Architectural changes to make more deployable, configureable, and upgradeable.

I am a big fan of Chartbuilder.  And please excuse any things I may have overlooked in researching how Chartbuilder works and how it should be used by other organizations.  I may come off negative here, but I am mostly just trying to discuss a possibility here.
Chartbuilder seems like it is meant to be used by other organizations.  Specifically I would think that the goal is to have organization install Chartbuilder, customize/configure for their needs, and then deploy somewhere. I personally don't think it's built in a way to do this effectively, and I am reluctant to use Chartbuilder in our organization since there is no real upgrade path or easy way to manage customizations/configuration.
This seems to be the current upgrade path for Chartbuilder, and this is not a very good/stable/usual way to upgrade.
https://github.com/Quartz/Chartbuilder/blob/master/docs/git-workflow-forks.md
To solve this, Chartbuilder should be thought of as a library, i.e. an NPM or Bower module that can be installed like npm install chartbuilder.  This would put a bit more work on the deployment side to set up an HTML page that called something like Chartbuilder({ el: ".cb-container" });.  But, given that you need to do npm install and other commands to get running with Chartbuilder, I don't see much difference in skill level for this.
Another step to achieve this would have Chartbuilder not need to go through a build process to be used, but instead comes as a built library.
Secondly, configuration is managed through changing source files.  This again, makes it difficult to upgrade.  Configuration should happen in a way that is outside the source files, either through a JSON file or options in a function.
JS configuration is also happening in multiple places.  It would be super nice to see/have this all in one place.
So, these sorts of changes would make it much easier to deploy, configure, upgrade, and ultimately invest in, at least in my opinion.
I don't think this is a perfect example, but this project gives a good idea of the architectural direction that I think would make Chartbuilder much easier to use from an organizational standpoint.
https://github.com/datanews/tik-tok

Also, for reference, these issues from a while back were aiming to move towards this architectural approach, though many things have changed since then.
https://github.com/Quartz/Chartbuilder/pull/48
https://github.com/Quartz/Chartbuilder/pull/103

Hey @zzolo, thank you for your thoughts, and sorry for taking so long to respond.
We're looking forward to discussing this—and agree on many points—but have been slammed with other Chartbuilder related stuff, so it's going to take a little while longer for us to give you a the proper response your comments and suggestions deserve.

Hey @zzolo, thanks for the feedback.
We are actively working toward doing this, and it's the right way to go. It's not totally clear what the exact API is going to be, but the end result is basically as you say, to distribute chartbuilder as a pre-compiled library and instantiate a new chartbuilder with whatever settings. Of course, for serious customization, one will have to edit the source files.
As a potential user of the chartbuilder library, may I ask what you would be looking to configure? Is there much beyond just basically theming the chart? Would you, for example, want to be able to add additional settings or have really granular control of the data parsing?
I am currently working on completely separating out the chart rendering code into its own library, which I think is a necessary first step in this direction. With that out of the way I think we can aim to have an API where a new chartbuilder is instantiated with default UI elements tied to a chart type, which change the chart model, but with the user able to either use defaults or customize how that data gets rendered.

So, the two big things to customize are the charts themselves and the interface.
Most of this should be handled in CSS and CSS is trivial to override, the key is just try not to make the default styles too specific.
The second part of the customization would be the actual markup/HTML.  This is a bit more complicated since there's no great way to override/include HTML natively with browsers, but what I like to do is just have the the markup in templates that can be overrided with config.  Tik Tok is a fine simple example; the template files get complied in the build process and bundled in the distributed version.
From my understanding, Chartbuilder uses some custom ways to handle theming for the charts.  I really like the ability to use em's.  But this means overriding these values has to be handled in JS or some way of parsing some CSS file that would then override in JS.  Highcharts is a really extreme example of style in JS config, but the idea is there.
So, then there are functional overriding/customizing.  These would be handled by hooks or events, depending on the need.  I think a hook or override of the data parsing function would be very helpful.  In projects, I just allow for a config that is a function that gets passed specific things.  For example:
Chartbuilder({
  el: ".cb-container",
  dataParser: function(data) {
    return data.map(String.toLowerCase);
  }
});

This could also be handled by JS events, like onParse, but I think a hook is a bit more appropriate since the goal is to alter data.  Either way doesn't matter that much.  More events could be included, like onRender, or onSave.
Things could get a bit more complicated if/when you separate out chart types.  One way I have handled this sort of scenario is to add a hook for the config basically, so someone could change any of the config based on  other config in code.  This basically allows for all other possibilities.
I don't have a great view of the Chartbuilder code or goals to say what is best, this is just what I have done in the past.


python3Packages.asyncio-dgram: 2.1.1 -> 2.1.2

Motivation for this change
https://github.com/jsbronder/asyncio-dgram/blob/master/ChangeLog
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 158408 run on x86_64-linux 1

10 packages built:

home-assistant-component-tests.guardian
home-assistant-component-tests.minecraft_server
mcstatus (python39Packages.mcstatus)
python310Packages.aioguardian
python310Packages.asyncio-dgram
python310Packages.mcstatus
python310Packages.pywizlight
python39Packages.aioguardian
python39Packages.asyncio-dgram
python39Packages.pywizlight


Upgrade Cassandra to 3.0.17

https://github.com/mesosphere/LCM/issues/15

I am closing this PR as it is a duplicate of Upgrade to #2736 (which has more comments).


How to add botplay and practice mode on pause menu again

Describe your problem here.
yea, i just want the botplay and practice mode buttons in the pause menu.
Are you modding a build from source or with Lua?
Source
What is your build target?
Linux
Did you edit anything in this build? If so, mention or summarize your changes.
No response

I already tried it and, it only gives a compiling error, so yeah, i don't think you can.
But you can maybe look up into the 0.4.2 source code and try to find a way to do so and avoiding errors.

Theese two items are now debug exclusive. Press 7 on the song you want botplay for and once the new mwnu loads press enter. You should have deez values again.

Theese two items are now debug exclusive. Press 7 on the song you want botplay for and once the new mwnu loads press enter. You should have deez values again.

man are you okay?
you have 3 spelling mistakes


chore(master): release 1.21.0

:robot: I have created a release beep boop
1.21.0 (2023-05-30)
Features

add backend example for spaces (18fd667)
add ingestv2 methods tests and examples (907cb80)
change options and add tags (8b42995)
remove examples from pipeline (0c7c6d8)
remove ingestv1 (a32d9b9)

Bug Fixes

fix dependencies (e7dc548)
update failing tests (82880bc)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/indykite/indykite-sdk-python/releases/tag/v1.21.0 :sunflower:


WIP: Revision of Overview

Edited overview document to address issue #35 and #12. Made the following additions:

Provided background on computational ethology; explained why it is useful
Explained why mice were used in experimentation
Gave a brief overview of the HCM system
Created a glossary and table of contents

@sicihuang @alannaiverson

Coverage remained the same at 42.484% when pulling 93b3ebe78ed100d6f019ff0ca853a1fb662e673e on jcpalumbo3:contributing-issue#35 into 667391019f48e9f70463d06653ba02ff2376f65e on berkeley-stat222:master.

@jcpalumbo3 @sicihuang @alannaiverson - has this been reviewed and is this ready to MRG?

Coverage remained the same at 42.484% when pulling f8d3f5ad6b18a30fcd26a7289ebc17a829d77561 on jcpalumbo3:contributing-issue#35 into 667391019f48e9f70463d06653ba02ff2376f65e on berkeley-stat222:master.

@jcpalumbo3 @alannaiverson @mingyungkim - this is now MRG'd


Upgrade sbt to 0.13.8

It finishes a move from sbt 0.13.6 to 0.13.8. This transition does not
include the change of deprecated AggressiveCompile to recommended IC or
MixedAnalyzingCompiler. This part will be covered by a separate ticket.
Fixes #1002481
Fixes #1002493

Supersedes #983


Fix FlutterError.onError in debug mode

Description
Based on https://github.com/flutter/flutter/pull/52728
This pr added a test
Related Issues
Fixes https://github.com/flutter/flutter/issues/47447
Fixes https://github.com/flutter/flutter/issues/44407
Tests
I added the following tests:
"ext.flutter.inspector.structuredErrors still report error to original on error"
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I signed the CLA.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[ ] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide

cc @jimmy-robert

@jacob314 I tried a different approach, let me know what do you think.


Deleting multiple GCP associated with PMID 36329257

User submitted 2 different submissions for this PMID: GCP000440 (2 studies) and GCP000443 (1 study).
They also submitted sumstats directly to pmid: 36329257 (3 studies with sumstat) (https://www.ebi.ac.uk/gwas/deposition/submission/637349737325c2000189ffca). GCST mentioned in the paper matches this submission.
Need to delete 2 GCPs; not sure if the GCSTs also needs to be deleted.

@Santhi1901 The GCP's have been deleted from DB


why a template, want to clone to my machine

Making this project a template just seems like a way to force someone to have a github account. Why?? Of course I have a github account otherwise I wouldn't be able to make this comment.  Every EULA signed lets companies sell any information they can find out about you. So this is my push back.
To clone this and other github templates off the github platform (say to your own machine) google: "clone github template" and follow the "[Is it possible to create a new git repository from a template]" link. I finished after the 'git commit -m "First commit" ' bullet. You will find gui_starter_template.git exists under the cpp-best-practices folder.
Is there are better way to circumvent github templates?
One good way would be for contributors NOT to use templates.

I don't understand what you're saying. This repository can be cloned normally, like any other GitHub-hosted one (or downloaded as a zip). Making it a template only makes it convenient for GitHub users to start their own repository from it.


Issue a warning or fail if a specific file given as an entry point does not exist

Simple knip.json:
{
  "entry": [
    "src/main.tsx!",
    "does-not-exist.ts",
  ]
}

does-not-exist.ts is a non-existent file.  When you run npm run knip, there is no warning or error even though does-not-exist.ts does not exist.
It would be great if Knip had a check that issued an error or warning if any file specified as an entry point did not exist (and maybe also for regex if the regex had no match).
For large projects that change over time, I would prefer to get an error that could be caught in CI so that I could update the knip.config when I make major changes that affect the entry points.

Duplicate of #331. Agreed it's useful, but I currently just don't have the bandwidth to work on such nice-to-haves. It also requires work on the console streamer. Might pick it up later down the road.


Bugfix 27

I took the stance of allowing migration folders to be version controlled - this way, when a pull is performed from master or develop, you know you're getting migrations in sync with your models.
Additionally, revamped the setup file to work well with the new protocol and to be more user friendly in general.

Resolves #27


Incorrect syntax near the keyword 'ORDER'.

Hey, I just came back to try your package after a while (from Azure AI). I switched like this:
//memoryBuilder.WithAzureAISearchMemoryDb(configuration["Azure:AISearch:Endpoint"]!, configuration["Azure:AISearch:APIKey"]!);
memoryBuilder.WithSqlServerMemoryDb(new SqlServerConfig
{
	ConnectionString = configuration.GetConnectionString("AIDataContext")!,
	EmbeddingsTableName = "KMEmbeddings",
	MemoryCollectionTableName = "KMMemoryCollections",
	MemoryTableName = "KMMemories",
	TagsTableName = "KMTags"
});

And ran the program. It runs fine, but when I start using it, it comes with:
fail: Microsoft.KernelMemory.Pipeline.InProcessPipelineOrchestrator[0]
      Pipeline start failed
      Microsoft.Data.SqlClient.SqlException (0x80131904): Incorrect syntax near the keyword 'ORDER'.
         at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
         at Microsoft.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
         at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
         at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
         at Microsoft.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString, Boolean isInternal, Boolean forDescribeParameterEncryption, Boolean shouldCacheForAlwaysEncrypted)
         at Microsoft.Data.SqlClient.SqlCommand.CompleteAsyncExecuteReader(Boolean isInternal, Boolean forDescribeParameterEncryption)
         at Microsoft.Data.SqlClient.SqlCommand.InternalEndExecuteNonQuery(IAsyncResult asyncResult, Boolean isInternal, String endMethod)
         at Microsoft.Data.SqlClient.SqlCommand.EndExecuteNonQueryInternal(IAsyncResult asyncResult)
         at Microsoft.Data.SqlClient.SqlCommand.EndExecuteNonQueryAsync(IAsyncResult asyncResult)
         at Microsoft.Data.SqlClient.SqlCommand.<>c.<InternalExecuteNonQueryAsync>b__210_1(IAsyncResult result)
         at System.Threading.Tasks.TaskFactory`1.FromAsyncCoreLogic(IAsyncResult iar, Func`2 endFunction, Action`1 endAction, Task`1 promise, Boolean requiresSynchronization)
      --- End of stack trace from previous location ---
         at KernelMemory.MemoryStorage.SqlServer.SqlServerMemory.CreateIndexAsync(String index, Int32 vectorSize, CancellationToken cancellationToken)
         at Microsoft.KernelMemory.Handlers.SaveRecordsHandler.SaveEmbeddingsAsync(DataPipeline pipeline, CancellationToken cancellationToken)
         at Microsoft.KernelMemory.Handlers.SaveRecordsHandler.InvokeAsync(DataPipeline pipeline, CancellationToken cancellationToken)
         at Microsoft.KernelMemory.Pipeline.InProcessPipelineOrchestrator.RunPipelineAsync(DataPipeline pipeline, CancellationToken cancellationToken)
         at Microsoft.KernelMemory.Pipeline.BaseOrchestrator.ImportDocumentAsync(String index, DocumentUploadRequest uploadRequest, CancellationToken cancellationToken)
      ClientConnectionId:0593855a-dbf3-4b5e-83b1-a2ff7c29731b
      Error Number:156,State:1,Class:15

Stacktrace displays your method: at KernelMemory.MemoryStorage.SqlServer.SqlServerMemory.CreateIndexAsync(String index, Int32 vectorSize, CancellationToken cancellationToken)
My code:
chatInputModel.DocumentId = Guid.NewGuid().ToString();

Document document = new Document(chatInputModel.DocumentId).AddFiles(filePaths);
await KernelMemory.ImportDocumentAsync(document, "document-uploads", cancellationToken: CancellationToken);

while (!await KernelMemory.IsDocumentReadyAsync(chatInputModel.DocumentId, "document-uploads", CancellationToken))
{
	await Task.Delay(100, CancellationToken);
}

Edit:
I tried downgrading nuget from 1.3.1 to 1.3.0, still the same issue.
Then I tried downgrading nuget from 1.3.0 to 1.1.4 and the issue disappeared.

I see that in your PR you have removed the ORDER clause. This is fundamental for COLUMNSTORE INDEX definition, so this isn't the correct solution.

I see that in your PR you have removed the ORDER clause. This is fundamental for COLUMNSTORE INDEX definition, so this isn't the correct solution.

The ORDER clause for CREATE COLUMNSTORE INDEX is only supported on SQL Server 2022 and newer.
I'm running SQL Server 2017 and removing the ORDER clause works for me. Perhaps you could do a SELECT @@version check before hand?
I note on the README you haven't mentioned which SQL Server version is a minimum requirement. If you don't support 2017 you should at least mention what minimum version is required.

@mamift @marcominerva , even if order clause is very important regarding performance. I updated the PR from @dmm-l-mediehus to check SQL server version before adding this clause to the tables creation.
In that way, this should work for all.


feat(STONEINTG-222) set euo to shell to fail on error early

set euo to shell to fail on error early
add handle_error to echo the error to task result TEST_OUTPUT

The hacbs-test image tag in the updated tasks file should be updated after https://github.com/redhat-appstudio/hacbs-test/pull/137 is merged.
Signed-off-by: Hongwei Liu<EMAIL_ADDRESS>

set -e changes behavior and few code parts must be udpated, commented inline.
Also, waiting for updated image, I'd like to do a deep testing as well

Yes, thanks for the reminder.

/retest

/retest

Python repo build test failed, we haven't updated this task, so either repo is broken or clone task
STEP-CLONE

+ '[' false = true ']'
+ '[' false = true ']'
+ CHECKOUT_DIR=/workspace/output/source
+ '[' true = true ']'
+ cleandir
+ '[' -d /workspace/output/source ']'
+ test -z ''
+ test -z ''
+ test -z ''
+ /ko-app/git-init -url=https://github.com/redhat-appstudio-qe/devfile-sample-python-basic.git -revision=symlink -refspec= -path=/workspace/output/source -sslVerify=true -submodules=true -depth=1 -sparseCheckoutDirectories=
{"level":"info","ts":1697192832.1426024,"caller":"git/git.go:178","msg":"Successfully cloned https://github.com/redhat-appstudio-qe/devfile-sample-python-basic.git @ cb167402672a0753e2f06bd9cb0ec588051a78fd (grafted, HEAD, origin/symlink) in path /workspace/output/source"}
{"level":"info","ts":1697192832.2145154,"caller":"git/git.go:217","msg":"Successfully initialized and updated submodules in path /workspace/output/source"}
+ cd /workspace/output/source
++ git rev-parse HEAD
+ RESULT_SHA=cb167402672a0753e2f06bd9cb0ec588051a78fd
+ EXIT_CODE=0
+ '[' 0 '!=' 0 ']'
+ printf %s cb167402672a0753e2f06bd9cb0ec588051a78fd
+ printf %s https://github.com/redhat-appstudio-qe/devfile-sample-python-basic.git
STEP-SYMLINK-CHECK

Running symlink check
The cloned repository contains symlink pointing outside of the cloned repository: /workspace/output/source/os-release-symlink

@mkosiarc can be this issue somehow related to your PR changing workdir?

But actually it clones https://github.com/redhat-appstudio-qe/devfile-sample-python-basic/commit/cb167402672a0753e2f06bd9cb0ec588051a78fd  which is branch specific for testing failure  when symlink is out of repo, why is this used in tests?

Nevermind what I wrote before, this is the failure
  failed to get cosign result for image quay.io/redhat-user-workloads/build-templates-e2e/test-app-570/devfile-sample-python-basic-cwbo:build-a3c96-1697192775@sha256:6fa1eb2ec5ef2411a2e57af23d1baff30c935a6e0e4312f60aed3d27f0ad6796: failed to find cosign results for image quay.io/redhat-user-workloads/build-templates-e2e/test-app-570/devfile-sample-python-basic-cwbo:build-a3c96-1697192775@sha256:6fa1eb2ec5ef2411a2e57af23d1baff30c935a6e0e4312f60aed3d27f0ad6796: error when getting attestation tag: cannot get manifest digest from quay.io/redhat-user-workloads/build-templates-e2e/test-app-570/devfile-sample-python-basic-cwbo:sha256-6fa1eb2ec5ef2411a2e57af23d1baff30c935a6e0e4312f60aed3d27f0ad6796.att image. response body: {"tags": [], "page": 1, "has_additional": false}

  Creating Pipeline "verify-enterprise-contract-run-2jrhv"
  Waiting for pipeline "verify-enterprise-contract-run-2jrhv" to finish
  [FAILED] in [It] - /github.com/redhat-appstudio/e2e-tests/tests/build/build_templates.go:319 @ 10/13/23 10:29:40.747
• [FAILED] [32.475 seconds]
[build-service-suite Build templates E2E test] HACBS pipelines when the container image for component with Git source URL https://github.com/redhat-appstudio-qe/devfile-sample-python-basic is created and pushed to container registry [It] verify-enterprise-contract check should pass [build, HACBS, pipeline, sbom, slow, build-templates-e2e]
/github.com/redhat-appstudio/e2e-tests/tests/build/build_templates.go:254

  [FAILED] Expected
      <[]v1beta1.TaskRunResult | len:1, cap:4>: [
          {
              Name: "TEST_OUTPUT",
              Type: "string",
              Value: {
                  Type: "string",
                  StringVal: "{\"timestamp\":\"1697192977\",\"namespace\":\"\",\"successes\":1,\"failures\":0,\"warnings\":1,\"result\":\"WARNING\"}",
                  ArrayVal: nil,
                  ObjectVal: nil,
              },
          },
      ]
  To satisfy at least one of these matchers: [%!s(*matchers.ContainElementsMatcher=&{[0xc001705140] [0xc001705140]}) %!s(*matchers.ContainElementsMatcher=&{[0xc001705180] [0xc001705180]})]
  In [It] at: /github.com/redhat-appstudio/e2e-tests/tests/build/build_templates.go:319 @ 10/13/23 10:29:40.747

Root cause is that test expects success
ContainElements(tekton.MatchTaskRunResultWithJSONPathValue(constants.TektonTaskTestOutputName, "{$.result}", `["SUCCESS"]`)),

but EC returns WARNING
STEP-SUMMARY

{
  "timestamp": "1697192977",
  "namespace": "",
  "successes": 1,
  "failures": 0,
  "warnings": 1,
  "result": "WARNING"
}

EC detail
  warnings:
  - metadata:
      code: slsa_source_correlated.source_code_reference_provided
      collections:
      - minimal
      - slsa1
      - slsa2
      - slsa3
      - redhat
      description: Warn if the expected source code reference is not provided.
      solution: Provide the expected source code reference in inputs.
      title: Source code reference provided
    msg: Expected source code reference was not provided for verification

/retest

/retest

Root cause is that test expects success
ContainElements(tekton.MatchTaskRunResultWithJSONPathValue(constants.TektonTaskTestOutputName, "{$.result}", `["SUCCESS"]`)),

but EC returns WARNING
STEP-SUMMARY

{
  "timestamp": "1697192977",
  "namespace": "",
  "successes": 1,
  "failures": 0,
  "warnings": 1,
  "result": "WARNING"
}

EC detail
  warnings:
  - metadata:
      code: slsa_source_correlated.source_code_reference_provided
      collections:
      - minimal
      - slsa1
      - slsa2
      - slsa3
      - redhat
      description: Warn if the expected source code reference is not provided.
      solution: Provide the expected source code reference in inputs.
      title: Source code reference provided
    msg: Expected source code reference was not provided for verification

Thanks very much for debugging it!


Fix interrupt kernel for interactive window

Discussed with @DonJayamanne  and while https://github.com/microsoft/vscode-jupyter/pull/7067 is the right fix, it's too risky for the recovery build and would also break the webview interactive window). Since #6983 is a recovery build candidate, this PR is a temporary workaround for the root cause (which is that the interactive window uses executeObservable and that results in the IKernel not being aware of cells executed that way when doing IKernel.interrupt)

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-2021.08@63d2d4b). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release-2021.08   #7070   +/-   ##
=================================================
  Coverage                   ?     65%
=================================================
  Files                      ?     410
  Lines                      ?   28546
  Branches                   ?    4267
=================================================
  Hits                       ?   18581
  Misses                     ?    8329
  Partials                   ?    1636


Impact of ExpireTimespan when in a Hybrid flow? (question)

I'm wondering about the impact of the ExpireTimespan setting in the MVC example here:
https://github.com/IdentityServer/IdentityServer4.Samples/blob/release/Clients/src/MvcHybrid/Startup.cs#L55
What does this setting actually do?
(To be clear, the problem is not IdentityServer here but the sample could be a bit misleading.)
I think most readers expect the Cookie expire to be 60 minutes, but it actually seems to be set to session length, not 60 minutes. The result is that if I close my browser and then revisit my MVC site, I'm not cookie authenticated but instead a redirect to IdentityServer happens.
I stumbled upon this problem with using IdentityServer3 but I think this applies to v4 as well. After some research and trying to find others with the same issue, I found this blog post that explains this in great detail (and how to fix it). http://www.jerriepelser.com/blog/managing-session-lifetime-aspnet-core-oauth-providers/

What does this setting actually do?

It controls the cookie lifetime. There's also a sliding setting as well. This is just how the cookie middleware works. I'm missing the point of your question/comment.

Suppose I set ExpireTimespan to 7 days. My assumption then is that my MVC application will inspect the cookie and say "yes, you are authenticated" for the next 7 days. So it shouldn't require a round-trip to IdentityServer to authenticate the user.
But for me, my MVC application redirects me to IdentityServer every time my browser session has expired. (And IdentityServer authenticates me and redirects back to the MVC application). So it seems that the ExpireTimespan has no effect.
Am I misunderstanding what effect that setting has? The first part of the blog post I linked explains my question:

I recently received a support request from a customer regarding the session lifetime once a user has signed in using Auth0 as they wanted the users to remain logged in across browser sessions. For our Auth0 integration with ASP.NET Core we have written no special middleware and instead rely on the standard OpenID Connect or OAuth2 middleware for authenticating users in MVC applications.

My initial response to the user was to simply configure the cookie middleware and specify an ExpireTimeSpan:
app.UseCookieAuthentication(new CookieAuthenticationOptions     {         AutomaticAuthenticate = true,         AutomaticChallenge = true,         ExpireTimeSpan = TimeSpan.FromDays(7)     });

Turns out that does not do much. Even when specifying that option the cookie still only remains active for the duration for the session

But for me, my MVC application redirects me to IdentityServer every time my browser session has expired.

If you want a persistent cookie, then you need to set the IsPersistent on the AuthenticationProperties at login time. That's just how the cookie middleware from Microsoft works.

Ok, thanks for the clarification. I think I need to look into this a bit more.
To me, the result with or without the ExpireTimespan set in the sample is the same, but I'll let it go for now.


Required field bug

class EdulevelTemplate(db.Model):
    __tablename__ = "edulevel_template"

    id = db.Column(db.Integer, primary_key=True)
    title = db.Column(db.String, nullable=False)
    tuition_template_id = db.Column(db.Integer, db.ForeignKey("tuition_template.id"), nullable=False)
    tuition_template = db.relationship("TuitionTemplate")
    objectives = db.relationship("TuitionTemplate")

Here, Objectives should not be required. But they are by default. AdminView is empty.
In conjunction with this: https://github.com/flask-admin/flask-admin/issues/2120 - makes things really complicated.

    tuition_template = db.relationship("TuitionTemplate")
    objectives = db.relationship("TuitionTemplate")

was bad copy-paste


Support for Kubernetes 1.29

What this PR does / why we need it:
Adding support for Kubernetes 1.29.
Which issue(s) this PR fixes:

Fixes #
What type of PR is this?

/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

Support for Kubernetes 1.29

Documentation:

TBD

/test all

/hold requires https://github.com/kubermatic/operating-system-manager/pull/343

/test all

/test pull-machine-controller-e2e-vsphere

/test all

/retest

/unhold

/approve
/lgtm


Updating apiEndpoints results in incomplete x509 certificate

Adding an additional apiEndpoint after cluster creation does not add new DNS name to controller's x509 certificate.
Steps to Reproduce

Create cluster with one apiEndpoint called original-api-endpoint.example.com
Update cluster adding an additional apiEndpoint called new-api-endpoint.example.com

Update node pool to use this new apiEndpoint

Expected Result
Worker connects successfully to the new apiEndpoint.
Actual Result
Worker cannot connect to new apiEndpoint as the controller's x509 certificate does not include new-api-endpoint.example.com.
Example error message from worker node after switching to newly created apiEndpoint:
E0420 15:05:56.242755       1 reflector.go:201] k8s.io/kubernetes/pkg/proxy/config/api.go:49: Failed to list *api.Endpoints:
Get https://new-api-endpoint.example.com/api/v1/endpoints?resourceVersion=0:
x509: certificate is valid for kubernetes, kubernetes.default, kubernetes.default.svc, kubernetes.default.svc.cluster.local, original-api-endpoint.example.com, not new-api-endpoint.example.com

Did you run render credentials to regenerate the certs? It's not explicit in the config but that needs to be done to add the new names.

I did not run render credentials when updating - that was the issue 😅  Thank you for your quick and helpful response!


Big problem!

I tried to sync with juliabox with github and files are gone !
How can I recover?

dup of #375

how to solve?
My notebooks are very important

if I tried to synchronize the account " juliatutorialbr " the juliabox with the account " jmarcellopereira " ( this ) the github

Unfortunately, it is difficult to retrieve the files back.
I'll give it a try though, and let you know offline.

Ok , I await contact. I am very grateful for the help

Closing. We were able to recover most files.
The core issue is open still.


Fixes #11763: Switch to cats ecosystem

https://www.rudder-project.org/redmine/issues/11763

OK, merging this PR


MudMenu triggering other menus below

Bug type
Component
Component name
MudMenu
What happened?
Hello,
I'm currently facing a problem when using the MudMenu in mobile phones.
Touch function is not working as expected since it's activating the menu of other card's that reside behind it.
I tried to add @ontouchend:stopPropagation to the MudMenuItem but the problem still occurs.
One thing that i notice wile testing is that this issue only happen whenever the page reloads as WebAssembly
https://github.com/MudBlazor/MudBlazor/assets/85495887/cc756d15-6438-41e9-877d-848db820402f
My code
<MudMenu Class="w-100 h-100" AnchorOrigin="Origin.TopRight" TransformOrigin="Origin.CenterRight" Dense="true">
    <ActivatorContent>
        <MudCard Class="border-l-4 border-solid mud-border-success w-100 h-100" Elevation="25">
            <MudCardContent>
                <MudText<EMAIL_ADDRESS>- @task.CustomerName</MudText>
                <MudText<EMAIL_ADDRESS>            </MudCardContent>
        </MudCard>
    </ActivatorContent>
    <ChildContent>
        <MudMenuItem IconColor="Color.Success"<EMAIL_ADDRESS>OnClick="(()=>Start(task))" OnTouch="(()=>Start(task))">Start Timer</MudMenuItem>
        <MudDivider />
        <MudMenuItem IconColor=" Color.Error"<EMAIL_ADDRESS>OnClick="(()=>OpenScan(task.MainTaskId))" OnTouch="(()=>OpenScan(task.MainTaskId))" Disabled="true">Scan Material</MudMenuItem>
        <MudDivider />
        <MudMenuItem IconColor="Color.Primary"<EMAIL_ADDRESS>OnClick="(()=>OpenPicture(task.MainTaskId))" OnTouch="(()=>OpenPicture(task.MainTaskId))">Take Picture</MudMenuItem>
        <MudDivider />

        @if (task.CustomerGmaps != null || task.ProjectGmaps != null)
        {
            <MudMenuItem IconColor="Color.Warning"<EMAIL_ADDRESS>OnClick="(()=>OpenDirections(task))" OnTouch="(()=>OpenDirections(task))" Disabled="false">Directions</MudMenuItem>
        }
        else
        {
            <MudMenuItem IconColor="Color.Warning"<EMAIL_ADDRESS>OnClick="(()=>OpenDirections(task))" OnTouch="(()=>OpenDirections(task))" Disabled="true">Directions</MudMenuItem>
        }
        <MudDivider />
        <MudMenuItem IconColor="Color.Info"<EMAIL_ADDRESS>OnClick="(()=>MoreInfo(task.MainTaskId))" OnTouch="(()=>MoreInfo(task.MainTaskId))">More Info</MudMenuItem>
    </ChildContent>
</MudMenu>

Expected behavior
Touch should not trigger other menus
Reproduction link
https://try.mudblazor.com/snippet/QacyEymHoeXhkgsv
Reproduction steps

Create Multiple MudMenus activated by cards
Order them as column
Click on the cards
...

Relevant log output
No response
Version (bug)
6.19.1
Version (working)
No response
What browsers are you seeing the problem on?
Chrome
On which operating systems are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

#8492 may resolve this. Can you compile and test your code on the dev branch? Alternatively a preview for v7 should be available in the next week or so.

Just tested on the dev branch and it looks like it's fixed.
Thank you!


Add test for expand_from_images in test_analyze_docker_dockerfile.py

Describe the Feature
Add a test in tests/test_analyze_docker_dockerfile.py named testExpandFromImages that will test the functionality of the expand_from_images function. In order to implement this a few things will have to happen first.

Create base OS and upload to Tern dockerhub repository
Write a new Dockerfile that uses above base OS as base image.

Use Cases
This will hep increase the test code coverage.
Implementation Changes
See description.

@rnjudge  I would like to take up this issue

@abhaykatheria Before you can work on this issue we need to create and upload a base OS to Tern's dockerhub repo. This will take a little time as we are trying to focus on the next release in a few weeks. Once the necessary resources are in place for this issue to be worked on, I will followup to see if you are still interested :)

I was actually thinking of making my own docker image and uploading it to docker hub to temporarily test this but I got busy. So when I will test this Ill tell  you the results.
Happy Holi.

Here's what i did
I made a docker file called Debian
FROM abhaykatheria/tern_test:latest

in test_analyze_docker_dockerfile.py
i added this test
def testExpandFromImages(self):
        dfobj = dockerfile.get_dockerfile_obj(self.debian)
        dockerfile.expand_from_images(dfobj)
        debian_base_image_with_digest = 'abhaykatheria/tern_test@sha256:e985f2e9c18edc21a9036bb3de4114d4c5d52a5d4ab59ce4ba9bbf0f484049cc'
        self.assertEqual(dfobj.parent_images[0],debian_base_image_with_digest)

The test is working fine on my image
:)

the image is quiet big so i will overwrite with a small alpine image.

Hello @abhaykatheria, the tests themselves look good and achieve the main purpose of this issue. The issue right now is with the base image. We do not want to push an image to Tern's dockerhub repo until we have an SBoM and sources available for it. This will be difficult for Alpine and Debian images. Ideally, we would create our own basic linux OS, hence my comment a few days ago :) We appreciate your interest in this and once we have this base OS available, this issue is all yours to work on!


getting latest version from CDN

I am loading via the CDN URLs. All of the examples seem to point to a specific version of the JS + CSS files (3.13.4). like this:
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/jodit/3.13.4/jodit.es2018.min.css"/>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jodit/3.13.4/jodit.es2018.min.js"></script>

Is there a set of URLs that will always grab the latest version? Something like this?
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/jodit/latest/jodit.es2018.min.css"/>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jodit/latest/jodit.es2018.min.js"></script>

Unfortunately, this is a free service and does not provide such a link.


yarn manifest出现错误?

你好,我按照这边提供的命令初始化该项目,但是yarn install之后到了yarn manifest生成文件时出现问题,请问能帮我看一下这是有什么问题导致的吗?

user [yarn manifest] this commed does face the same wrong as usual

I presume you're saying that the yarn manifest command does not work on Windows?
It'd be great if you could translate your bug summary to English ^^..

From your screenshot, I think you ran the yarn manifest command from the incorrect folder.
Could you try the commands as per our README: Installing fbt?

(attached screenshot for posterity)

从你的截图来看，你好像跑的命令是yarn manifests, 后边多了一个s。


Directly-linked audio files have a duration of 0:00:0

Hello, for reasons unknown to me, the bot displays a duration of 0:00:0 if I play an MP3, flac, etc directly from a website. It also outputs [mp3 @ 0x1f424c0] Estimating duration from bitrate, this may be inaccurate into the console. This doesn't happen at all with audio files that are downloaded from sites like YouTube, SoundCloud, etc. It only happens when I directly play an audio file.
if it matters, im using the review branch of the bot on a vps with ubuntu server 16.04.2 and python 3.5.2. IIRC, it did the same thing with the master branch. Thanks for reading! :D i did see something in player.py talking about using ffprobe to find the duration

Nevermind, managed to fix this by using ffprobe to check the duration of the downloaded files.


lv_group_set_style_mod_cb: Can I use animations?

Hi, I'm using the lv_group_set_style_mod_cb functionality in order to change the style of a given focused object in a group.
I was wondering if it would be possible to apply style animations to the focused object using this callback.

@kisvegabor

Unfortunately, you couldn't. The style_mod callback changes the style on the fly when it's required.
What you can do is to get the current time with lv_tick_get() in your style_mod callback. and set some parameters accordingly. E.g. set the background color dynamically. But in this case, you need to create an lv_task which continuously invalidates the focused object lv_obj_invalidate(...) to refresh it with the new style.

In the past few days LittlevGL's Forum has launched to discuss questions there. See this Announcment.
If the issue still persists please open a topic for it on the Forum.


First stab at auto-parsing GraphBLAS.h for cffi

create_headers.py is kind of a combination of high-tech and low-tech.  The high tech part is running the C preprocessor (hard-coded to gcc atm) and parsing with pycparser.  Most of it is the low tech, which is kind of just brute force munging to have a nicer organization and nicer diffs.  I've run this against older versions of GraphBLAS.h, and it's been rock-solid.
Closes #5.  I think this this satisfies all my goals from #5.  It is 99.8% fully automatic, and it should fail loudly and clearly for the 0.02% that may fail, and remediation should (hopefully) be painless.  The generated h files should be approachable, so take a look!
All grblas tests can pass when built using suitesparse/graphblas/suitesparse_graphblas.h and suitesparse/graphblas/source.c.  The only things missing from the cffi .lib are {'GxB_cuda_calloc', 'GxB_cuda_free', 'GxB_cuda_malloc'}, which are ignored because they're not made public via extern.
Note that I continued this PR from #4.

You can ignore the GxB_cuda_malloc and related functions.  Those are draft
methods, and not intended to be used yet.  It turns out that we actually
need different functions to use CUDA and the Rapids Memory Manager inside
SuiteSparse:GraphBLAS, so the GxB_cuda_malloc/free/etc functions will need
to change anyway.
On Fri, Apr 9, 2021 at 12:27 AM Erik Welch @.***> wrote:

create_headers.py is kind of a combination of high-tech and low-tech. The
high tech part is running the C preprocessor (hard-coded to gcc atm) and
parsing with pycparser. Most of it is the low tech, which is kind of just
brute force munging to have a nicer organization and nicer diffs. I've run
this against older versions of GraphBLAS.h, and it's been rock-solid.
Closes #5
https://github.com/GraphBLAS/python-suitesparse-graphblas/issues/5. I
think this this satisfies all my goals from #5
https://github.com/GraphBLAS/python-suitesparse-graphblas/issues/5. It
is 99.8% fully automatic, and it should fail loudly and clearly for the
0.02% that may fail, and remediation should (hopefully) be painless. The
generated h files should be approachable, so take a look!
All grblas tests can pass when built using
suitesparse/graphblas/suitesparse_graphblas.h and
suitesparse/graphblas/source.c. The only things missing from the cffi .lib
are {'GxB_cuda_calloc', 'GxB_cuda_free', 'GxB_cuda_malloc'}, which are
ignored because they're not made public via extern.
Note that I continued this PR from #4
https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/4.
You can view, comment on, or merge this pull request online at:
https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/6
Commit Summary

First stab at auto-parsing GraphBLAS.h for cffi

File Changes

M .gitignore
https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/6/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
(5)
M suitesparse/graphblas/build.py
https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/6/files#diff-6f842776e4d8dd663f8a2d365a5087ff571c719a48a8793fb0b6518f471422da
(12)
A suitesparse/graphblas/create_headers.py
https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/6/files#diff-18e66b050009218ea290e4f277b5fc6b20c2e82e3511f472eac53b6e7ce5dacb
(632)
A suitesparse/graphblas/source.c
https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/6/files#diff-ef6ffad16e8260ceeeb848570120123b21cb85e5da2f3be543d67fc6ef5d7172
(8)
A suitesparse/graphblas/suitesparse_graphblas.h
https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/6/files#diff-bf0b139d1230a3d0eebfdb7d11591d3b56f828433622ec9adada15c1cc336e83
(3241)
D suitesparse/graphblas/suitesparse_graphblas_4.0.3.h
https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/6/files#diff-02532c1cb4d1c5cca284840500822fdf94d3f18c36546ff560419a2d02c19b18
(8641)
A suitesparse/graphblas/suitesparse_graphblas_no_complex.h
https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/6/files#diff-2bb6b5031deef4ab20219028c8d344e47012b2e46bab54f05c671207601aee50
(3029)
D suitesparse/graphblas/suitesparse_graphblas_no_complex_4.0.3.h
https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/6/files#diff-24057ae9a57c2f52509674e1241aeeeb54f734fc1cb5e11b83f90ed50d0cce1d
(8638)

Patch Links:

https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/6.patch

https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/6.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/6, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AEYIIOO4SYBEWFVH77YNFRDTH2F3ZANCNFSM42UIMQXQ
.


Not an issue, just a comment - node.js 12.17 introduced a relevant (experimental) API

See https://nodejs.org/docs/latest-v16.x/api/module.html#source-map-v3-support.
import module from 'node:module';
const sourceMap = module.findSourceMap('./my-file.js');
const position = sourceMap.findEntry(1, 1);
// run file with the `--enable-source-maps` flag

Of course, it is experimental, and I don't know if it works with CommonJS scripts.

Feel free to close.

Fancy
Maybe can add a doc for this and put in the readme?
We are open for PRs 😎


SpecPriv Peephole optimizations bug in Release mode

Peephole optimization 3 tries to specialize the size of private read and write. However, in the release mode,
tail call void @__specpriv_private_write_range(i8* %126, i32 8) #6 is optimized to
call void @__specpriv_private_read_rangeb(i8* %130).
It is probably because all functions in liberty/include/liberty/Speculation/Api.h return pointer to a static object FunctionCallee. To address this issue, we need to change the Api.h to return FunctionCallee object directly.

In general, maybe we should do a sanitizer pass of CPF to check for all bugs like this.


ZEPPELIN-1597. Change cdh spark/hadoop dependency to apache spark/hadoop

What is this PR for?
I see several times of travis failure due to downloading cdh spark/hadoop for livy interpreter. This may be due to cdh repository issue, so in this PR I change it to apache spark/hadoop.
What type of PR is it?
[Improvement]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1597

How should this be tested?
No test added
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@prabhjyotsingh @felixcheung Please help review.

LGTM. I will merge it as hotfix if there is no more comment.

@minahlee yes please merge it asap this a total war zone here


SassError: SassError: Undefined mixin. sass variable or mixins not getting identified in Angular 12 scss application

SassError: SassError: Undefined mixin. sass variable or mixins not getting identified in Angular 12 scss application.
My _mixins.scss file content:
@mixin horizontal-box {
display: flex;
flex-direction: row;
}
@import url("../app/_mixins.scss");
.result-box {
@include horizontal-box;
}
this is a freshly created angular 12 application with commmand: ng new angular12app
it straight away gave the error on command: ng serve
./src/app/app.component.scss - Error: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: SassError: Undefined mixin.
╷
4 │ @include horizontal-box;
│ ^^^^^^^^^^^^^^^^^^^^^^^
╵
src\app\app.component.scss 4:3 root stylesheet
I lost 3 hours on this issue. Did not expect this from Angular.
Submitting an Issue
version of Angular CLI used: Angular 12.
Angular.json:
{
"$schema"<EMAIL_ADDRESS>"version": 1,
"newProjectRoot": "projects",
"projects": {
"angular12": {
"projectType": "application",
"schematics": {
"@schematics/angular:component": {
"style": "scss"
},
"@schematics/angular:application": {
"strict": true
}
},
"root": "",
"sourceRoot": "src",
"prefix": "app",
"architect": {
"build": {
"builder": "@angular-devkit/build-angular:browser",
"options": {
"outputPath": "dist/angular12",
"index": "src/index.html",
"main": "src/main.ts",
"polyfills": "src/polyfills.ts",
"tsConfig": "tsconfig.app.json",
"inlineStyleLanguage": "scss",
"assets": [
"src/favicon.ico",
"src/assets"
],
"styles": [
"src/styles.scss"
],
"scripts": []
},
"configurations": {
"production": {
"budgets": [
{
"type": "initial",
"maximumWarning": "500kb",
"maximumError": "1mb"
},
{
"type": "anyComponentStyle",
"maximumWarning": "2kb",
"maximumError": "4kb"
}
],
"fileReplacements": [
{
"replace": "src/environments/environment.ts",
"with": "src/environments/environment.prod.ts"
}
],
"outputHashing": "all"
},
"development": {
"buildOptimizer": false,
"optimization": false,
"vendorChunk": true,
"extractLicenses": false,
"sourceMap": true,
"namedChunks": true
}
},
"defaultConfiguration": "production"
},
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"configurations": {
"production": {
"browserTarget": "angular12:build:production"
},
"development": {
"browserTarget": "angular12:build:development"
}
},
"defaultConfiguration": "development"
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "angular12:build"
}
},
"test": {
"builder": "@angular-devkit/build-angular:karma",
"options": {
"main": "src/test.ts",
"polyfills": "src/polyfills.ts",
"tsConfig": "tsconfig.spec.json",
"karmaConfig": "karma.conf.js",
"inlineStyleLanguage": "scss",
"assets": [
"src/favicon.ico",
"src/assets"
],
"styles": [
"src/styles.scss"
],
"scripts": []
}
}
}
}
},
"defaultProject": "angular12"
}
version of Angular DevKit used: "@angular-devkit/build-angular": "~12.0.1",
3rd-party libraries and their versions: none
Most importantly - a use-case that fails:
Step 1:
create a file: _mixin.scss in the root folder: ->
content of the _mixin.scss
@mixin horizontal-box {
display: flex;
flex-direction: row;
}
Step 2:
import the mixin to app.component.scss:
@import url("_mixin.scss");
.result-box {
@include horizontal-box;
}
Step 3: Run ng serve from console:
Error:
./src/app/app.component.scss - Error: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: SassError: Undefined mixin.
╷
4 │     @include horizontal-box;
│     ^^^^^^^^^^^^^^^^^^^^^^^
╵
src\app\app.component.scss 4:5  root stylesheet
at Object.callback (D:\PROJECTS\Angular12\angular12\node_modules\sass-loader\dist\index.js:54:16)
at Worker. (D:\PROJECTS\Angular12\angular12\node_modules@angular-devkit\build-angular\src\sass\sass-service.js:123:25)
at Worker.emit (node:events:365:28)
at MessagePort. (node:internal/worker:241:53)
at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:461:20)
at MessagePort.exports.emitMessage (node:internal/per_context/messageport:23:28)
Hopefully You understood what to do. If not ping back, I will respond.
I have attached the source:
app.zip
In case, You have this feeling that , You do not have the source.  Kindly request You not to close this thread on Your own

@digish777, @import url is not a valid syntax to load Sass files.
See https://sass-lang.com/documentation/at-rules/import. Also as mentioned in the link provided @import is in deprecation phase.
- @import url("../app/_mixins.scss");  // incorrect
+ @import "../app/_mixins.scss"; // deprecated
+ @use "../app/_mixins.scss"; // current

NB: when using @use you need to reference the mixin from a namespace.
@use "../mixin";

.result-box {
    @include mixin.horizontal-box;
}

@use "../mixin" as m;

.result-box {
    @include m.horizontal-box;
}

See: https://sass-lang.com/documentation/at-rules/use

@alan-agius4 apologise for opening so many issue. or as per You spamming.
This working solution, I got :
@use "../mixin";
.result-box {
@include mixin.horizontal-box;
}
@use "../mixin" as m;
.result-box {
@include m.horizontal-box;
}
after opening 3 issues. If You would have pointed this out in the very first time instead of closing the issue straight away. I would not have opened multiple issue for a same issue.
Thanks.


ISSUE-157: (doc) key, value contruction error fix

Summary
Fix issue #157, where key-value construction got an error.
Checklist

[x] If docs where changed, run ./bin/configlet generate to ensure all documents are properly generated.
[ ] CI is green

Closes #157

Thanks for the fix!

Thanks for finding this @dariosena
The concepts/basics/about.md file also contains the bug, if you could add another commit.
There is lots of duplication in the concept docs.


[ZEPPELIN-4502] Adjust global styles and theming the visualization

What is this PR for?
Adjust global styles and theming the visualization
What type of PR is it?
[Feature]
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4502
How should this be tested?
Not applicable
Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Thanks @hsuanxyz LGTM


#Requires doesn't require separation

Steps to reproduce
#requires-modules psworkflow
#requiresCrazyThings -psed desktop

The #Requires directive doesn't seem to require some kind of separation from its keyword to the next token, but not providing that separation causes an error anyway.
PS C:\> #requiresCrazyThings -psed desktop
At line:1 char:2
+ #requiresCrazyThings -psed desktop
+  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Cannot process the #requires statement because it is not in the correct format.
The #requires statement must be in one of the following formats:
 "#requires -shellid <shellID>"
 "#requires -version <major.minor>"
 "#requires -psedition <edition>"
 "#requires -pssnapin <psSnapInName> [-version <major.minor>]"
 "#requires -modules <ModuleSpecification>"
 "#requires -runasadministrator"
+ CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
+ FullyQualifiedErrorId : ScriptRequiresInvalidFormat

PS C:\>

I am just not sure this is right.  A inexperienced user could stumble across this by accident thinking he's just entering a comment.   I have seen plenty of reports already of new users who are confused when the editor starts highlighting items in a comment, turning them in as bug reports.

Isn't the error message helpful ?

More fundamentally, the issue is that it is problematic that the syntactic form of a comment was chosen to implement "preprocessor directives" (statements evaluated at script/module parse time), which invites confusion.
I suggest either reframing this issue accordingly or creating a new issue to suggest a distinct syntax form.

I just think that #requires should be held to the same standard as any other keyword, it must adhere to delimiter standards to be acknowledged.  #requiresCrazyThings does not meet the delimiter requires anywhere else in PowerShell for a keyword of #requires.  Everywhere else, the token would be #requiresCrazyThings and that is not the same as #requires.  Because it doesn't match the required special preprocessor directive keyword, the line should be ignored, not produce an error for an 'almost' attempt.
I do realize that this is a case of error one way or the other, but I think because its based on a comment marker, the error should be in the direction of ignoring anything that isn't exactly right.   Its a comment, and instead let the user figure out why his very badly malformed #requires directive isn't working.  If the keyword token has met the standard delimiter and the rest of the syntax is in error, then display an error.
Background, I am working on a PR over at PowerShell/EditorSyntax, https://github.com/PowerShell/EditorSyntax/pull/156, and trying to make sure it mostly matches what PowerShell really expects.

I do realize that this is a case of error one way or the other, but I think because its based on a comment marker, the error should be in the direction of ignoring anything that isn't exactly right.

On purely technical grounds I'd agree: if something isn't a syntactically valid #requires directive, it shouldn't be treated as one.
However, falling back to the other construct that shares the #-prefixed syntax - a comment - means that what the user may have intended to be a #requires directive will be quietly ignored.
My sense is that this quiet ignoring would be worse than the current behavior, as a script author may not notice that a directive they meant to put in place wasn't.
If they didn't mean to create a #requires directive and #requiresCrazyThings was actually meant to be a comment, then at least the error message will alert them to how their comment is  being interpreted as something else - and working around the problem - should it ever arise - is trivial: simply put a space between # and requires.
As simple as that workaround is - and if we stick with the current behavior the error message should be amended to suggest it - it highlights the fundamental problem:
Comment syntax should never have been overloaded to serve as directive syntax too, and a proper solution requires a distinct syntax form for directives.

In general I tend to lean towards always having a leading space on my comments following the # symbol, so I guess I've never run into this as an issue. I agree, though, that using the standard comment syntax as a directive is probably not the best.
I'm sure it was intended to reflect back on C#'s preprocessor-directive syntax, but that might have been a bad idea.
Not sure if it can really be changed now, though? I guess it wouldn't be the end of the world, as changing it would essentially mean that all current #Requires statements are just... comments. I guess it'd be OK?
Not sure what we could really use instead. Any thoughts on viable alternatives @mklement0? 🤔

The using directives already are bona fide statements (though, unlike the #requires directives, they must be at the top of the script).
using module even more or less does the same thing as #requires -module (the former additionally loads PS classes).
using isn't really the right name for the other #requires directives (using runasadministrator?), however, so perhaps a separate requires keyword is called for.
I'm pretty sure that an RFC is needed to propose something of that magnitude.
In the current situation, my recommendation is to merely amend the error message so that if someone writes #requiresCrazyThings or even #requires time to process (where #requires is technically a valid keyword), they'll see something along the lines of "If you meant to write a comment instead, put a space between '#' and the word 'requires'" after the current message.

A couple thoughts:

The reasoning for using a comment for a directive was probably because of the low usage of the keyword.  In most languages, a keyword must be reserved in its entirety, and in this case, to only one purpose.  Using a comment marker eliminates that need to reserve the word from any other use.
A second reason, is that, new concepts can be added without breaking backwards compatibility when they serve minor value.  Not saying that's what is going on here, but another valid reason they exist.  Thinking of it that way, comment based directives should really only be considered minor, which is not really what requires does, except that if the requires directive is skipped, eventually an error will occur.   Its just that by then, the damage might already have been done.  A properly written program would have damage control.  In this case, requires could be just a easy way out of writing damage control.
My main concern, is that there is a lack of a requirement for a delimiter between the keyword and its arguments, and further agitated that the example of a seemingly valid construct for an argument is not accepted without a delimiter, when in fact one is not required for the keyword itself. ie #requires-modules psworkflow still returns an error, while anywhere else in PowerShell, the token would been decoded as  requires-modules and that wouldn't match requires.  I unfortunately do not have enough experience with other languages that do this (commented directives) to know how they behave, but the behavior seems odd.
usings requirement to be the first line(s) is solution to the reservation of a keyword, albeit with its own restrictions.  using namespace could just as well as been a comment directive, as its not critical (it just makes the writer type longer name spaces).

In actuality, most of the work of using or #requires can be accomplished directly in the scripting language, where more specific error messages could be crafted, or even the issue worked around, maybe with the exception of importing classes from a module.
I can implement the current syntax in the tmlanguage grammar, it will just be the odd one out, in all the rules, and is why I bring this up.  I think its better to have a good understanding of the grammar than to just assume it works a certain way, hence my investigation in to it in the first place.


VsCode Crashes with SDL2-CS

Environment data
dotnet --info output:
.NET SDK:
 Version:   7.0.114
 Commit:    b2a71039cd

Runtime Environment:
 OS Name:     ubuntu
 OS Version:  22.04
 OS Platform: Linux
 RID:         ubuntu.22.04-x64
 Base Path:   /usr/lib/dotnet/sdk/7.0.114/

Host:
  Version:      7.0.14
  Architecture: x64
  Commit:       808851b07a

.NET SDKs installed:
  6.0.125 [/usr/lib/dotnet/sdk]
  7.0.114 [/usr/lib/dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.25 [/usr/lib/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 7.0.14 [/usr/lib/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.25 [/usr/lib/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 7.0.14 [/usr/lib/dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  Not set

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

VS Code version: 1.84.2
C# Extension version: v2.13.10
OmniSharp log
Crashes and idk where the log is.
Steps to reproduce

Open project here. https://github.com/Shadowblitz16/AstroWars
Run project
Press space

Expected  behavior
VsCode Shouldn't crash
Actual behavior
VsCode crashes
Additional context
I reported this problem here too... https://github.com/microsoft/vscode/issues/200513

Hi @Shadowblitz16, can you define what you mean by "VS Code crashes"? I am not able to reproduce a problem when I try your scenario.

Hi @Shadowblitz16, can you define what you mean by "VS Code crashes"? I am not able to reproduce a problem when I try your scenario.

Hi gregg vscode seems to crash if I don't sleep the thread.
I think maybe sdl2-cs is running too fast for vscode to handle

I am closing this issue since there was never a response. Feel free to ping back if you have the required information.


Add browser support to README

Is your feature request related to a problem? Please describe.
I can see that the library is using the Intersection Observer API. Does that mean that browser support is equivalent to browsers that support Intersection Observer? Or do you use a polyfill?
Describe the solution you'd like
Add browser support list to README. This would allow developers browsing this library to instantly see what browsers are supported, and not have to look in the source code which can be time consuming.

hey @davidcetinkaya
it's already listed in the feature:
Simple usage and tiny size includes polyfill (minified + gzipped)

Maybe I'm missing something very obvious 🙈, but where do you read that?

feature list.

Speed up initial page loads by loading only images above the fold
Responsive with placeholders and animations
Support Priority Hints with importance attribute
Smart download logic using IntersectionObserver
Simple usage and tiny size includes polyfill (minified + gzipped)

Thanks for clarifying 🙂. Sorry, now I see 👍. Although I think something like this would help:

This package support majority of the browsers include ie11. But feel free to submit a PR to clarify this.

Thank you. I have to try the library first in order to determine browser support and submit a PR.

that would be lovely! thanks

going to close this issue for now, feel free to send a PR to correct that in the near future


Stable/newton

@<reviewer_id>
What issues does this address?
What's this change do?
Merging up mitaka into stable/newton
Where should the reviewer start?
Any background context?

@zancas and @jlongstaf: alrighty, this is ready for review and merge.

retest this please


chore: fair screen fixes

This PR resolves []
Description
Since we have a major upcoming fair - I thought it's about time to fix the issues in the screen as well as allow users to share the fair link. Below is a list of changes:

Fix broken tap on Read more
Add Share fair URL
Fix broken padding between sections
Remove additional separator
Add nestedScrollEnabled for a small performance improvements (I doubt it will be noticeable but better have it than not)
Align sort and filter experience with other screens (show number of artwork in bold instead of Showing X artwork)
Use Screen component in both Fair and FairInfoscreens.
Fix back button covering content in both Fair and FairInfo screens

Before
After

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

fix fair screen outstanding issues - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (fix fair screen outstanding issues - mounir)

  Generated by :no_entry_sign: dangerJS against 0e453d08f6f89e3b4a9ffe7ccd7a446f97541992

Feel free to merge this @araujobarret when you feel ready

I think I'll merge this to main but will pick your changes individually into my Fair branch, otherwise if I cherry-pick yours, once I cherry-pick mine I'll need to make conflict resolution in the release branch


Desktop Integration

It would be nice to have a proper desktop integration for the different platforms.
Though all desktop environments have their specifics, the most important things are in common:

[ ] desktop icon
[ ] minimize the application (to tray or launcher) instead of switching to windowed mode
[ ] launching applications (windows start button, unity launcher, gnome menus, ...)
[ ] tray / indicators (for example for daemonized functions like lan server or the global chat)
[ ] notifications for (for example: "map downloaded", "calclight done")

Specifics for Ubuntu Unity:

[ ] The launcher combines the start button and some functions of the tray
[ ] The unity launcher can show progress bars and a number badge (for example showing map download progress and or a frag counter)
[ ] Messaging indicator for unread chat messages

Windows specific:

[ ] Windows installer, see #277
[ ] Windows link to start Inexor in the start menu (always) and on the desktop (opt-in)
[ ] Windows updater (may be introduced at a later point, not necessary for the first step)

(Please add the specifics for your platform here! Thanks!)

Added an description for the issue

In the context of the Windows platform I don't really get the following two points:

minimize the application (to tray or launcher) instead of switching to windowed mode
launching applications (windows start button, unity launcher, gnome menus, ...)

Could you please describe what you mean? The "windows start button" sound like a normal application link? That's getting created by the Sauer installer. Do we use another installer?
And to the first point: When I'm alt+tab out of the game (or by using the windows key) it's working as expected, Sauer doesn't switch to windowed mode.

Yes, that's a linux issue. You can leave the fullscreen mode and enter the windows mode, and then you're able to minimize. But you cannot minimize from fullscreen directly.
You're right that the links should be created by the installer. I'm not sure: do we have an installer for windows, already?

A reminder: Windows start menu entries must go to their own folder. That is, %PROGRAMDATA%\Microsoft\Windows\Start Menu\Programs\Inexor\Inexor.lnk and not %PROGRAMDATA%\Microsoft\Windows\Start Menu\Programs\Inexor.lnk

Btw, Sauerbraten is using on Windows this: http://nsis.sourceforge.net

Similar discussion on Red Eclipse: https://github.com/red-eclipse/base/issues/175

Btw, Sauerbraten is using on Windows this: http://nsis.sourceforge.net

quick heads up: Red Eclipse has a more up to date NSIS installer script (Link), if that's the route you want to take for Windows installations.

@freezurbern does this smoothly integrate with your CI/Travis (as on Windows?). We'd love to have some automatic packaging going on, which is why I'd suggest either the Visual Studio Setup Extension or, prefferably the Chocolate package manager..

I have successfully built NSIS packages through my Jenkins instance using
the NSIS command line tools. It works great: on successful windows compile,
generate windows installer. I can show you the console scripts if you'd
like. Please note this is with Red Eclipse and the NSIS script i helped
with for them (linked earlier)
On Jun 21, 2016 2:31 PM, "Lennard Berger"<EMAIL_ADDRESS>wrote:

@freezurbern https://github.com/freezurbern does this smoothly
integrate with your CI/Travis (as on Windows?). We'd love to have some
automatic packaging going on, which is why I'd suggest either the Visual
Studio Setup Extension
https://visualstudiogallery.msdn.microsoft.com/f1cc3f3e-c300-40a7-8797-c509fb8933b9
or, prefferably the Chocolate package manager https://chocolatey.org/..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/inexor-game/code/issues/138#issuecomment-227530117,
or mute the thread
https://github.com/notifications/unsubscribe/AGEZGROsHkwVB9shTJsjSLIU4QBATqTwks5qOC4KgaJpZM4D5_J4
.

Most of the desktop integration functionality will be provided by Inexor Flex.
Icon
We have a scalable version of the Inexor logo:
Usage:

Window icon
Application icon
Start menu entry icon
System tray icon

Window icon

https://wiki.libsdl.org/SDL_SetWindowIcon

Start menu entries / Application icon

Windows:

Link from the start menu folder to the BAT file
%PROGRAMDATA%\Microsoft\Windows\Start Menu\Programs\Inexor\Inexor.lnk
The .lnk file contains the icon (see start menu entries)

Linux:

The icon location is: /usr/share/pixmaps
The .desktop file location is: /usr/share/applications or /usr/local/share/applications
The .desktop file references the icon and the shell script (inexor.sh)
https://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
https://help.ubuntu.com/community/UnityLaunchersAndDesktopFiles
https://wiki.archlinux.org/index.php/Desktop_entries

The system tray functionality

Shows that Inexor Flex is running
Menu for starting Inexor Core instances (servers and clients)
Minimize/restore the Inexor Core (Client) window
Open the Inexor Flex user interface in the default web browser

Ubuntu Unity allows to integrate most of the system tray functionality in a start menu entry:

https://help.ubuntu.com/community/UnityLaunchersAndDesktopFiles (Adding shortcuts to a launcher)

Libraries
Though the functionality of the tray icons and the system notifications are almost the same different platforms have different APIs and locations. I would prefer a cross platform way to solve these problems. Therefore I did a little research which NodeJS libraries provides a cross platform support for desktop integration tasks and are appropriate for integration in Inexor Flex.

Desktop Notifications:

Cross platform: node-notifier
Uses the notification center for macOS, notify-osd/libnotify-bin for Linux, toasters for windows 8/10 or taskbar balloons for earlier windows versions

Tray Icon

Haven't found a cross platform library for NodeJS (only for Java and Go )
Windows: https://github.com/jsdnxx/tray-windows
OSX: https://github.com/brandonhorst/node-tray
Linux: no NodeJS library available

Window control functionality

Minimize / restore the window
Fullscreen

Control the window of an Inexor Core instance using Inexor Flex:

    ./flex minimize 31415
    ./flex maximize 31415
    ./flex fullscreen 31415

Node-JS Library for dbus: https://github.com/Shouqun/node-dbus


applet.interface.uart: high Baud rates drop data

It seems that using ~1.5Mbaud, with high Rx data rates can cause the applet FIFOs to overflow, and silently drop data.
1.5Mbaud is worst-case of ~150KB/s... this overflow is likely due to the relatively inefficient USB utilization that is incurred with the default auto_flush=True.
Suggestions:

Set auto_flush=False, and implement a timer to flush buffers after a number of idle bit/word-times
Increase FPGA-side FIFO size, past the default of depth=512
Add a register to indicate overflow / dropped frames

I think that this should be a non-issue for Tx data, as the buffers will back up, eventually into Python.

This was discovered by @marcan while working on Asahi Linux.

We should probably implement something like Nagle for UART.


perf(linter): use CompactStr in no-hooks

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#6402
#6401  👈
#6400
#6399
#6398
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camchenry and the rest of your teammates on  Graphite

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#6402
#6401  👈
#6400
#6399
#6398
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camchenry and the rest of your teammates on  Graphite


Unable to upload video. No message shown when trying to upload image.

When I tried uploading a video on the hosted Web app, the video is not getting uploaded and there is no error message shown.

@kavishjadwani Currently the app is only intended to be used to upload images. I've done a small fix to make sure the file chooser will only allow you to select images and not movies :)
Thanks!


Visiblity shard id os WIP

What changed?

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 01869636-5314-4c19-8ee5-a00cf0938281

25 of 29 (86.21%)  changed or added relevant lines in 8 files are covered.
137 unchanged lines in 14 files lost coverage.
Overall coverage decreased (-0.08%) to 57.146%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/persistence/persistence-tests/dbVisibilityPersistenceTest.go
0
1
0.0%

common/persistence/nosql/nosqlplugin/cassandra/visibility.go
9
12
75.0%

Files with Coverage Reduction
New Missed Lines
%

service/history/queue/transfer_queue_processor_base.go
1
77.62%

common/cache/lru.go
2
92.2%

common/persistence/nosql/nosqlplugin/cassandra/visibility.go
2
50.34%

common/task/weightedRoundRobinTaskScheduler.go
2
88.6%

service/matching/matcher.go
2
91.46%

common/persistence/nosql/nosqlplugin/cassandra/workflow.go
3
59.55%

common/persistence/statsComputer.go
6
93.57%

service/history/task/transfer_standby_task_executor.go
6
87.24%

common/persistence/serialization/parser.go
8
63.91%

common/persistence/serialization/thrift_decoder.go
8
57.14%

Totals

Change from base Build 01869460-5d34-4f7e-806c-65ae42a65489:
-0.08%

Covered Lines:
85116

Relevant Lines:
148944

💛  - Coveralls


Secure Authentication for Online IDE

Feature Proposal

Spec Version 0.2.0

Context
Problem

Describe the problem that is tackled in this issue

The student needs to be authenticated when using the online IDE. Especially for the exam mode, it is important that the user is not able to share his session link with someone else so that this person works in his place and attempts cheating. The VSCode plugin inside of the Online IDE needs an authentication token to access the problem statement and other components of the Artemis website.
Two problems therefore arise:

Any token/credential saved in the Theia context can leak to third-parties authorized to access the session
Without authentication in Theia, we don’t know how many users are working together and submit using a reverse-proxy-like setup.

In addition, we don't want another login process where the user has to enter his credentials again. Opening the online IDE should be seamless and provide a fast entry.
The git cloning via HTTP or SSH imposes a secondary problem. The Theia session has to be able to clone and push to the student's exercise repository. If we clone the repository with HTTP the user would have to enter his credentials again. For SSH, we would have to generate an SSH on each Online Session start-up and link its public key to Artemis.
Motivation

Describe the motivation WHY the problem needs solving. Specify the affected users/roles.

Requirements Engineering
Existing (Problematic) Solution / System

What is the current solution (if there is one)? What is the problem with the current solution?
You may include a UML Model here

Currently, Artemis uses JWT to authenticate its user. The JWT token is stored as an HTTPOnly cookie and can not be read in JS.
Even if it were not HTTPOnly, hijacking that token would not be good practice, as a token should only be used for one service and not be shared. Therefore a new token for the online IDE and for the plugin should be generated. JWT is not built to generate additional tokens seamlessly.
Proposed System

What would the ideal solution look like?

To protect a theia session and guarantee seamless authentication we would integrate OIDC into Artemis. This allows generating a new token on session start up.
Authentication users with OIDC before granting them session access generates traces at the KeyCloak OID-Provider allowing fraud detection just like the existing session monitoring
With OIDC:

1 Token in Artemis Website
1 Token in Theia for Instance Access
1 Token in VSCode Plugin for Artemis Access

For the cloning of repositories we propose a token based cloning. Theia would then be provided with such a token and the user would not have to enter his credentials again.
Open:

how to securely pass this token to theia session?
if user passes this git token to someone else, can they submit without being detected?

Requirements

Describe the Functional and Non-Functional Requirements of the feature. Stick to the INVEST methodology!

FR: :

NFR: <FURPS+ Category>: :

Analysis
Analysis Object Model

What are the involved Analysis Objects?

Dynamic Behavior

Include dynamic models (Activity Diagram, State Chart Diagram, Communication Diagram) here to outline the dynamic nature of the PROBLEM

System Architecture
Subsystem Decomposition

Show the involved subsystems and their interfaces. Make sure to describe the APIs that you add/change in detail. Model the DTOs you intend to (re)use or change!

Persistent Data Management

Describe the Database changes you intend to make.
Outline new configuration options you plan to introduce
Describe all other data persistence mechanisms you may use.

Access Control / Security Aspects

Describe the access control considerations for your feature

Other Design Decisions

Potential topics to discuss here include: WebSockets, testing strategies.

UI/UX Design

Screenshots of the final UI mockups (mandatory): Please include screenshots to provide a clear and persistent visual reference of the design.
Link to the design mockup (optional): Additionally, you may include a link to the live design mockup (e.g., Figma, Sketch) for a more interactive view. Note that this link is supplementary and should not replace the required screenshots.

Open to discuss

if Theia has HTTPOnly token, can this token be used in the plugin? Is it maybe even automatically appended for each request of the plugin?

JWT is not built to generate additional tokens seamlessly.

I do not agree with this statement. Users can login on multiple browsers, each time a new JWT token is generated. So in some sense, you could argue that one user can have arbitrary many JWT tokens at the same time.
The Artemis client / browser stores the token in the cookie so that links to attachments can be shared and opened in separate tabs without the web application being active.
However, this mechanism is not set in stone. If there is a specific requirement to change it, we can discuss it.
Another alternative would be to host the client part of the Online IDE using the same URL as the Artemis instance based on a micro frontend approach. Then, the online IDE could directly access the JWT token within the cookie.


⚠ Bofrost.de has degraded performance

In 8375eb6, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1262 ms

Resolved: Bofrost.de performance has improved in 5d67d1b.


Issue with positions while using eventalign

Hi!
I have run into a problem while using eventalign for direct RNA sequencing data.
It seems that some of the positions are shifted for some strands for the same genes.
And I have doubled checked that they are not the reverse strand of sequences.
For example from the results of eventalign:

position
reference_kmer
read_name

21
GGCTC
62f8da7d-a17a-4285-bc7b-55ba25cb5910

21
GCTCA
f9d3f66e-3ced-45e8-9661-ea9954fb864f

21
GGCTC
5629137f-3789-47d9-892b-c0283ef1e996

21
GGCTC
53535cb3-a229-490b-a186-e0c95412dc23

21
GCTCA
a0f9c131-c580-46db-91df-b29a8218f93d

21
GCTCA
b60ad0fd-b466-4a12-ac16-a7ec5eca4864

21
GGCTC
42d19b2d-5e8c-40d9-9360-a544bd7c487e

There is a shift of one in the example.
Is there any way I can correct this?
Thanks!

Hmm, that shouldn't happen! I assume they are all from the same reference chromosome/contig?

Finally found the issue!
It was due to having spacing in my reference fasta.
After removing all the spacing, and remapping my sequences the issue was solved.
Sorry for the scare and thank you for your reply!


feat: updates twitter logo

Fixes #3920
Describe the changes you have made in this PR -
Replaced old twitter with the new X logo
Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Fixed via https://github.com/CircuitVerse/CircuitVerse/pull/4027


Object allows not existing properties on type when assigned value was touched by type

Bug Report
🔎 Search Terms
object not existing keys
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about Type System Behavior

⏯ Playground Link
Playground link with relevant code
💻 Code

var foo: {
	bar: number
	baz: string
} = {
	bar: 0,
	baz: '',
	foobar: 0
} as {
	bar: number
	baz: string
	foobar: number
}
function someFunc<R>(fn: () => R): R {
	return fn()
}
someFunc<{ foo: number }>(() => ({ foo: 1, foobar: '' }))

🙁 Actual behavior
error doesn't occurs even foobar property is exists in object.
🙂 Expected behavior
error occurs because foobar is not existing property in object.

Excess property checks is lint/helper feature, not type error as if you assign incompatible type and type assertion is first way to intentionally skip this error that is mentioned in handbook https://www.typescriptlang.org/docs/handbook/interfaces.html#excess-property-checks
Errors in cases above would be possible only with support of Exact Types #12936


[HUDI-3598] Row Data to Hoodie Record Operator should support users t…

…o adjust the number of parallelism
Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot run azure

@danny0405 ,the real problem is this operator just use the  the default parallelism of job instead of source parallelism. in some case, we will set parallelism for each operator include source operator. so this function can't chain the source operator, just because it always use the job default parallelism when source don't use the default parallelism of job.

closing since a new one created https://github.com/apache/hudi/pull/5049


read_image from torchvision.io failing

🐛 Describe the bug
Following this guide I get an error when using the torchvision read_image method.
from torchvision.io import read_image
p = "path_to_image"
img = read_image(Path(p))

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/rdessi/miniconda3/envs/egg/lib/python3.7/site-packages/torchvision/io/image.py", line 250, in read_image
    data = read_file(path)
  File "/rdessi/miniconda3/envs/egg/lib/python3.7/site-packages/torchvision/io/image.py", line 80, in read_file
    data = torch.ops.image.read_file(path)
  File "/rdessi/miniconda3/envs/egg/lib/python3.7/site-packages/torch/_ops.py", line 61, in __getattr__
    op = torch._C._jit_get_operation(qualified_op_name)
RuntimeError: No such operator image::read_file

Versions
PyTorch version: 1.7.0
Is debug build: True

CUDA used to build PyTorch: 10.1
ROCM used to build PyTorch: N/A

OS: Ubuntu 20.04.1 LTS (x86_64)
GCC version: (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
Clang version: Could not collect
CMake version: version 3.16.3
Libc version: glibc-2.10

Python version: 3.7.6 (default, Jan  8 2020, 19:59:22)  [GCC 7.3.0] (64-bit runtime)
Python platform: Linux-5.4.0-52-generic-x86_64-with-debian-bullseye-sid
Is CUDA available: True
CUDA runtime version: Could not collect
GPU models and configuration:
GPU 0: Quadro GP100
GPU 1: Quadro GP100

Nvidia driver version: 450.80.02
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A

Versions of relevant libraries:
[pip3] mypy==0.790
[pip3] mypy-extensions==0.4.3
[pip3] numpy==1.19.2
[pip3] torch==1.7.0
[pip3] torchaudio==0.7.0a0+ac17b64
[pip3] torchvision==0.9.0
[conda] blas                      1.0                         mkl
[conda] cudatoolkit               10.1.243             h6bb024c_0
[conda] mkl                       2020.2                      256
[conda] mkl-service               2.3.0            py37he904b0f_0
[conda] mkl_fft                   1.2.0            py37h23d657b_0
[conda] mkl_random                1.1.1            py37h0573a6f_0
[conda] mypy                      0.790                    pypi_0    pypi
[conda] mypy-extensions           0.4.3                    pypi_0    pypi
[conda] numpy                     1.19.2           py37h54aff64_0
[conda] numpy-base                1.19.2           py37hfa32c7d_0
[conda] pytorch                   1.7.0           py3.7_cuda10.1.243_cudnn7.6.3_0    pytorch
[conda] torchaudio                0.7.0                      py37    pytorch
[conda] torchvision               0.8.1                    pypi_0    pypi

Thanks for the report @robertodessi , it looks like you're using an old version of torchvision. Could you please update to the latest 0.11 version and try again? Thanks

And seems the versions of torch and torchvision are inconsistent, if you want to use torchvision 0.9.x, you could install torch 1.8.x.

Upgrading to the latest pytorch and torchvision worked. Thanks!


Show computed number of frames (and duration) for sliders

This could be helpful if someone is going for a specific duration of frames, or also as a warning in case the number of frames is incredibly high.

People have been living well without this.


Babel Server Crash

Minecraft v1.16.5
Forge v36.0.7
Babel v1.0.4
When trying to use this mod with Compote, I go a server crash
Crash Report

Thanks for the report, fixed in v1.0.5 which should be available on Curseforge now.

(fixed in 1.0.5)

Thanks!


Branching and converging pipelines

RE: https://github.com/pyviz/panel/issues/419
For discussion on 5/29/19

Merged into panel master.


Implement sharding

Sharding already works straight out of the box with the discord.js sharding manager.

You can actually do sharding using the sharding manager from discord.js and the client from commando like the client of discord.js.


Self Transitions and Feedback loops

Could you please provide guidance on how best to implement a self-transition?  That is a state that transitions back to itself?  Ideally, it would do this conditionally.  So, maybe it transitions to an If that can transition back to the original state?
Geneally, the framework seems to only support acyclic paths through the state machine.  Surely you can have a return transition that goes back to a previous state?  Would you just 'reinstantiate' that step again in the WF definition?
I suspect it would involve ExecutionResult.branch() but there is apparently no documentation of that nor any samples that use it.  The If example also appears to be a once-through with no feedback loop.
Any help would be greatly appreciated.  If all workflows have to be acyclical, that would be a dealbreaker for us using it.

It is possible but you have to do it like this currently:
let step1 = builder.startWith(HelloWorld);
let step2 = step1.then(GoodbyeWorld);
step2.thenStep(step1);

On the .net version we did implement a nicer syntax - here: https://github.com/danielgerlag/workflow-core/releases/tag/1.8.3


Fix Reconnection Logic

Description of Changes
Describe what has been changed, any new features or bug fixes

switched our "already connected" logic to using a reference to a MonoBehaviour instead of just a bool. MonoBehaviours are typically destroyed when a scene reload happens and in this case we'll want to allow developers to spawn a new SpacetimeDBNetworkManager if the previous one has been destroyed.

API
This is not an API break.

[ ] This is an API breaking change to the SDK

If the API is breaking, please state below what will break
Requires SpacetimeDB PRs
List any PRs here that are required for this SDK change to work
Testing
Write instructions for a test that you performed for this PR

[x] Checkout the SpacetimeDBCircleGame project
[x] Remove SpacetimeDB package and add a new one: https://github.com/clockworklabs/com.clockworklabs.spacetimedbsdk.git#jdetter-fix-reconnection-logic
[x] Add a simple function to the GameManager which reloads the scene in order to cause a reconnection:

private void Start()
{
    // add this to the bottom of start
    StartCoroutine(Reconnect());
}

public IEnumerator Reconnect()
{
    yield return new WaitForSeconds(3.0f);
    // Reload the scene to cause a reconnection
    UnityEngine.SceneManagement.SceneManager.LoadScene("Scenes/SampleScene");
}

Previously, before this PR you would end up with:
Unhandled log message: '[Exception] InvalidOperationException: SpacetimeDBNetworkManager is a singleton and should only be attached once.'. Use UnityEngine.TestTools.LogAssert.Expect

After this PR it just works with no error.

This only fixes some surface level issues, there are some deeper problems here with how we handle client side indexes that will need to be fixed.


Suppress inlay hints on lines with syntax errors

Starting with code like this:
use std::sync::mpsc::{Sender, channel};

fn main() {

    let (tx, rx) = channel();

}

Which I see in VSCode as this:

Most of the time, I can provide enough type hints in other parts of the code to let rust figure out this unknown type, but not always.  If I need to explicitly annotate the types, I often the mistake of writing code like this:
    let (tx: Sender<u8>, rx) = channel();

This is a syntax error, but rust-analyzer still gives inlay type hints to VSCode to display:

The result is quite hard to read and parse (for my human brain).  Do you think it would make sense for rust-analyzer to suppress inlay type hints on lines with syntax errors?

I don't think we can do much here, surpressing the hints for lines with syntax errors is gonna be quite difficult and I don't really see a feasible way for us to implement this without degrading general user experience in other places.


question about R_hier in Eq(5)

Hi, @diegovalsesia ,
According to the computation on R_hier in hype_triplet_losses, the default option for opposite_hier is False, so this line will be used. From my understanding,
par_norm <--> z_part
p_norm   <--> z_whole

But it is different from the version mentioned in Eq(5) in the original paper. Could you elaborate on it further?
Thanks~

Hi @amiltonwong ,
sorry for delay, anyway the variables name are a bit misleading:
par_norm <--> parent norm, i.e. z_whole
p_norm <--> positive part norm,i.e. z_part


Fix code coverage reporting

The aggregated LCOV files are like a zoo of relative paths to the same files, but from various working directories.
This makes it impossible to calculate the code coverage correctly.
It's best to fix that before the public release, I think.

Partially done, but still, there are some weird paths like src/../src. Some more investigation is needed.


[FeatureReq - Edge Addons site] Ability to report misconduct in user reviews on a Microsoft Edge Add-on product detail page

Is your feature request related to a problem? Please describe.
The reviews posted on Microsoft Edge Add-on product detail page are not monitored for misconduct or rude, hateful & abusive behaviour in the reviews posted by users.
Describe the solution you'd like
A clear and concise description of what you want to happen.

Duplicate of https://github.com/microsoft/MicrosoftEdge-Extensions/issues/39


Test Explorer contains an unrelated/unnecessary node at the top of the hierarchy.

Environment data

VS Code version: 1.31.1
Extension version (available under the Extensions sidebar): 2019.2.5433
OS and version: Windows 10
Python version (& distribution if applicable, e.g. Anaconda): 3.7.0
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
Relevant/affected Python packages and their versions: pytest

Expected behaviour
All nodes displayed in the Test Explorer hierarchy are nodes that pertain to a specific folder, file, test suite, or test function.
Actual behaviour
A node that has no relevance to the user's workspace test contents appears at the top of the tests hierarchy in the Test Explorer:

Steps to reproduce:

Clone, open, and configure Python/pytest, the Pytest repo in VS Code with the Python extension installed.

Once the VS Code editor and the Python extension load, the Test Explorer beaker icon should appear in the activity bar.

Run all tests.
Inspect the test results in the Test Explorer tree.

New code written in #4033 should solve this issue.
@ericsnowcurrently 	@d3r3kk 	/cc