Bable module

Related to #7
Run $ bable [path] --out-file [path] for every file.

Consider a more generic wrapper module, eg:
| wrapper cmd [file] --out-file=[file] arg0 arg1 arg2
Would run:
$ cmd path --outfile=path arg0 arg1 arg2
This would allow NPM packages in general to be wrapped as well.


[gh-pages] [ZEPPELIN-2597] updating navbar and main sections and what's new.

What is this PR for?
For more comfortable guidance, improved navigation bar, main blue section and what's new section.
And if anyone suggests idea or give me feedback, it would be appreciated!

In main blue section

add zeppelin logo
change buttons, Get started and Download
change button color.
change font style of description
change title font-size more smaller
change background color for dividing navbar and this section.

regarding to improve navbar

improve: change position of items
improve: change font option in dropdown-menu
fix : when not active, revert color
fix : when resizing window, dropdown-menu toggle text is disappeared.
fix : after using navigation bar in small window, and then drop-toggle place is misaligned in big window.

what's new sections

(minor) improve: aligned title text when small size windows

What type of PR is it?
[ Bug Fix | Improvement | Documentation ]
Todos

describe above What is this PR for? part

What is the Jira issue?

ZEPPELIN-2597

How should this be tested?

run bundle exec jekyll serve --watch in this branch
open localhost:4000

Screenshots (if appropriate)
1. blue section
[Before]

[After]

2. navbar

change position of items (Before -> After)

change font option in dropdown-menu (Before -> After)

fix : when not active, revert color

fix : when resizing window, dropdown-menu toggle text is disappeared.

fix : after using navigation bar in small window, and then drop-toggle place is misaligned in big window.

3. what's new sections

(minor) improve: aligned title text when small size windows

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? Yes, this is.

Hi, @AhyoungRyu @1ambda @Leemoonsoo. Please review again :slightly_smiling_face:

Some adding fix list

fix : when navbar-toggle in collapsed, do not revert color.
[Before]

[After]

fix: not fully hover in dropdown-menu title

Let me check. Thanks for the contribution and great effort on the improving official website.

Cool!.
I tried this branch and found

"Get Started" and "Download" button in the dark.
I think dark (or gray) button usually used to describe 'inactive' feature. So it may give wrong impression user. Can we choose other color that tells more 'active'?

Then bright white color would be better for the buttons.

(BUG) Navbar doesn't fold when I click other a component.

Can't find favicon.ico.

When I execute bundle exec jekyll serve --watch, I get this error.
[2017-06-09 13:13:01] ERROR `/favicon.ico' not found.

Do we have the favicon for Zeppelin?

Apache Zeppelin text need to be moved into the bottom a little bit while keeping the logo (icon) in the same position.

Current

(MINOR) we might add some shadows for texts in the section

I used this style, but we can test more different styles.
1px 1px #4a4a4a

Current

Fixed

6. font-size, text-shadow for menus in the navbar including collapsed version.
6-1 normal version
Since the toplevel menu's font-size is 15px, sub menus should have the equal or less font-size. currently, it's 16px.

Let's set font-size 15px for .docs .dropdown-menu li span

Current

Fixed

6-2 collapsed version

text-shadow in the sub menus can be decreased. too much IMO:  from 1px 2px #353131 to 1px 1px #353131
for font-size, we can apply the same policy with 6-1

15px for .navbar-inverse .navbar-nav > li > a  (in all media queries for the collapsed version  just not for @media only screen and (max-width: 996px) and (min-width: 768px)
15px for .docs .dropdown-menu b (in all media queries  for the collapsed version )
14px for .navbar-nav .open .dropdown-menu (for all  for the collapsed version)
fix padding-bottom for .docs .dropdown-menu li span from 12px 10px 12px 20px to 12px 10px 12px 15px. Currently it's too close to children.

Current

After

@soralee I left few 6 comments. Could you resolve one issue in a commit? It really helps to review.

@1ambda Sure, Thank you for your helping always!

@Leemoonsoo could you confirm this color?

@soralee IMO, using bright white as the color for not hovered button would be nicer.
and let's find another color combinations.
what about others' opinion?

@1ambda I've just updated as your comments except number 2 and 3. It might take time to resolve that. Let me inform if I finish to-do list. Thanks!

I just improved No 2 and 3.
And, regarding No 3, there is not favicon.ico file. So, I added favicon.ico package files.

not connected page

connected page

@soralee

[ ] 1. Main text: resolved, but need others opinions.
[x] 2. Nav doesn’t fold: fixed
[x] 3. No favicon: fixed
[x] 4. Narr magin-top: fixed
[x] 5.Text shadow for main text: fixed
[x] 6-1. Font for normal nav: fixed
[ ] 6-2. Font for collapsed nav: top level font still has 18px font-size

Additionally,

The color of main section is too bright. It doesn't go along nav color. Here are few options we can use.

Add a color can be a bridge (e.g button or shadow for nav, ...)
Use more deep blue and add border-shadow for nav to distinguish them easily.
Or change nav color
... and more

The color for buttons in main section

What about #33a6cc for background? The official website is already using the color for buttons below.

Here is a sample.

@1ambda Thanks for opinions!
IMO, regarding of no.7, it would be better to match navigation bar with #2371.
Let's use light such as box-shadow: 0px 3px 6px rgba(0, 0, 0, 0.4); and revert to original color in main section.
What do you think?
And no.8 is a good idea. Let's change the buttons color!

I couldn't change to original color in main section because, zeppelin log is disappeared :disappointed:. So changed one step more bright color than original main section color.

Fixed 6.2 comments and, here is more improvement list

main section

changed PR phrase to font-size : 22px, line-height: 1.4
added padding-top/bottom in main section
changed button font and weight
added button margin-side
added button interval
added interval between PR phrase in main section and buttons

revert to original what's new section

@soralee LGTM except for one thing,
h1 is hidden in mobile size browser.

LGTM

@1ambda Thank you for all your comment.

Ping, Ready to review!

@soralee Since https://github.com/apache/zeppelin/pull/2371 was merged, we can fix the URL names in this PR too.

quickstart button in nav: ${PROPER_PREFIX_FOR_0.8.0}/quickstart/install.html

@1ambda, @Leemoonsoo suggested the latest link so I already fix 0.7.2 version.
@Leemoonsoo could you confirm this?

I think it's ok to use the prefix for 0.7.2. Then, we can deploy before 0.8.0

merge if no more discussion


[docker] Docker image could not work well on Raspberry Pi

Describe the bug
When running openthread/otbr_arm32v7l_raspbian:latest docker image on Raspberry Pi, it will complain

standard_init_linux.go:190: exec user process caused "exec format error"

To Reproduce
docker pull openthread/otbr_arm32v7l_raspbian:latest (https://hub.docker.com/r/openthread/otbr_arm32v7l_raspbian)
Raspberry Pi 3 B+ with latest stretch lite and docker installed

docker run --sysctl "net.ipv6.conf.all.disable_ipv6=0 net.ipv4.conf.all.forwarding=1 net.ipv6.conf.all.forwarding=1" -p 8080:80 --dns=<IP_ADDRESS> -it --volume /dev/ttyACM0:/dev/ttyACM0 --name otbr --privileged openthread/otbr_arm32v7l_raspbian:latest
WARNING: Localhost DNS setting (--dns=<IP_ADDRESS>) may fail in containers.
standard_init_linux.go:190: exec user process caused "exec format error"

Additional context
A bit dig on the issue, it seems some architecture issue.
https://forums.docker.com/t/standard-init-linux-go-190-exec-user-process-caused-exec-format-error/49368

@jwhui, It seems that platform is not properly set for otbr_arm32v7l_raspbian

// from https://cloud.docker.com/u/openthread/repository/docker/openthread/otbr_arm32v7l_raspbian/timeline
Arch: amd64
BuildTime: 2018-08-30T18:42:30.000000000+00:00
ApiVersion: 1.37
Platform: {u'Name': u''}
Version: 18.03.1-ee-3
MinAPIVersion: 1.12
GitCommit: b9a5c95
Os: linux
GoVersion: go1.10.2
Starting build of index.docker.io/openthread/otbr_arm32v7l_raspbian:latest...
Step 1/17 : FROM ubuntu
---> 7698f282e524

@librasungirl thanks for raising this.
Yes, we need to cross-compile for arm on Docker Hub.
There is one solution presented here: https://www.balena.io/blog/building-arm-containers-on-any-x86-machine-even-dockerhub/
Other ideas?

I disabled the autobuild on Docker Hub and pushed an image for openthread/otbr_arm32v7l_raspbian that should work. We can enable autobuild on Docker Hub when we have this sorted out.

Resolved by #518


Countries name is not show, using docker

As seen above, the country name's did not show at all.
How to fix and trace this? Please help.
I'm using docker-compose with PostgreSQL.

Make sure your server is passing along the correct IP information. See, https://github.com/mikecao/umami/issues/415

Make sure your server is passing along the correct IP information. See, https://github.com/mikecao/umami/issues/415

I have test using simple php code on my server, detecting $_SERVER['REMOTE_ADDR'] and $_SERVER['HTTP_X_FORWARDED_FOR']. And the result is:
1. REMOTE_ADDR = <IP_ADDRESS>
2. HTTP_X_FORWARDED_FOR = <IP_ADDRESS>

It looks like the ip address of my vm (1) and my router (2). Looks like the problem is my router didn't forward public ip of visitor.
But I'm curious, how did you detect visitor's IP?

The IP just needs to be passed along by your webserver. I am hosting on Vercel so they pass along the IP information correctly.

Thank you for the time you spend to answer this issue. I'm closing it.

I had this issue as well, maybe it's worth mentioning it in the documentation?


Add command to wsl.exe to perform an Atomic restart of an instance

Would it be possible to have an atomic wsl function to restart an instance with the same properties (user, start directory etc)
For example:
Wsl restart -d Ubuntu-22.04
While this can be done with multiple wsl commands, having a single atomic command would allow install scripts inside wsl to self restart
Example a linux bash script would be able to issue:
PowerShell.exe -Command "wsl restart -d Ubuntu-22.04"

Do you mean something like wsl.exe --shutdown & wsl.exe -d Ubuntu-22.04 command but in one command line option?

While this can be done with multiple wsl commands, having a single atomic command would allow install scripts inside wsl to self restart

Why does someone want a single command if it can be done in multiple commands?

Do you mean something like wsl.exe --shutdown & wsl.exe -d Ubuntu-22.04 command but in one command line option?

more like
wsl.exe --terminate Ubuntu-22.04 & wsl.exe -d Ubuntu-22.04
But by having it as a single atomic function it can be issued inside wsl and would effect a restart, currently there is no way to do that, you can terminate the distribution, but the wsl command stops running at that point and does not go on tyo do the start-up again. you have to then manually restart it from the windows PowerShell side


🐛 fix(devkit): adjust tsconfig for build

:rocket: Welcome to Baloise ChatOps based GitOps Bot :tada:
- If you want to enable preview environments for this PullRequest, comment with `/preview`.
- If you want to disable the preview environment for this PR, comment with `/undeploy`.
- If you need help or want to see the docs, comment with `/help`.

Make sure to refresh this page after submitting a command.
Preview environments can be redeployed automatically if you enable the webhook for updates to the source branch. :new:

Have fun building awesome apps! :hammer:  :whale2:  :truck:  :ship:

/snapshot

/snapshot

/snapshot


Enhancement: Display Expected Results for a Contains Only Failure Using Json Formatting

Currently when there is a failure in a containers only assert, the expected value displays using a non-JSON format that doesn't parse with applications like Notepad++, and omits double quotes around string values.  As Karate is very strict on type matching, missing the strings can especially look confusing if the reason for the failure is not immediately evident.
Example:
get_payments.feature:58 - path: $.data[*],actual: [
	{
		"paymentDate": "2018-08-15",
		"paymentMethod": "Check",
		"amountPaid": 645.27,
		"bankAccount": "111",
		"amountApplied": 645.27,
		"amountUnapplied": 0.0,
		"transactionType": "Invoice",
		"invoiceDate": "2018-07-20",
		"applicationDate": "2018-08-16",
		"totalAmount": 645.27,
		"toleranceAmount": 0.0,
		"anticipatedAmount": 0.0,
		"discountAmount": 0.0,
		"writeOffAmount": 0.0,
		"chargebackAmount": 0.0,
		"debitOrCreditMemoApplied": 0.0,
		"openAmount": 0.0
	}
], expected: {amountApplied=645.27, discountAmount=0.00, toleranceAmount=0.00, invoiceDate=2018-07-20, openAmount=0.00, chargebackAmount=0.00, transactionType=Invoice, totalAmount=645.27, anticipatedAmount=0.00, writeOffAmount=0.00, amountPaid=645.27, paymentMethod=Check, paymentDate=2018-08-15, amountUnapplied=0.00, applicationDate=2018-08-16}, reason: actual value does not contain expected

tagging as help wanted

moving to project board: https://github.com/intuit/karate/projects/3#card-41317059


Avoiding future risk in signal-hook-registry's global data

We're updating our vendored version of signal-hook and signal-hook-registry in fuchsia, and we noticed some mild risk around how GlobalData is initialized. As best as we can tell things looks safe, but it's possible there could be some codepath down the road where a signal handler was registered before a call for GlobalData::ensure(). If that happened, a future call to GlobalData::ensure() could overwrite data being used in a signal handler and possibly trigger undefined behavior.
To avoid this risk, what do you think about using once_cell::race::OnceBox, which as best as I can tell is async-signal-safe since it only uses atomics. Or if you don't want to gamble on once_cell potentially becoming async-signal-unsafe, we could draw inspiration from it, and switch to something like:
    struct GlobalData { ... }

    static GLOBAL_DATA: GlobalCell<GlobalData> = GlobalCell {
        inner: AtomicPtr::new(),
        _phantom: PhantomData,
    };

    struct GlobalCell {
        inner: AtomicPtr<GlobalData>,
        phantom: PhantomData<Option<Box<T>>,
    }

    impl GlobalCell {
        // async-signal-safe
        pub(super) fn get(&self) -> Option<&'static GlobalData> {
             let ptr = self.inner.load(Ordering::Acquire);
             if ptr.is_null() { None } else { Some(unsafe { &*ptr }) }
        }

        // async-signal-unsafe
        pub(super) fn ensure(&self) -> &'static GlobalData> {
            let mut ptr = self.inner.load(Ordering::Acquire);
            if ptr.is_null() {
                let ptr = Box::into_raw(Box::new(GlobalData { .. }));

                let exchange = GLOBAL_DATA.inner.compare_exchange(
                    ptr::null_mut(),
                    ptr,
                    Ordering::AcqRel,
                    Ordering::Acquire,
                );

                if let Err(old) = {
                    drop(unsafe { Box::from_ptr(ptr) });
                    ptr = = old;
                }
            }

            Ok(unsafe { &*ptr })
        }
    }

Um, can you describe what the risk you're afraid actually is?
I mean, the fact that anyone trying to put anything into the data goes through the ensure is a core assumption. If anyone violates that, I'd say a lot more than just losing bit of data would break.
I'm not against what you propose, per se (I'd probably want to simplify it a bit ‒ instead of that exchange failing & retrying, it probably should panic ‒ the initialization is also protected by a mutex; get before initialization should probably be a hard-abort as that's a completely broken state). But I don't really see what it brings. This is one of the lesser traps in this code and one really needs to tread very carefully in here.


feat(pingcap/tidb-binlog): manage tidb-binlog with jobdsl

manage tidb-binlog with jobdsl.

/lgtm


Provide ShareGPT4V filtered annotations file

In datasets_mixture.py there is references a .json file that is not entirely clear where it came from based on the name: https://github.com/Efficient-Large-Model/VILA/blob/main/llava/data/datasets_mixture.py#L62
Is this file the same as https://huggingface.co/datasets/mit-han-lab/ShareGPT4V/blob/main/filter-share-captioner_coco_lcs_sam_1246k_1107.json?
if not, can you provide this file or some description of how it was generated?

That's correct. You may use the https://huggingface.co/datasets/mit-han-lab/ShareGPT4V/blob/main/filter.py to process the Sharegpt4V.


i2cdetect -F BUS_NUM states that nothing is supported; No ability to detect devices on the Bus

Hello,
came across your lovely project here and wanted to use instead of my cp2112 as a generic i2c interface.
First thing for me usually is to see if any devices get detected on the connected Bus.
This of for checking if i didn't mess up and switch SDA with SCL or something for example.
With your Release 1.0 Image, i got an error message that the Bus doesn't support detection features.
i2cdetect -F returns that none of the Features are supported.
For me this means that i can't use the project as it is right now.
In comparison, with a different Project all of them are reported supported and detection works as expected.
Link for reference: https://github.com/dquadros/I2C-Pico-USB

Maybe i didn't reset / re-plug the Pico after flashing which might have been the cause.
Just ran into the same issue with the linked project and repluging solved it.


[4.x] TypicalBot Product Analytics

Enhancement Suggestion
Product analytics that better shows how the bot is being used.
Description

Usefulness

Gives a better understanding of what part of the bot is most important to majority of users.
Have You...?

[ ] I have checked previous issues to see if my enhancement or feature has already been suggested.
[ ] I have checked previous issues and pull requests to see if my enhancement or feature has already been completed for an upcoming release.

I've been doing some work in this area in determining the best way to implement some telemetry of some kind, but there's some considerations that need to be made, most importantly of which is user privacy.

Implemented as of e8ebe70.


Use safe-buffer

Use the new Buffer APIs from Node v6 for added security. For example,
Buffer.from() will throw if passed a number, unlike Buffer() which
allocated UNINITIALIZED memory in that case.
Use the safe-buffer package for compatibility with previous versions
of Node.js, including v4.x, v0.12, and v0.10.
https://github.com/feross/safe-buffer

3.0.8


Restaurant  example is not working as expected

Rasa Core version: 0.7.9 (Tried 0.8.3 also)
Python version: Python 3.5.2
Operating system (windows, osx, ...): Ubuntu 14
Issue: The Restaurant is not working as expected. I have taken all the files from Github https://github.com/RasaHQ/rasa_core/tree/master/examples/restaurantbot. But, when I run this example, it is giving random responses. It looks like it is not understanding my input at all. Please see the below response. Am I missing anything here?
Bot loaded. Type a message and press enter :
Me-Hello
Bot-if you'd like to modify anything else, please tell me what
Me-moderately priced restaurant that serves creative food
Bot-if you'd like to modify anything else, please tell me what
Most of the time it replied as "if you'd like to modify anything else, please tell me what"
Below warning i am getting when i train model " python3 -m rasa_nlu.train -c nlu_model_config.json --fixed_model_name current"

Hi, with python3 -m rasa_nlu.train -c nlu_model_config.json --fixed_model_name current you only train NLU model. You also need to train dialogue policy

@Ghostvv I had  train dialogue policy also.Below are command i used to run complete application
ython3 -m rasa_nlu.train -c nlu_model_config.json --fixed_model_name current
python3 bot.py train-dialogue
python3 bot.py run

@artiberde27 thank you for your answer, I've just run it on my machine with last rasa_core version and got correct behavior:
Bot loaded. Type a message and press enter:
hi
/anaconda/lib/python3.6/site-packages/sklearn/preprocessing/label.py:151: DeprecationWarning: The truth value of an empty array is ambiguous. Returning False, but in future this will result in an error. Use `array.size > 0` to check that an array is not empty.
  if diff:
how can I help you?
i want some mexican food
/anaconda/lib/python3.6/site-packages/sklearn/preprocessing/label.py:151: DeprecationWarning: The truth value of an empty array is ambiguous. Returning False, but in future this will result in an error. Use `array.size > 0` to check that an array is not empty.
  if diff:
I'm on it
where?

Could you please provide more details?

To solve the "UndefinedMetricWarning" that pops up during training of the NLU, you can see the solution posted here.
#136


Error 500 when order is placed

With the bare minimum store and the demo data there are some pages that cause 500 error (caprover logs don't help much, just show a 500 error).
You can try it out by placing an order with the demo data.

Can't reproduce it.
Maybe smtp server credentials wrong. Start with APP_ENV=dev

That was it. Sorry to have opened an issue. I had a blank space at the end of the smtp address. I couldn't find the answer elsewhere. You saved me! Thank you for your work on the one click caprover app.


Navigate to default namespace from settings

What was changed

Starts navigating to the default namespace set through Settings
Related PR https://github.com/temporalio/ui-server/pull/101
Why?

Allows to customize the default namespace to navigate to
Checklist

Closes

How was this tested:

scenario A: Temporal service is offline (or throws errors)

Navigate to both http://localhost:3000/ and http://localhost:3000/namespaces
Expected: redirects http://localhost:3000/namespaces/default/workflows
Navigate to http://localhost:3000/namespaces/accounting/workflows
Expected: should stay on http://localhost:3000/namespaces/accounting/workflows

scenario B: defaultNamespace is set to empty string in settings ``

Navigate to both http://localhost:3000/ and http://localhost:3000/namespaces
Expected: redirects http://localhost:3000/namespaces/default/workflows
Navigate to http://localhost:3000/namespaces/accounting/workflows
Expected: should stay on http://localhost:3000/namespaces/accounting/workflows

Scenario C: defaultNamespace is set to sales

Navigate to both http://localhost:3000/ and http://localhost:3000/namespaces

Expected: redirects http://localhost:3000/namespaces/sales/workflows

Navigate to http://localhost:3000/namespaces/accounting/workflows

Expected: should stay on http://localhost:3000/namespaces/accounting/workflows

Any docs updates needed?

Closes #265.


[AIRFLOW-2139] Don't use private methods of a third-party package

WIP but this at least poses problems when migrating into a newer pandas-gbq version.
Make sure you have checked all steps below.
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title.

https://issues.apache.org/jira/browse/AIRFLOW-2139

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
No UI or API changes

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
pandas-gbq already tests the functionality

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Codecov Report

Merging #3066 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3066   +/-   ##
=======================================
  Coverage   73.27%   73.27%
=======================================
  Files         179      179
  Lines       12490    12490
=======================================
  Hits         9152     9152
  Misses       3338     3338

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30253c...f844b49. Read the comment docs.

@kaxil what's your opinion on this?

@hgrif do you have any experience with this?

@Fokko I haven't used Pandas GBQ but I would do it in few days and update it here in case this PR is still open.
@mremes Can you confirm that you have tried using get_pandas_df() method?

@Fokko : No, I've never used it. The library is also being used in pandas btw: https://pandas.pydata.org/pandas-docs/stable/generated/pandas.read_gbq.html

@kaxil using the hook in a custom operator. get_pandas_df() broke when pandas-gbq dependency is updated to version 0.3.1. It's doing what is expected, as can be read from the read_gbq docstring.

It's about KISS, I guess?

@mremes Thanks for updating. I agree that using private methods is not good practice. But I've never used the code, so thanks @kaxil and @hgrif for taking a look at it. Cheers!


Formatting extensions not working

Type: Bug
Download Black Formatter extension, set it as the default formatter and select a .py file and dilberately mess with the formatting and attempt to use Black Formatter to fix formatting in the file. (It didn't work when I tried)
VS Code version: Code 1.85.2 (8b3775030ed1a69b13e4f4c628c612102e30a681, 2024-01-18T06:40:10.514Z)
OS version: Windows_NT x64 10.0.22621
Modes://

System Info

Item
Value

CPUs
Intel(R) Celeron(R) N4020 CPU @ 1.10GHz (2 x 1094)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: disabled_offopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
3.82GB (0.20GB free)

Process Argv
--crash-reporter-id e42f6d51-5a61-4ca9-bf98-69f920fa12cc

Screen Reader
no

VM
0%

Extensions (5)

Extension
Author (truncated)
Version

prettier-vscode
esb
10.1.0

black-formatter
ms-
2023.6.0

debugpy
ms-
2023.3.13341008

python
ms-
2023.22.1

vscode-pylance
ms-
2023.12.1

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30933248
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
accentitlementsc:30887149
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
3ef8e399:30949928

@benjaminphalane How are you triggering formatting? You can also see Output > Black Formatter logs to see why it was not formatted.

I triggered formating by using both the "shift+alt+f "shortcut as well as the "format document with" option and nothing happened. I also checked the log according to it everything seems to be in order :

The screen shot shows the error. According to Python parser there is syntax error because there is an indent on line 4 that is not valid in Python.

I created that error on purpose to test the formatting extension.

You can try the following to see if formatting works:
Before:
x=[1,1]

After:
x = [1, 1]

We black code from formatting if there are syntax errors. This is to preserve the current experience with notebooks. It will get better when we implement support to handle notebook cells with cell magic (like %%time).

It works, thanks. I was surprised because the tutorial I'm following on YouTube had this working like a charm.


ExcelBuffer with capability work with more than one sheet when reading file

This PR aims to extend ExcelBuffer with capability to read multiple sheets Excel files without continously reopening file. Originally ReadSheet closes file after reading one sheet, so I extended Excel buffer with the following functions:
ReadSheetContinous - basically does the same as ReadSheet but has options to select if files should be closed on completion and to select sheet name.
SetActiveReaderSheet - lets change currently used sheet for reader.
GetSheetsNameListFromStream - returns list of sheet names in file stream.
SaveToStream - somehow there are fuctions to open Excel file from stream, but no way to save it back to stream. Sometime we do not want to return file directly to user (DOWNLOAD function), but for example to save it to Blob. This is when this function becomes useful.

Hi there! Glad to see that you’d like to collaborate. We have received your request and we’re looking at it now, we’ll get back to you shortly with a go/no-go decision.


fix: handle topk: volume POC

Approach detail:
Support topk when filtered based on global variable.
issue: topk would by default find top k element from different different time range and show all, it's not able to choose from consolidated list.
reference: https://www.robustperception.io/graph-top-n-time-series-in-grafana
Fix:

when filtered based on svm, it gets all volumes from svm with topk applied
when filtered based on volume, it gets only volume records, not topk
when not filtered on svm/volume, it gets records with topk applied

There are few disadvantages of this approach:

too many hidden variables in dashboard

If topk query identify volume VOL1, then it list all volumes named VOL1 from all svms even it's not belongs to top most list. [This is same as volume filter, it shows all volume with same name when applied]

Can this be closed?


update the default Docker adapter settings

have the Docker adapter start privileged containers by default
this is required for using Docker in Docker for Enterprise, and also helps resolve certain issues reported by customers related to starting and using services within jobs.
Please note: I'm not sure if this was best to add to /etc/default/travis-worker or /etc/default/travis-enterprise`

Merging this as-is would complicate things when we're ready to move EC2 to the Go Worker and use the packages for our AMIs, as we need privileged turned off in that context, for now.
Could we compromise on adding it commented out and then adding an option to the installer to enable it? This would mean it's not hard to enable at install time and is also pretty painless to enable later.

fwiw, proposed modification in #148 :heart_eyes_cat:

Superseded, and merged!

Egad!  I did this wrong.


Update the Postman url

Hi there,
the Postman URL has changed from  www.getpostman.com to www.postman.com.
I have created a PR: https://github.com/AdobeDocs/experience-platform.en/pull/14

Outdated links have been updated:

https://docs.adobe.com/content/help/en/experience-platform/tutorials/authentication.html
https://docs.adobe.com/content/help/en/experience-platform/data-science-workspace/authoring/feature-pipeline.html


Page bundles / nested navigation

🚀 Feature
I'd like Docusaurus to feature something like Hugo's page bundles:
https://gohugo.io/content-management/page-bundles/
As far as I can tell, Docusaurus only allows for a single level of documentation: all docs are in the same folder and there's no depth beyond that level. This prevents from creating complex documentation. For instance, in Docusaurus I cannot have something like...
- Index.md
  - /assets
  - /section
     - index.md
     - another page
     - /assets
     -/subsection
             - index.md
             - /assets

Have you read the Contributing Guidelines on issues?
Yes.
Motivation
Docusaurus cannot scale beyond very simple documentation projects if it doesn't support this sort of nesting.
Pitch
I'd like to be able to have a folder structure within /docs and have the build process go through it recursively, and build an overall ToC out of it.

@theletterf

As far as I can tell, Docusaurus only allows for a single level of documentation: all docs are in the same folder and there's no depth beyond that level.

This is not true. You can actually nest your doc as deep as you like.
Example:
https://github.com/olistic/warriorjs/tree/master/docs

Ha! Then it is possible after all. Going to look into that. I couldn't find any reference on that in the docs...

You have to set the navigation on your own. (e.g: headerlinks). If you need high level TOC document, you can build your own markdown docs as a high level TOC doc. Else, high level TOC in sidebar might be possible as well (see #868)
Either way, I think the main point is that you can nest your docs so I'm closing this.

Thanks!

@theletterf I thought we had the nested docs information on docusaurus.io, but maybe we didn't add it.
Would you like to submit a PR to add the information? Probably either in https://docusaurus.io/docs/en/site-creation or https://docusaurus.io/docs/en/site-preparation?

Sure.

Nesting works fine for *.md files, but I am unable to link to any static assets in a bundled directory.
I've tried in a assets subdirectory docs/foo/assets/bar-example.png and in the root directory docs/foo/bar-example.png.
Is this supported?


Version of Map API causing rendering error in carto-vl

Setup

carto-vl v1.4.6
6 months old image sverhoeven/cartodb on dockerhub to have a response from http://localhost/user/dev/api/v1/map (see https://github.com/sverhoeven/docker-cartodb/issues/87)

Problem

TypeError: n is undefined (carto-vl.min.js:6:500820) when parsing the response from http://localhost/user/dev/api/v1/map, happening when executing o=n.hasOwnProperty("featureCount")?n.featureCount:n.estimatedFeatureCount

Cause

http://localhost/user/dev/api/v1/map returns a meta object consisting of only two objects but https://github.com/CartoDB/carto-vl/blob/b52fdfcbdb89baffba343dab060c855f5cdef445/src/client/windshaft.js#L512 introduces const { stats, aggregation, dates_as_numbers } = meta;
The last working commit is https://github.com/CartoDB/carto-vl/blob/10758745aa488a1b55f7e902c51f77124b78147a/src/client/windshaft.js#L550 with const { stats, aggregation } = meta; included in carto-vl v0.4.0
carto-vl v0.4.0 seems to not work with subdomainless addresses

This is possibly a problem with carto-vl as the problem doesn't occur with carto.js. I have to investigate it further


Possible to "miss" very short missions

Most of our samples do something similar to this:
agent_host.startMission( my_mission, my_mission_record )
# Wait for start of mission (is_mission_running flag)
world_state = agent_host.getWorldState()
    while not world_state.is_mission_running:
        time.sleep(0.1)
        world_state = agent_host.getWorldState()

It's possible to create missions that can finish within 0.1 seconds - for example, in a setting where an agent must get to a goal square, but the start and end squares are randomised, it is possible for the agent's initial state to satisfy the end conditions.
In such cases, the above code can end up waiting forever, as the is_mission_running flag can be set and then unset again within the time.sleep() call.
One possible fix is to reduce the sleep time; alternatively, agent_host could have an is_mission_over flag too, instead of relying on is_mission_running.

Make startMission block until mission started? New API startMissionAndWait?
Samples should use peekWorldState too.


GD-129-2: Decoupling TestSuite class and make it internally

TestSuites now not extending anymore from TestSuite

continue on https://github.com/MikeSchulze/gdUnit3/pull/221 because of push force mistake ;)


Add clarification regarding U-Boot versions and auto-patching

Signed-off-by: Drew Moseley<EMAIL_ADDRESS>

OK.  I added a further clarifying statement.  Please review it and let me know your thoughts.


MassMutual - Logo has a checkered background

ENVIROMENT: production
COMPANY: MassMutual
URL: MassMutual peviitor.ro
Browser: Google Chrome
Device: laptop
OS: MacOS
Precondition:
The site must be open in browser.
Steps:

Observe the company's logo

Expected result:
The logo image has a clean background without any checkered pattern.
Actual result:
The company's logo has a checkered background.

@cristiol change logo url from scraper


feat(test): support capturing coverage from all files

As a developer, I want to be able to run tests and have the reported coverage be absolute rather than just based on the imported paths so that I can have a wholistic overview of the level of test coverage.
Currently, if a file is not imported as part of a test it will never be reported via coverage and will not be reflected in the overall coverage metrics.
Proposal
Introduce a --collect-coverage-from option that will allow developers to control how coverage is collected.
Options

imports (default): collect coverage from imported files only
all: collect coverage from all files

# Run tests and require 100% coverage across all files
very_good test --min-coverage 100 --collect-coverage-from all

Enums of two values can be like booleans. Cant that be a flag instead of an option? Then we have possibility of abbr for an even shorter syntax?

What would be the use case for only wanting import coverage, and not all? The way I see it, my initial reaction was that this was a bug in the test command in Dart, and not a design feature. That's why I can only see value at the moment of having all as the only option really that makes sense.

That makes it easy haha however it would technically be a breaking change.

I like:
--collect-coverage-from-all (default false)

However, I agree with @jorgecoca feels that the default behaviour should be collect-coverage-from-all.  Perhaps, a breaking change can be made, if we decide so, and --collect-coverage-imports-only, now defaulting to false, (cc: @renancaraujo ).

@alestiago Agreed! As long it is a flag defaulting to false, either is ok for me.

As a workaround for this, I wrote a dart script that programmatically generate a "coverage_helper_test.dart"  that imports all project's dart files before running the tests. As a result, it collects coverage from all files, even those files we are not testing, and help us understand how tested a project is.
I'm not sure if it's what you or the community is looking for, but works fine. Perhaps the same algorithm could be used when --collect-coverage-from-all flag is used.


Run/Debug test should show when a test cannot be run due to a compilation error.

dotnet --info output:
.NET Command Line Tools (1.0.0-preview2-1-003177)

Product Information:
Version: 1.0.0-preview2-1-003177
Commit SHA-1 hash: a2df9c2576

Runtime Environment:
OS Name: ubuntu
OS Version: 16.04
OS Platform: Linux
RID: ubuntu.16.04-x64

VS Code version:
Version 1.9.1
Commit f9d0c687ff2ea7aabd85fb9a43129117c0ecf519
Date 2017-02-08T23:44:55.542Z
Shell 1.4.6
Renderer 53.0.2785.143
Node 6.5.0
C# Extension version: 1.7.0
Steps to reproduce
Run a test with a non-compiling project.
The runner will output "Running test [test name] ..."
No further output will appear if the test fails due to lack of compilation.
Expected  behavior
The test runner will report that the project cannot be compiled.
Actual behavior
The test runner reports nothing.

The work I'm currently doing should improe the test output for running tests with project.json .NET Core projects. In the next release, it should look like this:
Running test Main.Test.MainTest.Test...
xUnit.net .NET CLI test runner (64-bit .NET Core win10-x64)
  Discovering: LegacyXunitTestProject
  Discovered:  LegacyXunitTestProject
  Starting:    LegacyXunitTestProject
  Finished:    LegacyXunitTestProject

Test passed

Running test Main.Test.MainTest.DataDrivenTest2...
xUnit.net .NET CLI test runner (64-bit .NET Core win10-x64)
  Discovering: LegacyXunitTestProject
  Discovered:  LegacyXunitTestProject
  Starting:    LegacyXunitTestProject
  Finished:    LegacyXunitTestProject

Test passed

Running test Main.Test.MainTest.DataDrivenTest1...
xUnit.net .NET CLI test runner (64-bit .NET Core win10-x64)
  Discovering: LegacyXunitTestProject
  Discovered:  LegacyXunitTestProject
  Starting:    LegacyXunitTestProject
      Assert.True() Failure
      Expected: True
      Actual:   False
      Stack Trace:
        c:\Projects\LegacyXunitTestProject\TestProgram.cs(18,0): at Main.Test.MainTest.DataDrivenTest1(Int32 i)
  Finished:    LegacyXunitTestProject

Test failed

Excellent, thanks for the update. I like the output - that will be very helpful, especially the stack trace on error.

OK. I'm going to go ahead and close this. 1.9.0 should be out soon (hopefully in a day or two) and that will include the improved output above.


updated page: trademark guidelines

the new page head can now be defined and added via frontmatter: pagehead:

"Page Title"
"bg2"

Thanks!


ctrl+click url does not change virtual desktop

Environment
Windows build number:  [Version 10.0.19042.804]
Windows Terminal version (if applicable): 1.5.10271.0

My browser runs on Virtual Desktop 1, my Windows Terminal runs on Virtual Desktop 3. When I Ctrl-click a link inside the terminal, the URL is correctly opened in the browser - but I remain at Virtual Desktop 3. I understand that this behavior might be preferred by some, but there are at least two other UX patterns worth considering (that are implemented in other OSes) as well:

switching to the browser's desktop (I would prefer this one)
bringing the browser to terminal's desktop

All we do is tell the OS to "please launch this URL". Anything that happens after that is out of our control -- otherwise, we would have to run a detection pass for windows belonging to any browser--manually!--and try to focus them. That seems like the wrong thing to do.

I see. 🤷


Support for compiling, testing, assembling and maintaining Multi-Release JARs

JEP 238 added support in the JDK for "Multi-Release JARs" that expose different class files depending on the JDK version they are run under.  This allows a library supporting multiple JDK versions to use different implementation classes to either take advantage of new APIs or to avoid deprecated (or removed) APIs.
The JDK itself only provides support for assembling multi-release JARs from existing class-files using the JAR tool and consuming them through the JDKs class-loaders. The JDK provides no support for:

Compiling the needed class-files.
Enforcing a sufficient level of signature compatibility between the different versions.
Executing unit/integration/system tests across the relevant JDK versions.

It would be good to see gradle providing build-time support to close this gap and make MR-JARs a much more palatable prospect.
In an idea world I'd like to see MR-JAR support be as simple as adding java sources under convention defined directories, say: src/main/java<N> and src/main/resources<N>. Gradle would then build the resultant multi-release JAR while enforcing a suitable level of JDK compatibility.  Java  specific test classes would go under src/test/java<N> and would result in multiple test executions: one using the default Java version, and one using Java  where the test set is the union of the two source sets.
This is just one proposal. I'm really not picky about how this is achieved as long as it feels natural in a Gradle environment. What I really want is for the Gradle community to pick up the ball that the JDK community dropped and bring this feature in to a useful state.

There are different things in one. The first one is the ability to have different folders representing different classes for different platforms. Gradle has all the infrastructure to do this, but it requires, today, a bunch of manual setup.
Then, there's the packaging problem. Should you produce a multi-release jar, or different jars for different platforms. Our general recommendation is that different jars are more likely to be what you need.
It doesn't matter what packaging you choose, the underlying model should be the same. Gradle can be a lot smarter if you use different variants instead of multi-release jars.

Hey there @chrisdennis,
Because neither JPMS in general nor MRJARs in particular have been embraced by a sufficient-enough percentage of the Java developer community, I can appreciate why Gradle doesn't see it as feasible to dedicate resources to implement support for it.  I'm finding that you and I are, unfortunately, a teeny-tiny percentage of Java developers interested in Multi-Release JAR files.
Gradle core devs are offering this advice to users with requirements like yours and mine:

„...Your best bet is to look for a community plugin that adds support for Java modules...“

A few weeks ago I searched for a Gradle plugin that supports creating Modular MRJAR Files. I never found that plugin. Instead, I found your issue report here. Your proposals inspired me to knock out the mrJar plugin. I introduced v0.0.1 a couple days ago in this Gradle Forums post.
After some valuable feedback offered in that post from the community, mrJar is now at v0.0.6. If you check out the mrJar.java9.modules.usage demo project, I hope that demo confirms for you that v0.0.6 of the plugin delivers close to 70%-80% of the features you're proposing in this issue.
With sufficient adoption and helpful feedback, I'm confident that mrJar should eventually implement 100% of your requested bullet points. Please let me know what you think? TIA.

I had a little play with mrJar a couple of days ago.  Things didn't work immediately for me, and I haven't had a chance to get back on it yet. One thing right now that might be a showstopper for mrJar though is that it's not open source. If I can inspect the code running in my build-system I'm not sure I can trust it when I need to run it on privileged machines - when publishing to sonatype for example.

Thanks for getting back @chrisdennis. Yeah versions 0.0.1 - 0.0.3 had teething problems. Naturally.

„...I'm not sure I can trust it when I need to run it on privileged machines...“

I'm under no illusions that those first two, three versions were ready for prime time :)
At this super early stage of the plugin's development there are absolutely things that need to be looked at, refactored, revisited. That's the reason I reached out to the Gradle community. My intention for reaching out, is not to say: „Here. Start using this on your privileged machines. Now!“.
But rather for actual end users — who would use the plugin in ways I had not envisaged during development — to help weed out defects in the plugin's functionality that are the result of either incorrect assumptions I made during development, And/or to reveal bugs in the functionality caused by my incomplete knowledge of every single use case the plugin might be applied in.

„...I can't inspect the code running in my build-system...“

I can appreciate that. Absolutely. But I don't think — for an end user specifically — seeing the source code is necessary to discover bugs in the plugin's functionality. Certainly not at this stage of development.
If you check out the demo project, you wouldn't be running it on your own code. But hopefully, the demo confirms how the plugin's functionality (from an end-user's perspective) is improving with each release.
And if you run into any problems running the demo, feedback on what the plugin does wrong in the demo and related issue reports in that demo's repository there, will help improve the plugin's functionality even more.
I find that Steps to reproduce help resolve bugs a whole lot quicker. TIA.

ping

fwiw: https://github.com/melix/mrjar-gradle-plugin


Tombstones are not reaped if reaping occurs before tombstones reach all replicas

Tombstones may not be reaped if reaping occurs before tombstones are written to all replicas.
Scenario

Tombstone is written
https://github.com/basho/riak_kv/blob/cada9c75fed524ec5b45404448a4b30255667fab/src/riak_kv_delete.erl#L80

Tombstone is reaped
https://github.com/basho/riak_kv/blob/cada9c75fed524ec5b45404448a4b30255667fab/src/riak_kv_delete.erl#L86

riak_kv_get_fsm checks for final action ( delete | read_repair | noop )
https://github.com/basho/riak_kv/blob/cada9c75fed524ec5b45404448a4b30255667fab/src/riak_kv_get_fsm.erl#L282

riak_kv_get_core checks if any replicas of the object (RObj) don't match the merged object (MObj)

If one of the replicas returns an older version during tombstone reaping, the riak_kv_get_core check returns read_repair rather than delete.
The riak_kv_get_fsm should be able to delete the object rather than read repairing if one of the replicas returns an object older than the tombstone.
Below is an example set of replicas that will result in a read repair rather than a delete:
[{274031556999544297163190906134303066185487351808,
  {ok,{r_object,<<"foo">>,<<"9698">>,
                [{r_content,{dict,6,16,16,8,80,48,
                                  {[],[],[],[],[],[],[],[],[],...},
                                  {{[],[],[[<<"Links">>]],[],[],[],[],...}}},
                            <<"hello world">>}],
                [{<<"úZ»/O{=\t">>,{1,63500707125}}],
                {dict,1,16,16,8,80,48,
                      {[],[],[],[],[],[],[],[],[],[],...},
                      {{[],[],[],[],[],[],[],[],...}}},
                undefined}}},
 {296867520082839655260123481645494988367611297792,
  {ok,{r_object,<<"foo">>,<<"9698">>,
                [{r_content,{dict,4,16,16,8,80,48,
                                  {[],[],[],[],[],[],[],[],...},
                                  {{[],[],[],[],[],[],...}}},
                            <<>>}],
                [{<<"úZ»/O{=\t">>,{2,63500707280}}],
                {dict,1,16,16,8,80,48,
                      {[],[],[],[],[],[],[],[],[],...},
                      {{[],[],[],[],[],[],[],...}}},
                undefined}}},
 {251195593916248939066258330623111144003363405824,
  {ok,{r_object,<<"foo">>,<<"9698">>,
                [{r_content,{dict,4,16,16,8,80,48,
                                  {[],[],[],[],[],[],[],...},
                                  {{[],[],[],[],[],...}}},
                            <<>>}],
                [{<<"úZ»/O{=\t">>,{2,63500707280}}],
                {dict,1,16,16,8,80,48,
                      {[],[],[],[],[],[],[],[],...},
                      {{[],[],[],[],[],[],...}}},
                undefined}}}]

We spent quite a bit of time today discussing this behavior and have decided to roll better reaping functionality into AAE as opposed to relying entirely on the get after put which might not be done propagating(depending on dw/pw settings). Additionally, when AAE is used as a view of the data for scans etc, we'll be smarted about sifting out tombstones.
Thanks everyone for their discussion and contributions. Closing this issue.


Add "ord wallet cardinals" command to list the cardinal outputs.

There's no easy way to find a list of cardinal outputs. You have to list all the outputs and remove the inscriptions.
Hence: ord wallet cardinals.

This would really be helpful. I'm overwhelmed with the list of outputs and have difficulty discerning how many cardinal UTXOs and the balances that remain. @raphjaph Would you be the right person to tag for review?


Added entry to index.html

@aedorado contribute to https://github.com/Ishaan28malik/Get-Dev-Resources instead.


Fix warnings in unit tests

What is being addressed
There were warnings thrown from unit tests run since the async client change. This PR fixes it.

/test


Bowling scoreboard UI

Players need to be able to see their current score - perhaps a toggleable user interface, or a screen somewhere in the world? Discussion appreciated.

I like the idea of having this solely displayed in the world; above the lane as you'd get in real life.

That'd be cool for vr but I feel pancake should still have a normal scoreboard


get anime by name not by id

there is no way to get the anime without having the id?

Use anime search?
https://docs.api.jikan.moe/#tag/anime/operation/getAnimeSearch
Feel free to ask questions on our discord server: http://discord.jikan.moe/


Dragon avatars are clipped

Seems like dragon avatars (and possibly other large/epic ones) are not displayed correctly

The same thing happens in vanilla plug:

Might also be worth slapping plug.dj devs over :smile: Perhaps tiny plug fixes like these could live in ExtPlug core, or a default plugin.


[Feature Request]:

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
This feature will provide users with personalized workout and diet plans based on their individual fitness goals, body type, and health conditions. The system will use input data such as age, weight, fitness level, dietary preferences, and health conditions to generate customized exercise routines and meal plans. The suggestions will be tailored for users aiming for different goals, such as weight loss, muscle gain, or general fitness maintenance. It will also take into account dietary restrictions (e.g., vegetarian, vegan, gluten-free) and exercise preferences (e.g., strength training, cardio, yoga).
Use Case

Personalized Fitness Plans: Users can input their fitness goals, and the system will generate tailored workout routines and diet suggestions to help them achieve those goals.
Health and Nutrition Monitoring: Users with specific dietary needs or fitness constraints (e.g., due to medical conditions) can receive suggestions that align with their health requirements, ensuring they stay on track without compromising their well-being.

Benefits

ailored Fitness and Nutrition: Users receive personalized workout and diet recommendations that are customized to their goals, fitness level, and dietary preferences, ensuring the plans are effective and sustainable.
Convenience: With automatically generated plans, users save time and effort in researching exercises or meals that fit their needs, making it easier to maintain a healthy lifestyle.
Health Optimization: By providing workout and diet plans that take into account the user's health conditions and preferences, the feature promotes balanced, sustainable improvements in both fitness and nutrition.

Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC-EXT contributor
[X] I'm a HACKTOBERFEST contributor
[X] I have starred the repository

@J-B-Mugundh go for it

@jeevan10017 is flask backend fine along with react frontend for this or shall i make a streamlit app and deploy it and add over here as a section?


Feature Request: Collection Names Automatic Off Attributes

Is your feature request related to a problem? Please describe.
Currently I have an audiobook library setup in such a way that every book (or album) is being automatically assigned a mood for the series it is in.  I am using PMM to sudo-automatically create a collection for each such mood, but I do still have to manually specify the name both of the collection to be created, and of the mood to search for (which are nearly identical).  I will list an example of my collection formatting for reference under additional context.
Describe the solution you'd like
I would like the ability to use attributes such as "mood:" or possibly other attributes as well for general purpose on other use-cases in the naming of a collection.  The general setup if this were implemented could work in a similar fashion to the TMDb collections ability to make genre based collections named after their own genre automatically.  Preferably this would allow us to modify the name of the collections generated to not be EXACTLY as the attributes, as in my example my album moods are all "Series: NAMEOFSERIES" and I would prefer not to have "Series:" at the beginning of each of my collections.
Describe alternatives you've considered
I'm not entirely sure what an alternative to this would be aside from manually creating the collections per name, or using an external script to generate such a list.
Additional context

I've made a mock-up of how such a feature could be used if it's possible to implement.


add travis build for cesm shared object test makefile

@bartnijssen - can you tell why this failing? It is working for me locally w/o any errors.
https://travis-ci.org/jhamman/VIC/jobs/74324104#L511

@jhamman : Fixed. I made a PR to the branch on your repo. Once you accept that one, I think it'll show here and this one will resolve OK.


Enhanced Submit Button fixes issue number #303

Pull Request Checklist

[x] I have added screenshots and videos to show before and after the working of my code.
[x] I have ensured that the screen size is set to 100% while making the video.
[x] I have synced the latest fork with my local repository and resolved any conflicts.
[x] I have mentioned the issue number which I created before making this PR .(format to mention issue number is : fixes #(issue number) )
[x] I understand that if any the above conditions are not met , my PR will not be MERGED .

Before

After

follow each point of the PR checklist

follow each point of the PR checklist

Sure mam.

resolve conflicts

resolve conflicts

Resolved all the existing conflicts.

fixes #303


Confusion about the use of "slice_axis" and image orientation

spin-off issue from: https://github.com/ivadomed/ivadomed/issues/1255#issuecomment-1371150578
In general, I feel there are confusing elements around the concept of image orientation. For example, here (and at many other locations) the code assumes that 'axial' refers to the last dimension of a 3D array:
https://github.com/ivadomed/ivadomed/blob/c61ab282ae3b2a2179c5a43b6b58db3d04ab2180/ivadomed/loader/bids3d_dataset.py#L24
But this definition assumes that the input image is oriented in a specific manner. Eg: an RIA (right-inferior-anterior) image would not fit this definition (because in this case, the axial plane would correspond to the 2nd dimension, not the 3rd).
However, there is also the possibility to specify an orientation in the JSON file:
https://github.com/ivadomed/ivadomed/blob/199eba68abe2f3d6627edd72bae6f2aa3b35a45d/ivadomed/config/config.json#L36
So, does this mean that a real axial slice (ie: from the radiological definition, the plane orthogonal to the superior inferior axis) depends on the value of "slice_axis"? I think this should deserve its own issue discussion. What is the need for ivadomed's low level functions to know if an image is axial, sagittal or coronal? And How is the field "slice_axis" used?

100% agree that the slice_axis key is confusing.

But this definition assumes that the input image is oriented in a specific manner.

I think it assumes that the input image is oriented in RAS and then it is converted to HxWxD orientation as seen here while forming the segmentation pair during data loading.

What is the need for ivadomed's low level functions to know if an image is axial, sagittal or coronal? And How is the field "slice_axis" used?

This function essentially transposes the input matrix depending on the corresponding integer value of the slice_axis key. ivadomed by default assumes that slice_axis is "axial" (see this line), meaning that if, in the config, if slice_axis is "axial" then the image is not transposed. So, for ivadomed, setting these parameters tells it how to transpose the matrix, in particular, which dimensions to permute.
Based on my understanding above,

So, does this mean that a real axial slice (ie: from the radiological definition, the plane orthogonal to the superior inferior axis) depends on the value of "slice_axis"?

I don't think this is the case as the slice_axis is simply used to transpose the matrix in order to extract the corresponding 2D slices from the 3D Niftis.
Moreover, slice_axis is also confusing because it only concerned with training 2D models. If we want to train 3D models, setting this key to 'sagittal' or 'coronal' only transposes it and creates more confusion because in datasets where input matrix sizes are not uniform such as 512x512x512 and rather have something like 128x512x64 (e.g. spinal cord data), transposing unnecessarily messes with the CenterCrop parameter.
For e.g., consider this scenario: the user knows that the input size is 128x512x64 and wants to train a 3D model on a sagittal scan (because the GT is given for sagittal scans). Because of the non-uniform input size, the CenterCrop will be something like 64x256x32. However, in the config file, the natural instinct is to set slice_axis as sagittal. But, this transposes the input and re-orients the input to 64x512x128 (because for "sagittal", image.transpose(2,1,0) is used). Now, the CenterCrop will erroneously cut a large portion in the 3rd dimension, thus resulting in something that the user did not expect. This is precisely what happened in the mp2rage project here.
Bottomline is that more discussion is required for this particular parameter and how we could make it less confusing.

Reorientating the input image is still useful, so that the model is always exposed to the same conformation of the object. Eg, when training a model with two different datasets, one axial and the other sagittal, reorienting everything to RPI (ie: axial) will make the model more performant. So it is clear that reorientation needs to be applied at some point in the pipeline. However, I am questioning if the way we deal with reorientation is correct. I'm thinking that reorientation should happen before patching up the data, at the time where we resample the data.
So, how about we make reorientation a "transformation" parameter, that would be defined here:
https://github.com/ivadomed/ivadomed/blob/ab381409e07af1f27a77e0cfb246f33bcc6291bb/ivadomed/config/config.json#L115
and that would take "official" orientation values and the reorientation would be dealt with by nibabel (ie: no need for us to maintain reorientation code, with ad hoc values such as here).


Problem with subtitles

I'm using OpenMediaVault (basically a Debian) with Plex Media Server and my video files are stored in a share. Serenity shows all subtitles which were automatically downloaded by Plex, but all SRT-subtitles which were stored manually next to the video files are recognized by the Plex client but not the Serenity client. Waiting for 20 seconds doesn't help. Does anyone have any solutions for this problem?

Can you get provide some sample XML for the affected movies/tv shows.
You can get more info on how to obtain the xml from here:
https://github.com/NineWorlds/serenity-android/wiki/Serenity-for-Android#bugreports
Also what version of the Plex server are you using?

Thanks for your answer.
Version of Plex-Server:
version="<IP_ADDRESS>.1520-6833552"
For example the problem exists with this one. My Plex client recognises the subtitles, but Serenity doesn't:
 <Directory ratingKey="3472" key="/library/metadata/3472/children" studio="CBS" type="show"   title="Extant" contentRating="TV-14" summary="Extant is an American science fiction television drama series created by Mickey Fisher and executive produced by Steven Spielberg. The story revolves around astronaut Molly Woods (Halle Berry) who returns home to her family inexplicably pregnant after 13 months in outer space on a solo mission." index="1" rating="7.5" lastViewedAt="1447100357" year="2014" thumb="/library/metadata/3472/thumb/1436570955" art="/library/metadata/3472/art/1436570955" banner="/library/metadata/3472/banner/1436570955" theme="/library/metadata/3472/theme/1436570955" duration="3600000" originallyAvailableAt="2014-07-09" leafCount="13" viewedLeafCount="0" childCount="1" addedAt="1436568132" updatedAt="1436570955"><Genre tag="Drama"/><Genre tag="Science-Fiction"/><Role tag="Halle Berry"/><Role tag="Goran Visnjic"/><Role tag="Pierce Gagnon"/></Directory>

Okay, to get the subtitle information we'll have to go deeper into the network.  Can you navigate to the following path:
/library/metadata/3472/children
and get me the XML from there.

Here you go:
/library/metadata/3472/children
 <MediaContainer size="1" allowSync="1" art="/library/metadata/3472/art/1436570955" banner="/library/metadata/3472/banner/1436570955" identifier="com.plexapp.plugins.library" key="3472" librarySectionID="2" librarySectionTitle="TV Shows" librarySectionUUID="8f17487f-5820-47b6-bb7a-17f28021a76d" mediaTagPrefix="/system/bundle/media/flags/" mediaTagVersion="1446075544" nocache="1" parentIndex="1" parentTitle="Extant" parentYear="2014" summary="Extant is an American science fiction television drama series created by Mickey Fisher and executive produced by Steven Spielberg. The story revolves around astronaut Molly Woods (Halle Berry) who returns home to her family inexplicably pregnant after 13 months in outer space on a solo mission." theme="/library/metadata/3472/theme/1436570955" thumb="/library/metadata/3472/thumb/1436570955" title1="TV Shows" title2="Extant" viewGroup="season" viewMode="65593"><Directory ratingKey="3473" key="/library/metadata/3473/children" parentRatingKey="3472" type="season" title="Season 1" parentKey="/library/metadata/3472" summary="" index="1" lastViewedAt="1447100357" thumb="/library/metadata/3473/thumb/1436570955" leafCount="13" viewedLeafCount="0" addedAt="1436568132" updatedAt="1436570955">

Hmmm... that xml doesn't contain what I was lookng for, I may have given you the wrong path to extract.  Let me take a look at the code to see what section the subtitle look is looking for.

Alright looks like we need to go down at last another level or two to get to the actual show meta data.
Can you send the XML from:
/library/metadata/3473/children
That should give us a larger amount of XML, and then from there we'll need to get one more list that actually contains the full list of metadata that contains the subtitle info.

Sorry for the super late response,  neither of these contained the necessary XML.  I'm going to start work on some updates so I'll try and retest this and get some more information out on the particular XML that is needed.  I also need to test against the latest Plex servers.

No problem, I'll just wait. I would have to wait anyway.

I mostly use the original Plex-App now, so this problem didn't really bother me anymore. I just did use Serenity and I got the solution by chance.
If I use Serenity, it's always with the folder view, in which one file is shown above the other. It didn't really occur to me to click on a single season poster on the bottom. When I did, the single episodes were displayed one at a time. And in this folder view I can choose subtitles.

Ah... that makes sense.  Yeah the single episode listing is going to give you more detail.


passage_embeddings

I don't understand how the passage_embeddings are generated?

star/inference.py computes the passage embeddings.
adore/inference.py utilizes the existing passage embeddings generated by star/inference.py.


[Bug][UI Next][V1.0.0-Alpha] An error occurred while importing workflow

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
An error occurred while importing workflow
The reason for the error is that：tenant not exists

What you expected to happen
The modification is saved successfully
How to reproduce
Import workflow and modify content click Save
Anything else
No response
Version
dev
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I will solve this.


Infinite (SSE) streams always raises hyper::Error(IncompleteMessage) / connection closed before message completed

Version
1.4.1 full
Platform
windows 11 64b
Description
For (possibly infinite) SSE streams, when client disconnects (ex. closes connection), hyper connection always returns error of type hyper::Error(IncompleteMessage).
I tried this code:
I used server example from official website + tokio IntervalStream for body:
use std::convert::Infallible;
use std::net::{Ipv4Addr, SocketAddr};

use futures::StreamExt;
use http_body_util::combinators::BoxBody;
use http_body_util::{BodyExt, StreamBody};
use hyper::body::{Bytes, Frame};
use hyper::server::conn::http1;
use hyper::service::service_fn;
use hyper::{header, Request, Response};
use hyper_util::rt::TokioIo;
use std::time::Duration;
use tokio::net::TcpListener;
use tokio_stream::wrappers::IntervalStream;

async fn hello(
    _: Request<hyper::body::Incoming>,
) -> Result<Response<BoxBody<Bytes, Infallible>>, Infallible> {
    let stream = IntervalStream::new(tokio::time::interval(Duration::from_secs(1)))
        .enumerate()
        .map(|(count, _)| {
            let data = Bytes::from(format!("data: Hello {}!\n\n", count));
            let frame = Frame::data(data);
            Ok::<_, Infallible>(frame)
        });

    let http_response = Response::builder()
        .header(header::CONTENT_TYPE, "text/event-stream")
        .body(BodyExt::boxed(StreamBody::new(stream)))
        .unwrap();

    Ok(http_response)
}

#[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
    let addr = SocketAddr::from((Ipv4Addr::UNSPECIFIED, 3000));
    let listener = TcpListener::bind(addr).await?;
    loop {
        let (stream, _) = listener.accept().await?;
        let io = TokioIo::new(stream);
        tokio::task::spawn(async move {
            if let Err(err) = http1::Builder::new()
                .serve_connection(io, service_fn(hello))
                .await
            {
                eprintln!("Error serving connection: {}", err);
            }
        });
    }

    Ok(())
}

I expected to see this happen: serve_connection shouldn't return Err on client disconnect. Ok should be returned and stream dropped.
Instead, this happened: Error of type hyper::Error(IncompleteMessage) is returned.

Have you been able to take a look at what triggers the error? My guess is that since the response isn't complete (because you can still stream more events to the client), when hyper notices the connection closed and determines it needs to tell you about the potential error condition (that the client didn't see all of the response). hyper has no special handling of server-sent-events, as they aren't actually special in the HTTP spec: they are just a long lived streaming response.
Thus, it's not immediately clear how hyper would know whether this is an error, or should be ignored. Suggestions are weclome. But also, since the application knows better what kind of streaming it is doing, it can choose to ignore these errors.

My guess is that since the response isn't complete (because you can still stream more events to the client), when hyper notices the connection closed and determines it needs to tell you about the potential error condition (that the client didn't see all of the response)

IIRC this is exactly the case.
Probably to handle this correctly, Body should be aware if its finite or not. Maybe it should be separate method like is_finite_stream or maybe a special case of size_hint? But this makes interface more complicated, especially for typical case.
Also maybe something a bit less correct, but easier to implement would be to check what poll_frame returned, and if it's Pending (eg. no more body available at the moment) the error could be suppressed?

maybe this solution will solve your problem click


custom  handle_HELO and handle_EHLO: 503 Error: send HELO first

summary
I've changed handle_HELO and handle_EHLO to get rid of unwanted hostnames as early as possible. Disappointingly, I am now stuck with the message 503 Error: send HELO first.
expected
220 v238348.srv.net Python SMTP 1.4.4.post2
HELO example.com
250 v238348.srv.net
MAIL FROM<EMAIL_ADDRESS>250 OK
RCPT TO<EMAIL_ADDRESS>250 OK
DATA
354 End data with <CR><LF>.<CR><LF>
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Subject: Telnet email

test
.

250 OK
QUIT
221 Bye
Connection closed by foreign host.

actual
220 v238348.srv.net Python SMTP 1.4.4.post2
HELO example.com
250 example.com
MAIL FROM<EMAIL_ADDRESS>503 Error: send HELO first

code
    async def handle_HELO(self, server, session, envelope, hostname):
        if hostname != 'example.org':
            return f'250 {hostname}'
        else:
            await server.push('550 5.7.1 Access denied')
            server.transport.close()
            # return '550 5.7.1 Access denied'

    async def handle_EHLO(self, server, session, envelope, hostname, response):
        if hostname != 'example.org':
            return response
        else:
            await server.push('550 5.7.1 Access denied')
            server.transport.close()
            # return [f'550 5.7.1 Access denied']

hint
versions

Python 3.9.2
1.4.4.post2

assumption
Seems like extending handle_HELO and handle_EHLO needs more code as expected?

Seems like I missed session.host_name = hostname. Sorry for the noise.


Gemfile + Gemspec: remove too hard fixed gem version

When using with Poltergeist, there was a conflict due to too strong restrictions on gem version:
Bundler could not find compatible versions for gem "capybara":
  In Gemfile:
    poltergeist (~> 1.6) ruby depends on
      capybara (~> 2.1) ruby

    capybara-mechanize (~> 1.4) ruby depends on
      capybara (~> 2.4.4) ruby

    capybara (~> 2.5) ruby

I only remove the third number of gem version in Gemfile + Gemspecs.

Hey, thanks for the PR! Looks like this PR failed on CI before even starting the tests. Seems like that's related to bumping some of the gems? If we could selectively bump the gem version, maybe that'd work?

Capybara 2.5 compatibility was included in https://github.com/jeroenvandijk/capybara-mechanize/pull/62, closing this.


Add Raspberry Pi 5 Support

Info
The Raspberry Pi 5 has been announced with a new SoC. Since the GPIOs are now managed by the RP1 chip, the low level software interface has likely changed.
The PiSCSI code should be updated to support the Raspberry Pi 5 platform.
Performance tests are recommended to compare the performance to RPi 4.

Note: I've pre-ordered RPi 5's, but if anyone else beats me to this, just comment below :)

The GPIO pins of the Pi 5 are said to be fully backwards compatible, so it should work out of the box. See https://kitronik.co.uk/blogs/resources/the-differences-between-raspberry-pi-4-model-b-raspberry-pi-5, for instance.
Regarding performance let me try to make a prediction :). There won't be much of a difference compared to a Pi 4. I'm saying that because even though the Pi 4 is much faster than a Pi Zero (Zero, not Zero 2), if I recall my tests correctly, rascsi was only about 10% faster with a Pi 4.
If this is the case, just for running piscsi the Pi 5 is IMO not very attractive, because it needs more power and is more expensive than previous models, and you pay for features (PCIe) you cannot use.

We'll find out when my Pi 5 arrives. It'd be great if no changes are needed!

Drop it straight into your old projects, it's the same general size and shape as its predecessors and the if features the same backwards compatible GPIO interface as its predecessors.

I would be surprised if the low-level register definitions didn't change, but we'll see!

The Raspberry Pi utility pinctl had updates specifically to support the RPi 5.
Reference: https://github.com/raspberrypi/utils/commit/2bd898fecb10c7259fc16efa8da22472d410a1d5

So it's probably just the pinout that has not changed.

If this is the case, just for running piscsi the Pi 5 is IMO not very attractive, because it needs more power and is more expensive than previous models, and you pay for features (PCIe) you cannot use.

There will be users who want to use an RPi5 with piscsi because that's what they have on hand, or for a multi-purpose setup with many different pieces of software running concurrently on the Pi.
I agree that it shouldn't be the recommended hardware though, unless we see a huge performance increase (unlikely).

Agree it probably won't be the recommended solution. But, still think the software should support it.

@akuker Yes, definitely. And maybe I am wrong and there is even a relevant gain of performance. Compile times will be shorter in any case ;-).
@rdmark Regarding a multi-purpose setup you may remember my concern from the past that easysetup is too intrusive. It installs/configures a lot that that you may not want. The more you use want to use your Pi for different things, the more this can become an issue.

A user has reported in Discord that the Bullseye based release images do not boot on an RPi5. We likely need to update the scripts in https://github.com/PiSCSI/piscsi-pi-gen and merge the latest changes from upstream pi-gen.

re-posting from discord for visibility:
I can't get PiSCSI to work at all on my pi 5 without modification. At gpiobus.cpp:397, epoll_wait will continuously fail, flooding the logs (leading to > 2GB log file). The calls to mmap in the systimer and gpiobus inits would also fail with EINVAL (We don't like addr, length, or offset (e.g., they are too large, or not aligned on a page boundary)).
I discovered this was because bcm_host_get_peripheral_address returns 16 on the pi 5. I was able to get around this by hardcoding the peripheral base address in GPIOBUS_Raspberry::Init to match what was said in this discussion. I don't as of yet know of a way to retrieve the base address for the RP1.
Additionally, in GPIOBUS_Raspberry::Init, I had to replace /dev/gpiochip0 with /dev/gpiochip4.
This cleared any errors from the logs, but I haven't been able yet to confirm if anything is actually working. Doing so as I type this out.
This document contains the addresses and offsets for the RP1 chip which is where the peripherals are now accessed (as opposed to via the BCMXXXX chip on the other pis). My gut says these offsets will need to be updated as well.


Unable to ssh to harvester host.

I'm very new to #Harvester HCI. Just deployed a 2 node cluster and can log in through GUI, but cannot ssh.
login as: admin
Keyboard-interactive authentication prompts from server:
| Password:
End of keyboard-interactive prompts from server
Access denied

Hi @MAH8U8, how did you create your cluster?
IIRC, the default login account was rancher instead admin

Hi @Vicente-Cheng,
Yes, the account is rancher and working now, thanks a lot!!

@MAH8U8,
No problem! I will close this issue. Feel free to reopen it or create a new one if you encounter it again.

Sure
Thanks
-Mahbub

Sent from my cellphone, please excuse brevity and typos.

On Thu, Jan 18, 2024 at 12:51 PM freeze @.***> wrote:

Closed #4991 https://github.com/harvester/harvester/issues/4991 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/harvester/harvester/issues/4991#event-11521116473,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKC64VTHMWEF6WMINQJZIJTYPDA77AVCNFSM6AAAAABB7WV4L2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGUZDCMJRGY2DOMY
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add news banner and log

Related to https://github.com/jupyter/nbclassic/issues/214
This PR add a banner and log message. The user can click on a button to not see the banner anymore (that choice is persisted across session and server restart via the local storage).

@jupyter/notebook-council As this PR introduces a very visible change for the users, I am looking for any feedback/enhancement.

Thx @RRosio for the review. Let's leave this open a few more days for any feedback before merging.

Thx a lot @isabela-pf. I have merged your suggestions.

Question - isn't our plan to deprecate and not support notebook 6 moving forward. Do we have a date as to when notebook 6 will stop being supported? If that is the case, don't we want to phrase this to communicate that to users? The phrasing "if you plan..." suggests that upgrading is entirely optional for users.

The JEP on noteobook 7 says "Jupyter Notebook v6 will be maintained with critical security fixes for two years following the release of Jupyter Notebook v7." I think the banner should communicate that to users.

I should note though that I think a banner like this is a fine idea and will be helpful for users to understand the plan.

isn't our plan to deprecate and not support notebook 6 moving forward.

Yes, that is the plan

Do we have a date as to when notebook 6 will stop being supported?

We had a few discussions in the community meeting related to support policies for Notebook, but nothing has been proposed nor decided to my knowledge and understanding.

If that is the case, don't we want to phrase this to communicate that to users? The phrasing "if you plan..." suggests that upgrading is entirely optional for users.

Well, I think the upgrade is optional indeed. As we don't have a EOL support date, I guess we could say "Notebook 6... will soon be deprecated..."
Please note that this banner will for now be shipped for NbClassic, so we may remove the mention to Notebook 6 to make the message more clear.
Also the primary intent of this banner is to highlight that any custom Notebook extensions will stop working with Notebook 7, instead of focussing on any depreciation or invitation to migrate to Notebook 7.

The JEP on noteobook 7 says "Jupyter Notebook v6 will be maintained with critical security fixes for two years following the release of Jupyter Notebook v7." I think the banner should communicate that to users.

Thank you for the pointer. Do you have a content that we could use as text for the banner?

BTW since the JEP, Notebook has evolved to NbClassic as a Jupyter Server extension, not sure if that 2 years support also applies to NbClassic.

The result of the Notebook community meeting discussions can be read on https://github.com/jupyter/notebook-team-compass/issues/5#issuecomment-1085254000

jupyter/notebook#main: The frontend and backend code for Notebook v7. Published to PyPI as notebook (v7)
jupyter/notebook#6.4.x: The frontend and backend code for Notebook v6.4 as it is now. Not maintained anymore, except for critical security fixes. It is superseded by Notebook v6.5 (see below). Published to PyPI as notebook (v6.4). User can pin pip install notebook==6.4, but for nearly all users, Notebook v6.5 or nbclassic v1 will likely be what they actually want on their machines. Installing Notebook v6.4 (or v6.5) not allow them to run on the same server as Notebook v7.
jupyter/notebook#6.5.x: This branch hosts the last releases of the v6 line, Notebook v6.5. No upcoming 6.6 branch should be created and the 6.5 branch aims to be EOL (End Of Life) in a reasonable timeframe -- likely coincident with the eventual release of Notebook v8. On server side, it is the same code base and structure as the Python Tornado NotebookApp of jupyter/notebook#6.4.x but uses the HTML/CSS/JS it gets from its dependency on nbclassic for its UI (see below). This branch receives bug and security fixes. No new features should be implemented in this branch, and relevant issues and PRs should be directed to jupyter/nbclassic#main. It does not use any Python from jupyter/nbclassic#main and is not a jupyter-server extension. Published to PyPI as notebook (v6.5).
jupyter/nbclassic#main: The Python code for nbclassic is a fork of the jupyter/notebook#6.5.x transformed into a jupyter-server extension. Published to PyPI as nbclassic (v1). This repo also contains the HTML/CSS/JS assets of Notebook 6.x (published in npm under a name TBD, e.g. @jupyter-ui/nbclassic), so if you pip install nbclassic you will get a fully operational notebook (v6-flavor). This becomes the only location for the frontend  assets of Notebook v6-flavor.

The changes are at the nbclassic template and jupyter server extensions levels. As such, they will not show up in Notebook 6.x distributions, even after a new nbclassic is released.
We can thus have open other PR on the Notebook branches to add similar features (banner + log), but with different messages and focus if needed.

I have updated this PR based on feedbacks collected here and in https://github.com/jupyter/nbclassic/issues/214, and opened https://github.com/jupyter/notebook/pull/6737/files

CI is failing with
    bower xterm.js-fit#*                           EHTTP Status code of 502
    /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pip-build-env-etjzzr96/overlay/lib/python3.7/site-packages/setuptools/command/easy_install.py:147: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
      EasyInstallDeprecationWarning,
```

CI is failing with
    bower xterm.js-fit#*                           EHTTP Status code of 502
    /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pip-build-env-etjzzr96/overlay/lib/python3.7/site-packages/setuptools/command/easy_install.py:147: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
      EasyInstallDeprecationWarning,

I read that pip install -e . is the equivalent of running python setup.py develop and that uses(?) EasyInstall? Could we try running python3 -m pip install --user -e . for the job to avoid this error? Although I didn’t check too far back, the error seems to have begun appearing in action 278  and has been intermittently happening ever since. I did see that the version of setuptools installed for packaging changed to setuptools-67.3.2 wheel-0.38.4 ever since action 278. I just opened a PR for a small link update and the same error appeared in the check_release (link_check) but not the check_release (check_release). It doesn't seem to be related to any changes from this PR specifically, if it sounds good to you @echarles I will merge!

I have relaunched the CI and the intermediary 502 returned by unpkg is now fixed.
@RRosio this is good to merge. Thx.


Add an API call to unpack RTC data

The RTC data we have in sysvars is stored in a packed format.  This makes it difficult to deal with.
It would be good to have an API call that accepts a buffer and unpacks the RTC data into that buffer so that values are expanded out into whole bytes and words

I think this may essentially just mean providing a wrapper for the rtc_unpack function

API call added in #91


Enable logging events when testing

I haven't been able to find a way to log all emitted events to the console when testing, similarly to how truffle test --show-events works, see  https://www.trufflesuite.com/docs/truffle/reference/truffle-commands#test

Hello @elenadimitrova, we are going to work also on such a functionality. Thank you for your issue!


feat(ui): apply diamond architecture in the credit page

Resolves #786

Files that is applied camel case failed in the ci process

file names that is applied both camel case and pascal case are failing in the github ci process

fixed all again

please, deploy the contracts locally, provide a bit of QA to your code

please, deploy the contracts locally, provide a bit of QA to your code

What do you mean "QA"?

please, deploy the contracts locally, provide a bit of QA to your code

Warnings in browser console was generated from uniswap widget.. not related to our codebase

Also added some logs in usePrices component, and tested

@bojan07 Could you fix this error?

@bojan07 Could you fix this error?

I thought that it was generated from my network status.. so ignored
What do you think that this error generated from?

@bojan07 Could you fix this error?

I thought that it was generated from my network status.. so ignored What do you think that this error generated from?

It is caused by the <UcrRedeem twapInteger={twapInteger} /> component but I haven't investigated in depth the root cause

@bojan07 Could you fix this error?

I thought that it was generated from my network status.. so ignored What do you think that this error generated from?

It is caused by the <UcrRedeem twapInteger={twapInteger} /> component but I haven't investigated in depth the root cause

Yeah, thanks for your time to check it out

@bojan07 Could you fix this error?

Just checked in depth. This issue was generated from Uniswap alpha router implementation.. need to check more in depth

Uniswap alpha router implementation.

It's not easy to fully understand how does it work? any help for this?

Uniswap alpha router implementation.

It's not easy to fully understand how it works? any help for this?

Seems now understood the logic a bit

Uniswap alpha router implementation.

It's not easy to fully understand how it works? any help for this?

Seems now understood the logic a bit

Related issue https://github.com/Uniswap/smart-order-router/issues/277

Uniswap alpha router implementation.

It's not easy to fully understand how it works? any help for this?

Seems now understood the logic a bit

Related issue Uniswap/smart-order-router#277

Now I'm getting new error.. have you met this kind of error before? I guess that it was because uniswap router only support certain networks(chains), not support local network(chainID 31337)

Uniswap alpha router implementation.

It's not easy to fully understand how it works? any help for this?

Seems now understood the logic a bit

Related issue Uniswap/smart-order-router#277

Uniswap alpha router implementation.

It's not easy to fully understand how it works? any help for this?

Seems now understood the logic a bit

Related issue Uniswap/smart-order-router#277

So, this can be fixed on our codebase? or just uniswap router package issue?

I guess that it was because uniswap router only support certain networks

Or some API has changed. I don't see any reasons why local networks can't be supported.

So, this can be fixed on our codebase? or just uniswap router package issue?

Hard to say, pls find the root cause of the error and fix it (if possible)

I guess that it was because uniswap router only support certain networks

Or some API has changed. I don't see any reasons why local networks can't be supported.

So, this can be fixed on our codebase? or just uniswap router package issue?

Hard to say, pls find the root cause of the error and fix it (if possible)

Oh.. already spending time on it.. feeling big issue 🤷♀

This uniswap router issue wasn't generated from diamond architecture implementation.. seems original codebase related to uniswap router had some problem.. hope to handle this in a separated issue

This uniswap router issue wasn't generated from diamond architecture implementation.. seems original codebase related to uniswap router had some problem.. hope to handle this in a separated issue

@rndquu what do you think?

This uniswap router issue wasn't generated from diamond architecture implementation.. seems original codebase related to uniswap router had some problem.. hope to handle this in a separated issue

@rndquu what do you think?

The credits page must open without errors. Otherwise there is no sense in the current PR as we will need to fix the credits page ourselves.

This uniswap router issue wasn't generated from diamond architecture implementation.. seems original codebase related to uniswap router had some problem.. hope to handle this in a separated issue

@rndquu what do you think?

The credits page must open without errors. Otherwise there is no sense in the current PR as we will need to fix the credits page ourselves.

Hmm.. I've already checked that error. But not easy to find the root cause. Hope one who has experience in it solve this

This uniswap router issue wasn't generated from diamond architecture implementation.. seems original codebase related to uniswap router had some problem.. hope to handle this in a separated issue

@rndquu what do you think?

The credits page must open without errors. Otherwise there is no sense in the current PR as we will need to fix the credits page ourselves.

Hmm.. I've already checked that error. But not easy to find the root cause. Hope one who has experience in it solve this

@molecula451 Could you help with this error?

This uniswap router issue wasn't generated from diamond architecture implementation.. seems original codebase related to uniswap router had some problem.. hope to handle this in a separated issue

@rndquu what do you think?

The credits page must open without errors. Otherwise there is no sense in the current PR as we will need to fix the credits page ourselves.

Hmm.. I've already checked that error. But not easy to find the root cause. Hope one who has experience in it solve this

@molecula451 Could you help with this error?

yes I will take a look as a part of the review

yes I will take a look as a part of the review

Any luck with this?

While updating from several times of reviews, the work related to credit page was completely reflected to PR804 through the recently added a few commits. so this can be closed to avoid complexity


HIVE-25996: Backport HIVE-25098 to branch-2.3

What changes were proposed in this pull request?
Backport HIVE-25098 to branch-2.3.
Why are the changes needed?
Make the downstreams easy to upgrade their Thrift version.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Local test.

cc @sunchao

Thanks to the work done by @wangyum, Hive 2.3 is widely used in the industry and adopted by many downstream projects such as Apache Spark. A security patch release is greatly appreciated.

Are there still plans to get this into the Hive 2.3 branch?

cc @sunchao this is the first step of upgrading thrift to get rid of CVE (0.14.0+), as we are planning Hive 2.3.10, please reopen this PR.

@wangyum could you rebase the PR?

There are around 30~40 tests failure in the latest branch-2.3, some of them are flaky.
36, 28, 34 test failures were reported by the latest three commits.
Jenkins reports 41 test failures, which seems reasonable.

@pan3793 It should throw Could not find include file share/fb303/if/fb303.thrift:
root@e8c54f097cdf:/opensource/HIVE-25996# mvn -pl metastore -Pthriftif -DskipTests=true package -Dthrift.home=/usr/local
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Hive Metastore 2.3.10-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-no-snapshots) @ hive-metastore ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-banned-dependencies) @ hive-metastore ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-property) @ hive-metastore ---
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run (generate-thrift-sources) @ hive-metastore ---
[INFO] Executing tasks

main:
   [delete] Deleting directory /opensource/HIVE-25996/metastore/src/gen/thrift
    [mkdir] Created dir: /opensource/HIVE-25996/metastore/src/gen/thrift
     [echo] Generating Thrift code for /opensource/HIVE-25996/metastore/if/hive_metastore.thrift
     [exec] [ERROR:/opensource/HIVE-25996/metastore/if/hive_metastore.thrift:1033] (last token was 'fb303.FacebookService')
     [exec] Service "fb303.FacebookService" has not been defined.
     [exec] [WARNING:/opensource/HIVE-25996/metastore/if/hive_metastore.thrift:25] Could not find include file share/fb303/if/fb303.thrift
     [exec]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.199 s
[INFO] Finished at: 2023-07-24T12:59:31+00:00
[INFO] Final Memory: 33M/362M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.7:run (generate-thrift-sources) on project hive-metastore: An Ant BuildException has occured: The following error occurred while executing this line:
[ERROR] /opensource/HIVE-25996/metastore/target/antrun/build-main.xml:15: exec returned: 1
[ERROR] around Ant part ...<for param="thrift.file">... @ 9:28 in /opensource/HIVE-25996/metastore/target/antrun/build-main.xml
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

It works if add fb303.thrift to share/fb303/if/:
root@e8c54f097cdf:/opensource/HIVE-25996# mvn -pl metastore -Pthriftif -DskipTests=true package -Dthrift.home=/usr/local
[INFO] Scanning for projects...

So why share/fb303/if/fb303.thrift is not included in Hive source?

@wangyum could you resolve the conflict? I'll merge this after it.

Thank you @sunchao. Conflict resolved.

Thanks! merged to branch-2.3


PR for discussions for adding artifactType

/cc @michaelb990 @jdolitsky @sudo-bmitch

Make artifactType SHOULD as per discussion.

Closing this PR and reopening another one.