Remove editLocation in DG and PPP draft

Codecov Report

Merging #301 (22f2d12) into master (dea8024) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #301   +/-   ##
=========================================
  Coverage     83.88%   83.88%
  Complexity     1126     1126
=========================================
  Files           125      125
  Lines          3028     3028
  Branches        410      410
=========================================
  Hits           2540     2540
  Misses          393      393
  Partials         95       95

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea8024...22f2d12. Read the comment docs.


Segfault when stress-testing an http server

I tried to write a multi-threaded-ish http server for emojicode. After playing around with the language for some time I actually got a working implementation (which even has a simplistic router so one could write full REST applications in emojicode) which can be found here: https://git.nightmares.pro/EmojiChat/http_server .
It never failed on me when doing simple one-connection tests. Then I tried to benchmark it with wrk (arguments used were -c400 -t8 -d10s resulting in 400 connections, distributed on 8 threads for 10 seconds) which causes a segfault to happen. I assume this should be reproducable when cloning the repo, then compiling and running main.emojic. Now you can do wrk -c400 -t8 -d10s http://localhost:8080/test which should result in the server giving you a segfault.
This is what I get when doing coredumpctl gdb https://gist.github.com/MagnificentPako/b460c67dae92dbdf5b4d2de570889e50
Greetings,
Paul

Thanks for reporting. I could reproduce the problem and there seems to be some kind of memory bug involved. I'll look into this.

I also encountered a similar bug (or maybe the same bug?) - a program that should work in O(n) memory (I'd estimate it should take <1 MB) segfaulted the virtual machine for n > 7 unless the heap size was increased. You can see it here. It's a program that solves this challenge involving maths and stamps. I tried to reduce this to a simpler example, but it doesn't seem to work. BTW, this can make the gc stress tests pass. This program also allowed me to find #87.

@NieDzejkob Thanks for reporting. It would be helpful to report issues like these immediately instead of just commenting them on SE.
Emojicode performs only one allocation for the heap, which is properly guarded against a null pointer, so that's definitely not the issue. If this is actually related to this bug and #56, I would expect it to feature multithreading, which seems to be the root cause of the other bugs. How did you conclude that "fixing this can make the gc stress tests pass"?

@NieDzejkob At first glance your bug seems different to the others, but I'll have to look at it further.
Your Programm does not allocate memory linearly because closures always allocate memory as of now. (An optimization for the future could be implemented here.)

I didn't report it immediately because I wanted to get a simpler example of failing code, then I got distracted, etc. This issue reminded me of that. Now that I think about it, should this be a separate issue?

@NieDzejkob You were indeed right. Your program was affected by a somewhat obvious bug that fixed yesterday, but now it shows the symptoms of #56. I will investigate further, before we decide how to categorize or separate this issue from what this thread here is actually about.

I released https://github.com/emojicode/emojicode/releases/tag/v0.5.3 which resolves the bug that affected @NieDzejkob's program and probably also the HTTP Server example.
The GC stress test, however, is still affected by a rare bug that seems strongly related to threading. The HTTP Server code terminates with 🚨 Fatal Error: Unexpectedly found ✨ while unwrapping a 🍬. on stress testing now, which could be related to the same bug.
I'll keep looking into this.

🚨 Fatal Error: Unexpectedly found ✨ while unwrapping a 🍬. is caused by line 62, http_server.emojic (in the version initially provided) and seems legit. There are probably just not as many system resources available as would be required.
There was one additional memory bug, which should be fixed now and will be released in a new version shortly.


Link to events on the same page

as mentioned by @eileen-kuehn  in #240, it is not so nice that clicking on events in the calendar always opens a new window. This PR is changing this behaviour.

[ ] dummy events removed

you can see the result here: https://662-267395254-gh.circle-artifacts.com/0/SORSE/programme/index.html
The main idea is, that the element in the calendar scrolls down to the card of the event, and the user can click if he wants to read more. Furthermore I added an back-to-top button to quickly go back to the calendar.
What do you think @vsoch and @eileen-kuehn?
The question is, what shall we do we the /programme/calendar/ page? One possibility would be to add all cards as in /programme/ but with display: none, and when the website user clicks on an event in the calendar, it get's displayed. Or we actually remove the /programme/calendar/ page an show it on the /programme/ page instead. Upcoming events are anyway already shown on the front page.
closes #240

in the calendar opens the events in the same window and clicking on the card does so, too

:+1: see f91b186975472232ed6885354ab4c23be633e9d6

alright, here's the adjusted page:
https://668-267395254-gh.circle-artifacts.com/0/SORSE/programme/index.html
@eileen-kuehn: any opinions on displaying the full calendar from /programme/calendar/ in /programme/?

@eileen-kuehn: any opinions on displaying the full calendar from /programme/calendar/ in /programme/?

I actually really like the full calendar view. More than the list-view actually. Nowadays it is hard to remember wich date we have,  so a calendar in this case really helps me :)

Sure, no, I totally agree with you. My point was not to remove it, but rather to show the calendar on the programme page instead of the upcoming events list (which is already shown on th front page)

Yes, I also meant it this way ;) I am totally fine with replacing it with the calendar!

alright, done with c207173, see
https://671-267395254-gh.circle-artifacts.com/0/SORSE/programme/index.html
@vsoch, does this work for you, too?

I’m not in agreement about the link so I’m not the one to ask! If it works for you I’m happy :)

Sure, @vsoch, it's rather about moving the full calendar to the /programme/ page or whether you think that's too much
I'm a bit worried because of your comment in https://github.com/Chilipp/sorse.github.io/pull/1#issuecomment-653155075. It does look okay for me now, but maybe I am not the right person to judge.

Yes I still hold with what I said before - it's not the best design because the huge calendar at the top takes away from being able to see the listing of events. I would want to come to the page and have my attention directed to that. But instead my eyes are drawn to the calendar and I might miss the event listing entirely. It is also redundant because we already have a calendar page that the user should be able to link to from a specific event. Right now I'm more likely to click on the calendar and miss the listing all together, which defeats the purpose of having it.

Hmm, OK. I thought that the list is not very useful as a stand-alone thing as it will be way to much content once we have many accepted events. It's still useful to have, but I think not so many would use the list of events as an entry point into what is available.
This is the approach of this PR. My plan is to make the list accessible with the full calendar and the back-to-top button.

It is also redundant because we already have a calendar page that the user should be able to link to from a specific event.

Well, this redundancy would be removed with https://github.com/SORSE/sorse.github.io/commit/c20717328078d6acd89cb064431bc2741550e0fe as this removes the /programme/calendar page

You should do whatever you think is best, you don't need validation from me.

You don't know how extremely helpful it is, though :sweat_smile:

Ah ok. Well let me give some high level thinking so maybe we can rubber duck figure this out. When someone comes to the programme page, they are likely interested in quickly seeing the events. The original limited schedule list wasn't great for that, and the full calendar isn't really either. Even though it will get longer when there are more, what they would want to quickly see are:

a listing that can be filtered based on topic, with pagination to see events further away, and some detail that gives information about the event. That is fulfilled with what is currently the bottom portion of the page that might be missed with the calendar
OR they already have a sense of events and what they might want to attend, and just want to see the whole calendar with brief titles. For this, we wouldn't want the full calendar right there on the page, but we would want that same link to the full calendar that was there before.

So to summary, these are the three use cases I see for someone wanting to come to the programme page.

I don't know what events are coming, but I want to quickly see a list, possibly filter by category, and then open links to a new tab as I browse to come back to ones that I like.
I'm not interested in browsing events anymore, but i'd like to click once to see the whole calendar
I want to quickly sort events by category / date and do the same.

This is why I would minimally remove the calendar from the top, restore it on it's own page (with a predictable URL) and add the link back to it. We can agree to disagree on the blank opening in a new window.

Completely agreed @vsoch! Great strategy :smiley: It would be great to add some filters to the /programme/ page (instead of a calendar). Do you have experience with that (within jekyll)?
we should then probably associate every accepted contribution with tags, shouldn't we? Like programming language, research domain, etc. The category (software demo, talk, poster, etc.) is not enough.

I thought we already had these headers somewhere on the site (to filter based on topic) but I don't see them now. Wherever they are, I'd reproduce that.

You mean this directly below the Programme header?

These are only links based on the category of the event. They do not filter in that sense

Ah I guess I assumed clicking them would do a filter, I guess that isn't the case? Is there pagination?

Wouldn't it be nice to have a real filter and/or search field that changes the display property of the events on the /programme/ site?

I guess that isn't the case?

no, this is not the case currently. See
https://github.com/SORSE/sorse.github.io/blob/2b0add200ed29711e1fe4aae35c96e4e39fcda72/_layouts/all-events.html#L5-L17

Is there pagination?

nope

alright @vsoch and @eileen-kuehn, this is my second approach and it would be nice to get your feedback.
As discussed with @vsoch above, I reverted c207173 and let the full calendar stay on it's own page.

The /programme/ page now shows the events only (i.e. not the ask-us-anything sessions, and not the submission deadlines. These are still shown on the front page. As discussed before, I'd like to remove this however and implement some filters to search for events. But I don't know yet, how
the full calendar now shows a preview card of the abstract in the side bar (see screenshot below), or below the calendar on mobile views, when you click on an event in the calendar

The link behaviours should now all be consistent:

clicking on an event in the calendar opens something in the same window
clicking on a card opens something in a new tab

Any feedback is highly appreciated :smiley:

Deskop view

Mobile view

I think it looks great! When I go to the programme page I can quickly see what's coming up, and it's also obvious there are sections below (and I can click the titles at the top to quickly jump to one). And of course I can easily see the link to the full calendar.
And the preview added to the full calendar is neat! I think you've done great work - and I wouldn't think too hard about if it's absolutely perfect. I can't imagine complaining about this setup.

Great, thanks a lot @vsoch :smiley:


java.lang.RuntimeException: No CUDA devices were found in system

I am having a "no CUDA devices were found in system" error when running the following code:
System.out.println(CudaEnvironment.getInstance().getConfiguration().getAvailableDevices().size());
The relevant portion of my build.gradle is as follows:
configurations {
    embed
    compile.extendsFrom(embed)
    all*.exclude group: 'org.bytedeco', module: 'javacpp-presets'
}

dependencies {
    embed 'org.deeplearning4j:deeplearning4j-core:0.6.0'
    compile 'org.nd4j:nd4j-native-platform:0.6.0'
    compile 'org.nd4j:nd4j-cuda-7.5-platform:0.6.0'
}

jar {
    from configurations.embed.collect { it.isDirectory() ? it : zipTree(it) }
}

I have tried adding -Djava.library.path="" to my JVM arguments to no avail. I've also tested the CUDA installation using the Nvidia utilities and it shows up fine there.

Get rid of nd4j-native and upgrade to 0.7.1 if you can (use 1 backend at a time at least till our next release). Beyond that make sure something simple like device query from the nvidia sdk works. Your problems are not specific to dl4j beyond this so I'm closing this.


Parse.FacebookUtils.logIn usable in React Native too?

The latest commit is "Make FacebookUtils work with React Native" – but it is not clear how to load FB SDK.
The classic web approach described here https://www.parse.com/docs/js/guide#users-facebook-users cannot be used. Using facebook's own react-native-fbsdk works, Parse SDK still insists "The FB JS SDK must be loaded before calling init."
Could you please post at least very basic example of how Parse+React+FB should be combined, if possible at all? There's a couple of unanswered questions on this in Google group too. Thank you!

ok finally I probably found solution, as always 10 minutes after opening an issue...
see a gist here https://gist.github.com/josefrichter/524dbffc2a37d4952b8a
basically 1. use react-native-fbsdk to do the FB login and then 2. pass the credentials to Parse.FacebookUtils.logIn


ETOR Processing Tag

ETOR Processing Tag
This PR adds a tag to the meta section of the messageHeader resource so that RS knows not to sending back to us. This will fix the sending loop.
Issue
Checklist

[ ] I have added tests to cover my changes
[ ] I have added logging where useful (with appropriate log level)
[ ] I have added JavaDocs where required
[ ] I have updated the documentation accordingly

Note: You may remove items that are not applicable

The mock_credentials PR was merged into this branch as I needed those changes for the API to work.

Really nice stuff!  It looks like there is a checkbox in the run configuration for the remote JVM debug that would allow you to store that configuration as a project file.  What are your thoughts on checking that in to the repo for everyone to just have access to it?

We still need e2e


feat: Add Dockerize option to nuxt project

This PR adds Dockerfile and docker-compose.yml as devOps option 🐳

Of course, making a CI/CD for each project is time consuming and different for each project, and therefore requires a Docker image with a different structure, but in small projects having a code sample can be very helpful.
You should also spend more time on related documentation and introduce different Docker image structures so that people can create their own Docker image as needed.

2 years is a pretty long time, is there any plan to introduce a first iteration of the Docker image variant yet? I'd like to eventually integrate new improvements or workarounds, but it's difficult to open PRs if nothing has been merged yet. Can we get any information about what is currently being worked on? It would be great if we had a documentation for various use-cases, or even better, if the Dockerfile was self-documented with available next steps after providing users with multiple generation options. For example, dev mode or build vs. generate may differ (and so does SSR), and we need workarounds like envsubst if we want to pass environment variables to nginx. Kubernetes tools could be also added in the following iterations, and so could tools like podman to become more inclusive.

It's non-trivial to create a multi-platform baseline that new projects can easily reuse, and there are plenty of additional DX improvements available, for example adding common docker use-cases as npm scripts (including stop & rm to clean the containers, parametrizing env using cross-env-shell with workarounds (e.g. cross-env-shell docker run --name project_name -v '\\\"$INIT_CWD:/usr/src/app\\\"'), referring to build image using $npm_package_version, pipeline to push the image, etc.).

The pros and cons of specific implementations (e.g. base docker images and their versions) could be listed somewhere as a source of truth to make it easier to suggest changes once the dependent technologies further evolve, so that users aren't stuck with ad-hoc decisions in their projects if they prefer zero-configuration.


feat: added namespace for AGP 8 support

This was done to support Android for react-native v0.73.0, Upcoming 0.73.0 has a breaking change for android due to AGP

[Android] Bump to AGP 8.0 https://github.com/react-native-community/discussions-and-proposals/issues/

breaking changes for libraries -> https://developer.android.com/build/releases/gradle-plugin#namespace-dsl
https://github.com/facebook/react-native/pull/37019
example: https://github.com/expo/expo/pull/22609/files#diff-ef1f15fe3a85e91b5b14cecbe065dd88e055f86f9b54c66fbdfd2c40ce95aa4b

see: https://github.com/reactwg/react-native-releases/discussions/64 for more info

fixes #24

@savv this was done a little different, to keep backwards compatibility with <73 react native projects.
Though I'm not home yet to test the solution it was taken from https://github.com/Shopify/react-native-skia/blob/52ae591bb866495995a8ef1d5f845e00376f450a/package/android/build.gradle#L116

Done @pranshuchittora

Thanks @jahead for the blazing fast changes.

Is this still looking like it could be merged?

Sorry for the delay. @pranshuchittora let me know if I should approve/merge, in case you can't.

I have already approved this, @savv we can merge the PR 🎊


Allow specifying image URL to display

The client can use command showurl with a URL as the parameter which is sent to server that responds with the image at given the URL.

Just repeating what I put in discord but this will preserve the context:
Looking at the changes for the client, it looks like the stream_image function can accommodate that command with some small changes, basically paying attention to the arguments, looking for the beginning of the URL.  (N:TCP)


Revert "VNET Rules API spec for Postgres and MySQL (#1773)"

This reverts commit cf69915f117cb7bff26fdd038fec7757ef6fbebc.
@rahulgouthamDOTgs reached out offline to say that these changes needed to be removed from the master branch.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-python)
Command: ['/usr/local/bin/autorest', '/tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp_kcljh1d/sdk', '--use=@microsoft.azure/autorest.python@preview', '--version=preview']
Finished with return code 1
and output:
AutoRest code generation utility [version: 2.0.4245; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core<EMAIL_ADDRESS>(2.0.4246)
   Loading AutoRest extension<EMAIL_ADDRESS>(preview->2.1.34)
   Loading AutoRest extension<EMAIL_ADDRESS>(2.3.38->2.3.38)
ERROR: Syntax error: missed comma between flow collection entries
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1635:37
ERROR: Syntax error: missed comma between flow collection entries
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1635:39
ERROR: Syntax error: duplicate key
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1:-1
ERROR: Syntax error: duplicate key
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1:-1
ERROR: Syntax error: missed comma between flow collection entries
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1636:6
ERROR: Syntax error: missed comma between flow collection entries
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1645:27
ERROR: Syntax error: missed comma between flow collection entries
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1645:29
ERROR: Syntax error: duplicate key
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1:-1
ERROR: Syntax error: duplicate key
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1:-1
ERROR: Syntax error: missed comma between flow collection entries
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1646:6
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1652:5
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1660:5
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1669:2
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1670:0
ERROR: Syntax error: expected a single document in the stream, but found more
    - file:///tmp/tmp_kcljh1d/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1652:5
FATAL: swagger-document/loader - FAILED
FATAL: Error: Syntax errors encountered.
Process() cancelled due to exception : Syntax errors encountered.
  Error: Syntax errors encountered.

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)
Command: ['/usr/local/bin/autorest', '/tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpnbqiy7sd/sdk', '--multiapi', '--package-version=v12.2.1-beta', '--use=@microsoft.azure/autorest.go@preview', "--user-agent='Azure-SDK-For-Go/v12.2.1-beta services'", '--verbose']
Finished with return code 1
and output:
AutoRest code generation utility [version: 2.0.4244; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest

There is a new version of AutoRest available (2.0.4245).
 > You can install the newer version with with npm install -g autorest@latest

   Loading AutoRest core      '/tmp/.autorest/@microsoft.azure_autorest-core<EMAIL_ADDRESS>(2.0.4244)
   Loading AutoRest extension<EMAIL_ADDRESS>(preview->3.0.40)
   Loading AutoRest extension<EMAIL_ADDRESS>(2.1.22->2.1.22)
Processing batch task - {"tag":"package-2017-04-preview"} .
ERROR: Syntax error: missed comma between flow collection entries
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1635:37
ERROR: Syntax error: missed comma between flow collection entries
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1635:39
ERROR: Syntax error: duplicate key
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1:-1
ERROR: Syntax error: duplicate key
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1:-1
ERROR: Syntax error: missed comma between flow collection entries
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1636:6
ERROR: Syntax error: missed comma between flow collection entries
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1645:27
ERROR: Syntax error: missed comma between flow collection entries
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1645:29
ERROR: Syntax error: duplicate key
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1:-1
ERROR: Syntax error: duplicate key
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1:-1
ERROR: Syntax error: missed comma between flow collection entries
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1646:6
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1652:5
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1660:5
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1669:2
ERROR: Syntax error: end of the stream or a document separator is expected
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1670:0
ERROR: Syntax error: expected a single document in the stream, but found more
    - file:///tmp/tmpnbqiy7sd/rest/specification/mysql/resource-manager/Microsoft.DBforMySQL/preview/2017-04-30-preview/mysql.json:1652:5
FATAL: swagger-document/loader - FAILED
FATAL: Error: Syntax errors encountered.
Process() cancelled due to exception : Syntax errors encountered.
Failure during batch task - {"tag":"package-2017-04-preview"} -- Error: Syntax errors encountered..
  Error: Syntax errors encountered.

Did a commit to Azure/azure-sdk-for-python:
https://github.com/Azure/azure-sdk-for-python/commit/9e047e9fe6b66a3a2671004ed044483b3a48704e

Did a commit to Azure/azure-sdk-for-go:
https://github.com/Azure/azure-sdk-for-go/commit/3c7d9db3e4293538a31fe274120d3ffc470cc917

Thanks for reverting , all looks good.

@marstr do you need any review from my end here?

Given the time-sensitive nature of this I'm going to go-ahead and merge this in. I've chatted at length about this offline, and feel confident that these are the right set of changes to include.

Automation for azure-sdk-for-python

Did a commit to Azure/azure-sdk-for-go:
https://github.com/Azure/azure-sdk-for-go/commit/7dcd4f83ae5a9fef368823403fe1d9afde9484ba


Add decompositions of basic ops to PennyLane core

Some external frameworks only support a minimal set of gates, e.g., rotations and a hardware-specific 2-qubit entangling gate. This leads to basic ops like Hadamard, PauliX, PauliY, PauliZ, and BasisState having to be decomposed locally in the plugins. For these ops, we should provide decompositions into basic rotations within PennyLane core.

Another one to add to the list: the S gate

So the idea would be to take some matrix representation of a gate, and output a series of PennyLane rotation operations that are equivalent to the gate?

The functionality already exists, we just need to extend it to a few more cases.
For intance, the Rot op has a decomposition method which indicates that if the Rot operation isn't available on a device, then it can fall back to a set of other simpler gates which is equivalent.
See here for example

@Lucaman99 you'll notice some gates don't have a decomposition method implemented, but they could (we just haven't gotten around to it yet)

@co9olguy Ah, I understand now! I'll get to work on this.


[Help Wanted] Set up a system for creating permanent links

With the current, if a doc is renamed or moved, its URL changes.
This sometimes causes issues if the help documentation was linked to in the product, because older versions may contain broken documentation links.
To make it easier, we'd like to add a system for creating permanent links that redirect to the correct docs. We can then keep the permanent link in the product, and just update which document the permanent link points to.

Closing this, we're just going to do website redirects


prevent swipe when reaching last slide

I have a vertical slider. and I'm using verticalSwiping = true, on mobile when swiping down to move to next slide it's working fine but when reaching the last slide it stucks there and I cannot scroll to see the content below the slider.
I tried to return false in the swipe event but it didn't work. I also try edgeFriction=0 but it didn't work also.

I think this can be achieved using the edge event?
$('.your-element').on('edge', function(event, slick, direction){
  console.log('edge was hit')
});

You can trigger the scroll using JavaScript (like 300px or something) then the user will be able to scroll to the content below


How to deal with foreign key constraint?

$ bin/rake db:seed

ActiveRecord::StatementInvalid: Mysql2::Error: Cannot delete or update a parent row: a foreign key constraint fails

Does the heart_seed have UPDATE sql instead of delete all and bulk insert ?
Or ignore foreign_key_checks option ?
For example
ActiveRecord::Base.connection.execute "SET FOREIGN_KEY_CHECKS = 0"
heart_seed:db:seed
ActiveRecord::Base.connection.execute "SET FOREIGN_KEY_CHECKS = 1"

Oh. I did not consider foreign key.
I'll try consider a good way.

@osdakira I released v0.1.0 !!


Support OSSelot as a curation provider

OSSelot is OSADL's "branding" of @OliverFendt's https://github.com/Open-Source-Compliance/package-analysis. With OSADL's backing that repository probably gets more traction, so we should consider adding is as a curation provider despite a few issues:

There is no API; curations are stored in tag-value (!) SPDX files. Also see https://github.com/Open-Source-Compliance/package-analysis/issues/20.
The repository focuses on curations for embedded (Linux) development. This means there usually is no package manager involved. As a result, many of the PURLs simply use generic as the type (see here, and click on "Show package URLs").
The use of generic means that download_url / vcs_url qualifiers are required to concretely identify packages. However, currently ORT does not take URLs into account when looking up curations, as only ORT package ids are used (this is actually being addressed as part of https://github.com/oss-review-toolkit/ort/pull/6387).

There is no API

By now there is, see https://wiki.osselot.org/index.php/REST.


boot2docker kernel missing /proc/sys/crypto

I ran into the problem that services in containers throw errors while starting because of missing /proc/sys/crypto
Is there any chance getting it into the boot2docker kernel ?

bump

Is there a kernel config flag that enables this?

yes, CONFIG_CRYPTO_FIPS it is

@tianon its been a while... have you thought about this ?
imho it should go somehwere in https://github.com/boot2docker/boot2docker/blob/master/kernel_config#L4601 ? if so, I can try it out and possibly make a PR

Note: CONFIG_CRYPTO_FIPS might have dependencies on other CONFIG_XXX, see http://unix.stackexchange.com/questions/261112/kernel-configs-and-dependencies


Add files via upload

Upload five-ingredients-of-a-yfd-vault diagram.

directed to the wrong location, closing PR


Use compression for rsync by default

I've taken the liberty of adding the compression flag default to the rsync arguments.
Also for clearity i've updated the defaults to all use long-arguments.

Thanks @fruitl00p!


[Loc] Update to base Langpack files

This PR updates the langpack source files to match the vscode langpack that was concurrent with the vscode-merge made recently. This is done to incorporate the changes made with the vscode-merge and to make it easier when the next release comes around.
Original vscode langpack files here: https://github.com/microsoft/vscode-loc/commit/b63fdad56a11937948561988d44c022dee46b07f
This also adds in the last release and the upcoming release to the changelog as well.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.175%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
14516

Relevant Lines:
28627

💛  - Coveralls


Utilities cleanup

This is a start, there's probably more that can be moved as we clean things up.

Fixed utility test for deep_merge that was failing
Made print_line two different functions for stdout and stderr
Updated print functions to be Python 3 ready
Moved template creation into a generic function
Test all the (moved) things

:+1:

One sec, one last fix

Alright, @rgreinho found a better fix for that failing test.

:+1:


Support for more complex types

Currently, Kafka Connect is missing the Support for Complex ClickHouse type

Array
Map

Support array implementation can be found at array support branch

Support map implementation can be found at map support branch


Test Issue created at Mon, 13 Dec 2021 02:24:41 GMT

Test issue body  Mon, 13 Dec 2021 02:24:41 GMT

Comment on issue at Mon, 13 Dec 2021 02:24:43 GMT


chore: add badges

Add badges for crates.io, codecov and build status.

Codecov Report

Merging #4 (d9ecfc8) into main (cfe97b9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   89.43%   89.43%
=======================================
  Files          17       17
  Lines        7655     7655
=======================================
  Hits         6846     6846
  Misses        809      809

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfe97b9...d9ecfc8. Read the comment docs.


Change in docs of Append subs

Document Updation for Append Subscriptions

From,
{
    "entities": [
        "83c2e5c2-3574-4e11-9530-2b1fbdfce832"
    ]
}

To
{
    "type": "urn:dx:rs:success",
    "title": "success",
    "results": {
        "entities": [
            "83c2e5c2-3574-4e11-9530-2b1fbdfce832"
        ]
    }
}

Can one of the admins verify this patch?


Remove string obfuscation to increase credibility

Hello!
I understand that you feel like you want to protect the code which you probably researched and put a lot of effort into, but I would also like to point out that obfuscation is not the way.
First of all, obfuscating the payload this way will not prevent anyone from actually reading the code (#3 is and example of that).
Construction containing eval(chain_of_obfuscation_methods(obfuscated_string)) will however discourage a lot of security-aware people from using your application, as they won't be able to read the code easily before running it.

Removing the eval + obfuscation part will result in:

more people actually using your application,
less people actually caring about how it is implemented.

Also, you decided to open-source your solution, so you know... why obfuscate the code now? So, what do you think?

$ytresponse = @file_get_contents("https://www.youtube.com/oembed?url=http%3A//youtube.com/watch%3Fv%3D$id&format=json");
$ytinfo = array();
$ytinfo = json_decode($ytresponse,true);
$type = $ytinfo['type'];
thats de code, i guess he is a genious of coding protecting his master pieace

Yes, I got through the process of de-obfuscating it too and figured that much. I will close this issue, there is no hope or reason to keep this open.

No, he is not dumb, this is a prevention...
http://www.attila-php.net or try to search for "watch%3Fv%3D$id&format=json"

@Julot135 Feel free to elaborate on that prevention part... as far as I am concerned, it does not prevent anyone from anything.


Breadcrumb trails

I am using this node to view the ISS on the world map.
What is the best way to leave behind a breadcrumb trail as the ISS is orbiting?
Thanks

use the tracks node that is part of this package.


[Maven] Include extension modules in main build

Updated reactor
Updated extension modules versions and parent pom dependencies

(fixes #132)

Codecov Report

Merging #133 into development will decrease coverage by 0.7%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             development     #133      +/-   ##
=================================================
- Coverage          83.19%   82.49%   -0.71%
- Complexity           657      736      +79
=================================================
  Files                 65       71       +6
  Lines               2095     2393     +298
  Branches             367      427      +60
=================================================
+ Hits                1743     1974     +231
- Misses               134      170      +36
- Partials             218      249      +31

Impacted Files
Coverage Δ
Complexity Δ

...ension/contentfragment/models/ContentFragment.java
100% <0%> (ø)
12% <0%> (?)

...internal/servlets/VariationsDataSourceServlet.java
100% <0%> (ø)
6% <0%> (?)

...agment/internal/models/v1/ContentFragmentImpl.java
71.51% <0%> (ø)
31% <0%> (?)

...t/internal/servlets/ElementsDataSourceServlet.java
78.26% <0%> (ø)
10% <0%> (?)

...al/servlets/AbstractContentFragmentDataSource.java
87.75% <0%> (ø)
16% <0%> (?)

...internal/servlets/ElementNamesRenderCondition.java
60.86% <0%> (ø)
4% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bafc9e...6e2bb25. Read the comment docs.


You cannot create React\Promise\FulfilledPromise

InvalidArgumentException: You cannot create React\Promise\FulfilledPromise with a promise. Use React\Promise\resolve($promiseOrValue) instead. in /*/vendor/react/promise/src/FulfilledPromise.php on line 12
Any ideas?

On Mar 5, 2015, at 6:48 AM, Bozhidar Hristov<EMAIL_ADDRESS>wrote:
InvalidArgumentException: You cannot create React\Promise\FulfilledPromise with a promise. Use React\Promise\resolve($promiseOrValue) instead. in /*/vendor/react/promise/src/FulfilledPromise.php on line 12
Any ideas?
—
Reply to this email directly or view it on GitHub.

Of course:
#0 */vendor/guzzlehttp/guzzle/src/RequestFsm.php(173): GuzzleHttp\Exception\RequestException::wrapException(Object(GuzzleHttp\Message\Request), Object(InvalidArgumentException))
#1 */vendor/guzzlehttp/guzzle/src/RequestFsm.php(92): GuzzleHttp\RequestFsm->error(Object(GuzzleHttp\Transaction))
#2 */vendor/guzzlehttp/guzzle/src/Client.php(245): GuzzleHttp\RequestFsm->__invoke(Object(GuzzleHttp\Transaction))
#3 : GuzzleHttp\Client->send(Object(GuzzleHttp\Message\Request))
#4 *
#5 *
#6
#7 *
#8 {main}

Thanks.
Can you update to the latest version of Guzzle? Is there a reproducible snippet of code you can provide that I can play around with?

Installing guzzlehttp/guzzle (dev-master 589f187)

Still same problem. The request is very simple:
$body = 'valid xml';
$request = $this->client->createRequest('POST', 'http://localhost:8989', array(
'body' => $body
));
$request->setHeader('Content-Type', 'text/xml');
$response = $this->client->send($request);

I just found the problem:
It tries three times to send query and enter here:
return self::retryFailedRewind($handler, $request, $response);
but second time this returns: GuzzleHttp\Ring\Future\CompletedFutureArray, not error.
This is my other question, how can I modify response before ANY validation? I'm integrating with XML API which is returning ALWAYS HTTP Status = 0 ? I need to modify Status to be always 200 so it won't broke Guzzle.

Weird. That could be a bug in Guzzle.
Are you sure that the service actually returns a status of 0? Does setting the status code to something other than 0 cause this problem to go away?

Yes, everything is ok with raw curl. Status is 0.
https://github.com/guzzle/RingPHP/blob/master/src/Client/CurlFactory.php#L89
!isset($response['status']) == true so self::createErrorResponse($handler, $request, $response)  is called.
https://github.com/guzzle/RingPHP/blob/master/src/Client/CurlFactory.php#L108 - There is no real error, actually request is succesfull.
https://github.com/guzzle/RingPHP/blob/master/src/Client/CurlFactory.php#L109 = yes, it's empty.
so, it call  return self::retryFailedRewind($handler, $request, $response);
internally retryFailedRewing calls recursively https://github.com/guzzle/RingPHP/blob/master/src/Client/CurlHandler.php#L60 which return CompletedFutureArray and outside of that call is wrapped again with CompletedFutureArray

$array["key"] = 0;
var_dump(isset($array["key"]));

bool(true)

So the problem is not that the status is 0. The problem is that $header['status'] is either

not set at all,
is set to null.

Can you debug this block?
In particular, this line. If it sets the value to null, that would be why the isset() call returns false.
The following could explain a lot too though, but the statement is rather vague...

Also there isn't any headers.

Can you elaborate? You mean the API you are calling does not return any headers at all?

Yes, the remote API we call does not return any headers. This is curl_info:
'content_type' => null
'http_code' => int 0
'header_size' => int 0
'request_size' => int 784

Well... that is one seriously broken API.

It's API of payment broker. :)
Data is in XML. (Also the real status code)

I don't really know how to deal with this.
If a subscriber with a onComplete hook could capture the request before it does the header validation, then you could simply check if the content contains a valid XML body and return the response using intercept() (or alternatively, add headers that the request should have).
I would definitely contact your payment broker though and ask them why their API is so broken, and request that they fix it. I've worked with a lot of payment providers in the past, and I have never encountered something like this before.

I tried to make them fix it, but they don't want to do it.
I tried and the following:
$this->client->getEmitter()->on('complete', array($this, 'fake'), 'first');
with no success either.

Not returning a status code or headers is not a valid HTTP response. I don't think guzzle needs to be modified to support that type of response. Maybe better error reporting would have been better though, and I'd gladly accept a PR along those lines.


Temporarily expose gRPC client connection for cloud API use

Describe the solution you'd like
The in-development cloud API wants to reuse the gRPC connection from the Go client to instantiate the gRPC API. This API is not yet stable and may move to a different location at some point, so this is just a temporary need at this time.
I think a GetGRPCConnection(internal.Client) *grpc.ClientConn should be added to https://pkg.go.dev/go.temporal.io/sdk/internalbindings with a warning that it is experimental and may be removed in the future.

This is not the approach we're going to take, see #1426 for a more full-fledged cloud client.


Added EnableHtmlForBlock flag on HtmlRenderer for issue #104

#104 I would really like to see this feature as well. From my understanding of your comments, these changes are what is necessary to enable it. Please accept this contribution to enable the feature or let me know what else needs to get done to enable it.
Thanks for creating such a great/useful library!!!

Hi, unfortunately, I can't accept this PR. Changing the behavior of the Html renderer to not render Html at all is not a good direction (note that the EnableHtmlForInline was introduced to support a required feature of rendering nodes without decoration inside links)
The reason is that in order to support #104, I would much prefer that we do this work as part of #32, as it covers broader use cases.

Thanks for the feedback. That is a little disappointing though as this is for a project I'm currently in the middle of. Please let me know if there is something else I can do to help with this!

That is a little disappointing

As I said above, making this as part of the html renderer might not be the worse solution after all.  😉  I just need a bit of time to take a look at the details...

Thanks, I have merged these changes to master

Thank you for all of your hard work on this library. It is greatly appreciated!!!


feat: message handling config

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

15 of 15 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 96.463%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
949

Relevant Lines:
996

💛  - Coveralls


QA form confirmations

@lukefretwell I can't figure this one out. Maybe Kevin knows?

@rebeccawoodbury is is both forms?

@lukefretwell I think it's just the contributor interest form

@rebeccawoodbury well, can you verify? 😛

@rebeccawoodbury sounds like we need to set up the SMTP, so I'm just just disabling those for now.


[WIP] Add HDFS module

This is a work in progress.
I have HDFS working, which you can test by running hadoop/bin/hdfs.
Spark doesn’t seem to be able talk to it though, since sc.textFile(‘hdfs:///file.txt') yields:
java.io.IOException: Incomplete HDFS URI, no host: hdfs:/file.txt

TODOs:

[ ] Get Spark to talk to HDFS.
[ ] Enforce Spark config dependency on HDFS install if necessary.

e.g. Add HDFS options to ClusterInfo.

[ ] Clean up CLI option handling.

e.g. spark_version is required if install_spark is set.

[ ] Abstract out login user from Hadoop config files.
[ ] Clean up template handling for slave_hosts.

Fixes #40.

@shivaram - Any quick pointers on what to do to get Spark talking to HDFS via sc.textFile()?
I know HDFS is working because I can dfs -put and dfs -cat files from the master or slaves. But something is missing to allow a command like sc.textFile('hdfs:///file.txt').count() to work. Even sc.textFile('hdfs://master_ip:9000/file.txt') doesn't seem to work.
I looked through Spark's config guide and tried adding more configs like HDFS_URL, but I'm just bumbling about and none of it seems to work.

@nchammas, I think I had basically gotten this working in spark-gce, although I never tested it much beyond the simple loading of data, and at one point it stopped working so this may not be the complete solution.  Beware!   But in case it is helpful, here are my spark config files, which include a few Hadoop-specific configurations.  In particular, take a look at core-site.xml (which would be placed in the spark/conf dir, or perhaps use the Hadoop version of the file and include it in the Spark classpath... see docs about this here).  For setting up classpaths, SPARK_SUBMIT_LIBRARY_PATH, SPARK_SUBMIT_CLASSPATH, and HADOOP_HOME environment vars in spark-env.sh seemed to do the trick.  I think the core-site.xml and classpath settings are the most important, as described [here].  Hope this helps!

@broxtronix - Oh, good point about the class path. I think I missed that.
From "Inheriting Cluster Configuration":

Inheriting Cluster Configuration
If you plan to read and write from HDFS using Spark, there are two Hadoop configuration files that should be included on Spark’s classpath:

hdfs-site.xml, which provides default behaviors for the HDFS client.
core-site.xml, which sets the default filesystem name.

The location of these configuration files varies across CDH and HDP versions, but a common location is inside of /etc/hadoop/conf. Some tools, such as Cloudera Manager, create configurations on-the-fly, but offer a mechanisms to download copies of them.
To make these files visible to Spark, set HADOOP_CONF_DIR in $SPARK_HOME/spark-env.sh to a location containing the configuration files.

Yeah the core-site.xml needs to be in the classpath. In spark-ec2 we just copy it to /root/spark/conf. BTW another way to do this is to open the HDFS ui at :50070 and that has the HDFS url written on it. It might be 8020 instead of 9000 on some newer versions I guess (I saw https://ambari.apache.org/1.2.3/installing-hadoop-using-ambari/content/reference_chap2_1.html)

OK, this is in a good state now. I'm going to polish it up a bit and merge it in the next few days if there is no feedback. The next key issue to work on will probably be #28, which we'll need if we want HDFS deployed on ephemeral storage.
One thing I'm particularly happy with in this PR is how little configuration was needed to get HDFS working. HDFS has changed a lot over the years, and it looks like spark-ec2 built up a lot of configuration "weight" supporting that technical churn. Since we only support the latest and greatest, this is a burden Flintrock doesn't have to bear. Of course, we can add more configuration as we need to, but it's good that we're starting light.


breaks GitHub

*$3p,domain=github.com

which version of uBO are you on ?

Nano Adblocker v<IP_ADDRESS> ( uBlock Origin Version/1.26.0 Commit/1295e25 )

The filter is
*$3p,denyallow=githubassets.com|githubusercontent.com|s3.amazonaws.com|map.fastly.net,domain=github.com
https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#denyallow
Nano hasn't implemented denyallow yet ?

My filters are tested on uBO only, not on uBO's forks, so you will have to take it up with Nano's maintainer.

It's broken in stable https://github.com/gorhill/uBlock/commit/36711a7c0761c6eecb8c7f7f9724cba6d1cc2994 https://github.com/gorhill/uBlock/commit/94935a4b9e5ff9d70eb6876c0214a570bab76371

It's broken in stable

Why ? || is not used, neither is a domain without ||

It's not about ||, it's about */|http:///|https:// with domain= option.

uBO 1.26.0/1.26.2 - broken
uBO 1.26.3b20 - work

Well I'm not waiting for the patch to land in stable, so disable it via $badfilter or however you see fit.


adapt modules for snakemake 8

To bump all modules to snakemake 8 (#12) we primarily need to document the libraries required to process the initial Snakemake file. These should be added to envs/global.yaml and cross-linked into the Snakemake file with a conda directive. See 'global workflow dependencies' in the snakemake docs. We also need to check the documentation for each module such that it makes sense for Snakemake8.
for each module

[ ] create envs/global.yaml  specifying required software for Snakefile execution
[ ] Document all Software version in the README additionally to the environment YAMLs (redundant?)
[ ] Document in every module the exact Snakemake version it was tested in. and/or use min version directive in Snakefile (redundant?!).

Modules

[ ] Unsupervised Analysis
[ ] Split, Filter, Normalize and Integrate Sequencing Data
[ ] Differential Analysis Using limma
[ ] Enrichment Analysis
[ ] Genome Track Visualization
[ ] ATAC-seq Processing
[ ] scRNA-seq Processing using Seurat
[ ] Differential Analysis using Seurat
[ ] Perturbation Analysis using Mixscape from Seurat

Let's find out which packages actually come with the minimal snakemake installation (the one that would create a problem because of missing packages). e.g., is yaml/pyaml for sure in there? then we could make one global.yaml and just copy paste it into every module.

I checked the RNA pipeline again and interestingly they only use the resource key once here: https://github.com/snakemake-workflows/rna-seq-star-deseq2/blob/993dcfcf3c1210f75f6bfb0ef765a4ddb77cadf7/workflow/rules/ref.smk#L51
in all other rules they only use the threads key.
Unsure what to do ie how to decouple resource specifications form workflow configuration meaningfully without adding complexity dor the enduser.


COMPRESS-580 - Remove redundant operation

Redundant array creation
Redundant type arguments
Redundant type cast
Redundant String operation
Unnecessarily escaped character

Coverage remained the same at 86.819% when pulling ce1c3f0d6d3ef873d43fa1337821800de7cc77ce on arturobernalg:feature/COMPRESS-580 into 9bc02b24a67db2783ca6817278e4b6b218677e26 on apache:master.


'vagrant list' does not show the state of VMs for vmware_fusion provider

It seems that this plugin is only useful to list the virtualbox VMs only:
for i in $(vagrant box list | awk '{print $1}' ); do [ -x "$i" ] && ( echo "$i:"; cd $i; vagrant status; ); done
centos6.4_i686minPupChef:
Current machine states:

default                  saved (virtualbox)

To resume this VM, simply run 'vagrant up'.

centos6.4_x86_64_fusion:
Current machine states:

default                  running (vmware_fusion)

The VM is running.  In either case, to restart it again, run
'vagrant up'.

ubuntu12.04_amd64_fusion_omnibus:
Current machine states:

default                  suspended (vmware_fusion)

The VM is suspended. To resume this VM, run 'vagrant up'.

Here's the output of the 'vagrant list':
$ vagrant list
ALL:
baafeb09-f135-429b-8fe2-1b46b7a6f843: centos6.4_x86_64minPupChef_1366189724 (Red Hat)
RUNNING:

One can see that it provides the list of the virtualbox VMs only.

Since i missed to readt the vagrant 1.6 release notes:
$ vagrant global-status
makes vagrant list obsolete.


Feat/332 replace orchard input with a combobox

Description
Completes #332
Main changes:
Integrate front-end with the new get orchards by vegCode endpoint, and display the options to users in comboboxes, which replaced the old fetch orchard by id flow.
Other changes:

rename OrchardModal to OrchardWarnModal and other variables/functions
stop showing warn modal when adding an orchard
stop displaying the add/delete buttons in form review for orchard step
refine the logic for determining the fetch status of parent-tree-genetic-quality queries
add default behaviour to React Query so we don't have to specify each query to not fetch on window refocus and remount.

  "queries":  {
      "refetchOnMount": false,
      "refetchOnWindowFocus": false,
      "retry": 3
  }

Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
local test
Checklist

[x] I have read the CONTRIBUTING doc
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have already been accepted and merged

Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@mgaseta has approved the PR so I'm bypassing the requirement of needing a code owner's approval


Proposal - rootRef and $Auth

The Problem
AngularFire has no stance on where or how a developer should construct a Firebase database reference. This can lead to plenty of new Firebase('<my-firebase-app>') lines littered throughout a code-base. Also, to use the awesome routing helpers  like .$waitForAuth() and .$requireAuth(), you'll need to construct an Auth factory.
Many AngularFire apps use the following code:
angular.module('app', ['firebase'])
  .constant('FirebaseUrl', '<my-firebase-app>')
  .service('rootRef', ['FirebaseUrl', Firebase])
  .factory('Auth', function ($firebaseAuth) {
     return $firebaseAuth(rootRef);
  });

I would love for AngularFire to handle this.
Below are two features I propose be added to AngularFire to make authentication and constructing references easier.
Proposal
Using a provider to construct a root reference
Dependency injection in Angular means never having to say new. But, it's still unclear where to construct a Firebase data reference in an Angular app. AngularFire could solve this problem by using a provider.
The provider would be responsible for getting the root URL of the Firebase database in the config phase, and then at runtime the root reference would be available for use. I propose the provider be named rootRefProvider, because it will then be constructed as rootRef.
angular.module('app', ['firebase'])
   .config(function ApplicationConfig(rootRefProvider) {
      // provide the root url in the config phase
      rootRefProvider.registerRootUrl('<my-firebase-app>');
   })
   .controller('MyCtrl', function MyController(rootRef, $firebaseArray) {
      this.items = $firebaseArray(rootRef.child('items'));
   });

There is no $ prefix here, because Angular's $digest is unaware of Firebase events. This provider simply constructs a root reference.
$Auth
The Firebase docs on AngularFire recommend creating an Auth factory that passes a constructed Firebase reference into the $firebaseAuth() service.
With the rootRef service above, that could be done by AngularFire. To fit with convention, I propose it be named $Auth:
angular.module('app', ['firebase'])
   .config(function ApplicationConfig(rootRefProvider, routeProvider) {
      // provide the root url in the config phase
      rootRefProvider.registerRootUrl('<my-firebase-app>');

      routeProvider.when('/', {
         controller: 'MyCtrl',
         template: 'view.html',
         resolve: {
           authData: function($Auth) {
              return $Auth.$requireAuth();
           }
         }
      });
   })
   .controller('MyCtrl', function($scope, authData) {
       $scope.currentUser = authData;
   });

@katowulf, @jamestalmage, @jwngr let me know what you guys think of this proposal. I'd love to get your input. Also, if you agree with the proposal, I would love to be the one to implement these features and also to write the tests.
I've already taken a stab at the implementation in a local branch and the code is simple. Here's a demo on JSBin.
Demo on JSBin

:+1:
There are lots of benefits to this.
Following this construct makes it a lot easier to use firebase-server. Just swap the configured url in your tests.
Having a standardized method for the getting that configuration value and auth status seems like a good plan. One less parameter for users to pass in to reusable components (the components can just look rootRef themselves).
I think it is pretty rare that an app connects to two different firebases, but should you at least provide for that?
rootRefProvider.registerRootUrl({
  foo: '<my-foo-app>',
  bar: '<my-bar-app>'
})

Finally, what about fbRoot instead of rootRef, and fbAuth instead of $Auth. The concepts of "a reference to the root of something" and "authorization status" are hardly unique to firebase.

Good thinking on the multiple Firebases. It's is rare, but it should be possible.
As for the names, I agree that rootRef and $Auth may hit some collisions. I'm not a huge fan of the fb prefix as it tends to create confusion with Facebook, who also uses fb.
I'll keep brainstorming on names.

How about firebaseRef and firebaseRefProvider?
And for registering the URL, it could be named registerUrl() and take in either a string or an object.
If it's a string, the firebaseRef will be a constructed reference.
If it's an object, the object must be a key/value of name/url. When firebaseRef is injected, it will be an object of keys and firebase references.
angular.module('app', ['firebase'])
  .constant('FirebaseUrl', 'https://provider.firebaseio-demo.com/')
  .constant('OtherFirebaseUrl', 'https://other-firebase-db.firebaseio-demo.com/')
  .config(function(firebaseRefProvider, FirebaseUrl, OtherFirebaseUrl) {
    // register urls for several references
    firebaseRefProvider.registerUrl({
      root: FirebaseUrl,
      messages: FirebaseUrl + 'messages',
      other: OtherFirebaseUrl
    });
  })
  .controller('MyCtrl', function(firebaseRef) {
    console.log(firebaseRef.root);
    console.log(firebaseRef.messages);
    console.log(firebaseRef.other);
  });

Plnkr Demo

:+1:

How about stealing a little from es6 module exports and allow a default in the object hash that is returned as firebaseRef, any other keys are attached as members on firebaseRef. There would need to be a check to make sure they did not try to overwrite an existing API method. If they don't supply a default, then it just returns an object hash, not a ref (so no namespace check needed in that case).

That sounds interesting, can you provide a sample of the API would look like?

Very similar to what you have already:
angular.module('app', ['firebase'])
  .constant('FirebaseUrl', 'https://provider.firebaseio-demo.com/')
  .constant('OtherFirebaseUrl', 'https://other-firebase-db.firebaseio-demo.com/')
  .config(function(firebaseRefProvider, FirebaseUrl, OtherFirebaseUrl) {
    // register urls for several references
    firebaseRefProvider.registerUrl({
      default: FirebaseUrl, // previously root
      messages: FirebaseUrl + 'messages',
      other: OtherFirebaseUrl
    });
  })
  .controller('MyCtrl', function(firebaseRef) {
    console.log(firebaseRef); // previously root
    console.log(firebaseRef.messages);
    console.log(firebaseRef.other);
  });

:+1: I like it. I'll keep thinking of names the the fbAuth service.

I was thinking about something similar while hacking around $firebaseAuth for a prototype.
But my idea was to simply turn $firebaseAuth into a provider so it's accessible in the configuration phase of Angular.
I think a constant/value for the URL, the ref, and a own service for auth/user handling is just fine.
Maybe even better than another provider that does these decisions for you?
For instance my prototype has a user service (provider) that takes care of all the $firebaseAuth internals itself - and no one else touches them! - while providing high level user functions to both, the router (which is initialized in configuration phase) and controllers.
I liked this much more than injecting the Auth factory into multiple services.

@ronnyhaase Sounds interesting. Could you create a Plnkr demonstrating this setup?

Closed with #703.


404 Not Found with Microsoft.AspNetCore.SpaServices.Extensions

Request returns 404 when using Microsoft.AspNetCore.SpaServices.Extensions package
Configuration works on FastEndpoints 5.7.0 but error occurs on 5.7.1

This is the code that I commented out to test if the Microsoft.AspNetCore.SpaServices.Extensions package is the cause of returning 404
 app.UseSpaStaticFiles();
        app.UseSpa(x =>
        {
            if (!app.Environment.IsDevelopment())
                return;
            x.UseProxyToSpaDevelopmentServer("http://localhost:5501");
        });

i believe changing the ordering of the middlewares should fix the issue. because in v5.7.1, i got rid of the custom fastendpoints middlware and sandwitched that logic into the regular endpoint middleware.
if you have trouble figuring out the right middleware order, try to comment out fastendpoints and add a test minimal api endpoint and get that working. if/when that works, fastendpoints should naturally work.
if it doesn't pls send through a self-contained/minimalistic repro project so i can debug.

i believe changing the ordering of the middlewares should fix the issue. because in v5.7.1, i got rid of the custom fastendpoints middlware and sandwitched that logic into the regular endpoint middleware.
if you have trouble figuring out the right middleware order, try to comment out fastendpoints and add a test minimal api endpoint and get that working. if/when that works, fastendpoints should naturally work.
if it doesn't pls send through a self-contained/minimalistic repro project so i can debug.

thank you I'll play withit later thank you

Hi @dj-nitehawk still no luck even changing the order. Here is my sample project https://github.com/markchristianlacap/dotnet-vue-template . Thank you

works like this:
var builder = WebApplication.CreateBuilder();
builder.Services.AddFastEndpoints();

var app = builder.Build();
app.UseRouting();
app.UseAuthorization();
app.UseFastEndpoints(x => x.Endpoints.RoutePrefix = "api");
app.UseEndpoints(_ => { });
if (app.Environment.IsDevelopment())
    app.UseSpa(x => x.UseProxyToSpaDevelopmentServer("http://localhost:8001"));
app.Run();

the reason it worked before v5.7.1 was because UseFastEndpoints() was a terminating middleware. it no longer is.
so now the spa proxy should be configure the same way as it would be for a regular minimal api endpoint system.


Issue #130: user changes to examples/audio_transcribe

#130
The point of my changes were to:

only use pocketsphinx
pass in file names from the command line (I'm aiming for a for loop or a file list)

It works for .aif (from inside a garage .band media file) files that are only 5 seconds, but my next smallest is at least a minute and it fails.

Ok, there are instructions in audio_transcribe about how to run this from the command line, but first you would need to download the file: long_interview_example.aif from my public dropbox link and put it in examples/

FYI: There're actually two copies of the short interview: one in examples/, the  other deep in examples/short_interview.band/ just to show you where I grabbed it from the garage band project.

Ok, I tried listen instead of record and got a transcription of 810 characters out of the 41 minute "long" interview.  So, it seems I only got the first chunk, but that's definitely the most promising thing so far!  Do I need to create a loop around listen?

Sorry, my participant changed their mind and I had to remove the file, so the dropbox link won't work anymore.
Do you have any idea why `listen

listen only transcribes the first phrase, so you'll need to use a loop around that. It's a bit of a hacky workaround; I'll post an example here in a bit.
No worries about the Dropbox link, by the way. I got the issue to manifest with a long-ish podcast, so there's a good starting point.

I just got this to work with a while loop over listen that stops when it catches the sr.WaitTimeoutError from the timeout argument in listen.
I'm not sure this is reliable, particularly, because I don't really know that it will always generate this timeout error at the end of the file (before, never?), but, at least it worked and I'm really grateful for your help.
I'd love to dig deeper and do some better testing to improve this example or create a new one to your design standards, @Uberi (if you think that would be valuable).

Glad you got it working! I'd definitely like to include this, so when there's time I'll do a proper review and merge it. Ideally, we'd want to exclude the line ending changes and split out the long examples into their own files.
There's a small issue with listen() that will be fixed in the next release (it's actually done, but still needs to be packaged up and published) - that should get things working pretty robustly. I'll be sure to update in this thread.

Sorry, @Uberi, I'm really eager to make this useful, but I can't figure out what you mean by "the line endings changes"- are you saying you would like me to break the long transcription up into multiple lines, or that I messed up some kind of line endings that used to be there?
Similarly, when you say "split out the long examples into their own files", do you mean write each loop of a transcription into its own file, or move the source code for long transcriptions into a separate file (from audio_transcribe.py) ... or something else?
I think I'll have some time to next week (probably this ⚠Tuesday) to do some tidying I'd like to do anyway. I would love if you gave me a little direction:

Should I make a separate "example" to demonstrate long transcriptions?
Should I make the long transcription loop work on all the API's? (would need keys)
Should I break up the resulting transcription somehow (line breaks, separate files, etc)?
Anything else?

Thanks!

Hey @combinatorist,
If you check out the diff for this PR, you'll notice that there are about 3500 lines changed, but the actual number of changes is somewhat less. That seems to be due to the line endings being changed from CRLF to LF. As for those questions:

Ideally, we'd want to have a separate example for that (maybe called long_transcriptions.py).
Just one API (Google's speech recognition maybe, since it doesn't require installing Sphinx or an API key) is totally fine.
Sure, either way works!
Nope, not at the moment. Note that I unfortunately won't have much time to look at it until exams are over.

Hi @Uberi, sorry, I was going to work on this during a flight, but had terrible wifi, so I put it off.
I think I might have some spare time later this month, so for what it's worth:

Agreed
I haven't really used the Google Speech Recognition side of the package, but I noticed it gives better results than Sphinx in the microphone example.  I'm not sure what complications might arise from longer segments, but I bet it's worth it.
Ok, I'll go with line breaks.

I'll also fix the line endings.  Let me know if you happen to think of anything else!

Actually, when I look at the diff online, I don't see a difference in line breaks.  Maybe it's displaying differently, but I think what you're seeing is just where I commented out a lot of code that wasn't relevant to my specific use case.
Regardless, I'm going to start over with my code in a separate example (as you suggested), so I won't be commenting anything out anymore.

Hmm, for some reason I'm getting various networking errors with Google, but notice the shortest phrase worked.  I've tried to get really short phrases in case it's a timeout issue, but that didn't appear to work
(speech)[517] examples% python long_transcriptions.py long_interview_example.aif
time: 04:02.54, loop_count: 1
google error; recognition connection failed: [Errno 32] Broken pipe
time: 04:06.56, loop_count: 2
	google error; recognition request failed: Bad Gateway
time: 04:11.00, loop_count: 3
google error; recognition request failed: Bad Gateway
time: 04:15.03, loop_count: 4
google error; recognition connection failed: [Errno 32] Broken pipe
time: 04:19.06, loop_count: 5
google error; recognition connection failed: [Errno 32] Broken pipe
time: 04:23.08, loop_count: 6
number 10 I don't anticipate any reason I would need to withdraw from the study if you choose to withdraw yourself at some point you can do that no problem whenever you want to do
time: 04:23.14, loop_count: 7
google error; recognition request failed: Bad Gateway
time: 04:27.17, loop_count: 8
google error; recognition connection failed: [Errno 32] Broken pipe
time: 04:31.19, loop_count: 9
^C
Traceback (most recent call last):
  File "long_transcriptions.py", line 63, in <module>
    f.write(' ' + text)
TypeError: cannot concatenate 'str' and 'exceptions.KeyboardInterrupt' objects

OK, FWIW, I downloaded Google's example docs and managed to get a 40 minute clip to transcribe in 4 minutes., but I had to use a URI in Google Cloud Storage (required an account etc).
I just need to add this to the python module and we're set!


Allow having a background color in CustomScrollView,NestedScrollView (GridView/SliverGrid)

Use case
It's just an option we need. I need it for my project and from looking around on GitHub and Stackoverflow, I'm not the only one. Wrapping it in a container doesn't cut it because it creates a whole lot of other issues, especially in SliverGrid.
Not only that, by not having this option, Grids are prone to more errors, such as https://github.com/flutter/flutter/issues/62817

Proposal

This looks like reasonable proposal
Related https://github.com/flutter/flutter/issues/19709 https://github.com/flutter/flutter/issues/28083, this could be address well this proposal

For the meantime, I found a very simple workaround. Just add this to each tile Container in the GridView/SliverGrid:
decoration: BoxDecoration(
              color: Colors.black,
              borderRadius:
                  BorderRadius.only(topRight: Radius.circular(1)),
            ),

Result

Never mind my previous workaround since it doesn't work 100%.
@dhawalmehta22 found a fix (see original post: https://github.com/flutter/flutter/issues/25009) that works at all times. Just wrap the problematic container with another container and add this to the parenting container:
decoration: BoxDecoration(
             color: Colors.black, //the color of the main container
             border: Border.all(
               //apply border to only that side where the line is appearing i.e. top | bottom | right | left.
               width: 2.0, //depends on the width of the unintended line
               color: Colors.black,
             ),
           ),

Even better would be having a background in CustomScrollView, which essentially also acts as a container. Wrapping it in a container is NOT the same in many cases.

@Piinks

Wrapping it in a container doesn't cut it because it creates a whole lot of other issues

Wrapping it in a container is NOT the same in many cases.

@tomasbaran can you elaborate on why this does not work, or creates other issues?

Can you follow up in https://github.com/flutter/flutter/issues/29702? We de-dupe issues to focus conversation and solutions in one place. Thanks!


ruff_python_formatter: add test for extraneous info string text

@ofek asked about this. I did specifically add support for it, but neglected to add a test. This PR adds a test.

Not in pure Markdown but extensions do support that frequently to do various things!

Not in pure Markdown but extensions do support that frequently to do various things!

Assuming pure Markdown is CommonMark, the extra text after the opening fences is called the "info string" and it does indeed permit for pretty much anything to go there. There are even examples in the spec: See: https://spec.commonmark.org/0.30/#fenced-code-blocks
The spec doesn't attach any semantic value to any part of the "info string," it just specifies what is allowed there. For example, when using backticks for a fenced code block, the info string itself cannot contain backticks. But it can if you use tildes!


[Project - Onboarding]: Implement tracking in each step of the onboarding flow

Description:
The goal of this task is to instrument the @storybook/addon-onboarding application to send specific telemetry events during the onboarding process. These events cover various steps in the onboarding flow, as well as user interactions with the interface. The telemetry data should be sent to the Node.js server from the browser using the tracking function implemented in a previous task.
Acceptance Criteria:
The application should send telemetry events for the following:

Started onboarding
Skipped onboarding (where was it triggered)
Finished Step-by-Step Tour
Finished How-to-write-your-Story Tour
Finished completely

All events should contain relevant data (if any), and should be sent at the appropriate times during the onboarding process.
Edge Cases to Consider:

Event firing reliability: The application should reliably send events even in the face of network interruptions or other issues.
Event ordering: The sequence of events should accurately reflect the order of the user's actions and the onboarding process.

List so far:

[ ] browser viewport size


Add https support to odnoklassniki using yandex as proxy

Was discussed here: https://github.com/sapegin/social-likes/pull/96#issuecomment-74084417

:+1:


Upgrade to CodeNarc 2.0.0

Upgrade to CodeNarc 2.0.0

Upgrade jars
Adapt Indentation rule to new behaviour
Use codenarc --ruleset arg instead of temp ruleset file

Replace super-linter by Mega-Linter

Closes #125

Codecov Report

Merging #126 (ec07bee) into master (6aace13) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   93.87%   93.84%   -0.04%
==========================================
  Files          72       72
  Lines        1879     1869      -10
==========================================
- Hits         1764     1754      -10
  Misses        115      115

Impacted Files
Coverage Δ

lib/analytics.js
91.77% <ø> (ø)

lib/codenarc-caller.js
83.94% <ø> (ø)

lib/rules/AssignmentInConditional.js
100.00% <ø> (ø)

lib/rules/BracesForIfElse.js
100.00% <ø> (ø)

lib/rules/ClassEndsWithBlankLine.js
100.00% <ø> (ø)

lib/rules/ClassStartsWithBlankLine.js
100.00% <ø> (ø)

lib/rules/UnusedMethodParameter.js
100.00% <ø> (ø)

lib/codenarc-factory.js
95.52% <100.00%> (-0.32%)
:arrow_down:

lib/groovy-lint-fix.js
98.57% <100.00%> (ø)

lib/groovy-lint.js
99.55% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aace13...ec07bee. Read the comment docs.


Fix the map jumping at the end of some transitions.

Sometimes, when zooming, the map would jump at the end of the transition.  This was caused by the zoom level reaching its final value, then a last animation frame firing, and asking to recenter the map when the center was already correct.

@aashish24 I think this was the problem you saw zooming with your laptop.

Current coverage is 86.90% (diff: 100%)

Merging #650 into master will increase coverage by 0.02%

@@             master       #650   diff @@
==========================================
  Files            87         87
  Lines          8585       8586     +1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           7459       7462     +3
+ Misses         1126       1124     -2
  Partials          0          0

Powered by Codecov. Last update b85183d...cf3b96e

@manthey is this what could cause the issue on some systems (like mine)? I will give it a try.

@manthey seems to have fixed the issue! thanks. The code looks reasonable to me. How did you reproduce this bug on your system?

It happens much more rarely using a mouse wheel than you had with your track pad, but I noticed it on rare occasions, added some debug logging, and when it occurred, looked at what happened.


[Feature Request] PDF Reader (mobile friendly) with annotating etc

Hi guys,
sorry if it is one kind of stupid questions: Why not to make your software perfect and add a reader with highlight and annotating functions?

Just to add to this issue
Can be based on https://mozilla.github.io/pdf.js/web/viewer.html (some code already exists here https://github.com/Frooodle/Stirling-PDF/tree/main/src/main/resources/static/pdfjs)
Must be a standalone feature called View/Annotate PDFs
Must have all same features as above viewer.html such as page view, pen drawing input etc

Im on it!

Wow! Guys, you are awsome! Thanks!


Fix linkage issues

[x] Resolve link errors in hmi_message_handler tests
[x] Resolve link errors in media_manager

@anosach-luxoft , Please review


Cleanup/removed mysql

Why was mysql here before and why is it being nuked? I have no problem with this, just curious

@adriancole It was our data store originally. But one of the features that we want to support is a reverse lookup--specifically, when a metric point comes in, can we find the "subscribed" detectors (i.e. the detectors we should apply to that). That reverse lookup is a non-trivial search and we found that Elasticsearch has a product called Percolator that can handle that. We saw an opportunity to consolidate the databases too since most of what we store is actually detector documents anyway, and all things being equal I'd rather have one DB than two.
Let me know your thoughts. I'm going to merge this but happy to take feedback.

@adriancole https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-percolate-query.html
Idea is that the metric-detector mappings are specified by query on metric tags. So when the metric point (document) comes in, we want to find the matching detectors (queries). The normal lookup is given a query, find the matching documents.

very interesting. thanks!


@added decorator does not work when applied to a namespace

The @added decorator does not work when applied to a namespace.
Playground Link

Other versioning decorators should also be considered (@removed,  @renamedFrom, @changedTypeFrom)

for this, narrow the target for these decorators
file a design issue for versioning containers

mark as breaking change

Describe the breaking change
Narrow possible targets of @added to exclude namespaces - specs with @added decorating a namespace will throw an error.
Back-compat design to avoid immediate breaking
Any back-compat design:  None
Link to detailed breaking design
Impact
This change affecting:

[ ] ARM
[ ] Data-plane
[x] Existing specs: 0
[ ] New specs
[ ] Emitters
[ ] SDK

Targeted Sprint
Sprint: November
Additional information


xgboost runtime transform bad performance

In our news CTR prediction scenario, we use xgboost to predict leaves then feed LogisticRegression as feature. The batch size is 1000 news candidates.
But mleap xgboost transformer perform much slower than raw xgboost scala library(x10~20 slower). I think there are two reasons:

mleap xgboost transformer transform row by row, raw xgboost library can predict 1000 candidates at once with DMatrix that can boost with multiple threads;
mleap xgboost transformer perform all of predictRaw/predictProbabilities/predict/predictLeaf/predictContrib default, but I just need predictLeaf;

Is it right?

you can refer to my mleap branch https://github.com/marsbible/mleap/tree/batch-predict, it adds batch prediction to xgboost runtime.
addtionally your can refer to my xgboost branch https://github.com/marsbible/xgboost/tree/predict-multithreading, it remove some threads contention code for prediction.

How much faster after the modification?  I have the same problem，When predict, it will often rise from 20 milliseconds to hundreds of milliseconds by chance.

Hey @ancasarb can you help to answer this question?

mleap run on xgboost is really slow.

Hello @marsbible . Is there any example of how to use RowTransformer(batch predict) ?

I have do some test. The bottleneck of the performance is XGBoostClassification call many times predictions by XGboost. In default, It will call rawPrediction, probability, prediction, leafPrediction,  contribPrediction.  That's the reason why xgboost runtime transform bad performance. So you should change the source code to comment it.
Another, the batch prediction only gain 10% improves.  I test @marsbible ' s code.

Hi @holysoros , we recently merged in this PR: https://github.com/combust/mleap/pull/645
which should make runtime predictions faster, if you use the PredictorOp.
If you try it out, let me know how it goes

Closing this for now in preparation of release 0.16.0, please reopen if PredictorOp doesn't improve things.


Add tests for packet_alert_max & alert queue optimization - v2

Previous PR: #808
Changes from last PR:

Add a test for to check for drop event even if there was an alert queue expansion failure (issue 5180, but ensuring realloc failure with a temporary 5319 approach).

(This is left as a draft because 5319 is waiting for https://github.com/OISF/suricata/pull/7463 to be merged before work on that front continues)
Related to issues:
https://redmine.openinfosecfoundation.org/issues/4207
https://redmine.openinfosecfoundation.org/issues/4942
https://redmine.openinfosecfoundation.org/issues/4943
https://redmine.openinfosecfoundation.org/issues/5180
https://redmine.openinfosecfoundation.org/issues/5319
Goes with Suricata PR https://github.com/OISF/suricata/pull/7469

Replaced by: https://github.com/OISF/suricata-verify/pull/842


getUserInfo access token gets overwritten by the default headers, if set

The getUserInfo requires an accessToken as first parameter. This access token should always be used independent of what is set on the defaultHeaders variable. However regarding this bit of code:
https://github.com/docusign/docusign-esign-node-client/blob/429c5226482cec3bbd74c83452ccba91874eb19f/src/ApiClient.js#L949-L954
The specified input accessToken will be overwriten by the one in the defaultHeaders due to the spread operator.
So, as soon as you call any method that changes the defaultHeaders like addDefaultHeader('Authorization', 'Bearer xxx') it does not matter what you pass into the  getUserInfo afterwards, it will always be ignored.
What I expect: The getUserInfo always uses the  accessToken passed in as input, independent of the defaultHeaders.

Hi @joaomvfsantos,
Thank you for bringing this to our attention; we will investigate and address this issue if confirmed.

Hi @joaomvfsantos ,
A new RC version (8.0.0-rc2) has been released with requested fix.
Please test out the same when possible. There will be a patch version 7.0.3 will be released as well with similar fix in a day or two.
Thank You.

@garg-mudit I confirm the release fixes the issue. I'm also interested in the 7.0.3 patch when it's available.
Best regards

Hi @joaomvfsantos ,
The 7.0.3 patch version has been released. Please test it and let us know if there are any remaining issues that need resolution.
Thank You.

@garg-mudit I confirm it's fixed on 7.0.3 too.


Using android studio to extract a variable causes breaking behaviour on a map

When running the variable extraction using android studio on a statement like below
var test = testMap['key'];
testMap['key'] = 'newVar';
if I run the variable extraction on this I get
var extracted = testMap['key'];
var test = extracted;
extracted = 'newVar';
This breaks the logic of the code. Only the value on the right of the = should be extracted
Flutter 2.2.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision f4abaa0735 (8 days ago) • 2021-07-01 12:46:11 -0700
Engine • revision 241c87ad80
Tools • Dart 2.13.4
Build: AI-202.76<IP_ADDRESS>86908,<PHONE_NUMBER>31,
AI-202.76<IP_ADDRESS>86908, JRE 11.0.8+10-b944.6916264x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.16, screens 2560x1440, 1680x1050; Retina
AS: 4.2.2; Kotlin plugin: 202-1.5.20-release-283-AS8194.7; Android Gradle Plugin: (plugin information not found); Gradle: (gradle version information not found); NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)
IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

@igloo12
Can you provide a complete minimal code sample along with steps to replicate, actual vs expected behavior to properly address this issue ?
Thanks.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Get the full class loader for BSP

I don't understand why we were using SpecialClassLoader but it seems to miss some jars, like os.Path for example is red in my build but not with this change.

Closing in favor of https://github.com/lihaoyi/mill/pull/969


Fix setting session cookie twice

Because setting cookie twice bothers me. Now proper options are applied to first one, so no need to set it again.
RocketTheme\Toolbox\Session uses ini_set() internally anyway, so this should not be a problem, but it can be changed to full session_set_cookie_params() call.

I had noticed this, but thought it was my local setup as I was testing login plugin changes.... Reverted.


Add Disable web search in windows search in #10

I also add message box to recommend run programs as admin.

In considering adding a section of a few more that I know of that is activated or shown only when running as admin (otherwise disabled).

In considering adding a section of a few more that I know of that is activated or shown only when running as admin (otherwise disabled).

Yes! I dont want to change many lines of code or adding more file because it make PR hard to check or update feature in future. So I only add a message box to do this.


[BUG] v1.5.1 - Snapshot job for "default" group. Retention is 20+ snapshots, but only one is kept at a time

Describe the bug (🐛 if you encounter this issue)
I have a snapshot job for "default" group. Retention is 20+ snapshots, but only one is kept at a time?
To Reproduce
Install v1.5.1.
Create a snapshot recurring job with a retention higher than 1.
Expected behavior

Snapshots according to my recurring job should be respected.

Support bundle for troubleshooting
Environment

Longhorn version: v1.5.1
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): Rancher Catalog App
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: v.124 (RKE2)

Number of management node in the cluster: 5
Number of worker node in the cluster: 5

Node config

OS type and version: Ubuntu 22 LTS
Kernel version: 5.19
CPU per node: variable
Memory per node: 80GB+
Disk type(e.g. SSD/NVMe/HDD): HDD
Network bandwidth between the nodes: 1G

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):
Number of Longhorn volumes in the cluster: 20

Additional context

Could you provide the support bundle?

Could you provide the support bundle?

Generating. I should have searched for this issue before posting - hopefully someone else hasn't posted the same issue for 1.5.1.

It's 185 MB. Where can I send it?

It's 185 MB. Where can I send it?

Could you provide a downloadable link to<EMAIL_ADDRESS>

Done. Thanks.

 Ref: https://github.com/longhorn/longhorn-manager/blob/v1.5.1/controller/engine_controller.go#L1176

logs/longhorn-system/longhorn-manager-dk7w5/longhorn-manager.log:2023-08-08T18:00:07.311870671Z time="2023-08-08T18:00:07Z" level=info msg="Deleting snapshot CR for the snapshot c-kh08nt-966de4ce-ad6e-49fa-a819-d4b83da61fc0" controller=longhorn-engine engine=pvc-51af6da0-bf12-4376-af71-1e0ab9e8d0c2-e-f9ff3369 node=worker2
logs/longhorn-system/longhorn-manager-dk7w5/longhorn-manager.log:2023-08-08T19:00:38.169308850Z time="2023-08-08T19:00:38Z" level=info msg="Deleting snapshot CR for the snapshot c-kh08nt-029a2cda-78b8-444f-a374-2f1fce7546c9" controller=longhorn-engine engine=pvc-51af6da0-bf12-4376-af71-1e0ab9e8d0c2-e-f9ff3369 node=worker2
logs/longhorn-system/longhorn-manager-dk7w5/longhorn-manager.log:2023-08-08T21:00:37.479831509Z time="2023-08-08T21:00:37Z" level=info msg="Deleting snapshot CR for the snapshot c-kh08nt-70810bfb-098d-4d24-a314-df18ca3edc9c" controller=longhorn-engine engine=pvc-51af6da0-bf12-4376-af71-1e0ab9e8d0c2-e-f9ff3369 node=worker2
logs/longhorn-system/longhorn-manager-dk7w5/longhorn-manager.log:2023-08-08T21:00:42.497609120Z time="2023-08-08T21:00:42Z" level=info msg="Deleting snapshot CR for the snapshot c-kh08nt-bd1ea452-1629-40c2-a756-b86b95705483" controller=longhorn-engine engine=pvc-51af6da0-bf12-4376-af71-1e0ab9e8d0c2-e-f9ff3369 node=worker2
logs/longhorn-system/longhorn-manager-dk7w5/longhorn-manager.log:2023-08-08T23:00:23.882915301Z time="2023-08-08T23:00:23Z" level=info msg="Deleting snapshot CR for the snapshot c-kh08nt-b601c1d6-2cdf-4703-88d0-c31b7f97743e" controller=longhorn-engine engine=pvc-51af6da0-bf12-4376-af71-1e0ab9e8d0c2-e-f9ff3369 node=worker2
logs/longhorn-system/longhorn-manager-dk7w5/longhorn-manager.log:2023-08-08T23:00:37.678076254Z time="2023-08-08T23:00:37Z" level=info msg="Deleting snapshot CR for the snapshot c-kh08nt-a1efc228-758e-471a-a008-8b1206e930a7" controller=longhorn-engine engine=pvc-51af6da0-bf12-4376-af71-1e0ab9e8d0c2-e-f9ff3369 node=worker2
logs/longhorn-system/longhorn-manager-dk7w5/longhorn-manager.log:2023-08-09T00:00:22.774428192Z time="2023-08-09T00:00:22Z" level=info msg="Deleting snapshot CR for the snapshot c-kh08nt-924869d0-09d1-4066-bcb9-7bd3d981970d" controller=longhorn-engine engine=pvc-51af6da0-bf12-4376-af71-1e0ab9e8d0c2-e-f9ff3369 node=worker2
logs/longhorn-system/longhorn-manager-dk7w5/longhorn-manager.log:2023-08-09T01:56:02.321614996Z time="2023-08-09T01:56:02Z" level=info msg="Deleting snapshot CR for the snapshot c-kh08nt-f3d82d0f-b593-4804-8c86-c1ad77022d80" controller=longhorn-engine engine=pvc-51af6da0-bf12-4376-af71-1e0ab9e8d0c2-e-f9ff3369 node=worker2
logs/longhorn-system/longhorn-manager-dk7w5/longhorn-manager.log:2023-08-09T02:00:33.700825626Z time="2023-08-09T02:00:33Z" level=info msg="Deleting snapshot CR for the snapshot c-kh08nt-1d62b514-5627-4b4c-849b-c75f2d0784e4" controller=longhorn-engine engine=pvc-51af6da0-bf12-4376-af71-1e0ab9e8d0c2-e-f9ff3369 node=worker2

BTW, noticed backups are not able to finish within 1 hour, suggest to set to longer intervals to resolve the error.
2023-08-08T07:00:00.103755066Z I0808 07:00:00.103277       1 event.go:294] "Event occurred" object="longhorn-system/c-di8ahv" fieldPath="" kind="CronJob" apiVersion="batch/v1" type="Normal" reason="JobAlreadyActive" message="Not starting job because prior execution is running and concurrency policy is Forbid"

One potential explanation is that the syncSnapshotCRs was called prior to updating the Engine.Status.Snapshots. However, I am not able to reproduce this so far.

BTW, noticed backups are not able to finish within 1 hour, suggest to set to longer intervals to resolve the error.

Most of my volumes are under 20GB's, I have one 80GB volume, I tested restoring it and the restore speed was like under 5MB - my Minio/S3 gateway is much faster than that - so I don't know why that was so slow.


Adding av-analytics-dynamic value

currently the analytics values are set when initialized.
av-analytics-dynamic will be a list of values to check when event is called
these values will be searched in av-analytics-on element attributes ('av-analytics-value' or 'data-av-analytics-value')

reopening in dev


Can't Create table use CTAS and CreateTable Like

Bug 报告
When I wan't to use TiSpark and Hive together, It's OK to read data from hive and TiKV, but it failed to Create table into TiKV. I have seen the code of Ti Spark, it show's that  your have write a Command of Create table like, but it don't works.

What is the document directory for the problem?

How would you like to improve it?
When use hive and tispark together, we can create table in TiKV

Create table to TiDB via TiSpark is not supported for now. You can use JDBC to create table.

Hi, @AngersZhuuuu.
As you can see, TiSpark has not yet implemented create table like statement to create TiKV tables. The current create table like statement will try to create the table in Hive.
The error you are observing is due to the fact that your catalog in Hive is on database default, and it already contains a table called test_ctas. We will support this feature later.  In order to do so, we will provide an API such as  create tikv table like or create tikv table select. You may keep track on this issue for this progress.
Meanwhile you can also use DataSource API to create a DataFrame and insert into TiKV, which you may refer to this document. Or you may as well use JDBC connector to run your statement.

it seems everyone is happy now, closing.


Error in makeClinChar

When doing
analysisSettings <- makeClinChar(targetCohortIds = 1:5,
dbms = con@dbms,
targetCohortNames = executionSettings$databaseName,
cdmDatabaseSchema = executionSettings$cdmDatabaseSchema,
workDatabaseSchema = executionSettings$workDatabaseSchema,
cohortTable = executionSettings$cohortTable)
Got an error
Error in (function (cl, name, valueClass) :
assignment of an object of class “NULL” is not valid for @‘tempEmulationSchema’ in an object of class “executionSettings”; is(value, "character") is not TRUE
ClinicalCharacteristics version 0.2.9

tested on redshift when tempEmulationSchema is NULL should be good. Please give your example another try, let me know if it errors out again.