Release 2.0.9

Descriptive summary
DMR Version 2.0.8
Release Manager: @VivianChu
Product Owner: @gamontoya
Operations: @jhriv
This release includes the work on addressing student access denied issue

@jhriv - New release branch has been merged into the master branch.  Could you please deploy it to production as soon as possible?  Thanks


Consume Artifacts

Hi, I have a separate build that generates an artifact stored in Azure. Now I have a second pipeline that needs to consume that artifact, but there's no info about how to generate credentials to be able to consume the artifact repo in another isolated build.
The ideal would be to have a step that generates some env variable with the credentials, that I could inject into the docker build that internally installs the dependency.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 638243e7-cdd6-7573-aa6a-87c39da1bb3d
Version Independent ID: d0046f56-ed26-7af2-3b8f-3dd5ab6ab892
Content: Publish packages to PyPI - Azure Pipelines
Content Source: docs/pipelines/artifacts/pypi.md
Product: devops
Technology: devops-cicd
GitHub Login: @thomps23
Microsoft Alias: elbatk

I was actually working on a PR to add this to docs when I saw your comment. Until it lands, please take a look at the following gist that I've extracted from a working pipeline
https://gist.github.com/noelbundick/0262aa0f37ec3f9a179137c622b6280d

@noelbundick wow, that what's exactly that I was looking for! great gist, thank you for sharing. Hope that PR get merged soon

@syonekura Apologies for the delayed response and thank you for reaching out. It looks like Noel helped you with your issue. Closing this one now.


extension breaks the new task view

Todoist introduced a "new task view" in Web version 2083. With the todoist-shortcuts extension enable the new task view doesn't work and is the old style. With the extension disabled the new task view works as expected.

Hey, what version of todoist-shortcuts are you on? This has been discussed on #204
I did just notice that the scheduling keybinding was broken, but that is now fixed in version 151

I'm on 152. The extension works, but it ends up with the old task view instead of the new view.
This is what I see after hitting Enter with a task selected
Without the extension enabled:

With the extension enabled:

Oh, yeah, that's just how todoist shortcut's keybindings work.  "i" is the
key to open task view.  Task view got a funny shortcut because
todoist-shortcuts predates the addition of the task view.
Happily, there are many similarities because Todoist took inspiration from
this extension.  However, I cannot change the extension's behaviors without
negatively impacting the muscle memory of the ~2000 users (and my own
muscle memory)
I know, this isn't great for people who start with Todoist native
shortcuts, maybe I will finally cave and add some options / configurability
to this extension...
On Fri, Jun 17, 2022 at 1:10 PM Brett Miller @.***>
wrote:

I'm on 152. The extension works, but it ends up with the old task view
instead of the new view.
This is what I see after hitting Enter with a task selected
Without the extension enabled:
[image: todoist_task_without_shortcuts_extension]
https://user-images.githubusercontent.com/1895215/174387411-d68d7c62-0ae3-440d-a3bf-2dd117f004a0.png
With the extension enabled:
[image: todoist_with_shortcuts_extension]
https://user-images.githubusercontent.com/1895215/174387465-f660aaa4-acd0-4234-82ab-186a6b362acc.png
—
Reply to this email directly, view it on GitHub
https://github.com/mgsloan/todoist-shortcuts/issues/213#issuecomment-1159159930,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFQKUGH5KHY7BXJ4OA7HTVPTETPANCNFSM5YVWV7OA
.
You are receiving this because you commented.Message ID:
@.***>

Ah, that makes sense. I've been using this extension pretty much since I started using Todoist, but I've always just used 'Enter' to modify a selected task and when Todoist announced changes to the selected task view and I wasn't seeing them I turned off the extension to see if that was why and it was. I can try to modify my habits to use 'i' if I want see the new task view.
I have noticed something that does seem to be an actual bug. If you hit 'enter' to edit a task and then 'esc' to close it, the focus is taken away from the task, but the task isn't properly closed (as it would be if clicking the 'cancel' button). You also can't select the task again after it looses focus unless you either tap it's 'cancel' button or select another task with 'enter' (then that task goes into the same weird state). After hitting 'esc' and the task loosing focus it seems to put focus on the previous last in the list, but the highlight to the left of the task to show it as selected isn't there. If this would be better in a new issue let me know and I can open one and then this one can be closed.

If you hit 'enter' to edit a task and then 'esc' to close it, the focus is taken away from the task, but the task isn't properly closed

Hmm, curiously I don't see this bug!  For me escape closes the task editor.  Feel free to open a bug about it.

You also can't select the task again after it looses focus unless you either tap it's 'cancel' button or select another task with 'enter' (then that task goes into the same weird state). After hitting 'esc' and the task loosing focus it seems to put focus on the previous last in the list, but the highlight to the left of the task to show it as selected isn't there.

Ah, good catch!  Fixed this in version 153.


[Error] Bancor Protocol

According to Bancor Protocol, balance seems to be set as a wrong value
real_type C(c.balance.amount+in.amount); -> real_type C(c.balance.amount);
https://github.com/EOSIO/eos/blob/13952d4505d56442a769528bdf6094b52768b2cd/contracts/eosio.system/exchange_state.cpp#L7
Also, supply seems to be set as a wrong value.
real_type R(supply.amount - in.amount); -> real_type R(supply.amount);
https://github.com/EOSIO/eos/blob/13952d4505d56442a769528bdf6094b52768b2cd/contracts/eosio.system/exchange_state.cpp#L25
if connector weight was intended to be 50%, the number "1000.0" should be "1.0" (since c.weight = .5 in exchange_state.hpp)
https://github.com/EOSIO/eos/blob/13952d4505d56442a769528bdf6094b52768b2cd/contracts/eosio.system/exchange_state.cpp#L8
https://github.com/EOSIO/eos/blob/13952d4505d56442a769528bdf6094b52768b2cd/contracts/eosio.system/exchange_state.cpp#L27

Connector weight was not intended to be 50%, but .1%.
The Bancor Protocol math is wrong in their paper, absent the "+ in.amount" and "- in.amount" the protocol can be gamed.  Extensive tests have verified the math cannot be gamed and always sees error approaching 0 when higher precision numbers are used.

@bytemaster
Yes the Bancor Protocol math is wrong in their "white paper"
If you wanted to fix it, you had to fix the following line:
  real_type T = C * (std::pow( ONE + E/R, F) - ONE);

it should be as follows:
real_type T = -1 * C * (std::pow( ONE - E/R, F) - ONE);

I am reviewing carefully Bancor papers. When saying that there is an error, please, refer clearly to what formula from what document you are talking about. So far I didn't find any errors in Meni Rosenfeld's article (though it could have been done simpler without integrating) nor in the two formulas in the last page of Bancor Whitepaper.

@sergioyuhjtman
I am sorry for unclearness. And the paper you have linked has no error. It was "white paper" https://storage.googleapis.com/website-bancor/2018/04/01ba8253-bancor_protocol_whitepaper_en.pdf (second equation of page 11) that I referred to. (Now I can see that whether the equation is wrong or not is depend on convention). The term "connected tokens paid out" in the LHS it self has negative sign therefore it should be multiplied by "-1". The same is true for the term "tokens destroyed" in the RHS. Thank you for reviewing this issue 👍

@hyunwoongJi Thanks. Please read also here https://eosio.stackexchange.com/questions/317/is-there-a-math-error-in-bancor-paper  to understand better what Dan Larimer has in mind. He is confused because he thinks that Rosenfeld's formulas are wrong. Since Dan's formulas make a difference in favor of the exchange, maybe this is good enough. But still I think it has to be reviewed carefully.

@sergioyuhjtman Thank you for sharing. Now I can understand it. And thank you again for taking this issue carefully :)


Side chain Frame constrcution

For example:
# psi-frame to backbone
    mat = _make_rigid_transformation_4x4(
        ex=atom_positions['C'] - atom_positions['CA'],
        ey=atom_positions['CA'] - atom_positions['N'],
        translation=atom_positions['C'])
    restype_rigid_group_default_frame[restype, 3, :, :] = mat

From paper: For the side chain frames, we use the atom before the torsion bond as x1, the atom after the torsion bond as x2 and the next atom after that as x3.  but here, CA atom is the origin of the Psi frame,  can you help me to explain this code?

@wangleiofficial Hi, Did you figure it out? I don't quite understand this part either.

This piece of code creates a matrix that sets up transformation matrix and a translation point two orthogonal axis from C-CA and CA to N within the protein chain and an axis perpendicular to them both but also, setting to C atom position which is correct for a PSI frame.
So For the side chain frames, we use the atom before the torsion bond as x1, the atom after the torsion bond as x2 and the next atom after that as x3 is correct but this piece of code does not relate to side chains.


Allow overriding $PROFILE file in Chocolatey installer

System Details

posh-git version/path: <IP_ADDRESS>  C:\tools\poshgit\dahlbyk-posh-git-9bda399\src
PowerShell version: 5.1.17134.112
git version 2.18.0.windows.1
OS: Microsoft Windows NT 10.0.17134.0

Issue Description
I notice in chocolateyInstall.ps1 for the posh-git Chocolatey package. That the install script uses the following:
    if ($PROFILE -and (Test-Path $PROFILE)) {
        Write-Verbose "Updating posh-git location in `'$PROFILE`'."
        $oldProfile = @(Get-Content $PROFILE)

It'd be really handy to be able to use Chocolatey package parameters or an Environment variable.

Would you like to specify an exact path, or one of the named $PROFILE locations (CurrentUserAllHosts, etc)?

In my case the exact path would be more useful since I split my profile up a bit so I'd point posh-git to  $env:USERPROFILE\Documents\WindowsPowerShell\Profile_PoshGit.ps1.

Interesting. Supporting an environment variable to override the posh-git install location seems the easiest option to let the setting propagate all the way down into Add-PoshGitToPrompt.


Show snapshot warnings in the summary

The compare endpoint will now sometimes return a header called x-github-dependency-graph-snapshot-warnings, which contains additional information about snapshot comparisons that users should know about. Right now, this header is only returned if the repository is flagged in for snapshot comparisons.
This PR adds code to look for the header, decode it if it is present, and display it in the summary. It does still contain some placeholder text, but that will change in the next day or two.

Here's a screenshot of this in action.


Enhances spo site set with ability to adding owner without having permissions, Closes #4600

Closes #4600

Thank you @nicodecleyre! We'll review it ASAP!

Question @nicodecleyre: how does this perform in an environment with many sites? I'm asking myself if we should call the admin endpoint all the time or only if the regular endpoint fails.

Question @nicodecleyre: how does this perform in an environment with many sites? I'm asking myself if we should call the admin endpoint all the time or only if the regular endpoint fails.

Don't know... I will take a look if i can test it on a tenant with 5000+ sites...

Hi @nicodecleyre,whats the status of this PR? Is it ready for review?

Hi @nicodecleyre,whats the status of this PR? Is it ready for review?

Not yet, gonna test it with a tenant with 5000 sites next week

Test looking good! (added some extra logging for this test) Let me know if you want me to test anything else

Test looking good! (added some extra logging for this test) Let me know if you want me to test anything else

How about speed of execution @nicodecleyre? How big was the tenant you tested this on and did you notice performance differences between the old and new way?

@nicodecleyre, did you have an answer on my question already?

@nicodecleyre, did you have an answer on my question already?

sorry about that! Tested it on a tenant with 5050 site collections.
I don't notice any change in speed. Just the fact that the command works with the enhancement as seen below (see 2nd output, first output is as is)

Hi @nicodecleyre,
It's been a while since I've responded to this one.
Reason is I've been thinking about the setup.
Retrieving all tenant sites using the new endpoint has a few drawbacks: You appear to cannot retrieve OneDrive sites like we do with the other endpoint, plus its interface is different from the CSOM request we are normally doing.
And the siteId cannot be found on other endpoints. It's not ideal.
So I thought: why are we even retrieving the siteId. And it turns out we only use it in one place. On the UpdateGroupPropertiesBySiteId function. Well, it appears there's an alias function that does not need the siteId: UpdateGroupProperties.
The following request updates the site title just as well:
POST https://contoso-admin.sharepoint.com/_api/SPOGroup/UpdateGroupProperties
{
  groupId: this.groupId,
  displayName: args.options.title
}

So I suggest we change it up a bit:

Use the getSiteGroupId function in site-remove.ts to get the group ID through the admin endpoint
Update to using the UpdateGroupProperties function.

Together this should be enough, and we can remove the getTenantSites util and implementation entirely. The change will be quite small.
Could you update the PR with this implementation? Thanks again for all the work!

Hi @nicodecleyre, how r u doing on this? Just checking 😀

Hi @martinlingstuyl,
Dit the changes as asked. If i'm not mistaken we still have to use getTenantSites to get the groupId. Or do I see this wrong and do you want to revert this to the usage of /_api/site?$select=GroupId?

Hi @nicodecleyre,
Nice, you've been busy!
About your question: You're right, we still need the groupId. but I'd like us to get it using the list on the admin site: DO_NOT_DELETE_SPLIST_TENANTADMIN_AGGREGATED_SITECOLLECTIONS, checkout hubsite get for example.
This seems to me more straightforward than using RenderAdminListData after all. For one we can use an odata $filter `SiteUrl eq '', and also we can reuse code.
Now you've been building this util in another PR. I suggest we wait a bit for a conclusion on the discussion there as to how we're going to handle the util PR's.

Waiting on the conclusion here

Hi @nicodecleyre @martinlingstuyl , I see this long discussion here, and I was wondering if the issue mentioned in the topic of this PR has already been resolved with the spo site admin add --asAdmin --primary command.
I noticed there were some doubts about using the admin endpoint (the https://contoso-admin.sharepoint.com/_api/SPO.Tenant/ endpoint is used in site admin add). Is there something I should reconsider in this command?

Hi @mkm17, That command does make this PR less urgent, yes...
I don't think I had doubts about using admin endpoints, but more about what endpoint to use so that it covers all types of sites (onedrives, regular sites, group sites) and where the group Id might be found if needed.

@martinlingstuyl ok, thank you for confirmation.


New Release?

The README specifically says that v0.5.0 uses a deprecated API, but that's also the last release.
Should there have been a new release cut or should we use the deprecated API?

The readme says the deprecated api was removed in 0.0.5 the current version is 0.5.0


Cannot obtain loader entries

Describe the bug
rebuild boot (or switch) do not create loader entries in  systemd-boot
To Reproduce
Steps to reproduce the behavior:

install NixOS unstable
git clone template branch
cp /etc/nixos/hardware-configuration.nix hosts/asus.nix
cp /etc/nixos/configuration.nix hosts/configuration.nix
import configuration.nix in asus.nix
change locale.nix
nix-shell
git add .
backup old config
create link nixos --> $pwd
rebuild asus test # all right
rebuild asus switch #or boot
reboot
nothing(

Expected behavior
I thought I would get new boot entry. Also, when I restart display-manager system is shutdown.
Additional context
Personal branch
EFI mount on /boot

I think I solved my problem. After rebuild switch need to execute sudo nixos-rebuild boot.


"Release notes" template

Summary
In a effort to improve our release process, we want to add a release note to all deploys to production.
Ideally this template will live in Github as a pull request template.
Output
A Pull request template to be used for all merges from development to master.

We're closing this issue due to the new GitHub auto generated release notes features
https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
This is solving our issue for now.


fix: Stop 'Add & edit Task' breaking sub-tags of global filter

Description
For a task in the format of:
- [ ] #global_filter <some description> #something_that_includes_global_filter ...
i.e., when the task includes a tag that includes the global filter, when editing the task via the Edit Task dialog and updating any field, the task is rewritten to its origin note without the original global filter. In the example above, merely editing the task line via Edit Task and updating it, will rewrite the task as <some description> #something_that_includes_global_filter ....
Worst part is if there are multiple tags that match the global filter, the Edit dialog actually corrupts them by removing the global filter match from one tag every time the task is updated...
This provides a simple fix.
Motivation and Context

I'm using #t as a global filter and #t/... for various task tags, e.g. a typical task I have is #t Some description #t/next #t/atOffice.
My tasks kept losing the global filter and their tags it took me a while to figure out why...
First time edit a task like the above it became Some description #t/next #t/atOffice, which could be fine, but on the next edit it became Some description /next #t/atOffice which was breaking my queries...
How has this been tested?

Only on my own copy.
To my best understanding, this dialog has no automated tests.
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project and passes yarn run lint.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] My change has adequate Unit Test coverage.

By creating a Pull Request you agree to our Code of Conduct. For further guidance on contributing please see contributing guide

Sorry about that, will rebase the main branch instead of merging it next time.

Sorry about that, will rebase the main branch instead of merging it next time.

Perfect - thanks very much.

Have you tested this in a vault without a global filter? What happens?
I'm fairly uncomfortable merging this without any tests for the logic in the modal/dialog. I think it's time to start adding them, first with a failing test for this capability...
A first step for that would be a PR to purely refactor the dialog code, to extract the guts of onMount() and _onSubmit() to stateless typescript code, so that the .svelte only deals with the UI widgets and has no - or minimal - logic.
Then there can be a second PR that fixes the behaviour.
I'm happy to pair on the adding of the first test, if it would help.

This refactoring sounds very doable, I might be able to do that next week.
But note that this is a data corruption bug - the plugin removes text without user intent, and as such it might be important to push a minimal patch first. Even if it goes through some more manual tests.
Also, the bug you linked to (https://github.com/obsidian-tasks-group/obsidian-tasks/issues/827) is interesting in this regard because it's the result of the same logic (removing the global filter and adding it back), but my change doesn't fix it. My patch can be extended to treat these cases (e.g. not remove the global filter if it's not a complete word, and then by the logic that I added, it will also not be "added back").

I did some basic testing. I haven't tested all paths through, but here is the first test I did:
With no global filter, on a blank line, open the Add/edit dialog, type wibble, press enter and the result is:
Before this PR:
- [ ] wibble (i.e. 1 space before wibble)
After this PR:
- [ ]  wibble (i.e. 2 spaces before wibble)
I suspect that this is because the logic to detect whether the global filter is present in the task looks like it doesn't allow for the global filter being blank, which is always present in the task, effectively...

Yes, caught that too following your previous comment. Embarrassing :facepalm:
But it's easy to get this patch to be simple to verify!

So I think the paths to manually test are something like:
for each [with Tasks version prior to PR, with build of this PR]
    for each [with global filter, without global filter]
        for each [on blank line, on line with `- [ ] `, on existing task]
            open add/edit modal
            make edit
            save results
            check results
and compare the results of each step with the 2 different versions of the Plugin

I volunteer to smoke test this on obsidian stable, if needed, following the protocol from above. Just let me know! (And then wait for timezone delay... :)

That's awesome, thank you!
I believe I'll fix the PR tomorrow and ping you when ready for testing :sunglasses:

That's awesome, thank you! I believe I'll fix the PR tomorrow and ping you when ready for testing 😎

Hi @esm7 - no pressure, but just to let you know I'll be doing a release soon - hopefully in the next day or so - so if you can see an easy way to fix the problem for users with no global tag filter, I'd be happy to include it in the release...

Thanks for the heads up! My week was busier than I anticipated so I'll only be able to do this on Sunday. I assume I'm going to miss the release window, but it's going to be a small fix, so I hope you'll feel confident to include it as part of some smaller patches release in the near future.

Thanks for the heads up! My week was busier than I anticipated so I'll only be able to do this on Sunday. I assume I'm going to miss the release window, but it's going to be a small fix, so I hope you'll feel confident to include it as part of some smaller patches release in the near future.

Thank you, yes, that's absolutely fine. It can either be released on its own as a bug-fix. Or there are a few smaller new features coming soon too, so it could be included with then. Very happy either way...

I pushed a fix, and as part of @AnnaKornfeldSimpson 's offer to comprehensively test this, I felt more confident to rewrite this fix in a more comprehensive manner that also fixes https://github.com/obsidian-tasks-group/obsidian-tasks/issues/827.
The new logic removes the global filter from the description only if it is a whole word, and returns it to the task when the dialog is closed only if it was indeed removed.
This means that if the global filter is #task and the description is some #task/group, it will be shown in the dialog unmodified.
Only if the description includes #task as a whole word, e.g. some #task, it will be removed for the purpose of editing in the dialog, and be put back at the beginning (like the original logic) on save.

I pushed a fix, and as part of @AnnaKornfeldSimpson 's offer to comprehensively test this, I felt more confident to rewrite this fix in a more comprehensive manner that also fixes #827.

Thanks for your work on this.
I feel in a difficult position now. This has gone from something like a 2-line fix that I could reason about (and was able to immediately spot a potential bug with, for when there was no global filter) - to a much more complicated thing, with multiple regular expressions.
The smoke tests are literally that - a very simple few-item run through to detect major errors. They do not replace developer testing, and would not have spotted the bug mentioned above.
Manual testing of this change would need a lot of care and thought about the happy paths, and potentially breaking changes.
And this would need to be repeated when future changes are mode to this code.

The new logic removes the global filter from the description only if it is a whole word, and returns it to the task when the dialog is closed only if it was indeed removed.
This means that if the global filter is #task and the description is some #task/group, it will be shown in the dialog unmodified.
Only if the description includes #task as a whole word, e.g. some #task, it will be removed for the purpose of editing in the dialog, and be put back at the beginning (like the original logic) on save.

I am sorry, but with the larger scope and complexity of the code in this change now, my preference is to ask for:

the pure refactoring that we talked about earlier to be made as one PR - that adds some tests for the existing behaviour (it's fine if those tests record the current broken behaviour, for later updating once the behaviour is improved.)
then once that is merged, for a separate PR to be made that actually changes the behaviour, together with tests for the changed behaviour.

No worries, I will go back to a simple fix of the original 2-line fix; I may have gone too far compared to what can actually be tested thoroughly with the current infrastructure!

No worries, I will go back to a simple fix of the original 2-line fix; I may have gone too far compared to what can actually be tested thoroughly with the current infrastructure!

That's great. Thank you for your understanding.

@claremacrae I have an idea!
What if I move this specific piece of logic, of removing the global filter and adding it back, to the Task class, and then cover it with tests using the existing infrastructure? Will you then be comfortable with a more comprehensive change?

Hi @esm7

@claremacrae I have an idea!
What if I move this specific piece of logic, of removing the global filter and adding it back, to the Task class, and then cover it with tests using the existing infrastructure? Will you then be comfortable with a more comprehensive change?

How many PRs are you envisaging? 1 or 2?

How many PRs are you envisaging? 1 or 2?

But to answer your question, yes, definitely happy with moving the logic out to somewhere where it can be tested... Basically, the less logic in UI code the better...
If you feel Tasks is the right (or geedo-enough) place, that's fine too.

Whatever you prefer; adapting the current very thin logic (a few lines of simple code) to move to Task and adding tests to it is almost trivial.
But doing the fix in the same PR is more convenient, that's for sure.

I understand that, from the author's perspective.
I'm thinking about 2 things:
Long-term usefulness of the diffs history in the repo
This repo is set up to squash all PRs, so even if the combined single PR consisted of a refactoring commit and then a fixing commit, they would get squashed in to one.
And so future maintainers reviewing the history, e.g. via git bisect would never be able to separate out the refactoring change from the fixing change.
Ease of reviewing the PR.
With a refactoring PR, the reviewer only has to convince themselves that the behaviour really hasn't changed.
With a bug-fix PR, they only have to understand the diff in fact does give the required change in behaviour.
If the PR does both, those two things become entangled, and it takes a lot longer to review.
I realise there will be a bit of a wait for the author between the two PRs, but in general, I will be able to merge two separate such PRs much more quickly than a single combined one.

Hallo @esm7, Is this one still needed, please, or is the next step a new PR off of main? Thanks.

Very needed indeed! Although it's been quite a journey since my tiny fix a few weeks ago, the whole discussion is here in this PR, so I was planning to finalize the fix based on the new refactored main in this PR.
Expecting to get to it today.

Done: updated this PR according to the new master.
Please note that by now, due to this PR going through many life stages, the commit history of the branch is very hard to follow.
But I thought that:

I should still merge from main rather than rebase, because rewriting the history of an active PR would make a future attempt to follow what we discussed here very difficult,
We rather use the same PR, and stick to the final result (via the 'Files Changed' diff), because it includes important discussions that also relate to other bugs and PRs.

Note that although the "base logic" is now covered with thorough tests, the actual flow of the UI is not, so the proposition of @AnnaKornfeldSimpson to run some well-defined manual tests is still very applicable.

Thank you!

I have tested this thoroughly in:

a vault that uses global filter #task
a vault that uses global filter Todo:
a vault with no global filter

The steps I tested were:

create a new task in the modal
manually add a sub-tag at the end
edit the task in the modal - and confirm the tags were unharmed in the process

Before updating, I was able to reproduce the problems described.
After updating, the behaviour was correct.

Splendid! Sorry for my delay. Is there anything that you still need/want me to test here?

No thanks - it's all good.

First and foremost, so great to see the great work done here by all of you!
Now to the rest of the stuff:

What seems to have happened is that after I tested the code, and the linter failed just before I wanted to commit, I blindly "fixed" the regex -- wrongly, it seems.
Although taken from a credible source, it's not great that escapeRegExp was not covered by any tests, and the higher-level flow that is using it is not covered by any tests that try to challenge this piece of code. Fact is that it can break very easily.
Slightly off-topic, but I feel the need to defend regular expressions as a whole :laughing: Before being a regex junkie, I used to write incredibly complicated code that searches for things in strings and uses complicated index tricks, which was unreadable and extremely inexpressive. Regex's are indeed cryptic, and in JS they are very poorly composable (it's unreasonably difficult to break a regex into smaller logical parts), but they are incredibly expressive for what they do!
Back to our topic, actually fixing the error is easy. So is adding a bunch of tests that cover some reasonable scenarios of global filters that may need escaping.
What troubles me is the part of "tests that exercise thoroughly every single one of the characters that are supposed to be being escaped". I'd love us to look at this PR in its original context: all I wanted initially was to fix what I thought to be a tiny bug :sweat_smile: We've come a long way: I wanted to provide a more thorough fix, and on the way cover in tests a piece of the code that never had any coverage. If I push a simple fix to escapeRegExp and a few basic tests that cover it, as far as we know this branch improves Tasks in both known bugs and coverage. I'd really love to move forward and use the little development time I scratch off my days for giving value in other areas such as https://github.com/obsidian-tasks-group/obsidian-tasks/discussions/877.

Yes, I agree with pretty much everything that you say. 😄
I have already written systematic tests - as linked to earlier today. To save you from hunting, I've just made a PR for them: Add systematic tests for escaped regex characters. by claremacrae · Pull Request #18 · esm7/obsidian-tasks · GitHub
If you are OK with them, and could decide what to do about the 3 characters that the escaping functions breaks searching for - see the comments in my PR code -  that should be all that's needed to merge your PR. 🎉

Slightly off-topic, but I feel the need to defend regular expressions as a whole  ...  in JS they are very poorly composable ...

Yes, I totally agree with their power, and being 'poorly composable' - hence also  'poorly comment-able'.
Once I got the new code thoroughly tested earlier, I did try breaking down that new regex into components with comments, and could not get the tests to pass, so gave up after a few minutes. 😢

What troubles me is the part of "tests that exercise thoroughly every single one of the characters that are supposed to be being escaped".

It's OK, I've already added all the tests. I've just submitted them as a PR on your branch: #18 · esm7/obsidian-tasks
It didn't take me long, and I learned a bunch about the behaviour of the code at the same time, including that some of the escaping seems to give broken regexes, as far as I could tell.

I'd love us to look at this PR in its original context: all I wanted initially was to fix what I thought to be a tiny bug

Yes ❤ ! And I'm very grateful for that, as will be the users who complained about their tags being lost.
The first fix just added the small issue of the extra space at the start of the line for users without a global filter.
Rather than a fix to the logic there, you kindly went on to produce a couple of iterations of a more comprehensive, general fix, which required more testing (on my part) but has definitely given a more robust improvement for those with global filters, for which thank you very much indeed!

... as far as we know this branch improves Tasks in both known bugs and coverage.

Sorry, but that's the bit I got a bit stuck on.
As the person doing user support, and taking on responsibility for maintaining any merged PRs, I just wanted a bit more confidence than that, and your separating out the UI logic enabled me to add the tests I wanted, and which I was very happy to do.

I'd really love to move forward and use the little development time I scratch off my days for giving value in other areas such as Themeability / CSS friendliness Suggestion #877.

Absolutely! There will be many happy users from that one too.
Very many thanks for all your contributions - version 1.9.0 was huge, and almost entirely your work.
Oh, and I had a nice email today, from a Tasks user, about one of those contributions:

BTW, I greatly appreciate, and was impressed by, the inline Task editor today! Surprisingly helpful! It replaces the need for text completion/expansions that I used to use when defining tasks inline!

D'oh. It just dawned on me that I could accept this PR and trivially add the systematic tests myself, so I will go ahead and do that.

@esm7 Very many thanks for working on this!

Awesome, great to see this merged!
(And sorry for being less responsive in the past few days, been a crazy week.)


Typedoc generator should be accessable from API.

Problem
I would like to genereate typedoc when express app is starting.
I dont see a way to do this without copyting and pasting whole typedoc bin file to my project files.
Suggested Solution

Move content of /bin/typedoc to /dist/execute.js.
Wrap content in a function.
In /bin/typedoc execute this function with 0 arguments.

So.. there's a problem with this. What the CLI does and what your server does should almost certainly not be the same.

bin/typedoc reads command line arguments - it likely shouldn't on your custom script.
bin/typedoc supports watching - it likely shouldn't in your custom script.

It really isn't that much code to set up TypeDoc in a more appropriate way for your usage.  The example here is likely sufficient.


fix 183 When isReverse is true,The scroll bar position incorrect

ref #183

Thanks. I don't know how this has gone unnoticed this long!

Could I ask When do you guys think this PR is going be merged and released?

Thanks for the work! I was looking for the problem and find this PR!

Mentioned a work around in case anyone is still waiting on this: https://github.com/CassetteRocks/react-infinite-scroller/issues/183#issuecomment-443371529

May I ask is there any plan for merging this PR?

Released in version 1.2.3!


ENOTFOUND when running as Docker container

After initializing the docker container, the following error occurs:
user@server:~$ docker logs yakjs
(node:1) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.
[2017-07-21 05:59:05.920] [INFO] HttpServer.console - .........................................................................
[2017-07-21 05:59:05.920] [INFO] HttpServer.console - YAKjs server initialized and running on http port 8790
[2017-07-21 05:59:05.920] [INFO] HttpServer.console - .........................................................................
[2017-07-21 05:59:05.921] [INFO] HttpServer.console -
[2017-07-21 05:59:05.921] [INFO] HttpServer.console - See ./log/yakjs.log for errors and warnings.
[2017-07-21 05:59:05.921] [INFO] HttpServer.console - Use --debug to display all log messages in the console.
[2017-07-21 05:59:05.921] [INFO] HttpServer.console -
[2017-07-21 05:59:05.921] [INFO] HttpServer.console - Press CTRL + C to stop YAKjs.
[2017-07-21 05:59:30.943] [ERROR] HttpServer.console - xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
[2017-07-21 05:59:30.943] [ERROR] HttpServer.console - Could not start YAKjs server on http port8790
[2017-07-21 05:59:30.943] [ERROR] HttpServer.console - xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
[2017-07-21 05:59:30.943] [ERROR] HttpServer.console -
[2017-07-21 05:59:30.943] [ERROR] HttpServer.console - Error: Unexpected error ENOTFOUND
[2017-07-21 05:59:30.944] [ERROR] HttpServer.console -
[2017-07-21 05:59:30.944] [ERROR] HttpServer.console - See ./log/yakjs.log for more technical details.

The port is available and assigned to the container.
Checking logs:
...@...:~# more ./log/yakjs.log
./log/yakjs.log: No such file or directory

Hello TekSiDot!
Thank you for your problem report.
Currently I am working on YAKjs 3.0 that shall be released in august.
So it will take some time for me to take a look at this docker issue.
As an alternative try to use YAKjs with npm install or an "old-school" download ;-)
Hello @dasMulli maybe you can have a look at this docker issue in the meantime?
BR
Christian

Hey there,
looking forward to seeing YAKjs 3.0 go live! The app is supposed to run on a docker-machine only server, so I'll have to wait for either a fix or 3.0.
LG
Jens

The issue is that it tries to listen on [::1] which isn't available when the docker daemon runs without IPv6 support (default AFAIK). (culprit: https://github.com/cschuller/yakjs/blob/f995f813d780e45ad25473920ccfe7bf94bf9395/server/src/expressServer.js#L59)

(d) is probably the best quick fix.
In the future it may be good to have options to configure the IP/Port for the API interface. probably also through an ENV var which is commonly used in Dockerfiles. Restricting to loopback interfaces is unnecessary for docker containers anyway - listening on all interfaces would be the best option. The question is how to configure it.

@TekSiDoT
YAKjs 3.0.3 is released.
Docker is now supported and working fine with YAKjs.
The docker documentation was updated at
https://github.com/cschuller/yakjs/tree/master/docker
Please create a new yakjs docker image and container to get it up and running.
Feedback and issue reports are highly welcome.
Grüße in das Weiß-Blaue Land ;-)

Works like a charm, thank you for your efforts and quick fix!
... Danke und Grüße in die Alpenrepublik ;)

fyi there is an automated build on docker hub that is based on my fork: https://hub.docker.com/r/dasmulli/yak-js/


feat: resource auto-detection

Which problem is this PR solving?

This an effort towards solving #841 (resource auto-detection)

Short description of the changes
The PR ports the existing resource auto-detection logic from OpenCensus. Some of the code has been reorganized and it uses the OpenTelemtetry semantic conventions. For the most part, resource auto-detection is unspecified for OTel, so I've kept to the Census approach for the initial port.
The biggest change from the Census implementation is that I reorganized the detection logic for each Resource type into its own "detector" class. With the goal of making it easier to add detectors in the future.
For reference, here are links to the Census code this is based on:

https://github.com/census-instrumentation/opencensus-node/blob/master/packages/opencensus-resource-util/src/resource-utils.ts
https://github.com/census-instrumentation/opencensus-node/blob/master/packages/opencensus-resource-util/src/detect-resource.ts
https://github.com/census-instrumentation/opencensus-node/blob/master/packages/opencensus-resource-util/test/test-detect-resource.ts

Because there is potential latency involved in auto-detection, users need to manually call the detectResources method during setup, making this functionality opt-in. For example:
import { detectResources } from '@opentelemetry/resources'

const provider = new NodeTracerProvider({ resource: detectResources() });

Codecov Report

Merging #899 into master will increase coverage by 1.76%.
The diff coverage is 96.06%.

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
+ Coverage   94.00%   95.76%   +1.76%
==========================================
  Files         247      120     -127
  Lines       10717     3404    -7313
  Branches     1040      258     -782
==========================================
- Hits        10074     3260    -6814
+ Misses        643      144     -499

Impacted Files
Coverage Δ

...rces/src/platform/node/detectors/AwsEc2Detector.ts
84.37% <84.37%> (ø)

...sources/src/platform/node/detectors/EnvDetector.ts
88.37% <88.37%> (ø)

...sources/src/platform/node/detectors/GcpDetector.ts
95.12% <95.12%> (ø)

packages/opentelemetry-resources/src/Resource.ts
100.00% <100.00%> (ø)

...ages/opentelemetry-resources/src/platform/index.ts
100.00% <100.00%> (ø)

...ry-resources/src/platform/node/detect-resources.ts
100.00% <100.00%> (ø)

...try-resources/src/platform/node/detectors/index.ts
100.00% <100.00%> (ø)

...opentelemetry-resources/src/platform/node/index.ts
100.00% <100.00%> (ø)

...ages/opentelemetry-resources/test/Resource.test.ts
100.00% <100.00%> (ø)

...ntelemetry-resources/test/detect-resources.test.ts
100.00% <100.00%> (ø)

... and 198 more

I think this is good to go, please resolve the merge conflicts.


CNV-23983: Create a modal form to add a boot volume

Signed-off-by: Aviv Turgeman<EMAIL_ADDRESS>📝 Description
A modal to create a DataVolume (with upload file or cloning an existing PVC) that adds the preferences and instanceType to a PVC as labels
🎥 Demo
https://user-images.githubusercontent.com/67270715/211275270-bd7bc47f-8794-4077-acc5-33810b39a569.mp4
To-Do

[ ] Verify backend delegated instance type and preference labels from DataVolume to PVC
[ ] Verify with backend if resources created as demo shows are correct

very nice! GJ! left a small comment about 2 functions in the util file

/lgtm


 This is not the kind of debugging I think I signed up for.

ok

Fixed


Devs SNBAT reference og infrastructure

Expected Behavior
We should wholly remove "og", now that we have no actual infrastructure referencing it
Current Behavior
We had some legacy setup with hard codede validator/tx node identities that we still kinda support, but mostly not really.

@tkporter does your latest PR mean we can close this?


The function Get-PendingReboot updated to version from 27/07/2015

The resolution for the issue #126

Thanks a bunch for this PR! Left one comment above but other than that it looks good.

Thanks. Sorry I never caught the fact that you added the commit to return the boolean but this will go into the next release hopefully due tonight or tomorrow morning.


samsung UE40F6400 volume control

hi everyone, how do i turn on volume control. thank you

Volume is implemented but doesn't show up at the moment. It however shows up in the homebridge accessories tab for me. I still have to figure out why iOS isn't showing the speaker service.

hi, I also see it as accessories in Homebridge but not on ios. thank you

I have the theory that iOS requires some other characteristics like CurrentMediaState before it will show the volume characteristics. Unfortunately I didn't find any more documentation concerning this topic in the hombridge docs or apples homekit documentation yet.

I just figured out that I can control the volume with the iPhone hardware buttons when in control center -> remote -> tv selected on top... I still don't know how to toggle mute in the remote app however. The source for this info also says that the home app just doesn't show the tv speaker accessory like other apps do. I might add an option to add a "lightbulb" accessory or so to be able to control the volume/mute directly in the home app like other plugins do.

the native accessory of apple tv 4 has volume control ... maybe you can investigate on that side ...
Gastón

El 29 jul. 2020, a la(s) 05:20, Martin Mende<EMAIL_ADDRESS>escribió:

I just figured out that I can control the volume with the iPhone hardware buttons when in control center -> remote -> tv selected on top... I still don't know how to toggle mute in the remote app however. The source for this info also says that the home app just doesn't show the tv speaker accessory like other apps do. I might add an option to add a "lightbulb" accessory or so to be able to control the volume/mute directly in the home app like other plugins do.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Maybe it will help
https://developer.apple.com/documentation/mediaplayer/mpvolumeview
Gastón

El 29 jul. 2020, a la(s) 05:32, Gastón Groel<EMAIL_ADDRESS>escribió:
the native accessory of apple tv 4 has volume control ... maybe you can investigate on that side ...
Gastón

El 29 jul. 2020, a la(s) 05:20, Martin Mende<EMAIL_ADDRESS>escribió:

I just figured out that I can control the volume with the iPhone hardware buttons when in control center -> remote -> tv selected on top... I still don't know how to toggle mute in the remote app however. The source for this info also says that the home app just doesn't show the tv speaker accessory like other apps do. I might add an option to add a "lightbulb" accessory or so to be able to control the volume/mute directly in the home app like other plugins do.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

in node-red Linked service "TelevisionSpeaker" e Characteristic :
{
"VolumeControlType":1,
"VolumeSelector":true
}
so I see it in the control center with output {"RemoteKey":4} UP; {"RemoteKey":5} DOWN; {"RemoteKey":7}DX; {"RemoteKey":6} SX
IF YOU CAN USE IT

now works!!!

Nice... A more fine grained volume control is not accessible in iOS yet unfortunately. However it is implemented theoretically in this plugin. I hope iOS 14 will bring volume controls for tv's.


Crashes when trying to parse a feed URL offline

For some reason, when trying to parse a URL in offline mode with FeedKit, the app crashes. If there's an Internet connection it works as expected.

I can't help but wonder if this is an error in the Foundation's XMLParser. I was able to replicate the crash, and it happens when calling
Parser(contentsOf: URL)
The 'Parser' class is actually a subclass of the foundation's XMLParser, and this is nothing but a call to a convenience initializer of the XMLParser itself.
Documentation says that it should return:

An initialized NSXMLParser object or nil if an error occurs.

And there is a check for that that propagates the failable initializer:
    public init?(URL: URL) {
        guard let parser = Parser(contentsOf: URL) else {
            return nil
        }
        self.parser = parser
    }

I'll have to dig deeper..

I tried to call directly XMLParser(contentsOf: URL) and it didn't crash. So it's something in the library, not XMLParser.

Just tried to isolate the issue:
Apparently this works:
let feedURL = URL(string: "http://images.apple.com/main/rss/hotnews/hotnews.rss")!

if let parser = XMLParser(contentsOf: feedURL) {
        print("Got instance \(parser)")
}

This does not:
class Parser: XMLParser { }

let feedURL = URL(string: "http://images.apple.com/main/rss/hotnews/hotnews.rss")!

if let parser = Parser(contentsOf: feedURL) {
        print("Got instance \(parser)")
}

Any ideas?

As a temporary solution, i found that you can safely do this:
if let data = NSData(contentsOf: feedURL) as? Data {
FeedParser(data: data).parse({ (result) in
    // do your thing
})

}

Maybe it's related to overriding
override init(data: Data) {
    super.init(data: data)
    self.delegate = self
}

Did you try to remove it to see if it crashes?

Yes, I did.
Take this example for instance:
class Parser: XMLParser { }

let feedURL = URL(string: "http://images.apple.com/main/rss/hotnews/hotnews.rss")!

if let parser = Parser(contentsOf: feedURL) {
    print("Got instance \(parser)")
}

In this example, the Parser class is not actually overriding anything. All it's doing is saying: Hello! I'm a subclass of XMLParser. Nothing else. And it still crashes!
I'll keep digging some more...

Submitted a bug report to Apple with nº 28904764 and opened up a Radar to this issue.
In the meantime I'll cook a workaround, using NSData's contentsOf init and release a fix.

Hi, any updates? Thanks!

I got the same error. I just replaced the link with
feedURL = NSURL(string:"http://images.apple.com/main/rss/hotnews/hotnews.rss#sthash.fuVEonEt.dpuf")!
Error gone...

Hi, any update? thanks

Apple engineers aren't able to reproduce this bug, and I just don't have time to go back and forward in the bug reporter with them.
You can always use the workaround described above.
I'm also working on version 6 of FeedKit, that will bypass this bug. Time however isn't much so it's taking awhile.


API for adding a resize box on canvas

Similar to #158 but for the resize overlay.
Should include API to enable resize box at bounds, callback when updated and remove. You should also be able to lock the aspect ratio + constrain to bounds on atlas world.

Implement what's been done in the "unwrapped" version of CP


qtwebkit won't compile

Hello everyone,
I got 3 compilation errors on the same line while compiling qtwebkit with Yocto/bitbake
First:
/workdir/build/tmp/work/corei7-64-oe-linux/qtwebkit/5.15.2+gitAUTOINC+10cd6a106e-r0/git/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h:60:16: note: in expansion of macro 'WTFMove'
   60 |         return WTFMove(property);
      |                ^~~~~~~
{standard input}: Assembler messages:
{standard input}:2235000: Warning: end of file not at end of a line; newline inserted
{standard input}:2235391: Error: number of operands mismatch for `mov'
{standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive
x86_64-oe-linux-g++: fatal error: Killed signal terminated program cc1plus

Second:
/workdir/build/tmp/work/corei7-64-oe-linux/qtwebkit/5.15.2+gitAUTOINC+10cd6a106e-r0/git/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h:60:16: note: in expansion of macro 'WTFMove'
   60 |         return WTFMove(property);
      |                ^~~~~~~
{standard input}: Assembler messages:
{standard input}:482020: Warning: end of file not at end of a line; newline inserted
{standard input}:482878: Error: unknown pseudo-op: `.lbb543'
{standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive
x86_64-oe-linux-g++: fatal error: Killed signal terminated program cc1plus
compilation terminated.

Third:
/workdir/build/tmp/work/corei7-64-oe-linux/qtwebkit/5.15.2+gitAUTOINC+10cd6a106e-r0/git/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h:60:16: note: in expansion of macro 'WTFMove'
   60 |         return WTFMove(property);
      |                ^~~~~~~
{standard input}: Assembler messages:
{standard input}:15702: Warning: end of file not at end of a line; newline inserted
{standard input}:16931: Error: no such instruction: `_zn7webcore20cachedhtmlcollectionins_21htmlopt'
x86_64-oe-linux-g++: fatal error: Killed signal terminated program cc1plus
compilation terminated.

The full logs (2) are 50k lines, I can't paste them here.
Everything was compiling with DEPENDS += " qtbase qtscript qtsvg qttools", but then I added qtwebkit, now it's failing.
I tried to change the SRCREV to the next commit e16357a52fece93e48d5657cfa8b137e8932c0bb but the patches won't apply.
Yocto/poky version is gatesgarth-24.0.0 (I did not forget to switch meta-qt5 to gategarth branch)
The target MACHINE is intel-corei7-64 (meta-intel)
GCC version is 10.%
Anything I could have done wrong ?
I don't know what information I should give to let you help me.
PS: I am trying to compile on gatesgarth-24.0.2, but it will take a few hours as I need to recompile everything.
UPDATE 2021/03/04:
I still have errors with gatesgarth-24.0.2. I got new errors:
/workdir/build/tmp/work/corei7-64-oe-linux/qtwebkit/5.15.2+gitAUTOINC+10cd6a106e-r0/git/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h:60:16: note: in expansion of macro 'WTFMove'
   60 |         return WTFMove(property);
      |                ^~~~~~~
{standard input}: Assembler messages:
{standard input}:467848: Warning: end of file not at end of a line; newline inserted
{standard input}:468087: Error: unknown pseudo-op: `.l'
{standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive
x86_64-oe-linux-g++: fatal error: Killed signal terminated program cc1plus

/workdir/build/tmp/work/corei7-64-oe-linux/qtwebkit/5.15.2+gitAUTOINC+10cd6a106e-r0/git/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h:60:16: note: in expansion of macro 'WTFMove'
   60 |         return WTFMove(property);
      |                ^~~~~~~
{standard input}: Assembler messages:
{standard input}:655627: Warning: end of file not at end of a line; newline inserted
{standard input}:656137: Error: expected comma after name `_ZN7WebCore35RenderMediaControlTimeli' in .size directive
x86_64-oe-linux-g++: fatal error: Killed signal terminated program cc1plus

It seems that there are new errors every time I try to compile...

Ok I think I need to create another comment for this.
I found a solution to solve this: run bitbake qtwebkit directly, then run bitbake my-recipe again.
I guess there is something wrong with my recipe. So I try:
# Clean the sstate of qtwebkit
bitbake qtwebkit -c cleansstate
# Then reproduce the bug
bitbake my-recipe # error, that's expected
# Then I commented some lines of my recipe, then
bitbake my-recipe # error
# Then I commented other lines of my recipe
bitbake my-recipe # works.

Fair enough. I try again.
# I clean the sstate again
bitbake qtwebkit -c cleansstate
# Reproduce the bug
bitbake my-recipe # error, that's expected
# Then I thought, let's try multiple times without commenting lines
bitbake my-recipe # error
bitbake my-recipe # works... What ?

Running bitbake my-recipe multiple times solved this ?
That makes 2 workarounds for this issue:

Run bitbake qtwebkit then run bitbake my-recipe
Run bitbake my-recipe multiple times

I started learning Yocto less than 2 months ago, so my knowledge is quite poor.
I don't know if the bug comes from meta-qt5, but it happened only there since then.
I don't know how to fix this bug, but if I can help you fix it in any way, please let me know.


DYN-5227-NotificationCenter-Font

Importing ArtifaktElement from @hig/fonts

FYI:
@avidit @QilongTang

@RobertGlobant20 @zeusongit @jesusalvino Could you also take a look, please? Thanks!


Added attachments to releases API

See #2084 for details. This is exactly the same PR, just on top of master.
Needs https://github.com/go-gitea/go-sdk/pull/83 to work.

CI failed

Yes, but i don't understand why... I've already run go fmt and the result was the last commit added https://github.com/go-gitea/gitea/pull/3075/commits/c788b3d95a03f4739725ea2f40a3cc3ae98fb1c3

Quick question: I see you are declaring some swagger definitions as code comments. Is there any documentation on the syntax? Should I do it as well?

@stefan-lacatus Yes, please do. Here are the relevant docs; let me know if you have any questions.

Swagger definitions are also included.
I think we should decide if we keep the endpoint which gets a single asset of a single repository. See the discussion on https://github.com/go-gitea/go-sdk/pull/83#discussion_r154686532

This feature got implemented in #3478 in the meantime. So I think that this PR should be closed.

Closed by #3478


ct_os_get_pod_ip could wait

... until the IP is available?

We are waiting for IP by OpenShift 4 tests. See ct_os_wait_pod_ready. This issue is not valid anymore.


Update README

@krallin - Some suggestions for the README, feel free to reject any/all. I think this is a really strong README, very well-written, and I don't have much to add. Great job!

Thanks! Made a couple markdown style fixes on top of your changes - you can see the diff here: https://github.com/chasballew/supercronic/compare/3b69cb8...fc6d894


Dockerfile for a tooling environment

make amis, etc works from the container.
terraform isn't necessary for he make tasks, but could come in handy if you want to expand your usage of this environment.

I like the idea but I'm not sure this belongs in this repository. There's nothing that is stack-specific in this dockerfile, it's more of a general-purpose container for working with packer and terraform.
Do you think it would be better on its own repository and we can show a link in the stack README?

Sorry for the late reply.
This is in fact specific to stack, its the only project I would use it on.

designed to support python
fills the Linux gap in the Makefile
runs make install at setup

So you might consider if you want your open-source project to support Linux out-of-the box or if you think its fine for people to deal with issues of having the wrong version of Python, etc.
You can certainly point to my fork of stack. That will save you a file in the directory but cost you a line in your README.

Fair, I'm happy to merge, just was thinking that any project that uses TF/Packer could benefit from having this container, not just stack-based stuff.

Its a good thought. In practice I find that containers (actually their images) compose very poorly at least at the level of building off of Dockerfiles. Even if you don't need to compose new things its often really hard to make them general enough for everyone also.


Align with packit#1357 code

Syncing of default files can now be disabled
Fixes packit/packit#1357
Merge after packit/packit#1483

I see occurrences of synced_files in
tests/unit/test_steve.py
tests/unit/test_config.py
tests/unit/test_events.py
tests/integration/test_pr_comment.py
tests/integration/test_koji_build.py
tests/integration/test_bodhi_update.py
tests/integration/test_dg_commit.py
tests/integration/test_check_rerun.py
tests/integration/test_issue_comment.py
tests/integration/test_release_event.py

Should those be updated, too?

This are occurrences of synced_files inside spec files which are yet allowed even if deprecated. I have not modified all those occurrences in tests neither here or in packit code. But if you think it should be done I can do it.

This are occurrences of synced_files inside spec files which are yet allowed even if deprecated. I have not modified all those occurrences in tests neither here or in packit code. But if you think it should be done I can do it.

I see. No there is no need for it for now. Thank you for the explanation!

recheck


Trying to run the examples gives error: "LinkError: WebAssembly.instantiate(): Import #0 module="env" function="Math.log""

Trying to build and load the examples with a recent version of Chrome and Safari on macOS Monterey arm64 gives the following error in console.log:
LinkError: WebAssembly.instantiate(): Import #0 module="env" function="Math.log" error: function import requires a callable

Seems the examples are not yet updated to v0.20 of the compiler but still require v0.19. Makes sense to update them :)

Well, it definitely makes as one cannot run the examples right now without having to figure out how they should work .. :) :P

I use in v0.20, but I don't know how to set it globally
env: {
       'Math.random': Math.random
      }

Should be fixed now


The vMax seem do not work with number of japanese

Hello BobKnothe ,
The vMax seem do not work with number of japanese.

I am not sure I understand.
Is it possible to post an example?

I am closing this issue hoping that you have found a solution.
If you need to re-open please post a fiddle so I can see the issue first hand.


Where to find failed-to-scan logs

Well written, thanks
Can you please also add where the logs go for this when things fail? Mine suddenly started to fail, the storage account is open to all networks (!) and it doesn't seem to be showing any blocked logs or authentication issues.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 02495b5c-f888-b3fc-82e0-37350af6ae81
Version Independent ID: ff0899fe-800e-328a-1690-f0d911331837
Content: SQL Vulnerability Assessment - Azure SQL Database & SQL Managed Instance & Azure Synapse Analytics
Content Source: articles/azure-sql/database/sql-vulnerability-assessment.md
Service: sql-db-mi
Sub-service: security
GitHub Login: @mibar
Microsoft Alias: mibar

@sarah026 Thank you for the feedback.
This is being assigned to the content author to evaluate and update the documentation as appropriate.

@mcrlc @amih90

#assign:mibar

mibar is not a valid GitHub ID, or is not a collaborator on this repo.

#assign:barmichal

Hello @sarah026,
Thank you for raising this feedback!
In case you have an issue with one of your scan, you can check your scan history in your Azure SQL vulnerability assessment page.
Best,
D.

#please-close


Bug: nuxt-rc-3 new page not added to the router automatically when it was created

Environment
Nuxt CLI v3.0.0-rc.3                                                                                21:17:50
RootDir: D:\workspace\amazon                                                                         21:17:51
Nuxt project info:                                                                                21:17:51

Operating System: Windows_NT
Node Version:     v16.13.2
Nuxt Version:     0.0.0
Package Manager:  unknown
Builder:          webpack
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
Just adding a new route to pages
and then new page isn't showing
Describe the bug
When i add a new page to the pages dir it should be add new route. But it isn't working as excepted.
To work as excepted, I have to stop the dev server and re-start the web server again. It is pretty bad for me.
And nuxt dev server is pretty slow it takes 30s for me that is bad
Additional context
This project
https://github.com/amm834/amazon-clone/tree/main/admin
Logs
Failed to load resource: the server responded with a status of 404 (Page not found: /category)

any updates?

This issue is already resolved. You should try to update Nuxt to the latest version.

Experiencing this issue on the latest nuxt stable version.
 "nuxt": "^3.10.3",
   "vue": "^3.4.19",
   "vue-router": "^4.3.0"

I have tried with the latest version. It's working well.
https://github.com/amm834/nuxt-layout-transition-animation


Properly group OR expressions

There was a regression in converting some of this code to Arel where OR
expressions were not being grouped properly. So an expression that was
previously expressing:
a AND (b OR c)

would now say:
a AND b OR c

Fortunately, since all the expressions are expressed in Arel now, the
fix can be made using Arel's DSL:
node.or(other_node)

Fixes https://github.com/ManageIQ/manageiq/issues/9427
@miq-bot add-label core, bug
@miq-bot assign @gtanzillo
/cc @jrafanie

Need new merge commit for travis... closing/re-opening

👏

@imtayadeway Can you confirm this bug isn't in darga?

@jrafanie darga yes or no?

I'll say Darga/no, it appears to do the right thing on darga.
exp = MiqExpression.new({"and"=>[{"AFTER"=>{"value"=>"30 Days Ago", "field"=>"MiqRequest-created_on"}}, {"or"=>[{"="=>{"value"=>"pending_approval", "field"=>"MiqRequest-approval_state"}}, {"="=>{"value"=>"approved", "field"=>"MiqRequest-approval_state"}}, {"="=>{"value"=>"denied", "field"=>"MiqRequest-approval_state"}}]}, {"or"=>[{"="=>{"value"=>"MiqProvisionRequest", "field"=>"MiqRequest-resource_type"}}, {"="=>{"value"=>"MiqProvisionConfiguredSystemRequest", "field"=>"MiqRequest-resource_type"}}, {"="=>{"value"=>"VmReconfigureRequest", "field"=>"MiqRequest-resource_type"}}, {"="=>{"value"=>"VmMigrateRequest", "field"=>"MiqRequest-resource_type"}}, {"="=>{"value"=>"ServiceTemplateProvisionRequest", "field"=>"MiqRequest-resource_type"}}, {"="=>{"value"=>"ServiceReconfigureRequest", "field"=>"MiqRequest-resource_type"}}]}]})

exp.to_sql
==>
["(miq_requests.created_on > '2016-05-25T23:59:59Z' AND (\"miq_requests\".\"approval_state\" = 'pending_approval' OR \"miq_requests\".\"approval_state\" = 'approved' OR \"miq_requests\".\"approval_state\" = 'denied'))", {}, {:supported_by_sql=>false}]

@jrafanie thanks for checking that ahead of me! :heart:


Docs - Remove Tabindex section

Here's a fresh PR to remove the tabindex section from the docs. Original PR here #6840

@joe-watkins Thanks for the PR! We want to invite you to the Foundation 6 private release. Email rafi at zurb .com and we'll get you in!


Add mastercard 2221-2720 range

On November 3, 2014, MasterCard announced that they were introducing a
new series of BIN ranges that begin with a “2” (222100–272099). They
will become active 14 October 2016.
https://en.wikipedia.org/wiki/Bank_card_number

For some reason it looks like the CI missed this. Mind amending your commit and force pushing?

This LGTM, and the CI is happy. If these don't become active for another 6 months, is there any rush to actually get this released right away?

No, there is no rush to get this released.
--
Thomas GUILLORY
<IP_ADDRESS>.66
On Mon, Apr 11, 2016 at 3:16 PM, Colin Ihrig<EMAIL_ADDRESS>wrote:

This LGTM, and the CI is happy. If these don't become active for another 6
months, is there any rush to actually get this released right away?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/continuationlabs/credit-card/pull/25#issuecomment-208335284

Hey guys, any idea when this is going to be merged ?

I'll land this in early September.

We could bundle this in a major bump... that way those who want it now can do so? Just a thought.

For people that are using this library in a hybrid mobile app would be really good to have this as soon as possible as they need time for customers to update their apps.
I don't think that 1 month will be enough to get a good part of the customers updated, so some people will not be able to order, in case of an e-commerce.

OK, I'll deal with this today.

Thanks @cjihrig

Thanks for the PR @thomasguillory. This is now published in<EMAIL_ADDRESS>

Thanks @thomasguillory for the PR and @cjihrig for the release.

👍


Improve TFX Addons README, creates tfx_addons.{module} root imports and fix xgboost penguin example

This is quite large change, but mostly it just includes a refactor TFX Addons README. Due to that, I had to restructure some parts of CI. Also I'm adding an easier way to import modules by doing import tfx_addons as tfxa similar to how tf-addons and tfx style does it. This should also give us more control over how to expose modules in tfxaddons while still develop in the repo.
Finally in the process of testing this realized xgboost evaluator was broken so fixed it and added it to the xgboost_penguin test.
I can break this change into smaller pieces as well.

/merge


Vulkan: OmniLight3D nodes render improperly after reaching greater than 44 shadow-enabled sources in a scene

Godot version
4.0.alpha14
System information
Windows 10, Vulkan Clustered, RTX 2060 (516.94)
Issue description
If there are greater than 44 (?) OmniLights with shadows enabled in a 3D scene, some will begin to attenuate improperly. It also appears to be partly influenced by the range of the light source, and the camera position, with more lights acting strangely as their range is decreased.
Lights will render properly until turning shadows on. Once turned on, the visual bug will appear on some lights ~and will not disappear even if shadows are then turned off, until the scene has been reloaded~. Edit: Appears to be unrelated to this issue in specific, mentioned in #50343.

Here's a video as well: https://www.youtube.com/watch?v=vL94p9ZuduA
I'm unsure if this is the result of a built-in engine limit, just thought it was a bit too unusual to be intentional.
Steps to reproduce

Create a new project
Add some geometry to be able to see the lights (in the attached project a simple plane mesh was used)
Begin adding OmniLight3D nodes to the scene (at least 45)
Enable shadows on all lights
Observe some lights failing to attenuate properly

Minimal reproduction project
lighting-bug.zip

Can you reproduce this after adjusting the shadow quadrant values in the project settings? Instead of the default 4/4/16/64 split, try something like 16/16/16/64.

Yeah, that definitely helps in regards to the number of light sources that render properly. At 16/16/16/256 for example, I can get up to 152 shadow-enabled lights before new ones start to break (ignoring the performance implications of course...)


[WIP] Support double sparsity

Motivation

Support double sparsity (post-training sparse attention) for long context inference in SGLang
See paper

Modifications

Add triton implementation in sglang/python/sglang/srt/layers/sparse_decode_attention.py
Add serving-related parts

Checklist

[ ] Format your code according to the Contributor Guide.
[ ] Add unit tests as outlined in the Contributor Guide.
[ ] Update documentation as needed, including docstrings or example tutorials.

Nice work! Is there a performance evaluation?

Great work. Some tips for rebasing:

Recently, we did some refactoring to introduce AttentionBackend. This will make the code of supporting multiple attention backend cleaner  https://github.com/sgl-project/sglang/pull/1381
Follow the above refactor, you can use cuda graph and torch.compile to make it run up to 4x faster (https://github.com/sgl-project/sglang/pull/1401, https://github.com/sgl-project/sglang/pull/1422)

Quick question @andy-yang-1 - Does this PR support just Double Sparsity or DS-Offload as well?

@vnkc1 Hi, this PR doesn't support DS-Offload for now. DS-Offload may be integrated in other PR if needed.

Is there a plan to merge this PR?

Yes. It should be merged within one week.
@andy-yang-1 please resolve the conflicts.

Yes. It should be merged within one week.
@andy-yang-1 please

Resolve the conflicts.
Add a end-to-end accuracy unit test

Please fix the lint error and add an end-to-end accuracy test

Give two example commands and past their results in the description of this PR. This is for tracking the progress.
# baseline
python3 -m sglang.bench_latency --model meta-llama/Meta-Llama-3.1-8B-Instruct --batch-size 1 --input 1024 --output 8

# double sparsity
python3 -m sglang.bench_latency --model meta-llama/Meta-Llama-3.1-8B-Instruct --batch-size 1 --input 1024 --output 8 --enable-double-sparsity ...

@andy-yang-1 Can you also paste the latency results?

@andy-yang-1 Thanks for the contribution. It is merged.

How does one generate the ds-channel-config to be able to use this?

@max99x You can use this link to generate channel config file.
@fengyang95 We may support it in the next PR

hi @andy-yang-1 Does this support the deepseek-v2 architecture? How can I obtain the config for this structure? I see that the example here https://github.com/andy-yang-1/DoubleSparse/blob/main/evaluation/group_channel_config.py uses llama&mixtral.

@fengyang95 I haven't added support for deepseek-v2 model. I may add support for this later

@fengyang95 I haven't added support for deepseek-v2 model. I may add support for this later

@andy-yang-1 Thank you very much! Looking forward to support for deepseek-v2 and cuda graph.

@andy-yang-1 - Loved the paper! I was trying this out and I am facing a few issues generating the config file using the mentioned script.

The line cos, sin = m.rotary_emb(v, seq_len=kv_seq_len) in stat_qk_max_hook of get_calib_qk_feat gives an error

TypeError: LlamaRotaryEmbedding got an unexpected keyword argument 'seq_len'

I replaced it with cos, sin = m.rotary_emb(v, position_ids=position_ids) which works. I'm not sure if that is correct but LlamaRotaryEmbedding indeed doesn't have the seq_len param

In the config file that gets generated, I only get keys of the form model.layers.{layer_num}.self_attn but the config file present in the test folder has keys in the form of model.layers.{layer_num}.self_attn.q_proj, model.layers.{layer_num}.self_attn.k_proj and model.layers.{layer_num}.self_attn.qk_proj. How were these generated?
On using my generated config with sglang, I am getting error of the type - Key model.layers.0.self_attn.k_proj was not found.

Any help on how to run this would be appreciated.

@shreyansh26 The first problem is caused by older version of transformers, and I will update the base repo to fix it this week.
The q_outlier_config/k_outlier_config is generated with get_calib_feat function, and the qk_outlier_config is generated with get_qk_calib_feat function. You can merge this two config together to get all configs. I will also update it this week.

Thank you.
There may be another discrepancy, in get_calib_feat, with the following condition, k_proj gets filtered out because of GQA.
if y.shape[-1] != model.config.hidden_size:
    return

But your Llama-3.1-8B-Instruct config file, k_proj keys are also present.

@shreyansh26 Hi, I have updated the main repo. Can you try with this code?

Thank you @andy-yang-1!! This is working perfectly now.


After called the change function, item of direction.route[0].legs, are not updating

calling a function by ng-change in a waypoint input field :
<input  type="text"  " ng-change="select_waypoints($index);"
controller :
$scope.select_waypoints = function(input_indext) {
console.log($scope.map)
console.log($scope.map.directionsRenderers[0])
console.log($scope.map.directionsRenderers[0].directions)
}
console of $scope.map is  :

console of $scope.map.directionsRenderers[0] is :

and console of  $scope.map.directionsRenderers[0].directions :

Not able to get new item of legs object or the value of the input field in $scope.map.directionsRenderers[0].directions object. while the $scope.map and $scope.map.directionsRenderers[0] showing new item as well

Is there any other way to find the distance between 2 points and if way-points are there, then individual distances between multiple way-points?


[ISSUE #3521] task6 add integration test for shared thread pool

Fixes #3521

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #3575 (2e0eb87) into master (bc67e69) will decrease coverage by 0.34%.
The diff coverage is 50.00%.

:exclamation: Current head 2e0eb87 differs from pull request most recent head 53f7120. Consider uploading reports for the commit 53f7120 to get more accurate results

@@             Coverage Diff              @@
##             master    #3575      +/-   ##
============================================
- Coverage     62.51%   62.16%   -0.35%
+ Complexity     5562     5536      -26
============================================
  Files           848      848
  Lines         23465    23468       +3
  Branches       2132     2132
============================================
- Hits          14669    14589      -80
- Misses         7441     7522      +81
- Partials       1355     1357       +2

Impacted Files
Coverage Δ

...e/shenyu/plugin/grpc/client/GrpcClientBuilder.java
66.66% <ø> (ø)

...e/shenyu/plugin/motan/proxy/MotanProxyService.java
1.85% <0.00%> (-0.04%)
:arrow_down:

...enyu/plugin/sofa/cache/ApplicationConfigCache.java
25.45% <0.00%> (-0.24%)
:arrow_down:

...starter/plugin/motan/MotanPluginConfiguration.java
100.00% <100.00%> (ø)

...plugin/logging/rocketmq/LoggingRocketMQPlugin.java
22.72% <0.00%> (-72.73%)
:arrow_down:

...ogging/rocketmq/body/LoggingServerHttpRequest.java
0.00% <0.00%> (-20.00%)
:arrow_down:

...he/shenyu/common/timer/HierarchicalWheelTimer.java
68.00% <0.00%> (-18.00%)
:arrow_down:

...va/org/apache/shenyu/common/timer/TimingWheel.java
73.80% <0.00%> (-16.67%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
51.06% <0.00%> (-11.71%)
:arrow_down:

...henyu/admin/service/impl/UpstreamCheckService.java
56.94% <0.00%> (-9.73%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc67e69...53f7120. Read the comment docs.


Exam, programming exercise, "Nachteilsausgleich": after deadline of the exam (without extension) pushing from the local repo not possible

Describe the bug

A student with a "Nachteilsausgleich" (more time for the exam) is not able to work on a programming task from the cloned repository after the normal  exam submission deadline is reached.
Right now the student would have to switch to the online editor, committing something to the remote repository from there is possible until the adjusted working time runs out.
To Reproduce

Create an exam with a programming exercise
give the student that you're using a Nachteilsausgleich (more time)
Clone the repository and work with your IDE
Wait until the normal exam deadline is reached (without of the extension)
Change something in the online editor and submit it -> works
Try to push from the local repository -> does not work

Expected behaviour

The student with a Nachteilsausgleich should be able to work with the local IDE until the end of the adjusted time for the exam.
Screenshots

Thanks for finding this issue. I assume this has happened, because the schedule for the programming exercise was set, before the student exam working time was changed.
So when the student working time changes, we should reschedule the task to lock the repository for the specific student

When did you actually set the individual working time?

I just found out together with @MaisiKoleni that the lock operation is planned at the unlock time, which is the visible. So if you change the working time of one student due to "Nachteilsausgleich" after the visible date of the exam, this will not change the time of the planned lock operation.
Can you please double check when you have actually set the individual working time?

This was working successfully for the first exam on Artemis, so I'll close this PR. Please notice that there might be rare edge cases where the automatic lock and unlock might not work, therefore @sleiss added buttons to manually trigger this as well in #1812


New version: LibSSH2_jll v1.10.2+0

Autogenerated JLL package registration

Registering JLL package LibSSH2_jll.jl
Repository: https://github.com/JuliaBinaryWrappers/LibSSH2_jll.jl
Version: v1.10.2+0
Commit: f9b75805ddd003961ee43cb342047b27281669df
Revision on Yggdrasil: https://github.com/JuliaPackaging/Yggdrasil/commit/24e331a74a9efdae8d341c65e9b1e6891bb8f819
Created by: @jeremiahpslewis

@giordano this is a registry issue / race condition, right?


Feat: spoonacular addition

I signed up for an account, received the API Key, and set up the main function we will be calling: SearchByIngredients

This method is no longer supported y webpack -- we will need to use fetch api!


Perform Data Assimilation with model

Detailed Description
One of the most compute intensive steps in NWPs is doing the data assimilation to create the starting conditions for running the simulation. This type of model could theoretically speed that up if it can integrate lots of observations and essentially interpolate them to the regular grid for NWP initialization.
Context

Possible Implementation
NOAA makes the raw observations public as well as the analysis files which are what the NWP's are started from.

Sounds good!
I'm really out of my depth here but I'm dimly aware that this is might be quite an active area of research in academia. If you haven't done so already, it might be worth doing a quick literature search on the topic of using ML for data assimilation. My understanding is that this is currently unsolved, although, like I say, I'm really out of my depth!

Although I think the reason it's largely unsolved is perhaps because NWPs absolutely require the output of data assimilation to be physically coherent (e.g. strictly observe conservation of energy and water over time). So it's really hard to use ML for data assimilation if you're feeding the output of the data assimilation into an NWP. But, if you're feeding the output of the data assimilation into another ML model, then maybe it'll work! (Because the "forecasting" ML model doesn't need the input data to be strictly physically coherent).

Sounds good!
I'm really out of my depth here but I'm dimly aware that this might be quite an active area of research in academia. If you haven't done so already, it might be worth doing a quick literature search on the topic of using ML for data assimilation. My understanding is that this is currently unsolved, although I should emphasise that I'm really out of my depth!

Yeah, that will be my plan before I start on it! This issue is fairly low on the priority list, definitely want to get forecasting the next steps of the NWPs going first. And yeah, makes sense that it might not work as assimilation for NWPs, but I am hoping that we could then feed it into the forecasting network and get reasonable forecasts that way much faster than how long it currently takes.

From the ECMWF Conference, there are apparently a lot more issues than generally just taking the observations and doing assimilation, one example here: https://github.com/DL-WG/LatentAssimilation but might need to be more careful or add more physical constraints/etc. Data assimilation also currently apparently doesn't use a lot of the data available, especially from satellite observations, so adding those could be quite useful.


Add Animation_Skin and Animation_SkinType model groups

Animation_Skin https://github.com/stevk/glTF-Asset-Generator/tree/skins/Output/Animation_Skin
Animation_SkinType https://github.com/stevk/glTF-Asset-Generator/tree/skins/Output/Animation_SkinType

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: stevk:x: kcoleyYou have signed the CLA already but the status is still pending? Let us recheck it.

Make models 06 is hard to see.  Talk to Patrick
Make model 7 rotated ~90 degrees vertically
Change the word hole to transform node

change heirarchy to hierarchy
rotate and turn model 6
turn model 7
animate only the bottom on model 7


Could you publish this package to packagist ?

Hello,
Could you add a composer.json  and then publish this package to packagist ?
Thanks

ping @bopoda

Hi @lyrixx,
Could you please have a look at PR before I merge? Do you have any suggestions regarding it?

bopoda/robots-txt-parser is available on packagist now.
@lyrixx, thank you very much! Please write if something else.

Thanks a lot.
It seems releases a missing on packagist. Maybe it's because the tag does not follow the pattern vX.Y.Z. Could you try to release v2.3.0?
(or maybe it does not work because there was no composer.json in the previous releases)

Thanks for the feedback.
I've created tag v2.3.0. Does it fix the issue? I see dev-master and v2.3.0 on packagist


Add new test to register 3D timelapses

This PR contains:

[X] a new test-case for the benchmark

[X] I hereby confirm that NO LLM-based technology (such as github copilot) was used while writing this benchmark

[ ] new dependencies in requirements.txt

[ ] The environment.yml file was updated using the command conda env export > environment.yml

[ ] new generator-functions allowing to sample from other LLMs
[ ] new samples (sample_....jsonl files)
[ ] new benchmarking results (..._results.jsonl files)
[ ] documentation update
[ ] bug fixes

Related github issue (if relevant): closes #0
Short description:

This PR implements a new test case of registration of a 3D timelapse. The catch is that the volumes need to be consistent not only between frames but also as a whole from beginning to end.

How do you think will this influence the benchmark results?
This is a very common procedure, and it should frequently be available online, but it is non-trivial due to the compounding of the frame's movement, so I think it will be a challenging test case.
Why do you think it makes sense to merge this PR?

Adds a new test case that's routinely used when tracking or quantifying information over time in bio-image analysis workflows.

Hey @JoOkuma ,
awesome, that's a very cool use-case! I did a tiny modification of the docstring, to be more clear.
I'm now going to merge these into a dev-branch, where we can collect new test cases. Just explaining: If we merged new test-cases now, we would have to re-run all the benchmarks as the new test-cases haven't been tested with the 18 models we benchmarked so far. I'd say once we have 10 new test cases together, we can do this in one shot limiting effort on the benchmarking side.
If you are interested in becoming co-author on the manuscript, please let us know your full name and affiliation so that we can add you. Also let us know if you have any conflicts of interest that should be reported when submitting the paper.
Thanks again!
Best,
Robert

Thanks for taking my PR @haesleinhuepf .

If you are interested in becoming co-author on the manuscript, please let us know your full name and affiliation so that we can add you. Also let us know if you have any conflicts of interest that should be reported when submitting the paper.

Name: Jordão Bragantini
Affiliation: Chan Zuckerberg Biohub
No conflict of interest.


RHIDP-2647 : chore: updates from privacy-legal team RHIDP-58

What does this PR do?
chore: updates from privacy-legal team RHIDP-58
Signed-off-by: Nick Boldt<EMAIL_ADDRESS>Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:

[x] The Eclipse Contributor Agreement is valid
[x] Code produced is complete
[x] Code builds without errors
[ ] Tests are covering the bugfix
[x] The repository devfile is up to date and works, if one exists
[x] Sections What issues does this PR fix or reference and How to test this PR completed
[x] Relevant user documentation updated
[x] Relevant contributing documentation updated
[x] CI/CD changes implemented, documented and communicated

Reviewers
Reviewers, please comment how you tested the PR when approving it.

/cherry-pick 1.2.x

I've created RHIDP-2647 to process this.

The content changes look fine, @nickboldt. Thanks

From @shipsing : " I think we can proceed with merge because the usual review process is complete and we have notified legal as well in that mail. "
Therefore merging.


fixed ldflags bug

Current coverage is 44.02% (diff: 100%)

Merging #97 into master will decrease coverage by 0.09%

@@             master        #97   diff @@
==========================================
  Files            16         16
  Lines          7051       7051
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           3111       3104     -7
- Misses         3155       3165    +10
+ Partials        785        782     -3

Powered by Codecov. Last update fb26571...fccb4bb


Add [SupportsWildcards()] to all -Path parameters

Also update the docs

@adityapatwardhan can you, please take a look?


fix(aria/ngModel): do not overwrite the default $isEmpty() method for checkboxes

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix(es)
What is the current behavior? (You can also link to an open issue here)
ngAria overwrites NgModelController.$isEmpty() for custom checkboxes (only considering false as empty), despite the fact that custom checkboxes don't necessarily have custom parsers setting falsy values to false. (E.g. the checkbox is considered "checked" even if value is undefined (because undefined !== false.)
Also, ngModel breaks when manually compiling from a terminal directive with lower priorty (see #14621).
Does this PR introduce a breaking change?
Yes !
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
Previously, ngAria would overwrite the default ngModelController.$isEmpty() method for custom
checkbox-shaped controls (e.g. role="checkbox" or role="menuitemcheckbox"), using the same
implementation as input[checkbox] (i.e. value === false). While this makes sense for
input[checkbox] which also defines a custom parser, it doesn't make sense for a custom checkbox
out-of-the-box. For example, an unintialized value (undefined) would make the checkbox appear as
"checked".
If the user wants to provide a custom parser (e.g. setting falsy values to false), then they
should also provide a custom $isEmpty() method.
As a side effect, this commit solves issue #14621. (We could have solved it in different ways.)
Fixes #14621
BREAKING CHANGE:
Custom checkbox-shaped controls (e.g. checkboxes, menuitemcheckboxes), no longer have a custom
$isEmpty() method on their NgModelController that checks for value === false. Unless
overwritten, the default $isEmpty() method will be used, which treats undefined, null, NaN
and '' as "empty".
Note: The $isEmpty() method is used to determine if the checkbox is checked ("not empty" means
"checked") and thus it can indirectly affect other things, such as the control's validity
with respect to the required validator (e.g. "empty" + "required" --> "invalid").
Before:
var template = '<my-checkbox role="checkbox" ng-model="value"></my-checkbox>';
var customCheckbox = $compile(template)(scope);
var ctrl = customCheckbox.controller('ngModel');

scope.$apply('value = false');
console.log(ctrl.$isEmpty());   //--> true

scope.$apply('value = true');
console.log(ctrl.$isEmpty());   //--> false

scope.$apply('value = undefined'/* or null or NaN or '' */);
console.log(ctrl.$isEmpty());   //--> false

After:
var template = '<my-checkbox role="checkbox" ng-model="value"></my-checkbox>';
var customCheckbox = $compile(template)(scope);
var ctrl = customCheckbox.controller('ngModel');

scope.$apply('value = false');
console.log(ctrl.$isEmpty());   //--> false

scope.$apply('value = true');
console.log(ctrl.$isEmpty());   //--> false

scope.$apply('value = undefined'/* or null or NaN or '' */);
console.log(ctrl.$isEmpty());   //--> true

--
If you want to have a custom $isEmpty() method, you need to overwrite the default. For example:
.directive('myCheckbox', function myCheckboxDirective() {
  return {
    require: 'ngModel',
    link: function myCheckboxPostLink(scope, elem, attrs, ngModelCtrl) {
      ngModelCtrl.$isEmpty = function myCheckboxIsEmpty(value) {
        return !value;   // Any falsy value means "empty"

        // Or to restore the previous behavior:
        // return value === false;
      };
    }
  };
})

I wonder if it would make more sense to provide a custom $isEmpty method to checkboxes, that interprets all falsy values as "empty"...

We could imo check emptiness based on the checked property, no? This would change the semantics (as the model value is currently validated), but I think it makes sense, for checkboxes specifically. I mean they are empty when unchecked almost by definition ...

I was referring to custom checkboxes (I think :smiley:), which don't necessarily have a checked property. For input[checkbox] we are already doing the right thing (basing emptiness on the value of the checked property.
But, I am still not sure if it is a good idea to provide a custom $isEmpty function for custom checkboxes. Or at least we should document it properly, because it is happening under the hood and we don't mention it anywhere.

You are right, the real checkbox uses checked. I'm fine with removing the custom isEmpty.

@Narretz, is this a LGTM? :stuck_out_tongue:
(I fixed the test description btw.)

Yes, LGTM :D