compiling dcn fails

I am attempting to set up MMSR on a Windows 10 PC.  I've installed the most recent versions of CUDA from nVidia, Anaconda, and PyTorch.  I try compiling dcn from codes/models/archs/dcn from within the Anaconda Prompt cmd window and the first few lines of output are:

python setup.py develop
running develop
running egg_info
creating deform_conv.egg-info
writing deform_conv.egg-info\PKG-INFO
writing dependency_links to deform_conv.egg-info\dependency_links.txt
writing top-level names to deform_conv.egg-info\top_level.txt
writing manifest file 'deform_conv.egg-info\SOURCES.txt'
reading manifest file 'deform_conv.egg-info\SOURCES.txt'
writing manifest file 'deform_conv.egg-info\SOURCES.txt'
running build_ext
C:\ProgramData\Anaconda3\lib\site-packages\torch\utils\cpp_extension.py:237: UserWarning: Error checking compiler version for cl: [WinError 2] The system cannot find the file specified
warnings.warn('Error checking compiler version for {}: {}'.format(compiler, error))

Then the compile continues:

building 'deform_conv_cuda' extension
creating I:\AI-NN\MMSR\mmsr-master\codes\models\archs\dcn\build
creating I:\AI-NN\MMSR\mmsr-master\codes\models\archs\dcn\build\temp.win-amd64-3.7
creating I:\AI-NN\MMSR\mmsr-master\codes\models\archs\dcn\build\temp.win-amd64-3.7\Release
creating I:\AI-NN\MMSR\mmsr-master\codes\models\archs\dcn\build\temp.win-amd64-3.7\Release\src
Emitting ninja build file I:\AI-NN\MMSR\mmsr-master\codes\models\archs\dcn\build\temp.win-amd64-3.7\Release\build.ninja...
Compiling objects...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
[1/2] cl /showIncludes /nologo /Ox /W3 /GL /DNDEBUG /MD /MD /wd4819 /EHsc -IC:\ProgramData\Anaconda3\lib\site-packages\torch\include -IC:\ProgramData\Anaconda3\lib\site-packages\torch\include\torch\csrc\api\include -IC:\ProgramData\Anaconda3\lib\site-packages\torch\include\TH -IC:\ProgramData\Anaconda3\lib\site-packages\torch\include\THC "-IC:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.2\include" -IC:\ProgramData\Anaconda3\include -IC:\ProgramData\Anaconda3\include "-IC:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\ATLMFC\include" "-IC:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\shared" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\winrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\cppwinrt" -c I:\AI-NN\MMSR\mmsr-master\codes\models\archs\dcn\src\deform_conv_cuda.cpp /FoI:\AI-NN\MMSR\mmsr-master\codes\models\archs\dcn\build\temp.win-amd64-3.7\Release\src/deform_conv_cuda.obj -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=deform_conv_cuda -D_GLIBCXX_USE_CXX11_ABI=0 /std:c++14
FAILED: I:/AI-NN/MMSR/mmsr-master/codes/models/archs/dcn/build/temp.win-amd64-3.7/Release/src/deform_conv_cuda.obj
cl /showIncludes /nologo /Ox /W3 /GL /DNDEBUG /MD /MD /wd4819 /EHsc -IC:\ProgramData\Anaconda3\lib\site-packages\torch\include -IC:\ProgramData\Anaconda3\lib\site-packages\torch\include\torch\csrc\api\include -IC:\ProgramData\Anaconda3\lib\site-packages\torch\include\TH -IC:\ProgramData\Anaconda3\lib\site-packages\torch\include\THC "-IC:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.2\include" -IC:\ProgramData\Anaconda3\include -IC:\ProgramData\Anaconda3\include "-IC:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\ATLMFC\include" "-IC:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\shared" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\winrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\cppwinrt" -c I:\AI-NN\MMSR\mmsr-master\codes\models\archs\dcn\src\deform_conv_cuda.cpp /FoI:\AI-NN\MMSR\mmsr-master\codes\models\archs\dcn\build\temp.win-amd64-3.7\Release\src/deform_conv_cuda.obj -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=deform_conv_cuda -D_GLIBCXX_USE_CXX11_ABI=0 /std:c++14
CreateProcess failed: The system cannot find the file specified.
ninja: fatal: ReadFile: The handle is invalid.
Traceback (most recent call last):
File "C:\ProgramData\Anaconda3\lib\site-packages\torch\utils\cpp_extension.py", line 1400, in _run_ninja_build
check=True)
File "C:\ProgramData\Anaconda3\lib\subprocess.py", line 512, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.

The first message suggests that it is looking for "cl", the command-line C++ compiler from Visual Studio.  So I installed Visual Studio Build Tools 2019, with only "C++ build tools" configured.  I try running setup.py; no change.  Next, I installed Visual Studio Community 2019, with only "Desktop development with C++" selected.  Try the build again, and it still fails in the same place.
Now, building dcn obviously requires a C++ compiler - but which one?  G++?  Visual Studio?  If VS, can it be the most recent version (2019) or must it be a specific version?  Cpp_extension.py seems to be looking for the VS compiler and not finding it - does it need some environment variables set up?
The MMSR README.md says nothing about what compiler it expects to be available.
Could someone describe how they successfully compiled dcn under Windows 10?

Additional info: VS 2019 requires you to run a batch file to set environment variables appropriately before you can do command-line compiles.  Running "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Auxiliary\Build\vcvars32.bat" from within the Anaconda Prompt window (before the "python setup.py develop") fixes the initial "Error checking compiler version" warning.
But the dcn build still fails with many warnings and errors

Hello, @dmmartindale
Did you find the solution?
I think I have the same issue, at least when I run setup.py, it gives me similar errors in the start.
It finishes though and says
Finished generating code
copying build\lib.win-amd64-3.7\deform_conv_cuda.cp37-win_amd64.pyd ->
Creating c:\users\besit\.conda\envs\mmsr\lib\site-packages\deform-conv.egg-link (link to .)
deform-conv 0.0.0 is already the active version in easy-install.pth

Installed z:\projects\neural\mmsr\codes\models\archs\dcn
Processing dependencies for deform-conv==0.0.0
Finished processing dependencies for deform-conv==0.0.0

But after this I can't execute test.py without error Dataloader worker exited unexpectedly

Ok, I've installed the latest version of MSVC which is 14.25.28610 in VS 2019
But I still have a lot of errors appearing

c1xx: fatal error C1356: unable to find mspdbcore.dll
I tried adding paths containing mspdbcore.dll to the Path env variable, but it didn't help
something like: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\bin\Hostx64\x64
actually all 8 of them, which I have in bin directory, didn't help

 fatal error C1189: #error:  STL1001: Unexpected compiler version, expected MSVC 19.24 or newer.
Seems like it's coded that I need version higher than 19.24, but the latest is 2019 14.25, maybe there is some kind of mess up in the VS versions or how they being read?

what command prompt gives me:
>python setup.py develop
running develop
running egg_info
writing deform_conv.egg-info\PKG-INFO
writing dependency_links to deform_conv.egg-info\dependency_links.txt
writing top-level names to deform_conv.egg-info\top_level.txt
reading manifest file 'deform_conv.egg-info\SOURCES.txt'
writing manifest file 'deform_conv.egg-info\SOURCES.txt'
running build_ext
building 'deform_conv_cuda' extension
Emitting ninja build file Z:\projects\Neural\mmsr2\codes\models\archs\dcn\build\temp.win-amd64-3.7\Release\build.ninja...
Compiling objects...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
[1/2] cl /showIncludes /nologo /Ox /W3 /GL /DNDEBUG /MD /MD /wd4819 /EHsc -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include\torch\csrc\api\include -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include\TH -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include\THC "-IC:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.2\include" -IC:\Users\besit\.conda\envs\mmsr2\include -IC:\Users\besit\.conda\envs\mmsr2\include "-IC:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\shared" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\cppwinrt" -c Z:\projects\Neural\mmsr2\codes\models\archs\dcn\src\deform_conv_cuda.cpp /FoZ:\projects\Neural\mmsr2\codes\models\archs\dcn\build\temp.win-amd64-3.7\Release\src/deform_conv_cuda.obj -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=deform_conv_cuda -D_GLIBCXX_USE_CXX11_ABI=0 /std:c++14
FAILED: Z:/projects/Neural/mmsr2/codes/models/archs/dcn/build/temp.win-amd64-3.7/Release/src/deform_conv_cuda.obj
cl /showIncludes /nologo /Ox /W3 /GL /DNDEBUG /MD /MD /wd4819 /EHsc -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include\torch\csrc\api\include -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include\TH -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include\THC "-IC:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.2\include" -IC:\Users\besit\.conda\envs\mmsr2\include -IC:\Users\besit\.conda\envs\mmsr2\include "-IC:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\shared" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\cppwinrt" -c Z:\projects\Neural\mmsr2\codes\models\archs\dcn\src\deform_conv_cuda.cpp /FoZ:\projects\Neural\mmsr2\codes\models\archs\dcn\build\temp.win-amd64-3.7\Release\src/deform_conv_cuda.obj -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=deform_conv_cuda -D_GLIBCXX_USE_CXX11_ABI=0 /std:c++14
c1xx: fatal error C1356: unable to find mspdbcore.dll
[2/2] C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.2\bin\nvcc -Xcompiler /MD -Xcompiler /wd4819 -Xcompiler /EHsc -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include\torch\csrc\api\include -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include\TH -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include\THC "-IC:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.2\include" -IC:\Users\besit\.conda\envs\mmsr2\include -IC:\Users\besit\.conda\envs\mmsr2\include "-IC:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\shared" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\cppwinrt" -c Z:\projects\Neural\mmsr2\codes\models\archs\dcn\src\deform_conv_cuda_kernel.cu -o Z:\projects\Neural\mmsr2\codes\models\archs\dcn\build\temp.win-amd64-3.7\Release\src/deform_conv_cuda_kernel.obj -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=deform_conv_cuda -D_GLIBCXX_USE_CXX11_ABI=0 -gencode=arch=compute_61,code=sm_61
FAILED: Z:/projects/Neural/mmsr2/codes/models/archs/dcn/build/temp.win-amd64-3.7/Release/src/deform_conv_cuda_kernel.obj
C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.2\bin\nvcc -Xcompiler /MD -Xcompiler /wd4819 -Xcompiler /EHsc -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include\torch\csrc\api\include -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include\TH -IC:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\include\THC "-IC:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.2\include" -IC:\Users\besit\.conda\envs\mmsr2\include -IC:\Users\besit\.conda\envs\mmsr2\include "-IC:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\shared" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\cppwinrt" -c Z:\projects\Neural\mmsr2\codes\models\archs\dcn\src\deform_conv_cuda_kernel.cu -o Z:\projects\Neural\mmsr2\codes\models\archs\dcn\build\temp.win-amd64-3.7\Release\src/deform_conv_cuda_kernel.obj -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=deform_conv_cuda -D_GLIBCXX_USE_CXX11_ABI=0 -gencode=arch=compute_61,code=sm_61
C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.25.28610/include\yvals_core.h(439): fatal error C1189: #error:  STL1001: Unexpected compiler version, expected MSVC 19.24 or newer.
deform_conv_cuda_kernel.cu
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
  File "C:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\utils\cpp_extension.py", line 1400, in _run_ninja_build
    check=True)
  File "C:\Users\besit\.conda\envs\mmsr2\lib\subprocess.py", line 512, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "setup.py", line 22, in <module>
    ], cmdclass={'build_ext': BuildExtension}, zip_safe=False)
  File "C:\Users\besit\.conda\envs\mmsr2\lib\site-packages\setuptools\__init__.py", line 144, in setup
    return distutils.core.setup(**attrs)
  File "C:\Users\besit\.conda\envs\mmsr2\lib\distutils\core.py", line 148, in setup
    dist.run_commands()
  File "C:\Users\besit\.conda\envs\mmsr2\lib\distutils\dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "C:\Users\besit\.conda\envs\mmsr2\lib\distutils\dist.py", line 985, in run_command
    cmd_obj.run()
  File "C:\Users\besit\.conda\envs\mmsr2\lib\site-packages\setuptools\command\develop.py", line 38, in run
    self.install_for_development()
  File "C:\Users\besit\.conda\envs\mmsr2\lib\site-packages\setuptools\command\develop.py", line 140, in install_for_development
    self.run_command('build_ext')
  File "C:\Users\besit\.conda\envs\mmsr2\lib\distutils\cmd.py", line 313, in run_command
    self.distribution.run_command(command)
  File "C:\Users\besit\.conda\envs\mmsr2\lib\distutils\dist.py", line 985, in run_command
    cmd_obj.run()
  File "C:\Users\besit\.conda\envs\mmsr2\lib\site-packages\setuptools\command\build_ext.py", line 87, in run
    _build_ext.run(self)
  File "C:\Users\besit\.conda\envs\mmsr2\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "C:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\utils\cpp_extension.py", line 580, in build_extensions
    build_ext.build_extensions(self)
  File "C:\Users\besit\.conda\envs\mmsr2\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "C:\Users\besit\.conda\envs\mmsr2\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "C:\Users\besit\.conda\envs\mmsr2\lib\site-packages\setuptools\command\build_ext.py", line 208, in build_extension
    _build_ext.build_extension(self, ext)
  File "C:\Users\besit\.conda\envs\mmsr2\lib\distutils\command\build_ext.py", line 534, in build_extension
    depends=ext.depends)
  File "C:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\utils\cpp_extension.py", line 562, in win_wrap_ninja_compile
    with_cuda=with_cuda)
  File "C:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\utils\cpp_extension.py", line 1140, in _write_ninja_file_and_compile_objects
    error_prefix='Error compiling objects for extension')
  File "C:\Users\besit\.conda\envs\mmsr2\lib\site-packages\torch\utils\cpp_extension.py", line 1413, in _run_ninja_build
    raise RuntimeError(message)
RuntimeError: Error compiling objects for extension

No, I did not get it working under Windows.
I did note that the documentation for MMdetection (which is more extensive than what is available for MMSR) says that it has been tested under Ubuntu and Centos, but that Windows is not supported.
I've obtained another PC that I can install Ubuntu on, and will try again using that.

Update:  The dcn code did not initially compile under Ubuntu either.  Issue #84 reports the errors I was seeing.  The problem turns out to be that Anaconda now installes Pytorch 1.5, and the dcn code hasn't been updated to be compatible with 1.5.  However, mmdetect has been updated, and it uses nearly-identical source code for the dcn operation.  My comment in issue 84 describes what I changed to update the dcn source.  With that change, dcn compiles (under Ubuntu).
However, even with this change, and using vcvars32.bat, dcn still fails to compile in Visual Studio.

Not familiar with windows with dcn.
BTW,
Thanks for using MMSR.
We will upgrade MMSR to MMEditing (in the same repo), which consists of SR, inpainting, matting and generation tasks.
And MMSR will be deprecated and no longer exist.


BR buildings has max intelligent control light sliders while having 0 final demand for light

I confirmed with the EB that the buildings section has 0 PJ final demand for light. However, the way the lighting shares are defined now this actually sets the intelligent control sliders at their max. value. This is somewhat counterintuitive and I suggest we try to make these sliders start are at 0% of their potential (in the present).

Well spotted and I agree with you conclusions, @RobTerwel . As it's not broken, let's pick this up after the deploy.

However, the way the lighting shares are defined now this actually sets the intelligent control sliders at their max. value.

I agree wth this. In other words, if a node has two shares of which one is share and the other flexible and no energy flows through that node the share is set to 100 % and the flexible to 0 %. It feels to me like we shouldn't want to change this or make an exception just to solve this issue.
I think the better solution would be to have a look the amount of electricity for lighting in buildings. You can actually set this in the buildings analysis, where it is now set to 0 PJ.
Re-assigning @thaisclv to pick this up if she has time.


resolve ala node_module resolution algorithim (NPM v3 support);

@rwjblue r?

Published as v0.1.3.


disabled IMDSv1 to use IMDSv2 only on all instances.

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/do-e2e-tests


Update fullcalendar to 2.4.0

Is it possible to update dependency to fullcalendar 2.4.0, many new functionality has been added since fullcalendar 2.1.1 which is required for ui-calendar 1.0.0

+1

have you tried to force bower to use the latest version of fullcalendar? if so, does that introduces any bugs?

Now I'm using fullcalendar 2.7.1 without errors, so maybe it's time to update this dependency, isn't it?

Yes, and there's a PR for 2.7.1 - #408 .

Perfect! Thanks!


Add Script 11: Mp3 Downloader

This script will download mp3 files from Youtube. Please assign me this issue, thank you!

There is already a Script 6, for Video Downloader


Per-tab sessions

It would be a great feature to have option to treat new tabs in Vim like new sessions. Instead of using cd to switch working directory when this option is enabled lcd should be used. This would ensure each tab has it's own working directory and since buffer restore and window layout come after restoring path everything should work without too much effort.
Also, on TabNew event new Startify window should be opened if this feature is turned on.

There is no TabNew event in Vim, but there's TabNewEntered in nvim. See https://github.com/mhinz/vim-startify/issues/139
2) When you say session do you mean Vim instance or really a Vim session (as in :mksession)? The latter would be hard to achieve in Vim, because of Startify's session persistence feature.

Good point. I just did little experimentation in past few days and indeed it's not all that flexible as I originally thought. While lcd does indeed allow per-tab working directory it's not all straight forward. I'd mark this as closed as it's not something easily done. Creates more problems than it solves.

Okey-dokey. Thanks for the feedback nevertheless!


Typo? "SpeededCrypto" -> "SeededCrypto"

https://github.com/dicekeys/seeded-crypto-ios/blob/33f11a9e8b4d30d8178f7231ae09f0613196b2b8/SeededCrypto.podspec#L29

@bakhtiyork looks like this is fixed in the main branch.


Remove "[Hydra]" from name options

Just add '[Hydra]' if the name options is not set

Closes #43
Thanks for this :)


Suggestion: Auto-Enabling/Disabling on Certain Websites

Hiya! I'm loving this extension, and it's been really helpful with avoiding dysphoria from my deadname.
I would suggest adding a feature that auto-enables or auto-disables the deadname remover when you're on a certain website. Like for example, making it so that if I go to gmail.com it automatically enables it and if I go to youtube.com it automatically disables it.
This would really help, as for some websites, I will never have a chance of seeing my deadname but may see other people who have it. This way you would less often get scenarios where someone had the same name as your deadname get changed to your preferred name.

This is an old issue, but it seems very useful. I'll try and work on this.

Thanks for the suggestion @evieamity ! Merging this into #520 ; hoping to implement this in version 2.0,0


Unresponsive Buttons

All buttons in the "Select Images For PIV" menu are unresponsive, even with granted permissions. If this is intentional, then maybe we can gray out buttons that can't be clicked yet. E.g., "View Results" button should be grayed out if there are no results to view.

Buttons are being set to inactive without communicating that to the user. Create a function that sets buttons to inactive and grays it out. We'll probably also need a function that sets the button to active, and changes it back to its original color.

Buttons are being set to inactive without communicating that to the user. Create a function that sets buttons to inactive and grays it out. We'll probably also need a function that sets the button to active, and changes it back to its original color.

This is a little more involved than first thought. Closing for now, will reopen if explicitly requested.

This is a little more involved than first thought. Closing for now, will reopen if explicitly requested.


Added configurable protocol prefix to server and client protocol IDs

Adds options to configure protocol prefix in client and server smart-record protocol ID.
Fixes #34

@petar, this should be a straightforward one to review. Thanks!


managed_dirs in cicd seems broken

It's set in https://github.com/GoogleCloudPlatform/healthcare-data-protection-suite/blob/master/examples/tfengine/team.hcl#L160
But not in https://github.com/GoogleCloudPlatform/healthcare-data-protection-suite/blob/master/examples/tfengine/generated/team/cicd/configs/run.sh#L20

The values are passed to https://github.com/GoogleCloudPlatform/healthcare-data-protection-suite/blob/master/examples/tfengine/generated/team/cicd/triggers.tf#L69 and then to the run.sh script via a flag https://github.com/GoogleCloudPlatform/healthcare-data-protection-suite/blob/master/examples/tfengine/generated/team/cicd/configs/tf-plan.yaml#L31

The values are passed to https://github.com/GoogleCloudPlatform/healthcare-data-protection-suite/blob/master/examples/tfengine/generated/team/cicd/triggers.tf#L69 and then to the run.sh script via a flag https://github.com/GoogleCloudPlatform/healthcare-data-protection-suite/blob/master/examples/tfengine/generated/team/cicd/configs/tf-plan.yaml#L31

Ah I see. What is the motivation behind the change? It prevents people from directly running run.sh locally

Ah I see. What is the motivation behind the change? It prevents people from directly running run.sh locally

The change was introduced in the multi env support PR #645. This way, we don't need to duplicate run.sh files multiple times, one for each env and use env-specific ones in the Cloud Build yaml files. It's bit more concise in implementation where env-specific dirs just need to specified in the google_cloudbuild_trigger  resources, and all Cloud Build yamls and run.sh can be reused. Users can still run run.sh script locally, but just need to supply the target directories to deploy.
One alternative is keeping one run.sh and change the argument to run.sh from a list of dirs to be just the env value. run.sh is pre-populated (based on input configs) with if/else statements to switch between envs and choose which list of dirs to deploy. But I'm not sure if that change will bring much benefit but will make the implementation more complicated.

The change was introduced in the multi env support PR #645. This way, we don't need to duplicate run.sh files multiple times, one for each env and use env-specific ones in the Cloud Build yaml files. It's bit more concise in implementation where env-specific dirs just need to specified in the google_cloudbuild_trigger  resources, and all Cloud Build yamls and run.sh can be reused. Users can still run run.sh script locally, but just need to supply the target directories to deploy.
One alternative is keeping one run.sh and change the argument to run.sh from a list of dirs to be just the env value. run.sh is pre-populated (based on input configs) with if/else statements to switch between envs and choose which list of dirs to deploy. But I'm not sure if that change will bring much benefit but will make the implementation more complicated.

Sounds good, I think we can leave as is for now.

Sounds good, I think we can leave as is for now.


[qt5-declarative] qt5_import_qml_plugins always import release libraries even if debug build

Describe the bug
Caused by share/cmake/Qt5QmlImportScanner/Qt5QmlImportScannerConfig.cmake.
It hard code qml_path to release type path, and only process release type libraries.
It will cause the link error on windows (mismatch detected for 'RuntimeLibrary')
set(qml_path "${_qt5Core_install_prefix}/qml/")
# .......
_qt5_Core_process_prl_file(
    "${entry_PATH}/lib${entry_PLUGIN}.prl" RELEASE
    _Qt5${entry_PLUGIN}_STATIC_RELEASE_LIB_DEPENDENCIES
    _Qt5${entry_PLUGIN}_STATIC_RELEASE_LINK_FLAGS
)
_qt5_link_to_QmlImportScanner_library_dependencies(
    "${imported_target}"
    RELEASE
    "${entry_PATH}/lib${entry_PLUGIN}.a"
    FALSE)

If I remove qt5_import_qml_plugins(xxx) from CMakeLists.txt, it can build. (Of course, due to the lack of plugin, this will cause a crash)
Apparently the link error is caused by Qt5QmlImportScannerConfig.cmake.
Please see logs below for details.
Please use x64-windows-static triplet to repro, since qt5_import_qml_plugins do nothing on dynamic build.
Environment

OS: windows
Compiler: revision

To Reproduce
Steps to reproduce the behavior:

./vcpkg install qt5:x64-windows-static
Build a demo qt quick app, it won't link when CMAKE_BUILD_TYPE=Debug

A simplest demo code can be found at https://github.com/xiaozhuai/vcpkg_demo/tree/master/src/qt5_quick
Failure logs
link_error.log

@MonicaLiu0311 Thanks for reply.
I note that error message error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MTd_StaticDebug' doesn't match value 'MDd_DynamicDebug' in AngleHelper.obj in your logs.
It is not same as mine
error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MTd_StaticDebug' in AngleHelper.cpp.obj.
That means your triplet is static but user project is dynamic. Perhaps you need to set "CMAKE_MSVC_RUNTIME_LIBRARY": "MultiThreaded$<$<CONFIG:Debug>:Debug>" in CMakePresets.json in your user project.
The key to repro it:

triplet and user project both static linking.
CMAKE_BUILD_TYPE is Debug.

Thanks again!

Hello @MonicaLiu0311 , any progress of this?

#42820


Introduce shader examples that don't use high level rendering apis

Objective
Most of the shader examples use the Material trait and the few remaining ones that don't use it might be updated in the future to either use that or some other high level rendering api.
We need an example that showcases a manual implementation for drawing a basic mesh without any high level apis.
There should also be an example showcasing a manual implementation of AsBindGroup.
These examples should be clearly used to showcase those lower level features and not be updated to higher level apis in the future.
Notes
Discord dicussion: https://discord.com/channels/691052431525675048/743663924229963868/1014539753854615662

I think the example itself should be really simple. Nothing more complicated than the current shader_material example. The important part is that it showcases the mid-level rendering apis explicitly. Personally, I was planning on pretty much just writing the shader_material example but without using a Material. I just didn't have time yet.

Basically re-establish a previous iteration of that example: https://github.com/bevyengine/bevy/blob/adb3ad399cf092110b2d69f7dc189abc0ebc9f80/examples/shader/shader_material.rs should might give a good base

Yeah, something like that would be a decent starting point. I think the important part would be having a lot of comment explaining what is going on.


Intensely good tabular data processing

Distributive deals with a lot of tabular data. With methods like strIn, strContainedIn, reIn, commandColumnNoHeader, it's clear that this could be abstracted even further. My proposal is as follows:
We need one, unified method for splitting a tabular string into a 2D slice. It should detect which regexp to use, judging by the consistency of the row widths (it would assume even rows). It might do this using standard deviation or something. It would abstract further and eliminate the need for separateString, stringToSlice, and stringToSliceMultispace. Possible regexp's: for rows: "\n+", for columns: "\\s{2,}", "\\s+", "\t+".
In conjunction, we need a method that fetches the a column (sans header) by the header title. This should be super simple and will totally prettify the code.
For organization, this will all go into another go package: tabular.go

Ideas for an algorithm for splitting arbitrary data into a table:
Try different regexps, counting the length of each row. If there is one with all rows the same length, use that. If not, toss one outlier and test again. If there still isn't, just pick the one with the lowest standard deviation.
Keep in mind that this algorithm must, at its heart, be probabalistic. Which might be an issue on commands with widely varying outputs.

Done with both, all that's left is to implement their use in all possible places.


Move script icon cache to ScriptServer & Remove cache from project.godot

<nathanfranke> Why is there a `_global_script_classes` property in project.godot? Shouldn't this be stored in `.godot`? AutoLoad should be separate
...
<Akien> nathanfranke: no specific reason, it was implemented this way initially because it was easy, but I suggested several times to move it to project metadata. Now that we have .godot instead of .import, that's even better suited.

TODO

[x] Remove Spaghetti :spaghetti:
[ ] Is it necessary to implement a cache system? What if the user edits the script outside of Godot? Lots of issues may arise from a cache system.

[x] Create a cache system using .godot/

[ ] Make sure this works with all languages (NativeScript, VisualScript(?), CsharpScript)
[ ] Resolve all TODOs in changed code.

Marking this as draft before I make this change: I want to move the cache to a file like .godot/global_classes since I think the cache is important for large projects.

I don't think I have the time to maintain this. I can prioritize it if someone can explain if caching is necessary, perhaps help with implementing a cache system (Maybe check file modification dates) and finally if I can guarantee that it will be merged promptly and not gain dust with merge conflicts.

I think project.godot shouldn't have any cache too. Many times, I delete _global_scripts_classes and _global_scripts_class_icons section because of Godot4's bug. move this cache to .godot folder was a good idea for me.


audio(koala): add new audio filter KoalaFilter

Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
Adds a new audio filter for noise reduction using Koala Noise Suppression.
https://picovoice.ai/platform/koala/

Very cool! Can you add a simple foundational example showing how to use this? Or, we can opt to not do that and just update the docs for this. WDYT?
Either way, it looks good! I tested it locally.

Docs PR showing how to use it: https://github.com/pipecat-ai/docs/pull/67.

Very cool! Can you add a simple foundational example showing how to use this? Or, we can opt to not do that and just update the docs for this. WDYT?
Either way, it looks good! I tested it locally.

I think we don't need another example, since it's just one line change from the Krisp one. Thanks for the docs update!


Don't call os.Exit explicitly to avoid lost of logs

Do not call os.Exit directly in codes, but call "return cli.NewExitError"
instead, so that after the program terminated, glog can flush and no
logs will be lost.
Signed-off-by: Zhang Wei<EMAIL_ADDRESS>

The reason that this commit works is that in https://github.com/hyperhq/runv/blob/master/main.go#L144-L148 , there is a glog.Flush() to flush all the logs after the APP exits, but if we call os.Exit in middle directly, there's no way to flush all the logs, hence cached logs would be lost.
With this modification, glog.Flush will always be called when program exits normally (except panic), and we could get all logs for debugging.


Pdf download in agent.py

Fixed these issues:

The browser variable was not defined
The async function in its replacement was not used

Solves #331

are you testing it properly? It's not working.

Issue:

In this report function, the file is downloaded to the 'data/pdf' folder, and users can also access the PDF via the URL in the chat interface. However, there's an issue when accessing the URL—it returns the PDF file directly instead of a webpage. Consequently, we can't capture a screenshot of it.

Here's a suggestion: Should we consider rewriting the 'open_page' function, which is currently used for capturing screenshots of useful websites, and comment out the 'open_page' function in the PDF download section?


ensure end state for inwebo

At the moment, the inWebo flow cannot actually complete, since there is no end state.

Summary of last changes:

created InweboMultifactorWebflowConfigurerTests extending BaseMultifactorWebflowConfigurerTests
added a method on the latter to check that all transitions in the provider flow have a destination in that flow.

This test reveals missing states in the Duo and Google Authenticator webflows, which I'm happy to patch as well if this is a good PR to do it.

In my original pull request, there was a mfa-inwebo-webflow.xml with an end state: https://github.com/apereo/cas/pull/5001/files#diff-8df9668826637db568fcabdfc810c779ce03d36d5f8a8d8f97f63f6dafc6f707
But it has been removed: https://github.com/apereo/cas/tree/master/support/cas-server-support-inwebo-mfa/src/main/resources/META-INF
So yes, the end state is now missing and this pull request fixes it.


feat: Add chinese README

This README has been translated using ChatGPT.
PS: Using ChatGPT to translate articles with markdown format is a great experience, but even with ChatGPT's help, it still took 1 hour and 30 minutes to translate this README. The main time was spent waiting for ChatGPT's response and manually copying the content from GitHub to chat.openai.com.
PS: If ChatGPT could access external up-to-date information through a plugin, the experience of translating README.md and similar documents would be greatly improved.

Thank you for this! We expect this repo to evolve quickly over time and don't have the bandwidth to keep resources up to date in multiple languages. Thanks for taking the time to put together this PR though!


Fix CMakes

Prefix options with RTTR_ and if it's added as a subdirectory, turn everything off (examples, docs, etc.)

RTTR_ and if it's added as a subdirectory, turn everything off (examples, docs, etc.)
What is the reason for this?
So why prefix? And Why disable the other stuff?

What is the reason for this?
So why prefix? And Why disable the other stuff?

Mainly - if you're building this project alone, as a standalone library - it's working as it was, but if you're just a client and do something like add_subdirectory it from another project like most of the third party integrations are done (mainly on Windows, on *nix there are tons of package managers, from which I can install this library), it will disable all tests, benchmarks, docs, etc.
And why prefix it?
Here is a snippet from root CMakeLists.txt of my homebrew engine:
# set(BUILD_PACKAGE OFF)
# set(BUILD_UNIT_TESTS OFF)
# set(BUILD_STATIC ON)
# set(BUILD_EXAMPLES OFF)
# set(BUILD_DOCUMENTATION OFF)
# set(BUILD_INSTALLER OFF)
# set(BUILD_PACKAGE OFF)
# set(USE_PCH OFF)
# add_subdirectory(vendor/rttr)

add_subdirectory(vendor/glad)
add_subdirectory(vendor/sdl2)

Right now, it will fail to parse my project, because docs are default to ON, examples too, and me as a user of your library don't care for tests, packaging, examples, documentation, installer, etc.
But I need to set those variables before I add_subdirectory your library and those variables will leak to every add_subdirectory on the way, what if some other library used for example USE_PCH or my own (they're not :P)? 😃
So prefixing them with RTTR_ will partially solve this problem, but the real solution is to not enable them in the first place if you detect you're being built as a subproject 😃

Okay I got it, that the variable names will leak to other libraries. So this change is okay. However, I don't like this implicit behavior. When you do it in this context then the variables defaults will changes.
And then someone else is coming and still want to have the docs generated, etc...
Please just set the variables default how you like it before calling  add_subdirectory(vendor/rttr) and that's it.


Issue with running the enviroment on new ubuntu devie

There seems to be an issue with the protobuf package when trying to run the enviroment under ubuntu:
google.protobuf.text_format.ParseError: 24:5 : Message type "android_env.SetupStep" has no field named "adb_request".
steps to repproduce:

clean install android_env in conda env
-download a task (i used droidfish packages)
run from the forlder where .apk and .textproto file are located

please help

Hi @munterwexi,
We haven't touched those tasks in a long time, and we also haven't released a new version on pypi in a long time either. The version at head is the only one that we know is working well.
Still though, it looks like the proto parsing is failing but I don't know why. The SetupStep message should have an adb_request field: https://github.com/deepmind/android_env/blob/440d61e8cd9f287e76e79bc955cac57f8a6aa064/android_env/proto/task.proto#L72
Sorry I don't have the time to debug this now. Let's leave this open for now.

Hi @munterwexi and @kenjitoyama,
It seems like the protobuffer definitions changed at some point and that adb_request is now adb_call. I figured this out by adding a breakpoint into the protobuf text_import.py script (at what is currently line 923).
        if not field:
          # breakpoint()
          field = message_descriptor.fields_by_name.get(name.lower(), None)

and then running something like [field.full_name for field in message_descriptor.fields] to view the fields actually included in the Android_Env protobuf definitions
The API has changed in several places so I recommend creating all new tasks, thought the old ones aren't too difficult to change through trial and error. I modified a MDP proto file to work and it looks something like this:
# Copyright 2022 DeepMind Technologies Limited.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# proto-file: android_env/proto/task.proto
# proto-message: android_env.Task

id: "mdp_0000"
name: "MDP 0000"
description: "A 2-state 2-action MDP game for debugging agents."

setup_steps: [
  {
    adb_call: {
      install_apk: {
        filesystem: {
          path: "2020.08.06-vokram-debug.apk"
        }
      }
    }
    success_condition: {
      check_install: {
        package_name: "com.example.vokram"
        timeout_sec: 10.0
      }
    }
  }
]

reset_steps: [
  {
    adb_call: {
      force_stop: {
        package_name: "com.example.vokram/com.example.vokram.MainActivity"
      }
    }
  },
  {
    adb_call: {
      start_activity: {
        full_activity: "com.example.vokram/com.example.vokram.MainActivity"
        extra_args: [
            "--ez", '"RL_TASK_ENABLED"', '"true"',
            "--es", '"RL_TASK_GAME_CONFIG"', '"{"'
            '"\\"initialSeed\\":-1,"' # Each episode will be randomized.
            '"\\"states\\":[0,1],"'
            '"\\"initial_states_prob\\":[{\\"S\\":\\"0\\",\\"P\\":1.0}],"'
            '"\\"terminal_state\\":1,"'
            '"\\"actions\\":[A,B],"'
            '"\\"transitions\\":["'
            '"{\\"FS\\":\\"0\\",\\"A\\":\\"A\\",\\"TS\\":\\"0\\",\\"P\\":1.0,\\"R\\":-1.0},"'
            '"{\\"FS\\":\\"0\\",\\"A\\":\\"B\\",\\"TS\\":\\"1\\",\\"P\\":1.0,\\"R\\":1.0}"'
            '"],"'
            '"\\"movementSpeed\\":[0,0,1]"' # Prevent action buttons from moving.
            '"}"'
        ]
      }
    }
    success_condition: {
      wait_for_app_screen: {
        app_screen: {
          activity: "com.example.vokram/com.example.vokram.MainActivity"
          view_hierarchy_path: [
          ]
        }
        timeout_sec: 10.0
      }
    }
  },
  {
    adb_call: {
      start_screen_pinning: {
        full_activity: "com.example.vokram/com.example.vokram.MainActivity"
      }
    }
  }
]

expected_app_screen: {
  activity: "com.example.vokram/com.example.vokram.MainActivity"
  view_hierarchy_path: [
  ]
}

max_duration_sec: 7200  # Prevent infinite episodes.

log_parsing_config: {

  filters: ["AndroidRLTask:V", "Vokram:V"]

  log_regexps: {
    score: "^[Ss]core: ([-+]?[0-9]*\\.?[0-9]*)$"
    reward: "^[Rr]eward: ([-+]?[0-9]*\\.?[0-9]*)$"
    episode_end: "^episode[ _]end$"
    extra: "^extra: (?P<name>[^ ]*)[ ]?(?P<extra>.*)$"
    json_extra: "^json_extra: (?P<json_extra>.*)$"
  }
}

extras_spec: [
  # All of these a returned when any button is pressed
  # Set of all buttons e.g. ['A', 'B']
  { name: "actions" shape: [2], dtype: STRING_U1},
  # Label of the button just pressed e.g. ['B']
  { name: "clicks" shape: [1], dtype: STRING_U1 },
  # Coordinates of the top left and bottom right corners of each button
  # [x_a_0, y_a_0, x_a_1, y_a_1], [x_b_0, y_a_0, x_b_1, y_b_1]
  { name: "buttons" shape: [2, 4], dtype: INT32 }
]

Hi, sorry for the massive delay, things have been quite busy these last few months.
As @Loeing said, the problem here is with the protobuf definition. Specifically, I think the textproto is actually fine, but the package in PyPi is really old, dating from Oct 7th 2021. I'll try to update the PyPi release later, but in the meantime, can you try running with the version at head from github?
Thanks

Hi, no worries- it was just for a private project. I will try to spin up my
instance and install with the github Version. Will let you know if it
worked. Thanks, Markus
Kenji @.***> schrieb am Di. 4. Apr. 2023 um 00:01:

Hi, sorry for the massive delay, things have been quite busy these last
few months.
As @Loeing https://github.com/Loeing said, the problem here is with the
protobuf definition. Specifically, I think the textproto is actually fine,
but the package in PyPi is really old, dating from Oct 7th 2021
https://pypi.org/project/android-env/1.1.0/#history. I'll try to update
the PyPi release later, but in the meantime, can you try running with the
version at head from github?
Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/deepmind/android_env/issues/116#issuecomment-1495043360,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS55HKMXCEBCX57H7XJ3E33W7NCDZANCNFSM6AAAAAAU7XNPEA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi! I have updated the AndroidEnv in PyPi: https://pypi.org/project/android-env/ (now at version 1.2.2). I'll close this bug for now, but let us know if you bump into other problems.


[BUG]: Nodejs version has security issues

What happened?
Dear Microsoft
We have scanned the latest agent recently with Twistlock, and it complained about the node 20 version in the binary.
The mentioned CVE in the report is : https://nvd.nist.gov/vuln/detail/CVE-2023-32002
Node has a new version 20.8.0 which would do the job for us. Can you verify and fix this issue with the next release?
Versions
3.277.2 (latest at this moment)
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[ ] Microsoft Hosted
[ ] VMSS Pool
[X] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
ubuntu, alpine
Version controll system
git
Relevant log output
Impacted versions: <=20.5.0,2 and >=20.0.0,2
Discovered: less than an hour ago
Published: 58 days ago
The use of Module._load() can bypass the policy mechanism and require modules outside of the policy.json definition for a given module. This vulnerability affects all users using the experimental policy mechanism in all active release lines: 16.x, 18.x and, 20.x. Please note that at the time this CVE was issued, the policy is an experimental feature of Node.js.

Hi @norbinto, thanks for the report! we'll try to fix it in next release

Results of Cloud Defender / Trivy scan:
HIGH | CVE-2017-18077 | brace-expansion | nodejs-brace-expansion: Regular expression denial of service | Yes |
-- | -- | -- | -- | -- | --
  | HIGH | CVE-2016-10540 | minimatch | Minimatch is a minimal matching utility that works by converting glob ... | Yes |
  | HIGH | CVE-2022-3517 | minimatch | ReDoS via the braceExpand function | Yes |
  | HIGH | NSWG-ECO-118 | minimatch | Regular Expression Denial of Service | Yes |
  | HIGH | CVE-2022-0144 | shelljs | nodejs-shelljs: improper privilege management | Yes |
  | HIGH | CVE-2023-2253 | github.com/docker/distribution | DoS from malicious API request | Yes |
  | HIGH | CVE-2023-28840 | github.com/docker/docker | Encrypted overlay network may be unauthenticated | Yes |
  | HIGH | CVE-2023-27561 | github.com/opencontainers/runc | volume mount race condition (regression of CVE-2019-19921) | Yes |
  | HIGH | CVE-2019-0820 | System.Text.RegularExpressions | dotnet: timeouts for regular expressions are not enforced | Yes |
  | HIGH | CVE-2019-0980 | System.Private.Uri | dotnet: infinite loop in Uri.TryCreate leading to ASP.Net Core Denial of Service | Yes |
  | HIGH | CVE-2019-0981 | System.Private.Uri | dotnet: crash in IPAddress.TryCreate leading to ASP.Net Core Denial of Service | Yes |
  | HIGH | CVE-2019-0820 | System.Text.RegularExpressions | dotnet: timeouts for regular expressions are not enforced | Yes |
  | HIGH | CVE-2019-0980 | System.Private.Uri | dotnet: infinite loop in Uri.TryCreate leading to ASP.Net Core Denial of Service | Yes |
  | HIGH | CVE-2019-0981 | System.Private.Uri | dotnet: crash in IPAddress.TryCreate leading to ASP.Net Core Denial of Service | Yes |
  | HIGH | CVE-2019-0820 | System.Text.RegularExpressions | dotnet: timeouts for regular expressions are not enforced | Yes |
  | HIGH | CVE-2019-0980 | System.Private.Uri | dotnet: infinite loop in Uri.TryCreate leading to ASP.Net Core Denial of Service | Yes |
  | HIGH | CVE-2019-0981 | System.Private.Uri | dotnet: crash in IPAddress.TryCreate leading to ASP.Net Core Denial of Service | Yes |
  | HIGH | CVE-2019-0820 | System.Text.RegularExpressions | dotnet: timeouts for regular expressions are not enforced | Yes |
  | HIGH | CVE-2019-0980 | System.Private.Uri | dotnet: infinite loop in Uri.TryCreate leading to ASP.Net Core Denial of Service | Yes |
  | HIGH | CVE-2019-0981 | System.Private.Uri | dotnet: crash in IPAddress.TryCreate leading to ASP.Net Core Denial of Service | Yes |
  | HIGH | CVE-2019-0820 | System.Text.RegularExpressions | dotnet: timeouts for regular expressions are not enforced | Yes |
  | HIGH | CVE-2019-0980 | System.Private.Uri | dotnet: infinite loop in Uri.TryCreate leading to ASP.Net Core Denial of Service | Yes |
  | HIGH | CVE-2019-0981 | System.Private.Uri | dotnet: crash in IPAddress.TryCreate leading to ASP.Net Core Denial of Service | Yes |
  | HIGH | CVE-2019-0820 | System.Text.RegularExpressions | dotnet: timeouts for regular expressions are not enforced
HIGH
CVE-2017-18077
brace-expansion
nodejs-brace-expansion: Regular expression denial of service
Yes
HIGH
CVE-2016-10540
minimatch
Minimatch is a minimal matching utility that works by converting glob ...
Yes
HIGH
CVE-2022-3517
minimatch
ReDoS via the braceExpand function
Yes
HIGH
NSWG-ECO-118
minimatch
Regular Expression Denial of Service
Yes
HIGH
CVE-2022-0144
shelljs
nodejs-shelljs: improper privilege management
Yes
HIGH
CVE-2023-2253
github.com/docker/distribution
DoS from malicious API request
Yes
HIGH
CVE-2023-28840
github.com/docker/docker
Encrypted overlay network may be unauthenticated
Yes
HIGH
CVE-2023-27561
github.com/opencontainers/runc
volume mount race condition (regression of CVE-2019-19921)
Yes
HIGH
CVE-2019-0820
System.Text.RegularExpressions
dotnet: timeouts for regular expressions are not enforced
Yes
HIGH
CVE-2019-0980
System.Private.Uri
dotnet: infinite loop in Uri.TryCreate leading to ASP.Net Core Denial of Service
Yes
HIGH
CVE-2019-0981
System.Private.Uri
dotnet: crash in IPAddress.TryCreate leading to ASP.Net Core Denial of Service
Yes
HIGH
CVE-2019-0820
System.Text.RegularExpressions
dotnet: timeouts for regular expressions are not enforced
Yes
HIGH
CVE-2019-0980
System.Private.Uri
dotnet: infinite loop in Uri.TryCreate leading to ASP.Net Core Denial of Service
Yes
HIGH
CVE-2019-0981
System.Private.Uri
dotnet: crash in IPAddress.TryCreate leading to ASP.Net Core Denial of Service
Yes
HIGH
CVE-2019-0820
System.Text.RegularExpressions
dotnet: timeouts for regular expressions are not enforced
Yes
HIGH
CVE-2019-0980
System.Private.Uri
dotnet: infinite loop in Uri.TryCreate leading to ASP.Net Core Denial of Service
Yes
HIGH
CVE-2019-0981
System.Private.Uri
dotnet: crash in IPAddress.TryCreate leading to ASP.Net Core Denial of Service
Yes
HIGH
CVE-2019-0820
System.Text.RegularExpressions
dotnet: timeouts for regular expressions are not enforced
Yes
HIGH
CVE-2019-0980
System.Private.Uri
dotnet: infinite loop in Uri.TryCreate leading to ASP.Net Core Denial of Service
Yes
HIGH
CVE-2019-0981
System.Private.Uri
dotnet: crash in IPAddress.TryCreate leading to ASP.Net Core Denial of Service
Yes
HIGH
CVE-2019-0820
System.Text.RegularExpressions
dotnet: timeouts for regular expressions are not enforced
Yes
HIGH
CVE-2019-0980
System.Private.Uri
dotnet: infinite loop in Uri.TryCreate leading to ASP.Net Core Denial of Service
Yes
HIGH
CVE-2019-0981
System.Private.Uri
dotnet: crash in IPAddress.TryCreate leading to ASP.Net Core Denial of Service
Yes
HIGH
CVE-2019-0820
System.Text.RegularExpressions
dotnet: timeouts for regular expressions are not enforced


Alter AclRuleUpdate to handle rule-only change

Fixes #547

Depends on this change to the Go API: https://github.com/RedisLabs/rediscloud-go-api/pull/176

Included in #554


implemented multi-region support

Region: eu-central-1 cfn property allows to deploy cfn stack cross-account into different account

Used annonnymous arrow notation to inject region into lazy loaded STS client.
() -> ClientBuilder.getStsClient("eu-central-1")

LGTM, tested according to @f7o


'cancelButton' not working under iOS 11

RMStepsBar.cancelButton does not seem to be receiving touch events under iOS 11. Has anyone else faced this issue?
iOS 9 and 10 are working perfectly.

Just checked an I can confirm the issue. I'll have a look asap and let you know 🙂

Thank you so much! 🙂

Well the problem is that the UIToolbar of iOS 11 adds some new subviews to itself. Since RMStepsBar (the bar containing the steps) inherits from UIToolbar these new subviews have been added above the view from RMStepsBar and thus receive all touch events.
I created a little branch called ios-11 which contains a fix for the problem. Mainly RMStepsBar does not inherit from UIToolbar anymore (that inheritance was a bad idea anyways 😄). Could you take a look if this branch suits your needs?

This fixes the cancel button issue, but tapping the other steps on the bar doesn't work anymore 🙂

Can you update the POD?

Hi Cooper, any luck? I can also try to fix it if you give me a hint where to look. Thanks!

Hey!
Sry I did not find the time to take care of it. I will as soon as possible. Hopefully next weekend 😄.
In the meantime: If you want you can take a look at RMStepsBar. The bug should be somewhere there. Probably the tap gesture recognizer has a wrong target 🙂

Thank you so much for the tip. I checked it out, and it seems to be caused by this 'if' statement inside the 'recognizeTap:' method:
           if(index < self.indexOfSelectedStep && self.allowBackward) {                 [self.delegate stepsBar:self shouldSelectStepAtIndex:index];             }
This will always be false if you're tapping a forward tab. Hope this helps 😊


Running behind nginx-proxy

Anyone have experience running Plex behind an nginx proxy: https://github.com/jwilder/nginx-proxy
I've got my site using SSL with the above proxy and companion container (https://github.com/JrCs/docker-letsencrypt-nginx-proxy-companion) to get SSL certificates from Let's Encrypt. I've had no luck getting plex to work behind it. With timhaak's version, I could specify a redirect port (80 goes to 32400) for Plex via PLEX_EXTERNALPORT and that sort of worked.
I could access my server directly, but not via plex.tv or my mobile app. Without running using net=host (which breaks the proxy setup), I haven't been able to get anything to work with this one when running behind the nginx proxy. Even with net=host, I had to use a relay option on plex.tv and my mobile app last night and it stopped working today. Not sure what the problem is there.
I've got 32400 forwarded. I did notice last night that a different port was made public when running as net=host than 32400, when looking at the server settings. Can't get back to that point now, though.

Here's an example of what I am seeing in the browser logs.

You may want to check https://support.plex.tv/hc/en-us/articles/201543147-What-network-ports-do-I-need-to-allow-through-my-firewall-

Also check your Preferences.xml, as I didn't really verify the PLEX_EXTERNALPORT which is also going to be renamed to PLEX_EXTERNAL_PORT on this fork.

Opened all ports, set my X_PLEX_TOKEN (had it earlier), and set the PLEX_EXTERNAL_PORT to 80 and 443 to see if either worked. Cannot get it to connect. Getting a lot of unreachable and preventing fallback of insecure connection. Trying to allow insecure connections didn't seem to do anything.

I suggest you check your network step by step. I don't know how many layers you have etc. I also don't know your docker-compose (if you're using that) or if you've setup linking correctly. I didn't use nginx-proxy image myself; usually I do that myself.
Now from the log is says ERR_INSECURE_RESPONSE which is normal because its a self signed certificate. Given its in your browser, you may want to add nginx-proxy self-signed certificate if it generates any, to your browser. You can also type badidea if you're using Chrome.

I don't think nginx-proxy is using self-signed certificates. I give it a directory to look for certificates to use when serving subdomains and I have a companion container that reaches out to Let's Encrypt for subdomain certificates and places them in that directory.
Of course, I don't know nginx that well, so maybe there are other certificates you are referring to? Couldn't seem to figure out how to use badidea (or the former danger). Was trying in the console. Not sure if there was somewhere else to use it. I'll double-check that the ports I specified are open and reachable later this week.
Thanks for all of the help so far!

Just type it in the page, even if nothing is visible. But understand the meaning: It'll just allow man-in-middle attacks so it's pretty much the same as if you had plain HTTP without TSL.

So, tried typing 'badidea' and 'danger' into Chrome. Can't tell if it did anything and the only thing I can find online is that it should apply if the window is in focus.
Anyway, I selected the "use fallback" option as well, but it does seem to have helped with issues of cross-origin headers, the insecure response, and other errors.

Looks like it tries a mix of <IP_ADDRESS>, the Docker container's IP, and my server's IP in the requests.

May I ask why you're using nginx reverse proxy? Plex doesn't need to run behind Nginx.

I'm using the Docker nginx-proxy project because it allows me to assign containers to different subdomains on my main domain. So, I can visit https://plex.example.com to reach my plex server.
I've got other containers like the Docker UI project running and accessible via https://ui.example.com, Gitlab via https://git.example.com, etc.
So, it's just a really handy setup for me to run different services all tied to the same address and port from the perspective of the user.
As a side note, I switched back to timhaak/plex and it works fine going directly to it (https://plex.example.com) and offers indirect streaming on my phone, just like before. So, not sure what is different. :/

I get that, but you can access via plex.tv and you don't need an accessible subdomain. You can use also another port.


Update to 1.20.2 + Nether Fix

This continues on DrexHD's work to update to 1.20.2.
The existing version did not work for the nether. This was caused by the following phenomenon.

The vanilla game uses the same world border centre for all dimensions.
To account for different dimension sizes, the vanilla game divides the centre coordinates by the dimension's scale factor.
This modification unties the centres of the various worlds. This means that if we set the centre of a world, we do not need to divide it by the scale factor any more. This was already implemented.
An unmodified client will still divide it by the scale factor, meaning that if we set the centre to $(x; y)$ on the server, the client will convert it to $({x \over {s}}; {y \over {s}})$ for the dimension's scale factor $s$. This causes the centre to appear different on the client from what it actually is on the server.

To resolve this, we did not want to modify any client code. Removing the division by the scale factor on the client would make the client unable to correctly interpret world borders of unmodified servers. As such instead we modified the server to instead send the coordinates $({s \times x}; {s \times y})$ to every client. Vanilla clients will then divide it again by $s$ to obtain the correct coordinates $(x; y)$.
This is not the end of the story, because as said in (3), modified clients will no longer divide by the scale factor, and end up with now incorrect coordinates $({s \times x}; {s \times y})$.
We therefore modified the pre-existing change of (3) to only be applied on logical servers; that is, modified clients will still do the division. This keeps the behaviour of modified clients and vanilla clients identical, which allows modified clients to benefit of the modification for single player worlds, while still remaining compatible with both vanilla and modified servers.

We were not able to reproduce the issue with the world border not updating by as described below.
https://github.com/PotatoPresident/worldborderfixer/pull/9#issuecomment-1742151070


Why do I need to disable MySQL strict mode?

I read that I need to set 'strict' => false for my MySQL connection to have your package work.
I would prefer to keep strict mode enable so I made a quick test:

clone your package
change your setting in TestCase.php to have 'strict' => true
change ServiceProvider.php to test against MySQL : $_ENV['type'] = 'mysql';
launch phpunit

and there is no error reporting by phpunit: all your tests passed (58).
So why do I need to disable strict mode?
In which case is it mandatory?
Please explain.
Regards,
Patrick

'strict' => false is from an older version of the package I change it to true now, thanks for the feedback....


FFmpeg stream unpipes around 20 seconds before end of audio file

YouTube does not always have an Opus audio file available and any other format I pass to Discordie's FFmpegEncoder. This has been happening recently after some of the SIGTERM and SIGKILL changes were implemented, but I am uncertain if this issue is caused by those changes.
I noticed that the stream unpipes from the audio socket output, but does not fire an end event. The timestamp shows the audio file stopped around 20 seconds from the end of the audio file for a full-length song (approx. 3 minutes).
I am still investigating the cause of this. Turning on FFmpegEncoder's debug does not show an error, but I may need to increase the log verbosity.

For more information, the encoder initialization is:
      this.encoder = voiceConnection.createExternalEncoder({
        type: 'ffmpeg',
        source: this.url,
        format: 'opus',
        outputArgs: ['-ab', '64000'],
        debug: true,
      });

This is from https://github.com/mbilker/cardinal-discord/blob/master/queue/queued-media.js#L89-L101

Found some log output:
  cardinal:queue QUEUE_ITEM +53s https://www.youtube.com/watch?v=-tRdBsnX4N4
  cardinal:queue fetchYoutubeInfo promise resolve +1s
  cardinal:queue handleQueued +4ms
  cardinal:queued-media stopPlaying +3m -HsOQFVeiGE vorbis
  cardinal:queued-media encoder unpipe +1ms -HsOQFVeiGE vorbis
  cardinal:queued-media stream unpipe +0ms -HsOQFVeiGE vorbis

I discovered I forgot to track when the stream from encoder.play() fires its end event.

How often does that happen?
This may be caused by Discord servers disconnecting you (though it will stay in the channel and autoreconnect if it's just a server change), thus why the library could be cleaning up all resources without firing an end event.
Adding a VOICE_DISCONNECTED handler would clear the case up a bit.
Also for debugging stuff like this I'd additionally recommend logging all library events using Dispatcher.onAny or in case of regular event emitters just hooking the emit method.

It happens with every non-Opus passthrough song. I am going to debug this with the methods you provided. Thanks for the quick response!

Okay tested it out on https://www.youtube.com/watch?v=rGd7IEOjk-0
It stopped at 2:41 out of 2:48. No events fired.

 I am sorry. The song never ends, but the timestamp stops updating. I had to manually trigger the unpipe.

Seems to be an issue with stream behavior changes in newer nodejs versions, can consistently reproduce on v6.2.0.

This commit seems to be causing the issue: https://github.com/nodejs/node/pull/6023.
v5.11.0:
spawned: 16340
:: STDOUT :: resume
:: PROCESS :: exit
:: STDOUT :: resume

v5.11.0 with commit rolled back:
spawned: 14756
:: STDOUT :: resume
:: PROCESS :: exit
:: STDOUT :: resume
:: STDOUT :: _socketEnd
stdout end
:: STDOUT :: end
:: STDOUT :: prefinish
:: STDOUT :: finish
process exited with code 0
:: PROCESS :: close
:: STDOUT :: close

Pushed a workaround https://github.com/qeled/discordie/commit/a7de2f4956b32744cf1d70c8652d65195ee219f7 to dev branch, will push to master and npm if that fixes it.
Doesn't fix the actual bug, but it seems too deep for me to hunt it down and keeps only happening with ffmpeg processes, things like cat close cleanly.

Thanks for the investigation. I did upgrade my Arch system between restarts of my bot, and I wasn't playing a lot of non-Opus songs so I never noticed.

Testing now

Yep that fixes it! I know it is a hack, but thank you for figuring it out.


Where are the Python scripts located?

There are few mentions of 2 python scripts to analyze logs:

LogInspector.py
LogPlotter.py

Where are these located?

Hi Alexis.  See the latest version of our SDK for these scripts.
https://github.com/inertialsense/inertial-sense-sdk/tree/release/python/logInspector

Thanks!


Rename "iree_public" dialect to "iree".

pytype failure is an automation bug.

👍
out of curiosity, any reason it's Dialects/iree/ instead of Dialects/IREE to match upstream conventions?

👍
out of curiosity, any reason it's Dialects/iree/ instead of Dialects/IREE to match upstream conventions?

Because I messed it up :)
I'll fix it in a follow-up.


Parse event timestamp and add more events metrics

Coverage decreased (-0.4%) to 82.088% when pulling 20b37fa1e2f97db9e284967d890391ea79a8319a on add_logging into cf1abbb4aef154b4e048730debe76e34444e6c56 on master.

Coverage decreased (-0.4%) to 82.112% when pulling 3da77c30f89e9e7c03a5126263e51cf5db49638d on add_logging into cf1abbb4aef154b4e048730debe76e34444e6c56 on master.

Coverage decreased (-0.2%) to 82.297% when pulling 76f2054b7671acb9b2acdc6d86c684ffc132a384 on add_logging into cf1abbb4aef154b4e048730debe76e34444e6c56 on master.


Snippets is removed after v2021.1.0 but still exists in the official doc. may cause confuse

https://github.com/microsoft/vscode-python/issues/15220#issuecomment-767840313
https://code.visualstudio.com/docs/languages/python#_snippets

I have opened an issue against the docs at https://github.com/microsoft/vscode-docs/issues/4469.

@NewUserHa thanks for the bug report!


Random unitary method

Fixes https://github.com/qgrad/qgrad/issues/59
@quantshah would it be better class-based?
cc @nathanshammah

Also, I feel like adding a seed argument would be better

Looks good. I just have some simplification of the function. Also, all random methods should have the seed parameter which can allow the user to reproduce the random numbers

I guess this one is fine being a function. rand_unitary(N) makes a unitary matrix so it should be the same level as the call method for Unitary(N). This looks good.


Typo in dependencies package name

Seems like there was a typo during prop-types package installation
You try to import prop-types package in source files, but there's only prop-type package available in dependencies

Thanks, published to 1.4.4


⚠ Beta Site has degraded performance

In c9a603b, Beta Site (https://beta.streamonaire.com) experienced degraded performance:

HTTP code: 200
Response time: 2975 ms

Resolved: Beta Site performance has improved in fddcc4d.


python310Packages.azure-eventhub: 5.9.0 -> 5.10.0

Description of changes
https://github.com/Azure/azure-sdk-for-python/releases/tag/azure-eventhub_5.10.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 176984 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.azure_event_hub
python310Packages.azure-eventhub
python39Packages.azure-eventhub


SimpleVectorIndex.load() is easy to be called more than once

index/simpleVectorIndex
func (s *Index) IsEmpty() (bool, error) {
	...
	err := s.load()
	...
}

func (s *Index) SimilaritySearch(ctx context.Context, query string, opts ...option.Option) (index.SearchResponses, error) {
	...
	err := s.load()
	...
}

The invocation of the load() function is very subtle, which easily leads to cases of repeated calls. Such as in the example.
We'd better make sure it's loaded only once.

Ok, added a task on the issue https://github.com/henomis/lingoose/issues/116

Fixed in https://github.com/henomis/lingoose/pull/123


Update view to find workshop staff

update this view https://amy.carpentries.org/workshops/workshop_staff/ to only use the "Instructor" (and "Trainer") awards.

@maneesha We have many places depending on the logic for determining if a person is an instructor. Until now this logic has been: Does the person have any of the badges: swc-instructor, dc-instructor, or lc-instructor?.
If I changed the logic to Does the person have a badge instructor, and an active Instructor Community Role then this logic (and underlying query) becomes quite complex.
I propose to use Does the person have an active Instructor Community Role, which should be simple enough.

Because the Instructor role requires an Instructor badge, this condition should work.


Riot settings: back button leads back to homepage systematically

To reproduce:

Be in an other tab than homepage
Open Riot settings
Hit the back "<-" button in the tool bar

Home page is displayed, instead of the tab where user was.
Note that if the back Android button is used, the good tab will be displayed.
In iOS, the good tab is opened after using this button.

Validated.


[Spelling alphabet] Add tests for the characters that mapped to multiple words

Currently, those mappings are not tested at all. So it is better for increasing code coverage

This won't make it into the cryptii project, as of now. However, we can bring your work into a new operation for ciphereditor. See #129 for more.


v4.1.1 - Messenger messages not being 'seen' by Miscord

Describe the bug
After having left 4.1.1 running for a bit I have an example of an instance of what I was suspecting was happening where the bot is not picking the odd message from messenger - there isn't even a mention of it on the log, it's as if it never saw it. I suspect it could be something about being idle, but there isn't much to go on.
Take these messages on Messenger. Logs are in UTC so the first log snippet shows that no message was seen at UTC 10:41 (which is 21:41 in the chat). But the message after (starting with Hmmm...) is seen by Miscord and is passed to Discord as usual.

The log:
[2018-10-13 10:31:52] … trace messenger › handleEvent › event
[2018-10-13 10:31:52]   { event: { threadId:<PHONE_NUMBER>627203, receiverId: 511162022 },
    type: 'readReceiptEvent' }
[2018-10-13 10:38:29] … trace messenger › handleEvent › event
[2018-10-13 10:38:29]   { event: { threadId:<PHONE_NUMBER>627203, receiverId:<PHONE_NUMBER>38056 },
    type: 'readReceiptEvent' }
[2018-10-13 10:41:13] … trace messenger › handleEvent › event
[2018-10-13 10:41:13]   { event: { threadId:<PHONE_NUMBER>627203, receiverId:<PHONE_NUMBER>17156 },
    type: 'readReceiptEvent' }
[2018-10-13 10:41:24] … trace messenger › handleEvent › event
[2018-10-13 10:41:24]   { event: { threadId:<PHONE_NUMBER>627203, receiverId:<PHONE_NUMBER>55661 },
    type: 'readReceiptEvent' }
[2018-10-13 10:43:29] … trace messenger › handleEvent › event
[2018-10-13 10:43:29]   { event: { threadId:<PHONE_NUMBER>627203, receiverId: 631847377 },
    type: 'readReceiptEvent' }

more read receipts and then
[2018-10-13 11:04:10] … trace messenger › listener › message
[2018-10-13 11:04:10]   { threadId:<PHONE_NUMBER>627203,
    attachments: [],
    authorId:<PHONE_NUMBER>47722,
    id: 'mid.$gAAXUUB7Kt4Nsnl5WqVmbRkN7I3vU',
    timestamp:<PHONE_NUMBER>665,
    message: 'Hmmm...depends what <snip> says, I\'m happy to do it then or wait, either is fine',
    stickerId: undefined }
[2018-10-13 11:04:10] ℹ info messenger › listener › Got a Messenger message
[2018-10-13 11:04:10] … debug messenger › getThread › Messenger thread cached
[2018-10-13 11:04:10] … debug messenger › listener › Got Messenger thread

Additional context
This is again on a large messenger group. I cannot replicate this on my testing channel after being idle.

Did you find the cause of this issue? I haven’t followed to see if anyone else saw the same.

Probably connection issues with libfb, it now checks if connection is not stalled


Saving to Download cart?  Nothing seems to happen

I tried saving utterances from 2 collections to the download cart, but the download cart was empty...

In the bottom picture above, clicking on any of the boxes does nothing at all.
Clicking on the only thing available to click on, the Video button, gives this error:

related? #348


Persian calendar

Resolved issue #8905 in GoToDate() methods in MudDatePicker
Description
resolves issue #8905
How Has This Been Tested?
I have tested it manually.
Type of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[ ] I've added relevant tests.

Hi.
Thanks, I really appreciate in helping with he Persian Calendar.
Would it be hard for you to add a unit test based on the #8905 repro (or own code)?

@ajahangard please understand that by providing a test for your fix you'll ensure that further work on the date picker will never ever break it again, at least not this aspect ;)

@henon @ScarletKuro ,
Hi, relevant test added:
PersianCalendarTest_GoToDate()
It test the gotodate functionality on persian calendar.


🐛 [PHONE AUTH] unknown status code : 17028 ! "SMS verification code request failed: unknown status code: 17028 Invalid request fields in play_integrity_token"

I've added the SHA-1 and SHA-256 to my firebase project and enabled the auth check with play integrity also checked the app name and SHA-1, SHA256 keys nothing seems to work and this error keeps on popping. I've redownloaded the google-service.json file also cleaned my project and recompiled it with every new update but nothing works.
My Code is
 void signInWithPhone() async {
      try {
        FirebaseAuth auth = FirebaseAuth.instance;
        await auth.verifyPhoneNumber(
            forceResendingToken: token,
            phoneNumber: "+92${widget.phoneController.text.trim()}",
            verificationCompleted: (credential) async {
              await auth.signInWithCredential(credential);
              setState(() {
                hello = "Logged In";
              });
            },
            verificationFailed: (verificationFailed) {
              setState(() {
                hello = "Error Occured $verificationFailed";
              });
            },
            codeSent: (codeSent, otp) {
              setState(() {
                hello = "Code sent";
                token = otp;
              });
            },
            codeAutoRetrievalTimeout: (codeAutoRetrievalTimeout) {});
        widget.controller.startLoading(false);
      } catch (e) {
print(e);
      }
    }

the error says

[SmsRetrieverHelper] SMS verification code request failed: unknown status code: 17028 Invalid request fields in play_integrity_token

and

Invoking original failure callbacks after phone verification failure for [My Phone Number], error - This app is not authorized to use Firebase Authentication. Please verify that the correct package name and SHA-1 are configured in the Firebase Console. [ Invalid request fields in play_integrity_token ]

Does anyone has any idea how to resolve this Issue

I am experiencing a similar issue, as I recently upgraded Fire Auth to version 4.4.1 and encountered an error.

Hi @hyderali0889, is this in debug or release mode? Can you also check the following StackOverflow links to see if any of the solutions stated in there work for you?
https://stackoverflow.com/questions/66848376/unknown-status-code-17028-a-safety-net-token-was-passed-but-no-matching-sha-25
https://stackoverflow.com/questions/46751766/this-app-is-not-authorized-to-use-firebase-authentication-please-verify-that-the/53513327#53513327

Hi @hyderali0889, is this in debug or release mode? Can you also check the following StackOverflow links to see if any of the solutions stated in there work for you? https://stackoverflow.com/questions/66848376/unknown-status-code-17028-a-safety-net-token-was-passed-but-no-matching-sha-25
https://stackoverflow.com/questions/46751766/this-app-is-not-authorized-to-use-firebase-authentication-please-verify-that-the/53513327#53513327

As Safety net's support is depreciated the first one is not the sol and my app is not on play store.

Hi @hyderali0889,
Please provide a minimal complete reproducible code sample along with steps to reproduce so that we can investigate this issue.
Please also provide the output of flutter pub deps -- --style=compact
Also, have you uploaded your debug token for app check?
Thank you


Is this repo dead?

I see there are other implementations of CLIP:

@Zasder3 have created a PyTorch lighting version to train the CLIP https://github.com/Zasder3/train-CLIP
researchers at UW, Google, Stanford, Amazon, Columbia, and Berkeley also create their training code https://github.com/mlfoundations/open_clip. open_clip seems to be quite active.

There is very limited activity in this repo. I wonder this repo is dead or would be deprecated?

This project is an open source implementation that allows you to use CLIP. The one you linked also allow you to train CLIP.

Source: https://github.com/mlfoundations/open_clip/issues/34#issuecomment-998389327


Additional events in webhooks

Hi! First of all, thank you very much for building this great integration for BTCPay Server :hugs:
On processing the webhooks it only listenens to the InvoiceSettled event at the moment which means that a few cases are not covered

it will only process if the payment settled normally
this means after transaction confirmed in a block which can take a few to 30+ minutes worst case (for on-chain transactions)
late payments not covered (expired invoices can be paid)
partial payments not covered (could have some note that it was partially paid)
expired invoices

Not sure if XF has some concept of order states so maybe not all usecases can or should be covered but you can see in our WooCommerce plugin how to cover all cases
You likely would not need all of it but I would at least additionally cover the case of an expired invoice paid late, which will not fire InvoiceSettled but rather a InvoiceExpired followed by an InvoicePaymentSettled
Let me know if you have any questions.
Thank you.

https://github.com/btcpayserver/xenforo/commit/8443ff5ba9138982b53c4d24b2baeae9dfe79d88


Helsinki May 2019

[x] reserve dates
[x] reserve room
[ ] announce
[x] team of instructors complete
[x] workshop website up
[ ] lessons distributed
[ ] helpers
[x] registration open
[ ] catering
[ ] registration closed
[ ] install instructions sent

Once registration is open please inform me and I will announce via Twitter.

@bast registration is now open feel free to advertise.

Super! I will advertise via Twitter.

Workshop Done with #215 :tada: .. closing.


Stop using signInWithRedirect

Starting June 18 2024 it will stop working apparently
https://firebase.google.com/docs/auth/web/redirect-best-practices

c967070 may have broken sign in. There's an error like credential-already-in-use or something like that.


Context Menus implemented.

Added the support for context menus.
I didn't write detailed docs but I did write some helpful comments that will help you to write detailed docs.
Q: How is this supposed to be used?
A: To make a context menu, create a file in interaction/context-menus/user||message folder. You can see the sample.js for the structure. In brief, you have to export a javascript object with the data key being an object with 2 values, name: For the name of your context menu and type: For the type of context menu (2 for user menu and 3 for message menu). And the execute key being a function that would be executed when the context menu is called.

And the interaction in the context menu's execute is of type ContextMenuInteraction.

Alright, this seems to be excellent new addition to our project!
I'm adding some comments and other bug fixes.

Alright for now, it seems good


Set release managers as CODEOWNERS for release-1.3

Setting up the release-1.3 branch, cf. https://github.com/istio/istio/issues/16201.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[x] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@rlenglet: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-presubmit-tests-release-1.3
d750c5b888c95472eac2455bab01e920f3413a75
link
/test integ-new-install-k8s-presubmit-tests-release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlenglet: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-presubmit-tests-release-1.3
d750c5b888c95472eac2455bab01e920f3413a75
link
/test integ-new-install-k8s-presubmit-tests-release-1.3

integ-mixer-k8s-presubmit-tests-release-1.3
d750c5b888c95472eac2455bab01e920f3413a75
link
/test integ-mixer-k8s-presubmit-tests-release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

You guys need to force merge this, it won't apply until after it is merged


Typeahead: Show all options when there's a default item set

When the Typeahead has a default value, the initial click into the component shows only the filtered items based on the initial value

The change with make it so when the Typeahead has an item, this item is not used to filter the initial set of results

Also, I renamed the prop defaultItem to just item. I was thinking about how the prop value is commonly used to set defaults, for example like in Textfield / Textarea, and felt this change in name might be more accurate.

Test Plan

Original functionality: https://gestalt.netlify.app/#/components/Typeahead

In the second example when you click in the Typeahead, only Label-4 is displayed

In the update, all labels should be displayed when Typeahead is clicked on despite item being set

https://deploy-preview-1067--gestalt.netlify.app/#/components/Typeahead

Approved from design side

@simkessy Hey Kessy, if you're going to change the name of the prop -codemod included- I suggest considering value. We should keep consistency across all components and most components use that naming for that specific funcitonality. The ones you mentioned, plus Searchfield, DatePicker, etc.
For our Gestalt users, having a consistent API is better so that they don't have to remember the specific naming of props for different components. value prop behavior should be predictable.
I think it's a good change, but I think we should go with value rather than item.

K:
Hey I was thinking value as well but my concern was that we were returning an object
So we'd end up with something like value.value or value.label
A:
What about options + value
SelectList uses options instead of data
Could you make item a string instead?
I’m checking SelectList;  Typeahead  is a searchable SelectList  so they should have more or less the same API. You can probably check the implementation there to use value (defaultItem) as a key to match it  in options (data)

I think the default option is still the only one showing.

nit change
could you keep Typeahead prefix on both or none of them? Just to stay consistent
import TypeaheadInputField from './TypeaheadInputField.js'; import Option from './TypeaheadOption.js';

Inside handleKeyNavigation

These lines. , you could just out a 0.

Flow cleanup here:

You can simplify handlers:

Can you give a use case for searchField = 'value'?  In my brain, this seems counterintuitive*, but I guess this prop is here for some reason, I would add an example of a use case with searchField = 'value'  Otherwise, I would remove it. *Because you are only going to search base on the displayed label, not the hidden value that the user doesn’t see.

findDefaultOption
remove the eslint disable there, just change the name of the argument to defaultOption

= id  is dead code

We ccan simplify this

I think the ref from the API is targeting the outer Box, try the solutions we've implemented in TapArea, Checkbox, RadioButton...

nit refactor

add forwardRef

check Checkbox, etc

on TypeaheadInputField
no need for if statement

nit

could you use IconButton here? play with size + padding to find the right ratio between icon size and total size.

no need for direction="row", it's the default value

darkMode

nit edge bug. https://www.loom.com/share/6fff552b3a90478eb68ee692c79bbec7

New changes LGTM!


Moon light setup

**aquacontrol version: 1.6.6
**Arduino IDE version: 1..8.12
**ESP32 Arduino core version:1.0.4
The Readme tells "Moon light settings can be adjusted in the channels area of the web-interface" but I can't figure out how. Maybe the problem lies between chair and computer, I can't find any setting related to moon light on this area of the web interface that I could change. It only shows the percentage of illumonation and a picture of the moon phase.  In the lower area I can change the channel names and colors. Can you clarify how the moon light setup is supposed to work?
Thanks for your help and this great project

It is indeed not so clear from the channels page.
The sliders on the channels page set the full moon output per channel.
The code just takes the full moon level you set and multiplies it with the percentage visible moon surface that is lit.
So:
If you put the first channel on 0.5% then this channel will be 0.5% x 100(full moon) = 0.5% at full moon.
At half moon it will be 0.5% x 0.5(half moon) = 0.25%.
At new moon it will be 0.5% x 0.0(new moon) = 0%.
Channels set to 0% will stay dark during the whole lunar cycle.
I hope this is clear.

I changed the label from bug to enhancement and a future commit will address this issue.

Hi, even reading all this I still have doubts how it works regarding the ON or OFF.
I can't see anywhere on the EDITOR to choose if is normal light or moonlight.
How really this works and I can setup specific timings for moonlight?
Thanks.


Error in README.md Lazy.nvim installation code

Description
In the code for Lazy.nvim installation, the setup function must be inside the table. At least, this what worked for me.
  {
    "kdheepak/lazygit.nvim",
    cmd = {
      "LazyGit",
      "LazyGitConfig",
      "LazyGitCurrentFile",
      "LazyGitFilter",
      "LazyGitFilterCurrentFile",
    },
    config = function()
      require("lazy").setup({})
    end,
    -- optional for floating window border decoration
    dependencies = {
      "nvim-lua/plenary.nvim",
    },
    -- setting the keybinding for LazyGit with 'keys' is recommended in
    -- order to load the plugin when the command is run for the first time
    keys = {
      { "<leader>gg", "<cmd>LazyGit<cr>", desc = "LazyGit" }
    }
  },

lazy = false also should work instead of the keybind.
Desktop (please complete the following information):
- nvim --version:
NVIM v0.9.4
Build type: RelWithDebInfo
LuaJIT 2.1.1692716794
:checkhealth
OS Info:
{
machine = "x86_64",
release = "6.5.0-28-generic",
sysname = "Linux",
version = "#29~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Apr  4 14:39:20 UTC 2"
}

I had the same issue with readme installation.
return {     "kdheepak/lazygit.nvim",     cmd = { "LazyGit", "LazyGitConfig", "LazyGitCurrentFile", "LazyGitFilter", "LazyGitFilterCurrentFile" },     dependencies = { "nvim-lua/plenary.nvim" },     keys = {         { "<leader>lg", "<cmd>LazyGit<cr>", desc = "LazyGit" }     } }
This resolved it.


GRU doesn't work for A2C

First, great work!!
I've decided to "upgrade" and use your A2C implementation instead of your A3C's, but I was surprised to see in your code that the changes aren't minor as I thought they would be. For example, your default is the FF version and not LSTM (or GRU in this version). I tried running the code on Breakout with --recurrent-policy and the model didn't seem to learn anything (works without it though). Are there an other parameters that I should change if I want to use it? e.g, maybe num-stack should be changed to 1?

Yeah. I also failed to make GRU policy stable in all environments. OpenAI baselines implementation has exactly the same problem. I'm not sure whether a different value for num-stack will change a lot. I guess that it requires a larger hyper-parameters search.
For a recurrent policy only PPO works well.

In that regard, why is a recurrent policy currently not supported for ACKTR?

@timmeinhardt it would take some extra work, since KFAC approximation is different for every type of layers.
For RNNs it requires something like this:
https://openreview.net/forum?id=HyMTkQZAb
I will have time to add it myself probably only in the late September.

@ShaniGam there was a bug in recurrent policy. Try again.

Still not working :/

Worked for me by increasing num_steps to 20.  Still needs more hyper-parameter tuning as its super unstable (probably the lr needs to come down).


Minecraft 1.18 support

The protocol changed (significantly?) in 1.18.
Some other proxies have updated already:

https://github.com/GeyserMC/Geyser
https://github.com/GeyserMC/MCProtocolLib/commits/master

... need to update this too. will have a look at doing it

I'll update Gate to 1.18 when I find the time. I usually look at what Velocity has changed as they are quite fast.
The updates that need to be implemented in Gate are will be this changelog: https://github.com/PaperMC/Velocity/compare/311133a4d3342e81ac99fafd8955e1641524d33e...dev/3.0.0

1.18 support added in https://github.com/minekube/gate/commit/d1b15b0b033325b5786ed536458fa3cbb5536d8d


Attribute NonSerialized is not working as intended

Attribute NonSerialized is not working as intended
The documentation preconize the use of [System.NonSerialized] to allow a field to be ignore by weaver on serialization. It is not working at all due to not be taken in account in Writers.cs::GenerateClassOrStructWriterFunction && Readers.cs::DeserializeFields
How to reproduce the issue, step by step
Create a struct used in a SyncList. Add a special type who can't be serialized by weaver, add the attribute [System.NonSerialized] :
`
struct Test {
int m_Test;
[System.NonSerialized]
ComplexObject m_FailWeaver;
}
`
Expected behavior
The field should be ignored by Weaver and do not cause errors
Desktop (please complete the following information):

OS: [e.g. Windows, MacOS]
Build target: [e.g.  Android, webgl, standalone, iOS]
Unity version: [e.g. 2017.4]
Mirror branch: [e.g.  master, 2018]

Additional context
I have fixed the bug this way in Writer.cs (line 140) :
                if (field.IsStatic || field.IsPrivate || field.Attributes.HasFlag(FieldAttributes.NotSerialized))                     continue;
and Readers.cs (line 373)
                if (field.IsStatic || field.IsPrivate || field.Attributes.HasFlag(FieldAttributes.NotSerialized))                     continue;

Seems like this is not viable on this version. Closing...


Naming Schema for multiple PDU

I own multiple PDUs
Currently the naming schema for entities is something like this:
switch.outlet_1
If i add a second or more pdus entities for same outlet (it's the same for other readings available from pdus) are named
switch.outlet_1-2
switch.outlet_1-3
and so on..
It's very very confusing

I feel your pain, but currently I don't intend to invest a substantial amount of time in this area. I'd happily accept contributions, but care should be taken not to break existing setups.
However, PDUs appear as devices to Home Assistant, listing all their entities under /config/devices/device/<ID>. You can give names to entities or even rename entity IDs from there.
By default, names for outlets set up in the PDU's management interface are used as entity names. "Outled " is just a fallback for unconfigured devices.

If you give a nane to the PDU in http panel then the PDU Is named the same also in Home Assistant.
Problem solved :)


Fix VST3 assertion condition on set_io_mode() (must be before "initialize")

Fixes https://github.com/DISTRHO/DPF/issues/466

Sorry, created a PR for wrong branch.


Cursors lose sync when using "Ctrl+Arrows" during "Change all occurences (Ctrl+F2)"

Issue Type: Bug

Select a word and Ctrl+F2 on it.
Move to left or right a couple of times using Ctrl+Arrow keys. Make sure to leave the original selection
Come back to original selection using plain arrow without using Ctrl.
Cursors will lose location sync and edit different places of the original selection.

VS Code version: Code 1.27.2 (f46c4c469d6e6d8c46f268d1553c5dc4b475840f, 2018-09-12T16:17:45.060Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4700HQ CPU @ 2.40GHz (8 x 2394)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.89GB (8.66GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (4)

Extension
Author (truncated)
Version

vscode-intelephense-client
bme
0.8.8

dart-code
Dar
2.19.0

flutter
Dar
2.19.0

php-debug
fel
1.12.6

This is as designed. The cursors move according to your instructions. When you press arrow left/right, the cursors move by 1 character. When you press ctrl+arrow left/right, the cursors move by 1 word. In other words, the cursors move as you want them to move, they are not synced in any special way, they are not tied up to the initial selection in any way.

Thanks for the explanation. Coming from Visual Studio Home, I'm having difficulty adapting (works chaotic when compared to Ctrl+R+R). Especially when the selection edited has some of its corresponding parts out of the visible page, this causes plenty of unintended edits during speed coding (I accidentally move out, come back, edit, all visible occurences look ok, however one occurence out of the visible area has a typo, which leads to an error. Maybe ok for compiled languages but cause run-time errors on script languages. And also blocks workflow, simple renaming turns into typo hunting.).

@guneyozsan I'm not familiar with the keybinding Ctrl+R+R from Visual Studio Home, perhaps that has a name that I can search online and learn about it. Perhaps someone else already has asked for that feature in one of the existing issues?

@alexandrudima Sorry my bad. Ctrl+R+R is the binding for Refactor.Rename. Reference: https://docs.microsoft.com/en-us/visualstudio/ide/default-keyboard-shortcuts-in-visual-studio?view=vs-2017

@guneyozsan No problem. We also have rename, but the keybinding is F2. We have rename support out-of-the-box for JavaScript and TypeScript, but you need to install extensions that add this support for other programming languages.