Crash Class::NumTypeArguments()

From this log:
FAILED: dartk-vm release_simdbc64 standalone_2/io/raw_socket_write_destroy_test
Expected: Pass
Actual: Crash

--- Command "vm_compile_to_kernel" (took 396ms):
DART_CONFIGURATION=ReleaseSIMDBC64 /b/s/w/ir/cache/builder/sdk/pkg/vm/tool/gen_kernel --no-aot --platform=xcodebuild/ReleaseSIMDBC64/vm_platform_strong.dill -o /b/s/w/ir/cache/builder/sdk/xcodebuild/ReleaseSIMDBC64/generated_compilations/dartk/tests_standalone_2_io_raw_socket_write_destroy_test.dart_3/out.dill /b/s/w/ir/cache/builder/sdk/tests/standalone_2/io/raw_socket_write_destroy_test.dart --packages=/b/s/w/ir/cache/builder/sdk/.packages -Ddart.developer.causal_async_stacks=true

exit code:
0

--- Command "vm" (took 03.000552s):
DART_CONFIGURATION=ReleaseSIMDBC64 xcodebuild/ReleaseSIMDBC64/dart --hot-reload-test-mode --short_socket_read --short_socket_write --sync-async --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.packages /b/s/w/ir/cache/builder/sdk/xcodebuild/ReleaseSIMDBC64/generated_compilations/dartk/tests_standalone_2_io_raw_socket_write_destroy_test.dart_3/out.dill

exit code:
-6

stderr:
===== CRASH =====
version=2.1.0-edge.f721d52163bfcf6162e62af810d6afd2fdb6d741 (Wed Nov 14 02:48:03 2018 +0000) on "macos_dbc"
si_signo=Segmentation fault: 11(11), si_code=1, si_addr=0xc1
Dumping native stack trace for thread f03
  [0x00000001098b0046] dart::Class::NumTypeArguments() const
  [0x00000001098b0046] dart::Class::NumTypeArguments() const
-- End of DumpStackTrace

--- Re-run this test:
python tools/test.py -m release -a simdbc64 -n dartk-reload-mac-release-simdbc64 --write-logs standalone_2/io/raw_socket_write_destroy_test

No coredump is available.
So far I was unable to reproduce this on vm1480-m4
/cc @mraleph

So far I was unable to reproduce this on vm1480-m4

Neither am I on the MBP with a 100 repeats.

DBC is obsolete.


Deferring a block containing a static variable definition should share the same static variable at all insertion points?

Done in 94527acdcd73aa180ba10fc0c91f9073d7abf4db
Still not 100% but seems wise


Meters Resetting at 10pm

I couldn’t find a setting for reset time but is anyone else finding the values pulled into HA reset at 10pm gmt every night?
It’s not a problem per se but is frustrating for my dashboards in HA due to the reset not happening at midnight. Am I missing something or is this something others see?
you can see from the image the reset, I checked and this seems to always happen at 10pm which makes me think it’s a setting somewhere?

Closing as the meters resetting seems to have stopped happening now, not sure what it was but it is now working.


[WIP][QUESTIONS][ILVerify]Report "Class implements interface but not method"

Experiment issue 6203
I'm working on this issue and i've got some questions.
/cc @jkotas @MichalStrehovsky

close this tmp PR created only for questions. Thank's guys!


cargo-wasix as the successor to cargo-wasi

cargo-wasi is being archived, so users need a replacement.
cargo-wasix could be what we should use and recommend instead. But it currently requires/install the wasix-libc as well as an old Rust toolchain. This may not be desirable, and is an issue for packaging.
Would it be reasonable to only download the wasix components when actually compiling to wasix? And maybe provide a cargo wasi command for people who need a maintained version of cargo wasi?

Looks like it currently also requires wasmer to be present.
And cargo wasix build doesn't work when Rust was not installed with rustup.
Fixing these little things would also be good in order to recommend cargo-wasix as the replacement for cargo-wasi.

Hey @jedisct1 , at the moment cargo-wasix is geared towards WASIX.
It uses the wasm32-wasmer-wasi target by default, runs a wasm-opt pass with the --asyncify enabled (because WASIX requires it for fork/exec), and as you've noticed, currently requires rustup and uses wasmer as the default runtime.
The rustup dependency is something we'd like to get rid of anyway, and making the runtime configurable was also always a target and wouldn't be hard.
The main challenge would be deciding between regular wasm32-wasi and WASIX targets without regressing the user experience.

I  general we'd definitely be open to making cargo-wasix also fill the shoes of cargo-wasi, as long as we can resolve the above in a satisfactory way.
One option would be defaulting to WASIX, but offering a flag / env var / custom Cargo.toml metadata to use wasm32-wasi instead.

Could it install a cargo-wasi command in addition to cargo-wasix?

Duh, that's much more sensible.
It can be just the same binary (copied/symlinked as cargo-wasix and cargo-wasi), and we detect what to do based on the command name.
We'll tackle the rustup and configurable engine ourselves, but we'll probably be hard-pressed to find cycles for the cargo-wasi compat mode, and would wait for an outside contribution.


In-Heap caching, Cache API and JCache support [JIRA: CLIENTS-532]

As a KV-store it would be great if standard Java APIs could be supported, e.g. the JCache API
Background: I am working on http://cache2k.org and plan to integrate Riak as a secondary storage provider. This will be a big technical challenge.
The idea of this issue is to get some more opinions on it and see what directions make sense. In particular:

How this complements the existing java client? Is JCache something that is planed within the Riak client?
What is the benefit? Is there a (technical) use case? E.g. porting/migrating JCache based applications on Riak
Areas where there is an "impedance mismatch" and how to overcome this
do applications use in-heap caching, like Google Guava on top of the Riak java client?

Hi @cruftex,
This is the first JCache request I've heard so I'll try my best.

How this complements the existing java client? Is JCache something that is planed within the Riak client?

JCache is not something that's planned, we love to see community involvement though! As far as complementing the client, it sounds like it would be a library that uses the Riak Java client as a dependency, not an addition to the client.   We do have a Redis add-on coming to Riak in the future, but that's to be a cache to Riak itself: http://basho.com/products/redis/.

What is the benefit? Is there a (technical) use case? E.g. porting/migrating JCache based applications on Riak

Not sure, you made the request :)  One benefit would be scaling your cache safely more than Redis or other implementations could. Porting applications would be another, like you said.

Areas where there is an "impedance mismatch" and how to overcome this?

One area where you would run into a mismatch would be the notion of siblings / conflict resolution, which is a side effect of being eventually consistent and distributed.  Eventual consistency + being distributed aren't a bad thing, they allow us to scale much more than other DB's, you just have to work with the trade offs.
These tradeoffs do conflict with some of the JCache spec though:
2.3.1. Default Consistency
When using the default consistency mode, most cache operations are performed as if a locking
mechanism exists for each key in a Cache. When a cache operation acquires an exclusive read and
write lock on a key all subsequent operations on that key will block until that lock is released. The
consequences are that operations performed by a thread happen-before read or mutation operations
performed by another thread, including threads in different Java Virtual Machines.
This can be understood as a pessimistic locking approach. Lock, mutate and unlock.

(Java™ Caching API - JSR107 Expert Group - Dec 16, 2013)
Most of the operations rely on these CAS operations, so any implementation wouldn't hold up to the spec 100%.  You could use last-write-wins (and possibly lose data), or write a conflict resolver for your classes to get around siblings/conflicts though, but you will have to know about the trade offs.

Do applications use in-heap caching, like Google Guava on top of the Riak java client?

Possibly, but I've not heard of it being used like this before.
Does this answer your questions?
Thanks,
Alex


Fix building on non-macOS Posix targets

Thanks for the PR! Will be merging.

A new build has been released, should be available on dub as 0.6.1 soon!


pkg/repotest dumps excessive amounts of logs during go test

Looking at a recent CI run...
https://app.circleci.com/pipelines/github/helm/helm/2735/workflows/a42f755d-0972-4949-96c6-3f5301eb3585/jobs/14305
Informational logs should not be displayed during a test run unless it is relevant to the failing test. During a test run it appears the repotest logs are displayed regardless if the test passed or failed, suggesting it is printed to stdout.
The excessive verbosity of the logs coming from repotest makes it hard to determine when and where a test fails. In many cases it masks the error because the amount of logs dumped to the screen usually go above most terminal's scroll buffer limit (usually 1000-2000 lines), resulting in the failing test case being hidden to the developer.

This looks like it may be the issue: https://github.com/helm/helm/blob/eb99434597d230a2106b22f15ac1e250ca5592f6/pkg/repo/repotest/server.go#L150


[$1000] Web -  Thread - No space between message and compose box when sender leave thread

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

go to any chat
send any message and click on reply in thread option
send message in thread
from receiver side go to thread
from sender side leave thread

Expected Result:
Should be some space between message and compose box
Actual Result:
No space between message and compose box
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.55-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/654675db-7d21-44ce-9e23-44bde88b3576
https://github.com/Expensify/App/assets/115492554/48b77b89-a0cf-4d0d-a40e-25e0ca4fa1cd
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
**Slack conversation:**https://expensify.slack.com/archives/C049HHMV9SM/p1691496184324319
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01007c19ea2483982e
Upwork Job ID:<PHONE_NUMBER>377553408
Last Price Increase: 2023-08-29

Proposal
Please re-state the problem that we are trying to solve in this issue.
No margin/padding between last message and composer when sender leaves thread
What is the root cause of that problem?
We are not rerendering the ReportActionsView on particinpants change, that won't rerenders ReportActionsList which is responsible for adding the bottom padding if required when we are not showing the RecipientLocalTime. That is causing this issue and not adding bottom padding dynamically.
https://github.com/Expensify/App/blob/d4490726ca1f6cc340b3c03044fd8c2ca350fdb8/src/pages/home/report/ReportActionsList.js#L166
What changes do you think we should make in order to solve the problem?
We need to add a check either for participantAccountIDs or participants length within arePropsEqual function here. That will rerender the component if the lengths are not same and allow the bottom padding if needed.
https://github.com/Expensify/App/blob/d4490726ca1f6cc340b3c03044fd8c2ca350fdb8/src/pages/home/report/ReportActionsView.js#L379

I don't see the pusher message in the console but something seems weird, when I put a breakpoint, one of the participant of the parent report is removed but not the thread report. I believe this one is backend

I'll get some engineering eyes

When the other person left the thread we are not showing the timestamp, in this case we need to provide some space/gap between last message and composer. Currently last message and composer don’t have any gap for this scenario.

Sure. @shawnborton, any preference on the size of that space? 😁

Just sharing the issue screenshot

We should take a consistent look at this everywhere, not just threads.
I think a good rule would be that if there is no timezone information, there should always be 8px of margin above the compose box.
If there is a timezone information, we should display 8px of margin above and below the timezone.
And this should be the case for all chats as a consistent, global style - not specific to threads or group chats or anything like that.

We already have the logic for that(show space when timezone isn't been shown) but specific to this scenario we are not rerendering the component when participants get updated. Showing timezone depends on that factor too. cc: @Gonals

Given the info, marking this as external!

Sorry got caught up in higher priority reviews today, will review the proposals tomorrow!

@Pujan92's proposal LGTM! It has the correct RCA and the solution makes the most sense to me (as the logic for adding padding is already in ReportActionsList, it's just not running).
:ribbon::eyes::ribbon: C+ reviewed

@Pujan92's proposal LGTM! It has the correct RCA and the solution makes the most sense to me (as the logic for adding padding is already in ReportActionsList, it's just not running).
🎀👀🎀 C+ reviewed

Sounds good!

@tienifr Sorry, I did have a look over your proposal and gave it a sort of stealth review when I said:

the logic for adding padding is already in ReportActionsList, it's just not running

I'm erring on the side of we probably added padding there for good reason, and your proposal was to move it to ReportActionCompose. I also don't think re-rendering on report.participantAccountIDs is necessarily a particularly bad thing in this case.

@jjcoffee PR is ready for review!

@Pujan92 Thanks, reviewing tomorrow!

@jjcoffee are you able to get to this?
Reassigning a BZ member, I am out on sabbatical

@jjcoffee friendly reminder on the checklist so that we can pay on Monday.

[x] The PR that introduced the bug has been identified. Link to the PR: N/A - padding was already there, the component just wasn't re-rendering.
[x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1694701144755569
[x] Determine if we should create a regression test for this bug. I don't think this is impactful enough to need a regression test
[x] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

I think we are all done here, right?

Just need to pay. @Pujan92 @gadhiyamanan can you apply to the job? https://www.upwork.com/jobs/~01007c19ea2483982e

@puneetlath applied, thanks!

Applied :)

All paid. Thanks everyone!


Show formatted instance variables when available...

Love how motion_print nicely formats many classes.
One thing I've always wanted was to have better output of the instance variables that are shown by default when you output a class.  For example, doing NSApplication.sharedApplication.delegate gives something like
#<AppDelegate:0x100c9f8a0 @main_window=#<NSWindow:0x105f5af80> @main_controller=#
<MainController:0x105f709a0> @toolbar_item_file_title=#<NSToolbarItem:0x10b09d270>
@tool_bar=#<NSToolbar:0x10afd2f90> @appearance_observer=#<__NSObserver:0x100d55850>>

What I would like to see is something like this (colorized of course):
AppDelegate
  :@main_window               => #<NSWindow:0x105f5af80>
  :@main_controller           => #<MainController:0x105f709a0>
  :@tool_bar                  => #<NSToolbar:0x10afd2f90>
  :@appearance_observer       => #<__NSObserver:0x100d55850>

So I've created the attached PR to implement this.  It doesn't effect any classes that implement the motion_print hook.  It also colorizes differently any instance variable that has public accessor method; makes it easy to know whether or not you can directly inspect that variable or not.
Hope you find it useful...

This is really cool! I think we should include the memory address of the top object in the output if possible.

Ha. I actually had it that way, and then I had to test an ever changing memory location, and I ran out steam for the day...you think it's really necessary?

I'd like motion_print to not lose any information that's being presented to the user in a puts. You should be able to do a regular expression match on the output in the tests like this:
'expected string'.match(/your regex/).should.not == nil

Sorry, just saw your comment with the regex.  The new commit did it without a regex, but it works...

@markrickert, the code has been updated to show the address of the object.  If there is anything else in this code needs changing, let me know.

I was about to ask you about the different colored variables but then read the PR closer... VERY cool!
Great job on this!

Version 1.2.0 released.

I was always annoyed not easily knowing which instance variables I could directly access, so thought it would be cool to add.
Thanks for merging the PR.

I'm seeing some inconsistencies in indentation now, as well as some errant commas in the output. Any idea on what might be going on here?

At the moment i'm not seeing that issue.  But it looks like your looking at a hash, not an object.  And I see the instance symbol (the @) is missing on the mis-formatted ones.  What's different about those variables?
Can't take a look closely right now, but will try later.


isogram exercism cpp challenge

mkdir build
cd build
cmake -G "Unix Makefiles" ..
make

What question number is this?

@mralanlee https://exercism.io/my/solutions/e661e6161afc4d9e9d81aff4cc0e29e2
My co-worker pointed me towards exercism. The tests are visible and allows local compiling. MUCH faster than leetcode cpp work.


New Unifi Network template.

This template is meant for monitoring Unifi network devices using Unifi Network API. Special thanks who wrote and maintain this wiki page, this guide helped me for realizing this template.
Added this new template and Ganeti on main README.md.

I tried importing and had several uuid errors repeated:

@WgkLink This problem show up on 6.4 template version. With last commit I have fixed all duplicated uuid and now I can import template on Zabbix 6.4.1 version without any issue.

Now imported, tks.


Kwxm/machines eval builtins

Here's a document about some of the issues that have surfaced wrt evaluation of unsaturated builtins, including Roman's recent point about higher-rank builtins (at the end).  I thought I'd better write some of this down before we forgot what's going on; also I'm not entirely sure how to proceed with the CK machine.
Feel free to comment/edit/add stuff.

I think the conversation is evolving in several different places so apologies for chiming in with comments on already covered stuff.

That's fine: it's definitely quite difficult to follow what's going on though with this non-linear conversation and further comments in the PRs for the machines.

I'm going to merge this so that other people can have a look.  Feel free to keep on commenting.


Refactor relations API

Codecov Report

Merging #31 (a4764c4) into main (3e38154) will decrease coverage by 0.06%.
The diff coverage is 94.87%.

:exclamation: Current head a4764c4 differs from pull request most recent head 1fea01a. Consider uploading reports for the commit 1fea01a to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   97.66%   97.61%   -0.06%
==========================================
  Files          79       79
  Lines        3300     3306       +6
==========================================
+ Hits         3223     3227       +4
- Misses         77       79       +2

Impacted Files
Coverage Δ

asu/settings/apps.py
100.00% <ø> (ø)

asu/utils/openapi.py
80.00% <66.66%> (-3.34%)
:arrow_down:

asu/auth/views.py
97.77% <92.85%> (-0.73%)
:arrow_down:

asu/auth/schemas.py
78.84% <100.00%> (-0.40%)
:arrow_down:

asu/auth/serializers/actions.py
99.29% <100.00%> (+0.01%)
:arrow_up:

asu/auth/urls.py
100.00% <100.00%> (ø)

tests/test_auth.py
100.00% <100.00%> (ø)


Create Audaspace nodes (like Sverchok)

Hi Nexyon.
I would like to create AudaSpace nodes with Python, like Sverchok did for geometry.
Is this possible?
I guess almost yes because, in the docs, most parameters for class methods are "standard" types (like int or float), but I can't figure out how would I connect return types such as "factory" and so.
Thanks in advance for any help.

https://github.com/neXyon/audionodes ;)

You're awesome!

As far as you know, tell me, is there any limit on what can Python do in Blender?
Take this seriously.

I mean the question


Update i2c.cc for node v4.0.0+ compatibility

Buffer::New() constructor changed moving into node v4.
This is the quickest and dirtiest way to make it compatible with all.
NOW it's compatible with node > 0.12.0 :)
Updating patch version to comply with semver rules.

Compiles for me.
$ node --version
v5.3.0

Any thoughts, comments, suggestions?

I mentioned this in another pr, but i'm looking for a solution that uses NaN https://www.npmjs.com/package/nan. Otherwise these problems are going to keep coming up.

Yes, but in the meantime, how about a quick official fix so everyone does not have to download and compile their own version,
Secondly, why not just continuely update rather than support 0.8x for eternity.  We're up to 5.0. it's time to upgrade.  people can choose to grab old packages if they need old support.

At this point I don't feel comfortable accepting a temporary fix. Many people running embedded computers are running older versions of node.

I'm not trying to argue here, but that's LITERALLY what "+#if( NODE_MAJOR_VERSION >= 4 )" is for.To support those running older versions. Addition, in package.json, the engines stanza prevents older versions from upgrading.
There are safety measures in place, we should take advantage of them.

I get that, but like I initially said, it's a hack and doesn't protect against future issues. Things will likely change again, and I don't want to add additional version matching logic. All of this is safely dealt with using NaN.


return exact location of a tweet

ever considered developing an algorithm to triangulate a tweet to a specific location?
algorithm:start with a city > chose different geo circles that cover the city > identify in which circle's intersection the tweet appears > chose new circles that cover the intersection area > repeate step 3 > repeate until u have a precise location.

That's an analysis feature, not scraping


Terminate function issue

Expected Behavior
terminate function stops and deletes all related docker volumes
Current Behavior
Issue while removing docker volumes
~/eth-docker$ ./ethd terminate
Stopping eth-docker_consensus_1 ... done
Stopping eth-docker_execution_1 ... done
Removing eth-docker_consensus_1 ... done
Removing eth-docker_execution_1 ... done
Removing network eth-docker_default
Error: No such volume: eth-docker_besu-eth1-data
eth-docker_jwtsecret
eth-docker_teku-data

~/eth-docker$ docker volume ls
DRIVER    VOLUME NAME
local     eth-docker_besu-eth1-data
local     eth-docker_jwtsecret
local     eth-docker_teku-data

Steps to Reproduce
git clone https://github.com/eth-educators/eth-docker.git && cd eth-docker
mv default.env .env
./ethd cmd build --pull
./ethd up
./ethd terminate
docker volume ls

Context (Environment)
Ubuntu 22.04 (Jammy Jellyfish)
Docker 20.10.16
Docker-compose 1.29.2

Fun one. Thanks for finding it! This came in with a lint pass. Thanks also for the PR!


Move status message to the ISE status bar

Because we're getting more and more icons on top of the Project Explorer Add-In, I would suggest to move the status message to the ISE status bar.

If you mean the global ISE status bar, I'm not sure if it's possible without hacking - I think plugins can do what they like inside their own tab, but not outside it. I can see on the ISE Object Model Hierarchy there is StatusText property, but it is read-only.

Descoped.


Add faking system to make testing easier

Am curious on your thoughts here for how this'll work, since I'm thinking we'll want similar in https://github.com/neighbourhoodie/adonis-kafka-v6


schedulerV3(ticdc): burst add table in a batch way to delay resource allocation

What problem does this PR solve?

Issue Number: close #6828
What is changed and how it works?
add batchSize to the basicScheduler, each tick add table no more than the batch.
Check List
Tests

Unit test
Manual test (add detailed scripts or steps below)

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`

/run-all-tests

/run-all-tests

/merge

/run-leak-test
/run-verify-ci

/run-verify-ci


Could you please tell me the gpu edition used in your CAA search?

Hi, I found there is no NAGA-II search code relased, so I reimplemented by myself. I followed the direction in your paper, used pymoo, set the search paramater as in your paper, and used 3 2080Ti GPU. But I found that my search time consumption on CIFAR-10 (more than 10 days on 3GPU) is much more than that the search time reported in your paper (3GPU/d). Did you mean by 3GPU/d that you searched on 3GPU and finished in 1 day? Is that because your gpu is much faster than mine? Could you please tell me the gpu edition you used in your CAA search?

The speed is determined by many factors.

2080Ti has only 11G memory but P100/V100 has 16G. It means the batch-size can be smaller if you use 2080Ti. I use V100 in the experiments.
If the installed torch is accelerated by cudnn.
the hyper-params used in NAGA-II implementation.

We had a lot of problems reproducing the paper, can you provide NAGA-II search code?

Hi, I found there is no NAGA-II search code relased, so I reimplemented by myself. I followed the direction in your paper, used pymoo, set the search paramater as in your paper, and used 3 2080Ti GPU. But I found that my search time consumption on CIFAR-10 (more than 10 days on 3GPU) is much more than that the search time reported in your paper (3GPU/d). Did you mean by 3GPU/d that you searched on 3GPU and finished in 1 day? Is that because your gpu is much faster than mine? Could you please tell me the gpu edition you used in your CAA search?方便加个联系方式交流一下吗

Sorry, there is no plan to open the search code till now.
You can refer to pymoo and MixPath to implement the NAGA-II search. If you have any other problems during reimplementing the CAA, feel free to put questions here.

We had a lot of problems reproducing the paper, can you provide NAGA-II search code?

My reimplementation is very far from perfect, but if you like, I can share my code through e-mail (please tell me your e-mail address), and I will be happy to talk about these problems.

We had a lot of problems reproducing the paper, can you provide NAGA-II search code?

My reimplementation is very far from perfect, but if you like, I can share my code through e-mail (please tell me your e-mail address), and I will be happy to talk about these problems.

Can you send me a code for reference?

We had a lot of problems reproducing the paper, can you provide NAGA-II search code?

My reimplementation is very far from perfect, but if you like, I can share my code through e-mail (please tell me your e-mail address), and I will be happy to talk about these problems.

OK，thank you ! my e-mail<EMAIL_ADDRESS>

We had a lot of problems reproducing the paper, can you provide NAGA-II search code?

My reimplementation is very far from perfect, but if you like, I can share my code through e-mail (please tell me your e-mail address), and I will be happy to talk about these problems.

Can you send me a code for reference?

Please tell me your e-mail, I will send to you soon

We had a lot of problems reproducing the paper, can you provide NAGA-II search code?

My reimplementation is very far from perfect, but if you like, I can share my code through e-mail (please tell me your e-mail address), and I will be happy to talk about these problems.

Can you provide your email address? I'd like to ask you some questions about the NSGA2 code you provided

We had a lot of problems reproducing the paper, can you provide NAGA-II search code?

My reimplementation is very far from perfect, but if you like, I can share my code through e-mail (please tell me your e-mail address), and I will be happy to talk about these problems.

Can you provide your email address? I'd like to ask you some questions about the NSGA2 code you provided

<EMAIL_ADDRESS>

Sorry, there is no plan to open the search code till now.
You can refer to pymoo and MixPath to implement the NAGA-II search. If you have any other problems during reimplementing the CAA, feel free to put questions here.

Now, I'm having some problems with my experiment, why is res.F and res.X always None, no search results. Can you tell me what caused this?

We had a lot of problems reproducing the paper, can you provide NAGA-II search code?

My reimplementation is very far from perfect, but if you like, I can share my code through e-mail (please tell me your e-mail address), and I will be happy to talk about these problems.

Can you send me a code for reference?

Please tell me your e-mail, I will send to you soon

Hello. I am recently implementing this method, could you share your codes with me? I major in evolutionary algorithms and neural architecture search.

We had a lot of problems reproducing the paper, can you provide NAGA-II search code?

My reimplementation is very far from perfect, but if you like, I can share my code through e-mail (please tell me your e-mail address), and I will be happy to talk about these problems.

Can you provide your email address? I'd like to ask you some questions about the NSGA2 code you provided

<EMAIL_ADDRESS>
<EMAIL_ADDRESS>

Hi, I found there is no NAGA-II search code relased, so I reimplemented by myself. I followed the direction in your paper, used pymoo, set the search paramater as in your paper, and used 3 2080Ti GPU. But I found that my search time consumption on CIFAR-10 (more than 10 days on 3GPU) is much more than that the search time reported in your paper (3GPU/d). Did you mean by 3GPU/d that you searched on 3GPU and finished in 1 day? Is that because your gpu is much faster than mine? Could you please tell me the gpu edition you used in your CAA search?

请问可以要一份复现代码吗<EMAIL_ADDRESS>十分感谢

Hi, I found there is no NAGA-II search code relased, so I reimplemented by myself. I followed the direction in your paper, used pymoo, set the search paramater as in your paper, and used 3 2080Ti GPU. But I found that my search time consumption on CIFAR-10 (more than 10 days on 3GPU) is much more than that the search time reported in your paper (3GPU/d). Did you mean by 3GPU/d that you searched on 3GPU and finished in 1 day? Is that because your gpu is much faster than mine? Could you please tell me the gpu edition you used in your CAA search?

Hello, I would also like to learn your reproduction code? Could you send me a copy,
<EMAIL_ADDRESS>Thank you very much!

Hi, I found there is no NAGA-II search code relased, so I reimplemented by myself. I followed the direction in your paper, used pymoo, set the search paramater as in your paper, and used 3 2080Ti GPU. But I found that my search time consumption on CIFAR-10 (more than 10 days on 3GPU) is much more than that the search time reported in your paper (3GPU/d). Did you mean by 3GPU/d that you searched on 3GPU and finished in 1 day? Is that because your gpu is much faster than mine? Could you please tell me the gpu edition you used in your CAA search?

Hello,i would also like to learn your reproceduction code about CCA,i am also a adversarial menthod learner.Could you send me a<EMAIL_ADDRESS>you very much.


Extend test case for reused PEM_ASN1_read_bio

This is related to #22780, simply add test cases
for the different failure modes of PEM_ASN1_read_bio. Depending on whether the PEM or the DER format is valid or not, the passed in CRL may be deleted ot not, therefore a statement like this:
reused_crl = PEM_read_bio_X509_CRL(b, &reused_crl, NULL, NULL);
must be avoided, because it can create memory leaks.

Checklist

[ ] documentation is added or updated
[x] tests are added or updated

I've updated this PR with a fix for #23713 and added test cases for reused CRL with refcount > 1

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 92 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 123 days ago

This pull request is ready to merge

Merged to all the active branches. Thank you for your patience.


V2 - Few of the URL formats are not accepted while creating Organization

Prerequisite

Create a CLA group with CCLA enabled
Add github repository for the CLA group
Generate template

Steps to Follow

Login to Github as corporate contributor
Navigate to the repository used in prerequisite
Create PR
CLA check fails
Click on CLA NOT SIGNED
Contributor is redirected to Contributor Console
Click on Proceed as a Corporate Contributor
Click on + Click Here button in drop down in Select Company screen
Observed below url formats are not accepted (Observed there are records in org service with those formats)

Example1

https://api-gw.dev.platform.linuxfoundation.org/organization-service/v1/orgs/0014100000Te028AAB

Example2

https://api-gw.dev.platform.linuxfoundation.org/organization-service/v1/orgs/0014100000TdzOGAAZ

@nirupamav It looks like the URL having HTTP and www is an optional thing so I will remove this is a validator.

Based on above comments formats mentioned in the ticket are not supported and hence moving the ticket to QA Done


Fix punkt tokenizer complexity for very long tokens

This change prevents N^2 complexity for inputs with very long tokens (N being the length of the longest token). Instead of using finditer with regex that starts from any point in the string, we use match method that starts only at the string beginning and remember where we stopped in the last step.
What was N^2 exactly?
Used regex can start at any position in the string. If we have a token
like<PHONE_NUMBER>0123...9, \S* starts matching 0 and matches everything till
the last 9 and then figures out that it does not have potential sentence
ending character.
Since finditer returns matches starting at any position, it tries matching with character 1, matches everything till the end and then does not find potential sentence ending, ... It does that matching N times, each time going through N/2 characters (on average).
Complexity test
I've found regression tests like the one I wrote useful. If you are ok with it, I can improve the robustness.

Just saw there are more rests in doctest files. Will make sure all pass.

Interesting, I can replicate sentiment doctest failures locally, but not tokenize doctest failures.

Added more context on the effect of this change on performance.

@stevenbird any chance you know when somebody would have time to review this? This is my first contribution here so I am not sure what's the usual cadence.

@mariokostelac, thanks for your PR. I'll review it during the week and respond here.

@mariokostelac, can you please explain the context where you are sentence tokenizing with tokens up to 60kB? There needs to be a case for adding to the complexity of the code? We ascribe to the worse is better doctrine, where simplicity of an implementation trumps completeness.

That's interesting, I've never heard of that doctrine, thanks for linking it.
I've stumbled upon this performance issue while debugging some ETL jobs I've created in Intercom. They process real world, text data entered by users in messenger (you can see one on the top bottom of https://biasandvariance.com/).
I'd be less concerned if I found this theoretically, but it actually took a while to find a needle in the haystack and figure out it's part of NLTK library. Of course there is a way to avoid it before it hits NLTK (deleting long tokens, for example; that's what I do now), but then it means I have to to think about it every time I'm putting NLTK in production, which makes the library less usable.

If you're ok with the approach, I should probably change https://github.com/nltk/nltk/blob/7fd2bf5d52fabea678d546cef632463e7c9f13ae/nltk/tokenize/punkt.py#L1282 before merging, too.

@mariokostelac sorry for the long delay... I've been reluctant to add complexity to the codebase, but if you're still keen, please go ahead with your other proposed change, and please resolve the merge conflicts, and then I'll merge. Thanks.


Can ListPointer() skip empty array ?

Example:
go-jsonpointer/testdata/357.json has few fields like,
"address": [],
"address2": ["x"],
"address3": [ ]
ListPointers() returns,
"/address/0"
"/address3/0"

This seems to work as expected.


How to set actor order on diagram?

How to make prio for actor on diagram? Have some idea or keyword for set order on screen?

The only way to do that right now is to utilize alias. Diagwiz will order the actors according to the order of aliases.
alias a = "Alice"
alias b = "Bob"

a->b: "Hello!"
b->a: "Hello back!"

See in playground
vs
alias b = "Bob"
alias a = "Alice"

a->b: "Hello!"
b->a: "Hello back!"

See in playground
Le me know if I misunderstood your question.

That's working. Thanks.


cannot install

Hi, I try to install this repo using the command:
pip install course22p2
but I got the error:
ERROR: Could not find a version that satisfies the requirement course22p2 (from versions: none)
ERROR: No matching distribution found for course22p2
I am using mac and tried to install it in a conda env.

I believe this is just nbdev boilerplate and this repo is still under construction ie (the readme needs to be udpated).  If you want to install this repo just use the trusty https://github.com/fastai/course22p2.git.

Hi @

I believe this is just nbdev boilerplate and this repo is still under construction ie (the readme needs to be udpated). If you want to download this repo just use the trusty git clone https://github.com/fastai/course22p2.git.

@wtliao In virtual environment preferably python 3.10.* and above you could. Just reviewing the readme.
cd into the directory
cd course22p2

Then do a pip install
pip install -e .


Readme changes

A Number of Changes:

Added some nice looking badges
Added a detailed contribution guide
Fixed some grammatical errors

Do these look good ??

Do these look good ??

I have left some comments.
Great work 👏
Thanks

Could you please approve this as this will be my last hacktoberfest checkpoint 😅

Done


Changes PSA key storage format to include key bits

Description
To simplify the storage of keys for opaque drivers we want to store the bit-size systematically with the other attributes. The storage format is updated by splitting the existing 32-bit field for the key type into 16-bit fields for type and bits.
Overview of changes:

Stores bits in psa_persistent_key_storage_format.
psa_load_persistent_key_into_slot still imports plaintext keys which ensures that the bits value gets set.
Updates key specification to match new implementation.
Expands persistent store and load tests with to check for bits attribute.
Removes bits storage from psa_se_key_data_storage_t.

Status
READY
Requires Backporting
NO
Migrations
NO
Since the existing PSA Crypto storage format (and dynamic SE driver storage format) isn't considered stable, no specific migration logic is included. The implementation still computes the bits value for transparent keys, since these are imported upon loading, which ensure backwards compatibility at the PSA Crypto storage format level.
For stored dynamic SE driver keys, the included bits field must be removed before loading the key.
Todos

[x] Tests
[x] Documentation
[x] Changelog updated

Please add a signoff line to all commit messages.

Please add a signoff line to all commit messages.

Which commits are missing a signoff line?

See the “Details” link next to the “DCO” check failure: https://github.com/ARMmbed/mbedtls/pull/3748/checks?check_run_id=1286499681

See the “Details” link next to the “DCO” check failure: https://github.com/ARMmbed/mbedtls/pull/3748/checks?check_run_id=1286499681
There's a signoff line, but the author email doesn't match the git one. I think you'll actually want to amend the committer email rather than the signoff line.

Thanks, I didn't spot the checker. Seems using the accept suggestion feature wasn't ideal. I amended the author field to match the rest.

Who would be a good second reviewer for this PR?

I'm on it.


⚠ Bofrost.de has degraded performance

In adb05f6, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 943 ms

Resolved: Bofrost.de performance has improved in a525d9a.


In requirements.txt : coverage version

Hi,
There is an installation issue when I pip install django-soft-delete in an environment where I have coverage version > 4
ERROR: soft-delete 0.2.2 has requirement coverage==4.0.3, but you'll have coverage 5.0.4 which is incompatible.

bumping this request. i am running in to the same issue. all we need is for you to change the requirement from coverage==4.0.3 to coverage>=4.0.3 in requirements.txt and setup.py.
thanks


Best way to get yaw/pitch at mouse pointer?

Similar to #203 , trying to implement a 'click to add hotspot' interface and getting mouse yaw/pitch on click would be super helpful, whether via modified getPosition or a separate function.
Does anyone know a three.js command sequence that would work this out from worldRenderer.hotspotRenderer.pointer or similar? Have been fiddling with it but so far no luck, any help much appreciated.

As far as I can see onGetPosition https://github.com/googlevr/vrview/blob/4545ce06e42987c4d118746a2e0a8fd880ed2cae/src/embed/main.js#L357-L364
returns somethig called camera rotation. The problem is that when I new hotspot whit Yaw and Pitch values returned by this method I get new hotspot rendered in very wrong position (90 degrees to the left).
Furthermore loading pano I suspect that camera looks at Vector3(0, 0, 0) but in fact it looks at point 90 degrees to the right.

I've also tried to send position using this.pointer on mouse up but still no effect:
  // If no hotspots are pressed, emit an empty click event.
  if (Util.isEmptyObject(this.downHotspots)) {
    this.emit('click');
    console.log('mouse up');
    console.log(this.pointer);
      Util.sendParentMessage({
          type: 'getposition',
          data: {
              x: this.pointer.x,
              y: this.pointer.y,
              z: -1, // skip
              add: true // add new hotspot if true
          }
      });
    return;
  }


Kubelet: wait up to 5m for Docker to come up.

The Kubelet assumes Docker is running during its execution and on
machine boot it is a race between Docker coming up and Kubelet calling
Docker. This PR waits for Docker to be up before the Kubelet begins
doing useful work. On timeout, Kubelet exits and expects to be
restarted.

I know for systemd environments we can state to start the Kubelet after Docker, but in general, this is ok.

LGTM

Thanks for fixing it @vmarmol


Better threshold UX

Describe your changes
Improves UX for the DKG ceremony based on user feedback, so we can actually tell people to use it.
This is a PR on top of #4343 to make it as easy as possible to merge.
Issue ticket number and link
#4335
Checklist before requesting a review

[x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

client-side key generation logic only


Copy newNuget.config generated from "NuGet Installer" build step to handle custom feed authentication

The "NuGet Installer" build step can be used to authenticate with custom NuGet feeds. However, it doesn't work with "dnu restore" unless you copy the generated newNuget.config file over the user's %APPDATA%\Nuget\Nuget.config file. This addition searches for that file and copies it over if it exists.
Note: I currently have the added lines below as a separate PowerShell task in my build (just before "DNX Tasks Build Web package" and it works. You'll probably want to test it yourself as well though.

Shouldn't this change also be made to BuildWebPackage.ps1? It also has a dnu restore.

Ah, yah, should probably be in there as well. I hadn't used it, so didn't go looking.
As far as I can find, dnu restore just uses the NuGet.config in $ENV:APPDATA\NuGet\NuGet.Config, and there doesn't seem to be an option to override that (you can pass sources in manually, but I can't find documentation on that, and the current documentation just instructs you to update the NuGet.Config in AppData).
You could potentially pull over the code from the NuGet Installer to build the config file, but that's a bit larger scope than I wanted to add =).

Because I changed many things in order to get this tasks running with the dotnet CLI I can not merge this anymore.
I will close this for now but I will have a look at this later.


I don't know what the problem is..

Hello everybody.
I have this error shown when I launch kickthemout on my macbook pro :
Traceback (most recent call last):
  File "kickthemout.py", line 478, in <module>
    defaultInterface = getDefaultInterface()
  File "kickthemout.py", line 357, in getDefaultInterface
    network, netmask, _, interface, address = max(iface_routes, key=lambda item:item[1])
ValueError: too many values to unpack

please I need your help

Hi there. Are your using an external WiFi card or your Macbook's in-built one?

Hi. Am using my built in wifi card

it works :D
I guess the problem with my case was that I didn't updated pip command.
Now it works fine with me.

Hey again @HappyCoOl. Apologies for the late response. I am glad that you managed to resolve your issue! :)

Hii, how did you fix that issue, I'm exactly in the same situation (using the built in wifi card of my macbook)

Hi i did update pip sudo pip install --upgrade pip but still get the module problem any help plz?


Compare the k8s versions correctly in Provisioner

Description
Changes proposed in this pull request:

Compare the k8s versions correctly in Provisioner

/test all

/test all

/test all

/test /all

/test all

/test all

/retest

/test pre-main-control-plane-reconciler-upgrade-kyma2-latest-to-main-gardener

/retest


Paging links numbers to rows instead of pages

Reviewing the demo and also with a short test project I found the the paging to work in a nonstandard way. It seems the numbers are linked to rows instead of a group of rows. This is the case with the online demo and even when I set a size option with no scrollbar (normal paging).  Have I just missed something obvious?

So virtual paging with a scrollbar is linked to the row. It calculates the grid height, location, number of rows, and height of rows to determine what page 'theortically' that it should be on.
Fixed/no scrollbar paging with page sizes, etc should work like expected.  Can you show me case where you don't see that happening? Maybe walk me through it?

I have attempted to reproduce my local results using the options from the regular paging demo -
https://github.com/Swimlane/angular-data-table/blob/master/demos/paging.html.
The codepen was modified from the virtual online example to match the demo but it doesn't produce any rows which is a different problem from pagination.
https://github.com/Swimlane/angular-data-table/blob/master/demos/paging.html


python traceback

Traceback (most recent call last):
  File "/usr/bin/radio", line 5, in <module>
    from radioactive.__main__ import main
  File "/usr/lib/python3.12/site-packages/radioactive/__main__.py", line 12, in <module>
    from radioactive.handler import Handler
  File "/usr/lib/python3.12/site-packages/radioactive/handler.py", line 9, in <module>
    import requests_cache
  File "/usr/lib/python3.12/site-packages/requests_cache/__init__.py", line 7, in <module>
    from .backends import *
  File "/usr/lib/python3.12/site-packages/requests_cache/backends/__init__.py", line 8, in <module>
    from .base import BaseCache, BaseStorage, DictStorage
  File "/usr/lib/python3.12/site-packages/requests_cache/backends/base.py", line 27, in <module>
    from ..cache_keys import create_key, redact_response
  File "/usr/lib/python3.12/site-packages/requests_cache/cache_keys.py", line 29, in <module>
    from url_normalize import url_normalize
ModuleNotFoundError: No module named 'url_normalize'

Archlinux 6.9.4-zen
python 3.12
radioactive-2.9.1-2 (from aur)

Solved installing missing python modules


How to use MediaPlayer to play video?

I got this error,

The code is like this:
fn main() -> anyhow::Result<()> {
    play_video();
    Ok(())
}

async fn play_video() -> anyhow::Result<()> {
    let path = HSTRING::from_wide(str_to_u16_slice("D:\\BaiduNetdiskDownload\\123.MP4"))?;
    let file = StorageFile::GetFileFromPathAsync(&path)?.await?;
    let source = MediaSource::CreateFromStorageFile(file)?;

    let media_player = MediaPlayer::new()?;
    media_player.SetSource(&source);
    media_player.Play()?;
    Ok(())
}

fn str_to_u16_slice(s: &str) -> &[u16] {
    let mut utf16: Vec<u16> = s.encode_utf16().collect();
    utf16.push(0); // 将字符串以空字符 '\0' 结尾
    utf16.as_slice()
}

The Rust compiler helpfully suggested the correct fix in the error message you shared: CreateFromStorageFile(&file)
You will also need to wait for the result of the async function and can simplify your code by using the h! macro to build the string literal as follows:
use windows::{core::*, Media::Core::*, Media::Playback::*, Storage::*};

fn main() -> Result<()> {
    futures::executor::block_on(main_async())
}

async fn main_async() -> Result<()> {
    let path = h!("path to media");
    let file = StorageFile::GetFileFromPathAsync(path)?.await?;
    let source = MediaSource::CreateFromStorageFile(&file)?;

    let media_player = MediaPlayer::new()?;
    media_player.SetSource(&source)?;
    media_player.Play()?;
    Ok(())
}

@kennykerr Thanks! I can compile it now, and I can hear the sound when playing video, but without any video images. What would be the reason?

For that you'll need a window to compose the video output with the MediaPlayer.GetSurface method using the Windows compositor. I wrote about it here. Here's an example of using the Windows compositor with Rust:
https://github.com/robmikh/minesweeper-rs

use windows::{core::*, Media::Core::*, Media::Playback::*, Storage::*};
fn main() {
    let path = h!("D:\\Music\\flac\\milet - Anytime Anywhere.flac");
    let file = StorageFile::GetFileFromPathAsync(path)
        .unwrap()
        .get()
        .unwrap();
    let source = MediaSource::CreateFromStorageFile(&file).unwrap();

    let media_player = MediaPlayer::new().unwrap();
    media_player.SetSource(&source);
    media_player.Play();

    loop {}
}

I borrowed file in MediaSource::CreateFromStorageFile(&file). But there's still an error:
error[E0277]: the trait bound `Storage::StorageFile: CanInto<IStorageFile>` is not satisfied
    --> src\main.rs:8:54
     |
8    |     let source = MediaSource::CreateFromStorageFile(&file).unwrap();
     |                  ----------------------------------  ^^^^ the trait `CanInto<IStorageFile>` is not implemented for `Storage::StorageFile`
     |                  |
     |                  required by a bound introduced by this call
     |
     = help: the following other types implement trait `CanInto<T>`:
               <Storage::StorageFile as CanInto<IUnknown>>
               <Storage::StorageFile as CanInto<IInspectable>>
     = note: required for `&Storage::StorageFile` to implement `Param<IStorageFile, InterfaceType>`
note: required by a bound in `Core::MediaSource::CreateFromStorageFile`
    --> C:\Users\ferry\.cargo\registry\src\index.crates.io-6f17d22bba15001f\windows-0.56.0\src\Windows\Media\Core\mod.rs:3520:13
     |
3518 |     pub fn CreateFromStorageFile<P0>(file: P0) -> windows_core::Result<MediaSource>
     |            --------------------- required by a bound in this associated function
3519 |     where
3520 |         P0: windows_core::Param<super::super::Storage::IStorageFile>,
     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `MediaSource::CreateFromStorageFile`

Any helps? Thanks!


Cloning T-Systems version

Pls!

Could you please elaborate more?

I think #143 describes it better.

In lack of more details, let's close this as a duplicate to #143


fix typos in error message

Fix #3639

Codecov Report

Merging #3643 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3643   +/-   ##
=======================================
  Coverage   72.09%   72.09%
=======================================
  Files         422      422
  Lines       26283    26283
  Branches     3977     3977
=======================================
  Hits        18949    18949
+ Misses       6120     6117    -3
- Partials     1214     1217    +3

Impacted Files
Coverage Δ

...cli-vm/azure/cli/command_modules/vm/_validators.py
75.29% <100%> (ø)
:arrow_up:

...dback/azure/cli/command_modules/feedback/custom.py
31.25% <0%> (ø)
:arrow_up:

src/azure-cli-core/azure/cli/core/util.py
72.1% <0%> (ø)
:arrow_up:

...nent/azure/cli/command_modules/component/custom.py
16.23% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c024331...796c745. Read the comment docs.


Diagnostic fixes

This PR implements two diagnostic-related changes:

CMake 3.27 has deprecated script modes prioer to CMake 3.5 and issues a deprecation notice for all users running on latest CMake. While we do not use features that would necessitate bumping the minimum language reqs, Kitware has deprecated such old releases, so scripts currently being maintained should follow along.
The configuration of rocm-examples is ridiculously noisy, because all samples are written in a self-sufficient (copy-paste friendly) manner, hence we find_pakcage(HIP) multiple times. As a result all uncached checks issuing a diagnostic are repeated on the console 30-ish times. These diagnostics have very little value to developers to be honest. The ones which are error path-related are defensible, but the library type diagnostic is almost like an AMD developer debug message that got committed somehow. No end-user cares about the library type of amdhip64.

Hi @MathiasMagnus I am closing this pull request but will keep the part of the changes that is about improving the messaging in find_package(hip) in hip-config-amd.cmake and will transfer those in an internal PR. Once that is reviewed and merged you should see the changes in clr repo here.

Hi @MathiasMagnus I am closing this pull request but will keep the part of the changes that is about improving the messaging in find_package(hip) in hip-config-amd.cmake and will transfer those in an internal PR. Once that is reviewed and merged you should see the changes in clr repo here.


ITestNGListenerFactory is broken and never invoked

TestNG Version
7.10.2
Worked as expected in 7.8.0
Expected behavior
When a ITestNGListenerFactory implementation is registered via @Listeners annotation, ITestNGListenerFactory#createListener should be invoked before any @Test annotated methods are invoked.
Actual behavior
ITestNGListenerFactory#createListener is never invoked.
Is the issue reproducible on runner?

[ ] Shell
[ ] Maven
[ ] Gradle
[ ] Ant
[ ] Eclipse
[X] IntelliJ
[ ] NetBeans

Test case sample

Factory is part of test class:

@Listeners(FactoryListenerTest.class)
public class FactoryListenerTest implements ITestNGListener, ITestNGListenerFactory {

    @Override
    public ITestNGListener createListener(Class<? extends ITestNGListener> listenerClass) {
        // Never invoked
        System.out.println("FactoryListenerTest.createListener");
        return null;
    }

    @Test
    public void test() {
        System.out.println("FactoryListenerTest.test");
    }
}

Independent factory

public class CustomFactory implements ITestNGListener, ITestNGListenerFactory {

    @Override
    public ITestNGListener createListener(Class<? extends ITestNGListener> aClass) {
        // Never invoked
        System.out.println("CustomFactory.createListener");
        return null;
    }
}

@Listeners(CustomFactory.class)
public class FactoryListenerTest {

    @Test
    public void test() {
        System.out.println("FactoryListenerTest.test");
    }
}

Contribution guidelines
Incase you plan to raise a pull request to fix this issue, please make sure you refer our Contributing section for detailed set of steps.

Root cause of this issue was because of this PR https://github.com/testng-team/testng/pull/3060

@RiJo - Until this issue is fixed, can you please try adding

<properties>
   <property>
      <name>listenerfactory</name>
      <value>your.fully.qualified.classname.goes.here</value>
  </property>
</properties>

This should ensure that your listener factory gets invoked when you run your tests using maven.
For running tests via intellij you can set this configurmation via the Test runner params

Thanks for the quick response!
It is not possible for me to add custom parameters and/or properties as the TestNG tests are part of a larger system. I will stay on version 7.8.0 until the issue has been addressed. Thanks!


getCurrentUrl is not working correctly with circleCi when using chrome

I was reading that there is some issues with the method getCurrentUrl . today when i was testing in my localhost everything works fine but when i push the code to circle ci . the getCurrentUrl method returns always the previous url address . so if i try to login to the home page, even if i am in the home page and the login was successful , getCurrentUrl return the login page.
This is happening with chrome on CircleCi while locally everything works like expected.
import { browser, Config, element, by } from 'protractor';
import { assert } from 'chai';

describe('test sample', function() {

    function urlChanged(url) {
            return function () {
                return browser.getCurrentUrl().then(function(actualUrl) {
                    return url != actualUrl;
                });
            };
    };

    beforeEach(function() {
        browser.ignoreSynchronization = true;
    });

    it('should login', function() {
        browser.get('http://localhost:8080/#/signin');
        const email = element(by.name('email'));
        const password = element(by.name('password'));
        const button = element(by.css('[type="submit"]'));
        email.sendKeys('qa-test@fashion.cloud');
        password.sendKeys('fc123456789');
        button.click();
        browser.wait(urlChanged('http://localhost:8080/#/signin'), 30000);
        browser.getCurrentUrl().then((url) => {
            console.log('url is', url);
        });
    });
});

Hi @BassemDev ,
Just to make thinks clear. When I read your script you do the following:

you go to http://localhost:8080/#/signin
you logon
you validate that the url is changed and the current url is NOT equal to http://localhost:8080/#/signin
You then get the current url, after you've checked that it isn't equal

How long does step 3 take? Less then 30 seconds? If so, then you already confirmed that getCurrentUrl() is giving a different url. Can you also log it?

Hi @wswebcreation ,
no the link never change , even after 30 second , the problem is that getCurrentUrl is sending always the old or the first url that you assign to the browser.get which mean http://localhost:8080/#/signin , this is the following error message:

if you try to avoid the timeout by decreasing the time to 20 second you will see the following message

So it's the same page even after 20 second.

Ok, clear, is it the same situation as in https://github.com/angular/protractor/issues/4384.
@NickTomlin , what do you think about this? The getCurrentUrl() is tested here but I can't find find if it is checked in the circleCi environment. I.m.h.o.
this is more a environmental thing then something coming from Protractor.

@wswebcreation , locally it works fine , i have tested in different browser and things are as expected and getCurrentUrl change so fast , you don't even wait 0.2 second for that. but in circleCi with chrome no chance.


Add CFGOV Helm Charts for Local Deployment to K8s

This PR adds a CFGOV Helm chart that allow for deployment to a local K8s cluster.
Additions

A CFGOV Helm Chart that includes:

2 init containers:

A Busybox container to ensure that the Postgresql and Opensearch Services are running
A data migration container that loads test data into the Postgresql Service and indexes that data to the Opensearch service.

2 containers:

The CFGOV application (running on PORT 8000)
The Apache server that proxies to to that web application (running on PORT 80)

Adds index.sh and test.sql.gz to the CFGOV docker image.
A helm deployment guide to the master docs
A helm-init.sh script to deploy the helm chart effortlessly.
A helm-uninstall.sh script that tears down everything related to the CFGOV Helm deployment.
A Helm notes script that outputs instructions for accessing the CFGOV deployment when deployed locally.

How to test this PR

Make sure you have a local K8s cluster running.
Clone the PR.
Run: docker build . -t cfgov
Run: helm-init.sh
Port forward the cfgov-apache container to a local port.
Access your application at localhost:<local_port>
Ensure the home page is displaying.
Visit localhost:<local_port>/about_us/blog to make sure the Open Search index is working.

Notes and todos

Reach out to @cooldragontattoo if you have any questions.

Checklist

[x] PR has an informative and human-readable title

PR titles are used to generate the change log in releases; good ones make that easier to scan.
Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".

[x] Changes are limited to a single goal (no scope creep)
[x] Code follows the standards laid out in the CFPB development guidelines
[x] Future todos are captured in comments and/or tickets
[x] Project documentation has been updated, potentially one or more of:

This repo’s docs (edit the files in the /docs folder) – for basic, close-to-the-code docs on working with this repo
CFGOV/platform wiki on GHE – for internal CFPB developer guidance
CFPB/hubcap wiki on GHE – for internal CFPB design and content guidance

Front-end testing

Browser testing
Check the current browser support cutoff list](https://cfpb.github.io/consumerfinance.gov/browser-support#current-browser-support-metrics) for browsers that are advisable
to prioritize for testing.
Accessibility

[ ] Keyboard friendly (navigable with tab, space, enter, arrow keys, etc.)
[ ] Screen reader friendly
[ ] Does not introduce new errors or warnings in WAVE

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Does not introduce new lint warnings
[ ] Flexible from small to large screens

@willbarton, I made your changes. @chosak, do you also want to review?

@cooldragontattoo yes, please, I'd still like to review.


com.google.ortools.sat.AutomatonConstraint.addTransition is package private

What version of OR-Tools and what language are you using?
Version: 9.11.4210
Language: Java
Which solver are you using (e.g. CP-SAT, Routing Solver, GLOP, BOP, Gurobi)
CP-SAT
What operating system (Linux, Windows, ...) and version?
both
What did you do?
I tried to construct an automaton constraint
What did you expect to see
I expected a public addTransition method in com.google.ortools.sat.AutomatonConstraint
What did you see instead?
addTransition is package private.

Thanks


mass and stiffness matrix from thermal transient analysis

Hello everybody,
I am new in ansys and I am using it for my master thesis.
For this I am simulating a model in a thermal transient analysis and try to get the mass and stiffness matrix as a dense matrix with the following code:
# -----------------------------------------------------------------------------
# Loading the .full-file from ANSYS
# -----------------------------------------------------------------------------

# load packages
import pyansys      # Documentation pyansys: https://akaszynski.github.io/pyansys/loading_km.html
import scipy
from pyansys import examples
import numpy as np

# create result reader object and read in full file
full = pyansys.read_binary(examples.fullfile)
dof_ref, k, m = full.load_km(sort=False)   # returns upper triangle only

# make k, m full, symmetric matrices
k += scipy.sparse.triu(k, 1).T
m += scipy.sparse.triu(m, 1).T          <--- HERE IS THE ERROR BECAUSE NO m IS AVAILABLE

# condition the k matrix to avoid getting the "Factor is exactly singular" error
k += scipy.sparse.diags(np.random.random(k.shape[0])/1E20, shape=k.shape)

# generate dense matrix from sparse matrix
k_dense = k.todense()
m_dense = m.todense()

Unfortunately I just get a stiffness matrix but not mass matrix. Can anybody tell me what I am doing wrong?
Thanks
Markus

Hello @SebiK91,
Thanks for your interest with pyansys.  Would it be possible to upload the *.full file here for me to take a quick look at it?  The mass matrix should be available, but I want to double check to see if it's not included in the file.

Hello @akaszynski,
here my *.full file, which is from a thermal transient analysis in Ansys:
file.zip

Thanks for that!
I got some help with this one from @FredAns:

When we perform a thermal transient analysis, the "Mass" matrix is not stored individually in the Full File.
For performance concerns, Both K and C matrices are combined into a single "equivalent conductivity matrix".

Here is the description of this combination, and how to extract individual matrices:

Ansys writes the equivalent conductivity matrix to the *.full file for a transient analysis:

[K] can be retrieved by:

setting c to a very small value for all materials
setting theta to 1 (using tintp command)
Setting  to 1 (using time, 1 and nsbst, 1,1,1)

[C] can be retrieved by setting k to a very small value for all materials
2 dummy full transient calculations have to be performed.  Only *.full file written (wrfull,1)
APDL Math is used to retrieve the matrices [K] and [C]: *SMAT

I think if you run the analysis using the above settings and then read in the *.full file using pyansys, you should be able to get the [K] and [C] matrices.
Let me know if you encounter any issues with this.

In a first step I tried your way to retrieve [K] and [C] and I think it works. This is the way I did it:

But I don't understand what I can do with the *SMAT function. I think in my two *.full files from the two calculations [K] and [C] are separated already.
In the second step reading the *.full files with pyansys works without any trouble. Do you know a way how I can double check if the values are correct? I already tried it with a simple cube but I don't know how to validate the matrices.
Thanks in advance!

The *SMAT function is used to return the matrices within MAPDL, but it sounds like you'd like to do this outside MAPDL with pyansys.  Totally understandable and pyansys can support that.
What I'll need is the two *full files to verify that the results are correct.  Also, if possible can you upload the entire input file here as well?
Thanks!

I'd like to do it outside MAPDL in Python to do a model order reduction...
Attached I send you the entire input file (K_cross - equivalent conductivity matrix) and my result files for [K] and [C]. Furthermore I send you my cube model.
Thanks!
cube.zip

I've run this using:
import pyansys

c_full = pyansys.read_binary('C.full')
k_full = pyansys.read_binary('K.full')

_, c, _  = c_full.load_km()
_, k, _  = k_full.load_km()

However, I can't verify this as the workbench file isn't loading as it's missing several required files.
If possible, please include the full directory containing the entire workbench directory.  Otherwise, you can always create an input file (or use the one workbench generates as a *.dat file) and I can run that instead.
Another way you can verify this is to generate the combined stiffness matrix which is generated by default and then load that as well within pyansys, and then verify the following equation holds true:

import pyansys

c_full = pyansys.read_binary('C.full')
_, c, _  = c_full.load_km()

k_full = pyansys.read_binary('K.full')
_, k, _  = k_full.load_km()

k_full = pyansys.read_binary('file.full')  # generated by default by MAPDL (equivalent conductivity matrix)
_, k_eqv, _  = k_full.load_km()

assert k_eqv == k + c

Aaaah, this works...
assert k_eqv == k + c is true :-)
Thank you very much!!!
Do you know if I can apply pyansys also for the input matrix/ load vector and output matrix/ result vector respectively?

Glad that worked out!
I've just added in the ability to access the load vector with:
vec = full_file.load_vector

You'll need pyansys==0.42.1.  As for the result vector, I don't think it's stored in the full file.  I'm a bit unfamiliar with transient thermal analyses, but if you're looking for the results from the analysis, you can find them in the file.rst file and can load that with:
pyansys.read_binary('file.rst')

If this isn't what you're looking for, I can ask internally on Monday.  Or, if you could point me to some docs describing what you'd like, I can go searching for it as well.

The load vector command works basically while I get four values at the four nodes of my cube where I applied a temperature (I applied a temperature to one surface of the cube). Unfortunatelly the values I get from the fule_file.load_vector does not correspond to the temperature I am applying.
I think the problem is that I have a transient thermal analysis. From this simulation I don't even get a *.rst-file but a *.rth-file. And I am not sure if 'pyansys' even works for a *.rth-file?
Here you can find a complete simulation result from ansys:
cube_res.zip

Correct, the load vector isn't the boundary conditions for the thermal result.  You can grab that from the thermal result file.
Actually, pyansys does support ".rth" result files.  They're the same format as a "*.rst" file, but I need to update the docs to reflect that.
You can get the thermal conditions for each result set with:
import pyansys
rth = pyansys.read_binary('file.rth')
temp = rth.nodal_solution(0)

# not supported just yet
# rth.boundary_conditions(0)

I need to add support for boundary conditions, and I think I'll be able to get around to it today (already halfway done).
I really appreciate your help with getting this prototyped, and I'm going to add better documentation to pyansys to show how to read in thermal result files so that it's clear that pyansys supports it.

Boundary conditions are now supported as of pyansys==0.42.2.  Should be out on pypi shortly:
>>> import pyansys
>>> rth = pyansys.read_binary('file.rth')
>>> nnum, dof, bc = rth.nodal_boundary_conditions(0)
>>> print(nnum)
>>> print(rth.result_dof(0), bc)
[1 4 3 2]
['TEMP'] [55. 55. 55. 55.]

Oh man - great job. Thank you!
I think I have almost reached my target. In the end I'd like to create the state-space of my Ansys-model in Python - ideally in the form like attached...

I tried different ways according to your descriptions and with approaches according to your method for the other matrices and vectors but it didn't work unfortunatelly. But in my opinion when thermal conductivity and capacity are exportable the it should be possible to export the other matrices as well. Can help me with this?

@SebiK91, sorry that I missed this!  Can you show me what you have so far, and I can help you pull out the rest of the data either from MAPDL or from the result file?

No worries, I found a solution with MAPDL to get the matrices. Nevertheless it would be much easier to the matrix export just with Python. Furthermore I realized that I don't have/ need the E-matrix (see the equations above). Is there a way to do export the B- and D-matrix?

When you get a chance, post the code for how you extracted the matrix from MAPDL.  We might be able to just transfer that from MAPDL to Python.
As for B, and D, I'm more familiar with the formulation of state space here:
https://en.wikipedia.org/wiki/State-space_representation
Either way, it looks like you're looking for the input matrix and output matrix, which I think we figured out we can get from the full file's boundary conditions, right?

Closing soon due to inactivity.  @SebiK91, I'll need a little more help with this to make some progress.


Add div with dynamic VergeJS viewport values to HTML

Trying to display a div with the Verge values during development.
Please see https://jsfiddle.net/ccL30a26/1/.
function getVergeValues() {

viewportWidth  = verge.viewportW() // Get the viewport width in pixels.
viewportHeight = verge.viewportH() // Get the viewport height in pixels.

var $width  = $( "

" );
var $height = $( "

" );

$('.w').text(viewportWidth  + 'px wide');
$('.h').text(viewportHeight + 'px high');

$( "body" ).append( $width, $height);

}

$(window).on('resize', getVergeValues);
$(document).ready(getVergeValues);

However now on domready there is no value shown and on window resize the values get added up filling the viewport.
How can I get the initial value to show on domready and only the current value to show on window resize please?
I assume this is not really an issue but am wondering why Verge does not display the inital value on domready. Do you have a clue?
Additionally it would be great if you could help with letting me know how I can avoid filling the viewport with new divs as I resize. Thank you.

It's because you're appending each time you call getVergeValues. You only need to append once. After that you can just update. Try more like:
function update() {
    $('.w').text(verge.viewportW()  + 'px wide');
    $('.h').text(verge.viewportH() + 'px high');
}

$('body').append('

');
$(window).on('resize', update);
$(document).ready(update);

Thank you.


Multiple worker receive action needs tooling support

Description:
The Worker Multiple Receive action #18163 has been fixed at #24556
This requires tooling support.
Related Issues:
#18163
Suggested Labels:
Component/LanguageServer, Area/Tooling
Suggested Assignees:
@nadeeshaan

Getting the following when tried the the multiple worker receive.

Closing this since the multiple receive action is not yet supported. We can create a new issue when that support is implemented.
public function main() {
    worker A {
        1 -> function;
    }

    worker B {
        2 -> function;
    }

    int i = <- {A, B};
}


Add FV for policy grouping.

Description

Additional FV test for #8098
Related issues/PRs

CORE-10015
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

/merge-when-ready

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.

Removing "merge-when-ready" label due to new commits

/merge-when-ready

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.

Removing "merge-when-ready" label due to new commits

/merge-when-ready squash-commits

OK, I will merge the pull request when it's ready, squash the commits when I merge it, and leave the branch after I've merged it.

Removing "merge-when-ready" label due to new commits

/merge-when-ready squash commits

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.

/merge-when-ready squash-commits

OK, I will merge the pull request when it's ready, squash the commits when I merge it, and leave the branch after I've merged it.


Allow "show images" for whitelist senders to always show

When viewing a message with the "Always show images" for an account, either allow addition of whitelist senders to show images without need to add sender to contacts, or allow 1 step addition to add to whitelist senders.

Sorry, see now this is a duplicate of #1035


Allow for using number keys to escape the Repeat mode

When using the new awesome repeat drawing mode, I found myself instinctively trying to escape the mode when done drawing sidewalks by pressing 2, which is my shortcut for Unmarked crossing, the thing I wanted to map next.
What I think would make sense (and be very intuitive) would be to allow using number keys to escape the drawing mode in repeat and start drawing that new feature that the key corresponded to (still in repeat mode for speed).
This would help reduce unnecessary key presses and would make an intuitive way to change between the feature being drawn possible.

This already works when the mapper is half way through an existing line.  What this issue is about ensuring that the listeners are active in that time between drawing lines.

This might actually be working as it should now.  Testing today allowed me to switch between different modes with the number keys.

This might actually be working as it should now. Testing today allowed me to switch between different modes with the number keys.

@BjornRasmussen This wasn't intentional but I'm glad it's working! I agree it's nice to switch the feature type immediately via hotkeys, especially since I often click the wrong button 😅. The new assistant helps a lot with this, since it tells you what you're drawing.


Add custom command checks tag

This PR adds a tag for creating custom decorators in discord.py for commands (different to the existing decorators tag in that it specifically shows how to make discord.py checks, a commonly required subject, rather than just decorators)
How the embed looks:

Updated embed:

Updated embed:

First sentence is unnecessary. If someone wants to know how to create a check then they already have a reason for why they want to do it. In any case, the notion of having to create something because it doesn't already exist is pretty obvious and doesn't need to be explained.

I've elected to keep the sentence, but I've made it more matter of fact. The reasoning behind this is that I don't want it to sound too robotic or boring for those reading since this is a tag generally for beginners, not the docs page. I believe that without it the sentence sounds too 'un human' and sounds weird, and given it's a single line I see no harm in having it that way.


Skip empty lines when determining base indentation

Summary
It turns out we saw a panic in cases when dedenting blocks like the def wrapper here:
def instrument_url(f: UrlFuncT) -> UrlFuncT:
    # TODO: Type this with ParamSpec to preserve the function signature.
    if not INSTRUMENTING:  # nocoverage -- option is always enabled; should we remove?
        return f
    else:

        def wrapper(
            self: "ZulipTestCase", url: str, info: object = {}, **kwargs: Union[bool, str]
        ) -> HttpResponseBase:

Since we relied on the first line to determine the indentation, instead of the first non-empty line.
Test Plan
cargo test

Ecosystem checks are correct. I accidentally merged https://github.com/astral-sh/ruff/pull/9769 previously which removed all of those rules because we started panicking on those specific files.


Limit downloaded file size for a single song

Is it possible to add a parameter to limit the file size?
https://gaana.com/playlist/gaana-dj-70s-rafi and https://gaana.com/playlist/gaana-dj-top-hindi-songs-of-70s playlist downloads few incorrect large files 150 MB to 400 MB.
If there is a parameter that limits matching song name and checks size of a single file to less than 15 MB would be nice.

Thanks, I'll think about it.
On Sun, Oct 29, 2017, 1:55 AM nerdygoofball<EMAIL_ADDRESS>wrote:

Is it possible to add a parameter to limit the file size?
https://gaana.com/playlist/gaana-dj-70s-rafi and
https://gaana.com/playlist/gaana-dj-top-hindi-songs-of-70s playlist
downloads few incorrect large files 150 MB to 400 MB.
If there is a parameter that limits matching song name and checks size of
a single file to less than 15 MB would be nice.
[image: image]
https://user-images.githubusercontent.com/33185115/32138204-3ca6ff24-bbf4-11e7-8081-2b1386c650c2.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/vishaltelangre/music-dl/issues/12, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA1eoxfuwUDz1LOItBO488O5HtYbkSlSks5sw43KgaJpZM4QKFIk
.

Its just converting the youtube videos matching with the title into the mp3. There's no proper audio. It's just video converter. Sorry but it's the truth.

@abhi1109 It is also described in the README document here: https://github.com/vishaltelangre/music-dl#does-it-really-download-from-these-sites

Does it really download from these sites?
Nope, it doesn't. It just retrieves the list of songs and information such as title, album, artists, etc. from these sites. It then downloads the matching music from YouTube.


generateSW is not working in version 0.2.0

When building the application manifest.webmanifest file is added twice to cached file list, that causes an error and the app become unavailable offline.
I created a repo using the official sveltekit skeleton app and a minimal configuration that you can use to verify the problem. You just need to build and preview the application to obtain the error:

Uncaught (in promise) add-to-cache-list-conflicting-entries: add-to-cache-list-conflicting-entries

@hawk93 checking latest kit changes, it is weird, the example here using kit v1.11.0 is working...

ok, the problem is there, the web manifest is added twice, but with your reproduction the hash changes, and that's the problem, using the example here works with duplicated entry:

@hawk93 your repro using local copy from #38, web manifest added only once, I'm going to publish a new patch version:

tested also with new patch version: https://github.com/vite-pwa/sveltekit/releases/tag/v0.2.1

@userquin I tested it too. It works now


Minor: Add comment explaining rationale for hash check

Which issue does this PR close?
Follow on to https://github.com/apache/datafusion/pull/11718
Closes #.
Rationale for this change
In https://github.com/apache/datafusion/pull/11718 @Rachelint  found that comparing hash values before group key values improved performance. The reason this could be faster was not obvious at first
What changes are included in this PR?
Add doc comments explaining the rationale and linking to https://github.com/apache/datafusion/pull/11718
Are these changes tested?
CI
Are there any user-facing changes?
No, just comments

Seems duckdb has the similar check(but just use the u16 prefix), maybe we can mention?
https://github.com/duckdb/duckdb/blob/f92559f42c118075baaa8daafc437954eb5c85ec/src/execution/aggregate_hashtable.cpp#L379-L386

Seems duckdb has the similar check(but just use the u16 prefix), maybe we can mention?
https://github.com/duckdb/duckdb/blob/f92559f42c118075baaa8daafc437954eb5c85ec/src/execution/aggregate_hashtable.cpp#L379-L386

The linked PR is interesting: https://github.com/duckdb/duckdb/pull/9575

maybe we can mention?

I am not sure what we would mention 🤔  Maybe can you propose the wording ?
Or maybe we can leave a comment to the duckdb art in one of the comments on https://github.com/apache/datafusion/pull/11718 ?

Seems duckdb has the similar check(but just use the u16 prefix), maybe we can mention?
https://github.com/duckdb/duckdb/blob/f92559f42c118075baaa8daafc437954eb5c85ec/src/execution/aggregate_hashtable.cpp#L379-L386

The linked PR is interesting: duckdb/duckdb#9575

Interesting, it seems the common point with #11718 is that we should consider the increasing collision when the hash table is filling up.

Interesting, it seems the common point with https://github.com/apache/datafusion/pull/11718 is that we should consider the increasing collision when the hash table is filling up.

In theory I think this is the kind of optimization that we are relying on hashbrown to do for us. Maybe there are some tuning knobs we could set but maybe we should just leave the defaults -- it seems to work reasonably well

Interesting, it seems the common point with #11718 is that we should consider the increasing collision when the hash table is filling up.

In theory I think this is the kind of optimization that we are relying on hashbrown to do for us. Maybe there are some tuning knobs we could set but maybe we should just leave the defaults -- it seems to work reasonably well

Yes, as @2010YOUY01 mentioned  in #11, hashbrown do a lot of design work about it.

Actually, I am thinking that, maybe exist a threshold (like xx% of the bucket have been filled), and it is just reasonable to check the hash first when exceed it.

It might be worth checking -- one thing that we have to be careful of is that the overhead of the check itself may end up large

Actually, I am thinking that, maybe exist a threshold (like xx% of the bucket have been filled), and it is just reasonable to check the hash first when exceed it.

It might be worth checking -- one thing that we have to be careful of is that the overhead of the check itself may end up large

Make sense, will make more experiments about this when having free time.
Another thing I found maybe we can optimize is about the group index. We use usize type now, it seems too big(which lead to the large size of hash table), maybe u32 is enough?
Actually u32 can hold 42 * (sizeof T) G entries.


Update Po.php

Function to Escape Control Characters like EOT from strings.

Thank you :+1:

No problem! ;)

I think we have a problem here: the control chars are not escaped, they are simply removed...

@Krato The recent changes to this repository will keep the bytes that you call "Control Characters like EOT"
That's because we can't strip out the bytes in the ranges \x01-\x09, \x0B, \x0C, \x0E-\x1F, x7F since they may be used in multibyte strings


update main

update main from develop

I think they are old, but not 100 % sure, will take a closer look. Should I update directly on this branch or on develop?

I think they are old, but not 100 % sure, will take a closer look. Should I update directly on this branch or on develop?

Thanks, Probably the warnings are harmless. May as well be on this branch I guess.

I have checked the warnings and renamed the workflow. From my understanding the warnings are nothing to worried about and I would keep this as it is. If you want to discuss this in more details, please let me know.


Snake game too difficult

Couple of suggestions to decrease difficulty:

make level score smaller , I.e. the score needed to move to next level
increase the number of points of fruit
shorten the time of the speed up

Done. I increased the number of points of fruit to 3, and shorten the time of speed up from 30 to 20. I keep the same level score. This will encourage eating fruits, and make it easier to reach the end of level. But will maintain the difficulty linked to the length of the snake.


chore: updated sdk, added wrapper in, and updated readme, for 3.0.0

What's in here:

New wrapper sdk with asset management, copilot, websockets, and caching features
Updated readme with examples of basic (wrapper) usage and advanced (core) usage
Also have updated core SDK to reflect latest from generated_runtime

Tested?

[x] Has been tested in the cli, neovim. and sublime
[x] Has been tested with shivay's streamlit x pieces repo

TODO before merge:

[ ] Get docs for wrapper on the docs site https://github.com/pieces-app/documentation/pull/547
[ ] Fix unit tests
[ ] Need to tag this with v3.0.0

@mark-at-pieces I will be changing something in the initialization
I want to change instead of the config["BasicUrl"] it should be config["host"]
+PiecesClient(config={'host': f'http://localhost:{port}'})
-PiecesClient(config={'baseUrl': f'http://localhost:{port}'})

as you can see here the config is like that in the API (pieces_os_client configuration) also we can make that variable for storing  other stuff that will be added to the configurations  eg username, password etc... which we will need later on when we enable payments

@mark-at-pieces I will be changing something in the initialization I want to change instead of config["BasicUrl"] it should be config["host"]
+PiecesClient(config={'host': f'http://localhost:{port}'})
-PiecesClient(config={'baseUrl': f'http://localhost:{port}'})

 as you can see here the config is like that in the API (pieces_os_client configuration) also we can make that variable for storing other stuff that will be added to the configurations eg username, password etc... which we will need later on when we enable payments

sounds good to me

just want to take note of this adjustment in the SDK for the future when updating the python SDK that we update back to this, but this is the only consideration im thinking about rn


'RNSkiaModule' could not be found. Verify that a module by this name is registered in the native binary., js engine: hermes

Description
I'm developing via expo. As soon as I upgraded to 0.1.222 of skia, I started to get this error:
_**ERROR  Invariant Violation: TurboModuleRegistry.getEnforcing(...): 'RNSkiaModule' could not be found. Verify that a module by this name is registered in the native binary., js engine: hermes
ERROR  Invariant Violation: "main" has not been registered. This can happen if:

Metro (the local dev server) is run from the wrong folder. Check if Metro is running, stop it and restart it in the current project.
A module failed to load due to an error and AppRegistry.registerComponent wasn't called., js engine: hermes**_

Version
0.1.222
Steps to reproduce
{
"name": "hamock-mobile",
"version": "1.0.0",
"main": "node_modules/expo/AppEntry.js",
"scripts": {
"start": "expo start",
"android": "expo start --android",
"ios": "expo start --ios",
"web": "expo start --web",
"eject": "expo eject",
"ts:check": "tsc"
},
"dependencies": {
"@expo-google-fonts/inter": "^0.2.3",
"@expo-google-fonts/montserrat": "^0.2.3",
"@expo-google-fonts/open-sans": "^0.2.3",
"@expo-google-fonts/quicksand": "^0.2.2",
"@expo-google-fonts/roboto": "^0.2.2",
"@expo-google-fonts/roboto-condensed": "^0.2.2",
"@expo-google-fonts/roboto-mono": "^0.2.3",
"@expo/vector-icons": "^13.0.0",
"@gorhom/bottom-sheet": "^4",
"@react-native-async-storage/async-storage": "1.18.2",
"@react-native-community/datetimepicker": "7.2.0",
"@react-native-community/netinfo": "9.3.10",
"@react-native-picker/picker": "2.4.10",
"@react-navigation/bottom-tabs": "^6.4.0",
"@react-navigation/native": "^6.0.13",
"@react-navigation/native-stack": "^6.9.1",
"@react-navigation/stack": "^6.3.16",
"@shopify/react-native-skia": "^0.1.222",
"@types/react": "~18.0.27",
"amazon-cognito-identity-js": "^6.2.0",
"aws-amplify": "^5.2.0",
"axios": "^1.3.1",
"d3": "^7.6.1",
"expo": "^49.0.13",
"expo-app-loading": "~2.1.0",
"expo-av": "~13.4.1",
"expo-blur": "~12.4.1",
"expo-font": "~11.4.0",
"expo-haptics": "~12.4.0",
"expo-location": "~16.1.0",
"expo-secure-store": "~12.3.1",
"expo-status-bar": "~1.6.0",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-native": "0.72.5",
"react-native-chart-kit": "^6.12.0",
"react-native-date-picker": "^4.3.3",
"react-native-gesture-handler": "~2.12.0",
"react-native-maps": "1.7.1",
"react-native-radio-buttons-group": "^3.0.2",
"react-native-reanimated": "~3.3.0",
"react-native-safe-area-context": "4.6.3",
"react-native-screens": "~3.22.0",
"react-native-svg": "13.9.0",
"react-native-toast-message": "^2.1.6",
"react-native-uuid": "^2.0.1",
"react-native-web": "~0.19.6"
},
"devDependencies": {
"@babel/core": "^7.18.6",
"@tsconfig/react-native": "^2.0.2",
"@types/d3": "^7.4.3",
"@types/jest": "^29.2.3",
"@types/react": "~18.2.14",
"@types/react-test-renderer": "^18.0.0",
"react-devtools": "^4.28.0",
"typescript": "^5.1.3"
},
"private": true
}
Snack, code example, screenshot, or link to a repository
{
"name": "hamock-mobile",
"version": "1.0.0",
"main": "node_modules/expo/AppEntry.js",
"scripts": {
"start": "expo start",
"android": "expo start --android",
"ios": "expo start --ios",
"web": "expo start --web",
"eject": "expo eject",
"ts:check": "tsc"
},
"dependencies": {
"@expo-google-fonts/inter": "^0.2.3",
"@expo-google-fonts/montserrat": "^0.2.3",
"@expo-google-fonts/open-sans": "^0.2.3",
"@expo-google-fonts/quicksand": "^0.2.2",
"@expo-google-fonts/roboto": "^0.2.2",
"@expo-google-fonts/roboto-condensed": "^0.2.2",
"@expo-google-fonts/roboto-mono": "^0.2.3",
"@expo/vector-icons": "^13.0.0",
"@gorhom/bottom-sheet": "^4",
"@react-native-async-storage/async-storage": "1.18.2",
"@react-native-community/datetimepicker": "7.2.0",
"@react-native-community/netinfo": "9.3.10",
"@react-native-picker/picker": "2.4.10",
"@react-navigation/bottom-tabs": "^6.4.0",
"@react-navigation/native": "^6.0.13",
"@react-navigation/native-stack": "^6.9.1",
"@react-navigation/stack": "^6.3.16",
"@shopify/react-native-skia": "^0.1.222",
"@types/react": "~18.0.27",
"amazon-cognito-identity-js": "^6.2.0",
"aws-amplify": "^5.2.0",
"axios": "^1.3.1",
"d3": "^7.6.1",
"expo": "^49.0.13",
"expo-app-loading": "~2.1.0",
"expo-av": "~13.4.1",
"expo-blur": "~12.4.1",
"expo-font": "~11.4.0",
"expo-haptics": "~12.4.0",
"expo-location": "~16.1.0",
"expo-secure-store": "~12.3.1",
"expo-status-bar": "~1.6.0",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-native": "0.72.5",
"react-native-chart-kit": "^6.12.0",
"react-native-date-picker": "^4.3.3",
"react-native-gesture-handler": "~2.12.0",
"react-native-maps": "1.7.1",
"react-native-radio-buttons-group": "^3.0.2",
"react-native-reanimated": "~3.3.0",
"react-native-safe-area-context": "4.6.3",
"react-native-screens": "~3.22.0",
"react-native-svg": "13.9.0",
"react-native-toast-message": "^2.1.6",
"react-native-uuid": "^2.0.1",
"react-native-web": "~0.19.6"
},
"devDependencies": {
"@babel/core": "^7.18.6",
"@tsconfig/react-native": "^2.0.2",
"@types/d3": "^7.4.3",
"@types/jest": "^29.2.3",
"@types/react": "~18.2.14",
"@types/react-test-renderer": "^18.0.0",
"react-devtools": "^4.28.0",
"typescript": "^5.1.3"
},
"private": true
}

@CoreyBovalina Got the same error and I'm not using Expo.

Indeed this version is not supported with expo sdk 49.
@hadnet If you have a small reproduction, let us know.

Indeed this version is not supported with expo sdk 49.
@hadnet If you have a small reproduction, let us know.

Solved. It was an issue with another library, nothing to do with Skia. Thank you.

@wcandillon, I encountered the same issue using a brand-new expo project. I wanted to test skia out. I used "@shopify/react-native-skia": "0.1.229" version with  "expo": "~49.0.21", as well as with downgraded versions 46, 47. The problem remains the same.
Any idea I can launch it with Expo?

@hadnet how did you resolve the issue;

Some dependencies are incompatible with the installed expo version
Solution:
npx expo install --fix
Doing that will let expo upgrade or downgrade the version of each package for compatibility purpose

Hi, having this issue without expo and the following repos, please help!
{
"name": "my-app",
"version": "0.0.1",
"private": true,
"scripts": {
"android": "react-native run-android",
"ios": "react-native run-ios",
"lint": "eslint .",
"start": "react-native start",
"test": "jest"
},
"dependencies": {
"react": "18.2.0",
"react-native": "0.72.4",
"react-native-fast-tflite": "^1.2.0",
"react-native-reanimated": "^3.12.1",
"react-native-vision-camera": "^4.0.3",
"react-native-worklets-core": "^1.3.0",
"vision-camera-resize-plugin": "^3.1.0"
},
"devDependencies": {
"@babel/core": "^7.20.0",
"@babel/preset-env": "^7.20.0",
"@babel/runtime": "^7.20.0",
"@react-native/babel-preset": "^0.74.81",
"@react-native/eslint-config": "^0.72.2",
"@react-native/metro-config": "^0.72.11",
"@tsconfig/react-native": "^3.0.0",
"@types/react": "^18.0.24",
"@types/react-test-renderer": "^18.0.0",
"babel-jest": "^29.2.1",
"eslint": "^8.19.0",
"jest": "^29.2.1",
"metro-react-native-babel-preset": "0.76.8",
"prettier": "^2.4.1",
"react-test-renderer": "18.2.0",
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
}
}

FYI - I was able to resolve this issue by building apk on EAS using eas build --profile development command. Download and install apk on device. And using installed apk for further development.

Still relevant issue, has anyone fixed it?