pymssql: init at 2.1.4

Motivation for this change
Missing package from python collection
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python2.pkgs.pymssql python3.pkgs.pymssql

Success on x86_64-linux (full log)
Attempted: python2.pkgs.pymssql, python3.pkgs.pymssql
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/miq4qyj4dcwdxpwba5k1gwx32iwq0iyl-python3.6-pymssql-2.1.4
shrinking /nix/store/miq4qyj4dcwdxpwba5k1gwx32iwq0iyl-python3.6-pymssql-2.1.4/lib/python3.6/site-packages/_mssql.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/miq4qyj4dcwdxpwba5k1gwx32iwq0iyl-python3.6-pymssql-2.1.4/lib/python3.6/site-packages/pymssql.cpython-36m-x86_64-linux-gnu.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/miq4qyj4dcwdxpwba5k1gwx32iwq0iyl-python3.6-pymssql-2.1.4/lib
patching script interpreter paths in /nix/store/miq4qyj4dcwdxpwba5k1gwx32iwq0iyl-python3.6-pymssql-2.1.4
checking for references to /build in /nix/store/miq4qyj4dcwdxpwba5k1gwx32iwq0iyl-python3.6-pymssql-2.1.4...
/nix/store/68qm8zllkckplf6iyjphskc43j2w943h-python2.7-pymssql-2.1.4
/nix/store/miq4qyj4dcwdxpwba5k1gwx32iwq0iyl-python3.6-pymssql-2.1.4

Success on aarch64-linux (full log)
Attempted: python2.pkgs.pymssql, python3.pkgs.pymssql
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ximijw720yrzzawd0b77c7k7l7aihn90-python3.6-pymssql-2.1.4
shrinking /nix/store/ximijw720yrzzawd0b77c7k7l7aihn90-python3.6-pymssql-2.1.4/lib/python3.6/site-packages/_mssql.cpython-36m-aarch64-linux-gnu.so
shrinking /nix/store/ximijw720yrzzawd0b77c7k7l7aihn90-python3.6-pymssql-2.1.4/lib/python3.6/site-packages/pymssql.cpython-36m-aarch64-linux-gnu.so
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ximijw720yrzzawd0b77c7k7l7aihn90-python3.6-pymssql-2.1.4/lib
patching script interpreter paths in /nix/store/ximijw720yrzzawd0b77c7k7l7aihn90-python3.6-pymssql-2.1.4
checking for references to /build in /nix/store/ximijw720yrzzawd0b77c7k7l7aihn90-python3.6-pymssql-2.1.4...
/nix/store/9l1v0vn7b2h0p4alhqhri7wk825r9z2k-python2.7-pymssql-2.1.4
/nix/store/ximijw720yrzzawd0b77c7k7l7aihn90-python3.6-pymssql-2.1.4

Success on x86_64-darwin (full log)
Attempted: python2.pkgs.pymssql, python3.pkgs.pymssql
Partial log (click to expand)
Processing ./pymssql-2.1.4-cp36-cp36m-macosx_10_6_x86_64.whl
Installing collected packages: pymssql
Successfully installed pymssql-2.1.4
/private/tmp/nix-build-python3.6-pymssql-2.1.4.drv-0/pymssql-2.1.4
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kwjs32dqw5wkcxj1i2j1ibp57xahfmpp-python3.6-pymssql-2.1.4/lib
patching script interpreter paths in /nix/store/kwjs32dqw5wkcxj1i2j1ibp57xahfmpp-python3.6-pymssql-2.1.4
/nix/store/nkyd6avjnlfvyimaw7a5mw7r8j9j1nz3-python2.7-pymssql-2.1.4
/nix/store/kwjs32dqw5wkcxj1i2j1ibp57xahfmpp-python3.6-pymssql-2.1.4

@GrahamcOfBorg build python2.pkgs.pymssql python3.pkgs.pymssql

Success on x86_64-darwin (full log)
Attempted: python2.pkgs.pymssql, python3.pkgs.pymssql
Partial log (click to expand)
Processing ./pymssql-2.1.4-cp37-cp37m-macosx_10_6_x86_64.whl
Installing collected packages: pymssql
Successfully installed pymssql-2.1.4
/private/tmp/nix-build-python3.7-pymssql-2.1.4.drv-0/pymssql-2.1.4
post-installation fixup
strip is /nix/store/rk3p99jbj4idl3dkkg1rxja5gz0qgs98-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/s429mp3qb281qpjg058c24rfigdmymsw-python3.7-pymssql-2.1.4/lib
patching script interpreter paths in /nix/store/s429mp3qb281qpjg058c24rfigdmymsw-python3.7-pymssql-2.1.4
/nix/store/cjm097p9fw0g3ggqz6w6cmdbbl1fhk05-python2.7-pymssql-2.1.4
/nix/store/s429mp3qb281qpjg058c24rfigdmymsw-python3.7-pymssql-2.1.4

Success on aarch64-linux (full log)
Attempted: python2.pkgs.pymssql, python3.pkgs.pymssql
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h3id44b8pgwjg431pp35mp3ykfl7z3c7-python3.7-pymssql-2.1.4
shrinking /nix/store/h3id44b8pgwjg431pp35mp3ykfl7z3c7-python3.7-pymssql-2.1.4/lib/python3.7/site-packages/_mssql.cpython-37m-aarch64-linux-gnu.so
shrinking /nix/store/h3id44b8pgwjg431pp35mp3ykfl7z3c7-python3.7-pymssql-2.1.4/lib/python3.7/site-packages/pymssql.cpython-37m-aarch64-linux-gnu.so
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h3id44b8pgwjg431pp35mp3ykfl7z3c7-python3.7-pymssql-2.1.4/lib
patching script interpreter paths in /nix/store/h3id44b8pgwjg431pp35mp3ykfl7z3c7-python3.7-pymssql-2.1.4
checking for references to /build in /nix/store/h3id44b8pgwjg431pp35mp3ykfl7z3c7-python3.7-pymssql-2.1.4...
/nix/store/ij95pfgv3s746pvl5yfwq6qygwdc8pk4-python2.7-pymssql-2.1.4
/nix/store/h3id44b8pgwjg431pp35mp3ykfl7z3c7-python3.7-pymssql-2.1.4

Success on x86_64-linux (full log)
Attempted: python2.pkgs.pymssql, python3.pkgs.pymssql
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lyjfmmv66kyfh46qwqilwnwcc6biw2gz-python3.7-pymssql-2.1.4
shrinking /nix/store/lyjfmmv66kyfh46qwqilwnwcc6biw2gz-python3.7-pymssql-2.1.4/lib/python3.7/site-packages/pymssql.cpython-37m-x86_64-linux-gnu.so
shrinking /nix/store/lyjfmmv66kyfh46qwqilwnwcc6biw2gz-python3.7-pymssql-2.1.4/lib/python3.7/site-packages/_mssql.cpython-37m-x86_64-linux-gnu.so
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lyjfmmv66kyfh46qwqilwnwcc6biw2gz-python3.7-pymssql-2.1.4/lib
patching script interpreter paths in /nix/store/lyjfmmv66kyfh46qwqilwnwcc6biw2gz-python3.7-pymssql-2.1.4
checking for references to /build in /nix/store/lyjfmmv66kyfh46qwqilwnwcc6biw2gz-python3.7-pymssql-2.1.4...
/nix/store/aaxc22j5lk28rb56ih9xzk7v0sfr3ff3-python2.7-pymssql-2.1.4
/nix/store/lyjfmmv66kyfh46qwqilwnwcc6biw2gz-python3.7-pymssql-2.1.4


Fix for importing Ramda in ESM-compatible nodes

closes #2988
This all is quite new in general. node has added support for ESM just recently so keep in mind that I can't guarantee that this covers everything ideally, but I've done the research and some testing and I'm positive about this working correctly. If any problems arise from this - just ping me and I will prepare appropriate fixes (hopefully this won't be necessary though).

This looks really good to me.
I have one concern, and that is that the changes are fairly inscrutable without your fantastic comments. Somebody who isn't already well versed in package.json files wouldn't know why things are set up the way they are.
Is this an issue? Should we look at hacking in some comments?

Is this an issue? Should we look at hacking in some comments?

Sure, I can write this down somewhere. Not sure though if package.json itself is the right place to do so 😅 If you want to keep it there I'm OK with that - just let me know where should I put it.

I honestly don't know where we should put it ¯\_(ツ)_/¯

Anyone understand why GitHub is saying that some checks are incomplete, but that Travis is saying they are complete?
One had failed before for what looked like spurious reasons.  I restarted, and it looks fine on Travis, but GitHub is saying otherwise.  Any ideas?
Other than that, this looks great to me.  I think I would rather point to this pull than try to hack comments into package.json, although I really do wish that commenting JSON were easier to do.
:herb:

@CrossEye Can we just merge anyway since we can still visually verify the CI completed successfully?

@Bradcomp: I was planning on giving it two days in case someone who understood what happened with Travis pointed out some flaw I didn't understand.  But yes, I think we can merge soon.

If this causes any problem (hopefully not) then please just ping me and i will try to find a fix for it


postgresql14JitPackages.pgrouting: 3.6.1 -> 3.6.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/pgRouting/pgrouting/releases.
meta.description for postgresql14JitPackages.pgrouting is: A PostgreSQL/PostGIS extension that provides geospatial routing functionality
meta.homepage for postgresql14JitPackages.pgrouting is: https://pgrouting.org/
meta.changelog for postgresql14JitPackages.pgrouting is: https://github.com/pgRouting/pgrouting/releases/tag/v3.6.2
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.6.2 with grep in /nix/store/4kz1dfl4wjhkmrjvhvmcl67qfs12ifi6-pgrouting-3.6.2
found 3.6.2 in filename of file in /nix/store/4kz1dfl4wjhkmrjvhvmcl67qfs12ifi6-pgrouting-3.6.2

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

12 package rebuild(s)

First fifty rebuilds by attrpath
postgresql12JitPackages.pgrouting
postgresql12Packages.pgrouting
postgresql13JitPackages.pgrouting
postgresql13Packages.pgrouting
postgresql14JitPackages.pgrouting
postgresql14Packages.pgrouting
postgresql15JitPackages.pgrouting
postgresql15Packages.pgrouting
postgresql16JitPackages.pgrouting
postgresql16Packages.pgrouting
postgresqlJitPackages.pgrouting
postgresqlPackages.pgrouting

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/4kz1dfl4wjhkmrjvhvmcl67qfs12ifi6-pgrouting-3.6.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A postgresql14JitPackages.pgrouting https://github.com/r-ryantm/nixpkgs/archive/268464bd8a4b53ceb561ea661ea250217bb602cd.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/268464bd8a4b53ceb561ea661ea250217bb602cd#postgresql14JitPackages.pgrouting

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/4kz1dfl4wjhkmrjvhvmcl67qfs12ifi6-pgrouting-3.6.2
ls -la /nix/store/4kz1dfl4wjhkmrjvhvmcl67qfs12ifi6-pgrouting-3.6.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

10 packages built:

postgresql12JitPackages.pgrouting
postgresql12Packages.pgrouting
postgresql13JitPackages.pgrouting
postgresql13Packages.pgrouting
postgresql14JitPackages.pgrouting
postgresql14Packages.pgrouting
postgresql15JitPackages.pgrouting
postgresql15Packages.pgrouting
postgresql16JitPackages.pgrouting
postgresql16Packages.pgrouting

Maintainer pings
cc @imincik @nh2 @nialov @sikmir @willcohen @steve-chavez for testing.

Duplicate to #300347 .


Add ENABLE_DEBUG_TOOLBAR to settings

I want to merge this change because...
#3978
Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] Database migration files are up to date.
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] GraphQL schema and type definitions are up to date.
[ ] Changes are mentioned in the changelog.

Since it's a PR for the debug toolbar, could you take a minute to bump django-debug-toolbar-request-history to 0.0.10? I made a minor change to the toolbar's request history, it now shows the requests methods, which is quite useful for backend developers.

@NyanKiyoshi lets bump dependencies in another PR


How to create new boards? Where is Admin panel?

Hi,
I was just searching new imageboard script to try found yours just now, I installed it but couldnt figure out how to create new boards and reach admin panel.
Is this functions implemented ?
Thanks.

No, those are not implemented (at least yet). You can create new boards via database at the moment. I might create admin panel and some other moderation features, like board creating and thread deleting etc. when I have more time. Thanks. :)


Unmasking and random word in MLM

Hi
I have a question regarding the unmasking and random word replacement in the pretraining. Given a list of indices of masked words, the following function unmasks some of them with a given probability and replaces other with a random word ID.
However, this should happen on a per-word basis rather than be the same for the entire sequence, so should p not be generated for every index, that is inside the for loop? Right now, as I understand the code at least, unmasking/random word replacement either happens or not for the entire sequence of masked words rather than on a word by word basis.
Thanks for the help in advance.
def perform_masking(indices: List[int]):
    p = random.random()
    for index in indices:
        masked_lm_labels[index] = output_word_ids[index]
        if p < (1.0 - self._random_word_prob - self._unmasked_word_prob):
            output_word_ids[index] = self._mask_id
        elif p < (1.0 - self._unmasked_word_prob):
            output_word_ids[index] = random.randint(self._pad_id + 1, self._tokenizer.vocab_size - 1)

Function taken from here: https://github.com/studio-ousia/luke/blob/master/luke/pretraining/batch_generator.py#L160

Hi @asgerius,
This function takes indices argument which is a list containing subword indices corresponding to a single word (not entire sequence). When we mask a word containing multiple subwords and whole_word_masking is set to True, we use the same strategy for all subwords.

Yes, that makes perfect sense. Thanks for clearinng up my confusion :)


Buiding caffe error: undefined reference to `cv::imread(cv::String const&, int)'

Hi, when I run build_all.sh, I got the error below:
..........................................
[ 98%] Scanning dependencies of target convert_mnist_siamese_data
Scanning dependencies of target pycaffe
Building CXX object examples/CMakeFiles/convert_mnist_data.dir/mnist/convert_mnist_data.cpp.o
[100%] Building CXX object examples/CMakeFiles/convert_mnist_siamese_data.dir/siamese/convert_mnist_siamese_data.cpp.o
[100%] Building CXX object python/CMakeFiles/pycaffe.dir/caffe/_caffe.cpp.o
Linking CXX executable mnist/convert_mnist_data
../lib/libcaffe.so: undefined reference to cv::imread(cv::String const&, int)' ../lib/libcaffe.so: undefined reference to cv::String::allocate(unsigned long)'
../lib/libcaffe.so: undefined reference to cv::String::deallocate()' ../lib/libcaffe.so: undefined reference to cv::imencode(cv::String const&, cv::_InputArray const&, std::vector<unsigned char, std::allocator >&, std::vector<int, std::allocator > const&)'
collect2: error: ld returned 1 exit status
make[2]: *** [examples/mnist/convert_mnist_data] Error 1
make[1]: *** [examples/CMakeFiles/convert_mnist_data.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
Linking CXX executable compute_image_mean
Linking CXX executable cifar10/convert_cifar_data
Linking CXX executable device_query
../lib/libcaffe.so: undefined reference to cv::imread(cv::String const&, int)' ../lib/libcaffe.so: undefined reference to cv::String::allocate(unsigned long)'
../lib/libcaffe.so: undefined reference to cv::String::deallocate()' ../lib/libcaffe.so: undefined reference to cv::imencode(cv::String const&, cv::_InputArray const&, std::vector<unsigned char, std::allocator >&, std::vector<int, std::allocator > const&)'
collect2: error: ld returned 1 exit status
make[2]: *** [tools/compute_image_mean] Error 1
make[1]: *** [tools/CMakeFiles/compute_image_mean.dir/all] Error 2
[100%] Built target device_query
../lib/libcaffe.so: undefined reference to cv::imread(cv::String const&, int)' ../lib/libcaffe.so: undefined reference to cv::String::allocate(unsigned long)'
../lib/libcaffe.so: undefined reference to cv::String::deallocate()' ../lib/libcaffe.so: undefined reference to cv::imencode(cv::String const&, cv::_InputArray const&, std::vector<unsigned char, std::allocator >&, std::vector<int, std::allocator > const&)'
collect2: error: ld returned 1 exit status
make[2]: *** [examples/cifar10/convert_cifar_data] Error 1
make[1]: *** [examples/CMakeFiles/convert_cifar_data.dir/all] Error 2
Linking CXX executable siamese/convert_mnist_siamese_data
Linking CXX executable train_net
Linking CXX executable convert_imageset
Linking CXX executable upgrade_net_proto_binary
[100%] Linking CXX executable net_speed_benchmark
Built target train_net
../lib/libcaffe.so: undefined reference to cv::imread(cv::String const&, int)' ../lib/libcaffe.so: undefined reference to cv::String::allocate(unsigned long)'
../lib/libcaffe.so: undefined reference to cv::String::deallocate()' ../lib/libcaffe.so: undefined reference to cv::imencode(cv::String const&, cv::_InputArray const&, std::vector<unsigned char, std::allocator >&, std::vector<int, std::allocator > const&)'
collect2: error: ld returned 1 exit status
make[2]: *** [examples/siamese/convert_mnist_siamese_data] Error 1
make[1]: *** [examples/CMakeFiles/convert_mnist_siamese_data.dir/all] Error 2
[100%] Built target net_speed_benchmark
Linking CXX executable test_net
../lib/libcaffe.so: undefined reference to cv::imread(cv::String const&, int)' ../lib/libcaffe.so: undefined reference to cv::String::allocate(unsigned long)'
../lib/libcaffe.so: undefined reference to cv::String::deallocate()' ../lib/libcaffe.so: undefined reference to cv::imencode(cv::String const&, cv::_InputArray const&, std::vector<unsigned char, std::allocator >&, std::vector<int, std::allocator > const&)'
collect2: error: ld returned 1 exit status
make[2]: *** [tools/convert_imageset] Error 1
make[1]: *** [tools/CMakeFiles/convert_imageset.dir/all] Error 2
../lib/libcaffe.so: undefined reference to cv::imread(cv::String const&, int)' ../lib/libcaffe.so: undefined reference to cv::String::allocate(unsigned long)'
../lib/libcaffe.so: undefined reference to cv::String::deallocate()' ../lib/libcaffe.so: undefined reference to cv::imencode(cv::String const&, cv::_InputArray const&, std::vector<unsigned char, std::allocator >&, std::vector<int, std::allocator > const&)'
collect2: error: ld returned 1 exit status
make[2]: *** [tools/upgrade_net_proto_binary] Error 1
make[1]: *** [tools/CMakeFiles/upgrade_net_proto_binary.dir/all] Error 2
Linking CXX executable upgrade_net_proto_text
[100%] Built target test_net
Linking CXX executable finetune_net
[100%] Built target finetune_net
../lib/libcaffe.so: undefined reference to cv::imread(cv::String const&, int)' ../lib/libcaffe.so: undefined reference to cv::String::allocate(unsigned long)'
../lib/libcaffe.so: undefined reference to cv::String::deallocate()' ../lib/libcaffe.so: undefined reference to cv::imencode(cv::String const&, cv::_InputArray const&, std::vector<unsigned char, std::allocator >&, std::vector<int, std::allocator > const&)'
collect2: error: ld returned 1 exit status
make[2]: *** [tools/upgrade_net_proto_text] Error 1
make[1]: *** [tools/CMakeFiles/upgrade_net_proto_text.dir/all] Error 2
................................................................
Enviroment:

python2.7.6(system itself) and annconda2.7.12（install path: ~/annoconda2）
opencv3.0.0(install before) and opencv(2.4.12)(install by running build_all.sh default)

Tried:
its seems that it can not find the corresponding libopencv_xx, so i just add the path by the following operation:

add "opencv-2.4.12/build/lib" to ~/bashrc
add "opencv-2.4.12/build/lib" to /etc/ld.so.conf.d/opencv.conf

However, it make no sense.

It is possible you compile with one version of OpenCV but link with the other one. Please refer to build_all.sh for build commands.

So, How can I known that which OpenCV version does it used when compiling, and when linking ?  For example, if the executable file is produced ( e.g. caffe ), then we could use command: "ldd caffe | grep opencv" to see which version did it used.
Referd to you recommandation,  I tried the following steps:

change cmake configurations commands as:
OpenCV_DIR=../../../3rd-party/opencv-$version/build/
OpenCV_LIB_DIR=../../../3rd-party/opencv-$version/build/lib
cmake .. -DCUDA_USE_STATIC_CUDA_RUNTIME=OFF

adjust the CMakeCache.txt built on caffe-action:
adding ------- OpenCV_LIB_DIR:PATH="$TSN_Root/3rd-party/opencv-$version/build/lib"

However, it make no sense. And I found that if the OpencvConfig.cmake could be found correctly, the corresponding LIB_PATH of Opencv also should be parsed correctly ?
Then, I compile dense_flow use OpenCV-2.4.12, and compile caffe-action use OpenCV-3.0.0,
the project was build successfully.
I'm wondering if something else problem would be occurred ?

If you have some time to look at the manual of CMake, you will find that
make VERBOSE=1 will do a build which prints all compile commands. So you can see possible problems related to library versions.

@sunnyxiaohu  我遇到了相同的问题，用opencv3编译之后会遇到什么问题吗


removed browse prefix for osmLinks

The prefix browse/ is not needed anymore.
https://www.openstreetmap.org/browse/node/xxxxx
is redirected to
https://www.openstreetmap.org/node/xxxxx

Thanks!


The uploader receives bad requests when setting CI env in GitHub actions

Describe the bug
When I run the codecov uploader in the docker container, everything is fine until I set up environment variables using the first technique mentioned in the following article:
https://docs.codecov.com/docs/testing-with-docker
Then the uploader complains about bad requests:
Detected GitHub Actions as the CI provider.
Pinging Codecov: https://codecov.io/upload/v4?package=uploader-0.1.0&token=*******&branch=test/migrate-to-shellspec&build=1039293011&build_url=undefined%2Fdustin71728%2Fyarn-2-completion%2Factions%2Fruns%2F1039293011&commit=24eb740b7574622e2af937f65c74e97292ab9448&job=default&pr=&service=github-actions&slug=dustin71728/yarn-2-completion&name=&tag=&flags=&parent=
https://codecov.io/upload/v4?package=uploader-0.1.0&branch=test/migrate-to-shellspec&build=1039293011&build_url=undefined%2Fdustin71728%2Fyarn-2-completion%2Factions%2Fruns%2F1039293011&commit=24eb740b7574622e2af937f65c74e97292ab9448&job=default&pr=&service=github-actions&slug=dustin71728/yarn-2-completion&name=&tag=&flags=&parent=
        Content-Type: 'text/plain'
        Content-Encoding: 'gzip'
        X-Reduced-Redundancy: 'false'
Error!: Error: Error uploading to https://codecov.io: Error: Error uploading to Codecov: Error: Bad Request

I wonder if the root cause is that the build_url query parameter is not a well-formatted URL. It is a  literal undefined string in the host part of the URL.
So I try to set up CI_BUILD_URL with the correct value, but it still doesn't work.
The failed log( In Run yarn test step):
https://github.com/dustin71728/yarn-2-completion/runs/3091016225?check_suite_focus=true
The log printed out all the environment variables returned from the command:
"ci_env=bash <(curl -s https://codecov.io/env)"
https://github.com/dustin71728/yarn-2-completion/runs/3090999690?check_suite_focus=true
The successful log without CI environment variables involved:
https://github.com/dustin71728/yarn-2-completion/runs/3081701233?check_suite_focus=true
References
Dockerfile: https://github.com/dustin71728/yarn-2-completion/blob/test/migrate-to-shellspec/docker/bash-5-0.Dockerfile
Github Action YAML file: https://github.com/dustin71728/yarn-2-completion/blob/test/migrate-to-shellspec/.github/workflows/default.yaml
Expected behavior
The uploader should upload the coverage report when the CI is true in the docker container running on Github action.

Getting the same with

 codecov -t ******* -f lcov-lines.info -v

     _____          _
    / ____|        | |
   | |     ___   __| | ___  ___ _____   __
   | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
   | |___| (_) | (_| |  __/ (_| (_) \ V /
    \_____\___/ \__,_|\___|\___\___/ \_/

  Codecov report uploader 0.1.0
=> Project root located at: /builds
Start of network processing...
Searching for files in /builds

....

Search complete for files in /builds
End of network processing
Processing lcov-lines.info...
Detected Local as the CI provider.
Pinging Codecov: https://codecov.io/upload/v4?package=uploader-0.1.0&token=*******&branch=master&build=&build_url=&commit=e5b400bee45556d948cf0e818f9d8ffc016fe09b&job=&pr=&service=&slug=paritytech/ink&name=&tag=&flags=&parent=
https://codecov.io/upload/v4?package=uploader-0.1.0&branch=master&build=&build_url=&commit=e5b400bee45556d948cf0e818f9d8ffc016fe09b&job=&pr=&service=&slug=paritytech/ink&name=&tag=&flags=&parent=
        Content-Type: 'text/plain'
        Content-Encoding: 'gzip'
        X-Reduced-Redundancy: 'false'
Error!: Error: Error uploading to https://codecov.io: Error: Error uploading to Codecov: Error: Bad Request

@TriplEight do you mind opening a separate issue for this if you are not using GitHub Actions? I think it's a different cause, and I'd like to be able to keep track of the issues to make sure they are taken care of.

@dustin71728, I made a change to the uploader, are you still experiencing the issue?

@thomasrockhu
Thanks for the effort, I can confirm that GITHUB_SERVER_URL is produced by curl -s https://codecov.io/env
± |main {1} ?:3 ✗| → env GITHUB_ACTIONS=1 bash <(curl -s https://codecov.io/env)
-e CODECOV_ENV -e CODECOV_TOKEN -e CODECOV_URL -e CODECOV_SLUG -e VCS_COMMIT_ID -e VCS_BRANCH_NAME -e VCS_PULL_REQUEST -e VCS_SLUG -e VCS_TAG -e CI_BUILD_URL -e CI_BUILD_ID -e CI_JOB_ID -e GITHUB_ACTIONS -e GITHUB_HEAD_REF -e GITHUB_REF -e GITHUB_REPOSITORY -e GITHUB_RUN_ID -e GITHUB_SERVER_URL -e GITHUB_SHA -e GITHUB_WORKFLOW

awesome @dustin71728, closing this out


Updating Notice.txt to match the recommended Microsoft template

Guidance can be found here: https://docs.opensource.microsoft.com/content/using/required-notice-template.html

@kurtzeborn - Is this still an active work stream or should we close out the PR?

@kurtzeborn - I'm going to close this out as there hasn't been recent activity.  Please feel free to reopen if you're still working on these changes.


test_G diverges from avg_r and avg_G during training

This is more of a question than it is a specific bug issue.
When running the lunar landing example exactly as it is in the repo, the avg_r and avg_G learns very quickly and very well.  However, the test_G that gets returned during the period test runs, is sharply diverged values.  Is this expected behavior?  Intuitively it would seem like the test metrics and the training metrics should be closely aligned.  Here is an example of avg_r and avg_G performing well according to the gymnasium set up, but performing very poorly in test_G:
[TrainMonitor|INFO] ep: 371,	T: 115,812,	G: 269,	avg_r: 0.398,	avg_G: 259,	t: 675,	dt: 39.606ms,	v: 73.9,	Rn: 100,	loss: 3.73,	training_step: 1.86e+04,	test_G: -25.6 [TrainMonitor|INFO] ep: 381,	T: 119,332,	G: 225,	avg_r: 0.45,	avg_G: 250,	t: 499,	dt: 50.396ms,	v: 61.4,	Rn: 90.8,	loss: 3.74,	training_step: 1.9e+04,	test_G: -13 [TrainMonitor|INFO] ep: 391,	T: 122,811,	G: 264,	avg_r: 0.524,	avg_G: 241,	t: 503,	dt: 53.950ms,	v: 73.2,	Rn: 108,	loss: 3.75,	training_step: 1.96e+04,	test_G: -20 [TrainMonitor|INFO] ep: 401,	T: 126,207,	G: 254,	avg_r: 0.485,	avg_G: 246,	t: 524,	dt: 49.395ms,	v: 72.5,	Rn: 103,	loss: 3.78,	training_step: 2e+04,	test_G: -7.67 [TrainMonitor|INFO] ep: 411,	T: 128,995,	G: 277,	avg_r: 1.29,	avg_G: 249,	t: 215,	dt: 118.231ms,	v: 82.2,	Rn: 180,	loss: 3.82,	training_step: 2.06e+04,	test_G: -44.1
Steps to recreate:
Run the lunar_landing example file in the repo.
Thank you for making such a great repo!

After further inspection, it appears because during the training, the seed is passed, so it trains on the same environment variant of the gym each time.  But during test, no seed is passed.
Given the current structure of the library, you actually cant train without passing a seed to training, which is a bug I think.


Supplied components

Coverage decreased (-0.4%) to 98.384% when pulling 52cc9c262b3709fe42c9b6818f2eee027dce9bdd on supplied-components into 3566fc542988be703e7af31c53a2145394634f5c on master.

Coverage decreased (-0.4%) to 98.385% when pulling f14b5059728378383450c9a464652f907d40edba on supplied-components into 3566fc542988be703e7af31c53a2145394634f5c on master.


Action in Custom stepper step.

Can we perform an action when a custom type component is rendered within a custom stepper step? I attempted to do this in the ngOnInit method, but the component is activated when the stepper is rendered. How can I modify my approach?
https://stackblitz.com/edit/angular-eeo4ub?file=src/app/app.component.ts

In order to know if the field is rendered within a custom stepper step either pass a custom option to props or check the parent:
1- pass a custom option to props
{
  key: 'test',
  type: 'customInput',
  props: {
    label: 'test',
    required: true,
+ stepper: true,
  },
},

...
export class CustomInputComponent extends FieldType implements OnInit {
  ngOnInit() {
    if (this.props.stepper) {
      console.log('rendered in step');
    }
  }
}

2- check the parent:
export class CustomInputComponent extends FieldType implements OnInit {
  ngOnInit() {
    // Note: use while loop to check all ancestors
    if (this.field.parent.type === 'stepper') {
      console.log('rendered in step');
    }
  }
}


Runtime error: invalid memory address or nil pointer dereference

https://github.com/gcushen/hugo-academic/blob/7cc95ba2526b651d9328fd199632c28c738e5a85/layouts/partials/tags.html#L6
The above line causes run time error if tag name has space in it.

@gcushen urlize is not required here. urlize converts space to %20 and $.Site.GetPage is returning <nil> in this case. Removing urlize solves the issue.

@prateekkumarweb thanks for finding and reporting this bug from a recent update! Should be fixed now by the above commit :)


Switching Dictionaries Doesn't Autosearch Current Search Term

I use multiple translation dictionaries and straight English dictionaries too. Many times I enter a word and then I notice it is the wrong dictionary so I then switch dictionaries and the word remains in the search field but QuickDic does not use it to search. I have to delete the last character of the word then type it again to get the app to search the word.
It would make more sense when a dictionary is changed with an active search term that it then automatically searches that term.
To reproduce:

Enter a word and watch it automatically search that word
Switch dictionaries
Delete last letter of the search term
Put that letter back

Now it autosearches.
Autosearch should autosearch immediately after dictionary switch.
This should be easy to code. Just add one line to search after dictionary switch.

I cannot reproduce, and I am fairly sure I fixed that.
Are you sure you use the latest version? 5.5.1 preferably?
If yes, it might be an issue specific to certain versions of Android or certain devices.
Please provide more detail in that case, but if I am not able to reproduce the issue that greatly reduces the chances of a fix.

I am using QuickDic 5.5.1 and yes, it is the same issue for me, it has not been fixed.
I am using Lineage OS 16.0 (Android 9) on a Pixel 2 (walleye).

I have tested with Lineage OS 15.1 on LG G4 and Android 9 on a Sony XZ1 and the emulator images.
I start the app, press the x next to the search to clear the previous one, enter "test", tap the flag on the top left, then tap some other flag in the popup list.
It immediately jumps to test/testament whatever is closes in the new dictionary.
Anything you do differently that would explain why you see the issue and I don't?

The dictionaries I am using are English and English-French, English-Spanish, English-German, and many more. When I hit the flag for English or any of its pairs it fails to search. Instead it stays at the top of the dictionary like you had not entered anything.
It is very strange it doesn't work for me but does for you.
I am wondering if more people have the reaction you have or if more people have my issue.
Maybe uninstalling the app and reinstalling it from F-Droid would fix it...

No, I just uninstalled QuickDic and reinstalled it from F-Droid and downloaded the dictionaries again and it has the same issue... it will not autosearch the current term after dictionary switch.
QuickDic 5.5.1 (ID 106)
This is quite strange...
are there any google dependencies? I am using open gapps pico...

I tried with the F-Droid version to be sure, but it also is fine with that.
No Google stuff is used by the app, so that should not be it.
However I wonder if it might be related to the keyboard in use.
I have "Android Keyboard (AOSP)" and SwiftKey in use currently.
The other option if you are comfortable with it would be to capture a debug level logcat, which should show a whole lot of printouts related to the search that should be auto-triggered when switching languages. Which might help me find some code to review in more detail.

Funny, I did find a comment though:
// Without this extra delay, the call to jumpToRow that this
// invokes doesn't always actually have any effect.
There seems to be no extra delay though.

Ah, I could reproduce it now, by reducing a couple of random delays in the code.

I am not sure this issue is 100% fixable, it feels like a race condition deep in the ListView code, where if it has not entirely processed a setAdapter call it fails to set the position in the list.
But I've seen some improvements with the change, so it would be good if the new build could be tested:
Dictionary-issue120.zip

So, I changed keyboards to AOSP and the search now works fine in 5.5.1.
I was using AnySoftKeyboard. I had no idea searching could be related to the keyboard.
I just tried the new prerelease version above with AnySoftKeyboard and it also works! So, it looks like you fixed the problem!

Fixed version is now in Google Play beta, F-Droid should follow after it got some testing here.
Thus closing.


Basic TOC button for jupyter notebooks

For #7305

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

I thought there was going to be a setting to turn it on/off?

Isn't there a limit to the enumber of icons we can have in the global toolbar?
Hope this doesn't result in some of our other icons being hidden (going into overflow)

A couple of notes here.

I made the button only enabled if the outline view is not visible and expanded. I could change this to just be visible if the notebook is open at all. Felt better to me this way, but I'm open to having it always available. Just feels funny as the button doesn't do much then, just moved the keyboard focus over.
I called the short name (shown on the button) 'Outline' as it seemed shorter and more concise than "Table of Contents" long name in the palette is Jupyter: Open Notebook Outline
Right now the button is available for any notebooks, but this doesn't mean that they have anything in the TOC, so it's not as useful for notebooks like this (see below):

I could engineer this to be disabled in these cases. The bit that seems iffy to me is that this outline content is based on vscode core code, we'd have to figure out a way to check if the outline view actually has content or not in a context key. I think that it requires markdown headers right now, but we'd be relying on that not changing if we were to base visibility on that. So I left that off for now.

@rchiodo Totally forgot the setting, I'll update with that added.

@claudiaregio and @greazer  for UX visibility on this review.

Isn't there a limit to the enumber of icons we can have in the global toolbar?
Hope this doesn't result in some of our other icons being hidden (going into overflow)

Yeah, I get ya. On my monitor it's not bad, as it's right next to the overflow button.

Could be an issue, but I am adding the setting to hide.

I made the button only enabled if the outline view is not visible and expanded. I could change this to just be visible if the notebook is open at all. Felt better to me this way, but I'm open to having it always available. Just feels funny as the button doesn't do much then, just moved the keyboard focus over.

So the behavior you have right now is pretty much identical to that of the Variables Window right? Basically, if either window isn't visible and usable, then the button is enabled. If it's already being shown on the screen in a usable way, then it's disabled.

I called the short name (shown on the button) 'Outline' as it seemed shorter and more concise than "Table of Contents" long name in the palette is Jupyter: Open Notebook Outline

Label seems ok to me. The main thing here is to make it more discoverable at all. Might want to consider creating a "wrapper" command called "Jupyter: Show Table of Contents (Outline View)" that is identical to "Explorer: Focus on Outline View"

Position is always right of Variables icon.

Any particular reason? My quick thinking is that more people have likely asked for TOC than Variables Window. Ensuring that it's more likely to not be relegated to overflow seems like a good idea. BUT I'm not sure it matters much.

Right now the button is available for any notebooks, but this doesn't mean that they have anything in the TOC, so it's not as useful for notebooks like this (see below):

The user can turn on code to be shown in the outline view. "Notebook: Outline: Show Code Cells", so it's not like this would always be the case for notebooks without markdown. Seems ok to me.

@greazer Inline.

So the behavior you have right now is pretty much identical to that of the Variables Window right? Basically, if either window isn't visible and usable, then the button is enabled. If it's already being shown on the screen in a usable way, then it's disabled. Consistency here is the right way to go.

Yup, if outline is off screen, or onscreen but collapsed the button is enabled. If it's on screen and expanded disable the button. Seemed smart as if it was on screen it was hard to even see that anything had happened when you clicked the button (only moved keyboard focus) made it seem a bit broken.

Label seems ok to me. The main thing here is to make it more discoverable at all. Might want to consider creating a "wrapper" command called "Jupyter: Show Table of Contents (Outline View)" that is identical to "Explorer: Focus on Outline View"

So the long title does show up in the command palette currently. Currently it's "Jupyter: Open Notebook Outline" but your text does have Table of Contents in it, so that might be a good change. I can change that.

Any particular reason? My quick thinking is that more people have likely asked for TOC than Variables Window. Ensuring that it's more likely to not be relegated to overflow seems like a good idea. BUT I'm not sure it matters much.

I was seeing it the other way around (variables over TOC) but I don't have data to back that up aside from our old requests for variable views being very upvoted. Mild preference would be to keep it how I have it as it add the "new" icon to the least dominate position so "Variable" will be in the same location for users muscle memory.

The user can turn on code to be shown in the outline view. "Notebook: Outline: Show Code Cells", so it's not like this would always be the case for notebooks without markdown. Seems ok to me.

Yeah, it seemed like it would open a bigger can of worms to try to check that.

Codecov Report

Merging #7651 (4c9af07) into main (5ea9ffc) will increase coverage by 0%.
The diff coverage is 50%.

:exclamation: Current head 4c9af07 differs from pull request most recent head a6c0084. Consider uploading reports for the commit a6c0084 to get more accurate results

@@          Coverage Diff          @@
##            main   #7651   +/-   ##
=====================================
  Coverage     68%     68%
=====================================
  Files        363     363
  Lines      22546   22537    -9
  Branches    3430    3428    -2
=====================================
+ Hits       15490   15510   +20
+ Misses      5724    5700   -24
+ Partials    1332    1327    -5

Impacted Files
Coverage Δ

src/client/datascience/commands/commandRegistry.ts
35% <33%> (-1%)
:arrow_down:

src/client/datascience/constants.ts
99% <100%> (+<1%)
:arrow_up:

.../kernel-launcher/localKnownPathKernelSpecFinder.ts
89% <0%> (-3%)
:arrow_down:

src/client/datascience/jupyter/jupyterNotebook.ts
25% <0%> (+<1%)
:arrow_up:

...client/datascience/commands/activeEditorContext.ts
91% <0%> (+<1%)
:arrow_up:

src/client/datascience/jupyter/kernels/helpers.ts
72% <0%> (+1%)
:arrow_up:

src/client/datascience/jupyter/kernelVariables.ts
53% <0%> (+1%)
:arrow_up:

...datascience/editor-integration/cellhashprovider.ts
72% <0%> (+1%)
:arrow_up:

.../localPythonAndRelatedNonPythonKernelSpecFinder.ts
81% <0%> (+2%)
:arrow_up:

...datascience/editor-integration/codelensprovider.ts
74% <0%> (+4%)
:arrow_up:

... and 2 more


Question: How to bypass /static path to next.js?

Let's  say, you want to get some static files to be load on pages (like img) with next.js (https://nextjs.org/docs/basic-features/static-file-serving). Right now all links to /static path will be captured with nest.js. You can use @nestjs/serve-static but it is unpleasant to use. Is were are some way to pass this matter to nest-next?
Nest-next version: 9.1.5
Next version: 9.3.3
Nest: 7.0.9

Ok, after read render.filter.ts i understand what any request not handled by nest controllers go to next. So i order to provide static file you need to create directory static in next project root.
Example:

However, public folder did not work for me. What is strange, Next.js supporting it from 9.1 version.
So i think we need to do 2 thinks:

Check how pass static file through /public directory, not the /static directory. We need this because /static directory is deprecated. (https://github.com/zeit/next.js/blob/master/errors/static-dir-deprecated.md)
Write guide in README.md how to handle static file and add pages that access static files in examples.

This was recently brought up in #47.
One of the main problems is how Nextjs handles the public files. Let's say that you have a fresh nextjs install without any nest integrations and you have your logo saved to /public/images/logo.png. If you try to access that file with that path it will 404, but if you try to access it at /images/logo.png next will correctly resolve the path.
So this brings up the question of how do we know what requests are for a static files since we can't just check if the req starts with public. From what I can tell, when next's server is generating all of the routes, it generates a list of all the public routes too. I am not sure if we should just take their lead, and generate a list of all the routes for public assets, but I am open to suggestions.

@Xilel I just added a new config option, see this comment for some info on how to get the public directory working

why dont you just add a static serving module in NestJS lol

@stevefan1999-personal That should work fine as long as you want to have Nest serve the static content rather than Next. Next allows for serving static content from the public folder but then performs a "rewrite" on the URL. So if you have an asset such as public/my-image.png, it can be accessed from /my-image.png.

@kyle-mccarthy well but it sort of works. Hell, I was even able to get next/image to work too. So I take that as a practical workaround, still the better solution is what you proposed (if I got right of your idea), when you hit 404 in Next, and try to see if the URL is starting in one of the public/static folders and redirect whenever possible.


Replace React Native FAQ

Fixes #2689

@esbenp your blog post is simply lovely 😍
Way better than our outdated FAQ.

Codecov Report

Merging #2691 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2691   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          67      67
  Lines        1380    1380
======================================
  Hits         1380    1380

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b403d...7042658. Read the comment docs.

Appreciate the warm words @gustavohenke :-) cool to be part of the docs :+1:

Totally worthy post. 👍


Tests of the driver testsuite should not be replaced by modified versions

As discussed in https://github.com/minkphp/Mink/issues/654, this is lying about the fact that the driver implements the API properly. The driver testsuite is precisely here to ensure all drivers behave in a consistent way. So if the implementation does not behave the same, you should see it failing (it is perfectly fine to see failures in your testsuite for now, until you fix the driver. much better than hiding them)

I will take a look at this, but last time i saw, to make it work i have to do some serious changes in the javascript function evaluation. First setp is to take a look at the separation between driver and extension and then do this fix.

Well, this is a requirement to make the driver implement the driver API.

the first step would probably be to run the real tests, allowing to see what the failures are. Then you can make changes 1 by 1 fixing some of these tests. This is what we did on our own drivers when adding all the new driver tests in 1.6+ (and actually, SahiDriver does not yet pass the testsuite, and we have red builds to show it)

Will definitely do this now that all is splitted.

Working on it right now.

@jcalderonzumba How its going with that?

Is a bit complicated, most of the problems are in the part of javascript evaluation or execution, PhantomJS way of handling javascript needs to be double check in order to pass the default tests of MinkDriver.

@jcalderonzumba for the executeScript and evaluateScript tests, you probably need to normalize the input to support all of them. All Mink drivers need to do it (none of the implementation support all syntaxes natively, but they all support different ones natively)

yes @stof i'm looking into that, there are also another tests that fail not related to javascript like BasicAuth that i'm having troubles with mainly because the way PhantomJS is behaving with BasicAuth even though i'm "reseting" everything internally.
With enough time i'm confident i'll sort it out or get to a point where the number of failures are the minimum i can get.

update, crazy times at work that i could not take "personal" time from work to the project as when we i was developing it but i'm still trying to get this done in the proper way.

@jcalderonzumba Well, perfect is the enemy of good. Push any kind of start of work onto a local branch, maybe someone will pick it up if they are bored

@stof @dawehner I started the hard work, i've been busy and slacking. So i removed the self made replacement of test to start fixing step by step. Work is here:
https://github.com/jcalderonzumba/MinkPhantomJSDriver/tree/issue_38
Travis results are here:
https://travis-ci.org/jcalderonzumba/MinkPhantomJSDriver/jobs/96028156
I managed to fix the BestPracticesTest test suite and now will continue to look problem by problem but i saw the following notice not related with the Driver:
The Symfony\Component\CssSelector\CssSelector class is deprecated since version 2.8 and will be removed in 3.0. Use directly the \Symfony\Component\CssSelector\CssSelectorConverter class instead: 1x
1x in ContentTest::testOuterHtml from Behat\Mink\Tests\Driver\Basic

@stof any news about this? I guess is Mink related.
I'll keep posting things here or in mink if while trying to fix the test i see something that actually needs fix in Mink and not in the Driver (it can happen).

@jcalderonzumba Mink already fixed this usage of the deprecated class in its dev version. It will be released this weekend. Your Travis build sees it because it runs against the stable version of Mink

@jcalderonzumba I suggest you to open a PR with your branch. It is easier to provide review comments on a PR than on a branch

For this branch i'm working on?

@jcalderonzumba yeah. We generally open PRs from branches in which we work, not for abandonned branches :smile: This allows commenting on the work being done.
Note that some of the test failures you have are related to the bug I'm fixing in https://github.com/jcalderonzumba/MinkPhantomJSDriver/pull/49

I think this can be close, new mink driver test suite has been added.


Sweep: FastAPI-Based CMS Template Repository

CMS Backend Template Specification
Introduction
This document outlines the technical specification for a CMS backend template built using FastAPI, PostgreSQL, SQLModel, and JWT-based authentication. It aims to provide a structured and scalable solution suitable for various content management needs.
System Overview
FastAPI: A high-performance web framework to build the API layer.
PostgreSQL: A relational database management system for persisting application data.
SQLModel: A library combining the capabilities of SQL databases with FastAPI to provide ORM functionalities.
Docker: A platform to automate application deployment inside lightweight, portable containers.
JWT: JSON Web Token used for authentication and session management.

Key Features

Dockerized Deployment
A Dockerfile will be provided for the FastAPI application.
A docker-compose.yml file will be created to handle multi-container applications, including the FastAPI application, PostgreSQL database, and any other potential services.
This setup will allow developers to initiate the entire system locally or in production with a single command: docker-compose up.

JWT-based Authentication
Utilize FastAPI's built-in OAuth2 password flow to issue JWT tokens.
Protect routes with JWT tokens ensuring only authenticated users can access particular endpoints.
JWT tokens will have an expiration time, after which users will be required to re-authenticate.

User Roles
Two primary roles: administrator and non-administrator.
Administrators will have full access to all functionalities and data.
Non-administrators will have restricted access. Specific restrictions can be defined based on project requirements.

Database Structure
Users Table
    id: UUID
    username: String
    hashed_password: String
    role: ENUM (administrator, non-administrator)
    is_active: Boolean
    Other profile-related fields.

Contents Table
    id: UUID
    title: String
    body: Text
    created_at: Timestamp
    updated_at: Timestamp
    author_id: ForeignKey (Users)

Other tables can be added based on project-specific requirements.

API Endpoints
Authentication
    POST /token: Authenticate users and return a JWT token.
    GET /users/me: Get the current user's details.

Users
    POST /users: Create a new user (Administrator only).
    GET /users: List all users (Administrator only).
    GET /users/{user_id}: Retrieve a specific user's details.
    PUT /users/{user_id}: Update a specific user's details.
    DELETE /users/{user_id}: Delete a specific user.

Content
    POST /content: Create a new content piece.
    GET /content: List all content.
    GET /content/{content_id}: Retrieve a specific content piece.
    PUT /content/{content_id}: Update a specific content piece.
    DELETE /content/{content_id}: Delete a specific content piece.

Error Handling
Use FastAPI's built-in exception handlers.
Custom exceptions can be defined for application-specific errors.

Testing
FastAPI's dependency injection system will be utilized to replace specific components during testing.
Use pytest for testing functionalities.

Security
Utilize FastAPI's security utilities to hash passwords before storing them in the database.
Ensure HTTPS to encrypt data in transit.
Set CORS policies appropriately to restrict unintended cross-origin requests.

Conclusion
This specification provides a high-level overview of the proposed CMS backend template. Implementing the system according to this specification will ensure a scalable, secure, and efficient content management solution. Detailed technical design and architecture will follow this specification.

Checklist

[X] Dockerfile ✅ Commit f43e2ae

• Add instructions to build a Docker image for the FastAPI application.
• Install necessary dependencies for the FastAPI application.

 Read documentation
    Our documentation can be found at https://docs.trunk.io

 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io

trunk fmt Dockerfile 2/3 ✅

Found no applicable linters for the requested path

trunk check --fix Dockerfile 3/3 ❌ (`1`)

  ISSUES

Dockerfile:0:0
 0:0  high  Specify at least 1 USER command in Dockerfile with non-root user as argument  trivy/DS002
 0:0  high  Add HEALTHCHECK instruction in your Dockerfile                                trivy/DS026

  FAILURES

 install_shims_for_checkov  Installing shims for tool checkov  .trunk/out/zIDF2.yaml

  NOTICES

 A tool failed to run. You can open the details yaml file for more information.

Checked 1 file
✖ 2 new issues

[X] docker-compose.yml ✅ Commit e671094

• Add services for the FastAPI application and PostgreSQL database.
• Define the necessary environment variables and volumes for each service.

 Read documentation
    Our documentation can be found at https://docs.trunk.io

 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io

trunk fmt docker-compose.yml 2/3 ✅

 ✔ Formatted docker-compose.yml

Re-checking autofixed files...

Checked 1 file
✔ No issues

trunk check --fix docker-compose.yml 3/3 ❌ (`1`)

  ISSUES

docker-compose.yml:7:9
  7:9   high  string value is redundantly quoted with any quotes  yamllint/quoted-strings
 22:9   high  string value is redundantly quoted with any quotes  yamllint/quoted-strings
 31:17  high  empty value in block mapping                        yamllint/empty-values

Checked 1 file
✖ 3 new issues

[X] app/main.py ✅ Commit cf7a609

• Set up the FastAPI application.
• Define the API endpoints for authentication, users, and content as specified in the issue.

 Read documentation
    Our documentation can be found at https://docs.trunk.io

 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io

trunk fmt app/main.py 2/3 ✅

 ✔ Formatted app/main.py

Re-checking autofixed files...

 ✔ Formatted app/main.py

Re-checking autofixed files...

Checked 1 file
✔ No issues

trunk check --fix app/main.py 3/3 ❌ (`1`)

 ✔ Auto-fixed app/main.py

Re-checking autofixed files...

  ISSUES

app/main.py:10:45
 10:45  high  Undefined name `OAuth2PasswordRequestForm`                   ruff/F821
 10:73  high  Do not perform function call `Depends` in argument defaults  ruff/B008
 14:25  high  Undefined name `status`                                      ruff/F821
 23:46  high  Do not perform function call `Depends` in argument defaults  ruff/B008
 63:11  high  Redefinition of unused `read_content` from line 58           ruff/F811

Checked 1 file
✖ 5 new issues

[ ] app/models.py
• Define the SQLModel classes for the Users and Contents tables as specified in the issue.

[ ] app/security.py
• Implement JWT-based authentication using FastAPI's OAuth2 password flow.
• Implement password hashing using FastAPI's security utilities.

[ ] README.md
• Provide instructions on how to use the CMS template.
• Include information on how to build and run the Docker containers.

Hey Ryan, we just fixed some issues so this ticket will be a lot more readable!


remove appsub for ACM hub CRDs in hypershift hosted cluster deployment.

Signed-off-by: morvencao<EMAIL_ADDRESS>

/lgtm


Problem with color settings on Rival 500

Hi,
Just trying the software and found that -C indeed does not work on Rival 500.  -c or --logo-color changes both the logo and the wheel at the same time.
Perhaps the color registers are packed or shifted and they must be both written at the same time?
Originally posted by @ChrisDWhitehead in https://github.com/flozz/rivalcfg/issues/189#issuecomment-2071324237

Hello,
Thank you for your repport, can you provide the output of the rivalcfg --print-debug command so we have the basic information about Rivalcfg, you system and the device?
I have a Rival 500 at home so I may be able to test/reproduce the issue as soon I find some time to work on this :)

RIVALCFG
Version: 4.13.0
udev rules installed: True
udev rules up to date: True
Installation path: /usr/local/lib/python3.10/dist-packages/rivalcfg
OPERATING SYSTEM
OS: Linux
Platform: Linux-5.15.0-105-generic-x86_64-with-glibc2.35
Version: #115-Ubuntu SMP Mon Apr 15 09:52:04 UTC 2024
Distribution issue: Linux Mint 21.3 Virginia \n \l
PYTHON
Python version: 3.10.12
HIDAPI version: 0.14.0
PLUGGED STEELSERIES DEVICES ENDPOINTS
1038:170e | 00 | SteelSeries Rival 500 Gaming Mouse (firmware v101.0)
1038:170e | 01 | SteelSeries Rival 500 Gaming Mouse (firmware v101.0)
1038:170e | 02 | SteelSeries Rival 500 Gaming Mouse (firmware v101.0)

I apologize for the strange formatting, but apparently some of the formating of the output triggers some HTML formatting. The underlines are actually a string of '=' but it gets re-interpreted. I tried using code mode but it didn't do anything.

Yeah a part of the text was interpreted as Markdown syntax. You can put RAW content using 3 backtick:

```
RAW CONTENT HERE
```


Problem with batch update

Hello again, I have a problem with Update method.
I have something like this
 context.Table
        .Where(x => x.Condition == true)
        .Update(x => new TableEntity
        {
            Property1 = x.Property2
        });

and this library generates SQL similar to this
UPDATE A
SET A.[Property1] =  B.[Property2] AS [Property2]
FROM [dbo].[Table] AS A
INNER JOIN ( SELECT
    [Extent1].[Id] AS [Id],
    [Extent1].[Property1] AS [Property1],
    [Extent1].[Property2] AS [Property2]
    FROM [dbo].[Table] AS [Extent1]
    WHERE (Condition == 1) AS B ON A.[Id] = B.[Id]

it can't be executed because  AS [Property2] in the second row. It throws Incorrect syntax near the keyword 'AS'.
Can you do something with it?
For example here is SQL that is generated by EF.Extended from the same code:
UPDATE [dbo].[Table] SET
[Property1] = [Property2]
FROM [dbo].[Table] AS j0 INNER JOIN (
SELECT
    [Extent1].[Id] AS [Id]
    FROM [dbo].[Table] AS [Extent1]
    WHERE ([Condition == 1)
) AS j1 ON (j0.[Id] = j1.[Id])

and it works

Hello @Immelstorn ,
Thank you for reporting.
We will look at this issue this week.
Best Regards,
Jonathan

Hello @Immelstorn ,
The issue has been successfully fixed.
The fix will be released within a few hours.
Best Regards,
Jonathan

Hello @Immelstorn
The v1.6.7 has been released.
Let me know if you still have the issue.
Best Regards,
Jonathan


[perf] Block PR on performance regression

This is very simple diff that will block PR if performance falls below hardcoded limit
Expectation that for now we going to update this limit manually, until better tooling comes in place
We want this to avoid more painful revert process that we have right now when regression is detected.

LGTM. Delegating review to @sausagee

@bors-libra r+

:pushpin: Commit a724486 has been approved by sausagee

@bors-libra retry

@bors-libra r=sausagee

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #2691

:pushpin: Commit a724486 has been approved by sausagee

@bors-libra r=sausagee

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #2606

:pushpin: Commit a724486 has been approved by sausagee

@bors-libra r=sausagee

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #2664

:pushpin: Commit a724486 has been approved by sausagee

:hourglass: Testing commit a7244864c8dc6bb423b524f4256d9e9d43f17aca with merge 6928e68b2ea111c12b92de6e64daeac13f5e2c50...

@bors-libra retry

@bors-libra r+ p=10
This should move it back to the first in the queue.

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #2674

:pushpin: Commit a724486 has been approved by sausagee

:hourglass: Testing commit a7244864c8dc6bb423b524f4256d9e9d43f17aca with merge e9514d3ee548a033784ce8518039ba5b62994a05...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sausagee
Pushing e9514d3ee548a033784ce8518039ba5b62994a05 to master...


Data Types Testing Issue

The tests of data types (semantic/types) use the values returned from a .create() call, .create() retrieved only auto incremented ids from the table so the values returned in callback will be the same values passed as parameters, that's why the test should insert, and then query the table to retrieve the persistent value.

Looks good– thanks! :+1:

You are welcome ! ;)

@khalilTN, @atiertant, this does look good indeed! This has exposed an apparent bug in sails-mongo since it is breaking the test:

Semantic Interface Binary Type with valid data should store proper binary value

build log line 536: https://travis-ci.org/balderdashy/waterline-adapter-tests/jobs/61589255#L536
We'll need to fix that before we can merge this to avoid breaking the build. I've raised balderdashy/sails-mongo#272 to address the sails-mongo issue.

@dmarcelino there is no better demonstation about this tests are useful...

Indeed! :smiley:
@khalilTN, @atiertant, it just occurred to me that this change make us lose the verification of the values returned by .create(). Can we also add checks to those, like:
  assert(createdRecord.list.length === 4);

I've submitted PR balderdashy/sails-mongo#274 which fixes balderdashy/sails-mongo#272.

I have commited the tests for the record returned by .create().

Perfect @khalilTN! Thank you.


Remove inline forward declaration of CheckFinite

LibTooling (Clang) seems to have some trouble with the "inline forward declaration" of `CheckFinite'. Removing it looks safe and it is now also more consistent with the existing design in this file. I am not even sure if the explicit inline statement for the forward declaration is the issue or some but in LibTooling lingering.
This is e.g. relevant for wrapper codegen.

@termi-official, if this is ready, can you please add the ready-for-review label, so we don't forget to start the review process?

Thanks for the pointer. I am still investigating. I think we can merge this, but this does not seem like the only one causing trouble. Maybe I can come up with a fix in the C++ parser instead. I will report back soon anyway.


NOT Support HTML tags in my ios app

I am using katex in my ios app and it failed to render HTML tags like <small><i> etc . When I try to render HTML tags it shows blank text view .

@ParveshChauhan can you provide some more details about what you're trying to do?  What HTML are you loading into the web view in your app?

Like I want to display this simplify:  so i use <i>simplify: </i> code but text view is empty ,shows nothing.

If the currency symbol is within the LaTeX code you're trying to render you will get an exception as we don't support this unicode symbol.  Check the console for errors.  You should see something like:
ParseError: KaTeX parse error: Expected 'EOF', got '₹' at position 1: ₹̲

so what should i do for render symbol or it is possible or not and what about html tags ?

@ParveshChauhan I'm not sure what's happening with the HTML tags not displaying.  As for adding ₹ we'll need to find a font that contains the symbol and extra metrics for it.  What package(s) are you using to rendering this in LaTeX?

HTML tags are not LaTeX, so it will not render if given to KaTeX. Also, we have an issue to track adding currency symbols like ₹ in https://github.com/KaTeX/katex-fonts/issues/18. Please feel free to ask or open new issue if you have any other questions.

when i try this Html type of string  "<img src="http://latex
The Image is not showing and
console response is  -
[plugin] AddInstanceForFactory: No factory registered for id <CFUUID 0x600003cf7080> F8BB1C28-BAE8-11D6-9C31-00039315CD46
[] nw_protocol_get_quic_image_block_invoke dlopen libquic failed
WF: === Starting WebFilter logging for process Example
WF: _userSettingsForUser : (null)
WF: _WebFilterIsActive returning: NO
Please Help What i'm doing Wrong

@iOSharsh That doesn't sound like a KaTeX issue.  Also, if you find an issue with KaTeX, please open a new issue with a complete example.

@edemaine
okay but can i explain my issues here?

@iOSharsh You'd be better off posting in a help forum specific to iOS development (or wherever the issue might be). Perhaps StackOverflow?

Hey @edemaine
please Check is it Your's Example
https://github.com/ratala1/KaTeX-MathView-Swift
i'm using this swift File


Rewrite job worker

Description
Rewrote job worker completely.
Job Handling
The worker now allows to handle jobs concurrently. Via a new configuration HandlerThreads you can set the thread count, which are used to handle activated jobs. Make sure your given Handler implementation is thread-safe. Per default the HandlerThread is set to 1, to be backwards compatible.
Interaction between Handling and Polling
Fixed some concurrency issues in activating and job handling, which caused that either for a longer time no jobs are polled or not handled or polled to fast. Poll interval are now respected better. It is rewritten in a way that it is now also better testable.
Job Polling
Introducing an threshold activation mechanism, which means that new jobs are only activated after the working queue reaches a threshold of 0.6.
Example:
maxActivationCount = 32
threshold = Ceil(32 * 0.6) = 20
If the maxActivationCount is set to 32, then for first twelve jobs no new jobs are activated. After going under 20 jobs it will poll again for new jobs, based on the work queue (32 - work queue count). This allows to batch better job activation it will reduce the load on the gateway and broker and avoids doing to much requests for a single job activation.
Related issues
closes #133
closes #149

@saig0 do you want and have time to check this?

I can have a look. But remember that I have zero C# knowledge :joy:

Thanks! I think this is fine. It's more about the concept.


[QUESTION] Is there a way to specify timezone in DateTime64Field?

Looks like it's hardcoded to 'UTC'

Looks like it's hardcoded to 'UTC'

This is intentional, to be consistent with the behavior of postgresql backend.

Anyway, do you really need to set timezone in database level? The recommended way to deal with timezone is using django.utils.timezone module.


docs(deps): remove markdown-it as dev dependency

Hi there,
in my opinion  markdown-it is direct dependency of vitepress-plugin-search and does not need to be imported as devDependency. Or do I miss a point?
Great work, anyway! 🌹

I'm make some tests.. but you are probably right 😁
I'll drop this PR since I'm making other changes and I can include this one in it.


WIP: Add $observe helper

This will add an $observe() helper to let users watch other components for changes. Likely I will limit the scope to other Alpine components only.
I might set this up to either automatically update a property on the child, or let the callback run after a mutation is found. Or both.

This is almost ready, but I might make a few more tweaks, as well as take any input from others. I've added it to a demo here: https://codepen.io/KevinBatdorf/pen/OJNXzpJ

Closed in favor of #3 which covers this and more


Rails 5 support

This gem is dependent on jimson-temp, which is dependent on rack (~> 1.4). Rails 5 is dependent on rack (~> 2.x). There's a pull request to loosen the dependency (https://github.com/mindeavor/jimson/pull/2), but no activity since it was opened.

Also, I'm not sure why this is depending on jimson-temp instead of just jimson, which has a similar issue: https://github.com/chriskite/jimson/issues/32.

thanks for your help. Maybe you want to fix this issue?

Looks like the jimson-temp dependency was replaced with multi_json in #342. I'm using in Rails 5 now and have no issues.

Yep, this should be resolved now! Thanks for pointing it out.


conda error

Hello
Thank you all for putting the code together for this project – the work is really exciting!
I encountered conflicts between PyTorch, NumPy, DGL, RxnFP, and others while installing.
Thank you!

Thank you very much for your recognition of our work. We have provided an automated configuration script and directly made the Python environment accessible. You can use the script for configuration or manually set up the relevant Python environment as needed.


SqlLab page can't handle UTF-8 codec

Hi all, I would like to report another bug here: The SqlLab can’t handle the UTF-8 codec. Steps to reproduce:

Run a query that can retrieve data from foreign country and I got the following error as the first 2 screenshots (either sync query or async query).
When I used other software tool (including browser) to run the same query, we can get the result displayed as the 3rd and 4th screenshots

Without the problem solved, we can’t create charts with data including character in UTF-8 or even other format. It would be great to get it fixed in current 1.2 branch before we can upgrade to 1.3. Thanks.

According to the error messages, this seems to be an issue with Snowflake, and not with sql lab. Was this a regression that used to work in superset, or did you only now notice the issue. I would be inclined to think that there's not an issue with superset here, given that i've used utf-8 characters with Presto fine, but let me know if you think differently before I close the issue

0xe9 is a bytestring; perhaps it should be cast to_char(column, 'utf-8') first? Or, more appropriately, correct the data stored in Snowflake…because it seems like some entries are storing data in that column as a binary rather than a UTF-8-encoded string.

Could you please try to reproduce this issue with a minimal example which does not depend on any existing table? Something like:.
select 'éèëē ñäâæ öøœ' as unicode_chars
This way we can narrow down, if @spdustin's suspicion  is true and anyone with a Snowflake DB can reproduce the bug, if it still exists.

@rumbin Yes, when running the query you provided, I could get the result without any problem. However, the input from all of the editors in any software is compliant with UTF-8 and can't reproduce the scenario that happened on our end where data came from different sources or are collected from 3rd party. It's hard to enforce all of our sources to convert the non-UTF8 bytes to UTF8 bytes.
Also, as I mentioned in this ticket earlier, Snowflake (for some reasons) can convert these byte string back to UTF-8 characters and displayed well in the browser. DBVisualizer does similar thing that can convert byte into some non-human readable characters, but at least it won't cause the error when running the query.
The following query goes through in Chrome browser connecting Snowflake account (meaning that Snowflake implemented both frontend and backend for the endpoint service with our Snowflake account) and in DBvisualizer, but it throws an error in SqlLab.
select install_country, install_city
from my_table
where return_date between current_date - 10 and current_date - 1
    and install_country = 'Venezuela' and endswith(install_city, 'rida')
limit 100;

I know the data are not perfect, but what I wanted was to have the query goes through, so we can create chart on dashboard. I'm ok if those non-human readable characters  are displayed in the charts.

Is anyone still facing this in current-era Superset? Tempted to close this due to inactivity, but I don't want to close it if it's still causing issues.

Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please re-open this issue, open a new Issue with updated context, or raise a PR to address the problem. Thanks!


support for OpenTargets

OpenTargets is an EBI project which we would like to link out to. I just added the BridgeDb record for it: https://github.com/bridgedb/datasources/commit/d1311c5fb9e589d65ad602dae41398c6e36b9078
They use Ensembl identifiers internally, and I like to request to add Ensembl<>OpenTargets mapping, basically both with the same ID, but with different Datasource (system code: Opt; there is no identifiers.org record, as far as I can see).

@BZdrazil, maybe you can help with setting this up?


DOMError and UnknownError

I got the error in "catch" callback,
err:DOMError
err.name:UnknownError
how to do with the UnknowError?

It happens when the underlying indexedDB implementation has some kind of serious problem, such as locked file or similar. There's nothing you could do. But it's interesting to know what platform you get this error on.

iOS9 Safari
most happened in iframe,and use toArray method

I use MacBook to inspect,and in dexie.js file ,"eventRejectHandler" method line 2,I output the event.target below:
IDBRequest = $1
error: DOMError {name: "UnknownError"}
onerror: function(event)
onsuccess: function()
readyState: "done"
result: null
source: IDBObjectStore
autoIncrement: false
indexNames: DOMStringList {length: 0, item: function, contains: function}
keyPath: "xxx_key"
name: "xxx_tbl"
transaction: IDBTransaction {mode: "readwrite", db: IDBDatabase, error: null, onabort: function, oncomplete: function, …}
IDBObjectStore プロトタイプ
transaction: IDBTransaction
db: IDBDatabase {name: "BBitIDB", version: 120, objectStoreNames: DOMStringList, onabort: null, onerror: null, …}
error: null
mode: "readwrite"
onabort: function(e)
oncomplete: function(e)
onerror: function(e)

I get this error a lot on Safari. Luckily, they announced they made a lot of improvements to IndexedDB in their upcoming version Safari 10
Hopefully this will be resolved!


Add sci_version tag to AMI on creation

If sci_verion as missing scylla-cluter-tests fails to use
those AMIs with the correct user-data

@bentsi why aren't we merging this ? until we'll address the renaming and such.
this could still prevent waste of resources, like we've seen


adjust TAF store directives for mom_fluxform.F and mom_vecinv.F, and solve_tri/pentadiagonal.F

What changes does this PR introduce?
cleanup and suggestion
What is the current behaviour?

part of the routine bodies of mom_fluxform.F and mom_vecinv.F are recomputed in AD mode;
AUTODIFF_ALLOW_VISCFACADJ related code only in mom_vecinv.F
recomputation warnings in verification/global_oce_ biogeo_bling because of solve_tri/pentadiagnonal.F with SOLVE_DIAGONAL_KINNER defined
lots of warnings that make it difficult to read taf_ad.log

What is the new behaviour

less of the routine bodies are recomputed in AD mode at the cost of increased memory overhead
AUTODIFF_ALLOW_VISCFACADJ related code added to mom_fluxform.F to be consistent with mom_vecinv.F
in general, storing strategies are more consistent between mom_fluxform.F and mom_vecinv.F
no more recomputation warnings in verification/global_oce_ biogeo_bling
remove conflict warnings and some unused tape and "storing not necessary" warnings
remove unnecessary checkpointing code from pkg/smooth_diff2/3d.F

Does this PR introduce a breaking change?
no, but with commit 1ee65c6, using SOM advection with ptracers requires also defining GAD_ALLOW_TS_SOM_ADV. A check stops the model, if runtime parameters and cpp-flags are inconsistent.
Other information:
This is a suggestion. Some stores can be debated and I would like to hear other opinions.
Suggested addition to tag-index

pkg/mom_fluxflux/vecinv: rearrange and add storing of variables to reduce number of (unwarned) recomputations.
model/src/solve_tri/pentadiagonal.F: store directives to avoid recomputation warnings with SOLVE_DIAGONAL_KINNER defined
compile routine bodies gad_som*.F only if GAD_ALLOW_TS_SOM_ADV is defined, also for ptracers.
remove and refine many unnecessary store directives to reduce the number of TAF warnings
remove unnecessary checkpointing code from pkg/smooth_diff2/3d.F

@owang01 I am still not quite done with my cleanup of store directives, but the most important changes have been made. What's left ist some stuff in the bio-packages, where I have a hard time deciding what's important and shouldn't be touched (maybe @jahn, @seamanticscience, @mmazloff have an idea).
In the smooth package, which is only tested in verification_other/global_oce_cs32/llc90, there is some TAMC_CHECKPOINTING code in smooth_diff2/3.F. I think that this code can be removed entirely and there is no need to store anything in those routines (TAF ignores all store directives and only complains about some of them not being necessary), but I am a little reluctant to push this code, because I don't know what the implications will be for other ECCO setups (@owang01 , @antnguyen13). If you want to try this, I can push one commit, which we could revert if it doesn't work for ECCO (as any of the others, as they are all independent).

@owang01 thanks!

I tested this branch on ECCO V4r5 for 3-month runs and the differences of adjoint gradients are very small (<1e-6) between this branch and the master.

As the storing strategy is now a little different, we can expect small differences (especially since you define SOLVE_DIAGONAL_KINNER, which used to do recomputations, with warnings, which should now be gone, right?).

In terms of code performance, the run using this branch took similar wall time as that using the master. This probably does not mean much as Pleiades uses Lustre file system that makes code performance fluctuate a lot.

The changes (for SOLVE_DIAGONAL_KINNER) may make things a slightlye faster, because some recomputations are avoided, but not very much, so that's also consistent with your test.

As you removed many unnecessary store directives, it is reasonably to believe that this branch will run faster.

I don't think (I hope!!!) that my cleanup of removing many unnecessary store directives changes anything in the AD code, just cleans up the taf_ad.log file a lot.

@antnguyen13
about the EXCLUDE_PCELL_MIX_CODE: as far as I remember this flag was put there explicitly to not show the corresponding code to TAF. Not sure if we want to make it work with TAF because no-one has ever tested if the corresponding code produces stable AD-runs. Unless you set some of the runtime parameters explicitly the code is not used anyway (and I don't see these parameters https://github.com/MITgcm-contrib/llc_hires/tree/master/llc_90/ecco_v4r4/input/data).
I think I already fixed it for calc_3d_diffusivities.F (for some reason), so I am surprised that it still produces these warnings. How do I reproduce the problem?
I think we should just not use CHECK_SALINITY_FOR_NEGATIVE_VALUES in AD runs. For the nonlinear free surface with real freshwater flux it does not make too much sense anyway.

@antnguyen13 please try the latest commits with your code to see if it helps (with the EXCLUDE_PCELL_MIX_CODE). Quite some additional stores are required, so I would only use this if really necessary

@mjlosch there was 2 conflicting files when I merged master in: for packages_init_variables.F it was easy to fix but for load_fields_driver.F I ended up adding back all the included header files you removed earlier since many more have been added for Tapenade. Doing the other way (removing them) would have revert some of the changes from PR #685, and this is not what a merge commit is supposed to do. Anyway, this will need to be sorted out (and making sure all the Tapenade tests are OK).

Only did a quick look at these changes:

why adding a local version of GAD_OPTIONS.h in tutorial_advection_in_gyre/code ? SOM advection is not used there but it's already compiled (and run) in other exp. (e.g., all 3 advect_[cs/xy/xz] + in AD exp. tutorial_tracer_adjsens ).
I run testreport, no changes to FWD test but little changes to obcs_ctrl and AD cs32 test from verification_other. Will run the llc90 AD test later (it takes time) but would be nice to know where these changes come from.

Thanks for looking at this (again)!
@jm-c

with commit 1ee65c6, using SOM advection with ptracers requires defining GAD_ALLOW_TS_SOM_ADV (see "Other information" in PR description). I implemented a check that stops the model if this is not the case. That's something we can discuss and maybe we find a better solution.
the differences in obcs_ctrl (I only found reduction of 16 to 14 in mean of (ADJ) U) come up in
d1a0161, where I store cDrag in 2 places (+2 if shelfice is used).  This avoids recomputing cDrag, which can explain the small difference. For verification_other/global_oce_cs32 (and probably in global_oce_llc), I need more time to figure out the differences.

@owang01 I added a comment about removing the checkpointing code in the PR description (and tag-index suggestion)

@mjlosch I reverted the last commit to avoid conflicts when merging master in (since PR #760 has now been merged in).

@mjlosch Regarding the changes related to GAD_ALLOW_TS_SOM_ADV which now needs to be defined to use SOM advection for ptracers:
I looked to the archive, and it seems that this PR changes is reverting the modifications from May 09, 2008 (was under CVS, so likely not a single Git commit):
Before May 09, 2008, a single CPP option "GAD_ALLOW_SOM_ADVECT" was used a) to include the som_T & som_S common block /GAD_SOM_VARS_R/ ; and b) to compile the SOM advection S/R.
After May 09, 2008, the CPP option was renamed "GAD_ALLOW_TS_SOM_ADV" and only applies to the T & S SOM common block.
We could revisit this 2008 decision, but first I would like to know if/how the changes here are needed for the adjoint. Currently it's not obvious to me.

@jm-c the changes of 1ee65c6 are not strictly needed for the AD code, but they suppress many "not necessary" warning for cases when SOM is not complied. I can replace all
#ifdef ALLOW_AUTODIFF_TAMC
by
#if ( defined ALLOW_AUTODIFF_TAMC && defined GAD_ALLOW_TS_SOM_ADV )
in the three routines. Then forward code will not be affected but we would still need this flag defined for ptracers+AD. I guess that makes more sense. And I'll try it out.

@jm-c I agree, that's probably nicer, because the current solution again implies a restriction (GAD_ALLOW_TS_SOM_ADV needs to be defined if you want to use AD som-code with passive tracers).
What do we do about the check in ptracers_check.F? It can probably be simplified/reduced to
#ifndef PTRACERS_ALLOW_DYN_STATE
       IF ( PTRACERS_SOM_Advection(iTracer) ) THEN
        WRITE(msgBuf,'(2A,I4,A)') 'PTRACERS_CHECK:',
     &    ' PTRACERS_SOM_Advection(', iTracer, ') = T, but'
        CALL PRINT_ERROR( msgBuf, myThid )
        WRITE(msgBuf,'(3A)') 'PTRACERS_CHECK:',
     &    ' PTRACERS_ALLOW_DYN_STATE is not defined',
     &    ' in PTRACERS_OPTIONS.h.'
        CALL PRINT_ERROR( msgBuf, myThid )
        errCount = errCount + 1
       ENDIF
#endif

Do you agree?

@mjlosch

Do you agree?

Yes

@mjlosch Are done with changes in this PR ? Once you are, will run full set of Adjoint tests to just double check.

@jm-c I played a little bit with the DISABLE_SIGMA_CODE flag for which I have a solution now (although it is not clear to me, if this will ever be needed, just to avoid the recomputations if the flag is accidentally not defined), but I don't think that this belongs here, so I'll stop. I am done, please do your AD tests.

@mjlosch yes, no need to spend time with DISABLE_SIGMA_CODE now (I don't think this has eever been tested anyway).
All changes look good to me. I am just waiting for the verification_other AD tests to finish, both with new "cDrag" store and without, just to double check.

Got all the AD tests back, all good, minor differences in AD monitor only in obcs_ctrl and from verification_other in cs32 and llc90, and can confirm that these are caused by cDrag storage and storage in calc_phi_hyd.F.
Will merge this PR soon (later today or tomorrow).


Way to validate if input is actually a YAML

CHECK_YAML only return the error message, if the input contains some YAML, but it's malformed. However, it silently fails, if we just pass a single string, without any newlines, or tabulation.
Current behavior
SELECT CHECK_YAML('"not a valid YAML"'); -> null
SELECT YAML_TO_JSON('not a valid YAML'); -> "not a valid YAML".
Expected behavior
SELECT CHECK_YAML('"not a valid YAML"'); -> "ERROR: invalid YAML"
SELECT YAML_TO_JSON('not a valid YAML'); -> null (maybe "ERROR: Invalid YAML" would be better)

I am not sure I understand. A single quoted string is a valid YAML document. By definition, CHECK_YAML should return NULL only if the input is well-formed, in alignment with Snowflake's own CHECK_JSON.


updated pnpx command for installation

pnpx command have been deprecated check here
They recomened using pnpm dlx [tsc] for equivalence with npx

Thanks, it's even better than that actually - they support yarn-style bin commands now 👍🏻


Inbox sort and order 101

As a user, I don´t find a way to order my inbox, by latest, name, sender or subject. The program needs a small heading over the inbox that allows you to order by those subjects if you click on them. It could even dissapear on scroll down like a website...and appear on scroll up.
Said headings are very important.

Which specific headings?
We've found that all users actually just use search when looking for mail, with the exception of sorting by time.

On a second look, this seems probably not needed. Thanks.
(deleting this issue).

I'm surprised this was closed so quickly.  Do other users not see this as a useful feature?  Sorting by sender name, date, read status, tagged.... all seem like basic necessity.
For example I haven't checked my email in a few days so I'm using the unread filter on the left-hand side.  Obviously certain unread emails are more important than others.... one way to tell might be who sent it.  Additionally, what if I want to see the oldest ones first so I can see which important messages were sent first?


Problem using Webpack and au-table

Greetings,
I recently integrated this project into an application I am working on. Unfortunately, I haven't found a way to get it to work without a workaround. I am using Webpack 2.7 and what I believe are all fairly standard parts of Aurelia including aurelia-validation. All components are Typescript.
When I added au-table to the project it would just hang on the initial screen with no errors in the console or backend. I backed out the changes and put them back one at a time and found that if I added the au-plugin to my startup it failed. I read where someone mentioned adding a  to their page it would work. I tried that and it stopped hanging while loading. However, if I opened the page with the require tag the app would hang up until I did a full refresh. However, pages that referenced your table code now work. I am not sure what is going on but here is my boot.ts:
`import 'whatwg-fetch'; // Add fetch polyfill so that IE11 works
import { Aurelia } from 'aurelia-framework';
import 'bootstrap/dist/css/bootstrap.css';
import 'bootstrap';
declare const IS_DEV_BUILD: boolean; // The value is supplied by Webpack during the build
export function configure(aurelia: Aurelia) {
aurelia.use
.standardConfiguration()
.plugin('aurelia-validation')
.plugin('au-table');
if (IS_DEV_BUILD) {
    aurelia.use
        .plugin('aurelia-validation')
        .plugin('au-table')
        .developmentLogging();
}

aurelia.start().then(() => aurelia.setRoot('app/components/app/app'));

}`
There are several features that you have implemented that I would really like to use. I appreciate any help you can offer and can supply further information if needed.
Thank you!

As a work around, I have a dummy.html file with the following:
<template>
    <require from="au-table"></require>
</template>

From what i can tell, that triggers WebPack to bring in everything needed into the project. If I include the <require> tag in a page that is actually used, it seems to cause the page and application to hang up until a refresh is performed.

That is pretty weird, a couple of days ago I switched to use PLATFORM.moduleName to improve the webpack support. Are you using a specific template project?

I started with the typescript/webpack skeleton that was available in April or so and merged that into an Asp.net core Web API project. This is my first project that uses WebPack so it seems likely that I broke something, but the other packages that I added seem to be working OK.

Can you try to include the plugin using: aurelia.use.plugin(PLATFORM.moduleName('au-table'));?

Thank you for the suggestion. Unfortunately, changing the load script so that it imports PLATFORM and changing the aurelia.use.plugin statement to pass PLATFORM.moduleName('au-table') gives the same result. Unless I specifically add the require tag it will not load. Without the require tag, I do not see the au-table/dist/commonjs folder in the package that WebPack builds.


Plausible login event does not work

Probably because the window is closed immediately after it is triggered

Can probably be removed as pageviews of /login suffice


Revert "Refactor fulcio signer to take in KeyOpts. (#1788)"

Summary

This reverts commit 8368baddf688c6eac4a47adee1ed42a4fcd0f83d which started causing e2e failures in https://github.com/sigstore/cosign/runs/6142999072?check_suite_focus=true.
Will look fixing this in the next few days, but rolling back for now to get the tests green again.
Ticket Link

part of #1788
Release Note

None

Missing DCO.

Missing DCO.

🤦
Fixed!

thanks!


Colors lost when piping

Theres a possibility I'm doing something wrong, but a little bit of insight could go a long way.
When building a custom reporter, ANSI character codes are stripped when spawning mocha and piping the child process stdout using Base.color. This is the undesired behavior.
Some assertions I can make to help narrow the issue:

I am passing the --color option to mocha. I can clearly see the --color option working, because base reporters (tested dot & spec) correctly output color, only when this switch is set.
I am using Base.color "correctly," because the reporter outputs colors just fine when not spawning a child process.
I notice internally, Base.color uses chalk, which in-turn uses supports-color. I tried enforcing the FORCE_COLOR environment variable (used by supports-color), with no luck. I also validated that FORCE_COLOR works as expected with other (non-mocha) modules I have written.
I have validated that exports.useColors is correctly set to true in the conditions under test.

When using chalk directly, there are no issues; the color outputs correctly in the spawned child process. However, to take advantage of self.epilogue() and mocha's built-in color map, it would be ideal if we could get this resolved.

@justinhelmer if you can track down where exactly this is happening, please let me know

@justinhelmer @boneskull The issue seems to be that we're currently using<EMAIL_ADDRESS>for some reason (I wonder why. Do you know, @boneskull?).
This version does not have FORCE_COLLOR support yet. I'll whip up a PR updating asap
See https://github.com/mochajs/mocha/issues/1844 for reference.

@jbnicolai we can't upgrade chalk past 0.4.0 because it uses tildes in package.json

that still doesn't explain why we're not getting colors w/o FORCE_COLOR

@boneskull do you mean carets (^<EMAIL_ADDRESS>does not use any tildes, see: https://github.com/chalk/chalk/blob/v1.1.1/package.json

Just to be sure, I've also recursively checked al subdebs of<EMAIL_ADDRESS>but there's definitely no tilde-notation anywhere.
find node_modules/chalk/ -name package.json -exec grep '~' {} \;

Nevermind. Doing some Googling, it seams you indeed meant carets. I'll leave the above for context.

sorry, yes, carets.

Thanks for digging into this guys.
Let me know if there's anything I can do to help.

@boneskull -
Sorry for taking more of your time, but I couldn't locate the context relating to why upgrading the the versions of npm (> 1.3.7) or node (> 0.8.x) is considered a breaking change to the 2.x branch of mocha.
I looked through #1969 and #1844 and the rest of the (open) issue queue but couldn't find it.
Is it something I might be able to fix in order to get mocha onto npm 3.x? If so, can you point me in the right direction?
FYI the box I'm working on right now has node 0.12.x and npm 3.5.x.

I'll also dig a bit more into your comment:

that still doesn't explain why we're not getting colors w/o FORCE_COLOR

when I have some time.

@justinhelmer I think you misunderstand.  We want to retain compatibility with a vanilla install of Node.js 0.8x.  This installs an npm version which has no support for carets.  This means we cannot upgrade chalk any further than v0.4.0, because it uses carets in its package.json.
Mocha works fine with npm 3.x, to my knowledge.

@boneskull makes perfect sense. Thank you for clarifying.

@boneskull
Had a chance to actually dig in; I was able to identify the "issue" and can articulate it accurately.
Our confusion comes from the fact that I originally misidentified the issue. The first and fourth assertions from the original post are inaccurate. They would be correctly updated as follows:

I am NOT passing the --color option to mocha. For that reason, the child process identifies stdout as non-TTY and strips ANSI character sequences.
I have validated that exports.useColors is NOT correctly set to true in the conditions under test.

I was getting tripped up on the version mismatches. As I'm sure you know, npm 3.x changed to a flat structure, and tossed mocha somewhere different than I was expecting (old dog, new tricks). The parent process was running the latest version, but the child process was accessing the Base reporters from the older version of mocha. The two versions of mocha being used in a single run threw me off.
On top of that, the third party reporter I was using had an old (1.x branch) version of mocha, that didn't correctly implement color support (supports-color wasn't yet a part of the Base reporter). Passing the --color switch was working but FORCE_COLOR was not, which further led to my misidentification of the problem.
However, the observation still exists in the context you have defined it. You have correctly identified the issue as it relates to FORCE_COLOR; a newer version of supports-color would "fix" that. Arguably mocha has no interest in supporting this flag; perhaps documenting this limitation would be sufficient.
So the more interesting point of why FORCE_COLOR is needed in the first place is: IT'S NOT.
If there is a place where you document these subtleties, I would be happy to submit a pull request to bring these somewhat complicated, subtle road bumps to light. Unless you are not interested in categorizing these discoveries as such.
I apologize for taking your valuable time.

Closing as no longer relevant to current versions of Mocha...