WSL2 - VSCODE - napi issue/question

Issue Summary
I ran into an issue that might be a knowledge gap on my end but wanted to provide some notes in case it helps someone else.
I'm on Windows 10 machine, running WSL2 with Ubuntu 20.04.
I installed sqlite3 via:
npm install sqlite3
I could execute scripts in the WSL2 terminal but kept receiving an error when attempting to "Run and Debug" in VSCode.
I would receive the following error - included in relevant logs/output section, bold emphasis is mine.
Solution:
I found that by installing sqlite3 on the windows host machine I could move the directory node_modules/sqlite3/binding/napi-v6-win32-unknown-x64 into the WSL2 project's node_modules/sqlite3/lib/binding directory I was able to "Run and Debug" in VSCode.
Request:
Is there a cli command to force the installation of this binding for windows?
Relevant logs or output
(node:1576) UnhandledPromiseRejectionWarning: Error: Cannot find module 'c:\...\node_modules\sqlite3\lib\binding\**napi-v6-win32-unknown-x64**\node_sqlite3.node'
Require stack:
- c:\...\node_modules\sqlite3\lib\sqlite3-binding.js
- c:\...\node_modules\sqlite3\lib\sqlite3.js
- c:\...\index.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
    at Function.Module._load (internal/modules/cjs/loader.js:841:27)
    at Module.require (internal/modules/cjs/loader.js:1025:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (c:\...\node_modules\sqlite3\lib\sqlite3-binding.js:4:17)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Module.require (internal/modules/cjs/loader.js:1025:19)
<node_internals>/internal/process/warning.js:32
(node:1576) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
<node_internals>/internal/process/warning.js:32
(node:1576) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code

Version
5.0.8
Node.js Version
16.15.0
How did you install the library?
npm install sqlite3

It sounds like you're running the project with a Windows-installed Node binary, or at least your Vscode determined that it should do so
If the project is indeed properly supposed to run on a Linux/WSL environment, your Vscode should be using the Linux-installed Node binary, and thus cause sqlite3 to properly use Linux binding

By having "console": "integratedTerminal" in launch.json, I can see the full command Vscode runs when doing Run & Debug action

The only sqlite3 binding installed in my project

I have same / similar issue when I tried to import package on code sandbox's environment (iOS) ( which having weird arch info )
node-pre-gypError: Cannot find module '/private/var/mobile/Containers/Data/Application/.../node_modules/sqlite3/lib/binding/napi-v3-ios-unknown-arm64/node_sqlite3.node'
Require stack:
- /private/var/mobile/Containers/Data/Application/.../node_modules/sqlite3/lib/sqlite3-binding.js
- /private/var/mobile/Containers/Data/Application/.../node_modules/sqlite3/lib/sqlite3.js
- /private/var/mobile/Containers/Data/Application/.../server/index.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:984:15)
    at Function.Module._load (internal/modules/cjs/loader.js:866:27)
    at Module.require (internal/modules/cjs/loader.js:1051:19)
    at require (internal/modules/cjs/helpers.js:86:18)
    at Object.<anonymous> (/private/var/mobile/Containers/Data/Application/.../node_modules/sqlite3/lib/sqlite3-binding.js:4:17)
    at Module._compile (internal/modules/cjs/loader.js:1176:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10)
    at Module.load (internal/modules/cjs/loader.js:1009:32)
    at Function.Module._load (internal/modules/cjs/loader.js:903:14)
    at Module.require (internal/modules/cjs/loader.js:1051:19)

version: "sqlite3": "^5.0.8"
Isn't v5+ already supported Node-API ?

This appears to be a configuration issue with VSCode - please ensure the environment you're running sqlite3 under is the one you expect 🙂


Import all 3313 IR commands; test a mute toggle.

It is speculation, but so far we know that these commands work for AVR X4400H (2017), AVR X1500H (2018), and the source document is for AVR 3313 (2012), so they may be the most compatible set of codes that we have.
It would not be my intention to write many methods such as the mute_toggle in this PR, but rather to make available the general purpose method send_post_ir that allows the user to send generic IR commands.  This allows the implementer of the library, including Home Assistant, to add specific IR commands to suit their needs without bogging down this library with more API variations than it already has.  To this end, import denonavr.ir_code as ir gives the user or developer access to a library that may allow them to achieve their specific goals.
Eventually these codes may become outdated and we can continue with the XML command API or some other variation.
Thank you to @bendavid for taking the time to verify that these codes work via the iPhoneAppDirect.xml endpoint and providing a link to the exhaustive list!
Cheers,
J.P.

Thanks for implementing this @JPHutchins .
I'm not able to test it, because apparently my Denon does not support those commands.
Could you please remove the PDF File from docs folder, because it looks like a part of a Denon manual and should not been published here


 I didn't realize it has been on 1.3-experimental1

From: Bob Pulliam @.>
Sent: Wednesday, March 8, 2023 5:02 PM
To: microsoft/WindowsAppSDK @.>
Cc: Will Thant @.>; State change @.>
Subject: Re: [microsoft/WindowsAppSDK] Update Minor Version to 4 (PR #3491)
also reset type eng\common\AzurePipelinesTemplates\WindowsAppSDK-BuildSetup-Steps.yml to checkout main instead of 1.3-experimental1
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FWindowsAppSDK%2Fpull%2F3491%23issuecomment-1461104962&data=05|01|Kyaw.Thant%40microsoft.com|5cc08702665744deaef708db2039e8f3|72f988bf86f141af91ab2d7cd011db47|1|0|638139205329849220|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=y1%2BRammq7SX5qI4EK%2BEREdouRDhWMjwJCLSI52PfgVU%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALQ7TUCVJPXF7TRBI3LKZ2DW3ETZDANCNFSM6AAAAAAVULZDIE&data=05|01|Kyaw.Thant%40microsoft.com|5cc08702665744deaef708db2039e8f3|72f988bf86f141af91ab2d7cd011db47|1|0|638139205329849220|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=5ra%2BRzxGolXjzJ%2FWrstEqhrZoVJ0oTsZBQyY68cS23I%3D&reserved=0.
You are receiving this because you modified the open/close state.Message ID: @.***>

/azp run


Option for manually binding custom variables

I'd like to able to bind presenter or other non-static handlers for views inside items:

  <variable
      name="presenter"
      type="com.example.module.somemodule.SomePresenter"/>

  <variable
      name="item"
      type="com.example.viewmodels.SomeViewModel"/>
</data>
...
<TextView
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    onClick="@{presenter.doSmth(item)}"/>

Getting hold of a view holder would allow such thing. But I can only access it in Type<ItemBinding>.onClick():
Type<SomeBinding> someType = new Type<>(R.layout.some_item);
someType.onClick(new Function1<ViewHolder<SomeBinding>, Unit>() {
  @Override
  public Unit invoke(ViewHolder<SomeItemBinding> viewHolder) {
    viewHolder.getBinding().setVariable(BR.presenter, presenter); // I need this somewhere outside
    return Unit.INSTANCE;
  }
});

Hi @jamolkhon
I tried to add a better support for this but it is not very clear to me where to get the new items from (the presenter in this case)... use always the same item? provide an additional collection? None of them seems to be really useful. I think there will always be only one item that really represents that element in the list, so I'm not sure if I should change that.
Anyway, you should be able to do what you want in the current version of the library in the onBind method. The viewholder is now provided to every callback: onBind/onRecycle/onClick/onLongClick so I recommend you doing so in onBind and to use the proper method in binding for that (instead of the generic setVariable). When you declare one variable in the layout (presenter, for example), then you have a set method in the binding to set this variable (setPresenter, in this case. After rebuilding the project):
@Override
public void onBind(@NotNull ViewHolder<SomeBinding> holder) {
    holder.getBinding().setPresenter(presenter)
}

Right now I'm working on adding a new callback for onCreate that will be much more appropriate to do so if you are using the same presenter for all the items, as well as for setting click listeners. This feature should be published in a new version somewhen soon.

Added onCreate callback in version 2.2.0. Please, check also (changelog)[https://github.com/nitrico/LastAdapter/blob/master/CHANGELOG.md] as there are some other breaking changes.

Great job! Thank you!


$remove command

Remove enrolled student, assignment, class or submission.

$destroy is implemented for class deletion


Patient enrollment shortcut

This creates a clinical trial enrollment shortcut so users can now add a study enrollment to the patient's record. The clinical trial shortcut allows users to specify the title of the clinical trial, the enrollment date, and an end date of the trial.
Shortcut:

Slim mode: Clinical trial is now an option in the list on the left. Users can select the title of a clinical trial and optionally select an enrollment date and end date using the date picker. The copy button updates, only adding dates once a trial title is selected.

Full mode: a #clinical trial button is available at the patient level in the context panel. This is because the clinical trial is on a patient, not a specific condition like our other shortcuts. The button does not disappear after added to a note since a patient can be in multiple clinical trials. Once #clinical trial is inserted, it has child structured phrases for title, enrollment date, and end date. The title structured phrase allows a user to type or click on a specific clinical trial title (ex. #PATINA) or type or click the general #title shortcut, which opens a portal with the list of possible trials. Enrollment date and end date work the same as the dates in disease status. You must first specify #enrolled on or #ended on and then choose the date using #date.

Cheat Sheet:

The powerpoint file in /docs was updated to include a slide for clinical trial.
A pdf version of the new slide was included in /public and is linked to in the clinical trial form in slim mode.

Tests:

Existing tests all pass.
Added UI tests for slim mode and full mode.
Added backend tests for Patient.jsx to ensure clinical trial enrollment is correctly added to the patient record and updated.
Added a note parser test to test parsing a note with #clinical trial.

Note parser:

Added a sample note that includes #clinical trial structured phrase. The parser correctly parses this note.

All feedback on this is greatly appreciated!

[GQ1] ClinicalTrialsList.jsx doesn't use the class format like our other data. Is there a compelling benefit to using the format used? Should we switch our other data classes? We should be consistent so either we need a JIRA to switch Patient to the non-class format or we should make ClinicalTrialsList a class.

Should we create a JIRA to create a common date picker component to use on our forms? I see the format appearing in a lot of places in our code for example, so it would be nice to control that in 1 place.

[GQ2] This is my fault I think, but StudyEnrollment should be added to the patient SHR using addEntryToPatientWithPatientFocalSubject. Keep the addEntryToPatient method in Patient though.

[GQ3] We should have a sample note with the minimum required subtags for the clinical trial so we can make sure the default values look right.

[GQ4] The description for #title should not be so generic since the tag is specific to the title of a clinical trial. Also, should it be #title or #name? I think they typically refer to the name of a clinical trial?

Should the end date on the form have a clear way of specifying "no end date" because the patient is still enrolled? Maybe a checkbox labelled "Clinical Trial involvement has ended" before the end date that defaults to off and disables the date picker until it is checked? Thoughts?

I think a common date picker would make sense rather than duplicating things, I vote to create a JIRA issue for that.

Thanks @mtorchio. I'll wait to see if there's any other thoughts on it and if there is consensus I'll create the JIRA.

I agree that a separate component for the date picker would make sense, so I would vote for a separate JIRA issue for that. I will make changes to address GQ1, GQ2, and GQ3. I will also add some helper text to indicate that the end date is optional, and we can evaluate the design of the form with the design team. For GQ4, I named it #title based on the SHR Study data element, which has a title and an identifier attribute. If we decide that the shortcut should use #name instead, I think we can adjust that fairly easily. I can update the description for #title to be less generic though.

I agree that we should have a separate JIRA issue to make a separate component for the date picker since it gets used a lot in our code

added JIRA ASCODCP-602

I just updated the pull request to fix GQ1, GQ2, and GQ3. For GQ4, I changed the description of #title, but kept it as title instead of name to stay consistent with the SHR element. I also added helper text to the End Date on the Clinical Trial Form to indicate that it is optional.

noticed one test (update methods for study enrollment) still uses addEntryToPatient instead of one with focal subject

For GQ3, I meant to add another sample note with minimum elements for clinical trial tag to the note parser test. I wasn't clear. Did you interpret this differently?

Oh. Yes I did. That was my fault. I added another sample note with just #clinical trial. I can do the same in the noteparser.test file.

Whoops. Good catch on the addEntryToPatient. I missed that one. I'll fix that now with the notepareser test.

Looks great just make sure you rebase before anyone merges this

Thanks for the approvals! I'm going to work on rebasing this now. I can merge once it is set.

I just rebased and all tests are passing. I'm going to merge this now.


Add value method.

OK, I should have seen that coming.

oohh, thank you!

this was red for a couple of days now, so I just just pulled in the changes myself.
Thanks for the contribution!

You're welcome. Thanks!


Cannot add an app with a New-IntuneWin32AppRequirementRuleRegistry. error

I'm trying to add an win32app with a requirement for a registry string comparison, but no matter what I try it always gives me the below error
WARNING: Request to https://graph.microsoft.com/Beta/deviceAppManagement/mobileApps failed with HTTP Status BadRequest and description: Bad Request
WARNING: Failed to create Win32 app using constructed body. Passing converted body as JSON to output.
When I use another detection method, like a Powershell script it works. The error is somewhere in my $detectionrule. I've checked the module New-IntuneWin32AppDetectionRuleRegistry to see what the command should look like, but if always fails, even when I use another type like Existence
My detectionrule is
$DetectionRule = New-IntuneWin32AppRequirementRuleRegistry -StringComparison -StringComparisonOperator equal -KeyPath $RegKeypath -ValueName $RegKeyValue -StringComparisonValue $Version
This transalates to

My code to add the win32app
Add-IntuneWin32App -FilePath $IntuneWinFile -DisplayName $DisplayName -Description $Description -Publisher $Publisher -InstallExperience $InstallExperience -RestartBehavior $RestartBehavior -DetectionRule $DetectionRule -InstallCommandLine $InstallCommandLine -UninstallCommandLine $UninstallCommandLine -Icon $Icon -Verbose
With the below detectionrule it works, so all the other parameters in the command are fine.

It just bombs out whenever I switch to a New-IntuneWin32AppRequirementRuleRegistry.

Tried almost everything, so no idea what I am doing wrong here

You should use the following function for detection rules:
New-IntuneWin32AppDetectionRuleRegistry
Since it will create the required odata.type object: #microsoft.graph.win32LobAppRegistryDetection
Requirement rules are different, and the function you're using created a '#microsoft.graph.win32LobAppRegistryRequirement' odata.type object.


IAPP report list

[ ] Might just have been user cache, but user saw wrong list of reports in IAPP

It's just the users cache no one can repro.


How does generate work?

In the generate method of the model, I notice that you remove some tokens, according to the top_p value. I don't understand why you remove the tokens with high logits, could you give me some material about this? Appreciate it so much!

Hi, we are actually removing the tokens with cumulative probability > top_p. This means that we only keep the top tokens such that their sum is equal to top_p (for example, if we set top_p = 0.9 and the first 10 tokens sum to 0.9, we will discard every token after 10 and sample only from the first 10.
This is standard nucleus sampling. Hope that makes sense!

I understand! Thank you so much!!


Missing AWS AMIs for nixos 23.11

Describe the bug
There are no AWS AMIs for nixos 23.11.
Given that nixos 23.04 is deprecated, the only ways to deploy a nixos 23.11 machine in AWS now is to either create your own AMI, or to deploy a nixos 23.04 AMI and to upgrade it, incurring both high CPU usage and large amounts of network traffic from the machine.
Expected behavior
That AMIs exist, as alluded to in the documentation (and the official download site).
Notify maintainers
@RaitoBezarius @AmineChikhaoui @arianvp

related: https://discourse.nixos.org/t/ami-for-nixos-23-11/36860

Dupe of: #285881
Fixed by: https://github.com/NixOS/nixpkgs/pull/292886 , which is a stop-gap to add the images to amazon-ec2-amis.nix. But in this comment @arianvp points people to https://nixos.github.io/amis/ , which does have 23.11 AMIs.
We can probably close this issue.

This was now fixed by @arianvp


Fix up appveyor ci script

There was a build error in #44 due to CI setup
This fixes it, so the CI gives proper results again.

This should be better now


Mobile Uploads

Hi @evanchiu !
Any chance of adding a way to do uploads from a mobile? All I really need is a button to browse and then a button to submit the file to upload. Thoughts?

Hello @ATCcodex!
That's a great idea.  As noted in uploader's index.html, I followed a Netlify example for the client side JavaScript.  I haven't looked into what that would require, but I don't expect that I'll be able to prioritize this soon.

@evanchiu Ok cool! Thanks! I'll look into it and see if I can figure it out! Thanks!


FiNER Wallet support

Description
Add support of FiNER Wallet which can be installed from App Store and Chrome Store
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

@AmmarHumackicSQA @amirsaran3 We reviewed all the nuances of interaction with the wallet on the mobile device, also added integration with the browser expansion

@AmmarHumackicSQA @amirsaran3 We reviewed all the nuances of interaction with the wallet on the mobile device, also added integration with the browser expansion

Thanks @prih, we will be checking it today.

Hi @prih , thanks for submitting this PR.
I've noticed some issues that you might want to check out.
On desktop view, the Finer wallet isn't visible in the list in case it's not installed. It should be present with the install page when selected. You can have a look at the example below.

In mobile view it is visible, but it throws this error when clicked.

After installing extension, when I'm trying to use wallet I'm getting "user reject" error when clicked on next.
You can check out video example

On desktop view, the Finer wallet isn't visible in the list in case it's not installed. It should be present with the install page when selected. You can have a look at the example below.

fixed

After installing extension, when I'm trying to use wallet I'm getting "user reject" error when clicked on next.

its in process, we are waiting for the renewal of expansion in the store... v0.1.4 - will open the extension window and inform the user about the need to connect the expansion with the mobile application.

In mobile view it is visible, but it throws this error when clicked.

this message is not at the JS code level, when trying to open a mobile application using the URL scheme finer://
simulation on the desktop browser (devtools) does not make it a real mobile browser)

In mobile view it is visible, but it throws this error when clicked.

this message is not at the JS code level, when trying to open a mobile application using the URL scheme finer:// simulation on the desktop browser (devtools) does not make it a real mobile browser)

@prih this is my initial review. these are some of the issues:

Your wallet (FiNER extension) is creating or overriding the existing window.near object which is conflicting with the Sender wallet.
The code about communicating with the extension is confusing and Sender is mentioned in a  lot of places it's a bit misleading.
signAndSendTransaction with a deposit is not working on the mobile wallet.

This PR is trying to combine 2 different wallet implementations for this reason we will need to decide if there is a need to split these into 2 different packages (wallets) like FiNER Wallet (mobile), FiNER Wallet(extension).
Could you have a look at the contributing docs too and make sure the FiNER wallet aligns with the criteria?
https://github.com/near/wallet-selector/blob/main/CONTRIBUTING.md#listing-criteria-for-third-party-wallet-on-wallet-selector
For the Extension can you see if it aligns with the NEP standard: https://github.com/near/NEPs/pull/408

Your wallet (FiNER extension) is creating or overriding the existing window.near object which is conflicting with the Sender wallet.

no, extension doesn't overwrite window.near only if it's undefined

packages/finer-wallet uses window.finer.near directly...

Your wallet (FiNER extension) is creating or overriding the existing window.near object which is conflicting with the Sender wallet.

no, extension doesn't overwrite window.near only if it's undefined
packages/finer-wallet uses window.finer.near directly...

no, extension doesn't overwrite window.near only if it's undefined

One way to find out this strange behaviour is if you disable Sender in the extensions of your browser and try clicking the Sender option. Sender and Finer must be 2 separate things.

signAndSendTransaction with a deposit is not working on the mobile wallet.

yes, we see the problem, it worked before)

no, extension doesn't overwrite window.near only if it's undefined

One way to find out this strange behaviour is if you disable Sender in the extensions of your browser and try clicking the Sender option. Sender and Finer must be 2 separate things.

Yes, I understand, but what's the problem? are we prohibited from using this API? if the user install Sender Wallet, then it will work without problems...
this is implemented for projects that have not integrated wallet-selector and will not do it, but already have integration with browser-wallet and Sender (since they appeared before wallet-selector became mainstream), and are de facto standards, like for example in Ethereum world (and other EVM) MetaMask plays such a role with its window.ethereum provider, and no one is surprised by this fact that the user has the wallet that suits him, and not something with which he can connect to a specific dApp.

This PR is trying to combine 2 different wallet implementations for this reason we will need to decide if there is a need to split these into 2 different packages (wallets) like FiNER Wallet (mobile), FiNER Wallet(extension).

why should we do this? our extension is not a standalone wallet, but a gateway for interacting with a mobile application, user can use the desktop experience, while his keys are safe on the mobile device

For the Extension can you see if it aligns with the NEP standard: near/NEPs#408

yes, we are following this, when we make our implementation of the injected wallet for NEAR, we will definitely pay attention to these documents with recommendations, but at the moment I think this is not relevant, because. communication takes place via the wallet-selector interface

no, extension doesn't overwrite window.near only if it's undefined

One way to find out this strange behaviour is if you disable Sender in the extensions of your browser and try clicking the Sender option. Sender and Finer must be 2 separate things.

Yes, I understand, but what's the problem? are we prohibited from using this API? if the user install Sender Wallet, then it will work without problems... this is implemented for projects that have not integrated wallet-selector and will not do it, but already have integration with browser-wallet and Sender (since they appeared before wallet-selector became mainstream), and are de facto standards, like for example in Ethereum world (and other EVM) MetaMask plays such a role with its window.ethereum provider, and no one is surprised by this fact that the user has the wallet that suits him, and not something with which he can connect to a specific dApp.

If sender is not installed and you click it in the wallet selector UI it should show the WalletNotInstalled view and not prompt the connection with FiNER.
Based on the specification here Sender will eventually have to move to window.near.sender if they want to align with the Standard: https://github.com/near/NEPs/blob/master/specs/Standards/Wallets/InjectedWallets.md#specification

This PR is trying to combine 2 different wallet implementations for this reason we will need to decide if there is a need to split these into 2 different packages (wallets) like FiNER Wallet (mobile), FiNER Wallet(extension).

why should we do this? our extension is not a standalone wallet, but a gateway for interacting with a mobile application, user can use the desktop experience, while his keys are safe on the mobile device

I see at first I thought the extension was a wallet too.

If sender is not installed and you click it in the wallet selector UI it should show the WalletNotInstalled view and not prompt the connection with FiNER.
Based on the specification here Sender will eventually have to move to window.near.sender if they want to align with the Standard: https://github.com/near/NEPs/blob/master/specs/Standards/Wallets/InjectedWallets.md#specification

If sender is not installed and you click it in the wallet selector UI it should show the WalletNotInstalled view and not prompt the connection with FiNER.

I agree, but this is done for compatibility, we can solve this by notifying the user that this is not a Sender and offering to use FiNER, if he refuses, then we will set a flag about this and will not offer FiNER, ok?

Based on the specification here Sender will eventually have to move to window.near.sender if they want to align with the Standard: https://github.com/near/NEPs/blob/master/specs/Standards/Wallets/InjectedWallets.md#specification

ok, it's up to them, we just want users to be able to replace window.near if the dApp can only do that...

signAndSendTransaction with a deposit is not working on the mobile wallet.

it is interesting that it didn’t problem with us, the wallet is waiting for the finalization of the transaction, and it doesn’t happen in any way. node loses recipes... but in fact it is in the blockchain, just rpc for some reason does not associate it with this transaction...
example:
https://explorer.testnet.near.org/transactions/2z8WphkMiSXoz3tNrw6ehhWghbdSAVWB9JRwsJNSzv4p
we have made adjustments to our finalization check mechanism, it should work with the new app update...

Hi @prih , thanks for the changes and updates. signAndSendTransaction is working now, one thing left to be addressed is the windows.near issue.

Hi @prih , thanks for the changes and updates. signAndSendTransaction is working now, one thing left to be addressed is the windows.near issue.

@DamirSQA @kujtimprenkuSQA
what is the issue?) we do not see any problems and reasons to change anything, our extension is api compatible with Sender Wallet, and this is so for compatibility, there are dApps that have directly integrated this api, and do not use wallet-selector, or early versions of it.
ok, if you are not satisfied with how our extension works, then - what rules does he break?

Is this the decentralization we deserve? why are we dictated how we should make a wallet and what api should it have? are we somehow conflicting with sender-wallet ? - no, only if it is not installed by the user, we are trying to make life easier for the user.

Hi @prih, the reason behind enforcing the standard is that we ensure everyone has the same conditions for their wallets without negative impact on each other.

what negative impact do we have? if the user has Sender installed, then our extension does not interfere with him in any way...

If sender is not installed and you click it in the wallet selector UI it should show the WalletNotInstalled view and not prompt the connection with FiNER.

I agree, but this is done for compatibility, we can solve this by notifying the user that this is not a Sender and offering to use FiNER, if he refuses, then we will set a flag about this and will not offer FiNER, ok?

Hi @prih, what if some other wallet team wants the users to be directed to their wallet in the same way?
It doesn't seem fair in this example not to show to the users when they select Sender theWalletNotInstalled view first as we have it currently, with the option for them to be redirected to the store to install it.

this is understandable and logical, but the user has already installed, for example, the Finer extension, for some reason he needed another wallet, that is, for some reason he consciously wants to use both at once? ok, only in this case it ? when our extension is not installed, we do not recommend Finer instead of Sender.

@AmmarHumackicSQA

Hi @prih, the reason behind enforcing the standard is that we ensure everyone has the same conditions for their wallets without negative impact on each other.

Please link this standard so we can find more details there.

@AmmarHumackicSQA

If sender is not installed and you click it in the wallet selector UI it should show the WalletNotInstalled view and not prompt the connection with FiNER.

I agree, but this is done for compatibility, we can solve this by notifying the user that this is not a Sender and offering to use FiNER, if he refuses, then we will set a flag about this and will not offer FiNER, ok?

Hi @prih, what if some other wallet team wants the users to be directed to their wallet in the same way?
It doesn't seem fair in this example not to show to the users when they select Sender theWalletNotInstalled view first as we have it currently, with the option for them to be redirected to the store to install it.

If the user didn't install Sender or Finer, where in the code do you find that we try to block Sender installation?

@AmmarHumackicSQA

If sender is not installed and you click it in the wallet selector UI it should show the WalletNotInstalled view and not prompt the connection with FiNER.

I agree, but this is done for compatibility, we can solve this by notifying the user that this is not a Sender and offering to use FiNER, if he refuses, then we will set a flag about this and will not offer FiNER, ok?

Hi @prih, what if some other wallet team wants the users to be directed to their wallet in the same way?
It doesn't seem fair in this example not to show to the users when they select Sender theWalletNotInstalled view first as we have it currently, with the option for them to be redirected to the store to install it.

If the user didn't install Sender or Finer, where in the code do you find that we try to block Sender installation?

Hi @Olexiy-pt it wasn't mentioned that you block it, but we are saying it should show the user how we currently have it with theWalletNotInstalled view.
To show the option first for the users to be redirected to the store to install Sender if it's not installed already. You can check out our live example: near.github.io/wallet-selector/.
If you have some examples to share of your suggestions we would appreciate it. Thanks!

@AmmarHumackicSQA

If sender is not installed and you click it in the wallet selector UI it should show the WalletNotInstalled view and not prompt the connection with FiNER.

I agree, but this is done for compatibility, we can solve this by notifying the user that this is not a Sender and offering to use FiNER, if he refuses, then we will set a flag about this and will not offer FiNER, ok?

Hi @prih, what if some other wallet team wants the users to be directed to their wallet in the same way?
It doesn't seem fair in this example not to show to the users when they select Sender theWalletNotInstalled view first as we have it currently, with the option for them to be redirected to the store to install it.

If the user didn't install Sender or Finer, where in the code do you find that we try to block Sender installation?

Hi @Olexiy-pt it wasn't mentioned that you block it, but we are saying it should show the user how we currently have it with theWalletNotInstalled view.
To show the option first for the users to be redirected to the store to install Sender if it's not installed already. You can check out our live example: near.github.io/wallet-selector/.
If you have some examples to share of your suggestions we would appreciate it. Thanks!

well, we will remove the automatic set in window.near, and the user himself can enable it in the settings. @AmmarHumackicSQA - ok?

@AmmarHumackicSQA

If sender is not installed and you click it in the wallet selector UI it should show the WalletNotInstalled view and not prompt the connection with FiNER.

I agree, but this is done for compatibility, we can solve this by notifying the user that this is not a Sender and offering to use FiNER, if he refuses, then we will set a flag about this and will not offer FiNER, ok?

Hi @prih, what if some other wallet team wants the users to be directed to their wallet in the same way?
It doesn't seem fair in this example not to show to the users when they select Sender theWalletNotInstalled view first as we have it currently, with the option for them to be redirected to the store to install it.

If the user didn't install Sender or Finer, where in the code do you find that we try to block Sender installation?

Hi @Olexiy-pt it wasn't mentioned that you block it, but we are saying it should show the user how we currently have it with theWalletNotInstalled view.
To show the option first for the users to be redirected to the store to install Sender if it's not installed already. You can check out our live example: near.github.io/wallet-selector/.
If you have some examples to share of your suggestions we would appreciate it. Thanks!

well, we will remove the automatic set in window.near, and the user himself can enable it in the settings. @AmmarHumackicSQA - ok?

Hi @prih that would be great. Thanks!

@AmmarHumackicSQA @DamirSQA we updated extension v0.1.5, it doesn't use window.near by default

Thanks @prih , I'll ask you to merge latest changes with your branch  before we proceed with merging PR.

Thanks @prih , I'll ask you to merge latest changes with your branch before we proceed with merging PR.

done

thx!

Hi @prih we tried testing the latest version (v0.4.2) of the FiNER wallet and we are getting the "Something went wrong" msg while trying to set up the wallet (tried multiple options: quick start, create a new wallet, and import wallet). Here is the ss of what we are getting:

Can you take a look at this? Thanks!


Merge branch 'master' into feature/215-save-settings-between-sessions…

…-from-settingsmenuscene

Codecov Report

Merging #216 (60d08c3) into master (25157a2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   11.89%   11.89%
=======================================
  Files         168      168
  Lines        2614     2614
  Branches      862      862
=======================================
  Hits          311      311
  Misses       2153     2153
  Partials      150      150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25157a2...60d08c3. Read the comment docs.


Fix options getter for in-viewport modifier so it returns correct object

I found the options passed to the in-viewport modifier were being ignored.
Turns out if we run
const { onEnter, onExit, ...options } = this.args.named;
return options; // it returns { options: {} }

But we need it to return the contents of the options object.
You can check this on a simple example
const {...options } = { options: {foo: '42'}};
console.log(options); // logs {options: {…}}
// instead we want it to just log {foo: 42}

Turns out this modifier never expected to get options as an argument, sorry for the confusion. I'm closing this PR


test

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate)
Types of changes

Social Handles (Optional)

ok


feature suggest, numerical label of the aromatic sites

At present, starting material and a possible product of reaction are compared with each other.  Probing each aromatic site, either

the product's energy is at least 1 kcal/mol below the one of the starting material, and then is marked by a green circle, .or.
the product's energy is at least 3 kcal/mol below the one of the starting material, and then marked by a red circle.

Using RegioSQM so far via your web site only, I would like to suggest an additional mode; namely, that the differences
are seen right next to the carbon atom in question in an accuracy of one decimal.  This could provide a more gradual ranking of the sites in terms of electrophilic substitution, than the current three level binning of «not really»  (|ΔG| < 1 kcal/mol, no mark), «so la la» (1 < |ΔG| < 3 kcal / mol, green), or «good» (|ΔG| > 3 kcal / mol, red).  It could be presented like the following illustration:

Context:
A question about electrophilic substitution on ChemistrySE was answered with emphasis on steric hinderance.  A complementary perspective is to assume the starting material as derived from two mono-substituted benzenes, and recalling how these patterns would preferentially direct the entrance of the new substitutent:

With RegioSQM, the situation may be decomposed as in the following illustration:

RegioSQM indicates the position para to the amide group as the one energetically most favourable for an electrophilic substitution; this aligns with the answer given on ChemSE.  On the other hand, the scrutiny of benzamide alone (bottom right) does not convey the preferred meta-diection by the amide group for a second substitution.
Thus, a number of monosubstituted benzenes were tested with subsitutents said to direct preferentially to either ortho/para, or to meta position.  For example, along the line of F -> Cl -> Br -> I, the preference for the former pattern becomes less visible (2020-07-21_question.pdf).  In the case of simultaneous presence of homo- and hetarenes (with_heterocylics.png), it equally could be highly instructive to have the version where atoms are joined by the note about ΔG as a numbers, too.
Thus I wish retaining the current three-level scale (none, green, red) as a scale generally applied, offering a quick survey across many possible molecules, as one option.  Depending on core structure and substitutents already present, the changes expressed by ΔG however may vary from molecule to molecule in addition to the variation probing the sites within a molecule.  Thus, accessing the ΔG as numbers intends as path complementary to the one already offered; preferentially both from the scripts deposit here, as well from the website dedicated as on-line service.
2020-07-21_question.pdf
with_heterocylics.png

At present, starting material and a possible product of reaction are compared with each other. Probing each aromatic site, either

the product's energy is at least 1 kcal/mol below the one of the starting material, and then is marked by a green circle, .or.
the product's energy is at least 3 kcal/mol below the one of the starting material, and then marked by a red circle.

This is wrong. Please read the paper carefully.


www.com中间填什么?,填空题www com好人一生平安

www.com中间填什么?,填空题www com好人一生平安
www.com中间填什么?,填空题www com好人一生平安👇观看入口👇
》》》》》点/此/进/入/观/看/《《《《

www.com中间填什么?,填空题www com好人一生平安描述
　　西川：固然，本来期间的题目和部分的题目也是精细贯串的。咱们这当代人年青时被培养要向典型进修，很多人总想变成一个典型似的人物，但题目来了，走到即日你创造本人明显不是那么的人，但你老想变成一个典型，这即是对自己看法的错位。到即日咱们面对很大的一个题目是，咱们连本人是谁都不领会，咱们本人毕竟是个怎么办的人，更加在即日的社会实际中是个怎么办的人？往日咱们被培养要做忘我贡献的典型，但即日人们都想、都想挣钱，这表示着本来人是有私念的，这很平常，但培养的要乞降你的私念之间你如何处置？当你面临本人的功夫，你创造本人没有那么高贵，没有那么像一个典型，你怎样做？这个功夫就诉求人淳厚面临本人，这即是处置一个期间中的本人。
　　冬日里，窗外的这棵枣树一改女性的温柔，铁青着脸色，虬枝交错，并伸展出尖刀般的利剑，于冰雪冷凝的世界，像一个武士巍然挺立，令人肃然生畏，其实这正是敢爱敢恨的枣树不惧生命的磨难勇敢地面对现实的真实写照，抑或坚贞如一的枣树在以烈女的气节等待心中那份放不下的思念。每逢大雪封门寒气逼人的日子，瑟缩在办公室里的我，总能从窗外雪压枝头挺不弯不惧清寒更抬头的枣树身上得到一丝丝鼓舞，心中常充满一种前所未有的温暖和力量。
Surprisingly, admittedly, original topic during emptying armpits and part of the subject is also fine.
Let's this contemporary young people train to typical education, a lot of people always want to be a typical characters, but subject to, to this day you create himself not so obviously, but you always want to be a typical, this is the dislocation of his own views.
To this day we face a big topic is, we don't even understand who I am, we after all is a man of what to do, the more in this day of social practice, is a man of what to do?
Past we were training to do typical selfless contribution, but now people want to, want to make money, this means that the people have selfish motives, originally this is normal, but the culture to beg to surrender your thoughts between what to do with you?
When you face my kung fu, you create himself not so noble, less like a typical, how do you do?
The kung fu can appeal people honest face, this is the disposal of a period of himself.
In the winter, the jujube tree outside the window change women's gentle, metal gray face, QiuZhi crisscross, and extend a sword like a sharp knife, born in the world of the condensation, so like a warrior, awe-inspiring terrible, actually it is just dare to love dare to hate Chinese jujube don't fear the hardships of life faces the reality bravely, or firmness, like a Chinese jujube in integrity integrity waiting in the heart that can not let go missing.
Every snow FengMen chill day, she in the office, I will always look out the window the snow pressure branches is not bend more unafraid to underprivileged students looked up and get a little bit of Chinese jujube, often filled with a kind of unprecedented warm heart and strength.

学习思路
回来小伙伴们总争论着各自到过的城比试比试谁父亲的城最大最美他们大谈城里的新鲜事大谈父亲携他们逛城的快乐事在孩子们幼小的心中谁父亲离家最远赚钱也最多城也最大最美无奈争来争去谁也夜Friends always argued back to their respective city away who his father's largest city is the most beautiful they talk of the town's new talk about happy things in the city of father carrying them around in the minds of young children who father as far as making money from home and most populous city and the biggest helpless to go to the most beautiful night

https://github.com/yuyete/wfcarog/issues/7
https://github.com/reetsv/inomell/issues/4
https://github.com/vcrtube/mngxg/blob/main/果冻传媒女演员舒畅
https://github.com/reetsv/wqixomh/issues/1
https://github.com/bqlene/cdsgza/blob/main/吃瓜合集の不定时更新QQ群
https://github.com/hukioip/nujcxu/issues/2
https://github.com/reetsv/tftxxho/issues/4
https://github.com/reetsv/asb-wcoks/blob/main/大菠萝app福引导前往打开
https://github.com/reetsv/rtlizuo/issues/2
https://github.com/yuyete/olzmgqd/blob/main/日本正能量不良直接进入滋水
https://github.com/reetsv/gniejg/blob/main/我的好妈妈6高清在线观看中文版
https://github.com/reetsv/ahv-ahvvs/issues/2
https://github.com/hukioip/jikssv/issues/1
https://github.com/wangyyun/ebydbct
https://github.com/Createree/dbkprdm
https://github.com/reetsv/tfmlynq/issues/3
https://github.com/hukioip/uipiimu/issues/5
https://github.com/temestas/fof-fofew/issues/6
https://github.com/huolpi/a/issues/1
https://github.com/Createree/xdl-xdloq/issues/3
https://github.com/reetsv/uqmpfcx/issues/2
https://github.com/qilixing/mopw/issues/6
https://github.com/hukioip/pvzswr/issues/2
https://github.com/hukioip/cemctpo/issues/2
https://github.com/hukioip/wzpcvm/issues/3
https://github.com/bluereds/fbybq/blob/main/README.md
https://github.com/reetsv/uqmpfcx/issues/2
https://github.com/reetsv/alq-alqvw/issues/1
https://github.com/yuyete/mfovpzo/issues/7
https://github.com/reetsv/neymarr
https://github.com/reetsv/eiw-eiwoc/blob/main/直接进入的正能量网站入口
https://github.com/reetsv/kyr-kyruy/issues/3
https://github.com/reetsv/zhdsg/issues/1
https://github.com/hukioip/qwbcsoa/issues/7
https://github.com/hukioip/jbpjspx/issues/5
https://github.com/reetsv/zyj-zyjve/issues/2
https://github.com/reetsv/gakiy/issues/5
https://github.com/reetsv/ilsbkqj
https://github.com/sohunew/xzi-xzize/blob/main/大佬们这题怎么填www
https://github.com/Createree/fgbhi/issues/6
https://github.com/Createree/pctoxds/issues/3
https://github.com/huolpi/ylfyoj
https://github.com/reetsv/krhtq/issues/2
https://github.com/Createree/vakbt/blob/main/有没有可以免费看www
https://github.com/vcrtube/xrg-xrgia/issues/1
https://github.com/hukioip/nwjsrxf/blob/main/一本二卡三卡四卡乱码仙踪林
https://github.com/bluereds/t
https://github.com/reetsv/vnvmio
https://github.com/hukioip/peljw/issues/1
https://github.com/vcrtube/eku-ekupk/issues/3

>>>>>让男人爽的视频,你懂的
>>>>>让男人爽的视频,你懂的
>>>>>让男人爽的视频,你懂的
鸭蚕妇夷愿私鹤炙阂忌照厥阎冈瓶肝茁


docs(examples): vue - new padding examples and fixes in dynamic examples

This PR:

Added new padding and scroll-padding examples for Vue
Fixed issues with the Vue dynamic examples
Updated .nvmrc to v16 so that it aligns with the GitHub actions.

@kouts Thanks

Thank you @piecyk 🙏 !


[EN DateTimeV2+Number] Inconsistency between datetime result and number result of ""=2019""

Number returns "=2019", but datetime returns "2019".

@ZijiaLin @substill What's the expected output? In my view the "=" should not be tagged in either case.


Moving files from bitbucket

license
startup script
docker-compose
readme

Thanks for taking the lead on this :) I'll modify the readme and stuff to clone everything from GitHub when I'm free


Moving code to correct location

Code now in correct location
Before issuing a pull request, please see the contributing page.

yay


rotate sms lifecell password

We need to rotate lifecell password
sending details to @lymychp

This done & deployed – https://github.com/edenlabllc/ehealth.charts/commit/ef15f0db2b86f171bcd8f77dbe6c182d828be2d2

thanks!
BR, Pavel V. Zhuk
2017-12-04 14:02 GMT+02:00 Eugene Pirogov<EMAIL_ADDRESS>
This done & deployed – edenlabllc/ehealth.charts@ef15f0d
https://github.com/edenlabllc/ehealth.charts/commit/ef15f0db2b86f171bcd8f77dbe6c182d828be2d2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/edenlabllc/ehealth.api/issues/1584#issuecomment-348942837,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ4gYBG9x83r3t7n6OP517Bx0XzqtPW-ks5s899IgaJpZM4Q0bWj
.


package not found by name

I downloaded a neuron package zip to my local repo. Afterwards, I issued neuron input add, and got the error message above.
CEU-8706:managerdb koren$ neuron repo list
Repositories:
-------------
sandbox: /Volumes/Home/xl/data/data-repo/repositories
local: /Volumes/Home/datastore/neuron-repos
CEU-8706:managerdb koren$ pwd
/Volumes/Home/datastore/managerdb
CEU-8706:managerdb koren$ neuron repo list
Repositories:
-------------
sandbox: /Volumes/Home/xl/data/data-repo/repositories
local: /Volumes/Home/datastore/neuron-repos
CEU-8706:managerdb koren$ neuron input add frame frame
ERROR: Not a known package name: frame
CEU-8706:managerdb koren$ ls /Volumes/Home/datastore/neuron-repos/
frame_20151028_152234_226060.zip	rovat_13_15_20151105_144001_928190.zip
CEU-8706:managerdb koren$

Names are not derived from file names - they are independent, you can rename the zip files to whatever you want, they will be still found or not.
In this case the name frame is not mapped to the package uuid of the concrete zip file.
Name export, import is a new command line feature, that was not implemented in the neuron binary.
Try
neuron input add frame /Volumes/Home/datastore/neuron-repos/frame_20151028_152234_226060.zip


Added apns-push-type parameter

This PR adds a parameter to specify the value of the apns-push-type  as per apple docs
  -type string
    	The value of the apns-push-type. Possible vaules are: alert background location voip complication fileprovider mdm liveactivity'.  Default is 'alert'

Fixes https://github.com/petarov/apns-push-cmd/issues/4

Thanks! I'm a little bit busy atm but will take a look ASAP.

Thanks a lot for contributing. 🍻


Business Central sandbox is not provisioning after 5 hours for version 12.0.22067.0

Moving an issue from AL GitHub:
https://github.com/Microsoft/AL/issues/2297
https://user-images.githubusercontent.com/39469150/40301810-54a75b20-5d41-11e8-9980-ad9aab072a72.png
Hi @freddydk,
This is only when I try it from the BC interface, searching for Sandbox (Container) and clicking on the In Azure button.
I realise I should have raised it in nav-docker issues, do let me know if you want me to recreate it there.
Cheers,
Robert

We had some build issues, which should be solved now.


 I have vagrant installed and virtual box. How i can run this?

free bitcoin
https://qoinpro.com/7c60c24ca7a498cb9bea167983a43216

??
Em 6 de jul de 2016 15:05, "Максим"<EMAIL_ADDRESS>escreveu:

free bitcoin
https://qoinpro.com/7c60c24ca7a498cb9bea167983a43216
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SamyPesse/How-to-Make-a-Computer-Operating-System/issues/96#issuecomment-230855586,
or mute the thread
https://github.com/notifications/unsubscribe/AJ_CurdKme2eD41AsUf-5QCvrynDA5fzks5qS-6AgaJpZM4F8W2J
.

I have no problem run this on Windows. Btw. But Windows isn't the best way to programming on C++ without IDE. Linux is the best way beside MinGW and CYGWIN.
Read this: https://samypesse.gitbooks.io/how-to-create-an-operating-system/content/Chapter-2/


⚠ Bofrost.lu has degraded performance

In b35c04c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2155 ms

Resolved: Bofrost.lu performance has improved in 3bb34e1 after 14 minutes.


Add an Alias mapping to a real class for dependency injection

Something like this in the Service Provider:
$this->app->alias('setting', 'Thetispro\Setting\Setting');

Or change the bind line
$this->app->bind(['setting' => 'Thetispro\Setting\Setting'], function($app) {

Makes it much easier to use dependency injection instead of facades to access everything.

Done.


D3 Multi-resolution time format missing

Both
  d3.time.format.multi
  d3.time.format.utc.multi

are missing in r2d3.  See :
https://github.com/mbostock/d3/wiki/Time-Formatting#format_multi

Hi there,
This project is no longer being maintained so this issue is being closed. Thank you for using r2d3 and taking the time to report this issue.


Resume training does not work for multi-gpus training

I met the problem when resuming training. A similar issues has happened in its successor repo : https://github.com/openai/guided-diffusion/issues/23.
It works well upon single gpu mode and single node-multigpus but not multinodes-multigpus.
Are there any suggestions ?

One way to tack this is to first load ckpt/opt before DDP, as suggested in https://github.com/pytorch/pytorch/issues/23138.
If there are other ways around, please leave comments here. Thanks.


Update janet and judge to latest versions

Remove walkies functions due to Janet integrating equivalent changes upstream: https://github.com/janet-lang/janet/pull/1095/files
Updates Janet to the latest commit (fc8c6a429eafacb88097aaf3ec7de17871a14013), and the Judge test to reflect the latest version's changes to the spec macros

Hey thanks! Can we make it be the stable Janet-1.28.0 release instead of the current HEAD? While I doubt there are any breaking changes there is an annoying (and undocumented) dependency where the Janet that you use to build Bauble has to be the same as the version that Bauble vendors here or crazy things could happen.
Also! The janet.c.patch thing is totally unnecessary now! The root bug was fixed in a previous release and we can just delete that now.

Hey @ianthehenry! I just updated the branch to use the stable version of Janet instead and remove the patch.
Also, given that the patch is unnecessary, does it still make sense to explicitly vendor a copy of janet rather than download it as part of a build script or keep it as a git submodule? I see upsides to either approach, just wondering what you think about this

Looks great! And yeah, I think that downloading it as a build step would make sense. The explicit vendoring was mostly just easy/lazy because Bauble didn't have any kind of build system when I started it :).
I don't think we can do it as a submodule because the amalgamated build isn't part of the janet repo? So it would require first building the amalgamted c file as a build step in here and I think that's probably harder than it's worth?

My extremely high-tech Bauble dev tools:
nix-shell ~/src/bauble ➜ sd bauble update-janet --cat
#!/usr/bin/env bash

set -euo pipefail

cd ~/src/bauble

version="v$1"

curl -L "https://github.com/janet-lang/janet/releases/download/${version}/janet.c" > janet/janet.c
curl -L "https://github.com/janet-lang/janet/releases/download/${version}/janet.h" > janet/janet.h

:p

Actually yeah I'm just gonna do this now

done in 5dae2e1460a1c4ea3bf2f58947b35d6f3ee0e852


New rule to check if the Classic Load Balancers serve HTTPS

'''
#####################################
##           Gherkin               ##
#####################################
Rule Name:
  CLASSIC_ELB_SSL_ENFORCE_CHECK

Description:
  Check whether SSL is enforced on the Amazon Classic Load Balancers either using HTTPS/SSL listeners or by redirecting HTTP traffic to HTTPS.

Trigger:
  Configuration change on AWS::ElasticLoadBalancing::LoadBalancer

Reports on:
  AWS::ElasticLoadBalancing::LoadBalancer

Rule Parameters:
  HttpsRedirectionCheck
   Optional
   A boolean parameter to check if HTTP to HTTPS traffic redirection is enabled. Default is True.

Scenarios:
  Scenario: 1
     Given: Parameter HttpsRedirectionCheck is configured
       And: It is not either True or False
      Then: Return an error
  Scenario: 2
     Given: CLB has only TCP listeners(s)
      Then: Return NON_COMPLIANT with Annotation "CLB {CLB_Name} has no HTTPS or SSL listeners configured."
  Scenario: 3
     Given: CLB has no HTTPS or SSL listeners(s)
      Then: Return NON_COMPLIANT with Annotation "CLB {CLB_Name} has no HTTPS or SSL listeners configured."
  Scenario: 4
     Given: CLB has HTTPS/SSL and HTTP listeners
       And: The parameter HttpsRedirectionCheck is False
      Then: Return NON_COMPLAINT with Annotation "CLB {CLB_Name} has HTTP listener(s) configured."
  Scenario: 5
     Given: CLB has HTTPS/SSL and HTTP listeners
       And: The parameter HttpsRedirectionCheck is True
       And: HTTP to HTTPS redirection is not enabled
      Then: Return NON_COMPLAINT with Annotation "CLB {CLB_Name} serves HTTP traffic without redirecting to HTTPS."
  Scenario: 6
     Given: CLB has HTTPS/SSL and HTTP listeners
       And: The parameter HttpsRedirectionCheck is True
       And: HTTP to HTTPS redirection is enabled
      Then: Return COMPLAINT
  Scenario: 7
     Given: CLB has HTTPS/SSL listener(s) only
      Then: Return COMPLAINT
'''

@jongogogo
Please review the gherkin and let me know for any changes.

See my comments: https://github.com/awslabs/aws-config-rules/issues/190
I suggest we finish the gherkin on ALB first, then adapt for CLB :)

Sure, I will do it after ALB Gherkin is complete, but I have some suggestions and questions

In our documentation we have HTTP, HTTPS, TCP and SSL listeners for CLB. It doesn't list SSL as TLS/SSL listener, do you still want me change SSL to TLS/SSL in the Gherkin?

Since CLB supports both L7 and L4 listeners, by HTTPS/SSL, I meant HTTPS or SSL listeners, I will change this one.

"Need a parameter comma-separated list on the SSL policies". Are you suggesting to use SSL policies also to check if a Load Balancer is Complaint or not?

For your last comment on issue #190 , I am  ok to create two separate rules for HTTPS,SSL listeners and HTTP to HTTPS redirection check, however I was thinking of below about this approach:

Our end goal for this rule is to inform rule user if their CLB has SSL enforced or not (on L7 or L4 or both). If we have two different rule to check if SSL is enforced or not, then how we are going to make a decision about compliance status of the CLB?
Or you are suggesting that we can have two different rules with it's own independent compliance status?

Yes, SSL to TLS/SSL. SSL is the old protocol (and mainly retired), but it became a synonym to encryption in transit for HTTPS. The security community is naming as TLS/SSL sometimes.
OK for L4 to L7, it is a bit more tricky than ALB indeed.
The SSL policies is because certain policies are allowed by PCI DSS (for example) and others are not. So customers must have the ability to check that.


Import Swagger YAML files.

The Swagger Java parser accepts both YAML and JSON files content.
This addresses #585
Notes:

tried https://gist.github.com/earth2marsh/264123aefc2e29551d9d but it doesn't seem a good spec (note all $ref doesn't have #/defintions/ prefix);
this seems to fix it but still apidoc can't import it: I can reproduce the same error with the same spec in JSON format (translated using swaggerhub) so I believe the issue doesn't depend on these changes but it's more deep in the swagger integration regardless of the swagger format - troubleshooting was taking too long so I'll probably open a new issue for this;
tests with YAML versions of JSON specs that were correctly imported looks fine.

lgtm

@mbryzek this is now completed

nice! merging

now live


Add FoxWallet support

Description
This PR adds FoxWallet as a supported wallet.
PLEASE NOTE- Checklist must be complete prior to review.
Checklist

[x] Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
[x] Check the box that allows repo maintainers to update this PR
[x] Test locally to make sure this feature/fix works
[x] Run yarn check-all to confirm there are not any associated errors
[x] Confirm this PR passes Circle CI checks
[x] Add or update relevant information in the documentation

Docs Checklist

[ ] Include a screenshot of any changes (see docs README on running locally)
[ ] Add/update the appropriate package README (if applicable)
[ ] Add/update the related module in the docs demo (if applicable)
[ ] Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/
Tests with demo app (injected)

[ ] send transaction
[ ] switch chains
[ ] sign message
[ ] sign typed message
[ ] disconnect

Tests with demo app (SDK)

[x] send transaction
[x] switch chains
[x] sign message
[x] sign typed message
[x] disconnect

@icodeface thanks for opening the PR! Unfortunately we will not be able to support this update to create a fox-wallet module.
As fox-wallet is an injected-wallet with no SDK requirements all functionality can be added to web3-onboard through adding fox wallet to the injected module.
We discontinued accepting new module that add support for injected wallets and dont have an SDK requirement as each module greatly increases dev time in support and all functionality can be found through add your wallet to the injected wallets module.
And example of this can be found here - https://github.com/blocknative/web3-onboard/pull/1177/files
If you would like to make this update and create a new PR or just update this PR that would be great!
Injected Wallet Contribution Guide: https://onboard.blocknative.com/docs/overview/contribution-guide#adding-injected-wallets

@icodeface thanks for opening the PR! Unfortunately we will not be able to support this update to create a fox-wallet module. As fox-wallet is an injected-wallet with no SDK requirements all functionality can be added to web3-onboard through adding fox wallet to the injected module. We discontinued accepting new module that add support for injected wallets and dont have an SDK requirement as each module greatly increases dev time in support and all functionality can be found through add your wallet to the injected wallets module. And example of this can be found here - https://github.com/blocknative/web3-onboard/pull/1177/files If you would like to make this update and create a new PR or just update this PR that would be great! Injected Wallet Contribution Guide: https://onboard.blocknative.com/docs/overview/contribution-guide#adding-injected-wallets

Thanks, provided a new PR https://github.com/blocknative/web3-onboard/pull/1997


Example no 16. - Typescript version

Github issues for C# /JS / Java/ Python should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Sample information

Sample type: typescript_nodejs/16.proactive-messages
Sample language: TypeScript
Sample name: Proactive messages

Describe the bug
Project won't build
To Reproduce
Steps to reproduce the behavior:

Run npm install
See error

Screenshot:

Thanks @misaizdaleka, investigating further.

I was able to get it running by removing @types/restify as a dependency.

Thanks for sharing. Verified removing @types/restify in package.json solved this issue from my end as well.
Closing this for now. @misaizdaleka. please re-open if needed.


Translate extend-kubernetes/extend-cluster.md in Korean

This is a Feature Request

What would you like to be added

Translate concepts/extend-kubernetes/extend-cluster.md in Korean.
Why is this needed
There is no document with concepts/extend-kubernetes/extend-cluster.md in Korean.
Comments

Page to update: https://kubernetes.io/docs/concepts/extend-kubernetes/extend-cluster/

/language ko
/assign


height data

We noticed that cultivar data has been uploaded for the trait "plant height". Thank you!
The trait "plant height" is measured only in St Louis, but the trait "height" is measured in Maricopa.
Would it be possible to get cultivar data uploaded to terraref for the "height" trait?

Could you please post the code you used to join tables and query cultivars?

big_table %>%   filter(name == 'height') %>%   select(cultivar_id) %>%    collect(n=Inf) %>%    distinct
gives only one result, NA. However, if height is replaced by plant_height, then it returns 4 distinct cultivar_id's.

I think that this is resolved by the updates to the sites_cultivars relationship that I did yesterday. Currently returns 174 distinct cultivars
However,

big_table %>%
  filter(name == 'canopy_height') %>%
  select(cultivar_id) %>%
  collect(n=Inf) %>%
  distinct

returns 369 rows. In

And this:
big_table <- traits %>%
  left_join(variables, by = 'variable_id') %>%
  left_join(sites, by = 'site_id')

z<-big_table %>%
  filter(name == 'canopy_height'&!is.null(date)) %>%
  collect %>%
  mutate(season = ifelse(date < lubridate::ymd('2016-08-01'), 'Season 1', 'Season 2')) %>%
  select(season, cultivar_id, date, mean)

library(ggplot2)
ggplot(data = z , aes(date, mean, group = cultivar_id))+
  geom_point(size = 0.1, alpha = 0.2) +
  geom_smooth(se=FALSE, size = 0.1, alpha = 0.2) +
  facet_wrap(~season, scales = 'free_x')


feat!: make esbuild a peer dependency where possible

Supersedes @gabro's #1018

Hey @AndrewLeedham,
we have other dependencies in our repo that uses esbuild 0.19.4 and esbuild's Plugin type has changed since 0.17.6.
So this PR would help us very much, I can resolve the conflicts if it would help to get this in :smile:

Hey @AndrewLeedham, we have other dependencies in our repo that use esbuild 0.19.4 and esbuild's Plugin type has changed since 0.17.6. So this PR would help us very much, I can resolve the conflicts if it would help to get this in 😄

@Benji1 This is not my PR. Other than providing some feedback, I am not involved in this, and cannot move it forward.

Thanks for moving the needle on this one. This has been superseded by #1232. We decided to go with an approach similar to what @gabro tried, but making esbuild an optional peer dependency. If you still have problems regarding esbuild versions, please raise an issue.


🐞 Adding __iter__ gives type errors

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
Taking example from the docs:
from pydantic import RootModel

class Pets(RootModel[list[str]]):
    root: list[str]

    def __iter__(self):
        return iter(self.root)

    def __getitem__(self, item: str) -> str:
        return self.root[item]

We're getting type errors:

__iter__ => Return type mismatch: base method returns type "TupleGenerator", override returns type "Iterator[str]"
__getitem__ => No overloads for "getitem" match the provided arguments (Even when we define type for )
Example Code
from pydantic import RootModel

class Pets(RootModel[list[str]]):
    root: list[str]

    def __iter__(self):
        return iter(self.root)

    def __getitem__(self, item: str) -> str:
        return self.root[item]

Python, Pydantic & OS Version
pydantic version: 2.9.1
        pydantic-core version: 2.23.3
          pydantic-core build: profile=release pgo=false
                 install path: /home/jd/Projects/mine/wrapwithai/backend/.venv/lib/python3.12/site-packages/pydantic
               python version: 3.12.7 (main, Nov  6 2024, 18:29:01) [GCC 14.2.0]
                     platform: Linux-6.11.0-8-generic-x86_64-with-glibc2.40
             related packages: fastapi-0.114.0 typing_extensions-4.12.2 pydantic-settings-2.4.0
                       commit: unknown

@jd-solanki - why are you overriding the root typing?
if you remove that I don't see any type errors
"""This example shows how to create a root model that iterates over a list of strings."""

from pydantic import RootModel

class Pets(RootModel[list[str]]):
    """A root model that iterates over a list of strings."""

    def __iter__(self):
        return iter(self.root)

    def __getitem__(self, item: str) -> str:
        return self.root[item]

if __name__ == '__main__':
    pets = Pets(root=['dog', 'cat', 'bird'])
    for pet in pets:
        print(pet)  # noqa: T201

    assert pets[0] == 'dog'
    assert pets.root == ['dog', 'cat', 'bird']

hi @jd-solanki (not a maintainer but) why are you overriding root typing? if you remove that I see no type errors
"""create a root model that iterates over a list of strings."""

from typing import Iterator

from pydantic import RootModel

class Pets(RootModel[list[str]]):
    """iterates over a list of strings."""

    def __iter__(self) -> Iterator[str]:
        return iter(self.root)

    def __getitem__(self, item: str) -> str:
        return self.root[item]

if __name__ == '__main__':
    pets = Pets(root=['dog', 'cat', 'bird'])
    for pet in pets:
        print(pet)  # noqa: T201

    assert pets[0] == 'dog'
    assert pets.root == ['dog', 'cat', 'bird']

@jd-solanki could not reproduce issue using same version though. tried using pycharm as well.

         pydantic version: 2.9.1
    pydantic-core version: 2.23.3
      pydantic-core build: profile=release pgo=false
             install path: /Users/addy/Documents/pydantic-testing/venv/lib/python3.12/site-packages/pydantic
           python version: 3.12.4 (v3.12.4:8e8a4baf65, Jun  6 2024, 17:33:18) [Clang 13.0.0 (clang-13<IP_ADDRESS>)]
                 platform: macOS-15.0-arm64-arm-64bit
         related packages: typing_extensions-4.12.2
                   commit: unknown

@adarsharegmi This occurs with the pylance which isn't exist in pycharm

BaseModel implements __iter__, hence you're seeing a collision issue.
In general, I'm not sure that adding __X__ methods is going to mesh well with pydantic.
Also, in your example, I believe __getitem__(self, item: str) -> str  needs to have item be an int and/or a slice.

Indeed, this is expected.
Closing as resolved - feel free to # type: ignore these errors if you're confident in your implementation.


Module settings not available

Kanka-foundry does not show up in module settings. I have both it and Lib doc installed. First install, have not used before.
Foundry Version 9 Build 280
Pathfinder 1 .81.3

I am also having this issue. Additionally, the journal entries imported from Kanka are no longer able to be opened.

Version 2.11.1 should be released soon and should fix this issue. Please give it a try. Sorry for the inconvenience!


Warnings on every single request

Getting these warnings on every single request:
[warn] :max_age was not set on Phoenix.Token.verify/4. A max_age is recommended otherwise tokens are forever valid. Please set it to the amount of seconds the token is valid, such as 86400 (1 day)

In significant amounts.  A max_age should be specified to something to prevent reply attacks later.  :-)

What's the Phoenix version?

Master, the warning was added in this commit:  https://github.com/phoenixframework/phoenix/commit/16d340d23a7faba95d55ea543f623bf56f8cdf8a#diff-dfff98abf14a9bea2145de1b0fd0b5d1
Plus there should always be a max_age anyway even in older versions (preferably short enough to encompass the request and no longer), else the token is replayable.


Add View Job & View Job Results Endpoints

Add support for View Job Details / View Job Results endpoints from the Jobs API

Closed by #31.


DocC Documentation build warnings

These links have all been fixed or removed -- no warnings from the docs that I see now.  That does mean that some of the links I would like to have are missing, but until docc supports them there is not much we can do.
OK to close?


Added check for verified commits

Signed-off-by: Spazzy<EMAIL_ADDRESS>Changelog

Adds a check that looks at commits and fails if commits are not verified

Issues
fix: None

Codecov Report

Merging #99 (7029d74) into main (a7c7867) will increase coverage by 0.73%.
The diff coverage is 92.37%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   86.36%   87.10%   +0.73%
==========================================
  Files          13       13
  Lines         763      876     +113
==========================================
+ Hits          659      763     +104
- Misses         74       78       +4
- Partials       30       35       +5

Flag
Coverage Δ

unittests
87.10% <92.37%> (+0.73%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/types/types.go
100.00% <ø> (ø)

pkg/github/pullrequests.go
80.58% <52.63%> (-3.63%)
:arrow_down:

pkg/github/checks.go
98.70% <100.00%> (+0.89%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c7867...7029d74. Read the comment docs.

/approve

/merge


Remove coupling / dependency on JUnit 4 and the TestRule class

For JUnit 5 tests, testcontainers dependency forces usage of JUnit 4, which should not be necessary.
This causes people accidentally using JUnit 4 constructs in JUnit 5-based test harnesses without knowing it.
JUnit 4 shouldn't be a transitive dependency of testcontainers, usually by putting
<optional>true</optional> into maven pom file
The issue is below
public class GenericContainer<SELF extends GenericContainer<SELF>>
        extends FailureDetectingExternalResource

and then
import org.junit.rules.TestRule;
public class FailureDetectingExternalResource implements TestRule {

The above should not be inheriting from TestRule. If that's necessary, there should be JUnit 4 and 5 versions of this class.

Duplicate of #970


Unable to install dependencies on installation

I'm getting this output on running mentioned installation:
pi@raspberrypi:~ $ bash -c "$(curl -sL https://raw.githubusercontent.com/MichMich/MagicMirror/master/installers/raspberry.sh)"

$$\      $$\                     $$\           $$\      $$\ $$\                                          $$$$$$\
$$$\    $$$ |                    \__|          $$$\    $$$ |\__|                                        $$  __$$\
$$$$\  $$$$ | $$$$$$\   $$$$$$\  $$\  $$$$$$$\ $$$$\  $$$$ |$$\  $$$$$$\   $$$$$$\   $$$$$$\   $$$$$$\  \__/  $$ |
$$\$$\$$ $$ | \____$$\ $$  __$$\ $$ |$$  _____|$$\$$\$$ $$ |$$ |$$  __$$\ $$  __$$\ $$  __$$\ $$  __$$\  $$$$$$  |
$$ \$$$  $$ | $$$$$$$ |$$ /  $$ |$$ |$$ /      $$ \$$$  $$ |$$ |$$ |  \__|$$ |  \__|$$ /  $$ |$$ |  \__|$$  ____/
$$ |\$  /$$ |$$  __$$ |$$ |  $$ |$$ |$$ |      $$ |\$  /$$ |$$ |$$ |      $$ |      $$ |  $$ |$$ |      $$ |
$$ | \_/ $$ |\$$$$$$$ |\$$$$$$$ |$$ |\$$$$$$$\ $$ | \_/ $$ |$$ |$$ |      $$ |      \$$$$$$  |$$ |      $$$$$$$$\
\__|     \__| \_______| \____$$ |\__| \_______|\__|     \__|\__|\__|      \__|       \______/ \__|      \________|
                       $$\   $$ |
                       \$$$$$$  |
                        \______/

Updating packages ...
Hit:1 http://archive.raspberrypi.org/debian stretch InRelease
Hit:2 http://mirrordirector.raspbian.org/raspbian stretch InRelease
Reading package lists... Done
Installing helper tools ...
Reading package lists... Done
Building dependency tree
Reading state information... Done
build-essential is already the newest version (12.3).
unzip is already the newest version (6.0-21).
wget is already the newest version (1.18-5).
The following additional packages will be installed:
  libcurl3
Suggested packages:
  git-daemon-run | git-daemon-sysvinit git-doc git-el git-email git-gui gitk
  gitweb git-arch git-cvs git-mediawiki git-svn
The following packages will be upgraded:
  curl git libcurl3
3 upgraded, 0 newly installed, 0 to remove and 61 not upgraded.
Need to get 3861 kB of archives.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n] y
Get:1 http://mirrordirector.raspbian.org/raspbian stretch/main armhf git armhf 1:2.11.0-3+deb9u2 [3380 kB]
Get:2 http://mirrordirector.raspbian.org/raspbian stretch/main armhf curl armhf 7.52.1-5+deb9u1 [220 kB]
Get:3 http://mirrordirector.raspbian.org/raspbian stretch/main armhf libcurl3 armhf 7.52.1-5+deb9u1 [261 kB]
Fetched 3861 kB in 2s (1511 kB/s)
apt-listchanges: Can't set locale; make sure $LC_* and $LANG are correct!
Reading changelogs... Done
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LANG = "en_GB.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
locale: Cannot set LC_CTYPE to default locale: No such file or directory
locale: Cannot set LC_MESSAGES to default locale: No such file or directory
locale: Cannot set LC_ALL to default locale: No such file or directory
(Reading database ... 122683 files and directories currently installed.)
Preparing to unpack .../git_1%3a2.11.0-3+deb9u2_armhf.deb ...
Unpacking git (1:2.11.0-3+deb9u2) over (1:2.11.0-3) ...
Preparing to unpack .../curl_7.52.1-5+deb9u1_armhf.deb ...
Unpacking curl (7.52.1-5+deb9u1) over (7.52.1-5) ...
Preparing to unpack .../libcurl3_7.52.1-5+deb9u1_armhf.deb ...
Unpacking libcurl3:armhf (7.52.1-5+deb9u1) over (7.52.1-5) ...
Setting up libcurl3:armhf (7.52.1-5+deb9u1) ...
Processing triggers for libc-bin (2.24-11+deb9u1) ...
Processing triggers for man-db (<IP_ADDRESS>-2) ...
Setting up git (1:2.11.0-3+deb9u2) ...
Setting up curl (7.52.1-5+deb9u1) ...
Check current Node installation ...
Node currently installed. Checking version number.
Minimum Node version: v5.1.0
Installed Node version: v4.8.2
Node should be upgraded.
Installing Node.js ...

## Installing the NodeSource Node.js v6.x repo...

## Populating apt-get cache...

+ apt-get update
Hit:1 http://mirrordirector.raspbian.org/raspbian stretch InRelease
Hit:2 http://archive.raspberrypi.org/debian stretch InRelease
Reading package lists... Done

## Confirming "stretch" is supported...

+ curl -sLf -o /dev/null 'https://deb.nodesource.com/node_6.x/dists/stretch/Release'

## Adding the NodeSource signing key to your keyring...

+ curl -s https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key add -
OK

## Creating apt sources list file for the NodeSource Node.js v6.x repo...

+ echo 'deb https://deb.nodesource.com/node_6.x stretch main' > /etc/apt/sources.list.d/nodesource.list
+ echo 'deb-src https://deb.nodesource.com/node_6.x stretch main' >> /etc/apt/sources.list.d/nodesource.list

## Running `apt-get update` for you...

+ apt-get update
Hit:1 http://archive.raspberrypi.org/debian stretch InRelease
Hit:2 http://mirrordirector.raspbian.org/raspbian stretch InRelease
Get:3 https://deb.nodesource.com/node_6.x stretch InRelease [4647 B]
Get:4 https://deb.nodesource.com/node_6.x stretch/main Sources [765 B]
Get:5 https://deb.nodesource.com/node_6.x stretch/main armhf Packages [1007 B]
Fetched 6419 B in 1s (3968 B/s)
Reading package lists... Done

## Run `apt-get install nodejs` (as root) to install Node.js v6.x and npm

Reading package lists... Done
Building dependency tree
Reading state information... Done
The following package was automatically installed and is no longer required:
  libuv1
Use 'sudo apt autoremove' to remove it.
The following packages will be REMOVED:
  nodejs-legacy nodered
The following packages will be upgraded:
  nodejs
1 upgraded, 0 newly installed, 2 to remove and 61 not upgraded.
Need to get 8761 kB of archives.
After this operation, 27.9 MB of additional disk space will be used.
Get:1 https://deb.nodesource.com/node_6.x stretch/main armhf nodejs armhf 6.11.4-1nodesource1 [8761 kB]
Fetched 8761 kB in 5s (1551 kB/s)
apt-listchanges: Can't set locale; make sure $LC_* and $LANG are correct!
apt-listchanges: Reading changelogs...
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LANG = "en_GB.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
locale: Cannot set LC_CTYPE to default locale: No such file or directory
locale: Cannot set LC_MESSAGES to default locale: No such file or directory
locale: Cannot set LC_ALL to default locale: No such file or directory
(Reading database ... 122683 files and directories currently installed.)
Removing nodered (0.17.4) ...
Removing nodejs-legacy (4.8.2~dfsg-1) ...
(Reading database ... 115794 files and directories currently installed.)
Preparing to unpack .../nodejs_6.11.4-1nodesource1_armhf.deb ...
Unpacking nodejs (6.11.4-1nodesource1) over (4.8.2~dfsg-1) ...
Processing triggers for mime-support (3.60) ...
Processing triggers for desktop-file-utils (0.23-1) ...
Setting up nodejs (6.11.4-1nodesource1) ...
Processing triggers for gnome-icon-theme (3.12.0-2) ...
Processing triggers for man-db (<IP_ADDRESS>-2) ...
Processing triggers for gnome-menus (3.13.3-9) ...
Node.js installation Done!
Cloning MagicMirror ...
Cloning into 'MagicMirror'...
remote: Counting objects: 8632, done.
remote: Total 8632 (delta 0), reused 0 (delta 0), pack-reused 8632
Receiving objects: 100% (8632/8632), 11.27 MiB | 1.39 MiB/s, done.
Resolving deltas: 100% (4887/4887), done.
Cloning MagicMirror Done!
Installing dependencies ...
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g

><EMAIL_ADDRESS>install /home/pi/MagicMirror/node_modules/uws
> node-gyp rebuild > build_log.txt 2>&1 || exit 0

Unable to install dependencies!

I had the same issue when trying to install Magicmirror on my freshly installer Rpi 3.

Which os are you trying? (It would really help if you filled in all the required information when creating an issue. Thanks!)

Sorry I forgot to mention.
I was using the lates raspbian package, which I donwloaded yesterday.
The Image is called: 2017-09-07-raspbian-stretch.img
I have Installed MagicMirror2 yesterday for a first try and it was working.
After playing around with config it refused working yesterday.
Today I wrote the raspbian image againto the SD Card and tried installing MM, what failed.

We got some reports from issues with Electron on "Stretch". You might want to try "Jessie"

I cannot get Jessie running on my Raspberry 3.
Do you have any rough schedule, when MM will work with Stretch?

I had the same problem.
Raspberry Pi 2 running Jessie and MagicMirror then upgrade to Stretch and it is still works but Raspberry Pi 3 with Stretch from beginning doesn't wanna run Electron.
I will try installing Jessie and MM before doing the upgrade on my Pi3.

Electron needs to be Fixed to run on Stretch. This needs to be done by the Electron team.

Hi,
Is the electron team aware of this issue?
BR Thorsten

Am 10.10.2017 um 17:19 schrieb Michael Teeuw<EMAIL_ADDRESS>Closed #1050.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi, I had a similar issue, I dont know if you solved it, but someone may still be struggling. I read in another post a way to solve it and it worked for me.
I installed the last version of raspbian (March 2018), followed youtube's setup videos, and couldnt get the magicmirror to work. What I then did was install raspbian without updating and upgrading anything. I inserted the sd, let it boot, configure wifi and language settings and installed MagicMirror with the automatic installation.
It works perfectly now and havent had any issue with it or any module. Hope this helps someone with a similar problem!


Reduce deps

This PR remove dependencies on refmterr (used only at build time) and esy-cmake 👀 I wonder why it was their.
Rationale: I have low disk space on my linux partition so try to reduce revery size globally. Another reason: less dependencies mean more easier to update. Now to publish to opam we need to publish our patched esy-sdl2 and this package is ready.

I have force pushed because I have forgotten to remove<EMAIL_ADDRESS>to test<EMAIL_ADDRESS>

Should we do something about the JS-build? @Et7f3

I really don't know what happen here. I will try to investigate after.

@lessp on master can you add: "@opam/lwt_ppx": "^2.0.0",

We had similar issuer with sdl https://discordapp.com/channels/526111832478449695/532721901886504981/676493496575590417

"@opam/lwt_ppx": "^2.0.0"

Can confirm it builds on master when adding this to js.json

Ok I am rebasing because a unused deps was already removed https://github.com/revery-ui/reason-sdl2/commit/d679957aefe07f932d0e2cee2bc1c77ba0d8f8a4


Install S3 repository plugin by default

S3 repository plugin is very popular plugin used to snapshot the data , specially in the cloud
I think it will be nice to have it installed  by default in the image

Not sure this is the right approach. The image will also be used in self hosted environments or by users not using S3 and they should not be forced to have a plugin installed they never use.
If someone needs a plugin, one can just modify the Dockerfile and add a line like this and build it's own image

I agree with @jakommo, this should not be done.

General consensus is not to include this, so I am going to close the issue.


New package: SimSpread v1.0.1

Registering package: SimSpread
Repository: https://github.com/cvigilv/SimSpread.jl
Created by: @cvigilv
Version: v1.0.1
Commit: 5ab448b42ad6c5b8ec3ea9dc6b1cfc7aae2eb7a5
Reviewed by: @cvigilv
Reference: https://github.com/cvigilv/SimSpread.jl/commit/5ab448b42ad6c5b8ec3ea9dc6b1cfc7aae2eb7a5#commitcomment-131163372
Description: SimSpread is a novel approach for predicting interactions between two distinct set of nodes, query and target nodes, using a similarity measure vector between query nodes as a meta-description in combination with the network-based inference for link prediction.

close PR


Speed problem with large files on Raspberry Pi 2

I have been experiencing a speed issue with CNC V1.8.7 on my Raspberry pi 2. Specifically with large files. I have found that CNC is unable the feed to data to my Arduino fast enough and the planner buffer and serial bufer is hovering around empty. However if I have just a small portion of the same G-code file, CNC has no problem feeding it to my Arduino and the planner buffer staying nice and full and the serial buffer is about 60-80% full most of the time.
One example is a Laser Raster which is 6.6MB in size and contains 357,000 lines of G-code. From the second it starts, CNC is struggling to feed the data fast enough from the raspberry pi to the Arduino. However if I take the first 15,000 line of that same file, it feed to data fast enough to keep the planner buffer full.
This same file running on the Windows version on the same Arduino has no problems. It is only a problem on the raspberry pi. Has anyone else experienced this.
I have attached a ZIP file which contained two G-code files. One is the full file, and one is the first 15,000 lines.
I've also attached some screen shots of the running process. As you can see, the full file has only executed 3300 lines, but the smaller file has executed 13280 lines of the same code in the same amount of time.
For reference, the full G-Code file execute cleanly on Windows CNC 1.8.7 in Windows 10 and takes about 42 minutes. But on the raspberry pi, it stutters a lot  takes over 2 hours.

Zac - RIP.zip

I have also noticed the same issue of the planer buffer always at zero as well on most if not all of my carves.

In CNC.js running GRBL 1.1, if the planner buffer is 0, that means it is full, and that's a good thing. On small files, I get 0 on the planner buffer and everything runs smooth, but on large files the buffer jumps between 14 and 15 when means GRBL is starved of data and causes it to stutter.

I've tested the same 357,000 line file using the python script 'stream.py' on my raspberry pi and it has no problem keeping up with CPU usage sitting below 5% the whole time.

I've just updated to V1.8.8 and still having the same problem.

Sorry for the late, I have been so busy the last two weeks. Next week I should have time to investigate the performance issue with your large G-code files on a RPi2. I will keep you updated once I found some clues.

Hi @mayhem2408,
May I know your full Grbl settings ($$), especially the followings:
$100  X-axis steps per millimeter
$101  Y-axis steps per millimeter
$102  Z-axis steps per millimeter
$110  X-axis maximum rate, mm/min
$111  Y-axis maximum rate, mm/min
$112  Z-axis maximum rate, mm/min
$120  X-axis acceleration, mm/sec^2
$121  Y-axis acceleration, mm/sec^2
$122  Z-axis acceleration, mm/sec^2

I tried "Zac - RIP - Y0-Y3.9.nc" and "Zac - RIP - Full.nc" files, but both cannot achieve the feed rate 2000 mm/min in status reports.

I forgot to enable laser mode by altering the $32 Grbl setting with the value of 1. After setting $32=1, it can achieve the desired feed rate.
After several tries, I experienced the same issue that both planner buffer and receive buffer are not fully utilized when loading a large file (e.g. Zac-RIP-Full.nc) on RPi2, but it never happened on a powerful machine like Windows desktop or Mac Book.
Needs to investigate what might be affected by CPU power while handling a large size of array on RPi2.
Zac-RIP-Full.nc

Zac-RIP-Y0-Y3.9.nc

https://gamealchemist.wordpress.com/2013/05/01/lets-get-those-javascript-arrays-to-work-fast/
Push and pop are not constant time operations

Push and pop are not constant time operations, but are taking a time proportional to the array’s length ( O(n) ), and memory fragmentation.

It might be related to the remain and sent array, which contains two copies of full G-code lines:
https://github.com/cheton/cnc/blob/master/src/app/lib/gcode-sender.js#L13
class GCodeSender extends events.EventEmitter {
    name = '';
    gcode = '';
    remain = [];
    sent = [];

I made some performance improvements for reducing the loading time by removing unnecessary regular expressions of parsing G-code commands. The loading speed will be 10x faster than current release.

The code changes for performance enhancements is still under local development, it will be released in 1.8.13 or 1.9.0.

This might be worth a read for one way to go about performance debugging on a node.js application.

http://techblog.netflix.com/2014/11/nodejs-in-flames.html
https://www.dynatrace.com/blog/how-to-track-down-cpu-issues-in-node-js/

@cheton  I have read that the shift() method can be very slow on large arrays. I was going to have a look at the code to see if a single array and an index variable could be used instead of the two arrays with Shifts and pushes, which would mean the large array would not have to be altered once loaded. I'll wait for your next release to see how it goes.

Just like you said, I refactored current implementation of character-counting streaming protocol using a single array (this.lines) and an index variable (this.sent). The time complexity is O(1), which should be much faster when handling a large array.
[STREAMING_PROTOCOL_CHAR_COUNTING]: () => {
    if (this.transmitDataQueue.length > 0) {
        const dataLength = this.transmitDataQueue.shift();
        this.transmitDataLength -= dataLength;
    }

    while (this.sent < this.total) {
        const line = this.lines[this.sent];
        this.transmitLine = this.transmitLine || stripLine(line);

        if (this.transmitLine.length + this.transmitDataLength >= this.transmitBufferSize) {
            break;
        }

        const gcode = this.transmitLine;
        this.transmitLine = ''; // clear transmitLine

        this.sent++;
        this.emit('change');

        if (gcode.length > 0) {
            this.transmitDataLength += gcode.length;
            this.transmitDataQueue.push(gcode.length);
            this.emit('gcode', gcode);
        } else {
            this.ack(); // Ack for empty lines
        }

        // Continue to the next line if empty
    }
}

Also made significant performance improvements for gcode-parser, gcode-interpreter, and gcode-toolpath. It will speed up the loading time at least 5x faster than earlier versions.

I've downloaded and manually installed 1.8.13 from the master and WOW. What a difference. The Raspberry Pi is keeping up and with room to spare. CPU usage is now only between 20-30% and the Planner and Serial buffers are remaining full.
Full file on V1.8.12 took 2h:43m to complete.
Full file on V1.8.13 took 43minutes which is the same as the stream.py python script.
The Load and render to improvement are massive.
V1.8.12, Load took 1m:33s and Render took 2m:00s, Total 3m:33s.
V1.8.13. Load took 0m:16s and Render was took quick to see. Total 0m:16s.
Thats over 13x faster.
Well done. Awesome work.

@cheton I though i'd give it a workout with some of my larger files. The next one was 650,000 line and 12Mb. It loaded and Rendered is 33 seconds and streams with no performance hit keeping the Raspberry Pi CPU at 20-30% and buffers are full.
So I though lets really stress test this thing. 1,885,791 lines of gcode and 35Mb.
This time Google Chrome said Aw... Google chrome has run out of memory.
So I tried 998,996 lines at 19.1Mb. It loaded and the Raspberry Pi streamed it OK, but Google Chrome keeps going not responsive. I'm guessing thats a Chrome limitation and not a great deal you can do about that.

Can you try to close the G-code widget? This widget may also consume a lot of memory while loading a large G-code file.
A better solution is to use a so-called lazy-loading mechanism instead of processing all the lines at once, which will save a lot of memory in the browser.

Fixed in 1.8.13.
For large file support (i.e. >20MB), I will create another issue for future enhancements.


Doesn't take notice of the command line

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
Why am I going to Chrome when I was told to use Edge?
PS C:\YouTube-DL> .\yt-dlp_x86.exe --cookies-from-browser Edge https://www.youtube.com/watch?v=dwaxWoJPUC0
Extracting cookies from edge
ERROR: Could not copy Chrome cookie database. See  https://github.com/yt-dlp/yt-dlp/issues/7271  for more info
ERROR: Could not copy Chrome cookie database. See  https://github.com/yt-dlp/yt-dlp/issues/7271  for more info
PS C:\YouTube-DL>
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
PS C:\YouTube-DL> .\yt-dlp_x86.exe -U
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds)
PS C:\YouTube-DL> .\yt-dlp_x86.exe --cookies-from-browser Edge https://www.youtube.com/watch?v=dwaxWoJPUC0
Extracting cookies from edge
ERROR: Could not copy Chrome cookie database. See  https://github.com/yt-dlp/yt-dlp/issues/7271  for more info
ERROR: Could not copy Chrome cookie database. See  https://github.com/yt-dlp/yt-dlp/issues/7271  for more info
PS C:\YouTube-DL> .\yt-dlp_x86.exe -vU --cookies-from-browser Edge https://www.youtube.com/watch?v=dwaxWoJPUC0
[debug] Command-line config: ['-vU', '--cookies-from-browser', 'Edge', 'https://www.youtube.com/watch?v=dwaxWoJPUC0']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds [fca3eb5f8] (win_x86_exe)
[debug] Python 3.10.11 (CPython AMD64 32bit) - Windows-10-10.0.22631-SP0 (OpenSSL 1.1.1t  7 Feb 2023)
[debug] exe versions: ffmpeg 2024-07-28-git-e7d3ff8dcd-full_build-www.gyan.dev (setts), ffprobe 2024-07-28-git-e7d3ff8dcd-full_build-www.gyan.dev, phantomjs 2.1.1
[debug] Optional libraries: Cryptodome-3.21.0, brotli-1.1.0, certifi-2024.08.30, mutagen-1.47.0, requests-2.32.3, sqlite3-3.40.1, urllib3-2.2.3, websockets-14.1
[debug] Proxy map: {}
Extracting cookies from edge
[debug] Extracting cookies from: "C:\Users\Clive\AppData\Local\Microsoft\Edge\User Data\Default\Network\Cookies"
ERROR: Could not copy Chrome cookie database. See  https://github.com/yt-dlp/yt-dlp/issues/7271  for more info
Traceback (most recent call last):
  File "yt_dlp\cookies.py", line 310, in _extract_chrome_cookies
  File "yt_dlp\cookies.py", line 1102, in _open_database_copy
  File "shutil.py", line 417, in copy
  File "shutil.py", line 254, in copyfile
PermissionError: [Errno 13] Permission denied: 'C:\\Users\\Clive\\AppData\\Local\\Microsoft\\Edge\\User Data\\Default\\Network\\Cookies'

ERROR: Could not copy Chrome cookie database. See  https://github.com/yt-dlp/yt-dlp/issues/7271  for more info
Traceback (most recent call last):
  File "yt_dlp\cookies.py", line 310, in _extract_chrome_cookies
  File "yt_dlp\cookies.py", line 1102, in _open_database_copy
  File "shutil.py", line 417, in copy
  File "shutil.py", line 254, in copyfile
PermissionError: [Errno 13] Permission denied: 'C:\\Users\\Clive\\AppData\\Local\\Microsoft\\Edge\\User Data\\Default\\Network\\Cookies'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "yt_dlp\cookies.py", line 99, in load_cookies
  File "yt_dlp\cookies.py", line 122, in extract_cookies_from_browser
  File "yt_dlp\cookies.py", line 351, in _extract_chrome_cookies
yt_dlp.utils.DownloadError: Could not copy Chrome cookie database. See  https://github.com/yt-dlp/yt-dlp/issues/7271  for more info

Did you read what the error message said? See https://github.com/yt-dlp/yt-dlp/issues/7271#issuecomment-1584404779.

Why am I going to Chrome when I was told to use Edge?

Edge is a chromium-based browser; it shares its cookies code with Chrome. The issue you are experiencing is #7271, see the comment linked above for workarounds.
Even if you work around that, though, you'll probably run into #10927
Either use Firefox with --cookies-from-browser or else export your cookies to a cookiefile and use it with --cookies


dartanalyzer: command not found

I am trying to use this lib, but when i try to run, i get the following error:

dartanalyzer: command not found

Steps do reproduce:
1º RUN export PATH="$PATH":"$HOME/.pub-cache/bin"
2º RUN dart pub global activate code_quality_report
3º RUN dartanalyzer . --format=machine 2>&1 | tocodeclimate > code-quality-report.json

The problemas was happening because my dart-sdk bin folder was not in my PATH variable.


Add CellOffsets abstraction

Refactor Notebook::cell_offsets to use an abstract struct for storing the cell
offsets. This will allow us to add useful methods on it.

Current dependencies on/for this PR:

main

PR #8813

PR #8814   👈

PR #8815

This stack of pull requests is managed by Graphite.