Add tests for PaddingDesignable & fix height bug

Summary of Pull Request:

This Pull Request adds tests for the PaddingDesignable protocol.
The height for the padding view has been changed to a default value of 1 pt.

Reasoning:

The height previously was 0 for the left and right padding.
The height for the sides configuration was set to the amount of width padding.

Therefore, if you provided a width that was greater than the height of the text field, the padding view could possibly extend outside the bounds of the text field.

          2 Warnings

:warning:
Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

:warning:
Consider adding / updating the demo ap.

SwiftLint found issues
Warnings

File
Line
Reason

AnimatableTextFieldTests.swift
70
Lines should not have trailing whitespace.

AnimatableTextFieldTests.swift
74
Lines should not have trailing whitespace.

AnimatableTextFieldTests.swift
78
Lines should not have trailing whitespace.

  Generated by :no_entry_sign: Danger

No problem! Ran out of time to fix SwiftLint warnings last night 😅

#434 - marking this for record keeping


Exception when using Redis-Pool

I get decoding exception when I use a redis-pool along with rejson client.
I'll use the same code as the Usage Example in README
from rejson import Client, Path
import redis

redis_pool = None

def redis_create_pool() -> None:
    """
    Get redis pool and init it globally.
    This is done at the start of main.py
    """
    # Redis client bound to pool of connections (auto-reconnecting).
    global redis_pool
    redis_pool = redis.ConnectionPool.from_url("redis://localhost", max_connections=10)

redis_create_pool()
rj = Client(decode_responses=True, connection_pool=redis_pool)

# Set the key `obj` to some object
obj = {
    'answer': 42,
    'arr': [None, True, 3.14],
    'truth': {
        'coord': 'out there'
    }
}
rj.jsonset('obj', Path.rootPath(), obj)

# Get something
print('Is there anybody... {}?'.format(rj.jsonget('obj', Path('.truth.coord'))))

# Delete something (or perhaps nothing), append something and pop it
rj.jsondel('obj', Path('.arr[0]'))
rj.jsonarrappend('obj', Path('.arr'), 'something')
print('{} popped!'.format(rj.jsonarrpop('obj', Path('.arr'))))

# Update something else
rj.jsonset('obj', Path('.answer'), 2.17)

# And use just like the regular redis-py client
jp = rj.pipeline()
jp.set('foo', 'bar')
jp.jsonset('baz', Path.rootPath(), 'qaz')
jp.execute()

# If you use non-ascii character in your JSON data, you can add the no_escape flag to JSON.GET command
obj_non_ascii = {
    'non_ascii_string': 'hyvää'
}
rj.jsonset('non-ascii', Path.rootPath(), obj_non_ascii)
print('{} is a non-ascii string'.format(rj.jsonget('non-ascii', Path('.non_ascii_string'), no_escape=True)))

This is the diff
1a2
> import redis
3c4,17
< rj = Client(host='localhost', port=6379, decode_responses=True)
---
> redis_pool = None
>
> def redis_create_pool() -> None:
>     """
>     Get redis pool and init it globally.
>     This is done at the start of main.py
>     """
>     # Redis client bound to pool of connections (auto-reconnecting).
>     global redis_pool
>     redis_pool = redis.ConnectionPool.from_url("redis://localhost", max_connections=10)
>
>
> redis_create_pool()
> rj = Client(decode_responses=True, connection_pool=redis_pool)

Exception

TypeError: cannot use a string pattern on a bytes-like object

Hello,
You didn't set decode_responses to True when you initialized your ConnectionPool.
The decode_responses is passed to the ConnectionPool object of the client when you create it.
Redis ConnectionPool are used by default when you initialize a Redis Client. Do you have a specific reason to initialize the ConnectionPool beforehand ?
You can skip the ConnectionPool part, and set up your rejson Client with the max_connection set to 10 and it would automatically create a connection pool managed by the Rejson client, that you can access atrj.connection_pool.
Here you can see the Redis client creating the ConnectionPool.
https://github.com/andymccurdy/redis-py/blob/9ed5cd7808789f791fdc7ee368bd268307ac9847/redis/client.py#L874-L875
Hope this helps

I'm using both rejson and redisearch. So my reasoning behind initializing a pool prehand is so that I can use the same pool for both the clients
import redis
import redisearch
import rejson

redis_pool = None

def redis_pool_get_con():
    return redis.Redis(connection_pool=redis_pool)

def redis_create_pool() -> None:
    global redis_pool
    redis_pool = redis.ConnectionPool.from_url("redis://localhost", max_connections=10)

redis_create_pool()
rs = redisearch.Client(index_name, conn=redis_pool_get_con())
rj = rejson.Client(decode_responses=True, connection_pool=redis_pool)

I don't know if there's a better way for your case, but I've checked in the RediSearch python client, and they use decode_responses as True for their ConnectionPool. So both ReJSON and RediSearch needs their ConnectionPool to have decode_responses set to True.
https://github.com/RediSearch/redisearch-py/blob/77ec182bff7039798037a8f1d069930e943fb745/redisearch/client.py#L245-L256
So for your case, when you create your ConnectionPool, set decode_responses to True.
def redis_create_pool() -> None:
    global redis_pool
    redis_pool = redis.ConnectionPool.from_url("redis://localhost", max_connections=10, decode_responses=True)

It should fix your Exception.

Thank you.


Add Expected recovered date for Active cases in State and District wise

Add Expected recover date for Active cases in State wise and District wise details based on everyday report

Could you elaborate on what you mean by Expected recover date.
Also, is that date available in the everyday reports?

Hi Krishna Pravin
First a fall thanks for review my feature request . I'm looking through the map state wise and district wise it will very hard to understand when it will solve all cases in particular districts and state wise.
For example Chennai is a district present inside a state of TamilNadu . It has more cases and don't know when it will get cured all patients . To know the rough estimate we can calculate some days for example consider last cases is reported today may 02 we can add 28 days and mentioned expected recover all patients by May 30 .
It is not accurate but it will help to understand within the mentioned date all patients will be recovered . We can add like this in all districts and state wise.

IMO this could be very speculative and misleading. Unless all the asymptotic cases are mapped and there are no unknown cases, the average recovery rate cannot be used to predict the estimated date of recovery for all patients.

Thanks

From: bee-rickey<EMAIL_ADDRESS>Sent: Sunday, May 3, 2020 1:54 PM
To: covid19india/covid19india-react<EMAIL_ADDRESS>Cc: christopherbramya<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [covid19india/covid19india-react] Add Expected recovered date for Active cases in State and District wise (#1665)
IMO this could be very speculative and misleading. Unless all the asymptotic cases are mapped and there are no unknown cases, the average recovery rate cannot be used to predict the estimated date of recovery for all patients.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/covid19india/covid19india-react/issues/1665#issuecomment-623073850, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APMTB3IWTVZ72VDDSPXRS4TRPUS4VANCNFSM4MVB4VTQ.


not smooth line in linechart

Describe the bug
i am using line chart.
my data set is :-
[
{
"date": "2023-12-27",
"isZero": true,
"labelName": "Mood",
"shift": false,
"value": 0
},
{
"date": "2023-12-28",
"isZero": true,
"labelName": "Mood",
"shift": false,
"value": 6
},
{
"date": "2023-12-29",
"isZero": true,
"labelName": "Mood",
"shift": false,
"value": 9
},
{
"date": "2023-12-30",
"hideDataPoint": true,
"isZero": true,
"labelName": "Mood",
"shift": false,
"value": 8
},
{
"date": "2023-12-31",
"hideDataPoint": true,
"isZero": true,
"labelName": "Mood",
"shift": true,
"value": 7
},
{
"date": "2024-01-01",
"isZero": true,
"labelName": "Mood",
"shift": true,
"value": 6
},
{
"date": "2024-01-02",
"isZero": true,
"labelName": "Mood",
"shift": true,
"value": 9
}
]
as you can see the values are whole numbers.I have attached the screenshot of chart produced using these data points. As you can see the curver from friday to monday is not smooth even though the points are whole numbers. Can you help me with this issue what wrog is done from my end using this package. the dotted lines are the values where the user has not entered the values so i have averaged out the score and changed those values from null to some value toto show dotted lines in this scenario.

Hi @Rinku222 👋
Try using the prop curveType={CurveType.QUADRATIC}
See https://github.com/Abhinandan-Kushwaha/react-native-gifted-charts/issues/474#issuecomment-1861036464


[7.20.2] Error when executing code in an fsx file

Describe the bug
Error when executing code in an fsx file.

The issue does not occur with 7.20.1.
Steps to reproduce

Create an fsx file.
Enter  a single line with: open System.
With the cursor on the above line do ALT+ENTER.

Expected behaviour
> # silentCd @"c:\Data\FSharp\Projects\<REMOVED>\tests\DO NOT COMMIT";;
- # 1 @"c:\Data\FSharp\Projects\<REMOVED>\tests\DO NOT COMMIT\issue.fsx"
- open System;;
>

Screenshots
Notification appears when doing ALT+ENTER

Machine info

OS: Windows 10 Pro 10.0.19045 Build 19045
.NET SDK version: 8.0.302
Ionide version: 7.20.2

https://github.com/microsoft/vscode/issues/216543
this is getting executed at fsi launch.
dotnet fsi -fsi-server-input-codepage:28591 --fsi-server-output-codepage:65001
There seems to be a dash missing. Need -- (two dashes) before fsi-server-input...

We're getting the same error since restarting VS Code today. The problem was introduced in yesterday's Ionide update version 7.20.2.
Reverting back to version 7.20.1 solves the problem:

Thanks for the reports folks, well take a look and try to see what's going on.

Are any of you passing the following settings?

FSharp.fsiExtraParameters
FSharp.FSIExtraSharedParameters
FSharp.FSIExtraInteractiveParameters

This is my settings file - not passing any parameters (I removed workspace settings and the problem still persists so they are not affecting this issue):
{
    "terminal.integrated.confirmOnExit": "always"

}

Reverting to older version of ionide fixes this issue. It seem this issue got introduced with 7.20.2.
The linked or referenced issue shows how you can debug launch failures with "code --trace log" command. That is how I found the actual command line and parameters that VS was sending to powershell (i think).

This is entirely my fault - I messed up the binding of the parameters from the VSCode configuration. A new release with the fix is building now!

What .NET SDK are you using?

> dotnet --info
.NET SDK:
 Version:           8.0.302
 Commit:            ef14e02af8
 Workload version:  8.0.300-manifests.f6879a9a
 MSBuild version:   17.10.4+10fbfbf2e

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.19045
 OS Platform: Windows
 RID:         win-x64
 Base Path:   C:\Program Files\dotnet\sdk\8.0.302\

.NET workloads installed:
There are no installed workloads to display.

Host:
  Version:      8.0.6
  Architecture: x64
  Commit:       3b8b000a0e

.NET SDKs installed:
  2.1.202 [C:\Program Files\dotnet\sdk]
  2.1.526 [C:\Program Files\dotnet\sdk]
  2.2.101 [C:\Program Files\dotnet\sdk]
  2.2.402 [C:\Program Files\dotnet\sdk]
  3.0.100 [C:\Program Files\dotnet\sdk]
  3.1.426 [C:\Program Files\dotnet\sdk]
  5.0.101 [C:\Program Files\dotnet\sdk]
  5.0.203 [C:\Program Files\dotnet\sdk]
  5.0.214 [C:\Program Files\dotnet\sdk]
  5.0.303 [C:\Program Files\dotnet\sdk]
  5.0.408 [C:\Program Files\dotnet\sdk]
  6.0.100 [C:\Program Files\dotnet\sdk]
  6.0.131 [C:\Program Files\dotnet\sdk]
  6.0.203 [C:\Program Files\dotnet\sdk]
  6.0.321 [C:\Program Files\dotnet\sdk]
  6.0.423 [C:\Program Files\dotnet\sdk]
  8.0.106 [C:\Program Files\dotnet\sdk]
  8.0.206 [C:\Program Files\dotnet\sdk]
  8.0.302 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.All 2.1.30 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.30 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.1.32 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 5.0.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 5.0.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 5.0.17 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 6.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 6.0.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 6.0.10 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 6.0.26 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 6.0.31 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 8.0.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.30 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.32 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 5.0.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 5.0.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 5.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 5.0.17 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 6.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 6.0.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 6.0.10 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 6.0.26 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 6.0.31 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 8.0.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 3.1.32 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 5.0.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 5.0.6 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 5.0.9 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 5.0.17 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 6.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 6.0.5 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 6.0.10 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 6.0.26 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 6.0.31 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 8.0.6 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Is there any code I can run in the fsx file that will show me what version of the .NET SDK it thinks it's using?

fyi 7.20.3 fixed the issue for me
dotnet  --info attached
Command Prompt.txt

There are two issues in this report I think:

A bug in the Ionide layer around passing args to FSI. This is fixed.
A potential bug in the FSAC layer around args used for typechecking - this one I'm still trying to investigate/figure out what additional data is needed

@baronfel Have you made any progress looking into this issue?

No, sadly. I haven't been able to repro it on my end to dig in further yet.

Strange!
I've now tried updating to 7.20.3 on three PC's all of which give the above error. This is two Win 10 and one Win 11. On two of the PC's I removed all extensions apart from:
.NET Install Tool v2.0.7
C# v2.34.12
Ionide for F# v7.20.3
Unfortunately, I have no problem reproducing the issue (d'oh!).

@baronfel Somehow I managed to miss your reply:

Are any of you passing the following settings?
* FSharp.fsiExtraParameters

* FSharp.FSIExtraSharedParameters

* FSharp.FSIExtraInteractiveParameters

I setup a VM with VSCode and Ionide only. It works with no errors. I then replaced the settings.json with the one from my main PC and got the error. Looking through the settings.json file I found:
"FSharp.fsiExtraParameters": [
    "--multiemit-"
],

With the following warning:
This setting can lead to errors when providing both FSI-CLI-only and script-typechecking-related parameters.
Please use `#FSharp.FSIExtraInteractiveParameters#` for FSI-CLI-specific parameters,
and `#FSharp.FSIExtraSharedParameters#` for typechecking-related parameters.(2)

I removed this and the error went away. I think I have this issue on multiple PC's because my settings were synced. Can't remember setting this value.
Thanks for your help, and sorry for wasting your time by not reading your replies properly.


Error with np.random.choice

Traceback (most recent call last):
File "avg_runner.py", line 185, in
main()
File "avg_runner.py", line 181, in main
runner.train()
File "avg_runner.py", line 68, in train
batch = get_train_batch()
File "/Users/shreyans/Desktop/Hamburg_Assignments/Neural networks/version 2/Adversarial_Video_Generation/Code/utils.py", line 126, in get_train_batch
path = c.TRAIN_DIR_CLIPS + str(np.random.choice(c.NUM_CLIPS)) + '.npz'
File "mtrand.pyx", line 1120, in mtrand.RandomState.choice
ValueError: a must be greater than 0

@itsmeshreyans Have you solve it? I met the same question with you.

I got the same error when I was running process_data.py.

You need to make sure the dataset in the right directory.
---Original---
From: "WANG<EMAIL_ADDRESS>Date: Sun, Jun 2, 2019 22:48 PM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS>Subject: Re: [dyelax/Adversarial_Video_Generation] Error with np.random.choice (#26)
I got the same error when I was running process_data.py.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@stillbetter Thank you! I got this problem solved, and I can run avg_runner.py without normally after processing data.


Improved data stream inspector

Pull Request Test Coverage Report for Build 607

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.797%

Totals

Change from base Build 605:
0.0%

Covered Lines:
4926

Relevant Lines:
4936

💛  - Coveralls


Update attachment_office365_image.yml

Description
Explain your change and why. For example, "negating legitimate replies," or "adding additional credential theft keywords."
If it's a new rule or insight, explain what the rule is designed to catch/what the insight should fire on.
Associated samples
Link to samples that are affected by your change.
For example, samples you are negating, samples you are including, or samples your new insight should fire on.

Sample 1
Sample 2

Associated hunts
If you ran any hunts with your rule, please link them here.

Hunt 1

Screenshot (insights)
For new insights only: Insert a screenshot of the insight firing. Remove this section if not applicable.

//mql-mimic-exempt: 245222
245222 = FP


[PE-D][Tester E] Postal Code parameter in Add Command is accepted even though Empty

Is the po parameter in AddCommand supposed to be compulsory? Even though I left out the field, it is still added, which is different from what is shown in the UserGuide documentation. Perhaps consider changing the UserGuide to make the po parameter optional?

Labels: severity.VeryLow type.DocumentationBug
original: elizabethhky/ped#8

Merging with #122


Flow chart in README does not correspond to example input

The flowchart image (http://francoislaberge.github.io/diagrams/docs/flowchart.png) has not been updated to be consistent with the README.md example (changed in 46e7f26).

I believe this is fixed.


jungaretti:jungaretti/add-proto-guide

What operating system and terminal are you using?
An example that showcases the bug.
What did you expect to see?
What did you see instead?

jungaretti:jungaretti/add-proto-guide


Width is a bit weird

the -width param acts very weird, its described as pixels unit, however if I set it to 450, I get an 18kx18k pixel image. If I specify 10, I get a 410x410 image, so I suspect there is some sort of mathematical shenanigans going on...
EDIT: thinking about it, it sounds like its acting like a multiplier rather than a static value...

mmmh
Also if you have more "data" in the QR-Code it gets also bigger.
New-QRCodeText -Width 10 -Text dfdsfdsfdsfdsfsdfsdfs2 -Show

New-QRCodeText -Width 10 -Text 1 -Show

i also think we cant realy do somthing because we depending on https://github.com/codebude/QRCoder where the GetGraphic(width) function is in

EDIT: thinking about it, it sounds like its acting like a multiplier rather than a static value...

Too bad that it takes an integer, then. Maybe we could get desired dimensions if we could supply a value between 0 and 1. :) The cmdlets validate width values 10-2000...
Any chance this will be updated to work "as advertised" (100 px by default, custom px dimensions using the Width parameter)?


Test Unlocking Doesn't save

After unlocking a couple of questions, ok exits and doesn't save the unlocked progress.

Any details on how to reproduce this?

I haven't really looked into it, but my guess is that if you exit out of a question halfway through it is definitely going to repro this. ("Ctrl +C")

From Youri:
I ran python3 ok -u like the specs told me to and went through unlocking
some questions and stopped after unlocking up to question2. However, when I
type in exit() it completely exits ok and doesn't give me an option to save
the questions I unlocked up until that point. I had to re-unlock them when
I was unlocking each question specifically.
On Sat, Jan 31, 2015 at 8:44 PM, albert12132<EMAIL_ADDRESS>wrote:

Any details on how to reproduce this?
—
Reply to this email directly or view it on GitHub
https://github.com/Cal-CS-61A-Staff/ok-client/issues/37#issuecomment-72351437
.

I'm not able to reproduce this bug. Every time I type "exit()" or "Ctrl-C", it saves everything that I unlocked during that session.

Closing this issue because I wasn't able to reproduce it, and I haven't seen it being an issue besides this one time. I suspect it was due to some exceptions not being handled properly, which might have been fixed since then.


Drop sourceType property from read

As read now inherits from Juttle source proc and program checks for
that, the sourceType property is not needed.
refs: https://github.com/juttle/juttle/pull/110

Rebased, will wait for green, then merge.


fixed add event link

Related Issue

Information about the related issue

Closes: #20
Describe the changes you've made
I changed redirect link so it redirects directly to "issue: Add event" now.

Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update.
[ ] This change requires a documentation update

How Has This Been Tested?

I clicked button and it works
Checklist

[ ] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented on my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original
Updated

original screenshot
updated screenshot

Code of Conduct

[x] I agree to follow this project's Code of Conduct

Cześć @Xoviec 👋🏻 ! The changes look good, thanks for your contribution!

Thanks, @Xoviec for the contribution. Welcome to the world of open Source.


Various fixes as per the review comments :)

Just checked some of the CI errors shown... 😉
It's not such a big deal (but at least, I avoid debugging Python code lol)

UPDATE:
OK, I decided to add some more fixes, based on the review comments (@ Pygments)... I hope I haven't messed up anything too much :)

Sorry, hadn't seen it before. 😢
But thank you a lot for this.
I had done the same things. I'm really sorry I missed it

I'll try to merge without break changes.
So your name'll appear at contributors list too.


[controller] Add resilience to pushjob when LEADER replica errors out

[controller] Add resilience to pushjob when LEADER replica errors out.
If during ingestion LEADER replicas transitions to error state in CV, currently the pushjob will fail without any type of resiliency. To overcome this single point of failure, instead of immediately marking the job failed, we disable the given replica, and let helix choose another replica which hopefully could finish the ingestion without any error. We will try to do this only if we have enough replica available.
The disable partitions are re-enabled by listening to live instance monitor. Whenever the error replica is restarted, the controller will listen to that event and enable the replica in helix.  This way server will try to reingest again.

@majisourav - Could you please add more details about the solution in the commit description? For example, who enables disabled partitions, do we persist a list of disabled partitions somewhere, and what happens to do disabled partitions when there is controller failure/leadership change, etc.

"The disable partitions are re-enabled by listening to live instance monitor. Whenever the error replica is restarted, the controller will listen to that event and enable the replica in helix. This way server will try to reingest again."
What will happen if we just re-enable a disabled replica without the server restarting? Will it go back to ERROR immediately or restart ST from OFFLINE->...?

"The disable partitions are re-enabled by listening to live instance monitor. Whenever the error replica is restarted, the controller will listen to that event and enable the replica in helix. This way server will try to reingest again."
What will happen if we just re-enable a disabled replica without the server restarting? Will it go back to ERROR immediately or restart ST from OFFLINE->...?

It will restart from ST from OFFLINE->STANDBY->LEADER. And there is a high chance that it will again become error if the ERROR is not due to transient issues.

@majisourav99  Changes look good. Should be mergeable. Can you plz resolve the conflicts and try the CI again?


adding support for keyword only args.

Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[ ] I have read the CONTRIBUTING doc
[ ] I used the commit message format described in CONTRIBUTING
[ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #13 (8eae00a) into main (aa3fea4) will decrease coverage by 1.13%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   98.31%   97.18%   -1.13%
==========================================
  Files           2        2
  Lines         297      320      +23
  Branches       86       95       +9
==========================================
+ Hits          292      311      +19
- Misses          2        3       +1
- Partials        3        6       +3

Impacted Files
Coverage Δ

.../braket/flake8_plugins/braket_checkstyle_plugin.py
97.16% <93.33%> (-1.14%)
:arrow_down:


source-build 3.0 Preview 7 versions out of sync?

When I build 3.0 from source-build, I get:

SDK version 3.0.100-preview7-012802
Runtime version 3.0.0-preview7-27902-19

The Microsoft releases have a slightly different version:

3.0 Preivew 7 release notes say that the SDK is version 3.0.100-preview7-012821
Microsoft.NETCore.App on nuget.org is version 3.0.0-preview7-27912-14

Is this version discrepancy expected?

This should be fixed with #1159, I've tagged the new build as https://github.com/dotnet/source-build/releases/tag/v3.0.100-preview7-012821-SDK.  Let me know if you see any more issues.

Thanks! I can confirm this solves the new issues I was seeing. In my tests, we are back to essentially the same set of issues seen in Preview 6 (eg, xunit broken, missing ASP.NET Core, missing sourcelink commit ids).

I couldn't find an issue for the XUnit problem, I opened https://github.com/dotnet/source-build/issues/1161 for that.  I've started working on the sourcelink fixes, so hopefully I'll have a PR for that soon.


Calculates messages size field

This change is

Codecov Report
Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (6cb1e26) 71.36% compared to head (b6518af) 71.12%.

Files
Patch %
Lines

crates/blockifier/src/fee/gas_usage.rs
0.00%
16 Missing :warning:

...lockifier/src/transaction/transaction_execution.rs
0.00%
6 Missing :warning:

...ates/native_blockifier/src/transaction_executor.rs
0.00%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1290      +/-   ##
==========================================
- Coverage   71.36%   71.12%   -0.24%
==========================================
  Files          59       59
  Lines        7225     7249      +24
  Branches     7225     7249      +24
==========================================
  Hits         5156     5156
- Misses       1657     1681      +24
  Partials      412      412

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


sys/linux: add brk syscall

Does it not cause too many syz-executor child crashes?

It should just allocate memory. Why would it cause crashes?
But either way there are much simpler ways to crash, e.g. call exit_group.


hi，need help

hello,
I want to know how / why  the device.getPartitions() is empty ?
When I  execute device.getPartitions().get(0).getFileSystem();
There is a exception:
java.util.ArrayList.throwIndexOutOfBoundsException(ArrayList.java:255)
It means partitions are empty.
What's the situation happened?
And  the Usb equipment is MS-DOS (FAT16) ，is That wrong？

Hey there,
please refer to this answer: https://github.com/magnusja/libaums/issues/72#issuecomment-296774149


Support condition as a function

Closes #1.
I just used is-fn to make the function act accordingly. If it looks good, I'll do the docs!

All right, I think I got it. I kept the old tests for a regular function but I can remove those if needed. cond now works if it's a function that returns a Promise.

I kept the old tests for a regular function but I can remove those if needed.

Keep 'em.

Readme needs to be updated.

🐔

There are still some unresolved inline feedback.

Moved over the logic to its own function, but couldn't think of a good name for it. Let me know if I missed anything else 😎

Looks great now. Thank you @sotojuan 🤘😎


Temporary fix for broken bundles

The current bundles were throwing "Stream is not a function".
The proper place to fix this would probably be in the bundler, but for now this circumvents the issue.
It appears the instantiated "Stream" will be cached and used inside the requestService that also requires './util/stream',  instead of just what's inside './util/stream'.

Thanks

You're welcome and thank you too ;)


Does oracle support it?

Oracle DB support is planned as part of our coming paid offering, see this post for details: https://github.com/launchbadge/sqlx/discussions/909


Publish Zowe v1.14 doc

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[x] If the changes in this PR is part of the next future release, make this pull request against the docs-staging branch which will be published at the next release boundary. If the changes in this PR are part of the current release, use the default base branch, master. For more information about branches, see https://github.com/zowe/docs-site/tree/master#understanding-the-doc-branches.

[x] If this PR relates to GitHub issues in docs-site or other repositories, please list in Description, prefixed with close, fix or resolve keywords.

Description (including links to related git issues)

[x] 1.14.x LTS site configuration

[x] Bump release version in docs-staging branch
[x] Archive the master branch to be v1.13.x [Instructions]
[x] Update Algolia search [Instructions]

[x] Release Notes set up
[ ] TPSRs [Instructions]
[ ] BoM update (manual)
[x] Archive PDF

:heart:Thank you!

Broken link in this branch -

http://zowe-docs-test-links/stable/getting-started/summaryofchanges.html https://docs.zowe.org/stable/user-guide/scripted-configure-server.html "75" "404 Not Found" "-"


CB-14880 Introduce the StackDto and the re-designed view of entities.

In the first part of the refactor, I have introduced some temporary solution to reduce the commit size, like the Delegate and the views as interface of the entity
Refactored  parts:

We don't fetch the terminated instances
we don't fetch the salt components
the references of the object will fetch neither lazy nor eager -> we hold these references in the DTO
in case of high number of events, the event bus could be timed out -> now, we send all of the allocated resources instead of one by one

@topolyai5
It seems a bit late, but I have concerns about this PR:

This is a huge PR, and only Denes approved it. I think it's so huge that all teams should have approved it.
It contains a lot of unrelated refactors, why? They should be in a separate PR.
StackDtoService contains the main part of the logic behind the change, and yet it has no unit tests at all.
There are a lot of force pushes after the approve, which apparently no one has checked.

@topolyai5 It seems a bit late, but I have concerns about this PR:

This is a huge PR, and only Denes approved it. I think it's so huge that all teams should have approved it.
It contains a lot of unrelated refactors, why? They should be in a separate PR.
StackDtoService contains the main part of the logic behind the change, and yet it has no unit tests at all.
There are a lot of force pushes after the approve, which apparently no one has checked.

Hi

It contains a lot of unrelated refactors, why? They should be in a separate PR.
We talked with Attila and the POC presentation, eighter to duplicate a lot of code, but it can merge in a separate PR or change the unreleated part of code and merge in a huge PR. We decided the second one because the copy and the original code can be mutated from each other and after the deletion maybe I delete a good code and hold the older one

StackDtoService contains the main part of the logic behind the change, and yet it has no unit tests at all.
you are right, I will cover the class

There are a lot of force pushes after the approve, which apparently no one has checked.
yeah, mainly CS fixes, test fixes, spotbugs fixes and rebases on master.

This is a huge PR, and only Denes approved it. I think it's so huge that all teams should have approved it.
this Pr wasn't hidden or merged on the fast track way. I have added the raven team as well to review it. I cannot write random ppl to would like to review it?
I have scheduled the merging for our branch guardians' time.
However, if you want, you can review it, and I will check it and I will change the code if the review is reasonable.

We talked with Attila and on the POC presentation, eighter to duplicate a lot of code, but it can merge in a separate PR or change the unreleated part of code and merge in a huge PR. We decided the second one because the copy and the original code can be mutated from each other and after the deletion maybe I delete a good code and hold the older one

Regarding unrelated reactors, I meant those that are not related to the Dto changes. Just to be clear, I am not against these refactors, they are just not related to this ticket and its big enough without these already.
For example: static imports of Collections.toMap in one random class. Extracting methods, etc.

this Pr wasn't hidden or merged on the fast track way. I have added the raven team as well to review it. I cannot write random ppl to would like to review it?
I have added this message here, and anybody could review who wants to review it

I am pretty sure the tests on this PR were red for a long time and the message sent through the wolf's channel may not necessarily reach the whole team.


⚠ Bofrost.at has degraded performance

In acfebbf, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1487 ms

Resolved: Bofrost.at performance has improved in 948a632.


Add troubleshooting note for Poetry errors on OSX install

poetry errors on OSX, added troubleshooting note on how to bypass the error on installation.
 The Poetry configuration is invalid:
    - Additional properties are not allowed ('group' was unexpected)
    -
  at ~/.poetry/lib/poetry/_vendor/py3.9/poetry/core/factory.py:43 in create_poetry
       39│             message = ""
       40│             for error in check_result["errors"]:
       41│                 message += "  - {}\n".format(error)
       42│
    →  43│             raise RuntimeError("The Poetry configuration is invalid:\n" + message)
       44│
       45│         # Load package
       46│         name = local_config["name"]
       47│         version = local_config["version"]

Codecov Report

Merging #1641 (9da1b85) into main (efafd00) will decrease coverage by 0.15%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
- Coverage   46.21%   46.07%   -0.15%
==========================================
  Files          47       47
  Lines        6913     6913
==========================================
- Hits         3195     3185      -10
- Misses       3718     3728      +10

see 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

on which poerty version are you one?

Do you get this error with the latest poetry version on macOS?

i realized something in my shell was pointing at Poetry version 1.1.12 intead of 1.4. Poetry 1.4 runs fine without errors.
Not sure why the path wasn't getting picked up, probably due to this issue below?
('Configuration file exists at /Users/bitcarrot/Library/Application Support/pypoetry, reusing this directory.\n\nConsider moving TOML configuration files to /Users/bitcarrot/Library/Preferences/pypoetry, as support for the legacy directory will be removed in an upcoming release.',)

yes this was the exact issue you where using poetry ^1.1 which is incompatible, i think this one can be closed?

yes this was the exact issue you where using poetry ^1.1 which is incompatible, i think this one can be closed?

Should we make a note in troubleshooting that poetry 1.4 or higher is required ?

Mininum poetry version has is ^1.2, but it is recommended to use latest poetry

OK


This pull request is ready to merge

Merged to master. Thank you.


Use master branch for release versions with automatic tagging

Currently, we merge everything into devel with an auto tagging script running after every merged PR. This means that whenever we merge a PR into devel, a new tag is created, deployed to PyPI, etc. However, even code merged into devel is constantly being updated in such ways which break the backwards compatibility. The tagging system is useful for everyone using the library, but in this current form it actually does not work. The quickly iterated on changes break backwards compatibility constantly. That means that we either will bump the major version number after every other PR or so (we would have a major version number around 150 or so now, if applied this approach), or, as it is currently, we ignore the semver semantics of the tagging system, and even minor version number introduces compatibility-breaking changes which makes the versions basically meaningless.
I think that Mata is now in a state where we should have a proper devel-master hierarchy of branches. The devel will function as it has so far, with the only change being that the auto tagging script will be redirected to master. We will merge PRs into devel one by one as they come, and devel may introduce breaking changes whenever necessary. master, on the other hand, will be updated only once in a while, manually, by creating a PR from devel to master, with automatic tagging with proper versioning. master will serve as the release branch for Mata, which was currently inadvertently served by devel.
This way, one can:

Propagate important bug fixes into master with patch version number bumps.
Introduce new interface options (types, methods, classes, functions) with minor version number bumps.
Bring compatibility-breaking changes with major version number bumps, whenever a larger portion of the changes which break compatibility is introduced or as needed, but in a single major version number bump. In our case, that would usually be a version bump for each paper on Mata, or a new Noodler version and similar.

Then, projects depending on Mata (Noodler, student works, other researcher's projects, …) can rely on Mata being well-versioned without having to worry about compatibility changes between minor version changes.
This will be immediately useful to everyone, will allow others to actually depend on Mata, and will make it easier to iterate on new features and improvements in isolation on devel without having to worry about breaking anyone's code and projects.

@kilohsakul @vhavlena @jurajsic @ondrik What do you think about this proposition?

I agree to have a stable master.

Sounds like a good idea, I agree.

Well, I have mixed feelings. On the one side the current versioning system is a bit funny, making it more meaningful is a good choice. One the other hand it sounds a bit like it introduces another level of a mess.

What kind of mess are you thinking about? Everything would be automatic, so the only thing necessary to do manually would be to create a PR from the latest changes on devel from time to time, or when needed (to fix a bug in "production", for example). In case of Noodler, I think we would still keep depending on devel (specific commit), and only really used fixed versions for Noodler when submitting a paper or sending Noodler on a competition ("in this paper, we used Noodler version x.y.z with Mata version xm.ym.zm").

An alternative approach, since this is a research project whose versions are considered in “generations”, we can adapt a widely-used modification as generation.major.minor (adding generation version number and dropping minor version number, as suggested in a SemVer repo issue). This approach corresponds to SemVer (major.minor.patch) as follows:

generation is a new version number incremented only when we subjectively decide to release a new iteration of Mata, as in, we publish a new article about Mata, contest in a competition, etc. Or when we substantially rework the main ideas of the project to warrant a new generation (or iteration) to be created.
major corresponds to SemVer major, only shifted by one to the right.
minor corresponds to SemVer minor, only shifted by one to the right.
patch is dropped in favour of generation.

The arguments for and against generation.major.minor are numerous. generation.major.minor is not an ideal solution, as this means that all tools working with SemVer will not work with Mata (will introduce breaking changes to the users of Mata when they try to update Mata). However, generation.major.minor is essentially exactly what we have been doing all this time. The only difference now would be that we would explicitly state that we use generation.major.minor (and anyone doing the actual merging would have to be conscious of this fact).
The way to mitigate the issues with generation.major.minor is to add a section to the project's README.md notifying the user (a student or a researcher) that they should handle releases of Mata in this non-SemVer approach.


Created and updated docs for 1.27-7

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


Terraform Immersion

💡 Description
@tloubrieu-jpl recommends that @ramesh-maddegoda and @sjoshi-jpl help @nutjob4life immerse himself into the world of Terraform.
This ticket is to track scheduling, progress, and metrics for immersion success—shallow, deep, thoroughly soaked, etc.
⚔ Parent Epic / Related Tickets
No response

Hi @ramesh-maddegoda and @sjoshi-jpl, I've created a straw poll to help figure out a time when we can meet and do this "immersion". Please respond when you can.

Meeting tomorrow to introduce Sean to terraform used in PDS ENG.

@ramesh-maddegoda @sjoshi-jpl see https://jpl.enterprise.slack.com/archives/GCGR1R3A4/p1712170107344829

meeting is rescheduled this Monday.

Successful meeting with @ramesh-maddegoda and @sjoshi-jpl with a number of takeaways:

Structure of Terraform into a top-level main.tf and subdirectories for specific "environments"

For example, mwaa-env is the "Managed Airflow" environment
You can re-use environments by repeating the source but substituting different variables

terraform.tfvars could contain secrets so it's best kept locally or in "private" GitHub repositories
Data blocks are generally for things "outside" Terraform, such as an IAM document already deployed in AWS

Or for resources that were previously managed by Terraform

depends_on = […] handles dependencies during orchestration
The .tfstate file tracks the "state of everything"

Locally this makes perfect sense
In the cloud, you'll want .tfstate in a backed storage like S3

Some sample commands

terraform fmt rewrites your Terraform files into a canonical style
terraform validate checks the files
terraform plan -var-file=./tfvars/def.tfvars -lock=false … shows the "plan of attack"
terraform apply -var-file=./tfvars/def.tfvars -lock=false … "attack!"

Note that depending on your vars, the same command works locally or all the way into the cloud

terraform destory -auto-approve … "retreat!" (brings it all down)

Best practices: https://www.terraform-best-practices.com/key-concepts

This good for now.


Including _version in delete requests, unable to filter _deleted items from list response.

Which Category is your question related to?
Using AWS Amplify API to delete items through AWS Appsync
Amplify CLI Version
4.18.1
What AWS Services are you utilizing?
AWS Appsync, DynamoDB
Provide additional details e.g. code snippets
While using API.graphql to delete items from my database I have 2 following issue:
Issue # 1:
Here is my request to delete a photo from the frontend:
API.graphql(graphqlOperation(mutations.deletePhoto, {
      input: {
        id: photoId,
        _version: 1,
      }
    })) as unknown as {
      data: DeletePhotoMutation
    }

Currently, there's no way for me delete an item without including the _version of the item without running into an error:
errorType: "ConflictUnhandled"
message: "Conflict resolver rejects mutation."

Is this intended? Or am I missing something.
Issue # 2 :
When I successfully deleted the item using the API by adding in the _version attributes, I verified that the deleted attributes in DynamoDB is false,

When I list all the items again, I couldn't find a way to filter out deleted items from server side. The generated types for the filter is like so:
export type ModelPhotoFilterInput = {
  id?: ModelIDInput | null,
  albumId?: ModelIDInput | null,
  bucket?: ModelStringInput | null,
  and?: Array< ModelPhotoFilterInput | null > | null,
  or?: Array< ModelPhotoFilterInput | null > | null,
  not?: ModelPhotoFilterInput | null,
};

So now I have to fetch all items from serverside and filter deleted items out on the front end like so
const listPhotosByAlbum = async (input: ListPhotosByAlbumQueryVariables): Promise<any> => {
  const response = await API.graphql(graphqlOperation(queries.listPhotosByAlbum, input)) as unknown as {
    data: ListPhotosByAlbumQuery
  };
  return response.data.listPhotosByAlbum.items.filter(item => item._deleted !== true);
};

which isn't ideal considering the number of deleted items can grow indefinitely and slow down the response.
Appreciate if anyone can share their experience.

Same issue, shouldn't Appsync Resolvers filter out _deleted=true ?

Which Category is your question related to?
Using AWS Amplify API to delete items through AWS Appsync
Amplify CLI Version
4.18.1
What AWS Services are you utilizing?
AWS Appsync, DynamoDB
Provide additional details e.g. code snippets
While using API.graphql to delete items from my database I have 2 following issue:
Issue # 1:
Here is my request to delete a photo from the frontend:
API.graphql(graphqlOperation(mutations.deletePhoto, {
      input: {
        id: photoId,
        _version: 1,
      }
    })) as unknown as {
      data: DeletePhotoMutation
    }

Currently, there's no way for me delete an item without including the _version of the item without running into an error:
errorType: "ConflictUnhandled"
message: "Conflict resolver rejects mutation."

Is this intended? Or am I missing something.
Issue # 2 :
When I successfully deleted the item using the API by adding in the _version attributes, I verified that the deleted attributes in DynamoDB is false,

When I list all the items again, I couldn't find a way to filter out deleted items from server side. The generated types for the filter is like so:
export type ModelPhotoFilterInput = {
  id?: ModelIDInput | null,
  albumId?: ModelIDInput | null,
  bucket?: ModelStringInput | null,
  and?: Array< ModelPhotoFilterInput | null > | null,
  or?: Array< ModelPhotoFilterInput | null > | null,
  not?: ModelPhotoFilterInput | null,
};

So now I have to fetch all items from serverside and filter deleted items out on the front end like so
const listPhotosByAlbum = async (input: ListPhotosByAlbumQueryVariables): Promise<any> => {
  const response = await API.graphql(graphqlOperation(queries.listPhotosByAlbum, input)) as unknown as {
    data: ListPhotosByAlbumQuery
  };
  return response.data.listPhotosByAlbum.items.filter(item => item._deleted !== true);
};

which isn't ideal considering the number of deleted items can grow indefinitely and slow down the response.
Appreciate if anyone can share their experience.

@drixta it looks like you setup a sync enabled endpoint but are calling it using the API category instead of DataStore. Did you intend to do this? That's why the version is required. If you didn't intend to do this I'd recommend just creating an app and using amplify add api through the standard flow.

@drixta I am closing this issue, do not hesitate to re-open if you have any further questions.

@drixta it looks like you setup a sync enabled endpoint but are calling it using the API category instead of DataStore. Did you intend to do this? That's why the version is required. If you didn't intend to do this I'd recommend just creating an app and using amplify add api through the standard flow.

@ammarkarachi What's the difference between a sync enabled endpoint and a regular endpoint was I'm unaware about this? I did create the endpoint using amplify add api so I'm curious what caused the difference.
Is it the Configure conflict detection portion during the setup? If so what option is for the regular endpoint, which one Is for the sync endpoint

@drixta it looks like you setup a sync enabled endpoint but are calling it using the API category instead of DataStore. Did you intend to do this? That's why the version is required. If you didn't intend to do this I'd recommend just creating an app and using amplify add api through the standard flow.

@ammarkarachi What's the difference between a sync enabled endpoint and a regular endpoint was I'm unaware about this? I did create the endpoint using amplify add api so I'm curious what caused the difference.
Is it the Configure conflict detection portion during the setup? If so what option is for the regular endpoint, which one Is for the sync endpoint

Yes correct conflict resolution is enabling sync. I'd suggest running amplify update api and turning off.

@drixta it looks like you setup a sync enabled endpoint but are calling it using the API category instead of DataStore. Did you intend to do this? That's why the version is required. If you didn't intend to do this I'd recommend just creating an app and using amplify add api through the standard flow.

@ammarkarachi What's the difference between a sync enabled endpoint and a regular endpoint was I'm unaware about this? I did create the endpoint using amplify add api so I'm curious what caused the difference.
Is it the Configure conflict detection portion during the setup? If so what option is for the regular endpoint, which one Is for the sync endpoint

Yes correct conflict resolution is enabling sync. I'd suggest running amplify update api and turning off.

Which Configure conflict detection  should be used?

@drixta it looks like you setup a sync enabled endpoint but are calling it using the API category instead of DataStore. Did you intend to do this? That's why the version is required. If you didn't intend to do this I'd recommend just creating an app and using amplify add api through the standard flow.

@ammarkarachi What's the difference between a sync enabled endpoint and a regular endpoint was I'm unaware about this? I did create the endpoint using amplify add api so I'm curious what caused the difference.
Is it the Configure conflict detection portion during the setup? If so what option is for the regular endpoint, which one Is for the sync endpoint

Yes correct conflict resolution is enabling sync. I'd suggest running amplify update api and turning off.

Which Configure conflict detection should be used?

I have exactly the same question.  Which option should we select if we want to disable this.
(Although Ideally I'd much rather be able to filter on _deleted as mentioned in in this issue https://github.com/aws-amplify/amplify-cli/issues/4230#issue-616194162 )

@LawrenceNorman @Mentioum are you using the API Category in your app client code? As mentioned above the reason the items which are marked for deletion are coming through is because you have syncing enabled on your endpoint which is not designed to work with the API category but rather the DataStore category. When you're using DataStore it uses this metadata to remove the items from the local storage medium, so no extra filtering is needed there. The API category from your client code isn't designed for synching which is why you shouldn't enable it if you're trying to interface with your GraphQL endpoint directly.

Thanks @undefobj that makes sense as to why it's not working.  That being said... I'm using both...
I'm using the datastore from my mobile PWA and the CLI from ReTool for my administration views.  What would you recommend in this scenario?

If you're using both, then you're going to have to independently track versions in your app state (sending the current version when you perform update mutations with API directly) and handling deletion filtering locally. Using both categories together isn't something we fully support OOTB today. It's on the roadmap, but to be transparent it's a bit away.

@undefobj ok no problem, that's what I ended up doing anyway ( I actually quite like sending the version with updates, it was only the _deleted field which annoyed me, since I wanted to add it to an index so I could filter it out... ).
Looking forward to seeing how far I and my team can push Amplify, some frustrations so far, with getting up to speed so quickly definitely outweighs the frustrations for now 👍 .

@LawrenceNorman @Mentioum are you using the API Category in your app client code? As mentioned above the reason the items which are marked for deletion are coming through is because you have syncing enabled on your endpoint which is not designed to work with the API category but rather the DataStore category. When you're using DataStore it uses this metadata to remove the items from the local storage medium, so no extra filtering is needed there. The API category from your client code isn't designed for synching which is why you shouldn't enable it if you're trying to interface with your GraphQL endpoint directly.

Could you please indicate how to disable the sync if it was enabled accidentally at the beginning?

Good to know that having both DataStore and GraphQL API going together might cause issues if you're not careful.  @ivenxu I kept running into issues with deletion and after reading https://github.com/aws-amplify/amplify-cli/issues/2384
I figured out I had to resort to:
amplify api remove
followed by
amplify add api
and then I just put my graphql db on an api key and opted to not configure conflict detection, and now my graphql mutations seem to be working well.

I actually ran into this on accident.  I added extra auth on a API so a Lambda could also make edits to AppSync/GraphQL and it asked me what I wanted to do about conflict resolution.  I picked 'AutoMerge' and ran into the same behavior.  I started to edit my schemas to include _deleted, _version but I thought I'd have the exact same issue having to filter off these records.  Thanks for mentioning the conflict detection, the only way I figured out I could change data was by passing the _version and I didn't want to get into this.  I will also attempt to remove this but I start to quiver every time I execute amplify update api :)

I actually ran into this on accident.  I added extra auth on a API so a Lambda could also make edits to AppSync/GraphQL and it asked me what I wanted to do about conflict resolution.  I picked 'AutoMerge' and ran into the same behavior.  I started to edit my schemas to include _deleted, _version but I thought I'd have the exact same issue having to filter off these records.  Thanks for mentioning the conflict detection, the only way I figured out I could change data was by passing the _version and I didn't want to get into this.  I will also attempt to remove this but I start to quiver every time I execute amplify update api :)

Hi,
I am having an issue I think it related to this thread. When I use the Amplify Admin UI to edit "Content" it requires the Datastore feature to be enabled, but this seems to result in items being marked as "deleted" with no way to easily filter them in a GraphQL query. I'm building a simple Nuxt web app and just used the amplify add api and created a Todo table through the CLI. Everything seems to work just fine except this deleted items issue.
-m

Hi,
I am having an issue I think it related to this thread. When I use the Amplify Admin UI to edit "Content" it requires the Datastore feature to be enabled, but this seems to result in items being marked as "deleted" with no way to easily filter them in a GraphQL query. I'm building a simple Nuxt web app and just used the amplify add api and created a Todo table through the CLI. Everything seems to work just fine except this deleted items issue.
-m

@micahwalter hi, I am doing exactly the same with Nuxt and I think I enabled Datastore when I turned on the Admin UI management feature. Did you end up filtering the results in javascript after the GraphQL query? C_

Hi,
I am having an issue I think it related to this thread. When I use the Amplify Admin UI to edit "Content" it requires the Datastore feature to be enabled, but this seems to result in items being marked as "deleted" with no way to easily filter them in a GraphQL query. I'm building a simple Nuxt web app and just used the amplify add api and created a Todo table through the CLI. Everything seems to work just fine except this deleted items issue.
-m

I have encountered the same issue. It seems that if you want to be able to use the Amplify Admin UI then datastored is enabled and removing it breaks the admin UI, but then it makes graphQL API unusable


Process to generate the JSON annotation files

Hi, HybrIK is indeed an awesome and elegant work. I really like it! Congratulations!
But, there's something I'm curious about, which is the process to generate JSON annotation files from the original datasets.
I would surely appreciate it if you would share some hints about the procedure.
Thanks again.

Hi, may this issue can help you. #5
I provide the code that used to generate the JSON files in Baidu Drive (code k77z) along with the original annotations. If Baidu Drive is not available to you, I could upload it to Google Drive.

I really appreciate this! The question has been solved.


Update parser and builder to latest spec

packageurl-go needs to be updated to the latest purl spec.

Fixed in #3


[libdwarf] Recover deleted historical versions

When updating the port, the historical version was deleted, making it impossible to download the historical version. This PR will restore the historical version.

[X] Changes comply with the maintainer guide.
[ ] SHA512s are updated for each updated download.
[ ] The "supports" clause reflects platforms that may be fixed by this new version.
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[ ] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[ ] Only one version is added to each modified port's versions file.

Usage test pass with following triplets:
x86-windows
x64-windows
x64-windows-static

Thanks!

oof!


Add error handling example to README

e.g.
import { getError, subscribeError } from "evolu"

useEffect(() => {
  const notifyOnError = () => {
    console.error(getError())
  }

  return subscribeError(notifyOnError)
}, [])

I see; I thought it was there 😅 Can you please send a PR? Both to apps/web and examples/nextjs (because those examples should be identical).


Ignored words are still detected in markdown code-block

Hi!
I noticed that words that are on my ignore-list are still detected when they are inside a markdown-codeblock:
My config:
- name: Perform spell check
  uses: codespell-project/actions-codespell@master
  with:
    path: '**/*.md'
    check_filenames: true
    ignore_words_list: tekst,Widgits

Leads to:
Error: docs/simplesamlphp-googleapps.md:41: Widgits ==> Widgets
See file: https://github.com/simplesamlphp/simplesamlphp/commit/73563071059752319c6da1f7c2e4b1a6fcad444c#annotation_14814240076

HI @tvdijen. The codespell dictionary entries are all lowercase. Even though the misspelling check is case insensitive when it comes to the text being checked, the entries in the ignore_words_list input must match the case of the dictionary entries exactly. So you must always use lowercase in the ignore_words_list input.
So try again after changing the input to this:
ignore_words_list: tekst,widgits

Ah thank you very much @per1234 , that has indeed solved the issue!
I must say that the docs are not immediately clear to me.. Maybe because I'm not native English, or because "[..] based on how they are written in the dictionary file" doesn't immediately mean something to me as an end-user.. I never see dictionary files when using this action.
Thanks very much, and I hope my feedback can help you to make this action even better!


would you like to take a screenshot

would you like to take a screenshot or have a demo url ready?

A screenshot is an excellent idea. Regarding a demo: That will be hard to do for a command line generator :)

Done!


Expand PublishTransaction into a reliable transaction [re]broadcast sub-system

Issue
Currently, we use the PublishTransaction method of the WalletController interface to broadcast transactions. Relevant transactions that are to be broadcast include: funding transaction, commitment transactions during a force close, transactions sweeping time locked outputs within the utxoNursery, and justice transactions created by the breachArbiter.
The current default implementation of the WalletController, BtcWallet, will attempt to re-broadcast any transactions which haven't been confirmed since the last restart. However, this only applies to transactions that directly spend inputs under its control. This means that any transactions that are channel related (other than the funding transaction) won't be re-broadcast. This is an issue as there are many occasions where we depend on a reliable transaction confirmation in order to dispatch critical services such as sweeping an HTLC that has had its time lock expire.
In order to address these issues, a new sub-system for reliable transaction broadcast should be created.
Steps to Completion

[ ] Within the daemon, create a new sub-system for reliable transaction broadcast. Extra points for creativity for the name of this new sub-system. This sub-system would only be used within the daemon, meaning that the reservation workflow within lnwallet would still use the PublishTransaction method as normal. All other instances within the lnd package currently use PublishTransaction should be modified to instead interact with this sub-system .

[ ] The sub-system itself should be exposed to the rest of lnd has a simple interface with a single method. It should accept identical arguments to that of PublishTransaction. The implementation of the sub-system should be split into two components:

A TransactionBroadaster an abstract interface that's able to submit transactions to the network somehow.
The concrete implementation of this new interface should take the TransactionBroadcaster as its parameter. This will allow us to have a single instance of the core logic, but be able to plug in different back end instances (neutrino, btcd, bitcoind, etc).

The core logic of this sub-system would be to implement reliable transaction broadcast. Before returning to the sender, it should write to disk, the transaction itself before broadcasting the transaction to the network using the TransactionBroadcast. This sub-system should also take an instance of the ChainNotifier and use it to register for confirmation notifications. Once it has received a confirmation notification, it can delete the transaction entry from the database.

[ ] The transaction broadcast method of this new sub-system should also have a concrete set of errors that are returned along with it. This set of errors will allow the other sub-systems within lnd to detect instances of duplicate transaction broadcast, double spends, etc. Atm we attempt to do this on a case-by-case basis by examining the string of the error returned. However, this currently only applied to errors returned by the btcd backend, and not neutrino, etc. Once these errors are in place, a sweep should be performed to find instances of such error checks like this one, moving them over to checking the new concrete errors.

I'll take this one 👍

In the current default context, this has been fixed by: https://github.com/Roasbeef/btcwallet/pull/16 and https://github.com/lightningnetwork/lnd/pull/594. We may revisit this later once additional pure wallet backends are added.


API Testing for the Story endpoint

I will do the API Testing for the Story endpoint

@gauravdas014 please assign this issue

@gauravdas014   before testing i logged in with an existing user in the database
but still sending a GET request to /api/story/all shows unauthorized
what should I do??


edit button

Edit button not show.
i set editButtonVisible to true , noting show , i tried exemple but still no edit button

Did you resolve this?

@lukebrandonfarrell , no I didn't .
It was not really important feature for me.
You can open a new  issue, or edit the source code, it's pretty easy to understand and restyle.

@antoinefotso What was the issue? Could you give us more details?
@jasimawan Just added this feature so strange that it is broke. Possibly usage is not clear? Have you enabled isEditButtonVisible to true?

I just checked it and isEditButtonVissible is working as expected. Maybe he is doing something wrong.
@lukebrandonfarrell


User Experience Improvement by implementing smooth scrolling using Lenis

Hello,
I would like to propose adding the Lenis library to the EzyShop project to enhance the scrolling experience across all pages. Smooth scrolling can significantly improve user experience by providing a more fluid transition between sections of the website.
Proposed Changes

Integrate Lenis: Add the Lenis library to the project, preferably via CDN for ease of use.

Implementation: Implement smooth scrolling functionality throughout the website.

Performance Testing: Ensure that the integration does not adversely affect load times or performance metrics.

Benefits

Enhanced User Experience: A smoother scrolling experience can make navigation more enjoyable and engaging for users.

Modern Aesthetics: Smooth scrolling is a contemporary design trend that can elevate the overall look and feel of the site.

Mobile Optimization: Lenis is designed to work well on mobile devices, ensuring a consistent experience across platforms.

I know its not that important. I am currently into UI/UX and just started contributing. let me know if i can contribute to better issues.

@MuraliKarthikS As of now, we do not need it. We will let you know in the future if there is a need. Please search for another issue and raise it, which I'm happy to assign to you.


invalid interpolation: field not allowed: interval:

While evaluating the default config with cue 0.4.3 the following error is reported.
´´´
netmeta.dashboards._dashboards.dashboards.Home.panels.0:
https://github.com/monogon-dev/NetMeta/blob/a8dac36695b989da2e3ce8bb835cf4978f6125a8/deploy/dashboards/base.cue#L178

Fixed by updating CUE


Expose a counterpart of Uri.toJSON

Serializing objects with Uris is a bit tricky today, because the Uri class has a toJSON method on it which changes the serialization behavior of JSON.stringify even if you are using the replacer feature (since the toJSON method will be called before the value is passed to the replacer). So it would be nice to expose a counterpart of Uri.toJSON, say Uri.fromJSON or something like that to make using JSON.parse with a reviver easier to handle.
/cc @jrieken

So it would be nice to expose a counterpart of Uri.toJSON, say Uri.fromJSON or something like that to make using JSON.parse with a reviver easier to handle.

In any case you need some kind of marker on the serialised object which tells you how to inflate it, right? That's why we have the $mid property or is your data structure static that you know at which property to expect a URI?

Yeah, I look for known properties that are Uris

I added the following to vscode.d.ts
/**
 * Create an URI from its component parts
 *
 * @see {@link Uri.toString}
 * @param components The component parts of an Uri.
 * @return A new Uri instance.
 */
static from(components: { scheme: string; authority?: string; path?: string; query?: string; fragment?: string }): Uri;

Just noticed that we don't validate URI created like that: https://github.com/microsoft/vscode/blob/e1f0f8f51390dea5df9096718fb6b647ed5a9534/src/vs/base/common/uri.ts#L166
I believe we do that to make parsing faster but in this case we should add the check again


斑马网络 https://www.hellobanma.com/

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

Thanks for sharing the case. Could you send the pull request to https://github.com/apache/incubator-skywalking/blob/6.0/docs/powered-by.md ?

Relate to #443


Add sampling logger

Added KLogger.sample which uses a RateLimitingSampler. Moved around some existing classes to prevent circular dependencies. The RateLimitingSampler uses misk.RateLimiter and not Guava's to test and for consistency.
It would be better to create a SamplingLogger that inherits from KLogger but this is a phase 1 approach.

I'm worried this interface will be confusing to use. The Sampler must be a global, but since this requires you to pass the sampler into the log call, it makes it tempting to instantiate the sampler in the call, like logger.info(RateLimitSampler(...)) { "hello"}, which wouldn't work. How can we prevent improper usage of this? Or make it obvious how to use it correctly?
If we went directly to phase 2, where we have a sampled logger, it becomes simpler.
companion object {
  sampledLogger = logger.sampled(RateLimitSampler(...))
}

and then you use the sampled logger.

Yeah, in the long run, I don't think we would have a use for this current interface of passing in a Sampler(). We can merge this, but we should do the work of creating a rate limiting logger

Yeah, in the long run, I don't think we would have a use for this current interface of passing in a Sampler(). We can merge this, but we should do the work of creating a rate limiting logger

Yeah I agree. I implemented this as a first pass per the design doc. I can follow this up with a SamplingLogger that can take in PercentSampler, AlwaysSampler, or RateLimitingSampler


Issue getting id_token from url

It seems that when call the signinRedirectCallback my url is not being parsed correctly into a valid object.
My url is as follows: http://localhost:3000/#/id_token=.....
Therefore when the SigninResponse metho parses my url using the following line of code:
	var SigninResponse = function () {
	    function SigninResponse(url) {
	        _classCallCheck(this, SigninResponse);

	        var values = _UrlUtility2.default.parseUrlFragment(url, "#");

	        this.error = values.error;
	        this.error_description = values.error_description;
	        this.error_uri = values.error_uri;

it only removes the '#' and leaves the '/' resulting in the values variable having a /id_token property rather than an id_token property and then it throws an error because it can't find the id_token.
Any help?

What does your redirect_uri look like in config?

http://localhost:3000/

Is that a SPA page? If it's angular, then i have a feeling it's adding the "/" after the #.

yeah I am running angular 1.x

i'd recommend not having the redirect uri back into the middle of angular routing. use a separate plain/simple page then once it's successful then redirect back int your NG app.

I will give it a go. Thanks!

Are there any other options in case we can't go that route?

you can parse the url yourself and pass it in as a param to the signinRedirectCallback  API

Ok thanks for your help I will give that a try!

@jaredmahan you can try running your angular application in html5 mode (https://docs.angularjs.org/guide/$location) In that case the # is no longer used in your routes.
As far as I know only 1 # is allowed in your uri.


TextDocument.setText

There is a TextDocument.getText() method but there isn't a TextDocument.setText() method. The reason I (think) need this is for my final-newline extension. It adds a final newline when the page is saved. But if the user presses Save All from the menus, it doesn't work because it only performs the action on the current active text editor document.
I listen to the onDidSaveTextDocument, which calls a listener with the TextDocument as parameter. From there on I can get the text, save the document, etc. but I cannot manipulate the document. Is this something that should be done differently?

You can only edit a TextDocument with an editor and its edit-method. Today there is no onWillSaveTextDocument event, so you could use the visibleTextEditors or onDidChangeActiveTextEditor

editorconfig already has this implemented (insert final new line)

I know, I'm core contributor of the EditorConfig plugin but my plugin was created when extensions were still closed beta. And it seems that still some people prefer to not have a config file for this feature.


tf.train.Saver does not restore input queue

example.py
import tensorflow as tf

queue = tf.train.string_input_producer(['data.txt'])

reader = tf.TextLineReader()
_, line = reader.read(queue)

global_step = tf.Variable(0, trainable=False, name='global_step')
global_step_op = tf.assign_add(global_step, 1)

with tf.Session() as sess:
    saver = tf.train.Saver()
    coord = tf.train.Coordinator()
    threads = tf.train.start_queue_runners(coord=coord)

    latest_checkpoint = tf.train.latest_checkpoint('/tmp')
    if latest_checkpoint:
        saver.restore(sess, latest_checkpoint)
        print('restored from', latest_checkpoint)
    else:
        sess.run([
            tf.local_variables_initializer(),
            tf.global_variables_initializer(),
        ])

    for i in range(5):
        value, step = sess.run([line, global_step_op])

        print(value, step)

    coord.request_stop()
    coord.join(threads)

    saver.save(sess, '/tmp/model')

data.txt
line 1
line 2
line 3
line 4
line 5
line 6

Will output on first run python3 example.py:

b'line 1' 1
b'line 2' 2
b'line 3' 3

Will output on second run python3 example.py:

restored from /tmp/model
b'line 1' 4
b'line 2' 5
b'line 3' 6

but expected:

restored from /tmp/model
b'line 4' 4
b'line 5' 5
b'line 6' 6

I think that's working as intended -- Saver only restores parameters, and queues don't have those. Recreating Queue op resets it to the beginning.

In my case it caused a systematic error in my hyperparameter evaluation however it should be easy to work a way around (e.g. always complete one epoch).

If someone finds this. It should also be possible to use reader.restore_state() for this purpose. See API docs

@bodokaiser did you try the solution of using reader.restore_state()? Did your Queue save correctly? I'm having huge problems with my model suddenly seeming overtrained when I save/reload it. Looks like it's seeing old data.

@yaroslavvb How would you suggest saving a Queue if the full dataset is not used at the point of saving? In that case, we need to keep the state of the Queue so it doesn't see the same old data again on restoring. If we save a .meta and restore the saver as in saver.restore(sess, tf.train.latest_checkpoint("./model/")), will that save the Queue state?


⚠ ClamAV has degraded performance

In e46b796, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 203 ms

Resolved: ClamAV performance has improved in f539648.


[Feature] - Updated Footer & Fixed File Name

Signed-off-by: Adithya Krishna<EMAIL_ADDRESS>Description
This PR fixes #431
Notes for Reviewers

The file name was nitish-malhotra .md , which has been changed to nitish-malhotra.md as it was giving no such file found during build or serve
Added SMI option to the footer

Signed commits

[x] Yes, I signed my commits.

Thanks, @adithyaakrishna

Ohh, this is a strange error 😶
The contributor collection has only one file but still, the site has two. Will look into this 💯

Lmao, my bad. I Modified file was added, but the existing one was still left in staged changes 😅


tlp: add pciutils and smartmontools dependencies

When running tlp stat, tlp complained about missing tools. This
patch should fix that.

/cc @abbradar

Closed by https://github.com/NixOS/nixpkgs/commit/779d3a2ec702995d1445059b0d46a5f15a39d9a8 with a small style fix. Thanks!


[CI] add badge

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #156 opened

Start Time: 2021-02-09T12:45:35.681+0000

Duration: 5 min 19 sec

Commit: 59d8defdeec1aee146c33a3ff521baa29beb7f12

Test stats :test_tube:

Test
Results

Failed
0

Passed
205

Skipped
6

Total
211

Trends :test_tube:


Fix --ipc=host dependency on /dev/mqueue existing

Since #15862, containers fail to start when started with --ipc=host if /dev/mqueue is not present. This change causes docker to create container-local mounts for --ipc=host containers as well as in the default case.
Three other options (which I consider undesirable for various reasons):

Warn the user more explicitly if /dev/shm or /dev/mqueue is not mounted, with instructions on mounting it;
Mount /dev/shm and/or /dev/mqueue for the user, if necessary; or
Check for presence of /dev/{shm,mqueue} when --ipc=host is specified, preferring to use the global mounts, but falling back to creating container-root mounts if they are not found.

Option 3 sounds fine from a behaviour perspective, but it adds nontrivial complexity.
cc @calavera @mrunalp

I would say 1 is a good option here. I don't like 3 as we are creating container ipc mounts when user has explicitly asked us not to.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix-mqueue" git@github.com:burke/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~3
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Ok, I revised the PR to just print a more obvious error:

Error response from daemon: Cannot start container ce7df2ee53ac29590df2cb6572f57c790bcc7ce061900842543c566902df364d: /dev/mqueue is not mounted, but must be for --host=ipc

Part of me feels like it's not really appropriate to ask users to mount devices for docker to work properly, especially since it appears to be default on ubuntu (14.04 at least) to not mount /dev/mqueue -- but then, --ipc=host is a pretty niche use-case, so it's probably not an issue.

I'm okay with setting a better error message for this. I think those need to go into the errors package though:
https://github.com/docker/docker/tree/master/errors

LGTM

LGTM

LGTM


GraphQL query PaymentAddress not working on preprod

Summary
Query for address data is not working. We are trying to use a query for the Gamechanger wallet. Cardano-node and db-sync are fully synced. But asset metadata sync gets stuck at 11% on preprod. This could be related.
Steps to reproduce the bug

Go to http://localhost:3100  #Graphql playground
Query paymentAddresses data using the following query data:
query.json
query_variables.json

Actual Result
Query results in an error: "TypeError: Cannot read properties of null (reading 'assetId')",
error.json
Expected Result
A list of assetdata. With asset information. I have no working graphQL node to show actual correct output.
Environment
{
os: {
arch: 'x64',
cpus: { count: 24, model: 'AMD Ryzen 9 7900X3D 12-Core Processor' },
release: '6.8.0-31-generic',
totalMem:<PHONE_NUMBER>32,
type: 'Linux'
},
version: '8.0.0'
}
Platform

[X] Linux (Ubuntu)
[ ] Linux (Other)
[ ] macOS
[ ] Windows

Platform version
Ubuntu 24.04 LTS
Runtime

[ ] Node.js
[X] Docker

Runtime version
26.1.0

Only 6 tokens with metadata seem to get added.
"encode","name","firstAppearedInSlot"
"2cd858d024a08ec3049bbdc05e27dc894635de72b2b35d09f7cf8874","LaceCoin10",19.579.821
"34250edd1e9836f5378702fbf9416b709bc140e04f668cc355208518","ATADAnameless",10.749.595
"3e6dc4f1ef55bc8f0b5eff391c7f6dd97680872b3941ca0a535aa170","LaceCoin8",19.579.352
"68e897d04e26e9652f42aa785988e9ca0ed5fc7e69b2c12ef9c9d54c","LaceCoin9",19.579.627
"ee1ce9d7560f48a4ba3867037dbec2d8fed776d94dd6b00a35309073","SadCoin",11.103.293
"efbbf6498a4bed2e6fd8a4c7e1aa30e944502580f8dce8d76b47fd12","EmirCoin",36.061.711
There are also assets that have a firstAppearedInSlot close to the tip. So seems process is not aborting but just skipping most of the work.

@M2tec Hi I just fixed your issue. Changes are in this branch: fix/assets-skipped
My environment is still syncing, but the assets are now at 100%. Could you check it if it fixes your problem?
Log from server component:
{"name":"cardano-graphql","hostname":"d7e9401ef017","pid":1,"level":30,"module":"Server","msg":"Sync Progress: cardano-db-sync: 85.36% | Asset: 100%","time":"2024-05-03T08:49:43.897Z","v":0}

Hey yes. I just finished syncing. Query no longer returns an error. Awesome, thanks a lot!
Query result.
Query_data.json

Perfect! I'm glad to hear that

Closing this issue since the bugfix is now in PreRelease 8.0.2
If you have any other issues, let me know.


Broken link on website dashboard

When I click on a specific run on the web dashboard, it links me to a page with undefined in the URL, which doesn't exist. Here's an annotated image of how to replicate.

Thank you for reporting! We'll investigate, and get back to you once we have something!

This seems like a bug, I'm filing a ticket.

Fixed, thank you!


WIP DBZ-3566 follow up refactorings and fixture introduction

A follow up to https://issues.redhat.com/browse/DBZ-3566 since the initial set of refactoring wasn't enough

LGTM, merged.  Thanks @jcechace !


what's up with the setup?

Hi, just curious about the setup code. Any chance enzyme would be able to abstract that away.. seems redundant.

Bumping this -- Wondering the same. If you have a moment,  a little explanation here would be very appreciated.


Tables 36 and 38: Why are integration events set to OnPrem?

Talking about BC 15.2, in table 36 Sales Header, there are three events with Scope OnPrem:
    [IntegrationEvent(TRUE, false)]
    [Obsolete('Function scope will be changed to OnPrem')]
    procedure OnCheckSalesPostRestrictions()
    begin
    end;

    [IntegrationEvent(TRUE, false)]
    [Scope('OnPrem')]
    procedure OnCustomerCreditLimitExceeded()
    begin
    end;

    [IntegrationEvent(TRUE, false)]
    [Scope('OnPrem')]
    procedure OnCustomerCreditLimitNotExceeded()
    begin
    end;

On the purchase side, T38, we can find
    [IntegrationEvent(TRUE, false)]
    [Obsolete('Function scope will be changed to OnPrem')]
    procedure OnCheckPurchasePostRestrictions()
    begin
    end;

OnCheckSalesPostRestrictions and OnCheckPurchasePostRestrictions have been set to Obselete only recently.
I am subscribing to them in my SaaS app , and I wonder what to do now? Why are these OnPrem anyway?

@atoader - can you help to answer this question?

Hi! The Scope attribute applies to the procedure, not the event. Usually, these procedures should be local and invoked only from within the object. In certain cases, the event is invoked by another object so the method must be public. At the same time, we do not want extension to raise this event so the method is marked as OnPrem

Hi @atoader , please tell that the AL compiler ;-)
I do not want to raise the event; I am only subscribing to it:

Hi! I get the problem now. The obsolete message bubbles up to subscribers. The change to OnPrem will not break your code, but it will break any direct callers.

@thloke

@atoader, @thloke,  this is still not fixed in BC 16

We are aware of it. The bug has not been marked as in-progress and it is still on our backlog. I will be publishing a doc on our GitHub process in a few weeks to provide more clarity on how we accept bugs and when to expect the fixes.

@atoader This gives us a current fail on our appSource submission because it translates to a compile error on BC16. I understand that there's a timeline for bugfixes, but right now, you're effectively breaking my submission.
Please refer to Ryan Weigel from the appSource submission team for the submission error.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for submitting this issue. We will publish a fix for it in the next minor update for release 16.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

@lthomsen the warning above cannot break AppSource submissions. If the submission is still failing, please ask Ryan to CC me.


Various Bokeh backend improvements

This PR includes various improvements for the bokeh backend:

Fix for document handling on Bokeh Chart based plotting classes (Bars, BoxWhisker)
Added HSVPlot
Updated Bokeh_Element Tutorial

There's a few more tweaks to come, so not quite ready to merge.

Ok all looks good to me. I'll trigger a website build so you can see the updated tutorial. Merging.

Yes, there's a number of important improvements here and I've updated the bokeh elements tutorial massively, so go ahead and merge.

Ok, the dev portion of the website is updated now and I can make some comments:

The side bar should have a Matplotlib Elements and Bokeh Elements entry imho.
I might consider putting a warning at the top of  Bokeh Elements saying that the page make take a few seconds to load. The first time I saw it, I navigated away from the page thinking it was broken.

Isn't being able to quickly preview changes to the website wonderful? :-)


Add application autoscaling

Adds support for Application Auto Scaling

Looks good to me!
Can you add an entry to CHANGELOG under the [Unreleased] header for this?


blackhole: remove synchronization of tables in BlackHoleMetadata

blackhole: remove synchronization of tables in BlackHoleMetadata
Synchronization (atomic remove and put into concurrent hash map of
tables) is not needed, it does not guarantee that concurrent operations
on metadata can be run safely (e.g. rename table with drop table).
Simple approach of fixing that would be to try implement transaction-like
metadata storage with using ConnectorSession.getStartTime() as transaction id (txid)
Then session with higher txid would need to wait for all
operations with lower txid to finish.
Ticket: #3647
Test Plan: none

Merged, thanks!


www shows invalid certificate on centos 7.2

Today, I installed letsencrypt-vesta . Everything installed fine.
But I just realised https://www.example.com shows invalid certificate, where https://example.com loads fine.
www shows invalid certicate.
I did get the error :-
/usr/local/bin/letsencrypt-vesta: line 64: /usr/local/vesta/bin/v-list-web-domain-alias: No such file or directory
I am running on Centos 7.2 with vestacp <IP_ADDRESS>

This due to this issue: https://github.com/interbrite/letsencrypt-vesta/issues/27
In the most recent Vesta update the v-list-web-domains-alias command was removed, so letsencrypt-vesta is no longer able to get the alias list, in which the www variant of the URL is generally listed.  I need to do a little more research into what's going on before I can suggest a solution, though.

Hi jpitoniak,
Just found this (untested as of yet) that seems to have a solution for your v-list-web-domains-alias command
https://forum.vestacp.com/viewtopic.php?t=11876

@CImrie ,
Well, that command didn't exactly work for me (it returned the site's IP address, not a list of aliases), but v-list-web-domain does return aliases among other things, so I should be able to make it work.  I'll try to play with it tonight and see if I can get a release out soon.
Thanks!

This should now be resolved after the update released on Saturday.  Please confirm.

It is resolved.
Thanks


svelte version dependency

What package has an issue
@svelteuidev/core
A clear and concise description of what the bug is
I'm not sure if this is a bug or not - the latest dev release seems to explicitly state svelte 3.47.0 as the peer dependency. 3.49.0 is the latest version, so trying to upgrade from a previous version of svelteui where you already have the latest svelte installed causes npm errors and warnings.
In which browser(s) did the problem occur?
No response
Steps To Reproduce
Install the latest svelteui - you'll get svelte 3.47.0 installed. Then npm install<EMAIL_ADDRESS>and you'll get:
User> $ npm outdated
Package  Current  Wanted  Latest  Location             Depended by
svelte    3.47.0  3.49.0  3.49.0  node_modules/svelte  svelteui-tab-test
User> $ npm install<EMAIL_ADDRESS>npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving<EMAIL_ADDRESS>npm WARN Found<EMAIL_ADDRESS>npm WARN node_modules/svelte
npm WARN   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN   node_modules/@sveltejs/vite-plugin-svelte
npm WARN     dev<EMAIL_ADDRESS>from the root project
npm WARN   5 more (@svelteuidev/core, svelte-check, svelte-hmr, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN node_modules/@svelteuidev/core
npm WARN<EMAIL_ADDRESS>from the root project

changed 1 package, and audited 96 packages in 325ms

10 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

Again, not sure if that's intentional or not. There is a vulnerability in svelte 3.47.0 that should make upgrading desirable.

Hey thanks for bringing that to my attention. There seems to be an issue in our build script that messes up the peerdeps. We will release a new patch.

Fixed in latest patch!


[Feature] Add the ability to disable truncation

Is your feature request related to a problem? Please describe.
Adding the an option to the track method that disables property truncation.
Describe the solution you'd like
I currently use ApplicationInsights-Web to send telemetry to a non-Azure endpoint. I do this because the SDK is robust, has fault tolerance, and implements useful retry logic out of the box. My service understands and adheres to the contracts created by the Application Insights SDK.  Unfortunately, the SDK defaults to limiting the length of property fields to 8192 characters. This limit is based on the Application Insights Azure service's specifications, but isn't relevant if you use a self-hosted option.
I'd love to see an option that can be passed down to conditionally disable the character length limit that exists here.
Describe alternatives you've considered
I've considered migrating away from using the ApplicationInsights-web SDK, though I enjoy the benefits the library confers for telemetry management.
I've also considered shrinking telemetry length, though there are some messages that are long by nature and cannot be shrunk.

We can't remove the "truncation" limits as if we do the backend will reject the entire event as that is why we have these limits in place.
If you find "some" field where it seems that the SDK imposed limit does not match the server limit we can address that as a bug, but generally the limits were gathered from the server several years ago.

We can't remove the "truncation" limits as if we do the backend will reject the entire event as that is why we have these limits in place.
If you find "some" field where it seems that the SDK imposed limit does not match the server limit we can address that as a bug, but generally the limits were gathered from the server several years ago.

@MSNev Thanks for replying so quickly! What about the possibility of adding a configuration to disable truncation client-side? We have our own server that mimics the behavior of the App Insights server, but doesn't have character limits as we need longer field values. It could be added to the .Track(..., truncate: Boolean) function such that, if omitted, it defaults to true. What do you think?

That might be a little ticky as all of the actual sanitization (truncation) occurs in these functions which don't take any additional config properties (to potentially have a disable flag)...
Which would mean that every call of these would either need to have an alias (so we could replace with a no-op that just returns the value), so it's probably not a trivial change and we would need to be a little careful to ensure we didn't increase the bundle size too much or introduce bugs of people that don't have the same requirements.
I'll tag this as an enhancement, but I don't expect that we will get to this any time soon. So feel free to investigate and see if you could propose a possible option to solve your issue (ie. a PR).

@MSNev In league with your feedback on my PR- do you have any availability to walk through the code a bit? I'd love to get the lay of the land in terms of how things work holistically, as well as future plans I can work around.

What timezone are you in? I'm in PST/PDT, I tend to have a lot of early morning meetings my time everyday... Based on your github profile it looks like your about -3hrs from me, is your listed github email the best way to directly contact you?

What timezone are you in? I'm in PST/PDT, I tend to have a lot of early morning meetings my time everyday... Based on your github profile it looks like your about -3hrs from me, is your listed github email the best way to directly contact you?

Yep! That's correct, I'm in EDT, so ~3 hours ahead of you. I can be reached at<EMAIL_ADDRESS>I was searching for you in Teams but I wasn't able to find your full handle, maybe we can interface that way?