[BUG]  Not Able to Update the Templates

Describe the bug
I am not able to update the File or Highlight Templates. When I click in either of the fields, the cursor always displays at the very beginning of the text, and I'm not able to work with the text in any way (e.g. select it by my mouse or write anything).
You can see that I'm using a custom theme, however, this doesn't affect this issue (I tried switching to the default and the bug was still persisting).
Method of syncing

[ ] Amazon Kindle Reader
[x] My Clippings file

To Reproduce
Steps to reproduce the behaviour:

Open the plugin settings
Click in either the File Template or HIghlight Template input field
Try editing the template text

Expected behaviour
I should be able to edit the text within both the File Template and the Highlight template input fields.
Screenshots
If applicable, add screenshots to help explain your problem.

Metadata

OS: macOS 12.0.1
Plugin version: 1.6.3
Obsidian version: Version 0.15.6 (installer 0.14.15)

I have the same problem!

Same problem but on windows.

Can you please see if this issue still exists in the latest version of the plugin 1.8.0 which was released this morning?
I've build a brand new template editor to make it easier for users to customise and preview their templates to their liking.
I haven't experienced this issue with this latest version.


Don't close browser on fail or at the end of the test

Hi,
First of all,thanks for your great job.
I want to create a test suite using D365 to run on a Dynamcis app.
I need my browser to be alive if any error occurs in my script to check from where come my problem (i can use page.pause() for that)
But in my CI I don't want to login again between each test (it take too much time considering the number of time i have)
Is there a way to avoid browser to close on fail (i know page.pause() exists) or when a test ends ?

@CyrilPERIE If I am not wrong, it is Playwright default behaviour to close the browser on a failure. You can use soft assertions or save the storageState for your login data and re use it in your tests.
https://playwright.dev/docs/auth


[BUG/ISSUE] text cut out start screen

https://github.com/marticliment/WingetUI/commit/6424762d74c43a3d25047b764088aea822666d50 causes this to me

Move to #971


Which pretrained checkpoints to use to perform rendering?

Thank you for sharing your excellent work. I want to run the rendering command CUDA_VISIBLE_DEVICES=0 python text2nerf_main.py --config 'configs/text2nerf_scenes.txt' --expname 'text000' --prompt 'a beautiful garden' --datadir 'data_example/text000' --pose_traj 'local_fixed' --regen_pose --render_only 1 --render_test 1 --ckpt '[path of ckpt]' but I couldn't figure out which checkpoint file to use.
I tried some of the checkpoints downloaded in the weights directory but it seems that the checkpoint is required to have kwargs key with 'aabb' and 'gridSize' information and I couldn't find one with kwargs.

I also didn't find the checkpoints and decide to train model, get checkpoints and then run rendering command.

I also didn't find the checkpoints and decide to train model, get checkpoints and then run rendering command.

Hello. Could I ask what dataset you used to train the model? thank you

I also didn't find the checkpoints and decide to train model, get checkpoints and then run rendering command.

Hello. Could I ask what dataset you used to train the model? thank you

I used to text prompt (which I needed in that monent) to generate dataset by diffusion models (in pipeline Text2NeRF).


publish on npm

hey @germanrcuriel , I've bumped a major version, need your help in publishing on npm.

Done! Sorry for the delay

thanks


preserveObjectReferences can result in InvalidCastException

when Uri is serialized with preserveObjectReferences and versionTolerance enabled, deserialization will fail with InvalidCastException.
It happens like this. During serialization,

SerializerSession will track Uri itself
Uri contains the url itself in several fields as string
it'll try to serialize the string value
session.TryGetObjectId will find the previous object, unfortunatelly it won't be string, but Uri
Later, during deserialization, this will result in InvalidCastException

Reason is, that SerializerSession is using default equality comparer for tracked objects and string and Uri are equal, when having the same value.

Possible duplicate of #85 ?

Not sure, but I'd say it's not the same issue


TODO/FIXME Count 2

[x] TODO: merge similar callbacks below into single function
Commit: (083eefe) Consolidate common code.
File:  lib/database.js:534
Dave Longley commented 5 years ago

[ ] TODO: refactor to avoid removing user; driver doesn't seem to provide
Commit: (6422e5e) Add mongodb 2.6+ support.
File:  lib/database.js:798
Dave Longley commented 5 years ago

All that remains is dealing with the user update/replacement. Maybe we just want to keep things as they are as well as it is simple.

Closing. Opened new issue for the remaining TODO item.


Bad Hex Package

The package on hex does not contain the dependencies: https://hex.pm/packages/brod
Dependencies must also be hex packages. Without a fix for this anyone using the hex package must manually include the 2 dependencies required by brod in their top level config.

Fair point. On it.

Verified with a Phoenix project, works fine with {:brod, "~> 2.1.2"} in hex.pm.

Thanks! Works great.


Experiments seem stuck when acquiring lock

Hi,
Firstly, I want to thank you for your amazing work. Sacred really, really helps me organizing and analyzing my experiments. Love it sooo much!
When I run several experiments in a row though, sometimes Sacred got stuck after an experiment is finished. Last time I waited for hours but it was still stuck. I had to manually press CTRL-C for the next experiment to start. And when I did that, this traceback occurred:
^CException ignored in: <module 'threading' from '/Users/kemal/.pyenv/versions/miniconda3-latest/envs/id-pos-tagging/lib/python3.6/threading.py'>
Traceback (most recent call last):
  File "/Users/kemal/.pyenv/versions/miniconda3-latest/envs/id-pos-tagging/lib/python3.6/threading.py", line 1294, in _shutdown
    t.join()
  File "/Users/kemal/.pyenv/versions/miniconda3-latest/envs/id-pos-tagging/lib/python3.6/threading.py", line 1056, in join
    self._wait_for_tstate_lock()
  File "/Users/kemal/.pyenv/versions/miniconda3-latest/envs/id-pos-tagging/lib/python3.6/threading.py", line 1072, in _wait_for_tstate_lock
    elif lock.acquire(block, timeout):
KeyboardInterrupt

Also, the metrics for that run weren't saved. This always happens after ~7 experiments in a row. I am running and storing my experiments locally on my macOS 10.13. I am using Sacred 0.7.2, Pymongo 3.4.0, and Mongodb 3.6.4. I'm probably wrong but this might have something to do with macOS because I had no such issues when running on Ubuntu.

UPDATE:
I was wrong, the metrics were saved. And it has nothing to do with macOS because now I am having the same problem when running on Ubuntu (both the experiments and MongoDB, but different machines). Also, I am using Python 3.6.

Ugh, this is an ugly one, and it is going to be difficult to track down. Just to be sure, could you check if the problem persists with the current master? Because I've since changed the threading behavior to fix some other problem.
pip install git+https://github.com/IDSIA/Sacred.git@master

Interesting. It seems the issue is fixed in master. Do you have any guess what the cause might be? Also, if I switch to master from 0.7.2 from PyPI, what are the major differences? I'm in the middle of experimentation so I don't want to have potential unfair comparisons among my experiments.

Yes. I had a bad way of dealing with the heartbeat thread, such that it would sometimes not exit when the experiment finished. This is probably also where it got stuck in your case.
I just released 0.7.3 on pypi, so you can now just pip install the new version. It is mostly a bugfix release (release notes), so it shouldn't affect your experiments much ;-).

I have 0.7.3 and sadly running into the same issue.


resin-persistent-logs: Fix persistent logging

Fixes #1035
Mount systemd units create directories when not available. We switched to
service units based on bindmount tools which expects the destination to be in
place. This change fixes this by making sure /var/lib/journal is in place
before starting the bind mount service.
Change-type: Patch
Changelog-entry: Fix persistent logging
Signed-off-by: Andrei Gherzan<EMAIL_ADDRESS>
Contributor checklist

[x] Changes have been tested
[x] Change-type present on at least one commit
[x] Signed-off-by is present
[x] The PR complies with the Open Embedded Commit Patch Message Guidelines

Reviewer Guidelines

When submitting a review, please pick:

'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

LGTM, with a small note on a typo in the commit log:

This change fixes this by making sure /var/lib/journal is in place
before starting the bind mount service.

Guess that should have been "/var/log/journal" instead

@floion fixed.


More maintainers needed!

Dear André Rouél,
This seems to be the best project for user agent detection in the JVM space. However, its getting to show its age. Could you please look through the list of contributors or fork owners and approach those you might trust to become contributors of this project?
Thanks! It would greatly help a lot of people.

+1 it's sad to see this project got abandoned
@before , can you please add more contributors to this project?

+1

FYI: https://github.com/woothee/woothee
Project Woothee is multi-language user-agent strings parsers.

@erikvanoosten the issue is that the data source is no longer open source ($50/month for data access I believe). At least that seems to be why @before gave up on the project (which I agree is the best of its kind on the jvm).
There's always client-side browser detection but it's nice to be able to do so statically server-side.

im not familiar with software license but is it OK to duplicate this repository and go from there? (e.g. change the group and publish to maven under a different name?)

According to https://github.com/before/uadetector/blob/master/LICENSE.txt this should be possible. However, as long as this project does not refer to the fork, it will take a long time before other people will find the it.

Thanks @godenji . That is good information. It would be great if that information appeared in the readme.

I'm open to hand over this project to some other folks. Please let me know who is interested.

@before I can step in for awhile, at least to push out another release with latest widely used user-agents in place.
I work in Scala + SBT + Sonatype; Maven + Java isn't my strong suit. A couple of years ago I tried upgrading the project to Java 8 but tests started failing.
Anyway, don't want to take too much of your time, but if you have build steps/guideline handy please send along.
Thanks

@godenji I just used a JDK 7 and default maven commands to build, test and package the code. You can always ask me when stepping into issues. I'm too busy with other projects and this one is not relevant to me since a while.


feature/fetch-all-supported-configurations

Description
Adds .fetch_all() method to the node-js-release-info crate to retrieve list of supported configurations.
How to Test

Clone and setup this branch locally (docs)
Review docs for .fetch_all(): cargo xtask doc --open
Run tests: cargo xtask test
Try out the examples

Outcome
Tests should pass, docs and examples should be clear and helpful, and you should be able to successfully replicate and run the examples.
Related / Discussions
N/A
Completeness

[x] PR opened :tada:
[x] Testing instructions have been provided
[x] Development How-To's have been provided
[x] Docs have been updated (cargo xtask doc)
[x] Branch is rebased against target (typically main)

🎈🥳 :shipit:


Make Speaker description width 100% for 992px to 1200px screen

Previously it was of width 50% by default ............ according to this issue I made it 100%.

Checklist

[x] I have read the Contribution & Best practices Guide.
[x] My branch is up-to-date with the Upstream development branch.
[x] I have added necessary documentation (if appropriate)

Short description of what this resolves:
Changes proposed in this pull request:

Fixes #2322

@Raunaksingh100 As you can see that it is just a change in CSS, the travis CI error has nothing to do with it [It is caused due to Selenium Timeout]


Single Player Creative Crash.

For some reason having this mod and https://mods.vintagestory.at/show/mod/5563 installed makes CAN Crops try to load its xskills compatability. Posting this on both of yalls issue tracker incase it is the other causing the issue.

https://github.com/kenigvovan/cancrops_7/issues/1

Correction, this mod causes a crash when loading a single player creative world.

Vintage Story loads two different Mods depending on what you're doing: The Creative Mod or the Survival Mod. The Creative Mod does not implement some things that the Survival Mod does (in this instance the Prospecting Pick is not implemented). Any mods based on the Survival Mod may not be compatible with Creative Mod

Oh weird. Sorry to make the issue if it was not something you can do anything about.


About where images uploaded from my local machine are stored（v5.2）

Hi Team,
I would like to ask about the following released features at v5.2.
・Ability to upload image from local machine.
Where are the images uploaded from the "local machine" saved?
Thanks,
(CC: @ATshirai)

Hi @MK202204 ,
In the latest release, we have added the feature "Ability to upload image from the local machine". This means author can upload the image from his local machine with the image size <=1MB.  This option can be seen in the UI like below

Hope this helps.

@gsv022 Thank you for your reply!
yes, I understand that author can upload from local machine, not just the image link.
I'm concerned about uploaded images being stored somewhere in the storage of accessible to everyone.
Or is it the same as sending an email with an image file attached?
Regards,

@MK202204 , the existing feature is like adding the URL of the image in image URL section so that image preview will be available, In addition, uploading the image through upload option. So we have given two ways for one option either image URL or uploading the image from the local machine.
The added feature is not related to sending an email with an image file attached.

@MK202204 , The uploaded images will be saved in the Azure blobs within private containers. So it won't be accessible to everyone.

@gsv022 @v-royavinash
Thank you for your replies!
I understood that uploaded images will be stored in CC's internal object storage.
Thanks,


Cod & nautilus shell isn't recognized by the plugin

*Description of issue:
Cod & Nautilus shell are considered as "AIR" in the /jobs info
CONFIG SECTION (DELETE IF NOT RELEVANT):
Fish:
      PufferFish:
        income: 5
        experience: 34
      Salmon:
        income: 5
        experience: 34
      Cod:
        income: 5
        experience: 34
      TropicalFish:
        income: 5
        experience: 34
      NAUTILUS_SHELL:
        income: 6
        experience: 40
      ENCHANTED_BOOK:
        income: 6
        experience: 40
      NAME_TAG:
        income: 6
        experience: 40

Server Type (Spigot/Paperspigot/etc):  Spigot
Server Version (using /ver):
[17:50:06 INFO]: This server is running CraftBukkit version git-Spigot-1a3504a-dfa7583 (MC: 1.13.2) (Implementing API version 1.13.2-R0.1-SNAPSHOT)
[17:50:06 INFO]: This is a final build for 1.13.2. Please see https://www.spigotmc.org/go/1.13.2 for details about upgrading.

Nautilus shell material has no any internal ID to be work correctly. If a material/entity has -1 internal value then does not generate to TranslatableWords file at plugin load. The Cod entity (now I see) has a Internal ID, so we fix it now and commit.


[resolves #113] - Updating identity and jdbc resources and operation accordingly with ELY-282.

Some code changes based on upstream changes (https://github.com/wildfly-security/wildfly-elytron/pull/287).

Changes to ON HOLD given that we need some changes to https://github.com/wildfly-security/wildfly-elytron/pull/287 in order to allow obtain the credential names.
See https://github.com/wildfly-security/elytron-subsystem/pull/114/files#diff-329ab5d71a226f7eb2dd18e1de9bc9dcR723, for more details.


Moc openstack login ii

Do not waste your time reviewing this pull request.  I am using this to try to diagnose the configuration issue I am having on one system.

The configuration issue is over - just closing this pull request.


Docs build failure

The flamedisx documentation has been failing to build for ~3 weeks on readthedocs, due to an nbsphinx/sphinx compatibility problem: https://github.com/spatialaudio/nbsphinx/issues/584. The current version at https://flamedisx.readthedocs.io should still be up to date, as there were no documentation changes in the last 3 weeks.
A fix seems to be on its way (see the nbsphinx issue above); if it takes too long we could pin sphinx to an earlier version to fix the build.

nbsphinx has been updated, and our docs are building again :-)


confusing documentation about sbt axises

here http://www.scala-sbt.org/0.13.5/docs/Getting-Started/Scopes.html some descriptions are very confusing.
In particular it took me long time to undestand that in
{<build-uri>}<project-id>/config:intask::key

I should choose between config or intask and then add ::key
I think one or two examples like:
fooproject/config::name
fooproject/intask::bartask

will resolve the problem.
In my case confusing parts appeared because I got used to the notion that I operate with sbt as if I operate with scala-code. But in case of project/axis::key notation I operate just with some sbt-specific command syntax that is not code. I think it should be highlighted in the beginning that we are dealing with some special notation and axises here do not mean some scala traits (like I thought in the beginning) but a part of sbt console commands.

Closing this for now.
https://www.scala-sbt.org/1.x/docs/Scopes.html hopefully has improved.

Closing this for now.
https://www.scala-sbt.org/1.x/docs/Scopes.html hopefully has improved.


disassembly might be ignoring literals

$ bin/bscript.js disassemble OP_10 0x01 0x78 OP_ADD 0x02 0x8200 OP_EQUAL
5a

$ bin/bscript.js disassemble OP_10 01 78 OP_ADD 02 8200 OP_EQUAL
5a

currently you must pass the literals as decimal.


修复在分片下载的协程中，因为关闭文件不及时造成的最后完成rename时提示文件被占用的错误

使用断点续传多线程方式下载文件，线上使用后发现，经常会出现rename  xxx.zip.temp  yyy.zip:the process cannot access the file because it is being used by another process  的错误导致下载失败
temp文件已经下载成功，但是最后重命名Rename的时候会出现这个错误
发现在下载分片的协程中，使用了defer来进行temp文件描述符的关闭，这样可能会造成多分片的情况下，result 管道已经通知，但是temp的fd还未及时关闭，很大概率会导致rename时出现文件被占用

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage decreased (-51.7%) to 39.121% when pulling 2028ddabe4bb52cc3861ba19b3dddde6f898859b on bryant24:fix-rename-process-being-used into dee3ad30860e06bd1e28e4d16e2d591da8e03552 on aliyun:master.


In-app CE to BE upgrade with 3 nodes free license fails

Issue
When attempting to use the in-app upgrade functionality to go from CE to EE on a CE install prior to 2.18.4 (I tested this with 2.18.2) using a 3NF license key, the upgrade process is unable to complete because of the lack of support for the new 3NF license key type. In addition, this gets the user partially upgraded to BE but without a valid license, locking them out of their Portainer installation.
Expected behavior

When user provide “2-xxx” license key when upgrading from CE to EE, portainer-updater should follow existing upgrade approach ( eg. Upgrade from CE 2.18.2 to EE 2.18.2 when providing "2-xxxx" license key )

When user provide “3-xxx” license key when upgrading from CE to EE, portainer-updater should upgrade to EE 2.18.4 ( eg. Upgrade from CE 2.18.2 to EE 2.18.4 when providing "3-xxx" license key )

Actual behavior
License validation fails but the CE install is upgraded to EE, but with no valid license key, locking the user out of their system until they upgrade to 2.18.4.
Steps to reproduce

Install Portainer CE version 2.18.2 (portainer/portainer-ce:2.18.2)
Click Upgrade to Business Edition banner link
Enter a 3NF license key
This will throw an “Unable to upgrade edition” error message. However, the upgrade has partially actioned in that the running image is now portainer/portainer-ee:2.18.2. The browser session has been invalidated as a result, and a reload will prompt you to log back in, at which point you are asked for a license key. Because you are running portainer/portainer-ee:2.18.2 your 3NF key is not accepted, throwing a “license is invalid” error message.

PR -> https://github.com/portainer/portainer-updater/pull/18


Security issue with the _formatted attribute ( highlight )

Describe the bug
When you do a search and require to highlight the terms that matched, an HTML tag  is added.
This force the applications to render the result from MailiSearch as HTML.
If a user insert a malicious HTML code, it will get executed.
MailiSearch should escape ( something similar to what php's htmlentities function does ).
Example:
Sample search: xuxu
Sample content:
ximira  xuxu

Highlighted content ( from a malicious user ):
ximira  xuxu

Expected highlighted content:
ximira <script>alert('xablau')</script> xuxu

This means that web applications using the highlighted output will only evaluate tags generated by MeiliSearch.

Hello @TiagoJacobs 👋
For the moment we have chosen to let the sanitization work to the choice of the user on the client-side according to his use case.
Here is an issue that will give more details about that choice. https://github.com/meilisearch/MeiliSearch/issues/1409
It is possible that we will change this behavior later, I will move this issue to our product repository discussions space so that we can discuss this topic and other users can join and vote for the best proposals/messages.


add fancier success icons

Please provide a description of this PR:
added fancier icons for success statuses in istioctl

@ilrudie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test release-notes

lint_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test release-notes

lint_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test lint

unit-tests-arm64_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test release-notes

lint_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test lint

unit-tests-arm64_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test unit-tests-arm64

gencheck_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test release-notes

lint_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test lint

unit-tests-arm64_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test unit-tests-arm64

gencheck_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test gencheck

unit-tests_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test lint

unit-tests-arm64_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test unit-tests-arm64

gencheck_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test gencheck

unit-tests_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test unit-tests

release-notes_istio
a3b88d59e02fa2e0f8ac799922102d9c7756270a
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test unit-tests-arm64

gencheck_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test gencheck

unit-tests_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test unit-tests

release-notes_istio
a3b88d59e02fa2e0f8ac799922102d9c7756270a
link
true
/test release-notes

lint_istio
a3b88d59e02fa2e0f8ac799922102d9c7756270a
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test gencheck

unit-tests_istio
2c17356dcb886225c6a0e2b5308cd7d28cbc3937
link
true
/test unit-tests

lint_istio
a3b88d59e02fa2e0f8ac799922102d9c7756270a
link
true
/test lint

release-notes_istio
fb28e81f4b5861b7eea321ef88a1cf53fdd62734
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ilrudie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
03534e6e3e10c6cad0f937f24e7c1503a8ee48e4
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes

Most of these characters don't render for me. I think seeing squares wouldn't be the best look. Not everyones terminal/font will have full unicode/emoji support.
⛵🧠🪢🔒🛬🛫✅❌✅❌
Only 3 of these (the sailboat, the knot and the lock) render for me.

In my case, the first letter of the last message is cut off:

Good it is in master :) thanks @stevenctl and @hanxiaop for reporting it. cc @ilrudie

We can revert it if folks want and I can look at some detection methods so we can have like a fancy set and a safe set to choose from based on detecting what is/isn't supported

An alternative might be to use a simple up/down to indicate success as we were previously but decorate the end of the line with fancy characters. this way if we do get the mystery char box at least what occurred is clear and still readable.


"Fan Switch" specific device type label is missing (Z-Wave Plus Device Type)

Is your feature request related to a problem? Please describe.
The Fan Switch specific device type has no label, it shows as UNKNOWN.
Describe the solution you'd like
The specific device type should say Fan Switch.
Describe alternatives you've considered
None.
Additional context
See example dump here, node 6 for example.
"deviceClass": {
					"basic": "Static Controller",
					"generic": "Multilevel Switch",
					"specific": "UNKNOWN (0x08)",
					"mandatorySupportedCCs": ["Basic", "Multilevel Switch"],
					"mandatoryControlCCs": []
				},

Should be
"deviceClass": {
					"basic": "Static Controller",
					"generic": "Multilevel Switch",
					"specific": "Fan Switch",
					"mandatorySupportedCCs": ["Basic", "Multilevel Switch"],
					"mandatoryControlCCs": []
				},

You don't have the updated specs by any chance?

You don't have the updated specs by any chance?

The device type spec is in this repo, section 4.8 for fan. Are you asking which document the actual value of SPECIFIC_TYPE_FAN_SWITCH is specified?

The device type spec is in this repo, section 4.8 for fan. Are you asking which document the actual value of SPECIFIC_TYPE_FAN_SWITCH is specified?

Uhh I think I don't have that part translated to JSON yet, only SDS10242. Or it might be an oversight.
If someone wants to help out - SDS13740 contains the values in a practical C-Code as PDF form 😖

Uhh I think I don't have that part translated to JSON yet, only SDS10242. Or it might be an oversight.
If someone wants to help out - SDS13740 contains the values in a practical C-Code as PDF form 😖

Huh, I'm missing SDS13740, good to know.
Is there more to it than just adding a new entry here?
https://github.com/zwave-js/node-zwave-js/blob/68c25e2b2372ef8592f8f1b0ca8aef1734c47085/packages/config/config/deviceClasses.json#L237
You have most of others, just not Fan and Color Tunable types.

Huh, I'm missing SDS13740, good to know.
Is there more to it than just adding a new entry here?
https://github.com/zwave-js/node-zwave-js/blob/68c25e2b2372ef8592f8f1b0ca8aef1734c47085/packages/config/config/deviceClasses.json#L237
You have most of others, just not Fan and Color Tunable types.

The C macros are also defined in this header file. Like in SDS13740 they seem to have given up on assigning descriptive names (e.g. Fan Switch).
There are human readable strings in this public XML file.

The C macros are also defined in this header file. Like in SDS13740 they seem to have given up on assigning descriptive names (e.g. Fan Switch).
There are human readable strings in this public XML file.


Getting styles for flex* props should return whatever was passed to the corresponding setter

YGNodeStyleGetFlexShrink() for example does not always return what was set in YGNodeStyleSetFlexShrink(). This is due to these being computed based on the shorthand flex property. This should however be more of an implementation detail and a style getter should always return what was passed to the setter.

I'll give this a go 🔨


Accordion

I would like to claim this task. : )

Hi @productdevbook, I'm working on this component

I getting this task :)


fix(bridge): fix max amount button

Fixes #2743

@shadab-taiko can we make sure the accuracy of the max value is a fixed value.


finish task 236

Ⅰ. Describe what this PR does
add "Copyright 2023 The Fluid Authors."
Ⅱ. Does this pull request fix one issue?

fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

/assign @yangyuliufeng


A .md file for Services offerings plan issue#159.

I have created a .md file based on the research I've done on this issue.

This PR is based on the research only I've done on this issue with the help of ChatGPT. I'll do changes as required when the PR will be approved on issue#158.


Login / Registration forms

A few things here.

removes the user entered session time, simply allows "forever" or uses what the admin has in the ACP.  No changes to the cookies themselves in this update
uses some experimental form inputs for text/email/password drawing from what material design does.  The concept is to keep the input labels close to the box.  Login was not bad but registration was a mess.  You can test drive at elk.spudsdesign.com by looking at the login and registration tabs.
As always various fixes to areas that showed up in trying to test the changes or misses from my previous commits 👼

Codecov Report

Merging #3504 (a98ac70) into development (233b62f) will increase coverage by 0.95%.
The diff coverage is 10.25%.

@@                Coverage Diff                @@
##             development    #3504      +/-   ##
=================================================
+ Coverage          30.27%   31.22%   +0.95%
+ Complexity         15782    11625    -4157
=================================================
  Files                416      258     -158
  Lines              74045    49474   -24571
=================================================
- Hits               22417    15450    -6967
+ Misses             51628    34024   -17604

Impacted Files
Coverage Δ

sources/ElkArte/AdminController/ManageFeatures.php
18.55% <0.00%> (+0.02%)
:arrow_up:

...ces/ElkArte/AdminController/ManageRegistration.php
5.39% <ø> (ø)

sources/ElkArte/Controller/Display.php
75.06% <ø> (-2.00%)
:arrow_down:

sources/ElkArte/Controller/Recent.php
64.00% <ø> (ø)

sources/ElkArte/Controller/Register.php
0.00% <0.00%> (-36.99%)
:arrow_down:

sources/ElkArte/Controller/Reminder.php
0.00% <0.00%> (ø)

sources/ElkArte/IlaIntegrate.php
0.00% <0.00%> (-3.75%)
:arrow_down:

sources/subs/Emailpost.subs.php
33.05% <0.00%> (-0.33%)
:arrow_down:

sources/subs/Who.subs.php
8.74% <ø> (-15.85%)
:arrow_down:

sources/ElkArte/Controller/Auth.php
22.04% <100.00%> (-20.24%)
:arrow_down:

... and 288 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 233b62f...a98ac70. Read the comment docs.

I've left the crowd speechless in the wake of this awesomeness ... merge!


Add notes for drafts

User needs:

to be able to discuss issues, changes and ideas for a draft with others
to see any feedback received from others
#52 is a pre-requisite for this ticket.

Acceptance criteria:

[ ] User can type in a comment box and hit "send" to add a comment to the notes panel

Just realizing this is an additional use case that simply uses the space created by a Notes pane, keeping it separate and subsequent makes sense.

Related: https://github.com/netlify/netlify-cms/issues/1850

Going back to my comment from like two years ago - this is going to be rolled together with #52.


Make it work for gcc-14

In GCC-14, pointer compatibility warnings have been promoted to errors.
This disables that check where necessary.

As a general note, eventually if one can at some point in the future depend on Nim 2.0.8 or newer being available, this workaround will become redundant.

what about compilers for which the flag does not exist (clang, older gcc etc)? ie has the option to actually fix the pointers been explored?

what about compilers for which the flag does not exist (clang, older gcc etc)? ie has the option to actually fix the pointers been explored?

I did look into that. I was unable to find out what the nim equivalent of the C type should be. It's a const void* const * const. Clearly it aligns with nim ptr pointer, but I have no idea how to make GCC see that. If you have the answer, I'd be happy to learn a thing or two!

Most our libraries have had to go through this process such as https://github.com/status-im/nim-bearssl/pull/62 - just look for gcc 14 in any bumped deps.

OK that was disgustingly simple. Thanks so much, Arne!


[pod-lifecycle] note the difference between PodConditions and PodStatus

The difference between pod.status.phase and pod.status.conditions.type was not very clear to me. As both provide some human-readable description of the pod state, I think it's important to make the distinction a bit clearer.

I signed it

@rozcietrzewiacz 👋  Please feel free to /reopen this PR when you're ready to apply review feedback.

/close


GitHub: rate limits border

Primary rate limit for unauthenticated users
You can make unauthenticated requests if you are only fetching public data. Unauthenticated requests are associated with the originating IP address, not with the user or application that made the request.
The primary rate limit for unauthenticated requests is 60 requests per hour.
Primary rate limit for authenticated users
You can use a personal access token to make API requests. Additionally, you can authorize a GitHub App or OAuth app, which can then make API requests on your behalf.
All of these requests count towards your personal rate limit of 5,000 requests per hour. Requests made on your behalf by a GitHub App that is owned by a GitHub Enterprise Cloud organization have a higher rate limit of 15,000 requests per hour. Similarly, requests made on your behalf by a OAuth app that is owned or approved by a GitHub Enterprise Cloud organization have a higher rate limit of 15,000 requests per hour if you are a member of the GitHub Enterprise Cloud organization.

More info: https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api


Remove Goyoo Node.js API client

Reasons to remove this:

This client is pretty weird, and a bit hard to use.
It hasn't been updated for 4 years.
Issues are piling up on GitHub.
It doesn't do much to help the user
There are many alternatives now that work well.

@SpamapS you might prefer to file an issue. To submit a pull request, you must sign the CLA - see https://github.com/kubernetes/website/pull/27028#issuecomment-797689259

/check-cla

@SpamapS if you sign the Kubernetes CLA, we can review these proposed changes. We'll close this PR in a few weeks if it's still not reviewable.

I believe my company, Spotify, has signed it and I'm waiting to hear back
from them on how to get my username added to the list that ties me to that.
On Thu, Mar 25, 2021, 5:56 PM Tim Bannister @.***>
wrote:

@SpamapS https://github.com/SpamapS if you sign the Kubernetes CLA, we
can review these proposed changes. We'll close this PR in a few weeks if
it's still not reviewable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/pull/27028#issuecomment-807847786,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADS6YBW2UBNDG7YEKJ5ZM3TFPLU3ANCNFSM4ZCZIAHQ
.

Hi @SpamapS .
Any progress on signing the CLA?
You might try to open a new PR (with this change)?

Hey there! @SpamapS, looks like you haven't signed the CLA yet. Could I please have you do that? https://github.com/kubernetes/community/blob/master/CLA.md

Hi @SpamapS .
I am closing this PR. You need a valid CLA to contribute content changes.
/close


error 500 fetching first image of volume

in some Volumes of http://library.bdrc.io/show/bdr:I1PD96684
eg http://library.bdrc.io/show/bdr:V1PD96684_I1PD106654, http://library.bdrc.io/show/bdr:V1PD96684_I1PD106655,
http://library.bdrc.io/show/bdr:V1PD96684_I1PD106657
but not http://library.bdrc.io/show/bdr:V1PD96684_I1PD106656,
manifest is fetched successfully but there is a 500 error fetching first image: http://iiif.bdrc.io/image/v2/bdr:V1PD96684_I1PD106657::I1PD1066530003.jpg/full/full/0/default.jpg

This is resource dependant as the first image is returned for other volumes: http://iiif.bdrc.io/image/v2/bdr:V1PD96684_I1PD106685::I1PD1066850003.jpg/full/full/0/default.jpg
It is now returning a 404 coming from s3 client which cannot find the Works/ff/W1PD96684/images/W1PD96684-I1PD106657/I1PD1066530003.jpg resource.

we have the same issue with http://iiif.bdrc.io/image/v2/bdr:V1PD96685_I1PD105064::I1PD1051040006.tif/info.json where s3 returns:
S3 client failed for identifier Works/4f/W1PD96685/images/W1PD96685-I1PD105064/I1PD1051040006.tif >> 404

@MarcAgate can you look this so that we can finish the iiif server side of things? Note that some aspects of this bug are actually this other unrelated bug so don't bother with them

We got rid of the /image/v2 part of the url so http://iiif.bdrc.io/image/v2/bdr:V1PD96685_I1PD105064::I1PD1051040006.tif/info.json has become http://iiif.bdrc.io/bdr:V1PD96685_I1PD105064::I1PD1051040006.tif/info.json, which fails.
According to https://github.com/buda-base/buda-iiif-presentation/issues/28 http://localhost:8080/bdr:V1PD96685_I1PD105064::I1PD1050640006.tif/info.json is the valid url (replacing I1PD1051040006.tif by I1PD1050640008.tif which is the valid image name)
Therefore I think we can close this issue which has its cause in the manifest referring to a wrong image name.

ok thanks


Basic example should just become send-all-bids example

Also, the call to disableInitialLoad is missing in the "send all bids" example - find out why.
For example, if this always has to be called, how come it is part of the boilerplate and not just automatically handled for you?
Need to understand this better.

I believe that as a DFP configuration disableInitialLoad is within the publisher's purview and Prebid avoids having an opinion about it, other than requiring that it be set true as a means of interrupting DFP to allow for an header bidding auction.


NOC_7_01_WolframCA_simple potential bug

Hi, Dan
While following the example, I found a potential bug.
this.generate = function() {
    // First we create an empty array for the new values
    var nextgen = new Array(this.cells.length);
    // For every spot, determine new state by examing current state, and neighbor states
    // Ignore edges that only have one neighor
    for (var i = 1; i < this.cells.length-1; i++) {
      var left   = this.cells[i-1];   // Left neighbor state
      var me     = this.cells[i];     // Current state
      var right  = this.cells[i+1];   // Right neighbor state
      nextgen[i] = this.rules(left, me, right); // Compute next generation state based on ruleset
    }
    // The current generation is the new generation
    this.cells = nextgen;
    this.generation++;
  };

In the above code, var nextgen gets the length when it's created, but the initializing is done through a for loop, which starts at i = 1, therefore, leaving nextgen[0] undefined. In this particular example, it works fine because this.rules function returns 0 as default, but when I was implementing another version of this.rules function, it caused me a problem.
I am not an expert in Javascript, but changing as below fixed the issue for me:
 var nextgen = new Array(this.cells.length);
 for (var i = 0; i < nextgen.length; i++) {
  nextgen[i] = 0;
 }

Ah, this is indeed a bug!   Thanks, fixed now!


No reference to 'analysis'

There is no reference to analysis object in 'demos/androguard_ANALYSIS.py'. Should we remove this file?

I think most of the demo scripts are broken. It would be really nice to have working examples in a wiki or so...
related #96


Doubt on "pytorch-seq2seq/seq2seq/models/EncoderRNN.py"

if self.variable_lengths:             embedded = nn.utils.rnn.pack_padded_sequence(embedded, input_lengths, batch_first=True)   output, hidden = self.rnn(embedded)   if self.variable_lengths:             output, _ = nn.utils.rnn.pad_packed_sequence(output, batch_first=True)
Hi,
Why here goes two if self.variable_lengths?
And this code doesn't identify the h0, c0, is that means they default to zero?
Looking forward to your response. @kylegao91

@caozhen-alex we use nn.utils.rnn.pack_padded_sequence here when the input sequences are of variable lengths and we need to feed it to an RNN but you need to be able to get the output at the right time step. Without packing, you have to unroll your RNN to a fixed length which will get you a fixed length of output. The desired output should have different length, so you have to mask them by yourself.
For example:
>>> import torch
>>> from torch.nn.utils.rnn import pad_packed_sequence, pack_padded_sequence
>>> x = torch.LongTensor([[1, 2, 3], [7, 8, 0]])
>>> x = x.view(2, 3, 1)
>>> x
tensor([[[1],
         [2],
         [3]],

        [[7],
         [8],
         [0]]])
>>> lens = [3, 2]
>>> y = pack_padded_sequence(x, lens, batch_first=True)
>>> y       # tensor after packing
PackedSequence(data=tensor([[1],
        [7],
        [2],
        [8],
        [3]]), batch_sizes=tensor([2, 2, 1]))
>>> z = pad_packed_sequence(y, batch_first=True)
>>> z        # the original tensor
(tensor([[[1],
         [2],
         [3]],

        [[7],
         [8],
         [0]]]), tensor([3, 2]))

And as for the h0, c0, the LSTM handles hidden and cell states on it's own, which means the hidden state of the LSTM is actually (h0, c0), so we don't manually need to identify them.
For example:
>>> import seq2seq
>>> from seq2seq.models import EncoderRNN, DecoderRNN, Seq2seq
>>> vocab_length = 10
>>> max_len = 5
>>> hidden_size = 7
>>> encoder = EncoderRNN(vocab_len, max_len, hidden_size, bidirectional=True, variable_lengths=True)
>>> x = torch.LongTensor([[1, 2, 3, 0, 0]])
>>> output, hidden = encoder(x, input_lengths=[3])
>>> hidden.size()
torch.Size([2, 1, 7])    # since hidden_size was 7 we get two tensors h0, c0 of length 7
>>> hidden
tensor([[[-0.0396, -0.3460,  0.3471,  0.3422, -0.4044, -0.0072,  0.4332]],

        [[ 0.1341,  0.3066,  0.0607, -0.2081,  0.2334,  0.3933,  0.1236]]],
       grad_fn=<StackBackward>)
>>> h0, c0 = h[0, :, :], h[1, :, : ]
>>> h0
tensor([[-0.0396, -0.3460,  0.3471,  0.3422, -0.4044, -0.0072,  0.4332]],
       grad_fn=<SelectBackward>)
>>> c0
tensor([[ 0.1341,  0.3066,  0.0607, -0.2081,  0.2334,  0.3933,  0.1236]],
       grad_fn=<SelectBackward>)

I'm not sure the maintainer is still active on the project. I hope this helped :)

Closing this for now


Publish to Environment - (AL-Go for Github - AppSource App template)

Hi Guys
Good day,
May I ask for some help with the Publish to Environment to AL-Go for Github - AppSource App template.
I set it up to deploy the update to our SandboxUAT environment but it is throwing as an error.

and here is what it says in BC
"An extension with same app Id 'xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxx' already exists in the AppSource marketplace with name 'XPL Travel' and publisher 'Explorer Technologies Pty Ltd'. Please use the extension marketplace to install the extension from AppSource or use a new app Id for your per-tenant extension."
Thank you in advance
John

Hi,
there is a limitation.
You can't use as S2S connection. AppSource Apps can only be installed as dev.
There is PowerShell helper that can create the AuthContext to impersonate a user. That will cause the App to be installed as dev.
I'll looking it up and get back to you.

Hi Jonas,
Thank you for your response. Its a bit clearer now, but may ask for your help on how to apply or to use this(the link) on our github. I'm a bit new with the solution and there is a bit of a vague area for me.
Thank you
John

Hi Freddy, Hi Jonas
Good day,
Is it possible to have an option in the "Publish to Environment" to deploy as DEV or PTE?
Thank you in advance
John

Hi John,
AppSource Apps can't be published as PTE.
The only way to get AppSource App into Environments is by publishing them as DEV or install them through AppSource.
This has one big disadvantage.

But this has the obvious downside that your app will be uninstalled when the environment updates.

But if this is acceptable for your usecase.
You can create a AuthContext using the -includeDeviceLogin flag this will create an authentication as if a user would log in using vscode.
$authContext = New-BcAuthContext -includeDeviceLogin
New-ALGoAuthContext -authContext $authContext | Set-Clipboard

AL-Go understands that is AuthContext can only be used for DEV deployments and will act accordingly.
@freddydk will the token still expire or do you have any mechanism to automaticlly refresh the token?

The token will expire after ~90 days.
I did try to add a feature to store/cache the new refresh token, but GitHub workflows doesn't have permissions to write secrets.


Remove all [Obsolete] from public APIs

GA1.0 part is public facing methods.  Might be easier to stage over a few PRs. .
Beware of PAClient and Fx.Dataverse  dependencies.
Especially removing:

IExpression , IExpressionExtensions
FormulaTypeSchema? FormulaTypeJsonConverter?
IPowerFxScopeQuickFix ?   RecalcEngineScope
some of the redundant APIs on Engine. Moving towards CheckResult.

ParseFormulasResult.ParseFormulasScript needs something from Vamsi before we can remove that one.

moving back to 1.0 per discussion


If aider is unable to fix lint error, it will loop forever without adding or changing code.

Issue
Aider ask me that: Attempt to fix lint errors? y
if i say Y it will try and is unable to fix it then il will loop forever (It will eat token like Pacman will eat dot).
If i said no, it will not process with the code change, fix or else and will do absolutly nothing.
I'm trap for the whole time in my Vite, React project without any help from Aider.
Version and model info
Latest version today.
gpt-4o-mini

When I've faced this i have resorted to delete the '.aider.tags.cache.v3' folder, the '.aider.llm.history', '.aider.input.history' and '.aider.chat.history.md' files in the working directory. I'm sure there are other ways, but this works for me.

Thanks for trying aider and filing this issue. This doc may be helpful:
https://aider.chat/docs/troubleshooting/edit-errors.html

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


How to save converted watertight mesh on local ?

@fwilliams @clbarnes @eltociear @maurock @Layer3 Hello
I used point clouds to do create mesh and saved it as .obj file. You can find below the link to the mesh.
https://drive.google.com/file/d/1dPqnw84VP-L4GQFf6MYoAEHHEKTCfEoV/view?usp=share_link
As this mesh is not watertight, I used your library to convert it watertight
https://www.fwilliams.info/point-cloud-utils/sections/watertight_manifold/
import point_cloud_utils as pcu
v, f = pcu.load_mesh_vf("laptop.obj")
resolution = 50_000
vw, fw = pcu.make_mesh_watertight(v, f, resolution)
It worked without errors, but then it is not clear how I can save the converted watertight mesh.
Can you please help to see how save it on local directory somewhere "C:\Users\Me\Desktop\laptop.obj". Thanks in advance!

I found how to save a converted watertight mesh pcu.save_mesh_vf("C:/Users/Me/Desktop/watertight.obj", vw, fw)
Next step was to check if the converted watertight mesh is really  watertight. I used the code below to check it
import open3d as o3d
mesh = o3d.io.read_triangle_mesh("C:/Users/Me/Desktop/watertight.obj")
is_watertight = mesh.is_watertight()
if is_watertight:
print("The mesh is watertight.")
else:
print("The mesh is not watertight.")
Unfortunately the result was "The mesh is not watertight". Do you know how to fix this issue?

@fwilliams thanks for your quick reply. Below link is the input mesh and then I just use the code above to convert and save.
https://drive.google.com/file/d/1dPqnw84VP-L4GQFf6MYoAEHHEKTCfEoV/view?usp=share_link
I used the converted mesh and checked with Open3D if it is manifold. The outputs are below.
self_intersecting: True
vertex_manifold: True
edge_manifold: True
watertight: False
I also used Open3D function to compute cubic metre volume mesh.get_volume() and it said the mesh is not watertight. So I don't know if the issue comes from point-cloud-utils converting process or from Open3D library.

Is this mesh the output of the manifold process?
Could you also send the input?
On Wed, May 17, 2023 at 10:45 AM Hripsime Snkhchyan <
@.***> wrote:

@fwilliams https://github.com/fwilliams thanks for your quick reply.
Below link is the input mesh and then I just use the code above to convert
and save.
https://drive.google.com/file/d/1dPqnw84VP-L4GQFf6MYoAEHHEKTCfEoV/view?usp=share_link
I used the converted mesh and checked with Open3D if it is manifold. The
outputs are below.
self_intersecting: True
vertex_manifold: True
edge_manifold: True
watertight: False
I also used Open3D function to compute cubic metre volume mesh.get_volume()
http://url and it said the mesh is not watertight. So I don't know if
the issue comes from point-cloud-utils converting process or from
Open3D library.
—
Reply to this email directly, view it on GitHub
https://github.com/fwilliams/point-cloud-utils/issues/65#issuecomment-1551536596,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKH6AFSRONBRVNIGD7IW7TXGTQBBANCNFSM6AAAAAAYDQ5YNE
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Sent from my Commodore 64.

@fwilliams below you can find the links for input and output meshes, also the code I used to convert to watertight mesh.
https://drive.google.com/file/d/1dPqnw84VP-L4GQFf6MYoAEHHEKTCfEoV/view?usp=share_link   Input mesh
https://drive.google.com/file/d/1lOAbaIO8XBG3utwW2aVtJzvyRl0_gf4t/view?usp=share_link  Output mesh
import point_cloud_utils as pcu
v, f = pcu.load_mesh_vf("C:/Users/Me/Desktop/laptop.obj")
resolution = 50_000
vw, fw = pcu.make_mesh_watertight(v, f, resolution)
pcu.save_mesh_vf("C:/Users/Me/Desktop/watertight.obj", vw, fw)

Just took a look.
Indeed it seems like there are self intersections in some very small triangles. These are likely due to numerical errors. The input mesh is low quality which makes this a challenging case.
That said, the mesh is watertight, so if that's all you need then this might be good enough. If not, you can try remeshing or removing the self intersections (meshlab has some tools). Could you elaborate a bit more on your application?

Any updates on this? Anything I can help with?


Mechanism to sync server prefetch with client API calls

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5918
Description (What does it do?)

To keep server and client API calls in sync, we need a solution that warns us if API calls are made from the browser to fetch content that could have been pre-rendered on the server, or indeed we're making unnecessary API calls on the server to fetch content that is not in the page. In addition to the warnings, it would ideally offer code reuse between server and client and help with the development workflow, or be minimally intrusive to it.
This PR issues console warnings for API calls made during the initial page render that have not been prefetched on the server and populated into the React Query cache.

Waits for the document to be loaded and flags it on the query cache.
Wraps our useQuery() hooks with a function that checks for cached data at a given key.
Log a console warning if the document has not loaded and a key requested by a client component has nothing cached.
Triggers a check on document load for any queries prefetched but not requested in components during the initial load.

Prefetches API data on the server for:

some of the homepage (excludes resources, commented in code)
the department listing page

How can this be tested?

Do not prefetch a query that is needed during initial render, e.g. in frontends/main/src/app/departments/page.tsx, remove channelsKeyFactory.countsByType("department") from the prefetch array.
In the consoles expect to see warning:

['channel', 'countsByType', 'department'] Content was not prefetched on the server for query key needed during initial render

Prefetch a query on the server that is not needed for initial render, e.g. in frontends/main/src/app/departments/page.tsx add channelsKeyFactory.countsByType("random") to the prefetch array.
In the consoles expect to see warning:

["channel","countsByType","random"] Content was prefetched on the server for query key not needed during initial render

Additional Context

For discussion, comments below.

I tried a variety of approaches aiming at the initial goal of specifying the queries needed for a page in one place, prefetching all on the server, then having client components pull from this construct to be checked off; otherwise warnings logged. The issues here were first that queries are parameterized and often in waterfall, so we'd need a dependency graph that could pass results, but also had to be serializable so it could be shared between server and client.
DAG with serializable was quickly looking impractical and overkill for this purpose.
An issue with listing out the queries at page level is also that the may be called at any point down the tree by any component that will often be in use across pages. Although conceivably components could repeatedly call usePageQueries() which would return all the results for the page (they are cached), keying them for reusable destructuring in code quickly gets messy.
Listing out the API calls in the components and exporting as arrays for use in server components would be good, though a server component cannot import anything other than a React node from a client component, plus we'd need to follow the component tree to aggregate all calls.
Currently we have a lightweight approach that has the benefit of needed no change to the client components (these continue to use the custom hooks), though does not give us code reuse in specifying the calls. In the page (server component), the key factory methods are called directly to prefetch into the query cache.

Warnings are logged to the console but no fail fast / build time error.

This adds the logic to a function that replaces useQuery(). This allows us to encapsulate it and only change the useQuery import to our own, without needing to wrap all the custom hook key factory calls.

A problem here is that this does not cover the cases that we call the key factory methods directly, notably in ResourceCarousel, https://github.com/mitodl/mit-learn/blob/jk/5919-prefetch-mechanism/frontends/main/src/page-components/ResourceCarousel/ResourceCarousel.tsx#L202-L207,

Still to do - mechanism to warn if data is prefetched but not use (looking at that now)

Prefetching the testimonials, for example, though server rendered, did not cause the carousel to appear on load. There appears to be significant blocking time while the Slick library makes width calculations, the likely candidate for slow blocking time in performance results.

As an alternative to a custom wrapper around useQueries, I want to propose inspecting the query cache after first render.

This is a much cleaner approach to warning on any queries made on the client that have not been prefetched, but I've not been able to find a way to get it to work for the inverse without intercepting useQuery or otherwise wrapping the API methods - ie. warning on anything prefetched on the server that is not accessed during initial render. Both sides of the problem are perhaps equal in terms of impact to performance, particularly as the site grows and unnecessary queries become harder to spot.

Hierarchical key matching is a nice bonus (and a lot cleaner than stringifying the keys for matching!)

Why don't I use console.table() more!?

Separately Especially for some more complicated cases (like if we decide to prefetch search queries that depend on search parameters) might be nice to have a way for the server and client components to share the prefetches.

Totally - most my time looking at this has actually been looking for a solution here.  Ideally we'd specify queries and the dependencies between them declaratively, which requires some sort of graph spec. The problem is also that an "active" list of queries with state and holding values needs to be serialized for it to be shared between server and client - it's starting to look over engineered for our purposes. I'm sure we could pass as props though and let Next.js handle serialization.

This is a much cleaner approach to warning on any queries made on the client that have not been prefetched, but I've not been able to find a way to get it to work for the inverse

Scratch that - the queries have an observer count.

Thanks for the summary above. I had forgotten about the "warn on unnecessary prefetches" aspect. Glad observer count solves that.

An issue with listing out the queries at page level is also that the may be called at any point down the tree by any component that will often be in use across pages. Although conceivably components could repeatedly call usePageQueries() which would return all the results for the page (they are cached), keying them for reusable destructuring in code quickly gets messy.

Yeah. We're currently using the App router in a way that resembles Pages router, where all prefetching happens at the Page level. Presumably restructuring to use more server components could help with this, though that would be a big change (and might complicate our current testing approach).

Listing out the API calls in the components and exporting as arrays for use in server components would be good, though a server component cannot import anything other than a React node from a client component, plus we'd need to follow the component tree to aggregate all calls.

A possible workaround for that, btw, was having a separate queries.ts file per page, to be imported by both the client and the sserver component. But it does get complicated in the cases you mention.

All in all, I think the warning approach is pretty good.


Editable combo box sets bound value to null when itemsource changes

Describe the bug
I have an editable combo box which allows the user to select predefined items or set another item by typing in its name. The combox box ItemsSource is bound to a list of strings which is changed when action is taken by the user which changes the list of predefined strings. When the ItemsSources changes it appears that the SelectedItem is set to null. I am unable to re-type the same value, and clicking the drop down repopulates the value.
I'm pretty confused about what is going on...
Steps to reproduce the bug
Create 2 editable combo boxes.
Have one 1 combo box ItemsSource rely on the value of the other.
Enter a value like "1" in the combo box.
Change the value of the other combo box to trigger a changes of the items source
The value in the editable combo box is replaced with null and "1" can not be entered.
Expected behavior
For an editable combo box change the items source should not re-trigger the value bound to selected item or text to change.
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.5.2: 1.5.240404000
Windows version
Windows 11 (22H2): Build 22621
Additional context
No response

I am having a hard time understanding the repro steps. Could you share some code and xaml that demonstrates the issue?

https://github.com/SoggyBottomBoy/EditableComboBoxBug
The second combox (bottom) is editable so enter in a value in the box, then change the section of the first box (top)

Thanks. I can reproduce the issue.
As you said, there are two issues here:

When the ItemsSource changes, it resets the selection of the ComboBox. This usually makes sense, but in the case of an editable combobox, it probably should not happen.
The inner TextBox of the ComboBox retains its old value. Normally when a user enters a value into the TextBox, the ComboBox will use that for the selection. But, it relies on the TextBox's TextChanging to trigger that. In this case, if the text does not actually change, it won't trigger that logic. So in order to select the old value, the user has to intentionally change it to something else and then change it back.

Yep but I think item 2 is somewhat solved by item 1. I would say an editable combox should be expected to retain the value if the ItemsSource is changed, if the developer does not want this behaviour then it should be an explicit opt in by handling ItemsSourceChanged or similar.

Resolving as dupe of #10232


[Bug] 当处理一个非常大的数据时，发生内存溢出，并且be掉线

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
1.2.3
What's Wrong?
当我处理十几亿数据的时候出现了内存移除，并且be节点掉线并停止服务，下面时错误信息
I0414 16:26:50.484669 21338 daemon.cpp:289] Process regular GC Cache, Free Memory 0 Bytes
W0414 16:26:55.842762 22006 beta_rowset_writer.cpp:950] too many segments in rowset. tablet_id:45362 rowset_id:0200000000000041554b66730bc2563eccaa43479f792cb5 max:200 _num_segment:200 _segcompacted_point:0 _num_segcompacted:0
W0414 16:26:55.901852 22006 merger.cpp:170] failed to write block when merging rowsets of tablet 45362.954735494.85477ec08198b797-b0869f63c6cff1b4[res=[E-238]]
W0414 16:26:55.902809 22006 compaction.cpp:351] fail to do vcumulative compaction. res=[E-238], tablet=45362.954735494.85477ec08198b797-b0869f63c6cff1b4, output_version=[296-381]
W0414 16:26:55.902848 22006 tablet.cpp:1596] failed to do cumulative compaction. res=[E-238], tablet=45362.954735494.85477ec08198b797-b0869f63c6cff1b4
I0414 16:27:02.334146 22007 compaction.cpp:320] start vcumulative compaction. tablet=45362.954735494.85477ec08198b797-b0869f63c6cff1b4, output_version=[296-381], permits: 100
I0414 16:27:03.209165 22008 compaction.cpp:400] succeed to do vcumulative compaction is_vertical=0. tablet=49060.1136312067.ab42e1a65125268f-63fc503d24052c8a, output_version=[138-167], current_max_version=199, disk=/opt/doris/apache-doris-be-1.2.3-bin-x86_64/storage, segments=103, input_row_num=150000000, output_row_num=150000000. elapsed time=990.879s. cumulative_compaction_policy=SIZE_BASED, compact_row_per_second=151380
I0414 16:27:03.306368 22008 compaction.cpp:320] start vcumulative compaction. tablet=49060.1136312067.ab42e1a65125268f-63fc503d24052c8a, output_version=[184-199], permits: 5
What You Expected?
当发生内存溢出时，当前查询请求可以失败，但是be节点不能掉线，服务不能停止，在释放本次查询使用的内存后，可以继续为其他查询提供服务
How to Reproduce?
No response
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

you need set max_segment_num_per_rowset  > 200


Documentation update

Since 1.20.5 there had been changes in the requirements for compiling the plugin.
Can you please update the readme with the required mvn and java version?

Afaik, it does not require any specific java version or maven version. (You just need java 8+). I fixed the nms readme (it does not require 1.20.5 but 1.20.6). What's your problem exactly ?

Oh.
The first problem with mvn clean install is that the nms module for 1.20.6 is not recognized:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project shopchest-plugin: Compilation failure
[ERROR] /C:/Users/alexa/workspace/MC/ShopChest-GamesMC/plugin/src/main/java/de/epiceric/shopchest/nms/PlatformLoader.java:[102,62] package de.epiceric.shopchest.nms.v1_20_R4 does not exist

When I try to install the nms module explicitly first, the new EntityType.ITEM is not found.
The Problems because of those I thought it is the java version (Incompatible Version 65) came later when I tried all possible things.
For sure spigot 1.20.6 remapped is compiled and installed to the local maven repo.
The github token is in the maven config and valid.

Oh, I didn't update the package on GitHub so you need to build the nms artifact yourself (with the -DbuildNMS option).
I'm gonna investigate this real quick.

It runs fine for me with the -DbuildNMS option, java 21.0.1 and maven 3.9.7. I will upload the nms artifact to GitHub package anyway.

Thanks.
I wonder why the nms wont compile
[ERROR] /C:/Users/alexa/workspace/MC/ShopChest-GamesMC/nms/reflection/src/main/java/de/epiceric/shopchest/nms/reflection/FakeItemImpl.java:[46,30] cannot find symbol
[ERROR]   symbol:   variable ITEM
[ERROR]   location: class org.bukkit.entity.EntityType

But when it loads the package from github, it wont be a problem anymore. Maybe a task for the future me...
Thanks for the quick help!

Pretty strange indeed. I've updated the package and tested it, it works fine. You should be okay until 1.21 :D


[:mix] piece in lockfiles sometimes wrongly removed by mix blend.update

https://github.com/mimiquate/tower_error_tracker/actions/runs/12120866411/job/33790525642?pr=26

A PR created by Dependabot also suffered from this...

May not be an issue specific to blend, but mix?

I dug into this a bit and it seems to be reproducible just with mix...
Reported https://github.com/elixir-lang/elixir/issues/14067.


Native crash on Windows

On a Windows 10 x64, I have encountered the following problem:
# A fatal error has been detected by the Java Runtime Environment:
#
#  EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x00007ff8c5774f4d, pid=12008, tid=0x0000000000001eb0
#
# JRE version: Java(TM) SE Runtime Environment (8.0_121-b13) (build 1.8.0_121-b13)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (25.121-b13 mixed mode windows-amd64 compressed oops)
# Problematic frame:
# C  [ntdll.dll+0x34f4d]

hs_err.txt
The crash seems to happen in the reset function (or a potential native callee of it):
Java frames: (J=compiled Java code, j=interpreted, Vv=VM code)
J 12576  org.sqlite.core.NativeDB.reset(J)I (0 bytes) @ 0x00000000026549fb [0x00000000026549c0+0x3b]
J 23330 C2 org.sqlite.core.CoreStatement.internalClose()V (75 bytes) @ 0x0000000006b343b4 [0x0000000006b34100+0x2b4]

+1
sqlite 3.16.1 jdbc  on windows server 2012

Does it still happen in 3.19.x?

Not happened to me yet on the new version, so I am closing the bug for now. :)

The same happened to me. I am using version 3.19.3. I will switch to the latest version and see if it solves the problem.
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x000000006877ad90, pid=1264, tid=0x00000000000011a8
#
# JRE version: Java(TM) SE Runtime Environment (8.0_92-b14) (build 1.8.0_92-b14)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (25.92-b14 mixed mode windows-amd64 compressed oops)
# Problematic frame:
# C  [sqlite-3.19.3-00509d78-7bb9-44de-97d6-d12997c3f225-sqlitejdbc.dll+0x7ad90]

Java frames: (J=compiled Java code, j=interpreted, Vv=VM code)
j  org.sqlite.core.NativeDB.reset(J)I+0
j  org.sqlite.core.CoreResultSet.close()V+90
j  org.sqlite.jdbc4.JDBC4ResultSet.close()V+6
j  org.sqlite.jdbc3.JDBC3ResultSet.next()Z+105


Update logo

No more padding around logo
"f" is now more balanced/symmetric
additional sizes
use more rounded ubuntu font

Thanks again Martin!!


nth Ugly Number | DP

Add comment to get assigned to your desired language.
Follow Submission directory Structure for PR merge.
Submission Title
nth Ugly number | DP
Submission Type
Algorithm
Submission Description
Ugly numbers are numbers whose only prime factors are 2, 3 or 5. Given a number n, the task is to find n’th Ugly number.
Submission Directory
Algorithms => DP => nth_Ugly_Number =>  Filename.extension
Language

[x]  C++
[x]  C
[x]  Python
[x] Java
[ ] C#
[x] JavaScript

@swathi-vennela your language?

I want to contribute to this issue using C++ language, Please assign this to me.

@swathi-vennela your language?

@krishrahul98  Thank you, but I can't work on this.. I just wanted to encourage people to contribute to dp..

can i work on this issue?

I can work in python, Golang, C/C++, and JavaScript on this one.

@swathi-vennela your language?

@krishrahul98 Thank you, but I can't work on this.. I just wanted to encourage people to contribute to dp..

@swathi-vennela great

I want to contribute to this issue using C++ language, Please assign this to me. @krishrahul98 @swathi-vennela

@Nitish-web-nik Assigned for C++

can i work on this issue?

@PRAy-d your preferred language?

I can work in python, Golang, C/C++, and JavaScript on this one.

@sawyer1997 Assigned for Python, Go, C and Javascript

Assign me this for java,please.

Assign me this for java,please.

@verma-shivani Assigned

I want to contribute to this issue using Python  language, Please assign this to me.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/krishrahul98/DSA-Library/issues/221#issuecomment-717925817,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AROKLXHMDVWLJ4LOCYRVMMDSNAKXDANCNFSM4TBKFRFA
.

Hey ! i have gone through the issue an d finds it really interesting, i want to contribute the code, please assign me the issue in java.

@sawyer1997 Already someone is assigned for Java. So, I can't directly assign you to Java. I am assigning you for code with efficient time complexity. Just add efficient in your PR request and file name as well.
And don't forget to fill the PR template correctly. It helps a lot.

@om840 I have gone through your PR. Your code is with very high complexity and already someone is assigned for Python. So, I can't accept your PR directly. Please write an efficient approach and append efficient in file name.
And fill the PR template properly.

Hey ! i have gone through the issue an d finds it really interesting, i want to contribute the code, please assign me the issue in java.

@sawyer1997 Already someone is assigned for Java. So, I can't directly assign you to Java. I am assigning you for code with efficient time complexity. Just add efficient in your PR request and file name as well.
And don't forget to fill the PR template correctly. It helps a lot.

@krishrahul98 I guess I have bee tagged in wrong reply?

Hey ! i have gone through the issue an d finds it really interesting, i want to contribute the code, please assign me the issue in java.

@sawyer1997 Already someone is assigned for Java. So, I can't directly assign you to Java. I am assigning you for code with efficient time complexity. Just add efficient in your PR request and file name as well.
And don't forget to fill the PR template correctly. It helps a lot.

@krishrahul98 I guess I have been tagged in wrong reply?

@sawyer1997 I am sorry. My bad.

I can work in python, Golang, C/C++, and JavaScript on this one.

@sawyer1997 Assigned for Python, Go, C and Javascript

@krishrahul98 Please consider reviewing the PR, and merging the same.

I can work in python, Golang, C/C++, and JavaScript on this one.

@sawyer1997 Assigned for Python, Go, C and Javascript

@krishrahul98 Please consider reviewing the PR, and merging the same.

@sawyer1997 Done

Can I take up the C# language?

Can I take up the C# language?

@rachitmanas Assigned for C#
Please follow all guidelines.


Adds CD for the android emulator plugin.

Link to GitHub repository
https://github.com/jenkinsci/android-emulator-plugin
When modifying release permission
If you are modifying the release permission of your plugin or component, fill out the following checklist:
When enabling automated releases (cd: true)
Link to the PR enabling CD in your plugin
https://github.com/jenkinsci/android-emulator-plugin/pull/151/files
### CD checklist (for submitters)
- [X] I have provided a link to the pull request in my plugin, which enables CD according to the documentation.

### Reviewer checklist
- [ ] Check that the `$pluginId Developers` team has `Admin` permissions while granting the access.
- [ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
- [ ] If security contacts are changed (this includes add/remove), ping the security officer (currently `@Wadeck`) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it.

You're missing the github action to actually do the releasing

My bad.
Should be ok now.

https://github.com/jenkinsci/android-emulator-plugin/blob/6ebeed93dd6e66724962fc993769468b1b72158f/pom.xml#L123 should match <tag>${scmTag}</tag>, in the best case.

Thanks for your help, folks, and sorry for the back and forth, I think it's my first time ever. 🤷


Add Go Http Client a very popular bot

UA Examples:

User   agent
Version
Popularity

Go-http-client/1.1
1.1
Very common

Go-http-client/2.0
2
Common

Go-http-client/1.1   https://hstspreload.org/ checker; see https://sapphire.alexcohn.com/hsts.html
1.1
Uncommon

Go-http-client/1.1
1.1
Uncommon

Mozilla/5.0   (compatible; Go-http-client/1.1<EMAIL_ADDRESS>1.1
Uncommon

go-httpclient   v0.5.1
0.5
Uncommon

Go-http-client/1.1
1.1
Uncommon

Go-http-client/1.2
1.2
Uncommon

Go-http-client/1.1   - [handyCafe Filter/3.3.16]
1.1
Uncommon

PR adds two test cases.
Link to this repo tests: http://thadafinser.github.io/UserAgentParserComparison/v5/user-agent-detail/fa/0e/fa0e85a4-0f6f-4c13-b573-9d14c87cc2e2.html#modal-47a9cd06-e213-4882-bc34-db6aed664223

Coverage increased (+0.02%) to 99.97% when pulling 90ff54636076c484a722d8f56f200bbc4317591d on ayumi-cloud:Go-http-client into 880b9fa797401d14b28956442944c3daa70240ff on WhichBrowser:master.

not finished yet - still working on this

Fatal error: Uncaught Error: Call to a member function toArray() on string in /home/travis/build/WhichBrowser/Parser-PHP/src/Model/Browser.php:168

PHP Fatal error:  Uncaught Error: Call to a member function toArray() on string in /home/travis/build/WhichBrowser/Parser-PHP/src/Model/Browser.php:168

Stuck on this - not sure what the issue is going on? Any suggestions from anyone would be helpful.

Does not happen locally?
On 7 Oct 2020, 14:41 +0100, Ayumi<EMAIL_ADDRESS>wrote:

Stuck on this - not sure what the issue is going on? Any suggestions from anyone would be helpful.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@NielsLeenheer @mariotsi

Does not happen locally?

Just tested it locally and same thing happens, the repo seems to not like adding a custom bot code into the file:
src/Analyser/Header/Useragent/Bot.php

Found the solution now!

Fixed by efffe033df41eb448cf76faa2e7deeb05649211c

Fixed by efffe033df41eb448cf76faa2e7deeb05649211c


Implement: ChevronLeft2Small and ChevronRight2Small

Component Name: ChevronLeft2Small and ChevronRight2Small
Component Requirements: Hi all, I ran these 2 new icons by the team at a previous SDS team meeting! The team agreed we should add it.
Icons can be found on the Google Drive:

[x] ChevronLeft2Small
[x] ChevronRight2Small

Team(s) Requesting: CZ ID

Related tickets:

[ ] #531
[ ] #532

Closed via #547


drop down list get scrolled

Hello
when ribbon has overflow-x; then drop-down lists, and select go under ribbon and ribbon scrolls vertically. Can you help me?

https://github.com/olton/Metro-UI-CSS/blob/master/CONTRIBUTING.md#pull-request-guidelines


ConfigWnd > dont show editor/viewer config files if not needed

This happens if you got a standalone config. We should not show the standalone config in the dropdown for a page that doesnt need it (for example Snip Panel).
Also check for other instances.

Done.


integration: don't call rand.Intn in TestSTMConflict on 0

Fixes #4874

/cc @gyuho

lgtm

lgtm. thanks!


How to use tensorflow2 keras model on java?

i use keras to build my model on tf2
in tf1, keras.backend.get_session(), then create .pb file for java calling
please show me the solution of tf2

try this one

try this one
thanks, it's tf1 java api demo, but i need some demo that tf2 model turn to tf1 model

As mentioned in Note  here : : There is no libtensorflow support for TensorFlow 2 yet. It is expected in a future release. tf2 is not supported yet

As mentioned in Note here : : There is no libtensorflow support for TensorFlow 2 yet. It is expected in a future release. tf2 is not supported yet

got that, thank you


Tasks with local storage file references do not load files unless explicitly synced

Describe the bug
Description at Tasks with local storage file references does not hold. Quote:

In cases where your tasks have multiple or complex input sources, such as multiple object tags in the labeling config or a HyperText tag with custom data values, you must prepare tasks manually.
In those cases, you can add local storage without syncing (to avoid automatic task creation from storage files) and specify the local files in your data values.

One cannot add a local storage like that.
The files don't show.
I only managed to display files once I explicitly sync via adding Source Storage -> Local Files -> Sync.
This obviously creates unwanted duplicate tasks from the raw media files.
To Reproduce
Steps to reproduce the behavior:

Run Label Studio on Docker and use local storage
Create a single task json file with file references as illustrated in Tasks with local storage file references
Create a project in LS and Import the aformentioned json file
Tasks are loaded, but media files referenced are not shown

The referenced media files are correctly accessible in the docker container.
Expected behavior
Honour documentation at Tasks with local storage file references.
Environment (please complete the following information):

OS: Ubuntu 20.04
Label Studio Version 1.4.1

@tilusnet Could you please show your

env variables (LABEL_STUDIO_LOCAL_FILES_SERVING_ENABLED & LABEL_STUDIO_LOCAL_FILES_DOCUMENT_ROOT)
screenshot of how you setup Local Storage in LS settings
example of import json


[dr-autosync] during sync_recover, workload report error: Region is unavailable

Bug Report

What version of TiKV are you using?

v6.5.3
What operating system and CPU are you using?

Steps to reproduce

a. down backup dc and make cluster work in the async mode for more than 10h with workload running.
b. recover backup dc，restart workload hit error of  "Region is unavailable"
What did you expect?
no error reported
What did happened?
[2023/06/20 10:51:08.959 +08:00] [INFO] [utils.go:55] ["current status is "] [curStatus=sync_recover]
java -cp .:lib/mysql-connector-java-5.1.49.jar batch_hy_zd "tiup-peer.e2e-dr-auto-sync-5r-pref-tps-1809605-1-603:3390" "root" "" 30  ecasdb 20
java.sql.SQLException: Region is unavailable
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:965)
at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3933)
at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3869)
at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2524)
at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2675)
at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2465)
at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2439)
at com.mysql.jdbc.StatementImpl.executeQuery(StatementImpl.java:1365)
at batch_hy_zd.getMax(batch_hy_zd.java:193)
at batch_hy_zd.main(batch_hy_zd.java:69)
test cluster id:<PHONE_NUMBER>958436285

should set replication-mode.pause-region-split: true in async mode

ref https://github.com/tikv/tikv/issues/7945


Remove explorer menu navigation

In preparation for #3012.
Notes for @thibaudcolas:

It looks like the React explorer is currently using [data-explorer-menu-url] as the selector for the menu item for attaching the onclick event - this will need to be updated, as this attribute (and the corresponding URL) no longer exist. I'd suggest just adding a distinctive class name in wagtail/wagtailadmin/wagtail_hooks.py.
I've left the #explorer and .explorer-close container elements intact in wagtailadmin/templates/base.html, in case the React explorer is still using them - if not, these can be removed.
Likewise, I haven't touched the CSS, as I don't know which bits the React explorer is depending on - I'll leave this for you to clean up. It should hopefully all be contained in wagtailadmin/scss/components/_explorer.scss, except for the z-index declaration for .explorer in core.scss.
wagtailadmin/js/submenu.js included a bit of code (now removed) to close the explorer menu when a submenu (e.g. Settings) is opened; we'll need to ensure that the equivalent is in place for the React explorer.

Moving some of the tasks from the explorer PR to here (will likely transport them over to other PRs/issues later)
Code cleanup

[ ] HTML
[ ] CSS (https://github.com/torchbox/wagtail/blob/master/wagtail/wagtailadmin/static_src/wagtailadmin/scss/components/_explorer.scss)
[ ] JS
[ ] Python

Documentation

[ ] React/Redux code styleguide (action types with keyMirror, FSA or not, file structure)
[ ] Integrate React components in UI styleguide

Features

[ ] Better translation according to @jjanssen's research (jsi18n) (https://docs.google.com/document/d/1WImkcI1ORB5nj3FeNuVnkPIcjJTIKoMIhCV-Hqj2IEY)
[ ] Better date format according to our research (moment-django FTW!)

Tooling

[ ] Use import aliases instead of relative paths everywhere
[ ] npm packaging of Wagtail front-end https://www.springload.co.nz/blog/wagtail-cape-town-sprint/ https://www.npmjs.com/package/wagtail
[ ] Add front-end test coverage to Coveralls

Related work to address later

[ ] @kaedroho's page chooser refactor #3038
[ ] #1160
[ ] #3106

Related issues
Possible issues which can be closed after merging

[ ] Explorer menu scrolls with page content #2520

This should be ready to merge, compared to the initial work:

Rebased onto master, with the explorer merged.
Updated docs
Updated some tests
Clean up styles

All looks good to me! Merged in e73c97463f71717a42ed2f13d02e2ef42c071267 + parents.


Cannot use JPA repository inside of AFTER_MIGRATE callback

I'm using Flyway 7.11.3.
I'm using the Java API with Spring Boot 2.5.2. JDK version is 11.
Database version: PostgreSQL 13.2 (Debian 13.2-1.pgdg100+1)
I'm on Windows 10, database is inside a Docker container.
Here is my Flyway config inside my application.properties
spring.flyway.enabled=true
spring.flyway.group=true
spring.flyway.placeholder-replacement=false
spring.flyway.user=${spring.datasource.username}
spring.flyway.password=${spring.datasource.password}
spring.flyway.url=${spring.datasource.url}
spring.flyway.locations=classpath:migrations

Here is how i configure my callback:
@Configuration
public class FlywayConfiguration {

    private final BootstrapCallback bootstrapCallback;

    public FlywayConfiguration(
        @Autowired BootstrapCallback bootstrapCallback
    ) {
        this.bootstrapCallback = bootstrapCallback;
    }

    @Bean
    public FlywayConfigurationCustomizer flywayConfigurationCustomizer(){
        return configuration -> {
            configuration
                .callbacks(
                    this.bootstrapCallback
                );
        };
    }
}

Here is my callback class:
@Component
public class BootstrapCallback implements Callback {

    private final SomeServiceUsingJpaRepository someServiceUsingJpaRepository;

    public BootstrapCallback(
        // i had to use @Lazy to make injection work here.
        @Lazy SomeServiceUsingJpaRepository someServiceUsingJpaRepository
    ){
        this.someServiceUsingJpaRepository= someServiceUsingJpaRepository;
    }

    @Override
    public boolean canHandleInTransaction(Event event, Context context) {
        // i also tried with false
        return true;
    }

    @Override
    public String getCallbackName() {
        return this.getClass().getName();
    }

    @Override
    public void handle(Event event, Context context){
        // "no EntityManagerFactory set" error thrown here
        this.someServiceUsingJpaRepository.createSomeEntity();
    }

    @Override
    public boolean supports(Event event, Context context) {
        return event.equals(Event.AFTER_MIGRATE);
    }
}

I was expecting to be able to use my JPA repositories to insert/update data after the migrate operation is successful.
Migration is working fine, schema is created and logs indicate that everything worked fine. The exception only occurs during the AFTER_MIGRATE callback.
A java.lang.IllegalStateException: No EntityManagerFactory set is thrown 9 out of 10 times.
Also, if i disable the callback and i try to insert data at a later time, it works fine.
Current workaround is to use context.getConnection() and run raw queries, but it's really not practical in my use case.
Any idea why this is happening ?
Thank you...

This could be due to connections being exhausted but without a reproduction it is hard to tell. Could you provide a reproduction project?
Could you also try setting flyway.group=false

Closing until further activity


feat: replace current multi-file template approach with handlebars

✅ Checklist

[x] I have followed every step in the contributing guide (updated 2022-10-06).
[x] The PR title follows the convention we established conventional-commit
[x] I performed a functional test on my final commit

Changelog

removed all the *.tsx files in /page-studs directory
replaced those files with 3 *.hbs (handlebars) files
removed the "name picker" for template files and replaced it with a compiler for handlebars templates

Screenshots

💯

Thanks for the PR, it's an interesting approach to fixing the duplication problem. That being said the problem with the duplication isn't that it's more lines of code, but that it's not ideal in terms of DX. However it feels to me like this solution also comes with its own DX issues.
Which of these is better/easier?

Work on one index file, which is just a normal .tsx, paste changes into other index files when done
With the handlebars setup, either:

Work directly in the handlebars file and not get live preview
Generate a .tsx file from the handlebars file, work in that, paste changes back into the handlebars file when done

My gut feeling is that 1 is actually the better DX despite of course being far from perfect. But I've not worked with handlebars in this sort of context before so am open to having my mind changed and would be interested to hear what others think.

I also think handlebars will just slow us down, both in terms of perf and in terms of us maintainers when updating templates since we're not used to it.
It's easier for us to update stuff in the templates when they are a single file.

I thought about doing this switch after reading TODOs regading this issue.
Those are my thoughts:

when it comes to code highlighting / auto completion while writing template files, it still does not work because of react package not being installed in the project (maybe I did something wrong tho?)
copying content from one template to another CAN lead to mistakes such as forgotten changes and things not being prepared for the template
updating templates is not really different from the current approach - you just have one / two files instead of multiple copies and you can just use the {{#if withOption}} helper

I don't think that there even is something that can be 100% perfect in our case, though handlebars can open us to new options like:

inserting variables like project name inside of the template file (eg. changing page title from "Create T3 App" to <my project name>)
adding more template options to the CLI, like "empty project" (which I would personally like to have in the future)

that would mean generating eg. one more set of template files, this time without the AuthShowcase and other components

Overall I'm not a fan of current approach. The lack of auto completion and language server should not limit us that much - maintaining multiple copies and being limited to only pre-written code is kind of cutting us off from new development opportunities.
Nevertheless, if you want me to change something, I'm open to your proposals :wink:


Unable to create correct port listening for SRT and GB28181

!!! Before submitting a new bug report, please ensure you have searched for any existing bugs and utilized
the Ask AI feature at https://ossrs.io or https://ossrs.net (for users in China). Duplicate issues or
questions that are overly simple or already addressed in the documentation will be removed without any
response.
Describe the bug
Failed to create a listening port for SRT and GB28181 services.
Version
5.0-r3
Screenshots

Additional context
container is: registry.cn-hangzhou.aliyuncs.com/ossrs/srs:5
It's a tiny device with 8GB of RAM and a 4-core processor, and it works well on servers with more cores and memory.

my edited the wrong configuration file and should use docker.conf instead.


Remove footer

Overview
Remove the footer everywhere except the settings.
Requirements

Remove the footer on all pages.
Keep the footer on the Welcome page
Keep the footer on the Settings page.

Goals

We got the go-ahead from legal that we could potentially only show this footer in the settings section of the app, so technically we do not have to show it everywhere. There would be some soft- and hard-benefits of doing so:
Soft:
Better focus on the main content. The less information is on the screen, the easier it is for users (especially first time users) to identify the important information. The legal links are for most users definitely not something that they want to always have 1 click away. (obviously, it should not be 10 clicks either).
Hard:
For lists such as the transaction list, the legal footer can take up to 10-15% of the vertical screen estate. We have already seen with the change to the full-screen apps, that increasing the available screen estate of the main content can be quite beneficial.

Requirements
Remove the footer from:

Assets (Coins)
Assets (Collectibles)
Transactions (Pending)
Transactions (History)
Address Book
Apps

@lukasschor, hi, @dasanra is concerned that in Spain this might be illegal. Can we double-check?

@dasanra is there anything that I could use as a reference when talking to the legal team? I assume the legal team mainly looked at it from a European law perspective, but if there is some national regulation that would influence this we'd have to see if the national regulation would actually apply to us as we are not actively targeting the Spanish market (no localization etc.)

@lukasschor I was checking but it's not a Spain constraint only, is on the EU Cookie compliance:

Make it as easy for users to withdraw their consent as it was for them to give their consent in the first place.

In the footer we have the Cookie preferences, and clicking there you can open the banner again and switch to not allow using cookies after that. Hiding the footer which contains the quick button for this can be seen as make more difficult to find this setting change (I always studied that this button should be present for the user in the whole site) so thereby we could be not filling the Cookie compliance for EU law
https://gdpr.eu/cookies/

I understand. I can double check this again, but the legal team said that having the footer accessible in the settings is good enough (also considering the cookie preferences can be seen as "app settings"). And that there is no need to show the footer all the time when navigating the app.

@lukasschor, but the settings we have are safe settings only, not app-wide settings. Or does it also work? One cannot access them without creating/loading a safe. Probably for this case we should leave them accessible on the welcome page too.

@lukasschor, but the settings we have are safe settings only, not app-wide settings. Or does it also work? One cannot access them without connecting a wallet and creating or loading a safe. Probably for this case, we should leave them accessible on the welcome page too.

Yeah we should definitely keep the footer in the welcome page.

I reconfirmed with legal that it is fine to only display the footer in the settings and welcome page.


Dark reader doesn't work on the docs of gdax https://docs.gdax.com/

https://docs.gdax.com/
Even the toggle button is disabled.
Curious as to what the cause is.

Seems to work just fine for me.

Maybe it used to be dark, one of contributors decided to add it into Dark List 2 years ago https://github.com/alexanderby/darkreader/blame/master/src/config/dark_sites.json#L22

Well, it doesn't work, the gdax docs page is very bright (white) and Dark reader Toggle button is not clickable.

Yeah, that's because it is added into global Dark List. If you are sure, that the website is always bright by default, I will exclude it from that list.

I've replaced gdax.com record with www.gdax.com, so the docs should be inverted now (after 15 minutes).

Works well now, thank you 👍