PNG8s are always tagged as sRGB irrespective of options or actual colour space

Hello,
Thanks for the great tool! I’m testing Generator to replace some SFW scripts used to output CMYK imagery to PNG. Unfortunately, SaveForWeb is buggy when it comes to controlling the conversion to sRGB and embedding the profile...
In latest Photoshop 2015.5.1 (latest Win10), pngquant seems to be the default (contrary to wiki).
Irregardless of whether the options to embed ICC profiles are set through the Export As UI or through generator config file (or its absence), and irregardless of how they are actually set (to embed or not) - the output PNG8s always contain sRGB (and gAMA) chunks! That happens not only when one specifically sets the options to not include the profile on output, but also (sic!) when the image is not in the sRGB colour space at all (e.g. in ProPhotoRGB).
As a side-note, and to confuse things even more, latest Photoshop is not able to properly recognise sRGB PNG chunk in the files it writes so these PNG8 files open as Untagged RGB. PNG24 in sRGB are bloated with 2,6KB of iCCP, so they are recognised properly (but are bigger than necessary).
I’m not sure if pngquant shipped with Photoshop is compiled with colour management as the version shipped (2.1.1) is too old to print this info (warning starts with version 2.5, current version is 2.7.2).
Regards
m.

Since v2.6 pngquant can generate untagged files.

Problems still unfixed in 2017.0.1. Would this issue be more appropriate for reporting in https://github.com/adobe-photoshop/generator-core?


feat(dashboard): add provider's tabs

split provider between tabs
remove providerID from backend/frontend title
add Angular-Boostrap

LGTM

I like the new look.  This is similar to what I wanted to do with the multiple providers, but I'm lacking in the frontend department.

LGTM


Multliple for loops and block scoping

I am in the process of enabling proposed ESLint rules (#5456). block-scoped-var has 160 errors, the large majority of which look like:
  258:14  error  'i' used outside of binding context  block-scoped-var
  258:21  error  'i' used outside of binding context  block-scoped-var
  258:39  error  'i' used outside of binding context  block-scoped-var
  259:29  error  'i' used outside of binding context  block-scoped-var

These come from functions like https://github.com/omh1280/cesium/blob/master/Source/Core/Tipsify.js#L125, which contain multiple for loops and re-use the variable i or j.
Which of these solutions makes the most sense to have as a standard?

Always use unique loop indexes within a function (i, j, k,...)
Declare the index at the function-level scope prior to its first use. (E.g. saying var i right before a for loop)
Something else?

I'll make a PR with the changes as soon as we agree on a standard. Thanks!

Either is OK with me, but separate variables is probably more textbook as it reduces the "span" of a variable, at least in block-scoped languages.


Setting up Data for Mapping

Brief: Relatively open ended, may require some discussion. However, rendering should be fairly straightforward. time ~1-3 hours
Current State
Along with #1, we have to determine how the data is structured and formatted to render on the map itself. The data, at minimum should have long/lat coordinates to be able to plot it on the map.
TODO
Work on setting up the logic to map data -> markers

[ ] Download existing data, convert to JSON format, add rough long/lat coordinates
[ ] Render out the HQ locations with simple markers on leaflet

Since this one considerably overlaps with the work in #3, closing this one


unit tests as a consecutive GitHub action fail to publish results

I am trying to run 2 actions (see my yml file at the end of this write up)

Modify version numbers held in a source file
Run ceedling unit tests, and publish results with EnricoMi/publish-unit-test-result-action@v2 (note that we use a status check hold on PRs requiring this step to pass before merge)

a few things I've run into (I could be wrong with some of these)

The two workflows cannot run concurrently.  The version number bumping will cause a commit/push.  The unit tests and publish might work, but it is not happening on the HEAD of the branch and so the check will fail.
For the same reason as 1, if being run consecutively, the unit tests cannot be run before the version bumping
I do not want to run the version number bump on PR closed.  This would require access to commit directly to main, which I don't want to allow.  Nor do I want to run the version number bump on push, it would bump too frequently and require pulls from devs doing pushes to align with origin.
The unit tests and publish must be the last step in the PR process, or the GitHub status check fails.  (this is somewhat assumed, but partially tested)

This all results in me trying to run the 2 actions consecutively, with the version number bump happening first.  Everything works fine until the EnricoMi/publish-unit-test-result-action@v2 attempts to publish the results.  It is trying to publish the results against the original commit associated with the PR...the commit BEFORE the version number bump causes a commit/push.  In the attached screenshot, you can see the checkout for the unit tests correctly action happening on the new HEAD commit (the one created by the version bump action...you will have to just trust me that this is the correct commit), and the publish is attempted on the previous commit (again, you will have to trust me here...but you can at least see the SHAs are different).
Finally, the issue I am driving at (as described in the above paragraph).  If the unit tests are a consecutive action following an action that causes a commit/push, the publish fails as it tries to publish to a commit that is not the HEAD of the branch.  Can this be fixed?  If not, can someone think of other approaches to run both of these actions on my project?
Edit: A small side note.  I cannot use EnricoMi/publish-unit-test-result-action@v2 but must instead use v1.  Something wrong with the check receiving the publish, not sure and I don't remember specifics.  My screenshot show use of v2 while I was trying things, but I actually use v1 in my project.
Thanks
the yaml for my GitHub action
name: my_yaml
on:
  pull_request:
    types:
      [opened, reopened]

jobs:
  update_version_number:
    runs-on: ubuntu-latest
    steps:
      - name: checkout
        uses: actions/checkout@v3
        with:
          ref: ${{ github.event.pull_request.head.ref }}
          fetch-depth: 1

      - name: Update version.txt
        run: |
          [redacted 'sed' commands to modify files' version numbers]

      - name: setup for commit
        run: |
          git config user.name "GitHub Actions Bot"
          git config user.email<EMAIL_ADDRESS>
      - name: commit
        run: |
          git add [redacted file path]
          git commit -m "commit message"
          git push
  unit_tests:
    needs: [update_version_number]
    runs-on: ubuntu-latest
    steps:
      - name: Checkout repo
        uses: actions/checkout@v3
        with:
          ref: ${{ github.event.pull_request.head.ref }}
          fetch-depth: 1
      - name: Run tests
        uses<EMAIL_ADDRESS>      - name: Publish Unit Test Results
        uses: EnricoMi/publish-unit-test-result-action@v2
        if: always()
        with:
            files: build/artifacts/test/report.xml

It is trying to publish the results against the original commit associated with the PR...

You can set the commit via commit option, similar to the ref option of the actions/checkout action. See Options related to Git and GitHub section in the README.md.
I'd suggest a different setup. You bump the version on pull request open and re-open events. Committing the bump triggers a synchronize event. I'd move the unit test job into a separate workflow that runs on synchronize only. Bumping the version will trigger the unit test workflow. Further, any push to that pull request will also cause a synchronize.
Reopening, merging master into the branch and rebasing the branch onto master are more situations that need to be considered.
You should really move to version 2. Let's investigate that in a different issue.

Please reopen if needed.


building with make fails because local module is not used

After forking the repository for adding a new package nodes, the make command failed because it was still referencing the xk6-kubernetes package from the github repository:

github.com/grafana/xk6-kubernetes/pkg/nodes: module github.com/grafana/xk6-kubernetes@latest found (v0.0.0-20220330204656-f40616db6d32), but does not contain package github.com/grafana/xk6-kubernetes/pkg/nodes

Removing the --with option in the k6 build command in the Makefile solves the issue.
--- a/Makefile
+++ b/Makefile
@@ -19,7 +19,7 @@ clean:
 ## build: Builds a custom 'k6' with the local extension.
 build:
        go install go.k6.io/xk6/cmd/xk6@latest
-       xk6 build --with github.com/grafana/xk6-output-prometheus-remote=.
+       xk6 build

This behavior is unexpected as xk6 should add the current module to the list of replaced modules.

cc @javaducky


Add payment module

Codecov Report

Merging #356 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #356      +/-   ##
===========================================
- Coverage    99.06%   99.06%   -0.01%
===========================================
  Files           16       16
  Lines          535      534       -1
  Branches       152      152
===========================================
- Hits           530      529       -1
  Misses           1        1
  Partials         4        4

Impacted Files
Coverage Δ

packages/ckb-sdk-rpc/src/resultFormatter.ts
98.11% <ø> (ø)
:arrow_up:

packages/ckb-sdk-utils/src/address/index.ts
100% <ø> (ø)
:arrow_up:

packages/ckb-sdk-core/src/address.ts
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d219548...25af441. Read the comment docs.


README.md needs work

There's a fine template for a README.md at:
https://gist.github.com/PurpleBooth/109311bb0361f32d87a2

Just an FYI, adding a license is easy on GitHub:
https://help.github.com/articles/adding-a-license-to-a-repository/
Create a file through the GitHub web interface with the name LICENSE (all upper-case) and it lets you pick a license template


Is it possible to get typing event or indicator when a user in slack starts typing in a message

Description
(I want to get a webhook or event when a user in slack starts typing, is it possible to get a typing event)

:wave: Closing in favor of slackapi/node-slack-sdk#1742!


[feat] Z-wave logging and log to file enabled by default

Is your feature request related to a problem? Please describe.
Depends. Could be yes, could be no.
Describe the solution you'd like
I'd like to request that Z-wave logging and log to file for Z-wave events be enabled and set to Debug/Silly log level by default.
Describe alternatives you've considered
A forced UI element during initial set up of the AddOn that prompts a user with the choice to enable Z-wave logging and log to file. This UI element should include STRONG encouragement to turn on logging.
Additional context
With log rotation and file compression having been implemented, the logging capabilities of JS2Mqtt are quite robust. As such, the impact to the file system should be minimal even with Silly level logging. Below is an example screenshot showing logs that were created over a four day period at Silly log level for a Z-wave network consisting of 36 devices, three of which report energy consumption data every 30 seconds.

As you can see, the file size footprint is quite small.
In many cases, receiving helpful guidance via discord or this forum is predicated on a user's ability to provide tangible evidence of the issue at hand. Anecdotally, I've seen many users arrive at the #zwave channel seeking assistance only to be presented with the "do you have logs?" barrier.  If logging were on by default, the answer would be "Yes" 100% of the time.
Logging by default would also benefit issue identification In cases where it may not be practical or possible for the end user to recreate the problem. Examples include nodes that randomly disappear from the z-wave network, or inclusion errors which occur during the initial setup of an elaborate Z-wave network.
Feedback via logging will ultimately benefit the development of the AddOn and those who invest their time doing so. The fact that JS2Mqtt has such a robust logging system is, in fact, the reason why I switched to this AddOn. Thank you for your consideration.

@daphatty enable logging by default actually could cause some unexpected side effects expecially with zwavejs2mqtt logs as them have no limits and have no rotation. @blhoward2 @AlCalzone thoughts on this?

I think this is about the driver logs which already use logrotation. I absolutely agree with debug level by default. I can't count how often I've asked for logs to diagnose an issue, only to be presented with useless info level logging.

Done here: https://github.com/zwave-js/zwavejs2mqtt/pull/1746/files/bdb203df29a5b06c01d89323a87c185766f7ddf1..3ac098859af9a08a2b948b794820067b4633498b


Add Favorites page with tab navigation for multiple object types

Description

Added a Favorites page where users can view their favorited items.
Implemented tab navigation to allow users to switch between different types of favorites (e.g., stays, cars, experiences).
This feature enhances user experience by providing an organized way to view different categories of favorites.

Type of Change

[x] New feature

Checklist

[x] My code follows the project’s coding style
[x] I have performed a self-review of my code
[x] I have tested the new functionality to ensure it works as expected
[x] My changes generate no new warnings or errors
[x] I have checked my code and corrected any misspellings

Additional Information
This feature provides users with the ability to easily view their favorites by type, using a tab-based navigation system.

:tada: This PR is included in version 1.39.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


News Flash API

currently no pagination in News Flash API
(See this issue in FE)
Hence we want to modify News Flash API as described here, without changing current functionality.
If current functionality is changed, please coordinate with SejoB ( FE  tem) for adjustments needed in FE of current API.

@ziv17 this is currently top priority.

Also. Previous BE volunteer working on this and talked to SejoB (Sergey) wrote the following:

relevant pr that removes unused API: https://github.com/data-for-change/anyway/pull/2644/files

Hi @atalyaalon ,
The PR that I prapare should build upon PR #2644? (or it will be merged before that PR?)
Which news-flash APIs, or URLs are included in the issue?

@ziv17 I'm working on merging it today, so you'll build upon it (After merge)
This issue is on API urls in /api/news-flash
Note that exist a specific url of specific id: /api/news-flash/<int:news_flash_id>
As mentioned we want to change this api and make sure we're adding the offset.

@ziv17 merged :) you can use dev branch

Hi @atalyaalon ,
Do we want to keep both offset and pageNumer (and limit with pageSize)?
If not, to deprecate offset and limit?

@ziv17 I suggest coordinating this decision with Sergey.
We can deprecate some, but make sure we're either backward compatible OR that we modify FE and BE at the same time.


protein acetyltransferase activity grouping term

Could we have some structure  under:
http://www.ebi.ac.uk/QuickGO/GTerm?id=GO:0016407#term=children
I'd like a grouping term for protein acetyltransferases. This is primarily so that we can
group the protein acetyltransferases so we can have a "has_substrate/has_direct_input"
prompt for an extension for these terms in our curation tool
There is a term
id: GO:0034212
name: peptide N-acetyltransferase activity
namespace: molecular_function
def: "Catalysis of the acetylation of an amino acid residue of a peptide or protein, according to the reaction: acetyl-CoA + peptide = CoA + N-acetylpeptide." [GOC:mah]
is there any reason this can't be protein in the primary term name?
All of the protein acetyltransferases need grouping under the new parent, but some (for instance the histone lysine acetyltransferases also need to be under
id: GO:0034212
name: peptide N-acetyltransferase activity
and they are not currently.
I'm confused about some of the acetyltransferases which refer only to amino acids, are these always protein acetyltransferases, or can free amino acids be acetylated?
Reported by: ValWood
Original Ticket: geneontology/ontology-requests/11815

Hi David,
Is this one easy? I am waiting on it  to add a term to one of our config files to specify when annotations extensions are required in the curation tool.
Cheers,
Val

Hi Val,
I would prefer to keep the name as is because although this term is not in EC, the child peptide alpha-N-acetyltransferase activity EC:<IP_ADDRESS> is and it uses the peptide nomenclature with the protein nomenclature as a synonym. Right now the structure we have pretty much follows EC.
It also appears that the enzymes in the superclass can work on free amino acids. See PMID:21936773 for an example. Any reason why you can't add the annotation extension requirement to each of the appropriate terms that currently exist? I'm not sure what a new grouping term would do for us.
-D

hi David,
Wouldn't it be useful to be able to find all of the acetyltransferases which are known to acetylate proteins?
Say you wanted to look for candidate acetyltransferases?
I can do it the other way., but to indicate my problem, I don't know how to.

I found the term I was asking for!
GO:0006473	protein acetylation
ignore me!


Suggestion: Checkbox to override operational state.

First a big thank you for making this nice plugin !
But sadly its not useable for me and maybe some other people because there is no way to override the operational state check.
Why:
I use the PSU Plugin to switch off the power of my printer when its not in use (relay) so the Printer is not in an operational state and the sheduled print will not be executed. There is allready a option to send a G Code or Systemcommand like "psucontrol:on" before starting the print that would my printer turn on and bring it to a operational state but this command is not  executed because the printer is not in operational state ...
So it would be nice to have a checkbox to override the check ...
Or the better way a checkbox that the "before printing" G Code and Systemcommands are executed without a check then wait lets say 10 seconds and after that do the operational state check and start printing.
Thank you very much !
Patrick

You mean powering on with psu control prior to starting? Maybe this will help?
https://github.com/jneilliii/OctoPrint-PrintScheduler/wiki/Helpful-System-Commands

Thank You !!!
And sorry that i have not seen the wiki article before i post :-(
Now its working :-)


⚠ Bofrost.lu has degraded performance

In 939c8fe, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1662 ms

Resolved: Bofrost.lu performance has improved in c856c95 after 24 minutes.


remove apidocs/layout after jekyll build

Proposed changes
I made a mistake in #1357. I removed apidocs/layout from the source and not from the output of jekyll build. It's now fixed, and it fixes broken links for #1068.

@mstanleyjones, @johndmulhausen
Can someone merge it please?

@aduermael please resolve the conflict.

@mstanleyjones I resolved it!


net/smtp: deprecate CRAMMD5Auth

Dear @golang team,
Can you remove old unsecure CRAM-MD5 from the code?

https://github.com/search?q=repo%3Agolang%2Fgo+cram-md5&type=code

It is unsecure:

https://tools.ietf.org/html/draft-ietf-sasl-crammd5-to-historic-00
https://tools.ietf.org/html/draft-zeilenga-luis140219-crammd5-to-historic-00

Time to add SCRAM-SHA-*(-PLUS) supports.
Latest IMAP RFC speaks about:

https://tools.ietf.org/html/rfc9051

Thanks in advance.

We cannot remove it as that would be a break in backwards compatibility
maybe we can mark it deprecated
@golang/security @bradfitz

Hello, I have a WIP patch to add SCRAM-SHA-256 support. I tested it against Postfix with SMTP AUTH through Dovecot SASL.
The SCRAM algorithm requires pbkdf2 and according to  RFC 5802 section 5.1 we have to apply the SASLprep profile [RFC4013] of the "stringprep" algorithm [RFC3454]. Since RFC 8265 obsoletes RFC 4013 I think we can use it that is already implemented in golang.org/x/text/secure/precis.
So we need the following dependencies:

golang.org/x/crypto
golang.org/x/text

are they acceptable for net/smtp ?

@drakkan: Nice :)
It is possible to support SCRAM-SHA-1/SCRAM-SHA-1-PLUS, SCRAM-SHA-256/SCRAM-SHA-256-PLUS, SCRAM-SHA-512/SCRAM-SHA-512-PLUS, SCRAM-SHA3-512/SCRAM-SHA3-512-PLUS?
Not only 256.
For examples (more at the next link):

Exim uses GNU SASL and support TLS Channel Binding
Cyrus-SASL has more supports than Postfix/Dovecot

All details here:

https://github.com/scram-sasl/info/issues/1

@drakkan: Thanks for your reply!
For example, SCRAM-SHA-1 and SCRAM-SHA-1-PLUS are used by default since a very long time by XMPP, you can see here:

https://datatracker.ietf.org/doc/html/rfc6120 (March 2011)

To have a real compatibility with all products, it is needed to support SCRAM-SHA-*(-PLUS) included SHA-1.
Of course, it is better to use SCRAM-SHA-1 than CRAM-MD5/DIGEST-MD5/LOGIN/PLAIN.
Some products which support SCRAM-SHA-*(-PLUS) and SCRAM-SHA3-512(-PLUS):

https://github.com/scram-sasl/info/issues/1

About Channel Bindings -> RFC 9266: Channel Bindings for TLS 1.3:

https://datatracker.ietf.org/doc/html/rfc9266

Little details, to know easily:

tls-unique for TLS =< 1.2
tls-exporter for TLS = 1.3


BABE implementation Phase 1

BABE Implementation
https://github.com/w3f/research/blob/master/docs/polkadot/BABE/Babe.md
The BABE implementation is similar to Aura, but uses a VRF for selecting slots instead of a round-robin. The VRF is meant to be computed on the slot number and some global, per-epoch, collaborative randomness. In the first phase of implementation, we will not use the randomness. We will use the Schnorrkel VRF and sr25519 signatures.
For now, we can define the BABE seal signature type as BabeSealSignature { public_key, vrf_proof, signature }
BABE block signing process:

sign (epoch_randomness, slot_number) with VRF and stop if it is not below threshold. This produces a proof if it does.

propose a block (we'll call the header after this step pre_header)

add a DigestItem::Seal(slot_number, BabeSignature {public_key, vrf_proof, signature })) to the proposed header. The signature should be a regular schnorrkel signature on some message incorporating pre_header,slot_number,vrf_proof. One example would be (pre_header.hash(), slot_number, vrf_proof).encode().

BABE block verification process (similar to Aura)

check that the last digest item is a DigestItem::Consensus([b'B', b'A', b'B', b'E'], msg), where msg decodes to a (slot_number, BabeSignature)
check that the public key is actually an authority
check the VRF proof. discard if bad
check the full signature on the header via the same process as used for signing.
the rest will be similar to Aura

Just an FYI, a Boneh Lynn Shacham signature is also a VRF. If substrate is planning to use BLS12-381 public keys as consensus keys in GRANDPA. You can use the same key as your VRF key for BABE.

We know, and I put Ouroboros-style VRF output methods into our BLS crate, but the schnorrkel VRF seems preferable here..
In the VRF use case, there are cofactor concerns which look secure, due to how Michele Orru handled hashing-to-the-curve in BLS12-381, but makes hashing-to-the-curve slow.  I would ideally dig more into exactly how the miller function and pairing behave outside the prime order subgroup too, just for my own peace of mind before using BLS as a VRF.
I actually favor sampling block production delays from a Poisson distribution seeded by the VRF, not checking each slot number.  At present, we check each slot number though, so schnorrkel::Keypair::vrf_check_n_sign is a much faster VRF than BLS.
We want small block producers eventually, and originally designed for them, in which case we gain nothing from BLS aggregation for VRF use case.  We'd gain if we want non-winner proofs, but we achieve that better by sampling block production delays from a Poisson distribution seeded by the VRF.  I added sound batch signing and batch verification tooling to the schnorrkel VRF for the non-winner proof case already.

Those reasons sounds sensible!

This has long been complete.


[WIP] Update cli-utils to v0.27.0

This is a test to make sure kpt can adopt the latest cli-utils. Version v0.27.0 is not out yet, but we can release it soon if all goes well here.
Major changes:

No default reconcile timeout (wait until cancelled)
No default prune/delete timeout (wait until cancelled)
Always wait for reconciliation after apply/prune/delete (previously only waited if there were dependencies, causing more than one apply task)
Send WaitEvent for every object
Added deletion prevention annotations
Context cancel/timeout now sends an error and event
Update K8s libs to v0.22.2
Update kyaml to v0.12.0
Printers moved from cmd to pkg

This will most notably change the output and behavior of kpt live apply/status/destroy.

Note, I ran into several bugs with the Makefile while trying to build this.

go-licenses install is broken
when updated, go-licenses modifies a bunch of files on master, like yamls
golangci-lint errors on thirdparty files

License issues fixed by https://github.com/GoogleContainerTools/kpt/pull/2583

Found a bug with apply-time-mutation: https://github.com/kubernetes-sigs/cli-utils/issues/481 (probably pre-dates this update tho)

Duplicate of https://github.com/GoogleContainerTools/kpt/pull/2616


HDDS-6172:  EC: Document the Ozone EC

What changes were proposed in this pull request?
Updated the doc for EC
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6172
How was this patch tested?
NA

Updated the initial version of the doc. Please review!

Thank you for the docs @umamaheswararao! I have added a few minor formatting-related comments.

Hi @umamaheswararao,
thank you for writing the documentation parts for the EC feature. I have added a couple of inline comments mainly for spelling issues, or where I have not understood well the sentence for the first read. (It might be because of my non-native english  skills, so I might not be right everywhere).
In general I would like to ask you to proof read the text one more time and please take care of some inconsistencies in writing different names. What I found inconsistent is the mixing of lower/uppercase forms like:
ec vs Ec vs EC
erasure coding vs Erasure coding vs Erasure Coding
replication config vs Replication config vs Replication configuration mixed with an ec prefix sometimes
At some points while I was reading I really missed an article in front of some words, and sometimes I felt the one I see is not really necessary. Again this can be my non-nativeness, and you might be perfectly right with the usage or lack of the article, hence when you read the text again, please consider this, and if articles are really missed or if they are not needed then please fix it.

@fapifta I totally agree that there are lot of places I used different formats as you mentioned. I did not really focused on that EC and Erasure Coding or EC Replication Config or EC replication configuration(I meant to say it's erasure coding configuration, but indirectly it's bringing inconsistencies for readers probably) is creating some in consistencies. As a review reader, I feel your views are correct than my biased view :-)
I changed most of the placed to be in consistent now. I still used Replication Config in place to tell that an interface.
Thanks for the reviews. Yeah we can continue improve as we need few mores updates to this docs as we may need to update few other configs.

Thank you @umamaheswararao +1 on committing it, after we discussed with @JyotinderSingh the hugo vs simple markup of images as well.


Reproduce MSDNet paper's results

Hi @gaohuang,
I have been trying lately to reproduce the results from the MSDNet paper, but I could not get the pretrained model's accuracy. I would very much appreciate if you could check if the following setup (for k=4) is correct:
th main.lua -dataset imagenet -data <imagenet_dir> -gen gen -nGPU 4 -nBlocks5 -base 7 -step 4 -batchSize 256 -nEpochs 90

vs.
th main.lua -dataset imagenet -data <imagenet_dir> -gen gen -nGPU 4 -nBlocks5 -base 7 -step 4 -batchSize 256 -retrain msdnet--step\=4--block\=5 --growthRate\=16.t7 -testOnly true

The discrepancy in accuracy ranges from -1% (1st classifier) to -6% (last classifier) in top-1.
According to your paper:

On ImageNet, we use MSDNets with four scales, and the ith classifier operates on the (k×i+3)th layer (with i=1, . . . , 5 ), where k=4, 6 and 7. For simplicity, the losses of all the classifiers are weighted equally during training.

[...]

We apply the same optimization scheme to the ImageNet dataset, except that we increase the mini-batch size to 256, and all the models are trained for 90 epochs with learning rate drops after 30 and 60 epochs.

Am I missing something in the training parameters for Imagenet?

Hi @gaohuang,
I was wondering if you have had any ideas on what could have gone wrong in the reproduction of the paper's results.
Is there a way to double-check the hyper-parameters of the distributed pretrained model? Could this be a consequence of training on multiple GPUs?
I would greatly appreciate your reply.


How to Justify selected text ?

What is the equivalent of Nano's ^J for justifying text in Micro ?

Also Thank you very very much for creating a beautiful text editor like this. ❤

I believe it is a work for plugin. @taconi does prettier https://github.com/taconi/plugin-channel/issues/37 solves this?

The prettier plugin uses the prettier tool and I know that it formats markdown files, maybe this plugin with some config help to solve this. The other plugin with the same name also uses prettier if the other one helps.

Seems kinda annoying that the solution is to install a plugin that depends on a tool written in node.js. I tried to write a plug-in that would do that, but could not figure how to access util.StringWidth from Lua code (which would be necessary to figure out how long a string is, because Lua's string functions don't care about UTF-8).

I tried to write a plug-in that would do that, but could not figure how to access util.StringWidth from Lua code (which would be necessary to figure out how long a string is, because Lua's string functions don't care about UTF-8).

We can add exporting util.StringWidth to Lua, if needed. It should be trivial to implement.
Or perhaps you can get by with using the buffer cursor's GetVisualX() method, which uses util.StringWidth underneath?

That sounds like it would be a reasonable addition in general, as, for example, anyone who would want to write a plug-in that prints or outputs a table would also want to know the width of strings of text.


Feature/#2807

Related issues

closes #2807
Short description and why it's useful

Discount code' input is bigger, so the user can see what he enters.
The button 'Apply' is smaller and consistent with the whole view.
Screenshots of visual changes before/after (if there are any)

Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle

[x] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
[ ] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
[ ] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[x] I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and currently important rules acceptance

[x] I read and followed contribution rules
[x] I read the TypeScript Action Plan and adjusted my PR according to it
[x] I read about Vue Storefront Modules and I am aware that every new feature should be a module

Thanks! Great job


M11209309_M11209306_1120 Practice

with M11209309
https://github.com/raymundlin/threathunting202309/blob/main/M11209309%2CNick333567.yaml
Checks

[x] Your YAML file has required fields as listed in Specs
[x] All checks have passed yaml-lint passed
[x] You agree to contribute your work under MIT license

only cloudstorage done right. shodan query is not shown. firepit not done


Make Pagefind available as a Rust library crate

Hello! I currently use the Node API to index custom files (EDN, in particular). It takes around 3 minutes to index 1100 files. I imagine that doing this in Rust would be much faster. Since pagefind is written in Rust, would you consider exposing a Rust API for custom indexing? Thank you!

👋 Hey @holyjak
This is definitely something that could be exposed! 🙂
One note though — the 1.0.3 does have a performance issue with the API indexing files. If you give 1.0.4-beta.0 an install you should see much-much-much better performance.
Sorry about that! I'll look at preparing a release soon.

You were right, the 1.0.4 beta is done in 5 sec. Amazin!

👋 Forgot about this issue! This has been implemented in v1.3.0 :)


Submit a budget request for event 3

What
Estimate total cost for event 3 and submit request to DSP SMT for approval.
Why
To get budget sign-off so we can proceed with procuring suppliers (platform)
Who needs to work on this
Kelly
Who needs to review this
Imran, SMT, DD, DSP
Done when

[ ] costs have been estimated
[ ] estimate has been shared with SMT
[ ] decision has been made and shared with squad

tea/coffee/merch and lunch for budget request

Kelly to request £300 for event 3 to cover costs

Blocked whilst awaiting a response from SMT.


XGB independent tree shap for model loss

Hi! Just a question here as I don't know where to ask. I am wondering if there are plans to include the independent tree shap algorithm for model loss in the XGBoost official code (just like the shap values and shap interaction values)? Thanks

There are not plans to port that into the XGBoost code base right now. I think it is better to focus on a single solid C++ implementation than try and maintain lots of implementations in each model library.


Auto Pre-events (Or something like that)

Describe your problem here.
Can an event be triggered automatically as a precursor to another?
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No

Explain more please my brain is confused.

like if it sees an event coming up, itll wait until a certain amount of time before said event, and do other script or event shid

Just use curStep

Yes but I’m lazy, also give an example lmao
On Mon, Feb 21, 2022 at 7:56 PM frantastic24 @.***>
wrote:

Just use curStep
—
Reply to this email directly, view it on GitHub
https://github.com/ShadowMario/FNF-PsychEngine/issues/5483#issuecomment-1047353114,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APKAJYLNSI6M2HNFFQAGZZTU4LUMFANCNFSM5O5SROQQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Mouse cursor is incorrect in Lumo

The style module for vaadin-select-text-field is loaded before the style module for vaadin-text-field, causing the wrong cursor property value to be applied for the input-field part.
Happens here for example: https://demo.vaadin.com/invoice-editor-app/
The “Employee” select and the currency select (below the grid) use the text cursor.

This is caused by importing bower_components/vaadin-grid-pro/vaadin-grid-pro-edit-column.html.
Here's a minimal test for reproducing the issue:
<!doctype html>
<html>
  <head>
    <script src="bower_components/webcomponentsjs/webcomponents-loader.js"></script>

    <link rel="import" href="../../bower_components/vaadin-select/vaadin-select.html">
    <link rel="import" href="../../bower_components/vaadin-grid-pro/vaadin-grid-pro-edit-column.html">
  </head>
  <body>
    <vaadin-select value="Item">
      <template>
        <vaadin-list-box>
          <vaadin-item>Item</vaadin-item>
        </vaadin-list-box>
      </template>
    </vaadin-select>
  </body>
</html>

With following bower dependencies:

vaadin/vaadin-select#master
vaadin/vaadin-grid-pro#master

The order of the above 2 imports doesn't make a difference.
When testing locally in Chrome using above setup, I am able to currently reproduce the issue seemingly 100% of the time. But I'm pretty sure that this isn't 100% deterministic, since when I was testing with slightly different code (but pretty much same important imports in same order) on a small percentage of page reloads the issue did not always happen. So I think there's some randomness involved depending on in which order the browser happens to finish loading some of the imports (at least when the app isn't bundled).

Import of vaadin-grid-pro/vaadin-grid-pro-edit-column.html can be swapped for one of the imports it contains to still reproduce the issue.
Basically importing vaadin-grid-pro/theme/lumo/vaadin-grid-pro-edit-select.html causes the issue because that contains a theme-for="vaadin-select-text-field" which ends up including the lumo-text-field styles again (from bower_components/vaadin-text-field/theme/lumo/vaadin-text-field-styles.html via some nested style includes) into <vaadin-select-text-field>.

Here's the import hierarchy for the related styles:

bower_components/vaadin-grid-pro/vaadin-grid-pro-edit-column.html

bower_components/vaadin-grid-pro/theme/lumo/vaadin-grid-pro-edit-select.html

bower_components/vaadin-grid-pro/theme/lumo/vaadin-grid-pro-edit-text-field.html

bower_components/vaadin-text-field/theme/lumo/vaadin-text-field.html

bower_components/vaadin-text-field/theme/lumo/vaadin-text-field-styles.html

<dom-module id="lumo-text-field" theme-for="vaadin-text-field">

<dom-module id="lumo-grid-pro-edit-text-field" theme-for="vaadin-grid-pro-edit-text-field">

<style include="lumo-text-field">

<dom-module id="lumo-grid-pro-edit-select-text-field" theme-for="vaadin-select-text-field">

<style include="lumo-select-text-field lumo-grid-pro-edit-text-field">

The problem is mainly here vaadin-grid-pro/theme/lumo/vaadin-grid-pro-edit-select.html#L18
<dom-module id="lumo-grid-pro-edit-select-text-field" theme-for="vaadin-select-text-field">
  <template>
    <style include="lumo-select-text-field lumo-grid-pro-edit-text-field">

The lumo-grid-pro-edit-text-field  also includes <style include="lumo-text-field"> which causes the cursor issue, because it now comes after lumo-select-text-field styles.

@Haprog thanks for pointing out, I suspected it could be something like this.
Will submit a PR for Grid Pro to remove duplicating lumo-text-field styles.

@web-padawan
But I think the lumo-text-field is still needed for the
<dom-module id="lumo-grid-pro-edit-text-field" theme-for="vaadin-grid-pro-edit-text-field">

here: https://github.com/vaadin/vaadin-grid-pro/blob/master/theme/lumo/vaadin-grid-pro-edit-text-field.html#L6
I think best fix would probably be to refactor that file, so that there's a separate:
<dom-module id="lumo-grid-pro-edit-text-field" theme-for="vaadin-grid-pro-edit-text-field">
  <template>
    <style include="lumo-text-field">
  </template>
</dom-module>

and after that the <dom-module id="lumo-grid-pro-edit-text-field" theme-for="vaadin-grid-pro-edit-text-field"> with only the inline styles (without the lumo-text-field include for when lumo-grid-pro-edit-text-field is used as a style include).


ninja's configure.py doesn't confirm features before it tries to use them; uses hardcoded OS list

I was trying to get ninja to build on an old version of FreeBSD 10 which lacks ppoll(2) support, and unfortunately it didn't have it. Instead of checking for the support (like autoconf would have potentially with well-written tests), ninja's configure.py assumed that the support was always present. I had to bypass the auto-detection in order to force pselect support use.
I think that it's good to have sane defaults and the like, but it should be verified, similar to what autoconf does, to ensure that the project is easier to port to versions with OS-specific features.

Hm ... not sure we should try to re-implement yet another build system within configure.py. Maybe it would make sense to provide a build file for a known system like CMake which could be used as an alternative for building ninja.


Repeatedly mention that .symbols.nupkg are legacy

If you Google "symbols nuget package", the first result is this legacy page. @Mikejo5000 do you know if it's possible to fix this so that Google returns the new symbols format instead?
It's easy to miss the "Important" warning. I tried to add more hints throughout the page that this information is legacy and has been replaced.

I am not sure.

I see 2 results and 2nd one is the newer .snupkg version.  Not sure why we need to re-direct? We do need the old page as well.

Will creating a different URL for the old symbols doc and creating a redirect from the old URL help?

That could work!

That sounds good to me too. Let’s do that in a separate PR though since this one is ready to merge in.

Agree. Merge it!


Source code management functions

Issue Type: Feature Request
There is a problem with your source code management function, and you have encountered an error when submitting to github
VS Code version: Code 1.22.2 (3aeede733d9a3098f7b4bdc1f66b63b0f48c1ef9, 2018-04-12T16:38:45.278Z)
OS version: Windows_NT x64 10.0.10586

Please provide more details about what you want to do and what goes wrong.

Please provide more details about what you want to do and what goes wrong.

Ditto


Support alternate endpoints

Happy with any other solution that achieves the same thing but thought I'd at least take a crack at it vs. lobbing an issue.

Hey @whiteley
Thank you for the PR. I think Address is a public field on the client. Is there a reason you can't do this:
client, err := NewClient("abcd1234")
if err != nil {
  panic(err)
}
client.Address = "my.custom.endpoint"

I'll have to go back and double check but iirc the init function set url from Address and setting it after wouldn't work and you couldn't call init again since it's private.
Sorry if I'm misremembering or made a mistake in looking at it.

On Mar 22, 2017, at 11:28, Seth Vargo<EMAIL_ADDRESS>wrote:
Hey @whiteley
Thank you for the PR. I think Address is a public field on the client. Is there a reason you can't do this:
client, err := NewClient("abcd1234")
if err != nil {
panic(err)
}
client.Address = "my.custom.endpoint"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@sethvargo I'm far from a Go expert but I had a more experienced friend check what I was doing and they agreed it seems impossible at the moment to address another API server. Could you take another look at this? My end goal is to add the support to the Fastly provider in Terraform. Thanks!


Add docs on kubeconfig parameters like proxy-url

There do not appear to be public facing docs for kubeconfig parameters like proxy-url, introduced in https://github.com/kubernetes/kubernetes/pull/81443.
also ref https://github.com/kubernetes/client-go/issues/351
/sig api-machinery cli

/kind feature
/triage accepted
Also see https://github.com/kubernetes/website/issues/23889

/remove-lifecycle stale
@sftim Do you think this would be a good candidate for help-wanted or good-first-issue?

/help
This isn't a good-first-issue for SIG Docs. It might be a good first issue for someone who knows client-go and is looking to get more involved with documentation.
The reference could go alongside generated documentation within https://kubernetes.io/docs/reference/config-api/

/remove-lifecycle stale

/remove-lifecycle rotten

/reopen
Oh, and I wouldn't count this as a good-first-issue, at least not as the issue description stands.

/remove-lifecycle rotten

This is revolved with the config API (https://kubernetes.io/docs/reference/config-api/kubeconfig.v1/).


Test instructions seem incorrect

README suggests bundle exec rake test but executes no tests; same reult for bundle exec rails test in master

Committed


Graphql object generation

This PR fixes the generation of GraphQL objects.

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   81.39%   81.39%
=======================================
  Files         129      129
  Lines        5562     5562
=======================================
  Hits         4527     4527
  Misses        720      720
  Partials      315      315


Bootstrap LESS files issues while navigating between apps

Hi,
Looked at the previous issues related to bootstrap CSS but none of them helped me. Below is my issue.
When I'm in an App1 after logging in. It works great. Everyhting looks perfect. no alignment issues.
But after I go to App2 and then back to App1, the pages look messy. After inspecting it I found out: the .less are adding up and casuing the issue but turns out i have no less files in Node modules > bootstrap > css > dist or in any of the bootstarp files in node modules.
How do i get rid of those files when I don't have them in my node modules in the first place.
Thanks,
Ravi

Only load one version of bootstrap. Do this in the root html file instead of inside of any of the apps. Your code probably has a js import or css import loading the bootstrap files, and you should delete those lines of code in favor of the root html file loading bootstrap


Docs feedback

Random notes of documentation feedback:

[x] https://lamin.ai/docs/guide/tutorial1#track-a-data-source does not explain the difference between a Transform and a Run. Is it required?
[x] The syntax of e.g. key__startswith wasn't really introduced. I feel like we should host a site on Lamin where we highlight all possible Django SQL filters with small examples and link to this side early in the guide with 1 sentence of explanation. Edit: it's actually explained here: https://lamin.ai/docs/guide/select#relationships - maybe this needs to be linked earlier?
[x] https://lamin.ai/docs/guide/data-lineage#from-a-file

[ ] https://lamin.ai/docs/guide/data-lineage#query-by-provenance - why is the result empty?

[ ] Look ups or lookups? We're naming the objects that we create lookup and not look_up. Primarily https://lamin.ai/docs/guide/select#look-ups
[ ] What are record for one and one_or_none here? django querysets? not obvious... https://lamin.ai/docs/guide/select#basic-select

[ ] Basic search result empty -> https://lamin.ai/docs/guide/select#basic-search

[ ] Adding schemas after init - https://lamin.ai/docs/guide/configure#init-an-instance - is there even a way? If yes, we should consider documenting it
[x] Use _bt suffix instead of _bionty for bionty objects - https://lamin.ai/docs/biology/registries and forward
[ ] Close, but not close enough

[x] Maybe this is also product feedback but this output is too verbose and confusing

[ ] lookup or look up? see above

[ ] There are still a lot of occasions where we can link to the actual function instead of just naming it with Sphinx

Closing and starting again from the beginning


Database migration failure

Version 0.310.20240830
Opening DB
Connecting to DB
AutoMigrating DB tables

2024/08/31 15:06:01 /build/hishtory/backend/server/internal/database/db.go:62
[6.992ms] [rows:1] SELECT count(*) FROM information_schema.tables WHERE table_schema = CURRENT_SCHEMA() AND table_name = 'enc_history_entries' AND table_type = 'BASE TABLE'

2024/08/31 15:06:01 /build/hishtory/backend/server/internal/database/db.go:62
[0.375ms] [rows:1] SELECT CURRENT_DATABASE()

2024/08/31 15:06:01 /build/hishtory/backend/server/internal/database/db.go:62
[15.200ms] [rows:-] SELECT c.column_name, c.is_nullable = 'YES', c.udt_name, c.character_maximum_length, c.numeric_precision, c.numeric_precision_radix, c.numeric_scale, c.datetime_precision, 8 * typlen, c.column_default, pd.description, c.identity_increment FROM information_schema.columns AS c JOIN pg_type AS pgt ON c.udt_name = pgt.typname LEFT JOIN pg_catalog.pg_description as pd ON pd.objsubid = c.ordinal_position AND pd.objoid = (SELECT oid FROM pg_catalog.pg_class WHERE relname = c.table_name AND relnamespace = (SELECT oid FROM pg_catalog.pg_namespace WHERE nspname = c.table_schema)) where table_catalog = 'hishtory' AND table_schema = CURRENT_SCHEMA() AND table_name = 'enc_history_entries'

2024/08/31 15:06:01 /build/hishtory/backend/server/internal/database/db.go:62 ERROR: could not determine data type of parameter $1 (SQLSTATE 42P18)
[0.422ms] [rows:-] SELECT * FROM "enc_history_entries" LIMIT 1
panic: OpenDB: failed to create underlying DB tables: db.AutoMigrate: ERROR: could not determine data type of parameter $1 (SQLSTATE 42P18)

goroutine 1 [running]:
main.InitDB()
        /build/hishtory/backend/server/server.go:173 +0x273
main.main()
        /build/hishtory/backend/server/server.go:202 +0x9b
root@7c2bdc899461:/# /app/server --help
Opening DB
Connecting to DB
AutoMigrating DB tables

2024/08/31 15:06:06 /build/hishtory/backend/server/internal/database/db.go:62
[7.328ms] [rows:1] SELECT count(*) FROM information_schema.tables WHERE table_schema = CURRENT_SCHEMA() AND table_name = 'enc_history_entries' AND table_type = 'BASE TABLE'

2024/08/31 15:06:06 /build/hishtory/backend/server/internal/database/db.go:62
[0.427ms] [rows:1] SELECT CURRENT_DATABASE()

2024/08/31 15:06:06 /build/hishtory/backend/server/internal/database/db.go:62
[15.242ms] [rows:-] SELECT c.column_name, c.is_nullable = 'YES', c.udt_name, c.character_maximum_length, c.numeric_precision, c.numeric_precision_radix, c.numeric_scale, c.datetime_precision, 8 * typlen, c.column_default, pd.description, c.identity_increment FROM information_schema.columns AS c JOIN pg_type AS pgt ON c.udt_name = pgt.typname LEFT JOIN pg_catalog.pg_description as pd ON pd.objsubid = c.ordinal_position AND pd.objoid = (SELECT oid FROM pg_catalog.pg_class WHERE relname = c.table_name AND relnamespace = (SELECT oid FROM pg_catalog.pg_namespace WHERE nspname = c.table_schema)) where table_catalog = 'hishtory' AND table_schema = CURRENT_SCHEMA() AND table_name = 'enc_history_entries'

2024/08/31 15:06:06 /build/hishtory/backend/server/internal/database/db.go:62 ERROR: could not determine data type of parameter $1 (SQLSTATE 42P18)
[0.389ms] [rows:-] SELECT * FROM "enc_history_entries" LIMIT 1
panic: OpenDB: failed to create underlying DB tables: db.AutoMigrate: ERROR: could not determine data type of parameter $1 (SQLSTATE 42P18)

goroutine 1 [running]:
main.InitDB()
        /build/hishtory/backend/server/server.go:173 +0x273
main.main()
        /build/hishtory/backend/server/server.go:202 +0x9b

Interesting, thank you for the bug report! I'm looking into this now. Given the source of the error, I think this may be a bug in the underlying gorm library (github.com/go-gorm/gorm) which I did upgrade the version of last week.

Ok, it looks like the root cause here is a mismatch of versions where we were using an older version of pgx and the gorm postgres driver, but a newer version of gorm. #243 should fix this, I'm going to let it run through all the tests on GH actions and then will release it ASAP.
I'll also follow up in a separate change to improve our test coverage to ensure we prevent this from happening again in the future.


added / to end of all routes to both with and without forward-slash will work

ex: /user/invite/ will not work when you leave out the extra foward-slash.
But if you add the forward-slash to the end of all the routes then /user/invite will work!

So now it works with both /user/invite/ and /user/invite, or only with the trailing slash?

@neurosnap why closed?

After a year and a half of this PR being listed, I'm just going to close it and clear it from my list of open PRs.


add driver manager and fix sign-in bugs

Hey Vishaal! It's Itai, one of the twins from UCLA/Cliffs. Thanks for making this scraper, just had a few additions if you don't mind.

I thought it would be nice to include the Chrome Driver Manager so it automatically stays up to date and you don't need to worry about the $PATH.

The username will return an error if there are non alphanumeric characters (i.e. a period) so I'd like to implement a slugifier.

Not sure why, but for me the login element returned an IndexError: list index out of range. I fixed this by changing to the first index [0] instead of [1].

The rest of the changes are markdown linting (sorry for the extra changes)

What's up Itai, hope you're doing well! Glad you found a use for my project. Your changes look good to me!


Get simplestViewController text

I am using the basic editor. How can I set the delicate, and then pull the html text from the editor to save elsewhere?
import UIKit
import MarkupEditor

class SimplestViewController: UIViewController {

    override func viewDidLoad() {
        super.viewDidLoad()
        let markupEditorUIView = MarkupEditorUIView(html: "
Hello World
")
        markupEditorUIView.frame = view.frame
        markupEditorUIView.autoresizingMask = [.flexibleWidth, .flexibleHeight]
        view.addSubview(markupEditorUIView)
    }

}

If you look in the DemoViewController, you can see how I get the text for the bottom view. In that case, for demo purposes, I'm updating the "raw text" you can view at the bottom both when the view loads and when any input is received on the Swift side (i.e., when you type into the editor). In those cases, it's all driven by callbacks to the MarkupDelegate, which is the DemoViewController itself. For example, this is the callback that is invoked as you type:
    func markupInput(_ view: MarkupWKWebView) {
        // This is way too heavyweight, but it suits the purposes of the demo
        setRawText()
    }

This calls setRawText(), which calls getHtml, which is what you're looking for:
    private func setRawText(_ handler: (()->Void)? = nil) {
        selectedWebView?.getHtml { html in
            self.rawTextView.attributedText = self.attributedString(from: html ?? "")
            handler?()
        }
    }


Create softlinks for shared paths task ignores ansistrano_shared_path variable

The task "Create softlinks for shared paths and files" ignores ansistrano_shared_path and creates shared directory always in the same place. This makes impossible to control where this dir should exist.
Task from tasks/symlink-shared.yml:
- name: ANSISTRANO | Create softlinks for shared paths and files
  file:
    state: link
    path: "{{ ansistrano_release_path.stdout }}/{{ item }}"
    src: "{{ item | regex_replace('[^\\/]*', '..') }}/../shared/{{ item }}"
  with_flattened:
    - "{{ ansistrano_shared_paths }}"
    - "{{ ansistrano_shared_files }}"

In this line:

src: "{{ item | regex_replace('[^\\/]*', '..') }}/../shared/{{ item }}"

ansistrano_shared_path should be used instead of this quirky regex_replace() so that links actually point to the shared dir defined in the playbook.
For this to work also "Ensure shared paths exists" task from tasks/setup.yml needs fixing as it creates shared paths inside {{ ansistrano_deploy_to }}/shared completely ignoring ansistrano_shared_path variable as well:
- name: ANSISTRANO | Ensure shared paths exists
  file:
    state: directory
    path: "{{ ansistrano_deploy_to }}/shared/{{ item }}"
  with_items: "{{ ansistrano_shared_paths }}"
  when: ansistrano_ensure_shared_paths_exist

Here {{ ansistrano_deploy_to }}/shared should be replaced with {{ ansistrano_shared_path }}.
I'll be happy to prepare PR if this makes any sense to you guys. Or maybe there is a purpose in current approach?

The regular expression is there to allow multi-folder shared items. It is quirky but there was no better way to achieve it

But it works as well without it. The only difference is that path is not relative but absolute.

Mmmm I see, it looks like you are right, the tests covers this case and they are passing!
Let me review a bit better but I think your code is much cleaner
Thanks!

Ok I remember now
If you check https://github.com/ansistrano/deploy/issues/92 you will see why this became a relative path instead of an absolute one.
I understand this makes ansistrano_shared_path impossible to control but it would break the behaviours in that issue

OK, I get it. Though that's kind kind of an edge case. I'll try figuring out how we can change this to relatives instead but preserving the logic.

I think the best option would be to have the folder name configurable (now it is hardcoded to shared) and use that value everywhere.
I believe one could even use something like "../../somewherelese" and then we would also allow shared stuff outside of the deployment main folder as some users requested a while ago

This role is failing out of the box for me for a somewhat vanilla configuration
ansistrano_shared_paths:
      - log
      - tmp/pids
      - tmp/cache
      - tmp/sockets
      - vendor/bundle
      - public/system
    ansistrano_shared_files:
      - config/database.yml
      - config/secrets.yml
      - config/puma/production.rb

Excerpt:
failed: [redacted] (item=tmp/pids) => {"changed": false, "failed": true, "item": "tmp/pids", "msg": "src file does not exist, use \"force=yes\" if you really want to create the link:
failed: [] (item=tmp/cache)
failed: [] (item=tmp/sockets)
failed: [] (item=config/puma/production.rb)
Not exactly why some paths worked though like  changed: [] => (item=public/system), sounds related though.

The error is self explanatory, it cannot symlink something that does not exist (in your case tmp/pids in <deploy_to>/shared) https://github.com/ansistrano/deploy/blob/master/tasks/symlink-shared.yml#L18

They most certainly do exist though, that's why i'm concerned the linked line item is incorrectly expanding the source locations. Let me investigate more for user error

Weird, as you said some others do work, maybe some permissions difference in some folders? Cannot thing of anything else :(

If you look at src on the failing folder it looks like the relative path is all of a sudden incorrect. I wonder if there is an easier way to debug ansible's file module. It's hard to see what's actually going on right now.
TASK [carlosbuenosvinos.ansistrano-deploy : ANSISTRANO | Create softlinks for shared paths and files] ******************************************************************************************************
changed: [] => (item=log) => {"changed": true, "dest": "/var/www/myapp/releases/20171107223411Z/log", "failed": false, "gid": 1000, "group": "ubuntu", "item": "log", "mode": "0777", "owner": "ubuntu", "size": 16, "src": "../../shared/log", "state": "link", "uid": 1000}
failed: [<IP_ADDRESS>] (item=tmp/pids) => {"changed": false, "failed": true, "item": "tmp/pids", "msg": "src file does not exist, use \"force=yes\" if you really want to create the link: /var/www/myapp/releases/20171107223411Z/tmp/../../../shared/tmp/pids", "path": "/var/www/myapp/releases/20171107223411Z/tmp/pids", "src": "../../../shared/tmp/pids", "state": "absent"}

ubuntu@ip-blah:/var/www/myapp/shared$ ls -la /var/www/myapp/shared/tmp/
total 20
drwxr-xr-x  5 ubuntu ubuntu 4096 Nov  7 20:24 .
drwxr-xr-x 10 ubuntu ubuntu 4096 Nov  7 20:24 ..
drwxrwxr-x  2 ubuntu ubuntu 4096 Nov  7 20:24 cache
drwxrwxr-x  2 ubuntu ubuntu 4096 Nov  7 20:24 pids
drwxrwxr-x  2 ubuntu ubuntu 4096 Nov  7 20:24 sockets

I'm going to do a quick sanity test and hardcode an absolute shared path for source

Oh duh, it's because its trying to create the symlink from shared/tmp/pids  to {current_release}/tmp/pids, but the tmp directory doesn't exist in the release folder therefore the confusing error message. I just i have to link the entire tmp directory.

Ah yeah, that's really annoying, sorry for not seeing it before, either this or you create tmp in a pre-hook or sth
Some tests reflect this situation, it is far from ideal though as you have seen


fix: deploy warning about insecure defaults (#1851)

PR #1851

Even if all automatic tests are passing, this tightening of the security context results in 'permission denied' errors during remote deployment, so it needs to be investigated further:
❯ ./func deploy --remote -v -p func-node-3-remote
Creating Pipeline resources
E0725 13:06:59.279231   13915 v2.go:105] write tcp <IP_ADDRESS>:56419-><IP_ADDRESS>:443: use of closed network connection
Error: failed to run pipeline: cannot upload sources to the PVC: the command failed: exitcode=1, out="tar: can't create directory 'source': Permission denied\ntar: can't open 'source/.funcignore': No such file or directory"

/approve
/lgtm

/hold

/unhold


PASSION FEED in GALLERY

What happened?
When i choose passion feed, there is no nft to show.
I think it will confuse the explorers.
Please reproduce in steps
Go to https://kodadot.xyz/rmrk/explore/?tab=GALLERY&page=1 Click on Passion Feed See error
Expected Behavior
I've expected that I can see nfts
What browsers are you seeing the problem on?
No response
Are you logged in?
No response
At which address did you encounter bug?
No response
Screenshots
Paste from your clipboard or upload screenshots/video

Relevant log output
No response
Payment link for reward
Fill up your KSM address: Payout
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Passion feed means the list of issuers from NFTs you already bought.
So, in this case, if you haven't bought any NFT, then yes, it should be empty. 😄

it should rather show a link to buy some

This would have been solved with #3103


Update OpenSearch versions in main and 1.x branches

Please update the version consumed in main and 1.x branch according to OpenSearch main and 1.x respectively.

#48 is related
1.x isn't critical at first, but main needs to be building against OpenSearch 1.1 and producing 1.1 output


Fix most of the out-of-date font cask installation issues

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
No, the casks are legacy and many of them violate naming rule, etc. that I don't touch.
[ ] The commit message includes the cask’s name and version.
No, casks are many. I can list them in the PR if necessary.

Additionally, if adding a new cask:

[ ] Named the cask according to the token reference.
[ ] brew cask install {{cask_file}} worked successfully.
[ ] brew cask uninstall {{cask_file}} worked successfully.
[ ] Checked there are no open pull requests for the same cask.
[ ] Checked that the cask was not already refused in closed issues.

Sorry for the trouble. I was behind some firewall that might be unstable, retried the 3 casks and the new hash is the same with CI now.

Thank you for your contribution.


Take screenshot

The CaptureScreenshotResult has one named field _screenshotData :: String. The Page.captureScreenshot should be used with onEvent or waitFor?

Already found out, with onEvent

It turned out like this:
import Control.Monad.Trans (liftIO)
import Data.Foldable (traverse_)
import Chrome.Target.Client
import Chrome.Target.Async (waitFor, onEvent, stopEventListener)
import qualified Chrome.API.Page as Page
import qualified Chrome.API.Page.Types as PageTypes
import qualified Chrome.API.Network as Network
import Data.ByteString.Base64 (decode)
import Data.ByteString as B
import Data.ByteString.Char8 as C8

takeScreenshot :: String -> String -> TargetClient ()
takeScreenshot url outputFileName = do
    traverse_ waitFor [Page.enable, Network.enable Network.defaultEnableParams]

    let screenshotParams = PageTypes.CaptureScreenshotParams "png" 0 True

    waitFor $ Page.navigate url
    waitFor $ Page.onLoadEventFired
    result <- waitFor $ Page.captureScreenshot screenshotParams
    liftIO $ writeData result

    traverse_ waitFor [Page.disable, Network.disable]

    where
        writeData (Left error)  = print error
        writeData (Right event) = writeDecodedData . decode . C8.pack $ PageTypes._screenshotData event
        writeDecodedData (Left error) = print error
        writeDecodedData (Right event) = B.writeFile outputFileName event


Crash when running amplify add api

Describe the bug
When running amplify add api the cli crashed on selecting "Do you want to edit the schema now":
? Do you want to edit the schema now? Yes
TypeError: fs.copyFileSync is not a function
    at serviceWalkthrough (/Users/josh/.nvm/versions/node/v8.3.0/lib/node_modules/@aws-amplify/cli/node_modules/amplify-category-api/provider-utils/awscloudformation/service-walkthroughs/appSync-walkthrough.js:164:6)
    at <anonymous>
There was an error adding the API resource

This seems to be due to running in an older node version (I was using v8.3.0), as fs.copyFileSync was only added in v8.5.0 according to the docs: https://nodejs.org/api/fs.html#fs_fs_copyfilesync_src_dest_flags
Perhaps we could check the user's node version and warn if they're running an older versions?  I'd be happy to put together a PR if you agree on this course :)
To Reproduce
Steps to reproduce the behavior:

In a new project run amplify add api
On "Do you want to edit the schema now?" select Yes
See error

Desktop (please complete the following information):

Node Version 8.3.0

@joshwnj  Please use Node version >= 8.11.x.

Thanks @kaustavghosh06 . I've submitted #224 as an easy way to prompt users with old node versions to upgrade.

Merged it. Thanks for the PR @joshwnj

Seems this error happens with node v10.7.0 still.
Do you want to edit the schema now? Yes
Error: EISDIR: illegal operation on a directory, copyfile<EMAIL_ADDRESS>-> '/Users/administrator/cargill/presigned-url-lambda/amplify/backend/api/signedurl/schema.graphql'
at Object.copyFileSync (fs.js:1697:3)
at serviceWalkthrough (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-category-api/provider-utils/awscloudformation/service-walkthroughs/appSync-walkthrough.js:204:6)
at process._tickCallback (internal/process/next_tick.js:68:7)
There was an error adding the API resource


plugin searchs for validation-api-sources.jar when it actually has a different filename

I added this plugin to build.gradle and set it up almost like the readme but it fails with this message :

:processResources
perform enhancement for task: processResources
:processResources FAILED
:autoLintGradle

FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':processResources'.

Could not resolve all files for configuration ':compileClasspath'.
Could not find validation-api-sources.jar (javax.validation:validation-api:1.1.0.Final).
Searched in the following locations:
file:/home/abd/.m2/repository/javax/validation/validation-api/1.1.0.Final/validation-api-1.1.0.Final-sources.jar

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

I don't know exactly what's the problem because validation-api sources jar exists in maven Central repo, probably the plugin is searching for a wrong filename or I'm missing something.
How to resolve this problem ?

I'll close this issue ... please ask questions on the forum - https://groups.google.com/forum/#!forum/ebean
Thanks.