Modified code to hide the visibility of contact details

Modified code to hide the visibility of contact details of all command except view command.

Codecov Report
Patch coverage: 60.00% and project coverage change: -0.34 :warning:

Comparison is base (093a734) 69.35% compared to head (3fc9c4b) 69.02%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
- Coverage     69.35%   69.02%   -0.34%
  Complexity      477      477
============================================
  Files            86       86
  Lines          1560     1569       +9
  Branches        172      175       +3
============================================
+ Hits           1082     1083       +1
- Misses          416      424       +8
  Partials         62       62

Impacted Files
Coverage Δ

...java/seedu/address/logic/commands/ViewCommand.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...rc/main/java/seedu/address/ui/PersonListPanel.java
0.00% <0.00%> (ø)

...va/seedu/address/logic/commands/CommandResult.java
80.00% <75.00%> (-3.34%)
:arrow_down:

.../java/seedu/address/logic/commands/AddCommand.java
100.00% <100.00%> (ø)

...ava/seedu/address/logic/commands/ClearCommand.java
100.00% <100.00%> (ø)

...ess/logic/commands/DeleteMultipleIndexCommand.java
90.00% <100.00%> (ø)

...dress/logic/commands/DeleteSingleIndexCommand.java
100.00% <100.00%> (ø)

...java/seedu/address/logic/commands/EditCommand.java
93.15% <100.00%> (ø)

... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

There's a bug here where the contact details are shown. Refer to the video in the telegram group for more info.
Don't merge this yet!!!!!

@Acerizm Help me check if it's working fine. Thanks!

Currently list -> view -> filter -> list is broken. Have yet to test the rest of the commands

For mine dataset, view -> list, is broken.  Few days back, I tried to debug, I also cant seem to find the bug, abit weird how javafx updates their PersonListPanel.
@Gibson0918 If it is too time consuming, this feature can make do without it.

@Statspadders Did u try with the latest commit? It is working on my end. Maybe you can take a video and post it on the telegram group so I can better understand the issue?
Here's a short video of what I tested:
https://user-images.githubusercontent.com/40551779/228500354-096d2ad0-80ef-40f0-b75f-e633390452a2.mp4
The only buggy part is the edit interaction. I unsure if users are allowed to edit since all contacts details are hidden.

Oops sorry was looking at the wrong commit.
I am facing this bug. Can you try on your end ?
view (all indexes)
add a new user
Some of the contacts are hidden and some are not.

@Statspadders Updated the code and it was working when I tested the bug that you mentioned. If there are any other bugs, then lmk and I'll try to fix it? Otherwise, if everything looks good then help me to approve and merge, Thanks!

view (all indexes)
add a new user
Some of the contacts are hidden and some are not.


Operation is not supported in this platform

I installed InTheHandBluetoothLe and microsoft.windows.cswinrt libraries and only wrote a single method and got this error.

You'll need to give more information - is this a donet standard or a dotnet core project, are you using unity (and if so, mono etc) and maybe some other things.

I get this same exception when using this method in .NET 5.

Should be PlatformNotSupportedException due to https://docs.microsoft.com/en-us/dotnet/core/compatibility/interop/5.0/built-in-support-for-winrt-removed

What is your target platform - which Windows 10 version? Is it older than 10.0.19041?


Fix typo in generate-daemon-manifest.sh

Signed-off-by: Andreas Karis<EMAIL_ADDRESS>
- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

/lgtm
/approve
sorry I have one hand faster than the other :(


[CopyPropagation] Canonicalize moved-from values.

If a move_value is determined to be redundant and removed, take the opportunity its removal makes available to canonicalize the moved-from value without the obstruction of the move_value.

@swift-ci please test

@swift-ci please benchmark

@swift-ci please benchmark

@swift-ci please test

@swift-ci please clean test macOS platform


Barbecue can’t down load

Change :   "utilyre/barbecue.nvim",
branch = "fix/E36",
Change branch to “‘main”


Mobile App user Agent issue fix

Fix for issue #28

Codecov Report

Merging #29 into master will increase coverage by 9.83%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   83.91%   93.75%   +9.83%
==========================================
  Files           3        3
  Lines         143      128      -15
  Branches       16       15       -1
==========================================
  Hits          120      120
+ Misses         21        6      -15
  Partials        2        2

Impacted Files
Coverage Δ

django_cookies_samesite/user_agent_checker.py
98.70% <100.00%> (+7.56%)
:arrow_up:

django_cookies_samesite/middleware.py
86.00% <0.00%> (+11.39%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f08a4d1...c0d9625. Read the comment docs.


[less] Syntax checking error for mixins

VSCode Version: 1.8.1
OS Version: OS X 10.11.6
The following valid less is incorrectly marked with red squiggles:
.media-switch(@styles) {
    @media(orientation:landscape){
        @styles();
    }
}

A similar issue happens when passing a detached ruleset to the mixin:
.media-switch({
    flex-direction: row;
});

See also issue 131.

Fixed by Microsoft/vscode-css-languageservice@f1d6e334992656997d68d270f62b4b2dea115990

Looks like this is not yet part of the build

This is still an issue when passing a detached ruleset as second parameter:

@aeschli could you re-open this, or should I file a new issue?

@geirsagberg Please file a new issue!


Update Redme

Remove this sentence and insert the description of the pull request here.

✅ By submitting this PR, I have verified the following

[x] Checked to see if a similar PR has already been opened 🤔
[x] Reviewed the contributing guidelines 🔍
[x] Added my name to the bottom of the list under the Contributors section in the README.md with a link to my personal website or GitHub profile 👥 (Optional)

nice try, this is not worth a PR


Tests for layoutSelector

react-i18next does not include  initReactI18next when running tests; therefore, I get the following error when using the configForTest.js:
You are passing an undefined module! Please check the object you are passing to i18next.use() However it does when developing.
These are the only keys that react-i18next include:
    {
      withTranslation: [Function: withTranslation],
      useTranslation: [Function: useTranslation],
      Trans: [Function: Trans],
      default: {
        withTranslation: [Function: withTranslation],
        useTranslation: [Function: useTranslation],
        Trans: [Function: Trans]
      }
    }

However, when developing and logging react-i18next includes initReactI18next among other methods as seen below:
{
  Trans: [Getter],
  useTranslation: [Getter],
  withTranslation: [Getter],
  Translation: [Getter],
  I18nextProvider: [Getter],
  withSSR: [Getter],
  useSSR: [Getter],
  I18nContext: [Getter],
  initReactI18next: [Getter],
  setDefaults: [Getter],
  getDefaults: [Getter],
  setI18n: [Getter],
  getI18n: [Getter],
  composeInitialProps: [Getter],
  getInitialProps: [Getter]}

Not sure why react-i18next is behaving this way. Any thoughts @moT01, @ojeytonwilliams ?

I made some mocks for react-i18next here - mostly taken from the example provided by them. It looks like we may need to mock that function - as they say here

It seemed they pulled some modules and passed them on. it seems reasonable to mock the methods we need to mock and pass on the required methods from the module directly.
I was able to shallow render the component that is being returned from layoutSelector and it has the info we need to test against.  let me know what you think.


Call to a member function all() on null

Laravel Version: 5.4.15
PHP Version: PHP 7.0.3
Composer 1.4.1

I want to select pages from database
PagesController:
$pages = $this->pages->all();
return view('pages.index', compact('pages'));

in index blade page:

	@if($pages->isEmpty())

		{{ trans('page.no_page') }}

	@else
		@foreach($pages as $page)

				{{ $page->title }}
				{{ $page->uri }}
				{{ $page->name }}
				{{ $page->icon }}

		@endforeach
	@endif

This should return translated message that there are no pages in database, but I'm getting error

FatalThrowableError in PagesController.php line 25: Call to a member function all() on null

$this->pages is not set properly in the PagesController.
This is not an issue with the framework.

It is set properly. I didn't wrote complete code.
class PagesController extends Controller
{
    protected $pages;

    public function __constructor(Page $pages)
    {
        $this->pages = $pages;
    }
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $pages = $this->pages->all();
        return view('admin.pages.index', compact('pages'));
    }

Does __constructor(Page $pages) refer do Page model? If so, you need to use it like this:
$pages = Page::all();

It's working on that way. But, I use $page = $this->pages->all() method in my projects in Laravel 5.2 with injected model and property in __construction method and it works fine.

__constructor => __construct

That's the problem. Thanks.


Question what's the default timeout set by fetchblob?

Hi,
I wanted to know what the default timeout set by fetchblob and if you can custom set this

+1!! time out is never triggered.


[DS-2776] Migrate primitives in sql

Postgres migration provided by @TimothyXL

Haven't tested it yet, but the SQL looks sane.

Reviewed & approved in today's DevMtg.


Add a focus to the volume UI

If you tab over to the volume UI, you can use arrow keys, but there is no visual cue that you are currently on the volume


Reflector

My previous implementation was a piece of shit
Now I have to implement this library completely from scratch

Design goals:

Full event support
Asynchronous multi-threading and single-thread support
Support all neovim channels
Supports 0.12 and nightly

Now, the develop branch is new, because zig's encapsulation of windows is too poor, it is necessary to implement a set of io reuse functions specifically for the windows platform.

Progess:
For windows, now the rpc part has implemented safe asynchrony, but safe exit and externally exposed api encapsulation have not yet been implemented. But now implementation is through polling, low efficiency.
Plan to use iocp or other more efficient mechanisms to implement
For unix-like,  linux will use epoll to implement this!

Branch:  new

Now socket namedpipe and jobstart with rpc under windows and linux are supported

However, the current implementation is still based on polling, and the efficiency may be a little worse, but it is still acceptable.


Fix GitHub.last_commit and enable more typing

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

I think Github.last_commit has been busted since https://github.com/Homebrew/brew/pull/14112/files#diff-0b87a525dc494bc971692d4384fa8f200851cc433dbfb297e513b6c7b5ba07efR684 bc it did not thread version into the method (and the file wasn't typed). This fixes that oversight, enables typing, and also updates a few more nearby files to enable typing.

Review period will end on 2023-03-17 at 01:14:15 UTC.

Review period skipped due to critical label.


Release 1.0.0-RC2

Let's do a 1 week effort to finish the most important issues for RC2, then we do a release.

New Features

Property files can now be linked to the integration without manually creating an external configmap (#1244, @nicolaferraro)
Periodic integrations are automatically translated into Kubernetes CronJobs (#1197, @nicolaferraro)
Camel K 1.0.0-RC2 will be also available for install via Helm (#1287, @nicolaferraro)
A kamel init command has been added to quickly scaffold integration files (e.g. kamel init Example.java) (#1219, @nicolaferraro)
feat(jolokia): Support auto-configuration for OpenShift 4
feat(jolokia): Automatically adds the camel-management dependency (#1193, @astefanutti)
Camel master component is automatically configured to do leader election using Kubernetes resources (#1274, @nicolaferraro)
feat: Support any Java base images (#1215, @astefanutti)
feat(build): Buildah support (#1259, @astefanutti)
Kubernetes events are generated to track the status of an integration (#1228, @nicolaferraro)
The kamel install and run commands provide a --save flag to store the command line parameters to the default configuration file (#1217, @nicolaferraro)

Bug Fixes

Some commands like kamel version threw an error if executed without connection to a cluster (#1241, @nicolaferraro)
Fixed x509 certificate errors for Knative serving services on OpenShift (#1269, @nicolaferraro)

Other Notable Changes

feat(trait): Unified JVM trait (#1226, @astefanutti)
chore(dev): Upgrade Operator SDK to version 0.15.0 (#1224, @astefanutti)
Operator is installed via OLM (Operator Lifecycle Manager) when available. (#1260, @nicolaferraro)
Code rebased on Knative 0.12.x (#1271, @nicolaferraro)
chore(build): Upgrade Kaniko to version 0.17.1 (#1253, @astefanutti)
fix(install): Check permission to create OpenShift ConsoleCLIDownload resource (#1248, @astefanutti)
fix(dev): Use go-homedir package instead of os/user to retrieve user home directory (#1211, @astefanutti)
fix(jolokia): Order consistently Jolokia agent options when encoded as environment variable (#1198, @astefanutti)

@nicolaferraro could you upload binaries for this release?

@nicolaferraro When will be the binaries available for download?

They should now be released, I'm doing some checks before the announcement.


Dynamic Programming: Find Minimum Insertion Steps to Make a String Palindrome in C++

Assign this isssue to me @akgmage
Thank you in advance

I will do it


[azmetrics] Inconsistent Metric Values from azmetrics.QueryResources() with Batches of 4+ Resources

Bug Report

when usinggithub.com/Azure/azure-sdk-for-go/sdk/monitor/query/azmetrics v1.0.0
with Go v1.21.7 darwin/arm64

Context
I am collecting metrics for 10 Microsoft.KeyVault/vaults.
What happened?
If I call azmetrics.QueryResources() with a batch of 1-3 resources, I get the same data points I see on Azure Portal.
However, I don't get the same values I see in Azure Portal if I try to get metrics values for the same resource in a batch request with 4+ resources.
For example, with a batch of 1-3 resources, I always get two time series values for each resource. Starting with batches of 4+ resources, the number of time series values in the response varies at each request (0-2).
In the following example, I collect the metrics values in two ways:

Querying SINGLE resources: I make 10 API calls with one resource each.
Querying resources as a GROUP: I make 1 API Call with 10 resources.

$ go run main.go

Ready to go!
----------------------------------------------------
Querying SINGLE resources
----------------------------------------------------
.../providers/Microsoft.KeyVault/vaults/kv1-oeefrt7tlykau
timeseries 2
.../providers/Microsoft.KeyVault/vaults/kv2-oeefrt7tlykau
timeseries 2
.../providers/Microsoft.KeyVault/vaults/kv3-oeefrt7tlykau
timeseries 2
.../providers/Microsoft.KeyVault/vaults/kv4-oeefrt7tlykau
timeseries 2
.../providers/Microsoft.KeyVault/vaults/kv5-oeefrt7tlykau
timeseries 2
.../providers/Microsoft.KeyVault/vaults/kv6-oeefrt7tlykau
timeseries 2
.../providers/Microsoft.KeyVault/vaults/kv7-oeefrt7tlykau
timeseries 2
.../providers/Microsoft.KeyVault/vaults/kv8-oeefrt7tlykau
timeseries 2
.../providers/Microsoft.KeyVault/vaults/kv9-oeefrt7tlykau
timeseries 2
.../providers/Microsoft.KeyVault/vaults/kv10-oeefrt7tlykau
timeseries 2
----------------------------------------------------
Querying resources as a GROUP
----------------------------------------------------
.../providers/Microsoft.KeyVault/vaults/kv1-oeefrt7tlykau
timeseries 1
.../providers/Microsoft.KeyVault/vaults/kv2-oeefrt7tlykau
timeseries 1
.../providers/Microsoft.KeyVault/vaults/kv3-oeefrt7tlykau
timeseries 2
.../providers/Microsoft.KeyVault/vaults/kv4-oeefrt7tlykau
timeseries 2
.../providers/Microsoft.KeyVault/vaults/kv5-oeefrt7tlykau
timeseries 0
.../providers/Microsoft.KeyVault/vaults/kv6-oeefrt7tlykau
timeseries 0
.../providers/Microsoft.KeyVault/vaults/kv7-oeefrt7tlykau
timeseries 0
.../providers/Microsoft.KeyVault/vaults/kv8-oeefrt7tlykau
timeseries 1
.../providers/Microsoft.KeyVault/vaults/kv9-oeefrt7tlykau
timeseries 1
.../providers/Microsoft.KeyVault/vaults/kv10-oeefrt7tlykau
timeseries 2

I get a different number of time series, depending if the same resource is in a batch of 1-3 or 4+ resources.
I repeated this test multiple times. The values for the "SINGLE" case never changed, while the values for the "GROUP" case changed on every call.
What did you expect or want to happen?
For the same resource, I expect azmetrics.QueryResources() to always return the same values, whether it's the only resource ID in the batch or one of the 50 supported resource IDs.
How can we reproduce it?
I created the gist https://gist.github.com/zmoog/fcede6fcbe5ba11f9275c40a58eea38d with:

Bicep file I used to create the test key vaults
Go with individual and batch calls to azmetrics.QueryResources()

Anything we should know about your environment.
Additional info
I see the same behavior when calling the API endpoint using cURL. See https://github.com/zmoog/public-notes/issues/81 for more details.
Questions:

Are my expectations correct?
Am I using the API the right way?
If the answer to the above questions is affirmative, is this a problem in the API and not the SDK?

Hi @zmoog! I think your issue will be fixed by setting the QueryResourcesOptions.Top field to a higher number. If a filter is specified, the service defaults to 10 records to retrieve per resource ID in the request. This is probably the cause of your throttling issues.
I repo'ed your code locally, and when I set Top to a higher number, the TimeSeries was consistent between the individual and group query.
options := azmetrics.QueryResourcesOptions{
		Aggregation: ptr("Count"),
		StartTime:   ptr("2024-04-16T07:18:13.001Z"),
		EndTime:     ptr("2024-04-16T07:19:13.001Z"),
		Filter:   ptr("ActivityType eq '*' AND ActivityName eq '*' AND StatusCode eq '*' AND StatusCodeClass eq '*'"),
		Interval: ptr("PT1M"),
		Top:      to.Ptr(int32(50)),
	}

@gracewilcox apologies if I'm missing something obvious, but:

the docs state that the default for Top is 10, and that this applies per resource ID
in the example there are fewer than 10 time series being returned per resource ID

So why should we need to increase Top if there are fewer than 10 time series per resource?
And given that Top should apply per resource, why does it matter if they're queried in bulk vs. one at a time?

@gracewilcox, thank you for replying!
The QueryResourcesOptions.Top plays a big role in the number of records in the QueryResources() response.
As you said, the Top option documentation reports:

The maximum number of records to retrieve per resource ID in the request. Valid only if the filter is specified. Defaults to 10.

However, it seems more like an option that applies to the whole batch and not per resource ID.
In my test case, I have:

10 resource IDs
1 metric (ServiceApiResult)
4 dimensions (ActivityType, ActivityName, StatusCode, StatusCodeClass)
1 aggregation type (Count)

All these key vaults are unused (I create them for testing), so I only get two records per resource, because we only have two unique combinations of dimension values:

vaultget, vault, 200, 2xx
vaultput, vault, 200, 2xx

So I only need a Top = 20 to get all the records.
However, when the resources are used, the number of unique combinations of dimension values varies greatly.
For example, if I start using one one the key vaults, I get 4-5 records instead of 2 for each resource ID:

----------------------------------------------------
Querying resources as a GROUP
----------------------------------------------------
/subscriptions/12cabcb4-86e8-404f-a3d2-1dc9982f45ca/resourceGroups/mbranca-azmetrics-test/providers/Microsoft.KeyVault/vaults/kv1-oeefrt7tlykau
timeseries 5
/subscriptions/12cabcb4-86e8-404f-a3d2-1dc9982f45ca/resourceGroups/mbranca-azmetrics-test/providers/Microsoft.KeyVault/vaults/kv2-oeefrt7tlykau
timeseries 4
/subscriptions/12cabcb4-86e8-404f-a3d2-1dc9982f45ca/resourceGroups/mbranca-azmetrics-test/providers/Microsoft.KeyVault/vaults/kv3-oeefrt7tlykau
timeseries 4
/subscriptions/12cabcb4-86e8-404f-a3d2-1dc9982f45ca/resourceGroups/mbranca-azmetrics-test/providers/Microsoft.KeyVault/vaults/kv4-oeefrt7tlykau
timeseries 4
/subscriptions/12cabcb4-86e8-404f-a3d2-1dc9982f45ca/resourceGroups/mbranca-azmetrics-test/providers/Microsoft.KeyVault/vaults/kv5-oeefrt7tlykau
timeseries 4
/subscriptions/12cabcb4-86e8-404f-a3d2-1dc9982f45ca/resourceGroups/mbranca-azmetrics-test/providers/Microsoft.KeyVault/vaults/kv6-oeefrt7tlykau
timeseries 4
/subscriptions/12cabcb4-86e8-404f-a3d2-1dc9982f45ca/resourceGroups/mbranca-azmetrics-test/providers/Microsoft.KeyVault/vaults/kv7-oeefrt7tlykau
timeseries 4
/subscriptions/12cabcb4-86e8-404f-a3d2-1dc9982f45ca/resourceGroups/mbranca-azmetrics-test/providers/Microsoft.KeyVault/vaults/kv8-oeefrt7tlykau
timeseries 4
/subscriptions/12cabcb4-86e8-404f-a3d2-1dc9982f45ca/resourceGroups/mbranca-azmetrics-test/providers/Microsoft.KeyVault/vaults/kv9-oeefrt7tlykau
timeseries 4
/subscriptions/12cabcb4-86e8-404f-a3d2-1dc9982f45ca/resourceGroups/mbranca-azmetrics-test/providers/Microsoft.KeyVault/vaults/kv10-oeefrt7tlykau
timeseries 4

I guess it's impossible to calculate the exact number of records because it depends on the unique combinations of the dimensions, which vary depending on the Azure service.
@gracewilcox, what strategy do you recommend for setting the Top value, and what's the maximum number allowed?

Hi @axw and @zmoog! Thank you for the detailed replies. The Top value is supposed to set the maximum records per resource ID, and as you discovered, it's currently not.
The service team is aware of the issue and is currently deploying a fix. Will let you know as soon as the bug is fixed. Thank you for your patience!

/unresolve

If I run the tests at https://gist.github.com/zmoog/fcede6fcbe5ba11f9275c40a58eea38d I still get the same result.
@gracewilcox, was the service updated with the fix? Does the fix require a new api-version?

@ToddKingMSFT, do you have guidance for this scenario?


Update on surprising jq behaviours

[[]] | implode crash was fixed in 1.7 by https://github.com/jqlang/jq/pull/2646
[limit(0; 1, 2, 3)] yielding 1,2 instead of nothing fixed in 1.7 by https://github.com/jqlang/jq/issues/2316
limit/2 will throw error on negative limit once https://github.com/jqlang/jq/pull/3181 is merged

The NaN compare stuff is a bit weird, maybe would be ok to do a breaking change for that? or could there be some indirect use of NaN compare that would break?
About the performance issues: i think most of them got resolved by https://github.com/jqlang/jq/pull/1834

Hi @wader, thanks for your PR! Your push motivated me to also remove a few other claims from the README that referred to jq 1.6 and which were not longer true in jq 1.7. So thanks for that. :)

@01mf02 👍 btw i'm slowly reading your "A formal specification of the jq language" paper and hope to get to review your jq docs improvements, been a bit busy with non-jq stuff


Added reference counting and Kafka checkpointing

This change is to use reference counters to check when data is done. Then, those counters are used by sources to know when to commit offsets. There are two primary types of nodes for the purposes here: synchronous nodes and asynchronous nodes. Synchronous do not exit from the update method before calling _emit. The reference counting happens in the Stream base class in the _emit function.  Asynchronous nodes, however do return and will call _emit at some time in the future. These nodes are more complicated because the metadata must be managed.
Synchronous nodes
The only thing changed here is that the metadata is passed forward to the next node.
Core

accumulate
filter
map
pluck
sink
rate_limit
slice
starmap
union
unique
flatten - The only special case for sync' nodes. The reference to the reference counters can not be duplicated for each messages or their counts will be decremented below zero. The metadata is emitted with the last element.

Dask

accumulate
map
starmap

Async' nodes (grouped by strategy)
Core
Input to output is 1:1
Couple the metadata with the data on the cache and pull the metadata off the cache with the data and emit them together.

buffer
delay
latest

Input single values and output collections
The metadata is cached with the data and emitted a collection.

collect
partition
sliding_window
timed_window

Multiple stream inputs combined into a single output
All datum that is emitted downstream will have it's accompanying metadata emitted with it as a collection.

combine_latest
zip
zip_latest

Dask
A yield is performed before _emit
The metadata is a simple pass-through just as in sync nodes, but the reference counter will need to incremented here as there is a yield before the _emit call

gather
scatter

Some Kafka tests did not pass. I'm going to close this and open a new PR with those tests fixed


Syntax highlighting - tex / latex - errors are an error

revtex (used by physics community worldwide) extensions of latex use some a few extra environmental tags. Another form of "equation" is "gather". Currently tex.vim will mark all sub/superscripts as errors. I have patched tex.vim to incorporate the new label. It works for me.
--- tex.vim	2020-07-25 08:55:49.000000000 -0700
+++ tex.new.vim	2020-08-05 14:19:17.040835605 -0700
@@ -409,7 +409,7 @@
 " Bad Math (mismatched): {{{1
 if !exists("g:tex_no_math") && !s:tex_no_error
  syn match texBadMath		"\\end\s*{\s*\(array\|[bBpvV]matrix\|split\|smallmatrix\)\s*}"
- syn match texBadMath		"\\end\s*{\s*\(displaymath\|equation\|eqnarray\|math\)\*\=\s*}"
+ syn match texBadMath		"\\end\s*{\s*\(displaymath\|equation\|eqnarray\|math|gather\)\*\=\s*}"
  syn match texBadMath		"\\[\])]"
 endif

@@ -452,6 +452,7 @@
  call TexNewMathZone("B","eqnarray",1)
  call TexNewMathZone("C","equation",1)
  call TexNewMathZone("D","math",1)
+ call TexNewMathZone("E","gather",1)

  " Inline Math Zones: {{{2
  if s:tex_fast =~# 'M'

And here's a bash script using sed to do it in situ.
#!/bin/bash
TV=tex.vim ; TV0=$TV~ ; cd /usr/share/vim/vim82/syntax
grep '|gather' $TV && exit #already fixed
[[ -e $TV0 ]] || cp -p $TV $TV0
#syn match texBadMath		"\\end\s*{\s*\(displaymath\|equation\|eqnarray\|math\)\*\=\s*}"  #original line
LN=$( sed -n '/eqnarray..math/=' $TV )
#call TexNewMathZone("D","math",1)  #original line
sed -i '/eqnarray..math/ s:\\):|gather&: ; /MathZone..D/a\
 call TexNewMathZone("E","gather",1)' $TV
most +$LN $TV
#not in vimBuild

The documentation inside the tex.vim script does note that other math environments can be included using the function NewTexMathZone that seems to yield the same result noted above.
But, why not make all such changes permanently inside tex.vim. The maintainer should peruse RevTex docs for all the environments defined there?

Try reading :help tex-package.  Check into the syntax additions I've made available on my website, which, by the way, include gather.

Try reading :help tex-package.  Check into the syntax additions I've made available on my website, which, by the way, include gather.

Try reading :help tex-package.  Check into the syntax additions I've made available on my website, which, by the way, include gather.

Try reading :help tex-package.  Check into the syntax additions I've made available on my website, which, by the way, include gather.

Try reading :help tex-package.  Check into the syntax additions I've made available on my website, which, by the way, include gather.

This issue should be closed, right?

OK.


Readme file doesn't have screenshot of project

Prerequisites
Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

[ ] I am running the latest version. - yes
[ ] I checked to make sure that this issue has not already been filed

Define You

[ ] GSSoC22 participant yes

It helps to contributor to understand the project.So i want to add screenshot of project

the screenshots which are added to README file


Commands Not Appearing in Command Palette

I installed the audio notes plugin, but the "create new audio note" command doesn't seem to appear in the command palette. I have the .mp3 file I'm aiming for in the vault. Is there something I'm missing about what is needed to create a new audio note?

Same here.  I installed it today but none of the commands that are listed in the docs show up, nor does typing in the commands by hand cause a player to show up.  Wondering if I missed another prerequisite.

Thanks for the report. I'll check it out today and get it fixed.

I just fixed the bug and made a new release. Github's CDN has been slow lately, so Obsidian can't see the new release yet, but it should be visible in Obsidian within a few hours. Last time it took ~ 4 hours, but hopefully it's faster this time.
I'm going to close this issue, but feel free to reopen it if you're still having issues with version 0.6.1.


-(void)callSourceCallbackURLString:parameters: is not complete

- (void)callSourceCallbackURLString:(NSString *)URLString parameters:(NSDictionary *)parameters defined in SBRCallbackParser.m doesn't really the call the URL given. It had to be refactored like below for me to work.
- (void)callSourceCallbackURLString:(NSString *)URLString parameters:(NSDictionary *)parameters {
  NSURL *url = [self callbackURLFromOriginalURLString:URLString parameters:parameters];

  if ([self.delegate respondsToSelector:@selector(xCallbackURLParser:shouldOpenSourceCallbackURL:)]) {
    [self.delegate xCallbackURLParser:self shouldOpenSourceCallbackURL:url];
  }

  [[SBRCallbackAction actionWithURL:url parameters:parameters] trigger];
}

- (void)callSourceCallbackURLString:(NSString *)URLString parameters:(NSDictionary *)parameters defined in SBRCallbackParser.m doesn't really the call the URL given. It had to be refactored like below for me to work.
- (void)callSourceCallbackURLString:(NSString *)URLString parameters:(NSDictionary *)parameters {
  NSURL *url = [self callbackURLFromOriginalURLString:URLString parameters:parameters];

  if ([self.delegate respondsToSelector:@selector(xCallbackURLParser:shouldOpenSourceCallbackURL:)]) {
    [self.delegate xCallbackURLParser:self shouldOpenSourceCallbackURL:url];
  }

  [[SBRCallbackAction actionWithURL:url parameters:parameters] trigger];
}


updating AssemblyResolution description  as it's not supported in netcore/net versions of MSTest

fix: https://github.com/microsoft/testfx/issues/1645

@Mikejo5000
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


DataParallelExecutorGroup hangs

the bind function costs a long time, taking around 80 seconds to complete binding operation. Below shows part of my code.
mod = mx.mod.Module(symbol=new_sym, context=devs)
mod.bind(data_shapes=train.provide_data, label_shapes=train.provide_label,for_training=True)
mod.init_params(initializer=mx.init.Xavier(rnd_type='gaussian', factor_type="in", magnitude=2))

And after debugged into the bind function, i found the code hangs in function 'DataParallelExecutorGroup' which is the bottleneck.   Anyone ever met this issue? Thanks a lot.
Here is my system info:
ubuntu 16.04
cuda 8.0.44

It could happen the first time you are using gpus.

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!

i am currently facing the same issue, but the halt period is like 9 minutes which seems way too long.
Also, this is happening on every occurrence rather than just being on the first time.
Is there something I can try to debug this time

@yajiedesign, would you mind re-opening this issue.
Thanks.


Swarm introduces linear performance degradation as #networks or #containers increases

It seems that Swarm introduces linear performance degradation as the number of networks and/or the  number of containers increases. I was focusing mainly on  starting a container and creating a network, but this issue affect many other commands like network delete, container delete, etc..
I made some profiling analysis and I believe that the source of this performance problem is the usage of RefreshNetworks() and RefreshContainers().
I think there are few issues with the current design/implementation:
Duplication - when we initiate "create container"  for example- Swarm explicitly calls refreshNetwork, however when the create container event will be received Swarm will initiate another refresh on the specific engine
Redundancy - When creating a container or a network Swarm calls refreshNetwork which goes over all engines and all networks on each engine. We we cerate a resources (container or network) we can actually do a focused discovery (e.g., during createNetwork send a listNetworks only for the id of the newly created network)
As Docker now supports overlay networks the situation becomes much worse as each engine may see many networks!
I also made some tests with eliminating some of the  redundant refresh calls and indeed most of the Swarm overhead was removed
A real fix would probably require some more investigation as currently the relevant functions are also used in situations in which you do want to discover everything (like swarm restart)

@abronan I'm not sure this is a network specific issue. I think it's a wider issue related to the overall Swarm "discovery" mechanism. The ability to create user-defined network just brought the issue to the surface as the number of networks increases.
However we also see similar behavior related to # of containers

@ezrasilvera thanks for the comprehensive report
We are definitely concerned about this and we want to improve performances.
I agree with you refreshNetworks() is the biggest issue, networks are the only place where you can do an API call on one engine and it's going to affect others engines, without swarm knowing about it.
That's why we are currently doing a refresh on every engine and that's really not ideal.
We are about to release 1.1.0 (tomorrow) but we are going to work on this very soon and release a 1.1.1 as soon as we reach significant improvement.
Do you mind sharing with us the branch you used for the reduced refreshNW tests ?

@vieux sure. will do.
I agree, that the NW has cross engine effect however when you manage a specific command (i.e., create container or network) you can limit the discovery - for example we can change RefrehNetwork on the engine to accept ID/filter so that we can do ListNetworks only on the NW ID you just created. and received. And when create/start  a container you just need to update the container list linked to the network of that container ...

@ezrasilvera agreed, also engine 1.10 (to be released tomorrow) also adds event on network creation/deletion/connect/disconnect
This removes the need for most of the refreshNetworks()

I think this relates to #1750 with the better and nice graph.

@chanwit I don't think those issues are related. This issue is not specific to the latest version and will not be noticed with a single NW. You need to create multiple (many .. :-) )  networks in order to see that.

You need to create multiple (many .. :-) ) networks in order to see that.

@ezrasilvera I see. This is the point. When you creating new networks, cluster store needs to handle additional loads. I'm still thinking it's the cause and we were seeing it clearly in our lab that the cluster store's CPU were spiking.
However, I'll be also finding the root cause.

@chanwit I fully agree that the cluster store also contribute to performance degradation, and we have seen that as well . We also saw nearly intensive CPU utilization and traffic for that.
However for this issue I actually think we know what is the root cause and we I believe we can eliminate most of the overhead especially if as @vieux said we can now listen to NW evenest and get rid of the refreshNetwork()
I would keep a separate issue directly related to cluster store as there might be some unrelated problems with that as well.

@ezrasilvera thanks for that I'll keep follow this issue as it would solve my problem too :):):)

I tested again with the latest code that includes @vieux changes of #1777 . The results are better but there is still a  gap compared to pure engine. I'm going to analyze the root-cause later on ..


Reinstall tarpauling for rust coverage

A small try to see if it works better now.

Lets trys again, as a new tarpaulin has been released potentially fixing the issue. :)


Row Color

Hi, Can we set different background-color for every row?

Any update?

Updated PlutoGrid 2.6.0


IOS17 support Trust Kit Crash (iphone15 physical)

Currently the ssl-pining cause a crash on new iPhones 15 Pro physical devices
I tried on simulator iphone 15 and Iphone 15 Pro- ios 17.0.0 - and there is no issues
This is breaking production devices also
Target Device :
Iphone 15 Pro (Physical)
IOS v17.0.2
Xcode 15
There is no error in console, will have to debug further and edit this post
But this is where Xcode crash in screenshot below
Issue seems to come from TrustKit need a little update with version 17.0.2 (iphone15)

Something I've noticed that may cause an issue, is that iphone15 Pro (physical), is read as an Iphone16 in singature binaries, I believe this is a mistake from apple, not sure if this affect TrustKit or SSL pining but worth to mention it

I've faced the same issues. Any solution?

@HakanSAYAR
I've successfully solved the issue  by Updating spec repo cocoapods on ios for TrustKit 3.0.3 (was using 3.0.2)
pod repo update
pod install

Then trustkit was updated to 3.0.3 and everything works now
#309


Leafcutter prototype recipe chain

Very very simple, but helps us nail down the mechanics.

@TimJentzsch I'm going to defer to implementation for the exact numbers: I think they're distracting and guaranteed to get out of date here.

Q&A from Discord:

Can a plant "fall back" to a previous growth stage when the number of items in the output goes down again?
Does a plant die if the leaf count goes to zero?
With how many leaves does a plant start? (Zero or more?)
Is there a maximum growth stage or does it keep going up?
Do you have plans yet on how the output capacity should grow with the growth stage? (constant factor, linear, exponential, etc.?)

Off the cuff:

No, otherwise it becomes too frustrating to prevent overharvesting
Yes: model as "must produce at least once every X seconds"
Zero, but see 2
Yes, you need distinct in game models for each
Varies by species for gameplay interest. Start with linear


Unable to log in tonight

Hey guys, I am unable to log into using this app tonight... been using it fine for over a year now. I was able to log in normally when I take this app out of the equation. But while using it I get the below error. While doing some of my own digging. I found in the json file that it is using https://api.zaonce.net. And when I go to that site, it is showing a 404 error page.
<data>
<status>404</status>
<message>Not Found</message>
</data>

Using the root "zaonce.net" domain does redirect me to Frontier (https://www.frontierstore.net/).

Can you post the contents of your log file?
https://api.zaonce.net is the base uri for Frontier's API so a 404 when trying to view it in your browser is expected.

Here you go. And thank you for the quick response.
min-ed-launcher.log

Also, not always, but sometimes I got this error in the cmd prompt.
Couldn't login: Couldn't parse json - ExpectedStartOfValueNotFound, < LineNumber: 0 | BytePositionInLine: 0.

Not OP, but having the same issue. Here's my log file in case it helps:
min-ed-launcher.log

Looks like I'm getting the same. The API isn't returning a JSON document like it normally does. It's only happening with my steam account though; my epic account works fine.
It's possible they've updated their API to expect something that min-ed-launcher isn't sending. I'll have to do some digging.

I know my Steam client updated twice tonight.

Having the same exact issue.
min-ed-launcher.log
Unlinking and linking my accounts fixed it for one launch, but then it went back to the same error afterwards.

I'm thinking this might be a Steam issue. The default launcher no longer logs me in. It appears to be the same for others as well. I think the default launcher caches auth tokens for a while so it might be the case that it worked before because our login info was re-used.

Seems like going switching Steam to the beta branch might fix it.

Didn't work for me personally. Default launcher works just fine, guess I'll just use that until Valve or FDev push a fix.

I see frontier has listed the issue as fixed. I was able to login normally a few minutes ago. Is anyone still unable to login?

First time I tried I got this error.

Second time, worked.


vuejs 2-crud-with-localstorage

Article Checklist
NOTE: (1st time contributors - submit ONLY one article to get familiar with the process, quality, and style-once published, you can then submit any number of articles.)
Preliminary Checks - Formatting and Structure

[ ] Does your article follow any of the suggested structure formats? - see example formats
[ ] Is your article properly formatted in Markdown? - see Github Markdown guide
[ ] Have you used the correct folder and file structure? - see Contribution Guidelines
[ ] Is your article over 750 words? - Tool: Wordcounter.net
[ ] Have you used our preferred heading structure? - H3 (###) and up
[ ] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.
[ ] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.
[ ] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images
[ ] In your PR - add a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.

Grammar Checks

[ ] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid -  Grammarly
[ ] Have you checked your article for readability? - Tool: Hemmingway
[ ] Have you added sources for quotes and images that aren't yours?

Technical Checks

[ ] Are your code snippets properly formatted for syntax highlighting - see Syntax guide

Contribution Guidelines
For first-time contributors and for more details, see Contributing Guidelines

@geoffrey45 done

@EspiraMarvin You have an author folder in your article directory. Please delete this folder ans commit again.

Link to my issue #1220

plagiarism check done

As an FYI we'll be adding a tiered payout label due to the level of revisions and reviews.

@hectorkambow I was inquiring is this not a tech tutorial?


[!] Error installing PinterestSDK

Pre-downloading: PinterestSDK from git@github.com:pinterest/ios-pdk.git
[!] Error installing PinterestSDK
[!] /usr/bin/git clone git@github.com:pinterest/ios-pdk.git /var/folders/pl/yrk05r2513s5slxl14s3m0tc0000gp/T/d20150723-3313-14c28hb --single-branch --depth 1
Cloning into '/var/folders/pl/yrk05r2513s5slxl14s3m0tc0000gp/T/d20150723-3313-14c28hb'...
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Would anyone know why?

You may want to give the https version a try:
https://github.com/pinterest/ios-pdk.git

@KyleJu did that resolve your issue?

I tried using this in my pod file instead and it worked:
'PinterestSDK', :git => 'https://github.com/pinterest/ios-pdk.git'

Glad that worked!

this help me. Please change the link in the documentation page!

thanks, it worked for me!

https://github.com/pinterest/ios-pdk.git
grt !!! it worked !


[Bug] [seatunnel-connector-flink-jdbc] NPE caused by unsigned number jdbc type when JdbcSource generates RowTypeInfo by ResultSet #1283

Purpose of this pull request

Check list

[x] Code changed are covered with tests, or it does not need tests for reason:
[x] If any new Jar binary package adding in you PR, please add License Notice according
New License Guide
[x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

#1316


result annotation sometimes gets added to the wrong workflow

Example in https://github.com/warner/magic-wormhole.rs/actions/runs/35621960
I've got two workflows: audit (which is triggered both by pushes and on a nightly schedule), and push (which is only triggered by a push). The clippy-check step lives in a job on the push workflow, but when I push a change and both workflows run, the clippy results show up as a job in the audit workflow. Sometimes, but not always. I haven't been able to track down what makes it appear in one place or the other.
My workaround was to name the results explicitly (with the name parameter), so at least it doesn't look like the job is being duplicated.
Was the intention that the result annotation got appended to the same job that ran the clippy step? I don't know how Actions' annotation API works, maybe there's an extra workflow-number field that needs to be passed in, and if it defaults to 0, then when multiple workflows are triggered by the same commit, something shows up in the wrong place.
thanks,
-Brian

Hey!
It happens because currently this action creates a separate check run and it just sticks either to some random workflow in the GitHub UI, as they all are invoked for the same commit.
It is indeed very irritating, but so far I have no idea how to fix that :(
Extra links:
https://github.com/actions/toolkit/issues/74
https://github.com/andrewmcodes/rubocop-linter-action/issues/19

@svartalf If the markdown summary were written to the file at $GITHUB_STEP_SUMMARY, it would be attached to the correct workflow, job, and step. See: https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/


BuildScriptBuilder: Do not print a trailing space for empty header lines

The file comment is split on "\n", so "\n\n" creates an empty header
line. Avoid a trailing space to be created in that case as having
trailing whitespace in code is commonly regarded as bad practice, esp.
for code managed in Git.
Signed-off-by: Sebastian Schuberth<EMAIL_ADDRESS>Context
This fixes a small annoyance for people using the gradle init command.
Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

Thanks @sschuberth, I cherry-picked this to release, so this will be in 5.1

@big-guy would you mind adding a quick unit test for this?

done in https://github.com/gradle/gradle/commit/d4b9ec953b187e3b8be496fd17ae8dc602825791#diff-6a2e0031a2a719105603afa430d04adfR49

great, thank you.


Correct type hint for labels parameter of :class:~.Graph

change type hint from bool to Union[bool, dict]

Overview: What does this pull request change?

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

Maybe it would be more inline to have labels be None, not False as a default. Then the type would be Optional[dict]

I'm happy to do this, but then we will lose the automatic labeling, since currently it's no labels vs auto labels vs custom labels (false vs true vs dict).
Lemme know if you want that, or if there's a better design.

I'm happy to do this, but then we will lose the automatic labeling, since currently it's no labels vs auto labels vs custom labels (false vs true vs dict).

Ah I wasn't aware of this. I'd say that the current design could probably be improved upon, but is beyond the scope of this PR.


I changed the port, but it doesn't work.

Issue Type: Feature Request
"liveServer.settings.port": 5500,  I changed my port to "5500",
but it worked "http://localhost:8081/" .
I don't know why I can't change it?
Extension version: 5.6.1
VS Code version: Code 1.35.1 (c7d83e57cd18f18026a8162d042843bda1bcf21f, 2019-06-12T14:30:02.622Z)
OS version: Windows_NT x64 6.1.7601

I am facing the same issue, Any solution for this?


hotfix(serf) properly clean up nodes table and regenerate node name

Full changelog

Properly clean up node tables on SIGTERM and SIGKILL.
Regenerates the serf.id value every time Kong starts/restarts.

Issues closed
Closes #1739.

Deleted the branch without seeing it was an open PR. What is the status of this?


Fix #12: Behavior of 'end' key is incorrect if 'show spaces' is not enabled

This change fixes the inconsistent 'end' key behavior described in #12 and makes it so that the caret always goes to the end of the line, including any whitespace.

Unfortunately this fix doesn't work. Take a long line of slashes and enable word-wrap. In that case textLine.TrailingWhitespaceLength is 0, and subtracting one ends up moving the caret in front of the last slash in the line.


Statistics Page: Not correctly displayed if a lot of libraries are present.

Describe the bug
I noticed some styling issues on my Jellystat instance, especially since I have a lot of libraries.
Environment Details (please complete the following information):

OS: TrueNAS Scale
Browser: LibreWolf
Jellystat Version: v1.1.0
Jellyfin Version: 10.9.11

To Reproduce
Steps to reproduce the behavior:

Go to Statistics page
If you have enough libraries, you see the following style issue

Expected behavior

Tooltip should be always in front and not behind other elements
Using rows would make the appearance much better

Screenshots
Here a screenshot of the current situation. You cannot really see it since I had to blur these parts, but the text elements of Play Count By Day - Last 20 Days and Play Count By Hour - Last 20 Days are in front together with the tooltip. This makes it super difficult to distinguish one element from another.

I modified some css values:

.recharts-tooltip-wrapper.recharts-tooltip-wrapper-left.recharts-tooltip-wrapper-top

Adding z-index: 1; helps to keep the tooltip in front

.p-2.rounded-2.border-0

Adding this value helps to split the tooltip in several rows:  columns: 3 18em;

This is the result on larger screens:

And this on smaller screens. There are two rows instead of three and the tooltip text elements are always in front. But there is still some mess on the background with the library names at Play Count By Day - Last 20 Days and Play Count By Hour - Last 20 Days:

Additional context
Add any other context about the problem here.

This, is just Wow. Il look into reworking this page.

great, thanks!
There are similar issues to the Count By Day - Last 20 Days and Play Count By Hour - Last 20 Days tooltips.
Adding columns: 18em 3; to .recharts-tooltip-wrapper.recharts-tooltip-wrapper-left.recharts-tooltip-wrapper-top helps too, but it for sure needs more works than just that ;)


Map: button to copy the position of the center of the viewport

Sometimes I need to update point geometry in the database. The Map viewer is very helpful but it doesn't allow me to copy the correct coordinate so that I can update it. I have to open a browser and go to an online map, pan to the correct location and copy the latlng.
Describe the solution you'd like
I would like to have a button which inserts the centroid of the map viewport (in the current coordinate system) into the clipboard.
Describe alternatives you've considered
Maybe that is a little hacky but I can't think of a better way other than to make the geometry movable (direct manipulation) to update the geometry within the results panel (but that seems like a lot more work without much additional benefit).
Additional context
Add any other context or screenshots about the feature request here.

Hello @chapmanjacobd,
Thanks for the suggestion!

Implemented basic functionality:

It copies the coordinates formatted as latitude, longitude to the clipboard.
Please note that it intentionally works only when viewed inside DBeaver.

Wrong coordinates are copied, may always be from EPSG:3857

Verified.
Please note that the coordinates are copied according to EPSG:4326 CRS.


feat(rule): add group promotes

doesn't have a test yet, but allows you to base on top of this.
fixes https://github.com/algolia/algoliasearch-client-javascript/issues/1155
see: https://www.algolia.com/doc/api-reference/api-methods/save-rule/#method-param-objectids

This feature can't be merged yet: https://github.com/algolia/algoliasearch-client-specs-internal/issues/118.


Move away from Documents folder

Current coverage is 82.63% (diff: 89.65%)

Merging #101 into master will increase coverage by 0.04%

@@             master       #101   diff @@
==========================================
  Files            27         27
  Lines          1856       1895    +39
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1533       1566    +33
- Misses          323        329     +6
  Partials          0          0

Powered by Codecov. Last update aee03ff...4079a84

This will migrate all files away from documents folder
Deletes the emtpy folder in document
Writes new cached events in library/cache

We should push this out as a release before Christmas I think.


Position Received from UI

We are getting position ranging on 77k but the board dimension is 720x1100 pixels only, please scale accordingly as we discussed earlier.
@sai-deekshith16

Fixed scaling mistakes.

Closed in #117


Documentation incomplete on converting an existing project to expo

Currently the documentation leaves a lot of vital steps like creating an exp.json file, updating to the proper versions for react and react native, and adding expo to package.json. There might even be more steps that need to be taken, but I know at least these ones are needed even though they're not mentioned in the readme.

Tracking the fix for this issue here https://github.com/expo/xde/issues/113

Any plans to update the documentation?


Create facilities tab & display text search results

Overview
This PR adds a facilities list tab which will display a list of text search results as depicted below when the facilities results return from a search of the API. I also added a free text search which currently searches on the name address and country_name fields to narrow down the list of visible results, as well as a "Download CSV" functionality which downloads a list of CSV items.
Additionally, this PR also:

replaces papaparse with a custom utility function to turn a 2d array into a string, which circumvents a bug whereby JSON.parse would sometimes try to parse the OAR ID as a number but fail and instead print NaN to the CSV
adds tests for that newly added utility function
adjusts the contributor list to list them in alphabetical order by name
adjusts the app's DOM structure to make it possible to scroll subcomponents rather than scrolling the entire app
changes the app name in package.json from "redpanda" (which was the legacy name?) to "open apparel registry"

Connects #209
Connects #227
Connects #127
Connects #123
Demo

CSV:
facilities.csv.txt
No results for a search:

Notes
I made #244 for the map interactions because it will need some dedicated thought about how to handle the various possible kinds of interaction.
Testing

get this branch then ./scripts/update
run ./scripts/test and verify that everything passes
./scripts/resetdb
visit the main map page and

verify that the contributors are now listed in alphabetical order by name
make a search and verify that you are navigated to the facilities tab on success
verify that the free text search works as expected
verify that you can download a list of facilities, filtered by your free text search
verify that you can scroll through the facilities and that clicking on any of the list items takes you to its details route

on the Macbook-sized viewport, check that the following pages scroll correctly following the changes I made to the DOM:

/auth/register
/contribute
/profile/:id/
/lists
/lists/:id

download a facility list and verify that that still works, following the changes to replace papaparse

Looking at this now

I'm seeing an odd click target bug when switching tabs in Chrome. Only clicks at the very top or bottom edges of the tab are triggering the state change. Clicks in the middle of the tab are triggering the Material UI animation, but not a state change.

I'm seeing an odd click target bug when switching tabs in Chrome.

Weird! I wonder if I set up the click handlers incorrectly. I tested staging and it's not happening there.

Interesting, I must need to add an ID to another element:

Turns out the correct function signature is:
  handleChange = (event, value) => {
    this.setState({ value });
  };

Adjusted it in 1a05babbb476104b76dd6d5244243a6086a507a1

It is a bit frustrating to loose scroll state on the search results. When navigating back from the details view. Have we done any scroll restoration on other projects that could possibly apply here? This react-router document talks about the issue but does not include a general solution for our issue. https://github.com/ReactTraining/react-router/blob/master/packages/react-router-dom/docs/guides/scroll-restoration.md

It is a bit frustrating to loose scroll state on the search results. When navigating back from the details view. Have we done any scroll restoration on other projects that could possibly apply here?

Make sense. I haven't ever worked on it; the nearest thing to this is the parcel cards sidebar in GARP for which we declined to try to set up scroll restoration.
I'm happy to look into it, but I wonder if it'd make sense as a new card?

I'm happy to look into it, but I wonder if it'd make sense as a new card?
Yes. We can break scroll state restoration into a separate issue.

If you run a search, click back to the search tab, change one of the filters, then click back to the "Facilities" tab you are now in a kind of inconsistent state. We may want to consider one of the following changes to make sure the state of the two tabs are always consistent.

How would you feel about dumping any existing facilities data altogether when the state of the filters changes? That'd also solve an inconsistency between prior data and the new filters before "search" has been clicked.

How would you feel about dumping any existing facilities data altogether when the state of the filters changes?
I think that is a good idea in general, but what would the facilities tab say at that point? If it reverts to the "No facilities were found for that search" message we are in the same situation.

I think that is a good idea in general, but what would the facilities tab say at that point? If it reverts to the "No facilities were found for that search" message we are in the same situation.

Interesting. Maybe we just don't show the tab at all if there are no facilities in the state to display? I'll try it out locally to see how that works.

9a189ee1b245bfed700608a67cc14830bb1ee655 creates a new "no facilities to display" state for the sidebar tab so that it will look like this when there's nothing to show:

In addition, I updated the application state to clear facilities data when any of the search filters change and to drop the markers from the map when the facilities data is cleared. For the latter, I kept the layer around, but just replace the data with an empty geojson feature collection so that no markers will show.

cd088df48235d13d08749e6f617e1b88b675dc1e updates the facilities list to have its height set dynamically based on the viewport size
@jwalgran this is ready for another look!

https://github.com/open-apparel-registry/open-apparel-registry/issues/250 is for scroll restoration
It occurred to me that we may be able to find an infinite scroll library that supports scroll restoration innately. That would also solve potential performance problems if the list of search results was in the thousands.

Rebased this on develop & squashed.

Looking at this now

I am still seeing "Search" on the "Facilities" tab. Consider changing the label to "Filter results" and the placeholder text to "Filter by name, address, or country"

Oof, must have forgot to update this. Will make this change before merging.

Thanks for your help with this!


One thing about the normalization

Thanks for sharing the code. I have one question about the squashing function + cross entropy loss. Do you have some experiments about using softmax + cross entropy loss? Or other normalization method

Hello @tonghe90 , thanks for asking. Yes, we have tested pure softmax + cross entropy and simple cosine normalization + cross entropy. Neither of them were as good as  squashing because squashing is relatively more relaxed compared to cosine, and normalized than direct feature. We are sorry wer did not report the comparison in the paper due to space limitations.


feat(dinero.js): implement toJSON() to serialize output of Dinero object

Implement toJSON() so that calls to JSON.stringify(Dinero()) will return a string. See #22
#22

Thanks @hanxue for working on this, but I'm not going to merge for the reasons I brought up in #22.


Using Nginx reverse proxy returns 404 for the POST to socket.io, but the GET works.

Hi
I am using the angular2-sails sailsService as a backend wrapper for my sails backend, and it has worked great when developing locally using angular-cli. I am not in the process on moving the code onto real servers, and I want to use Nginx to serve the Angular2 app.
So Sails is running on 1338 & Nginx is running on 9080 (testing purposes)
I have created an Nginx proxy config like this:
        location /socket.io/ {
            proxy_pass      http://<IP_ADDRESS>:1338/;
            proxy_redirect  http://<IP_ADDRESS>:1338/ /;
            proxy_read_timeout 60s;

            proxy_http_version 1.1;
            proxy_set_header Upgrade $http_upgrade;
            proxy_set_header Connection "upgrade";

            # May not need or want to set Host. Should default to the above hostname.
            proxy_set_header          Host            $host;
            proxy_set_header          X-Real-IP       $remote_addr;
            proxy_set_header          X-Forwarded-For $proxy_add_x_forwarded_for;

        }

When running the application I am seeing both HTTP 200s and 404s from the Socket.io calls in the browser:

I looks like the sailsService (socket.io) is calling first using a HTTP GET, which returns a HTTP CODE 200 and then it does a HTTP POST, which returns a HTTP CODE 404, and then a GET, then POST, etc.
The Nginx access logs shows:
<IP_ADDRESS> - - [07/Jun/2017:20:56:28 +0200] "GET /socket.io/?__sails_io_sdk_version=0.13.5&__sails_io_sdk_platform=browser&__sails_io_sdk_language=javascript&EIO=3&transport=polling&t=Lo3waeP HTTP/1.1" 200 21961 "http://localhost:8090/login?returnUrl=%2F" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36" "-"
<IP_ADDRESS> - - [07/Jun/2017:20:56:29 +0200] "POST /socket.io/?__sails_io_sdk_version=0.13.5&__sails_io_sdk_platform=browser&__sails_io_sdk_language=javascript&EIO=3&transport=polling&t=Lo3wafr HTTP/1.1" 404 0 "http://localhost:8090/login?returnUrl=%2F" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36" "-"
When I am running using angular-cli (ng serve or npm start) everything works fine.
What could be the issue?

I dont know, why you add an additional proxy for the socket.io path.
I use NginX config like that, for the whole sails application
server {
    listen 8080;

    server_name example.com;

    location / {
        proxy_pass http://<IP_ADDRESS>:1337;
        proxy_http_version 1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection 'upgrade';
        proxy_set_header Host $host;
        proxy_set_header X-Real-IP       $remote_addr;
	proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    }
}

in your app, you define the host and port (in this case host ist example.com and port 8080) where the socket should connect to. and I do not add an proxy redirect....

If you are not passing a host and port, socket.io will connect to the location, where it was requested from.
so opening the app with http://yourdomain.com:9080 will connect to yourdomain:9080

Thanks for the reply, but your config will pass all request to Nginx to the backend, right? My Angular app is not served from Sails. I only use the Sails as a REST api.
My Angular app is being served from Nginx.
    server {
        listen       8090;
        server_name  localhost;
        root /Users/xyz/Sites/dist;
        index index.html index.htm;

        location / {
            try_files $uri $uri/ =404;
        }

        location /socket.io/ {
            #rewrite ^/socket.io/(.*) /$1 break;
            #proxy_pass        http://<IP_ADDRESS>:1338/;
            #proxy_set_header  Host $host;
            #proxy_buffering   off;
            #proxy_set_header Upgrade $http_upgrade;
            #proxy_set_header Connection "upgrade";
            proxy_pass      http://<IP_ADDRESS>:1338/;
            proxy_redirect  http://<IP_ADDRESS>:1338/ /;
            proxy_read_timeout 60s;

            proxy_http_version 1.1;
            proxy_set_header Upgrade $http_upgrade;
            proxy_set_header Connection "upgrade";
            # May not need or want to set Host. Should default to the above hostname.
            proxy_set_header          Host            $host;
            proxy_set_header          X-Real-IP       $remote_addr;
            proxy_set_header          X-Forwarded-For $proxy_add_x_forwarded_for;
        }
    }

so your angular app is behind a proxy and your sails is behind a proxy.
so, than host sour sails under api.mydomain.com on port 80 and your app under whatever, www.mydomain.com or app.mydomain.com also on port 80.
in your nginx you set up 2 listeners on 2 ports, one for sails, one for the app.
in your app you connect to api.mydomain.com:80 and you are fine to go
i will close this issue, because it is related to your NginX configuration and not to this ng2-module.

Hi Joe
Thanks for your reply. I am sorry for the misunderstanding, but my angular2 app is not behind a proxy. The Nginx is serving the Angular2 app using the static HTML built using "ng build" from the root /Users/xyz/Sites/dist folder.
I then want the Angular2 app to connect to the Sails backend using the same hostname:port/api, but the "/socket.io/" has to exist as well apparently.
If I follow your config the Nginx will only work as a reverse_proxy and cannot server the angular2 app from its static HTML files, correct?
How do you serve your angular2 app?

do not connect to the same host/port as your angular2 app is running on. connect to the host/port of your sails application

i host them together in one application, so the built comes into the sails application. and then i connect to the public host

OK, we did that as well originally, but having the sails application serve the static html/javascript, that makes up the angular part of the app, seems like a bad idea. Why not use a web server for serving the static HTML/Javascript/CSS/images? That is what it is good at, right?

sure, you are free to do it in any way. I dont say whats good an whats bad habit. you asked me how I serve an angular/sails app. thats what I do, because sails offers me the webserver right up anyway. in fact, sails is nothing else, than a web server process, just with less features. and behind a NginX, I can enable caching for the static stuff, what reduces payload on the sails application.
but feel totally free on how to achieve your solution. I heavily depends on your needs of your project.
so, splitting it apart, is a way to do so. when the sails service crashes (if not clustered) your frontend is useless anyway. the other way round depends on what you use of sails.


Can't cancel an R job

Hi there,
When an R job starts runnning, I am unable to cancel the job by pressing the cancel button next to the elapsed time counter. It says "canceling" but never does so.

what is your OS and browser version?

Windows 7 and Google Chrome
2015-12-08 12:56 GMT-05:00 Scott Draves<EMAIL_ADDRESS>
what is your OS and browser version?
—
Reply to this email directly or view it on GitHub
https://github.com/twosigma/beaker-notebook/issues/3063#issuecomment-162961891
.

i was just thinking about this.  it's an old problem: https://github.com/twosigma/beaker-notebook/issues/542
will review, thanks for the reminder.

Thanks Scott!
2015-12-08 13:01 GMT-05:00 Scott Draves<EMAIL_ADDRESS>
i was just thinking about this. it's an old problem: #542
https://github.com/twosigma/beaker-notebook/issues/542
will review, thanks for the reminder.
—
Reply to this email directly or view it on GitHub
https://github.com/twosigma/beaker-notebook/issues/3063#issuecomment-162963391
.

this is just a dup now


[BUG] clustering._base should be called clustering.base

Imports from sktime.clustering.base have ceased to work in 0.10.0 since sktime.clustering.base._base was moved to sktime.clustering without renaming _base to base.
This should not have happened without deprecation - it happened without any warning.
It is also inconsistent with all the other modules, where sktime.modulename.base has the base classes.
Hence, one of the two following things should happen:

add a sktime.clustering.base which aliases _base
rename sktime.clustering._base to sktime.clustering.base

FYI @TonyBagnall, @chrisholder. Also see #1978

(is this correct?, i.e., is this a bug?)

I don't think it's a bug, it's a design choice Chris made. I think it makes sense, as we use init everywhere else

well, it's currently the only module whre the BaseSthSth is not in module.base.
It's not consistent with classification, for instance, which has a very similar base class and module design.

I changed classification to _base but it was part of a PR you blocked. Clustering is, by your definition, "experimental" [ref ABC discussions], so we I think this is fine unless you have anyone who has actually objected to it. If there are users wqho object, we could look at changing it, otherwise, it seems to me a good change to make our design more consistent.

I changed classification to _base but it was part of a PR you blocked.

Ah - in-principle, I would not mind, but we need to deprecate if we change public module names.

Clustering is, by your definition, "experimental"

Valid point - on the README the status is given as experimental.
Let's have the discussion on what the base modules should be called.

This has been refactored and is in main now


suite.py: make main() argv as an argument

Instead of using sys.argv implicitly, which is inconvenient for testing.
Signed-off-by: Loic Dachary<EMAIL_ADDRESS>

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1548/
Tests failed for this pull request.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1556/
Tests failed for this pull request.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1557/
Tests failed for this pull request.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1569/
Tests passed for this pull request.


Automatically generating the destination server certificate?

When using nginx as a forward proxy, this module supports importing the root certificate and automatically generating the destination server certificate?
if not, please tell me clues that may be useful, preferably a module like this
thank you！

This module could not do this, its only used as pure HTTP tunnel proxy, just proxying the raw data in the HTTP tunnel.

I'm closing this for now. Feel free to reopen or create a new one if you have any further issues.


Refactor toolbar into an ipywidgets subclass

Created a new dataclass, Toolbar.Item, that defines an entry in the Toolbar.
Once layer_manager_gui() is widgetized, we can move the new Toolbar widget into map_widgets.py.  The code remaining in toolbar.py will become simpler as the view and control separate.
Future work can also include implementing plotly_toolbar the same way.
Note that I uncommented the implementations for the help and gee tool items.  If they are not needed, we can remove them (I think it is better to remove than to keep commented out code)

@bengalin Thank you for working on this. It seems there are some merge conflicts after #1663 has been merged. Can you fix the conflict? Thanks.

Hmm, I somehow managed to close the pull request.  I am still learning how to work with GitHub.  Will see if I can recover this PR post merge or if I need to create a new one.

Is there a "Reopen pull request" on this page from your account?

There is, but it is disabled and says "There are no new commits on the bengalin:widgets branch".  So I guess the commits I have locally are no longer on my remote branch.   I can no longer see your commits

Okay, I managed to fetch and merge locally, and then after some magic the reopen PR button was active again.  So I think we are good?

This is really well done! I tested it and everything works fine. I really like the refactoring. Much more elegant than my previous version. Learned some new tricks from your code. Thank you very much for your contribution!


OCP Formulation

Similar to issue #1, I would move the formulation of the OCP problem in another script.
If possible I would use the same OCP object for both part of the project.
I would create the OcpSinglePendulum that can be used simply for the first part of the project (generation of the dataset).
Then I would use inheritance to create OcpSinglePendulumWithNNCost that extends OcpSinglePendulum by simply adding the terminal cost as evaluated by the neural network.
Note: I assume that you are quite familiar with Python and object inheritance. If not, let me know by writing here and ping me so I don't miss the thread.

For this part I would split the definition of the OCP problem and the solution, like
class OcpSinglePendulum:
    def __init__(self, ...):
        # ...
        pass

    def problem_setup(self, ... config values):
        # Here you define the parameters of the ocp
        # In this way while extending the class you can reuse the previously defined code
        pass

    def solve(self):
        return self.opti.solve()

Could you please review the file Integrate_terminal_cost_MPC.py to make sure I follow the right MPC algorithm?
I'm starting with initial state  * x = [pi/2, 0]* and control input * U = [0,..,0]* N steps.
Then starting the loop:
i from 0 to N:
U* = solve ocp(xi, Uguess = U)
xi+1 = dynamics(xi, u = U*[0])
U = np.pad(U[1:N], (0, 1), 'constant') #pad 0 at the end of U
I got an issue that is:
x[i+1,0] = dt*x[i,1] #dynamics
IndexError: index 200 is out of bounds for axis 0 with size 200

once the code is able to run, I will factorize the formulation of the OCP problem later  @matteodv99tn

Here the issue is related to the index up to which you integrate. You should integrate up to N-1.
The issue is that at each iteration index i you are writing to state i+1.
I imagine that you set N=200, thus range(N) yields i from 0 to 199, but at the last step you are writing to i+1=200 which is not valid (since x is has size 200, valid indexes are 0 to 199)

BTW next time instead of copy-paste code snippets I think it's easier if you use permalinks as reported here. This drives me exactly to the code section you asked me without problem.
Then use markdown syntax to embed permalink inside the issue

When I run MPC over N = 200 time steps, I don't know why the system was converge so quickly which is at the 2 steps.

This shouldn't be possible.
How many cycles does the solver take to reach it's optimal solution?
I will try to look later more deeply at the code
In the mean time I will highly suggest you to refactor the code as I told you above, it will ease next steps
I mean, at this point in time you should just copy the OcpSinglePendulum in another file and import it in the script used for the data generation

I didn't check properly... Did you bound the effort on your input? Can you check if the inputs are either satured or very high values?

When I change the bounded input to -10 to 10, or -5 to 5, the inputs are always reach to the saturation value @matteodv99tn

And still states are always zero (aside the first one)?

Yes, the states are always zero from the second state forward @matteodv99tn

The number of cycles that solver take to reach the optimal solution is n_eval in the picture below, right?

I think that these are function evaluation to estimate different functions and their gradients
Overall it seems to take 1 evaluation to find the solution (i.e. the first guess is considered already optimal)
Probabibly the OCP formulation is not correct

Hi @matteodv99tn , I factorize the code by moving OCP problem to another file, create the https://github.com/Thuong-ironman/OCR_2023/blob/b5b40a7aff4eea136e968212b5d882780eae84d2/OCP_SinglePendulum.py#L8 for the first part and https://github.com/Thuong-ironman/OCR_2023/blob/b5b40a7aff4eea136e968212b5d882780eae84d2/OCP_SinglePendulum.py#L82 for integrating terminal cost in OCP problem.

Why here  you have the OCP problem commented out? Just remove it and that's it..


Address book management

Currently, new addresses and their labels are automatically saved to a local state. When addresses are found to correspond to a domain, the domain is used in lieu of a label. Right now, there are ways to delete saved addresses (simply by clicking X when addresses show up), but no way to edit them. Moreover, addresses of deleted wallets are not automatically removed. The result is saved addresses blow up very quickly, and after using the wallets for a while, the users generally see a bunch of irrelevant addresses at first when they click the address input box.
We should allow addresses to be edited, by adding an edit button, in addition to existing delete button (X). The edit prompt could be a popover, or simply leading the user to a dedicated page where all saved addresses are listed and can be managed. As usual, modal should not be used.
References for starting point:
https://github.com/polymorpher/one-wallet/blob/master/code/client/src/components/AddressInput.jsx

[ ] Able to edit address and label
[ ] Able to remove address when wallet is deleted


[1.9.4] Bad tooltip background color

What happens:
In IO configuration, tooltip about how much liquid is in getting bad background after configuring IO to push.
See video for details: https://youtu.be/u1f0Uc3HKLw
Steps to reproduce:

Place tank
Add some liquid in
Configure IO to push into other tank/conduit

Affected Versions (Do not use "latest"):

EnderIO: 1.9.4-<IP_ADDRESS>_alpha
EnderCore: 1.9.4-<IP_ADDRESS>-alpha
Minecraft: 1.9.4
Forge: 1.9.4-<IP_ADDRESS>9

Thanks for the great report. Fixed in the next build.

Fixed, thanks guys!


adds type hinting

This PR:

adds type hinting to close #72

@cosmicBboy please review in detail as I'm not 100% sure on some of the type hints.
I think to include Pandera's built-in types; pandera.Column and pandera.DataFrameSchema, it will be best to modularize the code first.
Also not sure if it was intentional but I can't push to the repo since it moved to the org, hence the PR from a fork.

restart build

@mastersplinter re: pushing to the repo, I think you may need to reset your remote urls because I had a slight change of heart on the organization name and manually changed it from pandera-labs to pandera-dev

@cosmicBboy note that sphinx-autodoc-typehints produces docstring type hints that look a little different to before:

in this image the fn, and groups come from sphinx-autodoc-typehints while the groupy by is using the docstring specific type hints.
If you're good with this change in style, then I will remove all the docstring specified types.

cool! the sphinx-autodoc-typehints look good to me, I think prioritizing brevity in annotation is the thing to optimize here

I've removed the types from all of the docstrings where a type hint is available.


Changing distribution. Preparing for platform update

Currently we have distribution like

bin

idea.properties

lib
plugins

need change to:

platform/

build$NUMBER$

consulo.sh (consulo.bat, consulo.exe, consulo64.exe)
consulo.properties
consulo.vmoptions

Every platform will be installed inside platform directory. Executable need select last build
What we need

[X] Change distribution in consulo repo

[X] Change logic for select consulo.properties
[X] Change logic for select vm options file

[X] Devkit plugin will not understand new distribution
[X] When downloaded consulo-$OS$-no-jre.tar.gz we need just extract to platform directory, and call restart
Platform

mac

[ ] TODO

linux

[X] Change sh for support platform dir

windows

[X] Need create executable-loader for dll libraries (main executables will be converted to libraries)
[X] Change bat for support platform dir

branch https://github.com/consulo/consulo/tree/newDistribution

Merged into master


feat: Add support for iOS

This Library would break on iOS (see #88). As most people create their app in React Native to build for iOS and Android simultaneously I created a Pod for iOS to mock the native calls. Besides that I added a platform check to bypass the addListener and once functions completely. The library now no longer crashes the iOS build. yarn example ios can be used to start the example app in an iOS emulator. Linters and tests are passing.
All we need to look at is whether autolinking is working correctly, the example app links the Pod manually at this moment.

Unfortunately auto linking does not seem to be working yet. I will submit a new PR once fixed.

Fixed with latest commit

@Jurpp this PR allows to check if the location service is enabled?

@YsnKsy since it is fixing iOS crashes, could you please accept this merge request, please ?


Create default task scheduler

Motivation and Context
There is some evidence of thread starvation, causing parallel sample loads to interfere with each other, and causing the heartbeat/healthcheck thread to be unable to update the keepalive, resulting in K8S pods being bounced that should not be.
What has changed
Added a 'default' taskScheduler for Spring Boot to use.
How to test?
It's hard... but try running multiple sample loads simultaneously. In truth though, we won't really know if this has improved anything until it's had a chance to 'soak' in the integration environment for a while.
Links
Trello: https://trello.com/c/MPRzPGqL

 Revenge of the Spring TaskScheduler


git-sync use "rebase" replace "merge"

git-sync default use "merges the parent branch into the current branch"
i think "rebase the current branch to the parent branch" is more convenient.
or add a parameter

+1 for this.

If we rebase with branches that have been pushed to a remote repository, it will require a force push. Thats fine for feature branches, but just something I prefer to use minimally.

Thanks for the suggestion! Please keep in mind that in the Git Town world, one uses git ship to merge completed feature branches back into the main branch. git ship squashes the feature branch into a single commit before merging. So the particular strategy (merge vs rebase) how feature branches get updated while being developed doesn't matter much in the grand scheme of things, since they both end in the same result once the branch is shipped.
We chose to use merges instead of rebases for multiple reasons:

if there are merge conflicts while pulling, one has to resolve them only once for merges, but multiple times for rebases
rebasing requires a force-push, which is really problematic when a branch is shared between several developers or machines, because it now becomes impossible to do a git pull on the other machine

All of this together makes me hesitant to implement rebases here, or even add a configuration option. I don't see any advantages, and lots of disadvantages. Git Town is designed to make Git easy and robust.
@MasonLiuChn and @JaKXz, what are your reasons to prefer rebases here? Is it just because that's how one would do that normally (without Git Town), or are there other specific reasons?

@kevgo thanks for the detailed answer! I didn't really know about git ship hence my question (since I was doing the squashing manually and was a bit tedious, but I guess less tedious than getting merge conflicts wrong).
Does git ship create a merge commit with the parent branch? It would be great if it didn't so I could just make a PR and review it with my colleagues

@kevgo after looking at the docs for git ship I see the commit-options option, but how can I specify that I don't want the merge to happen?

@JaKXz git git-ship right now creates a normal commit on the main branch that contains the changes from the feature branch, then it deletes the feature branch. No merge commit, but a simple normal commit. See here for an example which commands exactly it runs in the most straightforward use case. Also, have you checked out the screen cast on git-town.com? It explains the different commands, what they do, and how they work together.

@kevgo thanks again for the reply. I'd seen the screen-cast, but I still don't see the case for deleting the branch and making the commit on top of the main branch. I think the typical git flow, even for those working from forks is to make a PR from your working branch, and then when the PR is merged you can use GitHub to delete the branch from your remote. (aside: this is where prune-branches for your fork only #356 would be nice).
I think git ship is a great convenience method for squashing all commits in the feature branch, but the way it is right now, I have to take extra steps to re-create the branch, cherry-pick the new commit, then reset my main branch to the commit before.

@kevgo but to come back to the actual topic of this issue, I think git sync, when on a feature branch should just checkout the main branch, do a regular git sync, and then come back to the feature branch and rebase it on the local copy of the main branch.

I have this rebaseme alias in my .bash_profile, which requires that you specify the main branch:
rebaseme ()
{
    local BRANCH=$(git rev-parse --abbrev-ref HEAD);
    git checkout "$1" && git sync && git co $BRANCH && git rebase "$1"
}

More awesome (according to me, a non-bash programmer) version of rebaseme
function rebaseme ()
{
    if [ -z $1 ]; then
        local BASE="master";
    else
        local BASE=$1;
    fi
    echo "rebasing on $BASE branch, are you sure? [Y/n]";
    read input;
    if [[ $input == "N" || $input == "n" ]]; then
        echo "not rebasing!";
    else
        local BRANCH=$(git rev-parse --abbrev-ref HEAD);
        git co $1 && git sync && git co $BRANCH && git rebase $1;
    fi
}

@JaKXz so on the "main" branch git sync actually rebases the local branch against the remote branch. This is documented in our tests. Same for perennial (long-lived) branches, see here.
So Git Town already does what this ticket has in mind for long-lived branches. If you are on a feature branch, I'm against rebasing. Because (A) merges are safer and easier to resolve when there are conflicts, (B) they don't require a force-push (which breaks other people or machines who have checked out this branch), and (C) when the branch is shipped, all the merge commits get squashed away. So in the end the merge strategy for feature branches doesn't matter at all if you use git ship.
@JaKXz and @MasonLiuChn I recommend you check out git ship, its another cool time and headache saver, and it addresses the issues you raise here.