Could this be made into a template?

The connectors have a template repo which along with the setup.sh script, makes it easier to create our own connector repo.
Could/should something like that be done here?

@nickchomey we actually got that done, pretty recently: https://github.com/ConduitIO/conduit-processor-template

Yup, yup, you're right.:) That page is in the making, we have an open PR for that.:)


Support setting _SHOULD_COPY_NOTEBOOKS using env variable

What does this PR do?

Support setting _SHOULD_COPY_NOTEBOOKS using env variable
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @borda @justusschock @awaelchli @akihironitta

@kaushikb11 does PL_FAST_DOC_DEV replace this? 53d1c03#diff-008dcb3426febd767787b1521f1fe33086313b927ea37eaab86df5fa88a51698R27

it could, it depends if we want to keep this separate or as one configuration :)

Noob q: what's the difference exactly?
I'd say one configuration is good enough

Noob q: what's the difference exactly?

yep, you are right, effectively they do the same :)

Yup, let's close this!


Nullish input of Big constructor results in Error

For example, using Big(null) will cause Error: [big.js] Invalid number while it is common that I can't make sure if the input is not nullish value.
I suggest that Big(null) returns value zero and it logs warning in dev mode.
ref: https://github.com/MikeMcl/big.js/blob/master/big.mjs#L138

IMO not a good idea. BigInt, which is newer than Number, throws error: https://github.com/tc39/proposal-bigint/issues/15


iOS: Popup is closing when background is touched instead of tapped

Currently on iOS, a mopup is closed when a user is touching the background instead of tapping it. This also leads to mopups always closing when the app is swiped into App Switcher mode or similar as the background is touched in the process.
The problem is occurring because the GestureRecognizer in PopUpPageRenderer isn't working anymore (OnTap isn't called). This might also be one of the reason for the changes in the HitTest method in PopUpWindow?
The suggested solution seems to be working but might not be the optimal solution. It attaches the Gesture Recognizer to the View from the ViewController of the PopupPageHandler and uses its Subview in the boundary check.
The solution also seems to fix #95.

Should be up and ready as version 1.3.1


Performance issues when running tests on parallel

When I'm trying to run some UI tests on parallel with a local server on every simulator, those servers are responding very slowly, sometimes response time can be 2-3 seconds, sometimes even more. I'm wondering what can cause such a delay when running tests on parallel, because when running on one simulator, server gives response quickly enough.

try starting multiple local HTTP servers

Still see this issue.
Added a setup in the test suite, to start an HTTP server for each test with a different ports. And response are super slow sometimes :( running tests locally on M1 Pro


Docs Show dev0 For Releases

I'm not really sure what's going wrong with setuptools_scm and git, but the simplest thing would be to just make it so we drop the dev label if its dev0.

We aren't showing version in the docs now.


Add support for icu_current and hospitalized_current

Summary

Add support for icu_current and hospitalized_current
Related to #940
Related to #1000

Changes

Validation for hospitalized and discharged -- will catch locations that were incorrectly noting hospitalized data as cumulative when it should have been current
Fixup Washoe (was incorrectly noting hospitalized data as cumulative when it should have been current)
Add icu_current and hospitalized_current to Mercury News scraper
Add docs

LGTM!


Release - 0.0.1

Features

#5
#7
#8
#9

Chores

#3

Bugs

N/A

Please release 0.1.0 version. Using patch version when you only make backwards-compatible bug fixes (ref: https://semver.org/)


Look for from and size in search body as well

Documentation says:

Though from and size can be set as request parameters, they can also be set within the search body.

This, maybe a bit to cautiously, tries to implement it.

Closing for now until I have time to test it properly.

@Krule Wondering what use case are you trying to support with the patch? I would need to dig deeper into the code, but I think that the current implementation does in fact look into the body?

@karmi If it does, that would be awesome as ATM I am using my own fork to make it work as I want it.
However, after I have closed this PR I took a look at the tests, I have found a few that appear to be ensuring the opposite:
https://github.com/elastic/elasticsearch-rails/blob/master/elasticsearch-model/test/unit/response_pagination_kaminari_test.rb#L301-L308
https://github.com/elastic/elasticsearch-rails/blob/master/elasticsearch-model/test/unit/response_pagination_kaminari_test.rb#L80-L87
As there are test ensuring this, I can only assume that it's intended behavior.

@karmi Use case is simple as:
POST _search
{  "from": n,
   "size": m,
   ...
}

encoded to JSON from hash:
class ElasticsearchQuery
  ...
  def to_hash
    {
      from: from,
      size: size,
      query: { ... },
      ...
    }
  end
  ...
end

Unfortunately, current implementation, as far as I could determine, did not look into body for from and size and I ended with default values. I will also look bit deeper as it would been strange if it's not supported, but I, so far, I have not been able to find the other reason.

@Krule And how do you define the search in the POST _search? Normally, in a Rails context, you do something like this: https://github.com/elastic/elasticsearch-rails/blob/master/elasticsearch-rails/lib/rails/templates/03-expert.rb#L213

@karmi In my case was equivalent of:
Article.search(ElasticsearchQuery.new(params).to_hash).results

with from and size as part of the hash. This did not work without the patch. However, once i changed it to equivalent of:
Article.search(ElasticsearchQuery.new(params).to_hash).page(params[:page]).results

everything worked as intended.
This, for my current implementation, is sufficient.
However, elasticsearch does allows these parameters as part of the search body and I think pagination should also attempt to use them, provided they are not set as request params and not already implemented as part of pagination in this gem.


linked storehouse HR graphics seems outdated compared to all others

compare https://github.com/Warehousing/Warehousing/blob/master/src/graphics/entity/storehouse/storehouse-linked.png
with
https://github.com/Warehousing/Warehousing/blob/master/src/graphics/entity/storehouse/hr-storehouse-active-provider.png
e.g.

the linked storehouse doesn't match all the other storehouses.

Huh, that is odd. I admit to not testing the Linked variants much in #88 since they aren't available in a normal game.
Let's see if @Anoyomouse has the graphics assets, or if not we can try to reach @snouz.
It can probably be fixed as a pixel edit if necessary, but first I'd like to see if we can do it "the right way". There's some other graphics stuff going on in #118 that I'd rather finish up before moving on to this, anyway.

Aww, too bad @ sources. I'll try to get to this by the end of this weekend. Gives @snouz a few more days to surface and rescue me from pixel peeping 🙃

@hgschmie Have a look at #123, and let me know if I missed anything stupid :)


Adapt the benchmark APIs to the many fidelities

Codecov Report

Merging #2 (556c57c) into main (52cf527) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage   96.59%   96.59%
=======================================
  Files           5        5
  Lines         382      382
  Branches       50       50
=======================================
  Hits          369      369
  Misses         10       10
  Partials        3        3


Reformat file to follow style guidelines.

Fixes #446

CI is wedged. I'm going to override and merge this issue anyway.


chore(master): release 1.1.117

:robot: I have created a release beep boop
1.1.117 (2023-07-13)
Miscellaneous

deps: update dependency @tailwindcss/forms to v0.5.4 (2ad0b1d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/keywind/releases/tag/v1.1.117 :sunflower:


Performance issue with "for"

According to the documentation for str f  = concats (with str f), but they have very different performance. Let's try a contrieved example using with first.
main :: IO ()
main = S.effects . S.concats . flip S.with S.yield $ S.each [1..20000]

This performs quite reasonably:
       8,360,600 bytes allocated in the heap
         245,616 bytes copied during GC
          35,824 bytes maximum residency (2 sample(s))
          50,192 bytes maximum slop
               5 MB total memory in use (0 MB lost due to fragmentation)

                                     Tot time (elapsed)  Avg pause  Max pause
  Gen  0         6 colls,     6 par    0.000s   0.001s     0.0001s    0.0005s
  Gen  1         2 colls,     1 par    0.000s   0.001s     0.0003s    0.0006s

  Parallel GC work balance: 0.31% (serial 0%, perfect 100%)

  TASKS: 6 (1 bound, 5 peak workers (5 total), using -N4)

  SPARKS: 0 (0 converted, 0 overflowed, 0 dud, 0 GC'd, 0 fizzled)

  INIT    time    0.000s  (  0.001s elapsed)
  MUT     time    0.000s  (  0.003s elapsed)
  GC      time    0.000s  (  0.001s elapsed)
  EXIT    time    0.000s  (  0.000s elapsed)
  Total   time    0.000s  (  0.005s elapsed)

  Alloc rate    0 bytes per MUT second

  Productivity 100.0% of total user, 62.1% of total elapsed

What about for?
main :: IO ()
main = S.effects . flip S.for S.yield $ S.each [1..20000]

Now things get interesting:
  25,709,918,336 bytes allocated in the heap
   9,582,313,464 bytes copied during GC
       3,345,424 bytes maximum residency (1845 sample(s))
       4,580,976 bytes maximum slop
              20 MB total memory in use (0 MB lost due to fragmentation)

                                     Tot time (elapsed)  Avg pause  Max pause
  Gen  0     13035 colls, 13035 par   22.609s  16.827s     0.0013s    0.0743s
  Gen  1      1845 colls,  1844 par    3.719s   3.461s     0.0019s    0.0323s

  Parallel GC work balance: 4.54% (serial 0%, perfect 100%)

  TASKS: 6 (1 bound, 5 peak workers (5 total), using -N4)

  SPARKS: 0 (0 converted, 0 overflowed, 0 dud, 0 GC'd, 0 fizzled)

  INIT    time    0.000s  (  0.001s elapsed)
  MUT     time   10.891s  ( 10.745s elapsed)
  GC      time   26.328s  ( 20.288s elapsed)
  EXIT    time    0.000s  ( -0.002s elapsed)
  Total   time   37.219s  ( 31.031s elapsed)

  Alloc rate    2,360,738,555 bytes per MUT second

  Productivity  29.3% of total user, 34.6% of total elapsed

Not quite sure what goes wrong here, but at least it's easy to work around by always using with instead of for.

I just tested this, and the second one is actually faster! Pasting my code here.
module Main (main) where

import qualified Streaming as S
import qualified Streaming.Prelude as S

main :: IO ()
main = S.effects . flip S.for S.yield $ S.each [1..20000]
--main = S.effects . S.concats . flip S.with S.yield $ S.each [1..20000]

compiled with: ghc Main.hs -prof -rtsopts
ran with: ./Main.hs +RTS -s
Output of main = S.effects . S.concats . flip S.with S.yield $ S.each [1..20000]:
      21,210,992 bytes allocated in the heap
         114,120 bytes copied during GC
          38,008 bytes maximum residency (2 sample(s))
          27,528 bytes maximum slop
               2 MB total memory in use (0 MB lost due to fragmentation)

                                     Tot time (elapsed)  Avg pause  Max pause
  Gen  0        19 colls,     0 par    0.000s   0.000s     0.0000s    0.0003s
  Gen  1         2 colls,     0 par    0.000s   0.000s     0.0001s    0.0001s

  INIT    time    0.000s  (  0.000s elapsed)
  MUT     time    0.006s  (  0.006s elapsed)
  GC      time    0.001s  (  0.001s elapsed)
  RP      time    0.000s  (  0.000s elapsed)
  PROF    time    0.000s  (  0.000s elapsed)
  EXIT    time    0.000s  (  0.000s elapsed)
  Total   time    0.007s  (  0.007s elapsed)

  %GC     time       7.1%  (7.1% elapsed)

  Alloc rate    3,293,971,413 bytes per MUT second

  Productivity  89.9% of total user, 90.0% of total elapsed

output of main = S.effects . flip S.for S.yield $ S.each [1..20000]:
      13,076,608 bytes allocated in the heap
         165,664 bytes copied during GC
          38,008 bytes maximum residency (2 sample(s))
          27,528 bytes maximum slop
               2 MB total memory in use (0 MB lost due to fragmentation)

                                     Tot time (elapsed)  Avg pause  Max pause
  Gen  0        11 colls,     0 par    0.000s   0.000s     0.0000s    0.0004s
  Gen  1         2 colls,     0 par    0.000s   0.000s     0.0001s    0.0002s

  INIT    time    0.000s  (  0.000s elapsed)
  MUT     time    0.004s  (  0.004s elapsed)
  GC      time    0.001s  (  0.001s elapsed)
  RP      time    0.000s  (  0.000s elapsed)
  PROF    time    0.000s  (  0.000s elapsed)
  EXIT    time    0.000s  (  0.000s elapsed)
  Total   time    0.005s  (  0.005s elapsed)

  %GC     time      13.6%  (13.6% elapsed)

  Alloc rate    2,926,983,265 bytes per MUT second

  Productivity  82.4% of total user, 82.5% of total elapsed

which actually seems to perform better.

It would be helpful if you pasted the full code, how you compiled it, and how you ran it.

I'm tempted to say that this is fixed, but I'd like to see how you ran/compiled your code.

Ok, no worries.


TypeScript definitions update: 'strictNullCheck' and 'onXxxCapture' events

Added strict null checks for typings
Changed class and className types to string (preact 8 changes)
Added most common capture event typings that were constants in preact 7
Added onReset event
Removed linkState

Coverage remained the same at 100.0% when pulling ad3bcfe1d08cabb961f39b30815df9e3338b8f7a on arusanov:master into 9e1dd185bb1d6505c35477d8101c886c25dc51c8 on developit:master.

Coverage remained the same at 100.0% when pulling 38ecad8b9d0d912101d7d1ebdfa26d12dfee4d20 on arusanov:master into 468cd25c2795f2f7a91770c402f2cad7cd4cb7e4 on developit:master.

Coverage remained the same at 100.0% when pulling 40c2ab121e0c4f841e92997ec0c56f6198143dcd on arusanov:master into 80ad4367e5352cbf6720f973a4488f6504498eb9 on developit:master.

Coverage remained the same at 100.0% when pulling 52bb00e07a77755540ec85c8e8ee541b3df3b5f0 on arusanov:master into 80ad4367e5352cbf6720f973a4488f6504498eb9 on developit:master.

Coverage remained the same at 100.0% when pulling 2d27f49c6386bda52e88fa06f6ba27b862922f38 on arusanov:master into 80ad4367e5352cbf6720f973a4488f6504498eb9 on developit:master.

@robertknight @developit ?

Coverage remained the same at 100.0% when pulling ac2d60257995ff71f0adb66024f56803dab4e7c2 on arusanov:master into ca2d9217a7d60f0ae17d8be07297e301d4638e3f on developit:master.

strict null checks and more was already submitted https://github.com/developit/preact/pull/621

Anyway this PR contains type changes for preact 8.x and some missing event like onLoad, onResize etc

Coverage remained the same at 100.0% when pulling fd86ec739642014b0a88447f93ad0ff69ecf7e88 on arusanov:master into 476772580fd41178d652626d148cd8d4a7478348 on developit:master.

yup I know

I guess @marvinhagemeister can close this as more better typings was already merged

@arusanov I see, would love to get the class/className change in master, though :)


Make safe for universal rendering

I do universal rendering of my site with a node, React, webpack/babel setup. On the server side, my import fails because "document" is not defined. I don't use pym on the server-side (I only use it in react's componentDidMount handler), but I need the library not to fail if "document" is not defined (so that I can reuse my code). I believe it's a simple matter of changing the following line for the npm packaged version:
lib.autoInit();
to
if(typeof document !== "undefined") {
lib.autoInit();
}
or something similar.

Makes sense to me -- Pym's javascript is a little old skool at this point; would be good to integrate better with webpack etc.

What I suggested was one solution, but ideally, an imported npm package should define but not execute code at all, regardless of whether "document" is defined. It could export an "autoInit" function, but not execute it until the developer decides.

@quickhand Sorry for the silence....I have found a slot to take a look at pym again and check issues and PRs. I will be actively working on a new release 1.2.0 for mid March. Your suggestion will be included in that release. Even though I understand and can even agree on your opinion of having code executed automatically can lead to some issues, there are benefits in that approach (pym.js is embedded in many different configurations, many of which have important restrictions on what can be included on the parent page, and having pym automatically executing autoInit on the parentPage simplifies the workflow a lot for some of our users).
Anyhow we will remove the execution if there's no document to allow for clean builds on the server side. Thanks for pointing that out to us. and stay tuned...


"null" in exported excel file

Hi,
First of all thanks for putting together this work. After a little bit of tinkering, I was able to get it work.
Somehow the excel it generated has "null" in the first row, as in the following screenshot:

I assume this is something that can be passed from meta prop, but somehow the following meta didn't make a difference:
        json_meta: [           [{             "key": "charset",             "value": "utf-8"           }],           [{             "key": "head",             "value": "Raw Data"           }]         ]
Am I missing anything?
Also on a side note, any chance to add a function to export simple CSV file?
Thanks again.

I have a feeling it's because metatags is being initialized as "null" then string concatenation after that.  I think initializing as '' instead of null will fix this issue.

correct, replace null with ''


Installation Issue

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
I followed all the steps in the docker installation page, but when I set up the docker, I got the error shown in the screenshot. I tried this on both Windows and Mac docker.

Expected Behavior
No response
Steps To Reproduce
No response
Relevant log output
No log output.

Screenshots
No response
Additional data
No response
Type of installation
Docker
Version
v.1.29.1

I fixed the installation issue. It turned out to be caused by not confirming my Docker email address.


FEAT: Open in new tab #89

@intellegento Did you get assigned to this ?

yep!

yep!

I dont see you being assigned to this task. From now onwards make sure youre assigned to a task to start working on it. Thankyou for your contribution.


Update/pin lints (pedantic? something else?)

Related discussion: https://github.com/dart-lang/site-www/pull/1016#discussion_r204196792

At a minimum, I think updating the templates to drop them is great.
Not 100% sure about enabling the lints for end users, though...

1.8.0 pedantic includes unnecessary_new & unnecessary_const, as does the stagehand options file. When we update to 1.8.0, we should remove duplicate declarations (such as unnecessary_new & unnecessary_const) from the the stagehand options file.

We should avoid having a free-floating pedantic dependency, since that's likely to break code whenever devs do a pub upgrade.
If we continue to use pedantic, we should have something like this in each template's analysis_options.yaml file:
include: package:pedantic/analysis_options.1.9.0.yaml

Currently, the analysis options files have something like this (which I'm calling a free-floating pedantic dependency):
include: package:pedantic/analysis_options.yaml

/cc @mit-mit

I'd recommend pinning to pedantic 1.8.0 for now. We're investigating using a different default set of lints, so no reason to push additional lints right now.


Single consumer name will not be correctly resolved from catalog

Describe the bug
Application with a single consumer will not resolve the name of the function correctly due to missing consumer branch in AbstractSpringFunctionAdapterInitializer.initFunctionConsumerOrSupplierFromContext.
The part of the code will try to retrieve the name of the function, if only 1 function is present in a function catalog. However it only checks for suppliers and functions, not for consumers. Therefor consumers will not be correctly called.
Sample
    @Bean(name = "some-consumer")
    public Consumer<String> someConsumer() {
        return (input) -> {
            doStuff(input);
        };
    }

Resolved with 013e714


https redirect

I set up Dockerfile.nginx

set up nginx_TLS.conf

Trying $host$request_uri
$host:8443$request_uri and redirect working how on screenshot

Any url working how https://host/request_uri:port, but should https://host:port/request_uri
Trying SSL_REDIRECT=True in setting.dist.py, but cert not working(https not working)

what happens if you follow the instructions in our docs / DOCKER.md?

Closing due to inactivity. Feel free to reopen if still valid.


update examples to use the fork

Replace xt0rted with alessbell with the readme examples.

By the way, @alessbell, thanks for your work on this!

I just noticed the v2 tag of your repo is not up-to-date.
In case you don't know how to overwrite it:
# On your fork's main branch
git tag v2 -f
git push origin tag v2 -f


Remove duplicate cfg_attr

This removes the duplicate cfg_attr that is leading to docs.rs build failures.
I ran the docs.rs build locally and it finished successfully - though strangely it's failing for 0.3.6 whereas their build finished successfully (even though both cfg_attrs are already there)

Thanks for noticing and figuring out what it was. I've released the new version as 0.3.8 :crossed_fingers:


DiskArray Multi Element Updates

Currently DiskArray supports update and pushBack elements that take in single elements. This can be quite slow when updating many elements (e.g., when inserting a batch of updates). We need faster support for updating and inserting a batch of elements in DiskArray level.
Once this feature is implemented to DiskArray, we should change our update functions (e.g., CSR reconstruction algorithms) to use it when possible.

This is stale now.


how to Additional Data filtering?

how to Additional Data filtering?

This Additional Data is part of the request info<EMAIL_ADDRESS>and we are only indexing specific fields in the extended data. For now, if you want a specific field indexed and searchable you need to put the simple field in the events data dictionary via EventBuilder.SetProperty("name", value) or event.data["name"] = value; Then you can search by it by doing data.name:value. Does this work for you?
@ejsmith what do you think about this? We aren't indexing cookies, form fields or other things either and I'm not sure we should be either.

Yeah, I would recommend adding the thing you want to search by as a custom property on the event.  Then you can use data.myproperty:somevalue in the search box.


⚠ Bofrost.be has degraded performance

In 79c86a6, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1070 ms

Resolved: Bofrost.be performance has improved in cbb8139 after 6 minutes.


Allow to override session timeout.

This comes useful as it can be overriden from the SDK now
@xetorthio :bell:

Yeap. Much better
On Fri, Jan 27, 2017, 22:43 Marcos Nils<EMAIL_ADDRESS>wrote:

@marcosnils commented on this pull request.
In handlers/new_session.go
https://github.com/franela/play-with-docker/pull/86:

@@ -9,14 +9,19 @@ import (
)

func NewSession(rw http.ResponseWriter, req *http.Request) {

if !services.IsHuman(req) {

req.ParseForm()
challenge := req.Form.Get("g-recaptcha-response")
if !services.IsHuman(challenge) {

You're right, I took the logic outside the function mainly because parse
form needs to be done outside. I can still send the request anyways and
parse the form in the NewSession function.
Does that sound right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/franela/play-with-docker/pull/86, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIhpzZfwJDkDl3_DxVRdeKJjmU9jlCGks5rWp1YgaJpZM4LwJDf
.

@xetorthio plz review.


Query promotion from website

Code changes for "query promotion" and associated behave tests.

Codecov Report

Merging #93 (88eaab3) into main (9dbd231) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   95.73%   95.73%
=======================================
  Files           6        6
  Lines         258      258
=======================================
  Hits          247      247
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dbd231...88eaab3. Read the comment docs.


[BUG]  Sports Widget doesn’t display Premier League image correctly

Environment
Self-Hosted (Docker)
Version
2.0.8
Describe the problem
In Safari on iOS (iPad and iPhone), the image for Premier League games is the wrong size meaning only the background colour shows.
The image is definitely loading as it can be long pressed and saved to photos.
Please see the following image:

Additional info
No response
Please tick the boxes

[X] You are using a supported version of Dashy (check the first two digits of the version number)
[X] You've checked that this issue hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

Reopening after starring repo


Add 'log' function to PostgresModule

Fixes Issue 173

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jgarciasastre seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


RDMA build failure with 1.10

Compile failed with RDMA on.
src/brpc/rdma/rdma_endpoint.cpp:1260:51: error: ‘class brpc::Socket’ has no member named ‘_bthread_tag’; did you mean ‘_read_buf’?
This field was removed by commit 122355a29e2dd3341ad6f47e17682b482c45b7e4.

@chenBright 看一下，好像是之前的改动不兼容了

@Alvicne 更新master试试


Maximum of query limit parameter 10.000?

Describe the bug
When querying QL's API, e.g. an attribute of an entity:
According to the docs (well, I refer to these since the link in the docs doesn't seem to work) the limit parameter can be set to limit the output. The default value is 10.000.
So far so good, if I query without any query paramter I get up to 10.000 values, if I query "[...]?limit=10" I get only 10 values but 10.000 seems to be the maximum value handled by QL. "[...]?limit=10.001" gives the same amount of data than with 10.000.
To Reproduce
Steps to reproduce the behavior:
Push more than 10.000 values for one attribute to cratedb.
Query QL for that attribute with and without the limit parameter.
Expected behavior
Since I would like to query for more than 10.000 (e.g. 100.000 values or even all saved values) I expect the limit parameter to work for values greater than 10.000.
Environment (please complete the following information):

OS: Orion:2.5.2, mongoDB:4.2.2, QL:fix-256 and crateDB:4.2.2 run in docker on Ubuntu 18
Any rest client

Hello @SBlechmann, thanks for using QuantumLeap :-)
Did you try using the offset parameter? In principle you should be able to paginate results, so that you can fetch e.g. pages of 10,000 results at a time as in:
...? offset=0     & limit=10000 ...      # fetch the first 10,000 query results
...? offset=10001 & limit=20000 ...      # fetch the next 10,000
...

One thing to keep in mind with pagination though is QuantumLeap doesn't snapshot query pages, so there's no guarantee the results fetched by a page will be consistent w/r/t the initial query. In more detail, call q the query predicate and D the device table it targets so that the query result set at the initial time t0 when you first run the query is
R( t0 ) = { q(r) | r ∈ D at time t0 } = { r0, r1,  ..., r[n] }

Now a "page" of R( t0 ) is a subset
P(t0, k, k+m+1) = { r[k], r[k+1], ..., r[k+m] }    # k = offset, k+m+1 = limit

So far so good. Except this isn't an accurate model for what QuantumLeap actually does. In fact, every time you fetch a page, QuantumLeap runs again q against D, recomputing the result set. So if t1 > t0, there's no guarantee
P(t0, k, k+m+1) = P(t1, k, k+m+1)

Is this a train smash in practice? In my opinion it isn't, as long as you use a toDate query parameter to make q likely to return the same result set every time it gets run
...? toDate=2021-01-01T00:00:00+00:00 & offset=10 & limit=100

Under the (fair?) assumption you seldom delete records (this is a historical record set after all), then pagination should be consistent across time, i.e. if t < u are two points in time, then P(t, ...) = P(u, ...).
One last word of caution. We still need to work on improving the query subsystem. See e.g.

https://github.com/smartsdk/ngsi-timeseries-api/wiki/The-Mother-of-all-Queries
https://github.com/smartsdk/ngsi-timeseries-api/wiki/Issues

Hello @SBlechmann, thanks for using QuantumLeap :-)
Did you try using the offset parameter? In principle you should be able to paginate results, so that you can fetch e.g. pages of 10,000 results at a time as in:
...? offset=0     & limit=10000 ...      # fetch the first 10,000 query results
...? offset=10001 & limit=20000 ...      # fetch the next 10,000
...

One thing to keep in mind with pagination though is QuantumLeap doesn't snapshot query pages, so there's no guarantee the results fetched by a page will be consistent w/r/t the initial query. In more detail, call q the query predicate and D the device table it targets so that the query result set at the initial time t0 when you first run the query is
R( t0 ) = { q(r) | r ∈ D at time t0 } = { r0, r1,  ..., r[n] }

Now a "page" of R( t0 ) is a subset
P(t0, k, k+m+1) = { r[k], r[k+1], ..., r[k+m] }    # k = offset, k+m+1 = limit

So far so good. Except this isn't an accurate model for what QuantumLeap actually does. In fact, every time you fetch a page, QuantumLeap runs again q against D, recomputing the result set. So if t1 > t0, there's no guarantee
P(t0, k, k+m+1) = P(t1, k, k+m+1)

Is this a train smash in practice? In my opinion it isn't, as long as you use a toDate query parameter to make q likely to return the same result set every time it gets run
...? toDate=2021-01-01T00:00:00+00:00 & offset=10 & limit=100

Under the (fair?) assumption you seldom delete records (this is a historical record set after all), then pagination should be consistent across time, i.e. if t < u are two points in time, then P(t, ...) = P(u, ...).
One last word of caution. We still need to work on improving the query subsystem. See e.g.

https://github.com/smartsdk/ngsi-timeseries-api/wiki/The-Mother-of-all-Queries
https://github.com/smartsdk/ngsi-timeseries-api/wiki/Issues

Hey @c0c0n3,
sorry for the late response and thanks for your fast answer and your suggestion for the well explained problem :)
I just found this issue where you explained the behavior of the limit parameter. Maybe we could add this to the docs or was I just to blind to see it in the first place?
Yes, I pretty much think the toDate parameter together with the offset (which I haven't known till now) solve the issue, thanks!
Still, Is there a way to check how many entries there would actually be in order to see how often I have to query with the suggested solution? Otherwise I'd just check whether the length of the index array is <=10.000.

Hey @c0c0n3,
sorry for the late response and thanks for your fast answer and your suggestion for the well explained problem :)
I just found this issue where you explained the behavior of the limit parameter. Maybe we could add this to the docs or was I just to blind to see it in the first place?
Yes, I pretty much think the toDate parameter together with the offset (which I haven't known till now) solve the issue, thanks!
Still, Is there a way to check how many entries there would actually be in order to see how often I have to query with the suggested solution? Otherwise I'd just check whether the length of the index array is <=10.000.

Hey hey,

Maybe we could add this to the docs or was I just to blind to see it in the first place?

No, you're dead right Sir :-) thanks so much for pointing it out. I've opened an issue about it: #419

Hey hey,

Maybe we could add this to the docs or was I just to blind to see it in the first place?

No, you're dead right Sir :-) thanks so much for pointing it out. I've opened an issue about it: #419

@c0c0n3 Unfortunately, the response in this issue is incorrect and does not describe the actual behavior of the API.

the parameter limit does only restrict the number of records returned in one request. This does represent a LIMIT command in SQL

the offset parameter does only move the selection of records and moves only the starting record. Important to note that the usual direction of the records start from the oldest to the newest. In SQL this would be in SQL:
SELECT *  FROM <yourTable> ORDER BY `timeIndex` ASC OFFSET <yourOffset>;

Hence, in combination of both we only need to raise the offset and not the limit:
```sql

SELECT *  FROM  ORDER BY timeIndex ASC OFFSET  LIMIT ;

Be careful if lastN is used because this will revert the ORDER BY direction.
```sql

SELECT *  FROM  ORDER BY timeIndex DESC OFFSET  LIMIT ;

Therefore, I would suggest to reopen this issue!
Cheers

@tstorek thanks so much for this. I'm reopening the issue so we can look at it again. Can you give us an example of where the API is broken? no need to use 10,000 records, 2 per page would do I guess? thanks alot!!


Modify surf/jump timer color

I don't know how it's back to orange but dammit I despise it

May have accidentally been hard-coded or given its own unlisted value? idk, something changed


Segfault when serializing empty array with initial len set greater than 0

The following code leads to Segmentation fault: 11, at least on macOS Sierra 10.12.6.
use "serialise"

actor Main
  new create(env: Env) =>
    try
      let auth = env.root as AmbientAuth
      let a = Array[USize](4)
      Serialised(SerialiseAuth(auth), a)?.output(OutputSerialisedAuth(auth))
    end

The problem is related to passing in an initial len argument greater than 0 to Array.  If you change
    let a = Array[USize](4)

to
    let a = Array[USize]

then it no longer segfaults.
It also no longer sefgaults if you push something onto the array before serializing.
Changing the Array type arg (say, to String) makes no difference.

Running this through lldb gives the place where it segfaults:
Process 492 stopped
* thread #2, name = 'scratch', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
    frame #0: 0x0000555555573d99 scratch`pony_serialise_offset(ctx=0x00007ffff6f95448, p=0x00007fffe5794000) at serialise.c:197
   194 	  // If we are not in the map, we are an untraced primitive. Return the type id
   195 	  // with the high bit set.
   196 	  pony_type_t* t = *(pony_type_t**)p;
-> 197 	  return (size_t)t->id | HIGH_BIT;
   198 	}
   199
   200 	PONY_API void pony_serialise(pony_ctx_t* ctx, void* p, pony_type_t* t,
(lldb) frame var
(pony_ctx_t *) ctx = 0x00007ffff6f95448
(void *) p = 0x00007fffe5794000
(serialise_t) k = {
  key =<PHONE_NUMBER>16736
  value =<PHONE_NUMBER>92280
  t = 0x00007fffe67938f0
  mutability = 3
  block = false
}
(size_t) index = 0
(serialise_t *) s = 0x0000000000000000
(pony_type_t *) t = 0x0000000000000000

If I change to
use "serialise"

actor Main
  new create(env: Env) =>
    try
      let auth = env.root as AmbientAuth
      let a = Array[USize].undefined(4)
      Serialised(SerialiseAuth(auth), a)?.output(OutputSerialisedAuth(auth))
    end

then there is no crash from my testing. I'd like someone to confirm.

I can confirm that on Windows the original code segfaults and Sean's change does not.


Why are you implement BC in 2.0.x releases?

For example.
Using Bootstrap Collapse. After update from 2.0.1 to 2.0.4
Invalid Configuration – yii\base\InvalidConfigException The "content" option should be a string or array.
it shouldnt contain any bcs only fixes, new features an enhancements or am i wrong?
And the next problem if youre going to implement a BC why not note it in https://github.com/yiisoft/yii2/blob/master/framework/UPGRADE.md ?

We're trying to keep BC but sometimes breaking changes are getting in (usually accidentally). If it's not mentioned in upgrade for either framework or extension it could be considered as documentation bug and should be fixed.

thats the commit
https://github.com/yiisoft/yii2-bootstrap/commit/599d60c376eaf9dedac0b8b5f48099beabefbe5b#diff-e2c8b04a3abee6260473c9f21e76bf7eL138
$content cant be an object anymore like an for example ActiveField.

According to docs it was never meant to. It specifies string as type.

yeah i saw. but it was working. nevermind than maybe make an enhancement out of this issue.
like
if (is_string($item['content']) || is_object($item['content'])) {
                $content = Html::tag('div', $item['content'], ['class' => 'panel-body']) . "\n";
            } elseif (is_array($item['content'])) {
                $content = Html::ul($item['content'], [
                    'class' => 'list-group',
                    'itemOptions' => [
                        'class' => 'list-group-item'
                    ],
                    'encode' => false,
                ]) . "\n";
                if (isset($item['footer'])) {
                    $content .= Html::tag('div', $item['footer'], ['class' => 'panel-footer']) . "\n";
                }
            } else {
                throw new InvalidConfigException('The "content" option should be a string, array, or object.');
            }

Yep. That would work.


[HOLD for payment 2024-07-26] [$250] Workspace - Workspace name reverts back to previous one if created and changed offline

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4635388&group_by=cases:section_id&group_id=229065&group_order=asc
Issue reported by: Applause - Internal Team
Action Performed:

Log in with any account
Go offline
Create a workspace
Change it's name while offline
Go online

Expected Result:
Workspace name should remain as it is edited while offline
Actual Result:
Workspace name reverts back to default one (after few seconds) instead of the edited workspace name after going online. Affects Gmail and expensifail accounts too
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/9d797889-0c5d-4a8c-bbbf-6a3a0d57536c
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a9ae643def6b9e4e
Upwork Job ID:<PHONE_NUMBER>231444547
Last Price Increase: 2024-07-11
Automatic offers:

suneox | Reviewer | 103096636
huult | Contributor | 103096638

Issue OwnerCurrent Issue Owner: @johncschuster

@johncschuster  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Asking for a retest/clarification on repro steps in Slack

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

I am  able to reproduce.
https://github.com/Expensify/App/assets/43996225/ab8c2c8c-40c1-4736-b509-e9217956619c

@suneox can you try again?

Bumped Slack for proposals again

Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace name reverts back to previous one if created and changed offline
What is the root cause of that problem?
When the user creates a new workspace while offline, the request will be persisted to disk. When the user edits the workspace name, this request does not update the previously persisted data, resulting in the display of the old workspace name.
What changes do you think we should make in order to solve the problem?
We should update the persisted data of CreateWorkspace when updating the workspace profile in offline mode.
// App/blob/main/src/libs/actions/Policy/Policy.ts#L1063
+    const allPersistedRequests = PersistedRequests.getAll();

+    allPersistedRequests.forEach((request, index) => {
+        if (request.data && request.data.policyID === policyID && request.data.policyName !== name) {
+            const persistedRequestClone = _.clone(request);
+            persistedRequestClone.data = deepReplaceKeysAndValues(request.data, request.data.policyName , name);
+            PersistedRequests.update(index, persistedRequestClone);
+        }
+    });

// // Need to check more conditions to avoid calling [UPDATE_WORKSPACE_GENERAL_SETTINGS]()

What alternative solutions did you explore? (Optional)

here is my PR

Acknowledged! I will issue payment once the regression window is passed 👍

@cristipaval, can you take a look to see if the linked PR caused a regression?

@cristipaval, can you take a look to see if the linked PR caused a regression?

@johncschuster, as @suneox stated, the PR for this issue revealed another issue with a different root cause. They are related somehow, but I am not sure if it makes sense to add penalties here 🤔

but I am not sure if it makes sense to add penalties here 🤔

Awesome. Thanks for saying that! I won't apply regression penalties then 👍

Not overdue. I'm waiting for the regression threshold window to pass (2024-08-01)

@huult I've issued your payment. Thanks for your contributions!
@suneox can you please complete the BZ Checklist? I'll issue your payment once that's complete.

@suneox Payment has been issued! Thanks for your contributions! 🎉


[BUG] Cython performance regression with untyped NumPy array

Describe the bug
We're attempting to upgrade to Cython 3.0.x in https://github.com/pandas-dev/pandas/pull/55179, but seeing some performance regressions. We've tracked a number of these down to our use of ndarray without any dtype or dimension specified. Is this change in performance expected?
Where we can, we've added the dtype and seen good performance improvements, but there are number of places in our Cython code that need to be able to handle an arbitrary NumPy array.
Code to reproduce the behaviour:
main.pyx:
cimport numpy as cnp
from numpy cimport ndarray

cnp.import_array()

def foo(ndarray arr):
    cdef int n, i
    n = len(arr)
    for i in range(n):
        arr[i] += 1

run.py:
import numpy as np
from main import foo
import time

arr = np.arange(10_000_000)
timer = time.time()
foo(arr)
print(time.time() - timer)

setup.py:
from setuptools import setup
from Cython.Build import cythonize
import numpy as np

setup(
    ext_modules=cythonize("main.pyx"),
    include_dirs=[np.get_include()]
)

Build command:
python setup.py build_ext --inplace

Expected behaviour
When compiling with Cython 0.29.33, the above code takes ~0.63 seconds to run. On Cython 3.0.2, it's ~1.04.
OS
Linux
Python version
3.10.12
Cython version
3.0.2 vs 0.29.33
Additional context
No response

I can confirm the numbers. Checked also against master.

I had a look into the example and I have some comments. But note that I don't have much experience with numpy and it's C API please have a patience with me :-)

why is needed this line: cnp.import_array()? The numpy documentation says[1] that it needs to be used when numpy CAPI is used. But when I had a look into the generated C code function foo() is not using any numpy array. Instead it uses standard python API to access array members (in both 0.29.X and 3.0.X):

Generated C code seems to be the same in both versions, I checked also called __Pyx_* functions but they seems to have same performance in both 3.0 and 0.29.X Cython.

When I have commented out line cnp.import_array() I got same performance in both 0.29.X and 3.0.X cython.

Long story short, it seems that the performance impact has the line cnp.import_array() but not sure why. I am even not sure whether is needed in this example.
[1] https://numpy.org/doc/1.13/reference/c-api.array.html#c.import_array

why is needed this line: cnp.import_array()

It probably isn't needed. But we generally recommend it if there's any doubt. There's a few cases where it's needed in 3.0 and not in 0.29.x. Cython actually generates it automatically if you cimport numpy and omit it because enough people were getting mystery crashes

If I had to guess (and this is a complete guess) we've made some changes to Python object indexing to support things like __class_getitem__(). I suspect it's this.

If I had to guess (and this is a complete guess) we've made some changes to Python object indexing to support things like class_getitem().

Indeed, now I did experiment. I commented out in the loop of generated C file lines as follows:
  for (__pyx_t_4 = 0; __pyx_t_4 < __pyx_t_3; __pyx_t_4+=1) {
    __pyx_v_i = __pyx_t_4;

    /* "main.pyx":10
 *     n = len(arr)
 *     for i in range(n):
 *         arr[i] += 1             # <<<<<<<<<<<<<<
 */
    __pyx_t_5 = __pyx_v_i;
    __pyx_t_6 = __Pyx_GetItemInt(((PyObject *)__pyx_v_arr), __pyx_t_5, int, 1, __Pyx_PyInt_From_int, 0, 1, 1); if (unlikely(!__pyx_t_6)) __PYX_ERR(0, 10, __pyx_L1_error)
    // __Pyx_GOTREF(__pyx_t_6);
    // __pyx_t_7 = __Pyx_PyInt_AddObjC(__pyx_t_6, __pyx_int_1, 1, 1, 0); if (unlikely(!__pyx_t_7)) __PYX_ERR(0, 10, __pyx_L1_error)
    // __Pyx_GOTREF(__pyx_t_7);
    // __Pyx_DECREF(__pyx_t_6); __pyx_t_6 = 0;
    // if (unlikely((__Pyx_SetItemInt(((PyObject *)__pyx_v_arr), __pyx_t_5, __pyx_t_7, int, 1, __Pyx_PyInt_From_int, 0, 1, 1) < 0))) __PYX_ERR(0, 10, __pyx_L1_error)
    // __Pyx_DECREF(__pyx_t_7); __pyx_t_7 = 0;
  }

And it seems that 0.29.X Cython is faster then 3.0.X Cython...

https://github.com/cython/cython/commit/c0ceabe1ee0904477ed0b0b9371ae43915d7bd2f
I'd try reverting that and seeing if the performance changes (just for diagnosis... I don't think we should fix it by just reverting it)

This was introduced in cython 3.0a2 (if I am not wrong) and when I installed 3.0a1 the issue was still present... But please doublecheck me.

c0ceabe
I'd try reverting that and seeing if the performance changes (just for diagnosis... I don't think we should fix it by just reverting it)

This was introduced in cython 3.0a2 (if I am not wrong) and when I installed 3.0a1 the issue was still present... But please doublecheck me.

Yeah you're right. If the issue was still in 3.0a1 then it's probably something else.

If the issue was still in 3.0a1 then it's probably something else.

I think we previously looked for the sequence protocol first and only then considered mappings. That might well make a difference in the case of NumPy. This was changed to match Python's own behaviour.

If I comment out the entire mapping handler part in __Pyx_GetItemInt_Fast(), it becomes ~15% faster for me. That makes the code incorrect, but it does make a major difference in this case.
https://github.com/cython/cython/blob/9827c6085e2141db71c55ae231a4a09a878dd524/Cython/Utility/ObjectHandling.c#L445-L451

So, the issue here is that NumPy implements both the CPython sequence protocol (for simple indexing, length, contains, etc.) and the mapping protocol (for slicing). Since Cython 3.0, we follow Python's behaviour of looking for the mapping protocol before the sequence protocol. Previously, we passed C integer indexes directly into the sequence protocol, ignoring the mapping protocol if both were implemented.
In the specific case of NumPy, this means that we hit a double slow path. First, we have to create a new Python int object from the Py_ssize_t C index to pass it into the mapping protocol, then NumPy receives a generic object and has to determine that we're up to simple indexing, before it can unpack the index into a C integer and look up the array value.
I'm not sure how to deal with this. We're not using the buffer interface here, so the code really is slower than necessary. Should we special-case NumPy for code that could much better be accelerated differently?

but there are number of places in our Cython code that need to be able to handle an arbitrary NumPy array.

Would fused types help here? That's what a couple of projects do, they just create a fused type of all possible NumPy dtypes and then let Cython generate function variants for each of them. Adds a bunch of code, and also the runtime overhead of checking the dtype and unpacking the array accordingly, but if the processing afterwards is non-trivial, or the array is somewhat large, it's probably worth it.

Would fused types help here?

I just tried it on the reported example, and the calculation of a 1,000,000 item array is ~300 times faster with fused types. For 1000 items, it's still about 200 times faster.

I'm not sure how to deal with this. We're not using the buffer interface here, so the code really is slower than necessary. Should we special-case NumPy for code that could much better be accelerated differently?

Just thinking aloud. Does it make sense to add support for abc.collections in cython?
def foo(Sequence arr):
    cdef int n, i
    n = len(arr)
    for i in range(n):
        arr[i] += 1

This would benefit also pure python where it will nicely:
import cython
from collections.abc import Sequence

def foo(arr: Sequence):
    n: cython.int
    i: cython.int
    n = len(arr)
    for i in range(n):
        arr[i] += 1

[1] https://docs.python.org/3/library/collections.abc.html

I don't think the distinction between the Python interfaces Sequence and Mapping is always preserved at the C API level.  E.g. for Cython extension types itself I think we always define __getitem__ under tp_mapping.
I like the basic idea of being able to pick out the fast-path, but not sure how it quite works here.

Ages ago pandas used to have a helper util.get_value_at (https://github.com/pandas-dev/pandas/blob/00416816fa5be34567185149fdfcbf2d0e068af0/pandas/_libs/util.pxd#L32, and under the hood https://github.com/pandas-dev/pandas/blob/00416816fa5be34567185149fdfcbf2d0e068af0/pandas/_libs/src/numpy_helper.h#L26) that we used for arr[i]  At some point I removed it in favor of calling ndarray.__getitem__ directly, but we could re-implement it.

they just create a fused type of all possible NumPy dtypes

IIRC you can't put e.g. np.datetime64 dtypes into a fused type (or declare them non-fused as ndarray[datetime64]).  I don't think that is relevant to the OP's issue, but prevents this from being a cure-all.

Ages ago pandas used to have a helper util.get_value_at (https://github.com/pandas-dev/pandas/blob/00416816fa5be34567185149fdfcbf2d0e068af0/pandas/_libs/util.pxd#L32, and under the hood https://github.com/pandas-dev/pandas/blob/00416816fa5be34567185149fdfcbf2d0e068af0/pandas/_libs/src/numpy_helper.h#L26) that we used for arr[i] At some point I removed it in favor of calling ndarray.__getitem__ directly, but we could re-implement it.

You could also try using the C API function PySequence_GetItem which I think will skip directly to the fast path of the __getitem__ lookup and be simpler than what you used to have.

Last thing that comes to mind: in order to handle unknown-dimension ndarrays pandas has been moving to using a pattern like
    it = <flatiter>PyArray_IterNew(arr)
    for i in range(n):
        val = PyArray_GETITEM(arr, PyArray_ITER_DATA(it))

it's not pretty, and the __setitem__ analogue is really not pretty.  Since the input arrays have unknown ndim, they can't have their types declared.  AFAIK that hasn't killed perf.  So moving to that pattern more is an option.

I don't think the distinction between the Python interfaces Sequence and Mapping is always preserved at the C API level. E.g. for Cython extension types itself I think we always define __getitem__ under tp_mapping.

We define both, with a slower "create PyLong, then delegate" wrapper in sq_item. So preferring sq_item would actually slow down Cython generated code.
I now wonder if we could avoid that wrapper if users defined __getitem__ with a C integer type as index argument, so I created https://github.com/cython/cython/issues/5729 to track the idea.


Improve documentation and code for FileTimeStampInspectors

To highlight the differences as preparation for #13234.

IIUC using Stat helps with using finer-grained timestamps on Windows, right?

Yes, and on Linux with Java 8 as well, see https://github.com/gradle/gradle/blob/3aa01644ecdb59a1daff12a7e6b08538ad94d232/subprojects/native/src/test/groovy/org/gradle/internal/nativeintegration/filesystem/services/NativePlatformBackedFileMetadataAccessorTest.groovy#L44-L45

What is the behavioral change here? Is there a performance impact, too?

There could be a small performance impact for very quick builds, like when everything we snapshot happens at the end-of-the-build timestamp, so we would need to drop it from the file hasher cache. For "normal" build usage, nothing should change.


CI for main is broken

With the merge of https://github.com/bytecodealliance/wasmtime/security/advisories/GHSA-7f6x-jwh5-m9r4 and https://github.com/bytecodealliance/wasmtime/security/advisories/GHSA-5fhj-g3p3-pq9g to the main branch (and the release-0.{38,39.0} branches) CI now appears to be failing across the board. Failure logs include:

[ ] s390x-related all test failures
[ ] aarch64-related SIGKILL failures
[x] s390x filetest failures -- only happens on release-0.{38,39}.0, fixed on main by #4427

I think https://github.com/bytecodealliance/wasmtime/pull/4486 will fix the SIGKILL issues.
I have attempted to reproduce the filetest failures locally and cannot (where I think I'm using the same version of QEMU). @uweigand are you perhaps around to help debug the filetest issue?
I have not investigate the s390x all failures yet.

I've had a quick look, and the filetest failures are due to a newly added test (udiv_i16_const).  However, this test passes natively for me.  Not sure if this is a qemu issues ... I'll have a look.
As to the all tests, those are failed assertions:
multiple uses of vreg with a Stack constraint are not supported

Not sure what exactly this means, but I can reproduce natively.

Ok in that case I think I'm realizing that the ISLE transition for s390x may have fixed the filetest issue. Investigating...

Ok the filetest failures I can confirm were fixed in #4427. The test fails on the release-0.38.0 and release-0.39.0 branches. The tests pass, however, on the #4427 commit (and therefore main).
When the other s390x issue is sorted I think we can backport temporary disabling of s390x running the test on the release-0.{38,39}.0 branches and leave main as-is. Now it's just the all test failures you mentioned.

Initial reduction of the other issue from one failing wasm test case is:
function u0:0(i64 vmctx, i64) fast {
       gv0 = vmctx
       gv1 = load.i64 notrap aligned readonly gv0+8
       gv2 = load.i64 notrap aligned gv1
       gv3 = vmctx
       sig0 = (i64 vmctx, i32 uext) -> r64 wasmtime_system_v
       sig1 = (i64 vmctx, i32 uext, r64) wasmtime_system_v
       stack_limit = gv2

       block0(v0: i64, v1: i64):
           v3 -> v0
           v8 -> v0
           v12 -> v0
           v17 -> v0
           v2 = null.r64
           v16 -> v2
           v4 = load.i64 notrap aligned readonly v0+48
           v9 -> v4
           v13 -> v4
           v18 -> v4
           v5 = load.i64 notrap aligned readonly v4+128
           v6 = iconst.i32 0
           v11 -> v6
           v15 -> v6
           v20 -> v6
           v7 = call_indirect sig0, v5(v0, v6)
           v10 = load.i64 notrap aligned readonly v4+136
           v14 -> v10
           v19 -> v10
           call_indirect sig1, v10(v0, v6, v7)
           call_indirect sig1, v10(v0, v6, v7)
           call_indirect sig1, v10(v0, v6, v2)
           jump block1

       block1:
           return
}

which yields:
$ cargo run -p cranelift-tools -- compile out.clif --target s390x
    Finished dev [unoptimized + debuginfo] target(s) in 0.08s
     Running `target/debug/clif-util compile out.clif --target s390x`
thread 'main' panicked at 'multiple uses of vreg with a Stack constraint are not supported', /home/alex/.cargo/registry/src/github.com-1ecc6299db9ec823/regalloc2-0.3.0/src/ion/liveranges.rs:1339:57
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Reduced a bit further:
function u0:0(i64) fast {
  sig0 = () -> r64 wasmtime_system_v
  sig1 = (r64) wasmtime_system_v

  block0(v0: i64):
    v1 = call_indirect sig0, v0()
    call_indirect sig1, v0(v1)
    call_indirect sig1, v0(v1)
    return
}

Right, from what I can see it seems the problem is related to the fact that v1 is used twice, but also the value is forced to the stack (maybe because it's a reference value live across a call?).
Not sure what this has to do with s390x, though.

Ok the filetest failures I can confirm were fixed in #4427. The test fails on the release-0.38.0 and release-0.39.0 branches. The tests pass, however, on the #4427 commit (and therefore main).

Ah, that makes sense.  As part of #4427 I fixed the following bug found by fuzzing:

a problem with random high bits in sub-word immediates that were not properly zero-extended

This is exactly the problem here (when using the full-word divide instruction to perform a sub-word operation, the inputs must be properly extended or we get wrong results).
The attached minimal backport of just this fix resolves the problem on the release-0.39.0 branch:
diff-s390x-zeroext-fix.txt

@cfallin has found the issue and this fixes the panic:
diff --git a/cranelift/codegen/src/machinst/vcode.rs b/cranelift/codegen/src/machinst/vcode.rs
index f9ef6670f..79959dfa3 100644
--- a/cranelift/codegen/src/machinst/vcode.rs
+++ b/cranelift/codegen/src/machinst/vcode.rs
@@ -606,6 +606,8 @@ impl<I: VCodeInst> VCodeBuilder<I> {
         for reg in self.vcode.reftyped_vregs.iter_mut() {
             *reg = Self::resolve_vreg_alias_impl(&self.vcode.vreg_aliases, *reg);
         }
+        self.vcode.reftyped_vregs.sort();
+        self.vcode.reftyped_vregs.dedup();

         self.compute_preds_from_succs();
         self.vcode.debug_value_labels.sort_unstable();

As to the regalloc2 assertion, I see the following code just before the failure:
TRACE - built vcode: VCode {
  Entry block: 0
  v129 := v130
Block 0:
    (original IR block: block0)
    (instruction range: 0 .. 8)
  Inst 0: lgr %v128, %r2
  Inst 1: basr %r14, %v128
  Inst 2: lgr %v130, %r2
  Inst 3: lgr %r2, %v129
  Inst 4: basr %r14, %v128
  Inst 5: lgr %r2, %v129
  Inst 6: basr %r14, %v128
  Inst 7: br %r14
}

which looks very similar to the code I get on x86_64:
TRACE - built vcode: VCode {
  Entry block: 0
Block 0:
    (original IR block: block0)
    (instruction range: 0 .. 8)
  Inst 0: movq    %rdi, %v128
  Inst 1: call    *%v128
  Inst 2: movq    %rax, %v129
  Inst 3: movq    %v129, %rdi
  Inst 4: call    *%v128
  Inst 5: movq    %v129, %rdi
  Inst 6: call    *%v128
  Inst 7: ret
}

The only difference I can see is that on s390x, we have two vregs that are aliased (v129, v130), while on x86_64 we only have one (v129).  This is pretty sure because s390x now lowers calls via ISLE, where we get the extra aliased copy.
But that shouldn't change the behavior of regalloc2 otherwise.  @cfallin maybe you can help here?

Ok fixes are applied in https://github.com/bytecodealliance/wasmtime/pull/4486 and I will work on backporting this to the release-0.3{8,9}.0 branches for new point releases as well. Thanks for your help @uweigand!

Ok fixes are applied in #4486 and I will work on backporting this to the release-0.3{8,9}.0 branches for new point releases as well. Thanks for your help @uweigand!

Thanks!  For the release branches, maybe you can also add the patch from https://github.com/bytecodealliance/wasmtime/issues/4487#issuecomment-1190707048 to fix the s390x filetest regression as well.


Print output file on failure

Modify the FAILED: output to provide the output files that failed to
build, followed by the failed command on the next line.  This makes the
failure much easier to read, as you can immediately see much shorter
name of the file that failed instead of trying to parse a very long
command line.  It also makes manually re-running the failed command much
easier because you can copy the whole line without ending up with the
FAILED: prefix.

I like it!

This seems like a good change to me. It's slightly backwards-incompatible, but it feels fairly low risk and like a good improvement. Thanks for the patch!


[Bug]: Testfield when creating new Vendor

Describe the issue
When creating a new Vendor with the extension E-Document installed there's this code (in pageextension 6161 "E-Doc. Vendor Page") that doesn't allow to create new vendors

trigger OnAfterGetCurrRecord()
begin
Rec.TestField("No.");
ParticipantIdCount := ServiceParticipant.GetParticipantIdCount(Enum::"E-Document Source Type"::Vendor, Rec."No.");
end;

i think it could be something like this instead

trigger OnAfterGetCurrRecord()
begin
    ParticipantIdCount := 0;
    if Rec.("No.") <> '' then
        ParticipantIdCount := ServiceParticipant.GetParticipantIdCount(Enum::"E-Document Source Type"::Vendor, Rec."No.");
end;

This is in BC 25.2.27733.28023 SaaS in the Spanish version
And the extension is one of this (I don't know exactly)
E-Document Connector - Avalara
E-Document Core
E-Document Core Demo Data
E-Document Format for Factura-E
E-Documents Connector with External Endpoints
pd: I don't know if this goes here. sorry if it's not the place. I would really appreciate if you point me where to address this.
Thanks
Expected behavior
I should be allowed to create new vendors
Steps to reproduce
Go to Vendor List and create a New Vendor
Additional context
No response
I will provide a fix for a bug

[x] I will provide a fix for a bug

Discussed on Viva Engage (and should be already fixed).

Oh... thanks i will have a look and close this.
but I updated an environment yesterday and this problem is still there, i can assure you that.
Thank you!

It is fixed, but it will be available in the build 28099, as mentioned there.


Computationally mapped references are not included in Uniprot REST API

Please let me know if this is not the correct repo to raise this issue.
When accessing the rest API via the url: https://rest.uniprot.org/uniprotkb/Q5VST6.json, only reviewed references are included. In the example only 7 references are included under the references key of the response, and there are 11 computationally inferred references that are not included.
Thank you for your work on this incredible resource!

All publications are available at the following endpoint:


A Way to Listen to NotifyChanged Events on all Properties in a Class?

I'm using Fody.PropertyChanged.  I read the wiki page that explains how to bind an event to model property changes.  Is there an easy way to bind an event that fires for all properties on that model?
I'm guessing the following will not work:
model.Bind(x => x, (sender, eventArgs) =>
My best guess at an alternative is to use reflection to read all the properties on the model and then call model.Bind for every property.  Is that correct?

Just subscribe to the PropertyChanged event.
The Bind stuff makes no sense, as the handler is strongly typed to the type of property. If you subscribe to multiple properties they may have multiple types, so the types handler doesn't make sense.
The Bind method only exists as a wrapper around subscribing to PropertyChanged to make it easier to choose the property to subscribe to and provide a strongly typed way of accessing thr new value. You're doing neither of those things, so it doesn't make sense to use Bind.
On 3 February 2019 17:22:28 GMT, James<EMAIL_ADDRESS>wrote:

I wasn't sure how doing this would work using the Lamba selector
pattern. I don't know how you'd pass a property object from a
reflection property list directly into the selector.
So I took a look at the source code and the extension method Bind() is
compiling the targetSelector and doing this with it:
TSource strongTarget;
                   if (weakTarget.TryGetTarget(out strongTarget))
handler(strongTarget, new
PropertyChangedExtendedEventArgs<TProperty>(propertyName,
propertyAccess(strongTarget)));

I'm a bit uncertain as to why all this is necessary.  Is it strictly
for the purpose of being able to use Intellisense on a lambda
expression when you call Model.Bind()?  If yes, then I see the power
here.  But I need to bypass this and call the underlying methods and
creation steps directly if I've got a list of Properties from
reflection, correct?
After the target checks, the main piece of code calls new PropertyChangedExtendedEventArgs(propertyName, propertyType)
I should be able to call that directly if I've already got a
propertyname and property type from reflection?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/canton7/Stylet/issues/68#issuecomment-460070517

Ah.  Was totally looking at this from the wrong angle.  Thanks!!


README: add instructions for kubernetes

Add a quick and easy way to run this on top of kubernetes. It isn't
production ready but gives people a starting point.

While we're in here, we should probably clarify that both docker compose and k8s instructions are not meant for production, but testing.

@jzelinskie Done.


Bluetooth: controller: Refactor to use max macro

Cleaned up the use of conditional statements to use the max macro.
Fixes #6230.
Signed-off-by: David Maitland<EMAIL_ADDRESS>

I tested the changes by building and running on a nRF51-PCA10028 board.
I wasn't able to run the sanity tests locally without my laptop crashing (unrelated to my changes), but will try to get that working before committing in the future!

Codecov Report

Merging #6756 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #6756   +/-   ##
======================================
  Coverage    54.4%   54.4%
======================================
  Files         444     444
  Lines       42233   42233
  Branches     7996    7996
======================================
  Hits        22978   22978
- Misses      16047   16048    +1
+ Partials     3208    3207    -1

Impacted Files
Coverage Δ

kernel/posix/pthread.c
69.5% <0%> (-0.5%)
:arrow_down:

boards/posix/native_posix/timer_model.c
100% <0%> (+1.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39e2a2...534fcf1. Read the comment docs.

@lpereira thanks, will have a look.
@cvinayak sorry, didn’t realise I could do that.


fix(challenge): stricter tests for "Add Items Using splice()".

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #13070

Description

Add stricter test cases, see issue referenced for details.

LGTM!


24w35a more stuff

Registry related changes:

Most are reverts of this snapshots's changes
New changes to avoid conflict and for consistency (very impactful): getOrEmpty to getOptionalValue, T getOrThrow(RegistryKey) to getValueOrThrow.


feature request: add option to ignore backticks around template, or alternatively a preprocess function

Until .jstl files are well supported, I'm gonna tell my IDE to parse them as js files, and surround the whole template in backticks `` .
It would be nice to have  a convenient option to get rid of backticks automatically upon loading the template file. Or alternatively a function to preprocess the template string so I can do that manually

I do like the idea of a preprocessing hook though


Typo fix for Crital => Critical

Typo fix for Crital => Critical

@madchap  : is it ok or should I create a spécific migration file for this ?

it will be OK if you also update models.py. the migrations and models.py need to be in sync.


percentile_over_realization bug

Reference issue IMPRO336
Testing:

[Some tests ] Ran tests and they passed OK
[X] Added new tests for the new feature(s)

I think we should deal with the duplication codacy is pointing out. You can get more detail on the problems by looking at the detailed codacy output.

I'm getting a failure when I run the /improver-ecc/04-rebadging_renamed_percentile_coord.bats test. It is complaining that a file does not exist. Has something changed?


Fix for keymapping bug on Linux and Windows

In response to issue #2156, the keymapping conflict has been removed from linux.json and win32.json in the app/keymaps/ directory. Now the keymap for window close is ctrl+shift+q and the keymap for pane close is ctrl+shift+w.
Note: The first commit failed for the yarn command on CircleCI in this PR because I had neglected to update yarn.lock.

Note: The first commit failed for the yarn command on CircleCI in this PR because I had neglected to update my copy of yarn.lock.

thank you so much @h93xV2


Could not load file or assembly 'System.Web.Http error

After installing the nuget package into my MVC and Web API project I get the following error:
Could not load file or assembly 'System.Web.Http, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
reinstalling WebAPI via the following Nuget console command
Update-Package Microsoft.AspNet.WebApi -reinstall
results in a couple of errors:

System.Web.Http.ExceptionHandling isn't recognised any more
In global.asax.cs  GlobalConfiguration.Configuration.Filters.Add(new ElmahHandleErrorApiAttribute()); is erroring as ElmahHandleErrorApiAttribute isn't an IFilter.

removing Elmah.Contrib.WebApi and reinstalling Microsoft.AspNet.WebApi puts everything back how it was - but no error logging in the WebApi calls.

Hi @mattkemp I'm not actively maintaining this project any more. However it's really only 2 files so I recommend simply dropping them into your solution directly, and changing whichever signature you need to support the new framework interface (if it has changed).
https://github.com/rdingwall/elmah-contrib-webapi/blob/master/src/Elmah.Contrib.WebApi/ElmahExceptionLogger.cs
https://github.com/rdingwall/elmah-contrib-webapi/blob/master/src/Elmah.Contrib.WebApi/ElmahHandleErrorApiAttribute.cs
Sorry - hope this helps!

Thanks Richard!
I had an old version of WebAPI which I uninstalled and put in Web API 2.2, it doesn't seem to have broken anything and now System.Web.Http.ExceptionHandling is available.

also I removed the global.asax.cs line, and just left the WebApiConfig.cs line in there as it was logging two elmah errors per exception.


Remove the '.' in assistedsetup snippets

Because there's a '.' in the assistedsetup snippet (pre & post 15.0 versions), each time you type a '.' those 2 snippets are suggested.
if you then accidentally use enter or tab, a snippet is inserted, which is annoying.
Could it be possible to remove this '.'?

Will do!  Thanks for pointing out!
Sent from my iPhone
On 14 Apr 2020, at 11:22, SirBETE<EMAIL_ADDRESS>wrote:

Because there's a '.' in the assistedsetup snippet (pre & post 15.0 versions), each time you type a '.' those 2 snippets are suggested.
if you then accidentally use enter or tab, a snippet is inserted, which is annoying.
Could it be possible to remove this '.'?
[image]https://user-images.githubusercontent.com/34303738/79208024-cf0e0d00-7e41-11ea-8854-c7ca4c2e3c4e.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/waldo1001/crs-al-language-extension/issues/162, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC4HGTQN2GV2QLED2CD6KNTRMQTOHANCNFSM4MHSTFJA.


Use version range for logging components & terracotta-utilities

This commit introduces version ranges for Logback and SLF4J.
This commit also introduces a version range for terracotta-utilities
and bumps the base version.  The upper bound is left open.
To prevent depdendency convergence conflicts, several exclusions
(mostly for SLF4J) are also included.

I still need to verify that the "kit" content is OK ...

I still need to verify that the "kit" content is OK ...

The content of target/terracotta-5.9-SNAPSHOT/terracotta-5.9-SNAPSHOT appears to be consistent with the version built from master:HEAD along with the expected version differences.


chore: release master

:robot: I have created a release beep boop
@allaround/all-components: 1.4.1
Dependencies

The following workspace dependencies were updated

dependencies

@allaround/input bumped from ^2.4.0 to ^2.5.0

input: 2.5.0
2.5.0 (2023-06-07)
Features

add box shadow to input (2b069fb)

allaround-components: 2.5.0
2.5.0 (2023-06-07)
Features

add box shadow to input (2b069fb)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wholesome-ghoul/allaround-components/releases/tag/all-components-v1.4.1 :sunflower:

:robot: Release is at https://github.com/wholesome-ghoul/allaround-components/releases/tag/input-v2.5.0 :sunflower:


Show the migration of the data from HBase to MapR-DB Binary

So far we have the code and documentation explaining how to write the Java app that will be running on MapR-DB
What we should also show, pointing to maprdocs when needed is:

the Hbase application with data
migrat/move the data from hbase to Mapr-db

So we can have a script that imports data into Hbase

Created document, which shows how to migrate the data from HBase to MapR-DB Binary. Also, created script for HBase table initialization.


grafana and heapster service error

version:master branch------
\heapster_grafana:v2.6.0-2
kubernetes/heapster:canary
kubernetes/heapster_influxdb:v0.5
grafana service    only showed {{alert.title}}(console showed that js and css files were 404 missing).heapster service   showed "404 page not found".only influxdb service worked normally.
pod logs are   as follows:
GET /api/v1/proxy/namespaces/kube-system/services/monitoring-grafana/public/css/grafana.dark.min.a95b3754.css HTTP/1.1" 404 Not Found 23 bytes in 730us
2016-09-19T10:09:18.874944104Z 2016/09/19 10:09:18 [I] Completed <IP_ADDRESS> - "GET /api/v1/proxy/namespaces/kube-system/services/monitoring-grafana/public/app/app.ca0ab6f9.js HTTP/1.1" 404 Not Found 23 bytes in 1079us

it seems as if it connected the api server using the wrong host url,it should be masterUrl+/api/vi/proxy.....but in my situation,the host url is the grafana service url

Same problem, unable to use Heapster & Grafana on Kubernetes v1.3.6.
Here is grafana's logs :
t=2016-09-30T11:35:25+0000 lvl=info msg="Request Completed" logger=context userId=0 orgId=1 uname= method=GET path=/api/v1/proxy/namespaces/kube-system/services/monitoring-grafana/public/app/boot.1649cbaa.js status=404 remote_addr=<IP_ADDRESS> time_ns=0 size=19
Try as a NodePort and as a ClusterIP.
Any idea?

this appears to be the same as #1316.  Closing in favor of that.


Create CryptoAwake (B2) Restart a node according to schedule.

Node id: e9d6fe26fb03fd18
Full logs will be submitted

rejected:B2
reason:logs are missing

rejected:B2
reason:logs are missing


Test

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2de22eb). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   66.17%
=========================================
  Files             ?      355
  Lines             ?    47980
  Branches          ?        0
=========================================
  Hits              ?    31752
  Misses            ?    16228
  Partials          ?        0

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2de22eb). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   77.82%
=========================================
  Files             ?      334
  Lines             ?    40827
  Branches          ?        0
=========================================
  Hits              ?    31775
  Misses            ?     9052
  Partials          ?        0


FEATURE REQUEST: Add a way to start from the bottom of the list and scroll upward

Feature Request
It would be nice if there way a way to effectively reverse the virtualization of the table, in a way where the users scroll position starts at the bottom of the virtualized table, then scrolls up to load more rows.

What's your use case? (Tell me about your application and what problem you're trying to solve.)

I am trying to create a virtualized chat window in my application. Generally speaking a lot of chat windows will show their latest data at the bottom, then the user will scroll up to see older messages.

What interface do you have in mind? (What new properties or methods do you think might be helpful?)

I believe the only external interface you would need would be some sort of reverse or scrollFromBottom boolean. You would be able to set that and the table would just scroll from the bottom up.

Can you point to similar functionality with any existing libraries or components? (Working demos can be helpful.)

iMessage, Facebook Chat, Instagram Chat, etc

you could solve this by setting a state with scrollToIndex value and setting the initial value as listData.index - 1

@MauroGL doing it and it still scrolls ugly :( jumping, after loadMore focusing in wrong place, e.t.c

@theromis same here. Since then, have you found any solutions or alternatives?

is this not a feature yet? looking to implement a discord-like messaging system :/

working on chat and have the same problem too!

Any updates ?

I tried many diff libraries during my career. The only lib which can be well used for Chat-like view is https://github.com/Flipkart/recyclerlistview
The only difficulty with recyclerlistview is that you need to measure each cell height and provide this value into the lib. But this can be managed.

to be honest InfiniteLoader its kinda wierd. Mby it is good to load entities, but just for load more items its overdose. I would like to see something rly simple like onReachedBottom and callback you can pass to load more items

I tried many diff libraries during my career. The only lib which can be well used for Chat-like view is https://github.com/Flipkart/recyclerlistview

Also looking for a lib where it can start from the bottom without weird UI behavior. recyclerlistview doesn't look like it's maintained.


Docs update

A revamp of the README.md to not be verbose and rather point to the Gitbook docs.

First time that we're merging into develop. I will redo the change from develop.


Migrate from Travis to GitHub Actions and CircleCI

Template
The following template is not required, but if you do not use it, please be sure to include all answers to all of the questions in some other way.
Does your pull request resolve or partially resolve an issue?
Yes
If Yes, which issue?
Fully resolves #88.
Does your pull request implement code improvements?
No.
Does your pull request implement any breaking changes?
Yes
If breaking changes are implemented, please describe:
In order to match the new build environments, some checksums adn filenames in the provided checksums file were altered.
Testing:
This pull request:
[X] Alters the existing CI in some way.
[ ] Adds a new step to the CI.
[ ] Does not introduce any features that the CI could not already test.
[ ] Is not accompanied by necessary CI changes due to some limitation described below. (Please also describe how new features can be manually tested.)
See the README.md file in the nrCascadeSim/tests directory for more instructions on how to make tests.

Codecov Report

Merging #105 (9f54078) into develop (d91a9b7) will decrease coverage by 0.57%.
 Consider uploading reports for the commit 06d24e4 to get more accurate results

@@             Coverage Diff             @@
##           develop     #105      +/-   ##
===========================================
- Coverage    82.57%   81.99%   -0.58%
===========================================
  Files           13       13
  Lines         1245     1261      +16
===========================================
+ Hits          1028     1034       +6
- Misses         217      227      +10

Impacted Files
Coverage Δ

src/weisskopf.cpp
100.00% <ø> (ø)

bin/regexPlayground.cpp
57.40% <0.00%> (-5.10%)
:arrow_down:

bin/realizeCascades.cpp
53.78% <0.00%> (-0.32%)
:arrow_down:

src/edepmath.cpp
48.64% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91a9b7...06d24e4. Read the comment docs.


Integration not working

I'm receiving the following warning:
Updating sunweg sensor took longer than the scheduled update interval 0:00:30
If I reload the integration it will update the data once, but later this happen.
sunweg - latest version
HA Core 2024.5.3
HA Frontend 20240501.1
Anything I could do to check what is going on?
Thanks
Raphael

There is a PR at HA so fix that: https://github.com/home-assistant/core/pull/118435
Please can you submit an issue there?


Example: token algebra of total functions

I'll squash and rebase this before marking it ready for review.


Small typo

Description

Related Issues

Checklist:

[ ] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[ ] This PR is being made to staging branch and not to main branch.

Codecov Report

Merging #1594 (6a477eb) into staging (45195d3) will increase coverage by 61.90%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           staging    #1594       +/-   ##
============================================
+ Coverage     0.00%   61.90%   +61.90%
============================================
  Files           84       84
  Lines         8462     8462
============================================
+ Hits             0     5238     +5238
- Misses           0     3224     +3224

Flag
Coverage Δ

nightly
?

pr-gate
61.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

recommenders/datasets/mind.py
0.00% <0.00%> (ø)

recommenders/datasets/movielens.py
69.46% <0.00%> (+69.46%)
:arrow_up:

recommenders/datasets/download_utils.py
90.00% <0.00%> (+90.00%)
:arrow_up:

recommenders/models/geoimc/geoimc_data.py
39.13% <0.00%> (+39.13%)
:arrow_up:

recommenders/models/newsrec/models/npa.py
95.58% <0.00%> (+95.58%)
:arrow_up:

recommenders/models/newsrec/models/naml.py
92.43% <0.00%> (+92.43%)
:arrow_up:

recommenders/models/newsrec/models/nrms.py
91.37% <0.00%> (+91.37%)
:arrow_up:

recommenders/evaluation/spark_evaluation.py
86.60% <0.00%> (+86.60%)
:arrow_up:

recommenders/models/newsrec/models/lstur.py
87.14% <0.00%> (+87.14%)
:arrow_up:

recommenders/evaluation/python_evaluation.py
93.68% <0.00%> (+93.68%)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45195d3...6a477eb. Read the comment docs.


Test ensuring currency is preserved when using money_accessor

I think money_accessor should probably preserve the currency if you're passing it a Money object.

Closing this as https://github.com/Shopify/money/pull/224 has been merged.

Closing this as https://github.com/Shopify/money/pull/224 has been merged.


Output JSON is empty.

When I run this:
python .\tgscrape.py "fun_with_friends"
this is what I get:
> Telegram Public Groups Scraper

[deleted]
[deleted]
[deleted]
[deleted]
[deleted]
[deleted]
[deleted]
[deleted]
[deleted]
[deleted]
[deleted]
[deleted]
[deleted]
[deleted]
[deleted]
[deleted]
[deleted]
[deleted]
[deleted]

Writing to ./conversations/fun_with_friends.json...
ERROR: 0
Exiting...

Is something outdated or so?

same here

@ThatBrianDude @hpiedcoq try to increase error counter in config.py from 20 to 2000


Add chartmigration resource and disable chartconfig controller

Towards giantswarm/roadmap#30
Now that we only use chart CRs in new tenant clusters the only purpose of the legacy chartconfig controller is for deleting chartconfig CRs.
This is now done by a new chartmigration resource. It checks for the chart-operator.giantswarm.io/delete-custom-resource-only annotation which is added by cluster-operator once the migration is complete.
https://github.com/giantswarm/cluster-operator/blob/legacy/service/controller/resource/appmigration/create.go#L150-L155

Changes made. Tested on ghost.

@tomahawk28 PTAL. Doing a final test but this should be OK now.

Tested on ghost. Going with this.


Fixed Up/Down command in ZWave Cover component

Up and Down buttons seems to be swapped.

Can you please answer a couple of Q's before we merge this?

Is this tested with your own equipment?
Do you mind sharing what device this is?

There has been alot of back and forth with the code to zwave cover.
:dancer:

Yes, I've tested on my own equipment : Fibaro FGR 221.
On Wed, Oct 26, 2016 at 4:14 PM, John Arild Berentsen <
<EMAIL_ADDRESS>wrote:

Can you please answer a couple of Q's before we merge this?

Is this tested with your own equipment?
Do you mind sharing what device this is?

There has been alot of back and forth with the code to zwave cover.
💃
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/4064#issuecomment-256360093,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACLhnyaGBecTL9Vrh9gKZOcIXWY4dbXuks5q32ApgaJpZM4KhNGU
.

Ok, then I need to ask some of the guys that helped me with implementing this to see if theirs are reversed.
Because you can reverse the electrical connections, and get this behaviour. Have you checked the calibration procedure, that it does excactly what the manual says is going to happen?
@nunofgs Can you check your setupto see if it reversed?

I can confirm this issue with my FGRM-222. I assumed this was a problem in the OZW configuration files and I just swapped the buttons in the XML file.
In any case the code seems inconsistent with Open equivalent to Down and Close to Up.

Sure, it's calibrated alright : level setting works as indented.
I find it makes more sense to see Up or Open than Down or Open in
'open_cover'.


Confiuge ci sonar cloud

I used GitHub actions for CI

Why is the report empty?
https://sonarcloud.io/dashboard?id=amrsamii_hazelcast-kotlindsl

This report was made automatically by SonarCloud when I integrated with the Repo, the code coverage was not configured yet, but the report analyzed 266 lines of kotlin and 67 lines of xml and it did not find any problem. Now the automatic analysis is turned off and it will be triggered only when a successful build is made, then code coverage will appear.

Build fails.
I've created an issue

I am working on it


Terminal strings shift to the right

VSCode Version: 1.12.2
OS Version: 15063.296

Steps to Reproduce:

Open Terminal
Write anything
Get this

yes， I have same problem. How to fix it ?

Duplicate https://github.com/Microsoft/vscode/issues/19665


Integrations API — Dev Setup for Testing Locally Example

Capturing the idea that we should show instructions for setting up a local dev env and testing a non-internal integration (see this comment) per @bholmesdev request. One will need to configure their own tsconfig as astro-scripts which is typically used within astro's main monorepo is not available. Also, many folks new to npm publishing won't be aware of tooling like npm pack etc., so a hello world example of all this will help them get to a place where they can contribute.
Here's a small readme showing how I did it (and the integration seems to be working in this repo link too if you follow those instructions); but I believe Ben wants to investigate if there's a cleaner pnpm way to approach to this :)

Just because this is getting a little stale, I'm pinging @bholmesdev again to see if he has a fresh take on this one!

My thoughts haven't changed on this too much! I've sadly had to deprioritize this in favor of other bug and documentation work. Happy to pick this up in the next couple weeks.

Hey sorry, this issue got a little neglected. We’re not going to be able to prioritise this for a little while. If anyone does want to pick it up and provide a guide — maybe adding to our NPM Package guide — would be happy to see it!

Going to close this in favour of #1969!


Unwanted blocks in generated RAML

I used springmvc-raml-plugin to generate .raml from a spring boot application.
Here is a snapshot of the code:
@RestController
public class SystemInfoController {

    /**
     * Returns version
     * @param
     * @return string
     *
     */
    @RequestMapping(value = "/api/v0/version", method = {GET})
    public SystemInformation.Version fetchVersion() {
        ...
    }
}

And the generated .raml file:
#%RAML 0.8
title: manager
version: "0.0.1"
baseUri: /api/v0/
/api:
    displayName: Api Resource
    description: Api Resource
    /v0:
        displayName: V0 Resource
        description: V0 Resource
        /version:
            displayName: Version Resource
            description: Version Resource
            get:
                description: Returns version
                responses:
                    "200":
                        description: string
                        body:
                            application/json:
                                schema: |
                                    {
                                      "type" : "object",
                                      "id" : "urn:jsonschema:net:polarisnetworks:manager:pojo:SystemInformation:Version",
                                      "properties" : {
                                        "coreVersion" : {
                                          "type" : "string"
                                        }
                                      }
                                    }

I want to omit the _/ap_i and /v0 blocks from the generated .raml - after all, the URI endpoint is /api/v0/version. How can I achieve that?
Thanks in advance.

Hi !
I'm interested in that bug as I have the same issue. I tried to look into the code to try to fix it myself, but I could not find the place where the "restBasePath" should be consumed.
Regards,
Raphaël

What is the value of restBasePath in your pom.xml?
@soumyakantiroychowdhury I assume you set <restBasePath>/api/v0</restBasePath> in your maven config. If you set the value to / your raml will be correct.
But I agree that this is a bug since generated resources should respect (and be relative to) baseUri.
@piroxxi SpringMvcRamlApiSyncMojo reads the value and pass it to RamlGenerator.generateRamlForClasses method (baseUri is the name of parameter).

@stojsavljevic I did not set the restBasePath, frankly, I was not aware. Currently I moved from RAML to Swagger for API documentation, so it does not affect me any more. You may wish to close / suspend the issue if it does not fit to your plan.


Kubeflow on Kubernetes: subPath dynamic volume provisioning broken

The Kubeflow on Kubernetes getting started docs indicate kind as a recommended tool for local development and testing (introduced in https://github.com/kubeflow/website/commit/1a95986c4c1c2b8adbe5655ed7de94050492de23).
@gyliu513, I'm new to kubeflow and having difficulty deploying using kind due to, I think, a kind issue with the subPath property (https://github.com/kubernetes-sigs/kind/issues/403) and that kind dynamic volume provisioning support is still a work in progress (https://github.com/kubernetes-sigs/kind/issues/118).
To reproduce

Create a local kind cluster and generate the kubeflow config files:

kind create cluster
export KUBECONFIG="$(kind get kubeconfig-path --name="kind")"

export KFAPP=kubeflow-test
kfctl init ${KFAPP}
cd ${KFAPP}
kfctl generate all -V

Open the  file ks_app/vendor/pipeline/minio.libsonnet, which contains:

volumeMounts: [
  {
    name: "data",
    mountPath: "/data",
    subPath: "minio",
  }
]

Deploy kubeflow to the local kind cluster:

$ kfctl apply all -V
$ kubectl -n kubeflow get pods
NAME                                                        READY   STATUS                       RESTARTS   AGE

...

minio-5f6b9b5b7-w42mg                                       0/1     CreateContainerConfigError   0          39m
ml-pipeline-79474f7b99-bwkwj                                0/1     CrashLoopBackOff             7          39m

...

$ kubectl -n kubeflow describe pods minio-5f6b9b5b7-w42mg

...

Events:
  Type     Reason            Age                   From                         Message
  ----     ------            ----                  ----                         -------
  Warning  FailedScheduling  35m (x3 over 35m)     default-scheduler            persistentvolumeclaim "minio-pvc" not found
  Normal   Scheduled         35m                   default-scheduler            Successfully assigned kubeflow/minio-5f6b9b5b7-w42mg to kind-control-plane
  Normal   Pulling           35m                   kubelet, kind-control-plane  Pulling image "minio/minio:RELEASE.2018-02-09T22-40-05Z"
  Normal   Pulled            11m                   kubelet, kind-control-plane  Successfully pulled image "minio/minio:RELEASE.2018-02-09T22-40-05Z"
  Warning  Failed            9m46s (x12 over 11m)  kubelet, kind-control-plane  Error: stat /tmp/hostpath_pv/4d2d668f-824c-11e9-8c85-0242ac110002: no such file or directory
  Normal   Pulled            104s (x48 over 11m)   kubelet, kind-control-plane  Container image "minio/minio:RELEASE.2018-02-09T22-40-05Z" already present on machine

The following message corresponds to https://github.com/kubernetes-sigs/kind/issues/403:
Error: stat /tmp/hostpath_pv/4d2d668f-824c-11e9-8c85-0242ac110002: no such file or directory

Suggestion
Either:

Test whether kubeflow pipelines function as intended when manually removing the subPath property from ks_app/vendor/pipeline/minio.libsonnet. If so, mention this modification as an additional step in the Kubeflow on Kubernetes documentation.

Investigate whether subPath could be removed from the ml-pipeline .libsonnet configuration files. (/cc @jlewi)

Wait for https://github.com/kubernetes-sigs/kind/issues/403 to be resolved and add a warning note in the Kubeflow on Kubernetes documentation.

/assign @gyliu513

It looks like PR https://github.com/sighupio/fury-images/pull/27 fixed the problem. Also, the Kubeflow installation docs have been substantially rewritten and no longer recommend kind. I'm closing this issue, but please do re-open it if more doc work is required.
/close


Add additional authors

Signed-off-by: dhh1128<EMAIL_ADDRESS>

@ashcherbakov and @DenisRybas : please confirm correct links