fix(theme): dark and light AppStore menu fix

Fixes #172
Fixes #173
Fixes #169
Hi @rohit-gohri, thanks for this amazing plugin. I noticed the issues described in those issues filed and am proposing a fix.
The issue was because we are initiating 2 copies of AppStore: one for dark and one for light. The last copy of AppStore successfully binds various scroll events to the window and hence was the only one able to receive the event. When in light theme, this doesn't work. I understood from the code that the 2 copies of AppStore were meant for ServerStyles to generate the dark and light stylesheets correctly.
I propose to only initiate 1 copy of AppStore and depending on the theme, update the options accordingly.
Feel free to clarify on the changes proposed. If this is alright, I'd like this fix to be published as soon as possible.

@oil-oil @srweeks @birkmose does the change fix the issue you've described? You can look at it from the preview: https://redocusaurus-git-fork-mauris-fix-store-menu-problem-rohit-gohri.vercel.app/

it does, nice. Noticing that switching between themes no longer maintains the selection though

@mauris doesn't seem to fix the menu expansion issue no :(
Example: https://redocusaurus-git-fork-mauris-fix-store-menu-problem-rohit-gohri.vercel.app/examples/using-swagger-json/#tag/user/operation/createUsersWithArrayInput
When opening this link the left-hand menu stays collapsed.

added more changes that should address issues raised by @birkmose and @srweeks about switching themes and "not expanding menu sometimes"
the key issue was that, in redoc, the AppStore instance is expected to be kind of a singleton. If you need to change the AppStore because some options were changed, you need to AppStore.dispose() the current instance, and reinitialize a new AppStore by running new AppStore(...).
What I've done in the last commit, was to simply store the current singleton instance outside of the hook, and make sure to clean up the current instance of AppStore before initializing a new one.
I've also added useEffect to watch theme change and when first loaded on browser to perform a AppStore.onDidMount() to ensure that the menu expands correctly.

What I've done in the last commit, was to simply store the current singleton instance outside of the hook, and make sure to clean up the current instance of AppStore before initializing a new one.

That's a good solution but that will break with multiple instance of Redoc are on a single page which is possible when using the MDX components to render schemas like here: https://redocusaurus.vercel.app/docs/guides/schema-imports
I'm not sure what the solution is, but this approach is definitely in the right direction and fixing some of the "hacks" I had added before. Maybe I should separate the hooks for the MDX embeds and full page docs?

tested ApiSchema on my local build and it looked fine even with the singleton, likely because ApiSchema only uses values from the options and didn't really depend on other content such as the Redoc left side menu.
is it possible to update the preview? @rohit-gohri thanks!

Thanks @rohit-gohri, the preview deployment succeeded and I can see the issues described by @birkmose and @oil-oil were resolved. ApiSchema also seem to be working without issue. Able to confirm? Thanks

Released in v1.1.3! Thank you for this fix!


Incorrect results with Archer

With Archer (dc4e363) build with out of source with LLVM 4.0 and OMP-TR4. Running GROMACS unit tests:
git init gromacs && cd gromacs
git fetch https://gerrit.gromacs.org/gromacs refs/changes/48/6648/1 && git checkout FETCH_HEAD
mkdir build && cd build
CC=clang-archer CXX=clang-archer++ cmake -GNinja -DGMX_OPENMP_MAX_THREADS=256 -DGMX_BUILD_HELP=OFF -DBUILD_SHARED_LIBS=yes -DCMAKE_BUILD_TYPE=RelWithDebInfo -DGMX_HWLOC=no .. -DGMX_SIMD=None -DTMPI_ATOMICS_DISABLED=yes -DGMX_MPI=on
ninja check

Produces:
The following tests FAILED:
          7 - EwaldUnitTests (Failed)
         12 - MdrunUtilityMpiUnitTests (Failed)
         23 - CorrelationsTest (Failed)

Compiling and running with clang 4.0 without archer (with or without using OMP-TR4) all tests pass. All unit tests also pass with VS2015, ICC 16&17, GCC 4.8-7.1 and a few other compilers we check less regularly. Thus it is highly unlikely that the unit tests failures are GROMACS source code problems.

@rolandschulz: thank you for using Archer on your build-and-test system.
Could you describe how those unit tests failed more specifically? One of the common cases of something like this in our environment is Archer/TSan detects an error (directly in a unit test code or some other tester components) and causes it to exit with a return code 66. https://github.com/google/sanitizers/wiki/ThreadSanitizerFlags
Could you try to set EnvVar, TSAN_OPTIONS="exitcode=0" before you run these unit tests and see if this makes any difference?

All 3 failures are incorrect results not TSAN errors. They also all 3 still occur with OMP_NUM_THREADS=1. Thus it seems that the LLVM pass added by archer causes incorrect results. Compiling and run all unit tests with clang 4.0 with Tsan (without archer) all unit tests give the correct result (some tests produce false positive tsan warnings - different tests from the ones which fail with archer) E.g. running the first test which fails by itself gives
./bin/ewald-test --gtest_filter=SaneInput1/PmeBSplineModuliCorrectnessTest.ReproducesValues/0
Note: Google Test filter = SaneInput1/PmeBSplineModuliCorrectnessTest.ReproducesValues/0
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SaneInput1/PmeBSplineModuliCorrectnessTest
[ RUN      ] SaneInput1/PmeBSplineModuliCorrectnessTest.ReproducesValues/0
../src/testutils/refdata.cpp:900: Failure
  In item: /X/Length
   Actual: '-1782689792'
Reference: '64'
Google Test trace:
../src/gromacs/ewald/tests/pmebsplinetest.cpp:95: Testing B-spline moduli creation (plain) for PME order 3, grid size 64 32 64
../src/testutils/refdata.cpp:900: Failure
  In item: /Y/Length
   Actual: '-1782689792'
Reference: '32'
Google Test trace:
../src/gromacs/ewald/tests/pmebsplinetest.cpp:95: Testing B-spline moduli creation (plain) for PME order 3, grid size 64 32 64
../src/testutils/refdata.cpp:900: Failure
  In item: /Z/Length
   Actual: '-1782689792'
Reference: '64'
Google Test trace:
../src/gromacs/ewald/tests/pmebsplinetest.cpp:95: Testing B-spline moduli creation (plain) for PME order 3, grid size 64 32 64
[  FAILED  ] SaneInput1/PmeBSplineModuliCorrectnessTest.ReproducesValues/0, where GetParam() = (12-byte object <40-00 00-00 20-00 00-00 40-00 00-00>, 3, 4-byte object <00-00 00-00>) (52 ms)
[----------] 1 test from SaneInput1/PmeBSplineModuliCorrectnessTest (55 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (56 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SaneInput1/PmeBSplineModuliCorrectnessTest.ReproducesValues/0, where GetParam() = (12-byte object <40-00 00-00 20-00 00-00 40-00 00-00>, 3, 4-byte object <00-00 00-00>)

 1 FAILED TEST

Thanks. Seems something that @simoatze should look into. @rolandschulz: how should we reproduce this failures?

I provided the git, cmake, and ninja commands in my first message. That should let you be able to reproduce the error. If you have difficulty reproducing I'm happy to help.

@rolandschulz thanks for reporting these issues. I'll look into it as soon as I can and get back to you.


[Feature Request] Edit Modifier Bucket Pop-Up

Just GM'd my first game with FoundryVTT and GURPS Game Aid. It was a lot of fun. One area where I think it would be a great improvement and would really enhance speed of play is having GMs be able to modify the popup in the modifier bucket. There are quite a few things in there that we do not use (e.g., Feverish Defense in DFRPG) and others that come up frequently that aren't there. A workaround has been to create journal entries that have all of the modifiers from various tables in the DFRPG books. But that is somewhat time consuming to find. If GMs could edit the modifier bucket to have common modifiers (Bad footing, Deceptive Attack at a level higher than -1, etc.), that would be great. I know that I can write in the modifier and send it to a player, but anything that is preloaded is better.
Thanks, as always--my players thought that the import feature and combat was really, really great. We had a good time.

Duplicate of https://github.com/crnormand/gurps/issues/165  (I linked your comment to that issue)


@cgreening I don't want to use the push button to record. what needs to be done.

@cgreening I don't want to use the push button to record. what needs to be done.
Originally posted by @Yatinbaluja in https://github.com/atomic14/esp32_sdcard_audio/issues/1#issuecomment-846150096

Not sure what to do about this - can you givd


fix: Adjust workflow ghcr image path

This PR should fix the release workflow of the ghcr image.

:tada: This PR is included in version 2.0.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[TSVB] Simplify TSVB aggregation pipelines UI

Summary
TSVB is very powerful... too powerful for some users who have no idea how to work with it. As the result they get discouraged when they see the amount of option they need to configure to achieve a simple visualization for their metrics.
(not so) Fun fact: some user believe that Visualize in Kibana provides only way to interact with time series data.
Aggregation pipelines. One of the main strengths of TSVB is its ability to configure aggregation pipelines. There are many aggregation types supported by TSVB, however for most cases, only a subset is used (min, max, avg, median, rate, count, percentiles).
User stories
Current TSVB UI provides a lot of parameters to configure which can be ok for power users, the ones who really know what they're doing. Other find is very hard to understand how it work.
It'd be useful to have a "Simple mode" where only the most common aggregations are displayed (e.g. Min, Max, Avg, Rate, Percentile, Count, Cardinality).

Pinging @elastic/observability-design (design)


Mint url has a trailing slash that breaks cashu-ts

https://github.com/cashubtc/cashu-ts/pull/87

fixed in: 502a3962e3bab8d59915daf5ad54e1037a5f7e8b


Select option - Can be mapped value label to another object property

I have an object that has two properties id and name. Is there any way to specify two properties as value and label? Or do I have to map the object properties id to value and name to label?

I am not really in favor of this feature. With the map function you can easily map your list to the list that is accepted as input:
let selectOptions = yourOptions.map((option) => {
    return {
        value: option.id,
        label: option.name
    };
});

To me it sounds a little odd to offer customization of the input data structure like this. Also, I can't think of any other components that offer such a feature. But I might be wrong about that.
For now I will close this feature request. If there seems to be a large interest for this feature from other users, then I might consider implementing.


Improve color picker

I believe the best user experience is to give to the user a handful of colors they can quickly pick from. The previous color picker required you to chose from all the possible colors which is not ideal. Good news is that the same library has a color picker "Twitter" that lets you pick from a small list and has a fallback with hexadecimal. This is what I wanted!

Adding position: relative to the container and shrinking the width a bit so that it fits.

I used the default Twitter colors, added black and white, and removed two so that it fits in the box. We'll likely want to iterate on the color scheme in the future! Note: we should also use different set of colors for the background, none of them are really good for that.

Instead of implementing the same logic for all the color pickers, I extracted the logic into a self contained component.

cc @jaredpalmer

I prefer this new color picker a lot, way simpler to use.
There's still a bug where you can't scroll the container if the cursor is not placed on the color picker itself, and it's elsewhere on the sidebar instead.

Yeah I found this bug, not sure what's happening.

LGTM. IIRC GitHub labels have some solid foreground and background colors. We could also take them from tailwind’s color palette.

Shipped as part of #195


Lock "CanNotDelete" on VM prevents to stop this VM. Why?

I have set lock  "CanNotDelete" on VM. When I try to stop this VM an error occurred like this:
"Failed to stop the virtual machine 'myvm'. Error: The scope 'myvm' cannot perform write operation because following scope(s) are locked: '/subscriptions/xxx/resourcegroups/xxx/providers/Microsoft.Compute/virtualMachines/myvm'. Please remove the lock and try again."
Why is it so?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4e7af209-7240-dd2a-7130-e7fb3143986a
Version Independent ID: a653b0d1-877d-09f7-17fa-11bf06c37cc9
Content: Lock resources to prevent changes - Azure Resource Manager
Content Source: articles/azure-resource-manager/management/lock-resources.md
Service: azure-resource-manager
Sub-service: management
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@beelesnik  Thanks for your comment. We are actively looking into and it and we will update you soon.

It sounds like there is a read-only lock somewhere in the hierarchy. I would look at the locks on the vm through the portal and make sure there isn't a read-only lock that is inherited from the resource group or higher. The articles notes that a read-only lock on the resource group will prevent users from starting or stopping a vm.

Sorry, it is my fault. I'v been mistaken and create ReadOnly lock.
Close it


Connecting a Unity app and ROS from different networks

[x] I am at the right place and my issue is directly related to ROS#. General technical questions I would post e.g. at ROS Answers or Stack Overflow. For library-specific questions I would look for help in the corresponding library forums.
[x] I have thoroughly read the Contributing Guideline and writing this issue is the right thing to do in my case.

I have a question!

[x] I searched the Wiki, open and closed issues for an answer. I tried my best to find the answer by myself without success. I believe that the discussion we will have in this issue, and the solutions we might find, will help me, and likely other community members who have a similar problem.

Here is my question:
Hi,
Thank you very much for this awesome tool! I have a question regarding the deployment of ros-sharp. I would like to have a Unity build/project run on a machine in one network and have it connect to my ROS application which is running on a VM on a different network. I am wondering whether this is feasible as I have been able to connect the two when using the same network. Unfortunately, I am unfamiliar with networking in general so I'm kind of stumped about how to proceed.
Thanks!

Hi @karthikm-0 ,
thanks for your positive feedback!
Concerning ROS#, all I can say is that we are using a basic websocket connection. That is, if the ROS- and Unity machines can ping each other and there are no blocking firewall settings, ROS# should work.
If you need other connections, you can implement your own IProtocol
Please refer to e.g. StackOverflow for your issue and make sure to provide a more detailed explanation of your problem, your network infrastructure and the errors you received.
Best,
Martin


Operator adds or views operation-related documents and contacts

Description:
Wireframes: https://www.figma.com/proto/LsDmLDCdnJqI8UahyqvOD8/OBPS-App-Designs?page-id=4%3A2&type=design&node-id=5-6&viewport=365%2C284%2C0.29&t=4frrrAOPoEC9MQ8k-1&scaling=scale-down&starting-point-node-id=5%3A6&show-proto-sidebar=1&mode=design
Most of the operation form was completed in https://app.zenhub.com/workspaces/team-moose-sprint-board-60d216175a2689000ec774d0/issues/gh/bcgov/cas-registration/26. This ticket is about adding document upload and contacts (these two fields have a many-to-many relationship with operations).
Acceptance Criteria:
Given I am logged in to the Registration app with my Business BCeID account and I have been granted "admin" role for my operator
When I navigate to the create Operation (facility) form
Then I can add documents and contacts to the form
Given I am logged in to the Registration app with my Business BCeID account and I have been granted "admin" role for my operator
When I navigate to the Operation (facility) Details page
Then I can view the existing contacts and documents associated with my operator
And I can add new documents and contacts for an operation associated with my operator
Development Checklist:

[ ] Add document handling (e.g. https://django-ninja.rest-framework.com/guides/input/file-params/) to the existing operation forms
[ ] Add contact handling
[ ] Documents and contacts are already in the models
[ ] Checklist item
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

Hey team! Please add your planning poker estimate with Zenhub @BCerki @Sepehr-Sobhani @JoshLarouche @joshgamache @dleard @shon-button

@joshgamache  and @dleard  reminder for your estimates :)

TBD - we may leave document upload out of MVP

I'm skipping design for regulated products and reporting activities (they currently look like [this] (https://www.loom.com/share/fac4414d33824944b6917a6243568b43)) because the multiselect widget will handle it and I don't want to duplicate anything.


Change order of the IndentNestedKeywords

Closes #318

Codecov Report

Merging #320 (5b41bea) into main (052653c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   97.35%   97.35%
=======================================
  Files          38       38
  Lines        2758     2758
=======================================
  Hits         2685     2685
  Misses         73       73

Impacted Files
Coverage Δ

robotidy/transformers/__init__.py
98.01% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052653c...5b41bea. Read the comment docs.

No test for it - we don't have any E2E but I think it's about time to create some.. (to run robotidy with all transformers enaled and see the results on example files).


Is there any Error Checks for the busy bus?

I want to know if there is a queue when someone using the bus.
Does the request got dropped out or the modules have waiting for the bus to be available again?
Edit: When the master wants to write.

Hmmm, I don't think there is.
Got to implement this.

So i tought that i will use a simpe boolean for that purpose. That didn't worked out well.
I have multiple slaves, and i don't know how many. At start up i'am trying to count these slaves, wich is working fine. I'am pushing one slave address into an array. I loop trought 128 slaves ( thats the max slaves i can have ) and if one is already in the array ( because its happens somehow ) i don't push it. So if the array filled, then i delete this task and creating another where i continously communicating with all the slaves and get the id's from the previously filled array.
I'am doing it like this:
I have this task on core 0 wich is running for ever because i have to continously check if there is some modification on one of my slaves pins.
void ModBus_Loop( void * parameter ){
  for ever{
    ModBus_RUN();
    delay(1);
  }
}

In the ModBus_RUN(); function i have this function:
boolean Bus_is_Busy = false;
int Reading_Address = 0;
static const inline void ModBus_Read_Existing(){
  if(!Bus_is_Busy){
    Bus_is_Busy = true;
    modbus.readHoldingRegisters(Address_Array[Reading_Address], Start_In_Reg_Address, Reg_Count);
    Reading_Address++;
    if(Address_Array[Reading_Address] == 0){Reading_Address = 0;}
  }
}

As you can see there is a boolean variable where i tell the whole program that the rs485 line is currently busy. I did this because the readings was not reliable. They were fluctuating continously. And were getting an error every f.. time.
And i have an other function wich is running every 2 second.
long thermosreadtime = millis();
static const inline void Write_Thermos(){
  if(millis() - thermosreadtime >= 2000 && !Bus_is_Busy){
    thermosreadtime = millis();
    Bus_is_Busy = true;
    modbus.writeMultHoldingRegisters(128,0,8,Thermos_Data);
    Thermos_Data[11]++; if(Thermos_Data[11] >= 60){Thermos_Data[11] = 1;}
    Thermos_Data[15]++; if(Thermos_Data[15] >= 8){Thermos_Data[15] = 1;}
  }
}

And if i get a data or an error, inside the handlers i clearing the boolean to let any other reading run.
modbus.onData([](uint8_t slaveAddress, esp32Modbus::FunctionCode fc, uint16_t address, uint8_t* data, size_t length) {
    if(slaveAddress >= 128){       // Thermos
    }else if(slaveAddress < 128){  // Expanders
      if(fc == 3){
        if(Can_Check_Array){
          String Info_Data = "";
          for (int i = 0; i < length; i++)
          {if(!(i <= 2)){if(!(i%2 == 0)){Info_Data += Get_ASCII(data[i]);}}}
          Check_Existing_Modules(slaveAddress,Info_Data);
        }
      }
    }
    Bus_is_Busy = false;
  });
  modbus.onError([](esp32Modbus::Error error, uint8_t slaveAddress) {
    if(Can_Check_Array){Check_Loop_Count();}
    Handle_Error(String(error,HEX),String(slaveAddress,HEX));
    Bus_is_Busy = false;
  });

Like this, the program usually stops at one of the slaves, continously reading just one, and sometimes but just rarely, asking an other one. I espected it to read all the slaves wich are in the array one by one.
But thats not the case. :O
Btw: i have a maximum of 15millis response time, therefor the defined timeout is 15millis and the queue size is 10. But none of that matters. I varied these and nothing changed.

I've looked into the code just now.
So what happens is this:

you make a request
the request is put into a queue (_addToQueue)
a separate task checks for requests in the queue (_handleConnection)
if there is one, it sends the request and waits for the answer (or timeouts) (from _handleConnection, call _send)
callbacks are fired
tasks loops back to "check for pending requests"

So actually I would think we're not sending on a busy bus.

So in theory, i can't send if the bus is busy, instead it gets added to the queue and it sends later.
Interesting because now, i put a vTaskDelay(20); inbetween requests and it is working fine now. There is the queue, and the timeout and my boolean Bus_is_Busy, and even with the given conditions, i had to put a delay inbetween requests.  If i lower the delay to 15 or 10 millis, the errors are coming back. Slower and fewer but they are there.
How is it possible? :D

I always gets added to the queue. Because sending and receiving is in another task and the queue does the syncing between the tasks.
Where do you add the delay? In your code?
You might want to raise the queue size: https://github.com/bertmelis/esp32ModbusRTU/blob/72dd86c0a0fa020c73ca4bf4b73653997a280f20/src/esp32ModbusRTU.h#L31
The queue is by default only 20 requests. If you loop over 128 slaves, the queue fills up fast...

I have this function:
static const inline void ModBus_RUN(){
  if(Flip_Read){
    ModBus_Read_Existing();
    vTaskDelay(20);
    Write_Thermos();
  }
}

This has two functions in it. One for communicating the existing slaves and one for communicating a thermostat.
Address_Array contains the existing addresses of the slaves on the bus. This function is looping trought of all the slaves. One by one. After one request, 20 millis delay and check the thermostat wich is running in every second.
int Reading_Address = 0;
static const inline void ModBus_Read_Existing(){
  if(!Bus_is_Busy){
    Bus_is_Busy = true;
    modbus.readHoldingRegisters(Address_Array[Reading_Address], Start_In_Reg_Address, Reg_Count);
    Reading_Address++;
    if(Address_Array[Reading_Address] == 0){Reading_Address = 0;}
  }
}

long thermosreadtime = millis();
static const inline void Write_Thermos(){
  if(millis() - thermosreadtime >= 2000 && !Bus_is_Busy){
    thermosreadtime = millis();
    Bus_is_Busy = true;
    modbus.writeMultHoldingRegisters(128,0,8,Thermos_Data);
    Thermos_Data[11]++; if(Thermos_Data[11] >= 60){Thermos_Data[11] = 1;}
    Thermos_Data[15]++; if(Thermos_Data[15] >= 8){Thermos_Data[15] = 1;}
  }
}

The queue is not getting 128 requests just once at start up. After that the program communicates with the existing slaves on the bus, wich is currently 2.

Are you getting the response before you make the next request?

It doesn't matter if i get data or an error, in both situations, i make the Bus_is_Busy bit to false and the request goes again. Or why do you ask?
I don't call the modbus read if the previous is not finished. If is that what you asking.


update to latest version and keeps reverting to previous version

Prerequisites

[x] I'm using latest version: v
[ ] I've checked Known issues

Description
[Description of the issue]
Operating system:
I'm using Windows 10.  I have 0.21.0 running and it tells me there is an update.  I click on update to latest version and it takes me to the website.  I click the web installer and run through the install.  It closes my running version correctly and starts up correctly and I can verify I am now running 0.21.1.  However after a period of time, maybe it's after a Windows restart, I get notifications that an update is available and I notice I'm back to running 0.21.0 again.  I think I've installed 0.21.1 3 times now.
Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

Expected behavior: [What you expect to happen]
Actual behavior: [What actually happens]
Reproduces how often: [What percentage of the time does it reproduce?]
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

Hi @dmikester1 ,thanks for the report!
How do you verify the version? From "About"  window?
Maybe try going to Windows settings and see if there are multiple versions installed?

No reply and pretty old issue, so closing.


adding a test to write an GNU tar layer with padded zeros at the end

This is just a test pr against main to show prove that our untar logic will hang forever if given an image with a padded tar layer

Closing this PR, since this was just to show the test written was a valid test. And failed against main.


Get week ranges for a given month?

I needed a way to get the week ranges (start/end day) for a given month. I ended up with this hacky solution:
function weeks (month) {
    month = moment(month, 'YYYY-MM-DD');

    var first = month.day() == 0 ? 6 : month.day()-1;
    var day = 7-first;

    var last = month.daysInMonth();
    var count = (last-day)/7;

    var weeks = [];
    weeks.push([1, day]);
    for (var i=0; i < count; i++) {
        weeks.push([(day+1), (Math.min(day+=7, last))]);

    }
    return weeks;
}

http://jsfiddle.net/simo/xPcEm/
Is there a better (cleaner) way to accomplish this?
Thanks!

I came up on this issue by searching on Google. Came up with a simple solution for this;
const weeksInMonth = moment(moment().endOf('month') - moment().startOf('month')).weeks()

@jtangelder If moment('2015-02-01') is plugged in the function returns 5. Given Feb 2015 was not a leap-year and had 28 days would you expect this to return 4?

I was using this solution Math.ceil(moment().daysInMonth()/7)

@jhabdas what about October 2016  your solution returns 5 but it has 6 weeks ,i was using Math.ceil(moment()).daysInMonth()/7) and face the same issue

@basilinhoe If that's the case I'd consider it a bug in Moment Duration. Could you double-check your installed version of Moment and Moment Duration so we can open a new ticket?

Also need sample Inputs to reproduce.

@basilinjoe If that's the case I'd consider it a bug in Moment Duration. Could you echo your installed version of Moment and Moment Duration, and provide sample input data to reproduce so we can open a new ticket?

/fyi @fluidbyte

@jhabdas I encountered the same bug as @basilinjoe
In October 2016, moment duration (using your function) returns 5 weeks instead of 6. I've created a quick CodePen: http://codepen.io/UnrealKazu/pen/jrYVwE

I'll be damned. Thanks. Will file a bug.

@jhabdas Nice! If you could link the bug report here so that we can track it, that would be great.

@timrwood thoughts on the above line of questioning before I open a bug? Looking at October on the Calendar it starts on a Sunday and ends on a Monday, covering a 6 week period (and not 5).
My use case personally was to create a bar graph with one bar for each week in the month. This seems it should be a trivial endeavor. But I had difficulty in doing so, and it seems others are as well.

@jhabdas Did you ever file that bug? I can't seem to find it. I do however have the same issue with October 2017.

Nope. I decided to quit my job instead.


Fix snakemake version to be less than 8.6.0 to fix temp delete issue.

Snakemake 8.6.0 introduced a bug that prevented the deletion of temp files created before a checkpoint, even after a complete DAG execution. This bug was introduced when a pull request was merged into version 8.6.0 of Snakemake, which prevented some corner cases where temp files were deleted before a checkpoint even though they were needed later. However, this change prevents any temp files before a checkpoint from being deleted. After this bug was introduced, these temp files were not deleted, even at the end of the pipeline. We have many gigabytes of temp files in our pipeline before the checkpoint 'split_circular_and_linear_contigs' that need to be deleted; this leads to my server running out of storage room.  I provided a bug report to Snakemake here: https://github.com/snakemake/snakemake/issues/2982
As a temporary fix I am fixing the Snakemake version to be less than 8.6.0 but more than 8.0.0.

I figured out that I basically have to go back farther to version 7.0 because older versions of snakemake 8 are not stable and cause issues.


Fix CI by updating pnpm-lock.yaml

Build was failing due to old version of pnpm-lock.yaml. Update it and while at at it update pnpm version.

🙏


Some text illegible when using Azure dark theme

Describe the Bug with repro steps
There are multiple places where I notice incompatibilities with the Azure dark theme. Here are some examples:

Confirmation when deleting a step
Configuration screen for the "Sends a message to the SQS queue" step

Workflow JSON
No response
Screenshots or Videos

Browser
Google Chrome Version 111.0.5563.146 (Official Build) (arm64)
Additional context
No response

@rllyy97 did this fix not make it to production yet?

This was not part of the production hotfix, we're gonna be rolling it out in this weeks release

@hamdrew this should be fixed with the release going out this week.


Make MaterializeEncodingPass be backend specific.

Move the tiling selection logic to LLVMCPUMaterializeEncodingPass and VMVXMaterializeEncodingPass.cpp.
Rename Common/MaterializeEncodingPass to Common/MaterializeEncodingIntoPackUnPack.cpp.
The shared patterns and utils are implemented by Common/MaterializeEncodingIntoPackUnPack.cpp.
Expose (or say move from Passes.h) getMaterializeEncodingValueFn method in Common/EncodingInfo.h, which is needed by TileAndDistributeToWorkgroupsPass.

Took a first pass. I think this layering works for me. Thanks for doing this! Is this ready to land, if so I can approve.

I'm fixing the bazel build. If it's fixed, we can land the PR.


Clean up formatting of outgoing email article

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


brilliant-CV:2.0.0

I am submitting

[X] a new package
[ ] an update for a package

Description: Explain what the package does and why it's useful.
Brilliant CV is a Typst template for making Résume, CV or Cover Letter inspired by the famous LaTeX CV template Awesome-CV.
It has several features:

Separation of style and content
Quick twitches on the visual
Multilingual support
AI Prompt and Keywords Injection

I have read and followed the submission guidelines and, in particular, I

[X] selected a name that isn't the most obvious or canonical name for what the package does
[X] added a typst.toml file with all required keys
[X] added a README.md with documentation for my package
[X] have chosen a license and added a LICENSE file or linked one in my README.md
[X] tested my package locally on my system and it worked
[X] excluded PDFs or README images, if any, but not the LICENSE

[X] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

The package name should be all lowercase, i.e. brilliant-cv.

Hi @laurmaedje thanks for the reminder! It should be good now.

Thanks!


OpenH264 failed to build due to error LNK2001: unresolved external symbol _WelsThreadCreate with MSVC on windows.

Environment:
VS 2017 + Windows Server 2016
Issue description:
We tried to build OpenH264 and it failed to build due to error LNK2001: unresolved external symbol _WelsThreadCreate with MSVC on windows. It can be first reproduced on latest revision c185ac3. Could you look at this issue? Thanks a lot.
Repro steps:

git clone https://github.com/cisco/openh264 D:\OpenH264\src
Open a clean x86 prompt and browse to D:\OpenH264
msbuild /p:Configuration=Release;Platform=Win32 /p:WindowsTargetPlatformVersion=10.0.17134.0 .\src\test\build\win32\codec_ut\Codec_UT.sln /t:Rebuild

log_x86_build.log
Error info:
welsdcore.lib(wels_decoder_thread.obj) : error LNK2001: unresolved external symbol _WelsThreadCreate [D:\OpenH264\src\codec\build\win32\dec\WelsDecPlus.vcxproj]
welsdcore.lib(wels_decoder_thread.obj) : error LNK2001: unresolved external symbol _WelsThreadJoin [D:\OpenH264\src\codec\build\win32\dec\WelsDecPlus.vcxproj]
welsdcore.lib(wels_decoder_thread.obj) : error LNK2001: unresolved external symbol _WelsQueryLogicalProcessInfo [D:\OpenH264\src\codec\build\win32\dec\WelsDecPlus.vcxproj]
.........\bin\Win32\Release\welsdec.dll : fatal error LNK1120: 3 unresolved externals [D:\OpenH264\src\codec\build\win32\dec\WelsDecPlus.vcxproj]
Done Building Project "D:\OpenH264\src\codec\build\win32\dec\WelsDecPlus.vcxproj" (Rebuild target(s)) -- FAILED.
Project "D:\OpenH264\src\test\build\win32\codec_ut\Codec_UT.sln" (1) is building "D:\OpenH264\src\codec\build\win32\enc\WelsEncPlus.vcxproj" (7) on node 1 (Rebuild target(s)).

Hi All,
Could someone look at this issue ?
Thanks,
Lin

Hi, All,
Could someone look at this issue ? It can still reproduce on latest revision 4b2a2f0.
Thanks,
Lin

@borzun Thanks for your help! We got the latest version of master branch, and applied the patch of you provided.We tried to build OpenH264 and it passed. could you merge your changes to the master branch? thanks a lot.

@215020267 Sorry, I'm not working for CISCO, and I don't have rights to merge PR into master. But glad that my changes helped you.

@borzun @215020267
merged.


Allow fetching TUF root from HTTP

This patch allows fetching TUF root from HTTP in addition to GCS. If the
specified mirror is an HTTP link, then HTTPRemoteStore will be used.
Otherwise it defaults to GCS.

This PR is related to: https://github.com/sigstore/cosign/issues/1179

@rgerganov You are also missing to update the command description to be able to use a different mirror in cmd/cosign/cli/initialize.go: SigStore remote TUF repository is pulled from the GCS mirror at sigstore-tuf-root.

This description is about the default behavior which is not changed (i.e. pulling from GCS)


Internet identity Refactor

Breaking changes:

identityOverride param is replaced by just having the IIdentity property settable
Fido2 now uses Authenticator class for login. Only one function now


refactor css to make mobile first

change media queries around so that mobile is standard, and media queries are for larger screens

Done.


Renaming files in the FileSystem should edit the path of preload("path") inside all scripts.

Godot version
3.4.2
System information
Linux
Issue description
Renaming files in the FileSystem should edit the path of preload("path") inside all scripts (The path is a compile time const).
Steps to reproduce
Create art1.png and art2.png.
Create a Sprite in your Main Scene and set its Texture to the art1.png file.
Attach a script to the Sprite.
In the script add const art = preload("res://art2.png")
Play your project and notice no errors.
In the FileSystem rename art1.png to heart1.png
In the FileSystem rename art2.png to heart2.png
Play your project and notice that the texture path was updated to the new file name but the script's "const" preload path was not.
preload's path is a compile time const that should be updated on renames.
Minimal reproduction project
No response

Duplicate of https://github.com/godotengine/godot-proposals/issues/899. Implementing this feature essentially requires refactor tooling to safely modify scripts in an automated manner.


Added ability to select template from dropdown

Signed-off-by: Micheal Mand<EMAIL_ADDRESS>

Nice, thank you, will test this out.


[Bug] Toast messages need to show an appropriate error instead of "unexpected error" as a catch all

Description
User needs to click on debugger/browser console to read the exact error since toast messages currently displays a generic "unknown error occurred" message.
Steps to reproduce the behaviour:

Create a query using a Google Sheets data source and run query by missing one or more fields each time before you click on 'Run' and observe the toast messages displayed and check debugger to see actual error messages.

Important Details

Version: Cloud
OS: Win10
Browser: Chrome
Environment: Release

related #6986


Use v-once and/or v-memo with submissions table

v-once and v-memo are mentioned as options for improving performance on this page. The documentation for v-memo says:

v-memo is provided solely for micro optimizations in performance-critical scenarios and should be rarely needed. The most common case where this may prove helpful is when rendering large v-for lists (where length > 1000)

The submissions table seems like a good example of that case.
That said, I've already reduced the reactivity of the submission requestData. That means that the submission row components already have very few reactive dependencies. If there is limited reactivity already, would v-once and v-memo have any additional benefit? My guess is yes, because even if the submission requestData is minimally reactive, the component props are still reactive: the submission row components don't know that they're used within a context that guarantees that their props are immutable.

We're planning to add pagination to the submissions table, which should help a lot with performance. I'm going to go ahead and close this issue. We can always reopen it if there are issues with performance after pagination is introduced.

the submission row components don't know that they're used within a context that guarantees that their props are immutable.

As of #1043, it's no longer the case that the props of SubmissionMetadataRow are immutable: the awaitingResponse prop will change after the delete button is clicked.


Merge the thingpedia-client library in this library

We have too many library. This PR attempts to solve the issue, by merging thingpedia-client in this library.
At the same time, given the internal API is changing in a way that will require the downstream users (almond-dialog-agent, thingengine-core) to adapt, let's also clean up the configuration interface to be more consistent across configuration mechanisms.
Fixes #10

Pull Request Test Coverage Report for Build 125

633 of 724 (87.43%)  changed or added relevant lines in 25 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+16.6%) to 82.773%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/config/base.js
6
7
85.71%

lib/helpers/oauth2.js
2
3
66.67%

lib/base_engine.js
10
12
83.33%

lib/loaders/generic.js
39
41
95.12%

lib/loaders/rss_factory.js
24
26
92.31%

lib/config/oauth2.js
24
28
85.71%

lib/loaders/base_generic.js
31
35
88.57%

lib/loaders/base_js.js
77
82
93.9%

lib/factory.js
10
16
62.5%

lib/utils.js
104
110
94.55%

Totals

Change from base Build 119:
16.6%

Covered Lines:
993

Relevant Lines:
1152

💛  - Coveralls


Incorrect Totals

I've noticed this for a few days. It appears that the totals for NBA (haven't checked other sports) get mixed up for a couple games.
For example today (2023-11-15)  it lists the total for Milwaulkee @ Toronto at 229 when its 224.5 (Mixes it up with NYK @ Atlanta).
And Sacramento @ Lakers it says 217.5 instead of 235.5. (Mixes it up with the Cleveland @ Portland game.
See the pictures for reference. Something is getting mixed up.

also put this on the NBA-Machine-Learning-Sports-Betting issues, believe this is the same issue as #328 and #360 there.
I "think" the issue is related to the sbrscrape making multiple calls to SBR and assuming the results are returned in the same order for the ML, Odds, etc.  But they aren't.  Even if you review the webpage they sometimes come back in a different order.  Could be wrong but it seems the issue is with the scrape, not upstream.

I was able to reproduce this today. I'll have to take a closer look when I have time. PRs welcome!!

should be fixed in 0.0.10


[WIP]fix: fix advanced resolver current schema symbol

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[ ] Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[ ] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

24 of 26 (92.31%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.009%) to 71.88%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

kclvm/sema/src/advanced_resolver/node.rs
20
22
90.91%

Totals

Change from base Build<PHONE_NUMBER>:
0.009%

Covered Lines:
44549

Relevant Lines:
61977

💛  - Coveralls


Add Next 12 and React 18 Support

Upgrade Next.js to version 12 and React to version 18.

Hey!
Thank you for your contribution!
I merged your changes and and published a new version to npm: https://www.npmjs.com/package/next-export-i18n/v/2.0.1
Cheers!


The remote name could not be resolved: 'mbl-sd r.scm.azurewebsites.net'

The remote name could not be resolved: 'mbl-mobilequiz.scm.azurewebsites.net'
	Total Count: 122
	Sources: GetScmData, GetEventLogsFromScm

Total Requests: 57

@stevenernst131  - I guess you fixed this one?

ok. @aspaan - I am guessing you opened this for ILB ASE? what is the course of action here?
For ILB ASE, you will get this error. Is this workitem for catching this exception and consuming it for ILB ASE?


added soil test centers nearby using maps

Pull Request
Title
Integration of a location-based search feature using the Google Maps API or Mapbox. This feature would allow users to search for nearby soil testing centers based on
Description
Current location (using geolocation services).
Manually entered address or location.
The system would display a map with nearby soil testing centers, along with details such as contact information, services offered, and directions to the center
Related Issues
issue #161
Changes Made
added a map of soil test centers in india , it is just demo , i will improve this feature in upcoming days
Checklist

[x] I have tested the changes locally
[ ] Documentation has been updated (if necessary)
[x] Changes are backward-compatible

Screenshots (if applicable)

Additional Notes
i will improve this feature in upcoming days
Footer

hi @Anandha-Vihari as of now it is not showing anything in deployment..
could you please share working video..so that i will get clarity on how it is working..


could you share inferrence.py file ? thank you advance.

Thank you for your interest in our work!
Simply add --resume path/to/ckpt.pth  --eval  on the training script, and you can perform inference.


chore: bump navajo version to v0.0.2

Fixes aead::DecryptReader when input Read is less thanSegment (#39)

Codecov Report
Patch coverage has no change and project coverage change: -0.03 :warning:

Comparison is base (e772cf2) 59.34% compared to head (362e31c) 59.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   59.34%   59.32%   -0.03%
==========================================
  Files          88       88
  Lines        9188     9188
==========================================
- Hits         5453     5451       -2
- Misses       3735     3737       +2

see 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Uncaught TypeError: Cannot read property 'length' of undefined

For some reason I always get this error randomly

I have a one page application and I use this library to put some effects to it, I don't always use it, there are places where this library just stands, and wherever I don't use it, it gives me that error, sometimes it takes a lot of time for it to show up, sometimes it shows right after refreshing.
The error is on this line:
,t.prototype._restorePlayingTweens=function(){for(var t=0;t<this._savedTweens.length;t++)this._savedTweens[t].resume()},t}()),p=new a;e["default"]=p}

for "this._savedTweens.length;"

Hi @Kaperstone,
Sorry for the long wait.
Did this issue is resolved today?
Thx :wink:

I somehow got around this back then, don't remember how.
anyhow, I don't use this lib, this is an amazing lib tho!


DOCKER_OPTS not working

Output of docker version:
Client:
 Version:      1.12.0-rc3
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   91e29e8
 Built:        Sat Jul  2 00:53:33 2016
 OS/Arch:      linux/amd64
 Experimental: true

Server:
 Version:      1.12.0-rc3
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   91e29e8
 Built:        Sat Jul  2 00:53:33 2016
 OS/Arch:      linux/amd64
 Experimental: true

Steps to reproduce the issue:

install 1.12.0-rc3
modify /etc/default/docker (eg: DOCKER_OPTS="--storage-driver=overlay2")
docker daemon is not running with these additional arguments

Additional information you deem important (e.g. issue happens only occasionally):
Tested on Ubuntu 16.04 and CentOS 7

@sodre90   Did you  restart the docker daemon,after modifying /etc/default/docker?   if not, please restart the docker daemon, try again.

The /etc/default/docker file is only used for systems using upstart or sysvinit; see the comment at the top of that file; https://github.com/docker/docker/blob/master/contrib/init/sysvinit-debian/docker.default#L1-L8. Both Ubuntu 16.04 and CentOS 7 use systemd, so don't use this file.
The easiest way to configure the daemon, is to use a /etc/docker/daemon.json configuration file; https://docs.docker.com/engine/reference/commandline/dockerd/#/daemon-configuration-file
Alternatively, use a systemd drop-in file, as explained in this section of the documentation
I'll close this issue, because this is not a bug, but feel free to comment after I closed


FancyZones feature request: Different Zone Layouts on multi-monitor setups

Hi,
love fancyzones. I have 3 monitors at 3840 x 2160. I would love to have 3 fancy zones layouts, a different one for each montor.
left: 3 horizontal zones
center: 5 zones focus
right: 4 quadrant zones
Would you consider adding this?
Also in the custom layout creator, could you add snaps for
horizontal and vertical snaps at 1/2 of screen, 1/3, 2/3 of screen?
If two zones touch, they could be sticky, eg. if I move the line, both zones resize.
best
chris

Tried few time, in laptop screen also a HDMI connected screen. After click apply then a flash of the frames, and gone.
Hope get help.
Windows 10.
I am new here,
Thanks very much.


Fixed calculation of total lost rays in plots.

Dear Manuel,
Please consider to merge this minor fix for displaying the total number of lost rays in the plots. Thank you.
Regards,
Maksim Rakitin

Thanks a lot Maksim

I was glad to help! Thanks for merging.


diff-quality --violations=pylint fails because of innocuous stderr output from pylint

This started happening today -- I'm guessing it's due to a recent change in pylint.
If I run diff-quality --violations=pylint, it fails with the following output:
$ diff-quality --violations=pylint
> /usr/local/pyenv/versions/2.7.13/envs/mcdsu-2.7.13/lib/python2.7/site-packages/diff_cover/command_runner.py(53)run_command_for_code()
Traceback (most recent call last):
  File "/usr/local/pyenv/versions/mcdsu-2.7.13/bin/diff-quality", line 11, in <module>
    sys.exit(main())
  File "/usr/local/pyenv/versions/2.7.13/envs/mcdsu-2.7.13/lib/python2.7/site-packages/diff_cover/tool.py", line 376, in main
    exclude=arg_dict['exclude'],
  File "/usr/local/pyenv/versions/2.7.13/envs/mcdsu-2.7.13/lib/python2.7/site-packages/diff_cover/tool.py", line 296, in generate_quality_report
    reporter.generate_report(output_file)
  File "/usr/local/pyenv/versions/2.7.13/envs/mcdsu-2.7.13/lib/python2.7/site-packages/diff_cover/report_generator.py", line 216, in generate_report
    report = template.render(self._context())
  File "/usr/local/pyenv/versions/2.7.13/envs/mcdsu-2.7.13/lib/python2.7/site-packages/diff_cover/report_generator.py", line 260, in _context
    (src, self._src_path_stats(src)) for src in self.src_paths()
  File "/usr/local/pyenv/versions/2.7.13/envs/mcdsu-2.7.13/lib/python2.7/site-packages/diff_cover/report_generator.py", line 83, in src_paths
    return set(src for src, summary in self._diff_violations().items()
  File "/usr/local/pyenv/versions/2.7.13/envs/mcdsu-2.7.13/lib/python2.7/site-packages/diff_cover/report_generator.py", line 176, in _diff_violations
    ) for src_path in self._diff.src_paths_changed()
  File "/usr/local/pyenv/versions/2.7.13/envs/mcdsu-2.7.13/lib/python2.7/site-packages/diff_cover/report_generator.py", line 176, in <genexpr>
    ) for src_path in self._diff.src_paths_changed()
  File "/usr/local/pyenv/versions/2.7.13/envs/mcdsu-2.7.13/lib/python2.7/site-packages/diff_cover/violationsreporters/base.py", line 157, in violations
    output, _ = execute(command)
  File "/usr/local/pyenv/versions/2.7.13/envs/mcdsu-2.7.13/lib/python2.7/site-packages/diff_cover/command_runner.py", line 43, in execute
    raise CommandError(stderr)
diff_cover.command_runner.CommandError: Using config file /opt/dev/src/.pylintrc

Note the stderr output does not indicate an actual error, it's simply notifying what configuration file pylint is using. This message is coming from here.
This occurs with diff_cover version 1.0.0 and pylint version 1.8.1.

Hmm, I believe we have a fix currently living on master that I intend to release soon

@peterg79  do I have that right?

I just need to find some time to actually do a release. This weekend by the latest...

Sounds great! BTW, I confirmed it does not fail if I downgrade to pylint 1.7.5.

@Bachmann1234 that's right, version 1.0.2 will fix that. This issue is a variation of https://github.com/Bachmann1234/diff-cover/issues/58 - that is fixed in 1.0.2 too.
Basically, pylint enabled more output to stderr, and diff-quality considered it as an error. From 1.0.2 diff-cover looks at the exit code of the process to determine if the tool run properly.

Released! https://pypi.python.org/pypi/diff_cover/1.0.2

That's great! Thanks for the quick turnaround.


Discovery methods

You are using SSDP as a discovery service.
  ssdpServer = new Ssdp.Server({
    suppressRootDeviceAdvertisements: true,
    location: `http://${ip.address()}:${port}`,
    sourcePort: 1900,
  })
  ssdpServer.addUSN('bigfoot:all')
  ssdpServer.start()

Is there in your roadmap any spot for another discovery process? cloud?

I am still researching what method would be the best to implement other discovery/ linking / claiming methods that already exist out there.
Currently I am most worried about bluetooth methods and cloud as you suggest than others but it still not clear. Probably some kind of QR code linking would be best to exchange credentials with services.


Consider adding Alaska / Arctic switch for data

The pan-Arctic data lags a lot behind the Alaska dataset.  We can consider adding the Alaska data to this app.

We're using the standard NSIDC product now so I think this ticket can be closed.


doc: Instruct windows users to not install the lastest gnuarmemb

The latest release of the Windows toolchain has a critical bug,
Windows users should install the next-to-latest release instead.
To prevent Windows users from being affected we add a note about this
in the documentation.
Bug: https://github.com/zephyrproject-rtos/zephyr/issues/12257
Signed-off-by: Sebastian Bøe<EMAIL_ADDRESS>

Codecov Report

Merging #14146 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #14146   +/-   ##
=======================================
  Coverage   52.68%   52.68%
=======================================
  Files         307      307
  Lines       45473    45473
  Branches    10530    10530
=======================================
  Hits        23956    23956
  Misses      16640    16640
  Partials     4877     4877

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f96c9bc...21488bb. Read the comment docs.

Instead of documenting away the bug, I would prefer to fix it. Closing this in favour of https://github.com/zephyrproject-rtos/zephyr/pull/14158

@dbkinder can you revisit please?

recheck

recheck

@carlescufi : This can (finally) be merged.


[🐞] State Not Refreshing/Updating Inside Form Action Callback

Which component is affected?
Qwik Runtime
Describe the bug
I want to show a loading indicator when the form is submitted using routeAction as follows but it seems the state is not updating even though the callback gets called after the submission is completed.
`
export default component$(() => {
const action = useFormSubmitAction();
const processing = useSignal(0);
return (

<Form
action={action}
onSubmit$={()=>{
processing.value = 1;
}}
onSubmitCompleted$={(d)=>{
console.log("submission done");
processing.value = 0;
}}
spaReset
>

                ....

                <button type="submit" class="btn">{processing.value==1? 'Posting...':'Post'}</button>

          </div>
        </Form>
  </article>

);
});
`
Reproduction
https://qwik.new/
Steps to reproduce
Just run the route component posted above.
System Info
Windows 11 Nodejs 20

Additional Information
No response

@nla-asia I faced a similar problem. In my case, onSubmit$ was somehow notified after onSubmitCompleted$. I found action had isRunning property and I worked around the problem by using action.isRunning instead of a flag controlled by onSubmit$ and onSubmitCompleted$ events. I do not think isRunning is documented, so I do not know we can rely on it, though.
https://github.com/BuilderIO/qwik/blob/ab74880eeaaed4a247f369ce6754ddcd966176b7/packages/qwik-city/runtime/src/server-functions.ts#L105

Correct . isRunning is the way to get that information.
I am going to close this issue as solved. If you feel otherwise, please re-open with a reproduction, your current URL points to a generic stackblitz.


PNGs over a certain size do not load in the browser

When you try to view on the browser a PNG uploaded that goes over a certain file size, you get a server error instead of seeing the file.
Steps:

Create or open a new public container.
Select "Upload to this Container" and select a PNG of at least 91 KB in size.
Click on "Click to view file in web browser".

You will then end up with a browser tab showing a server error 502 instead of seeing the image file. I don't the minimum file size that triggers this. A very small PNG file such as a 2KB one does not trigger it. This could also be a server-side issue, though, as you can still download the PNG file from NeoFS without issues through Greenfinch
Example of a public PNG file that is around 91KB in file size.

Tried to load the file once more and actually got a different response from the server this time.
could not receive object: read header: read response: rpc error: code = Unavailable desc = error reading from server: EOF

Issue seems to be fixed now.

Great news, this was an issue with the HTTP node and not greenfinch as it turned out, but all good - it was a necessary for greenfinch


Migrate AlertDialog to OverflowBar

Description
Thir pr migrates the legacy ButtonBar in AlertDialog to the new OverflowBar.
This also fixes a visual padding issue.
Most of the new code is copied from the DatePicker.
Related Issues
This issue will be fixed. (The bottom padding of the bar should be equal to the right padding. Just like it is in the DatePicker.

Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behavior with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[ ] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

Hey @HansMuller I think you are the right Person to tag regarding this change? :)
What do you think about it?

Gold has detected about 1 untriaged digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/68330

Gold has detected about 3 untriaged digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/68330

This looks like a good change however it looks like there are golden-image failures. I assume they're due to the "visual padding" change you mentioned in the description? It would be best to break this into two PRs: a non-breaking PR that substitutes OverflowBar for ButtonBar, and then a separate breaking PR which changes the dialog's layout.  Breaking changes require additional effort, please see https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes

Okay that sounds fair enough. I will try to make the golden files not fail anymore for this pr.
Another thing though: This pr is kind of breaking by deprecating buttonPadding. I had to do this as OverflowBar uses spacing instead, which requires a double instead of a EdgeInsetsGeometry.
Right now I don't really see a way to Integrate the OverflowBar by still having buttonPadding work.
Do you have any idea regarding this problem?

Maybe we should start with deprecating buttonPadding and introducint actionsButtonSpacing, which can easily be converted to a EdgeInsetsGeometry until we introduce the OverflowBar and make buttonPadding useless? 🤔

Gold has detected about 1 untriaged digest(s) on patchset 7.
View them at https://flutter-gold.skia.org/cl/github/68330

Maybe we should start with deprecating buttonPadding and introducing actionsButtonSpacing as it's replacement, which can easily be converted to a EdgeInsetsGeometry until we migrate to the new OverflowBar and make buttonPadding useless? 🤔

@HansMuller Sorry for tagging you again, but I would like to have your opinion regarding this

Gold has detected about 1 untriaged digest(s) on patchset 10.
View them at https://flutter-gold.skia.org/cl/github/68330

I have some issues because I accidentally pushed this into my master branch. I will reopen a new pull request

But I'm glad, that this could be a good example for @dnfield 😁😁


CommaApi: use auth.py for request authentication when on PC

This should only be done for fetching the routes for replays.


Tech spike - Remove serialization manager injection in fromJson

Is your feature request related to a problem? Please describe.
To comply with the standardized format for fromJson method we would need to remove the injection of the serialization manager.
fromJson interface would go from this:
  factory SerializableEntity.fromJson(
    Map<String, dynamic> jsonSerialization,
    _i1.SerializationManager serializationManager,
  ) {}

To this:
  factory SerializableEntity.fromJson(
    Map<String, dynamic> jsonSerialization,
  ) {}

Describe the solution you'd like
Tech feasibility investigation with an issue defined for what needs to be done to make this happen.

Issue created: https://github.com/serverpod/serverpod/issues/2027


Invoke notify callback with errors

This PR ensures that the callback argument on the notify function is invoked with an error as the first argument when the event is prevented from being sent to Bugsnag.
The situations & their messages are;

When an API key is not supplied.

Error: Bugsnag has not been configured with an api key!

If the release stage is not included in the notifyReleaseStages array.

Error: Current release stage not permitted to send events to Bugsnag.

If a beforeNotify callback prevents the event from being sent.

Error: At least one beforeNotify callback prevented the event from being sent to Bugsnag.

Fixes #74

Thanks for the patch, @jacobmarshall! Looks good to me, I just had one tweak to make the error message generation a bit more readable. :ship:

Thank you! 🎉


Add comments to top of packages for GoDoc

It's really not helpful right now: https://godoc.org/github.com/blue-jay/blueprint

All done, woot!


When ginkgo timeouts, artifacts are not gathered

Observed this in a couple of different suites (both k8s and openshift)
https://circleci.com/gh/Azure/acs-engine/30298?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
test.mk:26: recipe for target 'test-kubernetes' failed
make: *** [test-kubernetes] Terminated
Too long with no output (exceeded 30m0s)

@jackfrancis @CecileRobertMichon @mjudeikis if you want to have a look

https://circleci.com/gh/Azure/acs-engine/30340?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

I've seen quite a few of those. My assumption was that circle was getting stuck...


Admob Pro License

Hi Sir,
I want to buy Admob Pro License
Can you help me to implement the interstitial ads on navigation menu

The license fee only cover the usage of this plugin for commercial.
Please read the documentation and example code to learn how to use it, if any question, you can ask here.

I only have basic html skills
my apps are based on simple html only, only article as a content
If you can help me to implement the interstitial ads on navigation menu in index.html, I'll buy the license
I'll sent my index.html later

@wahyuxo to my understanding, an app needs some logic, even very basic. I guess you need learn some javascript to make it an app.

I use cordova to make app and I have the complete and working html5 template (include jquery.mobile and other javascript), I've tested it with admob_simple.js and the banner and interstitial appeared in my app, but the interstitial appear a few second after the app opened, and it break the admob rules.
The interstitial should be appeared in the transtition page before the next page appeared.
I want to call the interstitial to appear in the transatition page between index.html and the next page
I hope you understand it and can help me
thanks

Okay, now I understand.
I can check if I can help if you can send me (rjfun.mobile at gmail dot com):
1, your index.html file;
2, your ad unit id (created in your admob portal)

I've sent you my index and ad unit via email (grapmarbel at yahoo dot com)
Title : "Wahyuxo Interstitial Github + ( Index Template File )"
I hope you can help me
thanks

I did received your email and downloaded your files from dropbox, but unfortunately, when open it in browser, it does not work properly and always show error loading page. Sorry, I have no time to debug your app, you need resolve it.

You should remove cordova.js in the folder before to try it in the browser, because cordova.js will be loaded first before the index.html opened
I forget to remove the cordova.js from the folder
I've sent you a new file without cordova.js, you should be able to open it properly
I hope you can help me
thanks

Yes, when I remove the following things to get it loaded in broswer.
		<script type="text/javascript" charset="utf-8" src="cordova.js"></script>
		<script type="text/javascript" src="admob_simple.js"></script>

I can see clickable items in the browser, but when I click the items, it always shows Error Loading Page.

Oks I see the problem,
You should open the file in Mozilla browser
I've tried to open it in Opera and the button always shows Error Loading Page
But, I have some applications from this template and run smoothly in my android devices.


Quick fix add import depends upon the case of the import

Environment data

Language Server version: XXX
OS and version: XXX
Python version (& distribution if applicable, e.g. Anaconda): XXX

Code Snippet
# test.py
abcd = 1234

# main.py
abcd

in main.py file, I can't use "cmd + ."  to get quick fix.
if "abcd" is rename "Abcd", it run good.
Repro Steps

XXX

Expected behavior
XXX
Actual behavior
XXX
Logs

XXX

Thanks for the issue. I think what you're asking is why abcd doesn't have a quick fix but Abcd does?
I get this if the import is Abcd:

But I get nothing if it's abcd (well nothing from pylance).

That seems like a bug to me.

Is this related to https://github.com/microsoft/pylance-release/issues/5159?

Is this related to #5159?

Might be. Might be the root cause of 5159.

Okay it seems this is on purpose. What a module exports and what it doesn't isn't really defined anywhere. By convention, you would use an __all__ method to indicate variables you'd want to export.
So something like so:
# test.py
abcd = "1234"
__all__ = ['abcd']

# main.py
abcd # Add import quick fix works now

But if you don't use __all__, Pylance only exports variables it considers constants. Constants conventionally are all CAPS or CamelCased.

The code for this is actually open sourced. It's here:
https://github.com/microsoft/pyrx/blob/2d8f5abb0551f63d626d2428cd9474c56015233f/packages/pyright/packages/pyright-internal/src/analyzer/symbolNameUtils.ts#L48

If we don't use such a heuristic to limit the variables that are exposed, hundreds of temporal variables defined in any user files will show up in the code actions or completion. Our decision is that the user needs to explicitly tell us their intention that a variable is supposed to be consumed by another module by putting it in __all__

@heejaechang @debonte @rchiodo
Even if __all__  is used, there are still issues. Please refer to the zip file I provided below.
I first created files __init__.py and res_manager/integrator.py.
in __init__.py  file, it is ok.

and I create res_manager/tese.py file, it not good.

Then we go back to the __init__.py file,  and it didn't run either

test-py.zip


Code workflow

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: satyamg448 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


update packages

:x: Build TheIdServer 8.1.0-fix-dependencies.1+10.build.3826 failed (commit https://github.com/Aguafrommars/TheIdServer/commit/ff3369714c by @invalid-email-address)

:white_check_mark: Build TheIdServer 8.1.0-fix-dependencies.1+10.build.3827 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/ff3369714c by @invalid-email-address)


Fix missing includes and incorrect string literal declaration

Hi.
I'm interested in using this library, so I decided to compile the examples. But it seems that there are missing includes and incorrect raw string literal declarations that prevent it from compiling. This is my fix for that.
Thanks!

Thanks a lot for taking the time to make the PR!
LGTM!


Add reinit on specific slide

Allow reinit of Slick to specify a current slide to address the issue when a slide is inserted at the beginning of the carousel dynamically on "previous" click.  This allows lazy-loading of very long carousels.
https://github.com/kenwheeler/slick/issues/303

@kenwheeler Any chance we can get this code merged? I tried it and it works fine.

@keithlam can you update this to work with the current version on master, and for slide removal as well?


Fix: Use alt and <title> in UNSTABLE_PartnerLogo and UNSTABLE_ProductLogo

Description
Use the alt attribute and <title> tag to make the inside images accessible.
Issue reference
Discovered in #1618.

Maybe the first line of the commit message could be better.

coverage: 78.696%. remained the same
when pulling b7e8db7b96fb3979bf3003b104814f816770bf48 on fix/product-and-partner-logo
into e5c8a7b7d118e001a9f8df9a569e933367b075fa on main.

ParterLogo and ProductLogo are already stabilized in integration/BC-v3-design-tokens


Speedup - Error when updating mask for aten::div

Describe the issue:
The following error occurred when updating mask for aten::div:
unsupported operation: more than one element of the written-to tensor refers to a single memory location. Please clone() the tensor before performing the operation.
How to reproduce it?:
The issue can be reproduced by pruning this model and speedup after.
Model

Config:

Environment:

NNI version: 2.9
Python version: 3.9
PyTorch/TensorFlow version: 1.12.1
Is conda/virtualenv/venv used?: yes
Is running in Docker?: yes

RuntimeError                              Traceback (most recent call last)
Cell In [12], line 4
1 # speedup the model, for more information about speedup, please refer :doc:pruning_speedup.
2 from nni.compression.pytorch.speedup import ModelSpeedup
----> 4 ModelSpeedup(model, torch.rand(100, 3, 160, 160).to(device), masks).speedup_model()

File ~/fyp/venv/lib/python3.9/site-packages/nni/compression/pytorch/speedup/compressor.py:547, in ModelSpeedup.speedup_model(self)
544 fix_mask_conflict(self.masks, self.bound_model, self.dummy_input)
546 _logger.info("infer module masks...")
--> 547 self.infer_modules_masks()
548 _logger.info('resolve the mask conflict')
550 # load the original stat dict before replace the model

File ~/fyp/venv/lib/python3.9/site-packages/nni/compression/pytorch/speedup/compressor.py:380, in ModelSpeedup.infer_modules_masks(self)
378 curnode = visit_queue.get()
379 # forward mask inference for curnode
--> 380 self.update_direct_sparsity(curnode)
381 successors = self.torch_graph.find_successors(curnode.unique_name)
382 for successor in successors:

File ~/fyp/venv/lib/python3.9/site-packages/nni/compression/pytorch/speedup/compressor.py:247, in ModelSpeedup.update_direct_sparsity(self, node)
244 self.auto_inferences[unique_name] = _auto_infer
245 _auto_infer.name = node.unique_name
--> 247 _auto_infer.update_direct_sparsity()
248 # also save the input debug names into the auto_infer
249 _auto_infer.input_debugname = input_debugname

File ~/fyp/venv/lib/python3.9/site-packages/nni/compression/pytorch/speedup/infer_mask.py:331, in AutoMaskInference.update_direct_sparsity(self)
326 constant = None
327 with torch.no_grad():
328     # Note: we need randomly init the input one more time here!
329     # Because some operation have the in-place operation, such as relu_,
330     # the in-place operation may modify or write 0s into the dummy_input
--> 331     self.random_init()
332     # apply the mask for the input tensor and the weight tensor
333     self.apply_mask()

File ~/fyp/venv/lib/python3.9/site-packages/nni/compression/pytorch/speedup/infer_mask.py:139, in AutoMaskInference.random_init(self, start, end)
130 for tensor in self.dummy_input:
131     if isinstance(tensor, torch.Tensor) and len(tensor.size()) > self.batch_dim
132         and tensor.size(self.batch_dim) == self.batch_size:
133         # if the input tensor only has one dimension, which means
(...)
137         # by the size operator), then we will skip this tensor
138         # try:
--> 139         randomize_tensor(tensor, start, end)
140         # except:
141         #     pass
142 for para in self.weights:

File ~/fyp/venv/lib/python3.9/site-packages/nni/compression/pytorch/utils/utils.py:79, in randomize_tensor(tensor, start, end)
72     torch.randint(int(start), int(end), tensor.size(),
73                   out=tensor.data, dtype=tensor.dtype)
74     # pass
75 else:
76     # we can use nn.init.uniform_ to randomize this tensor
77     # Note: the tensor that with integer type cannot be randomize
78     # with nn.init.uniform_
---> 79     torch.nn.init.uniform_(tensor.data, start, end)

File ~/fyp/venv/lib/python3.9/site-packages/torch/nn/init.py:137, in uniform_(tensor, a, b)
135 if torch.overrides.has_torch_function_variadic(tensor):
136     return torch.overrides.handle_torch_function(uniform_, (tensor,), tensor=tensor, a=a, b=b)
--> 137 return no_grad_uniform(tensor, a, b)

File ~/fyp/venv/lib/python3.9/site-packages/torch/nn/init.py:14, in no_grad_uniform(tensor, a, b)
12 def no_grad_uniform(tensor, a, b):
13     with torch.no_grad():
---> 14         return tensor.uniform_(a, b)

RuntimeError: unsupported operation: more than one element of the written-to tensor refers to a single memory location. Please clone() the tensor before performing the operation.

It's a bug that has been reproduced in #5018. The reason is that we should randomize all the intermediate tensor variables, but the randomize function did not treat un-contiguous tensor correctly.
the fix is in #5141.

It's a bug that has been reproduced in #5018. The reason is that we should randomize all the intermediate tensor variables, but the randomize function did not treat un-contiguous tensor correctly. the fix is in #5141.

Thanks for the reply, it solved the above issue.
The pruning and speedup can be completed without issue, but inference fails after speed-up:
RuntimeError: Given groups=1, weight of size [82, 705, 1, 1], expected input[10, 574, 8, 8] to have 705 channels, but got 574 channels instead
I am using the dependency-aware mode

The pruning and speedup can be completed without issue, but inference fails after speed-up:
RuntimeError: Given groups=1, weight of size [82, 705, 1, 1], expected input[10, 574, 8, 8] to have 705 channels, but got 574 channels instead
I am using the dependency-aware mode

Thanks for @weixingp raising new issue. Could you provide more details for debugging?

The channels error happens before, but we haven't solved it yet. We are going to solve it in version 3.x.


Handle the Users errors

Need to handle a few errors for User CRDs. Errors:

username already in use  (when adding new user)
username not found (when deleting user)

example of the first error:

Check this case for Postgres User

Decided to remove the postgres user management in general


mmseqs2 cannot remove identical sequences in cluster or linclust

Expected Behavior
mmseqs2 should remove exactly identical sequences if I run linclust or cluster on the attached file.
pdb_seqres.protein.linclust.fasta.gz
Current Behavior
In both cluster and linclust, the result contains multiple entries with identical sequence "MGIFNGIIEFLSNINFEVIAQLTMIAMIGIAGPMIIFLLAVRRGNL" or "EVIAQLTMIAMIGIAGPMIIFLLAVRRGNL"
Steps to Reproduce (for bugs)
mkdir -p mmseqs2_cluster
./mmseqs2/bin/mmseqs createdb pdb_seqres.protein.fasta mmseqs2_cluster/pdb_seqres.protein.DB
./mmseqs2/bin/mmseqs cluster mmseqs2_cluster/pdb_seqres.protein.DB mmseqs2_cluster/pdb_seqres.protein.cluster /tmp/zcx/mmseqs2  --min-seq-id 0.9 --cov-mode 1 -c 0.9
./mmseqs2/bin/mmseqs createseqfiledb mmseqs2_cluster/pdb_seqres.protein.DB mmseqs2_cluster/pdb_seqres.protein.cluster mmseqs2_cluster/pdb_seqres.protein.cluster.DB
./mmseqs2/bin/mmseqs result2flat mmseqs2_cluster/pdb_seqres.protein.DB mmseqs2_cluster/pdb_seqres.protein.DB mmseqs2_cluster/pdb_seqres.protein.cluster.DB mmseqs2_cluster/pdb_seqres.protein.cluster.fasta
./mmseqs2/bin/mmseqs linclust mmseqs2_cluster/pdb_seqres.protein.DB mmseqs2_cluster/pdb_seqres.protein.linclust /tmp/zcx/mmseqs2  --min-seq-id 0.9 --cov-mode 1 -c 0.9
./mmseqs2/bin/mmseqs createseqfiledb mmseqs2_cluster/pdb_seqres.protein.DB mmseqs2_cluster/pdb_seqres.protein.linclust mmseqs2_cluster/pdb_seqres.protein.linclust.DB

MMseqs Output (for bugs)
pdb_seqres.protein.cluster.fasta.gz
pdb_seqres.protein.fasta.gz
The output is compressed by gzip as github does not support .fasta file.
Context
I suspect this is because short sequence has a low alignment score. When you are estimating sequence identity according to alignment score, you will get false negative for short sequence.
Your Environment
Include as many relevant details about the environment you experienced the bug in.

Git commit used (The string after "MMseqs Version:" when you execute MMseqs without any parameters): e3f80a7b0a32b1bc4122b73c045a9dd2f7da42e3
Which MMseqs version was used (Statically-compiled, self-compiled, Homebrew, etc.): statically-compiled SSE4.1
Server specifications (especially CPU support for AVX2/SSE and amount of system memory):
Support SSE but not AVX2. 125G.
Operating system and version:
LSB Version:	:base-4.0-amd64:base-4.0-noarch:core-4.0-amd64:core-4.0-noarch:graphics-4.0-amd64:graphics-4.0-noarch:printing-4.0-amd64:printing-4.0-noarch
Distributor ID:	RedHatEnterpriseServer
Description:	Red Hat Enterprise Linux Server release 6.10 (Santiago)
Release:	6.10
Codename:	Santiago

Here is the full output
mmseqs_cluster.txt

I think this is related to https://github.com/soedinglab/MMseqs2/issues/88
However, I do not think it is inconvenient to demand users to be aware of so many small tweaks. Also, I did not find the '-s' option in linclust. Cleaner solutions include:

mmseqs2 cluster and linclust include subroutine to merge identical sequences before the actual clustering
adjust alignment score - sequence identity calibration for short sequence.
I guess solution 1 is not that hard to implement.

@kad-ecoli thank you for reporting this issues.
Yes, the issues is related to https://github.com/soedinglab/MMseqs2/issues/88. I do not find solution 1. very elegant since we do need more CPU time, IO and hard disk space.
If you do not mind this slight overhead than you could just run clusthash (see https://github.com/soedinglab/MMseqs2/wiki#how-to-redundancy-filter-sequences-with-identical-length-and-100-length-overlap).
I will think about a more elegant solution for this problem.

Thanks for pointing to the clusthash stuff. Of course there is no free lunch in any additional feature. Since clusthash seems to be much faster than even linclust, maybe we can have it as an optional preprocessing step in cluster/linclust workflow.

@kad-ecoli I implemented a solution into linclust, which should not miss same sequences again for nearly zero costs. Could you please try the newest version and see if you still encounter this problem?

The problem seems to still occur if I use the static linux version (AVS). If you just update the github code but not the static linux version, could you rebuild the binaries?

@kad-ecoli Thank you for testing it. The static build should be always up to date. MMseqs2 always reports the commit id. Could you check if its the most recent commit. If yes than could you please provide an example so that I can reproduce your issuse?

MMseqs2 Version: 4eb5e14267f64f2fb337995bd824ef279e04f266
Input file:
pdb_seqres.protein.fasta.gz

Thank you for uploading the example. I have tried your example and it results in two clusters and one clusters.
This call produces two clusters:
 mmseqs createdb pdb_seqres.protein.fasta pdb_seqres.protein
 mmseqs cluster pdb_seqres.protein pdb_seqres.protein_clu tmp --min-seq-id 0.9

This call produces just one cluster:
 mmseqs cluster pdb_seqres.protein pdb_seqres.protein_clu_1.0_v2 tmp --min-seq-id 1.0 --cov-mode 1 -c 0.9

I still have the same issue. The script to reproduce the issue is attached. Is this related to my incorrect invoke of createseqfiledb and/or result2flat?
test_mmseqs2.sh.zip

@kad-ecoli thank you for the script. If I run your script I end up with two clusters, which is expected because of the coverage mode. In default Linclust just clusters sequences with at least 80% bidirectional coverage. The maximum overlap in your example is 65%.
If you want fragments to be clustered you need to add  --cov-mode 1. This turns on the unidirectional coverage. So the short sequence should be 80% covered.
See also https://github.com/soedinglab/MMseqs2/wiki#how-to-set-the-right-alignment-coverage-to-cluster

How do you check there are two clusters? There are far more entries in the resulting fasta file.

The createseqfiledb format contains all sequences. Each cluster starts with an entry that has two fasta headers. The structure of the format is described here https://github.com/soedinglab/MMseqs2/wiki#cluster-fasta-like-format.
Maybe you just want to have the representative sequences?
You can extract the rep sequences with the following commands.
mmseqs result2repseq DB clu clu_rep
mmseqs result2flat DB DB clu_rep clu_rep.fasta --use-fasta-header


Replace the legacy print call in triton.cc with the SlotTracker-based one

The legacy print call will assign names (e.g., %10) to values, which can be undesirable in some cases.

This can resolve #369


Remove unused component reference

Describe the bug A clear and concise description of what the bug is.
I was running the linter and noticed a warning about an unused import in src/routes/+page.svelte. Remove the import Coin from '../lib/Coin.svelte'; import.

The beginnings of the classic Connect Four game.

Welcome to SvelteKit

Visit kit.svelte.dev to read the documentation

	<Board />

Footer © 2022 GitHub, Inc. Footer navigation

To Reproduce Steps to reproduce the behavior:

Run npm run lint
Notice the warning in the console.

/Users/taco/dev/oss/connect-four/src/routes/+page.svelte
  3:9  warning  'Coin' is defined but never used  @typescript-eslint/no-unused-vars

Expected behavior A clear and concise description of what you expected to
happen.
No warning about an unused import
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context Add any other context about the problem here.

Hi @nickytonline, I would like to give this issue a try, if you are so kind to assign it to me. Thanks in advance!

All yours @raykotab!

Thanks! I'll get into it right now!


[SPARK-50063][SQL][CONNECT] Add support for Variant in the Spark Connect Scala client

What changes were proposed in this pull request?
This PR adds support for Variant in the Spark Connect Scala client by adding cases for VariantEncoder in ArrowSerializer.scala and ArrowDeserializer.scala.
Why are the changes needed?

The Spark Connect Scala client does not currently support Variants. This PR enables this support.
Does this PR introduce any user-facing change?

Yes, users using the Spark Connect Scala client will now be able to interact with Variants.
How was this patch tested?

Unit tests to round trip Arrow encoding and decoding of Variants.
Was this patch authored or co-authored using generative AI tooling?

No

@ueshin I have removed the TODO comments and enabled those tests. The SQL E2E tests only seem to test the Deserializer. Do you know of any real use-cases for the Serializer? The tests in ArrowEncoderSuite.scala do test both.

@harshmotw-db let me merge this to master. It is up to you if you want to address the comments in a follow-up.


Enable clang-tidy Objective-C checks

Description
I just discovered that there are clang-tidy Objective-C checks so it seemed wise to enable them.

SFMLBuildMaster: Build this please.


May I ask a question

Do we need to manually build the paths of the dataset in this train.npy file one by one

You may use os package to scan the data folder, e.g., file_list = os.listdir(your_data_path).


feat(aws): bump aws-sdk-go to v1.44.174

Description of your changes
We need to make use of a new RDS DBInstance parameter that is in a later version of the AWS SDK, specifically being able to set CACertificateIdentifier. This pull request bumps aws-sdk-go to version v1.44.174, the version where this parameter was introduced.
I've added all new resources to ignore.resource_names so they can be introduced more carefully, however let me know if this isn't the correct approach.
Also needed to slightly refactor how tagging works in cloudwatchlogs/loggroup/setup.go to work around some deprecation warnings.
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Yet to do any testing, however I'll be running a build locally to test out some resources and ensure things are working as expected.

[x] Run a local build and ensured the following resources that we use were working as expected: S3.Bucket, S3.BucketPolicy, IAM.Role, IAM.Policy, IAM.RolePolicyAttachment, EC2.SecurityGroup, EC2.SecurityGroupRule, RDS.DBSubnetGroup, RDS.DBCluster, RDS.DBClusterParameterGroup, RDS.DBInstance, Kinesis.Stream, DynamoDB.Table,  KMS.Key.
[x] Ensured refactored tagging for CloudwatchLogs.LogGroup is working as expected.

thanks for driving this - overall looks good
lets implement first https://github.com/crossplane-contrib/provider-aws/pull/1689 then we have a check for breaking changes in the crds ;)

@haarchri Sure, let me know when it's merged and I'll rebase

done! @AlexLast  can you rebase ? thanks ;)

@haarchri Have rebased and re run make reviewable test - no changes.
Looks like there are a couple of resources reported by report-breaking-changes, although seems to be some new status fields and some parameters that are no longer required.

thats what i wanted to see ;)


Corrected examples in pluralize template filter docstring and added tests.

Fix pluralize template filter and add some tests.

@timgraham thanks, requested changes done


Check stereo chemie

CDK works fine, error is only using MARVIN

Now, the chemistry works with MARVIN


Fix search experience in notebooks

This PR is for #18472

Check that the findWidget is undefined before handling notebook cell events.
When hitting enter for the next result, the find widget loses focus and we cannot longer go to the next result. Focusing on the findInput, when searching next result fixes the issue.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.28%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
14819

Relevant Lines:
29137

💛  - Coveralls


It is possible for the human to input an illegal move on behalf of the bot, crashing the program.

Reproduction steps:

Make very slow bot
Play "Human Vs Bot"
Make a move
While the bot is thinking, start dragging your pieces around.
The console will say the bot made an illegal move.
Program sometimes crashes?

Is it possible for you to reduce thinking depth / time, same thing happened to me and I reduced the depth and it still performed about as well and was a lot speedier. (Note this will affect end game performance)

Thanks, this is fixed in latest patch (V1.11)


Rigidbody doesn't sleep if can_sleep is subsequently set to false and true

Godot 3.1
Bullet physics
Repro steps:

Create a rigid body in midair and set it to kinematic mode
After a short time, switch it to rigid mode, and at the same time, set its can_sleep property twice like this:

can_sleep = false
can_sleep = true

Watch it fall, and notice it never goes to sleep. I expected it to sleep since it was last allowed to sleep.

Test project: play main scene and watch.
RigidbodyCannotSleepAnymoreIfCanSleepIsSetTwice.zip
Note: I found this behavior by testing workarounds to #28075

Similar issue: https://github.com/godotengine/godot/issues/27715

I can confirm that this was fixed with #27730.

Fixed by #27730.


Proposal: Automatic Cookie download

Description
I like your project and i find it very useful, although a bit tedious to do all the preparations to make it work... So I have thought of a way to automate the cookie retrieval, instead of relying on the user doing it manually.
It could possibly reduce the number of errors like #7 and #44
Explanation
I have found this interesting answer on StackExchange where it proposes to use Javascript to convert cookie and it says it's compatible with youtube-dl...
We could use this to our advantage by using Selenium Webdriver's .execute_script().
I haven't tested yet but it could be something like this (i changed only a bit the answer above)...
with open("cookie.txt", "w") as cookie_file:
        cookie_file.write(d.execute_script("""
                /* *******************************************************************
                        Source: https://apple.stackexchange.com/a/425700/429715
                ******************************************************************* */
                (function() {
                  let S = '# Netscape HTTP Cookie File\n';
                  for (raw_cookie of document.cookie.split(';')) {
                    let cookie = raw_cookie.trim();
                    let separator = cookie.indexOf('=');
                    let name = cookie.substring(0, separator);
                    let value = cookie.substring(separator + 1);

                    let domain = window.location.hostname;
                    // hopefully this will convert domains like `www.test.com` and `test.com` into `.test.com`
                    domain = domain.replace('www.', '.');
                    if (domain[0] !== '.') {
                        domain = '.' + domain;
                    }

                    // netscape cookie file format:
                    // # domain  HTTP PATH SECURE timestamp name  value
                    // .test.com TRUE /    FALSE  123456789 token 1234abcdef
                    S += `${domain}\tTRUE\t/\tTRUE\t0\t${name}\t${value}\n`
                  }

                  return S
                })();
        """))

What do you think?
If you're interested and i find the time i could try and make a PR for you (if i make it work 😄)

Oh, no
Another ck.getcookiestxt.com.

Oh, no
Another ck.getcookiestxt.com.

What do you mean?


[Question, Feature Request] Output, how many items in a playlist, series, season, show, or ... etc?

It would be nice to have a "simulate" or otherwise output command to display how many items are in [your current] URL. And if there is a fairly simple solution available I'd love to hear it. I'm primarily using PowerShell (believe it or not) for my youtube-dl scripts atm. Despite how awkward it is to use in some areas (I'm looking at YOU -- passing in arguments!) I am finding it quite powerful in it's own right but I'd love to be able to either find out how many items are in a playlist, series, or season or have youtube-dl reauth to vrv after some arbitrary time.
VRV seems to be very particular and will straight up deauth after some amount of time so I just write a script that re-runs youtube-dl with authentication after some amount of runs using a manual --playlist-items $Min-Max  or something like --playlist-items 1-61,123-196,271-341,413-1086
I will close this issue regardless of if I get help as most of the issues are incredibly verbose and not worth posting on the GitHub so thank you in advance.
Feel free to delete this issue or send me to some support forum instead.

Also if there is an easy way to check if the show has seasons or not it would be a great help for automated scripts I'm writing.

--dump-single-json --flat-playlist. Count number of entries.


Kl add todos to db

@cpirich are the migrations automatically run on the production db via a GitHub action, or do we need to run those manually prior to merging this to main?


Add '-o name' to mutations

Implement -o name (short output mode) for mutations*, and make default output more verbose. Fixes #5906
For example,
// Create a pod and CLI prints pods "xxx" created by default
kubectl create -f pod.yaml
// Create a pod and CLI only prints pods/xxx
kubectl create -f pod.yaml -o name
*Affected mutations include create, delete, stop, replace, patch, scale. Other mutations (label, run, expose, rollingupdate) use -o flag for output format and print the object like get does and therefore will be changed later.

@bgrant0607 @smarterclayton @andronat

cc @jlowdermilk @deads2k

In general, I think you should be have a RESTMapping for each resource. Use strings.ToLower(info.Mapping.Kind) rather than info.Mapping.

I think the distinction between resource and kind is important to us even if it isn't obvious to users and I'm pretty sure these should be resources.  The Kind describes the type and the Resource describes how you're using it.  As an example, pods/status takes a Pod kind and it's pretty common for subresources to deal in kinds that overlap with other resources.  We use resources on the cli tool to be certain that we can unambiguously determine intent in all cases except create -f.

I should also add, I like the idea make the resource in "resource/name" singular.  We don't have a singularlizer, but here's how we pluralize: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/api/meta/restmapper.go#L126

Restmapper should have a method to expose that.
Also, that "status" hack is ugly and probably shouldn't be there.  If you
need to define rules like that it should be explicit in the registration.
On Jul 2, 2015, at 7:58 AM, David Eads<EMAIL_ADDRESS>wrote:
I should also add, I like the idea make the resource in "resource/name"
singular. We don't have a singularlizer, but here's how we pluralize:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/api/meta/restmapper.go#L126
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/10652#issuecomment-118009588
.

Thanks for the feedback. Commit has been updated accordingly. Decisions include:

Keep -o name and change default printout to resource (singular) "name" operation (remove the message "successfully"), e.g., pod "nginx" created.
Keep info.Mapping.Resource and create ResourceSingularlizer() in RESTMapper to singularize resource name.

PTAL

LGTM, @smarterclayton, @deads2k may have more comments.

nits.  lgtm.

I changed ResourceSingularizer() to be a method on the interface RESTMapper. When rest mapper pluralize resources, it'll save the mapping between plural and singular of each resource so we can simply look up the map to singularize resources.

One last change and the LGTM - add test for singularize to RESTMapper package

Added TestRESTMapperResourceSingularizer(). PTAL

@k8s-bot test this please

@k8s-bot test this please

Please rebase

Code rebased.

I think this is ready for merge, then. If we need any changes, they can be done in follow-up PRs.
We'll need to update lots of docs.


Expose HttpStatus.forStatus to Java

Hello,
I'm working on a Java project and noticed the HttpStatus.forStatus method is missing. I added the @JvmStatic so the method is available in Java.

Thank you @Knorrke - while you wait for the release you can reach it through HttpStatus.INSTANCE.forStatus()

Thank you @Knorrke - while you wait for the release you can reach it through HttpStatus.INSTANCE.forStatus()

Thanks for the quick merge. I just tried your recommendation, but it doesn't seem to compile. But for now I just iterate over HttpStatus.values() and look for the matching HttpStatus myself. That will do until the next release :)

Just in case - you can also use snapshot build that already has this change applied :)