BasicAuth: middleware versus entire_site_protected

Problem
The documented SS_USE_BASIC_AUTH doesn't have any effect as of 4.0.0-beta2.
Users can still apply this with the config property SilverStripe\Security\BasicAuth.entire_site_protected: true, and users can still hole punch this when it's enabled, for specific controllers by calling $this->disableBasicAuth() from a controller's init method.
Options

Replace the use of the config property and controller coupling to it with a BasicAuthenticationMiddleware which can be applied to Director (note that there's a BasicAuthenticationHandler references in the docs of the AuthenticationHandler interface, but it hasn't been implemented)
Re-implement the check for SS_USE_BASIC_AUTH in CoreKernel (replacement for ConfigureFromEnv.php?) and leave the BasicAuth config property and supporting methods in place
Do both (fix existing functionality and add a middleware, but don't remove config properties)

A middleware for basic authentication would be nice because as noted it would remove some coupling with other parts of the framework and BasicAuth. It would also allow us to remove the basic authentication handler from the GraphQL module, since a basic auth middleware could be applied for GraphQL's controller to provide the member context. Currently it would still require an implementation of this to make this achievable with middleware in the GraphQL module. This is noted here.
If the hole punching for certain controllers is still desired (I can imagine some scenarios where it would be useful) then it could perhaps be re-implemented as a config array on the middleware which allows certain regex URL patterns to pass through it unauthenticated. It wouldn't be a direct replacement for the existing behaviour, but since the Director middlewares are outside of a controller context I don't know that a direct replacement could be achieved without making all controllers middleware aware.
I suppose that the environment variable support should be retained as well - especially useful to enable basic auth for test sites without having to modify the code. Does the config YAML syntax support "if env var is defined" conditions like it does constants?

Adding this to the beta4 milestone, since this is security related and potentially exposes confidential information (e.g. UAT sites).

My preference would be restoring the old behaviour to save implementation time, I really don't want this to become a big refactor fest of BasicAuth and middleware. Agreed it'd be good to have, but we can't change APIs at this point, so the "baseline" is restoring behaviour for SS_USE_BASIC_AUTH. Please leave any basic auth middleware as an opt-in we can tackle in 4.1 or later.

Fix at https://github.com/silverstripe/silverstripe-framework/pull/7414. I didn't want to spend a lot of time so I implemented a simple fix.

Awesome


⚠ Bofrost.lu has degraded performance

In f503119, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1772 ms

Resolved: Bofrost.lu performance has improved in 0556652 after 6 minutes.


util: Refactor quilt-tester to use util.WaitFor

This generalizes the waitFor() function from quilt-tester/exec
to accept an arbitrary timeout and migrates it to the util package
so that other packages can make use of it.

Current coverage is 53.73% (diff: 100%)

Merging #693 into master will increase coverage by 0.03%

@@             master       #693   diff @@
==========================================
  Files            82         82
  Lines          7133       7143    +10
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           3830       3838     +8
- Misses         2992       2994     +2
  Partials        311        311

Powered by Codecov. Last update 43308ff...e848f85

@ejj changed.

LGTM will merge once CI passes


Mappable, Array<Mappable, and Set initializers and toJSON

Thanks again for the great framework! Because of the nature of the changes, I included a pretty lengthy discussion here. Since this mostly reflects my design ideas and not substantial functionality improvement, feel free to reject this PR if it doesn't fit your goals, but I thought making this available to you was the least I could do to say thanks. :) I don't offhand know why this can't be automatically merged if you accept though. I don't think I made any hard-to-merge changes.
Mappable Extensions
Purpose
This PR incorporates the init and toJSON additions to Mappable, Array<Mappable>, and Set<Mappable> that I implemented for a recent project. I believe this interface is a bit more Swifty than the current interface and allows better encapsulation of the ObjectMapper framework.
Changes
By using protocol extensions, I added failable initializers and a toJSON() for Mappable, Array<Mappable>, and Set<Mappable>. At a high level, these changes allow for the following use cases.
class MyMappable : Mappable, Hashable { ... }

let myMappable = MyMappable(JSONString: aJSONString)
let myMappable = MyMappable(JSON: aJSONDictionary)

let myArray = [MyMappable](JSONString: aJSONArrayString)
let myArray = [MyMappable](JSONArray: aJSONDictionaryArray)

let mySet = Set<MyMappable>(JSONString: aJSONArrayString)
let myset = Set<MyMappable>(JSONArray: aJSONDictionaryArray)

let myMappableJSON = myMappable?.toJSON()
let myArrayJSON = myArray?.toJSON()
let mySetJSON = mySet?.toJSON()

Discussion
As I have been working on this project, I have found that ObjectMapper has made writing my JSON-based API client so much easier. However, the framework dependency had to be spread to a few places that I would prefer it didn't. This was mostly the API client classes as well as the model-testing classes. Since all my JSON-mapped model objects already had to include the framework to implement Mappable, this seemed like the ideal place to encapsulate all the framework knowledge. By removing these dependencies and localizing the knowledge to the model objects, changing mapping libraries or even serialization methodology in the future should be easier to accomplish. This functionality could be further abstracted into protocols (e.g. JSONConvertible) to make testability in the API client easier, though I didn't take it that far.
In addition, since Swift added failable initializers, the Apple frameworks have moved more towards this pattern instead of the factory pattern that has been prevalent. It seemed like a nice idea to implement this pattern for ObjectMapper as well for stylistic reasons. This was made quite a bit easier with protocol extensions.
Caveats
I made the decision to not implement initializers that take AnyObject? arguments. While this might make sense for the calls to Mapper given the context, it seemed a bit misleading to provide such a vaguely typed initializer by default since there's a relatively small subset of the AnyObject? type that could successfully initialize an object. It also seemed to be fighting the type system a bit. I think a better solution is to leave that type check in the code that is initializing the Mappable where checking for having the right type to initialize is maybe more appropriate.
I was not able to extend this philosophy to Dictionary<String, AnyObject>. This was primarily due to the current limitation of not being able to conditionally extend protocols with non-protocol type requirements. There could be a way around this, but it escaped me.
I would also prefer to include the new initializers in the Mappable protocol as well so that implementers could chose to override the default functionality. However, I couldn't figure out how to do that without adding a bunch of required inits. Again, there could be a way around this. Also, if this functionality was refactored out into a JSONConvertible protocol, that would largely alleviate this concern. However, with current limitations of protocol extensions, you'd then run into the problem of not being able to do something like:
extension Array : JSONConvertible where Element : JSONConvertible { ... }

Testing
Tests are included to provide 100% coverage of the new extensions.

Hi @scottrhoyt, thanks a lot for the PR and the in depth discussion. Sorry about the slow response.
I quite like your idea to extend the Mappable protocol to include init functions! I am currently in the midst of making some tweaks to your branch and will soon merge it into master.
Thanks a lot :+1:

No problem! Let me know if you'd like any help.

@tristanhimmelman I was wondering if you had given more thought to this change?

Hey @scottrhoyt, yes I have actually. I think I will merge it very soon. PR https://github.com/Hearst-DD/ObjectMapper/pull/328 includes your changes and is up to date with master. My only real concern is that unfortunately Xcode doesn't seem smart enough to provide code completion suggestions for the Mappable extension. If it weren't for that I would have merge this a while back....

Awesome. Yeah, I've run into similar Xcode issues. Let me know if there is any way I can help!


Batch create transactions: Submit import

We're going to simplify the approach and describe the submit mechanism in https://github.com/opencollective/opencollective/issues/7432


Recursive extraction fails when file type is misidentified

Running binwalk -eM on this file (after unzipping) extracts a lot of .crt files, which Binwalk believes to be certificates (despite some are several megabytes), but it does not go on to extract those. They have to be manually extracted by invoking binwalk again.

Binwalk doesn't know how big the certificate files are, so it just copies out everything from the beginning of the cert to the end of the file. During recursive extraction this can cause problems, since binwalk would extract a bunch of data from the original file, then end up re-scanning it, extracting it again, re-scanning it, extracting it again, etc; hence binwalk refused to extract them when running recursively. In fact, the latest version of binwalk doesn't extract certificate files under any circumstances, since it's easy enough to dd them out if you really want them: https://github.com/devttys0/binwalk/blob/master/src/binwalk/config/extract.conf#L89
With that said, I don't think these file types are being mis-identified. At least the first few certificate results that binwalk reported look like legitimate certificate files.

So all the extra files extracted from those .crt files are just duplicates of what's in the original file?
I wonder if it's possible to determine their size by looking at nearby words that might be a size, extracting that much, and checking if the result is a valid certificate (or other type of file) without any extra junk at the end.


Find better solution for Team_Data data load

and consumption
at the moment there is a notify and subscribe workflow which works but it is not optional (and makes the code much more complex than it should be)

This should be fixed with a solution equivalent to the one used on projects #207

refactoring done (see team_Data and team_Mappings)


Migrate from deprecated pedantic to flutter_lints

Description
Migrated all packages from deprecated pedantic to flutter_lints.
Add a dev_dependency on package: flutter_lints to all project’s pubspec.yaml
Since the project already had a custom analysis_options.yaml file at its root, I added include: package:flutter_lints/flutter.yaml to it at the top
Related Issues
closes #471
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Can you please merge with main thanks

I have resolved the conflicts to merge with main.

On some packages, you removed the sdk flutter from the integration_test dependency.
It is for this reason that the build fails
Need to specify the sdk flutter
  integration_test:
      sdk: flutter

Hey @NatsuOnFire, Thank you for pointing that out. I have added
  integration_test:
      sdk: flutter

to all files, it was removed from. Please @mhadaily if you could review the changes again.
Also, wanted to ask about this one file:

I haven't made any changes to it. Might be due to some new merge. Do I need to do something about it? If so, Could you help me with it?

I haven't made any changes to it. Might be due to some new merge. Do I need to do something about it? If so, Could you help me with it?

Please merge the main branch and update the PR.
Thanks!

Updated @Elias8. Let me know if it is okay now. Thanks!

@mhadaily Did you see that some updated package versions are reverted to an older version? Did you pass intentionally?

@Elias8 what do you mean?

I'll close this and redo this taking care of the changes.

thanks, @adityathakurxd  looking forward to it


Backport disabling the configuration cache on TAPI model building

Original issue at https://github.com/gradle/gradle/issues/15044
Fix for 7.0 at https://github.com/gradle/gradle/pull/15422

Backported in https://github.com/gradle/gradle/pull/16836


feat: add silent flag

I have implemented a feature that adds support for the --silent flag that suppresses non-critical messages (i.e. warnings and errors are still surfaced)
I have decided to add two abstractions to implement this.

getCliOptions is a helper which is responsible for parsing different CLI options. Currently, it supports only the silent flag and the external assets flag. When we decide to add new flags, this abstraction might make it easier for us. It also brings a small utility library which takes care of parsing the CLI arguments and all the different edge cases of that.

getLogger is an abstraction for console.* functions that encapsulate some code (currently, only the silencing logic).  This allows us to replace console.* with logger.* in majority of the places and be done with it. We could potentially extend the logic further in case some other requirements surface up later.

Tell me what you think about it and whether there are any alternatives solution which you have thought about.

Nicely done!
Thank you very much!
I'm granding you write privilege on the repo: https://github.com/InseeFrLab/keycloakify/invitations

@all-contributors please add @Tasyp for tests and code

@all-contributors please add @Tasyp for tests and code

@all-contributors please add @Tasyp for tests and code


Made fully cost iteration not go through a Map structure.

Additionally minor refactoring of analyze_gas_statements.

Stack:

#6618
#6634 ⬅

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is


Increase tests coverage for tasks itself

The RKD core is mostly covered with tests, the standardlib and rkd_python is not that much.
We need to write more unit and functional tests.

Less work could be after https://github.com/riotkit-org/riotkit-do/issues/24 will be done


People titles font too large on desktop

I think this has something to do how the browser interprets element style.
This is how the actual wikipedia page for "James Prescott Joule" looks like

Note that just from the HTML and by inheritance, the titles SHOULD have "font-size:100", but Wikipedia's website doesn't recognize this as a valid style assignment, therefore it uses the style assignment from the parent element (77%)
This doesn't seem to be the case for our website, as "font-size:100" is valid, likely read as 100px.

Is this an issue with CSS/HTML versions? or is there anything else causing this


High vulnerabilities in keda 1.5 docker image

Our Sysdig enterprise image scan is picking up 36 vulnerabilities. Is it possible to scan and fix them before releasing an image? This can help enterprise adoption of KEDA
Some highlight
RHSA-2020:2637
RHSA-2020:0271
RHSA-2020:0273
RHSA-2020:0575
RHSA-2020:2755

KEDA Version:1.5.0

I'll take this up, sorry about that.
See #1040, #1041 & https://github.com/kedacore/charts/issues/64

@zroubalik @ahmelsayed We should include this in 2.0 and maybe ship 1.5.1 for this.

agree 2.0 should include this for sure

These should be mitigated in v2.0, can you have a look please?

Closing due to no response


Unable to use the plugin

Hello everyone,
I am trying to use your plugin to generate an API Reference that fit in docusaurus.
So, I've followed the README Installation and Usage guide but I can't figure out how to run the plugin.
I've done
npm install --save-dev typedoc typedoc-plugin-markdow
and then in my package.json
"build:doc": "typedoc --module commonjs --plugin typedoc-plugin-markdown src"
npm run build:doc
This didn't work, so i tried, as you suggest
npx typedoc --module commonjs --plugin typedoc-plugin-mardown src
But both times i got the same result :
Error: "typedoc-plugin-markdown" needs to be executed from the same location as "typedoc". Please make sure to run "npx typedoc" or alternatively install the plugin globally.
Does someone have a solution ?
typedoc version : 0.14.0
typedoc-plugin-mardown version: 2.2.7
node version: 11.10.0
npm version: 6.11.3

Do you have monorepo with multiple package.json or a single package.json?

I tryed on both, same result

Can you please try?
node_modules/.bin/typedoc --module commonjs --plugin typedoc-plugin-markdown src

I've tried that too :/
$> node_modules/.bin/typedoc --module commonjs --plugin typedoc-plugin-markdown --out docs src
Loaded plugin typedoc-plugin-markdown

Using TypeScript 3.2.4 from /Users/jbourdale/NODATA/test/node_modules/typedoc/node_modules/typescript/lib
Error: "typedoc-plugin-markdown" needs to be executed from the same location as "typedoc".
Please make sure to run "npx typedoc" or alternatively install the plugin globally.

Strange i can't reproduce this. I don't suppose you would be able to share an example repo with this behaviour?

https://github.com/jbourdale/tsdoc-plugin-markdown-fail

Thanks for that. Could you set the version typedoc-plugin-markdown to 2.2.9 and try again please. I have removed the dependancy on Handlebars and it seems to fix the issue. Why it was only causing issue on this repo I am not too sure about though..

Awesome, it works.
Thx for the reactivity!!

We're suffering from exactly the same issue. We tried to downgrade to 2.2.9 but it did not solve the problem. We tested it on 2 local environments and both are returning the same error message. I guess the path, which is being checked in the condition (/src/theme.js) is null in our case.
@tom-grey do you have some idea what could be a cause of the issue even after downgrading to 2.2.9?

@rmakara I just faced the same issue. I tried downgrading TypeDoc to the version used by @jbourdale (0.14.0) and it works fine. I think the plugin doesn't seem to be working with the current version of TypeDoc (0.15.3).
@tom-grey any idea on what's throwing this error?

@rmakara @arjunbalgovind  Thanks for the comments. I will re-open this. The cause is an issue with multiple handlebars instances being registered when the plugin assumes a global instance (a design flaw in this plugin). Most likely a local version of Handlebars has been installed which is a different version than typedoc. I will look at a fix for this scenario.

@rmakara @arjunbalgovind  please try 2.2.13 ...

@tom-grey it works! Thank you for awesome, very quick fix.  Thanks for the great fix! I realized that there were some changes in TypeDoc 0.15.x that I really needed, so this is great :D


Check waste incineration emissions

Waste to energy is not showing up as much as would be expected in solid waste totals. It also seems like the incineration script is resulting in the same values for n2o and co2. Check why this is and make sure all calculations are functioning correctly.

The issue came from mislabeling the emissions factors for incineration as "WTE" instead of "Waste to energy", resulting in the values being empty after merging. Corrected.


Still get C1010 "unexpected EOF looking for precompiled header", even with it turned off.

It's like all VS wants me to do is suffer
I've turned it off on the entire project by right clicking on it in the solution explorer.
I've manually disabled precompiled headers for every single file
I've even tried a blank solution, which won't give an error, but refuses to compile into a DLL, even after I change both the output type and the output extension, yet it throws out an EXE.
I literally have no idea what happened, it was working fine a few months ago, now on my new project it just decides to quit on everything

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7710ea05-1307-eaaf-3ba0-86175eeaf184
Version Independent ID: 30568a08-383b-1676-dfb3-e1dc6f28f38c
Content: Fatal Error C1010
Content Source: docs/error-messages/compiler-errors-1/fatal-error-c1010.md
Product: visual-cpp
Technology: cpp-diagnostics
GitHub Login: @corob-msft
Microsoft Alias: corob

@TacticalBFG
Sorry you're having issues. Turning off precompiled headers in an existing project can be complex. I've updated the procedure for that in the article, which should appear in a day or two. Here's the new procedure:
To turn off precompiled header use in a project, follow these steps:

In the Solution Explorer window, right-click the project name, and then choose Properties to open the project Property Pages dialog.

In the Configuration drop-down, select All Configurations.

Select the Configuration properties > C/C++ > Precompiled Headers property page.

In the property list, select the drop-down for the Precompiled Header property, and then choose Not Using Precompiled Headers. Choose OK to save your changes.

In the Solution Explorer window, right-click the pch.cpp source file in your project. (In older projects, the file may be named stdafx.cpp.) Choose Exclude from Project to remove it from the build.

Use the Build > Clean solution menu command for each configuration you build, to delete any project_name.pch files in your intermediate build directories.

I think the part about making changes for all configurations could be one of the problems you ran into. Hopefully this procedure will address your issue.


Client error '403 Forbidden'

Since the last update been getting a 403 to the camera. Have confirmed the password is correct
21/11/2022 17:36:06 [INFO] App Version: 1.0.16
21/11/2022 17:36:06 [INFO] Fetching camera details...
21/11/2022 17:36:13 [INFO] Device type: AD110
21/11/2022 17:36:13 [INFO] Serial number: Z0568E8DDEB79
21/11/2022 17:36:13 [INFO] Software version: 1.000.00AC008.2.R (2022-09-07)
21/11/2022 17:36:13 [INFO] Device name: Front Door
21/11/2022 17:36:13 [INFO] Writing Home Assistant discovery config...
21/11/2022 17:36:13 [INFO] Fetching storage sensors...
21/11/2022 17:36:14 [INFO] Listening for events...
21/11/2022 17:36:16 [ERROR] Amcrest error: Client error '403 Forbidden' for url 'http://X.X.X.X/cgi-bin/eventManager.cgi?action=attach&codes=[All]'

Same....I've been trying to figure out who to roll back the firmware

Instructions here https://support.amcrest.com/hc/en-us/articles/4415484574349-How-to-Upgrade-Firmware-Using-the-Amcrest-IP-Config-Tool-ASH26-

Did the IP config tool work?  I'm just getting login errors when attempting to connect via IP.  I just reset my password on the camera again so I'm sure I can't be putting in the wrong password.

It worked for me - you need to open the settings window every time and put in the IP, user and password - it doesn't save it.

It worked for me - you need to open the settings window every time and put in the IP, user and password - it doesn't save it.

Also have this issue. I wonder if this is resolvable or if we're stuck with having to roll back to older firmware forever now?

same issue here, doorbell is useless currently ... anyone have a fix ?
Can't login to the doorbell using IP config tool either

I was able to roll back the firmware on the doorbell and fix as posted above.  I had to reset my admin password to something shorter, I think the IP Config tool didn't like my long secure password for some reason.

wow, indeed it seems to not work with passwords using symbols ..
THANKS !


Store File with file_path

This will allow us to perform some logic based on the product of an xcode_target.

This changes how they hashed. Was easier to just compare file_paths instead.


[Feature Request] Turbo Controller: separate On/Off toggle for Left/Right cross hotbars

Is your feature request related to a problem? Please describe.
There are times when Turbo Controller is not desirable, i.e: Ninja's mudra and Dancer's step inputs.
Describe the solution you'd like
I think having separate toggles for Left/Right cross hotbars would solve that problem.
(Or perhaps more generally, a button to temporarily disable Turbo when held, which could be LT/RT)
Describe alternatives you've considered
I'm using reWASD for its turbo feature, but it would be nice to have it built into the game so that it will be available for any controller, not just the ones I have set up.
Additional context
Simply something similar to this checkbox in the Quick Gather would work great.

Not really feasible. Turbo feature is polling hardware signals and not your hotbars.


[BUG] Impossible to make the map command on a stage channel

Describe the bug
An error occurs when we try to run the sudo map command on a stage channel.
To Reproduce
Steps to reproduce the behaviour:

Execute the command sudo map [0/1] {stageChannelId} {textChannelId}.
Bot response: Error processing command - specified channel ID does not belong to a voice channel

Expected behaviour
I wanted to link the stage channel with a text channel, as it is already possible to do automatically without the command.
Screenshots

Hi @BenNotix
v13 upgrade is currently being deployed.
Fix for this should be available for you in few minutes.
Beware that commands were overhauled, so there's no interaction with the bot via messages anymore - within 1 hour there should be slash commands available for the bot on every server.
Have a great day!


The pods on Kubernetes cannot access the pod IP addresses on other's nodes.

When I deploy Calico in Kubernetes, the cluster network works fine when I use the ipip mode. However, when I use the vxlan network, some pods on certain nodes cannot ping each other. I want to know ,what problem with me???
when i use  calico vxlan mode
server A pod A ping serverA pod B's ip  ok
server A pod A  ping serverB pod B's  ip  fault
when i use  calico ipip mode
server A pod A ping serverA pod B's ip  ok
server A pod A  ping serverB pod B 's ip  ok

What Kernel and OS are you running?
This sounds like you may be running into https://docs.rke2.io/known_issues#calico-with-vxlan-encapsulation
Can try an quick fix via https://github.com/rancher/rke2/issues/1541#issuecomment-895297008

@opencmit2 please fill in the issue template fully so we can understand your cluster better.


Experiment with a true slice type

Related issue(s)

Resolves #606 and #562
Description
Summary of changes
Currently slices in noir are not "true" slices. Instead, something like fn foo(a: [Field], b: [Field]) -> [Field] is sugar for fn foo<A, B, C>(a: [Field; A], b: [Field; B]) -> [Field; C].
This has been known to cause issues when these slices are used as return types. The compiler can later infer the correct lengths of these arrays (e.g. inferring A == C), although this may fail if these functions are inferred in an incorrect order. See #562.
This PR does away with this desugaring entirely and implements true slices without associated lengths into noir.
Currently this is a draft, the changes to the type system are finished but changes are still needed to the ssa form. Specifically, we will need the ability to reason about arrays of unknown length within a function until it can be later inlined and the concrete length becomes known. Changes are also needed to delay evaluation of std::array::len since it will no longer always be known during monomorphisation.
Checklist

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt with default settings.
[ ] I have linked this PR to the issue(s) that it resolves.
[ ] I have reviewed the changes on GitHub, line by line.
[ ] I have ensured all changes are covered in the description.

Alternatives
Possible alternatives:

Disallow slices entirely and force users to use explicit lengths everywhere. This is likely the easiest approach development wise but is the most restrictive to users.
Build a call graph during name resolution and use this ordering to guide the type checker on the correct order to type check functions. This would fix the issues with the current desugaring of slices within functions, although we would still have to disallow storing slices within structs.

Can you elaborate on why the explicit lengths will be restrictive for users -- I believe we wrote notes about this somewhere.
Also why can't allowing explicit lengths just be an Array and Slices be Arrays without explicit lengths, but the lengths are still compile time know -- This would then be different to a Vector whose length would not be known at compile time.

Can you elaborate on why the explicit lengths will be restrictive for users -- I believe we wrote notes about this somewhere.

Explicit length arrays are a bit more restrictive than slices most notably when operating with several arrays/slices of different lengths:
fn foo(array1: [Field; 2], array2: [Field; 3], slice1: [Field], slice2: [Field]) {
    array1 == array2 // error: arrays are of different lengths
    slice1 == slice2 // ok

    let multi_dimensional1 = [array1, array2] // error: element type expected to be [Field; 2] but the second element is of type [Field; 3]
    let multi_dimensional2 = [slice1, slice2] // ok
}

The ability for multi-dimensional arrays/slices to store slices of differing lengths is itself useful.
Another usecase for "slices" is actually the ability to merge them with Vecs in noir since their lengths are dynamic we could allow push, pop, or even push_front, pop_front, etc. I'll assert that since this has no runtime cost there is no reason to have separate slice and Vec types in noir at all. I'm assuming once we implement push and friends we can rename slices to Vecs but naming discussions can wait of course.

Also why can't allowing explicit lengths just be an Array and Slices be Arrays without explicit lengths, but the lengths are still compile time know -- This would then be different to a Vector whose length would not be known at compile time.

That is the system we have currently where the lengths are known at compile-time but users do not have to write them. It effectively makes slices sugar for arrays and subject to similar restrictions as them. The restrictions are actually even tighter since to know the lengths at compile-time we need to infer the lengths which makes e.g. representing structs containing slices more difficult since we'd need to implicitly add the generic length to the struct's generics and keep it hidden from users. Doing this though, means it'd be possible for users to get an error that MyStruct<T> != MyStruct<T> if both contain slices of different lengths since they'd actually be MyStruct<T, N> and MyStruct<T, M>. You can see how this would be confusing, especially if we keep these lengths hidden.
Since we'd be creating and inferring these extra generic lengths ourselves, this also leads  to issue #562 where to do it correctly for functions we'd need to infer them in the correct order (starting from the leaves of the call graph).


make OpenFOAMProject::print_operations also print generate and execute

fixes #153
The output will now be:
[operations.py:34]	  INFO: Available operations are:
	apply
	archive
	blockMesh
	checkMesh
	controlDict
	decomposePar
	execute
	fetchCase
	fvSchemes
	fvSolution
	generate
	initialConditions
	refineMesh
	runParallelSolver
	runSerialSolver
	setKeyValuePair
	shell
	transportProperties
	turbulenceProperties
	```
Note, that `execute` was also missing from the list of available operations.

Can this be merged @greole, or do you have anything to add?


CSS file not loading Core 3.0

After upgrading my project to the release of Core 3.0 the css file no longer loads and just returns an empty page.
I was able to reproduce this on the demo project in the repo just by upgrading it to core 3.0. I had to comment out
     app.UseMvc(routes =>
            {
                routes.MapRoute(
                    name: "default",
                    template: "{controller=Home}/{action=Index}/{id?}");
            });

to run the project.
EDIT:
setting  o.ConfigureKestrel(options => options.AllowSynchronousIO = true);
fixes the issue, but i am guessing is not a good solution

also for me the same problem, it is not loaded the stylesheet!
ho provato anche ad aggiungere:
o.ConfigureKestrel(options => options.AllowSynchronousIO = true);
ma niente ...!
immagine

To be more precises for 3.0, replace in Program.cs .
public static IHostBuilder CreateHostBuilder(string[] args) =>
Host.CreateDefaultBuilder(args)
.UseServiceProviderFactory(new AutofacServiceProviderFactory())
.ConfigureWebHostDefaults(webBuilder =>
{
webBuilder.UseStartup()
.ConfigureKestrel(options =>
{
options.AllowSynchronousIO = true;
});
});

same result! The style sheet is not loaded.

Hi!
Same problem! Any solution?

ref #48
please merge!

I found this problem wasn't solved by the keerthiraja1988's code snippet when using IIS with the .net core 3 hosting bundle as kestrel doesn't seem to be relevant. Instead this similar snippet worked for me in ConfigureServices in startup.cs
            services.Configure<IISServerOptions>(options =>             {                 options.AllowSynchronousIO = true;             });
Hope this helps someone

I found this problem wasn't solved by the keerthiraja1988's code snippet when using IIS with the .net core 3 hosting bundle as kestrel doesn't seem to be relevant. Instead this similar snippet worked for me in ConfigureServices in startup.cs
 services.Configure<IISServerOptions>(options => { options.AllowSynchronousIO = true; });
Hope this helps someone

TOP !

another solution avoiding change the AllowSynchronousIO option is to intercept the stylesheet call and serve the static css file.
in startup, in configure method use this (instead of simply app.UseElmah()):
 app.MapWhen(context => context.Request.Path.StartsWithSegments("/elmah", StringComparison.OrdinalIgnoreCase), appBuilder =>             {                 appBuilder.UseMiddleware<MyMiddleware>();                 appBuilder.UseElmah();             });
MyMiddleware is this:
`public class MyMiddleware
{
private readonly RequestDelegate _next;
        public MyMiddleware(RequestDelegate next)
        {
            _next = next;
        }

        public async Task Invoke(HttpContext context)
        {
            if (context.Request.Path.HasValue && context.Request.Path.Value == @"/elmah/stylesheet")
            {
                context.Response.Redirect("/css/elmah.min.css");
            }
            else
            {
                // Call the next delegate/middleware in the pipeline
                await _next(context);
            }
        }
    }`

where the path for redirect depend on where you put the static css file.
you can take the static css file using the two file Bootstrap.css and ErrorLog.css that you can find in this repository in ElmahCore/ElmahCore.mvc


add build local-disk-action-controller in e2e test

What this PR does / why we need it:
add build local-disk-action-controller in e2e test
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Codecov Report

Merging #1123 (fc11ab1) into main (39ce353) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   39.39%   39.39%
=======================================
  Files          25       25
  Lines        1942     1942
=======================================
  Hits          765      765
  Misses       1075     1075
  Partials      102      102

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[WIP] Spawn nodes for cluster

Adds commands to bring cluster nodes up and down, list running nodes and run kubeadm

/cc @alban @nhlfr

Can we close this PR?

I was still waiting on feedback from you and @alban
If you are alright with it I would like to merge this because it closes at least 2 issues

I could still split it into 3 commits like you suggest. But if I remember correctly I had some issues with the renaming of cmd/kubeadm-systemd/kubeadm-systemd  to *-nspawn


Querying the open ledger

We should look into storing the open ledger in Redis, or something similar.
Or maybe each clio server can keep it's own cache.

It's not clear if this is needed. We need to go through the use cases and see when the open ledger is actually needed.

We have proxying for this. We only receive validated/closed ledgers so seems like proxying is the solution as clio was not really meant to be used on live data. Closing.


Consumer Retry Logic

Retrying delivery of unconfirmed messages from the KafkaConsumerActor is currently configurable via a delay.  It would be good to be able to limit the number of retries as once the session has timed out it probably does not make sense to continue to redeliver indefinitely.

Fixed in https://github.com/cakesolutions/scala-kafka-client/pull/67


Windows Terminal minimizes on launch if set as default terminal application

Windows Terminal version (or Windows build number)
10.0.21390.1 1.9.1523.0
Other Software
No response
Steps to reproduce

Set Windows Terminal as the default terminal application
Start Command Prompt or Powershell

Expected Behavior
Launch Windows Terminal with the window in focus
Actual Behavior
Windows Terminal starts and minimizes but if an instance is already running, works as expected

This could be #10292 or #10386

Thanks! Yeah, this is a /duplicate of #10386


How to set footer by function “SetHeaderFooter”，How to use this method, I tried but failed to achieve the desired effect

I set the footer, but the page number is reversed.

What effect did you expected, what did you do and which version of Excelize are you using? Could you create the issue by an issue template and provides more detail?


MSI: add WindowWalker module

Summary of the Pull Request
add missing files to the MSI

PR Checklist

[x] Applies to #1627
[x] CLA signed. If not, go over here and sign the CLA

Validation Steps Performed

installed MSI and verified that it works

Let's also add WindowWalker.exe and WindowWalker.dll to the list of binaries to be signed in
https://github.com/microsoft/PowerToys/blob/master/.pipelines/pipeline.user.windows.yml#L46-L52

perhaps we should the same for PreviewHandler and ImageResizer too then?

perhaps we should do the same for PreviewHandler and ImageResizer too then?

Yes. But we can do it an another PR.

Alright, I'll create an issue and open a PR for it.


Question before migrating :)

This library looks absolutely great.  Nice work.
I'm eager to find a new solution.  My data is in the form of a tree.  Each layer of the tree specifies a droppabal/draggable pair.  The depth of the tree is 5 (in other words, I'm not expecting more than 10 layers ever).
The flat version of the state is:
tree: {
    0: {
       id: 0,
       height: 0,
       data: {},
       parent: null,
       childIds:[1,2],
    },
  1: {
       id: 1,
       height: 1,
       data: {},
       parent: 1,
       childIds:[...etc],
    },
    2: {
       id: 2,
       height: 1,
       data: {},
       parent: 1,
       childIds:[...etc],
    },
// etc...
    15: {
        id: 15,
        height: 4,
        data: { item },
        parent: 14,
        childIds: [],
    }
}

The leaf nodes have the items of interest.  The nodes to that point are just ways to group the items.  The system needs to capture the drop events at the various height/nodes.  The draggables can be any node or leaf.
Can this library track the movement events in such a layered design?
Thanks in advance for letting me know.
- E

Hey @EdmundsEcho, what type of interface are you building? Looking at your data structure, it sounds like you're building a sortable tree. If so, you can take a look at this story which should give you a general idea of how to flatten your data structure to make it work with @dnd-kit https://github.com/clauderic/dnd-kit/pull/76


get Funds Information (Deposits and Withdrawals)

Hi, i'm just new user of xchange library. I am not aware yet how to raise a request or issue so bear with me. My concern basically is that I wanted to get the history of the deposits and withdrawals for certain exchanges but I dont think it is fully supported by the library , please feel free to correct me. I am able to do this for Bitfinex by adding below codes. I would like to suggest in adding such feature for reporting/accounting purpose. Let me know if this is possible or how do I go about this. Thanks.
-------- BitfinexAccountServiceRaw  -------
public BitfinexMovementsResponse[] getBitfinexMovements() throws IOException {
try {
BitfinexMovementsResponse[] e = this.bitfinex.movements(this.apiKey, this.payloadCreator, this.signatureCreator, new BitfinexMovementsRequest(String.valueOf(this.exchange.getNonceFactory().createValue())));
return e;
} catch (BitfinexException var2) {
throw new ExchangeException(var2.getMessage());
}
}
-------- xchange-core  -------
public final class FundsInfo {
private final List fundsRecordList;
public FundsInfo(List<FundsRecord> fundsRecordList) {
    this.fundsRecordList = fundsRecordList;
}

public List<FundsRecord> getFundsRecordList() {
    return this.fundsRecordList;
}

public String toString() {
    return "FundsInfo [fundsRecordList=" + this.fundsRecordList + "]";
}

}
-------- BitfinexAccountService  -------
public FundsInfo getFundsInfo() throws IOException {
return BitfinexAdapters.adaptFundsInfo(this.getBitfinexMovements());
}
-------- BitfinexAdapters -----
public static FundsInfo adaptFundsInfo(BitfinexMovementsResponse[] bitfinexMovementsResponses){
List fundsRecords = new ArrayList();
for (BitfinexMovementsResponse responseEntry : bitfinexMovementsResponses) {
String address = "";
String description = responseEntry.getDescription();
if (responseEntry.getCurrency().equals("BTC") && responseEntry.getType().equals("WITHDRAWAL") && description.contains(",")){
address = description.substring(0,description.indexOf(",")-1);
description = description.substring(description.indexOf("txid: ")+ "txid: ".length());
}
FundsRecord fundsRecordEntry = new FundsRecord(address,responseEntry.getTimestamp() * 1000L,
responseEntry.getCurrency(),responseEntry.getAmount(),
description,responseEntry.getType());
  fundsRecords.add(fundsRecordEntry);
}
return new FundsInfo(fundsRecords);

}

FundInfo object here
------- xchange-core-----
public final class FundsRecord {
public FundsRecord(String address, Long date, String ccy, BigDecimal amount, String ref, String fundsType){
this.address = address;
this.date = date;
this.ccy = ccy;
this.amount = amount;
this.ref = ref;
this.fundsType = fundsType;
}
}

You are right, XChange generic API doesn't support this yet. I think this would be a useful addition to the generic API (I myself would use it immediately for some of my projects).
I already suggested it in #21 (though the issue discussion mostly digressed to other topics).
If someone starts implementing this, please ping me and I'll help with code review, suggestions, and possibly implementations for some exchanges with testing. I don't currently have the time to start writing this myself though.

Hi, can I work on this for 4 exchanges to get Withdraw/Deposit history? I have the codes ready for Kraken, Bitfinex, OkCoin and BTCChina ... I will have to throw NotYetImplementedForExchangeException for all the rest. If yes, i need some kick start guide, e.g. branching, issue naming conventions etc.....  I also plan to fix around 3 to 4 issues I found as well for other exchanges like BTC China and Bitstamp. Its my first time trying to contribute to github open source repositories so I still don't know where to start

@kisapmata That sounds great! I'll do my best to help. I'll try to give you some pointers today if I manage to, otherwise next week.

So I suggest we start with what you have.
Your contributions should be separate and self-contained, so if you have the FundsInfo addition plus 4 other issues, these should be all in separate git branches, so 5 branches altogether. Branch names are not very important, but try to make them a bit descriptive, like generic-fundsinfo, bitstamp-timestamp-fix and such.
First make sure you have your code committed to these branches locally. Each branch should be rebased on the latest state of the develop branch.
Whenever possible, each branch should contain unit tests that test new code, or in case of bug fixes, tests that demonstrate the bug (ie. tests that fail before the bug fix and pass with the bug fix included).
When your local branches are ready, push them into your XChange clone repository on GitHub (https://github.com/kisapmata/XChange). Submit a Pull Request (PR) against the develop branch timmolter/XChange for each branch, together with a short description, or a reference to an existing issue, eg. #1334 (this issue). GitHub should offer a one-click PR submit option, or you can click on the branch in your repo and submit a PR there.
When a PR is submitted, I'll review the code and add some suggestions. You can then simply switch to the corresponding branch locally, code any additions/changes, and push into your GitHub repo; the PR will be updated automatically.
When we're satisfied with the result, I'll merge the issue into timmolter/XChange. Done!
If you need help with any of the above, please ask. You can also reach me by e-mail (see my GitHub profile page).
Thanks a lot for contributing, it's greatly appreciated!

Besides Kraken, Bitfinex, OkCoin and BTCChina implementations that @kisapmata will contribute, I'll do Bitstamp and Poloniex. I think this will be a good start.

I have made the commit and PR. I included adapter tests and also demo for each bitfinex, kraken, okcoin and btcchina

i have to cancel the PR. I need to sync first with the latest develop branch sorry

I initially missed out to re-base from develop branch. now its fine, PR should be updated.


Add benchmarks/tests for //kythe/go/storage/stream package [phab:D885]

Created by schroederc at 2016-05-13 16:35:41:

shahms accepted this revision at 2016-05-13 16:42:19

schroederc closed via commit 6bbbddef924fe90de988c725768e2b3cfd74629c at 2016-05-13 16:43:16


[SYSTEMML-962] Refactor jekyll based website with new layout

Apply the new website layout to the existing Jekyll based website.

@deroneriksson @objectadjective The main entry page seems to be working well, except for the videos. And I need to fix some styles on the old pages. But other then that it seems to be coming along well. Please provide some feedback on things that I might have missed.

@lresende This is great! Thank you for all the hard work migrating the new design to Jekyll! This is a huge step forward for the project.
When viewing the generated source code, I noticed that this version fixes the favicon image. Does that mean that this represents the most up-to-date official version of the website since it contains improvements such as the favicon fix (compared to what is in svn)?
I noticed that the "Get Involved" header isn't centered on Chrome but that is very minor and we can subsequently update little things such as that. The important thing is that we now have the redesign migrated to Jekyll which is awesome.
LGTM.

@lresende Thanks, this is awesome.

@lresende LGTM

Merged into master.


Mocha timeout option is ignored

I have a test with a page that takes fairly long to fully load (for example: http://www.saksfifthavenue.com/). It oftentimes takes more than 10 seconds to get all the widgets, pop-ups and everything fully loaded.  In these cases, I get the following error message (just on trying to load the page - I have not started interacting with the page):
Blablabla test suite "before all" hook:
timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.
running chrome
Error: timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.
at Timeout. (/usr/local/lib/node_modules/wdio-mocha-framework/node_modules/mocha/lib/runnable.js:226:19)
at tryOnTimeout (timers.js:224:11)
at Timer.listOnTimeout (timers.js:198:5)
I tried changing the mocha timeout in wdio.conf.js as described in the http://webdriver.io/guide/testrunner/timeouts.html page:
framework: 'mocha',
mochaOpts: {
    timeout: 99999999
},

But no matter which value is given to timeout (I tried 20000, 0 and other big numbers), it still times out after 10 seconds.
I switched to using Jasmine instead, changed the Jasmine timeout to 20 seconds (as it still fails occasionally if I keep the 10 seconds default value) and everything works fine.
It looks to me like the mocha timeout value in wdio.conf.js is not being passed correctly to mocha itself.
I think I am using the latest version of all components:
mocha: 2.5.3
wdio-mocha-framework: 0.3.5
webdriverio: 4.2.1

{
	"webdriverio" : "^4.2.1",
	"wdio-mocha-framework" : "^0.3.5",
}

Works fine for me.
I'm not sure, but have you tried waitforTimeout: 999999 ?

Yes, I did try to raise all the timeout values (including waitforTimeout), but these other timeouts are not the ones causing the issue (I am not actually running any waitfor... commands, I am still just waiting for the page to load).  Mocha timeout seems to trip up before all others.  When I switched to Jasmine, I reset all the other timeouts and I have no issues on page load (well as long as I raise the Jasmine framework timeout above 10 seconds, of course).
I am not really required to use Mocha, Jasmine is perfectly fine.  I just raised the issue in case I am not the only one seeing this (and others might require the use of Mocha).

@ianrenauld it is working for me to. Are you using the wdio testrunner?

Yes I am using the wdio test runner.
If someones wants to reproduce what I am seeing, here is a simplification of my code that does the problem for me (maybe not 100% of the time: we need the web site to take slightly more than 10 seconds to load, but it happens often enough).  Increasing Mocha timeout does not help, but increasing the timeout in Jasmine does work.
describe('Test Suite', function () {

    it('Open the web page', function () {
        browser.url('http://www.saksfifthavenue.com/Entry.jsp?sf_ip=<IP_ADDRESS>');
        if (browser.element('[id="modal"]').isVisible) {
            browser.element('[id="closeButton"]').click();
            // Pause for the animation that closes the window
            browser.pause(250);
        }
        browser.waitForVisible('[id="sf-widget-companion"]');
        browser.frame('sf-widget-companion');

        if (browser.element('.sidebar2.js-sidebar-widget.desktop.sidebar2--close-desktop').isVisible()) {
            browser.element('.sidebar2.js-sidebar-widget.desktop.sidebar2--close-desktop').click();
        }

    });
});

@ianrenauld can you execute console.log(browser.options) and post the result here?

Found the issue while printing out my browser.options.  Seems that I had two different sections for mochaOpts in my config file.  The first one set the timeout, while the second one set the ui to bdd.  But since there was no timeout values in that block, it reset to 10000.
When I combine the two, all is fine.  Thanks for your help!

I am getting this error but only 1 mocha config section.


docs: add showcase section to the contributing guide

What kind of changes does this PR include?

Changes or translations of Starlight docs site content
Something else!

Description
This PR adds a new section to the contributing guide, which explains how to add a showcase entry to the Starlight docs site which is something that was never properly documented before.
I've also added a link to this new section in docs/src/content/docs/resources/showcase.mdx so that it's easier to find.

Thanks everyone for your help :raised_hands:


v0.11 util vs. tool nesting

It's been requested for a long time by @bendichter to use a more proper utils designation applying only to functions that contain no external dependencies beyond the standard python library. Anything that depends on stuff like pynwb or spikeinterface should really, then, be classified as a tools function instead. Below are some proposals for how this ought to be nested, and I wanted to get everyone's feedback on which looks nicest.
@alejoe91 has also requested that commonly used tool functions for SI be exposed at a higher level (ideally from nwb_conversion_tools import write_recording), and while implementing this is as easy as updating the __init__.py for the package independent of the utils/tools discrepancy, I have some ambiguity concerns with respect to the naming schemes there, which I highlight at the end of each proposal.
(a)
nwb_conversion_tools
  - data_interfaces
    -- All the various interfaces we use
  - schemas
    -- All the various JSON schemas we use
  - utils
    -- schemas
      --- Basically, all the internal schematic retrieval utilities we use like get_schema_from_hdmf_class
    -- dict
      --- Dictionary-specific utils, of which we have several but the most important being dict_deep_update
  - write_tools
    -- nwbfile.py
    -- yaml_conversion_specification.py
    -- spikeinterface
      --- write functions as well as generic iterator
    -- roiextractors
      --- write functions as well as generic iterator (TODO)
    -- neo
      --- the ABF reader and other future icephys stuff

@alejoe91 - For unexposed imports, this would look like from nwb_conversion_tools.write_tools.spikeinterface import write_recording. My concern here is that, when exposed at the highest level, from nwb_conversion_tools import write_recording doesn't indicate any specificity to SpikeInterface; so when we eventually add neo support or anything similar, it could be ambiguous what kind of 'recording' we are writing; whereas when unexposed, the way it is imported clearly indicates the type of recording being references. Re-naming the function to write_spike_interface_recording could otherwise resolve this ambiguity, but then a direct unexposed import of from nwb_conversion_tools.write_tools.spikeinterface import write_spike_interface_recording seems excessively verbose.
(b)
nwb_conversion_tools
  - data_interfaces
    -- ecephys
      --- baserecordinginterface.py, ...
      --- write_tools
        ---- SpikeInterface write functions as well as generic iterator. The idea here is that these tools
        ---- are so specific to these interfaces, they could live next to each other.
    -- ophys
      --- baseimaginginterface.py, ...
      --- write_tools
        ---- roiextractor write functions as well as generic iterator. The idea here is that these tools
        ---- are so specific to these interfaces, they could live next to each other.
    -- icephys
      --- baseicephysinterface.py
      --- write_tools
        ---- the ABF reader and other future icephys/neo stuff. The idea here is that these tools
        ---- are so specific to these interfaces, they could live next to each other.
  - schemas
    -- All the various JSON schemas we use
  - utils
    -- schemas
      --- Basically, all the internal schematic retrieval utilities we use like get_schema_from_hdmf_class
    -- dict
      --- Dictionary-specific utils, of which we have several but the most important being dict_deep_update
  - tools
    -- nwbfile.py
    -- yaml_conversion_specification.py

@alejoe91 - unexposed:  from nwb_conversion_tools.data_interfaces.ecephys.write_tools.spikeinterface import write_recording I'll admit, that is so utterly nested it just needs to be exposed regardless. In this case I'd just insert _spike_interface_ into all the function names to make it obvious that's the type of recording being referred to.
(c)
nwb_conversion_tools
  - data_interfaces
    -- All the various interfaces we use
  - schemas
    -- All the various JSON schemas we use
  - utils
    -- schemas
      --- Basically, all the internal schematic retrieval utilities we use like get_schema_from_hdmf_class
    -- dict
      --- Dictionary-specific utils, of which we have several but the most important being dict_deep_update
  - tools
    -- nwbfile.py
    -- yaml_conversion_specification.py
    -- writing
      --- spikeinterface
        ---- write functions as well as generic iterator
      --- roiextractors
        ---- write functions as well as generic iterator (TODO)
      --- neo
        ---- the ABF reader and other future icephys stuff

@alejoe91 - similar to (b), nesting becomes undeniably complicated.
Open to all other suggestions as well; trying to make the structure and clean, organized, and intuitive as possible.

I agree with the name changing (maybe keep a Deprecation warning for a while) and going for option (a). What about write_si_recording/write_si_sorting? or write_spikeinterface_recording() (without the extra _)

Suggestion from meeting nwb_conversion_tools.spikeinterface import write_recording alias of nwb_conversion_tools.tools.spikeinterface import write_recording

Also tools instead of write_tools


Consider emitting precise signatures for private/private[this] members

Currently, we're only emitting SemanticDB and ScalaSignature payloads for public and protected members (private[foo] qualifies as kinda public, since it's modelled this way in pickles and bytecode). Let's consider including private and private[this] members.

While this would be definitely useful for tool integrations, our focus for now is enabling parallel compilation for Scalac. For that, emitting private and private[this] signatures is unnecessary.


Feature Proposal: Use github action instead travis for CI / CD

Expected Behavior or Use Case
Github action is easy to setup and maintained. We should use github action for all CI / CD in the long run instead of travis. Here is an example workflow(https://github.com/amundsen-io/amundsencommon/pull/47).
Service or Ingestion ETL

Possible Implementation

Example Screenshots (if appropriate):
Context

I will take a look next week once back.
cc @ttannis @Golodhros

I haven't used GH actions much but I've worked a ton with circleci, I think I could make good progress on this without too much help -- can I pick this up?

Thanks @dorianj , but I think this one requires to access some passwords / token for the project in order to test it end 2 end (e.g upload pypi). I would still prefer to do it myself if it is ok to you.

all the prs are merged and we are 100% on github action now.


Test the semi-auto way to cut a bp-cli release

What type of PR is this?
(feature/test)
What this PR does / Why we need it?
https://issues.redhat.com/browse/OSD-20658
More context
https://docs.google.com/document/d/1_EfS9FGuT-3a4i_1xC3jyhIh9qWrNfWMINLoe-8VhhU/edit

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.54%. Comparing base (8421f5c) to head (a2ea22e).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage   44.54%   44.54%
=======================================
  Files          63       63
  Lines        5296     5296
=======================================
  Hits         2359     2359
  Misses       2617     2617
  Partials      320      320

/lgtm


when I run main.py in my data, I find the loss has more than 0.9, but the acc is only has 0.7, Do you have any good suggestions？

when I run main.py in my data, I find the loss has more than 0.9, but the acc is only has 0.7, Do you have any good suggestions？

@18456432930 Regarding the loss specified above, are you getting the value around -0.9? As the minimum loss value corresponds to -1. But When checked the model accuracy, it steadily increases with every epoch. On the other hand, loss value goes like this -15, -34 in this direction. Thanks!

你在哪个模型上面跑，BYOL还是simsiam？


Move static route to systemd unit

If a node reboots, the routes aren't installed as it happens in kubeadm.
It should be a unit in ignition. Context: https://gigantic.slack.com/archives/C02EVLE9W/p1714374192860579
/run cluster-test-suites

/run cluster-test-suites

This needs testing in an environment with multiple NICs/routes and manual validation in Flatcar.

/run cluster-test-suites

"It works on my computer"
/run cluster-test-suites

I tested it manually and it works. The E2E tests fail again because of lack of resources.

/run cluster-test-suites

Tests fail because of the schema changes FYI

Closing in favor of https://github.com/giantswarm/cluster-cloud-director/pull/301


CLOUD-43441 Change UPDATE_IN_PROGRESS states to WAIT_FOR_SYNC at CB start

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1747/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1749/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1750/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1751/


NuGet PackageReference should recommend PrivateAssets=all

Description
PolySharp's NuGet PackageReference recommendation is currently:
<PackageReference Include="PolySharp" Version="1.7.1" />

Since PolySharp is a source-only polyfill provider, it should recommend a more restricted scope PackageReference like this:
<PackageReference Include="PolySharp" Version="1.7.1">
  <PrivateAssets>all</PrivateAssets>
  <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>

Rationale
This prevents any package dependencies from flowing to parent projects as described at Controlling dependency assets. It's also the recommendation of every other source-only polyfill project I'm familiar with (e.g., PolyKit.Embedded, Polyfill.NET, and Nullable).
Drawbacks
None that I'm aware of.

Yeah that's a good point. I usually just recommend using PrivateAssets="all", that alone should do the trick. I'm not aware of a way to change that suggestion on NuGet though, that's not something that I see an option for on the website 🤔
I guess I could at least add a section about this in the readme though to help folks.

I believe you need to set the MSBuild property DevelopmentDependency to true as discussed at DevelopmentDependency support for PackageReference. It can be in your .csproj files (e.g., PolyKit.Embedded.csproj, Polyfill.NET.csproj), or it can be in a .nuspec file (e.g., Nullable.nuspec).

This uncovered an annoying inconsistency in nugetizer. I've now fixed it, published the fix, and set the PR to fix this :).


Simplification of example-code in documentation

The Prediction documentation contains a section how to transform the ratio bounding boxes to absolute ones. The part
let xBoundingBox = word.boundingBox.origin.x * imageView.frame.size.width
let yBoundingBox = word.boundingBox.origin.y * imageView.frame.size.height
let widthBoundingBox = word.boundingBox.size.width * imageView.frame.size.width
let heightBoundingBox = word.boundingBox.size.height * imageView.frame.size.height
let boundingBox = UIView(frame: CGRect(x: xBoundingBox, y: yBoundingBox, width: widthBoundingBox, height: heightBoundingBox))

can be replaced with
let trafo = CGAffineTransform(scaleX: imageView.frame.size.width, y: imageView.frame.size.height)
let boundingBox = UIView(frame: word.boundingBox.applying(trafo))

I'm not sure if that's better as it hides the actual operation, however, it is more concise in my opinion.

This change was merged. Therefore, I see little reason to keep this ticket open. Thanks for considering my suggestion.


About the ensemble model

Hello, I fused the logits of the three models. Maybe you know how does this ensemble model gets its GradCAM?

You can backpropagate score gradients to each model and get three Grad-CAM heatmaps. Unfortunately, this code only supports a single heatmap.


VideoView undesired implicit animations

As a developer integrating Pillarbox I want to be able to animate VideoViews without glitches, especially during rotations, translations or size changes.
Even if some issues were fixed in https://github.com/SRGSSR/pillarbox-apple/pull/726, we recently updated our Podcastator sandbox project and found that the video background animation during player expansion / collapsing is lagging behind.
Acceptance criteria

The Podcastator animation glitch is fixed.
Rotation animations are correct.
SRF news animations are correct.

Tasks

[ ] Fix the issue.

Attempting to synchronize CALayer animations like we did in #726 is doomed to fail. But we can store the view and its layer instead of the layer alone in our custom picture in picture manager class. This way we can have the view use AVPlayerLayer as backing layer class, which should solve this issue.
This needs further testing of course.


React16 Support

I'm Submitting a ...

[ ] Bug report
[x] Feature request
[ ] Support request

With react currently at -rc.3 and should be actually releasing 16 this week, is it possible to bump these dependencies?

and, looks like it was released this morning :)


Pasting from Snipping Tool

Description
Following on from #86, I'm encountering another bug on Windows where if you paste an image taken with the snipping tool, the result is just an empty array.
(I can confirm that #86 is fixed and actual files can be pasted as expected.)
To reproduce

Open Snipping Tool (e.g. with keyboard shortcut Shift + Windows + S)
Select an area to screenshot, such as something like this

Paste into flutter app
With the following code snippet, observe that flutter: pasted [] is printed

Code snippet
/// Maps image formats to their file extension.
const Map<SimpleFileFormat, String> formats = {
  Formats.png: '.png',
  // ...
};

for (SimpleFileFormat format in formats.keys) {
  if (!reader.canProvide(format)) continue;
  final progress = reader.getFile(
    format,
    (file) async {
      final stream = file.getStream();
      final List<int> bytes = [];
      await Future.delayed(const Duration(milliseconds: 100));
      await for (final chunk in stream) {
        bytes.addAll(chunk);
        await Future.delayed(const Duration(milliseconds: 100));
      }
      print('pasted $bytes'); // flutter: pasted []

      String extension;
      if (file.fileName != null) {
        extension = file.fileName!.substring(file.fileName!.lastIndexOf('.'));
      } else {
        extension = formats[format]!;
      }

      photoInfos.add(PhotoInfo(
        bytes: Uint8List.fromList(bytes),
        extension: extension,
      ));
    },
  );
  if (progress != null) progresses.add(progress);
}

I added in some Future.delayeds to make sure that it wasn't a problem of not waiting long enough. I also increased them to 3000ms but that didn't change anything.

More info

Windows 11 22H2 x64
Flutter 3.7.9
super_clipboard 0.3.0+1
super_native_extensions 0.3.0+1
PR in my repo: https://github.com/adil192/saber/pull/474

Flutter 3.7.9 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 62bd79521d (3 days ago) • 2023-03-30 10:59:36 -0700
Engine • revision ec975089ac
Tools • Dart 2.19.6 • DevTools 2.20.1

Thank you for the report. This is an oversight in reader implementation. OLE streams need to be rewound before reading and the reader didn't do that.
The delay when reading should not be necessary.

Please reopen if this happens with 0.3.0+2.

Works perfectly :) Thank you!


Issue In Azure connetion

at Microsoft.Data.SqlClient.TdsParser.SendFedAuthToken(SqlFedAuthToken fedAuthToken)
at Microsoft.Data.SqlClient.SqlInternalConnectionTds.OnFedAuthInfo(SqlFedAuthInfo fedAuthInfo)
at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
at Microsoft.Data.SqlClient.TdsParser.Run(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj)
at Microsoft.Data.SqlClient.SqlInternalConnectionTds.CompleteLogin(Boolean enlistOK)
at Microsoft.Data.SqlClient.SqlInternalConnectionTds.AttemptOneLogin(ServerInfo serverInfo, String newPassword, SecureString newSecurePassword, Boolean ignoreSniOpenTimeout, TimeoutTimer timeout, Boolean withFailover)
at Microsoft.Data.SqlClient.SqlInternalConnectionTds.LoginNoFailover(ServerInfo serverInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString connectionOptions, SqlCredential credential, TimeoutTimer timeout)
at Microsoft.Data.SqlClient.SqlInternalConnectionTds.OpenLoginEnlist(TimeoutTimer timeout, SqlConnectionString connectionOptions, SqlCredential credential, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance)
at Microsoft.Data.SqlClient.SqlInternalConnectionTds..ctor(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, SqlCredential credential, Object providerInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString userConnectionOptions, SessionData reconnectSessionData, Boolean applyTransientFaultHandling, String accessToken, DbConnectionPool pool)
at Microsoft.Data.SqlClient.SqlConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions)
at Microsoft.Data.ProviderBase.DbConnectionFactory.CreatePooledConnection(DbConnectionPool pool, DbConnection owningObject, DbConnectionOptions options, DbConnectionPoolKey poolKey, DbConnectionOptions userOptions)
at Microsoft.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
at Microsoft.Data.ProviderBase.DbConnectionPool.UserCreateRequest(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection)
at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, TaskCompletionSource1 retry, DbConnectionOptions userOptions, DbConnectionInternal& connection)    at Microsoft.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)
at Microsoft.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource1 retry, DbConnectionOptions userOptions)    at Microsoft.Data.ProviderBase.DbConnectionClosed.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource1 retry, DbConnectionOptions userOptions)
at Microsoft.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry, SqlConnectionOverrides overrides)
at Microsoft.Data.SqlClient.SqlConnection.Open(SqlConnectionOverrides overrides)
at Microsoft.Data.SqlClient.SqlConnection.Open()
at TestAzureapp.Handler.TestHandler.Handle(TestRequest request, CancellationToken cancellationToken) in D:\IOTConnect\7825_Test_App\TestAzureapp\TestAzureapp\Handler\TestHandler.cs:line 30

@sw-tt-pankajkathiriya can you provide more details please? A sample repro would be appreciated.

I get the same error.
My usage pattern is to create connections to round about 200 Azure SQL Databases in a loop.
The first 20 connections open successfully. Then some connection cannot be created with that null reference exception.
In total ca. 50% of the connection attempts fail. A simple retry does not help.

@ctse020 I tried downgrading to 1.14, which worked for me. Thanks!


jail: Add archive subcommand and create method

The archive subcommand (-A) creates a tar file containing the contents of a jail and it's metadata.  The create subcommand (-c) gains a new method to create a new jail from an archive, restoring its metadata. This can be used to save a copy of a jail before updates or to transfer a jail to another machine.
This PR depends on (and thus contains) #793

@brooksdavis Can you please rebase after the #793 merge? Looks like the ports piece was missed here.

@brooksdavis Can you please rebase after the #793 merge? Looks like the ports piece was missed here.


If no project name found (eg because no project.conf) set it to a default, with a warning

See original issue on GitLab
In GitLab by [Gitlab user @devcurmudgeon] on Apr 5, 2018, 15:26
As discussed on IRC, this way new user doesn't have to create a project.conf file.
I suggest the warning should be something like:
WARNING: Missing project name - please add a name in project.conf
And I suggest the name should be "new-project" or similar

In GitLab by [Gitlab user @tristanvb] on Apr 6, 2018, 10:14
The project.conf is essential especially for the project name, which should be explicitly selected by the user in order to distinguish it from other projects.
For this reason, it is a bad idea to train the user to ignore this aspect, instead we should make it easier for the user to get started.
I do recognize that there is some frustration in "getting started" in general, especially in the absence of a really nice guide - as such I'm going to close this in favor of issue #342, which [Gitlab user @cs-shadow] happened to also file around the same time as this issue; we can track the UX for starting on a new project in that issue.

In GitLab by [Gitlab user @tristanvb] on Apr 6, 2018, 10:14
closed


commanded.new is not working with Miro

When I run
mix commanded.new auctioneer --miro o9J_l9SPDEU=
I get the following error
** (MatchError) no match of right hand side value: {:error, "No authorization data was found on the request"}     (commanded_generator 1.2.0) lib/commanded/generator/project.ex:49: Commanded.Generator.Project.build_model/3     (commanded_generator 1.2.0) lib/mix/tasks/commanded.new.ex:97: Mix.Tasks.Commanded.New.generate/4     (mix 1.11.4) lib/mix/task.ex:394: Mix.Task.run_task/3     (mix 1.11.4) lib/mix/cli.ex:84: Mix.CLI.run_task/2
My Miro board is public

You might want to run the command with your Miro REST API access token as an env var:
MIRO_ACCESS_TOKEN=<your-access-token> mix commanded.new PATH --miro BOARD_ID

How did you get a token? Did you have to setup a developer team with Miro?

How did you get a token? Did you have to setup a developer team with Miro?

I just solved this mystery; yes you start up a dev team and more.  I followed this through step 4: https://developers.miro.com/docs/getting-started


Add working GitHub Actions support

Tests one model architecture and gives us a nice little green tick if the errors between the Keras model and the Konverted model are low enough!

Kudos on this! I skimmed over the test.yml and I'm really impressed by the apparent complexity and completeness of it. I have never used Github Actions before so I'm learning by example here. I'll pull from this and test on my end and let you know if I come up with some ideas.
Keep up the great work!!

Thank you! I really just copied the example code from Poetry so that I could use the correct implementation and the rest of the commits were just getting the matrix to work properly, adding custom versions of TF based on the Python version as well as fixing issues with Poetry and TensorFlow which I just decided on using pip itself for the tests in the end haha. I hope it helps, you could really cut out a few steps if you don't need cache, but that seems to speed it up quite a bit

Do you have Discord? I'm having some trouble with Typer, you probably know more about it

As of 5 minutes ago, I do, my username is apiad#1042.

I don't think Typer is all that important here, since konverter doesn't (yet) have a complicated CLI, so if it is causing problems, I think a pure argparse rewrite is fairly easy. I can do it if you want.


V2.10.4 - Bump pyxplora_api from 2.8.3 to 2.10.0

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


fix devicelab

I believe this will fix the devicelab - it passes locally, but so does my previous attempt.
I'm unable to test it on the boxes themselves, I keep getting kicked off.
Based on what I've seen in https://github.com/CocoaPods/CocoaPods/issues/7708

Tree is actually green - merging.


op=stream defaults to 1h scroll ttl

@hochgi  2 questions:

Does it affect other stream types?
Can we override this by providing TTL as query parameter?

@Ivan-Shestakov

No. Just stream
Yes, but I added it for debug & benchmarking purposes. End users shouldn't be troubled with it.


database quoted message querries

2 checkpoint:

if message has quote
if quoted message exists in database

Both of them = true then fills the columns

non-ASCII characters were unacceptable to btoa() function. Used Buffer instead.
body_blob column in progress.

Modifications for folder transaction.
Every table queries are done. Except:
For group messages:  Query functions for sender, recipents and headers columns are in need of modification.                                                                     Main goal is to read group messages as emails of a mail group.

#5 is fixed and merged by this pull request.


fix: blocked gateway cctx for high-gas deposit

Description

Add a gas limit for omnichain calls with gateway workflow
Add TestDepositAndCallOutOfGasName test to check CCTX revert if the omnichain call is out of gas

Check the change:
if the value is set back to nil in https://github.com/zeta-chain/node/pull/3106/files#diff-27b3a64d8d9957b22a3aaec6fe8679ed046033e5de6437afe7b46c7efca3c7b7R19 then the TestDepositAndCallOutOfGasName will fail because inbound doesn't get observed

Removing https://github.com/zeta-chain/node/issues/3084 as attached PR as it will not fully address the problem


Uncaught error using React basic demo with Typescript

Description
Hi, im trying to render a very basic HotTable to test the performance of the library, and using the very basic demo the app is crashing.
Steps to reproduce

render the component
Go to the app
Check console error

Demo

https://jsfiddle.net/handsoncode/c6rgz08x/

Your environment

React wrapper version: 4.0.0
Handsontable version: 8.2.0
React: 16.13.1
Typescript 4.0.3

Thank you for sharing the issue report. Pablo. I've built a sample app using

npx create-react-app my-app --template typescript

with following dependencies
    "@handsontable/react": "^4.0.0",
    "@types/react": "^16.9.53",
    "handsontable": "^8.2.0",
    "react": "^17.0.1",
    "typescript": "^4.0.3",

and got the project working. You can download it from here (node_modules removed) https://we.tl/t-UzfQxXJWaW
ps. we've created a separate project to test Handsontable performance https://github.com/handsontable/performance-lab
We mostly use it to compare two versions of the software but if you want to test it you just pick a set of settings for the table as all the crucial test scenarios are already defined and available to run.

Thanks for the demo and the fast reply, i spent some time trying to figure out what the source of the problem is, and i found this code from my project:

After i rename that custom function to something else, everything is working. Just in case you want to review that.


Possible bug and difference between scale and resolution?

https://github.com/ashawkey/torch-ngp/blob/b6e080468925f0bb44827b4f8f0ed08291dcf8a9/gridencoder/src/gridencoder.cu#L138
What's the difference between scale and resolution? Shouldn't they both refer to the number of voxels along one dimension?
And here you are trying to get the voxel center, why do you add 0.5 when align_corners is false?
https://github.com/ashawkey/torch-ngp/blob/b6e080468925f0bb44827b4f8f0ed08291dcf8a9/gridencoder/src/gridencoder.cu#L148

@Guptajakala Hi, scale is float and resolution is int, it follows the original implementation's notation.
For the second one, you may refer to this.


Highlight app namespaces

It seems like it would be handy to be able to highlight my own app's namespaces when printing the exception, perhaps by bolding it? This is quite a common feature in exception reporters, where you can provide a namespace/package prefix to match on.
This could possibly be made into a frame rule, with a new frame visibility of :bold?

Seems like a good idea.

I would love this idea 😁


Update dependencies of nexus-sdk-js

Several dependencies could be updated (including Typescript), better do it when there is no urgency to update and test that everything is working,.

Fixed.


#313 bump jcabi parent version to 0.49.9

This is for #313.
According to jcabi changelog, this was fixed since 0.49.2 (most certainly with 0.49.5 but changelog is not extremely clear).
Since

0.49.2 was released before #313 was opened
0.49.9 was released after #313 was opened

I believe this should be alright to answer the ticket submitter request for using latest snapshot at the time.

@victornoel/z this pull request is too small, just 4 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @paulodamaso/z please review this and merge or reject

@paulodamaso please wait for review, it seems the build is now broken :)

@paulodamaso it should be fixed.
Note that:

I had to keep the version of hamcrest-core and co to the old one because the new one has the needed dependency for compile in hamcrest instead of hamcrest-core, which then, if added to the compile scope, would make qulice complain
I took the opportunity to use the version of junit recommended by jcabi parent, which remove the deprecated org.junit.Test annotation, hence the change in the code for tests to work.

@victornoel Thanks!

@rultor merge

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 19min)

Job gh:yegor256/jpeek#434 is not assigned, can't get performer


In Workspace, doing a copy/replace drops the crlf.

There are times when I want to replace something with a crlf. The copy replace window strips out ther crlf.

The Replace window has lost the crlf.

This makes trying to add crlf into text very tedious in certain situations.

Most find and find-and-replace features do not handle linefeeds.  VW is an exception and it's so handle that I use it for completely unsmalltalk related text processing in spite of the... basic... API.
If Jadeite chooses not to handle then stripping off the unsearchable-for text is a good idea and would apply to find as well as find-and-replace.


Remove Inside logic from FileUploadExecutors

Purpose

Remove Inside logic from FileUploadExecutors

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/1652790957

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/1652790957
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/1657263712

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/1657263712
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/1716934207

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/1716934207
Status: success


Elasticsearch 2.3.x?

The documentation says that 2.4 is required in one place, but in other it seems to imply at least 2.1.x.
Is 2.3.x supported?  I ask because AWS provides managed ES clusters which simplifies things greatly but they are currently 2.3.2 and 1.5 (IIRC).

It depends on the Moloch version, in general we continue to require newer and newer versions of ES as we go.
0.13.0 - 0.16.1 should support ES 2.3
0.17.0-GIT is currently requiring ES 2.4, but I may change that back to ES 2.3 (it was 2.1 in the code previously)
The issue is that ES 5 requires upgrading from ES 2.[34] currently, so might as well get folks on to ES 2.4 for whenever we are ready to support ES 5.  ES 5 is NOT supported yet.

👍 thanks.  There are additional gotchas with using the AWS ES instance, but as of yet I don't think they are blockers for moloch.


Customize port number

Is it possible to adjust the port 3000 in a different port? because I have 2x Rpi running. One with Flex and one with POCSAG but wants to put this POCSAG on port 3001.
First running @ : http://<IP_ADDRESS>:3000/

Where do i find that file? i have PM2 running.

Depends on your environment, but by default you'd place it in the server dir.
PM2 docos has more info on setting env variables: http://pm2.keymetrics.io/docs/usage/environment/

Sorry friends, can't find the file where i must chance the port setting. Like to have port 3001

If you haven't moved the file, it's in the same folder as app.js

You may also know it as this file if you didn't rename it
https://github.com/davidmckenzie/pagermon/blob/master/server/process-default.json

Case closed. I have made it.
First Rpi http://<IP_ADDRESS>:3000/ its the filter of my district
Second Rpi http://<IP_ADDRESS>:3001 its the Dutch network of pager alarms EMS
Thanks people.


Importing something from the entrypoint file causes it to be executed twice

Describe the bug
If you have an entry point that exports anything e.g.
import './other.ts'
export const a = 'hello';

and another file that imports from the entry point, e.g.
import {a} from './main'
console.log(a);

Then the code in the entry point is executed twice.
Reproduction
https://github.com/Artur-/vite-vaadin-problem3
Expectation is that "Hello Vite!" would be printed once, not twice
System Info
System:
    OS: macOS 11.6
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 628.55 MB / 32.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 16.11.0 - /usr/local/bin/node
    Yarn: 1.22.11 - /usr/local/bin/yarn
    npm: 8.0.0 - /usr/local/bin/npm
    Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 95.0.4638.54
    Chrome Canary: 97.0.4683.0
    Firefox: 92.0.1
    Safari: 15.0
    Safari Technology Preview: 15.4
  npmPackages:
    vite: ^2.6.4 => 2.6.12

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I can't reproduce. It showed ReferenceError.
Uncaught ReferenceError: can't access lexical declaration 'a' before initialization

Ok, interestingly enough the first time you open the page it shows
Uncaught ReferenceError: Cannot access 'a' before initialization

and then if you touch some file e.g.
touch src/main.ts

then it no longer gives any error but shows the contents twice

This seems to be a problem of the reduced test case though, I did not see this in the original application

Just bumped into this myself. I was getting

Uncaught ReferenceError: Cannot access 'createRoot' before initialization

Removing exports from my entry file fixed.

Starting from 2.7 I see Uncaught ReferenceError: Cannot access 'a' before initialization all the time in the test case, even after doing touch src/main.ts.

This maybe same with #3033.

Starting from 2.7 I see Uncaught ReferenceError: Cannot access 'a' before initialization all the time in the test case, even after doing touch src/main.ts.

So the bug can be closed then? The ReferenceError is correct behavior and happens with and without Vite.

@jonaskuske Thanks! Yeah, the behavior seems to be correct.
I've tested without Vite and this code does not work.
Closing as it's working correctly.


when g:NERDCustomDelimiters['x']['left'] set to begin with space nerdcommenter works uncorrectly.

vimrc:
filetype plugin indent on
let g:NERDCustomDelimiters = {'lex': { 'left': ' /**', 'right': '*/' } }

note:the left value of comment style begin with a space.
Nerdcommenter could correctly comment it but it could not correctly uncomment it.
origin text:
a

And we will get:
 /** [[> > a <] <] */

Although no a programming language comment style begins with a space,it's necessary for nerdcommenter to handle it correctly.Sometimes the char for comment could not write in the beginning of a line but user wants to comment the line.
This problem may be caused by the wrong determination whether the text is commented:
function s:IsCommented

Adding a space character to surrounding a delimiter is not supported for many reasons, most notably because it conflicts with the way we actually handle this. The correct supported way to get a space after the delimiter for your comments is to enable the corresponding feature:
let g:NERDSpaceDelims = 1

You can also customize the string used for the optional leading space, for example to get more than one space:
let s:spacePreStr = '  '

This should account for the the situation where existing comments may or may not have used the user's preferred leading space scenario.
This only gets complicated where some languages and style guides do in fact demand the space to be valid syntax, sometimes even more than one (Looking at you, silly PEP8!). For those cases there is already an issue to track this, see #328.


Add engagement_time_msec to Measurement Protocol message

According to docs:

https://trackingchef.com/google-analytics/how-to-add-session-id-to-ga4-measurement-protocol-events/
https://developers.google.com/analytics/devguides/collection/protocol/ga4/sending-events?client_type=firebase#format_the_request

Summarized sample:
{
"client_id": "123123123",
"events": [
{
"name": "offline_purchase",
"params": {
"engagement_time_msec": "100",
"session_id": "123456"
}
}
]}

Fixed in the sqlx files: https://github.com/GoogleCloudPlatform/marketing-analytics-jumpstart/tree/main/templates/activation_query

In order for user activity to display in reports like Realtime, engagement_time_msec and session_id must be supplied as part of the params for an event. The engagement_time_msec parameter should reflect the event's engagement time in milliseconds.


Is UWP supported?

Just came across this on GitHub and was wondering if Lottie is supported on UWP?

Sorry :(. I should have looked at this. https://github.com/martijn00/LottieXamarin/issues/5

https://github.com/martijn00/LottieXamarin/pull/63


[BEAM-5969] Add BOUNDED_SIDE_INPUT_JOIN new Query to Beam website

Now that the new query is merged into master, let's add it on the website and also give the names of the queries. I also updated the status of that query in batch and streaming modes in the tables. As PCollectionView is not supported in spark in streaming mode, I put ko on that and ok on the others (I still need to check the status of that query by updating the dashboards)
R: @kennknowles

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

@kennknowles quick update: I have just added the new query to all the perfkit dashboards for all the runners in batch and streaming modes. It runs fine !
Just a comment: nexmark postcommits on dataflow runner seem deactivated as there is no BQ table for that query. Nevertheless, I'll keep the dashboards for the time they are back online

@kennknowles actually nexmark dataflow postCommits are not deactivated: they seem to be failing. I opened a ticket for that: https://issues.apache.org/jira/browse/BEAM-5996

@kennknowles I updated and squashed commits PTAL.

@kennknowles ping ?

Sorry - I went on a little vacation without announcing. LGTM.

No need to wait for me again - merge when you are ready.

no problem Kenn, thanks for the approval !