[SPARK-13754] Keep old data source name for backwards compatibility

Motivation
CSV data source was contributed by Databricks. It is the inlined version of https://github.com/databricks/spark-csv. The data source name was com.databricks.spark.csv. As a result there are many tables created on older versions of spark with that name as the source. For backwards compatibility we should keep the old name.
Proposed changes
com.databricks.spark.csv was added to list of backwardCompatibilityMap in ResolvedDataSource.scala
Tests
A unit test was added to CSVSuite to parse a csv file using the old name.

Test build #52695 has started for PR 11589 at commit 4e891bf.

LGTM pending tests.

Test build #52695 has finished for PR 11589 at commit 4e891bf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52695/
Test PASSed.

Merging to master.

Thanks closing it. For some reason it did not close.


ZEPPELIN-481: On click of edit for notebook name don't receive focus

On click of edit for notebook name it opens up editor but it does not receive focus.
Same is the case with edit title of a paragraph.

Ready for review.

If I'm right, #512 is solving the same issue?

Yes, it does, closing this.


Bundles should have delays

Currently, the bundle syntax looks something like this:
bundle f[#N]: for<#i> @[G+#i, G+#i+1] #W

It is (hopefully) obvious that each wire in this bundle holds onto values for 1 cycle. However, for a bundle like this:
bundle f[#N]: for<#i> @[G, G+#i+1] #W

Each index holds onto a value for varying number of cycles. This means that this bundle cannot be reused until the index that holds the value for the longest amount of time releases it. This is extremely similar to how the input-output ports of a module affect its delay. It implies that a bundle must have a delay:
bundle f<G: #N>: for<#i> @[G, G+#i+1] #W

This tells us that the bundle may hold onto values for long amounts of time but it is bounded by #N. A bundle well-formedness pass must check this property.
A bundle used inside a module affects its delay in the same way that an invocation: for a module with delay d, for each bundle, we must ensure that the delay of bundle b is less than or equal to d.

Currently not needed. We are checking and enforcing bundle delay in #110


Best way to load raw audio data?

Is there a recommended way of loading the data as raw audio? I am working with Pytorch, and tried using torchaudio, generating a dataset that reads individual mp3 files, in a similar way to the dataset in the baseline code.
However, this is really slow, as it seems the workers are busy decoding the mp3 files.
Would it make sense to preprocess all files and save them as npyor torch.Tensor files, while the dataset only loads them? The main issue is that it would require significant more storage than the raw dataset stored as mp3.

It depends on what do you want to do with audio prior to learning. We use Essentia to read audio files and compute the spectrograms (see melspectrograms.py).
If you want to work with raw audio, I would say that indeed there is a tradeoff between speed and storage. It is a good practice to do the preprocessing separately from training (cutting or selecting regions) and save data that is ready for training as .npy (that's what we did for 30s spectrograms).
Any other comments, @minzwon?

I've never used torchaudio yet. I usually store the raw audio as .npy file. This is useful especially when you train the network with shorter chunks (i.e. 8 seconds instead of 30 seconds). In this case, I also recommend you to check mmap_mode of np.load.

It seems that preprocessing the files saving them as .npy makes sense then. That said, have you tried saving all individual .npyfiles as a single lmdb file?
Depending on the filesystem, this should be faster, as the extra cost for accessing a file is done only once. However, in my tests this is actually slower than just loading individual .npyfiles.


EnhancementSupport function YEARWEEK(DATE,INT,INT) RETURN INT

Proposed changes
Support function INT YEARWEEK(DATE date, INT week_start, INT day_in_first_week).

Returns year and week for the input date.
The parameter week_start means the start day of a week, which value is between 1 and 7，as is shown in following table：

week_start
meaning

1
Monday is the first day in a week

2
Tuesday is the first day in a week

3
Wednesday is the first day in a week

4
Thursday is the first day in a week

5
Friday is the first day in a week

6
Saturday is the first day in a week

7
Sunday is the first day in a week

The parameter day_in_first_week means which day in January belongs to first week，which value is between 1 and 7,
as is shown in following table：

day_in_first_week
meaning

1
The week including January 1st is the first week in the year

2
The week including January 2nd is the first week in the year

3
The week including January 3rd is the first week in the year

4
The week including January 4th is the first week in the year

5
The week including January 5th is the first week in the year

6
The week including January 6th is the first week in the year

7
The week including January 7th is the first week in the year

For example:
mysql> select yearweek('2022-1-1', 1, 1);
+---------------------------------------+
| yearweek('2022-01-01 00:00:00', 1, 1) |
+---------------------------------------+
|                                202201 |
+---------------------------------------+

mysql> select yearweek('2022-1-1', 1, 3);
+---------------------------------------+
| yearweek('2022-01-01 00:00:00', 1, 3) |
+---------------------------------------+
|                                202153 |
+---------------------------------------+

mysql> select yearweek('2021-12-29', 1, 1);
+---------------------------------------+
| yearweek('2021-12-29 00:00:00', 1, 1) |
+---------------------------------------+
|                                202201 |
+---------------------------------------+

Checklist(Required)

Does it affect the original behavior: No
Has unit tests been added: Yes
Has document been added or modified: Yes
Does it need to update dependencies: No
Are there any changes that cannot be rolled back: No

please support it in vec exec engine too， thank you

I had planned to implement vectorization for this func in another PR. That's all right, I will add vectorization code in this PR.

please support it in vec exec engine too， thank you

I had planned to implement vectorization for this func in another PR. That's all right, I will add vectorization code in this PR.

please support it in vec exec engine too， thank you

I had planned to implement vectorization for this func in another PR. That's all right, I will add vectorization code in this PR.

another PR is OK, thank you.


Hi. - Hi! Friend!

Hi. - Hi! Friend!
Please change the alignment line border style to rounded corners.
Thank you very much for a most awesome theme! 👍🎉

Hi Zhou. Thanks for the suggestion. Could you explain it better? Are you referring to the corners of the blue line (reading indicator)? Which alignment?

This is really a detail... Anyway, here is a preview.

I will have to recalculate the border width using that slider (Style Settings) and maybe eliminate the right reading indicator.

Hi Zhou. Thanks for the suggestion. Could you explain it better? Are you referring to the corners of the blue line (reading indicator)? Which alignment?
The spacing in the second photo is larger because it is an ordered list (indented text)

the corners of the blue line (reading indicator)

Preview 2. The reading indicator will on the left side of the title folding. The headings labels will be left aligned with the text of the titles. This is working, if you increase the width of the indicator (border width) it will be on the left side of the folding title symbol (no overlapping).

If you set the value of the width to 0 (no indicator border)

That's good!👍

Zhou, please check theme version 10.0.0. Let me know if it is working well for you. Please test changing colors and width of the reading indicator. I tested on desktop and mobile. It is working well here.
If it is ok, you can close the issue. If you have other suggestions, open another issue.
All the best

I fixed the tables look in reading mode as well.

No need to change the position, just change the square corners to rounded corners

The previous version ran much better

If I make the position closer to the text, it will overlap with the text folding symbols... I had to change it

Whats the problem? The label could be closer to the reading indicator, like preview 1 image.

If that's the best I can do, then I'd prefer to revert to the previous version!

The current version has compatibility issues with custom styles.

The current version has compatibility issues with custom styles.

Custom style... the user added it, so just change it. The theme can't be compatible with all custom styles the users will eventually add.

Which compatibility issues?

The previous version worked better!

Please check theme version 10.0.1.

Very good! That's how it works, but the rounded corner values could be more refined 0.10~0.15~0.20~0.25~0.30~0.35 ?

Very good! That's how it works, but the rounded corner values could be more refined
 0.10~0.15~0.20~0.25~0.30~0.35~~~0.95~10.0 ?

Thanks. Sorry, but I can't add the rounded corners adjustment.

If I add more it will look like a sphere. It was already calculated.

The rounded corner values could be finer 0.10~0.15~0.20~0.25~0.30~0.35~0.40~0.45~~~~

Ah, do you mean the width? not the rounded rorners.

I added 0.1 increments

yes!👍

I added 0.1 increments. I can easy make 0.05

Width values could be finer 0.10~0.15~0.20~0.25~0.30~0.35~0.40~0.45 ~~~~

Please check version 10.0.2

I'll test the theme in all directions tomorrow, thank you! My friend! 👬🎉

If it is working well. You can close the issue.
All the best

Okay! 👌

Very good! Everything is running well.

Thank you very much. If you have other suggestions, just open other issue.
All the best


Need to use raw strings for parameters passed to regular expressions

Nastygrams at high levels of Python 3 for some uses of "\s+" as default parameters to functions. Replace with raw strings.

Candidate fix coded - which, in tests, removes the nastygrams and still runs properly.

Shipped in v0.6.9.


Move to Maven Central repository

Currently the project is published in JCenter repository. However, starting with Android Gradle Plugin 4.2.0 JCenter is deprecated because it became read-only. All the artifacts should be migrated to Maven Central https://developer.android.com/studio/build/jcenter-migration

I just published v2 in Maven Central a few days ago with minor breaking changes from v1; removal of deprecated APIs, and new namespace (old namespace seems to not serving me well in long run, sorry about that 😅)
If you are not using any APIs that marked as deprecated, then you could just swap to v2 artifact and reimport all import statements.


Horizon 0.20.0 crashes on start

Trying to run horizon-0.20.0 (using https://github.com/stellar/go/releases/download/horizon-v0.20.0/horizon-v0.20.0-linux-amd64.tar.gz) results in below.
Steps:

run migrations UP.
run horizon the same way as Horizon 0.18.0 and earlier versions (except adding Environment="ENABLE_EXPERIMENTAL_INGESTION=true") .

-> Output as below.
panic: (*logrus.Entry) (0xd92540,0xc0001e2050)

goroutine 1 [running]:
github.com/stellar/go/vendor/github.com/sirupsen/logrus.Entry.log(0xc0001107d0, 0xc000105890, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/go/src/github.com/stellar/go/vendor/github.com/sirupsen/logrus/entry.go:112 +0x23f
github.com/stellar/go/vendor/github.com/sirupsen/logrus.(*Entry).Panic(0xc000110870, 0xc0005259f0, 0x1, 0x1)
	/go/src/github.com/stellar/go/vendor/github.com/sirupsen/logrus/entry.go:180 +0xb2
github.com/stellar/go/support/log.(*Entry).Panic(0xc000110870, 0xc0005259f0, 0x1, 0x1)
	/go/src/github.com/stellar/go/support/log/entry.go:130 +0x4b
github.com/stellar/go/support/log.Panic(0xc0005259f0, 0x1, 0x1)
	/go/src/github.com/stellar/go/support/log/main.go:155 +0x4b
github.com/stellar/go/services/horizon/internal.initExpIngester(0xc00014a780, 0xc0000e2040)
	/go/src/github.com/stellar/go/services/horizon/internal/init.go:85 +0x22b
github.com/stellar/go/services/horizon/internal.(*App).init(0xc00014a780)
	/go/src/github.com/stellar/go/services/horizon/internal/app.go:407 +0x785
github.com/stellar/go/services/horizon/internal.NewApp(0xc00004400d, 0x46, 0xc00003e01a, 0x52, 0x7fffc19d5460, 0x2a, 0xc000391190, 0x1, 0x1, 0x1f40, ...)
	/go/src/github.com/stellar/go/services/horizon/internal/app.go:75 +0xe2
github.com/stellar/go/services/horizon/cmd.initApp(0x0)
	/go/src/github.com/stellar/go/services/horizon/cmd/root.go:333 +0x62
github.com/stellar/go/services/horizon/cmd.glob..func11(0x1556780, 0xc0002d6b60, 0x0, 0xd)
	/go/src/github.com/stellar/go/services/horizon/cmd/root.go:28 +0x22
github.com/stellar/go/vendor/github.com/spf13/cobra.(*Command).execute(0x1556780, 0xc0000300f0, 0xd, 0xd, 0x1556780, 0xc0000300f0)
	/go/src/github.com/stellar/go/vendor/github.com/spf13/cobra/command.go:603 +0x241
github.com/stellar/go/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x1556780, 0x2, 0x4, 0x0)
	/go/src/github.com/stellar/go/vendor/github.com/spf13/cobra/command.go:689 +0x2cc
github.com/stellar/go/vendor/github.com/spf13/cobra.(*Command).Execute(0x1556780, 0x407460, 0xc0000440b8)
	/go/src/github.com/stellar/go/vendor/github.com/spf13/cobra/command.go:648 +0x2b
github.com/stellar/go/services/horizon/cmd.Execute()
	/go/src/github.com/stellar/go/services/horizon/cmd/root.go:374 +0x2d
main.main()
	/go/src/github.com/stellar/go/services/horizon/main.go:6 +0x20

Currently running migrations DOWN 2 so I can bring 0.18.0 back online. It seems to take significantly longer than the UP migrations.
@bartekn @tomquisel @tamirms

Marcinx, not sure why the error message is obfuscated but it looks like you
don't have history archive urls set. Check 0.19.0 release notes for an
example.
Trying to run horizon-0.20.0 (using

https://github.com/stellar/go/releases/download/horizon-v0.20.0/horizon-v0.20.0-linux-amd64.tar.gz)
results in below.
Steps:

run migrations UP.
run horizon the same way as Horizon 0.18.0 and earlier versions.

-> Output as below.
panic: (*logrus.Entry) (0xd92540,0xc0001e2050)
goroutine 1 [running]:github.com/stellar/go/vendor/github.com/sirupsen/logrus.Entry.log(0xc0001107d0, 0xc000105890, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/go/src/github.com/stellar/go/vendor/github.com/sirupsen/logrus/entry.go:112 +0x23fgithub.com/stellar/go/vendor/github.com/sirupsen/logrus.(*Entry).Panic(0xc000110870, 0xc0005259f0, 0x1, 0x1)
/go/src/github.com/stellar/go/vendor/github.com/sirupsen/logrus/entry.go:180 +0xb2github.com/stellar/go/support/log.(*Entry).Panic(0xc000110870, 0xc0005259f0, 0x1, 0x1)
/go/src/github.com/stellar/go/support/log/entry.go:130 +0x4bgithub.com/stellar/go/support/log.Panic(0xc0005259f0, 0x1, 0x1)
/go/src/github.com/stellar/go/support/log/main.go:155 +0x4bgithub.com/stellar/go/services/horizon/internal.initExpIngester(0xc00014a780, 0xc0000e2040)
/go/src/github.com/stellar/go/services/horizon/internal/init.go:85 +0x22bgithub.com/stellar/go/services/horizon/internal.(*App).init(0xc00014a780)
/go/src/github.com/stellar/go/services/horizon/internal/app.go:407 +0x785github.com/stellar/go/services/horizon/internal.NewApp(0xc00004400d, 0x46, 0xc00003e01a, 0x52, 0x7fffc19d5460, 0x2a, 0xc000391190, 0x1, 0x1, 0x1f40, ...)
/go/src/github.com/stellar/go/services/horizon/internal/app.go:75 +0xe2github.com/stellar/go/services/horizon/cmd.initApp(0x0)
/go/src/github.com/stellar/go/services/horizon/cmd/root.go:333 +0x62github.com/stellar/go/services/horizon/cmd.glob..func11(0x1556780, 0xc0002d6b60, 0x0, 0xd)
/go/src/github.com/stellar/go/services/horizon/cmd/root.go:28 +0x22github.com/stellar/go/vendor/github.com/spf13/cobra.(*Command).execute(0x1556780, 0xc0000300f0, 0xd, 0xd, 0x1556780, 0xc0000300f0)
/go/src/github.com/stellar/go/vendor/github.com/spf13/cobra/command.go:603 +0x241github.com/stellar/go/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x1556780, 0x2, 0x4, 0x0)
/go/src/github.com/stellar/go/vendor/github.com/spf13/cobra/command.go:689 +0x2ccgithub.com/stellar/go/vendor/github.com/spf13/cobra.(*Command).Execute(0x1556780, 0x407460, 0xc0000440b8)
/go/src/github.com/stellar/go/vendor/github.com/spf13/cobra/command.go:648 +0x2bgithub.com/stellar/go/services/horizon/cmd.Execute()
/go/src/github.com/stellar/go/services/horizon/cmd/root.go:374 +0x2d
main.main()
/go/src/github.com/stellar/go/services/horizon/main.go:6 +0x20
Currently running migrations DOWN 2 so I can bring 0.18.0 back online. It
seems to take significantly longer than the UP migrations.
@bartekn https://github.com/bartekn @tomquisel
https://github.com/tomquisel @tamirms https://github.com/tamirms
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stellar/go/issues/1643?email_source=notifications&email_token=AADRQKWQYCQRLQTSUQYWY5TQGCBNJA5CNFSM4IPEWCD2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHE3LGQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADRQKWPTIAS3X2Q6KX3ZK3QGCBNJANCNFSM4IPEWCDQ
.

Okay, that's possible as we skipped 0.19.0. Thanks for the hint. I will check it out.

Cool! Got Horizon 0.20.0 to run with that. Thanks for the help @bartekn.


Repetition code distance off by one

The X distance of a repetition code generated with stim.Circuit.generated is off by 1 (inputting distance d generates a distance d+1 repetition code).
E.g. rather than getting 2d-1 qubits I get:
>>> import stim
>>> stim.Circuit.generated("repetition_code:memory", distance=3, rounds=1).num_qubits
7
>>> stim.Circuit.generated("repetition_code:memory", distance=5, rounds=1).num_qubits
11

Looks like it could be fixed by subtracting one here.

Hahaha how did I miss that. Will fix for sure.

Great, thanks!

This will be in the next python release (no date atm).


Text displayed for Corporate CLA and Individual CLA should be consistent when templates are not generated

Background

Launch Project Management Console url in dev environment
Login as Project Manager
Click on a project
Click ADD CLA GROUP button
CLA Group popup window is displayed
Enter CLA Group name as 1clagroup
Select check boxes for Corporate CLA and Individual CLA
Click Save

Issue 1
9. Observed that text for Corporate CLA card is displayed in proper case but text for Individual CLA card text is not displayed in proper case. The text style should be consistent

Issue 2
Observed that text for Corporate CLA card is displayed as "No Template Created." but text for Individual CLA card text is displayed as "No template selected.". The text displayed should be consistent as we are generating pdf's for both CCLA and ICLA. Either it should be displayed as "No template selected" for both or for both it should be displayed as "No template generated"

Simple text update

Verified that the text is consistent
Verified in Chrome, Firefox and IE


Threshold value

Hi, it seems the threshold in the evaluation script is set at 0 (line 67: "rating_threshold = 0") but in the comment it says 2 (line 149: "# Only consider relevance scores greater than 2"). I was wondering which value is the correct one to be used? Thanks!

Hi, the correct value to use is rating_threshold = 0. We will correct the comment in line 149. Thank you very much for reporting the issue!


Make Tether be a devDependency instead of a dependency

Hi there,
as Drop.js concatenates the Tether library to create a standalone library file (drop.min.js), we should move (in bower.json) the Tether dependency from "dependencies" to "devDependencies".
These are the advantages:

people that only include Drop.js as a dependency in their projects won't have to download Tether as well. This is especially important in cases where the CI servers are configured not to preserve the bower_components folder, but to checkout all dependencies from scratch in each run (even if it uses a cache).
people who just want to include bower_components/**/*.min.js won't have to explicitly exclude tether.min.js. This is especially important as Drop.js still works when not excluding tether.min.js explicitly. What's really bad in this situation is, that all tether modules are registered twice, slowing down all tether related positioning stuff by a factor of 2.

Yet even better solution:
Leave Tether as a dependency and rewrite Drop.js to NOT include tether itself, but to make use of whatever Tether library is already included in the page. This allows people to be more flexible, e.g. they can decide to use a patched version of Tether, without having to dig into the CoffeScript-compiled version that ships with Drop.js.

Hi again! The recent update actually makes Tether a separate dependency since we decided to no longer bundle (or concat in this case) Tether with Drop. Hopefully the changes reflect your better solution as we feel this is a much better solution as well. Again feel free to let me know if you have any issues :smile_cat:


Edit Readme and update Documentation

Am I allowed to edit the readme yet?

You can edit it, but the ANZ disclaimer must remain for now.


Image weights are not considered while caching

Images with higher weights should be cached the most compared to images with lower weights.

I think there's a problem with how dictionaries are being consumed by oslo config, or I just don't understand how to use dictionary options with oslo config. The strategy code appears to be good by proxy of the unit tests. Going to try to find a work-around to config issue.

Comment above also applies to #61


const AC_DEVICE_NAME

https://github.com/teodoradima/homebridge-samsung-air-conditioner-smart-things/blob/4c6405a9e0c31c89bf0b7dec0ebcab46c082e143/src/samsungApi.ts#L3
Looking at API response, should this change to
const AC_DEVICE_NAME = 'Samsung Room A/C';

After making the above change to the file on my local machine, once I reloaded homebridge the AC units are all found as expected.
Either the AC_DEVICE_NAME needs to be updated to the suggest change, or the code needs adjusting so that more than one AC_DEVICE_NAME can be checked when looking at the api response for legacy AC units.
I believe a firmware update pushed to the AC units changed the reported device name in the api.

I now have two types of Device Name
"name":"Air Conditioner"
and
"name":"Samsung Room A/C"

Not nice, not clean, not best solution, but works.
const AC_DEVICE_NAME = 'Samsung Room A/C';
const AC_DEVICE_NAME_2 = 'Air Conditioner';
    return items.filter(item => item.name === AC_DEVICE_NAME || item.name === AC_DEVICE_NAME_2);

is on /homebridge/node_modules/homebridge-samsung-air-conditioner-smart-things/dist/samsungApi.js

Hi, i've installed this plugin in my hombebridge on raspberry pi. Where i can find the samsungApi.ts file to edit it so the plugin finds my ACs.
thnx.

Just wanted to say thanks @StoreEverything! Total newbie here, just installed Homebridge on an Rpi yesterday and managed to get my Tapo Lights/Plugs, SwitchBot Locks, Ring Cameras/Security devices, Smart Blinds and LG TV up and running alongside all my native HomeKit devices. My Samsung WindFree ACs were the only thing I couldn’t manage to get into HomeKit until I found your advice in this thread.
Just to pay it forward, for those (like me) that don’t know what you’re doing, this fix works perfectly right within the HomeBridge UI with the following steps:

Launch Terminal from the menu (three dots/hamburger) at the upper right corner of your HomeBridge UI.

Type: cd node_modules/homebridge-samsung-air-conditioner-smart-things/dist this just opens the folder/directory where the js file you need to edit is saved. Thanks to @manieridimambro for pointing ne in the right direction.

Type: nano samsungApi.js noting that this is case-sensitive. This will open the text editor in terminal.

Modify the highlighted code, replacing the outdated code as described by @StoreEverything at the start of this thread:

Once you’re done, use the keyboard shortcut ‘Ctrl+X’ to exit the text editor and ‘Y’ to save your edits.

Type exit to finish up in Terminal and restart HomeBridge.

That’s it… You should now see your Samsung AC unit(s) appear in the Home app! This should do the trick, at least until one of the PRs for the plug-in is accepted/published.

Thank you, @StoreEverything for this fix, and @manieridimambro and @FLgator86 for explaining how to implement it. This worked like a charm!

Just wanted to say thanks @StoreEverything! Total newbie here, just installed Homebridge on an Rpi yesterday and managed to get my Tapo Lights/Plugs, SwitchBot Locks, Ring Cameras/Security devices, Smart Blinds and LG TV up and running alongside all my native HomeKit devices. My Samsung WindFree ACs were the only thing I couldn’t manage to get into HomeKit until I found your advice in this thread.
Just to pay it forward, for those (like me) that don’t know what you’re doing, this fix works perfectly right within the HomeBridge UI with the following steps:

Launch Terminal from the menu (three dots/hamburger) at the upper right corner of your HomeBridge UI.
Type: cd node_modules/homebridge-samsung-air-conditioner-smart-things/dist this just opens the folder/directory where the js file you need to edit is saved. Thanks to @manieridimambro for pointing me in the right direction.
Type: nano samsungApi.js noting that this is case-sensitive. This will open the text editor in terminal.
Modify the highlighted code, replacing the outdated code as described by @StoreEverything at the start of this thread:

Once you’re done, use the keyboard shortcut ‘Ctrl+X’ to exit the text editor and ‘Y’ to save your edits.
Type exit to finish up in Terminal and restart HomeBridge.

That’s it… You should now see your Samsung AC unit(s) appear in the Home app! This should do the trick, at least until one of the PRs for the plug-in is accepted/published.

It seems on my side the device name on the API for my aircon is "Samsung-Room-Air-Conditioner". The best approach might be to use the steps above to identify your aircon name and potentially override the constant value using a config value if presented.

Samsung-Room-Air-Conditioner

thank you!
i visited the API devices page (https://api.smartthings.com/v1/devices) and found mine was also "Samsung-Room-Air-Conditioner"
all working now.

simply and clever solution:
const AC_DEVICE_NAMES = ['Samsung Room A/C','Air Conditione'];
...
...
...
return items.filter(item => AC_DEVICE_NAMES.includes(item.name));

@FLgator86 @StoreEverything @armandkamffer Where can I find and edit the file mentioned in you step 2 ?
When I tap the command cd node_modules/homebridge-samsung-air-conditioner-smart-things/dist in my terminal, it doesn’t open the file, instead I get the message "cd: no such file or directory: node_modules/homebridge-samsung-air-conditioner-smart-things/dist"

I found my answer : if you installed Homebridge on MacOS, the file you need to edit (samsungApi.js) is in : /usr/local/lib/node_modules/homebridge-samsung-air-conditioner-smart-things/dist
To find it, you first need to show hidden files in you Finder. To do so you can use (when you are in you Finder) the shortcut : Command + Shift + .

I installed Homebridge on Linux, where can I find and edit the file?

when I paste the command: cd node_modules/homebridge-samsung-air-conditioner-smart-things/dist
i get the messege: bash: cd: node_modules/homebridge-samsung-air-conditioner-smart-things/dist: No such file or directory

I have 3 AC units. All of them used to work fine before. Doing this recommended fix gets one of them working. Any idea how to get the other 2?
thanks

simply and clever solution:
const AC_DEVICE_NAMES = ['Samsung Room A/C','Air Conditione'];
...
...
...
return items.filter(item => AC_DEVICE_NAMES.includes(item.name));

How would I use this to loop through different device names? I have 3 units, called:
"name":"Samsung Room A/C"
"name":"Samsung-Room-Air-Conditioner"
"name":"Samsung-Room-Air-Conditioner"
Thanks

simply and clever solution:
const AC_DEVICE_NAMES = ['Samsung Room A/C','Air Conditione'];
...
...
...
return items.filter(item => AC_DEVICE_NAMES.includes(item.name));

How would I use this to loop through different device names? I have 3 units, called: "name":"Samsung Room A/C" "name":"Samsung-Room-Air-Conditioner" "name":"Samsung-Room-Air-Conditioner"
Thanks

Got it working. The return items.filter line needs to replace the line in the getDevices block.

when I paste the command: cd node_modules/homebridge-samsung-air-conditioner-smart-things/dist
i get the messege: bash: cd: node_modules/homebridge-samsung-air-conditioner-smart-things/dist: No such file or directory

Type: cd /usr/lib/node_modules/homebridge-samsung-air-conditioner-smart-things/dist this just opens the folder/directory where the js file you need to edit is saved. Thanks to @manieridimambro for pointing me in the right direction.
Type: nano samsungApi.js noting that this is case-sensitive. This will open the text editor in terminal.

For me, the change was
const AC_DEVICE_NAME = '[system a/c] Samsung';


PR: Improve cells support in the Editor

Description of Changes

Add a button in one of main toolbars to create a new cell.
Add cell divider to also cross the line numbers.

Issue(s) Resolved

Part of https://github.com/spyder-ide/ux-improvements/issues/30
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@jsbautista

Hi @dalthviz

Preview

@jsbautista, I think you need to merge with master to get make our Linux tests pass.

One last thing to consider, but perhaps for a follow-up PR: should we try to move the code that paints cell dividers on top of panels to the paintEvent method of the base Panel class?

I think that could be a good idea. In that way if more panels are added then they will automatically add the cell line  :+1: Probably we will need to validate self.position to only apply the code to paint the cell line when the panel position is on the LEFT right @ccordoba12 ?

In that way if more panels are added then they will automatically add the cell line +1

Yep, that was my reasoning too.

Probably we will need to validate self.position to only apply the code to paint the cell line when the panel position is on the LEFT right @ccordoba12 ?

I'd say LEFT and RIGHT, just to be safe (users could add panels to the right using our API).

@dalthviz, @jsbautista, I think this is ready to be merged, unless you prefer to make the changes to paintEvent we talked about here too.

@jsbautista will working on the refactor mentioned above here :+1:

Note: this needs a merge with master for the test to pass


Prepare for new lib-webpack release

:shipit:

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.00%. Comparing base (63784c1) to head (1a4052c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   25.00%   25.00%
=======================================
  Files          41       41
  Lines        1220     1220
  Branches      245      245
=======================================
  Hits          305      305
  Misses        899      899
  Partials       16       16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


cephfs-provisioner: Upgrade to 1.1.0-k8s1.10

Upstream Changes:

Update CEPH_VERSION to mimic (https://github.com/kubernetes-incubator/external-storage/pull/841)

Our Changes:

Using image from official repo which contain latest changes (https://quay.io/repository/external_storage/cephfs-provisioner)

ci check this

@hswong3i  Why didn't you consider adding  cephfs-provisioner to Kubespray?

@hswong3i Why didn't you consider adding rbd-provisioner to Kubespray?

@riverzhang Because CephFS support RWX, where RBD only support RWO...
In my use cases for Drupal hosting, multiple Apache and PHP-FPM pods mounting single shared RWX /var/www (i.e. CephFS good for this), where individual MariaDB mount its own RWO /var/lib/mysql and form and multi-master cluster; therefore implementing RBD support is just half-way for me ;-)


Possibility to exclude paths when searching for project files and script files

Possibility to exclude paths when searching for project files and script files. Exclude patterns could be added via OmniSharp Configuration Options.

This looks almost like a duplicate of https://github.com/OmniSharp/omnisharp-roslyn/issues/896?

@filipw, yeah it’s a duplicate. Closing this then..


Add paginator addon into table widget

Frontend Pull Request Description

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have updated change log
[ ] I have been following Definition of done
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new lint warnings
[x] New and existing unit tests pass locally and on CI with my changes
[x] Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Additional Context (if necessary)

I was unable to create proper unit tests for paginator in table widget so I created ticket for it as it took me too much time. https://swicloud.atlassian.net/browse/NUI-6229. Maybe it will make more sense to create UI test once protractor will be exchanged because of migration to newer Angular. It is mentioned in the ticket.

just lint errors, rest are fine for me


mypy: Add annotations to api/integrations/asana/zulip_asana_mirror

Automated message from Dropbox CLA bot
@540KJ, it looks like you've already signed the Dropbox CLA. Thanks!

@540KJ did you mean to close this ?


Package not found in NPM repository

The install fails because the package is not found in the NPM repository.

It was late & I might have made a typo. I copy & pasted into package.json like in the demo.
"@canutin/svelte-currency-input": "latest"


Interpolated transitions are garbage collected on level change

This breaks animations on transitions, causing them to not fade out properly.

Keeping it closed for now until I encounter it again.


DisallowMultipleAssignments false positive when assigning to variable property of an object in an array

Describe the bug
False positive on a complex statement that suggests the assignment is not the first block of code.
Try assigning a value to a property of an object contained in an (indexed) array.
Code sample
<?php

$filtered_results[ $i ]->$field = $result;

Custom ruleset
Can be reproduced with the WordPress-Extra or Squiz rulesets, or any combination using the Squiz.PHP.DisallowMultipleAssignments rule.
To reproduce
Steps to reproduce the behavior:

Create a file called test.php with the code sample above...
Run phpcs test.php --standard=Squiz --sniffs=Squiz.PHP.DisallowMultipleAssignments -s or similar
See error message displayed

3 | ERROR | Assignments must be the first block of code on a line (Squiz.PHP.DisallowMultipleAssignments.Found)

Expected behavior
No violation reported.
Versions (please complete the following information)

Operating System
MacOS 14.6.1

PHP version
7.4

PHP_CodeSniffer version
3.9.2

Standard
Squiz

Install type
Composer

Additional context
None of the tests seem to have an assignment to a property of an object in an array.
Please confirm

[x] I have searched the issue list and am not opening a duplicate issue.
[x] I have read the Contribution Guidelines and this is not a support question.
[x] I confirm that this bug is a bug in PHP_CodeSniffer and not in one of the external standards.
[x] I have verified the issue still exists in the master branch of PHP_CodeSniffer.

@GaryJones Thanks for reporting this. I can confirm the issue, which appears to be caused by the variable variable, i.e. the variable for the property name:
$filtered_results[] = $result;
$filtered_results[ $i ] = $result;

$filtered_results->field = $result;
$filtered_results->$field = $result;

$filtered_results[ $i ]->field = $result;
$filtered_results[ $i ]->$field = $result; // <- This is the bug, all other test cases in this code sample are handled correctly.

@GaryJones PR #610 should fix this. Testing appreciated.


403 Implementation using ACS Commons Error Handling

Hi,
I have implemented the custom error handling using ACS-Commons and I get re-redirected to my 404 page when a 404 error occurs.
I have also created a custom page for 403, just like I created for 404.
I have configured a test page with CUG (Closed User Group, I am not a part of the group applied as a part of CUG).
I should now be redirected to a 403 page in this scenario, but this does not happen.
I have followed the steps mentioned in the video (https://www.youtube.com/watch?time_continue=1&v=w4P9T_miX8Q)
Is 403 error handling not supported by ACS-Commons or am I missing something here?
AEM Version - 6.2.0 (Vanilla Instance)
ACS AEM Commons Version: 3.6.2

What’s the response status on the page? 403 or 404?  Error page handler uses whatever status code sling provides, so unless 404 is your fallback/default page, if check to make sure aem/sling is resolving the request as a 403 (and not a 404)


Multiple layouts with different dependencies (js, css) minified

Hi
Is there an easy option to have multiple layouts files with different dependencies (js and css) minified?
Configuring two pipelines seams overwhelming.

Hi, did you see this? https://github.com/jayfar/sails.js-use-different-layout-with-different-javascript-files

@eriksape thanks for the link!
@daniel79 Thanks for using Sails!  FYI, this forum is for reporting bugs on the Sails core.  Please direct future support requests to our Google Group, chat room or StackOverflow.

@eriksape thanks!


pal implementation for web/service workers

Following this  discussion you may want to consider a PAL implementation specifically for web workers.
The requirement came up while trying to decorate a worker's class as transient.

Yes, absolutely. It's not at the top of our list, but if someone from the community wants to start in on it, we'd be glad to help them along.

We've got this :)


Example in README files is not up-to-date

Hi Cuong,
The example in README file is not updated, the old library name QConnectionLibrary is still used.
Thank you,
Ngoan

Hi @milanac030988 ,
please fix this with high priority.
Thank you,
Thomas

Hi  @milanac030988 ,
what is the status of this issue?
Thank you,
Thomas

Hello @test-fullautomation,
Fixed by Fixed in -Update Readme by milanac030988 · Pull Request #44 · test-fullautomation/robotframework-qconnect-base
Thank you,
Cuong


Release binaries should strip debug symbols

The go command should be additionally invoked with:
go build -trimpath -ldflags '-s -w'

Related to #16. With these flags, the binary shrinks from 7.6 MiB to 5.4 MiB.


Generate warnings when incorrectly accessing Transform or GlobalTransform

What problem does this solve or what need does it fill?
Updating Transform late or reading GlobalTransform early are very common issues that result in a number of help requests and bugs in general.
What solution would you like?
Generate a warning in debug mode any time a Transform is ever mutated after GlobalTransform is propagated or a GlobalTransform is accessed before it has been updated that frame.
What alternative(s) have you considered?

Do nothing, accept this as a source of error.
Develop some general method of specifying component dependencies.
Keep positions from the last frame in GlobalTransform and propagate Transforms at the end of the frame to ensure that worst case, systems accessing it will be a frame out of date, but still work. This could be accompanied with an error message.

Something else to consider is that most User Code should only read from GlobalTransform, as the Value is managed and overrriden by Bevy itself.

Generate a warning in debug mode

With the general recommendation being "run in release", I wonder if it wouldn't be better to add a "debug" feature enabled by default (probably with a better name though... "training-wheels"? "clippy"?)
I think disabling default features to pick only the ones you want when you release a game is the good thing to do (anyway it's what I do)

Something else to consider is that most User Code should only read from GlobalTransform, as its Values are managed and overrriden by Bevy itself.

#1460 should take care of that.

For reference, this should be improved by #68.

GlobalTransform doesn't have a Transform field anymore, and since, #7134 it's not even possible to mutate it.
The 1-frame lag issue is still an open question, but  it seems very difficult to design a system to catch it and warn users about it.


Test gravity and "move and slide"

During Godot v4 migration, the gravity feature in GOAT was not tested. It should be verified that it still works as expected.

Gravity was tested and it works fine, but it should also be added to the demo game, as a showcase. Currently, there aren't many places in "2 minute adventure" where steps / slope could be placed. This might call for a different GOAT example scene.


fix NumericIndex for nightly

Nightly builds were failing because NumericIndex is removed for 2.0, so this allows it to work for 1.5.x, but removes it from testing for 2.0.
Once 2.0 is released, then we can remove NumericIndex in the PYI and tests.

Thanks @Dr-Irv


[yaml] add use-case example

Adds 2 simple use-case examples to examples catalog.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @liferoad

R: @damccorm


Autoprior: numpy.float64' object has no attribute 'to'

Hi all,
I'm trying to use pysersic to fit a sersic profile to synthetic data. I have unitless 2D numpy arrays for the image, mask, and sig files, and I am using a psf generated from WebbPSF for my PSF file.
`from pysersic.results import plot_image
from pysersic import check_input_data
#########  Image array is sersic_prof2d_convolved_mock
######### Sig array is rms_image
######### PSF array is rms_image,psf[0].data
mask2 = sersic_prof2d_convolved_mock < 0 # All True mask with shape = np.shape(sersic_prof2d_convolved_mock)
fig, ax = plot_image(sersic_prof2d_convolved_mock,mask2,rms_image,psf[0].data)
check_input_data(data=sersic_prof2d_convolved_mock,rms=rms_image,psf=psf[0].data,mask=mask2)
######### Next step
from pysersic.priors import autoprior
prior  = autoprior(image = sersic_prof2d_convolved_mock, profile_type = 'sersic', sky_type = 'none')`
This input passes the check_input command, but crashes while running autoprior with the error message:
`ttributeError                            Traceback (most recent call last)
Cell In[106], line 16
13 ######### Next step
14 from pysersic.priors import autoprior
---> 16 prior  = autoprior(image = sersic_prof2d_convolved_mock, profile_type = 'sersic', sky_type = 'none')
File ~/miniforge3/lib/python3.10/site-packages/pysersic/priors.py:807, in autoprior(image, profile_type, mask, sky_type)
788 def autoprior(image: np.array, profile_type: 'str', mask:np.array =None, sky_type: str = 'none') -> PySersicSourcePrior:
789     """Simple wrapper function to generate a prior using the built-in defaults. This can be used as a starting place but may not work for all sources
790
791     Parameters
(...)
805         Prior object that can be used in initializing FitSingle
806     """
--> 807     props = SourceProperties(image = image, mask = mask)
808     prior = props.generate_prior(profile_type = profile_type, sky_type = sky_type)
809     return prior
File ~/miniforge3/lib/python3.10/site-packages/pysersic/priors.py:526, in SourceProperties.init(self, image, mask)
524 else:
525     self.cat = data_properties(self.image)
--> 526 _ = self.measure_properties()
File ~/miniforge3/lib/python3.10/site-packages/pysersic/priors.py:537, in SourceProperties.measure_properties(self, **kwargs)
529 """Measure default properties of the source
530
531 Returns
(...)
534     returns self
535 """
536 self.set_flux_guess(**kwargs)
--> 537 self.set_r_eff_guess(**kwargs)
538 self.set_theta_guess(**kwargs)
539 self.set_position_guess(**kwargs)
File ~/miniforge3/lib/python3.10/site-packages/pysersic/priors.py:613, in SourceProperties.set_r_eff_guess(self, r_eff_guess, r_eff_guess_err, **kwargs)
598 """Measure or set guess for effective radius. If no estimate is provided, the r_eff of the source in estimated using photutils
599
600 Parameters
(...)
610     returns self
611 """
612 if r_eff_guess is None:
--> 613     r_eff_guess = self.cat.fluxfrac_radius(0.5).to(u.pixel).value
615 if r_eff_guess_err is not None:
616     self.r_eff_guess_err = r_eff_guess_err
AttributeError: 'numpy.float64' object has no attribute 'to'`
Is this a compatibility issue between the code's dependencies and my installed packages?

This looks like a change in the way photutils  "data_properties" table generation works between some versions. In our code, (and in the environment I currently run pysersic in), data_properties ) returns a SourceCatalog for which the fluxfrac_radius for some value is an astropy.Quantity, hence the use of .to() to ensure it is in pixels, then .value to extract the float.
In your case, it appears the fluxfrac_radius() method is returning a float directly, meaning there is no .to() method (which is only for quantities).
Could you try using
import photutils
photutils.__version__

and see which you have? For reference, we are currently on 1.11.0.
I noticed photutils' latest version is now 1.12.0, so it's possible the change happened there. If your version is older, than 1.11.0, I recommend upgrading to that version in your pysersic environment; if you have the latest 1.12.0, then let me know and I'll go through and ensure that pysersic reflects any breaking changes.
(that might take me a day or two, so you could always downgrade to 1.11.0 in your env for now as well).

Thank you for your speedy response!
I was running photutils verison 1.1.0. I just updated to 1.11.0, though and I'm getting the same error message.

Photutils and astropy are pretty intimately linked, so maybe check that
too. The easiest way to really confirm is to make a new conda environment
using the environment.yml file we provide in the repo — pysersic is
currently confirmed to be working in the environment made by that file
(which is python3.11 and all packages upgraded as much as possible).
Let me know if you still have any issues!
On Fri, Apr 19, 2024 at 10:57 PM Kelly Whalen @.***>
wrote:

Thank you for your speedy response!
I was running photutils verison 1.1.0. I just updated to 1.11.0, though
and I'm getting the same error message.
—
Reply to this email directly, view it on GitHub
https://github.com/pysersic/pysersic/issues/54#issuecomment-2067524898,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACD6XXHH7EC627LDVSYHMHLY6HKQVAVCNFSM6AAAAABGQDARYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGUZDIOBZHA
.
You are receiving this because you commented.Message ID:
@.***>

Yes, it worked in the new conda environment! Thank you!

Great! If you check which versions of the few core packages (astropy, numpy etc), you may determine you can easily get your normal environment set up so you don't have to activate one just for pysersic.
Closing this as complete!


[4.0] IRGen: An @objc protocol method call's self argument behaves li…

…ke a class method's
rdar://34847037
SR-6068

Explanation: The compiler did not handle the self argument emission for calls to objective c methods where self argument type is a objective c existential correctly resulting in a compiler crash.

Scope: I believe this to be a longer standing bug

Risk: Low, the code change should only affect objective c method calls with objc existential self arguments

Testing: A test case added to the Swift regression suite

@swift-ci Please test

This is why I was working on the objc_method SIL instruction recently... once we use it for ObjC protocol calls, we can remove some special hacks and use witness_method for Swift protocols only. :-)

@swift-ci Please test source compatibility


How to scale Microweber on the cloud (AWS) ?

I'm sure everybody here knows the classic structure of a cloud platform:
Multiple instances of servers are connected to a shared Database and the traffic is controlled by the load balancer.

Our app is interfacing with Microweber by the database. This means we are creating/updating new products directly from the database without Microweber "admin panel". We have to execute a trigger to flush the cache in the file system to view updated data.
Problems I'm faced with:

Caching File System: Microweber stores its data in the DB but makes a copy on the local disk. This means If I make a change in one server every other server won't be notified to refresh its cache and will display old data. Does Microweber check first with the DB if data was changed?

Is there a field in the database I can update to force the flushing of the cache in all instances?

Multi-tenant: Every server has its own copy of /config/tenantWebsite (where the tenants are stored). This means, to add a new tenant, I have to manually connect to every instance and update the /config. I know the Microweber Team have created their own multi-tenant cloud service.

How did they manage to add new tenants on-the-fly over multiple servers?
Thank you for your time! :)

Hi,
For scaling at the moment there are few things needed

For database: You need to have shared database instance and edit the access details in config/database.php
For storage: You need to use shared storage for the config and media, either by NFS or some other method. The folders that needs to be shared across all instances are config and userfiles/media  . All other folders can be considered ephemeral and can be safely deleted
For cache you need Redis or some cache driver that support cache tagging. Edit the file config/cache.php and set the details


chore: set vscode default formatter to prettier

I formatted the code using the default TS formatter again in https://github.com/immerjs/immer/pull/1007
Adding this as a separate PR to help avoid this issue for everyone

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.558%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
786

Relevant Lines:
794

💛  - Coveralls


How do I filter on events from contracts?

I've been trying for hours to listen to events from contracts. There is nothing in the docs on how it is done. Please tell me how.
ethjs-filter
Before opening a new issue, please take a moment to review our community guidelines to make the contribution process easy and effective for everyone involved.
Before opening a new issue, you may find an answer in already closed issues:
https://github.com/ethjs/ethjs-filter/issues?q=is%3Aissue+is%3Aclosed
Issue Type

[ ] Bug (https://github.com/ethjs/ethjs-filter/blob/master/.github/CONTRIBUTING.md#bug-reports)
[ ] Feature (https://github.com/ethjs/ethjs-filter/blob/master/.github/CONTRIBUTING.md#feature-requests)

Description
(Add images if possible)
Steps to reproduce
(Add link to a demo on https://jsfiddle.net or similar if possible)
Versions

Node/NPM:
Browser:

Also, what options do I have for the filters? How do options work? Could the examples be a bit more fleshed out?
I love ETHJS other than that.

@wahlforss thanks! Okay, so contract filtering is fairly straight forward and you can use it and learn more about it by using/viewing ethjs-contract.
Module:
https://github.com/ethjs/ethjs-contract
API Example:
const filter = simpleStore.SetComplete()
.new({ toBlock: 'latest' }, (error, result) => {
  // result null <BigNumber ...> filterId
});
filter.watch((err, result) => {
  // result null FilterResult {...}
});
filter.uninstall()
.then(result) => {
  // result Boolean
});

The contract object uses ethjs-filter inside it.
The filter code is available here, you can see we produce the solidity event SHA3 signature, that filter for it.
https://github.com/ethjs/ethjs-contract/blob/master/src/index.js#L90-L99
Lastly, ethjs-filter does not work with stateless API's like the infura endpoint. But will work with extensions like metamask that polyfill the stateful API with a stateless version.
We will soon address this by providing stateless API filtering, that does not require the node/endpoint to keep track of events.
Thanks for use ETHJS!

How do I listen to the event “NewBet” on my end?
Alfred Wahlforss
<EMAIL_ADDRESS>+46 70 587 21 61

On 11 Dec 2017, at 18:58, Nick Dodson<EMAIL_ADDRESS>wrote:
@wahlforss https://github.com/wahlforss thanks! Okay, so contract filtering is fairly straight forward and you can use it and learn more about it by using/viewing ethjs-contract.
Module:
https://github.com/ethjs/ethjs-contract https://github.com/ethjs/ethjs-contract
API Example:
const filter = simpleStore.SetComplete()
.new({ toBlock: 'latest' }, (error, result) => {
// result null <BigNumber ...> filterId
});
filter.watch((err, result) => {
// result null FilterResult {...}
});
filter.uninstall()
.then(result) => {
// result Boolean
});
The contract object uses ethjs-filter inside it.
The filter code is available here, you can see we produce the solidity event SHA3 signature, that filter for it.
https://github.com/ethjs/ethjs-contract/blob/master/src/index.js#L90-L99 https://github.com/ethjs/ethjs-contract/blob/master/src/index.js#L90-L99
Lastly, ethjs-filter does not work with stateless API's like the infura endpoint. But will work with extensions like metamask that polyfill the stateful API with a stateless version.
We will soon address this by providing stateless API filtering, that does not require the node/endpoint to keep track of events.
Thanks for use ETHJS!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ethjs/ethjs-filter/issues/4#issuecomment-350805178, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEeWZ4qzfuIeTagTL00wRLVO5IjgZtfks5s_W1hgaJpZM4Q9s6H.

See the example above (similar to web3).

Setup Eth instance
Setup your contract object
Listen for your event

Example here using ethjs-query + ethjs-contract:
https://github.com/ethjs/ethjs-contract#usage
and example here using ethjs interface module.
https://github.com/ethjs/ethjs#usage
So it would be something like:
yourContract.NewBet()
.new({ toBlock: 'latest' }, (error, result) => {
  // result null <BigNumber ...> filterId
});
filter.watch((err, result) => {
  // result null FilterResult {...}
});
filter.uninstall()
.then(result) => {
  // result Boolean
});

More examples here in the ethjs user-guide.
https://github.com/ethjs/ethjs/blob/master/docs/user-guide.md#contract-instance

Hello,
I can't make this example work either.

On the promise object, there is no function watch: TypeError: filter.watch is not a function
On the other hand, I can do
let filter = myContract.Event().watch((err, res) => { console.log(res) })
But the events are not captured, and filter.filterId is null.
Any idea?

Let me look into this stat. I'll get back to you later today. Thanks!
Sent from my iPhone

On Dec 18, 2017, at 8:03 AM, Louis<EMAIL_ADDRESS>wrote:
Hello,
I can't make this example work either.

On the promise object, there is no function watch: TypeError: filter.watch is not a function
On the other hand, I can do
let filter = myContract.Event().watch((err, res) => { console.log(res) })
But the events are not captured, and filter.filterId is null.
Any idea?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

So it should be that you setup the event then watch.
So:
const someEvent = contract.Event();
someEvent.new()
someEvent.watch()
Try this format and let me know how it goes.
Sent from my iPhone

On Dec 18, 2017, at 8:03 AM, Louis<EMAIL_ADDRESS>wrote:
Hello,
I can't make this example work either.

On the promise object, there is no function watch: TypeError: filter.watch is not a function
On the other hand, I can do
let filter = myContract.Event().watch((err, res) => { console.log(res) })
But the events are not captured, and filter.filterId is null.
Any idea?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@lgaroche @wahlforss did you manage to get things working here?

@SilentCicero the above mentioned format works
const someEvent = contract.Event();
someEvent.new()
someEvent.watch((err, result) => {
  if(result[0]) {
    // do something
  }
});

Though I saw 2 things unidentical:

it's the callback, not a promise
the event watch keeping update every seconds with empty result, need extra filter(as above) for it.

That could be easily fixed, would you like to make a pr to address it?
Sent from my iPhone

On Apr 17, 2018, at 11:35 PM, gasolin<EMAIL_ADDRESS>wrote:
@SilentCicero the above mentioned format works
const someEvent = contract.Event();
someEvent.new()
someEvent.watch((err, result) => {
if(result[0]) {
// do something
}
});
Though I saw 2 things unidentical:
it's the callback, not a promise
the event watch keeping update every seconds with empty result, need extra filter(as above) for it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@SilentCicero I found the event watch keeping update every seconds issue might be related to
https://github.com/ethjs/ethjs-filter/blob/master/src/index.js#L48
Moving watcher.callback into (Array.isArray(decodedChangeResults) && changeResult.length > 0) might fix that issue (haven't test that)

Error: Invalid params: unknown field 'to', expected one of 'fromBlock', 'toBlock', 'address', 'topics', 'limit'.","code":-32603}
i get this error too :<  did the api change?  seem like 'to' should be 'address'


Markdown example does not work with myst_parser>=0.18

The example from https://github.com/widgetti/reacton#markdown-component-example does not work with myst_parser>=0.18  since the to_html function has been removed from the python api (see https://github.com/executablebooks/MyST-Parser/blob/28725fceb8e1e117cb247b06a267f82c501ce527/CHANGELOG.md#breaking-changes)
One solution:
@reacton.component
def Markdown(md: str):
    from markdown_it.renderer import RendererHTML
    from myst_parser.config.main import MdParserConfig
    from myst_parser.parsers.mdit import create_md_parser
    md_parser = create_md_parser(MdParserConfig(), RendererHTML)
    html = md_parser.render(md)
    return w.HTML(value=html)

BR, Alex

(FYI, sorry for the late reply, just noticed I didn't get GH notifications from the repo)
I just fixed this in https://github.com/widgetti/reacton/commit/af8b6e0291985fc2a080717a911f8b0648282071 , and also included a Markdown example at:
Markdown example live with Jupyter lite


chore: watch mode

Fixes https://github.com/stackblitz/tutorialkit/issues/128

There's still an issue on @tutorialkit/astro > @tutorialkit/react-components HMR. The packages/template sees the update of @tutorialkit/react-components and HMR kicks in, but it's served from cached optimized deps from .vite/deps. Restarting Vite/Astro server of packages/template with --force works.
I've tried all kinds of combinations of optimizeDeps.exclude but so far nothing works.

There's still an issue on @tutorialkit/astro > @tutorialkit/react-components HMR.

Adding optimizeDeps on packages/astro seems to fix it - exactly as TUTORIALKIT_DEV does! 🥳
I tried to force it from the packages/template using @tutorialkit/astro > @tutorialkit/react-components in optimizeDeps. It should work, in theory at least.


[BUG] Fix width of first table columns in the docs

The width of the first column of some tables in the docs is too large, for some reason that I don't understand.
By default, Sphinx seems to set column widths based on the relative sizes of the actual columns in .rst format in the source, which is weird. But, that doesn't explain why the first columns are too big in the screenshots below.
The pattern below was successfully used in various places in the docs to override the default column sizing described above. However, that's not having any effect on the tables in the screenshots below, either...
Perhaps some CSS is getting in the way somewhere? I need help on this one.
.. table::
    :widths: 20 20 40 20

    <rst-table-contents>

Some borked tables in the docs:

This appears to be due to a rule introduced in c9bb15f83 making the first cells of all tables 70% wide. This is likely treated as a ratio instead of an absolute measurement - e.g. the column widths in the first table ("media type") above have a 70:30:40 ratio.
For reference, without that rule, here's what all of the autodoc-generated pages look like:

These are given 10% and 90% column widths for some reason - maybe it's possible to change on the backend instead.

Hmm, nice find. I wonder why the 70% rule was introduced. That PR was from when Tyler was working on tweaking how the API docs look. Perhaps he was adjusting how these tables are rendered https://voxel51.com/docs/fiftyone/api/fiftyone.core.dataset.html but didn't realize other changes that were happening.

It was introduced to stop some tables from rendering like in my screenshot above. It seems that the 10%, 90% widths of those tables are hardcoded in the sphinx.ext.autosummary package, but they ordinarily look fine - the autosummary documentation has a table with these rules, for instance:

I've tracked down one rule in pytorch's theme.css that is causing part of the issue, but there is at least one other that I haven't found yet.


Dynamically load Bard Config

The Bard version is now dynamically loaded instead of being hardcoded in Bard.ts.
Fixed the dev script in package.json

Perfect. Merging.


Merge learning - genetic algorithm implementation

I propose to choose squash and merge, due to large amount of code refactoring and code movement between class. What do you think?

Rebase with master done


PMEC partner updates for GA

@KumudD
Can you review the proposed changes? They'll need to be moved into the private repo for staging. Let us know if you'd like assistance with that.
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Court72 Thanks for your offer to help moving this PR to the private repo. Please can you go ahead and do so. Thanks!
cc @liumichelle


Coveralls does not work any more

After merging #2104 (specifically after adding java11 to the travis jobs) coveralls does not seem to work anymore.
It's just displaying "Expected — Waiting for status to be reported" (e.g. on #2124), but that's it. I don't know where to get more information what's wrong here.
@kwin, @badvision, @davidjgonzalez : any idea where to look?

IMHO you need to add the webhook to travis.yaml as described in https://docs.coveralls.io/parallel-build-webhook

hmpf, much simpler (https://travis-ci.org/Adobe-Consulting-Services/acs-aem-commons/jobs/618131076#L8685)
$ if [ "$POST_COVERAGE" == "true" ]; then mvn -Pcoverage clean package coveralls:report -Dlogback.configurationFile=bundle/src/test/resources/logback-test-no-logging.xml fi

/home/travis/.travis/functions: eval: line 110: syntax error: unexpected end of file

It seems I made a mistake there.

fixed in #2126


feat(@vtmn/svelte): add VtmnModal component

Add a new component svelte VtmnModal

Add tests on the component
Workaround for a css issue (#1039)
Add animation properties set at true by default. You can disable the show animation. We have some issues with this one on chrome.

Need to tests if we can initialize the modal on the body for all the application

So ... I do some changes on the component.

Add disableAnimation, why ? See this one
-- With class show on the modal

-- Wihout class show on the modal

So, animation will infect the z-index.
Another very interesting addition only on svelte :

Add automatically a <style> to hide the overflow on body when the modal is open ! 🔥

when we click on the buttons inside your example modal?

I've tried to do some changes on the story, but args are only one way binding. Storybook don't handle to change this values on the documentation.


Quit working entirely [SELECT "SMS"; response: #6# [NO [NONEXISTENT]]

I have used this app for years and only had one previous issue. My problem now is that it quit working on my Samsung Galaxy S5 despite having worked on that very phone for the last year. I only recently noticed things weren't backing up when I needed to find an important text. All previously backed up information is gone and both call log and SMS Folders empty.
I get Error during backup/restore: Command: SELECT "SMS"; response: #6# [NO [NONEXISTENT], Unknown Mailbox: SMS (failure)
I tried googling for a fix and have tried all of the following:

Verified my gmail had IMAP enabled
Verified my labels had IMAP enabled
Verified the call log and SMS labels were there and both spelt and capitalized properly
Uninstalled SMS Backup+ and reinstalled it

@missmorte could you try out the latest beta 1.5.11? If that doesn't work, could you provide the log as discussed in https://github.com/jberkel/sms-backup-plus#faq-general-file-bug-report?

Ah!
My apologies, it is now working, I had disabled IMAP for SMS and have now reneabled and it works fine.
Thank you for this great piece of software, it has helped me out many times.


File.StoreXXX methods do not flush on write (and there is no flush method)

Godot version:
3.1.1 (Mono)
OS/device including version:
Windows 10
Issue description:
When calling the store methods of file, e.g store_string(...) the content is not automatically flushed. There is also no method to do it manually instead. If the application is killed (GDScript), or even worse under Mono, just graceful exited, the unflushed content will not be written.
Closing the file before exit correctly persist the writes.
The GDScript implementation has decent cleanup and will close open files on application exit, and this will flush the contents. If you kill the application, rather than doing a graceful close, then the content will not be written.
Under Mono the behaviour is worse. You can simply close the application (e.g by clicking the X), and the un-flushed data will be lost.
Steps to reproduce:
(Mono)

Open a file using the File class
Write some content, e.g. using the StoreString method
Either (GDSscript) kill the running project or (Mono) simply exit the program with the X window button.
Examine the file for the stored content - it will not have been stored.

Minimal reproduction project:
Project includes GDScript and Mono versions for testing. Just attach whichever script version you need.
Testing-FileFlush.zip

(Also relevant: https://github.com/godotengine/godot/issues/29043)

Separate from Mono, there's probably scope to have a discussion on whether Godot should implement a flush method anyway. I can see legit scenarios where you want to ensure data is written in real time, especially in the event of a crash (e.g. a log file), or where you don't have full control over the lifecycle (e.g. mobile apps).

Absolutely! Just to be clear, thats why I added both the mono and core labels. :)

I just saw a web project that simply saves a string followed by file close. Calling load right seemed to fetch the updated values but re-loading the tab then loading the value more often than not fails to get the updated value and pulls a previously persisted value. If you waited 10 seconds or more before clicking refresh it would "usually' work but still wasn't reliable.

I had another use-case today to write log files, so I've been looking at this again.
FileAccess (the abstraction used by all the specific file implementations) already exposes a public flush() method. The path of least resistance would be to just add core bindings so the method is exposed to scripts. It's not clear to me however if this is the "right" thing to do. The concept of flushing doesn't always make sense.
Both encrypted and compressed implementations do not support flushing. They are both designed having their content written to a buffer, and then on close the buffer is written to disk in either the compressed or encrypted format. FileAccessNetwork also has no concept of flushing. The behaviour of each seems to vary - encrypted and compressed both silently ignore the flush operation, whilst network will error.
Any work on this should probably make the behaviours consistent as part of the change. My preference would be to expose the flush() method with a new binding, and change all the cases where flush() makes no sense to explicitly error.
This is my preference, but I'd like to get some thoughts on this before I go ahead and patch it.
Alternatively we could leave as is, and encourage developers to use File access as short lived only. This would only require documentation changes rather than implementation. I can't think of a use-case outside of logging where write-on-close would be a significant problem if documented.

Wrong button ^^

The use-case is all file systems operations MUST either work every time or return an error.
I've been chasing this problem for days. My game allows the player to save the current state and exit. The save works intermittently if the player exits the game (or web page) quickly. It is especially bad on HTML5 exports (tried multiple browsers - same behavior). Have experienced the same problem with Android app also.
We really need the ability to flush file operations manually because the automatic cache flush is unreliable in real world applications.
Code:
func save_player_data(sdata:Dictionary)->bool:
	var fd:File = File.new();
	var ferr:int = fd.open(PLAYER_DATA_FILE, File.WRITE);
	if ferr != OK:
		return false;
	var pdata:String = to_json(sdata);
	fd.store_line(pdata);
	fd.close();
	return true;

I have a web export running on an IP restricted site that demonstrates the problem. If someone wants to see the problem first hand, please email maps.erpiv at homebuilt-lan.com with the IP you'll use to access the site and I'll add it to the authorized list then send you the URL for the game.
To Reproduce:

Browse to the game site (I'll send you the web address after your IP is authorized)
Click "Starting Line"
Click "Start Run"
Click "Suspend Run" at the bottom of the game board
Immediately close the browser
Browse to the game site again

If you see the main page then the player data saved did not get flushed.
Repeat the above except wait 10 seconds before closing the browser. When you browse to the site again you'll see the Resume/Discard scene. For what it's worth, if you discard this time and immediately close the browser, the saved state will still be there when you re-enter the game. Discard then wait 10 seconds before closing the browser and the saved game state will be gone.
Thanks!

I've put further work on my game on hold until this problem is solved. I can't publish it if the game_state save feature is unreliable.
Suggestion: Rather than expose a flush() method, add a synchronous_write property to File and Dictionary that forces an immediate flush on all write operations. It can default to False. Add a warning to the docs about performance impact when synchronous write is used.
Thank you!

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


add urlJoin function

Pull Request Test Coverage Report for Build 247

15 of 18 (83.33%)  changed or added relevant lines in 5 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.2%) to 84.697%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

index.js
6
9
66.67%

Files with Coverage Reduction
New Missed Lines
%

lib/refresh.js
2
90.32%

lib/login.js
2
90.32%

Totals

Change from base Build 242:
-1.2%

Covered Lines:
226

Relevant Lines:
264

💛  - Coveralls

SInce we are now doing URL canonicalization as a result of feedback of people making mistakes in URLs  I would like you all to consider #50 along with this which I have personally encountered.
#50 might not be the the most general as it converts http to https which happens to be relevant in our particular setup. More general would be to get the redirect from the HTTP response.
@daniyarchambylov @fgimenez what do you think? @daniyarchambylov would you be willing to shepard this through? If so, later I will update the JIRA ticket to include this.


Use "aws eks get-token" instead of "aws-iam-authenticator"

Use aws eks get-token instead of aws-iam-authenticator
Since AWS CLI version 1.16.156, aws-iam-authenticator is no longer needed to obtain an auth token for the EKS cluster. This can be performed using awscli directly with aws eks get-token. (reference)
I propose changing the default value of kubeconfig_aws_authenticator_command and kubeconfig_aws_authenticator_command_args to:
  kubeconfig_aws_authenticator_command = "aws"
  kubeconfig_aws_authenticator_command_args = [
    "--region",
    data.aws_region.this.name,
    "eks",
    "get-token",
    "--cluster-name",
    local.cluster_name
  ]
}

I'm submitting a...

[ ] bug report
[x] feature request
[ ] support request - read the FAQ first!
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
External dependency on aws-iam-authenticator tool causes terraform apply to fail when not installed.
This dependency is not clearly indicated in the readme.
If this is a bug, how to reproduce? Please include a code sample if relevant.
Using this module without having installed aws-iam-authenticator will throw an error while provisioning the cluster.
What's the expected behavior?
No external dependency on aws-iam-authenticator.
Are you able to fix this problem and submit a PR? Link here if you have already.
Yes
Environment details

Affected module version: v10.0.0
OS: Mac OS Catalina 10.15.4
Terraform version: v0.12.26

Any other relevant info
I'm not sure which tool is more common for this purpose, but our team uses awscli whenever possible. Since this functionality is now present in awscli >= 1.16.156 (we are using v2.0.19), it might be worthwhile to use it instead of aws-iam-authenticator.
In any case, whether depending on awscli or aws-iam-authenticator, it might be a good idea to clearly indicate external dependencies in the module readme.

what error is thrown?

The error that is thrown:
→ kubectl get nodes
Unable to connect to the server: getting credentials: exec: executable aws-iam-authenticator not found
It looks like you are trying to use a client-go credential plugin that is not installed.
To learn more about this feature, consult the documentation available at:
      https://kubernetes.io/docs/reference/access-authn-authz/authentication/#client-go-credential-plugins

You'll get an error executing commands with the generated kubeconfig, that encourage you to download aws-iam-authenticator. However, with any aws-cli from the last year and a half, this additional tool is unnecessary, aws eks get-token does what's needed.

Any news on this?

How you can re-open this issue?

If it helps promote this issue, I've been using the example implementation from the OP (with a very minor change to region for our usecase) for about 10 months and it's working perfectly for us. None of us have aws-iam-authenticator installed.
  kubeconfig_aws_authenticator_command = "aws"

  kubeconfig_aws_authenticator_command_args = [
    "--region",
    var.region,
    "eks",
    "get-token",
    "--cluster-name",
    local.kubernetes_cluster
  ]


straight line in short distance

Hello,
i'm trying to use the plugin to draw arcs on a map.
 var path = L.Polyline.Arc(
[ 48.8611473, 2.33802768704666 ] , [ 41.3751984992, 2.12036451854 ], {
            vertices: 100,
        }).addTo(myMap)

With these coordinates it shows a line instead of an arc,
may be due to a problem with short distances?
I tried also the following demo example and it works well :
    L.Polyline.Arc([59.56667, 150.8], [67.5, 64.03333], {
      color: "red",
      vertices: 200
    }).addTo(map);

Hi @Christian-Nja!
Leaflet.Arc creates greate circle arcs (see https://en.wikipedia.org/wiki/Great-circle_distance).
Coords that you pass have a very close longitude, and great circle arc for them looks almos like a straigt line.


Add integration tests for authority-claimer

📚 Context
The authority-claimer doesn't have integration tests, so we should implement them to ensure it is working correctly with the contracts 2.0.

The authority-claimer is going to be deprecated for 2.0 and the integration tests for the new claimer are documented on #484


Centralizing the core in case of forced minimum height

Context:
Centralizing the core in the die, after forcing min_height option.
Change: Made the core height and die height independent of each other in case of min_height option, and centralized the core.
Result:

@antonblanchard

I tested this against the RAMs I am using, and it looks good. Thanks!

Actually I think the met4 straps are not long enough. Let me get back to you.

It doesn't solve the issue unfortunately. I asked for --min-height 180 but it didn't resolve my met4 strap issues:

So wait, the straps are laid out only across the core area? That's silly. We'll take another look at PDN generation.

@donn That does look to be the issue. I was going to increase the core area, but just getting the straps to extend past the core area sounds like a good solution.


stop layout

I've created a menu where the user can choose between different layouts. If a layout is selected the others are stopped. I noticed that spread layout continues in background and layout.stop() has no effect. How can I stop the layout?
Thank you

Since there are two layouts proper that this layout runs, have you handled both of them?
If you have suggestions to make the extension more streamlined for this case, you're welcome to discuss that further here or to open a pull request with suggested changes.


Herald needs a maintainer!

Hi all,
I will be brief. While love this project I have neither the time or ability to maintain it. The original app that started this died nearly a year ago. I have been trying to maintain it as I could but I think it would be best if someone else took the lead. The biggest issue I have is that I don't currently use it in any of my apps.
If anyone is interested in taking over or just helping out please make your self known here. Many thanks!

@dohomi, @alethes, @erasaur, @delgermurun, @splendido, @SachaG
Call out to everyone on the contributor list, just want to be sure you see this, sorry for the spam.

@Kestanous I'm very sorry to say, but for me Herald isn't in use for long time. I wouldn't be the right person to overtake.. I use Meteor only in combination with AngularJs.. Hope anyone else has time because the project has great potential.

Ah no worries @dohomi! Thanks for responding.

I already have a lot on my plate, but that being said I'm still using Herald inside Telescope. So if someone ever wants to improve the notification system there they might be interested in becoming a maintainer of Herald?

Hey Kestanous, You have an awesome project here!! love it!
Why can't just stay the maintainer ? just give 5 hours per week since the project is almost perfect ;)
I will try contributing on this awesome project!
Just don't drop the flag and keep up the good work!

What's the roadmap for this and what are the demands?

Agree with @capensisma. You don't have to do a lot. Just keep up with the PRs and encourage them!

@Kestanous thanks for the proposal by I really have no time for this.
I'm sorry to hear you'd like someone else to take over your maintainer role...
Would it really be that much work for you to continue promoting contributions and keep an eye on it reviewing PRs?

To all, thanks for your support! For those that are asking why I can't keep supporting this. My issue is I am running 3 app and 3 other packages and don't even have the time for those (my company is still understaffed). If truly no one wants to take over then I will defiantly do what I can, but I worry about issues following though.
@thatgibbyguy For the most part this is stable. As for future work:

resolve the current issues, api / security / cleanup improvements.
find a better server queuing system, the current one locks up. This is a big one, I can expand on this if you wish.
A nice to have is more supported media (mobile push, SMS, ext.)
Convert to ecmascript 2015 (make a Herald class its instances the couriers)

@Kestanous I'd love to help, but this is probably a bit out of my scope of expertise. Give me another few months and I'll be up to speed :)

@thatgibbyguy It's a great way to learn!

@Kestanous Re: meteor-queue. I ran into a major issue with the queue as well. It was not clearing out old logs, so I collected over 1MM log records in my collection in a short amount of time. I submitted a PR fixing this issue (https://github.com/artwells/meteor-queue/pull/9), so if that was the culprit, meteor-queue should work much better now.

@Kestanous I can help you with some issues specially for the Web Notification extension which I'm actually using in my project. I already submitted a PR (https://github.com/Meteor-Reaction/Herald-Web-Notifications/pull/9).
I'd like to help with the Herald package but actually I'm not familiar with the code, probably in a few weeks I will start using it in my project so by then I could give you a hand!

Yeah I'm like @victorperez, I'm not totally familiar with this project, but it is a good one and needs help. Perhaps you can throw stuff to us, or we could moderate PRs?

Hey all. Hopping to get to this this weekend, time permitting. I am thinking that I can create a Herald Teem for my Meteor-Reaction and give push/pull rights to it. Then I could add any of you interested? Though it would probably be best if a single person took over coordinating things. Not sure how many people will end up joining but there is plenty of improvements to be done.
As far as getting used to the code base goes. I feel like a full rewrite with the new ecmascript package might be in order. The current code has a bit of a spaghetti feel. I would be happy to lay out what Herald is supposed to do vs what it currently does.
For now what are peoples thoughts? I should be able to make time this next month to get things set up properly for everyone. I might even be able to do said rewrite, though I make no promises when it comes to time :)

Hello @Kestanous :)
I'm in ;) I will add some small features..
also can you tell us more about how do What Herald is supposed to do vs what it currently does.
We are ready to roll! :)
Thank you

I can throw in some help on some tasks. It would be a great learning experience for me. Really into the team idea.

Hey all. Again sorry for the long wait. I just drafted my idea for herald v2.0 in this gist (untested code) https://gist.github.com/Kestanous/566914bd555fdccb82f1
It removes a lot of bloat and allows the user to any logic they need for there app. (e.g.) no more built in background jobs but users can wrap the call in one. Thus fixing the queue problem completely.
@SachaG I am particularly interested if you would use something like this with Telescope. Namely the fact that it depends on the ecmascript package. If you see any issue with it I would greatly appreciate knowing.
For everyone else. This code would reduce herald to a single file. One would think that would be easy enough to maintain :wink: I would likely ask people to take over the runners themselves as that is where a lot of the real logic would go. But a runner is just a function with some added logic given the type of media it uses.
I am thinking of creating an all new organization to hold the herald code. I am a huge fan of how things are set up with UserAccounts so likely something like that.

I don't see a problem with using the Ecmascript package, looking forward to the new version :)


When Session data is over 1MB, the service can't receive it

Reproduction: check out the tree branch in this repo.
There's a test service and daemon plugin:
https://github.com/whamcloud/integrated-manager-for-lustre/blob/tree/iml-services/iml-size-test/src/main.rs
https://github.com/whamcloud/integrated-manager-for-lustre/blob/tree/iml-agent/src/daemon_plugins/size_test.rs
On oss1:
[root@oss1 vagrant]# journalctl -fu rust-iml-agent
-- Logs begin at Thu 2020-06-04 07:03:06 UTC.

On adm:
[root@adm vagrant]# journalctl -fu iml-size-test
-- Logs begin at Thu 2020-06-04 07:00:00 UTC. --
Jun 04 09:31:54 adm.local iml-size-test[30470]: Jun 04 09:31:54.843  INFO iml_size_test: Received 8192 datums from mds2.local
Jun 04 09:31:54 adm.local iml-size-test[30470]: Jun 04 09:31:54.951  INFO iml_size_test: Received 8192 datums from oss2.local
Jun 04 09:32:04 adm.local iml-size-test[30470]: Jun 04 09:32:04.533  INFO iml_size_test: Received 8192 datums from oss1.local
Jun 04 09:32:05 adm.local iml-size-test[30470]: Jun 04 09:32:05.935  INFO iml_size_test: Received 8192 datums from oss2.local
Jun 04 09:32:16 adm.local iml-size-test[30470]: Jun 04 09:32:16.928  INFO iml_size_test: Received 8192 datums from oss2.local
Jun 04 10:16:48 adm.local systemd[1]: Stopping IML Size Test Service...
Jun 04 10:16:48 adm.local systemd[1]: Stopped IML Size Test Service.
Jun 04 10:16:52 adm.local iml-size-test[31975]: Jun 04 10:16:52.573  INFO iml_size_test: Server starting
Jun 04 10:16:52 adm.local systemd[1]: Started IML Size Test Service.
Jun 04 10:16:52 adm.local iml-size-test[31975]: Jun 04 10:16:52.675  INFO iml_rabbit: purged queue rust_agent_size_test_rx

As one can see, with a Vec of 8192 elements it works, with 16384 - it doesn't. The numbers are changed here:
https://github.com/whamcloud/integrated-manager-for-lustre/blob/tree/iml-agent/src/daemon_plugins/size_test.rs#L33
Size estimation is just that - estimation, because we're sending Value not String. But it seems to be a pretty accurate estimation.
To rule out some of possible culprits, RabbitMQ claims to support messages up to 512 MB, so we need to look at other components in delivery chain.
@ip1981 has pinpointed the possible point to be in Nginx configuration here:
https://github.com/whamcloud/integrated-manager-for-lustre/blob/tree/chroma-manager.conf.template#L287
Didn't check its effect yet.

Simply increasing client_body_buffer_size to 8m didn't help.

I didn't mean that was the exact place to look at :) You have to figure out which location entry is involved. And client buffer size doesn't matter, max body size does (which is 1M by default).

/agent2/message receives Rust agent messages here:
https://github.com/whamcloud/integrated-manager-for-lustre/blob/6856f8aeef0b9c96eacf31d2273d34d61af44225/chroma-manager.conf.template#L304-L317
The nginx error log should have entries if items are being dropped.
What are we sending that is > 1MB in size?

Ok so it can be fixed with max body size increase, and errors do show up in error.log.
That got me thinking though - if this is happening with just 10 pools, won't it be an issue in production? I.e. with 100 pools a single device tree will end up being roughly the same size.
@jgrund what do you think?

It would make sense to update the endpoint to match:
https://github.com/whamcloud/integrated-manager-for-lustre/blob/6856f8aeef0b9c96eacf31d2273d34d61af44225/chroma-manager.conf.template#L287-L288
In addition, we should look at send compression on the agent side (I think this just landed in recent reqwest).


can't execute test_compute_neighbors.py

When I execute test_compute_neighbors.py something goes horribly wrong during the import of compute_neighbors and the selectors module can't find select.select anymore. Now if I move the test outside of laserchicken/feature_extractor/ everything is fine.  Since no one ran into the issue it's probably due to my install and I'll try to fix that .
But wouldn't it be better to move all the tests outside of the laserchicken folder and put them in a separate test folder ?

I can't reproduce it  .... So I close it


operators [O] ember-csi-community-operator (0.9.1)

Closes: https://github.com/redhat-openshift-ecosystem/community-operators-prod/issues/197
Description
For all distributions that we could identify that the max OCP version is required it was added. More info: https://github.com/operator-framework/community-operators/issues/4226
However, this bundle is not loading with the operator framework/api. This is the only distribution shipped here that is missing that and has this problem. (more info: https://pipelines.actions.githubusercontent.com/KclMGAJStI2m21LtFWMet9p5LrC8aWGNVg9Qr9CUKXHL0T5WTn/_apis/pipelines/1/runs/6604/signedlogcontent/15?urlExpires=2021-09-13T11%3A12%3A36.5513811Z&urlSigningMethod=HMACV1&urlSignature=hx2NeT7YVgf1CP5pukvSV3MAf0NmnKbgq5yDftfQCkA%3D )
This PR fixes: Set the max OCP version = 4.8 which is missing
Signed-Off-By: @camilamacedo86

/merge possible

Hi @J0zi @mvalarh could we please get this one merged?
Also, see that I raised the issue asking for the author fix their bundle https://github.com/redhat-openshift-ecosystem/community-operators-prod/issues/234

/retest

/merge possible

/merge possible

@cschwede, please approve adding this https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/223#issuecomment-924197437

@camilamacedo86 can you please add following to ci.yaml file?
packagemanifestClusterVersionLabel: auto

/merge possible


Order by

:tada: This PR is included in version 1.33.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

Thanks a lot for your work @bogannathan !


Huge Rework

-Fixed .uplugin file
-Fixed project can't load the .dll of assimp cause of pathes
-Added Async support
-Import
--Added option to normalize the mesh into a 100cm cube
--Fixed Relative path not working
--Made relative path more clear and added relative to project option
--Added option to merge mesh sections together (By Material/All)
--Fixed tranforms of imported mesh sections not correct on hierarchical mesh nodes.
--Added error logging for importer to output log of Unreal
--Moved code for loading the triangles to where it belongs
--Added transform to the import that is applied to the mesh data
-Created a LogCategory for the importer
-Added more functions to the library
-Renamed files/structs/library to be more usefull
-Removed unused variables
-...

@RumbleballTheReal hello, is it possible you can make your pull request not require write access so that I may merge it? Just so I can try using it as well...

Sorry, but not sure what you mean. I'm basically lost with git/github.
Can't you just merge with my fork the the repo?

Ah ok cool, Im definitely gonna keep a look out for it on the marketplace :)


[Bug?] "Method code too large!" Error after changing a file to use global variables

Intro:
Error executing {[0:crafttweaker]: stage3.recipes.add.shaped.zs}: Method code too large!
Issue Description:
After changing scripts to use the globals I created, I got this error.
What happens:
Error executing {[0:crafttweaker]: stage3.recipes.add.shaped.zs}: Method code too large!
Script used:
There is 50+ scripts in total. This is whats truly related (I suppose)
https://gist.github.com/justinrusso/5da32c4556fbcfcf0d14e133e43f637b
See https://github.com/Darkosto/SevTechAgesConfigs/tree/ingot-stuff/scripts if you want the full thing. Commit https://github.com/Darkosto/SevTechAgesConfigs/commit/26d32b0bbcbdbb5aa116527866d6ccf1cfee3c5b broke it.
Minetweaker.log file:
https://gist.github.com/justinrusso/98b4328b3b1a664102cba6469e7e74f7

Affected Versions (Do not use "latest"):

Minecraft: 1.12.2
Forge: <IP_ADDRESS>4
Crafttweaker: 1.12-4.0.10 Latest Dev Build (from kindlich)

Your most recent log file where the issue was present:

Could you test if that script is working if you replace your global maps with values?
I believe your maps might be too big for ZS...

I've got recipe maps (IIngredient[][][][IItemStack]) that are pretty large that seem to do fine, but I'll give it a shot.

Replaced null with filler items/oredictentries and still the same error

I kept the metal and metalItems global maps, and just re-added some old global variables the stage3.recipes.add.shaped.zs file used to use, and reverting back to pre-using the global map in that file it does not give me the error.
https://gist.github.com/justinrusso/77b123751b4ea59c32ccebd3e7922740

I removed 17 metal entries from the map (now only 10 left) and it still is giving the error.. I feel like its not that :/

I'm... not sure its me...
I altered the stage3.recipes.add.shaped.zs to make local variables that reference the global map
var ip = metals.iron.plate;
var ap = metals.aluminum.plate;
var lp = metals.lead.plate;
var np = metals.nickel.plate;
var sip = metals.silver.plate;
var gp = metals.gold.plate;
var pp = metals.platinum.plate;

I then replaced all the global map references in the map to the local variable, and everything worked for that file. I then, for the sake of testing if maybe it was the size of the file, created an array with 4 THOUSAND lines. The file size used to be 20KB, and is now erroring that its 122KB, but was fine around 3 thousand lines, and 103KB file size.
Am I just misunderstanding how something works here?

https://stackoverflow.com/a/6570454
ZenScript is subject to the same limits as java


upd(goverlay): 1.0 -> 1.1.1

Goverlay is full Qt6 from upstream (Thx to Antiz)
Add pacdeps=("qt6pas")
Changed URL to point to Source Package (Was binary before, without -bin)
Is now built from source
Changed maintainer name to Xdavius

Need qt6pas merge before

Please don't plop in the PKGBUILD, try to rework the pacscript as is.

Will see later.
Need to push again after qt6pas merge to check if some makedepends are missing too (wasn't on my side but...)
Ok for check function.
But still don't understand why cancelling pkgver line even if it's implicit.
Please, wait a bit for this one.
I have re-uploaded you're original one as -git for now, without update, as an alternative before I test the -bin new release on my side (tempus fugit for now)
Thank you.

But still don't understand why cancelling pkgver line even if it's implicit.

pkgrel defaults to 1 if not included, it only clutters it if you include it with it's default value.

Need lazarus-ide > 3.0 as pacdeps to build.
Working on lazarus-ide-qt6 to provide it.

Please make this a draft until you are ready for review.

Please make this a draft until you are ready for review.

Should be good with lazarus-deb merged

All the tests fail.

All the tests fail.

I'm testing right now. lazarus-deb doesn't provide the default symlink... (No update-aternative, no postinstall in the Deb...)
And the package lazarus-deb doesn't support pacdeps so it doesn't download his deps... it's really a pain...
So... I need to fix this.

And the package lazarus-deb doesn't support pacdeps so it doesn't download his deps... it's really a pain...

We are working on that for 5.0.0.

And the package lazarus-deb doesn't support pacdeps so it doesn't download his deps... it's really a pain...

We are working on that for 5.0.0.

I have found a solution, puting deps in order in pacdeps...
But, I have a new error with Lazarus set as dep (but I have no more depend on my test copy... I should reinstall a clean VM to continue, after the weekend now)

Hi.
I have modified my fork but, I see that if I modify it, update directly here. I don't want this but I don't know how to do. My branch is like synchonized to the PR.