Outputs naming alignment with OV

Just testing, please don't merge.

@tomdol I understand this is a test PR, however, I assume, it's part of some operation activity.
Could you please briefly explain what is activity about, is it into 22.1 scope, and do you expect any assistance from ARM plugin team?

@tomdol I understand this is a test PR, however, I assume, it's part of some operation activity. Could you please briefly explain what is activity about, is it into 22.1 scope, and do you expect any assistance from ARM plugin team?

Sure, this PR is a part of a bigger task where I adjust the friendly names of ngraph Nodes as well as tensor names. This happens for ONNX models when the ONNX FE imports them. https://github.com/openvinotoolkit/openvino/pull/7691 here's the main PR which also introduces a lot of changes in the OV core.
In that PR the TensorIterator tests fail when executed with the ARM plugin (ie_tests_cpu_arm_debian_9_arm_release) and I got a sugestion from @apankratovantonp that this could be the fix. I've also created a PR with 2 custom branches for both OV and OV_contrib to see how the combination of those changes works https://github.com/intel-innersource/frameworks.ai.openvino.ci.product-configs/pull/566
The starting point of this activity is a task with id 48859. For now I don't need any more assistance but I'd like to ask for a review of this PR. Can you please suggest or add someone to the list of reviewers yourself?

CI passed: https://github.com/intel-innersource/frameworks.ai.openvino.ci.product-configs/pull/566


line 35: instagram.py command not found

someone opened an issue with the same problem. you told them to install the latest version of python on the device. did that and it gives the same error

Any answer?


Initial exploration of SF Open Data

We are currently unsure if there is any data that is available in the open data that the city has shared at https://data.sfgov.org/  This work will help us create a better set of hypothesis to bring to the data science team to do a more detailed dive into the data.
We need a set of visualizations that will give us a better idea of what is going on in the data sets that might help us better understand the problem.

I'll explore this and update. It's a bit open ended so no particular reason for other people to not have a go at this too.

Breakdown of tasks.

[ ] Figure out how to automatically download data from the SFOpen site
[ ] Insert data into a SQL database
[ ] Histograms: category uniqueness, description clustering, etc.

Closing this issue for now because we have decided on a direction that doesn't need this data. WIll reopen if we need to dig into the OpenSF data in the future


Support AWS config file options

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue, please leave a comment

Describe the Feature

More info here: https://github.com/awslabs/aws-sdk-kotlin/issues/206

SEP - seps/accepted/shared/configuration-file.md


coprocessor: RPN function IfNull

What have you changed? (mandatory)
This PR adds RPN function IfNull.
What are the type of the changes? (mandatory)

Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)
Unit test.

/run-integration-tests


tsp, do not skip API in pollingOperation

quote Michael

I agree with the suggestion here that we should always generate all operations regardless of whether they are marked with polling operation.  We can use @access for now to hide them if we don’t want them and @scope once that decorator comes online.

Hold on as there is more discussion in email and chat.


Feature/local development

Makes Schema.yaml location configurable via "SCHEMA_CONFIG_PATH" env variable.
Adds Makefile utilities for downloading sample redis data
Makes docker file to be used with Tranql frontend and Redis backend,


[flutter_markdown]: limit/restrict markdown functionality

Use case
I only want to use
emphasis

This is ~strike_through~
this is bold
this is italic

list

ordered

item1
item2

unordered lists
item 4

Hyperlink

link

Proposal
Allow us to restrict functionalities to which we want to use.

@sgshubham98
What feature / functionality / plugin are you referring to for this proposal ?
Can you elaborate ?
Thanks.

This is related to the flutter_markdown plugin

What is the use case for actively restricting to a subset of the language? Why not just not use the features that you don't want to use?

The application contains a lot of text content entered by users. That text can contain any character let's say starting with # XYZ then it will be rendered as a heading if the text is passed to the MarkdownBody.
There are many other cases such as
This text won't be visible
 or anything after this till new line
Also, there were cases where in-between characters were hit markdown sequence and were rendered as markdown text which was not intended by the user

It sounds like you want a custom markup language for your specific use case then, which happens to be a subset of markdown, rather than actually wanting markdown then. It's not clear to me that trying to make the package be able to parse arbitrarily defined subsets of the language makes sense from a complexity/maintainability standpoint.

Not custom markup language but sort of. I'm not sure how complex it will be to render only a defined syntax.
let say it render only heading tags and not another syntax
# h1
## h2

Not custom markup language but sort of.

Markdown is a specific set of syntax rules that do transformations. If you want something that doesn't obey a lot of those rules, then that's not markdown, it's a custom markup language. It may be inspired by markdown, but it's not markdown.

Hey
I needed to disable some features as well. And I found out how to do it. To disable an image you can override an image builder like this:
imageBuilder: (uri, title, alt) {
  return Text('![${title ?? ''}](${uri.toString()})');
}

Implement the MarkdownElementBuilder in order to override other tags. For example to override markdown paragraph behavior to pay attention to the single "\n" in the text I wrote this builder:
class MarkdownTextBuilder extends MarkdownElementBuilder {
  @override
  Widget? visitText(md.Text text, TextStyle? preferredStyle) {
    return Text(
      text.text,
      style: preferredStyle,
    );
  }
}

MarkdownBody(
  data: data,
  builders: {
    'p': MarkdownTextBuilder(),
  },
)


Do not merge: Implementing Unit testing for Python

Looking at #42 I think we should fix this before modifying the Python code. I was surprised to see the second test succeeding and the first failing btw

cc @andygrove  see results here https://github.com/edmondop/datafusion-ray/actions/runs/12099448052/job/33737021716

cc @andygrove see results here edmondop/datafusion-ray/actions/runs/12099448052/job/33737021716

That was the wrong build sorry, this is the fialing build https://github.com/edmondop/datafusion-ray/actions/runs/12268595231

Superseded by @andygrove https://github.com/apache/datafusion-ray/pull/53


Fix for #7, by sending 400 (Bad Request) when POST and content-type is not application/json

Only sending a generic Bad Request. IMO, should send a properly formatted error message. I could not find any example in code or documentation.

Assuming that check is required for PUT as well.
Also the example given for PUT in readme, does not work as body-parser was in strict mode and body sent in example 32. body-parser in strict mode only accepts arrays and objects.

Thanks @akshendra, looks good


Hot Reloading not working?

I tried out hot reloading but it seems it's not working, at least for me.
Project Structure:
➜ tree .
.
├── SimpleRunnerDriver
│   ├── Package.resolved
│   ├── Package.swift
│   ├── Sources
│   │   └── SimpleRunnerDriver
│   │       ├── Dummy.swift
│   │       ├── PlayerController.swift
│   │       └── SimpleRunnerDriver.swift
│   └── Tests
│       └── SimpleRunnerDriverTests
│           └── SimpleRunnerDriverTests.swift
├── SimpleRunnerDriver.gdextension
├── assets
│   ├── swift.png
│   ├── swift.png.import
│   ├── tileset.png
│   └── tileset.png.import
├── icon.svg
├── icon.svg.import
├── main.tscn
├── objects
│   └── player.tscn
└── project.godot

SimpleRunnerDriver.gdextension
   1   │ [configuration]
   2   │ entry_symbol = "swift_entry_point"
   3   │ compatibility_minimum = 4.2
   4   │ reloadable = true
   5   │
   6   │ [libraries]
   7   │ macos.debug = "res://SimpleRunnerDriver/.build/arm64-apple-macosx/debug/libSimpleRunnerDriver.dylib"

Godot Editor log:
SWIFT: extension_initialize
Registering PlayerController : CharacterBody2D
Registering Dummy : Node
SWIFT: extension_initialize
2023-12-04 13:28:16.116 Godot[42742:8159462] WARNING: AVCaptureDeviceTypeExternal is deprecated for Continuity Cameras. Please use AVCaptureDeviceTypeContinuityCamera and add NSCameraUseContinuityCameraDeviceType to your Info.plist.
WARNING: Blend file import is enabled in the project settings, but no Blender path is configured in the editor settings. Blend files will not be imported.
     at: _editor_init (modules/gltf/register_types.cpp:63)
SWIFT: Removed object from our live SubType list (type was: <Dummy#1551305338405>
SWIFT: instanceBindingFree token=Optional(0x0000000150031950) instance=Optional(0x000000014f374810) binding=Optional(0x0000600003967860)
SWIFT: Removed object from our live SubType list (type was: <PlayerController#1551338892837>
SWIFT: instanceBindingFree token=Optional(0x0000000150031950) instance=Optional(0x000000014f4d0210) binding=Optional(0x0000600006c54840)
SWIFT: extension_deinitialize
SWIFT: extension_deinitialize
SWIFT: extension_deinitialize
SWIFT: extension_deinitialize
ERROR: Condition "p_level > int32_t(level_initialized)" is true.
   at: deinitialize_library (core/extension/gdextension.cpp:794)
ERROR: Condition "p_level > int32_t(level_initialized)" is true.
   at: deinitialize_library (core/extension/gdextension.cpp:794)
ERROR: Condition "p_level > int32_t(level_initialized)" is true.
   at: deinitialize_library (core/extension/gdextension.cpp:794)
ERROR: Condition "p_level > int32_t(level_initialized)" is true.
   at: deinitialize_library (core/extension/gdextension.cpp:794)

I am not sure if reloadable = true is necessary in the .gdextension file (I think I got that from the Rust bindings). Nevertheless hot reloading is not working for me. Maybe I am doing something wrong?
Thank you for the awesome work and the cool talk at GodotCon ;)

If you look at Godot's core/extension/gdextension_manager.cpp, you can see that init levels beneath SCENE cause Godot to inform the user they need to restart the editor to see changes:
GDExtensionManager::LoadStatus GDExtensionManager::_load_extension_internal(const Ref<GDExtension> &p_extension) {
	if (level >= 0) { // Already initialized up to some level.
		int32_t minimum_level = p_extension->get_minimum_library_initialization_level();
		if (minimum_level < MIN(level, GDExtension::INITIALIZATION_LEVEL_SCENE)) {
			return LOAD_STATUS_NEEDS_RESTART;
		}
		// Initialize up to current level.
		for (int32_t i = minimum_level; i <= level; i++) {
			p_extension->initialize_library(GDExtension::InitializationLevel(i));
		}
	}

	for (const KeyValue<String, String> &kv : p_extension->class_icon_paths) {
		gdextension_class_icon_paths[kv.key] = kv.value;
	}

	return LOAD_STATUS_OK;
}


Invalid locking in k_delayed_work_submit_to_queue()

From k_delayed_work_submit_to_queue():
        k_spinlock_key_t key = k_spin_lock(&work_q->lock);
        int err = 0;

        /* Work cannot be active in multiple queues */
        if (work->work_q && work->work_q != work_q) {
                err = -EADDRINUSE;
                goto done;
        }

The spinlock taken on first line of the code above is located in work queue, so on SMP machines it does not protect from sending the same work to multiple work queues.

FYI: @nashif, @carlescufi, @pdunaj


[Feature] Support CRD versioning

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
The current kuberay CRD has changed a few times in the past year. Some of these changes have invalidated existing RayCluster configs, resulting in added migration complexity. In particular, if you have existing RayClusters that were created with the old CRD, it's not clear how to correctly migrate them to the new CRD without affecting users.
Kubernetes recommends two different approaches to CRD versioning:

Multiple versions at once
Webhook conversion

It would be great to understand which approach makes the most sense of kuberay and add versioning to the CRD going forward.
Use case
Supporting upgrades to new Ray Operator and CRD versions without breaking existing RayCluster configs.
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

I agree with that changes result  in added migration complexity.
At the beginning, there are three CRDs in this repo. We have discussed in the last year and merge them into one CRD. I think we will work on this CRD , and the ray-operator controller will be compatible with all versions of the CRD. So Multiple versions at once looks good to me.

Based on previous experience, we try not to introduce webhook for the conversion. Explicitly specifying the version sound better to me an we do have good practice in other projects.

Any API changes should bump crd version. v1alpha1 -> v1alpha2 -> v1beta1 -> v1 -> v2alpha2 etc
Suggest user to use pinned version.  kuberay v0.2.0 etc.
Release testing will cover upgrade tests and migration guidance should be provided

Close this one in favor of #1209.


cookies modal not appearing

blocked by https://github.com/wp-pwa/saturn-theme/issues/308
The cookies modal is not popping-up in https://iosmac.es/ and it looks like it is configured properly in the db.
Only if you go to "Opciones de privacidad" in the lateral menu and you close the window then the cookies pop-up appears.
Site Id mEZfdocCWvFqzRHxm
Steps to reproduce it:

Go to https://iosmac.es/ and open the menu.
Click on "Opciones de privacidad" and then close that window.

After closing the Privacy Policy the cookies pop-up shows up

@luisherranz let me know when this is deployed. Thanks! (just mention me on this issue, and I'll be notified ;) )

@rmartinezduque it looks like it's working now with the new library 👍


Hyprland crashing on startup

Already reported ? *

[X] I have searched the existing open and closed issues.

Regression?
No
System Info and Version
 System/Version info
Hyprland 0.44.0 built from branch main at commit e58e97b0a38b8ccc87a4304c9e4e2b37c9966875  (Nix: build aquamarine and hyprutils in debug when using hyprland-debug).
Date: Thu Nov 7 09:54:52 2024
Tag: v0.44.0-126-ge58e97b0, commits: 5425
built against aquamarine 0.4.3

flags set:
debug

System Information:
System name: Linux
Node name: archlinux
Release: 6.11.6-arch1-1
Version: #1 SMP PREEMPT_DYNAMIC Fri, 01 Nov 2024 03:30:41 +0000

GPU information:
00:02.0 VGA compatible controller [0300]: Intel Corporation Alder Lake-P Integrated Graphics Controller [8086:4626] (rev 0c) (prog-if 00 [VGA controller])

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:
	unknown: not runtime

Description
Hyprland briefly flashes then crashes
How to reproduce
run Hyprland from a TTY after updating to latest in AUR
Crash reports, logs, images, videos
Crash Report: hyprlandCrashReport8868.txt

Did you update hyprutils and aquamarine too?

I'm confused

I updated my whole system with paru, these are the versions I have installed
$ pacman -Qi aquamarine
Name            : aquamarine-git
Version         : 0.4.3_r227.ga49bc35-1
Description     : a very light linux rendering backend library
Architecture    : x86_64
URL             : https://github.com/hyprwm/aquamarine
Licenses        : BSD-3-Clause
Groups          : None
Provides        : aquamarine
Depends On      : gcc-libs  glibc  hyprutils-git  hyprwayland-scanner-git  libdisplay-info  libdrm  libglvnd  libinput  mesa
                  opengl-driver  pixman  pugixml  seatd  systemd-libs  wayland  wayland-protocols
Optional Deps   : None
Required By     : hyprland-git
Optional For    : None
Conflicts With  : aquamarine
Replaces        : None
Installed Size  : 1196.41 KiB
Packager        : Unknown Packager
Build Date      : Fri Nov 8 06:41:48 2024
Install Date    : Fri Nov 8 06:42:27 2024
Install Reason  : Installed as a dependency for another package
Install Script  : No
Validated By    : None

$ pacman -Qi hyprutils
Name            : hyprutils-git
Version         : 0.2.3.r4.g3ce0cde8-1
Description     : Hyprland utilities library used across the ecosystem
Architecture    : any
URL             : https://github.com/hyprwm/hyprutils
Licenses        : BSD-3-Clause
Groups          : None
Provides        : hyprutils=0.2.3  libhyprutils.so=1-64
Depends On      : pixman
Optional Deps   : None
Required By     : aquamarine-git  hyprcursor-git  hyprland-git  hyprlock-git  hyprpaper  xdg-desktop-portal-hyprland
Optional For    : None
Conflicts With  : hyprutils
Replaces        : None
Installed Size  : 220.11 KiB
Packager        : Unknown Packager
Build Date      : Fri Nov 8 06:41:18 2024
Install Date    : Fri Nov 8 06:41:38 2024
Install Reason  : Installed as a dependency for another package
Install Script  : No
Validated By    : None

  I'm confused

Maybe it's because I don't have it compiled with debug symbols?

What gpu do you have amd what drivers have you installed?

cooked stacktrace, but I'd suspect something isnt linked right. Can you rebuild aquamarine then hyprland?

I used paru to compile and install, I'm now updating to latest commit, I'll verify if it works, otherwise I might try to build and install it manually following your suggestion, even tho I remember I didn't have success compiling Hyprland last time I tried.

What gpu/s does your computer have and what drivers has your system installed?

this are my specs.
After updating to latest commit hyprland now starts correctly, with only those few errors in the config cause of shadow sub category, which I fixed.
It now seems to work fine, the only problem I notice is this:

the small white triangles on the corners

closing then


Support data.world as a datasource

data.world would be a great general purpose, low entry barrier datasource for plot.ly.
It should be a very straightforward integration based on the implementation of existing data.world connectors for Tableau (https://github.com/datadotworld/tableau-connector) and Google Data Studio (https://github.com/datadotworld/data-studio-connector).

That is a great idea, thanks for the feedback!

@rflprr I'm labelling this issue as community. I also think this is a good first contribution. If you feel like contributing, I can point you to the files that need changing and help through the process.

Hi, @n-riesco. We would like to contribute and could start as early as this week. What's the best way for us to get started?

@rflprr
First of all, you need to set up your dev machine:

install Node.js v6
install yarn v1
clone Falcon's repository, build and run:$ git clone https://github.com/plotly/falcon-sql-client.git
$ cd falcon-sql-client
$ yarn install
$ yarn run rebuild:modules:electron
$ yarn run build
$ yarn run start-hot

Once the dev machine is setup. Here's a list of files you need to look at to add a new connector:

backend/persistent/datastores/Datastores.js
app/constants/constants.js
app/images
app/actions/sessions.js
app/components/Settings/Tabs/Tab.react.js
app/components/Settings/Settings.react.js

As an example of what needs doing, you could also have a look at the following commits from the PR implementing the Impala connector:

UI changes: 2d1477f2435aae3b37ef1a27ec63daa6100d6eb1
Backend implementation: 67ae51d3739a3f147b49e1ad1720ba326a5829b6
Add a sample connection: 9e85a2bab3aed6ce3c6267bdc99037476dd0a997
Add tests: https://github.com/plotly/falcon-sql-client/blob/master/test/backend/datastores.ibmdb.spec.js

Hopefully, I didn't miss anything ;), but if I did or you need more help, don't hesitate to contact me.


Divide two numbers

Thank you for participating  in hacktoberfest ❣ if you liked working on this repo you can share it with friends and star this project for helping others


Invalid License

See https://github.com/github/dmca/blob/master/2018/2018-01-25-Monero.md for more details.

The latest update in terms of Monero license reporting seems to be
``
Copyright (c) 2014-2018, The Monero Project

Hmm...  I've been trying to make a script to do this for me for a bit...  Unfortunately this task seems to be more akin to manual labor.  You have to actually go in to each file, compare it to the source Monero fork, determine if any changes were made, then determine if the changes warrant a separate edollar mark.
I'm still working on it, but I still have 500 or so files to comb through in the scr and tests folders.

Here is the list of files that still need to be looked though...
list.txt

Ok, got it . I made the pull request anyway. In case I can close it. I can see two other possibilities:

the license is going to be changed wherever the invalid Monero copyright was reported with the correct one. Tten the Edollar copyright is going to be applied for those files that have been actually added in this project
create a script which fetch the Monero project and the edollar one, compare each single file. Then compare the code similarity with fuzzy hashing (ssdeep) . The ones with higher similarity score are Monero Copyright, the ones with low similarity scores need to be reviewed since potentially edollar copyright.

Any feedback is welcome

The problem with that method is that it doesn't factor context into account.  For example, if one line is changed in a file, that could either be a comment edit or a proprietary algorithm.  A single line change in one large file could be way more relevant than multiple line changes in a small file, but the smaller one would have a much lower similarity score.

@VincentVespa  you are right. At this point I'd like to give a try adding a scoring mechanism  based not just on the whole source file content , but splitting by blocks of lines. In this way if I'm confident to pick up the source files that are actually the same, and I can still tweak the thresholds in a way that the ones with few changes  are also showed as file of interest . Let's see.

#8 Should have all of the necessary copyrights updated...  It haven't double-checked my work, though, if someone would like to look through it and make sure I didn't make any mistakes.

@VincentVespa sounds to me you changed pretty much the same number of files of  the script I wrote for this which has produced  https://github.com/edollar-project/edollar/pull/7.  Anyway a double check is not bad at all for a task  like this one.

@block202612 Yessir.  Same idea, just kind of a different route.  :-)  I filtered the two repositories in the following order before I determined the copyright determinations:

Removed all files that I had already manually edited earlier.
Removed all files that did not contain any form of copyright marker.
Removed all files that did not contain 'edollar' or 'monero'.
Removed all files that did not appear in both bases. (I was left with about 507 files at that point).

After that I made a function that would read the file from both code bases, then remove all lines that were identical.  If the only remaining line was the Edollar copy, I knew that would have to be changed to the Monero copyright without the Edollar copyright.  Batch edited those and removed them from my file list.
After that, I incorporated the same function into a GUI so I could see the differences an manually edit it.  Unforunately, I would edit that GUI as I went for whatever I needed it to do, and I trashed the input code when I changed the functions to my output (text edit) code.  The base GUI outline is still there, though, if that helps you get an idea of what I was working with.

@VincentVespa  great work anyway

Merge pull request from @@VincentVespa


Generate Enum

The CrmSvcUtil.exe allowed an extension, in order to generate enum for option sets, status and status reason. Can this be added to the tool?

Hi, yes. I added this feature, but have not yet published in XrmToolbox store, will publish soon

I see that the feature is there now. Thanks for adding it. One things I noticed is that the names contain underscores, which violates Microsoft Naming Guidelines and introduces a whole lot of Code Analysis Warnings.
Can you follow https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/naming-guidelines when naming your classes/fields/methods/properties/etc. please?
Code Analysis Warnings are generated when the Microsoft Naming Guidelines are violated.
One thing I've noticed in your naming is the use of underscores for public types (private is fine - but you should follow Roslyn and/or Resharper recommended naming).


Make module look more professional

When I install an Xposed module, I expect it to appear as though it could've been a default feature of the operating system. WiFi Password was the best of the WiFi password revealer modules, but didn't quite meet my standards of professionalism, so I've gone ahead and made the following changes:

Correct grammar in README.md.
Change app_desc to match README.md description.
Change clip_info_format to use the full word "Password".
Change empty_password to "None" to match "Security: None" in dialogs.
Change toast_wifi_info_copied to tell user exactly what was copied.
Show empty_password without click when password is empty.
Replace person covering his eyes(?) with the correct number of password dots based on password length.
Remove leading and trailing quotations from displayed and copied data, as these could lead user to believe quotations are part of the password.

Very thanks for your work.

Thanks, I will release it soon.


Occasional Network Disconnect

Hi Chris,
Whilst I realise this isn't a problem for most (and probably not really your problem at all), I'm facing an interesting intermittent issue where for some (undetermined) reason, HA loses the MQTT connection with lxp-bridge. Both are running in separate containers with the MQTT server on a separate machine. I can restore full functionality only by restarting the lxp container.
My initial analysis is that there is possibly an intermittent network problem. When it occurs, lxp 'disappears' from HA but all other MQTT devices remain addressable so I assume that the problem is that lxp is not reconnecting to the MQTT server after the interruption?  I'm wondering if there is a simple 'fix' to the 'dropped' connection?

Hello @JohnMacrae ,
Sorry about he delay here - could you perhaps provide some logs from your side when this happens? Both HA and lxp-bridge.
In your scenatio both HA and lxp-bridge would be clients connecting to the external MQTT server, so it would be interesting to see where things break down. Judging by your explanation, it looks like it might be breaking down between lxp-bridge and the MQTT server (you are still seeing other MQTT things on HA).
It might also be a connection break between lxp-bridge and the inverters, so the logs might help show if that is the case.
---Jaco

Hi Jaco,
Sadly I don't have the old logs. I've also now moved the MQTT server to be on the same machine as LXP Bridge and HA and the problem has not recurred. I consider this an 'edge' case as most people will be running the MQTT server on the same machine as lxp-bridge and HA - and most people probably have a better network than me :)
I did notice when it last happened that the connection between lxp-bridge and the inverter was operating (although it may have stopped and restarted - but the MQTT connection was dead.) I'm not sure the problem deserves too much attention but maybe worth keeping in the back of your mind if you're in there taking a look.
Sadly, I'm no Rust programmer otherwise I'd already have been there.


Add listing of organization members

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Added members subcommand (membersOrganizationCmd func) to the orgs command to list members of an organiozation.
Added a Members method to OrganizationAPI interface to expose the underlying API.
Added membersView for rendering a list of members.
Refactored the pagination logic into a getWithPagination helper func to reuse the logic between membersOrganizationCmd and listAppsCmd. This required some ugly manipulation of slices due to the lack of generics. Maybe there's a better way to do this?
Fixes #377
References
Fixes #377.
Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.
Also include details of the environment this PR was developed in (language/platform/browser version).

I tested this by executing the new cli subcommand against existing orgs.
I'm happy to add unit/integrations tests if somebody could guide me how this is done here.

[ ] This change adds test coverage for new/changed/fixed functionality

Checklist

[ ] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
[x] All active GitHub checks for tests, formatting, and security are passing
[x] The correct base branch is being used, if not master

Hi @sergeybykov, thanks for raising this. I haven't been able to take a look at the PR yet. When I have some bandwidth I'll circle back and review.

Hi @sergeybykov, thanks for raising this. Is this PR ready for review?

Hi @Widcket, yes it is ready. I only made it a draft because wanted to hear on the issue first.

I'm busy right now, but I'll circle back when I have some bandwidth.

Hi @Widcket, did you get a chance to take a look?

Thanks for reviewing, @Widcket.
I believe I addressed your feedback.

This is now out in v0.11.4.


Add a separate "TaxBrain Documentation" page.

Rather than including so much documentation on the input pages, I think we could have a separate TaxBrain Documentation page.
The content should be stored in a html file in webapp-public (for now) rather than in a flatblock, so it is easy for contributors to suggest changes via PRs.
To begin with, we can keep everything in a single page / HTML file and link to relevant subsections with anchors.
The page can use the same styling as our TaxBrain input pages.
If no one has a better suggestion, url could be www.ospc.org/taxbrain/docs

Perhaps this should be ospc.org/docs and include info for all models.


Support for Go 1.11

Hello,
do you plane to release a Go 1.11 version ?
Best regards

With Go support now present in OE-Core, I'm not doing much with meta-golang these days. An update to 1.11 recently went into OE-Core master.

I didn't know that GO is in OE-Core. You should maybe set a [DEPRECATED] advice in the README.


Update to 2.0.0 (Rewritten on Python)

This PR will be merged, when all commands from JS version will be rewritten

This PR will be merged, when all commands from JS version will be rewritten


THANK YOU for flashpatcher

Thank you, thank you, thank you for FlashPatcher.  It's EXACTLY what I needed to get my HP Printer software to work.
Are you taking donations?
Bill
<EMAIL_ADDRESS>

Oh, Donations ? Lol I have accepted them a few times in the past- but I don't like to advertise that I do lol

Oh, Donations ? Lol I have accepted them a few times in the past- but I don't like to advertise that I do lol

thanks.

thanks.


External group mapping to JWT scopes (SAML) does not work as expected

Hello, I have uaa group mapping configured as follows:
scim:
            groups:
                group1: Group1
                group2: Group2
            external_groups:
                saml:
                    external_id1:
                        - group1
                    external_id2:
                        - group2

Also I've added external groups to externalGroupsWhitelist on my SAML provider.
When trying to log in, I can see White listed external SAML groups:'[external_id1, external_id2]' logged.
So I came to the conclusion that groups are mapped correctly (https://github.com/cloudfoundry/uaa/blob/develop/server/src/main/java/org/cloudfoundry/identity/uaa/provider/saml/LoginSamlAuthenticationProvider.java#L168)
But when I inspect JWT token, I can see no external group scopes (internal groups are visible in the scope list).
I checked UAA code, responsible for user scope generation:
https://github.com/cloudfoundry/uaa/blob/ad4a24861853348b52627c03541bd8b50d655e51/server/src/main/java/org/cloudfoundry/identity/uaa/oauth/UaaAuthorizationRequestManager.java#L369
Which, gets internal groups from database:
https://github.com/cloudfoundry/uaa/blob/ad4a24861853348b52627c03541bd8b50d655e51/server/src/main/java/org/cloudfoundry/identity/uaa/user/JdbcUaaUserDatabase.java#L204
But does nothing about the external groups. Is this expected behavior?
As I understand, it would work In a different way, if user database bean was missing https://github.com/cloudfoundry/uaa/blob/ad4a24861853348b52627c03541bd8b50d655e51/server/src/main/java/org/cloudfoundry/identity/uaa/oauth/UaaAuthorizationRequestManager.java#L373-L375
In that case authorities would be retrieved from Security context, where external groups are present. Should I disable user database bean?

Never-mind, turns out I used wrong origin when configuring group mappings.


samples: net: ptp: slave: Add PTP slave sample

The PTP slave sample application for Zephyr allows boards to synchronize to a IEEE 1588-2008 (PTP V2) master running on the network.
This example will be reworked based on feedback from #40187.
cc @jukkar @erwango
Signed-off-by: Alex Sergeev<EMAIL_ADDRESS>

@erwango please take another look

@erwango please take another look

@carlescufi None of my comments were addressed. @alsrgv Can you provide an updated version ?

Apologies, haven't worked on this for a while. @jukkar, on the other PR you left a comment about using socket APIs instead of net_context, but I'm not sure how to retrieve a timestamp from socket API. I'd like to rework that part before touching others.
I agree about gptp.h headers - I was planning to introduce ptp.h and refactor most of the structures defined in IEEE 1588 to be in ptp.h and used by gptp.h.

Attempting to resurrect this PR.

I will reopen separate PR.


Want to add Light and dark mode for websites using Dino.

Participant of SWOC:
Username: officialarmannq
Discord:atoz#5954

Just to get it clear, you want to add a button that will make websites that do not have a theme toggler, have one right? The dark mode is not for extension right?

Yes sir for the current page

Cool! Go ahead! Do ask if you need any help!


Fix #808

Q
A

Bug fix?
yes

New feature?
no

API breaks?
no

Deprecations?
no

Related tickets
fixes #808

License
Apache 2.0

What's in this PR?
Improved matcher for supported istio versions
Why?
IstioControlPlane was not usable setting 1.11 as version.
Checklist

[ X ] Implementation tested
[ X ] Error handling code meets the guideline (N/A)
[ X ] Logging code meets the guideline (N/A)
[ X ] User guide and development docs updated (if needed) (N/A)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you very much @Tanemahuta for your contribution!

Thank you very much @Tanemahuta for your contribution!

It was my pleasure, thanks for your help with the problems I had!


InfluxDB error when restoring from backup

Hi @jasonacox,
I have been using Powerwall-Dashboard for some time now and today decided to upgrade to the current version. My installaton has not been updated since about july 2022.
So I first made a backup of InfluxDB according to the notes in the backup folder, basically:
docker exec influxdb influxd backup -database powerwall /var/lib/influxdb/backups
sudo tar -zcvf Powerwall-Dashboard.tgz influxdb
Then I cloned the current repository, set it up from scratch using ./setup.sh and checked everything was working (all containers started up fine). As far as I can tell, everything was working fine (of course, all historical data was still missing).
Next I restored the backup, following your notes again:
./compose-dash.sh stop
tar -zxvf Powerwall-Dashboard.tgz
./compose-dash.sh start
Now the historical data was available again, as well as the live data in the Power Flow diagram or the Power Meters diagram.
Unfortunately, the Energy Usage graph was now almost empty (only showing the Sun and Moon data), with a small red exclamation mark in the upper left corner, saying:
InfluxDB: InfluxDB Error: not executed
Any idea what is wrong? At the moment I have it running again without the historical data, but maybe there is an easy way to have this issue fixed.

Hi @jaydkay - thanks for opening this issue.
Did you try the upgrade.sh script first?  I would have recommended doing that after the backup.  The reason is that we have added a few retention policies and CQs (continuous queries) to InfluxDB since your last install (and the snapshot of your restore) and it is possible that the error is related to missing data from a CQ. You can try this from the Powerwall-Dashboard folder to create those missing CQs:
docker exec --tty influxdb sh -c "influx -import -path=/var/lib/influxdb/influxdb.sql"

If that doesn't help, can you see what the actual error might be?
docker logs grafana

Dear @jasonacox, thanks for your quick reply. No, I did not try the upgrade.sh script, I just set it up from scratch.
Since the command you mentioned above is also run during setup.sh, you mean I should run it again after restoring the backup? Do I need to stop the docker containers first or should the command be executed while the Powerwall-Dashboard is up?

Hi @jaydkay ! You are correct. When you restored the database, it wiped out all the changes setup.sh made to InfluxDB (the backup is effectively a snapshot of the database and config for InfluxDB).
You do not stop the containers.  You need InfluxdDB to be running to accept the commands to create the retention policies and CQs:
docker exec --tty influxdb sh -c "influx -import -path=/var/lib/influxdb/influxdb.sql"

After you run that, it will take InfluxDB a few minutes to create the new measurements based on new incoming data from telegraf.  But you should be able to refresh Grafana and see the data show up.
Can you post a screenshot of where you see the error?

Hi @jasonacox, just wanted to let you know that I have been succesfull in restoring the backup using your instructions above.
At first it didn't work, but then it occured to me that restoring the backup has also overwritten the file influxdb.sql with the older version from last july. After pulling the current version again and repeating the above command everything seems to be working again. Only the data of the last two days is missing now, of course. I made a backup of the influxdb-folder before restoring the backup (containing the data of the last two days) - do you know if there is an easy way to re-import this into the database to fill the gaps?
Below is the screenshot you requested of the error before repairing the influxdb installation.
Thanks a lot for your assistance!

That's great news @jaydkay !
In the future, I really recommend that you use the upgrade.sh tool to help save you the hassle.  It's still good to do a backup to save as an emergency, but the upgrade.sh will update all the files but leave your data alone.  It does occur to me that we don't have a comprehensive instruction set for someone who wanted to do an upgrade manually.  TODO for me to add a "how to upgrade manually" section. 😁

do you know if there is an easy way to re-import this into the database to fill the gaps?

Yes!!  Thanks to @mcbirse 's amazing work, you can use the Tesla import tool to fill in those gaps from the Tesla Cloud.  Here are the instructions (and the tool is in the ./tools folder):
https://github.com/jasonacox/Powerwall-Dashboard/tree/main/tools/tesla-history#tesla-history-import-tool
It is a little invovled running it the first time to get your Tesla token, but if you follow the steps you will be able to fill in all the data missing from the time your purchased your Powerwall until now.

Great to hear!  Thanks @jaydkay !


[TC-SMCO-2.2] - SDK has to be implemented for Smoke and CO Alarm Cluster

Summary
All-clusters-app has to be enabled with below mentioned Attributes :

[ ]  expressed-state
[ ]  smoke-state
[ ]  costate
[ ]  battery-alert
[ ]  device-muted
[ ]  test-in-progress
[ ]  hardware-fault-alert
[ ]  end-of-service-alert
[ ]  interconnect-smoke-alarm
[ ]  interconnect-coalarm
[ ]  contamination-state
[ ]  sensitivity-level
[ ]  expiry-date

All-clusters-app has to be enabled with below mentioned commands :

[ ]  SelfTestRequest command

All-clusters-app has to be enabled with below mentioned events :

[ ] AllClear event

Bug prevalence
Everytime
GitHub hash of the SDK that was being used
d55f68526864b2986404d1da9c2ccd8b64735b6e - master
Platform
raspi
Platform Version(s)
RPI4 8GB RAM
Anything else?
No response

Duplicate of https://github.com/project-chip/connectedhomeip/issues/27725
@Rajashreekalmane please file issues on what needs to be done, not just per-test.


Add ground atmosphere and day/night shading to Model and 3D Tiles

Description
:warning: This PR is built on top of #11744, so make sure that gets merged first.

This PR adds ground atmosphere and day/night shading to the AtmospherePipelineStage for models and 3D Tiles. For world-scale datasets like P3DT, this will make it look a lot nicer!

P3DT without ground atmosphere
P3DT with ground atmosphere

Issue number and link

Fixes #11717

Testing plan

Sandcastles for testing:

Comparison with Globe
OWT Base Globe + atmosphere
Camera Distance Comparison

Author checklist

[x] I have submitted a Contributor License Agreement
[x] I have added my name to CONTRIBUTORS.md
[x] I have updated CHANGES.md with a short summary of my change
[ ] I have added or updated unit tests to ensure consistent code coverage
[ ] I have update the inline documentation, and included code examples where relevant
[ ] I have performed a self-review of my code
[ ] Other to-dos:

[x] Determine why the globe appears black before I toggle dynamic lighting
[x] Determine the new condition for adding AtmospherePipelineStage to the model rendering pipeline
[x] Figure out better handling for normals (e.g. P3DT doesn't have them!)
[x] One of the diffuse terms looks like it's using the wrong light direction (always facing the camera). See if that's related to my normal workaround
[x] Add a showGroundAtmosphere setting. Though think about how this will work between Atmosphere and Globe.
[x] Try more datasets, e.g. the One World Terrain globe, non-world-scale datasets to see how they look
[ ] Check through Sandcastle gallery to see if examples look nice or if they need further tweaking.
[ ] Examine performance of OWT Base Globe

I tried the OWT base globe, working nicely with styles and custom shaders!

I am noticing the performance isn't the best for this example, but I'll have to see how much of that is due to the custom shader/styling and how much of that is the added overhead of atmosphere lighting.

One of the specs in Model is failing, the render test with fog in sunlight.
I stepped through the code with debugCanvasWidth=400, one weird thing I notice is that the sunny day color seems wrong (I thought I picked a time that would make it orange like a sunset...), it's just a slightly different shade of blue from DynamicAtmosphereLightingType.NONE :thinking:. Meanwhile when I use SCENE_LIGHT, then it becomes orange.
I checked the enum values in the uniform map and in the shader, they look correct. I also made sure the atmosphere object was propagated to the frame state. So not sure what's going on yet.

@jjhembd @ggetz oh yikes, it looks like the render fog in sunlight spec fails in main too. Since that's a render test, it doesn't run in CI, so it must have been one of my last commits in #11744 that was incorrect

I fixed it, basically the dark color was exactly black, I thought it was supposed to be slightly lighter than that, so I removed the one expectation.

@ggetz @jjhembd I only briefly looked at performance of the OWT base globe with the FPS monitor. I would recommend doing more thorough performance testing, but here's my observations so far:

with the default view with atmosphere off entirely, the frame rate varies quite a bit from 51-60 FPS. Not sure why that would be for an idling tileset, camera and mouse.
Zooming in (again with no atmosphere), the frame rate drops, presumably for rendering many tiles at once.
With the default view, turning atmosphere on doesn't have a noticeable impact above the noise
Zoomed in however, turning on the ground atmosphere does seem to cause the frame rate to drop a bit more.

Thanks @ptrgags for all the work here! We are going to close this for now until we can dedicate someone to finishing up the work the testing an work you suggested here.


Combining Powered Spawn and broken spawner in anvil doesn´t worke

Issue Description:
I craeted my own modpack with twitch. Now I want to craft an powered spawner in anvil with a broken spawner. The problem is that it wount worke, the crafting recipie dont worke.
I installed the mods: ender IO, Ender IO Endergy, Ender Tweaker, Ender Storrage 1.8+, Ender Zoo, Ender Core

Affected Versions (Do not use "latest"):

EnderIO: 5.1.55
EnderCore: 0.5.73
Minecraft: 1.12.2
Forge: <IP_ADDRESS>47
SpongeForge? no
Optifine? yes
Single Player and/or Server? Both

Your most recent log file where the issue was present:
Pastebin ist to small
2020-03-31-2.log

Which mob?

All Mobs don't worke

Which mob?

All Mobs don't worke

are you doing the powered spawner first?

are you doing the powered spawner first?

Yes of course

works just fine

works just fine

But not in my Modpack
Try it Twitch: MCStorzi

pack custom as well with 289 mods
so this is not a issue sorry

pack custom as well with 289 mods
so this is not a issue sorry

But can you help me I just want to fix it

I found using the dark steel anvil worked in my pack while the vanilla one did not, so maybe give that a go. @Stooorzi


A few minor Dockerfile enhancements.

All these things are cosmetic, but it reduces a docker image size as well

Dockerfile improvements.

fewer RUN
COPY --chmod

Linter warnings are addressed.

https://github.com/hadolint/hadolint/wiki/DL3041
https://github.com/hadolint/hadolint/wiki/DL3027

This looks good to me. Thanks!


Added support for passing empty values to lane parameters.

In my lane I want to pass empty value (as parameter) to the lane:
fastlane lane_name key1:

Unfortunately I'm receiving this error:
error: undefined method `length' for nil:NilClass. Use --trace to view backtrace

Problems is in file lib/fastlane/command_line_handler.rb:11:
key, value = current.split(":")

After splitting value is a NilClass and not a string. Secondly next line will throw exception if the value length is 0. Personally I think that only key type and length should be checked and we should allow passing empty values.

Thanks for the pull request. The reason why I verified the value is the following:
When the user executes
fastlane lane_name key

I want to show how to correctly pass parameters.
I'm okay with not verifying the value, but we'd then need to be sure there is at least the : inbetween. What do you think?

There is a problem with fastlane lane_name key. When you execute it you will receive an error:
error: Could not find lane 'lane_name key'. Available lanes: ios lane_name
When you execute fastlane ios lane_name key lane executes without any parameters and there is no information how to pass arguments.
As I can see in the code, you already checking if : is in between using:
if current.include? ":"

So I think that everything is in place.

You're right, thanks for the clarification! This will be in the next release :rocket:


ActiveRel#create and #create! three-arg syntax

Just like initialize, only a little less efficient (one allocation) because it's not often that someone needs to create enough rels at once that it becomes an issue.

Failing from a single timestamp mismatch, so merging.


Can't Figure Out How To Import my rclone.conf File.

I copied the rclone.conf file from My Mac to my Galaxy S8+. I put it in the Downloads folder of the phone storage (not SD). But for some reason when I tap Import Configuration and navigate to Downloads, the folder shows me all its contents except for the rclone.conf file. Do I need to rename it to something especial or anything like that?

Never mind. I wasn't in the right directory at all.


Port deduplicate to TQL2

This ports the deduplicate operator to TQL2. The operator has two major changes from its TQL1 pendant, namely:

It takes only a single expression as an argument. To group by multiple keys, a record expression must be used.
The timeout option was split into separate create_timeout, write_timeout, and read_timeout options. Previously, the timeout behaved like a read timeout, i.e., it always reset, even when the event was not forwarded.

Example 1: Get diagnostics, but show at most 10 per pipeline per hour:
diagnostics live=true
deduplicate pipeline_id, limit=10, create_timeout=1h

Example 2: Get an event every time the node disconnects from the Tenzir Platform:
metrics "platform", live=true
deduplicate connected, distance=1
where not connected

It takes only a single expression as an argument. To group by multiple keys, a record expression must be used.

If it's because the argument parser lacks support for variadic args, not sure this is a good idea.

If it's because the argument parser lacks support for variadic args, not sure this is a good idea.

It is because of precisely that reason currently, we can always change this again in the future.


[REQUEST] Add support to optionally use connection uri for postgresql and redis

Ran into an issue where redis and postgresql database provider required ssl to be turned on in order to accept requests. Ended up having to manually edit the query string to enable ssl support.

I already have a pr for this can I go ahead and submit it?

I think this feature is beneficial for the user-experience as well. If using a database provider, it is typically easier to use a connection URI instead of individual params.

Please submit a PR :)

Added as #154 , thanks!

Merged


Feature: add settings flag to disable inbound TCP/UDP nodes

In some hosted environments it isn't desirable to expose the core TCP/UDP nodes that allow inbound connections. However, those nodes also support outbound connections - which is supported in hosted environments.
For example, the IBM Cloud hosted instance disabled the TCP/UDP nodes and replaced them with custom nodes that used the same node types, but only supported outbound connections. Those forked nodes then inevitably fell behind the core nodes.
It would be better if the core nodes supported this use case and provided a means (via the settings file) to disable their inbound modes.

Ideally this setting should also  be available to other nodes to query  that may also expose their own TCP/UDP ports for example the Email MTA node

Is this intended to be a global indicator of "don't bother to offer this node if inbound connection isn't allowed" - or a specific flag per node (one for udp, one for tcp, one for email - etc ) ?
In the first case as it is then down to individual nodes to implement the flag needs to make clear it is more of an indication that can be followed rather than a hard rule.
In the second - is there a proposed naming convention ? disallowInboundXxx ? or something ?

I think a single global flag indicating that the environment doesn't support inbound connections are not available is the right approach.

I agree (with @hardillb ) - though is it true all the time ? can I have internal (localhost) connections from another process ? Or is that sufficiently edge-case that it doesn't matter ?

The main requirement is a way to disable (non-http) inbound connections in the core nodes. We have other ways of disabling/blocking extra modules that can be done administratively (and doesn't require the node author to had adopted this setting).
The scenario of allowing some connections but not others is out of scope of what is being proposed here.That would require the node UI to allow inbound to be configured, but then have additional validation to allow only certain values.

ok - so more of http(s) connections only flag.

So does this just disable them ? or stop them appearing in the editor palette (IE can't be used) ? EG if I import a flow with existing (or new) tcp in node in - will it somehow get disabled (dotted) ? or be "unknown".
(I'd assume the actual cloud instance would stop it actually working/doing anything so no danger per se - so purely visual)

or stop them appearing in the editor palette (I

The problem we have is the TCP nodes can act in both inbound and outbound mode - we don't have separate nodes for the different 'directions'. So it isn't just a case of disabling a node (which we could already do). The purpose of the flag would be to tell the TCP/UDP nodes not to offer the inbound configuration options.
In terms of importing a flow with a node configured for inbound connections - the node validation logic in the editor would be able to flag it as an invalid configuration.


Feat/api get categories

Slider added in PC format
Categories requested from API

Looks good to me, probably just move the categories section to the top (before meals section)


Support for tags, pagination and sections

I stole most of the stuff from other themes, so Hyde now have the same functionality as other themes, like tag support and sections.
Also fixed the index page, which was showing everything from oldest to newest and no breaks with the use of Paginator, so now the theme requires the "paginate_by" as After-Dark does.

There is one problem that I don't know how to solve it yet: In the section, we traverse all pages in the section, without the Paginator. This causes the list to, as the index before, display all the pages from oldest to newest instead of the other way around.

This theme is just a port of an existing one, could those changes be kept on your fork and we link it on the README of this one?


Add code coverage upload to CI

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@612fba3). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage        ?   95.55%
=======================================
  Files           ?        2
  Lines           ?       45
  Branches        ?        0
=======================================
  Hits            ?       43
  Misses          ?        2
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 612fba3...b395e5d. Read the comment docs.


3 | import __node_cjsModule from 'node:module';

error: Error: Unable to resolve module node:module from /Users/xxx/node_modules/react-native-magic-modal/dist/index.js: node:module could not be found within the project or in these directories:
node_modules/react-native-magic-modal/node_modules
node_modules
../../node_modules
1 | import React, { Fragment, useMemo, memo, useCallback, useEffect, useImperativeHandle } from 'react';
2 | import { Platform, StyleSheet, Pressable, useWindowDimensions, View, BackHandler } from 'react-native';

3 | import __node_cjsModule from 'node:module';

This issue appears when using the esm build of react-native-magic-modal which is picked up on expo projects when turning on unstable_enablePackageExports.
The esm build itself seems faulty such that it ends up using the require from node.
There's only one line of require here.
Since react-native-screens will always be there anyway for all platforms, I wonder if just using a traditional import will be a simpler fix.
A workaround for expo users now while leaving unstable_enablePackageExports on is patching this package inverting this package's package.json:
"exports": {
    "./package.json": "./package.json",
    ".": {
      "require": {
        "types": "./dist/index.d.cts",
        "default": "./dist/index.cjs"
      },
      "import": {
        "types": "./dist/index.d.ts",
        "default": "./dist/index.js"
      }
    }
  },

This makes expo pick-up the commonjs version first.

Thanks for pinpointing! I agree with the solution. Will spin up a quick PR.

Fixed, let me know if it solves this for you!


Template Literal Types reduces string union

Bug Report
When the template literal type is used in a union with strings that match its pattern, the union is reduced:
type union = 'downcast' | 'dataDowncast' | 'editingDowncast' | `${ string }Downcast`;
//   ^? type union = `${string}Downcast` | "downcast"

This is a problem when I want to use it as a parameter type, because then only "downcast" is suggested when calling the function:
function test( groupName: union ): void {}

test('') // Only "downcast" is suggested

As a workaround, I can use function overloading, where one signature has union with all string literals and another only the template literal type, but it would be nice to get this issue fixed:
function test2( groupName: 'downcast' | 'dataDowncast' | 'editingDowncast' ): void;
function test2( groupName: `${ string }Downcast` ): void;
function test2( groupName: string ): void {}

test2('') // All "downcast", "dataDowncast" and "editingDowncast" are suggested

🕗 Version & Regression Information
From 4.1 (when template literal types were introduced) to 5.1.0-beta, tested in TypeScript Playground.
⏯ Playground Link
Link to the TypeScript Playground
🙁 Actual behavior
Only string literals that don't match the template literal type are displayed.
🙂 Expected behavior
All string literals should be shown.

This sounds vey much like #33471.

It doesn't work. For example, passing the string 'testDowncast' reports an error because it doesn't match any value from the union.
function test( groupName: 'downcast' | 'dataDowncast' | 'editingDowncast' | `${ string & {} }Downcast` ): void {}

test('testDowncast') // Throws an error

function test2( groupName: 'downcast' | 'dataDowncast' | 'editingDowncast' | `${ string }Downcast` ): void {}

test2('testDowncast') // Works

Oh, I see. I have a fix for this locally - might wrap it up in PR later. I think that this should work since this string & {} is already handled by the compiler in different places and it's meaning is somewhat established.

It definitely should work - all strings are also string & {} by definition, as {} is a supertype of string. (of course by the same token you could argue that the types are equivalent and shouldn’t behave differently but that’s a different can of worms)

I'm reopening this issue per our discussion in the last design meeting. We already support the pattern
type Foo = "choice1" | "choice2" | string & {};

to produce an un-reduced union for purposes of statement completion. We want to support a similar pattern for template literal types by intersecting with {} at the top level (rather than inside a placeholder as implemented by #54188). For example:
type Foo = "choice1" | "choice2" | `choice${string}` & {};

This means that the type in the original post should be written
type union = 'downcast' | 'dataDowncast' | 'editingDowncast' | `${ string }Downcast` & {};

I will put up a PR to that effect.


fix(storage-resizes-images) Fixes issue where resized image is not rendered in Firebase Console (Issue #140)

The problem with the current extension is outlined here
This should add a new configuration option to NOT delete the token, defaults to true to preserve existing functionality, users can go in to disable it if they don't want it happening.

@firebase/invertase Can you verify that this works? If the option is set to "false" then does it allow the resized image to be downloaded? If yes, then it seems that this should not be a param, but the download token should just always be preserved, and we would make a minor version bump.

No, well I mean right now you cant download the resized images, so defaulting to false I assumed would not break existing configurations for users who have it working this way now and for some reason want it like that?
It shouldn't be a param, and the delete command should just go away honestly... but I didn't want to rock the boat.
Like I can't for the life of my understand why this is here
https://github.com/firebase/extensions/blob/685443f5e44ac2e69304f10e2c497702471e0935/storage-resize-images/functions/src/index.ts#L205
Wouldn't it be the inverse, more people would want that access token there so the resized image just works?

No, well I mean right now you cant download the resized images, so defaulting to false I assumed would not break existing configurations for users who have it working this way now and for some reason want it like that?
I agree 100%, it shouldn't be a param, and the delete command should just go away honestly... but I didn't want to rock the boat.
Like I can't for the life of my understand why this is here
https://github.com/firebase/extensions/blob/685443f5e44ac2e69304f10e2c497702471e0935/storage-resize-images/functions/src/index.ts#L205
Wouldn't it be the inverse, more people would want that access token there so the resized image just works?

That's why I suggested a minor version bump, which for versions under 1.0.0 indicates a breaking change. (I think this is worth doing a breaking change for, rather than adding an unnecessary param)

Ok, so if I have the blessing... remove the param and delete entirely, bump to 0.2.0? Sound good?

@sitefinitysteve Yes please, also you do not have to increment the version or add to the changelog in this PR, that gets automatically generated later when we do the release. Thanks for your contribution!

Hey @laurenzlong, I can confirm that this works.
This is a resized image before the change is made. As you can see there is no image displayed because it need a new token creating:

This is a resized image after the change. Image is displayed because the token is preserved:

I mean i've been using this fix by editing the cloud function directly for a few weeks, but new releases keep blowing away the edit, I know she works.
On that note, what's the release schedule like for something like this?

Thanks @sitefinitysteve and @russellwheatley! This is failing the linter, could you please fix by running npm run format?
We can slot this in for the May 7 release.

Thanks for the contribution!


Is this the new Readium web project ?

Sorry if the question has already been asked but is this project the new reader replacing readium web v1 ?

Hi, not exactly. The new Readium Web project is started in readium/web (monorepo).
Divina is a format specific to comics, manga, webtoons ... incubated in EDRLab + Readium Foundation.
This Divina player has already been integrated in Thorium Reader.
It will soon be also integrated in Readium Mobile.
And it will later be integrated in Readium Web as a specialized Navigator.


Temperature data did not displayed on the Chart

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in QA
Followed all applicable steps in the TROUBLESHOOTING guide: TODO
Checked for relevant discussions on Discord: https://discord.gg/pPERUuv
Checked that your issue isn't already filed: https://github.com/COVID-19-electronic-health-system/Corona-tracker/issues

Description
Temperature data did not displayed on the Chart
Data being entered:

Empty Chart:

Steps to Reproduce

run yarn start
click "Show me more"
See empty chart

Expected behavior:
We should see bars with temperature data for each day of entry.
Actual behavior:
Empty Chart
Reproduces how often:
100%
Versions

Additional Information

I'm working on this issue.


fix: HMR doesn’t work in examples/web

With #1765 the resolve alias was removed from examples/web, this broke HMR. I think it was removed because the aliases broke for @scalar/api-reference/style.css and @scalar/api-client/style.css (we only had an exemption for @scalar/components/style.css)
This PR re-introduces the aliases and changes them to not match @scalar/${anything}/style.css.
Let’s test the deploy preview to see if the CSS is still fine and all.

Actually it was removed on purpose! Just so we can test the packages properly since they behave differently with the alias, it was hiding some bugs. I think we should just have two vite configs one for dev and one for actual testing. What do you think @hanspagel?

@amritk sounds good. can we merge this though? And follow with the testing config?

Sure but just remember that this aliasing hides bugs sometimes


Proposal: Make block timeout value configurable

The purpose of the timeout in the block creation routine is for the block creation to wait for new transactions from the validators before creating the block.
We do this because on slower systems transactions are not validated fast enough and without a timeout this causes the block creation routine to create in quick succession blocks with few transactions instead of bundling them to save consensus rounds.
There have been some questions about this value and whether it is configurable and @makevoid forked bigchaindb just to make this change.
Would it make sense for this to be a configurable parameter in the bigchaindb config file?

The block-creation-timeout time is something every node in the federation should agree on (like the keyring), and therefore if it is configurable, it should be included in the set of federation-level configuration parameters. Right now, we have nowhere to store federation-level configuration parameters, but see the proposal in issue #187

+1, I am using a fork (that I have to periodically sync) just to change
block time - I am currently putting a value slightly higher than average
ping (latency)

Related issue #123

We decided not to make a fancy cluster configuration management system (issue #436, now closed), so if we do decide to make block timeout value configurable, we can just add it as a new setting in the BigchainDB Server configuration file.


Compatibility with segment replication

Summary
With 2.9.0 release, there are lot of enhancements going in for segment replication[1][2] feature (went GA in 2.7.0), we need to ensure different plugins are compatible with current state of this feature. Previously, we ran tests on plugin repos to verify this compatibility but want plugin owners to be aware of these changes so that required updates (if any) can be made. With 2.10.0 release, remote store feature is going GA which internally uses SEGMENT replication strategy only i.e. it enforces all indices to use SEGMENT replication strategy. So, it is important to validate plugins are compatible with segment replication feature.
What changed
1. Refresh policy behavior

RefreshPolicy.IMMEDIATE will only refresh primary shards but not replica shards immediately. Instead post refresh, primary will start  a round of segment replication to update the replica shard copies leading to eventual consistency.
RefreshPolicy.WAIT_UNTIL ensures the indexing operation is searchable in your cluster i.e. RAW (Read after write guarantee). With segment replication, this guarantee is not promised due to delay in replica shared updates from asynchronous background refreshes.

2. Refresh lag on replicas
With segment replication, there is inherent delay in documents to be searchable on replica shard copies. This is due to the fact that replica shard copies over data (segment) files from primary. Thus, compared to document replication, there will be on average increase in amount of time the replica shards are consistent with primaries.
3. System/hidden indices support
With https://github.com/opensearch-project/OpenSearch/pull/8200, system and hidden indices are now supported with SEGMENT replication strategy. We need to ensure there are no bottlenecks which prevents system/hidden indices with segment replication.
Next steps
With segment replication strong reads are not guaranteed. Thus, if the plugin needs strong reads guarantees specially as alternative to change in behavior of refresh policy and lag on replicas (point 1 and 2 above), we need to update search requests to target primary shard only. With https://github.com/opensearch-project/OpenSearch/pull/7375, core now supports primary shards only based search. Please follow documentation for examples and details
Open questions
In case of any questions or issues, please post it in core issue
Reference
[1] Design
[2] Documentation

Request owners to add v2.9.0 label on this issue. @dai-chen

Hi Plugin Owners,
Gentle reminder to look into this issue as code freeze date for 2.9.0 release is near i.e. July 11th.

Gentle reminder for plugin owners as we are past code freeze date for 2.9.0 release

@dreamer-89 For Observability plugin, users create objects in the observability-dashboards plugin and may want to view immediately in the UI. Thus, we are adding the search preferences to _primary. Usually, there number of objects created is low in volume and small in size. We don't see heavy load on primary due to our requests.

@dreamer-89 For Observability plugin, users create objects in the observability-dashboards plugin and may want to view immediately in the UI. Thus, we are adding the search preferences to _primary. Usually, there number of objects created is low in volume and small in size. We don't see heavy load on primary due to our requests.

Thanks @ps48 for the update. _primary preference based search may work for search queries.
In case, your plugin performs realtime reads via get/mget APIs, I wanted to update that core now supports realtime reads for segment replication enabled indices with https://github.com/opensearch-project/OpenSearch/issues/8536. So, if your plugin performs search via get/mget APIs only, then there should be no change needed. Please check https://github.com/opensearch-project/OpenSearch/issues/8536 for more details.

i see in https://github.com/opensearch-project/sql/pull/2013 you mentioned

Existing OpenSearchDataSourceMetadataStorage.java uses match_all & term based search queries which does not provide strong reads and thus as part of https://github.com/opensearch-project/sql/issues/1801 there was no need to perform _primary based routing

In observability, there are get and search APIs, the search API also uses term based search queries https://github.com/opensearch-project/observability/blob/4345041ed16ba89082c481c9e8e326ffa1f73739/src/main/kotlin/org/opensearch/observability/index/ObservabilityIndex.kt#L277, i believe the same statement applies here. closing

@dreamer-89 thanks for the note, we do prefer strong reads if possible for better user experience.
I see targeting _primary was recommended in the original issue, WAIT_FOR is used by dashboards, and IMMEDIATE is recommended here. The observability and reporting plugin only stores metadata created by the user, which should imply low overhead. would you provide some guidance regarding IMMEDIATE, WAIT_FOR, and primary shard only search? i understand the distinction but i'm not sure what's recommended for our use case

Thanks @joshuali925 for the update.

we do prefer strong reads if possible for better user experience.

I suggest you to confirm whether your use case needs strong reads or not. This is important before we perform any action to support strong reads. One way to achieve this is via manual testing and see if you see any discrepancy.

The observability and reporting plugin only stores metadata created by the user, which should imply low overhead. would you provide some guidance regarding IMMEDIATE, WAIT_FOR, and primary shard only search? i understand the distinction but i'm not sure what's recommended for our use case

As with SEGMENT replication, IMMEDIATE, WAIT_FOR refresh policies do not guarantee replica shard refreshes (and thus strong reads). The only options to get strong reads is via get/mget APIs or using _primary preference on search queries. The later puts extra burden on primary shards as all queries lands on it. But, I suggest you to first identify if strong reads are really needed or not for your use case.
CC @mch2 @anasalkouz

Not sure if i understood properly, the two statements seems a bit contradicting. Could you elaborate it a bit? e.g. if _primary is the only way for strong reads, why was IMMEDIATE brought up?

it is still possible to have strong reads with queries you mentioned above by using IMMEDIATE refresh policy during indexing operations

The only options to get strong reads is via get/mget APIs or using _primary preference on search queries

The reason I think we need strong read is because users will want to see the objects they created immediately after creation. For example observability allows users to add sample notebooks, it will be confusing if they clicked "Add sample notebooks" and the new sample ones doesn't show up in the notebooks list, which theoretically could happen.
Our use case is very similar to dashboards saved objects, would be better if we can align to their behavior. @kavilla do you know how is OSD saved objects handling strong reads?

To avoid choosing, have we considered making it configurable? Like _msearch and _search is configurable right now.

Thanks @joshuali925 for the comment and seeking clarification.
There are two mechanism by which you can get strong reads as mentioned below.

During indexing operation. This is done by refreshing all shard copies inside the indexing operation. This results in any subsequent data search query to return the latest data. This is done today via IMMEDIATE, WAIT_FOR refresh policies. Segment replication does not support this as mentioned in issue description.
During data search request. get/mget APIs and using _primary preference parameter ensures strong reads. This is handled automatically on core and thus with SEGMENT replication only mechanism to get strong reads.

@kavilla : I do not have much background on dashboards. Does your last comment suggest that there is no change needed ?

Thanks. I think we would want to align with OSD behavior, since observability objects should act in the same way as OSD saved objects

i did some manual testing in observability, didn't see inconsistent behavior. will close the issue for now


[stable/elasticsearch] Update elastic to 6.6.1

Signed-off-by: ialidzhikov<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md

/test pull-charts-e2e

/ok-to-test

/test pull-charts-e2e

[test-infra maintainer trying to ensure prow is not having issues for helm/charts again, apparently the trust settings for this repo are just collaborators, so I can't actually check 🤷♂]

Let me try, use me as a remote control. :)
/assign
/test pull-charts-e2e

It reads "job triggered", I assume it is ok (even if I'm probably 2 days late).
/ok-to-test

Back to @ialidzhikov: thanks!
/lgtm


Packet manager not appearing after jailbreak

iPhone XR 16.0, I have tried to reinstall, rebuild icon cache and re jailbreak. But Sileo or zebra won't appear. Thanks

Wait few mins or reboot userspace .. it appears but few seconds or couple of mins later.

Thanks, I have tried user space reboot and waited around 10 minutes but it still has not shown up


Investigate if tests (specially with hypothesis) are always properly rebuilt

gt4py.stencil(definition=...., rebuild=TRUE)

For tests, a new cache is used in each run #500


typo in scm

https://github.com/sisioh/aws4s/blob/develop/project/Build.scala#L49-L50

Thank you!


Does this work with LLama 3?

Question in the title.
Big thanks for making this accessible to the community!

Thank you for this issue! We are actively in testing DCA with Llama3 8B/70B, results will be updated in next week!

Hi! The language modeling results for Llama3 8b/70b have been updated! DCA is still very effective!  ChunkLlama3 shows an obvious performance gain over ChunkLlama2 in PPL.
Updates  of needle in a haystack, few-shot, and zero-shot results are expected in two days.  These are running a bit slow.

All results of ChunkLlama3 8b/70b has been updated. (see the results)
Generally, ChunkLlama3-8b achieves 100% retrieval accuracy across all document depths.
Results on real-world tasks show that ChunkLlama3-70b achieves performance on par with GPT-4 (2023/06/13) and Llama2 Long 70b!


feat: add async support

Description
Some interest was shown on getting a PR to lead the way onto migrating from requests in the main goal to serve async.
So, I took the liberty to compose that patch as proposed in #134
Close #134
Checklist

[ ] The patch has appropriate test coverage
[x] The patch follows the style guidelines of this project
[x] The patch has appropriate comments, particularly in hard-to-understand areas
[x] The documentation was updated corresponding to the patch
[x] I have performed a self-review of this patch

I am thinking on a way to test this in the CI appropriately. This effectively create some duplication, but no actual soft way to handle this task without duplication (async/sync).

I have some questions,
In the case of having the "mirror" code but async, do we have to recover the whole thing?
Or can we, let's say, verify that the async interface isn't broken?
With this, should we create a script that automate the generation of the _async submodule?

Fixed the conflicts. I leave to you then.

I applied your suggestions.

7cdaa94 from GH-162 improves CI support for your enhancements. If you like it, feel free to cherry-pick it into your branch. Otherwise, let's add it later.

I did found a solution for the mock lib. One sec.

Done! I looked into the code of requests_mock and did found a "clever" solution to the last issue.

Wonderful, ~300 lines less code lines touched. Merging.

Thank you, looking forward to see it live.

I've also invited you as member to this project, so that we can better share future patches with you, giving you also chances to review them and such.

Thank you!

looking forward to see it live

Maybe it will make sense to address the other minor GH-160 before the release?

Clearly yes, It should.

We thought to have successfully tested the new grafana-client on behalf of grafana-wtf already, so we released version 4.0.0, including your changes.
However, now on CI, there are errors. Maybe our validation was faulty.

https://github.com/panodata/grafana-wtf/pull/125

We've diverted the discussion to a different topic.

GH-169

Dear Ahmed,
it looks like this operations went very well, so thank you once more for your significant contribution. There is a post to share with the community now, at Grafana Client migrated from Requests to Niquests, with added notes from our pen about how to eventually improve and move forward.
Thanks for proof-reading, if you like...?
With kind regards,
Andreas.

It looks like it went well so far, we will know better in a week or so to detect if there's any subtle consequences.
I took the time to read it, and here a few comments:

"Ahmed Thari" is actually spelled Ahmed Tahri
About the "TypeError: expected string or bytes-like object"

The conclusion was that grafana-wtf created by accident a hybrid HTTP Client that had niquests.Session() alongs with requests.adapters.HTTPAdapter in it, whitch didn't go well. For a good reason. In fact, you can do this s.adapters.set("http://", 0) and it wouldn't complain about it. Niquests can definitely do better than accepting any type here.

from niquests import monkey

As I said in https://github.com/panodata/grafana-wtf/pull/130#discussion_r1545547301 it would be wise outside of a development environment and if Niquests would ever expose such a function, I know for sure I would be (big time) blamed for it.

Dear Ahmed,
thanks a stack for your reply. Apologies for misspelling your name, I just fixed that typo. Thanks also for your suggestions to improve the code at grafana-wtf, I will try to follow your advise at [1] to hopefully fix [2], which is currently the most prominent downstream issue.

It looks like it went well so far, we will know better in a week or so to detect if there's any subtle consequences.

Yeah looks good so far. If we get the issues at grafana-wtf sorted out, concluding it by a corresponding release, I will be thoroughly happy.
With kind regards,
Andreas.
[1] https://github.com/panodata/grafana-wtf/pull/130#discussion_r1545547301
[2] https://github.com/panodata/grafana-wtf/issues/132

grafana-wtf 0.19.0 has been released, concluding the update to Niquests, through grafana-client 4.0.0. Cheers!
Announcement: https://community.panodata.org/t/grafana-wtf/67/4

Hello again,
We are next to the one week period and everything still look okay :+1:  . As far as I can see, half of the traffic uses the v4+ the other half remain on the v3.
We've applied the minor "remarks" found during our work in grafana-client at Niquests, we will soon release a new version with it.
If you have ideas, possible improvements do not hesitate to ping us at Niquests.
And, lastly, if you come to know project(s) that could benefit from Niquests, feel free to introduce us :+1:
Regards,

Dear Ahmed,
thank you very much for picking up some UX improvements from here on behalf of https://github.com/jawah/niquests/pull/104. Looks good to me!

We are next to the one week period and everything still look okay 👍 . As far as I can see, half of the traffic uses the v4+ the other half remain on the v3.

Yeah, no bad reports yet, so far, and we guess it will stay like this. This means Niquests has excellent quality already, please keep up your good work.
With kind regards,
Andreas.


Re-loading files after multi-select

I haven't been able to reproduce this within BrowseEverything, and only encounter this when I'm using the gem within one of our applications, so it could be how we're integrating it that's the problem. Here's a video that shows what happens:
https://dl.dropboxusercontent.com/u/9554743/select-issue.m4v

@awead video is 404


feat/config regex

Codecov Report

Merging #98 into main will increase coverage by 2.01%.
The diff coverage is 96.00%.

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   69.49%   71.50%   +2.01%
==========================================
  Files           5        6       +1
  Lines         177      193      +16
  Branches       29       31       +2
==========================================
+ Hits          123      138      +15
- Misses         53       54       +1
  Partials        1        1

Impacted Files
Coverage Δ

src/config.ts
96.00% <92.30%> (-4.00%)
:arrow_down:

src/schema.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a320c...92861b4. Read the comment docs.


A simple example added to Date - toString

First attempt at using GIT for updating the documentation. Added a simple example to the date documentation.

I understand. The code has been updated.  Thanks for the feedback, i will use asserts in the future.

@Wulfklaue I think you're confusing ddoc examples with unittests. A ddoc example is what you had initially - a code snippet enclosed between two --- lines inside a ddoc comment (/** ...  */). A ddoc-ed unittest is just a regular unittest put after a function preceded by a potentially empty ddoc comment (/** ...  */ or /// ...).
So you need to move the unittest after the function.

See also: http://dlang.org/spec/unittest.html#documented-unittests

Ok, got it figure out. A few times egg on the face but now i know the logic :)
Unfortunately, also discovered while the code is valid, the doc testing can not run it.
/d446/f202.d(1): Error: module date is in file 'std/datetime/date.d' which cannot be read import path[0] = /opt/compilers/dmd2/include import path[1] = /opt/compilers/dmd2/bin64/../../src/phobos import path[2] = /opt/compilers/dmd2/bin64/../../src/druntime/import
Function std.datetime.date.Date.toString
Function std.datetime.date.Date.toSimpleString
Function std.datetime.date.Date.toISOString
...
All suffer from the same issue that the example is valid but the code runner has issues with it.

Unfortunately, also discovered while the code is valid, the doc testing can not run it.

Unfortunately that's a known problem and there's no simple fix. The issue is that online runner uses https://dpaste.dzfl.pl, which in turn uses the last stable dmd release, which means that some examples will become properly runnable only when the next version of dmd is released.

Unfortunately that's a known problem and there's no simple fix. The issue is that online runner uses https://dpaste.dzfl.pl, which in turn uses the last stable dmd release, which means that some examples will become properly runnable only when the next version of dmd is released.

Absolutely correct.
@ZombineDev  I pinged @nazriel many times to support dmd-nightly on DPaste - unfortunately without success so far.

Okay, here's the thing. No on should be relying on the format of the output of toString like this. It wouldn't surprise me if someone is, but they shouldn't be. Aside from simply printing out a the Date (or SysTime, DateTime, etc.) as a string to see what it is without caring about it's format, you really should be using one of the specific to*String methods - probably toISOExtString. If you want to interoperate with anything or serialize the Date as a string and then deserialize it later, then a standard format is going to be needed anyway. I made the mistake of putting toSimpleString in std.datetime when I created it (it comes from Boost but is completely non-standard), and toString currently uses it. I've debated switching it to use toISOExtString instead, and I may or may not make that change in the future, but regardless, it would just be bad practice to rely on the output of toString over using one of the to*String functions that guarantees a specific format. And all of that being the case, I think that it's a mistake to put in the documentation what format toString prints out. It prints out the Date as a string in whatever format it prints it. If you care about a specific format, then use one of the to*String functions.
I should probably just add notes to the toString documentation to make it clear that the format is not guaranteed to stay the same and that no one should rely on its format.

I think that it's a mistake to put in the documentation what format toString prints out. It prints out the Date as a string in whatever format it prints it. If you care about a specific format, then use one of the to*String functions.
I should probably just add notes to the toString documentation to make it clear that the format is not guaranteed to stay the same and that no one should rely on its format.

@Wulfklaue maybe you can add the notes to the docs directly in this/your PR?

It's wishful thinking to not want dependencies on the format of the output of toString.  The output of that api (really any api) is a defacto contract for the api and the longer the language and libraries live the stronger that dependency grows.  Might as well accept and embrace it since it's the practical reality.

The output of that api (really any api) is a defacto contract for the api and the longer the language and libraries live the stronger that dependency grows. Might as well accept and embrace it since it's the practical reality.

Ping @jmdavis for a decision

@braddr nailed it. As long as the code passes people will use it and assume the format.

@jmdavis is there a dependency on a global locale or something? If so, a comment // The exact format may depend on the selected locale should predate the assert.

@jmdavis is there a dependency on a global locale or something? If so, a comment // The exact format may depend on the selected locale should predate the assert.

For Date? No. There are really two issues here. One, it calls toSimpleString, which comes from Boost but probably should have never been in std.datetime, because it's non-standard and causes folks to think that it should do something with locales, because it uses the English abbrevations for the months instead of numbers. Because of that I've considered changed it to calling toISOExtString instead but have never made the change and arguably shouldn't for the reasons that Brad brings up. The other issue is that anyone who actually depends on the time format should either be using a standard time format or specifically using a custom format based on what they need (preferably the standard time format), and such usage should be explicit. toString is just for converting an object to a string and thus makes sense for debugging or simply printing out the date without caring much about the format, but if you actually need to transmit it to someone or store it in a database or something, then you should be using a function for a specific format appropriate for that. So, I definitely think that the use of toString for anything that depends on the format of the string should be strongly discouraged.


Reuse program

Also you have a mypy failure
$ check/mypy
cirq/google/engine/engine.py:434: error: Argument 2 to "_serialize_program" of "Engine" has incompatible type "Optional[SerializableGateSet]"; expected "SerializableGateSet"
The command "check/mypy" exited with 1.


Add support for --features and --no-default-features flags in workspace builds

When using cargo cmd --all --no-default-features on virtual manifest cargo should disable default features for all crates in the workspace. cargo cmd --all --features feature1,feature2 should enable feature if crate in the workspace has it and ignore it otherwise.
Old issue text:
In RustCrypto/hashes xargo is used in CI to verify if all crates are indeed no_std. But with the addition of std feature (see branch digest_v0.8) which per convention is enabled by default, xargo does not work correctly anymore. I've changed CI config to use the following command on workspace (Travis build):
xargo build --all --no-default-features --verbose --target armv7-unknown-linux-gnueabihf

But it fails with this error:
error[E0463]: can't find crate for `std`
  |
  = note: the `armv7-unknown-linux-gnueabihf` target may not be installed

It looks like that problem originates from the fact that cargo does not propagate --no-default-features when it builds all crates in workspace. In this particular case it causes digest (and all other crates) to be built with enabled std feature which is quite undesirable.
Is this behaviour intentional? In my opinion this flag (and others?) should be propagated to all crates in the workspace on which subcommand is called.
Old xargo issue.

The way serde_bytes, which depends on serde, and which both have optional no_std support, is doing it is via the following setup:
[features]
default = ["std"]
std = ["serde/std"]

[dependencies]
serde = { version = "1.0", default-features = false }

@est31
I am not sure why you wrote it here, as you can see for example here RustCrypto/hashes uses the same approach. (std feature in digest crate is disabled by default to simplify configuration a bit)

@newpavlov oh I see. nvm then :)

I think this is either a bug or a feature depending on how you look at it, right now the feature selection applies to a "root crate" (which doesn't have much meaning any more really) rather than all crates (aka if you specify --feature foo --all how would we interpret it where it works?)
In that sense this is sort of working as expected, albeit surprisingly.

aka if you specify --feature foo --all how would we interpret it where it works?

I think intuitive behaviour in this case will be to enable feature if crate in the workspace has it and ignore otherwise. At the very least if cargo does not support working with features when building workspace (aka virtual manifest) in my opinion it should display warning/error, as currently it's essentially ignores feature related flags.

Instead of disabling all features with --no-default-features, I need to enable a specific feature using --features foo, which is not possible right now when I put my crates in a workspace. :(

Duplicate of #5015.

@ishitatsuyuki I'd say that that bug is a dupe of this one, no? Because the other bug has been filed later.

@est31 I'm in favour of using #5015 because that one has a clearer title. This bug affects --features, not only --no-default-features.

I've updated issue title and text.

@ishitatsuyuki I see, that's a point.

Well, given that the title is updated, feel free to close #5015.

So, just stumbled upon this problem.
What is the recommended workaround?

I am likewise being bitten by this issue. It isn't clear how to properly work with features when you have a rather large workspace already in place. :D

In fact... none of my intuition has even lead me to a solution. If I have a crate in a workspace that must use a feature in order to build, unless I specify a default feature set then I'm unable to build my workspace now.
Specifying a default feature is a bad idea in this case, because if a developer wants to work on this crate, they can't use --no-default-features to override the default in order to work with the other features.
In my particular case the features are determining which graphics api to use, which means that any developers on osx wouldn't be able to develop or contribute to this project without unnecessary trouble.

Any progress? This is really counterintuitive right now.

package-features has been stabilized since 1.51. The member/feature syntax can be used to enable features defined in member packages.
cargo build --features member/feature

https://doc.rust-lang.org/cargo/reference/features.html#command-line-feature-options
https://doc.rust-lang.org/cargo/reference/features.html#resolver-version-2-command-line-flags


fix: SCIM access token compatible identifiers

Currently the GENERATE_SCIM_ACCESS_TOKEN fails because the results column is in lowercase when QUOTED_IDENTIFIER_IGNORE_CASE = TRUE is on account level. Solution would be to use UPPERCASE for the column so that the success of this function is not dependent on the QUOTED_IDENTIFIER_IGNORE_CASE parameter
Relates to #729
Test Plan

[x] acceptance tests

References

https://docs.snowflake.com/en/sql-reference/parameters.html#quoted-identifiers-ignore-case

/ok-to-test sha=7477bb6


deps: upgrade typing-extensions to v4

What was wrong?
typing-extensions v4 was released on November 15th, however the version pinning precludes it's use and causes several package conflicts due to too-tight pinning
How was it fixed?
Upgrading the package
Cute Animal Picture

I'm going to close since I just merged #122.


New imposm3 run background command

Automatically download and import OSM changes.

[x] add 'delay' for flush expire tiles when catching up after initial import
[x] documentation

This branch is based on expire-tiles.

Rebased and merged.


Skip virtualenv folder during execution

I'd like to suggest skipping the virtualenvs folders during execution or from folders that are not the project folder. Currently, I got other fixtures that are on my virtualenv. For instance:
Fixture name: celery_session_app, location: /Users/xxx/.virtualenvs/an-awesome-project/lib/python3.6/site-packages/celery/contrib/pytest.py:56
    Session Fixture: Return app for session fixtures.
Fixture name: celery_session_worker, location: /Users/xxx/.virtualenvs/an-awesome-project/lib/python3.6/site-packages/celery/contrib/pytest.py:77
    Session Fixture: Start worker that lives throughout test suite.
Fixture name: celery_enable_logging, location: /Users/xxx/.virtualenvs/an-awesome-project/lib/python3.6/site-packages/celery/contrib/pytest.py:94
    You can override this fixture to enable logging.

Just to make it clear: I'm not using those fixtures on my codebase.

#6

Thanks @jairhenrique!
I made a quick participation in a comment thread there.

fixed in #6