[SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values

What changes were proposed in this pull request?
This patch ensures accessing recorded values in listener is always after letting listeners fully process all events. To ensure this, this patch adds new class to hide these values and access with methods which will ensure above condition. Without this guard, two threads are running concurrently - 1) listeners process thread 2) test main thread - and race condition would occur.
That's why we also see very odd thing, error message saying condition is met but test failed:
- Barrier task failures from the same stage attempt don't trigger multiple stage retries *** FAILED ***
  ArrayBuffer(0) did not equal List(0) (DAGSchedulerSuite.scala:2656)

which means verification failed, and condition is met just before constructing error message.
The guard is properly placed in many spots, but missed in some places. This patch enforces that it can't be missed.
Why are the changes needed?
UT fails intermittently and this patch will address the flakyness.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Modified UT. It's not easy to reproduce (not often) so I'd feel safer to get reviewed by more eyes instead of blindly running test more times.

I'm also seeing inconsistency among this test suite how to verify failedStages. Some places access it directly, while other places access it via scheduler.failedStages. Some places convert it to Set, some other places use contains and length separately, some other places directly compare with Seq. Ideally it seems to be better to deal with this as well, but not sure we would like to deal with this here or another minor PR.

Can one of the admins verify this patch?

Maybe even better to extract the logic about "ensuring listener has no event to process" and "access failedStages" into method and always call this. It should help us not missing to wait for listener thread.

Can one of the admins verify this patch?

Test build #110209 has started for PR 25706 at commit 7808a01.

Test build #110212 has started for PR 25706 at commit ea3bc10.

There're so many authors in the file, but let me cc. to couple of committers who authored related code or reported this flakyness issue.
cc. @jiangxb1987 @vanzin @tgravescs @dongjoon-hyun

Test build #110209 has finished for PR 25706 at commit 7808a01.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110209/
Test PASSed.

Test build #110212 has finished for PR 25706 at commit ea3bc10.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 class EventInfoRecordingListener extends SparkListener

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110212/
Test PASSed.

Just commented where the waiting is missed.

Test build #110266 has started for PR 25706 at commit 3d999e9.

Forgot to thank you for providing brilliant idea to artificially fail the problematic tests. I've just applied 50ms of sleep on each onXXX method, and I've found 3 methods being failed. (They've marked as X. Just ignore ! as they failed on waiting listener in given timeout.)
When I applied same in this patch all tests marked as X passed.

Test build #110266 has finished for PR 25706 at commit 3d999e9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110266/
Test PASSed.

Retest this please.

Test build #110442 has started for PR 25706 at commit 3d999e9.

For me, this PR looks fine. Could you review this once more, @vanzin and @jiangxb1987 ? Thanks~
If there is no further comments, I'm going to merge this tomorrow.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15429/
Test PASSed.

Test build #110442 has finished for PR 25706 at commit 3d999e9.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110442/
Test FAILed.

retest this, please

Test build #110447 has started for PR 25706 at commit 3d999e9.

Test build #110447 has finished for PR 25706 at commit 3d999e9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110447/
Test PASSed.

Thanks all for reviewing and merging!

Thank you, @HeartSaVioR , @vanzin , @jiangxb1987 , @HyukjinKwon .
As @HeartSaVioR pointed here, the root cause is introduced at 2.4.0 via https://github.com/apache/spark/commit/e3486e1b9556e00bc9c392a5b8440ab366780f9b#diff-f3b410b16818d8f34bb1eb4120a60d51R1102 .
Since branch-2.4 is our LTS branch, can we have this in branch-2.4?
@HeartSaVioR . Could you make a backporting PR against branch-2.4? I guess that will be a reduced backport PR compared with this.

#25794 for branch-2.4


Mach-O thumb entry point issue

I think the Mach-O loader gets the entry point wrong for thumb binaries.
I made a small armv7/thumb2 binary and loaded it into binja. It's entry point is at 0BEC8, which gets created as thumb and labeled main(). Additionally, 0BEC9 is created and marked as thumb, disassembled misaligned. Thumb disassembly has a minimum alignment of 2, so 0BEC9 should never be a valid instruction.
I've attached the binary.
test_thumb.zip

Fixed in dev


Lightbox fix

Hey Elliott, when you get a second, can you fix the conflicts between this branch and master?

It would also be great if we can add a few things to this feature:

[ ] Email validation on form submission
[ ] A thank you template the appears after successful submission then self-closes after four seconds
[ ] Google Analytics event tracking

I added a file called Segment.js in admithub telescope theme. This file asks for a meteor settings variable that can be stored in our settings.json file alongside the shared auth key.

This breaks Linux (including heroku) because of inconsistency between the case of filenames and the names in package.js -- check lightbox.styl.
OS X's filesystem is case insensitive, so it works there, but it will fail on any case sensitive filesystem. (I'd fixes this previously but the commits here undo my fix).

I pushed a fix before deploying to stage.


[BUG] capabilities could not be synchronized when rerunning vela install

➜  /Users/zhouzhengxi/Programming/golang/src/github.com/oam-dev/kubevela/examples/testapp git:(docs-autoscale) ✗ k delete oam --all
applicationconfiguration.core.oam.dev "testapp" deleted
healthscope.core.oam.dev "testapp-default-health" deleted
component.core.oam.dev "express-server" deleted
➜  /Users/zhouzhengxi/Programming/golang/src/github.com/oam-dev/kubevela/examples/testapp git:(docs-autoscale) ✗ vela install
- Installing Vela Core Chart:
Vela system along with OAM runtime already exist.
Synchronizing capabilities from cluster⌛ ...
Sync capabilities successfully ✅ Add(0) Update(0) Delete(7)
TYPE       	CATEGORY	DESCRIPTION
-task      	workload	One-time task/job
-webservice	workload	Long running service with network routes
-worker    	workload	Backend worker without ports exposed
-autoscale 	trait   	Automatically scale workloads
-metric    	trait   	Add metric monitoring for workload
-route     	trait   	Add a route for workload
-scaler    	trait   	Scale replica for workload
- Finished successfully.
➜  /Users/zhouzhengxi/Programming/golang/src/github.com/oam-dev/kubevela/examples/testapp git:(docs-autoscale) ✗ vela install
- Installing Vela Core Chart:
Vela system along with OAM runtime already exist.
Synchronizing capabilities from cluster⌛ ...
Sync capabilities successfully ✅ (no changes)
TYPE	CATEGORY	DESCRIPTION
- Finished successfully.

✗ vela version
Version: 0.1.0
GitRevision: git-b641302
GolangVersion: go1.14.11

close we are deprecating the comand vela install

close we are deprecating the comand vela install


Enable number formatting on all chart types.

I'd propose to add numberFormat() method on all chart types not only on Legend. As I see you are using the numberFormat variable on all chart/tooltip types, but it's exposed only on Legend type. I don't see any reason for not exposing it for other types.
Expected Behavior
Formatting a number is possible for all chart/tooltip types where numberFormat is used.
Current Behavior
Formatting a number is possible only for Legend type.
Possible Solution
It should be as simple as adding numberFromat method to exports as it is on Legend.
 exports.numberFormat = function(_x) {
            if (!arguments.length) {
                return numberFormat;
            }
            numberFormat = _x;

            return this;
        };

Context
I use charts only for showing full numbers without any 0.5, 0.23 etc. I'd like to present number 4 to the user as just 4 not 4.00.
Your Environment

Version used: 2.0.0
Browser Name and version: Chrome 60
Operating System and version (desktop or mobile): Win 7

Hi @piotrsucharski , thanks for the issue!
That seems doable. There is a bunch of parameters that we haven't make open because we didn't know if they would be, so it makes sense for us to make them available as users like you need them.
Out of curiosity, in which specific charts would you need this?
Thanks!

I am using the following components:

Bar
Donut
Legend
Mini Tooltip
Tooltip
Brush
Line

Thanks!


move Extensions for server command into server command

imho it makes sense to move the list of extensions
https://github.com/owncloud/ocis/blob/master/pkg/micro/runtime/runtime.go#L32
from runtime to server command.
See command "simple" - should be aligned.

simple is 💀 closing this one.

simple is 💀 closing this one.


Crop Circles...

Hello,
Let me start by saying how awesomely complete this plugin is. Its great. There is just one minor thing that I had to look elsewhere for. A Circle shape for the cropper. It would be very nice to have to further round out this otherwise thorough plugin.
I looked into modifying myself but I didn't expect you to be using spans the way that you did. It kinda threw me off. So I am not sure how to get it in there. I could only come up with a CSS hack that doesn't really look good:
span.cropper-face.cropper-move::after {
  content: '';
  height: 100%;
  width: 100%;
  position: relative;
  top: 0px;
  bottom: 0px;
  left: 0px;
  right: 0px;
  display: block;
  border-radius: 100%;
  background-color: white;
  mix-blend-mode: soft-light;
}

span.cropper-face.cropper-move{
    background-color: transparent;
    opacity:1;
}

What I am really hoping for is something like this: ngImgCrop
Unfortunately this one has a bug that I cant figure out. When I apply a data: image from another canvas, for some reason the img-crop canvas dimensions are set to 0. Can't figure out why. Oh, and the canvas is being generated by html2canvas. But I don't think that should matter.
I know that he is making more use of the canvas to get a cleaner look. But I'm hoping that since you are more familiar with your code you would have a better idea on how to do this.

You can try to reset this class:
.cropper-view-box {
  border-radius: 50%;
}

Yes, that does look better. Still wish I had a way to either ditch those spans or manipulate them so that the rectangle is not visible at all and only the circle is.

Btw, thanks for clueing me in on that class. I will use this and hide the .cropper-line's and unwanted .point's:
.point-w, .point-e, .point-s,
.point-n, .point-ne, .point-nw, .point-sw{
	outline-color: transparent;
}

.cropper-view-box {
  border-radius: 100%;
  outline-color: transparent;
}

Sure would be nice to flip a flag in the options to apply these and maybe even repostion .point-se::before to line up with the new circle border.

Here is what I used to reposition the handle and scale up the crosshairs:
.cropper-center {
	-webkit-transform: scale(3.5);
}

.cropper-point.point-se {
  right: 12%;
  bottom: 12%;
  -webkit-transform: translate(100%, 100%);
}


Fix for LightOnOff example

Hi,
I think there is a little error in the LightOnOff sketch example.
 digitalWrite(PIN_RELAY, on ? HIGH : LOW);
should be
 digitalWrite(PIN_RELAY, on ? LOW : HIGH);
Thanks again for the great job on Homie-esp8266 !
Alex
Update : after new compilation, the behavior is correct...don't really understand why. Please ignore this issue.

Mmhm? If it is needed to switch the output to HIGH or LOW to switch the light/LED on, depends on how you wire the output.
It is more usual* to connect collector or cathode (e.g. of ULN2003) to the output, so in this case it is necessary to switch to LOW for on.
If you connect a single LED with its anode or an n-type FET you would need to send HIGH for on.

*) As most microcontrollers, the ESP8266 can sink more current than it can source.


feat(console): angular 11, replace ngx-moment with @angular/material-moment-adapter

This improves buildtime by 1 minute and speeds up the first contentful paint :tada:

looks good to me.
@livio-a @fgerschwiler should we merge this before or after u2f?
I would say before 😁

... before as well. implementing tests and improving multiple things for u2f right now
so might take some another day
and console will need to implement some stuff for WebAuthN as well

:tada: This PR is included in version 0.104.0 :tada:
The release is available on:

GitHub release
v0.104.0

Your semantic-release bot :package::rocket:


SyntaxError: EOL while scanning string literal

Describe the issue:
Environment:

NNI version: 2.2
Training service (local|remote|pai|aml|etc):local
Client OS:Windows 10
Server OS (for remote mode only): Windows 10
Python version: 3.8.10
PyTorch/TensorFlow version: 1.8.1+cu102
Is conda/virtualenv/venv used?: yes
Is running in Docker?: no

Configuration:

Experiment config (remember to remove secrets!):
authorName: default
experimentName: test_nni
trialConcurrency: 1
maxExecDuration: 1d
maxTrialNum: 50
#choice: local, remote, pai
trainingServicePlatform: local
searchSpacePath: search_space.json
#choice: true, false
useAnnotation: false
tuner:
#choice: TPE, Random, Anneal, Evolution, BatchTuner, MetisTuner, GPTuner
#SMAC (SMAC should be installed through nnictl)
builtinTunerName: TPE
classArgs:
#choice: maximize, minimize
optimize_mode: minimize
trial:
command: python train_nni.py
codeDir: .
gpuNum: 1
localConfig:
useActiveGpu: true
gpuIndices: '3'

Search space:
{   "start_lr": {"_type": "uniform", "_value": [0.0001, 0.1]},
"batch_size": {"_type": "choice", "_value": [8, 12, 16, 32]}
}

Log message:

nnimanager.log:
[2021-05-21 17:11:26] INFO [ 'Datastore initialization done' ]
[2021-05-21 17:11:26] INFO [ 'RestServer start' ]
[2021-05-21 17:11:27] WARNING [ 'Tensorboard may not installed, if you want to use tensorboard, please check if tensorboard installed.' ]
[2021-05-21 17:11:27] INFO [ 'RestServer base port is 2222' ]
[2021-05-21 17:11:27] INFO [ 'Rest server listening on: http://<IP_ADDRESS>:2222' ]
[2021-05-21 17:11:30] INFO [ 'Starting experiment: 5TQIR042' ]
[2021-05-21 17:11:30] INFO [ 'Setup training service...' ]
[2021-05-21 17:11:31] INFO [ 'Construct local machine training service.' ]
[2021-05-21 17:11:31] INFO [ 'Setup tuner...' ]
[2021-05-21 17:11:31] INFO [ 'Change NNIManager status from: INITIALIZED to: RUNNING' ]
[2021-05-21 17:11:31] INFO [ 'Add event listeners' ]
[2021-05-21 17:11:31] INFO [ 'Run local machine training service.' ]
[2021-05-21 17:12:01] INFO [ 'NNIManager received command from dispatcher: ID, ' ]
[2021-05-21 17:12:01] INFO [ 'NNIManager received command from dispatcher: TR, {"parameter_id": 0, "parameter_source": "algorithm", "parameters": {"start_lr": 0.006036625924380562, "batch_size": 16}, "parameter_index": 0}' ]
[2021-05-21 17:12:02] INFO [ 'submitTrialJob: form: {"sequenceId":0,"hyperParameters":{"value":"{\"parameter_id\": 0, \"parameter_source\": \"algorithm\", \"parameters\": {\"start_lr\": 0.006036625924380562, \"batch_size\": 16}, \"parameter_index\": 0}","index":0}}' ]
[2021-05-21 17:12:33] INFO [ 'Trial job vdk4F status changed from WAITING to FAILED' ]

dispatcher.log:
[2021-05-21 17:12:01] INFO (nni.runtime.msg_dispatcher_base/MainThread) Dispatcher started
[2021-05-21 17:12:01] INFO (hyperopt.tpe/Thread-1) tpe_transform took 0.001001 seconds
[2021-05-21 17:12:01] INFO (hyperopt.tpe/Thread-1) TPE using 0 trials
[2021-05-21 17:12:33] INFO (hyperopt.tpe/Thread-1) tpe_transform took 0.001993 seconds
[2021-05-21 17:12:33] INFO (hyperopt.tpe/Thread-1) TPE using 0 trials
[2021-05-21 17:13:06] INFO (hyperopt.tpe/Thread-1) tpe_transform took 0.002001 seconds
[2021-05-21 17:13:06] INFO (hyperopt.tpe/Thread-1) TPE using 0 trials
[2021-05-21 17:13:36] INFO (hyperopt.tpe/Thread-1) tpe_transform took 0.002002 seconds

nnictl stdout and stderr:

            Experiment start time 2021-05-21 17:11:18

File "", line 1
'import
^
SyntaxError: EOL while scanning string literal

This could have been fixed in this release. Could you try again by installing from master branch?

hello @creater-zq, this had been fixed in #3634, but what made your experiment failed is not this error. Can you try again by installing from master branch or waiting for v2.3 release?

when is the following release? I can't install from source (company proxy + my own limitations). Is there any workaround?

hello @externalsupplierstaff, v2.3 had been released! you can upgrade the version of NNI and try it


Remapping "less than" and "greater than" keys

Microsoft PowerToys version
0.69.1
Installation method
Microsoft Store
Running as admin
None
Area(s) with issue?
Keyboard Manager
Steps to reproduce

Launch Powertoys
Open Keyboard Manager
Open Remap Keys

Click on + button

From the drop-down menu, select "less than"
Map to [CTRL]+[,]

Click ok button

✔ Expected Behavior

with reference to numbering in the above steps, at number 7 I expected to find "greater than" in dropdown menu, instead only "less than" is present
Remapping is not working. Once I click [CTRL]+[,] nothing happens

Tried both as normal user as well as admin
❌ Actual Behavior

can't find "greater than" in dropdown menu
Remapping is not working. Once I click [CTRL]+[,] nothing happens

Other Software
n/a

What keys do you normally press to get that character?

Hi,
I don’t have them in my keyboard. Physical keyboard is us while on windows
have the Italian one.
On Sat, 29 Apr 2023 at 16:16, Jay @.***> wrote:

What keys do you normally press to get that character?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/25739#issuecomment-1528799135,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIP4YG4OXNPFTHIJ3JJSQ6TXDUPFJANCNFSM6AAAAAAXNZNS7I
.
You are receiving this because you authored the thread.Message ID:
@.***>

Can you type < without a shift key?  /needinfo
the KBM uses raw input vkey so if you can’t directly type it, it is not a valid input. Like on EN-us, a ? Isn’t a valid input by itself.

It's not CTRL + ,
It's SHIFT + ,

It's SHIFT + ,

That would be a shortcut

Can you type < without a shift key? /needinfo
the KBM uses raw input vkey so if you can’t directly type it, it is not a valid input. Like on EN-us, a ? Isn’t a valid input by itself.

Hi,
I don’t have < and > in my keyboard.
Physical keyboard is us while on windows I am using the Italian keyboard.
Reason for that: pc is American, I am Italian.
In this context I have no possibility to type < and/or > thus the need to remap then into that combination (my assumption was that Powertoys/keyboard mapping would help, isn’t that the objective of the tool?)
In my case I was trying to use [CTRL] + [,]

Flip the sides. You have them reversed.

/needinfo

Flip the sides. You have them reversed.

Please explain. What should I reverse?

The left and right column. Read it as "press ... to send..."

#25774

@lucarossetti you want "<" on the right side.

wait wait @crutkas you cannot do that. Read the example in the very screenshot above.
In fact you cannot have on the left side a combination of keys!
That is [CTRL] + [,]
Either [CTRL] or [,]

Then use "Remap a shortcut"

All right. This works. Now what about the "greater than"?

@Jay-o-Way the reason for asking is that I cannot find "greater than" in the "Mapped To:" dropdown list

@crutkas can you please advise where is "greater than" in the "Mapped To:" dropdown list?

Hi, I've been facing the same issue and I've found a work around.
Unfortunately, my solution doesn't involve PowerToys but a keyboard remapping program called "Key Manager".
It natively has the "<" symbol so remapping to it is fairly straightforward. For the ">" symbol, it's quite simple actually. Other than remapping, the program also allows you to paste certain text when a specific key is pressed. So, on the same key that I put the lesser than symbol on, I remapped that key to paste the text ">" when it's pressed with Alt. And voilà it works.
If ever you have a more elegant solution, I'm open!! I've looked at a lot of apps, and when the key isn't on the keyboard like in my case, this is the only solution I've found.

Same problem, am on a Swiss keyboard, but configured on top of a keyboard that only offers US layout, and I can't remap ### greater-than or  backslash, both are missing from your list.
Here's some context because other international users might ask you
international layouts sometimes don't have the exact same physical keys as the US layout. In my case, normally, the Swiss layout has an extra key next to the left-shift (here's a picture of my work laptop)

when using the Swiss windows layout on a US keyboard (I switched the keycaps), the shift key covers where the less-than, greater-than and backslash should be (here's a picture of my home keyboard):

So because I don't have a physical key that would normally be used to write those characters, I have to map another shortcut to type those characters.
remapper issue
Since the greater-than and backslash are missing from the list of available characters, I've tried going around the problem by opening settings.json, to add mappings manually, because I was able to remap the less-than character, and I figured I could reverse-engineer the json settings, but I don't know what the ID corresponds to, it's not the unicode code:

What is the numerical ID for greater-than and backslash?

A way to remap the greater-than to a key on your keyboard is to;
-->go into th PowerToys Keyboard Manager
--> go to Remap a shortcut,
--> select the + signe add shortcut remapping
-->on the left side you enter the Shortcut you want to map,
-->on the middle, pull out the Action dropdown list and choose send text,
-->bellow it (where it says keys) you enter the greater-than symbol (by help of the touch/virtual/visual keyboard, or by copying it from somewhere, say the internet, and pasting there),
-->select the target app,
-->then hit OK.
As shown in the picts below.


Strange Disk Activity

So today I noticed that the HDD activity light on my server was just perpetually on, but on the unraid Main page the read/writes on my drives/cache were mostly 0. I shut down all my dockers and checked them all because I figured it was just Plex doing something but it turned out to be MakeMKV, whenever I start the docker the activity light comes on and just stays light. Not sure what would be causing this since it didn't used to do this, but if you have any thoughts on how to troubleshoot it I would really appreciate it! Thanks!

Is the container's log showing any activity ?

Hmm here's the log file from the docker: https://pastebin.com/2JbZ7U4C
But as far as I can tell it's not actively doing anything, I tried running the top command through the terminal to see what processes were running but I didn't really learn anything useful there, although I'm very new to Linux so it's very likely I just don't know what I'm looking for lol

Try to run the command docker stats MakeMKV to see if the container is doing any BLOCK I/O.
On unRAID, you can also install apps that will help you figure out what is accessing the disks.  See https://www.reddit.com/r/unRAID/comments/8698zx/best_way_to_view_disk_activity_stats/

Okay so from the docker stats its saying that the Net I/O is 34.8kb/3.13kB and the Block I/O is 121MB/5.3MB.
I installed Glances too but the Disk I/O lists 0 read/write on everything, and I installed the Open Files plugin but that's a little less helpful because it only shows whats open and doesn't say what's actively being reading or writing

Do you see the Block I/O always increasing ?
Also, I thing the "File Activity" plugin may be useful.

Closing this issue, please re-open if needed.


Classrooms: Revise submit step, small copy changes

Part of https://github.com/studentinsights/studentinsights/issues/1696.
Who is this PR for?
K-5 teaching teams, particularly for teacher teams submitting lists to principals.
What does this PR do?
There wasn't a distinct "submit" step before, so this adds one to make the handoff and transition to principal explicit.  This PR saves the class list as "submitted" and prevents teachers from editing, but doesn't enable principals to make additional updates yet.  It has some copy revisions as well.
Screenshot (if adding a client-side feature)
Notes, feedback and submit confirmation

After submitting, readonly

Copy: Intro

Copy: More explicit caption for reduced lunch

Checklists

[x] Author checked latest in IE - Class lists
[x] Author improved specs for code in need of better test coverage
[x] Author included specs for new code

selfie


Reproducing few-shot experiments on Multiwoz2.1

Hi,
I am working on few-shot experiments on MultiWOZ2.1. However, I faced the same problem as in #7 .
BERT + pre + multi trained on few-shot dataset achieved ~0.49 JGA on the test set (with random seed 42).
I modified a small part of your codes, and the diff is listed here (GitHub comparing changes). I ran the experiment directly with DO.example.advanced.
Environment

GPU: RTX 3090
PyTorch: 1.7.0+cu110

I wonder if my training / evaluation process were wrong and got the high performance even in the few-shot setting.
Thanks for your reply in advance!

Apologies for the delay in addressing this issue. I don't fully understand your issue, are you saying that you're achieving higher performance than JGA of 0.49 using our few-shot setup?
I don't see any problems in your diff. One way to assert that there's no errors is to ensure that there is no data leakage in the MLM-pre and MLM-multi steps (i.e., that MLM in the few-shot case is only done on the few-shot data).


chore: remove actions-next-bundle analyzer in CI

Overview

Related with https://github.com/toss/suspensive/pull/1157#issuecomment-2254481894
Remove actions-next-bundle analyzer in CI.
PR Checklist

[x] I did below actions if need

I read the Contributing Guide
I added documents and tests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.60%. Comparing base (49546cf) to head (6f5887f).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1159   +/-   ##
=======================================
  Coverage   77.60%   77.60%
=======================================
  Files          62       62
  Lines         594      594
  Branches      116      116
=======================================
  Hits          461      461
  Misses        123      123
  Partials       10       10

Components
Coverage Δ

@suspensive/utils
47.16% <ø> (ø)

@suspensive/react
100.00% <ø> (ø)

@suspensive/react-query
72.18% <ø> (ø)

@suspensive/react-query-4
0.00% <ø> (ø)

@suspensive/react-query-5
0.00% <ø> (ø)

@suspensive/jotai
0.00% <ø> (ø)

@suspensive/cache
98.23% <ø> (ø)

@suspensive/react-image
80.39% <ø> (ø)


Expand our front-page readme a bit

Description of changes:
This adds a bit more information to our front-page github readme that I think helps give people a clearer "taste" of Kani, if they've been given a link to our page without any further information.
In addition, I expanded our comparison slightly to include links to more other tools of interest.
Testing:

How is this change tested? n/a

Is this a refactor change? no

Checklist

[ ] Each commit message has a non-empty body, explaining why the change was made
[ ] Methods or procedures are documented
[ ] Regression or unit tests are included, or existing tests cover the modified code
[ ] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

I completely agree with this idea. I think it's good to have directions and some brief introduction be as accessible as possible to new eyes.


Security: No boundary check on ocall_malloc

// EDL
void ocall_malloc(size_t size, [out] uint8_t **ret);

// Implementation
void ocall_malloc(size_t size, uint8_t **ret) {
    *ret = static_cast<uint8_t *>(malloc(size));
}

uint8_t **ret could be a pointer to memory in enclave. It could casue a arbitrary memory write in enclave.
Fix：
Add a wrapper function of ocall_malloc, checking the returned value with sgx_is_inside_enclave/sgx_is_outside_enclave. There is a sample below.
void wrapper_ocall_malloc(size_t size, uint8_t **ret) {
    ocall_malloc(size, ret);
    if (sgx_is_inside_enclave(*ret, size)) {
        // error
    }
}

Thanks for reporting this! I made PR #67, which implements your suggestion with one change: the wrapper is named ocall_malloc while the raw ocall is renamed to unsafe_ocall_malloc to reduce the chance that it is accidentally called in future code.


feat(client): add support for title case header names at the socket level

This introduces support for the HTTP/1 Client to write header names as title case when encoding
the request.
Need to work on tests.
Closes #1492

I noticed that the encode methods are not tested at the bottom of the file, but they are heavily tested in the integration tests of Client. I will add some tests for the title_case method and some integration tests to check for title cased headers through the client request.

I modified the client integration test macros to accept a title_case_headers parameter and I added a test using said change to ensure the client is encoding the headers as title case.
If you feel that this change is unnecessary because of the unit test, then I can revert that file back to its original state.

Hmm. The tests passed on my computer, but on Travis they flat out fail or crash.

The tests in CI failing are unrelated. I'm battling a race condition in the futures mpsc channel implementation, and still haven't gotten it working always, it seems.

It looks good to me, thanks!

Thank you very much!


ARK-client 1.4.2 Account balance not updated on main-screen. (macOS. 13.1)

A tiny minor bug:
after installing 1.4.2 and starting it for the first time it showed the previous account-balance. (I did a transaction while 1.4.1 was running last time, but that amount was still included on the balance.)
After restarting the ARK-client it updated and showed the right account-balance on the main-screen.
edit on November 20:

This happens on Windows 10 and macOS 13.1.
This happens every time, not just on the first run after the update to 1.4.2.

Did you click on refresh balances to update the list?

On specific account you also have this (if you have manually refresh enabled in settings):

@boldninja thanks, but the "problem" is on the -main- screen... you're in the account already on your screenshot. But... on the main screen there's a refresh too, I know. Ok, than it's not a bug, then it's a tiny design flaw I'd say. The refresh procedure or function should be called right after the program starts I'd say, then the account balance is always up to date. But I don't know... there could also be a good reason for this not to be automatic of course.

@alexbarnsley can you confirm if once you start client and get network connection balances are refreshed? Might be good to add if not yet.
When 1st connection to ARK network = success, call refresh function (only 1 time once it starts).

@alexbarnsley i can confirm this a bit more now. Each time you start the ARK-client it shows the balance from the last time the ARK-client was run.
I can confirm this to be the case on macOS 13.1, but also Windows 10.

I can confirm it doesn't refresh all accounts on network connection. There is a setting "Settings" > "Refresh accounts automatically?" which runs every 8 seconds by the looks of it, to refresh the current account. However, this is turned off by default.
I will add the functionality to refresh all accounts on network connection 👌

@alexbarnsley  is this in the 1.4.3 already? i'll check and confirm it...

@rdk1979 Yes

Confirmed... works perfectly now! Nice little improvement.
Thanks @alexbarnsley @boldninja


Navbar bottom dropdown bug

I will do a better investigation/write up later but just to put this on your radar for now...

Reduced test case on Codepen showing navbar bottom dropdown bug on small screens and down (width <= 768px). Dropdown appears briefly and then is hidden.

Nevermind now that I have read the Dropdown docs I see now I can add the dropup class to the dropdown. Updated the test case on Codepen and closing this.


Update README.md

Testing commit for CLA.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Record video in square

Is there any way i can record the video in square? fusumaCropImage just works for the image and not video

any news on that? record is in square, result is not. that sucks

@MarvinNazari It's possible now 👍

@ytakzk  how it's possible?


Fix rxjs operators support

I introduced tsup as a bundler to make this possible. Users should now be able to access rxjs-operators with typings. Also removed package-cjs.json and package-esm.json in favor of the tsup onSucess hook which does the same thing, in a more precise manner. Addresses #38

Fixed in https://github.com/lune-climate/ts-results-es/pull/45 based on your work, thank you @jacoobes


TODO: No usb controller found on this system.

While building a Vagrant box to be clean for testing deployment my self, I stumbled over a thing needs to be fixed sometimes later. Not to forget, I file an issue :smile:
It happens by using t2 list
WARNING: No usb controller found on this system.
INFO Searching for nearby Tessels...
/home/vagrant/app/t2-cli-t2-root/lib/usb_connection.js:232
  usb.getDeviceList().forEach(deviceInspector);
     ^
TypeError: Cannot read property 'getDeviceList' of undefined
    at USB.Scanner.start (/home/vagrant/app/t2-cli-t2-root/lib/usb_connection.js:232:6)
    at processImmediate [as _immediateCallback] (timers.js:367:17)

It needs a change here
or here. Maybe a simple
if(haveusb){
    usb.getDeviceList().forEach(deviceInspector);
    usb.on('attach', deviceInspector);
  } else {
      console.warn('WARNING: No usb controller found on this system.');

  }

is enough  here?

Hmm I thought it should be possible to find USB devices with the VM. @tcr can you comment?

@johnnyman727 there is no need for looking into. It will be my own misconfiguration finally. The issue report is only for necessary error handling - there are many silly users like me ;) ...
(but if someone knows the vagrant flag to enable usb ... this way didn't work for me - I assume I have used a bad base box - are there any Vagrantfiles you use internally for referencing and testing on MacOS, Windows, Linux - would save time ??)
Btw: The reason I do this is to figure out what error handling is necessary to provide answers to basic cases like no ssh installed (or what ever I will notice by testing on my reference VMs).
Also a note: The mdns-js seems to find only your own virtual tessels - not that one are running within other VMs or on other computers - is this known ? I am trying to figure out that last days - but if someone knows more at this point - could save time ;)

Thanks, Dan.
The mdns library should be able to find VMs on the network (it does for me), assuming those VMs are also connected to the network. Is your VM running a process called dns-sd?


Yum certification lapsed

Hey,
I wanted to install using yum as indicated in the ripgrep readme, but looks like the certification has lapsed.
https://github.com/BurntSushi/ripgrep/issues/2389 <--- link to an issue I posted to ripgrep github.

I just got the same certification complaint. It must be something on my
side maybe. I'll figure it out. And report back.
[image: image.png]
Never seen this before. Must be something goofy with the vm I'm running.
If I ignore the cert like recommended I can curl down that metadata, but I
don't receive a rpm I can yum install.
I don't know yum very well. I'll try to figure that out on my own, but if
you know what I should be doing instead and let me know that would be cool.
Thanks for the response,
On Wed, Jan 4, 2023 at 1:00 PM Carl George @.***> wrote:

I followed the same steps you mentioned in that other issue in a CentOS 7
container, and they worked fine for me. Even if there was some kind of
certificate error, I just managed that one Copr repo, not the entire Copr
infrastructure. Can you reproduce the error on other systems? Does a plain curl
https://copr.fedorainfracloud.org/coprs/carlwgeorge/ripgrep/repo/epel-7/carlwgeorge-ripgrep-epel-7.repo
work?
—
Reply to this email directly, view it on GitHub
https://github.com/carlwgeorge/ripgrep-rpm/issues/9#issuecomment-1371247871,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKYLBNBDONQUZ5AEH7Q56ILWQW3EDANCNFSM6AAAAAATQ6QDJU
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Judsen Hembree
(864) 506-3011

Yum just used curl underneath, so the issue has nothing to do with yum.  Even if you work around the problem for yum your system will still have issues with anything else that uses curl to reach external services (which is really common).  Once you get it sorted out then adding the copr with yum-config-manager should start working as well.  As this seems to be an issue specific to your machine I'm going to close this issue out.  Good luck.


Replace isAssignableFrom with == for final classes, refactor retrieveMethodAccessor

For final classes isAssignableFrom could be replaced with == to avoid calling native methods

Codecov Report

Merging #440 (2b5d293) into main (5236d34) will decrease coverage by 0.02%.
The diff coverage is 78.94%.

@@             Coverage Diff              @@
##               main     #440      +/-   ##
============================================
- Coverage     93.95%   93.92%   -0.03%
+ Complexity     2003     1999       -4
============================================
  Files           222      222
  Lines          4017     4019       +2
  Branches        384      382       -2
============================================
+ Hits           3774     3775       +1
- Misses          146      150       +4
+ Partials         97       94       -3

Impacted Files
Coverage Δ

.../java/net/datafaker/service/FakeValuesService.java
87.25% <78.94%> (+0.05%)
:arrow_up:

.../main/java/net/datafaker/service/FakerContext.java
84.61% <0.00%> (-2.57%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


⚠ Bofrost.at has degraded performance

In fd13d09, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1318 ms

Resolved: Bofrost.at performance has improved in 9d8809b.


[ZEPPELIN-1052] Application does not logout user when authcBasic is used

What is this PR for?
This PR is WRT to this mail thread (Authentication in zeppelin)
Where in if authcBasic mechanisim is used then on clicking logout, the user doesn't gets logout.
What type of PR is it?
[Bug Fix]
Todos

[x] -  set username and password false on logout

What is the Jira issue?

ZEPPELIN-533

How should this be tested?
In shiro.ini conf set /** = authcBasic, then start the zeppelin server.

try login as admin/password1
now try to logout (this should work)

Questions:

Does the licenses files need update? n/a
Is there breaking changes for older versions? n/a
Does this needs documentation? n/a

Tested this branch with both authc and authcBasic and logout works well. LGTM

Yeah it works well. LGTM 👍

Verified and It works.LGTM from me too

Merging this if no more discussion.

@prabhjyotsingh Thanks for the fix!
Seems like this PR is bringing CI error in master, branch-0.6:
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 81.986 sec <<< FAILURE! - in org.apache.zeppelin.integration.AuthenticationIT
testGroupPermission(org.apache.zeppelin.integration.AuthenticationIT)  Time elapsed: 42.459 sec  <<< ERROR!
org.openqa.selenium.TimeoutException: Timed out after 30 seconds waiting for org.apache.zeppelin.AbstractZeppelinIT$1@4c156b4b
Build info: version: '2.48.2', revision: '41bccdd10cf2c0560f637404c2d96164b67d9d67', time: '2015-10-09 13:08:06'
System info: host: 'testing-worker-linux-docker-8fa71dca-3379-linux-8', ip: '<IP_ADDRESS>', os.name: 'Linux', os.arch: 'amd64', os.version: '3.13.0-40-generic', java.version: '1.7.0_76'
Driver info: driver.version: unknown
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
	at org.openqa.selenium.remote.ErrorHandler.createThrowable(ErrorHandler.java:206)
	at org.openqa.selenium.remote.ErrorHandler.throwIfResponseFailed(ErrorHandler.java:158)
	at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:647)
	at org.openqa.selenium.remote.RemoteWebDriver.findElement(RemoteWebDriver.java:353)
	at org.openqa.selenium.remote.RemoteWebDriver.findElementByXPath(RemoteWebDriver.java:490)
	at org.openqa.selenium.By$ByXPath.findElement(By.java:361)
	at org.openqa.selenium.remote.RemoteWebDriver.findElement(RemoteWebDriver.java:345)
	at org.apache.zeppelin.AbstractZeppelinIT$1.apply(AbstractZeppelinIT.java:116)
	at org.apache.zeppelin.AbstractZeppelinIT$1.apply(AbstractZeppelinIT.java:114)
	at org.openqa.selenium.support.ui.FluentWait.until(FluentWait.java:238)
	at org.apache.zeppelin.AbstractZeppelinIT.pollingWait(AbstractZeppelinIT.java:114)
	at org.apache.zeppelin.integration.AuthenticationIT.authenticationUser(AuthenticationIT.java:109)
	at org.apache.zeppelin.integration.AuthenticationIT.testGroupPermission(AuthenticationIT.java:177)
Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"//div[contains(@class, 'navbar-collapse')]//li//button[contains(.,'Login')]"}

I was able to reproduce error that logout doesn't work by following:

start zeppelin with default shiro.ini
create Untitled Note 1 and set permissions to (admin, admin, admin)
go back to zeppelin main page (http://localhost:8080)
click Untitled Note 1
login as admin
click logout button -> doesn't work
Could you take a look please?

@minahlee, Thank you for review this.
With default shiro.ini i.e.
/api/version = anon
/** = anon
#/** = authc

Under Insufficient privileges "Login button" should not show up, sounds like a different bug to me, but if you refresh the page, the auth info will be removed.
And before merging this PR, when I saw travis log, it was failing for these two, and I assumed both were unrelated.
Results :

Failed tests:
  ParagraphActionsIT.testTitleButton:350 After Show Title : The title field contains
Expected: "Untitled"
     but: was ""

Tests in error:
  AuthenticationIT.testGroupPermission:177->authenticationUser:109->AbstractZeppelinIT.pollingWait:114 Â» Timeout

I'll open up a HOTFIX now, to fix CI.

@prabhjyotsingh Thanks for quick response. The steps I wrote was just for reproducing the case that logout action doesn't work because I couldn't reproduce it in my laptop with shiro setting in AuthenticationIT
And yes I agree that showing login button with insufficient privileges doesn't make much of sense.
Tests in error:
  AuthenticationIT.testGroupPermission:177->authenticationUser:109->AbstractZeppelinIT.pollingWait:114 Â» Timeout

This seems to happen because it is trying to find Login button after logout, but cannot since logout button is not functioning.
Attaching the screen shot from https://s3.amazonaws.com/archive.travis-ci.org/jobs/139763023/log.txt where selenium tries to find Login button:

@minahlee Thank you for much explanation about the issue.Have open up https://github.com/apache/zeppelin/pull/1084 to find and fix this issue, I'll try to resolve ASAP.

@prabhjyotsingh I got it working on localhost:8080, but not using ./grunt serve
Could you take a look?

@corneadoug, will surly look into it, in the mean while have created this a new jira for tracking the same https://issues.apache.org/jira/browse/ZEPPELIN-1125


Refactor weighted blended

This is an attempt to fix #207, and maybe implement the idea of re-using the rgba16uint picking texture for the accumulation texture.
In McGuire's blog it says that the reveal texture can be r8unorm. The extra bits of r16float help a bit, but don't seem that necessary - he argues that the memory it requires may not be worth it.

I also tried using rgba16uint for the accumulation texture, because if that works, we could re-use the picking texture and reduce the memory considerably. There are two downsides: 1) we'd need an extra pass to copy the picking data to a lower-res texture; 2) I don't seem to be able to use a 16uint texture with texture binding.
In more detail: when using an uint texture, you cannot access it via a sampler. I get that. But I also seem unable to bind it as a texture. But binding it as a storage texture also does not work, because as of late the only access for a storage texture is write-only. I think that maybe our wgpu-native snapshot is in between a transition that now effects the formats that we can use as textures.
I really hope that the current change is enough to fix #207.


cargo-expand: 0.4.19 -> 0.5.0

Motivation for this change
Update cargo-expand to the latest release.

https://github.com/dtolnay/cargo-expand/releases/tag/0.5.0

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@marsam Thank you!!


Behaviour change without major version bump.

It seems the behaviour of eql has changed but without bumping the major version. All of my project use should.js with ^4.0.4 (for example) in the package.json. I've done a fresh npm install in one of my projects and it errored where it didn't before.
This change seems to have occurred in v4.3.0.
I have a repo here that reproduces the issue.
My main issue is that this is a behaviour change which will be pulled in for any projects that use the ^ in the package.json.
vagrant@devenv:~/test-should-versions$ mocha

  should 4.0.4
    ✓ should pass

  should 4.1.0
WARN Strict version of eql return different result for this comparison
WARN it means that e.g { a: 10 } is equal to { a: "10" }, make sure it is expected
WARN To disable any warnings add should.warn = false
WARN If you think that is not right, raise issue on github https://github.com/shouldjs/should.js/issues
    ✓ should pass

  should 4.2.0
WARN Strict version of eql return different result for this comparison
WARN it means that e.g { a: 10 } is equal to { a: "10" }, make sure it is expected
WARN To disable any warnings add should.warn = false
WARN If you think that is not right, raise issue on github https://github.com/shouldjs/should.js/issues
    ✓ should pass

  should 4.2.1
WARN Strict version of eql return different result for this comparison
WARN it means that e.g { a: 10 } is equal to { a: "10" }, make sure it is expected
WARN To disable any warnings add should.warn = false
WARN If you think that is not right, raise issue on github https://github.com/shouldjs/should.js/issues
    ✓ should pass

  should 4.3.0
    1) should pass

  should 4.3.1
    2) should pass

  should 4.4.0
    3) should pass

  should 4.4.1
    4) should pass

  should 4.4.2
    5) should pass

  should 4.4.3
    6) should pass

  should 4.4.4
    7) should pass

  4 passing (252ms)
  7 failing

  1) should 4.3.0 should pass:

      AssertionError: expected [ { CustomerRef: '123456' } ] to equal [ { CustomerRef: 123456 } ] (at '0' -> CustomerRef, A has '123456' and B has 123456)
      + expected - actual

       [
         {
      +    "CustomerRef": 123456
      -    "CustomerRef": "123456"
         }
       ]

  2) should 4.3.1 should pass:

      AssertionError: expected [ { CustomerRef: '123456' } ] to equal [ { CustomerRef: 123456 } ] (at '0' -> CustomerRef, A has '123456' and B has 123456)
      + expected - actual

       [
         {
      +    "CustomerRef": 123456
      -    "CustomerRef": "123456"
         }
       ]

  3) should 4.4.0 should pass:

      AssertionError: expected [ { CustomerRef: '123456' } ] to equal [ { CustomerRef: 123456 } ] (at '0' -> CustomerRef, A has '123456' and B has 123456)
      + expected - actual

       [
         {
      +    "CustomerRef": 123456
      -    "CustomerRef": "123456"
         }
       ]

  4) should 4.4.1 should pass:

      AssertionError: expected [ { CustomerRef: '123456' } ] to equal [ { CustomerRef: 123456 } ] (at '0' -> CustomerRef, A has '123456' and B has 123456)
      + expected - actual

       [
         {
      +    "CustomerRef": 123456
      -    "CustomerRef": "123456"
         }
       ]

  5) should 4.4.2 should pass:

      AssertionError: expected [ { CustomerRef: '123456' } ] to equal [ { CustomerRef: 123456 } ] (at '0' -> CustomerRef, A has '123456' and B has 123456)
      + expected - actual

       [
         {
      +    "CustomerRef": 123456
      -    "CustomerRef": "123456"
         }
       ]

  6) should 4.4.3 should pass:

      AssertionError: expected [ { CustomerRef: '123456' } ] to equal [ { CustomerRef: 123456 } ] (at '0' -> CustomerRef, A has '123456' and B has 123456)
      + expected - actual

       [
         {
      +    "CustomerRef": 123456
      -    "CustomerRef": "123456"
         }
       ]

  7) should 4.4.4 should pass:

      AssertionError: expected [ { CustomerRef: '123456' } ] to equal [ { CustomerRef: 123456 } ] (at '0' -> CustomerRef, A has '123456' and B has 123456)
      + expected - actual

       [
         {
      +    "CustomerRef": 123456
      -    "CustomerRef": "123456"
         }
       ]

Yes, that is true. I assume this as a bug fix (was several issues about this in old repo, even in node about their assert.deepEqual implementation, and i several times found that bug), that is why i did not bump major version. I did some preparation for this. As you see first warn appeared at 4.1.0, which was published at 19 Oct. So i can do anything you think acceptable, but i will not return old .eql. Because 123456 is not equal "123456" and allowing shooting in leg is not an option.
As a suggestion i can add old version, and a key in should.config object to allow use old .eql implementation (the same in assert.deepEqual).
What do you think?

Another option i just bump major version.

I agree that it was a bug, and that it should have been fixed.
If you do a major version bump, that won't change the versions that are out there so I think that boat has sailed! So I'd be happy with the config option which will give me a chance to keep up-to-date with the library and fix the issue in my repos.
The other option which wouldn't involve any change to the library would be that I just use a fixed version until I can sort it out. However, there should be some in the documentation describing the behavioural change.
My preference would be for the config option

Try 4.5.0. Somewhere you need to set should.config.useOldDeepEqual = true. You can change it dynamically if it will be need.


Add Additional parameters for requestSpecification

Hey,
Thanks again for this great package. Here are few things i would request to add to request Specification.

HttpHeaders ( like Authorization and other basic headers doesn't need to be repeated )
Ability to ignoreHTTPSErrors ( set default to false )
proxy ( Network proxy )
Timeout
UserAgent

Let me know your thoughts on this.

Thank you @bheemreddy181, those all make sense. I’ll split this into separate issues (one for each property) later this morning, if that’s OK with you. I like my issues and changes small and many, makes it easier to separate discussion and release.

Sounds good to me

Do you think we will have an ability to specify headers at request spec level and append any additional headers which are provided at the actual test ?

Do you think we will have an ability to specify headers at request spec level and append any additional headers which are provided at the actual test ?

Yes, absolutely.

Sounds good thanks

Really looking forward into this addition

Really looking forward into this addition

So do I, just need to find some time to work on this properly. Hopefully later this week so I can release 1.1.0 with all the additions around the weekend.

@bheemreddy181 in the meantime, would you like to take a look at this one? See #23.

Added this in #23, so closing. Created separate issue for the support for the Content-Type header.


TODO:   Fix the Discourse Module

Current Discourse module will keep populating the top ranking list to 10s or 100s of entries.
Re-implement the logic to select the TOP N entries - with N anywhere from 3  to 15 ONLY.
Define a "module structure" that makes sense for these sort of "full stack reactjs components", beware it will always be executing on nextJS  (keep to JAMStack ideals).
Keep this work on ONE SINGLE PR.

@Sing-Li I would like to work on this issue. So we store the top N entries from the request in our CMS, repopulate them at intervals using cron jobs and make the top N entries accessible to the NextJS component depending on the parameters given to component ?

@samad-yar-khan that's correct. If you see the current codebase, we have a cron function calling the fetchTopPosts function. Instead of storing all possible entries store only the top N within the CMS.

@RonLek Got it ! I will start working on this.


Fix help message for --assetPath

As per
https://github.com/ionic-team/capacitor-assets/blob/main/src/index.ts#L67
the suggested command should be --assetPath and not --asset-path

If you plan to merge this do you mind adding the label HACKTOBERFEST-ACCEPTED? Thx :)

Thanks, taking a look at this I just need to normalize the config options, they got mixed with snake and camel casing

This has been resolved and out in 2.0.0 thanks


set modal focus state before showing

Hello,
I was having some issues with controlled inputs inside modals. When I would update the Modal after an input value changed, the input would suddenly lose focus. I managed to track this issue down to the Modal's focus state being set after the call to renderIntoSubtree(). This meant that the Modal wasn't be focused until the next render, when the input changed values.
Here is some React code to show what I mean:
import React from "react";
import {Modal,ModalBody} from "reactstrap";

class ModalWithInput extends React.Component {
  state = {};

  render() {
    return <Modal {...this.props}>
      <ModalBody>
        <input
          type="text"
          value={this.state.inputValue}
          onChange={(e) => this.setState({ inputValue: e.target.value })} />
      </ModalBody>
    </Modal>;
  }
}

Coverage remained the same at 100.0% when pulling 09dabf8a2068da9f10bca852a79b08e2ce447541 on tyler-johnson:modal-focus-fix into 869e5232da05dfbdfa787190e7f7d28a272a4f39 on reactstrap:master.

Thanks @tyler-johnson, great find!


Set the default language based on the Browser

Is your feature request related to a problem? Please describe.
At the moment it defaults to English
Describe the solution you'd like
Use something like js navigator.language to set the default Open-webui language
Describe alternatives you've considered
Use the browser language for the default language for the login page, but if the user changes it, respect it for the duration of the session. I think that would be the best UX

Possibly related, but not clear enough for me to make that decision on my own. I will still link the merged PR here for your own viewing: #1313

I believe at the moment openwebui defaults to english not matter your OS or Browser settings. That's OK for the admin but not for the endusers if planning to deploy it to more people, as if someone doens't know english they probably would have a hard time looking for the setting to change it.
I believe it's better UX to default to the OS/Browser language to ensure the user understands it. But then if the user changes it in the settings, respect that election while he is logged on.
If I have time I'll try to submit a PR.

Are you on the latest version? Language auto detection should be enabled by default: https://github.com/open-webui/open-webui/blob/9e4dd4b86f77653b59dc1fa97fe3f72e8252b359/src/routes/%2Blayout.svelte#L65

Are you on the latest version? Language auto detection should be enabled by default:
https://github.com/open-webui/open-webui/blob/9e4dd4b86f77653b59dc1fa97fe3f72e8252b359/src/routes/%2Blayout.svelte#L65

Hi! thanks for the response. I didn't notice this was already implemented as I just tested manually. This is what I've found with the info you provided.
Yes, latest version. I just checked and navigator.languages  can output non-default languages-combos
This is in Edge:

This is in Chrome:

It seems like:
navigator.languages[0]
in this case would pick "es" which doesn't correspond to any of the list compatible with openwebui

Maybe looping for the output of navigator.languages  until there is a match would be a better solution?

Feel free to make a PR!

Should be fixed on dev!


Task 400/accordion more progressive

This branch rewrites the accordion component so that it uses the details and summary elements which expand and contract in browsers. by default without any javascript.
It still uses javascript in order to apply open and closing animations.
CSS is modified to hide the default open/closing caret indicator and apply our design with a plus/minus icon only when the javascript executes by using :defined on the custom element name in the CSS selector
The plus and minus icons are created with CSS box shadows so the previously required separate components plus and minus are deleted
This is a breaking change for this component because the recommended markup is changed significantly. The major version is bumped to indicate the breaking nature of the update

I see you updated the markup example in components/accordion/README.md @aaronhans  - that's great.
Can we sync up on our desired workflow for breaking changes? It's a workflow we are going to need to convert into a step-by-step process so we can keep track of our preferred sequence.
To kick us off:

New development breaks markup.
Review the change in general, and also in the component UI.
Summarize the markup changes in human-readable format using diff of the change as source info.
Draft a communication to PM/content editors on the markup change
Do updates to content - QA the change notification to confirm that it's crystal clear with no issues.

I noticed that the package has already been updated. Did we put this component in a draft mode on npm already?
If not, it might be good to create a 2.0.0-rc version of the component for review while co-developing the notification of the breaking change - and then when the messaging about the change is completed, to do the package bump, including guidance on the difference with that version.
I will draft a message in the next comment.

We could do this in the CHANGELOG
2.0.0

Rewrite to use the details element which expands and collapses without requiring javascript. The javascript remains only for the animation. This radically improves progressive enhancement while reducing code size.
Make use of :defined to enhance design styles. This is available after the custom element's javascript has been executed.

Upgrade notes 2.0.0

Updated markup structure please refer to the README for the latest markup  example. See diff
When performing this component update, existing accordion markup content will need to be mapped to the new HTML structure in content. Any integrations will also need to update structure and content implementations.

A couple of other notes came to mind:

Update component documentation (content model)
Creating an upgrades page, with some suggestions of how to do this easily for a content team in hand-coded situations.

Good suggestions @chachasikes thank you! I'll:

integrate improved changelog text
review the content model
open a new ticket for a general upgrades page and we can include dependabot instructions there too

Those are good notes on the upgrade process.
There is difficult for the component consumer so our documentation could emphasize the steps taken before considering implementing a breaking change.
This is the process we went through so far:

Need for breaking change is approved by multiple members of design system engineering team
Update is prototyped and exercised independently of design system code updates
Multiple engineers review the potential change before integration into the design system is considered
Publish a -beta version of the npm package with the potential change
Integrate this change into at least 2 different sites using the component
Modify site code as required to preserve custom styling
Verify all component variations in both sites work as expected in all target browsers
If component has a corresponding Gutenberg block update the block code
Test updated Gutenberg block plugin by deploying it on site using latest version of WordPress

Todo:

Summarize the markup changes in human-readable format using diff of the change as source info.
Draft a communication to PM/content editors on the markup change

Regarding version publishing schedule: I published this as a -beta version while I was upgrading it on covid19 and in the Gutenberg blocks plugin. When those updates were working and ready for review I published the npm package v2.0 so it could be used in the final change request to those codebases. In this case the previous PRs to the design system site had already gone through review cycles against older site release branches.
Good point about an -rc version. This requires multiple updates to the sites where the new version was tested and the custom Gutenberg blocks plugin but we could follow a more conservative process, perhaps:

PRs to live sites using the component and the custom Gutenberg blocks plugin could go live initially with -rc version of the component's npm package
The v2.0 version of the component could be published to npm as the design system site change referencing it goes live.
All sites used for testing the latest version of the component and the custom Gutenberg blocks plugin would receive additional PRs to upgrade to the v2.0 once published

These are awesome notes! Thank you!
I'll copy this over to our process notes as a sub-page so we don't lose it in the issue log history until it has a forever-home.
This is the kind of stuff that I would expect could help other devs across the State - especially regarding knowing what happens when there are changes and what's involve in submitting a major improvement.
We could confirm this by sharing our process when new people start using this process.

(Also note for everyone - I'm the Release Ranger this sprint & I'm noticing process changes & making sure they get handed off to the next ranger)

You're right, thanks @zakiya

This shouldn't be merged until we have design approval. After design approval publish latest patch version to npm with changelog describing design fixes

Thank you @kmbrlygl for the excellent design review:
-[ ] Compared to the Figma mockup, the +/- icons are a lot bolder.
-[ ] I notice there are buttons (Hello, Goodbye) in the first accordion but doesn’t look like a button, so seems confusing so maybe we can remove or apply a button style
-[ ] If the point is to showcase the type of content it can contain, maybe we can put a list in another accordion to show versatility
-[ ] We mention using a h2 or h3 heading in the documentation, can we demonstrate that in the demo & markup? (Heading mentions are no longer appropriate so they have been removed from the readme)
-[ ] The second accordion title draws attention to itself and is unclear why. I suggest keeping it all the same or making them all different.
-[ ] Ideas: Title 1, Title 2…. (similar to Carbon DS) / Summary Title 1…2…
-[ ] If the point is to show a title that spans two lines, maybe: Title 1: Single-line, Title 2: Multi-line [Lorem ipsum text]

Thank you @kmbrlygl for reviewing the open icon live with me and tweaking the pixels. The changes we made are live on https://task-400-accordion-more-progressive.pr.designsystem.webstandards.ca.gov/pr/task-400-accordion-more-progressive/components/accordion/readme/

I am going to modify the changelog. Let me know if you as release ranger want to include this in the release branch it is targeting @chachasikes

Great work @aaronhans! Thanks for your diligence to get this looking great

@aaronhans

No changes to the component, looks good - changes to JS look good
Are there any accordions in DS page content that will need to be converted?
Thanks for updating the content model!

I don't see any accordions in the DS page content outside the accordion readme
Latest version 2.0.1 has been published to npm
This PR is ready for release


Customization - CSS in JS section needs an update?

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

Current Behavior 😯

Examples 🌈

Context 🔦

If you install react-jss via npm, currently it installs with version 10.0.0-alpha.7 which has breaking changes included.
So I guess it should be updated with below? Correct me if I'm wrong, thanks
- import JssProvider from 'react-jss/lib/JssProvider';
- import { createGenerateClassName, jssPreset } from '@material-ui/core/styles';
+ import { JssProvider, createGenerateId } from 'react-jss';
+ import { jssPreset } from '@material-ui/core/styles';

The new JSS v10 alpha seems to have deprecated the react-jss library, or at least the github repo, and there seem to be breaking API changes as well, the migration path of which is not clear.

@kof It seems that the react-jss npm tags are incorrect.

yeah, npm tags is a mess right now, need to find a way to set them each time with our current setup over lerna publish or drop lerna and do it differently

@pheuter what made you think react-jss is deprecated?

Last I checked the repo was marked as archived on GitHub, could mean
something totally different I just drew my conclusion from that.
On Thu, Jan 3, 2019 at 5:48 PM Oleg Isonen<EMAIL_ADDRESS>wrote:

@pheuter https://github.com/pheuter what made you think react-jss is
deprecated?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mui-org/material-ui/issues/14076#issuecomment-451302566,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFqGv3szikw74hvXpJz60FVc10vsUACks5u_ojVgaJpZM4ZoC-T
.

I guess writing it once in the project title is never enough...

@ifndefdeadmau5 react-jss tags have been fixed. We can close the issue. You should be able to use react-jss as before.

@kof I'm sure it's enough, I was just rushing and happened to miss it. Thanks for the clarification.

@oliviertassinari Thank you for quick fix 🙏


Analyser AD0001 Throws Exception VW2019

VSF_TYPE_MARKDOWNAfter upgrading to VS2019 the analyzer "Microsoft.EntityFrameworkCore.RawSqlStringInjectionDiagnosticAnalyzer" is throwing an exception and showing as a warning in the error list in VS.
This issue has been moved from https://developercommunity.visualstudio.com/content/problem/518155/analyser-ad0001-throws-exception-vw2019.html
VSTS ticketId: 839596
These are the original issue comments:
Tony Silvestri on 4/7/2019, 00:42 PM (79 days ago): Same error here
Visual Studio Feedback System on 4/8/2019, 00:14 AM (78 days ago): We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.
Steven Hargrave on 5/4/2019, 05:02 PM (51 days ago): Same problem here VS2019
Visual Studio Feedback System on 5/21/2019, 00:00 AM (35 days ago): Thank you for sharing your feedback! Our teams prioritize action on product issues with broad customer impact. See details at:  https://docs.microsoft.com/en-us/visualstudio/ide/report-a-problem?view=vs-2017#faq . In case you need answers to common questions or need assisted support, be sure to use  https://visualstudio.microsoft.com/vs/support/ . We'll keep you posted on any updates to this feedback.
These are the original issue solutions:
(no solutions)

@lajones, @ajcvickers looks like issues for EF Core are also being (semi?) automatically being transferred to the EF6 repo. Can I move this to the right repo or is there a reason it has to be here? The GitHub issue transfer functionality sets up redirects, so I think it should be fine.


analyzer/api: Improve e2e testing

SUMMARY

Add e2e tests for the staking/commission/validator endpoints.
ISSUE TYPE

Feature Idea

COMPONENT NAME

ADDITIONAL INFORMATION

The infra for e2e testing is now built in #142 , but these tests need to be written still.

https://app.clickup.com/t/3r2m45u

Comment from Mitja Trampus
e2e regression tests are a higher priority right now, e.g. e2e regression test: Support non-block analyzers ; they give us most of the bang for a lot less buck.
But for corner cases, synthetic e2e tests would still be useful. Example of a recent bug that we cannot easily verify via regression tests because it occurs so rarely: https://github.com/oasisprotocol/nexus/pull/517

This has been implemented in https://github.com/oasisprotocol/nexus/pull/627


Collision between two bodies with multiple shapes (explosion bug?)

Hi,
First, i want to thanks you for this great project!
I am trying to make a collision between 2 bodies (both with multiple spheres), but the result is not what i expected.
Am I doing something wrong, or is it an issue?
Could you please have a look?
Just go here: http://schteppe.github.io/cannon.js/demos/compound.html , paste this in the console and select the "Sphere2" demo:
demo.addScene("Spheres2",function(){
          var world = setupWorld(demo);
          world.gravity.z=-.02;
          var mass = 10;
          var body = new CANNON.Body({ mass: mass });
          body.velocity.x=.4;
          var body2 = new CANNON.Body({ mass: mass });
          body2.velocity.x=-.4;
          var sphereShape = new CANNON.Sphere(1);

          body.addShape(sphereShape, new CANNON.Vec3( 4, 0,-2));
          body.addShape(sphereShape, new CANNON.Vec3( 4, 0, 2));
          body2.addShape(sphereShape, new CANNON.Vec3( 4, 0,-2));
          body2.addShape(sphereShape, new CANNON.Vec3( 4, 0, 2));

          body.position.set(-2,0,6);
          body2.position.set(2,0,6);
          world.add(body);
          demo.addVisual(body);
          world.add(body2);
          demo.addVisual(body2);
        });

Hi,
I believe I've already fixed this bug. Try building the most recent master branch locally and it should work.
Thanks for using Cannon!
Stefan

Thanks! it works a expected now

Awesome! Let me know if you run into any other bugs.
Stefan


transfer simulation framework from proteolizard

This PR Draft is supposed to transfer the simulation framework of proteolizard-algorithm to pyims

This is the most perfect piece of code ever created! Good job!


Demo about how to output layout generation results under given partial category constraints

Hello, thank you for your excellent work. I have a question. If I want to specify some category constraints: it must contain 3 categories 1 and 2 categories 2. Then output the layout results. I would like to ask if you can give me a demo example for testing? grateful.

Hi, thank you for your interest in our project! Please refer to here.

Closed due to inactivity. Feel free to re-open if you have more questions!


Work around django-cache-machine redis breakage (bug 881405)

The latest version of django-cache-machine parses REDIS_BACKENDS incorrectly. See https://github.com/django-cache-machine/django-cache-machine/issues/92
This switches us to a fork that has a patch fixing that bug while we wait for that patch to be integrated into upstream master.

@jasonthomas r?

r+


$CELLULOID_MONITORING causes breakage?

I'm new to Celluloid and noticed $CELLULOID_MONITORING in the source.  I thought it might be helpful for learning and tried using it naively in an example, but it appears to cause two errors.

missing constant Celluloid::Probe
undefined method .terminate!

What am I doing wrong?
require 'celluloid/autostart'

$CELLULOID_MONITORING = true # Remove for "successful" second output below.

class UselessActor
  include Celluloid

  attr_accessor :value

  def initialize value
    @value = value
  end
end

p = UselessActor.new 1

Running with CELLULOUD_MONITORING = true produces:
$ ruby ./simpler_test.rb
An exception occurred running ./simpler_test.rb:

    Missing or uninitialized constant: Celluloid::Probe (NameError)

Backtrace:

                Module#const_missing at kernel/common/module.rb:667
              Celluloid::Actor#start at /home/rmichael/.rvm/gems/rbx-2.2.6@celluloid-learning/bundler/gems/celluloid-f5edcf9c1130/lib/celluloid/actor.rb:133
          Celluloid::Cell#initialize at /home/rmichael/.rvm/gems/rbx-2.2.6@celluloid-learning/bundler/gems/celluloid-f5edcf9c1130/lib/celluloid/cell.rb:43
  Celluloid::ClassMethods(Class)#new at /home/rmichael/.rvm/gems/rbx-2.2.6@celluloid-learning/bundler/gems/celluloid-f5edcf9c1130/lib/celluloid.rb:168
                   Object#__script__ at simpler_test.rb:21
    Rubinius::CodeLoader#load_script at kernel/delta/code_loader.rb:66
    Rubinius::CodeLoader.load_script at kernel/delta/code_loader.rb:152
             Rubinius::Loader#script at kernel/loader.rb:649
               Rubinius::Loader#main at kernel/loader.rb:831
D, [2014-03-18T22:02:30.551872 #28281] DEBUG -- : Terminating 5 actors...
An exception occurred running at_exit handlers

    undefined method `terminate!' on nil:NilClass. (NoMethodError)

Backtrace:

  Kernel(NilClass)#terminate! (method_missing) at kernel/delta/kernel.rb:78
        { } in Celluloid::ActorSystem#shutdown at /home/rmichael/.rvm/gems/rbx-2.2.6@celluloid-learning/bundler/gems/celluloid-f5edcf9c1130/lib/celluloid/actor_system.rb:72
                                    Array#each at kernel/bootstrap/array.rb:66
        { } in Celluloid::ActorSystem#shutdown at /home/rmichael/.rvm/gems/rbx-2.2.6@celluloid-learning/bundler/gems/celluloid-f5edcf9c1130/lib/celluloid/actor_system.rb:70
                               Timeout.timeout at /home/rmichael/.rvm/rubies/rbx-2.2.6/gems/gems/rubysl-timeout-2.0.0/lib/rubysl/timeout/timeout.rb:149
               Celluloid::ActorSystem#shutdown at /home/rmichael/.rvm/gems/rbx-2.2.6@celluloid-learning/bundler/gems/celluloid-f5edcf9c1130/lib/celluloid/actor_system.rb:66
                            Celluloid.shutdown at /home/rmichael/.rvm/gems/rbx-2.2.6@celluloid-learning/bundler/gems/celluloid-f5edcf9c1130/lib/celluloid.rb:156
            { } in Celluloid.register_shutdown at /home/rmichael/.rvm/gems/rbx-2.2.6@celluloid-learning/bundler/gems/celluloid-f5edcf9c1130/lib/celluloid.rb:148
                                     Proc#call at kernel/bootstrap/proc.rb:20
                 Rubinius::Loader#run_at_exits at kernel/loader.rb:710
                     Rubinius::Loader#epilogue at kernel/loader.rb:730
                         Rubinius::Loader#main at kernel/loader.rb:862

and, running without produces:
$ ruby ./simpler_test.rb
D, [2014-03-18T22:02:44.406391 #28305] DEBUG -- : Terminating 5 actors...

I can still reproduce this. Marking for 0.17.0 to get it cleared from the roadmap after a year of dormancy. If this is totally dead, let's close it though.

This appears to worked around or done. Any remaining pieces would be documentation of Probe which can be handled separately.


&#65279 after inserting a link

Jodit Version: 3.3.24
Expected behavior:
Just insert the link without "&#65279"
ee
Actual behavior:
After inserting a link the dom looks like
ee
"&#65279"

Having this issue too


Feature/remove context typees

change contextType component which update easily

Hi @dmt0
I have sent that PR mistakenly.
In that PR way, I can not do migration well, so I am making PR now in another way!


External definitions with conflicting Type fluent and Type.Ops static definitions cause errors

E.g @fp-ts/data/Option 's isSome and isNone, you want to define them as fluent (not getter) because they type narrow, but you also want to define them as static on the 'virtual' Option.Ops.
This however leads to when using Option.isSome that it tries to resolve the fluent function and therefore fails.
Actually, it seems there are other issues with e.g interface ReadonlyArray marked as Companion object; ReadonlyArray.map etc exists and leads to the default implement on the prototype instead:
    /**
     * Calls a defined callback function on each element of an array, and returns an array that contains the results.
     * @param callbackfn A function that accepts up to three arguments. The map method calls the callbackfn function one time for each element in the array.
     * @param thisArg An object to which the this keyword can refer in the callbackfn function. If thisArg is omitted, undefined is used as the this value.
     */
    map<U>(callbackfn: (value: T, index: number, array: T[]) => U, thisArg?: any): U[];

This seems to work for me (using branch pk/fixes) after adding the definition to the JSON and restarting tsserver

@0x706b I can still reproduce this on the latest of https://github.com/effect-ts-app/libs/pull/21
when I change packages/core/_src/Option.ts line 37,  function convert, into:
function convert(a: any) {
  return Opt.isSome(a) || Opt.isNone(a) ? a : Opt.fromNullable(a)
}

I get Expected 0 arguments, but got 1.ts(2554)

hm, my bad, this actually seems to work when you put the right definitions into place 😊


Include user documents

fixes #83
This PR is fairly significant, because it adds user documentation from the /doc folder into rosdoc2.
Notes:

The PR includes some previously submitted PRs (like PR #88) so I might need to rebase it before final.
Assuming PR #88, the items generated into the build document only show up in the docs_build folder, so there is no good reason to tag those with a 'generated/' directory. Also, as we add more items to rosdoc2, there are going to be additional things added. So instead I am using named directories for added things. Here I use 'user_docs', I also renamed the interface landing directory to 'interfaces'
The style that I have been using for the parent index has been 'category/details', where category is 'C++ API' or 'Python API' for example. Here I continued that, using 'Documents' as the category. Virtually everyone who customizes their index.rst puts each document instead at the top level of the index. But they are controlling the details of that. If there are a lot of documents, other important categories would get lost, so I think using a containing index entry "Documents" is preferable when that is going to be an unordered list of documents from a folder.
What to do with documents in subdirectories? Items like /doc/subdirectory/thedocument.rst are placed in the index with the name 'subdirectory/' with a corresponding .rst document created to list all of those documents.

To help with review, I processed packages that have /doc folders, and uploaded the results to http://test1.rosdabbler.com  You can also get some idea looking at the rendering of full_package in the test suite.
Much of the time the result is favorable. However there are a number of issues that can be seen.

Internal anchors are not working (like ## Overview [⬆](#swri_dbw_interface)
Some documents include embedded math or latex that is not being rendered properly, and instead shows up as embedded code gobbledygook, (like $$\begin{equation}\label{eq:QP}\tag{QP} )
Some documents include cross-reference to other documents that assumes things that don't exist in our implementation.

Some of these issues might be fixed with adding additional options to myst, or with other fixes. I am going to recommend though that we deal with those in followup PRs, rather than try here to fix issues in specific package renderings.

The others are merged and this now has a conflict, probably the fixups from before the merge.
The example output looks great such as rclcpp's API review just popping out http://test1.rosdabbler.com/rclcpp/
One I noticed as the fuse_doc directory here: http://test1.rosdabbler.com/fuse_doc/ that appears to have overridden the wrapper. Is that from a different test or did it's sphinx take over the wrapped invocation?

fuse_doc has completely replaced our generated index.rst and conf.py with their own. See http://docs.ros.org/en/iron/p/fuse_doc/ it should be no different.
This should be ready for review again.


Slide with a overflow-y: scroll break swipers horizontal touch events (on touch device)

Check that this is really a bug

[X] I confirm

Reproduction link
https://swiper-slider-js-rdjos8.stackblitz.io
Bug description
If a swiper slide contains a div with the style height: 100% and an overflow-y: scroll or overflow-y: auto the regular horizontal touch swipe is not working anymore. I use it to have scrollable content within the swiper slides. It used to work when I used the ionic6 swiper module for angular, but since you need to integrate swiper yourself in ionic7, i got this issue.
It seems that this is a pure css issue. When I remove:
.swiper-horizontal {
    touch-action: pan-y;
}

I can swipe again, but not vertically scroll. I can get either or not both.
Expected Behavior
Swiping should work as expected.
Actual Behavior
Horizontal swipe breaks. only the touch start event is fired and one touch move but not more.
Swiper version
9.x.x
Platform/Target and Browser Versions
Chrome 113, XPS17 with touch screen, or android 13 browser
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate. (#6363 doesn't work for the stackblitz I have)
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Please do the issues search first, it is related to touch-actions CSS

solved by not using a nested element then https://github.com/nolimits4web/swiper/issues/6363 will work


#69 notifyUpdateForAllById

@rultor merge.

@rultor merge.

@portlek OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge.

@portlek Done! FYI, the full log is here (took me 5min)


WIP - feat($route): wait for resolves

Based on #14159. Just triggering CI.

I'm cool with your version or my version.

I've just opened this one to run some tests on CI. Let's go with yours.


Port 1.7.10

Can you backport this mod to 1.7.10? please

No, but there it's a port of a 1.7.10 mod called Catwalks 2. No stairs but it has ladders that haven't been added to Catwalks 3 yet.
http://www.minecraftforum.net/forums/mapping-and-modding/minecraft-mods/2531592-catwalks-2


Add throw on number parse

When parsing a number, the parse function can return NaN. This PR adds a optional flag to throw an error .

Codecov Report

Merging #78 into master will decrease coverage by 0.94%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage     100%   99.05%   -0.95%
==========================================
  Files           3        3
  Lines         419      424       +5
  Branches       60       63       +3
==========================================
+ Hits          419      420       +1
- Misses          0        2       +2
- Partials        0        2       +2

Impacted Files
Coverage Δ

packages/toi/index.ts
98.28% <50%> (-1.72%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f3b0a...025dbf6. Read the comment docs.

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #78   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines         419    423    +4
  Branches       60     62    +2
=====================================
+ Hits          419    423    +4

Impacted Files
Coverage Δ

packages/toi/index.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f3b0a...b4577ea. Read the comment docs.

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #78   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines         403    423   +20
  Branches       53     62    +9
=====================================
+ Hits          403    423   +20

Impacted Files
Coverage Δ

packages/toi/index.ts
100% <100%> (ø)
:arrow_up:

packages/dynamo/index.ts
100% <0%> (ø)
:arrow_up:

packages/toix/index.ts
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3374024...c45a7cd. Read the comment docs.