Mapping Error MB

Im receiving this "Mapping Error MB" Under Clients Section

Openvpn-UI takes this information from OpenVPN server management console, which should be enabled (first line management <IP_ADDRESS> 2080 in your server.conf), up and running.
If you running 2 containers (openvpn server and openvpn ui) - both containers should use the same Docker subnet and management console must be available from openvpn-ui container (by default it takes container name openvpn to address  management console.
What you have to do for fix:

Confirm you have management console enabled on port 2080 in server.conf.
Confirm your openvpn service/container is up and running (docker ps | grep openvpn).
Confirm you have access to management console from host server (with netcat):

yejik@superserv:~ $ nc -zv $(docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' openvpn) 2080
Connection to <IP_ADDRESS> 2080 port [tcp/*] succeeded!
yejik@ superserv:~ $

Confirm you have access to management console from the openvpn-ui container:

yejik@ superserv:~ $ docker exec openvpn-ui sh -c "nc -zv $(docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' openvpn) 2080"
<IP_ADDRESS> (<IP_ADDRESS>:2080) open
yejik@ superserv:~ $

if you do have access between containers, than, please share the start logs for both openvpn and openvpn-ui containers (docker restart openvpn; docker restart openvpn-ui; docker logs openvpn; docker logs openvpn-ui)

Can u provide a solution for a different scenario?
I have installed the OpenVPN server and OpenVPN-ui on an On-Prem Server
intel i7 2nd gen 8gb ram and 256gb sata SSD(old-pc)
OS: Ubuntu Server
Here is what I have done so far:

I installed the OpenVPN server using OpenVPN-install-script
I have cloned the Openvpn-ui repo and installed it using standalone-install.sh I have followed all the steps given in the GitHub and was successfully able to install without any issues
When I opened openvpn-ui(web interface) and found this issue

Can u please walkme through to fix this issues

Then you need to update Management interface address in Openvpn-UI.
Login to UIU, go to Configuration > OpenVPN-UI and change openvpn:2080 to <IP_ADDRESS>:2080.
But before confirm it is available: nc -zv <IP_ADDRESS>:2080.

<IP_ADDRESS>:2080: forward host lookup failed: Unknown host


Add fine-grained tracing hooks

Codecov Report

Merging #8473 (d528731) into master (e7a2f5b) will decrease coverage by 43.57%.
The diff coverage is 39.07%.

:exclamation: Current head d528731 differs from pull request most recent head e9b32e2. Consider uploading reports for the commit e9b32e2 to get more accurate results

@@              Coverage Diff              @@
##             master    #8473       +/-   ##
=============================================
- Coverage     70.68%   27.10%   -43.58%
=============================================
  Files          1663     1661        -2
  Lines         87288    87212       -76
  Branches      13210    13203        -7
=============================================
- Hits          61697    23642    -38055
- Misses        21305    61353    +40048
+ Partials       4286     2217     -2069

Flag
Coverage Δ

integration1
27.10% <39.07%> (+<0.01%)
:arrow_up:

integration2
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../request/context/predicate/IsNotNullPredicate.java
0.00% <0.00%> (-69.24%)
:arrow_down:

...mon/request/context/predicate/IsNullPredicate.java
0.00% <0.00%> (-69.24%)
:arrow_down:

...ot/common/request/context/predicate/Predicate.java
100.00% <ø> (ø)

...pql/parsers/PinotQuery2BrokerRequestConverter.java
0.00% <0.00%> (-89.19%)
:arrow_down:

...core/query/executor/ServerQueryExecutorV1Impl.java
77.98% <0.00%> (-4.59%)
:arrow_down:

...t/core/query/selection/SelectionOperatorUtils.java
53.09% <0.00%> (-40.40%)
:arrow_down:

...rg/apache/pinot/core/util/trace/DefaultTracer.java
0.00% <0.00%> (ø)

...local/realtime/impl/json/MutableJsonIndexImpl.java
0.00% <0.00%> (-86.41%)
:arrow_down:

...al/segment/index/readers/LuceneFSTIndexReader.java
0.00% <0.00%> (-76.48%)
:arrow_down:

...t/index/readers/json/ImmutableJsonIndexReader.java
0.00% <0.00%> (-75.37%)
:arrow_down:

... and 1251 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a2f5b...e9b32e2. Read the comment docs.


Peers data not saved on Windows 7

Getting reports of issues on Windows 7, where peers.dat isn't saving, so every time it tries finding new peers from scratch. Sorting out a testnet seed for now, but we need more testing on Windows 7.
Problem does not manifest on Windows 10.

Looks like the node is crashing during the save process, which is why it's also not saving fees in that one case.

Seeing something similar on an Ubuntu VM, where closing the client during first sync...


Preact+Webpack update + misc

A bundle of updates.
I had to solve the issue of FOUC so I could continue to use this extension. In the process, I upgraded dependencies and fixed spelling errors.
~I haven't bothered upgrading ESLint. It is currently trying to parse JSON as JS.~
Now upgraded!

Please merge this. Tested it and it fixes the flash of content on navigation.

Thanks Brandon.  Although npm install it today flags 87 vulnerabilities of which npm audit fix resolves all but 5 of them.

$ npm audit
found 0 vulnerabilities

I've updated to Preact X.
All packages are now updated with the exception of the component library. That should be a seperate PR.
@johnmee @eejdoowad
Ready for review. I've been using my fork for a long time, so it would be great to see this finally merged in!

Oops. I see on a fresh install the menu is empty. I believe I had this issue last time which is why I didn't go to Preact X. If you guys have pointers why this could be happening that would help.

Alright. The issues are sorted and everything is now working with Preact X! Ready for review and merge.

That's a massive update! Thanks for taking the time to upgrade dependencies, refactor code, fix major bugs, and add new features. I've reviewed the file changes and tested the updates on Firefox and Chrome, and everything checks out.
I'm merging this change now, but a production release will be delayed until I resolve a bug that breaks settings when the extension updates.

Glad to see this merged @eejdoowad
Do you have the update issue in the tracker?

Just made one: #287. I haven't had a chance to work on it. It will probably be a challenging bug to replicate/resolve. Do you want to try tackling it? Otherwise I'll give it a shot this weekend.

Thanks. I'm not able to reproduce that so it would be better if you worked on it.


Is it possible to change camera dynamically ?

I am using this code but it works only for the first time:
    this.mapView.latitude = latitude;
    this.mapView.longitude = longitude;
    this.mapView.zoom = 4;

In order to fix this issue i parsed latitude and longitude as number.
this.mapView.latitude = Number(latitude);
this.mapView.longitude = Number(longitude);
this.mapView.zoom = 4;


Don't break @:skip fields when resetting cached & unlocked objects

Unlike in Neko, in PHP a field can no longer be accessed after it has
been removed with Reflect.deleteField.  Use Reflect.setField instead.
Not bothering with clearing the fields of cache items was considered,
but would make the behavior @:skip fields less predictable, besides
potentially breaking user code.
Related: HaxeFoundation/haxe#8016 ("Possible PHP7 haxe.Serializer bug")
Closes: #34 ("Synchronizing the fields")

Jonas,
First, thanks again to take time to test my case and for your answer.
Then, sorry for Sqlite, I've never used that, I'll take care in the future.
With your fix, it works fine now only because it's a getter that check if my field is null and set it. So when it's nulled by the Manager, it's recreated of course...
I've written a smaller sample which shows that your fix (and the old code lines) doesn't work in a special case.
Here is the Main file :
import haxe.Serializer;
import haxe.Unserializer;

import sys.db.TableCreate;
import sys.db.Sqlite;
import sys.db.Manager;
import sys.db.Types;

class Object extends sys.db.Object{
	public var id	: SId;

	@:skip
	public var foo	(get, set)	: String;

	@:skip var _foo	: String;

	function get_foo(){
		if ( _foo == null ){
			_foo = "bla";
		}
		return _foo;
	}

	function set_foo( s : String ){
		_foo = s;
		return _foo;
	}

	function hxSerialize( s : Serializer ){
		trace( _foo );
		s.serialize( id );
	}

	function hxUnserialize( u : Unserializer ){
		id	= u.unserialize();
	}
}

@:table( "tag" )
class Tag extends Object{

	public var name	: SString<255>;

	override function hxSerialize( s : Serializer ){
		super.hxSerialize( s );
	}

	override function hxUnserialize( u : Unserializer ){
		super.hxUnserialize( u );
	}

	public function new(){
		super();
	}

}

class Main {

	static function main() {
		Serializer.USE_CACHE	= true;

		Manager.cnx = Sqlite.open(":memory:");
		Manager.initialize();
		Manager.cleanup();

		TableCreate.create(Tag.manager);

		var tag = new Tag();
		tag.name = "tag_name";
		tag.insert();

		trace( 0 );

		var tag	= Tag.manager.get( 1, false );
			tag.foo	= "bla";

		trace( 1 );

		Serializer.run( tag );

		trace( 2 );

		tag.lock();

		trace( 3 );

		Serializer.run( tag );

		trace( 4 );
	}
}

And I've just added some traces in the Manager too like that :
for ( f in Reflect.fields(c) ){
	trace( c, f, Reflect.field( c, f ) );
	Reflect.setField(c, f, null);
}

This are the traces output :
```
src/Main.hx:68: 0
  src/Main.hx:73: 1
  src/Main.hx:30: bla <------- OK
  src/Main.hx:77: 2
  sys/db/Manager.hx:673: tag#1, name, Peace spreader
  sys/db/Manager.hx:673: tag#1, _foo, bla    <-------------- OK
  sys/db/Manager.hx:673: tag#1, id, 1
  sys/db/Manager.hx:673: tag#null, cache, { id : 1, name : Peace spreader }
  sys/db/Manager.hx:673: tag#null, _lock, false
  sys/db/Manager.hx:673: tag#null, _manager, [object sys.db.Manager]
  sys/db/Manager.hx:693: tag#1, name, Peace spreader
  sys/db/Manager.hx:693: tag#1, _foo, null   <-------------- NULL
  sys/db/Manager.hx:693: tag#1, id, 1
  sys/db/Manager.hx:693: tag#1, cache, { id : 1, name : Peace spreader }
  sys/db/Manager.hx:693: tag#1, _lock, true
  sys/db/Manager.hx:693: tag#1, _manager, [object sys.db.Manager]
  src/Main.hx:81: 3
  src/Main.hx:30: null  <------ NULL
  src/Main.hx:85: 4

As you can see it's the same object, I just locked it between 2 serializations and it lost its foo field.
It's a bit complicated case because the getter foo works with another field, if not, it works fine, but if I want to access this _foo field, it will be wrong (it's private here but let's say it's public one, it fails)

In fact, we can reproduce this "bug" like that :
import sys.db.Manager;
import sys.db.Types;
import sys.db.TableCreate;
import sys.db.Sqlite;

@:table( "tag" )
class Tag extends sys.db.Object{
	public var id	: SId;
	public var name	: SString<255>;
        @:skip
	public var foo	: String;

	public function new(){
		super();
	}
}

class Main {

	static function main() {
		Manager.cnx = Sqlite.open(":memory:");
		Manager.initialize();
		Manager.cleanup();

		TableCreate.create(Tag.manager);

		var tag = new Tag();
		tag.name = "tag_name";
		tag.insert();

		var tag	= Tag.manager.get( 1, false );
		tag.foo	= "bla";
		trace( tag.foo );
		tag.lock();
		trace( tag.foo );
	}
}

But for my needs I used the serializer because I do things with a @:skip ed field inside hxSerialize function...

@jonasmalacofilho Hej, do you think is it normal please ?

@filt3rek I'm still considering what to do here...
Your last example showed an important point: an apparently "simple" lock() call can cause the field to be cleared.
At the same time, we still need to consider the issue the current code tries to solve: what happens if the object changes on the DB and then gets reloaded by a later SPOD call?
I think that simply keeping the field would be very bad (and worse than the current behavior): the field would still get out of sync, but there would no longer be a way for the owner of the object to test that had happened.
So my question to you is: in your real world use case, can you simply replace the physical field by a property, or add one to wrap the field and handle the null case (like you did in the examples)?
(I also plan to search for users of @:skip feature on GitHub and see what they're using it for...)

@jonasmalacofilho thanks for your answer, I didn't know you have taken in account my examples.
What about me is not very important because for me I almost always find a way to do what I want but it was in order to have a better behaviour for the lib for the future for all of us :) I don't find logical to reset the entire object when doing a lock. Maybe we should have a kind of public method like "synchronize" or something like that which do the stuff explicitly ? And even here I still don't find logical to touch fields that are not SPOD fields. When synchronizing data, we should only touch the fields that are used in DB not these with @:skip. It's my opinion, maybe I miss something.
And here in my concrete application I use a getter as you have seen get_xfields.
Thanks anyway for your work

Hello, I agree with @jonasmalacofilho  ... locking an object makes a request like "SELECT * FROM MyTable FOR UPDATE" which will resync all the fields from the database.
Then this seems logical to also clear the @:skip fields in that case, because the values of this @:skip fields will - in most cases- be related to the other regular fields values.
Don't forget that SPOD has been designed to be used with InnoDB transactions.

Yeah all the fields from database, all is said, not these which are not used in DB.
I disagree with this kind of behaviour, it's not logical for me, but if everybody is ok with that, at least we should say in the doc that locking an object make it completly reset.
Where is it told that SPOD has to be used with InnoDB transaction ? It works with InnoDB better (because is also works with MyISAM) but I've never seen that it must be used with transactions. Now, maybe I've missed that.

Well you're right, its not written in the Readme.md that it should be used with InnoDB transactions, but using "FOR UPDATE" statements makes no sense outside InnoDB transactions  ( https://dev.mysql.com/doc/refman/8.0/en/innodb-locking-reads.html ) ...
I guess it has no effect for a MyIsam table.   There is a workaround for your case : you can always get objects with a lock since the beginning then you won't have any field cleared later. ( User.manager.get(1,true) )
Maybe we should talk about this in the documentation.

Yes for InnoDB constraints like cascading, etc., when used with InnoDB it works like in MySQL.
But for simple relations for example, you can also use MyISAM, it will bring you the relations in SPOD, not simply the "id".
I know there are workarounds, I always succes in what I want to do (yeaaaah :sunglasses: :laughing: ) but I'm talking for other users, to be more clear about the behaviour.


Publication date field indexed using solr date type

Should be good to go.

This is looking pretty good, a couple comments:

We should allow dates in the form of YYYY, YYYY-MM, or YYYY-MM-DD.

The changes in this PR have introduced a number of new Rubocop offenses, run rubocop from the project home directory to see a full list. (Some of these existed previously, so not every offense needs to be addressed, but if you can try and fix as many of the ones that are related to the new changes as possible, that would be great.)

This looks like it may be a bit more complicated than it appears. With Solr date objects, the time component looks to be optional and will be filled out by Solr with (i.e. entering a  publication_date_start to 2016-05-05 will produce "publication_date_start_dtsim":["2016-05-05T00:00:00Z"]. However, there is no contingency with regards to years or year/month combinations.
It looks like, in order to do this, we'll need to take advantage of Solr's DateRangeField, which supports single dates but expands to allow ranges. This requires a bit more tweaks to the solrizer gem, but I'd like to discuss this before making major updates. As we discussed, the Solrizer gem isn't being used the same way now. I'm not sure how this changes development, as the documentation is sparse.

Can we work on reducing the number of Rubocop offenses? Most of the ones that have been introduced by these commits should be pretty easy to fix, I think.

Doing some testing, I noticed this issue:
As an admin user
When I am on the 'Add New' form for Article or Issue
And I enter a date in the 'Publication Date' field and click Save
The publication date is stored correctly in Fedora and Solr
But when I click the 'Edit' button for that work
The previously saved publication date is missing

Also, I wonder if it might be possible to DRY some of the indexing/validation stuff?

date range indexing
Both NewspaperTitleIndexer and NewspaperContainerIndexer have (basically) the same code for the date range indexing. We could possibly combine these into a single method in NewspaperWorks::NewspaperCoreIndexer that can be called from NewspaperTitleIndexer and NewspaperContainerIndexer?

publication_date_valid
This method is repeated in both NewspaperArticle and NewspaperIssue. We could possibly create something like NewspaperWorks::PublicationDateValidator in app/validators/newspaper_works/publication_date_validator.rb that would then get included in the models? (See Hyrax HasOneTitleValidator for an example.)

publication_date_start_valid, publication_date_end_valid, publication_date_start_before_publication_date_end
These 3 methods are duplicated in NewspaperTitle and NewspaperContainer. Could possibly pursue validator pattern described above?


PGD torch device inconsistency

on this line https://github.com/DSE-MSU/DeepRobust/blob/master/deeprobust/image/defense/pgdtraining.py#L219
adversary = PGD(self.model)
You guys forgot to pass in the self.device parameter, which results in inconsistency between the device in the PGD class and the PGDTraining class. I believe the correct code should be
adversary = PGD(self.model, device=self.device)
Can you guys fix that code? Thanks! :D

find the same error


Self awareness for MDW instances for things like asset imports and cache refreshes

Currently, whenever there's an asset import or a cache refresh, MDW performs a propagation of the action by sending a message to each of the other instances as configured in mdw.server.list property.   This is not a viable approach in the case of PaaS since instances can be scaled up and down on demand, and we have no way of knowing how many, or how to reach each one directly (i.e. PCF, Docker, etc).
Each MDW instance will need to be self aware of the need to import assets or refresh cache based on saved state information in the database (i.e. last commit, timestamp of last cache refresh, etc), by checking periodically if it needs to perform any of these actions.

With this can we get rid of the IsIntraRequest concept in AccessFilter?

Crawler has been committed.  Still needs some testing in different cases, like jsx pages.


BMI088: Bug fix scheduling interval.

Just came across this bug while working on something else.  Not sure who "owns" this driver, but figured someone might care about this.
And then I found another instance of this same bug in the BMI055 driver.  There may be more of these.

Ha! Looks like we just got lucky with the numbers (both 1000).

Build failure. https://github.com/PX4/Firmware/runs/531773676?check_suite_focus=true
You need to add "using namespace time_literals".

You need to add "using namespace time_literals".

Ah, that's where that operator comes from.  I was having a hard time finding that.


Exchange

Exchange

Deployed here: https://thegraph.com/explorer/subgraph/sushiswap/exchange
Will merge in once checks are done to ensure data is all correct.


#8 update nestjs to v7 and update the other dependencies, add prettie…

…r linting

:tada: This PR is included in version 1.0.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fixed sorting, now case-insensitive (Summit)

jenkins retest this

jenkins retest this. This time it will save the server logs.


Deactivating Embargos

If a work has been previously embargoed, then the embargo is deactivated, the work will remail private indefinitely until it's edited to be public or some other visibility.

This is an issue on staging also


Room setting constantly lost

Describe The Bug:
After choosing a custom Room for my Beam device, the room is lost and resets to the default Room. This has been happening for months/as long as I've used the plugin.
To Reproduce:
I'm not sure how long it takes to reset to default room, but it is definitely =<24 hours.
Expected behavior:
The Room setting is retained forever just like all other devices.
Environment:

Plugin Version: v0.3.0 (2023-01-02)
Homebridge Version: v4.50.2
Node.js Version: v16.16.0
NPM Version: ?
Operating System: Raspbian

Love the plugin, thanks in advance!

That's an interesting one. Just so I fully understand, is this in the Home app that the Beam is resetting back to whatever room it has at first setup? Or is this in the Homebridge UI that it's resetting back to "default room"?

Yes the first example you gave- in iOS Home.app

Ok, I'll have a look! 🙂

So I've been trying to recreate this issue but can't seem to be able to. Whatever I try the device stays in the same room I assign it.

I'm really stumped by this one. Could you please paste is the config json you have for plugin? I'm not sure if that'll help but there could be a setting I don't have turned on that's messing it up.

Hey, it actually happened again. I'm not sure when exactly. The Beam moved from my "Living Room" to the room "Utility". No idea why it went to Utility, that's the last room in my list per my custom order.

Hmmm ok. I'll open the issue and take another wee look!

Happened again, I took this screenshot 6 days ago. But nowtoday I can't actually find the beam anywhere in my Home. I did update my HB to v1.6.1 this morning, but I'm not sure if it disappeared before or after that.

I realize this is probably not very helpful, but it happened again. This time within ~2 weeks. The only thing I've done in HB in the last couple weeks is update other plugins and installed 1 new plugin.
If there's something I can do to monitor the change to help you out let me know.

Really bizarre. I still have yet to see that happen. I'll have another crack at trying to replicate it at the weekend!

Lost room setting for me on 0.5.1. But no idea why. Will have another dig at the weekend

Hopefully this may clue everyone in on what could be causing this behavior. I am finding that when rooms are grouped, if homebridge/sonos plugin restarts, it will no longer acknowledge the soundbars and purge them.


Use "Embedded in another view" with helpers and/or with "Implicit optional callback"

"Embedded in another view" + "Implicit optional callback":
Views.py
class DataTableView(DatatableView):
    model = Agent
    datatable_options = {
        'columns': [
            'firstname',
            'lastname',
            ("Certification", 'agent__certifications', 'get_agent_certifications'),
        ]
        }

    def get_agent_certifications(self, instance, *args, **kwargs):
        return ", ".join([Certification.long_name for Certification in instance.certifications.all()])

class SelectionAgentSearchView(LoginRequiredMixin, FormView):
    form_class = SearchForm
    template_name = 'client/datatable.html'
    success_url = 'client/datatable.html'

    def get_context_data(self, **kwargs):
        context = super(SelectionAgentSearchView, self).get_context_data(**kwargs)
        datatable_view = DataTableView()
        # Init Datatables parameters
        model = datatable_view.model
        options = datatable_view.get_datatable_options()
        # Retrieve the selection ID from the url to join with agents
        selectionid = self.kwargs['selectionid']
        datatable = get_datatable_structure(reverse('clients:agents_list'), options, model=model)
        context['datatable'] = datatable
        return context

def agents_list(request):
    if request.method == 'GET':
        agents = Agent.objects.filter().values_list(
            'firstname',
            'lastname',
            '', # Here should be the datas returned by implicit callback
    agents = {"data": list(agents)}
    return JsonResponse(agents, safe=False)

Of course, there is no datas in "Certification" column.
I think the way of doings things is putting the implicit callback def get_agent_certifications(self, instance, *args, **kwargs):         return ", ".join([Certification.long_name for Certification in instance.certifications.all()]) if agents_list function. Can you confirm or infirm please ?
I think I'll have the same issue with helpers ?

Yes, you'll find yourself needing to copy that logic to your agents_list view.
However, you shouldn't need the agents_list view at all, since the DatatableView is actually providing this for you.  If you were to place it in your urls instead of agents_list, and keep the url name in place, you could remove that extra view function and get the desired behavior.


PLUGIN_FAILURE and no row written to payu_latam_transactions

It looks like there are occasionally instances where we are getting PLUGIN_FAILURE for payment transactions and no rows are being written to payu_latam_transactions (or responses as well). Is this expected? (I would expect a row to be written to transactions in case of gateway failure and I would expect that if we are failing before connecting to the gateway that this would probably be because of a bug of ours).
Here's a query that will identify this case (although it looks like ALL plugin failures at the moment do not write to payu_latam_transactions)
SELECT
distinct p.id
FROM
payments p
INNER JOIN payment_transactions pt on
p.id=pt.payment_id
AND pt.transaction_status='PLUGIN_FAILURE'
INNER JOIN payment_methods pm on
p.payment_method_id=pm.id
AND pm.plugin_name='killbill-payu-latam'
LEFT OUTER JOIN payu_latam_transactions plt on
pt.id=plt.kb_payment_transaction_id
WHERE 1=1
AND p.tenant_record_id=7
AND plt.kb_payment_transaction_id is null

PLUGIN_FAILURE indicates a fatal error in the plugin (the call wasn't attempted), whereas PAYMENT_FAILURE indicates the call went through, but the payment method couldn't be charged.

A response row will always be created if we are able to contact the gateway (PAYMENT_FAILURE, SUCCESS or PENDING)
A transaction row is created only if the payment is successful (not in case of PLUGIN_FAILURE nor PAYMENT_FAILURE)

Note that I made some improvements regarding network connection errors when contacting the gateway (starting with https://github.com/killbill/killbill-plugin-framework-ruby/commit/27b2dc88f47eaa5144271c6fefa1611ae66dfb8b).

This can be closed.


Pydantic v2

Description
Migrate to Pydantic v2. This is the final PR, which is a follow-up from the PoC PRs #6463 and #6685.
Current status: I still need to refine a few details (marked with TODO), and review the full mypy diff (it's big). But I think any changes from here on out should be relatively minor so it makes sense to open it for review now. inmanta-lsm PR will follow soon.
part of #6462
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

All TODO's I had marked in this PR are now done.

@arnaudsjs @Hugo-Inmanta all done.

Processing this pull request

Merged into branches master in f8c7fa371b85e8b6563e64cddf2e557c21e48064

This branch was not deleted as it seems to still be in use.


Browse error if table doesn't have timestamps

Laravel Version: 5.4.19
Voyager Version: 0.11.9
PHP Version: 5.6.29
Database Driver & Version: MySQL 5.7.17

Description:
If I create table without timestamps and than try to browse it get an error
QueryException in Connection.php line 647: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'created_at' in 'order clause' (SQL: select * from bookings order by created_at desc)
It could useful to add an option to BREAD creation, which adds public $timestamps = false; to the model.
Steps To Reproduce:

Create table
Add BREAD to the table
Browse table

@timbertlt then why don't you just add created_at to your table, so it's not causing error.

@endrureza because I don't need such type of fields in this table. It's not a problem to add $timestamps = false to the table, but anyway it's make sense to have this option or add timestamps by default.

I'm also seeing this issue. The table I've created is solely for storing dropdown list data used elsewhere in the admin dashboard so I have no need for created & updated data.

Labels: enhancement, possible bug

Closing since 1.0 is released.  If this is still an issue in 1.0, please provide steps to reproduce the error in 1.0 and we'll reopen it.

This is still an issue in 1.0.5. I clicked "Add BREAD to this table" for a table without timestamps, left all of the fields the way they were, clicked "Submit", gave the "admin" role all permissions for the table, and then clicked the "Browse BREAD" button. This is what I got:
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'created_at' in 'order clause' (SQL: select * from `mytable` order by `created_at` desc)

This may not be an issue after all. I'm still new to Laravel and am working with a legacy database. When I added public $timestamps = false; to the model, the problem went away.

As @ataylor32 said in the last post, this issue can be closed again.

It was never reopened

Sorry I didn't saw, I would say that his solution simply work.


Do not attempt to devirtualize methods on value types

@sandreenko PTAL

Is returning the unboxing stub here a todo, or is there some reason why this can't happen?

Is returning the unboxing stub here a todo, or is there some reason why this can't happen?

@AndyAyersMS I haven't looked into it in detail yet (hence the TODO). I think the problem will be that we don't have a representation for unboxing thunks in the type system (and can't pass out a CORINFO_METHOD_HANDLE that represents it).
Does RyuJIT expect to see a handle for a method that has a reference type for this as the result of devirtualization?

The jit expects to get a method handle that has a compatible signature with the base method, so, abstractly, yes, this should be a reference type.
That being said, the jit doesn't check for compatible signatures at the point of devirtualization and since the resulting method can't be inlined the jit probably wouldn't notice if the signature was different.
What triggers the issue in CoreRT is that after devirtualization the jit then goes on and tries to inline the method and that's where the type mismatch becomes evident.

@AndyAyersMS thanks, I updated the comment to capture this information. We'll need to revisit this when we start looking at perf (there's already a couple TODOs on the JitInterface side around perf).


Counterintuitive mix ecto.rollback interface

Current behavior
$ mix ecto.rollback --to<PHONE_NUMBER>5227
12:15:35.434 [info]  == Running<PHONE_NUMBER>3138 [...] backward
12:15:35.444 [info]  alter table o[...]
12:15:35.471 [info]  == Migrated<PHONE_NUMBER>3138 in 0.0s
12:15:35.483 [info]  == Running<PHONE_NUMBER>5227 [...] backward
12:15:35.483 [info]  drop index dial_[...]_index
12:15:35.484 [info]  drop table dial_[...]
12:15:35.486 [info]  == Migrated<PHONE_NUMBER>5227 in 0.0s

Migration specified with to is also being rolled back.
Expected behavior
mix ecto.rollback leaves a repo exactly at to migration, i.e. it does "rollback to" specified revision.
That would make more sense, right?
(It would be a one-character fix PR, I guess.)

That's a good point. However, I am worried about changing the current behaviour and breaking the code for anyone who could be relying on this. So my suggestion would be to introduce a new option that matches the current semantics, and then if necessary we could introduce one that mirrors what you propose.

I don't quite get... Then there would be two options with the same behaviour?.. I thought the usual approach in this case is to add a new option (like --upto) with behaviour I've described and the existing one (--to) to be marked as deprecated, but still supported for some time.

That’s another option, but we likely shouldn’t call it —up-to as we are going “down”. It could be down-to on rollback and up-to on migrate for consistency.

Ping. Would you like to send a PR, @staring-frog? :)

I got fired from proSapient (yeah, that place :wink:), hence it became less relevant for me :D It's unlikely that I'll have the time for this issue. But I'll find some time for other two issue I've promised about, after I get back from unplanned vacation :D
Btw "up-to" and "down-to" are hard to remember IMHO: I had hard times recalling each time which way are we going while code diving. Probably [--target, -T] would be easier to remember.


Something is missing

Describe your problem here.
Note.hx (line 124)
PlayState.hx (line 2353)
PlayState.hx (line 1053)
flixel/FlxGame.hx (line 637)
flixel/FlxGame.hx (line 724)
flixel/FlxGame.hx (line 677)
flixel/FlxGame.hx (line 545)
openfl/events/EventDispatcher.hx (line 402)
openfl/display/DisplayObject.hx (line 1399)
Uncaught Error: Null Object Reference
Please report this error to the GitHub page: https://github.com/ShadowMario/FNF-PsychEngine

Crash Handler written by: sqirra-rng

What's missing? Pls help!
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no

i think you need a newer build

I have newest build
niedz., 28 sie 2022, 01:24 użytkownik Grape Boy @.***>
napisał:

i think you need a newer build
—
Reply to this email directly, view it on GitHub
https://github.com/ShadowMario/FNF-PsychEngine/issues/10331#issuecomment-1229317132,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVBPX2FSISZIZPMCOXVZLCTV3KPTHANCNFSM57ZAZ36A
.
You are receiving this because you authored the thread.Message ID:
@.***>


Add event parser

Create event parser that takes important bits out of the Kronox file
Depends on #4

done and done


Missing Reference to StyledComponent in 4.10

https://github.com/styled-components/styled-components/blob/v4.0.0-beta.10/src/models/StyledComponent.js#L182

If you're not going to use the issue template and give us a proper issue that we can look into and be helpful, don't bother opening one.

@probablyup

What project is this? It works correctly in the main library.
On Fri, Oct 5, 2018 at 11:21 AM James<EMAIL_ADDRESS>wrote:

@probablyup https://github.com/probablyup
[image: screen shot 2018-10-05 at 8 51 06 pm]
https://user-images.githubusercontent.com/4022631/46544149-71aa0f00-c8e0-11e8-8af1-d3e4132b424c.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/2067#issuecomment-427402871,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiy1ijzEp6-Ju1t-nqudj5gKcGkLP1aks5uh3kQgaJpZM4XKZ40
.


[Branch View] Add Included TAG

This PR will hilight Branches wich can be deleted ..
... because they are clones of the default one
... they are merged manualy
Close: https://github.com/go-gitea/gitea/issues/7976

Succesor of https://github.com/go-gitea/gitea/pull/7979

Could you post before/after captures?

Sorry: I saw them later.

@guillep2k :eyes:

Codecov Report

Merging #8449 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #8449      +/-   ##
==========================================
- Coverage   41.81%   41.81%   -0.01%
==========================================
  Files         497      497
  Lines       65639    65644       +5
==========================================
- Hits        27450    27448       -2
- Misses      34674    34678       +4
- Partials     3515     3518       +3

Impacted Files
Coverage Δ

routers/repo/branch.go
56.66% <100%> (+1.05%)
:arrow_up:

modules/sync/unique_queue.go
78.57% <0%> (-10.72%)
:arrow_down:

modules/avatar/avatar.go
48% <0%> (-6%)
:arrow_down:

models/gpg_key.go
55.83% <0%> (-0.84%)
:arrow_down:

modules/log/event.go
65.64% <0%> (+1.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe81bc...89c7e1b. Read the comment docs.

@sapk done ;)

Git supports a git branch --contains <hash>, wouldn't that make more sense with the last non merge commit from the given branch?

@MarkusAmshove we can change that - but i think gitea uses less resources this way?

make LGTM work

Make lg-tm work


Home for transforms subpackage

The current transforms submodule of the data library implements the same transform base class and whitening transform as BBHnet.  There is an open issue in ml4gw to incorporate the whitening transform.
The StandardScalerTransform should probably be generalized to allow, e.g., standardization of (batch_size, n_data) tensors, as well as (batch_size, n_channels, n_data) tensors and added in ml4gw as well.

Shall we close this since this is migrated to ml4gw?


A11y: Quickview arrows do not show focus indicator

Focus indicator for keyboard users should always be visible
[https://www.w3.org/WAI/WCAG22/Understanding/focus-visible.html|https://www.w3.org/WAI/WCAG22/Understanding/focus-visible.html|smart-link]
!Screenshot 2024-10-11 at 15.29.01.png|width=1407,height=670,alt="Screenshot 2024-10-11 at 15.29.01.png"!

[public] Shopware automated response: This issue is linked to the internal issue: CMS-473
[created from CMS-473, comment 506647]


*: Bump to 3.0.3

Signed-off-by: nolouch<EMAIL_ADDRESS>
What have you changed?
bump to 3.0.3

/run-all-tests


simplify README.md + add table.DefaultTxControl()

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report

Merging #197 (a372f79) into master (f54c60d) will increase coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   57.93%   58.10%   +0.16%
==========================================
  Files         132      132
  Lines       15591    15599       +8
==========================================
+ Hits         9033     9064      +31
+ Misses       5969     5951      -18
+ Partials      589      584       -5

Flag
Coverage Δ

1.14.x
27.18% <0.00%> (-0.01%)
:arrow_down:

1.15.x
27.18% <0.00%> (-0.01%)
:arrow_down:

1.16.x
27.18% <0.00%> (-0.08%)
:arrow_down:

1.17.x
58.04% <0.00%> (+0.15%)
:arrow_up:

1.18.x
27.26% <0.00%> (+0.07%)
:arrow_up:

connection
15.61% <0.00%> (-0.01%)
:arrow_down:

discovery
14.72% <0.00%> (-0.01%)
:arrow_down:

e2e
48.36% <0.00%> (+0.23%)
:arrow_up:

integration
48.36% <0.00%> (+0.23%)
:arrow_up:

macOS-latest
27.18% <0.00%> (-0.08%)
:arrow_down:

ratelimiter
16.84% <0.00%> (-0.01%)
:arrow_down:

scripting
17.36% <0.00%> (-0.01%)
:arrow_down:

table
42.18% <0.00%> (+0.24%)
:arrow_up:

ubuntu-latest
58.04% <0.00%> (+0.15%)
:arrow_up:

unit
27.26% <0.00%> (+0.01%)
:arrow_up:

windows-latest
27.26% <0.00%> (+0.07%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

connection.go
77.07% <ø> (ø)

internal/table/session.go
75.51% <0.00%> (+0.54%)
:arrow_up:

table/table.go
73.83% <0.00%> (-3.62%)
:arrow_down:

internal/table/client.go
91.16% <0.00%> (+0.31%)
:arrow_up:

internal/database/database.go
67.74% <0.00%> (+3.22%)
:arrow_up:

internal/conn/conn.go
82.24% <0.00%> (+4.43%)
:arrow_up:

internal/xerrors/operation.go
66.66% <0.00%> (+5.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54c60d...a372f79. Read the comment docs.


enhance service kill and stats

After kill cmd, switch the service's container status according to real container status

Supplement some Metrics

Hi, Since I pushed the commits for supporting exec, and there is some conflicts,
can you fix the conflicts and resend PR?


ARTEMIS-3707 ResourceAdapter Documentation

Documentation of the Artemis ResourceAdapter.

thanks for your contribution

I dont think this should have been merged with all the links to main in it (see outstanding feedback on the original PR).
I also dont think this one should have been raised at all when considering it is documenting the opposite approach of what the original PR was eventually described as being aimed at achieving (not having to build your own / use the described examples).
Oh well, I give up.

@gemmellr It is no problem for me to fix the documentation afterwards and open a PR for that. At the moment no WLP sample is mentioned in the documentation, only available material is used...
Have you found a solution to refer the version in the link?

@gemmellr , @waldi5001 I only made a connection with the previous PR after I merged it. I can revert it and a new PR sent by @waldi5001 ?

No problem.

@waldi5001 , @gemmellr I reverted this commit as discussed, please send a new PR as we discussed earlier.
thank you

@gemmellr It is no problem for me to fix the documentation afterwards and open a PR for that. At the moment no WLP sample is mentioned in the documentation, only available material is used...

Right, and I was saying that seems bizarre, if the original goal was actually to add new rars and get rid of the examples just documented.

Have you found a solution to refer the version in the link?

I suggested on the original PR you could probably look to include it using some filtering.
I have just raised a PR making it available, #4050

I opened the new PR #4060 with the version in the links. On my machine with mvn clean install -Prelease -DskipTests it works well.

Right, and I was saying that seems bizarre, if the original goal was actually to add new rars and get rid of the examples just documented.

as I understood you, shipping a artemis.rar is not what you (or the team) want. So, in the documentation is explained what the readers have to do, if they want to use a resource adapter. No example get rid, no artemis.rar is added.
If I misunderstood you, no problem, I will open another PR with artemis.rar files, rid of the examples (or not) and a adjusted documentation.
But first of all #4043 have to be merged, without that it will become difficult to use the exampleArtemis.rar in the application server of your choice.

You have definitely misunderstood me. Though I did query at one point why the new rar modules were being added, as they seemed largely duplication of the example and their presence wasnt clear based on the documentation also being added that said you must build your own like the example, we then discussed why on the PR. I reviewed the PR multiple times after without saying 'remove these', and even added stuff to the build myself so you could use it to more easily action some prior feedback I had given, plus when you asked if the PR was dead I said no. You then closed it and raised the other of somewhat different PRs.


"Merge All Windows" command no longer works on Mac OSX after update

VSCode Version: Version 1.36.1 (1.36.1)
OS Version: Mac Sierra 10.12.6

Steps to Reproduce:

code somefolder
code someotherfolder
cmd+p and run "merge all windows".

Windows don't merge.

Does this issue occur when all extensions are disabled?: Yes/No
Yes
--
I can manually drag the two windows to merge them, but the my keyboard shortcut cmd+k+m is broken since the command doesn't work.

This seems to work for me on Insiders, can you try?


dependabot to target all maintained branches

This PR updates dependabot to add a dont_backport label when it updates dependancies on the main branch.
This will fix an issue we were running into where mergify would try to backport the dependabot dependency updates. But, because it is not able to run a mod tidy, it was hitting conflicts.
Instead, we added separate target-branches for dependabot to keep up to date.
This PR also includes minor cosmetic update to the mergify PR's.

Since opening this PR, I now have a different stance.
I don't think it is necessary to to have dependabot run on all maintained branches. It's a bit overkill.
Keeping it just on main should be fine.
We can update deps on maintained branches on an as-need basis.


[Feature][Connect jdbc] Support Array/Json/Jsonb/Timestamptz DataType in Connect jdbc PostgreSQL

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Support Array/Json/Jsonb/Timestamptz DataType in Connect jdbc PostgreSQL
Usage Scenario
Use Connect jdbc read PostgreSQL database
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

please assign to me; thx。

Can assign it to me ?  I have finished part of the work


chore(master): release 2.1.1

:robot: I have created a release beep boop
2.1.1 (2022-11-25)
Bug Fixes

libfaketime (7fa1cce)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/docker-php-dev/releases/tag/v2.1.1 :sunflower:


Version on Microsoft Store is not the latest one

Just wanted to open this issue to be sure that are aware of it :)

Thanks 👍 but I am aware of that.
The Microsoft Store doesn't let me upload this version so I am currently looking into new stuff that I could implement to update the version 1.0.5.
The reason for this is that I tried out the Package Flights feature in the Store and gave it an early preview of the 1.0.4 version to send to a few friends, just to test it out. When I tried to release the actual 1.0.4 version I deleted the flight package and uploaded the real one to the Store but now it doesn't accept any packages with the version 1.0.4 as there already was a package with the version 1.0.4 in the Store.
So, let me know if you have any suggestions for stuff I could change. I don't really want to create a new version with no changes.

Alright, the new version v1.1.0 is now also in the Microsoft Store and will be slowly rolled out. ✔
Only a small percentage of people will get updated at first to ensure any unexpected issues are limited to a small group but it will eventually be rolled out to everyone, manually checking for updates will always get you the newest version tho.


Schema type object without defining the keys

I have tried to add an object as a part of a schema and the values are only stored if the object's children are described as "object.child" in the schema.
I currently got a solution working by serializing the object and storing it as a string, but it will negate all hopes of searching by those values in the future.
Am I missing something about the object type and/or is there a workaround for this?

have you tried blackbox: true?
in other words :
myObj: {
    type: Object,
    blackbox: true
}

then you can add any keys you want to myObj


dbeaver/dbeaver-ee#2023 use eclipse resource menu to open blobs

Closes dbeaver/dbeaver-ee#2023
Now the Eclipse editor selection will pop up instead, where the user can select the required editor. Also, now the user can change associations via Eclipse file associations preference.

Verified


New update failing to open in comfyUI -all nodes[bug]

Describe the bug
After i updated the comfy_mtb i find that some of the new updates failed to load the nodes in comfyUI . Before the update all were working fine. Possibly in the old version there was a reqs_windows.txt which in the modified version is not there resulting in some mismatch. Please check same.. Not sure where the break is but the issue is not available or shown in the backend.
Reproduction
No response
Expected behavior
No response
Operating System
Windows (Default)
Comfy Mode
Comfy Portable (embed) (Default)
Console output
No response
Additional context
No response

Hi,
I can't do much with this information
Can you provide some log from either the backend of the frontend?

First you seem to use system python, I highly suggest against that, either use portable or a virtual env:
[!] WARNING: Ignoring invalid distribution -ip (c:\users\sunde\appdata\roaming\python\python310\site-packages)
[!] WARNING: Ignoring invalid distribution -ip (c:\users\sunde\appdata\roaming\python\python310\site-packages)
[!] WARNING: Ignoring invalid distribution -ip (c:\users\sunde\appdata\roaming\python\python310\site-packages)

Then your AIT extension is broken:
Traceback (most recent call last):
  File "D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1734, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\AIT\__init__.py", line 1, in <module>
    from .AITemplate.AITemplate import AITemplateLoader, AITemplateControlNetLoader, AITemplateVAEDecode, AITemplateVAEEncode, VAEEncodeForInpaint, AITemplateEmptyLatentImage, AITemplateLatentUpscale
  File "D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\AIT\AITemplate\AITemplate.py", line 414
    else:
    ^^^^
IndentationError: expected an indented block after 'if' statement on line 413

Cannot import D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\AIT module for custom nodes: expected an indented block after 'if' statement on line 413 (AITemplate.py, line 414)

Same for animateDiff (this is the old version, I recommend the evolved one):
Traceback (most recent call last):
  File "D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1734, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 879, in exec_module
  File "<frozen importlib._bootstrap_external>", line 1016, in get_code
  File "<frozen importlib._bootstrap_external>", line 1073, in get_data
FileNotFoundError: [Errno 2] No such file or directory: 'D:\\AI\\ComfyUI_windows_portable_nvidia_cu118_or_cpu\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\animatediff\\__init__.py'

Cannot import D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\animatediff module for custom nodes: [Errno 2] No such file or directory: 'D:\\AI\\ComfyUI_windows_portable_nvidia_cu118_or_cpu\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\animatediff\\__init__.py'

Traceback (most recent call last):
  File "D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1734, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\cg-image-picker\__init__.py", line 4, in <module>
    from .image_chooser import *
  File "D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\cg-image-picker\image_chooser.py", line 6, in <module>
    from custom_nodes.cg_custom_core.ui_decorator import ui_signal
  File "D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\__init__.py", line 2, in <module>
    from .animatediff.nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
  File "D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\animatediff\nodes.py", line 17, in <module>
    from comfy.sd import ModelPatcher, calculate_parameters
ImportError: cannot import name 'ModelPatcher' from 'comfy.sd' (D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\comfy\sd.py)

Same for cg-image-picker:
Cannot import D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\cg-image-picker module for custom nodes: cannot import name 'ModelPatcher' from 'comfy.sd' (D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\comfy\sd.py)
Web extensions folder found at D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\web\extensions\ComfyLiterals
Traceback (most recent call last):
  File "D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1734, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 879, in exec_module
  File "<frozen importlib._bootstrap_external>", line 1016, in get_code
  File "<frozen importlib._bootstrap_external>", line 1073, in get_data
FileNotFoundError: [Errno 2] No such file or directory: 'D:\\AI\\ComfyUI_windows_portable_nvidia_cu118_or_cpu\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\ComfyUI\\__init__.py'

I'm going to stop there but you have like 4 more extensions with issues.
About mtb:
Cannot import D:\AI\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy_mtb module for custom nodes: Cannot call rmtree on a symbolic link

This is an error I made that was since fixed: https://github.com/melMass/comfy_mtb/commit/25b933c698b250a411549d2600fae49bec225b7a
So just re-updating it should work fine

okay thanks for same and will reupdate once done


[TO-DO] Bugs

Bugs to be fixed:

[x] use path.join() to work with path to SSH key file instead of Linux convention inside of generate-ssh utility. This is to support OS other than Linux. Also check that SSH key storage is done the same way in other OS. Priority: high
[ ] allow graceful shutdown even when stuck in inquirer prompt. Priority: low

generate-ssh now supports Windows path style. Also supports inputting folders that do not exist yet.
See #60

Moved tasks to projects instead. Cleaner approach. Closing for now


server crash when using flake8 from environment

Switching to using flake8 from my environment causes the server to crash. The same error is observed with v2023.6.0 and with the prerelease version. The same error occurs when changing the import strategy to fromEnvironment as when explicitly setting the linter path.
The flake8 version in the environment is 6.1.0, but I obtain the same error if I downgrade to 5.0.4 .
The error message is:
2023-08-31 17:05:48.595 [info] Traceback (most recent call last):
  File "/Users/dham/.vscode/extensions/ms-python.flake8-2023.6.0/bundled/tool/lsp_server.py", line 236, in <module>

2023-08-31 17:05:48.595 [info]     @LSP_SERVER.feature(
     ^^^^^^^^^^^^^^^^^^^
  File "/Users/dham/docs/principles_of_programming/PoP_venv/lib/python3.11/site-packages/pygls/feature_manager.py", line 174, in decorator
    raise TypeError(
TypeError: Options of method "textDocument/codeAction" should be instance of type typing.Union[pygls.lsp.types.language_features.code_action.CodeActionOptions, pygls.lsp.types.language_features.code_action.CodeActionRegistrationOptions]

2023-08-31 17:05:48.663 [info] [Error - 17:05:48] Server initialization failed.
2023-08-31 17:05:48.663 [info]   Message: Pending response rejected since connection got disposed
  Code: -32097
2023-08-31 17:05:48.663 [info] [Error - 17:05:48] The Flake8 server crashed 5 times in the last 3 minutes. The server will not be restarted. See the output for more information.
2023-08-31 17:05:48.663 [info] [Error - 17:05:48] Flake8 client: couldn't create connection to server.
2023-08-31 17:05:48.663 [info]   Message: Pending response rejected since connection got disposed
  Code: -32097
2023-08-31 17:05:48.663 [info] [Error - 17:05:48] Restarting server failed
2023-08-31 17:05:48.663 [info]   Message: Pending response rejected since connection got disposed
  Code: -32097

@dham Can you share what packages you have in you environment? rune python -m pip list from the activated terminal.
This occurs if older version of typeguard is present in the environment.

I upgraded typeguard and consequently pygls and esbonio (because pip complained about dependencies). This fixed the problem.
The difference between python -m pip list before and after follows. It seems likely, as you suggest, that there is an undocumented dependency on a sufficiently recent version of typeguard.
> cattrs                          23.1.2
26c27
< esbonio                         0.15.0
---
> esbonio                         0.16.1
48a50
> lsprotocol                      2023.0.0a3
80c82
< pygls                           0.13.1
---
> pygls                           1.0.2
122,123c124,125
< typeguard                       2.13.3
< typing_extensions               4.4.0
---
> typeguard                       3.0.2
> typing_extensions               4.7.1

@karthiknadig This is exactly my issue so I won't file a new one (my error stack is visually different since I'm on python 3.10 compared to 3.11 above)

This usually means that you have a version of pygls or some other server pacakge that is too old in your environment.
You don't need to have all of these, but if your environment has any of these then please update them to the version below. If you don't have them we use fallback and pick it up from the bundle. The issue occurs when you have it but the version is not supported.
These are the server packages needed:
attrs==23.1.0
cattrs==23.1.2
exceptiongroup==1.1.3
importlib-metadata==6.8.0
lsprotocol==2023.0.0b1
packaging==23.2
pygls==1.1.2
typeguard==4.1.5
typing-extensions==4.8.0
zipp==3.17.0

It's strange that the server uses the environment's Python while it's anyway running flake8 as a subprocess. I would expect the LSP server to use vendored dependencies, but flake8 to use Python from the environment.
It seems that the issue is that the vendored libs are appended to sys.path instead of being prepended (like it's done for tool):
2024-02-07 15:30:01.549 [info] sys.path used to run Server:
   .../.vscode/extensions/ms-python.flake8-2023.10.0/bundled/tool
   /usr/lib64/python39.zip
   /usr/lib64/python3.9
   /usr/lib64/python3.9/lib-dynload
   ... My venv paths are here
   .../.vscode/extensions/ms-python.flake8-2023.10.0/bundled/libs

I ran into the same issue and one of our project dependencies pinned typeguard to a lower version. The isort extension uses the bundled libs as the first in the sys path:
2024-03-07 15:09:02.216 [info] sys.path used to run Server:
   /Users/<user>/.vscode/extensions/ms-python.isort-2023.10.1/bundled/libs
   /Users/<user>/.vscode/extensions/ms-python.isort-2023.10.1/bundled/tool
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>   /path/to/project/.venv/lib/python3.12/site-packages


Revert "Attempt to build the volto/components Storybook only when something c…"

Reverts plone/volto#5595

Superseded by https://github.com/plone/volto/pull/5600

@sneridagh Would you please merge this PR? I don't have your super power to override the Required Statuses setting (nor do I want it or should have it).

@sneridagh it looks like I can squash and merge it after all. I guess the changelog check is not a required status? Merging.


Update flexible modular info-display component

take

make it more like

we want four fields:

title
subtitle
value
unit

and then capability for the component to be clicked and call a function

see https://github.com/Open-Breeze/covid19-ventilator/tree/flex-value-card


No events recieved

G'day Martin. Thanks for this book and CanaryRaspberryJuice. I'm running through the book using CanaryRaspberryJuice and Minecraft 1.8 (CanaryMod) on Linux to familiarise myself with the workflow and results before handing it over to three eager kids.
Everything has been working great until I hit Adventure 4 and blockHit.py. As best as I've been able to determine, no matter which sword I use, I am not being returned event data.
My code is here:
https://git.mcwhirter.io/craige/MyAdventures/blob/master/blockHit.py
I've also run your version from "Code Files" and neither version are returning any block hit events.
At different points I have also tried adding print statements, to print the event position but nothing is ever printed.
The code all runs without error but unfortunately also without any event data.
Do you have any ideas on where I could be digging to resolve this one?
Thanks!

Can you confirm your are RIGHT clicking while holding a sword. Left click isn't a hit.

Oh wow, subtle but important distinction. I'd never used right-click for sword actions before.
Very happy to say that was indeed the solution.
Thanks!


make footnotes work

currently they dont work
https://github.com/orgs/remarkjs/discussions/1024#discussioncomment-3345267
gives some indicationt hat it should work if we bump the deps

@swyxio Doing it.

would honestly still prefer it to be supported as a remark plugin, but cheers to @Bishwas-py for supporting it!


feat(labs): adds ability to add, view, and list lab requests

Changes proposed in this pull request:

adds ability to list labs
adds ability to view lab
adds ability to create new lab request
adds ability to update, cancel, or complete a lab request

This is huge! 😲

There seems to be a conflict in this file #1962 (files)

@tehKapa this has ben resolved


Add fedora/redhat support on install script and add missing sudo

I've added support for redhat-like sistems, I've tested it in Fedora, Centos and Ubuntu.
Also previous line 31 missed a sudo, without is the cp command failed because the clone is made as root. Causing errors like #2

Thanks for your pull request!
Seems very helpful for anyone who uses Fedora linux.


Session file with cookie cannot be parsed

Checklist

[Y] I've searched for similar issues.

[Y] I'm using the the latest version of HTTPie.

httpie version, 2.4.0

python version, 3.9

I prepared the my-session-cookie.json file, the request parameters are placed in query.json, and the expected response results are placed in the result.json file.
my-session-cookie.json like this:
{       "__meta__": {             "about": "HTTPie session file",             "help": "https://httpie.org/doc#sessions",             "httpie": "2.4.0"        },        "headers": {             "Content-Type": "application/json",             "cookie": "12345"       } }
And command like this:

http --verify=no -v  --session-read-only=~/Desktop/my-session-cookie.json POST http://localhost:8301/test < ~/Desktop/query.json -d >>~/Desktop/result.json
And I got error like this:
http: error: RuntimeError: OrderedDict mutated during iteration
Then I did some test and the request can be executed

remove cookie field
OR remove -d >>~/Desktop/result.json in the command

So what's wrong？

Could you rerun the command with --debug and copy-paste the whole output (not a screenshot)?
And to ease reproduction on our side, share whole data needed as code, not screenshots, please.

What is the content of query.json?

@BoboTiG
Just a normal json data like this:
`
{
"data": {
},
"pageNum": 1,
"pageSize": 100
}
`

@BoboTiG
I guess the problem is parsing the session file.
When there is a cookie field in the session file, the parsing directly reported an error, simply can not send http request.
And when I remove the cookie field, session field can be parsed rightly and can send http request.

Sry, I missed this msg.
In debug mode:
CASE 1:
http --debug  --verify=no -v  --session-read-only=~/Desktop/my-session-cookie.json POST http://localhost:8301/test < ~/Desktop/query.json -d >>~/Desktop/result.json
HTTPie 2.4.0
Requests 2.25.1
Pygments 2.7.4
Python 3.9.5 (default, May  4 2021, 03:33:11)
[Clang 12.0.0 (clang-1<IP_ADDRESS>)]
/usr/local/Cellar/httpie/2.4.0/libexec/bin/python3.9
Darwin 19.6.0
<Environment {'colors': 256,
'config': {'default_options': []},
'config_dir': PosixPath('/Users/bytedance/.config/httpie'),
'devnull': <property object at 0x1025e11d0>,
'is_windows': False,
'log_error': <function Environment.log_error at 0x1025dde50>,
'program_name': 'http',
'stderr': <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>,
'stderr_isatty': True,
'stdin': <_io.TextIOWrapper name='' mode='r' encoding='utf-8'>,
'stdin_encoding': 'utf-8',
'stdin_isatty': False,
'stdout': <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>,
'stdout_encoding': 'utf-8',
'stdout_isatty': False}>
http: error: RuntimeError: OrderedDict mutated during iteration
Traceback (most recent call last):
File "/usr/local/bin/http", line 33, in
sys.exit(load_entry_point('httpie==2.4.0', 'console_scripts', 'http')())
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/httpie/main.py", line 11, in main
exit_status = main()
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/httpie/core.py", line 70, in main
exit_status = program(
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/httpie/core.py", line 169, in program
for message in messages:
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/httpie/client.py", line 63, in collect_messages
httpie_session.update_headers(request_kwargs['headers'])
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/httpie/sessions.py", line 75, in update_headers
for name, value in request_headers.items():
File<EMAIL_ADDRESS>line 849, in iter
for key in self._mapping:
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/requests/structures.py", line 60, in
return (casedkey for casedkey, mappedvalue in self._store.values())
RuntimeError: OrderedDict mutated during iteration
CASE 2:
http --debug  --verify=no -v  --session-read-only=~/Desktop/my-session-cookie.json POST http://localhost:8301/test < ~/Desktop/query.json
HTTPie 2.4.0
Requests 2.25.1
Pygments 2.7.4
Python 3.9.5 (default, May  4 2021, 03:33:11)
[Clang 12.0.0 (clang-1<IP_ADDRESS>)]
/usr/local/Cellar/httpie/2.4.0/libexec/bin/python3.9
Darwin 19.6.0
<Environment {'colors': 256,
'config': {'default_options': []},
'config_dir': PosixPath('/Users/bytedance/.config/httpie'),
'devnull': <property object at 0x10d88f130>,
'is_windows': False,
'log_error': <function Environment.log_error at 0x10d888e50>,
'program_name': 'http',
'stderr': <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>,
'stderr_isatty': True,
'stdin': <_io.TextIOWrapper name='' mode='r' encoding='utf-8'>,
'stdin_encoding': 'utf-8',
'stdin_isatty': False,
'stdout': <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>,
'stdout_encoding': 'utf-8',
'stdout_isatty': True}>

requests.request(**{'auth': None,
'data': <_io.BufferedReader name=''>,
'headers': {'User-Agent': b'HTTPie/2.4.0', 'Accept': b'application/json, /;q=0.5', 'Content-Type': b'application/json'},
'method': 'post',
'params': <generator object MultiValueOrderedDict.items at 0x10d93ee40>,
'url': 'http://localhost:8301/test'})

POST /test HTTP/1.1
Accept: application/json, /;q=0.5
Accept-Encoding: gzip, deflate
Connection: keep-alive
Content-Length: 60
Content-Type: application/json
Host: localhost:8301
User-Agent: HTTPie/2.4.0
http: error: ConnectionError: HTTPConnectionPool(host='localhost', port=8301): Max retries exceeded with url: /test (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x10d9c01f0>: Failed to establish a new connection: [Errno 61] Connection refused')) while doing a POST request to URL: http://localhost:8301/test
Traceback (most recent call last):
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/urllib3/connection.py", line 169, in _new_conn
conn = connection.create_connection(
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/urllib3/util/connection.py", line 96, in create_connection
raise err
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/urllib3/util/connection.py", line 86, in create_connection
sock.connect(sa)
ConnectionRefusedError: [Errno 61] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/urllib3/connectionpool.py", line 699, in urlopen
httplib_response = self._make_request(
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/urllib3/connectionpool.py", line 394, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/urllib3/connection.py", line 234, in request
super(HTTPConnection, self).request(method, url, body=body, headers=headers)
File<EMAIL_ADDRESS>line 1253, in request
self._send_request(method, url, body, headers, encode_chunked)
File<EMAIL_ADDRESS>line 1299, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File<EMAIL_ADDRESS>line 1248, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File<EMAIL_ADDRESS>line 1008, in _send_output
self.send(msg)
File<EMAIL_ADDRESS>line 948, in send
self.connect()
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/urllib3/connection.py", line 200, in connect
conn = self._new_conn()
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/urllib3/connection.py", line 181, in _new_conn
raise NewConnectionError(
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x10d9c01f0>: Failed to establish a new connection: [Errno 61] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/requests/adapters.py", line 439, in send
resp = conn.urlopen(
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/urllib3/connectionpool.py", line 755, in urlopen
retries = retries.increment(
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/urllib3/util/retry.py", line 573, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='localhost', port=8301): Max retries exceeded with url: /test (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x10d9c01f0>: Failed to establish a new connection: [Errno 61] Connection refused'))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/bin/http", line 33, in
sys.exit(load_entry_point('httpie==2.4.0', 'console_scripts', 'http')())
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/httpie/main.py", line 11, in main
exit_status = main()
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/httpie/core.py", line 70, in main
exit_status = program(
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/httpie/core.py", line 169, in program
for message in messages:
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/httpie/client.py", line 101, in collect_messages
response = requests_session.send(
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/requests/sessions.py", line 655, in send
r = adapter.send(request, **kwargs)
File "/usr/local/Cellar/httpie/2.4.0/libexec/lib/python3.9/site-packages/requests/adapters.py", line 516, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=8301): Max retries exceeded with url: /test (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x10d9c01f0>: Failed to establish a new connection: [Errno 61] Connection refused'))
Case 1,  http: error: RuntimeError: OrderedDict mutated during iteration
CASE 2, can parse session file and can send http request
I wonder,  sending a request with a cookie and writing the response to a specified file be supported at the same time?
I remember that older versions, such as version 2.0.0, are supported.

Thank you @caofanCPU. I can reproduce the problem, expect a fix very soon :)

@BoboTiG @jokull
Thank you for your timely handling work, my httpie util is online again, ✌!
‘cause can’t wait for the release version,  I directly install the latest versio from the master. 😎
Of course, I am looking forward to the next release version! 🤝


Fix issue #5

Thanks for the fix! I can merge it.
Would you mind also fixing the warnings:
ccronexpr.c(821): warning C4101: 'err': unreferenced local variable
ccronexpr.c(879): warning C4189: 'days_replaced': local variable is initialized but not referenced

Parsing of invalid expressions from #5 is actually still passing for me, so I'll leave it open.


Run from local sources

Would like to understand how do you test locally using the demo :
i always got error :
[ ERROR ]  Unresolved Import
Could not resolve './components' from ../router/dist/collection/index.js
Steps :
npm i (a root)
lerna bootstrap
/packages/router
npm run build
/packages/demo
npm run build
And cannot see the demo working.
I would like to help if i can understand the workflow you use for development of this component

I made demo work by deleting the export * from “components/“ , but still not understanding why

@romulocintra this is an issue with Stencil that will be resolved when 0.12.0 releases. Thanks!


Love your library!

Awesome, thanks! It's great to hear nice things, that means a lot :-). Hope you find it useful!


22978 Fixed original filing date display

Issue #: bcgov/entity#22978
Description of changes:

app version = 4.10.7
replaced DateMixin with DateUtilities (coop correction and corp correction only)
used correct date conversions for original filing date

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

/gcbrun

Temporary Url for review: https://business-edit-dev--pr-584-li36kx9a.web.app


Update web-sys & wasm-bindgen

This PR updates web-sys & wasm to the newest version.
(this was already part of the POC #4954 )

Closes https://github.com/emilk/egui/issues/4961
Closes https://github.com/emilk/egui/issues/4958
[x] I have followed the instructions in the PR template

When will we see this released as a new patch version?

I'm aiming to do a major release (0.29) in the next week or two


UI - Hide shrink disk option on XCP-NG/Xenserver

Description
This PR fixes https://github.com/apache/cloudstack/issues/5698

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5829 (SL-JID-979)

@blueorangutan ui

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5829 (SL-JID-980)

Minor UI change, smoke tests not needed.


[SPARKR][SPARK-10711] Do not assume spark.submit.deployMode is always set

In RUtils.sparkRPackagePath() we

Call  sys.props("spark.submit.deployMode") which returns null if spark.submit.deployMode is not suet
Call  sparkConf.get("spark.submit.deployMode") which throws NoSuchElementException if spark.submit.deployMode is not set. This patch simply passes a default value ("cluster") for spark.submit.deployMode.

cc @rxin

Merged build triggered.

Merged build started.

Test build #42699 has started for   PR 8832 at commit 8b80886.

cc @shivaram

Any reason this would not be set ? My assumption was that all spark-submit applications had this -- so I guess this is for applications not using spark-submit ?
cc @sun-rui who added the function

Yes, if an application starts the JVM manually (not using spark-submit) this call will fail. The change just adds safety without compromising functionality or correctness.

Test build #42699 has finished for   PR 8832 at commit 8b80886.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42699/
Test PASSed.

Merged build finished. Test PASSed.

@falaki , are you using RStudio, where spark-submit is not involved?
I don't think we can simply set a default value. Because it is possible that the default mode does not match spark master. For example, if the spark master is 'yarn-cluster', the default mode is "client", that does not match.
The correct policy is:
if the master does not contain deploy mode information, the deploy mode is "client",
else get deploy mode from the master URL.
I think this issue is not related to SparkR only. @andrewor14, any policy when handling default configurations when a spark-application is not launched via spark-submit? Should we extract some logic from spark-submit so that the logic can be called in non-spark-submit cases to keep consistency?

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42759/
Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #42800 has started for   PR 8832 at commit a643281.

if the master does not contain deploy mode information, the deploy mode is "client",
else get deploy mode from the master URL.

We're actually deprecating the master URLs yarn-client and yarn-cluster (#8385). In general I find it pretty confusing to have the deploy mode embedded in the master URL.

I think this issue is not related to SparkR only. @andrewor14, any policy when handling default configurations when a spark-application is not launched via spark-submit? Should we extract some logic from spark-submit so that the logic can be called in non-spark-submit cases to keep consistency?

We do have the launcher library, but beyond that I don't think this is something we support because it gets pretty difficult to maintain. AFAIK deploy mode is the only such config so this should be fine.

LGTM merging once tests pass

Test build #42800 has finished for   PR 8832 at commit a643281.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42800/
Test PASSed.

I've merged this.


Implementing StrictBank functions and tests

Related to https://github.com/keep-starknet-strange/satoru/issues/272
Implemented functions to the best of my understanding of the GMX contracts. The implementation I think I did well the tests are the issue. The functions are:
record_transfer_in
sync_token_balance
record_transfer_in_internal
after_transfer_out_infernal
PASSING TESTS
The ones which are passing and am comfy with the logic:
fn test_initialize()
fn given_normal_conditions_when_transfer_out_then_works()
fn given_caller_has_no_controller_role_when_transfer_out_then_fails()
fn given_caller_has_no_controller_role_when_record_transfer_in_then_fails()
fn given_caller_has_no_controller_role_when_sync_token_balance_then_fails()
fn given_normal_conditions_when_sync_token_balance_passes() - this passes but am unsure if I have to play around with token balance first to at least test it or I just call it directly.
FAILING TESTS
fn given_receiver_is_contract_when_transfer_out_then_fails() -                                                                                Error: (u256_sub Overflow)                                                                                I think am having the logic correct, am minting to Bank contract address, and passing the bank contract address to transfer out function to make it panic with the assert reason.
fn given_normal_conditions_when_record_transfer_in_works()                                                                                'ERC20: transfer from 0' error.                                                                                It seems it is not minting to caller address successfully. That is why for this test I have I tried to mint to the strict bank address, and transfer out, then transfer in again to register the change. Still getting 'ERC20: transfer from 0'

hello, you implemented  _afterTransferOut but didnt used anywhere. Since it is override function I think you need to use it after you called IBank::transfer_out() function.
https://github.com/VictorONN/satoru/blob/6711409640ff7e19fdfe26b7856370734cbc70ad/src/bank/strict_bank.cairo#L129C13-L129C32

@VictorONN Can you fix your coding style pls ?

@VictorONN do you have any news ? If I don't receive a response within 24 hours, I will have to proceed with redoing the issue

Hello, fixed style and fixed the tests too.


Memorable file names

Feature request
Gret job with Kap folks. Really good. I come to explain a situation I found myself quite often.
I take multiple short videos to show what I did. Usually these files are posted alongisde a PR. The thing is that at the moment I have to put them in the PR description is quite difficult to remember which gif correspond to what feature.

Kap file explorer screenshot
I think that memorable names instead of time hashes will help with this issue. With this I mean autogenerated names like docker images, for example.
I found this other report: https://github.com/wulkano/kap/issues/695. Depending on how that is implemented my proposal could fit.
I'd love to help with this if you think is something you wanna have in Kap. Let me know if so.
Again, thanks for the hard work 👏

Do you think being able to edit filenames in the exports list could be a good solution for this too?

I'm no expert in UX. It'll work for me tho I can see that the solution might be suboptimal.
Honestly, I feel like the other issue I linked is worth a shot. But it's also way more complex.
I have the same problem with other date-based naming conventions. Like mobile or macos screenshots. Maybe it's just my brain 🧠😜

I think that making the filenames editable in the export list would work well. A simple click on to rename would work. Currently I usually just go into the export folder and edit the names there.

I like the idea. We could use something like https://github.com/andreasonny83/unique-names-generator to generate fun names like Awesome Donkey, Mesmerizing Sea Turtle, etc.

I like the idea. We could use something like https://github.com/andreasonny83/unique-names-generator to generate fun names like Awesome Donkey, Mesmerizing Sea Turtle, etc.

I don't know if "Awesome Donkey" would help him remember what he was recording. But then again, maybe it would lol

I think the ideal solution here is to easily let you change the filename prior to export, some apps let you edit the filename from the titlebar, like Sketch:

Can we close this in favor of: https://github.com/karaggeorge/kap-recording-name ?


Results Refactor: Each benefit will now have its own info/program page

When a user clicks on More info from the main results view, each benefit will now have its own page display.
https://xd.adobe.com/view/8bb0344c-fab7-4fc6-bd03-49857d8ffd13-dee3/screen/2341183d-f7d8-4568-8ec9-32c96d71b5c3?fullscreen

Hi @sydney-devine , I've got a question about the content resource. Please see below screenshot. Thanks!

Hi @sydney-devine , I've got a question about the content resource. Please see below screenshot. Thanks!

@CalebPena - are we all set on the list of documents so Ming knows where to pull those from?
The text for that paragraph should be the current benefit description.
Wherever this is pulling from currently

Documents field is being pushed on Friday. The description is description field on the program.

I created a pr to add the documents to the Program type.


Copying button for API key

Follow up from:
https://github.com/dandi/dandiarchive/pull/134#issuecomment-598171132

cannot currently copy the api token on safari. i can see it, but i can't select it or copy it, so can't use it.


fix(curriculum): allow optional spacing for assignment operator

Summary
This PR goes through and updates the tests to allow for optional spacing around the assignment operator.
Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #53704

There's few similar cases in other projects, would you want to include them in this PR?

@gikf
I did a quick global search and found one python project step with the same issue.
Are you referring to that?
Or were there other JS projects?

When checking for \s+= globally I found a few more for the platform and todo app.
So since that is small we can add it to this PR

Hanoi:
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/07-scientific-computing-with-python/learn-recursion-by-solving-the-tower-of-hanoi-puzzle/64ddd65848a12919d7e1c7d0.md
Luhn ( += +):
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/07-scientific-computing-with-python/learn-how-to-work-with-numbers-and-strings-by-implementing-the-luhn-algorithm/65687da2e60409c45595bbe1.md
Password generator ( <=):
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/07-scientific-computing-with-python/learn-regular-expressions-by-building-a-password-generator/6565bd4265158360de8e2ae7.md
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/07-scientific-computing-with-python/learn-regular-expressions-by-building-a-password-generator/6565c084627071646f94c4b0.md
Music player (\s=):
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-basic-string-and-array-methods-by-building-a-music-player/653635c731206b718659d3d5.md
Todo app (\s=):
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-localstorage-by-building-a-todo-app/64fad07f43a101779cb8692a.md


issue about running on linux.

Hi JP,
here use your code on linux for iPXE Boot,has failed as below, i know your code run sucsess on windows, for linux can you give some advice?
many thanks.~
DHCP Server start failed, reason 'System.PlatformNotSupportedException: Socket.IOControl handles Windows-specific control codes and is not supported on this platform.
at System.Net.Sockets.SocketPal.WindowsIoctl(SafeSocketHandle handle, Int32 ioControlCode, Byte[] optionInValue, Byte[] optionOutValue, Int32& optionLength)
at System.Net.Sockets.Socket.IOControl(Int32 ioControlCode, Byte[] optionInValue, Byte[] optionOutValue)
at System.Net.Sockets.Socket.IOControl(IOControlCode ioControlCode, Byte[] optionInValue, Byte[] optionOutValue)
at GitHub.JPMikkers.DHCP.UDPSocket..ctor(IPEndPoint localEndPoint, Int32 packetSize, Boolean dontFragment, Int16 ttl, OnReceiveDelegate onReceive, OnStopDelegate onStop) in /home/jingxi/Code/autostress/Library/UDPSocket.cs:line 139

Hi Jingxi,
On linux, the IOControl method is not supported, you should comment it out (line 139 in UDPSocket.cs)
https://github.com/jpmikkers/DHCPServer/blob/master/DHCPServer/Library/UDPSocket.cs#L139
A prettier solution (on .NET 6) would be to test if we're running on windows before calling IOControl, like so:
if (OperatingSystem.IsWindows())
{
    m_Socket.IOControl((IOControlCode)SIO_UDP_CONNRESET, new byte[] { 0, 0, 0, 0 }, null);
}

My TFTPServer and TFTPClient libraries have the same linux issue, so I'll create a fix for all of those soon.


Port not correctly interpolated when collector contains root

Sometimes a collector URL may have an endpoint such as example.com/snowplow_event_tracker, which causes issues when interpolating the portString.
const targetUrl = protocol + '://' + endpoint + portString + path;

i.e. Given the endpoint example.com/snowplow_event_tracker, the current logic will place the portString at the end to give http://example.com/snowplow_event_tracker:8080/i rather than the expected place example.com:8080

this package is just a wrapper for the original package. if you find bugs its most likely there.


Use ray[default] package in RAG notebook

Fixes an issue with the ray client when trying to retrieve job status.

/gcbrun

Autopilot flaking due to known issue:
Error: Internal error occurred: failed calling webhook "default.podmonitorings.gmp-operator.gke-gmp-system.monitoring.googleapis.com": failed to call webhook: Post "https://gmp-operator.gke-gmp-system.svc:443/default/monitoring.googleapis.com/v1/podmonitorings?timeout=10s": No agent available


python312Packages.fyta-cli: 0.5.1 -> 0.6.2

Diff: https://github.com/dontinelli/fyta_cli/compare/refs/tags/v0.5.1...v0.6.2
Changelog: https://github.com/dontinelli/fyta_cli/releases/tag/v0.6.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 335893 run on x86_64-linux 1

1 package failed to build:

home-assistant-component-tests.fyta

4 packages built:

python311Packages.fyta-cli
python311Packages.fyta-cli.dist
python312Packages.fyta-cli
python312Packages.fyta-cli.dist


In WT version 1.2.2381.0, everytime I enter VIM it starts in insert mode

It seems to me it began happening after upgrade from WT preview. If I use putty for connecting to the same host and username, it doesn't happen.
I tested in RHEL 6.7 and Oracle Linux Server release 7.7.
Any clues?
Thanks in advance.

Environment
Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable):

Any other software?

Steps to reproduce

Expected behavior

Actual behavior

Does it start in insert mode or replace mode?

I'm using Windows 10 1909.

Does it start in insert mode or replace mode?

Goop point! In fact, it starts in replace mode. My bad.

Thanks! In that case, this is a /duplicate of #1637.


Updated Sampling Result names

This PR updates the names of Sampling result for consistency, closing #1648
The changes have been made following these specifications:
open-telemetry/opentelemetry-specification#938
open-telemetry/opentelemetry-specification#956
Changed from:

NOT_RECORD

RECORD

RECORD_AND_SAMPLED

Changed to:

DROP

RECORD_ONLY

RECORD_AND_SAMPLE

lgtm.


Fix keys aren't enforced

#1733 will happen when only some client keys are defined, like defined clientKey, javascriptKey and restAPIKey but missing the dotNetKey.
Added some test cases to demonstrate the fix.

[Current coverage][cc-pull] is 92.16%

Merging [#1789][cc-pull] into [master][cc-base-branch] will decrease coverage by -<.01%

File src/rest.js (not in diff) was modified. more

Misses +1
Partials 0
Hits -1

@@             master      #1789   diff @@
==========================================
  Files            87         87
  Lines          6206       6210     +4
  Methods        1069       1070     +1
  Messages          0          0
  Branches       1292       1293     +1
==========================================
+ Hits           5720       5723     +3
- Misses          486        487     +1
  Partials          0          0

Powered by Codecov. Last updated by [1854928...40dcb35][cc-compare]
[cc-base-branch]: https://codecov.io/gh/ParsePlatform/parse-server/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/ParsePlatform/parse-server/compare/1854928fe7c3e05be3524d9f647120969bcd46c0...40dcb3592e45b621b60586c8b0c20003ea24d2f4
[cc-pull]: https://codecov.io/gh/ParsePlatform/parse-server/pull/1789?src=pr

Personally I think we should be removing client keys entirely, they aren't necessary anymore in Parse Server. So I'd rather change the documentation to reflect the current behaviours. If people have specific use cases for client keys, though, I'd happily listen to them.
Also, this is a breaking change for people who currently have weird key setups so we would need to bump to 2.3.0 if we do this.

I understand
So I think we have two options:

fix the docs, as they are currently misleading and don't reflect the behavior.
if people want to use the keys, and declare them on the server initialization, then enforce. Otherwise, if no keys are set, don't require (except master, of course).

Technically, in Parse.com the applicationId alone would be enough also, right? Considering that both are meant to be public as well, what the keys really added there that they don't add here?

Also, if we remove them completely, people will need to change the server initialization to remove those unneeded parameters - although I don't think it would be breaking as much as enforcing if defined.

Yep the client keys are pretty much unnecessary. In JS you can provide extra, unused parameters, so people wouldn't need to remove them from the config.

So should I open a PR fixing the docs?

I am in favor of that solution but I haven't considered all use cases so if someone has a good reason to keep client keys around, we should merge this instead. I think @lacker had a reason, but I never heard it.

Can we spell out why we do or don't need the keys?
All I can think of for keeping:
Don't the client keys provide a weak layer of security? E.g. if someone wants to use a malicious client then they have a bit more work to do to extract the keys from an existing client.

I agree with @steven-supersolid . Even though it's a weak layer, it's another hurdle (small, I agree) to be passed.

weird key...even Parse blog said it is useless?
May I know what is the initial purpose of introducing client key in Parse.com?

The first thing you need to understand is that your client key is not a security mechanism.
http://blog.parse.com/learn/engineering/parse-security-i-are-you-the-key-master/

Why would extracting the client key be any harder than extracting the application ID?

That's right, I thought about it.
So taking it to the other extreme: if parse server isn't multi-app, why do we need an Application Id?

Actually we probably don't. But, if/when we approach running multiple Parse apps on a single server, the application ID might be necessary depending on the approach we use. Personally I think one app per mount point is the way to go but I don't want to close the door on multiple apps per mount point.

Fair enough! That's what I imagined.

I misunderstood that we were talking about removing the application ID as well. If not then the client keys are not so important.
I'm fine with removing the client keys.

Please do not remove client keys. Unfortunately I strongly believe that there are many misconfigured apps out there with messed up db rights that heavily rely on this mechanism. It is not a strong one for sure, but at least a key other than the appid is needed.


ebnf links broken for precedence expressions

Hi @OmarTawfik , is it possible to have more context on this? I could give it a shot to take it off your plate since I'm noticing that you have been assigned a lot of tickets.
Secondly, are precedence expression documentation in language-definition-v2.md intentionally missing this repo related source code link(s)? e.g

Hi @0xf333
Apologies for missing your comment! and thank you so much for your interest in helping!
I have updated the issue with more information. Please let me know if you have any questions!