Display search results in a tab instead of the side bar

I was talking to a colleague the other day and the only reason he's not using VS Code is because of how the search is implemented in VS Code and I have to agree with his opinion.
Both Sublime Text (which I'm used to) and Atom (the editor my colleague is using) feature a search tab. A search tab displays the results much more clearly given that there's much more space available to display them. Instead, VS Code displays them in a "small" side bar.
Yes, we can resize back and forth the side bar, but that's a bit annoying. It would be nice to have the search results displayed in a new tab similar to Sublime Text and Atom.

I prefer the functionality of VS Code over sublimes implementation.  I don't use sublime much, so maybe this is configurable; however, these are the limitations.

I can't simply cursor down over each match and have the file opened as I cursor down
It is harder to see just all the matches due to so much extra formatting and context around the matches
I often want to hide the side panel, but then go back to the last results again.  Not sure how smoothly that will work from another document.

I wider display however could be useful.  For example displaying in bottom panel instead of side panel.
Also, ability to capture the text of results would certainly be useful.  #17920

I know this has had some discussion before but can't find the issue right now. I've been toying with the idea of a button to dump the results from the viewlet into a sublime-style editor view, which would solve a few problems at once. Not sure how great that experience would be.

@roblourens I can imagine lots of people have different ideas of how the contents of the dump should look.  Would it be difficult to provide an API so that we could write extensions to do something with the results?

I understand your points @dakaraphi :)
My only reasoning for this was the wider display to show the results. Currently, in the sidebar, is a cumbersome to go through the results (especially when there are many of them).

@rfgamaral Thanks for clarifying.  In this case, you might be interested following this item #2806

I would love to have the search results shown on the bottom tabs where there's also "terminal" " outout" and so on.
is it possible?

IMO, all three options would be nice to have; in the sidebar, as a tab/buffer or in the console area.

Is this feature supported yet?

Isn't duplicated of #9435?

+1 I really love the way Sublime displays the search results so you get a the overview without opening each file.

I recently moved to VSCode. As a sublime user, while I feel at home, but Search UX is just not very good. I would love to see search results in wider bottom panel, which I can expand to full tab whenever I wish.

A huge 👍  to this issue. As a long time Sublime Text user, this is the deal breaker functionality. I often find myself resizing the search pane back and forth. Also lack of context in the VSCode search is another big thing. It makes very hard to find what you are looking for if you search something common in the codebase.
Hope this feature lands in the VSCode sooner than later.

likewise, I prefer to have more horizontal space to view search results 🙏

Just use Atom's search UI and a lot of Atom users will convert.

Another fun fact is, Sublime or Atom version of displaying search results also allows you to search in the search results which is really handy.

This. Another thing that is very important.
I hope whenever the search's re-layout work done, this search within search results functionality is taken care of as well.

I was talking to a colleague the other day and the only reason he's not using VS Code is because of how the search is implemented in VS Code

I'm so glad I'm not the only one. I'd really like to switch to vs code, as Atom is getting way too slow. But when I first tried to search in files and saw how the results were cramped inside the SIDE bar, I didn't know how fast to switch back after discovering that my only option was to make the sidebar wider manually, which also made it wider for the file explorer.
If vs code could copy a thing or two from Atom's UX it'd be a great editor, this is one of those things.

Display search results in a tab instead of the side bar please, like Sublime text

This is the one reason I have yet to switch to vscode. I've tried to make the switch multiple times but I need to see more context about the search results without having to continuously resize the LHS panel. Would be very greatful if this was user configurable at some point in the future.

At the very least, the sidebar with search results should expand. I find myself resizing it to view the results, then resizing it back down.

After using VSCode for a week, this is the only thing which is pulling me back to sublime. Really the search should be improved.

The VSCode search panel really need to be improved. It can't config the position and result displaying is too narrow.

honestly if the tab icons weren't so huge, it would be a good start.

+1 on this.  I'm still using Sublime because the search just works compared to VSC.  Please prioritize search results in tab as with Sublime including search on search results.  To anyone using both it is quite obvious change is needed as a priority.  VSC does so many things but then lets itself down with lack of essential find in files functionality.

@chrmarti @roblourens - Could we escalate this?

We have started to investigate into this one https://github.com/Microsoft/vscode/issues/9435
More specificaly, exploring how to adress the lack of horizontal space in search.
I feel this item is more general, thus it remains in the backlog for now.

Another use case for opening in a new tab is allowing to search multiple things at once and switching back and forth between the results. This is very useful when doing big refactors.

I recently shifted to vscode, and I have to use sublime when I perform a global search.
When the search results are opened in new tab It not only shows the required results but some code above and below, after which I can perform a search inside search results.
would love to have the same in vscode.

I completely agree and at least for me this is the only reason I'm not yet willing to switch from Sublime Text to VS Code. Searching and replacing is one of the most important features in a code editor and really needs:

enough space to enter multi-line search and replace strings (large uncluttered panel like in Sublime Text and Atom)
as much space as possible to show the search results (show results in a separate tab like in Sublime Text and Atom)
option to show context of search results (like in Sublime Text)
option to prompt for replacement in multiple files  (like in Sublime Text)

See https://github.com/Microsoft/vscode/pull/43833
Just set in your prefs.
 "search.location": "panel",

@aneilbaboo This does alleviate the problem when displaying the search results, but the pane is still far to small and cluttered. Additionally I would have to open and close the pane on and off instead of just having the results ready in a separate tab.

@aneilbaboo Thanks, this is brillant, almost a perfect solution ... the default location (side bar) is way too cramped, moving it to the panel makes it definitely workable.
Next problem is that I want an easy way to close the search panel when I'm done with it, so my next step was to define a keyboard shortcut for "close panel" (this is apparently not the same as "close editor", ctrl-w or cmd-w).
I like VSCode but this is one of the (seemlngly small but important) annoyances that would  keep me from calling it my favorite IDE, yet ... however step by step I'm getting there.
Tip (regarding the search dialog): with the "alt-up" and "alt-down" keys you can cycle through your search history. This is a feature which I like a lot in my other IDEs (Eclipse, Netbeans, Webstorm) and which I thought was missing but it's there, just a bit hidden.

@aneilbaboo Thanks, better.  But definitely not a perfect solution.  Results still cluttered and cramped, needs a separate tab.  Please reference Sublime Text implementation.  No need for reinvention, it just works.  This is plain to see for anyone using both.  Last piece missing from me moving over to VSCode!

@aneilbaboo @isidorn
[Feature Request] Pressing ESC should trigger a close on both the panel search result.

@pxwee5 use cmd+j

"search.location": "panel" is great. If space is too small, try utilizing View: Toggle Maximized Panel.

Any news? Because this is OP feature, like Atom or Sublime have. Because in panel there's no much space for height and it's hard to see if list is long ALSO it's way better to have option to move it to separate tab. I suggest to create option like: "search.location": "tab"
/cc @roblourens

"search.location": "panel" is a big improvement however the experience is still more clumsy and less ergonomic compared to what IDEs like Eclipse or Webstorm are offering ... but it's workable

@pxwee5 Agreed. In the meantime, adding the following snippet to keybindings.json will close the search window upon an ESC press when it that panel is visible.
{
    "key": "escape",
    "command": "workbench.action.togglePanel",
    "when": "searchViewletVisible"
},

Funny, I have gotten used to the search results in the sidebar and prefer it! Since the source files are listed in the sidebar, displaying the search results there is a more relevant fit in my opinion. I found this issue in order to figure out how to turn it back as the latest update seemed to set the new setting default value to panel. Glad there are options for us all :)

Problem with the sidebar is it's way too cramped and narrow! But if it works for you, then by all means ... good indeed that there are choices. The fact that VSCode is so configurable is one of the things I like about it (the other thing is that it's lightweight).

{
"search.location": "panel"
}

Have to agree here, the search result ought to be in a tab or at the bottom via vertical-split in my setup and I miss this at great length.
I think adding an option for that should be on the list.

I'm looking for to create a feature request for the Sublime Text behaviour of find where the results show in an Editor Tab the same as regular plain text files – I'm not entirely sure whether that's the same as this request? Is this request asking for them to just display in a bigger area but everything else to be the same? Or does this also cover the results being editable?

My key issue are:

enough space to enter multi-line search and replace strings (large uncluttered panel like in Sublime Text and Atom)
as much space as possible to show the search results (show results in a separate tab like in Sublime Text and Atom)
option to show context of search results (like in Sublime Text)

🙋♂

🙋♂
I really keep trying to switch from Sublime Text to VSCode but this is the single reason why I can't.

+1

In similar direction as the API asks, I'd like the search results document so I can continue to work with them.
If not an API, it would be nice to be able to export the results to a new document as a built in action.

Notepad++ does a nice way of searching in text, and displaying the results in the terminal / tab at the bottom

Similar to the comment about how NotePad++ does searching.  I really like how NP++ does search and replace in files.  In VS Code all I can do is click "ok" to each one individually when what I most times really want is for it to just do the search and replace without user intervention.  Then I can use git or a diffing tool to see the changes before I commit the code.

Ouch. Just switched to vscode for the day, and now back to atom after discovering this rather pitiful excuse for a search results view and over one year old unresolved issue with tons of feedback. Looks like a significant omission.

@abrambailey did you see this?
https://github.com/Microsoft/vscode/issues/23931#issuecomment-376060761

@davidnorthetal did you see this?
#23931 (comment)

@Matrosskin yes I did, but it doesn't invalidate the link I posted above, I for one consider this absolutely closed, how hard is it to bind a key that toggles the bottom pane?

@davidnorthetal in case question was about keybinding - yes, you are right. But the issue is about the place where a search result rendered, is not it?

Just set this in settings

I found the settings, but don't know where to add this text.

@Matrosskin  thanks! The panel display is beautiful! Almost like notepad++! This panel should be the default setting... I would prefer to see a longer snippet to use the panel space, as the line is trimmed to a max length it seems. But very nice.

This is not just a little thing you have to get used to. It is actually a dealbreaker. Searching something takes significally longer in VS than it does in Sublime.

@fabu-gharbieh this issue isn't about performance, it's about where the search results show up

@andrewdang17 I didn't mean the performance of the tool, but the performance of the workflow. If I search something and get all the results in a new tab, showing me all the hits and also some lines before I'll be finding stuff much faster.

I miss the search from Sublime.
My general Sublime workflow (as I work on several very large projects with thousands and thousands of files) would often be to search for something, realize I needed to dig deeper, search for something else, then scroll back up to see my first set of results.  As long as the search tab remained open, I had a history of what I've searched for.  And, perhaps the (second) nicest thing was I could also delete lines that were not relevant to what I was searching for.
For the curious, first nicest was the fact I could see the full line of the search (with only a single match per line!) and see the context in which the search was in (in my case, two lines above and below).
In the panel alone, there just isn't enough space to retain all of that, at least not comfortably.  And having a different font in the search panel also breaks continuity with the actual code I'm working on.  Having it displayed as actual snippets (with context) in the actual code editor, with history retention and editing, would be a huge benefit.
Come on VSCode, this would be a stellar addition, one that would keep me from having to flip between code editors.

I'll vote for "search.location": "tab". Search results displayed in a tab make me go through results easier (with vscodevim).

The Search UI at bottom panel need to a redesign. Look how much space the elements takes. It's terrible and the results view is limited, sometimes we a lot of results and we do not have the general concept of the file, like sublime or atom.

I also like how IntelliJ implements their Find in Path
which opens a separate floating Search window with its own preview
And when you double-click in any of these Preview, then it opens a new tab pointing at the instance

This is the only thing holding me back from fully switching to VSCode from IntelliJ

Search in VSS code is terrible. I have to hit extra enter to start search, it should be an auto-search. And every time I does a search and click the interested file, I have to do extra click on sidebar to go back to Explorer so I know the location of the file and check related files close by
This is deal breaker and it's still not solved. Many things of VSS code have been improved, but this issue has been there for too long

Regarding switching the search.location default to panel:
On #63465 @roblourens wrote:

I would challenge you to try to switch the defaults but I easily see this to have a lot of push back by people used to the result in the side bar.

Probably not going to do this. I don't like changing long-established defaults unless there is a really good reason.
I completely agree that changing long-established defaults is to be avoided unless there is a really good reason.
The real question if how good of a reason is this?
The first time I switched back to Atom after trying Code because the search result did not suit me, I did not search for a solution. So good defaults are key.  As @adamreisnz wrote here:

If I were developing an app to compete with very popular editors like Atom and Sublime, I would make sure that it at least takes all the good things and does them the same or better.
If 150+ people vote for a particular feature and tell me it's missing and that they're waiting to switch because of it, I'd be damn sure to prioritise that issue.
In reality there's probably 15,000 people who are can't be bothered to report the issue but feel the same way. It is still the only reason I'm not using VSCode to date...

150 is now 350 and considering the context here I think the multiplier it is at least 400 for the people that do not bother to report.  I am not sure how many resources you guys have on user research and time you can invest in A/B testing (that is probably a little awkward in an code editor) but I would look deeper to how many people are not using Code as their main editor for this very reason.
I expect push back from loud people just because they were used to the "old way" and do not like changes but since there is an option to go back to the current default, I do not think it may not be a big problem.

@ccinelli You're missing the point.  I use the panel, and it is far from good.
Everything might be fine if you're dealing with small projects with maybe a hundred files.  But step up to a monolith with tens of thousands of files, and sacrificing space means you're sacrificing time.
If the search is In the sidebar, you lose whatever view you were on: source control, file manager, whatever.  That means no panel pops up, which is nice, but doesn't allow for good flow.
If the search is in the panel, you're taking up valuable real estate, especially when you work on large projects. If the panel is on the bottom, you're cutting off anywhere from 25%-50% (on average and depending on your settings) of every document you have open.  If the panel is on the side, it's a bit less obtrusive, but makes search results for long terms basically unusable, and you run into the same issue: space.  That panel will end up taking up all your vertical space, resulting in a problem bigger than less lines readable - less columns readable.  Sure, you can close the panel, but then you lose your results, and it will inevitably be open in 5 minutes again anyway.
The reason tabs are important are:

Space.  I don't care if you have one file open or a hundred, having the search in a dedicated tab in the main area means you can see your results, act on them, and put them aside for when you need them again in a few moments.
Result visibility.  The search in VSCode provides results in their own font (Monaco, I believe).  Do you code in Monaco?  I highly doubt it.  By making the results in a tab, they can make the look and feel actually feel like you're looking at a snippet of your own code, while making results much, much more legible.
Result expansion and collection.  Wherever you put the search at today, having contextual lines around your search results is basically impossible - the results would span too many lines and you'd never be able to actually see everything.  In a dedicated tab, you could provide context - as well as per-file grouping - to see exactly where your results are in the context of other things.
Result manipulation.  As an example, Sublime Text uses tabs for search results.  You search once, and you basically have a new document with your results.  Some areas become click targets to go to a result or file.  The beautiful thing about this is you can modify your results.  Say you're making an upgrade to a framework and have to update every instance of some method call, but only in certain circumstances.  Being able to delete the results from the search once updated turns your search results into a valuable checklist that lets you go exactly where you need.
Result aggregation.  Again, in Sublime, when you search a second time, the results get amended to the bottom of the dedicated search tab.  If you have a related search but don't want to lose the previous one, great - it's still there - just added at the bottom.  I'd be OK with each search being in its own separate tab as well.  We've all been down the path of trying to trace something back, and once you go a few steps, you can't remember where you started.  Now you can.

One thing I'd be willing to lose in this scenario is VSCode's live-updating search results in the panels/sidebar.  It's kinda neat but it isn't really useful in practice.  I can always hit search again and get updated results.  For those that want to retain the live updating results functionality, that can be still be provided in the sidebar/panel views.

Not perfect, but it does the job for now https://marketplace.visualstudio.com/items?itemName=night-codes.sublime-search-vscode

@GuskiS and all... Sorry I guess I am still unfamiliar with the lingo of the different containers inside VSCode.  In #63465 search.location=panel  was brought up. For me it is an improvement compared to the sidebar. But I understand what you guys want here and I agree that a full tab would be a lot better.

Tried switching to VSC today, but like many others, I was really dissapointed with the search feature. It is quite terrible compared to Sublime. I think overall VSC is the superior product, but I rely on the search function too heavily to make the switch until this is resolved.
As many others, I am looking for a tab for the results with their necessary context.

What just happened?
Now it's in a tab at the bottom and I want it back in the sidebar! I often need to find something that's in a dozen files and scrolling in the bottom is a pain.
The fact that search is realtime is very valuable - but not if I can only see half a dozen results.
How can I put it back under Explorer!

I also like how IntelliJ implements their Find in Path
which opens a separate floating Search window with its own preview
And when you double-click in any of these Preview, then it opens a new tab pointing at the instance
https://intellij-support.jetbrains.com/hc/user_images/NdCWcxDumXweIEcto0mzqA.png
This is the only thing holding me back from fully switching to VSCode from IntelliJ

This right here. 100%
Not sure how many of you have experience with WebStorm, but the UX here is FAR superior to VSCode.

@t0byman wrote:

I also have the search:location set to panel. It's something but I really want the search results to be displayed in a separate tab/document like Atom and Sublime.

I wrote a comment here suggesting adding search.resultsLocation to compliment the existing unchanged search.location config parameter:
https://github.com/Microsoft/vscode/issues/68877#issuecomment-466354501
search.location is used to display the search form. search.resultsLocation would be used to target the search results to same (default and same as existing search functionality), tab or newtab. See that comment for further information and feedback on that would be appreciated :)

@t0byman wrote:

I also have the search:location set to panel. It's something but I really want the search results to be displayed in a separate tab/document like Atom and Sublime.

I wrote a comment here suggesting adding search.resultsLocation to compliment the existing unchanged search.location config parameter:
#68877 (comment)
search.location is used to display the search form. search.resultsLocation would be used to target the search results to same (default value and the same target as search.location), tab (show search results always in the same tab) or newtab (show search results always in a new tab).
Please see that comment for further information and any feedback on that would be appreciated :)

This looks great!

Plus one vote for a better search interface. The VSCode search sidebar is severely lacking in comparison with Atom or Eclipse. I'm not sure how anyone finds anything.

REALLY want to see a port of WebStorm's finder -- even as an extension. For anyone that hasn't used it, I recommend you download WebStorm and give it a go. It's infinitely superior to VSCode, Atom, Sublime, Eclipse, all of em...
I'm willing to contribute heavily to an extension if anyone wants to help set up some of the boilerplate. I've never developed a VSCode extension and not sure if I have the time to familiarize myself with the process.

In case anyone is curious of the status here, this is on the roadmap:

Investigate showing search results not only in the side bar or a panel, but also in an editor. This allows us to show additional context information for each match.

https://github.com/Microsoft/vscode/wiki/Roadmap#workbench

I don't know if anyone has already mentioned it, but another annoying thing about the search is that after opening a file from search results there doesn't seem to be a straightforward way to get back to the results. If I do Ctrl+Shift+F again it focuses the search box and I have to tab 8 times to focus the results again. Even if I hit F4 to Focus Next Search Result (which would be a clumsy and annoying and not legit solution for a variety of reasons anyway) it still doesn't even let me navigate with arrow keys. (If someone knows of a way I'm missing to get straight back to the results please let me know.)
In Atom you get a tab for search results, can navigate them with arrow keys, open a file, and can easily return to search results and repeat navigating and opening.

I'm seeing at least one person asking to contribute to an extension that implements this sort of search behavior, so I thought I'd plug my own:
https://marketplace.visualstudio.com/items?itemName=travisthieman.better-search
https://github.com/thieman/better-search
We're definitely still missing some extension points (namely, fully custom views in the Side Bar and any customization at all in the Panel) to make this really nice, but I think it's serviceable for now.
(Sorry if this is considered bad form, I'll delete the comment if this type of post is discouraged)

As someone coming from Sublime (mac), here's how I'm working around the limited space issue until the planned roadmap investigation:

Make your sidebar very wide (almost entire screen)
Close it using Cmd-B when done with a search.  Keep it closed while working in tabs.

Also has the benefit of allowing for better views of deep file structures in the Explorer.  Just get used to using Shift-Cmd-E to open explorer and Cmd-B when done.  Never resize the sidebar, always show/hide with shortcut.

I did not understand very well what was decided. But please implement this or show me the path I need to follow (files and tips) to do this.
I can not keep changing the size of my sidebar just to see where the file comes from or see the whole line.
I can not stand having to keep remembering to close my side menu every time I do a search on my project.
And the sidebar does not solve for me because it's a new version of the same problem, every time I need to close the footer.
My dream: I do a research, I click on the result and I go to the archive.
As I do today: I open the side menu, search and go to the file, 10 min later I see that it is missing space on my screen I need to close the side menu.

REALLY want to see a port of WebStorm's finder -- even as an extension. For anyone that hasn't used it, I recommend you download WebStorm and give it a go. It's infinitely superior to VSCode, Atom, Sublime, Eclipse, all of em...
I'm willing to contribute heavily to an extension if anyone wants to help set up some of the boilerplate. I've never developed a VSCode extension and not sure if I have the time to familiarize myself with the process.

EDIT:
There are some highly relevant considerations on the roadmap. I've experimented a little bit with creating an extension to support this kind of behavior, but I think I will wait for these:

Support for detachable workbench parts is our most upvoted feature request which due to architectural issues is challenging to implement. We will explore how we can work around this limitation. This investigation will focus on detaching terminals (2nd most upvoted feature request) and editors.

Investigate custom viewlets and panels.

this maybe resolve the problem too, a floated window displaying the search results instead a tab.

I want to switch to VSCode but this issue annoys me. So a +1 from me, opening the results in a new tab (like Atom) would be way better.

It's a GREAT idea, but I would like to vote for it as an option to choose from.
Something like "search.ResultsDisplay": and choose here "atSidebar" or "atTab"
Why? Because in small projects, the search in the sidebar is still useful

As others have mentioned above, i also want these two things in Code desperately:

search results in a tab
searching within the search results

These two things make intuitive sense when using an editor to reduce mental context switches. This should be available as an alternative search simultaneously available, imo, as the current search is useful too but most of the times it is not what i want
After seeing the WebStorm screenshot above, it seems like a good mash of Sublime + Code search in a grep-y way but not sure if search within search results is possible in it

is this thing  finished investigating stage and move to development yet? I also need this feature. Hope to see it very soon

It is a bit disappointing that this feature is still not available after 2 years.
The search results are still not syntax-highlighted and stylised as it is in the editor.

I found my self more often outside of VScode to run my searches. VSCode is definitely subpar compared to other editors if your worflow involves running often searches and they generate a lot of results.
So the suggestions in comments above are definitely a must. But I am adding another request: Sometimes if you end up with tons of files, being able to group results in a tree folder would greatly help.

I found my self more often outside of VScode to run my searches. VSCode is definitely subpar compared to other editors if your worflow involves running often searches and they generate a lot of results.
So the suggestions in comments above are definitely a must. But I am adding another request: Sometimes if you end up with tons of files, being able to group results in a tree folder would greatly help.

Clarification of thread:
You can today put the search in the panel (horizontal oriented bottom where terminal is located) by flipping search.location to panel.
What OP asks for is for a way the get search result to appear in a new editor tab. (Like in sublime for example)
If you have other ideas not directly linked to OP's suggestion please create a new Issue.
..AND I can't second this issues suggestion enough!

Lackluster search is the only feature that prevents VSCode from being as good or better than other editors. I'm sure I'm not alone in this opinion. Running multiple searches in several tabs often based off the results of another search is just such a common pattern in analyzing and refactoring large codebases. I hope this can be made a priority over other more niche features, IMO search is a really foundational feature for an editor and it being a poor experience really hampers adoption of what it otherwise one of the best editors.

I agree 100%. There are definitely other little quirks and nuances that get to me, but I would forget them all if the search experience compared to Webstorm's.
I've said it before - if the extension API opens up a little to let us do things like create detachable floating windows, I will totally pour my heart into building a VS port of Webstorm's finder.
I know that's on the roadmap, but it's been so for quite a while now. Anyone know what the priority is on those features?
On Sep 11, 2019, 15:15 -0400, amorsillo<EMAIL_ADDRESS>wrote:

Lackluster search is the only feature that prevents VSCode from being as good or better than other editors. I'm sure I'm not alone in this opinion. Running multiple searches in several tabs often based off the results of another search is just such a common pattern in analyzing and refactoring large codebases. I hope this can be made a priority over other more niche features, IMO search is a really foundational feature for an editor and it being a poor experience really hampers adoption of what it otherwise one of the best editors.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Is it possible to get search results from the current document to a bottom panel?
Like in Notepad++?

Switched from VS Code to Sublime. Missing search from Sublime a LOT!!!

I found the expand to full screen button on the panel can mitigate the search problem quite a lot. @nobreferreira You may try it out. Hope you can come back.

Hope you can come back.

He will come back faster than he thinks 😜

😆 I explained myself wrong!
I switched from ST to VSCode. But I'm missing search from Sublime a LOT!!!
Although I miss the ST search a lot, it isn't reason enough to get back to ST.

I had this exact problem (wanted results to new tab/buffer) until today but then I found @thieman 's Better Search: https://marketplace.visualstudio.com/items?itemName=travisthieman.better-search
It does exactly what most of us are wanting here! It outputs results like Sublime and you can have multiple results tab open.. And what best, you can search from search results!! :)
I recommend trying this extension while we wait for this to be standard. Good work @thieman :)

I have Better Search installed but the results keep showing in the sidebar.

I have Better Search installed but the results keep showing in the sidebar.

Afaik, you need to run the extension using ctrl+shift+p in order to use it, instead of the built-in search.
It then collects your search options, then shells out to ripgrep, then puts the formatted results into a tab; it's really very clunky. It's still an improvement on the built-in, tiny, zero context sidebar search, but I'm still not migrating from Atom until this gets considerably better, somehow.

The ability to search, then search for something else, then go back to the previous search results quickly because you wanted to check something again is incredibly useful. In Visual Studio Code the search results are lost after each search. I have to try remember what obscure thing I was searching for before then search again. It makes VS Code almost useless as an IDE.
I used to use Netbeans and here's how they do it with a search window that appears at the bottom and different buttons to click on the results:

This issue was first opened in April 2017.  Consensus is pretty clear.  Why this is taking 2+ years to address is a total mystery.

This issue was first opened in April 2017. Consensus is pretty clear. Why this is taking 2+ years to address is a total mystery.

Yeah, that's quite interesting, but what we can do (except PRs)? 😔
Anyway respect for VSCode team developers returning this program for free

@worsethannetbeans FWIW, the search box has history, so if you push the up arrow you can see previous terms you searched for.

Coming from Atom, regretting that I did not move earlier because I like pretty much everything in VSCodium more I really hate the search in the sidebar. My idea for a simple extension would be to temporary change the sidebar width for a predefined width and then back to what it was when not searching anymore. Basically a search 'tab' width as the sidebar kind of has its own tabs.

I am also coming from notepad++ and i miss this a lot.
Plugin mentioned here are ok but in my opinion a better workaround is:
1-Copy current full file path
2-Open the "find in files"
3-Define "files to include" correctly
Then we could just paste or type search text.
Does such extension exist? Didn't find it and have been doing all this steps manually...

Search result in panel is good for me, but search results only show a very small part of the line that the result is in.
Please show whole lines in search results, or add just two simple options.

full-line: full line + scrollbar.
focus-match: focus on the actual match (same as now and default form of display).

+1 - there are also time when I want to use the search results as the basis for a document.  Can't do that when it's in the sidebar.

+1 for Search system similar to NetBeans from which i came to VSCode as well.

This is generally very good news. Here is another thing I had on my mind since I switched from Emacs to Code: Since search results are in an editor, would it be possible to edit search results? To implement a search-and-replace?

@JacksonKearl I think it would be cool to be able to use a peek view on the search results editor to see those results in the actual file.

Hey all, this sprint I'll be working on an initial implementation of this feature. The current thinking is to provide a new 'search-result' file mode and syntax, and in search-result-mode editors, provide for navigating to individual results. These editors would be created by a "Copy Results to Tab" action in the existing search panel or viewlet, so you would open a search's results in a tab by first preforming a search in the viewlet or panel, then triggering the action (through keyboard shortcut, command palette, context menu, or button). Saving the results to disk and using them later would be supported.
I'd like feedback on if this would satisfy your search pain points, and if not what additional functionality you'd want to see.

@JacksonKearl This is great news! Thank you for looking into this.
One thing that would be great to consider as part of your design is that it would be extremely useful to be able to edit files from inside the search results tab (as mentioned earlier). This was my all time favorite feature in Emacs and it would be amazing to have it again in vscode. Here is an example of what I'm talking about for inspiration (if someone has a better presentation for this feature, please share it).
It's definitely not a requirement for MVP, but it would be great to keep it in the back of your mind to leave room for future developments.

Love you man 👍 Would be great if we can customise it. For example.

Costuming where to open the tab. Spilt current screen so you see search results under the editor you are work on and you can click in the search result tab to move around in the main editor.
Possibility to open results always in a tab
Visually clear display file and line with high-lined search keyword.

Awesome! I think it will be perfect
I guess for me the ability to show X lines above and X lines below the search result would be nice.
Also the ability on the search results page to "search" again. I like to be able to get a general list of results and then say search for something I know will be near it.

@JacksonKearl  Not sure if this in the scope of this feature, but since you mention:

Saving the results to disk and using them later would be supported.

My common workflow during refactor or similar is to do a search, and while going through results I'd like to "bookmark" a particular search result/match so that I can later go back to it after the initial refactor is done. In other words, I want to persist a given result, while being able to run new searches.
That's what this issue is about --- but, instead of being able to clone only the whole search list (which can contain tens or hundreds of matches), I often want to clone/persist only one or a few of the matches.
If this feature makes sense, it could be implement in two ways:

Allow to mark a result item (e.g. via a context menu item) to be persisted across new searches (i.e., it would effectively freeze the result item, and put it atop/bottom of any subsequent search results, when a new search is made --- until it's manually removed, either selectively, or the search is explicitly cleared as a whole).
Allow to clone to new tab just a single result item, as opposed to all results. Preferably, all subsequent matches that user marks to be cloned would end up in the same tab, so that when you want to persist several items, it wouldn't create new tab for each.

Thanks for consideration.

@JacksonKearl In regards to @roblourens comment about using peek to see results -- it would be also awesome to be able to edit in there as well -- especially with @bpasero's recent work to allow saving from inside the peek

Hey all, this sprint I'll be working on an initial implementation of this feature.

Amazing, thank you!

so you would open a search's results in a tab by first preforming a search in the viewlet or panel, then triggering the action

I never want to see the search panel, ever. It's worse than having the results in a tab, in all cases, so I just want to search and have the results in a tab. If there could be an option to just show the results in a tab immediately, and not show the panel, that would be ideal. Everything else is a bonus, but this is key.
There are some existing extensions that allow you to end up with search results in a tab, but they're all clunky, involving extra steps. If you implement a solution that allows you to end up with search results in a tab, eventually, with extra steps, then that doesn't really improve the situation much. It would be a shame to spend time implementing something that doesn't really fix the core UX issues.

@JacksonKearl It would be great to have a dedicated shortcut for showing/hiding this editor for half of the screen (without a need to split the window)
@joehillen take a look at helm-swoop

@JacksonKearl In regards to @roblourens comment about using peek to see results -- it would be also awesome to be able to edit in there as well -- especially with @bpasero's recent work to allow saving from inside the peek

This is a nice idea, however note that the current implementation will only check for the currently focused embedded editor, but not all embedded editors. I found it weird to save all embedded editors because they may not be all in view. But we can revisit this decision as needed. Code pointer:
https://github.com/microsoft/vscode/blob/65050271c24788f74456cc9210931dbecf9c79c5/src/vs/workbench/contrib/files/browser/fileCommands.ts#L354

@JacksonKearl awesome, this will be great!
My feedback would be also the same as @dflock's comment above - I would suggest having a way to show the search results in a tab instantly:

If there could be an option to just show the results in a tab immediately, and not show the panel, that would be ideal.

@JacksonKearl good to hear that this issue will be tackled
I would be happy to at least get the functionality currently available in sublime text but anything better is more then welcome.

I have Better Search installed but the results keep showing in the sidebar.
What am i doing wrong? How do I activate the result in a tab?

@nobreferreira @dflock You can also configure shortcut to open Better Search. Just press CMD+SHIFT+P and type shortcuts, then search for "search". You can replace normal search or bind another key combination for new search.
I have used CMD+SHIFT+G for Better Search because some quick finds normal search is okay :)

Thank you @JacksonKearl!
I also agree with @dflock's comment above.
I would like CMD+SHIFT+F -> type query -> return to instantly open a new tab with the results. (No sidebar or panel interaction at all)

BetterSearch doesn't seem to actually work, full options is super annoying because it asks you like 5 questions just to do a search. Quick search returns no results even though I know there should be some for my query. Vscode is a huge fail at search compared to Atom.

@JacksonKearl Thanks!!!
Sorry to be repetitive but I agree that it would be ideal to automatically show the search result in the new tab with NO panel interaction at all (Just like Sublime Text does it):. Maybe an option in Settings to do this automatically. Also, in sublime you can double click a line (from the search results tab file) and it does take you to the actual file. This I think it is important, otherwise there would be no option to actually navigate to the actual file having the search result. If not familiar, it would be sweet if you download Sublime Text and just take a look on how its search functionality works.
Thanks again!

@JacksonKearl, thank you! This is my number one missing feature!

As other have mentioned, using the Sublime Text search flow would be really helpful. For v1, it would be great to just have:

Search results in a new tab on cmd/ctrl+shift+f
Search within the search results tab
Clicking search result to open the relevant file

Everything more than this is a gift

I think that:

Search results in a new tab on cmd/ctrl+shift+f, no panel ever.
Clicking search result to open the relevant file, at the relevant line.

are the bare-minimum/mvp features here. Everything else can be added in the future. There's lots more to add - as people say, see Atom & Sublime for really nice implementation for full-tab search - but these are the minimum for this to add value.

It would be nice to have an option to choose output format:

~/path/filename
50: match
500: match

vs

filename:50: match
filename:500: match

Hey all, an initial implementation of this is out in Insiders for you to play around with, the setting "search.enableSearchEditorPreview": true will enable it. We won't have this finalized it by the next Stable release, but it will be released as a Preview, accessible via the same flag.
Thanks for all your feedback! It has helped shape various aspects of the implementation for this release. I've gone through all the requests and outlined the extent to which they already are or will be supported:

"Live" Search Results: Extension candidate. I can give a rough layout of how the extension might operate if anyone is interested in implementing it.

Customize where to open the tab: Currently the tab will always open in your active editor group. A flow that works for me is to open the results in a tab, then use Command+Option click on a result ("Open Definition to the Side", also Command-K F12) to open it in the editor group to the side, creating one if it does not yet exist.

Possibility to open results always in a tab: Not yet, but this will come in a future iteration, likely as this comes out of preview.

Visually clear display file and line with high-lined search keyword: I hope the file is clear! Results are highlighted, and the colors can be configured with searchEditor.findMatchBackground and searchEditor.findMatchBorder.

Context Lines: I'm currently working on this; I don't yet have a good idea of how to surface configuring this in the UI, but in preview the functionality at will be accessible with a command or setting.

Search in Search: This is supported via the normal Ctrl/Command-F "find in file"

Allowing to clone to new tab just a single result item: This is an interesting idea, I think it could be implemented as an extension where if you select some results in the editor, a command would pull those out into a new editor.

Peek to see results: Peeking is supported, and editing in a peek view is already possible, the one hiccup is that saving those edits requires saving the search results as well, which might not be desirable in same cases. Cc @bpasero for if we can make a peek save without requiring the main editor save.

"I never want to see the search panel, ever": As above, we'll provide for editor searches by default eventually, but not this iteration. For now, the search panel/viewlet is the only entry point to a search editor. From there, it's command-enter (Mac-only) to open the current results in an editor. With the work done to make search run as-you-type, the workflow should be reasonably smooth: type as much of your query as you need until the viewlet's/panel's results are correct, then command-enter to open those results in an editor and begin working through them. That being said, an extension today could make, for instance, Command-Shift-F (Find in workspace) open a search editor and place your cursor on the query line for you to type the search or paste in what you had previously selected, then trigger it to fetch results with the re-run search action (Command-Shift-R).

Dedicated shortcut for showing/hiding this editor for half of the screen: Once this is out and people start to play around with it we'll start to come up with a good set of commands for interacting with the editor in an intuitive way, this may be one of them!

"I would like CMD+SHIFT+F -> type query -> return to instantly open a new tab with the results": Extension Candidate, as mentioned above in more detail.

Double click a line to take you to the actual file: We're currently using the standard "go to definition" click, which is configurable in settings. Double click already is "select word", which I don't really want to redefine specifically for the search editor.

Formatting configuration: Not currently on-deck, as the benefit doesn't seem to outweigh the complexity of parsing and serializing across many different syntaxes. If there's a good use case we might reconsider.

"Live" Search Results: Extension candidate. I can give a rough layout of how the extension might operate if anyone is interested in implementing it.

I'd be interested. What do you mean by "Live"?

@joehillen by “live” I mean when a source file is edited, those changes are reflected in the search, and conversely if one were to modify the textual results, the source files would get modified as well.
I envision an extension contributing a “make search results live” action, which would first ensure the results match the files (possibly through a simple re-run search command), then establish file watchers on both the search results editor, and all files referenced from the results.

My suggestions are still current: https://github.com/Microsoft/vscode/issues/63465#issuecomment-440223799

Just read https://github.com/microsoft/vscode/issues/23931#issuecomment-559227491 - It looks good!

Thank you for your work on this!
--
In this life we cannot do great things. We can only do small things with
great love. -- Mother Teresa

@JacksonKearl thanks for this preview and progress report!
I think there may be some confusion in some of the points that you mentioned as feedback. I think the following three points all are the same feature, just described differently.
What was additionally confusing for me is that you answered differently to them:

Possibility to open results always in a tab (@turururu in https://github.com/microsoft/vscode/issues/23931#issuecomment-555673989): Not yet, but this will come in a future iteration, likely as this comes out of preview.
"I never want to see the search panel, ever" (@dflock in https://github.com/microsoft/vscode/issues/23931#issuecomment-555701290): As above, we'll provide for editor searches by default eventually, but not this iteration.
"I would like CMD+SHIFT+F -> type query -> return to instantly open a new tab with the results" (@blakeprudhomme in https://github.com/microsoft/vscode/issues/23931#issuecomment-556076368): Extension Candidate, as mentioned above in more detail.

@karlhorky Apologies for any confusion, I think "extension candidate" is the wrong term here, it's more like "this particular flow can be implemented by an extension with 1.41, and may become part of core in ^1.42". Case by case:

Possibility to open results always in a tab: An extension is not able to take a query from the viewlet/panel and run it, thus it cannot open those results in a tab. But in the future we may allow the search location to be 'panel' | 'viewlet' | 'editor', which would make it possible to only ever view results in the editor.

"I never want to see the search panel, ever": An extension is not able to remove panel items, this again would come as part of the possible 'panel' | 'viewlet' | 'editor' search location.

"I would like CMD+SHIFT+F -> type query -> return to instantly open a new tab with the results": An extension can contribute keybindings to trigger arbitrary scripts, and it can create search-result mode editors and fill them in with query text, and it can trigger a search.action.rerunEditorSearch command on vscode to fill in the results. So this is implementable by an extension, though such an extension would become obsolete if we implement 'panel' | 'viewlet' | 'editor' search location.

Does that clear things up any?

@JacksonKearl

Peek to see results: Peeking is supported, and editing in a peek view is already possible, the one hiccup is that saving those edits requires saving the search results as well, which might not be desirable in same cases. Cc @bpasero for if we can make a peek save without requiring the main editor save.

I would not want to change this because it could frustrate users that save works only in some cases depending on focus.
Why is the search editor an untitled editor at all? That seems weird to me.

@bpasero what would you suggest using instead of an untitled editor?

@JacksonKearl a readonly editor. You can simply provide a text document content provider for a resource and open it. This editor will not allow for editing nor participate in dirty and save.

@bpasero But the idea is that you can edit and save these documents -- you can edit the query and re-run the results, you can commit the query to be reused by your team, etc.

Agreed, that's very useful.
On Thu, Dec 5, 2019 at 11:57 AM Eric Amodio<EMAIL_ADDRESS>wrote:

@bpasero https://github.com/bpasero But the idea is that you can edit
and save these documents -- you can edit the query and re-run the results,
you can commit the query to be reused by your team, etc.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/23931?email_source=notifications&email_token=AAASGN3MRYJPMX6QJERHEH3QXFMLPA5CNFSM4DGQQDRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGB6I3Y#issuecomment-562291823,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAASGN6WXLZLILBENEODQCDQXFMLPANCNFSM4DGQQDRA
.

--
In this life we cannot do great things. We can only do small things with
great love. -- Mother Teresa

@JacksonKearl : Apologies for any confusion...

Alright, ok, that's a lot of detail that I didn't consider.
However, my point was, maybe there could be a solution that would make everyone happy:
A true / false option for this:
☑ When a search is performed from the panel, show results in a tab
It's not exactly what each of the requests said, but maybe it's enough to satisfy  @turururu, @dflock, @blakeprudhomme and any others that agreed? At least for a first version?

Update:
Stable v1.41 shipped yesterday with the initial, experimental, search editor. It contains the base features I listed above.
On Insiders we also have Syntax Highlighting, which I find to be a really nice addition to the experience:

A full-fledged UI for the editor is coming soon, which will basically be search results in the text format you see now, but with proper input boxes and buttons for the configuration. With that will come allowing the Search Editor to be the default search experience.

Keeping the editor writable is important so that you can selectively remove and keep only the results you want.

@JacksonKearl This is awesome! Is it possible to open files from search results in the column next to the search editor?

@1st1 yes you can open the source file of a result using the "Open Definition to Side" command, which is Ctrl/Cmd + F12 or Ctrl/Cmd + Option + Click. (might be different on different OS's, but you can look it up in the keybindings editor)

A panel option would be great. I find vs code greatly superior in almost every way. But I still go back to Atom when I need to search the entire workspace

@1st1 yes you can open the source file of a result using the "Open Definition to Side" command, which is Ctrl/Cmd + F12 or Ctrl/Cmd + Option + Click. (might be different on different OS's, but you can look it up in the keybindings editor)

@JacksonKearl IMO, this is too much friction when you just want to open a file from the result.
It would be really great to just left click on the file name or the line number and be taken to the appropriate location in file without having to remember shortcuts.

it would be soo nice tho, that the opened editor with the search results, are not considered as a saveable file.

@andrasnyarai please open issues against the current implementation as new issues.

@JacksonKearl like so? https://github.com/microsoft/vscode/issues/87961

@JacksonKearl this (when combined with search.action.openNewEditor) has greatly improved the developer experience when using vscode. Thanks, amazing.

Is there a way how to navigate results without using mouse? I would really like to make it work nicely with VSCodeVim.

@kolpav you can navigate the results using the keyboard as you would any other editor, but this may not work with some extensions which add their own keybindings. Are you finding that the VSCodeVim specific bindings don’t work in the editor, or that no key commands at all work?

@JacksonKearl I just tried it on fresh insiders version so it doesn't interfere with any extensions.
This is my non-vscodevim shortcut
[
    {
        "key": "ctrl+.",
        "command": "search.action.openNewEditor"
    }
]

I press ctrl+. type something I want to search for, press enter and then I am unable to go to results. Left and right arrows just cycle through previous searches.

It’s set up the same as the search viewlet - you can use the “search editor focus next input” (or something like that) command you move focus from the input areas to the results. This defaults to Cmd/Ctrl+Down. Esc to move focus back to the query input.

@JacksonKearl Nice now I can focus results window. Last thing is how do I navigate to specific search result?

@kolpav See @JacksonKearl's answer to my question here: https://github.com/microsoft/vscode/issues/88154#issuecomment-578331665
Short answer: Use the Go to definition command.
I asked a few other questions about keyboard nav in that thread, and I also use VSCodeVim. 👍

@adamlogic Works great thanks, love this feature already.
For others: Shortcut for go to definition when using VSCodeVim is gd so no need for any custom bindings.

@kolpav is it, for you? I have F12 as my shortcut for that (macOS)...

The new search editor is an excellent new feature! It's very useful, especially for examining the context around search results.
However, I have noticed that files with certain extensions in the search editor do not have syntax highlighting in the search results. For example, for Perl, all .pl files have syntax highlighting in the results, but .pm files do not. I even added "*.pm": "perl" to my files associations in settings.json. Is anyone else seeing this issue?

@Kenobi-the-2nd unfortunately custom file associations won't work with the search editor - it uses a statically generated tm grammar that identifies which scope to inject into the result body based on the file extension of the file name line. See: https://github.com/microsoft/vscode/blob/4e81d10222d0a533d15094a1454b1ea40e83b5c4/extensions/search-result/syntaxes/generateTMLanguage.js#L39-L42
Aside, figuring out which extensions to use for Perl was actually one of the most troublesome parts of that entire script, and I still got it wrong. Whoops.
Tracked & fixed in #90550.

Ok, thank-you for adding it. I took a look at your mappings and noticed that you do not have any for ".cfm" or ".cfc" extensions (ColdFusion modules and components). A ".vue" extension is missing as well. If you would not mind adding these when you get the chance, it would be much appreciated.

This is awesome!! ❤
Now can you add an option to sync Search and Find the same way Sublime does it? #34970
It would also be nice to put the cursor in the editor instead of the search box after searching.

@JacksonKearl awsome job! Now I can finally switch to VSC!
I beg you on my knees to implement Save changes functionality.
Sublime has extension Find Results Apply Changes.
I use it all the time to selectively refactor my code.

@chavlji An extension can implement a simple version of such functionality today, but an implementation hardened enough to go into core is not likely to come soon. For instance: what happens if the source documents are modified or moved, or for that matter if the search editor itself moves? To come into core we'd want a proper 2-way sync, which would be a significant development effort and would potentially entangle the core logic in ways that make further developments more difficult too.
However, an extension would be able to get away having more constrained behavior, and could be implemented relatively simply by reading window.activeTextEditor.document and iterating through all the lines, writing them back to the source documents if changes are detected.

@JacksonKearl I understand all of your concerns. The above mentioned plugin for Sublime didn't care about things like that, but it was still very useful. But I agree it can't be put into original product in a state like that.
Thank you very much for the plugin example! I will definitely play with it when I have some time!

@chavlji I will be releasing the extension to the marketplace after I make some changes on the VS Code side to allow for better functionality, that should be out in time the stable release.

Awesome! Thank you very much! It will be a top notch!
Where can i monitor the progress or find out about extension release? Should I monitor this thread or the extension-mock repo?

@chavlji  I'll make a release on https://github.com/JacksonKearl/vscode-search-editor-apply-changes when it goes out. You should be able to subscribe to changes for that.

I'm really liking how this is coming along 👏
A few refinements I'd love to have:

Include the count of results in the openNewEditor top-of-the-screen interface, like there is in the bottom panel (e.g. 20 results in 15 files).
Remember the Show context setting. I have to re-set it each time a do a new search.

@lucascosti thanks for the feedback, please file separate issues for feature requests so the community can vote on them, as per our specification for handling feature requests.

Is there a way to open files from search editor not in the current editor group, but in the previously active one?
I want to be able to see list of search results + edit files at the same time.

@dmi-dmi-dmi does Open Definition to the Side work for your situation?

Hi! First, thank you for this feature! I now have totally abandoned Sublime Text now!
Second. For some reason Select All Occurrences of Find Match (via Show All Commands or the key shortcut) is not showing up or working in the search tab where all the results show. Any idea?
Thanks!

@cafesanu first, are you on Insiders or Stable? Search editors have been heavily polished this iteration.
In insiders, I see this:

Note that the action is not "Select All Occurrences of Find Match" but rather "selectAllSearchEditorMatches". This is because in the search editor you may still have a local in-editor find open that you want to select all occurrences of.

@JacksonKearl  Nice. Yeah I am in Stable. I do see it in Insiders. Will use it!
Any way to see it in Show All Commands? Thanks!

I can't seem to get the search to appear in a tab when right clicking a folder in the sidebar and selecting Find in Folder. I have enableSearchEditorPreview enabled. It seems to take the setting into account only when I start a new blank search.
I have enableSearchEditorPreview enabled, am I missing another setting somewhere?

@cpascu I have not yet made a setting to prefer the editor for the “find in folder” context menu action. If you submit a new issue I will look into it.

Can I set hotkeys on "search.searchEditor.doubleClickBehaviour": "goToLocation" instead of double click behavior?

@igolskyi I'm not sure what you mean. You can configure keybindings using the Keybindings Editor
https://code.visualstudio.com/docs/getstarted/keybindings

@JacksonKearl Yes, I want to configure keybinding for command "goToLocation" but I don't know how does it (command by double click) names.

@igolskyi the command run on double click will either be 'editor.action.goToDeclaration' or 'editor.action.openDeclarationToTheSide' depending on search.searchEditor.doubleClickBehaviour. Does that help? You can rebind those in the keybindings editor.

@JacksonKearl yes it's editor.action.goToDeclaration ) Thank you so much )

I almost get this feature set up perfectly but I am unable to figure out how to always reuse the search tab I don't need new one for every search I make any ideas?
Btw this keybindings greatly improved my search experience. You open search editor with whatever shortcut you have it mapped to, start typing your search query press enter and it will focus search result window, press ctrl+n to go to next search result or press ctrl+p to go to previous one esc will focus search input again.
  {
    "key": "enter",
    "command": "search.focus.nextInputBox",
    "when": "inSearchEditor && inputBoxFocus || inputBoxFocus && searchViewletVisible"
  },
  {
    "key": "ctrl+n",
    "command": "search.action.focusNextSearchResult",
    "when": "inSearchEditor"
  },
  {
    "key": "ctrl+p",
    "command": "search.action.focusPreviousSearchResult",
    "when": "inSearchEditor"
  }

Is there any way to default the original search to this? or a shortcut to bring it up the search editor? looks like we can only do it via the command pallet

@andyd0 You can assign a keyboard shortcut for the search.action.openNewEditor command.
You can also assign it to Ctrl + Shift + F, then remove the default shortcut on workbench.view.search command.

@kolpav

I am unable to figure out how to always reuse the search tab

No way to do this currently. If you open a feature request for this I will look into adding it.

press ctrl+n to go to next search result or press ctrl+p to go to previous one

F4 and Shift+F4 already do this for both search editors and the search viewlet, just btw.

press enter and it will focus search result window,

Neat.

Can openLocationToSide not always consider only editor group to its right? Case: I want the search editor on the right side, and when I double click I want it to open the file in the editor group to its left (which already exists).

@dwelle It uses the existing editor.action.openDeclarationToTheSide command. You can open a separate feature request for that to consider other groups.

@JacksonKearl Great work! Thank you!

Is it only me or did this feature break the Replace All button of the global search?
My steps are same as before:

Open the Search Sidebar
Enter a Search Term
Click the little arrow left of the Search Term field
Enter a Replace Term
Hit "Enter" to search all occurrences and show a list of changes
Click the "Replace All" button on the right side of the Replace Term field
Nothing happens.

I must go through every file in the list of occurrences and apply the changes with the "Replace all" next to the file name. Do you have the same issue?

@PJUllrich yes; that’s tracked in #92443 and fixed in Insiders.

I got this new feature today with an update. But search results in a separate tab?. I mean, in a recent update from the vscode there was an option to shift the search result anywhere you like. I've moved mine right next to the terminal. This is quite handy than the search result in a separate tab. In fact, with the search results at the bottom, it's very much similar to the IntelliJ.
Check it out here:
https://code.visualstudio.com/updates/v1_42#_moving-views-from-the-sidebar-to-the-panel


Specification of how to serialise datamodels

Added a figure specifying how instances can be serialised: https://raw.githubusercontent.com/emmo-repo/datamodel/serialisation/figs/serialisation.svg
I would prefer alternative 2 where the serialisation of both entities and their instances are done with individuals. If you agree, we should clean up the figure and use it as an example of how to use this ontology.

I think it would be very useful to have an example to better evaluate which is the best alternative. My immediate respons is that I think speciffic data models (entitities) and instances of these should conceptually both be individuals (alternative 2, as I understand), but I do not properly grasp how these two alternatives will be implemented (differently).

I think it would be very useful to have an example to better evaluate which is the best alternative. My immediate respons is that I think speciffic data models (entitities) and instances of these should conceptually both be individuals (alternative 2, as I understand), but I do not properly grasp how these two alternatives will be implemented (differently).

Isn't the figure easier than a turtle file as an example?


clarity on 'uid' usage + move examples to permission naming convention rule

a) more clarity: scopes must be always defined. Use uid pseudo scope in case no API permissions are needed (green or yellow), or endpoint protection is done  differently w/o permissions
b) delete repetition of uid usage in the same rule below
c) move scope examples to the rule below defining the scope naming convention

:+1:

👍


Add ref access to sections

Describe the feature
It would be nice if each FormKit component section had a ref to the underlying DOM element. For example:
<script setup>
const myFormKitComponent = ref()

onMounted(() => {
  // This is a ref to the `<input>` element:
  myFormKitComponent.value.refs.input
})
</script>

<template>
  <FormKit ref="myFormKitComponent" type="text" />
</template>

To clarify, the value of refs would be the DOM nodes for all the section keys for a given input. eg (outer, wrapper, inner, input, etc).

wait in hope

This really feels like missing functionality. at the least it should be possible on an inputish (I mean select, input, checkbox, etc) component to get the dom input. right now it is strangely complicated just to enable a "prefixIcon" click to focus an input element


Portfolio on Raspberry pi

Hi,
I'm the guy who was taking help from you on the robinhood subreddit post and I'm currently trying to get it to run in docker on the rpi but while it creates the container, it never actually runs it; it just says exited. If I take out -d from the main command to get it to run not in the background, it gives me this error: "standard_init_linux.go:178: exec user process caused "exec format error"".
I did some research and I think this may be because the docker image is compiled for an x86 platform and the raspberry pi runs on ARM. Would this be fixed by recompiling the docker image?
Thanks for the help

You are right, it will not work on ARM. I'll create a new image based on raspbian and see how other dependencies work out. Testing may be difficult - my RPI has been offline for a while. So once/if it compiles I'll add a revision for you to try.

BTW, was the other issue with connection resolved?

The connection issue was not resolved, did you ever end up trying to make an arm image?

Converting it to arm is possible, however pytables are not very well supported on arm at the moment. So it may be easier just to create a branch based on pickle or csv. Will try to look at it some point - somewhat busy now.

Not going to happen. Closing now.


exclude_glob doesn't respect ** operator

Context
One of the more useful tools in glob is being able to use the ** operator to match patterns at any point in the tree; however, that requires the recursive flag to be turned on in the glob.glob function: https://docs.python.org/3.9/library/glob.html#glob.glob
It appears that that has not been used:
https://github.com/zappa/Zappa/blob/f2f03ba8b58c9e2bdbbff7b5e8c905e3a8c08021/zappa/core.py#L638
and
https://github.com/zappa/Zappa/blob/f2f03ba8b58c9e2bdbbff7b5e8c905e3a8c08021/zappa/core.py#L770
However, the ** operator is used in the example in the docs:
https://github.com/zappa/Zappa/blame/f2f03ba8b58c9e2bdbbff7b5e8c905e3a8c08021/README.md#L951
Expected Behavior
An exclude_glob entry with a **, e.g. "**/__pycache__" should recurse through the directory tree to identify and eliminate matching paths
Actual Behavior
** operators are ignored by glob
Possible Fix
Add the recursive=True argument to each of the places where exclude_glob paths are used
Steps to Reproduce

Identify a directory common to multiple paths in the project
Add a matching glob path to exclude_glob
Run zappa package
Observe that the paths have not been removed from the packaged project

This is still relevant, I am trying to find time to update the PR


#19

Correct the issue 19

Coverage decreased (-0.3%) to 31.12% when pulling a4adca1586240be3d33b08af93962cacf489f2b2 on Hamlix:#19 into b94f7f19b3c8aea9f53fa0166eac436d0d16534d on Bouquet2:develop.


Update Joeie PPP

Codecov Report

Merging #346 (3af69ba) into master (c8ff2b4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #346   +/-   ##
=========================================
  Coverage     71.13%   71.13%
  Complexity      586      586
=========================================
  Files            89       89
  Lines          1864     1864
  Branches        239      239
=========================================
  Hits           1326     1326
  Misses          450      450
  Partials         88       88

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ff2b4...3af69ba. Read the comment docs.


Address API to to be completed

/address/:hash
/address/:hash/transactions

after a bit of research, I feel what we can do is that we can remove the /address/:hash/transactions and add the transactions in the /address/:hash itself.

Please review https://github.com/Electra-project/electra-api/pull/8


Package vulnerability warnings

These dependencies in package.json
"dependencies": {
    "blueimp-file-upload": "~9.22.1",
    "handlebars": "~4.0.0",
    "jquery": ">=3.0.0",

A npm audit raises a warning for jquery under jquery-sortable:
https://www.npmjs.com/advisories/328
GitHub warns about blueimp-file-upload:
https://nvd.nist.gov/vuln/detail/CVE-2018-9206
Thank you!

The issue with blueimp-file-upload seems to be about backend .php code example. It's not really a part of JS library we're all using. Not unless you've copied the example.
As for jquery-sortable, it is a problem. It is updated to require jQuery 3, but don't seem to have a release. here's the PR https://github.com/johnny/jquery-sortable/pull/253

Thank you for looking into it. For now, I am using the below to get quiet the warnings:
blueimp-file-upload": "^9.12.6
jquery-sortable": "^0.9.13

I will watch for your update when sortable is updated.
Terrific library btw and I especially appreciate the oEmbed option.

Not my lib, just wondered in while trying to fix the warnings on my project :D
Yeah, great lib! Image uploading is super easy.


TLS Cert should be a kubernetes secret

Describe the bug
TLS cert should be in a kube secret
Expected behavior
TLS cert is currently in a config map, should be a kubernetes secret.
To Reproduce
Steps to reproduce the behavior.
Knative release version
Additional context
Add any other context about the problem here such as proposed priority

assign @juliafriedman8

@juliafriedman8 will complete the work to change the K8 Secret into a kubernetes.io/tls type (adding to @beemarie's PR)

/reopen

@juliafriedman8 please also make the updates for TLS cert secret in https://github.com/knative-sandbox/eventing-redis/blob/main/sink/config/config-tls.yaml too


Make zero on conditions be falsy

This is needed to fix an unintentional divergence between templates
rendered in ruby and in javascript.
This should fix #38

Hey @ClaytonPassmore , I finished the PR to fix that inconsistency with Handlebars.js
Please let me know if there is anything you all want me to change 👍


Desktop PWA refactor

Desktop PWA refactor

Whoops!
There were 12 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
app.yaml - 'app.yaml' was changed, was that intentional?
src/content/en/fundamentals/app-install-banners/_a2hs-criteria.html#L62 - Consider adding a "was this page helpful?" widget to your page: https://developers.google.com/web/resources/widgets#helpful
src/content/en/fundamentals/app-install-banners/index.md#L143 - Common typo found: 'omnibox' Should it be 'address bar'? See: https://developers.google.com/style/word-list#omnibox
src/content/en/progressive-web-apps/desktop.md#L152 - Common typo found: 'Homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/progressive-web-apps/desktop.md#L31 - Line must be at most 100 characters
src/content/en/shows/http203/podcast/io-chats-ben-dion.md#L48 - Consider adding a "was this page helpful?" widget to your page: https://developers.google.com/web/resources/widgets#helpful
src/content/en/shows/http203/podcast/io-chats-ben-dion.md#L22 - Common typo found: 'Ajax' Should it be 'AJAX'? See: https://developers.google.com/style/word-list#ajax
src/content/en/shows/http203/podcast/io-chats-ben-dion.md#L22 - Common typo found: 'ajax' Should it be 'AJAX'? See: https://developers.google.com/style/word-list#ajax
src/content/en/shows/http203/podcast/io-chats-ben-dion.md#L22 - Common typo found: 'ajax' Should it be 'AJAX'? See: https://developers.google.com/style/word-list#ajax
src/content/en/updates/2018/05/nic67.md#L205 - Consider adding a "was this page helpful?" widget to your page: https://developers.google.com/web/resources/widgets#helpful
src/content/en/updates/2018/05/nic67.md#L8 - Common typo found: 'chrome' Should it be 'Chrome'?
src/content/en/updates/2018/05/nic67.md#L42 - Line must be at most 100 characters

Whoops!
There were 12 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
app.yaml - 'app.yaml' was changed, was that intentional?
src/content/en/fundamentals/app-install-banners/_a2hs-criteria.html#L62 - Consider adding a "was this page helpful?" widget to your page: https://developers.google.com/web/resources/widgets#helpful
src/content/en/fundamentals/app-install-banners/index.md#L143 - Common typo found: 'omnibox' Should it be 'address bar'? See: https://developers.google.com/style/word-list#omnibox
src/content/en/progressive-web-apps/desktop.md#L152 - Common typo found: 'Homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/progressive-web-apps/desktop.md#L31 - Line must be at most 100 characters
src/content/en/shows/http203/podcast/io-chats-ben-dion.md#L48 - Consider adding a "was this page helpful?" widget to your page: https://developers.google.com/web/resources/widgets#helpful
src/content/en/shows/http203/podcast/io-chats-ben-dion.md#L22 - Common typo found: 'Ajax' Should it be 'AJAX'? See: https://developers.google.com/style/word-list#ajax
src/content/en/shows/http203/podcast/io-chats-ben-dion.md#L22 - Common typo found: 'ajax' Should it be 'AJAX'? See: https://developers.google.com/style/word-list#ajax
src/content/en/shows/http203/podcast/io-chats-ben-dion.md#L22 - Common typo found: 'ajax' Should it be 'AJAX'? See: https://developers.google.com/style/word-list#ajax
src/content/en/updates/2018/05/nic67.md#L205 - Consider adding a "was this page helpful?" widget to your page: https://developers.google.com/web/resources/widgets#helpful
src/content/en/updates/2018/05/nic67.md#L8 - Common typo found: 'chrome' Should it be 'Chrome'?
src/content/en/updates/2018/05/nic67.md#L42 - Line must be at most 100 characters

:tada: This has been pushed live to https://developers.google.com/web/


Update ACA templates to support MI with ACR_PULL role

Update our aca templates to use managed identity instead of registry secret
Need to assign acr_pull role to the containerApps system MI.

Completed


Switch to git submodules for deps, improve build scripts

This PR adds binjgb and rgbds as submodules, so that these dependencies are always cloned fresh at the same commit.
It augments the binjgb build script to automatically detect and use a local installation of emscripten.
It also adds a new script to serve the site locally.
Todo:

[x] decouple hardware.inc.js generation from serving
[x] add top level build script
[x] figure out why binjgb doesn't have the functions emulator.js is relying on

I'm just wondering if it's worth to wrap all these build scripts in a Makefile or just do the move to the bundler first ?

Is the top-level ./build.sh not sufficient? Happy to add a Makefile if you want.


Add ability to skip extensive health check for non-GETs

I don’t think we want this.

A better solution is to use HTTP/2, which doesn’t need such hacks!

Thanks @swankjesse, I'll see if I can use http/2 instead!


Remove step from Bears pipeline

The removed step had been used to commit Nopol info, but we don't need it anymore.

And didn't you want to make the inversion between the two last steps?


Added ignoring of query-to-query interference before postprocessing

@DaloroAT check my responses, please ^

Hello,
Thank you for this grate framework!
I am study oml examples and find problem
with import "from oml.models.siamese import ConcatSiamese" which is not working in https://open-metric-learning.readthedocs.io/en/latest/examples/python.html
Postprocessing example.
Is it because there is another way of siamese realization in your framework?

@yurikobyzev thank you for using OML!
Based on the link you provided I see another code which imports the model:
from oml.models.meta.siamese import ConcatSiamese (this one is the newest one).
I also recommend you to update the library to the last version.
PS. I'm a bit confused why you've decided to raise this problem here, in the closed issue. Don't hesitate to create a new one in the next time.


[test] Mark long collection tests as such

The FlattenCollection.swift.gyb and LazyFilterCollection.swift.gyb tests are taking 1000+ seconds to execute, even with optimizations. It should be possible to shorten these, but meanwhile, mark them as long tests to speed up regular testing.
rdar://problem/52872766
rdar://problem/52873170

@swift-ci test


Braulio balanza

Hey, I just made a Pull Request!
Fetches website using useInterval() until audit is completed or failed. Implements  #522
:heavy_check_mark: Checklist

[x] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

WIP, need to update tests to account for the additional components

Thanks! Could you update the PR title? Also added @fastfrwrd as reviewer since he wrote the original version of this plugin.

There are a couple of things.

It would be cool to have a transition CSS effect whenever the audit is re-fetched. I was trying to use <Fade> from material UI, but the AuditRow is not re-rendering when the states are updated, only the children re-render.
I would also like to fix some of the yarn test warnings, specially an error relating to an update to AuditList inside a test was not wrapped in act(...).
Would also like to refactor as @fastfrwrd 's initial suggestion to a flux architecture

Thank you @freben for your review! Just fixed the issues you pointed out.


The async component cannot SSR in a named slot

Version
v2.10.2
Reproduction link
https://github.com/klwfwdk/nuxt_async_issue
Steps to reproduce

clone the repositories
2.yarn install and start it by yarn dev or nom run dev
3.curl http://localhost:3000

What is expected ?
the component import through "() => import('......')" can be SSR
What is actually happening?
This component does not appear in the results returned by SSR.
This component is rendered in the browser by javascript
Additional comments?
in the reproduction , I imported three identical components except for the text through different ways. The last two components are import as async components.
the container components has 3 slots, the first two are named slots , the last one is default sold.
when I put three components into 3 sorts. the async component with default slots and the sync component with named slots are rendered and returned by the server. But the async with named slot does not appear in the result of the server rendering.
In production mode(build and start),the first return is same as dev mode. but the fallowing return include the async component with named slot.

This bug report is available on Nuxt community (#c9950)

The latest version does not resolve the issue

see #6844


Access to dataset

Thank you for the valuable study in Super-Resolution for the Sentinel-5P, which is highly relevant to my current project.
I am a postdoctoral researcher at Orleans University, focusing on developing super-resolution techniques for analyzing satellite images to study atmospheric pollution.
I am interested in accessing the data used for your study or any insights you can share regarding its availability.

Hi, Hyamomar! We appreciate your interest in our study. If you could provide me with your email, I would be pleased to share the employed data with you.

Thank you for your prompt response!
I appreciate your willingness to share the data. You can reach me at<EMAIL_ADDRESS>Looking forward to receiving the data and further collaboration.

I am a postgraduate student studying at Dalian Maritime University, focusing on super-resolution techniques.
I also want to access the data in the paper.Here is my email<EMAIL_ADDRESS>I would be very grateful if I could get your data.


3 Possible Essential Features for model.summary()

System information.
TensorFlow version (you are using): 2.4.1
Are you willing to contribute it (Yes/No): No

Describe the feature and the current behavior/state.
Total 3 Feature Request, illustrated below.
[Feature Request 1]: Add Model Memory Usage
Many times it's needed to know about the consumed size of GPU memory for DL models to avoid potential out-of-memory errors either at the beginning of training or in the middle.
So in the model. summary, (we think) it would be better to have such functionalities that would give a rough estimation of memory usage by the DL model.
We've found a nice solution from @ZFTurbo on here, that addresses such a request. And I think it would be nice to have such a mechanism inside model.summary(memory_usage_info = True / False). Here is the starting gist for the contributor.
[Feature Request 2]: Layer Range to Display Model Summary
Let's say, we want to print the summary of the following model and are interested to observe the information of trainable and non-trainable parameter counts only, maybe we simply want to print the model summary within a specific range (like); in that case, it's not intuitive to get such LONG output.
from tensorflow.keras import Input, Model, Sequential
from tensorflow.keras import layers

input = Input((224, 224, 3))
base =  keras.applications.MobileNetV3Small(weights=None,
                                             include_top = False,
                                             input_tensor = input)
features     = layers.GlobalAveragePooling2D() (base.output)
classifier   = layers.Dense(10, activation="sigmoid")(features)
model        = Model(base.input, classifier)
model.summary()
# lots of layer gets print
# ....

Instead, a new parameters can be introduced such as model.summary(layer_range=['layer_a', 'layer_z']) to print sub-graph (like we have now for plot_model). Also, a parameter that only also .summary function to print the following output only:
# No Long Layer Prints ...
Total params: 1,540,218
Trainable params: 1,528,106
Non-trainable params: 12,112

It becomes a bit painful if we need to print the model summary more than one time and because of the long layer print, we have to scroll for a while which is inconvenient. At the time of transfer learning where we freeze/unfreeze layers and quickly check the parameter counts, the painful situation becomes more visible.
[Feature Request 3]: Print Nested Model / Layers It has been addressed. HERE https://github.com/keras-team/keras/issues/15250

details of feature request 3

Let's say, we've defined a model as follows
from tensorflow import keras
from tensorflow.keras import layers
from tensorflow.keras.layers.experimental import preprocessing

model = keras.Sequential(
    [
        keras.applications.MobileNetV3Small(
            input_shape=(224, 224, 3),
            include_top=False,
            weights="imagenet"
            ),
        layers.GlobalAveragePooling2D(),
        layers.Dense(10, activation="sigmoid"),
    ]
)

If we print the model summary, we will get
model.summary()
Model: "sequential_6"
_________________________________________________________________
Layer (type)                 Output Shape              Param #
===============================================
MobilenetV3small (Functional (None, 1, 1, 1024)        1529968
_________________________________________________________________
global_average_pooling2d_13  (None, 1024)              0
_________________________________________________________________
dense_16 (Dense)             (None, 10)                10250
=============================================
Total params: 1,540,218
Trainable params: 1,528,106
Non-trainable params: 12,112

The problem here is that the MobilenNet model becomes nested and acts as a single layer. Regarding this, a question on SO had been asked and there is some workaround to overcome this issue. How, instead of printing the model summary, if we want to plot the model, we can use expand_nested=True to plot the whole model including that base model.

Will this change the current api? How?
Yes, It will increase the strength of the model utility functions.
Who will benefit from this feature?
DL researchers or engineers who use keras.
Contributing

Do you want to contribute a PR? (yes/no): no (but happy to share a starter for any contributor).
If yes, please read this page for instructions
Briefly describe your candidate solution(if contributing):

I am implementing the expand_nested in the model.summary(). I will make a PR when I will be done!

I have made the changes. I have followed the Contributing guidelines. But I want to visualize the changes by myself. How can I do that?
I have made the changes but as obvious I cannot import keras to run my code. How can I locally check that?

In feature request 2, I think it will be better not to make it separate and not with model.summary().

I can do feature requests #1 and #2. I will make a PR when I finish.

Hi, i was looking for an easy contribution just to start with keras and i found this issue.
As i can see, feature 1 and 3 have been already implemented so i decided to work on the 2nd one, taking main inspiration from this  similar issue that has been already solved.
I'm happy to hear any suggestion, i'll post my PR as soon as possible!

Ok, my merge request has been merged in https://github.com/keras-team/keras/commit/953d13bd1f5f149848daab3b54065b1ddcccd99e so also the second feature request has been fulfilled.
Thanks all!

I can work on the first feature request (the last to be completed) 👌  I'll create an issue soon to track progress and discussions, and create the PR when ready

@aaossa
As you're working, please keep the following cases in your test.

test_sequential and functional model (usualy you'll select them.)
test_sub-class model
test_hub.KerasLayer
test_huggingface.vision_model

For example, if I build keras model as follows, will it campute layer-wise as it should!
model = keras.Sequential(
    [
        keras.layers.InputLayer(input_shape=INP_SIZE+(3,)),
        hub.KerasLayer(
            model_url,
            input_shape=INP_SIZE+(3,),
            trainable=True,
            dtype=tf.float32,
            load_options=load_locally
        ),
    ]
)

You can use the starter script I shared above. If you run it, you will get
gbytes = get_model_memory_usage(batch_size=32, model=cnn_model, verbose=1)
print('Approximate Required GPU-RAN {} GB'.format(gbytes))

Memory for input_1  layer in MB is: 0.75
Memory for rescaling  layer in MB is: 0.75
Memory for normalization  layer in MB is: 0.75
Memory for stem_conv_pad  layer in MB is: 0.7529325485229492
....
Memory for global_average_pooling2d  layer in MB is: 0.001220703125
Memory for predictions  layer in MB is: 9.5367431640625e-07
Approximate Required GPU-RAN 15.589 GB

Now to add it in summary method, It might be better to have the above information as follows.
_________________________________________________________________
 Layer (type)                Output Shape              Param #    # Memory Usage
=================================================================
 input_1 (InputLayer)        [(None, 784)]             0          (in MB)

 dense (Dense)               (None, 64)                50240      (in MB)

 dense_1 (Dense)             (None, 64)                4160       (in MB)

 dense_2 (Dense)             (None, 10)                650        (in MB)

=================================================================
Total params: 55,050
Trainable params: 55,050
Approximate Required GPU-RAN [] GB
Non-trainable params: 0
_________________________________________________________________


JsonPatchDocument: incorrect method names in code sample

Methods AppendAddOp and AppendRemoveOp are actually called AppendAdd and AppendRemove in the Azure SDK.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9e97b4d5-7efe-4f5f-0b83-c67de8c36d10
Version Independent ID: d64704f7-0e1b-eb34-46e7-0bca3ab707fd
Content: Manage digital twins - Azure Digital Twins
Content Source: articles/digital-twins/how-to-manage-twin.md
Service: digital-twins
GitHub Login: @baanders
Microsoft Alias: baanders

@algattik
Thanks for your feedback! We will investigate and update as appropriate.

Hello @algattik thanks for the feedback!
I have assigned the issue to the content author for further review.

Thank you @algattik, I have updated the method names in digital twins code sample PR #10.
Since the fix has been merged, I'll now close this issue.
#please-close


Create a new object for visiting unvisited directories

instead of trying to reset the current object.
This should avoid further bugs in that area.

@bot-gradle test QFL

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


The collision resistance of TxID not conform sha256‘s but confirm  getRandomNonce()

I look into the function of generate txid in protoutil/proputils.go
Although it use sha256()function to compute txid, the collision resistance is not the same as sha256 but as function getRandomNonce(). A possible solution to this problem may be add unique transaction information into the compute of txid, which can improve the collision resistance

@adecaro What do you think? Is getRandomNonce() good enough?

Hi @denyeart and @lluckydog,
Very good point. The key measure here is the entropy of the message that we hash.
So, fixed the creator (that has at least 64 bits of entropy), the nonce brings in 192 bits of entropy (24 bytes), under the assumption that the PRG is working properly. I think we are good enough here. The source has at least 256 bits of entropy.
We can certainly increase it and even move to SHA3-512 for better quantum resistance.

@adecaro Thanks for your answer, it really help me understand this point. The point I want to say not is the hash function isn't good enough, but it not help improve resistance, so I got a little confused at first. I didn't think about the PRG can improve this think, which, to my point, is also good enough.


fix: 非私有云同步region name

这个 PR 实现什么功能/修复什么问题:
非私有云同步region name
是否需要 backport 到之前的 release 分支:

release/2.12

/area region
/cc @zexi

Codecov Report

Merging #5919 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #5919   +/-   ##
=======================================
  Coverage    6.94%    6.94%
=======================================
  Files         641      641
  Lines      110004   110006    +2
=======================================
+ Hits         7640     7642    +2
- Misses     101777   101778    +1
+ Partials      587      586    -1

Flag
Coverage Δ

#aFlag
6.94% <0.00%> (+<0.01%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/compute/models/cloudregions.go
1.63% <0.00%> (-0.01%)
:arrow_down:

pkg/appsrv/response.go
70.58% <0.00%> (+2.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087a2a1...86087b9. Read the comment docs.


build-script: Invoke Foundation macros build separately

This adds a separate CMake invocation to build Foundation macros for each toolchain host. Additionally, it updates the Foundation build to build using the Foundation macros build for the local host so that when cross-compiling for a separate host the macro library builds for the destination host but Foundation uses the local host's macro library for building itself.

https://github.com/apple/swift-foundation/pull/714
@swift-ci please smoke test

https://github.com/apple/swift-foundation/pull/714
@swift-ci please build toolchain Linux platform

https://github.com/apple/swift-foundation/pull/714
@swift-ci please smoke test

https://github.com/apple/swift-foundation/pull/714
@swift-ci please build toolchain Linux platform

I've confirmed in the build logs that libFoundationMacros.so is successfully loaded as part of the FoundationEssentials build and it is also correctly installed into the produced toolchain


Upgrade dompurify or fix the sanitize import

Error: Build failed with 1 error:
node_modules/super-react-gist/es/index.js:2:9: ERROR: No matching export in "node_modules/dompurify/dist/purify.es.js" for import "sanitize"

Thanks for the contribution again @chandlervdw. The fix is included in v1.1.1.


Trouble with multiple functions on drag and IE

        {{item.Name}}

This works on every browser except IE, where the directive simply doesn't work  unless dnd-moved is only set to group.list.splice($index, 1);.
I've of course tried to wrap the splice and my function in another function and then set only that function to dnd-moved but on IE it would never call that function.

Do you also not see the "Item moved" console output in this demo?
http://marceljuenemann.github.io/angular-drag-and-drop-lists/demo/#/advanced