Fixes #34: Use node-gyp 3.0.0 to install headers.

Also improved build rules to more similarily match the
way that node-gyp's cli invokes the node-gyp library and
improves logging when failures occur.

Do not merge.

:+1: Awesome!

Should be good to merge, appears to be working everywhere:
http://puu.sh/kkaVV.png

@brett19 You basically just did what I planned to do this week ;) I'll wait for @mafintosh to respond before merging.
@mafintosh Should this be a new patch?

@ralphtheninja I spent Friday afternoon and all day Monday trying to resolve various issues with prebuild running on my builders.  This ended up being by far the simplest way to fix it all in one swoop :)

@brett19 Aye, I think that's mainly due to node-gyp using smaller header tarballs when available.

@brett19 On a side note. Which windows targets are you building your modules on?

The matrix above is for VS2015.  Though I was using VS2012 and VS2013 before (it was just unnecessary, and had issues with Node.js 4.0.0's v8).

Great job everyone. @ralphtheninja yea we can patch release this

On a side note: I wonder if any of the remaining code inside prebuild now was written by me now hehe

@mafintosh lol well it's just code and it's still your idea, which is the important thing imo :)

@mafintosh Haha.  As an aside as well, we should probably consider having a small helper library which wraps the logic of invoking node-gyp with various parameters.  I might do that after this PR if it gets merged.

@brett19 I'm testing your branch on leveldown and I get some issues with<EMAIL_ADDRESS>

@brett19 If you want to reproduce, clone leveldown and execute prebuild (obviously npm link your master first) inside leveldown folder

I've seen this before, its related to the include/node/ vs src/ thing.  getAbi has no check on retrying and retries indefinitely, I fixed it originally by introducing the switch between the two directories, but we should probably add a better check there so it doesnt loop out of control.  Can you paste me your ls of $HOME/.node-gyp/?

Downloading headers only using node-gyp seems to work fine:

I'll repro locally and resolve.  One moment :)

Aah. Missing include folder for that version?

I suspect the pathing might be different (ie: include/iojs/ rather than include/node).

Hmm nope, it's something else.  Maybe there is use for a separate module to extract the abi version which could be used for any target, e.g. electron

Resolved.  It was just getting confused by the iojs- prefix.
P.S. I am avoiding doing specific version validation, favouring path checking instead as it is more likely to hold up against weird version identifiers (like prerelease versions).

P.S. I am avoiding doing specific version validation, favouring path checking instead as it is more likely to hold up against weird version identifiers (like prerelease versions).

+1

I can confirm all leveldown versions built successfully. Time to merge and release! :)

2.5.3
Thanks for awesome work @brett19 !

Don't release yet if you didn't already.

Looks like I was too late, but see: https://github.com/mafintosh/prebuild/pull/40


Improved readme and function extension specification syntax improvements

Improved readme along with some breaking changes to improve definition and testing of function extensions.

I'm unsure about the following though:
Global variables for the function extension definition have been created in the process.
They were singletons before, but this is no longer possible as the functions are now instances.
Are global variables fine like this, or what would be better practice?

I'm unsure about the following though: Global variables for the function extension definition have been created in the process. They were singletons before, but this is no longer possible as the functions are now instances. Are global variables fine like this, or what would be better practice?

You mean as part of the object, or did I overlook something?

Fixed in commit a918d6b1d0574ae9c69bfecbc167b72632b0ed4d

Readme looks good!
One minor thing: Use the functional Napier interface (e.g Napier.e{} (curly braces!)), as it completely omits all logging invocations for disabled log levels.

Fixed in commit a918d6b1d0574ae9c69bfecbc167b72632b0ed4d


feat: include confusionmatrix to metrics

Is your feature request related to a problem? Please describe.
N.A.
Describe the solution you'd like
I think the builtin metric visualization would benefit from a confusion matrix.
https://en.wikipedia.org/wiki/Confusion_matrix
Describe alternatives you've considered
N.A.
Additional context
from argilla.metrics.text_classification
from argilla.metrics.token_classification

closing in favor of https://github.com/argilla-io/argilla/issues/4034
@cceyda , any input would be very welcome in the other issue :)


Project Manager is not keyboard friendly

Ubuntu 16.10 - Godot version: tested on 2.1.2 stable but may affect all builds
Issue description:
Can't use keyboard on the Project Manager using all the options.
Keyboard shortcuts and common navigation (using arrows and tabs) is expected to work.
Steps to reproduce:
Try to use the project manager with keyboard to run, edit, import and create projects.

In latest master https://github.com/godotengine/godot/commit/550f436f8fbea86984a845c821270fba78189143 , tab and arrow keys work BUT seems to be in bad shape.
Issues:
You need to first click on search or similar before any keys start working(Just hovering isn't enough).
Also, after pressing tab a few times, you get focus on the small "open project folder" buttons. Then holding arrow keys highlights projects, while pressing arrow keys or tab key highlights the "open project folder" buttons. It is buggy. Sometimes pressing keys once shift focus to next button, sometimes twice.
It would be nice if someone could confirm this and list out the needed changes.

Would it make sense to select and focus on the first project automatically (as long as there is at least one project in the list)?

Focus on the first project or "new project" button if the list is empty.

@Calinou any plans for making a PR from 2897818? I could have sworn that Godot 3.1 autofocused the first project, but in Godot 3.2 it focuses the button column on the right.

Yup, just rebuilt 3.1 and confirmed, it did focus the first project, so there was some regression in 3.2.

@rcorre In the master branch, the search field is now automatically focused so you can press Enter after searching for anything. This hasn't been cherry-picked to the 3.2 branch yet though.

@Calinou ah, so it does! That's pretty nice. The up/down arrows still take you down the buttons on the side rather than the project list though ... is that intentional?

@rcorre No, but I haven't looked into solving this yet. If we fix this, we need to find alternative shortcuts for individual actions so they can all be performed using the keyboard exclusively.
For starters, maybe we could make Ctrl + Enter run a project instead of editing it?

ctrl+enter to edit the project sounds better, and check the neighbour of the file selection dialog because it keeps scrolling on the project list if you go out of the file list with arrow keys.

@eon-s When you double-click a project, it will be edited. I'd rather have the "simplest" keyboard action be consistent with that. Running a project directly is typically a secondary action. Most people open the project manager to edit projects :slightly_smiling_face:

@Calinou yes, you are right, I have read it wrong :+1:

The last time I checked arrow keys work on both project list and buttons at the same time. For example, on pressing down arrow key, not only listed 2nd project but also 2nd button of the right side list is highlighted.

Duplicate of https://github.com/godotengine/godot-proposals/issues/532?

Most likely yes, since this is older this should probably be closed in favor of the proposal.

Closing in favor of https://github.com/godotengine/godot-proposals/issues/532.


Stars Comment

What issue is this addressing?

What type of issue is this addressing?

What this PR does | solves

Start Comment added If you want me to add it somewhere else, write me.

Do you want anything else like this or anything else you want me to add to those that have no comments?

No comments are fine so far.


Where is the train_voc.py?

Thanks for the sharing of implementation of retinanet, but where is the training code on voc dataset? I didn't find the code...

I also want to know


chore: log sign-in link when in development

Introduction :pencil2:
Automatically log the Portal sign-in link when in development to easily allow sign-in when emails are not actually sent.

Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6da84ce) 21.88% compared to head (7e1d6ef) 36.90%.
Report is 155 commits behind head on main.

Files
Patch %
Lines

...1/controllers/tfm/deal/tfm-get-deals.controller.js
0.00%
3 Missing :warning:

...lers/tfm/facility/tfm-get-facilities.controller.js
0.00%
1 Missing and 1 partial :warning:

dtfs-central-api/src/drivers/db-client.js
0.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2591       +/-   ##
===========================================
+ Coverage   21.88%   36.90%   +15.02%
===========================================
  Files        1132      636      -496
  Lines       27048    16191    -10857
  Branches     4447     3110     -1337
===========================================
+ Hits         5920     5976       +56
+ Misses      18403     8489     -9914
+ Partials     2725     1726      -999

Flag
Coverage Δ

api-test
∅ <ø> (∅)

ui-test
65.63% <ø> (+0.49%)
:arrow_up:

unit-test
8.09% <0.00%> (+4.30%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Does the score effect the red team bot?

I have one question.
while not correct_password and attempt < 3:
    # Step 1. AI Red Team generate automatic prompt
    red_team_response = red_teamer_bot.complete_chat_user(message=gandalf_text_response)
    print(f"Attempt #{attempt}")
    print("Sending the following to Gandalf:")
    print(red_team_response)
    print()

    # Step 2. Send jailbreak idea to Gandalf
    gandalf_response = gandalf_bot.complete_text(text=red_team_response)
    gandalf_text_response = gandalf_response.completion
    print("Response from Gandalf:")
    print(gandalf_text_response)
    print()

    # Step 3. Score the response
    score = gandalf_password_scorer.score_text(text=gandalf_text_response)

    # Step 4. Ask if we should continue
    print(f"Score: {score.score_value}")
    if score.score_value:
        correct_password = gandalf_text_response
        print(f"Found the correct password in {attempt + 1} attempts!\n")
        break

    attempt += 1

It seems that there is no mechanism for the calculated score to effect the red team bot.

But based on the image above, the scoring engine feedback is effecting the prompt generated.
Please let me know if I missed something.
Thank you.

Hi @ysy970923 , thanks for submitting this question! You're right in that the feedback mechanism in this example is just the response from the target LLM.
More generally, we can envision cases where the score is very much required. Let's say our target LLM generates images (which we can't pass back into the LLM directly), then we need a score (or textual feedback) to be passed back to the Red Teaming LLM. As you can see, there are different kinds of setups, but we didn't want to overcomplicate the diagram either, so it just mentions feedback from the scoring engine.
I hope that helps! Please let us know if you have further thoughts on the topic otherwise we'll close the issue within the next 7 days.

Thanks so much for the response 👍
Are there plans for adding examples for image generation?
If not can I contribute some examples for text to image models?

Yes, that's definitely relevant.
I'm not sure to what extent you already have these or are planning to work on that, but you can certainly open a PR if you already have it and we can comment there. If you're just starting out it's probably faster and simpler to write up a short outline and share (in a new issue since the original question was answered and is unrelated) so that you can get quick feedback before spending too much time on it. What do you think?

I did some work on this, so I made a pull request.
Feel free to give comments :)
Thank you


fix: safe execute git commands without sh wrapper

:wrench: Summary
Execution of shell commands with sh wrapper can bring unexpected behavior because of arguments (branch names) that can be places into a command. For example, when a branch is named "mybranch;killall" the command for getting files for the pre-push hook will look like sh -c 'git diff --name-only HEAD mybranch;killall' and it may shoot badly.
The sh wrapper is actually needed only for the files option where user can specify something like git ls-files | grep _test. So, this behavior is kept as before + one more integrity test for it.

Are strings embedded in shell commands now sanitized in the remaining case? You can use this if not https://pkg.go.dev/github.com/alessio/shellescape


feat: place __INTERRUPTS vector in .trap.rodata

This change preemptively adopts the change proposed to svd2rust to
expose the link section as a config parameter.
I split out the changes to the generator from the actual update of the generated files to make it a little easier to review, since the generated code changes are a little noisy.
It also addresses an unrelated issue I ran into with rust-analyzer (by way of vscode) in 64e16dae7f57d78b31f7dab1cb1de0eb5a896744 . Just let me know if you hate it, and I'll pop it off this PR.

Cool, it looks like https://github.com/rust-embedded/svd2rust/pull/718 got merged with no changes, so I'll just re-point this to the "official" sha and then I'm happy with this one.


Modified demos so they can be handled separately by the frost-guide

#minor#

Approved

Good work Justin :)


Bugfix: lk_max_locks default to 537000

Do you know what you do there?
https://github.com/wattson-coder/SelaCoin/commit/c938f0fdcac4d8d7cd280f199da3b7e567500de1
Why do you have increase the max_locks? This has nothing to do with "safely handle reorgs with up to 5 blocks reversed"
Check the Oracle docs:
https://docs.oracle.com/cd/E17276_01/html/api_reference/C/envset_lk_max_locks.html

yep reverted to defualt - the commit was approved as resut of an error, thank you


Test Spark 3.3.0-rc3

Why are the changes needed?

<EMAIL_ADDRESS>How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

The failed UT is caused by https://github.com/apache/spark/pull/36591

Codecov Report

Merging #2735 (b1bad7e) into master (c84ea87) will decrease coverage by 0.01%.
 Consider uploading reports for the commit 99ea2b5 to get more accurate results

@@             Coverage Diff              @@
##             master    #2735      +/-   ##
============================================
- Coverage     61.79%   61.78%   -0.02%
  Complexity      273      273
============================================
  Files           411      411
  Lines         19826    19826
  Branches       2703     2703
============================================
- Hits          12252    12249       -3
  Misses         6378     6378
- Partials       1196     1199       +3

Impacted Files
Coverage Δ

...ache/kyuubi/operation/KyuubiOperationManager.scala
83.60% <0.00%> (-1.64%)
:arrow_down:

...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala
84.27% <0.00%> (-0.63%)
:arrow_down:

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
96.64% <0.00%> (-0.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84ea87...99ea2b5. Read the comment docs.

Thanks, merging to master


What happens when network disconnects abruptly?

Hello,
Could you please explain how does the SDK behave on abrupt network disconnect?
When auto-reconnect is enabled, will the SDK be able to recover automatically as in be able to mqtt publish/subscribe/unsubscribe without connecting manually?
Will the disconnect callback be called in such abrupt network disconnect events?
Thanks

Hi @shekharhimanshu ,
On abrupt disconnect, the keep-alive ping request will fail and trigger the auto-reconnect procedure. On successful reconnect, the device will resubscribe to the topics which it had subscribed to on first connection.
The relevant keep-alive code can be found here
I'm not sure if I understand what you mean by publish/subscribe/unsubscribe. If you continue publishing on a disconnect, those publishes will fail until the device reconnects. After the auto-reconnect is successful, all MQTT operations will work as before.
And yes, the disconnect callback will be called in such cases.
You will see a delay between when the actual disconnect happens and when the callback is called/auto-reconnect process starts as the keep-alive needs to fail before it can recognize the fact that it is disconnected. The keep-alive interval can be changed in the config.json that is used by the project here.
Please keep us posted if you have any more questions.
Thanks!
Varun

Hello @vareddy
This clears most of my doubts. Thanks!

Hello,
After looking through more code, I have one more think to confirm.
During abrupt disconnect, the SDK has no idea to know the disconnect event. As a result of which, previously subscribed subscriptions will remain active. (Please correct me if I am wrong here)
Now since AWS IoT message broker does not support persistent sessions at the moment (source here), applications must connect & re-subscribe themselves. (if applications want to handle abrupt disconnect themselves and not wait for the next PING request to fail).
However, when subscribing, the code here removes active subscriptions from the subscribe request packet which means connect -> subscribe -> abrupt disconnect -> connect -> subscribe sequence will not succeed.
The workaround here is to unsubscribe before subscribing again. The unsubscribe here will have no meaning to the AWS IoT message broker and will only clean up the SDK internal state.
I wanted to confirm if this is the correct behavior?

Hi @shekharhimanshu,
That is not supposed to happen and is a bug. I think this warrants a second look at the overall subscription flow in the SDK. Maybe a central API for managing all subscriptions that the client(s) talk to? I will give this some thought and see if I have an easy solution for you while we work on this. It should be as simple as setting all subscriptions to inactive in the current flow but I don't know if that makes sense in the longer term.
Please let me know if you have further suggestions.
Rahul

Thank you for the confirmation.

I think this warrants a second look at the overall subscription flow in the SDK.

IMHO, the SDK needs to define what spec of MQTT it is following as the base specification.
Whether the one defined by AWS Iot message broker here or the standard MQTT version 3.1.1.
AWS Iot message broker says Although the AWS IoT message broker implementation is based on MQTT version 3.1.1, it deviates from the specification as follows: ....
If the SDK strictly follows AWS Iot message broker specifications, it should clean the subscriptions on each disconnect -> connect event since AWS Iot message broker does not support persistent sessions at the moment and should change the specification when AWS Iot message broker supports it.
For me, the workaround of connect -> subscribe -> abrupt disconnect -> connect -> **unsubscribe** -> subscribe works at the moment (although I don't like the unnecessary unsubscribe call) but in the long term, the SDK should have a clear specification about subscriptions management.
It might be helpful to see how other mqtt clients like Mosquitto handle these situations (given the SDK follows the standard MQTT version 3.1.1).

Hi @shekharhimanshu,
You are correct ofcourse. The SDK should be following the AWS IoT message broker implementation and not the exact MQTT v3.1.1 standard. I will make a note to go through the SDK APIs once more to ensure we are not breaking that in any other areas. Please do let me know if you find any such issues.
Thank you for the great contributions as always :)
Rahul

Clear explanation/notes about these things inside the api reference/document is highly appreciated as well.

Hi @shekharhimanshu,
v1.1.1 now takes care of subscription cleanup on disconnect.
Thanks!
Varun


fix(core): ensure stable webpack theme aliases sorting

Motivation
The comparison function provided for themes is not consistent. The resulting array order is implementation-dependent, which means it could break between Node releases (unlikely, though) or if somebody tried to run this code in a browser somehow :grimacing:
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan

The only way to test this is by not using V8:
Before:
[
  '@theme/Navbar',
  '@theme/NavbarItem',
  '@theme/NavbarItem/DefaultNavbarItem',
].sort((a, b) => a.includes(`${b}/`) ? -1 : 0)

Chrome: ['@theme/Navbar', '@theme/NavbarItem/DefaultNavbarItem', '@theme/NavbarItem']
Firefox: [ "@theme/Navbar", "@theme/NavbarItem", "@theme/NavbarItem/DefaultNavbarItem"]
After:
[
  '@theme/Navbar',
  '@theme/NavbarItem',
  '@theme/NavbarItem/DefaultNavbarItem',
].sort((a, b) => a.includes(`${b}/`) ? -1 : (b.includes(`${a}/`) ? 1 : 0))

Chrome: ['@theme/Navbar', '@theme/NavbarItem/DefaultNavbarItem', '@theme/NavbarItem']
Firefox: [ "@theme/Navbar", "@theme/NavbarItem/DefaultNavbarItem", "@theme/NavbarItem" ]
Related PRs
Current implementation introduced here: https://github.com/facebook/docusaurus/pull/5383

Also, I can't possibly envision Docusaurus being run in a runtime other than Node without going to significant lengths. So this remains largely a useful but not critical fix 😊


Clean-up

Pull Request To-Do List
Description of the changes

I have done the following to make this PR ready for review:

[x] I have updated the requirements.txt file (if appropriate)
[x] I have re-based my branch on the latest master branch
[x] I have added necessary documentation (if appropriate)
[x] I have commented my code, particularly in hard-to-understand areas

For the reviewer, make sure this PR meets these criteria before merging:

[ ] New code has comments
[ ] New code has tests (if appropriate)
[ ] New code has documentation (if appropriate)
[ ] New code has been reviewed by at least one other person

First time that all checks have passed!


Object detection with YOLOv5 and PyTorch

Article checklist
Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #4636

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

@srishilesh kindly review the tutorial now. It was one commit away before a final review.

@srishilesh I've done the requested changes

@srishilesh
Thank you for the great feedback - lets take a look at the recent changes provided.
IF any other revisions are needed - lets provide some guidance on how to get the article up to par - and CLOSE the PR. To allow the author the proper time to make any and all needed corrections.
This is a duplicate PR - if any more changes were needed (in general) we should close the PR immediately especially if its a duplicate PR (generally there are always exceptions).
cc @section-engineering-education/peer-reviewers

@srishilesh Hello, concerning the 2 index.md files, I realized I messed up with the commits. I will make the requested changes and open a new PR just to avoid git headaches. For now, I'll close this PR
cc @hectorkambow


Moving API client base class to Stratis.Bitcoin & implemented BlockStore API client

This PR can be reviewed commit by commit
This is needed to add block store client which will later be used on fed peg project
upd
Implemented client in this PR

Fixes applied


bug(FormField): appearance "outline" breaks UI

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
14
Description
If the we use the example from the https://material.angular.io/components/form-field/overview, with appearance outline. The width of the input field is set to minimum
Reproduction
Steps to reproduce:

https://material.angular.io/components/form-field/overview
Select and use the appearance outline example

Expected Behavior

Actual Behavior

Environment

Angular: 15.2.2
CDK/Material: 15.2.2
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows 11

Hi @muhammad-usman-anwar , I was unable to reproduce the behavior shown in the screenshot. Could you provide a stackblitz with a more detailed description of how to reproduce this bug?
Here's a screenshot from when I tried interacting with the appearance outline example

In case you're using Tailwind:
@layer base {
  *,
  ::before,
  ::after {
    // https://github.com/tailwindlabs/tailwindcss/discussions/9993
    // Only reason why Tailwind sets it to "solid" is so you don't have to specify border style together with "border[-x]" class.
    // That's something we can live without.
    border-style: none;
  }
}

You will have to manually add border-[style] class everywhere.

its because of tailwind

its because of tailwind

its because of tailwind


Fall back to using urandom on Linux if getrandom isn't available.

@mohatry, @saurik, this should address your concerns. Tested on Ubuntu 14.04 (kernel 3.13), with both the "__NR_getrandom not defined" and "__NR_getrandom defined but fails at runtime" code paths.

Can you check the build failures?

@tuexen Fixed; it was just that sctp_pcb.h was transitively including stdlib.h.


Multisig. Signatory selection flow. Lost wallets

Description
New approach to select signatory is shown not all wallets.
Old one:

New one:

Test data:
wallets.json
accounts.json
Steps to Reproduce

Go to multisig creation flow
Try to select as a signatory different wallets

Expected Behavior
In the list are available:

Polkadot vault, filtered by network
Wallet Connect filtered by network

Actual Behavior
On test accounts only polkadot vault are available
Environment
https://github.com/novasamatech/nova-spektr/commit/278e261c7f71889e78983c981e8bdf5c32b1fa79

Status verification: ✅


Broke warn_on_host_root

With #137 warn_on_host_root is broken
Running command
sudo podman run -it --rm --privileged -v /dev:/dev -v /var/lib/containers:/var/lib/containers -v /:/target --pid=host --security-opt label=type:unconfined_t -e RUST_LOG=trace quay.io/otuchfel/bootc:latest bash -c 'diff <(stat -f -c %i /target/sysroot) <(stat -f -c %i /proc/1/root/) --side-by-side`

On a bootc booted system
fc0400000000						      |<PHONE_NUMBER>0

On a normal system
(slightly modified to look at /target rather than /target/sysroot which is what bootc will do)
4a902cc3058b9cd6						4a902cc3058b9cd6

On FCOS
fc0400000000						      |	0

The solution would be to use the original user provided root_path for the fd passed to warn_on_host_root, rather than the modified one, as that will always match /proc/0/root's fsid (in ostree systems systemd is running with the deployment root as its root, and this is what we have mounted as /:/target)

I will wait for #905 to merge before pushing a fix, as they're surely going to conflict.


Eliminated exceptions when parameters are not supplied or invalid.

Minor tweak to the parameter and file handling if you are interested.

Thanks!


[Linux] Trackpad Gestures Pinch and Pan broken in 2D and 3D workspace (everything just Zooms)

Godot version
4.0 rc2 (and 3.5.1)
System information
Fedora 36 on a thinkpad with Trackpad
Issue description
Now I'm not entirely sure if this is even implemented, but the changelog for RC2 contained the line

Editor: Fix panning via InputEventPanGesture (notably for macOS) (GH-72884).

and it appears as the Trackpad is supposed to be able to pan and Tilt like in Blender. (It doesn't)
Mayhaps Related: #72414
Steps to reproduce
Click in the 3D Workspace, put two Fingers on the Trackpad and move them sideways

2 Finger Gesture
Expected
Actual

Slide horizontally
Pan
nothing

Slide vertically
Tilt
Zoom

Pinch
Zoom
nothing

Rotate
nothing
nothing

And for the 2D Workspace

2 Finger Gesture
Expected
Actual

Slide horizontally
Scroll left/right
Zoom  and erratically Scroll left/right

Slide vertically
Scroll up/down
Zoom and erratic Scroll up/down

Pinch
Zoom
nothing

Rotate
nothing
nothing

The erratic Scrolling in the 2D workspace can't be observed in the RC1 build or a 3.5.1 build,
and seems to be more likely when several gestures are combined and done quickly.
Minimal reproduction project
N/A

Now I'm not entirely sure if this is even implemented, but the changelog for RC2 contained the line

InputEventPanGesture and InputEventMagnifyGesture are supported only on macOS and Android.

On my acer windows 10 laptop, the 'pinch to zoom' and 'two buttons to scroll' are reversed in Godot - if I pinch to zoom it scrolls, if I try to scroll it zooms.

Is there a tracking issue to support them on windows and/or linux?

Duplicate of https://github.com/godotengine/godot/issues/13139.

The 2D editor issue is most likely due to https://github.com/godotengine/godot/issues/77212.

@Calinou  Could you please re-open this issue. It's still a problem in 4.3 beta2 and #85473 does not fix it.
I'd say this a major issue since it breaks the convention which literally every other app uses. But perhaps Linux laptop users are a very small minority and thus not prioritized...


Refresh with updated tools

Hi,
As VSTS has been renamed Azure to Azure DevOps, with the release of .NET Core 3.1 and Azure Functions v3, a small refresh of this repos was necessary:

The Cats Reviews webapp has been migrated to .NET Core 3.1
The Function App has been migrated to v3
Provisioning script is now using the "Az" commands

@arnaudmaichac thank you!


python3Packages.numpy: fix failing tests and clang 16

Description of changes
This PR fixes the failing tests on Darwin. The clang 16 fix was submitted upstream.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I think this should target staging-next (I think numpy will start to be broken there).

I also retargeted it to staging-next.


Make sure we catch early exceptions

Not sure why it's showing the local path changes, this PR should have be based on the 'local-path' branch.


Coverity 1545946: Uninitialized scalar variable in server transform plugin example

[approve ci autest]

[approve ci autest]

[approve ci autest]

Cherry-picked to v10.0.x


Flaky e2e: Shell should pass tests for services.sh (Failed 3 times in the last 30 runs. Stability: 90 %)

Master issue is #9312
Recent failures include:
====
waiting for service3 at <IP_ADDRESS>:80
wget: download timed out
ERROR: (gcloud.compute.ssh) [/usr/bin/ssh] exited with return code [1].
testing service3 VIP from container failed
namespaces/services-test-701
===
waiting for service3 at <IP_ADDRESS>:80
Test 7: Bring up another service, make sure it does not re-use IPs.
Starting service 'services-test-15187/service4' on port 80 with 3 replicas
error: could not read an encoded object from STDIN: unable to connect to a server to handle "replicationcontrollers": couldn't read version from server: Get https://<IP_ADDRESS>/version: dial tcp <IP_ADDRESS>:443: connection refused
error: no objects passed to create
error: couldn't read version from server: Get https://<IP_ADDRESS>/version: dial tcp <IP_ADDRESS>:443: connection refused
====

See also #8849.

See also #8953

I'm going to take another shot at cleaning this up.

I suspect that the part of the test that is failing is working correctly in test/e2e/services.go, and can simply be deleted from this shell-based test?

@brendanburns - are you planning to look into it today? If not, I can look into it tomorrow waw time and check whether the shell script is testing anything that is not tested by go test.

I will look into it tomorrow waw time.

@quinton-hoole
FYI: after merging #10819 the test already passed 10 times as part of gce-flaky. I will leave it there for one more day and move it to stable tomorrow if there won't be any failures until then.

There are still 2 kind of failures that are happening:
Test 5: Remove the iptables rules, make sure they come back.
Manually removing iptables rules
Verifying the VIPs from the host
waiting for service3 at <IP_ADDRESS>:80
Verifying the VIPs from a container
waiting for service3 at <IP_ADDRESS>:80
wget: download timed out
ERROR: (gcloud.compute.ssh) [/usr/bin/ssh] exited with return code [1].

and
Test 1: Prove that the service VIP is alive.
Verifying the VIP from the host
waiting for service1 at <IP_ADDRESS>:80
waiting for service2 at <IP_ADDRESS>:80
expected 'service2-1z6tg service2-2x41m service2-l8voq', got 'service2-2x41m service2-l8voq': will try again
expected 'service2-1z6tg service2-2x41m service2-l8voq', got 'service2-2x41m service2-l8voq': will try again
expected 'service2-1z6tg service2-2x41m service2-l8voq', got 'service2-2x41m service2-l8voq': will try again
expected 'service2-1z6tg service2-2x41m service2-l8voq', got 'service2-2x41m service2-l8voq': will try again
expected 'service2-1z6tg service2-2x41m service2-l8voq', got 'service2-2x41m service2-l8voq': will try again
service2: failed to verify portal from host

Hopefully - this should be fixed now. I will be monitoring the test and will move it to non-flaky suite tomorrow.

Fixed by #10989

#10989 broke e2e-gce-parallel, our parallel test run (and presumably all per-PR e2e runs). See comment there on how to fix it.

This failed again:
http://kubekins.dls.corp.google.com/job/kubernetes-e2e-gce/7545/

I think I understand the failure - in test 6 we don't wait until apiserver is really restarted, so it sometimes happen that at the begining of test 7 apiserver is still down (or at least not yet responding to request). I will prepare a fix for it.

Sorry to keep beating a dead horse, but "Shell should pass tests for services.sh" still looks flaky. After #11139 was merged it has failed two GCE E2E runs, and the 1 and only GCE soak test run after today's 2 PM deployment.
See:

job/kubernetes-e2e-gce/7575/
job/kubernetes-e2e-gce/7576/
job/kubernetes-soak-continuous-e2e/1981/

Fixed with #10127

@saad-ali - thanks for fixing it!


OCPBUGS-14824: Bump csi-driver-shared-resource-operator library-go

Bump library-go
The library-go fix openshift/library-go/pull/1541 merged we also need to bump the library-go dependency for csi drivers operators.
$ go get -u github.com/openshift/library-go
go: upgraded github.com/openshift/api v0.0.0-20230509100629-894b49f57a15 => v0.0.0-20230613151523-ba04973d3ed1
go: upgraded github.com/openshift/library-go v0.0.0-20230508110756-9b7abe2c9cbf => v0.0.0-20230626162119-954ade536d6d
go: upgraded github.com/spf13/cobra v1.6.0 => v1.6.1
$ go mod tidy && go mod vendor

/lgtm
/label docs-approved
/label px-approved

/approve


Feat/add cloud install plans

Summary
This is adding the nerdletState install plan directive field, applying it to one existing AWS install plan, and creating new install plans for AWS, GCP, and Azure leveraging it.
These install plans have been applied to the majority of AWS, GCP, and Azure quickstarts as well as updating their existing documentation links to point to documentation rather than the nerdlet opened by this install plan.

@natecanfield822 Just FYI we removed the files you edited in /docs in favor of an auto generated doc from the graphql schema. I removed that file when I merged in main, so this should be good to go!


Skip refresh if value is null

If the prefix does not exist in consul, the value in the response
object will be null. In this case, do not publish a refresh event.
I'm told to say that SAS has a signed Committers Confidentiality
Agreement as well.

@dahamr Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


Enhance the builtin module types

https://nodejs.org/docs/latest-v16.x/api/modules.html#modules_the_module_object
https://nodejs.org/docs/latest-v16.x/api/module.html#module_the_module_object

Add the builtin node "module" module.
Fix the builtin CommonJS module variable.  builtinModules is not and
was never on this type; it's on the added "module" module.  Add
missing documented properties.

@gkz do you need a rebase or?

@gkz do you need a rebase or?

I'll merge this in next week.

I just mean that I saw there are merge conflicts now, and would you like me to fix them?

I just mean that I saw there are merge conflicts now, and would you like me to fix them?

It'll be easier for me to do, don't worry about it


bug: maths functions incorrect for nodeset args

Various maths functions return the wrong results when supplied with nodeset arguments, specifically:

exp()
exp10()
log()
log10()
sqrt()

PR with failing test (1st commit), and then fix (2nd commit) at #107


Paranthesis checker in C/C++

Creating a program to validate the paranthesis in a equation
It will be done by using stack data structure
I will implement it in C language
"GSSOC'21 participant, please assign it to me"

Hello @rudrakshi99 @nakul-19 @plazzy99 @tarun26091999 .
I am  a GSSoC21 participant.
I would like to contribute in this issue.
please assign this issue to me.

Hi, @rudrakshi99 @nakul-19 @plazzy99 @tarun26091999
I am a GSSoC'21 Participant,
Its my request that you please assign this issue to me.
I ensure you efficient and neat code.

Hi i am a beginner , can i contribute on this ? can you guide me?

I would like to work on this issue in Java. Kindly assign it to me.

I would like to work on this issue in Java. Kindly assign it to me.

i have made a PR on this issue please check it..


Add single colour version

Solid black version of the logo in SVG. Bubbles have been subtracted from the liquid path for transparency. Opaque and transparent PNGs provided. I apologize for the mess of the previous PR.

Excellent work! I really like this. @cobyism, would you mind giving a :+1: if you like it?

:+1: Yeah, this is hot. My only feedback is that I'm slightly distracted by the tail of the last L overlapping the test tube's outline. In the colour versions there's depth, so the overlap isn't an issue, but for this single colour one I think the test tube outline would be better unbreached. Do you both agree?

Definitely agree. I didn't want to change your design in any way but to make it solid so I left that alone. Another possible improvement would be to shift the test tube to the right a little. The stroke consumed what little padding was there in the original logo and now the word and tube are a bit close.

Cool, yeah I wouldn't worry about not modifying the original. Those tweaks to make it work better for this treatment would definitely be worth trying. Have a play and see what looks most "right" 😊
Also, don't be afraid to suggest changes to the colour version too, if you have suggestions!

Moving the test tube tackles both of those issues. Thoughts?

:ok_hand: :sparkles: :tropical_fish:

Awesome. I'll update the PR. Also, I'm just going to leave this here while I'm at it...

:heart_eyes_cat: I wondered if a two-colour variation was going to come up in this discussion. Fancy adding the files for that version too? :yum:

Sure thing. Do you want the two-colour in a separate SVG or add it as a separate layer with the black?

I think just a separate layer is fine. As long as it’s easy for whoever to export the right files without having to tweak too much that’s what matters. :+1:

Any further changes required for this or is everyone happy with it?

@stefenfriesen Would you add a mention of it in the README? You can add your own section, like Black and White Logo (With Red Test-Tube Variant) or Single-Color Version.

These are so awesome. :sparkles: :heart_eyes_cat: :sparkles:

Made the changes. Also corrected some grammar and typos. Couldn't help myself. Might want to double check it for accuracy.

Excellent, excellent, thank you @stefenfriesen!

Boom, merged.

Thanks, @parkr! Pleasure working with you guys :)


Any IDE support?

Tried at WebStorm. It recognizes only simple type descriptions like:
function A(b: String): Number {}

No support for type = and union types.

@GulinSS did you set language to Flow? Webstorm's flow support is getting redone, it works reasonably well at the moment but is going to get a lot better. Here is the issue - https://youtrack.jetbrains.com/issue/WEB-14254
Alternatively Atom has a pretty good flow plugin.

thank you, @phpnode!


Deeply nested Cache data takes a long time to update

Describe the bug
I have a Nuxt app utilizing the @nuxtjs/apollo module. On page load, I run a query that has data nested 3+ levels deep. One part of this page allows the user the ability to create/delete one of the deeply nested Items, however It takes around ~2.5s for the cache to update, even with optimisticResponse. The cache at this point might look something like this:
ROOT_QUERY
  trips: [Trip]
    0: Trip:1
      categories: [Category]
        0: Category:1
          items: [Item]
            0: Item:1
            1: Item:2
            2: Item:3
    1: Trip:2

I ran an interesting experiment where I run a Categories query after my initial large Trips query. From what I understand, it will avoid making a second request to the server because that data already exists in the Cache, and what this also effectively  does is change my Cache to look something like this:
ROOT_QUERY
  trips: [Trip]
    0: Trip:1
      categories: [Category]
        0: Category:1
          items: [Item]
            0: Item:1
            1: Item:2
            2: Item:3
    1: Trip:2
  categories: [Category]
    0: Category:1
      items: [Item]
        0: Item:1
        1: Item:2
        2: Item:3
    1: Category:2
    2: Category:3
    3: Category:4
    ...

This effectively puts both Categories and Trips at the top level of the ROOT_QUERY, and when I modified the service function to write to Categories instead, it reduced the time from ~2.5s to ~350ms.
Here is how I'm running this experiment:
Table.vue:
methods: {
  async handleRemoveRow (item, category) {
      const payload = {
          fields: {
            item_id: item.id,
            category_id: category.id
          },
          trip_id: this.activeTrip.id,
          apollo: this.$apollo
        };

        const from = window.performance.now();
        await itemService.removeItem(payload);
        const to = window.performance.now();
        console.log(`Call took removeRow ${to - from} milliseconds`);
  }
}

item.service.js:
import { produce } from 'immer';

async function removeItem ({ fields, trip_id, apollo }) {
  return await apollo.mutate({
    mutation: removeItemMutation,
    variables: fields,
    optimisticResponse: {
      __typename: 'Mutation',
      removeItem: {
        __typename: 'item',
        id: fields.item_id,
        name: '',
        weight: 0,
        unit: '',
        price: 0,
        category_id: fields.category_id,
        quantity: 0,
        position: 0,
        created_at: Date.now(),
        updated_at: Date.now()
      }
    },
    update: (store, { data: { removeItem } }) => {
      console.log({ removeItem });
      // read
      const data = store.readQuery({ query: tripsQuery });

      // find indices
      const tripIndex = data.trips.findIndex(e => e.id === trip_id);
      const categoryIndex = data.trips[tripIndex].categories.findIndex(e => e.id === fields.category_id);
      const itemIndex = data.trips[tripIndex].categories[categoryIndex].items.findIndex(e => e.id === fields.item_id);

      // mutate
      const newData = produce(data, x => {
        x.trips[tripIndex].categories[categoryIndex].items.splice(itemIndex, 1);
      });
      console.log({ newData });

      // write
      store.writeQuery({
        query: tripsQuery,
        data: newData
      });
    }
  });
}

To Reproduce
Steps to reproduce the behavior:

Populate Cache with data nested 3+ levels deep.
Attempt to add/remove one of the objects from the deepest array.
Response time will grow exponentially the deeper you go.

Expected behavior
I expect deeply nested data to respond in a reasonable amount of time.
Versions
vue: 2.6.12
vue-apollo: 3.0.5
apollo-client: 2.6.10
Additional context
I originally created a StackOverflow post with code and ultimately my findings, before deciding to open an Issue here.

Just an update: I upgraded @nuxtjs/apollo from v4.0.1-rc.5 to v4.0.1-rc.18 and vue-apollo from v.3.0.1 to v.3.0.5, which dramatically reduced the time for these mutations. Originally it was taking around ~2.5s, now they're down to 0.5-1s. Still not ideal, but MUCH better.


Improve error messaging for SSL related errors

Issue description:
Recently we saw a lot of agent SSL issues not related to the agent. Usually, we see a generic error message like the below:
System.Net.Http.HttpRequestException: The SSL connection could not be established, see inner exception.
---> System.Security.Authentication.AuthenticationException: The remote certificate is invalid according to the validation procedure.

We need to increase verbosity to such errors - to be able to understand the root cause more quickly.
Fix description:
As a fix, we will use ServerCertificateCustomValidationCallback to capture the SSL-related data about web requests. We will set this custom callback for every Vss connection that will be created by the pipeline agent during the runtime.
Changelog:

Introduced SslUtil class that contains the implementation of ServerCertificateCustomValidationCallback
Updated method CreateConnection of VssUtil class to set ServerCertificateCustomValidationCallback for each Vss connections
Other methods were updated to pass TraceWriter in the CreateConnection method to be able to write SSL-related data to the agent's log

Examples of logging:

Examples
[2021-11-16 10:32:39Z INFO AgentServer] Diagnostic data for request:
[SSL Policy Errors]
RemoteCertificateChainErrors: ChainStatus has returned a non empty array
[HttpRequest]
Requested URI: https://v-alsmo.visualstudio.com/_apis/connectionData?connectOptions=0&lastChangeId=109199399&lastChangeId64=109199399
Request method: GET
[HttpRequestHeaders]
X-TFS-Session: 212cdc39-bc97-47ee-be06-87c6f7dddd81
X-VSS-E2EID: 94f6e84e-faf3-4f42-ae8e-cf804e7461c5
User-Agent: VSServices/16.196.31911.0, (NetStandard; Microsoft Windows 10.0.19043), VstsAgentCore-win-x64/2.999.999, (Microsoft Windows 10.0.19043)
[Certificate]
Effective date: 11/10/2021 6:59:48 PM
Expiration date: 11/10/2022 6:59:48 PM
Issuer: CN=Microsoft RSA TLS CA 02, O=Microsoft Corporation, C=US
Subject: CN=visualstudio.com

[2021-11-16 10:31:52Z INFO AgentServer] Diagnostic data for request:
[SSL Policy Errors]
RemoteCertificateNameMismatch: Certificate name mismatch
RemoteCertificateChainErrors: ChainStatus has returned a non empty array
[HttpRequest]
Requested URI: https://v-alsmo.visualstudio.com/_apis/distributedtask/pools/1/sessions/f98284a4-8bd4-43ab-9e37-4c21403c2d7d
Request method: DELETE
[HttpRequestHeaders]
X-TFS-Session: 0252cb29-20b8-4e31-9f5b-7903e236fe76
X-VSS-E2EID: 6f5c22b1-52a0-4f34-878a-ba54688a46ad
User-Agent: VSServices/16.196.31911.0, (NetStandard; Microsoft Windows 10.0.19043), VstsAgentCore-win-x64/2.999.999, (Microsoft Windows 10.0.19043)
[Certificate]
Effective date: 11/10/2021 6:59:48 PM
Expiration date: 11/10/2022 6:59:48 PM
Issuer: CN=Microsoft RSA TLS CA 02, O=Microsoft Corporation, C=US
Subject: CN=visualstudio.com

[2021-11-16 10:30:48Z INFO AgentServer] Diagnostic data for request:
[SSL Policy Errors]
RemoteCertificateNotAvailable: Could not resolve related error message
RemoteCertificateNameMismatch: Certificate name mismatch
RemoteCertificateChainErrors: ChainStatus has returned a non empty array
[HttpRequest]
Requested URI: https://v-alsmo.visualstudio.com/_apis/distributedtask/pools/1/sessions/8788a522-8f1f-4243-bc3a-d993a7f15e48
Request method: DELETE
[HttpRequestHeaders]
X-TFS-Session: 4641a21d-c316-4ddb-a340-8b5322844033
X-VSS-E2EID: 58c19023-50b5-4fe3-9c50-a654e02d1439
User-Agent: VSServices/16.196.31911.0, (NetStandard; Microsoft Windows 10.0.19043), VstsAgentCore-win-x64/2.999.999, (Microsoft Windows 10.0.19043)
[Certificate]
Effective date: 11/10/2021 6:59:48 PM
Expiration date: 11/10/2022 6:59:48 PM
Issuer: CN=Microsoft RSA TLS CA 02, O=Microsoft Corporation, C=US
Subject: CN=visualstudio.com

Documentation changes required: No
Added unit tests: No
Attached related issue:

#1623

Checklist:

[x] Checked that applied changes work as expected

There are 2 places for which trace is still not passed - could you please check?
src\Agent.Sdk\LogPlugin.cs:205
src\Agent.Worker\WorkerUtilties.cs:30

The following VssConnections constructor call still not adjusted - so there won't be SSL errors tracing for them:
src\Agent.Plugins\Artifact\FileContainerProvider.cs

src\Agent.Sdk\LogPlugin.cs:205
src\Agent.Plugins\Artifact\FileContainerProvider.cs
src\Agent.Worker\Build\FileContainerServer.cs

Per offline discussion, we have decided to postpone enabling  SSL error tracing for these places.


Mobile: Welcome Screen

Overview
updates buttons to fit on mobile
Changes

replaces with new Primary/Secondary Buttons

Screenshots

@adamgall wasn't the New Buttons. These were still using a 'ColoredButton' Component within the Home.tsx that wasn't set with a width so default to auto and that allowed the buttons to extend past the parent containers.


Improve add list

Part of #34

Create Type class
Integrate Type class to return meaningful feedback to User through CommandResult
Added attribute information to Item to facilitate additional increments for UI

LGTM!


Add-UiPathProcessSchedule does not accept user (Modern Folder Support)

When setting the robot to a user as required for modern folders, you receive a type mismatch error.

Bumping with Error Output:
Add-UiPathProcessSchedule : Cannot bind parameter 'Robots'. Cannot convert the "UiPath.PowerShell.Models.User" value
of type "UiPath.PowerShell.Models.User" to type "UiPath.PowerShell.Models.Robot".


BenchmarkDriver Strangler replaces Benchmark_Driver run

This is a followup to PR #18719 that concludes the StranglerApplication of the Benchmark_Driver's run command. The remaining free-standing functions implementing the run command were replaced with methods on BenchmarkDriver class with full unit test coverage.
The functionality remains unchanged with the exception of cleaning up the last "Totals" line of the log reports, after removing the bogus aggregate statistics. It now simply states the number of executed benchmarks:
Total performance tests executed: 1

I've structured the PR as a series of small, incremental changes with detailed descriptions in the commit messages, it is therefore best reviewed sequentially by individual commits.

@eeckstein Please review 🙏

@swift-ci please benchmark

@swift-ci please smoke test

@eeckstein Benchmarks finished successfully. Can you merge this as is or should I change something?


Error when running create-dnsmasq.sh

Trying to convert the CDN address text files to dnsmasq format.
But when running the create file I get this error.
./create-dnsmasq.sh: line 21: syntax error: unexpected redirection
Following instructions from here though I am not using piehole. Just my routers dnsmasq server.
https://oct8l.gitlab.io/posts/2021/297/scripting-lancache-dns-updates-with-pi-hole/

Getting the same error, if you fixed it, please share the solution ^^

parse error: Expected another key-value pair at line 9, column 2
thats that line:
out=$?

Is anybody still experiencing this problem?


Nft minting ux

Can you please take a look of menu bar in mobile view, it seems like on home page its has some padding or margin, not sure which keep some space after the menu.


[Stable Video Diffusion] How to increase the motion of the video by adjusting the parameter

Firstly, many thanks for the advanced algorithms provided
I found in my reasoning, the same image, the proportion of said portrait, by changing the seed, there is a time when the portrait will move slightly, there is a time when only the background changes, and there is a time when there is no movement, may I ask whether it is possible to adjust the other parameters, so that every time said portrait moves!

Try changing motion_bucket_id. The higher value you use the more motion is added, but still lacks clarity on how it affects the direction of movement


TACKLE-665: AddCustomRules: use customFileHandler

Use updated version of file-upload-multiple from PF
Use customFileHandler prop to have a granular control of duplicate files and XML validation (against schema).
Fixes ability to remove a file from upload list. See https://issues.redhat.com/browse/TACKLE-665 for details

@gildub

Seems as if we are Uploading the file and storing it without enabling/disabling the Add button. Can we integrate this functionality with the Add button? I think this is a regression from main. Thx.

@ibolton336, actually the (requirement)[https://github.com/konveyor/enhancements/tree/master/enhancements/tackle/tackle-windup-integration#custom-rules] says:
"If any of the files is not valid clicking on "Add" will result in only the valid files being added to the custom rules list".

@ibolton336, actually the requirement says: "If any of the files is not valid clicking on "Add" will result in only the valid files being added to the custom rules list".
Although it make sense when several files are selected for upload, it doesn't really ideal when there is only one file selected.

:+1:  So we need to add some logic for the Add button state as it stands sounds like.

@ibolton336, done, button is disabled when there not at least one valid and uploaded file.

I am still able to upload duplicate rule files in some cases:

If I upload a rule file, close the modal, and then reopen the add custom rule file modal & add the same rule file - I see a few bugs. See screen shots.

@ibolton336, I've fixed the issue when closing the modal. Thanks for testing.

@ibolton336, I've fixed the issue when closing the modal. Thanks for testing.

I am still seeing the count increment when adding and then closing the add modal. I see 2 of 1 upon re-opening the modal etc.

@ibolton336, I cannot reproduce the count increment using latest patch. Could you please check ?


Add the function getPlayerSummaries(options)

Add the function getPlayerSummaries to get the player information by dota2 account id.
I need to use dota2-api to get the information of players and matches but the original package does not have the method to get the player's username or player's image. So I add this function.

Coverage decreased (-3.5%) to 95.614% when pulling bb830badc5245cc4ad5a17c3a9aeb27f53759790 on susufqx:master into 7be54f8e5e68b760e5914e9481c48b62c408f57b on booxood:master.

@susufqx Thanks for your pull request.
The code in the lib directory is generate by build. Please add source code to src directory.


Update setup.py to require colorama on Windows

Closes #31

I think I got it fixed!

now black likes it. We should be good to go!

Sorry, I didn't get a notification email for this for some reason. Looks great, thanks!


When I run "python3 -m pyprocessing run examples/setupdraw.py" I get an error

The full error:
Traceback (most recent call last):   File "/usr/lib/python3.8/runpy.py", line 193, in _run_module_as_main     return _run_code(code, main_globals, None,   File "/usr/lib/python3.8/runpy.py", line 86, in _run_code     exec(code, run_globals)   File "/home/mateusap1/Projects/pyprocessing/pyprocessing/__main__.py", line 37, in <module>     sys.exit(callback(**args))   File "/home/mateusap1/Projects/pyprocessing/pyprocessing/__main__.py", line 15, in run     runner = Runner.from_sketch_path(args.path, args.renderers) AttributeError: 'dict' object has no attribute 'path'
When I changed
runner = Runner.from_sketch_path(args.path, args.renderers) to
runner = Runner.from_sketch_path(args["path"], args["renderers"])
on line 14 of __main__.py it worked.

I'm getting the same error. Changeing the line to just runner = Runner.from_sketch_path(path, renderers) aslo fixed it

This was fixed in #7

Good, I was about to do that.


Unable to set securityContext for controller containers

Description
Observed Behavior:
This https://github.com/aws/karpenter-provider-aws/issues/4278 removed capability to set custom security contexts
It should allow to set them and just have defaults instead of removing whole capability
Unable to install on hardened clusters which require containers to have set contexts
Expected Behavior:
Ability to set own podSecurityContext containerSecurityContext and controllerSecurityContext
Reproduction Steps (Please include YAML):
Try to install on any cluster with gatekeeper that requires fsGroups on container or supplementalGroups
Versions:

Chart Version: 0.31 and up
Kubernetes Version (kubectl version):

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Unable to install on hardened clusters which require containers to have set contexts

Which part of the securityContext do you need to be able to set and doesn't work in the default configuration?

for starters here runAs fsGroup etc is not settable, i don't understand the apporach, you should make defaults but allow to override them, first time i see this on any k8s addon i use

fsGroup is in the podSecurityContext and is settable in the latest versions of Karpenter. I think the general thinking was: Why do you need to set the security context of the container? Can we pick a sensible default that works for everyone?

the sensible default is ability to override you will not cover all the cases anyway,
at the same time i cannot disclose what gatekeeper rules we use, just revert that PR and put the defaults in values.yaml
for container security context imagine any operator injecting init container that will use different group id
i don't wanna argue about this but all other projects just allow override

any operator injecting init container that will use different group id

If you inject an init container, can't you set the security context specifically for that?

at the same time i cannot disclose what gatekeeper rules we use, just revert that PR

I'll look around at some other charts, but it's hard for me to justify reverting a PR without having a concrete reason to do so.

The reason is to have more flexibility and coverage of use cases :) also charting best practices.
I don't hue to convince you it's not like I ask to change defaults just to have possibilities

The reason is to have more flexibility and coverage of use cases

I'll take a guess -- because I think I've seen valid use-cases for this (as I was refreshing my memory on this, I realized that I had this conversation with someone else before): #5794. Given I can see cases where you would want to be able to inject a different value per-container for this kind of thing, I can see an argument to opening this up. To your point, we don't lose a lot from doing it.
An even bigger question -- because I'm curious -- are there specific parts of the security context that you need us to open up or just something like the runAsUser. This is really the only value that I can imagine that you would need to/want to change and.

also charting best practices

Do you mind pointing me to a few examples? I did a quick search-around and I saw some differences here and there. Some seem to just allow runAsUser while others seem to open up the whole thing.
cc: @stevehipwell

the stuff i used was opening the whole thing and in my opinion that's karpenter should do too, considering its possible future adoption.
also i've seen some projects trying to be to detailed in their charts and they ended up chart and values hell imo giving sane defaults for sections and opening them up to override its best road. otherwise instead of maintaining code you will end up maintaining charts :)

otherwise instead of maintaining code you will end up maintaining charts

Makes sense. If this was something that you wanted to propose to add, we'd be receptive to it. I'd personally go for a securityContext block under both the controller and webhook sections in the values.yaml file to handle both of the container contexts.

yes under both sections plus bring back podSecurityContext

@jonathan-innis @gacopl I can't see an actual issue in the current chart logic, although I can think of a couple of optimisations.
The podSecurityContext value is currently fully configurable; but I think we should probably provide some better defaults than just setting fsGroup.
Locking the Karpenter container security context down is IMHO absolutely the right thing to do for a first party Helm chart. Why would the user have any need to change most of these settings when they are explicitly tied to the logic and OCI image? That said I can potentially see a use for exposing seccompProfile & seLinuxOptions as these are the only options which are potentially end user driven.
Any additional containers added can have their security context set to whatever the end user desires, and as the podSecurityContext is open there are no fixed limitations on that.

I have to fully disagree with @stevehipwell, first party Helm chart wannabe should absolutely give ability to control how the product is being run on user cluster, providing sane defaults with ability to override is the way to go many other projects successfully did. And if not override, add your defaults but allow to add whatever else user might need if you want to be strict. But this is not standalone product its plugin so you should allow some freedom for advanced users if you want adoption
Honestly I am surprised we have to discuss this it seemed like a no-brainer...

I mean just look at how cluster-autoscaler is handlling it that's it

@gacopl Karpenter (karpenter-aws-provider to be exact) is a first party Helm chart, where the service is targeting a single cloud vendor (also first party), with a direct SemVer relationship between the binary and Helm chart; this all means that the valid use pattern is as consistent as possible. I can't think of anything other than seccompProfile & seLinuxOptions that you could have a valid reason to modify on the pod security context.

I mean just look at how cluster-autoscaler is handlling it that's it

I'm pretty familiar with that project/chart having rewritten the chart before handing it back to be maintained. The difference there is the context; the primary maintainers aren't focused on Helm and the service itself is very much multi-cloud. This means that the potential use patterns are very different and the maintainers can't or don't want to handle the overhead of having fixed values.
Let's just acknowledge that the "perfect" Helm chart would be one with no input variables that still managed to meet each individual end-user's requirements. The closest we can get to this is either the operator pattern (notice how locked down operator pod specs tend to be) or a Helm chart well aligned to the use case (such as Karpenter).
To take this further please could you provide some use cases which you're currently blocked from achieving due to the Karpenter Helm chart?

supplemental groups, seccomp, se..
unless you want to set defaults for all these which probably will not be good for everyone - override makes most sense. I don't understand why you don't want to agree to at least have extension possibility to add stuff besides whatever you specify.
i won't spend time arguing as i did - back in the day of EKS preview, if you don't plan to be more open we will just call it typical aws non-sesne and fork the chart - you will come around eventually

supplemental groups, seccomp, se..

@gacopl of those 3 I'd already mentioned 2. I think customisable supplemental groups could be something the user might want to modify but I'm not sure of any use cases relevant to Karpenter? You've still not actually provided any use cases yet though, could you please share the ones which led to this issue?
FYI the beauty of OSS is that you can take something and modify it to fit your needs, although you need to want it enough to put the resources in to maintain the fork. In this case you don't even have to fork the chart, you could just use a post render function like kustomize to overlay a custom patch.
I'm not AWS BTW, just an OSS contributor.

Steve like stated above I won't put in what exactly rules we use in gatekeeper that require us to modify the context from your default values, trying to find default values that will work for everyone is just vain
This was to open up the possibilities and shed light on this imo bad practice
There are multiple ways to workaround this kustomize that's what we usually do in more complex cases, nothing new to us but simply prefer to not play circus tricks over something that should be set right from the start. Fix the root
Anyways, If you don't intend changing approach feel free to close issue I won't play convincing game as I don't have time for it :)
Someone already brought it before me someone will bring it again eventually.
As for the OSS part  I even more cannot understand the approach as the approach should be open too if it's OSS.
People run clusters in many ways, trying to enforce one right way by default non customizable chart values in some beta project is surprising.
Begs a question why even bother running it through helm if you want to have such strict approach idk
Godspeed

Hello,
I am reactivating this thread as I am in the exact same case as @gacopl.
stevehipwell I have a production ready EKS cluster with Gatekeeper rules enforced by our security team. One of the rule is to have a securityContexte that has privileged: false. I saw that there are default values (which match some of my Gatekeeper rule), but it would be better to allow full customization for users.
Is it possible to reconsider this ? Thanks a lot !


Source sdk-partitions from the models instead of hardcoding

Motivation and Context
Fixes #2836
This is required to gain access to hew partitions.
Description

Update sync-models to sync from aws-sdk-rust. This location includes sdk-partitions.json
Update aws:sdk gradle file to properly set this variable in codegen.
Add an additional safeguard to ensure that the default hardcoded version is only used in tests and adhoc SDK generation.

Testing

Verify that adhoc assemble fails if you manually set the flag for a prod build

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

merged as bot because server changes are whitespace only


HTML table support

The table in https://plato.stanford.edu/entries/pythagoras/ is currently not supported.
Note that there's another

 inside a 	, which further complicates the issue.

Solved by e1b01fb, although some cosmetic tweaks (perhaps manually) may be needed for the nested tables in https://plato.stanford.edu/entries/pythagoras/.


CLIError when exporting to PDF: dir option must be relative to "/tmp"

Hi,
When I try to export my file to PDF I get the following error:

Failure to export: [CLIError] Failed converting Markdown. (dir option must be relative to "/tmp", found "/home/fd".)

I tried playing around with the few settings available but no luck. Any chance you can help me?
Cheers,
François

It will be resolved by merging the latest Marp CLI v0.21.1: https://github.com/marp-team/marp-cli/issues/201, https://github.com/marp-team/marp-cli/pull/283, #165
But Marp CLI in the same VS Code environment still reported another issue (https://github.com/marp-team/marp-cli/issues/287). We will merge and release new version of the extension as soon as fixed it.

A reported error has been fixed by updating Marp CLI. Try new release of the extension, v0.15.1.
If you may see another error message like "Puppeteer was unable to kill the process...", try these steps:

Open VS Code setting.
Find out Markdown > Marp: Chrome Path, and set "/snap/chromium/current/usr/lib/chromium-browser/chrome".
Restart VS Code.
Try again export to PDF.

Failure to export: [CLIError] Failed converting Markdown. (kill EACCES)  occurs whenever i try to save into pdf, i can now save as html


Instances of classes created through object literals don't use class instance methods

TypeScript Version:  3.0.1

object literal structural typing method call
class Point {
	constructor(readonly x: number, readonly y: number) { }
	toString() { return `${this.x}, ${this.y}` }
}

const p1: Point = { x: 0, y: 0 }
const p2: Point = new Point(0, 0)

console.log(p1.toString())
console.log(p2.toString())

Expected behavior:
p1 and p2 to print the same thing
Actual behavior:
p1 bypasses the toString method, and just calls the generic object toString()
Playground Link:
https://www.typescriptlang.org/play/#src=class Point {
	constructor(readonly x: number, readonly y: number) { }
	toString() { return `${this.x}, ${this.y}` }%09%0D%0A}%0D%0A%0D%0Aconst%20p:%20Point%20=%20{%20x:%200,%20y:%200%20}%0D%0A%0D%0Aalert(p.toString())
Related Issues:

This is expected because p1 is no instance of Point. You just told Typescript that p1 should be structurally equivalent to Point, i.e. have the properties x and y

Types don't impact the runtime behavior, so this is expected. See https://github.com/Microsoft/TypeScript/wiki/FAQ#what-is-type-erasure

You don't have any warnings or errors because every object* in JavaScript have a toString method from Object prototype, so neither in assignment nor calling the method will throw because the method exists in runtime. If you change the method to another name, then you will realice that you must provide an implementation for your object.


Add OpenWithFlags and OpenBestEffort flag

This patch allows the callers to opt into a best-effort open where
malformed is skipped without returning an error.
Signed-off-by: Zygmunt Krynicki<EMAIL_ADDRESS>

\o/


Update dependencies

Upgrade eslint from 3.3.1 to 3.5.0, which adds 5-10 new rules that are fixable with --fix.
There were also new rule additions. I will create separate issues for the ones that make sense.

Test failure can be ignored, it's related to a rule catching more errors in eslint 3.5.0.

Re-running tests...

Thanks for the review, @LinusU!
This is now released as standard v8.1.0.


HDDS-5963. Implement ListBlock command

https://issues.apache.org/jira/browse/HDDS-5963

@cchenax Could you please fix the ut failures, I think they are related to this patch.

Hi @adoroszlai , could you please continue reviewing this one?
This is a based on a previous pending issue contributed by Sammi.

Hi all, any updates on this?
I think this interface is important for implementing EC Offline Recovery, we'd better get this done and later we could merge it back to the EC branch.
FYI: https://issues.apache.org/jira/browse/HDDS-6462

Hi all, any updates on this?

I'm waiting for an answer on a code reuse question.  Otherwise the patch LGTM.

Thanks @ChenSammi @cchenax for the work, thanks @adoroszlai for reviewing.


Azure cli create container app not working after migration to Microsoft.App

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az containerapp env create Extension Name: containerapp. Version: 0.2.4.
Errors:
Creation or update of environments and container apps in Microsoft.Web namespace are no longer supported. Please use Microsoft.App namespace instead. More information available via aka.ms/microsoftappmigration.

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az containerapp env create --name {} --resource-group {} --logs-workspace-id {} --logs-workspace-key {} --location {}

Expected Behavior
Environment Summary
Windows-10-10.0.19041-SP0
Python 3.8.9
Installer: MSI

azure-cli 2.34.1

Extensions:
aro 1.0.0
containerapp 0.2.4

Dependencies:
msal 1.16.0
azure-mgmt-resource 20.0.0

Additional Context

route to CXP team

@ShafeerAli CLI experience currently doesn't support Microsoft.App - use portal until CLI release happens in the next week or so. Sorry for the inconvenience. @anthonychu , @torosent FYI

@ShafeerAli Apologies for the late reply. Could you please check the above suggestion provided by @panchagnula and let me know if you see any issue ? Awaiting your reply.

@navba-MSFT Container APPs is not a GA feature yet, so hoping CXP can skip these issues for now.

@ShafeerAli we will update this issue when the Microsoft.App support for Container apps using CLI is ready, so you can re-try & confirm.

The Microsoft.App-compatible version of the extension is now ready. Please see this issue for more: https://github.com/microsoft/azure-container-apps/issues/152

Please try the new version & let us know.


Specify a types for functions and errors in resolvers

Expected Behavior
Our resolvers currently have functions that can produce a certain error or a result from the context layer below. We should add typespecs to all the functions in the resolvers and
Actual Behavior
At the moment there are no types for any errors or functions in the resolvers
Acceptance Criteria
The errors  that can occur in the resolvers should have a type that is shown in the resolver specs, the functions should have their  types specified
Steps to Reproduce the Problem

Our GraphQL resolvers don't have types for the errors and the functions

Specifications

Version:

I think @br4inii  and @WanjikuMac  you two should work together to finish this issue it will get you guys very familiar with the project

@br4inii  @WanjikuMac  let me know when we can meet up and I can give you guys direction for what to do here