Read status port from mesh config

For https://github.com/istio/istio/issues/21222

cc @incfly for app prober changes

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-conformance-k8s-tests_istio

integ-local-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-conformance-k8s-tests_istio

integ-local-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-conformance-k8s-tests_istio

integ-local-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-conformance-k8s-tests_istio

integ-local-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-conformance-k8s-tests_istio

integ-local-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-conformance-k8s-tests_istio

integ-local-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-conformance-k8s-tests_istio

integ-local-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-pilot-k8s-tests_istio

lint_istio
344b76325ac007328c5a6c521f54372da58f7a07
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-distroless-k8s-tests_istio

integ-conformance-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-conformance-k8s-tests_istio

integ-local-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-local-tests_istio

integ-galley-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-pilot-k8s-tests_istio

lint_istio
344b76325ac007328c5a6c521f54372da58f7a07
link
/test lint_istio

gencheck_istio
344b76325ac007328c5a6c521f54372da58f7a07
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-local-tests_istio

integ-mixer-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
63acab9879328619a47ea9356534cde101151228
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
4cafcec38914081c150554802aa71bf05c33f8a2
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
63acab9879328619a47ea9356534cde101151228
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
63acab9879328619a47ea9356534cde101151228
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add doc for EXTRACT, date_part

Which issue does this PR close?
After implement the #1974 , add the doc for user😊
Closes #.
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@Ted-Jiang  please fix the format of the document.

@yjshen I have pointed out this issue like https://github.com/apache/arrow-datafusion/issues/1379
I have a plan to do and consolidate them.

It seems we modeled after PostgreSQL for both the function and this documentation. I've noticed some gaps in the supported types and the return type. Do we have notes elsewhere, or should we create TODOs to fill the gap?

@yjshen I have pointed out this issue like https://github.com/apache/arrow-datafusion/issues/1379
I have a plan to do and consolidate them.


Add package.json

Add package.json so people can install via npm (i.e. they're not using bower)

Please update to new urls, so we can merge!

:+1:
Just ran into this today


OpenAI error

Hey @irgolic,
Facing openai context window limit errors.
Would recommend wrapping the openai completion base with reliableGPT to handle retries, model switching, etc.
from reliablegpt import reliableGPT
openai.ChatCompletion.create = reliableGPT(openai.ChatCompletion.create, user_email=...)

Source: https://github.com/BerriAI/reliableGPT

Hi @krrishdholakia, thanks for reaching out.
I use tenacity to handle retries, unsure how this is useful apart from rotating API keys, or why a user email is needed.


[MS Connector] Setup sync workflows executions

launch fullsync when connector is created
launch incremental sync after the fullsync, then continueasnew every ~ 5mn (1 per connector)

will require tweaking incremental sync code

garbage collection: similarly, run continuously (1 per connector)

Depends on #5747 #5751

Also ensure fullsync and incremental sync coexist soundly:

incrementalsync should not exclude parents, and look at all a file's parents when it is updated;
only update files and folders when lastModified > lastSeenTs (in addition to startSyncTs > lastSeenTs)
in the opposite case, for files don't do anything; for folders, don't update or mark as visited, but still go through their children (that might have been modified too)


Can't loadSession from bot.on('event', event => {})

Version
Botbuilder: 3.15.0,
Node.js: 8.9.0
Running on my local machine
Description
The call for builder.UniversalBot.loadSession fails silently while called in the builder.UniversalBot.on handler.
To Reproduce
Steps to reproduce the behavior:

A Directline postActivity is created on the client. A 'event' type message with text 'connect' is sent to the bot.

  botConnection
    .postActivity({
      from: user,
      type: 'event',
      text: 'connect'
    })
    .subscribe(
      id => console.log('Posted activity, assigned ID ', id),
      error => console.log('Error posting activity', error)
    );

A handler is created in the bot. It's suppose to call loadSession with the provided address recieved from the event but it never enters the callback.

bot.on('event', data => {
  bot.loadSession(data.address, (error, session) => {
    if (error) {
      console.error(error);
    }
    ...
  });
});

If I promisify the loadSession:

bot.on('event', data => {
  const promisifyLoadSession = promisify(bot.loadSession);
  promisifyLoadSession(data.address)
    .then(_ => {
      console.log(_);
    })
    .catch(err => {
      console.error(err);
    });
});

I get the following catched error message and stack trace:
{
message: "Cannot read property 'loadSessionWithOptionalDispatch' of undefined",
stack: "TypeError: Cannot read property 'loadSessionWithOptionalDispatch' of undefined
    at UniversalBot.loadSession (/home/fbulic/Bots/Bot-HandOff/node_modules/botbuilder/lib/bots/UniversalBot.js:253:14)
    at internal/util.js:227:26
    at UniversalBot.bot.on.data (/home/fbulic/Bots/Bot-HandOff/app.ts:75:5)
    at emitOne (events.js:116:13)
    at UniversalBot.emit (events.js:211:7)
    at /home/fbulic/Bots/Bot-HandOff/node_modules/botbuilder/lib/bots/UniversalBot.js:156:31
    at /home/fbulic/Bots/Bot-HandOff/node_modules/botbuilder/lib/bots/UniversalBot.js:427:53
    at UniversalBot.tryCatch (/home/fbulic/Bots/Bot-HandOff/node_modules/botbuilder/lib/bots/UniversalBot.js:516:13)
    at next (/home/fbulic/Bots/Bot-HandOff/node_modules/botbuilder/lib/bots/UniversalBot.js:427:23)
    at UniversalBot.eventMiddleware (/home/fbulic/Bots/Bot-HandOff/node_modules/botbuilder/lib/bots/UniversalBot.js:430:9)
    at /home/fbulic/Bots/Bot-HandOff/node_modules/botbuilder/lib/bots/UniversalBot.js:141:23
    at /home/fbulic/Bots/Bot-HandOff/node_modules/botbuilder/lib/bots/UniversalBot.js:472:53
    at UniversalBot.tryCatch (/home/fbulic/Bots/Bot-HandOff/node_modules/botbuilder/lib/bots/UniversalBot.js:516:13)
    at /home/fbulic/Bots/Bot-HandOff/node_modules/botbuilder/lib/bots/UniversalBot.js:472:23
    at UniversalBot.tryCatch (/home/fbulic/Bots/Bot-HandOff/node_modules/botbuilder/lib/bots/UniversalBot.js:516:13)
    at UniversalBot.lookupUser (/home/fbulic/Bots/Bot-HandOff/node_modules/botbuilder/lib/bots/UniversalBot.js:459:14)
    at /home/fbulic/Bots/Bot-HandOff/node_modules/botbuilder/lib/bots/UniversalBot.js:136:19
    at /home/fbulic/Bots/Bot-HandOff/node_modules/async/lib/async.js:181:20
    at replenish (/home/fbulic/Bots/Bot-HandOff/node_modules/async/lib/async.js:319:21)
    at /home/fbulic/Bots/Bot-HandOff/node_modules/async/lib/async.js:330:15
    at Object.async.forEachLimit.async.eachLimit (/home/fbulic/Bots/Bot-HandOff/node_modules/async/lib/async.js:220:35)
    at UniversalBot.receive (/home/fbulic/Bots/Bot-HandOff/node_modules/botbuilder/lib/bots/UniversalBot.js:133:15)"
}

Expected behavior
Should loadSession without failing silently.
[bug]
[javascript]

You mentioned data.address a few times in the event handler, but it doesn't look like that's defined in the activity sent, which should be the source of the immediate issue from the looks of things.
That said, I'll take a look into why the callback is not returning the error out of loadSession

@nyxsys as the activity enters the bot it has some additional data/properties, one of which is the address property (implementing the botbuilder IAddress interface). Here is an example of a data object:
{
"type":"event",
"timestamp":"2018-11-03T08:47:30.4687371Z",
"name":"connect",
"text":"",
"attachments":[],
"entities":[],
"address":{"id":"6uhHKBSxVUC13WBYlzrJGR|0000000","channelId":"webchat","user":{"id":"Agent01","name":"Agent01"},"conversation":{"id":"6uhHKBSxVUC13WBYlzrJGR"},"bot":{"id":"<botId>,"name":<botNAme>},"serviceUrl":"https://directline.botframework.com/"},
"source":"webchat",
"agent":"botbuilder",
"user":{"id":"Agent01","name":"Agent01"}
}

For the moment I'm setting up a PR to at least add a try catch for error handling to the location that should throw the exception. I am going to dig deeper and try and find out why this is occurring at all after that.

So the error "Cannot read property 'loadSessionWithOptionalDispatch' of undefined" suggests that something is wrong with the initialization of the universal bot. Could you post your code where you initialize the bot itself?

This is the code:
const bot = new builder.UniversalBot(connector)
  .set('localizerSettings', {
    botLocalePath: path.join(process.cwd(), 'locale'),
    defaultLocale: 'en'
  })
  .set('persistConversationData', true)
  .set('autoBatchDelay', 0)
  .set('storage', new builder.MemoryBotStorage());

I've used other methods (like send, on, dialog ...) and everything works. This is the only exception.

I realize that, which is why its weird that the error suggests there's an issue there, going to look into it further.

I tried bot.loadSession on a bot on the same version of botbuilder you've listed in three locations.  bot.on() as well as bot.dialog() and bot.use() but I have not been able to recreate the error you are seeing, both with and without including the same bot.set() config calls you've posted. Could you try and see if you get a different result out of putting the bot.loadSession() call into middleware  using bot.use()?
If that doesn't work, it might be good to see if you could put together a minimum version of your bot that can reproduce this issue.

@filipjakov, have you tried the suggestion from @nyxsys or is the issue resolved? Thx.

Closing as resolved not repro


Wrong signature - only in codesandbox with v0.33

In this codesandbox env I'm getting a wrong signature error when authentication happens. Diving a bit deeper makes it clear that the signToBase64 returns the wrong thing, only in codesandbox with v0.33:
const test = signToBase64(
  'test',
  'A/HPrEDqn+1KLZiOLwFOzknX3DAX8bbOmVt/+WCkrzM=',
);
test.then(console.log);

Locally: mWh7xwoBFAdj2vKdG4ACq0jGvxUtF8APjWEgHCEDXR1aCc2NBVLEgd9NR2N5hXqdDRZuYrwFKoFE4ZVZT5KJBQ==
Codesandbox (v0.32.2): mWh7xwoBFAdj2vKdG4ACq0jGvxUtF8APjWEgHCEDXR1aCc2NBVLEgd9NR2N5hXqdDRZuYrwFKoFE4ZVZT5KJBQ==
Codesandbox (v0.33.0): CKNpTllw1LZ33Fwm/Dkbx6lpvuQ+8hk3DrtA0BxntHV0AjNdkZvXdxCfhlAsiZ24Ofudcxx4bRylB+sHv3cQDA==
What's going on here?

https://github.com/paulmillr/noble-ed25519/issues/70
Not sure what the issue was. Locking the noble dependency fixed the issue, but I can't reproduce it.


[Joss Review] Tests

To my understanding, the package is tested using doctest only. I could consider that a good starting point, but the currently included test can be considered happy-path regression/integration tests. Considering that some of the implemented functions have several inputs and possible execution branches, a more elaborate suite of unittests would be nice.
I would not consider this an exclusion criteria for the review, but I personally would not feel comfortable using the current package in any project of relevance given the current state of testing.

Your point is well taken.  There are definitely more tests I can add to ensure coverage/completeness.
I haven't found that this project benefits much from using specifically the unittest framework over doctest as the algorithms are written pretty functionally so the nice features like magic inputs on some combination haven't been missed so far.  Maybe you did track it down, but I am using doctest for more than just the function and class docstrings. There are extra test files that are run (there are over 200 tests run).  Many of the examples were made/written as code tests.
So far, relying on doctest forces the documentation to be clear and comprehensive, as pretty much every case that I would want to check I make an example of how it is expected to perform.  In my experience, unittests for things like 'assert some function returns a non-empty list' are not as useful as expected output examples, because I have had lists returned that are not empty, but not the expected output.
So I am humbly clear though; it's not to say I think the testing I have is perfect or exhaustive, there is and always will be room for improvement.  I could see some students helping and contributing to the project through the testing as a first step on it as well.
Sorry if I missed your point, "happy-path regression/integration tests" is fair, was there other types of tests you expect?

I also setup some github actions to at least make the commits more consistent for checking https://github.com/cadop/seg1d/commit/fc414453c67111e5832edb542f656cf311a94475

Sry for the silience from my side. Just let me give a little bit of context to my issue.
First of all, compared to many other packages out there the testing of seg1d is really solid. However, I think lack of proper testing is one of the biggest issue with many smaller scientific codebases, I wanted to provide some further feedback.
Unittesting: Unittesting is a concept and not really tied to any framework like unittest or pytest. Unittesting is just the concept to isolate small components of you codebase (e.g. a single class or single function) and test the full functionality of this part of the code. Im comparison to testing programs end-to-end, is that focusing on a single function often makes it easier to come up with proper testcases, as the overall complexity is lower.
Happy Path Testing: Happy Path Testing refers to the pitfall of only testing a function in the way you expect an experience user to use it correctly. This often leads to not testing combinations of inputs, that might not be reasonable, not testing that exception are thrown correctly, what happens if functions are called with wrong input data types. In particular the last one is a typical Python problem. Of course it is not feasible to assert and test every function with any possible combinations for input types, but in particular with scientific python there are a couple of things that I usually like to test explicitly: What happens when your function is called with a pandas dataframe instead of an numpy array. Sometimes this leads to different results without throwing an error message. Similarly, I test what happens if float values are passed instead of integer values (or the other way around). Due to the differences how native Python and numpy deal with datatypes during mathematical operations, this can sometimes highlight a couple of edge cases of your function. In general, it is up to the developer to be aware of potential edgecases of the code and write explicit tests for this to make sure that these edge cases are properly handled.
Regarding your tests, I was missing tests that for example check, if exceptions are thrown in the correct way, or if unexpected results occur if invalid input combinations are used. These things are far easier to test, if you isolate a single function in a unittesting concept. This is why I suggested it.

As this is not a blocking issue, but just FYI, I will close it


[MODCON - 103] - Skip patron users when migration existing users

…PES.SHADOW}")

Purpose

Approach

Skipped patron users
TODOS and Open Questions

Learning

Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.

Does this PR meet or exceed the expected quality standards?

[ ] Code coverage on new code is 80% or greater
[ ] Duplications on new code is 3% or less
[ ] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] Were any API paths or methods changed, added or removed?
[ ] Were there any schema changes?
[ ] Did any of the interface versions change?
[ ] Were permissions changed, added or removed?
[ ] Are there new interface dependencies?
[ ] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all the appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Did you modify code to call some additional endpoints?

[ ] If so, do you check that necessary module permission added in ModuleDescriptor-template.yaml file?

Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Results

Warn logs

@azizbekxm please add karate tests in separate PR for this functionality


Added Datastore.findOpts(query, opts, callback)

findOpts is an extended version of the find function, where the 2nd parameter (previously just projections) is now used to pass in fields (aka projections), paging, and sort  values which, for the most part, eliminates the need to return a cursor.
This function will never return a cursor and will always expect the last parameter to be a callback, keeping it auto-promisification compliant.
i.e. With this function, you can now run promise.promisifyAll(...) on an instance of Datastore to be able to use await or yield on findOptsAsync with all working find features whereas simply using findAsync function would be severely handicapped as it would not be able to project, page or sort.

Yes, this is make sense. However, I would recommend adding additional options to the standard find, findOne and count projection as: $skip, $limit, and $sort.
Example:
db.find({}, {username: 1, email: 1, _id: 0,  $skip: 20, $limit: 10, $sort: {username: 1} }, callback)

The issue with that is, count is not paged. Neither is find one. The criteria should remain seperate from query options.

You may be right. However, I don't thing we should add this pull request to the official distribution.
You may make  a wrapper for NeDB with that functionality that will work over the original package.
I hope @louischatriot will take a clever decision.


How to hide/move down the legend from PieChart

Hi Team,
How to hide/move down the legend from PieChart, Kindly help on this. thanks.

To hide you just need to set the property hasLegend={false}


Can't access on my solder server

Hello
I had a working solder server a year ago, but now that i want to start to use it again i cannot access.
If I try to go on my server page it just start a download of a file (that is the /public/idex.php file)
I try to reinstall solder but nothing changed, what could be the problem?

This doesn't sound like an issue with Solder directly; it sounds like you're either missing PHP on your webserver, or your webserver isn't configured properly to serve PHP pages.
Please see the following documentation to confirm your web server is configured properly: http://docs.solder.io/docs/example-web-server-configs


wallpaperPlainColor for workspace & kscreenlocker

Adding wallpaperPlainColor for desktop workspace and kscreenlocker.
4th value is alpha, value from 0 to 256. Default is 256 (100% opacity).
programs.plasma.workspace.wallpaperPlainColor = "11,44,176";
programs.plasma.kscreenlocker.wallpaperPlainColor = "11,44,176,256";

Works great, thanks


Verify the input tensors of the entry point function

This patch adds verification of the input tensors that are passed to entry point functions such as run_main_graph. Entry point signature is used to verify tensors. In particular, it verifies:

The number of input tensors
Data type of each input tensor
Rank and shape of each input tensor

When the input tensors are invalid, run_main_graph returns NULL and errno = EINVAL (Invalid argument) is emitted.
A new compile option --verifyInputTensors is added to enable verification inside the entry point function. It's off by default.
A new backend test is added to verify this verification, that is make check-onnx-backend-input-verification.
This is an example of verification when data type is wrong:
Wrong data type for the input 0: expect f32
Traceback (most recent call last):
  File "test.py", line 22, in <module>
    y = sess.run(input=[a, b])
RuntimeError: Runtime error during inference returning with ERRNO code 'Invalid argument'.

The verification detected an error about numerical tests on Windows CI:
Wrong data type for the input 0: expect f32, but got undefined.

It looked like the data type of the randomly generated tensors was not set correctly on Windows. This patch fixed this issue also.
Resolves #1125
Signed-off-by: Tung D. Le<EMAIL_ADDRESS>

@jenkins-droid test this please

I would like to have a bit more high level info to understand what and how this PR is doing the checking. Checking is useful to our uses, no doubts.
I am a bit concerned that we use the compiler to create a json string and then use the json string to verify the input. So why not skipping the (probably inefficient) json string and test directly the inputs from what the shape inference and compiler knows.
What is the performance impact of testing? It is a useful service to the user, but does it have to be inline all the time?
LLVM has a Json string parser, I have used it in our utils; so creating a "service" that check the input tensors with for the JSON string can be relatively easily done in the runtime (e.g. additional call to ExecutionSession).
If we do it inline all the time, it better be very cheap, or we should consider switching it on/off using an option.

Verification is very lightweight, it is like if (actualRank != referenceRank) then return NULL for each value we want to verify.

Very good. I assume that the errno value is also set and the pseudo code above just omitted this part.

I assume that the errno value is also set and the pseudo code above just omitted this part.

Yes, you are right.

Jenkins Linux ppc64le Build #5493 [push] Verify the input tensors... started at 23:22

Jenkins Linux s390x Build #6371 [push] Verify the input tensors... started at 23:20

Jenkins Linux amd64 Build #6355 [push] Verify the input tensors... started at 22:20

Jenkins Linux amd64 Build #6355 [push] Verify the input tensors... passed after 1 hr 23 min

Jenkins Linux s390x Build #6371 [push] Verify the input tensors... passed after 1 hr 28 min

Jenkins Linux ppc64le Build #5493 [push] Verify the input tensors... passed after 1 hr 33 min


Trojan:Script/Wacatac.B!ml After Ollama Update Ollama

Today after Ollama automatic update on a windows machine  system find Trojan:Script/Wacatac.B!ml.
Why??

I'm sorry you hit this – it's a false positive detection from Windows Defender. Unfortunately Go programs have a history of causing false positives with Windows Defender. We're working with Microsoft Security Intelligence to fix this. For now I'll merge this with https://github.com/ollama/ollama/issues/2519

In the meantime, please do update your Windows Defender definitions and the latest version of Ollama should install without any warnings. You can see more info here: https://github.com/ollama/ollama/issues/2519#issuecomment-1957880099


Perform auth via Snowflake OAuth implicit grant

Rather than relying on OAuthD, this change makes ember-icis-auth
directly use Snowflake via the OAuth2 implicit grant flow.
This also removes the /auth end point because that was specifically for
the authorization grant flow via OAuthD. We don't support that here, and
it we wanted to, we'd need to reimplement what had been there before
because it relied on OAuth.js which was specifically for OAuthD.

@maxfierke Totally down with ripping out Travis build. Why have double coverage, we already build it w/ Kochiku.

@rustygeldmacher I guess our many open source contributors to this library will be SOL when comes to viewing build logs then :p


neovim: Generate per-plugin config in different languages

lua support in neovim has considerably improved in version 0.7.
Some users may want to use an init.lua instead of an init.vim for
instance. This MR makes it possible (disable wrapping and wrap neovim
yourself).
It also allows to generate a runtime.
See pkgs/applications/editors/neovim/tests.nix how to pass your plugins
(or home-manager once it takes advantage of this).
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I will update this after the branch off for 22.05

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nix2vim-prerelease/18980/4

+1

it's a bad idea after all, there is an implementation in home-manager already. Nixpkgs should focus on basics and my experience with fennel or teal have not been good enough to consider those as "basic" (and adoption doesn't seem widespread either)


Use .zshenv instead of .zshrc

Here you unfortunately chose to modify .zshrc instead of .zprofile, which is the analog to .profile/.bash_profile.
It makes a difference when running zsh from the command line as a login shell, because .zshrc is not loaded in that case.

I have the same problem discussed here.

A shell is a login shell if it has been set as the login shell say for example with chsh -s /bin/zsh or via Terminal Preferences correct?  Since zsh is now the default shell for Catalina moving forward, zsh would be an interactive login shell would it not? Therefore putting export PATH lines in .zprofile and autoload -U promptinit lines in .zshrc would be the accepted conventions no? However many people just dump everything into .zshrc which does no harm really if zsh is the default shell right?

@tysun that seems reasonable, but i'm no zsh expert, i've avoided catalina so far, and plan to use bash as my default shell when i'm forced to upgrade, so I'd be happy to review a PR that gets approvals from a bunch of zsh users :-)

Except that Bash is being deprecated due to licensing issues. Hence Apples move to a default Zsh. That is why I am future-proofing now and have removed all traces of Bash. Everything is just a mirror anyway. .bashrc = .zshrc, .bash_profile = .zprofile etc. I am using zsh + Hyper.

Apple is deprecating it; bash itself isn’t being deprecated.
I’m fully in support of nvm working well on both zsh, and on any Mac as freshly installed (modifications beyond that, ymmv). I’m just not knowledgeable enough on zsh to ensure that, so I’m hoping others will contribute.

That's right. Bash is being deprecated by Apple, as I mentioned, due to licensing.  So....if you are on macOS it would be best to future-proof. Thank you for your input and support.

I ran across this when trying to improve the developer experience of React Native developers building their apps for iOS.
In a React Native project shell scripts are invoked, when building the app, which use command -v node internally to determine the Node executable. In its current form NVM is installed in the .zshrc but this is loaded only on interactive login shells. The interactive shell isn't reasonable to use when Xcode is executing build scripts.
A perfectly fine workaround is to move the SOURCE_STR from ~/.zshrc into ~/.zshenv (as that will be loaded for any zsh):
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm

I'd be happy to provide a PR, but it seems the install.sh would need a non-trivial refactor to split the SOURCE_STR and COMPLETION_STR across two different files (I'd say the latter belongs in ~/.zshrc in any case).

Stopping in to say: I just upgraded to Sonoma, and my VS Code tasks stopped being able to find yarn. Turns out it's no longer loading .zshrc when it runs tasks. Not sure why upgrading to Sonoma seems to have done that; I don't think I upgraded Code at the same time.
In any case, I came across this issue looking for solutions, and moving all the nvm stuff from .zshrc to .zshenv fixed it. Whether or not that makes it worth changing where nvm puts it in the first place, hopefully someone else with the same issue finds this note and it helps them solve it. 🙂

And stopping in again to note that it took my non-interactive shell startup time from 0.122s to 0.677s, which bogged down all kinds of stuff (like every keybinding I've made through skhd). Seems I'm going to have to find a better solution. I can't recommend putting it in your .zshenv.


Allow optional specification of image folder during multiple inference

closes #504

Works for me!

I have updated the text below the text fields.

Thank you very much for having added this feature in such a short time!!!


Consolidate and rationalize SQL generation

Currently different parts of the stack do SQL generation in different ways. This may be fine since, for example, query and update have different mechanisms and requirements. However, we should make sure that we are using common code where it makes sense. If nothing else, code for escaping, etc. should be able to be shared. Related to this is that if a provider needs to customize how things like escaping are done, then the provider should only need to do this in one place.

Make sure we API review IUpdateSqlGenerator et al before closing this

This should be a very scoped refactoring just to ensure providers don't have to override escaping etc. in multiple places

We are happy with what we have now


For News Feed, Auto-Parse Content And Link Relevant Objects

Would be nice to either use simple markdown when writing news posts to refer to ML people or projects or to auto-parse this stuff from the news post and link to the appropriate things.

I think it's just easier to have them manually selected like https://github.com/makeabilitylab/makeabilitylabwebsite/issues/874


Update readme for running e2e tests with nomad

The Chore
The instructions need to be brought up to date: https://github.com/vegaprotocol/frontend-monorepo#running-tests implies you can just run them, then https://github.com/vegaprotocol/frontend-monorepo#vega-capsule mentions that 2 of the test suites require a nomad setup, but only contain partial instructions for getting that up and running.
Tasks

[ ] Ensure that it is clear for someone unfamiliar with the setup how to run all the tests

@edd to review

I think this is still unclear - It's got more text than it needs. I just want to know how to run the tests for a project I haven't run them for, without having to make a decision about Docker or Capsule. The original ticket is still valid.

This is clearly way out of date


I can't start after setting led parameters

My panel is 32x32. I changed the parameter. The original parameter is 16. My panel parameter is 32, but it can't be started. It shows "flash read err, 1000". What should I do?
main.cpp
#ifndef PXMATRIX_ROW_PATTERN
#define PXMATRIX_ROW_PATTERN 32 // The row pattern for the display
13:59:01.597 -> ets Jun  8 2016 00:22:57
13:59:01.597 ->
13:59:01.597 -> rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
13:59:01.597 -> flash read err, 1000
13:59:01.597 -> ets_main.c 371
13:59:01.967 -> ets Jun  8 2016 00:22:57
13:59:01.967 ->
13:59:01.967 -> rst:0x10 (RTCWDT_RTC_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
13:59:01.967 -> configsip: 0, SPIWP:0xee
13:59:01.967 -> clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
13:59:01.967 -> mode:DIO, clock div:2
13:59:01.967 -> load:0x3fff0018,len:4
13:59:01.967 -> load:0x3fff001c,len:1044
13:59:01.967 -> load:0x40078000,len:10124
13:59:01.967 -> load:0x40080400,len:5828
13:59:01.967 -> entry 0x400806a8
13:59:02.527 ->

From what I can tell, that error happens when it looks at 0x1000 for the bootloader and fails to find it. This project uses a custom flash partition layout, so that might be a factor. That parameter you changed isn't for the display resolution but for the inverse of the scan pattern, so the default 16 is for a 1/16 pattern. This is directly fed into the PxMatrix library, so I would first try one of the examples from https://github.com/2dom/PxMatrix to ensure you have the display working and the correct parameters before trying to get this project working. 32x32 panels typically have a 1/8 or 1/16 scan pattern, though.


intro fix

oh just noticed in the last PR that the course should say through Jan 20th not Jan19 - need to fix that

I will do this when I make the other updates to the intro


Doc - restore conf link

Internal ref:

https://github.com/arangodb/planning/issues/2514

Either we restore the link, or we change the default conf file. Should be okay to restore the link?
This PR is a wip, @Simran-B to verify if the links in the doc can be fixed and once it builds it can get merged and backported to 3.4 - by today
What I did:

i moved the file configuration.md into configuration/README.md
also can we review this file, is it current - should we clearly link the page for the arangod server options - thanks

@sleto-it Please review too (GitHub won't let me add you as reviewer for some reason, maybe because you are the author?)


Compile warnings in clang 18

When the google test version bumps to the lates, we can see below warnings when we compile tests with clang 18
In file included from /home/runner/work/proxy/proxy/build-clang-18/_deps/googletest-src/googletest/src/gtest-all.cc:38:
In file included from /home/runner/work/proxy/proxy/build-clang-18/_deps/googletest-src/googletest/include/gtest/gtest.h:55:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/memory:66:
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_tempbuf.h:263:8: warning: 'get_temporary_buffer<testing::TestInfo *>' is deprecated [-Wdeprecated-declarations]
  263 |                 std::get_temporary_buffer<value_type>(_M_original_len));
      |                      ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_algo.h:4996:15: note: in instantiation of member function 'std::_Temporary_buffer<__gnu_cxx::__normal_iterator<testing::TestInfo **, std::vector<testing::TestInfo *>>, testing::TestInfo *>::_Temporary_buffer' requested here
 4996 |       _TmpBuf __buf(__first, (__last - __first + 1) / 2);
      |               ^
/usr/bin/../lib/gcc/x[86](https://github.com/microsoft/proxy/actions/runs/10312728530/job/28548416779#step:8:87)_64-linux-gnu/12/../../../../include/c++/12/bits/stl_algo.h:5070:23: note: in instantiation of function template specialization 'std::__stable_sort<__gnu_cxx::__normal_iterator<testing::TestInfo **, std::vector<testing::TestInfo *>>, __gnu_cxx::__ops::_Iter_comp_iter<(lambda at /home/runner/work/proxy/proxy/build-clang-18/_deps/googletest-src/googletest/src/gtest.cc:3009:20)>>' requested here
 5070 |       _GLIBCXX_STD_A::__stable_sort(__first, __last,
      |                       ^
/home/runner/work/proxy/proxy/build-clang-18/_deps/googletest-src/googletest/src/gtest.cc:3008:8: note: in instantiation of function template specialization 'std::stable_sort<__gnu_cxx::__normal_iterator<testing::TestInfo **, std::vector<testing::TestInfo *>>, (lambda at /home/runner/work/proxy/proxy/build-clang-18/_deps/googletest-src/googletest/src/gtest.cc:3009:20)>' requested here
 3008 |   std::stable_sort(test_info_list_.begin(), test_info_list_.end(),
      |        ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_tempbuf.h:99:5: note: 'get_temporary_buffer<testing::TestInfo *>' has been explicitly marked deprecated here
   99 |     _GLIBCXX17_DEPRECATED
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12/bits/c++config.h:119:34: note: expanded from macro '_GLIBCXX17_DEPRECATED'
  119 | # define _GLIBCXX17_DEPRECATED [[__deprecated__]]
      |                                  ^

One hypothesis is that the root cause might because we are using libstdc++ with clang, while libc++ is the standard library for LLVM.

I believe the warning is totally unrelated to proxy. We're not using any related standard utilities.


Add to_arr

closes #17

Needs a rebase, but looks good otherwise

Please do not push additional commits to the branch that is currently active in the PR. Ask me tomorrow to help you fix that. I'd like to merge your first commit. There should be a second PR for your second task.


Flexvolume driver instance principal authentication doesn't work

Some complexity around configuration results in errors for instance principal auth in the flexvolume driver. The following PR addresses the root cause https://github.com/oracle/oci-flexvolume-driver/pull/150/files

Change the flexvolume configuration to share with the CCM and Volume Provisioner. This should resolve the issue.


Couchbase Logs Fix: mapping of couchbase_general log severity

Noticed the field in the regex was not matching the later defined
	components = append(components,
		confgenerator.LoggingProcessorModifyFields{
			Fields: map[string]*confgenerator.ModifyField{
				"severity": {
					MoveFrom: "jsonPayload.level",
					MapValues: map[string]string{
						"debug": "DEBUG",
						"info":  "INFO",
						"warn":  "WARNING",
						"error": "ERROR",
					},
					MapValuesExclusive: true,
				},
				InstrumentationSourceLabel: instrumentationSourceValue(lr.Type()),
			},
		}.Components(tag, lr.Type())...)

@braydonk going to try and validate via the integration test the fields are getting set 😄

Updating docs change but everything was validated and passed with changes


Enhances spo listitem batch add, Closes #4666

Closes #4666

Thank you, we'll try to review it ASAP!

What I think is that you should surround $csvContent with quotes.
--csvContent "$csvContent".
If you don't do that, your command will look like:
--csvContent Item A which is not interpreted as 1 value.

You could try the route Milan suggests @nicodecleyre. If we use "$csvContent" we probably also need to escape " in the variable.
Some trial and error may be necessary. And this should also work with csv's with quoted columns!

What I think is that you should surround $csvContent with quotes. --csvContent "$csvContent".
If you don't do that, your command will look like: --csvContent Item A which is not interpreted as 1 value.

Thx for your suggestion @milanholemans, unfortunately the command exhibits the same behavior 😞

Perhaps we should consider changing formatting.parseCsvToJson(csvContent!) a bit. Currently, sending the converted CSV object to the CLI isn't straightforward. But an approach like this works:
$json = @(
  @{
    "Name" = "John"
    "Age" = 30
    "City" = "New York"
  },
  @{
    "Name" = "Jane"
    "Age" = 25
    "City" = "London"
  },
  @{
    "Name" = "Bob"
    "Age" = 40
    "City" = "Paris"
  }
)

$csvData = $json | ConvertTo-Csv -Delimiter ',' -UseQuotes Always -NoTypeInformation | ForEach-Object { $_ -replace '"', "'" }

# $csvData = 'City','Age','Name' 'New York','30','John' 'London','25','Jane' 'Paris','40','Bob'

Then execute the CLI command like this:
$> m365 spo listitem batch add --csvContent $csvData --webUrl ... --listTitle ... --verbose

Executing command spo listitem batch add with options {"options":{"csvContent":"'City','Age','Name' 'New York','30','John' 'London','25','Jane' 'Paris','40','Bob'","webUrl":"...","listTitle":"...","verbose":true,"debug":true,"output":"json"}}
Starting to create batch items from csv from content

This way, we'll have a CSV object ready to be sent to the CLI. However, it's worth noting that the parseCsvToJson utility isn't able to handle this format just yet. This is an alternative approach to consider. 😊

@nicodecleyre: the problem seems to be the double quotes around the csv field values. Can you try escaping them? The same restriction goes up here as with feeding it complex Json: get the right escapes in place.

@Jwaegebaert, that would not be valid json, so I'd like us to steer clear of it.

@martinlingstuyl not sure what you mean by 'not valid json'?

Time to stop working for me I guess 😂

Anyway, I do think we need to check out first if escaping the quotes will be enough.

You mean escaping the quotes in Powershell itself or escaping the quotes in the command? Because the problem lies in the way process.argv treats the options and it never reaches the command

I mean escaping the quotes in PowerShell itself. Option values like JSON strings have the same issues. We have a couple of paragraphs on the docs explaining how to properly escape in different versions of PowerShell, due to the nature of how PowerShell passes these values on to the lowerlying native commands.

https://pnp.github.io/cli-microsoft365/user-guide/using-cli#escaping-double-quotes-in-powershell

What version of PowerShell do you use?

Id try something like $csvContent.Replace('"','"') for example.

Hi all,
$csvContent.Replace('"','\"') seems do to the trick! Taking this into account i have added an example to the documentation as requested. Please let me know if there is still anything missing!
Thank you all for your help!

$obj = @(
  @{
    Name = "Item A"
    Age = 10
  },
  @{
    Name = "Item B"
    Age = 20
  }
)

$csv = ConvertTo-Csv -InputObject $obj -Delimiter "," -NoTypeInformation

Hi @Jwaegebaert, the problem lies in how PowerShell treats the object.. The way you did it, your array consists of hashtables. When you convert this with ConvertTo-Csv, it converts the properties of the hashtable, and not the actual object as you can see below.

In order for ConvertTo-Csv to convert the actual object, your array must consist of PSCustomObjects:
$obj = @(
  [PSCustomObject]@{
    Name = "Item A"
    Age = 10
  },
  [PSCustomObject]@{
    Name = "Item B"
    Age = 20
  }
)

AND we have to use
$obj | ConvertTo-Csv -NoTypeInformation -Delimiter ","

Instead of
 ConvertTo-Csv -InputObject $obj -Delimiter "," -NoTypeInformation

This goes beyond the context of the CLI for Microsoft365 and is due to how ConvertTo-CSV handles an array object. I'll update the example with a multiple object array so that the user can use it properly.
To conclude, here an example of how it works:

Results in:

Hey, I did some digging and finally figured out what's causing the issue. I actually tried the suggestions you gave earlier, but they didn't do the trick for me. It's not really a big problem, more like a hassle. It seems you're running your scripts on PS version 5, while I'm using PS Core. I was able to smoothly add my object array to the SP list with PS 5, but with PS Core, it throws an error regarding the column '\"Name\"' not being found.
I personally prefer a solution that works with the latest version, PS Core, or one that works with both versions. I think we should explore a workaround for this. @pnp/cli-for-microsoft-365-maintainers, what do you guys think?

Hey, I did some digging and finally figured out what's causing the issue. I actually tried the suggestions you gave earlier, but they didn't do the trick for me. It's not really a big problem, more like a hassle. It seems you're running your scripts on PS version 5, while I'm using PS Core. I was able to smoothly add my object array to the SP list with PS 5, but with PS Core, it throws an error regarding the column '\"Name\"' not being found.
I personally prefer a solution that works with the latest version, PS Core, or one that works with both versions. I think we should explore a workaround for this. @pnp/cli-for-microsoft-365-maintainers, what do you guys think?

I see.. PS 5 on the left, PS 7 on the right

@Jwaegebaert, i've added a fix for PS 7. Tested in both PS 5 & PS 7 and it works in both.
Can you take another  look whenever you have time please?


(PUP-7742) Ensure getpwent and getgrent iterators are properly closed

A regression introduced in PUP-7498 commit e45ae7c where an iteration
was introduced that started with setpwent or setgrent and then iterated
each entry with the corresponding getpwent or getgrent until no more
entries were found. A call to endpwent or endgrent was never made.
In essence, this means that the internal iterator is reset to the start
before each iteration so it should be fine. The problem is that on some
platforms (notably on CentOS 7) the lack of the call to endpwent or
endgrent, causes a cached iterator to be reused. It is never refreshed
with new values. Consequently, a call to useradd would succeed, but the
added user would then not be found.
This commit replaces the initial call to setpwent or setgrent with
an ensured call to endpwent or endgrend at the end. The initial
set call was deemed unnecessary since it should be considered a serious
problem if the iterator is left open somewhere else. It's better to make
such problems abundantly apparent than adding attempts to overcome them.
This commit contains no tests. A proper acceptance test must be written
that asserts this functionality on CentOS-7 (the first platform where the
problem was discovered).

CLA signed by all contributors.

Thanks @thallgren


chore: release v0.1.10

Depends on #387 and #388.

Both of the dependent PRs have been merged. @seanmalloy please rebase when you have a chance and we can cut the release, thanks!

@vinny-sabatini and @sanbornick ready for review.


chore: Refine readme and replace docs with docs.pgvecto.rs

Close #233
Ref #214

Comments addressed. Preview is here: https://github.com/gaocegege/pgvecto.rs/tree/docs
PTAL

The upgrading doc is moved to admin, and README is updated.


fix: Handling of API operations that contain reserved characters in their paths

Fixes #992

Codecov Report

Merging #993 (f673a26) into master (f1566f7) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
- Coverage   99.78%   99.60%   -0.18%
==========================================
  Files          67       67
  Lines        4616     4615       -1
  Branches      765      765
==========================================
- Hits         4606     4597       -9
- Misses          3        8       +5
- Partials        7       10       +3

Flag
Coverage Δ

unittests
99.60% <100.00%> (-0.14%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/schemathesis/models.py
99.53% <100.00%> (ø)

src/schemathesis/schemas.py
100.00% <100.00%> (ø)

src/schemathesis/_compat.py
50.00% <0.00%> (-50.00%)
:arrow_down:

src/schemathesis/extra/pytest_plugin.py
97.77% <0.00%> (-2.23%)
:arrow_down:

src/schemathesis/cli/callbacks.py
98.19% <0.00%> (-1.81%)
:arrow_down:

src/schemathesis/cli/cassettes.py
98.30% <0.00%> (-1.70%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1566f7...f673a26. Read the comment docs.

Codecov Report

Merging #993 (f673a26) into master (f1566f7) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
- Coverage   99.78%   99.60%   -0.18%
==========================================
  Files          67       67
  Lines        4616     4615       -1
  Branches      765      765
==========================================
- Hits         4606     4597       -9
- Misses          3        8       +5
- Partials        7       10       +3

Flag
Coverage Δ

unittests
99.60% <100.00%> (-0.14%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/schemathesis/models.py
99.53% <100.00%> (ø)

src/schemathesis/schemas.py
100.00% <100.00%> (ø)

src/schemathesis/_compat.py
50.00% <0.00%> (-50.00%)
:arrow_down:

src/schemathesis/extra/pytest_plugin.py
97.77% <0.00%> (-2.23%)
:arrow_down:

src/schemathesis/cli/callbacks.py
98.19% <0.00%> (-1.81%)
:arrow_down:

src/schemathesis/cli/cassettes.py
98.30% <0.00%> (-1.70%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1566f7...f673a26. Read the comment docs.


Version bump for 2.3.1

Description of the change
Version bump to fix build folder error in 2.3.0
Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists
Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ]  This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

Sorry for the delay on these!! Somehow I'm not seeing the notifications!!


Use open jdk 11 in CI for installer

https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.7%2B10.1/OpenJDK11U-jre_x64_windows_hotspot_11.0.7_10.zip
Wanna have the bug fixed quickly?
Visit Issue hunt...

I mirrored it on https://content.faforever.com/jre/OpenJDK11U-jre_x64_windows_hotspot_11.0.7_10.zip as we know of speed issues with Github.

cool thx

I need a tar gz

@Brutus5000 next try https://drive.google.com/file/d/1mi3c_I0Yssvjq2PU5COs8yvVTtg3dotK/view?usp=sharing

needs to be a tar gz. I bundeled it via install4j(not sure what else it does to the jre)

https://content.faforever.com/jre/windows-amd64-11.0.7.tar.gz

Does not work yet so for reasons I need to investigate :D


Actual RAM usage vs. Memory Mapped

Hello,
First of all, very handy tool. Thanks!
I'm using mmap to read some giant files and Psrecord shows the file size as a part of memory usage report. Is there a way to make it only the actual RAM usage? What I care about is the RAM usage so I can provision enough memory for the kubernetes resources that run the code.
Thanks

I believe I'm seeing this behaviour too. Real memory being reported as >2x available RAM on the machine.


Added Project + Mentioned my name in README

Project_doc.md is missing
Do not edit the readme file
Fetch upstream before making any Pull Request

resolve conflicts and raise another PR


Add support for visionOS

In the future you'll probably be able to use target_family = "darwin" instead, but for now target_vendor = "apple" should suffice.

Could you update docs/comments too?
https://github.com/smol-rs/polling/blob/7531821ae2d61f967bb66aab9eb18310a8831a3d/src/lib.rs#L5
https://github.com/smol-rs/polling/blob/7531821ae2d61f967bb66aab9eb18310a8831a3d/src/kqueue.rs#L1
https://github.com/smol-rs/polling/blob/7531821ae2d61f967bb66aab9eb18310a8831a3d/README.md?plain=1#L16


also optionally provide per-task-function statistics

Currently statistics are per-request. With #103 tasks return a Result() giving us insight into how often the entire Task succeeds and/or fails. This issue is to optionally provide statistics about this at the end of a load test.
One specific use-case of this feature would be to confirm that all task sets have been assigned to a GooseUser, and that all contained tasks have actually run. These statistics would provide insight into how often each Task is running, and whether any were skipped (ie, due to weighting and too few users).

I like that a lot - this is so useful


Shuffle ids for building graph index

This pr is to shuffle ids for building graph index since user's data may be clustered by its sequence, this could cause some islands in graph to affect recall significantly, shuffle could alleviate this.
Divide base vector ids(not raw data itself) into different blocks(diskann already did this), and shuffle these blocks to build index, and adding points in each block is still memory friendly, result shows on a dataset with clustered data. Try to use 8192 as default block size in hnsw, which is currently used in diskann, to achieve almost the same building time and high recall in these cases.

hnsw
Build time(s)
recall(top100)
diskann
Build time(s)
recall(top100)

Full shuffle
246
0.926

479
0.933

Block size=1024
147
0.9079

389
0.9203

Block size=8192
126
0.8988

376
0.8667

No shuffle(now)
117
0.4975

371
0.4752

@chasingegg

what problem does this commit solve exactly and why the problem is actually solved?
is it worth making such a shuffle configurable in order to have 'more reproducible' results, for example, during some kind of debugging?

Thanks

Still need to know why order plus OOD data can damage the recall.

/lgtm

Fix #326


Add unit tests to the tox runs and wire them to presubmits

Unit tests that live alongside the tested modules (and not under test/) should be simple, self-contained tests that run very quickly. As such, they would be good candidate to run as part of the pre-submit checks.
This could be achieved with tox pre-commit hook described here: https://github.com/psafont/pre-commit-tox

This is now fixed with PR #867

This is now fixed with PR #867


Upgrade plugin to 1.3.0 and log4j to 2.17.1

Signed-off-by: Karishma Joseph<EMAIL_ADDRESS>Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #113 (e9f98b5) into main (24e1ac9) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #113      +/-   ##
============================================
- Coverage     72.01%   71.98%   -0.04%
+ Complexity     2943     2941       -2
============================================
  Files           376      376
  Lines         18723    18723
  Branches       1432     1432
============================================
- Hits          13483    13477       -6
- Misses         4656     4662       +6
  Partials        584      584

Impacted Files
Coverage Δ

.../org/opensearch/performanceanalyzer/core/Util.java
62.50% <0.00%> (-8.34%)
:arrow_down:

...formanceanalyzer/PerformanceAnalyzerWebServer.java
68.65% <0.00%> (-5.98%)
:arrow_down:

...nsearch/performanceanalyzer/rca/RcaController.java
79.29% <0.00%> (-0.45%)
:arrow_down:

...nalyzer/rca/net/handler/PublishRequestHandler.java
78.04% <0.00%> (+2.43%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24e1ac9...e9f98b5. Read the comment docs.


Turn bpp into a proper enumeration

The filter/prediction algorithm has only a small set of possible values for the length of byte chunks it operates on. This would previously be passed as a usize but still match against the discrete value choices in several different locations with differing methods. We turn it into a proper enum to avoid this issue.

[ ] Evaluated if this influences optimization.

BPP often means bits per pixel, but here seems to stand for bytes per pixel. It might be better to be explicit and call the type BytesPerPixel?

call the type BytesPerPixel?

Good point, yes.

You should be able to instead use an enum with custom discriminant values. It will allow for slightly better optimization and perhaps less boilerplate.

@Shnatsel It will be part of #227


User suggestion in assignee field

[x] Make Assigned To label as Assignee
[ ] For the Assignee input box there should be an autocompleting feature where members usernames should be suggested while providing input

References :point_down:
https://github.com/Real-Dev-Squad/website-api-contracts/tree/main/members

@Pavangbhat can this be picked?

Hi @DeRaowl
Sorry for the late reply, I did not get any notification
Yes you can start working on this task
Meanwhile checkout Real Dev Squad and feel to reach out to any of our members to join the community


Spanish translation of Chapter 5

¡Hi! This is the spanish translation for chapter 5 according to issue #38.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Adds support for using Danger on PRs

Summary
Adds initial Danger rules:

Warns on No new un-flowed JS file
Fails build  when FB Copyright header is not included

Test plan
This Dangerfile does not have the FB Copyright Header, so once Danger is set up she should fail this build.
Discussion

I based this on looking through a few PRs, will dig through a few more now that I've got something to show
Danger relies on Jest's packages, should/can I make the deps local paths inside yarn? So there's no duplication confusion

Setup
This requires a bit of config by @cpojer - you will need to go through the "creating a bot account"  - as this is OSS, it should be a new account with zero privileges to any repos.
After that you'll need to add a token to travis for DANGER_GITHUB_API_TOKEN.

I think these CI fails are from our usage of jest-transform in Danger, so, this question becomes more important

Danger relies on Jest's packages, should/can I make the deps local paths inside yarn? So there's no duplication confusion

I'll get the access data for the jest-bot and will report back when I added the token.
A few things that would be nice (I will add more ideas some time):

Fails if there are merge commits in the PR.
Fails if there are changes to package.json without changes to yarn.lock.

Does Danger have any form of state? Can we potentially use it to compare the performance of the test run to master?

Added a stricter rule check for the copyright header
Added the package.json to yarn.lock check, but I made it warn, not fail, a version bump or changes to the scripts would trigger a fail.
Turns out danger needs support for reading the commits, they're not in the raw diff, which makes sense considering you need an API for commit comments etc https://github.com/danger/danger-js/issues/81

@orta I added the token to travis using jest-bot. Is there anything else I need to do?

The master CI is broken, I'm gonna test without running ESLinter et al

Fails

:no_entry_sign:
New JS files do not have the Facebook copyright header: dangerfile.js

Warnings

:warning:
Please ensure that @flow and 'use strict' are enabled on: dangerfile.js

  Generated by :no_entry_sign: dangerJS

I set the "Display value in build log" to "on". Is there something else I need to do?

I mean at this point:

Everything else seems 👍

done!

Rock, that looks good to me. Will see if I can get enough time today to ship the commits API, otherwise might look over the weekend for that 👍

Awesome! Let me know when it's ready and doesn't spam people so much any more ;)

@orta the Flow link warning has a link to @flow => https://github.com/flow.... should it be in backticks instead? or should it link to the Flow website?


Dependency fail n 18.04 Bionic - python-gnomekeyring

Dependency fail n 18.04 Bionic - python-gnomekeyring:
Please fix. Affects all bionic installs.
root@rufus-ubuntu:/home/rufus/Software# ls -lha|grep term
-rw-r--r--  1 rufus rufus  44M May  4 20:53 terminus_1.0.0-alpha.46_amd64.deb
root@rufus-ubuntu:/home/rufus/Software# apt install ./terminus_1.0.0-alpha.46_amd64.deb
Reading package lists... Done
Building dependency tree
Reading state information... Done
Note, selecting 'terminus' instead of './terminus_1.0.0-alpha.46_amd64.deb'
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:
The following packages have unmet dependencies:
terminus : Depends: python-gnomekeyring but it is not installable
E: Unable to correct problems, you have held broken packages.
root@rufus-ubuntu:/home/rufus/Software# cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04 LTS"
root@rufus-ubuntu:/home/rufus/Software# uname -a
Linux rufus-ubuntu 4.15.0-20-generic #21-Ubuntu SMP Tue Apr 24 06:16:15 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Duplicate of #339

Thanks, awesome terminal, though I hope you can speed up loading.
On Wed, 16 May 2018, 00:50 Eugene Pankov<EMAIL_ADDRESS>wrote:

Closed #343 https://github.com/Eugeny/terminus/issues/343.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Eugeny/terminus/issues/343#event-1627411537, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AYRzZJuiqqQawG6_MKoTlu2WjDQzCTrYks5tyuskgaJpZM4T_pUY
.


UNFINISHED: saved cards

This is submitted for discussion. It corresponds to and requires: https://github.com/burnbright/silverstripe-omnipay/pull/63. It also is branched off of https://github.com/burnbright/silverstripe-shop/pull/269 - sorry if that's confusing. No action is required at this time. I'll submit a final PR once the work is complete and tested. Comments welcome @jedateach, @halkyon, or @chillu (or anyone really).
Basically, this work would not change anything unless:

You are using a gateway that supports createCard
You set CheckoutConfig.save_credit_cards to true

If both of those conditions are met, it functions exactly like the addressbook does. It of course only stores the last 4 digits of the card and a card reference token.

Hey @markguinn, what is the status of this? What are the plans for this regarding SS4? Cheers

@xini I'm not really working on this project any more but there is a decent community of folks who are. I suspect if someone took this branch and updated it it could be merged without any problem.

I have implemented a stripe version of this in https://github.com/xini/silverstripe-silvershop-stripe. Still early days though. PRs welcome.


General architecture for visualization of geospatial data

Hi,
I just had a quick call with Alexander Thieme and Sebastian H.
I am the author of the following project:
https://github.com/ManuelB/covid-19-vis/
Here are my thoughts about visualization the data that are collected with the CovApp.
The data has multiple target groups:
Data Scientist
Medical professionals
Normal citizens
The data that is currently stored in a PostgreSQL Database can easily be offered in a standardized format by using a geoserver (http://geoserver.org/) e.g. as WFS layer.
This layer offers the data by default in 7 different vector formats e.g. GeoJSON, GML, CSV, Shapefile etc. Other formats like Vector Tiles can be added with plugins for the geoserver.
This GeoJSON can be consumed by a client app e.g. MapBox GL JS. Unfortunately MapBox does not directly support WFS but it is still possible to add the GeoJSON.
An example url from a geoserver to load GeoJSON looks like this:
https://geoserver.everyonecounts.de/everyonecounts/ows?service=WFS&version=1.0.0&request=GetFeature&typeName=everyonecounts%3AEveryoneCounts&maxFeatures=50&outputFormat=application%2Fjson
CQL filters can be used to filter by time:
https://docs.geoserver.org/latest/en/user/services/wfs/vendor.html#wfs-vendor-parameters
This service can be consumed by multiple other systems like OpenLayers or QGIS.
The GeoJSON file can be put into https://kepler.gl/demo to do more animations.
Hope that helps
Manuel

Not relevant anymore.


Optionally omit the 'name' attr of dummy autocomplete fields.

TP2000-229 Don't submit '_autocomplete' fields

Why
Autocomplete fields are only used in the client and have no purpose on the server, but current behaviour submits their contents to the server (as URL encoded params on many of Tamato's forms). This can cause undesirable side-effects.
What

the auto allows setting the name attribute of the autocomplete field. This PR allows setting it to an empty value and thereby avoids submitting its value to the server.

Codecov Report

Merging #523 (bf3a5a9) into master (7e073e6) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
+ Coverage   92.72%   92.86%   +0.14%
==========================================
  Files         299      301       +2
  Lines       18567    19186     +619
  Branches     1479     1524      +45
==========================================
+ Hits        17216    17817     +601
- Misses       1077     1088      +11
- Partials      274      281       +7

Impacted Files
Coverage Δ

regulations/tests/test_business_rules.py
91.01% <0.00%> (-2.21%)
:arrow_down:

measures/models.py
95.71% <0.00%> (-0.21%)
:arrow_down:

measures/apps.py
100.00% <0.00%> (ø)

measures/signals.py
92.85% <0.00%> (ø)

measures/tests/test_signals.py
100.00% <0.00%> (ø)

measures/patterns.py
91.26% <0.00%> (+0.40%)
:arrow_up:

common/models/mixins/validity.py
98.48% <0.00%> (+0.44%)
:arrow_up:

measures/tests/test_business_rules.py
97.79% <0.00%> (+0.87%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e073e6...bf3a5a9. Read the comment docs.


Installing Failed Pty.js

Hello, I've tried installing from a git clone and received the following error:
npm http GET https://registry.npmjs.org/argparse/-/argparse-0.1.16.tgz
npm http 200 https://registry.npmjs.org/esprima/-/esprima-1.0.4.tgz
npm http 200 https://registry.npmjs.org/argparse/-/argparse-0.1.16.tgz

><EMAIL_ADDRESS>install /root/wetty/node_modules/pty.js
> node-gyp rebuild

/bin/sh: 1: node: not found
gyp: Call to 'node -e "require('nan')"' returned exit status 127. while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/usr/share/node-gyp/lib/configure.js:431:16)
gyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:797:12)
gyp ERR! System Linux 3.13.0-57-generic
gyp ERR! command "nodejs" "/usr/bin/node-gyp" "rebuild"
gyp ERR! cwd /root/wetty/node_modules/pty.js
gyp ERR! node -v v0.10.25
gyp ERR! node-gyp -v v0.10.10
gyp ERR! not ok
npm WARN This failure might be due to the use of legacy binary "node"
npm WARN For further explanations, please read
/usr/share/doc/nodejs/README.Debian

npm ERR! weird error 1
npm ERR! Error: ENOENT, lstat '/root/tmp/npm-18900-1ajJ8_LR/1453153736493-0.21297033480368555/package/dist/lodash.underscore.js'
npm ERR! If you need help, you may report this log at:
npm ERR!     <http://github.com/isaacs/npm/issues>
npm ERR! or email it to:
npm ERR<EMAIL_ADDRESS>
npm ERR! System Linux 3.13.0-57-generic
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! cwd /root/wetty
npm ERR! node -v v0.10.25
npm ERR! npm -v 1.3.10
npm ERR! path /root/tmp/npm-18900-1ajJ8_LR/1453153736493-0.21297033480368555/package/dist/lodash.underscore.js
npm ERR! fstream_path /root/tmp/npm-18900-1ajJ8_LR/1453153736493-0.21297033480368555/package/dist/lodash.underscore.js
npm ERR! fstream_type File
npm ERR! fstream_class FileWriter
npm ERR! code ENOENT
npm ERR! errno 34
npm ERR! fstream_stack /usr/lib/nodejs/fstream/lib/writer.js:284:26
npm ERR! fstream_stack Object.oncomplete (fs.js:107:15)
npm ERR! Error: ENOENT, lstat '/root/tmp/npm-18900-1ajJ8_LR/1453153737388-0.06007509049959481/package/test/test.js'
npm ERR! If you need help, you may report this log at:
npm ERR!     <http://github.com/isaacs/npm/issues>
npm ERR! or email it to:
npm ERR<EMAIL_ADDRESS>
npm ERR! System Linux 3.13.0-57-generic
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! cwd /root/wetty
npm ERR! node -v v0.10.25
npm ERR! npm -v 1.3.10
npm ERR! path /root/tmp/npm-18900-1ajJ8_LR/1453153737388-0.06007509049959481/package/test/test.js
npm ERR! fstream_path /root/tmp/npm-18900-1ajJ8_LR/1453153737388-0.06007509049959481/package/test/test.js
npm ERR! fstream_type File
npm ERR! fstream_class FileWriter
npm ERR! code ENOENT
npm ERR! errno 34
npm ERR! fstream_stack /usr/lib/nodejs/fstream/lib/writer.js:284:26
npm ERR! fstream_stack Object.oncomplete (fs.js:107:15)
npm ERR! tar pack Error reading /root/tmp/npm-18900-1ajJ8_LR/1453153736534-0.860922196181491/package
npm ERR! addLocalDirectory Could not pack "/root/tmp/npm-18900-1ajJ8_LR/1453153736534-0.860922196181491/package" to "/root/.npm/underscore.string/2.                                                                                3.3/package.tgz"
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /root/wetty/npm-debug.log
npm ERR! not ok code 0

What commands did you run to produce this error? Also, where is node installed on your system?

Hi, I have the same problem. I get the exact same error when I run the command "npm install".  System Linux 3.13.0-36-generic
gyp ERR! command "nodejs" "/usr/bin/node-gyp" "rebuild"
gyp ERR! cwd /tmp/wetty/wetty/node_modules/pty.js
gyp ERR! node -v v0.10.25
gyp ERR! node-gyp -v v0.10.10
gyp ERR! not ok
npm WARN This failure might be due to the use of legacy binary "node"
npm WARN For further explanations, please read
/usr/share/doc/nodejs/README.Debian
npm ERR! weird error 1
npm ERR! not ok code 0
`

I see this warning here:
npm WARN This failure might be due to the use of legacy binary "node"

What version of node are you running? (node -v)

Hi,
I am using the latest version of Node according to apt-get and it seems to be v.3.2-7.4. However when I type 'node -v' it shows blank.
Thanks
-M A
Date: Wed, 10 Feb 2016 12:40:22 -0800
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [wetty] Installing Failed Pty.js (#43)
I see this warning here:
npm WARN This failure might be due to the use of legacy binary "node"
What version of node are you running? (node -v)
—
Reply to this email directly or view it on GitHub.

That's strange. You might need a compatibility symbolic link.
From nodejs.org:

A Node.js package is also available in the official repo for Debian Sid (unstable), Jessie (testing) and Wheezy (wheezy-backports) as "nodejs". It only installs a nodejs binary, so you might want to ln -s /usr/bin/nodejs /usr/bin/node for many things to work.

How did you install nodejs on your system? Did you install the default package from your package manager or download one directly from https://nodejs.org/?

Hi,
I just ran "ln -s /usr/bin/nodejs /usr/bin/node" and 'node -v' still shows blank. I installed node via "apt-get install node". I have tried installing and reinstalling node again and it's still blank. In case it matters, I am doing all these on the default AWS instance and all packages are updated.
Date: Wed, 10 Feb 2016 13:35:47 -0800
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [wetty] Installing Failed Pty.js (#43)
That's strange. You might need a compatibility symbolic link.
From nodejs.org:
A Node.js package is also available in the official repo for Debian Sid (unstable), Jessie (testing) and Wheezy (wheezy-backports) as "nodejs". It only installs a nodejs binary, so you might want to ln -s /usr/bin/nodejs /usr/bin/node for many things to work.
How did you install nodejs on your system? Did you install the default package from your package manager or download one directly from https://nodejs.org/?
—
Reply to this email directly or view it on GitHub.

What is the output of the following commands?
ls -l "$(which node)"
ls -l "$(which nodejs)"
nodejs -v

Hi,
Here is the output:
ubuntu@ip-1-0-1-50:~$ ls -l "$(which node)"lrwxrwxrwx 1 root root 9 Oct 29  2012 /usr/sbin/node -> ax25-nodeubuntu@ip-1-0-1-50:~$ ls -l "$(which nodejs)"-rwxr-xr-x 1 root root 1462424 Mar 27  2014 /usr/bin/nodejsubuntu@ip-1-0-1-50:~$ nodejs -vnodejs: /usr/local/MATLAB/MATLAB_Compiler_Runtime/v83/bin/glnxa64/libcrypto.so.1.0.0: no version information available (required by nodejs)nodejs: /usr/local/MATLAB/MATLAB_Compiler_Runtime/v83/bin/glnxa64/libssl.so.1.0.0: no version information available (required by nodejs)nodejs: /usr/local/MATLAB/MATLAB_Compiler_Runtime/v83/bin/glnxa64/libssl.so.1.0.0: no version information available (required by nodejs)v0.10.25
Date: Wed, 10 Feb 2016 13:57:13 -0800
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [wetty] Installing Failed Pty.js (#43)
What is the output of the following commands?
ls -l "$(which node)"
ls -l "$(which nodejs)"
nodejs -v
—
Reply to this email directly or view it on GitHub.

It looks like you have a couple of options.

You can try installing nodejs-legacy as described here. This is probably your best bet.

If that doesn't work you could try to install a newer version of node.

If none of the above works you could manually create a compatibility symbolic link. In your case specifically this should work:

rm /usr/sbin/node
ln -s /usr/bin/nodejs /usr/sbin/node

Hope that helps,
Jarrett

Hi Jarrett,
Thank you so much for your help. I am very grateful and the problem has been finally solved. Wetty is running perfectly and works great. Just a quick question, is it possible to login to SSH with wetty using keys instead of user/pass? I mean just typing the username and it gets the SSH authentication key from a pre-specified file?
Thanks a lot again!
-M Anam.
Date: Wed, 10 Feb 2016 15:39:06 -0800
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [wetty] Installing Failed Pty.js (#43)
It looks like you have a couple of options.
You can try installing nodejs-legacy as described here. This is probably your best bet.
If that doesn't work you could try to install a newer version of node.
If none of the above works you could manually create a compatibility symbolic link. In your case specifically this should work:
rm /usr/sbin/node
ln -s /usr/bin/nodejs /usr/sbin/node
Hope that helps,
Jarrett
—
Reply to this email directly or view it on GitHub.

Try --sshauth publickey. Closing.


Remove status bar

The status bar element is unnecessary and pulls away from the aesthetic of the application. As per our group's discussion, this element will be removed from the UI.
Closes #157

Codecov Report
Base: 62.63% // Head: 62.77% // Increases project coverage by +0.13% :tada:

Coverage data is based on head (c5b0d8a) compared to base (b1e0c76).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #171      +/-   ##
============================================
+ Coverage     62.63%   62.77%   +0.13%
  Complexity      666      666
============================================
  Files           119      118       -1
  Lines          2358     2353       -5
  Branches        295      295
============================================
  Hits           1477     1477
+ Misses          771      766       -5
  Partials        110      110

Impacted Files
Coverage Δ

src/main/java/seedu/address/ui/MainWindow.java
0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


make_exec should clear icache

On a Mac with an M1 processor, reusing an anonymous memory map can execute the previous code, resulting in seemingly-impossible failure modes.
Here's a minimal reproduction case, alternating between
mov x0 #1
ret

or
mov x0 #2
ret

and asserting that they return the correct value:
fn main() {
    let mov_x0_1: u32 = 0x200080D2; // MOV x0, #1
    let mov_x0_2: u32 = 0x400080D2; // MOV x0, #2
    let ret: u32 = 0xC0035FD6; // RET
    let mut mmap = memmap2::MmapMut::map_anon(8).unwrap();
    mmap[4..8].copy_from_slice(&ret.to_be_bytes());

    for i in 0..100 {
        // Build and execute a function that should return 1
        mmap[0..4].copy_from_slice(&mov_x0_1.to_be_bytes());
        let mmap_exec = mmap.make_exec().unwrap();
        let f: unsafe extern "C" fn() -> u32 = unsafe {
            std::mem::transmute(mmap_exec.as_ptr())
        };
        assert_eq!(unsafe { f() }, 1);
        mmap = mmap_exec.make_mut().unwrap();

        // Build and execute a function that should return 2
        mmap[0..4].copy_from_slice(&mov_x0_2.to_be_bytes());
        let mmap_exec = mmap.make_exec().unwrap();
        let f: unsafe extern "C" fn() -> u32 = unsafe {
            std::mem::transmute(mmap_exec.as_ptr())
        };
        assert_eq!(unsafe { f() }, 2);
        mmap = mmap_exec.make_mut().unwrap();
    }
}

This fails because the icache and dcache are separated, so the modified program written to the buffer will not be used during evaluation.  ARM has a 2013 blog post explaining the issue, which makes me suspect this is not unique to the M1 and will be an issue on any ARM processor.
On macOS, this cache is flushed by sys_icache_invalidate.  For reference, here's a fixed version of this program:

use std::ffi::c_void;

#[link(name = "c")]
extern "C" {
    fn sys_icache_invalidate(start: *const std::ffi::c_void, size: usize);
}

fn main() {
    let mov_x0_1: u32 = 0x200080D2; // MOV x0, #1
    let mov_x0_2: u32 = 0x400080D2; // MOV x0, #2
    let ret: u32 = 0xC0035FD6; // RET
    let mut mmap = memmap2::MmapMut::map_anon(8).unwrap();
    mmap[4..8].copy_from_slice(&ret.to_be_bytes());

    for i in 0..100 {
        // Build and execute a function that should return 1
        mmap[0..4].copy_from_slice(&mov_x0_1.to_be_bytes());
        unsafe {
            sys_icache_invalidate(mmap.as_ptr() as *const c_void, mmap.len())
        };

        let mmap_exec = mmap.make_exec().unwrap();
        let f: unsafe extern "C" fn() -> u32 =
            unsafe { std::mem::transmute(mmap_exec.as_ptr()) };
        assert_eq!(unsafe { f() }, 1);
        mmap = mmap_exec.make_mut().unwrap();

        // Build and execute a function that should return 2
        mmap[0..4].copy_from_slice(&mov_x0_2.to_be_bytes());
        unsafe {
            sys_icache_invalidate(mmap.as_ptr() as *const c_void, mmap.len())
        };

        let mmap_exec = mmap.make_exec().unwrap();
        let f: unsafe extern "C" fn() -> u32 =
            unsafe { std::mem::transmute(mmap_exec.as_ptr()) };
        assert_eq!(unsafe { f() }, 2);
        mmap = mmap_exec.make_mut().unwrap();
    }
}

I'm not totally sure of the right fix here!
Adding a call to sys_icache_invalidate (and the Linux equivalent) will fix the issue, but that's is not the recommended way of doing W^X on macOS:
Porting Just-In-Time Compilers to Apple Silicon suggests creating the region with both PROT_WRITE, PROT_EXEC, and the MAP_JIT flag, then using pthread_jit_write_protect_np to modify write-protection on a per-thread (?!) basis.
This would be a significant change from the common unix codebase!

Are you sure this should be handled by this crate and not the caller? I mean, memmap2 is unsafe by design. It's just a thin cross-platform API wrapper. We do not provide any logic beyond that.

That's a fair question!
I expected make_exec (which is not unsafe) to do everything necessary to make the anonymous map usefully executable; it's not doing so, which is why I considered this a library issue.
Still, I understand your point of view.  If you want to leave the crate as-is, should I open up a PR to the make_exec docstring warning about this corner case?

I think doc comment would be fine. I'm not an expert in this area and I'm not sure there is an easy solution. This crate is just an abstraction over the system API. Nothing more.


Certificate for private sector?

Is it possible create a certificate for provate sector?
I'm trying without docker. I changed "spid_sector" to private in spid_public.conf but I always obtain the following error:
problem creating object organizationIdentifier=<IP_ADDRESS>
error:08064066:object identifier routines:OBJ_create:oid exists:crypto\objects\obj_dat.c:698:

Management of private sector certificates is still a work in progress feature. Anyway, according to Avviso SPID n.29, certificates for private sector can not be self-signed.
About the error you're referring to, it is related to double definition of organizationIdentifier. In recent OpenSSL versions, it's already defined. The error can be fixed by commenting the definition within *.conf files.


[FLINK-9332][TableAPI & SQL] Fix Codegen error of CallGenerator

What is the purpose of the change
Fix bugs that nullTerm do not handle function call return value correctly.
Brief change log

check function call return value and reset nullTerm if necessary.

Verifying this change
This change added tests and can be verified as follows:
org.apache.flink.table.runtime.stream.sql.SqlITCase#testNullableFunctionCall
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency):  no
The public API, i.e., is any changed class annotated with @Public(Evolving):  no
The serializers:  no
The runtime per-record code paths (performance sensitive):  no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector:  no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? no

Merging


Check if .git directory exists before finding the git exe

When building from a tarball, there will be not a .git dir.
So any git operations will not be valid.  So check for the
.git directory before doing any git operations.

Patch also used in opae-rpm here
https://github.com/trixirt/opae-rpm/commit/3fbb57c0e8c4586ee285a7e6afcfbceaec9c1f7e

Coverage remained the same at 81.185% when pulling 4abac9a8f65b1985e2459fc0f54a5430f14e6c6b on trixirt:trix/master/cmake_git into ee78b3cd688dc034ed4ab4eb7a73698b67cd429a on OPAE:master.


Log successful and failed login attempts

Description:
This is basically the same feature which was introduced with #1558. Instead of only showing:
16-06-21 21:31:35 INFO (WSGI-server) [homeassistant.components.http] <IP_ADDRESS> - - [21/Jun/2016 21:31:35] "GET /api/bootstrap HTTP/1.1" 200 14754 0.001991

and
16-06-21 21:51:35 INFO (WSGI-server) [homeassistant.components.http] <IP_ADDRESS> - - [21/Jun/2016 21:51:35] "GET /api/bootstrap HTTP/1.1" 401 186 0.001866

There will be a human-readable log entry with the source additionally to the 200/401 HTTP message.
16-06-21 21:31:35 INFO (WSGI-server) [homeassistant.components.http] Successful login from <IP_ADDRESS>

or
16-06-21 21:51:35 WARNING (WSGI-server) [homeassistant.components.http] Login attempt with an invalid password from <IP_ADDRESS>

Example entry for configuration.yaml (if applicable):
http:

Checklist:
If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Looks good. Can be merged when linting error addressed 🐬

I only realize now that this adds a lot of logging. I wonder if we should reduce the visibility of the logging? Although, that might also not be useful. I don't know.

I wonder if it would be better to add a config option so this could be turned off?

Perhaps we should get rid for the additional log entries for 200 responses. One would still be able to spot easily failed login attempts and the entry for 200 responses only need a little more parsing if those details matters.

Another option would be to default the http component logging to a higher level, like warning. To be honest I keep mine at critical
@philhawthorne to turn off/down you can try this
logger:
  logs:
    homeassistant.components.http: critical

The logging trick works but we shouldn't be broken (or spamming) by
default.
On Wed, Jun 29, 2016, 07:41 Johann Kellerman<EMAIL_ADDRESS>wrote:

Another option would be to default the http component logging to a higher
level, like warning. To be honest I keep mine at critical
@philhawthorne https://github.com/philhawthorne to turn off/down you
can try this
logger:
logs:
homeassistant.components.http: critical
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/2347#issuecomment-229377508,
or mute the thread
https://github.com/notifications/unsubscribe/ABYJ2vGwhW8xy_DW4RJuNt4CGHh3hhccks5qQoQigaJpZM4I7HkD
.

New CherryPy wsgi server doesn't print any url so we could print the url
retrieved and include if we authenticated successfully
On Wed, Jun 29, 2016, 09:07 Paulus Schoutsen<EMAIL_ADDRESS>wrote:

The logging trick works but we shouldn't be broken (or spamming) by
default.
On Wed, Jun 29, 2016, 07:41 Johann Kellerman<EMAIL_ADDRESS>wrote:

Another option would be to default the http component logging to a higher
level, like warning. To be honest I keep mine at critical
@philhawthorne https://github.com/philhawthorne to turn off/down you
can try this
logger:
logs:
homeassistant.components.http: critical
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/2347#issuecomment-229377508,
or mute the thread
https://github.com/notifications/unsubscribe/ABYJ2vGwhW8xy_DW4RJuNt4CGHh3hhccks5qQoQigaJpZM4I7HkD
.