Re-indenting of block comments doesn't handle blank lines.

https://github.com/swiftlang/swift-format/pull/791 doesn't seem to handle a blank line in the block comments, i.e. -
        /* Comment

           Comment after blank */

        /*
           Comment

           Comment after blank
         */

It looks like this is inserting the leading whitespace on the blank lines rather than leaving the blank lines completely blank. And that whitespace then gets flagged as something that should get fixed.

Synced to Apple’s issue tracker as rdar://136589486


Add contributors section

Hi team 🖖
I just updated the contributors section in README.md. I hope you like it. You can customize it on this page. The image is dynamic and updates every 24 hours.

PS: I'm the owner of MarkupGo.

@abdullah I love this! If you decide to re-open, I'd happily take it 😄

Ah @brooksmtownsend you are so nice 😊 re-opened the PR. ♥

@abdullah I think you will need to rebase this to "sign off" which is required for us as a CNCF project, the Details section next to the DCO check will let you know how:
git rebase HEAD~1 --signoff
git push --force-with-lease origin main

Did you close originally for any issue I should be aware of?

Thanks, @brooksmtownsend. I just force-pushed the commit with a verified one!

Did you close originally for any issue I should be aware of?

Actually, no. I opened a similar PR for the project, and they didn’t welcome my PR because they considered it spamming. So, I decided not to bother this project too and closed this PR. ☺

Ah okay. I know different projects have different attitudes to out-of-the-blue PRs, I can understand the reluctance in a world of AI things

Just a note I went ahead and amended the commit message to make our lint-cc bot happy, should merge!


Add SBOM to release

Is your feature request related to a problem? Please describe.
Currently, we do not have an SBOM attached to the release of Kepler. Having one attached will help us identify what components we have if there was a vulnerability in one and also help adopters with securing their software supply chain.
A software bill of materials (SBOM).  is a list of all the open-source and third-party components present in a codebase. An SBOM also lists the licenses that govern those components, the versions of the components used in the codebase, and their patch status, which allows security teams to quickly identify any associated security or license risks.
Describe the solution you'd like
We can easily put an additional step on the release.yml to attach the SBOM to the release, not changing or breaking anything.
I'm happy to do this work.

@bradmccoydev thanks , assigned to you just now
@marceloamaral @rootfs FYI a good improvement to kepler

@bradmccoydev and @jichenjc sounds like a good plan!
It is also important to establish some recommendations for defining the best way to handle code updates.

Cool!
is there any SBOM which able to support both docker/container and binary?

Hello, I have finished my testing on this and it worked fine. I have made the PR


org.apache.dubbo.remoting.exchange.support.DefaultFuture doWithCloseChannel will logRequestData

[x] I have searched the issues of this repository and believe that this is not a duplicate.
[x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version:  2.7.14-SNAPSHOT
Operating System version: Win10
Java version: JDK8

Actual Result
打印出来的日志带有请求toString的内容
 public static void closeChannel(Channel channel) {
        for (Map.Entry<Long, Channel> entry : CHANNELS.entrySet()) {
            if (channel.equals(entry.getValue())) {
                DefaultFuture future = getFuture(entry.getKey());
                if (future != null && !future.isDone()) {
                    Response disconnectResponse = new Response(future.getId());
                    disconnectResponse.setStatus(Response.CHANNEL_INACTIVE);
                    disconnectResponse.setErrorMessage("Channel " +
                            channel +
                            " is inactive. Directly return the unFinished request : " +
                            // 这个方法会打印整个 request 对象toString的值
                            future.getRequest());
                    DefaultFuture.received(channel, disconnectResponse);
                }
            }
        }
    }

timeout打印的请求对象是不带有Request的
    private String getTimeoutMessage(boolean scan) {
        long nowTimestamp = System.currentTimeMillis();
        return (sent > 0 ? "Waiting server-side response timeout" : "Sending request timeout in client-side")
                + (scan ? " by scan timer" : "") + ". start time: "
                + (new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS").format(new Date(start))) + ", end time: "
                + (new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS").format(new Date(nowTimestamp))) + ","
                + (sent > 0 ? " client elapsed: " + (sent - start)
                + " ms, server elapsed: " + (nowTimestamp - sent)
                : " elapsed: " + (nowTimestamp - start)) + " ms, timeout: "
                + timeout + " ms, request: " + (logger.isDebugEnabled() ? request : getRequestWithoutData()) + ", channel: " + channel.getLocalAddress()
                + " -> " + channel.getRemoteAddress();
    }

这个是漏加了吧

I'll fix it later.


ARM Architecture not supported

TL;DR
ARM Architecture not supported
Expected behavior
Docker container to run with ARM based architecture
Observed behavior
Docker container does not run with ARM based architecture
Debug log output
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

### Additional information

_No response_

Hi @igoooor
Docker multi-build doesn't seem to be well-supported, and there hasn't been much demand. I'll accept a community contribution for this feature, but it's not a core priority for the project right now.


[java] enable RASP SQLi tests

Motivation
APPSEC-54578
Changes

Set RASP SQLi tests to v1.39.0. This was released in v1.38.0, disabled by default, but was flaky. Effectively, we'll want to consider v1.39.0 the first release with RASP SQLi support.
Enable all tests for RASP SQLi in Java.

Workflow

⚠ Create your PR as draft ⚠
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist

[ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
[ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
[ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
[ ] A docker base image is modified?

[ ] the relevant build-XXX-image label is present

[ ] A scenario is added (or removed)?

[ ] Get a review from R&P team

Updated the PR, actually meant for merge now (after changing minimum version).


Update Invoice and SendMixin Classes

Updated the Invoice class to include an AllowOnlineCreditCardPayment attribute (defaults to False), and also updated the SendMixin class to url encode input emails

Coverage decreased (-0.4%) to 95.116% when pulling 3a2b10d6ae310a081cd8c6f8e8b2212a41f92443 on EquityZen:master into 5cc7415a413718229a2f08d4472841652c72b073 on sidecars:master.


[Feature Request] Be able to disable the warning in standalone mode

Hello,
Is your feature request related to a problem? Please describe.
In standalone mode, we would like to be able to hide the warning message: Warning: NeoDash is running with a plaintext password in config.json.

Describe the solution you'd like
Have a setting somewhere to disable/enable the warning. It can be enabled by default.
Best regards,
Cobra

We intend to take this up shortly (maybe in 2 weeks time). Stay tuned!

Some delay on this from our end - I think it'll be a few more weeks (1-1.5 months) before we can get to it.

+1 would like to see this feature too

Any news on this feature?

You can now add the parameter "standalonePasswordWarningHidden": true in the latest version of NeoDash so I close the request.


Unauthorized error in Maven private parent resolution since JFrog CLI 2.33.0

Describe the bug
Since version 2.33.0 I have 401 error when I execute jf mvn compile command for a maven project with private parent in it's pom
Current behavior
jf mvn -B compile -Dmaven.test.skip -Dstyle.color=always -Dartifactory.publish.artifacts=false
[Info] Downloading build-info-extractor from https://artefact-repo.titi.net/artifactory/maven-public/org/jfrog/buildinfo/build-info-extractor-maven3/2.39.0/build-info-extractor-maven3-2.39.0-uber.jar
[Info] Running Mvn...
[main] INFO org.apache.maven.cli.event.ExecutionEventLogger - Scanning for projects...
[main] INFO org.apache.maven.cli.transfer.Slf4jMavenTransferListener - Downloading from artifactory-snapshot: https://artefact-repo.titi.net/artifactory/maven_02608/com/parent/apiiv-parent/1.0.2-SNAPSHOT/maven-metadata.xml
[main] WARNING org.codehaus.plexus.PlexusContainer - Could not transfer metadata com.parent:apiiv-parent:1.0.2-SNAPSHOT/maven-metadata.xml from/to artifactory-snapshot (https://artefact-repo.titi.net/artifactory/maven_02608): Authentication failed for https://artefact-repo.titi.net/artifactory/maven_02608/com/parent/apiiv-parent/1.0.2-SNAPSHOT/maven-metadata.xml 401 Unauthorized
[main] INFO org.apache.maven.cli.transfer.Slf4jMavenTransferListener - Downloading from artifactory-snapshot: https://artefact-repo.titi.net/artifactory/maven_02608/com/parent/apiiv-parent/1.0.2-SNAPSHOT/apiiv-parent-1.0.2-SNAPSHOT.pom
[main] ERROR org.apache.maven.DefaultMaven - [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for titi.gpf.eul.02608:HelloWorld:1.1.2017-SNAPSHOT: Could not transfer artifact com.parent:apiiv-parent:pom:1.0.2-SNAPSHOT from/to artifactory-snapshot (https://artefact-repo.titi.net/artifactory/maven_02608): Authentication failed for https://artefact-repo.titi.net/artifactory/maven_02608/com/parent/apiiv-parent/1.0.2-SNAPSHOT/apiiv-parent-1.0.2-SNAPSHOT.pom 401 Unauthorized and 'parent.relativePath' points at wrong local POM @ line 28, column 13

Reproduction steps
In the root pom.xml of a project add a parent declaration like this :
    <parent>
      <groupId>my.company</groupId>
      <artifactId>my-parent</artifactId>
      <version>1.0.0-SNAPSHOT</version>
  </parent>

The parent pom.xml is in the private virtual repository use by the project (name my_virtual).
Then execute the commands (with jf cli >= 2.33.0) :

jf config add...
jf mvn-config --repo-resolve-releases my_virtual --repo-resolve-snapshots my_virtual
jf mvn compile -Dartifactory.publish.artifacts=false

Expected behavior
that jf mvn command resolve the private parent dependency (ok with versions before 2.33.0).
JFrog CLI version
from 2.33.0 to 2.34.2
Operating system type and version
Ubuntu
JFrog Artifactory version
7.41.7
JFrog Xray version
3.55.2

Hi,
Is someone have an idea of the cause ?
In my company we are facing this issue and due to this another issue : https://github.com/jfrog/build-info/pull/706 it is currently not possible to use jfrog cli with maven 3.9.0 for maven project with a parent on a private repository

It's ok with 2.34.6 releases, thanks !


please add tag for version 2.0.0

Latest version in npm registry is 2.0.0 but github tag is missing for this release.

Done!


User access removed, access is now via a team

Hi there
The user carwynmoj had Direct Member access to this repository and access via a team.
Access is now only via a team.
You may have less access it is dependant upon the teams access to the repo.
If you have any questions, please post in (#ask-operations-engineering)[https://mojdt.slack.com/archives/C01BUKJSZD4] on Slack.
This issue can be closed.

Thanks for taking a look at this. I was going to clean up the user config after setting up the repo but you got there before me.


RabbitMQ reconnect causes multiple connections to be created

The reconnecting triggered after the RabbitMQ channel is closed will cause the client side and server level to maintain multiple connections simultaneously.
When chanNotifyClose receives an error, the RabbitMQ connection isn't closed. It immediately establishes a new connection and subsequently recreates a channel based on this new connection.
https://github.com/go-micro/plugins/blob/bc05fb076ce7165ca58cd960008407f42d8bbb23/v4/broker/rabbitmq/connection.go#L161
This can result in the client and server simultaneously holding both old and new connection resources. In this scenario, we can either manually close the old connection before reconnecting or reuse the existing connection resources.

Can I submit a merge request to fix it?


Add intermediary ERB file to generate active sidebar classes

This commit improves page generation performance by generating the
sidebar once, including it in each page and handling active classes
based on the current page; as opposed to the sidebar being generated
with active classes by looping through the list of documents for each
page.
When the Gluegun commands are run, the _sidebar-template.erb file loops
through the list of documents once and generates the _sidebar.erb file
which contains the hardcoded sidebar with the conditionals that check
if the given sidebar item/category should have active classes. The
_sidebar.erb file is included on the beginning of the _header.erb file.

One minor comment is the generate docs must be viewable locally without being hosted.

@deekoder @kaankabalak Before the doc file generation process, I think it's better to remove the already generated 'doc' folder if exists in order to get rid of any leftover files which are not part of the current process.

@deekoder, I will submit a fix for that issue shortly.
@rushenn, I agree with you that we should remove the "doc" folder that is already generated before generating a new one, as I think that it is confusing for the users.

@deekoder @rushenn Submitted fix for docs not being viewable locally on click and first link not being active on index.html when the slug for the first page wasn't entered, would appreciate if you could take another look.


Separate builds for CI binaries using build tags

Since we are adding new commands to CLI, the size of the binary is constantly increasing. This reflects in the case when the users pull the CLI binary in their CI systems as the time to pull the binary increases. Thus, creating a separate binary on every release that will be served if the environment is a CI system is the need.

Working on this.

The size of the package is still considerably small.  Does not make sense to add this complexity in the build.


Switch to use android library plugin

This branch is to migrate the SDK to use android-library-plugin to decouple with non-Android Java. Since it's not backward compatible, it will be a major version bump to v3.0.0.

gradlew files are added so Gradle wrapper is used for compile.
Minor fix for BoundingBoxOptions.java to add default Locale.
Add changelog file.
Bump auto-value version to 1.2.
Bump jackson-dataformat-yaml version to 2.7.2.

ShipIt


feat: add boost test, lexical_cast, phoenix

as title
need skip url stability check

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (boost.lexical_cast, boost.phoenix, boost.test) have been updated in this PR. Please review the changes.


[Bug]: Gemini with prompt caching fails

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Describe the bug and reproduction steps
Gemini with prompt caching fails with an exception:
litellm.APIConnectionError: GeminiException - Gemini Context Caching only supports 1 message/block of continuous messages. Your idx, messages were - [(0, {'content': [{'type': 'text', 'text': 'A chat between a curious user and an artificial intelligence assistant. The assistant gives helpful, detailed answers to the user\'s questions.\n\n[1] The assistant can use a Python environment with <execute_ipython>...

Gemini is reported by liteLLM to support prompt caching, along with Claude, GPTs, and Deepseek. Unlike those though, this isn't automatic (ignoring silently the cache attribute), nor compatible with Anthropic.
OpenHands Installation
Development workflow
OpenHands Version
No response
Operating System
None
Logs, Errors, Screenshots, and Additional Context
No response

This is not failing on the current main, because we again changed how we do this in the agent: now we only use prompt caching for Anthropic.


Template string with special character are getting inappropriately autofix to quoted string

<input placeholder={`line1\nline2`} ></input> gets autofix into
<input placeholder="line1\nline2" /> which treats the \n literally.
Versions:
"eslint-config-airbnb": "^16.0.0",
"eslint-plugin-import": "^2.7.0",
"eslint-plugin-jsx-a11y": "^6.0.2",
"eslint-plugin-react": "^7.4.0"

cc @jackyho112

@ljharb Thanks for tagging me! I think this bug will be fixed in https://github.com/yannickcr/eslint-plugin-react/pull/1458/files#diff-a9ba802868aa552c39802228bac37c08R174 because with the new update, the rule will identify the backslash and bail out instead of incorrectly fixing the code.


fix(esm): re-export in esm build

Hey there @Annoraaq
I'm sorry but I've just now realized that the previous PR wasn't fully addressing the export of additional PathStrategies. I didn't see the way how you're constructing your ESM bundle so I thought while at it also export the other string enums.
I've just realized this once trying out the build with vite as bundler which is taking the esm dependency as preferred solution.

Oh good catch! I did not think about this as well.


No formattting when I do Ctrl+Shift+I

I just get a message saying "no document formatter for 'solidity'-files installed."

@Rpittrer there is none implemented.

@juanfranblanco Are there plans to implement a formatter? Maybe in some simple form for starters, just to fix indentation?

I am hoping the solium linter to provide fixing for indentation, this is rather complex, so I may do it for in vscode. @quezak


Support "test/plan require UEFI" requirement

As suggested in https://gitlab.com/testing-farm/artemis/-/issues/175, one might develop tests that work only with UEFI machines, or machines that do not possess this feature. To me, the idea sounds like an HW requirement whose place is in L1/L2 metadata, therefore something for TMT to specify.
No idea where to put this field, whether as a top-level key (hardware.uefi: true) or nest it under some key (hardware.boot.uefi: true). I guess it makes sense to mention the importance of uefi: false, because, once people begin to request UEFI machines, I'm pretty sure they will request machines that absolutely do not, under no circumstances, support UEFI :)
Or as an enum? hardware.bios: bios|uefi|.... IIUIC, it's not just about the boot alone, there are other features BIOS/UEFI provide, but maybe hardware.boot: bios|eufi would make sense as well.
Anyway, there's a user need, and before implementing the support for it, it would be nice to hear ideas and opinions and get a place in specification.

yeah, I like hardware.boot: bios|uefi more ...
Note that also Automotive QE are interested in this, and seems AWS has some support, what is great:
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ami-boot.html

after discussion, seems it would be good to think about future extensibility, thus:
hardware:
    boot:
        method: uefi | bios

So I will open a PR for this. Any mode ideas welcomee

Just for the record - leapp team is also very-very interested in this feature :)

FYI Fedora images should be now compatible with both firmwares: https://fedoraproject.org/wiki/Changes/FedoraCloudHybridBoot

hardware:
    boot:
        method: uefi | bios

yes, on POWER we will need to select between OpenFirmware and PowerNV (although boot may be a bit misnamed, because firmware selection is not just about booting...)

@pcahyna, so do you suggest to use a better name for the section instead?

@psss it may be ok after all. I suppose for PowerVM vs. PowerNV one should rather use the hypervisor field, if it is going to exist (like in Beaker, <hostRequires><system><hypervisor op="==" value=.../></system> </hostRequires>). At the end, the question is, what is the field going to represent and how it will be used. Let me think whether there is a similar distinction like EFI vs. BIOS on other architectures.

For the features related to virtualization there is already outlined a virtualization section:
virtualization:
    is-virtualized: true
    is-supported: false
    hypervisor: kvm


Atom Helper crashed

Prerequisites

[ ] Can you reproduce the problem in safe mode?
[x] Are you running the latest version of Atom?
[x] Did you check the debugging guide?
[x] Did you check the FAQs on Discuss?
[x] Are you reporting to the correct repository?
[x] Did you perform a cursory search to see if your bug or enhancement is already reported?

Description
i normally used the editor, placed the cursor on another line with the mouse, than it hangs and finally crashed. the bad thing is that my unsaved documents are lost, but the saved ones are fine. i hope the crash report helps.
https://davidak.basecom.de/paste/?697ce85863f6f098#iP9oxwL1DMHNgVjipgp7EYIKiq3u9fqJbYcnkKY03ck=
from system log:
Jul 26 11:50:53 unibook-2.local Atom[10849]: XPC error messaging com.apple.IconServicesAgent: Connection interrupted
Jul 26 11:50:53 unibook-2.local Atom[10849]: XPC error messaging com.apple.IconServicesAgent: Connection invalid
Jul 26 15:29:26 unibook-2.local ReportCrash[30557]: Saved crash report for Atom Helper[10854] version 1.8.0 (1.8.0) to /Users/davidak/Library/Logs/DiagnosticReports/Atom Helper_2016-07-26-152926_unibook-2.crash
Jul 26 15:30:36 unibook-2.local Atom[30629]: App load time: 561ms
Jul 26 15:47:13 unibook-2.local Atom[30629]: Cannot read property 'length' of undefined
Jul 26 15:47:13 unibook-2.local Atom[30629]: TypeError: Cannot read property 'length' of undefined
	    at AtomApplication.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/browser/atom-application.js:707:40)
	    at AtomApplication.module.exports.AtomApplication.openPaths (/Applications/Atom.app/Contents/Resources/app.asar/src/browser/atom-application.js:712:10)
	    at /Applications/Atom.app/Contents/Resources/app.asar/src/browser/atom-application.js:1040:24
	    at Function.wrappedCallback (/Applications/Atom.app/Contents/Resources/atom.asar/browser/api/lib/dialog.js:78:14)

Steps to Reproduce
happened only once
Expected behavior:
stable textedior
Actual behavior:
crash, data loss
Versions
Atom    : 1.8.0
Electron: 0.36.8
Chrome  : 47.0.2526.110
Node    : 5.1.1
apm  1.9.2
npm  2.13.3
node 0.10.40
python 2.7.9
git 1.9.5
OS X 10.9.5

Noticed the same behavior on 1.9 beta1 atom helper related crash! Unsaved documents unrecoverable. I love this editor, but losing data in a text editor is so 90s. This has to be fixed.

Similar thing (I guess) happened to me yesterday. I saved multiple big .js files quickly one after another. Atom crashed, and after reloading one of the .js files was suddenly empty, and saved like that. I've completely lost all of the contents of the file, and couldn't get it back, even in Time Machine backup the file was empty.
Atom version: 1.8.0
OS and version: OS X 10.11.5
Installed packages:
color-picker
minimap
Additional information:
Crash report: http://pastebin.com/cbLuDRPC

Problem can be reproduced in safe mode: I don't really want to try to reproduce it.
Problem started happening recently, didn't happen in an older version of Atom: [Yes]
Problem can be reliably reproduced, doesn't happen randomly: [No]
Problem happens with all files and projects, not only some files or projects: Don't know

Happened again with de.txt (289659 lines).
steps to reproduce:

download und unpack de-2011.zip (1,7 MB)
open de.txt in Atom
"Find in Buffer"
"Use Regex"
try to type " [0-9]+", it will crash
if that might work, hit "Replace All", it will crash!

crash report:
https://davidak.basecom.de/paste/?6d4487da3241e84b#FTzpkeXora1jJAoeHgsTeig+whGIfb2vSEKvDsxfp4g=
PS: Click "Keep It Open" to not loose data in other Atom windows!
PPS: Works in Sublimetext 2, also the file loads a lot faster and scrolling is very smooth.

a process crashed after high RAM usage for some hours, editor still works.

https://davidak.basecom.de/paste/?57a5547d8a4f0d86#toGHJvQ429+U8GRnhfRU4ALNFhbh3vnul1y9wqUvHBc=

and again one atom window crashed while scrolling through a 4.6 MB file.
https://davidak.basecom.de/paste/?0fcc4af950bd3518#kSkLy7SbQYC2JIbObxEI1NYJEtCPF9i1T3Da3dho3lw=
please do something, this is a serious problem. maybe rewrite it in rust or go :P

you can always fork!   OpenSource++ BitchLess++


chore: removes unused js events

Description
Tracking of certain user actions tend to pollute our Mixpanel dashboard instead of providing meaningful insights. The following Mixpanel events add very little value and hence should be removed immediately:
CONSOLE_LOG_CREATED
AUTO_COMPLETE_SHOW
Fixes #31728
Automation
/ok-to-test<EMAIL_ADDRESS>@tag.JS, @tag.Binding"
:mag: Cypress test results

[!IMPORTANT]
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8281028348
Commit: 4f1502191d03a5476473a1c911e011e3ad8ad1df
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

Summary by CodeRabbit

Refactor

Enhanced privacy by removing specific analytics logging for user-generated events.

Chores

Updated analytics event types by removing unused events.

tested:

adding statement in js function console.log("hi")
added input widget and tried referencing it via auto complete in js function

in both cases, there were no changes in experience and no errors on browser console.


fix(interactive): Fix Bugs of Group Returning Results from Compiler

What do these changes do?
Group Returning Results are split into multiple maps in user scenarios, for the query which results size is larger than 64 can trigger the issue, i.e.
gremlin> g.V().hasLabel('PERSON').limit(100).group().by('firstName').by(count())
==>{Dặng Dinh=1, Carey=1, Michel=1, Wojciech=1, Ayesha=2, Anand=2, Franz=1, Volodymyr=1, Maria=1, Fritz=1, Jie=1, Kunal=1, Aditya=1, Mikhail=1, Milan=1, Serghei=1, Neil=1, Shweta=2, Walter=1, Arturo=1, Rahul=2, Barney=1, Peter=2, Evgeny=1, Charlie=1, Bing=1, Bob=1, Pope=1, Wilson=1, Arjun=1, Antonio=3, Carlos=2, Dania=1, André=1, K.=2, Crown Prince=1, Li=1, Karl=1, Gabriel=1, Javed=1, Michael=1, Asim=1, James=1, Alexander=2, Bela=1, Chipo=1, Philippe=1, Jun=2, Andry=1, Wei=2, Bingbing=1, Andrew=1, Yang=2, Abdala=1, Hao=1, Aa Ngurah=1, Mohammad Reza=1, Eddie=1, Luis=1, Lei=1, Zheng=1, Giuseppe=1, Dhafer=1, David=1}
==>{John=3, Ricky=1, Peng=1, A.=1, Ivan=1, Abdel Wahab=1, Chen=4, Sam=1, Boris=1, Mario=1, Lin=1, Paresh=1, Jose=1, Fernando=1, Almira=1, Abraham=1, R.=1, Ai=1}

This pr mainly fix the issue.

Related issue number

Fixes

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9228223) 48.81% compared to head (3e53c18) 27.89%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3533       +/-   ##
===========================================
- Coverage   48.81%   27.89%   -20.93%
===========================================
  Files         177      176        -1
  Lines       16198    16168       -30
===========================================
- Hits         7907     4510     -3397
- Misses       8291    11658     +3367

see 61 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9228223...3e53c18. Read the comment docs.


Added methods for registering a user as local/remote user

I.e. registration on the robot controller (e.g. can be useful with robot controllers in Manual mode). Also minor cleanup of the code

@jontje: feel free to merge.


Whitelist react-native-maps

The type definitions for react-native-maps are required by @types/expo.
Pull request for @types/expo where this is needed.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: janaagaard75 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Any news about this pull request? The pull request that I mentioned, https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30737, was closed because I was too slow to react to a closure warning, but once this PR has been merged, I will recreate the PR for DefinitelyTyped.

Sorry I didn't notice this. I hadn't set up this repo to ping me when PRs are opened.
Is there a reason you re-ordered the whitelist in addition to adding react-native-maps?

Is there a reason you re-ordered the whitelist in addition to adding react-native-maps?

Only that the mostly alphabetically sorted list triggered my OCD. 🙂

In retrospect, I should have known the answer to myquestion. 😸


⚠ API - Lens has degraded performance

In 9e12dea, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 597 ms

Resolved: API - Lens performance has improved in 44df96f after 6 minutes.


Ready Attack Stalling

In the past I realize there have been situations where the AI would stall for a bit and then resume as normal.
For the combat I'm currently in, if I ready an attack for more than 1 character then the AI stalls indefinitely. I tested this out, to make sure it wasn't just taking a long time and would then resume, by giving it about 30 mins while I went to go do something else.
Is there a workaround for this (other than just not readying an attack on more than one character)? It could be something more specific but I'm not sure. If this isn't a known issue and there is no true workaround, I can attach a save file.

Is this something you could try to reproduce on a save without the mod installed? We don’t touch AI at this level in the mod. Max we do is create new brains on very specific spell scenarios.

Sure I can try to reproduce it w/out the mod. Question first though: will not having the mod installed mess up any premade characters that were made w/ the mod?

Further update. The issue is not necessarily with multiple people readying an attack for one enemy. The issue is the readied attack triggering from more than one character for a single enemy, while they are in the same spot.
Ex. If the enemy triggers one readied attack then moves forward 1 space to trigger another, there is no issue. Only stalls if triggered from the same space.
It's sounding more like this is something related to a base game engine issue.

@EnderWiggin , you have more experience with ready attacks. Would our extensions to allow/force cantrips be part of the problem?

I've had numerous combats where multiple PCs have readied attacks and hit the same target with all of them without the target moving.  I'm only using .32 (I haven't played in a week(ish), but I've never had it stall for more than 10-15 seconds after the first readied attack.  As a matter of fact, the most I get stalls currently is when I quicken a spell and then attack with a cantrip (usually Eldritch Blast, because I almost always multi-class my Sorcerer with a few levels of Warlock for the Sorcery Point burn)

That's amount of time is more typical for me too. This is definitely an outlier situation.

I was able to get a save with the soft lock after first ally ready an attack.

ReadyActionSoftLock.zip

fixed


Doesn't work in React Native 0.14.0-rc?

I haven't been able to get the package to work in 0.14.0-rc (trouble with RCTAdSupport)
Is this just me or is it a problem for others too?
p.s. it's currently working for me in 0.13.0

Hmm. Obviously I'm not supporting release candidates - but please let me know if this issue persists when the final version comes out. For now, can you explain more in detail what issue is arising with the RCTAdSupport module?

Hi, the problem persists also in the final version 0.14.0. A Build process in XCode ends with: Command /bin/sh failed with exit code 1, and there is an error: uncaught error Error: UnableToResolveError: Unable to resolve module AdSupportIOS from ./node_modules/react-native-google-analytics/lib/Tracking.js: Invalid directory /Users/node_modules/AdSupportIOS ... please check it out. thx.


Handle custom-image in case of version checks

Description
Incase a custom image is used for the OneAgent DaemonSet, then we set the Version and Source in the Dynakube's Status to the custom-image constant.
Our version checks didn't handle this, now they do.
Also flipped the proxy env version check, so if we don't know the version then we don't use the deprecated proxy envvar.

This was decided to be consistent with the HealthConfig logic.

Furthermore the HealthConfig version check is checking for a newer version.

If we don't want to do this, then IMO we need to make the HealthConfig logic to consistent with it.

How can this be tested?
In case the oneAgent.image field is set to something, everything works
Checklist

[x] Unit tests have been updated/added
[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2c7f395) 67.72% compared to head (fe59df8) 67.70%.
Report is 1 commits behind head on release-1.0.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.0    #2676      +/-   ##
===============================================
- Coverage        67.72%   67.70%   -0.03%
===============================================
  Files              250      250
  Lines            13616    13637      +21
===============================================
+ Hits              9222     9233      +11
- Misses            3590     3594       +4
- Partials           804      810       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


how to remove or hide decimal place

HI ,
i have to show count as Y axis but it accepting only double instead of int , so its showing decimal place as show in image , so how to remove the decimal place as i need to show count value
Like 51  76   instead of 51.0 76.0

You can use barTouchData->BarTouchTooltipData properties and describe your own format with getTooltipItem

Yes that's right,
Thanks @kdmatrosov


Test and validate mysql 8.x

Test mysql 8.x and formally add support.

@davidnuzik Hi, Could you tell me is there a completion date?

Hi @linyinli there is no date. This item is in the backlog to be picked up later when we review items in the backlog. I cannot provide a date at this time. We do have an interest to test this though, if we have some time free up in a couple of months we may take this on then. It's possible we may be able to validate by the end of the year (no promises).

Unfortunately Digital Ocean Managed MySQL DBs only support MySQL version 8.0. I'd like to use DO Managed MySQL, but k3s apparently doesn't support it yet?

It should work fine. It's tested upstream by kine, just QA hasn't signed off on it yet.
https://github.com/k3s-io/kine/blob/master/scripts/test-run-mysql#L25-L32

Yup, I tested it out on DO and it works fine with 1.24 RC

Closing because this appears to be resolved


Fix warnings Elixir 1.4

warning: variable "package" does not exist and is being expanded to "package()", please use parentheses to remove the ambiguity or change the variable name
scrivener_html/mix.exs:20
warning: variable "deps" does not exist and is being expanded to "deps()", please use parentheses to remove the ambiguity or change the variable name
scrivener_html/mix.exs:21
warning: variable "aliases" does not exist and is being expanded to "aliases()", please use parentheses to remove the ambiguity or change the variable name
scrivener_html/mix.exs:22

Published v1.4.1, thanks!


Improve SDKs for building REST APIs

Building REST APIs is a (very) common use that we want to support with Spin.
Ideally, we want the SDKs to help users build them, and simplify operations such as:

routing based on the HTTP method
extracting path segments
show examples for serialising / deserialising bodies
connect to external data sources

(There is a fine line between reimplementing an entire HTTP framework and basic helper functionality — but we don't want to have to reimplement operations such as manually extracting path segments on every application.)
ref #222

You can generalize this with an IDL model and use code generation to create the required spin stubs. Like this, you stay more generic for other protocols and bindings. For example, you can create spin-specific traits for that in your own package for a Smithy model: https://smithy.io/2.0/guides/using-code-generation/index.html Would that help?


Added Geektime App to showcase

This pull request adds the Geektime mobile app to the React Native showcase.
Geektime is a content publisher, the largest tech blog in Israel and one of the largest tech blogs outside the US. Geektime is a funded Startup (undisclosed amounts) with revenues coming mainly from advertising, sponsorships and reports.
The Geektime app is written entirely in React Native.

Do you have a link to anything that shows Geektime is a funded startup? I just need to make sure this meets the criteria.

I don't have a link, since we haven't announced any funding publicly but we did raise some money so far and still raising our next round of funding. I reached you in a private fb message with more details.

Alright. Can you rebase on top of master? We just updated the way the showcase works.

Thanks for sending this pull request. For consistency the Showcase is now fully managed by the open source team at Facebook and we unfortunately cannot accept more pull requests to it. Feel free to post about the app in the React Native Community group on Facebook to increase visibility.


Creation of cluster fails to start control-plane with: context deadline exceeded

I'm unable to to bootstrap cluster. It isn't obvious to me what causes the failure, so here is almost full output:
$ kind create cluster --name konflux --config kind-config.yaml
enabling experimental podman provider
Creating cluster "konflux" ...
 ✓ Ensuring node image (kindest/node:v1.30.0) 🖼
 ✓ Preparing nodes 📦
 ✓ Writing configuration 📜
 ✗ Starting control-plane 🕹
Deleted nodes: ["konflux-control-plane"]
ERROR: failed to create cluster: failed to init node with kubeadm: command "podman exec --privileged konflux-control-plane kubeadm init --skip-phases=preflight --config=/kind/kubeadm.conf --skip-token-print --v=6" failed with error: exit status 1
Command Output: I0710 17:20:03.702786     132 initconfiguration.go:260] loading configuration from "/kind/kubeadm.conf"
W0710 17:20:03.705887     132 initconfiguration.go:348] [config] WARNING: Ignored YAML document with GroupVersionKind kubeadm.k8s.io/v1beta3, Kind=JoinConfiguration
[init] Using Kubernetes version: v1.30.0
[certs] Using certificateDir folder "/etc/kubernetes/pki"
I0710 17:20:03.721044     132 certs.go:112] creating a new certificate authority for ca
[certs] Generating "ca" certificate and key
I0710 17:20:03.835223     132 certs.go:483] validating certificate period for ca certificate
[certs] Generating "apiserver" certificate and key
[certs] apiserver serving cert is signed for DNS names [konflux-control-plane kubernetes kubernetes.default kubernetes.default.svc kubernetes.default.svc.cluster.local localhost] and IPs [<IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>]
[certs] Generating "apiserver-kubelet-client" certificate and key
I0710 17:20:04.152857     132 certs.go:112] creating a new certificate authority for front-proxy-ca
[certs] Generating "front-proxy-ca" certificate and key
I0710 17:20:04.278687     132 certs.go:483] validating certificate period for front-proxy-ca certificate
[certs] Generating "front-proxy-client" certificate and key
I0710 17:20:04.466347     132 certs.go:112] creating a new certificate authority for etcd-ca
[certs] Generating "etcd/ca" certificate and key
I0710 17:20:04.593205     132 certs.go:483] validating certificate period for etcd/ca certificate
[certs] Generating "etcd/server" certificate and key
[certs] etcd/server serving cert is signed for DNS names [konflux-control-plane localhost] and IPs [<IP_ADDRESS> <IP_ADDRESS> ::1]
[certs] Generating "etcd/peer" certificate and key
[certs] etcd/peer serving cert is signed for DNS names [konflux-control-plane localhost] and IPs [<IP_ADDRESS> <IP_ADDRESS> ::1]
[certs] Generating "etcd/healthcheck-client" certificate and key
[certs] Generating "apiserver-etcd-client" certificate and key
I0710 17:20:05.536090     132 certs.go:78] creating new public/private key files for signing service account users
[certs] Generating "sa" key and public key
[kubeconfig] Using kubeconfig folder "/etc/kubernetes"
I0710 17:20:05.611977     132 kubeconfig.go:112] creating kubeconfig file for admin.conf
[kubeconfig] Writing "admin.conf" kubeconfig file
I0710 17:20:05.688477     132 kubeconfig.go:112] creating kubeconfig file for super-admin.conf
[kubeconfig] Writing "super-admin.conf" kubeconfig file
I0710 17:20:05.891181     132 kubeconfig.go:112] creating kubeconfig file for kubelet.conf
[kubeconfig] Writing "kubelet.conf" kubeconfig file
I0710 17:20:06.083404     132 kubeconfig.go:112] creating kubeconfig file for controller-manager.conf
[kubeconfig] Writing "controller-manager.conf" kubeconfig file
I0710 17:20:06.139208     132 kubeconfig.go:112] creating kubeconfig file for scheduler.conf
[kubeconfig] Writing "scheduler.conf" kubeconfig file
[etcd] Creating static Pod manifest for local etcd in "/etc/kubernetes/manifests"
[control-plane] Using manifest folder "/etc/kubernetes/manifests"
[control-plane] Creating static Pod manifest for "kube-apiserver"
I0710 17:20:06.460519     132 local.go:65] [etcd] wrote Static Pod manifest for a local etcd member to "/etc/kubernetes/manifests/etcd.yaml"
I0710 17:20:06.460560     132 manifests.go:103] [control-plane] getting StaticPodSpecs
I0710 17:20:06.460808     132 certs.go:483] validating certificate period for CA certificate
I0710 17:20:06.460894     132 manifests.go:129] [control-plane] adding volume "ca-certs" for component "kube-apiserver"
I0710 17:20:06.460901     132 manifests.go:129] [control-plane] adding volume "etc-ca-certificates" for component "kube-apiserver"
I0710 17:20:06.460906     132 manifests.go:129] [control-plane] adding volume "k8s-certs" for component "kube-apiserver"
I0710 17:20:06.460911     132 manifests.go:129] [control-plane] adding volume "usr-local-share-ca-certificates" for component "kube-apiserver"
I0710 17:20:06.460916     132 manifests.go:129] [control-plane] adding volume "usr-share-ca-certificates" for component "kube-apiserver"
[control-plane] Creating static Pod manifest for "kube-controller-manager"
I0710 17:20:06.462025     132 manifests.go:158] [control-plane] wrote static Pod manifest for component "kube-apiserver" to "/etc/kubernetes/manifests/kube-apiserver.yaml"
I0710 17:20:06.462047     132 manifests.go:103] [control-plane] getting StaticPodSpecs
I0710 17:20:06.462262     132 manifests.go:129] [control-plane] adding volume "ca-certs" for component "kube-controller-manager"
I0710 17:20:06.462275     132 manifests.go:129] [control-plane] adding volume "etc-ca-certificates" for component "kube-controller-manager"
I0710 17:20:06.462305     132 manifests.go:129] [control-plane] adding volume "flexvolume-dir" for component "kube-controller-manager"
I0710 17:20:06.462311     132 manifests.go:129] [control-plane] adding volume "k8s-certs" for component "kube-controller-manager"
I0710 17:20:06.462315     132 manifests.go:129] [control-plane] adding volume "kubeconfig" for component "kube-controller-manager"
I0710 17:20:06.462319     132 manifests.go:129] [control-plane] adding volume "usr-local-share-ca-certificates" for component "kube-controller-manager"
I0710 17:20:06.462324     132 manifests.go:129] [control-plane] adding volume "usr-share-ca-certificates" for component "kube-controller-manager"
[control-plane] Creating static Pod manifest for "kube-scheduler"
I0710 17:20:06.463324     132 manifests.go:158] [control-plane] wrote static Pod manifest for component "kube-controller-manager" to "/etc/kubernetes/manifests/kube-controller-manager.yaml"
I0710 17:20:06.463344     132 manifests.go:103] [control-plane] getting StaticPodSpecs
I0710 17:20:06.463562     132 manifests.go:129] [control-plane] adding volume "kubeconfig" for component "kube-scheduler"
I0710 17:20:06.464166     132 manifests.go:158] [control-plane] wrote static Pod manifest for component "kube-scheduler" to "/etc/kubernetes/manifests/kube-scheduler.yaml"
I0710 17:20:06.464185     132 kubelet.go:68] Stopping the kubelet
[kubelet-start] Writing kubelet environment file with flags to file "/var/lib/kubelet/kubeadm-flags.env"
[kubelet-start] Writing kubelet configuration to file "/var/lib/kubelet/config.yaml"
[kubelet-start] Starting the kubelet
I0710 17:20:06.795612     132 loader.go:395] Config loaded from file:  /etc/kubernetes/admin.conf
[wait-control-plane] Waiting for the kubelet to boot up the control plane as static Pods from directory "/etc/kubernetes/manifests"
[kubelet-check] Waiting for a healthy kubelet. This can take up to 4m0s
[kubelet-check] The kubelet is healthy after 1.002349472s
[api-check] Waiting for a healthy API server. This can take up to 4m0s
I0710 17:20:07.800747     132 round_trippers.go:553] GET https://konflux-control-plane:6443/healthz?timeout=10s  in 1 milliseconds
I0710 17:20:08.300651     132 round_trippers.go:553] GET https://konflux-control-plane:6443/healthz?timeout=10s  in 1 milliseconds

8< snipped here to remove ~ 466 repeated lines like previous ones. Now continuing:
I0710 17:24:06.801021     132 round_trippers.go:553] GET https://konflux-control-plane:6443/healthz?timeout=10s  in 1 milliseconds
I0710 17:24:07.300615     132 round_trippers.go:553] GET https://konflux-control-plane:6443/healthz?timeout=10s  in 1 milliseconds
[api-check] The API server is not healthy after 4m0.000226692s

Unfortunately, an error has occurred:
	context deadline exceeded

This error is likely caused by:
	- The kubelet is not running
	- The kubelet is unhealthy due to a misconfiguration of the node in some way (required cgroups disabled)

If you are on a systemd-powered system, you can try to troubleshoot the error with the following commands:
	- 'systemctl status kubelet'
	- 'journalctl -xeu kubelet'

Additionally, a control plane component may have crashed or exited when started by the container runtime.
To troubleshoot, list all containers using your preferred container runtimes CLI.
Here is one example how you may list all running Kubernetes containers by using crictl:
	- 'crictl --runtime-endpoint unix:///run/containerd/containerd.sock ps -a | grep kube | grep -v pause'
	Once you have found the failing container, you can inspect its logs with:
	- 'crictl --runtime-endpoint unix:///run/containerd/containerd.sock logs CONTAINERID'
couldn't initialize a Kubernetes cluster
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/init.runWaitControlPlanePhase.func1
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/init/waitcontrolplane.go:110
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/init.runWaitControlPlanePhase
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/init/waitcontrolplane.go:125
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).Run.func1
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow/runner.go:259
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).visitAll
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow/runner.go:446
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).Run
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow/runner.go:232
k8s.io/kubernetes/cmd/kubeadm/app/cmd.newCmdInit.func1
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/init.go:128
github.com/spf13/cobra.(*Command).execute
	github.com/spf13/cobra@v1.7.0/command.go:940
github.com/spf13/cobra.(*Command).ExecuteC
	github.com/spf13/cobra@v1.7.0/command.go:1068
github.com/spf13/cobra.(*Command).Execute
	github.com/spf13/cobra@v1.7.0/command.go:992
k8s.io/kubernetes/cmd/kubeadm/app.Run
	k8s.io/kubernetes/cmd/kubeadm/app/kubeadm.go:52
main.main
	k8s.io/kubernetes/cmd/kubeadm/kubeadm.go:25
runtime.main
	runtime/proc.go:271
runtime.goexit
	runtime/asm_amd64.s:1695
error execution phase wait-control-plane
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).Run.func1
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow/runner.go:260
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).visitAll
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow/runner.go:446
k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow.(*Runner).Run
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow/runner.go:232
k8s.io/kubernetes/cmd/kubeadm/app/cmd.newCmdInit.func1
	k8s.io/kubernetes/cmd/kubeadm/app/cmd/init.go:128
github.com/spf13/cobra.(*Command).execute
	github.com/spf13/cobra@v1.7.0/command.go:940
github.com/spf13/cobra.(*Command).ExecuteC
	github.com/spf13/cobra@v1.7.0/command.go:1068
github.com/spf13/cobra.(*Command).Execute
	github.com/spf13/cobra@v1.7.0/command.go:992
k8s.io/kubernetes/cmd/kubeadm/app.Run
	k8s.io/kubernetes/cmd/kubeadm/app/kubeadm.go:52
main.main
	k8s.io/kubernetes/cmd/kubeadm/kubeadm.go:25
runtime.main
	runtime/proc.go:271
runtime.goexit
	runtime/asm_amd64.s:1695

I'm running this in a VM with following configuration (ran just before bootstrapping the cluster):
$ sudo inxi --system --machine --memory-short --disk --cpu --za
System:
  Kernel: 6.8.5-301.fc40.x86_64 arch: x86_64 bits: 64
  Console: pty pts/1 Distro: Fedora Linux 40 (Server Edition)
Machine:
  Type: Kvm System: QEMU product: Standard PC (Q35 + ICH9, 2009) v: pc-q35-8.1 serial: N/A
  Mobo: N/A model: N/A serial: N/A BIOS: SeaBIOS v: 1.16.3-1.fc39 date: 04/01/2014
Memory:
  System RAM: total: 12 GiB available: 11.68 GiB used: 640.3 MiB (5.4%)
  Report: arrays: 1 capacity: 12 GiB installed: 12 GiB slots: 1 active: 1 type: RAM
    eec: Multi-bit ECC
CPU:
  Info: 4x 1-core model: N/A bits: 64 type: SMP cache: L2: 4x 512 KiB (2 MiB)
  Speed (MHz): avg: 2400 min/max: N/A cores: 1: 2400 2: 2400 3: 2400 4: 2400
Drives:
  Local Storage: total: 20 GiB used: 2.29 GiB (11.4%)
  ID-1: /dev/vda model: N/A size: 20 GiB

All the VM storage is on pool with SATA 3.1, 5400 rpm HDD.
And going even more back in the past, just after fresh Fedora Server 40 installation I ran:
$ sudo dnf install -qy podman git-core inxi
$ curl --silent --show-error -Lo ./kind https://kind.sigs.k8s.io/dl/v0.23.0/kind-linux-amd64
$ sudo install -o root -g root -m 0755 kind /usr/local/bin/kind
$ curl --silent --show-error -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl"
$ sudo install -o root -g root -m 0755 kubectl /usr/local/bin/kubectl
$ sudo sysctl fs.inotify.max_user_watches=524288
$ sudo sysctl fs.inotify.max_user_instances=512
$ git clone https://github.com/konflux-ci/konflux-ci.git
$ cd konflux-ci
$ sed -i s/memory=8Gi/memory=12Gi/ kind-config.yaml

And finally HEAD of the konflux-ci repo is at:
$ git log --pretty=format:"%h%x09%x09%ad%x09%s" -1
c165bae         Wed Jul 10 14:28:22 2024 +0300  Merge pull request #198 from yftacherzog/test-pvc-default-sa

Since I managed to install this last week, I tried to:
$ git reset --hard 255d3a0e5118195029777942bc91444bf788d8ed
HEAD is now at 255d3a0 konftool:gh_app: GH App creation flow (partial)
$ git log --pretty=format:"%h%x09%x09%ad%x09%s" -1
255d3a0         Wed Jun 26 09:06:13 2024 +0300  konftool:gh_app: GH App creation flow (partial)

and with that one:
$ kind create cluster --name konflux --config kind-config.yaml
enabling experimental podman provider
Creating cluster "konflux" ...
 ✓ Ensuring node image (kindest/node:v1.30.0) 🖼
 ✓ Preparing nodes 📦
 ✓ Writing configuration 📜
 ✓ Starting control-plane 🕹
 ✓ Installing CNI 🔌
 ✓ Installing StorageClass 💾
Set kubectl context to "kind-konflux"
You can now use your cluster with:

kubectl cluster-info --context kind-konflux

Have a question, bug, or feature request? Let us know! https://kind.sigs.k8s.io/#community 🙂

I haven't bisected particular problematic commit here.

Thanks @pbabinca for raising those issues!
I think the fact that it fails during cluster creation means the issue is with either the OS configs or available resources.
The only thing in the repo that affects cluster creation is the kind-config.yaml file, which haven't changed for some time.
The two things I can think of is:

podman installation: Following Kind rootless configs seem to help with those. Having said that, I would not expect to see it failing in different places every time if that was the reason.
Not enough resources: something looks off there. We didn't see the cluster requiring more than 8 gigs of RAM for the setup, and it seems to me as processes are having hard time starting, which makes me think again on not enough CPU cores.

What I can suggest is trying to run it on a bigger VM. You should be able to set one up in cnv-engineering. I took some notes when doing that: https://redhat-internal.slack.com/archives/C02CTEB3MMF/p1715150561436869?thread_ts=1715092931.327899&cid=C02CTEB3MMF

@pbabinca have you tried the suggestion above? can we close this issue?


Missing file for certain videos

ERROR:src.download:ERROR: unable to rename file: [Errno 2] No such file or directory: '/code/data/songs/Vtuber Covers/re-i-am.webm.part' -> '/code/data/songs/Vtuber Covers/re-i-am.webm'

link: https://www.youtube.com/watch?v=QzdsaXemBWM

Can't reproduce


Backport masternodebroadcast to v0.12.0.x

see 40f0d1f1dc6782d640beb925b14a7eccc6fbd69a #741 and c96284a7879b02fdc365a9bb2e28fd8199c01e91 #744 for more info
@thelazier

Thank you so much :+1:
Live on mainnet for electrum.dash.siampm.com (electrum-dash-server) now.

Found many Misbehaving with this line
CMasternodePing::CheckAndUpdate - Signature rejected, too far into the past ...
So, I guess prior version relay ping without checking sigtime, is this worth fixing on v0.12.0.x ?
(ref: https://github.com/UdjinM6/dash/blob/256e02f760accccd0895bc1ef58eb53f69230fdd/src/masternode.cpp #L379 and #L479 )

@thelazier Probably. But 1) I'm not quite sure what is causing this and 2) definitely not in this PR ;)

utACK


Make Response::new public for easier testing

I want to be able to write tests with fake/mock servers.  This would be so easy if there were a way to create a Response object myself.  Sadly Request::new is private, and there is no other way to create them.
Could you consider making some public constructor for testing?

You can construct a reqwest::Response via From<http::Response<Body>>. The trait implementations are sometimes hard to notice in the documentation...

Ah, I did miss that, sorry and thanks for the quick response!


Map Linux AltGr to right alt. It was currently being ignored.

Description
Pressing the AltGr key in Linux generates an unknown keycode to Flutter. Since Flutter doesn't have the concept of an AltGr key, lets just map it to right Alt.
Related Issues
https://github.com/flutter/flutter/issues/68713
Tests
No tests added.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x ] I signed the CLA.
[x ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x ] I updated/added relevant documentation (doc comments with ///).
[x ] All existing and new tests are passing.
[x ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x ] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change.

Yes, generated as per the instructions in dev/tools/gen_keycodes/README.md.

Yes, generated as per the instructions in dev/tools/gen_keycodes/README.md.


codespell: take it to the next level

typos works a bit better.
./.rubocop.yml:127:44: `diffult` -> `difficult`
./app/assets/javascripts/project-form.js:161:19: `requrired` -> `required`
./config/initializers/rack_attack.rb:77:27: `sercurity` -> `security`
./lib/tasks/default.rake:495:3: `Ths` -> `The`, `This`
./lib/tasks/default.rake:695:34: `runnning` -> `running`
./db/migrate/20170626143755_add_prequisites_to_criteria.rb:20: `prequisites` -> `prerequisites`
./db/migrate/20170626143755_add_prequisites_to_criteria.rb:3:10: `Prequisites` -> `Prerequisites`
./docs/background.md:1612:46: `caculation` -> `calculation`
./docs/background.md:1618:53: `caculation` -> `calculation`
./docs/background.md:1618:97: `caculation` -> `calculation`
./docs/design.md:307:8: `Contoller` -> `Controller`
./docs/design.md:418:16: `satifying` -> `satisfying`
./docs/assurance-case.md:3383:39: `antoher` -> `another`
./docs/other.md:1590:47: `Occurence` -> `Occurrence`
./test/controllers/project_stats_controller_test.rb:186:8: `Projets` -> `Projects`
./.github/dependabot.yml:29:67: `licnese` -> `license`

Would you upgrade?

I presume you mean https://github.com/crate-ci/typos
That's also OSS, so I can certainly consider it. We'd have to change what we invoke in our workflow. We'll also have to do some reconfiguring, since we have a number of non-English files.
No matter what, we should fix the typos noted. They aren't a BIG deal, but it'd be nice to do so.

have to do some reconfiguring,

Here is .typos.toml for you.
[files]
extend-exclude = [
    ".git/",
    ".codespellignore",
    "config/locales/",
    "test/vcr_cassettes/*.yml",
]
ignore-hidden = false

[default]
extend-ignore-re = [
    "[0-9A-Za-z/+]{76}",
    "Synopsys' Protecode",
    "Jonathan Suh",
    "mis à jour",
    "du site Web du projet",
    "les projets de logiciel",
]

[default.extend-words]
# No such English word
requestor = "requestor"

[default.extend-identifiers]
HELO = "HELO"
WXwindows = "WXwindows"

# Typos
#"Github" = "GitHub"


cluster size cut on strip hits, WP95

this PR goes with PR358 from mkFit repo (https://github.com/trackreco/mkFit/pull/358), and updates the JSON files accordingly

closing, as I'll be moving to WP99


Upload master to hackage

Latest version of hi in hackage (<IP_ADDRESS>) is incompatible with optparse-applicative >= 0.13, so it's difficult to build it with recent stack snapshots.
Could you upload the master version in this repository to hackage? Thanks in advance.

@debug-ito @fujimara: I thought a new release might be needed as well, hence #62

@fujimura: This is also the same issue as #61.  It was fixed in #60, it just requires a new release.
If you are busy, please add me as a package maintainer on hackage (I am adetokunbo there as well), and I will upload a release on your behalf.

Oops, this was  a duplicate of #62.

Just uploaded <IP_ADDRESS>  which is compatible with optparse-applicative >= 0.13 to hackage. I confirmed that hi <IP_ADDRESS> can be installed with GHC 8.4.3 & cabal-install <IP_ADDRESS>.
Let me know if you find further issues. Thanks for reporting!

Thanks!


Simulated datasets

Hi @QiuyuLian ,
Where can I find the code you used to generate the simulations described in your paper?
https://academic.oup.com/bioinformatics/article/36/Supplement_1/i542/5870491#205479414
Best,
Stephany

Hi Stephany,
Many thanks for reaching out to me.
Unfortunately, I don't have the simulation code currently. It was contributed by my collaborator Hongyi. Please contact him by<EMAIL_ADDRESS>for the code.
Best,
Qiuyu


Add a simple pir command to print the loaded PIR textually

Useful for turning the flat PIR that comes out of the plugin into something you can look at.

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[ ] Commit sequence broadly makes sense
[ ] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages
[ ] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[ ] Self-reviewed the diff
[ ] Useful pull request description
[ ] Reviewer requested

This is still useful, I'll revive it when I have a sec.


TabOptions switch "-SelectorColor" sets the colur permanently

Hello
When TabOptions -SlimTabs -SelectorColor blue is used color is set permanently even after -selectorcolor switched is removed
So the only way to change the color is to use the switch -selectorcolor again with new color name.

Is there a way to restore the color/layout to the deafault?
any chance that -selectorcolor switch will support hexhtml colours values?

Piotr

Please give an example how you're using this. As far as I understand the way it's supposed to be used is to have 1 selector for whole .HTML file but maybe there are other ways people use it
All commands that take color will give you validateset for colors, however if you give it HEX value it will be used.

The code responsible for it:
https://github.com/EvotecIT/PSWriteHTML/blob/30065455bfd08032a30217aba9b3a9cb0d2273c8/Private/Convert-FromColor.ps1#L1-L31
Ferwe/Tino did hard work on that here https://github.com/EvotecIT/PSWriteHTML/pull/68

Here u go
Extract:
TabOptions -SlimTabs -selectorcolor blue
Tab -Name 'Azure Service Health Dashboard' {
foreach ($Region in $Azure.Keys) {
Tab -Name $Region {
Table -DataTable $Azure.$Region -Filtering {
foreach ($Column in $Azure...

Selectorcolor switch added with blue as value
Generate the html
Remove the selector switch
Generate the html again. U will observe that color is still set as blue

Workaround:

running new pa session , import module and generate html again with default colours

Re validateset

it is not applicable for -selectorcolor switch
hex value did not work for me either

I see. This is a bug. Will fix
It's related to how hashtable $Script:Configuration is able to survive runs.
https://github.com/EvotecIT/PSWriteHTML/blob/30065455bfd08032a30217aba9b3a9cb0d2273c8/Private/Parameters.Configuration.ps1#L413-L422
The workaround is to actually use: Import-Module PSWriteHTML -Force at the top which reloads module clearing hashtable - a reason why I didn't notice the error.

Yep.
That is why i showed workaround :)
On Wed, 27 May 2020 at 22:39, Przemysław Kłys<EMAIL_ADDRESS>wrote:

I see. This is a bug. Will fix
It's related to how hashtable $Script:Configuration is able to survive
runs.
https://github.com/EvotecIT/PSWriteHTML/blob/30065455bfd08032a30217aba9b3a9cb0d2273c8/Private/Parameters.Configuration.ps1#L413-L422
The workaround is to actually use: Import-Module PSWriteHTML -Force at the
top which reloads module clearing hashtable - a reason why I didn't notice
the error.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EvotecIT/PSWriteHTML/issues/128#issuecomment-634926697,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI25TFMVEHR2ECJG7S5RSVLRTV275ANCNFSM4NMGIQ3Q
.

--
Best Regards / Pozdrawiam
Piotr

Any update pls? :)

It should be fixed in next release.


kpt fn error reporting and CLI output

kpt fn render should report errors with useful diagnostic info that helps the end-users as well as kpt developers. We should explore if we kpt can support error reporting explained in this post by Rob Pike.  The approach in that post tries to strike the right balance with needs of both the personas.
In addition, being able to trace input/output for each function execution of the pipeline can assist in function level debugging as well.

This is addressed with #1634

Reopening this since we need to hash out the UX for error reporting and CLI output.
A list of all the data involved in running functions:

What function provides:

ResourceList.results
ResourceList.items
stderr
exit code

Orchestrator provides metadata:

What function is running (Specially important when running a pipeline)

We need to figure out the best UX for providing all or subset of the following to the user across:

CLI output
2. stdout
3. stderr
FucntionResults files

As part of this, need to consider happy paths and failure paths:

Happy path: The pipeline ran successfully
Failure paths:

Function exceptional failures (e.g. function segfaulted)
Validator failures which are WAI (kubeval found an issue)
Orchestrator failed for some reason (e.g. IO failures or user input issues)

Some principles to follow:

Don’t pollute the CLI output unnecessarily (Especially in the happy path)
Provide realtime information about what’s happening, especially for long-running operations. The CLI should not appear stuck for long periods of time with no progress.
Follow and add to the style guide: go/kpt-errors-style-guide

#1783 should be addressed as part of this.

As part this, need to add e2e test cases for both render and eval: go/kpt-test-cases

Related to this, the current output while a pipeline is running is a little confusing. It prints
package ".": running function "gcr.io/kpt-fn/kubeval:v0.1":

with the caret blinking at the end of the line. It looks like we expect some kind of user input.

Yes, I want to see a design doc iterating on the UI here. There are good prior art for CLI showing task progress.

Adding that we should address the concerns raised here:
https://github.com/GoogleContainerTools/kpt/pull/1839#pullrequestreview-650567778

The works remained for this task are:

Aggregate structured results
Create results file.
Hash output for the behavior with CLI stdin and stdout

These tasks are coved by umbrella issue #1390. Subtasks: #1920, #1915

Close this with #1783 . The only thing remained in m2 is #1915. Please create new issues for bugs or features.


Type generalization precision is now required

https://github.com/phpstan/phpstan-src/commit/65681033ff625c67a478212a0cd6da29cd5ab5fa
I think no documentation is needed.
@canvural Please wait for the next PHPStan release.

Thanks! Can you change the target branch to phpstan-1.0? In that branch I'm fixing the compatibility with the PHPStan 1.0

Changing base 👉 disaster :)

@canvural Please cherry-pick my commit or simply copy-paste these lines.

Done.
https://github.com/nunomaduro/larastan/commits/phpstan-1.0


Adding requirements docs for CloudStack provider

Issue #: #3658
Description of changes:
This PR creates the requirements page for creating EKS Anywhere clusters on a CloudStack provider.
Feel free to comment. It's still on hold as I work through a couple of issues.

/cherrypick release-0.12


Replace got w/ node-fetch

This pull request fixes #109. It replaces the got package which is only used once, with an alternative ( node-fetch, which against intuitions does not depend on @types/node where got did ).
This means that there are now not any issues when running tsc in a Cloudflare Workers project which uses xdm. This came up specifically while building a Remix application, as @remix-run/dev depends on xdm.
I made sure to replicate the existing caching set up, as that is not included in node-fetch.
Thanks for this awesome project 🙏

Can you rebase? I fixed the unrelated error on main

Released, thanks!


Fix broken spillage and item requests (e.g. beacons) on Nanobots

Encountered this while playing, it deleted an Epic stone brick :(
This commit Fixes that problem by moving to the new spill_item_stack api
See:
Old New
This also fixes a much bigger issue, item requests, which no longer work via item_requests, instead you have to use the insert_plan which is pain...

There are still some issues with Quality i need to solve before this is OK


Calibration files only read while reading MIDAS files or generating Analysis Tree

I think that calibration files are only read when reading MIDAS files or generating Analysis Trees since the only calls to TChannel::ReadCalFile() are in TAnalysisTreeBuilder::InitChannels and TGRSILoop::ProcessMidasFile.
Could calibration files be read in all cases? In my particular case I have a macro that I'm using to do gain correction from a hosts file (I know that I can start my macro with ReadCalFile()). It would also come up when using -s on a fragment tree.
The easiest fix would be to call ReadCalFil() immediately after reading it in, as well as when it is currently called (I doubt that extra calls would cause issues)

Seems reasonable to me. I’m slightly surprised it doesn’t do this already as I thought I put something in to do that ages ago. I would check to make sure that ReadCalFromTree isn’t just overriding this. When I originally put this in (I think) we were not yet reading and writing directly to the root files the way we are now.

On Jul 3, 2015, at 9:52 PM, gdemand<EMAIL_ADDRESS>wrote:
I think that calibration files are only read when reading MIDAS files or generating Analysis Trees since the only calls to TChannel::ReadCalFile() are in TAnalysisTreeBuilder::InitChannels and TGRSILoop::ProcessMidasFile.
Could calibration files be read in all cases? In my particular case I have a macro that I'm using to do gain correction from a hosts file (I know that I can start my macro with ReadCalFile()). It would also come up when using -s on a fragment tree.
The easiest fix would be to call ReadCalFil() immediately after reading it in, as well as when it is currently called (I doubt that extra calls would cause issues)
—
Reply to this email directly or view it on GitHub https://github.com/GRIFFINCollaboration/GRSISort/issues/378.

I am not sure I understand... if your macro is run after starting grsisort with an analysis/fragment tree on the command line, I believe they are loaded automatically.
If you are loading the root file after starting the program or running a macro with the .X command, I think they have to be loaded by the user, same as the tree.

Is this sorted out?

I'm assuming the question is whether we want the ability to do something like
grsisort -l mycalibration.cal

It might be useful, but might be a bit buggy.

It would be pretty easy to added it to grsiloop::applyoptions after the
sorting.
If you are sorting it happens anyways, just have to be careful as order
matters.
On Jul 27, 2015 12:55 PM, "Ryan Dunlop"<EMAIL_ADDRESS>wrote:

I'm assuming the question is whether we want the ability to do something
like
grsisort -l mycalibration.cal
It might be useful, but might be a bit buggy.
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/378#issuecomment-125270863
.

I agree that it should be put in the grsiloop::applyoptions.  This would let people do things like
grsisort fragment.root mycalibration.cal

or
grsisort -l fragment.root mycalibration.cal

or
grsisort analysis.root mycalibration.cal

ApplyOptions is in TGRSIint.
You just have to be careful because things like MakeUserHists FromFragmentTree happens near the start, so the second cal file would be ignored. I meant buggy in the sense that you can’t just drop it in and we have to pay attention that the order that things happen makes sense.

On Jul 27, 2015, at 1:52 PM, gdemand<EMAIL_ADDRESS>wrote:
I agree that it should be put in the grsiloop::applyoptions. This would let people do things like
grsisort fragment.root mycalibration.cal
or
grsisort -l fragment.root mycalibration.cal
or
grsisort analysis.root mycalibration.cal
—
Reply to this email directly or view it on GitHub https://github.com/GRIFFINCollaboration/GRSISort/issues/378#issuecomment-125286146.

Solved in #427 .


Optimize dataset updates

Review with white space comparison turned off, as most of the lines changed in es_export.py are only indentation changes.
Some compromises were needed. Discussion of alternatives is welcome:

I had to pick a different server backend for bottle, because its default is single-threaded and can't dispatch messages fast enough to keep the update daemon workers working. I chose CherryPy because it is actively developed and doesn't rely on green threads or forks. CherryPy seems to default to 10 threads.
I noticed that I now get a lot of these warnings about the Elasticsearch HTTP connections not being cleaned up:sm-api_1              | namedtuple_Column:14: ResourceWarning: unclosed <socket.socket fd=117, family=AddressFamily.AF_INET, type=2049, proto=6, laddr=('<IP_ADDRESS>', 34468), raddr=('<IP_ADDRESS>', 9200)>

I compared against master - apparently I've always been getting warnings like this, but with CherryPy's multithreading they now come in large batches, all at once.
Each DatasetLocker uses its own database connection. I found that psycopg2 can only apply transactions at the connection level, so I couldn't implement this using transactions. Also, Postgres 9.5 doesn't support the transaction-based advisory locks, so I was stuck using session-based advisory locks. Postgres defaults to a maximum of 100 connections, and I managed to hit that limit when I tried running with 32 worker threads.
Postgres' advisory locks don't support strings, only 32-bit and 64-bit integers. I've used a 32-bit hash of the dataset ID instead of locking on the exact ID itself.
Using a single ElasticSearch pipeline name didn't scale to multiple threads, so now it uses a different name for each dataset and deletes the pipeline after use
Updating a dataset doesn't change its status at all now. This means no status update is published, so the webapp won't automatically refresh the list after a name change.

Locally, with these changes and 4 update daemon worker threads, it takes 160s to update the group name on 114 datasets. None of the Python processes use more than 1% CPU, and ElasticSearch uses 300-400%. I tried 8 and 16 threads and they took 120s but on 16 threads there was 1 request timeout failure and lagged everything else on my computer. I don't think the extra speed from 8 threads is worth the risk of lagging everything else on the system.
I also tried to fix the scientific test on CircleCI for extra certainty that I hadn't broken anything, but I couldn't get past this error: https://circleci.com/gh/metaspace2020/metaspace/1727

To fix https://circleci.com/gh/metaspace2020/metaspace/1727,
one can try to limit the number of spark executors by setting spark.master = "local[2]",

The scientific test passed with the local[2] change: https://circleci.com/gh/metaspace2020/metaspace/1755


Terraform Extension puts the AzureRM connection secret in plain text in the terminal

  - task: TerraformTaskV1@0
    displayName: 'init'
    inputs:
      provider: 'azurerm'
      command: 'init'
      workingDirectory: '$(TerraformWorkingDirectory)'
      backendServiceArm: '$(ServiceConnection)'
      backendAzureRmResourceGroupName: '$(ResourceGroup)'
      backendAzureRmStorageAccountName: '$(ResourceGroup)'
      backendAzureRmContainerName: 'tfstatedevops165'
      backendAzureRmKey: 'terraform.tfstate'

Snipped off some for security but it seems strange that many of th pieces are *** but not the secret?

@gabrielmccoll We are always mocking Secret . I tested with latest terraform version and we are mocking it .
Can you confirm are you using microsoft terra extension ? because on marketplace there are multiple terraform extension but we are releasing through Microsoft publisher

I tested and it is working fine

Can you please verify it ?  Can you also attach debug log and send it to<EMAIL_ADDRESS>

Hi there. I only had one at the time which was the devlabs one so am pretty sure. I'm not back at work until Monday to check unfortunately. I switched to a different extension after I reported this because of this issue

@gabrielmccoll can you verify once?

We verified this and its not getting logged. Feel free to reopen if you see this issue again with detail logs. Closing this issue


fix: editing path of link to capital removes link

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/21417
PROPOSAL: https://github.com/Expensify/App/issues/21417#issuecomment-1604382428
Tests

Go to a chat and add a comment

https://staging.new.expensify.com/r/995549455728297

Edit the link by changing the r character after the first / to R. Note to change the link wrapped by (), like

[https://staging.new.expensify.com/r/995549455728297](https://staging.new.expensify.com/R/995549455728297)

Save the edited link
Verify that the link is edited and displayed as link instead of plain text.

[x] Verify that no errors appear in the JS console

Offline tests
QA Steps
Same as test

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/117511920/24801071-18f0-412b-9d17-0df6fac6e3bf

Mobile Web - Chrome

https://github.com/Expensify/App/assets/117511920/5ff87f98-d352-4c8b-96e3-9c322dd0414e

Mobile Web - Safari

https://github.com/Expensify/App/assets/117511920/238407b6-a5c7-4f21-9aaf-cd193e10328e

Desktop

https://github.com/Expensify/App/assets/117511920/b41c9ade-26e7-4b33-bdc8-0641ba0fcb79

iOS

https://github.com/Expensify/App/assets/117511920/cd26277a-51e8-4bf6-87d6-87e0e43c7107

Android

https://github.com/Expensify/App/assets/117511920/4eb1492b-e029-438f-a289-4eb56a54bc43

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.35-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Add more plugins to be used by grpc_cronet

A few more plugins are required by Cronet. Missing them makes some internal tests fail.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Asan C++ - #13477
Basic Tests MacOS - cython and mpm issues unrelated.


make job page responsive #263

@aditya-bhaumik
Issues Identification
Closes: #263
Description
By adding media queries to job.css file to make job page responsive.
Summary
A brief description of what this pull request does and why it is needed.
Details
Include any detailed information about the changes in this pull request.
Types of Changes
Please check the boxes that apply

[x] Bugfix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Please check the boxes that apply

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] My changes do not break the current system and pass all existing test cases
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Screenshots
If applicable, please attach screenshots of the changes made to the user interface.

Additional Information
Please provide any other information that is relevant to this pull request.

resolve conflicts

??

@AkankshaSinghK please fix it

@aditya-bhaumik
At my locall it is working fine
I think becase of other PRs this problem is coming

@aditya-bhaumik

At my end all things are working properly so how should i fix it
It may be due to other PRs
On Sun, 6 Oct 2024, 6:53 pm Aditya Bhaumik, @.***>
wrote:

@AkankshaSinghK https://github.com/AkankshaSinghK please fix it
—
Reply to this email directly, view it on GitHub
https://github.com/aditya-bhaumik/Pathsphere/pull/316#issuecomment-2395439327,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXBOUSPFZGOHMUXYOEZTMD3Z2E2UJAVCNFSM6AAAAABPN67QKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGQZTSMZSG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Hooks

Codecov Report
Attention: Patch coverage is 75.43994% with 321 lines in your changes are missing coverage. Please review.

Project coverage is 57.58%. Comparing base (d11be06) to head (8dee04f).

Files
Patch %
Lines

...g/skellig/feature/parser/SkelligFeatureParser.java
66.35%
189 Missing and 28 partials :warning:

...lig/runner/junit/report/model/HookReportDetails.kt
28.57%
14 Missing and 1 partial :warning:

...ure/src/main/kotlin/org/skellig/feature/Feature.kt
76.47%
4 Missing and 8 partials :warning:

...ig/feature/hook/DefaultSkelligTestHooksRegistry.kt
83.63%
4 Missing and 5 partials :warning:

.../runner/junit/report/model/FeatureReportDetails.kt
65.38%
0 Missing and 9 partials :warning:

...rg/skellig/feature/parser/SkelligFeatureLexer.java
77.14%
8 Missing :warning:

...org/skellig/feature/parser/DefaultFeatureParser.kt
94.11%
2 Missing and 5 partials :warning:

...rc/main/kotlin/org/skellig/runner/SkelligRunner.kt
80.55%
2 Missing and 5 partials :warning:

...rc/main/kotlin/org/skellig/feature/TestScenario.kt
88.00%
4 Missing and 2 partials :warning:

...rc/main/kotlin/org/skellig/runner/FeatureRunner.kt
83.78%
0 Missing and 6 partials :warning:

... and 10 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
+ Coverage     55.22%   57.58%   +2.36%
- Complexity     1289     1468     +179
============================================
  Files           249      255       +6
  Lines          7173     8160     +987
  Branches        964     1091     +127
============================================
+ Hits           3961     4699     +738
- Misses         2796     2995     +199
- Partials        416      466      +50

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


govee2mqtt -> mosquitto -> matterbridge (not working)

First of all - Thanks for your great work. :)
I have installed matterbridge and mosquitto as mqtt broker with docker compose. I then installed govee2mqtt (wez). This also finds my Govee lamp and reports to mosquitto with the zigbee topic “govee2mqtt/xxxxxxx...”. Unfortunately, I cannot see the lamp in the Matterbridge. I think it is because the Matterbridge expects a topic “zigbee2mqtt”. Is this the problem? And how can I fix it? Any help is welcome. (I can't change the topic in govee2mqtt, i think it is hardcoded.

Hi,
thanks for your appreciation.
I don't think that your lamp sends the same data as zigbee2mqtt...
If you want to try, you can change the topic in the plugin config.

The Addon is working with the home assistant zigbee2mqtt and mosquitto setup. So i thought it should work the the mosquitto setup from your docker container. It also contacts the mosquitto broker successfully, but i don't see anything in the matterbridge.

Hi,
yes the data format are not the same of course.


MODE-1384 Changed JBoss AS7 kit assembly to use project version variable

Previously, the '3.0-SNAPSHOT' was hardcoded. Plus, some of the Maven modules were referencing modeshape-jcr-redux, which was just replaced by modeshape-jcr.
Even with a clean Maven repository, the build works well.

Merged into the '3.x' branch.


Parent state resolve not working when transitioning from child

Hey,
I have states configured like this:
$stateProvider.state('administration', {
	url : '/administration',
	template : '<div ui-view> </div>',
	abstract : true,
	data : {
		permissions : {
			only : 'admin',
            redirectTo : 'pageNotFound'
		}
	}
});

$stateProvider.state('administration.company', {
    url : '/company',
    template : '<div ui-view> </div>',
    abstract : true
});

$stateProvider.state('administration.company.settings', {
    url: '/settings',
    controller:'CompanysettingsCtrl',
    templateUrl: 'administration/companyAdministration/partial/companySettings/companySettings.html',
    resolve:{
        companySetting: function(companySettingsService){
            return companySettingsService.getSettings();
        }
    }
}),

$stateProvider.state('administration.company.settings.update', {
    url: '/update',
    controller:'UpdatecompanysettingsCtrl',
    templateUrl: 'administration/companyAdministration/partial/updateCompanySettings/updateCompanySettings.html',
    resolve:{
        companySetting: function(companySettingsService){
            return companySettingsService.getSettings();
        }
    }
})

We go to the '/settings/update' from '/settings', update info there and on save in controller there's this (to go back) :
$state.go('administration.company.settings');

But state is not being updated - old info is shown there though resolve should get new info.
Tried it with all the settings like so:
$state.go('administration.company.settings', {}, {reload : false, inherit : true, notify : true});

Nothing changed.
Then while debugging I've noticed that actually once there's transition from /settings/update back to /settings, resolve in administration.company.settings is never reached. Further debugging showed that transition is being canceled when there're permissions on them.
If I remove permission definition & 'permission' dependency altogether, resolve is being executed.
TL;DR Permissions are defined properly and working on other functionalities (states/views) but once you try to transition from child to parent, parent's resolve is not being executed.
Is this by design/bug?

It is @version v2.1.2 - 2016-03-06

I've simplified it to
$stateProvider.state('company', {
    url : '/company',
    template: '<div ui-view></div>',
    abstract : true,
    data : {
  		permissions : {
  			only : 'admin',
              redirectTo : 'pageNotFound'
  		}
  	}

});

$stateProvider.state('company.settings', {
    url: '/settings',
    controller:'CompanysettingsCtrl',
    templateUrl: 'administration/companyAdministration/partial/companySettings/companySettings.html',
    resolve:{
        companySetting: function(companySettingsService){
            return companySettingsService.getSettings();
        }
    }
}),

$stateProvider.state('company.settings.update', {
    url: '/update',
    controller:'UpdatecompanysettingsCtrl',
    templateUrl: 'administration/companyAdministration/partial/updateCompanySettings/updateCompanySettings.html',
    resolve:{
        companySetting: function(companySettingsService){
            return companySettingsService.getSettings();
        }
    }
}),

But "company.settings" resolve is still not being reached.

Hey, any news on this?
It seems that .transitionTo is being called twice - first time with the correct params & second one with the bad ones.


Anchor element update

"Find the following anchor element in the Pages/Shared/_Layout.cshtml file.
RazorPagesMovie"
should read
RazorPagesMovie

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 70f6104a-a223-4bb3-4101-f553002b9b26
Version Independent ID: 15e79e80-8d46-7cd5-c883-6cc0f5940a1b
Content: Scaffolded Razor Pages in ASP.NET Core
Content Source: aspnetcore/tutorials/razor-pages/page.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

The templates generate asp-area=""

asp-area="" was not generated for me. I have the same RazorPagesMovie as the above comment mentioned. Would I update that with Movie?

Update your SDK version.


how to use GPU for create_pretraining_data.py

I'm trying to create pretraining data using GPU server. However, while I was running create_pre_training_data.py, I found that there is no running process on GPU.
How can I run the program on GPU?
And I shard my data file because of the OOM problem. Can I run it as follow?
python create_pretraining_data.py   --input_file=$/data_file_shard/data_file_shard*   --output_file=$/tmp/tf_examples.tfrecord   --vocab_file=$/BERT_BASE/vocab.txt   --do_lower_case=True   --max_seq_length=128   --max_predictions_per_seq=20   --masked_lm_prob=0.15   --random_seed=12345   --dupe_factor=5
Or do I have to create seperate tf_examples.tfrecord (eg. tf_examplestfrecord_00) for each data file?

I'm trying to create pretraining data using GPU server. However, while I was running create_pre_training_data.py, I found that there is no running process on GPU.
How can I run the program on GPU?
And I shard my data file because of the OOM problem. Can I run it as follow?
python create_pretraining_data.py --input_file=$/data_file_shard/data_file_shard* --output_file=$/tmp/tf_examples.tfrecord --vocab_file=$/BERT_BASE/vocab.txt --do_lower_case=True --max_seq_length=128 --max_predictions_per_seq=20 --masked_lm_prob=0.15 --random_seed=12345 --dupe_factor=5
Or do I have to create seperate tf_examples.tfrecord (eg. tf_examplestfrecord_00) for each data file?

Dear CarinaXZZ,
I hope you were able to proceed with the pre-training using GPU. If so, could you please share the steps you have followed?.
Thanks in advance.

Any updates here ?


openapi docs do not seem to be aware of their location for mounted apps

Describe the bug
When mounting a Starlite app as an asgi mount, the openapi docs can be found at the expected path, but the internally documented paths within that documentation all refer to the site root.
To Reproduce
For some Starlite app, mount it into your primary application. E.g., for some app called v1_app:
v1_asgi = asgi(path="/v1", is_mount=True)(v1_app)
app = Starlite(
    route_handlers=[v1_asgi]
)

The result is that the api docs can be found at /v1/schema as expected. However, the links within those docs will be at the site root, not at /v1 as expected.

It looks like the solution to this is to provide the servers attribute to the OpenAPIConfig. So:
from starlite.config.openapi import Server

v1_app = Starlite(
    openapi_config=OpenAPIConfig(
    servers=[Server(url="/v1")],
    ....
    )
...
)

Then as above:
v1_asgi = asgi(path="/v1", is_mount=True)(v1_app)
app = Starlite(
    route_handlers=[v1_asgi]
)


Mldb 256 accuracy multiclass

@mailletf I added a commit which may help things along.  The thing you were missing was that labels are CellValues, not strings, and when they are passed through column names, they are JSON encoded.

+1

Beside the comments I made in PR 182, can you please enable the MLDB-1272 test.  I see that you have fixed it.

@mailletf apologies, but I'm with @guyd on the camelCase/snake_case thing: the output here should be changed to camelCase to match the rest of MLDB's output. Out of curiosity I checked the output of the classifier.experiment procedure and there is a mix of camel and snake case there, so we should fix that too. Please LMK if you want me to create a different JIRA issue for that.