Extract image_upload_widget.hbs

We can extract image_upload_widget.hbs  so that we can use the
same HTML template for all 4 widgets (user avatar, icon, day logo, night logo)
across the two settings UIs and different image upload widgets as possible.
Testing Plan:
GIFs or Screenshots:

@Jagansivam28 is this ready for a review?  I notice a lot of commits and it passing CI, but it's also tagged WIP.

Regardless, I'm taking a look at it today. The code looks good at a glance.
On Tue, Jun 16, 2020, 6:43 AM Tim Abbott<EMAIL_ADDRESS>wrote:

@Jagansivam28 https://github.com/Jagansivam28 is this ready for a
review? I notice a lot of commits and it passing CI, but it's also tagged
WIP.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/pull/15333#issuecomment-644471938, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB5JHVVIZJBJE2QAA5IRUMLRW3BNNANCNFSM4N4LWSHA
.

@timabbott still in WIP

@timabbott @aero31aero ready for the first review

@Jagansivam28 this is great progress!  I merged the first half of it, after making the commit message titles more consistent (you have some random capitalization, etc.).  A few notes on how to improve the rest:

settings_account.user_can_change_logo should probably be in settings_data.js instead.
I suspect this branch breaks i18n, because our scanner doesn't support passing a variable into the translation functions.  I'm not sure what the right way to fix it is.  See https://zulip.readthedocs.io/en/latest/translating/translating.html.
The last CSS commit seems to leave some empty blocks that should be deleted?
The CSS for realm-icon-upload-widget has a blank line at the start that should be removed.
The 3 commits for implementing the "realm icon" transition should be squashed together; the separation between template and JS changes doesn't make sense, because the old JS is broken following the template changes.
I think the same is true for 4/5 of the realm logo commits.

@timabbott @aero31aero Thanks for the review. I'll Update those suggested changes and let you know

@timabbott @aero31aero ready for review

After doing a thorough review yesterday and reading the final commits that fix i18n, this PR LGTM. I haven't tested the last 2 commits locally.

I tested this locally, fixed our i18n regexes to support this new style of accessing t, and merged as the series ending with 872d43713a8104450165cf4f511d54360526a48b.  Thanks @Jagansivam28!
I think there's more cleanup we can do; e.g. probably the duplicate delete helper methods could eventually be moved into upload_widget.build_direct_upload_widget by just passing in url and an optional delete_success_continuation.  Might require a bit of work on the other callers, like "emoji settings" and "bot settings" to standardize those before it's worth going down that path.
And in any case, this is a good releasable checkpoint where we've finished the overhaul of this part of the UI.

I should mention that I'd like you to give more attention to your commit messages; I often find myself noticing and fixing typos in them before merging, or just rewriting them to more clearly explain the changes.

ok sure Tim


Update offers index screen for CX-807

paired with @annacarey
completes https://artsyproduct.atlassian.net/browse/CX-807

All tests are passing, and they're displaying again on CircleCI, so I'm going to merge this in order to rebase my next PR for Convection.


[arm64] internal/loader: adding arm64 support basically

I have tested it with golang1.16. The result seems OK.

Since jit and native modules not support arm yet, there is no need for this


Sent messages not saving; multiple draft copies get created like cockroach spawn

BUGS:

Many of my sent messages are not saving (in the thread and also not in sent folder) even though they do get through to recipients. I'm sure you can imagine why this is very problematic.

Also: when I create a draft, often it gets copied in a recurring loop such that I have 20 or so copies of that draft in the thread + in the draft folder. They're like cockroaches - respawning as soon as they're deleted.

I am really frustrated that these kinds of debilitating bugs are still present quite far along in the development of this product. Please help bc I need a reliable email client.

+1 on this. Same thing happening to me.


How to test code that uses external APIs?

We're using OpenAI for example and it's annoying and potentially expensive to call out to their API in CI/CD.
I've seen various approaches to mock OpenAI such as LangChain's FakeLLM and https://github.com/ClerkieAI/bettertest.
I have generally worked on internal tools and packaged software so I haven't had to ship much production code that depends on external APIs, so I'm open to suggestions on how to best handle this situation for Ref Studio!

I like thinking about safely shipping ML-related code, so I dig this issue and am open to more ideas.
Here's how I've previously approached testing when shipping ML models to production. I think the LLM world changes things a bit, but maybe we can borrow some ideas. I've also never worked on desktop applications.
In the past, I have thought about this as two questions:

How do we test against external APIs?
How do we test APIs / function calls where the expected results somewhat vary (LLMs, ML models, etc)?

For the former, I think traditional mocking should be sufficient. We know the APIs input parameters and expected response structure, so we can mock and test against that. This is what we currently do with calls to Grobid and OpenAI. Of course, the downside of mocking is that there will be unforeseen changes to both of those variables -- PDFs we haven't tested against resulting in API responses we hadn't expected. When that happens, I've always viewed the resulting bug as another test case to add (and maybe an indication I should have coded more defensively).
For the latter, I've thought about this in multiple parts. I'll imagine we're building a grocery delivery company to illustrate.
Unit and integration tests for some expected range of results
If we have a model that predicts how long it will take to shop for some groceries, then calling the model with all features = 0 should result in a prediction of 0. Or setting feature num_items_to_shop_for = 10_000 should result in prediction > 60 minutes. Testing against "known knowns".
Guardrails and some sort of "fallback" heuristic in the event something is clearly wrong
Imagine we shipped a bad model that is occasionally raising exceptions. Rather than error out, fall back to some heuristic or guardrail as the prediction, since running in a slightly degraded state is probably better for the user than not running at all. Protecting against "known unknowns".
Logging, instrumentation, alerting, and monitoring
If we're hitting the guardrail or falling back to the heuristic model, an alert would get thrown in Slack and the on-call MLEng would get paged. We'd also log predictions to the db and have dashboards that allowed us to monitor online model performance, so that we knew if there was some model drift or degradation (possibly due to retraining or shipping a new model). Capturing and quantifying "unknown unknowns."
Experimentation and feature flags
Any new model went through a split test so that impact to related metrics could be measured (e.g. "how does a new version of our shopping time model impact our actual % of late deliveries"). Additionally, having the {model_version} always set through a feature flag allowed us to quickly toggle to a "safe" model without requiring a code change.
The refstudio world of desktop apps and LLMs is different, but I think there are common themes.

For part 2, we wrote a blog post a few years back on that topic that may be of interest: http://www.hammerlab.org/2015/09/30/testing-oml/


MTL-2280: spire and dhcp hostname

Summary and Scope
Enable spire-agent and allow dhcp hostnames to be set

Fixes: MTL-2280

Issue Type

Bugfix Pull Request

Compute and Application nodes require that spire-agent be running for things like BOS and CFS to work correctly.
Prerequisites

[x] I have included documentation in my PR (or it is not required)
[x] I have tested this by building an image using this branch HEAD, or this is does not pertain to the node-images pipeline.
[x] I tested this on internal system or this pertains to the node-images pipeline (if yes and not build related, please include results or a description of the test)
[ x I tested this on a vshasta system or this pertains to the node-images pipeline (if yes and not build related, please include results or a description of the test)
Tested on beau

Idempotency
Should be
Risks and Mitigations
Low, Image can be modified via CFS image customization to address issues until fixed. Image used for validation primarily.

Should this be backported to lts/csm-1.5?

Should this be backported to lts/csm-1.5?

Yes, please. Is there a github action for that, or can I take care of it?

/backport lts/csm-1.5


Update README.md

added a tagline to convey the message and also made a minor change.

screenshot


Unable to run train.py Too many errors.

I wanted to use applr as a benchmark. However, the requirements for training are not specified. Some functions are used without defining them. For example, qt()
https://github.com/Daffan/nav-competition-icra2022/blob/8f902467016129e9756fc3d3b60735cc46466b96/applr/envs/gazebo_simulation.py#L16
Would really appreciate a walkthrough/documentation.
Thank you in advance.
@Daffan

Could you check the latest commit in the main branch? This should be fixed already. Thanks for your understanding!

Sorry, I just realized that was in applr branch. We trained APPLR on a cluster, so the training pipeline does not work locally. The code for APPLR here only ensures the deployment, which means run.py should load APPLR policy and run the navigation.
Here is a training pipeline that trains end-to-end deep RL policy locally. I plan to add APPLR training soon. However, the performance is not guaranteed to match branch applr and e2e at here. I will post here once the APPLR training is added.
https://github.com/Daffan/ros_jackal

@Sleepyhead01 Please check this branch for competition setting: https://github.com/Daffan/ros_jackal/tree/competition


suppress the warns about the unused vars

@niXman Thanks for looking up all those instances of unused vars. I think @vendethiel is right though, it would be better to either comment the parameter names out (or just remove them).


draft: adds support for symbol change

This is my proposal for symbol changes.
Test data attached.
symbol-change.csv
It would be nice to also check if the replacement symbol is the correct one, but I think that's not possible with the current structure.
Does this work? Is there a better approach?

symbol-change-mock.csv
I've tested with symbol-change-mock.csv. That's the same data, but the symbol change was removed.
This results in
Stillhalter-Gewinne                     109.85  109.85
Stillhalter-Verluste                    -67.43  -67.43
Stillhalter Gesamt                       42.42   42.42

while the original csv file shows
Stillhalter-Gewinne                     222.43  222.43
Stillhalter-Verluste                   -180.01 -180.01
Stillhalter Gesamt                       42.42   42.42

This implies the trades are recorded twice during the symbol change which is wrong.


Official 1.17 Release Docs

🛑 DO NOT MERGE 🛑 UNTIL KUBERNETES 1.17 IS RELEASED
Target Date: 2019-12-09
Release Deadline

Date
Description

NOV 8
Open placeholder PRs

NOV 15
PRs ready for review

NOV 22
All PRs reviewed and ready to merge

More information
contact: @daminisatya @irvifa @VineethReddy02 @pgburt

/hold

/milestone 1.17

@daminisatya check is failing 🤔

@daminisatya It looks like there's a failed CLA check that's breaking the PR. The last successful build was on October 26: https://github.com/kubernetes/website/pull/17065#commits-pushed-cce1b12, which is also where it started failing. Maybe start by looking at the PRs in that commit?
I'm curious how an unsigned commit was merged into the release branch in the first place. 🤔 The relevant PR should have failed its checks...

@daminisatya , How about:
https://github.com/kubernetes/website/pull/17065/commits/4442fd0533a2c078d8edaff7276b3f5cc2c329ec

/check-cla

This pr looks good https://github.com/kubernetes/website/commit/4442fd0533a2c078d8edaff7276b3f5cc2c329ec no sign of cla error as well, hmm

This pr looks good 4442fd0 no sign of cla error as well, hmm

Not sure exactly what is going on, but this commit could be reverted?

Is it save to do that? I’m not sure reverting it will fix the subsequent cla check error 🤔

@guineveresaenger logged a ticket with the LF cla team to give us some more information. It might not be that specific commit that is the problem.

Heather from the LF sent me the following:
There is at least one user who's commit is not properly linked to their github profile. From what I can see, it is https://github.com/kubernetes/website/pull/17065/commits/4442fd0533a2c078d8edaff7276b3f5cc2c329ec

The cla error in that commit links to the page https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user

Kevin will need to follow the steps in that github guide to get his commit properly authored before the tool will let him pass.

@kevtaylor - any chance this is you? Sorry for the trouble!

Heather from the LF sent me the following:

There is at least one user who's commit is not properly linked to their github profile.
From what I can see, it is
4442fd0

The cla error in that commit links to the page
https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user

Kevin will need to follow the steps in that github guide to get his commit
properly authored before the tool will let him pass.

@kevtaylor - any chance this is you? Sorry for the trouble!

Right. I noticed two email accounts. Perhaps one user/email account was used for the original commit in the PR and then another user/email account was used when rebasing this PR before merging?

@kbhawkey - the different email would do it if only one is cla signed.

@guineveresaenger I changed my CLA email since that original commit

@kbhawkey @kbhawkey Maybe the easiest way to solve this is to sign the CLA with the other email as well.

I agree with @VineethReddy02 after that let’s try to run cla check again..

/check-cla

/retest

@kevtaylor @kbhawkey Maybe the easiest way to solve this is to sign the CLA with the other email as well.

Hi! Since the changes are minimal (and could easily be created again), how about reverting or removing the original commit? Or is there an easier way?

@kbhawkey but signing the CLA would be the easiest. If that doesn't work we can revert and add the changes again.

https://help.github.com/en/github/using-git/changing-author-info
Are we allowed to do this?

@kbhawkey I cant resign with the original email because it is no longer visible to me.

@kbhawkey I cant resign with the original email because it is no longer visible to me.

Looks like we'll need to revert the commit and add the changes as a new one.

Yes! Let me revert the commit.
Commit hash - 4442fd0533a2c078d8edaff7276b3f5cc2c329ec

I think the PR will actually need to be rebased away instead of reverted (my bad), the revert still leaves the commit in place but undoes the changes.

I think the PR will actually need to be rebased away instead of reverted (my bad), the revert still leaves the commit in place but undoes the changes.

Yes, agreed.

I tried to rebase, and remove just 4442fd0 from the log.
However, It is getting more complicated with many more conflicts coming in. Is there any other way to resolve this?

@daminisatya - I'm happy to get on a zoom chat with you if you like!

Let me know if I can do something

@jimangel is this already merged to master?

@irvifa we closed this PR to do some work to fix up the dev-1.17 branch. A new PR should be opened to replace it. 👍


The "Projects" page in the Wiki disappear

What version of Go are you using (go version)?
not related
Does this issue reproduce with the latest release?
not related
What operating system and processor architecture are you using (go env)?
not related
What did you expect to see?
A page showing a curated list of Go (Open source) projects.
Original URL:
https://github.com/golang/go/wiki/Projects
What did you see instead?
Empty page

It causes the bad reference at:
https://github.com/golang/go/wiki

https://golang.org/pkg/

Thanks, looks like someone deleted it for some reason.  Restored.


MP: GO:0140404 | effector-mediated modulation of host innate immune response by symbiont

GO:0140404 | effector-mediated modulation of host innate immune response by symbiont |
should be a descendant of
GO:0140415 | effector-mediated modulation of host defenses by symbiont

I still don't see this parentage? Shoud I see it yet?

Well I see it in Protégé
The snapshot release has not worked since Jan 28
You can always look at the latest date the ontology was released here: http://snapshot.geneontology.org/metadata/release-date.json


Avoid resource naming conflicts

Better to add a namespace prefix to library resources. In this case, it will be something like pinkman_darkGray.
A developer can define the resource with the same name in his app and get pin view changed unexpectedly. Prefix avoids such cases.
https://github.com/RedMadRobot/PINkman/blob/05e076bcd06e234622d432fb7c0958f8f2893111/pinkman-ui/src/main/res/values/colors.xml#L3-L4
The same here. Better to add a prefix. For example <style name="Pinkman.DefaultKeyboard" parent="">
https://github.com/RedMadRobot/PINkman/blob/05e076bcd06e234622d432fb7c0958f8f2893111/pinkman-ui/src/main/res/values/styles.xml#L2
The same for the drawables.
circle_red -> pinkman_circle_red
circle_grey -> pinkman_circle_grey

@osipxd yeah, you're right. Feel free to send PR ;)


First test examples (TZ-1268)

Answers checklist.

[X] I have read the documentation ESP Zigbee SDK Programming Guide and tried the debugging tips, the issue is not addressed there.
[X] I have updated ESP Zigbee libs (esp-zboss-lib and esp-zigbee-lib) to the latest version, with corresponding IDF version, and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
last
esp-zigbee-lib version.
Last
esp-zboss-lib version.
Last
Espressif SoC revision.
ESP32-C6
What is the expected behavior?
I uploaded the sample codes for zigbee in 2 esp32 C6 (Light and switch code).
Purtroppo il devices con il codice Light riporta la seguente striga sulla seriale
(427) phy_init: saving new calibration data because of checksum failure, mode(0)
I (427) main_task: Returned from app_main()
I (487) phy: libbtbb version: 04952fd, Jun  4 2024, 16:38:26
I (497) ESP_ZB_ON_OFF_LIGHT: ZDO signal: ZDO Config Ready (0x17), status: ESP_FAIL
I (497) ESP_ZB_ON_OFF_LIGHT: Zigbee stack initialized
I (497) ESP_ZB_ON_OFF_LIGHT: Device started up in  factory-reset mode
I (507) ESP_ZB_ON_OFF_LIGHT: Start network steering
I (2897) ESP_ZB_ON_OFF_LIGHT: Network steering was not successful (status: ESP_FAIL)
I (6307) ESP_ZB_ON_OFF_LIGHT: Network steering was not successful (status: ESP_FAIL)
And it can't unlock at all.
Can anyone help me?
What is the actual behavior?
I expected the example to work
Steps to reproduce.

Step
Step
Step
...

More Information.
No response

@Elettronicosentino ，
Could you please share the logs from the switch side? When the switch device, acting as the coordinator, reboots, it will open the network for 180 seconds. If the network is closed, other devices will be unable to join.

As soon as I turn on the "switch" card the message appears and by pressing the boot button it appears
I (1586) ESP_ZB_ON_OFF_SWITCH: Send 'on_off toggle' command
180 Seconds Don't Pass
ESP-ROM:esp32c6-20220919
Build:Sep 19 2022
rst:0x1 (POWERON),boot:0xc (SPI_FAST_FLASH_BOOT)
SPIWP:0xee
mode:DIO, clock div:2
load:0x40875720,len:0x1804
load:0x4086c110,len:0xe2c
load:0x4086e610,len:0x2e5c
entry 0x4086c11a
I (23) boot: ESP-IDF v5.3.1 2nd stage bootloader
I (24) boot: compile time Nov  6 2024 15:50:39
I (24) boot: chip revision: v0.0
I (26) boot.esp32c6: SPI Speed      : 80MHz
I (31) boot.esp32c6: SPI Mode       : DIO
I (36) boot.esp32c6: SPI Flash Size : 2MB
I (41) boot: Enabling RNG early entropy source...
I (46) boot: Partition Table:
I (50) boot: ## Label            Usage          Type ST Offset   Length
I (57) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (64) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (72) boot:  2 factory          factory app      00 00 00010000 000e1000
I (79) boot:  3 zb_storage       Unknown data     01 81 000f1000 00004000
I (87) boot:  4 zb_fct           Unknown data     01 81 000f5000 00000400
I (94) boot: End of partition table
I (98) esp_image: segment 0: paddr=00010020 vaddr=42090020 size=1117ch ( 70012) map
I (121) esp_image: segment 1: paddr=000211a4 vaddr=40800000 size=06e74h ( 28276) load
I (129) esp_image: segment 2: paddr=00028020 vaddr=42000020 size=8b26ch (569964) map
I (247) esp_image: segment 3: paddr=000b3294 vaddr=40806e74 size=08220h ( 33312) load
I (256) esp_image: segment 4: paddr=000bb4bc vaddr=4080f0a0 size=022a4h (  8868) load
I (262) boot: Loaded app from partition at offset 0x10000
I (263) boot: Disabling RNG early entropy source...
I (276) cpu_start: Unicore app
I (286) cpu_start: Pro cpu start user code
I (286) cpu_start: cpu freq: 160000000 Hz
I (286) app_init: Application information:
I (289) app_init: Project name:     light_switch
I (294) app_init: App version:      1
I (298) app_init: Compile time:     Nov  6 2024 15:49:56
I (304) app_init: ELF file SHA256:  eb102551c...
I (310) app_init: ESP-IDF:          v5.3.1
I (315) efuse_init: Min chip rev:     v0.0
I (319) efuse_init: Max chip rev:     v0.99
I (324) efuse_init: Chip rev:         v0.0
I (329) heap_init: Initializing. RAM available for dynamic allocation:
I (336) heap_init: At 4081AF70 len 000616A0 (389 KiB): RAM
I (342) heap_init: At 4087C610 len 00002F54 (11 KiB): RAM
I (348) heap_init: At 50000000 len 00003FE8 (15 KiB): RTCRAM
I (356) spi_flash: detected chip: generic
I (360) spi_flash: flash io: dio
W (363) spi_flash: Detected size(4096k) larger than the size in the binary image header(2048k). Using the size in the binary image header.
I (377) sleep: Configure to isolate all GPIO pins in sleep state
I (383) sleep: Enable automatic switching of GPIO sleep configuration
I (390) coexist: coex firmware version: 4482466
I (405) coexist: coexist rom version 5b8dcfa
I (406) main_task: Started on CPU0
I (406) main_task: Calling app_main()
I (406) gpio: GPIO[9]| InputEn: 1| OutputEn: 0| OpenDrain: 0| Pullup: 1| Pulldown: 0| Intr:2
I (416) phy_init: phy_version 310,dde1ba9,Jun  4 2024,16:38:11
W (456) phy_init: saving new calibration data because of checksum failure, mode(0)
I (456) main_task: Returned from app_main()
I (516) phy: libbtbb version: 04952fd, Jun  4 2024, 16:38:26
I (526) ESP_ZB_ON_OFF_SWITCH: ZDO signal: ZDO Config Ready (0x17), status: ESP_FAIL
I (526) ESP_ZB_ON_OFF_SWITCH: Zigbee stack initialized
W (546) ESP_ZB_ON_OFF_SWITCH: Network(0xc5bc) closed, devices joining not allowed.
I (546) ESP_ZB_ON_OFF_SWITCH: Device started up in non factory-reset mode
I (546) ESP_ZB_ON_OFF_SWITCH: Device rebooted
I (1586) ESP_ZB_ON_OFF_SWITCH: Send 'on_off toggle' command
I (2346) ESP_ZB_ON_OFF_SWITCH: Send 'on_off toggle' command
I (3716) ESP_ZB_ON_OFF_SWITCH: Send 'on_off toggle' command
I (4346) ESP_ZB_ON_OFF_SWITCH: Send 'on_off toggle' command

Based on the above log, it indicates that the network has already closed. I recommend using the latest SDK, which will automatically open the network upon reboot. Please refer to https://github.com/espressif/esp-zigbee-sdk/blob/main/examples/esp_zigbee_HA_sample/HA_on_off_switch/main/esp_zb_switch.c#L120

@Elettronicosentino Please reopen if any follow up questions.


refactor symbol/market pair into Ticker class

A long slog but finally now done, along with the required changes in atacama. Horray!


Add hustle methods

Coverage remained the same at 79.554% when pulling a2761bf6d78e0dd3e4832f08587d6ffefe1a1871 on hustle into db59be979fb2dcb5366c3c3bc5c6b8cbf35353c6 on master.


x/website/internal/backport/fmtsort: failures in TestCompare and TestOrder due to out-of-order allocations

The x/website backports of html/template and text/template use a backported copy of internal/fmtsort.
That backported copy does not include the workaround for #49431, and even if it did it arguably shouldn't make the assumptions about non-moving channel addresses that are made in CL 361918.
We should probably at least either backport the test fix or remove the test cases that make invalid allocation assumptions.


RS configuration: proposed changes to @lekcyjna123's proposed changes

Instead of reviewing, I proposed some changes myself. Have fun! Changes:

Removed name from keys. Subclassing is an approach which is more descriptive and less prone to typos, so should be the default. Keys which have parameters are still possible, but should be created explicitly.
Removed dep_type too. As the key type implies the dependency type (in the recommended use case), it's not needed.
Created a hierarchy of abstract key classes:

DependencyKey is the base one. It has two type parameters: one for values related to the key, and the second for the values returned from the key.
SimpleKey is for keys which relate to a single value.
UnifierKey is for keys relating to potentially multiple methods, combined by an Unifier.
These abstract key classes should never be instanced, they are for subclassing.

Modified ComponentConnections so that all kinds of keys are treated the same.

Removing name from key classes is good idea, but how you want to realise value-parametrised keys? By creating a separate class which can get value as parameter during construction?

Removing name from key classes is good idea, but how you want to realise value-parametrised keys? By creating a separate class which can get value as parameter during construction?

Exactly, and thanks to the magic of dataclasses, everything will work just fine.
I think that this subsystem will require adequate documentation, but let's agree on an implementation first.

Made some changes to make this more polished. If this looks fine for you, let's start the merging party.


feat: add reader feedback buttons to the bottom of each page

Provide users a simple thumbsup/thumbsdown to signify whether they find the given page useful or not.
Resolves #264 (at least as a first effort)
Refs: #264, stellar/soroban-docs#586

Preview is available here:http://developers-pr265.previews.kube001.services.stellar-ops.com

Preview is available here:http://developers-pr265.previews.kube001.services.stellar-ops.com


⚠ Bofrost.at has degraded performance

In a63e8bf, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1972 ms

Resolved: Bofrost.at performance has improved in e50a264 after 9 minutes.


Add IAM signer

/cc @matthewg

FYI to @elibixby as well.

Nope, just 200.
On Wed, Feb 15, 2017, 4:03 PM Luke Sneeringer<EMAIL_ADDRESS>wrote:

@lukesneeringer commented on this pull request.
In google/auth/iam.py
https://github.com/GoogleCloudPlatform/google-auth-library-python/pull/108#discussion_r101415211
:

def _make_signing_request(self, message):

   """Makes a request to the API signBlob API."""

   message = _helpers.to_bytes(message)

   method = 'POST'

   url = _SIGN_BLOB_URI.format(self._service_account_email)

   headers = {}

   body = json.dumps({

       'bytesToSign': base64.b64encode(message).decode('utf-8'),

   })

   self._credentials.before_request(self._request, method, url, headers)

   response = self._request(

       url=url, method=method, body=body, headers=headers)

   if response.status != http_client.OK:

Are there ever cases where this particular API would send back successes
that are not 200? (Say, 201 or 202?)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-auth-library-python/pull/108#pullrequestreview-22143321,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc-3fMDD2cZ4053w7zE7onq-BugWvks5rc5JHgaJpZM4MCOf8
.

Is there any risk of that changing? Cards on table: I usually do status < 400 for this kind of check, since it seems more future-proof.
If you are pretty sure that everything returned from the IAM API will always be 200 for a success case, though, then this is good to go.

If you are pretty sure that everything returned from the IAM API will always be 200 for a success case, though, then this is good to go.

I feel like any change in that behavior should necessitate a change in our code. I also don't think they'll mess with it.


a11y considerations

Two options for how to hide the content:

Only hide it visually, but show it visually when a keyboard user tabs into it.
Don't display it at all, and only show it when activated with JavaScript.

I'm leaning towards the first option.

v9.0.0


Linker error regarding Xamarin.Android.Support.CustomTabs

When I build a release configuration of an app using the Share Plugin with the latest Xamarin.Android.Support.CustomTabs package I get:
/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/Android/Xamarin.Android.Common.targets:
Error: Error executing task LinkAssemblies:
error XA2006: Could not resolve reference to 'System.Void Android.Support.CustomTabs.CustomTabsIntent::LaunchUrl(Android.App.Activity,Android.Net.Uri)'
(defined in assembly 'Plugin.Share, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null') with scope 'Xamarin.Android.Support.CustomTabs, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'.
When the scope is different from the defining assembly, it usually means that the type is forwarded.

I put together a quick reproduction of the issue here:
https://github.com/brandonrisell/PluginTest
The steps I used to reproduce it:

Create a new Xamarin.Forms PCL project
Add the Share Plugin nuget package
I added a button that triggered the share plugin, but this isn't needed
Update the Xamarin.Android.Support.CustomTabs package from version 23.3.0 to 25.1.1

EDIT: Downgraded a different project that has this package to 24.2.1 and it appears so far to not have any issues with the linker

Change config to Release
Build Android project

Don't update that package there is no need to. I will have to generate an update build, but it is tricky with Xamarin.Forms where some developers wont have that version.

Duplicate of #43

Try: <IP_ADDRESS>-beta

Awesome, I'll check it out and let you know how it goes. Thanks James.

<IP_ADDRESS>-beta is built against 25.1.1 and validated working in the test sample app on 25-1-1-support branch. 5.x will remain on 23.x support libraries

Installed and working great, thank you so much James. You're such a hard working and motivating person, I really admire how much you do for the Xamarin community.


Text selection

Hello,
When I want to edit a text in a textbox, it's drawing a rectangle and doesn't select the text. Here is an example:

Any idea why ?
I have another question, I use the Picker for the autocomplete. My problem is that by default it only searches in the beginning of the text (like "startswith"), not in whole string. To change this I want to use the callback named onResolveSuggestions. Is it possible ? Do I have access to it ?
Thanks !

as I don't have access to onResolveSuggestions of the Picker, I tried to use the onRender of the column to display my picker. It works but I can't detect if I'm in edit mode, so the picker is there even if only in display mode. How can i get the edit mode of the row ? Thanks

Hi @David-Rousselle
Please you can take the latest version (1.11.0) that has enhanced feature for Picker Suggestions. It can now support string rules like 'STARTSWITH', 'CONTAINS', 'EQUALTO' etc. This way you can choose to define the rule based on which you want picker suggestions.
You just need to upgrade the package and add 'suggestionsRule: StringOperators.STARTSWITH' (or any other rule) in you grid configuration and this should work fine and unblock you. You can also refer to the ReadMe or GridConfig.tsx of the PR https://github.com/microsoft/FluentUIEditableDetailsList/pull/102 to see the fix.
As for the textbox selection, let me get back to you with a fix or further details about the behaviour.
Let me know if the picker fix works for you.

Hello @kushalmehrotra713 ,
You forgot to update the definition of IColumnConfig I think, I added it to test. It's not working, "contains" works like "startswith". I think I updated the package correctly.
Also, After asking the possibility to search in whole string with "contains" in my first post, I realized that it won't be enough for me. It's ok for the first picker "project", but I want to do something "cascading". Once I choose my project in the picker, I want the picker in the Task column to have it's pickerTags updated with some info I would get with REST. I then need to have the possibility to access the picker of the task column to update the pickerTags when the project is selected. Or, to control the suggestions dynamically when the user begins to type something in the task picker, with onResolveSuggestions for example.
Thanks a lot for your time.

Hi @David-Rousselle
IColumnConfig was updated in the PR that I checked in earlier. You can find the same in columnconfigtype.tsx in the PR https://github.com/microsoft/FluentUIEditableDetailsList/pull/102/files
Also, I have tested the package and it seems to be working fine with the suggestionsRule. As for "contains" functionality, "startswith" is always going to be a subset of "contains" functionality. In other words, any rule condition that is true for "startswith" is always going to be true for "contains" as well.
Now coming to the part where you are looking for cascading functionality. In the current grid implementation, its does not provide that support for pickers and dropdowns, but it can be achieved for controls like textbox, multiline textfields etc. However, I think its a valid ask. So let me see if I can achieve that in the grid in a holistic manner and not constrain it to a single use case. As you mentioned, allowing custom implementation for onResolveSuggestions can be one way to achieve that. Let me try spinning something up on that in a couple of days if thats ok.


Create Unit test for About you health

About your health
General question -check drop-down options
Heart disease question -check drop-down options
Diabetes question -check drop-down options
Asthma question -check drop-down options
Smoking question -check drop-down options
Kidney disease question -check drop-down options
Cancer question -check drop-down options
Medications -check drop-down options
Already had COVID-19 question -check drop-down options

Thank you for creating this issue.
We are reviewing our approach to testing + will update the guidance around testing once that is completed.


Add option to run selenium tests locally.

If no remote option is passed to nose, run tests with a local
selenium webdriver, defaulting to phantomjs. To switch local drivers,
pass the local option, e.g. --tc=local:Firefox; the value should
corresponding to the class name of the desired driver in the
selenium.webdriver module.
Note--not all tests pass locally. I'm guessing that this is related to timing issues (tests tend to run faster locally than on a remote vm, and we may be implicitly depending on that latency). Or I got the local configuration wrong, but there's very little going on there. I would suggest fixing the local tests in a separate issue, although it would be fine to address that here instead.

Would you mind adding a quick note in the README about running these tests locally?

Thank you kindly!


Implement --no-install-recommends for apt-get

Avoid additional packages by specifying --no-install-recommends.

FROM ubuntu
RUN apt-get install -y golang=1.22
FROM ubuntu
RUN apt-get install -y --no-install-recommends golang=1.22


fix: allow multiple _ parameters, and disallow _ as an expression you can read from

Description
Problem
I noticed you couldn't define a function like fn foo(_: i32, _: Field), it errored saying that _ is defined multiple times.
Then I noticed you can have code like let _ = 1; let x = _;.
Summary
Both things above are fixed with this PR (the first one doesn't error anymore, the second one errors with a message that's the same Rust produces).
Additional Context
Documentation
Check one:

[x] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Hm, it seems the debugger is inserting some "" for "" variables but I don't know where...


Ability to exit the room even when the game has already started

The players should be able to leave the room even if the game already started.
If only one player is left, then that player wins the game

Players should be notified that a player left and also if the creator rights were moved to another player.


Increase delayed_job max run time again

Since it's timing out at 28800 seconds/8 hours

Lol at @studentinsights-bot, thank you! :D


Attribute Object and Fields

Critical Changes
Changes
Creating object and fields for attributes
Issues Closed
Fixes #737
New Metadata
Custom Object
Attribute__c.object
Layout
Attribute__c-EDA Attribute Layout.layout
Translations:
Attribute__c-ca
Attribute__c-en_US
Attribute__c-es
Attribute__c-fr
Record Types:
Attribute__c.Credential
Attribute__c.Student_Characteristic
Deleted Metadata
Testing Notes

@xinnanlisf Is there a Github issue for this? And can you fill out the New Metadata section?

@juliesnow would you mind reviewing the release note here? Thank you!

@xinnanlisf @lifewithryan I just realized this was still Dev In Progress - are we ready to move the WI over to Ready for QA?

@lifewithryan this PR is good to go! You might want to take a look at those record type descriptions :)

@juliesnow Just pinging you here to let you know you have release notes to review on this one.

@lifewithryan - Thoughts on whether we should mention CBE in the PR text? (see https://powerofus.force.com/s/question/0D51E00004sFbR6SAK/traditional-grading-vs-standardsbasedcompetencybased-grading)

@lifewithryan - Thoughts on whether we should mention CBE in the PR text? (see https://powerofus.force.com/s/question/0D51E00004sFbR6SAK/traditional-grading-vs-standardsbasedcompetencybased-grading)

@juliesnow -- I wouldn't talk about CBE as I feel like that would be prescriptive in a way.


[Request] MySQL Support

This is by far the most ergonomic and safe ORM Rust has to offer - but it's really missing out without MySQL support. What is the timeline for that? What would be needed to make that happen?

Ugh.... Fiiiiiiiine. I cave.

I will try to tackle this for the release after the next, which I will work on after I get back from holiday vacation. So late January.

:D
I'd be happy to help if I can. I need to take some more time to look at the code, but would copying the SQLlite implementation and adjusting it to work with MySQL be a decent place to start?

No, Postgres is a better place to start. SQLite is fundamentally different.

👍

Any update on what you've done @logannc? Would it help to have someone else?

MySQL support has been fully implemented, and will be released with Diesel 0.11.


Release notes for 3.4.57, 3.5.27, and 3.5.27-upcoming

Offline review. Linkchecker always fails with new pages.


complete swagger documentation

we need to build on the work that esteban did, follow the same patterns to ensure that our swagger page (localhost:3001/docs) has the request and response shape documented
https://github.com/Nonprofit-Exchange-Hub/web-app/pull/299

first PR - https://github.com/Nonprofit-Exchange-Hub/web-app/pull/336 (/auth, /assets, /categories)


[Power Toys-Color Picker]: Color picker is not actionable with keyboard.

Microsoft PowerToys version
v0.79.0
Installation method
PowerToys auto-update
Running as admin
None
Area(s) with issue?
ColorPicker
Steps to reproduce
Test environment:
OS Build: Windows 11 Enterprise insider preview 23H2 (22631.3296)
Power toys version: v0.79.0
Repro Steps:

Open the Power Toys app in the desktop.
Select the color picker option from left navigation pane.
Now activate color picker with shortcut keys mentioned.
Now press tab focus will be on color picker and try to press enter or spacebar to activate the editor.
Observe the issue.

User Experience:
Users who rely on keyboard navigation or have accessibility needs may find it difficult or impossible to interact with the color picker effectively. This issue can hinder their ability to select colors efficiently, leading to frustration and potential abandonment of the task at hand.
Guideline Reference:
https://www.w3.org/WAI/WCAG22/Understanding/keyboard
Attachments:
https://github.com/microsoft/PowerToys/assets/117908911/5779ba0b-1542-4f31-846b-e54efaf34e02

✔ Expected Behavior
When a user presses the enter or space key while interacting with the color picker, the color selection action should be triggered, allowing the user to confirm their choice.
❌ Actual Behavior
Currently, when the user presses the enter or space key while interacting with the color picker, no action is taken. The color selection action is not triggered, resulting in a lack of responsiveness to keyboard input.
Other Software
No response

Closing this fixed at latest build 0.81


Automated cherry pick of #10863: fix(region): make cloudprovider sync worker configurable

Cherry pick of #10863 on release/3.5.
#10863: fix(region): make cloudprovider sync worker configurable

Codecov Report

Merging #10866 (e58efd4) into release/3.5 (6a15e02) will increase coverage by 11.89%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release/3.5   #10866       +/-   ##
================================================
+ Coverage         5.98%   17.87%   +11.89%
================================================
  Files              796       85      -711
  Lines           125693     8940   -116753
================================================
- Hits              7522     1598     -5924
+ Misses          117504     7170   -110334
+ Partials           667      172      -495

Flag
Coverage Δ

aFlag
17.87% <0.00%> (+11.89%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/baremetal/cronjobs.go
0.00% <0.00%> (ø)

pkg/baremetal/manager.go
0.50% <0.00%> (-0.01%)
:arrow_down:

pkg/util/seclib2/seclib.go
80.39% <0.00%> (-5.66%)
:arrow_down:

pkg/util/ansiblev2/session.go
0.00% <0.00%> (ø)

.../monitor/alerting/conditions/suggestrulereducer.go
0.00% <0.00%> (ø)

pkg/multicloud/ucloud/image.go

pkg/multicloud/esxi/virtualmachine.go

pkg/util/netutils2/netutils_linux.go

pkg/mcclient/options/k8s/configmap.go

... and 583 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5235b01...e58efd4. Read the comment docs.


Error when gpx contains Waypoints

When I use gpx with route, everything works fine.
when I add at least one waypoint I get error and maps is not shown even with route:
Uncaught TypeError: Cannot read property 'length' of null
at i._parse_gpx_data (VM463 gpx.min.js:formatted:366)
at i (VM463 gpx.min.js:formatted:293)
at XMLHttpRequest.o.onreadystatechange (VM463 gpx.min.js:formatted:286)
I used this, maybe there are some more mandatory parameters that are missing?
<wpt lat="xxx" lon="yyy"> <name>Name</name> </wpt>
Just check some other waypoints from the Issues, it turned out that <desc> is needed, but according to gpx specification it is not mandatory
https://www.topografix.com/gpx_manual.asp

Hmm, that's weird, it should already correctly handle this. This is how waypoints are parsed:
el = xml.getElementsByTagName('wpt');
for (i = 0; i < el.length; i++) {
  var ll = new L.LatLng(
      el[i].getAttribute('lat'),
      el[i].getAttribute('lon'));

  var nameEl = el[i].getElementsByTagName('name');
  var name = nameEl.length > 0 ? nameEl[0].textContent : null;

  var descEl = el[i].getElementsByTagName('desc');
  var desc = descEl.length > 0 ? descEl[0].textContent : null;

  var symEl = el[i].getElementsByTagName('sym');
  var symKey = symEl.length > 0 ? symEl[0].textContent : null;

  var typeEl = el[i].getElementsByTagName('type');
  var typeKey = typeEl.length > 0 ? typeEl[0].textContent : null;

  // ...
}

As you can see, I just call getElementsByTagName('desc') on each <wpt> element, which returns an empty collection if the sub-element <desc> does not exist; descEl should never be null.
Can you confirm you are using the latest version of leaflet-gpx, and share your code snipped and source GPX file so I can reproduce?

I had the same problem using v1.5.1 and a .gpx file that includes a waypoint (but no <desc> tag for the waypoint). I added a `' tag and found that it works correctly now.
This was not a problem with v1.5.0 - even without the <desc> tag, everything worked as it should in that version.
I can try to work up an example if that would help.

It is working if I change null in line 367 to the empty string, making it similar to how you coded this part in v1.5.0.

@jengalas Thanks! The Cannot read property 'length' of null was actually coming from further down in that function because name and desc could now be null instead of empty strings. v1.5.2 contains the fix.


FEATURE: separate config file for enable/disable of individual checks

For those of us that like to keep in sync with the mothership, setting enabled to true or false within the commands.json (soon to be commands.toml?) file will require a local merge every time a pull is executed. If this were done in a separate file, one could keep that independent and pull at will.

Agreed. I need to think of a smart way to keep track of versions of osxlockdown that takes into account the rules, allow people to potentially have their own additional rules, and allow them to enable and disable rules and maintain those preferences across new releases.

I've always been fond of *BSD's .local overrides: one file for stock settings, and a .local version which overrides those settings. Here, for example, a commands.json and a commands.json.local would be a solid model for my tastes. Internally, the app could load the defaults into a mutable data structure, then the override into the same.


still need to add CI workflows for reusing actions/stale

We still need to add CI workflows to other org repos to call this new reusable workflow for actions/stale
Originally posted by @2bndy5 in https://github.com/cpp-linter/.github/issues/23#issuecomment-2004175433

Great! I keep forgetting about this. I did write a sample workflow in #22. Maybe that could be the starting point.


Allow setting resources for StatefulSet or Snapshot/Restore jobs

ping https://github.com/k8sdb/operator/issues/96


Feature request: tmux integration

My iTerm2 profile is configured with Send text at start: tmux attach -t base || tmux new -s base, which automatically attaches to or launches a tmux session. Which means that when kube-solo-osx tries to launch commands in my terminal, it doesn't work (it just opens a new tab in iTerm2 which attaches to my tmux session and nothing else happens). Would it be possible to configure the app to open a new tmux window instead of trying to launch iTerm2?

I need to think how to use tmux, as I do not want to break App's work for everybody else who do not use tmux

Understood. Maybe if you could point me to the bash script I would need to edit to make this work, I could try to figure something out.


Operation killed issue using, two INSAR scenes to process

Hey there,
I am using 2 reframed sentinel-1 scenes to generate a large interferogram. AT the phase computation and correlation stage, the operation kills and the python interpreter terminates.
When I try to process again, I have to start from the scratch to do all steps because I need to run sbas = Stack(WORKDIR, drop_if_exists=True).set_scenes(scenes) to set the sbas parameter prior to running any sbas_computations (e.g., sbas reframe, sbas align, or geocode).
What could be the reason for such termination of session ? How to better handle such problem. Also, is there a way so that I don't need to restart from the scratch in case of such terminations, in order to save time ?? It might be lack of my knowledge in coding to be not able to handle this issue, but I am looking forward to your suggestions.
Thank you so much in advance for your guidance and patience...

The dask.persist() command materializes the results in memory. Do you have sufficient RAM to handle both the processing and the results? The code snippet you provided is recommended for educational purposes as it includes all the operations on the data. However, it is not the most efficient for big data processing. Instead, you can use the sbas.compute_interferogram_multilook() function, which optimizes the workflow immediately storing the results on disk. The usage of this function is well demonstrated in the PyGMTSAR examples.

Thank you very much for describing it. I got it. I will do as suggested and share updates :)

In case you cannot resolve it on your side, don’t hesitate to share your test notebook on Google Colab with public read access.

Thank you so much ! I definitely will once I give it a try :)


developer-guide: use the correct kernel config file name

kernel_arch was being set to amd64 instead of x86_64
on intel. The kernel config file name starts with
x86_64 and hence this needs to be fixed.
Fixes:  #158
Signed-off-by: Nitesh Konkar<EMAIL_ADDRESS>

lgtm

/cc @grahamwhaley


asset_tag error

I have a question.
I have 4 servers in the cluster, but when the script works, it adds an Asset Tag to one, and gives an error to the rest.

2021-07-06 17:46:37,313 - INFO: Updating NetBox 'device' object 'huaweix1.aso.rt.local' with data: {'asset_tag': 'Huawei'}
2021-07-06 17:46:37,510 - ERROR: NetBox returned: PATCH /api/dcim/devices/369/ Bad Request
2021-07-06 17:46:37,510 - ERROR: NetBox returned body: {'asset_tag': ['device with this Asset tag already exists.']}
2021-07-06 17:46:37,510 - ERROR: Request Failed for device. Used data: {'asset_tag': 'Huawei'}

Where does he get this parameter?

Asset tags are usually set in the iBMC of your Huawei server.
But you can just disable the sync of asset tags here:
https://github.com/bb-Ricardo/netbox-sync/blob/1337df6139129685c0a0a5c3ffad3defbfd26ddd/settings-example.ini#L185-L186
Then you should be able to sync without this error.

Thanks

You're welcome 😀


Android API key validation failed?

[x] Review the documentation: https://docs.viromedia.com/
[x] Search for existing issues: https://github.com/viromedia/viro
[x] Use the latest ViroReact release: https://docs.viromedia.com/docs/releases

Environment
Please provide the following information about your environment:

Development OS: Mac
Device OS & Version: Android 8
Version: ViroCore 1.11
Device(s): Pixel

Description
I added API_KEY to AndroidManifest.xml.
After running it, it crashed right away with this runtime error:    java.lang.NoClassDefFoundError: Failed resolution of: Lcom/amazonaws/auth/CognitoCachingCredentialsProvider;
at com.viro.core.internal.keys.KeyValidator.(KeyValidator.java:38)
at com.viro.core.ViroView.init(ViroView.java:178)
at com.viro.core.ViroView.(ViroView.java:153)
It seems like whenever I try to create ViroView, there is a step to check the credential.
So it fails at
CognitoCachingCredentialsProvider credentialsProvider = new CognitoCachingCredentialsProvider(context, "us-west-2:4079eab2-c426-4a9a-a9e7-c4a38ad886eb", Regions.US_WEST_2);
from KeyValidator.java
Then the question is how I can avoid that problem..
Reproducible Demo
It is crashing whenever it starts.

Hey @yjoo9317, thanks for filing the bug. Can you share the details on how you have set up your workspace? Were you simply cloning the ViroCore Sample code? Or did you download a new ViroCore Hello World project?

No. I was setting up just a simple app. Basically, I was trying to setup the view pointing to my_sample.obj file and I was trying to start from there. But while creating the view, it crashed at the above stack.

Thanks @yjoo9317.

I was setting up just a simple app.

By the above, what instructions have you followed to ensure that you have included the right Viro libraries and it's dependencies when setting up your Android application?
I strongly suggest ensuring that you double check both the build gradle settings and the android manifests in your Android app workspace to ensure that it is the same (or at least contains) settings as the ones in ViroCore HelloWorld or our ViroCore Code samples, so as to ensure that you are not missing any of the required dependencies.
If you are creating a new simple app, I would suggest using the ViroCore HelloWorld project as your starting base, as it would already contain all the required dependencies for Viro to function properly.

Thanks dthian..
That hello world project link was not within my watch somehow. I figured that some aws libraries are needed and I included jar files that seemed related to the error.
After seeing the helloworld project, I found 2 more libraries were needed.
Thanks for the help.


name attribute ValueError when running on the cluster

Hi and hope all is well!
I've caught a bug around the name attribute in Snakemake rules. Specifically the character : is not allowed and raises an error, but strangely only when running it on the cluster with the --cluster function. It also doesn't throw the error on dry runs, but seems only to be having an issue when interacting with qsub.
This is the error:
snakemake/7.32.3 is loaded
Traceback (most recent call last):
  File "/software/snakemake/7.28.1/lib/python3.11/site-packages/snakemake/common/__init__.py", line 47, in parse_key_value_arg
    key, val = arg.split("=", 1)
    ^^^^^^^^
ValueError: not enough values to unpack (expected 2, got 1)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/software/snakemake/7.28.1/lib/python3.11/site-packages/snakemake/__main__.py", line 4, in <module>
    main()
  File "/software/snakemake/7.28.1/lib/python3.11/site-packages/snakemake/__init__.py", line 3056, in main
    target_jobs=parse_target_jobs_cli_args(args),
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/software/snakemake/7.28.1/lib/python3.11/site-packages/snakemake/target_jobs.py", line 21, in parse_target_jobs_cli_args
    wildcards = dict(
                ^^^^^
  File "/software/snakemake/7.28.1/lib/python3.11/site-packages/snakemake/target_jobs.py", line 22, in <genexpr>
    parse_wildcard(entry) for entry in wildcards.split(",")
    ^^^^^^^^^^^^^^^^^^^^^
  File "/software/snakemake/7.28.1/lib/python3.11/site-packages/snakemake/target_jobs.py", line 19, in parse_wildcard
    return parse_key_value_arg(entry, errmsg)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/software/snakemake/7.28.1/lib/python3.11/site-packages/snakemake/common/__init__.py", line 49, in parse_key_value_arg
    raise ValueError(errmsg + f" (Unparseable value: {repr(arg)})")
ValueError: Invalid target wildcards definition: entries have to be defined as WILDCARD=VALUE pairs (Unparseable value: ' preprocess report:')

my snakemake rule is:
rule multiqc:
  name : "preprocessing.py: preprocess report"
  input:
    fastplogs = expand("results/preprocess/{sample_id}/report.fastp.json", sample_id = samples.keys())
  output:
    "workflow/report/preprocess/preprocess_report.html",
    "workflow/report/preprocess/preprocess_report_data/multiqc.log"
  params:
    search_dir = "results/preprocess/",
    output_dir = "workflow/report/preprocess/",
    tmp_dir = "$TMPDIR/multiqc/"
  log: "logs/preprocess_multiqc.log"
  threads: 1
  conda: "../envs/multiqc.yml"
  shell:
    """
    rm -rf {params.tmp_dir} {params.output_dir}
    mkdir -p {params.tmp_dir} {params.output_dir}

    multiqc {params.search_dir} -f -o {params.tmp_dir} -n preprocess_report.html 2> {log}

    mv {params.tmp_dir}preprocess_report* {params.output_dir}
    rm -rf {params.tmp_dir}

    """

The command that caused the error:
snakemake workflow/report/preprocess/preprocess_report.html --use-conda -j 88 -f --rerun-incomplete --cluster "qsub -N {log} -l nodes=1:ppn={threads} -l mem={resources.mem_mb}m -l walltime=120:00:00 -q test -o qsub.out -e qsub.err " -k  --rerun-triggers mtime

Two things resolved the error:

Removing the : immediately resolved my problem.
Running without the cluster with : included in my rule name.

snakemake workflow/report/preprocess/preprocess_report.html --use-conda -j 1 -f --rerun-incomplete  -k  --rerun-triggers mtime

Also wanted to add that adding a \ to escape the : pythonic dictionary format works, but It makes the name printed also have a backlash which is undesirable.


remove unneeded ClusterRole and ClusteRroleBinding in gateway

/cc @linsun @rshriram

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yangminzhu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: gyliu513
If they are not already assigned, you can assign the PR to them by writing /assign @gyliu513 in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lgtm pending tests passing

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
de579873309201ea29776790ca3caffdf649052d
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-integ-k8s-tests

@linsun @rshriram All required tests pass, PTAL. thanks!

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
de579873309201ea29776790ca3caffdf649052d
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Also handle/resolve orphan TXs when parents appear in a block

This should fix many of the mempool inconsistencies seen on mainnet when high load appears with many chained transactions.
This also backports bitcoin#15644 as we need the orphan handling to be callable from outside of ProcessMessage.
The PR is currently built on top of #3127 as it adds more testing to orphan TX handling.

utACK to merge after rebase

rebased on develop

Removing backport label as it turned out that this needs #3138, which in turn requires multiple follow up PRs.

@codablock #3138?

Sorry, I meant 60438257a5288a2f3e40b819b21e05dfa3101b9d which is part of #2931

@codablock Ah, ok 👍


[bug] email magic link Redirect to localhost:3000 after Vercel deploying

As the tiltle describing, after the vercel deploying, email magic link redirect to localhost:3000, so it won't work.

@maxchiron Make sure you set the auth url in the Supabase Auth Redirect urls to your domain. It should be in the readme under the Magic Link section

I figured out I need to change the default value 'site URL' here:

However, I do not know what URL to put in there. Putting the app homepage there just leads me in circles. So where should the link go to?

I have the same problem

+1 on having the same issue

Found the solution copy and paste this to email template > magic link after changing the URL
Magic Link
Follow this link to login:
Log In

Amazing, thank you @sonnylazuardi that fixed it for me!

I'm getting 404 error using the following template

Magic Link

Follow this link to login:

Log In

Generated link in email https://headshots-starter-clone-wx9z.vercel.app/auth/confirm?token_hash=a6b755c63a7c18e469499dfd6790775f765ce101f82dee3a98ad05a9&type=email


When pasting anything, I get every output 13x to console.log

When pasting anything, I get every output 13x to console.log. The text "getrennte" was pasted once and output 13x:

Is this correct? What could be the problem?

Yeah, what a nice coincidence: this is issue number 13! :laughing:

no way, I cannot reproduce the problem, can you make a simple jsfiddle or gist to demonstrate the problem? that would be really helpful! :smile:

It seems to have to do with the $('*') selector from the example:
  $('*').on('pasteImage', (ev, data) ->
    # ...

It seems to somehow traverse all the parent nodes of the textarea and appends the <div> to each node.
When doing
  $('textarea#boilerplate_intro').on('pasteImage', (ev, data) ->
    # ...

it seems to work. But I don't want to specify a fixed ID, I want to target all the textareas I have.
If this doesn't help yet, I will create a CodePen for it.


Cannot Use Host Networking

I have this Vagrantfile:
  config.vm.box = "google/gce"
  config.vm.provider :google do |google, override|
    google.google_project_id = "mycorp-user-dgarstang"
    google.network_project_id = "mycorp-vpc-sandbox"
    google.subnetwork = "http://www.googleapis.com/compute/v1/projects/mycorp-vpc-sandbox/regions/us-west1/subnetworks/default-us-west1"
    google.network = "default"
    google.google_json_key_location = "/Users/dgarstang/git/puppet-integration-image/mycorp-user-dgarstang-21dbe490a8d8.json"
    google.image_family = 'puppetint'
    google.zone = "us-west1-a"
    override.ssh.username = "dgarstang"
    override.ssh.private_key_path = "~/.ssh/id_rsa"
  end
end

When I perform a 'vagrant up', I get the following:
/Users/dgarstang/.vagrant.d/gems/2.4.9/gems/google-api-client-0.23.9/lib/google/apis/core/http_command.rb:218:in `check_status': invalid: Invalid value for field 'resource.networkInterfaces[0].network': 'global/networks/default'. The referenced network resource cannot be found. (Google::Apis::ClientError)

The network 'default' definitely exists as a vpc network in the referenced host network 'mycorp-vpc-sandbox'.
Earlier, I also had a local network called 'default' in this project and was being told "Subnetwork does not belong to the network.". This is further evidence that host networking is not working - ie it was looking at the default network in my service project, not the default network in the host network.
Can we please get host networking working? This is a really important feature!

This is still an issue.


add chainId selector to generate chain specific checksum

evaluate if worth to support EIP-1191 (add chain id to mixed-case checksum address)
ethereum/EIPs#1121
basically, it encodes the chain id + address so it helps user not to deposit token to the wrong chain address

I’ve outlined on the EIP discussions why it is not advisable to incorporate it, and there has been some discussions whether support in existing libraries will remove it; I’ve recommended against removing it (even though I’m against the EIP) from Web3.js and EthereumJS for the same reason: it impacts backwards compatibility.
But we should not go adding it to any new libraries. :)

close the issue based on above comment

Hi @gasolin I think it is a good idea (but not perfect) and the arguments in the long discussion referenced are contradictory. I can chat with you if you are interested.


Automated cherry pick of #6202

Cherry pick of #6202 on release-5.27.
/cc  @hahmadia

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.


debug_output on by default in config

Simple Q: Is there any performance concern for having debug_output on by default in the config?
My idea was to keep it on to be able to analyze logs and root-cause issues, vs enabling only after the issue, which maybe doesn't reproduce easily.
Or should I stick with just doing yabai -m config debug_output on/off manually?

I always run with debug_output on and the performance is fine imo. It doesn't really amount to much, it mostly just logs events as they get processed.
If you build from source you can enable some profiling marks to get rudimentary timing info, but it is far from finished. I think the command was make install CLI_FLAGS=-DPROFILE=2

If you build from source you can enable some profiling marks to get rudimentary timing info, but it is far from finished. I think the command was make install CLI_FLAGS=-DPROFILE=2

I'm interested on this. Built locally, but where do I find the timing info?

@koekeishiya upon inspection of the timing info, it seems events are processed fast.
However there is still latency/lag, and it seems it's because the processing of the next event only happens after a significant delay (~1s).
Any ideas what's going on in the non-timed process between events?

For completeness, here is how the profiling via the Instruments tool looks like:

The different operations in yabai seem fast and lightweight, but they happen very far apart in time (1s in this case).


MRG, ENH: Allow disabling FXAA

@bloyl @kingjr can you see if this fixes your OSMESA / remote rendering experience in mne coreg and stc.plot? For the latter you'll also need to pass stc.plot(..., antialias=False) and if you use PySurfer you'll need to be on https://github.com/nipy/PySurfer/pull/295
@GuillaumeFavelier can you take a look and make sure I disabled it in the right place(s)?

Everything looks okay to me @larsoner

I'll look more closely later today but this looks like it only fixes stc.plot?
Would it be possible to use a global config variable that is respected by the 3d renderers? That would have the benefit of fixing all 3d plotting (plot_alignment, etc.) and also let the same code work in a number of settings.

Ahh right, we'd need to update every 3D plotting function to take this argument. That's probably not so nice. We could have something like a mne.viz.set_3d_options(antialias=None) -- for now it would just be antialias as the only arg but eventually we might want to add other things (depth peeling?). @GuillaumeFavelier WDYT? Other API ideas? And also maybe we want a new MNE_3D_OPTION_ANTIALIAS so that users that always want this off can just set a bash env var and never worry about it.

update every 3D plotting function to take this argument

If it's global, why update every function? It's not like you would like to have specific plots with AA and some without it. I think we could just modify the renderers directly and mne.coreg. It's less painful to maintain too.
I like set_3d_options. Do we have a place to save such settings or we can just modify os.environ?

I like set_3d_options. Do we have a place to save such settings or we can just modify os.environ?

We shouldn't use os.environ to pass things around unless we need to. I think I know a simple way to implement it, let me give it a shot...

If it's global, why update every function?

I meant if we followed what I was originally doing we'd need to. With the global approach (implemented now), indeed we don't.
@GuillaumeFavelier can you look at the changes and let me know what you think? @bloyl in principle this should now work with all 3D functions in MNE. You can do either mne.viz.set_3d_options(antialias=False) in a given session, or set MNE_3D_OPTIONS_ANTIALIAS=false as an env var.

mne/viz/_3d.py is a nice place indeed, thanks for adding this. Also, LGTM

I pushed a commit to fix the import in _pyvista.py

Okay @bloyl @kingjr let us know if this helps and we'll go ahead and merge


Show unread count in account list

Attempt to fix #4515
There are a couple of issues with this PR:
The unread count is retrieved on the UI thread (needs to be decoupled)
There is a cosmetic issue where the account that's selected in the drawer, has its unread count text overwritten onto the avatar.
I'm not quite convinced that using the accountsLiveData as the source of changes of the unread count is always going to pick up changes to the unread count. It worked when I tested it.
I will go ahead and try to fix these, if @cketti is happy with the general approach.

@cketti Thanks for the review comments. I can't figure out why the badge is overwriting the account header in the drawer. Am I using MaterialDrawer wrong, or could it be a bug in that library?

I can't figure out why the badge is overwriting the account header in the drawer. Am I using MaterialDrawer wrong, or could it be a bug in that library?

It's done intentionally in MaterialDrawer. You can set a badgeStyle on ProfileDrawerItem to configure a Drawable that is used as the TextView's background. That way it could look nice. However, I don't see a way to use different badgeStyles for the list and for the profile image.
We could do some hackery and either not display a badge on the profile image or use different badge styles for the profile image and the list items. But it's probably best to create a feature request in the MaterialDrawer issue tracker.
I have no opinion on whether or not to display the unread count on the profile image. Not doing it is probably easier, because then we don't have to make it look nice :smile:

I have no opinion on whether or not to display the unread count on the profile image. Not doing it is probably easier, because then we don't have to make it look nice smile

OK with the new MaterialDrawer, I was able to remove the unread count on the profile image.
Anything else that needs doing?

Anything else that needs doing?

It looks like the wrong color is used for the badge text of the currently selected account. Otherwise :+1:

It looks like the wrong color is used for the badge text of the currently selected account. Otherwise +1

It seems you can either have the default colours (which makes the selected text look a bit wrong as it's some kind of greenish-blue), or you can set it to a fixed color, which I've just done (I set it to the account colour).
It looks a bit odd as the account name is just in black (or white, in dark mode). I can't work out what is the correct reference to use for the default text colour, I am reluctant to just code in WHITE or BLACK. Any thoughts?

Thanks :heart:


added end spawn power

I was looking for a power for the player to spawn in the end (for use with mods like BetterEnd). Let me know if I missed anything, but this is working on my side as far as I can tell.

Sorry, but I have been working together with @TheMisteryMan on a more general version of this power. It will be included in the next update. :) I appreciate the pull request a lot though!


Increase the touch slop.

It was 8.0. It's now arbitrarily 18.0.
Changing this required adjusting some tests. Adjusting the tests required debugging the tests. Debugging the tests required some tools to help debugging gesture recognizers and gesture arenas, so I added some. It also required updating some toString() methods which resulted in some changes to the tree diagnostics logic. Doing that required learning how those worked which required writing some documentation and adding some asserts, and that resulted in some code cleanup.
So... sorry about the yak hair, is what I'm saying.

cc @jacob314 for the tree description changes.

Do we know what that Android value of touch slop is?  Presumably we could also figure out via testing what iOSes is?  Or maybe those are irrelevant questions? :)

@eseidelGoogle I looked around but couldn't figure it out from the documentation. It may be configurable. Maybe we should actually be deriving our value from Android?

lgtm for the tree diagnostics logic changes.

For iOS its definitely possible to increase the hit region of a button:
https://stackoverflow.com/questions/808503/uibutton-making-the-hit-area-larger-than-the-default-hit-area
It's not clear to me what the definition of "slop" in this PR is.  Is it the hit-region which extends beyond the painted region of the button?

This patch increases the kTouchSlop constant: https://master-docs-flutter-io.firebaseapp.com/flutter/gestures/kTouchSlop-constant.html

LGTM

will land on green

Android doesn't have a "touch slop". This is the wrong way to fix this.

Not that I am volunteering to fix it. This is at least better than it was! :-)

Android technically does have a touch slop (try scrolling a list where you can tap the items). It's just that we apply it a bit more aggressively than Android does.

Coverage decreased (-11.6%) to 71.446% when pulling 409e7168d1c9d7fdaeb0e0745a3264d4cf7d8d77 on Hixie:wider-slop into 990dae85ebffb58dcc7b7b1fa911418584cbcff4 on flutter:master.


Make the yaml cache fully thread-safe

Concurrent::Map.new { |h, k| h[k] = Concurrent::Map.new }

is prone to a race condition, thus the cache won't be fully thread safe if definitions are parsed in multiple threads.
This PR fixes that.
Ref: https://github.com/ruby-concurrency/concurrent-ruby/issues/970

specs dont seem to be related to this change

Got it. WIll look at this today.

main is green, merging

@mensfeld  You missed the ||= that you've fixed in pull requests for other projects.

@granthusbands I did not miss it. I explicitly do not do it here to make the change small. I pointed out in the article that I wanted to keep the scope small because I do not know how given libs operate.

that you've fixed in pull requests for other projects.

Not exactly the same. In most cases, I fixed the internal ||=, not the external. Nonetheless you are right and feel free to create a PR :) @solnic should be happy


Use a cache invalidation system

We need to find a way to invalid the cache for get new comments.
We also want to provide an way to manually reload comments by clearing the cache.

Implemented with #28
Here we don't provide a way to manually reload the cache.
Developer can just reload the browser.


WebApp initial translation setup

Summary & Motivation
Adding translation setup using Lingui
Checklist

[x] I have added a Label to the pull-request
[x] I have added tests, and done manual regression tests
[x] I have updated the documentation, if necessary

Not sure why the build fails?
Please add more description to the pull-request. You can use this GPT that will help you, just write a rough description describing the changes.

BTW.... Please create an issue with the enhancement tag on the Kanban board and link to this pull request and link that issue to the Roadmap issue on the roadmap board.


Footer doesn't follow language + Spelling

The link to contact is always the English link. Also the Address field is currently wrong in both languages.
Dutch: Adres, English: Address, Currenly on the site: Adress.

Odd. It should be using the English version for both (as a compromise/simplification). Address is spelled correctly here which is what I thought the footer was drawing on.


Bug: Notification icon showing up even though the option is off

Describe the bug:

I keep the show notification icon toggle off, but after a reboot of the computer, the icon shows up again and again and I need to toggle the option on and off to fix it.
To Reproduce:
Steps to reproduce the behavior:

Go to 'Personalization'
Click on 'Show icon on system tray area' to turn it off.
Reboot the computer.
See error

Screenshots:

OS Version:

Windows 10 Version: 20270

ModernFlyouts Version:

Version: <IP_ADDRESS>

Additional context:
I have the top setting on.

Duplicate of #281.


[Feature] Make

This extension will hightlight embedding prompts those i have, that is great! However when I adjust the embedding prompt's weight to something other than 1, the highlighting doesn't exist.
I hope embedding prompts can be still highlighted if the weight != 1.
Thank you, i like this extension really, because it shows me what i write Intuitively.

Thank you for your suggestion for the extension! This feature is now supported.


Adds total comments

Add ability to get total comments per element id

Thanks for the PR!

 I just updated the README with instructions but I think you were too quick.

All good - it's in there now :smile:

Thanks boss!


Split image name into snapshot and release registries, with a separate path parameter

In the docker image generator, we were originally publishing all built images to the same registry. It is however useful to publish snapshot versions of one's Spark images to one registry, and release versions to another registry. As such, the schema for the configuration is now as follows:
sparkDocker {
  baseImage <full path to base image, including the registry and tag>
  imagePath <The path component only of the image name>
  snapshotRegistry <The registry to use when pushing snapshot versions>
  releaseRegistry <The registry to use when pushing release versions>
  tags <set of tags to push>
}

We follow the SLS versioning specification to determine whether or not an image is being built on a release version or a snapshot version.

@iamdanfox I switched to using a Property instead of a Provider, that's automatically computed read-only by the extension. I didn't address some of the other things you have mentioned, since I think they belong in separate refactor PRs rather than in a PR that is introducing new functionality.

@iamdanfox any further comments here?


Add new org.osbuild.bootupd.gen-metadata stage

New stage that runs bootupctl generate-update-metadata in the tree to transform /usr/lib/ostree-boot into a bootupd-compatible update payload.
This stage should be run on the sysroot of an ostree deployment or ostree-converted tree (after org.osbuild.ostree.preptree.
Tree-diff stage test included.

Question for the audience: I didn't add any options to the stage but the command does take one positional argument and that's sysroot.  However, it only accepts / as a valid value.  Perhaps we should add one in case it ever grows to work on non-/.  @cgwalters?

Perhaps we should add one in case it ever grows to work on non-/. @cgwalters?

We kind of decided recently upstream to not support the non-/ case, i.e. bootupd always runs from the target root because handling cross roots is hard.

Perhaps we should add one in case it ever grows to work on non-/. @cgwalters?

We kind of decided recently upstream to not support the non-/ case, i.e. bootupd always runs from the target root because handling cross roots is hard.

That's how I understood it, thanks for confirming.  Let's keep the stage without options then.


Move to async/.await?

No way of getting moved to async/.await and (maybe) supporting longpoll? I'd love it and can help with it.

(maybe) supporting longpoll

In my opinion this has little relation to async/.await, so please open a separate issue for supporting long polling.

getting moved to async/.await

I am certainly not against it!
The reason vk-bot is currently synchronous is as follows:

Initially, rvk was asynchronous (long before async/.await).
Then I changed it to be synchronous in v0.2.0 for some reason that I'm not entirely sure about now :sweat_smile:.
After some time I created vk-bot, and decided to go for synchronous as well (async/.await was also not a thing in Rust yet).

So for making it async/.await, the following needs to be done, I think (do correct me if I'm wrong somewhere):

Transition rvk to use async/.await. While this is likely not strictly required I guess, it'd certainly be nice for essentially the "backend" of vk-bot to be asynchronous as well in the first place.
This should be relatively straightforward, most actual changes would be in api.rs:

Choose a library to use. I think surf is a great option right now?
APIClient should store some sort of a Client if such thing is needed/exists in the chosen library.
call_method should be made async and use that library to call API methods.

Release a new (major) version of rvk.

Close Dependabot's PR attempt to migrate vk-bot to that version as it should fail, if I understand correctly.

Change vk-bot to use the new version of rvk.
A little bit more involved than step 1: while it should be straightforward theoretically, I'm not exactly sure how well/simply that'd work with Rocket. Anything mentioning API calls would probably need to be changed initially, and then rustc is your best friend, as always :wink:.

Release a new (major) version of vk-bot.

I'd love it and can help with it.

Awesome! Then I think you can start by opening a PR on rvk with the needed changes (also feel free to open a draft PR right away if you want).

The first and second parts are ready I think :smile:
But I'm a bit unsure about rocket because it supports async/.await only in git's version. What's about moving to any other framework or ...?

Ok, so u32i64/rvk#9 is merged now. As far as I understand, you'd like to change some other things in rvk as well.
So we could either:

Release new rvk version now and proceed with other changes to get async/.await support first, and then do the other improvements after that is done.
Or I will wait for your changes, and then we'll proceed on async/.await.

Personally, I think 1 is a better option. Do you have any preference?

But I'm a bit unsure about rocket because it supports async/.await only in git's version. What's about moving to any other framework or ...?

Hmm. Ideally I'd like to not change that... but I see that Rocket's async is still in progress, yes. The good news is that there are just a handful of HTTP requests that need to be handled, so switching shouldn't be that complex.
Do you have any preferred alternatives in mind? From my quick look warp looks good enough for vk-bot's purposes.

Yeah, I think warp is ok for this. I choose the second option. I'll write here when rvk is ready.

Ok, I think rvk is ready! I'll add async/.await support for vk-bot in next PR. Also I want to extend the features of vk-bot and release async/.await with them :smile:


Updating CN for node certs generated by vault

This allows the node authorization plugin to function correctly

ci check this

triggering CI for vault


PSA counter start/stop functionality?

The control plane API for counters includes start(index) and stop(index) methods, but I can't find a description of what they do. They look like they're meant to suspend/resume attempts by the data plane to count on a particular index, but the pseudocode in Appendix C doesn't implement this behavior.

I believe those were originally typed in by Calin @cc10512 and I believe I verbally asked at one time and the answer was something about that being useful for some debug situations, perhaps?
It may make sense to de-emphasize and/or delete the control plane APIs in the PSA specification, referring instead to the P4Runtime API spec, which is not at v1.0 release yet, but with a goal of reaching that milestone by June 2018.
I don't think start/stop functionality is included explicitly in the P4Runtime API spec.  I also recall a conversation in some PSA working group meeting that because counter update actions must be written explicitly in PSA programs (i.e. there are no automatic counter or meter updates implied that are not explicitly in the P4 source program, not even for DirectCounter or DirectMeter externs), that you can achieve the same effect as start/top by having one action that includes update actions for a DirectCounter, and another action that is identical except with no update action for the DirectCounter, and having the control plane API choose between the counter-updating action and the non-counter-updating action to implement start/stop behavior.

It's probably fine to move most of the API discussion, but if counter implementations do need to be able to be suspended it seems like that should be mentioned here in any case.
Using multiple actions works for direct counters, but currently start/stop are also defined for freestanding counters. Registers could also work.
There are tradeoffs for direct counters too. One issue with the current design is that all counters have to include start/stop bits, even if the user doesn't want that functionality. Multiple actions solves that, but requires the user to manually specialize actions and duplicate code. Another possibility is opting-in to a counter being suspendible via a constructor parameter.


I have a problem testing this in localhost (facebook)

Is there a quick way of putting this in dev mode for local testing?

what kind of issues do you have running it locally?


#152107320 users can see total recipe views

What does this PR do?
Users can see total recipe views
Description of Task to be completed?

modify getSingleRecipe action
modify view icons to eye
create middleware to get user id
modify getSingleRecipe controller
modify migration file to include views field
modify migration file to include userViews field
modify models to include views field
modify models to include userViews field
modify endpoint to getSingleRecipe

How should this be manually tested?
https://purpose-more-recipes.herokuapp.com/
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#152107320 users can see total recipe views
Screenshots(if any)

Questions:
N/A

Coverage decreased (-1.6%) to 82.723% when pulling db79c17f655711e9dd7439cef1ae29cd6411cb4c on feature/152107320/count-recipe-views into 0b9af5e97532156deafb1682ea0617fbdd3638e2 on develope.


Fix the tomcat-juli.jar to prevent a CNFE for juli logging

Probably you could have make a conditional add to the classpath and what about windows (.bat)


Simulation switching does not clean up state from previous simulation/recording

Something relevant in https://github.com/IRL2/nanover-protocol/pull/225 but doesn't quite address the issue. Interactions and selections should not persist between switches. Avatars etc wouldn't hurt. Box position?

Is this related to #302 ?

Is this related to #302 ?

Yes I think #302 is because of this -- I didn't see that you already created it


Clean doc, 3rd part

Third and last part of #173 and #174.

The last version 0.2.7 was released a year ago.
Can you release version 0.2.8 on pypi? @sylvchev @agramfort

Thx 🙏 @qbarthelemy


Daily PR from master to published

Proposed changes
Daily PR from master to published for October 29, 2019

Deploy preview for docsdocker ready!
Built with commit 13e226f2ac538ecba80abb85ab0c8435f31d18f2
https://deploy-preview-9759--docsdocker.netlify.com


Installation process and Update notification after GA

Currently, we have an update-notifier, each time someone executes odo command, it checks with github if there is a new version available and if there is it shows the following message that suggests that users can use our install.sh script to install or update odo.

Are we going to use this script even after GA
The script is using binary packages (hacky packages that no official repo will ever accept) and our deb and rpm repositories hosted on bintray.  I don't think that we should keep using it.
Shouldn't we just guide users to install it by copying odo binary to appropriate directory? we can use the install.sh script to automate it.
Windows installation process?

/priority high
/area release-eng

IMO, I always found the notification annoying and I have it permanently disabled.
Does oc even use it?
Also, past GA, I don't think we should use it as (theoretically) odo is stable and backwards compatible, so any new updates are new features + bug fixes.

I don't have a strong opinion with either keeping or removing this, but how do we intend to notify the user of a new update being available for odo if we remove this feature? There's a possibility that we will see BZ/issues opened for things that are already fixed by a newer version.

Resolution from cabal call:

we are keeping the update notifier, just updating the message, not using install.sh script as it is not portable (not going to work on Windows)
PR already opened for updating the message - https://github.com/openshift/odo/pull/2110
update notification message should point to the docs.openshift.com odo installation section (it can be via github releases). Message from update notified pointing to github releases, which points to docs.openshift.com


Update scalacheck to 1.17.1

About this PR
📦 Updates org.scalacheck:scalacheck from 1.17.0 to 1.17.1
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalacheck", artifactId = "scalacheck" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalacheck", artifactId = "scalacheck" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:early-semver, commit-count:1

Bumped in https://github.com/alexarchambault/scalacheck-shapeless/pull/299


PSPNet-Res101 parameter

Hi,
Thanks for your excellent work!
I would like to receive the model parameters and trains script file of PSPNet-Res101 used in paper Table 1. (b) experiment, PSPNet-Res101 -> DeepLabV3-Res18.

Thank you for your interests in our paper.
The results in  Table 1. (b) experiments are conducted on MGD codebase (based on MMSegmentation), whose training crop size is 512*512. And the PSPNet-Res101 pretrained checkpoint are downloaded from MMSegmentation official website.
If you are interested in this experiment, you can simply modify MGD loss to ours in MGD repo.

I can't find the PSP teacher model parameters trained with Cityscapes datasets. So, I trained it, but the performance is not as good as the 78.32% value written in your paper. Could you please give me the PSP model parameters? :)

Hi, you can download the checkpoint in this website: https://github.com/open-mmlab/mmsegmentation/tree/main/configs/pspnet

The site only provides parameters learned with the size of cityscapes 512X1024. I want to receive the parameters learned in 512X512. Since KD's performance of the teacher model is important for the same comparison, I would appreciate it if you could provide it to me by email. My email is<EMAIL_ADDRESS>thank you!!!


add metrics

What this PR does / why we need it:
It adds basic metrics
Which issue(s) this PR fixes:
Fixes #46

@alvaroaleman @metalmatze
PTAL

Two small points:

Please remove the healthListenAddress var and flag
Please add prometheus.io/{port,scrape}" annotations and  - -listen-address=<IP_ADDRESS>:8085` to the example deployment

Otherwise lgtm, awesome work!`

I will check that in a bit when I get to the airport.

@alvaroaleman done with 560cb5e and 15300cf
Very good catch!

Approved in the plane before taking off in Brussels. 😂


Make Script Repeatable

Can this line be changed to have a timestamp file ending so that it can safely be repeated

Any thoughts?


Please help me to setup this project on my computer

hello
Please help me to setup this proejct on my computer, i am getting error in database dump file

Can you share the backtrace of the error you're facing?


[SPARK-37429][PYTHON][MLLIB] Inline annotations for pyspark.mllib.linalg.init.py

What changes were proposed in this pull request?

Inline annotations for pyspark.mllib.linalg.__init__.py
Why are the changes needed?

Currently, there is type hint stub files  pyspark.mllib.linalg.__init__.pyi to show the expected types for functions, but we can also take advantage of static type checking within the functions by inlining the type hints.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Existing tests.

cc @WeichenXu123 .
If there are no reviews being done, I would be fine to go ahead as are. I will leave it to you @zero323 - I have less background on ML side ..

Merged into master.


Go to definition doesn't work for record syntax

Doesn't work for constructor

Doesn't work for fields

Thanks for the bug report, that definitely sounds like something that we should fix. If you want to take a look yourself, my guess would be that getSrcSpanInfos is the culprit.

It seems to work fine here:

... both for constructors and fields (though for fields it still refers to the position of the constructor).
Can you provide a minimal failing example?

I defined person0 and person1.
The only time I get the popup is when I hover over the Person constructor in person1.

And Go To Definition doesn't work anywhere in the person0 case.

I get definitions for the Person constructor in both person0 (due to https://github.com/digital-asset/ghcide/blob/master/src/Development/IDE/Spans/Calculate.hs#L122) and person1 (due to https://github.com/digital-asset/ghcide/blob/master/src/Development/IDE/Spans/Calculate.hs#L121). I don't get information about name or age because it doesn't have any cases that examine the record fields. This whole piece of code was copied wholesale from Intero, upgraded through a few GHC versions, lightly hacked for "things that didn't work", and could do with someone giving it some love. However, it shouldn't be that hard to make it a lot more powerful. If using SYB was OK then finding all names and grabbing the nearest enclosing Loc would probably be perfect.

If using SYB was OK

Has SYB been proscribed?

SYB seems to be responsible for a lot of problems, e.g. https://github.com/haskell/haskell-ide-engine/issues/1371. It's not fast and it is memory hungry. That said, it is concise and if it can be formulated properly, it's probably correct by construction.

I got tired of trying to verify manually what works and what does not, so I wrote some automated tests, which you can find here.
The one entitled "plain data constructor" passes while the one entitled "record data constructor" fails, which seems to agree with what @newhoggy observes above, as well as my own observations in both VSCode and Emacs; but it disagrees with what @ndmitchell observes above.

I get definitions for the Person constructor in [...] person0 (due to https://github.com/digital-asset/ghcide/blob/master/src/Development/IDE/Spans/Calculate.hs#L122)

Removing line 122, has no observable effect on any of the tests I have written. (I have confirmed that removal of lines 120, 121, or 147 does break some of my tests).

This whole piece of code [...] could do with someone giving it some love.

I'd like to have a go, but would benefit immensely from some pointers on how best to get stuck in.

@mpickering ported the hie code over as part of https://github.com/digital-asset/ghcide/issues/101#issuecomment-534498465. If we can use that implementation rather than our own that makes most sense - less code = better.

I have wanted to experiment with geniplate, in
order to generate efficient traversal functions. That might be worth looking into.

I've just test it in hls and works for me, i guess it should work in ghcide too.
@newhoggy feel free to reopen if it is no the case


[BUG] .opensearch-sap-log-types-config and .opensearch-sap-pre-packaged-rules-config should not exist

Describe the bug
Above two indices should not exist when starting cluster,
To Reproduce
Steps to reproduce the behavior:

Start cluster
cat shards

Expected behavior
If the cluster is just created, the indices should be clean.

@ryanqin01 AFAIK nobody is working on this, do you want to pick it up?

yeah sure, but how? any guide?

[Untriage]
I see two issues reported here:

Too many default indices that come with the plugins, some of them are.opensearch-sap-log-types-config, .opensearch-sap-pre-packaged-rules-config, .plugins-ml-config.

Some default indices does not honor the discovery.type=single-node and cluster does not show up as green. (As mentioned in the comment the hack is to remove the plugins and delete the indices)

@dblock should @ryanqin01 start with plugins that create default indices to honor discovery.type=single-node and show green when cluster started with single node? and then circle back for point 1 dealing with too many default indices?
Also is the build repo right place for this issue? :), we can have a META issue created in Core repo and child issues in each repo to honor discovery.type=single-node.
Some helpful links with this topic:
https://github.com/opensearch-project/security-analytics/issues/459
https://github.com/opensearch-project/ml-commons/blob/main/common/src/main/java/org/opensearch/ml/common/CommonValue.java#L61

I am facing a somewhat related issue. I am trying to use the opensearch-operator to upgrade a cluster from 2.8.0 to 2.11.1. The upgrade gets stuck because the cluster goes into a yellow state. After some debugging, I found that the problem is because version 2.11.1 creates a .opensearch-sap-log-types-config index by default. On a 3 node cluster, it requires 1 primary and 2 replica shard. So during the upgrade, the process gets stuck because all shards can't be allocated to a node.

Another workaround that doesn't require to delete any plugin.
Reduce the number of replicas for this index to 0:
/.opensearch-sap-log-types-config/_settings {"auto_expand_replicas":"false","index":{"number_of_replicas":0}}

Note:
this index is hidden, so you could search it with
/_cat/indices?expand_wildcards=all

Moving this to security analytics plugin to take a look.