[CI] Fix git diff on Windows runners

What does this PR do?
This PR changes the diff algorithm used on some files.

Motivation
On the windows runners' containers, we use MinGit (Minimal Git for Windows) which is a reduced sized Git. When running git diff between 2 commits, if one file in the diff has its format in *.doc, *.docx, *.docm, *.dot, *.dotx, *.dotm, *.pdf, *.rtf, *.ods, *.odf, *.odt, the command will fail with:
error: cannot spawn astexplain: No such files or directory
fatal: unable to read files diff

The git diff tries to run astextplain because of the config files:
gitconfig
➜ cat ~/Downloads/MinGit-2.26.2-64-bit/etc/gitconfig
...
[diff "astextplain"]
	textconv = astextplain
...

gitattributes
➜  cat ~/Downloads/MinGit-2.26.2-64-bit/etc/gitattributes
*.doc	diff=astextplain
*.DOC	diff=astextplain
*.docx	diff=astextplain
*.DOCX	diff=astextplain
*.docm	diff=astextplain
*.DOCM	diff=astextplain
*.dot	diff=astextplain
*.DOT	diff=astextplain
*.dotx	diff=astextplain
*.DOTX	diff=astextplain
*.dotm	diff=astextplain
*.DOTM	diff=astextplain
*.pdf	diff=astextplain
*.PDF	diff=astextplain
*.rtf	diff=astextplain
*.RTF	diff=astextplain
*.ods	diff=astextplain
*.ODS	diff=astextplain
*.odf	diff=astextplain
*.ODF	diff=astextplain
*.odt	diff=astextplain
*.ODT	diff=astextplain

The astextplain binary is not embedded in our MinGit version (2.26.2) (not sure why tbh), which is the reason why it fails.
That's why we're overriding the MinGit default gitattributes config to avoid using astextplain on the file formats above.
The MinGit's gitconfig file still have the problematic config though it should not use it anymore.

Additional Notes

This PR will fix the linters that broke in #19506. Because the new-from-rev feature in golanci-lint uses a git diff to work.
Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

Working !


[vulnerability] Disconnect outbound peers on the invalid chain

Currently, the outbound peers on incompatible chains may use up outbound connection slots (the ProcessMessage() function in src/net_processing.cpp). If the block header is valid, but the block is known to be invalid, and the peer announces the same block as being on its active chain, the peer should be disconnected.
A possible solution is to check whether the first invalid header in mapBlockIndex is at the end, if not, disconnect the peer (after line 1981 in src/net_processing.cpp).
Similar fix from Bitcoin: https://github.com/bitcoin/bitcoin/commit/37886d5e2f9992678dea4b1bd893f4f10d61d3ad.
Reported by 6004ed5feaa31ae9df36b5dbc60f0fa53255a5fb734334082c6d202405fc738c.

@patricklodder @rnicoll  Who is working on this? How can I help?

@patricklodder @rnicoll @michilumin
This fix requires a significant amount of work to implement properly. See Bitcoins, #11490 ( https://github.com/bitcoin/bitcoin/commit/d93fa261f079d529a94ff26aa406a49e28d10340 ),  where the merge description describes the kind of work I mean. For reference:
e065249 Add unit test for outbound peer eviction (Suhas Daftuar)
5a6d00c Permit disconnection of outbound peers on bad/slow chains (Suhas Daftuar)
c60fd71 Disconnecting from bad outbound peers in IBD (Suhas Daftuar)

Pull request description:

  The first commit will disconnect an outbound peer that serves us a headers chain with
 insufficient work while we're in IBD.

  The second commit introduces a way to disconnect outbound peers whose chains
fall out of sync with ours:

  For a given outbound peer, we check whether their best known block (which is known
 from the blocks they announce to us) has  at least as much work as our tip.  If it doesn't,
we set a 20 minute timeout, and if we still haven't heard about a block with as much work
 as our tip had when we set the timeout, then we send a single getheaders message, and
 wait 2 more minutes.  If after two  minutes their best known block has insufficient work,
 we disconnect that peer.

 We protect 4 of our outbound peers (who provide some "good" headers chains, ie a chain
with at least as much work as our tip at some point) from being subject to this logic, to prevent
excessive network topology changes as a result of this algorithm, while still ensuring that we have
a reasonable number of nodes not known to be on bogus chains.

  We also don't require our peers to be on the same chain as us, to prevent accidental
partitioning of the network in the event of a  chain split.  Note that if our peers are ever
on a more work chain than our tip, then we will download and validate it, and then either
reorg to it, or learn of a consensus incompatibility with that peer and disconnect.  This PR
 is designed to protect against peers that are on a less work chain which we may never try
 to download and validate.

Tree-SHA512: 2e0169a1dd8a7fb95980573ac4a201924bffdd724c19afcab5efcef076fdbe1f2cec7dc5f5d7e0a6327216f56d3828884f73642e00c8534b56ec2bb4c854a656

Subsequent to that, we will need to implement #11568 (https://github.com/bitcoin/bitcoin/commit/4637f18522429473e68f6f512a03040e121a446d),  and then the mentioned above commit.
I tried implementing only the suggest fix in the commit, but substantial changes will need to be made to src/net.h , src/net.cpp, src/net_processing.cpp, and possibly to src/validation.cpp as well --- I cant remember by now, after chasing so many logical nibles of code that needs to included to make that small suggestion above work.
Unless someone's got a subtle idea to make it work, this is all I got for now.

@patricklodder Given  #2459, let's move this one as well to 1.14.5.


Support IOperation explorer

Similar to #77 but on bound nodes.

@alrz What's the best current doc on IOperation and bound nodes?

Apparently, according to wiki, it's pretty much an in-progress feature. I can see that build-in analyzers also use reflection to invoke the internal GetOperationInternal method. :(

Thanks, I'll mark as external for now, until their work part is stabilized.

@333fred Thanks -- I'll take a look (depending on other priorities).

@alrz @333fred How do I get the root of IOperation tree? Does it have a root?

IOperation: Root type for representing the abstract semantics of C# and VB statements and expressions.

So I guess we can't have a single root, but for every method body, getter/setter and field initializer.

Would it work if I implement that within current syntax tree for now, and split later if needed (separate ticket)?

Having this within current syntax tree would make it easier to find a specific IOperation, so I think it's still a good way to do this, (without having a symbol tree on top - could be a separate feature but I'm not knowledgeable in that area)

Done:

If anything is missing, please raise as new bugs/suggestions.


[infra] Version xcode cache

There can be multiple xcode versions in use by infrastructure, and it would be better to version the cache as it's expensive to setup. Right now we use old_osx_sdk which is not easy to support.

This has been implemented.


feat(patch): fix #828, patch socket.io client

fix #828, patch socket.io-client.
I created a sample repo in here, https://github.com/JiaLiPassion/zone-socketio

Seems to be failing CI. Will merge as soon as we can get it green. (ping me on slack)


Fix session language decision in SessionDetailViewModel

Issue

Session language in detail page is always English #243

Overview (Required)

Change session id letter case from upper to small, because LocaleUtil constant value is lower case.

Links

https://github.com/DroidKaigi/conference-app-2017/blob/master/app/src/main/java/io/github/droidkaigi/confsched2017/util/LocaleUtil.java

Screenshot

Before
After

:eyes:

Good catch! LGTM! 💯  Thanks!


usage message + bugfix when using tslide in a pipe

@noffle no code review? 😢

You're right! I'm a villain. Please feel free to CR retroactively -- happy
to make revisions or push an emergency fix if I've goofed anything.
On May 26, 2016 2:29 PM, "Rafael Rinaldi"<EMAIL_ADDRESS>wrote:

@noffle https://github.com/noffle no code review? 😢
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/dominictarr/tslide/pull/10#issuecomment-222000394

@noffle NP man, just feel free to use my help whenever you want 👍

I will! Really happy this thing has such interest behind it.
On May 26, 2016 2:34 PM, "Rafael Rinaldi"<EMAIL_ADDRESS>wrote:

@noffle https://github.com/noffle NP man, just feel free to use my help
whenever you want 👍
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/dominictarr/tslide/pull/10#issuecomment-222001689


Please update OpenAPI schema

Hi @kislerdm ! Thank you for your project. Recently, we had an API update. One change about the project quota could break this SDK - now the quota field is nested in the settings field. I tried to update the schema and regenerate the code, but it failed because of the new project pagination. I am still trying to get to the root cause. So, opening this issue to remember. Let me know if I can help

@nikitakalyanov Hey Nikita! Thanks a lot for this feedback. I plan for execution on ASAP basis.


Proper reformation.

Now that we are getting started to move at a good pace, we need to have this repo formatted properly. The requirements are as follows:

Different directories for different concepts (for ex- all sorting algorithms in one directory, all searching algorithms in another)
A more robust and appealing README file
A dedicated directory for learning resources or notes to help beginners grow their knowledge in python (more importantly about different DSA and algorithms, reducing time and space complexities, covering edge cases, etc).

Any changes/suggestions in the contribution guidelines are also welcome at this point so that we can help even more users later on and work with more contributors.

@Dude-901  I can help you out with this

@Tanmay-901 can i help you with that

@mathieuschnd2 sure, go ahead and fork the repo and then send the PR. Look forward to it.


Add alias for shouldBeEqualToUsingFields and disallow specifying NO fields

Occasionally, I have to assert value-equality of Java class instances that do not implement equals() with kotlintest (also see this). For these cases, it would be nice to have a matcher that iterates over all fields via reflection (recursively) and asserts value equality for each.

@sksamuel are we still looking for alias? A part of it has been done in #1176

I think we just need to fix the bug that @sschuberth put up. Using shouldBeEqualToIgnoringFields gave kotlin.reflect.full.IllegalCallableAccessException: java.lang.IllegalAccessException: class kotlin.reflect.jvm.internal.calls.CallerImpl$FieldGetter cannot access a member of class org.apache.maven.settings.Proxy with modifiers "private"
I imagine its because his class has private field or something.

I imagine its because his class has private field or something.

Exactly, it Maven settings' Proxy.java which has private fields.

@sschuberth have a look at #1208 that will fix the issue

Done in #1208


Tests for upcoming features are being skipped on the analyzer

There are a huge quantity of co19 nonfunction type alias tests that appear to be being skipped, with a reference to github.com/dart-lang/language/issues/115
Examples:
LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/dynamic/*: Skip # github.com/dart-lang/language/issues/115
LanguageFeatures/Instantiate-to-bound/nonfunction_typedef/static/*: Skip # github.com/dart-lang/language/issues/115

@eernstg @athomas Is this intentional?  Unless there's something I'm missing here, we should be unskipping this ASAP.  Do we need to audit the status files for other skips here?

cc @scheglov

The issue/115 skips are removed in https://dart-review.googlesource.com/c/sdk/+/192930.

@eernstg please see https://dart-review.googlesource.com/c/sdk/+/193402

This is fixed.


Clarify and update language around WebAuthn

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


JBPM-5542: Stunner - Properties Panel and Process Explorer are shown for incorrect asset

The idea is refreshing only the affected docks when new dock elements are added or removed.
@ederign can you take a look? Does it fit what we talked yesterday?

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@mbiarnes could you please check why the jenkins is asking for approval? This should not be needed afaik.

jenkins retest this

jenkins retest this

jenkins retest this


in list of Available Resource Templates in Sinopia, make the first alphabetical sort be ascending, not descending

When a user first tries to sort the Available Resource Templates in Sinopia, either by Template Name column or by ID column, the system responds with a descending Z-to-A alphabetical sort. Users are expecting A-to-Z to be the first alpha sort. and then the second click would change to Z-to-A.

@jcoyne suggests having the ResourceTemplate list initially sorted in a consistent order. yes. we should do this. and the initial sort should be alpha ascending on Resource Template ID

just a note to say that this ticket requested sorting by template ID but was implemented as sort by Name. I think this is fine and maybe even better so no need to change, just want to document that the functionality we added is sorting by template name.

part of this did not get done, which is that when the user clicks on another column to change the sort key, it is supposed to sort ascending first. right now (on DEV) we are successfully sorting on template name by default. then if I click "template ID" column or "author", the first sort is descending, and it should be ascending.

I'll see if this is possible to set.

Replaced by #1296


Feat/undo changes

Issue https://app.zenhub.com/workspaces/climate-action-secretariat-60ca4121764d710011481ca2/issues/bcgov/cas-cif/378
I'm happy with the Happo screenshots

Two issues I noticed:

The undo button doesn't remove project contacts that were added, or recreate contacts that were removed. You'll want to send mutations to delete form_change records with the create operation, and revert form_changes with the archive operation to be update instead
Adding the undo button brought back the issue of the page layout moving when the saving indicator changes. One minor change that Suha was suggesting is to simplify the saving indicator and remove the date and outline. You can do this in another PR just after this one

Saving indicator PR will be here when ready: https://github.com/bcgov/cas-cif/pull/534


Built-in scripts don't open when clicking errors in debugger

Godot version
a98589a
System information
W10
Issue description
When you have error in built-in script and it appears in the debugger, the script won't show up if the scene containing it is not opened.
Steps to reproduce

Have error in built-in script
Have its scene closed
Click the error in debugger

Minimal reproduction project
ReproductionProject.zip

Doesn't seem valid in 3a48474, no idea what happened

Reopening because it's happening again in 66ab3ce
Or, like, it was never fixed. I don't know what happened with the previous comment, but it's wrong.


[WIP] Stacked-bar refactor and offset-bar

This is a Work In Progress, but thought it was worth sharing my current thoughts and notes at this stage.
Open questions:

is transposeCsv a good name for the component which takes d3.csv and converts it into series (plural!)
transposeCsv adds the name for each series as an array property. This feels a bit ugly,
but does retain a 2D array structure making it easier to datajoin.
The yDomain is a bit messy:

fc.util.extent(series, [function(d) { return 0; }, function(d) { return d.y; }])

This makes use of fc.util.extent to operate on arrays of arrays. It also ensures the domain starts from zero.
A couple of options spring to mind:

Create fc.util.max / min that also operate on arrays of arrays resulting in:
[0, fc.util.max(series, function(d) { return d.y; }])]

Use a d3.functor to make it easier to provide the zero domain minimum.
fc.util.extent(series, [0, function(d) { return d.y; }])

I quite like option (2).
Also, in keeping with the rebindAll var-arg API, this should also be possible
fc.util.extent(series, 0, function(d) { return d.y; });
TODO:

[x] Offset bar, the offset is currently applied via decorate, it should really be applied as an adapter around the xScale to keep decorate 'clean'.
[ ] Tests for transposeCsv
[ ] Look into the stackedBar decorate function, I'd prefer an easier way of colouring each series

Random thought, why do you need transpose?

That's a very good question, it is currently used so that we can render each
data 'attribute' or column using a single series.
For stacked bar we could render each 'stack' independently, however it wouldn't
work so well for line or area series where there is some natural connection
between each row of data in the original CSV.
Thinking about it, I'm not sure how we would employ d3's stacked layout without
performing a transpose operation.
On Wed, Sep 30, 2015 at 4:04 p.m., ScottLogic/d3fc
<EMAIL_ADDRESS>wrote:
Random thought, why do you need transpose?
—
Reply to this email directly or view it on GitHub
[https://github.com/ScottLogic/d3fc/pull/575#issuecomment-144439523] .[https://github.com/notifications/beacon/ABDBfiOv1_U5Rv5UELQxzsADfqp2TGYFks5o2_GZgaJpZM4GGUAy.gif]

Mike bostocks stacked line performs a transpose when mapping the data before
passing it to the stack layout:
http://bl.ocks.org/mbostock/3885211
However his stacked bar does not transpose for the reasons I mentioned earlier.
On Wed, Sep 30, 2015 at 4:04 p.m., ScottLogic/d3fc
<EMAIL_ADDRESS>wrote:
Random thought, why do you need transpose?
—
Reply to this email directly or view it on GitHub
[https://github.com/ScottLogic/d3fc/pull/575#issuecomment-144439523] .[https://github.com/notifications/beacon/ABDBfiOv1_U5Rv5UELQxzsADfqp2TGYFks5o2_GZgaJpZM4GGUAy.gif]

Replaced by #600


Have to reset the board in order to get the connection

Issue template

Hardware description:
ARM Base Ubuntu 20.04 and OpenCR
RTOS:
Installation type:
Version or commit hash:
ROS2 Foxy

Steps to reproduce the issue

Expected behavior
Agent should connect to OpenCR whenever I run this command
ros2 run micro_ros_agent micro_ros_agent serial --dev /dev/ttyACM0
OpenCR is programed with the example from the library (micro-ros_tf_publisher.ino)
Actual behavior
I have to reset the OpenCR board first before I run ros2 run micro_ros_agent micro_ros_agent serial --dev /dev/ttyACM0 otherwise I will not get the connection. Also, after I power the OpenCR for a while, it will enter the error_loop since the LED blinks. Moreover, once I got the connection and then I terminated ros2 run micro_ros_agent micro_ros_agent serial --dev /dev/ttyACM0 using Ctrl-C. I cannot get new connection anymore unless I reset the OpenCR again.
Additional information

Hello @fllay, the client will try to connect to the agent in rclc_support_init() for a certain amount of times with a certain timeout.
If this attempt fails, in this example, the app will fail. You can check the return value of this function and retry until the agent is reached. You can ping the agent in order to wait until it is available. But in general, you should handle the client-agent connection.
In your use case, if you open the agent and later the client, the client might lose all the opportunities to connect. If you open the agent and then the client, it will succeed.


Update exclusive-canonicalization.js

Fix for #95. The default namespace should not be rendered explicitly.

i'm no really sure if this change is compatible with the spec so we will wait for @yaronn to review this


[stable/mongodb-replicaset] Upgrade to MongoDB 4.2 ?

The chart mongodb-replicaset is currently supporting mongodb 3.6. May it be upgraded to 4.2 ?

Hello @olivierboudet ,
Today I tested the original mongodb-replicaset chart (that uses MongoDB 3.6 by default) and I managed to upgrade it to 4.2.7 successfully. I just changed the image tag in the chart to 4.2.7 and installed the modified chart. In case you currently have the chart installed with version 3.6 on persistentVolume its necessary to change the featureCompatibilityVersion before you go for the upgrade.
Dan

Hello,
Yes it works, I use it also with image tag 4.2.5 but there is some deprecated server options (mostly ssl options) which may be updated.

hello, quick example if someone has time.  https://github.com/weareopensource/rancher-catalog/tree/master/charts/mongodb-replicaset/4.2
Just ssl migration, adding this forgotten PR https://github.com/helm/charts/issues/12954, and rancher catalog
I'm sorry, not an expert and lack of time for PR, I had to make a repo for my need today, sticking to the Mongodb release. I would try to PR later asap.


doit reruns each time

Hi I'm still learning this library so its very likely that I did something wrong, but right now it seems that doit reruns all tasks every single time.
Initially I saw this behavior with code that a lot more complicated but then wrote example below to debug this issue, and I still see it.
def task_experiment():
    def touch():
        open('test','w')
    return {
        'actions': [touch],
        'targets': ['test']
    }

Then I run:

doit run --file=dodo_sample.py
.  experiment
doit run --file=dodo_sample.py
.  experiment
doit run --file=dodo_sample.py
.  experiment

Its very likely that I'm missing something obvious but I'm just not sure what it is.
Contents of my doit related files:
.doit.db.bak

'experiment', (0, 56)

.doit.db.dir

'experiment', (0, 56)

.doit.db.bat

{"values:": {}, "checker:": "MD5Checker", "deps:": []}

My system:
doit 0.31.1
Python 3.6.6
Win10

Also running strace produces:

. experiement
. strace_report

One more thing I tried using --chcek_file_uptodate with both timestamp and md5 options and they produce same outcome.

After couple hours of reasearch I found the problem.
Target is not file dependency, I had to specify file_dep to keep my task from reruning.

I believe this issue should be reopened and documentation should be changed.
Documentation does not mention that empty file_dep implies that target will be always executed, for example here: https://pydoit.org/tasks.html#targets Furthermore, the documentation contains example of task with empty file_dep field (https://pydoit.org/tasks.html#execution-order (create)) which behaves like that. The expected behavior can be achieved by setting uptodate property to True, but it should be reflected in the documentation (note in "Tasks" section with link to "More on dependencies").


chore: update ci-action workflow

I suspect npm i causes the recent build failures.
Example failure:
https://github.com/googleapis/code-suggester/actions/runs/3314347076/jobs/5473513904

The build is still failing


Add FK awareness (eg: Navigation Links) in Views

I have several views in my database for ease of navigation , eg, a subset of a table, or some prejoined tables.
But when one selects from a view, the displayed resultset in DBeaver does not recognized underlying foreign keys, and one loses the (very useful) features of Navigation Links.
This happens even for the simplest views, say CREATE VIEW v_mytable_a as select t.* from mytable t where kind  = 'A'
It would be nice if this feature is available.

Thank you for request.


Added attributes option when generate a model

This PR introduces a new option when you generate a model
lotus generate model car --attributes=brand,model

This command creates a file like this:
class Car
  include Lotus::entity

  attributes :brand, :model
end

@AlfonsoUceda I'm not sure about this change for a few reasons:

Even if we leave Lotus::Model as it is, the potential scope of this enhancement is larger that the actual. This opens to requests like typed attributes lotus generate model car brand_id:integer name:string.
We are holding our decisions about data (Lotus::Model and Lotus::Validations) until 0.7

@AlfonsoUceda Closing this for now.


Only two items

Why i can add only two items in my cart?
I press add product and in response see only two previos items. If i delete one, i can add another one. Some limit?
` class CartController extends Controller
{
/**
* @param Request $request
* @return \Illuminate\Http\JsonResponse
*/
public function add(Request $request)
{
$product = Product::find($request->id);
    if(empty($request->quantity)){
        $quantity = 1;
    }else{
        $quantity = $request->quantity;
    }
    return response()->json(Cart::add($product->id, $product->title, $quantity, $product->price));
}

public function remove($rowId)
{
    return response()->json(Cart::remove($rowId));
}

public function content()
{
    return response()->json(Cart::content());
}

public function total()
{
    return response()->json(Cart::total());
}

public function destroy()
{
    return response()->json(Cart::destroy());
}

public function update(Request $requests)
{
    return response()->json(Cart::update($requests->rowId, $requests->qty));
}

} `

There should not be a limit or anything. Which session driver are you using?

And the response of the add method is not the cart content.

I dont know. iv use Laragon 2.1.0.

About response it doesn`t matter, the main goal is to save in backend. Other stuff in Angular app.

Any idea? Earlier all works fine. I created backend side and frontend (Angular). Then i started to create markup from PSD and while I've working with checkout page i found this. =(

If i use SESSION_DRIVER=file all works fine. Weird...

https://github.com/Crinsane/LaravelShoppingcart/issues/48#issuecomment-50444846


feat: scale and mirror body

Description
Ability to scale or mirror a body
Issue linked
#1036
Checklist

[x] I have tested my changes locally.
[x] I have added necessary documentation or updated existing documentation.
[x] I have followed the coding style guidelines of this project.
[x] I have added appropriate unit tests.
[x] I have reviewed my changes before submitting this pull request.
[x] I have linked the issue or issues that are solved to the PR if any.
[x] I have assigned this PR to myself.
[x] I have added the minimum version decorator to any new backend method implemented.
[x] I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue FYI i renamed "mirror" to "map" since that's a more accurate description of the method. I also added unit tests, see test_body_mapping() for a couple examples

looks good! I am not big on documentation personally, but I feel like it would be a good idea to add a comment that describes the concrete implementation of scale() and map() or links them back the comment on their abstract counterparts.

The way autocomplete and linters work is that they will go to the abstract class to get the docstring in case they don't have a specific docstring implemented. This was an iterative process that @jonahrb worked on some time ago to figure out the best solution. I personally like it since that way we avoid duplicating docstrings and honestly the implementations are quite similar (if not identical). They are acting more as interfaces rather than actual "abstract" classes.


Flux updates

[x] Make the CLI easier to use by not asking the user to specify --app. They can simply write the app name.
[x] Add a CLI command for signing a payload
[x] Add a CLI command for formatting the env file in the correct format for deploying on Flux
[x] Add the first steps for updating env on enterprise nodes as a command

There will need to be a follow up PR in captcha-private once this is released.


graphback init throws an error when creating fullstack templates

Steps to reproduce
❯ npx<EMAIL_ADDRESS>init fullstack-issue

Choose one of the fullstack templates, for example apollo-fullstack-react-postgres-ts.
The following error is thrown:
Error: EEXIST: file already exists, mkdir '/home/ephelan/code/playground/fullstack-issue/client'
    at Object.mkdirSync (fs.js:840:3)
    at Object.<anonymous> (/home/ephelan/.npm/_npx/49060/lib/node_modules/graphback-cli/dist/init/starterTemplates.js:135:22)
    at Generator.next (<anonymous>)
    at fulfilled (/home/ephelan/.npm/_npx/49060/lib/node_modules/graphback-cli/node_modules/tslib/tslib.js:110:62)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5) {
  errno: -17,
  syscall: 'mkdir',
  code: 'EEXIST',
  path: '/home/ephelan/code/playground/fullstack-issue/client'
}

Looks like the backend templates already have a client subfolder so it can't create a new one.

Creating the backend template creates a client symlink:
client -> ../ts-react-apollo-client

Our init command takes client and trie to compose them. If you have already client app in the folder after seeing this error message then we can possibly rely on symlink when exporting data and ignore composition.

I think we should force override symlink when creating template using init.

Agreed.


[BUG]Strong password required

Describe the bug
The signup form allows users to create password without any minimum length requirement, which lead to very short and potentially insecure passwords.
To Reproduce

Go to sign up page.
After filling the user name and email.
Move to password input field.
See error.

Screenshots

I would like to work on this issue. Please assign it to me.

Hello, I've fixed this issue!
This is what I've done:
To address the issue of allowing short and potentially insecure passwords, we'll add a minimum password length requirement to the signup form. We'll update the Signup.js file to include a validation check for password length before submitting the form. We'll also add a visual indicator to show the user if their password meets the minimum length requirement.
Here's a summary of the changes:

Add a minimum password length constant
Implement password length validation in the submitHandler function
Add a visual indicator for password strength
Update the password input field to show the strength indicator

I also created pull request: https://github.com/kartikayasijaa/talk-trove/pull/172

[!CAUTION]
Disclaimer: This fix was created by Latta AI and you should never merge before you check the correctness of generated code!

This bug was fixed for free by Latta AI - https://latta.ai/ourmission


Tip for Encryption

The encrypted output is right adjacent to the current speed value and causes confusion, added a tip for newcomers.  Issue

@repos-jmp Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Could you submit this PR against the 1.3.x branch so we can easily merge it forward?

@repos-jmp Thank you for signing the Contributor License Agreement!

Codecov Report

Merging #730 into 1.3.x will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            1.3.x     #730      +/-   ##
==========================================
- Coverage   74.61%   74.55%   -0.07%
==========================================
  Files          72       73       +1
  Lines        2446     2448       +2
  Branches      354      352       -2
==========================================
  Hits         1825     1825
  Misses        467      467
- Partials      154      156       +2

Impacted Files
Coverage Δ

...config/server/encryption/LocatorTextEncryptor.java
72.72% <0%> (-5.06%)
:arrow_down:

...fig/server/config/EncryptionAutoConfiguration.java
86.66% <0%> (-3.81%)
:arrow_down:

...erver/config/SingleEncryptorAutoConfiguration.java
100% <0%> (ø)

.../bootstrap/ConfigServerBootstrapConfiguration.java
61.53% <0%> (+5.98%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54bcb47...673761b. Read the comment docs.

Will create a new pull request.


fix(docs) hostnames are allowed as well

The text was limiting to IP addresses, but hostnames can also be set (as well as Upstream names).

please have another look


Issues related to rendering Pod6 in GitHub

Hi! I'm implementing Pod 6 rendering on github.com using this library. Everything works great so far! Have a look:
https://github.com/kivikakk/pod6test/blob/master/test.pod6
There's only one nit, which you'll see in that example: class names are getting Pod::To::HTML:: prepended, I guess because the code is getting evaluated in the context of the module.
Here's a quick repro:
test.p6
#| Hello!
class XYZ {}

Using perl6 --doc=HTML:
$ perl6 --doc=HTML test.p6 | awk '/pod-body/, /\/div/'

XYZ: Hello!

$

Using Pod::To::HTML directly:
$ perl6
To exit type 'exit' or '^D'
> use Pod::To::HTML;
Nil
> for Pod::To::HTML.render('test.p6'.IO).lines { .say if /'pod-body'/ ff /'/div'/ }

Pod::To::HTML::XYZ: Hello!

>

Above is with Rakudo Star 2018.10. I've just installed Rakudo 2018.11 from scratch and tried with that, and the results are exactly same, weird no-toc) bit and all.

Oh hey, look, https://github.com/perl6/Pod-To-HTML/blob/master/README.pod6 renders now!

So, this is probably not the solution... but, is it?
diff --git a/lib/Pod/To/HTML.pm b/lib/Pod/To/HTML.pm
index 64f88ca..f195e63 100644
--- a/lib/Pod/To/HTML.pm
+++ b/lib/Pod/To/HTML.pm
@@ -301,7 +301,7 @@ multi sub node2html(Pod::Block::Declarator $node) {
         }
         default {
             Debug { note "I don't know what {$node.WHEREFORE.WHAT.perl} is. Assuming class..." };
-        "
"~ node2html([$node.WHEREFORE.perl, q{: }, $node.contents])~ "
";
+        "
"~ node2html([$node.WHEREFORE.perl.subst(/^'Pod::To::HTML::'/, ''), q{: }, $node.contents])~ "
";
         }
     }
 }

Hi, Ashe. First, thanks a lot for doing this. We'll do what we can to help you. But let me understand what you need. You need no class at all  there, or something else? We can implement a switch that, by default, does not include any class name (and the TOC part). Would that be OK for you? I don't think substituting it on the tail end would make a lot of sense, but it might...

Well, it does happen if you use Pod::To::HTML directly. Now that's weird.

But I think I know the reason why...

EVAL is used to render the pod, but that's done within the current package. That is why the namespace of the current package is appended, but only if you call it the way you do. That's by design, it's not an error. If you positively need to to that, we can try and fix it at the package level. At any rate, we do need to remove package names prepended to class names. So mid-term fix will have to be fixing that. And thanks!

FWIW, we're using a vendored copy of Pod::To::HTML for this (see https://github.com/github/markup/tree/master/vendor), so we can just update the submodule reference, publish a new github-markup gem and use that in github.com to get the latest fix. So let me know when you think it's ready! cdc6266 looks promising.

btw, this process has been a lovely introduction to Perl 6 for me! Really enjoying it.

It takes a full day to update the repositories, so it's not going to work until later today, circa 12pm Madrid time. I'll let you know. And thanks for all the work you're doing! Also, welcome to the community :-)

It's already in the repositories. You'll need to reinstall dependencies, since there's a new one now. Please reopen if you find any other problem or it does not really fix it.

Thanks so much. Changes underway now to use it.

There seems to be a few issues with the new Pod::To::HTML:

It only gets the first Pod "element" from a document, and ignores the rest.
e.g. https://github.com/kivikakk/pod6test/blob/3114490895bf9fb26ef8ab9fe0013b7f35c2cb80/test6.pod renders only the line "Pod 6, determined heuristically." If I remove the =begin pod ... =end pod section, it only renders the
, and not the Pod for the sub that follows. In short, most of the document won't be written out.

It writes temporary files that aren't cleaned up.
/tmp/perl6-pod-load is filled with Pod document fragments, and subdirectories under there are filled with compilation artifacts. We can't use this on our servers as-is -- it will fill up containers until they crash.

There is a race condition with tempfile writing.
See load in Pod::Load:
my $initials= $string.words.map( *.substr(1,1) )[^128]:v;
my $id = $tmp-dir~ $initials.join("") ~ ".pod6";
spurt $id, $string;

If I attempt to view two documents rendered via Pod::Load whose words have the same second letter, a race condition will ensue. Tempfiles should never have predictable names. Using File::Temp would shield you from race conditions, as it uses :exclusive when attempting to create the temp file (and retries in case the file already existed). It also ensures created files are unlinked, although an open issue on the GitHub repo for it raises questions about whether or not that really works due to reference holding.
It doesn't help with the precompilation file issue, as they get created by something else entirely.

I would like to use the new version to get this bug fixed, but all three issues are individually show-stoppers.

Maybe Temp::Path is better than File::Temp (see https://colabti.org/irclogger/irclogger_log/perl6-dev?date=2017-06-05#l313).

OK. I'm creating different issues for each one of them. Two of them are
easy, the other one, well, I don't know. Thanks for the advice!

Re: temporary files: You are going to have that all over the place if you use Perl 6, it's the precomp cache and you'll have .precomp files all over. I don't see an easy solution to that. We can remove them every time they are created, but that would have a (maybe small) performance penalty.

You are going to have that all over the place if you use Perl 6, it's the precomp cache and you'll have .precomp files all over. I don't see an easy solution to that.

It's fine if we end up with precompiled code as a result of running our Perl code -- it's not okay if we end up with precompiled code sitting on the disk as a result of converting Pod to HTML. (i.e. it's an artifact of converting a particular piece of Pod.) The first category won't grow with continued use, the second category will.

OK, I'm working my way through this. 1 down, two to go. Checking out Temp::Path now in JJ/p6-pod-load#2

OK, two down, one to go. This one is actually the messiest. Let's see.

Excellent! One last question. Precompiling this way appears to execute the referenced code, not just precompile it. For instance:
$ cat test.p6
use v6.c;

use nqp;

our $precomp-store = CompUnit::PrecompilationStore::File.new(prefix => './tmp/'.IO);
our $precomp = CompUnit::PrecompilationRepository::Default.new(store => $precomp-store);

my $id = nqp::sha1(~'my-file');
my $handle = $precomp.load($id)[0];
without $handle {
    $precomp.precompile('my-file'.IO, $id, :force);
    $handle = $precomp.load($id)[0] // fail("Could not precompile");
}
$ cat my-file
"hello".say;
$ perl6 test.p6
hello
$

More precisely, it's $precomp.load that causes execution, rather than $precomp.precompile. We can't execute arbitrary code on our servers in order to render documentation -- Markup isn't made for things which need sandboxing. (We've already had to disable the current Pod 6 renderer having realised the old version of Pod::To::HTML's use of EVAL was completely unsafe.)

The thing is that Pod6 is part of the language itself, not just some dumb comments. I was thinking about creating some Pod::To::Pod module that extracts just-the-pod out of a file. But even so there might be some way of executing code (via config passed to the Pod chunks). That can be eliminated too via a smart Pod::To::Pod module, though.

Is the same not true of Pod in perl5? Pod::Simple, which we use for perl5 Pod, doesn't appear to actually execute the given code.

In the way to fix the third part... Almost there now. The sanitizing part, that's going to be harder.

@JJ, have you looked at having the pod classes spit out their original pod again? If we could do that, sanitizing would be easy, but maybe I’m missing something.

@tbrowder yep, it was mentioned. The problem is, as @jnthn says here, it's almost completely impossible to parse something without running something. The only alternative is to split the Perl 6 grammar to get only the pod part. Do you think that's even possible?

Sorry, I’m muddling up the whole process in my mind. FWIW, much of the Rakudo pod parsing code has been separated from other grammar and actions in Grammar.nqp and Actions.nqp.

We'll have to check that out.

Find the pod-only sections by searching on “POD-ONLY” in both Grammar.nqp and Actions.nqp.
I think a separate, pod-only parser would be an interesting challenge!

I revisited comments of @jnthn on subject and he said a pod slang should do the trick, and it would be better than splitting off pod6 handling as a separate program. Breaking out the slang really looks way to complex for my p6 skills. I think Larry took quite some time on the last major slang work, so it’s not a weekend project for mere mortals for sure!

A recap of this issue; and what I'm thinking is a proposal for progress. Afaict my proposal is practical and requires no action on the part of GH.
@kivikakk got pod6 rendering working. But realized that it requires execution of a parser that can do arbitrary execution and therefore needs sand boxing. As they put it, "Markup isn't made for things which need sandboxing." (cf the 2009 discussion in my previous comment.) Then, unless I'm mistaken, JJ closed this issue with a solution that requires sandboxing, i.e. helpful for other situations but, aiui, even if working perfectly, is a non-starter as a solution for this issue.
 Maybe I'm missing obvious stuff. I'd be very happy to hear I've misunderstood. Until then the rest of this comment is a strawman proposal of what simple thing could be done next.
Afaict the only common sense conclusion is we must have a solution that avoids arbitrary execution on third party servers for rendering pod6. This is for GH and any other sane third party storage service.
Hence the following strawman proposal:

Authors in the P6 community start generating target translation files that are pre-rendered or renderable files that are in an existing format that doesn't require sandboxing for use when stored in repos. For example, given a file foo.p6 that contains pod6, foo's author could generate a foo.p6.md that contains a markdown version of the pod in foo.p6. Then this file could be copied alongside foo.p6 wherever it goes into a repo, such as when stored in a GH repo. The markdown version will then be available for clicking on, and will render appropriately, without GH needing to do anything.

We could/should/would also nail down a consistent convention to make this a little more organized, e.g. that any directory containing P6 source may contain a .doc subdirectory that contains these files that contain doc corresponding to the files in the parent directory of the .doc subdirectory.

We could/should/would create or modify tooling to make this easier.

We include a link in a source file to its corresponding doc file and from the doc file to its corresponding source file. The links could/should/would try to notice if their host source file and rendered doc file are out of step; avoid 404ing; and whatever else can be done to make this solution initially adequate (just a link) and eventually as good as it can be.

Maybe there's something we ask GH to do once we've got it together; but quite possibly this is an entirely autonomous solution and GH and other storage services don't need to do anything to support this.

@kivikakk plus if you're generating .md, GitHub is going to render it for you anyway. Only way out I see is to generate a module that renders pod6 via an independent pod6 grammar (which, as @AlexDaniel says, could be actually overkill) or some other method.


feature request: renew client certificate

regenerate-certs is there for server certs, but I could not find a way to regenerate my expired client certificate.  I walked through the issue on stack overflow.  Seems like it would be a relatively common problem, or will be soon.  I would expect the interface to be like the typical docker-compose regenerate-client-cert.
Summary:
docker-machine unexpectedly reports expired cert.  Server certs are not expired.  Client cert is:
$ docker-machine ls
NAME            ACTIVE   DRIVER         STATE     URL                          SWARM   DOCKER    ERRORS
foo          -        digitalocean   Running   tcp://x.x.x.x:2376           Unknown   Unable to query docker version: Get https://<IP_ADDRESS>:2376/v1.15/version: x509: certificate has expired or is not yet valid

$ openssl x509 -in cert.pem -text
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            c5:2a:9f:bf:d4:73:51:ce:c8:09:37:2b:8f:fb:9d:0b
    Signature Algorithm: sha256WithRSAEncryption
        Issuer: O=whatevs
        Validity
            Not Before: Feb 27 22:12:00 2015 GMT
            Not After : Feb 11 22:12:00 2018 GMT

Yes please this is maddening I guess not a lot of people have been using machine since 2015 ;-). Docker commands report this which I assumed meant server cert was expired:
error during connect: Get https://docker.example.com:2376/v1.36/containers/myproject_myservice_1/json: x509: certificate has expired or is not yet valid

What to do meanwhile? my certs has just expired.
Can I just regenerate cert.pem and ca.pem with openssl? any specifics to consider?

btw, that docker machine was created less than a year ago  (stat says ca.pem was create in 1st April 2017). But certificates has:
notBefore=Mar 13 03:22:00 2015 GMT
notAfter=Feb 25 03:22:00 2018 GMT

which are strange dates for that moment, and maybe there is another bug that leads to past dates

Suddenly today I am also getting this error in all my machines. Regenerate certs does not help either, any suggestions?

@splix https://github.com/docker/machine/releases/tag/v0.14.0-rc1

@shin- Thank you.
It seems it's not a particular machine certificate, but a root certificate is from 2015:
$ openssl x509 -in ~/.docker/machine/ca.pem -noout -dates
notBefore=Mar 13 03:22:00 2015 GMT
notAfter=Feb 25 03:22:00 2018 GMT

That date looks like a first use of docker on that machine, so probably a correct date. I just expected that certificate will be different for new remotes, I guess it was copied as is?
Anyway, I'm trying to regenerate it with using --client-certs w/o luck so far. Now I'm stuck with Too many retries waiting for SSH to be available.  Last error: Maximum number of retries (60) exceeded, that's crazy because SSH works perfectly to that machine. Not sure it's related to current issue, probably a different one.

@splix https://github.com/docker/machine/pull/4401#issuecomment-368670971

@shin- thank you, it helped


docs: add population data definition examples

Add data examples
specify (with comments) the datetime syntax as it's defined in OpenAPI 3.0.3, date-time:

@see: https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.0.3.md#data-types
@see: https://www.rfc-editor.org/rfc/rfc3339#section-5.6

Specifying the datetime output-syntax is important as for example by default the python/pydantic-setup serializes the datetime-type timezone information in the {date}T{time}+000 syntax instead of the openapi-specs zulu-code style: {date}T{time}Z.
Maybe the datetime syntax could/should be enforced with the pydantic-definition utils (like maybe a regex-pattern with the Field-class?) and regarding that: does the ioxio's converter-utility maybe contain any helpers for that kind of thing?

I merged in these changes. I can't right away comment on the comments on the datetime fields. I'd suggest moving that discussion to Slack.


fix code formatting

<@U4HKQNM2Q>  This page shows Search code as one line whereas it should show up as separate line after very pipe
https://help.sumologic.com/docs/search/get-started-with-search/build-search/best-practices-search/
Put pipe-delimited operations on separate lines
For readability, use a soft return in the query field to put each new pipe-delimited operation on a separate line.
Best approach:
_sourceCategory=Apache/Access and GET | parse "\"GET * HTTP/1.1\"\" * * \"\"*\"\"" as url,status_code,size,referrer | count by status_code,referrer | sort _count
Slack Message

fixed in source

fixed in source

hi @MariePMcGarry , if you've fixed it, you can close out the ticket below


Add a few patches to v0.24

Tauri version 1 will stick to 0.24 but there are a few patches I think are good to merge into it too.
Here are the commits and pull requests I would like to merge:
#865
https://github.com/tauri-apps/wry/pull/867

I open a branch v0.24.1. Please open a PR against it.

Closing as we periodically put patches to v0.24.1 when needed, we don't need an issue to track


grt: disallow 1-track gcell near macro obstructions

Fixes https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/issues/2382.
The two DRCs in asap7/swerv_wrapper are caused because GRT is using the only free track in M3 inside of a GCell that overlaps with a macro. When DRT uses this track, a violation happens in a M2-M3 via.
This PR disallows GRT to use single-track gcells that overlaps with macros to avoid via violations with the macro obstruction.

Metrics update here: https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/pull/2404


Week 4: FRQ #1 and Iteration Mini-Lab

[x]  Iteration Mini Lab

Made my own bat rhyme with names

Displayed monkeys horizontally and bats vertically

Answered some hack questions

[x] 2018 FRQ 1

Went through and answered FRQ thoroughly

Included thought process and scoring guidelines

[x]  Group Presentation: Methods and Control Structures

Created lesson

Made hacks questions

Collaborated with team mates on presentation

Added Jazair's Scrumboard to the main page of our group repo

Self-grade
+2.7/3.0

I was very thorough with the FRQ
Collaborated effectively with team
Iteration mini-lab: I added the bats and did a whole other rhyme, in addition to the monkey

2.7+/3

Explained methods and control structures well
Had additional resources

Good images to support information

Demonstrated extra information about control structures
FRQ answered thoroughly.
Also explained conditionals and iteration very well

Grade: 2.7+/3
Great job! Definitely went above and beyond! :)

Thorough method lesson with examples and explanation

Linked additional resources and videos

Thorough control structure lesson

Good diagrams and examples to support
If-else, ternary operators, switch cases
Loops: for and while loops

FRQs done well
Creative iteration labs

Commenter: Samuel Wang

The methods talk was very thorough and a lot was explained, with an example being included to help us understand it better
the control structure model was very helpful to our learning, ifelse statement examples were also really helpful, loops and break-continue stuff was also well explained
for the frqs, it was well explained what they had to do and what they ended up doing and why

2.7+/3
Kian Pasokhi

I like how you guys explained how to make and call a method then showed specific examples.
I like the teamwork and how you guys always said, "we," rather than singling yourself out.
I really like the visual representations you gave.
Showed very good understanding of conditionals and iteration.

Overall showed a lot of collaboration and cooperation. Showed teamwork and handwork. Explained everything clearly and showed a perfect understanding of the assignment.

notes/lesson on methods and control structures
Review of previous material (switch case, if, loops?) (ellen and Jazair)
Thorough explanation of the FRQ 2018 (Hetvi and Brian)
Iteration lab: extra ascii art created of a car (different rhyme) (Jazair)
Explanation of problem solving for ascii art display (Brian)

Commenter: Andrew Meng
2.7+/3

Methods and control structures extra lessons
Extra hacks for review
Full process of FRQ 2018 (Hetvi and Brian) and FRQ 2019 (Ellen and Jazair)
Iteration with extra ASCII art and rhymes

Commenter: Bailey Say

brian and hetvi talked about methods, and using methods
ellen and josair  talked about control structures and using them in example code
made a well organized blog about methods and control structures
each pair explained the frq's well with comments in the code examples - included scoring from CB
iteration labs were unique for each group
Included extra in the lesson about methods and control structures
2.7+

productive blogging (lesson) on control structures and methods
work as a team/pairs
review of previous material and elaborated on it
good frq explanations and ties to learning

Score 2.7+/3

2.7+/3.0

had a lesson for methods in java with examples of code
Added hacks to lesson
Had their FRQ done with comments in the code
Iteration lab all had different hacks for each person

2.7+/3 for everyone

presented a lesson on methods and control structures with sample code and hacks
solved FRQs with comments on what the code is doing
finished iteration mini-lab with hacks

Hetvi - less on methods.   Creating and Calling.  Added hacks for lesson.
Brian - back and forth on methods lesson.  Good introductions.
2018 FROGS done together.  Hetvi Introduced and talked on part A.  Brian took over on part B.  discussed key area and had nice comments on key lines of code.
Hetvi Bats poem and names.
Brian Wise Monkeys, discussed , horizontal.
Ellen - discussed Control Structures.   Had some nice visuals all integrated into Blog.  Discussed Ternary operator (shorthand) syntax.  Back and forth then to Loops discussed condition of continuation.
Jasair - discussed if else statements.  gave a couple of simple examples.  Later talked about Switch Case.   Break and Continue discussed on loops.
2019 leap year.  Header block comments, no inline.  Ellen did description of FRQ.  Got a little loss in details, I think comments on key lines would help.
Jasair talked about car adaptation.  Changed ASCII art
Ellen adjusted to horizontal.
Good team transitions and excellent depth.  3.0 for Brian, Hetvi, Ellen, 2.9 for Jazair as a little less on depth in presentations.

2.7+ for everyone.

Finished mini-lab with hacks and added ASCII art, made it unique
Did FRQs and had notes on how they did it
Made lesson for methods
Well organized presentation

Crossover Grade 2.7+/3.0

Completed iteration mini lab
Completed 2018 FRQ 1
Did a good job creating a thorough presentation on methods

Could be improved:

Could have been more creative with implementation of iteration mini lab


Rewrite all shell scripts in Python

This PR replaces all shell scripts with Python equivalents. Even for the smaller scripts, this can result in something that is more readable, safer, and faster. I have tried to comment on things that look tricky but this should be a lot simpler to overstand overall. The biggest change is generate.py, which is now able to just call generate_tuxsuite.py and generate_workflow.py directly through the main functions.

This is great -- I don't know how the performance compares, but looks better to me indeed :)


Add yaml file for perf

This PR and future related PRs will be transformed into performance-CI, benchmarking different operators with various input parameters. For now, we are starting with GEMMs. In the future, we will add convolution, flash attention, and other operators as needed. The ultimate goal is to create performance plots for those operators so we can see their performance daily.
The perf.yaml file is added to the repo to distinguish between Performance and CI related operations.

Wait what's the motivation here? Looks like it's running the same commands to me. A PR description would help

The motivation is that we want a separate performance-ci that is only run nightly and can be triggered with a button. (as opposed to the ci that is triggered on every commit). For now, they are identical but we will change the performance-ci to be more compute heavy in the future.

That general direction sounds good to me, but can someone write out more of a plan in the PR description and/or an issue? I'm curious which tests /  benchmarks will be running. I want us to be able to connect what the workflows are running with the project overview in the README, for example (AOT export, eager execution, custom ops). I think some organization around the project roadmap will go a long way.

The motivation is that we want a separate performance-ci that is only run nightly and can be triggered with a button. (as opposed to the ci that is triggered on every commit). For now, they are identical but we will change the performance-ci to be more compute heavy in the future.

That general direction sounds good to me, but can someone write out more of a plan in the PR description and/or an issue? I'm curious which tests / benchmarks will be running. I want us to be able to connect what the workflows are running with the project overview in the README, for example (AOT export, eager execution, custom ops). I think some organization around the project roadmap will go a long way.

This PR and future related PRs will be transformed into performance-CI, benchmarking different operators with various input parameters. For now, we are starting with GEMMs. In the future, we will add convolution and flash attention as well as other operators as needed. The ultimate goal is to create performance plots for those operators so we can see their performance daily.

Cool, that sounds good. Can we push adding this CI to when the workflows are actually different. As long as they are the same, you can just use the CI trigger/nightly that is happening


Use test/common as basis for a more convenient API

It looks like the tests use a slew of convenience functions provided in mysql/test/common.d. This suggests that the API provided is inconvenient. It also means that the tests can't easily be used as a guide for how to use the regular API.
Since the tests use a more convenient API, it would be nice if the primary API were augmented with those additions.

I agree. I just wanted to put a little but more thought into them before exposing them publically.
For reference, the functions in question are here:
https://github.com/mysql-d/mysql-native/blob/master/source/mysql/test/common.d#L102

Fixed in v1.0.0


Add some kind of "doctor" command.

Whether it's part of git media init, or a separate sub command, Git Media should verify that its requirements are met, such as having the correct version of Git.
Here's how homebrew does it:
$ brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry and just ignore them. Thanks!

Warning: Your Homebrew is outdated.
You haven't updated for at least 24 hours, this is a long time in brewland!
To update Homebrew, run `brew update`.

It'd be cool to teach Git Media how to file issues to us somehow too.

Zero feelings!


How do I connect to MAPR Hive Clusters using DBeaver?

I've downloaded the mapr drill odbc driver, but I'm clueless after that. Any ideas?

You could try ODBC driver in DBeaver (available only in Windows version).
You will need to configure ODBC datasource in windows ODBC admin tool.
Then create new ODBC connection in DBeaver - just set datasource name (in Database/Schema field) and user credentials (if needed).

Hmm... so this won't work for the mac edition (which is where & why i use DBeaver)

Then you should use JDBC driver (it works on Mac as good as on other platforms).
You could try to use preconfigured Apache Drill driver (http://maprdocs.mapr.com/home/Drill/Downloading-Configuring-Driver.html)
Also some docs are here: https://mapr.com/blog/connecting-apache-hive-to-odbc/#6

It looks like this question was solved. It will be closed. If you think that it is actual just let us know.


Fixes on catching rules in dataHelper.cs. #163

For #163

Code changes look good but something is still wrong with the pinning rule.
Expected
The left sidebar column on /websiteeditor/surfacegroups should render the help topic "What is a surface?"

Actual
The left sidebar column does not show the help topic.

It's related with https://github.com/StarcounterApps/Website/issues/154. Currently there is a problem with parameterized URIs. If You try with any uri without parameters, then It should work. Since It's not part of this issue please confirm if It's mergable.

FYI, the issue with rendering of the "What is a surface?" area was fixed


Error creating Key Vault using azcli from Cloud Shell

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az keyvault create
Errors:
400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 206, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 608, in execute
    raise ex
cli/core/commands/__init__.py, ln 666, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
cli/core/commands/__init__.py, ln 659, in _run_job
    six.reraise(*sys.exc_info())
...
python3.6/site-packages/msrestazure/azure_active_directory.py, ln 486, in get_msi_token
    result.raise_for_status()
python3.6/site-packages/requests/models.py, ln 940, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az keyvault create -n {} -g {} -l {} --enable-purge-protection {} --enable-soft-delete {}

Expected Behavior
Environment Summary
Linux-4.15.0-1067-azure-x86_64-with-debian-stretch-sid
Python 3.6.5
Shell: bash

azure-cli 2.0.81

Additional Context

Hi @bim-msft , could you please help with this ?

Duplicate with #11779
@themorey As a workaround, you may manually run az login or use a local installed Azure CLI to get unblocked.

Issue closed, if anything else, feel free to reopen.

Thank you
On Mon, Feb 17, 2020, 10:12 AM Bin Ma<EMAIL_ADDRESS>wrote:

Issue closed, if anything else, feel free to reopen.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-cli/issues/12107?email_source=notifications&email_token=AF2OLB7QGMJVWWE3AHXCLPLRDKSOTA5CNFSM4KSCJJA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL6YDOQ#issuecomment-587039162,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF2OLB4ZWEG226LJWUA7D23RDKSOTANCNFSM4KSCJJAQ
.


ID4 tracker unavailable

Since a few days my ID4 tracker is unavailable
I install the latest version of the app with Hacs.
Version:
Core
2024.4.3
Supervisor
2024.04.0
Operating System
12.2
Frontend
20240404.2

I found this in de debuglogging:
2024-04-15 19:56:28.981 WARNING (ImportExecutor_0) [homeassistant.components.device_tracker] SOURCE_TYPE_GPS was used from volkswagen_we_connect_id, this is a deprecated constant which will be removed in HA Core 2025.1. Use SourceType.GPS instead, please report it to the author of the 'volkswagen_we_connect_id' custom integration 2024-04-15 19:56:28.994 WARNING (ImportExecutor_0) [homeassistant.components.device_tracker] SOURCE_TYPE_GPS was used from volkswagen_we_connect_id, this is a deprecated constant which will be removed in HA Core 2025.1. Use SourceType.GPS instead, please report it to the author of the 'volkswagen_we_connect_id' custom integration

Uploading home-assistant_volkswagen_we_connect_id_2024-04-16T07-00-16.412Z.log…

Can someone help with this issue?

I found this in de debuglogging:
2024-04-15 19:56:28.981 WARNING (ImportExecutor_0) [homeassistant.components.device_tracker] SOURCE_TYPE_GPS was used from volkswagen_we_connect_id, this is a deprecated constant which will be removed in HA Core 2025.1. Use SourceType.GPS instead, please report it to the author of the 'volkswagen_we_connect_id' custom integration 2024-04-15 19:56:28.994 WARNING (ImportExecutor_0) [homeassistant.components.device_tracker] SOURCE_TYPE_GPS was used from volkswagen_we_connect_id, this is a deprecated constant which will be removed in HA Core 2025.1. Use SourceType.GPS instead, please report it to the author of the 'volkswagen_we_connect_id' custom integration

This is a separate issue as it is only a deprecation warning. Should probably be raised separately.
I'm afraid I can't help with either but can confirm the location problem.

I had the some warning some time ago, but it is not directly related to "volkswagen_we_connect_id", but to a required library weconnect (version 0.60.2 as seen from manifest.json). In my installation I do not have the warning anymore. I am a rather newbie, and I have not found out how I can verify the version of weconnect on my installation (or even how i could force an update of weconnect.


[master] PHPStan integration - levels 0 + 1

Based on #6440, rebased & moved from composer.json to .travis.yml (to be installed only during CI builds). Fixed lib/ for levels 0 & 1.
I don't like the changes for level 1 though. Some of the changes shouldn't be even needed - PHPStan limitation reported in https://github.com/phpstan/phpstan/issues/349.

Wow, removal of the return from PersistentCollection#offsetSet() breaks 26 tests... Well, that is..., unexpected... at least. :)

@Ocramius Ok, I'll see what could be done there, it won't work out-of-box though...
$ vendor/bin/phpstan analyse -l 1 -c phpstan.neon tests/
  19/835 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]   2%PHP Fatal error:  Class 'Doctrine\Common\Cli\Tasks\AbstractTask' not found in /www/doctrine/doctrine2/tests/Doctrine/Tests/Mocks/TaskMock.php on line 12

Damn, the tests are in a really bad shape, it'll be massive donkey work to improve them and bring at bring at level 1 (or 0 at least). It's over 150 issues even for level 0, over 300 for level 1.
Fixed some of them, but manywill require more than just simply fixing a type (i.e. dependencies between test files, undefined ::class references etc.). 😞

@Majkl578 then let's skip it for now.

@Ocramius Can we merge this then? Or anything else?

@Majkl578 🚢  thanks!


[Language Text] Update entity recognition NER tests

Packages impacted by this PR
ai-cognitive-language
Issues associated with this PR
#23521
Describe the problem that is addressed by this PR
Update the NER tests so that there is a comprehensive coverage for different recognized entities
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


Contribution to " Inefficient Regular Expression Complexity in chalk/ansi-regex"

Updates

Affected products
Severity

this is actually wrong, going to resubmit


Switch from ete3 to ete4

PR Checklist

[X] Referenced issue is linked
[X] If you've fixed a bug or added code that should be tested, add tests!
[ ] Documentation in docs is updated

Description of changes
This PR is the response to the issue https://github.com/etetoolkit/ete/issues/739, which aim to upgrade the usage of etetoolkit
in pertpy from ete3 to ete4.
perpty implement ete for the following tasks:
a) browsing trees, such as getting leaves, descendants, ancestors, etc.
b) annotation of trees, such as adding information to nodes.
c) drawing tree, including drawing tree with layouts of nodes' information.
This repo upgrade the syntax in regards to the first two tasks. The third task which include the drawing part will mostly maintain the usage of ete3 version expect for calling the module in new places
Technical details
This PR mostly just correct the syntax of calling the methods or features from ete3 to ete4, straight forward and trivial.
detailed differences can be found from

migration noteos: https://github.com/etetoolkit/ete/wiki/3to4
ete4 official tutorial https://etetoolkit.github.io/ete/tutorial/tutorial_trees.html#browsing-trees-traversing

I used two ways to conduct the test

Passed the unitest this folder /home/deng/Projects/metatree_drawer/test_pertpy/pertpy/tests/tools/_coda

Be able to recreate tree images from the step-by-step tutorial of tasccoda tree-aggregated analysis from https://pertpy.readthedocs.io/en/latest/tutorials/notebooks/tasccoda.html

Additional context
ete4 installation, ete4 currently is released on githup repo as beta version therefore not yet available in pip nor conda. Users can install ete4 via githup
pip install https://github.com/etetoolkit/ete/archive/ete4.zip
In regards to c) drawing tree, ete4 still contains the treeview inherited from ete3 which relies on novel PyQt6 module to render tree image. Users can install the depencies by
pip install PyQt6
or install ete4 via
pip install -e .[treeview]
for a local editable installation.
Important information:
In ete4 we will stop maintaining nor making new updates in the old treeview module which is used in pertpy, at this moment it is still functional.
Instead ete4 embrace the new smartview module which has abilities to visualize large tree dataset up to thousands of tips interactively and introduce with novel layouts. The new drawing engine has been implemented in some tools such as
PhyloCloud https://phylocloud.cgmlab.org/ (https://doi.org/10.1093/nar/gkac324)
TreeProfiler https://doi.org/10.1101/2<IP_ADDRESS>8621
If pertpy has the demands to visualize trees with ete4 smartview, I'm more than welcome to provide a novel PR in regards to this feature.

Thank you very much!

ete4 installation, ete4 currently is released on githup repo as beta version therefore not yet available in pip nor conda. Users can install ete4 via github
pip install https://github.com/etetoolkit/ete/archive/ete4.zip

This is why I was asking for a release of ete4 on pypi. Currently, I cannot merge/accept this PR because I could not distribute pertpy on pypi. Github dependencies are not supported on pypi for obvious reasons.
What is the status of a pypi release of ete4?
Thank you again!

Important information:
In ete4 we will stop maintaining nor making new updates in the old treeview module which is used in pertpy, at this moment it is still functional.
Instead ete4 embrace the new smartview module which has abilities to visualize large tree dataset up to thousands of tips interactively and introduce with novel layouts. The new drawing engine has been implemented in some tools such as
PhyloCloud https://phylocloud.cgmlab.org/ (https://doi.org/10.1093/nar/gkac324)
TreeProfiler https://doi.org/10.1101/2<IP_ADDRESS>8621
If pertpy has the demands to visualize trees with ete4 smartview, I'm more than welcome to provide a novel PR in regards to this feature.

@johannesostner could you please comment on this?

Hi @dengzq1234,
thanks for helping us with porting our code from ete3 to ete4!
Regarding the drawing engine, most of our tree structures are quite small (up to 100 tips), so the performance boost from smartview is not that important for us.
Nevertheless, I think that replacing treeview with smartview would be preferable to ensure future compatibility.
Some questions:

How well does smartview integrate with jupyter notebooks? I think most of our users would like to see the plots rendered directly below their code cells
Do you know a better way to create the last plot from  https://pertpy.readthedocs.io/en/latest/tutorials/notebooks/tasccoda.html (tree with a barplot for every leaf?) Currently, the implmentation for this is quite hacky (save the tree as png and import it into a matplotlib plot).

Thank you very much!

ete4 installation, ete4 currently is released on githup repo as beta version therefore not yet available in pip nor conda. Users can install ete4 via github
pip install https://github.com/etetoolkit/ete/archive/ete4.zip

This is why I was asking for a release of ete4 on pypi. Currently, I cannot merge/accept this PR because I could not distribute pertpy on pypi. Github dependencies are not supported on pypi for obvious reasons.
What is the status of a pypi release of ete4?
Thank you again!

I see the issue, the current ete4 is undergoing development on one of the major features which is not showing on the github yet therefore we haven't put it on pypi. I will need to coordinate to see if we want to release the beta version on pypi or wait until it is fully ready. I will keep you updated!

Hi @dengzq1234, thanks for helping us with porting our code from ete3 to ete4! Regarding the drawing engine, most of our tree structures are quite small (up to 100 tips), so the performance boost from smartview is not that important for us. Nevertheless, I think that replacing treeview with smartview would be preferable to ensure future compatibility.
Some questions:

How well does smartview integrate with jupyter notebooks? I think most of our users would like to see the plots rendered directly below their code cells
Do you know a better way to create the last plot from  https://pertpy.readthedocs.io/en/latest/tutorials/notebooks/tasccoda.html (tree with a barplot for every leaf?) Currently, the implmentation for this is quite hacky (save the tree as png and import it into a matplotlib plot).

Hi! If the tree is relatively small then I think treeview at this moment will handle just fine and tree will be shown clearly.
To your questions:

Here is how it goes in Jupyter notebook, it provide a interactive interface so users can manipulate the tree.

I have seen the barplot drawing in the function, and yes and no for current ete4.
Yes we can draw the barplot for every leaf, such as

And no because your barplot is bidirectional barplot with negative, that's something we are currently working on it.
One of the downside of current ete4 is instead of drawing a tree as static image, we open the tree as a browsing and interactive session, users need to active this browsing session in order to output the static png/pdf for tree. For users who need to automate the tree drawing pipeline, it might be a hinder. But as you said if your users would like to see the tree in the jupyter cells, then I would say ete4 smartview fit this purpose.

@dengzq1234 kindly pinging you after 3 months:

I see the issue, the current ete4 is undergoing development on one of the major features which is not showing on the github yet therefore we haven't put it on pypi. I will need to coordinate to see if we want to release the beta version on pypi or wait until it is fully ready. I will keep you updated!

Do you have an update on this?

@dengzq1234 sorry to ping you again, but is there a status update? I don't want to be annoying but I'd be happy to adopt ete4

Hi @Zethson, i am very sorry for the late reply. I did see the message but I don't have answer in regards to the status update. Now it's more of a decision making about if we release ete4 to pip in current state or wait until a major feature. I'm not able to give you the answer because I am also waiting for the answer. :(


Refine mirror settings

Only set plugin portal mirror on CI
Use mirror for EC2 agents and macOS agents

@blindpirate keep in mind that all changes you did/plan to do should also be done on the release branch, as repo.gradle.org will be updated once we migrated and then all branches need to be adapted to the new Artifactory instance.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Low severity vulnerability found on<EMAIL_ADDRESS>

snyk test npm-check
Testing npm-check...
✗ Low severity vulnerability found on<EMAIL_ADDRESS>
desc: Prototype Pollution
info: https://snyk.io/vuln/npm:merge-options:20180415
from<EMAIL_ADDRESS>><EMAIL_ADDRESS>Upgrade direct dependency<EMAIL_ADDRESS>to<EMAIL_ADDRESS>

Fixed in v5.7.1


Suppress missing require from externs

This is to fix the case where you have React defined globally in externs:
// Externs:

var React = {};

/**
 * @constructor
 * @param {Object} props
 */
React.Component = function(props) {};

// Main code:

class X extends React.Component {
}

Without this PR you get the following warning, which is incorrect since externs don't need to be required as they are global:
'React.Component' used but not goog.require'd

If this is accepted, PR https://github.com/google/closure-compiler/pull/1147 for suppressing missing requires on class nodes can be deleted.

I thought the existing var.isExtern() check on line 406 was supposed to make this work. We should figure out why it's not.

Looks live visitNewNode doesn't call maybeAddUsage

I'm afraid I broke this PR when I rebased and resolved conflicts with a formatting change. I've committed a fix.

Closing, reworked here:
https://github.com/google/closure-compiler/pull/1366


feat: replace IsCreated with Exists for Client interface from package docker

Thanks for your contribution! :tada: :+1:

This PR fixes #478


Org Required workflow create and update api's should return the workflow object

The api for required workflow, for both create and update , returns the created workflow object in the response.
Currently the code for these do not return the create object back in an object instead only return the JSON version of these objects.
It would be good to return a typed object as this would enable us to get the details of the created workflow such as name, id etc.

Is #2755 related?

Hi @gmlewis ,
This is for  CreateRequiredWorkflow and UpdateRequiredWorkflow methods in the actions_required_workflows file.
I dont think this is related to 2755.

Hi @gmlewis ,
I have raised PR#2759 for this.
Pls take a look.
Thanks.


[ttnn ops Docs some example ops generate errors]

Describe the bug
some of the ops examples included in TTNN documentation https://tenstorrent-metal.github.io/tt-metal/latest/ttnn/operations.html generate errors both building from main and building via v-38 release. it seems like docs are not synced with latest code changes,
To Reproduce
Steps to reproduce the behavior:

build from main
git checkout dvartanians/ttnn_ops
launch a jupyter notebook and open ttnn/tutorials/ttnn_ops.ipynb
test cells and you will see errors when running mtx @ vec & vec @ vec muls.
building from v38, there is error with deallocator op in addition to mtx @ vec mul ops.

Expected behavior
no errors should be generated and documentation should match the release or have notes regarding compatibility with what release ...
Screenshots
If applicable, add screenshots to help explain your problem.
Please complete the following environment information:

OS: [e.g. Ubuntu 20.04]
branch: dvartanians/ttnn_ops: commit 3e1ac423c27eb9b1c831eef20aa259305310c8e8

Additional context
Add any other context about the problem here.

@arakhmati @eyonland could you give us some insight here?

@tt-rkim we are going to resolve these issues as soon as we finish writing whisper and t5 using ttnn


Update the Usage section

Currently, we don't know how to use the template base on the current Usage content.
## Usage

Clone the repository

`git clone git@github.com:nimblehq/elixir-templates.git`

It's better if we could improve it to make it clear like what should we do after cloning the repo, do we need to run any script after that, ...
Thank you 🚀

Added in Version 2.0


detect if inside iframe and handle it appropriately

By doing window.self !== window.top we can detect if we're inside an iframe. Just like we're doing for electron we could act accordingly and make the router behave out of the box. Ref https://github.com/yoshuawuyts/choo/issues/344

And then we can get the src tag from inside the iframe using document.referrer :sparkles: - it allows us to strip that part from each url and then booom, we're good (:


Added my personal information to the file.

Added information about Stephanie Fulcar to the file.

Thanks for contributing! Because of previous contributions, this file has a merge conflict. I'll fix it myself for now and in a future meeting I'll explain what that is and show how you'd fix it yourself.


[BugFix] Fix could not choose mv plan when mv has statistics

Fixes #issue
when we create a materialized view for hive table, if mv plan has multi join, it need to compare cost between mv plan and origin plan,  if mv collect statistics but there is no column statisrics for hive table, it would not choose mv plan because it's cost are heigher.
In order to fix this problem, we adjusted the cost of mv when there are  no exact statistis in the origin plan

[FE PR Coverage Check]
:disappointed: fail : 12 / 31 (38.71%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/Group.java
0
1
00.00%
[248]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
0
5
00.00%
[1580, 1581, 1582, 1583, 1584]

:large_blue_circle:
com/starrocks/sql/optimizer/cost/CostModel.java
11
23
47.83%
[134, 135, 137, 138, 139, 141, 142, 143, 144, 145, 147, 148]

:large_blue_circle:
com/starrocks/sql/optimizer/ExpressionContext.java
1
2
50.00%
[143]

[FE PR Coverage Check]
:disappointed: fail : 12 / 30 (40.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/Group.java
0
1
00.00%
[248]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
0
4
00.00%
[1579, 1580, 1581, 1584]

:large_blue_circle:
com/starrocks/sql/optimizer/cost/CostModel.java
11
23
47.83%
[134, 135, 137, 138, 139, 141, 142, 143, 144, 145, 147, 148]

:large_blue_circle:
com/starrocks/sql/optimizer/ExpressionContext.java
1
2
50.00%
[143]

[FE PR Coverage Check]
:disappointed: fail : 12 / 31 (38.71%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/Group.java
0
1
00.00%
[248]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
0
4
00.00%
[1579, 1580, 1581, 1584]

:large_blue_circle:
com/starrocks/sql/optimizer/cost/CostModel.java
11
24
45.83%
[134, 135, 137, 138, 139, 141, 142, 143, 144, 145, 146, 150, 151]

:large_blue_circle:
com/starrocks/sql/optimizer/ExpressionContext.java
1
2
50.00%
[143]

[FE PR Coverage Check]
:disappointed: fail : 11 / 29 (37.93%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/Group.java
0
1
00.00%
[248]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
0
3
00.00%
[1578, 1581, 1584]

:large_blue_circle:
com/starrocks/sql/optimizer/cost/CostModel.java
10
23
43.48%
[133, 134, 135, 137, 138, 139, 141, 142, 143, 144, 147, 148, 163]

:large_blue_circle:
com/starrocks/sql/optimizer/ExpressionContext.java
1
2
50.00%
[143]

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


Roadchoice Search: Phase 2 Enhancements

This ticket contains an archive of tickets created for Roadchoice search prior to the new RC Search project. They are held here for documentation and accessibility should they be required as enhancements in phase 2.
https://github.com/hlxsites/vg-roadchoice-com/issues/239
https://github.com/hlxsites/vg-roadchoice-com/issues/252
https://github.com/hlxsites/vg-roadchoice-com/issues/246

Pending SOW from Netcentric.


Replace dartsass-rails with  cssbundling-sass

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
790

Relevant Lines:
790

💛  - Coveralls


logger with context ?

Which version of Elastic are you using?
[ x ] elastic.v7 (for Elasticsearch 7.x)
[ ] elastic.v6 (for Elasticsearch 6.x)
[ ] elastic.v5 (for Elasticsearch 5.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[ ] elastic.v2 (for Elasticsearch 1.x)
Please describe the expected behavior
Can Logger support Context ? Because it's usefully for tracing，add requestId etc for a request.
Please describe the actual behavior
Any steps to reproduce the behavior?

@olivere that does not meet the problem. (we have implement own logger with zap)
In our system, there is a "requestId" for per-request for logging, so we can combine multiple log for the same request.
if there is an error, errorlog will trace the error message, but we can not add custom fields to the log message (which get from Context).

@olivere
hello, this change is not going to upload?

Very probably not. This repository is effectively deprecated and dormant. Please switch to the official client.


LUCENE-9983: Stop sorting determinize powersets unnecessarily

Description
In determinize function (which truns NFA to DFA), we use SortedIntSet to store powerset and it uses a sorted data structure which could be very costly in some cases. And we actually don't need the sorting functionality.
Solution
Replace usage of SortedIntSet by StateSet, a wrapper of IntIntHashMap. Note I haven't removed SortedIntSet but probably we should since it is only used in determinize?
Tests

Reused old tests that used to test SortedIntSet
I also applied the patch attached in LUCENE-9981. Before the commit it runs 6min before throw an exception and after patch it is 1+ sec. (Seems from the error message this has something to do with the order we iterate the key, but I believe it still provides some speedups)

Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Lucene maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[x] I have added tests for my changes.

Close this one temporarily for debugging


AttributeError: 'UserPassCredentials' object has no attribute 'get_token'

import os
from msrestazure.azure_active_directory import UserPassCredentials
from azure.mgmt.resource import ResourceManagementClient

credentials = UserPassCredentials(username=os.getenv('AZURE_USERNAME'), password=os.getenv('AZURE_PASSWORD'))
subscription_id = os.getenv('AZURE_SUBSCRIPTION')
resource_client = ResourceManagementClient(credentials, subscription_id)
resource_list = resource_client.resource_groups.list()

for resource in resource_list:
    print(resource)

For the above code I am running into the error -

AttributeError: 'UserPassCredentials' object has no attribute 'get_token'

I have to use Active directory to authenticate. I have the token embedded inside the credentials. I think I am missing something here. Can you please guide me in the right direction on how can I list all the resource group in my subscriptions using the credentials that I generated or if I need to use a different method.
Update 1 - Fixed a typo

Hi @reach4bawer ,
Are you using the latest azure-mgmt-resource package? It's a new generation of Python SDK, and azure-identity instead of msrestazure should be used for it.
I think you may need this: https://azuresdkdocs.blob.core.windows.net/$web/python/azure-identity/1.4.0/azure.identity.html#azure.identity.UsernamePasswordCredential
And here is a quick start for using azure-identity in new generation of SDK: https://azure.github.io/azure-sdk-for-python/mgmt_quickstart.html

I tried the above examples my code but it did not work. I have read only access to all the subscriptions so this is the code that is working -
import os
from azure.mgmt.subscription import SubscriptionClient
from msrestazure.azure_active_directory import UserPassCredentials

credentials = UserPassCredentials(username=os.getenv('AZURE_USERNAME'), password=os.getenv('AZURE_PASSWORD'))
sub_client = SubscriptionClient(credentials)
subs = [sub.as_dict() for sub in sub_client.subscriptions.list()]

Notice that there is no client id or anything that was needed to be passed. I was able to print all the subscriptions using the above code. From the credentials object I was able to extract the default client_id and exported that in my environment variables. When I try the new method with the following code -
import os
from azure.identity import UsernamePasswordCredential
from azure.mgmt.subscription import SubscriptionClient
credentials = UsernamePasswordCredential(client_id = os.getenv('AZURE_CLIENT_ID'),
                                          username=os.getenv('AZURE_USERNAME'),password=os.getenv('AZURE_PASSWORD'))
sub_client = SubscriptionClient(credentials)
subs = [sub.as_dict() for sub in sub_client.subscriptions.list()]

I get the error -

AttributeError: 'UsernamePasswordCredential' object has no attribute 'signed_session'

I was able to use the UsernamePasswordCredential to get the Resource Groups. See the code below -
import os
from azure.identity import UsernamePasswordCredential
from azure.mgmt.resource import ResourceManagementClient
subscription_id = os.getenv('AZURE_SUBSCRIPTION')
credentials = UsernamePasswordCredential(client_id = os.getenv('AZURE_CLIENT_ID'),
                                          username=os.getenv('AZURE_USERNAME'),password=os.getenv('AZURE_PASSWORD'))
resource_client = ResourceManagementClient(credentials, subscription_id)
resource_list = resource_client.resource_groups.list()
for resource in resource_list:
    print(resource)

Can UsernamePasswordCredential not be used to get all the subscriptions that I have access to? My goal is to iterate over all the subscriptions and resource groups and list all the details for the keyvault in them.

msrestazure and azure-identity credentials have different APIs. The current major version of azure-mgmt-resource, 15, expects azure-identity credentials like azure.identity.UsernamePasswordCredential. Lower major versions expect msrestazure credentials like msrestazure.azure_active_directory.UserPassCredentials. When you use an azure-identity credential with azure-mgmt-resource 10.x, you'll see an AttributeError about signed_session. When you use an msrestazure credential with azure-mgmt-resource 15.x, you'll see an AttributeError about get_token. The fix is to use a credential with the right API for your version of ResourceManagementClient. I recommend azure-mgmt-resource 15.x and azure-identity.
(related: #14499)

The follow is the output for the pip freeze command to show the versions that I am using -
azure-common==1.1.25
azure-core==1.8.2
azure-identity==1.4.1
azure-keyvault-secrets==4.2.0
azure-mgmt-core==1.2.1
azure-mgmt-resource==15.0.0
azure-mgmt-subscription==0.7.0

So I am using the 15.x version. I tried updating all of them but seems like that these are the latest version.

Ah, I see, the issue then is azure-mgmt-subscription's SubscriptionClient, which expects an msrestazure credential. I'm not so familiar with these libraries, but I see there's a azure.mgmt.resource.subscriptions.SubscriptionClient that might be all you need to list subscriptions. If you must use azure-mgmt-subscription and want to use the same credential object with ResourceManagementClient and SubscriptionClient, you could use AzureIdentityCredentialWrapper. It wraps an msrestazure credential with the azure-identity API, allowing you to use msrestazure.azure_active_directory.UserPassCredentials with ResourceManagementClient.
@changlong-liu what's the story with azure-mgmt-subscription? Will it have a track 2 version?

Hi @chlowell ,
The azure-mgmt-subscription has not been released as Track2.
It's in the plan. May have preview version in 1 or 2 month.

Thanks everyone for clarifying my doubts. Will close the issue.

Not through azure-identity. The client ID is the ID of the Azure Active Directory application to which the user authenticates. You could in principle use a different library to get a list of applications registered in your tenant then somehow present that to a user for selection, but I doubt that would be helpful. Do you not already know the correct ID as an owner of the application?

Users typically don't need to know the client ID. The developer writing the program knows the Azure AD application registered to represent it and therefore also its client ID. Have you registered an Azure AD application for this?


[OSD-9910] Add account validation controller to AAO

Adds a new controller to validate accounts to the operator.
Currently the validation logic only includes verifying that an unclaimed, non-ccs account is under the expected root organisation.
If this is not the case the account will be moved.

/lgtm

/lgtm

/approve


[CI/Build] Update Dockerfile.cpu

Use COPY in favor of mount for requirements-x.txt files.
The Dockerfile is using this principle
https://github.com/vllm-project/vllm/blob/fc990f97958636ce25e4471acfd5651b096b0311/Dockerfile#L39-L42
but the Dockerfile.cpu is mounting them
https://github.com/vllm-project/vllm/blob/fc990f97958636ce25e4471acfd5651b096b0311/Dockerfile.cpu#L50-L53
FIX #8502 (link existing issues this PR will resolve)

The requirements files are already copied in the image later, we have no real benefit in changing this back to COPY.

Fix for podman build: https://github.com/vllm-project/vllm/pull/8540

Closing as fixed by https://github.com/vllm-project/vllm/pull/8540


wasm-builder-runner does ignore Cargo.toml patch section

We have written a custom sr-io module. Before the introduction of the wasm-builder-runner, the patch section of the runtime/wasm/Cargo.toml was used to replace the original sr-io module.
We no see no option to accomplish that feat, adding this feature would be great.

Why do you replace the sr-io module?

And where do you apply the patch?

We want to use the std library for some computations. Back then I was given the advice that if I want to do that, the only way is to extend the sr-io module with a custom host_call.
I tried both:

applying the patch in the runtime/Cargo.toml
adding the runtime as a workspace to the project and apply the patch from the root toml.

Should this feature already be included and I didn't see it?

Here's our patch section. still doesn't work:
https://github.com/scs/substraTEE-node/blob/435a2af1e4213998ab6da71bc588bae12ab6f548/Cargo.toml#L109


replace script to entry

update mpm version
update unit test

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Making sure to change all "script" functions to "entry" functions could also provide backward compatibility for old contracts.

@sanlee42 @welbon @jackzhhuang comment mpm package prove temp


NullPointerException

First of all, thanks for the great plugin.
In the play store dashboard, the following crash reports keep showing up. Is this a bug in the implementation or in the plugin?
java.lang.NullPointerException:
at com.bitpay.cordova.qrscanner.QRScanner$19.run(QRScanner.java:546)
at android.app.Activity.runOnUiThread(Activity.java:5562)
at com.bitpay.cordova.qrscanner.QRScanner.prepare(QRScanner.java:543)
at com.bitpay.cordova.qrscanner.QRScanner.access$1500(QRScanner.java:38)
at com.bitpay.cordova.qrscanner.QRScanner$11$1.run(QRScanner.java:192)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:152)
at android.app.ActivityThread.main(ActivityThread.java:5497)
at java.lang.reflect.Method.invoke(Native Method:0)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Yes i'm experiencing this error too. It happens when i tap the scan button on my app. Sometimes it works fine, sometimes the app force closes (several times in a row before returning to work) and these errors appear on my logcat.
I "wrote a workaround", just to prevent the force close: a simple control on that mBarcodeView object to verify if it's null. If it actually is, i signal it in the logcat and then return. Here's the code i added in
<path-to-my-cordova-app>\platforms\android\src\com\bitpay\cordova\qrscanner\QRScanner.java
First of all include Log class, used to write to logcat:
import android.util.Log;
Then add the if(mBarcodeView == null) {...} at around line 544, just before mBarcodeView.pause();
Here's some context:
other code...
else {
    prepared = false;
    this.cordova.getActivity().runOnUiThread(new Runnable() {
        @Override
        public void run() {
            /**********************************************/
            if(mBarcodeView == null) {                                 //  <= I added this if
                Log.e("MyFirenze", "Error: mBarcodeView is null. Returning");
                return;
            }
            /************************************************/
            mBarcodeView.pause();          // <= The error happens here, since mBarcodeView might be null
        }
    });
more code...

Hope this helps someone and also hope that the dev will address this issue.

Thanks for the report! This may be solved in 2.6.0. If you're still having trouble, please open a new issue or send a PR 🚀