Disable belongs_to filter

Hi, we have a belongs_to on a model that points to a table of 20k items. This makes exadmin pages w/ this filter take a long time to load. Is there a way to either replace it w/ an async typeahead or disable it entirely?
Same for the create/edit page. I can disable it there I believe, but if it's necessary for creation it'd be nice to have an option that didn't load 20k items. Thanks!

@aaronjensen Just pushed an update to the filter API. If @smpallen99 accepts it, you'll need to explicitly specify all the filters you want visible on the page. (Sounds like this problem will fix itself.)

Great, thanks!

I'm on vacation for a couple days. will look at the PR when I get back home.


[CI] Concurrency on gha

Cancels workflow jobs for PRs when those of the previous commit aren't finished yet

@osalpekar thoughts on this?

@vmoens This is a great idea. For reference, here's the concurrency group formatting we use for all the other GHA jobs in the pytorch organization: https://github.com/pytorch/test-infra/blob/main/.github/workflows/build_wheels_linux.yml#L216 (but they have a slightly different naming convention).


Components inside overlay.open do not react properly to external state

Issue Description:
This problem occurred in overlay-kit 1.3.0 version.
I ran into the following problem while working with "overlay-kit".
Components inside the "overlay.open" do not react properly when the state exists externally
Expected
export default function Page() {
  const [notWorkingText, setNotWorkingText] = useState("world");
  return (

      <button
        onClick={() => {
          overlay.open(({ isOpen }) => {
            return isOpen ? (

{notWorkingText}

                <button
                  onClick={() => {
                    setNotWorkingText("hello");
                  }}
                >
                  text change
                </button>

            ) : null;
          });
        }}
      >
        not work example button
      </button>

)

When I click the "Change Text" button, I think the text that appears on the screen should change from world to hello.
But this example doesn't actually work
Please let me know if I'm doing something wrong
Case that works
      <button
        onClick={() => {
          overlay.open(({ isOpen, close }) => {
            // eslint-disable-next-line react-hooks/rules-of-hooks
            const [workingText, setWorkingText] = useState("world");
            return (

{workingText}

                <button
                  onClick={() => {
                    setWorkingText("hello");
                  }}
                >
                  text change
                </button>

            );
          });
        }}
      >
        work example
      </button>

This example works perfectly. I think it probably responds appropriately to state changes because it holds the state inside the component.
Is this a bug?
If this isn't a bug, I'm curious how this use case can be handled.
Additional Context
I've posted a code snippet that reproduces this issue
Thank you for your efforts

You’re correct in identifying the issue. This limitation is due to the nature of the library, and it’s not something that can be fixed easily. This problem has existed since the use-overlay in slash.
When the overlay opens, it captures a snapshot of its internal state, making it incompatible with dynamic children. Here are a few ways to work with dynamic content that come to mind:

Move the state inside the component, as you have shown in your example.
Manage the state directly without using overlay-kit.

This issue is also present in mantine’s modal manager, which offers a similar API.
Link: https://mantine.dev/x/modals/#dynamic-content-and-the-modals-manager
Thank you for your efforts.

Thank you for your kindness.
I've often encountered this problem in the past when writing code with patterns similar to overlay-kit.
Thanks to your explanation, I understand the problem better.
thank you!

It seems your questions have been resolved, so I will close this issue for now.
If you have any further questions related to this, please feel free to reopen the issue!


Maximum call stack size exceeded when validate is overrided

Environment

Ember Version: 2.8
Ember CLI Version: 2.8
Ember CP Validations Version: 3.0.1

Steps to Reproduce
Override the validate method of a function and to Tiny.__container__.lookup('service:store').createRecord('subscription').validate().
With this model :
import DS from 'ember-data';
import {buildValidations} from 'ember-cp-validations';

const Validations = buildValidations({});

export default DS.Model.extend(Validations, {
  validate() {
    return this._super(...arguments);
  }
});

And I do Tiny.__container__.lookup('service:store').createRecord('subscription').validate() I have this error :
ember.debug.js:23399 Uncaught RangeError: Maximum call stack size exceeded(…)
get @   ember.debug.js:23399
validate    @   factory.js:130
(anonymous function)    @   factory.js:115
ComputedPropertyPrototype.get   @   ember.debug.js:18547
get @   ember.debug.js:23419
get @   ember.debug.js:36413
(anonymous function)    @   factory.js:123
ComputedPropertyPrototype.get   @   ember.debug.js:18547
get @   ember.debug.js:23419
validate    @   factory.js:130

I call this line, then, it do a tons of thing and call  this and it's back again.
Then solution is obviously to not override the validate method but the bug is strange enough to be notified.

@GCorbel I'm closing the issue because it's quite old. Feel free to reopen if you need more help.


[stable/telegraf] Allow ENV vars

What this PR does / why we need it:
Allow ENV vars. Some telegraf plugins need ENV vars to work (like azure_monitor - https://github.com/influxdata/telegraf/tree/master/plugins/outputs/azure_monitor#authentication)
Which issue this PR fixes

fixes #15264

Checklist

[X] DCO signed
[X] Title of the PR starts with chart name (e.g. [stable/chart])

/lgtm
/ok-to-test


dummy

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

https://pantheon.corp.google.com/cloud-build/builds/13f3919d-8890-4b89-95e6-dd3425d1b283?project=cloud-dataproc-ci&mods=dataproc_env_image_prod&invt=Abd1mw&inv=1
This build runs all the non GPU dependent tests. All the issues are addressed and the presubmits builds are now green. I will be monitoring the builds and keep an eye on the new PRs going in this repo to foresee any new failures.

/gcbrun


17017 migrate RadioButtonWithLabel to PressableWithFeedback

Details

This PR migrates RadioButtonWithLabel to PressableWithFeedback
Fixed Issues

$ https://github.com/Expensify/App/issues/17017
PROPOSAL: https://github.com/Expensify/App/issues/17017
Tests

For local testing I needed to mock the question

Access the Idiology question section inside Enable Payments Page
Click/Press the radio button either on radio button or it's label
Verify that clicked/Pressed option is properly selected and works as intended

[X] Verify that no errors appear in the JS console

Offline tests

Same as Test steps
QA Steps

Same as Test steps

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/61146594/81b48c23-3c01-4eae-8377-174ecdf3f433

Mobile Web - Chrome
https://github.com/Expensify/App/assets/61146594/838ab82e-eeb5-41fb-9a04-a27f9f23fc14

Mobile Web - Safari
https://github.com/Expensify/App/assets/61146594/627f4e85-2544-44be-9394-8ea205160789

Desktop
https://github.com/Expensify/App/assets/61146594/e48e266f-4fd6-4a5e-a870-ce58f1bd4923

iOS
https://github.com/Expensify/App/assets/61146594/e5e6b058-0f6e-4a2f-b6bd-680035be01c6

Android
https://github.com/Expensify/App/assets/61146594/6b0aa4ac-7d01-4fe3-af52-e5598f5bafee

Will start on this.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@robertKozik Added some questions on the implementation. It would be better to add some more information in the PR details section since the linked issue also doesn't have much information which should be useful for future references.

Hi, I did mock the questions page and tested out the changes
Current behaviour in main:
https://github.com/Expensify/App/assets/46707890/2b36a4da-db64-4c9f-b3be-fb9fb4dbdd45
Behaviour with the new code change:
https://github.com/Expensify/App/assets/46707890/215c840f-9681-454c-bf7f-d288ab50fb78

I have few concerns

With the new implementation the label is dimmed on hover itself and shows the text in grey, which seems odd. This opacity change behaviour would be good for button but seems odd just for label. Are we expecting this?

If we are expecting number one, the checkbox icon doesn't have the same behaviour(Assuming its due to the fact it still uses plain old Pressable). Do we have future plans to unify the behaviour for radio icon as well?

And more odder when you combine long press with it along with hover effect.

https://github.com/Expensify/App/assets/46707890/a22248bb-3751-4fcc-8df4-8827671ae1ec

Might be out of scope of this PR, but just calling out since I had noticied. The radio with the check box is selectable/unselectable even at the horizontal end of the page where the text is not even nearby. It could be due to the Pressable view extending till the end. I noticied this behaviour in main as well.

@robertKozik @dangrous  I understand this PR is only concerned about the migration but would be good to understand the thoughts on the above issues. Are we fine with the behaviour?/ Do we need to fix it part of this PR or Do as a followup action.

Both behaviour are easy to change, or remove. It comes from the implementation of PressableWithFeedback as it have out-of-the-box solution for dimming on both hover and presses.
That's why your third point occurred, different dimming is applied on the presses.
I agree with you that no visible changes should be introduced with the migration so I'll remove the hover dimming, press dimming is present on production so I'll left it.
Your last concern comes from the styling used on the view, as it styling the view with styles.w100 to span to the end.

@robertKozik  Great. Then lets go with not changing/regressing any behaviour now. Have migration changes in the same way.
Others concerns i posted which is also present in the main can be took as a follow-up( concern number 4)

@abdulrahuman5196 I've disabled the hover dimming and removed doubling styles (this was unintentional). However I'll be able to test it once more in about an hour or so.

@robertKozik  Sure. Kindly update once you have done testing. I will continue testing tomorrow morning from my end.

Alright, I've filled out details PR section and change the video from web to indicate no hover effect

@robertKozik  I other difference I see is in the long press case. In main the option gets selected only when we release the press, but in the new code its gets selected after a while without release but the press dim is only gone after press release.
New implementation
https://github.com/Expensify/App/assets/46707890/7e873404-180e-468e-8015-27cbc1858091
Current implementation
https://github.com/Expensify/App/assets/46707890/45a4743e-13e1-4788-95ec-0e29b25eff2f

I needed to rebase with main, but now options are selected when user releases the button. Also I have implemented the custom prop test in order to remove the AccessibilityLabel is required error when element is not accessible. I hope that new it works as it should be  🎸

@robertKozik I tried in desktop and all seems to work fine. Can you take care of the above request alone - https://github.com/Expensify/App/pull/18847#discussion_r1196306744? So that I can start testing in other platforms and complete the reviewer's checklist?

@robertKozik  And kindly fix the lint failure as well

Just to note. This PR fixes could fix the lint failure - https://github.com/Expensify/App/pull/19109/files
We can do merge from main.

Thanks for the updates. I will test it out in other platforms and work on reviewers checklist. I think there shouldn't be any more issues.
Kindly resolve the comments once you took action since it would avoid noise in the GH.

@abdulrahuman5196 thanks, merge helped. I also fixed the custom test for accessibilityLabel. As I stated here with this PR we would create new console error, which is related to this PR.

@dangrous Could you kindly check and provide your thoughts for this? https://github.com/Expensify/App/pull/18847#discussion_r1196798890

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Note: I see some console errors and issues with ideology page but none of those are in issue here. I will file bugs in slack for those.

Update - I think it makes the most sense to ignore the design changes I want to make and handle that separately. I'll make another issue for that. Just handle the requested changes, and we should be good to go!
And reading back in the comments I see you both talked about some of these issues I had as well (such as press dimming), so I'm glad we're pretty much on the same page. I think we can clean up the design of this significantly

Sure, generally the migration to PressableWithFeedback/PressableWithoutFeedback will be great platform to implement such a standardisation of the press/hover behaviours.
Let me know if we want to update therequirePropsCheck function even when it will need to supress eslint rule for this line.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
-[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack

[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/46707890/232e94b0-f6b3-4381-9d25-c22abbb53ad9

Mobile Web - Chrome

https://github.com/Expensify/App/assets/46707890/d70d19dd-1f31-4a2e-80aa-77849538117e

Mobile Web - Safari

https://github.com/Expensify/App/assets/46707890/79b1a632-353c-4180-98e1-ce1ca2615449

Desktop

https://github.com/Expensify/App/assets/46707890/4122598d-5cde-4ace-b4e0-1f6d3c80ce78

iOS

https://github.com/Expensify/App/assets/46707890/c41cfe42-75b6-49d8-92e2-eb38e182eacf

Android

Yep, tested on the real flow and looks good!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.17-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@robertKozik @dangrous Is there an easy way to navigate to this page in Staging?

@mvtglobally can y'all do the Wallet Activation flow? If not, let me know and I can test quickly

@dangrous isnt it behind the KYC wall? I don't think we were able to do it in the past, but if you can share a way it would be great

I mean it sort of IS the KYC wall? I think you're right though, I can check this out shortly

Man, took me forever to get there but looks good!

@dangrous are we ok to check it off?

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.17-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Can we have a cli option/command to rebuild/build rags?

          Can we have a cli option/command to rebuild/build rags?

Originally posted by @Squirreljetpack in https://github.com/sigoden/aichat/issues/664#issuecomment-2327746406

Sorry, currently no plans.


Fix deprecation warning about keyword arguments in ruby 2.7

Running specs under Ruby 2.7 produces lots and lots of deprecation warnings:

Warning: Using the last argument as keyword parameters is deprecated;
maybe ** should be added to the call.

This is because we expect the command function to include keyword arguments, but automatic de-structuring of a hash to keyword arguments is targeted to be removed in a future version.
The fix is to explicitly de-structure the hash to keyword args with the double splat operator.
(See https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/)
Changing the caller to use a double splat operator fixes this warning, but introduces a new one under ruby 2.6:

warning: in `call': the last argument was passed as a single Hash
although a splat keyword arguments here.

To fix this, we need to ensure that the call definitions in the specs explicitly accept additional keyword arguments.
Not sure if it's possible to write a test for a deprecation warning, but the cli/command test suite passes successfully and without warnings now under both 2.6 and 2.7

Might have spoken too soon; the CI output for 2.6 shows:

warning: in `call': the last argument was passed as a single Hash
/home/runner/work/dry-cli/dry-cli/lib/dry/cli.rb:65: warning: although a splat keyword arguments here

As far as remember, there were no way to remove both cops. Either 2.7 will complaij, or 2.6


VeeamBRStats.ps1 - Connection Error

Hello, iam stuck in the connection.  Changed localhost to our server:
param(     [Parameter(Position=0, Mandatory=$false)]         [string] $BRHost = "BKUP01",
With PSx64.exe i get the wanted XML output. But the Sensor Logs comes up with:
Failed to connect to Veeam BR Host
even when it is hardcoded in the powershell script. So i checked the user, its running with a credential which is approved to connect. Means i logged in on the same remote host the PRTG probe is installed and run the script with PSx64 which gives me the XML output.
Error Output:
`C:\Program Files (x86)\PRTG Network Monitor\custom
sensors\EXEXML\VeeamBRStats.ps1 : Failed to connect to Veeam BR Host
At line:1 char:1

&'C:\Program Files (x86)\PRTG Network Monitor\custom sensors\EXEXML\V ...

  + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorExcep
 tion
  + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorExceptio
 n,VeeamBRStats.ps1

1
Failed to connect to Veeam BR Host

`
`
OS: WS 2016
PSx64: <IP_ADDRESS>
0:
Name                           Value

PSVersion                      5.1.14393.3053
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.3053
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>`
Also i tried with Parameters in PRTG as:
-f="FileName.ps1 -p="BKUP01" and -f="FileName.ps1" -p="-BRHost BKUP01"
Any ideas here?
Originally posted by @eulisan in https://github.com/mycloudrevolution/Advanced-PRTG-Sensors/issues/42#issuecomment-561172604

Hi @eulisan ,
I have split this request into a dedicated issue.
Have you tried to Connect via VBR Console from the server where the PowerShell script is executed?

First of all. Thank you for the quick reply. Yes i can use the VBR GUI Console with the remote VBR Server and the same user used by PRTG. In Addition iam also able to connect via Powershell and the Connect-VBRServer cmdlet.

Hi Both,
I am too getting the same error:
C:\Program Files (x86)\PRTG Network Monitor\Custom Sensors\EXE\PRTG-VeeamBRStats.ps1 : Failed to connect to Veeam BR
Host
At line:1 char:1

&'C:\Program Files (x86)\PRTG Network Monitor\Custom Sensors\EXE\PRTG ...

  + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
  + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,PRTG-VeeamBRStats.ps1

C:\Program Files (x86)\PRTG Network Monitor\Custom Sensors\EXE\PRTG-VeeamBRStats.ps1 : at , C:\Program
Files (x86)\PRTG Network Monitor\Custom Sensors\EXE\PRTG-VeeamBRStats.ps1: line 202
at , : line 1
At line:1 char:1

&'C:\Program Files (x86)\PRTG Network Monitor\Custom Sensors\EXE\PRTG ...

  + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
  + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,PRTG-VeeamBRStats.ps1

1
Failed to connect to Veeam BR Host

Any help will be much appreciated.
Thanks

@revilo55 Have you tried to Connect via VBR Console from the server where the PowerShell script is executed?

@eulisan and @revilo55 Have you tried to execute the script without PSx64.exe (same user and server) ?

@revilo55 Have you tried to Connect via VBR Console from the server where the PowerShell script is executed?

Yes, I'm able get a response from veeam.

@revilo55 and the script execution without PSx64?

I ran ./PRTG-VeeamBRStats.ps1 -BRhost "fqdn of host".
Using the original script.
That was run straight from powershell as admin, which gave a result.

Got the same results as revilo. Even when running PSx64 via PS Console without PRTG got the results. Just when the script is executed via PRTG it returns "Failed to connect to Veeam BRHost". Confusing.

When I run the script in Powershell 64 bit it runs fine. When I run the script in powershell x86 with PSx64 it gives an error "Failed to connect to Veeam BR Host". The remote console connects without issues.
Veeam version <IP_ADDRESS>66 (community edition)
Windows 1909

Got the same results as revilo. Even when running PSx64 via PS Console without PRTG got the results. Just when the script is executed via PRTG it returns "Failed to connect to Veeam BRHost". Confusing.

@eulisan Do you pass the Veeam Hostname as a parameter?

When I run the script in Powershell 64 bit it runs fine. When I run the script in powershell x86 with PSx64 it gives an error "Failed to connect to Veeam BR Host". The remote console connects without issues.
Veeam version <IP_ADDRESS>66 (community edition)
Windows 1909

@Legoracers Do you pass the Veeam Hostname as a parameter?

I have added additional Debug Output and Error Details during connection.
Might you please run a few tests with this version of the Script:
https://github.com/mycloudrevolution/Advanced-PRTG-Sensors/blob/ConnectionDetails/Veeam/PRTG-VeeamBRStats.ps1
PS 64Bit: ./PRTG-VeeamBRStats.ps1 -Debug
PS 64Bit: ./PRTG-VeeamBRStats.ps1 -Debug
PS 32Bit: ./PRTG-VeeamBRStats.ps1 -Debug
PS 32Bit: ./PRTG-VeeamBRStats.ps1 -Debug
CMD: PSx64.exe -f="PRTG-VeeamBRStats.ps1"


Sent links are not visible

Not WCAG compatible :D

Looking at Signal and Telegram, they have solved this issue by making sent links the same color as normal text and adding an underline. iMessage doesn’t display links at all, only the rich preview.
Signal and Telegram also have an underline in the received links. Telegram uses an accent color for the text where as Signal doesn’t.

Fixed in 957cc8b


Rename column in migration has no effect

Laravel-mongodb Version: 3.8
PHP Version: 8.1.16
Database Driver & Version: MongoDB 4.4.14, mongodb php driver 1.13.0

Description:
When I try to rename a field of a collection within a migration using $table->renameColumn() the migration runs without errors but the fields in the collection have the same name as before running the migration
Steps to reproduce
Collection users:
{
    _id: 62859365a1767a00c9589712,
    name: "admin",
    role: "member"
}

Migration file:
class RenameUser extends Migration
{
    public function up()
    {
		Schema::table ('users', function (Blueprint $table) {
			$table->renameColumn ('role', 'global_role');
		});
    }
}

> php artisan migrate
Expected behaviour
I expected the same behavior as running the following monogdb command
db.users.updateMany ({},{ $rename: { 'role': 'global_role'}} )
The name of the field role should be global_role after running the migration.
Actual behaviour
Nothing, no error but also no effect.

I'm also getting the same error, No error but renaming has not happened.
@flappix did you get any solution for this?

No, I think the schema builder is not capable of doing this. You could use a raw query instead instead of the schema builder like
public function up()
    {
		 DB::collection('users')->update([
            '$rename'=>['role'=> "global_role"],
        ]);
    }


Include  for std::unique_ptr

LLVM's libc++ is removing transitive inclusions among std header files in newer C++ versions, so user code must explicitly include needed std header files. In this case, cubeb_opensl.cpp must explicitly include  for std::unique_ptr because, starting in C++23,  no longers includes .
https://libcxx.llvm.org/DesignDocs/HeaderRemovalPolicy.html
libcubeb/src/cubeb_opensl.cpp:140:8: error: no template named 'unique_ptr' in namespace 'std'
  140 |   std::unique_ptr<cubeb_stream_params> input_params;
      |   ~~~~~^

I hit this compilation error when trying to compile Firefox with -std=c++23 (bug 1880762).

Thanks Chris!


Another lambda capture issue with PrintFunc

I want to give some background on a small issue in my code. I have wrapped some pocketpy functionality in a class PktpyInterpreter, and in this class I have a method eval_text which should silently try to eval some pocketpy code (i.e. without stderr output if it fails) and then try to exec it and output error to stderr if that fails.
The way I wanted to make this work is to have a private disable_stderr instance variable of the class and have it checked in the _stderr function.
Because  the signature of _stderr is PrintFunc instead of std::function, no captures are allowed in this case and this->disable_stderr var is not accessible inside this->_stderr.
Is there any way around this to reach the same objective: i.e. selectively disable stderr output for one particular case?
PktpyInterpreter::PktpyInterpreter()
{
    this->name = symbol_unique();
    this->pythonpath = gensym("");
    this->source_name = gensym("");
    this->source_path = gensym("");
    this->path_code = 0;
    this->loglevel = log_level::PY_LOG_LEVEL;
    this->disable_stderr = false;
    this->vm = new VM(false); // vm->enable_os = false

    this->vm->_stdout = [](VM* vm, const Str& s) {
        const char* stdout_output = s.c_str_dup();
        post((char*)stdout_output);
    };

    this->vm->_stderr = [&](VM* vm, const Str& s) {
        if (!this->disable_stderr) {
            const char* stderr_output = s.c_str_dup();
            error((char*)stderr_output);
        }
    };
}

// ...

PyObject* PktpyInterpreter::eval_text(char* text)
{
    this->disable_stderr = true;
    PyObject* result = this->vm->exec(text, "<eval>", EVAL_MODE);
    this->disable_stderr = false;

    if (result == NULL) {
        if (this->vm->exec(text, "main.py", EXEC_MODE) != NULL) {
            return this->vm->None;
        }
    } else {
        return result;
    }
    return NULL;
}

I have managed to get this to work by converting PrintFunc from a function pointer to a std::function as follows in line 3435-3436 of pocketpy.h
//typedef void(*PrintFunc)(VM*, const Str&);
typedef std::function<void(VM*, const Str&)> PrintFunc;

This has (at least for me) no impact on time or size of binary.
May I suggest this is enabled/disabled via a #define PK_ENABLE_STD_FUNCTION_PRINTFUNC 1 or similar as follows? :
#ifdef PK_ENABLE_STD_FUNCTION_PRINTFUNC
typedef std::function<void(VM*, const Str&)> PrintFunc;
#else
typedef void(*PrintFunc)(VM*, const Str&);
#endif

Well, I think you can subclass VM to implement PktpyInterpreter. So you can do static_cast<PktpyInterpreter*>(vm) to get all additional fields, instead of using std::function.

Well, I think you can subclass VM to implement PktpyInterpreter. So you can do static_cast<PktpyInterpreter*>(vm) to get all additional fields, instead of using std::function for each possible C-style callbacks.

This is different from bindings. You are extending the VM (not do some patches). So subclassing is a better design pattern.

Thanks, you are right, although I tend to avoid inheritance, in this case, It makes sense... and seems to work to fine:
// main.cpp
#include "pocketpy.h"
#include "stdio.h"

using namespace pkpy;

class PktpyInterpreter : public VM { };

int main() {
    PktpyInterpreter *py = new PktpyInterpreter();
    PyObject* result = py->exec("1+1", "<eval>", EVAL_MODE);
    if (is_int(result)) {
        int int_result = py_cast<int>(py, result);
        printf("result: %d\n", int_result);
    }
}

and
$ g++ --std=c++17  -O2 -Wall -Wfatal-errors -Wno-sign-compare -Wno-unused-variable -fno-rtti \
       -stdlib=libc++ -o main main.cpp
$ ./main
result: 2

Thanks for your help. It was a quick and successful conversion and I ended up as per your advice with the following member function in PktpyInterpreter:
    this->_stderr = [](VM* vm, const Str& s) {
        if (!static_cast<PktpyInterpreter*>(vm)->disable_stderr) {
            const char* stderr_output = s.c_str_dup();
            error((char*)stderr_output);
        }
    };


Hotfix/gh pages

Think I figured out what's wrong with the gh-pages build. This should fix it. I have a temp repository built on my local box I can try to push the gh-pages with if we'd like to try it first before releasing this into CI.

To answer the k-web-theme submodule was still being used as part of the npm build definition in web/package.json


[usbdev] Fixup test name with 'usbdev_' prefix

This caused breakage with some of our CI metrics gathering scripts, as by convention all tests start with the blockname.
This shouldn't be an issue, but it turns out there is strange underlying dvsim behaviour where if a test is unmapped it creates a 'dummy' test output with 0 total runs, but with the same name as the testpoint. This dummy name clashes the name of the unmapped test in this case.

where if a test is unmapped it creates a 'dummy' test output with 0 total runs,

It should read "if a testpoint contains no tests, it creates ..."


remove Tall Worlds folder

pretty unuseful folder, why is it even still there?

already done for 1.15 branches


VSCode uses MSBuild 14 instead of MSBuild 15 to build Visual Studio 2017 RC solution

Environment data
dotnet --info output:
.NET Command Line Tools (1.0.0-preview4-004233)
Product Information:
Version:            1.0.0-preview4-004233
Commit SHA-1 hash:  8cec61c6f7
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.14986
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\1.0.0-preview4-004233
VS Code version:
Version 1.8.1
Commit ee428b0eead68bf0fb99ab5fdc4439be227b6281
Date 2016-12-19T14:49:23.350Z
Shell 1.4.6
Renderer 53.0.2785.143
Node 6.5.0
C# Extension version:
ms-vscode.csharp-1.6.0-beta6
Steps to reproduce
Create .NET Core library project in Visual Studio 2017 RC
Add XUnit Unit Tests project.
Expected  behavior
Builds using MSBuild 15.0
Actual behavior
Microsoft (R) Build Engine version 14.0.25420.1
Copyright (C) Microsoft Corporation. All rights reserved.
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
Build started 20/12/2016 22:09:10.
Project "c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\StateMachineExplorations.sln" on node 1 (build target(s)).
ValidateSolutionConfiguration:
  Building solution configuration "Debug|Any CPU".
Project "c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\StateMachineExplorations.sln" (1) is building "c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\src\StateMachineExplorations\StateMachineExplorations.csproj" (2) on node 1 (default targets).
c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\src\StateMachineExplorations\StateMachineExplorations.csproj(31,52): error MSB4066: The attribute "Version" in element <PackageReference> is unrecognized.
Done Building Project "c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\src\StateMachineExplorations\StateMachineExplorations.csproj" (default targets) -- FAILED.
Project "c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\StateMachineExplorations.sln" (1) is building "c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\tests\StateMachineExplorationTests\StateMachineExplorationTests.csproj" (3) on node 1 (default targets).
c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\tests\StateMachineExplorationTests\StateMachineExplorationTests.csproj(25,37): error MSB4066: The attribute "Version" in element <PackageReference> is unrecognized.
Done Building Project "c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\tests\StateMachineExplorationTests\StateMachineExplorationTests.csproj" (default targets) -- FAILED.
Done Building Project "c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\StateMachineExplorations.sln" (build target(s)) -- FAILED.
Build FAILED.
"c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\StateMachineExplorations.sln" (build target) (1) ->
"c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\src\StateMachineExplorations\StateMachineExplorations.csproj" (default target) (2) ->
  c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\src\StateMachineExplorations\StateMachineExplorations.csproj(31,52): error MSB4066: The attribute "Version" in element <PackageReference> is unrecognized.
"c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\StateMachineExplorations.sln" (build target) (1) ->
"c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\tests\StateMachineExplorationTests\StateMachineExplorationTests.csproj" (default target) (3) ->
  c:\Projects\PauloMorgado_GH\StateMachineExplorations\git\tests\StateMachineExplorationTests\StateMachineExplorationTests.csproj(25,37): error MSB4066: The attribute "Version" in element <PackageReference> is unrecognized.
    0 Warning(s)
    2 Error(s)
Time Elapsed 00:00:00.07

Paulo -- I'm a bit confused. VS Code doesn't launch MSBuild to build your project. Also, your repro steps don't actually get to the actual behavior (I assume you've opened the project and built somehow). Could you clarify your steps?

@DustinCampbell,
I created a solution on Visual Studio 2017 RC with a class library project and a XUnit unit test project.
Then I opened it in VSCode (after installing the latest beta of OmniSharp - 1.6.0-beta6).
Then I pressed Ctrl+Shift+B to build and it prompted me to configure the task runner and I chose MSBUILD.
The solution is here, if you want to take a look at it.

Ah. The problem is choosing MSBuild. That's not actually owned by the C# extension. Try this:

Delete the .vscode folder in your project.
Open the project in VS Code.
Press Ctrl+Shift+B and choose ".NET Core"

Doh!
Now it builds using Microsoft (R) Build Engine version 15.1.458.808.
Can I run the unit tests in VSCode?

Not really. We don't have very robust support for unit testing in VS Code. There's some support, but it's not great. You should be able to run unit tests at the command line with dotnet test.

Yep! Working fine on the command line.
Strange that the test project builds fine, but on the editor it's complaining about Moq.

Maybe run dotnet restore at the command line?

That was my first thought.
Eventually closing and opening VSCode solved it.

Ahh... it's likely that you had VS Code open with your project when you performed a dotnet restore. In that case, OmniSharp wouldn't have caught the change yet. You can kick OmniSharp with the Restart OmniSharp command inside VS Code (or close/open your project, or just restart).
csproj-based .NET Core projects are still a work-in-progress. :smile:

Paulo, I'm going to close this for now because the original issue sounds like it's solved. Feel free to file issues if you come across problems. We're definitely interested in whatever can help make the extension better. Thanks!

Hi, I m using Jenkins to build my project but m getting the following error
`Build started 3/27/2018 2:30:27 PM.
Project "D:\PSAVWorkSpaces\abcd\Dev\ReleaseA\abcd\abcd\abcd.Droid\abcd.Droid.csproj" on node 1 (SignForAndroid target(s)).
D:\PSAVWorkSpaces\abcd\Dev\ReleaseA\abcd\abcd\abcd.Droid\abcd.Droid.csproj(113,47): error MSB4066: The attribute "Version" in element is unrecognized.
Done Building Project "D:\PSAVWorkSpaces\abcd\Dev\ReleaseA\abcd\abcd\abcd.Droid\abcd.Droid.csproj" (SignForAndroid target(s)) -- FAILED.
Build FAILED.
"D:\WorkSpaces\abcd\abcd\abcd.Droid\abcd.Droid.csproj" (SignForAndroid target) (1) ->
D:\WorkSpaces\abcd\abcd\abcd.Droid\abcd.Droid.csprojj(113,47): error MSB4066: The attribute "Version" in element is unrecognized.
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:00.01
Build step 'Build a Visual Studio project or solution using MSBuild' marked build as failure
Finished: FAILURE`
i tried using dotnet restore but it pop up with below error

D:\Jenkins\JenkinsHome\workspace\abcd>dotnet restore  D:\Jenkins\JenkinsHome\workspace\abcd\abcd.Common.Files\abcd.Common.Files.csproj(158,3): error MSB4019: The imported project "C:\Program Files\dotnet\sdk\2.1.100\Microsoft\Portable\v4.5\Microsoft.Portable.CSharp.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk. D:\Jenkins\JenkinsHome\workspace\abcd\abcd.Sqlite.Entities\abcd.Sqlite.Entities.csproj(71,3): error MSB4019: The imported project "C:\Program Files\dotnet\sdk\2.1.100\Microsoft\Portable\v4.5\Microsoft.Portable.CSharp.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk. D:\Jenkins\JenkinsHome\workspace\abcd\abcd.Generic.Interfaces\abcd.Generic.Interfaces.csproj(64,3): error MSB4019: The imported project "C:\Program Files\dotnet\sdk\2.1.100\Microsoft\Portable\v4.5\Microsoft.Portable.CSharp.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk. D:\Jenkins\JenkinsHome\workspace\abcd\abcd.WebApi.Interfaces\abcd.WebApi.Interfaces.csproj(71,3): error MSB4019: The imported project "C:\Program Files\dotnet\sdk\2.1.100\Microsoft\Portable\v4.5\Microsoft.Portable.CSharp.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk. D:\Jenkins\JenkinsHome\workspace\abcd\abcd.Sqlite.Interfaces\abcd.Sqlite.Interfaces.csproj(76,3): error MSB4019: The imported project "C:\Program Files\dotnet\sdk\2.1.100\Microsoft\Portable\v4.5\Microsoft.Portable.CSharp.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk. D:\Jenkins\JenkinsHome\workspace\abcd\abcd\abcd.Droid\abcd.Droid.csproj(269,3): error MSB4019: The imported project "C:\Program Files\dotnet\sdk\2.1.100\Xamarin\Android\Xamarin.Android.CSharp.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk. D:\Jenkins\JenkinsHome\workspace\abcd\abcd.WebApi.Methods\abcd.WebApi.Methods.csproj(98,3): error MSB4019: The imported project "C:\Program Files\dotnet\sdk\2.1.100\Microsoft\Portable\v4.5\Microsoft.Portable.CSharp.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk. Files\dotnet\sdk\2.1.100\Microsoft\Portable\v4.5\Microsoft.Portable.CSharp.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on di

can anyone help me with this
thankyou

@SonaliRane26: This is the repo for the C# extension for VS Code. We can only help you here with issues related to that project.
I suspect you're looking for https://github.com/dotnet/cli or https://github.com/dotnet/sdk. However, I can tell you that you will not be able to build Xamarin or Portable projects with the .NET CLI, which it looks like you're trying to do.

Yes, thankyou


no release workflow

I noticed that the releases have been outdated for several years already and the release workflow has been removed. Any plans for adding it back?

Yeah, we need a release workflow. PR's welcome!

the release workflow has been removed

The previous is just a template and never works


function returning default breadcrumb markup

Having to define breadcrumb markup manually each time i use plugin is s bit if a chore. There should be function that returns ready to use breadcrumb HTML, ready to use, implemenying all nessesary schema tags.
Do you accept pull requests? If yes, i can do this for you.

Hi @piotrpog
Thanks for taking time to report this issue and offer a pull request.
I like your ideas but it makes the plugin opinionated.
What happens if somebody wants to display a visual breadcrumb using BEM syntax or using Tailwind classes as an example? The same could be said about the HTML markup.
I appreciate BreadcrumbList schema is more defined, but again, what happens if somebody wants to markup a multiple breadcrumb trail?
I think these decisions are best left for the developer to decide, not the plugin. Once you create a Twig component once, it's easy to copy across projects.

@jonleverrier
Well, classes can be passed to components using function parameters. Not only classes but whole arrays that are later transformed into HTML attributes like in Craft attr() function.
I feel that having such additional function won't hurt - for "lazy" people it would be ready to use, for devs that need something custom, there would be still a possibility of manual rendering.
But I respect your decision :)

Thanks @piotrpog - I appreciate your feedback :)


Add files via u#pload

#40我修正了ioserverTests类的testWriteLine发方法，使它能够正常运行，此外，在testWriteLine方法中修改后的内容能够同时验证字符内容和颜色。还为la

ngResourceBoundle类天机了junit测试方法。覆盖率如下图

The submitted code was totally unrelated with proposed issue. Stop polluting my repo with “Add files via upload”.


pip installing FB does not include all scripts

Hey folks,
Christoph Koeberlin pointed out that pip installing FB does not include all of the scripts.

There's no fix-fsselection.py etc

it must  be mentioned in setup.py. https://github.com/googlefonts/fontbakery/blob/master/setup.py#L66
We should probably write a function that collects all these scripts and registers them, simmilar to https://github.com/googlefonts/fontbakery/blob/master/bin/fontbakery#L9 (maybe we should reuse this, so there's no difference ever)

Sounds good, @felipesanches could you take care of this?

I reviewed and fixed this earlier this week and released FontBakery v0.2.1 on pypi. See https://github.com/googlefonts/fontbakery/issues/1406#issuecomment-312751979

Please automate the process so we don't regress on this
On Jul 9, 2017 11:06 AM, "Felipe Corrêa da Silva Sanches" <
<EMAIL_ADDRESS>wrote:

I reviewed and fixed this earlier this week and released FontBakery v0.2.1
on pypi. See #1406 (comment)
https://github.com/googlefonts/fontbakery/issues/1406#issuecomment-312751979
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/googlefonts/fontbakery/issues/1378#issuecomment-313925446,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAP9y3GoRl8grLnwSSI0gqSaUwsjtiw7ks5sMOx2gaJpZM4NxF80
.


Incorrect code in  BottomUp 0/1 Dynamic problem

https://github.com/mission-peace/interview/blob/master/src/com/interview/dynamic/Knapsack01.java
Line 38 has the formula K[i][j] = Math.max(K[i-1][j], K[i-1][j-wt[i-1]] + val[i-1]);
It should be  K[i][j] = Math.max(K[i-1][j], K[i-1][j-wt[i-1]] + val[i]);

Actually, its not an issue. I forgot that K is one row and one column bigger than wt array.


Error: missing provider provider["registry.terraform.io/hashicorp/oci"].home

I am getting the error below when running terraform validate or terraform apply
[raoul@auto terraform-oci-oke]$ terraform init
Initializing modules...
Initializing the backend...
Initializing provider plugins...

Reusing previous version of hashicorp/time from the dependency lock file
Reusing previous version of hashicorp/local from the dependency lock file
Reusing previous version of hashicorp/oci from the dependency lock file
Reusing previous version of hashicorp/cloudinit from the dependency lock file
Reusing previous version of hashicorp/null from the dependency lock file
Using previously-installed hashicorp/time v0.7.2
Using previously-installed hashicorp/local v2.1.0
Using previously-installed hashicorp/oci v4.62.0
Using previously-installed hashicorp/cloudinit v2.2.0
Using previously-installed hashicorp/null v3.1.0

Terraform has been successfully initialized!
You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.
If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
[raoul@auto terraform-oci-oke]$ terraform validate
╷
│ Error: missing provider provider["registry.terraform.io/hashicorp/oci"].home
│

I am also experiencing this issue when invoking this module via Terragrunt.
│ Error: missing provider provider["registry.terraform.io/oracle/oci"].home

Getting same error,
Error: missing provider provider["registry.terraform.io/oracle/oci"].home

If my experience of using Oracle Cloud, opening issues, talking to their support directly, and trying to deploy their Kubernetes offering on OCI is anything to go by I would patch this yourself and move on. Oracle do not care.

Please, check if this issue can be reproduced with latest code release.


Image overexposed and too dark at the same time; DFK 37AUX265

Hi,
I'm in a kind of a hurry to meet a client's deadline.
I'm using one DFK 37AUX265 camera and there does not seem to be a set of parameters that give me a good image under outdoor lightening. Usually there is a high source of light and a high dynamic range for the application and the image tends to get overexposed at some areas, what set of parameters is suitable and how can I implement WDR on linux ?
here is my gstreamer pipeline:
"tcambin serial="" name=source ! video/x-raw,format=RGBx,width=1920,height=1080,framerate=30/1 ! appsink name=sink"
I'm using python for the application.

Hello
For Linux I have currently solution for using the 10bit range per color channel of your camera. This is currently implemented in Windows with WDR/Tonemapping property only. We still work on a closed source library containing these algorithms.
So, what you can do on your own:
First of all, overexposed areas do not contain any information. Thus, avoid overexposed areas. This, of course, results in a dark image. But the dark areas usually contain enough information, so with a more or less smart histogram spreading you can brighten up the dark areas and lower the bright ones.
You can use
I did not test on my own, but you may try following modules:
https://gstreamer.freedesktop.org/documentation/frei0r/frei0r-filter-equaliz0r.html?gi-language=c#frei0r-filter-equaliz0r (I do not know, how to install that)
https://gstreamer.freedesktop.org/documentation/videofilter/gamma.html?gi-language=c#gamma
! videoconvert ! gamma gamma=0.2 ! ximagesink
Play with values less 1.0 or above.
You may find more filters at https://gstreamer.freedesktop.org/documentation/plugins_doc.html?gi-language=c
Stefan

Thanks for the quick reply,
I tested the WDR/Tonemaping property on Windows and the image is perfectly fine.
So to be sure there is no such property available for linux as of right now and if not do you have a specific timeline?
One more question before testing the Histogram spreading,
Is it normal for the Highlight Reduction to be kind of slow ?

The tonemapping is done inside the Windows driver, thus it is done in software.
It is currently not avaialble in Linux, we are in process of writing that as Gstreamer module.

Is it normal for the Highlight Reduction to be kind of slow ?
Depends on the meaning of "slow".  A particular mimium area of the image must be over exposed, until this property comes into effect.

Thanks a lot. Good luck

Good luck
Hopefully it is not a matter of luck. But the current version is far too slow.

Did you try the "gamma" module?


md-math-block uses non-Oniguruma regex

Does this issue occur when all extensions are disabled?: No. This is an issue in the Markdown Math extension.

VS Code Version: master branch commit 60fe2d5970245742a89a0bdead58f0626d957f1c
OS Version: NA

The following regex in md-math-block.tmLanguage.json is not a valid TextMate regex:
https://github.com/microsoft/vscode/blob/60fe2d5970245742a89a0bdead58f0626d957f1c/extensions/markdown-math/syntaxes/md-math-block.tmLanguage.json#L16
TextMate grammars should use the Oniguruma regex dialect. This is the regex engine used by Ruby. The given regex give the following result when tried in Ruby:
(?<=^\\s*)(\\${2})(?![^$]*\\${2})
=> jdoodle.rb:1: invalid pattern in look-behind: /(?<=^\\s*)(\\${2})(?![^$]*\\${2})/

Tested at jdoodle.com using Ruby 3.0.2.
Either the regex should be updated, or the regex implementation should be fixed to be compliant with Oniguruma.
About TextMate regexes:
https://macromates.com/manual/en/regular_expressions
https://code.visualstudio.com/api/language-extensions/syntax-highlight-guide#textmate-grammars
This issue was first observed here: https://github.com/eclipse/tm4e/issues/525

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.78.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

The issue appears to be that the first portion of the regex, (?<=^\\s*), is a lookbehind on a variable-length subexpression. Onigurama only supports lookbehind on a fixed-length subexpression.

vscodes TextMate engine uses the Oniguruma dialect
which does support variable length lookbehinds
https://github.com/kkos/oniguruma/blob/master/doc/SYNTAX.md#6-onig_syn_different_len_alt_look_behind-allow-abc

Oniguruma can handle either form, but not all regex engines can, so for compatibility, Oniguruma allows you to cause regexes for other regex engines to fail if they might depend on this rule.

look-behind length is however limited to 65536 characters

Closing as this doesn't seem like an issue for how we're using the grammar. PRs welcome if you want to provide a reasonable fix for other users


Add new pet chicken

This is connected to issue #242
I changed all necessary things. (or at least I think that I have done this) I tested it and the extension creates the chicken, but it does not get displayed in the frame. Now I don't really know what to do anymore to get it working. :/
Additionally I get errors from the translation files, but I guess, that this has nothing to do with the new chicken-pet.

Make sure you're running a newer version of vs code. Also open up the Developer Console to see any runtime errors

I forgot to compile the whole project and because of this the chicken could not load. 😂

Love your chicken names list,  'Albert Eggstein' 😂 this is masterpiece 🤌🏼

Codecov Report

Merging #339 (4baf824) into master (76aca9f) will decrease coverage by 2.00%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   16.35%   14.34%   -2.01%
==========================================
  Files          18       17       -1
  Lines        1107      774     -333
  Branches      152      103      -49
==========================================
- Hits          181      111      -70
+ Misses        917      663     -254
+ Partials        9        0       -9

Impacted Files
Coverage Δ

src/common/types.ts
71.42% <ø> (ø)

src/panel/pets.ts
19.79% <33.33%> (+0.43%)
:arrow_up:

src/panel/pets/chicken.ts
50.00% <50.00%> (ø)

src/extension/extension.ts

src/common/localize.ts

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Love it!! 👍🏻


Spritesheet with Rotated frames do not display correctly

Hi,
I have a problem with my spritesheet created by TexturePacker. When I untick the checkbox "Allow Rotation" in TexturePacker, it works perfectly. But with the tag "rotated": true in json file, some frames seem to be wrongly positioned and the animation didn't display correctly.
Thank you.

I found this too, worked fine on all my testing devices except the iphone 4 where width/height were reported incorrectly.

It seems to be a problem with frame size. When I have an rotated image from a spritesheet and set interactive = true, then width and height of the hitArea are inverse with the size of image.

Hey @LEMinhViet, can you provide a live example?

You can see that the smoke do not display correctly.

@LEMinhViet When we say live example, we mean a running code example. We need to debug the code and see what is happening.
Thanks!

sorry, that's the example
http://jsfiddle.net/vietlm13/fm4ewufq/7/
It seems to be happen only with CanvasRender

Yes, the problem occurs when using the CanvasRenderer and displaying a Sprite that uses a rotated texture from a sprite sheet. Making a example now.

Made a test with a sprite. The WebGLRenderer will render correctly but the CanvasRenderer will not.
Download: https://www.dropbox.com/s/3vhu6no9g3hwaeu/PixiCanvasRendererBugTest.zip?dl=0

hello! this should be fixed now :+1:


Leave SofaTraceContext to spring ioc management

Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.

I have signed cla

is there an issue to describe this PR?  I think SofaTraceContext cannot be Managed to spring IOC.

When I need to get Span ID，i must do this :SofaTraceContextHolder.getSofaTraceContext().getCurrentSpan().getSofaTracerSpanContext().getSpanId();
it's to long and not graceful, i wanna inject SofaTraceContext by @Resource/@Autowired,like inject request by @Autowired

When I need to get Span ID，i must do this :SofaTraceContextHolder.getSofaTraceContext().getCurrentSpan().getSofaTracerSpanContext().getSpanId();
it's to long and not graceful, i wanna inject SofaTraceContext by @Resource/@Autowired,like inject request by @Autowired

If there is no use the spring, how to do？


Load TMS by default

To simplify the experience (and to create a quicker load) on a single image, can we load the TMS by default and take away the option to view the thumbnail on the map? Is there an advantage to viewing the the thumbnail in place of the TMS? We could add the ability to download the thumbnail image as a TIFF or PNG. On this topic, is thumbnail the correct term for this image?

This is fixed and deployed to staging.
I didn't remove the thumbnail option simply because I know there are currently images on production that don't have a TMS.


When creating Nets as part of a Bus, create them in a circuit

When creating Nets as part of extending a Bus, create the nets as part of the circuit of what we want to connect them to, rather than the default circuit. This causes a crash if this functionality is used on a circuit other than the default circuit

Thanks for fixing this!
I had to change your code since an int doesn't have a circuit attribute. So I changed both your modifications to use the circuit of the bus (circuit=self.circuit). I checked the modifications into the development branch. Test it and make sure it does what you need.

OK, I'll assume this works...


Feature/profile

Adding edit profile

You can fix the JS issues on codeclimate and make sure that the tests run successfully on the CI.
Use phantomjs if chrome crashes several times.


Fix that weird periodicity error on left/right margins

(actually probably an issue with Universe::add_pulsar())

fixed! it was a problem with add_pulsar!


Updated Resources Links

Added some more resources/links.
NOTE: original Markdown formatting changed (to Pandoc+GitHub standard
output) due to editor auto-cleanup. Sorry about that...

I apoligise for the markdown auto-reformatting ... my MD editor auto-cleans up whenever I save.
I know that MD diffing can be a bit of a nightmare, but since I've only added links (and changed 2 entries — Inform and TADS) if the Pandoc default formatting is not a problem I guess you could accept it as is.
Else, we could agree on some standard formatting — invoking pandoc (with agreed upon extensions) to process from markdown to markdown, so that the README file is always formatted according to a given standard.
I was about to create my own Awesome Interactive Fiction list, and when I checked if there was already one in place I was really glad to find yours. I hope we can work on it together!
Best regards

Another commit followed:
I've added more resources links, and also changed/added some categories. Corrected some broken links.
"Frameworks and Tools" renamed to "Software" -> "IF Developement Tools"
"Interpreters" now falls under "Software", and I've subdivided terps by OS type. Also added some description, regarding which story files are supported.
I've fixed some links which contained twice "http://" and were broken...
Hope these structural changes are welcomed.
PS: Is this list intended to be a "curated" list (Awesome-stuff only) or an omni-comprehensive one (link all resources available)?

Hey hey,
I'm not bothered by the Markdown formatting change in this case. It's fine.
I like the category changes. I think a couple of the links are still broken, but I'm going to merge this in as-is.
When I started this list, I leaned towards making it a comprehensive one. I still feel the same. However, I'd love to explicitly indicate which resources are thoroughly awesome.
Thanks for contributing!

Thanks for merging!
I agree: a comprehensive list suite better the Interactive Fiction vast echo-system — many of the "old systems" are actually still in use (like Z-Code); and since usually story files are played into virtual machines, there is an abundance of implementation for different platforms, all of them worth mentioning.


Improve ST7789 frame rate ~4x

The ST7789's Tscycw (time between serial write clock cycles) is
16 ns. This can be found on page 44 of the datasheet I'm using:
https://www.waveshare.com/w/upload/a/ae/ST7789_Datasheet.pdf
(I do not know which manufacturer Pimoroni products use and if
their parts might be different. But it seems like this wouldn't
change.)
The existing code sets the SPI baud to 16 * 1000 * 1000. But baud
is Hz, not seconds. That 16 * 1000 * 1000 doesn't represent 16 ns.
It represents 16,000,000 Hz.
16 ns * (1 Hz / s) = 62,500,000 Hz.
This commit changes the baud from 16 * 1000 * 1000 to 62'500'000,
representing ~4x speed improvement in SPI and thus ~4x frame rate
improvement, since the display's frame rate is currently
SPI-limited.
A before & after video can be seen here:
https://www.youtube.com/watch?v=n2y19TCnATo
Note that also on page 44 of that datasheet Tscycr (the read speed)
is only 150 ns, not 16 ns. Right now, the Pimoroni code doesn't read
any values back from the ST7789 so it is safe to operate at the
higher speed.
Also note that the 16 * 1000 * 1000 is the requested baud. The actual
baud is the closest the Pico can get, which is 15,625,000.
The new requested baud of 62'500'000 results in an exact match.

I should mention I was able to test this change on the Pico Display (the 1.14" version, not the 2.0 version) and the Pico Explorer.
My local store doesn't carry any other Pimoroni products that have a screen.
I will order some others online to test them as well.

Thank you- hopefully I'll get 'round to giving this a go across some of our other displays. 16MHz is pretty slow for SPI displays and I'm not sure how we landed on that value. It was probably a conservative choice, but it seems a bit too conservative.

My Pico Display 2 has arrived. I tested on it.
However, it calls into drivers/st7789/st7789.cpp : ST7789::init(), passing a baud of 74 * 1000 * 1000. That overrides the default. So there are no visible changes on the Pico Display 2.
That said, the baud specified by the Pico Display 2 is higher than what the Raspberry Pi Pico can handle. I checked and that large value also gets rounded down to 62'500'000 baud.
I'll update the pull request to include a fix for that as well.
(I have a Pico System as well that I can test. However, this code isn't used on any Pico System examples.)

Thanks for all your sleuthing here! Extra eyes are always appreciated on my terrible code 😆


advertisement-discovery.js not detecting con-connectable peripheral

On a Raspberry Pi 3 with bluez installed, I can run the following and detect my BLE device which is running on a non-connectable advertising mode:
sudo hcitool lescan

But when I run:
sudo node advertisement-discovery.js

I don't see the above device. I am able to see other connectable BLE devices.
Any idea what might be going on? Thanks.

Anyone?
The above can be tested by running the ble_app_beacon Nordic example on the nRF52-DK.

@electronut see https://github.com/sandeepmistry/noble/issues/594#issuecomment-294382410.
Closing as a duplicate of #594 .


Package in npmjs isn't current to master

Realized that when I saw that the messageStructureParser was trying to find the UNECE definitions at www.unece.org, but that url has actually changed to service.unece.org, which is already reflected in master but not in the package published to npmjs...

I've released 0.0.13 today which should include the update of the service URL


Update logo on contributors list

Kept the same file dimensions and positioning.
Should look OK until a proper redesign. :smile:

@dosire Is this the right place to make this change?

:+1:


bug in tf.histogram_fixed_width_bins

This PR is to correct a bug that is present in tf.histogram_fixed_width_bins. The issue was described in https://github.com/tensorflow/tensorflow/issues/29661.
When the elements of value_range are same and matches with one or more of the elements in input array values, then the index of the element will be outside nbins.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Please give me couple of days. I will update the code as suggested by @alextp . Thanks!

Any updates here, @jvishnuvardhan ?

@mihaimaruseac Will complete it by tomorrow. Thanks!

Almost ready! Now all we need is a test to prevent this fix from being scaled back.

Thanks @alextp. Added a test case. Please let me know if that is sufficient? Thanks!

@jvishnuvardhan Can you please check build failures? Thanks!

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

It has been 43 days that this pull-request has stalled. Please create a new pull-request with the requested changes.


Add unit tests

These will be required at some point, especially when we need to merge pull requests etc.
CasperJS could be useful, Hugo uses it on his accessible Modal

https://github.com/edenspiekermann/accessible-modal-dialog/blob/master/tests/index.js
http://docs.casperjs.org/en/latest/testing.html

Currently underway with Mocha/Chai. We need to scope out the necessary tests for all components and unique tests per component, also whether we incorporate cross-browser testing? It seems like we should be able to do this, we need to make sure the test suite supports the browsers we need to support. We can automate with phantomjs as well, but I'm not sure the benefit outweighs the pain in setting it up.

Branch open: https://github.com/frend/frend.co/tree/feature/domtests


the-sz.Doro version 2.22

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @the-sz,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 870.)

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-03-14 14:02:59.171 [FAIL] Installer failed security check. Url: https://the-sz.com/common/get.php?product=doro Result: 0x80004005

(Automated response - build 870.)

@wingetbot run


SB-1133: Remote Artifacts resolution improvements

@carlspring can you please have a look? it's ready to merge

@steve-todorov if you will have a time can you please verify that SB-1133 resolved?

@sbespalov I will be able to test this at some time Sunday. @carlspring maybe you could have a look before me?

@sbespalov your changes seem to be fixing SB-1133 indeed! The inotify test shows the file is written only once and then it's only reading. I don't have time to check if this improves the performance - will do that Sunday if by then nobody has had a chance to do it. Great job Sergey! :)


SOC C Libcaliptra should mask the upper nibble of the SOC RTL Address

Currently the caliptra_top_regs.h provided by RTL source include a 0x3xxxxxxx offset which can`t be consumed directly by the IP.
Libcaliptra should mask those component out, before calling apb_write/read APIs

Can we get rid of this static address bit in a future version of caliptra?


Documentation got fixed.

Delete the unnecessary @docs at the beginning of the functions' doc.

cc024d67e5b936d7b5391cbcef564e2cdc18b95b


Error Error: Cannot find module './utils' when upgrading to V1.0

I am coming from version 0.2 and tried to upgrade to version 1.0 and received the below errors.
`

host.RR-DEB-iOB
2023-01-20 11:29:25.381
error
Caught by controller[0]: }

host.RR-DEB-iOB
2023-01-20 11:29:25.381
error
Caught by controller[0]: ]

host.RR-DEB-iOB
2023-01-20 11:29:25.381
error
Caught by controller[0]: '/opt/iobroker/node_modules/iobroker.oekofen-json/main.js'

host.RR-DEB-iOB
2023-01-20 11:29:25.381
error
Caught by controller[0]: '/opt/iobroker/node_modules/iobroker.oekofen-json/node_modules/axios/index.js',

host.RR-DEB-iOB
2023-01-20 11:29:25.380
error
Caught by controller[0]: '/opt/iobroker/node_modules/iobroker.oekofen-json/node_modules/axios/lib/axios.js',

host.RR-DEB-iOB
2023-01-20 11:29:25.380
error
Caught by controller[0]: requireStack: [

host.RR-DEB-iOB
2023-01-20 11:29:25.380
error
Caught by controller[0]: code: 'MODULE_NOT_FOUND',

host.RR-DEB-iOB
2023-01-20 11:29:25.380
error
Caught by controller[0]: at Module.require (node:internal/modules/cjs/loader:1067:19) {

host.RR-DEB-iOB
2023-01-20 11:29:25.380
error
Caught by controller[0]: at Function.Module._load (node:internal/modules/cjs/loader:878:12)

host.RR-DEB-iOB
2023-01-20 11:29:25.380
error
Caught by controller[0]: at Module.load (node:internal/modules/cjs/loader:1043:32)

host.RR-DEB-iOB
2023-01-20 11:29:25.380
error
Caught by controller[0]: at Object.Module._extensions..js (node:internal/modules/cjs/loader:1219:10)

host.RR-DEB-iOB
2023-01-20 11:29:25.379
error
Caught by controller[0]: at Module._compile (node:internal/modules/cjs/loader:1165:14)

host.RR-DEB-iOB
2023-01-20 11:29:25.379
error
Caught by controller[0]: at Object. (/opt/iobroker/node_modules/iobroker.oekofen-json/node_modules/axios/lib/axios.js:3:13)

host.RR-DEB-iOB
2023-01-20 11:29:25.379
error
Caught by controller[0]: at require (node:internal/modules/cjs/helpers:103:18)

host.RR-DEB-iOB
2023-01-20 11:29:25.379
error
Caught by controller[0]: at Module.require (node:internal/modules/cjs/loader:1067:19)

host.RR-DEB-iOB
2023-01-20 11:29:25.379
error
Caught by controller[0]: at Function.Module._load (node:internal/modules/cjs/loader:841:27)

host.RR-DEB-iOB
2023-01-20 11:29:25.379
error
Caught by controller[0]: at Function.Module._resolveFilename (node:internal/modules/cjs/loader:995:15)

host.RR-DEB-iOB
2023-01-20 11:29:25.379
error
Caught by controller[0]: - /opt/iobroker/node_modules/iobroker.oekofen-json/main.js

host.RR-DEB-iOB
2023-01-20 11:29:25.379
error
Caught by controller[0]: - /opt/iobroker/node_modules/iobroker.oekofen-json/node_modules/axios/index.js

host.RR-DEB-iOB
2023-01-20 11:29:25.378
error
Caught by controller[0]: - /opt/iobroker/node_modules/iobroker.oekofen-json/node_modules/axios/lib/axios.js

host.RR-DEB-iOB
2023-01-20 11:29:25.378
error
Caught by controller[0]: Require stack:

host.RR-DEB-iOB
2023-01-20 11:29:25.378
error
Caught by controller[0]: Error: Cannot find module './utils'

host.RR-DEB-iOB
2023-01-20 11:29:25.378
error
Caught by controller[0]: ^

host.RR-DEB-iOB
2023-01-20 11:29:25.378
error
Caught by controller[0]: throw err;

host.RR-DEB-iOB
2023-01-20 11:29:25.377
error
Caught by controller[0]: node:internal/modules/cjs/loader:998

`

hi @looxer01, which version 0.2? 0.2.0?
In that case you most probably need to delete the instance and the adapter and start with a fresh install of 1.0.0 again.
The commit from Aug 15, 2022 (v0.2.3) right after 0.2.0 targeted many things Apollon pointed out which have to be changed for the adapter to be compliant (encrypted passwords, static objects not created in the code, ...) so most probably this was a breaking change at the package.

thx for the fast response. I completely deleted the version and then installed V1.0.
there is no error but I am getting a huge number of channels in the objects list and the system slows down of course.
looks like an error to me. Before it was like HK1, Hk2 etc which made sense to me

this is mostly weird tbh. You're the second one with that issue, like #7 - but i've never heard something again about it. I still can't imagine how this condition happens as there's no counter used in the code, only the response of the ökofen is parsed and iterated so in theory when i think about the process only when the response from axios contains that, this would be created. Can you normally access the json interface of your ökofen via a browser and receive a normal json response with hk1, hk2, ww1, pe1, ..?

Hi,
the jason respons is as expected. It worked with 0.2.0 Beta without issue.
Anthing I can do for furthe analysis ?

Hi, thats interesting news - i've never tried using a wrong password... if that is causing that behaviour maybe i can catch that in the code. i'll have a look into that


Incorrect error information for boundary check.

Changing the third clause of S¹-T² in T2.aya into a hole gives the error
In file Spaces/Torus/T2.aya:16:18 ->

  14 |   | base, base => point
  15 |   | loop i, base => line1 i
  16 |   | base, loop i => {??}
     |                     ^--^

Goal: Goal of type
        T²
        (Normalized: T²)
      Context:
        {i : I}
      To ensure confluence:
        Given (i => i), we should have: point
        Given (i => i), we should have: point
        Given (i => i), we should have: face 0 j
        Given (i => i), we should have: face 1 j

where the confluence error message produce incorrect substitution hints.

Latest Aya gives
Goal: Goal of type
        T²
        (Normalized: T²)
      Context:
        {i : I}
        {j : I}
      To ensure confluence:
        Given (i => i, i => 0), we should have: line2 j
        Given (i => i, i => 1), we should have: line2 j
        Given (i => j, j => 0), we should have: line1 i
        Given (i => j, j => 1), we should have: line1 i
Error: Unsolved meta _1

😅

Getting close!

Maybe we can sanitize the substitution by removing unused vars and rename the same-named vars.

The case for reporting the last clause can be fixed easily by removing the redundant substitutions involved during condition check. (See first commit of #878)
That is, the definition
def S¹-T² (s1 s2 : S¹) : T²
| base, base => point
| loop i, base => line1 i
| base, loop i => line2 i
| loop i, loop j => {??}

now correctly produces the message
Goal: Goal of type
        T²
        (Normalized: T²)
      Context:
        {i : I}
        {j : I}
      To ensure confluence:
        Given (i => 0), we should have: line2 j
        Given (i => 1), we should have: line2 j
        Given (j => 0), we should have: line1 i
        Given (j => 1), we should have: line1 i

However, for the case where
def S¹-T² (s1 s2 : S¹) : T²
| base, base => point
| loop i, base => line1 i
| base, loop i => {??}
| loop i, loop j => face i j

the message is a bit mysterious
Goal: Goal of type
        T²
        (Normalized: T²)
      Context:
        {k : I}
      To ensure confluence:
        Given (k => 0), we should have: point
        Given (k => 1), we should have: point
        Given (i => 0), we should have: face 0 j
        Given (i => 1), we should have: face 1 j

by referencing the variable i.
This is due to the fact that the hole in the third clause actually has conditions imposed by the fourth clause, and the substitution i => 0 refers to the context in the fourth clause.
I need to work on those cases now.

Great!!

Now we have for the clause base, loop k => {??},
Goal: Goal of type
        T²
        (Normalized: T²)
      Context:
        {k : I}
      To ensure confluence:
        Given (k => 0), we should have: point
        Given (k => 1), we should have: point
        Given (k => j), we should have: face 0 j
        Given (k => j), we should have: face 1 j

Making much better sense.


fixup typo

Just a simple fix for a typo in the code example.
Checklist

[x] documentation is added or updated
[ ] tests are added or updated

@baloo if you agree that this is a trivial change, could you amend the git commit so it includes CLA: trivial on a line by itself.  git commit --amend followed by git push -f.
Otherwise, we'll need a CLA filled in.

@baloo if you agree that this is a trivial change, could you amend the git commit so it includes CLA: trivial on a line by itself. git commit --amend followed by git push -f.
Otherwise, we'll need a CLA filled in.

@paulidale He already did that. Although the commit message subject (the first line) could be amended as well to make it more clear. Something like EVP_KDF-KB man page: Fix typo in the example code would make it better.

@t8m, I confused.  I thought the need CLA was present.

https://github.com/openssl/openssl/commit/88b7a6b1212c6ce8ed0922b68f412550b659f309.patch
From 88b7a6b1212c6ce8ed0922b68f412550b659f309 Mon Sep 17 00:00:00 2001
From: Arthur Gautier<EMAIL_ADDRESS>Date: Sat, 6 Mar 2021 23:08:08 +0000
Subject: [PATCH] fixup typo

CLA: trivial
Signed-off-by: Arthur Gautier<EMAIL_ADDRESS>
Am I missing something?

I changed the commit title as suggested.

@t8m, I confused. I thought the need CLA was present.

The need for CLA was present but I pushed a new amended commit a couple minutes later once I learned about the CLA. First commit I pushed on openssl :)

Still approved

The CLA thing was my mistake, sorry.
Still approved.