feat: add ResourceHierarchyLoader::findRecursive() and new CachedReso…

To be able to find resources in the resource hierarchy according to certain criteria, a findResource method is required.
If this method is used intensively, the resource should not have to be reloaded every time. For this reason, a CachedResourceLoader is also provided that can cache resources that have already been loaded.

The findRecursive must be included in the interface if I want to use it, because I never use the direct implementation.
I have the following use case.
  $resource = $this->categoryLoader->findRecursive(
      $location,
      function ($resource) use ($anchor) {
          $resourceAnchor = $resource->getData()->getString('init.anchor');
          return $resourceAnchor === $anchor;
      }
  );

A RecursiveIterator class might be an alternative. I just find it very cumbersome to work with sometimes.

Die Idee, das ganze Navigieren in dem Baum nicht über den ResourceHierarchyLoader bereit zu stellen finde ich gut. Es ist auch sicher besser das Laden der Resource und dessen Kindern zu trennen.
Es ist etwas schwer zu entscheiden welche Provider notwendig sein werden.
Um meinen Fall abzudecken könnte ich einen Atoolo\Resource\ResourceHierarchyWalker implementieren
$walker = new ResourceHierarchyWalker($resourceHierarchyLoader);
$resource = $walker
   ->filter(function ($resource) use ($anchor) {
      $resourceAnchor = $resource->getData()->getString('init.anchor');
      return $resourceAnchor === $anchor;
   })
   ->findFirst();

Walker is perhaps not quite correct here. ResourceHierarchyFinder might fit better.

Sounds great!

It is somewhat difficult to decide which providers will be necessary.

You're probably fine building only what you need right now; We can always add more settings to a Finder/Walker.
Your example looks good, just a thought I had before you start working on it:
The separation of filter and findFirst suggests a stream-like api. If we choose this approach we probably would have to solve future requirements with other such methods: anyMatches, noneMatches, sort, collect, ...
While a class like that would be a cool feature, it would also take quite a bit of effort to implement properly, avoiding unnecessary iterations. Maybe we're better of building a class that only has this one method for now:
$resource = $walker->findFirst(
    $root,
    fn($resource) => $resource->getData()->getString('init.anchor') === $anchor,
);

If we do need more this should be easy to add or refactor.

The implementation could look like this:
class ResourceHierarchyFinder
{
    public function __construct(
        private readonly ResourceLoader $resourceLoader,
        private readonly ResourceHierarchyLoader $hierarchyLoader
    ) {
    }

    public function findFirst(Resource $base, callable $fn): ?Resource
    {

        if ($fn($base) === true) {
            return $base;
        }

        $childrenLocations = $this->hierarchyLoader
            ->getChildrenLocations($base);
        foreach ($childrenLocations as $childLocation) {
            $child = $this->resourceLoader->load($childLocation);
            $result = $this->findFirst(
                $child,
                $fn
            );
            if ($result !== null) {
                return $result;
            }
        }

        return null;
    }
}

It is correct that initially only the $childrenLocations are determined and then the individual resources are loaded as required.
However, I do not like the following:

I also have to specify the ResourceLoader in the constructor, although the ResourceHierarchyLoader also has it. There could even be two different ones, unintentionally.
In my case, I only have the base location and have to load the resource from outside, which makes it more complicated for me.

I also have to specify the ResourceLoader in the constructor, although the ResourceHierarchyLoader also has it. There could even be two different ones, unintentionally.

What if a ResourceHierarchyLoader would also be a ResourceLoader? Then we would only need the one.

In my case, I only have the base location and have to load the resource from outside, which makes it more complicated for me.

If you have to construct the Finder you'll have to have access to a ResourceHieraryLoader, which you then could also use to load the Resource to use as root for the lookup:
$finder = new ResourceHierarchyFinder($resourceHierarchyLoader);

$root = $resourceHieraryLoader->load($rootLocation);

$resource = $finder->findFirst(
    $root,
    fn($resource) => $resource->getData()->getString('init.anchor') === $anchor,
);


Download FB posts for the past year

In order to have organized files — i.e., one file for each month — the script needs to be called 12 different times for each month.

[ ] December (pull in January; offset -1)
[x] November (offset -1)
[x] October (offset -2)
[x] September (offset -3)
[x] August (offset -4)
[x] July (offset -5)
[x] June (offset -6)
[x] May (offset -7)
[x] April (offset -8)
[x] March (offset -9)
[x] February (offset -10)
[x] January (offset -11)

Note, Nov-Dec 2021 was also downloaded because, to calculate the FIB index for January 2022, we need the past three months.

Completed.


Add bidi bracket support (enable LayoutNG)

As this vscode doesn't support bidi brackets. What is that? http://www.unicode.org/notes/tn39/
Sample code: "سشی (شسی)"
Actual:

Expected:

LayoutNG which is enabled in Chrome 76 will enable this for text in html, test this data:text/html;charset=utf8,"%D8%B3%D8%B4%DB%8C (%D8%B4%D8%B3%DB%8C)" (put it in address bar) when LayoutNG experiment is enabled and disabled in about:flags of Chrome (which in Chrome 76 may is default enabled) but I don't think that helps here as AFAIK monaco uses a different and internal bidi code.

can we show bidi control charactor in text editor? for easy edit words. like U+202A U+202B U+202C

This specific case works in Insiders, so it is fixed by our adoption of Electron v6.

Very interesting, this all depends on rendering whitespace or not ...

@ebraminio @alexdima I can confirm the difference between when Render Whitespace is selected or not, on both release (1.41.1) and insiders (1.42.0-insiders).
But there is another difference: when Render Whitespace is selected, the word order is swapped.

(The Unicode spec uses the convention of lowercase letters for LTR scripts and uppercase for RTL. I'm following that here. Also, the actual sequence of the characters is in alphabetical order: ABCD, even if in an RTL script it would be displayed DCBA.)
I think there are a two distinct issues here:

Paragraph direction -- VS Code has no notion of RTL at the paragraph level. Therefore, when Render Whitespace is off, neutral characters such as spaces within the RTL text take on the surrounding direction: RTL. The words thus get rendered in their proper (RTL) order:
 HGFE DCBA
 RRRRRRRRR

But neutral characters at the beginning or end of the paragraph are treated as LTR, because the paragraph end is always LTR in VS Code. (\n represents a single newline character.)
 _DCBA_\n
 LRRRRLL

Therefore (again, when Render Whitespace is off(, the brackets within the RTL text are treated as RTL (and identified as part of a bracket pair), but the brackets at the beginning or end of the paragraph are resolved to LTR.
 (HGFE (DCBA
 LRRRRRRRRRR

The same thing happens with ", as in @ebraminio 's original post:
 "DCBA) DCBA)"
 LRRRRRRRRRLL

'Render Whitespace' uses an LTR character -- I suspect that the character used for spaces in Render Whitespace is an LTR character, which ends up like this:
 "DCBA (DCBA)"
 LRRRRLLRRRRL

but this is also incorrect, because now the RTL run is split into two by the LTR space-representing character; the opening parenthesis follows suit and becomes LTR, so now it's in the same direction as the closing parenthesis. But the words are swapped, like so:
 DCBA HGFE
 RRRRLRRRR

instead of
 HGFE DCBA
 RRRRRRRRR

Bad idea on closing the issue, #65648 was its parent issue with enough 'stars', separated it to make it clear what developers should do thus the action encourages mixing the issues.

I have a bit more understanding now after my fix for #90019. LayoutNG fixes several bidi rendering issues, irrespective of what we do.
So, when using Chromium + LayoutNG, "سشی (شسی)" renders correctly without any code change on our side:

But for #88873 , we actually run VS Code with LayoutNG disabled because of https://bugs.chromium.org/p/chromium/issues/detail?id=1043471 . Thus, our current rendering is:

Thiss can be verified by removing this line: https://github.com/microsoft/vscode/blob/80cd0ee564caed53f0a7f9fe8fba5b781cbbf12d/src/main.js#L179
cc @bpasero @deepak1556

Here is the fix chromium landed for layoutNG https://chromium-review.googlesource.com/c/chromium/src/+/1837435 , we can try adopting it for non-layoutNG codepath to fix this issue.

Having filed two of the bugs linked on the patch there, that was less about bidi bracket itself but some other bracket related issue thus enabling LayoutNG in vscode should be first priority I believe.

@deepak1556 I will explore next milestone a different way to mitigate #88873 ... It would mean for us to move away from ::before, ::after pseudo elements in those editor decorations. If that works OK, then we should be fine to enable LayoutNG again. So I would like to first try that before trying to bring in the patch.

The fix will be available in upcoming stable release.


In-page links don't exist

eg. https://github.com/danger/danger.systems/blob/master/static/source/guides/getting_started.html.slim#L16
So http://danger.systems/guides/getting_started.html#creating-a-github-account-for-danger-to-use doesn't go anywhere.
Played around with this, but didn't find the "official" way of fixing it.

Yeah, I spotted this when making your guides - wanted to do some artsy work before getting back to it, but yeah, not too sure on the answer yet


Support for startOf, endOf

This would be really useful (supported from momentjs 1.7.0)
for example:
{{ date | amStartOf:'month' | amLocal }}
{{ date | amEndOf:'day' | amLocal }}

links:
http://momentjs.com/docs/#/manipulating/start-of/
http://momentjs.com/docs/#/manipulating/end-of/

:+1:

Sounds like a great idea, can you please send a PR with these filters?
Thanks!

@vikbez are you interested in sending a PR for this features?

Yes, but I'm currently quite busy, so if you want to do it, free to you or else wait a little :)
Thanks

@vikbez great, thanks! I will wait for it then :)

closed because https://github.com/urish/angular-moment/pull/203


Generate an assignment with a config file that uses a given indentation size

User Story:
As a... GatorGradle user, I want to...
generate an assignment with a config file that uses a given indentation size.
Implementation Plans:

Use Gradle's native(??) indent configuration with "lvl 2"
or
Potentially implement Spotless or something similar to fix indentation and catch improper indentation.

Relevant Resources:
diffplug/spotless

@kailaniwoodard The "indentation" user story refers to the indent header parameter of GatorGradle's configuration file, config/gatorgrader.yml.


Add test CI

We'll want to have an integration and unit test suite to validate quality between changes. Minimally we should run tests to make sure that the examples in our repo work as we expect.

Something like https://github.com/kaihendry/gptscript-test/blob/main/.github/workflows/run.yml ?

Closing this out as we now have a suite of unit, smoke, and e2e tests that run on PRs and merge to main.


Lex refactor follow-ups

There are a number of things in the lex refactor that we are skipping for now, but should come back around to soon.

[ ] string "subtype" validation, for things like handles. there already exist validation functions, regexes, and test cases in the typescript repo, we should reuse those. but need to add some lexgen hook or API for this. eg, Validate() methods on all structs? string alias types with validating constructors?
[ ] size constraints on blobs (max bytes)
[ ] size constraints on strings, both in bytes (UTF-8) and graphemes
[ ] review when to populate $type field (see below)
[ ] cleanup deprecated terms: "vote" (now "like"), repo "append" (now "commit"), ActorRef (now "ActorViewBasic" or similar)

From conversation with Devin, the times the $type field needs to be set are:

on every record type object, at the top level, with no # in the type
on every "new" style blob ($type = "blob")
on every union (enum) object sub-type, with a # indicating the variant

a bunch of this is done; or part of indigo/atproto/lexicon package PR.
@devinivy funny that we discussed the "should $type include #main" back in march! we just revisited and clarified this in the past couple weeks.


[stable/presto] Set semver version

What this PR does / why we need it:
Charts should have a semver-compatible version. This PR changes the version of presto to make it semver.
cc/ @bivas
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/lgtm


Allow Engine types other than MergeTree

Options to add ENGINE types other than MergeTree would be great.
When creating tables, if we could specify the engine type such as MergeTree, ReplacingMergeTree, ReplicatedReplacingMergeTree etc. that would be super helpful.

Thanks for the issue and PR. I'll close this one as your PR has been merged and will keep active on this repository for future issues.


add cpu qos and mv nodeslo informer to states informer

Ⅰ. Describe what this PR does
#154
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews

@zwzhang0107 can you split this into separate PRs? one for CPU QoS, and the other for states_informer.

Codecov Report

Merging #153 (ecccb4c) into main (0cf1616) will decrease coverage by 0.31%.
The diff coverage is 31.33%.

:exclamation: Current head ecccb4c differs from pull request most recent head a4e9a23. Consider uploading reports for the commit a4e9a23 to get more accurate results

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   56.89%   56.57%   -0.32%
==========================================
  Files          86       89       +3
  Lines        7887     7954      +67
==========================================
+ Hits         4487     4500      +13
- Misses       3006     3059      +53
- Partials      394      395       +1

Flag
Coverage Δ

unittests
56.57% <31.33%> (-0.32%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/koordlet/statesinformer/states_informer.go
0.00% <0.00%> (-8.22%)
:arrow_down:

pkg/util/config.go
0.00% <0.00%> (ø)

pkg/koordlet/statesinformer/states_pod.go
9.09% <9.09%> (ø)

pkg/koordlet/statesinformer/states_node.go
27.58% <27.58%> (ø)

pkg/koordlet/statesinformer/register.go
66.66% <66.66%> (ø)

pkg/koordlet/statesinformer/states_nodeslo.go
83.80% <71.60%> (ø)

pkg/koordlet/resmanager/resmanager.go
58.11% <100.00%> (+1.42%)
:arrow_up:

...slo-controller/nodemetric/nodemetric_controller.go
44.68% <0.00%> (-8.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cf1616...a4e9a23. Read the comment docs.

it's already a separation of group identity hook implement(#154), since cpu qos definition dose not include much logic

could you also fix #77 in this PR?

could you also fix #77 in this PR? Thanks

done

fixes #77

/lgtm

/approve


Start-DscConfiguration shall output in full width and not truncate output

Steps to reproduce
Configuration BasicIIS
{
    Import-DscResource -ModuleName 'PSDesiredStateConfiguration'
    node localhost {
        WindowsFeature IIS {
            Ensure = "Present"
            Name = "Web-Mgmt-Service"
        }
        WindowsFeature Init {
            Name = "Web-AppInit"
            Ensure = "Present"
            IncludeAllSubFeature = $true
        }

Expected behavior
Shall not truncate output and use full width on the screen
Actual behavior
VERBOSE: [F5D20D2AD720]: LCM:  [ End    Set      ]  [[xRemoteFile]IISadmin]  in
 1.1600 seconds.
VERBOSE: [F5D20D2AD720]: LCM:  [ End    Resource ]  [[xRemoteFile]IISadmin]
VERBOSE: [F5D20D2AD720]: LCM:  [ End    Set      ]
VERBOSE: [F5D20D2AD720]: LCM:  [ End    Set      ]    in  6.8710 seconds.
VERBOSE: Operation 'Invoke CimMethod' complete.
VERBOSE: Time taken for configuration job to complete is 10.641 seconds
--06/16/2017 10:18:11-- Starting IIS Admin installation
--06/16/2017 10:19:00-- Finished IIS Admin installation

 ---><PHONE_NUMBER>83
Removing intermediate container a131a928f4a0
Step 9/12 : COPY .\artifacts\web.config C:\Program Files\IIS Administration\1.1.1\Microsoft.IIS.Administration\web.config
 ---> 5bf3236da65d

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      5.1.15063.296
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.15063.296
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

DSC issues aren't handled by this repo and should be reported on uservoice


[v0.7.0] add email sender and webmail

Related to #748
Do not merge before #756 and #754
Email sender provide function to send plain test or html email using templates and high level functions to send specific emails as:
SendAccountVerificationEmail(to string, accountName string, token string) error
SendAccountResetPasswordEmail(to, string, accountName string, token string) error
SendAccountPasswordConfirmationEmail(to string, accountName string)
these email answers are managed by webmail module which receive the answer, execute the right appcelerator account functions and send back htrml page considering the account functions answers.
hack/amptools make -f Makefile.refactor.make cleanall install-deps
make install
make test
email design has to be validated, especially the pictures.
for theses emails, i used recommendations from:
https://postmarkapp.com/blog/password-reset-templates-best-practices
http://99rabbits.com/email-sign-up-confirmation/
https://reallygoodemails.com/category/inaugural/account/
https://reallygoodemails.com/category/password-reset/

Close, ampmail is going to be merged on account-users


Cloud or unified settings

Description of the new feature / enhancement
PowerToys has many settings and I have many computers. This is a problem.
Are there any options for cloud save/sync settings? No matter where PT is installed the settings files are located "AppData\Local\Microsoft\PowerToys".
A full-blown feature to support this would be awesome, but other solutions would work.
The simplest might be an export/import for all options.
I personally would love it to be synchronized/integrated with my Microsoft account.
Scenario when this would be used?
PowerToys has many settings and I have many computers. If I change a setting, I need to change it on many other machines. Some settings take many clicks to get to, and require a specific value.
Another reason this is an issue is that PowerToys "changes how you use Windows" and you really want that to be the same on each machine you use as easily as possible.
Supporting information
No response

Probably a duplicate of #3381 and #586

/dup https://github.com/microsoft/PowerToys/issues/3381


Reduce installer size

i know we're looking at a few things but wanted to get this documented. When comparing msix to msi, we have a bit of file size that we may be able to reduce.

looks like these could be customized

Low pri as core 3 will boost the installer size no matter what


IIIF is broken

It looks like https://github.com/openseadragon/openseadragon/pull/2059 has broken IIIF (see https://github.com/openseadragon/openseadragon/issues/1985#issuecomment-975212887). We'll want to back out that change, but we should also see if we can solve the problem that PR was trying to fix in a different way.

It looks like when I reviewed #2059, I misunderstood how getLevelScale is being used. I think we should return that function to its earlier state. In order to support the scenario that PR was intended to support, I propose we add a setMaxLevel function to TileSource, and it should trigger a fresh memoization for getLevelScale. What do you think, @kim-sanghoon ?

@iangilman Thank you for letting me know! I should have tested the PR with other types of image slides...
Based on your proposal, I added a setMaxLevel function to TileSource as https://github.com/kim-sanghoon/openseadragon/commit/de39597c141cdf9e34c8a3b94ae18af4e2db048c, and invoked the function inside the constructor so that the getLevelScale memoization could be made at the initialization time.
I tested the code with the automated unit tests and demo pages, and it seems to be working. However, I personally feel my changes could be improved in terms of code quality. I will open a PR on this issue if the code is okay to be reviewed.

@kim-sanghoon wonderful, thank you! Please do make a PR!


Clean up of the first render PR

In #14, our main goal was to get a basic render up and running. Now that we have achieved that goal, our next step is to clean up that code and give it a glow up. As such, here are some of the improvements we should make:

The Material class should probably be a struct.
https://github.com/wermos/Rendera/blob/47f65c2a2cd24293a9140b9833f4a5cd33420460/Rendera/include/material.hpp#L22-L39
As you can see here, we define these variables as private variables but then also define getters for every single private variable, meaning that we actually want them to be a part of the public API. The most reasonable way to achieve this in C++ is by defining the class as a struct, where all the members are public by default.
The image height and image width should be of type std::size_t and not int.
https://github.com/wermos/Rendera/blob/47f65c2a2cd24293a9140b9833f4a5cd33420460/Rendera/include/camera.hpp#L13-L14
Obviously, negative image height or width doesn't make sense, and for that reason we should use an unsigned type. std::size_t is one such well-defined unsigned type.
We need to figure out and improve the get_int() function.
https://github.com/wermos/Rendera/blob/47f65c2a2cd24293a9140b9833f4a5cd33420460/utilities/include/color.hpp#L28-L33
a) The comment suggests that the class should return a color consisting of 8-bit ints, but the int type is 32 bits. We need to amend this by using the std::uint8_t type. (Unsigned because the value will be in the range 0-255, inclusive).
b) We need to determine why, and if, the call to the std::max function is needed. Perhaps discussing this @Inferno2401 will help here.
In the hit function, we see the following:
https://github.com/wermos/Rendera/blob/47f65c2a2cd24293a9140b9833f4a5cd33420460/utilities/include/intersection.hpp#L26-L33
However, it is better to subscribe to a "return fast" policy. What this means is that inside the if clause (where we checked if the discriminant is non-negative or not), we should return true or false, depending on whether or not t2 is non-negative, and outside the if clause, we should return false. The reason a "return fast" policy is better than the existing implementation is because it minimizes the number of possible comparisons and branches in the code.
The Intersection class should not have getter functions for both t1 and t2, because if the ray doesn't hit the object at all, they will return garbage to the user. However, amending this problem is less of a priority because we are planning to remove this class entirely as a part of the refactoring being done in #24.

Assignee: @KartikDhawaniya

Closed as completed by #38.


Fix the expected results in doc

Small fix in the fractional and Cartesian coordinate example results. To fix this kind of future errors doctests can be added , like this doc page in flux.

@Dsantra92 Thank you!!  Yes, doctests are something we need to incorporate.  Opening an issue.


docs: Update filtering.md

This time for sure...

@richb-hanover what's up with this PR?
I didn't manage to review it yet, but I've seen at a glance that it's a big improvement.

@aljazerzen  - Thanks for the kind words. I saw that everything was changing so I decided to wait 'til the structure settled down. I will repost the three pages later today.


[ms connector] Base code for microsoft connectors

Description
Initialize MS connectors
Risk
Connectors are not visible/usable for now
Deploy Plan
Deploy front and connectors

What's the update on framing here? Did I miss it? Otherwise not very useful to review yet no?

Last comment: can't see the "Preview" button from the connectors' list yet. Is that for a follwoing pr?

Last comment: can't see the "Preview" button from the connectors' list yet. Is that for a follwoing pr?

It was hidden so far, but now in preview (and can be enabled by activating the feature-flag)


Add batch delete support for azblob

let me take a look.

I found no official RESTful batch delete API provided by Azure Storage Blobs. Even their CLI tool implements it by deleting sequentially.
The question is, if we meet with failure during batch deletion, should previously delete files (in the batch) be resumed? This can make our batch deletion atomic.

I found no official RESTful batch delete API provided by Azure Storage Blobs. Even their CLI tool implements it by deleting sequentially.
The question is, if we meet with failure during batch deletion, should previously delete files (in the batch) be resumed? This can make our batch deletion atomic.

After investigating implementation of S3, errors will be tolerated and kept in the returned value.


Throwing last torch in a stack of Throwables Torches crashes the game (1.20.1)

Happens on both single-player and server. On the server, only the client crashes.
FABRIC API Version 0.90.7+1.20.1
FABRIC Loader Version 0.14.24
Throwable Torches Version 1.20.1-1
Minecraft Version 1.20.1
To replicate, load up Minecraft and either craft or give yourself any kind of throwable torch. Throw each torch in the stack, and upon throwing the last torch, the game will crash and close.
Crash log for single-player instance included.
crash-2023-12-04_11.27.32-client.txt

The mod has been updated to 1.21.3. Could you confirm is that still happens ?


About the condition OptionalFragmentList.Num() > 0 inside ForEachEntityChunk

First, I want to thank you for this great demo. I'm learning a lot from it.
When I was reading README.md, I noticed there's a code snippet like this:
MyQuery.ForEachEntityChunk(EntitySubsystem, Context, [](FMassExecutionContext& Context)
{
	const auto OptionalFragmentList = Context.GetMutableFragmentView<FMyOptionalFragment>();
	const auto HorseFragmentList = Context.GetMutableFragmentView<FHorseFragment>();
	const auto SheepFragmentList = Context.GetMutableFragmentView<FSheepFragment>();
	for (int32 i = 0; i < Context.GetNumEntities(); ++i)
	{
		// An optional fragment array is present in our current chunk if the OptionalFragmentList isn't empty
		if(OptionalFragmentList.Num() > 0)
		{
			// Now that we know it is safe to do so, we can compute
			OptionalFragmentList[i].DoOptionalStuff();
		}

		// Same with fragments marked with Any
		if(HorseFragmentList.Num() > 0)
		{
			HorseFragmentList[i].DoHorseStuff();
		}
		if(SheepFragmentList.Num() > 0)
		{
			SheepFragmentList[i].DoSheepStuff();
		}
	}
});

I was thinking, say, if we have a chunk of 5 entities, and 3 of them has the optional fragment. When we loop i from 0 to 5-1,  we will have time when i==4 when we face the if condition if(OptionalFragmentList.Num() > 0), and since we have 3 entities with optional fragment, this will be 3>0, and we will execute OptionalFragmentList[i].DoOptionalStuff();. But OptionalFragmentList only has 3 members, so OptionalFragmentList [4] would cause error.

Each chunk we iterate on can only be one kind of archetype, so checking for the presence at all like this is okay. I suppose it would be smarter to check before we enter the loop instead of every entity. :P


Initial boilerplate for telemetry

Pull Request check list

[ ] Proper tests/regressions included?
[ ] Documentation updated?

Affected functionality
Monitoring
Description of change
Add dockerfile for Prometheus usage with an initial metric server
Which issue this PR fixes

Just waiting on the merge conflict to be resolved to approve 🍰


[CHORE] Create banners for Dropstab Test campaign

Dropstab Banner requirements:

Top Banner

Logo 1:1 atleast 64x64 px
Headline up to 20 characters
Body text up to 60 characters
link

Bottom Banner

Logo 1:1 - atleast 80x80 px
Headline up to 30 characters
Body text up to 60 characters
CTA Button text up to 15 characters
link

Closing as shipped.


JoltGeneric6DOFJoint3D angular limit gizmo not correct

while playing around with this addon, which I really like, I figured there is a small issue with the Jolt-version of the 6DOF joints.
The short version: The angular limit gizmos only show the actual limits correctly if the joint itself is rotated by 90 degrees.

steps to reproduce:
should be obvious, have a static body  and a rigid body connected by a Jolt 6DOF joint, set an angular limit that's relatively narrow to see the effect AND the gizmo, add a camera and run the scene  to see the angular limit is not solved as previewed by the gizmo.
minimal project to reproduce:
jolt_gizmo_minimal.zip
Godot-Jolt version: 0.12.
Godot version: 4.2.1 stable

Thank you for reporting this. This has been in the back of my mind for a while now, but I never got around to it.
I've spent a silly amount of time trying to make sense of these joint gizmos, ever since I first implemented them, which I realize in hindsight was largely a result of me getting tripped up by the way that single-body joints work in Godot Physics, which I for some reason felt the need to accommodate for (over two-body joints).
With this behavior having changed in #725 I should rightfully have changed the gizmo accordingly, but forgot to.
Anyway, this should be fixed when #862 is merged. It now seems to line up nicely with Jolt's own debug visualization, as well as Nvidia Omniverse, which happens to use a very similar visualization in its USD Composer editor.

extremely cool and swift execution. nicely done.

just compiled the master - is this the intended display of the gizmos?

i.e. intuitively I would expect the gizmo to show the range of limits in the direction of the effect, but now it looks like its showing it on the opposite side.

might be an issue with negative values - I just checked and it looks good with limits above 0°

Would you mind sharing the scene? It's hard to tell from the screenshots how you've set it up. It seemed to make sense in the scene I tried it with.

you get the same issue with the minimal project up above. The underlying problem seems to be with where 0° starts? I phrased this as having to rotate the joint by 90° but then you fix only one axis and it gets messy when you need more than one axis limited.As you just changed the sign in your calculation i don't think that fixed it. I will see if I can suggest a fix on my own over then weekend.Am 23.05.2024 21:36 schrieb Mikael Hermansson @.***>:
Would you mind sharing the scene/project? It's hard to tell from the screenshots how you've set it up. It seemed to make sense in the scene I tried it with.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

I'm pretty sure all we need is to add or substract half PI from the gizmo angle when calculating the points for it. However while trying this I don't see any effect on the gizmo drawing at all. I must be missing something crucial about the whole plugin build.

sorry, bit pressed for time so I'll be sloppy.
basically you need to revert your change from #862, it's doing the wrong thing
instead line 83 in the jolt joint gizmo .cpp should be something like const float angle = p_limit_lower + angle_step * (float)p_index  - Mathf_PI / 2.0;
I also now noticed that the limits must be in range -180° to 180°, which propably follows naturally. It's just the UI doesn't limit this and maybe should.

see suggested fix in #872

Yes, sorry, I saw it. I've been somewhat strapped for time when it comes to this extension in general lately, and this ended up pretty far down on my priority list when you in the PR mentioned that it wasn't a complete solution.
 The fact that I deviated to begin with was somewhat questionable, given that the substitute joints are largely meant to just augment the functionality of the built-in ones. I figure if someone wants it to be different it should rightfully be fixed in Godot itself as well in any case.
Thank you for the PR though. I'll see what I end up doing about this. I'll go ahead and close your PR for now though.

With this extension now having been merged into Godot in the form of an engine module (see README), this extension will be considered to be in maintenance mode going forward, where only bug fixes will be considered for merging.
While this issue could still be considered a bug, it's highly unlikely that I'll spend any time addressing this, so I'll go ahead and close this as wontfix.


SHOW PARTITIONS statement

Documentation for new SHOW PARTITIONS SQL statement:

SHOW PARTITIONS SQL statement page and diagram
SQL statement TOC and table entry
SHOW PARTITIONS example in partitioning page; partitioning page cleaned up
SHOW PARTITIONS step added to geo-partitioning demo pages (docs and training)
Geo-partitioning demo (training) now uses cockroach workload

This change is

@jseldess
As you can see, the show-partitions.md file should have a "Setup" section under "Examples". This will be an include file called movr-statements-nodes.md. That file is a new file, and part of #5221.
This is all 19.2 stuff though, so no rush.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0ee823645dd7652f454e0b53224058249528e839/
Edited pages:

v19.2/configure-replication-zones.md
v19.2/demo-geo-partitioning.md
v19.2/partition-by.md
v19.2/partitioning.md
v19.2/show-partitions.md
v19.2/sql-statements.md
v19.2/training/geo-partitioning.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3ad27eaf8b1692dc565a5158a67c0d0085ccc1d5/
Edited pages:

v19.2/configure-replication-zones.md
v19.2/demo-geo-partitioning.md
v19.2/partition-by.md
v19.2/partitioning.md
v19.2/show-partitions.md
v19.2/sql-statements.md
v19.2/training/geo-partitioning.md

@jseldess Please review my latest changes (see Reviewable for comments).

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/8074c1d12a2e639960600abcd1705b3c8f1a0f07/
Edited pages:

v19.2/configure-replication-zones.md
v19.2/demo-geo-partitioning.md
v19.2/partition-by.md
v19.2/partitioning.md
v19.2/show-partitions.md
v19.2/sql-statements.md
v19.2/training/geo-partitioning.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c35d2dd0959adbb0e03d93d1fb3220ac1b0d3c32/
Edited pages:

v19.2/configure-replication-zones.md
v19.2/demo-geo-partitioning.md
v19.2/partition-by.md
v19.2/partitioning.md
v19.2/show-partitions.md
v19.2/sql-statements.md
v19.2/training/geo-partitioning.md

@jseldess This is ready to be reviewed again.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/934b8677367c07aa3ebf32f5b171fb7dcbc86e9a/
Edited pages:

v19.2/configure-replication-zones.md
v19.2/demo-geo-partitioning.md
v19.2/partition-by.md
v19.2/partitioning.md
v19.2/show-partitions.md
v19.2/sql-statements.md
v19.2/training/geo-partitioning.md


Relax aeson and bytestring constraints for GHC version 9.2.5

I have done this, note however the following warning:
    The field ‘program’ belonging to type ExecuteParams is ambiguous.     This will not be supported by -XDuplicateRecordFields in future releases of GHC.     You can use explicit case analysis to resolve the ambiguity.


starting the bot

how can i run the bot after writing the code? i did python3 main.py but bot is not working.

This is the error please help


Adjust Reaper readme to accomodate new workflow

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#225
#224  👈
#223
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rbro112 and the rest of your teammates on  Graphite


Ignoring existing ALBs

Hi,
we are currently running a Kubernetes trial in one of our AWS accounts. There are also other resources around that do not belong to the Kubernetes cluster. For example two ALBs. We wanted to utilise the alb-ingress-controller, but it seems that it can not just ignore existing ALBs in an account.
It starts up and complains about missing tags on the existing ALBs. Is there any way to ignore them?
alb-ingress-controller: 1.0-alpha.5
Kubernetes: 1.8
Regards
hrzbrg

Hi @hrzbrg
Can you paste the logs here? Thanks in advanced.

I1023 14:50:44.009392       1 main.go:24] [ALB-INGRESS] [controller] [INFO]: Log level read as "", defaulting to INFO. To change, set LOG_LEVEL environment variable to WARN, ERROR, or DEBUG.
I1023 14:50:44.009578       1 launch.go:112] &{ALB Ingress Controller 1.0.0 git-00000000 git://github.com/coreos/alb-ingress-controller}
I1023 14:50:44.009607       1 launch.go:115] Watching for ingress class: alb
I1023 14:50:44.009801       1 launch.go:282] Creating API client for https://<IP_ADDRESS>:443
I1023 14:50:44.019238       1 launch.go:295] Running in Kubernetes Cluster version v1.8 (v1.8.0) - git (clean) commit 6e937839ac04a38cac63e6a7a306c5d035fe7b0a - platform linux/amd64
I1023 14:50:44.020946       1 launch.go:134] validated util/alb-ingress-controller-default-backend as the default backend
I1023 14:50:44.025698       1 alb-controller.go:79] [ALB-INGRESS] [controller] [INFO]: Ingress class set to alb
I1023 14:50:44.025715       1 albingresses.go:85] [ALB-INGRESS] [ingresses] [INFO]: Build up list of existing ingresses
F1023 14:50:44.172854       1 albingresses.go:142] [ALB-INGRESS] [ingresses] [ERROR]: The LoadBalancer sandbox-gatewayservice-lrr-lb does not have an IngressName tag, can't import

After that the container goes into CrashLoopBackOff

F1023 14:50:44.172854       1 albingresses.go:142] [ALB-INGRESS] [ingresses] [ERROR]: The LoadBalancer sandbox-gatewayservice-lrr-lb does not have an IngressName tag, can't import

Is expected. It's the controller's way of saying it won't attempt to manage that ALB.
We'll change this error message to be INFO level and make the message sound less like an error.
However, the CrashLoopBackOff shouldn't happen subsequently. Could you paste the full logs so I can see exactly where the panic occurs?

@hrzbrg - My mistake, I see where this is stopping the controller now.
I'll knock it out in short order. Thanks for the report.

Awesome, thanks. I almost thought I am crazy, because I did not find anything wrong on my side.

The query for what ALBs the controller should attempt to manage is done based on assuming the prefix of the ALB name will be what you set in the CLUSTER_NAME for the controller.
In your case, I presume, this was set to sandbox. So in your specific environment, this is the source of the conflict.
The ALB controller then incorrectly assumes it should manage it and in order to do so looks for the IngressName and Namesapce tags in AWS.
If you'd like to try the following build, I've patched it with a fix.
quay.io/coreos/alb-ingress-controller:1.0-alpha.5.1

Perfect, thank you so much for the quick fix. Just deployed it and it works.

Sorry, I gotta reopen this issue. I currently have two Clusters in two different AWS Accounts. The setup is basically the same, however one AWS account has existing ALBs.
On this account the Ingress Controller just hangs with the last log line being
I1112 11:16:22.838086       1 albingresses.go:86] [ALB-INGRESS] [ingresses] [INFO]: Build up list of existing ingresses

I already tried using another CLUSTER_NAME, but it still hangs. When I launch the same ALB Ingress Controller setup in the account without existing ALBs, it works as expected.
ALB Ingress Controller: 1.0-alpha.5.1
K8S Version: 1.8.0

Hanging when building the list of existing ingresses is a different issue and is generally related to AWS APIs not responding or being throttled. If this is still an issue please open a new ticket. Thanks!


Add a link to a video about installation and configuration of kiosk-mode

This pull request adds a video to the README about the installation and configuration of kiosk-mode to help those that are not used to yaml code.

great addition


Issue 1006: POC for providing mechanism to allow context contributors

Changes in this PR
Initial POC implementation to add new feature as described in #1006 -- provide a mechanism to be able to register context contributors
-- Need to complete reactive implementation
-- Is there value to provide access to other information in the GraphQLContextContributor.contribute signature to things such as query, variables and operationName?
Issue #1006

I am wondering if we should invoke the context contributors when we know the query is valid. I.e an instrumentation will invoke the contributors when query validation has passed.

I am wondering if we should invoke the context contributors when we know the query is valid. I.e an instrumentation will invoke the contributors when query validation has passed.

Query parsing consults the context for ParsingOptions.
One could anticipate that a GraphQLContext contributor may want to set parser options based on headers/caller/etc....
See: https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/ParseAndValidate.java#L58-L62

The more I look at this the more I think we could implement the context contributors as part of an Instrumentation and not as part of the DgsQueryExecutor.  The Instrumentation could be created such that it gets a ObjectProvider of contributors and builds an ordered representation of such contributors via the ObjectProvider's orderedStream API. The contributors can then use the @Ordered annotations to express an order of precedence. I still think that we should invoke the contributors after validation of the query has passed. If we need to change the Query Parser Options I would rather have a specific mechanism to override those, instead of doing it implicitly by a context contributor.

@berngp - How do you recommend we make available the WebRequest/ServerRequest to said Instrumentation to then be able to be sent into any context contributors?
The primary use case that drove me to develop this capability was so that the context contributor(s) can have access to the headers on the request and based on the existance or value, be able to set something on the GraphQLContext.

By the time the first instrumentation is being called the 'DgsContext' is already available vie the Instrumentation Environment. We could extract it from there, will get a poc. This will suggest that if we implement this feature via Instrumentations, we need to ensure the one that calls the context contributors executes before the others.

@berngp  -- I've done as you suggested in https://github.com/Netflix/dgs-framework/pull/1145 Please take a look and verify you still feel that is a better direction to move towards, and if so, I'll close this PR in favor of that one.

By the time the first instrumentation is being called the 'DgsContext' is already available vie the Instrumentation Environment. We could extract it from there, will get a poc. This will suggest that if we implement this feature via Instrumentations, we need to ensure the one that calls the context contributors executes before the others.


[N01] addStorageRoot can add duplicate URLs

addStorageRoot can add duplicate url's
In PR #8360, the addStorageRoot function of the Accounts contract adds url's to an offchainStorageRoots array for the msg.sender's account.
This function does not check whether the url already exists in the array so there can be duplicate entries added.
This does not pose a security risk. However, it can result in unnecessary gas expenditure. Furthermore the resulting redundant data returned by the getOffchainStorageRoots function can confuse offchain clients and add computational complexity to the processing of this data.
Consider using OpenZeppelin's EnumerableMap as a more practical solution than an array.
Part of the OpenZeppelin Release 6 Audit: @georgercarder @clarkhenry

These duplicates can be checked for on the client side easily, both as a check before adding a duplicate or as a filter on the returned storage roots. To avoid complicating and inflating the cost of the storage root logic, we will not make a change to address this at this time.


[Integration Test] Ensure that startTime is reset when jobs are stopped

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I added a test case to ensure that startTime is reset when jobs are stopped, as discussed in https://github.com/kubernetes-sigs/kueue/pull/797#issuecomment-1560048273 with @alculquicondor.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

I should add an ensuring that startTime isn't nil after jobs are stopped.

This PR is ready. PTAL
/hold cancel
/assign @alculquicondor

/assign @trasc
for first pass

/hold
This depends on kubernetes-sigs/jobset#181

/hold cancel

@alculquicondor @trasc I have addressed your comments. PTAL.

/lgtm


Include Bruno's comments into the definition

Taking @b_around's comments...
          Sharing some ideas that I think should be in our definition of modernization which probably should be split into two parts – what we understand as modernization and how we will address modernization

OUR PERCEPTION OF MODERNIZATION CONTEXT
•	Modernization is about enabling continuous evolution of business operations (products, services, process) in line with a company mission and customer needs
•	Modernization is enabled by technology changes (apps, data, platforms, infrastructure, Dev & Ops tooling) and organizational changes (structure, culture, ways of working, alignment of priorities)
•	Mainframe platforms typically support business critical operations and due to its historical criticality and longevity, not always have been through holistic or consistent approaches to modernization
•	The above sometimes leads to an incorrect view that the only option for modernizing areas that depend on mainframe is the replacement of the platform
OUR WE WILL ADDRESS MODERNIZATION DEFINITION AND OUR BOUNDARIES
•	The OMP Working Group aims to provide a clear articulation of options, principles and patterns for mainframe platforms modernization in the form of a framework that guides the modernization of technology components and organizational practices around mainframes
•	The framework considers business needs, business value & ROI, execution risks & trade-offs, technology options & organizational impact
•	The framework is not tied to specific mainframe platforms, vendor technologies, tools, or target states and rather focus on the approach, execution process and required capabilities
•	Because organizational context matters and "one-size fits all" approaches don’t exist, thus the framework, parameters and considerations should always be adjusted to a company reality
Originally posted by @b-around in https://github.com/openmainframeproject/wg-modernization/issues/6#issuecomment-1551547088

Pull request created - think we can close this issue and manage any iterations of the definition directly on pull requests

Hello @ijmitch , should I update the modernization-definition.md file with the following content:
Modernization is about achieving continuous evolution of the business (products, services, process) in line with the company mission and customer needs. This journey is enabled by technology changes (apps, data, platforms, infrastructure, Dev & Ops tooling) and people and culture changes (organizational structure changes, culture, ways of working, alignment of priorities).
Because of the way business, technology and people are interconnected, modernization does need to holistically look at these all perspectives to truly achieve its goals and deliver business value.
Mainframes typically support business critical operations and due to its historical criticality and longevity, not always have been through holistic or consistent approaches to modernization. A common pitfall this leads to is a biased view that the only option for modernizing capabilities that depend on mainframes, is the replacement of such platforms.
The OMP Working Group aims to provide a clear articulation of options, principles and patterns for modernization in the mainframe context, delivering a framework that guides the modernization of technology components and organizational practices.
This framework considers business needs, business value & ROI, execution risks & trade-offs, technology options & organizational impact. The framework is not tied to specific mainframe technologies, vendors, tools, or target states and rather focus on the approach, execution process and required capabilities.
Because organizational context matters and "one-size fits all" approaches don’t exist, the proposed framework, parameters and considerations should always be adjusted to a company reality.


Setting "repositoryMethod" on "referenceMany" breaks persistence

Good day everyone,
I have stumbled across this issue and was wondering whether I have encountered a weird edge case / a bug or a feature:
When I set a custom repository Method on a reference many field in order to populate the hydrated collection everything works as expected.
However when I then modify that collection like this (pseudo code):
$newReferencedObject = new Object();
$dm->persist($newReferencedObject);
$hydratedDocument->getField()->add($newReferencedObject);
$dm->flush();

The new object is persisted, but the collection not updated. Everything seemed to work perfectly fine, until I introduced the "repositoryMethod" setting.
Any idea why that would happen ?

I'm not sure, since I'm not ODM expert, but you might be running into a case where change tracking fails on object return from getField(). A similar case can be sometimes observed in ORM, when you try to update a DateTime instance and changes are not reflected during flush(), since it is still the same DateTime object and by default - as much as I'm aware - Doctrine just compares if it is still the same instance of the object.
See http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/change-tracking-policies.html.
However, I might be completely wrong on this ;)

IIRC using the repositoryMethed marks collection as the inverse side thus no changes are saved to the collection itself (even it's existance in db should be ignored)


I need a python function that converts a docx document to markdown and an python functions that converts a markdown file to docx.
git-bob think about this

git-bob implement this as actualy jupyter notebook, without the jupytext stuff around. Use the file "test.docx" as example input and save the result as "test.md".

For the record: I implemented this without pandoc, and without reusing pre-existing libs to have a permissively licensed, python-only implementation for simple docx files: https://github.com/haesleinhuepf/docx2markdown/


I can not use a web app core with Windows container support. It works with Linux Container

I am trying to run a demo following the instructions from this page:
https://docs.microsoft.com/en-us/visualstudio/containers/hosting-web-apps-in-docker?view=vs-2019&viewFallbackFrom=aspnetcore-5.0
I ran the image in my local machine and worked fine, but when I am trying to publish it to Azure, I got:
Gravedad Código Descripción Proyecto Archivo Línea Estado suprimido
Error No se pudo ejecutar el comando de Docker. Código de salida: 1.
The command 'cmd /S /C dotnet restore "DockerAppPrueba/DockerAppPrueba.csproj"' returned a non-zero code: 1 DockerAppPrueba C:\Users\usuario\source\repos\DockerAppPrueba\DockerAppPrueba\Dockerfile 0
This is my docker file:
#See https://aka.ms/containerfastmode to understand how Visual Studio uses this Dockerfile to build your images for faster debugging.
#Depending on the operating system of the host machines(s) that will build or run the containers, the image specified in the FROM statement may need to be changed.
#For more information, please see https://aka.ms/containercompat
FROM mcr.microsoft.com/dotnet/core/aspnet:3.1-nanoserver-1903 AS base
WORKDIR /app
EXPOSE 80
EXPOSE 443
FROM mcr.microsoft.com/dotnet/core/sdk:3.1-nanoserver-1903 AS build
WORKDIR /src
COPY ["DockerAppPrueba/DockerAppPrueba.csproj", "DockerAppPrueba/"]
RUN dotnet restore "DockerAppPrueba/DockerAppPrueba.csproj"
COPY . .
WORKDIR "/src/DockerAppPrueba"
RUN dotnet build "DockerAppPrueba.csproj" -c Release -o /app/build
FROM build AS publish
RUN dotnet publish "DockerAppPrueba.csproj" -c Release -o /app/publish
FROM base AS final
WORKDIR /app
COPY --from=publish /app/publish .
ENTRYPOINT ["dotnet", "DockerAppPrueba.dll"]
This is the publication:

I am using this versión of Visual Studio 2019. I am create a new default web core app with Windows Container support

When using App Service, you need to use a Windows Server 2019 (or 2016) container image. Since you're using a SAC release (1903) this will fail. We'll close this for now as this is related to Azure App Service.

When using App Service, you need to use a Windows Server 2019 (or 2016) container image. Since you're using a SAC release (1903) this will fail. We'll close this for now as this is related to Azure App Service.


Merge with zf1s

Merge efforts with zf1s project:

https://github.com/zf1s/zf1

it's code lives in monorepo:

https://github.com/zf1s/zf1

but also code is split to sub-packages to benefit composer install of needed components only.
x-ref:

https://github.com/zf1s/zf1/issues/25

I don't plan on doing some large merge at any point. If there are any important changes on zf1s that you feel are missing from this repo though please feel free to make a pull request

Port needed to this repo:

https://github.com/zf1s/zf1/pull/26#issuecomment-700843265

Port needed to this repo:

https://github.com/zf1s/zf1/pull/27#issuecomment-702554375

@glensc you know what you're doing so I've invited you as a contributor

@Shardj thanks, but I'm only interested in improving zf1s side due to its package split and composer support and retaining support for legacy PHP versions and only providing continued support, not change/improve things.
However,
I'll keep providing two-way feedback on issues arising in zf1s project unless you tell me to stop.
Aside, would be nice to have opposite tracking too, or I'll just subscribe to this project updates.

You can cherry-pick the commits from zf1s with something like this:

go to PR page: https://github.com/zf1s/zf1/pull/39
append .patch to the URL: https://github.com/zf1s/zf1/pull/39.patch
download that locally: wget https://github.com/zf1s/zf1/pull/39.patch
apply with git am: git am 39.patch
git push, git, branch, etc

@glensc thanks that's very helpful

Doesn't seem to be working for me as the patch always fails, even after I fix the file paths. I'll just manually do this

Ah it seems that for that particular patch we already fixed this code a while back

ah, git am may not work if the project file layout is totally different. but you can use git commit --author 'XXX<EMAIL_ADDRESS>--date 'some timestamp' to preserve author and commit date.

cherry-picking zf1s -> zf1-future is much easier when adding zf1s as remove, git is able to understand path renames.
example:
git remote add zf1s ../zf1s
git cherry-pick 232e616b8a3b4d278151f4d12214d3f5c43cc31b

later can manually compare both diffs:
git show 232e616b8a3b4d278151f4d12214d3f5c43cc31b > 1.patch
git show > 2.patch
diff 1.patch 2.patch

Carried 2022:

https://github.com/Shardj/zf1-future/pull/265


Add labels at the top to better represent which tab is currently selected

…cted

Codecov Report

Merging #103 (cb15693) into master (b844945) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #103      +/-   ##
============================================
- Coverage     66.11%   66.06%   -0.05%
  Complexity      407      407
============================================
  Files            80       80
  Lines          1378     1379       +1
  Branches        136      136
============================================
  Hits            911      911
- Misses          433      434       +1
  Partials         34       34

Impacted Files
Coverage Δ

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/TabMenu.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b844945...cb15693. Read the comment docs.


fullscreen can't advance past to first load

if the minRowsAtStart parameter is not set to a bigg value (at least the total number of pictures) if you switch to fullscreen view before reaching the end of the page, you can only advance to the last already loaded picture (before switching to fullscreen).
Step to reproduce :
1/ go to your demo page : https://ecodev.ch/natural-gallery/demo/ it says for example 9/80 pictures
2/ clic on the first picture to switch to fullscreen, on the top left you can read 1/9
3/ advance to the 9th picture for example using the arrows, try to go to the 10th picture, it comes back to the first one.
A way to get around is to set the minRowsAtStart parameter to 9999 for example, this way all the thumbnails are loaded right from the beginning... it solves the problem at the expense of bandwidth...

Hi, thx for your report. I could reproduce.
A recent change seems to have broken the pagination when navigating in the lightbox. I'll check it.

Issue fixed and will be published on next release, that will be a major version. If you really need this fixed asap, you can already use master branch. Refer to sandbox/index.html. Demo is not updated yet.

I reopen the bug because I discovered something that seems still related to the lazy loading number...
on an iPad (2018, iOS 12, Safari), when I use the lazyloading, for example set to 20 pictures, there are problems to load all the pictures when I scroll down. If y set the parameter to something like 2000 (I have around 500-1500 pictures to load) there are no problems.


Rclone wont mount windows 10

What is the problem you are having with rclone?
rclone wont mount on windows
What is your rclone version (eg output from rclone -V)
C:\Users\herohamp\Documents\commands>rclone -V
rclone v1.40

os/arch: windows/amd64
go version: go1.10

Which OS you are using and how many bits (eg Windows 7, 64 bit)
Windows 10 64 Bit
Which cloud storage system are you using? (eg Google Drive)
Google Drive
The command you were trying to run (eg rclone copy /tmp remote:tmp)
rclone mount music: M: -vv
A log from the command with the -vv flag (eg output from rclone -vv copy /tmp remote:tmp)
C:\Users\herohamp\Documents\commands>rclone mount music: M: -vv
2018/04/15 15:43:12 DEBUG : rclone: Version "v1.40" starting with parameters ["rclone" "mount" "music:" "M:" "-vv"]
2018/04/15 15:43:12 DEBUG : Using config file from "C:\Users\herohamp\.config\rclone\rclone.conf"
2018/04/15 15:43:12 INFO  : Google drive root '': Modify window is 1ms
2018/04/15 15:43:12 DEBUG : Google drive root '': Mounting on "M:"
2018/04/15 15:43:12 DEBUG : vfs cache root is "C:\Users\herohamp\AppData\Local\rclone\vfs\music"
2018/04/15 15:43:12 DEBUG : Adding path "vfs/forget" to remote control registry
2018/04/15 15:43:12 DEBUG : Google drive root '': Mounting with options: ["-o" "fsname=music:" "-o" "subtype=rclone" "-o" "max_readahead=131072" "-o" "attr_timeout=0" "-o" "atomic_o_trunc" "-o" "uid=-1" "-o" "gid=-1" "--FileSystemName=rclone"]
panic: cgofuse: cannot find winfsp
goroutine 20 [running]:
github.com/ncw/rclone/vendor/github.com/billziss-gh/cgofuse/fuse.(*FileSystemHost).Mount(0xc0422b4ed0, 0xc0420280d0, 0x2, 0xc04230a500, 0xf, 0x14, 0x0)
C:/gopath/src/github.com/ncw/rclone/vendor/github.com/billziss-gh/cgofuse/fuse/host.go:1131 +0x4fa
github.com/ncw/rclone/cmd/cmount.mount.func1(0xc0422b4ed0, 0xc0420280d0, 0x2, 0xc04230a500, 0xf, 0x14, 0x10739c0, 0xc0423a0000, 0xc0422b2660)
C:/gopath/src/github.com/ncw/rclone/cmd/cmount/mount.go:142 +0x71
created by github.com/ncw/rclone/cmd/cmount.mount
C:/gopath/src/github.com/ncw/rclone/cmd/cmount/mount.go:140 +0x3d4

This is the relevant line from the log panic: cgofuse: cannot find winfsp
So it looks like you need to install (or reinstall) WinFSP.

i've installed winFSP and i'm still receiving this error

i've installed winFSP and i'm still receiving this error

Can you post the log and traceback you get?

Hello，i've installed winFSP and i'm still receiving this error。
2023/09/12 20:19:07 NOTICE: Serving remote control on http://<IP_ADDRESS>:19090/
2023/09/12 20:19:09 Fatal error: failed to mount FUSE fs: mount stopped before calling Init: mount failed: cgofuse: cannot find winfsp
I dont know how to handle it.

@beirenwuze please post on the rclone forum about this - thanks!


How Many Numbers Are Smaller Than the Current Number[Leetcode]

https://leetcode.com/problems/how-many-numbers-are-smaller-than-the-current-number/
Given the array nums, for each nums[i] find out how many numbers in the array are smaller than it. That is, for each nums[i] you have to count the number of valid j's such that j != i and nums[j] < nums[i].
Return the answer in an array.

Put it into the Leetcode problems package under the array


[WIP] Finish repository transfer

This includes the following changes:

update the product bundle identifier (de.rheinfabrik.Dobby to com.trivago.Dobby);
update the organization name (B264 GmbH to trivago GmbH);
update the copyright holder (B264 GmbH to trivago GmbH); and
update the pod spec (Author?, Social Media URL?, Homepage, Git Repository URL)

as discussed in #31.
@tibr please verify all the changes are correct after the remaining fields of the pod spec have been updated accordingly.

we have to clarify author and social media url with @andygrunwald who is currently on vacation. besides that thanks for the pr 👍 .

Will Be back at the Weekend / starting next week. But feel free to drop me
a mail or a comment here with all information you need.
Am Montag, 12. September 2016 schrieb Susann Proszak :

we have to clarify author and social media url with @andygrunwald
https://github.com/andygrunwald who is currently on vacation. besides
that thanks for the pr 👍 .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/trivago/Dobby/pull/33#issuecomment-246355026, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATiQKM2mpqan_zViytWF9gQRMGCT6yEks5qpVoigaJpZM4J475L
.

To reinvigorate the discussion here:
Hey @andygrunwald! This is the information that we need to complete the repository transfer:
author: This one is currently 'Rheinfabrik' =><EMAIL_ADDRESS>We could stick with the company name. Then we would need a fitting trivago mail to place here. I think I would also be fine to just use one of our personal addresses if a trivago one does not exist or would be hard to maintain.
social_media_url: I would guess we put https://twitter.com/trivago_tech in here?
Thanks for your help!

Sorry @felixjendrusch
I was on a trip again. I talked with @SusannProszak in between and we created<EMAIL_ADDRESS>Hope this works :)
Thanks for your effort.


Made tf.abs underflow-safe on CPU & GPU and added test for it.

Description

Fixes part of #895. The CPU backend now uses Math.hypot and the WebGL backend uses length albeit with some workaround to ensure underflow-safety (which is otherwise not given, at least on Intel GPUs).

For repository owners only:
Please remember to apply all applicable tags to your pull request.
Tags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY
For more info see: https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md

This change is

Done, hope I didn't forget anything.

eps² will not underflow, but I tried to improvise...

Hm, I know what the issue is (we're uploading this as a uniform) so I'll merge this change and then fix it :)

Really nice work!

Thank You!
What issue are You referring to? The 0/0 was in complex_abs_gpu and I hope I fixed it. My other statement about eps² generally not rounding down to zero is not a bug. What would be necessary is another constant like ENV.get('MIN_VALUE') to determine a value that close to underflow.


Fix failing tests and improve test error reporting

I am investigating recent test failures from a timeout error while waiting for the DataJoint server to start

The latest version of sortingview requires a running kachery daemon and a registered account on kacheryhub. The current test suite does not use sortingview. While we could run that relatively easily, it does not really seem appropriate to clutter the kachery network with temporary nodes and accounts used solely for testing the nwb_datajoint package. @jsoules what are your thoughts on doing this? Would that be all right or is there a different preferred way? For now, in this PR, I have removed importing sortingview, but we may need it in the future.

@rly Well, it depends what the test is trying to achieve. If you're looking for a full integration test, it might be appropriate to have some fixed test credentials that you use for pre-release testing or something like that. But I agree that it's best not to clutter the kachery network with this on a regular basis, and more importantly you probably don't want your tests failing on a regular basis on that account anyway. (@magland, would you agree?)
How extensive is the sortingview integration that's impacting on nwb_datajoint? Is this something where the sortingview component could be mocked for the purposes of your unit tests? (e.g. https://stackoverflow.com/questions/8658043/how-to-mock-an-import)?

@magland Yes, import sortingview without a running kachery daemon results in the error:
~/anaconda3/envs/nwb_datajoint/lib/python3.8/site-packages/kachery_client/_daemon_connection.py in _read_client_auth_code()
33 p = f'{ksd}/client-auth'
34 if not os.path.isfile(p):
---> 35 raise Exception(f'Unable to find client auth file (perhaps daemon is not running): {p}')
36 try:
37 with open(p, 'r') as f:

Exception: Unable to find client auth file (perhaps daemon is not running): None/client-auth


Unpublish truqu/elm-oauth2.0 due to bad name

Hi, I just published a package under truqu/elm-oauth2.0. However, I had to rename it to get rid of the 2.0 which was causing an issue with the generated code. All functions in JavaScript get prefixed with
_truqu$elm_oauth2.0$ which is not a valid JavaScript identifier. Getting rid of the .0 solves the issue though I believe elm package publish shouldn't allow the publication in the first place?
Anyway, now, there are 2 packages with same sources but almost identical names. Since it is not possible to unpublish a package, may I ask a manual operation to unpublish:
http://package.elm-lang.org/packages/truqu/elm-oauth2.0/latest
Thanks.

Hi!  Evan occasionally does manually fix the package database in some cases, but I can't say whether he will have the time or inclination to do so in this case.
(Also note that packages automatically get dropped off when there's a new major release of Elm, so when 0.19 is released, the wrong package will get hidden (assuming you don't update it and republish it :) )
In the meantime, the recommend approach is to go into the wrongly-named package, change the elm-package.json description and the README to clearly state that it shouldn't be used and say which package to use instead, and then publish a new version of that wrongly-named package which will then show up in the package repo with the note about what to use instead.

Good idea indeed, will do (if possible actually... :/ ).
Still, it would be quite nice to prevent those kind of issues by, for instance, forbidding the publication of wrongly named module :+1:

I have similar issue. Should I create individual issue for it, ok this can be done here?
Package http://package.elm-lang.org/packages/akoppela/elm-css-extra-ptoperties has type in name. So I created new package. http://package.elm-lang.org/packages/akoppela/elm-css-extra-ptoperties needs to be unpublished.

Sorry for the trouble on this! The upcoming release disallows names with dots in elm.json so no one else finds out about this the hard way.
I needed to migrate a bunch of metadata to a new format, and not all packages can survive that transition. I can check to see that libraries with dots do not make it, so this will no longer exist on the 0.19 version of the pacakge website.

Yeah, packages with dots do not get migrated, so this will be removed when 0.19 is out.


refactor: generalize SMul (Ideal R) (Submodule R M) to SMul (Submodule R A) (Submodule R M)

and redefine Mul (Submodule R A) (Submodule R A) using the latter.

!bench

!bench

I think we won't get bench comparison unless we change the base branch or merge Ideal.mul (#17708) first ...

!bench

Can you please merge master and bench again?

!bench

Hmm, looks like a rather positive change! Mathlib.Algebra.Algebra.Operations got 15.7% slower but also 12.2% longer.

Hmm, looks like a rather positive change! Mathlib.Algebra.Algebra.Operations got 15.7% slower but also 12.2% longer.

Sorry, false alarm. The sped-up files were changed to avoid timeouts. Let me single those out to a separate PR ...

Thanks!
bors merge


build(blockifier_reexecution): add preprocess before execute txs

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1821  👈
#1797
#1796
#1765
#1759
#1758
#1712
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AvivYossef-starkware and the rest of your teammates on  Graphite

Merge activity

Nov 6, 10:34 AM EST: A user merged this pull request with Graphite.


[tool_crash] FileSystemException: Cannot create file, OS Error: Отказано в доступе., errno = 5

Command
flutter create app02_login_stateful

Steps to Reproduce

...
...
...

Logs
FileSystemException: Cannot create file, OS Error: Отказано в доступе.
, errno = 5
#0      _File.throwIfError (dart:io/file_impl.dart:635:7)
#1      _File.createSync (dart:io/file_impl.dart:273:5)
#2      ForwardingFile.createSync (package:file/src/forwarding/forwarding_file.dart:24:16)
#3      ForwardingFile.createSync (package:file/src/forwarding/forwarding_file.dart:24:16)
#4      Template.render.<anonymous closure> (package:flutter_tools/src/template.dart:231:28)
#5      _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:377:8)
#6      Template.render (package:flutter_tools/src/template.dart:195:24)
#7      CreateCommand._renderTemplate (package:flutter_tools/src/commands/create.dart:791:21)
#8      _rootRunUnary (dart:async/zone.dart:1198:47)
#9      _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#10     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#11     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#12     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#13     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#14     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
#15     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)
#16     Template.fromName (package:flutter_tools/src/template.dart)
#17     _rootRunUnary (dart:async/zone.dart:1198:47)
#18     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#19     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#20     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#21     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#22     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#23     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:40:15)
#24     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:311:13)

[✓] Flutter (Channel beta, 1.23.0-18.1.pre, on Microsoft Windows [Version
    6.1.7601], locale ru-RU)
    • Flutter version 1.23.0-18.1.pre at E:\tools\flutter
    • Framework revision 198df796aa (5 days ago), 2020-10-15 12:04:33 -0700
    • Engine revision 1d12d82d9c
    • Dart version 2.11.0 (build 2.11.0-213.1.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version
    29.0.2)
    • Android SDK at E:\Users\tol_pc\AppData\Local\Android\Sdk
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = E:\Users\tol_pc\AppData\Local\Android\Sdk
    • Java binary at: E:\Program Files\Android\Android Studio1\jre\bin\java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at E:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[✓] Android Studio (version 4.1.0)
    • Android Studio at E:\Program Files\Android\Android Studio1
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b01)

[✓] IntelliJ IDEA Community Edition (version 2020.1)
    • IntelliJ at E:\Program Files\JetBrains\IntelliJ IDEA Community Edition
      2020.1.3
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin version 201.8538.45

[✓] VS Code (version 1.49.3)
    • VS Code at E:\Users\tol_pc\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.14.1

[✓] Connected device (2 available)
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome
      86.0.4240.75

• No issues found!

Flutter Application Metadata
No pubspec in working directory.

Duplicate of #50880
Hey @rustkas , I found an issue addressing this problem. Please refer to that. It was fixed in a following PR. It should arrive in channel beta soon

Hi @rustkas
I'm closing this as a duplicate of https://github.com/flutter/flutter/issues/68099 please follow up on that issue for more information.


[Bug]: Group elements of non transformed PCollection with the transformed elements PColls in MLTransform

What happened?
In MLTransform, it infers schema from the transformations using the columns provided at data transformation level. When the input PCollection contains columns that are not specified at data transformation level, MLTransform will drop these columns at output since these columns are not known at compile time unless provided by user.
Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components

[X] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

Fixed at #27544


Run schedules without the ./ace command

How can I run the tasks without the ./ace command?
The idea is that I want to make it dependent on an env variable tu run it automatically, without having to type in the command.

Hey @GencBlakqori, take a look here: https://github.com/nrempel/adonis-scheduler/issues/10

Works, thanks @nrempel


[CT-1697] Release nightly from main

Proposal
Release nightly from main.
When to Release
dbt-core, dbt-bigquery, dbt-redshift -> nightly
dbt-snowflake and dbt-spark -> weekly
Both dbt-spark and dbt-snowflake do not currently run automated testing multiple times a day because tests are flaky.  Once that problem is fixed, these can move to being released daily as well.
Where to Release
Only release to test PyPi for these automated runs
Release to GitHub as a draft?  A prerelease?
Support

No guarantee release is bug-free
Ask the community to please report bugs via issues, but we won't be prioritizing fixes immediately.  Obviously bugs would be fixed before RC releases.
There would need to be some kind of socialization around this.

How to Tag
These aren't really alpha releases.  Should they even have a version associated with them?
1.4.nightly20221220
nightly-20221220 <- this makes it clear that it's different
What happens if the release fails?
Post to #dev-core-alerts.  New release has a lot of logging so it should be clear what caused the failures.
Open Questions

What to do about version bump? changelog?
How to deal with version match constraints between core/adapters?

Other Info
We would still release beta/RCs/final as before.  These would be manually triggered.

This is instead being done via nightly test releases to PyPI test with versions in the format of 1.3.4.dev<date>.  dbt-core get released off main and the adapters (minus spark b/c CircleCI) get released off of the most recent *.latest branches because they need minor version matching with core.


Shortcut doesnt work well on windows

Trying to trigger this using WIN + K on windows 11 results in windows trying to open the mirrorcast app
I have not been able to find a reliable shortcut to trigger this without triggering OS level shortcuts and cant find a way of specifying a custom shortcut to bypass the issue.
Am i doing something wrong?

@adenekan41 do you have any feedback on this issue?

Hey @danielcherrington,
This a good one,
I've tested this severally on different OS. and windows didn't seem to have a problem at the point of test. a possible fix would be to shift the SCA (shortcut action) from the windows button to the control button so we can trigger this with
ctrl + k
I'll see if I can send out a fix this week. Lets move this to #P2

Thanks @adenekan41 i will test out the new version this week and see if it resolves the problem =)

can confirm CTRL + K shortcut is now working as expected