Bug when formatting float literals in BigQuery

Describe the bug
sqlfmt adds unnecessary spaces for float literals in E notation in BigQuery
To Reproduce
1e-9
Expected behavior
1e-9
Actual behavior
1 e -9
Additional context
We are using the sqlfmt embedded in dbt develop. The UI on https://sqlfmt.com/ produces the same result.

Thanks for the report, @liaopeiyuan . I knew, and then forgot, that number literals could use scientific notation. This is true in postgres too. This is definitely a bug; I'll get this fixed asap.
We just need to change the number Rule to add a pattern that will match something like 1e-9 or -55.55e10. Decimals after the e are not supported (at least on pg).
https://github.com/tconbeer/sqlfmt/blob/f349abe38544b530f06aab64e3862a57e4d39a8e/src/sqlfmt/rules/core.py#L70-L76

@liaopeiyuan This patch has been merged to main. Thanks again for the report!


xplr: add missing darwin dependencies

Motivation for this change
Follow up to #122515
ZHF: #122042
https://hydra.nixos.org/build/142878923/nixlog/2
draft for now until a darwin user can confirm this builds
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Might be better off leaving this to darwin users.


Implement Python runtime ops (test_ops.py)

Hello,
I've seen in the PRs this topic is getting some interest so I am pushing my current implementation although it is not cleaned up yet.
$ PYTHON=1 python3 ./test/test_ops.py
...
----------------------------------------------------------------------
Ran 245 tests in 5769.725s

OK (skipped=4)

Let me know what you think of it, as I am new to this project I hope my understanding of it is good enough.
I will do some refactor a bit later to remove some useless lines.

Rebased and cleaned up I believe.
The performances are a bit concerning but I think that's to be expected with that many operations.
Feel free to merge whatever you think is valid. Cheers!

Note that the UOps.IF implementation is wrong at this stage (eg. nested ifs are not handled - a test should be added for that, but I have no clue how to generate those) and that likely the store implementation is too hacky. KamiKomplex504 gave some hints about how to handle it, and I guess the open dtypes PR may be relevant as well.

Tests failing.

Error: The operation was canceled.
I think that's because there is a timeout of some sorts on the CI. Maybe I should disable some for the python testing.

Just noticed https://github.com/tinygrad/tinygrad/pull/3384 is finally green too.
From the diff their implementation is likely more accurate so feel free to close this PR.

If you think theres is better, I'll close


tutorial: PrintToPDF

http://electron.atom.io/docs/api/web-contents/#contentsprinttopdfoptions-callback

I think this section should have low priority because we should just use one function described in the electron doc and because only a few app needed expressly this feature.


It's time to release a new version in pypi!

It's time to release a new version in pypi!

i agree!

Please, there are still print() statements for errors in the pypi package, which have long since been converted to proper logger events.
When this repo is being used by downstream pypi packages, pypi prevents pinning to a github branch. Which means, as a downstream consumer we are totally stuck with what is published in pypi if we also want to be published to pypi.

Sorry for delay - busy with babies and all that. Updated pypi.


Update docs' lists of supported HTTP clients

I noticed these were out of sync, especially weirdly one mentioning boto and the other mentioning boto3. I figure the list in the README is redundant when the Installation docs section lists the supported libraries, so I've removed it. I also:

alphabetically sorted the list
Highlighted the library names as code
Added both boto and boto3 to the list since there is support for both
Removed the comment about Tornado's AsyncHTTPClient since that's an implementation detail plus the patch happens on a couple different classes
Removed the note about http.client being part of Python 3, because everyone is Python 3 these days anyway :)

@adamchainz thanks for your contribution!


Allow to set/get attachment on Channel

Most users are looking for a way to assign some attachment to a Channel. At the moment they have two choices (out of the box).

Use a shared ChannelLocal instance for this
Use ChannelHandlerContext for this (the attachment is only visible in the ChannelHandler which belongs the the context here).

ChannelLocal is often not easy to spot for new-comers and also add some extra overhead because of the needed CAS semantic.
We should add methods to the Channel interface to set and get an Channel related attachment + @deprecate ChannelLocal. This will make it easier for users and also eliminate the overhead which ChannelLocal introduce.

I like the idea.
Thanks Norm.

How about this?
class AttributeKey<T> ... { ... }
<T> Attribute<T> Channel.getAttribute(AttributeKey<T> key)

Then we could keep type safety and make attributes more tightly integrated into a Channel.

I actually also have this implementation in my local branch.  I really should finish multi-modularization and start to sending pull requests. :-(

@trustin  Yeah the AttributeKey would allow us to keep type safety. So I think its not a bad idea. Should I implement it or do you have working code already ?

@ngocdaothanh I agree that ChannelLocal make things a bit more type-safe but it also gives some performance penalty which is not needed (CAS). Most times you are not interested in other Channels attributes so there is not need to keep them in a Map.

I have something similar to what I proposed, but it's not type-safe.
What I did was so small that it's fine for you to implement it by
yourself.  My idea was so far basically:

Define a dedicated interface that provides attribute access
Define a new final class AttributeType<T> and Attribute<T>

Attribute<T> has thread-safe getter, setter, compareAndSet, etc.

Make Channel extend it.

Feel free to implement it by yourself and improve it. :-)

Is there a reason that there can be only a single attachment to a channel? I can think of some examples where I would like to set a bunch of properties on a channel, but not sure I should need one all encompassing property DTO attachment. And if I want to set a bunch of DTOs on a channel, I'll need a parent wrapper DTO to group them.
Personally, I don't mind the ChannelLocal idea as long as it truly follows the ThreadLocal example. ThreadLocal is static and uses static methods. ChannelLocal is not static or use static methods, so the developer needs to instantiate it and pass it around, create a static instance in a super class that is shared, or set it on the Channel's attachment. Realistically, your setAttribute could just defer to a static ChannelLocal and then people can use either approach. I just like the ability to apply my own key/value pairs to property sets instead of being forced to attach everything to one DTO attached to the channel.

We should replace an attachment with an attribute map.

@trustin I don't agree... I think allow only one attachment makes sense. It even gives the user more power as setting just an object is "cheaper" then first create an Map and then store the object into it. If the user want to store more then one attachment its easy to just set and Map as attachment and operate on this. This even let the user choose if the Map needs to be synchronized / CAS or not.

@rshelley See above too ^^

Wouldn't it be a premature optimization?

@trustin can you give some more context why you thing its "premature" ?

It's just a hash map access and it might not slow thing as expected. If
it turns out to be too slow then we can add attachment or special
attribute key that accesses a dedicated volatile field.

I was more concerned about the "extra" space it takes. As we need to create it even if the user don't use the attachment as a ConcurrentHashMap on Channel construction or we need to synchronize the getAttachment setAttachment and create it in a lazy fashion.
I guess if we go this route I would prefer the second solution (lazy create)

I can see Norman's point, but from a developer's perspective, a lazy create of a small HashMap would be an easier (and cleaner) implementation.
Map blah = new HashMap();
foo.put("foo","bar");
channel.setAttachment(blah);
channel.getAttachment().get("foo");
as opposed to:
channel.setAttachment("foo","bar");
channel.getAttachment("foo");
The only issue you'll see with the latter approach is type safety. I can't assume that all my attachments would be strings (as in the example above). More likely, I'll have a mix of object types. To that you could add a type parameter to getAttachment:
channel.getAttachment("foo", String.class);
And that will return null if foo doesn't exist or if foo is not a String.


Request to join org

Hey, I'm Alon Bukai a Senior UI Engineer.
My email is<EMAIL_ADDRESS>I'd like to join the org please.

Hi. I am from the EMEA services team and my email is<EMAIL_ADDRESS>I would like to join the organization please.


Table query with parenthesis needs operators enclosed in spaces

Which service(blob, file, queue, table) does this issue concern?
table
Which version of the Azurite was used?
3.14.1
Where do you get Azurite? (npm, DockerHub, NuGet, Visual Studio Code Extension)
Visual Studio Professional 2022
What's the Node.js version?
16.13.2
What problem was encountered?
Table query with parenthesis and operators without spaces in between returns HTTP 400 error. It works with both real Azure storage and the deprecated Azure Storage Emulator v5.10
Steps to reproduce the issue?
Let's have a table with field BoolField of type Boolean.
Following query does not work with Azurite: (PartitionKey eq '')or(BoolField eq false)
Have you found a mitigation/solution?
The query operator must be enclosed in spaces: (PartitionKey eq '') or (BoolField eq false)

Thanks for reporting, I'm taking a look

Changes merged, pending next release.


[CI] Upgrade CI docker image and package Chromedriver to v91

User Story

As a [user role below]:
Carbon for IBM.com Tester

I need to:
have automated tests run against the latest version of Chromedriver

so that I can:
ensure all tests run properly on the latest version of Chrome

Additional information

Packages in Carbon for IBM.com should be upgraded to Chromedriver 90
Publish a new docker image that ships with Chrome v90 Stable: https://github.ibm.com/webstandards/dds-jenkins-agent

Acceptance criteria

[ ] New versioned docker image uploaded to Artifactory
[ ] Update pod template in Jenkins to point to the latest artifactory version
[ ] Upgrade Chromedriver across projects to v90

FYI, I ended up doing this for this sprint because the docker image was upgraded for a different reason during my work on the cypress e2e testing, but in the process pulled the latest stable chrome (v91).


docs: Updates to new onboarding account section

Issue #, if available: GALI-1059
Description of changes: New instructions added for the onboarding new account section.
Checklist:

[ ] Have you successfully deployed to an AWS account with your changes?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully tested with your changes locally?
[ ] If new dependencies have been added, have they been pinned to specific versions?
[ ] Is this change also required on the AWS Solution version?
[ ] Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)?
[ ] If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests?
[ ] If you are updating the changelog and vending out a new release, have you updated versionNumber and versionDate in .defaults.yml

AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

LGTM content-wise, but this should be PR'd against Tim's branch feat-merged-workspace-egress-update-user-permissions, not develop

Closing this PR in favor of this one instead.


More general ether torsion

I added a more general ether torsion, as discussed in issue #14

@cbayly13 Here's the fix we came up with for the not general enough ether torsion

Thanks, @bannanc . Merging.


Fixed errors thrown by Travis CI

Corrected formatting errors as thrown by Travis CI. Should build correctly now.

winning.

WOOT!


FIX: Cookbook - Packaging Components for npm

The example folder structure defines a rollup.config.json file, however the adjoined documentation involves creating a rollup.config.js file.

Thank you!


Fix locals and layer norm gradient edge case.

Changing p from global to local in all modules.
In layer normalization, moving addition of eps inside sqrt to prevent undefined gradient at sqrt(0).

LGTM


Food On Fork Node V2

Description
This PR is adding a feature node Food on Fork that will allow for automatically detecting the presence of food on the fork. It is addressing the issue linked here. It will output a probability to a topic /food_on_fork and the probability represents the probability with which we are able to predict food on the fork.
Design Decisions

This feature is currently using a model that uses Logistic Regression to make predictions for whether or not there is Food on the Fork.

Testing procedure
Steps to follow before beginning any tests:
Connect to Robot

ssh nano
ros2config
ros2 launch realsense2_camera rs_launch.py rgb_camera.profile:='640,480,30' depth_module.profile:='640,480,30' align_depth.enable:='true' initial_reset:='true'

Launching and Testing

Make sure to clone this repository and atharvak/food_on_fork_node_v2 branch and make sure to complete the installation of all dependencies.
Inside the ada_feeding_perception/config folder, there is a food_on_fork.yaml file. This file contains all the parameters. Notice that there is a test parameter. Go ahead and change the value of this parameter to be True.
Make sure to build and then launch the food_on_fork node by running ros2 launch ada_feeding_perception ada_feeding_perception_launch.xml. This will launch the node with the specified parameters.
In another terminal, please listen to the /food_on_fork topic (ros2 topic echo /food_on_fork). This is where you will be able to see the predictions being published.

Viewing output

To view the Prediction Probability, you can note this either in the log statements or in the terminal where you are listening to the /food_on_fork node.
To view the num pixels, you can note this in the log statements.

Choosing a fork and food item

Please choose a fork with fork tines NOT covered in tape (so, regular fork)
Please choose any food item for testing (You could consider doing a solid and a leafy food item, if you wish)

Test 1: Verify the overall behavior/working of the node (position: Home)
Position the robot to be in the Home position. Then, launch the node and make sure to echo the /food_on_fork topic.

[ ] Make sure you are seeing some log statements that are logging num pixels and Prediction Probability (if this is not working, make sure to go back and follow Launching and Testing steps)
[ ] Verify that when you are listening to topic /food_on_fork, where you see a probability (0.0-1.0) being output

Test 2: Verify the accuracy of count of pixels and output probability (position: Home; no Food on Fork)
Position the robot to be in the Home position. Then, launch the node and make sure to echo the /food_on_fork topic. Do not add any food onto the fork.

[ ] Verify that the num pixels is in the range of 0-150
[ ] Based on the number of pixels, visually trace over to a location of those number of pixels on the x-axis of the above figure. Then, visually verify that the Prediction Probability output is in a reasonable range on the y-axis of the above figure.

Test 3: Verify the accuracy of count of pixels and output probability (position: Home; Add Food on Fork)

Position the robot to be in the Home position. Then, launch the node and make sure to echo the /food_on_fork topic.
Add a food item on to the fork

[ ] Verify that the num pixels is in a higher range than when there was no food on the fork.
[ ] Based on the number of pixels, visually trace over to a location of those number of pixels on the x-axis of the above figure. Then, visually verify that the Prediction Probability output is in a reasonable range on the y-axis of the above figure.

Test 4: Repeat Tests 2-3 with a change in position to In-Front of Face
Position the robot to be in the In-Front of Face position. Make sure that the fork is approximately 2 inches away from the mannequin's mouth. Then, launch the node and make sure to echo the /food_on_fork topic. Then repeat Tests 2-3 in this position.
When there is no Food on Fork

[ ] Verify that the num pixels is in the range of 0-150
[ ] Based on the number of pixels, visually trace over to a location of those number of pixels on the x-axis of the above figure. Then, visually verify that the Prediction Probability output is in a reasonable range on the y-axis of the above figure.

When there is Food on Fork

[ ] Verify that the num pixels is in a higher range than when there was no food on the fork.
[ ] Based on the number of pixels, visually trace over to a location of those number of pixels on the x-axis of the above figure. Then, visually verify that the Prediction Probability output is in a reasonable range on the y-axis of the above figure.

Test 5: Repeat Tests 2-3 with a change in position to Over-the-plate
Position the robot to be in the Over-the-plate position. Make sure that the fork is approximately 2 inches away from plate. Then, launch the node and make sure to echo the /food_on_fork topic. Then repeat Tests 2-3 in this position.
When there is no Food on Fork

[ ] Verify that the num pixels is in the range of 150-300
[ ] Based on the number of pixels, visually trace over to a location of those number of pixels on the x-axis of the above figure. Then, visually verify that the Prediction Probability output is in a reasonable range on the y-axis of the above figure.

When there is Food on Fork

[ ] Verify that the num pixels is in a higher range than when there was no food on the fork.
[ ] Based on the number of pixels, visually trace over to a location of those number of pixels on the x-axis of the above figure. Then, visually verify that the Prediction Probability output is in a reasonable range on the y-axis of the above figure.

Test 6: Repeat Tests 2-3 when the arm is In-Motion

Repeat Tests 2 and 3 by moving the arm around

When there is no Food on Fork

[ ] Verify that the num pixels is in the range of 0-300
[ ] Based on the number of pixels, visually trace over to a location of those number of pixels on the x-axis of the above figure. Then, visually verify that the Prediction Probability output is in a reasonable range on the y-axis of the above figure.

When there is Food on Fork

[ ] Verify that the num pixels is in a higher range than when there was no food on the fork.
[ ] Based on the number of pixels, visually trace over to a location of those number of pixels on the x-axis of the above figure. Then, visually verify that the Prediction Probability output is in a reasonable range on the y-axis of the above figure.

Note: After the completion of testing, make sure to go back to the food_on_fork.yaml file and change back the test boolean from True to False.

[ ] Run your code through pylint and address (most) warnings/errors: pylint --recursive=y .

Before Merging

[ ] Squash & Merge

@amalnanavati I have a couple follow-up questions for you from your comments.

What exactly does it mean to add the testing procedure? Would I need to outline the things that someone else needs to do to be able to make sure that the code is working?
How/Where should I document dependency? I know you mention readme but would this be overall readme (as linked here but in my branch)?
Also, the training code should go into ada_feeding_perception package right? Just as a python file?

See this PR as an example. You need to:

Come up with a systematic set of tests to run so that you, as well as a critical reviewer, can be convinced that your code works.
You need to document the procedure so that anyone who reads this PR can follow the same procedure and get the same results. Just saying that it passes tests is not enough; it has to be independently verifiable.

Add it to the installation section of the ada_feeding_perception README. Make the change in this branch (e.g., as part of this PR), and then when this PR get merged into the main branch that change will go along with it.
You can put the code in somewhere like ada_feeding_perception/ada_feeding_perception/food_on_fork_train_model.py. You can put the data somewhere like ada_feeding_perception/data/food_on_fork_training_data.csv. Be sure to add to the README instructions on how to run the model training so that anyone who wants to retrain the model can.

Closing this PR to give way to PR # .


Random crashes on TextProgressBar

Information

Qiskit Terra version: 0.16.0
Python version: 3.7
Operating system:  Ubuntu 18.04, but actually any OS VM with 1  processor core

What is the current behavior?
Aqua uses TextProgressBar in several places and so it happens that sometimes the usage is reentrant. The problem is that the event infrastructure in Terra is global and sometimes we get crashes on the instance variable the TextBarProgress keeps (self.iter) since a single TextProgressBar receives all those events from parallel_map in mixed orders when actually they should apply to separate progress bars
Steps to reproduce the problem
This fails on a VM with 1 processor core:
import logging
import numpy as np

# Qiskit components
from qiskit import Aer, __qiskit_version__
from qiskit.circuit.library import RealAmplitudes, EfficientSU2
from qiskit.chemistry.components.initial_states import HartreeFock
from qiskit.aqua import QuantumInstance, set_qiskit_aqua_logging
from qiskit.aqua.algorithms import VQE, NumPyMinimumEigensolver
from qiskit.chemistry import set_qiskit_chemistry_logging
from qiskit.chemistry.applications import MolecularGroundStateEnergy
from qiskit.chemistry.core import TransformationType, QubitMappingType
from qiskit.aqua.components.optimizers import COBYLA, SPSA, SLSQP, CG, L_BFGS_B
from qiskit.chemistry.drivers import PySCFDriver, UnitsType
from qiskit.chemistry.components.variational_forms import UCCSD

set_qiskit_chemistry_logging(logging.DEBUG)
set_qiskit_aqua_logging(logging.DEBUG)
logging.info(__qiskit_version__)
logger = logging.getLogger(__name__)

def cb_create_solver_vqe(num_particles, num_orbitals,
                         qubit_mapping, two_qubit_reduction, z2_symmetries):
    print('z2 symmetries : {}'.format(z2_symmetries))

    initial_state = HartreeFock(num_orbitals, num_particles, qubit_mapping,
                                two_qubit_reduction, z2_symmetries.sq_list)
    var_form = UCCSD(num_orbitals=num_orbitals,
                     num_particles=num_particles,
                     initial_state=initial_state,
                     qubit_mapping=qubit_mapping,
                     two_qubit_reduction=two_qubit_reduction,
                     z2_symmetries=z2_symmetries)

    initial_point =  0.01*np.random.uniform(-2*np.pi, np.pi, size = var_form.num_parameters)
    optimizer =  SLSQP(maxiter = 1)

    vqe = VQE(var_form=var_form, optimizer=optimizer,
              initial_point=initial_point, include_custom=True)
    vqe.quantum_instance = QuantumInstance(Aer.get_backend('qasm_simulator'), shots=1)
    return vqe

def cb_create_solver_nes(num_particles, num_orbitals,
                         qubit_mapping, two_qubit_reduction, z2_symmetries):
    nes = NumPyMinimumEigensolver()
    return nes

DO_CLASSICAL = False

def main():
    # Molecule
    print('Begin main')
    # mol_geom = ["Li -0.1137 -2.139 0.0; S 0.0 0.0 0.0; H 1.353 0.0 0.0"]
    mol_geom = ['Li 0.0 0.0 1.375; H 0.0 0.0 -1.375']
    num_geom = len(mol_geom)
    results = np.zeros([num_geom])
    for i in range(num_geom):
        atom = mol_geom[i]
        print('mol geom[{}]: {}'.format(i,atom))
        driver = PySCFDriver(atom=atom, unit=UnitsType.ANGSTROM,charge=0, spin=0, basis='sto3g')

        mgse = MolecularGroundStateEnergy(driver, transformation=TransformationType.PARTICLE_HOLE,
                                          qubit_mapping=QubitMappingType.PARITY,
                                          two_qubit_reduction=True, freeze_core=True,
                                          orbital_reduction=[], z2symmetry_reduction='auto')
        solver = cb_create_solver_nes if DO_CLASSICAL else cb_create_solver_vqe
        result = mgse.compute_energy(solver)
        print(result)

if __name__ == "__main__":
    main()

What is the expected behavior?
TextProgressBar should receive events in order and just the ones that apply to that instance.
Suggested solutions
We thought of one solution that might work: The parallel_map method and TextProgressBar class would accept some optional event id. The id could be appended/prepended to the global Terra event string so that when time comes to emit the event in parallel map, it knows how to emit the ones that are start or end etc. This way there would be no clobbering of states.
And the publisher/subscriber would still work the same way not allowing the same event string more than once.
So each parallel_map method invocation would have 3 unique events: one start, one end and one update.

I think tqdm progress bars can support this. Maybe we can consider using them instead of our home grown bars?

This has nothing to do with the progress bars themselves. Rather it is the pubsub mechanism and how things listen to very general events that can easily conflict with others.

You can see this consistently when using the UCCSD() function in aqua under the following conditions:

You enable the DEBUG log level
local_hardware_info() sees only one CPU, or you export QISKIT_IN_PARALLEL=TRUE before running the program.

# https://github.com/Qiskit/qiskit-aqua/blob/0.7.5/qiskit/chemistry/components/variational_forms/uccsd.py#L239-L241
def _build_hopping_operators(self):
        if logger.isEnabledFor(logging.DEBUG):
            TextProgressBar(sys.stderr)

UCCSD instantiates progress bar subscriptions when in DEBUG log level. These functions can send an empty value list to parallel_map(). This case was seen already in #3634 and was fixed by making it return early where otherwise the progress bar would blow up with a division by zero.
However, even though the parallel_map returns early, the progress bar was already subscribed AND is uninitialized until there is a terra.parallel.start event.
For some reason I have not figured out, the update function on the progress bar can still get called in this uninitialized state, which results in this traceback:
Traceback (most recent call last):
  File "qprogram.py", line 99, in <module>
    result = main(callback = user_feedback,backend=Aer.get_backend("statevector_simulator"))
  File "qprogram.py", line 86, in main
    two_qubit_reduction=qubit_reduction, num_time_slices=1)
  File "/usr/local/lib/python3.7/site-packages/qiskit/chemistry/components/variational_forms/uccsd.py", line 157, in __init__
    self._hopping_ops, self._num_parameters = self._build_hopping_operators()
  File "/usr/local/lib/python3.7/site-packages/qiskit/chemistry/components/variational_forms/uccsd.py", line 249, in _build_hopping_operators
    num_processes=aqua_globals.num_processes)
  File "/usr/local/lib/python3.7/site-packages/qiskit/tools/parallel.py", line 149, in parallel_map
    _callback(0)
  File "/usr/local/lib/python3.7/site-packages/qiskit/tools/parallel.py", line 115, in _callback
    Publisher().publish("terra.parallel.done", nfinished[0])
  File "/usr/local/lib/python3.7/site-packages/qiskit/tools/events/pubsub.py", line 135, in publish
    return self._broker.dispatch(event, *args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/qiskit/tools/events/pubsub.py", line 97, in dispatch
    subscriber.callback(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/qiskit/tools/events/progressbar.py", line 139, in _update_progress_bar
    self.update(progress)
  File "/usr/local/lib/python3.7/site-packages/qiskit/tools/events/progressbar.py", line 163, in update
    filled_length = int(round(50 * n / self.iter))
TypeError: unsupported operand type(s) for /: 'int' and 'NoneType'

self.iter is None, since the progress bar start() was never called to set it.
     # https://github.com/Qiskit/qiskit-terra/blob/0.15.1/qiskit/tools/events/progressbar.py#L158
     filled_length = int(round(50 * n / self.iter))  # self.iter is None

The progress bar could check if it has been initialized based on self.touched before updating. However, a race condition would mean that something else that was not able to subscribe (collided due to an existing subscription) would still go on and publish events which would trigger a subscribed/uninitialized listener. Perhaps this is the cause for the above.

So I agree with the problem here it looks like the previous subscriber when aqua calls parallel_map([], ...) doesn't exit out. I think the fix for comparing the subscribers object ids is a good way to handle this. It does feel like there is an aqua bug here (which is what I mentioned in #3634) but this is simple enough to fix. The other thing which I tried was to force the text progress bar subscriber to exit when the fast paths for len() 0 and 1:
--- a/qiskit/tools/parallel.py
+++ b/qiskit/tools/parallel.py
@@ -101,21 +101,25 @@ def parallel_map(  # pylint: disable=dangerous-default-value
         terra.parallel.finish: All the parallel tasks have finished.
     """
     if len(values) == 0:
+        Publisher().publish("terra.parallel.start", len(values))
+        Publisher().publish("terra.parallel.finish")
         return []
     if len(values) == 1:
+        Publisher().publish("terra.parallel.start", len(values))
+        Publisher().publish("terra.parallel.finish")
         return [task(values[0], *task_args, **task_kwargs)]

Which also fixed the failures, but still seems more hacky than comparing the object ids.


Koonom1985 patch atrts

anyone help to check if this ATRTS is as expected?

this is for the issue #272

Hi @koonom1985,
This looks great on first glance. 😎  The development branch has improved typing and a more common and consistent style. For example: ssf with numba support. If you want give the new format a shot, awesome. If not, no worries.
Are you satisfied with the results so far? The core base indicators (ma, atr) are inline with TA Lib, so it should be fine.
Thanks,
KJ

sure, let me trytry the new format.
the result seems not very convincing as it shows diff with same of the example picture found online, not sure which part went wrong.

I double check on some ticker, it seems can imply the uptrend and downtrend.

Hi @koonom1985,
I have added it to the development branch if you want to check it out and provide feedback.
$ pip install -U git+https://github.com/twopirllc/pandas-ta.git@development

Thanks
KJ

Hey @koonom1985 and @twopirllc, I'm testing this script and comparing the values to the Tradingview indicator - but I'm getting different results. I'm comparing it to "ATR Trailing Stoploss".
I'm pretty new to this and probably doing something wrong, maybe I picked the wrong indicator, not sure. Maybe "ATR Trailing Stoploss" is not "ATR Trailing Stop"?
Can someone please help me out with this?

@wrone Did you find out the issue?


feat: upgrade deps

:tada: This PR is included in version 3.29.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


"Token endpoint should not use query parameters" will block some usages

As this ticket: https://github.com/spring-projects/spring-authorization-server/issues/1451, token endpoint should not use query parameters, since many existing external systems use our application's token endpoint which pass the query parameter as "/oauth/token?grant_type=client_credentials", it is not easy to notify all external systems to change their codes.
And the grant_type does not contain any sensitive information, is it possible that distinguish sensitive the parameters, accept non-sensitive parameters as query parameters, just reject the parameters which have sensitive information?

@lidothui

many existing external systems use our application's token endpoint which pass the query parameter as "/oauth/token?grant_type=client_credentials"

The external systems are not implemented to spec so it should be fixed there.

is it possible that distinguish sensitive the parameters, accept non-sensitive parameters as query parameters, just reject the parameters which have sensitive information?

You can override the existing OAuth2ClientCredentialsAuthenticationConverter by supplying your own implementation of AuthenticationConverter (similar to OAuth2ClientCredentialsAuthenticationConverter) and configuring it as follows:
OAuth2AuthorizationServerConfigurer authorizationServerConfigurer =
		new OAuth2AuthorizationServerConfigurer();
authorizationServerConfigurer
		.tokenEndpoint(tokenEndpoint ->
				tokenEndpoint
						.accessTokenRequestConverter(customClientCredentialsAuthenticationConverter)
						...

I'm going to close this as the consuming application would need to configure this off-spec customization.


Escaping the table name on insertion

I have a table named 'order'. Since it is a reserved keyword, it can be escaped with ` (back quote I think it's called), meaning I can do things like : CREATE TABLE `order` ( ... );. Thing is, when I try to insert a new entity through Spot, the escaping quotes are not used, and the PDO fails quite terribly :(
Is there any way to override that ? Should I just put protected static $table = "`order`";.
P.S.: I had to tweak the markdown a bit to have backquotes in the code, sorry if it looks weird
Edit: Actually, putting back quotes in $table fails the SELECT :(

This exact same issue bit me as well, with the "nice" addition that when performing a simple $orderMapper->get(1234) the resulting query was SELECT * FROM Order Order WHERE `Order`.`id` = ? LIMIT 1' with params [1234] which means that the query is broken in two different ways.

I agree that this should be done, but this is why I explicitly avoid naming tables and columns with reserved SQL keywords - it's just asking for trouble.

This should be fixed now as of v2.1.7.


Wrong merge algorithm

Describe the bug
The way that we currently merge models together (when we encounter combination, conditional schemas, etc) are somewhat wrong, since we merge properties together that have already been set.
How to Reproduce
Given the following JSON Schema:
{
  "type": "object",
  "properties": {
    "name": { "type": "string", "enum": ["test"] },
    "credit_card": { "type": "number" }
  },
  "dependencies": {
    "credit_card": {
      "properties": {
        "name": { "enum": ["test", "test2"] }
      },
    }
  }
}

It validates correctly against
{
  "name": "test",
  "credit_card": 2
}

but not
{
  "name": "test2",
  "credit_card": 2
}

which our model would allow, i.e. the current common model representation is this:
{
  "type": "object",
  "properties": {
    "name": { "type": "string", "enum": ["test", "test2"] },
    "credit_card": { "type": "number" }
  }
}

when in theory it should be
{
  "type": "object",
  "properties": {
    "name": { "type": "string", "enum": ["test"] },
    "credit_card": { "type": "number" }
  }
}

Meaning that our merge function should NOT add extra stuff to already sat keywords, only if they are not sat.
This is of course not relevant for properties since they can add extra properties as long as the property does not already exist, so there are exceptions. I have not figured everything out for each keyword, so it should be determined first.

Remember that not all places where CommonModel.mergeCommonModels is used this behavior make sense. It is only in the context of the interpreter.

Still relevant.

I think the solution here is that nested interpretations cannot open up a restricted structure.
For example, adding a context option to the interpreter which enables or disables this behavior conditionally.

This is going to be left for a later version, as having both is okay... Just not optimal.
And this use case is probably not going to be encountered that often.
Gonna re-create the issue with a focus on the interpretation.


⚠ Samsung has degraded performance

In b757cd3, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2769 ms

Resolved: Samsung performance has improved in 4424df5.


Installation on Archlinux fails: no shasum

What version of dep are you using (dep version)?
I installed dep using go get github.com/golang/dep. When running make install an error is displayed.
git describe --tags shows:
v0.5.0-15-g22125cfa

What dep command did you run?
Not applicable, I'm trying to install on Archlinux.
What did you expect to see?
No errors.
What did you see instead?
As seen in ci on travis:
./hack/build-all.bash: line 61: shasum: command not found

Archlinux does not have shasum, but does have sha256sum. I'll make a pull request for this change.

Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks!


window.requestAnimationFrame not defined and nodeType null

Hey,
I'm helping test an animation library and my tests are failing because it says that requestAnimationFrame is not defined and nodeType not defined. The code works I've verified that in codepen. However I think its because jest isn't exposing requestAnimationFrame property on the window object. Just to make sure here in MDN docs it should be on the window object.  I console log the window object in the test and a very very large object is logged out to my terminal. I'm new to Jest but heres what the test looks like so I may be doing something wrong:
import React from 'react';
import renderer from 'react-test-renderer';
import Anime from './../src/Anime.js';

// fails with ReferenceError: requestAnimationFrame is not defined
it('Anime single child Snapshot', () => {
  const tree = renderer.create(
    <Anime easing="easeOutElastic"
           loop={true}
           duration={1000}
           direction="alternate"
           loop={true}
           delay={(el, index) => index * 240}
           translateX='13rem'
           scale={[.75, .9]}>

1

      </Anime>
  ).toJSON();
  expect(tree).toMatchSnapshot();
});

// fails with TypeError: Cannot read property 'nodeType' of null
it('Anime multi-child Snapshot', () => {
  const tree = renderer.create(
    <Anime easing="easeOutElastic"
           loop={true}
           duration={1000}
           direction="alternate"
           loop={true}
           delay={(el, index) => index * 240}
           translateX='13rem'
           scale={[.75, .9]}>

1

2

3

      </Anime>
  ).toJSON();
  expect(tree).toMatchSnapshot();
});

jsdom doesn't ship with requestAnimationFrame. You'll need to put a polyfill into your setupFiles config like this one: https://gist.github.com/paulirish/1579671

@cpojer okay just fixed that, do you know why the Cannot read property 'nodeType' of null is occurring? It happens here:
Before:
   // mutiple children failed test complains about the children not having key prop
  {children.map((child, i) => (React.cloneElement(child, {ref: this.addRef})))}

After:
  // so I added key to the prop and then Cannot read property 'nodeType' of null is caused
  {children.map((child, i) => (React.cloneElement(child, {key: i, ref: this.addRef})))}

The test renderer currently doesn't support refs; this is a feature the React team is currently working on.

Okay, any timetable you may know of?

I think probably like 15.4 but I'm not on the React team, so not sure. See https://github.com/facebook/react/pull/7649

@cpojer thank you!


how to use in hosting

Hi,
I'm using this tools, and work like charm on my local server, but how to achieve in hosting CGI/FastCGI
TQ

Put the b374k file in the folder that you run your php applications.

dear hiagohubert,
thank for reply, sorry just read my mail, your notice thrown to spam,
like I said "works like charm on my local server" but not in shared hosting...
maybe you have any other clue ?

Hi ntaloventi, what is the version of PHP on the shared hosting? When you try to run b374k on shared hosting, it throws a error?


Revert "[Core] Remove index on deleted status (#7815)"

Description
Fixes https://github.com/dust-tt/tasks/issues/1442 again
See issue: removing the index put a strain on the secondary, which triggered monitors on database recovery errors every time the scrub workflow was run (every 8 hours)
This is fixed by reverting commit 294e82cb1a5eed65d7e17ca8e2ccd08978fbbbdc.
Risks
Risk was that the index make inserting in that table costly, but that doesn't seem to be the case, since the query we wanted to optimize by removing the index sits still:
link
(the update data source / status is still at ~25ms so removing the index actually had no effect)
Deploy

run migration on prodbox
deploy core

PMRR


Binary XML file line #29: Binary XML file line #29: Error inflating class com.paulrybitskyi.persistentsearchview.PersistentSearchView

When I tried to implement library, at the beginning get this error. Is there anyone know the reason?

@mustafayildizz Could you post the full stack trace of the error? Would help a lot to pin down the issue.

Thank you and sorry for late answer. No longer needed. Thanks a lot again.


faster dual

making duals is really slow and now that it's multi-threaded it pollutes flamegraphs

Closing as not actionable. #184 has done most of the job.


Per-machine installation description accuracy

Following paragraph for the description of a 'Per-machine installation' has inaccurate program folders identified;
This installs Teams to the Program Files (x86) folder on a 64-bit operating system and to the Program Files folder on a 32-bit operating system.
Should read;
This installs Teams to the Program Files (x86) folder on a 32-bit operating system and to the Program Files folder on a 64-bit operating system.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 85b331f4-5939-688a-31e6-7f4c5e1c185d
Version Independent ID: 42e1f341-92c0-0a9b-9c3b-efbb5238844f
Content: Microsoft Teams on Windows Virtual Desktop - Azure
Content Source: articles/virtual-desktop/teams-on-wvd.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@Zucky16 Thanks for pointing this out. The document is updated and changes will go live soon.


HP.HPCMSL version 1.6.4

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/rerun-pipelines-please

@wingetbot waivers Add Validation-No-Executables


[REVIEW] Portfolio + GitHub Profile Review

Portfolio link: https://anishagg17.github.io/
GitHub Profile link: https://github.com/anishagg17

A trivial but best part that I liked was if you try to scroll past the end of the page the %age badge on About page shows more than 100% 👍 Not sure if it works on all the devices, I was on a Mac with Safari. Still nice touch!
I know this is a small thing, but since I have an OCD for design, the tiles on 'My Work' pages are not uniform/same size. Other than that amazing work!

Portfolio link: https://anishagg17.github.io/
GitHub Profile link: https://github.com/anishagg17

@anishagg17 bro i have some suggestion for you regrading github profiles you can added more features in it like you can add languages and framework with proper big big boxes like this is seen in my this github profile

and plss increase the size of social media icons

Thank you for sharing, we will review on a live stream soon 👍 It looks like you are getting great community feedback already 💥

Reviewed on live stream https://www.youtube.com/watch?v=8SmgE7X9yHg
Looks good, some of our thoughts

you have not joined EddieHub 😢
great to see the technology break down in your customised profile
I am not a fan of profile views badge
the website looks great, and the terminal is fun


Split Zooniverse classification data by project

Zooniverse data is retrieved using same project number, for many different projects. This leads to issues in populating the db for each project since things like movie_id might not be unique.

It populates the db after the workflow has been selected, so this issue gets solved by solving issue #124


Include patch for SOURCE_DATE_EPOCH

This adds a fix for SOURCE_DATE_EPOCH in static libraries on macOS. The fix was merged upstream: https://github.com/tpoechtrager/cctools-port/pull/140

That patch now is included through #70. I think we can close this PR?


[CARBONDATA-772]  NumberFormatException displays to user in spark 2.1

There were a problem with conversion of value from string to actual data-type for filter query.
So it needed to be parsed as parseInt and other.

Build Success with Spark 1.6.2, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/1213/

Please provide detail description about this change

@kumarvishal09 description added

Build Success with Spark 1.6.2, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/1217/

@rahulforallp please change tile to : [CARBONDATA-772] xxx

@chenliang613 title edited

retest this please

Build Success with Spark 1.6.2, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/1974/

SDV Build Failed with Spark 2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/60/

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/90/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/628/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/1259/


Make it PWA

[ ] Website new version available
[ ] Cache all requests (with exclusions)
[ ] Return cached version and update cache in bg. If updated -> new cache version is available


Use symfony/lts for 3.3 branch too

composer create-project symfony/skeleton test "3.3.*" as specified in example in http://symfony.com/doc/current/setup.html currently downloads 4.* packages

Thank you @ostrolucky.


[test] Allow customizing swift-ide-test invocations during tests.

In some Linux setups, one might need to provide extra arguments to setup the environment for invocations done during the tests. The Swift frontend and driver already had a mechanism to provide those arguments in the shape of SWIFT_FRONTEND_TEST_OPTIONS and
SWIFT_DRIVER_TEST_OPTIONS. swift-ide-test was sadly missing the same feature, which meant that many tests might fail or tests against the incorrect environment.
The changes implement the SWIFT_IDE_TEST_TEST_OPTIONS mechanism to cover that gap.

@swift-ci please test


Symbols for other tokens

Currently we handle symbols for identifiers and dynamic strings, but there are other kinds of symbols in Ruby. Those include:

[ ] Instance variables (:@foo)
[ ] Class variables (:@@foo)
[ ] Global variables (:$foo)
[ ] Keywords (:self)
[ ] Operators (:+)
[ ] Constants (:Foo)

We need to handle all of these cases. This will involve updating our parse_symbol function.

Fixed by #271


Feature: Add optional lookback_interval param to insert_by_period materialization

This is a:

[ ] bug fix PR with no breaking changes — please ensure the base branch is master
[x] new functionality — please ensure the base branch is the latest dev/ branch
[ ] a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation
The insert_by_period materialization does not work with sessionization models like segment_web_page_views__sessionized from the dbt Segment package due to some unusually complex logic. Since these sessionization models are often very large and complex, I would like to be able to use the insert_by_period materialization with them.
This is my first PR to a dbt repo, let alone a dev branch, so please let me know if any additional work is needed for this PR.
Also, huge thanks to Scott Barber on the dbt-labs customer support engineering team to get me started on refactoring the macro! His input and guidance were a massive help and this was a great learning experience for me.

This PR adds an optional lookback_interval parameter to the insert_by_period materialization, allowing it to be used with sessionization models like segment_web_page_views__sessionized from the dbt Segment package.
This is achieved by allowing the end user to include __PERIOD_FILTER_WITH_LOOKBACK__ in their model SQL, which the materialization replaces at runtime of each period using this modified macro logic in the materialization code.
{% macro default__get_period_sql(target_cols_csv, sql, timestamp_field, period, start_timestamp, stop_timestamp, offset, lookback_interval) -%}

  {%- set period_filter -%}
    ("{{timestamp_field}}" >  '{{start_timestamp}}'::timestamp + interval '{{offset}} {{period}}' and
     "{{timestamp_field}}" <= '{{start_timestamp}}'::timestamp + interval '{{offset}} {{period}}' + interval '1 {{period}}' and
     "{{timestamp_field}}" <  '{{stop_timestamp}}'::timestamp)
  {%- endset -%}

  {%- set period_filter_with_lookback -%}
    ("{{timestamp_field}}" >  '{{start_timestamp}}'::timestamp + interval '{{offset}} {{period}}' - interval '{{lookback_interval}}' and
     "{{timestamp_field}}" <= '{{start_timestamp}}'::timestamp + interval '{{offset}} {{period}}' + interval '1 {{period}}' and
     "{{timestamp_field}}" <  '{{stop_timestamp}}'::timestamp)
  {%- endset -%}

  {%- set filtered_sql = sql | replace("__PERIOD_FILTER__", period_filter) | replace("__PERIOD_FILTER_WITH_LOOKBACK__", period_filter_with_lookback) -%}

  select
    {{target_cols_csv}}
  from (
    {{filtered_sql}}
  )

{%- endmacro %}

In addition to the integration tests I have added in this PR, I have tested the application of these changes to the materialization on my sessionization models @Surfline to ensure idempotency of session_ids is still maintained. I have added documentation on usage to the README.
The materialization can also be used on any model where loading by period is desired, but a lookback interval is also required to filter the upstream data (which is typically accomplished using incremental logic).
Checklist

[x] I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)

[ ] BigQuery
[ ] Postgres
[x] Redshift
[ ] Snowflake

[ ] I have "dispatched" any new macro(s) so non-core adapters can also use them (e.g. the star() source)
[x] I have updated the README.md (if applicable)
[x] I have added tests & descriptions to my models (and macros if applicable)
[x] I have added an entry to CHANGELOG.md

I also see issue #192 talking about modernizing this materialization. But, it looks like all of the changes discussed there have happened in the dbtvault repo and are largely Snowflake focused.
Would be great to modernize the original redshift version as well (or a universal materialization). But that work seems like a separate PR.

@jtcohen6 since you have done a fair amount of work with Segment in the past, thought you might have the context to review this -- it's an application of insert_by_period that allows for a window to use for sessionization-type queries.

Hi @GClunies! This is a really fantastic addition to the codebase and clearly has a ton of thought and care put into it. We are actually in the process of determining what the future of the insert_by_period materialization is. It's less battle tested and cross compatible and much more experimental than the level of assurance you would normally expect in dbt-utils and it'd quite likely we will be moving it into a repo for experimental  functionality in the near future. We'd love this addition and other things like cross database functionality to get added when we do that.
In the meantime I'm going to close this as it isn't a good fit for utils right now but we really, really do appreciate the contribution and look forward to merging this in when we ultimately determine where insert_by_period is going to live.

@jasnonaz thanks for the kind words and update! Agree that a separate repo makes a lot of sense. Feel free to ping me in the new repo when you get to it. For now I have this as a macro in our dbt project so no risk of a breaking change for me.


Saving project crashes if source project files have been deleted

Can you detail how to reproduce it? Here's what I've done:

Create a new project and save it under some name
Delete the project file
Save the project again

It didn't crash.

To be honest, I don't recall exactly what the problem was. I should have included detailed repro steps but I was too lazy apparently. I'll close this ticket. We can open it again or create a new ticket if/when we figure it out.
Thanks for looking into it!


Missing license files

@sindresorhus Hi Sindre, thank you for this package. Would you mind adding the license file to the npm package of v0.1.0 and latest? Without it we're not really able to use it, because it makes the npm package a distribution of proprietary code.
Additionally I noticed the license file does not include the date, which makes it invalid. I'd greatly appreciate it if you could add the dates to the license files in GH repo as well.
Many thanks for your consideration.

Same answer as https://github.com/sindresorhus/is-path-cwd/issues/5#issuecomment-435030426.

@sindresorhus, it's your own dependency (require-uncached) is using the outdated version of caller-path.


ldapseach operational attributes

Hi,
How to search operational attributes like :  createtimestamp, modifytimestamp, pwdchangedtime
using ldapjs npm. Usually we use '+' to search these attributes, but somehow its not working at my end.
Thanks in advanced.

I am also interested. Did you discovered how to fetch operational attributes ?

Hi guys, i have just bumped into this issue
@projadmin @Snowmanko you can do it this way:
opts = {
scope: 'sub',
attributes: ['*','+']
};
See the "+" sign in attributes option

maybe this could be added to the docs?

👋
On February 22, 2023, we released version 3 of this library. As a result, we are closing this issue/pull request.
Please see issue #839 for more information, including how to proceed if you feel this closure is in error.


silx.gui: Fixed PyQt6 support by not using deprecated qt.QPalette.Normal

Replace qt.QPalette.Normal by qt.QPalette.Active to support pyqt6
closes #3962

I guess it's because QPalette.Normal is deprecated (see https://doc.qt.io/qt-6/qpalette.html#ColorGroup-enum) but I don't really see the point.


default character set option for mysqldump command

After 8.5.0, ConcreteCMS support utf8mb4 character set.
We've fixed the default character set to utf8 upto now

Added


chore: cleanup Travis CI config

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Feature Request]: Add unit test to validate RunInference ModelHandler doesn't cause regressions

What would you like to happen?
In the unit tests for ModelHandler there is no strong test to validate that the signature of the constructor does not change.
If the signature of the constructor changes, then we can break other projects that rely on backwards compatibility like tfx-bsl classes that rely on ModelHandler.
We should add unit tests to make sure this compatibility is not broken.
Issue Priority
Priority: 2
Issue Component
Component: sdk-py-core

.take-issue

.set-labels task run-inference python ml core P2

The take issue/add labels action was broken until just now, should be fixed


Stringify torch.version before serializing it.

Otherwise, it causes problems when loading a checkpoint saved by torch 1.10.0 from torch 1.7.1

LGTM!


Catch CI up with github

Fallout from https://github.blog/changelog/2022-11-09-github-actions-ubuntu-latest-workflows-will-use-ubuntu-22-04/

No trouble at all.  If you want to pick a clang version to switch to, or to add in addition to the ubuntu-20.04/clang-10 mix, I'm happy to add those too.

Don't merge; testing newer clangs.  If it works, I'll expand some commentary and then we can merge.

OK, maybe ready now. :)


Fix powershell multi-line command

Added missing backticks on the New-AzProximityPlacementGroup multiline powershell command so that copy/paste into a terminal will work as expected

@mattmcinnes
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Add generic circular array container

Proposed changes
This patch introduces a generic circular array container, ancillary to the upcoming functional form of motion models.
Type of change

[ ] 🐛 Bugfix (change which fixes an issue)
[x] 🚀 Feature (change which adds functionality)
[ ] 📚 Documentation (change which fixes or extends documentation)

Checklist

[x] Lint and unit tests (if any) pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] All commits have been signed for DCO

All green, going in!


feat(rpc): update staging in tx pool info to proposed

update staging field in the tx pool info to proposed field

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@312a5c4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             develop    #181   +/-   ##
=========================================
  Coverage           ?   97.4%
=========================================
  Files              ?       9
  Lines              ?     231
  Branches           ?      42
=========================================
  Hits               ?     225
  Misses             ?       5
  Partials           ?       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312a5c4...a4f4192. Read the comment docs.


docker启动byconity-server报错

启动命令：

docker compose -f docker-compose.essentials.yml -f docker-compose.simple.yml up -d

环境文件：

COMPOSE_PROJECT_NAME="byconity"

DATA_DIR=/data/byconity
SERVER_TCP_PORT=9123
SERVER_HTTP_PORT=9124

BYCONITY_IMAGE=byconity/debian-runner
BYCONITY_IMAGE=byconity/byconity:0.4.0
BYCONITY_BINARY_PATH=""

日志：

[root@iZbp1gzqkxjmvdfgohobh9Z docker-compose]# docker logs -f 3d3974dcf916
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (7) Failed to connect to tso-0 port 18845: Connection refused
Warning: Problem : connection refused. Will retry in 5 seconds. 10 retries
Warning: left.
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (7) Failed to connect to tso-0 port 18845: Connection refused
Warning: Problem : connection refused. Will retry in 5 seconds. 9 retries
Warning: left.
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (7) Failed to connect to tso-0 port 18845: Connection refused
Warning: Problem : connection refused. Will retry in 5 seconds. 8 retries
Warning: left.
100   376  100   376    0     0   367k      0 --:--:-- --:--:-- --:--:--  367k
version: DB::TSO::TSOImpl
non_service_error: 0
connection_count: 1
max_concurrency: unlimited
[DB.TSO.TSO]

GetTimestamp (GetTimestampReq) returns (GetTimestampResp)
count: 0
qps: 0
error: 0
eps: 0
latency: 0
max_latency: 0
concurrency: 0

GetTimestamps (GetTimestampsReq) returns (GetTimestampsResp)
count: 0
qps: 0
error: 0
eps: 0
latency: 0
max_latency: 0
concurrency: 0

Processing configuration file '/config/server.yml'.
Logging debug to /var/log/byconity/out.log
Logging errors to /var/log/byconity/err.log
Logging debug to console
2024.07.01 10:04:21.254745 [ 7 ] {} <Information> Application: jeprof status: false
2024.07.01 10:04:21.254809 [ 7 ] {} <Information> SentryWriter: Sending crash reports is disabled
2024.07.01 10:04:21.515326 [ 7 ] {} <Information> : Starting ByConity <IP_ADDRESS> scm <IP_ADDRESS> with revision 54453, build id: DA45EC1127D06731, PID 7
2024.07.01 10:04:21.515515 [ 7 ] {} <Information> Application: starting up
2024.07.01 10:04:21.515599 [ 7 ] {} <Information> Application: OS name: Linux, version: 3.10.0-1160.114.2.el7.x86_64, architecture: x86_64
2024.07.01 10:04:21.534126 [ 7 ] {} <Error> Application: DB::Exception: cnch_config not found SQLSTATE: F0000
2024.07.01 10:04:21.534220 [ 7 ] {} <Information> Application: shutting down
2024.07.01 10:04:21.534230 [ 7 ] {} <Debug> Application: Uninitializing subsystem: Logging Subsystem
2024.07.01 10:04:21.534475 [ 34 ] {} <Information> BaseDaemon: Stop SignalListener thread

Please check if there is any files changed in your git repo (git status), and the branch is correct (git branch). Or simply clone a new repo and start from scratch.

@w182757427 Can you please switch to the latest master branch and run the docker-compose again?

@w182757427 Can you please switch to the latest master branch and run the docker-compose again?

ok，docker compose使用1.0.0的镜像版本启动没有问题了


Parameterize STAGING in build task

Since our staging bucket is private, let's not hardcode it.

Does mule ensure that environment variables are set? Seems like a good change.

It depends on the task, but generally, yes.
Most mule tasks call targets that invoke a shell script, so those will check for needed env vars.  Others, like the one in question here, call an internal library function to upload to S3 using boto3, so that will expect the env var to be set in the calling environment.
Here is how I did the upload to staging:
STAGING=algorand-staging VERSION=2.2.0-beta mule -f mule.yaml stage

I'll add all of this to the documents.


Limit order notification always show M$0

I keep seeing notifications like these from this market: https://manifold.markets/Stralor/who-will-be-the-republican-nominee-8a36dedc6445
It should not say "M$0"

I think it's from this component:
https://github.com/manifoldmarkets/manifold/blob/7feb7be024cc7133fd4a5b1ed13f4771ace9d24c/web/components/notifications/notification-types.tsx#L477

resolved by c1521ca6fe2ecf51819ed554b8526ae7c72799b1


Template block in partial not overriden

Let's say I override the title block in the homepage template:
index.html
{{ define "title" }}{{ .Site.Title }} | {{ .Site.Params.description }}{{ end }}

It is working if I include the title block in baseof.html:
baseof.html
<title>{{ block "title" . }}{{ .Title }} | {{ .Site.Title }}{{ end }}</title>

But it is not working if I include the title block in a partial and then import the partial in baseof.html:
baseof.html
{{ partial "head" . }}

head.html
<title>{{ block "title" . }}{{ .Title }} | {{ .Site.Title }}{{ end }}</title>

Then the title content seems to be the last known or "Hugo default" title.

Hugo version 0.76.5

Duplicate #7936

Duplicate #7936


[styles] Bump CSSType@3

Bumps csstype to the next major release

[x] I have followed (at least) the PR section of the contributing guide.

Sure, I understand. At least this test passes.

This test passes which tests for conflicts between v2 and v3. But it's unclear on what could happen beyond this, so I understand.
Here's the changes in v3 https://github.com/frenic/csstype#version-30, so the major change primarily affect Flow so it doesn't really concern you.
There's a PR open that bumps CSSType@3 for React here: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46435/
Whenever that's merged you should be safe to merge this as well 👍

@frenic I have updated @types/react to v3 but we have an issue with https://github.com/frenic/csstype/issues/63. I had to force the resolution to v3.

I see. I bumped @types/react and @types/styled-components in all package.jsons. I believe it's right thing to do here. But also @emotion/serialize, dom-helpers and jss needs to bump to v3 as well until it can resolve to v3 without resolutions.


enable ubuntu2204_cpp20

cpp20 build is missing in the ci

Is the failure just because it's a new image name?

looks like a problem with the cache? I dont know
ERROR: failed to solve: failed to push ghcr.io/acts-project/ubuntu2204_cpp20:pr-85: unexpected status: 403 Forbidden


Adding navigateFallback does not work

Hi,
Thank you for providing an example implementation of a PWA with nextjs. I was implementing a similar model to my nextjs app and with my config for the service worker in next.config.js i added then setting called navigateFallback="/index" to add a fallback page if the network is down so the service worker can deliver that and the app continues to display some cached content even if the network is down.
That setting however doesn't work and when the network is turned off it still shows a 404 page saying the page can not be found and so the redirect doesn't work.
I wonder if you have found this bug or have a solution to get that to work?
BW
P

Sadly this is a known issue with both sw-precache and next-offline and the only solution consists of wrapping requests in a local cache and then defining an app shell to get everything to work. It's not particularly easy to do, so it's better to just use next-offline to at least get some offline support.


perf(remix-dev/config): improve createRoutPath's footprint & unit tests

Hi Remix,
I chose a todo at random in the code and came across the createRoutePath function of remix-dev.
I added the last missing unit test to have 100% coverage but I'm not sure if the case reacts correctly.
Indeed, a routes/index/children path will generate routeschildren. I did not change the way it works to avoid a braking change.
I don't know what we want in this case createRoutePath('routes/index/children'):
routeschildren
routes/children
routes/index/children
https://github.com/gyx1000/remix/blob/perf/dev-create-route-path/packages/remix-dev/config/routesConvention.ts#L201
By analyzing the function, I also realized that we could improve its performance by about 50% (with the tests I performed).
Several functions are initialized for each iterated character. I simply converted the function to a variable to avoid this.
console.time('createRoutePath');
for(let i=0; i<1_000; ++i) {
    createRoutePath('routes/children/subchildren')
}
console.timeEnd('createRoutePath');

// before change: 22.96ms
// after change: 11.143ms

Thanks again for this wonderful project.

Thanks for the update @gyx1000!  This code is actually about to be deleted when we move our default to the "flat routes" convention for v2 - but we've moved this "nested folders" approach over to a new package folks can continue to use in v2 if they prefer it.  So I don't think it's worth merging these changes here just to delete the code but if you'd like to make them over in the other repo and open a PR we could merge them for future usages of that package!
As for the routes/index/children test - since index.tsx is a reserved name, you may need to leverage routes/[index]/children.tsx if you actually want to be able to hit a URL such as https://domain.com/index/children, so I'm not sure if that is a valid test.  But the routing convention isn't my specialty so I'll defer to @mcansh on that for the new PR.
Thanks!


Istio metric “istio_requests_total” does not include the requests in flight

Bug description
Istio has several default metrics, such as istio_requests_total, istio_request_bytes, istio_tcp_connections_opened_total. Istio envoy proxy computes and exposes these metrics. On the Istio website, it shows that istio_requests_total is a COUNTER incremented for every request handled by an Istio proxy.
We made some experiments where we let a lot of requests go through the Istio envoy to reach a microservice behind Istio envoy, and at the same time we monitored the metric from Istio envoy. However, we found that istio_requests_total does not include the requests that have got through Istio envoy to the backend microservice but their responses have not arrived at Istio envoy from the backend microservice. In other words, istio_requests_total only includes the number of served requests, and does not include the requests in flight.
Is our observation right?
Why does istio_requests_total NOT include the requests in flight?
Expected behavior
“istio_requests_total” should include all requests, no matter whether envoy receives their responses or not.
Steps to reproduce the bug

deploy a microservice with envoy proxy.
send the requests to the microservice through envoy proxy.
scrape the metrics from envoy proxy.

Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
# istioctl version --remote
client version: 1.5.2
control plane version: 1.3.5
data plane version: 1.3.5 (9 proxies)

# kubectl version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.1", GitCommit:"7879fc12a63337efff607952a323df90cdc7a335", GitTreeState:"clean", BuildDate:"2020-04-08T17:38:50Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T11:48:36Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

# helm version
version.BuildInfo{Version:"v3.0.2", GitCommit:"19e47ee3283ae98139d98460de796c1be1e3975f", GitTreeState:"clean", GoVersion:"go1.13.5"}

How was Istio installed?
Follow the official document.
Environment where bug was observed (cloud vendor, OS, etc)
Physical cluster.
Ubuntu 16.04.1 LTS (GNU/Linux 4.4.0-174-generic x86_64)

Not an expert here, but the metric includes tags like response code, etc. I am not sure if would be possible to report these before the response has completed

This is the expected behavior. The metrics are populated in the log() phase. In-flight requests are not currently monitored.
It sounds like there is a feature request here however. I don't think we could use the same metric (for reasons related to the ones that @howardjohn mentions), but we could pursue an in-flight metric, perhaps.

@hotjunfeng Would you mind expanding on the use cases that you have in mind for this feature?  Is the concern tracking pending requests? Or long-lived requests?

I think the in-flight metric is pretty useful in these cases: (1) monitor the instant load of the service by factoring in pending requests; (2) monitor the exact incoming rate of the service (the rate of arriving instead of the rate of responding); (3) could help get the duration time of requests (the time between arriving and responding). @douglas-reid

Hi @douglas-reid , I would like to add this in-flight metric but I am a newbie for Istio. Could you please give me some hints about how to deploy this metric? For example, which part of codes should I look into and modify? Thank you very much.

This feature will also be pretty useful to setup autoscaling API-based services. Any update here.

Envoy has a stats downstream_rq_active which might be sufficient for the
use case:
https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_conn_man/stats
You can use annotations to expose it:
https://istio.io/latest/docs/ops/configuration/telemetry/envoy-stats/
On Fri, Sep 25, 2020 at 5:24 PM Parth Shah<EMAIL_ADDRESS>wrote:

This feature will also be pretty useful to setup autoscaling API-based
services. Any update here.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/23672#issuecomment-699238612, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AIJBBSF4RGGBHAVVZPFZU5DSHUYDHANCNFSM4M4UMUZQ
.

One technical reason is that requests in flight don't have peer metadata (e.g. we wait for response headers to populate labels). Some labels like response code and flags are not known until completion.

Envoy has a stats downstream_rq_active which might be sufficient for the use case: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_conn_man/stats You can use annotations to expose it: https://istio.io/latest/docs/ops/configuration/telemetry/envoy-stats/
…
On Fri, Sep 25, 2020 at 5:24 PM Parth Shah @.***> wrote: This feature will also be pretty useful to setup autoscaling API-based services. Any update here. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#23672 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJBBSF4RGGBHAVVZPFZU5DSHUYDHANCNFSM4M4UMUZQ .

We wanted to be able to monitor the number of inflight requests for our services through Istio, so we followed the steps in the links suggested. We were able to expose the envoy_http_stats_downstream_rq_activegauge metric; however, this metric always reports back a constant "1" value which is not useful. Wondering if anyone else has seen this issue or knows how we can try to fix it?


Support for Redis clusters

I have a Redis cluster on AWS elasticache and using request.redis.get in order to retrieve cached data results on MOVED <IP address> errors which are the way Redis tell its clients should ask other node about this key.
Does this client implementation supports Redis clusters, is it in the future directions?

@yuriferretti The client currently does not support Redis Clusters.
Please file an issue against RediStack


Non-causal implementation of language model for synthetic datasets

Regarding synthetic datasets: from the implementation and as it explained in the issue, train loss is evaluated on all tokens and test is only evaluated on the last token . Then my question is what is the advantage of such autoregressive training strategy, which require the model to be causal, rather than simply modelling the training as a  classification problem, i.e. loss and accuracy of training is evaluated only on the last token as such that
$p({y}[..., -1]) \simeq  Hyena(x) [..., -1]$
If we follow this training approach then the target is estimated based on all the token in the sentence and,  it seems that, it is not required for the model to be causal for datasets: Associative Recall and induction head, is it trues?

This synthetic was designed to figure out the gap on causal language
modeling and was originally used for a state space model (H3) which is
naturally causal by design. We wanted the synthetic to match the actual
language task as closely as possible. We used a similar synthetic when
designing Monarch Mixer, but non causal as that’s a BERT model.
On Wed, Nov 29, 2023 at 7:51 PM Mahdi Karami @.***>
wrote:

Regarding synthetic datasets: from the implementation and as it
explained in the issue https://github.com/HazyResearch/safari/issues/35,
train loss is evaluated on all tokens and test is only evaluated on the
last token . Then my question is what is the advantage of such
autoregressive training strategy, which require the model to be causal,
rather than simply modelling the training as a classification problem, i.e.
loss and accuracy of training is evaluated only on the last token as such
that
$p({y}[..., -1]) \simeq Hyena(x) [..., -1]$
If we follow this training approach then the target is estimated based on
all the token in the sentence and, it seems that, it is not required for
the model to be causal for datasets: Associative Recall and induction
head, is it trues?
—
Reply to this email directly, view it on GitHub
https://github.com/HazyResearch/safari/issues/42, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDDIIVD25NDWSVDH66FL3TYG77EHAVCNFSM6AAAAABAAQQFLGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTOOBSGIZDONI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

My intuition is that the next-token prediction actually makes it easier for the model to learn the circuit it needs to do associative recall, since there's more tokens it needs to predict correctly during training (roughly the second half of the tokens, once it's seen each example once). You can see this when the training accuracy jumps around the same time that the test accuracy jumps - it's learned a generalizable behavior, not just a shortcut.

For the M2-BERT synthetics, we ran a non-causal form of associative recall to fine-tune the architecture.
For induction head - the same analogy applies for what we implemented here, but you're right that the setup is a bit different.


Microsoft.AspNet.FriendlyUrls usage ? are you using in asp.net webform and porting to .net core would help ?

If you are using add a 👍 reaction to this comment. If you are not using, kindly ignore.

Let's see if we can run the library itself on top of this project with WebForms.SystemWebShim


Fix #2180: Fix java.lang.Character.isWhitespace.

Review by @sjrd

LGTM

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2777/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3577/
Test PASSed.


[BACKLOG-29210] Snowflake DW Manager.

Adding common UI controls to be shared across multiple plugins.

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'ui' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'ui' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  ui/src/main/java/org/pentaho/di/ui/core/widget/WidgetBuilder.java
  ui/src/main/java/org/pentaho/di/ui/job/entry/JobEntryDialog.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

:new: org.pentaho.di.ui.core.widget.WidgetBuilder

Coverage: 0% :exclamation:

:new: org.pentaho.di.ui.core.widget.WidgetBuilder.Templates

Coverage: 0% :exclamation:

org.pentaho.di.ui.job.entry.JobEntryDialog

Branch Change: -2.9% :small_red_triangle_down:
Complexity Change: -3.9% :small_red_triangle_down:
Instruction Change: -6.3% :small_red_triangle_down:
Line Change: -7.7% :small_red_triangle_down:
Method Change: -5.2% :small_red_triangle_down:

License header violations

:heavy_exclamation_mark: Copyright year is not the current year on ui/src/main/java/org/pentaho/di/ui/job/entry/JobEntryDialog.java. Found 2017. Was expecting 2019

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'ui' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'ui' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  ui/src/main/java/org/pentaho/di/ui/core/widget/WidgetBuilder.java
  ui/src/main/java/org/pentaho/di/ui/job/entry/JobEntryDialog.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

:new: org.pentaho.di.ui.core.widget.WidgetBuilder

Coverage: 0% :exclamation:

:new: org.pentaho.di.ui.core.widget.WidgetBuilder.Templates

Coverage: 0% :exclamation:

org.pentaho.di.ui.job.entry.JobEntryDialog

Branch Change: -2.9% :small_red_triangle_down:
Complexity Change: -3.9% :small_red_triangle_down:
Instruction Change: -6.3% :small_red_triangle_down:
Line Change: -7.7% :small_red_triangle_down:
Method Change: -5.2% :small_red_triangle_down:

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'ui' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'ui' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  ui/src/main/java/org/pentaho/di/ui/core/widget/WidgetBuilder.java
  ui/src/main/java/org/pentaho/di/ui/job/entry/JobEntryDialog.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
:new: org.pentaho.di.ui.core.widget.WidgetBuilder

Coverage: 0% :exclamation:

:new: org.pentaho.di.ui.core.widget.WidgetBuilder.Templates

Coverage: 0% :exclamation:

org.pentaho.di.ui.job.entry.JobEntryDialog

Branch Change: -2.9% :small_red_triangle_down:
Complexity Change: -3.9% :small_red_triangle_down:
Instruction Change: -6.3% :small_red_triangle_down:
Line Change: -7.7% :small_red_triangle_down:
Method Change: -5.2% :small_red_triangle_down:


Repeat: variable name and value switched

User feedback:
"Hey Matt, coincidentally I tried out the repeat functionality this week, and think there's a bug when saving the configuration in the entry. The stop repeating variable name and optional variable value field values get switched over on pressing the ok button..."

0.9.0


Problem combining memory mapped arrays on the same file

Hi, I'm opening a new issue for the same exact problem as #4920 (GitHub won't let me reopen that one). The attempted solution was in PR #4931. It was to change has functions so that Dask's tokenize function gave different values for the two different numpy memmaps on different parts of the same file. While they do now have different tokenize values, the original problem remains (using dask 2.3.0). I am happy to try to fix this if someone can point me in the right direction. I've copied the original text of my issue below for convenience.
I have a large binary file that contains several chunks of data that I'd like to combine into a single multidimensional array, without having to immediately read all of these chunks into memory. My strategy for doing so is is to use np.memmap to create multiple memory-mapped arrays which are views different parts of the same binary file. Then, I use da.stack to make these part of the same dask array. However, when I then try to access the data in the dask array, it copies the second memory-mapped array twice instead of doing the first and then the second.
import dask.array as da
import numpy as np

#create a file with 10 random bytes
file = open('demo_data', 'wb')
file.write(b'ashekwicht')
file.close()

#open the file and read the bytes the bytes we just wrote
file = open('demo_data', 'rb')
first10 = np.frombuffer(file.read(10), np.uint8)
print('The first 5 bytes of the file are: {}'.format(first10[:5]))
print('The next 5 bytes of the file are: {}'.format(first10[5:]))

#now create two memory mapped views into the same file
mmap1 = np.memmap(file, dtype=np.uint8, mode='r', offset=0, shape=5)
mmap2 = np.memmap(file, dtype=np.uint8, mode='r', offset=5, shape=5)

#combine them with dask and read the 10 bytes again
dask_array = da.stack((mmap1, mmap2))
print('First 5 byte values {}'.format(np.array(dask_array[0, :])))
print('Next 5 byte values {}'.format(np.array(dask_array[0, :])))

Wait, actually just realized there is a typo in that example, and it does work as expected. However, there is still a problem with my application...will try to make another example that illustrates this

After looking at it some more, it seems the problem was that the tokenize function wasn't behaving correctly when slicing into memmapped arrays. Reproducing example below:
import dask.array as da
import numpy as np
from dask.base import tokenize

# create a file with 10 random bytes
file = open('demo_data', 'wb')
size = 100
rand_bytes = np.random.bytes(size)
file.write(rand_bytes)
file.close()

#open the file and read the bytes the bytes we just wrote
file = open('demo_data', 'rb')

#now create two memory mapped views into the same file
img1 = np.memmap(file, dtype=np.uint8, mode='r', offset=0, shape=10)
img2 = np.memmap(file, dtype=np.uint8, mode='r', offset=size // 2, shape=10)
array1 = img1[3:-3]
array2 = img2[3:-3]

print(tokenize(array1) == tokenize(array2))


nvim +PackerSync +qall does nothing

Run nvim +PackerSync +qall and I get nothing but a screen flash. The plugins are not downloaded.

https://github.com/junegunn/vim-plug/issues/225

Workaround
nvim +PackerSync +30sleep +qall

That is indeed the case, because PackerSync seems asynchronous so nvim will quit immediately.

@FrankFang  A better way to deal with asynchronous nature of Packer command, see https://github.com/jdhao/nvim-config/issues/31.


Cannot visit demo web page

Ask help for my demo
Hey, guys. I deploy the simple demo on my server, and then use 'export FLASK_APP=demo.py' , 'flask run --host=<IP_ADDRESS>' to launch the program.
However, I have tried every possible way to visit my web page, but failed all the same. It shows time out. I'm waiting sincerely for your help!!
My code:
from flask import Flask
app = Flask(__name__)

@app.route('/')
def hello_world():
   return 'Hello, World!'

if __name__ == '__main__':
   app.run( host='<IP_ADDRESS>',port=5000)

Note:

I am sure there firewall(iptables) is closed on my server.
I used Chrome to visit the web page, and got the result time out.

Please use Stack Overflow for questions about your own code. This tracker is for issues related to the project itself. Be sure to include a minimal, complete, and verifiable example.


HOTDIX: fix .travis.yml syntax for conditional deployments

Was silently missing on: section :(
https://docs.travis-ci.com/user/deployment/#conditional-releases-with-on

Merging as a hotfix


Poor UI performance with lots of workflows viewing all. Random sort order when viewing paginated.

Summary
When viewing 100's of workflows paginated, the sort order doesn't seem to make sense. When viewing all workflows, the load time is very high.
Diagnostics
What Kubernetes provider are you using? GKE
What version of Argo Workflows are you running? 2.11.7
I am using a Postgres database to archive workflows as well. When I view workflows in the list, I can select all in which case it takes around 13 seconds to load the listing and is appropriately sorted. When using paginated sorting, it loads quickly but it seems quite random which workflows are on each page.
I see the message Workflows cannot be globally sorted when paginated
Is this "It is what it is.." type issue? Since I am archiving all workflows, is is possible to pull the listing from the database instead in the proper order?

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

When viewing 100's of workflows paginated, the sort order doesn't seem to make sense.

This is known. We use K8s' pagination and simply propagate its result, and K8s pagination does not have "global sorting" between pages. See https://github.com/argoproj/argo/issues/2926.

Is this "It is what it is.." type issue?

For now, yes.

Since I am archiving all workflows, is is possible to pull the listing from the database instead in the proper order?

That would actually be the intended use case. Ideally the live workflows view is meant for recent workflows. Those workflows would then have short TTLs after completion and if their information is needed afterwards, it would be available in the workflow archive.
Is there a reason why you need to persist a large number of workflows after they are completed?

Okay... This makes sense... I guess I didn't follow that I need to make sure my jobs get archived after a certain amount of time to remove them from the list. I am still learning.
So, for others...  I added this to my configmap so there is a TTL automatically applied to all of my workflows and that list now has only workflows from the past hour. It's safe to use the all option which sorts correctly (assuming you have a sane number of workflows from the past hour)
   workflowDefaults:
    spec:
      ttlStrategy:
        secondsAfterCompletion: 3600

And then I can use the Workflow Archive section which loads data from my postgres database quite quickly and in the right order.
Thanks!

@simster7 do you think it would be a good idea to set some sort of sane workflow TTL default (24 hours)? I am starting to wonder if poor performance of my cluster/kubectl CLI was due to so many workflows sitting in etcd. It was not at all clear to me that I should be clearing out old workflows manually. I probably missed it in the docs somewhere. Just food for thought.

We actually have nudges in the UI that display this information (#3089)

Do you use the UI? I'm thinking that we should also add nudges on the CLI. I'll work on that soon.

do you think it would be a good idea to set some sort of sane workflow TTL default (24 hours)

It might be useful, but I don't think we'd want to add code that deletes K8s resources without the user taking an explicit action to enable it. Especially since the workflow archive may not be enabled so information could be lost

@simster7 I saw the nudge in the UI about the number of workflows and I checked the link to the documentation. I guess I didn't read it well enough... Up until this point I didn't follow that there was the "active workflows" vs the "workflow archive" being two different holding tanks that you need to somewhat manually manage the transition between. My suggestion would still be a sane default for archiving.. The confusion between "where did my workflow go?" vs "my cluster is running like crap and it's really slow to load" Although I guess if you don't have an archive then it becomes another issue. I dunno...

@simster7 how about this #4549

Do we have a docs section of known issues and limitations?
Maybe we should add to the operator manual a section for it and include this issue as I think many users would hit that problem.
WDYT?

We use K8s' pagination and simply propagate its result, and K8s pagination does not have "global sorting" between pages. See #2926.

Noting here that server-side sorting should be possible after #12736 (running an in-memory SQLite DB)


[Bug] Trademark Policy uses term "contrast ratio" without defining it

Description
The Trademark Policy says:

You are not authorized to use any modified versions of our trademarks, except that you may use a different color for the CC logo and its background so long as the two colors chosen have a contrast ratio of at least 3:1.

But what ratio do you mean? For web use, do we …

… just add up the 8-bit RGB components of each color and then divide?
… realize that the amount of illumination corresponding to those RGB components isn't actually linear, but something much closer to sRGB, so convert to CIEXYZ color space?
… remember that human perception isn't linear, so convert to e.g. CIELAB color space instead?

… and what about viewing conditions?
I suppose we could try to use the definition at https://www.w3.org/TR/WCAG21/#dfn-contrast-ratio, but see https://github.com/w3c/wcag/issues/695 for why that might not be the best plan.
And what about usage in print?
In conclusion: (╯°□°）╯︵ ┻━┻. It might be better to forget about defining things for now, and just say something like "but please choose colors with plenty of contrast".
Resolution

[ ] I would be interested in resolving this bug.

You guys will never understand people like me. I have a life, a family, a body and mind. All these years, you and me are like 1 bots even though the development of the system is proven by technology.  how  I was born in Thailand  Lord of the land, you have created a contracted media channel that is accepted as the first in the world.  He made and placed a hidden secret that......can't tell.  Throughout the past 11-12 years  Loyalty has nothing to do with it.  I began to run out of potential and angry with the group of people who possession of the rights, with my rights.  as a secondary mouse until I  began to end with a strong military force  Security orders, rights in various contracts, I have the right.  But you don't have the right to treat me unhel

[ ] pfully like this.  or let me  Fight against cyber defenses as human beings, with only a few claimants.  Some places have been modified by government agencies to change the route of the system.  They say that I'm thin, crippled, thin, childish, but that reality doesn't apply to this world.  Which I supported to spread to spread each other in the progress of the problems of various countries that have a bachelor's demonic, protection that I protected, investing, receiving the rights that I am in the technology system that you never know that I have  identity  They have a different understanding of each other, or someone has claimed the benefits that I have not yet given to anyone to act on my behalf.  But I tried to cry out for help)

You guys will never understand people like me. I have a life, a family, a body and mind. All these years, you and me are like 1 bots even though the development of the system is proven by technology.  how  I was born in Thailand  Lord of the land, you have created a contracted media channel that is accepted as the first in the world.  He made and placed a hidden secret that......can't tell.  Throughout the past 11-12 years  Loyalty has nothing to do with it.  I began to run out of potential and angry with the group of people who possession of the rights, with my rights.  as a secondary mouse until I  began to end with a strong military force  Security orders, rights in various contracts, I have the right.  But you don't have the right to treat me unhelpfully like this.  or let me  Fight against cyber defenses as human beings, with only a few claimants.  Some places have been modified by government agencies to change the route of the system.  They say that I'm thin, crippled, thin, childish, but that reality doesn't apply to this world.  Which I supported to spread to spread each other in the progress of the problems of various countries that have a bachelor's demonic, protection that I protected, investing, receiving the rights that I am in the technology system that you never know that I have  identity  They have a different understanding of each other, or someone has claimed the benefits that I have not yet given to anyone to act on my behalf.  But I tried to cry out for help.


Updated ESlint command

Extends #37 A small command mistake was done in the previous documentation update.
I found this error when I was rechecking all the documentation is correct and the commands are working properly.

Codecov Report

Merging #39 (702c072) into main (56a2a9b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   97.05%   97.05%
=======================================
  Files           5        5
  Lines          34       34
  Branches        1        1
=======================================
  Hits           33       33
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a2a9b...702c072. Read the comment docs.


MD037 line break not supported

Hi,
Since 0.20.0, error MD037/no-space-in-emphasis (Spaces inside emphasis markers [Context: "* *"]) is displayed for this code:
*one
two* *three*

I think the line break are not supported.

Sorry about that! I rewrote this rule and probably introduced this problem. I thought I had tests for multi-line, but they may not be good enough. I’ll have a look soon.

Definitely my bug and a regression. I have something better working now and hope to publish a patch this evening.


Could I query the event data through event.payload data such as parent.event.payload?

Could I query the event data through event.payload data such as event.payload.parent?
give an example?

store.findEvents({payload:{parent:["parentA","parentB"]}} ... )  ?

no