Multiple ssm maintenance windows for single schedule

I am trying to create a schedule which spans across instances which have different maintenance windows. For example: We have 10 windows instance which have maintenance windows of 4 hours over weekend and 5 linux instances which have 1 hour maintenance window out of office hours. Can i add these two maintenance windows under single schedule in below format ?
{
  "type": {
    "S": "schedule"
  },
  "name": {
    "S": "UK-OfficeHours"
  },
  "description": {
    "S": "Office hours in UK Mon-Fri"
  },
  "enforced": {
    "BOOL": false
  },
  "hibernate": {
    "BOOL": false
  },
  "periods": {
    "SS": [
      "UK-OfficeHours-period"
    ]
  },
  "retain_running": {
    "BOOL": false
  },
  "ssm_maintenance_window": {
    "S": "ec2-maintenance-linux,ec2-maintenance-windows"
  },
  "stop_new_instances": {
    "BOOL": true
  },
  "timezone": {
    "S": "Europe/London"
  },
  "use_maintenance_window": {
    "BOOL": true
  }
}

Please Advice.
Thanks

Hi @Rithvik-Reddy-10
Schedules currently only support a single ssm_maintenance_window per schedule so you would need to create a separate schedule for your windows and linux instances.
Even if the scheduler did support it, I would still recommend creating separate schedules so that you can avoid errantly starting (and paying for) your linux instances during the windows maintenance window and vice-versa

i agree it would be useful to configure multiple maint windows in the same schedule.  another alternative would be to look for the maint window that applies to that ec2 and start it.  otherwise we have to create multiple schedules with different tags which can confuse some users if they happen to tag the instance with the wrong schedule that doesn't correspond to the maint window.

We do not have plans to support this feature in the solution.


Set up app to render templates

As a user, I want to be able to view the home and dashboard pages in the browser

done and pushed


libkbfs: Handle GetForTLF returning an empty result in folder branch ops

Spotted in wild.

Hmm, this is a bit strange, because if the user already has an unmerged MD update, by definition there needs to be a merged one that it conflicted against, to exist in the first place.
I wrote more details in the JIRA ticket.

Closing for archival.


what is the meaning of the dport_refresh parameter?

Is d an abbreviation for destination?
这里的d是否是destination的缩写词？
Based on the above guesses, I think that dport_refresh refers to the refresh interval of the UDP target port, is my understanding correct?
基于以上猜测，我认为dport_refresh指的是udp目标端口刷新的时间间隔，我的理解是否正确？
I'm also wondering, why would flushing the destination port be considered, rather than modifying the source port?
我还想知道，为什么会考虑刷新目标端口，而不是修改源端口？

Both kcptube and udphop have the same meaning for "dport_refresh": it can be either a destination or dynamic.
无论是 kcptube 还是 udphop，这个 dport_refresh 的意思都是一样的：既可以是 destination，又可以是 dynamic。
I have mentioned in https://www.v2ex.com/t/956158 under ‘features’: ‘unconditional port jumping (even when the server is in single-port mode, the client still changes the sending port).’
我在 https://www.v2ex.com/t/956158 列出“特点”时就提到过：“无条件端口跳跃（服务器单端口模式时客户端照样更换发送端口）”
In other words, the source port of the client will always be changed.
换句话说，客户端的源端口一定会更换的。
There is one difference between kcptube and udphop — dport_refresh=0 can be set in kcptube to completely disable port refreshing. Once disabled, no ports will be changed anymore.
相较于 udphop，kcptube 有个不同之处——可以设置 dport_refresh=0 彻底禁用端口刷新，禁用后就不再更换任何端口了。


Feature request: make it possible to go back/forward with either hotkeys or mouse navigation buttons

Checklist:

[X] I have checked that there are no issues with similar or the same content

[X] I have checked the FAQ (https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/FAQ) and the answer I am looking for is not there

[X] I have double checked and can reproduce the issue

OS:
CentOS Linux release 7.4.1708 (Core)
GPMDP Version:
google-play-music-desktop-player-4.6.0-1.x86_64
Issue Descriptions:
There seems to be no way to navigate back (and forward for that matter) within the player. In the normal web browser version of Play Music (and I suspect YT Music also) you can use navigation buttons from the browser, Alt+Left/Right Arrow hotkey, or back/forward buttons from a mouse with navigational buttons on it. All of that works in a normal browser.
Steps to Reproduce:
If you have a mouse with "back & forward" navigation buttons, you could try them and they wouldn't work.
Alternatively, the standard hotkey of Alt+Left/Right Arrow to navigate back and forward that works in any common browser, does not work also.
In a few browsers, the Backspace key goes back one page. It doesn't do anything in the player.

Fixed in master

To follow up, this is all already implemented, but broken in 4.6.0. 4.6.1 will have this fixed.

Great! Looking forward to using it.


Added delay message functionality

Added the possibility to delay message

Hey, just curious as to why you closed this? I haven't been able to test this yet but I'm sure I tried something similar a while back and it didn't have the effect I was hoping... is that what's happened now?

Hi, I didn't test it enough so I found a misstake. Please look at my updated pull request.


Fix bug related to disabling TSan tests on 32-bit platform.

@swift-ci please smoke test and merge


allow dig ansible lookups

trying an ansible filter of lookup('dig'...) fails without python-dns RPM

👍 #2437 in stg


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-30-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4806

Questions ?
Please refer to the Backport tool documentation


Website

Website Development, See https://github.com/apj520/ENG1Team13.github.io for details. Please note this is hosted in a different repository to the rest of the project for legacy reasons.


Update KMeansExample.scala

What changes were proposed in this pull request?
example does not work wo DataFrame import
How was this patch tested?
example doc only
example does not work wo DataFrame import

Can one of the admins verify this patch?

Jenkins test this please

Test build #55460 has started for PR 12277 at commit 4150863.

Test build #55460 has finished for PR 12277 at commit 4150863.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55460/
Test PASSed.

Looks correct to me.


sim,mem,cpu,arch-arm: Add support for cache PMU events

See individual commits for details.
This was rather tricky to figure out - I noticed I could not check the dynamic type of the connected probes since we were calling virtual functions on partially constructed objects.

Wow this looks like an amazing contribution.
As it is touching non arch-arm code as well, can I ask you to amend the PR title? So that other people can chime in if interested on reviewing this

@studyztp can you review this change with respect to the probe changes? You just spent a bunch of time writing the documentation for probes so I think you would be a great person to take a look at this part of the change.

@arichardson, this is a great work! I looked over all the changes. Most of them make senses to me. I just want to discuss about a few things. Sorry for the out of order comments. I did not realize that my review will be publish immediately :)

Hi @arichardson
I didn't do a full review of the PR. It generally looks fine, however I am a bit concerned we are adding extra abstractions which might not be fully necessary
The concept of Probe and Listener is quite straightforward per se. You are adding the ProbeConnection abstraction and as far as I can see it is simply adding an indirection to a listener. Do we really need that?
class ProbeConnection
{
  public:
    ProbeConnection(ProbeManager* _manager,
               std::unique_ptr<ProbeListener> _listener);
    ~ProbeConnection();
    ProbeConnection(const ProbeConnection& other) = delete;

 protected:
    std::unique_ptr<ProbeListener> listener;
    ProbeManager* manager;
};

You solve the partially construct problem by splitting the Listener construction and Listener connection in two steps within the connect method in the probe manager
template<typename Listener, typename... Args>
ProbeConnectionPtr connect(Args&&... args)
{
    return std::make_unique<ProbeConnection>(
        this, std::make_unique<Listener>(std::forward<Args>(args)...));
}

Can't we just do this without defining an intermediate object? The ProbeConnector constructor is anyway calling the manager addListener method, so we have
ProbeManager::connect -> calls -> ProbeConnection::ProbeConnextion-> calls -> ProbeManager::addListener....
IMHO we could call addListener within the connect method straight away and return the listener ptr directly... Please let me know your thought and if there's something I am missing

The reason I added the intermediate object is that I didn't see an easy solution to avoid the virtual function call from within the constructor without this indirection. It basically guarantees that we have fully constructed the listener before calling addListener(). Otherwise we end up passing a partially constructed object and that is dangerous.
There might be a cleaner solution, but this seemed like a reasonable approach to me.

@arichardson, this is a great work! I looked over all the changes. Most of them make sense to me. I just want to discuss a few things. Sorry for the out-of-order comments. I did not realize that my review would be published immediately :)

Hi, I believe your github comments were not published. Probably need to click on finish review?

Hi @arichardson
I didn't do a full review of the PR. It generally looks fine, however I am a bit concerned we are adding extra abstractions which might not be fully necessary
The concept of Probe and Listener is quite straightforward per se. You are adding the ProbeConnection abstraction and as far as I can see it is simply adding an indirection to a listener. Do we really need that?
class ProbeConnection
{
  public:
    ProbeConnection(ProbeManager* _manager,
               std::unique_ptr<ProbeListener> _listener);
    ~ProbeConnection();
    ProbeConnection(const ProbeConnection& other) = delete;

 protected:
    std::unique_ptr<ProbeListener> listener;
    ProbeManager* manager;
};

You solve the partially construct problem by splitting the Listener construction and Listener connection in two steps within the connect method in the probe manager
template<typename Listener, typename... Args>
ProbeConnectionPtr connect(Args&&... args)
{
    return std::make_unique<ProbeConnection>(
        this, std::make_unique<Listener>(std::forward<Args>(args)...));
}

Can't we just do this without defining an intermediate object? The ProbeConnector constructor is anyway calling the manager addListener method, so we have
ProbeManager::connect -> calls -> ProbeConnection::ProbeConnextion-> calls -> ProbeManager::addListener....
IMHO we could call addListener within the connect method straight away and return the listener ptr directly... Please let me know your thought and if there's something I am missing

The reason I added the intermediate object is that I didn't see an easy solution to avoid the virtual function call from within the constructor without this indirection. It basically guarantees that we have fully constructed the listener before calling addListener(). Otherwise we end up passing a partially constructed object and that is dangerous.
There might be a cleaner solution, but this seemed like a reasonable approach to me.

Essentially, this ProbeConnection class is just a std::unique_ptr, but instead of causing undefined behaviour by calling {add/remove}Listener in the {con/de}structor it calls those methods while the object is in a fully constructed state.

Hi @arichardson
I didn't do a full review of the PR. It generally looks fine, however I am a bit concerned we are adding extra abstractions which might not be fully necessary
The concept of Probe and Listener is quite straightforward per se. You are adding the ProbeConnection abstraction and as far as I can see it is simply adding an indirection to a listener. Do we really need that?
class ProbeConnection
{
  public:
    ProbeConnection(ProbeManager* _manager,
               std::unique_ptr<ProbeListener> _listener);
    ~ProbeConnection();
    ProbeConnection(const ProbeConnection& other) = delete;

 protected:
    std::unique_ptr<ProbeListener> listener;
    ProbeManager* manager;
};

You solve the partially construct problem by splitting the Listener construction and Listener connection in two steps within the connect method in the probe manager
template<typename Listener, typename... Args>
ProbeConnectionPtr connect(Args&&... args)
{
    return std::make_unique<ProbeConnection>(
        this, std::make_unique<Listener>(std::forward<Args>(args)...));
}

Can't we just do this without defining an intermediate object? The ProbeConnector constructor is anyway calling the manager addListener method, so we have
ProbeManager::connect -> calls -> ProbeConnection::ProbeConnextion-> calls -> ProbeManager::addListener....
IMHO we could call addListener within the connect method straight away and return the listener ptr directly... Please let me know your thought and if there's something I am missing

The reason I added the intermediate object is that I didn't see an easy solution to avoid the virtual function call from within the constructor without this indirection. It basically guarantees that we have fully constructed the listener before calling addListener(). Otherwise we end up passing a partially constructed object and that is dangerous.
There might be a cleaner solution, but this seemed like a reasonable approach to me.

Essentially, this ProbeConnection class is just a std::unique_ptr, but instead of causing undefined behaviour by calling {add/remove}Listener in the {con/de}structor it calls those methods while the object is in a fully constructed state. And I agree, we could call addListener in the connect method, but I'm not sure calling removeListener with a partially destructed object is actually legal C++.

Hi @arichardson
I didn't do a full review of the PR. It generally looks fine, however I am a bit concerned we are adding extra abstractions which might not be fully necessary
The concept of Probe and Listener is quite straightforward per se. You are adding the ProbeConnection abstraction and as far as I can see it is simply adding an indirection to a listener. Do we really need that?
class ProbeConnection
{
  public:
    ProbeConnection(ProbeManager* _manager,
               std::unique_ptr<ProbeListener> _listener);
    ~ProbeConnection();
    ProbeConnection(const ProbeConnection& other) = delete;

 protected:
    std::unique_ptr<ProbeListener> listener;
    ProbeManager* manager;
};

You solve the partially construct problem by splitting the Listener construction and Listener connection in two steps within the connect method in the probe manager
template<typename Listener, typename... Args>
ProbeConnectionPtr connect(Args&&... args)
{
    return std::make_unique<ProbeConnection>(
        this, std::make_unique<Listener>(std::forward<Args>(args)...));
}

Can't we just do this without defining an intermediate object? The ProbeConnector constructor is anyway calling the manager addListener method, so we have
ProbeManager::connect -> calls -> ProbeConnection::ProbeConnextion-> calls -> ProbeManager::addListener....
IMHO we could call addListener within the connect method straight away and return the listener ptr directly... Please let me know your thought and if there's something I am missing

The reason I added the intermediate object is that I didn't see an easy solution to avoid the virtual function call from within the constructor without this indirection. It basically guarantees that we have fully constructed the listener before calling addListener(). Otherwise we end up passing a partially constructed object and that is dangerous.
There might be a cleaner solution, but this seemed like a reasonable approach to me.

Yes it is more than reasonable and it is also clean. I am just being concerned about introducing new abstractions. Also lots of members are still called listeners even if they hold a vector of connection pointers. What I was proposing was something like the following
template<typename Listener, typename... Args>
std::unique_ptr<Listener> connect(Args&&... args)
{
    auto listener = std::make_unique<Listener>(std::forward<Args>(args)...));
    addListener(listener->getName(), *listener);
    return std::move(listener);
}

(Note we might want to rename connect method in that case). I am not sure my implementation is better than yours. Using ConnectionPtr might have some other advantages so I am not going to push strongly against ProbeConnection. I am more interested on hearing your thoughts over my semplification

Hi @arichardson,
Thank you for the contribution, could you please update us on the status of this PR?

Hi @arichardson,
Thank you for the contribution, could you please update us on the status of this PR?

Sorry I've been caught up on other projects for the past month, will try to address the comments shortly

@arichardson Hello, could you provide another update on what the status of this PR is? Thank you!

@odanrc


AIP-192: Blank lines between fields with comments?

This is both a question and a feature request. We see a lot of people doing the following:
// c1
string f1 = 1;
// c2
string f2 = 2;

AIP-192 is not clear on this and AIP-191 does not cover this either. The language guide also does not cover this, nor does the style guide.
The question is if this is actually a problem. As far as I understand the Protobuf standard the c2 comment could be considered part of a trailing comment for f1. My searches for this only turned up with other people asking themselves the same question (https://github.com/square/protoparser/issues/84#issuecomment-104130555). Right now we ask people to add a line …
// c1
string f1 = 1;

// c2
string f2 = 2;

… but doing so on every pull request is not feasible and prone to human error/oversight. Should this not be covered by the linter?

I'd recommend opening an issue with protobuf.
Until that is done/resolved, I think it's best that we not take a stance on this. I'm going to close this for now, but I'm happy to reopen it once we have a clearer direction. Thanks for your question.


Can't use ita.traineddata

While using ita.traineddata I get this error message:

read_params_file: parameter not found:

I'm using tesseract 4.1 on Ubuntu 19.04
$ tesseract --version
tesseract 4.1.0
 leptonica-1.78.0
  libgif 5.1.4 : libjpeg 8d (libjpeg-turbo 2.0.1) : libpng 1.6.37 : libtiff 4.0.10 : zlib 1.2.11 : libwebp 0.6.1 : libopenjp2 2.3.0
 Found AVX2
 Found AVX
 Found SSE

Please write command you used.

I found that is my fault:
My application is using a static compiled libtesseract.so.3.0.4 in place the dynamic 4.1 in my system, so I was using a non-legacy supporting trained data with an old engine.
I recently switched from tessdata to tessdata_best so I guessed the problem was with trained data, my bad.


Advisory 99 should allow v1.6.9 of engine.io-client

Release 1.6.9 contained the fix described in Advisory 99. I find the same with a freshly installed copy
dougwade /tmp » grep "rejectUnauthorized ===" node_modules/engine.io-client/engine.io.js
  this.rejectUnauthorized = opts.rejectUnauthorized === undefined ? true : opts.rejectUnauthorized;
dougwade /tmp » npm i engine.io-client

However, the nsp vulnerability range (<= 99.999.99999 || <= 1.6.8) doesn't allow it.

Thanks for the report. We had not received reports back that it was addressed yet. I went ahead and updated the versions in the advisory.


[Feat] run func timeout use std::time::Duration

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


trace_get

Signed-off-by: Mark Terry<EMAIL_ADDRESS>PR description
Implementation for trace_get API.

exclude revertReason from result (matches Besu trace_call and openethereum)

Note this implementation matches openethereum behaviour except for:

we manually added creationMethod to test files even though openethereum 3.2.5 does not include this field (this matches Besu trace_transaction implementation which also includes the creationMethod field)

See #2889
Changelog

[ ] I thought about the changelog and included a changelog update if required.

The unit tests failures are explained by: the version of openethereum which generated these test files (3.2.5 installed via homebrew) doesn't have this patch https://github.com/openethereum/openethereum/issues/114

regarding the revert reason I think it was added voluntarily even if OE does not manage it. We should ask @shemnon  if he has more context on it.

if creationMethod is not needed in this case why we are not using this field ? https://github.com/hyperledger/besu/blob/b0de73fe57bfd8c398939b8e7edef577dd773e04/ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/tracing/flat/FlatTraceGenerator.java#L233

regarding the revert reason I think it was added voluntarily even if OE does not manage it. We should ask @shemnon if he has more context on it.

for revert reason we have decided to leave as is for now, and made a new ticket #3515 to revisit it.

if creationMethod is not needed in this case why we are not using this field ?
https://github.com/hyperledger/besu/blob/b0de73fe57bfd8c398939b8e7edef577dd773e04/ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/tracing/flat/FlatTraceGenerator.java#L233

we decided to include this extra field based on conversation with @mbaxter who is waiting for these APIs to be implemented.


fix: remove trim _pxx

This should fix for some pictures titled end with _xxx, e.g. https://www.pixiv.net/artworks/100345141
リコリス・リコイル_02.txt shouldn't be trimed to リコリス・リコイル.txt
However, I don't know why info_filename = re.sub(r'_p?\d+$', '', info_filename) code exists. I checked the commit history and found that this was added six years ago, I think it may be a historical problem

it is for manga images, if you don't remove it, the info file will contains _pxx

I 've tested both single image and manga images. I found that deleting this code did not change the output(except the bug that I mentioned), that's why I have that question

I used the default config
filenameFormat = %artist% (%member_id%)/%urlFilename% - %title%
filenameMangaFormat = %artist% (%member_id%)/%urlFilename% - %title%
filenameInfoFormat = %artist% (%member_id%)/%urlFilename% - %title%
filenameMangaInfoFormat = %artist% (%member_id%)/%urlFilename% - %title%

info_filename is end with %title%, and _pxx will be only trimed from %title% not from %urlFilename%
So all the manga information will be in the format id_pXX - title and _pXX won't be trimed


WIP: feat(optimizer): add apply filter&project rules

What's changed and what's your intention?
The current implementation may be incorrect: e.g., pull up seems only correct for cross join.
Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: xxchan:x: likg227You have signed the CLA already but the status is still pending? Let us recheck it.


Power outage to tuya devices makes homebridge unresponsive due to excessive logging

Checklist

[ x ] I have read the common issues wiki page
[ x ] I have checked to make sure the plugin is up to date

Describe the bug
If a tuya device on homebridge loses power / connectivity, homebridge becomes unresponsive and requires force restart.
To Reproduce
Steps to reproduce the behavior:

Add and configure Tuya devices. In my case, it was a 16A smart plug and a 12W light bulb. I have more devices added to homebridge but all those have power backup.
Disconnect power to the devices.
Watch homebridge logs for continuous errors.
After few mins (say 15 mins), give the power back to the devices.
The logs in homebridge still keep logging in.
Restarting homebridge becomes unresponsive.
Force reboot raspberry pi to fix the problem.

Expected behavior
It can log errors, but only periodically. It shouldn't make homebridge unresponsive due to excessive logging.
Screenshots
Couldn't take screenshots. Had to force reboot Raspberry Pi 4B with 4GB RAM. If this happens again, will take screenshots and update it here.
Environment (please complete the following information):

OS: HOOBS 3.2.6
iOS version: 14.0
Homehubs: -
Node Version:  12.16.3
Plugin Version: 1.0.5
Accessory Type: Smart plug and Smart bulb

Hi there, this is a known issue, and will be patched in the next release. I'm going to release it as part of V1.x instead of V2.

not sure if this is related, but after i updated the plugin to the latest version, I'm getting thousands of log messages like:
[TuyaAccessory] Slowing down retry attempts; if you see this happening often, it could mean some sort of incompatibility.
[TuyaAccessory] Socket had a problem and will reconnect to Porch Lights (Error: ERR_CONNECTION_TIMED_OUT)
The plugin had been working perfectly up til then.  Note that I have also updated Homebridge to the latest released version (I think 1.2.0)
All my other plugins are working fine but i've had to remove all my Tuya accessories from the config.

If the original issue that @sasikiran reported is an "ECONNRESET storm" (see below) when powering on a Tuya accessory powered off more than about a minute ago, I experienced the same thing about a month ago while repurposing some outlet accessories and fixed it last week in my own copy of TuyaAccessory.js.
I don't know if I've made the correct fixes. The ECONNRESET storm in the logs is about 50 or more message pairs per second like this:
[TuyaAccessory] Sending first query to Driveway io-WiFi-Plug-PM 3 (3.3)
[TuyaAccessory] Socket had a problem and will reconnect to Driveway io-WiFi-Plug-PM 3 (ECONNRESET)

It happens for me only if you leave the accessory powered off long enough to get an ERR_CONNECTION_TIMED_OUT. The sequence where it starts looks like this:
[TuyaAccessory] Socket had a problem and will reconnect to Driveway io-WiFi-Plug-PM 3 (Error: ERR_PING_TIMED_OUT)
[TuyaAccessory] Socket had a problem and will reconnect to Driveway io-WiFi-Plug-PM 3 (EHOSTUNREACH)
[TuyaAccessory] Socket had a problem and will reconnect to Driveway io-WiFi-Plug-PM 3 (EHOSTUNREACH)
[TuyaAccessory] Socket had a problem and will reconnect to Driveway io-WiFi-Plug-PM 3 (EHOSTUNREACH)
[TuyaAccessory] Socket had a problem and will reconnect to Driveway io-WiFi-Plug-PM 3 (Error: ERR_CONNECTION_TIMED_OUT)
[TuyaAccessory] Socket had a problem and will reconnect to Driveway io-WiFi-Plug-PM 3 (EHOSTUNREACH)
[TuyaAccessory] Socket had a problem and will reconnect to Driveway io-WiFi-Plug-PM 3 (EHOSTUNREACH)
##########
# turned outlet back on here
#########
[TuyaDiscovery] UDP from <IP_ADDRESS>:6667 0x000055aa...0x0000aa55
[TuyaAccessory] Socket had a problem and will reconnect to Driveway io-WiFi-Plug-PM 3 (ECONNREFUSED)
[TuyaAccessory] Sending first query to Driveway io-WiFi-Plug-PM 3 (3.3)
[TuyaAccessory] Heard back from Driveway io-WiFi-Plug-PM 3 with command 10
[TuyaAccessory] Heard back from Driveway io-WiFi-Plug-PM 3 with command 8
[TuyaAccessory] Sending first query to Driveway io-WiFi-Plug-PM 3 (3.3)
[TuyaAccessory] Socket had a problem and will reconnect to Driveway io-WiFi-Plug-PM 3 (ECONNRESET)

My TuyaAccessory.js still includes some DEBUG log messages, as I'm not convinced I've really fixed it, despite it working repeatedly. These are the changes I made, and the console.log DEBUG statements can all be deleted with no functional impact:
56a57,58
>       console.log(
>           `[TuyaAccessory DEBUG] reconnect called for ${this.context.name}`);
66a69,73
>       if (this._socket._errorReconnect) {
>         clearTimeout(this._socket._errorReconnect);
>         this._socket._errorReconnect = null;
>       }
>
75a83,84
>       this._incrementAttemptCounter();
>
99c108,110
<       setTimeout(() => this._socket._ping(), 1000);
---
>       if (this._socket._pinger)
>         clearTimeout(this._socket._pinger);
>       this._socket._pinger = setTimeout(() => this._socket._ping(), 1000);
144a156,158
>         console.log(
>             `[TuyaAccessory DEBUG] Reconnecting with connection attempts =  ${
>                 this._connectionAttempts}`);
165c179,187
<       setTimeout(() => { process.nextTick(this._connect.bind(this)); }, delay);
---
>       if (!this._socket._errorReconnect) {
>         console.log(
>             `[TuyaAccessory DEBUG] after error setting _connect in ${delay}ms`);
>         this._socket._errorReconnect = setTimeout(() => {
>           console.log(`[TuyaAccessory DEBUG] executing _connect after ${
>               delay}ms delay`);
>           process.nextTick(this._connect.bind(this));
>         }, delay);
>       }
182c204,209
<     setTimeout(() => { this._connectionAttempts--; }, 10000);
---
>     setTimeout(() => {
>       console.log(
>           `[TuyaAccessory DEBUG] decrementing this._connectionAttempts, currently ${
>               this._connectionAttempts}`);
>       this._connectionAttempts--;
>     }, 10000);

This is the commit comment explaining my changes:
    To prevent a fast ECONNRESET loop when turning off an accessory and
    turning it back on more than a few minutes later, e.g. to move and
    re-purpose it, did the following:
    In _socket.on('error') recorded the _connect() Timeout in
    this._socket._errorReconnect and tested that value before setting
    another Timeout to prevent scheduling two _connect() calls;
    Added _errorReconnect to the list of Timeouts cleared in _connect();
    In this._socket.reconnect, incremented the Attempt Counter
    this._connectionAttempts just before the call to
    this._socket.connect(). The attempt counter was being incremented only
    on _connect(), not on reconnect;
    In _socket.on('connect'), cleared an existing pinger Timeout before
    setting another one;
    Added several DEBUG console.log statements to help trace what was
    happening and confirm the above changes worked.

@iRayanKhan apologies if this is being discussed elsewhere and has already been addressed, but can you take a look at the changes above and if it seems appropriate, incorporate this change?  I'm having the same issue.

Try 1.2.0

Try 1.2.0

This is still happening in v1.2

This is still happening in v1.2

I finally got around to opening a PR for this. #197


[rest] Configurable Extra Patterns in main.php broke url parameters

If you configure default expand #13864, it does not read url expand param anymore.
What steps will reproduce the problem?
Configure main.php with rule
				[
					'class' => 'yii\rest\UrlRule',
					'controller' => ['participant'],
					'ruleConfig' => [
						'class' => 'yii\web\UrlRule',
						'defaults' => [
							'expand' => 'user',
						]
					],
				],

And try go to the url: participants?expand=user,detail
What is the expected result?
User and detail are shown as extra field.
Without param, user is only shown as extra field.
What do you get instead?
User is shown as extra field.
Without param, the same, user is shown as extra field.
Additional info

Q
A

Yii version
<IP_ADDRESS>

PHP version
5.6.2

Operating system
Window 10

what does debug says? take an screenshot of the section 'Request' please

closing as no feedback is provided for a long time.


[CAMEL-15314] Maven tooling: make dsl static builders public in EndpointDslMojo

Call setPublic on methods used for the static builders in StaticEndpointBuilders (camel-endpointdsl)
(backport of #4046)

Thanks


Added Contributor's Page

Closes: #290
I have added contributor's page that is directly fetching the data from the repo dynamically.
https://github.com/user-attachments/assets/62e54fa9-9e11-4780-8810-7d38a95622c5

@soham0005 @PRathod27 , I have opened new PR with the changes.
Please review it. Can you label it with level 3 for my work?
Thank You!!

@PRathod27 , Check it now Sir

@PRathod27 , Check it now Sir

@TBorundia I'll merge It tomorrow. Or in case, other maintainers and PA will merge it.
Till now you have done a great work.
Happy Coding!

@PRathod27 , You have not assigned it and even not added the levels.
Can you please assign it with level 3 for my work.
Thank You!!

Ok let me correct it. Sorry for the inconvenience.

@TBorundia Labels have been added.
Thank you for your valuable contributions.
Happy Coding!


Unable to build generated typescript code

Hi,
When running npm build or yarn build within the root of the typescript-codegen directory, we get a few compile time errors:

This error repeats once for every operation in the specification.

src/commands/UpdateTransactionGeneratorCommand.ts:70:13 - error TS2339: Property 'logger' does not exist on type 'LedgerServiceClientResolvedConfig'.

70     const { logger } = configuration;
               ~~~~~~

Interface error

src/ts/commands/CreateAccountCommand.ts:67:45 - error TS2345: Argument of type 'LedgerServiceClientResolvedConfig' is not assignable to parameter of type 'SerdeContext'.
  Property 'endpoint' is missing in type 'SmithyConfiguration<HttpHandlerOptions> & Required<ClientDefaults>' but required in type 'SerdeContext'.

67     this.middlewareStack.use(getSerdePlugin(configuration, this.serialize, this.deserialize));

Any advice would be appreciated to correct these issues.

Which release of smithy-typescript-codegen are you using? We run a CI job in the JS SDK repository to make sure that a very simple model can generate and build: https://github.com/aws/aws-sdk-js-v3/blob/main/codegen/generic-client-test-codegen/build.gradle.kts
I don't have enough information to be certain yet, but my guess is either you're not including the AWS codegen library (software.amazon.smithy.typescript:smithy-aws-typescript-codegen), there's some sort of version mismatch, or the generator version is from before we attempted to ensure that non-AWS clients were functional.

Hi and thanks for your feedback on the matter!
I was simply following similar instructions to the readme on this repo, and the little bit I've learnt from using the Go code generators.
I have not included the smithy-aws-typescript-codegen dependency, as the readme only lists the smithy-typescript-codegen dependency. Specifically, the include line in our build.gradle.kts looks like this:
    implementation("software.amazon.smithy.typescript:smithy-typescript-codegen:0.8.0")

The smithy-typescript-codegen dependency I had to build and publish to the local maven repo myself (it could not resolve any public dependencies). I did this by checking out smithy-typescript and running pushd smithy-typescript-codegen && ./gradlew build which created the 0.8.0 artificat in my local maven repo. The commit I have is from January 11th 2022 (so fairly recent).
To be clear: generating the code works, but compiling the generating code does not (due to the error supplied in the first message of this issue).
Here is a complete copy of our build.gradle.kts:
// This example builds the model and places it in the JAR.

plugins {
    id("software.amazon.smithy").version("0.6.0")
}

repositories {
    mavenLocal()
    mavenCentral()
}

buildscript {
    dependencies {
        classpath("software.amazon.smithy:smithy-openapi:1.11.0")
        classpath("software.amazon.smithy.go:smithy-go-codegen:0.1.0")
        // classpath("software.amazon.smithy:smithy-aws-apigateway-openapi:1.11.0")
        // The openapi plugin configured in the smithy-build.json example below
        // uses the restJson1 protocol defined in the aws-traits package. This
        // additional dependency must added to use that protocol.
        classpath("software.amazon.smithy:smithy-aws-traits:1.11.0")
    }
}

dependencies {
    implementation("software.amazon.smithy:smithy-model:[1.0, 2.0[")
    implementation("software.amazon.smithy:smithy-aws-traits:[1.0, 2.0[")
    implementation("software.amazon.smithy.go:smithy-go-codegen:0.1.0")
    implementation("software.amazon.smithy.typescript:smithy-typescript-codegen:0.8.0")
}

configure<software.amazon.smithy.gradle.SmithyExtension> {
    // Uncomment this to use a custom projection when building the JAR.
    // projection = "foo"
}

// Uncomment to disable creating a JAR.
tasks["jar"].enabled = false

As well as our smithy-build.json
{
  "version": "1.0",
  "outputDirectory": "build",
  "plugins": {
    "go-codegen": {
      "service": "abc.myservice#MyService",
      "module": "github.com/jabalsad/my-service/src/go/ledger"
    },
    "typescript-codegen": {
      "service": "abc.myservice#MyService",
      "package": "my-service-client",
      "packageVersion": "0.0.1",
      "packageJson": {
        "license": "Apache-2.0"
      }
    },
    "openapi": {
      "service": "abc.myservice#MyService",
      "protocol": "aws.protocols#restJson1",
      "useIntegerType": true,
      "jsonAdd": {
        "/servers": [
          {
            "url": "https://test.com/v1"
          }
        ]
      }
    }
  }
}

I tested out building using the smithy-aws-typescript-codegen dependency instead, and this time the code generation does not even work successfully:
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':smithyBuildJar'.
> 'software.amazon.smithy.model.shapes.ShapeId software.amazon.smithy.model.shapes.OperationShape.getInputShape()'

With verbose logging enabled:
Caused by: java.lang.NoSuchMethodError: 'software.amazon.smithy.model.shapes.ShapeId software.amazon.smithy.model.shapes.OperationShape.getInputShape()'
        at software.amazon.smithy.model.validation.validators.OperationValidator.validateOperationNameAmbiguity(OperationValidator.java:152)

Yeah, that happens when there's a version mismatch between smithy dependencies in your project. smithy-aws-typescript-codegen uses APIs from smithy 1.15, and your other dependencies are not that recent.
You should be able to fix this with a buildscript dependency on smithy-cli 1.15.0. This example is in groovy format, not kotlin, but hopefully illustrative:
buildscript {
    repositories {
        mavenCentral()
    }
    dependencies {
       classpath("software.amazon.smithy:smithy-cli:1.15.0")
    }
}

To clarify - should I be using smithy-typescript-codegen:0.8.0 or smithy-aws-typescript-codegen:0.8.0 ?

To clarify - should I be using smithy-typescript-codegen:0.8.0 or smithy-aws-typescript-codegen:0.8.0 ?

I'd like to see what happens when you use smithy-aws-typescript-codegen. A lot of packages specify both, but since smithy-aws-typescript-codegen depends on smithy-typescript-codegen you shouldn't need it.

We upgraded our dependencies and added smithy-cli as a dependency. FYI I find it interesting that depending on smithy-cli:1.16.3 breaks again but smithy-cli:1.15 works.

OK - depending on smithy-aws-typescript-codegen:0.8.0 has resolved the tsc build problem and the TS code all compiles successfully after a yarn install. I'm still not sure what caused the smithy-typescript-codegen version to fail, since I pulled in all the latest changes and built it again to test.
Thanks for helping me work through it, though I recommend upgrading your readme to reflect the recommended steps.

Lastly (before we can close this issue :-) ); can you elaborate perhaps on why the 1.15 smithy tools seem to work but the 1.16.x ones do not? Is this something that is expected to be fixed in the future if we ever have a need to upgrade?

Lastly (before we can close this issue :-) ); can you elaborate perhaps on why the 1.15 smithy tools seem to work but the 1.16.x ones do not? Is this something that is expected to be fixed in the future if we ever have a need to upgrade?

Smithy 1.16 will be supported in the 0.9 code generators; see https://github.com/aws/aws-sdk-js-v3/pull/3215 and https://github.com/awslabs/smithy-typescript/pull/499

though I recommend upgrading your readme to reflect the recommended steps.

We need a mix of this and some work to remove the necessity of relying on the aws generator.

Sounds good, thank you!

@adamthom-amzn
I'd like to piggy-back on this issue, because I haven't quite been able to build the typescript package. I found a bug in the typescript codegen:
The generated package.json has a types field that points to dist-types/index.d.ts but the directory tree that is contained in source-projection/source/typescript-codegen has all the types located under a src tree in dist-types/src/index.d.ts.
This results in being unable to import this package as a dependency from npm because no types are found.

I can't reproduce this with our generic client that we use for CI tests (https://github.com/aws/aws-sdk-js-v3/tree/main/codegen/generic-client-test-codegen). dist-types isn't generated by codegen, but created by tsc during build:types. What does that target look like in your generated package.json, and what does your generated tsconfig.types.json look like?

Smithy generates the following tsconfig.types.json file:
{
  "extends": "./tsconfig",
  "compilerOptions": {
    "removeComments": false,
    "declaration": true,
    "declarationDir": "dist-types",
    "emitDeclarationOnly": true
  },
  "exclude": ["test/**/*", "dist-types/**/*"]
}

And the types field in the generated package.json points to dist-types/index.d.ts

And I'm assuming build:types is "tsc -p tsconfig.types.json", in your package.json?
if your rootDir is src in tsconfig.json I don't know why there would be a src folder in your dist-types folder. There is not for me when I build locally.

Yes. The package.json and tsconfig files are all untouched (I'm using them as is from the generated smithy output).

It appears I've tracked it down to a subtle difference in the command that is used to invoke the build (yarn vs npm).
If I run yarn build in the root of the typescript-codegen directory, I end up with dist-* directories that contain the src dir. However, if I instead run npm run build, these src directories don't appear.

FWIW I ran into this as well and needed to use the smithy-aws-typescript-codegen instead of the smithy-typescript-codegen.
The logger error appears to be because the aws codegen version adds additional properties that aren't in the smithy-typescript-codegen version, one of which is logger.

diff smithy vs. smithy-aws
--- /tmp/smithy-only/src/MyServiceClient.ts	2022-07-06 14:23:58.000000000 -0400
+++ /tmp/smithy-aws/src/MyServiceClient.ts	2022-07-06 16:37:19.000000000 -0400

export interface ClientDefaults
  extends Partial<__SmithyResolvedConfiguration<__HttpHandlerOptions>> {

...

+   * Value for how many times a request will be made at most in case of retry.
+   */
+  maxAttempts?: number | __Provider<number>;
+
+  /**
+   * Specifies which retry algorithm to use.
+   */
+  retryMode?: string | __Provider<string>;
+
+  /**
+   * Optional logger for logging debug/info/warn/error.
+   */
+  logger?: __Logger;
+
+  /**
+   * Enables IPv6/IPv4 dualstack endpoint.
+   */
+  useDualstackEndpoint?: boolean | __Provider<boolean>;
+
+  /**
+   * Enables FIPS compatible endpoints.
+   */
+  useFipsEndpoint?: boolean | __Provider<boolean>;
+
+  /**
+   * Unique service identifier.
+   * @internal
+   */
+  serviceId?: string;
+
+  /**
+   * Fetch related hostname, signing name or signing region with given region.
+   * @internal
+   */
+  regionInfoProvider?: RegionInfoProvider;
+
+  /**
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
+   */
+  defaultUserAgentProvider?: Provider<__UserAgent>;
}

The other error I get, which might be new from when the original issue was created, is around endpoints:
[build:cjs] src/commands/MyCommand.ts(47,45): error TS2345: Argument of type 'MyServiceClientResolvedConfig' is not assignable to parameter of type 'SerdeContext'.
[build:cjs]   Property 'endpoint' is missing in type 'SmithyConfiguration<HttpHandlerOptions> & Required<ClientDefaults>' but required in type 'SerdeContext'.

Which looks like it's coming from EndpointsResolvedConfig when comparing the diff of smithy-typescript vs. smithy-aws-typescript:

diff smithy vs. smithy-aws
 type MyServiceClientResolvedConfigType = __SmithyResolvedConfiguration<__HttpHandlerOptions>
   & Required<ClientDefaults>
+  & RegionResolvedConfig
+  & EndpointsResolvedConfig
+  & RetryResolvedConfig
+  & HostHeaderResolvedConfig
+  & UserAgentResolvedConfig

Using smithy-aws-typescript-codegen does result in having to provide an
unnecessary region param when creating a client (I'm providing my own
endpoint param), but otherwise seems to work.
NOTE: I also had to pull in #561 to get everything working for real, otherwise npm install fails with the error from #560.

It looks like the original problem here has finally been fixed in this PR: https://github.com/awslabs/smithy-typescript/pull/693
From what I can tell, smithy-aws-typescript-codegen extends smithy-typescript-codegen with various plugins. One of those plugins was responsible for adding logger to the generated runtime configuration. Some code in this package was incorrectly assuming that the runtime config would always contain logger even though nothing here was adding it, so builds with smithy-aws-typescript-codegen would succeed but generic builds with this package would fail.  It's now added by AddClientRuntimeConfig.java


Update dependencies, regen and fix cbor-gen output, add dependabot

This one's a little more tricky because we don't use the raw cbor-gen output but do some modifications here to deal with a custom Pointer type (pointer_cbor.go isn't included in cbor-gen generate but I manually made a minor edit) and the custom big.Int handling here. So the changes here are a unification of the new cbor-gen output and the modified one.

I tried this branch out on an nv23 migration and it got the same state root as the currently released version, so there's some verification that we're not doing anything funky here.

@Stebalien updated this, care to take another look and we can land it?

:heart:


Enable Arithmetics

In order to realize arithmetics as per the standard, the following is required:

[ ] The parser needs to take operator precedence into account (* and / before + and -).
[ ] Evaluation of all ground arithmetic terms occurring anywhere as a subterm ( a fact p(f(g(3+4,a)). must yield p(f(g(7,a)) in all answer sets).
[ ] Ignoring instances of undefined arithmetics ( p(3+a). and p(3/0). are simply ignored, likewise a constraint :- not p(3/0). is also ignored).

It also seems that arithmetics with variables is unsupported.
Steps to reproduce:
#> cat test.asp
h :- b(1-Y), d(Y).

#> java -jar alpha.jar -i test.asp
Exception in thread "main" java.lang.UnsupportedOperationException: Unsupported syntax encountered: 1-Y
[...]

Release v0.2.0

I am sorry, my comment was too specific. Apparently, Alpha v0.2.0 does not yet support arithmetics at all.

The current master branch supports a little arithmetics, so Alpha should process it if you build from source (see https://github.com/alpha-asp/Alpha#building) and then write your rule as:
h :- b(B1), B1 = Y-1, d(Y).
Otherwise arithmetics is still very limited as this issue indicates.

Apparently it can happen that Alpha does not ground rules in which unsupported forms of arithmetics occur, but no error message is returned to the user, who may not notice in this case that anything is wrong. Can be reproduced with this program, in which the term O-1 in the following rule seems to be problematic:
h_assign_1(U1,T,X,W) :- order(X,T,O), assign(U,T1,Y), order(Y,T1,O-1), maxOrder(M), maxUnit(MU), comUnit(U1), U1<=U, maxElem(ME), W=10*MU*(M-O)+2*(ME-X)+U1.
So as a first step, Alpha should at least report to the user if unsupported arithmetics occur in the input.

Can you provide a minimal working example of the wrong behaviour? I just tested a simple version with the term 0-1 and it gets evaluated to -1 correctly on the master branch. There were some changes to the evaluation of arithmetics some time ago, such that ground arithmetic expressions should now be evaluated by the grounder directly.

I will try to find a smaller example, but I can already tell you it´s about O-1 (variable minus constant), not 0-1 (constant minus constant).

O, I saw that as 0. But even with a variable, I fail to reproduce the error.
My test program is:
h_assign_1(U1,T,X,W) :- order(X,T,O), assign(U,T1,Y), order(Y,T1,O-1), maxOrder(M),maxUnit(MU),comUnit(U1), U1<=U, maxElem(ME), W=10*MU*(M-O)+2*(ME-X)+U1.
order(1,now1,3).
order(2,now2,2).
maxOrder(7).
maxUnit(11).
comUnit(5).
assign(6,now2,2).
maxElem(13).

Alpha on master finds the following answer set:
Answer set 1:
{ assign(6, now2, 2), comUnit(5), h_assign_1(5, now1, 1, 469), maxElem(13), maxOrder(7), maxUnit(11), order(1, now1, 3), order(2, now2, 2) }
SATISFIABLE

What is missing here?

Unfortunately I also cannot reproduce the issue using the approach of a minimal input program.
However, I narrowed the issue down to the call of Substitution#unify, which returns null. Obviously this is because of a missing feature in Substitution#unifyTerms. You can reproduce the issue as follows:
@Test
public void testSubstituteNminus1() {
	Predicate predOrder = Predicate.getInstance("order", 3);
	ConstantTerm<Integer> const1 = ConstantTerm.getInstance(1);
	ConstantTerm<String> constZ = ConstantTerm.getInstance("z");
	VariableTerm varN = VariableTerm.getInstance("N");
	Atom substitute = new BasicAtom(predOrder, const1, constZ, ArithmeticTerm.getInstance(varN, ArithmeticTerm.ArithmeticOperator.MINUS, const1));
	Instance instance = new Instance(const1, constZ, const1);
	Substitution unification = Substitution.unify(substitute, instance, new Substitution());
	Substitution expectedUnification = new Substitution();
	expectedUnification.put(varN, ConstantTerm.getInstance(2));
	assertEquals(expectedUnification, unification);
}

Ahh, I see: it tries to unify 1 with N-1 and fails. Honestly, I am not sure if we should support this, since this would mean that our unification needs to solve arithmetic equations.
I think this should never happen, i.e., throw an error (possibly at some other position already).


Fixed the checkstyle indentation issue in common pkg.

This is the last part of checkstyle fix.

Can one of the admins verify this patch?


How to use byRow with stacked elements and responsive layouts

The _rows function simply tests if the current element has the same top as the previous element, according to DOM order. This causes elements that should be in the same visual group to be in different groups if an item comes between them that has a different offset().top.
In many responsive views, you might have two elements that stack in one breakpoint, but in another breakpoint they are side by side.
Take this example:

            STACKED

            STACKED

            NOT-STACKED

            NOT-STACKED

Assuming the row-a and row-b are right beside one another, and we are viewing from a large viewport: items 1, 3 and 4 are in the same visual row, but the code only treats 3 and 4 as the same group.
However, in the md breakpoint, item 1 and 2 would ideally be the same height when they are beside one another.

This isn't currently supported. Sounds like a good idea though, I'll look into implementing it. In the meantime I guess you'll need to select your elements together and then sort them (e.g. [item-1, item-3, item-2, item-4]).

So theoretically, would this work in this context?
'''
$.fn.matchHeight._apply([item-1, item-3, item-4, item-2], {byRow:true})
'''
In the row array, instead of the default key, what if the key was instead the "value" of the row?
So instead of row[] looking like
row[0], row[1], row[2], it looked like row[670], row[700], row[900], where the key is the floored pixel value of the offset?

Couldn't we make the byRow param accept an element like this:
byRow: '.row-a'
So it looks for the parent row with the classname 'row-a'?


[FEATURE] Send Email to User After registration ....

Send an Email To registered User.
send an email to user after registration on the platform

done.....


Support filtering trusted JWT Issuers in IdP API implementation

Is your suggestion related to an experience ? Please describe.
Support filtering trusted JWT issuers in the existing IdP API.
Describe the improvement
Keep a IdP metadata to filter the trusted JWT issuers from the rest of the IdPs.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Refinement: added x-ms-enum for tags patch operation

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

As suggested in a cli pr for tags cmdlet, we did the following refinement:
Added "x-ms-enum" for tags patch operation:
Updated in mgmt:2019-10-01 and mgmt:2019-10-01.
Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

Removing ARM Feedback label since ARM review board will not be reviewing property level changes going forward.

@Grayer123 , could you resolve the comments?

@Grayer123 , are you still working on this PR?

/azp run automation - sdk

/azp run automation - sdk

Hello @raych1, there is an automation - sdk test failure? Not sure if my change could cause that, could you please help us take a look? Thanks.


There is no Spanish translation

We would like to have a Spanish translation

@beeman I can help with this. Please let me know how to get involved :D

@onel0p3z Thanks! Actually there is just a Mexican translation added by @Stidro.
If you think the Spanish from Spain is different and should be added to you can look at PR #120


[BUG] Exception when using tf Painless method suggests using the deprecated classic similarity

Describe the bug
Without the correct setup, if a user calls the tf Painless method in the script_score query, the user gets back an UnsupportedOperationException:
{
  "error": {
    "root_cause": [
      {
        "type": "unsupported_operation_exception",
        "reason": "unsupported_operation_exception: requires a TFIDFSimilarity (such as ClassicSimilarity)"
      }
    ],
    "type": "search_phase_execution_exception",
    "reason": "all shards failed",
    "phase": "query",
    "grouped": true,
    "failed_shards": [
      {
        "shard": 0,
        "index": "test",
        "node": "sQkgvgQWRT2pfI4leTC8lg",
        "reason": {
          "type": "script_exception",
          "reason": "runtime error",
          "script_stack": [
            "org.opensearch.ExceptionsHelper.convertToOpenSearchException(ExceptionsHelper.java:86)",
            "org.opensearch.script.ScoreScriptUtils$TF.tf(ScoreScriptUtils.java:113)",
            "tf(params.field, params.term)",
            "                       ^---- HERE"
          ],
          "script": "tf(params.field, params.term)",
          "lang": "painless",
          "position": {
            "offset": 23,
            "start": 0,
            "end": 29
          },
          "caused_by": {
            "type": "exception",
            "reason": "java.lang.UnsupportedOperationException: requires a TFIDFSimilarity (such as ClassicSimilarity)",
            "caused_by": {
              "type": "unsupported_operation_exception",
              "reason": "unsupported_operation_exception: requires a TFIDFSimilarity (such as ClassicSimilarity)"
            }
          }
        }
      }
    ],
    "caused_by": {
      "type": "unsupported_operation_exception",
      "reason": "unsupported_operation_exception: requires a TFIDFSimilarity (such as ClassicSimilarity)"
    }
  },
  "status": 400
}

This exception instructs the user to use classic similarity. If the user then executes a query to set the similarity to classic:
PUT /test/_mapping
{
  "properties": {
    "<field_name>": {
      "type": "text",
      "similarity": "classic"
    }
  }
}

the user gets an exception saying that the classic similarity is deprecated and to use the BM25 similarity in its place.
To Reproduce
Steps to reproduce the behavior:

Run a query above
See the UnsupportedOperationException error

Expected behavior
Instead of classic, the exception should instruct the user to use the BM25 similarity:
unsupported_operation_exception: requires a TFIDFSimilarity (such as BM25Similarity)
Host/Environment (please complete the following information):

Version 2.10

Additional context
See discussion in the documentation PR https://github.com/opensearch-project/documentation-website/pull/4988

@kolchfa-aws I just learned that classic similarity has been removed from main branch, but not from 2.10. https://github.com/opensearch-project/OpenSearch/blob/2.10/server/src/main/java/org/opensearch/index/similarity/SimilarityService.java#L78-L98
Could you please confirm that 2.10 works properly?

Should we have added support for the tf function if it depends on TFIDFSimilarity and we don't allow users to use ClassicSimilarity (the only subclass of TFIDFSimilarity that was shipping with Lucene)? I know it was requested in https://github.com/opensearch-project/OpenSearch/issues/7558, but was there any consideration for how it would work in practice? Is there a valid way for users to make use of the tf function with the available similarities in OpenSearch?

Should we have added support for the tf function if it depends on TFIDFSimilarity and we don't allow users to use ClassicSimilarity (the only subclass of TFIDFSimilarity that ships with Lucene)? I know it was requested in #7558, but was there any consideration for how it would work in practice? Is there a valid way for users to make use of the tf function with the available similarities in OpenSearch?

Good point, unless OpenSearch support ClassicSimilarity users could not really use tf() function in practice. The bugfix should remove the support of tf().


implement power and sample size analysis

This could be useful for several reasons. In my use case, I have a large number of possible group assignments I could test with pairwise log-rank tests. However, I prefer to not test them all since I expect that a significant fraction of them stands no chance of being significant, because of insufficient sample sizes or numbers of deaths. Performing such tests would have no benefit but would dilute the results by increasing the amount of multiple-hypothesis correction. If instead I can rule many of these hopeless cases out a priori based on power/sample size analysis, I can avoid that problem.
I'm new to survival statistics, so I hesitate to try my hand at helping code this, but I imagine that for an expert, implementing this for the log-rank test would not be very difficult. I have searched a bit and found proprietary statistical packages (Stata, SAS, etc) offering this feature. There are R packages, academic references and a few forum posts that seemed related but perhaps not exactly what I'm looking for.
Power and sample size analysis for survival regression would also be useful.

:+1: yea I can put this with the 0.8.0 release. Thanks for the suggestion. Can you suggest some literature on the subject?

Sure. I will need to search a bit but I'll try to get back to you soon.

The references mentioned at this site should be useful. They are listed at the bottom of the page. The manual for the R package powerSurvEpi has newer references, including the most apparently relevant that I found myself with Google Scholar.
This may not cover everything you'll need, but hopefully it covers most of it and can give you leads to find other relevant references.

This has been implemented in v0.8.0.

Excellent! Good work. I've got the latest version and am looking for it--where is it? How is it accessed? Sorry, I shouldn't be impatient, the documentation will catch up.

Yea, I skipped docs on it :disappointed:
In the CHANGLOG, you'll see:

added sample size and power calculations for statistical tests. See lifeline.statistics. sample_size_necessary_under_cph and lifelines.statistics. power_under_cph.

Great, I'm using them now. Nice work on the quick turnaround for these.
For both functions, I'd like to estimate p_exp and p_con from data. I
understand these are the probability of an event in the experimental and
control groups, respectively, over the maximum time of the study. How do I
estimate them given that some observations are truncated? This is probably
a very basic survival analysis question; I apologize for my inexperience. I
thought I could use CoxPHFitter, fit a model to each group's data, and
retrieve the probability as some attribute of the fitted model, although it
wasn't clear to me which attribute was relevant. Am I headed in the right
direction?
James Jensen
PhD student, Bioinformatics and Systems Biology
Trey Ideker lab
University of California, San Diego
On Mon, Aug 3, 2015 at 6:03 PM, Cameron Davidson-Pilon <
<EMAIL_ADDRESS>wrote:

Yea, I skipped docs on it [image: :disappointed:]
In the CHANGLOG, you'll see:
added sample size and power calculations for statistical tests. See
lifeline.statistics. sample_size_necessary_under_cph and
lifelines.statistics. power_under_cph.
—
Reply to this email directly or view it on GitHub
https://github.com/CamDavidsonPilon/lifelines/issues/174#issuecomment-127444808
.


Perform live_grep on previous results

Hi,
this is not exactly an issue, more of a workflow "problem" i can't solve right now:
Is it somehow possible to do this:

first find files based on live_grep
perform 2nd live_grep search on the result of 1.

Is this possible somehow?
Regards

Yes it’s possible, you’ll need to craft a new rg command using the last search query and use it as the new cmd.
Say I just searched for foo, you can now run live grep with this cmd:
live_grep({ cmd = 'rg …<opts>… “foo” | rg … <opts>' })

Closing, feel free to reopen if you need more help.


Ensure BEFORE_SCRIPT and AFTER_SCRIPT are populated correctly

After discussions with @ghostwriter, and after some simple testing on this myself to confirm, this is the proposed fix to prevent the error:
/usr/local/bin/entrypoint.sh: line 147: readarray: `BEFORE_SCRIPT=xmllint --schema vendor/phpunit/phpunit/phpunit.xsd phpunit.xml.dist': not a valid identifier

Note: I'm not able to use git CLI right now, but consider this signed off.

As stated in slack:
I would avoid the whole file descriptor stuff.
Just change the code like this and we have dedicated commands.
declare -a BEFORE_SCRIPT=()
readarray -t BEFORE_SCRIPT < <(echo "${JOB}" | jq -rc '(.before_script // [])[]' )

declare -a AFTER_SCRIPT=()
readarray -t AFTER_SCRIPT < <(echo "${JOB}" | jq -rc '(.after_script // [])[]' )

There should be no before_script which provides multiline commands. As of now, we do only provide before_script via the matrix itself without the ability to read it from i.e. .laminas-ci.json and thus, that might already be fine.
Not sure if we need an extra safe-guard for multiline commands. Upstream projects already can provide .laminas-ci/pre-run.sh where they can have their super complex multiline whatever before_script logic.

Sorry for the force push, needed to signoff that earlier commit.
Thanks also to @boesing and @Xerkus for their help with this

I'd say, 🚢


not supporting percent in width

<Line width="100%"  height="250"  /> It's expected to set width 100% but when it rendered width is 100px.
how to set width to 100% of parent's width?

@agent3bood thank you


plot

Create generic plot function, that determines what and how to plot on the basis of the keys in the dict provided.

(Include code for vertical CI bars on the bootstrap plot.)

(Include code for vertical CI bars on the bootstrap plot.)


Merge remote-tracking branch 'refs/remotes/tensorflow/master'

This pull request appears to be empty, so I'm going to close it.


Mark pg client as done

Right now the connection client doesn't get marked as done, so we could easily fill the pool.

should be fixed in 4.0.1


Added mention of IndiePKG in install instructions.

Hey there!
A while ago I added your program to my package manager's repositories.

I've moved it to a different section, let me know if I should make any more changes :)

The documentation looks pretty good now, but the packag (or IndiePKG itself seems to have a bug), here is the error:
=> Error
[!] File /home/beta/.indiepkg/tmp/package_src/wiki/wiki is not a regular file, can't copy.

Fixed it, sorry about that. I assume you changed the install instructions eventually and it threw off indiepkg.

@BetaPictoris should I make any further changes?

Merging... Thank you, and I apologize for the late reply!


In Place Merge Sort in C++

The current implementation of merge sort in C++, is by using a temporary storage array. I can implement an improvised algorithm, where we do not need extra space.
Kindly assign this issue to me @tarun26091999

I will add it in C++.
@tarun26091999 Please assign me this issue.

I would like to contribute to the above problem in java as I am a participant of GSSOC'21. Kindly assign this to me.


[feature] Added New Car Model

New Feature
Adds a new car model in three different colors
How to test

In a sourced terminal execute
a. roslaunch model_publisher estima_model_white.launch
b. roslaunch model_publisher estima_model_gray.launch
c. roslaunch model_publisher estima_model_black.launch
Launch RViz
Change fixed frame to base_link
Add Topic -> RobotModel

The robot Model should be visible
White:

Gray:

Black:

Video:
https://drive.google.com/open?id=0BzYuVrO9pnh6U1hrUE9Jb0t1Y3M

@amc-nu wheels are not moving yet:)


Added Digest::SHA256

The interface is the same as Digest::SHA1.
A lot of code is duplicated between the two, maybe we should refactor into a Digest::Utils module?
Or Digest::Utils::SHA for SHA-specific utils?
The padding function, for example, is the same between all SHAs.
Also, the Digest::* interface is probably gonna be implemented in the same way for every hash function, only the digest method will change.
Maybe we should have an interface with hexdigest and base64digest implemented (as a base class or mixin, I don't know if it's a thing in crystal)?
Tests are also provided, based on the test suite for SHA1.

Thanks! I don't have means for a proper review (I'm on a phone).
I believe SHA256 and SHA512 are actually the same thing (SHA2) but using different lengths. I'll read more about that and about SHA1, and see whether it could make sense to have a single SHA2 implementation, possibly sharing some code with SHA1.
How fast is this implementation, compared to using OpenSSL::Digest for example?

For the test vectors, I took the tests from sha1_spec.cr and rehashed them using shasum -a 256.
SHA-256 and SHA-512 are very similar indeed, but SHA-512 use 64 bit words. I've seen that crystal supports something close to C++ templates, so it may be possible to share some code between the two.
As for the speed, I don't know. This implementation is based on the existing Digest::SHA1 implementation. I am very new to crystal, so I have no idea how benchmarks are done here (do you have something like the Benchmark module in ruby?), but I would be glad to make one, and optimize the implementation.

Yes, our benchmark stdlib has roughly the same API as Ruby's and that of the benchmark-ips gem.

Ok, I did this small benchmark :
require "benchmark"
require "openssl"
require "digest/sha256"

n = 10000
strings = [] of String
ssl_sha256 = OpenSSL::Digest.new("sha256")

n.times do
    len = (rand * 100).to_i * 1024 # (1k..100k range)
    str = "a" * len
    strings << str
end

Benchmark.bm do |x|
    x.report("OpenSSL::Digest") do
        strings.each do |str|
            ssl_sha256.reset
            ssl_sha256 << str
            ssl_sha256.digest
        end
    end

    x.report("Digest::SHA256") do
        strings.each {|str| Digest::SHA256.digest(str) }
    end
end

It generates strings full of 'a's, with a random length between 1k and 100k.
On my machine, OpenSSL is twice as fast. However, when dealing with smaller strings (1 ~ 1k), Digest::SHA256 is up to twice as fast as OpenSSL. I suppose this come from the block reading method, in Digest::SHA* modules, this is done one byte at a time, while it is possible (but nontrivial due to padding) to read up to 512 bytes into the buffer.

Thanks for digging more. I'll definitely take a closer look.

Any news about this ?

I originally implemented Digest::SHA1 in pure Crystal so we don't depend on openssl for websockets, which are needed for crystal play. The one that comes with openssl is fine, I think, so I don't think we'll want to implement every algorithm in pure crystal, mostly because of security reasons. In fact I can imagine removing Digest::SHA1 eventually once we can workaround some issues with building the compiler with openssl.


use go-kong's ListAll funcs in dump package

This can't be done because decK uses selector tags and go-kong only supports listing all the entities.


AutoObject for List or RadioButtons

Thank you for your amazing work! I also tried to create a PR for this change, but I'm not able to do so easily 😈
Is it simple to implement a special key:value for AutoObject in order to automatically create a List control (aka a Select) or a RadioGroup buttons?
For example, it could be implemented with:
myKey: ['alpha', 'beta']
Or with labels:
myKey: [{alpha:'AlphaLabel', beta:'BetaLabel'}]
Given that the Array is not checked as an input type in the AutoObject if statement, I think it is feasible. Thanks!

Hi, thanks for using the library and contributing this idea for a new feature!
First I just want to make sure components like <List> and <RadioGrid> are on your radar, since they make it easy to create Select and radio button controls, for example:
<script lang="ts">
	import { List, RadioGrid } from 'svelte-tweakpane-ui';
	let value: string;
</script>

<List bind:value options={{ 'Alpha Label': 'alpha', 'Beta Label': 'beta' }} />
<RadioGrid bind:value values={['alpha', 'beta']} />

The <AutoObject> (and  <AutoValue>) components trade configurability for convenience, since they use the same object or value to both define the structure of the UI and react to control changes. Because of this, the tricky thing here would be how to separate defining the list options from the state value representing the active selection:
// Hypothetical, not currently implemented!
<script lang="ts">
	import { AutoObject } from 'svelte-tweakpane-ui';
	let object = {
	  myKey: ['alpha', 'beta']
	};
</script>

<AutoObject bind:object >
{object.myKey} // ???

The only ways that I can think of to disambiguate state from configuration are:
A. Add a prop with additional configuration to define the list, at which point I think it makes more sense to use the more specific components like <List> that already have props for this.
B. Come up with a special object shape that puts the selected value state alongside the list definition. I guess <AutoObject> could look for a type like { [key: string]: { value: T; options: T[] }; }, so the example above would become:
// Hypothetical, not currently implemented!
<script lang="ts">
	import { AutoObject } from 'svelte-tweakpane-ui';
	let object = {
		myKey: { value: 'alpha', options: ['alpha', 'beta'] }
	};
</script>

<AutoObject bind:object >
{object.myKey.value} // alpha

There's some precedent for this kind of magic control inference in vanilla Tweakpane, and that's mirrored in how <AutoObject> infers color and point controls based on object shape... but for lists, I think vanilla Tweakpane always separates the list options from the bound value, like in this example, so I'm not sure if a special object shape would end up creating more confusion than convenience. (Though we might have some room for magic in a component with "Auto" in its name...)
Open to your ideas — it would be great to hear a bit more info on how you envisioned binding working. I could be missing something obvious.

Thank you very much for the response. I hadn't grasped the concept of Value Binding; indeed, it only makes sense when Value and UI Configuration coincide, so it's complex with Lists, and anyway, it would undermine the utility of AutoObject.
We will try to use the components separately for our application. However, if I come up with an elegant idea to solve the problem, I'll propose it to you :)

Sounds good, thanks for the discussion and good luck with your project.


[Bug] Only one of metric_id and metric_selector is allowed

looks like there is a cirlce problem in custom anomaly rules.
If I add metric_selector and metric metricId I get this error:
Error: {
│   "code": 400,
│   "message": "Constraints violated.",
│   "constraintViolations": [
│     {
│       "parameterLocation": "PAYLOAD_BODY",
│       "location": "",
│       "message": "Exactly one metric specification method should be provided, please use either a metricId or a metricSelector",
│       "path": ""
│     },
│     {
│       "parameterLocation": "PAYLOAD_BODY",
│       "location": "",
│       "message": "The given metric id is not configured.",
│       "path": "metricId"
│     }
│   ]
│ }

But when I only add metric_selector i get this error:
Error: Missing required argument
│
│   on modules/environment/anomalies_custom-response-time-greater-3s.tf line 1, in resource "dynatrace_custom_anomalies" "response_time_greater_than_3_sec_for_8_minutes":
│    1: resource "dynatrace_custom_anomalies" "response_time_greater_than_3_sec_for_8_minutes" {
│
│ The argument "metric_id" is required, but no definition was found.

Best
Joerg

metric_id is not required anymore - you're right. I unfortunately introduced the new attribute as an optional additional feature, didn't realize that there's a lot more behind that.
Tomorrow I'll push out another hotfix in order to fix that properly.


_.config

module.exports =
Your config schema
config:
someInt:
type: 'integer'
default: 23
minimum: 1
activate: (state) -> # ...
...

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us halfway :grinning:


epicnx wallpaper pack

New wallpaper pack EpicNX. Inspired by the EpicNoir and Switch emulationstation themes.

Thank you. This is beautiful!


add Client.delete() and Client.put()

Add Client.delete() and Client.put()
Closes #11

@OscarSalgado could you add Client.put() along with it's test?

You can cherry pick 467a057038b5200ff36b17b1d9845353514cfea3
Please make any necessary change

@OscarSalgado can you add the recorded VCR cassette?
To run the tests, you need to first make sure you have a saved, active tokens located in $GARTH_HOME.

Now it should be ok ac73b450b0fe1446be12761497290d069393063a

Looks good. Thanks!


Update dependencies

I remember also the other thing I didn't like with dependabot: it does 1 PR per dependency. That's also spamming the main's branch history.
Wdyt? Do you think it's best to have a separate commit for each dependency update? I don't see much reason to do so

I'm okay with bulk dependency updates if there's a good way to do it; maybe a GitHub Actions periodic?  What I'm trying to avoid is having to remember to manually sweep repos periodically to keep their deps from going stale.

Periodic workflow in #89.


Sanitize inputs coming from the Java frontend

Because of https://github.com/runtimeverification/k/issues/3436, we have examples when things are coming from the frontend where they do not contain sort parameter information on klabels, and sometimes they don't contain variable sort information.
This caused us to have to manually add sort parameters in some cases, for example here: https://github.com/runtimeverification/pyk/pull/481 or https://github.com/runtimeverification/pyk/pull/464 or https://github.com/runtimeverification/pyk/pull/472.
Gradually, we'll probably discover more places we'll have to do this "sanitization" of the input coming from the frontend. It would be nice to factor out htat sanitization into its own pass, and apply it globally to inputs coming from the frontend. For now, that pass could call KDefinition.sort_vars and KDefinition.add_sort_params.

We can close this, we've handelde the cases we have seen.


Make WKWebView inspectable from Safari

Allow inspection from Safari. More info:
https://webkit.org/blog/13936/enabling-the-inspection-of-web-content-in-apps/

Thanks for this! I'm going to incorporate this into my hard fork for my swift bindings if that's okay.

Thanks for the contribution!
Dev tools should already work with WebKit on macOS but my understanding of this PR is that it also enables inspecting the WebKit window via Safari.
This part of the linked page is something we probably should take into account:

Working with older versions of macOS and iOS
For apps linked against an SDK before macOS 13.3 and iOS 16.4 WKWebViews and JSContexts will continue to follow the previous behavior of always being inspectable when built for debugging from Xcode.
Apps that support older versions of macOS and iOS while linked against the most recent SDK will not get the previous behavior of all content being inspectable in debug builds to avoid confusion about what will and will not be inspectable by customers. Apps targeting older OS versions but linking against the new SDK can use this new API conditionally on OS versions that support it. To conditionally guard usage of the API:
Swift
if #available(macOS 13.3, iOS 16.4, tvOS 16.4, *) {
    webView.isInspectable = true
}

Objective-C
if (@available(macOS 13.3, iOS 16.4, tvOS 16.4, *))
    webView.inspectable = YES;

You can learn more about guarding usage of new API on developer.apple.com.

I gave this a try on macOS 12 and got this error:
2023-07-20 21:20:26.730 basic[1188:15171] -[WKWebView setInspectable:]: unrecognized selector sent to instance 0x7ff78b006d80

I've rebased the commit in this PR, added more information and an API usage guard to avoid crashing the program on macOS versions older than 13.3:

#956

The work in this PR was merged along with #956. Thanks!


DBZ-2469 [Documentation] Fix Debezium Server documentation for transformations and Google Pub/Sub

Fix configuration for transformations and Google Pub/Sub.
Issue https://issues.redhat.com/browse/DBZ-2469

Good catch, thx! Rebased and applied this to the master branche (i.e. 1.3, as 1.2 is receiving only critical bug fixes at this point).


[BUG] get kubeconfig command remove the symbolic link managed by dotfiles

I got a slight problem in kubeconfig file management. Personally I manage the confidentail config files like ssh and kubeconfig with symbolic links.
But Every single time when I creating a new k3d cluster and switch to the kubernetes context with
k3d create cluster test
k3d get kubeconfig test -s

I find the k3d get kubeconfig command will remove the symbolic link and create a new one. This makes me hard managing the cluster context.
What did you expect to happen?
Not sure if there is any disscussion about the creating flow before. I think It would be nice if k3d updates and switchs to the context just created automatically whenever k3d creates a new cluster. (like the creating flow in minikube start)
Environment
OS: Ubuntu 20.04/ amd64
k3d: v3.0.0-rc.6

Hi @timtorChen , thanks for opening this issue and sharing your concerns/thoughts!
k3d by default updates the default kubeconfig now and switches the current context.
Fixed by #288


[i2c,dv] Target mode nack generation directed tests

Builds upon the changes from #23711 , only the last 3 commits are new.

This PR adds three directed tests ["i2c_target_nack_acqfull", "i2c_target_nack_acqfull_addr", "i2c_target_nack_txstretch"] which go towards closing the testpoint "target_mode_nack_generation".
Note that this PR does not cover the following sub-bullets of the testpoint using directed tests:
              - Check that ACQDATA.{NACK,NACKSTART} are set correctly when automatic NACKs have
                space to add a new entry to the ACQFIFO.
              - Check that ACQDATA.ABYTE contains the NACKd byte when automatic NACKs have space
                to add a new entry to the ACQFIFO.

DV for those particular bullets will come from upcoming predictor/scoreboard changes that will check these ACQDATA fields are correct for each transfer. I will link that PR back to this one when it is available.
Goes towards #23077.

Rebased, and removed commits from #23528

Latest push removes changes from other PRs which have already landed in master.

CHANGE AUTHORIZED: hw/ip/i2c/data/i2c.hjson

CHANGE AUTHORIZED: hw/ip/i2c/data/i2c.hjson

Some CW310 ROM tests are failing, but it's nothing to do with this PR. Merging....


Refractor dependency list for better overview.

Just saw this and propose a better overview for the file.

@bmagyar We should also port this repo to GH-Actions...

@destogl Hasn't that been done? https://github.com/ros-controls/control_msgs/pull/51

Oh, nvm. This is for foxy


Adding DMG Color Emulation

Here is the shine file itself!
See #7 for reference

Looking forward to the godray shader :+1:

:sweat_smile: hope it's ok!


Remove deprecated API methods

Remove the deprecated API methods and the key translation for settings dictionaries in clientbuilder.

I'm just going to close this for now. When we get to 2.0 we'll take a good look at everything and remove the bits that no longer make sense.


Fix message/event HTTP sending

Sometimes the processing of messages/events gets stuck. I'm using this ticket to track all the errors that I see when this happens, so that we can look into catching them properly.
2017-04-19 09:20:57,934 [twisted] CRITICAL: Unhandled Error
Traceback (most recent call last):
Failure: twisted.web._newclient.RequestTransmissionFailed: [<twisted.python.failure.Failure twisted.internet.error.ConnectionDone: Connection was closed cleanly.>]

2017-04-19 09:20:57,934 [twisted] CRITICAL: Unexpected exception from twisted.web.client.FileBodyProducer.stopProducing
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/twisted/internet/endpoints.py", line 130, in connectionLost
    return self._wrappedProtocol.connectionLost(reason)
  File "/usr/local/lib/python2.7/site-packages/twisted/web/_newclient.py", line 929, in dispatcher
    return func(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/twisted/web/_newclient.py", line 1599, in _connectionLost_TRANSMITTING
    self._currentRequest.stopWriting()
  File "/usr/local/lib/python2.7/site-packages/twisted/web/_newclient.py", line 830, in stopWriting
    _callAppFunction(self.bodyProducer.stopProducing)
--- <exception caught here> ---
  File "/usr/local/lib/python2.7/site-packages/twisted/web/_newclient.py", line 194, in _callAppFunction
    function()
  File "/usr/local/lib/python2.7/site-packages/twisted/web/client.py", line 1041, in stopProducing
    self._task.stop()
  File "/usr/local/lib/python2.7/site-packages/twisted/internet/task.py", line 497, in stop
    self._checkFinish()
  File "/usr/local/lib/python2.7/site-packages/twisted/internet/task.py", line 507, in _checkFinish
    raise self._completionState
twisted.internet.task.TaskStopped:

Traceback (most recent call last):
Failure: twisted.web._newclient.RequestTransmissionFailed: [<twisted.python.failure.Failure twisted.internet.error.ConnectionDone: Connection was closed cleanly.>]

2017-04-26 07:15:52,573 [twisted] CRITICAL: Unexpected exception from twisted.web.client.FileBodyProducer.stopProducing
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/twisted/internet/endpoints.py", line 130, in connectionLost
    return self._wrappedProtocol.connectionLost(reason)
  File "/usr/local/lib/python2.7/site-packages/twisted/web/_newclient.py", line 929, in dispatcher
    return func(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/twisted/web/_newclient.py", line 1599, in _connectionLost_TRANSMITTING
    self._currentRequest.stopWriting()
  File "/usr/local/lib/python2.7/site-packages/twisted/web/_newclient.py", line 830, in stopWriting
    _callAppFunction(self.bodyProducer.stopProducing)
--- <exception caught here> ---
  File "/usr/local/lib/python2.7/site-packages/twisted/web/_newclient.py", line 194, in _callAppFunction
    function()
  File "/usr/local/lib/python2.7/site-packages/twisted/web/client.py", line 1041, in stopProducing
    self._task.stop()
  File "/usr/local/lib/python2.7/site-packages/twisted/internet/task.py", line 497, in stop
    self._checkFinish()
  File "/usr/local/lib/python2.7/site-packages/twisted/internet/task.py", line 507, in _checkFinish
    raise self._completionState
twisted.internet.task.TaskStopped: ```

This seems to have been fixed by https://github.com/praekelt/junebug/pull/137


fix: Improve Lineage chart UI

Signed-off-by: Ozan Dogrultan<EMAIL_ADDRESS>Summary of Changes
This PR introduces some UI improvements to especially fix the overlapping of node labels in the Lineage chart when there are many nodes being rendered.
This is achieved by assigning a fixed the horizontal space between different labels in the graph and rearranging the position of the labels based on the graph direction.
Here are the screenshot to compare before and after:
Before:

After:

Tests
Updated one test case for Lineage graph dimension calculation.
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes.
[x] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

Hi @Golodhros , I've addressed your comments, can you please take a look again? Thanks a lot!


root_metadata: set the writer MD copied bit for finalized MDs

Otherwise clients reject it, since the MD usage doesn't match up, and
could try to re-apply operations in it to the node cache.
Issue: KBFS-1976

By the way, I think this also explains why keybase.pub still doesn't correctly apply updates after an account reset.


How use DataTable DOM

I want to use below  DOM but how?
"sDom": '<"top">rt<"bottom"i><"clear">',

I would recommend visiting the DataTables site for docs on the options in the JS library.  The property is now called dom in 1.10.  You can also ask specific questions about the DataTable JS library in their forum


dp.change event not firing

hi
i copied the code from your docs but the change events are not being fired - any reason you can think of that might cause this?
thanks
:)

Hi, same is happening here.
Any possible idea?
Thanks

i've tried everything i can think of but no luck - not sure if it's an incompatibility with new jquery or moment or a bug in the datetime picker itself
hoping for some progress toward a fix soon or i have to dump this and use something else

I'm getting this as well.. it seems to be that on line 483 that the date and old date are the same and its not firing the event.
if (e.type === 'dp.change' && ((e.date && e.date.isSame(e.oldDate)) || (!e.date && !e.oldDate)))
it seems that 'unset' online 861 is always false so its making the oldDate always equal to the new date.
var oldDate = unset ? null : date;
dp.change will never be fired.
I'm investigating more.

so the event comes from the datetimepicker within the element?
slaps head
thanks i will try this

@fake-fur I added the HTML code to the example, in case you want to compare.
It shouldn't be relevant but, in my case I am using input-group-btn instead of input-group-addon – I edited the datepicker js file to support this.

thanks will try later when home from office :)

Trying to attach to an input. I cannot get this to work.
$('input[name="start-date"],input[name="end-date"]').datetimepicker({
    format: 'DD MMMM YYYY'
}).on('dp.change', function(e) {
    console.log('changed');
});

I found if I used the most recent release 4.17.46 it is working.
Also try attaching to the input with an ID.

@Gnative Thanks. Am on the latest version, and tried with IDs, but still no luck.

Hi, actually seems like this issue was happening in the latest version.
My code was working fine with the older version but it just stopped working after updating the plugin.
I workaround that I found in order to trigger the change event was setting a new date (could be the same as the initial one) by using the function .date()
Note: you should call it after the datepicker is initialized.
It's not an elegant solution but so far I didn't found any other way.

Using jQuery v2 instead of v3 "fixes" this for me.

This not work:
$('.date').on("dp.change", function(e){
	//doesnt work
});

This work:
$('.parent_div').on("dp.change", '.date', function(e){
	//works
});

Does #1942 (included in v4.17.47) fix this?

@lasseal This is happening to me as well, I'm on 4.17.47 but my JQuery is is an oldy, 1.12. Maybe upgrading to JQuery v2? Did you have any luck solving this?

"eonasdan-bootstrap-datetimepicker": "^4.17.47",
"jquery": "^3.1.1"

Works like a charm together.

Hi, the latest version, 4.17.47, doesn't have this error.

In my case the dp.change event was not firing because the dp.error event fires instead. When the dp.error event fires, the dp.change event does not fire at all.

I am using bootstrap datetime picker. After doing lots of research, below code works for me:
$('.data_date_of_birth').on('changeDate', function(event) {
  alert($(this).val());
});


Add support for python-polars

Besides the use of pandas, it would be great to add support for the polars Python interface: https://github.com/pola-rs/polars.
Polars has very similar functionalities to Pandas, but uses a Rust backend that significantly speeds up operations compared to Pandas.

I like what I hear about Polars, but great care will be needed to avoid upsetting user base.
Is there another popular package that migrated that we can learn from?

I can't think of projects that started in Pandas and then transitioned, and I do agree that care is needed when migrating foundational dependencies.
In my view, simply translating can give some speed up over Pandas, but some more thinking is required to make the most of the lazy execution in Polars, which would give an extra boost.


chore(master): release 1.11.0

:robot: I have created a release beep boop
1.11.0 (2023-08-28)
Features

403页面 (6fb76a9)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/KYX1234/Element-Admin/releases/tag/v1.11.0 :sunflower:


Time Lock

Today I tried paste my seed phrase but I see only "It can take a few minutes to derive all of your possible accounts and verify them against the Solana network.
Please be patient." Nothing further

It showed me this

seems resolved with https://github.com/code-wallet/timelock-explorer/commit/77a01f685dbaa4f77c2c1ec1e59b4ce568c8a388


Detect 32 bit MSVC compiler on 64 bit Python

With nuitka <IP_ADDRESS> I can not compile with correct msvc arch:

C:\kungfu\core>pipenv run python -m nuitka  --standalone --follow-imports python/kungfu/main.py
scons: warning: MSVC_USE_SCRIPT set to False, assuming environment set correctly.
File "C:\Users\dkr\VIRTUA~1\CORE-F~1\lib\SITE-P~1\nuitka\build\SINGLE~1.SCO", line 532, in createEnvironment
Error, mismatch between Python binary ('C:\Users\dkr.virtualenvs\core-feNv3oGK\Scripts\python.exe' -> 'pei-x86-64') and C compiler ('C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\bin\HostX86\x86\cl.exe' -> 'pei-i386') arches.

My environment is:

C:\kungfu\core>pipenv run python -m nuitka --version
<IP_ADDRESS>
Python: 3.7.4 (tags/v3.7.4:e09359112e, Jul  8 2019, 20:34:20) [MSC v.1916 64 bit (AMD64)]
Executable: C:\Users\dkr.virtualenvs\core-feNv3oGK\Scripts\python.exe
OS: Windows
Arch: x86_64

From the comments of Issue #225 I see this seems to be fixed, but still not working.

For what definition of correctness are you talking? Your Python version says it's 64 bits, and your compile binary path says 32 bits. That is exactly what this is supposed to find. Simply don't use a MSVC environment, then Nuitka will pick up the correct one, or alternatively know what you are supposed to do and use the correct one.
The checks caught you, which is good news to me, demonstrating their usefulness. But what made you convinced it's otherwise?

Unfortunately I have to use the MSVC environment in my project which relates to many other stuff like cmake, Node.js, etc. It would be great if Nuitka can provide an argument like --mingw64 to force MSVC to use 64bit arch.

My work has addons (written in C++) to both Python and Node.js, so I use cmake-js to build C++ sources and then pybind11 to make Python bindings. With cmake-js it can automatically pick the right arch with Visual Studio 2019 MSVC environment. I am fine to use some arguments to specify the MSVC arch if exist, right now it is just no way to me to get it going.


[LFT]: Fullstack Hacker

Background
Talk a little about yourself:

[X] Who you are:
My name is Mateusz and I'm from Berlin. I'm an experienced information security person with fullstack experience. It's my first hackathon.

[X] What you do:
I’m in the smart contract security field since 2018, where I’ve done audit and security consultation work for various teams. I’m also working in the traditional infosec field as an IT auditor for over 7 years. In the past I've been contributing as a risk assessor for Nexus Mutual (e.g. PancakeSwap v2 Risk Assessment 2, THORChain Risk Assessment). I’ve also contributed to the overall information security field (e.g. Black Hat US, Black Hat USA 2017 | Mateusz Khalil.

[X] How you got first into Ethereum:
After the DAO hack in 2016.

[X] What brings you to ETHBerlin:
I'm looking for a new project to contribute to and learn new stuff.

Skills
Tell us what your skills are:

[ ] Core Blockchain Development (Go, C++, Rust)
[X] Smart Contracts (Solidity)
[X] DApps, Web3.JS (React) *no pretty UI/UX
[X] Blockchain Operations, Infrastructure (AWS, microservices)
[ ] Game theory, Crypto-Economics
[ ] Design, User Experience
[ ] Project Management
[X] Security (Auditing, Fuzzing, ...)
[X] Data Analytics (Python i.e. pandas, basic Dune)

Communication
Consider leaving your personal Matrix address so that the team can contact you off GitHub.

[ ] Matrix handle:
@mat3--:matrix.org
[ ] Twitter handle:
twitter.com/1ultimat3

I'm going to work on #27