Cyclic Dependency Check in IoC

when ever I have e cyclic depency in Laravel, I can barely know that it is the issue I think an appropriate exception could be thrown to illustrate were the cycle is found, and suggest some break ups.
I know there are many ways to fix this cyclic issue, but thrown an exception is a huge help to just pin-point that there is one.
is there a reason why Laravel up till now don't handle this issue ?

How would we implement this?

A naive solution could be to keep track of the size of the $buildStack when resolving something out of the container and then enforce some ridiculous artificial upper limit. However, without analyzing the content of the dependency stack, any exception thrown would just indicate that there is a cycle but not explain why it is happening.

I implemented this once using:

A Waiting List array, this is an assiciative array with hashes of class names as keys and full namespaced name as values example: `[123456=>'App\Http\MyController']
Then everytime a class requests a dependancy, I check if that dependancy is in the waiting list, if its in the waiting, I thrown an exception, showing the two classes in the cycle.

I think this can be extended to include full cycles, but I haven't dug that deep in the methodology

Actually, never mind the thing about $buildStack. A fatal error occurs when there is a cyclic dependency: Maximum function nesting level of '100' reached, aborting!

I know yes, but it don't show where the issue is formed, I was just thinking maybe we can take this a step further, but showing a detected cycle.

and maybe it is only checked when APP_DEBUG is true so that it doesn't affect performance for production applications

@etcinit Exactly, it should be a configuration option, that you can turn it on and off, but when I dug into why this "limit exceeded" is thrown, it was doing a recursive function call. I think this is the real performance issue, and it would really help us understanding the nature of the issue.

There seems to be algorithms for detecting these kind of situations (like https://en.wikipedia.org/wiki/Tarjan's_strongly_connected_components_algorithm) but it seems a bit overkill for a web framework.

I think those are for full cycle detection, I used the proposed solution of the Waiting List, it is effecient just to break the cycle and show the class that had rounded cycles, maybe we can just provide this small detection. and enhance it later

Maximum function nesting level of '100' reached, aborting!

That limit would be way to low for us to impose with that build stack count. Also, note the new xdebug default in the 2.3 release will be 250. I already have applications that go over 100 nested function calls.

@GrahamCampbell so we may just need to implement the suggested algorithm, or another simple solution,
I know its a web framework, but since it depends heavily on IoC, then IMHO I think that Cyclic Dependency checks are necessary.

Ok. Are there any other php dependency containers implementing a cyclic dependency prevention algo?

@GrahamCampbell I did a small search and could find this project https://github.com/antimax/PHP-DependencyInjectionContainer, I didn't really dig deep in it, but perhaps there are other frameworks.
Also Symphony has a ServiceCircularReferenceException in its DI container have a look at
this.
Those are the ones I could find so far.

@GrahamCampbell @engma Symfony DI component checked when its compiled. I don't know/think it does the check when registering service at runtime.
Check https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DependencyInjection/Compiler/CheckCircularReferencesPass.php , which shows how it's done when compiling the dependency graph.

I disagree about running it in debug mode only. The overhead would be comparatively small.

@ibrasho I think, it won't make a big overhead, and with the deferred services in Laravel, you can limit the services loaded for each request and this way limit the overhead even further.
I will try to implement a simple implementation in the next coming days, after I deliver my current task.

I made something simple that seems to work.
I think the exception message could be better. What do you think?

:-1: This is development cycle issue which is easily covered by trivial test. Maximum function nesting level of '100' reached, aborting! is totally fine and you will see root problem 100 times in the stack trace.

Wondering is there any update on this issue.

Nothing going on here?


iOS release memory leak

The release method for iOS needs to change as below:
 [[self callbackPool] removeObjectForKey:player];
to
 [[self callbackPool] removeObjectForKey:key];

Hi @a-koka, seem like this project no longer maintained. I planning to make a new project to completly manage and play sound with some new features base on this project and our fork. But i don't have a deep knowgle in objective-C.
So, could you describe your issue and your solution more clarify?
Hope to receive a helping hand from you.

Sure, I'd be happy to give a helping hand. I have a fork myself. Curious what features/fixes your fork introduces?
Regarding my proposed change, it's a simple typo fix in RNSound.m. Look at the function below where removeObjectForKey is using an incorrect key. That's all.
RCT_EXPORT_METHOD(release:(nonnull NSNumber*)key) {
  AVAudioPlayer* player = [self playerForKey:key];
  if (player) {
    [player stop];
    [[self callbackPool] removeObjectForKey:player];
    [[self playerPool] removeObjectForKey:key];
    NSNotificationCenter *notificationCenter = [NSNotificationCenter defaultCenter];
    [notificationCenter removeObserver:self];
  }
}

you can check my fork here: https://github.com/nodejsaber/react-native-sound
i merged some fixs in pull request and rewrote js base on es6 syntax. Add Eslint to lint project.
Convert play pool key to double and unique it to prevent Media life circle lock when play a sound multi times.
So, i planning to convert all api to Promise/ Async - Await.
Add some api follow Factory pattern. You have a Factory class and diffrent type of resource need diffrent api to create sound instant. (It exactly what i'm done in our Project.)
i think it will make this library ease to use and ease to know than current.
This thinking help to manage sounds from other resources ease, and separate some specify handles of diffrent resources.
Add timeout option when create new sound from online resouces to prevent case server not respond -> resolve Promise lock when create new sound from online resources.
Update late ...

For what it's worth,  I opened #476 a while ago but no one has merged it yet =(.

Looks like this was fixed in #476.


Research on folder selector field in the config page

Instead of having to manually write a local folder, it would be ideal to have a folder selector field.

Among many others: http://stackoverflow.com/questions/2809688/directory-chooser-in-html-page


User avatar.

Added user avatar to account creation. PLS review.

Closing as this code would not allow file upload and would create merge conflicts since a lot of code has changed during migration to Entity Framework. I will ask you to reimplement a working version in the new codebase.


ppci-cc hello.c -o hello; ./hello should "just work"

The scenario:
ppci-cc hello.c -o hello; ./hello should "just work" (tm) to give a better out of box experience.
See #24 for an initial discussion about this.
Questions here:

Use a C library?
What C runtime to use?
How to deal with windows, linux, mac support?

As I mentioned elsewhere, the question of standard and runtime support libraries is a big task, which is also not really of "research" and "computer science" type of task (unlike for example IR, optimizations on it, codegeneration, etc). Instead, it's gruntwork mere engineering.
Of course this still would need to be resolved, just the same as similar "mere engineering" tasks for project building, linking, executable file generation were resolved (not completely, but "noticeably" for sure).
So, I guess the top question is the usual one:

Whether to do work from scratch, or,
Whether to reuse existing project.

One of the big points of https://github.com/windelbouwman/ppci-mirror/issues/11 (I'm nor sure if it's pronounced explicitly enough) is that it won't do to make everything from scratch - that's sisyphean effort with very slow progress, and leading only to NIH land. So, with full understanding that a quick prototype/mockup is easier to do from scratch, I'd recommend to put energy into leveraging/adaptation of an existing projects instead.

With that intro, specific suggestions:

Use a C library?

Yes. Newlib is a well-known libc implementation which is also not too bloated (used in deeply embedded projects). Note that I have an impression that recent months, I see another libc project popping up in my github feed like every month. That can be a typical turing tarpit though - some lib may be smaller and easier to leverage, but then turns out that it's incomplete, buggy, and need constant fixing.

What C runtime to use?

LLVM/Clang folks once had a same question, and it take even 10 years them to make a well complete and shiny librt. We should try to reuse it as far as possible (note that I'm personally not familiar with it).

How to deal with windows, linux, mac support?

Ughh, another tarpit. I'd say, keep doing it like it is now: keep PPCI cross-platform, but concentrate on generating one executable format well (ELF). Windows people, besides a usual option of running a Linux VM, can use WSL nowadays. Mac people can use an emulator or contribute support for MachO or whatever they use nowadays. And MacOSX is largely posix compatible, so libc efforts should just help with Mac support anyway (I mean, in larger scope than just stuff like string.h, which will also help Windows automagically).

But again, libc/librt matters are big. There's still much lower-hanging fruit:

ppci-cc hello.c -o hello; ./hello should "just work"

So, from this, immediate thing what's missing is ppci-cc call ppci-objcopy to produce a real platform executable. And I'd say, rather ppci-ld should do it, as usual. No, .oj format is cute and fine. It's just that ld's output should be a platform executable by default. Current behavior (producing another .oj) should be ld -r.

I added the link option -r. Leaving the option out, generated an elf file with objcopy. The makefile example you made can use this, and skip the objcopy step.

Leaving the option out, generated an elf file with objcopy.

Great, thanks! With winter holidays over, it will be more latency for me to look into ppci, but I hope to update the makefile example on weekend.


missing "encode" function in JVAE class of gimVI

The following encode function used to be in the
jvae.py in scvi-tools version 0.8.0 is missing in the current scvi.external.GIMVI module:
def encode(
        self, x: torch.Tensor, mode: int
    ) -> Tuple[
        torch.Tensor,
        torch.Tensor,
        torch.Tensor,
        Optional[torch.Tensor],
        Optional[torch.Tensor],
        torch.Tensor,
    ]:
        x_ = x
        if self.log_variational:
            x_ = torch.log(1 + x_)

        qz_m, qz_v, z = self.z_encoder(x_, mode)
        ql_m, ql_v, library = None, None, None
        if self.model_library_bools[mode]:
            ql_m, ql_v, library = self.l_encoders[mode](x_)
        else:
            library = torch.log(torch.sum(x, dim=1)).view(-1, 1)

        return qz_m, qz_v, z, ql_m, ql_v, library

Causing GIMVI.get_imputed_values(normalized = False) to fail in the following logic of imputing unnormalized counts:
    GIMVI.setup_anndata(spatial_data_partial)
    GIMVI.setup_anndata(seq_data)
    model = GIMVI(seq_data, spatial_data_partial)
    model.train(200)
    _, imputation = model.get_imputed_values(normalized = False) # calls JVAE.sample_rate(), involving a call to self.encode, which is missing

```pytb
[ERROR HERE]

Versions:

0.16.4

I just came across the same problem with the latest version (0.17.1).

model.get_imputed_values(normalized=True) worked as expected
model.get_imputed_values(normalized=False) led to the following error: AttributeError: 'JVAE' object has no attribute 'encode'.


dependencies update for rust[>=1.80]

Now getting
pam_rssh[1187334]: read_authorized_keys: Failed to get user name

so something still needs fixing

It works on my test setup. Could you provide logs in debug mode.

It works on my test setup. Could you provide logs in debug mode.

sudo itself returns
sudo: PAM authentication error: Insufficient credentials to access authentication data
sudo: a password is required

and syslog:
pam_rssh[1509287]: SSH-Agent address: /home/tom/.ssh/ssh_auth_sock
pam_rssh[1509287]: Reading authorized_keys
pam_rssh[1509287]: read_authorized_keys: Failed to get user name
 sudo[1509287]:      tom : PAM authentication error: Insufficient credentials to access authentication data ; TTY=pts/3 ; PWD=/home/tom ; USER=root ; COMMAND=validate

which comes from
let user = pamh.get_user(None).map_err(|_| RsshErr::GetUserErr)?;

https://github.com/z4yx/pam_rssh/blob/main/src/lib.rs#L39

It also works on my NixOS desktop.

my override
{ config, lib, pkgs, self, ... }:
let

  pam_rssh = pkgs.pam_rssh.override (old: {
    rustPlatform.buildRustPackage = x: old.rustPlatform.buildRustPackage (
      x // {
        src = pkgs.fetchFromGitHub {
          owner = "z4yx";
          repo = "pam_rssh";
          rev = "1d5bf963c9b1c5d3298bf563454e08bbeb9700c0";
          hash = "sha256-T2edexuSjLsr7BL/cXwZEiwipplKueKpNNu40n3r4+o=";
          fetchSubmodules = true;
        };
        cargoHash = "sha256-Z+axlIwCll1vrgRXCSiLmQzT84UjTYy6rE2/B2KUB/g=";
      }
    );
  });

in
{
  config = {

    # libpam_rssh
    security.pam.services.sudo.text = lib.mkDefault (lib.mkBefore ''
      auth sufficient ${pam_rssh}/lib/libpam_rssh.so auth_key_file=/etc/ssh/authorized_keys.d/rvfg
    '');
    security.sudo.extraConfig = ''
      Defaults env_keep+=SSH_AUTH_SOCK
    '';

  };
}

According to pam man pages, PAM_USER can be changed by other modules in pam stack. https://www.man7.org/linux/man-pages/man3/pam_get_item.3.html
Is pam_rssh the first module in your pam.d/sudo config?

It also works on my NixOS desktop.

this is only an issue when there's no auth_key_file configured

According to pam man pages, PAM_USER can be changed by other modules in pam stack. https://www.man7.org/linux/man-pages/man3/pam_get_item.3.html
Is pam_rssh the first module in your pam.d/sudo config?

i've tried making it the first module and get the same behaviour. my pam config hasn't changed, this only started happening after rebuilding with rust-1.80.1

digging a bit more, it appears that pam_get_user called from pam-bindings get_user is returning PAM_SUCCESS but the ptr passed to it is still null so an error gets returned. i've no idea why that is though

have also rebuilt pam with some debug logging, and pamh->user has the correct value. so, for some reason the pointer passed in to pam_get_user isn't being set
also, looks like this crate is no longer maintained so maybe its worth migrating pam_rssh to something else? (https://github.com/anowell/pam-rs/issues/13#issuecomment-1986997476)

I've replaced get_user with get_item, which is the low-level interface. Could you try the branch wip-migrate.

I've replaced get_user with get_item, which is the low-level interface. Could you try the branch wip-migrate.

Yep, that seems to have fixed it! thanks!

Great! I think get_item is more appropriate than get_user, because it doesn't prompt for user input.
I'll merge this PR and apply changes in wip-migrate.


Ctor Selection Should be Configurable by type

Relates to #19. Right now it's all or nothing. Would be nice to have the strategy configurable per type

This can be done using a "container" blueprint


Feature: preloading font in a-assets

To avoid noticeable rendering delays when first using a font, we should add preloading capability. You can already handle the font file itself using <a-asset-item src="fontfile.woff">, but we can additionally allow pregeneration of glyph SDFs using the preloadFont() utility in troika-3d-text.

yes  feature is required. Other features are very good.

Yeah I was trying to figure out the "right" way to reference the same font across troika text entities using the same custom font, seems like asset loader would help here?

...  font="#my-font"

I can see how that would be nice. I'll keep that in mind if/when I ever get to this feature.

In the meantime it sounds like you can use the asset loader for a font and that will at least make sure the font is loaded during scene loading screen and then subsequent references are cached?

Yes, that's true. All instances that reference the same font file share a single loading state and SDF texture. The font file will be loaded and the SDF will be generated per character on first usage, so there can be a period when text should be visible but it's still waiting on those things. This feature would help minimize that delay, by letting aframe's asset loading system wait for the font file to be loaded (and ideally an initial set of of characters to be generated) before entering the scene.

Thanks to @msub2 contributing the font="#assetId" support in PR #57, I believe this is now satisfied. It doesn't pregenerate SDFs, but since troika-three-text now does that on the GPU it's super fast anyway and shouldn't be noticeable in the vast majority of cases.

Hi, I'm trying to work offline so specifying the font path should work yet
            <a-asset-item id="font" src="roboto.woff"></a-asset-item>
      </a-assets>
...
      <a-troika-text target value="jxr qs a-sphere sa color blue" font="#font"></a-troika-text>

does not while <a-troika-text target value="jxr qs a-sphere sa color blue" font="roboto.woff" does.
What am I missing?

What am I missing?
Edit: I was missing the updated version since that PR, my bad, all good! :D

I'm having the same issue – what is the fix? Which PR? Thanks

I was using a version predating the PR. You seem to rely on a CDN so probably unrelated.


Migrate the CLI packaging system to the latest recommendation

I was randomly discussing packaging and CLI impact with @marstr, and I promised I will create an issue about the packaging update to do for CLI. So here it is :)
This means getting rid of azure_bdist_wheel file, using PEP420 for Python 3, etc. A more complete rational can be found here:
https://github.com/Azure/azure-sdk-for-python/wiki/Azure-packaging
I wouldn't say it's urgent, being that it doesn't impact at all the installers (Windows MSI, homebrew, etc.). Main benefits are :

For service team development, since it will simplify the dev_setup.py (remove this kind of black magic). pip install --force-reinstall azure-nspkg==1.0.0 should never be needed anymore.
Could simplify the "pip install" scenario in some corner case (shouldn't be considered a big concern)

Note that azure_bdist_wheel file logic is broken since an update of setuptools in November 2017, so we could consider as a benefit too removing a file that adds no value and just noise.

@fengzhou-msft  add to S162.

will work on this when support for Python 2 is removed.

Just to note, this does impact an internal Python project we wrote because we call out to the azure-cli and thus have this project as a listed dependency (which forces back our setuptools).
So while it surely isn't critical, I'd love to see it.

resolved in version 2.11.0.


test etcd HA functionality and recover from 1 node

https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/recovery.md

closed in favor of #120


additional information for "Migrate LDAP IdAttribute"

Summary
The explanation for mmctl ldap id migration misses some important background information compared to the old command line doc.
Additional there was a small copy & paste error for the -h section.

Hello @JtheBAB,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mgdelacroix, gentle ping on this when you have the bandwidth for a review. Thank you! :)

I'm afraid I'm not familiar with how the migration works under the hood, so I'm adding @mkraft as the tech reviewer instead.
It would be good to add these changes to the mmctl interactive docs as well, so I've created https://github.com/mattermost/mmctl/pull/374 to sync them and be merged after this one

Removed myself as a reviewer, as discussed @cwarnermm


How to configure Bot Framework C# project to send welcome message over Teams channel

Hello guys,
I developed a C# Bot and withing WebChat channel I'm sending a welcome message every time a user contacts my bot.
So, in the same way, I would like to have the same behavior when I publish the Teams channels and an user contacts for the first time my bot (no waiting until the user sends any message to the bot)
Thanks in advance!
Best regards
Lope

Hello! Any news about this?
Thanks!

@lopejum - You can send welcome message to channel when your App is installed to the team. In order to do that you need to get the Get the user ID, team ID or channel ID which then can be used to send welcome message.
Here is documentation on sending proactive message:
https://docs.microsoft.com/en-us/microsoftteams/platform/bots/how-to/conversations/send-proactive-messages?tabs=dotnet
Here is step by step guide on sending proactive message: https://docs.microsoft.com/en-us/microsoftteams/platform/sbs-send-proactive
Please let us know if you are facing any issues or need more inforamtion.

We are closing this issue for now, Please feel free to reopen it, if required.


Boolean properties and misc

As mentioned in https://github.com/sensu/sensu-puppet/commit/05999a605345ed49e455d6c92cbb34dc67fd3b85#commitcomment-10864529 , implement the boolean properties through a superclass.
Unfortunately, Puppet::Parameter::Boolean was only introduced in 3.3, so we must implement our own superclass. In the process, fixed some other issues.

I've been re-evaluating what versions of puppet I support with my modules and was thinking about this module as well.  The release of 4.0 makes me think we should drop all 2.7 support, and I believe dropping everything pre-3.3 still keeps one version of PE older than current support.  Not to muddy the waters on this, but I'm wondering if it makes sense to just use Puppet::Parameter::Boolean and make this module depend on >= 3.3.

I guess I am not adverse to that - we'll go a major release to go with it?

That would probably make sense if we remove older supported versions.  If there's other things we want to change with that we should probably have that discussion outside this PR.

Yeah I don't have anything else - unless you do - there's probably a few types/providers folks would like to replace but I don't have any bandwidth.

So would you prefer a pull request using Puppet::Property::Boolean for puppet >= 3.3.0?

Yes please!

Done. I also added another commit for using the full GPG fingerprint for the apt repository, as this generates a warning in the latest puppetlabs-apt (I can submit a separate PR if you prefer).

Thanks so much for this - excellent refactor!

Unfortunately, there is a problem. Once a property is true, you cannot change it back to false. This is because on ResourceHarness::sync_if_needed() the property value is not even checked to be in sync of if the should value is false:
if param.should && !param.safe_insync?(current_value)

Arguable this should test nil? (property unmanaged) but things are what they are. I'll prepare a fix later this week (probably it will have no normalize to :true/:false), but in the meantime you may want to revert ec9fa40.


Cleanup package.json

packaged libs should be in dependencies.
dev libs should be in devDependencies.
for example: react & react-dom are in the wrong category.

Hey team! Please add your planning poker estimate with ZenHub @andraskvr @Stijnkool


Remove device unlock from hostonly compile test

Reproduced locally, validates this test fails without an iOS device attached, and passes on this diff.
dart bin/run.dart -t hello_world_ios__compile

Fixes https://github.com/flutter/flutter/issues/100570
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/100571


visual glitches after updating some packages on Fedora (38)

Does this issue occur when all extensions are disabled?: Yes

❯ code --version
1.82.2
abd2f3db4bdb28f9e95536dfa84d8479f1eb312d
x64
❯ hostnamectl
    Operating System: Fedora Linux 38 (KDE Plasma)
         CPE OS Name: cpe:/o:fedoraproject:fedora:38
      OS Support End: Tue 2024-05-14
OS Support Remaining: 7month 3w
              Kernel: Linux 6.4.15-200.fc38.x86_64
        Architecture: x86-64
     Hardware Vendor: Lenovo
      Hardware Model: ThinkPad P14s Gen 2a

Steps to Reproduce:

launch code

I updated some packages on fedora and rebooted this somehow broke the visual display (might be uncorrelated).
Rolled back to 1.81 still same issue.
Launching code tunnel and then opening the url in the browser works ( although  since it doesn't use the same configs from the installed application its a bit of a pain to work with )
Attached few screen shots:
Issue

With extensions disabled

the problem persists on Wayland and x11

/needsMoreInfo
Is it reproducible with --disable-gpu flag?

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

Aha!
The program opens without any glitches when running code --disable-gpu

May be related to this update mentioned in blog post
https://code.visualstudio.com/updates/v1_82#_update-highlights-for-chromium

Merging to https://github.com/microsoft/vscode/issues/190437


refactor: semantic release

refactor: .gitignore updated
fix: semantic-release fix
fix: semantic-release branch renamed

:tada: This PR is included in version 2.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Don't distribute team internal config targets

Configurations/90-team.conf isn't for public consumption, so we rename
it to 90-team.norelease.conf and make sure 'make dist' and 'make tar'
don't include it in the tarball.

The name alone should be enough of a hint. It's a bunch of random team configs which are hardly relevant for public distribution. If you want to use them, t them with git.

Shrug.  Seems like demo's, kinda worthwhile to have as examples, but NBD.

This PR is ready, no ?

Not quite, the "dist" target needs to be moved, or it must be used differently...

(closed and re-opened to see that the CIs agree)
I made the small change of moving the "dist" config target to its own file.  This should be good to go now, but needs re-approval.

Reconfimr.


Auto Commit flow Engineering Discussion

Notion doc - https://www.notion.so/appsmith/Auto-Committing-Migration-c4d0951431204a77b52826280b4a963f


In Ubuntu 20.04, vvplacy doesn't work!!!

Hi, I am a beginner of rust and point cloud. I follow the instructions on github and find some error when executing vvplay
I have installed rust, gcc, g++, cmake, libssl-dev, pkg-config, libfontconfig1-dev
error message:
thread 'main' panicked at 'Failed to focus input context: XError { description: "BadMatch (invalid parameter attributes)", error_code: 8, request_code: 149, minor_code: 4 }', /home/ccw/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.27.5/src/platform_impl/linux/x11/event_processor.rs:912:30
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
Please help me! Thanks

Can you set RUST_BACKTRACE=1 and run it again? Then we will have more information to check where went wrong, thanks.

I will close this issue as there is no more information


TSDF voxel grid values

Hi,
Just for compute TDF voxel grid values given a point cloud Is it important to use Marvin ?
Is it possible to use it without Marvin (not working with windows).
Thank you in advance.

Hello! Marvin is not required for computing TDF voxel grid values.


[BUG] incorrect priority of verbose

NestJS log level priorities:
const LOG_LEVEL_VALUES: Record<LogLevel, number> = {
  debug: 0,
  verbose: 1,
  log: 2,
  warn: 3,
  error: 4,
};

so in NestJS verbose is higher than debug, but in Pino verbose (actually trace) is lower than debug.

can you point the source code for this constant?
I'm not sure if this is not a bug of nestjs, as from my experience verbose is lower then debug.
Also in the docs in this section and tight before it levels go like 'log', 'error', 'warn', 'debug', and 'verbose', if exclude the first log level one can think that other levels go from high to low

https://github.com/nestjs/nest/blob/master/packages/common/services/utils/is-log-level-enabled.util.ts#L3
right, verbose is usually lower than debug but not in NestJS

As I understand correctly, the error will only be for users who migrated from the built-in logger with verbose or debug levels and set the trace or debug levels for pino according to the level mapping table from the readme.
And the fix would be to change the mapping from verbose(nest) -> trace(pino) and debug(nest) -> debug(pino) to debug(nest) -> trace(pino) and verbose(nest) -> debug(pino).
Well, to be honest, I think it would be unclear if both loggers had a debug level that is not equal to each other, moreover, often the verbose level for other (not only JS) loggers is lower than debug. Maybe the best solution here is to add a warning about this next to the level mapping table and keep the same behavior for current users.

I migrated logger and spent some time to figure out why verbose does not work.
Maybe we should ask NestJS first if it was made intentionally.

Agree

they won't change behavior

@andkom as I understood at least before next major release. But this is surely bug/misfunctioning of Nest. The best I can suggest is add a note on this in readme with the link to original issue

OK, since they decided to fix this in next major, I believe we can close current issue. If you want you can open PR with a note on this somewhere close to levels mapping table


Add checksum property to tar_package

Description
Add checksum property to tar_package resource. Also make the properties in the README look better.
Issues Resolved
#44
Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Made requested changed, rebased, and ready to merge.


Include Github actions to dependabot.yaml

Github actions should be automatically updated by dependabot.yaml, not only Rust software

It should be as easy as:
...
  - package-ecosystem: "github-actions"
    directory: "/"
    schedule:
      interval: "weekly"


Set the access when configuring the code set table

Fix for #545

The test failure highlights some inconsistencies with the way pages and tabs are generated - I won't try and fix them all here but will try and get this particular page working well enough to copy for other components

Sorry, messed this one up a bit - it's now ready for review.
Probably need a chat about unifying components at some point!


Vulnerability roundup 51: openjpeg-2.3.0

openjpeg-2.3.0: 1 advisory
search, files

[ ] CVE-2018-16376 (unstable, 18.09, 18.03)

There is not a fix yet.
Could we tag it with a tag such as need: upstream fix ?

I would appreciate this, but I'm unfortunately unable to set labels here on GH. Perhaps it's time for someone™ to grant me necessary permissions...

@domenkozar @rbvermaa I think it is a good idea to give @ckauhaus write access
On a more local note, I created «9.needs: upstream fix», but I guess in this case we are not going to try and influence the upstream, so «2.status: wait-for-upstream» fits better. It feels like «9.needs: upstream fix» fits when we actively negotiate with upstream or prepare a patch to propose or something like that.

obsolete: 19.03 ships openjpeg-2.3.1


error when loading multiplayer lobby with MoreCompany cosmetics equipped

Hey when i join a game i have a issue, the game is freezing and bepinex console spam this

I have this modpack https://thunderstore.io/c/lethal-company/p/JusteLoneWolf/LethalBonneCompany/ is 2.0.2
Edit: it's cause with cosmitics with MoreCompany

I have this modpack https://thunderstore.io/c/lethal-company/p/JusteLoneWolf/LethalBonneCompany/ is 2.0.2

it's cause with cosmitics with MoreCompany

If you're able to reproduce the problem, could you get logs according to the instructions here? That should allow me to fix the issue quite quickly.

Unfortunately I can no longer reproduce it, sorry. I could try it probably in the evening or tomorrow.

I come back to you to give you news, I tested 1 and several items and various cosmetics, and the error does not occur at all (with just more company and bodycam, and with all the mod pack), sorry not to be able to give you more details on this bug passenger.

No worries, let me know if you have this happen again and figure out anything specific that might be triggering it.

Don't worry, I'll let you know !

When playing multiplayer games with more than three players, when the following players join, players other than the homeowner will randomly experience a screen freeze, just like the screen image pauses. But in reality, you can hear the sound, others can see you moving, but your entire screen is fixed. When he exits and re-enters the game, joining the room will also cause other non console player cards to appear. After I delete this mod, it never appears again

@apeng0907

When playing multiplayer games with more than three players, when the following players join, players other than the homeowner will randomly experience a screen freeze, just like the screen image pauses. But in reality, you can hear the sound, others can see you moving, but your entire screen is fixed. When he exits and re-enters the game, joining the room will also cause other non console player cards to appear. After I delete this mod, it never appears again

This is most likely a compatibility issue with another mod (or multiple), unless there are other factors causing it to happen to you.
If you're able to reproduce that issue with the first option mentioned here enabled, and get me the logs here as it describes, I should be able to figure out what's going wrong.
Otherwise, I'll probably need both logs and a profile code to be able to reproduce it on my end and fix the issue.

Managed to reproduce what I believe to be this issue in a play session, I pushed out version 1.2.9 with a fix for that, please report back with logs if you encounter this incompatibility with MoreCompany again.

Looks like is still not fixed:
[Warning:OpenBodyCams] In 0 seconds, GunHolsterCosmetic(Clone) will be destroyed while it is referenced by a body cam.
[Warning:OpenBodyCams]   at OpenBodyCams.Patches.PatchModelDestructionDebugging.DestroyingObject (UnityEngine.Object obj, System.Single t) [0x00000] in <50548e335bdb4d2fa1a78e660ec5c947>:IL_0000
  at MonoMod.Utils.DynamicMethodDefinition.NativeDetour_Wrapper<UnityEngine.Object::Destroy>?1 (UnityEngine.Object , System.Single ) [0x00000] in <6733e342b5b549bba815373898724469>:IL_0000
  at UnityEngine.Object.Destroy (UnityEngine.Object obj) [0x00000] in <e27997765c1848b09d8073e5d642717a>:IL_0000
  at MoreCompany.Cosmetics.CosmeticApplication.ClearCosmetics () [0x00019] in <eb37ec296e9c481db43d6bdfdda816e8>:IL_0019
  at MoreCompany.ClientReceiveMessagePatch.DMD<MoreCompany.ClientReceiveMessagePatch::HandleDataMessage> (System.String& ) [0x00000] in <eb37ec296e9c481db43d6bdfdda816e8>:IL_0000
  at MoreCompany.ClientReceiveMessagePatch.Prefix (HUDManager& __instance, System.String& chatMessage, System.Int32 playerId) [0x00084] in <eb37ec296e9c481db43d6bdfdda816e8>:IL_0084
  at HUDManager.DMD<HUDManager::AddPlayerChatMessageClientRpc> (HUDManager , System.String , System.Int32 ) [0x00000] in <af9b1eec498a45aebd42601d6ab85015>:IL_0000
  at HUDManager.__rpc_handler_168728662 (Unity.Netcode.NetworkBehaviour target, Unity.Netcode.FastBufferReader reader, Unity.Netcode.__RpcParams rpcParams) [0x00000] in <af9b1eec498a45aebd42601d6ab85015>:IL_0000
  at Unity.Netcode.RpcMessageHelpers.Handle (Unity.Netcode.NetworkContext& context, Unity.Netcode.RpcMetadata& metadata, Unity.Netcode.FastBufferReader& payload, Unity.Netcode.__RpcParams& rpcParams) [0x00000] in <895801699cfc4b4ab52267f31e2a4998>:IL_0000
  at Unity.Netcode.ClientRpcMessage.Handle (Unity.Netcode.NetworkContext& context) [0x00000] in <895801699cfc4b4ab52267f31e2a4998>:IL_0000
  at Unity.Netcode.NetworkMessageManager.ReceiveMessage[T] (Unity.Netcode.FastBufferReader reader, Unity.Netcode.NetworkContext& context, Unity.Netcode.NetworkMessageManager manager) [0x00000] in <895801699cfc4b4ab52267f31e2a4998>:IL_0000
  at Unity.Netcode.NetworkMessageManager.HandleMessage (Unity.Netcode.NetworkMessageHeader& header, Unity.Netcode.FastBufferReader reader, System.UInt64 senderId, System.Single timestamp, System.Int32 serializedHeaderSize) [0x00000] in <895801699cfc4b4ab52267f31e2a4998>:IL_0000
  at Unity.Netcode.NetworkMessageManager.ProcessIncomingMessageQueue () [0x00000] in <895801699cfc4b4ab52267f31e2a4998>:IL_0000
  at Unity.Netcode.NetworkManager.NetworkUpdate (Unity.Netcode.NetworkUpdateStage updateStage) [0x00000] in <895801699cfc4b4ab52267f31e2a4998>:IL_0000
  at Unity.Netcode.NetworkUpdateLoop.RunNetworkUpdateStage (Unity.Netcode.NetworkUpdateStage updateStage) [0x00000] in <895801699cfc4b4ab52267f31e2a4998>:IL_0000
  at Unity.Netcode.NetworkUpdateLoop+NetworkEarlyUpdate+<>c.<CreateLoopSystem>b__0_0 () [0x00000] in <895801699cfc4b4ab52267f31e2a4998>:IL_0000

Looks like is still not fixed:
[Warning:OpenBodyCams] In 0 seconds, GunHolsterCosmetic(Clone) will be destroyed while it is referenced by a body cam.
[Warning:OpenBodyCams]   at OpenBodyCams.Patches.PatchModelDestructionDebugging.DestroyingObject (UnityEngine.Object obj, System.Single t) [0x00000] in <50548e335bdb4d2fa1a78e660ec5c947>:IL_0000
  at MonoMod.Utils.DynamicMethodDefinition.NativeDetour_Wrapper<UnityEngine.Object::Destroy>?1 (UnityEngine.Object , System.Single ) [0x00000] in <6733e342b5b549bba815373898724469>:IL_0000
  at UnityEngine.Object.Destroy (UnityEngine.Object obj) [0x00000] in <e27997765c1848b09d8073e5d642717a>:IL_0000
  at MoreCompany.Cosmetics.CosmeticApplication.ClearCosmetics () [0x00019] in <eb37ec296e9c481db43d6bdfdda816e8>:IL_0019
  at MoreCompany.ClientReceiveMessagePatch.DMD<MoreCompany.ClientReceiveMessagePatch::HandleDataMessage> (System.String& ) [0x00000] in <eb37ec296e9c481db43d6bdfdda816e8>:IL_0000
  at MoreCompany.ClientReceiveMessagePatch.Prefix (HUDManager& __instance, System.String& chatMessage, System.Int32 playerId) [0x00084] in <eb37ec296e9c481db43d6bdfdda816e8>:IL_0084
  at HUDManager.DMD<HUDManager::AddPlayerChatMessageClientRpc> (HUDManager , System.String , System.Int32 ) [0x00000] in <af9b1eec498a45aebd42601d6ab85015>:IL_0000
  ...

Note that with ReferencedObjectDestructionDetectionEnabled enabled, you'll get a message when the cosmetics will be destroyed, regardless of whether the cosmetics will be updated after.
If you have the BruteForcePreventFreezes option enabled, then you should see a A cosmetic attached to [name] has been destroyed, re-collecting cosmetics. If you have it disabled, then there will likely be error spam and perhaps a screen freeze. If none of the above happen, then there is no problem.

Thank you very much for your reply

Closing this out since the latest update 1.3.0 made some improvements to MoreCompany compatibility and this hasn't been reproduced in a while. Feel free to comment here if you still have troubles when joining a lobby with MoreCompany and I'll reopen it.


Most of the times can't get the services of a device

Hi,
I am running noble in an Artik 530 that runs Fedora and am trying to access the services and characteristics of an Artik 020 that runs a Thermometer example app. I can access the information in the Artik 020 when running LightBlue Explorer app from iOS and LightBlue app from a mac and also when using bluetoothctl from the Artik 530 without any problem. But when I try the peripheral-explorer.js example most of the time I get no info:
peripheral with ID 000b570be269 found
  Local Name        = BG57961
  Service Data      =
  Service UUIDs     = 1809,1802

services and characteristics:

Only sometimes I get some info:
peripheral with ID 000b570be269 found
  Local Name        = BG57961
  Service Data      =
  Service UUIDs     = 1809,1802

services and characteristics:
1801 (Generic Attribute)
1800 (Generic Access)
180a (Device Information)
1809 (Health Thermometer)
  2a05 (Service Changed)
    properties  indicate

And very rarely I get all the information:
peripheral with ID 000b570be269 found
  Local Name        = BG57961
  Service Data      =
  Service UUIDs     = 1809,1802

services and characteristics:
1801 (Generic Attribute)
  2a05 (Service Changed)
    properties  indicate
1800 (Generic Access)
  2a00 (Device Name)
    properties  read, write
    value<PHONE_NUMBER>3631 | 'BG57961'
  2a01 (Appearance)
    properties  read
    value       0003 | ''
180a (Device Information)
  2a29 (Manufacturer Name String)
    properties  read
    value       53696c69636f6e204c616273 | 'Silicon Labs'
1809 (Health Thermometer)
  2a1c (Temperature Measurement)
    properties  indicate
  2a1d (Temperature Type)
    properties  read
    value       02 | ''
  2a1e (Intermediate Temperature)
    properties  notify
  2a21 (Measurement Interval)
    properties  write
1802 (Immediate Alert)
  2a06 (Alert Level)
    properties  writeWithoutResponse
1d14d6eefd634fa1bfa48f47b42119f0
  f7bf3564fb6d4e5388a45e37e0326063
    properties  write

I am running node.js v7.10.0 (tried also v4.7.3 that is the one that came preinstalled but nothing) and noble 1.8.1
I attach the different logs.
Any idea what might be happening?
Thank you.
bluetoothctl.txt
connection_not_ok.txt
connection_ok.txt
connection_pseudo_ok.txt

Can you replicate this with other devices ? If you have no other devices you could try using the gattserver on the NRF Connect app from Nordic. Or some other computer acting as a peripheral.

@jrobeson thanks for helping out!
@alvarosp please re-open with answers to the questions @jrobeson asked above. Thanks.


Cannot generate a new migration with ModeReplay

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

I cannot generate a new migration with ModeReplay.
ent/schema/user.go
package schema

import (
	"entgo.io/ent"
	"entgo.io/ent/schema/field"
)

// User holds the schema definition for the User entity.
type User struct {
	ent.Schema
}

// Fields of the User.
func (User) Fields() []ent.Field {
	return []ent.Field{
		field.String("name").NotEmpty(),
		field.String("job").NotEmpty(),
		field.Int("age").Positive(),
	}
}

// Edges of the User.
func (User) Edges() []ent.Edge {
	return nil
}

ent/generate.go
package ent

//go:generate go run -mod=mod entgo.io/ent/cmd/ent generate --feature sql/versioned-migration ./schema

ent/migrate/main.go
//go:build ignore

package main

import (
	"context"
	"log"
	"os"

	_ "ariga.io/atlas/sql/sqlite"
	_ "github.com/mattn/go-sqlite3"

	"atlas-sqlite-modereplay/ent/migrate"

	atlas "ariga.io/atlas/sql/migrate"
	"entgo.io/ent/dialect"
	"entgo.io/ent/dialect/sql/schema"
)

func main() {
	if len(os.Args) != 2 {
		log.Fatalln("migration name is required. Use: 'go run -mod=mod ent/migrate/main.go <name>'")
	}

	// Create a local migration directory able to understand Atlas migration file format for replay.
	dir, err := atlas.NewLocalDir("ent/migrate/migrations")
	if err != nil {
		log.Fatalf("failed creating atlas migration directory: %v", err)
	}

	// Migrate diff options.
	opts := []schema.MigrateOption{
		schema.WithDir(dir),
		schema.WithMigrationMode(schema.ModeReplay),
		schema.WithDialect(dialect.SQLite),
		schema.WithFormatter(atlas.DefaultFormatter),
	}

	ctx := context.Background()
	if err := migrate.NamedDiff(ctx, "sqlite3://main.db?_fk=1", os.Args[1], opts...); err != nil {
		log.Fatalf("failed generating migration file: %v", err)
	}
}

Running migration at first works fine.
$ go run -mod=mod ariga.io/atlas/cmd/atlas@master migrate apply --dir="file://ent/migrate/migrations" --url="sqlite3://main.db?_fk=1"
Migrating to version<PHONE_NUMBER>3708 (2 migrations in total):

  -- migrating version<PHONE_NUMBER>3312
    -> CREATE TABLE `users` (`id` integer NOT NULL PRIMARY KEY AUTOINCREMENT, `name` text NOT NULL);
  -- ok (133.214826ms)

  -- migrating version<PHONE_NUMBER>3708
    -> ALTER TABLE `users` ADD COLUMN `age` integer NOT NULL;
  -- ok (132.619177ms)

  -------------------------
  -- 266.676089ms
  -- 2 migrations
  -- 2 sql statements

Genearating a new migration then says a strange error. It should generate a migration for job field added in User schema, though.
$ go run -mod=mod ent/migrate/main.go add_job
2022/10/24 17:49:30 failed generating migration file: sql/migrate: connected database is not clean: found table "atlas_schema_revisions"
exit status 1

I can generate a new migration when I delete main.db or with ModeInspect.
Expected Behavior 🤔
A new migration should be generated with ModeReplay migration.

Steps to Reproduce 🕹
This is a repo to reproduce this issue.
https://github.com/IzumiSy/ent-migration-modereplay
Your Environment 🌎

Tech
Version

Go
1.19.2

Ent
0.11.3

Database
SQLite3

Driver
github.com/mattn/go-sqlite3

In the past, I had the same problem. Now, I get failed creating named schema diff: validating migration directory: checksum file not found. Maybe these are related.
MVP can be found at bodokaiser/entgo-migrate-diff#atlas.  From your description migrations DB and DB itself - same sqlite file (sqlite3://main.db?_fk=1). But for this migrations type they should be different.
For migration ModeReplay you need always provide connection url to CLEAN db, as it work like this:

Check if DB is clean
Apply all migrations from directory
Compare states and generate diff (same step as for inspect mode)
Cleanup provided DB (to be reusable, related to p.1)
Generate migration files

So when you applied migrations - your DB is not clean anymore, and migration generation is failing after this.

I think this is just my misunderstanding. Thanks for correcting me!


TLS Confusion

Hello. I'm a bit confused on if TLS is used to encrypt email by default in Exchange or not.  In the second section, it states "In the service, encryption is used in Microsoft 365 by default; you don't have to configure anything. For example, Microsoft 365 uses Transport Layer Security (TLS) to encrypt the connection, or session, between two servers."  If this is true, then why would we need OME, IRM, or S/MIME.  Or create a mail rule to enforce TLS, if TLS is already used by default?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 21613e57-8909-5adc-26ea-14e0a4771d3b
Version Independent ID: dcd08c8d-4786-abbd-bd9d-47ad6d2117e6
Content: Email encryption in Microsoft 365 - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/email-encryption.md
Service: o365-seccomp
GitHub Login: @KCCross
Microsoft Alias: krowley

@Canis-Lupis Thank you for your feedback.
We recommend using TLS in situations where you want to set up a secure channel of correspondence between Microsoft and your on-premises organization or another organization, such as a partner. Exchange Online always attempts to use TLS first to secure your email but cannot always do this if the other party does not offer TLS security.
For Exchange Online, we use TLS to encrypt the connections between our Exchange servers and the connections between our Exchange servers and other servers such as your on-premises Exchange servers or your recipients' mail servers. Once the connection is encrypted, all data sent through that connection is sent through the encrypted channel. However, if you forward a message that was sent through a TLS-encrypted connection, that message isn't necessarily encrypted. This is because, in simple terms, TLS doesn't encrypt the message, just the connection.
If you want to encrypt the message you need to use an encryption technology that encrypts the message contents LIke OME, IRM etc.
Hope this helps!
Thanks
Sri

@Canis-Lupis Thank you for your feedback.
We recommend using TLS in situations where you want to set up a secure channel of correspondence between Microsoft and your on-premises organization or another organization, such as a partner. Exchange Online always attempts to use TLS first to secure your email but cannot always do this if the other party does not offer TLS security.
For Exchange Online, we use TLS to encrypt the connections between our Exchange servers and the connections between our Exchange servers and other servers such as your on-premises Exchange servers or your recipients' mail servers. Once the connection is encrypted, all data sent through that connection is sent through the encrypted channel. However, if you forward a message that was sent through a TLS-encrypted connection, that message isn't necessarily encrypted. This is because, in simple terms, TLS doesn't encrypt the message, just the connection.
If you want to encrypt the message you need to use an encryption technology that encrypts the message contents LIke OME, IRM etc.
Hope this helps!
Thanks
Sri

The connection is private (or secure) because symmetric cryptography is used to encrypt the data transmitted. The email is not encrypted but just the connection.

The connection is private (or secure) because symmetric cryptography is used to encrypt the data transmitted. The email is not encrypted but just the connection.

@msbemba Thank you very much for the contribution and sharing this explanation. @Canis-Lupis Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@msbemba Thank you very much for the contribution and sharing this explanation. @Canis-Lupis Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


allow exporting the search query as json

Something was done with the Search.js fork: https://github.com/hirokiosame/search.js/tree/master
Unfortunately last update is 2 years old and it's not supported anymore..
Anyway, +1! Would be a nice feature

:+1:


upgraded to 1.1.0, undefined local variable or method `currency_value_class_info'

Upgrading from 1.0.1 to 1.1.0 yields this error:
/Users/justin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.1.7/lib/active_record/dynamic_matchers.rb:22:in `method_missing': undefined local variable or method `currency_value_class_info' for #<Class:0x007f9c29b22088> (NameError)
	from /Users/justin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/attr_encrypted-3.1.0/lib/attr_encrypted.rb:306:in `method_missing'
	from /Users/justin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/attr_encrypted-3.1.0/lib/attr_encrypted/adapters/active_record.rb:131:in `method_missing_with_attr_encrypted'
	from /Users/justin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/invoicing-1.1.0/lib/invoicing/currency_value.rb:122:in `block in <module:CurrencyValue>'
	from /Users/justin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.1.7/lib/active_support/concern.rb:120:in `class_eval'
	from /Users/justin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.1.7/lib/active_support/concern.rb:120:in `append_features'
	from /Users/justin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/invoicing-1.1.0/lib/invoicing/class_info.rb:75:in `include'
	from /Users/justin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/invoicing-1.1.0/lib/invoicing/class_info.rb:75:in `acts_as'
	from /Users/justin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/invoicing-1.1.0/lib/invoicing/currency_value.rb:116:in `acts_as_currency_value'
	from /Users/justin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/invoicing-1.1.0/lib/invoicing/ledger_item.rb:315:in `acts_as_ledger_item'

Same as #66


Crash when deleting a buffer and then recreating it during playback

We should guard against this problem with buffer access

Does not reload when you delete the buffer then remake it, but the crash is avoided


Add instructions to run via Docker

I made a Docker image so one could quickly try out scrcpy if needed.

Thank you for providing docker images :+1:
I merge the reference to your repo in the README.
One suggestion: for simplicity, maybe the docker files for intel, amd and nvidia could be in subdirectories instead of different branches?

Thanks for the suggestion. I wanted automated builds for Docker Hub but I might've overcomplicated things :sweat_smile:

adb devices returns "No devices".
I have adb locally which is working okay but the one in docker doesnt.


multi-writer for single user on multi-devices and clouds

Problem
Hypercore is single-writer. In multi-device scenarios (mobile and PC) we need to have one [virtual] Hypercore instead of 2, on each device. The same with Personal Cloud replicas. All need to act as one.
Existing approaches in Hypercore community

Materialize merged Hypercores into one (Kappa-DB does that). Drawbacks:
1.1. duplication of data (confirm?)
1.2. loses sparse access
1.3. loses the authenticity of individual records (confirm?)
1.4. loses performance

Co-Hyperdrive. Analysis TBD.

Suggested Approach
Master feed + deltas.
The solution is simpler if it is for personal use only. For teams we might create a different solution. This multi-writer builds on recent work on consensus in distributed systems both on NoSQL and in blockchain world.
Main idea

1+N feeds, master feed and one per peer.
Each peer submits changes to its own feed.
Leader subscribes to all peers delta feeds and merges them into the "master".
Each peer reads from the union of master feed and its own delta.
Replicator from master feed detects updates and removes them from delta (watch out for the race condition to avoid losing the record in union)
Union Comparator must filter out updates from master if they are present in delta
To rotate master / leader we will need group signatures, e.g. Ring Signatures. This will make the master feed identical on all nodes (subject to replication propagation).
At cluster creation we need to establish ring signature and securely communicate about it with each cluster member (TBD).

Consensus

Simple and fast Consensus. Consensus research for Databases have been supercharged with the advent of Blockchains. EOS blockchain demonstrated that if we assume all peers are on a fast reliable network with low latency, a much simpler consensus algorithm becomes possible and it converges 2-3 orders of magnitude faster (EOS can do 3000 transactions per second).

Any peer can submit a change, but only Cloud peers can write to master feed.
nodes as the only peers that participate in consensus. All personal devices present new transactions to Cloud nodes.

Which consensus algo?
1.1 PBFT is quite mature, supports Byzantine faults, but requires (n-1)/3 nodes (so minimum 7 nodes?) and has difficult leader selection.
1.1 Tendermint improves by rotating the leader every round, and skips non-responding leader automatically (who many peers minimum?)

Note.  Most changes are expected from personal devices. Later, Cloud App will also generate new data. We will limit by the data type what changes Cloud peers can initiate.
Rotate leader

To rotate quickly each peer is prepared to be a leader by subscribing to delta feeds of all other peers.
TBD leader election.

CRDT merge
Merge changes into master with the help of CRDT, used in Redit, as well as Cloud-scale databases AWS DynamoDB and Azure Cosmos. Use yjs or https://github.com/automerge/automerge).
Secure Clock
Use vector time / clocks to better resolve conflicts.

Effectively I understand this to be a "hosted hypercore with offline-capable updates from client devices." It's notable as a variation of a simple "hosted hypercore," which is a hypercore that exposes its API to the network to accept writes from clients via RPC.
In your proposed model, each client device maintains a set of deltas (which I might call the "staging cache") which it can sync to the hosting device at any time. Until sync, the client device will read a union of the currently-known master hypercore and its local cache, enabling live writes in an offline context.
A "hosted hypercore" model loses the ability to accept writes in an offline context. This proposal can continue to accept writes when offline, but will not propagate the writes to the network until the client device can sync with the master device. It is a simpler model than masterless multiwriters, but it maintains offline-first abilities.

1.3. loses the authenticity of individual records (confirm?)

Not sure about the other properties but I'm pretty sure each writer uses their own hypercore and so authenticity isn't lost.

The solution is simpler if it is for personal use only. For teams we might create a different solution.

I usually refer to this as "multi-device" vs "multi-author"

Leader rotation & consensus algorithm

What requirements do you have which require leader election and a consensus algorithm? Are you assuming the master would not be able to appoint a new leader, eg due to catastrophic data loss?

@pfrazee thank you for the comments! I will review in full, and react to all, but want to share the correction to the first statement. Our intent is not just a hosted Hypercore. We want Cloud Apps to work there too. So updates will be initiated both in the cloud and on devices. In this way they are symmetric. But they may not need to be symmetric in the way updates are pushed. For example, a 10MB file does not need to be uploaded from a device to all Personal Cloud replicas and to other devices. This would be quite inefficient, and costly on a data plan. So updates could be sent to one of Personal Cloud replicas to be disseminated further.

Great writeup! There's some cool stuff in here. I think you might also want to look into what CoBox made with their Kappa-Drive module which is kinda in between co-hyperdrive and kappa.
Regarding co-hyperdrive/multi-hyperdrive:

I don't think the watch() function actually downloads data unless you do some sort of FS operation like readdir on watching
The consistency is actually decent if peers are online and replicating. Notification of changes will go pretty fast through all the peers. If all peers see the same latest index for all the feeds, then they will resolve to the same view of the "latest file".
That is to say, It's "eventually consistent". vector clocks and the such won't change the consistency guarantees but will help for the cases where two peers are writing at the same time but have clock skew.
I don't think backups are quite as complicated as you're imagining. In order to backup, you send the URL of the co-hyperdrive you wish to download, and it'll automagically be downloading from all the sources at once. This is happening in the Natakanu project with decent success, and there's lots of room for improvement.

@urbien multi-hyperdrive doesn't do anything for adding peers automatically and relies on the addDrive API to be called by the application.
co-hyperdrive adds in the automatic writer tracking by storing writers in the hypertie.
When you authorize() another writer key, it get saved to a hidden key inside an existing writers hypertrie.
Other writers will detect the change in the hypertrie and then make sure they've loaded the full list of writers / detected removed writers and purged them.
So with that you can be sure that if you authorize() a new writer (provider you're already a writer), anyone else replicating will see the change. I've tested this in the Natakanu app and it's honestly a little magical how it just works.

Regarding the updated cons for co-hyperdrive:

Network: painful fan-out on a data change. If pre-fetch on watch event is used it number of peers in the swarm * data-size. If pre-fetch is not done, the file still can be requested on more than one peer, and it will be uploaded more then once. Besides, the mobile may not be online to provide the data (waking up mobile app in background mode is possible but it has limitations).

This isn't any different than downloading all the data of a single writer. No sure "will be uploaded more than once" would mean. When a peer tries to load a file, it'll see who it's connected to that has the data and fetch individual blocks once between all the peers. It won't load the same block twice. Mobile peers being offline is the same as the single writer scenario and requires backups of some sort for higher resilience in the same way.

Consistency: can end up with different in state of each master (needs CRDT and clocks)

This is only true for when peers are offline and aren't replicating with anybody. This is the same regardless of whether you're using CRDTs or clocks. The only alternative is not allowing reads when you're not replicating.

Collaboration: coarse conflict resolution, but can be improved with CRDT and file metadata

This is partially a limitation of hyperdrive not having coarse random-access reads.

TODO: Is tracking changes reliable? can watch events get lost, e.g. when peer dies?

If a peer is offline and it writes, then there's no way for other peers to get it's new data, I don't think there's any way around it except preventing peers from being able to write if they don't have any other peers.

on the folowing issue

TODO: Is tracking changes reliable? can watch events get lost, e.g. when peer dies?

If a peer is offline and it writes, then there's no way for other peers to get it's new data, I don't think there's any way around it except preventing peers from being able to write if they don't have any other peers.

I just realized that the merge should be done at the stage when resource is about to be submitted
Some flow example:
User uses 2 devices: phone and laptop

User makes the changes on his laptop.

Receives an urgent call.
Closes computer without submitting the changes

User takes his phone with him.

Some idea strikes.
He makes changes on the phone to the same resource he started making changes on his laptop.
Submits the changes

Back home.

Opens computer.
Makes some more changes (to already stale resource).
Submits the changes

We ended up with two versions of the same resource that need merging before submitting.
In Tradle we can detect that the version of the resource that is been changed is not the same as the most current one
That's where we can initiate the merge

first alpha release of multi-hyperbee is out and passes a bunch of tests. The work continues to:

adding more tests
save / restore related feeds
and to make Dynalite (DynamoDB emulation on LevelUP) work in embedded mode (removing HTTP marshaling)

See the roadmap on multi-hyperbee repo


Fix manual Makefile by including function doc generation

Since #53055 was merged the Makefile for the manual could not be run
correctly as the generated function documentation was included, but
not actually generated.
This adds the necessary generation step by first building the XML file
containing function locations and preserving its store path in a
variable, which is then used both for linking of the locations file
and as a build input for the function docs generator.
This fixes #55014
Side note: Recreating the derivation dependencies this way in the Makefile is a little bit awkward. Better suggestions welcome! :thinking:

Motivation for this change
Manual builds were broken (as per #55014)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

When reproducing the failure/success, be sure you make clean, as the file isn't re-generated without cleaning.


I can't see in the documentation how you actually get the value

I can't actually see in the readme where you get the value of <Datepicker />? Can you still use refs?

How did you end up doing it? I know onChange will let you get the value but I would like to do it using refs.

Still no docs.

Hey!
I think this is an usual problem for developers starting using react, don't know if this is your case.
Input type of components are usually used in a controlled way, so weset the prop value with some date that westore and keep track of it.
Then when the value changes, weneed to update the value of our variable, and that will be given again to the datepicker. So wealways have the value stored by ourselves.
See react docs: https://reactjs.org/docs/forms.html#controlled-components
In case you don't like controlled components (that you should if you are using react) you can use it in a uncontrolled way using defaultValue and you can listen to changes using onChange. The problem is that you won't be able to update the value programmatically that way. You are just a listener.
https://reactjs.org/docs/uncontrolled-components.html
In case you don't like any of those alternatives, you can access to the internal state of the component's instance using refs. Totally discouraged, because internals can change at any time without any advice breaking your application completely. If we don't care about it and want to use the component in a way it was never thought of, it's possible to access to the internal value using:
// in the render method
<Datetime ref={ instance => this.picker = instance  }/>

// anywhere else in the component
let date = this.picker.state.selectedValue

@arqex It's a nice plug in but It would be better if you put how to get Datetime component value when onChange and how to set initial value


[Feature]: update readme

Describe feature to implement

update readme on how to get serviceCode
add rationale on why the tool was created

resolved i main


fix: gosec warnings

This commit fixes all gosec warnings either via ignoring the error, where it makes sense
or via fixing it. I have fixed multiple implicit memory aliasing errors in loops.
These can be dangerous. For more information: https://stackoverflow.com/questions/62446118/implicit-memory-aliasing-in-for-loop
Fixes: OSD-11463

@fahlmant I fixed the last two issues + I will ask the security team for a review.

Code seems fine, thanks for improving the code quality 👍
For the 2 points I reported, there are several occurrences of them in the code. Please fix them all.
I guess that in the future we want to enable gosec linter in the builder to keep sure the code remains correct for this linter. Is there some ticket tracking that?

I guess that in the future we want to enable gosec linter in the builder to keep sure the code remains correct for this linter. Is there some ticket tracking that?

I think there is an epic for gosec preparations.. if this is complete the plan is to enforce gosec for all projects.

/unhold
Please lgtm or hold again if you are unhappy


Don't call ValidateBundle in cmd.Start()?

At the moment, running crc start requires that a .crcbundle file exists, even if it will not be needed by the next steps.
This is because of the call to validation.ValidateBundle() in cmd/crc/cmd/start.go
This check is useful when the VM does not exist already, however it's not useful when the VM has been created already as nothing will need the bundle.
Not exactly sure yet what the right behaviour would be. Maybe this logic should be moved to machine.Start() where we have better control over whether the VM already exists or not.

Duplicate of #952 which is still open


chore: update deprecated modules

github.com/libp2p/go-libp2p-host -> github.com/libp2p/go-libp2p-core/host
github.com/libp2p/go-libp2p-peer -> github.com/libp2p/go-libp2p-core/peer
github.com/ipfs/go-ipfs-addr -> github.com/multiformats/go-multiaddr
Also .gitignored the leveldb folder

Replaced.


ci: upload binaries on release

Requires @mcuadros or @ajnavarro to add a GITHUB_TOKEN environment variable to the travis configuration.

token added to travis.


Update path without effects

Codecov Report
Base: 100.00% // Head: 99.73% // Decreases project coverage by -0.27% :warning:

Coverage data is based on head (44f5aa1) compared to base (4079c90).
Patch coverage: 93.33% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@              Coverage Diff              @@
##              master      #24      +/-   ##
=============================================
- Coverage     100.00%   99.73%   -0.27%
- Complexity       124      127       +3
=============================================
  Files             11       11
  Lines            373      378       +5
=============================================
+ Hits             373      377       +4
- Misses             0        1       +1

Impacted Files
Coverage Δ

src/AsTree.php
99.02% <90.00%> (-0.98%)
:arrow_down:

src/Relations/HasManyDeep.php
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Can't remove deleted Reddit account

I tried these instructions to remove a deleted Reddit account, but all I could do is add my new reddit account, not remove my old one.
https://brid.gy/about#add-remove-url

Hey Todd, sorry for the trouble! If the old account is deleted in Reddit, I assume that means you can't log into it any more? Bridgy expects you to auth as a given account to prove you own it before it will let you disable/remove it, so that won't work in this case. I'll just go ahead and disable it manually instead.

Correct, can't authenticate to that account that doesn't exist anymore.
Thank you!


Timepicker on  tag: model is undefined

Bug description:
Model is undefined after UI-change. Spinners works well, but after direct input the model is undefined.
Link to minimally-working plunker that reproduces the issue:
http://plnkr.co/edit/UzER1XUzfMYkHTnkjo8Z?p=preview
Version of Angular, UIBS, and Bootstrap
Angular: 1.5
UIBS: 1.2.5
Bootstrap: 3.3.6

You actually want to use this control with a div - see here.
Going to close as a simple usage issue.

This workaround is known. The problem is, if I add angular functionality to my page, I MUST change my working code... It's not very good. Apart from then, an -tag is semantically correct. Can You fix it?

This is probably not something we can support - the input directive modifies the ng-model flow.
It would be better for you to change to use another element.

Should I do it for all input- and select- tags?

Yes.


bry_time is hardcoded in step 9b for MARBL setup (easy-fix)

bry_time is hardcoded in correction_on_BRYtime.m
This is not a good practice and should be very easy to fix

Hi @ubbu36 do you know if this got addressed? If it is still a problem could you raise a new issue over on the relocated MATLAB setup tools repo? https://github.com/CWorthy-ocean/matlab_setup_tools . I will close it here for now.


pattern-validation: refactor

Added JSDocs, fixed formatting, removed redundant code and improved some of the implementations.

Hey @VoltrexMaster thanks for your PRs 🍻


Implement audio language definition by folder name

Until the definition is implemented, all subtitles are marked as Russian


: A negative 'height' with 'rx' will crash the app

Bug
This seems like a pretty small / straightforward-to-repro bug
Using

"expo": "~41.0.1",
"react-native-svg": "12.1.0",

✅ For a <Rect/> component, a negative height (ex. -10 or "-10") still renders fine
❌ But when you have a negative height AND you specify rx, the app crashes, and with zero console output (at least I wasn't able to log anything). Through trial and error, I finally narrowed down the repro steps.
THIS WILL CRASH YOUR CODE
<Rect
  x="15"
  y="15"
  width="70"
- height="70"
+ height="-70"
  stroke="red"
  strokeWidth="2"
  fill="yellow"
+ rx="10"
/>

Environment info
Run react-native info in your terminal and copy the results here. Also, include the precise version number of this library that you are using in the project
React native info output:
System:
    OS: macOS 11.4
    CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
    Memory: 899.54 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.16.0 - ~/.nvm/versions/node/v14.16.0/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 7.11.2 - ~/.nvm/versions/node/v14.16.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: Not Found
  SDKs:
    iOS SDK:
      Platforms: iOS 14.5, DriverKit 20.4, macOS 11.3, tvOS 14.5, watchOS 7.4
    Android SDK: Not Found
  IDEs:
    Android Studio: 4.2 AI-202.76<IP_ADDRESS>51085
    Xcode: 12.5/12E262 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.1 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: https://github.com/expo/react-native/archive/sdk-41.0.0.tar.gz => 0.63.2
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Library version: "react-native-svg": "12.1.0",

Also happening to me. Thanks for making this known.

Facing the same issue, any workarounds?

happing to me. Please help me to solve it.

Can confirm this is happening on 13.9.0

Also happening to me. Expo 48.0.18 react-native-svg: 13.4.0

Hello @thiskevinwang,
I couldn't reproduce that problem, if you still have some issues, feel free to open a new issue.
Thank you


Expose project parsing errors

Related to #5925
We should expose project parsing errors to help in debugging scenarios.

@waldekmastykarz I would like to work on this issue.

use the logger to log to stderr
or
throw a CommandError ?
Do you need unit tests for this scenario ?

I suggest we throw CommandError, and yes, we'll need unit tests to confirm it's working as intended.
@pnp/cli-for-microsoft-365-maintainers agreed?

Yes, I agree that throwing CommandError should suffice for this case.


Support --username and --password as parameters to jenkins-cli.jar

When security is enabled, and realm is set to UNIX user/group database, it is impossible to use the jenkins cookbook with a UNIX user. This is because private key authentication is disabled, which in turn is due to JENKINS-22346.
The jenkins-cli.jar utility accepts the parameters --username and --password, which enables the use of a UNIX user again. This functionality is, sadly, not supported by the cookbook.
I kindly ask that you implement this feature, either as parameters to the resources, or similar to the private key variable in node.run_state[:jenkins_private_key].

Hi,
I tried to use your patch (against 2.2.2 version of this cookbook), and can confirm that it works correctly. When node['jenkins']['executor']['cli_credentials'] attribute is set, Chef will use them and successfully authenticate against Jenkins instance.

try java -jar jenkins-cli.jar -s http://localhost:8080 who-am-i --username admin --password fe3f1e1624ea4be8873b7a35e28b24be

should i give my username password each time when I use a command

No @sathizzh, you could do the login command to be logged:
$ java -jar "/tmp/kitchen/cache/jenkins-cli.jar" -s http://localhost:8080 login --username jenkins --password foobar

User -auth:
-auth ram:ram

After some trial and errors, got it working by this aliasing statement for jenkins-cli
alias jenkins-cli='java -jar /var/lib/jenkins/jenkins-cli.jar -auth admin:admin'
After this aliasing, you can use the commands like:
jenkins-cli help jenkins-cli who-am-i
and many other commands (listed by help)
In my case here, I had added SSH key for 'admin' user of Jenkins and I had changed its password to 'admin'


Create edumail.txt

Department of Education and Training Victoria

portal url: http://www.education.vic.gov.au/school/teachers/hr/Pages/edumail.aspx


Remove duplication vision strategy

Description
The two pages were nearly identical, this PR removes the duplication. It's not meant to have semantical impact, a PR to do so will follow later.
Related Issue(s)

Checklist

[x] I have read the contribution guidelines
[x] I have considered the performance impact of these changes
[x] Suitable unit/system level tests have been added and they pass
[x] Documentation has been updated

Good to merge once tests pass.


Fix many typos and links in ADQ component docs and navigation

This fixes countless documentation typos and not properly links in the ADQ digitizer channel component, which I omitted yesterday to get the component merged and ready for a meeting with users today. I also fixed the navigation, which I didn't properly keep up to date in my ignorance.
There's one very small functional change as well in 6c9064b275aa1120f12f287037b065b2c9b7ddad: While checking docs, I encounted one small bug in that the roi/train_roi passed to train_data/pulse_data did not actually work as slices as advertised, but tuple of a slice as if it's passed to KeyData.ndarray. Since the shape of digitizer data is known, this seems unneccesarily complex. For ease of implementation, I continued to allow this tuple form and wrap a slice into it accordingly.
Finally, there's one setting of mkdocs I would like to change in d52a031e5791ef1afbe65fe2db61dcc96b54154b by enabling show_symbol_type_doc. I always found it hard in the comparbly long list of some components to distinguish properties from methods. This introduces a visual difference:

Thanks for review


Add quality declaration documents

This PR adds quality declaration documents and (where necessary) basic README files too all packages in rmf_demos.
The resource packages meet the requirements to be Quality Level 3. All source-code-containing packages are currently QL4.

I just noticed that the packages these quality declarations are targeting no longer exist as they were split up between a bunch of new packages. I'm working on refactoring the quality declarations into the new packages.

@luca-della-vedova, it seems that GitHub will need you to change your review to an approval before it's willing to merge.


Planner/Project Management Tool Functionality

Use python's built in time and date libraries to build basic scheduling and reminding features.
The added commands are:
todo - Displays the TODO list for all the incomplete events scheduled for the future
describe - Display the details of the specified event/task
assign - Assigns a specified event/task to a specified user
add_task - Adds a task to the TODO list
add_desc - Adds a description to the specified event/task
cat - Adds an event to a specified category
due - Sets the due date of the specified event/task
remind - Set how long before the due date to send the users assigned a reminder
done - Marks an event as complete

P.S. I also cleaned up the fuck_praxis a bit.

c4458c6 fixed latex rendering for wikipedia feature

I have hosted the bot already, will switch the main branch for my own version. Hence, closing this.


feat: Add OpenFeature.Extensions.Hosting package

Closes: open-feature/dotnet-sdk#264

Related

open-feature/spec#81

open-feature/ofep#32
open-feature/spec#227

TODO:

[ ] moar tests

[ ] evaluation context

[ ] IHostingEnvironment sample

[ ] hooks
[ ] providers:

[ ] none
[ ] one
[ ] multiple

[ ] xml docs
[ ] readme docs

FYI couple of known test failures:

DCO is intentionally broken by a temp commit containing a squash of #187 and #188. Once those PRs are merged, I'll rebase and elide the temp commit.
dotnet-format is being weird about OpenFeatureHostedService and I'm pretty sure its just a sign that we need to migrate from the dotnet-format tool, to the new dotnet format that's baked into recent SDKs.
flaky unit tests: pretty sure these are all related to the async stuff, so hoping they'll be less common after #184 lands, but in the meantime please just re-run the test if its failed at the time of your review.

Is this PR going to be merged? I was looking forward to this capabilities with version 2.0

Is this PR going to be merged? I was looking forward to this capabilities with version 2.0

@nbr28 This is still being worked on, mostly by @askpt :pray: . We are still planning to merge once it's completed.

Superseded by #310


Export does not thing after a while, has to restart Zotero.

Just a minor bug, when after a while the export button does nothing.
I have to restart Zotero completely to get this functionality back.

If you can recreate this and show me the debug output I can try to diagnose the problem!

(3)(+0001773): NS_ERROR_FAILURE Exception: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFilePicker.init] init@chrome://zotero/content/modules/filePicker.js:60:258 writeExport@chrome://zoteroroamexport/content/roamexport.js:375:9

this is what show up in the debug log after I clicked export to Roam.

Interesting, I think it has something to do with asynchronous processing, but the problem seems to lie with the filepicker library. Did you have another filepicker open at the time? In any event, I wonder if this is an edge case that will be difficult to replicate.

Sorry I have no idea what is a filepicker and a quick search doesn't help.
But yeah this is probably just a weird edge case not with an easy work around so not worth spending time on it.

It's the thing that pops up where you specify the name of and the location for the export -- it's part of Zotero's internals and not this exporter.
I'll close this issue for now 👍


Issue merging LoRa adapters back into gptq quantized model

System Info
A PEFT model cannot be merged with the quantized model and pushed to hub...The error is:

Cannot merge LORA layers when the model is gptq quantized

after trying:
model_id = "ybelkada/llama-7b-GPTQ-test"
model = AutoModelForCausalLM.from_pretrained(model_id, device_map="auto")

from peft import PeftModel

# load PEFT model with new adapters
model = PeftModel.from_pretrained(
    model,
    adapter_model_name,
)

model = model.merge_and_unload() # merge adapters with the base model.

Note that 'model' is the gptq quantized model, origin
I had originally posted in autogptq but realise this may be a question for here.

### Who can help?

@fxmarty perhaps you could assist? Maybe there is an alternate approach

### Information

- [ ] The official example scripts
- [X] My own modified scripts

### Tasks

- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details below)

### Reproduction (minimal, reproducible, runnable)

See above

### Expected behavior

Typically, this approach of merging (like when I do it with NF4 quantization) will work.

Hi @RonanKMcGovern, this is not a bug. We still haven't implemented the merge_and_unload() for gptq quantized model. Feel free to request this as a feature enhancement in peft library.


How does Tensor.where_ work?

I can not find an example or a test covering its use

Here is a small test illustrating this. The behavior should be similar to torch.where.
#[test]
fn where_() {
    let t1 = Tensor::of_slice(&[3, 1, 4, 1, 5, 9]);
    let t2 = Tensor::of_slice(&[2, 7, 1, 8, 2, 8]);
    let t = t1.where_(&t1.eq(1), &t2);
    assert_eq!(Vec::<i64>::from(&t), [2, 1, 1, 1, 2, 8]);
}

Great, eq method was what I was missing

Any boolean tensor can be used for the first argument, so t1.eq would work but also t1.gt, t1.lt, etc.

Understood, thank you.
Also as a general comment, according to the doc, the method apply_ of the Tensor struct takes a function implementing the nn::Module trait as argument. Would it be possible to pass to it a function implementing Fn(&Tensor) -> Tensor for example?

Fwiw I've added the where_ test to the standard test suite so that it's easier to discover.
Re using closures directly in apply_ that's actually not very straightforward: if we would like closure to implement the Module trait they would also need to implement the std::fmt::Debug trait which is not currently the case. Introducing our own Debug trait would probably help but doesn't seem very nice.
An easy solution would be to add a method with a different name than apply, e.g. map, but not sure if it would help this much, e.g. we would be able to write something like xs.apply_(&mymodule).map(|x| x.exp() + 1).

Great news about the where_ test. I think many coming from PyTorch would not know the comparison methods (ge,eq,lt,etc...) so best to have a small test showing its use.
Thinking about it, apply in PyTorch can be replaced in most cases by an explicit Tensor calculation so it is more convenient than functionally critical. But one thing PyTorch does not seem to support is an apply_row function that loops through a tensor row-by-row and stacks the output. Do you think such a function could be useful?

Maybe it would make sense to have such apply_row function indeed or some equivalent of map or fold. I imagine that the reason why it's not there is that this would result in some python loop which would be slow and run on the cpu and you should rather write use some vectorized operations that are more efficient. That said it's not always possible/desirable to use vectorized operations so it could actually be helpful to have this apply_row (also the cost of the loop in rust should be far less than in python - even though it's cpu only).

I am not sure why such a function is not available. It is probably the same reason why some of the tensor methods can not be "broadcast". If it was just a performance issue in Python, it would exist in the C++ library, and I am not so sure it does. I will look into it after I have finished writing the next tutorial...


Add trace-plotter to tools

Hello! This PR adds trace-plotter to tools.
trace-plotter is a program to plot a CDF latency graph of Zipkin traces.
To make it easier to get all traces out of Zipkin, I added some instructions on running Zipkin with an elasticsearch backend, but it is still runnable with the in-memory database Zipkin as well

[x]  sign the commit
[x]  add copyrights to all files
[ ]  run golinter on the code (make sure the CI does run on it)
[x]  fix the docs
[x]  add CI that sets up a workflow with helm, etc. You can run a KinD container on a github-hosted runner
[x]  move example YAML files to a subfolder
[x]  remove redundant/optional code

linter action seems to fail because of spellcheck issues with CDF and Elasticsearch
Other test fails do not look relevant to this pr.

good job, thank you!


Payload - 413 Request Entity Too Large Error

First I want to say thank you for the really cool swagger rest-api adapter. Under the existing admin user everything runs smoothly so far. With another new user (in admin group) I unfortunately get "error": "permissionError", but this is at the moment okay and will check this later. But I ran into another issue with my normal admin account.
The PUT command  to create and update state objects is generally working, but when I try to write large JSON data with e.g. the Rest API command:

setState(id, state) - set state value with JSON object (e.g. {"val": 1, "ack": true})

I get a 413 - Request Entity Too Large Error in my test case.
As a quick workaround I commented in the file 'obroker.rest-api/node_modules/raw-body/index.js' the following parts:
Lines 157-163
 /*   if (limit !== null && length !== null && length > limit) {     return done(createError(413, 'limit: ' + limit + 'length1: ' + length +  'request entity too large', {       expected: length,       length: length,       limit: limit,       type: 'entity.too.large'     }))   }   */
Lines 262-272
 /*     if (limit !== null && received > limit) {       done(createError(413, 'request entity too large', {         limit: limit,         received: received,         type: 'entity.too.large'       }))     } else if (decoder) {       buffer += decoder.write(chunk)     } else {       buffer.push(chunk)     }     */
Without these checks I can write large JSON data successfully.
Expected behavior
Now I would like to know why the check is necessary and if there is a better solution for it. Can I perhaps set the limit in the header during the HTTP request?
Versions:

Adapter version: 1.0.0
JS-Controller version: 4.0.23
Node version: v14.18.1
Operating system: "Raspbian GNU/Linux 10 (buster)" - ARMv7 Processor rev 3 (v7l)

What exactly are "large JSON data"? So how large is large in your case?
It eems that body-parser has a default limit of 100kb ... yes this is not that much :-)
So the clean solution is to pass "limit" as option to https://github.com/ioBroker/ioBroker.rest-api/blob/master/lib/rest-api.js#L261
see https://github.com/expressjs/body-parser#limit
@GermanBluefox To what we should limit?

Perfect, many thanks for the quick answer! This was exactly for what I was looking for.
In my case I tried to store approx. 500 Server objects from a JSON, each object has optional ≈ 15-20 extra attributes.
The file itself has about 500kb.
It seems that the standard is 2097152 (not kb) characters, which is equivalent to 4 MB of Unicode string data.

https://docs.microsoft.com/en-us/dotnet/api/system.web.script.serialization.javascriptserializer.maxjsonlength?view=netframework-4.8
https://www.ibm.com/mysupport/s/question/0D50z00006AB2wNCAT/json-type-length-exceeded?language=de

No, the defaukt is 100kb as shown on the page linked above. All fine ... also 4MB is small ... We need to decide what we set as limit ... but maybe 4MB is a good start? @GermanBluefox

(bluefox) Increased the max size of body to 100Mb
in 1.0.1

My problem with the permission denied error is also fixed now. I only had to enable the SSL encryption and now I can use a different user than the default admin. @GermanBluefox maybe you can add this info to the main README.md overview.

I am not quite sure, that I understand you. Does it required to enable SSL to use other users but admin?


[Q] Python bindings in (Windows) PORTABLE package

Hi @lelegard ,
Any reason to not include the Python bindings inside the Portable Windows package?
I'm including this inside my python scripts to use the TSDuck without install:
import sys
sys.path.append('C:/Portable/TSDuck/python')

import ts
...

I suggest to include this small subdirectory in the package. And perhaps the Java binding too.
And please, document (if you want) this simple method to use the binding with the portable version.
I hope this helps others as well.
Regards.

The Windows portable package only includes the tools and plugins, not the development environment. I can modify it to include the development environment for C++, Java and Python, but this will make it much bigger.
I understand that you are interested in Python only. But a C++ or Java developer will legitimately ask "why him and not me?"

The Windows portable package only includes the tools and plugins, not the development environment. I can modify it to include the development environment for C++, Java and Python, but this will make it much bigger.
I understand that you are interested in Python only. But a C++ or Java developer will legitimately ask "why him and not me?"

Hi @lelegard ,
I have this "simple" solution: Create a new package named "dev-bindings.zip" that represents the portable version of the Python/Java/C++ environments.
At time, in Windows to "extract" the python binding I need to install, copy, deinstall the Windows version. Or do a git clone, or ZIP download... Several different solutions exist. However, a simple package will be welcome.
So, please consider it.
Thank you!

Hi @lelegard ,
I close this request as you've already implemented it https://github.com/tsduck/tsduck/commit/35c7f804aaa2f60aa04adf95377e7c9658f1de35
Thank you!


Update readme.md

It took me a few minutes to figure out how to install this forked version of the lib, So I guess it is fair to say that this might happen to everybody. Especially since the README.md is somewhat old:
https://www.npmjs.com/package/graphql-depth-limit-ts#usage
Gonna open a PR.

Off-topic: BTW Do you think that what I did here is analogous to what this lib does?


Just one line changed in index.html file to check how git works :)

Looks like you removed the youtube video so I'm not merging this ;)
But feel free to make more pull requests and learn more about git :) this project it's all about learning


Create y115

@DRockMiller Please rename lib/domains/org/y115 to lib/domains/org/y115.txt. Thank you.

Renamed.

@DRockMiller Thank you! Pull request merged.


skip_prompt=True in TextIteratorStreamer

What does this PR do?
Adds skip_prompt=True in TextIteratorStreamer.
Instead of the output in https://github.com/huggingface/trl/issues/1866#issuecomment-2396987672, you get:
<quentin_gallouedec>:
Hello, world!

<microsoft/Phi-3-mini-4k-instruct>:
This is a simple greeting message. You can imagine it as if someone is writing a note to say hello to the world. It is
equivalent to saying "Hello, universe!" or "Hello, everyone!"

<quentin_gallouedec>:
What's your opinion?

<microsoft/Phi-3-mini-4k-instruct>:
I don't have personal opinions. As an AI developed by Microsoft, I don't form opinions or feelings. My role is to provide
information and assistance based on the data and programming I have been given.

Not 100% why it solves the issue. But it does.
Fixes #1866
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a GitHub issue? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

just realised I've not pushed the right commit. Now it's all good


Audit and DLP activities

Feature Request
Is your feature request related to a problem?
As an administrator I need insight into audit and DLP activities, so I can better understand what is happening within my environment
Describe the solution you would like
Incorporate data from the Office 365 Service Communication API as documented here

Tirage - Work on this feature has started and is expected to be complete by the end of the week.

This feature has been added with PR #114


samples/net/promiscuous_mode the include file is not there

Describe the bug
there is no net/tcp.h file to include
To Reproduce
Steps to reproduce the behavior:

mkdir build; cd build
cmake -DBOARD=frdm_k64f ..
make
See error

Expected behavior
sample need update
Impact
sample
Screenshots or console output
/build/src/workspace/frdmk64f_master/samples/net/promiscuous_mode/src/main.c:17:21: fatal error: net/tcp.h: No such file or directory

 #include <net/tcp.h>

                     ^

compilation terminated.

CMakeFiles/app.dir/build.make:62: recipe for target 'CMakeFiles/app.dir/src/main.c.obj' failed

Environment (please complete the following information):

OS: ( Linux)
Toolchain ( Zephyr SDK)
Commit SHA or Version used: v1.14.0_rc2

https://github.com/zephyrproject-rtos/zephyr/commit/ebce5601c05d76fa75cbd478fa68e56502fa763a already merged.


Add ModuleConcatenationPlugin

Resolves #1318
I'm also going to add a note to #1331 so that we note this in the Production guide when we rewrite it.

@simon04 merging, but please let me know if there's some other enhancements we can make to this page. It doesn't seem like this plugin takes any options/parameters. I basically just used a re-worded version of @TheLarkInn's description in his blog post.
(@TheLarkInn hope that's ok!)


Wht don't you put padding and margin features in FlexContatiner(not child)?

It is more efficient than using a separate MarginContainer because it is processed at once when calculating FlexContaminer layout.

Due to the initial design, I defined FlexContainer as a Container node in Godot, following the behavior of Container. MarginContainer node handles the margin itself, and currently neither the container nor its child nodes have padding. This can be added as a new property to both the container and its child nodes (padding handling is available in version 3.5).