IConnectorClient and BotAuthentication custom settings

We get settings using CloudConfigurationManager. IConnectorClient resolved automatically in the dialog when calling context.PostAsync. How to pass the correct parameters (MicrosoftAppId, MicrosoftAppPassword)?
In the case BotAuthentication we wrote a simple custom attribute:
public class CustomBotAuthenticationAttribute : BotAuthentication
    {
        public override Task OnActionExecutingAsync(
            HttpActionContext actionContext, CancellationToken cancellationToken)
        {
            MicrosoftAppId = CloudConfigHelper.GetSetting(MicrosoftAppIdSettingName);
            return base.OnActionExecutingAsync(actionContext, cancellationToken);
        }
    }

You might consider dynamically instantiating the BotAthentication attribute (and inheriting from it) with the proper parameters.  @msft-shahins do we have a pattern for this?

It is not clear how to write custom implementation IConnectorClientFactory. And in what container to register it. Confused by the constructor in ConnectorClientFactory passing IMessageActivity.

If you like, you can reuse the global static container on the Conversations class to register your custom implementation:
https://github.com/Microsoft/BotBuilder/blob/master/CSharp/Library/Dialogs/Conversation.cs#L49
The reason the ConnectorClientFactory takes an IMessageActivity is because it needs information like the ServiceUrl:
https://github.com/Microsoft/BotBuilder/blob/master/CSharp/Library/Dialogs/IConnectorClientFactory.cs#L69
I wonder if you could just provide a MicrosoftAppCredentials in a per-request manner and just use the standard IConnectorClientor instead:
https://github.com/Microsoft/BotBuilder/blob/master/CSharp/Library/Dialogs/DialogModule.cs#L85

Providing MicrosoftAppCredentials is a best option I think, but I can't understand how to do it.

Here is some untested, not fully formed code to update the Conversations class static Autofac container.  You'll need to figure out what data to pass to MicrosoftAppCredentials, and whether it's a singleton or per-request.  You might consider providing an Autofac factory Func as another option.
        var builder = new ContainerBuilder();
        builder.Register(c => new MicrosoftAppCredentials());
        builder.Update(Conversation.Container);

I register BotIdResolver and MicrosoftAppCredentials. And I use custom BotAuthentication attribute (https://github.com/Microsoft/BotBuilder/issues/927#issue-169796892).
It works! Thanks!
		public static void RegisterBotDependencies()
		{
			var builder = new ContainerBuilder();

			builder.Register(c => new BotIdResolver(
				CloudConfigHelper.GetSetting("_BotId")))
				.As<IBotIdResolver>()
				.SingleInstance();

			builder.Register(c => new MicrosoftAppCredentials(
				CloudConfigHelper.GetSetting("_MicrosoftAppId"),
				CloudConfigHelper.GetSetting("_MicrosoftAppPassword")))
				.SingleInstance();

			builder.Update(Conversation.Container);
		}

Where do you call RegisterBotDependencies ? From
public async Task Post([FromBody] Activity activity) ?
Can you provide full example?

@wiltodelta where do you call RegisterBotDependencies function ?

@vovanb @lonche usually you can call something like RegisterBotDependencies just once and early in your application, perhaps in a static constructor.


PJAS-1670 Rework the forked repository to fit the requirements

Implement a proxy service as a fork from Metallic to fit the requirements.

@mario-deluna , as we agreed, no need to review the code.
I tagged you in the PR just to have some context and reference for the ongoing work.


Adds Templates for Issues, PRs and CodeOfConduct

Adds handy github templates for us to use for development and contributors :)

UPDATE: Ah whoops! this branch came off of the https://github.com/ml5js/ml5-examples/pull/115 branch - will test the previous PR before merging here


Add shellcheck linter

I thought this was a cool project:
https://github.com/koalaman/shellcheck
Now with this PR you can integrate it into micro

@LevitatingBusinessMan FYI support for shellcheck linter got merged in July 2021 with PR #2157

@LevitatingBusinessMan FYI support for shellcheck linter got merged in July 2021 with PR #2157

Thanks for letting me know, I'll close this PR now.


Kubernetes Version 1.30

Thank you for making the Blueprints available, they are a great help.
I would like to know about using Kubernetes 1.30 and Karpenter, do I need to update it? Auxiliary material?
Thanks!

hello @guilhermemilesi7, thanks for raising this issue. As @jakeskyaws said, we try to keep versions updated as much as possible, and Jake highlighted the places you could update. And +1 on having contributions from the community. However, this time won't be needed as I didn't realize I didn't push my latest changes to update the repository. Give it a try/look, the repo is now using the most recent versions of Kubernetes and Karpenter.


Improve conditional

https://github.com/softlayer/sl-ember-components/blob/bf5d3474b7ea7740edd283a1b478f08ddcc32436/addon/components/sl-menu.js#L585 should be:
return 'true' === this.get( 'showAll' );

Resolved by https://github.com/softlayer/sl-ember-components/pull/499


Clarify the images-latest workflow

This took me a little longer than it should have to understand what was going on, so here's a few cleanup that I'd have found helpful:

Rename TAG to COMMIT_SHA as that's what it is... and tag is a bit ambiguous because the image is actually getting tagged with multiple things.
Organize all the tagging steps together.
Move the login step right next to publish... total nit, but typical workflows are build, tag, publish, and login is  really part of publishing.

Oops, meant to push this against my fork for testing...


Vuelvo a Verte (with Pablo Albóran) by Malú unsupported.

Check if issue with swaglyrics or whether song lyrics unavailable on Genius.

stripper -> Malu-Vuelvo-a-Verte

added


Use pyproject.toml to specify package info

Split out from the docker related PR, this just switches over to a pyproject.toml based package definition

Thank you for splitting up the bigger pull request. These changes are very reasonable.


Rename package to instructlab.sdg from instructlab_sdg

Part of issue #2
This changes to use Python namespace packages where instructlab is
the namespace used for our libraries.
Signed-off-by: Russell Bryant<EMAIL_ADDRESS>

[x] Depends on https://github.com/instructlab/instructlab/pull/1263

The instructlab side went in, so this can go in now once I rebase it.

I think I'm down to a linter fight between ruff wanting this import to move to its own first party section
+# First Party
+from instructlab.sdg import utils

but if I do that, there's another linter complaining that all of the instructlab imports aren't grouped together

I fixed the linter issue.


Reminder email bug for unhooked component

Motivation and Context

What has changed

How to test?

Links

/deploy sinhaa


Feat: Updated with newHeads descriptions.

Doc update related to newHeads
Related issue(s): #2117
Fixes #

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.15%.  Consider uploading reports for the commit b6c95c1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2220   +/-   ##
=======================================
  Coverage   75.15%   75.15%
=======================================
  Files          13       13
  Lines         644      644
  Branches      118      118
=======================================
  Hits          484      484
  Misses        115      115
  Partials       45       45

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Replaced by #2396


fix(clientInit): stop returning numOfAppLaunches (AEROGEAR-9073)

Motivation
https://issues.jboss.org/browse/AEROGEAR-9073
What
stop returning numOfAppLaunches on clientInit endPoint /api/init
Why
is set to zero but should not be returned as can cause developer confusion
How
add omitempty to the model
Verification Steps

checkout the branch
start the go server make serve
run make test-integration to test and seed the db
hit the http://localhost:3000/api/init endpoint with the following body

{
  "appId":"com.aerogear.testapp",
  "deviceId":"e71b7790-5537-11e9-88a1-85ea65c9f61e",
  "deviceType":"android",
  "deviceVersion":"8.0.0",
  "version":"0.0.1"
}

The response should not contain numOfAppLaunches field e.g.

{
	"id": "860fc986-7012-4b00-90f7-fbade5503916",
	"version": "0.0.1",
	"appId": "io.ionic.starter",
	"disabled": true,
	"disabledMessage": "The Admin has disabled this app version"
}

Checklist:

[x] Code has been tested locally by PR requester
[ ] Changes have been successfully verified by another team member

Coverage remained the same at 93.838% when pulling 355500ab4fafed5610e5a50afded0471c09a91cf on austincunningham:AEROGEAR-9073 into b7d16a2fbac5ef9c45457ff8397eeceb0ca8d9b5 on aerogear:master.

Code change LGTM, will just verify it now though


How to Mutate State of UITableViewCell?

I have a cell HCheckBoxTableViewCell which has a UILabel for showing title and a UIImageView to show checked or unchecked state.
class HCheckBoxTableViewCell: TableViewCell {

  @IBOutlet weak var titleLabel: UILabel!
  @IBOutlet weak var checkImageView: UIImageView!

  func bind(reactor: MedicineCellReactor) {
    reactor.state.map({ $0.message })
      .bind(to: titleLabel.rx.text)
      .disposed(by: disposeBag)

    reactor.state.map({ $0.isSelected })
      .subscribe(onNext: { [weak self] isSelected in
        self?.checkImageView.image = isSelected == true ? Images.checked : Images.unchecked
      }).disposed(by: disposeBag)
  }
}

I have MedicineCellReactor which stores the state of the above cell.
final class MedicineCellReactor: Reactor {

  typealias Action = NoAction

  struct State {
    var id: String
    var message: String?
    var isSelected: Bool
  }

  let initialState: State

  init(id: String, title: String, isSelected: Bool) {
    self.initialState = State(id: id, message: title, isSelected: isSelected)
  }
}

I have MedicalConditionSelectionReactor which maintains the state of MedicalListViewController who populates the UITableView with the above cell.
When any row is tapped Action.toggleCondition is called with the respected row index. So I just want to toggle the value of isSelected property & then change the image of the cell to checked or unchecked based on the property value. Since the currentState and initialState of MedicineCellReactor are both immutable. How do I achieve this? I don't want to reload the whole tableView.
class MedicalConditionSelectionReactor: Reactor {

  // represent user actions
  enum Action {
    case loadConditions
    case addNewCondition
    case removeCondition
    case toggleCondition(index: Int)
    case save
  }

  // represent state changes
  enum Mutation {
    case loadedMedicalConditions([MedicalConditionSelectionSectionItem])
    case reloadList
  }

  // represents the current view state
  struct State {
    var sections: [MedicalConditionSelectionSection] = [MedicalConditionSelectionSection(items: [])]
  }

  let initialState: State = State()

  func mutate(action: Action) -> Observable<Mutation> {
    switch action {
    case .loadConditions:
      let medicalConditions = OptionsModelDBProvider<RealmMedicalConditionModel>().fetch()
      let conditions = medicalConditions.toArray().map { item -> MedicalConditionSelectionSectionItem in
        // let isSelected = arrayOfMedicalConditionID.contains("\(item.ID)")
        let medicalCell = MedicineCellReactor(id: "\(item.ID)", title: item.name, isSelected: false)
        return MedicalConditionSelectionSectionItem.medicalCondition(medicalCell)
      }
      return Observable.of(Mutation.loadedMedicalConditions(conditions))

    case let .toggleCondition(indexOfCell):
      let state = currentState.sections[0].items[indexOfCell]
      switch state {
      case let .medicalCondition(reactor):
        // TODO:- How to toggle the isSelected bool property of MedicineCellReactor.State. Since this is immutable.
        // reactor.currentState.isSelected = false
        break
      default: break
      }
      return Observable.of(Mutation.reloadList)

    default:
      return Observable.of(Mutation.reloadList)
    }
  }

  func reduce(state: State, mutation: Mutation) -> State {
    var state = state
    switch mutation {
    case let .loadedMedicalConditions(conditions):
      state.sections[0].items = conditions
    default:
      break
    }
    return state
  }

}

First, I think, you need to manage the state of the child's Reactor in the parent.
And how about telling to the child about it?
class MedicalConditionSelectionReactor: Reactor {
  struct Condition {
    var id: String
    var isSelected: Bool
  }

  enum Mutation {
    case loadedMedicalConditions([MedicalConditionSelectionSectionItem])
    case toggleCondition(String)
  }

  struct State {
    var sections: [MedicalConditionSelectionSection] = [MedicalConditionSelectionSection(items: [])]
    var conditions: [Condition] = []

    func conditionFor(id: String) -> Bool {
      return conditions.filter { /* find a condition by id */ }.first ?? false
    }

    mutating toggleCondition(_ id: String) {
      // mutate the conditions array
    }
  }

  func mutate(action: Action) -> Observable<Mutation> {
    switch action {
    case .loadConditions:
      let medicalConditions = OptionsModelDBProvider<RealmMedicalConditionModel>().fetch()
      let conditions = medicalConditions.toArray().map { item -> MedicalConditionSelectionSectionItem in
        // pass parent state to the child
        let medicalCell = MedicineCellReactor(id: "\(item.ID)", title: item.name, isSelected: false, stateFromParent: state.map { $0.conditionFor(id: item.id) })
        return MedicalConditionSelectionSectionItem.medicalCondition(medicalCell)
      }
      return Observable.of(Mutation.loadedMedicalConditions(conditions))
    case let .toggleCondition(index): // recommend: use id instead of index. index is not stable.
      let id = /* find id from the index */
      return Observable.of(Mutation.toggleCondition(id))

      // ...
    }
  }

  func reduce(state: State, mutation: Mutation) -> State {
    var state = state
    switch mutation {
    case let .loadedMedicalConditions(conditions):
      state.sections[0].items = conditions
      state.conditions = []
    case let .toggleCondition(id):
      state.toggleCondition(id)
    default:
      break
    }
    return state
  }
}

final class MedicineCellReactor: Reactor {
  typealias Action = NoAction

  enum Mutation {
      case setSelected(Bool)
  }

  struct State {
    var id: String
    var message: String?
    var isSelected: Bool
  }

  let initialState: State
  private let stateFromParent: Observable<Bool>

  init(id: String, title: String, isSelected: Bool, stateFromParent: Observable<Bool>) {
    self.initialState = State(id: id, message: title, isSelected: isSelected)
    self.stateFromParent = stateFromParent
  }

  func transform(mutation: Observable<Mutation>) -> Observable<Mutation> {
    // observe parent state
    return Observable.merge(mutation, stateFromParent.map(Mutation.setSelected))
  }

  func reduce(state: State, mutation: Mutation) -> State {
    var state = state
    switch mutation {
    case let .setSelected(isSelected):
      state.isSelected = isSelected
    }

    return state
  }
}

How can I use multiple different Reactors for same tableview cell class?

You can use different reactors for a reused cells by disposing previous subscriptions.
class HCheckBoxTableViewCell: TableViewCell {
  // ...

  private(set) var disposeBag = DisposeBag()

  override func prepareForReuse() {
    super.prepareForReuse()
    disposeBag = DisposeBag() // dispose previous subscriptions
  }

  func bind(reactor: MedicineCellReactor) {
    reactor.state.map({ $0.message })
      .bind(to: titleLabel.rx.text)
      .disposed(by: disposeBag)

    reactor.state.map({ $0.isSelected })
      .subscribe(onNext: { [weak self] isSelected in
        self?.checkImageView.image = isSelected == true ? Images.checked : Images.unchecked
      }).disposed(by: disposeBag)
  }
}

No, I mean how can I use different Reactor classes altogether?

Ah, OK.
I think, the Reactor is designed to be assigned to a single View.
It is limited by View protocol.
https://github.com/ReactorKit/ReactorKit/blob/2592a48d275d7aaba4660a195cd99c0a62df6833/Sources/ReactorKit/View.swift#L21-L22
Why do you want to associate multiple Reactors with a single View?
If there are multiple components in a single cell, I think you can think of them as Views.
You may need to use grandchild Reactor.

ViewController with ParentReactor
Cell with ChildReactor
Cell components with GrandchildReactor

Or

ViewController with ParentReactor
Cell components with ChildReactor (Stop associating it with the Cell itself and associate it with a component in the cell)

Yeah, so UITableView class is just a view right so it can be reused elsewhere also for similar UI so there I might have a different type of Reactor so in that case, I think UITableView class will not accept that other reactor.

To do that, you might want to create a Container View to associate with a specific Reactor.
And attach a common view to that Container View.
The common view is shared by multiple Container Views.
Or you don't have to use Reactor.
You can just convert part of the Reactor's State to a cell configuration model and pass it to the cell.
Whatever you do, the design of the model is the most important thing; you don't have to stick with Reactor.
I recommend that you start by defining your models in plain Swift without Reactor.
Reactor is just the glue.

Can you please it in the code?

There are many challenges to solving your problem.
To summarize what I'm trying to say, here's the code.
I hope this helps.
import ReactorKit
import RxCocoa
import UIKit

class MyReactor: Reactor {
    enum Action {
        case didSelectRowAt(index: Int)
    }

    enum Mutation {
        case toggle(index: Int)
    }

    // These models (State and Item) are actually Reactor-independent.
    // It could be used in ViewModel, ReSwift, etc.
    // Instead of having logic in the Reactor, it's better to have mutation logic in the Model, just like the toggle method.
    // These are plain Swift.
    // These are very easy to test without Reactor.
    struct State {
        // these items are loaded from db or network etc.
        // and mapped into the `Item` struct.
        // manage items here instead of manage in a child reactor.
        var items: [Item]

        // function for `Mutation.toggle(index:)`
        mutating func toggle(index: Int) {
            items[index].isChecked.toggle()
        }
    }

    struct Item: Equatable {
        var title: String
        var isChecked: Bool = false

        // init(from databaseModel: ...) {}
        // init(from networkModel: ...) {}
    }

    let initialState: State = State(items: [
        .init(title: "test 1"),
        .init(title: "test 2")
    ])

    func mutate(action: Action) -> Observable<Mutation> {
        switch action {
        case let .didSelectRowAt(index):
            // this is just a demo.
            // you may need to update db and fetch latest values from the db here.
            // and you can send some mutations from here.
            // example: `Mutation.setChecked(Bool)`, `Mutation.refreshItem(Item)`, `Mutation.reload([Item])`, etc.
            return .just(.toggle(index: index))
        }
    }

    func reduce(state: State, mutation: Mutation) -> State {
        var state = state

        switch mutation {
        case let .toggle(index):
            state.toggle(index: index)
        }

        return state
    }
}

class ViewController: UITableViewController, View {
    typealias Reactor = MyReactor

    var disposeBag = DisposeBag()

    private var items: [Reactor.Item] = [] {
        didSet {
            // if you want to use animations for cells, you may need to use NSDiffableDataSource, DifferenceKit, RxDataSources, etc.
            tableView.reloadData()
        }
    }

    func bind(reactor: Reactor) {
        reactor.state.map { $0.items }
            .distinctUntilChanged()
            .bind { [weak self] in self?.items = $0 }
            .disposed(by: disposeBag)
    }

    override func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
        return items.count
    }

    override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
        let item = items[indexPath.row]

        // you can use any shared cells. because there are no children reactors. This is just a UIKIt view.
        // cell state is managed by the parent reactor.
        let cell = tableView.dequeueReusableCell(withIdentifier: "Cell", for: indexPath)
        cell.accessoryType = item.isChecked ? .checkmark : .none
        cell.textLabel?.text = item.title

        return cell
    }

    override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
        // we don't need to use any children reactors.
        // just send an action to the parent reactor.
        reactor?.action.onNext(.didSelectRowAt(index: indexPath.row))
    }
}


Add reserved Rockets list to My Profile View

For this task, the following changes were introduced:

Render a list of all reserved rockets (use filter()) on the "My profile" page.
Used the ListGroup element from React-bootstrap

Hi @jfoyarzo ,
✔   Status: APPROVED 🏆 🎉 🎊
You have done a great job on this project, keep it up 👍 🥇. Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
congratulations!  🎉💯🌟
Top highlight 🎯

Excellent Implementation
The PR title and description are professional and descriptive ✅
Linters are working properly ✅


Add ATLAS style callouts

@bzavhorodskyi this isn't perfect, but I've got the kitchen sink page to show things as I want it to. Let me know what you think.

In general, I`ve checked how it looks and I like it


Repo retrieves only one class for binary classification tasks

Thanks for the nice package! It fosters research in different aspects of AutoML!
However, I am curious about the expected behavior when loading the predictions for binary classification tasks (e.g. "Australian" dataset). According to the documentation, it should output a tensor with shapes: (n_configs, n_rows, n_classes). However, the code below yields predictions of size (n_configs, n_rows).
Given that it is a binary classification problem, I expected something like (n_configs, n_rows, n_classes), where n_classes = 2. Is the current setup giving just the probability of one class? If so, I can easily compute the probability of the other class, however, it would be better to output directly both. Otherwise, please let me know what I am missing.
To reproduce the issue:
from tabrepo import load_repository, get_context, EvaluationRepository

context_name = "D244_F3_C1530_100"
repo: EvaluationRepository = load_repository(context_name, cache=True)

shape1 = repo.predict_val_multi(dataset="Australian",fold=0, configs=["CatBoost_r1_BAG_L1", "LightGBM_r41_BAG_L1"]).shape
shape2 = repo.predict_val_multi(dataset="autoUniv-au7-700",fold=0, configs=["CatBoost_r1_BAG_L1", "LightGBM_r41_BAG_L1"]).shape

print("Shape 1:", shape1)
print("Shape 2:", shape2)

Output:
Shape 1: (2, 621)
Shape 2: (2, 630, 3)

Regards,
Sebastian

Sorry for the confusion our doc is indeed to be improved there, we return a tensor with shape (n_configs, n_rows, n_classes) in case of multi-class classification and a tensor with shape (n_configs, n_rows)else for both regression and binary classification.
For binary classification, we return the probability of the first class IIRC.
Thanks for pointing this out, we will improve our doc to avoid this confusion.

Yeah, @geoalgo's answer is correct. The reason we only return the positive class prediction probability is for efficiency. It allows us to halve the memory usage and runtime of the operations. It might be a good idea for us to add a flag that users can set to make it return the multiclass representation though, for ease of use purposes.

Thanks for the information! Indeed, a flag would be useful, especially if someone wants to write a general code that works for any number of classes.

Hey @sebastianpinedaar, I've added a flag to the methods in #64, called binary_as_multiclass. Hope it helps!


Use whatever is globally installed (yarn, npm, pnpm) in CLI to boot up editor

Yarn must be globally installed currently for mirrorful to work. Otherwise, you will see
an Unhandled 'error' event when running npx mirrorful:
$ npx mirrorful
Running Mirrorful version: 6.1.10
Starting Mirrorful in ~

Inside your project, you can run:
 npx mirrorful
to start the visual editor at any time.

✨ Opening Mirrorful in your browser at http://localhost:5050/

node:events:491
     throw er; // Unhandled 'error' event
     ^

Error: spawn yarn ENOENT
   at Process.ChildProcess._handle.onexit (node:internal/child_process:285:19)
   at onErrorNT (node:internal/child_process:485:16)
   at processTicksAndRejections (node:internal/process/task_queues:83:21)
Emitted 'error' event on ChildProcess instance at:
   at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12)
   at onErrorNT (node:internal/child_process:485:16)
   at processTicksAndRejections (node:internal/process/task_queues:83:21) {
 errno: -2,
 code: 'ENOENT',
 syscall: 'spawn yarn',
 path: 'yarn',
 spawnargs: [ 'run', 'next-start', '-p', '5050' ]

This is because we use yarn to run next-start to boot the editor. Instead we should use whatever the user has installed. Relevant line of code: https://github.com/Mirrorful/mirrorful/blob/main/packages/mirrorful/cli/init.ts#L83

I just resolved this by making yarn a dependency. Not great, but a fine workaround for now.


Fixed Scroll view to Search

Fixed Scroll view to Search View https://github.com/jiffy-labs/jiffyscan-frontend/issues/147

Thanks a lot @shashankcoc for the fix !

Thanks for the thanks! Looking forward to more contributions!!


chore: move test fonts to the main repo

A step toward #1411 and to remove submodules.
This migrates https://github.com/KaTeX/katex-test-fonts to the main repo.
Git is able to easily handle binary files ~10 MB and test fonts are not likely to change.

Codecov Report

Merging #2834 (e44f2f1) into master (a8c2265) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head e44f2f1 differs from pull request most recent head ba9713c. Consider uploading reports for the commit ba9713c to get more accurate results

@@           Coverage Diff           @@
##           master    #2834   +/-   ##
=======================================
  Coverage   93.92%   93.92%
=======================================
  Files          87       87
  Lines        6326     6326
  Branches     1308     1308
=======================================
  Hits         5942     5942
  Misses        354      354
  Partials       30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8c2265...ba9713c. Read the comment docs.

I'm a bit late to the party, but how are we supposed to recompile fonts with the new set-up?

@pzinn Run dockers/fonts/buildFonts.sh (Docker is required). Note the relevant PR is #2837.

thanks. doesn't obviously work:
pzinn@mammoth - ~/KaTeX/dockers/fonts ./buildFonts.sh
./Dockerfile: No such file or directory
~/KaTeX/src ~/KaTeX
~/KaTeX
Need to build docker image katex/fonts:DF-
unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat /home/pzinn/KaTeX/Dockerfile: no such file or directory


Longest Valid Parentheses

Problem
Given a string containing just the characters '(' and ')', find the length of the longest valid (well-formed) parentheses substring.
Example 1
Input: s = "(()"
Output: 2
Explanation: The longest valid parentheses substring is "()".
Example 2
Input: s = ")()())"
Output: 4
Explanation: The longest valid parentheses substring is "()()".
Hey, I am Atul Kashyap, a GSSOC'21 participant.
I want to contribute the code for the implementation of the Longest Palindrome Substring in the C++ language.
Please assign this task to me.
@anubhavitis @dheerajkotwani @tarun26091999 @todi-2000 @geekquad @plazzy99 @rudrakshi99

Hi,
I am GSSOC'21 participant
My code will be in JAVA with proper comments and test cases.
@rudrakshi99 @nakul-19 @plazzy99 please assign me this issue

issue present at #217


Implement kn plugin

Fixes #60

Open for early feedback, to make sure I'm not off-track.

I don't see some of the other starter boilerplate from the client sample, which helps with things like building with the linker flags to set Version: https://github.com/knative/client-contrib/tree/master/plugins/hello/hack

I was thinking of moving that to the top level hack folder.

I ended up removing the plugin hack scripts, given:

codegen and dep updates were already centralized
plugin build and test was already working out of the box with the current CI config
the only important bit was the build flags, used by the version subcommand, I added them to the goreleaser configuration

The only manual bit is building the plugin before invoking it for e2e tests (I just run go build -o kn-vsphere ./plugins/vsphere/cmd/vsphere)


Hide api key from repo

Planning to publish the app using the git-connect-functionality enabling auto-updating of the app through git. But I have my API key in shared.py. How can I best hide this from the repo? Or dont I need the api key when the app is deployed on connect?

That makes a lot of sense.
And thats what I did for my deployment (connecting using board_connect( ) without any parameters).
closing issue :)


Token transfer bug - not all actions are recorded in history #316

Added a table to store the ids to use them in deferred transactions in history
Added a new table to store the processed transactions. This is needed for the correct qev and trx points calculation.

Contracts modified:

[ ] History

No migrations or settings are needed

Great stuff!

Deployed on testnet and mainnet


Create Logic Diagrams

Saved here: https://www.notion.so/threebox/Logic-Diagrams-579277a5c8ac4ab9800b473eeeeb1356

[x] User lands on dapp
[x] User changes address
[x] User changes network

@oznekenzo what's the status on these? can we close this?


Changed Swabra page for cloud

TC Cloud doesn't support the installation of agent tools by the user. I created a new cloud-specific page for Swabra where I changed the installation of the handle.exe section.

@wachtel1 huge thanks for a PR! <3
However, there's a trick here: we don't need to duplicate files to create a diversity between Cloud and OP content. The doc engine supports the {product="tc"} and {product="tcc"} attributes for platform-specific paragraphs, images, sections, examples, etc.
I've added two "Installing Handle" to the doc, users will see only one of them depending on the doc platform: https://github.com/JetBrains/teamcity-documentation/commit/9ee19fca94b769d4c25e501e63147f65ac44f0d9
This means the PR (and a duplicate .md file) is no longer needed. However, I've used the edited text to freshen up this article, so still definitely not a waste, thanks


ARROW-6658: [Rust][Datafusion] Implement AVG expression

I wasn't sure about the datatypes of sum&count (picked the broadest f64 and i64) also it may or may not be better to implement this as SUM()/COUNT().
Either way the changes from mod.rs are needed to test SQL with f64

I'm excited to see these PRs! I am away on a business trip so might not be able to review until the end of the week or at the weekend.

@alippai please rebase


IKTAddSuperImplementationToClass cannot be found on device/release config

While my hooks work fine while debugging, they crash on device with the Release configuration. I think I've been able to nail it down to IKTAddSuperImplementationToClass not being found. The dlsym in InterposeSubclass returns nil. Any ideas / tips for how to further debug this?

I recently adopted InterposeKit in our app and befell this same issue during TestFlight testing.


NC | Health fix cli arguments validation and some small fixes

Explain the changes

Health.js -

Added CLI arguments type validation (validate_input_types).
Added check_rsyslog flag - rsyslog service will be checked only if this flag was provided.
Called  get_boolean_or_string_value(arg) on every boolean argument.
Added try catch when calling exec(), and changed ignore_rc to - when ignore_rc=true service_status/pid/memory are undefined, when ignore_rc=false, setting them as missing so the user will know the command failed and didn't succeed.
service health is no longer effected by rsyslog/syslog_ng status, even if they are failing the overall status will be OK, their errors will be reflected in the rsyslog/syslog_ng service section.

Manage_nsfs_constants.js - Added Health related type and options.
Manage_nsfs_validations.js - Added Health options to be validated.
test_utils.js - added exec_health_cli.js function.
test_nc_nsfs_health.js - added relevant tests and fixed failing.

Issues: Fixed #xxx / Gap #xxx

Fixed https://bugzilla.redhat.com/show_bug.cgi?id=2262777
Fixed #8046
Fixed #8027
Fixed #8024
all_account_details/all_bucket_details defined check Uday mentioned on slack channel.

Testing Instructions:

sudo node --trace-warnings ./node_modules/mocha/bin/mocha /Users/romy/github/noobaa-core/src/test/unit_tests/test_nc_nsfs_health.js
Gap - a follow-up Refactoring PR

[ ] Doc added/updated
[x] Tests added

@romayalon could you update the doc with new changes, Other than that its LGTM

This PR is depenedant on validations changes, therefore it can not be backported to 5.15.4


fix: make tab heights consistent

This PR...
Changes

Fixes

How to test it

Screenshots

Checklist

[ ] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] added a test

https://user-images.githubusercontent.com/2957624/230819225-7d7d973f-cabe-4ce2-aa39-d51787ba5838.mov


Azul distribution support

Hi, Can you confirm that the azul distribution has removed versions 9, 10, 12 and 14 from their official API version?

Hello @jlerbsc, Thank you for creating this issue and we will get back to you once we have some feedback.

Hi @jlerbsc, currently, the Azul distribution supports versions 8, 11, 17, 21, and 22 only. All other versions have been removed from their official website. I've included a screenshot for your reference.

Thank you for your reply. We're going to migrate the Javaparser project to another distribution.


eclipse on mac OSX El Capitan

I've tried to make lombok work on my mac.  I read about and tried various combinations.  I'm using
Version: Mars.1 Release (4.5.1)
Build id: 20150924-1200
and a spring project that other people in my group have working that uses @Data and works.
I discovered that the eclipse.ini at ~/eclipse/jee-mars/Eclipse.app/Contents/Eclipse/eclipse.ini
is likely the correct ini file since at times I can make eclipse not start up by modifying the content.
If I add:
-javaagent:lombok.jar
as recommended eclipse will not start.
If I add:
-javaagent=lombok.jar
eclipse will start but the setters/getters will not appear in the outline window as expected.
I've also tried various combinations of:
-Xbootclasspath
Also, I never see any indication under: about eclipse that lombok has been added.

Did you try to use the lombok installer?
java -jar lombok.jar

That should generate the right line at the right location in your ini file.


fix: battery time remaining

time is reported in second and should be divided by 3600 and not 1000.
should fix: https://github.com/Alexays/Waybar/pull/1867#pullrequestreview-1246756355

Thx!


Redundancy of parameters removed by introducing a Constants class

Each new Gateway implementation will have to have a inner class in the new Constants class and have all the constants (parameters etc) listed there as public static final String variables

Hey defining constant class is not a good idea its creating complexity for new comer who would like to integrate new gateway Also there is an idea to implement more than 100 gateways and for that constant class will be a pain.
Yes but we can discus about XML creation.

You can view an example of what happens with using Freemarker for creating the requests, I have already pushed them in the pull request.
Regarding the constants class, it is not the main goal to offer people a solution that works, the quality of the work and the code in this case has to be as good as possible and with the way it was before, the quality wasn’t that good, believe my 20+ years of using Java.
If you want to work on the quality of the code and gain tips that will become intrinsic to your way of working, I will suggest that you use a solution like Sonarqube to check the quality of your code.
Sent with Unibox

On May 9, 2018, at 10:30 AM, Muhammad Ilyas<EMAIL_ADDRESS>wrote:
Hey defining constant class is not a good idea its creating complexity for new comer who would like to integrate new gateway Also there is an idea to implement more than 100 gateways and for that constant class will be a pain.
Yes but we can discus about XML creation.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
, or mute the thread
.

I can understand but defining constants for just one time use is not a good idea.

@ilyas2016 @tousifhasanzai I agree with @dwamara its a good approach to use constants although it will create difficulties in Integrations but still we have to meet coding standards as well, if we do not use constants and directly bind parameters/property to a class in the future for any property level change it will be necessary to modify the class which can increase chances of mistakes aka Human Error

The constants is just an approach to get things in the right direction. I don’t pretend on having the all knowing Graal on this, so if you can suggest a better approach, I’m glad to hear and abide by it and will make the necessary modifications to the code that I have written so far for this project.
Sent with Unibox

On May 9, 2018, at 10:47 PM, shanmarif<EMAIL_ADDRESS>wrote:
@ilyas2016
@tousifhasanzai
I agree with @dwamara
its a good approach to use constants although it will create difficulties in Integrations but still we have to meet coding standards as well, if we do not use constants and directly bind parameters/property to a class in the future for any property level change it will be necessary to modify the class which can increase chances of mistakes aka Human Error
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
, or mute the thread
.

@ilyas2016 @tousifhasanzai i agree with @dwamara having a constant class helps the code base much easier to refactor and also this is the best time to define the coding standard for the project since its relatively still new.
To add more to what @dwamara refactored, i think it would be much better to move all the payment gateways to a separate package, with this you can have more of a schematic structure for each gateway and in the future we can create a script that auto generate schematic structure for new gateways.
examples
-----package com.tranxactive.j2pay
            .gateways
                 .billprogateway
                       ---Constant.java
                       ---BillproGateway.java
-----package com.tranxactive.j2pay
            .gateways
                 .authorizegateway
                       ---Constant.java
                       ---AuthorizeGateway.java

The above structure makes the code more modular and easier to maintain and enforce coding standards.

@dwamara what do you think about @lukkystunt review?

That seems OK, but for the package name under "gateways", you can remove "gateway" at the end because as it is supposed to be a gateway, there is no need to repeat it again. And as there will be more than one constant value in the class, the class name has to be in plural form.
If it's ok, I can make the change and let it pass through sonarqube again to be sure that the quality hasn't been affected.
And as @lukkystunt said, that will be a good time to create and enforce standards now. Those standards can be in the future integrated with a solution like checkstyle to be sure that no one is pushing code that doesn't conform to the standards.

But some packages have also to be moved like "com.tranxactive.j2pay.gateways.responses", "com.tranxactive.j2pay.gateways.util". The classes under "com.tranxactive.j2pay.net" are util classes and could be relocated under a more convenient package.

yes @dwamara I we can go for it.

great recommendation @dwamara and @lukkystunt , I am agree with that approach as well

I have just made the changes with the relocation of the classes under a new package with a single Constants class per Gateway and the quality looks like this: https://www.dropbox.com/s/cvg70swubf5q8k2/Screenshot 2018-05-10 15.26.19.png?dl=0

Made some other changes and now I am at

I will push that and go out, it's a bank holiday in Germany so I want to enjoy it.

if its failed? then why we implement that?

If what failed?
Sent with Unibox

On May 10, 2018, at 3:47 PM, Muhammad Ilyas<EMAIL_ADDRESS>wrote:
if its failed? then why we implement that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
, or mute the thread
.

And BTW someone should think about adding Junit tests.

your given snapshot says its failed.

It failed to pass the quality gate. It's exactly what I meant yesterday when I wrote that it's not enough to give people a code that works, it's important to give them a code of good quality and on the quality side, the actual code fails to pass the quality threshold because locally I still have 11 vulnerabilities, 14 code smells, 7h code debt, 7.7% duplications spread between 20 code duplications.
It says nothing to the functionality of the code, just its quality. For the functionalities, you have to have unit tests that have to be run and this part is still missing.
I know most of the coders think that writing code is enough and don't care about writing tests, and I fell sometimes in that category because I do most functional and integration tests of my code and not unit tests but when you want to give people a library that they have to use, in the future surely in productive systems, you have to assure them that your code is working and that enough unit tests have been made.

But it's a great improvement compared to the code I had when I first checked it out because they were something like 75% duplicated code, 4 days of debt, nearly 60 vulnerabilities and a little more than 300 code smells.

Here what my quality gate looks like

Another thing that I will be adding is a logger, but to have as less as dependencies as possible, I will be doing the logging in a file with the java.util.logging.Logger

I haven't found a better solution than to have a single class per Gateway implementation in a single package as proposed by @lukkystunt

Alright so your code with "separate packages for each gateway" is ready. can i merge?/

It’s already been pushed since yesterday, you should be able to merge, all the last coding that I made are in the pull request.

Why some files are .xml while other are .ftl?

Sorry forgot to rename some, I needed to create first XML files to get them validated before turning them to ftl and I forgot some. Renaming and making another pull request

and also we should not create two inner classes in constants class like RequestParameters and ResponseParameters instead, we should define directly on constants class level. since you are using ResponseParameters.NAME in request parameters thats not making sense to me.

if you want to do it, then you have to prefix the constants with either REQUEST_ or RESPONSE_ in order to be able to differentiate and know which ones are those for the Request and those for the RESPONSE. I made it that way in order to be able in the future to easily create a documentation (either through Javadoc or something else) where one can directly know and see which parameters for example belong to requests and which not.

using ResponseParameters.NAME in request not making any sense how will you sort that out?

I don’t quite get your question

what if request and request have same parameter name? like both have name

test payment gateways are little tricky we would not be able to refund a transactions instantly until it is settled. I am wondering how we could create test cases for that.

If you can’t use a remote system for testing your code, you have to resort to using a mock system or mocking the responses you can get from the system for various use cases (success, failure, failure because system is not reachable, failure because credits are missing, etc).
You can research mocking frameworks for Java on the net but you have for example EasyMock or Mockito that are very well know.
So it’s not that tricky after all, you just have to take your time to learn how to mock and mock.

And BTW unit tests are supposed to be implemented to work offline, so they shouldn't rely on external systems, be it a database or something else. As soon as you start using external systems, you move concept wise from unit tests to integration tests.

@dwamara please stop any further work. Now library seem more complicated to use or implement new gateways. I will let you when we will decide for changing core of library. thanks.


BUG: Fix DWIConverter hard-coded transpose/FSLBy3Rows setting

@hjmjohnson thanks for the review.
@yrathi I believe this plus #356 fixes conversion of one of your datasets (cc @odonnell).

Hi Isaiah. Thanks! Please test behavior on the HCP data.


Feature request: Ignore message by ID or author

It will be nice if the bot supports filters to ignore some messages when deleting, it can be useful for channels that must keep some messages (or messages sent from a specific author) when deleting other messages.

Closing this as completed in #1


[export] Add support for exporting functions with effects

In presence of ordered effects JAX lowering produces a main function that takes token
inputs and returns token outputs. Previously, when exporting such a module, we would wrap the main function with a function that does not use tokens on inputs and outputs. With this change we actually leave the token inputs and outputs and rely on consumers of the exported function to know how to invoke a function with tokens.
This depends on a recent change to XLA and JAX lowering that uses stablehlo.token types for the main function's argument and result types (xla_extension_version >= 199).
This introduces serialization version 9, but does not change the default serialization version. This means that version 9 will not be used except in some tests.

@junwhanahn PTAL


[Feature Request] Add possibility to add annotations to server configmap

Is your feature request related to a problem? Please describe.
I use this helm chart with bank-vault mutating webhook https://bank-vaults.dev/docs/mutating-webhook/.
I want to be able to add annotations to the template server-configmap.yaml in order to be able to mutate some values from vault. (here i want to mutate some dynamic username from vault)
Describe the solution you'd like
In values.yaml maybe add something like server.configAnnotations
In server-configmap.yaml add the anotations
Additional context
https://bank-vaults.dev/docs/mutating-webhook/configuration/#secret-and-configmap-examples
conclusion
Is it something you think it may be possible to add?
Thanks you a lot in advance

(may be possible without adding this new annotation)
i will try a solution when i have time and submit new issue with pr :)


Router: Find means to provide Handlers the router

Routes can be named in router to generate nice URL
But to generate the nice URL, we need to have access to the router. Find means to make that happen
(there is a trick as we expect to call on RouterSetup only once ... ;) )
Update Wiki (especially for redirection)  on route naming and url generation.
See: https://github.com/gorilla/mux#registered-urls

Added web.GetRouter() function
now we can use : https://github.com/gorilla/mux#registered-urls to ensure we don't mess up urls in controllers.
Not sure if it will work from template but should do something like  {{ GetRouter.Get "article" | URL "subdomain" "news" }} to be checked... ;)


Unable to build/run

Hi, your lift-shiro project looks like just what we're looking for. I'm having problems running it though.
1 ) I had to update the reference to the maven repo becuase it looks like your domain is not resolving.
diff --git a/project/plugins/build.sbt b/project/plugins/build.sbt
index 31d6ae1..82a69ee 100644
--- a/project/plugins/build.sbt
+++ b/project/plugins/build.sbt
@@ -1,4 +1,4 @@
-resolvers += "web-plugin.repo" at "http://siasia.github.com/maven2"
+resolvers += "web-plugin.repo" at "https://github.com/siasia/siasia.github.com/tree/master/maven2"
addSbtPlugin("com.github.siasia" %% "xsbt-web-plugin" % "0.1.2")

Building using sbt 0.11.0, I get:

$ ./sbt
[info] Loading project definition from /home/agoodno/work/scala/lift-shiro/project/plugins
[error] java.lang.NoClassDefFoundError: sbt/JettyConfiguration
[error] Use 'last' for the full log.
Project loading failed: (r)etry, (q)uit, (l)ast, or (i)gnore?
Any ideas?
Andy

This is very odd. I've blown away my .ivy2 and .m2 and everything packages fine. Please also clear your local caches... you probably have something broken.

Ok, blowing away both caches fixed the compile.  Thanks for the suggestion.  Shouldn't there now be a task in the jetty context so I can just do 'jetty:run' to run the example?  Is there another way to run it?  Also, just to follow-up on the resolver problem above.  I'm still unable to ping siasia.github.com or browse to that URL so I'm not sure how that's working.

You need to do the following to run the sample:

project example
[...]
jetty-run

Yeah I tried that too:
agoodno@agoodno-ubuntu:~/work/scala/lift-shiro$ ./sbt
[info] Loading project definition from /home/agoodno/work/scala/lift-shiro/project/plugins
[info] Set current project to lift-shiro-root (in build file:/home/agoodno/work/scala/lift-shiro/)

project
[info] lift-shiro-root (in build file:/home/agoodno/work/scala/lift-shiro/)
project example
[error] Not a valid project ID: example
[error] project example
[error]                ^

Sorry, I was thinking of another project. Please use the SBT documentation to become familiar with project navigation etc. Here's what you need to do in the immediate:
[lift-shiro-root]> projects
[info] In file:/Users/timperrett/repositories/lift/lift-shiro/
[info] 	   lift-shiro-example
[info] 	   lift-shiro
[info] 	 * lift-shiro-root
[lift-shiro-root]> project lift-shiro-example
[info] Set current project to lift-shiro-example (in build file:/Users/timperrett/repositories/lift/lift-shiro/)
[lift-shiro-example]> jetty-run

Ok, that worked. Our projects are structured differently and it didn't occur to me that the project name would be different than the directory that it's in.  Thanks.


Using LwIP with TityUSB

Hi. I need some advice and maybe an explanation.
I try to use LwIP stack from Pico-SDK together with TinyUSB which is also part of Pico-SDK.
The goal is to implement a web-server and Web-UI for my device, similar as it was done here
Accept I don't want to include LwIP and TinyUSB as submodules in my project.
I also use FreeRTOS SMP and seems that I need to perform some additional integration of LwIP to respect multithreading and RTOS stuff...
I saw that LwIP stack in Pico-SDK already has all required FreeRTOS implementations.
The question is is it possible to use "pico_cyw43_arch_lwip_sys_freertos" with USB not with cyw43 and how to do it properly?
I also have a custom board without cyw43 chip and PICO_BOARD not "pico_w"

This sounds like a question that would be better answered in the C SDK section of the forums.


[Coral-Trino] use 'TRY_CAST' instead of 'CAST'

What changes are proposed in this pull request, and why are they necessary?
Hive/Spark CAST is equivalent to Trino TRY_CAST. If CAST fails, a query using Hive/Spark will return null, while a query using Trino will throw error. So I think should  use 'TRY_CAST' instead of 'CAST'.

Hive/Spark
select cast('a' as int)  return null
Trino
select cast('a' as int)   throw error like "Cannot cast 'a' to INT"
select try_cast('a' as int)   return null

How was this patch tested?
Modified unit tests.

@wmoustafa Could you help review it?


The type of EventEmitter is better be any

Thank for this simple but helpful solution firstly.
The problem:
Let's say we have a very simple Component:
@Component({
selector: "simple-one",
template: "I like simple"
})
export class SimpleOneComponent {
@Output() clicked = new EventEmitter<string>();
}
The problem is the type of the output, it's a string, but in the source code:
metadata.outputs.forEach((method) => {
Mock.prototype[method] = new EventEmitter<Object>();
});
output type is always Object, which runs into errors.
Solution:
Change the output type to any. I have tried this, no more err~

Pull request for this same reason made.
issue is resolved once merged


[v2.8] Add support for deleting clusters and scaling RKE2/K3S worker nodepools

Issue:  [EPIC] Automate Deleting clusters and add/delete nodes from Rancher

Problem

Currently in the framework, we do not have a means to delete supported cluster types or to scale a worker node pool for RKE2/K3S. While it's an option to simply refactor the existing provisioning node driver and custom cluster test files to have this, we don't want to do that.
This is mainly because the tests aren't necessarily provisioning specific and down the line, it's going to flood the test files.
Solution

I've created separate test files for scaling and deleting clusters. This way, moving forward, we can add all deleting/scaling test cases in their respective test files.
Testing

Engineering Testing
Manual Testing

Locally tested the following scenarios:

Deleting RKE1/RKE2/K3S custom and node driver clusters
Scaled RKE2/K3S node driver clusters

Automated Testing
Offline Jenkins jobs will be given to reviewers.

assuming this is all the same as 2.7 pr, please see review there for reference.


Add kuttl tests

Corresponding change to openshift/release CI: https://github.com/openshift/release/pull/42074


Autogenerate CreateOrUpdate resolvers

Is this feature request related to a new or existing Amplify category?
api
Is this related to another service?
DynamoDB
Describe the feature you'd like to request
I'd like to suggest that Amplify API resolver codegen be updated to support Upsert/CreateOrUpdate/PutItem semantics for DynamoDB.   This would allow clients trying to create or update an @model object defined in their Amplify schema to issue a single call to the api instead of first checking whether an object exists (which increases latency, is less atomic, requires error parsing, etc).
Guidance from several years ago says "just manually update the resolvers", but this seems like a lot of work if you have many @models and expect to rebuild your API a lot.  This behavior is very generic (it's a fundamental feature of DynamoDB, after all)- would it be possible for Amplify to enable it?
Describe the solution you'd like
It'd be awesome to have some option to auto-generate this code, or always auto-generate it and provide an option to invoke it.
It seems like this could be an option in the conditions of the Create() Graphql calls-  I think it might be harder to modify update calls, as right now I'm not sure they require that all required schema fields be provided?
Describe alternatives you've considered

Update all the vtl resolvers manually.  I don't really like this solution because 1) everyone has to learn VTL, which Amplify tries to abstract, and 2) It means that my resolvers stop benefitting from codegen updates the CLI pushes.

Write a postprocessing script that changes all the codegen'ed VTL to allow upsert (basically removing the manual part of 1).  My qualm here is that it relies on Amplify codegen internals and is likely unintelligible to all but a few members of my team, who still require deep understanding of Amplify and VTL.

Replace all client Create() calls with Get() -> if (error) then Create else Update logic.  this increases latency and decreases atomicity, and is more bug prone because errors have to be correctly disambiguated.

Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request

Would this feature include a breaking change?

[ ] ⚠ This feature might incur a breaking change

@ykethan , do you have any update on this? :)

Hey @unknown1337, thank you for reaching out. I do not have an ETA on this, as the resolution will be based on the priority set by our back-end team. As soon as it gets released, it should be publicly announced. Please feel free in adding your use case to the issue.


dependecies: Fix 'yarn' dependency installation

Fixes: #3107
Currently, running yarn to install/update depencencies is failing
on iOS with XCode 10.
The cause is Detox, one of the dependencies fail to build.
Upgrading to the latest version fixes that problem.
Note on Detox:
We are not actively using it but we should, and that is why I did
update the dependency instead of removing it.
They are also finishing up their Android support:
https://github.com/wix/Detox/blob/master/docs/More.AndroidSupportStatus.md

@gnprice this is short-n-simple + urgent ⏩


Add check if message is sent by game

Seems like this is forgotten to be added

I can sent a "You have a funny feeling like you would have been followed" Private message, clan chat message or just public chat message, and the plugin will make a screenshot and sent it to the webhook. Easy way to spy on people :^)


Exporting document as HTML like

Hi @jsamr, this lib looks incredible.
Is there a way to export the created document as HTML content or something readable by other thing than the Print component ?
Because I would like to use it to create articles which will be saved in a database as HTML and then show these articles in an other component or even in a web page.

@dardinier This feature hasn't been implemented yet but it should be pretty straightforward to do (document → HTML). However, the other way (HTML → document) is more complex because, of course, HTML is way richer than formatted text. I am working hard on other projects right now and I don't have much time to dedicate to typeskill, but this project will receive more care in the future, that I can promise! I'm very open to a PR if you're willing to put the effort.

Thank you for your answer !
I'll try to take a look for this feature then ! :wink:


"manière" should have an "s", in Readme file

French error in Readme file, at "nouvelles manière": should be "manières".

You are right, and the whole sentence was weird anyway. Not enough sleep this last days here :) Thank you.


Always preserve new lines for array and object literals.

Regardless of the value of 'preserveNewLines'.
Fixes: https://github.com/Microsoft/TypeScript/issues/2513
An alternative approach would be do just remove the preserveNewLines flag, and attempt to preserve in all the other places we handle this today.  That would be my preference.   You can see this alternate approach here: https://github.com/Microsoft/TypeScript/pull/2518
This produces output closer to the original code, and means that you don't get ugly code explosion when you write nice single-lined stuff like arrow functions, and in many cases, you don't have your complex multi-line code smushed up to a singline line.
Thoughts?

I like #2518 better, but I will also sign off on this one.


Irc channel for Hubot support?

What is the irc channel for Hubot support?

It's in the readme :+1:

If you'd like to chat, drop by #hubot on FreeNode IRC.


Change the default location for Enso project on Mac and Windows

Should be My Documents/enso-projects (or Documents/enso-projects on Mac.
However, if the user already has the current structure we should move it to the new location.
If starting enso on a complete pristine machine (i.e. no folder) it should be created and not crash!

One minor thing: please verify the correct permissions on folders. Should be u+rw

After some consideration, I think we don't need to manipulate permissions because the root user catalog already has it correct
$ ls -l /home
total 20
drwx------ 60 dbushev dbushev 20480 Jun 19 11:00 dbushev/

Not sure about Windows though, but I would be surprised if it is different.


Prepare to submit a paper to JOSS

🚀 Pull Request
resolve #389
Description

Journal of Open Source Software

@bjlittle You can now check a preview of your paper using ci-draft-pdf's artifact. The markdown I added is a template, so please feel free to write in it. A simple description of up to two pages is what we expect. It is not my desire to waste your time writing your paper.


Support _first and _last parameter for missing bucket ordering in composite aggregation

Description
Support _first and _last parameter for missing bucket ordering in composite aggregation.
If missing_order is "_first" or "_last", regardless order, missing_bucket is at first or last respectively. for example, the following query will sort product asc and null bucket will be placed at last.
{
  "size": 0,
  "aggs": {
    "my_buckets": {
      "composite": {
        "sources": [
          {
            "product_name": {
              "terms": {
                "field": "product",
                "missing_bucket": true,
                "missing_order": "last",
                "order": "asc"
              }
            }
          }
        ]
      }
    }
  }
}

Issues Resolved
#1899
Check List

[x ] New functionality includes testing.

[x ] All tests pass

[ ] New functionality has been documented.

[x ] New functionality has javadoc added

[ x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo Why did you close this?

@penghuo Why did you close this?

I forgot to sign-off.  Post another PR instead. https://github.com/opensearch-project/OpenSearch/pull/1942


Get Contract Details GraphQL

As NHS admin I want to be able to get Contract Details using new admin portal.
So, we need to implement it using graphql

[x] confluence / schema / features
[x] implement
[ ] test

things to be changed or fixed:

[ ] instead of contractRequestId we should use contractRequest:ContractRequest
change in both schema and implementation
[ ] parentContract can be null. Now I receive error Cannot return null for non-nullable field
change in schema parentContractId to parentContract:Contract
[ ] attachedDocuments return null response


docs: add more pages for other frequently asked questions

The project could use a few more pages to better guide users as well as meet common expectations from documentation sites. The goal is to remove all gray spots that may leave our potential users confused or unable to understand tge scope of this project
Some pages to be added are:

[ ] changelog - to keep track of the project changes
[ ] contributions - guidelines on getting started with contributing to various aspects of the project
[ ] references - links to other related resources
[ ] download - For links to download the library's source code

The guides and examples will be hosted on the project wiki here on GitHub to make it easier for anyone to contribute to that part of the project.
@foss2cyber @adarshswaminath @takanome-dev
Any insights on what other pages we may add to the documentation site?

Stale issue message


refactor(init): move service creation to lambda init

Current dependencies on/for this PR:

main

PR #54   👈

This comment was auto-generated by Graphite.


how to get message's body from messgeView

messageView.getBody returns ByteBuffer object ，does it has graceful method to get messageBody？

@MumfordSons Thanks for your feedback! Actually message body in messageView is readonly, which means you could not get byte[] from bytebuffer directly because byte[] here is the underlying reference and it is not read only.
Just copy byte[] from bytebuffer If you still need to get byte[] from readonly bytebuffer. By the way, creating issues from rocketmq-clients could help it to attract more attention. 😊

@MumfordSons Thanks for your feedback! Actually message body in messageView is readonly, which means you could not get byte[] from bytebuffer directly because byte[] here is the underlying reference and it is not readonly.
Just copy byte[] from bytebuffer If you still need to get byte[] from readonly bytebuffer. By the way, creating issues from rocketmq-clients could help it to attract more attention. 😊
ok，thanks


cmake & make error in deform

Hi, thanks for sharing the code.
I tried to train the models with the codes provided, but encountered an error when building the "deform" library.
When I type cmake .. and make in deform/build directory, I encounter with the following error message. Could you give me some advice an how to solve the error, or what CUDA version and GPU you are using?
(I am using GTX 1080 Ti and CUDA 9.0, by the way).
Would really appreciate if you could give me some help!
1 error detected in the compilation of "/home/johnyi/Documents/DAN-master/cpp/Deform/build/deform_psroi_pooling_op_gpu.cpp1.ii".
CMake Error at cuda_compile_2_generated_deform_psroi_pooling_op_gpu.cu.o.cmake:280 (message):
Error generating file
/home/johnyi/Documents/DAN-master/cpp/Deform/build/CMakeFiles/cuda_compile_2.dir//./cuda_compile_2_generated_deform_psroi_pooling_op_gpu.cu.o
CMakeFiles/deform.dir/build.make:70: recipe for target 'CMakeFiles/cuda_compile_2.dir/cuda_compile_2_generated_deform_psroi_pooling_op_gpu.cu.o' failed
make[2]: *** [CMakeFiles/cuda_compile_2.dir/cuda_compile_2_generated_deform_psroi_pooling_op_gpu.cu.o] Error 1
CMakeFiles/Makefile2:72: recipe for target 'CMakeFiles/deform.dir/all' failed

请问你解决问题了吗？我也遇到了cmake编译的问题。-- Found CWD: /home/ChenGb/wl/renlianshibie/jiance/PyramidBox-master/datasets/DAN-master/cpp/ExtraLib/build
-- Found GPU_CAPABILITY: gencode arch=compute_61,code=sm_61
Traceback (most recent call last):
File "", line 1, in
ImportError: No module named 'tensorflow'
Traceback (most recent call last):
File "", line 1, in
ImportError: No module named 'tensorflow'
-- Found TF_INC:
-- Found TF_INC_EXTERNAL: /external/nsync/public
-- Found TF_LIB:
-- Configuring done
-- Generating done
但是我是装了tensorflow的啊

@JuheonYi 看看虚拟环境有没有问题


[Docs] What is the difference between internvl_g, internvl_chat_llava, and internvl_chat?

📚 The doc issue
Dear experts, what is the difference between internvl_g, internvl_chat_llava, and internvl_chat? If you can answer this question, it would be a great help to me. Thank you very much!
Suggest a potential alternative/fix
No response

Thank you very much for your question. The three models you mentioned are all proposed in our InternVL 1.0. For a detailed introduction, please refer to our 1.0 paper.

internvl_g: For contrastive tasks, as shown in Figure 4 (a) (b), we introduce two inference modes: InternVL-C and InternVL-G, using the vision encoder or the combination of InternViT and QLLaMA to encode visual features.

internvl_chat: For multi-modal dialogue, we introduce InternVL-Chat, leveraging InternVL as the visual component to connect with LLMs.

internvl_chat_llava: InternVL-Chat-LLaVA is a code implementation of InternVL-Chat V1.0. We mainly use the LLaVA code base to evaluate the performance of InternVL (InternViT-6B) in creating MLLM.

Thank you very much for your question. The three models you mentioned are all proposed in our InternVL 1.0. For a detailed introduction, please refer to our 1.0 paper.

internvl_g: For contrastive tasks, as shown in Figure 4 (a) (b), we introduce two inference modes: InternVL-C and InternVL-G, using the vision encoder or the combination of InternViT and QLLaMA to encode visual features.
internvl_chat: For multi-modal dialogue, we introduce InternVL-Chat, leveraging InternVL as the visual component to connect with LLMs.
internvl_chat_llava: InternVL-Chat-LLaVA is a code implementation of InternVL-Chat V1.0. We mainly use the LLaVA code base to evaluate the performance of InternVL (InternViT-6B) in creating MLLM.

Is it possible to use InternVL2_5-8B in internvl_g structure? I want to replace Llama with InternVL2.5, but it seems has no cross attention part and no query either. What I can do to use InternVL2.5 in internvl_g and finetune it?  @yuecao0119

Sorry, I may not understand what you mean.
Starting from InternVL 1.5, we have abandoned the QLLaMA middleware and adopted the simpler ViT-MLP-LLM framework. So InternVL 2.5 is a complete multi-modal dialogue model, and its purpose is closer to internvl_chat.

Thank you very much for your question. The three models you mentioned are all proposed in our InternVL 1.0. For a detailed introduction, please refer to our 1.0 paper.

internvl_g: For contrastive tasks, as shown in Figure 4 (a) (b), we introduce two inference modes: InternVL-C and InternVL-G, using the vision encoder or the combination of InternViT and QLLaMA to encode visual features.
internvl_chat: For multi-modal dialogue, we introduce InternVL-Chat, leveraging InternVL as the visual component to connect with LLMs.
internvl_chat_llava: InternVL-Chat-LLaVA is a code implementation of InternVL-Chat V1.0. We mainly use the LLaVA code base to evaluate the performance of InternVL (InternViT-6B) in creating MLLM.

Thank you for your response, which has given me a very clear understanding！ May I ask what are the differences betweenhttps://github.com/OpenGVLab/InternVL/tree/main/internvl_chat and https://github.com/OpenGVLab/InternVL/tree/main/internvl_chat_llava, and is there any difference in their performance?
Thank you again for your answer！

Thank you very much for your question. The three models you mentioned are all proposed in our InternVL 1.0. For a detailed introduction, please refer to our 1.0 paper.

internvl_g: For contrastive tasks, as shown in Figure 4 (a) (b), we introduce two inference modes: InternVL-C and InternVL-G, using the vision encoder or the combination of InternViT and QLLaMA to encode visual features.
internvl_chat: For multi-modal dialogue, we introduce InternVL-Chat, leveraging InternVL as the visual component to connect with LLMs.
internvl_chat_llava: InternVL-Chat-LLaVA is a code implementation of InternVL-Chat V1.0. We mainly use the LLaVA code base to evaluate the performance of InternVL (InternViT-6B) in creating MLLM.

Thank you for your response, which has given me a very clear understanding！ May I ask what are the differences betweenhttps://github.com/OpenGVLab/InternVL/tree/main/internvl_chat and https://github.com/OpenGVLab/InternVL/tree/main/internvl_chat_llava, and is there any difference in their performance? Thank you again for your answer！

The internvl folder mainly contains the implementation of the V1.1~2.5 series of InternVL-Chat. Reference reports: V1.5 paper, V2.5 report.
The internvl-chat-llava folder mainly contains the implementation of InternVL-Chat V1.0, corresponding to Section 4.4 of our InternVL 1.0 paper.
Model version evaluation, better overall performance, more supported modes.


YT-DLP crashes before finishing any download

I just downloaded the automatic installer and tried using YT-DLP gui but every time I start a download, it closes after a clouple seconds, leaving me with 3/4 uncompleted files in YT-DLP's directory.

I had the same problem.
It was caused on my system due to my regional settings using a comma (dutch regional settings) instead of a point (english regional settings) as the decimal separator.
This will crash the program, when it parses the output of yt-dlp.exe, as that always uses a point.
It is fixed in my pull request https://github.com/kannagi0303/yt-dlp-gui/pulls


Issue/224 - change builtInButtons to buttons

This branch obfuscates the binding for buttons in steps to the user and makes setup mirror the docs from Shepherd.js. For issue #224

@chuckcarpenter I don't think we should call something that's not the same as Shepherd, the same as Shepherd here. builtInButtons have a type and generate a button that is built into ember-shepherd. These include cancel, back, next, etc. If we're trying to align with Shepherd and just be a pass through, this will be confusing to people, I think, right?

I'm still in favor of merging builtInButtons output and buttons if you want vanilla Shepherd buttons.

It seems like the primary issue here is that the interface lacks constraint. What if we had two separate options: shepherdButtons and customButtons. Each is focused, explicit, and unambiguous -- unlike builtInButtons and buttons, apparently 😛.

@BrianSipple I would keep builtInButtons I think. The buttons are built in and provided. customButtons makes it sound like you want to do something custom.
We could potentially use just buttons I suppose, and add a check for type. If you pass type we use a built in one we provide, if you do not, it's just treated like a vanilla Shepherd button. What do you think @chuckcarpenter?

customButtons makes it sound like you want to do something custom.

Right, isn't that what we're trying to enable? The current confusion is from the fact that builtInButtons allows you to select from one of shepherd's buttons and pass in something different. Or am I confused about what we're confused about?

@BrianSipple Shepherd does not provide any buttons.

Totally agree @BrianSipple! We just need to fix conflicts here and add the type check stuff.


Clone key in copy constructor

The copy constructor for Blake2bDigest clones the new instance's own key rather than the key of the instance being copied.

Thanks. Applied.


Screen recording not working with replay kit and broadcast extension

Hi,
https://drive.google.com/file/d/1laasE2uC6OFulKqrh3e3SaItiUi-E01v/view?usp=sharing
In this video, we have called android phone and during the call, an Android device has shared its screen(using Twilio) and during screen iOS device can see every actions and activity of android. We want to implement the same things in iOS. How iOS can share or broadcast its mirror screen to other devices?
We have used TVIScreenCapturer.init(view: view) but it broadcasts only current view. We want to share the entire device with an opponent.
I've also created ticket in twilio support for the same issue "https://www.twilio.com/console/support/tickets/1517926" in this ticket you can find whole conversation
Thanks

@Perachi  TVIScreenCapturer is deprecated on iOS 12.0 and above due to performance issues on wide-color devices. If you wish to share the contents of the screen we recommend that you use ReplayKit instead. Take a look at our ReplayKit example app to get started. The ReplayKit example demonstrate the entire device with the remote Participant when the iOS version is >= 12.

@Perachi Let me know if have any questions for me, else we can close this ticket.


Subteam mentions

Slack supports links to user-groups/sub-teams, of the form: <!subteam^link|@team_name>. This seems to be the least invasive method to support this in a way that has a chance of supporting similar links in the future.
Thanks!

@paulhammond Does this seem like a reasonable approach? hubot-slack doesn't seem to do this yet.

perhaps the pattern for the subtype should be [^^]+  instead of \w+, just in case other punctuation ends up in those identifiers.

Hi!
So this command is documented at https://api.slack.com/docs/formatting:

For paid teams there is an additional command for user groups that follows the format <!subteam^ID|handle>. These indicate a user group message, and should cause a notification to be displayed by the client. User group IDs can be determined from the usergroups.list API endpoint.

I can tell you that the the subteam IDs will always be alphanumeric in this case. So your code will handle the subteam command just fine.
But I think it's worth drawing your attention to the next paragraph in the docs where we say we might be adding new commands in the future (where commands are things starting with a !). I know there's at least one more we're about to document, and that uses a lot of non-letter characters after the ^, and even has more than one ^. All of these new types will include labels (because we need to maintain some level of backwards compatibility with existing mobile clients) so the approach you have will almost work, except for the multiple ^ thing.
Here's a test case that includes most of the test cases you might need to consider:
<!foo^C12345^{foo}^http://www.example.com/|label>
(Oh and I'm moving onto a different team at Slack in the near future. Jimmy, I'll introduce you to some other people on the platform team who can help you with these kinds of questions from here on)

Thanks very much, Paul!

@jimmycuadra I just discovered that we’re pinned to my branch for this PR, and we need some of the newer features. I’m going to resurrect it and attempt to handle @paulhammond’s example case above. I’ll review the updated docs, but is there anything you know I need to watch out for?
(Also, this should fix #124)

Wow, it’s been a while! Yes, the thing we were about to launch that I was referring to above was <!date>, docs for that are at https://api.slack.com/docs/message-formatting#formatting_dates

@jimmycuadra I opted to swap values in a few conditionals after the regexp replace in favor of making the regexp quite a bit more complex trying to get them right with lookaheads. I think that would likely make the regexp inscrutable. Let me know if you’d prefer it that way.

Hmm. That spec also failed locally, but was far away from my changes, and I presumed it was my environment. I’ll take a quick look at it to see if I can figure out why it is failing.

The spec fails non-deterministically. rspec --seed 0 ./spec/lita/adapters/slack/rtm_connection_spec.rb:119 will fail about 20% of the time. But it clumps in weird ways, too.


Expose normalization method to Mel transforms

create_fb_matrix function supports Slaney normalization. [doc]
There are three transforms that uses this function, MelScale, InverseMelScale and MelSpectrogram (via MelScale). It was pointed out in #1058 that it is useful to expose the normalization option to these transforms. It is highly appreciated if someone can contribute this.
Steps

Add normalization argument to the transforms. MelScale, InverseMelScale and MelSpectrogram. (default to None for the backward compatibility.
[Optional] If the addition of Slaney normalization to MelSpectrogram makes it numerically compatible with librosa, add a test to check the numerical parity against librosa in librosa compatibility test (Add a new test class.)
This is not confirmed, so please run simple test locally and tell us if this is the case. See also #1058

Can I help out here?, what do I need do accomplish?

Can I help out here?, what do I need do accomplish?

Hi @pratik-99
Thanks. You can make a PR with the changes described above and ping me.

Hi @pratik-99
Thanks. You can make a PR with the changes described above and ping me.

hey @mthrok I'm new here can you explain me what do I exactly need to do I don't no the specifications of this project, can you help me out?

hey @mthrok I'm new here can you explain me what do I exactly need to do I don't no the specifications of this project, can you help me out?

Hi @pratik-99~ do you mind if I try this issue as well? I happen to need to complete some bootcamp task and this is one of them. Thank you!

Hi @pratik-99~ do you mind if I try this issue as well? I happen to need to complete some bootcamp task and this is one of them. Thank you!


DinD documentation

closes #832

Wow thanks @jhamman ! That made it a lot clearer to me. I deployed a BinderHub for neurips once and that is all my BinderHub deployment experience, but at that time I didn't understand this but now I grasp this thanks to your documentation!
:heart: :tada: LGTM

Question for Yuvi and/or Min: are there also security benefits for running builds via docker-in-docker? In my mind one reason to run in DIND mode is that you have better control over what the docker build... command executed by repo2docker has access to in terms of files and resources. But it is a fuzzy concept in my head so I can't write a sentence to include in the docs :(

@betatim I find this very challenging, and while working with gitlab's helm chart I've considered related security concerns about Docker overall to build and run things for users in CI pipelines.
Here are some of these concerns written down by GitLab's team:
https://docs.gitlab.com/runner/executors/kubernetes.html#using-docker-in-your-builds

Bumping this so we don't loose too much momentum. @betatim / @consideRatio - should we add some comments about DIND and security? I would need input from you on what to write.

@jhamman I'm not knowledgeable enough about these aspects yet to suggest something =/

When PRs go stale feel free to bump them by following up on the questions/discussion points by suggesting a resolution that seems to follow the consensus. I think a frequent reason for why things go stale is that there is no immediate actionable thing and no one is trying to get to one. I think it is best if the PR proposer tries to do the driving by suggesting a next actionable item.
For now I would skip the security question and maybe @jhamman can create a new PR addressing/adding thoughts on that. That way we can get this PR merged.

@betatim - thanks for the review. I've updated things a bit and this should be good to go in.

should we add some comments about DIND and security

I don't know. I'm not familiar with this issue so I'll leave this for the next contributor.


Unit test, localization use-deferred-loading: true makes same testWidgets not pass twice,

Details
We have a simple unit test that's failing when it is copy pasted and tested twice.
EG:

    testWidgets('should be properly sorted without favorites', (tester) async {
      await tester.pumpWidget(builder());
      await tester.pumpAndSettle();
      final scaffold = find.byType(Scaffold);
      expect(scaffold, findsOneWidget);
    });

    // // // same test if added, fails
    // testWidgets('should be properly sorted without favorites', (tester) async {
    //   await tester.pumpWidget(builder());
    //   await tester.pumpAndSettle();
    //   final scaffold = find.byType(Scaffold);
    //   expect(scaffold, findsOneWidget);
    // });

We pinpointed the issue to the custom localization delegate used by the library.  More specifically the deferred loading
Both test pass when using arb files with flutter --gen-l10n, one of two test pass when using use-deferred-loading: true
One of the two test fail when loading a json for localization instead.  So maybe rootBundle.loadString is at cause here.
reproduce
We have two branch here that have been reduced to the minimum to reproduce the issue (at least in the test files);
This one fails when the second test is uncommented. The test is the only one remaining and is in test/_country_selector_test.dart
git clone https://github.com/cedvdb/phone_form_field/tree/localization_json && cd phone_form_field && flutter pub get && flutter test

This one works with use-deferred-loading: false (or not specified) and does not work with it set to true. This can be set in l10n.yaml
git checkout localization_arb && flutter pub get && flutter test

Version:
flutter --version
Flutter 2.6.0-0.0.pre • channel dev • https://github.com/flutter/flutter.git
Framework • revision 83b9e99cfb (3 weeks ago) • 2021-08-23 19:03:21 +0200
Engine • revision d5adde01dd
Tools • Dart 2.15.0 (build 2.15.0-42.0.dev)
but I believe it happens on versions anterior to this one.

@cedvdb
This doesn't seem to be a performance related issue. I cloned the repo and ran as prescribed which passed, as below:
Cloning into 'phone_form_field'...
remote: Enumerating objects: 1216, done.
remote: Counting objects: 100% (1216/1216), done.
remote: Compressing objects: 100% (860/860), done.
remote: Total 1216 (delta 507), reused 987 (delta 292), pack-reused 0
Receiving objects: 100% (1216/1216), 7.45 MiB | 5.95 MiB/s, done.
Resolving deltas: 100% (507/507), done.
dhs@Dhss-MacBook-Pro ncflutter % cd phone_form_field
dhs@Dhss-MacBook-Pro phone_form_field % flutter pub get
Running "flutter pub get" in phone_form_field...                    7.2s
Running "flutter pub get" in example...                          1,072ms
dhs@Dhss-MacBook-Pro phone_form_field % flutter test
00:11 +17: All tests passed!
dhs@Dhss-MacBook-Pro phone_form_field %

Same with other one as well:
dhs@Dhss-MacBook-Pro phone_form_field % git checkout localization_arb && flutter pub get && flutter test
M	example/pubspec.lock
M	pubspec.lock
Branch 'localization_arb' set up to track remote branch 'localization_arb' from 'origin'.
Switched to a new branch 'localization_arb'
Running "flutter pub get" in phone_form_field...                   576ms
Running "flutter pub get" in example...                            566ms
00:02 +2: All tests passed!
dhs@Dhss-MacBook-Pro phone_form_field %

Also checked by directly running country_selector_test.dart which was uncommented and as-is which worked as below:

I verified this on latest stable (2.5.0)

In the first branch localization_json you ran flutter test, the second test is commented. Please uncomment or git pull second test to see it failing.
Note: this is not a performance issue, this was mislabeled

Actually I found a nice find to help you debug this:
When using the second repository (arb) which was working, if I use use-deferred-loading: true when generating localization it also stops working

Thanks for the details. From localization_json branch, if I run the tests as-is, I get below exception:

console error log
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure object was thrown running a test:
  Expected: exactly one matching node in the widget tree
  Actual: _WidgetTypeFinder:<zero widgets with type "Scaffold" (ignoring offstage widgets)>
   Which: means none were found but one was expected

When the exception was thrown, this was the stack:
#4      main.<anonymous closure>.<anonymous closure> (file:///Users/dhs/Downloads/phone_form_field-localization_json/test/_country_selector_test.dart:37:7)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)

This was caught by the test expectation on the following line:
  file:///Users/dhs/Downloads/phone_form_field-localization_json/test/_country_selector_test.dart line 37
The test description was:
  should be properly sorted without favorites
════════════════════════════════════════════════════════════════════════════════════════════════════

Test failed. See exception logs above.
The test description was: should be properly sorted without favorites

From the same test file, if I comment out below snippet and run again, the same tests passes properly:
  // locale: Locale('en'),
          // localizationsDelegates: [
          //   ...GlobalMaterialLocalizations.delegates,
          //   PhoneFieldLocalization.delegate,
          // ],
          // supportedLocales: [Locale('en')],

Is this a correct interpretation of the issue ?

That is for the localization_json
For the localization_arb one if you use deferred loading for the l10n.yaml you'll also get the same error. The arb one is a better case for reproducity because at that point there is nothing from my app and only vanilla flutter code or code generated by flutter itself.


Find/Replace Usability: Tabbing between fields should select all text

VSCode Version: 1.12.2
OS Version: Windows 10

Steps to Reproduce:

With an editor tab in focus, make a selection of a few characters and press CTRL+H to open the find/replace dialog.
If the Replace text box (the second one) is empty, enter some text, press escape, and repeat step 1.
You'll notice that the text in the Replace text box is selected.  This allows the user to quickly type something new without worrying about the selection or cursor position.
Press shift tab to move focus to the Find text box (the first one).  The cursor, by default, appears at the end of the text box.

Ideally all of the text in the Find text box would be selected allowing the user to quickly type over it.  The current implementation appears to preserve the selection and cursor position, which can be jarring because it's inconsistent (unless you're keeping track of the cursor position in your head, which seems unlikely).
The behavior I'm describing and requesting here is the same behavior in Visual Studio as well as Notepad and many other applications in Windows.  I can't speak for OSX, but as far as usability goes, selecting the text instead of preserving the selection seems to be more desirable.

The Search/Replace All Files fields work the way you're saying the Search/Replace Document fields should work. It would be nice for them to work the same way. I agree that selecting all the text when tabbing is the expected behavior, including on MacOS.


chore: upgrade to react 18

update react to 18 closes #490

Ready to go, let's deploy it on Monday


[docs] Migrate content to the new location

Current URL: https://deploy-preview-30757--material-ui.netlify.app/components/buttons/
New URL: https://deploy-preview-30757--material-ui.netlify.app/material/react-button/
Once this PR is merged, there might be some conflict on other PRs if they touch .md file. Those PRs have to revert the change and update the markdown in /docs/data/*.md instead.

[x] I have followed (at least) the PR section of the contributing guide.

It can take a while to review... 😉

 It can take a while to review... 😉

Honestly, smoke tests the deploy preview should be enough 😂. We should trust the e2e tests and ahrefs report.

Clicking on the System under the product pages is navigating me to the old system pages. Shouldn't it go to the new pages?

Clicking on the System under the product pages is navigating me to the old system pages. Shouldn't it go to the new pages?

Good point! but this is expected because the goal of this PR is to have the new URL for indexing (Users won't realize what we are doing, so the system pages remain the same).
The system pages will change in a follow-up PR when we enable the redirects.

Should we call it "Material UI" here?

Should we call it "Material UI" here?

Nice catch! I will need to refine the Product Drawer in the next PR anyway (will keep this as a checklist).

Note: the 1% error is not related to the migration. https://app.ahrefs.com/site-audit/3276941/5/data-explorer?columns=pageRating%2Curl%2Ctraffic%2ChttpCode%2Cdepth%2Ccompliant%2CincomingAllLinks%2Corigin&filterCollapsed=true&filterId=ce299062c267aa6829f86c4c4966bd3c&issueId=c64dae3f-d0f4-11e7-8ed1-001e67ed4656&sorting=-pageRating

A side note, I'm not a fan of this change:
-{{"demo": "pages/components/alert/TransitionAlerts.js"}}
+{{"demo": "TransitionAlerts.js"}}

Previously, you could grep the demo and search it in your IDE, zero conflicts. Now, there is a higher chance that the name will conflict with another folder.

A side note, I'm not a fan of this change:
-{{"demo": "pages/components/alert/TransitionAlerts.js"}}
+{{"demo": "TransitionAlerts.js"}}

Previously, you could grep the demo and search it in your IDE, zero conflicts. Now, there is a higher chance that the name will conflict with another folder.

Let me state why I did this change:

there is a TODO in loader.js // TODO: const moduleID = demoName;
 // The import paths currently use a completely different format.
 // They should just use relative imports.

Using relative imports means no couple with path (the whole folder can be moved around with no change, I know that this is a very rare case but I like having things independent from each other.

Can you explain more about what did you usually search for? Maybe we can do something about it.


MySQL bool type generates int32 golang type

The following MySQL source code:
CREATE TABLE example
(
    id         integer      NOT NULL AUTO_INCREMENT PRIMARY KEY,
    successful bool         NOT NULL
);

Generated the following model:
type Example struct {
	ID         int32     `json:"id"`
	Successful int32     `json:"successful"`
}

Actually, all the boolean types (bool, boolean and tinyint) are behaving in this way.
I'm currently using this workaround to force the correct type:
version: "1"

packages: [...]
overrides:
- column: "example.successful"
  go_type: "bool"

This has already been mentioned by @markschmid in https://github.com/kyleconroy/sqlc/issues/666#issuecomment-732159568_

MySQL doesn't have a native boolean type. BOOL and BOOLEAN map to tinyint(1). We can't map tinyint(1) to boolean because you can actually store values other than 0 and 1 in  a column marked tinyint(1).
The issue is that the MySQL parser we're using parsers BOOL and BOOLEAN (correctly) as tinyint(1) and offers no way to see the original type.

we may want to convert any tinyint(1) column to a BOOL.

This is now done

Using v1.7.0, it seems this issue is still there. I'm not using any overrides.
CREATE TABLE `images` (
    `is_main`    BOOL NOT NULL DEFAULT FALSE
)

type ImageGetRow struct {
	IsMain     int32     `json:"is_main"`
}

$ sqlc version
v1.7.0

Ahh, thanks for the in-depth report. It looks like I fixed it for model generation but something is off when generating the methods. Will fix!


feat: version v0.8.0

Proposed changes
Versioning version 0.8.0
Types of changes

[ ] 🐛 Bugfix (non-breaking change which fixes an issue)
[ ] ✨ New feature (non-breaking change which adds functionality or enhancements)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] ✅ Tests (added tests for an existing feature)
[ ] 📚 Documentation Update (if none of the other choices apply)
[x] 🙌 Other (please, write a clear and concise description of the proposal in the section above)

Checklist

[ ] 👀 I have read the CONTRIBUTING doc
[ ] ✅ Lint and unit tests pass locally with my changes
[ ] 🧪 I have added tests that prove my fix is effective or that my feature works
[ ] 📚 I have added the necessary documentation (if appropriate)
[ ] 🔀 Any dependent changes have been merged and published in downstream modules

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (fd2fcb2) compared to base (17d8fab).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##              main      #644   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          112       112
  Lines         1035      1035
  Branches       153       153
=========================================
  Hits          1035      1035

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Support GEP-1762

https://gateway-api.sigs.k8s.io/geps/gep-1762/
cc @envoyproxy/gateway-maintainers

@zirain what is the use case here ?
is it linking static Envoy Proxy infra to Gateways using this field ? If so, as part of this issue we must also generate Envoy Proxy Infra via helm

need support GatewayInfrastructure?

@zirain can you elaborate ?

relates to https://github.com/envoyproxy/gateway/issues/1379

@arkodg I think EG should follow https://gateway-api.sigs.k8s.io/geps/gep-1762/#automated-deployments


fix Jacobian to return transpose

Sebastian Weber on stan-users pointed out that the matrix returned by the Jacobian functional in   math/rev/mat/functor/jacobian.hpp returns a tranposed result.
According to
https://en.wikipedia.org/wiki/Jacobian_matrix_and_determinant
if f: R^N -> R^M, then the Jacobian should be M x N
But it's currently N x M.

[ ] fix Jacobian to be in line with standard definition

Hi!
Going over the function again, I think there is another bug, i.e. the function calls to
set_zero_all_adjoints();
should possibly be replaced with calls to
set_zero_all_adjoints_nested();
Right?
Sebastian

Either way will be OK, but the nested version will be more
efficient (the stuff below the current nesting will already
have all its adjoints set to zero because they're only nonzero
in reverse sweeps).

Bob

On Feb 20, 2016, at 5:51 AM, wds15<EMAIL_ADDRESS>wrote:
Hi!
Going over the function again, I think there is another bug, i.e. the function calls to
set_zero_all_adjoints();
should possibly be replaced with calls to
set_zero_all_adjoints_nested();
Right?
Sebastian
—
Reply to this email directly or view it on GitHub.

Hi Bob!
Let' start with smaller patches... I just fixed the problem described and pushed the branch
bugfix/issue-230-jacobian-transposed
Maybe you have a look and then we start a pull request?
Sebastian

@wds15, please create a pull request from that branch to develop. Thank you.


Boundary Gap For "ordinal" axis option

Hi when i am using "ordinal" axis option for plotting categories for Area Chart

how to reduce this issue ?

Use a time or linear based axis.


Add missed files

LGTM ping @bucaran

@sijad Can you just push the .gitignore for now. I am not sure we should keep using .editorconfig and the reason is that there is a fish_indent function that can help us format the code similar to what go fmt does for golang.
For this we would need to create a simple plugin to wrap the function, but it would be nice to have.
Please tell me if that has nothing to do with .editorconfig or if I missed something.

done ;-)

let me change the commit message

good to go


SSCS-5216 Accomodate reps with org names in Notify personalisations

JIRA link
https://tools.hmcts.net/jira/browse/SSCS-5216
Change description
Adds logic to support the display of alternate text for Representative who are an organisation rather than a named individual. Prevent display of "null null" when firstname and lastname are unavailable.
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

@arcotc I took another run at that merge conflict. Root cause of ADJOURNED_NOTIFICATION disappearing was indeed PEBKAC