Come up with strategy around multicall batch sizes

Batch sizes are likely going to be different per provider as they can apply their own limits. We need to set the limit for multicalling active dAPIs.
See this thread for reference.

A similar concern is eth_getLogs limits and providers used in an Airnode config. We just set a blanket limit for the chain there and weed out the providers that don't work with it.

Could we maybe do a quick benchmark when Airseeker starts?

It was decided to hardcode batch sizes to 10.


Update dependencies

This time it doesn't touch eslint dependency despite one of the commit messages.

Upgrade eslint-config-airbnb
Upgrade eslint-plugin-import, raw-loader, webpack-merge
Upgrade glob
Upgrade async
Upgrade @babel/cli, @babel/core, @babel/preset-env
Install eslint-plugin-react-hooks
Update caniuse-lite
Install eslint-plugin-react
Install eslint-plugin-jsx-a11y

@LewWadoo

List how you tested the updates.
Is any new release justified?

@LewWadoo
1. List how you tested the updates.

I relied on yarn run test e.g., jest tests. I used only this one option, so nothing to list.

2. Is any new release justified?

webpack should not be upgraded to a major release, because our documentation states that it supports Webpack 4. It's easier to justify minor and hotfix releases, but all my major upgrades were not justified. I just wanted to see how far I can go without breaking the tests.

Did CI run? I'm surprised that the code didn't need updates with the eslint changes.

@Judahmeek @LewWadoo what's needed to get CI to run on this branch? #160 is merged.

And do we need a new release?

And do we need a new release?

I think we do. So we don't need to merge it blindly.

@LewWadoo why not just rebase & force push to this branch instead of creating a new PR?


Implement offline persistence desync recovery

The persistent transition frontier database lags behind the root snarked ledger database by design (in order to limit writes required to scale transition throughput and eventually separate writes to a different process). This means that if the daemon shuts down in a way such that it is not able to gracefully synchronize the data between both persisted states, the daemon needs to do some work in order to re synchronize those two states. Right now, there is not enough persisted information available in order to do this. Currently, when we get into this state, we just wipe the persisted frontier and bootstrap to the network, but this is not good.
Here is a plan for enabling offline persistence desync recovery. we can implement an inverted snarked ledger witness queue which is stored on disk and tracked by the Persistent_root module (which also "owns" the root snarked ledger database). What this enables is the ability to "fast forward" the root of the persisted frontier to a root which points to the state of the root snarked ledger database. This can be done through the following algorithm:
Call the state that the root snarked ledger points to s1 and the state that the persisted frontier's root is at s0. Note that s1 will always be at the same point or further ahead in the chain than s0 (s1 >= s0 wrt height).

make a mask on the root snarked ledger database, label it mr
apply undos (inverted txn witnesses) from the queue maintained by the persistent root to mr, synchronizing its merkle root with the snarked ledger hash pointed to by s0.
make a mask ms off of mr
apply all transactions in the staged ledger (cumulatively) to ms, bringing it's root to the same value that the staged ledger of s0 points to.
construct the staged ledger at s0 using ms and the scan state data stored in the persisted root
find the transition matching s1 in the persisted frontier
fold over the path between s0 and s1, moving the root in the persisted frontier, applying staged ledger diffs to the staged ledger constructed in step 5 (also need to commit txns for proofs emitted to mr to keep ms in sync with the staged ledger)
persist the new staged ledger auxiliary data
destroy both ms and mr
load the full frontier from the persisten frontier as usual

#6370 is a good interim solution to this problem, but it would be nice to keep this algorithm captured somewhere for the future in case we determine that #6370 is not enough by itself (it will not work in all shutdown cases, where are this should approach should). I'm reopening for now, at least until this solution is better captured elsewhere. Otherwise, we can leave this issue open as a low priority item on the backlog so that we can pull it up if we need to in the future.

After a discussion regarding #6830 and the need to generate a root snarked ledger for the some transition in the root history, it seemed easier to fix the desync in the first place and remove eager application of root transition diff that caused #6830.
Context:
The original problem was that the persisted root snarked ledger gets ahead of the persisted frontier's root. So we eagerly move the persisted frontier's root to be in sync with the persisted root snarked ledger. However, if a node crashes abruptly and the frontier transitions are not written to the disk, then the persisted frontier might have transitions less than k breaking the k- invariant of the transition frontier. Fixing this involves persisting root history and the ability to generate the snarked ledger corresponding to a block in the root history to serve sync ledger queries.
The fast-forward approach described above where the the persisted root is moved forward would also break the k-invariant by how many ever blocks the root moves.
@nholland94 and I discussed a solution that would solve the desync problem and would not break the k-invariant:
Solution:  instead of moving the persisted root forward (eagerly or using the above mentioned fast-forward algorithm), we can bring the persisted root snarked ledger back to be in sync with the persisted frontier's root. This will keep the persisted frontier intact with k blocks and in sync with the root snarked ledger. The node will also be able to serve transition chain proof and sync ledger queries. The node's best tip after loading the frontier would be older than the network's best tip by the number of blocks moved back to sync ledger + any new blocks since the node went offline. The node can then catch up/bootstrap to the network's best tip.
We would have to persist the undos as described in the algorithm above (step 1 and 2)  and use those to get the persisted root snarked ledger in sync.
Note: For a very small k it is possible that the block the persisted root snarked ledger points to will not to be in the persisted frontier at all and therefore cannot sync to the persisted frontier. This will not happen given the current value of k = 290. The diff buffer max size is 120 diffs before it is flushed and total diffs for k transitions in the worst case = 2*k + 3. This means the block that the root snarked ledger points to (when the root moves) will be in the persisted frontier

Hm... not sure I am reading your message correcltly, but when I implemented the eager root application, I remember thinking that the idea of persisting undos didn't really make sense. Here is why:

each undo is basically a block
we would need to serialize the undos eagerly in order to make sure they are there for us to recover
the whole point of this diff buffering thing was ostensibly to avoid writing blocks to disk

So, it seems to me in eagerly serializing of an undo to save us from eagerly serializing "add block" diffs we are basically trading 1 for 1, and if we think that is ok, then we should just eagerly serialize all diffs.

To me it is better than eagerly persisting all the diffs because those can be more frequent than moving the root, given that slots have multiple blocks. I think persisting the undos is equivalent to eagerly applying root transition diffs but without the less-than-k-blocks problem


SCB-1604 modify InterruptedException

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Well, it looks like we need to introduce a code style checking plugin ?

Well, it looks like we need to introduce a code style checking plugin ?

Code style plugin setting up guide could be found here: http://servicecomb.apache.org/developers/setup-develop-environment/


Add wrappers to the documentation list (Please add your own)

[ ] PHPokeapi https://github.com/n1c0l4stournier/PHPokeAPI
[ ] Poke node https://github.com/hemphillcc/pokenode

node - https://www.npmjs.com/package/pkmn

I have a Drupal project that integrate with Pokeapi.
https://www.drupal.org/project/pokeapi

Another PHP wrapper https://github.com/williamn/pokeapi-php


Sync eng/common directory with azure-sdk-tools for PR 8376

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/8376  See eng/common workflow

Keyvault failures seem to be in main...which means I'm going to ignore this likely. Letting a main invocation of the keyvault CI run to verify the suspicion.

Going to check-enforcer override. There is the exact same # of failed tests in main vs this PR. Ignoring.

/check-enforcer override


How do I override default blade files such as sidebar.blade.php and master.blade.php?

The current documentation only shows how to override the bread views, but there isn't a way to override the other views.
What is the proper way to edit those files? Is it just editing the blade templates in tcg/voyager/resources/views directly?

You cant. Why you want to ovveride them?

If you can't override any of these views, then it's not flexible at all. I want to display different sidebar menu based on different user roles. Also, I can foresee that there will be pretty extensive changes all over the admin panels in real world projects (clients might request to change the layout of the views).

@davodavodavo3 is incorrect.  Laravel documentation shows you how to override any package view.  Our documentation is intended to supplement the laravel documentation on this topic.

I still don't get it @fletch3555 , how to implement it in voyager case
The documentation of laravel about that it's not clear for me, can you explain the step for voyager ? i wanna override sidebar view too
Thanks :D

The documentation tells you exactly how to override package views.
Just scroll down to Overriding Package Views

Okay, please tell me if im wrong sir @emptynick :

I create a file for override view of voyager sidebar here : resources/view/vendor/voyager/admin_menu.blade.php
What should i do next ? nothing ? number 1 should override it ?

Well the view you want to override needs to exist of course.
So if you want to override menu/admin_menu your path would be
resources/view/vendor/voyager/menu/admin_menu

Thanks sir @emptynick , you help me so much :+1:


Propper credit and lots of bugfixes

Hi, would you be willing to rebase this on https://github.com/diasurgical/devilutionX so that proper credit is given to all that worked to make this possible. This would also fix a lot of the defects and issues with the port. Let us know if you need some help with the process.

Yeah I could do that. I'm sorry if I didn't do this from the start, I was just hacking around and I guess I forgot to make this repo private. I'll make the changes as soon as I can.

No worries at the time you did this DevilutionX was still 3 months away from fully covering all the needs for this port. It would be really awesome if you can help to get Vita support upstreamed so that we cab vetter support players that are interested ands have hellfire support ready on day one :)


LabeledExpression>ignoredLabels allow yaml list

This PR is one in a serie of PRs to implement #2498

Codecov Report

Merging #2613 into master will increase coverage by 1.71%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #2613      +/-   ##
============================================
+ Coverage     25.28%   27.00%   +1.71%
+ Complexity      396      394       -2
============================================
  Files           379      379
  Lines          7438     6743     -695
  Branches       1225     1224       -1
============================================
- Hits           1881     1821      -60
+ Misses         5428     4793     -635
  Partials        129      129

Impacted Files
Coverage Δ
Complexity Δ

...bosch/detekt/rules/complexity/LabeledExpression.kt
30.43% <50.00%> (+6.43%)
1.00 <0.00> (ø)

...itlab/arturbosch/detekt/api/internal/Validation.kt
33.33% <0.00%> (-16.67%)
0.00% <0.00%> (ø%)

.../gitlab/arturbosch/detekt/cli/console/Colorizer.kt
61.53% <0.00%> (-9.90%)
0.00% <0.00%> (ø%)

...h/detekt/api/internal/DisabledAutoCorrectConfig.kt
55.55% <0.00%> (-8.09%)
4.00% <0.00%> (ø%)

...otlin/io/gitlab/arturbosch/detekt/core/TaskPool.kt
33.33% <0.00%> (-6.67%)
3.00% <0.00%> (ø%)

...in/io/gitlab/arturbosch/detekt/api/SingleAssign.kt
60.00% <0.00%> (-6.67%)
3.00% <0.00%> (ø%)

...in/kotlin/io/gitlab/arturbosch/detekt/api/Issue.kt
50.00% <0.00%> (-5.56%)
2.00% <0.00%> (ø%)

...n/io/gitlab/arturbosch/detekt/api/ConsoleReport.kt
75.00% <0.00%> (-5.00%)
4.00% <0.00%> (ø%)

...tlab/arturbosch/detekt/api/internal/EmptyConfig.kt
66.66% <0.00%> (-4.77%)
4.00% <0.00%> (ø%)

...in/io/gitlab/arturbosch/detekt/cli/OutputFacade.kt
77.77% <0.00%> (-4.05%)
5.00% <0.00%> (ø%)

... and 260 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee023d...5ec6567. Read the comment docs.


Provide an AppImage for Linux distributions

(Based off of https://github.com/MrAlex94/Waterfox/issues/127)
Providing an AppImage would have, among others, these advantages:

Works for most Linux distributions (including Ubuntu, Fedora, openSUSE, CentOS, elementaryOS, Linux Mint, and others)
One app = one file = super simple for users: just download one AppImage file, make it executable, and run
No unpacking or installation necessary
No root needed
No system libraries changed
Just one format for all major distributions
Works out of the box, no installation of runtimes needed (unlike Snap and Flatpak)
Optional desktop integration with appimaged
Optional binary delta updates, e.g., for continuous builds (only download the binary diff) using AppImageUpdate
Can optionally GPG2-sign your AppImages (inside the file)
Works on Live ISOs (unlike Flatpak)
Can use the same AppImages when dual-booting multiple distributions

Here is an overview of projects that are already distributing upstream-provided, official AppImages.
It might be great if this project could make use of it.

Duplicate of #36.


Deliverables

. [ ] Create this issue
2. [ ] Install softwares
3. [ ] Install VSCode extensions
4. [ ] Organize your computer
5. [ ] GitHub setup
6. [ ] Fork and Clone the flashcards repository
7. [ ] Prep work for Workflows Chapter 1

completed


Upgrade GitHub Action from v1 to v2 and add reference links for clarity

The tutorial uses GitHub Action v1, which is outdated, so this needs to be upgraded to Checkout Version 2. In addition, few instructions can need clarity where the readers can pursue own learning further:

GitHub Action Workflow Syntax
GitHub Metadata Syntax

Link to PR:
https://github.com/githubtraining/hello-github-actions/pull/36


Thank you, very helpful project!

Hi, @zellyn and @srlehn
I just wanted to take a moment to express my gratitude for this project. Although it is no longer actively maintained, I wanted to let you know that it is still working well and has been a great help to me. I appreciate the time and effort you guys put into creating and maintaining it, and your contributions to the open source community are truly appreciated. Thank you.

Thanks!
I do plan to implement fixes, etc. every now and then. But this project has a very low priority for me.
Closing this as it is not an issue.


RxJs Dependency Problems

Fresh clone of repo (Windows 10 64-bit, latest NPM, lastest Node) is getting the following after running npm install (note that I have run npm install once already at this point):

Additionally I get a ton a errors when running npm start:

This is what I get when attempting to view the app on localhost:3000:

the location you downloaded the repo at doesn't allow you to remove files. if you download the repo again I pushed the changes to revert the rxjs update hack

Thanks for your swift reply ^^ I will give it a try.

The compilation errors have gone away, thank you again for all your work.

I am still getting a few errors after running npm run server:

@datatypevoid  can you update this file or pull latest changes again
https://raw.githubusercontent.com/AngularClass/angular2-webpack-starter/master/src/polyfills.ts

All cleared up. Thank again. This is the best resource I have found for Angular 2 with Webpack.

awesome thanks for opening an issue :+1: feel free to oen another one if you run into another problem


[BUG] Inconsistency across spinners

Some spinners, notably the ones built using emojis, include a trailing space. An extra space is inserted between the spinner and the spinner's text. I would argue that this is one space too much.
This difference is easy to see when running python -m rich.spinner.

Can you cut and paste it, and count the spaces?

Here are two from python -m rich.spinner:
 ◵ 'circleQuarters'
 🕘  'clock'

The frames in _spinners.py clearly include the spaces.

The spinners are inherited from another project, and I suspect they are there to compensate for differences in how emojis are rendered on different platforms.

I’d consider a PR but since you’re the first to notice, it’s very low priority.


wapiti: 3.1.1 -> 3.1.2

Description of changes
https://github.com/wapiti-scanner/wapiti/blob/master/doc/ChangeLog_Wapiti

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.


Zone already loaded on npm run server

I'm submitting a...

[x] Bug report
[ ] Feature request
[ ] Documentation issue or request

In package

[ ] @ng-toolkit/init
[ ] @ng-toolkit/serverless
[x] @ng-toolkit/universal
[ ] @ng-toolkit/pwa
[ ] @ng-toolkit/firebug

Current behavior
Started using ng-toolkit, it generated all the sources and code is build successfully. When I run the "npm run server" getting error as "Zone already loaded". I found out I have zone imports in polyfills.ts and server.ts. Need help in resolve the issue?
Error: Zone already loaded.
at sample-app/dist/server.js:200473:15
at sample-app/dist/server.js:201085:3
at module.exports.FUNCTION (sample-app/dist/server.js:200451:10)
at Object.module.exports.Object.defineProperty.value (sample-app/dist/server.js:200453:2)
at webpack_require (sample-app/dist/server.js:21:30)
at Object.zone.js/dist/zone (sample-app/dist/server.js:242055:18)
at webpack_require (sample-app/dist/server.js:226904:30)
at Object../src/polyfills.ts (sample-app/dist/server.js:240817:1)
at webpack_require (sample-app/dist/server.js:226904:30)
at Object../src/app/app.module.ts (sample-app/dist/server.js:229925:1)
Expected behavior
should run the
Minimal reproduction of the problem with instructions

Generate a Angular project with polyfills.ts which has import 'zone.js/dist/zone';
use ng add @ng-toolkit/universal
build using npm run build:prod
run using npm run server

Angular version: 6.1.2

- Node version: v8.11.3
- Platform:  Mac

Have the same issue, @dosapati Made it working?

Nope. I couldn’t solve it

Planning to move forward with other options.

Closing now as there have been new releases and the issue is already too old.
Please open a new issue if you find this same bug.
Cheers!


LQOI

Changes might be to aggressive.
Is enough for MathOptInterfaceCPLEX, with LinQuadOptInterface
How do we proceed?

I removed stuff from MOI which is lives now in MathOptInterfaceCPLEX.
This is needed to have MathOptInterfaceCPLEX working. It is passing CPLEX.jl tests.
Should I test anything else?
Is the current organization ok?
cc @mlubin @odow @blegat

Callbacks are still unresolved. I'm not in a rush to have this merged. It almost seems like there should be a CPLEXBase.jl with this version of the C wrapper to go with MathOptInterfaceCPLEX.jl. Then CPLEX.jl can stay with the MPB version and callbacks.

I am not very found of having both CPLEXBase.jl  and CPLEX.jl unless the second is completely discontinued and turned into legacy.

This PR, and https://github.com/JuliaOpt/CPLEX.jl/pull/139 are both pretty unwieldy.
I propose closing both, and starting again from the latest master.
That new PR would

add the code from MathOptInterfaceCPLEX.jl
add all of the new cpx_xxx.jl files
retain all of the old code, except, where the arguments are the same, deprecate in favour of the new named functions. e.g., read_model becomes cpx_readcopyprob.
An alternative to the last point:
the various add_constrs! add_var! methods leave a high surface area for bugs. Leave all of the function definitions, but replace the bodies with an appropriate error.

I am ok with that

Closing in favor of #181


succeeded() parameter is undocumented

I couldn't find any documentation that indicated succeeded allowed a parameter reference to a particular job. E.g. succeeded('JobName')

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 21e5cee4-eaae-3a96-db91-540ac759e83a
Version Independent ID: 9bdc837c-ffe0-d999-f922-f3a5debc7f92
Content: Conditions - Azure Pipelines
Content Source: docs/pipelines/process/conditions.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

Ho @Eonasdan Those are system predefined methods for comparing/decision-making methods. I believe the system doesn't have any method which takes parameters as inputs.

Thanks @kohithms! @Eonasdan succeeded() is a job status functions. You can learn more about it and other job status functions in our expressions article. They do not take arguments.


Soft delete and changelog

In the CMDB/IPAN/DCIM one of the essential roles is to have historical information on what was the object state and why at the point of time. Therefore I think there should be a soft delete option for objects that are either currently not observed of have been deleted, otherwise the whole history (changelog) is lost together with the record.

Yes its good to have history of an object, but how would you implement this in netbox? There is no soft delete option, when an objects gets deleted from the API all changelog gets lost with it.

I'd say playing with the status of an object or assigning a tag would be a solution. I will think of it and describe my vision

Lifecycle wise i imagine:
asset -> purchase/inventory id/stocking can be handled in Inventory plugin/module
resource -> in use/on the field in core netbox [as device]
Nevertheless device-asset (even in case of reimage .. new uuid; rename etc) relationship and/or device should not be deleted as it is "same thing" with different values or..?

The easiest way I currently see, is to add orphan tag to objects which would mark soft deletion. But this approach would introduce use to new issues like:

which orphans to autodelete and which to keep
adding new objects whose primary keys would overlap with orphans would trigger error

So full redesign of OrphanManager will also have to be implemented.

The easiest way I currently see, is to add orphan tag to objects which would mark soft deletion.

Hi there! This is how https://github.com/bb-Ricardo/netbox-sync works and it works pretty well :)
See: https://github.com/bb-Ricardo/netbox-sync?tab=readme-ov-file#principles or https://github.com/bb-Ricardo/netbox-sync?tab=readme-ov-file#pruning

Hello thanks for the resources. I think the idea here is, if user specifies
netbox.removeOrphans: False

Then all objects that are orphans should be given Orphan tag. And on the next run if they are found this tag is deleted.
Also if removeOrphans is False, user can specify value that determines how long do we keep orphans (default will be forever):

netbox.OrphanLifeSpan: 3 which would mean remove orhpans after 3 days

Would this approach be the right one?

Hello thanks for the resources. I think the idea here is, if user specifies
netbox.removeOrphans: False

Then all objects that are orphans should be given Orphan tag

I think you mean :
netbox.removeOrphans: True

right?

:tada: This issue has been resolved in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


When I aws-okta add and set a password with a space character, it fails

I'm running Ubuntu 18.04, and am using the 0.19.0 binary that has been published here on GitHub.
When I try running aws-okta add,  it always fails with the Failed to set credentials in your keyring when I input a password with a space character in it.  However, it works fine if the password I input does not have any space characters in it (I havent tried any other whitespace characters though).

I'm able to repro on Mac. Will take a look

Nope, I take that back. I cleared my keyring and now can't repro :(
I can't repro on Linux either actually. I'm running Ubuntu 18.04 in a Docker container. I was able to add an org/user/pass that was all spaces.
If you delete ~/.aws-okta (maybe make a backup), does it still happen?

@nickatsegment  yeah I'm able to get it to work on the Ubuntu 18.04 container, but not with the desktop it seems.

If you're able to build from master, maybe give that a go with -d. It'll actually log the underlying error: https://github.com/segmentio/aws-okta/blob/master/cmd/add.go#L89

@nickatsegment  I was actually able to get a little but farther with building it from the master branch,  it asked for my MFA code this time, but still failed to set the credentials in the keyring:
DEBU[0181] Failed to add user to keyring: Failed to execute program org.kde.kwalletd: No such file or directory
Failed to set credentials in your keyring

@Chili-Man I assume you don't actually want to use kwallet, right? Which backend are you using? Are you using the --backend flag? If you're not, try specifying it.

@nickatsegment I was able to get it to work with the latest 0.19.4 version;  thanks for the help!


Integrated Terminal - Can't enter commands, no bash prompt no cursor

VSCode Version: 1.3.0
OS Version: Mac OS X

Hi,
I can't enter commands using the integrated terminal after updating to 1.3.
Steps to Reproduce:

Open the integrated terminal

Same problem on windows 10 x64.
Terminal is not launched screenshot

Can you open developer tools (Help > Toggle Developer Tools) and check the console for any errors?
Also do either of you have a custom shell or any terminal-related settings in settings.json?

My user settings:
{
"editor.renderWhitespace": true,
"files.trimTrailingWhitespace": true,
"editor.fontFamily": "Source Code Pro",
"editor.fontSize": 0,
"editor.glyphMargin": true,
"editor.rulers": [120]
}
When I press Ctrl+` to open terminal no errors in developer tools. When I'm closed it I see 3 error messages:
index.html?config="...long address..."

Error: IPC channel is already disconnected
at ChildProcess.target.disconnect (internal/child_process.js:660)
at Pipe.channel.onread (internal/child_process.js:453)

events.js:154 Uncaught Error: IPC channel is already disconnected
target.disconnect	@	internal/child_process.js:660
channel.onread	@	internal/child_process.js:453

...long address... is URL parameters.
When I commented User settings the terminal is opened.
The problem is in this line "editor.fontFamily": "Source Code Pro",
Tyriar, thanks a lot for help.

There are no errors in the console.
In my settings.json file editor.fontSize was also set to 0 after removing this line the problem is solved. I don't know why I left it like that. Anyways thanks for your help.

Thanks, I'll reopen and do a fix for this, it shouldn't break the terminal since 0 seems to be valid for the fallback editor.fontSize.


Suite release can be auto-generated in build pipeline

The master branch pipeline automatically publishes releases based on new github tags.

The GH API call for creating a release can also create the tag won't seem to work - this is only true when using the UI (api doesn't have that).
I think doing the first flow might be the better option here and we can automate it using GH actions afaict.


Workaround WebKit canvas rendering bug when zooming PDFs

WebKit has a bug when rendering canvases that have their width defined as relative to their container, and their parent is resized. This causes a This causes a "tearing" effect when zooming in PDFs past a certain threshold, which is device-dependent but tends to be between 120% and 200%.
The DOM structure around the canvas is as follows:
div.pdfViewer [ --scale-factor: ...; ]
  > div.page [ width: round(var(--scale-factor) * ..., 1px); ]
    > div.canvasWrapper
      > canvas

Setting width: inherit on the div.canvasWrapper and on the canvas is equivalent to explicitly specifying the same width property in pixels as in div.page, thus making Safari properly redraw the canvas on resize.
See https://bugs.webkit.org/show_bug.cgi?id=267986 for more details on the WebKit bug.
Fixes #16155, fixes #16329, fixes #17459, fixes #17713
https://github.com/mozilla/pdf.js/discussions/17459 shows a good video of what the rendering bug fixed by this PR is.

Note that it's very easy to fix this for downstream consumers of pdf.js. I think adding this CSS to their page is enough:
.pdfViewer .canvasWrapper,
.pdfViewer .page canvas[zooming] {
  width: inherit !important;
}

however, I'm opening this PR because

I noticed that multiple people submitted issues about it
the fix is very minimal and does not impact other browser, given than in this case width: 100% and width: inherit should have the same behavior.

Marking as a draft because I tested it on an iPad but I'm waiting for something with an iPhone to confirm that this indeed works for them too :)

thanks so much. this seems to work fine on iPad and from my quick test, also on iPhone

As mentioned in https://github.com/mozilla/pdf.js/pull/17571#pullrequestreview-1841057316 we generally don't want to add browser-specific compatibility hacks in the main code base, even more so when the browser in question is only listed as "Mostly" supported; please note https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#legacy-build

I had a look and removing the display property:
https://github.com/mozilla/pdf.js/blob/f3b03e5c4bbb786dc05204cc803558909a083053/web/pdf_viewer.css#L158
(or setting it to inline) fixes the issue for me with Safari on mac.
I don't see any reason why it's block, as far as I can tell it comes from:
https://github.com/mozilla/pdf.js/pull/136
Since we add some svg elements in the canvas wrapper when highlighting, I checked if everything is ok and it seems to be.
So I guess we can remove it.
And tbh, I wasn't super excited by the original patch, especially because it's hard to test and because I had the feeling that even if it was small it could have led to easily introduce some regressions in the future.
@nicolo-ribaudo, could you check that it fixes the issue on ipad/ios (I don't have such devices) ? and if it's ok for you, please make an other PR.

Re https://github.com/mozilla/pdf.js/pull/17571#issuecomment-2047832265, please let's make a new release first (as mentioned elsewhere) before we consider hacking around a Safari-only bug.

Re #17571 (comment), please let's make a new release first (as mentioned elsewhere) before we consider hacking around a Safari-only bug.

Yes of course, there is no rush here.


Issue 73: die should restore the terminal state

I didn't want to add another parameter to die(), that didn't really make sense so instead I created a Terminator object that contains things that need to be cleaned up (for now, only the liner).
Turns out I had to change a bunch of other places, to pass the Terminator instead of liner.State, so in retrospect maybe adding the liner to die wasn't such a bad idea (if you don't like this implementation I can change it)
While there I also added support for command completion and the option to get help for a specific command (I have a bunch of command line tools with similar support and I can't live without it :)

I have updated the pull request with a couple of your suggestions. I am still not convinced about the third :)

The third being breaking out completion into its own PR?
Right now this commit fixes 1 bug and adds 2 features:

Fix terminal state
Add help for individual command
Add tab completion

I'd like to keep this PR focused on fixing the bug, and have separate PRs for adding those features, that way discussion can be focused on one detail at a time.

No, I am fine moving the the tab completion and all related stuff in a
different PR. I was referring to some note in the comment for tab
completion.
I am going to close this PR (as soon as I get the time) and reopen it as
two separate PRs.
thanks!
-- Raffaele
On Thu, Mar 5, 2015 at 10:51 AM, Derek Parker<EMAIL_ADDRESS>wrote:

The third being breaking out completion into its own PR?
Right now this commit fixes 1 bug and adds 2 features:

Fix terminal state
Add help for individual command
Add tab completion

I'd like to keep this PR focused on fixing the bug, and have separate PRs
for adding those features, that way discussion can be focused on one detail
at a time.
—
Reply to this email directly or view it on GitHub
https://github.com/derekparker/delve/pull/77#issuecomment-77425241.

Ah, gotcha. Sounds good.

@raff will you be able to tease this apart soon into multiple PRs? I'd really like to merge the liner fix.

Sorry, I got kind of busy.
I'll try to do today or tomorrow.
On Wed, Mar 11, 2015 at 5:26 PM, Derek Parker<EMAIL_ADDRESS>wrote:

@raff https://github.com/raff will you be able to tease this apart soon
into multiple PRs? I'd really like to merge the liner fix.
—
Reply to this email directly or view it on GitHub
https://github.com/derekparker/delve/pull/77#issuecomment-78402192.

I'd really like to merge this liner fix in, as it's quite an annoying issue. I definitely understand you're hacking on this in your free time, but I will be closing this PR tomorrow and put in a fix myself unless this gets teased out (this PR is almost 2 weeks old by now).
Even if this gets closed without merge, I'd like PRs for the other stuff if you're still interested in hacking on them. Thanks.

Check new pull request (#84)
On Sun, Mar 15, 2015 at 12:03 PM, Derek Parker<EMAIL_ADDRESS>wrote:

I'd really like to merge this liner fix in, as it's quite an annoying
issue. I definitely understand you're hacking on this in your free time,
but I will be closing this PR tomorrow and put in a fix myself unless this
gets teased out (this PR is almost 2 weeks old by now).
Even if this gets closed without merge, I'd like PRs for the other stuff
if you're still interested in hacking on them. Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/derekparker/delve/pull/77#issuecomment-81200590.


sentence_capitalization should only be applied to actual sentences

Right now, sentence_capitalization is applied to all comments, regardless whether that comment is actually a sentence, a word, or commented out code. This leads to a lot of false positives, making sentence_capitalization for me pretty much unusable outside of markdown files:

I agree that it creates more false-positives that it's worth right now. I'm of the opinion it should not be enabled by default until the implementation is more mature.
@elijah-potter thoughts?

I'm so sorry I haven't been able to get to this until now. I've been swamped. You're absolutely right that it needs work.
I've made some changes that will hopefully improve it.
Are you in a position where you frequently Harper from source? If not, it's high time we ran a release, so let me know if that needs to happen for you to test the changes.

Are you in a position where you frequently Harper from source?

I do not, so yeah a release would be be nice


next: user profile record store

Side note:
We have decided to let auth gear to import record gear code directly.
This would imply that, auth gear would access record gear database directly, migration for record gear must also be run if auth gear use record gear to store user profile.


Runtime error in ALLiveVideoChatClient

I have successfully compiled ALLiveVideoChatClient on Amdroid32/64 platforms using Delphi 10.4.2. To achieve that I have done these steps:

Updated original Delphi files by Update.bat found in "alcinoe\embarcadero\sydney\10_4_2"
Added path to Alcinoe source files to compiler's search path
Changed original dx.bat in "C:\Users\Public\Documents\Embarcadero\Studio\21.0\CatalogRepository\AndroidSDK-2525-21.0.40680.4203\build-tools\29.0.3" with dx.bat file from "alcinoe\tools\D8Proxy"
Updated path in dx.bat file, line 50, original path was "C:\SDKs\android\platforms\android-30" an I have changed it to "C:\Users\Public\Documents\Embarcadero\Studio\21.0\CatalogRepository\AndroidSDK-2525-21.0.40680.4203\platforms\android-29\android.jar" where my android.jar really is
Created "C:\Dev\Alcinoe\lib\jar" and copied content of "alcinoe\lib\jar" there

I can compile on both android platforms with these steps but I got runtime error : "First chance exception at $0000007627129C40. Exception class EJNIException with message 'java.lang.NoClassDefFoundError: Failed resolution of: Lorg/webrtc/PeerConnectionFactory$InitializationOptions;'. Process ALLiveVideoChatClient.apk (1699)"
How to solve this problem?

Hello, everything has been fixed in the latest committed version.


Address is displayed twice for an Individual and Organisation in their profile.

Open "https://rcv11.fightpandemics.xyz"
Navigate to HelpBoard
'Click on Profile icon of an Org to view the its details

Issue: You will observe  that the address for an organisation is displayed.
Refer below screenshot.

Please note this is regression, this issue does not exist in STG. i.e. staging.fightpandemics.work

This is about #1250. @cweave


Update DG for v1.1

Add Use Case, User Stories and Non-Functional Requirements to DeveloperGuide.md

Please put the correct PR name, and put the according labels and milestones next time.

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (10c15b8) compared to base (d6fe083).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Thanks for ammending boss


username is default selected instead of group name when creating group

Seem to just get a user list instead of group name stuff, when I start filtering I do get group name.

Possibly not yet deployed and need to retest

Works with new deploy


Spell check correction

small spell correction from regerator to regenerator

Thank you! Could you please amend your commit to trigger a new build? We have some tests that time out sometimes. I think we need to bump up the timeout.


Model 3.2 merge

Contains model 3.0 merged into master via a merge commit.  This preserves all commits made to model-3.0 in their original form.
Through the github UI, use the "rebase and merge" option, NOT the squash, nor the merge commit (as this PR already has the merge commit in it)
Resolves #121

huh, well, I guess I don't fully know what the GH merge options do.  I can do it manually on the command line.


nnn fails to install on darwin (MacOS) because of archivemount dependency

Describe the bug
nnn fails to install on MacOs (darwin) because archivemount is not supported on darwin platform
To Reproduce
Steps to reproduce the behavior:

nix-shell -p nnn

error: Package ‘archivemount-0.9.1’ in /nix/store/9xg5s5yk4kjw6f00ps0ync2xq56n4866-nixpkgs-21.05pre282987.294d1925af6/nixpkgs/pkgs/tools/filesystems/archivemount/default.nix:18 is not supported on ‘x86_64-darwin’, refusing to evaluate.

Notify maintainers
@jfrankenau @Br1ght0ne @sikmir @tomberek @siraben
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-darwin"`
 - host os: `Darwin 20.3.0, macOS 10.16`
 - multi-user?: `no`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.3.10`
 - channels(maciej.mazur): `"home-manager, nixpkgs-21.05pre282987.294d1925af6"`
 - nixpkgs: `/Users/maciej.mazur/.nix-defexpr/channels/nixpkgs`

Maintainer information:
# a list of nixos modules affected by the problem
module:  nixpkgs/pkgs/applications/misc/nnn

This is fixed in #118269.

❯ nix-build -A nnn
these derivations will be built:
  /nix/store/6rwg101ybsgzvhiimrps0jzhvkk41yxi-nnn-3.6.drv
these paths will be fetched (0.15 MiB download, 0.64 MiB unpacked):
  /nix/store/ph6zv6q89acfwxvbf2fm45sh2m40zxsx-source
copying path '/nix/store/ph6zv6q89acfwxvbf2fm45sh2m40zxsx-source' from 'https://cache.nixos.org'...
building '/nix/store/6rwg101ybsgzvhiimrps0jzhvkk41yxi-nnn-3.6.drv'...
unpacking sources
unpacking source archive /nix/store/ph6zv6q89acfwxvbf2fm45sh2m40zxsx-source
source root is source
patching sources
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/4k9jawhj2d4jzh6n1p5qk63rrdnzxv48-bash-4.4-p23/bin/bash PREFIX=\$\(out\)
clang  -std=c11 -Wall -Wextra -Wshadow -O3 -D_DARWIN_C_SOURCE -I/nix/store/f7kn2avlfsn992klwywb2yjf9w2bsgzf-ncurses-6.2-dev/include  -o nnn src/nnn.c -lreadline -Wl,-search_paths_first -lncursesw
installing
install flags: SHELL=/nix/store/4k9jawhj2d4jzh6n1p5qk63rrdnzxv48-bash-4.4-p23/bin/bash PREFIX=\$\(out\) install
install -m 0755 -d /nix/store/v5zv928jr54yfvsxqvkw1hd9lrkq89qg-nnn-3.6/bin
install -m 0755 nnn /nix/store/v5zv928jr54yfvsxqvkw1hd9lrkq89qg-nnn-3.6/bin
install -m 0755 -d /nix/store/v5zv928jr54yfvsxqvkw1hd9lrkq89qg-nnn-3.6/share/man/man1
install -m 0644 nnn.1 /nix/store/v5zv928jr54yfvsxqvkw1hd9lrkq89qg-nnn-3.6/share/man/man1
post-installation fixup
gzipping man pages under /nix/store/v5zv928jr54yfvsxqvkw1hd9lrkq89qg-nnn-3.6/share/man/
strip is /nix/store/z8d39gw4q90i97jlsilbad33siwh4yxd-cctools-binutils-darwin-949.0.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/v5zv928jr54yfvsxqvkw1hd9lrkq89qg-nnn-3.6/bin
patching script interpreter paths in /nix/store/v5zv928jr54yfvsxqvkw1hd9lrkq89qg-nnn-3.6
/nix/store/v5zv928jr54yfvsxqvkw1hd9lrkq89qg-nnn-3.6

Actually, that wasn't enough. I overlooked that archivemount was only a part of recently introduced dependencies. For the latest nnn to build on Darwin, the vlock dependency would have to be disabled.
Moreover, the dependencies that were added are command line utilities that nnn can optionally use if installed. As these are command line utilities that users would typically choose to explicitly install if needed, I think it's enough to let nnn pick up the available commands from PATH at runtime rather than having the nnn package depend on them. Or maybe introduce an option (e.g., withExtraTools) to include those dependencies.


ncem - python 3.9

check python 3.9 compatibilities of ncem and adjust dependencies

Hi,
NCEM recently don't support python3.10, do you plan to update it ?


Consider more standard behavior for logging directory

Given experience with https://pytorch.org/docs/stable/tensorboard.html  and see https://pytorch.org/docs/master/_modules/torch/utils/tensorboard/writer.html#SummaryWriter
I suggest following the pytorch/tensorflow approach above which I think is
function TensorBoardCallback(comment::String = "", log_dir::String = nothing, args...; kwargs...)
    if isnothing(log_dir)
        directory =  "runs/$(Dates.format(now(), dateformat"ud_H-M-S"))-$(gethostname())$(comment)"
    else
        directory = log_dir
    end

    lg = TBLogger(directory, min_level=Logging.Info; step_increment=0)

    return TensorBoardCallback(lg, args...; kwargs...)
end

which I believe mimics the constructor behavior for teh pytorch summarywriter:
        if not log_dir:
            import socket
            from datetime import datetime
            current_time = datetime.now().strftime('%b%d_%H-%M-%S')
            log_dir = os.path.join(
                'runs', current_time + '_' + socket.gethostname() + comment)

One benefit of this is that all tensorboard docs will use the runs as the basic directory to look inside, so this would pick them all up and make it easy to distinguish the experiments.

This sounds like a great idea! Though I'll go with Dates.format(now(), dateformat"Y-m-d_H-M-S").


control room enhancement: screen control

export interface ScreenControl {
  filler?: boolean;
  heading?: string;
  next_schedule?: ScreenNextSchedule;
  footer?: string;
}

UpcomingTopic

Filler mode
Upcoming topic mode
Basic announcement mode

Heading
Optional: next schedule (indep to topics)
Optional: footer

https://github.com/ruby-no-kai/takeout-app/pull/30


Can not find the include file's fuction define in vscode jupyter

The fuction can run,but report "XXX" is not define

d

Thanks for the report. The main.ipynb is in the project root. In order to import func, you will need to treat inc as a module. So you would you please try from inc.func import *
Please reopen this issue if this continues to be a problem.
thanks


Talktorial 10 - Input Cell #10

Should be,
pdb_ids = list(set(found_pbd_ids + found_pbd_ids2))
and not,
pdb_ids = list(set(found_pbd_ids + found_pbd_ids))

Addressed in #44


Vision with llava-1.6-7B is unusable via CLI

What is the issue?
The image recognition is very poor. It can't describe the picture properly and it also can't extract text. It seems to process a very downscaled image because it complains about the text being too small and it makes assumptions about image elements that seem to be likely but aren't true. It hallucinates a lot and makes things up.
Basically this model is very capable. But with Ollama it is unusable and I tried different tags. llava:7b-v1.6-mistral-q5_K_M and llava:7b from the ollama library. Additionally I downloded a Q5_K_M quant of the model from HF and imported it into my local ollama with a self-created modelfile. The problem was always the same.
I used this image, a screenshot from a PDF manual:

Prompt:

extract the text underneath the image: /Users/olaf/Desktop/Screenshot\ 2024-03-22\ at\ 18.37.08.png
Added image '/Users/olaf/Desktop/Screenshot 2024-03-22 at 18.37.08.png'

Ollama response:

The image shows a digital advertisement or informational graphic, but it is too small and low resolution to provide a clear transcription of the text. The visible content includes a large purple logo in the upper right corner with the name "SWITCH" below it, and several smaller graphics or logos aligned vertically along the top and bottom edges of the image, which may be related to the product or service advertised on this webpage.
Please note that due to the low resolution and size of the text in the image, it's difficult to provide an exact transcription of what is written.

It did not even try to extract the text, instead described the image but the description is complete nonsense.
Converting the image to JPG improved the recognition but the model still made things up and the text extraction is just partially correct:

The text underneath the image reads:
"Click on any package result to see above. Otherwise the top row will not be visible. A popup will appear and display the packages in the next step.
The first group of buttons is for the product options. The second set of buttons are for different shipping options. The third set ofbuttons allows you to change your email if needed.
Please note that these buttons might not be active on this page but they will be when you click through from a live site."

Using a python script as described in https://ollama.com/blog/vision-models does not improve anything.
Log output after script execution with the png file:
time=2024-03-22T20:03:14.404+01:00 level=INFO source=dyn_ext_server.go:172 msg="loaded 1 images"
{"function":"launch_slot_with_data","level":"INFO","line":833,"msg":"slot is processing task","slot_id":0,"task_id":637,"tid":"0x172f5f000","timestamp":1711134194}
{"function":"update_slots","level":"INFO","line":1852,"msg":"kv cache rm [p0, end)","p0":0,"slot_id":0,"task_id":637,"tid":"0x172f5f000","timestamp":1711134194}
encode_image_with_clip: image embedding created: 576 tokens

encode_image_with_clip: image encoded in   658.77 ms by CLIP (    1.14 ms per image patch)
{"function":"print_timings","level":"INFO","line":264,"msg":"prompt eval time     =    6374.43 ms /     1 tokens ( 6374.43 ms per token,     0.16 tokens per second)","n_prompt_tokens_processed":1,"n_tokens_second":0.15687684555803996,"slot_id":0,"t_prompt_processing":6374.427,"t_token":6374.427,"task_id":637,"tid":"0x172f5f000","timestamp":1711134212}
{"function":"print_timings","level":"INFO","line":278,"msg":"generation eval time =   11258.49 ms /   321 runs   (   35.07 ms per token,    28.51 tokens per second)","n_decoded":321,"n_tokens_second":28.511811350934032,"slot_id":0,"t_token":35.073183800623056,"t_token_generation":11258.492,"task_id":637,"tid":"0x172f5f000","timestamp":1711134212}
{"function":"print_timings","level":"INFO","line":287,"msg":"          total time =   17632.92 ms","slot_id":0,"t_prompt_processing":6374.427,"t_token_generation":11258.492,"t_total":17632.919,"task_id":637,"tid":"0x172f5f000","timestamp":1711134212}
{"function":"update_slots","level":"INFO","line":1660,"msg":"slot released","n_cache_tokens":322,"n_ctx":2048,"n_past":907,"n_system_tokens":0,"slot_id":0,"task_id":637,"tid":"0x172f5f000","timestamp":1711134212,"truncated":false}
[GIN] 2024/03/22 - 20:03:32 | 200 | 17.686484875s |       <IP_ADDRESS> | POST     "/api/chat"

What did you expect to see?
I compared it with the results from this HF space running the same model in FP16 but most probably with pytorch and transformers: https://huggingface.co/spaces/merve/llava-next
prompt:

extract the text underneath the image

response:

The text underneath the image is as follows:
"Click on any package results in additional information popping up, as seen above. Otherwise, the top row of text buttons represents view filters for seeing and sorting packs differently. The first group of buttons offers to filter packages by their source, either by showing only those by Bitwig, only those by Artists, or only those from Partners (like sound design companies, etc.). Or simply turn off this filter to see all packages

This is a good answer. It is exactly the text beneath the image in the image.
Steps to reproduce

ollama run llava:7b
Use the uploaded picture with the prompt from above

Are there any recent changes that introduced the issue?
No response
OS
macOS
Architecture
arm64
Platform
No response
Ollama version
0.1.29
GPU
Apple
GPU info
M1 Pro
CPU
Apple
Other software
No response

no supprise  , llava is aways poor in  image recognition, is not ollama issue, maybe have to ask llava team.

I disagree. The model performs very well in that regard, better than any other model <= 7B. Read my section about my expectations. The model served in a HF spaces is doing near perfect OCR and description of the image.

Hi @olafgeibig
There are 3 Llava Models, the biggest is the best. I crop the image you provided to keep only the part with the text in Black and White and asked Llava : can you give me the text written on this image? /Users/igor/Documents/readme
... .png
The result is:
The image contains text that appears to be instructions for filtering
packages or content, possibly on a website or software platform. Here is
the transcribed text:
"Click on any package result is additional information popping up as seen
above otherwise the top row of text buttons represents view filters for
seeing and sorting packs differently. The first group of buttons offers to
filter packages by their source such as Only By Blizz, only by Artists, or
simply turn off this page. The second group of buttons offers to filter
package by their status installed/uninstalled meaning if they are
available on your computer. Finally, the third group offers sorting
options one option is to sort packages alphabetically with the Name 1
button Or choose to sort packages based on their release date with the
Recommended button."
When I use the same picture and same prompt but when I use the Llava13b model, I got this answer:
The text in the image appears to be a bit blurry and stretched due to the
perspective, making it difficult to read accurately. However, from what is
visible, it seems to be a description or instructions related to sorting
or filtering packages on a website or application. If you provide a
clearer image or more details about the text, I could try to transcribe it
for you.
I used a old llava 1.3 from 3 month ago (a 7b model and it was working), but the recognition was not as good in 1.3 than in 1.6 so the result was :
The first group of buttons offers filters for package results, additional
information popping up as seen above any row of text buttons representing
various views. Filters are available from the source by showing on either
BittyWig (artists), a like sound design company, or simply by using
Partner's like sound design. They have also included simple options for
sorting packages alphabetically with their name button and choosing to
sort by date when the release is announced, which will be displayed on
this page.

Have the same issue. The Huggingface deployments of 1.6 are able to read text out of most of the document images I've given it. When I give the same images to ollama is it unable to read them. I'm on an intel mac though.

@marksalpeter Which version of the model do you use? It seems like the llava:34b-v1.6 works better. I'm trying to install this version from Hugging Face: https://huggingface.co/llava-hf/llava-v1.6-34b-hf but have to spend some time doing that.

My issue is with the 7B model. I can't run a 34B model.

@olafgeibig On hugging face, did you test with the 7B model? The 34B model works fine with Ollama, so it could be an issue with the 7B model itself.

Yep, the HF space where they demo the new transformers feature to use Llava models is using the 7B model. See yourself: https://huggingface.co/spaces/merve/llava-next/blob/main/app.py

bump

Can confirm,

And the hf spaces says that the llava 1.6 mistral 7b variant is being used.

Try LLaVA NeXT in this demo (more specifically, the Mistral-7B variant).

I loaded lava 7b with version 0.1.32 and I get a good result with this image:
ollama run llava:7b

can you give me the full text of this image ? /Users/igor/Documents/readme.png'

Added image '/Users/igor/Documents/readme.png'
Sure, here's the full text from the image:
click on any package result is additonal information popping up as seen
above otherwise the top row of buttons are different filters for seeing
all products by sorting them by price low to high or showing only items
that have been installed either by me or someone else. The first group of
buttons offers filter packages by their source. These are not shown but
they are there if you need to see them.

Below this is the second group of buttons which offer different types of
packages. You can use a keyboard shortcut to navigate through these
buttons. However, the package installer is disabled for now. There may be
some hidden options that you cannot find. The package installer does not
work without being installed but are available if you simply turn them on.
This is an important message to ensure that users are aware of all
available packages in order to sort their preferences.

The first set of buttons allows a user to see the name and description of
each package as well as any buttons that might be associated with it. The
second row of buttons is disabled for now but simply turning them on will
allow you to see all packages that are not installed or simply turn off
this option if you wish to disable it.

The last set of buttons allows you to choose the third group of options
which are not fully visible in this image and do not have any associated
keyboard shortcuts. These options are also not fully visible in this
image. It is important to note that all packages can be sorted into
different categories based on their function or the number of packages
they belong to. The final set of buttons allows you to choose your
preferences. This is an important message to ensure that users are aware
of all available packages in order to sort their preferences.

The result is not exaclty the same as the image, but I think that we can close this Issue if @olafgeibig agrees.

Also seeing the same issue where llava from ollama performs significantly worse than the hosted version.

I loaded lava 7b with version 0.1.32 and I get a good result with this image:

Trying the exact same thing but the result seems very bad with latest ollama.
>>> can you give me the full text of this image ? /home/xxx/Desktop/readme.png
Added image '/home/xxx/Desktop/readme.png'
 The image contains a humorous meme with a visual pun. Here's the text in a semi-transparent format:

"DON'T PAY ANY ATTENTION TO THE DISTINCT LACK OF LOGICAL SEQUENCES OR THE CLEAR LACK OF COHERENCE BECAUSE THIS IS A MEME"

Interestingly, restarting ollama server makes the first image query work.
For anything other than the first image query uploaded (even with a fresh client session), the model will just output nonsense or complain about it being too blurry.

Looking at the release note of 0.1.34 I think this is already addressed:

Fixed issues with LLaVa models where they would respond incorrectly after the first request

Seems to fix for me on llava:34b.

Hi folks 0.1.34 should fix these issues. Sorry this happened. Thanks for creating an issue 😊

I have the same problem on 1.43.  Using  llava:13b-v1.6

I don't know what I did to mess up the format.  I used the <> button which inserted a couple of ticks and I pasted the text into the texts.

Guys any update with this for llava 8b?


Restrict log scale domain min value to 1 to prevent NaN.

Log scale may be very convenient. However, we happen to have some values at 0.This should not be a problem since this is a log scale (ie just a way to display).
However, if we have a 0 value, the complete series is erased, replaced by "NaN". The trivial workaround is to put "+1" on the query (urk).
This commit reduces the scale domain to [1, max] and prevents this bug. The series is now considered as "no value" only on dots where the value is 0 (interrupted curve) which is better than nothing.

Hey,
PromDash is officially deprecated, and has been for quite a while. We recommend using grafana, as it has native prometheus support, and a fuller feature set.

@stuartnelson3 wow, didn't see that, as Promdash works pretty well for us. We should look for a migration, then.
However, merging this should not hurt anybody ;)

Yeah, PromDash is pretty awesome.
What's the complete range of the data you're using that causes values to be NaN? I remember when this was originally being implemented that I bounded values to 0 so that they would render properly, so I suppose I'm curious why for your team this isn't working.
Relevant code: https://github.com/prometheus/promdash/blob/master/app/assets/javascripts/angular/directives/graph_chart.js#L109-L123

The answer is easy: we have some 0 values, and log(0)=NaN ;)
Another correct fix should be then to amend your code and replace the 0 minimum to a 1 (if between 0 and 1, the log would be negative). However, for what I understand, the D3js domain() function already provides this.

Hm, good point.
I suppose my only concern is for people (if there even are any) that are using a log scale but looking at a data range that exists between 0 and 1. Seems pretty unlikely, though.
I'll go ahead and merge this. We really do recommend migrating to grafana as soon as possible, as it is a superior solution.

Apparently, actually, I have had my merge permissions revoked -.-


Variable substitution in the config.yml

We are using GitLab CI
We are unable to have variables in config.yml as they are not getting substitutied during the run time, and then we end up having actual values in config.yml.
We do not have an encrypted token, which means directly putting it in config.yml is a risk. Although, we have the token as an environment variable and therefore we wish to make use of variables inside config.yml
.gitlab-ci.yml
image:
  name: 'ghcr.io/gitlabform/gitlabform:latest'
  pull_policy: if-not-present

stages:
  - "Execute"

apply-automated-gitlab-configuration:
  stage: 'Execute'
  tags:
    - default
  script:
    - gitlabform ALL

config.yml
# This key is required in configs for GitLabForm version
config_version: 3

# GitLab API access config
gitlab:
  url: ${CI_SERVER_URL}
  token: ${CI_JOB_TOKEN}
  ssl_verify: true
  timeout: 10

# Configuration to apply to GitLab projects, groups and subgroups
projects_and_groups:
  ....
  ....
  ....
  ....

What are we doing wrong?

Ok, yes sure. Thanks for the input.
Will give it a try.

config.yml
# This key is required in configs for GitLabForm version
config_version: 3

# GitLab API access config
gitlab:
  url: "{{GITLAB_URL}}"
  token: "{{GITLAB_TOKEN}}"
  ssl_verify: true
  timeout: 10

# Configuration to apply to GitLab projects, groups and subgroups
projects_and_groups:
  ....
  ....
  ....
  ....

Doing this also does not help, and I get
Request url='<GITLAB_URL>/api/v4/version?per_page=100, method=GET, failed - expected code(s) [200], got code 401 & body: '{"message":"401 Unauthorized"}'
However, if I hardcode the same values then it works 🤔
Is this "{{GITLAB_TOKEN}}" the correct way to reference it?

Using the following config.yml fixed it
# This key is required in configs for GitLabForm version
config_version: 3

# Configuration to apply to GitLab projects, groups and subgroups
projects_and_groups:
  ....
  ....
  ....
  ....

Changes:

Setting GITLAB_URL & GITLAB_TOKEN as environment variables
Removing the gitlab top-level key from config.yml

#526


Fix: Properly select last version when Alpha/Beta/Dev versions are present

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

resolves #21215
Microsoft Reviewers: Open in CodeFlow

cc @OfficialEsco and @denelon

ooop, if i'm reading this correctly it will ignore any folders starting with a to z correct?
If that is so there is another issue, some annoying softwares contains atleast a v<IP_ADDRESS>, IIRC there are some rare cases where its a different letter, but very rare.
Scrolled trough winget search and spotted these:
Name                             Id                                 Version
------------------------------------------------------------------------------------------
Mazerator-Old                    WaterbugStudios.MazeratorOld       Nightly 20200420
WebDL                            Timber1900.WebDL                   v9.2
FileZilla Server                 TimKosse.FileZillaServer           beta 0.9.60
TeamViewerQS                     TeamViewer.TeamViewerQS            Latest (this should have been removed and we don't do latest anymore)
JetBrains MPS                    JetBrains.MPS                      MPS-211.7442.1291
MakeMKV                          GuinpinSoft.MakeMKV                v1.16.4
NoteTab Light                    FookesHolding.NoteTabLight         NoteTab Light 7.2
DJI Assistant 2 For Mavic        DJI.DJIAssistant2ForMavic          V<IP_ADDRESS>
DJI Assistant 2 For Phantom      DJI.DJIAssistant2ForPhantom        V<IP_ADDRESS>
DJI Assistant 2                  DJI.DJIAssistant2                  V1.2.5
DJI Assistant 2 (Consumer Drone… DJI.DJIAssistant2ConsumerSeries    V<IP_ADDRESS>
DJI Assistant 2 (Enterprise Ser… DJI.DJIAssistant2EnterpriseSeries  V<IP_ADDRESS>
DJI Assistant 2 (DJI FPV series) DJI.DJIAssistant2FPV               V<IP_ADDRESS>
DJI Assistant 2 For Autopilot    DJI.DJIAssistant2ForAutopilot      V<IP_ADDRESS>
DJI Assistant 2 For Battery Sta… DJI.DJIAssistant2ForBatteryStation V<IP_ADDRESS>
DJI Assistant 2 For MG           DJI.DJIAssistant2ForMG             V<IP_ADDRESS>
CHIRP                            CHIRP.CHIRP                        daily-20210706
AnyDesk                          AnyDeskSoftwareGmbH.AnyDesk        ad 6.3.2 (correct version)
AHM System Manager               Allen&Heath.AHMSystemManager       V1.03 - Rev. 62957
Avantis Director                 Allen&Heath.AvantisDirector        V1.11 - Rev. 64180
Custom Control Editor            Allen&Heath.CustomControlEditor    V1.1.1 - Rev. 58551
SQ MixPad                        Allen&Heath.SQMixPad               V1.5.0 - Rev. 56519
dLive Director                   Allen&Heath.dLiveDirector          V1.88 - Rev. 64094
AIMP                             AIMP.AIMP                          v4.70.2251, 23.05.2021

@OfficialEsco I'll wait to review/approve/merge until after you validate and approve.

ooop, if i'm reading this correctly it will ignore any folders starting with a to z correct?
If that is so there is another issue, some annoying softwares contains atleast a v<IP_ADDRESS>, IIRC there are some rare cases where its a different letter, but very rare.
Scrolled trough winget search and spotted these:
Name                             Id                                 Version
------------------------------------------------------------------------------------------
Mazerator-Old                    WaterbugStudios.MazeratorOld       Nightly 20200420
WebDL                            Timber1900.WebDL                   v9.2
FileZilla Server                 TimKosse.FileZillaServer           beta 0.9.60
TeamViewerQS                     TeamViewer.TeamViewerQS            Latest (this should have been removed and we don't do latest anymore)
JetBrains MPS                    JetBrains.MPS                      MPS-211.7442.1291
MakeMKV                          GuinpinSoft.MakeMKV                v1.16.4
NoteTab Light                    FookesHolding.NoteTabLight         NoteTab Light 7.2
DJI Assistant 2 For Mavic        DJI.DJIAssistant2ForMavic          V<IP_ADDRESS>
DJI Assistant 2 For Phantom      DJI.DJIAssistant2ForPhantom        V<IP_ADDRESS>
DJI Assistant 2                  DJI.DJIAssistant2                  V1.2.5
DJI Assistant 2 (Consumer Drone… DJI.DJIAssistant2ConsumerSeries    V<IP_ADDRESS>
DJI Assistant 2 (Enterprise Ser… DJI.DJIAssistant2EnterpriseSeries  V<IP_ADDRESS>
DJI Assistant 2 (DJI FPV series) DJI.DJIAssistant2FPV               V<IP_ADDRESS>
DJI Assistant 2 For Autopilot    DJI.DJIAssistant2ForAutopilot      V<IP_ADDRESS>
DJI Assistant 2 For Battery Sta… DJI.DJIAssistant2ForBatteryStation V<IP_ADDRESS>
DJI Assistant 2 For MG           DJI.DJIAssistant2ForMG             V<IP_ADDRESS>
CHIRP                            CHIRP.CHIRP                        daily-20210706
AnyDesk                          AnyDeskSoftwareGmbH.AnyDesk        ad 6.3.2 (correct version)
AHM System Manager               Allen&Heath.AHMSystemManager       V1.03 - Rev. 62957
Avantis Director                 Allen&Heath.AvantisDirector        V1.11 - Rev. 64180
Custom Control Editor            Allen&Heath.CustomControlEditor    V1.1.1 - Rev. 58551
SQ MixPad                        Allen&Heath.SQMixPad               V1.5.0 - Rev. 56519
dLive Director                   Allen&Heath.dLiveDirector          V1.88 - Rev. 64094
AIMP                             AIMP.AIMP                          v4.70.2251, 23.05.2021

Aahhh. That does complicate things a bit Let me look a bit further

@Trenly we had set a precedent initially with Visual Studio manifests. The "nesting" can be tricky to resolve. We do a recursive crawl from a manifest file to determine the "PackageIdentifier".
Visual Studio Load Test Controller 2019              Microsoft.VisualStudio.2019.TestController       16.10.31424.327
Visual Studio Test Agent 2019                        Microsoft.VisualStudio.2019.TestAgent            16.10.31424.327
Visual Studio Team Explorer 2019                     Microsoft.VisualStudio.2019.TeamExplorer         16.10.31424.327
Performance Tools for Visual Studio 2019             Microsoft.VisualStudio.2019.StandaloneProfiler   16.0.31321.278
Remote Tools for Visual Studio 2019                  Microsoft.VisualStudio.2019.RemoteTools          16.0.31321.278
Visual Studio Professional 2019 Preview              Microsoft.VisualStudio.2019.Professional-Preview 16.11.31320.298
Visual Studio Professional 2019                      Microsoft.VisualStudio.2019.Professional         16.10.31424.327
Visual Studio Enterprise 2019 Preview                Microsoft.VisualStudio.2019.Enterprise-Preview   16.11.31320.298
Visual Studio Enterprise 2019                        Microsoft.VisualStudio.2019.Enterprise           16.10.31424.327
Visual Studio Community 2019 Preview                 Microsoft.VisualStudio.2019.Community-Preview    16.11.31320.298
Visual Studio Community 2019                         Microsoft.VisualStudio.2019.Community            16.10.31424.327
Visual Studio Build Tools 2019                       Microsoft.VisualStudio.2019.BuildTools           16.10.31424.327
Visual Studio Enterprise 2022 Preview                Microsoft.VisualStudio.2022.Enterprise-Preview   17.0.31423.177
Visual Studio Community 2022 Preview                 Microsoft.VisualStudio.2022.Community-Preview    17.0.31423.177
Visual Studio Professional 2022 Preview              Microsoft.VisualStudio.2022.Professional-Preview 17.0.31423.177

Microsoft Visual Studio and .NET Framework Log Collection Tool Microsoft.VisualStudioCollect       16.0.28407.115
Microsoft Visual Studio Code Insiders                          Microsoft.VisualStudioCode.Insiders 1.59.0
Microsoft Visual Studio Code                                   Microsoft.VisualStudioCode          1.58.2

Aahhh. That does complicate things a bit Let me look a bit further

Exactly this is where my brain is getting fried! 😁

Would it be safe to assume that a version folder should only have manifests under it, and a Beta folder should only have version folders under it?

Yep the folder structure is always
| Google
|| Chrome
||| 91.0.4472.124
||| Beta
|||| 92.0.4515.81
||| Canary
|||| 93.0.4563.0
||| Dev
|||| 93.0.4557.4

Or in another rare case /manifests/m/Microsoft/VisualStudio/2022/Community-Preview/17.0.31423.177/Microsoft.VisualStudio.2022.Community-Preview.installer.yaml

@OfficialEsco let me know when you approve and I'll merge if there aren't any more changes.

Leaving this here for anyone interested in the logic -
These changes should look at the App Folder, and find all files that are 0 or 1 levels deep. Because this is the app folder, we know that there will be no files at 0 depth, only Version/Beta directories. If a file is found at a depth of 1, then it means that it belongs to a version of that app. All Beta apps will only have directories at a depth of 1, and will therefore not be returned when we get the children recursively.
From here we extract the full paths of the files that were returned, then split them twice. Once to drop the file name and get the parent directory, and the second time to drop everything preceding the directory name (which leave us just the versions). With this list of versions, we can sort and select the last one as appropriate.

If(when) @Trenly can confirm it works on Google Chrome then you can merge it, as of now i'm stuck with
PS C:\Users\Esco\GitHub\winget-pkgs> .\Tools\YamlCreate.ps1
At C:\Users\Esco\GitHub\winget-pkgs\Tools\YamlCreate.ps1:945 char:24
+         git commit -m "$CommitType: `$PackageIdentifier` version $Pac ...
+                        ~~~~~~~~~~~~
Variable reference is not valid. ':' was not followed by a valid variable name character. Consider using ${} to
delimit the name.
    + CategoryInfo          : ParserError: (:) [], ParseException
    + FullyQualifiedErrorId : InvalidVariableReferenceWithDrive

I tested with Chrome, VisualStudio, and a few randomly selected from your screenshot


App crashes

The App crashes when I am trying to run it using my own graph file and labels file.
I tweaked the code in mainActivity.java accordingly.
Is the app hardcoded to run using only your graph and label files?

@swetshaw yes, you will have to change the input and output in the class TensorFlowImageClassifier.

I am getting the following error :

I am getting the following error when I downloaded and opened your app :
Gradle sync failed: Cause: error in opening zip file
Consult IDE log for more details (Help | Show Log)
Is this is a problem with gradle or is it because I did not follow the steps on your blog post, and directly
downloaded this ?


iOS9 scanner locking up

In IOS9 the scanner seems to open and instantly freeze.  I can tap the camera icon to bring up the front facing camera and that works just fine without any freezing.  I can also click cancel and have that close the scanner window.  However as stated the camera locks up at a black screen (before camera opens) or right after the camera screen shows the image.

On ios 8.4 was the same

Version 3.0 works

I am using build.phonegap.com aside from adding this to my config.xml file I haven't had to do any other installation.  The line in the config file is solely this.
<gap:plugin name="com.phonegap.plugins.barcodescanner" />
How would I tell the system I want to use v3.0?

I tried the following and it is still freezing on my iPhone 4s
<gap:plugin name="net.roughshod.plugins.barcodescanner" version="3.0.0" />

I also have same problem with version of plugin 4.0.1
Same time application have crash after freezing.

I have Cordova IOS 3.9.1, XCode 7.0
By my opinion problem appears after changing  XCode 6 to  XCode 7

Version 3 also have freezing
I use "ionic plugin add<EMAIL_ADDRESS>

Anyone going to be able to look at this sometime soon?  This is a detrimental feature for the phonegap build we are making.  Without it we may as well not have the need for phonegap :)
There are several people experiencing the issue and I would prefer to use this plugin than seeking around for another scanning plugin (if any even exist).

@jcrawford I'm not sure what you mean. Did you just put a script tag in your index.html to include barcodescanner.js? I didn't see anything in the docs about doing that.

@graphicgeek yes all I did was add the script tag right after the one for phonegap.js and all started working perfect.  I recall seeing this in one of their demo examples and nothing about it in the docs so I tried it and it solved the issue.

@graphicgeek this is the example where I saw them using the barcodescanner.js inclusion which gave me the idea to try it and again it solved my lock-up issues.
https://github.com/wildabeast/BarcodeDemo/blob/master/index.html

@jcrawford Thanks, but that fix didn't work for me unfortunately. But I'm using Cordova rather than phonegap build. That example is also for an older version of the plugin.
I've also tried older versions (3.0.0 and 2.2.0) but no luck. Every time I launch the scanner in (iOS 9) it just freezes.

I am using this specific plugin with that inclusion for the scanner and it works fine for me.
<gap:plugin name="net.roughshod.plugins.barcodescanner" version="3.0.0" />

I'm using Cordova, not Phonegap Build.
I think I've narrowed this to a permissions issue with my app. For some reason, the app isn't asking for permission to use the camera.
I installed a fresh "hello world" app, that did nothing but launch the scanner. When it launches it asks for permission to use the camera, and it works fine. So time to comb through my code and figure out why my  app isn't asking for permission.

I'm having the same issue. Running IOS 9 and the newest version of the plugin, on Cordova 5.3.1

By my opinion this problem appears after switching to XCode 7.0.
I'm had trying to run build of program on IOS 8 and also have similar problem.
But before switching from XCode6 to XCode7 all works fine!

unfortunately, one of the other plugins gives me a linker error when I try to build in xcode 7, that I spent days trying to diagnose before switching back to xcode 6.4.

I was finding that the camera on iOS 8 occasionally froze when the barcode scanner was called - I was using the latest PhoneGap Barcodescanner (4.0.2).
However, upgrading the iOS device to iOS 9 solved this issue.
Have you tried upgrading your 3.0.0 PhoneGap Barcodescanner to the latest version (4.0.2)?

@olimortimer Yes I had version 4.0.2 problem not solved
But my colleagues it seems resolved this issue In the near future I will tell about decision

We switch to another plugin, works perfectly on iOS9 (not tested with Android or Windows).
Also launches faster than the phonegap one.
https://github.com/tjwoon/csZBar

Same problem here. Camera goes black and I see the following in the Xcode console: "...whose view is not in the window hierarchy!" I'm using iOS 9.2 and Xcode 7.2. However, whenever I launch the scanner from a button WITHIN the  tags, it works fine. Is this useful insight? Any thoughts?


Add agiles and sprints

@romanzdk thank you for the PR! Could you please also add test data for those endpoints? Thank you!

I added tests for new endpoints and updated the code a bit. @romanzdk I saw that you tried to reference Agile and Sprint models to each other. It's possible to do with so called postponed annotations. But this leads to circular references (Sprint.agile -> Agile, Agile.sprints or Agile.current_sprint -> Sprint). So I introduced two additional models that contains basic information about Agile boards and Sprints. Could you please test changes to make sure that you can fetch all data you need?

@romanzdk you made about 10 force-pushes into this PR - it's therefore impossible to see the changes that you were making and why. Can you tell what did you want to achieve and whether the current solution works for you?

I am sorry, I had some issue with formatting. Nevertheless, I just added the missing EOL and renamed Info classes to Base.

/rebase

@felix11h @marns93 this is weird - @mergealot did something but it's not reflected in the PR o_O

@felix11h @marns93 this is weird - @mergealot did something but it's not reflected in the PR o_O

Ah, I know - he pushed into romanzdk-master in this repository for some reason, instead of the original repository.


Conversation options (nicknames, add person, change color, etc.) and stickers shop not working after app has been running for a while.

The options seem to be working, however the menus are either not showing or showing in very low opacity (ses screen recording in link below). I have been experiencing the problem several times and quitting and reopening the app seems to be the only fix it so far.
I haven't been able to figure out when/what makes the problem occurs, at some point when the app has been open for some time (in most cases a day or two, with the computer going to sleep in between (might be worth investigation if going to sleep this might be the culprit))..
Reload app from server doesn't solve the issue.
Quit+reopening the app solves it, until it happens again.
Video of bug: https://dl.dropboxusercontent.com/u/478737/Messengerapp.mov
Appversion: 0.1.7
Running: 10.10.3 (15D21)
On: MacBook Pro (Retina, 15-inch, Mid 2015)

The problem also seems to effect when you want to delete a message (rightclick > choose delete > normally a confirmation-popup appears, but now nothing appears and you can't interact with anything - if you pixelhunt a bit you can fint two areas to press: the cancel and delete button on the confirmation-popup, but it isn't visible, you can only detect it by looking for your arrowcursor turning into the actioncursor (hand)).

Having this problem too. I went to edit a nickname but couldn't click on the field (weird) so I closed it, now I can't open it.


List azure-specific messaging.operation.names and clarity list of applicable attributes

Fixes #926
Changes
Also addresses the Azure-messaging specific portion on #869
Merge requirement checklist

[x] CONTRIBUTING.md guidelines followed.
[ ] Change log entry added, according to the guidelines in When to add a changelog entry.

If your PR does not need a change log, start the PR title with [chore]

schema-next.yaml updated with changes to existing conventions.

Blocked on #947


Metadata and data import for d20200808_MINIAT

#236

Codecov Report

Merging #237 into master will decrease coverage by 1.62%.
The diff coverage is 43.47%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   97.95%   96.32%   -1.63%
==========================================
  Files           9        9
  Lines         783      790       +7
==========================================
- Hits          767      761       -6
- Misses         16       29      +13

Impacted Files
Coverage Δ

R/user.R
76.78% <18.75%> (-23.22%)
:arrow_down:

R/parser.R
100.00% <100.00%> (ø)

R/utils.R
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 522a8f8...9a83e5a. Read the comment docs.


Adapted plugin to recaptcha V2. api.js is now automatically loaded

Hi, I adapted the plugin to support the V2 version of recaptcha.
Main changes regarding previous recaptcha api are:

publicKey (now called siteKey) must be in the javascript options
Recaptcha object was renamed to grecaptcha
recaptcha functions were renamed
There is no challenge, the service is able to do everything only with the client response

I made another feature which is making the "api.js" automatic. When the widget starts, it checks if the grecaptcha object is in the javascript context, if not, it starts loading the api.js and will only initialize the widget after recaptcha is present.
Another problem is the fact that recaptcha4j has not been updated in years. The server validation was used without the recaptcha4j API. Altough, they have a simple http facade which I used, so the dependency was not totally removed, but I suggest removing it in the future.

Thanks!
Merged to branch v2.
A few things should be done before i can release it.

upgrade ReCaptchaOptions to v2. (most of the options are invalid now)
get rid of Recaptcha4j (http post can be done with standard URLConnection)
drop customHtml. (It's not supported in v2, or at least not documented...)

Any help will be very welcome.


Extra (leading) 0's in exponent causes dropped speech

Using MathJax 3.1.2, the following MathML that has a doubled '0' produces "x to the th power". If there is a single '0' (<mn>0</mn>), speech is good ("x to the  0 power").
<math>
  <msup>
    <mi>x</mi>
    <mn>00</mn>
  </msup>
</math>

SRE wrongly classifies 00 as an integer, which it is of course not. Interestingly enough 01 leads to "x to the first power"), which is also wrong.

I'll bite... why is '00', or for that matter, any sequence of two or more
digits not an integer?
On Thu, Feb 11, 2021 at 6:00 AM Volker Sorge<EMAIL_ADDRESS>wrote:

SRE wrongly classifies 00 as an integer, which it is of course not.
Interestingly enough 01 leads to "x to the first power"), which is also
wrong.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zorkow/speech-rule-engine/issues/455#issuecomment-777478299,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALZM3AEAFJIIKQCKIFPYXLS6PPG3ANCNFSM4XJQUQPA
.

Sorry, I was imprecise: What I really meant was "base 10 integer".  I.e., ^01 is not the "first power" but the power of 01. Because what is ^011? 11th power or maybe the 3rd? Of course, so could be ^11. But a leading 0 tends to indicate a base different of 10 so one can exploit that.


Wrapper error

When I use my own wrapper and require ManagerRegistry somewhere, I get an "Undefined array key 0" error when my own wrapper is not in DI

In my opinion, there is no need to get a connection from the container, because we already have it via DI. The first one defined must always be the default. For me, I would remove the getting connection from the DI and the one that goes via argument, so I would use it as the default. And the same with the manager.
https://github.com/nettrine/orm/blob/master/src/ManagerRegistry.php#L21

Ok... The problem is here. Because connection with wrapper class is not defined in DI
https://github.com/nettrine/dbal/blob/master/src/DI/DbalExtension.php#L153
@f3l1x  please check PR nettrine/dbal#62


Slowness on import caused by first line of Invoke-SqlCmd2.ps1

per @FriedrichWeinmann : Measure-Command { Get-Item function:\Invoke-Sqlcmd2 -ErrorAction Ignore }

Strange!  I can't seem to replicate this.  It could be related to this, and I've seen AV add to this.
Any chance you could swap in Bartek's method for loading functions into the psm1 to see if this resolves the issue?  Otherwise, I'm happy to just make the change (PR in dbatools dev branch, pull back here?)
On that note / aside, I'll open another issue on a process for automating that, if it makes sense:

dbatools appveyor job runs
tests run, if they pass...
clone this repo
replace invoke-sqlcmd.ps1, git add, git commit (re-use commit message from dbatools push), git push

SSH key or some other auth can be stored in AppVeyor secure variables, if you're comfortable with that.  Or... AppVeyor might already be running with that permission?  Not sure!
Cheers!

Hi Warren,
we already use that method of loading files. This delay on Get-Command happens, when the command isn't available only.
Cheers,
Fred

Gotcha - I left in some cruft that might be slowing things down - removing the bit that searches a non-existent private folder cuts down the speed for me from 800ms to 100ms or so.
Still can't duplicate a two second delay though, could something else be in play on your system (anti-malware software, for example)?

Hey Warren,
Not sure about the dela -- I use the default Microsoft malware stuff.
The appveyor thing sounds good :) Right now, I'm just putting it in the manual publish.ps1 that I have LOL.
Lemme know when that cruft has been removed (or where I can remove it) -- I'd love to include the speed up in the upcoming release.


Add some Zipkin tracing

This is great!  stopping the zipkin service with systemctl works great and doesn't seem to make the middle-ware that mad as best i can tell.  The trace interface on http://saio:9411/ looks great!


Create reporting dashboard for LAC

LAC is interested in getting regular emails detailing the number of HIV results we're sending. They want something detailing the number of results submitted during a certain time frame for each disease (for now just HIV, but should show other diseases once we're supporting those).
To be discussed during refinement:

parameters around the query:

patient from LAC, facility in LAC, disease is STI disease... anything else?
since not all our addresses have county, what cities should we filter by?

they might also like a list of facilities sending HIV results to them

Filtered by cities in this list:
https://en.wikipedia.org/wiki/List_of_cities_in_Los_Angeles_County,_California

For filtering by patients just doing the county since we don't expose cities or zip codes in metabase

LAC gets results for ordering provider zip codes in LAC
Maybe show zip codes represented in dashboard? (if using cities above as the filter)

LAC do not receive test data from patients who have LAC addresses -- they only care about ordering provider zip code

Ready for review: https://www.simplereport.gov/metabase/dashboard/265-los-angeles-county-lac-hiv-dashboard
Decisions

Filtering

by ordering provider city names that are included in this list: https://en.wikipedia.org/wiki/List_of_cities_in_Los_Angeles_County,_California
filter by ordering provider state is CA

Dashboard

count of all HIV results reported (all-time)
zip codes of ordering providers reporting HIV results (this is because we are filtering by city and not by zip code. We want to make sure they can flag if any zip codes not in LAC are being counted in this dashboard)
facilities name + CLIAs that are reporting HIV

@DanielSass shared that LAC only cares about ordering provider zip codes for HIV... When we introduce other STIs, LAC will also want results for patient address/county/state NOT ordering provider zip. So this dashboard will need to be updated once other STIs are introduced.

This has been approved by devs: https://www.simplereport.gov/metabase/dashboard/265-los-angeles-county-lac-hiv-dashboard
We just need to add email recipients once results are being submitted and let recipients know that they will be receiving this. This will be done later!
cc @jayna-SkylightDigital


Display mod description below shadows

The mod list already do that so it seams it is a bug.
Before / After :

great, thank you!


[Request] Config options to disable explosive tank sound and flame fx

Was already going to add this eventually but this shows that someone wants it so sure. I don't know how to do configs yet but when I do, I will add this functionally.


client is not fully configable

Hi,
firstoff: this was the most modern guzzleBundle i could find, so props for that :)
I need to use
 cookies: true
  verify: false

in my Guzzle Client.
This is not possible at the moment since the the clients config is passed via bundle extension and these two options are not respected.
So wouldnt it make sense to just open the client config with ->useAttributeAsKey('name')?
Or how do i set other options to the client?

hey @ivoba
thoses options are request related, I am not sure if its possible to setup this during the client configuration. can you provide an exemple ?
txs

I'am having the same issue with authentication parameters. Here is what the client instanciation documentation say:

All other options passed to the constructor are used as default request options with every request created by the client.

http://docs.guzzlephp.org/en/latest/quickstart.html#creating-a-client
So we should be able to define all request options in client configuration.


flent: 2.0.1 -> 2.1.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for flent is: "The FLExible Network Tester"
meta.homepage for flent is: "https://flent.org"
meta.changelog for flent is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.1.1 with grep in /nix/store/ikl0nbyx8zc25fmblwp6gyp0lxw7c48a-flent-2.1.1
found 2.1.1 in filename of file in /nix/store/ikl0nbyx8zc25fmblwp6gyp0lxw7c48a-flent-2.1.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
flent

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ikl0nbyx8zc25fmblwp6gyp0lxw7c48a-flent-2.1.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A flent https://github.com/r-ryantm/nixpkgs/archive/4cddee24f110207c30b373a66d8976b37df0aec5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ikl0nbyx8zc25fmblwp6gyp0lxw7c48a-flent-2.1.1
ls -la /nix/store/ikl0nbyx8zc25fmblwp6gyp0lxw7c48a-flent-2.1.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

flent

Maintainer pings
cc @mmlb for testing.

@r-ryantm this PR is obsoleted by https://github.com/NixOS/nixpkgs/pull/199571, can you take a look at it?


Customer-reported issue with NNBD migration tool: Failed to rerun migration

Failed to rerun migration
Error: ConflictingEditException: {"offset":38304,"length":2,"replacement":""} conflicts with {"offset":38301,"length":7,"replacement":""}
Please fill in the following:
Name of package being migrated (if public):
What I was doing when this issue occurred:
Is it possible to work around this issue:
Has this issue happened before, and if so, how often:
Dart SDK version: 2.12.2
Additional details:
Thanks for filing!
Stacktrace: auto populated by migration preview tool.
#0      addEditForSource (package:analyzer_plugin/src/protocol/protocol_internal.dart:58:7)
#1      SourceFileEdit.add (package:analyzer_plugin/protocol/protocol_common.dart:5544:32)
#2      addEditToSourceChange (package:analyzer_plugin/src/protocol/protocol_internal.dart:73:12)
#3      SourceChange.addEdit (package:analyzer_plugin/protocol/protocol_common.dart:5240:7)
#4      DartFixListener.addEditWithoutSuggestion (package:nnbd_migration/src/front_end/dartfix_listener.dart:28:18)
#5      NullabilityMigrationAdapter.addEdit (package:nnbd_migration/src/front_end/non_nullable_fix.dart:538:14)
#6      NullabilityMigrationImpl.finalizeInput (package:nnbd_migration/src/nullability_migration_impl.dart:189:16)
#7      NonNullableFix.finalizeUnit (package:nnbd_migration/src/front_end/non_nullable_fix.dart:115:15)
#8      _FixCodeProcessor.runLaterPhases.<anonymous closure> (package:nnbd_migration/migration_cli.dart:1159:21)
#9      _FixCodeProcessor.runLaterPhases.<anonymous closure> (package:nnbd_migration/migration_cli.dart:1156:28)
#10     _FixCodeProcessor.processResources (package:nnbd_migration/migration_cli.dart:1081:30)
<asynchronous suspension>
#11     _FixCodeProcessor.runLaterPhases (package:nnbd_migration/migration_cli.dart:1156:5)
<asynchronous suspension>
#12     MigrationCliRunner._rerunFunction (package:nnbd_migration/migration_cli.dart:977:14)
<asynchronous suspension>
#13     NonNullableFix.rerun (package:nnbd_migration/src/front_end/non_nullable_fix.dart:169:17)
<asynchronous suspension>
#14     PreviewSite.rerunMigration (package:nnbd_migration/src/preview/preview_site.dart:597:22)
<asynchronous suspension>
#15     PreviewSite.handlePostRequest (package:nnbd_migration/src/preview/preview_site.dart:454:9)
<asynchronous suspension>
#16     HttpPreviewServer._handlePostRequest (package:nnbd_migration/src/preview/http_preview_server.dart:109:5)
<asynchronous suspension>
#17     HttpPreviewServer._handleServer.<anonymous closure> (package:nnbd_migration/src/preview/http_preview_server.dart:119:9)
<asynchronous suspension>

Hi @khongorzul1120, thanks for the bug report!
A few questions:

Is the code you were migrating publicly available?  (It's ok if it isn't, it's just sometimes easier for us to debug if it is)
Can you tell us what you were doing when the issue occurred?
How frequently does this happen?  Have you found a sequence of steps that reliably causes the issue to arise?
Have you been able to make progress with the migration tool in spite of this bug, or does it prevent you from getting anything done?

(Note that there is one other bug that looks similar: #45554.  I haven't had a chance to investigate that issue yet, but the person who filed that bug appears to have found a workaround.  Does their workaround help you any?)

As of 1c7fe7196dd7a542f7f91cd6ea2ac81e1a13146c, the null safety migration tool has been removed from active development and retired. No further work on the tool is planned.
If you still need help, or you believe this issue has been closed in error, please feel free to reopen.