TestSynchCritical is very, very, very flakey

I'm constantly having CI failures from building tip of FreeRDP:
99% tests passed, 2 tests failed out of 171

Total Test time (real) =   4.28 sec

The following tests FAILED:
          5 - TestSynchCritical (Failed)
          8 - TestSynchMultipleThreads (Failed)
Errors while running CTest
make: *** [Makefile:91: test] Error 8

@colemickens ok, any details?
the 2 tests run on our ci for years now, so maybe you have something unique or differing from our setup that triggers that?

I'm not really sure, I still see it failing from time to time here. Seems like it's when it's my 8-core system under a fair amount of load. Sometimes I can just "upaarrow-enter" rebuild and it builds, sometimes I throw it in a loop it just rebuilds until it passes.
Is there a way to get more info out of the test in terms of what fails? This was the only relevant output I was seeing, but maybe I didn't scroll up enough.

@colemickens ok, which environment and compile options do you use (including cmake options)?
aside from that, you might want to check https://stackoverflow.com/questions/5709914/using-cmake-how-do-i-get-verbose-output-from-ctest#5757256

This is the first part of a full build log, albeit from a successful run, if this helps at all:
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/z1m5z2pvq9hnvv4psl43lap0kanb2j35-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LOCALEDIR=/nix/store/4a698dvjw4768aysq281llbphxnxz5bi-wlfreerdp-+29c92af/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/4a698dvjw4768aysq281llbphxnxz5bi-wlfreerdp-+29c92af/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/4a698dvjw4768aysq281llbphxnxz5bi-wlfreerdp-+29c92af/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/4a698dvjw4768aysq281llbphxnxz5bi-wlfreerdp-+29c92af/share/doc/FreeRDP -DCMAKE_INSTALL_INFODIR=/nix/store/4a698dvjw4768aysq281llbphxnxz5bi-wlfreerdp-+29c92af/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/4a698dvjw4768aysq281llbphxnxz5bi-wlfreerdp-+29c92af/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/4a698dvjw4768aysq281llbphxnxz5bi-wlfreerdp-+29c92af/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/4a698dvjw4768aysq281llbphxnxz5bi-wlfreerdp-+29c92af/include -DCMAKE_INSTALL_SBINDIR=/nix/store/4a698dvjw4768aysq281llbphxnxz5bi-wlfreerdp-+29c92af/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/4a698dvjw4768aysq281llbphxnxz5bi-wlfreerdp-+29c92af/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/4a698dvjw4768aysq281llbphxnxz5bi-wlfreerdp-+29c92af/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_SYSROOT= -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/wn31i3dzwahz6ccws8bs1nwyqrpgsvj7-gcc-wrapper-11.3.0/bin/strip -DCMAKE_RANLIB=/nix/store/wn31i3dzwahz6ccws8bs1nwyqrpgsvj7-gcc-wrapper-11.3.0/bin/ranlib -DCMAKE_AR=/nix/store/wn31i3dzwahz6ccws8bs1nwyqrpgsvj7-gcc-wrapper-11.3.0/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/4a698dvjw4768aysq281llbphxnxz5bi-wlfreerdp-+29c92af -DCMAKE_INSTALL_LIBDIR=lib -DBUILD_TESTING=ON -DWITH_CAIRO=ON -DWITH_CUNIT=ON -DWITH_CUPS=ON -DWITH_JPEG=ON -DWITH_OSS=OFF -DWITH_PCSC=ON -DWITH_PULSE=ON -DWITH_SERVER=ON -DWITH_SSE2=ON -DWITH_VAAPI=ON -DWITH_X11=ON
-- The C compiler identification is GNU 11.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/wn31i3dzwahz6ccws8bs1nwyqrpgsvj7-gcc-wrapper-11.3.0/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Found PkgConfig: /nix/store/k2vd7w2ixbqbgd9v88am8780111bng7j-pkg-config-wrapper-0.29.2/bin/pkg-config (found version "0.29.2")
FREERDP_VERSION=3.0.0-dev
-- Git Revision n/a
-- Looking for __x86_64__
-- Looking for __x86_64__ - found
-- Performing Test Wimplicit-function-declaration
-- Performing Test Wimplicit-function-declaration - Success
-- Performing Test Wredundant-decls
-- Performing Test Wredundant-decls - Success
-- Performing Test Wno-builtin-macro-redefined
-- Performing Test Wno-builtin-macro-redefined - Success
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Performing Test fno-omit-frame-pointer
-- Performing Test fno-omit-frame-pointer - Success
-- Finding recommended feature libsystemd for systemd journal appender (allows to export wLog to systemd journal)
--     Disable feature libsystemd using "-DWITH_LIBSYSTEMD=OFF"
-- Found libsystemd: /nix/store/iap1if4pm6h6sacydm344p38j182c189-systemd-minimal-252.1/lib/libsystemd.so
-- Finding recommended feature X11 for X11 (X11 client and server)
--     Disable feature X11 using "-DWITH_X11=OFF"
-- Found X11: /nix/store/3zk3527zglm18ykrvgjdhgz3a4zrfapr-libX11-1.8.1/lib/libX11.so
-- Finding recommended feature Wayland for Wayland (Wayland client)
--     Disable feature Wayland using "-DWITH_WAYLAND=OFF"
CMake Warning (dev) at /nix/store/blqlkgmvs12h8m8rhbv7pmyj7jyxxp37-cmake-3.24.3/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (PkgConfig)
  does not match the name of the calling package (Wayland).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  /nix/store/blqlkgmvs12h8m8rhbv7pmyj7jyxxp37-cmake-3.24.3/share/cmake-3.24/Modules/FindPkgConfig.cmake:99 (find_package_handle_standard_args)
  cmake/FindWayland.cmake:28 (include)
  cmake/FindFeature.cmake:26 (find_package)
  CMakeLists.txt:721 (find_feature)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Checking for module 'wayland-scanner'
--   Found wayland-scanner, version 1.21.0
-- Checking for module 'wayland-client'
--   Found wayland-client, version 1.21.0
-- Checking for module 'wayland-cursor'
--   Found wayland-cursor, version 1.21.0
-- Checking for module 'xkbcommon'
--   Found xkbcommon, version 1.4.1
CMake Warning (dev) at /nix/store/blqlkgmvs12h8m8rhbv7pmyj7jyxxp37-cmake-3.24.3/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (WAYLAND)
  does not match the name of the calling package (Wayland).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  cmake/FindWayland.cmake:69 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  cmake/FindFeature.cmake:26 (find_package)
  CMakeLists.txt:721 (find_feature)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found WAYLAND: /nix/store/i5pgqx46qx0zjc1f2ivhp4bxgayyfwf0-wayland-1.21.0-bin/bin/wayland-scanner
-- Finding required feature ZLIB for compression (data compression)
-- Found ZLIB: /nix/store/zaflwh2nwzj1f0wngd7hqm3nvlf3yhsx-zlib-1.2.13/lib/libz.so (found version "1.2.13")
-- Finding required feature OpenSSL for cryptography (encryption, certificate validation, hashing functions)
-- Found OpenSSL: /nix/store/zpwhl35d2dkj0p4bli5wp6sw1vfsyab5-openssl-3.0.7/lib/libcrypto.so (found version "3.0.7")
-- Skipping optional feature MbedTLS for cryptography (encryption, certificate validation, hashing functions)
--     Enable feature MbedTLS using "-DWITH_MBEDTLS=ON"
-- Skipping optional feature OpenSLES for multimedia (OpenSLES audio / video)
--     Enable feature OpenSLES using "-DWITH_OPENSLES=ON"
-- Skipping recommended feature OSS for sound (audio input, audio output and multimedia redirection)
-- Finding recommended feature ALSA for sound (audio input, audio output and multimedia redirection)
--     Disable feature ALSA using "-DWITH_ALSA=OFF"
-- Found ALSA: /nix/store/w48s09nmw20zq61snxin75phnz902wp6-alsa-lib-<IP_ADDRESS>/lib/libasound.so (found version "<IP_ADDRESS>")
-- Finding recommended feature Pulse for sound (audio input, audio output and multimedia redirection)
--     Disable feature Pulse using "-DWITH_PULSE=OFF"
CMake Warning (dev) at /nix/store/blqlkgmvs12h8m8rhbv7pmyj7jyxxp37-cmake-3.24.3/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (PkgConfig)
  does not match the name of the calling package (Pulse).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  /nix/store/blqlkgmvs12h8m8rhbv7pmyj7jyxxp37-cmake-3.24.3/share/cmake-3.24/Modules/FindPkgConfig.cmake:99 (find_package_handle_standard_args)
  cmake/FindPulse.cmake:2 (include)
  cmake/FindFeature.cmake:26 (find_package)
  CMakeLists.txt:730 (find_feature)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Checking for module 'libpulse'
--   Found libpulse, version 16.1
-- Found Pulse: /nix/store/ysbxm2wcbzr5j6p4s8m6z8b5r13gp8pw-libpulseaudio-16.1-dev/include
-- Finding recommended feature Cups for printing (printer device redirection)
--     Disable feature Cups using "-DWITH_CUPS=OFF"
-- Found Cups: /nix/store/ywszsbpp7d36wpgmnksr3xzl640xz4n1-cups-2.4.2-lib/lib/libcups.so (found version "2.4.2")
-- Finding recommended feature PCSC for smart card (smart card device redirection)
--     Disable feature PCSC using "-DWITH_PCSC=OFF"
CMake Warning (dev) at /nix/store/blqlkgmvs12h8m8rhbv7pmyj7jyxxp37-cmake-3.24.3/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (PkgConfig)
  does not match the name of the calling package (PCSC).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  /nix/store/blqlkgmvs12h8m8rhbv7pmyj7jyxxp37-cmake-3.24.3/share/cmake-3.24/Modules/FindPkgConfig.cmake:99 (find_package_handle_standard_args)
  cmake/FindPCSC.cmake:7 (include)
  cmake/FindFeature.cmake:26 (find_package)
  CMakeLists.txt:733 (find_feature)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found PCSC: /nix/store/xxfw2svaf581dnm5w3l1kfmcvcxz8gvb-pcsclite-1.9.5/lib/libpcsclite.so
-- Skipping recommended feature FFmpeg for multimedia (multimedia redirection, audio and video playback)
-- Finding optional feature JPEG for codec (use JPEG library)
-- Found JPEG: /nix/store/1fhga0xcjfypga7xmgqkvg4sipz1ghw9-libjpeg-turbo-2.1.4/lib/libjpeg.so (found version "62")
-- Skipping optional feature OpenH264 for codec (use OpenH264 library)
--     Enable feature OpenH264 using "-DWITH_OPENH264=ON"
-- Skipping optional feature OpenCL for codec (use OpenCL library)
--     Enable feature OpenCL using "-DWITH_OPENCL=ON"
-- Skipping optional feature GSM for codec (GSM audio codec library)
--     Enable feature GSM using "-DWITH_GSM=ON"
-- Skipping optional feature LAME for codec (lame MP3 audio codec library)
--     Enable feature LAME using "-DWITH_LAME=ON"
-- Skipping optional feature FAAD2 for codec (FAAD2 AAC audio codec library)
--     Enable feature FAAD2 using "-DWITH_FAAD2=ON"
-- Skipping optional feature FAAC for codec (FAAC AAC audio codec library)
--     Enable feature FAAC using "-DWITH_FAAC=ON"
-- Skipping optional feature soxr for codec (SOX audio resample library)
--     Enable feature soxr using "-DWITH_SOXR=ON"
-- Skipping optional feature IPP for performance (Intel Integrated Performance Primitives library)
--     Enable feature IPP using "-DWITH_IPP=ON"
-- Using OpenSSL Version: 3.0.7
using default plugins location
-- Looking for strndup
-- Looking for strndup - found
-- Looking for include file unistd.h
-- Looking for include file unistd.h - found
-- Looking for include file execinfo.h
-- Looking for include file execinfo.h - found
-- Looking for backtrace
-- Looking for backtrace - found
-- Looking for backtrace_symbols
-- Looking for backtrace_symbols - found
-- Looking for backtrace_symbols_fd
-- Looking for backtrace_symbols_fd - found
-- Looking for include file inttypes.h
-- Looking for include file inttypes.h - found
-- Looking for include file stdint.h
-- Looking for include file stdint.h - found
-- Looking for include file stdbool.h
-- Looking for include file stdbool.h - found
-- Looking for include file fcntl.h
-- Looking for include file fcntl.h - found
-- Looking for include file aio.h
-- Looking for include file aio.h - found
-- Looking for include file sys/timerfd.h
-- Looking for include file sys/timerfd.h - found
-- Looking for include file sys/filio.h
-- Looking for include file sys/filio.h - not found
-- Looking for include file sys/sockio.h
-- Looking for include file sys/sockio.h - not found
-- Looking for include file syslog.h
-- Looking for include file syslog.h - found
-- Looking for include file sys/select.h
-- Looking for include file sys/select.h - found
-- Looking for include file sys/eventfd.h
-- Looking for include file sys/eventfd.h - found
-- Looking for include file unwind.h
-- Looking for include file unwind.h - found
-- Looking for eventfd_read
-- Looking for eventfd_read - found
-- Looking for getlogin_r
-- Looking for getlogin_r - found
-- Looking for getpwuid_r
-- Looking for getpwuid_r - found
-- Performing Test HAVE_TM_GMTOFF
-- Performing Test HAVE_TM_GMTOFF - Success
-- Looking for include file poll.h
-- Looking for include file poll.h - found
-- Looking for pthread_mutex_timedlock in pthreads
-- Looking for pthread_mutex_timedlock in pthreads - not found
-- Looking for pthread_mutex_timedlock in pthread
-- Looking for pthread_mutex_timedlock in pthread - found
-- Looking for pthread_mutex_timedlock
-- Looking for pthread_mutex_timedlock - found
-- Finding recommended feature OpenSSL for cryptography (encryption, certificate validation, hashing functions)
--     Disable feature OpenSSL using "-DWITH_OPENSSL=OFF"
-- Skipping optional feature MbedTLS for cryptography (encryption, certificate validation, hashing functions)
--     Enable feature MbedTLS using "-DWITH_MBEDTLS=ON"
-- Skipping optional feature Pkcs11 for PKCS11 (encryption, certificate validation, hashing functions)
--     Enable feature Pkcs11 using "-DWITH_PKCS11=ON"
-- Looking for timer_create
-- Looking for timer_create - found
-- Looking for timer_delete
-- Looking for timer_delete - found
-- Looking for timer_settime
-- Looking for timer_settime - found
-- Looking for timer_gettime
-- Looking for timer_gettime - found
-- Looking for backtrace
-- Looking for backtrace - found
-- Found the following ICU libraries:
--   i18n (required): /nix/store/wkmc51s1nyyic7ym9c44k57wk8aqlpp9-icu4c-72.1/lib/libicui18n.so
--   uc (required): /nix/store/wkmc51s1nyyic7ym9c44k57wk8aqlpp9-icu4c-72.1/lib/libicuuc.so
--   io (required): /nix/store/wkmc51s1nyyic7ym9c44k57wk8aqlpp9-icu4c-72.1/lib/libicuio.so
-- Found ICU: /nix/store/lmr9gzvvxrdq0akic1fls9jklh4kq2vf-icu4c-72.1-dev/include (found version "72.1")
-- Looking for include file stdbool.h
-- Looking for include file stdbool.h - found
-- Finding required feature Wayland for Wayland (Wayland client)
CMake Warning (dev) at /nix/store/blqlkgmvs12h8m8rhbv7pmyj7jyxxp37-cmake-3.24.3/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (PkgConfig)
  does not match the name of the calling package (Wayland).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  /nix/store/blqlkgmvs12h8m8rhbv7pmyj7jyxxp37-cmake-3.24.3/share/cmake-3.24/Modules/FindPkgConfig.cmake:99 (find_package_handle_standard_args)
  cmake/FindWayland.cmake:28 (include)
  cmake/FindFeature.cmake:17 (find_package)
  uwac/CMakeLists.txt:100 (find_feature)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at /nix/store/blqlkgmvs12h8m8rhbv7pmyj7jyxxp37-cmake-3.24.3/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (WAYLAND)
  does not match the name of the calling package (Wayland).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  cmake/FindWayland.cmake:69 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  cmake/FindFeature.cmake:17 (find_package)
  uwac/CMakeLists.txt:100 (find_feature)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found WAYLAND: /nix/store/i5pgqx46qx0zjc1f2ivhp4bxgayyfwf0-wayland-1.21.0-bin/bin/wayland-scanner
-- Checking for module 'cairo'
--   Found cairo, version 1.16.0
Package libpcre2-8 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libpcre2-8.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libpcre2-8', required by 'glib-2.0', not found
Package libpcre2-8 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libpcre2-8.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libpcre2-8', required by 'glib-2.0', not found
Package libpcre2-8 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libpcre2-8.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libpcre2-8', required by 'glib-2.0', not found
Package libpcre2-8 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libpcre2-8.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libpcre2-8', required by 'glib-2.0', not found
-- Found Cairo: /nix/store/n2vak5lsywj8kgyp7r9361pnc150p0vf-cairo-1.16.0/lib/libcairo.so
-- Finding recommended feature XKBFile for X11 keyboard (X11 keyboard file extension)
--     Disable feature XKBFile using "-DWITH_XKBFILE=OFF"
-- Found XKBFile: /nix/store/jdiwf9ga2blwmm2nilab9m0xm68bwkli-libxkbfile-1.1.0/lib/libxkbfile.so
Skipping connection tests, requires WITH_SAMPLE and WITH_SERVER set!
CMake Warning at libfreerdp/CMakeLists.txt:120 (message):
  Compiling without WITH_DSP_FFMPEG and WITH_FAAC, AAC encoder support
  disabled

-- Adding STATIC channel client server "drdynvc": Dynamic Virtual Channel Extension
-- Adding DYNAMIC channel client "video": Video optimized remoting Virtual Channel Extension
-- Adding DYNAMIC channel client "urbdrc": USB Devices Virtual Channel Extension
-- Found libusb-1.0:
--  - Includes: /nix/store/75wphk88yg4axqx02yrbyzr15rxxa6hn-libusb-1.0.26-dev/include/libusb-1.0
--  - Libraries: /nix/store/vqg16chb5dgg3ihxgpwvnickws8q3wd0-libusb-1.0.26/lib/libusb-1.0.so
-- Adding DYNAMIC channel server "telemetry": Telemetry Virtual Channel Extension
-- Adding DEVICE channel client "smartcard": Smart Card Virtual Channel Extension
-- Adding DEVICE channel client "serial": Serial Port Virtual Channel Extension
-- Adding STATIC channel client server "remdesk": Remote Assistance Virtual Channel Extension
-- Adding STATIC channel client server "rdpsnd": Audio Output Virtual Channel Extension
-- Adding DYNAMIC channel client "rdpgfx": Graphics Pipeline Extension
-- Adding DYNAMIC channel client "rdpei": Input Virtual Channel Extension
-- Adding DYNAMIC channel server "rdpecam": Video Capture Virtual Channel Extension
-- Adding STATIC channel client server "rdpdr": Device Redirection Virtual Channel Extension
-- Adding STATIC channel client "rdp2tcp": Tunneling TCP over RDP
-- Adding STATIC channel client "rail": Remote Programs Virtual Channel Extension
-- Adding DEVICE channel client "printer": Print Virtual Channel Extension
-- Adding DEVICE channel client "parallel": Parallel Port Virtual Channel Extension
-- Adding DYNAMIC channel client "geometry": Geometry tracking Virtual Channel Extension
-- Adding STATIC channel client server "encomsp": Multiparty Virtual Channel Extension
-- Adding DYNAMIC channel client server "echo": Echo Virtual Channel Extension
-- Adding DEVICE channel client "drive": Drive Redirection Virtual Channel Extension
-- Adding DYNAMIC channel client "disp": Display Update Virtual Channel Extension
-- Adding STATIC channel client server "cliprdr": Clipboard Virtual Channel Extension
-- Adding DYNAMIC channel client server "audin": Audio Input Redirection Virtual Channel Extension
-- Adding DYNAMIC channel client server "ainput": Advanced Input Virtual Channel Extension
-- Could NOT find DocBook XSL stylesheets (missing: DOCBOOKXSL_DIR)
CMake Warning at client/X11/CMakeLists.txt:131 (message):
  WITH_MANPAGES was set, but xsltproc was not found.  man-pages will not be
  installed

-- Finding required feature XShm for X11 shared memory (X11 shared memory extension)
-- Found XShm: /nix/store/z1zr4xyiaxvdkxc0f1a5cswkvgmix3dw-libXext-1.3.4/lib/libXext.so
-- Finding recommended feature Xinerama for multi-monitor (X11 multi-monitor extension)
--     Disable feature Xinerama using "-DWITH_XINERAMA=OFF"
-- Found Xinerama: /nix/store/bq5kj7wy7v7f8zh5x8yfrsjdf76vlz1v-libXinerama-1.1.4/lib/libXinerama.so
-- Finding recommended feature Xext for X11 extension (X11 core extensions)
--     Disable feature Xext using "-DWITH_XEXT=OFF"
-- Found Xext: /nix/store/z1zr4xyiaxvdkxc0f1a5cswkvgmix3dw-libXext-1.3.4/lib/libXext.so
-- Finding recommended feature Xcursor for cursor (X11 cursor extension)
--     Disable feature Xcursor using "-DWITH_XCURSOR=OFF"
-- Found Xcursor: /nix/store/ib4av8117pkz33hjxjfmp6s7qr8i063b-libXcursor-1.2.0/lib/libXcursor.so
-- Finding recommended feature Xv for video (X11 video extension)
--     Disable feature Xv using "-DWITH_XV=OFF"
-- Found Xv: /nix/store/j9y889v3giqxl2wx8g12fy7khqsl8ijv-libXv-1.0.11/lib/libXv.so
-- Finding recommended feature Xi for input (X11 input extension)
--     Disable feature Xi using "-DWITH_XI=OFF"
-- Checking for module 'xi'
--   Found xi, version 1.8
Package xdmcp was not found in the pkg-config search path.
Perhaps you should add the directory containing `xdmcp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'xdmcp', required by 'xcb', not found
Package xdmcp was not found in the pkg-config search path.
Perhaps you should add the directory containing `xdmcp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'xdmcp', required by 'xcb', not found
Package xdmcp was not found in the pkg-config search path.
Perhaps you should add the directory containing `xdmcp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'xdmcp', required by 'xcb', not found
Package xdmcp was not found in the pkg-config search path.
Perhaps you should add the directory containing `xdmcp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'xdmcp', required by 'xcb', not found
-- Found Xi: /nix/store/gahzc2wha6xq3swgd6kypxxph72605w6-libXi-1.8/lib/libXi.so
-- Finding recommended feature Xrender for rendering (X11 render extension)
--     Disable feature Xrender using "-DWITH_XRENDER=OFF"
-- Found Xrender: /nix/store/p3rjnhrl4g09jm581agvz06jb5g1dwxc-libXrender-0.9.10/lib/libXrender.so
-- Finding recommended feature XRandR for tracking output configuration (X11 randr extension)
--     Disable feature XRandR using "-DWITH_XRANDR=OFF"
-- Found XRandR: /nix/store/szjia7bzp3ax0s09xsyncf5rxhyz7rnl-libXrandr-1.5.2/lib/libXrandr.so
-- Finding recommended feature Xfixes for X11 xfixes extension (Useful additions to the X11 core protocol)
--     Disable feature Xfixes using "-DWITH_XFIXES=OFF"
-- Found Xfixes: /nix/store/prsi6v8xcv04vj30mazicmz476ndn16g-libXfixes-6.0.0/lib/libXfixes.so
-- Finding recommended feature FUSE for Remote to local file copy (use -DWITH_FUSE2 or -DWITH_FUSE3 to specify fuse version)
--     Disable feature FUSE using "-DWITH_FUSE=OFF"
-- Could NOT find FUSE (missing: FUSE_LIBRARIES FUSE_INCLUDE_DIR FUSE_API_VERSION)
CMake Warning at cmake/FindFeature.cmake:47 (message):
      feature FUSE was requested but could not be found! ON / FALSE
Call Stack (most recent call first):
  client/X11/CMakeLists.txt:184 (find_feature)

-- Finding recommended feature PAM for authentication (user authentication)
--     Disable feature PAM using "-DWITH_PAM=OFF"
-- Finding recommended feature Xext for X11 extension (X11 core extensions)
--     Disable feature Xext using "-DWITH_XEXT=OFF"
-- Finding recommended feature XShm for X11 shared memory (X11 shared memory extension)
--     Disable feature XShm using "-DWITH_XSHM=OFF"
-- Finding recommended feature XTest for X11 input event injection (X11 input event injection extension)
--     Disable feature XTest using "-DWITH_XTEST=OFF"
-- Found XTest: /nix/store/iryyhpnhnpym00m1kii35zs2gy635sd4-libXtst-1.2.3/lib/libXtst.so
-- Finding recommended feature Xfixes for X11 region (X11 region fix extension)
--     Disable feature Xfixes using "-DWITH_XFIXES=OFF"
-- Warning: Property DESCRIPTION for package Xfixes already set to "Useful additions to the X11 core protocol", overriding it with "X11 region fix extension"
-- Finding recommended feature Xdamage for X11 region damage (X11 region damage extension)
--     Disable feature Xdamage using "-DWITH_XDAMAGE=OFF"
-- Found Xdamage: /nix/store/5a421vw7q07b7b4d00x38fala928ga4g-libXdamage-1.1.5/lib/libXdamage.so
-- Finding recommended feature Xinerama for multi-monitor (X11 multi-monitor extension)
--     Disable feature Xinerama using "-DWITH_XINERAMA=OFF"
-- Finding recommended feature XRandR for X11 resize, rotate and reflect (X11 resize, rotate and reflect extension)
--     Disable feature XRandR using "-DWITH_XRANDR=OFF"
-- Warning: Property DESCRIPTION for package XRandR already set to "X11 randr extension", overriding it with "X11 resize, rotate and reflect extension"
-- Finding recommended feature Xcursor for cursor (X11 cursor extension)
--     Disable feature Xcursor using "-DWITH_XCURSOR=OFF"
-- Adding proxy module capture
-- Adding proxy module demo
-- The CXX compiler identification is GNU 11.3.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/wn31i3dzwahz6ccws8bs1nwyqrpgsvj7-gcc-wrapper-11.3.0/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Intrinsic path configuration:
-- FREERDP_INSTALL_PREFIX=/nix/store/4a698dvjw4768aysq281llbphxnxz5bi-wlfreerdp-+29c92af
-- FREERDP_LIBRARY_PATH=lib
-- FREERDP_PLUGIN_PATH=lib/freerdp3
-- FREERDP_ADDIN_PATH=lib/freerdp3
-- FREERDP_EXTENSION_PATH=/nix/store/4a698dvjw4768aysq281llbphxnxz5bi-wlfreerdp-+29c92af/lib/freerdp3/extensions
-- FREERDP_PROXY_PLUGINDIR=lib/freerdp3/proxy/
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_POLICY_DEFAULT_CMP0025

-- Build files have been written to: /build/source/build
cmake: enabled parallel building
@nix { "action": "setPhase", "phase": "buildPhase" }
building
build flags: -j16 SHELL=/nix/store/4xw8n979xpivdc46a9ndcvyhwgif00hz-bash-5.1-p16/bin/bash
[  2%] Building C object channels/remdesk/client/CMakeFiles/remdesk-client.dir/remdesk_main.c.o
[  2%] Building C object winpr/libwinpr/library/test/TestLibraryB/CMakeFiles/TestLibraryB.dir/TestLibraryB.c.o
[  2%] Building C object server/proxy/channels/CMakeFiles/pf_channels.dir/pf_channel_rdpdr.c.o
[  2%] Building C object winpr/libwinpr/security/test/CMakeFiles/TestSecurity.dir/TestSecurity.c.o
[  2%] Building C object server/proxy/channels/CMakeFiles/pf_channels.dir/pf_channel_drdynvc.c.o
[  2%] Building C object winpr/libwinpr/library/test/TestLibraryA/CMakeFiles/TestLibraryA.dir/TestLibraryA.c.o
[  2%] Building C object winpr/libwinpr/memory/test/CMakeFiles/TestMemory.dir/TestMemory.c.o
[  2%] Building C object channels/drdynvc/client/CMakeFiles/drdynvc-client.dir/drdynvc_main.c.o
[  2%] Building C object winpr/libwinpr/security/test/CMakeFiles/TestSecurity.dir/TestSecurityToken.c.o
[  2%] Building C object winpr/libwinpr/memory/test/CMakeFiles/TestMemory.dir/TestMemoryCreateFileMapping.c.o
[  2%] Building C object channels/urbdrc/common/CMakeFiles/urbdrc-common.dir/urbdrc_helpers.c.o
[  2%] Building C object channels/encomsp/client/CMakeFiles/encomsp-client.dir/encomsp_main.c.o
[  2%] Building C object channels/rdpsnd/server/CMakeFiles/rdpsnd-server.dir/rdpsnd_main.c.o
[  2%] Building C object channels/cliprdr/client/CMakeFiles/cliprdr-client.dir/cliprdr_format.c.o
[  3%] Building C object channels/server/CMakeFiles/freerdp-channels-server.dir/channels.c.o
[  3%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/address.c.o
[  3%] Linking C shared library ../../../../../Testing/TestLibraryB.so
[  4%] Linking C shared library ../../../../../Testing/TestLibraryA.so
[  4%] Building C object channels/cliprdr/client/CMakeFiles/cliprdr-client.dir/cliprdr_main.c.o
[  4%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/barrier.c.o
[  4%] Linking C executable ../../../../Testing/TestSecurity
[  4%] Linking C executable ../../../../Testing/TestMemory
[  4%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/critical.c.o
[  4%] Building C object channels/urbdrc/common/CMakeFiles/urbdrc-common.dir/msusb.c.o
[  5%] Building C object channels/cliprdr/client/CMakeFiles/cliprdr-client.dir/__/cliprdr_common.c.o
/build/source/channels/rdpsnd/server/rdpsnd_main.c: In function 'rdpsnd_server_recv_formats':
/build/source/channels/rdpsnd/server/rdpsnd_main.c:183:14: warning: variable 'lastblock' set but not used []8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-but-set-variable-Wunused-but-set-variable]8;;]
  183 |         BYTE lastblock;
      |              ^~~~~~~~~
/build/source/channels/rdpsnd/server/rdpsnd_main.c:182:16: warning: variable 'udpPort' set but not used []8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-but-set-variable-Wunused-but-set-variable]8;;]
  182 |         UINT16 udpPort;
      |                ^~~~~~~

@colemickens you add -DBUILD_TESTS=ON to release builds? a very bad idea, the tests change the ABI so that they can access freerdp internal functions.
also:

-DWITH_SSE2=ON is not required, autodetected.
-DWITH_VAAPI=ON bad idea, that is meant for single use case connections (e.g. single resolution sessions) as there are issues with VAAPI and resolution restrictions
you build without FAAC, FAAD, FFMPEG or OpenH264 support, your binary will have very limited capabilities!

as for the actual problem, sorry, the log does not help there.


Defender for Storage malware scan ARM template does not mention log analytics export parameters

I need to programmatically, in ARM, forward the malware scan result logs from defender to a log analytics workspace. This page doesn't really show how to do that in ARM, and I've only been able to find semi-helpful REST notes here. Please advise if this is even possible in ARM, and if so, how to do it.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5c168644-bf18-27e8-7887-84a339ea4691
Version Independent ID: df0cb4d7-4774-468c-87e8-8bc7522c8195
Content: Infrastructure as Code enablement - Microsoft Defender for Cloud
Content Source: articles/defender-for-cloud/defender-for-storage-infrastructure-as-code-enablement.md
Service: defender-for-cloud
GitHub Login: @AlizaBernstein
Microsoft Alias: v-bernsteina

@yuruhimesama
Thanks for your feedback! We will investigate and update as appropriate.

@yuruhimesama  sorry couldn't find any specific document, I'd recommend working closer with our support team via an [Azure support request] (https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request). Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.Teams Q&A forum for technical questions about the configuration and administration of Microsoft Teams on Windows.
Microsoft Teams Community forum


collection: format, fix cross-compile, cleanups, etc.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 115197 run on x86_64-darwin 1

2 packages marked as broken and skipped:

poke
profanity

3 packages failed to build and already failed to build on hydra master:

python37Packages.google-api-python-client: log was empty
python38Packages.google-api-python-client: log was empty
thefuck: log was empty

10 packages failed to build and are new build failures:

python37Packages.bpython: log was empty
python37Packages.curtsies: log was empty
python37Packages.pyte: plain log  |  pretty log
python38Packages.bpython: log was empty
python38Packages.curtsies: log was empty
python38Packages.pyte: plain log  |  pretty log
python39Packages.bpython: log was empty
python39Packages.curtsies: log was empty
python39Packages.pyte: plain log  |  pretty log
termtosvg: log was empty

19 packages built:

arachne-pnr
bootil
dejagnu
expect
gmad
gti
haskellPackages.nix-output-monitor
http-prompt
httpie
monotone
nix-output-monitor
pkgdiff
python37Packages.googleapis-common-protos
python38Packages.googleapis-common-protos
python39Packages.google-api-python-client
python39Packages.googleapis-common-protos
safe-rm
wdiff
wrangler

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

bootil:

warning: attribute-typo
A likely typo in premakefile argument was found, did you mean makefile?
Near pkgs/development/libraries/bootil/default.nix:31:3:
   |
31 |   premakefile = "projects/premake4.lua";
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md

dejagnu:

warning: EvalError
Cannot evaluate attribute ‘dejagnu’ in ‘/nix/store/im2yvpgaqr622y2vj2ljc2jwxavsrv1h-nixpkgs’.

expect:

warning: EvalError
Cannot evaluate attribute ‘expect’ in ‘/nix/store/im2yvpgaqr622y2vj2ljc2jwxavsrv1h-nixpkgs’.

gmad:

warning: EvalError
Cannot evaluate attribute ‘gmad’ in ‘/nix/store/im2yvpgaqr622y2vj2ljc2jwxavsrv1h-nixpkgs’.

gti:

Using CC=cc, CXX=c++, AR=ar or LD=cc prevents cross compiling.
Please use CC=${stdenv.cc.targetPrefix}cc, CXX=${stdenv.cc.targetPrefix}c++, AR=${stdenv.cc.targetPrefix}ar or LD=${stdenv.cc.targetPrefix}cc.

haskellPackages.nix-output-monitor:

warning: EvalError
Cannot evaluate attribute ‘haskellPackages.nix-output-monitor’ in ‘/nix/store/im2yvpgaqr622y2vj2ljc2jwxavsrv1h-nixpkgs’.

monotone:

warning: EvalError
Cannot evaluate attribute ‘monotone’ in ‘/nix/store/im2yvpgaqr622y2vj2ljc2jwxavsrv1h-nixpkgs’.

nix-output-monitor:

warning: EvalError
Cannot evaluate attribute ‘nix-output-monitor’ in ‘/nix/store/im2yvpgaqr622y2vj2ljc2jwxavsrv1h-nixpkgs’.

pkgdiff:

warning: EvalError
Cannot evaluate attribute ‘pkgdiff’ in ‘/nix/store/im2yvpgaqr622y2vj2ljc2jwxavsrv1h-nixpkgs’.

python37Packages.bpython:

warning: python-include-tests
Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python37Packages.google-api-python-client:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/google-api-python-client/default.nix:37:5:
   |
37 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python37Packages.googleapis-common-protos:

warning: unused-argument
Unused argument: pytestCheckHook.
Near pkgs/development/python-modules/googleapis-common-protos/default.nix:6:3:
  |
6 | , pytestCheckHook
  |   ^

python37Packages.pyte:

build log of '/nix/store/l8g573qn2bzwspfwpzn6dqj61hf0na8j-python3.7-pyte-0.8.0' is not available
error: --- Error --- nix
build log of '/nix/store/l8g573qn2bzwspfwpzn6dqj61hf0na8j-python3.7-pyte-0.8.0' is not available
When evaluating attribute ‘python37Packages.pyte’:
warning: unclear-gpl
lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.
Near pkgs/development/python-modules/pyte/default.nix:21:5:
   |
21 |     license = licenses.lgpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

python38Packages.bpython:

warning: python-include-tests
Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python38Packages.google-api-python-client:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/google-api-python-client/default.nix:37:5:
   |
37 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python38Packages.googleapis-common-protos:

warning: unused-argument
Unused argument: pytestCheckHook.
Near pkgs/development/python-modules/googleapis-common-protos/default.nix:6:3:
  |
6 | , pytestCheckHook
  |   ^

python38Packages.pyte:

build log of '/nix/store/2xb9yi2qhx6jfpgfv76mcn61ck441f2a-python3.8-pyte-0.8.0' is not available
error: --- Error --- nix
build log of '/nix/store/2xb9yi2qhx6jfpgfv76mcn61ck441f2a-python3.8-pyte-0.8.0' is not available
When evaluating attribute ‘python38Packages.pyte’:
warning: unclear-gpl
lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.
Near pkgs/development/python-modules/pyte/default.nix:21:5:
   |
21 |     license = licenses.lgpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

python39Packages.bpython:

warning: python-include-tests
Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python39Packages.google-api-python-client:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/google-api-python-client/default.nix:37:5:
   |
37 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python39Packages.googleapis-common-protos:

warning: unused-argument
Unused argument: pytestCheckHook.
Near pkgs/development/python-modules/googleapis-common-protos/default.nix:6:3:
  |
6 | , pytestCheckHook
  |   ^

python39Packages.pyte:

build log of '/nix/store/wm4m8spdys9a56n4m9aawl3p4s9pzqk6-python3.9-pyte-0.8.0' is not available
error: --- Error --- nix
build log of '/nix/store/wm4m8spdys9a56n4m9aawl3p4s9pzqk6-python3.9-pyte-0.8.0' is not available
When evaluating attribute ‘python39Packages.pyte’:
warning: unclear-gpl
lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.
Near pkgs/development/python-modules/pyte/default.nix:21:5:
   |
21 |     license = licenses.lgpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

safe-rm:

warning: unclear-gpl
gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/tools/system/safe-rm/default.nix:33:5:
   |
33 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

wdiff:

warning: EvalError
Cannot evaluate attribute ‘wdiff’ in ‘/nix/store/im2yvpgaqr622y2vj2ljc2jwxavsrv1h-nixpkgs’.

wrangler:

warning: EvalError
Cannot evaluate attribute ‘wrangler’ in ‘/nix/store/im2yvpgaqr622y2vj2ljc2jwxavsrv1h-nixpkgs’.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 115197 run on x86_64-linux 1

2 packages marked as broken and skipped:

linuxPackages-libre.virtualbox
linuxPackages_latest-libre.virtualbox

57 packages built:

arachne-pnr
bootil
dejagnu
expect
fmbt
gmad
gti
hashdeep
http-prompt
httpie
linuxPackages.virtualbox
linuxPackages_4_14.virtualbox
linuxPackages_4_19.virtualbox
linuxPackages_4_4.virtualbox
linuxPackages_4_9.virtualbox
linuxPackages_5_10.virtualbox
linuxPackages_5_11.virtualbox
linuxPackages_hardened.virtualbox
linuxPackages_latest_hardened.virtualbox
linuxPackages_latest_xen_dom0.virtualbox
linuxPackages_latest_xen_dom0_hardened.virtualbox
linuxPackages_lqx.virtualbox
linuxPackages_testing_bcachefs.virtualbox
linuxPackages_xen_dom0.virtualbox
linuxPackages_xen_dom0_hardened.virtualbox
linuxPackages_zen.virtualbox
monotone
nix-output-monitor
open-watcom-bin
pkgdiff
poke
profanity
python37Packages.bpython
python37Packages.curtsies
python37Packages.google-api-python-client
python37Packages.googleapis-common-protos
python37Packages.pyte
python38Packages.bpython
python38Packages.curtsies
python38Packages.google-api-python-client
python38Packages.googleapis-common-protos
python38Packages.pyte
python39Packages.bpython
python39Packages.curtsies
python39Packages.google-api-python-client
python39Packages.googleapis-common-protos
python39Packages.pyte
safe-rm
swtpm (swtpm-tpm2)
termtosvg
thefuck
viking
virtualbox
virtualboxHardened
virtualboxHeadless
virtualboxWithExtpack
wdiff

This PR introduced breaking changes to the public interface of nixpkgs mixed in with trivial formatting changes and cleanups and was merged within little over 24h after all but one review (which was done before the breakage was introduced).
I can sympathize with the desire to bring the attribute names in pythonPackages in line with the upstream names and PyPi, but downstream users depend on these attributes and removing them introduces unnecessary and unmanaged breakage (for example this is how I got wind of this PR). Maybe the renames should have waited until we have alias support for pythonPackages?


Installation problem - invalid packages names

Mac OSX El Capitan
Node 5.2.0, 6.0.0., 6.6.0
I'm trying to install the latest version of angular-cli:

npm uninstall -g angular-cli
npm cache clean
npm install -g angular-cli@latest

For node 5.2.0 (npm version 3.3.12) I get errors:

npm WARN install Couldn't install optional dependency: Invalid name: "@angular/tsc-wrapped"
npm WARN install Couldn't install optional dependency: Invalid name: "@angular-cli/base-href-webpack"
npm WARN install Couldn't install optional dependency: Invalid name: "@angular/platform-browser"
npm WARN install Couldn't install optional dependency: Invalid name: "@angular/platform-server"
npm WARN install Couldn't install optional dependency: Invalid name: "@angular/compiler"
npm WARN install Couldn't install optional dependency: Invalid name: "@angular-cli/ast-tools"
npm WARN install Couldn't install optional dependency: Invalid name: "@angular/compiler-cli"
npm WARN install Couldn't install optional dependency: Invalid name: "@angular/common"
npm WARN install Couldn't install optional dependency: Invalid name: "@angular/core"

For node 6.6.0
npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "-g" "angular-cli@latest"
npm ERR! node v6.6.0
npm ERR! npm  v3.10.3

npm ERR! Invalid name: "@angular/tsc-wrapped"

For node 6.0.0
(node:89154) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "-g" "angular-cli@latest"
npm ERR! node v6.0.0
npm ERR! npm  v3.8.6

npm ERR! Invalid name: "@angular-cli/base-href-webpack"

Possibly related https://github.com/angular/angular-cli/issues/2150
What is the result of running npm info @angular/core dist-tags?

I get the following error when I run  "sudo npm install -g @angular-cli@latest"
Darwin 15.4.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "-g" "angular-cli@latest"
npm ERR! node v6.7.0
npm ERR! npm  v3.10.3
npm ERR! Invalid name: "@angular-cli/ast-tools"
Following are the debug logs:
2911 verbose stack Error: Invalid name: "@angular-cli/ast-tools"
2911 verbose stack     at ensureValidName (/usr/local/lib/node_modules/npm/node_modules/read-package-json/node_modules/normalize-package-data/lib/fixer.js:281:15)
2911 verbose stack     at Object.fixNameField (/usr/local/lib/node_modules/npm/node_modules/read-package-json/node_modules/normalize-package-data/lib/fixer.js:196:5)
2911 verbose stack     at /usr/local/lib/node_modules/npm/node_modules/read-package-json/node_modules/normalize-package-data/lib/normalize.js:29:38
2911 verbose stack     at Array.forEach (native)
2911 verbose stack     at normalize (/usr/local/lib/node_modules/npm/node_modules/read-package-json/node_modules/normalize-package-data/lib/normalize.js:28:15)
2911 verbose stack     at final (/usr/local/lib/node_modules/npm/node_modules/read-package-json/read-json.js:349:5)
2911 verbose stack     at then (/usr/local/lib/node_modules/npm/node_modules/read-package-json/read-json.js:124:5)
2911 verbose stack     at /usr/local/lib/node_modules/npm/node_modules/read-package-json/read-json.js:214:31
2911 verbose stack     at f (/usr/local/lib/node_modules/npm/node_modules/once/once.js:17:25)
2911 verbose stack     at Glob. (/usr/local/lib/node_modules/npm/node_modules/read-package-json/node_modules/glob/glob.js:146:7)
2912 verbose cwd /Users/XXX
2913 error Darwin 15.4.0
2914 error argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "-g" "angular-cli@latest"
2915 error node v6.7.0
2916 error npm  v3.10.3
2917 error Invalid name: "@angular-cli/ast-tools"

@filipesilva In my case:
$ npm info @angular/core dist-tags
{ latest: '2.0.2', next: '2.1.0-rc.0' }

Turns out, an update to npm fixed this issue.
Here's how I resolved this issue:
  sudo npm update npm -g
  npm --v
  node -v
  sudo npm uninstall -g angular-cli
  sudo npm cache clean
  sudo npm install -g angular-cli@latest

After running the following commands, following were the versions of npm and node:
npm: 3.10.9
node: v6.6.0

@Olgagr you seem to have some npm problem. npm info shows the package exists, but npm install says the package name is invalid. @apatil88 seems to have fixed it by updating npm, so perhaps that works.
Either way there isn't anything we can do on the CLI itself, we have those dependencies and cannot do without them.

tks champions \o/


request: binary for armv6h (gcc refers to it as armv6l)

Hello,
thanks for this useful program. It would be cool when I could use it on my raspberry pi. I do not have any experience with go so I ask here maybe you can compile a armv6h version for me.
Thanks!

Hello,
Sorry for the late reply!
As far as I know it is realy easy to compile to arm but I know nothing about aspberry pi. The OS is linux right?
I gonna add the build for GOOS=linux GOARCH=arm and GOOS=linux GOARCH=arm64. After that I would like to know if it worked for you.
For reference the supported archtectures by go can be found here.

Hi @Spacewalker2.
Here is the build: https://github.com/gumieri/note/releases/tag/v1.2.1
Please let me know if it worked for you.
The Issue will be closed but if you find any trouble you are free to re-open it.

Hello @gumieri,
it worked as expected. Thanks! I tried gccgo by myself but I got a lot of error messages. Thanks for the urls I will study them.


stdout is not a tty

Hello,
in the past I always was able to pipe ffmpeg output to another program. But now not any more. I get the message: stdout is not a tty
I use this command for example:
ffmpeg -re -i "input.mpeg" -f null /dev/null 2>&1 | awk '{print}'
or:
ffmpeg -i "input.mpeg"  -f matroska - | ffplay -
In Windows cmd this is not a problem.
You have any idea, what is happen here?
Regards
jb_

Maybe this? https://sourceforge.net/p/msys2/wiki/Porting/#standard-streams-in-mintty

Sorry, the reference is unrelated as long as winpty works not.

Ok I found a very wired solution. When ffmpeg is outside from the msys2 installation environment it works, or when I putt .exe at the end (ffmpeg.exe) it works also in the msys2 environment.
It can also be, that this issue belong to Windows 10, because I can not reproduce this in Windows 7.
Is this a bug from msys2? When not we can close here.

If you're using ffmpeg/mpv from the media-autobuild_suite, it creates a helper script that calls ffmpeg/mpv with winpty. To not use that you need to explicitely use ffmpeg.exe or mpv.com.

Thank you wiiaboo for that information! It comes not to my mind, that there is a helper script.


sudo python3 ./simple_IMSI-catcher.py --sniff

hi my python3 version is 3.9.2.
when i run this script (sudo python3 ./simple_IMSI-catcher.py --sniff ) i get this exception:
**Nb IMSI ; TMSI-1     ; TMSI-2     ; IMSI              ; country      ; brand      ; operator              ; MCC  ; MNC   ; LAC    ; CellId ; Timestamp
Traceback (most recent call last):
File "/root/IMSI-catcher/./simple_IMSI-catcher.py", line 610, in
sniff(iface=options.iface, filter="port {} and not icmp and udp".format(options.port), prn=find_imsi_from_pkt, store=0)
File "/usr/local/lib/python3.9/dist-packages/scapy/sendrecv.py", line 1263, in sniff
sniffer._run(*args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/scapy/sendrecv.py", line 1210, in _run
session.on_packet_received(p)
File "/usr/local/lib/python3.9/dist-packages/scapy/sessions.py", line 108, in on_packet_received
result = self.prn(pkt)
File "/root/IMSI-catcher/./simple_IMSI-catcher.py", line 561, in find_imsi_from_pkt
find_imsi(udpdata)
File "/root/IMSI-catcher/./simple_IMSI-catcher.py", line 490, in find_imsi
t.register_imsi(gsm.arfcn, imsi1, imsi2, tmsi1, tmsi2, p)
File "/root/IMSI-catcher/./simple_IMSI-catcher.py", line 276, in register_imsi
self.pfields(str(n), tmsi1, tmsi2, imsi1, str(self.mcc), str(self.mnc), str(self.lac), str(self.cell), p)
File "/root/IMSI-catcher/./simple_IMSI-catcher.py", line 193, in pfields
self.output_function(cpt, tmsi1, tmsi2, imsi, imsicountry, imsibrand, imsioperator, mcc, mnc, lac, cell, now, packet)
File "/root/IMSI-catcher/./simple_IMSI-catcher.py", line 182, in output
print("{:7s} ; {:10s} ; {:10s} ; {:17s} ; {:12s} ; {:10s} ; {:21s} ; {:4s} ; {:5s} ; {:6s} ; {:6s} ; {:s}".format(str(cpt), tmsi1, tmsi2, imsi, imsicountry.encode('utf-8'), imsibrand.encode('utf-8'), imsioperator.encode('utf-8'), str(mcc), str(mnc), str(lac), str(cell), now.isoformat()))
TypeError: unsupported format string passed to bytes.format
**

@lapolis : could you take a look at this ? (https://github.com/Oros42/IMSI-catcher/pull/128)

hi my python3 version is 3.9.2.
... ...
TypeError: unsupported format string passed to bytes.format
**
Sorry about that, it should work on python2.7 which is apparently what I used while testing. So you might be able to use it for now. Later today i will fix it for python3.

@lapolis  hi) first i get imsi but after update kali linux version from 2020.3 to 2021.2 i got this exception( in advance " i run python simple_IMSI-catcher.py -s " and i can catch imsi

Hi dear what is your advice . I change my python version to 2.7?
On Tue, 13 Jul 2021, 13:45 lapolis_aka_blu, @.***>
wrote:

hi my python3 version is 3.9.2.
... ...
TypeError: unsupported format string passed to bytes.format
**
Sorry about that, it should work on python2.7 which is apparently what I
used while testing. So you might be able to use it for now. Later today i
will fix it for python3.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Oros42/IMSI-catcher/issues/130#issuecomment-878941570,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANDJBPQUUDEMES7LEZBW5P3TXQDMTANCNFSM5AITZBTQ
.

Hi dear what is your advice . I change my python version to 2.7?
…
On Tue, 13 Jul 2021, 13:45 lapolis_aka_blu, @.***> wrote: hi my python3 version is 3.9.2. ... ... TypeError: unsupported format string passed to bytes.format ** Sorry about that, it should work on python2.7 which is apparently what I used while testing. So you might be able to use it for now. Later today i will fix it for python3. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#130 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANDJBPQUUDEMES7LEZBW5P3TXQDMTANCNFSM5AITZBTQ .

Just for now but I will patch it later today cause using Python2.7 in 2021 is not something I want to live with

huh, just spent some time trying t figure out what did I wrong - glad it's known issue. wating for fix ,-)
Thanks for great work on this project

i change my python version to 2.7.3 and i get this exception
Traceback (most recent call last):
File "simple_IMSI-catcher.py", line 608, in
from scapy.all import sniff, UDP
ImportError: No module named scapy.all

i change my python version to 2.7.3 and i get this exception
Traceback (most recent call last):
File "simple_IMSI-catcher.py", line 608, in
from scapy.all import sniff, UDP
ImportError: No module named scapy.all

You need to install scapy on python2

i installed scapy on python3 .
but when i run script i get this error
root@kali:~/IMSI-catcher# python3 simple_IMSI-catcher.py -s
Nb IMSI ; TMSI-1     ; TMSI-2     ; IMSI              ; country      ; brand      ; operator              ; MCC  ; MNC   ; LAC    ; CellId ; Timestamp
Traceback (most recent call last):
File "/root/IMSI-catcher/simple_IMSI-catcher.py", line 610, in
sniff(iface=options.iface, filter="port {} and not icmp and udp".format(options.port), prn=find_imsi_from_pkt, store=0)
File "/usr/local/lib/python3.9/dist-packages/scapy/sendrecv.py", line 1263, in sniff
sniffer._run(*args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/scapy/sendrecv.py", line 1210, in _run
session.on_packet_received(p)
File "/usr/local/lib/python3.9/dist-packages/scapy/sessions.py", line 108, in on_packet_received
result = self.prn(pkt)
File "/root/IMSI-catcher/simple_IMSI-catcher.py", line 561, in find_imsi_from_pkt
find_imsi(udpdata)
File "/root/IMSI-catcher/simple_IMSI-catcher.py", line 490, in find_imsi
t.register_imsi(gsm.arfcn, imsi1, imsi2, tmsi1, tmsi2, p)
File "/root/IMSI-catcher/simple_IMSI-catcher.py", line 276, in register_imsi
self.pfields(str(n), tmsi1, tmsi2, imsi1, str(self.mcc), str(self.mnc), str(self.lac), str(self.cell), p)
File "/root/IMSI-catcher/simple_IMSI-catcher.py", line 193, in pfields
self.output_function(cpt, tmsi1, tmsi2, imsi, imsicountry, imsibrand, imsioperator, mcc, mnc, lac, cell, now, packet)
File "/root/IMSI-catcher/simple_IMSI-catcher.py", line 182, in output
print("{:7s} ; {:10s} ; {:10s} ; {:17s} ; {:12s} ; {:10s} ; {:21s} ; {:4s} ; {:5s} ; {:6s} ; {:6s} ; {:s}".format(str(cpt), tmsi1, tmsi2, imsi, imsicountry.encode('utf-8'), imsibrand.encode('utf-8'), imsioperator.encode('utf-8'), str(mcc), str(mnc), str(lac), str(cell), now.isoformat()))
TypeError: unsupported format string passed to bytes.format

Step to make it work:
Step 1 - Install scapy for Python 2.7
Step 2 - Use Python 2.7 to run the code
Bonus point - additional step:
Step 3 - Wait few hours until I patch it for Python 3.9
Hope it is more clear now.

okey thanks for attention

This fix should work --> #131

Merge done

it works perfectly thanks a lot this is amazing project!. thanks for support

it works perfectly thanks a lot this is amazing project!. thanks for support

Glad it does.
And sorry @Oros42 for the mess

Just fyi - I dropped this as is into "DragonOS" which has python2/3 and had no issues running sudo python3 simple_IMSI-catcher.py --sniff - but I also had no issues before these updates. Either way, it works.

Just fyi - I dropped this as is into "DragonOS" which has python2/3 and had no issues running sudo python3 simple_IMSI-catcher.py --sniff - but I also had no issues before these updates. Either way, it works.

I was on DragonOS too. The latest one. The whole script was working well but it was crashing whenever there were some unicode in the country|brand|operator column.
I realised that when I used a Polish sim card from an operator that has the \u00f3 letter in the name. Not sure if I was in Python3 or 2 tho.


Gradle 'muzei' project refresh failed: Error:This Gradle plugin requires Studio 3.0 minimum

I pulled project and imported in Android Studio. Gradle sync processed but i'm getting following error :
Gradle 'muzei' project refresh failed:
Error:This Gradle plugin requires Studio 3.0 minimum

but, my Android Studio Gradle settings used Use default gradle wrapper, and Service directory path have gradle-4.1-rc-1-all directory.
Android Studio version is 2.3.3.
help me, please!

It's my fault, when i use Android Studio 3.0, issues is gone !


Updated connector is not reflected in this doc -

Yo! -
This connector information is out of date - This describes the Dataverse connector as OData, but the current version is based on TDS - and has a very different interface and connection format -
See this document  https://docs.microsoft.com/en-us/powerapps/maker/data-platform/data-platform-powerbi-connector
Reach out and I'm happy to help clarify.  Or reach out to Rich Dickinson, the PM who owns the interface.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e182c32-ef1e-2092-9e8f-0643f991c17a
Version Independent ID: 11d6812e-4d94-9024-72ad-a8ae7aa429a6
Content: Power Query Dataverse connector
Content Source: powerquery-docs/Connectors/Dataverse.md
Service: powerquery
GitHub Login: @DougKlopfenstein
Microsoft Alias: bezhan

@cpopell can you please take a look at this?


Removed unneeded alias. Fixed description metadata.

Fixes some minor errors kindly pointed out by @Moxinilian. I'm assuming the issue with the description was the format, so I changed it to reflect the TWIA field.

bors r+


why Roberta?

Why did you use Roberta and not use BERT or ELMO instead?

In an ablation study (that we didn't publish) we found that RoBERTa fine-tunes better than BERT or GPT-2 itself. We expect ELECTRA should work as well.


Detect browser wakeup and re-fetch

When I open my laptop in the morning my guide page typically looks like this:

If I stay on the page it just stays like this. We coulddddd use the existing setInterval on the page to store the last time setInterval ran, then compare it to the current time and if its more than an hour we do a refetch.
Need to think on a good solution here but it would be nice for it to work when:
1.) User re-opens their laptop after a long while
2.) If the guide page stays open for hours, it continually refreshes the guide page.  This would allow some users to have a dedicated "guide" screen if they wanted.

IIRC react-query has this kinda stuff built in. I thought it worked automatically but maybe we need to change some query client settings.

Ah yea, I do recall them having a staleness duration param.  We could probably pass in the guide duration value into that and have it auto fetch new data every time the guide duration expires

I think I got this working using React Query's 'refetchInterval' set to the guide duration.  Doing some testing on it now

Fixed in https://github.com/chrisbenincasa/tunarr/pull/65


Shouldn't globbing recurse directories?

Noticed in mattkrick/meatier#122 that xo src/**/*.js does not pick up all .js files in the src directory. Is this intended behavior? It is a little unexpected to have to ls src/**/*.js | xo.

Try to wrap the glob pattern in quotes like this: xo 'src/**/*.js'. Otherwise your shell will do the glob expanding instead of XO.

And the answer is...I forgot to brew my own bash so I have 3.x instead of the 4.x necessary to support recursion via globstar.
Mystery solved.


Feature/company

Add support for companies

[x] API for all company actions
[x] Rework existing Auth API to use ContextProvider method

Fixes #80.

Just added draft label, since I accidentally marked this PR as "Ready for Reveiw"

https://github.com/Kodeworks/liquidator-frontend/blob/91683d30939bccd538fd18a8848e8c2c3a81a4f8/src/store/reducers/auth.ts#L14-L18
💡 	Are the access and refresh tokens even necessary in the AuthState, at all? 🤔
I would argue that they are not, since the only time they are actually used, they are fetched from localStorage. This also follows conventions, I think.
If the AuthPRovider is written properly, a valid user object would be in AuthState if the user is authenticated, and the AuthState would be null if not. This makes it easy to check if the App is in an "Authenticated"state or not.

will fixx :smile:

https://github.com/Kodeworks/liquidator-frontend/blob/91683d30939bccd538fd18a8848e8c2c3a81a4f8/src/components/atoms/Routes.tsx#L30-L34
This redirect should be done for all urls, not only the ones in pageRoutes. 🤔

I'll take a look at implementing this later today. Looks good, thanks for
the review.
El vie., 19 jul. 2019 10:05, Nicolaj<EMAIL_ADDRESS>escribió:

@NicolajNiels1 commented on this pull request.
In src/components/atoms/Routes.tsx
https://github.com/Kodeworks/liquidator-frontend/pull/90#discussion_r305227293
:

+const Routes: React.FC<RouteComponentProps<{}>> = props => {

const user = useAuthState();

if (!localStorage.getItem('access')) {

// If path is not /login or /register. Done like this to make the list easy to extend

if (['/login', '/register'].indexOf(props.location.pathname) === -1) {

 props.history.push('/login');

}

return (

 <>

   <Route path="/login" component={Login} />

   <Route path="/register" component={Register} />

 </>

);

} else if (localStorage.getItem('access') && !user) {

⬇ Suggested change

} else if (localStorage.getItem('access') && !user) {

} else if (!user) {

In src/components/molecules/tests/Filters.test.tsx
https://github.com/Kodeworks/liquidator-frontend/pull/90#discussion_r305231768
:

return (

<AuthCtx.Provider value={{ store: auth, dispatch: authDispatch }}>

 <ThemeProvider theme={theme}>

   <>{props.children}</>

 </ThemeProvider>

</AuthCtx.Provider>

 <>{props.children}</>

Since we're using the render method from test-utils.ts it's not necessary
to wrap with ThemeProvider since the render method is already wrapped with
GlobalWrapper (which contains ThemeProvider) 🙂
In src/components/molecules/tests/Filters.test.tsx
https://github.com/Kodeworks/liquidator-frontend/pull/90#discussion_r305231841
:

return (

<AuthCtx.Provider value={{ store: auth, dispatch: authDispatch }}>

 <ThemeProvider theme={theme}>

   <>{props.children}</>

 </ThemeProvider>

</AuthCtx.Provider>

⬇ Suggested change

In src/components/molecules/tests/Filters.test.tsx
https://github.com/Kodeworks/liquidator-frontend/pull/90#discussion_r305231922
:

return (

<AuthCtx.Provider value={{ store: auth, dispatch: authDispatch }}>

 <ThemeProvider theme={theme}>

   <>{props.children}</>

 </ThemeProvider>

</AuthCtx.Provider>

 <>{props.children}</>

⬇ Suggested change

In src/components/molecules/tests/Filters.test.tsx
https://github.com/Kodeworks/liquidator-frontend/pull/90#discussion_r305232078
:

return (

<AuthCtx.Provider value={{ store: auth, dispatch: authDispatch }}>

 <ThemeProvider theme={theme}>

   <>{props.children}</>

 </ThemeProvider>

</AuthCtx.Provider>

 <>{props.children}</>

⬇ Suggested change

 <>{props.children}</>

<>{props.children}</>

In src/components/organism/Toolbar.tsx
https://github.com/Kodeworks/liquidator-frontend/pull/90#discussion_r305233293
:

return (
 <ToolbarContainer>

Welcome, {`${store.user!.first_name} ${store.user!.last_name}`}

Welcome, {`${user!.first_name} ${user!.last_name}`}

The ToolBar is never rendered when unauthenticated or while the user
object is fetched async from API, right?
In src/components/organism/Toolbar.tsx
https://github.com/Kodeworks/liquidator-frontend/pull/90#discussion_r305233553
:

return (
 <ToolbarContainer>

Welcome, {`${store.user!.first_name} ${store.user!.last_name}`}

Welcome, {`${user!.first_name} ${user!.last_name}`}

I'm just not entirely confident about the whole auth flow yet 🙂
In src/components/organism/authentication/Authentication.tsx
https://github.com/Kodeworks/liquidator-frontend/pull/90#discussion_r305234237
:

@@ -119,10 +119,10 @@ const Authentication: React.FC = props => {

     />

     <OutlinedButton>{props.type}</OutlinedButton>

     {props.type === AuthType.Login && (

     <AccentedLink to="#">Forgot your password?</AccentedLink>

     <AccentedLink to="/register">Forgot your password?</AccentedLink>

How about just giving an alert message, since there's no functionality for
retrieving lost passwords yet?
I thing redirecting to /register might be confusing
In src/components/organism/authentication/Login.tsx
https://github.com/Kodeworks/liquidator-frontend/pull/90#discussion_r305236111
:

@@ -27,4 +28,4 @@ const Login: React.FC = props => {

);
};
-export default Login;
+export default withRouter(Login);
Doesn't the Login component already have access to the Router, and thus
props.history, because of this line in Routes.tsx:
https://github.com/Kodeworks/liquidator-frontend/blob/320eddc1a468db5072dfdcac4a7f8cc6fe27b60e/src/components/atoms/Routes.tsx#L26
In src/helpers/GlobalWrapper.tsx
https://github.com/Kodeworks/liquidator-frontend/pull/90#discussion_r305237313
:

     </ThemeProvider>

   </BrowserRouter>

 </TransactionProvider>

 <AuthProvider>

   <CompanyProvider>

     <TransactionProvider>

       <GlobalStyle />

       <ThemeProvider theme={theme}>

{props.children}

       </ThemeProvider>

     </TransactionProvider>

   </CompanyProvider>

 </AuthProvider>

🤣
In src/mitochondria/test/auth.test.ts
https://github.com/Kodeworks/liquidator-frontend/pull/90#discussion_r305239347
:

@@ -40,15 +40,11 @@ describe('Authentication/Registration', () => {

   loginPassword

 );

 expect(registerResp).toEqual({

 access,

 refresh,

 user: {

   companies: [],

   email: loginEmail,

   first_name: loginFirstName,

   id: 0,

   last_name: loginLastName,

 },

 companies: [],

 email: loginEmail,

 first_name: loginFirstName,

 id: 0,

 last_name: loginLastName,

'register creates a new user and returns it along with tokens'
There are no tokens in the toEqual body?
It doesn't match the nock response? Why does it pass?
In src/store/reducers/transactions.ts
https://github.com/Kodeworks/liquidator-frontend/pull/90#discussion_r305243446
:

const addTransaction = (

tx: ITransaction
-): { type: typeof ADD_TRANSACTION; tx: ITransaction } => ({

tx,

+): { type: typeof ADD_TRANSACTION; payload: ITransaction } => ({
I like this! 💯
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Kodeworks/liquidator-frontend/pull/90?email_source=notifications&email_token=AB2V2G2VHEODOAN6VJC4QALQAFYWLA5CNFSM4IERXMO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB66QNYQ#pullrequestreview-264046306,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB2V2GZCWBT3RV4GNO3TV3TQAFYWLANCNFSM4IERXMOQ
.

Will merge after I push another commit. The backend changed some of its API to reflect some changes requested by me.


Rawhide Bodhi updates created from sidetags not auto-pushed to stable

Normally, rawhide updates have Stable by Time: 0 days and are pushed to stable automatically after a few seconds/minutes.
However, the latest update for packit, specfile and ogr has been stuck in pending for 5 days now.
It would seem that updates created from sidetags behave differently in this regard, but for instance this one for packit and specfile from 2 weeks ago was successfully auto-pushed to stable.
Looking more closely, starting with packit-0.100.2-1.fc42 no rawhide update has been auto-pushed, so it would seem that it has something to do with rawhide switching from f41 to f42.

Looking more closely, starting with packit-0.100.2-1.fc42 no rawhide update has been auto-pushed, so it would seem that it has something to do with rawhide switching from f41 to f42.

If that's the case, doesn't it suggest that it's an issue on the Bodhi side?

It does seem to be specific to packit only:

only packit is (still) stuck: https://bodhi.fedoraproject.org/updates/?search=&status=pending&releases=F42
some other updates by packit in rawhide were obsoluted: https://bodhi.fedoraproject.org/updates/?search=&status=obsolete&releases=F42&page=1. Gating status there seems to be all over the place
there were weird cases in f41 rawhide as well: https://bodhi.fedoraproject.org/updates/?search=&status=obsolete&releases=F41&gating=ignored&user=packit

If that's the case, doesn't it suggest that it's an issue on the Bodhi side?

That's what I thought, but then there are updates that work as expected:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-8dbf4f0df5

Looking at the history of one of the packages involved, it seems like the packit-stg user untagged them from the side-tag before it could be processed by bodhi:
$ koji list-history --build packit-0.101.1-1.fc42
Wed Sep 18 15:37:59 2024 packit-0.101.1-1.fc42 tagged into f42-build-side-96225 by packit-stg
Wed Sep 18 15:38:10 2024 packit-0.101.1-1.fc42 untagged from f42-build-side-96225 by packit-stg
Sat Sep 21 04:33:04 2024 packit-0.101.1-1.fc42 tagged into f42-signing-pending by bodhi
Sat Sep 21 04:34:07 2024 packit-0.101.1-1.fc42 untagged from f42-signing-pending by autosign/autosign02.iad2.fedoraproject.org
Sat Sep 21 04:34:07 2024 packit-0.101.1-1.fc42 tagged into f42-updates-testing-pending by autosign/autosign02.iad2.fedoraproject.org [still active]

Thanks @decathorpe, removing the sidetag is most likely the cause of the issues. We need to prioritize and implement https://github.com/packit/packit-service/issues/2497, that should fix it.

Fixed by https://github.com/packit/packit-service/pull/2549.


Fix param input order for cudagraph

Description
I discovered that when I attempt to use cudagraph during Pipeline Parallelism, the gradient becomes incorrect, ultimately leading to a NaN issue. After debugging, I identified a small bug in TE's graph.py.
Fixes # (issue)
Here is the translation of your text into English for your GitHub issue description: Since the make_graphed_callables function in TE implements the backward graph through the torch.autograd.grad function, the weights are also passed into the torch.autograd.grad function through the inputs. This requires that the order of inputs in torch.autograd.grad matches the order in the forward graph; otherwise, it will lead to backward errors.
Type of change

[ ] Documentation change (change only to the documentation, either a fix or a new content)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Infra/Build change
[ ] Code refractor

Changes
Modify the input order of weights inside of cudagraph related module
Checklist:

[x] I have read and followed the contributing guidelines
[x] The functionality is complete
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

This fix seems plausible. It seems that make_graphed_callables expects sample_args to be ordered first by layer number, then by microbatch, then by model chunk:
https://github.com/NVIDIA/TransformerEngine/blob/0ece13ea3618bff300e9de304f32010480ddafce/transformer_engine/pytorch/graph.py#L236-L238
However, I see some of our MLPerf wrappers order by microbatch, then layer number, then model chunk: https://gitlab-master.nvidia.com/dl/mlperf/optimized/-/blob/main/large_language_model/pytorch/custom_callbacks.py#L249-L254
Pinging @ksivaman.
Also, can you sign your commit to pass the DCO check?

THX for your reminder! I have signed my commit.
Based on my understanding of the code, the order you referenced from MLPerf does not affect the capture order within the make_graphed_callables function. When performing the capture, it still follows the sequence of first by layer number, then by microbatch, and finally by model chunk. Therefore, the issue described earlier will still occur. I understand that this is why there is a modification in the code to isolate the captures of different microbatches (which will prevent sharing the memory pool and is likely to increase memory overhead):
https://gitlab-master.nvidia.com/dl/mlperf/optimized/-/blob/main/large_language_model/pytorch/custom_callbacks.py#L216-237

/te-ci pytorch


Custom day view

I have created a custom day view, replacing the original. I can view it and navigate properly from both the day/month/year menu and clicking on a specific day on the calendar from week/ month views.
The issue is that I cannot get the correct date the user selected. It always shows today's events.
How can I get the correct current date according to user selection and corresponding events?

Sorry I don't quite follow you, do you mean when the user clicks the day number on the month view?

Yes, when the user clicks on the day number on week or month view, it goes to day view but the events have not been updated. It will always shows todays' events.

That's odd, as it works fine in the demo: http://mattlewis92.github.io/angular-bootstrap-calendar/#?example=kitchen-sink
Can you reproduce it in a plunker please?

Sorry I cannot reproduce it. Events are loaded from back-end and on the day view a separate AJAX call is made to filter the data. It seems there is a scope issue.

Maybe try this then?
https://github.com/mattlewis92/angular-bootstrap-calendar/issues/271#issuecomment-176841792

Closing, LMK if you're still having issues.

I resolved it. It was a scope issue after all. Thank you very much for the
help and quick responses.
Regards
Georgia
2016-02-07 14:27 GMT+00:00 Matt Lewis<EMAIL_ADDRESS>
Closing, LMK if you're still having issues.
—
Reply to this email directly or view it on GitHub
https://github.com/mattlewis92/angular-bootstrap-calendar/issues/275#issuecomment-181022109
.

Great to hear! :smile:


Don't run as root

Fixes #131.
@elyscape this should actually run the tests.

This is definitely simpler, and seems to work. Hitting same issue as my branch did, though, whereby some tests rely on running as root, so will need to tweak tests somehow.


fix(browser): allow immidiate reinvalidation of mocked dependencies

Description
Fixes #6105

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
[ ] Ideally, include a test that fails without this PR but passes with it.
[ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

[ ] Run the tests with pnpm test:ci.

Documentation

[ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

[ ] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

This looks like it was the last bug before I can port my app to browser mode! Can you release 2.0.3 please?


Opening balance accounts payable and receivable listing

[x] Exchange rate not displayed
[x] Debit and credit Amount need to displayed in base currency with currency code.
[x] Pagination

Issue closed


Fabric 2.4 binding can get stuck waiting for unfinished transactions

On running tests on occasion the following can happen
2022.05.13-13:06:13.776 info  [caliper] [default-observer]      [get-asset-evaluate-100 Round 3 Transaction Info] - Submitted: 21 Succ: 20 Fail:0 Unfinished:1
2022.05.13-13:06:18.777 info  [caliper] [default-observer]      [get-asset-evaluate-100 Round 3 Transaction Info] - Submitted: 21 Succ: 20 Fail:0 Unfinished:1
2022.05.13-13:06:23.778 info  [caliper] [default-observer]      [get-asset-evaluate-100 Round 3 Transaction Info] - Submitted: 21 Succ: 20 Fail:0 Unfinished:1
2022.05.13-13:06:28.779 info  [caliper] [default-observer]      [get-asset-evaluate-100 Round 3 Transaction Info] - Submitted: 21 Succ: 20 Fail:0 Unfinished:1
2022.05.13-13:06:33.780 info  [caliper] [default-observer]      [get-asset-evaluate-100 Round 3 Transaction Info] - Submitted: 21 Succ: 20 Fail:0 Unfinished:1
2022.05.13-13:06:38.781 info  [caliper] [default-observer]      [get-asset-evaluate-100 Round 3 Transaction Info] - Submitted: 21 Succ: 20 Fail:0 Unfinished:1
2022.05.13-13:06:43.782 info  [caliper] [default-observer]      [get-asset-evaluate-100 Round 3 Transaction Info] - Submitted: 21 Succ: 20 Fail:0 Unfinished:1
2022.05.13-13:06:48.784 info  [caliper] [default-observer]      [get-asset-evaluate-100 Round 3 Transaction Info] - Submitted: 21 Succ: 20 Fail:0 Unfinished:1
2022.05.13-13:06:53.786 info  [caliper] [default-observer]      [get-asset-evaluate-100 Round 3 Transaction Info] - Submitted: 21 Succ: 20 Fail:0 Unfinished:1
2022.05.13-13:06:58.787 info  [caliper] [default-observer]      [get-asset-evaluate-100 Round 3 Transaction Info] - Submitted: 21 Succ: 20 Fail:0 Unfinished:1
2022.05.13-13:07:03.789 info  [caliper] [default-observer]      [get-asset-evaluate-100 Round 3 Transaction Info] - Submitted: 21 Succ: 20 Fail:0 Unfinished:1
2022.05.13-13:07:08.790 info  [caliper] [default-observer]      [get-asset-evaluate-100 Round 3 Transaction Info] - Submitted: 21 Succ: 20 Fail:0 Unfinished:1

This also happens for transactions that are submitted. As this example is evaluate it looks like the evaluate call is never unblocked even though a timeout of 60 seconds is given to evaluate it appears to not fire and so caliper hangs waiting for an unfinished transaction which never completes
This isn't likely to be an issue with caliper or the connector implementation however it causes caliper a lot of problems if it does occur (and it's also been seen in other scenarios).
There are several options here

re-think the need for a caliper-worker to wait for unfinished transactions or put a time limit on it
have the base connector implement it's own timeout on submit calls
have the fabric connectors set a timer around the call as well as use the timers from the sdk so the connector can ensure it really does timeout

I was able to recreate this quite frequently on grpc-js 1.6.7 and seems to be less frequently on 1.4.2. I was also running caliper in the current docker container setup of node:14.19-alpine  if I added a console.log to caliper-worker when it submits a transaction in the SetImmediatePromise call then I couldn't recreate the problem. It's very odd and going to be a nightmare to track down is it is so intermittent

Ok, I think I may have found the issue which would affect all SUTs. txFinished in the transaction-statistics-collector has a situation where it won't mark the transaction as finished, also the time comparison should be >=, not > as time granularity in node is not going to be good enough on a fast machine.

Also found a big potential issue with the implementation of the TxObserverInterface, so will raise an issue for that but doesn't have to be fixed for 0.5.0

Hi I am still facing the same issue 2 years later on the latest caliper version and latest fabric version.
2024.05.04-08:27:49.706 info  [caliper] [default-observer] 	[Read asset fixed-rate-2 Round 3 Transaction Info] - Submitted: 601 Succ: 600 Fail:0 Unfinished:1 2024.05.04-08:27:54.706 info  [caliper] [default-observer] 	[Read asset fixed-rate-2 Round 3 Transaction Info] - Submitted: 601 Succ: 600 Fail:0 Unfinished:1 2024.05.04-08:27:59.708 info  [caliper] [default-observer] 	[Read asset fixed-rate-2 Round 3 Transaction Info] - Submitted: 601 Succ: 600 Fail:0 Unfinished:1 2024.05.04-08:28:04.708 info  [caliper] [default-observer] 	[Read asset fixed-rate-2 Round 3 Transaction Info] - Submitted: 601 Succ: 600 Fail:0 Unfinished:1 2024.05.04-08:28:09.709 info  [caliper] [default-observer] 	[Read asset fixed-rate-2 Round 3 Transaction Info] - Submitted: 601 Succ: 600 Fail:0 Unfinished:1 2024.05.04-08:28:14.710 info  [caliper] [default-observer] 	[Read asset fixed-rate-2 Round 3 Transaction Info] - Submitted: 601 Succ: 600 Fail:0 Unfinished:1 2024.05.04-08:28:19.712 info  [caliper] [default-observer] 	[Read asset fixed-rate-2 Round 3 Transaction Info] - Submitted: 601 Succ: 600 Fail:0 Unfinished:1 2024.05.04-08:28:24.713 info  [caliper] [default-observer] 	[Read asset fixed-rate-2 Round 3 Transaction Info] - Submitted: 601 Succ: 600 Fail:0 Unfinished:1 2024.05.04-08:28:29.714 info  [caliper] [default-observer] 	[Read asset fixed-rate-2 Round 3 Transaction Info] - Submitted: 601 Succ: 600 Fail:0 Unfinished:1 2024.05.04-08:28:34.715 info  [caliper] [default-observer] 	[Read asset fixed-rate-2 Round 3 Transaction Info] - Submitted: 601 Succ: 600 Fail:0 Unfinished:1 2024.05.04-08:28:39.717 info  [caliper] [default-observer] 	[Read asset fixed-rate-2 Round 3 Transaction Info] - Submitted: 601 Succ: 600 Fail:0 Unfinished:1 2024.05.04-08:28:44.717 info  [caliper] [default-observer] 	[Read asset fixed-rate-2 Round 3 Transaction Info] - Submitted: 601 Succ: 600 Fail:0 Unfinished:1


Dev

Codecov Report

Merging #67 (093d01a) into master (a2aae17) will increase coverage by 0.76%.
The diff coverage is 70.09%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   84.83%   85.59%   +0.76%
==========================================
  Files          12       13       +1
  Lines        1721     1715       -6
==========================================
+ Hits         1460     1468       +8
+ Misses        261      247      -14

Impacted Files
Coverage Δ

pyrekordbox/db6/tables.py
95.90% <45.45%> (-0.46%)
:arrow_down:

pyrekordbox/db6/database.py
73.09% <60.00%> (+3.46%)
:arrow_up:

pyrekordbox/db6/registry.py
77.46% <77.46%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Expected header x-api-key in curl preview, but got X-Api-Key

Expected Behavior
In the curl preview
curl --request GET \
  --url https://api.datamesh-manager.com/api/dataproducts \
  --header 'x-api-key: '

Actual Behavior
In the curl preview
curl --request GET \
  --url https://api.datamesh-manager.com/api/dataproducts \
  --header 'X-Api-Key: '

Reproduction steps
With an openapi.yaml like this:

components:
  securitySchemes:
    ApiKeyAuth:
      type: apiKey
      description: ...
      in: header
      name: x-api-key

### Link to site / OpenAPI Spec

https://app.datamesh-manager.com/openapi.yaml

### Version

the latest via CDN

### What browsers are you seeing the problem on?

Chrome

Thanks for reporting! Isn’t it the same, though?

According to HTTP specification header names are case-insensitive, so content-type is the same as Content-Type.
https://www.rfc-editor.org/rfc/rfc9110.html#section-5.1-3

Ah, I was not aware of that. Still, to me, it felt strange that it doesn't reuse the header field name exactly as I specified it. Why change it / capitalize it? But this is probably more a matter of taste/opinion, so closing this.


adb.exe System error

After trying command prompt.on the directory scrcpy- its shows " The program can't start because api-ms-win-crt-string-l1-1-0.dll is missing from your computer. try reinstalling the program to fix this problem" .. i think this issue need to fix..

[ ] I have read the FAQ.
[ ] I have searched in existing issues.

Environment

OS: [e.g. Debian, Windows, macOS...]
scrcpy version: [e.g. 1.12.1]
installation method: [e.g. manual build, apt, snap, brew, Windows release...]
device model:
Android version: [e.g. 10]

Describe the bug
A clear and concise description of what the bug is.
On errors, please provide the output of the console (and adb logcat if relevant).
Please paste terminal output in a code block.

Please do not post screenshots of your terminal, just post the content as text instead.

https://answers.microsoft.com/en-us/windows/forum/all/api-ms-win-crt-string-l1-1-0dll-is-missing-in/bb0b23b8-83ec-4fd8-b912-23c81351b5e7


Add higher-order component connectHistory()

This adds a connectHistory higher-order component that makes the history object accessible via props to a wrapped component.
I took my best guess and named the passed-in prop history. A warning is logged if it ends up overwriting an existing prop.
connectHistory
Proposed API:
import { connectHistory } from 'react-router'

class MyComponent extends React.Component {
  handleClick () {
    this.props.history.pushState(null, '/some/path')
  }
  render () {
    return
 this.handleClick()}>Click Me!

  }
}

export default connectHistory(MyComponent)

I've done my best to follow the repo's practices and guidelines. Let me know if you need adjustments. If this looks good I'm happy to modify the documentation and/or CHANGES.md.

I dislike using a wrapping component for this pattern. This came up a few times in discussion on Discord and also at https://github.com/rackt/react-router/issues/2364#issuecomment-150825015. The alternative approach I'd proposed of just adding the history entry to contextTypes and injecting it via e.g. a property is also imperfect.
Mostly, though, I don't see this as a pattern that's worth encouraging - I think pulling the history object directly from context is just fine.

@taion : The problem with building directly off of context is that although the API is finally documented, it's clearly labelled experimental and its general use is cautioned against. Isolating its use to library code makes it easy to adjust to whatever might change. Using it in hundreds of isolated instances across my project becomes a significant liability.
Regarding your concern about static or public methods. Anecdotally, I guess I just haven't seen that become a major problem. Wrapped components tend to be used occasionally for special behaviors, and it's not difficult to separate that from components with methods that would be problematically obscured. Between that and depending directly on an experimental feature, this seems to me like the lesser of two evils.

Nevertheless this is the formally documented solution: https://github.com/rackt/react-router/blob/v1.0.0/docs/API.md#but-im-using-classes
Just adding a wrapper component there is not obviously the correct answer - among other things you break people trying to access instance methods via refs, and you hide static methods as well, and become much more susceptible to issues with e.g. ordering of your wrappers.
It's not a good approach to take here.

@taion : Agree to disagree. From my perspective you're talking about scenarios that are applicable only in rare situations and bad practices to employ generally. If you're rejecting the PR, that's fine. No hard feelings, I'll probably just publish the hoc as separate module.

Nevertheless they're ones we have to think of here. It's not acceptable to expose APIs to users that expose edge cases like with using wrappers to effectively inject a non-dynamic property - not without a very good reason, which we just haven't got in this case.
I can leave this open to solicit further comment but I'd have to see stronger arguments than what you've put forth in favor of this approach over just using this.context.history or modifying the class in-place to be happy with merging this.

I'm closing this for now, with an additional note that I strongly discourage using the wrapper component pattern for this sort of use case.

Oh, context is documented now, so yeah, people can just grab it off of context.

For anyone stumbling over this who's still interested in higher-order-component versions of the mixins, I made this: https://github.com/dlmanning/react-router-ad-hocs

Fair enough, but I still recommend against using HoCs for just getting history off context.

@taion : And I'd strongly recommend against using context in application code at this point. We disagree. It happens. :)

I am making my comment in my capacity as a member of this project. This is not really a matter of personal taste - it's categorically incorrect in this context.

@taion Dude, I think anyone possibly reading this gets exactly what you think about my solution.

That's not really the point. I am not making the statement that "I personally dislike the solution you have as a subjective matter".
I am making the statement that "I believe your solution is objectively worse". I really want to make this distinction clear - obviously I have no control over what you do in your application code; my concern is for users who stumble across this via e.g. Stack Overflow or something in the future and find them directed toward a bad solution; hence the need to be extremely clear here.
Obviously everyone on this thread knows what I think; this isn't for our benefit.

@taion : I'm not sure how you believe it's possible to transcend your own personal tastes. I happen to believe that your solution is objectively worse. I think you're unnecessarily creating a pain point for your users and that your advice is for them to write application code on an unstable feature that's really likely to turn into a liability in the long run. I think you're doing a bad job in your capacity as a collaborator and that you're being more than a little rude about it.
But that's my opinion, and I recognize it as such. I could be wrong. In the end, there are vastly more important things to worry about in the world. I'm done with this now. Be well.

I'm personally still interested in the pattern so I'm glad to see https://github.com/dlmanning/react-router-ad-hocs. Thanks @dlmanning
Since context is documented, and the API we expose there is already exposed as API via props, its the current recommendation for accessing deeper in the app hierarchy. (The less API we have to maintain, the better.) As the react community continues to work with context, perhaps we'll have a different solution later, but for now we just use plain old stuff that react provides.
@taion this thread makes me pretty sad, its probably the first one on the project that turned into a meta conversation about the conversation (the worst!) which I think was triggered by too much opinion. This comment never needed to exist:

Fair enough, but I still recommend against using HoCs for just getting history off context.

The issue was closed and he provided a way for other people interested to try it out; we don't need to express opinions on the best way to access things on context. This project is pretty opinion-less on the greater React ecosystem, we just want to provide the primitives so people can try out whatever they'd like.
In other words, we can reject a PR for the router w/o rejecting the idea for React app (take it to twitter :P)
Interacting with contributors like this will absolutely discourage any future contributions, and for newer devs, it may crush their confidence in contributing to open source completely :cry:
I'm grateful for every contribution anybody makes (especially yours!); a respectful, open-minded conversation about tradeoffs with any PR is important to have--even if you already have a strong opinion on the matter.
With that said, there would be no 1.0 without you, thank you thank you thank you :bow:

My apologies, @dlmanning and @ryanflorence. I'm in the wrong here. I'd be happy to delete my intemperate comments above.
This is one of those things that has been a bit touchy for me in the past - pretty much as soon any library I've worked with exposes an HoC-style API unnecessarily, people start being confused by why their class static properties get hidden.
You're definitely right in that this pattern is one that does have positive tradeoff elements, such as support for stateless components. I'll agree that it's worth exploring (though by people other than me, obviously).

@taion thanks. ☮

<3 <3 <3


Integration with vimwiki

I just recently noticed your calendar plugin, and I am impressed. It looks amazing!
However, there is one major feature that I miss, and that is implemented in Matsumotos calendar plugin: A calendar action hook. This hook is used by vimwiki to let the function vimwiki#diary#calendar_action open the current chosen date with <cr>.

Has there been any update regarding this matter? I would love to be able to mark a day that has a diary entry.


iOS to iOS device not working

I did not any change of your code, Just install in two iOS devices. Room connection is the success but there is no video or audio.
It is mentionable that iOS device to Andriod device, iOS device to Web, iOS device to simulator working fine .
Did you face same kind or similar kinds of problems?

How you solved it? I have same error

I am sorry I could not solve this issue, rather I postponed this project. If you will have solved this issues please inform me.


Add files via upload

The file here look correct now?
https://github.com/cxndao/constellation/tree/main/docs/Town Hall Artifacts


Coding Standard & HHVM

A question for every active person around here, especially @lox  and @aik099 :
I would like to define a coding standard for this project and connect it to a tool like scrutinizer to automatically check it (and autofix most issues). The reason for a coding standard should be obvious and I prefer PSR2 as I'm used to it but I am of course open to suggestions. The tooling just takes away the pain and in case of scrutinizer comes with the benefit of a coverage overview and allows us to track the progress.
Any thoughts or other tools you would like to see?
And I would like to remove the "allow_failures" from hhvm in the travis build as a statement that hhvm is officially supported. Any obstacles on that?
---- List: ----

scrutinizer (coding standard analysis & fixes)
coveralls.io (coverage reports with PR commenting)

Added external code coverage integration to scrutinizer.
So now we have coverage available but I'm going to leave this open until @brianium has time to integrate coveralls.io


Switch to upper case identifiers

Fixes #35

@taylor-cedar, this isn't completely polished but please apply the patch to your install and see if it allows you to proceed with your testing.

Hey Tim, I tested this change and I am seeing errors only with DEBUG=True. DEBUG=False seems to work great.
 File<EMAIL_ADDRESS>line 126, in __exit__
    next(self.gen)
  File "/Users/thakes/code/test_django/env/lib/python3.9/site-packages/django/db/backends/utils.py", line 113, in debug_sql
    sql = self.db.ops.last_executed_query(self.cursor, sql, params)
  File "/Users/thakes/code/test_django/django_snowflake/operations.py", line 133, in last_executed_query
    return cursor.query
AttributeError: 'SnowflakeCursor' object has no attribute 'query'

@timgraham Nice! Working perfectly now.


Feat synth converter

duplicate with https://github.com/sdsc-ordes/cat-plus-zarr-converters/pull/8


More steps

Hopefully the above steps are easy to follow app developers using VSTS, As Infra people may not be able to do. Please add more screen shot and step by step statement will help infra people who is testing / evaluating Azure stack hybrid App.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a0e54ed0-e139-1569-adc8-1833de468eb9
Version Independent ID: 7101f8d8-3828-959a-db7c-fb73104b9949
Content: Deploy your app to Azure and Azure Stack
Content Source: articles/azure-stack/user/azure-stack-solution-pipeline.md
Service: azure-stack
GitHub Login: @jeffgilb
Microsoft Alias: jeffgilb

Thanks for reporting! I have assigned the issue to the author to investigate and update as appropriate.

Thank you for the feedback, passing this on to the current writer, @mattbriggs .

@Velmurugan-n Thank you for the feedback on this article. I have this article in my next bundle of work to be updated. The update will take some time, but I will keep in mind what you were hoping to get out of the topic, that is a workflow for system admins who are validating the workflow for their devs or for evaluation. After I update, I hope you can see if it meets your needs. Thanks!
#please-close