[DevCenter] API Review

New API Review meeting has been requested.
Service Name: DevCenter
Review Created By: Chris Miller @chrissmiller
Review Date: 1/26/2023 4:00 PM PT
PR:
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: here
Description: API review for 2023-01-01-preview public preview API spec for Azure DevCenter. Our service has been previously deployed and is released to users in public preview.
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@chrissmiller Could you please link the PR to be reviewed here, or if there is no PR any other materials we can use to prep for the meeting.

@chrissmiller Could you please link the PR to be reviewed here, or if there is no PR any other materials we can use to prep for the meeting.

@mikekistler Here is the link to our draft PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/10832. We'll finalize the changes in there and publish the PR after our internal team review of the spec changes this afternoon.

Notes from API review meeting Jan 26, 2022

Is the model polymorphic?  No, but action type is an extensible enum
httpStatusCode? Consider a more generic name.
consider errorDetails -> error
Is the restart post action idempotent? Consider supporting OASIS repeatability headers.
catalogItems or items? Items might be marginally better.

PR was signed off -- closing this as complete.


terraform epoll_wait high cpu utilization

This bug-tracker is monitored by developers and other technical types.  We like detail!  So please use this form and tell us, concisely but precisely, what's up.  Please fill out ALL THE FIELDS!
If you have a feature request, please post to the UserVoice.
If this is a console issue (a problem with layout, rendering, colors, etc.), please post to the console issue tracker.
Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues.  Instead, send dumps/traces to<EMAIL_ADDRESS>referencing the GitHub bug number. Ideally, please configure your machine to capture minidumps, repro the issue, and send the minidump from "C:\Windows\minidump".

Your Windows build number:  (Type ver at a Windows Command Prompt)

Microsoft Windows [Version 10.0.16299.431]

What you're doing and what's happening:  (Copy&paste specific commands and their output, or include screen shots)
I am using terraform to start virtual infrastructure in aws. while terraform is waiting for input, it experiences very high cpu utilization. this appears to be related to epoll_wait.
the WSL version of terraform experiences this high cpu, where as the windows version does not.

I am quite aware that the developers are not necessarily familiar with terraform, but this issue no longer appears to be a terraform but instead an issue with how WSL handles the epoll_wait calls.
terraform apply

screen shots
WSL version show very high cpu while waiting for use input

windows version of terraform showing non high cpu

terraform -v
Terraform v0.11.3
+ provider.aws v1.21.0

WSL / ubuntu for windows (on windows 10 build 1709)
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.3 LTS
Release:        16.04
Codename:       xenial

terraform mainfest
# ca04test01
resource "aws_instance" "ca04test01" {
	key_name = "${var.keypair}"
	ami = "${var.ami_xenial}"
	instance_type = "${var.server_type["ca04test01"]}"
	subnet_id = "${var.subnet_production["ent_app_preprod"]}"
	private_ip = "${var.server_ip["ca04test01"]}"
	# vpc_security_group_ids has to be a list, so enclose in [] to make it a 1 item list
	vpc_security_group_ids = ["${var.sg_production["ent_app_preprod"]}"]

	lifecycle {
		ignore_changes = ["tags"]
	}
	count = "1"
	user_data = "#cloud-config\nhostname: ca04test01.agilitypr.internal\nfqdn: ca04test01.agilitypr.internal"

	tags {
		type = "test"
		role = "test"
		Name = "ca04test01"
	}

	provisioner "remote-exec" {
		inline = [
			"printf '\n${var.server_ip["ca04test01"]} ca04test01.agilitypr.internal' | sudo tee -a /etc/hosts",
			"sleep 1" # trick to get terraform to finish above command before closing ssh conn
			# command || true # force command to exit and allow terraform to continue
		]
		connection {
			type = "ssh"
			user = "ubuntu"
		}
	}
}

What's wrong / what should be happening instead:

While waiting for user input the application should not be using very high cpu

Strace of the failing command, if applicable:  (If some_command is failing, then run strace -o some_command.strace -f some_command some_args, and link the contents of some_command.strace in a gist here)

straces gist:
https://gist.github.com/jgrammen-agilitypr/47bf7baa6d81b1bbccd6e9189c047aff
See our contributing instructions for assistance.

ok, I will attempt to get an environment setup on the insider release of windows to test.

I will attempt to get an environment setup on the insider release of windows to test.

This one is awkward because WSL improved from FCU 16299 and April Update 17134, but #3191 is still under investigation. If it were me I would try 17134 stable first not insiders. Or try both if you are feeling highly motivated. Your problem could be fixed in 17134 but broken on the most recent insiders (17682 as of this writing). Or it could be an unrelated problem and spin in both. [Or, it could even be, albeit less likely, an unrelated problem and work fine in both 17134 and 17682, but not 16299.]

what are the next steps in debugging this issue so that it can be resolved? debug logs? straces?

I also suspect this is the same as #3191 which is understood. There is an issue with large writes to non-blocking unix sockets that will cause them to always return EAGAIN.

It was almost duped right out of the gate. The ambiguity was caused by this (from #3191):

Tested and succeeded in 17134 and 17661.

The OP here is 16299.

@therealkenc - indeed, that is quite an oversight on my part; likely unrelated issues.

@jgrammen-agilitypr I downloaded a terraform binary and tried the example and did not see any CPU usage while it was prompting for the first value. Does this work for you as well?

@Brian-Perkins the example you used, does not get far enough into the terraform process to actually cause problems.
you need something closer to the example posted at the beginning of this thread.
I am linking to a gist which contains a more complete project example:
https://gist.github.com/jgrammen-agilitypr/57b00d549c73a276fa5b0e0d448aa3f7
All of thoes files go in a folder, in my case named "test". inside the folder you run 'terraform init', to setup the aws provider.
You need to fill in the masked variables (eg: server_ip, sg_production, subnet_production, access_key, secret_key etc )
The example just creates an amazon ec2 nano instance, running ubuntu 16.04 xenial.

Unfortunately it looks like that sample actually tries to connect to AWS as I am getting an error that the security token is invalid. So a repro from my side is seeming less likely. @jgrammen-agilitypr can you update your strace output with a "-f" as the original doesn't appear to contain the problematic loop. For starters I am mostly interested in what file type is causing the epoll_wait to always be ready so that I can at least narrow down the problem-space.

Doing this need-repro so it doesn't float indefinitely. Needs something self-contained (which I think is possible with terraform).

I apologize for the delay, I must have missed the notification of your comment.
I have attached a strace with -f. The file was too large for gist, so I am uploading a zipped copy here
terraform_test_project.zip
the command run was
strace -o terraform_test_project.strace -f terraform apply

You can reproduce it with this
mkdir repo
main.tf
resource "local_file" "foo" {
  content = "foo"
  filename = "${path.module}/foo.txt"
}

This will create a file called foo.txt with the contents "foo". If the file exists remove it, run terraform apply and wait at the prompt, in WSL I get 25% CPU utilisation in kernel mode - I have 2 cores, with hyperthreading so 4 processors, the utilisation is balanced across all 4 processors - in effect at any point in time one CPU is 100% utilisation but there's no affinity to one CPU so over time it is spread across all CPUs and looks like 1/N utilisation.

Much better, thanks @berney. You didn't say what version of Windows 10 you are on. If it still spins on 17704 (which you'll inevitably be asked to try) then that is a good repro.

Sorry, I updated my comment above to state I'm on Windows 1803 (OS Build 17134.112) and using Terraform v0.11.7 in WSL.

I have tested @berney 's reproduction steps in insiders build 17704
and get very high cpu usage.

terraform -v
Terraform v0.11.7
+ provider.local v1.1.0

windows version
C:\Users\test>ver

Microsoft Windows [Version 10.0.17704.1000]

WSL
test@DESKTOP-668DBNN:/mnt/c/Users/test/Desktop/local$ lsb_release -a
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.4 LTS
Release:        16.04
Codename:       xenial

I have tested @berney 's reproduction steps in insiders build 17704

Thanks, much appreciated. That's kind of what I figured, because this issue didn't seem to be dupe #3191 from the get-go. The devs will have to take a look from here.
Pro-tip: In general you can increase the chances of that happening by providing CLI repro steps from clean install, the first step often being either wget or apt. Think something a six year old can cut and paste into a terminal. Brian seemed to have Terraform at least limping along so that might not be necessary here.

Ok, thanks for the pro tip.
If dev's need more information or debug logs etc, ask away and I will do my best to provide what I can.

This is an issue with pipes and the EPOLLET epoll event flag, where the EPOLLET part is not being respected so the epoll_wait always returns immediately.

Testing on build 17728 ( somehow it skipped 17723 ) confirms that the issue with high load is fixed.


Feature Request: Ability to pass in a Hyperdrive instance

Use Case
Use a browser based hyperdrive/indexeddb instance as the filesystem for enoki content. I'd still like to serve my site over standard HTTP to regular browsers but not rely on the content.json file to provide my content. This would also allow me to write to the drive from regular browsers as well. If I could pass a custom hyperdrive instance, I could do something like the following.
const hyperdrive = require('hyperdrive')
const rai = require('random-access-idb')('db')
const Enoki = require('enoki')

const archive = hyperdrive(rai)
const enoki = new Enoki(archive, defaults)
...

Honestly not sure how feasible this would be, but it seems like it could work and allow for some more flexibility when wanting to use enoki in environments like standard browsers/PWA's and cordova apps where fs access is not available and neither would the DatArchive API's.
Thoughts?

I stumbled across @RangerMauve 's dat-polyfill and it might provide a simpler way of doing what I need, and would be easier to integrate here.

Yeah, the Dat Polyfill is made exactly for this use case. :D Feel free to reach out if you want help setting it up.

@RangerMauve mind if I ping you on Gitter?

Of course! I work 9-5 EST, but I can reply I'm between tasks


UX: Make connection between "Documentation" and the actual errors more clear

I just scanned a webproject we made and I can see a lot of errors like

this makes me think of why is the x-xss-protection header not needed? in the first place its a security header and its not obvious why I should not use them (or maybe its a more complex context here which I dont know about and needs explanation?)

origin issue: https://github.com/sonarwhal/sonarwhal/issues/682#issuecomment-348187171

@staabm For every error, there is a documentation link that should provide all the information related to that specific test (e.g.: for x-xss-protection header not needed)

ohh wow, its such a huge button and my brain wasnt able to get the connection between each error below and this button... I guess this means we should do something about it.
Proposal:

I guess things would be easier when the "docu" symbol would appear when hovering with the mouse over a error-msg. that way the user has a indicator that there is some info available which is directly related to the error being shown.

especially for error messages which are far more away from the "Documentation" button, the benefit is getting obvious

@ststimac @sonarwhal/core Thoughts?

I don't think we should add an icon to every error. Some people have 200+ errors and that will just be a bit redundant.
We can try making the rules themself a link, but there was also a suggestion to add another call to action to take users to the documentation at the bottom of the results, which I think would be helpful for when some rules have a long list of errors and the documentation button disappears from view as users scroll down.

I don't think we should add an icon to every error.

I agree.

We can try making the rules themself a link,

:+1:
Just so that there is no confusion, we are referring to also making the following parts point to the documentation:

@staabm Thoughts? Do you think that would make it more clear / easy for new users such as yourself?

Depends on the styles applied to this headline I guess


No matching distribution found for pyside2

Any idea how to solve this? It seems to be a problem where PySimpleGUIQt doesn't play nicely with pyside2. I tried downgrading my condo env to 3.9 but no luck.

is it in a windows or mac?
As far as I know, when users do a fresh env with python=3.10 (or 3.9) and install dependencies with pip install -e . it works fine.
if you have pyside2 before installing pysimplegui there might be incompatibility issues

It's a mac. Let me blow away my env and try again!

mac has issues, i could not get it going. u can try compiling from scratch.

Yeah with Mac pip install DisocrdAlertsTrader gives problems. Better do git clone and then follow the readme.md instructions, a couple of days a mac user installed it without issues after creating a new env without old dependencies

pyside2 isn't supported on Mac M-chips. i've run into the same problem now


Allow users to define cluster-scoped BuildTemplates

Some cluster operators might want to provide and manage predefined build templates, available across all namespaces.
We should create a ClusterBuildTemplate resource type which is available cluster-wide.
Questions

If a user creates a BuildTemplate in their namespace with a conflicting name with an existing ClusterBuildTemplate should we allow that or reject it?
If we allow it, a Build would have to specify template.name: 'some-namespace/the-template' to specify the namespaced template.
If we disallow it, creating a new ClusterBuildTemplate would have to look for a conflicting name across all namespaces.

I'm not familiar enough with Kubernetes API ClusterFoo idioms to know which is more consistent, hoping for pointers from those with more experience.

I will work with the following assumptions:

We should reject a BuildTemplate with a conflicting name.
The create ClusterBuildTemplate also should check existing namespaces and give an error on conflict.

This is more in line with the general pattern of Resources not allowed in both Cluster and Namespace scopes

wouldnt that be a racy check?
Sent from my iPhone

On Aug 20, 2018, at 9:58 AM, Nader Ziada<EMAIL_ADDRESS>wrote:
I will work with the following assumptions:
We should reject a BuildTemplate with a conflicting name.
The create ClusterBuildTemplate also should check existing namespaces and give an error on conflict.
This is more in line with the general pattern of Resources not allowed in both Cluster and Namespace scopes
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@pivotal-nader-ziada no idea, i was thinking there would be more established way of doing this in kubernetes apis.
i was just looking at how ClusterRole vs Role in kube rbac is referenced (https://kubernetes.io/docs/reference/access-authn-authz/rbac/). looks like they use roleRef that contains kind key which could be ClusterRole or Role. (though they also have apiGroup).
may be adding templateKind: ClusterBuildTemplate | BuildTemplate (default) next to template (which currently specifies name) is better instead of trying to do name check trickery. alternatively can add templateRef that could be used mutually exclusively with template for more advanced cases?

@cppforlife Thanks, I like the idea of adding the templateKind

Agreed, working on adding a template kind field to the build type instead of checking existing names as per @cppforlife and @evankanderson suggestion


[question] slotchange event and component lifecycle in Safari.

Hi All,
I've a question relating to component lifecycle and listening to slotchange events.
I have created a basic component to describe my findings.
The component has two slots; one default and another named slot called "contents". I have added a slotchange event to both slots as I'm interested to know if the slots have changed.
In both Chrome and Firefox the slotchange events are handled as I expected.
Safari seems to handle the component lifecycle a little differently. Safari handles the slotchange event before the connectedCallback is called.
index.html
<!DOCTYPE html>

  <meta charset="UTF-8">
  <title>Custom Component Test</title>

  <my-lit-element>

I'm in the default slot

I'm in the named slot

  </my-lit-element>

CustomLitElement.js
import {html, render} from 'lit-html';

class CustomLitElement extends HTMLElement {
  constructor() {
    super();
    const shadow = this.attachShadow({ mode: 'open' });
    render(this.template(), this.shadowRoot);
  }

  template() {
    return html`

Custom Component using lit-html

        <slot id="default-slot" @slotchange=${this}></slot>

        <slot id="named-slot" name="contents" @slotchange=${this}></slot>

 `;
  }

  handleEvent(event) {
    if (event.target.id === 'default-slot') {
      console.log(`slotchange event on default slot`);
    }
    if (event.target.id === 'named-slot') {
      console.log(`slotchange event on named slot`);
    }
  }

  connectedCallback() {
    console.log('connectedCallback - my-lit-element');
  }
}
window.customElements.define('my-lit-element', CustomLitElement);

Chrome

connectedCallback - my-lit-element
slotchange event on default slot
slotchange event on named slot

Firefox

connectedCallback - my-lit-element
slotchange event on default slot
slotchange event on named slot

Safari

slotchange event on default slot
slotchange event on named slot
connectedCallback - my-lit-element

If I move the render function from the constructor to the connectedCallback I will not get the slotchange event, as the mutation (in Safari) happens before the connectedCallback, which is before I've called the render, and registered interest in the slotchange event.
What is the correct order?
Where should I perform the initial render?
Is Safari handling things incorrectly ?
Any help would be appreciated :)

This might be a Safari bug. In general if you want to get light DOM children, we've found you need to get an initial set with assignedNodes() as well as listen to slotchange

Actually it is a Safari Bug, https://github.com/whatwg/dom/issues/447

Thanks @justinfagnani, that pointer really helped.
Thanks too, @mzeiher I'll keep an eye on this.
Out of curiosity should I perform the initial render in the constructor or in the connectedCallback?

This might be a Safari bug. In general if you want to get light DOM children, we've found you need to get an initial set with assignedNodes() as well as listen to slotchange

@katejeffreys note to self for docs

Just my humble opinion, but I think Safari got it right and the issue is page load.  When the html gets parsed, and before any user interaction or external scripts can be run on that element, how does one know what elements were part of the page and which may have been added later?  The answer in Safari is - "you know when connectedCallback fires", but for other browsers, you don't know without a more hack-ish solution.

It sounds like the spec has been updated since this bug was filed, so browsers should be firing slotchange consistently. And the LitElement API has changed as well, so unless anyone feels strongly that there's something to document here, I'm going to mark this as stale.

OK, we don't have "Stale" or "wontfix" labels, so I'm going to label it "More Info Needed." :D

Please reopen if this issue is still relevant.


I can not use it

I can use Xamarin.Forms.Maps without problems but if I want to use Xamarin.Foms.GoogleMaps only shows me:

My packages:

This is expected behaviour

Ok, then how do I do it to be displayed?

You should call Xamarin.FormsGoogleMaps.Init in your MainActivity.cs(Android) and AppDelegate.cs(iOS)

https://github.com/amay077/Xamarin.Forms.GoogleMaps/blob/master/XFGoogleMapSample/Droid/MainActivity.cs#L24
https://github.com/amay077/Xamarin.Forms.GoogleMaps/blob/master/XFGoogleMapSample/iOS/AppDelegate.cs#L16

Also setting Google Maps API Key each platforms.

https://github.com/amay077/Xamarin.Forms.GoogleMaps#usage

Same problem here.

Oh! I just remove, clean and add again (1.7.1). This was before:
Xamarin.FormsMaps.Init(this, savedInstanceState);
But Xamarin Studio was still compiling. Now I changed it for:
Xamarin.FormsGoogleMaps.Init(this, savedInstanceState);
Working fine.

Xamarin.FormsMaps.Init is XAMARIN OFFICIAL Map component's method.
Xamarin.FormsGoogleMaps.Init is MY PRODUCT Map component(called Xamarin.Forms.GoogleMaps)'s method. 👍


[#359] Extend AWS Vpc helpers: GetVpcById

This is the code for the issue: #359
It extends the AWS Vpc module with GetVpcById, GetVpcByIdE, and GetVpcsE.
Backward compatibility is maintained. The test temporarily creates a Vpc.
Tests output: https://gist.github.com/kasia-kittel/ee1389f395fc85853105c47ad2022e1f

I addressed all comments in folling commits.

Looks good! Will kick off our build now.

Build passed, so going to merge this in and release. Thanks for your contribution!

https://github.com/gruntwork-io/terratest/releases/tag/v0.18.6


fix full type name in syntax

Change the parameter type in syntax. The type name should not be the full type name.
Change the related test cases.

@yishengjin1413,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


[ILLA App idea] Import CSV to PostgreSQL

Description
Upload a CSV and write it to your PostgreSQL database
Additional Information
Upload a CSV and write it to your PostgreSQL database

/assign @ayanjoshi


Don't color numbers in class names

This makes the digit in 'include apache2' use the same color.
i.e.: digits are colored only when starting a word.

Waiting for CLA signature by @sathieu
@sathieu - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/
Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html

My patch is trivial, it can be merged without CLA.

@sathieu can you prepend "(maint) " to the commit message. Our release scripts look through the commit messages for first lines starting with "(maint)" or "(PUP-1234)"-style beginning-of-lines, and croak if the commit message doesn't match.

@kylog done

Thanks for the contribution @sathieu!


[Bug]: backup list exchange does not return anything

What happened?
Following the instructions in the quickstart, I backed up a mailbox two times.  Using the returned backup IDs, I confirmed that I could restore the backups to restore folders in my mailbox.  However when I run the command ./corso backup list exchange I just get the following output:
Logging to file: /Users/eric.johnson/Library/Logs/corso/logs/2024-01-24T16-01-53Z.log
Connecting to M365                               done
Connecting to repository                      4s done
  ID                                    Started At            Duration    Status     Resource Owner
Connecting to M365                               done
Connecting to repository                      4s done

FWIW, as an experiment I ran the same command with an incorrect AWS token and also with an invalid repository password, and in both cases the log file showed the expected error.  However in the log file shown below for a correctly configured run, it appears to connect to the repository fine but then just doesn't give any output.
Corso Version?
Corso version: v0.18.0
Where are you running Corso?
MacOS 14.2.1
Relevant log output
2024-01-24T10:10:28.703-0600	DEBUG	logger/logger.go:415	seeding logger	{"logger_settings": {"File":"/Users/eric.johnson/Library/Logs/corso/logs/2024-01-24T16-10-28Z.log","Format":"text","Level":"debug","PIIHandling":"hash","LogStorage":false}}
2024-01-24T10:10:28.704-0600	DEBUG	config/config.go:126	initializing viper	{"config_file_path": "/Users/eric.johnson/.corso.toml"}
2024-01-24T10:10:28.704-0600	DEBUG	config/config.go:129	initialized config	{"config_file_path": "/Users/eric.johnson/.corso.toml"}
2024-01-24T10:10:28.704-0600	DEBUG	config/config.go:206	found config file	{"configFile": "/Users/eric.johnson/.corso.toml"}
2024-01-24T10:10:28.704-0600	INFO	cli/cli.go:69	cli command	{"command": "corso backup list exchange", "flags": ["log-level", "mask-sensitive-data"], "version": "v0.18.0"}
2024-01-24T10:10:28.704-0600	DEBUG	config/config.go:307	reading config from file	{"clues_trace": "968d7ce0", "viper_config_file": "/Users/eric.johnson/.corso.toml"}
2024-01-24T10:10:28.704-0600	INFO	observe/observe.go:275	Connecting to M365	{"acct_provider": "M365", "clues_trace": "660753ba", "acct_id": "7fb4cd0f9beb1a80", "storage_provider": "S3"}
2024-01-24T10:10:28.705-0600	INFO	graph/concurrency_middleware.go:49	turning on the concurrency limiter	{"storage_provider": "S3", "clues_trace": "660753ba", "acct_provider": "M365", "acct_id": "7fb4cd0f9beb1a80", "concurrency_limit": 4}
2024-01-24T10:10:28.708-0600	INFO	observe/observe.go:333	done - Connecting to M365	{"acct_provider": "M365", "clues_trace": "660753ba", "acct_id": "7fb4cd0f9beb1a80", "storage_provider": "S3"}
2024-01-24T10:10:29.197-0600	INFO	observe/observe.go:275	Connecting to repository	{"acct_id": "7fb4cd0f9beb1a80", "storage_provider": "S3", "acct_provider": "M365", "clues_trace": "660753ba"}
2024-01-24T10:10:33.166-0600	INFO	observe/observe.go:333	done - Connecting to repository	{"acct_id": "7fb4cd0f9beb1a80", "storage_provider": "S3", "acct_provider": "M365", "clues_trace": "660753ba"}

@eric-johnson-cp - can you try running the list command this with the --hide-progress flag added i.e. ./corso backup list exchange --hide-progress ?
It's possible the progress bar logic is clobbering the list output.

Success!  Yes, adding --hide-progress results in the expected output.  It must be as you guessed, that the progress bar is hiding the output, especially since I only have two backups in my list.

Thanks @OrhanTozan!  Would you also be willing to try out the above build?

@ryanfkeepers what is the status of this issue? Was your fix included in v0.19.0?

hi @OrhanTozan, the fix that was in the build linked in this ticket is included in the v0.19.0
I'm going to close this ticket as the fix has been released


Release maintenance/flocker 0.3.2/quickstart cli to client floc 1399

Fixes FLOC-1399

Looks good.

This is only a change to the docs so I think that the build failures are unrelated. Merging.


[BUG] Log message is not ideal on exhausting state space that is the image of View

Description
When you generate multiple counterexamples with --max-error=k, and a View operator, if it is not possible to generate at least k counterexamples then the log contains this line 'Found a deadlock. No SMT model.  E@14:57:23.621', which makes sense but is a bit confusing.
Input specification
------------------------------------ MODULE 2PossibleTraces -----------------------------
(*
There should be only two possible paths for x to reach 3
0 -> 1 -> 3
0 -> 2 -> 3
*)

EXTENDS Integers, FiniteSets, Sequences, TLC

VARIABLES
    \* @type: Int;
    x

\* @type: () => Bool;
Init == x = 0

ZeroToOne == x = 0 /\ x' = 1
ZeroToTwo == x = 0 /\ x' = 2
OneToThree == x = 1 /\ x' = 3
TwoToThree == x = 2 /\ x' = 3

ThreePlus == 2 < x /\ x' = x + 1

Next ==
    \/ ZeroToOne
    \/ ZeroToTwo
    \/ OneToThree
    \/ TwoToThree
    \/ ThreePlus

IsThree ==
    LET Desired == x = 3
    IN ~Desired

View == x
===============================================================================

The command line parameters used to run the tool
apalache-mc check --max-error=3 --view=View --inv=IsThree 2PossibleTraces.tla
Expected behavior
A nice log message like 'max counterexamples have been generated for the given view'
Log files
# Tool home: /usr/local
# Package:   /usr/local/mod-distribution/target//apalache-pkg-0.15.12-full.jar
# JVM args:  -Xmx4096m -DTLA-Library=/usr/local/src/tla
#
# APALACHE version 0.15.12 build 05d50b2
#
# WARNING: This tool is in the experimental stage.
#          Please report bugs at: [https://github.com/informalsystems/apalache/issues]
#
# Usage statistics is ON. Thank you!
# If you have changed your mind, disable the statistics with config --enable-stats=false.

Checker options: filename=2PossibleTraces.tla, init=, next=, inv=IsThree I@15:03:26.784
Tuning:                                                           I@15:03:27.459
PASS #0: SanyParser                                               I@15:03:27.460
Parsing file /Users/danwt/Documents/sandbox-tla/2PossibleTraces.tla
Parsing file /private/var/folders/c5/f5xhs6_d2s3_3xr84_rnyswc0000gn/T/Integers.tla
Parsing file /private/var/folders/c5/f5xhs6_d2s3_3xr84_rnyswc0000gn/T/FiniteSets.tla
Parsing file /private/var/folders/c5/f5xhs6_d2s3_3xr84_rnyswc0000gn/T/Sequences.tla
Parsing file /private/var/folders/c5/f5xhs6_d2s3_3xr84_rnyswc0000gn/T/TLC.tla
Parsing file /private/var/folders/c5/f5xhs6_d2s3_3xr84_rnyswc0000gn/T/Naturals.tla
PASS #1: TypeCheckerSnowcat                                       I@15:03:28.372
 > Running Snowcat .::.                                           I@15:03:28.373
 > Your types are great!                                          I@15:03:28.658
 > All expressions are typed                                      I@15:03:28.659
PASS #2: ConfigurationPass                                        I@15:03:28.739
  > 2PossibleTraces.cfg: Loading TLC configuration                I@15:03:28.745
  > Using the init predicate Init from the TLC config             I@15:03:28.794
  > Using the next predicate Next from the TLC config             I@15:03:28.795
  > Set the initialization predicate to Init                      I@15:03:28.796
  > Set the transition predicate to Next                          I@15:03:28.797
  > Set an invariant to IsThree                                   I@15:03:28.797
PASS #3: DesugarerPass                                            I@15:03:28.870
  > Desugaring...                                                 I@15:03:28.870
PASS #4: UnrollPass                                               I@15:03:28.937
  > Unroller                                                      I@15:03:28.971
PASS #5: InlinePass                                               I@15:03:29.035
  > InlinerOfUserOper                                             I@15:03:29.038
  > Wrap                                                          I@15:03:29.046
  > CallByNameOperatorEmbedder                                    I@15:03:29.049
  > LetInExpander                                                 I@15:03:29.056
  > Unwrap                                                        I@15:03:29.061
  > InlinerOfUserOper                                             I@15:03:29.067
Leaving only relevant operators: CInitPrimed, Init, InitPrimed, IsThree, Next, View I@15:03:29.075
PASS #6: PrimingPass                                              I@15:03:29.121
  > Introducing InitPrimed for Init'                              I@15:03:29.123
PASS #7: VCGen                                                    I@15:03:29.156
  > Producing verification conditions from the invariant IsThree  I@15:03:29.156
  > Using state view View                                         I@15:03:29.156
  > VCGen produced 1 verification condition(s)                    I@15:03:29.162
PASS #8: PreprocessingPass                                        I@15:03:29.204
  > Before preprocessing: unique renaming                         I@15:03:29.204
 > Applying standard transformations:                             I@15:03:29.214
  > PrimePropagation                                              I@15:03:29.215
  > Desugarer                                                     I@15:03:29.253
  > UniqueRenamer                                                 I@15:03:29.326
  > Normalizer                                                    I@15:03:29.368
  > Keramelizer                                                   I@15:03:29.412
  > After preprocessing: UniqueRenamer                            I@15:03:29.455
PASS #9: TransitionFinderPass                                     I@15:03:29.494
  > Found 1 initializing transitions                              I@15:03:29.508
  > Found 5 transitions                                           I@15:03:29.528
  > No constant initializer                                       I@15:03:29.528
  > Applying unique renaming                                      I@15:03:29.529
PASS #10: OptimizationPass                                        I@15:03:29.566
 > Applying optimizations:                                        I@15:03:29.568
  > ConstSimplifier                                               I@15:03:29.569
  > ExprOptimizer                                                 I@15:03:29.571
  > ConstSimplifier                                               I@15:03:29.574
PASS #11: AnalysisPass                                            I@15:03:29.602
 > Marking skolemizable existentials and sets to be expanded...   I@15:03:29.603
  > SkolemizationMarker                                           I@15:03:29.604
  > ExpansionMarker                                               I@15:03:29.605
 > Running analyzers...                                           I@15:03:29.607
  > Introduced expression grades                                  I@15:03:29.638
  > Introduced 5 formula hints                                    I@15:03:29.639
PASS #12: PostTypeCheckerSnowcat                                  I@15:03:29.640
 > Running Snowcat .::.                                           I@15:03:29.640
 > Your types are great!                                          I@15:03:29.718
 > All expressions are typed                                      I@15:03:29.718
PASS #13: BoundedChecker                                          I@15:03:29.753
State 0: Checking 1 state invariants                              I@15:03:31.775
Step 0: picking a transition out of 1 transition(s)               I@15:03:31.780
State 1: Checking 1 state invariants                              I@15:03:31.817
State 1: Checking 1 state invariants                              I@15:03:31.832
Step 1: Transition #2 is disabled                                 I@15:03:31.846
Step 1: Transition #3 is disabled                                 I@15:03:31.858
Step 1: Transition #4 is disabled                                 I@15:03:31.877
Step 1: picking a transition out of 2 transition(s)               I@15:03:31.878
Step 2: Transition #0 is disabled                                 I@15:03:31.905
Step 2: Transition #1 is disabled                                 I@15:03:31.921
State 2: Checking 1 state invariants                              I@15:03:31.936
State 2: state invariant 0 violated. Check the counterexample in: counterexample1.tla, MC1.out, counterexample1.json E@15:03:31.983
State 2: Checking 1 state invariants                              I@15:03:32.021
State 2: state invariant 0 violated. Check the counterexample in: counterexample2.tla, MC2.out, counterexample2.json E@15:03:32.041
Step 2: Transition #4 is disabled                                 I@15:03:32.101
Step 2: picking a transition out of 2 transition(s)               I@15:03:32.101
Step 3: Transition #0 is disabled                                 I@15:03:32.127
Step 3: Transition #1 is disabled                                 I@15:03:32.152
Step 3: Transition #2 is disabled                                 I@15:03:32.171
Step 3: Transition #3 is disabled                                 I@15:03:32.187
Step 3: Transition #4 is disabled                                 I@15:03:32.203
Found a deadlock. No SMT model.                                   E@15:03:32.203
Found 2 error(s)                                                  I@15:03:32.204
The outcome is: Error                                             I@15:03:32.205
Checker has found an error                                        I@15:03:32.206
It took me 0 days  0 hours  0 min  5 sec                          I@15:03:32.207
Total time: 5.556 sec                                             I@15:03:32.208
EXITCODE: ERROR (12)

System information

Apalache version [apalache-mc version]: APALACHE version 0.15.12 build 05d50b2
OS [e.g. Ubuntu Linux or Mac OS, and the current version]: OSX 11.5
JDK version [e.g. OpenJDK 0.8.0]: OpenJDK Runtime Environment Zulu16.32+15-CA (build 16.0.2+7)

With flag --no-deadlock introduced in #1679 this now prints:
All executions are shorter than the provided bound.               W@12:42:41.962
Found 2 error(s)                                                  I@12:42:41.963
The outcome is: ExecutionsTooShort                                I@12:42:41.966

@konnov I'd say this is resolved?

Actually, it's not. With --no-deadlock, Apalache finishes with an OK result, even if there were previous counter-examples:
All executions are shorter than the provided bound.               W@12:50:52.595
Found 2 error(s)                                                  I@12:50:52.598
The outcome is: ExecutionsTooShort                                I@12:50:52.601
Checker reports no error up to computation length 10              I@12:50:52.601
It took me 0 days  0 hours  0 min  4 sec                          I@12:50:52.603
Total time: 4.790 sec                                             I@12:50:52.603
EXITCODE: OK

Oops. The fix was not good then

@shonfeder, given the recent refactoring of the configuration options, what would be the optimal place for doing the following: if --max-error=k is set and k > 1, set --no-deadlock to true.

@shonfeder, given the recent refactoring of the configuration options, what would be the optimal place for doing the following: if --max-error=k is set and k > 1, set --no-deadlock to true.

This is also an issue when passing a transition filter.
Maybe deadlock checking should be off by default? All other checks we do (invariants, ...) are off by default.

Given that deadlock detection makes an additional call (and it's is incomplete anyways), it seems to be a good idea to me to set --no-deadlock=true by default.

what would be the optimal place for doing the following: if --max-error=k is set and k > 1, set --no-deadlock to true.

Really depends on the program logic. If it is an invariant of anything that takes checker options, then I think it should go in the converstion from configurations to "option groups":
https://github.com/informalsystems/apalache/blob/b39ce05b2f8f51858d6ae5262fe5812a59e7ebaf/mod-infra/src/main/scala/at/forsyte/apalache/infra/passes/options.scala#L570-L602


Possible to enable custom domain name for certificate when hitting external endpoint?

Is it possible to create certificate via Container apps (or use from keyvault), so we can use our own domain name when hitting the external endpoint (via DNS CNAME)??

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 307a2025-0f86-5d45-dba6-7c859c4313e7
Version Independent ID: 171ef08d-42f2-c473-e6ab-469bf20cc11d
Content: Set up HTTPS ingress in Azure Container Apps Preview
Content Source: articles/container-apps/ingress.md
Service: container-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

Hello @LAKN-Lasse-Knudsen - Thank you for your feedback! We will review and update as appropriate.

Hello @LAKN-Lasse-Knudsen - Sorry for the late reply. Support for custom domains, DNS settings, SSL cert are roadmap features that are in the works. For more updates, please review & track the following issue: https://github.com/microsoft/azure-container-apps/issues/8
If you have an immediate need for them in production, you can look to use other services like Azure Frontdoor, Azure Application Gateway. or APIM.
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Custom icon not being displayed

Hi,
Excellent app! Just started using it.
The inbuilt icons work fine but the custom images don't appear to.
I am using Version 77.0.3865.90 (Official Build) (64-bit)
I can see the icon gets "loaded" or at least can be seen by the app:

But in the tabs I see this:

The other tab functions are working - the tab will be made unique and protected which is great... the icon doesn't change. Small thing but would be nice.
Img URL I'm using is this: https://upload.wikimedia.org/wikipedia/commons/0/09/Blue_computer_icon.svg
Thanks!

Darn... it was coz it was SVG... sorry!

It was not the right repository to post an issue btw. ;)


Update prettify code and scripts

Update prettify code and scripts to prettify in future

I have updated the files. Please check


mysql Transactions

Hi, I have a simple question regarding transactions, Does beginTransaction just set auto_commit off and then commits all the queries? Does it also locks the table or we've to lock the table by querying
SELECT ID FROM myTable FOR UPDATE ...

Good question again, thank you!
Calling beginTransaction does indeed turn autocommit off, so that the subsequent statements will not be executed immediately but will be executed in one atomic batch as soon as you finish or commit the transaction, which also turns autocommit on again.
That’s just the way transactions work. So I think everything is fine here in regard to how the library works or how you use it or intend to use it.
Assuming you’re using MySQL, there are some quirks, though:

Data definition language (DDL) statements, such as CREATE TABLE, ALTER TABLE, TRUNCATE TABLE, DROP TABLE, CREATE INDEX or DROP INDEX, implicitly end any transaction and thus break the atomicity and the ability to roll back [1]. So you really shouldn’t use those in transactions.
Both LOCK TABLES and UNLOCK TABLES implicitly commit any active transaction, too. And also the other way round, beginning a transaction implicitly releases existing table locks [2]. So table locking does indeed not play well with transactions in MySQL. The two are practically incompatible.

Your SELECT ... FOR UPDATE, on the other hand, should work perfectly well with transactions [3]. You may need this if you execute queries using SELECT within your transactions.
Finally, if you only use data manipulation language (DML) statements in your transactions, such as INSERT, UPDATE or DELETE, you should be fine with pure transactions, without any additional locking.
Does that help?

Thank you so much for your helpful answer, referring to this question in readme.md file would be helpful for others.
Thanks again for such a great answer.


Reorganize some glyphs: simplify font selection

https://github.com/KaTeX/katex-fonts/pull/71

Move italic \imath (dotless i) and \jmath (dotless j) to Math PUA

Main already has \i and \j from cmr and they differ from math ones
No need to use mathitLetters
Fixes #354: incorrect spacing around dotless i (and j)

Move old-style numerals (0-9) to Math

Old-style numerals are not calligraphic, \mathcal{2} doesn't work in LaTeX
No need to check for numerals in mathnormal

Move pound sign to non-italic

Make it consistent with dollar sign
No need to use mathitLetters

Rename mathdefault to mathnormal

Codecov Report

Merging #2156 into master will decrease coverage by 6.2%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2156      +/-   ##
==========================================
- Coverage   94.89%   88.68%   -6.21%
==========================================
  Files          81       81
  Lines        5285     5275      -10
  Branches      926      922       -4
==========================================
- Hits         5015     4678     -337
- Misses        247      526     +279
- Partials       23       71      +48

Flag
Coverage Δ

#screenshotter
?

#test
88.68% <100%> (+0.09%)
:arrow_up:

Impacted Files
Coverage Δ

src/wide-character.js
72.22% <ø> (ø)
:arrow_up:

src/symbols.js
100% <100%> (ø)
:arrow_up:

src/buildCommon.js
93.62% <100%> (-4.46%)
:arrow_down:

src/functions/underline.js
16.66% <0%> (-83.34%)
:arrow_down:

src/functions/verb.js
17.64% <0%> (-82.36%)
:arrow_down:

src/functions/overline.js
23.07% <0%> (-76.93%)
:arrow_down:

src/functions/lap.js
61.9% <0%> (-38.1%)
:arrow_down:

src/functions/delimsizing.js
64.89% <0%> (-31.92%)
:arrow_down:

src/svgGeometry.js
61.29% <0%> (-29.04%)
:arrow_down:

src/functions/phantom.js
72.22% <0%> (-27.78%)
:arrow_down:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1cee3c...35456f8. Read the comment docs.

Is this blocked on https://github.com/KaTeX/katex-fonts/pull/71?

@kevinbarabash Yes it is.

Codecov Report

Merging #2156 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2156      +/-   ##
==========================================
- Coverage   94.77%   94.74%   -0.03%
==========================================
  Files          83       83
  Lines        5360     5349      -11
  Branches      940      935       -5
==========================================
- Hits         5080     5068      -12
- Misses        257      258       +1
  Partials       23       23

Flag
Coverage Δ

#screenshotter
88.41% <100.00%> (-0.05%)
:arrow_down:

#test
88.65% <100.00%> (+0.08%)
:arrow_up:

Impacted Files
Coverage Δ

src/wide-character.js
72.22% <ø> (ø)

src/buildCommon.js
97.96% <100.00%> (-0.12%)
:arrow_down:

src/macros.js
97.20% <100.00%> (+0.01%)
:arrow_up:

src/symbols.js
100.00% <100.00%> (ø)

src/buildMathML.js
98.14% <0.00%> (-0.93%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a22d3...212c0f8. Read the comment docs.

Wow, I was surprised to see what \mathcal{1234567890} produces in LaTeX:

This will make this PR a breaking change, so should be well-documented.
It looks like LaTeX does support old-style numerals, though, via \oldstylenums. Perhaps it's worth including them in a font somewhere, and adding proper support for them? It would be annoying to break this and not have a replacement...

@edemaine \mathnormal{1234567890} gives old-style numerals.

@edemaine Thank you for the review!


Windows Powershell Lagging while typing in windows terminal

Expected behavior
Should Be Responsive As i type in any CLI Interface.
Actual behavior
When I complete typing my whole command and look at the screen it has started typing The first word.Sowly typing letter by letter.
I don't have any such problem on opening powershell from win + x But I love the design Of terminal,Therefore came here to report the issue.
By the way, Command Prompt(cmd.exe) is working absolutely fine but i am more comfortable with interface of windows powershell.
Please Fix this bug as soon as possible
I Dont Have any Recording Tool To Attach The Recording.So,sorry couldn't give proof
Summing up, The problem is only Windows Powershell is lagging a lot while typing in windows terminal.But runs Perfectly Fine While opened as Standalone(form win + x )

@Rasesh2005 -- can you please reply with the following information:

windows version (e.g. windows 10 --  patch 1803/1903/1909/2004 etc.)
graphics card (e.g. intel iris, nvidia gfx 960 etc etc) and the driver version
screen resolution (e.g. 4000 x 3000) and screen refresh rate (e.g. 60hz?)
laptop screen or external monitor? both? Does the lag happen on both screens or just external?
what version of windows powershell? Try running it as powershell.exe -noprofile  does it still lag?

windows version -- 2004
amd radeon graphics chip(don't remember the exact model)
720p display
laptop
$psversiontable is as follows
Name                           Value

PSVersion                      5.1.19041.1
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.1
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
powershell.exe -noprofile  doesnt make any diffference
But My concern is that it is working smoothly when launched from win+x or right clicking start button. But When Opened in terminal it lags a lot,like after typing the whole sentence, its still typing  first word at the rate of one letter every 2 seconds

When launched from Win+X that's the original conhost which uses GDI+. Windows Terminal is something very different. It uses DirectX and DirectWrite technology. It also adds a lot of other fancy things. So it should be expected that Windows Terminal has different performance comparing to conhost. Of course we do not want the lagging. Just to point out the essential difference of those two fellows.

Ohk! Thanks For this Valuable Knowledge. Didn't know this.  But I am frustrated by windows terminal but want it to be better because of its better customisations ... SomeOne Plz Fix this issue ASAP

We'd also love to fix whatever problem you're experiencing. But you gotta give us more context. The CPU & GPU, memory, driver, all those things may help.
By the way have you tried software rendering? This may also help.

( related feature request about measuring time-to-character-rendering: https://github.com/microsoft/terminal/issues/5590 )

you can check the feature of hp pavillion g6 1117tx notebook pc
I didn't make any modifications over it

@Rasesh2005 Try what @skyline75489  mentions above -- there's a setting you can change that will use a different method to draw the screen. It may alleviate the problem by bypassing bugs in your video drivers.

For ref, his machine has a core i3 cpu and AMD Radeon HD 6470M for gpu.

Can I get help where to paste the settings? Because I don't have much idea about  how json settings work

Sure! You want to add it to the top-level of the json object, next to defaultProfile, like so:

Sometime when I kill it from task manager (though it ends itself when exit.but doesn’t fix the issue) , It gets Fixed and I am able to use it smoothly

@Rasesh2005 Is this a work computer? Do you have a corporate antivirus running? Or your own personal one?

personal Computer. So No Urgency


docker-compose or nah?

considering making this to use docker-compose?

It probably is, by now:
$ git grep compose
Makefile:       docker-compose pull
Makefile:       docker-compose up -d
Makefile:       docker-compose down
README.md:need as a prerequisite is having `docker`, `docker-compose`, and `make` installed on your machine. The container exposes the following ports:

If you agree, please close the issue?

@akauppi thanks.


Windows: fix Windows graph driver name

@jhowardmsft, #22775 changed the name of the Windows graph driver from windowsfilter to Windows filter storage driver, not realizing that this string was used as a component in a file path. This caused all my images to disappear, and now I have this silly directory c:\programdata\docker\image\Windows filter storage driver on my machine.
Reverting the name change.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix_windows_graph_name" git@github.com:jstarks/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix_windows_graph_name" git@github.com:jstarks/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

LGTM

LGTM


Videos not playing at all

In my Google photos video album, only one out of 23 videos plays at all (the first one listed). The rest just instantly crash back to the browsing screen. This happened on both our Roku TVs and under 2 different accounts.

same thing is happening to me


FE: Allow for showing Discord name on profile

we have .discordtoken in the db for the ids, and then lookup the id with the Discord client like: Client.fetchUser("123456789012345678");
I don't know if it completely makes sense to do, it would require a way to keep those names refreshed

we have .discordtoken in the db for the ids, and then lookup the id with the Discord client like: Client.fetchUser("123456789012345678");
I don't know if it completely makes sense to do, it would require a way to keep those names refreshed

The bot could fetch those names.
What make most sense to me is... if someone does .play or .key, we check if they have a name on that account and if not, we set it to the discord name. If there was already a name, do nothing.

The bot could fetch those names.
What make most sense to me is... if someone does .play or .key, we check if they have a name on that account and if not, we set it to the discord name. If there was already a name, do nothing.


creating a zip with deployment artifacts

Description:
make a zip file containing artifacts needs for the deployment and sample scenarios.
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

https://github.com/wso2/k8s-apim-operator/pull/75


Major bug with definition of user tag

I don't know if it is because of the new vscode language client, but there is a major bug with definition for user tag. To reproduce the problem, do Ctrl+Click on an user tag in qute template without click on it (to avoid opening the file)

And you will see in the trace an infinite of didOpen, didClose of the user tag file name, which report  a lot of diagnostics (because diagnostics is done on didOpen).
To stop those didOpen/didClose, you need to open the user tag file name.

I don't think it's the language client, I tried it on 7.y.z of the language client and was able to reproduce the issue.


[CARBONDATA-3420] Concurrent Datamap Creation is not synchronised across different sessions

Problem: Create (preaggregate) datamap from two or more concurrent sessions. After this only one datamap creation is success, others failed. Now do SHOW DATAMAP ON TABLE tableName. Some sessions do not display the newly created datamap.
RCA: One session successfully creates the datamap and other failed on the create table command (create table command being called from DataMapProvider.initMeta from CarbonCreateDataMapCommand.processMetadata). So now all the sessions have their CarbonFileMetastore.tableModifiedTimeStore synced with the SCHEMAS_MODIFIED_TIME_FILE but the CarbonTable is not updated. So next time also it will not update the CarbonTable as the SCHEMAS_MODIFIED_TIME_FILE is already synced with CarbonFileMetastore.tableModifiedTimeStore.
Solution: Update the last modified time of SCHEMAS_MODIFIED_TIME_FILE after the datamap creation is finished.

[x] Any interfaces changed?  ->  No
[x] Any backward compatibility impacted?  ->  No
[x] Document update required?  ->  No
[x] Testing done  ->  Yes
[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3468/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3671/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/11735/

@NamanRastogi This is only for pre-aggregate? what about MV? Is MV working? If it is for pre-aggregate only then why we need to fix it as it is going to be replaced by MV.

@ravipesala No, this error is not reproducible for MV.


GitHub Packages broken with multiple repos in 1 org

Describe the bug
Attempting to use github packages integration, with the same package(s), from two separate repositories within the same organization will cause package upload failures.
I set up GitHub Packages + binarycaching with GitHub actions in one of my repos (https://github.com/PazerOP?tab=packages&repo_name=stuff), and was very happy with how it worked. I then tried to integrate it with another repo (https://github.com/PazerOP?tab=packages&repo_name=SourceRCON). After setting it up with the second repo, I noticed that fmt_x64-linux was failing to upload to GitHub Packages. It appears this is an issue because fmt_x64-linux is associated with the first repo (PazerOP/stuff), and will not accept new versions uploaded from a second repo.
Environment

OS: ubuntu, but probably doesn't matter what OS
Compiler: GCC 9, but also probably doesn't matter

To Reproduce
Steps to reproduce the behavior:

Set up vcpkg with GitHub Packages binarycaching on repo A, and install a package.
Set up vcpkg with GitHub Packages binarycaching on repo B, and install the same package. Make sure your build flags/compiler version/etc are different, such that the cached package from repo A is not suitable for use in repo B (aka make sure there is a cache miss).
The upload of the package from repo B to GitHub Packages will fail.

Expected behavior
The package from repo B should be successfully cached, one way or another. I don't (personally) care about the advertised feature of the GitHub Packages cache being shared between repos. All that matters to me is that they are cached so a particular repo will not do a complete rebuild on each CI run. A bandaid solution might be to just have a command line option for vcpkg that lets me specify a user-defined prefix or suffix for the NuGet packages.
Failure logs
Log from the second repo (with --debug):
Starting package 3/4: fmt:x64-linux
Building package fmt[core]:x64-linux...
[DEBUG] popen(/home/runner/work/SourceRCON/SourceRCON/vcpkg/downloads/tools/cmake-3.19.2-linux/cmake-3.19.2-Linux-x86_64/bin/cmake -DALL_FEATURES= -DCURRENT_PORT_DIR=/home/runner/work/SourceRCON/SourceRCON/vcpkg/ports/fmt -D_HOST_TRIPLET=x64-linux -DFEATURES=core -DPORT=fmt -DVCPKG_USE_HEAD_VERSION=0 -D_VCPKG_DOWNLOAD_TOOL=BUILT_IN -D_VCPKG_EDITABLE=0 -D_VCPKG_NO_DOWNLOADS=0 -DCMD=BUILD -DDOWNLOADS=/home/runner/work/SourceRCON/SourceRCON/vcpkg/downloads -DTARGET_TRIPLET=x64-linux -DTARGET_TRIPLET_FILE=/home/runner/work/SourceRCON/SourceRCON/vcpkg/triplets/x64-linux.cmake -DVCPKG_BASE_VERSION=2021-01-13 -DVCPKG_CONCURRENCY=3 -DVCPKG_PLATFORM_TOOLSET=external -DGIT=/usr/bin/git "-DVCPKG_PORT_CONFIGS=/home/runner/work/SourceRCON/SourceRCON/cmake_out/vcpkg_installed/x64-linux/share/vcpkg-cmake/vcpkg-port-config.cmake;/home/runner/work/SourceRCON/SourceRCON/cmake_out/vcpkg_installed/x64-linux/share/vcpkg-cmake-config/vcpkg-port-config.cmake" -DVCPKG_ROOT_DIR=/home/runner/work/SourceRCON/SourceRCON/vcpkg -DPACKAGES_DIR=/home/runner/work/SourceRCON/SourceRCON/vcpkg/packages -DBUILDTREES_DIR=/home/runner/work/SourceRCON/SourceRCON/vcpkg/buildtrees -D_VCPKG_INSTALLED_DIR=/home/runner/work/SourceRCON/SourceRCON/cmake_out/vcpkg_installed -DDOWNLOADS=/home/runner/work/SourceRCON/SourceRCON/vcpkg/downloads -DVCPKG_MANIFEST_INSTALL=OFF -P /home/runner/work/SourceRCON/SourceRCON/vcpkg/scripts/ports.cmake 2>&1)
-- Using cached /home/runner/work/SourceRCON/SourceRCON/vcpkg/downloads/fmtlib-fmt-7bdf0628b1276379886c7f6dda2cef2b3b374f0b.tar.gz
-- Cleaning sources at /home/runner/work/SourceRCON/SourceRCON/vcpkg/buildtrees/fmt/src/2b3b374f0b-8ea71ee8ea.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/runner/work/SourceRCON/SourceRCON/vcpkg/downloads/fmtlib-fmt-7bdf0628b1276379886c7f6dda2cef2b3b374f0b.tar.gz
-- Applying patch fix-warning4189.patch
-- Using source at /home/runner/work/SourceRCON/SourceRCON/vcpkg/buildtrees/fmt/src/2b3b374f0b-8ea71ee8ea.clean
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Installing: /home/runner/work/SourceRCON/SourceRCON/vcpkg/packages/fmt_x64-linux/share/fmt/copyright
-- Fixing pkgconfig file: /home/runner/work/SourceRCON/SourceRCON/vcpkg/packages/fmt_x64-linux/lib/pkgconfig/fmt.pc
-- Fixing pkgconfig file: /home/runner/work/SourceRCON/SourceRCON/vcpkg/packages/fmt_x64-linux/debug/lib/pkgconfig/fmt.pc
-- Installing: /home/runner/work/SourceRCON/SourceRCON/vcpkg/packages/fmt_x64-linux/share/fmt/usage
[DEBUG] cmd_execute_and_stream_data() returned 0 after 11062321 us
-- Performing post-build validation
-- Performing post-build validation done
[DEBUG] popen(/usr/bin/mono /home/runner/work/SourceRCON/SourceRCON/vcpkg/downloads/tools/nuget-5.5.1-linux/nuget.exe pack /home/runner/work/SourceRCON/SourceRCON/vcpkg/buildtrees/fmt/x64-linux.nuspec -OutputDirectory /home/runner/work/SourceRCON/SourceRCON/vcpkg/buildtrees -NoDefaultExcludes -ForceEnglishOutput -NonInteractive 2>&1)
[DEBUG] cmd_execute_and_stream_data() returned 0 after  1269476 us
Attempting to build package from 'x64-linux.nuspec'.
Successfully created package '/home/runner/work/SourceRCON/SourceRCON/vcpkg/buildtrees/fmt_x64-linux.7.1.3-vcpkg9cbe796a59b5d4b0f74b5af284208f1a59ded4f6.nupkg'.
WARNING: NU5103: The folder 'lib/pkgconfig/fmt.pc' under 'lib' is not recognized as a valid framework name or a supported culture identifier. Rename it to a valid framework name or culture identifier.
WARNING: NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:
- Add a dependency group for pkgconfig0.0 to the nuspec
Uploading binaries for fmt:x64-linux to NuGet source GitHub.
[DEBUG] popen(/usr/bin/mono /home/runner/work/SourceRCON/SourceRCON/vcpkg/downloads/tools/nuget-5.5.1-linux/nuget.exe push /home/runner/work/SourceRCON/SourceRCON/vcpkg/buildtrees/fmt_x64-linux.7.1.3-vcpkg9cbe796a59b5d4b0f74b5af284208f1a59ded4f6.nupkg -ForceEnglishOutput -Source GitHub -NonInteractive 2>&1)
[DEBUG] cmd_execute_and_stream_data() returned 256 after  1615940 us
WARNING: No API Key was provided and no API Key could be found for 'https://nuget.pkg.github.com/PazerOP'. To save an API Key for a source use the 'setApiKey' command.
Pushing fmt_x64-linux.7.1.3-vcpkg9cbe796a59b5d4b0f74b5af284208f1a59ded4f6.nupkg to 'https://nuget.pkg.github.com/PazerOP'...
  PUT https://nuget.pkg.github.com/PazerOP/
WARNING: Package "fmt_x64-linux" is already associated with another repository.
  UnprocessableEntity https://nuget.pkg.github.com/PazerOP/ 682ms
Response status code does not indicate success: 422 (Unprocessable Entity).
Pushing NuGet to GitHub failed. Use --debug for more information.

Hi @PazerOP
Have you tried the suggestion here https://github.com/microsoft/vcpkg-tool/pull/40#issue-604434510? Please let us know if this can work for you.
Thnaks.

I have the same problem. But I think it would be better if it was possible to cache the same packages from different repositories.
For example, there is one organization with two repositories. They depend on the same external libraries. In one repository, CI works once a day, in the second - once every 2 weeks. If you use X_VCPKG_NUGET_ID_PREFIX (or without it, when the first repository is the owner of all packages), then each build will go slowly - there is no cache (the images for the build change often https://github.com/actions/virtual-environments/tree/main/images).
but X_VCPKG_NUGET_ID_PREFIX work for me. And solve 'Package "xxx" is already associated with another repository.'.
Thanks

One more things - X_VCPKG_NUGET_ID_PREFIX dont working for download cached package.  -( Build is working, but its slow.

can we hope to handle X_VCPKG_NUGET_ID_PREFIX when searching the cache?

@ctapmex  Since this issue was resolved, can you please open a new issue to request that?


Bug fixes, test cases, json config support

only detect circular references on collections, update version
Issue #18: Can't deploy with UTF-8 BOM
Issue #15: service_id is not shimmed
Add unit tests for ini/json reading
add support for reading options from json to be more compatible with the R SDK

+1


feat: repo-query support

Description
Fixes #14
What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents
#14
Mobile & Desktop Screenshots/Recordings

Implemented a loop for QnA after I recorded this GIF.

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[x] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

This is mostly done (except reviews), but there's this error that I get after a repo gets indexed:
Checking if pawurb/ecto_psql_extras is indexed by us...⏳
Repo not found❗
Indexing repo...⏳
Fetching Repository from GitHub...
Embedding Repository...
Saving the embeddings to our database...
Indexing Complete. You can now ask questions about this repository! 🎉
Error: EOF
Usage:
  pizza repo-query url [flags]

Flags:
  -b, --branch string   The branch to index (default "HEAD")
  -h, --help            help for repo-query

2023/08/02 00:25:50 EOF
exit status 1

here's the code for sending the indexing request:
https://github.com/diivi/pizza-cli/blob/57d49f5b1cb41a29ba10ecfbc81b77e3399d30f2/cmd/repo-query/repo-query.go#L145-L146
Can you help me understand what might be wrong here?

Never mind, I fixed it.

I noticed that but after I asked a question, I got exit 1 error.
go run main.go repo-query https://github.com/open-sauced/insights --branch beta
Checking if open-sauced/insights is indexed by us...⏳
Repo found ✅

Want to ask a question about open-sauced/insights?
> what is the test plan?
Searching the codebase for your query...🔍
Searching tests/lib/utils/truncate.test.ts for your query...🔍
Generating a response...🧠

The test plan for the repository \"open-sauced/insights\" can be found in the file \"tests/lib/utils/truncate.test.ts\". Here are some relevant test cases from that file:\n\n1. Test case: \"string should be returned unchanged\"\n   - Test code: `test(\"string should be returned unchanged\", () => { const string = \"test/testtesttest\"; const result = truncateString(string, 17); expect(result).toBe(\"test/testtesttest\"); });`\n\n2. Test case: \"string should truncate with length\"\n   - Test code: `test(\"string should truncate with length\", () => { const string = \"test/testtesttest\"; const result = truncateString(string, 9); expect(result).toBe(\"test/test...\"); });`\n\nPlease note that these are just a few examples. There might be more test cases in the test plan
Error: EOF
Usage:
  pizza repo-query url [flags]

Flags:
  -b, --branch string   The branch to index (default "HEAD")
  -h, --help            help for repo-query

2023/08/01 11:59:53 EOF
exit status 1

I noticed that but after I asked a question, I got exit 1 error.
Fixed

I added some parsing errors and some documentation here and there. Also abstracted the SSE listening code.
Let me know if there's anything more than I can improve.

I think this is in a place to test live, but only after we switch the Azure deployment. https://github.com/open-sauced/repo-query/issues/10
It would also be nice to format the response return a little syntax highlighting. Not sure if that is a repo-query thing (via system prompt asking for syntax highlight) or something we can do with the response in cobra. Here is the output in markdown:
> can you convert hsl(30, 70.0%, 7.2%) to hex code?
Searching the codebase for your query...🔍
Searching components/molecules/PaginationGotoPage/pagination-goto-page.tsx for your query...🔍
Generating a response...🧠

Yes, there is a function called `hslToHex` in the codebase. It is used in the `components/molecules/PaginationGotoPage/pagination-goto-page.tsx` file. Here is an example of how it is used:\n\n```tsx\nconst PaginationGotoPage = ({ page, name, setPage, totalPage }: PaginationGotoPageProps): JSX.Element => {\n  const [pageNumber, setPageNumber] = useState<number | string>(page);\n  const [value, setValue] = useState<number | string>(\"\");\n\n  const handleGotoPage = (e: React.FormEvent<HTMLFormElement>) => {\n    e.preventDefault();\n    // Convert HSL to Hex using the hslToHex function\n    const hexColor = hslToHex(30, 70.0, 7.2);\n    // Rest of the code...\n  }\n\n  // Rest of the code...\n}\n```\n\nPlease note that the exact implementation of the `hslToHex` function is not provided in the code snippet. You may need to search for its implementation in other files or external dependencies

Here is a screencap from the terminal:

It would also be nice to format the response return a little syntax highlighting

@bdougie - I was thinking the exact same thing. Yes, this is something we can absolutely tackle and would be trivial with the fmt package:
package main

import (
	"fmt"
)

func main() {
	myString := "This is a string\n\nwith newlines"
	fmt.Println(myString)
}

this prints a the string as:
This is a string

with newlines

As far as deeper syntax highlighting (like with backticks ``` or other markdown style editing from the AI model, that would be more difficult since we'd need to inspect the user's TERM env variable and ensure the terminal environment supports 256 colors.
But for now, interpreting the newlines as literal would be a great first step.

For the "\n"s, it's a known issue, the server sends "\n", so this gets rendered as a normal string. The markdown parser for the open-sauced/ai interface has the same problem (the prompt needs to fix this server-side).

@diivi - I'd use a string replacer then:
package main

import (
	"fmt"
	"strings"
)

func main() {
	myString := "This is a string\\n\\nwith newlines"
	replacer := strings.NewReplacer(
		"\\n", "\n",
	)
	myString = replacer.Replace(myString)
	fmt.Println(myString)
}

this returns the correct bits for the string to be formated by fmt


feat: error new handler

:tada: This PR is included in version 0.106.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat: script to check merkle tree hooks

feat: script to check merkle tree hooks
found super useful when trying to debug a recent chain deploy issue
left the write-back option commented out for now

Wondering if scripts like this make sense to have in the registry or somewhere else. Happy to merge if you think it'll be useful in the future

Generally I think if something is generalisable to non-AW deployments I will try to have it here e.g. I plan to keep the sql-generation script in infra


Fixing the loading problem

Fixes #35

[ ] Please do a function test within the posit cloud environment and GHA.
[ ] please update the RDS file so that it reflects the most recent XLSX


run machine controller through leader election

this pull demonstrates the whole concept, just wanted to show you where we are heading for.
I think that it will take a few more pulls to get it done.
Oh, I also need to concentrate on the hardest part ... testing :)


Ipsec-router pending restart.

Hi everybody,
I am trying to install Rancher 2.0 preview, but I got a problem regarding the ipsec-router sidekick. I managed to start Rancher server, then add custom hosts, but the ipsec-router didn't work, and the healthcare services as well.
core-services-ipsec-router log:

export CHARON_PID_FILE=/var/run/charon.pid
CHARON_PID_FILE=/var/run/charon.pid
rm -f /var/run/charon.pid
GCM=false
(( i=0 ))
(( i<6 ))
ip xfrm state add src <IP_ADDRESS> dst <IP_ADDRESS> spi 42 proto esp mode tunnel aead 'rfc4106(gcm(aes))' 0x0000000000000000000000000000000000000001 128 sel src <IP_ADDRESS> dst <IP_ADDRESS>
GCM=true
ip xfrm state del src <IP_ADDRESS> dst <IP_ADDRESS> spi 42 proto esp
break
'[' false == true ']'
DEBUG=
mkdir -p /etc/ipsec
'[' true = true ']'
curl -s -f http://<IP_ADDRESS>/2016-07-29/self/service/token
[repeat]

core-services-healthcheck logs:
level=fatal msg="Get http://<IP_ADDRESS>/2015-12-19/version: dial tcp <IP_ADDRESS>:80: getsockopt: no route to host"
[repeat]
Rancher versions:
rancher/server: 2.0 preview
rancher/agent: 2.0 alpha4 preview
Infrastructure Stack versions:
healthcheck: rancher/healthcheck:v0.3.3

status: pending restart
ipsec: rancher/net:v0.12.3
- status: ipsec starts, ipsec-router: pending restart (error)
network-services: cni rancher/net:v0.12.3

Docker version: (docker version,docker info preferred)
1.12.6 upstream
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
RHEL 7.4 3.10.0-514
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
VM

What does metadata log say? And network-manager?
Can you share full output of uname -r and docker info

Hi @superseb
Attached is the metadata log.
metadata.log

I have tried with ranger-agent alpha2 and alpha3, it still has the same error.
@superseb , could you please remove the needed information tag?

Seems to be related to firewalld, can you try:
firewall-cmd --permanent --zone=trusted --change-interface=docker0
firewall-cmd --reload

Thanks a lot @superseb ! It works now!
Just a question: I have opened the necessary firewall ports:
sudo firewall-cmd --list-ports
443/tcp 10250/tcp 10255/tcp 30000-32767/tcp 500/udp 4500/udp 42/tcp
Why didn't it work then? What is the difference to your command?

Ok great, closing this out. You can read a whole chunk of the problem here: https://github.com/moby/moby/issues/16137
Basically firewalld uses iptables but also introduced zones, which needs specific configuration regarding to Docker.


Data type "smallserial" in Postgres not highlighted

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.62
OS Version: Windows 10 x64 (build 19043)

Steps to Reproduce:

Open VS Code
Type the following in .sql file

But note that it has no problem recognizing other psuedo data types, like
serial

or bigserial

Only smallserial is not recognized.

/causedByExtension


Outdated mixpanel plugin

Why not updating mixpanel plugin to last version? Doing ionic state restore loads com.samz.mixpanel plugin, which doesn't have majority of the functions supported now by cordova-mixpanel-plugin. It would allow everyone to extend test app to identify people, send push notifications, and many more

no reason, just didnt have time to look at this project in the last couple of months.
its just a matter of using the new npm style plugin id right?
com.samz.mixpanel -> cordova-mixpanel-plugin

merged the relater pr


Find a way to avoid merging some Search models

While the purpose of https://github.com/Azure/azure-sdk-for-net/pull/12302 was to get the public APIs set, we should find a way to implement #12150 to instead not merge types using the generator, which does not support this feature and has no plans to. The public API cannot change, but the implementation may.
At first thought, wrapping types and taking over serialization like I do for KeywordTokenizer - but with different types nested therein (or maybe just for the V1 to roundtrip) could work.

Moving out of GA as any solution will require significant testing. The public API still wouldn't change.

Closing this for now.


Add TS definitions to ModmailConversation

No .d.ts files exists for ModmailConversation or ModmailConversationAuthor. This should be added.
Note: New modmail responses can be tricky to decode as it seems to move fields around and re-use them for different purposes

I have a draft on my laptop that I was working on for DefTyped, I'll submit it later today at the airport

Sounds good


Install new font in reports BC15 SaaS

Hello!
We have BC15 in SaaS and we need to change fonts in reports RDLC.
We install new font in local computer and we can view the new font in Visual Studio Code to make a RDLC but when we upload extension and try in web client, the font change to standard font.
It possible in SaaS install new font?
Thanks!

Let's get the issue to a team who will fix and backport it, as this repository is only for issues related to the latest developer preview environment for Dynamics 365 Business Central. We suggest that you open a support case or file a bug in Collaborate, to ensure that all Business Central users benefit from your catch as soon as possible.
To open a support case, you can:

Open a support request to CSS through the PartnerSource portal
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company

If you file the bug in Collaborate, remember to include steps to reproduce the issue, and the Business Central build number and country version you're using.


feat: Added route names component

Summary:
Add a "Route Names" GTFS Component #1464
Expected behavior:
"Route Names" component should be added to this list. We consider this component present if both the fields route_short_name and route_long_name in routes.txt are present, and if they have at least one value defined.

Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with gradle test to make sure you didn't break anything
[x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
[x] Linked all relevant issues
[x] Include screenshot(s) showing how this pull request works and fixes the issue(s)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I would suggest briefly explaining in the issue the manual testing you did if any. Did you modify a dataset to simulate the situation? How was it modified? Maybe include the dataset you used?


Won't load

The hitsounds, skin, and scripts will not load causing me to not be able to play whatsoever. Does it have to do with the domain change and everything?

oops.. looks like some files on a third party server are down

I guess it works now. Thanks for notifying


important info missing

default value

@embender : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Rename "export" to "release"

Secure key release will be changing the export API and enum to release. We must change all our export-related APIs accordingly. Keep an eye on the swagger for when that change occurs.

I'm closing this issue because "export" and "release" are actually separate (but similar). I closed .NET's and forgot I opened these across languages; however, both of these - if implemented - should be moved out of the February GA as they are slated for 7.3-preview service version.

I'm closing this issue because "export" and "release" are actually separate (but similar). I closed .NET's and forgot I opened these across languages; however, both of these - if implemented - should be moved out of the February GA as they are slated for 7.3-preview service version.

I'm closing this issue because "export" and "release" are actually separate (but similar). I closed .NET's and forgot I opened these across languages; however, both of these - if implemented - should be moved out of the February GA as they are slated for 7.3-preview service version.

I'm closing this issue because "export" and "release" are actually separate (but similar). I closed .NET's and forgot I opened these across languages; however, both of these - if implemented - should be moved out of the February GA as they are slated for 7.3-preview service version.


Example to validate data with the ebucoreplus.owl file

In my case, I start to wrote the model with some sample data.
At this point I didn't know the procedure to validate my sample data with the ebucoreplus.owl.
It may be helpful to provide an example to validate data from the OWL.

Thank you for your request, @MarcAntoine-Arnaud ! We need to better understand your requirement and are happy to discuss this in one of our next meetings of the editorial committee. Please send an e-mail to me or @aro-max for the link.

As discussed in meeting, an idea it to generate a SHACL from the EBUCorePlus Turtle ontology.


[#894] WIP: tutorial tester

This is a WIP for the tutorial tester command utility.
Usage (to be executed at the root of the operator for now)
go run test/utils/tutorials/tester.go --help
Usage of /tmp/go-build1254439168/b001/exe/tester:
  -dry-run
    	just list what would be executed without doing it
  -interactive
    	prompt to press enter between each chunk
  -start-from string
    	start from a specific stage name
  -timeout int
    	the timeout in minutes for every executed command (default 10)
  -verbose
    	print more logs

Executing when everything goes well should give this output:

When a command fails (for instance by misspelling a command):

There's also a possibility to have a verbose output

In this example, the teardown stage for deleting the minikube instance gets executed to cleanup afterwards.
There's a tutorial about how to create a tutorial. Check it out to get the details of the capabilities.

This is fantastic, great work.
I guess pulling this command inline into a VerifyTutorialsTest for go test wold be trivial.
only comment of note is the use of env vars, to make sure those are visible to the non automated user.

Thanks a lot for your feedback! I will work on a better way for variables extraction as you requested.


expose Angular-CLI VERSION as part of API

🚀 Feature request
Command (mark with an x)

[ ] new
[ ] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Description
Currently, I can can to the following with the Angular API, but not with the Angular-CLI API:
import { Component, VERSION as ngVersion } from '@angular/core';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.scss'],
})
export class AppComponent {
  angularVersion = ngVersion.full;
}

And the corresponding HTML:

Angular version: {{ angularVersion }}

Describe the solution you'd like
I would like to be able to do the following in addition to what is shown above:
import { VERSION as cliVersion } from '@angular/cli';

angularCliVersion = cliVersion.full;

and the corresponding HTML:

Angular-CLI version: {{ angularCliVersion }}

Describe alternatives you've considered
Hard-coding the Angular-CLI version number in the component.ts file.

Hi @fmorriso,
@angular/cli is a Node.js application and shouldn’t be imported and used in a browser application.

Hi @fmorriso, thanks for this request.
None-the-less, the above use-case doesn’t justify why version should be added as part of the public API.


DB health check results in postgres fatal log

The error message that shows up every 30 seconds in the postgres container log is
FATAL:  role "-d" does not exist
It doesn't seem to cause trouble and I guess it's a kind of health check on app side. Unfortunately, I don't know with which version of the container this started. Currently I'm running
Mattermost Version: 5.5.0
Database Schema Version: 5.5.0
Database: postgres
Build Hash:<PHONE_NUMBER>04c13bf564a8c4fd51616fc2cc4df9
EE Build Hash: 8eb31159c091f8a1e75c99ae6f4e47010dbf3731
Webapp Build Hash: 86bcb560c7dbd31967a28bf3b9da746da1a6947c
Build Date: Thu Nov 15 18:39:02 UTC 2018

Hmm weird, should have been fixed by this commit

I think I figured out how that happened. I'm not using the docker-compose file that comes with the repo, but when I put that setup into my ansible deployment playbook, I kinda transferred it using the env vars that were used at that time.
These env vars were renamed at some point in time and as a consequence the new ones are not set in my container.
I didn't have any issue with that because these envs were only relevant for a fresh db to initialize. My data is in a bind mount though, so I didn't notice until now. I'm fine with closing this since my setup might be exotic (i.e., not using the compose file). I leave it up to you if you wanna handle that condition.

Ok, it explains your issue.
I'll close since there is nothing to fix here IMHO.


v1.0.0 Wiki updates

alpha-only now takes in an optional data-no-space attribute to disallow spaced
alpha-numeric now accepts spaces by default. It also takes in an optional data-no-space attribute to disallow spaces
Removed the optional css class in favor of using a required attribute

Update to v1.0.0 version due to incompatibility change in behavior


Fix bad reference to retry_after

headers["retry_after"] causes an error since it is no longer part of header.

The version without capitals was never in the header- I think I never actually tested this case. Good work!


Implement FileFormat for BSON

Description
bson_scan has a unique implementation compared to other object scans. We can implement FileFormat trait for BSON and create the BSON scan table function similar to others (csv_scan etc.)

When I started writing this, I tried to do this and it didn't work. I think this probably doesn't make sense for a couple of reasons:

I'm not sure it gets us anything, except adding more boilerplate code: the streaming table implementation is rather clean.
it's not actually possible at this time given the state of the FileType enum and its dependency on DataFusion's FileFormat trait. see:

https://github.com/apache/arrow-datafusion/issues/8345
https://github.com/apache/arrow-datafusion/issues/8657

Having said that, I think even if it were possible, I'd be less inclined to want to do this: it'd mean writing rather a lot of boilerplate code, minimal benefits, and as it stands, the bson tables are easy to partition (and therefore potentially distribute/parallelize), and are quite lazily generated, which isn't impossible to do otherwise, but is pretty nice.

I'm not sure it gets us anything, except adding more boilerplate code: the streaming table implementation is rather clean.

It allows us to have a common implementation for both external tables and table functions (and any other thing we have in future).

it's not actually possible at this time given the state of the FileType enum and its dependency on DataFusion's FileFormat trait. see:

I think we can not use FileType and have an enum of our own. We create dyn FileFormat on our own using the enum. We can parse into our own enum and use it instead.
Not implementing FileFormat will lead us to maintain everything for (csv, json, parquet) and bson separately. Moreover, when we support other types, it will lead to more maintenance headache. I think it's worth investing in some boilerplate code in this case.

It allows us to have a common implementation for both external tables and table functions (and any other thing we have in future).

The external table and table funcs share an implementation. We don't implement anything special for any of the other formats, we just us stuff from DF, which is great: changing in this way, would move one of our own implementations to a different form of our own implementation. There doesn't seem to be a clear win in terms of functionality, or maintenance unless we can upstream it, which seems unlikely.

I think we can not use FileType and have an enum of our own. We create dyn FileFormat on our own using the enum. We can parse into our own enum and use it instead.

I tried this. Because the FileFormat trait in DF depends on the FileType enum in DF, you can't inject your own FileFormat. The DF ticket I linked should address this problem, but we'd be trading what we currently have for a much more complicated implementation without any new features.

(Just to close the loop on this; I think the current implementation is probably temporary and that this solution will eventually make sense, but we do need to wait for changes to datafusion and I don't think it's worth dedicating time to doing this work unless there's some kind of functional gain.)

I'm increasingly disinclined to do this, and now that we have object store support for bson without needing FileFormat (and a parallel implementation for json stream data) there's even less reason to rewrite the code this way. Also by more tightly coupling to datafusion interfaces, we expose ourselves to more upgrade related friction.
It might make sense to do this as part of some other feature development, but I think we can go ahead and close this.

Agreed. I did think about this some more and this makes sense not to move forward with.


Response ContentLength > ByteRange size for ranged GetObjectAsync

I'm using aws sdk for multipart download of 5MB chunks using ByteRange as documented here But sometime i get size bigger than the requested range.
Expected Behavior
The ResponseStream should have the same size as the ByteRange which is 5MB
Current Behavior
It keep downloading until OutOfmemory exception
Steps to Reproduce (for bugs)
`class Program
{
    static async Task Main(string[] args)
    {
        const string region    = "us-east-1";
        const long fileSize    =<PHONE_NUMBER>;
        var partSize           = 5 * (int) Math.Pow(2, 20);
        var partCount          = (int)Math.Ceiling((decimal)(fileSize) / partSize);

        var client = new AmazonS3Client(string.Empty, string.Empty, RegionEndpoint.GetBySystemName(region));

        using (var ms = new MemoryStream(partSize))
        {
            foreach (var partNumber in Enumerable.Range(395, partCount))
            {
                //var byteRange = new ByteRange((partNumber - 1) * partSize, (partNumber - 1) * partSize - 1 + partSize);
                var req = new GetObjectRequest
                {
                    Key        = "5GB.zip",
                    BucketName = "acembly-test-1",
                    PartNumber = partNumber,
                    //ByteRange = byteRange
                };

                var res = await client.GetObjectAsync(req);
                if (res.ContentLength != partSize)
                    throw new InternalBufferOverflowException();

                ms.SetLength(res.ContentLength);
                ms.Position = 0;
                using (var stream = res.ResponseStream)
                {
                    try
                    {
                        await stream.CopyToAsync(ms);
                        Console.WriteLine("[DONE] Part " + partNumber);
                    }
                    catch (OutOfMemoryException e)
                    {
                        Console.WriteLine(e);
                    }
                }
            }
        }

        Console.ReadKey();
    }
}`

Same outcome for both PartNumber and ByteRange.
Im misusing or this is a bug ?
Your Environment

AWSSDK.S3 <IP_ADDRESS>
Service assembly and version used:
Operating System windows 10:
Visual Studio version: 2017
Targeted .NET platform: netcoreapp2.0

.NET Core Info

.NET Core version used for development: netcoreapp2.0

Request:
GET https://acembly-test-1.s3.amazonaws.com/5GB.zip HTTP/1.1 Range: bytes=-2113929216--2108686337 User-Agent: aws-sdk-dotnet-45/<IP_ADDRESS> aws-sdk-dotnet-core/<IP_ADDRESS> .NET_Runtime/4.0 .NET_Framework/4.0 OS/Microsoft_Windows_NT_6.2.9200.0 ClientAsync host: acembly-test-1.s3.amazonaws.com X-Amz-Date: 20180525T112945Z X-Amz-Content-SHA256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 Authorization: AWS4-HMAC-SHA256 Credential=AKIAIVI3BTIJYHGGHGNA/20180525/us-west-2/s3/aws4_request, SignedHeaders=host;range;user-agent;x-amz-content-sha256;x-amz-date, Signature=bf4fee15ad1ac6ed45e845cd9d054f4d2ca6e8c3b320336cd49e00ffe03f9376 Request-Context: appId=cid-v1:0665f9fd-5489-4027-8e90-7361ce555f47 x-ms-request-root-id: 1a4fef98-43d499faaf4190b5 x-ms-request-id: |1a4fef98-43d499faaf4190b5. Request-Id: |1a4fef98-43d499faaf4190b5.
Response:
HTTP/1.1 200 OK x-amz-id-2: 7U5faUqISSh0HFj7BsKw+LnE25cVB00rJ0q+JgF2xFcfyaIGicT4K3QpR4LZHbHbiOcwKqlsZJI= x-amz-request-id: 828E916474C8CAED Date: Fri, 25 May 2018 11:29:46 GMT Last-Modified: Tue, 22 May 2018 15:47:55 GMT ETag: "e55d3940bd163b0ccb8dfa9184f1937c-1024" Accept-Ranges: bytes Content-Type: application/zip Content-Length:<PHONE_NUMBER> Server: AmazonS3

Hi @HalidCisse, I think your issue is mostly due to commenting out the code that would set the byte range.  The range seems to be missing from your headers, which would be representative of the code you provided.  Please try uncommenting and checking your logic.  We'll close out this issue in a few days if we don't get a response.

@klaytaybai i found a work around, i think its a int overflow of int.MaxValue.

Maybe.  The SDK uses long for this operation, so you might want to cast your operands to long to avoid it in your calculations.
What was your workaround?  Should I close this issue out?

The issue happen when i use PartNumber not ByteRange.
The issue is not fixed, but it doesn't affect me anymore. So close it.


AMBARI-24521. CLONE - Requests STOMP topic sent updates for host check request.

What changes were proposed in this pull request?
Now server does not create request STOMP updates for requests not related to any cluster.
How was this patch tested?
Manual testing.

Approved in https://github.com/apache/ambari/pull/2142.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3697/
Test PASSed.


Add "no-console" lint rule

This PR fixes #2373, and also adds a lint rule to prevent the console.log calls from being added

Coverage increased (+0.09%) to 82.809% when pulling d2fc6bb778a79d9160474cebfc6c5a52bcf464ff on fix-2373 into 514cebb834fd913d350a538b1aaf3e2331ad2aea on dev.


Links to old rtk.net site for other dbs

For the non-RMP databases, we'll add some language about how updates to these webpages are still in the works and provide links on the old rtk.net site.

This was completed with most recent PR.


Update organizing-conversations.md

Documentation was out of date, updated it to include info about the channel management policy settings.

+1

+1


Embedded image under step 3 of section "Create a replica set" needs u…

…pdating since still points to Preview
With the general availability of replica sets, the image needs updating since points to Replica Sets (Preview).  See announcement of GA in article here:  https://techcommunity.microsoft.com/t5/azure-active-directory-identity/accelerate-your-move-to-the-cloud-with-new-capabilities-in-azure/ba-p/1994704

@gamcmaho : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Justinha The original "following" in the updated line aligns with the Microsoft Writing Style Guide - below, so the change shouldn't be merged, but will you review the request to update the screenshot from "preview"? Thanks.

@ktoliver The "preview" is removed. Thanks!

@justinha, "following" is Microsoft style. See  Microsoft Writing Style Guide - "below". Thanks for the screenshot fix.


feat: rename delete to stop

According to this comment, it's not necessary to remove the service from the database and we only need to stop it.
So, in the deployer, we can rename the delete_service function to stop_service and just remove the persistence line for dropping the service in database.
Considering this endpoint no longer deletes the service but just stops it, we can rename the delete command to stop in cargo-shuttle.
This should fix #561

Thanks @jdrouet! This looks like it's nearly there, but won't we still get an FK error from calling delete_deployments_by_service_id?

@oddgrd good point, thank you for noticing it 😉

LGTM, thanks! One last thing: I think we can safely remove the delete_deployments_by_service_id function, I don't think it's used anywhere else.

Sure, I'm used to have a clippy job that would break on the CI for this kind of issues so I tend to forget to check 😅


python 3 compatible

I don't know may be we need replace / with // in another places? I just try quadkey.from_geo() and it works.

I'll run the tests on python 3 and if they pass merge it in. I should probably set up some CI stuff too...

@buckhx -- any chance this get's merged and updated in pip? Everything is moving Python3 nowadays


Tschie/list related features

List Related Features sample

@john0005 can you please review? Should work with 100.1+

Thanks @doneill for offering to review!

Thanks for the review. I've made the changes. Merging this.


Fixed some minor typo into example code that could cause unwanted compilation problem after copy-paste

I switched argv with argc where it was needed.

Doing locally