Custom metrics are not showing up when the model has adaptive batching activated

Custom metrics seems to be not working in the Seldon core V1 wrapped MLServers when the adaptive batching wrapper is enabled. However, when adaptive batching is disabled, everything works perfectly and new metrics are registered immediately. Seems to be some problem with logging when the model is decorated with adaptive batching that disables the MLServer metric logging capability.

Thanks for raising this one @saeid93 , we'll check it out :+1:

@adriangonz an update to this is that I cannot monitor the builtin batch_request_queue  metric too. Other builtin parameters like parallel_request_queue  are working smoothly.

@adriangonz  I just realized that this was some misconfig from my side. I'm closing it as I no longer observing the same issue after solving that problem on my end. Sorry if it has caused some time debugging for you.

No worries! Thanks for the update @saeid93 :+1:


Godot headless crashes when generating gdnative api json

Godot version:  v3.2.3

OS/device including version: Linux (Arch + Ubuntu 20.04) 64 bit

Issue description:
When using godot headless from here calling --gdnative-generate-json-api results in a straight terminate.
With the normal binary:
~/Temp
❯ godot --gdnative-generate-json-api api.json
Godot Engine v3.2.3.stable.custom_build - https://godotengine.org
OpenGL ES 3.0 Renderer: AMD Radeon(TM) Vega 10 Graphics (RAVEN, DRM 3.39.0, 5.9.9-95-tkg-bmq, LLVM 11.0.0)

WIth the headless binary fails:

~/Temp
❯ ./Godot_v3.2.3-stable_linux_headless.64 --gdnative-generate-json-api api.json
Godot Engine v3.2.3.stable.official - https://godotengine.org

pure virtual method called
terminate called without an active exception
fish: “./Godot_v3.2.3-stable_linux_hea…” terminated by signal SIGABRT (Abort)

~/Temp                                                                                ✘ ABRT
❯

Steps to reproduce:

Download the godot headless binary
unzip it
./Godot_v3.2.3-stable_linux_headless.64 --gdnative-generate-json-api api.json

Just tested with the latest beta, same thing happens:
~/Temp
❯ ./Godot_v3.2.4-beta3_linux_headless.64 --gdnative-generate-json-api api.json
Godot Engine v3.2.4.beta3.official - https://godotengine.org

pure virtual method called
terminate called without an active exception
fish: “./Godot_v3.2.4-beta3_linux_head…” terminated by signal SIGABRT (Abort)

Earlier related issue: #36582

Earlier related issue: #36582

Still experiencing this issue for both headless and server builds of Godot 3.2.4.

Still experiencing this issue for both headless and server builds of Godot 3.2.4.

Duplicate of https://github.com/godotengine/godot/issues/43953.

Duplicate of https://github.com/godotengine/godot/issues/43953.

Duplicate of #43953.

That's this issue, I guess you meant to reference #36582.

Duplicate of #43953.

That's this issue, I guess you meant to reference #36582.


luajit: 2.0.5-2021-10-02, 2.1.0-2021-10-27 -> 2.0.5-2022-03-13, 2.1.0-2022-04-05

Various bugfixes.
luajit_2_0
https://github.com/LuaJIT/LuaJIT/compare/d3294fa63b344173db68dd612c6d3801631e28d4...93a65d3cc263aef2d2feb3d7ff2206aca3bee17e
luajit_2_1
https://github.com/LuaJIT/LuaJIT/compare/b4b2dce9fc3ffaaaede39b36d06415311e2aa516...5e3c45c43bb0e0f1f2917d432e9d2dba12c42a6e
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

nixpkgs-review reveals no new failures on macos 10.15

I did some more testing and found no issue.  I've noticed some luajit issues in debian after recent update, but that was just for ppc64el which we don't really support.


Not all logos from simple-icons will work?

It is possible to use logos from different projects and even from simple-icons. I have tested a lot of them on simple-icons and they work, but not Lua and that is the icon i want to use. I noticed that SparkFun is not working either.
Shouldn't all of them work?

It looks like any icons added after v1.9.7 are not showing on shields badges.
Which is strange as we should currently be using the latest simple-icons version (v1.9.9) in production:

@paulmelnikow Do you think maybe the npm packages weren't updated in the latest deploy?

It runs npm install every time, though it doesn’t respect package-lock. This is frustrating, of course, because locking deps in production is the whole point of using package-lock on an application.
Is simple-icons bumped in package.json?

Ref: #1988


Update images dependency to v0.54.0

Update images dependency and adjust import paths for distro package
changes.
Includes #4065.

Base tests are failing.    Digging.


Add additional css rules to address Nuxt and similar frameworks

Nuxt v3 injects and requires a div#__nuxt added to the DOM directly following the body. The way Pico's max-width rules target head, main and footer is by using direct descenders. For example ,body > main.
Original:
@media (min-width: 768px) {
body > header,
body > main,
body > footer {
    max-width: 700px;
  }
}

While Nuxt contains this one descending div, Next contains two descending divs. To accommodate both frameworks, maybe:
@media (min-width: 768px) {
body > header, body > div[id] header,
body > main, body > div[id] main,
body > footer, body > div[id] footer {
    max-width: 700px;
  }
}

This seems quite similar to my issue, #13.

Same issue as #13

I find that too framework-specific.
But the problem exists.
I could imagine the following solution:
The good old [role="contentinfo"] is the old aria variant of "footer".
With the difference that it should only be the main footer. And that is exactly what we want.
So instead of body > footer you could use [role="contentinfo"]...
The same applies to the header: [role="banner"] instead of body > header.
The disadvantage is that you have to mark the footer with an additional (redundant?) attribute.


Partial function application + default argument causes type error

I spotted this problem with Pony master last week (2017-11-24) while trying to diagnose a CI compilation problem with https://github.com/ponylang/ponyc/pull/2370.
This PR adds a 2nd argument to env.exitcall() that has a default argument.  This new argument cause pony-stable to fail to build in the Travis-CI environment.  See compiler errors below, taken from https://travis-ci.org/ponylang/ponyc/jobs/307782380#L7890.  I have boiled down the essence of the bug/type problem/?? into a smaller code example, see Playground URL http://playground.ponylang.org/?gist=21c3ec1c0a6e4270f1bc9aaeb2736332.  (The playground example also demonstrates using a lambda as a workaround.)
Regardless of the fate of PR #2370, I hope that the lambda kludge shown in the playground example isn't the correct way to work around this problem.
Via chat, @mfelsche speculated, "For the code sample to work we would need to bring the notion of having a default argument to the type / the signature and basically make {(I32): None val} a subtype of {(I32, I64): None val} if the second argument has a default value. I don't know if that is possible or valid, but i think it is worth the discussion."
Error:
/tmp/pony-stable/stable/main.pony:76:28: argument not a subtype of parameter
        Shell(consume cmd, env~exitcode())?
                           ^
    Info:
    /tmp/pony-stable/stable/main.pony:76:40: methods have a different number of parameters
            Shell(consume cmd, env~exitcode())?
                                           ^
    /tmp/pony-stable/stable/main.pony:76:40: {(I32 val, U64 val): None val} ref is not a subtype of _ExitCodeFn ref: method 'apply' has an incompatible signature
            Shell(consume cmd, env~exitcode())?
                                           ^
    /tmp/pony-stable/stable/main.pony:76:40: {(I32 val, U64 val): None val} ref is not a subtype of None val
            Shell(consume cmd, env~exitcode())?
                                           ^
    /tmp/pony-stable/stable/main.pony:76:40: {(I32 val, U64 val): None val} ref is not a subtype of any element of (_ExitCodeFn ref | None val)
            Shell(consume cmd, env~exitcode())?
                                           ^
Error:
/tmp/pony-stable/stable/main.pony:79:56: argument not a subtype of parameter
          ["env"; "PONYPATH="+ponypath].>append(rest), env~exitcode()
                                                       ^
    Info:
    /tmp/pony-stable/stable/main.pony:79:68: methods have a different number of parameters
              ["env"; "PONYPATH="+ponypath].>append(rest), env~exitcode()
                                                                       ^
    /tmp/pony-stable/stable/main.pony:79:68: {(I32 val, U64 val): None val} ref is not a subtype of _ExitCodeFn ref: method 'apply' has an incompatible signature
              ["env"; "PONYPATH="+ponypath].>append(rest), env~exitcode()
                                                                       ^
    /tmp/pony-stable/stable/main.pony:79:68: {(I32 val, U64 val): None val} ref is not a subtype of None val
              ["env"; "PONYPATH="+ponypath].>append(rest), env~exitcode()
                                                                       ^
    /tmp/pony-stable/stable/main.pony:79:68: {(I32 val, U64 val): None val} ref is not a subtype of any element of (_ExitCodeFn ref | None val)
              ["env"; "PONYPATH="+ponypath].>append(rest), env~exitcode()
                                                                       ^
make: *** [bin/stable] Error 255

I think the only issue here is that the _ExitCodeFn interface needed to be updated to match the new interface of the function it was supposed to match (which had changed in that PR).
See this modification of your playground example:
http://playground.ponylang.org/?gist=e6de62641e316d79d34c30b13b5dda0c

As #2370 is closed now, i think the only remaining issue to discuss here, if we want to allow the subtyping relationship of {(T1): RT1} being a subtype of {(T1, T2): RT1} if the latter provides a default argument for T2.

@mfelsche - I don't think we can allow it because the LLVM code we need to generate is different.
If I recall correctly, the default argument value is actually handled on the caller side when invoking the function, so we need to know about the default parameter when we're doing code generation.

Regarding the LLVM code generation, @jemc is right that we currently need to know default arguments on the caller side.
However, we could remove that requirement by introducing mangled functions taking care of defaut arguments and forwarding to the main function, similar to what we currently do with boxed primitives.

For the record, when we had the name mangling discussion on the sync call, we noted that if we need to account for named arguments, we'd have to generate a different mangling for every possible permutation of the default argument parameters being omitted, which might be a bit of a pain.
Still, it's on the table if we decide this is otherwise a good idea.
But I worry it may have problematic type system implications, so we still need to discuss from that angle - that's why the needs discussion label remains.


Update <IP_ADDRESS> product logo

https://github.com/cloudflare/cloudflare-docs/blob/afe84b90c45d1ed3c389153e44e6509c0318cd75/products/<IP_ADDRESS>/docs-config.js#L4
I think this should be using the 1^4 icon instead as that's the current app icon etc.

@abracchi-tw can you confirm if this is an edit we should make? Thanks!

@abracchi-tw can you confirm if this is an edit we should make? Thanks!

@syeef thanks for raising this. hope to get this changed ASAP

@syeef thanks for raising this. hope to get this changed ASAP

hi @syeef can you provide us with an .svg file? thanks!

<svg width="20" height="26" fill="none" xmlns="http://www.w3.org/2000/svg">   <path fill-rule="evenodd" clip-rule="evenodd" d="M16.899 6.598v1.98h1.65v-1.98h1.138v-1.43H18.55V.02h-1.553L13.28 5.009v1.59h3.619zm0-4.402v2.972h-2.25l2.213-2.972h.037zM2.778 5.102c-.82.143-1.652.214-2.485.213V8.5h6.105v17.483h4.437V1.209H7.534c-.142.755-.444 1.392-.905 1.911A5.59 5.59 0 014.96 4.394c-.65.33-1.378.567-2.182.708z" fill="#fff"/>   <path fill-rule="evenodd" clip-rule="evenodd" d="M16.899 6.598v1.98h1.65v-1.98h1.138v-1.43H18.55V.02h-1.553L13.28 5.009v1.59h3.619zm0-4.402v2.972h-2.25l2.213-2.972h.037zM2.778 5.102c-.82.143-1.652.214-2.485.213V8.5h6.105v17.483h4.437V1.209H7.534c-.142.755-.444 1.392-.905 1.911A5.59 5.59 0 014.96 4.394c-.65.33-1.378.567-2.182.708z" fill="url(#paint0_linear)"/>   <path fill-rule="evenodd" clip-rule="evenodd" d="M16.899 6.598v1.98h1.65v-1.98h1.138v-1.43H18.55V.02h-1.553L13.28 5.009v1.59h3.619zm0-4.402v2.972h-2.25l2.213-2.972h.037zM2.778 5.102c-.82.143-1.652.214-2.485.213V8.5h6.105v17.483h4.437V1.209H7.534c-.142.755-.444 1.392-.905 1.911A5.59 5.59 0 014.96 4.394c-.65.33-1.378.567-2.182.708z" fill="url(#paint1_linear)"/>   <defs>     <linearGradient id="paint0_linear" x1="9.99" y1=".02" x2="9.99" y2="25.983" gradientUnits="userSpaceOnUse">       <stop stop-color="#fff"/>       <stop offset="1" stop-color="#fff" stop-opacity="0"/>     </linearGradient>     <linearGradient id="paint1_linear" x1="9.99" y1=".02" x2="9.99" y2="25.983" gradientUnits="userSpaceOnUse">       <stop stop-color="#fff"/>       <stop offset="1" stop-color="#fff" stop-opacity="0"/>     </linearGradient>   </defs> </svg>
@abracchi-tw this is the .svg code

Hi, @syeef I put the above svg and it renders like this:

Does this look good? In terms of size? If it is a little small would you mind providing me with an updated svg that would fit in a 48 x 48 px?

Hey @gganch - try this instead, thanks for quickly picking this up!
<svg width="49" height="50" fill="none" xmlns="http://www.w3.org/2000/svg">   <path fill-rule="evenodd" clip-rule="evenodd" d="M7 10.828c1.546.003 3.09-.129 4.612-.394 1.493-.263 2.844-.7 4.052-1.314a10.374 10.374 0 003.097-2.365c.856-.964 1.416-2.146 1.68-3.547h6.128v45.986h-8.236V16.74H7v-5.913zM37.825 16.888V13.21h-6.718v-2.95L38.007 1h2.882v9.555H43v2.656h-2.11v3.677h-3.064zm0-6.333V5.04h-.068l-4.108 5.515h4.177z" fill="#fff"/> </svg>

Looks like @gganch completed this. Will close. Thanks!


Add support for packaging slint-compiler with slint-cpp recipe

At the moment the slint-cpp recipe creates a library that only supports the dynamic C++ Slint interpreter API. Slint also supports compiling .slint files to .cpp files at compile time, which is more efficient and provides type-safety.
The cmake build by default produces a slint-compiler executable that's a host build, and the generated SlintConfig.cmake references that.
Unfortunately the current slint-cpp bit bake recipe does not handle this correctly. The produced binary should go into a native package (as opposed to target) and somehow the generated SlintConfig.cmake should be able to reference the slint-compiler binary from the host binary directory tree.
We need help to implement this properly using bit bake.

Discussed this a bit with Olivier. We could do something like this:

Create a slint-compiler recipe that builds a native slint-compiler, which builds with SLINT_FEATURE_COMPILER=ON and a (new) SLINT_FEATURE_RUNTIMELIB=OFF.
Let slint-cpp depend on slint-compiler-native, build with -DSLINT_COMPILER=/path/to/native-slint-compiler (which implies SLINT_FEATURE_COMPILER=OFF in terms of building)

I’ve started on this by letting slint-cpp-native product the compiler and slint-cpp (for target) depend and use it. Still a few smaller issues to sort out, but looking promising.

For git builds this now implemented. I've added TODOs for completion to the description of this issue.


[Question] Failed to preprocess criteo data

when i try to run a sample of wdl  https://github.com/NVIDIA-Merlin/HugeCTR/tree/master/samples/wdl
i got a error at step :Preprocess the Dataset Through NVTabular
bash preprocess.sh 0 criteo_data nvt 1 0 1 # parquet output
error :

Hi @LarryZhangy, NVTabular has updated the API and we are working on fixing the data preprocessing scripts to make them work. I will let you know once we fixed it.

@jershi425 , when this bug can be fixed?

I run the preprocessing script and got an IndexError, not quite sure what it means. Can anyone enlight me on this?

This issue was fixed in v22.11 release.


Feat/1608 facility form edit

Addresses:
1608
1982
2026
🚀 Impact:

Shared ErrorBoundary across apps

bciers/libs/components/src/error/ErrorBoundary.tsx
bciers/libs/components/src/error/Error.tsx
bciers/libs/components/src/error/GlobalError.tsx
bciers/apps/administration/app/error.tsx
bciers/apps/administration/app/global-error.tsx

Updated breadcrumbs for UUID and numeric

bciers/libs/components/src/navigation/Bread.tsx
bciers/apps/administration/app/components/contacts/ContactsForm.tsx

Facility Page href to add-facility folder for consistent file naming structure

bciers/apps/administration/app/components/facilities/FacilitiesPage.tsx

Facility Form edit

bciers/apps/administration/app/components/facilities/FacilityForm.tsx

Vitests

bciers/apps/administration/tests/components/facilities/FacilityForm.test.tsx

Facility endpoint PUT

bc_obps/registration/api/v1/_facilities/facility_id.py

Facility service update

bc_obps/service/facility_service.py
bc_obps/service/data_access_service/facility_service.py

Facility endpoint PUT tests

bc_obps/registration/tests/endpoints/v1/_facilities/test_facility_id.py

🚧 To Do
Unauthorized Record Displays in Facilities Grid
🔬 Local Testing:

From terminal command, start the api server:

cd bc_obps
make reset_db
make run

From terminal command, start the app development server:

cd client && yarn dev-all

Test ErrorBoundary component IF... Unauthorized Record Displays in Facilities Grid has NOT been completed/merged to develop and rebased to this branch

Navigate to http://localhost:3000
Click button "Log in with Business BCeID"
Sign in to Keycloak using bc-cas-dev
Navigate to http://localhost:3000/administration/operations

Click grid link Operation 2\View Facilities

Click grid link Facility 2\View Details
Expected Results: Error boundary component displays when nested component throws an error, e.g:

throw new Error(
        "We couldn't find your facility information. Please ensure you have been approved for access to this facility.",
      );

Test Contact Form Add:

Navigate to http://localhost:3000
Click button "Log in with Business BCeID"
Sign in to Keycloak using bc-cas-dev
Navigate to http://localhost:3000/administration/contacts
Expected Results

Contacts displays

Click button Add Contact
Expected Results

Contact form in edit mode displays

Complete the required form fields.
Click button Submit
Expected Results

Breadcrumbs displays the value in field First Name Last Name

Test Facility Form Add:

Navigate to http://localhost:3000
Click button "Log in with Business BCeID"
Sign in to Keycloak using bc-cas-dev
Navigate to http://localhost:3000/administration/operations
Expected Results

Operations displays

Click grid link Operation 2\View Facilities
Expected Results

Operation 2 > Facilities displays
'Add Facilty` button displays

Click button Add Facility
Expected Results

Facility form in edit mode displays

Complete the required form fields.
Click button Submit
Expected Results

Breadcrumbs displays the value in field Facility Name

Test Facility Form Edit:

Navigate to http://localhost:3000
Click button "Log in with Business BCeID"
Sign in to Keycloak using bc-cas-dev
Navigate to http://localhost:3000/administration/operations
Expected Results

Operation displays

Click grid link Operation 2\View Facilities
Expected Results

Operation 2 > Facilities displays

Click grid link Facility 1\View Details
Expected Results

Record information displays
Form fields are read-only
Edit button displays
Cancel button displays

Click button Cancel
Expected Results

Operation 2 > Facilities displays

Click grid link Facility 1\View Details
Click button Edit
Expected Results

Form fields are editable
Submit button displays

Add duplicate values in field  Well Authorization Number(s)

Click button Submit
Expected Results

Error alert displays: Well Authorization Number: Duplicates are not allowed.

Add non-duplicate values in Well Authorization Number(s) Note record the value(s)
Complete the other form fields.
Click button Submit
Expected Results

Error alert DOES NOT display
Sandbox displays: Your edits were saved successfully
Values entered in the edit form reflect in the read form
Edit button displays
Cancel button displays

Click button Cancel
Expected Results

Operation 2 > Facilities displays

Click grid link Facility 3\View Details
Add values in field  Well Authorization Number(s) recorded above (reflected in  Facility 1\View Details)
Click button Submit
Expected Results

Error alert displays: Well Authorization Number: Well authorization number with this Well authorization number already exists.

Some overall notes:

We're missing some form fields but I think Gabe's PR is handling those? Also the label for well auth numbers should be: BC Energy Regulator Well Authorization Number(s) (not sure if that's also part of Gabe's work)
When switching from readonly to edit we lose the facility type:  This ~could just be an error with our mock data--LFO facilities can't have type Single Facility Operation  but we may have that set wrong in our json files
If I get an error with adding a well auth number the field disappears when I try to edit it:
If I get an error with the facility name, when I try to edit the value resets:
Well auth is supposed to be optional but once I've added one I can't delete it: (I think this is unrelated to your PR; I think this behaviour is coming from the widget and we already have a ticket for that: https://github.com/orgs/bcgov/projects/122/views/2?filterQuery=well+auth&pane=issue&itemId=69155548

@BCerki
Thank-you very much for your in-depth and insightful review 🥇
Could these possible issues be moved to tech debt ticket(s)?

Some overall notes:

We're missing some form fields but I think Gabe's PR is handling those? Also the label for well auth numbers should be: BC Energy Regulator Well Authorization Number(s) (not sure if that's also part of Gabe's work)
When switching from readonly to edit we lose the facility type:  This ~could just be an error with our mock data--LFO facilities can't have type Single Facility Operation  but we may have that set wrong in our json files
If I get an error with adding a well auth number the field disappears when I try to edit it:
If I get an error with the facility name, when I try to edit the value resets:
Well auth is supposed to be optional but once I've added one I can't delete it: (I think this is unrelated to your PR; I think this behaviour is coming from the widget and we already have a ticket for that: https://github.com/orgs/bcgov/projects/122/views/2?filterQuery=well+auth&pane=issue&itemId=69155548

@BCerki
Thank-you very much for your in-depth and insightful review 🥇 Could these possible issues be moved to tech debt ticket(s)?

The well auth widget can be tech debt, but I think the other ones should be done as part of this card (don't have to be part of this PR though). Losing data when going from readonly to edit and having form fields disappear is more buggy than debt.

Thanks for all your work on this, Shon, looking good! Some overall notes:

The label for well auth numbers should be: BC Energy Regulator Well Authorization Number(s) (this is in bciers/apps/administration/app/data/jsonSchema/facilitiesLfo/Sfo.ts so probably not part of the well auth ticket, but if so disregard)
Small Aggregate Type facilities disappear on edit (loom same as next bullet)
If I edit the facility name for a second time, I have to hit a key twice before anything is entered: https://www.loom.com/share/47cd7c3ee07441c49d66d877baff13af?sid=e8ba73cc-66e8-40d4-a3bd-2f667fba745a
^I don't usually approve code with known bugs, but the double-type thing is small, so if it's not a quick fix we could do a separate card for it

@BCerki
I believe the type Small Aggregate LFO is no longer a valid option.  I will remove the value from the fixtures
useAutocomplete.js:211 MUI: The value provided to Autocomplete is invalid.
None of the options match with `{"const":"Small Aggregate","title":"Small Aggregate"}`.


[Request] Can the Object Allocation sub-dashboard have dynamic categories?

See #12
Currently, the sub-dashboard that splits out object allocations into separate panels for different classes does so by simply containing a hardcoded list of classes that are filtered for. For example, int[] here:
https://github.com/cryostatio/cryostat-grafana-dashboard/blob/ca315d0a3a71ac71079ce743c4d6a9a11e759d55/dashboards/obj_alloc_sample.dashboard.json#L278
However, on the main dashboard, this is done with a wildcard query:
https://github.com/cryostatio/cryostat-grafana-dashboard/blob/ca315d0a3a71ac71079ce743c4d6a9a11e759d55/dashboards/main.dashboard.json#L1178
Is there a way to dynamically generate the sub-dashboard so that it has separate panels for each class in the dataset?
Right now, the main dashboard panel for allocations is complete and accurate to the underlying JFR data, but it can be hard to read because the data is too dense. The sub-dashboard splits it out, reducing the density and making it legible, but it is actually representing incomplete data because any class that is not hardcoded to the layout will not be rendered at all.

Actually, it seems that the sub-dashboard does somehow pick up on additional classes that are not hardcoded already - though I'm not really sure how. Need to investigate more into variable templating and things, I think.

Actually, it seems that the sub-dashboard does somehow pick up on additional classes that are not hardcoded already - though I'm not really sure how. Need to investigate more into variable templating and things, I think.

I remember (vaguely) this is indeed done using Grafana variables, which calls the data-source /search endpoint:
https://github.com/grafana/simple-json-datasource?tab=readme-ov-file#search-api. This variable is then templated into the panel query ${objectClass}.

Ah thanks @tthvo , I had figured out the variable templating bit but the /search hint helped me fix something else I was doing wrong :-)
https://github.com/cryostatio/cryostat-grafana-dashboard/pull/68/commits/bdbef6331cfd91230a58a3c6ce33f0845f3cdd02


Update testdataset asBulit to 1.6.3

As testmanager ,
I want to have the latest testdataset,
so that i can test with latest parts.
Hints / Details

see testdataset (download-link)
added SingleLevelBomAsSpecified and PartAsSpecified (TDG-4)
hasAlternatives set to "false" (TDG-31)
changed URN to "samm" for Batch, ProductDescription and SingleLevelBomAsSpecified (TDG-33)

Outcome / Acceptance Criteria
Outcome

Testdataset asBuilt 1.6.3 can be used for testing on DEV and INT.

Acceptance Criteria

[ ] Testdataset asBuilt has been updated to 1.6.3.

Out of Scope

Issues with testdataset -> For any issues with testdataset testmanager will create TDG ticket to fix.

Blocked until a Testdata file has been released with changes affecting our scope

@jzbmw there is already a newer version 1.7.0 I will close this.


Duplicate bevy_egui dependency

Related to #141.
error[duplicate]: found 2 duplicate entries for crate 'bevy_egui'
   ┌─ /home/tim/Documents/bevyengine/Emergence/Cargo.lock:42:1
   │
42 │ ╭ bevy_egui 0.17.1 registry+https://github.com/rust-lang/crates.io-index
43 │ │ bevy_egui 0.18.0 registry+https://github.com/rust-lang/crates.io-index
   │ ╰──────────────────────────────────────────────────────────────────────^ lock entries
   │
   = bevy_egui v0.17.1
     └── bevy_pancam v0.7.0
         └── emergence_lib v0.1.0
             └── emergence_game v0.1.0
   = bevy_egui v0.18.0
     └── bevy-inspector-egui v0.15.0
         └── debug_tools v0.0.2
             └── emergence_lib v0.1.0
                 └── emergence_game v0.1.0

This results in a ton of over duplicate dependencies as well.
bevy_pancam already bumped the dependency on their side:
https://github.com/johanhelsing/bevy_pancam/blob/e406cf9be7a106ad9c8463d067f10d4ac213a525/Cargo.toml#L18
We basically just have to wait for a new release and upgrade to that.

Closed by #180.


update to master

Hi @rofrol. Could you please explain the changes in the PR? Also, what does the reference to rofrol/beho--zig-csv/archive/c8bbbeb894ef6835a4c0341fc2326b476a3e86d4.tar.gz do?


[feat][msic] Upgrade oxia version to 0.4.9

Motivation
Upgrade the Oxia version to 0.4.9 to fix several connection-related bugs.
Modifications

upgrade the oxia version to 0.4.9

Verifying this change

[x] Make sure that the change passes the CI checks.

Documentation

[x] doc-not-needed

Please update this file:
https://github.com/apache/pulsar/blob/27158532de26d40e7a402769e73ddd3be43f0623/distribution/server/src/assemble/LICENSE.bin.txt#L484-L485

Yes, you are right. let me rebase first. :)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.34%. Comparing base (bbc6224) to head (ed0e03a).
Report is 734 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23607      +/-   ##
============================================
+ Coverage     73.57%   74.34%   +0.77%
- Complexity    32624    34967    +2343
============================================
  Files          1877     1944      +67
  Lines        139502   147127    +7625
  Branches      15299    16225     +926
============================================
+ Hits         102638   109386    +6748
- Misses        28908    29298     +390
- Partials       7956     8443     +487

Flag
Coverage Δ

inttests
27.56% <ø> (+2.98%)
:arrow_up:

systests
24.39% <ø> (+0.06%)
:arrow_up:

unittests
73.71% <ø> (+0.87%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 656 files with indirect coverage changes


fluent-plugin-elasticsearch config options are missing

There are quite a few configuration options from https://github.com/uken/fluent-plugin-elasticsearch#configuration missing at https://docs.fluentd.org/output/elasticsearch#parameters
The particular settings I need are ca_file, client_cert and client_key.
AFAIS the only way to use them, is to mount my own fluent.conf. But this seems wrong to me.

@domruf
Thank you for the feedback.
But in that section, it is not intended to explain the fully supported parameters.
That is why a further reading section is put on.

If you want to include the above parameters, we are welcome to your PR.


Outliers or extremes

Within the currently GHCN Daily flags it is possible for an extreme observation to be falsely flagged as an outlier, "O".
For details of the current quality assurance procedures see:
https://journals.ametsoc.org/view/journals/apme/49/8/2010jamc2375.1.xml

10.1111/1467-9876.00413

Pseudo code:

Flagged as "O"
Identify surrounding neighbours
Check their observations and look at whether it is spatially consistent
Propose a flay "TE" - suspected true extreme


PLEASE STOP THIS PROJECT!

Do us (Windows users) a favour and put this effort into improving your command prompt (cmd.exe) which is still lagging behind cmder (conemu) and other terminal emulators out there.
This pseudo Linux Bash just don't feel right - same as cygwin, babun and co. And even if you tried to make it feel right than you would have to reinvent Linux (on Windows!) - which I guess you don't intend to do. For Linux on Windows there are virtual machines (e.g. Vagrant) and containers (e.g. Docker).
Just integrate some of the cool Linux commands seamlessly into Windows's terminal / command prompt and let Windows user have their native user experience. No need for a Linux subsystem or a Linux user on Windows, really  ;-)))

Have you given PowerShell a try instead of always using CMD? A lot of the functionality (if not all) that you are referencing Windows is needing exists in PowerShell. I like seeing Bash on Windows as it allows me to natively run tools that I normally wouldn't be able to run on a Windows box. It's not designed to be a terminal emulator for Windows. They have a lot of work ahead of them but are making good progress.

@Tset-Noitamotua This project actually has very little to do with "Bash on Windows" (imo it is a misnomer).  Bash on Windows is actually a sort of proof of concept for the larger Linux Subsystem.
Windows Console improvements are planned to take place in concert with the Linux subsystem project (WSL), but they are distinct projects inside of Microsoft (even though the teams do work together).
If you noticed, @bitcrazed assigns console issues to @zadjii-msft and not to the other people on this project, and that's because he's the guy working on getting the Windows console working with the bash wrapper (although I don't know if he's formally part of the WSL team or the console team).

I assumed that this was a bit of sarcasm, but since we're discussing it.. PowerShell's learning curve seems to be quite excessive for little obvious benefit to the casual user.

I think it's time for a new model of development and implementation in which free software (and open source) rests on a solid, reliable and modern proprietary kernel code.
All the freedom to develop and deploy you want for your code, but full control of the operating system by two large and serious companies like Microsoft and Canonical, which eliminates at the root development anarchy and fragmentation.
With native support for Linux binaries, the two companies are doing just that: 'open' paradigm suitable to the future.
As it is currently implemented it guarantees countless possibilities of a merger on a single desktop of the best features of those which are now the two Windows 10 garments (the one open and one closed), but in the future I think it is conceivable a WSL autonomous, a MC/* nix (Microsoft-Canonical/* nix) standalone ... maybe based on something similar to the current Hyper-V Server , which is little more than a kernel stripped of everything that isn't necessary bearing layer above the WSL.
You could call it MCNux? :)
I hope that team members don't want to kill me for this post.
I'm sorry for my bad english.

@SecurityWaffle  I always tried to avoid using powershell in the past but since I got in touch with Packer, Vagrant, Docker and the like I thing there is no way around to get familiar with it seriously  ... so it´s on my TODO list :)
And hey, I don´t mean what I wrote as evil as it might sound. As I first heard about this (lets call it by name) WSL (Windows Subsystem for Linux) my first thought was "Great! Finally I can get rid of all that different tools like Cmder, ConEmu, Cygwin, Babun, GitBash etc. and have everything in one place - in a Windows native "terminal" (I know it´s the wrong term) with the ability to execute Linux (like) commands". But after I got a little taste of it (as described here) I am sure that I will stick with Cmder still a while because I like their approach more. I have almost everythink in one place even some linux-like commands and if I am missing something like e.g. wget - I just download the wget.exe for Windows, put it in Cmder's bin directory and there I go, it's on PATH and I can use it from everywhere on my native Windows filesystem. I don´t need to mess around with Linux-like folder structure (/usr/local/bin/) or to deal with two isolated PATHs (one on Windows and one on WSL) not to think about environment variables - with WSL one would have to manage all that stuff twice ... proxy settings, .git config, .ssh config  ... oh my god. I don´t even want to think about it - it´s a nightmare even without WSL :)
All that said, I think that any effort of bringing open source to Windows and vise versa and any enhencement of cross-platform development experience is worth it. So keep up the good work! (But don´t forget to pimp the command prompt ;-))))

@Tset-Noitamotua I think you're misunderstanding the nature of WSL.
WSL is a Windows subsystem ... is part of it as are RT and Win32.
The novelty (and need) lies precisely in this: making Microsoft operating system even more interoperable with all that exists, pushing him into the border once considered impassable (almost there was an invisible Hadrian's wall) of Free Software.
He's still young, he's only a few months old, but its purpose is to make Windows 10 simultaneously owner and free, and make both sides equal.
Give it some time, enjoy the results, and if you can use your skills for aiding the debugging.

I would think that CMDis beyond recovery because of the need to run old scripts.
All of CMD's issues are too deeply in its core.
Take the problems with quoting strings and passing them around as one example.
If you fixed the quoting then you break existing scripts.

Eh, this Issue is a definition of "jumping the gun".
The project has literraly nothing to do with the bash itself, rather, this is an attempt at establishing a solid, concrete bridge between linux and windows ecosystems, to allow windows users to benifit from linux in a ways including, but not limited to, bash shell.
This is the reverse-wine done right.

please NOT stop this project. it is beautifoul!!!

@barry-scott There is no problem with cmd.exe, which is a shell rather than a virtual console/terminal emulator (that program is called the Windows Console Host (conhost.exe)).  Running cmd.exe in Windows actually opens up an interactive cmd.exe session running on conhost.
In theory, there is no reason why cmd.exe would have to be changed or removed, since it is just another shell for the Windows operating system.  The most feature-complete Windows shell is powershell, which also runs in conhost.exe and has deep connections with the Win32 API with native support for things like COM and registry management.  Because Windows uses file extensions to determine default applications to open things, batch scripts (.BAT files) could still open with cmd, while you could set bash.exe as the default program to use to open .sh or .bsh shellscripts from Windows (this doesn't exactly work since they need to be started with special arguments and with a copy of bash running in the background in interactive mode, but the concept works fine).

@Deiru2k & @benhillis I think the project name, bash, is wrong because the people thinks to a simple command processor.

@iz0eyj The official name (on the MSDN blog, in the Windows 10 component manager, etc.) is the Windows Subsystem for Linux, and in the internal Microsoft naming scheme (judging from certain filenames like lxss, lxsessionmanager, lxsession, etc), it apparently is called "lxss".

Digging deeper I am beginning to understand that WSL is about much more
than just the bash shell. In that case the project's name indeed is a bit
missleading. So I am pretty sure I am not going to be the last one who was
trying to use this tool with wrong expectations.
Federico<EMAIL_ADDRESS>schrieb am Fr., 19. Aug. 2016 um 20:00:

@Deiru2k https://github.com/Deiru2k & @benhillis
https://github.com/benhillis I think the project name, bash, is wrong
because the people thinks to a simple command processor.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/BashOnWindows/issues/935#issuecomment-241089911,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFX9hon05zAW_GrzQdfKNtBoJ1XU0Xszks5qhe8xgaJpZM4Jn9AF
.

Then Microsoft should avoid to promote it as BashOnWindows.
fpqc<EMAIL_ADDRESS>schrieb am Fr., 19. Aug. 2016 um 20:22:

@iz0eyj https://github.com/iz0eyj The official name (on the MSDN blog,
in the Windows 10 component manager, etc.) is the Windows Subsystem for
Linux, and in the internal Microsoft naming scheme (judging from certain
filenames like lxss, lxsessionmanager, lxsession, etc), it apparently is
called "lxss".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/BashOnWindows/issues/935#issuecomment-241095750,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFX9hoC4CI3EfujICw05ndmXMAfD-QV8ks5qhfRIgaJpZM4Jn9AF
.

@Tset-Noitamotua They called it "Bash On Windows" because that was the name of the feature that people requested when they first put up the Windows 10 User voice.  In fact, it's much much more than that, so you can't blame them for I guess ginning it up a little bit and giving it an exciting name, since in fact this is just a tiny simple application of the project, almost a proof of concept.

@fpqc Yes, I know all... but for large oart of end-user this project is "bash", and this people thinks it is a simple shell.
Also WSL is wrong, this project needs a "true name", a logo and a changelog included in the main Win10 note of versiin.

@Tset-Noitamotua "Digging deeper I am beginning to understand that WSL is about much more
than just the bash shell"
Glad you're finding that there's considerable value in what we're building.
FWIW, we are working hard to overhaul the Windows Console itself. Console has received little love over the past few decades, but we've got a dedicated, passionate, full-time team working on a major overhaul as I type. Lots more detail to come, but know that there's a lot of good stuff coming to the console over the next few releases.
And re. the naming; we hear ya.

@ericblade Are you sure we have the right distinction here between shell, readline, coreutils, ssh etc.
Most people club these together sbash. Bash is none of these. Bash is the super awful square brackets with spaces required for if while
The tools you see in powershell are the canonical way of doing things. You can continue to use coreutils and no one would judge you. Anecdotal but i had no issues starting in powershell and love it's predictability and specially the canonical verbose way of doing things in maintainable scripts.

@fpqc The details of the conhost vs shell do not have any bearing on the fitness of the shell hosted in it. You did not address the problem of quoted strings in CMD.EXE that makes it very hard to use robustly.

Why is this issue still open? It's clearly a wontfix.

@blueben Great point. I think it's safe to say this discussion has run it's course.

TLDR; Guy comes out of nowhere, complaining that lxss is no better than Cmder. 1) lxss is much more than simply "Bash on Windows". 2) Even if it wasn't, it is clearly NOT another terminal emulator (like Cmder is).

PLEASE DELETE THIS QUESTION (or at least rename it). It's absurd. OP clearly do not know the difference between a shell, a terminal emulator, and what Lxss stands for (also, it's the first hits when someone googles for "Lxss terminal emulator", instead of, say, https://github.com/goreliu/wsl-terminal).

haha ... I wish It would be that easy to get "a first hit" on google with other things, too :)))
I have no pain to rename it. Tell me what title you want it to have. (Hope that it holds it's first position in google search after renaming)

@Tset-Noitamotua, how about renaming it "Is WSL more than just Bash on Windows?"

@shoogle they just did this, it's on the console blog


[1.19.2] Snowballs are not affected by Modify Damage Taken

My guess is that since there is no damage in the first place, the Forge event used for Modify Damage Taken does not fire. This should also apply to eggs.
This is ultimately not super important to fix imo, but it is a part of Blazeborn that isn't present in Forge.

From what I can tell, something happens between Entity.hurt and Entity.actuallyHurt. Forge has hooks in actuallyHurt, maybe not in hurt.
I'll check when I have minecraft's source code in front of me.

The issue is kinda dumb. To avoid staggering the player when it takes a snowball, the game actually prevents damage of 0 specifically to the Player. This doesn't happen in any other context, meaning any other entity with that power would take damage.


Fix key for new locations with hash history

The new test case demonstrates the issue. When you do hashHistory.push(), the new location has a key, but there's no query key and you can never recover that key again; it ends up being a purely in-memory thing.
This code isn't wonderful but it's the best I could find without a more extensive refactor.

I'm not sure how much this matters given other pending work, but this addresses my biggest concern in https://github.com/ReactJSTraining/history/issues/163#issuecomment-201895122 – namely that location.key on a hash history is not null on PUSH transitions.

Rebased

Ping!

@taion You're welcome to cut a 3.x maintenance release with this work in it. The majority of the work for v4 is already done, and I'm focused on shipping that for the time being.

Looks like this has stalled. Please re-open if you'd still like to get this merged into a 3.x maintenance release.


How to get all keys or get all keys by pattern ?

I want to get all key with one pattern  KeysGameOnline:*
I using method Keys in commangds.go but result undefined.

How to get all keys or get all keys by pattern ?

https://redis.uptrace.dev/get-all-keys/


WaitFor for RabbitMQ

Description
Adds WaitFor support for RabbitMQ
Related: #5645
Checklist

Is this feature complete?

[x] Yes. Ready to ship.
[ ] No. Follow-up changes expected.

Are you including unit tests for the changes and scenario tests if relevant?

[x] Yes
[ ] No

Did you add public API?

[ ] Yes

If yes, did you have an API Review for it?

[ ] Yes
[ ] No

Did you add <remarks /> and <code /> elements on your triple slash comments?

[ ] Yes
[ ] No

[x] No

Does the change make any security assumptions or guarantees?

[ ] Yes

If yes, have you done a threat model and had a security review?

[ ] Yes
[ ] No

[x] No

Does the change require an update in our Aspire docs?

[ ] Yes

Link to aspire-docs issue:

[x] No

Microsoft Reviewers: Open in CodeFlow

We gotta disable this repository test. It’s failing all of the PRs
cc @JamesNK @radical

@radical How can I view the log output for this test?

I couldn’t find the logs for that test

Me neither. The test is setup to write output: https://github.com/dotnet/aspire/pull/5701
And I can see test output locally:

Lets disable it and file an issue, I'd like to unblock these PRs.

/azp run


Title: Improve UI

Which pre-existing JavaScript project will you be working on?
113 - Minesweeper Game
Describe your enhancement/improvement
Enhance the UI of the Minesweeper Game, to give a more vintage and classic game experience, like it used to be in Windows XP. Also, I'll implement Glassmorphism effect in order to provide a great User Experience.
Anything you need to say to the Reviewers
Kindly assign me this issue under GSSoC '24.
Add any other context or relevant screenshots about the enhancement here.
Below is a sample of the UI enhancements I want to make to make it visually apealing as well as to provide a great user experience.

@Sambit-Mondal Thank you for providing your insight but it is not required as of now.


Avoid using read to parse SlotNumber

https://github.com/input-output-hk/cardano-node/blob/5e301e0d9fef58033a0aef10b4930473572b1235/cardano-node/src/Cardano/Tracing/Tracers.hs#L186
Caused https://github.com/input-output-hk/ouroboros-network/pull/1106 when consensus changed slot number format.

Resolved in #225


I cant run the server up to 25+ GB [HELP]

@Megabyte918

@NameYT you must run the command from inside of /src, not /run

@Megabyte918
 Still an error

@Megabyte918

@NameYT Exit out of the terminal, open src, shift + right click, "open command window here", then type the command

I dont understandt you what terminal?

okay nvm i did it

@Megabyte918
Still error!

@NameYT

press the "x" located top right of the command window (the black box with white text in it on the screen)
go to the navigation bar (the bar that says MultiOgar-Edited-master > run)
click on MultiOgar-Edited-master in the navigation bar (do not click on run)
once your in the MultiOgar-Edited-master folder, double click on the folder named "src" directly underneath the "run" folder
once your inside the "src" folder, right click an empty space (make sure you dont right click a folder or file)
you should then see a dropdown menu, go down on the dropdown menu until you see something that says "open command window here"
click on that option, a new command window should open (the black box again)
enter that same command that you entered before, and press enter

I've already told you, follow my instructions.


#599 runAsUser not needed

#599 this PR reference an Issue occurs on OpenShift.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Can we in case make this optional rather than just remove it ?

Of course. I already viewed at it. I would implement it, as the other options: With Viper and an annotation.
Can you explain me why the runasuser part is important? I like to understand the advantages in this case.

Replying from my phone so can't really look around that much but if I am not mistaken this defines the container settings for vault agent , in a cluster / namespace that does not allow running as user 0 we need to set this.

I thought about it a bit and looked in the code again. The other containers which are injected, does not bekomm runAsUser: 100. Maybe I should add it to all injected containers?

I thought about it a bit and looked in the code again. The other containers which are injected, does not bekomm runAsUser: 100. Maybe I should add it to all injected containers?

Good point.
Which injected container are you talking about ? I guess "vault-env" and "consul-template"

vault-env builds on top of the vault image ( since i think it will use vault-agent to grab the actual token  ? )  , by default it runs as root, does some permissions changes,  and drop privileges to vault user through docker-entrypoint  - We need to make sure it keeps working when changed to user 100 from this change ( i think it should with no issues )

consult-template - will try to change directory permissions on startup to 100:1000 before dropping privileges to the user, so this as well need to make sure that it keeps working as before.
There were some discussions about uid for consul-template but can't remember exactly what the point was, @jurgenweber might know more about it.
see this

@bonifaido do we have enough checks in the current acceptance-test.sh to ensure that all the webhook different options ( vault-env, consul-template) to make sure it will keep working seamlessly with such a change ?

Unfortunately, the consul-template code paths are not tested in acceptance-test.sh, but it is a very nice (and not extremely hard) challenge to add those :)

I talk about vault-env and the copy container. The consul-template container was not in my scope.

I talk about vault-env and the copy container. The consul-template container was not in my scope.

my bad, i can see now that the consul-template security context is not affected by the change so that should be ok

@aidun looks good and CI is passing , using default values. Would you be able to extend the acceptance test to check the feature is working as expected ?

@primeroz I added some test, with the new annotation. Is that how you imagined it?

before this is merged I will need to test this, that runAsUser is there for a very specific reason and there is a high probability you will just fix it for you and break it for everyone else.

@jurgenweber I think I haven't changed the current behavior and only made it possible to deploy the webhook on OpenShift. This use case is very specific to OpenShift, but on OpenShift the default :/

before this is merged I will need to test this, that runAsUser is there for a very specific reason and there is a high probability you will just fix it for you and break it for everyone else.
So please ensure you maintain current behaviour and manipulate it for your edge case.

Please test it if you get a chance. I am not 100% familiar with the webhook code since i am not running it yet.
I do believe that this change only affect the vault agent init container and vault-env keeping the default behavior as it is now.
Consul-template container should not be affected since the security context for that container is defined in its own function

CircleCI is back, finally the test can excercise this!

The CI now failed because of "resource requests" and amount of cpu on the node used for testing
@bonifaido I would dare say that starting all workloads and checking in the on_finish is not scalable and might need some re-thought going forward
@aidun For the time being rather than check in the on_finish it might be better to start the workloads, check, cleanup the workload

Hi, yes it is not scalable, it is mostly for debugging purposes. What we could do here is to remove the deployments after they went successful to spare some resources, so, for example, we can remove the first like this:
kubectl apply -f deploy/test-deployment.yaml
kubectl wait --for=condition=available deployment/hello-secrets --timeout=120s
+ kubectl delete -f deploy/test-deployment.yaml

Anyhow the test needs to be reworked, but of course not in this PR.

yeah, lets test what we want before the delete for now instead of using the on_finish

Sorry I haven't contacted you. the last few days have been a little stressful.
i've been working with Kubernetes / OpenShift, RBAC, PSP and so on. Some questions arose concerning the implementation and I'm not sure anymore if these are cleanly implementable under OpenShift. For me there were two problems:
The way the containers / init containers are added always requires that the service account under which the init container is started must have extended privileges. Unfortunately I haven't found a reason why this causes problems under OpenShift or why it is necessary for Kubernetes.
Another point is, the required security constraints under OpenShift  require that the executing service account runs with more rights than necessary. Unfortunately, it cannot be restricted to the injected containers. For the Init containers I see no reason to set special SecurityContexts that were not set by the Pod.
At first I thought it could be simplified and reduced to a minimum. I'd like to get more familiar with the topic and analyze it before I jump to conclusions and waste your time with reviews.
For this I have to build a suitable test setup to understand the exact differences between OpenShift SCC and Kubernetes PSP. I'm also looking for a better way to debug the webhook to get to the created but not logged manifest of the init-container.
Until then I would like to withdraw the PR, because it does not lead to the desired goal, the OpenShift support.
But there is nothing to prevent a merge, if it helps the project.

Hello @aidun, sorry to hear about your struggle with OpenShift - unluckily, though they claim to be compatible with upstream Kubernetes by far it is not the case. Its is really a shame, but the main reason they do thinks differently are:

lots of legacy code/architecture back from the OpenStack days
vendor lock-in

@pbalogh-sa will deep dive into the PR in more details and check what and how would make sense to lift from your PR, or propose some alternative solutions.
As always, we appreciate the time you put into the PR and willingness to contribute back, sorry to learn about the OpenShift issues (lucky us, we interact with OpenShift only when we migrate customers over to PKE and Pipeline).

@aidun do you have any plan with this?

fixed by #698


Release process.

This PR defines a release process. I thought it was worthwhile to spell it out before the 0.1.0 release.

I addressed outstanding feedback and will merge now.


Link to ianpartridge/swift-log-syslog backend impl

@ianpartridge implemented a backend for syslog (awesome :-)) so we should link to it so people are easily able to discover it (and any other future implementations we'd want to link to).
The style of this section closely follows swift metrics, where we also have a section about "existing backends."
Sounds good to add like this @ianpartridge or should we reword somehow?
// cc @tomerd @weissi

Sorry about the typo @ianpartridge, fixed :-) Merge at will.

thanks @ktoso


pc-ble-driver: 4.1.1 -> 4.1.4

Signed-off-by: Sirio Balmelli<EMAIL_ADDRESS>

Result of nixpkgs-review pr 123645 at 8718f932 run on aarch64-linux 1

3 packages built successfully:

nrfutil
pc-ble-driver
python38Packages.pc-ble-driver-py


build: Reorder setting of COMMON_CFLAGS

The idea is to allow CFLAGS that come from the user override those used
by Soletta, at least where it makes sense.
Things done include:

Always use -ffloat-store. The way it was checked if it was necessary
before is not compatible with cross-compilers, and we want the
effect of that flag always in any case.
Only use LTO flags in release mode. If the user wants to enable
debug information, they should either set Soletta to a debug build
or make sure to include -fno-lto in their CFLAGS
Set all Soletta CFLAGS first, then include the ones that come from
the user/OS, so it allows users to override other flags or set
optimization levels that match the target OS.
Set -std=gnu99 at the end of everything else. Unfortunately, some
systems build with a different standard set that may enable
STRICT_ANSI and breaks building Soletta, so we need to always
override this value to the one we expect.

Signed-off-by: Iván Briano<EMAIL_ADDRESS>

+1

Merged


dns

any plan for dns over h3?

it's possible, hickory-dns has that support. though it's not the highest priority


The page is not up-to-date and I can't find it in docs repo

InstallerType now supports: exe, msi, msix, inno, nullsoft

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8b884a25-4155-ac22-67b1-afb6d81d9751
Version Independent ID: 2b7bd115-a4d9-17c7-0e21-6d23a0774af6
Content: Submit packages to Windows Package Manager
Content Source: hub/package-manager/package/index.md
Product: dev-environment
Technology: ****
GitHub Login: @denelon
Microsoft Alias: denelon

If the installer is a .exe and it was built using Nullsoft or Inno, you may specify those values instead.  When Nullsoft or Inno are specified, the client will automatically set the silent, and silent with progress install behaviors for the installer.

This information has been added to the manifest article.


Add Cupertino to gallery and add CupertinoButton and many yak friends

#8352

cc @abarth
It's not ready yet. I just wanted to have some code so I can ask you some concrete questions. There's some animation stuff I didn't understand. #8409

Grew a yak farm in the meantime. PTAL

Added a cupertino button version with background
Tweaked the cupertino dialog layout a bit according to http://ios10.greatsimple.io/
Extracted the various cupertino demo to their own pages
Rearranged the flutter_gallery/lib/demo folder a bit
Let cupertino button take a child

Please add a basic control test for CupertinoButton

Oops, forgot test. Added

Oh, sorry.  I was going to recommend that you replace the text with a SizedBox in your layout tests so your tests aren't sensitive to fickle text metrics.


Add a team in a project CR

Hi there,
At the moment, we can create projects, clusters and db users thanks to the operator.
At project creation, the Atlas user to whom belongs the API key set in the secret is automatically added to the project.
However, the addition of a team or multiple users within the project creation process could be useful, actually particurarly for the team by adding the team id and its associated permissions as project properties.
This would avoid the need to do it manually through the UI or API calls.
It could be something like
spec:
  name: Test project
  teams:
  - teamId: 125067d9afe5fe909d3f1b27
    roleNames:
    - GROUP_OWNER
    - GROUP_DATA_ACCESS_READ_WRITE

What do you think ?

This is great feedback, thank you. We will add it to our backlog and will get it done. We will target it for the next release.

Hi @cebidhem -
Sorry for the delay in response on this issue. Are you still interested in using Teams from the Atlas Operator? FWIW, we do have Teams available in the mongocli so it would be possible to automate this kind of scenario (outside of the Atlas Project CR).
Let us know, or if not we will close this and track any further needs.
Thanks-
Jason


modifies list restore handler and handles lists advanced restore

includes GetList in list restore handler
includes GetListsByCollisionKey in list restore handler
updates mock list restore handler

Does this PR need a docs update or release note?

[x] :no_entry: No

Type of change

[x] :sunflower: Feature

Issue(s)
#4754
Test Plan

[x] :muscle: Manual
[x] :zap: Unit test
[x] :green_heart: E2E

All individual PRs have been approved. Apologies for a big PR merge but all changes are Sharepoint Lists specifc


Allow macOS to get local timezone offset if single threaded

Recently support for Linux and BSD was merged to allow code running on those OS's to access the local timezone if code is single threaded. This simply adds support for macOS. num_threads already supports macOS so this just enables it in time.

This is already done on the dev branch.


Typescript Support

Apologies if I have missed it, but it would be really useful if this plugin supported TypeScript, i.e. had a typescript definition file with it. I am happy to help with this if required.

The new commercial version does; this feature will make it into the free version when I release the multithreading support in the commercial version.

Nope, at this point the typings are still only available in the commercial version.

@jacargentina, you can make your own typescript definition file for this package. I have made one with most of the functions based on the free version.
I'll refrain from sharing it here though as I am not sure if @NathanaelA would accept a PR for this since it possibly crashes with his commercial interests. If not an issue I'll gladly submit it as a PR.


[Question] How to adapt the native octree for 3D navigation,

Hey, I'm trying to adapt the native octree to be used as a 3D pathfinding structure for our game. What I need to do is insert all the AABB's of our scene into it and somehow mark the nodes that still intersect a object at max depth as impassable. Do you have a suggestion on how to proceed ? I'm sorta getting lost in the API. Thank you in advance for your time and effort.

I don't think this is suitable to use as a structure for pathfinding directly, at least not without a lot of changes. So I can't help you there unfortunately.
I did however build a pathfinding library myself that utilizes this in a navigation mesh, where it is used to accelerate raycast queries to see where an agent is currently:
https://assetstore.unity.com/packages/tools/behavior-ai/anypath-213200
Good luck!


[WIP] [DO NOT MERGE] initial Linux platform and scripts

WORK IN PROGRESS - DO NOT MERGE
This is a rough port of the GVFS.Platform.Linux classes, and some others, plus the Scripts/Linux scripts, from both the Mac equivalents in this repository as well as those from the microsoft/VFSForGit repository.
This work needs to be refactored to better reflect the original work, if possible, and in particular the commits by @kivikakk.
From commit b304cf72b2a8 in VFSForGit:
    We add the core GVFS.Platform.Linux classes, derived from their
    GVFS.Platform.Mac equivalents but with appropriate changes for
    syscall argument signatures and flag values, type definitions,
    and structure fields (e.g., mode_t is a uint, and the layout of
    struct stat is quite different).

However, a good deal of useful refactoring which exists in microsoft/VFSForGit has not yet been ported; this would (re-)eliminate some of the duplication between the Mac and Linux platforms and move common code into the POSIX one.
There's also an open question of what to do in the LinuxDaemonController; that'll have to be rewritten, obviously.
Running Scripts/Linux/RunUnitTests.sh on my system with .NET Core 3.1.302 reports:
Test Run Successful.
Total tests: 267
     Passed: 267

/azp run microsoft.scalar

@chrisd8088: I started the pipeline as currently-written, and got an error. I expect that you're currently writing GitHub Actions YAML instead, so perhaps that error doesn't matter.

To be honest, I think the decision to merge or not is entirely up to you!  I've been holding off while I experiment with running the functional tests (which break in all kinds of ways), but if you wanted to move forwards with this as it stands, I'm OK with that too -- but I would want to rewrite the commits somewhat at a bare minimum.
There will necessarily be refactoring of the Mac and Linux platforms to get them back to parity with the VFSForGit ones, where we'd made some progress eliminated duplicated code.  Again, that's the sort of thing I thought I would try to get further along before proposing this as a "real" PR.
Let me see if I can clean this up a bit more, at least, tomorrow, if that works for you.  I am happy with the CI builds in Actions, though, so that could also be a separate PR, I suppose.

To be honest, I think the decision to merge or not is entirely up to you!

You're absolutely right, which is why I asked what was still "in progress" as part of your "WIP" designation.

I've been holding off while I experiment with running the functional tests (which break in all kinds of ways), but if you wanted to move forwards with this as it stands, I'm OK with that too -- but I would want to rewrite the commits somewhat at a bare minimum.

Rewriting commits to satisfy your quality bar is definitely something you should take time to do.
I would prefer that we get a PR that runs the build + unit test step before we do the extra work to get functional tests working. Trying to do them all at once sounds like a recipe for PR bloat that will make it hard to review.

There will necessarily be refactoring of the Mac and Linux platforms to get them back to parity with the VFSForGit ones, where we'd made some progress eliminated duplicated code. Again, that's the sort of thing I thought I would try to get further along before proposing this as a "real" PR.

Please don't consider "parity with VFS for Git" a goal. Updating the platforms to reflect necessary platform differences is a valuable effort, but preferably that would be isolated to demonstrating that functional tests start to pass with those changes. The unit tests don't need these platform updates.

Let me see if I can clean this up a bit more, at least, tomorrow, if that works for you. I am happy with the CI builds in Actions, though, so that could also be a separate PR, I suppose.

Yes! I'm very happy to have the GitHub Actions workflows merged to the main branch while you continue to work on the hard platform-specific aspects of the Linux work. Just trying to pull out pieces that can be merged earlier than that.

OK, I can tweak these into two PRs in the next while, one for the basic first pass on the platform, and one for adding the Actions builds.
As for the functional tests, I'm just chipping away at problems, most of which so far have been config issues, but now seem to have something going sideways in FastFetch, but that too could be a config issue at its root.  In brief, nothing too exciting to report there, just chipping at the coal face.

As for the functional tests, I'm just chipping away at problems, most of which so far have been config issues, but now seem to have something going sideways in FastFetch, but that too could be a config issue at its root. In brief, nothing too exciting to report there, just chipping at the coal face.

FastFetch? Where is there still FastFetch code in scalar?

Yeah, don't take that too seriously -- I was just in the midst of debugging, and so far everything is purely config-related.  In that case, FastFetch was turning up because it's part of the test repo in https://gvfs.visualstudio.com/ci/_git/ForTests which is still used in Scalar.FunctionalTests/Settings.cs as test fodder.  Let me get to the point of some "real" failures before commenting in depth, which should be soon, I think.

Latest functional test run was actually pretty successful:
Test Count: 196, Passed: 190, Failed: 2, Warnings: 0, Inconclusive: 0, Skipped: 4.

I'm going to close and reopen so the PR validation runs again (hopefully).


Malfunction of context selection in the workspace.

** Test 1**

Expand git project.
Select the root of git project in the workspace.
Git > Show File History

** Issue 1. **
'Show File History' is enabled even though the root of git project is not a file.
** Issue 2. **
The result of step 3: The dialog of 'Show Repository History' is popped up not a 'Show File History'.

** Test 2**

Clone git repository. (It must be new. That is, it never been expanded in the workspace)

** Issue **
If git repository has not been expanded in the workspace, IDE does not recognize it as git repository.
Therefore,
No icon of git in the git project. No menu list for git project.

I tried Test 2 again.
Then, git repository is recognized as git project before expanding the project.
I think that the problem is occurred because of time. (It might be recognized late sometimes)
It is still a problem.

done.(applied new menu framework)


src/Bugsnag/Request.php:35: Error in exception handler: array_merge():

This breaks if $requestData['request']['params']is not an array.
if(isset($requestData['request']['params'])) {
    $requestData['request']['params'] = array_merge($requestData['request']['params'],$params);
}

May I suggest:
if (isset($requestData['request']['params']) && is_array(isset($requestData['request']['params']))) {
    $requestData['request']['params'] = array_merge($requestData['request']['params'],$params);
}

Thank you for the report and suggestion, @Ralla. Taking a look.

Maybe it's better to check why you're getting such situation:
$requestData['request']['params'] = json_decode(file_get_contents('php://input'));
json_decode returns object instead array. We could add second parameter to its call:
$requestData['request']['params'] = json_decode(file_get_contents('php://input'), true);

@Volind Ah! That was it. I looked at it a few times I didn't notice it wasn't being converted into an associative array. Patching.


include new relic on the dashboard front-end

Pivotal Card
Takes environment variables to configure newrelic.js.

So compact! LGTM!


#211 Fix for using post method (Update/insert documents)

The data obtained from the atomic update is raw data. Which means this still needs to be deserialized to be a valid json string. This exact behaviour is also done within the get method. Making select queries work again.
Closes #211

Hi @Baklap4 !
I think, It's better put this serialization in AtomicUpdate classes to prevent wrong behaviours when some other part of framework use post method from SolrConnection.
What do you think?

Hmmm if all usages of post are used with raw json stringdata i don't see why it should only be updated within the atomicUpdate class.

I think changes in SolrConnection is against single responsibility principle, because this class is used to send data to SOLR server.
How this data is created or manipulated, is not they responsibility.

True, yet you do exactly the same with a get request: https://github.com/solr-express/solr-express/blob/master/src/SolrExpress.Solr5/SolrConnection.cs#L53 ?

You are correct!
But I will do a review in v.5
Tks for your fix 😄


Allow non IP value in DNS global setting

It will be interesting to allow user to add non ip value in DNS global settings.
We can use this in wireguard to specify the local domain to search (eg: .home)
DNS = <IP_ADDRESS>, home

From wg-quick man page:

DNS — a comma-separated list of IP (v4 or v6) addresses to be set as the interface's DNS servers, or non-IP hostnames to be set as the interface's DNS search domains. [...]

+1, I faced the same problem, want to set search domain by default


Upgrade Carbon deps to v10.10.x

There are several fixes needed in this upgrade. This work will have to be done post MAS MVP release.
Complete when:

[ ] update all carbon deps
[ ] test our stories for defects

MAS team depends on the latest carbon updates, Notification component
Carbon:

Addons:

We will need too take this into account: https://github.com/carbon-design-system/carbon/pull/5379

<EMAIL_ADDRESS>
Bug fixes 🐛
fix(tag): define default tag style (#5677) (f8b485066)
fix(button): prevent hover on disabled buttons in g90/g100 theme (#5678) (04ae1e92d)
fix(tile): change expandable tile to button (#5609) (fbab6c0bd)
fix(components): remove @carbon/icons from peerDependencies (#5656) (39e612536)
fix(button): prevent icon and tooltip jumping for tertiary button (#5618) (f32c1a611)
fix(code-snippet): set correct width for feedback container in Safari (#5601) (0917bb27e)
fix(progress-indicator): use circle--filled icon (#5585) (7ae99155c)
fix(tile): add non link styling to clickable tile (#5591) (20517eb72)
fix(SideNav): disregard hover on non-rail SideNav when closed (#5562) (b494e528d)
Bug fixes 🐛
fix(button): prevent text jump in disabled button set (#5556) (38fb161af)
fix(dependencies): update icons dependency in vanilla (#5574) (f793a156a)
fix(toggle): change spacing to match style guide (#5462) (bbe9f0d50)
fix(link): use hover color token for visited links (#5559) (8b03644ec)
fix(tooltip): wrap icon tooltip content (#5544) (dfc695617)
fix(modal): change bottom margin (#5510) (3b7314442)
fix(tabs): update tab styles (#5482) (2c14be25b)
fix(modal): set half width single buttons (#5502) (80903ac57)
fix(Slider): onRelease not always firing (#2695) (#5359) (f5b7d0be9)
fix(overflow-menu): correct hover color (#5513) (40613c234)
New features 🚀
feat(tooltip): add support for hoverable definition tooltip body (#5323) (550bc70d0)
feat(select): add height variations to select (#5311) (6d23a7044)
feat(notification): add info icon to notification (#5203) (189c1c30f)
feat(react): add Grid components (#4894) (354baa82b)
feat(progress-indicator): update to use carbon icons (#5122) (aa33fa0c5)
feat: add Esc key support to dismiss tooltips (#5147) (f03a0a122)
feat(progress-indicator): adds hidden span to announce state of completion (#5125) (99fde8e0d)
feat(progress-indicator): add vertical progress indicator to react (#5146) (1532cf721)
feat(box-shadow): remove deprecated layer, use box-shadow mixin (#5126) (aed0ea253)
feat(text-input): add height variations to text input (#5076) (7011d0bf6)
feat(grid): add zero span columns (#5052) (a0752cd65)
feat(list-box): update selection style (#4753) (9e6335fdf)
Bug fixes 🐛
fix(data-table): correct padding for batch action buttons (#5413) (b3e0b3502)
fix(list-box): reset multiselect selection count position (#5405) (a0bc366d3)
fix(toggle): prevent text from wrapping (#5393) (a84e31c51)
fix(list-box): remove 32px margin right on option (#5400) (382df0407)
fix(number-input): fix positioning when no label is present (#5376) (18f3c8350)
fix(button): reduce ghost button left/right padding (#5334) (5454ef5af)
fix(combobox/text-input): add svg top positioning for IE11 (#5362) (347185b85)
fix(dropdown): ensure inline dropdown has light variant (#5322) (ee3229485)
fix(progressindicator): adjust styles for progress step with optional label position (#5356) (ea14f9874)
fix(button): update icon only ghost button colors (#5313) (8adc849d7)
fix(data-table): fix row sizing with overflow menu (#5292) (0aa38ec76)
fix(_header.scss): fixed head base nav with mobile first approach (#5238) (24429b8d6)
fix(accordion): resolve accordion header z-index issue (#5276) (554c9cee4)
fix(accordion): only target direct child p tags (#5291) (48c9e68b0)
fix(button): use currentColor as icon fill for all states (#5270) (0f9aef286)
fix(notification): inline notification fits parent container (#5268) (004c6143d)
fix(modal): add padding to last child only when scrolling is true (#5267) (a2424745a)
fix(tokens): update color tokens (#5240) (6093c2e45)
fix(code-snippet): use Carbon focus outline and reposition scroll bar (#5233) (ac8bcbd92)
fix(link): remove visited styles by default (#5239) (3c6bff698)
fix(file-uploader): adjusts default button and removes clear file button (#5166) (054b1da43)
fix(ui-shell): remove role='menu' from ui-shell (#5235) (eb9412f9d)
fix(inline-dropdown): vanilla style fixes (#5223) (7059be47e)
fix(search): update search icon to correct token (#5222) (51a3c0a31)
fix(data-table): remove hover styles from thead checkbox (#5209) (7e299c0db)
fix(button): correct sizes for icon-only buttons (#5195) (7e83aa779)
fix(code-snippet): remove focus from snippet container (#5202) (625a98bb7)
fix(button): remove margin added by safari (#5169) (2ce57b31b)
fix(select): change light select hover color token (#5150) (76f800906)
fix(datatable): add padding so search clear button doesn't obstruct text (#5145) (c39173f63)
fix(button): set min-height for field buttons (#5176) (2541e34d6)
fix(inline-loading): update type token (#5172) (6c6341473)
fix(storybook): remove layer import (#5160) (e3b3f0e2e)
fix(text-input): rename sizing props (#5167) (8c577c53c)
fix(tag): add default cursor to non-filter tag (#5140) (0fbfae935)
fix(modal): prevent modal from shifting when scrollbar appears (#5119) (1b3fe3a0f)
fix(date-picker): use correct background for date picker in modal (#5123) (08b6d3cbe)
fix(list): left align numbers (#5100) (d8aa52c8e)
fix(date-picker): adjust style slectors for disabled or prev/next days (#5085) (dc3de3416)
fix: duplicate id data-table in carbon-website (#5080) (baf2e0ae4)
fix(multiselect): fix invalid inline multiselect error icon (#5075) (67adf172d)
fix(accordion): update accordion breakpoints (#5074) (783b7c43b)
fix(data-table-skeleton): remove unnecessary border bottom (#5040) (7af549fcf)
fix(modal): fix modal content padding for regular size (#5046) (62453e7c6)
fix(modal): add transparent outline for high contrast themes (#5037) (e3752093c)
fix(tag): ensure tag keeps pill shape with single character (#5053) (7246188b2)
fix(ui-shell): remove role="menuitem" from header links (63c950e94)
fix(tabs): truncate container tab header text with ellipses (#5035) (532ebc864)
fix(text-area): set wrapper to width:100% to span container (#4995) (30dcf4238)
fix(list): explicitly remove list-style (#5000) (172b32fe3)
fix(list-box): fix dropdown item sizes (#5128) (2975d56db)
fix(dropdown): restore default dropdown height (#5118) (7e91692d8)
fix(listbox): set default title attributes to item text (#5102) (62024063d)
fix(list-box): ensure size variants are in effect (#4928) (0e4d6a82f)
fix(grid): moved vertical spacing to col (#4960) (ed368b1a9)
fix(Tag): ignore click events when disabled (#4792) (3264b8c22)
fix(CodeSnippet): use tooltip styles for feedback and add animation (#4741) (62217bdc0)
fix(uishell): add bgcolor to active links (#4980) (e46d9e4bb)
fix(text-area): change disabled light textarea background colors (#4983) (8f7a077b7)
fix(accordion-skeleton): add margin between icon & text when align=end (#4963) (1ce37896a)
fix(breadcrumb): set visited color to link-01 token (#4976) (ddf3afa42)
fix(checkbox-skeleton): apply skeleton class to checkbox (#4923) (4af62e67f)
fix(tag): adds various fixes for screen reader accessibility; adds AAT (#4863) (00786f81a)
fix(styles): add error handling for rem & em sass functions (#4931) (51558b60a)
fix(styles): update placeholder colors (#4799) (69d495ad4)
fix(code-snippet): maxheight 100% for expanded multi and add padding (#4915) (52145edbe)
fix(inline-notification): add 8px right padding if close button is hidden (#4873) (16f50a617)
fix(styles): replace old spacing vars with new syntax (#4889) (0fa982a91)
fix(button): update focus styles to use box-shadow (#4867) (8495b36f2)
fix(list-box): update chevron position for IE11 (#4898) (bb634cc9a)
fix(multi-select): close button for tags (#4890) (e2fa31ae5)

<EMAIL_ADDRESS>
Housekeeping 🏠
chore(release): v10.10.3 (109634091)
chore(release): v10.10.3-rc.1 (c78c9480c)
chore(project): sync generated files (af8895e87)
chore(release): v10.10.3-rc.0 (25fa5140a)

<EMAIL_ADDRESS>
Bug fixes 🐛
fix(icon): Remove redundant 16px variants (#5563) (ad8af68ce)
Bug fixes 🐛
fix(icons): include build-info.json in files for svelte team (#5536) (5a4587011)
fix(icon): makes up-to-top = back-to-top (#5509) (3e7b3daec)
New features 🚀
feat(icons): add icons from the January and February batch (#5342) (b82f079d5)
feat(icons): add December icon batch (#5015) (66b4833f2)
Bug fixes 🐛
fix(icon): embiggen caret and sort carets icons (#5412) (29f416db3)
fix(icons): update 32/settings--adjust.svg to use new geometry (#5361) (7e7bfeb40)
fix(icons): update switcher 32 geometry and overflow menus (#5314) (b49d5871e)
fix(ui-shell): fix onclick menu bugs (#5274) (616b18259)

<EMAIL_ADDRESS>
Bug fixes 🐛
fix(data-table): require additional props in certain situations (#5682) (c095b57d8)
fix(combo-box): add title attribute to input field (#5621) (854c1b21f)
fix(tag): define default tag style (#5677) (f8b485066)
fix(Tooltip): use valid prop name for tabIndex (#5679) (ffd588f1d)
fix(tile): change expandable tile to button (#5609) (fbab6c0bd)
fix(TableToolbarSearch): set focus on expanded search bar (#5637) (d6916b531)
fix(DropdownSkeleton): remove div role (#5619) (cc93f33ac)
fix(text-input): use placeholder text as title attribute (#5622) (b0494ea08)
fix(structured-list): remove unused prop (#5592) (6bc7f8b7a)
fix(icon-build-helpers): disable svgo plugins that cause rendering issues (#5603) (c0ae87bbc)
fix(progress-indicator): use circle--filled icon (#5585) (7ae99155c)
fix(tile): add non link styling to clickable tile (#5591) (20517eb72)
fix(InlineNotification): make statusIconDescription optional (#5528) (952c780cb)
fix(SideNav): disregard hover on non-rail SideNav when closed (#5562) (b494e528d)
Bug fixes 🐛
fix(button): remove role="button" from button styled anchors (#5522) (76e97f7c8)
fix(ui-shell): remove role="menuitem" from Switcher li's (#5525) (80d767b95)
fix(FileUploader): respect multiple prop in default file uploader (#5492) (f12617178)
fix(Slider): onRelease not always firing (#2695) (#5359) (f5b7d0be9)
New features 🚀
feat(tooltip): add support for hoverable definition tooltip body (#5323) (550bc70d0)
feat(select): add height variations to select (#5311) (6d23a7044)
feat(components): support automatic focus sentinel (#5260) (0e9c6d525)
feat(Tooltip): add several ARIA attributes (#5282) (45acec0b9)
feat(SideNavMenu): collapse submenu on esc keydown (#5198) (0853d381a)
feat(notification): add info icon to notification (#5203) (189c1c30f)
feat(react): add Grid components (#4894) (354baa82b)
feat(react): add support for rollup in bundles (#5185) (540889922)
feat(progress-indicator): update to use carbon icons (#5122) (aa33fa0c5)
feat: add Esc key support to dismiss tooltips (#5147) (f03a0a122)
feat(DataTable): allow additional contents to expand cells (#5060) (f3422c438)
feat(progress-indicator): adds hidden span to announce state of completion (#5125) (99fde8e0d)
feat(progress-indicator): add vertical progress indicator to react (#5146) (1532cf721)
feat(text-input): add height variations to text input (#5076) (7011d0bf6)
feat(data-table): add colSpan prop for TableHeader (#5088) (c061bccca)
feat(list-box): update selection style (#4753) (9e6335fdf)
feat(ListBox): fix labels of trigger buttons (#4820) (f87a204f6)
feat(file-uploader): add support for onChange (#4906) (66abfcf77)
Bug fixes 🐛
fix(Copy): add aria-live to announce text updates (#5386) (75acb174e)
fix: Prevent Tooltip setState call if not open (#5363) (aa276b2f0)
fix(number-input): remove default value for label (#5347) (acb94588f)
fix(ui-shell): add check for if href exists when handling onBlur (#5352) (50b14ff8c)
fix(button): update icon only ghost button colors (#5313) (8adc849d7)
fix(OverflowMenu): call closeMenu method only when menu is open (#5336) (61d137373)
fix(search): switch search role from datatable to search, add labeledby (#5330) (7e4c0e5b1)
fix(DatePicker): ensure down arrow opens calendar dropdown (#5326) (57914e5fa)
fix(HeaderMenu): re-enabled links in submenu (#5296) (55f44c9cc)
fix(ui-shell): fix onclick menu bugs (#5274) (616b18259)
fix(notification): update status icon description prop (#5266) (3e77d6d07)
fix(tooltip): ensure tooltip is not hidden in storybook (#5304) (b8c1e1c57)
fix(ui-shell): update SideNavLink proptype (#5256) (5822571de)
fix(ui-shell): allow custom classes on HeaderSideNavItems (#5275) (4b9cc7c2e)
fix(slider): change prop to stepMultiplier and deprecate stepMuliplier (#5251) (dbce79476)
fix(number-input): adjust invalid logic and add proptype check for value (#5217) (115de18a2)
fix(link): remove visited styles by default (#5239) (3c6bff698)
fix(file-uploader): adjusts default button and removes clear file button (#5166) (054b1da43)
fix(ui-shell): remove role='menu' from ui-shell (#5235) (eb9412f9d)
fix(Tab): hoist tab role to upper element (#5173) (d6a36a9d9)
fix(data-table): also add ref to non-sortable branch in TableHeader (#5204) (132dbfb46)
fix(code-snippet): remove focus from snippet container (#5202) (625a98bb7)
fix(FilterableMultiSelect): open item list when searching (#5192) (8faf1f7b1)
fix(tile): adds onChange call to handlers in selectable tile (#5156) (1ebf04a16)
fix(TableToolbarSearch): allow default values to be set (#5089) (e97a7ed9b)
fix(multiselect): replace checkbox with visually identical element (#5039) (88fd0afbe)
fix(storybook): remove layer import (#5160) (e3b3f0e2e)
fix(text-input): rename sizing props (#5167) (8c577c53c)
fix(tag): add default cursor to non-filter tag (#5140) (0fbfae935)
fix(Tabs): allow keyboard event defaults (#5124) (cd62e62a4)
fix(tabs): un-comment hidden prop to be add to root elem (#5120) (b30d5f688)
fix(time-picker): update icon to chevrondown16 (#5115) (fd67b897e)
fix(TableBatchActions): ensure hidden action bar un-focusable (#5081) (b994c9af8)
fix(breadcrumbs): add spread attribute to root node (#5108) (cb2a1ecbd)
fix(pagination): use descriptive id for right hand select (#5109) (f04f03b88)
fix(TooltipIcon): add new direction prop types (#5051) (b5b4cb54b)
fix(ui-shell): remove role banner from header ui-shell (#5077) (766929991)
fix(Tabs): add ARIA attributes (#4970) (0add8cc8a)
fix(structured-list): fix DAP errors (#5066) (0f1f2876f)
fix(ui-shell): remove role="menuitem" from header links (63c950e94)
fix(code-snippet): update export pattern to include missing export (de233aad2)
fix(tabs): truncate container tab header text with ellipses (#5035) (532ebc864)
fix(InlineLoading): change error icon to filled (#5018) (2f9ffa67e)
fix(FileUploaderDropContainer): fix NPE selecting file (#4936) (f4cb71c98)
fix(uishell): close HeaderMenu on blur (#5003) (79fc14b2e)
fix(listbox): set default title attributes to item text (#5102) (62024063d)
fix(Tag): ignore click events when disabled (#4792) (3264b8c22)
fix(DatePicker): fix programmatic set of date in range mode (#4814) (ba9616498)
fix(DatePicker): fix calendar dropdown position (#4846) (4a7f458a3)
fix(CodeSnippet): use tooltip styles for feedback and add animation (#4741) (62217bdc0)
fix(Tabs): ignore disabled tabs on keyboard navigation (#4784) (f430a1446)
fix(radio-tile, selectable-tile): deprecate iconDescription and add handleOnChange function (#4966) (6a70073ea)
fix(ComboBox): bring IME support back (#4952) (f788410fa)
fix(checkbox-skeleton): apply skeleton class to checkbox (#4923) (4af62e67f)
fix(DatePicker): explicitly update minDate and maxDate (#4912) (731583027)
fix(date-picker): support changing date format (#4856) (2ca548e62)
fix(ComboBox): ensure unique keys (#4999) (b92e2407b)
fix(multi-select): fix DAP violations (#4991) (8a20d0e5e)
fix(dropdown): use itemToElement for selected label if not null (#4977) (057e35cfc)
fix(tag): adds various fixes for screen reader accessibility; adds AAT (#4863) (00786f81a)
fix(dropdown): revert id change to have stable identifier (#4935) (a506f76ae)
fix(search): adjust icon and hover styles on Close16 button for Chrome's new autofill color (#4891) (62dee03b5)
fix(button): add elementType to 'as' property type check (#4893) (#4895) (0144dfeea)
fix(devenv): use content margin style for expanded side nav (#4886) (4bd977619)
fix(inline-notification): add 8px right padding if close button is hidden (#4873) (16f50a617)
fix(table-header): forward ref for (#4877) (f65f115dc)
fix(UIshell): adds story for SkipToContent and removes the tabIndex prop requirement (#4875) (04ed48019)
fix(data-table): update menu to match visible and accessible labels (#4862) (7663fe682)

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Bug fixes 🐛
fix(colors): update rgb hex colors clr (#5139) (1a7203300)

delete layer global mixin
copy old formItem story since Carbon deleted theirs. This lets people be aware of it from storybook.
SideNav has some css changes needed for menu sub items

MAS team depends on some fixes done in FileUploaderContainer
https://github.com/carbon-design-system/carbon/pull/4936

Carbon removed handleTabAnchorFocus in https://github.com/carbon-design-system/carbon/commit/83ddb6a722cd5b5de9e947feafffccb1173de048#diff-fc9dc2c53f4ac6f9a14e2ff6741c85af. Good catch Taylor


Automate deploy of Storybook

Run yarn deploy-storybook every time a PR gets merged

Would also be nice to deploy storys for PRs to some temp location so that reviewers can check them out before merging.

I've started work on setting up deployments of static-storybook on PR to an s3 bucket: https://github.com/devlucky/react-audio-vis/pull/24


Drag Selection perf problem

Describe the bug
It feels slow when dragging on Flow Editor to select multiple Action nodes.

Version

Browser

[ ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Screenshots

Additional context

I got a solution to optimize this scenario.

During drag selection, commit to local cach instead of shell state
After a mouseUp event on canvas area is detected, commit selected ids to shell state.

I'll close this issue after validated on the newest main branch (where Leilei had optimized the perf problem a lot)

This problem is relieved a lot after our perf optimization work. Thanks to Leilei @lei9444


touchGuard intercept fabMenu's touch event

In click callback sample, i am noticing that i always need to double click the fabMenuItem to show the snackbar. The first click was intercepted by touchGuard.
My OS : Android 6.0.1, CM13.1
AndroidStudio:2.2.2

This should be closed, surely?


New angular dependencies

Hi Zemke. I am testing your code and I would like to add some dependencies using npm running the following command at the project root:
npm install datatables.net
I can see npm downloading the files to a node_modules at the project root. However I see there is an angular_modules at resources/assets/js/libs/angular_modules. The gulpfile includes this folder with 'libs/**/*.js'. My question is: within your app, which would be the proper way to use npm to install a library and use it inside a controller? Thanks.

As it is right now, you'd manually add the dependencies. To keep it simple and focused on Laravel and AngularJS integration, I did not include anything like that.
There's a pull request #25 by @pierrerigal that introduces Bower integration. You could take advantage of that and do dependency management with Bower.


[ISSUE #6355] Add logback placeholder default value to avoid brokerLogDir_IS_UNDEFINED

What is the purpose of the change
fix #6355
Brief changelog
add logback placeholder default value to avoid brokerLogDir_IS_UNDEFINED

Has this change been tested on the Windows?


style(pdk): rename some variables

Summary
KAG-6036
It is a follow up of #14025
Checklist

[ ] The Pull Request has tests
[ ] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

cherry-pick is blocked by https://github.com/Kong/kong-ee/pull/11082


target.getAttribute is not defined

Even with some of the simplest components, I keep getting the following error (paraphrase from Firefox console although it seems to happen in all browsers):
TypeError: target.getAttribute is not a function
getTypeIndex()                document-register-element.max.js:422
verifyAndSetupAndAction()     document-register-element.max.js:520
loopAndVerify()               document-register-element.max.js:397
onReadyStateChange()          document-register-element.max.js:469

The following is a sample of my component:
let Star = document.registerElement('x-star', {
  prototype: {
    createdCallback() {
      console.log('created')
    },
    attachedCallback() {
      console.log('attached')
    }
  }
})

Other frameworks/library involved? Cause AFAIK your basic example is tested
and works pretty much everywhere,  not sure I can do much in here
On Oct 17, 2015 10:38 PM, "Caleb Meredith"<EMAIL_ADDRESS>wrote:

Even with some of the simplest components, I keep getting the following
error (paraphrase from Firefox console although it seems to happen in all
browsers):
TypeError: target.getAttribute is not a function
getTypeIndex()                document-register-element.max.js:422
verifyAndSetupAndAction()     document-register-element.max.js:520
loopAndVerify()               document-register-element.max.js:397
onReadyStateChange()          document-register-element.max.js:469
The following is a sample of my component:
let Star = document.registerElement('x-star', {
prototype: {
createdCallback() {
console.log('created')
},
attachedCallback() {
console.log('attached')
}
}
})
—
Reply to this email directly or view it on GitHub
https://github.com/WebReflection/document-register-element/issues/40.

this page works as expected:  http://webreflection.github.io/document-register-element/test/examples/x-star.html
Bear in mind it's full of obtrusive frameworks out there, these might not play that well with polyfilled standards .