Fix some small grammatical errors in the contributing doc

What does this pull request do?
Fixes some small things I found when reading through the CONTRIBUTING guide just now.
Related issues
n/a

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: [Pull request #945 opened]

Reason: The PR is not allowed to run in the CI yet

Start Time: 2020-10-12T20:09:50.251+0000

Duration: 3 min 48 sec

Commit: 15eaca59e7b36306d5fdb4d9d185aadf77cc21da

Steps errors
Expand to view the steps failures

Name: Error signal

Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

Duration: 0 min 0 sec

Start Time: 2020-10-12T20:12:34.785+0000

log

Log output
Expand to view the last 100 lines of log output

[2020-10-12T20:12:10.470Z]  > git merge 79e722dc5240d10c2fadbfcf9e44327afdbb4245 # timeout=10
[2020-10-12T20:12:10.485Z]  > git rev-parse HEAD^{commit} # timeout=10
[2020-10-12T20:12:10.496Z]  > git config core.sparsecheckout # timeout=10
[2020-10-12T20:12:10.500Z]  > git checkout -f 15eaca59e7b36306d5fdb4d9d185aadf77cc21da # timeout=15
[2020-10-12T20:12:14.172Z] Commit message: "Fix some small grammatical errors in the contributing doc"
[2020-10-12T20:12:14.172Z] First time build. Skipping changelog.
[2020-10-12T20:12:14.172Z] Cleaning workspace
[2020-10-12T20:12:14.248Z]  > git --version # timeout=10
[2020-10-12T20:12:14.253Z]  > git --version # 'git version 2.17.1'
[2020-10-12T20:12:14.258Z] fatal: bad object bb43e5e89f62e8063fa4b74e1218b2f983fe870c
[2020-10-12T20:12:15.055Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2020-10-12T20:12:14.176Z]  > git rev-parse --verify HEAD # timeout=10
[2020-10-12T20:12:14.180Z] Resetting working tree
[2020-10-12T20:12:14.180Z]  > git reset --hard # timeout=10
[2020-10-12T20:12:14.211Z]  > git clean -fdx # timeout=10
[2020-10-12T20:12:15.137Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2020-10-12T20:12:15.278Z] Timeout set to expire in 1 hr 0 min
[2020-10-12T20:12:15.553Z] [INFO] Number of builds to be searched 10
[2020-10-12T20:12:15.716Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2020-10-12T20:12:15.742Z] Running in /var/lib/jenkins/workspace/thon_apm-agent-python-mbp_PR-945/src/github.com/elastic/apm-agent-python
[2020-10-12T20:12:15.790Z] [INFO] gitCheckout: Checkout SCM PR-945 with default customisation from the Item.
[2020-10-12T20:12:15.822Z] [INFO] Override default checkout
[2020-10-12T20:12:15.896Z] Sleeping for 10 sec
[2020-10-12T20:12:26.087Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2020-10-12T20:12:26.178Z] Wiping out workspace first.
[2020-10-12T20:12:26.190Z] Cloning the remote Git repository
[2020-10-12T20:12:26.190Z] Using shallow clone with depth 3
[2020-10-12T20:12:26.190Z] Avoid fetching tags
[2020-10-12T20:12:26.211Z] Cloning repository git@github.com:elastic/apm-agent-python.git
[2020-10-12T20:12:26.239Z]  > git init /var/lib/jenkins/workspace/thon_apm-agent-python-mbp_PR-945/src/github.com/elastic/apm-agent-python # timeout=10
[2020-10-12T20:12:26.254Z] Fetching upstream changes from git@github.com:elastic/apm-agent-python.git
[2020-10-12T20:12:26.255Z]  > git --version # timeout=10
[2020-10-12T20:12:26.263Z]  > git --version # 'git version 2.17.1'
[2020-10-12T20:12:26.264Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-10-12T20:12:26.269Z]  > git fetch --no-tags --progress -- git@github.com:elastic/apm-agent-python.git +refs/heads/*:refs/remotes/origin/* # timeout=15
[2020-10-12T20:12:27.515Z] Cleaning workspace
[2020-10-12T20:12:27.538Z] Using shallow fetch with depth 3
[2020-10-12T20:12:27.538Z] Pruning obsolete local branches
[2020-10-12T20:12:27.491Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-python.git # timeout=10
[2020-10-12T20:12:27.495Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-10-12T20:12:27.507Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-python.git # timeout=10
[2020-10-12T20:12:27.519Z]  > git rev-parse --verify HEAD # timeout=10
[2020-10-12T20:12:27.526Z] No valid HEAD. Skipping the resetting
[2020-10-12T20:12:27.527Z]  > git clean -fdx # timeout=10
[2020-10-12T20:12:27.543Z] Fetching upstream changes from git@github.com:elastic/apm-agent-python.git
[2020-10-12T20:12:27.543Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-10-12T20:12:27.547Z]  > git fetch --no-tags --progress --prune -- git@github.com:elastic/apm-agent-python.git +refs/pull/945/head:refs/remotes/origin/PR-945 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2020-10-12T20:12:28.186Z] Merging remotes/origin/master commit 79e722dc5240d10c2fadbfcf9e44327afdbb4245 into PR head commit 15eaca59e7b36306d5fdb4d9d185aadf77cc21da
[2020-10-12T20:12:28.284Z] Merge succeeded, producing 15eaca59e7b36306d5fdb4d9d185aadf77cc21da
[2020-10-12T20:12:28.284Z] Checking out Revision 15eaca59e7b36306d5fdb4d9d185aadf77cc21da (PR-945)
[2020-10-12T20:12:28.333Z] Commit message: "Fix some small grammatical errors in the contributing doc"
[2020-10-12T20:12:28.333Z] Cleaning workspace
[2020-10-12T20:12:28.405Z]  > git --version # timeout=10
[2020-10-12T20:12:28.409Z]  > git --version # 'git version 2.17.1'
[2020-10-12T20:12:28.412Z] fatal: bad object bb43e5e89f62e8063fa4b74e1218b2f983fe870c
[2020-10-12T20:12:28.191Z]  > git config core.sparsecheckout # timeout=10
[2020-10-12T20:12:28.195Z]  > git checkout -f 15eaca59e7b36306d5fdb4d9d185aadf77cc21da # timeout=15
[2020-10-12T20:12:28.254Z]  > git remote # timeout=10
[2020-10-12T20:12:28.262Z]  > git config --get remote.origin.url # timeout=10
[2020-10-12T20:12:28.266Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-10-12T20:12:28.271Z]  > git merge 79e722dc5240d10c2fadbfcf9e44327afdbb4245 # timeout=10
[2020-10-12T20:12:28.280Z]  > git rev-parse HEAD^{commit} # timeout=10
[2020-10-12T20:12:28.289Z]  > git config core.sparsecheckout # timeout=10
[2020-10-12T20:12:28.292Z]  > git checkout -f 15eaca59e7b36306d5fdb4d9d185aadf77cc21da # timeout=15
[2020-10-12T20:12:28.338Z]  > git rev-parse --verify HEAD # timeout=10
[2020-10-12T20:12:28.341Z] Resetting working tree
[2020-10-12T20:12:28.342Z]  > git reset --hard # timeout=10
[2020-10-12T20:12:28.372Z]  > git clean -fdx # timeout=10
[2020-10-12T20:12:29.326Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2020-10-12T20:12:30.016Z] + git fetch<EMAIL_ADDRESS>+refs/pull/*/head:refs/remotes/origin/pr/*
[2020-10-12T20:12:31.487Z] Archiving artifacts
[2020-10-12T20:12:32.220Z] + git rev-parse HEAD
[2020-10-12T20:12:32.616Z] + git rev-parse HEAD
[2020-10-12T20:12:32.947Z] + git rev-parse origin/pr/945
[2020-10-12T20:12:33.005Z] [INFO] githubEnv: Found Git Build Cause: pr
[2020-10-12T20:12:33.304Z] Masking supported pattern matches of $GITHUB_TOKEN
[2020-10-12T20:12:34.355Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/apm-agent-python/pulls/945/reviews return 0 elements
[2020-10-12T20:12:34.424Z] [INFO] githubPrCheckApproved: Title: Fix some small grammatical errors in the contributing doc - User: rallytime - Author Association: FIRST_TIME_CONTRIBUTOR
[2020-10-12T20:12:34.808Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2020-10-12T20:12:34.808Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2020-10-12T20:12:34.901Z] [INFO] Let's stop build #1. The PR is not allowed to run in the CI yet
[2020-10-12T20:12:34.928Z] Sleeping for 5 sec
[2020-10-12T20:12:36.120Z] Stage "Sanity checks" skipped due to earlier failure(s)
[2020-10-12T20:12:36.211Z] Stage "Test" skipped due to earlier failure(s)
[2020-10-12T20:12:36.305Z] Stage "Building packages" skipped due to earlier failure(s)
[2020-10-12T20:12:36.395Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-10-12T20:12:36.489Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2020-10-12T20:12:36.683Z] Stage "Prepare Release" skipped due to earlier failure(s)
[2020-10-12T20:12:36.722Z] Stage "Prepare Release" skipped due to earlier failure(s)
[2020-10-12T20:12:36.811Z] Stage "Prepare Release" skipped due to earlier failure(s)
[2020-10-12T20:12:36.899Z] Stage "Prepare Release" skipped due to earlier failure(s)
[2020-10-12T20:12:37.232Z] Running on Jenkins in /var/lib/jenkins/workspace/thon_apm-agent-python-mbp_PR-945
[2020-10-12T20:12:37.394Z] [INFO] getVaultSecret: Getting secrets
[2020-10-12T20:12:37.586Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-10-12T20:12:38.491Z] + chmod 755 generate-build-data.sh
[2020-10-12T20:12:38.491Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-945/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-945/runs/1 ABORTED 167968
[2020-10-12T20:12:39.041Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-945/runs/1/steps/?limit=10000 -o steps-info.json
[2020-10-12T20:12:39.592Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-python/apm-agent-python-mbp/PR-945/runs/1/tests/?status=FAILED -o tests-errors.json
[2020-10-12T20:12:39.593Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2020-10-12T20:12:40.504Z] Retry 2/3 exited 22, retrying in 2 seconds...


Automatic arrays in compiler check

Closes #254

@jenkins-cscs retry dom

Codecov Report

Merging #311 into master will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   91.18%   91.41%   +0.22%
==========================================
  Files          67       67
  Lines        7941     8071     +130
==========================================
+ Hits         7241     7378     +137
+ Misses        700      693       -7

Impacted Files
Coverage Δ

unittests/test_utility.py
99.16% <0%> (+0.42%)
:arrow_up:

reframe/core/config.py
84.54% <0%> (+1.81%)
:arrow_up:

reframe/utility/__init__.py
97.02% <0%> (+4.46%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd18a5e...f8d60e5. Read the comment docs.

@ajocksch The test fails due to KeyError in the arrays_reference. Have a look here:
https://jenkins.cscs.ch/blue/organizations/jenkins/ReframeCI/detail/ReframeCI/588/pipeline

The * in PrgEnv is the problem, since the keys are only for PrgEnv without *
One solution: Run the check for one PrgEnv only.
Another solution: Extend the dictionaries? or allow somehow the * for searches

You can also do the following:
if environ.name.startswith('PrgEnv-pgi'):
    key = 'PrgEnv-pgi'
else:
    key = environ.name

self.reference = self.arrays_reference[key]

PrgEnv-pgi_16 PrgEnv-pgi_17 PrgEnv-pgi_18 fail as expected
also PrgEnv-cray_aj* fails since the mvapich* libraries set only the -I and -L path for mpif90 and not for ftn; this needs to be discussed

@jenkins-cscs retry all

@ajocksch This is the output I am getting:
SUMMARY OF FAILURES
------------------------------------------------------------------------------
FAILURE INFO for AutomaticArraysCheck
  * System partition: kesch:cn
  * Environment: PrgEnv-pgi_16
  * Stage directory: /users/karakasv/Devel/reframe/stage/cn/AutomaticArraysCheck/PrgEnv-pgi_16
  * Job type: batch job (id=None)
  * Maintainers: ['AJ', 'VK']
  * Failing phase: compile
  * Reason: OS error: [Errno 2] No such file or directory: 'mpif90': 'mpif90'
------------------------------------------------------------------------------
FAILURE INFO for AutomaticArraysCheck
  * System partition: kesch:cn
  * Environment: PrgEnv-pgi_17
  * Stage directory: /users/karakasv/Devel/reframe/stage/cn/AutomaticArraysCheck/PrgEnv-pgi_17
  * Job type: batch job (id=None)
  * Maintainers: ['AJ', 'VK']
  * Failing phase: compile
  * Reason: caught framework exception: Command '['mpif90', '-O2', '-ta=tesla,cc35,cuda8.0', '-I/users/karakasv/Devel/reframe/stage/cn/AutomaticArraysCheck/PrgEnv-pgi_17', '/users/karakasv/Devel/reframe/stage/cn/AutomaticArraysCheck/PrgEnv-pgi_17/automatic_arrays.f90', '-o', '/users/karakasv/Devel/reframe/stage/cn/AutomaticArraysCheck/PrgEnv-pgi_17/./AutomaticArraysCheck']' failed with exit code 127:
=== STDOUT ===
=== STDERR ===
/appsmnt/escha/UES/RH7.3_experimental/pgi/18.4/linux86-64/2018/mpi/openmpi-2.1.2/bin/.bin/mpif90: error while loading shared libraries: libpgm.so: cannot open shared object file: No such file or directory

------------------------------------------------------------------------------
FAILURE INFO for AutomaticArraysCheck
  * System partition: kesch:cn
  * Environment: PrgEnv-pgi_18
  * Stage directory: /users/karakasv/Devel/reframe/stage/cn/AutomaticArraysCheck/PrgEnv-pgi_18
  * Job type: batch job (id=817530)
  * Maintainers: ['AJ', 'VK']
  * Failing phase: sanity
  * Reason: sanity error: pattern `Result: ' not found in `/users/karakasv/Devel/reframe/stage/cn/AutomaticArraysCheck/PrgEnv-pgi_18/AutomaticArraysCheck.out'
------------------------------------------------------------------------------
FAILURE INFO for AutomaticArraysCheck
  * System partition: kesch:cn
  * Environment: PrgEnv-pgi_18_aj
  * Stage directory: /users/karakasv/Devel/reframe/stage/cn/AutomaticArraysCheck/PrgEnv-pgi_18_aj
  * Job type: batch job (id=817528)
  * Maintainers: ['AJ', 'VK']
  * Failing phase: performance
  * Reason: sanity error: 0.0001628 is beyond reference value 0.00014 (l=-inf, u=0.00016099999999999998)
------------------------------------------------------------------------------
FAILURE INFO for AutomaticArraysCheck
  * System partition: kesch:cn
  * Environment: PrgEnv-cray_aj
  * Stage directory: /users/karakasv/Devel/reframe/stage/cn/AutomaticArraysCheck/PrgEnv-cray_aj
  * Job type: batch job (id=817483)
  * Maintainers: ['AJ', 'VK']
  * Failing phase: sanity
  * Reason: sanity error: pattern `Result: ' not found in `/users/karakasv/Devel/reframe/stage/cn/AutomaticArraysCheck/PrgEnv-cray_aj/AutomaticArraysCheck.out'
------------------------------------------------------------------------------
FAILURE INFO for AutomaticArraysCheck
  * System partition: kesch:cn
  * Environment: PrgEnv-cray_aj_b
  * Stage directory: /users/karakasv/Devel/reframe/stage/cn/AutomaticArraysCheck/PrgEnv-cray_aj_b
  * Job type: batch job (id=817438)
  * Maintainers: ['AJ', 'VK']
  * Failing phase: sanity
  * Reason: sanity error: pattern `Result: ' not found in `/users/karakasv/Devel/reframe/stage/cn/AutomaticArraysCheck/PrgEnv-cray_aj_b/AutomaticArraysCheck.out'
------------------------------------------------------------------------------

You should not also rely on the CI, because it only runs a test if you have changed the test's Python file. In this case, you don't, that's why it does not run it. You should try it manually.

it is necessary to set the variable MV2_USE_CUDA for the cray compiler and mvapich compiled for gcc, although no gpu-direct is used; otherwise the code hangs in the first OpenACC directives

@lxavier the performance of the check is not 100% reproducible; there might be a problem with the dynamic adaptation of the clock frequencies of the nodes

@jenkins-cscs retry daint kesch

@lxavier it is necessary to set the variable MV2_USE_CUDA for the cray compiler and ..
Interesting I think when we run cosmo on CPU we set MV2_USE_CUDA=0 , but we may use a different mvapich for cpu. Anyone, all this will have to be in the cosmo module files once Hannes is completed. Let it like this for now

@lxavier the performance of the check is not 100% reproducible
We try to make it long enough so that this should not be an issue. We can increase the threshold. We want to detect if the timing goes completly of.  In addition we wanted to have a graphic to http://jenkins-mch.cscs.ch/view/POMPA/job/cosmo5_performance_benchmark/ so that we can monitor time, so it is ok if it fluctuate a bit.


Unable to launch with default settings

Trying to launch the latest and several prior versions of the chart and getting the below:
2022-10-31T20:15:56.048 DEBUG --- [  MainThread] stevedore.extension        : found extension EntryPoint(name='transfer:pro', value='localstack_ext.providers:transfer', group='localstack.aws.provider') 2022-10-31T20:15:56.048 DEBUG --- [  MainThread] stevedore.extension        : found extension EntryPoint(name='xray:pro', value='localstack_ext.providers:xray', group='localstack.aws.provider') 2022-10-31T20:15:56.049 DEBUG --- [  MainThread] localstack.services.infra  : [shutdown] Cleaning up resources ... 2022-10-31T20:15:56.050 DEBUG --- [  MainThread] localstack.utils.threads   : [shutdown] Done cleaning up threads / processes / tasks 2022-10-31T20:15:56.050 DEBUG --- [  MainThread] localstack.utils.run       : Executing command: rm -rf "/var/lib/localstack/tmp" 2022-10-31T20:15:56.058 DEBUG --- [  MainThread] localstack.services.infra  : [shutdown] Force shutdown, not waiting for infrastructure to shut down Traceback (most recent call last):   File "/usr/local/lib/python3.10/runpy.py", line 196, in _run_module_as_main     return _run_code(code, main_globals, None,   File "/usr/local/lib/python3.10/runpy.py", line 86, in _run_code     exec(code, run_globals)   File "/opt/code/localstack/localstack/cli/main.py", line 10, in <module>     main()   File "/opt/code/localstack/localstack/cli/main.py", line 6, in main     cli()   File "/opt/code/localstack/localstack/cli/plugin.py", line 15, in __call__     self.group(*args, **kwargs)   File "/opt/code/localstack/.venv/lib/python3.10/site-packages/click/core.py", line 1130, in __call__     return self.main(*args, **kwargs)   File "/opt/code/localstack/.venv/lib/python3.10/site-packages/click/core.py", line 1055, in main     rv = self.invoke(ctx)   File "/opt/code/localstack/.venv/lib/python3.10/site-packages/click/core.py", line 1657, in invoke     return _process_result(sub_ctx.command.invoke(sub_ctx))   File "/opt/code/localstack/.venv/lib/python3.10/site-packages/click/core.py", line 1404, in invoke     return ctx.invoke(self.callback, **ctx.params)   File "/opt/code/localstack/.venv/lib/python3.10/site-packages/click/core.py", line 760, in invoke     return __callback(*args, **kwargs)   File "/opt/code/localstack/localstack/utils/analytics/cli.py", line 66, in publisher_wrapper     return fn(*args, **kwargs)   File "/opt/code/localstack/localstack/cli/localstack.py", line 148, in cmd_start     bootstrap.start_infra_locally()   File "/opt/code/localstack/localstack/utils/bootstrap.py", line 260, in start_infra_locally     return infra.start_infra()   File "/opt/code/localstack/localstack/services/infra.py", line 435, in start_infra     raise e   File "/opt/code/localstack/localstack/services/infra.py", line 421, in start_infra     thread = do_start_infra(asynchronous, apis, is_in_docker)   File "/opt/code/localstack/localstack/services/infra.py", line 520, in do_start_infra     thread = start_runtime_components()   File "/opt/code/localstack/localstack/utils/bootstrap.py", line 77, in wrapped     return f(*args, **kwargs)   File "/opt/code/localstack/localstack/services/infra.py", line 512, in start_runtime_components     raise TimeoutError( TimeoutError: gave up waiting for edge server on <IP_ADDRESS>:4566 2022-10-31 20:15:57,369 INFO exited: infra (exit status 1; not expected)
These are the only parameters that have been set based on other reported issues:
  set {     name  = "livenessProbe.periodSeconds"     value = "65"   }   set {     name  = "debug"     value = "true"   }

Is this issue solved? This is an intermittent error I get everytime a new release happens.

Hi @navneel99!
Could you please create a new issue report with a detailed description of your issue and how to reproduce it?
Thanks!

My issue ended up being something to do with the proxy internally...After I exported the ENV Vars to set the proxy it was able to start. I also needed to increase the liveness probe to 180 seconds to give the app enough time to launch successfully.

Hi @alexrashed, sorry for the very late response. My issue also got resolved once I exported the proxy environment variables.


Press Release Too Far Down

Press releases are too far down, it does highlight the featured picture but really shuns the written content. We should adjust this.

we'll try to split the difference between what we have now, and what I thought looked good and #50 which is what we have now.

Tweaked from 500px to 360px.

Looks better in the Newsroom, but still looks really far down in the editor.

hmmm, Okay, I tweaked it again. I'm using a percentage value instead of a Pixel count. But Now it looks right in both the editor and the  newsroom.
The variable can be found in /posts/post_Item.js "topPadding" if you want to tweak it more.  We use post_Item.html and its javascript file buddy everywhere there is a post.

The newsroom looks great! I guess I think the Dashboard looks too far down now. Haha.

A lot of it might depend on the featured image as well. On one of my machines the difference is hardly noticeable.
We could change it so that the padding is aware of what area its in to adjust it to be exactly the same. I'll see about messing around with it today.

Thank you @bflanagin


Difference only-depth and base-depth

Hello!
I'm testing out this tool because I want to switch out from using mpileup and mosdepth doesn't fit my use case.
When running both modes on the same data with the same settings I get different results. I'm not too sure of the difference between the modes but I was hoping of getting the same.
The commands run and the results are:
./perbase only-depth --bed-format -m -q 0 -z -r /Homo_sapiens_assembly19.fasta -t 6 -o test_perbase_onlydepth_matefixed.bed -F 3848 -b coverage.bed final.bam
7	117199644	117199645		151
7	117199645	117199646		144
7	117199646	117199647		143

and
./perbase only-depth -m -Q 1 -q 0 -z -r /Homo_sapiens_assembly19.fasta -t 6 -o test_perbase_basedepth.txt -F 3848 -b coverage.bed final.bam
REF	POS	REF_BASE	DEPTH	A	C	G	T	N	INS	DEL	REF_SKIP	FAIL	NEAR_MAX_DEPTH
7	117199644	T	133	0	0	0	6	0	0	127	0	0	false
7	117199645	C	129	0	0	0	0	0	0	129	0	0	false
7	117199646	T	129	0	0	0	0	0	0	129	0	0	false

Thanks in advance!

Hello!
Could you clarify which commands you used? I'm assuming based on ouput format that the first is is only-depth and the second is base-depth. Could you also share a subset of data to reproduce what you're seeing above?
I'm not surprised that they are producing different outputs. At first glance I want to say it's how mate-fixing is handled between the two, but it's been years since I looked at this code. If you can share data I'll do some more digging. You could also try running without mate fixing and/or without read filtering to see which of those two might be to blame.

Hello!
Apologies, I sort of copy-paste and fixed the commands but yes, the 2nd one is base-depth and the 1st one is only-depth.
Unfortunately I can't share any data due to it being private data. I'll try disabling the mate fix option and check how it behaves. The option for read filtering which one are you referring to?
Best regards,
Jonatan

No worries! Yes, the -m and -F options, try running with without / with differing combos of those which should hopefully narrow down the source of difference.


New Effects

Can we add a new file which shows a different style of art on the images like stippling effect etc? I would love to contribute towards it.

Nice work @Preetesh21 !
You can build upon this for:

[ ] Mosaic Art
[ ] Travelling Salesman Art

Reference: link

Nice work @Preetesh21 !
You can build upon this for:

[ ]  Mosaic Art
[ ]  Travelling Salesman Art

Reference: link

Sir I had tried performing the TSP Art for the given image but the results are not very good as I could see.I am attaching the images of the same  here
This does not use stippling algorithm:

This one does:

A particular reason which I could think of the result is the low contrast in the image we are using which makes the TSP algorithm lot more straight then we would expect and also on increasing the number of cities in the TSP algorithm beyond 10000 there is a risk of a system crash.

Sir, I had tried for the problems and did not get very encouraging results and also the problems took considerably long time(3-4 mins) for solving the backtracking TSP. The result for the same is as :
Without increasing the contrast of the image

Increasing the contrast:

I had taken 10000 cities for the kolkata.jpg image , on increasing the number of cities the system crashed.

Sir, I had tried for the problems and did not get very encouraging results and also the problems took considerably long time(3-4 mins) for solving the backtracking TSP. The result for the same is as :
Without increasing the contrast of the image

Increasing the contrast:

I had taken 10000 cities for the kolkata.jpg image , on increasing the number of cities the system crashed.

I see, have you tried experimentation with  an optimization library like numba
And are you facing difficulties with the mosaic effect too?

Yes, sir, I am struggling with both of them :(. The results are not encouraging at all. Sorry.

Yes, sir, I am struggling with both of them :(. The results are not encouraging at all. Sorry.

No worries. Take your time and try going through some more blogs. Have a look at the blogs on the mosaic effect in Towards Data Science

Sure sir.


Selection of Files/Folders via Hovering Mouse Over

What's the Problem?
I see that there is no way to select files/folders by hovering the mouse pointer over.
Also, there is no option to make Files the default file explorer but I found out that if I use the sideload version from the Files website, I have the option to make it default file explorer but not if I get it via the MS Store.
Solution/Idea
By hovering the mouse pointer on a file/folder it should be selected without having to click on it.
Alternatives
n/a
Priorities
No response
Files Version
Version: <IP_ADDRESS>
Windows Version
Windows 10 OS Version: 10.0.19044.1526
Comments
No response

Merging with #3682


Path Matcher - Custom filename/namespaces

This resolves #209. With the great suggestions of @Excalibaard. Thanks.
~The basic functionality is finished and I need to do more testing and polishing while filling the docs.~
~You can clone and build by yourself if you want to try it out first. Two examples are provided in examples/path-matcher~
Docs: https://github.com/antfu/i18n-ally/blob/feat/path-matcher/docs/path_matcher.md
Thanks :)

EDIT: I think it's ready, but somehow vscode market does not provide a feature to publish alpha/beta packages that can opt-in by users. So I attached a vsix file for you to install it manually testing out. Any feedback would be greatly appreciated.
i18n-ally-1.13.99.vsix.zip

This works great. Thank you very much. The only thing that I'm missing is the possibility to apply the path matcher on the create tanslation function.

The only thing that I'm missing is the possibility to apply the path matcher on the create tanslation function.

Sorry I don't get it. Can you provide some examples? Thanks

Released as v1.14.0 :)

Wow, looks very good! Going to try it out in my project right now!

The only thing that I'm missing is the possibility to apply the path matcher on the create tanslation function.

Sorry I don't get it. Can you provide some examples? Thanks

I think he means a way to automatically have undefined keys be added under the correct namespaced directory path when using the 'create translation' functionality.
For example:

Path matcher matches the general.foo namespace for files of the pattern `general/foo/{locale}.yml
A new, undefined translation $t(general.foo.bar) is added
When adding a new translation for general.foo.bar, because general.foo is a matched translation namespace, it will create a translation bar: in general/foo/{locale}.yml

OK. I'll look into it!


Prepare release of SDK 1.7.1

View templates were all successfully compiled locally with the SDK analyzer, with no relevant error reported.

OK, I removed the TODELETE lines myself and pushed to prepare/1.7.1

Thanks for doing the removal.
For 25, 26 and 27, a line removed was the only line under a heading with number 5, so I'm wondering if this is OK.
See for example: https://github.com/OP-TED/eForms-SDK/commit/018ee32f598207e5dcb792df52b7f4c3d6db204e#diff-9b37daff4472ccb6984d9a0a9d925e0c565dbc2169ff3ecdd1f109efddb866a8

This now looks OK for me, no errors on view templates from the analyzer.


pull request for e2e test at 12/08/2016 17:56:01

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Write tests for Beneficiary and Donations models

Write tests for Beneficiary and Donations models that ensure the presence of the models generated

Written tests for beneficiaries and donations


Next.js support

Hello,
I'm trying to use ibm-gantt-chart-react with next.js, but I'm getting an error "window is not defined". Is there anything I should set differently when using next.js? (maybe it's trying to render the chart on the server?)

I am not sure to understand what you are trying to do and how you are integrating the gantt component.
Can you elaborate on that ?

@DavsX This issue covers several options to avoiding having a component render on the server:
https://github.com/vercel/next.js/issues/2473
One of the options is to use dynamic import with SSR disabled:
https://nextjs.org/docs/advanced-features/dynamic-import#with-no-ssr
But something simple like checking if window exists and conditionally rendering will work as well.


Add Central European University as txt

The Central European University is based in Vienna.
I am a researcher at the Department of Network and Data Science.

@mcontisc Pull request merged. Thank you.


update valence-on-rails repository

The valence-on-rails repository will serve as a short-term documentation on how to use valence in practice as jupyter notebooks.
This task is specifically about preparing this repository for v0.0.1 release.

valence.build
valence.analyze
repository readme

Longer term we will create one documentation site with on-rails documentation and low-level api documentation .. but thats another issue.

Update completed


[enhancement]: speed up (forced) snapshot refresh

Describe the solution you'd like
I think the forcerefreshsnap option was introduced to control regular updates of the snapshot view.
However there is a little drawback I've encountered:
When the camera detects an event (motion, person, doorbell, ...) the eufy client automatically pushes the new pictureUrl. This then is not used when the forcerefreshsnap option is enabled.
A consequence of this is that the image for the push notification from HomeKit is delayed by the time it needs to start the livestream and render the snapshot for the notification.
I think a better way would be to keep track of how old the pushed picture url is and use this instead for the notifications as long as it is recent enough. I would suggest 5 seconds.
Will try to realize this in a few days.

@thieren I think your reasoning is correct. However I'm interested in knowing what snapshot you are seeing when just receiving it from the doorbell pressed push. On my end it is always the previous event - not the current one.

@schliemann I think that depends on the configuration you're using. In my case I use forcerefreshsnap and so the occuring SnapshotRequest loads the livestream and gets one frame from the camera.
But I have an assumption as to why you're seeing the last event instead:
I noticed that when the doorbell is triggered a new pictureURLis generated from eufy cloud. However this URL is not valid until eufy itself started the camera and takes a snapshot. So in the handleSnapshot method the ffmpeg process can't utilize this url because there has not elapsed enough time yet for the eufy cloud to keep up.
But I'm a bit confused as to why the old snapshot is used. The way I understand it, there would be no snapshot (due to no valid pictureURL). Maybe there is some caching from HomeKit itself.
Do you have forcerefreshsnap disabled and also don't trigger motion events? This would at least explain why you always seem to see only old snapshots from doorbell events.
I'm currently working on a SnapshotManager that tries to circumvent some of these problems. Mainly it shall give back a snapshot as fast as possible.
As stated above the behavior that a snapshot takes a few seconds to process has major disadvantages in my view.
For example if I open HomeKit and almost immediately open the camera stream it will only start after the snapshot request is fulfilled that was started beforehand. This can in total take up to 10 seconds in my case. In my opinion this is too much for a good user experience.

@thieren Makes sense. I have disabled motion detection on my doorbell to preserve battery.
How does your night vision snapshots look? In the old repo I got snapshots with night vision working by adding "-ss 00:00:00.500" to ffmpeg. Without it I get a completely black snapshot.

@schliemann It's the same with the night vision snapshots for me. I think that's a limitation from the hardware design side of the eufy devices. The camera probably detects whether to use night vision by analyzing the brightness of the video (just an assumption) And so the first frames always will be dark until the device turns on night vision.

No. The problem is that we pick the first frame for the snapshot. The first frame never utilizes night vision. That's why the seek fixes it.

Yeah that is what I meant or rather what would be the consequence of my assumption.
I'm totally with you. I too don't think that the first frame ever utilizes the night vision. As for why exactly this is, is not absolutely clear.
Anyway, since we have no other choice at the moment a workaround as described by you is the best alternative I think.

@thieren Ah. I probably misunderstood your previous post. Sorry.
Also regarding the current doorbell pressed functionality this is what I see if forcedrefresh is disabled.
On iphone:
Doorbell pressed event with old snapshot unrelated to the current doorbell event.
On AppleTv:
AppleTv shows a PIP Doorbell pressed event with old snapshot unrelated to the current doorbell event.
AppleTV shows a PIP live feed which is live

hey, 2 cents, I think Eufy App is cheating and keep is own snap cache and force to generate one when user is opening the app.

@lenoxys @bropat Something is definitely going on. But I presume the android app is able to show the correct snapshot on push? And the eufy security client is built on the android app. So it is a bit odd that the snapshot is not the current one.

Hi
Added this in 2.0.1-beta.6
@schliemann Could you check if your problem with the old snapshot on ring events is solved by this?
Also please let me know what you think of this change.
Basically there is a new section in the camera configuration wizard with three options for snapshot handling.
'Force new snapshots' works mostly like forcesnaprefresh and 'speed' acts like the normal behavior with a few improvements to both.
The 'balanced' option tries to combine the two to get fewer outdated snapshots but also don't generate too much delay in the snapshot generating process.
Additionally there are a few extra options:

generate a snapshot automatically every x minutes
delay a camera snapshot by 0.5 seconds (as mentioned by @schliemann to improve night vision snaps)
setting to speed up notifications on doorbell ring events

@thieren Looks very interesting. Looking forward to test this. Not home until tuesday however.

Currently using Balanced mode without any specific periodic refresh.  Will continue to test but it seems to be working well.

Update: set a 5 minute refresh but this morning logs are saying "livestream didn't start in time" so it seems the snapshot hasn't updated since midnight.  It usually takes 7-8 seconds for a snapshot to create - any way we can configure the timeout duration?

Update: set a 5 minute refresh but this morning logs are saying "livestream didn't start in time" so it seems the snapshot hasn't updated since midnight. It usually takes 7-8 seconds for a snapshot to create - any way we can configure the timeout duration?

Hey @fullphat
can you provide a longer log output with detailed logging enabled?
Also I'd need your json config.
The current timeout is 15 seconds. So in theory should be way enough.

Hi @all
Just released a revised beta with a few small fixes/improvements to the snapshot handling.
@fullphat I believe this should fix the problem with the automatic refresh. Let me know if it's doing it's job now.

Will take a look!  I noticed earlier that the plugin had stopped and wouldn't restart.  In the end I had to kill the process with Activity Monitor and it came back ok.  I don't have the logs but if it happens again I'll try to save them off.

Just given it a try.  I got an error saying no snapshot in memory but it then still times-out when creating a snapshot.
I gave it 5 minutes but it didn't seem to create a snapshot and when I launched the Home app again, I got the same "No snapshot" error in the log but this time it didn't try to create one.

Hi @fullphat
can't quite follow you. For a few other people it's working at least. So I'll need a longer log output and also your json config.
But before that please try to empty your browser cache and save the settings via config wizard again. Unfortunately this seems to be the source of some strange bugs. (see #1 for reference)

@thieren Do I have to have forcesnaprefresh specified if I use the new snapshotHandlingMethod?

@thieren Do I have to have forcesnaprefresh specified if I use the new snapshotHandlingMethod?

Hey @schliemann no forcesnaprefresh will not be used with the new snapshot handling
ok not entirely true. If the new handling is enabled but no method defined aka. Balanced forced, speed the plug-in will determine the method based on forcesnaprefresh
But that's only because the new handling is enabled by default and I needed a way to determine which method works best for the individual user.
If you configure the thing via config ui the old option is ignored entirely.

Is implemented with release of 2.1.0


Any method which will discard the invalid data from data object against a schema (if/else/then conditions)

schema = {
  type: "object",
 properties: {
    firstName: {
       type: "string"
     }
  },
  if: {
    { properties: { firstName: { const: "abc" } } }
  },
  then: {
    { properties: { lastName: { type: "string" } } }
  }
}

data = {
  firstName: "def",  // other than "abc"
  lastName: "some value"
}

If you observe the data is not satisfying the if condition in schema but still data has lastName value
My requirement is to have a method which will take these two as parameter and return { firstName: "def" } .  (Discarding the lastName field becasue the conditions is not matched)

+1

This logic is easier to express in the application code, rather than achieve via the schema and general purpose library - it's quite specialised...
Please look at discriminator keyword and removeAdditional option - maybe combining them in some way would help you achieve what you need.


Embedding with AzureOpenAI

I am trying to get the pdf-chat-terminal example working with Azure.
I have created two api configurations for this. One for embedding and the other for chatting. It looks like this:
const embeddApi = new AzureOpenAIApiConfiguration({
  // apiKey: automatically uses process.env.AZURE_OPENAI_API_KEY,
  resourceName: "my-resource-name",
  deploymentId: "my-embedd-id",
  apiVersion: "my-api-version",
})

Unfortunately I get the following error Too many inputs. The max number of inputs is 16....
Is there a possibility to set this parameter?
Thanks in advance

Yes, I will.

PR included in v0.89.0. Thanks!


npm run build fails to minify

I am unable to build this package with my React environment, let me know if you can check this out! Thanks.
More info on it:
https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-run-build-fails-to-minify

Sorry – I don't want to publish an ES5 version. I suggest changing your tooling so that it can handle ES6 code. It's probably uglify-js or something that can only hanle ES5 crashing on this code. I recommend babel-minify instead, which can handle ES6.


Some Toolbar icons are not centered

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.72.0
OS Version: 12.5.1

These two icons are not centered in the toolbar. This occurs everywhere:

I am happy to work on this issue if needed

Transferring to the Codicons repo.


Throwable exception uncaught in Route.php unlike in App.php

Hi,
I found a bug while dealing with phpErrorHandler. I noticed that Throwable exceptions are not caught in Route.php on line 324 whereas this case is handle in App.php
    try {
        ob_start();
        $newResponse = $handler($this->callable, $request, $response, $this->arguments);
        $output = ob_get_clean();
    } catch (Exception $e) {
        ob_end_clean();
        throw $e;
    }

For Throwable exceptions, ob_end_clean() is never called.
It should be replace by:
    try {
        ob_start();
        $newResponse = $handler($this->callable, $request, $response, $this->arguments);
        $output = ob_get_clean();
    } catch (Exception $e) {
        ob_end_clean();
        throw $e;
    } catch (Throwable $e) {
        ob_end_clean();
        throw $e;
    }

Thanks

Following the documentation http://php.net/manual/en/language.errors.php7.php#119652, we should "add a catch block for Exception AFTER catching Throwable first".
Just switch catch blocks:
try {
ob_start();
$newResponse = $handler($this->callable, $request, $response, $this->arguments);
$output = ob_get_clean();
} catch (Throwable $e) {
ob_end_clean();
throw $e;
} catch (Exception $e) {
ob_end_clean();
throw $e;
}

I put Throwable first.
Thanks

Thank you !


New version: schollz.croc version 9.6.7

Pull request has been created with komac v2.1.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Hi @BiosPlus,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 870.)

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-03-12 08:15:54.931 [FAIL] Installer failed security check. Url: https://github.com/schollz/croc/releases/download/v9.6.7/croc_v9.6.7_Windows-64bit.zip Result: 0x80004005
2024-03-12 08:15:28.172 [FAIL] Installer failed security check. Url: https://github.com/schollz/croc/releases/download/v9.6.7/croc_v9.6.7_Windows-32bit.zip Result: 0x80004005

(Automated response - build 870.)


back order for goods receipt "Cost Amount" not working (stock card unit price not correct)

Done


Allow an easy way to disable legacy CRDs in Helm chart

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you expect to see?
The docs says that legacy API group (traefik.containo.us) is deprecated and will be removed in v3.
Would it be possible, until v3 is live, to have a true/false switch in the official Helm chart Values to be able to skip applying the legacy CRDs?
I have two motivations for such request:

should any of my old helm charts still accidentally use legacy API group, it should fail to deploy so that I immediately know that it should be upgraded
I'll get rid of duplicated resource aliases with the same name

I understand and share those motivations.
Following official Helm documentation on CRDs, I don't see a way to do it.

Actually you can just remove any CRDs you do not use from your cluster: Helm does not update CRDs once installed, like other manifests, but rather installs them only on the first helm install invocations. See also https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-1-let-helm-do-it-for-you.
As for this chart: it might as well be feasible to delete all old CRDs from the chart, since existing installations won't be affected by any change to the crds folder (since they will only be installed once and then ignored on upgrades) and new installations won't need the legacy CRDs.


Parse array with uniqueItems: true as a Set

What are the steps to reproduce this issue?

Add uniqueItems: true to a field in the OpenAPI doc
Run Orval

What happens?
The field comes back as an array.
What were you expecting to happen?
n/a
Any logs, error output, etc?
n/a
Any other comments?
As in the example of parsing dates as Date instances, it would be helpful to be able to parse an array of items that are known to be unique as a Set and have the generated type match that.
What versions are you using?
6.10.2

Hello @dawsonbooth, can you give me a quick example of what you expect?

I have a few endpoints that return a list of available actions to the user as an array. I know these actions to be unique within the array and have noted the return type as such in the swagger.json by setting uniqueItems: true, so I would like to use that information to parse the array as a Set upon receiving the data.
I know that I can just convert the array ad hoc for each specific query that I want, but it would be nice to be able to do this automatically for any items marked with uniqueItems: true and have the generated types from running orval use Set as well.
I figure this could be done either automatically by way of a flag in the orval config file, or it can be handled in the response parsing side similar to the Date parsing example in the docs.

On second thought, I'm realizing that this would be much better suited as a discussion item instead of an issue!
https://github.com/anymaniax/orval/discussions/674


Assess Cypress tests for flaky behavior; re-enable on builds

Run all tests numerous times via GUI, CLI, and CI.  Verify tests can execute consistently.
The following are known issues and must also be resolved, have tests disabled, or a workaround added before re-enabling on builds:

#680 - FIXED (maybe - see #735 )
#678 - FIXED

Issues not limited to the two linked above.

Using test:cypress-loop from #677 is a good starting point for setting up a test of the tests.

The two initial issues have been resolved.  Will monitor to see if more come up.  Still need to run all tests numerous times.

cy.wait(6000); in commands.js seems excessive.  See if this can be reduced.

OBE, closed.


Deployement not working

Accessing site doesn't work, issue is in default specified port.

Solved itself


Support 4rd bracket style: \n after and before open bracket

example:
.some
{
font-size: 14px;
}

Please check the issues before opening another, thanks. 😄
https://github.com/ben-eb/perfectionist/issues/21


Add tray icon

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable

Description
Added an optional tray icon. The tray icon can be used when the main window is minimized, closed or both. Clicking the tray icon will toggle the visibility of all windows. Right clicking it will open a context menu to show or close the application so users have an option to exit if they set Chatterino to hide when closing the main window.

I only tested this on linux with KDE, so it would have to be tested on other platforms as well, but I assume Qt takes care of the tray icon fairly well. I hope I put everything in the right place, I didn't really know where to put the enum for the tray icon setting, so if there's some issues I'd be happy to correct them.
Closes #1358

(Merging this closes #1358.)

While minimized to tray, closing any other visible window such as usercard or settings dialog results in application quitting - this should not be a case.

This doesn't happen for me, so maybe it's only an issue on windows? I'll try and test it on Windows later on.

Right now, minimizing the application to system tray via tray icon, hides only main window and all other windows like settings dialog, usercards, emote picker, etc. stay open.

This one is a bit more complicated. I switched to a signal for hiding/showing windows which seems to have fixed the issue mostly from what I can tell. The only issue left is that the settings dialog is always set to visible when clicking the tray icon, but that should be fixable.

This doesn't happen for me, so maybe it's only an issue on windows? I'll try and test it on Windows later on.

I am an arch user, btw. Maybe it's because of i3wm.

How does this handle multiple Chatterino windows? This is mostly a thing for Windows users who use the extension, or StreamLink (or other external viewer programs) users who might start Chatterino with the -c flag?
Getting the behaviour right for most users will be a difficult task.
I believe the setting(s) should be more akin to: Behaviour when pressing the Close button and Behaviour when pressing the Minimize button rather than a single setting trying to control both behaviours.
In addition, the default value for Close should be "ask users for future preference" (not sure how that would be shown in the settings page), and the default value for Minimize should be the old behaviour (so just minimize to the task bar, not to the tray)

How does this handle multiple Chatterino windows? This is mostly a thing for Windows users who use the extension, or StreamLink (or other external viewer programs) users who might start Chatterino with the -c flag?

It only reacts to the main window closing or being minimized. I wanted it so I could keep the program open and still get live notifications. I guess it should automatically start minimized if the -c flag is used? It should maybe also save the state and load it on launch.

I believe the setting(s) should be more akin to: Behaviour when pressing the Close button and Behaviour when pressing the Minimize button rather than a single setting trying to control both behaviours.

Seems fair.

In addition, the default value for Close should be "ask users for future preference"

I honestly dislike programs that do that. I'd leave it at the expected behavior and just let users set it in the settings.

In addition, the default value for Close should be "ask users for future preference"

I honestly dislike programs that do that. I'd leave it at the expected behavior and just let users set it in the settings.

Yeah if there is a valid default that works for most people I agree, but this is a pretty polarizing "feature", and the "ask users what their future preference is" has become pretty standard for some applications at least (I think Discord/Spotify at least)

How does this handle multiple Chatterino windows? This is mostly a thing for Windows users who use the extension, or StreamLink (or other external viewer programs) users who might start Chatterino with the -c flag?

It only reacts to the main window closing or being minimized. I wanted it so I could keep the program open and still get live notifications. I guess it should automatically start minimized if the -c flag is used? It should maybe also save the state and load it on launch.

That's my bad - I thought the tray icon was always visible a la Discord, but if the tray icon only shows up when you minimize or close the application (depending on the user settings) that makes more sense to me.
One thing to take into consideration with multiple windows, still, is that if Chatterino is started with the -c flag, settings aren't saved so asking the question for future actions wouldn't make sense

How does this handle multiple Chatterino windows? This is mostly a thing for Windows users who use the extension, or StreamLink (or other external viewer programs) users who might start Chatterino with the -c flag?

It only reacts to the main window closing or being minimized. I wanted it so I could keep the program open and still get live notifications. I guess it should automatically start minimized if the -c flag is used? It should maybe also save the state and load it on launch.

That's my bad - I thought the tray icon was always visible a la Discord, but if the tray icon only shows up when you minimize or close the application (depending on the user settings) that makes more sense to me.
One thing to take into consideration with multiple windows, still, is that if Chatterino is started with the -c flag, settings aren't saved so asking the question for future actions wouldn't make sense

Currently it is always visible, but I guess it'd make more sense to only show it when Chatterino is hidden.

How does this handle multiple Chatterino windows? This is mostly a thing for Windows users who use the extension, or StreamLink (or other external viewer programs) users who might start Chatterino with the -c flag?

It only reacts to the main window closing or being minimized. I wanted it so I could keep the program open and still get live notifications. I guess it should automatically start minimized if the -c flag is used? It should maybe also save the state and load it on launch.

That's my bad - I thought the tray icon was always visible a la Discord, but if the tray icon only shows up when you minimize or close the application (depending on the user settings) that makes more sense to me.
One thing to take into consideration with multiple windows, still, is that if Chatterino is started with the -c flag, settings aren't saved so asking the question for future actions wouldn't make sense

Currently it is always visible, but I guess it'd make more sense to only show it when Chatterino is hidden.

sorry for the double misunderstanding! :D
I think, for a single Chatterino window, it makes sense to keep the tray icon visible at all times, especially if we want to expand on the tray icon usage to show things like unread messages, have a place to spawn notifications from etc.
I think the question still is how tray icons behave with Chatterino windows other than the main window.
Maybe if Chatterino is started with -c no tray icon should be visible and close button/minimuze button has the same behaviour as now when no tray icon exists.
Same thing if Chatterino is running in "extension mode", we should also make sure no tray icon is visible

I think, for a single Chatterino window, it makes sense to keep the tray icon visible at all times, especially if we want to expand on the tray icon usage to show things like unread messages, have a place to spawn notifications from etc.
I think the question still is how tray icons behave with Chatterino windows other than the main window.
Maybe if Chatterino is started with -c no tray icon should be visible and close button/minimuze button has the same behaviour as now when no tray icon exists.
Same thing if Chatterino is running in "extension mode", we should also make sure no tray icon is visible

Is the gui even started if it's running in extension mode? From what I can see here it doesn't look like it so the icon shouldn't show up. Where is the -c flag checked? And what does it do? Also what do you mean by a single Chatterino window? No popup and user chats?

I know this isn't quite done, so I just wanted to quickly ask what I should do so this could be merged (if it's even good enough to be merged).

These are the changes that are required for further review:
In the settings dialog, instead of having them be checkboxes, it should instead be a dropdown menu of actions.
The actions possible for the "What should we do when you press the Close button" are:

"Ask me" <-- DEFAULT OPTION
"Minimize to tray icon"
"Close Chatterino (Standard behaviour)"

The actions possible for the "What should we do when you press the Minimize button" are:

"Ask me" <-- DEFAULT OPTION
"Minimize to tray icon"
"Minimize to task bar (Standard behaviour)"

The "Ask me" option should open a dialog asking the user what they would like to do, and saving that option to the setting.
After that there's some thinking/testing to be done with regards to multiple Chatterino windows and how that behaviour works, in particular we will need to handle "Ask me" differently if Chatterino is running in a mode where it does not save settings.

Alrighty, I'll try to find some time next week. Does "Ask me" need to be an option in the settings dialog? Wouldn't it be enough to show this dialog the first time when the user minimizes/closes, apply the users choice to the settings dialog and leave it at that?

It doesn't necessarily need to be an option in the list, but I thought it might be the simple way to do it code-wise. Maybe it just shouldn't render in the list. So for action, since you'd never want to set it to "ask me", just default to minimize to task bar and let the use change it in the settings if they'd like. For close we ask still

hey was there any update on this? curious since i was searching around for exactly this.

No, I sadly haven't had time nor motivation to work on this as of late.

How about now, any updates? Using the setting that shows full window name in the taskbar for applications makes Chatterino take up a lot of space (especially when I'm just using it in the Twitch browser using the Chrome extension thing).

How about now, any updates?

You can track the progress of this PR by following the commit history on this branch.

Well, better late than never:

Works on my machine™

@univrsal it should just say Minimize to tray instead of Minimize to tray icon

@univrsal it should just say Minimize to tray instead of Minimize to tray icon

I just copy pasted that from pajlada's message.

@univrsal it should just say Minimize to tray instead of Minimize to tray icon

I just copy pasted that from pajlada's message.

Initial thoughts (tested with both QtCreator build & nightly artifact):

It seems the minimize setting does not properly hold the window to request what behavior you want, it always minimizes itself and then the prompt will appear next time you go to maximize it again, and because of this will re-minimize itself on confirmation.

(It should be noted that, while clicking the C on your taskbar to minimize, the same issue arises, but the prompt does not follow and is still accessible.)

Clicking X on the popup forces the window into tray for both settings, and sets their respective BoolSetting to match.
It should either abort and keep the settings set to Ask me, or use original defaults (minimize & close) and keep the setting on Ask me.

Closing Chatterino from the taskbar right-click -> Exit will force it back to the taskbar on next startup.

Unrelated to code but reminder, Changelog will have to be dragged out of the depths of hell, and stripped of it's issue #. (we only do PR #'s now).

Initial thoughts (tested with both QtCreator build & nightly artifact):
1. It seems the minimize setting does not properly hold the window to request what behavior you want, it always minimizes itself and then the prompt will appear next time you go to maximize it again, and because of this will re-minimize itself on confirmation.
   ![c2_2501_1](https://user-images.githubusercontent.com/41973452/167548498-4b32ed67-da13-438a-bd29-8eac9399f01d.gif)

(It should be noted that, while clicking the C on your taskbar to minimize, the same issue arises, but the prompt does not follow and is still accessible.)
2. Clicking `X` on the popup forces the window into tray for both settings, and sets their respective `BoolSetting` to match.
   It should either abort and keep the settings set to `Ask me`, or use original defaults (minimize & close) and keep the setting on `Ask me`.
   ![c2_2501_2](https://user-images.githubusercontent.com/41973452/167549281-5f428f49-f693-4a5c-b301-8521aedc2a0d.gif)

3. Closing Chatterino from the taskbar `right-click -> Exit` will force it back to the taskbar on next startup.
   ![c2_2501_3](https://user-images.githubusercontent.com/41973452/167547549-54d9844c-a6c4-4c91-8839-292f1805b268.gif)

4. Unrelated to code but reminder, Changelog will have to be dragged out of the depths of hell, and stripped of it's issue #. (we only do PR #'s now).

Looks like 1. and 2. are issues on Windows. I'll try and debug it. 3. is probably a leftover from when the first attempt, the idea was that it should remember whether the program was hidden or not, but I guess that's not really necessary/useful.

So windows needed some extra code, because of the custom toolbar, but it seems to work now, I'll have to test it on linux again though
https://user-images.githubusercontent.com/8353672/167714926-a31782f3-4bcd-494b-9d41-b13a04933876.mp4

when user minimize chatterino window by clicking on task bar, OS will minimize it by itself while chatterino (with AskMe mode) will still show its MsgBox. Suggested behavior in this case would be not showing msgbox and not changing AskMe settings.

That's how I've now implemented it on windows. I don't think there's an easy way to distinguish these events on linux though. So on linux clicking the taskbar icon just shows the message box.

hey just saw this after commenting in this thread almost a year ago and glad you got to it! was wondering if its currently available for users on most recent update as i dont see the option

Alright, here comes the macOS review to make everything more complicated
This PR in it's current form is problematic on macOS, as the concept of the menu bar (which is where the QSystemTrayIcon is put) differs quite a bit from the system tray on i.e. windows.
How this would be expected to work for a macOS application:

A single setting "keep in menu bar", that adds a persistent chatterino icon (preferably monochrome) to the menu bar while chatterino is running
If that setting is enabled, don't close the main chatterino window on clicking the close button and just hide it (like this PR is doing rn)
On pressing the close button for the first time, display a dialog asking if you want to keep chatterino in the menu bar
On clicking the menu bar icon, always focus the chatterino window
Don't change anything about the minimizing behavior, macOS has a separate space for minimized applications in the dock and there is nothing that chatterino should change about that (ofc still un-minimize when clicking the menu bar icon)

Since those changes are fundamentally different from the implementation on windows/linux, I would guess that they'll probably require a lot of separate code for each platform (I haven't looked at the code in-depth so maybe it's less than I expect?) but I am unsure whether it makes sense for you to include that in this PR, without having a macOS system to test on. I could theoretically PR into your fork's branch or just open a separate PR after these changes get merged in, for a macOS implementation, but the current code will definitely have to be hidden, at least in part, behind ifdef's for macOS.

Since those changes are fundamentally different from the implementation on windows/linux, I would guess that they'll probably require a lot of separate code for each platform (I haven't looked at the code in-depth so maybe it's less than I expect?) but I am unsure whether it makes sense for you to include that in this PR, without having a macOS system to test on. I could theoretically PR into your fork's branch or just open a separate PR after these changes get merged in, for a macOS implementation, but the current code will definitely have to be hidden, at least in part, behind ifdef's for macOS.

Yeah I'd prefer it if I didn't have to deal with macOS, but I'd assume that the changes shouldn't be that complex.

Yeah I'd prefer it if I didn't have to deal with macOS

understandable 😄
Then I'd say it's probably easiest for you to just make this PR non-macOS only and for me to  open another one afterwards adapting it.

Is this supposed to be live on non-macOS platforms?

Is this supposed to be live on non-macOS platforms?

No, the green Open would be a purple Merged.

Is this feature available on Nightly? I can't seem to find minimize it to the tray.

Converting this PR to a draft, as I mentioned above unless the status below the PR title is a purple [Merged] - it has not yet made it to the nightly build(and subsequently stable releases).

I merged the current master branch on https://github.com/Nerixyz/chatterino2/tree/feat/tray-icon (https://github.com/Chatterino/chatterino2/compare/master...Nerixyz:chatterino2:feat/tray-icon) and cleaned it up a bit (and disabled the stuff on macOS).
In my opinion, there shouldn't be an "ask" option. This would simplify the implementation a bit. Thunderbird for example has a similar feature where you can minimize it to the tray, and it doesn't ask the user (at least last time I reinstalled it). Especially when implementing this as an MVP, the app shouldn't prompt users that updated.
One thing that feels a bit off on Windows in the current implementation is that windows hide as if they're closed. Thunderbird has a minimize animation in contrast, which gives a better indication of what actually happens. It would be fine to keep the current implementation in an MVP.
@univrsal please let us know if you want to continue this PR.

@univrsal please let us know if you want to continue this PR.

probably not, I just learned to live with the pain and minimize the program.


Fix heroku app

This PR solves issue #62
Issue:
Heroku App won't launch properly due to missing config.

Thanks!
looks great!


Animation links between stars should not fade

I feel that this would be a fun thing to fill out, and not fade away. This is IPFS, after all. :)

Disagree, it's fun that they disappear over time so you can start over or play with evolving patterns (game of life esque). probably could be modes. we could have an easter egg page that lets you play with it in various modes.

I like the stars either way, but they're eating good amounts of CPU

Closing as non actionable. Please continue to discuss though :)

@dignifiedquire This is pretty actionable, it just shouldn't be prioritized at all. The action is to change the JS.

@RichardLitt yes but I don't see a consensus on changing it

probably could be modes. we could have an easter egg page that lets you play with it in various modes.

That's as actionable as this will be; making a PR that allows you to switch on keypress should do it, fine. I think that this is a good idea, and would be fun.

Now we have a Disable Animation button for the CPU problem. I believe all here is solved


remove with_new_extra

Change Summary
Simplifies management of ValidationState a little. This is a related cleanup to the work ongoing in #1230.
Related issue number
N/A
Checklist

[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes where applicable
[ ] Pydantic tests pass with this pydantic-core (except for expected changes)
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Will proceed to just merge this as tidy up of internal refactorings.


bazel-deps does not generate workspace.bzl and BUILD

The project I maintain at work uses https://github.com/typedb/bazel-deps/releases/tag/0.3 for reasons lost to time. As that fork is long abandoned I would like to swap it out for the official, original bazel-deps as it seems to be well maintained.
First thing I wanted to to is the regenerate the workspace.bzl file because from what I see, typedb's fork makes very different target names for Bazel.
Problem is, when I try to generate the workspace.bzl file with this version, nothing ever happens. In fact if I try to regenerate to overwrite an existing file, it will vanish along with the BUILD file neighbouring it. But the other BUILD files, for all the dependencies individually, appear without issue.
Here is my directory layout:
/home/grepwood/git/nice-project
├── 3rdparty
|   ├── jvm-dependencies.yaml
|   └── jvm/
|       ├── BUILD (gets deleted by bazeltools/bazel-deps, generates)
|       ├── workspace.bzl (gets deleted by bazeltools/bazel-deps, never generates)
|       └── (a lot of directories) (generated by bazeltools/bazel-deps and typedb/bazel-deps)
├── WORKSPACE
└── (other things)

Here are my steps retraced in the source directory of my project:
# More or less, we use a private mirror
curl -LO https://github.com/bazeltools/bazel-deps/releases/download/v0.1-60/bazel-deps.jar
# Now the main course
java -cp bazel-deps.jar com.github.johnynek.bazel_deps.ParseProject generate -r /home/grepwood/git/nice-project -s 3rdparty/jvm/workspace.bzl -d 3rdparty/jvm-dependencies.yaml

It just keeps printing something like this:
[io-compute-blocker-2] ERROR MakeDeps - directory 3rdparty/jvm/... expected but missing
[io-compute-blocker-2] ERROR MakeDeps - file 3rdparty/jvm/.../BUILD does not exist.

After that it writes:
wrote 414 targets

But to where is anyone's guess. I tried to remove everything from 3rdparty/jvm except that directory:
rm -rf 3rdparty/jvm/*

and then I retried:
java -cp bazel-deps.jar com.github.johnynek.bazel_deps.ParseProject generate -r /home/grepwood/git/nice-project -s 3rdparty/jvm/workspace.bzl -d 3rdparty/jvm-dependencies.yaml

This made the errors go away. It still prints wrote 414 targets, it generates all the targets, but it doesn't generate the 3rdparty/jvm/BUILD and 3rdparty/jvm/workspace.bzl.
What am I doing wrong?

I haven't tried to repro, but it works for us following basically the setup described in the README.
Try putting the workspace.bzl file outside the jvm folder (which gets deleted every time). I'd guess (without looking at anything) that it generates workspace.bzl before deleting jvm, so you see it disappear.

Thank you @SeaJaredCode, I'll try that tomorrow when I'm at work


Ed25519 keys are not supported for GPG signatures

Hi,
Just wanted to share that Ed25519 keys are not supported for GPG signatures.
This is a limitation of golang.org/x/crypto/openpgp (used by go-git) which is deprecated anyway. I’ve opened an issue and made a PR on go-git to change the openpgp provider (see https://github.com/go-git/go-git/issues/282 and https://github.com/go-git/go-git/pull/283).
Meanwhile, I’m opening this issue in the hope it can help people who are debugging why source-controller prints messages like this one when the signature is completely valid:
{"level":"error","ts":"2021-04-02T21:27:22.111Z","logger":"controller.gitrepository","msg":"Reconciler error","reconciler group":"source.toolkit.fluxcd.io","reconciler kind":"GitRepository","name":"main","namespace":"flux","error":"PGP signature '[SNIPPED]' of '[SNIPPED]' can't be verified"}

Hopefully the PR on go-git can get merged soon and you’ll be able to update the dependency.

This should have been solved in the latest release via https://github.com/fluxcd/source-controller/pull/365


[Docs] Please show actual source code of demo instead of custom

Description
Hi 👋🏻
I was giving this module a try and found that actual source code is different from shown in the docs. For example in this form demo you have spaces between inputs but if we copy and paste the same code we don't get any spacing between inputs 🤷🏻♂ . Later I checked the source code and found that docs has additional class that provides spacing.
Another and clear example: In this demo we get surprised by how icon can be rendered without mentioning it 🤯

I suggest providing real source code in docs so we can copy and play with it. This will make UI lib more clear & less frustrating. Imaging copying the same code and still getting different results 😵💫
Additional context
Thanks for this module 🙏🏻

Hi @benjamincanac
After this issue was closed I tried and still, some things require updates like this zod example when copied to the page doesn't get the spacing between the form:

However, in docs due to the space space-y-4 class, it looks fine. Can you please reopen the issue?

@jd-solanki Done in https://github.com/nuxt/ui/commit/0eb8d8f7ec2939c630996346c6e6b6d497fc750b


Updating find_rocm_config.py to account for ROCm 5.2 related header file changes (HIP runtime)

This PR is really a continuation for PRs #1603, #1605, #1607, #1612, #1614 and #1617 (in the ROCm TF fork)
Newer ROCm 5.2 builds are running into build failures related to HIP runtime header file location/content updates.
This commit applies the same fix (updated location, newer locations searched first) to the HIP runtime files

jenkins : retest Ubuntu-GPU-multi please


Edit Vertices during draw

Let the user edit already drawn vertices of an unfinished polygon during draw.
Please upvote if you need this feature.

Closed until there is enough need to start developing this feature. Please upvote if you need it.


Token Error on resetting password

After using the forgot password screen and using the link provided in the email.  Fill in the form with your new password and get the ever fun token error.   I'm getting an error about wrong code, not wrong token...

Works fine in 1.1/2.0


Remove compose project stuff

It's clunky and doesn't work well with multi-architecture builds. Also, this type of thing ought to be handled with CI/CD instead of a GUI.
Allow a config option for the compose project directory to give read-only access to compose.yml, but no GUI controls.

Possibly useful sample information:
    "Labels": {
      "com.docker.compose.config-hash": "994cee78849078f7015bc83af99c806a6682640118136c4f203dad3c029d7cdb",
      "com.docker.compose.container-number": "1",
      "com.docker.compose.oneoff": "False",
      "com.docker.compose.project": "tea-runner",
      "com.docker.compose.project.config_files": "compose.yml",
      "com.docker.compose.project.working_dir": "/var/lib/docker/compose/tea-runner",
      "com.docker.compose.service": "tea-runner",
      "com.docker.compose.version": "1.29.2"

Server-side: https://github.com/DavesCodeMusings/container-central/commit/dae3a7db32bfdd08f8c5aa4800e0d39465ed839a.
Client-side: https://github.com/DavesCodeMusings/container-central/commit/fae4c854004790f6e0ac1c0ba1225efce8098b68.
Dockerfile: https://github.com/DavesCodeMusings/container-central/commit/b31f5433edd592acc3518ee66b177b86a2b4acf5.


incompatibility with elasticsearch-model after upgrading to hashie 3.4.x

I encountered a strange issue with my tests suites
I have a model such as this
class Place < Hashie::Mash
  include Elasticsearch::Model
  index_name    "place"
  document_type "place"

  def self.default_per_page
    25
  end
end

and I am hitting this error
undefined method 'id' for #<Elasticsearch::Model::Proxy::InstanceMethodsProxy:0x007fe62a1afaf0> (NoMethodError)
calling object.__elasticsearch__.index_document
strangly I could fix this issue by defining the id method like this
class Place
  def id
     super # goes to Hashie#method_missing and returns nil
  end
end

and found out the alternative is to lock down hashie to 3.3.x
would there be a better solution ?
defining the method is a bit weird, and locking down the gem is unfortunate

Do you know what's going on here? Is ElasticSearch::Model trapping the id call and not passing it down to Hashie::Mash? Or vice-versa?

In https://github.com/intridea/hashie/pull/392 we introduce a way to run integration tests, so you should be able to write something for this.

This is because of how elasticsearch-model delegates from its proxy to the underlying object.
They do a check with #respond_to? against the underlying object which, in this case, is a Hashie::Mash. If we look at the implementation of Mash#respond_to_missing?, we see that Mash will respond with false unless the method name is one of Mash's affixes or the key exists.
The best way to fix this would be to give your objects an id attribute before trying to persist them.
What's happening here is that Elasticsearch::Model expects the objects that it is mixed into to respond to #id and you are not giving the Mash an id. My understanding of Elasticsearch::Model is that it is intended to be mixed into an ORM class (like ActiveRecord::Base or something that has Mongoid::Document mixed into it), not an arbitrary object, like Mash.
I feel that the current implementation of Mash#respond_to_missing? is correct. While it would be technically correct for Mash to say it always responds to a missing method, I think that breaks the spirit of what Mash is all about. Mashes are Hashes first and foremost and I think that suggests that it should "only respond" to those keys that it has, plus its special methods.
As such, I'm going to close this issue. Hopefully, that explanation gets you where you need to go!

@dblock I wrote up an integration spec, but I don't think it's worth including since it essentially describes behavior in another gem. What do you think?

thank you very much for the great answer.
i think you are right, including ES::Model in a Mashie was wrong... something we should probably refactor.
I did not think to question this part at first, but it makes total sense

Specs are generally useful. This one would be a failing one, so I would just link it from here and call it a day.


How to use text content that is not in the "content" folder

This can be done today, but there is a ugly hack to handle the md rendering (see explanation below).
#400 might help (with 2 loaders, we could use one for the text only).
LOGS
Ben Briggs @ben-eb 16:37
I'm rewriting cssnano docs to be in a directory under the project root (/docs) and want to include CHANGELOG.md as a page
But I can't symlink it because it doesn't have the appropriate metadata
So I want to include the contents of it in a new page without duplicating the file
That new page then has the layout, title etc
Maxime Thirouin @MoOx 16:39
good question
I have the exact same problem for phenomic docs
I have an answer
but you might have to wait before being able to use it
Ben Briggs @ben-eb 16:40
Sure
Maxime Thirouin @MoOx 16:40
maybe partially
Make a React component that include the .md
with a webpack loader
this will be a hack for now
we must thing about that to offer a elegant way to handle this
then use a .md with the layout to point to this component
that will render the md
really tricky
but can work today
Opening an issue about that.
Ben Briggs @ben-eb 16:43
md is already handled by content-loader?
Maxime Thirouin @MoOx 16:43
you can adjusst the “include” option
to skip it
and use a md loader (or just raw-loader + “hardcoded” rendering in the component)
I said it will be hacky for now
not that hacky after all
we will explode content-loader
into 2 loaders
but we will keeep content-loader
as a convenience
so you will be able to use “text-loader"
later

I guess we can handle this by using the "context" option of phenomic loader. Maybe it's just some missing doc.

Will be handled with the collection refactoring.


apparmor blocks Tor Browser >= 10.5 starting with MOZ_ENABLE_WAYLAND set

Since Tor Browser 10.5 (release notes, tbb#31729) when the MOZ_ENABLE_WAYLAND environment variable is set, the Firefox build that is part of Tor Browser will try to use Wayland IPC and if that fails then Tor Browser will not start. The current torbrowser.Browser.firefox apparmor profile denies access to the relevant Wayland IPC files/sockets:
Jul 07 08:23:15 audit[437003]: AVC apparmor="DENIED" operation="mknod" profile="torbrowser_firefox" name="/dev/shm/wayland.mozilla.ipc.0" pid=437003 comm="Compositor" requested_mask="c" denied_mask="c" fsuid=1000 ouid=1000

I was able to workaround this issue using this command:
sudo sh -c 'echo "owner /dev/shm/wayland.mozilla.ipc.[0-9]* rw," > /etc/apparmor.d/local/torbrowser.Browser.firefox ; apparmor_parser -r /etc/apparmor.d/torbrowser.Browser.firefox'

Confirm this works as well. Do you mind sending a PR with the fix as well?

As I haven't contributed to this project yet I'd prefer someone else do it.
--
bye,
pabs
https://bonedaddy.net/pabs3/


Dronekit delivery example does not exit on Windows

When I want to exit the example I do Ctrl+C but nothing happens. To exit I need to shut down the command prompt.

Dear Sir,
I am able to Ctrl+C to exit. What I do to open the example is as follows
cd ~/ardupilot/ArduCopter
then sim_vehicle.sh
on another command prompt i do
cd ~/dronekit-python/examples/drone_delivery
sudo python drone_delivery.py
and the example works. Then when I do Ctrl+C the program exits, is it maybe that I don't have the updated version of the example?

@deksprime I have clarified - the error occurs on Windows only.


Spaces in filename breaks Etcher

Etcher version: 1.0.0-beta.13
Operating system and architecture: Arch Linux - Intel x86_64
Do you see any meaningful error information on DevTools?
Nothing useful was shown in the DevTools Menu.

To reproduce, I had this file that I was writing:
TrueOS-Desktop-11.0-CURRENTJULY2016-07-26-2016-x64-USB (1).img
When clicking "Flash" the state freezes at "Starting", and nothing happens. A temporary work around is to remove the space and the (1) from the filename, but it is still a bug that needs to be addressed.

Hi @larrydewey ,
Thanks a lot for reporting this. We've fixed a very similar issue in the past, so we might be facing a small regression. Let me investigate further and report back.

Hi @larrydewey ,
I'm unable to reproduce on an Ubuntu 16.04 machine, which makes me wonder if there is something system specific causing this for you.
Are you running Etcher directly as root? If not, when the elevation dialog appears (based on pkexec or kdesudo depending in your system), you can see the actual full command being ran in the "details" section of the dialog. Can you share that here, please?
Alternatively, could it be that your file name doesn't contain a space, but another "invisible" unicode character or something like that?

I am also getting the same issue. I have the same specs as @larrydewey

Tried this. beta14 still stalls, but the git head writes the same file correctly. I presume it was fixed in the changes since the report, and should be part of the next release.

Hm, that's weird. I'm beginning to think the issue may only be
reproducible when running inside an AppImage. Are you running with npm start?
You can generate an AppImage out of master by running the following
command in the root of the repository:
./scripts/build/linux.sh all x64

The generated AppImage will be placed in etcher-release/installers.
Can you check if you can reproduce this way?
On Thu, Sep 22, 2016 at 07:07:18PM -0700, Gergely Imreh wrote:

Tried this. beta14 still stalls, but the git head writes the same file correctly. I presume it was fixed in the changes since the report, and should be part of the next release.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/resin-io/etcher/issues/665#issuecomment-249083497

--
Juan Cruz Viotti
Software Engineer

@jviotti tried it out, indeed npm start burns okay, AppImage stalls on the same image file with spaces in the name.

Thanks a lot for the testing @imrehg, I'll try to reproduce here and fix soon!

After the comment above, I'm pretty sure this issue and this one refer to the same problem.


vtk: add HyperTreeGrid support

This adds basic support for VTK's new(ish) HyperTreeGrid. It seems there were older versions of this floating around, but it got revamped pretty heavily 2 years ago, so I'm only planning on supporting the latest version.
TODO: Very much work in progress and awaiting some usage in boxtree.

Just realized the branch wasn't on my fork. Closed in favor of #48.


issue #949, [ClockService] refactor the stalling task diagnosis

Current coverage is 62.85%

Merging #950 into master will change coverage by +0.35% by ed9f235

Coverage Diff
@@            master    #950   diff @@
======================================
  Files          208     208
  Stmts         4187    4172    -15
  Branches         0       0
  Methods          0       0
======================================
+ Hit           2617    2622     +5
  Partial          0       0
+ Missed        1570    1550    -20

Uncovered Suggestions

+0.74% via ...yarn/Constants.scala#22...52
+0.43% via ...ne/PipeLineDSL.scala#72...89
+0.33% via ...rt/QueryServer.scala#127...140
See 7 more...

Powered by Codecov


upgrade the cookie dependency

npm audit report
cookie  <0.7.0
cookie accepts cookie name, path, and domain with out of bounds characters - https://github.com/advisories/GHSA-pxg6-pf52-xh8x
No fix available
node_modules/cookie
iron-session  *
Depends on vulnerable versions of cookie
node_modules/iron-session

Can we get an updated ETA on when to expect the cookie dep to be updated? @vvo


Chrome WebView User-Agent

Describe the feature
It would be nice, I think, to add an option in the HeaderGeneratorOptions to generate WebView only user-agents (maybe only for mobile?)
examples:

Mozilla/5.0 (Linux; Android 7.0; SM-A310F Build/NRD90M; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/64.0.3282.137 Mobile Safari/537.36
Mozilla/5.0 (Linux; Android 13; 2201122G Build/TKQ1.220807.001; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/122.0.6261.64 Mobile Safari/537.36

Motivation
Some fingerprints detections use this to flag certain kind of devices

Hello - and thank you for your interest in this project!
We generate all our browser data (headers + Web API values) from data that we collect in regular web traffic. WebView-based requests are unfortunately very scarce in our datasets, so we cannot reliably generate this kind of requests.
Because of that, this is a wontfix from me right now - but we're definitely curious if you have any kind of dataset with these kinds of devices collected. Thank you! (and sorry for the wontfix).

Hello!
Can you share me the way you are collecting data please?
I don't have any dataset but I know from sources that some anti-bot services can block by this.