THCrap completely freezes up completely when finding games folder during patching

No, the newest version did not cause this, this has been an issue for every version.

https://github.com/thpatch/thcrap/assets/78673863/0ce22932-bed7-4aa2-8e79-23e60d70c976

In the thcrap folder, you should have a logs folder with a file called thcrap_log.txt. Can you reproduce this problem (including the part where Windows tells you "this program stopped responding" and you click "yes") and send thcrap_log.txt right after that?
I'm not sure from the video, the problem happens when you click on "Find games in a specific folder...", right? Does it happen when you click on either "Find games automatically" or "Find every game on your computer (slow)"?
In the thcrap folder, you have a bin folder, and inside that, a program called thcrap_configure.exe. Can you run that one (not the one with _v3 at the end) and see if you have the same issue? If it works, can you send a screenshot of the file picker?
I see that your explorer has some quite heavy extensions. Do you mind disabling them and checking if you still have the problem without them?


Monkeys don't emit update events?

 My dependencies look like this:
A(cursor)              B(cursor)    C(cursor)
          \            /            /
            D(monkey)              /
                      \          /
                        E(monkey)

When any of A, B, or C update, the appropriate monkeys are updated. However, the monkeys themselves do not appear to emit update events, which means that I don't get the updated monkey values unless I periodically re-check them.
I could watch the cursors for updates and re-evaluate the monkeys, but then I have to declare the monkeys' dependencies everywhere it's used. #358 says that monkeys aren't cursors -- am I experiencing the intended monkey behavior? What is the suggested way to get an update event from a monkey?

+1
Experiencing the same issue, any chance this will be fixed?

Here's a jsbin with this issue:
http://jsbin.com/ziyopuqohe/edit?html,js,console
@oortlieb is this somewhat your use case?

Monkeys are lazy by default so you need to add a watcher.get() or similar
to get the monkey to actually evaluate.
Den 30 maj 2016 15:25 skrev "Constantin Dumitrescu" <
<EMAIL_ADDRESS>
Here's a jsbin with this issue:
http://jsbin.com/ziyopuqohe/edit?html,js,console
@oortlieb https://github.com/oortlieb is this somewhat your use case?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Yomguithereal/baobab/issues/448#issuecomment-222492184,
or mute the thread
https://github.com/notifications/unsubscribe/ADYLwAGjdW98Yev2JHTSTDUkbacBT_j2ks5qGuUvgaJpZM4IVZsW
.

Indeed, the only way to know if a monkey's value has changed is to evaluate it (regardless if its dependencies have changed, the monkey's might not)
But, how about an EAGER UPDATER flag on the cursor/watcher so that you get updates for anything that occurs on the dependency chain?
watcher.on('eager-update', x => {
   console.log('getting every update here!!! and I can decide! if I do trigger')
   if (x.theChangedData !== "something I know will not need evaluation") {
      x.currentData()
   }
})

Otherwise, we would have to do it like this:
tree.on('update', x => {
// very complex logic in order to know if a monkey does indeed need to evaluate
})

The fact is that monkeys (dynamic nodes) are meant to be linked in hierarchies. In my view at least, you can encapsulate all of the application logic in dynamic nodes that define derived data based on the essential state your application runs on.

Sorry for disappearing!
Yes, @dumconstantin, that's similar to my use case. I'm piling dynamic nodes on dynamic nodes, and my current method of watching paths and manually replacing cursors is getting unwieldy.
@Zache I thought the laziness could be the issue, but setting the lazyMonkeys option to false in my baobab didn't fix the issue. It's possible I did something incorrectly -- should that have fixed my problem?

Hello! Is there any update on this? I tried fixing this issue myself last week, but ultimately failed, because I'm not very familiar with the inner workings of Baobab.
I have written the following test case which you can drop into the monkey suite:
describe('Issue #448 - Monkeys don\'t emit update events?', function () {
  it('update events emitted by a monkey should also reach the parents of the monkey.', function (done) {
    const tree = new Baobab({
      value: 5,
      monkeys: {
        valueSquared: monkey(['value'], value => value * value)
      }
    }, {
      lazyMonkeys: false
    });

    const newValue = 10;

    const parentCursor = tree.select('monkeys');
    parentCursor.on('update', () => {
      assert.strictEqual(tree.get(['monkeys', 'valueSquared']), newValue * newValue);
      done();
    });

    tree.set(['value'], newValue);
  });
});

+1 experiencing this issue myself as well and I am also personally unable to provide a solution.
Thanks in advance to anyone who can take a closer look.

@Yomguithereal -- I took a short dive into the code and noticed the following...
It appears that updated monkey path is not added to the tree._affectedPathsIndex and thereafter the tree.commit() emits an update message without the monkey path in paths and therefore the parent cursors doesn't solveUpdate and emit an update event.
It also appears that the difference is that in the monkey updates the tree using the update.js function directly as opposed to the tree.update() function (which cursor.set() uses) that appends to the tree._affectedPathsIndex
What would be the best course of action to ensure the monkey, when evaluated , adds its path to the tree._affectedPathsIndex?

I must admit my memory is a bit blurry on the subject. Let me check that at the beginning of next week. Don’t hesitate to ping me if I forget.

@Yomguithereal -- Thanks for avid engagement, truly appreciated it. I put in a Pull Request that fixes the issue. Let me know if it needs any refactoring.

Merged the PR and released 2.5.1 on npm. Thanks @roark.


new d3d12 wrapping related work and fixes

First pull request attempt, i am not really used to git and i don't know the way to keep the visual project updates local ( as i work in 2015 ) and not send them in the pull request.
Update to latest d3d12 interface ( for ID3D12Device1 and ID3D12Debug1 )
Fixes of missing and improper unwrap.
Handle wrapping of the remaining d3d12 interface creation calls.
Fix of d3d12 reusing root signature pointer at creation.
Fix read back resource creation at capture time
All the files were processed by clang-format before commits.

A couple of bookkeeping things - yes you'll need to remove the project and header changes from the pull request - there are a few ways to do this, one would be to work on a given scratch branch, and then when you're ready to make your PR create a new branch, and rebase it to remove those commits. This would also let you remove the clang-format commits which I'd like you to please squash into other commits as appropriate - it leads to an ugly history if they're left separate.
On that note - please don't add new commits to a PR after you've created it, it makes things harder to process. The original PR was an OK size but this is now a bit of a clump of loosely related changes, ideally you'd make a PR with a particular purpose since it's then easier to track in history as well as review.
In more general terms, the D3D12 back-end is still in its very early stages which is why I've not really announced its existance much. I'm grateful for help and I'm not going to reject any PRs over it, but I'd kind of suggest you stay away from making changes here as there's going to be an awful lot of churn that will make things difficult.
Because of the limitations of D3D12 needing Windows 10, I can't develop it on my primary machine, I have to use a secondary PC that runs windows 10. That sometimes means that I don't push my work up to github as regularly, so you might end up doing work that conflicts with stuff I have done - and I am likely to accept mine rather than yours in that case. Again I appreciate the contribution I just want to make sure there's not going to be conflicts and such wasting work.

Hi,
First, thanks for the time spent reviewing that PR. I will process everything in the comments, break up in smaller PR, clean up, then come back to bother you again. I definitely have perforce habits that does not mix well with a git flow i need to work on.
I will certainly continue to work on the d3d12 backend, because VSGD is crap, IHV tools inconsistent, and PIX Xbox One only. And Renderdoc was an important tool for us with DX11 and it will likely be for DX12 too, building a knowledge of his code is a safe guard to help internally fix future bug if needed.
I am fine with you not having the time to review all the crap i will commit, or picking your own code if it conflicts with something you have locally and not yet on github. I don't know how it will work with future pull request as i move forward tho.
Right now, i can run and capture my dx12 sandbox ( mostly every piece of api possible ), so it is definitely an improvement ( i need the reference all resource check box and loading the capture crash on a failing CreateShaderResourceView ).
Thanks.

No problem. I think there are some good git process guides out there. People have different thoughts and opinions on git, but I like the workflow and how flexible it can be. E.g. it's very easy to keep a branch somewhere, and make a new branch with only a few of the commits (look up git cherry-pick to bring across a single commit). I also make extensive use of git rebase -i in my work. E.g. when I was doing some of the D3D12 work I would make many commits, find a bug or mistake in one of them later, and then I would just make a new commit "fix to  earlier thing", and then git rebase -i allows me to both re-order them so the fix is immediately afterwards, and then also squash them together. This could be useful both for some of the bugfix commits you have as well as the clang-format commits.
I'm glad you have a high opinion of RenderDoc, hopefully the D3D12 support can live up to that :smile:. As I say you are of course free to continue working on it and I'll accept contributions, I just wanted to make sure your expectations are set, since with the code still largely unfinished and in flux there's a higher chance of me just going "this isn't correct I'm going to do it a different way", or running into conflicts that either mean your work won't be applied or at least will have to be resolved against my changes.
I'll definitely review anything you submit though and pull in what I can (right now I don't have any pending work so this can all go in). I'll also try and do better at committing the D3D12 work more regularly so you can see the latest. Another git thing - when you make a pull request, you'll need to make sure it is rebased against recent code, rather than merging.
Good news about the sandbox though! I've been using AMD's HelloD3D12 for testing as it's about as simple as it gets, I didn't realise the API coverage was remotely useful for something more complex, but missing capture data might not show up as a crash, so it won't be clear until you can replay :smile:.
I'm closing this PR since you'll split it up, but again - the code contributions are welcome.

Hi,
I compiled Renderdoc D3D12 from galop1n branch which should be equal to using this patches and using Microsoft  DirectX12 samples from(https://github.com/Microsoft/DirectX-Graphics-Samples).
I tested simple D3D12HelloTriangle from D3D12HelloWorld solution..
I compiled a x86 binary of Renderdoc and of the sample and I could record a frame but upon replaying crashes..
Replay Log:
RENDERDOC:  [09:05:17]             core.cpp( 270) - Log     - RenderDoc v0.31 x86 (NO_GIT_COMMIT_HASH_DEFINED) loaded in replay application
RENDERDOC:  [09:05:43]    win32_process.cpp( 410) - Log     - Injecting renderdoc into process 14912
RENDERDOC:  [09:05:43]    win32_process.cpp( 279) - Debug   - Injecting call to RENDERDOC_SetLogFile
RENDERDOC:  [09:05:43]    win32_process.cpp( 279) - Debug   - Injecting call to RENDERDOC_SetCaptureOptions
RENDERDOC:  [09:05:43]    win32_process.cpp( 279) - Debug   - Injecting call to RENDERDOC_GetRemoteAccessIdent
RENDERDOC:  [09:05:43]    win32_network.cpp( 339) - Debug   - connect before timeout
RENDERDOC:  [09:05:43]    remote_access.cpp( 398) - Log     - Got remote handshake: D3D12HelloTriangle () [14912]
RENDERDOC:  [09:05:44]    remote_access.cpp( 600) - Log     - Used API: D3D12
RENDERDOC:  [09:05:46]    remote_access.cpp( 587) - Log     - Got a new capture: 0 (time<PHONE_NUMBER>) 0 byte thumbnail
RENDERDOC:  [09:05:48]    win32_network.cpp( 178) - Warning - recv: 10054
RENDERDOC:  [09:05:48]       serialiser.cpp( 629) - Debug   - Opened capture file for read
RENDERDOC:  [09:05:48]  replay_renderer.cpp(1551) - Log     - Creating replay device for C:\Users\oscarb\AppData\Local\Temp\D3D12HelloTriangle_2016.08.28_09.05.43_frame98.rdc
RENDERDOC:  [09:05:48]       serialiser.cpp( 629) - Debug   - Opened capture file for read
RENDERDOC:  [09:05:48]     d3d12_replay.cpp( 522) - Debug   - Creating a D3D12 replay device
RENDERDOC:  [09:05:48]       serialiser.cpp( 629) - Debug   - Opened capture file for read
RENDERDOC:  [09:05:48]      d3d12_hooks.cpp( 173) - Debug   - Call to Create_Internal Feature Level b000
RENDERDOC:  [09:05:48]      d3d12_hooks.cpp( 179) - Debug   - In replay app
RENDERDOC:  [09:05:48]      d3d12_hooks.cpp( 214) - Debug   - Calling real createdevice...
RENDERDOC:  [09:05:49]      d3d12_hooks.cpp( 235) - Debug   - Called real createdevice... 0x00000000
RENDERDOC:  [09:05:49]      d3d12_hooks.cpp( 239) - Debug   - succeeded and hooking.
RENDERDOC:  [09:05:49]      d3d12_hooks.cpp( 250) - Debug   - created wrapped device.
RENDERDOC:  [09:05:49]       serialiser.cpp( 629) - Debug   - Opened capture file for read
RENDERDOC:  [09:05:49]     d3d12_replay.cpp( 581) - Log     - Created device.
RENDERDOC:  [09:05:49]  replay_renderer.cpp(1568) - Log     - Created replay driver.
RENDERDOC:  [09:05:49]     d3d12_common.cpp( 800) - Error   - Unrecognised RTV Dimension 0
RENDERDOC:  [09:05:49]     d3d12_common.cpp( 800) - Error   - Unrecognised RTV Dimension 0
RENDERDOC:  [09:05:49]     d3d12_common.cpp( 752) - Error   - Unrecognised SRV Dimension 0
RENDERDOC:  [09:05:49]    d3d12_manager.cpp( 647) - Error   - Couldn't create upload buffer: 0x8007000e
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 12 at offset 157067
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 225 at offset 157241
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 4592 at offset 157259
RENDERDOC:  [09:05:49]       serialiser.cpp(1587) - Error   - Unexpected control byte: f3
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 12676 at offset 157265
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 7710 at offset 158203
RENDERDOC:  [09:05:49]       serialiser.cpp(1587) - Error   - Unexpected control byte: 17
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 6977 at offset 158209
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 7926 at offset 158218
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 7213 at offset 158311
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 8866 at offset 158358
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 255 at offset 158914
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 2316 at offset 158920
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 206 at offset 158926
RENDERDOC:  [09:05:49]       serialiser.cpp(1587) - Error   - Unexpected control byte: 2
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 10477 at offset 158932
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 256 at offset 158940
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 89 at offset 158946
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 111 at offset 158952
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 11776 at offset 158958
RENDERDOC:  [09:05:49]       serialiser.cpp(1587) - Error   - Unexpected control byte: 40
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 8445 at offset 158962
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 16221 at offset 158977
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 1293 at offset 159518
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 512 at offset 161539
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 616 at offset 161665
RENDERDOC:  [09:05:49]       serialiser.cpp(1587) - Error   - Unexpected control byte: 7
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 545 at offset 161669
RENDERDOC:  [09:05:49]       serialiser.cpp(1587) - Error   - Unexpected control byte: 27
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 8039 at offset 162124
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 6144 at offset 162131
RENDERDOC:  [09:05:49]       serialiser.cpp(1587) - Error   - Unexpected control byte: 2e
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 10599 at offset 162193
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 10087 at offset 162202
RENDERDOC:  [09:05:49] d3d12_device_wrap.cpp( 422) - Error   - Failed on resource serialise-creation, HRESULT: 0x80070057
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 38 at offset 162252
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 12166 at offset 162258
RENDERDOC:  [09:05:49]       serialiser.cpp(1587) - Error   - Unexpected control byte: 40
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 10087 at offset 162262
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 50 at offset 162269
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 4612 at offset 162275
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 36 at offset 162279
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 10087 at offset 162285
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 39 at offset 162289
RENDERDOC:  [09:05:49]     d3d12_device.cpp(1459) - Error   - Unexpected non-device chunk 512 at offset 162295
RENDERDOC:  [09:05:49]       serialiser.cpp(1124) - Fatal   - Allocation for<PHONE_NUMBER> bytes failed
Capture Log:
RENDERDOC:  [09:05:43]             core.cpp( 273) - Log     - RenderDoc v0.31 x86 (NO_GIT_COMMIT_HASH_DEFINED) capturing application
RENDERDOC:  [09:05:43]   win32_libentry.cpp(  66) - Log     - Loading into C:\Users\oscarb\Downloads\DirectX-Graphics-Samples-1.0.160510.1\DirectX-Graphics-Samples-1.0.160510.1\Samples\Desktop\D3D12HelloWorld\src\HelloTriangle\bin\Win32\Release\D3D12HelloTriangle.exe
RENDERDOC:  [09:05:43]            hooks.cpp(  45) - Debug   - Attempting to hook kernel32.dll
RENDERDOC:  [09:05:43]            hooks.cpp(  49) - Log     - Loaded and hooked into kernel32.dll, PID 14912
RENDERDOC:  [09:05:43]            hooks.cpp(  45) - Debug   - Attempting to hook opengl32.dll
RENDERDOC:  [09:05:43]            hooks.cpp(  49) - Log     - Loaded and hooked into opengl32.dll, PID 14912
RENDERDOC:  [09:05:43]            hooks.cpp(  45) - Debug   - Attempting to hook d3d11.dll
RENDERDOC:  [09:05:43]            hooks.cpp(  49) - Log     - Loaded and hooked into d3d11.dll, PID 14912
RENDERDOC:  [09:05:43]            hooks.cpp(  45) - Debug   - Attempting to hook d3d9.dll
RENDERDOC:  [09:05:43]            hooks.cpp(  49) - Log     - Loaded and hooked into d3d9.dll, PID 14912
RENDERDOC:  [09:05:43]            hooks.cpp(  45) - Debug   - Attempting to hook dxgi.dll
RENDERDOC:  [09:05:43]            hooks.cpp(  49) - Log     - Loaded and hooked into dxgi.dll, PID 14912
RENDERDOC:  [09:05:43]            hooks.cpp(  45) - Debug   - Attempting to hook d3d12.dll
RENDERDOC:  [09:05:43]            hooks.cpp(  49) - Log     - Loaded and hooked into d3d12.dll, PID 14912
RENDERDOC:  [09:05:43]            hooks.cpp(  45) - Debug   - Attempting to hook vulkan-1.dll
RENDERDOC:  [09:05:43]            hooks.cpp(  49) - Log     - Loaded and hooked into vulkan-1.dll, PID 14912
RENDERDOC:  [09:05:43]      d3d12_hooks.cpp( 173) - Debug   - Call to Create_Internal Feature Level b000
RENDERDOC:  [09:05:43]      d3d12_hooks.cpp( 214) - Debug   - Calling real createdevice...
RENDERDOC:  [09:05:43]     dxgi_wrapped.cpp( 518) - Warning - Querying IDXGIObject for interface: GUID {7abb6563-02bc-47c4-8ef9-acc4795edbcf}
RENDERDOC:  [09:05:44]      d3d12_hooks.cpp( 235) - Debug   - Called real createdevice... 0x00000001
RENDERDOC:  [09:05:44]      d3d12_hooks.cpp( 257) - Log     - Created wrapped D3D12 device.
RENDERDOC:  [09:05:44]      d3d12_hooks.cpp( 173) - Debug   - Call to Create_Internal Feature Level b000
RENDERDOC:  [09:05:44]      d3d12_hooks.cpp( 214) - Debug   - Calling real createdevice...
RENDERDOC:  [09:05:44]     dxgi_wrapped.cpp( 518) - Warning - Querying IDXGIObject for interface: GUID {7abb6563-02bc-47c4-8ef9-acc4795edbcf}
RENDERDOC:  [09:05:44]      d3d12_hooks.cpp( 235) - Debug   - Called real createdevice... 0x00000000
RENDERDOC:  [09:05:44]      d3d12_hooks.cpp( 239) - Debug   - succeeded and hooking.
RENDERDOC:  [09:05:44]      d3d12_hooks.cpp( 250) - Debug   - created wrapped device.
RENDERDOC:  [09:05:44]    d3d12_resources.h( 569) - Debug   - D3D12 not implemented - Resource mapping
RENDERDOC:  [09:05:44]    d3d12_resources.h( 575) - Debug   - D3D12 not implemented - Resource mapping
RENDERDOC:  [09:05:44]     d3d12_device.cpp(1168) - Debug   - D3D12 not implemented - ReleaseResource
RENDERDOC:  [09:05:46]   resource_manager.h( 896) - Debug   - Preparing up to 32 potentially dirty resources
RENDERDOC:  [09:05:46]   resource_manager.h( 921) - Debug   - Prepared 31 dirty resources
RENDERDOC:  [09:05:46]   resource_manager.h( 937) - Debug   - Force-prepared 0 dirty resources
RENDERDOC:  [09:05:46]     d3d12_device.cpp( 974) - Debug   - Attempting capture
RENDERDOC:  [09:05:46]     d3d12_device.cpp( 990) - Log     - Starting capture, frame 97
RENDERDOC:  [09:05:46] d3d12_command_queue_wrap.cpp(  83) - Debug   - D3D12 not implemented - Serialise_DebugMessages
RENDERDOC:  [09:05:46]     d3d12_device.cpp(1023) - Log     - Finished capture, Frame 98
RENDERDOC:  [09:05:46]     d3d12_device.cpp(1087) - Debug   - Inserting Resource Serialisers
RENDERDOC:  [09:05:46]   resource_manager.h( 859) - Debug   - 7 frame resource records
RENDERDOC:  [09:05:46]   resource_manager.h( 881) - Debug   - 46 frame resource chunks
RENDERDOC:  [09:05:46]   resource_manager.h( 888) - Debug   - inserted to serialiser
RENDERDOC:  [09:05:46]   resource_manager.h( 949) - Debug   - Checking 32 possibly dirty resources
RENDERDOC:  [09:05:46]     d3d12_common.cpp( 800) - Error   - Unrecognised RTV Dimension 0
RENDERDOC:  [09:05:46]     d3d12_common.cpp( 800) - Error   - Unrecognised RTV Dimension 0
RENDERDOC:  [09:05:46]     d3d12_common.cpp( 752) - Error   - Unrecognised SRV Dimension 0
RENDERDOC:  [09:05:46]     d3d12_common.cpp( 800) - Error   - Unrecognised RTV Dimension 0
RENDERDOC:  [09:05:46]     d3d12_common.cpp( 800) - Error   - Unrecognised RTV Dimension 0
RENDERDOC:  [09:05:46]   resource_manager.h(1027) - Debug   - Serialised 31 dirty resources, skipped 0 unreferenced
RENDERDOC:  [09:05:46]   resource_manager.h(1058) - Debug   - Force-serialised 0 dirty resources
RENDERDOC:  [09:05:46]     d3d12_device.cpp(1093) - Debug   - Creating Capture Scope
RENDERDOC:  [09:05:46]     d3d12_device.cpp(1114) - Debug   - Flushing 1 command list records to file serialiser
RENDERDOC:  [09:05:46]     d3d12_device.cpp(1121) - Debug   - Adding 11 chunks to file serialiser from command list 302
RENDERDOC:  [09:05:46]     d3d12_device.cpp(1131) - Debug   - Flushing 14 chunks to file serialiser from context record
RENDERDOC:  [09:05:46]     d3d12_device.cpp(1136) - Debug   - Done
RENDERDOC:  [09:05:46]       serialiser.cpp(1277) - Debug   - writing capture files
RENDERDOC:  [09:05:46]       serialiser.cpp(1305) - Debug   - Opened capture file for write
RENDERDOC:  [09:05:46]       serialiser.cpp(1415) - Log     - Compressed frame capture data from 334002 to 49287
RENDERDOC:  [09:05:46]       serialiser.cpp(1273) - Log     - Timer File writing - 17.594 ms
RENDERDOC:  [09:05:46]             core.cpp( 858) - Log     - Written to disk: C:\Users\oscarb\AppData\Local\Temp\D3D12HelloTriangle_2016.08.28_09.05.43_frame98.rdc
RENDERDOC:  [09:05:46]       serialiser.cpp( 629) - Debug   - Opened capture file for read
RENDERDOC:  [09:05:46]       serialiser.cpp( 629) - Debug   - Opened capture file for read
RENDERDOC:  [09:05:48]      d3d12_debug.cpp(1199) - Debug   - D3D12 not implemented - Not freeing RTV's - will run out

@oscarbg It is also the issue i have with a much more complex and real life sample, if i read the log properly ( RTV failure ). I believe it is something wrong in the capture, not in the replay. I started working locally on @baldurk remarks, but it had been a slow week for side projects.
Thanks for showing interests in my branch tho


rollback pybind11 because the latest one will cause build failure.

A commit used for discussion. Please do not merge this PR.

We will stay with cutting-edge pybind11.


In-circuit implementation for BN254 precompiles: ecadd, ecmul and ecpairing.

What ❔

Update yul wrappers for ecadd and ecmul from contract implementation to circuit.
Add ecpairing contract-wrapper in yul to delegate in-circuit.

Why ❔
To improve performance and boost EVM equivalence.
Checklist

[x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[x] Documentation comments have been added / updated.

think circuit can handle this better than performing calculation in contract

Probably yes, however I guess there might be a necessity of vanguard validation, so that we won't get any issues with proof generation failing for bad input

think circuit can handle this better than performing calculation in contract

Probably yes, however I guess there might be a necessity of vanguard validation, so that we won't get any issues with proof generation failing for bad input

I think this is specific if branching was introduced to optimize the edge case, not because it is a special case. So you can remove this optimisation as circuit will do bettter job anywat

Hey guys, @vladbochok @StanislavBreadless, I have simplified yul contracts as much as possible, moving all validations inside the circuits. Also, I am wondering what values shall be selected as GasPrice for each of ecadd, ecmul and ecpairing, because for now I've just put something akin to EVM equivalent prices.

Guys, you maybe want to switch the base branch from main to dl-precompiles as was mentioned by Jules de Smit so that all our work will be pinned to specific branch across your repositories

@NikitaMasych please go ahead with dl-precompiles

I'll need you to push the dl-precompiles branch in matter-labs/era-contracts checking out of main or whatever you find suitable to be base branch, since I don't have the permission for that

@NikitaMasych please go ahead with dl-precompiles

I'll need you to push the dl-precompiles branch in matter-labs/era-contracts checking out of main or whatever you find suitable to be base branch, since I don't have the permission for that

Similar to how it is done on era-zkevm_circuits repo:
The branch:
https://github.com/matter-labs/era-zkevm_circuits/tree/dl-precompiles
PR:
https://github.com/matter-labs/era-zkevm_circuits/pull/32


Add judgment and Modify level3 cannot be a keyword

Add try/catch in JDBCExample.java

Hi @qiaojialin , how do you think.
@iwasjoker , so "device" can not appear in the path?

Hi @qiaojialin , how do you think.
@iwasjoker , so "device" can not appear in the path?


Support for targetSdkVersion < 23 and compileSdkVersion < 23

Not able to use your library for targetSdkVersion = 21 and compileSdkVersion = 21

Any reason WHY you are using this ?
Library has the newest dependencies 23.1.1 +
compileSdkVersion 23
buildToolsVersion "23.0.2"
minSdkVersion 14
targetSdkVersion 23
Gradle 1.5.0
And you should have the same ...


i'm stack with Extracting data

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Extracting data:   0%|                                                                                | 0/1 [00:00<?, ?it/s]

me too! Have you found a solution yet？

me too! Have you found a solution yet？

none

Hello! Could you expand on your setup and help us reproduce the issue?

Are you using local LLMs? If yes, what is your setup?
What data are you currently trying it on? Is it the book from our example?

I started QWEN on Fastchat, but it got stuck all the time. I'll switch to VLLM to start QWEN and it will run

Hey, could you try to insert a very small example (if you haven't done that already) and see if it gets stuck anyway?


Created KuberenetesResource implementations for EventType

Part of #3181
Proposed Changes

Create EventType KubernetesResource implementations so that we can have proper typing when implementating the AutoCreate features

/test unit-tests

/test unit-tests

/test unit-tests

@pierDipi I am getting the following warnings which cause the unit tests to fail, but I believe I added the correct license header. Any ideas what is going on?


Populate smallruminants yaml files

YAML files for small ruminants are generated.
I've tried to categorize them similarly to cattle.
Some files seem to be parents (?) so I didn't put them into sub-dirs.
@gbadske @jphill01 please review and confirm if issue can be closed.


Add linrongbin16/gitlinker.nvim

Checklist:

[x] The plugin is specifically built for Neovim, or if it's a colorscheme, it supports treesitter syntax.
[x] The lines end with a .. This is to conform to awesome-list linting and requirements.
[x] The title of the pull request is Add/Update/Remove `username/repo`  (notice the backticks around `username/repo`) when adding a new plugin.
[x] The description doesn't mention that it's a Neovim plugin, it's obvious from the rest of the document. No mentions of the word plugin unless it's related to something else.
[x] The description doesn't contain emojis.
[x] Neovim is spelled as Neovim (not nvim, NeoVim or neovim), Vim is spelled as Vim (capitalized), Lua is spelled as Lua (capitalized), Tree-sitter is spelled as Tree-sitter.
[x] Acronyms should be fully capitalized, for example LSP, TS, YAML, etc.

Thanks for the PR!
Something went wrong with the syntax of your line, when you fix that I can merge your PR. See the failing CI.

Is original repository really that not maintained? Seems like last commit was only three weeks ago.

For respect, I will close this PR.


runtime: change in Caller prevents detecting program name

I used to have a way for packages to determine the name of the program that included them. This is very helpful for providing easy-to-use metrics and logging packages: the package determines the name of the program, and everyone knows how to map between the name of the metrics/logs and the location of the relevant source code. The implementation details I was using to do that have changed during the Go 1.10 cycle, and it's not clear how I can move forward.
What version of Go are you using (go version)?
go1.10beta1:
$ go version
go version devel +9ce6b5c2ed Thu Dec 7 17:38:51 2017 +0000 darwin/amd64

Does this issue reproduce with the latest release?
This is a regression since Go 1.9, present in go1.10beta1.
What operating system and processor architecture are you using (go env)?
darwin/amd64, linux/amd64
What did you do?
Since Go 1.4, I've maintained a (closed-source) package that allows programs to determine their name: the import path of the "main" package. This was based on using runtime.Caller in an init function until encountering main.init. The filename defining that function would allow my package to determine the import path of the program (assuming $GOPATH didn't include a bonus "/src/" element).
This worked well until Go 1.9, when the filenames of all init functions changed to be <autogenerated>. I updated my package to rely on even more arcane implementation details, using runtime.FuncForPC to do a binary search of the executable between the PC for main.init and the PC for its own init function to find other code within package main that included a real filename, and returning the import path it calculated from that.
Then, I upgraded to go1.10beta1 and found that the package was once again broken, with git bisect pointing to the removal of <autogenerated> methods from stack traces (https://github.com/golang/go/commit/e97209515ad8c4042f5a3ef32068200366892fc2). /cc @aclements
What did you expect to see?
I expected that the caller of an init function would continue to be the code that caused it to run—that is, the package that caused it to be part of the program by importing it.
I expect there to be a way for programs to determine their identity. This package is deployed in a large number of (closed-source) applications, where it is used when naming logs and metric streams for a clear bidirectional mapping between metrics and the programs that generated them.
I expected to be able to work around the change, with some other way of getting ahold of a program counter for something in package main, without having to dig even deeper into unsupported behavior.
From https://github.com/golang/go/issues/22231#issuecomment-340627198, "Using Caller(1) in an init function is definitely depending on an implementation detail that could easily change for any number of reasons." makes it clear that this behavior should not be trusted .. but what is the alternative?
What did you see instead?
Today https://play.golang.org/p/-RRrePXZMo prints three frames, and would print more if it were in a non-main package:
goroutine 1 [running, locked to thread]:
main.printStack()
	/tmp/sandbox953472673/main.go:10 +0x80
main.init.0()
	/tmp/sandbox953472673/main.go:15 +0x20
main.init()
	<autogenerated>:1 +0xa0

go1.9

But with go1.10beta1, it prints only two:
$ go run /tmp/main.go
goroutine 1 [running, locked to thread]:
main.printStack()
	/tmp/main.go:10 +0x77
main.init.0()
	/tmp/main.go:15 +0x20

devel +9ce6b5c2ed Thu Dec 7 17:38:51 2017 +0000

Critically, the final frame is in the function that calls runtime.Stack/runtime.Caller and no longer leads all the way up the import tree to the "main" package.

Can you just look at os.Args[0] instead?

Or https://golang.org/pkg/os/#Executable

I'm looking for the full import path of the program. When adding instrumentation to https://godoc.org/golang.org/x/tools/cmd/present, the path I'd look for is "golang.org/x/tools/cmd/present". os.Args[0] and os.Executable might be able to give me "present". The name of the directory containing the program isn't generally meaningful in my environments.
We'd end up with a bunch of different programs claiming to be "server", "api", or "worker".
I guess it could be done via debug/elf (and os.Executable): the symbol table would give an offset that I could use with runtime.FuncForPC. I'll give that a shot and measure its overhead. Thanks for the suggestions!

I'm looking for the full import path of the program.

Something like this?

Why does it need to be called in init? Calling it from main.main would work, right?

Calling from main.main would give the correct results, but changing to require that is impractical. The results of the lookup are used in several places in our programs. Some programs may initialize everything in main.main, some may use goroutines. Some packages have their own init functions, which would run before main.main starts. These details may change as service owners refactor their code.
@cznic I'm looking for the import path of the program's main package. The code you linked looks like it gives the import path of the immediate caller. I use a function like that one for a related purpose—for importable packages to give unique names to data they provide in expvar and runtime/pprof—but it doesn't help to differentiate between metrics emitted by different programs using the same stats package.
Reading the symbol table has worked so far on linux and darwin. I haven't tackled windows support yet.
Looking at the call stack relied on implementation details, but it was cross-platform. The runtime package provides access to GOOS/GOARCH, the compiler name, the compiler version, and GOROOT. Maybe it could also give access to the import path ("name") of the program?

I'm looking for the import path of the program's main package. The code you linked looks like it gives the import path of the immediate caller.

Correct, but then why not just call it from within the main package? I'm probably missing something.

The results are used in several metrics/logging packages. They are initialized in a variety of places across a large number of programs (each with a different main package) which are maintained by different teams. Migrating all of our programs to use a new API which only works when called from the main package is impractical for us.

Hi @rhysh. Sorry that this broke for you.
If you're willing to try more implementation-dependent tricks, I believe it should still work to call runtime.Callers and then iterate over the returned PCs manually (rather than using CallersFrames). One of those PCs (probably the last one) should still the be generated super-init function in the main package, which should keep your existing code working.

The runtime package provides access to GOOS/GOARCH, the compiler name, the compiler version, and GOROOT. Maybe it could also give access to the import path ("name") of the program?

My concern with doing something like this is that package/import paths aren't actually part of the Go language. They're part of the build system, and there are build systems that define them differently (e.g., Blaze [Bazel used to, but it seems that was fixed, thankfully]). And this may get more complicated even in the go tool with changes for package versioning.

Reading the symbol table has worked so far on linux and darwin. I haven't tackled windows support yet.

I would argue that this is actually the "right" way to do this, even though I understand it requires a little platform-dependent code (I think only a few lines per platform though?). It doesn't depend on any implementation details and it goes through well-defined interfaces. Even the runtime doesn't really have this information handy; it obviously has a map from PC to function, but there's no map the other way around.


Changed comments name inside grammar

Changed comments name to 'comment.line.rainmeter' to get better consistency
with other languages (e.g. python and c). This also stresses that the comment is a line comment.
From a more pragmatic point of view, it enables the custom-folds package to graphically highligh the beginning and end of a custom fold region.

this is quite an old project but thanks for caring about it and updating it


Add encryption support using a shared password (Insertable Streams)

@jeremija What would it take for e2e encryption to occur on devices using a custom built iOS, MacOS, Windows, or Android app?

Hi @chrismgonzalez, this is experimental technology. Out of all major browsers, I think Chrome is the only one that currently supports it, and it's hidden behind a flag .
I think Electron 9 has support for this as well (since it's based on Chromium), so that should make it easy to build a native Windows/Mac/Linux app. As for iOS and Android, unless if there's a React Native module for this, you'd probably have to use the WebRTC C++ library:
See https://webrtchacks.com/true-end-to-end-encryption-with-webrtc-insertable-streams/:

This is not a new idea – the webrtc.org library already has a native API for frame encryption. However, this was never exposed to the browser. Surprisingly, it is not used by the current API. This can be seen in channel_send.cc. The difference here is that Insertable Streams needs to be asynchronous.

See the FrameEncryptor interface.


Thumbnail prefix

Extensions - Resize Images
Image prefix is not saved
Docs

A relative path in which to store resized images. For example, if you specify a path here of thumbs and you upload an image to /images/original.jpg, then the resized image is stored at /images/thumbs/original_200x200.jpg. If you prefer to store resized images at the root of your bucket, leave this field empty.

When I save the image with the name original
the thumbnail is not saved with the name original_200x200, instead - _200x200

Duplicate https://github.com/firebase/extensions/issues/20#issue-501070832


Display namespace in deployment summary

Hey, I just made a Pull Request!
Enhanced the deployment summary, DeploymentDrawer, to display the namespace of the deployment. It is useful when a component is deployed in multiple namespaces i.e. dev, test, prod in a single cluster.

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@mclarke47 for visibility! :eyes:

Ping @deepak-bhardwaj-ps


Cannot define "indices.settings" of MeilisearchConfig with PHP

Description
I am migrating my Symfony configuration to use a type-safe PHP-based ConfigBuilder.
However, there seems to be a problem with the definition of the Meilisearch configuration, which causes the following code to not work:
$meiliSearchConfig
    ->indices()
        ->settings([
            'filterableAttributes' => [
                'type',
                'difficulty',
            ],
            'sortableAttributes' => [
                'id',
            ],
        ]);

The error message states:
The following keys are not supported by "Symfony\Config\MeiliSearch\IndicesConfig\SettingsConfig": filterableAttributes, sortableAttributes

Expected behavior
I should be able to define settings as I did in my YAML configuration.
meilisearch:
  indices:
    - settings:
        filterableAttributes:
          - type
          - difficulty
        sortableAttributes:
          - id

Current behavior
In FileLoader.php line 177:

  The following keys are not supported by "Symfony\Config\MeiliSearch\IndicesConfig\SettingsConfig": filterableAttributes, sortableAttributes in /Volumes/Dev/ResearchProject/lets-php/app-sf/config/packages/meilisearch.php (which is being imported from "/Volumes/Dev/ResearchProject/lets-php/app-sf/src/Kernel.php").

In SettingsConfig.php line 16:

  The following keys are not supported by "Symfony\Config\MeiliSearch\IndicesConfig\SettingsConfig": filterableAttributes, sortableAttributes

Screenshots or Logs

Environment (please complete the following information):

OS: macOS
Meilisearch version: N/A
meilisearch-symfony version: dev-main (d46b2da1865ef228aaca67eeac9e6851022dbeaf)

this happens to my yaml configuration too.
meilisearch:
    url: '%env(MEILISEARCH_URL)%' # URL of the Meilisearch server (mandatory)
    api_key: '%env(MEILISEARCH_API_KEY)%' # API key to access the Meilisearch server (mandatory)
    prefix: '%env(MEILISEARCH_PREFIX)%'
    doctrineSubscribedEvents: ['preRemove']
    batchSize: 250
    indices:
        -   name: products
            class: App\Entity\Product\Product
            index_if: isIndexable
            enable_serializer_groups: true
            serializer_groups: ['shop:product:searchable']
            settings:
                filterableAttributes: ['productTaxons','brand','featured','attributes','mainTaxon','code','tags']
                searchableAttributes: ['translations']
                sortableAttributes: ['createdAt','variants']

when i try to create indexes with bin/console meili:create i got follwing error
In SettingsUpdater.php line 73:
Exception::__construct(): Argument #1 ($message) must be of type string, array given
but when i remove the settings it just creates without a problem


tests use cross-spawn-async instead of child_process.spawn

This allows Windows to run the tests, as promised in
https://github.com/feross/webtorrent/issues/429#issuecomment-146061289
Note that there are a couple of outstanding failures on Windows:
# client.seed: filesystem path to folder with one file, string
not ok 8 should be equal
  ---
    operator: equal
    expected: '3a686c32404af0a66913dd5f8d2b40673f8d4490'
    actual:   'e6887b78d89d995876c7cef3476b6fb32c4c4e3d'
  ...
not ok 9 should be equal
  ---
    operator: equal
    expected: |-
      'magnet:?xt=urn:btih:3a686c32404af0a66913dd5f8d2b40673f8d4490&dn=folder&tr=udp%3A%2F%2Ftracker.webtorrent.io%3A80'
    actual: |-
      'magnet:?xt=urn:btih:e6887b78d89d995876c7cef3476b6fb32c4c4e3d&dn=folder&tr=udp%3A%2F%2Ftracker.webtorrent.io%3A80'

Note that there are a couple of outstanding failures on Windows:

Hmm, this appears to have been due to a bad core.autocrlf setting I had in the VM. core.autocrlf was set to true, so ./test/content/folder/file.txt had an extra CR character in it, causing the infoHash to differ. Running git config core.autocrlf input and refreshing file.txt allowed the tests to pass. See here for more info: https://help.github.com/articles/dealing-with-line-endings/#platform-linux


[IDE] Import completion

It would be nice if we could complete path imports by enumerating file system and module imports by looking at available node_modules.

and libraries as well!

@timotheeguerin Are the follow-up items tracked already? I know we still want relative path completion and I believe there were some other improvements you had in mind? If they are tracked, linking from here would help find them. If not, could you file them?

No, still need to create the 2 new issues

https://github.com/microsoft/cadl/issues/621
https://github.com/microsoft/cadl/issues/622


Create Exponetialsearch.py

Title :

Issue no :

Description

Screenshots (if applicable)

Checklist

[x] I have read and agree to abide by the Code of Conduct
[x] I have read and followed the Contributing Guidelines

this is the code of exponential search in python. this code is not  present in the repository so i contribute this for your repo.
if this good is better for your repository then merge it

Title :
Issue no :
Description
Screenshots (if applicable)
Checklist

[x]  I have read and agree to abide by the Code of Conduct
[x]  I have read and followed the Contributing Guidelines

Hey @s7917 !
Great job there on implementing Exponential Search. However it would be great if you can follow the COC and update the details in your PR here

 @himanshu-03 please see that screenshot.... this interface is show in my repository.... resolve this issue please

yes this is fine it would be great if you can update the details in your PR here

i am creating poll request again for exponential search
and now i am close this poll request...............


removed s3 endpoint from vpc code

removing s3 endpoint to fix errors

Thomas is adding an issue for this. Approving.

linked issue


Set data bag item lookout to a variable in the correct scope

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@delivery approve

Change: 81e4018c-3438-46a9-9ed2-55bf380a81e4 approved by: @schisamo

This PR has passed 'Acceptance' and is ready to be delivered!
Use: '@delivery deliver' when validated in acceptance.

@delivery deliver

Change: 81e4018c-3438-46a9-9ed2-55bf380a81e4 delivered by: @schisamo


Fixed port number for Syncthing v0.11

Updated the port number to be compatible to SyncThing 0.11
which is using 8384 instead of 8080.

nice, thx :)


⚠ Bofrost.at has degraded performance

In efb940a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1238 ms

Resolved: Bofrost.at performance has improved in 40b74b8 after 10 minutes.


[BEAM-7819] Add missing fields to python apache_beam.io.gcp.pubsub.PubsubMessage

Add the publish_time, message_id and ordering_key
attributes to the PubsubMessage class
Convert google.protobuf.timestamp_pb2.Timestamp to python
datetime in _from_proto_str
Ensure message_id and publish_time fields are unset
in WriteToPubsub

This also addresses [BEAM-10958]

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[X] Choose reviewer(s) and mention them in a comment (R: @username).
[X] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[X] Update CHANGES.md with noteworthy changes.
[X] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @pabloem
Is it expected that the formatter/lint tests will fail? It's mostly indentation errors on lines I haven't changed

It seems to be failing on the lines you have changed. Please try fixing those.

Run Python PreCommit

Run Python PreCommit

Run Python 3.8 PostCommit

LGTM. Thanks!

@pabloem I was a little surprised to find that this didn't make it into the 2.30.0 release.  Should I expect it in 2.31?

(cc @aaltay and @ibzib -- is there a timeline for this actually landing on a release branch)

Here is a link to the release policy: https://beam.apache.org/contribute/release-guide/
Once the release branch is cut, you can check to see if your change is included. This change will be included in the 2.31.0 release.

Release branches are publicly visible at release-2.x.0 e.g. https://github.com/apache/beam/commits/release-2.31.0?after=9161c9417a6c58cc54367e58370a64f8050a3e59+139&branch=release-2.31.0

It’s been months now and this still hasn’t been included in a release. As @n-oden said back in June, “is there a timeline for this actually landing on a release branch?”

@astorrs All changes are automatically picked up by a "release cut" that happens roughly once every 6 weeks. https://beam.apache.org/contribute/#when-will-my-change-show-up-in-an-apache-beam-release
This change was included starting with the 2.31.0 release of Beam in June. If you still see this bug in newer versions of Beam, please let us know.


Added pool.GetTimeout to limit how long Get blocks when pool is empty

This currently only affects Get if CreateLimit is used, but this could be used in the future for any other blocking features that are added. A specific ErrGetTimeout is returned if it is hit so the caller could potentially do something special.

@mediocregopher updated fixing those 3 things. Not sure why I thought nil channels returned the zeroed value immediately versus blocking.


is "ENABLE_MONGODB=0" outdated ?

I see usage of "ENABLE_MONGODB=0" in "release" script, however, it seems that variable is not used anywhere
[ilia@localhost ClickHouse]$ grep -r ENABLE_MONGODB .
./contrib/libpoco/CMakeLists.txt:option(POCO_ENABLE_MONGODB "Enable MongoDB" ON)
./contrib/libpoco/CMakeLists.txt:if (POCO_ENABLE_MONGODB)
./doc/build_osx.md:export ENABLE_MONGODB=0
./doc/getting_started/getting_started_en.md:~/ClickHouse$ ENABLE_MONGODB=0 ./release --standalone
./doc/getting_started/getting_started_ru.md:~/ClickHouse$ ENABLE_MONGODB=0 ./release --standalone
./.travis.yml:    - ENABLE_MONGODB=0
./release:debuild -e DAEMONS="${DAEMONS}" -e ENABLE_MONGODB -e GLIBC_COMPATIBILITY -e CC -e CXX -b ${DEBUILD_NOSIGN_OPTIONS} ${DEBUILD_NODEPS_OPTIONS}
[ilia@localhost ClickHouse]$

is it still possible to build Clickhouse without mongodb support ? am I missing something ?

We removed libmongodb dependency at December. Now we use Poco library (which is built from sources by default) for external MongoDB dictionaries.
Remaining mentions of ENABLE_MONGODB variable in ClickHouse's sources don't make sense.

ok, I can make "cleanup PR" on that
stay tuned....


(maint) Fix typo in exception handler

When a Bolt::error is rescued there was a typo in the is_a? method where the ? was ommitted. This was causing acceptance tests failures in ORCH.

Running acceptance tests locally with changes to file_cache.rb from https://github.com/puppetlabs/bolt/pull/721.


Android: "Invalid url, go in settings" despite app working

Hey - thanks for making this app!
Sometimes it works even too well :-) I installed it from the play store today, and the start screen has an orange bar saying "Invalid url, go to settings" (probably from here).
The thing is: According to my server logs, the app is actually sending locations.

I couldn't reproduce this on a second phone of mine, unfortunately. So maybe it is spurious. Let me know if you need more information about the OS etc. :)

I get this sometimes when the network cuts out

I see. that makes sense. Nevermind in that case :+1:

Thanks @dermesser and @dshanske for reporting and letting us know! I know that for the iOS app similar issues can occur when there's some network cut issues. And let us know if there's a clearer pattern we can investigate :-)

It should recognize unable to connect with a better error message


micro_ros_arduino on Portenta interfaced with Jetson Xavier NX

Hello guys! I'm currently working on a project using ROS2 Dashing installed on a Jetson Xavier NX to do some high-level robotics control. For the low-level controller I'm using a Portenta H7 and I will like to interface the Jetson Xavier NX with the Portenta via Ethernet (with the Vision Shield). I want to be able to send ROS2 messages to the Portenta, and then perform other processes with this information.
Will this be possible with your library? As I see that you work with the ROS2 Foxy version, and I have Dashing installed on my Jetson NX. I would appreciate any guidance.
Thanks in advance!

Hello @guilleherreraf, yes with this package you should be able to build a micro-ROS application for Arduino Portenta H7, the micro-ROS application will run in the M7 core.
This micro-ROS application will be communicated with a micro-ROS Agent in charge of handling the ROS 2 communication, you can read more about this architecture here.
Regarding the compatibility between Foxy and Dashing, one of the things that can be critical is the versions of the ROS 2 middleware. Have you tried to communicate Foxy with Dashing with some examples?

Hello @pablogs9 thanks for your quick response!
I have not yet tried to communicate Foxy with Dashing. On the other hand, in order to program the Portenta I'm using a Windows 10 machine with the Arduino IDE. I have also a virtual machine (with Ubuntu 20.04 and Foxy installed). Maybe I could try to install the micro-ROS package on the Portenta through the Virtual Machine.... However, I will still have the compatibility issue (Foxy and Dashing). Do you think it is something I will be able to do?

You can just install the micro-ROS library for Arduino in your Arduino IDE... Just download this repo as a .zip and use the Add library from .zip...`

So if I understand correctly, using the Arduino IDE (with the installed micro_ros_arduino library) to flash the Portenta I do not need to follow all the cross-compilation process you describe on your website (create, configure, build and flash)? I can just open the publisher example, upload it to the Portenta, and then connect the Portenta via Ethernet on a machine running Linux and I will be able to subscribe to the corresponding topic? (Running echo for instance)

Well:

Using the micro-ROS module for Arduino you don't need to use the micro-ROS build system (create, configure...) because you have precompiled versions for some platforms.
micro-ROS needs a micro-ROS Agent in order to talk with the ROS 2 world, so in your Linux machine you will need an agent. We have a dockerized version: docker run -it --rm --net=host microros/micro-ros-agent:foxy [args]
micro-ROS module for Arduino by now only supports serial transports, so you will need to connect your Portenta with a USB-C cable to the machine with the Agent.
For example, opening an agent for the serial transport in the Portenta should be something like: docker run -it --rm --net=host microros/micro-ros-agent:foxy serial [PORTENTA SERIAL DEVICE] -v6
If you want to have UDP transports (for the communication between client and agent) you will need to implement these functions accordingly. If you need help with this we can guide you, and if contribute them to this repo it will be awesome.

You can read more about the micro-ROS architecture here: https://micro-ros.github.io//docs/overview/features/

And yes, once you have a micro-ROS client connected to the micro-ROS agent you will be able to publish, subscribe, create services/clients, having executors, and some other cool features.

Ok @pablogs9 I understand. Well first of all I will try to have the serial example running, and from there try to adapt it to my system requirements. My main concern is the Foxy-Dashing compatibility. But well, I'll see how it works.
Thanks a lot again and I'll keep you posted!

I have done a quick test and it seems that at least for basic types and pub/sub it works:

That is great! I will try to do the same today and let you know how it goes!

@pablogs9 I tried running the docker container in the NX but it throws the follwing error, due to the used architecture:

The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

Is there a parameter to specify a given architecture?

You need to run this docker in a Linux machine

I have a version of Ubuntu on my Jetson NX, the only difference is that it has an architecture different from amd64.
Anyway, For now I'm trying with the Portenta connected to my machine running the VM with Ubuntu 20.04 and ROS Foxy. I uploaded the publisher example with the Arduino IDE and I have tried both running the client with and without Docker, with the following commands respectively:
No Docker: ros2 run micro_ros_agent micro_ros_agent serial --dev /dev/ttyACM0 -v6
Docker: sudo docker run -it --rm -v /dev:/dev --privileged --net=host microros/micro-ros-agent:foxy serial --dev /dev/ttyACM0 -v6
In both cases I get the following in the terminal:

I do not get any other message and if I try running ros2 topic list I only see these topics:

Hello, Ubuntu is running under a virtual machine? Because in that case, you should first check that you have full duplex communication between your host machine and the virtualized Ubuntu machine. Otherwise, the agent won't be able to receive requests from the agent or answer to them.

Hello @jamoralp. I'm not sure, I'll look into that. Thanks for the suggestion!

Are you still having issues running this on the NX @guilleherreraf?
Like @B00M3RSIX I have also been able to run the serial agent in containers based on arm64v8/ros:foxy and arm64v8/ros:galactic (in my case on a AGX Xavier) without any issues.
I also tried to compile the micro-ros-agent for foxy on the 18.04 based system from the newest JetPack, but gave up after a while. It might be possible but seemed to be pretty tricky. I haven't tried to install the dashing version of  micro-ros-agent, but it will probably work since the foxy version worked on aarch64.
Nvidia is planning to release a 20.04 based OS as a preview for Jetson Q1 2022 (see https://forums.developer.nvidia.com/t/jetson-software-roadmap-for-2h-2021-and-2022/177723)
Using the micro-ros-agent for foxy/galactic directly on the main OS or in their special docker images that support hardware-accelerated graphics should be pretty straightforward after that release.

Closing due to inactivity. Reopen if needed.


fix: refactor to use open-turo/actions-go composite actions

Description of the change

Description here

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists
Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] Jira issue referenced in commit message and/or PR title

Testing

Description of testing

These changes not necessary, I am closing this PR.


Replace CGFloat.pi with CGFloat(Double.pi) for ActivityIndicatorShape #no-public-changes

I have experienced an issue that had been described here ninjaprox/NVActivityIndicatorView#138.
Since activity indicator animations in IBAnimatable have been ported from the NVActivityIndicatorView project, I thought that the solution had to be the same, and it worked.
This patch fixes missing activity indicator animations on iPhone 5.

          2 Warnings

:warning:
Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

:warning:
Consider adding / updating the demo ap.

  Generated by :no_entry_sign: Danger

@broadwaylamb thanks for fixing that issue 👍. I remember I migrated all .pi manually since we ported the project in Swift 2. But I don't know CGFloat.pi would cause problem.
I am going to make a release like 4.0.1, Can I ask you a favor to add an item to https://github.com/IBAnimatable/IBAnimatable/blob/master/CHANGELOG.md#bugfixes because you do fix a bug. I didn't recongize when I mreged it.


Link to AWS setup returns 404

The link on page https://quickwit.io/docs/guides/storage-setup/aws-s3/ to https://quickwit.io/docs/guides/storage-setup/aws-setup is a 404.

It seems it works. I also tested it in incognito mode. Can you test it again?


Moar perf

Remove some functions because apparently function call overhead is somewhat high in PHP

For #256

Getting rid of tryGet and coalesce is a great idea. LGTM.


Bug-fixes & functionality that replaces comment popup&tooltips

Bug-fixes & functionality that replaces Mirador comment popup and tooltips with external ones
Functionality that replaces Mirador comment popup and tooltips and notifies external applications
Bug-fix: change implementation of resize function because latest merges assosiated with image coordinates doesn't work fine. It can be reproduced with the only image from http://oculus-dev.harvardx.harvard.edu/manifests/drs:48309543
#764
Bug-fix: in-manifest annotations not being aligned properly with canvas
#918

I extracted some commits from Stanislav's work in order to review them faster. I need to fulfill one more todo task but you can check the other code.

I have merged this and will start testing it and create tickets for anything I find.  @radpet @beaudet

@rsinghal
Okey I'll prepare another one soon. I need to organize them a little bit. I think it would be better if you check this one before we merge the other in order to track any issues easier.

Sounds good.  I am also fixing some things and will be pushing those changes to this branch as well.


Adding the ability to create/modify/delete micromanager groups and presets + groups and presets table

This PR adds the ability to create, modify, delete and save groups and presets like in micromanager.
https://user-images.githubusercontent.com/70725613/153727471-2b2f8102-0306-454b-9205-4c4997878e1d.mov

New/Add:  Create a new group with presets or add presets to a selected group' -> _create_group_presets().

https://user-images.githubusercontent.com/70725613/153727408-522426f9-aa6f-4be7-9f7d-5256ac555077.mov
https://user-images.githubusercontent.com/70725613/153727414-1757db89-f601-4747-95d2-4c29e02e921b.mov
https://user-images.githubusercontent.com/70725613/153727416-7a825150-d3c5-456b-b968-baa29696a51a.mov

Edit: Modify the (device, property, value)(s) of the selected preset in the selected group -> _edit_group_presets().

https://user-images.githubusercontent.com/70725613/153727450-a0cc5532-db39-47b0-8851-d72aa3ede0bc.mov

Rename: Rename the selected group and/or the preset name -> _open_rename_widget().

https://user-images.githubusercontent.com/70725613/153727453-4ff90334-779b-45b0-8327-4364059cf2e7.mov

Delete Group: Delete the selected group (and all the presets) -> _delete_selected_group() (in _group_and_presets_tab.py).
Delete Preset: Delete only the selected presets in the selected group -> _delete_selected_preset() (in _group_and_presets_tab.py).

https://user-images.githubusercontent.com/70725613/153727461-ce44357d-c276-429f-a40a-a613ac5adc69.mov

Channel group: if there is a channel group, change the channel with either the channel_comboBox in the main gui or in the groups_and_presets table.

snap_channel_comboBox -> _change_channel_main_gui() -> set new channel  -> _change_channel_cbox_in_table() -> set the channel in the table channel combobox (with blockSignals).
channel_comboBox in group table -> set new channel -> send signal  table_wdg_changed -> _change_channel_main_gui() -> set the snap_channel_comboBox in main gui (with blockSignals).

https://user-images.githubusercontent.com/70725613/153727486-d760e29c-c85f-476c-8e95-90abe460fb45.mov

Objective group: change the objective with either the objective_comboBox in the main gui or (if there is an objective group) in the groups_and_presets table.

objective_comboBox -> _change_objective_main_gui() -> set new objective  -> _change_objective_cbox_in_table() -> set the objective in the table objective combobox (with blockSignals).
objective_comboBox in group table  -> set new objective -> send signal  table_wdg_changed ->_change_objective_main_gui() -> set the objective_comboBox in main gui (with blockSignals).

https://user-images.githubusercontent.com/70725613/153727492-5e68f639-c93b-449c-b0bb-de300ab4bd44.mov

This looks really exciting @fdrgsp!
I think I have to request that we try to break it into smaller chunks though.  Reviewing 2500 lines making changes across 15 files is just really really hard to do.  It causes reviewer fatigue, meaning the reviewer will eventually just give up and hope that everything is ok (so you don't get a useful review), or the reviewer will just never finish, or it will get mired down in small comments.  Is there any way to contain this a little bit more?

I agree with talley that it would be helpful to review this more broken up, or at the very least squashed into a few commits, each of which does a specific thing.
The other review point I have is based on the gifs (thank you for those!) which is that I think we should be careful about what the order of tabs is. In particular I think we should keep Snap/Live as the first one as that is the most useful thing when you first open. Or we can follow micromanager's lead and condense snap/live and put them side by side wit hthis panel.

this one is too massive.  I do love the functionality, but it's just not possible to review at this size.  If merging main allows this to be more confined to a file or two, then go ahead and do that.  Otherwise, consider closing this and accomplishing this in a more step-wise fashion.  For example, it's ok to make a PR adding a component that you intend to use in a later PR, that isn't actually hooked up to the rest of the UI.  It's much easier to review individual components in isolation, and then have one PR where it gets "hooked up".  thanks!


ERROR Error: Expecting instance of DOM Element

'<ng5-slider [(value)]="value" [(highValue)]="highValue" [options]="options">
'
'value: number = 40
highValue: number = 60
options: Options = {
floor: 0,
ceil: 100
}'

Did you find the cause of this bug?

Any solution ?

Maybe it's because you didn't put the end tag?

I assume this is a duplicate of #195.


Fixed smallvec implementations to process elements inside.

Now there's one drawback that in some case SmallVec won't be supported where A is still smallvec::Array but isn't [T; N]. However, it should be OK in reality, given smallvec itself is going to be SmallVec<T, N> instead of SmallVec<[T; N]> with removing this.
Context: https://github.com/servo/rust-smallvec/issues/183
Closes #89

Hi @xkikeg and thanks for another PR!
So as I understand it:

smallvec 1.x is defined as SmallVec<A: Array> where Array is a trait with an Item associated type
smallvec 2.x is defined as SmallVec<T, const N: usize>

This PR improves the impl from:
impl<A> ToBoundedStatic for smallvec::SmallVec<A>
where
    A: smallvec::Array + 'static,
    A::Item: Clone

To become:
impl<T, const N: usize> ToBoundedStatic for smallvec::SmallVec<[T; N]>
where
    [T; N]: smallvec::Array<Item = T>,
    [T::Static; N]: smallvec::Array<Item = T::Static>,
    T: ToBoundedStatic

This is clearly an improvement, as we can now convert any SmallVec<[T; N]> where T: ToBoundedStatic.
The limitation, as you note, is that it is restricting the usage to SmallVec<[T; N]> rather than the more general SmallVec<A> where A: Array.  Not an issue for smallvec 2.x but could be a limitation for smallvec 1.x users.
I had a try and generalising it for the current smallvec 1.x version and came up with this (and similar for IntoBoundedStatic):
impl<A, T> ToBoundedStatic for smallvec::SmallVec<A>
where
    A: smallvec::Array<Item = T> + ToBoundedStatic,
    T: ToBoundedStatic,
    <A as ToBoundedStatic>::Static: smallvec::Array<Item = T::Static>,
{
    type Static = smallvec::SmallVec<A::Static>;

    fn to_static(&self) -> Self::Static {
        self.iter().map(ToBoundedStatic::to_static).collect()
    }
}

To make this work I also had to remove the Copy restriction from impl<T, const N: usize> ToBoundedStatic for [T; N] which is possible these days thanks to core::array::from_fn.
I changed:
impl<T, const N: usize> ToBoundedStatic for [T; N]
where
    T: ToBoundedStatic + Copy,
{
    type Static = [T::Static; N];

    fn to_static(&self) -> Self::Static {
        // Note that we required that `T` is `Copy` here whereas the `IntoBoundedStatic` impl does not.
        self.map(|item| item.to_static())
    }
}

To become:
impl<T, const N: usize> ToBoundedStatic for [T; N]
where
    T: ToBoundedStatic,
{
    type Static = [T::Static; N];

    fn to_static(&self) -> Self::Static {
        core::array::from_fn(|i| self[i].to_static())
    }
}

What do you think?

Thanks for suggestions! Your impl seems good so no objections for going with that approach (A: Array<Item=T>).

@xkikeg merged, thanks.  Do you need this immediately?  If not i'd prefer to hold off on a release until some other changes land.


ARROW-5648: [C++] Avoid using codecvt

Some antiquated C++ build chains miss the standard  header.
Use a small vendored UTF8 implementation instead.

Building with this change on the Rtools setup does succeed: https://ci.appveyor.com/project/nealrichardson/arrow/builds/25397807
So as far as that is concerned, LGTM.

Appveyor build: https://ci.appveyor.com/project/pitrou/arrow/builds/25396740


LFS-506: Icon button uses term identifier instead of @path

To test install any vocabulary (ex. HP), check info buttons in drop-down suggestions for Co-morbidities... input field in Demographics form.
For testing vocab terms with special characters in id follow steps in jira task to reproduce LFS-463 and test info button for term suggestions.

Found the following problem with ICD-O-3-T
Use ICD-O-3-T in Comborbidities of Demographic form

type kidney in Comorbities --> you will get 2 options --> click on "i" bttn of the first option (KIDNEY) --> you will get this (correct)

click on the "LEARN MORE" button --> then click on the "i" bttn of the first option (KIDNEY) and you will get this (correct)

now click on the "i" bttn of the second option (Kidney, NOS) and observe the error

Steps for ICD-O-3-M:

type renal in Comorbidities --> notice the following 2 options renal pelvis and RENAL PELVIS
click on the "i" bttn of the RENAL PELVIS
click on the LEARN MORE bttn
click on "i" bttn of the renal pelvis and observe the error

@sdumitriu Noticed a room for some optimization but not sure whether it's needed. When you click on info button, this sends a request for the term info.json. When you then click on on "learn more", the same request is sent again to open term browser. Shell we optimize and pass the already requested term info to the term browser or its not that important?

The problem that I reported above is solved.


Cannot open using open <deck>.podium

Expected behaviour
In a terminal on macOS, executing open <deck>.podium should open the deck in podium
Actual behaviour
Invoking the command opens podium in my taskbar, but doesn't open the deck.
I can then navigate to podium, which invokes a file selector window, where I can then open my deck.
Local system
macOS High Sierra, iterm2

Confirmed.
For the record: there's 5 ways you should be able to open a slide deck:

Open Podium from finder/launchpad, select document
Double click on a podium deck in finder
Drag a podium deck onto Podium in the taskbar
open <deck>.podium from the command line
podium <deck.podium> from the command line, inside a virtual environment.

The process of opening documents is a little complex. It's (unfortunately) not as simple as just using sys.argv; it relies on the Cocoa NSDocument interface that was recently abstracted behind DocumentApp.

Resolved by #686


Ionic 4 not working (using beta version of ionic-image-loader)

Can someone help me using ionic-image-loader with Ionic 4 ?
i installed the beta version (v4) of ionic-image-loader.
i got this error
ERROR in node_modules/ionic-image-loader/lib/services/image-loader.service.d.ts(3,25): error TS2307: Cannot find module '@ionic-native/ionic-webview/ngx'.
[ng]
How to fix that ?
Thanks

You need to run npm i -S @ionic-native/ionic-webview

To date it still does not work in ionic 4, in console the following errors come out after doing
npm i -S @ionic-native/ionic-webview

ERROR in ./node_modules/ionic-image-loader/dist/image-loader.module.js
Module not found: Error: Can't resolve 'ionic-angular' in 'C:\wamp64\www\folder\node_modules\ionic-image-loader\dist'

ERROR in ./node_modules/ionic-image-loader/dist/providers/image-loader.js
Module not found: Error: Can't resolve 'ionic-angular' in C:\wamp64\www\folder\node_modules\ionic-image-loader\dist\providers'

ERROR in ./node_modules/ionic-image-loader/dist/providers/image-loader.js
Module not found: Error: Can't resolve 'rxjs/observable/fromEvent' in  'C:\wamp64\www\folder\node_modules\ionic-image-loader\dist\providers'

ionic-angular has changed to @ionic/angular in version 4 but this package still use old version, any help?
I tried to edit files myself but it didn't work and also another issue was if this packages gets update all my edits would be re-write.
Ideas?

ionic-angular has changed to @ionic/angular in version 4 but this package still use old version, any help?
I tried to edit files myself but it didn't work and also another issue was if this packages gets update all my edits would be re-write.
Ideas?

Did you find the solution?

ionic-angular has changed to @ionic/angular in version 4 but this package still use old version, any help?
I tried to edit files myself but it didn't work and also another issue was if this packages gets update all my edits would be re-write.
Ideas?

Did you find the solution?

I found one which worked for me here https://github.com/zyra/ionic-image-loader/issues/209#issuecomment-525661515


Sticky Top Bar data-options: small-up, medium-up, etc

The data-options for Sticky top bars don't seem to fit with how Foundation's visibility classes are structured. You can only declare the following
data-options="sticky_on: small" sticky only on small screens
data-options="sticky_on: medium"  sticky only on medium screens
data-options="sticky_on: large" sticky only on large screens
I don't see a method to implement a sticky nav that works both on medium and large screens, or medium and up, etc.
Adoption of -up to these options would help with this function. Here's my bloated fix to foundation.topbar.js is_sticky function. It adds
data-options="sticky_on: small-up" same as all
data-options="sticky_on: medium-up"  sticky on medium and larger screens
data-options="sticky_on: large-up" sticky on large and up screens
is_sticky: function (topbar, topbarContainer, settings) {
	var sticky = topbarContainer.hasClass(settings.sticky_class);

	if (sticky && settings.sticky_on === 'all' || sticky && settings.sticky_on === 'small-up') {
		return true;
	} else if (sticky && this.small() && settings.sticky_on === 'small') {
		return (matchMedia(Foundation.media_queries.small).matches && !matchMedia(Foundation.media_queries.medium).matches &&
				!matchMedia(Foundation.media_queries.large).matches);
		//return true;
	} else if (sticky && this.medium() && settings.sticky_on === 'medium') {
		return (matchMedia(Foundation.media_queries.small).matches && matchMedia(Foundation.media_queries.medium).matches &&
				!matchMedia(Foundation.media_queries.large).matches);
		//return true;
	} else if(sticky && this.large() && settings.sticky_on === 'large') {
		return (matchMedia(Foundation.media_queries.small).matches && matchMedia(Foundation.media_queries.medium).matches &&
				matchMedia(Foundation.media_queries.large).matches);
		//return true;
	} else if(sticky && settings.sticky_on === 'medium-up') {
		if(this.medium() || this.large()) {
			return (matchMedia(Foundation.media_queries.small).matches && matchMedia(Foundation.media_queries.medium).matches &&
					matchMedia(Foundation.media_queries.large).matches);
		}
	} else if(sticky && settings.sticky_on === 'large-up' && this.large()) {
			return (matchMedia(Foundation.media_queries.small).matches && matchMedia(Foundation.media_queries.medium).matches &&
					matchMedia(Foundation.media_queries.large).matches);
	}
	return false;
},

Thanks @Lynesth! I did a tiny bit of refactoring and added it into the code base and updated the docs. :)


Add a Span variant with line and column information

This is more of a feature request than a bug, so feel free to dismiss it!
I'm just starting my migration from nom to chumsky and although there was a bit of a learning curve at the start, I'm loving it so far <3.
That being said, something that I'm missing is how the helper crate nom_locate offered a way to obtain the line and column of a given input span, which is quite useful when generating diagnostics for editors that require such information. I know that computing those from the source string and the offsets isn't too hard, but I'm afraid that would result in a bunch of repetitive computations that could be more easily (?) implemented by the parsers.

@zesterer thanks a lot for your response! I had no idea about the source_span crate and it looks exactly what I need. Thanks again for the suggestion and the amazing project 😻

I'll close this now ☺


nbdev_test_nbs do not work without a GPU

I have opened an issue on nbdev https://github.com/fastai/nbdev/issues/199 about this.  Just posting this cross-referenced issue here for visibility.

I don't know if this helps, but the following line in 00_torch_core.ipynb is an example of a test that does not work without GPU available:
test_eq_type(t,(3,(tensor(3).cuda(),tensor(2).cuda())))

I had this issue too when I was trying to make a change to fastai2 in an environment without GPU. It turned out I didn't need the change in the main fastai2 repository, but I also think nbdev should definitely have some sort of flag for the type of hardware available.

Fixed. Use --flags '' to skip GPU and slow tests.


feat: resolution media queries add the x unit as an alias for dppx

css-values-4 adds x as an alias for dppx unit.
x unit support in: Chrome 68+, Edge 79+, Opera 55+, Safari 16+, Firefox 62+
See also:

Chrome: https://chromestatus.com/feature/5150549246738432
Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1460655
Safari(Technology Preview 138): https://trac.webkit.org/changeset/286874/webkit/
MDN docs: https://developer.mozilla.org/en-US/docs/Web/CSS/resolution#browser_compatibility

Thanks!


Add complete content for news.html

This PR adds short blurbs and images for each of the news stories. Thanks to @jnnsmpth for adding the content!

looks good! <3


[Event Request] table 81 "Gen. Journal Line" - OnBeforeSetAmountWithRemainingVendLedgEntry

Describe the request
Hello, can you please add a new event OnBeforeSetAmountWithRemainingVendLedgEntry to table 81 "Gen. Journal Line"?
    local procedure SetAmountWithVendLedgEntry()
    var
       IsHandled: Boolean;
    begin
        OnBeforeSetAmountWithVendLedgEntry(Rec, VendLedgEntry);

        if "Currency Code" <> VendLedgEntry."Currency Code" then
            CheckModifyCurrencyCode("Account Type"::Vendor, VendLedgEntry."Currency Code");
        if Amount = 0 then begin
            VendLedgEntry.CalcFields("Remaining Amount");
            IsHandled := false;
            OnBeforeSetAmountWithRemainingVendLedgEntry(Rec, VendLedgEntry, IsHandled);
            If not IsHandled then

               SetAmountWithRemaining(
                 PaymentToleranceMgt.CheckCalcPmtDiscGenJnlVend(Rec, VendLedgEntry, 0, false),
                 VendLedgEntry."Amount to Apply", VendLedgEntry."Remaining Amount", VendLedgEntry.GetRemainingPmtDiscPossible(Rec."Posting Date"));
        end;
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeSetAmountWithRemainingVendLedgEntry(var GenJournalLine: Record "Gen. Journal Line"; var VendLedgerEntry: Record "Vendor Ledger Entry"; var IsHandled: Boolean)
    begin
    end;

Additional context
In specific cases in germany, the amount is calculated differently.
Internal work item: AB#499136

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 16151.


Failed to find .env file if options are not in correct order

The Problem
I expect that the order of options isn't affecting the execution. These two options should both work the same way.

./node_modules/.bin/env-cmd -r .env-cmdrc -e development --use-shell 'echo "$TEST"'
./node_modules/.bin/env-cmd -r .env-cmdrc --use-shell 'echo "$TEST"' -e development

The position of -e is different

But the second results in the following error while the first one works:
Error: Failed to find .env file at default paths: [./.env,./.env.js,./.env.json]
    at getEnvFile (/<...>/node_modules/env-cmd/dist/get-env-vars.js:58:11)
    at async Object.EnvCmd (/<...>/node_modules/env-cmd/dist/env-cmd.js:39:15)
    at async Object.CLI (/<...>/node_modules/env-cmd/dist/env-cmd.js:19:16)

Why we need -e to be the last option
We are using multiple npm scripts for different environments. For example build:staging and build:prod. To reduce the boilerplate code of repeating everything except the -e option we want to create a general build task without the -e option that can be called in other npm scripts like this: npm run build -e development.

Yeah, this is a bug and actually should be fixed in the latest master. You now have to use -- to separate the command from the env-cmd options. This is a result of updating commander which is used for parsing command line args.


Update logic that splits line items in a buyer order

Curently its splitting based on ShipFromAddressID however that doesn't capture the full story it should actually split based on:
DefaultSupplierID, ShipFromAddressID, and InventoryRecords

It looks like the current code is already splitting on DefaultSupplierID and ShipFromAddressID.  Upon further reflection, I think this is sufficient. If a solution needs inventory records to be taken into account, then they should set ShipFromAddressID to InventoryRecord.AddressID to acommplish this.


Need a way to only update associations.

Hey guys, so I've run into a blocking problem with the current associations implementation - specifically I'm referring to how we're supposed to update models to attach associations.
Currently, I can do the following:
User.update({ id: 1 }, { id: 1, password: '123456' }, ...)

Then I can use the beforeUpdate lifecycle callback to check if(values.password) and hash the new password for storage if it exists in the values to be updated. This works as expected.
A problem exists however, with the way models are updated when an association is changed. Let's say I have a user...
User.findOne(1, function(err, user) {
  user.roles.add(1);
  user.save(cb);
});

Should work no problem right? Not so much. Because we haven't explicitly told Sails exactly which values we're updating, it assumes we're updating everything. The result is that values in my beforeUpdate lifecycle callback now has values.password = the database entry for the user's password. My code then assumes that the password is being changed and rehashes the password.
I don't think the problem here is with my usage of the beforeUpdate lifecycle callback - I think my use case is pretty typical. The problem is that Sails is assuming I'm updating something which I am not.
Is there a workaround which doesn't require me moving the logic out of the lifecycle callback?

I'm curious what pattern is considered kosher for maintaining a hashed password– what did you settle on, @lwansbrough?

@devinivy bcrypt is the most common library - it'll store your password hash and salt together for you.

I meant which waterline pattern.  Currently I'm using beforeValidate and only updating the hash if the set value is plaintext.

Ah, I added a class method User.hashPassword and then an instance method changePassword and added a call to User.hashPassword in beforeCreate then any other calls for password changes will be handled explicitly by a controller.


Feature Request: Draw borders on top

The old version of token factions had the ability to draw the borders on top and change the radius of the borders so you could use them to cover up circular borders on the tokens with faction based ones. Also, with the beveled borders feature, they looked very nice. This feature seems to have been lost in the change over to the new version. I'd like to see it return.

I would love to be able to have faction borders drawn over the token, I'm currently playing with version 0.3.1 of this module which supported this feature, Is there any chance this will work again?

Should be fixed with version 0..4.6 for v11

This has not been fixed. I do not see the option in the settings at all to enable borders on top. If you set a circular border and give it a negative radius, it goes underneath the token and can't be seen at all.


Hey, I use your pytube to download music, but 95% i get this error

urllib.error.HTTPError: HTTP Error 429: Too Many Requests
can we fix this? i am using heroku, i can't change ip or use any browser to use cookies module. Please Help

Have you tried using a time.sleep() between the requests?

Have you tried using a time.sleep() between the requests?

yes. still same problem

Have you tried using a time.sleep() between the requests?

yes. still same problem

https://stackoverflow.com/a/23367215

This is not a problem of PyTube. Services such as Facebook, Twitter or Instagram have a similar approach. Too many requests in a short time and the IP is blocked. The only thing that helps is to hope and wait for the IP address to be released again or you have to change it.

This is not a problem of PyTube. Services such as Facebook, Twitter or Instagram have a similar approach. Too many requests in a short time and the IP is blocked. The only thing that helps is to hope and wait for the IP address to be released again or you have to change it.

But I am using Heroku and changing IP is not possible.

Anyone Help :/

try increasing the sleep time. Maybe that would help

@StarkGang have you tried using a proxy server for your code? To use a proxy with pytube, your code would look something like this:
from pytube import YouTube
from pytube.helpers import install_proxy

vid_id = '2lAe1cqCOXo'
proxy_dict = {
    'http': 'http://your.http.proxy.server.here',
    'https': 'https://your.https.proxy.server.here'
}
install_proxy(proxy_dict)
yt = YouTube('https://youtube.com/watch?v=' + vid_id)

This is likely the only way around this issue if you are unable to change your IP address, as this is not a problem that the pytube library can fix.

Hi, I updated pytube before yesterday, I used it a lot today and yesterday and now it gives me the same error "HTTPError: Too Many Requests"
Always use proxy in the following way (I never had this HTTPError before):
yt = YouTube ('https://youtube.com/watch?v='+v_id,proxies = {' socks5 ':' socks5: //<IP_ADDRESS>: 31567 '})
I have tried with different proxy but none works.
Is there a way to check if pytube is actually using the proxy?

hi @SnoopiACK a while back, somebody else asked about using a socks5 proxy as well. pytube is unable to support socks5 without adding additional dependencies, but you can install the proxy yourself with external libraries. I wrote an example of how to do this in this comment.

@StarkGang have you tried using a proxy server for your code? To use a proxy with pytube, I believe your code would look something like this:
from pytube import YouTube
from pytube.helpers import install_proxy

vid_id = '2lAe1cqCOXo'
proxy_dict = {
    'http': 'http://your.http.proxy.server.here',
    'https': 'https://your.https.proxy.server.here'
}
install_proxy(proxy_dict)
yt = YouTube('https://youtube.com/watch?v=' + vid_id)

This is likely the only way around this issue if you are unable to change your IP address, as this is not a problem that the pytube library can fix.

Thanks but it seems i  can't do it heroku.

I can't help you out then, @StarkGang. This issue isn't something that pytube can fix for you, as the problem is the way that you're using pytube.


888casino

888casino.com and www.888casino.com appear on the unified hosts list (excluding gambling), but this is a regular gambling site and not malware/adware.

Thank you for this Anon @triatic.
You say the domain www.888casino.com because... ? What investigations have you conducted, how did you do it, and what did you find?  And we would believe you why?
Regardless, the domain www.888casino.com comes to us from upstream. You can make your case with Dan Pollock by email at<EMAIL_ADDRESS>Closing.


Improve LogDir configuration

Update the crio command line arguments to accept --log-dir
Improve configuration validation to test the LogDir
Update unit tests for the additional code paths

Codecov Report

Merging #2198 into master will increase coverage by 0.14%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2198      +/-   ##
==========================================
+ Coverage   31.48%   31.62%   +0.14%
==========================================
  Files          76       76
  Lines        6797     6808      +11
==========================================
+ Hits         2140     2153      +13
+ Misses       4535     4534       -1
+ Partials      122      121       -1

LGTM

/test e2e_fedora

/test e2e_rhel

/retest

See #2199

/retest

/retest

/test kata-containers

/retest

/retest

/test e2e_fedora

/test e2e_fedora

/test e2e_rhel
On Fri, Apr 5, 2019 at 3:53 PM OpenShift CI Robot<EMAIL_ADDRESS>wrote:

@saschagrunert https://github.com/saschagrunert: The following test
failed, say /retest to rerun them all:
Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_rhel 6a8845c
https://github.com/cri-o/cri-o/commit/6a8845c36dbb8a701ee735c076d6cdb2b64f8b48
link
https://openshift-gce-devel.appspot.com/build/origin-federated-results/pr-logs/pull/cri-o_cri-o/2198/test_pull_request_crio_e2e_rhel/2574/ /test
e2e_rhel
Full PR test history
https://openshift-gce-devel.appspot.com/pr/cri-o_cri-o/2198. Your PR
dashboard https://openshift-gce-devel.appspot.com/pr/saschagrunert.
Please help us cut down on flakes by linking to
https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests
an open issue https://github.com/cri-o/cri-o/issues?q=is:issue+is:open
when you hit one in your PR.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cri-o/cri-o/pull/2198#issuecomment-480402237, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIqYJy1KxJRWcP18_vdB5pVU_XOUl3Wtks5vd6nTgaJpZM4cVfid
.

/check-dco

Small spelling nits, otherwise LGTM

I rebased on top of the latest master and fixed the mentioned issues. @umohnani8 please have a look again.

/test integration_fedora

I rebased again on top of the latest master and fixed the mentioned issues. PTAL

/test e2e_rhel

LGTM

Man pages for command and crio.conf.5.md?

Man pages for command and crio.conf.5.md?

Yup, I updated the documentation and hope I did not miss anything. PTAL

What about crio.8.md?

What about crio.8.md?

Ah I forgot, it's now updated as well :+1:

LGTM

/test integration_fedora

/lgtm


feat(nexus): finish artifact saver

Fixes WB-15188
Description
Nexus docs: https://weightsandbiases.slack.com/archives/C04MNBGJDBN/p1692678447664909
Upload algorithm docs: https://weightsandbiases.slack.com/archives/C04MNBGJDBN/p1693352398534739
Benchmark: https://weightsandbiases.slack.com/archives/C04MNBGJDBN/p1695764535202659
TODO:

delete staged files
write to cache
S3 multipart upload

Test plan
TBD

What happened here? @dmitryduev @kptkin why did you add a bunch of unrelated changes to my PR?


[New Port Request]

Library name:
Boost fiber (maybe name it boost-fiber[numa] ?)
Library description:
This is the boost-fiber library compiled with some additional flags to support non-uniform memory addressing.
Source repository URL:
https://github.com/boostorg/fiber
Project homepage (if different from the source repository):
Anything else that is useful to know when adding (such as optional features the library may have that should be included):
I've looked at https://github.com/boostorg/fiber/blob/develop/build/Jamfile.v2 . Seems like we need some minor changes in https://github.com/microsoft/vcpkg/blob/master/ports/boost-fiber/portfile.cmake to pass the numa flag, but I don't know how to do it.

https://www.boost.org/doc/libs/1_75_0/libs/fiber/doc/html/fiber/numa.html#:~:text=NUMA support in Boost.Fiber Because only a subset,systems, Boost.Fiber provides only a minimalistic NUMA API.
I think the resulting dynamic library is called libboost_fiber_numa.so . I have a CMakeLists.txt that asks for
find_package (Boost REQUIRED COMPONENTS fiber_numa)

But I can't supply the fiber_numa package with the current vcpkg.


Move integration tests to separate module

Describe the solution you'd like
We'd like to move integration tests from Android tests folder, which rely on external services, to a dedicated SDK project module.
These tests are making network calls to lightwalletd.com, which they shouldn’t do.  (It's fine if we want to write some integration tests and run them occasionally, but they shouldn’t be part of CI, because they're relying on an external service, which makes the tests unreliable and non-deterministic)
Additional context

The new module name can be sdk-integration-test-lib
it can align with these guidelines:

https://developer.android.com/topic/performance/benchmarking/macrobenchmark-overview#setup-macrobenchmark
https://developer.android.com/studio/test/advanced-test-setup#use-separate-test-modules-for-instrumented-tests

Waits for https://github.com/zcash/zcash-android-wallet-sdk/pull/675 to be merged first.


Add production server setup

add Dockerfile
add k8s deployment, service and configmap
Define default environment variables for development and production
Add Makefile for simpler build/deploy workflow

TODO:

[ ] parametrize deploy/ocp-metal-ui.yaml
[ ] improve README (producetion build, repo setup, app deployment)


Change ListProcesses to ListPids

These rpcs only return pids []uint32 so should be named that way in
order to have other rpcs that list Processes such as Exec'd processes.
Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

This is in prep for adding task ids for Tasks and Processes (exec added processes).  It creates a split between a random process in a container and a process placed in the container via task.Exec

LGTM

Codecov Report

Merging #1114 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1114   +/-   ##
=======================================
  Coverage   54.51%   54.51%
=======================================
  Files          16       16
  Lines        1229     1229
=======================================
  Hits          670      670
  Misses        386      386
  Partials      173      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55861c1...e2d5522. Read the comment docs.