New term for deployments: setup_by / pickup_by [REPLACEMENT ISSUE]

The original issue
Id: 7
Title: New term for deployments: setup_by / pickup_by

could not be created.
This is a dummy issue, replacing the original one. It contains everything but the original issue description. In case the gitlab repository is still existing, visit the following link to show the original issue:
TODO

In GitLab by @peterdesmet on Aug 10, 2020, 20:16
changed title from New term for deployments: {-deployed-}_by to New term for deployments: {+setup_by / pickup+}_by

In GitLab by @peterdesmet on Aug 10, 2020, 20:16
changed the description

In GitLab by @peterdesmet on Aug 17, 2020, 16:51
Note, to be GDPR compliant, we use anonymous user_ids for those fields.

In GitLab by @kbubnicki on Aug 28, 2020, 13:35
Same as #6 I would say. Personally, I do not find this information relevant for people re-using a dataset. Probably it is enough to provide a contact to a project admin, dataset curator etc if there are any questions about the methodology etc

In GitLab by @kbubnicki on Aug 28, 2020, 13:36
But if it is about giving credits to field technicians they can be also mentioned in the project-level metadata.

In GitLab by @peterdesmet on Aug 28, 2020, 14:29
@yliefting what is your take on this. Is setup_by/pickup_by important information for an export/data package?

In GitLab by @yliefting on Aug 28, 2020, 15:29
In a way, yes. In agouti, these events are meant to mark the exact beginning and end of your sampling period, which is not always equal to the timestamp of the first and last image. In practice though, they are often close. I'm ok with leaving this out of the standard, as the obvious solution is to correct the deployment start and end timestamps.

In GitLab by @peterdesmet on Aug 28, 2020, 15:35
@yliefting sorry, I think I wasn't clear enough with my field names. By setup_by and pickup_by I mean the person/user who did the deployment setup and deployment pickup. Is that relevant information to include?

In GitLab by @yliefting on Aug 28, 2020, 15:41
Oh, my fault. Yes, I do think that's very relevant information. There could be a bias caused by the person placing or removing the camera for which you'd like to test in your analysis.So we should definitely give people this information.

In GitLab by @kbubnicki on Aug 28, 2020, 16:56
Ok I get your point @yliefting. But I would opt for not making these fields required as not everybody stores this information.

In GitLab by @peterdesmet on Aug 29, 2020, 15:24
Ok, I will indicate this issue community:consensus and add them as non-required terms.

In GitLab by @peterdesmet on Sep 2, 2020, 15:45
assigned to @kbubnicki

In GitLab by @kbubnicki on Sep 2, 2020, 16:59
Ok working on implementing this now and my conclusion is that setup_by should be enough for testing for a potential bias mentioned by @yliefting. I see no real use for the information about who collected a camera - if there was a bias in selecting location or wrong settings then setup_by is enough to test for this. I would remove pickup_by at this stage and if you really think that this is still useful information we can create a separate/new issue and ask the community afterwards. Is this ok for you @yliefting ?

In GitLab by @yliefting on Sep 2, 2020, 17:02
Yes, that's reasonable and okay with me.

In GitLab by @kbubnicki on Sep 3, 2020, 00:41
mentioned in commit 1cf8d960d276ce21e6b3f2f75e918b241f04545d

In GitLab by @kbubnicki on Sep 3, 2020, 00:46
mentioned in merge request !9

In GitLab by @peterdesmet on Sep 4, 2020, 13:31
Implemented (setup_by only) in !9.


incompatible Float64 encoding?

This is only an issue of Float64 and not N0f8.
using ImageCore, TiffImages
img = rand(RGB{Float64}, 64, 64)
TiffImages.save("tmp.tif", img)
img_loadback = TiffImages.load("tmp.tif")

img == img_loadback # true

However, this "tmp.tif" file is not loadable by other image viewers (both macOS and Windows' default image viewer fail to open it).

Can those default image viewers open 64bit floating bit RGBs normally? AFAIK, support for opening those is pretty limited to scientific TIFF readers, i.e. Fiji/ImageJ or Napari.
For example Fiji is capable of opening them with the BioFormats plugin:

And Napari as well:

I see. So this is because our TiffImages format is too advanced?

Yeah, unfortunately simple TIFF readers are quite limited in what datatypes they support. TiffImages.jl supports reading/writing many combinations that are valid TIFFs but other less flexible readers might not support.
That said, I don't support all TIFFs either, but I try to support most common scientific TIFF types.

Curiously, if we wrap the LibTIFF C library, would you like to maintain it as a fallback backend in TiffImages for cases we don't have much time/priority to implement?

I simply don't have the bandwidth to wrap it or really maintain this year. This package serves my needs for processing my microscopy images (particularly with it's advanced mmapping facilities that LibTIFF doesn't have AFAIK).
I haven't gotten too many complaints since ImageIO.jl switched to using TiffImages.jl. Has it been causing problems for you?

Not much for the main functionality stuff. The Jpeg compression stuff comes from the recent GSoC project https://github.com/ashwani-rathee/ExifViewer.jl/issues/5 where thumbnail is a TIFF bytes sequence with JPEG compression.
FYI, I'm working part-time in tongyuan.cc to bring a compatible image processing toolbox to MATLAB and I sometimes find compatibility issues across implementations for edge cases and advanced keyword options.


Add component Utility list

Refer:
https://digitalnsw.github.io/nsw-design-system/components/utility-list/index.html

This was added in 3.14.0


WordCounter/SameDiff upload file size validation

Looks like WordCounter and SameDiff are not checking filesize at the interface level (would be in static/js/same-diffvalidate.js and static/js/wordcounter-validate.js)

WordCounter and SameDiff now enforce filesize limits - this should help with performance issues so that people can't upload ginormous files into the system


Improve thread visibility in AsyncSemaphore

counter variable in AsyncSemaphore is not volatile variable.
but getCounter() method is public, and not synchronized.
getCounter() method is possible access by many thread. (not in now. but may be possible in the future.)
so add volatile keyword to counter variable.
Redisson version
redisson-3.11.5 (latest)

Good point! Fixed


Possible next version API implementation

This PR contains implementation of the next possible release of the library.
Some quicknotes:

API have been cut significantly in order to provide simpler experience in learning and using it.
It is now written in TypeScript and generates type declarations with itself. This means that types wont get stale.
Tests are now done with mocha. There is no big decision behind this. It's just more wide spread so more people are already familiar with it.
More useful errors for different cases.

Right now there are following problems:

New API is based on the idea that you will provide single reducer to createStore. No more way to use combineReducers.
You have to provide initial state to createStore. This is because of types additions. It's no more sufficient to initiate state using defaults as in Redux itself.

The biggest question right now is how to side-step Redux in a clearer way. I believe that Redux here is used more to piggy back on it's existing infrastructure (DevTools) and we should not follow every other convention of it. In my opinion library should reasonably follow Elm.

I'm 💯  on no longer implementing combineReducers, it is my opinion that it's not really a good idea in the first place. In my Elm apps I keep a fairly flat state shape and I've found that works fine in redux as well. There's definitely more of a "remove boilerplate at all costs" ethos in the JS community but I think it's okay to defy that in a sense.
I think it's okay to have to pass in initial state as well. If there ends up being a way around that in the future it'll just be a minor version bump, no big deal.
This looks really good to me, we should start moving toward a release. The only thing I want to insist on is that I want a single effect(() => somePromise) function rather than Effects.fromLazyPromise(). Is it possible to expose the type of the Effects class without actually exposing the class itself? To me the existence of the class specifically is an implementation detail.

i think providing an example combineReducers could be useful, but I think most people should write their own because redux-loop can't really optimize it for a general use case. see this old comment I made. https://github.com/redux-loop/redux-loop/issues/51

Actually I am now thinking that maybe it would make sense to rename createStore to something like createLoopStore so it would be early on flag for people that they are not exactly the same. Any thoughts?
@lukewestby as for Effects.fromLazyPromise to effects I can easily do it. Before it I would like to show you some things to consider.

It feels like it's a bit more clear to see it as class because it do have instance method map.
As far as I remember previously it was common practise in RxJS, ImmutableJS and maybe some other libraries to have similar API.

Actually these were reasons for me to make it this way. I am not sure if we can expose type without class, but will look into it.
I guess the only thing I need to do in order to make a release is to update examples with something. it should one evening of work.

@gyzerok +1 for createLoopStore, it reminds me of a recommendation that dan abramov made for redux-loop to help people who were having trouble getting the order of the enhancers correct. If it turns out to be really tough to expose the Effects type without exposing the class then I'm okay with Effects.fromLazyPromise. No point in worrying about names if the work to make them happen introduces unnecessary complexity. This is great! I'm excited to see this moving forward.

@gyzerok i've had a little change of heart about being able to pass in the arguments to the promise creator so deep-equals testing can be done. I think we should keep it, and if people don't want to use it they don't have to. I've been talking to more people and it sounds like this feature is a major draw for them.
You don't have to implement it before we merge this I'll be happy to spend the time on it since I'm the one creating the idea churn, but I just wanted to let you first instead of committing a bunch of changes later on without letting you know why.

@gyzerok do you think once this example is fully working this it's okay to merge?

This looks great! effect.map certainly reads a lot more natural compared to previous Effects.lift. However to second @lukewestby, exposing Effects as class might be a bit two powerful: nothing preventing user doing effect.toPromise() inside a reducer. Furthermore, while in typescript land, static types will ensure reducer actually returns Loop, when used in javascript, people can simply extend Effect class or fake effect object entirely. Previously getEffect, isLoop etc uses Symbols to detect and extract effect from loop, and the symbol is entirely private to the library, and I am confident a value will never be treated as an effect without calling Effects.* apis. Now getEffect is simply ret.effects, which a rougue reducer could easily fake.
I am not saying class based api is bad, in fact, be able to extend Effects could allow a lot of neat tricks - just it does have more potiential for weird or unexpected corner cases.
Another comparision with<EMAIL_ADDRESS>seems with new api, it's very difficult to replicate Effects.batch. I do a lot of things like:
loop(state,
Effects.batch([
  Effects.promise(fetchData),
  Effects.constant(releaseLoadingLock())
]));

Relying on batch's Promise.all behavior.
With new api, the following code does something quite different:
return {
  state,
  effects : [
    Effect.fromLazyPromise(fetchData),
    Effect.fromLazyPromise(() => Promise.resolve(releaseLoadingLock())
  ]
}

To achieve the batch / Promise.all behavior, it seems something like this is needed - specifically a new action type on redux side to handle an list of actions:
return {
  state,
  effects : Effects.fromLazyPromise(() => {
    return Promise.all([fetchData], Promise.resolve(releaseLoadingLock())
      .then([action1, action2] => ({ type: BATCH_ACTION, payload: [action1, action2] });
  })
}

The reason is new api diretly passes dispatch / enhancedDispatch to effect's promise callback, i.e.:
effect.toPromise().then(enhancedDispatch)

In<EMAIL_ADDRESS>I believe, each effect resolves to an array of actions when converted to promise.
Another appoach with new api:
// helper function to ensure a promise returning function gets called
// only once, same thing as lodash.once
function cachePromise(lazyPromiseFn) {
  let cached = null;
  return () => {
    if (!cached) {
      cached = lazyPromiseFn();
    }
    return cached;
  };
}
// inside reducer
const fetchEff = Effects.fromLazyPromise(cachePromise(fetchData));
return {
  state,
  effects: [
    fetchEff,
    fetchEff.map(() => releaseLoadingLock())
  ]
}

Caching of promise factory is required to avoid running the same effectual code twice. This solution is better than requiring specific redux batch action type - but it's also non-obvious. I guess a more principled approach would be:
class EffectsOnce extends Effects {
  constructor(promiseCreator) {
    this._promiseCreator = once(promiseCreator);
  }
}

Which goes back to my previous comments on exposing Effects class: greater responsibility but also greater power :)

@lukewestby yes, I guess we can merge it even earlier. Example is nice for the final release of course, but nobody stops us to make a pre-release, so at least some people will try the thing and give us feedback.
Hello @yiransheng and thanks for your feedback!

exposing Effects as class might be a bit too powerful: nothing preventing user doing effect.toPromise() inside a reducer. Furthermore, while in typescript land, static types will ensure reducer actually returns Loop, when used in javascript, people can simply extend Effect class or fake effect object entirely. Previously getEffect, isLoop etc uses Symbols to detect and extract effect from loop, and the symbol is entirely private to the library, and I am confident a value will never be treated as an effect without calling Effects.* apis. Now getEffect is simply ret.effects, which a rougue reducer could easily fake.

It's JavaScript! You can see and fake easily everything 😄  With the previous API it was possible as well. After all effect was just an object and symbol was it's property. So you can create this object, read symbol from it and bam you can fake effects. You was able to extend them as well by creating new objects manually with same property names and changing implementation.
Also after all I expect people who come to use this library to have certain level of understanding why they want to use it.

Another comparision with<EMAIL_ADDRESS>seems with new api, it's very difficult to replicate Effects.batch. I do a lot of things like:

loop(state,
Effects.batch([
  Effects.promise(fetchData),
 Effects.constant(releaseLoadingLock())
]));

Relying on batch's Promise.all behavior.

With new api, the following code does something quite different:

I believe you shouldn't rely on implementation details behaviour at any point. Promise.all was probably used to reduce number of rerenders. It was purely optimisation technique. Correct me @lukewestby  if I am wrong. On the other hand it has it's own drowbacks. No you have to wait until the slowest effects get resolved to be able to dispatch all of them.
In your example you should not create two effects immediately, but instead when you recieve actio
switch (action) {
  case SOMETHING_HAPPEND:
    return {
      state: // something
      effects: [Effect.fromLazyPromise(fetchData)] // this produce message DATA_FETCHED
    }
  case DATA_FETCHED:
    return {
      state: // something
      effects: [Effect.fromLazyPromise(() => Promise.resolve(releaseLoadingLock())]
    }
}

Thanks @gyzerok for the reply. While in general I agree effects should be small and specialized, I do think Effects.batch is useful. Even if the library does not support it natively (requiring built-in Promiss.all somewhere), I think it should be made eazy to implement on top of redux-loop. As I pointed out, this is actually feasible with new api. I'd like to add some more thoughts here on the differences between old and new apis, and some quite notes on how to use new api in a backward compatible way.
@lukewestby can probably explain this much better. Currently redux loop Effects always resolve to a list of actions. Effects from promise factories have the resolved value automatically wrapped in an array of a single action:
Effects.none() -> Promise.resolve([]);
Effects.constant(action) -> Promise.resolve([action]);
Effects.promise(factory) -> factory().then(action => [action]);
Effects.batch(effects) -> Promise.all(effects.map(effectToPromise)).then(flatten)

I think this behavior while subtle, outlines a key difference between old and new apis. Previously, a reducer returns a state and a single effect, marking Effects.batch an essential piece of combining effects. With new api, we are returning a list of effects - and there's no syncrounization on these effects at the library level, any effect's action is dispatched as soon as they are complete. Based on my understanding here's a mapping between old concepts and new ones:
Effects.none() -> { state, effects: [] }
Effects.constant(action) ->
  { state, effects: [Effects.fromLazyPromise(() => promise.resolve(action))] }
Effects.promise(factory) -> { state, effects: [Effects.fromLazyPromise(factory)] }
Effects.batch(effects) -> /* a bit more involved */

With this in mind, a compatibility layer can be established:
// redux-loop-compat.js

export function loop(state, effects) {
  if (!Array.isArray(effects)) {
    effects = [effects];
  }
  return { state, effects };
}

// all apis return an single effect or an array of effects
const EffectsApi = {
  none : () => [],
  constant : (action) => Effects.fromLazyPromise(() => Promise.resolve(action)),
  promise : (factory, ...args) => Effects.fromLazyPromise(() => factory(...args)),
  lift : (effect, factory) => effect.map(factory),
  batch: (effects) => {
    const factoryForAll = once(() => {
      const promises = effects.map(e => e.toPromise());
      return Promise.all(promises);
    });
    const batchEff = Effects.fromLazyPromise(factoryForAll);
    // returns an array of effects
    return effects.map((_, i) => batchEff.map(actions => actions[i]));
  }
};
export { EffectsApi as Effects };

Then in an existing code base, just needs to change import statements, deprecate all Effects.call usages.
import {loop, Effects} from "redux-loop-compat";

// old reducer code remains the same
// new reducers can adopt new api

@gyzerok i have some time today so i'm gonna merge this and keep working on things

@lukewestby ok, thanks! Sorry for a bit of an off time, have some release to be done soon :(


Postgres 10.0 version could not be determined

When running this against postgres 10.0 the following warning is logged:
level=warning msg="Proceeding with outdated query maps, as the Postgres version could not be determined: Error parsing version string: Could not find a postgres version in
string: PostgreSQL 10.0, compiled by Visual C++ build 1800, 64-bit\n" source="postgres_exporter.go:984"

Instead of using a regular expression (which expects to find a full 3 digit version, instead of just two) and the SELECT version(); statement why aren't you using the show server_version (which returns 10.0) statement instead?

https://github.com/wrouesnel/postgres_exporter/pull/112 contains a fix for this


Trying to get an idea about where the algorithm is flexible

If you don't mind me poking around a bit more :)
This is mostly based off of your description, though I checked out some relevant parts of the code.
Clustering/grid
This seems to me the most interesting part. Typically, compression algorithms aim to partition the input into chunks of uncorrelated data, to use a set of parameters tailored for each individual chunck.
In this regard, this looks much more sophisticated than what's usually done, namely slicing the image up into a grid (which you also do as the next step). Would it be possible to get some sort of estimate for how much storage the clustering metadata demands? (an x times y grid, for instance, only has two numbers worth of overhead).
From what I understand, your approach is not limited to a specific algorithm for deciding on the clusters for unique decodability. This should mean that there's the option for asymmetric encoding, where the decoder is computationally inexpensive in that it just has to decode only the single layout you ended up with, while the encoder is free to try multiple different approaches.
Calculating Lists

Every cluster has a minimum pixel value. This value is according to the minimum R, G, B value in that chunk. The resulting pixel value is an addition of this chunk value and the encoded pixel value.

It seems to me, you are using a very simple predictive coding approach here. The "predictor" is a single value for each chunck/cluster.
This would give you very few of the benefits the cluster decorrelation potentially gives. Zstd should be able to explot much of the redundancy of neighbouring pixels in your list, but the 2D correlation is somewhat wasted.
While I'm not sure what the geometry of your "wiggly lines", an analogue technique for scanline traversal would be to store each pixel value as the difference from the pixel above, which would otherwise be far away in the list, and out of reach for the entropy coding.

To illustrate my point, here is a very simple scheme:

Read image as raw RGB bytes.
Traverse the image in scanline order, storing each R, G and B value as the difference from the line above.
Compress this with zstd.

Using a best-worse file size graph again, this very simple predictor has considerably better performance than just using zstd directly.
My suggestion: You should look into using a spatial predictor, even a very simple one, in your "calculating lists" step.
With your advanced partitioning, you will likely also have some gains by selecting a different predictor for each cluster.

To illustrate my point, here is a very simple scheme:

Read image as raw RGB bytes.
Traverse the image in scanline order, storing each R, G and B value as the difference from the line above.
Compress this with zstd.

Using a best-worse file size graph again, this very simple predictor has considerably better performance than just using zstd directly.
My suggestion: You should look into using a spatial predictor, even a very simple one, in your "calculating lists" step.
With your advanced partitioning, you will likely also have some gains by selecting a different predictor for each cluster.

Have you already implemented this method or what's the source of your graph?

Have you already implemented this method or what's the source of your graph?

This idea of yours is pretty good and I'm confident that it will improve the system significantly. However it will take me a long time to implement. Here is why:
As you have seen Rust is static typed. This is the issue. Your proposal would require the use of signed 8-bit integers instead of unsigned 8-bit integers, that I'm currently using. This is important, because if we calculate lists in relation to the previous line it's possible, that we have a decrease in one or multiple of the RGB values. This decrease requires signed integers. This is, again, probably not an issue. The refactor is just immense.

This idea of yours is pretty good and I'm confident that it will improve the system significantly. However it will take me a long time to implement. Here is why:
As you have seen Rust is static typed. This is the issue. Your proposal would require the use of signed 8-bit integers instead of unsigned 8-bit integers, that I'm currently using. This is important, because if we calculate lists in relation to the previous line it's possible, that we have a decrease in one or multiple of the RGB values. This decrease requires signed integers. This is, again, probably not an issue. The refactor is just immense.

Yes, I implemented this transform to make the graph.
You can probably get away without using signed integers by storing the diffs with an offset of 128:
RED1 - RED2 potentially has a range of -255 to 255. However, we can notice that a diff of 128 is equivalent to a diff of -128, a diff of 129 equivalent to -127, and so on.
The real range is then -128 to 127. If you store that +128, you have the range 0-255, which should fit in an unsigned integer.

Yes, I implemented this transform to make the graph.
You can probably get away without using signed integers by storing the diffs with an offset of 128:
RED1 - RED2 potentially has a range of -255 to 255. However, we can notice that a diff of 128 is equivalent to a diff of -128, a diff of 129 equivalent to -127, and so on.
The real range is then -128 to 127. If you store that +128, you have the range 0-255, which should fit in an unsigned integer.

Could you upload the the implementation to your fork and make a pull request. If the system passes all tests we can use it directly.
Otherwise, I will implement it.

Could you upload the the implementation to your fork and make a pull request. If the system passes all tests we can use it directly.
Otherwise, I will implement it.

I wrote this as a separate c++ program, sadly.
It's probably also highly dependent on how your "wiggly lines" work, as I just used a simple scanline approach.

I wrote this as a separate c++ program, sadly.
It's probably also highly dependent on how your "wiggly lines" work, as I just used a simple scanline approach.

I'm working on it. Can't make any promises though. I've been trying to implement it for the last hour. The hole encoder and decoder is pretty bad organized and coded. It's also very hard to debug, because you never know where the error is. Could be in the encoder or the decoder.
How did you write your C++ Code? Did you rewrite the hole algorithm? Maybe I don't quite get yet what your plan is.
I'm graduating in several weeks from high school so I have only two weeks max to bring the code into a reasonable state.
Nevertheless I highly appreciate your contributions.

I'm working on it. Can't make any promises though. I've been trying to implement it for the last hour. The hole encoder and decoder is pretty bad organized and coded. It's also very hard to debug, because you never know where the error is. Could be in the encoder or the decoder.
How did you write your C++ Code? Did you rewrite the hole algorithm? Maybe I don't quite get yet what your plan is.
I'm graduating in several weeks from high school so I have only two weeks max to bring the code into a reasonable state.
Nevertheless I highly appreciate your contributions.


Fix #794, Add msg stubs and update SB UT

Describe the contribution
Fix #794 - Add msg stubs, update SB UT to use them, and remove msg module include from unit tests
Testing performed
Standard build with unit tests enabled, passed.
Expected behavior changes
UTs will now use msg stubs.
System(s) tested on

Hardware: cFS Dev Server
OS: Ubuntu 18.04
Versions: bundle + #726 + this change

Additional context
Depends on #726
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

Ping @excaliburtb

Force pushed removal of old header.

Need to remove old storage structure.

CCB 2020-08-19 APPROVED

Rebased and squashed.


is there 'enum' type for columns?

Question:
is there 'enum' type for columns?
i did not find Enum type for columns and try to write my own function for sorting such columns with  sortFn but it does not work or me!

I'm not sure what you are actually asking for. there is no enum type in JavaScript. So you are forcing me to assume that you are referring to the concept of enumeration, which is extremely vague. If you read the wikipedia article for it, you will find that what you think of as "enumeration" is just an arbitrary set of restrictions chosen by a programming language. These restrictions vary greatly from language to language, basically making the term pointless if in regards to a language that has not defined it's own meaning of what an enum is.

https://en.wikipedia.org/wiki/Enumerated_type

Can you remove the word enum from your request, and instead, describe with detail and specificity exactly what feature you are requesting?

closing.


No sourcemaps for component styles (inline)

Bug Report or Feature Request (mark with an x)
- [X] bug report
- [ ] feature request

Versions.
v1.3.0-rc.3
Repro steps.
Add a style to app.component.scss. E.g. h1 { color: red; }. Compile (ng start / build) with --sourcemap true.
The styles will have no sourcemaps:
<style>h1[_ngcontent-c0] {
  color: red; }</style>

Desired functionality.
--sourcemap true should generate sourcemaps for component's styles, too.

This is actually something that needs to be implemented in Angular itself. See https://github.com/angular/angular/pull/14175 for more information.

Closed 6 month ago but not in any release? :(

Check the last comment in that issue: https://github.com/angular/angular/pull/14175#issuecomment-294876457


Fix old reference to TermApp::Command

#7796 and #7667 were being implemented concurrently. As a part of #7667, Command was moved from TermApp to TSM. This just applies that change to a line we missed in #7796 and fixes the build break.

@msftbot merge this in 5 minutes


Doesn't compile on Rasbian 10

AOM doesn't compile on Rasbian 10 Buster on a Raspberry Pi 4. I fixed by adding -DCMAKE_C_FLAGS="-mfloat-abi=hard -march=armv7-a -marm -mfpu=neon" to the build flags

Unfortunately, I don't have a Pi here for testing. I'll try to fix it blindly.

A possible fix has been implemented via bcd2e075050e963fd8f370aafde8c85f375e2096


The wrong tag

Taiwan is a part of China, and should not be displayed as separate parts,please modify

thx @rastapasta


[WIP] Add child retirement task methods

The service retirement needs tasks and requests for each child item and this is the creation of those. It's WIP'd cause there's a question about the source id.

@miq-bot add_label enhancement

@tinaafitz could you review please

@bdunne any chance you could 👀 on this for me please?


Update to google-cloud-datastore 0.11.2-beta. Code formating

@Mistic92 - thanks for this Pull Request. I've merged the relevant changes (EntityManagerFactory) from this and will check in the changes.


add alibaba aloud Serverless Workflow logo & Serverless Application Engine logo

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~15 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Build failed because of:
Integration tests have failed for unclear reasons. Please run locally for more info and/or ask for help on #landscapers-help on slack.cncf.io

Build failed because of:
No cached entry, and Alibaba Cloud Serverless App Engine has issues with logo: alibaba-sae.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/alibaba-sae.svg'

Deploy preview for landscape failed.
Built with commit 465a36688fe0c2839d56e984fe2ec431053bdf56
https://app.netlify.com/sites/landscape/deploys/5fc5b3f5c91b7e00082275c8

Build failed because of:
Integration tests have failed for unclear reasons. Please run locally for more info and/or ask for help on #landscapers-help on slack.cncf.io

Deploy preview for landscape failed.
Built with commit 16c9a3361268fd88ecd4afcc167d8a63f07b52b5
https://app.netlify.com/sites/landscape/deploys/5fc5b048c781ff00073f19ab

LSTM


Oxygen production issue.

The oxygen produced isn't counted towards the colonies oxygen creation which leads to the game always saying you produce 0 oxygen on the daily reports.
Most likely linked to missing information on the electroylzer itself
http://prntscr.com/pp7088
vs the advanced
http://prntscr.com/pp70lb

Should be fixed


How should I pull changes from here everytime there's an update?

I'm not sure if I'm posting in the right place about this, sorry! I've cloned this into my themes folder and started creating a site. I'm a bit unsure on how to pull recent changes and how often. I was hoping to get your advice on this.
I see changes being made frequently but if I were to pull these changes every so often, isn't it going to override my changes? I've run a pull and it gives me  "Your local changes to the following files would be overwritten by merge". I'm not sure if I should of downloaded a zip file of this into my themes folder and then pushed that onto my own git repository. So when I push my changes there being saved into my own repository. But then how do I pull your recent updates.
I guess I'm a bit lost on the how-to on pushing my changes and at the same time pulling your changes from FoundationPress. Sorry if it's not making sense, I hope it comes out clear. I guess I'm used to working with a Child Theme where I make my changes and the Parent theme is the one always getting updated so I don't have overwriting issues.
I was just hoping for your advice and guidance! Thank you!

@SebRiemelt there's no great way of doing this. I would recommend creating a new foundationpress-updates branch on your local repo and pull the upstream changes. Then go through each merge conflict and resolve them. Make sure everything works, and then merge the local foundationporess-updates branch into your local master branch.
Starter themes like FoundationPress aren't meant to be used as parent/child themes. They're a base to build a custom theme from, so updating them is trickier.

@olefredrik we should probably add a section about this to the README. Can we please create a Documentation label and add it to this issue? Thanks!

@colin-marshall thanks for getting back! So would it be ok to clone once without pulling more update? In other words I can clone once, pull no updates, built my theme and put it live. I want to do this, but I was worried that with my theme built and then being live would be a problem if the recent changes aren't added to it.
Thank you so much! Sorry if it's not clear, I'm new to WordPress but love Foundation. Thank you!

You will not experience any problems if we update FoundationPress and you have already built your theme and made it live. There are times when we update FoundationPress in order to fix breaking changes that may happen with WordPress core updates, but these are very rare. If your theme is functioning as it should, it's probably best to just leave it alone. If you experience issues, look through the changelog of this repo in the Releases section for something related to your problem or search the issues.

Sorry for jumping in on this conversation, but I've been using FoundtionPress for years and ran into an issue where I need to update it.  Recently, I tried to pull down a website that I worked on years ago onto a new machine so I can make some updates, but I can no longer run npm install on that project.  It's using version 1.3.0 with Foundation 5 (back when FoundationPress used grunt, etc).
For example, when I try to run npm install, I get this error:

Cannot download "https://github.com/sass/node-sass/releases/download/v3.2.0/darwin-x64-46_binding.node": HTTP error 404 Not Found

That URL is now gone.  It's apparent that I need to update this old FoundationPress 5 site somehow, because I can no longer run it to produce node_modules files correctly so I can generated the CSS, JS, and other files.
How do I fix this problem?  I'm usually a DIY guy when it comes to things like this, but I've not found anything yet on this problem and I'm hoping someone can point me in the right direction.  Thanks.

Did you try to change your node version? (use nvm for that). I have a lot of "older" installation and I'm able to use them with older version od node. Sometime it's time consuming when you have to try every Node version before finding the one working (when you find it, put the version number in a .nvmrc file).
Note that I do not "re-install", I'm just finding the Node version that works with my old install.

@saintcloud in addition to what @dantahoua recommended, you can bump up the version #'s for outdated packages in package.json. Also, if you go to the link below, from version 3.4.2 forward on the node-sass releases page shows you which versions of Node each release of node-sass is compatible with.
https://github.com/sass/node-sass/releases?after=v3.9.1

@dantahoua @colin-marshall   Thanks to both of you!  I first tried finding a version of node that would work.  As I mentioned, I'm on a completely new machine and I don't know what the original node version was and didn't have the experience to record the node version.  After not having success with a couple older versions of node, I instead tried bumping the node-sass version and it worked just fine.  I'm back up and running.  Thanks again!


Updates the 'webpack' task, removing the use of the --colors arg when…

Purpose
Removes the --colors argument from the webpack task, avoiding an interaction with the terminal environment that causes a development build to fail with:

UnicodeEncodeError: 'ascii' codec can't encode characters in position 18-20: ordinal not in range(128)

Color output will not be emitted by the webpack task in a development environment.  Builds are a bit more dreary, but won't fail when executed from a Docker container.
Changes
Updates the webpack to be invoked with --progress no matter the environment (development or production).
Side effects
The webpack task will be invoked with --progress, even in a development build.
Ticket
Proposed fix for issue #5739.

Thanks @emetsger . Looks like a good change; we certainly don't want webpack builds failing just to support colors.
That said, it's nice to have colors in environments that support it; it makes errors very obvious while developing. Maybe we add a color parameter to the invoke task that defaults to False?

Maybe we add a color parameter to the invoke task that defaults to False?

+1
That sounds great!

Added the --colors argument in https://github.com/CenterForOpenScience/osf.io/commit/587283336b460140fd93d76e3c867a26b8aa5f8a . Thanks for the PR.

Thanks @sloria!


Results->Timeline: Horizontal scrollbar positioning

Is your feature request related to a problem? Please describe.
The horizontal scrollbar is at the bottom making it very iffy to use when checking the rotation as the most important rows are at the top.
Describe the solution you'd like
Put the horizontal scrollbar at the bottom of the currently visible portion of the table as kind of a HUD, make it visually part of the website below the table instead of part of the table or move it when it is being scrolled up/down so that it is allways visible/usable.
Describe alternatives you've considered
Just put the horizontal scrollbar at the top, if my wished solution is too annoying/complicated to do.
Additional context

A solution to this is holding Shift while scrolling (this will make your mouse scroll wheel do trigger the horizontal scroll instead of the vertical one)

Oh, i didnt know that was possible, sorry. My request might be irrelevant then. Unless you wanna implement it for other users who might not know this either. I cant assess if that would be worth the work.

Your request is still relevant so I would leave it open if someone wants to tackle it 👍

I looked into this a bit and because of the way scrolling content works on webpages we can't preserve the "stuck" labels on the left hand side with a fixed size container with scrolling overflow. You can only get the horizontal scrollbar on the outer container which makes you lose the labels. I could do some funky stuff to force it but I have to put a background on the labels to obscure the timeline as it passes over like in the SS below.

We could also add a note that says something like "Hold shift to scroll timeline horizontally"

Hey @KryptixGG I ended up adding two things:

You can now click and drag the timeline to scroll it, and
I added a note about being able to click and drag, as well as holding Shift+scrolling

Hopefully it'll be a bit easier to navigate the timeline going forward!


Link to explorer doesn't work

When I click on the link to take me to the explorer.

I get a 404 error in the explorer.

That's a misspelled URL.
wrong: http://explorer-0.10.0.x-01.symboldev.network/account/...
correct: http://explorer-0.10.0.x-01.symboldev.network/accounts/...
Similarly, Hash and Inner Transaction Hash in Details about a transaction
wrong: http://explorer-0.10.0.x-01.symboldev.network/transaction/...
correct: http://explorer-0.10.0.x-01.symboldev.network/transactions/...

Fixed


Update date sidebar to support vertical and horizontal layouts.

Add support for setting the layout/orientation of the date in the side bar.

Nice! Found a bug! When creating a new date, layout is not visible until "hide none" is clicked

Let me take a look.

Updated if check should be working now.


Missing nullability on some inferred type arguments for collection literals

When the type parameter of the collection literal is inferred as the least upper bound of a type argument and another value, the nullability is undetermined.
This is true for list, set, and map literals.
Here is an example based on the test co19/LanguageFeatures/Set-literals/type_inference_A20_t01.
class C<X> {
  test(X x) {
    var v = {x, 1, 2};
    print(v is Set<Object?>); // should be true
    print(v is Set<int?>); // should be false
  }
}

main() {
  C<int?>().test(42);
  C<int?>().test(null);
}

You can see the undetermined nullability of the inferred type: core::Object%
class C<X extends core::Object? = dynamic> extends core::Object {
  synthetic constructor •() → tes::C<tes::C::X%>
    : super core::Object::•()
    ;
  method test(generic-covariant-impl tes::C::X% x) → dynamic {
    core::Set<core::Object%> v = <core::Object%>{x, 1, 2};
    core::print(v is{ForNonNullableByDefault} core::Set<core::Object?>);
    core::print(v is{ForNonNullableByDefault} core::Set<core::int?>);
  }
}
static method main() → dynamic {
  new tes::C::•<core::int?>().{tes::C::test}(42);
  new tes::C::•<core::int?>().{tes::C::test}(null);
}

@johnniwinther

@stefantsov can you take a look at this?

Note that this could very well be caused by the issue that is targeted in the spec update https://github.com/dart-lang/language/pull/1195 (which is about least upper bounds).

@leafpetersen Please triage

I believe this issue is the cause of these new test failures https://github.com/dart-lang/co19/issues/938.

The spec change has been landed, and there is an implementation issue: https://github.com/dart-lang/sdk/issues/43479.


Secure files that get generated via ansible

https://www.stigviewer.com/stig/rancher_government_solutions_rke2/2022-10-13/finding/V-254564

Currently don't pass the following:

Ensure correct permissions of each file in /var/lib/rancher/rke2/data
cd /var/lib/rancher/rke2/data
ls -l

all owners are root:root
all files are 0640

Ensure correct permissions of /var/lib/rancher/rke2/server
cd /var/lib/rancher/rke2/server
ls -l

The following directories are set to 0750
manifests
logs


sound effects enhancement

A simple enhancement is adding sound effects using AVFoundation. I added 3 basic sound effects, torpedo.mp3 (bullet sound), explosion.mp3 , collison.mp3.
sound effects available:
torpedo.mp3
explosion.mp3
collision.mp3
import AVFoundation
var Player: AVAudioPlayer = AVAudioPlayer()

// added this basic code snippet in three places just change the forResource for each mp3 name.
do
        {
           let MusicURL = Bundle.main.path(forResource: "torpedo", ofType: "mp3")
            try Player = AVAudioPlayer(contentsOf: NSURL (fileURLWithPath:MusicURL!) as URL)
            Player.prepareToPlay()
           Player.play()
        }
        catch let error as NSError {
           print(error.description)
       }

1st spot.  after
@IBAction func didTapScreen(_ sender: UITapGestureRecognizer) { // fire bullet in direction camera is facing

2nd spot.  after

 func removeNodeWithAnimation(_ node: SCNNode, explosion: Bool) {

        if explosion {

3rd spot after
 func physicsWorld(_ world: SCNPhysicsWorld, didBegin contact: SCNPhysicsContact) {
        //print("did begin contact", contact.nodeA.physicsBody!.categoryBitMask, contact.nodeB.physicsBody!.categoryBitMask)
        if contact.nodeA.physicsBody?.categoryBitMask == CollisionCategory.ship.rawValue || contact.nodeB.physicsBody?.categoryBitMask == CollisionCategory.ship.rawValue { // this conditional is not required--we've used the bit masks to ensure only one type of collision takes place--will be necessary as soon as more collisions are created/enabled
            do
            {

Thats it!

Sound effects would be cool! Could I ask you to submit a pull request with this included?

@farice
I'm just in the process of downloading Xcode 9 beta 2. Will look at it tomorrow for you.
This is a video of the game with sound effects
video

Very nice! @wave-electron

Merged https://github.com/farice/ARShooter/pull/10


How to go to current month after change month ?

Can anyone help me ?

You need to give me more info on what you are trying to accomplish. If you are trying to go to the selected date, retrieve it and set it using setCurrentDate.

Thank you for your reply . What you reply is what i want.


log_entries on a check_in should include all log entries on the given date for the current account

Forgot this isn't actually important anymore.


Null is not an object error

Trying to use the npm package via npm install in an expo application (running on IOS14)
running any methode from the package gives me the following error:
  "e": [TypeError: null is not an object (evaluating 'BcryptReactNative.default.getSalt')

I am grateful for any ideas?

Hey @JackGlobetrotter, this package contains native code hence is only for projects created with react native cli and expo ejected


Self-hosted JS?

It would be good if HyperScala had an option to use self-hosted JS instead of referring to third-party hosts:

netdna.bootstrapcdn.com
cdnjs.cloudflare.com
code.createjs.com
code.jquery.com

It supports both.  Look at EaselJS for an example of both self-hosted and third-party hosted JS.

Perhaps my descriptiong was not clear. I meant to suggest a flag to load the standard JS libs from self-hosted URL.
For example, in EasleJS module, a link to https://code.createjs.com/easeljs-0.8.0.min.js is hard-coded. Instead, it would be convenient to have a flag which chooses between that and /js/easeljs-0.8.0.min.js.

Yeah, I've considered that, but then that means I have to add yet further bloat to Hyperscala by storing all of those JS dependencies in the project and I'd like to get away from that.

One solution:
Download the JS on the server side at run-time, and then serve it through a local path. The download can happen to an in-memory buffer (with a soft-reference) and subsequent requests can be served directly from the buffer.
A nice enhancement to this would be:
Keep a MD5 checksum in the server, and verify the download before serving it.
If this sounds good in concept, I could attempt implementing it.

Though it might worth considering at some point, this is a really low-priority issue right now.  There are far more important issues I expected you to be tackling in Hyperscala.


Removed unused global declaration

Description
Removed unused global declaration
Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[ ] Bump-up library or tool used for development (does not change the final image)
[ ] CI configuration change
[ ] Konflux configuration change

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.90%. Comparing base (78bd028) to head (9cd5c95).
Report is 24 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1711   +/-   ##
=======================================
  Coverage   94.89%   94.90%
=======================================
  Files          60       60
  Lines        2685     2689    +4
=======================================
+ Hits         2548     2552    +4
  Misses        137      137

Files with missing lines
Coverage Δ

ols/src/rag_index/index_loader.py
92.72% <ø> (ø)

/retest
/approve

/lgtm

/override "ci/prow/e2e-ols-cluster-4-17"


CI: Builds with VS2015

Also updated the spec submodule to latest.

AppVeyor complains:
Building: C:\Program Files (x86)\nodejs\node.exe C:\projects\node-sass\node_modules\pangyp\bin\node-gyp.js rebuild --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.

C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.Cpp.Platform.targets(64,5):
error MSB8020: The build tools for v140 (Platform Toolset = 'v140') cannot be found.
To build using the v140 build tools, please install v140 build tools.
Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Upgrade Solution...". [C:\projects\node-sass\build\src\libsass.vcxproj]

gypBuild failed

npm ERR<EMAIL_ADDRESS>postinstall: `node scripts/build.js`
npm ERR! Exit status

It seems that we would need to switch AppVeyor environments. Will check with my personal account.

Somewhere it was written that now AppVeyor default image has VS2015 installed, but that is only true if we call it directly:
- call "%ProgramFiles(x86)%\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" %platform%

To get VS2015 in PATH, apparently os key needs to be set like https://github.com/sass/libsass/blob/1e60d83/appveyor.yml#L1.


Can't say if this is a issue per say, but is there a way to clear the TimePicker date?

Hey everyone, I was wondering if I could call something like this.refs.timePicker.setTime(null) or something like this to clear the time.
Another approach I've tried was to set the defaultDate as a state variable and change it from my component, but the end result was pretty weird [as attachement].

Does anyone knows if we can clear the time?

There is currently no functionality to clear the TimePicker or DatePicker.
You could add a button and onClick of that clear the value of the TimePicker.
Closing this issue for now as its a use-case based issue and not a bug.

Setting null value to TimePicker doesn't work
https://ajainvivek.github.io/react-aztec/#/timepicker
but works fine for DatePicker
http://localhost:8080/#/datepicker
It looks like a bug


fix: email OTP error codes and docs

This PR includes improvements for the Email OTP plugin:

Consistently return errors with values from ERROR_CODES.
Consistently return OTP_EXPIRED when the OTP has expired.
Add details about password reset via OTP to docs.

It also includes a fix for the 'your first plugin' guide (throw APIError -> throw new APIError).

thanks for the PR!


Github link in Readme quickstart is not working

I tried to install this package following the steps in the Readme document, under Quickstart Unity XR Input, but when I paste the github link in the package manager and press Add I get the error message that there is no git executable was found.

Hi @joostbos - do you have git installed in your machine?
there's some instructions from Unity on how to set this up if you haven't yet:
https://docs.unity3d.com/Manual/upm-git.html
let me know if you have any issues setting it up!
Cheers,
Rune

Hi Rune,
Thanks for the info, this worked (altough I did not get any confirmation that the package was installed, that was confusing).
Can you point me to an explanation on how this works with WebXR? I addied the Tracked Pose Drivers to the WebXRCameraSet, they are tracked, but the hands are not visible (Skinned Mesh Renderer is inactive, when I activate it manually in the editor they are visible). And I get two weird grey planes right in front of the camera.
Thanks.

Hi @joostbos - unfortunately we dont support webxr through this plugin. our understanding is that webxr uses a web stack to talk directly to steamvr and not through our plugin.


Fix all of our invalid format strings

This pull request is required for #2629 to merge.

When you build an application that formats NSInteger as %d on the reference platform, it complains that the format character is invalid and the quickfix is to both change it to %ld and cast NSInteger to unsigned long.
This adeptly handles the bitness/width change of NS(U?)Integer between platforms.

:shipit:

:shipit:

@rasjesh-msft %S question answered by new revision above :)

@rajsesh-msft it appears that without GitHub's user suggestion, I will simply spell your name wrong!


[Core] Remove unnecessary calculation of stage's parents

What changes were proposed in this pull request?
Remove unnecessary calculation of stage's parents, because stage's parents have been set at the time of stage construction.
How was this patch tested?
Make use of the existing test cases

Can one of the admins verify this patch?

https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark

@sharkdtu please file a JIRA and add it to the title. Otherwise let's close this PR.

I think this change is made by another PR #13677. We can close it now.


Missing argparse as a dependency for Python 2.6

We should add argparse as a dependency for python versions prior to 2.7.

This is now released in version 2.1.1.


add vyper spec template

make all
write spec to vyper-spec.ini
add spec_name.k to vyper_files in Makefile
make specs/vyper/spec_name.k.test

Could you ## add how to get started in README?


Frontend: Create Landing Page

User story
Who: As a user
What: I want to see the landing page of webshop where it shows all products
Why: So that I can login, browse products, use menus to navigate.
Acceptance criteria
The page should look like in image below and have all working components included

check wireframe here
https://www.figma.com/file/lMeDy1n608SLjsKYrKu1nc/HYF-WebShop?node-id=2%3A4
Implementation details
Need to include next components:

Menu - issue#8
Hero image - issue#13
Carousel - issue#4
Sorting - issue#11
Pagination - issue#12
Footer - issue#5

Need to use next endpoint:

GET api/products - #37
GET api/categories - #68

Remember to change App.js so that this page component is being rendered when we open the App.

@semih1239 I`m doing the ProductView that willl join Pagination and Sorting for this page #80

@semih1239 I`m doing the ProductView that willl join Pagination and Sorting for this page #80

Okay Julia. Thanks. I am waiting them to merge


TelemetryConfiguration.Dispose should flush the default Channel

I think TelemetryConfiguration.Dispose(bool disposing) should be flushing this.telemetrySinks.DefaultSink.TelemetryChannel before actually disposing. Currently it does not. If this on purpose (please explain why) or an oversight?
Thanks!
P.S. !! I am adding a comment in this respect to the mentioned method. If the resolution of this issue is to leave things as they are, we should remove that coment. :)

Thanks! There are multiple Flush() discussions going on, I think we can consolidate and address those around ~2.8.


Unable to get watch work with etcd backend

Hello,
With watch = true in configuration, it still seems to be pulling from etcd every 10 seconds.
I'd expect it to only have action, if something changes in etcd.
Is my expectation of how watch should perform with confd wrong or is there something I'm missing in configuration ?
I've also tried running confd -watch confd -watch=true, having watch setting in /etc/confd/conf.d/pgbouncer.toml to no avail.
My use case for confd is to reconfigure and reload pgBouncer, when key changes in etcd DCS used by Patroni.
Configuration
/etc/confd/confd.toml
backend = "etcd"

client_cakeys = "/etc/postgresql/ssl/nms-ca.pem"
client_cert = "/etc/postgresql/ssl/nms-vg-pglab-db-01.pem"
client_key = "/etc/postgresql/ssl/nms-vg-pglab-db-01-key.pem"

log-level = "debug"

watch = true

nodes = [
  "https://ms-vg-etcd-01.mnw.no:2379",
  "https://ms-vg-etcd-02.mnw.no:2379",
  "https://ms-vg-etcd-03.mnw.no:2379",
  "https://ms-vg-etcd-04.mnw.no:2379",
  "https://ms-vg-etcd-05.mnw.no:2379",
]

scheme = "https"

/etc/confd/conf.d/pgbouncer.toml
[template]

owner = "postgres"
mode = "0644"
src = "pgbouncer.tmpl"
dest = "/etc/pgbouncer/pgbouncer.ini"

reload_cmd = "systemctl reload pgbouncer"

prefix = "/service/osl1-pglab/"
keys = [
    "/members/","/leader"
]

Starting confd
/opt/confd/bin/confd
Logs
2019-08-24T17:00:54+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: INFO Backend set to etcd
2019-08-24T17:00:54+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: INFO Starting confd
2019-08-24T17:00:54+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: INFO Backend source(s) set to https://ms-vg-etcd-01.mnw.no:2379, https://ms-vg-etcd-02.mnw.no:2379, https://ms-vg-etcd-03.mnw.no:2379, https://ms-vg-etcd-04.mnw.no:2379, https://ms-vg-etcd-05.mnw.no:2379
2019-08-24T17:00:54+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Loading template resources from confdir /etc/confd
2019-08-24T17:00:54+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Found template: /etc/confd/conf.d/pgbouncer.toml
2019-08-24T17:00:54+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Loading template resource from /etc/confd/conf.d/pgbouncer.toml
2019-08-24T17:00:54+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Retrieving keys from store
2019-08-24T17:00:54+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Key prefix set to /service/osl1-pglab/
2019-08-24T17:00:54+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Got the following map from store: map[/service/osl1-pglab/members/nms-vg-pglab-db-01:{"conn_url":"postgres://nms-vg-pglab-db-01.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-01.mnw.no:8008/patroni","timeline":46,"state":"running","role":"replica","xlog_location":452229858456} /service/osl1-pglab/members/nms-vg-pglab-db-02:{"conn_url":"postgres://nms-vg-pglab-db-02.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-02.mnw.no:8008/patroni","timeline":46,"state":"running","role":"master","xlog_location":452229858456} /service/osl1-pglab/leader:nms-vg-pglab-db-02]
2019-08-24T17:00:54+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Using source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:00:54+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Compiling source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:00:54+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Comparing candidate config to /etc/pgbouncer/pgbouncer.ini
2019-08-24T17:00:54+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Target config /etc/pgbouncer/pgbouncer.ini in sync
2019-08-24T17:01:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Retrieving keys from store
2019-08-24T17:01:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Key prefix set to /service/osl1-pglab/
2019-08-24T17:01:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Got the following map from store: map[/service/osl1-pglab/members/nms-vg-pglab-db-01:{"conn_url":"postgres://nms-vg-pglab-db-01.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-01.mnw.no:8008/patroni","timeline":46,"state":"running","role":"replica","xlog_location":452229858456} /service/osl1-pglab/members/nms-vg-pglab-db-02:{"conn_url":"postgres://nms-vg-pglab-db-02.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-02.mnw.no:8008/patroni","timeline":46,"state":"running","role":"master","xlog_location":452229858456} /service/osl1-pglab/leader:nms-vg-pglab-db-02]
2019-08-24T17:01:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Using source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:01:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Compiling source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:01:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Comparing candidate config to /etc/pgbouncer/pgbouncer.ini
2019-08-24T17:01:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Target config /etc/pgbouncer/pgbouncer.ini in sync
2019-08-24T17:01:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Retrieving keys from store
2019-08-24T17:01:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Key prefix set to /service/osl1-pglab/
2019-08-24T17:01:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Got the following map from store: map[/service/osl1-pglab/members/nms-vg-pglab-db-01:{"conn_url":"postgres://nms-vg-pglab-db-01.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-01.mnw.no:8008/patroni","timeline":46,"state":"running","role":"replica","xlog_location":452229858456} /service/osl1-pglab/members/nms-vg-pglab-db-02:{"conn_url":"postgres://nms-vg-pglab-db-02.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-02.mnw.no:8008/patroni","timeline":46,"state":"running","role":"master","xlog_location":452229858456} /service/osl1-pglab/leader:nms-vg-pglab-db-02]
2019-08-24T17:01:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Using source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:01:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Compiling source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:01:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Comparing candidate config to /etc/pgbouncer/pgbouncer.ini
2019-08-24T17:01:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Target config /etc/pgbouncer/pgbouncer.ini in sync
2019-08-24T17:01:10+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Retrieving keys from store
2019-08-24T17:01:10+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Key prefix set to /service/osl1-pglab/
2019-08-24T17:01:10+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Got the following map from store: map[/service/osl1-pglab/members/nms-vg-pglab-db-01:{"conn_url":"postgres://nms-vg-pglab-db-01.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-01.mnw.no:8008/patroni","timeline":46,"state":"running","role":"replica","xlog_location":452229858456} /service/osl1-pglab/members/nms-vg-pglab-db-02:{"conn_url":"postgres://nms-vg-pglab-db-02.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-02.mnw.no:8008/patroni","timeline":46,"state":"running","role":"master","xlog_location":452229858456} /service/osl1-pglab/leader:nms-vg-pglab-db-02]
2019-08-24T17:01:10+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Using source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:01:10+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Compiling source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:01:10+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Comparing candidate config to /etc/pgbouncer/pgbouncer.ini
2019-08-24T17:01:10+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[63917]: DEBUG Target config /etc/pgbouncer/pgbouncer.ini in sync

I was also considering that the trigger that I see every 10 minutes in logs, is related to Patroni writing to DC every 10 seconds..
However, if that is the case, I'd also expect it to trigger when make Patroni change /service/osl1-pglab/leader key, but confd fails to acknowledge it until next 10 second pull has been done.
This is rather important, as when this key changes, the pgBouncer should be reloaded ASAP.

It seems to actually be watching the key changes..
Patroni action, which updates the etcd
2019-08-24 17:25:06.16493 Successfully switched over to "nms-vg-pglab-db-02"
confd logs
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Retrieving keys from store
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Key prefix set to /service/osl1-pglab/
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Got the following map from store: map[/service/osl1-pglab/members/nms-vg-pglab-db-02:{"conn_url":"postgres://nms-vg-pglab-db-02.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-02.mnw.no:8008/patroni","timeline":47,"state":"running","role":"replica","xlog_location":452263419312} /service/osl1-pglab/leader:nms-vg-pglab-db-01 /service/osl1-pglab/members/nms-vg-pglab-db-01:{"conn_url":"postgres://nms-vg-pglab-db-01.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-01.mnw.no:8008/patroni","timeline":47,"state":"running","role":"master","xlog_location":452263419312}]
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Using source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Compiling source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Comparing candidate config to /etc/pgbouncer/pgbouncer.ini
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Target config /etc/pgbouncer/pgbouncer.ini in sync
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Retrieving keys from store
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Key prefix set to /service/osl1-pglab/
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Got the following map from store: map[/service/osl1-pglab/members/nms-vg-pglab-db-01:{"conn_url":"postgres://nms-vg-pglab-db-01.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-01.mnw.no:8008/patroni","timeline":47,"state":"running","role":"master","xlog_location":452263419312} /service/osl1-pglab/members/nms-vg-pglab-db-02:{"conn_url":"postgres://nms-vg-pglab-db-02.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-02.mnw.no:8008/patroni","timeline":47,"state":"running","role":"replica","xlog_location":452263419312} /service/osl1-pglab/leader:nms-vg-pglab-db-01]
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Using source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Compiling source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Comparing candidate config to /etc/pgbouncer/pgbouncer.ini
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Target config /etc/pgbouncer/pgbouncer.ini in sync
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Retrieving keys from store
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Key prefix set to /service/osl1-pglab/
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Got the following map from store: map[/service/osl1-pglab/members/nms-vg-pglab-db-01:{"role":"master","state":"running","conn_url":"postgres://nms-vg-pglab-db-01.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-01.mnw.no:8008/patroni"} /service/osl1-pglab/members/nms-vg-pglab-db-02:{"conn_url":"postgres://nms-vg-pglab-db-02.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-02.mnw.no:8008/patroni","timeline":47,"state":"running","role":"replica","xlog_location":452263419312} /service/osl1-pglab/leader:nms-vg-pglab-db-01]
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Using source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Compiling source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Comparing candidate config to /etc/pgbouncer/pgbouncer.ini
2019-08-24T17:25:00+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Target config /etc/pgbouncer/pgbouncer.ini in sync
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Retrieving keys from store
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Key prefix set to /service/osl1-pglab/
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: ERROR 100: Key not found (/service/osl1-pglab/leader) [1848]
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Retrieving keys from store
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Key prefix set to /service/osl1-pglab/
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Got the following map from store: map[/service/osl1-pglab/members/nms-vg-pglab-db-01:{"role":"demoted","state":"stopped","conn_url":"postgres://nms-vg-pglab-db-01.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-01.mnw.no:8008/patroni"} /service/osl1-pglab/members/nms-vg-pglab-db-02:{"conn_url":"postgres://nms-vg-pglab-db-02.mnw.no:6432/postgres","api_url":"https://nms-vg-pglab-db-02.mnw.no:8008/patroni","timeline":47,"state":"running","role":"replica","xlog_location":452263419312} /service/osl1-pglab/leader:nms-vg-pglab-db-02]
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Using source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Compiling source template /etc/confd/templates/pgbouncer.tmpl
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Comparing candidate config to /etc/pgbouncer/pgbouncer.ini
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: INFO /etc/pgbouncer/pgbouncer.ini has md5sum 678c33aa69ca0d0c0555c9e8157d86d4 should be 97e7923124f1a27db43a494707687ab7
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: INFO Target config /etc/pgbouncer/pgbouncer.ini out of sync
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Overwriting target config /etc/pgbouncer/pgbouncer.ini
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Running systemctl reload pgbouncer
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG ""
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: INFO Target config /etc/pgbouncer/pgbouncer.ini has been updated
2019-08-24T17:25:10+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: DEBUG Retrieving keys from store

Specifically
2019-08-24T17:25:05+02:00 nms-vg-pglab-db-01 /opt/confd/bin/confd[71704]: INFO /etc/pgbouncer/pgbouncer.ini has md5sum 678c33aa69ca0d0c0555c9e8157d86d4 should be 97e7923124f1a27db43a494707687ab7
Which I would not expect to happen at that time.
It seems that everything is in order with confd and the 10 second intervals are indeed the Patroni doing.
Closed. False alarm.


Rename imagenet2012 -> imagenet-1k

On the Hugging Face Hub, users refer to imagenet2012 (from #4178 ) as imagenet-1k in their model tags.
To correctly link models to imagenet, we should rename this dataset imagenet-1k.
Later we can add imagenet-21k as a new dataset if we want.
Once this one is merged we can delete the imagenet2012 dataset repository on the Hub.
EDIT: to complete the rationale on why we should name it imagenet-1k:
If users specifically added the tag imagenet-1k , then it could be for two reasons (not sure which one is predominant), either they

wanted to make it explicit that it’s not 21k -> the distinction is important for the community
or they have been following this convention from other models -> the convention implicitly exists already

Later we can add imagenet-21k as a new dataset if we want.

isn't it what models refer to as imagenet already?

isn't it what models refer to as imagenet already?

I wasn't sure, but it looks like it indeed. Therefore having a dataset imagenet for ImageNet 21k makes sense actually.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

should we remove the repo mirror on the hub side or will you do it?


Update French local with actual words, domains, ans regions

I commited somes changes for French local. I updated some files with acutal informations :)

Bump! Could we please resolve?

I am going to close this PR as stale. If this still needs to be merged, please feel free to reopen it.
Thanks for contributing


[SPARK-43804][PYTHON][TESTS] Test on nested structs support in Pandas UDF

What changes were proposed in this pull request?
Test on nested structs support in Pandas UDF. That support is newly enabled (compared to Spark 3.4).
Why are the changes needed?
Test coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests.

@ueshin @HyukjinKwon @zhengruifeng would you review it please?

Thanks! merging to master.


Suppress Ruby 2.7 kwargs warnings

I've suppressed Ruby 2.7 kwargs warnings.
And I made belongs_to method the same interface to ActiveRecord one,
because it uses "super" inside its implementation.
If this pull request merged, these warnings are going to be suppressed.
/path/to/ruby/2.7.0/gems/active_hash-3.1.0/lib/associations/associations.rb:22: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

:memo: Separation of positional and keyword arguments in Ruby 3.0
https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

@zilkey or other maintainers: Could you review this pull request? In Ruby 2.8 or later, this becomes raise exception instead warnings. Sooner or later, we should fix it. Thanks.

I'll take a look. And thanks! I hate these warnings

this passes on all versions of ruby, and rails 5.0 and above
LGTM


Fix bl resolution for security

Description
Resolve the bl nested dependency to a version without the high security advisory.

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 8e02b0baa3ac9b51f9191a1afab7a7ed81284a3c


How do I unban people from my game? With adonis admin

Alright so someone raided my roblox game now people are banned everytime I try to unban them and then rejoi to check bans are still there and wont stop.

:unban
However unbanning the user wont work half (or most) of the time

:unban
However unbanning the user wont work half (or most) of the time

I have found out how to remove everyone from my bans that was falsely banned by changing the datastore key thank you for your help or with trying to help.

You could try :cleardata and it should unban them that way (however it will also clear any data like aliases, keybinds, and more)

I have found out how to remove everyone from my bans that was falsely banned by changing the datastore key thank you for your help or with trying to help.

Alright

You could try :cleardata and it should unban them that way (however it will also clear any data like aliases, keybinds, and more)

I tried doing that but would not work.


Allow multi-lora in Messages API

Feature request
Multi lora support in TGI has been around since 2.0.6, but it is not compatible with the Messages API using the openai package.
Motivation
The openai chat completion approach is an industry standard at this point, so having it be compatible with multi lora would be great.
Your contribution
.

Hi @nbroad1881 👋
Btw, I noticed there was a conversation on slack regarding this. Was the issue resolved or should we leave this open? 🤗

@drbh is working on a fix

@drbh ,
I can't remember, was this fixed?

I was using the messages API today with version 2.2.0. The lora does seem to get loaded when I set the model to the huggingface lora adapter repo id. The model id in response is still the base model.

@drbh Is it possible to use OpenAI chat completion API, for multi-lora adapters, yet?


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter zigbee2mqtt for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.zigbee2mqtt
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E254] Versions "2.13.9, 2.13.8, 2.13.7" listed at common.news at io-package.json do not exist at NPM. Please remove from news section.

:thumbsup: No warnings found
:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
or
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Thu, 17 Oct 2024 09:12:09 GMT based on commit ada329bf993e3a3e0533f2a230b53099546c4d7f
ioBroker.repochecker 3.1.3

@iobroker-bot recheck


Remove package.json hard paths and add lifecycle stages

never include the path to node_modules/.bin/
Just trust the PATH environ.

https://twitter.com/izs/status/657976995326726144
https://twitter.com/izs/status/657977615228104704

Just cleaning up the package.json scripts a little bit, and added a coupe lifecycle steps where it made sense.

I don't trust the PATH environ :( this has bitten me quite often and failed to work, but lets give it another shot..

Could you please change the commit message to something like chore: Remove package.json hard paths and add lifecycle stages trying to get an automated changelog from the commit messages. See this for details

Sure.

Should be good to go!

Thanks :octocat:

Ugh, i never trust npm to have set $PATH correctly. in my experience, it leads to pain and suffering.

Same here, never worked for me somehow...
On Oct 27, 2015 11:26, "Juan Benet"<EMAIL_ADDRESS>wrote:

Ugh, i never trust npm to have set $PATH correctly. in my experience, it
leads to pain and suffering.
—
Reply to this email directly or view it on GitHub
https://github.com/ipfs/station/pull/70#issuecomment-151445903.

@jbenet I don't either, but izs said on twitter so confident that it should work that I suggest we all start using it and file issues on npm and bug him on twitter until it gets fixed :)

I've never had a problem and it provides a compatibility layer when npm changes how node_modules moves things around.


Implement support for Algorand Wallet via WalletConnect

While there's probably more details needed on top of the basic support, I'll mark this as done.


Add hover effect to "Search Icon Button"

Description
The website has a missing hover effect on the Search Icon button
Expected Behavior
It should show Green circle on hovering the Search Icon Button.

I would like to be assigned to this issue under hacktoberfest and would like to work on it.

Hello! I’m excited to work on this issue as a Hacktoberfest contributor. Could you please assign it to me?


only trigger builds of our own PRs

no not trigger automatic builds of anybodys PR for obvious reason

LGTM - can you test by submitting a PR via another user who is not in either team?

@aspiers I already did, I removed @aplanas from the team (just for a few minutes) and his PRs disappeared.

Excellent, +1 from me then!

:+1: though the .head is still confusing, as if different commits of the PR could come out of different source repos


Is Code upgrade required for existing customers in 8.0, Please specify in the documentation

Could you please specify somewhere in the documentation if Code upgrade is required when moving from 8.0 to 8.1.
LCS code upgrade only shows 7.3 to 8.0

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c3c5b4d1-9ab4-ff33-6a3a-14460998fcd1
Version Independent ID: bfb7d49f-1ab1-542d-62ce-1625a8664bc7
Content: What's new or changed in Dynamics 365 for Finance and Operations version 8.1 (October 2018) - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/fin-and-ops/get-started/whats-new-changed-8-1-October-2018.md
Service: dynamics-ax-platform
GitHub Login: @tonyafehr
Microsoft Alias: tfehr

We'll soon be publishing a topic about updating from 8.0 to 8.1.  I'll let you know when it's available.

For information about how to update environments from 8.0 to 8.1 please see Update environments from version 8.0 to 8.1.


refactor(http): Use macro for ErrorCode variants

Adding a new ErrorCode variant was previously a tedious process due to having to duplicate the display implementation as a rustdoc comment and matching ErrorCode::num()'s output to From<u64>'s input.
To assure this a tests were added (assert_error_code()), this is no longer necessary as the macro correctly handles everything.

Superseded by #1394.


feat: Issuer component enhance get credential endpoint by supporting filters

Description
Enhance the functionality of the existing GET /api/issuer/useCaseParticipation endpoint in the Issuer Component. The enhancement involves the ability to filter the returned list of use case participations by the status of the credentials (Active, Expired, or All).
Why
Better user experience
Checklist
Please delete options that are not relevant.

[x] I have performed a self-review of my own code
[x] I have successfully tested my changes locally
[x] I have added tests that prove my changes work
[x] I have checked that new and existing tests pass locally with my changes
[x] I have commented my code, particularly in hard-to-understand areas

DRAFT PR - no review yet expected
we are currently rechecking the PR once again


[Discussion] DataTransactionResult and CompletableFuture

So, there might be instances, and are instances, where the result of a data transaction ought not to be available immediately. One example of this is with skulls. We should be updating the GameProfile of a skull asynchronously whenever it is set or removed but that is not currently the case. (My latest commit regarding skulls makes updating async for updating from within the base game). I would like to propose that we wrap DataTransactionResult in a CompletableFuture in almost, if not all, methods that return a DataTransactionResult or at any other data processor mutators. This will allow for asynchronous data manipulation.
This would also be a great boon to possible data processors that perform I/O operations.

This seems like a reasonable proposal. However I don't really think it should be the default behavior, plenty of data (in fact most of the data) should be non-asynchronous. It's my view that this should be an additional variety of data with these properties. That might be simply too much work to maintain two distinct systems like that, but using CompletableFuture for an operation does complicate the plugin code, and there's no reason to suggest operations are asynchronous when they are not.

The great thing about CompletableFuture is that it doesn't actually have to be in the future. Non-asynchronous data transactions would just create a new future and call complete(V) on it right away.

Good point, given that there should be no reason we don't switch to CompletableFuture

While it's interesting to note, I'm curious what the implications could mean, since this would allow for theoretical async data access where the completable future just waits to re-sync back to the main thread. Having that said, for the case of skulls, it would be certainly interesting, but at the same time, the asynchronous aspect is probably not going to be well understood, and in the event an async task completes but for example, a TileEntity is no longer present, the task should fail.
The implications to handle processing in such ways would be interesting. I'll have to give this some thought as the implementation plumbing is very reliant on being on the main thread.

@gabizou Could you elaborate on "theoretical async data access"? The only thing that would be running on a different thread here should be the processors themselves and for mutators only. Those mutators would returns a future of a result and a plugin dev could either get() it and block the main thread until completed or handle it which would run a BiConsumer with the result and an exception if failed. It might not be a bad idea to implement our own Future as well to make these definitions a bit more strict as CompleteableFuture allows you to pretty much do whatever you want with the result and thrown exception, disregarding the actual intent of the future.


[WIP] New arrow serialization code

This is based on the new numbuf library, see https://github.com/pcmoritz/numbuf
User visible change:

For large data, users should not run into the protocol buffer limit any more

Serialization of large numerical data nested in python objects is fast now (especially deserialization); this comes up when serializing weight collections for neural networks for example.

Things that need to be done before it can be merges:

[ ] Port Mehrdad's changes to arrow onto the new version
[ ] Fix remaining test failures related to serializing objrefs and strides for NumPy arrays

The old one will get removed of course. It makes sense to have a transition period where both are available in principle ;)

Two reasons:

The new arrow serialization code is not complete. It doesn't serialize object references.
Having both versions could help with debugging. E.g, if we see a problem, we can turn on the old code to see if the bug still happens.

Any chance you could also add Arrow as a submodule as well?

@mehrdadn: I have another PR in the pipeline, where I get rid of the old arrow serialization code. I'll include arrow as a submodule in there!


Fix for crash when deleting via admin site

Problem
I have verified that there is a crash if one tries to delete records using the admin site (see #432).
Solution
The fix is simple - to add instance attributes to the RowResult.
This introduced some code duplication, so I added a minor refactor of RowResult to set attributes via a new method.

I also fixed sort order for conf.py attributes (raised by make lint).
I added the pytz dependency which is needed for testing with python 3.9 (see #1336).
Added test file books-for-delete.csv

Acceptance Criteria

Integration test to prove the issue exists and is fixed (test_admin_integration.py)
Added unit tests for the new RowResult method

Coverage increased (+0.009%) to 98.072% when pulling afdcc2237f257a6961a8c4a4edeaebadbb80434d on matthewhegarty:error-on-delete-from-admin-432 into 97a9232dd779f8fecc79e19616102a99a91553bd on django-import-export:main.


Active link class not getting removed on sub-routes

If a two routes share a similar path, the active link class will be applied to both.
This can be seen in the stencil-site repo.
Here, the active component is the demo page, but both the docs and demo link are marked as "active"

Note, the landing Component's url is / and the demo component is /demo so that shared / is throwing things off. You can also see this as you navigate along the side menu links .

We now have exact={true} as an option.  This allows for some interesting link options.


Class initialization via 'new' fails in precompiled bytecode chunks

pluto: plutoc.out: bad binary format (integer overflow)

local class A
end

new A()

Setting LINE_INJECTED to 0 removes the error and passes the 0.8.0 test suite. (not a valid line number, but still unsigned-compatible :P)
I am curious, why was LINE_INJECTED -1886153070 in the first place?

It's just a magic number, derived from the string 'plin' for "Pluto Injected". This just allows us to differentiate between injected and non-injected code.


raise connection errors from BrokerConnection.connect()

This change may have been ill-conceived, as pointed out in #634 by @smueller18. BrokerConnection.connect() failing to connect to a broker and returning without any indication of that error makes no sense to me - a proper interface for this function would have it raising the appropriate exception upon failure to connect. BrokerConnection.connect() and Broker.connect() should both be changed to raise connection exceptions to their callers, and the callers should be adjusted to expect these exceptions such that issues like #543 don't reoccur.
PyKafka version: https://github.com/Parsely/pykafka/commit/8f4617c42a3508d97d02e05a590e33482bf89b9a

Closed with #636