Constructors for Point and Vector2 belong together

Maybe it's just me, but it seems perplexing that the constructors for Point and Vector2 are not siblings.

Point lives at Phaser.Geom.Point
Vector2 lives at Phaser.Math.Vector2

I would expect Vector2 to live at Phaser.Geom.Vector2.
"Vector" is defined specifically with reference to geometry in both the Phaser documentation and on Wikipedia:

A representation of a vector in 2D space
-- Phaser 3 documentation

Euclidean vector, a geometric object that has magnitude (or length) and direction
-- Wikipedia, on Vector

Vector2 should be moved (or aliased) into the Phaser.Geom collection.

There's no tangible benefit to moving (or aliasing) this. Point was left over from v2. Vector2 is used almost exclusively internally and in Phaser 4 it's Vector2 only and no Point class. The two have existed like this in v3 for years now and there's no need to change them at this stage of its life.

There's no tangible benefit to moving (or aliasing) this. Point was left over from v2. Vector2 is used almost exclusively internally and in Phaser 4 it's Vector2 only and no Point class. The two have existed like this in v3 for years now and there's no need to change them at this stage of its life.


[Build] Python-client build script use wrong path for root dir

Motivation
The current build process is broken by the wrong root dir. The same mistake that occurred in RPM build has been fixed by #9890 but it hasn't been fixed in python-client build.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


error : invalid air mode: 255 while trying HFP API (IDFGH-2349)

i was working on HFP, whenever a call is recieved(smartphone) the following error comes up after the function esp_hf_client_outgoing_data_ready() is called:
bt_hf_client_sco_out_data invalid air mode: 255
I can get audio packets in an Outgoing call , the error comes up only while receiving Incoming call.
i registered the HF data callbacks as :
esp_hf_client_register_data_callback(esp_hf_client_incoming_data_cb,
                                                esp_hf_client_outgoing_data_cb);

The AVRCP and A2DP are working perfectly, i can also see incoming calls and network state.
Code reference : a2dp_sink example Compiled using ESP-IDF 4.0
Thankful for the support. Help!

Hi @Tarun-Narain,
Where do you place the esp_hf_client_outgoing_data_ready(); API?
It shouldn't be placed in esp_hf_client_incoming_data_cb, please comment it out or place it just after the outgoing call data is ready, to test the incoming calls.
Thanks
Abner

Hi @AbnerFederer,
i've commented the line in esp_hf_client_incoming_data_cb but the error still exists, i call the esp_hf_client_outgoing_data_ready(); in
void bt_app_hf_event(esp_hf_client_cb_event_t event, esp_hf_client_cb_param_t *param)
{
    switch (event) {

 case ESP_HF_CLIENT_CIND_CALL_EVT:
        ESP_LOGE(BT_AV_TAG, "--Call indicator %s %d",
                 c_call_str[param->call.status],param->call.status);
				 if(param->call.status==1)// 1=>call in progress
					 esp_hf_client_outgoing_data_ready();
        break;
}

Hi @Tarun-Narain
It should be used in your application where outgoing data is ready for each SCO packet.
For example, when i2s have saved enough data for the outgoing SCO packet.
Thanks
Abner

Thanks @alexey-morozov,
Can you tell me why there is noise when i feed the audio To i2s_write or write_ringbuf functions?

Hi @Tarun-Narain
I have tested the HFP with A2DP coexist the incoming data I think is good enough.
Maybe you can control the frequency for write_ringbuf or i2s_write.
I will continue to dive into HFP and A2DP about SCO issues.
I will merge optimizations if any updates.
Thanks
Abner

Thanks for solving the issue within a day. 😃


Add support for deno workspace and deno publish.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.00%. Comparing base (3a584b0) to head (a9cf0fc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   92.00%   92.00%
=======================================
  Files          52       52
  Lines        3789     3789
  Branches      352      352
=======================================
  Hits         3486     3486
  Misses        302      302
  Partials        1        1

Flag
Coverage Δ

unittests
92.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Skip imports when generating marker interfaces

Before, we tried to generate marker interfaces and insertion points for Protobuf sources which are included for a Proto compilation but are not requested, i.e. Protobuf imports. This led to failures in multi-project Gradle builds when several projects depending on each other had some marker interfaces to generate.
From now, the markers are generated for the requested types only.

@armiol, PTAL.


Suggestion: add "sane"

sane is the inverse of "insane" and is thus ableist in many contexts

Hey @nslater!
Thanks for the issue. :smile:

What considerate alternatives would you suggest, instead of “sane”?
Would you be interested in creating a PR? Basically, you’d add a new pattern to retext-equality/script/ablist.yml, like so, and then (after npm install) execute npm run build to update the distribution files.

@nslater Ping!

Closing due to no response.


Add support for cancel (or pause?)

See recent commit to https://github.com/sindresorhus/electron-dl/commit/cb20484c2d3c9e2ecdff40cc6e81a8afac51353e
Since your download manager tries to support resume, it's possible this cancel functionality could double as pause. (Truly canceling may require deleting the what has been downloaded upto the cancel.)

@ericpyle apparently the item is being send as a second argument in the onProgress function, so I think you should be able to call item.cancel(), take a look:
https://github.com/danielnieto/electron-download-manager/blob/2aec86d97a0cd7a75a94921524028992a43dbebb/index.js#L47-L49

Thanks @ndelvalle


generalize cholesky_serial code

This PR for clean up cholesky_serial code:

simplify the code, improve readability
read input file from command line by adding --input_file="inputFilePath"
data type consistency
remove necessary args and functions

Hi @weilewei @mhaseeb123, please review this PR if possible.
Do you think I should create another PR for clean up cholesky_stdpar? or waiting this got merged?


Installed shadcn ui + fixed conflicting css files and project structure

Re-worked file structure and removed css conflicts.
Once merged to develop we still need to:

fix modal and start buttons in SDG11 page
fix dropdown in navbar
fix home page


some CSS is not available in View Formatting SPO

My  can't apply css view formatting
"clip-path":"polygon(50%0%','83%12%','100%43%','94%78%','68%100%','32%100%','6%78%','0%43%','17%12%)"
Somebody have bug too ?

I find document css for view formatting spo,I hope it will update more someday
https://docs.microsoft.com/en-us/sharepoint/dev/declarative-customization/column-formatting#detailed-syntax-reference


Tweet automation?

Thinking about https://github.com/zmoon/FortranTipBrowser/issues/2, with that kind of workflow it would be possible[^1] to automate the Tweet creation.
The text file format could be like:
The tweet text for the tip could be here at the top.

Maybe with multiple paras.

Long version
============
This would be the long version of the tip text.
This section (including heading) would be optional.

It can have multiple paras too.

Another option would be to place the tip text for the tweet and optional long version as comments in the Fortran source code file, would just have to decide on a format to use.
[^1]: I just got a Twitter API key, and there are some options for automating Carbon. I could write a GitHub Actions Workflow to check for new .f90/.txt files upon push to the main branch and create a draft tweet if one is found.

Good idea, thanks. Let's try it out. You now have contributor privileges through TweetDeck for @fortrantip. I just uploaded function.f90 and function.txt to this repo. You can create a tweet and post it from @FortranTip if it looks good.

I've gotten Carbon automation working, but I'm not sure I have the style settings exactly the same as what you have been using.
So far I have (https://github.com/zmoon/FortranTip/blob/8883acf3c9c2a566f68db40f7dd83cd3f360486a/tweet/tweet.py#L19-L25)

One Light theme
white bg color
window controls off

Looks good.

I figured out the auto tweet posting. But in order to post as @FortranTip we need to generate an access token for my "app".

I guess you figured it out, since I see the tweet. Thanks.

Haha I just did it manually because I was tired of fiddling with it. I think I could generate the token if you (privately) shared the FortranTip credentials?

I just did through TweetDeck.


[SPARK-18106][SQL] ANALYZE TABLE should raise a ParseException for invalid option

What changes were proposed in this pull request?
Currently, ANALYZE TABLE command accepts identifier for option NOSCAN. This PR raises a ParseException for unknown option.
Before
scala> sql("create table test(a int)")
res0: org.apache.spark.sql.DataFrame = []

scala> sql("analyze table test compute statistics blah")
res1: org.apache.spark.sql.DataFrame = []

After
scala> sql("create table test(a int)")
res0: org.apache.spark.sql.DataFrame = []

scala> sql("analyze table test compute statistics blah")
org.apache.spark.sql.catalyst.parser.ParseException:
Expected `NOSCAN` instead of `blah`(line 1, pos 0)

How was this patch tested?
Pass the Jenkins test with a new test case.

Test build #67560 has started for PR 15640 at commit 4819dd1.

Test build #67560 has finished for PR 15640 at commit 4819dd1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67560/
Test PASSed.

Test build #67587 has started for PR 15640 at commit c92b6f1.

Test build #67588 has started for PR 15640 at commit 2a7707e.

Hi, @srinathshankar .
For the test suite, I'll update again if you give more opinion. So far, I didn't update that because I'm not sure.

Test build #67587 has finished for PR 15640 at commit c92b6f1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67587/
Test PASSed.

Test build #67588 has finished for PR 15640 at commit 2a7707e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67588/
Test PASSed.

Merged build finished. Test PASSed.

Hi, @hvanhovell .
Could you review this PR when you have some time?

Test build #67598 has started for PR 15640 at commit ec0516b.

Test build #67598 has finished for PR 15640 at commit ec0516b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67598/
Test PASSed.

Test build #67792 has started for PR 15640 at commit 00b4f54.

Test build #67793 has started for PR 15640 at commit 465f646.

Test build #67792 has finished for PR 15640 at commit 00b4f54.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67792/
Test FAILed.

The only test failure seems to be irrelevant. Let's see the final test result which is still running.
[info] - SPARK-10562: partition by column with mixed case name *** FAILED *** (687 milliseconds)

Test build #67793 has finished for PR 15640 at commit 465f646.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67793/
Test PASSed.

Merged build finished. Test PASSed.

LGTM - merging to master. Thanks!

Thank you, @hvanhovell ! Also, Thank you, @srinathshankar .


Implement integration tests for basic send/receive, message settling and lock renewal scenarios

Tests that need mocks
Reconnect

Reconnect receiver link on message receive failure
Reconnect on session failure
Reconnect on connection failure
No reconnect on non-retryable errors
No reconnect for batching receivers

Hi @ramya-rao-a, @amarzavery  - I just did a test for this scenario:
No settling of message results in an expired message. Should this increment the delivery count the next time?

And I can confirm that this does indeed increment the delivery count - which should protect us from messages that crash the client so long as the client can recover itself.

Thank you for breaking down this work! I have created separate issues for this work.


A fatal error has been detected by the Java Runtime Environment

Game crashing with code 1
Windows 10, 19045.2251
OS & version [e.g. Windows 10, 1822]:
Microsoft-32931 (17.0.3+7) (build 17.0.3+7-LTS)
Every time i try opening the game it just crashes, with the exit code 1

Thank you for the report!
Please submit this issue over at the Mojang bug tracker. Please search for existing reports first; in case you do not find any, create a new report and let us know about the issue number here (e.g. MC-123456). The Mojang team will take the first look. If an OpenJDK bug is identified, the Mojang team will contact the Microsoft Build of OpenJDK team to address the issue.


e2e tests: provide KubernetesIPAM factory func with explicit namespace

It would use the namespace mentioned in the kubeconfig's current
context, which can be empty.
This way, the tests can inject the correct namespace into the client.

/cc @nicklesimba


Proc-macro panic with r# identifier

This code:
#[derive_where::derive_where(Clone)]
struct Foo<'a, T> {
    r#class: &'a T,
}

Fails to compile:
error: proc-macro derive panicked
 --> src/main.rs:2:1
  |
2 | #[derive_where::derive_where(Clone)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = help: message: `"__r#class"` is not a valid identifier
  = note: this error originates in the attribute macro `derive_where::derive_where` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `derive-where-err` due to previous error

Likely because somewhere in the crate, it prefixes the identifier name with __ without checking for the r# prefix.

@ColonelThirtyTwo a new version was released with a fix: https://crates.io/crates/derive-where/1.2.1.


Evaluator crashes upon starting

Log from the evaluator suggests the DOS Package Configuration Provider is missing a communications token.  This is curious, since the same token is always used also for the DOS Scanner, which runs successfully. There's been no changes to the Evaluator job configuration.
2024-09-12 07:55:39.636	2024-09-12 04:55:39.634 [DefaultDispatcher-worker-1] [traceId=b4f76088-6a12-4e25-913a-db401a7d3381, ortRunId=159, component=evaluator-worker, evaluatorJobId=24] level=INFO  o.e.a.o.t.r.RabbitMqMessageSenderFactory - RabbitMQ queue: 'orchestrator_queue'
2024-09-12 07:55:39.635	2024-09-12 04:55:39.634 [DefaultDispatcher-worker-1] [traceId=b4f76088-6a12-4e25-913a-db401a7d3381, ortRunId=159, component=evaluator-worker, evaluatorJobId=24] level=INFO  o.e.a.o.t.r.RabbitMqMessageSenderFactory - RabbitMQ user: 'admin'
2024-09-12 07:55:39.635	2024-09-12 04:55:39.634 [DefaultDispatcher-worker-1] [traceId=b4f76088-6a12-4e25-913a-db401a7d3381, ortRunId=159, component=evaluator-worker, evaluatorJobId=24] level=INFO  o.e.a.o.t.r.RabbitMqMessageSenderFactory - RabbitMQ server URI: 'amqp://rabbitmq:5672'
2024-09-12 07:55:39.634	2024-09-12 04:55:39.634 [DefaultDispatcher-worker-1] [traceId=b4f76088-6a12-4e25-913a-db401a7d3381, ortRunId=159, component=evaluator-worker, evaluatorJobId=24] level=INFO  o.e.a.o.t.r.RabbitMqMessageSenderFactory - Creating RabbitMQ sender for endpoint 'orchestrator'.
2024-09-12 07:55:39.628	2024-09-12 04:55:39.626 [DefaultDispatcher-worker-1] [traceId=b4f76088-6a12-4e25-913a-db401a7d3381, ortRunId=159, component=evaluator-worker, evaluatorJobId=24] level=INFO  o.e.a.o.t.MessageSenderFactory - Creating a MessageSender of type 'rabbitMQ' for endpoint 'orchestrator'.
2024-09-12 07:55:39.628	2024-09-12 04:55:39.624 [DefaultDispatcher-worker-1] [traceId=b4f76088-6a12-4e25-913a-db401a7d3381, ortRunId=159, component=evaluator-worker, evaluatorJobId=24] level=INFO  o.e.a.o.transport.MessagePublisher - Sending 'EvaluatorWorkerError' message to 'OrchestratorEndpoint'. TraceID: 'b4f76088-6a12-4e25-913a-db401a7d3381'.
2024-09-12 07:55:39.627		at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:702)
2024-09-12 07:55:39.627		at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:715)
2024-09-12 07:55:39.627		at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:811)
2024-09-12 07:55:39.625		at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:104)
2024-09-12 07:55:39.625		at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584)
2024-09-12 07:55:39.625		at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:99)
2024-09-12 07:55:39.625		at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:111)
2024-09-12 07:55:39.624		at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
2024-09-12 07:55:39.624		at kotlinx.coroutines.JobSupport.makeCompletingOnce$kotlinx_coroutines_core(JobSupport.kt:839)
2024-09-12 07:55:39.624		at kotlinx.coroutines.AbstractCoroutine.resumeWith(AbstractCoroutine.kt:97)
2024-09-12 07:55:39.624		at kotlinx.coroutines.JobSupport.tryMakeCompleting(JobSupport.kt:867)
2024-09-12 07:55:39.624		at kotlinx.coroutines.JobSupport$ChildCompletion.invoke(JobSupport.kt:1166)
2024-09-12 07:55:39.624		at kotlinx.coroutines.JobSupport.tryFinalizeSimpleState(JobSupport.kt:294)
2024-09-12 07:55:39.624		at kotlinx.coroutines.JobSupport.completeStateFinalization(JobSupport.kt:317)
2024-09-12 07:55:39.624		at kotlinx.coroutines.JobSupport.continueCompleting(JobSupport.kt:947)
2024-09-12 07:55:39.624		at kotlinx.coroutines.JobSupport.access$continueCompleting(JobSupport.kt:22)
2024-09-12 07:55:39.622		at kotlinx.coroutines.DispatchedCoroutine.afterCompletion(Builders.common.kt:251)
2024-09-12 07:55:39.622		at kotlinx.coroutines.DispatchedCoroutine.afterResume(Builders.common.kt:257)
2024-09-12 07:55:39.621		at kotlinx.coroutines.internal.DispatchedContinuationKt.resumeCancellableWith$default(DispatchedContinuation.kt:274)
2024-09-12 07:55:39.621		at kotlinx.coroutines.internal.DispatchedContinuationKt.resumeCancellableWith(DispatchedContinuation.kt:279)
2024-09-12 07:55:39.620		at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
2024-09-12 07:55:39.620		at org.eclipse.apoapsis.ortserver.workers.evaluator.EvaluatorRunner$run$1.invokeSuspend(EvaluatorRunner.kt)
2024-09-12 07:55:39.620		at org.eclipse.apoapsis.ortserver.workers.evaluator.EvaluatorRunner.run(EvaluatorRunner.kt:103)
2024-09-12 07:55:39.620		at org.ossreviewtoolkit.plugins.packageconfigurationproviders.api.PackageConfigurationProviderFactory$Companion.create(PackageConfigurationProviderFactory.kt:52)
2024-09-12 07:55:39.619		at org.ossreviewtoolkit.plugins.packageconfigurationproviders.dos.DosPackageConfigurationProviderFactory.create(DosPackageConfigurationProviderFactory.kt:15)
2024-09-12 07:55:39.619		at org.ossreviewtoolkit.plugins.packageconfigurationproviders.dos.DosPackageConfigurationProviderFactory.create(DosPackageConfigurationProviderFactory.kt:9)
2024-09-12 07:55:39.618	2024-09-12 04:55:39.615 [DefaultDispatcher-worker-1] [traceId=b4f76088-6a12-4e25-913a-db401a7d3381, ortRunId=159, component=evaluator-worker, evaluatorJobId=24] level=ERROR o.e.a.o.w.e.EvaluatorComponent - Evaluator job '24' failed.
2024-09-12 07:55:39.618	java.lang.IllegalStateException: Option token is required but not set.
2024-09-12 07:55:39.612	2024-09-12 04:55:39.613 [DefaultDispatcher-worker-1] [traceId=b4f76088-6a12-4e25-913a-db401a7d3381, ortRunId=159, component=evaluator-worker, evaluatorJobId=24] level=ERROR o.e.a.o.w.evaluator.EvaluatorWorker - Error while processing message with traceId 'b4f76088-6a12-4e25-913a-db401a7d3381': Option token is required but not set.

@sschuberth The difference to my yesterday's runs is that ORT has updated to v31 for which I'm reading the changelog now. Are there any breaking changes to plugin config?

Yes, indeed the new plug-in API is in use for package configuration providers now. However, the DOS provider should have been migrated properly as we upstreamed it a while ago.

Apparently,  token  is marked as a required option to configure the DOS PCP now, but it is not provided by your config.

Yes, indeed the new plug-in API is in use for package configuration providers now. However, the DOS provider should have been migrated properly as we upstreamed it a while ago.

The curious thing is, yesterday the Evaluator did run and the ort-result.yml showed the correct resolved_configuration from our backend - the issue was that the new state wasn't being handled properly.
In today's runs, the Evaluator crashes immediately, so naturally there are no resolved configurations seen in ort-result.yml. I think the only relevant change is ORT v31, but I am going through all commits since yesterday.

It is, in secrets.properties, just like yesterday.

This is a bug in ORT, see https://github.com/oss-review-toolkit/ort/pull/9128.

This was fixed with ORT 32.1.0.


Remove unsigned variants of DataValue

As discussed in issue #5398 and Zulip previously, the unsigned variants of DataValue do not make a lot of sense given that Cranelift does not distinguish between signed/unsigned values in the IR and the operations specify signedness when it matters.
Given that there seems to have been no public progress for a couple of months I decided to pick it up.
This changes makes the interpreter reflect that by using explicit signed/unsigned operations when required that follow the IR naming scheme by prepending s or u before the operation name.

@afonso360, do you want to review this one?


Add FileStream property for audio file in addition to byte array

This PR adds a FileStream property so a Stream can be used instead of a byte array for the Whisper API.

Sorry for the confusion. I meant if both of them are not null. I have updated the code. I prefer to let OpenAI handle it if the developer does not send any file.

Sorry for the confusion. I meant if both of them are not null. I have updated the code. I prefer to let OpenAI handle it if the developer does not send any file.

I see, I actually misread your comment. That makes sense! Thanks for fixing it.


Update docs on how to setup top frame 3 legged OAuth with PKCE

Update docs on how to setup top frame 3 legged OAuth with PKCE

Coverage decreased (-0.2%) to 89.977% when pulling 3043dd49092ea116fdd2992134a3f27ff4d84e0f on bugfix/update-docs-for-top-frame-login-with-pkce into 2bc7829c17fe196bfe7fb38d3752e8163dff67fc on master.


integration test 's open id connect throw "System.Net.CookieException : The 'Path'='/signin-oidc' part of the cookie is invalid "

I have a mvc client use the oidc feature with asp.net identity.Config in startup is that:
            services.AddAuthentication(options =>
            {
                options.DefaultScheme = "Cookies";
                options.DefaultChallengeScheme = "oidc";
            })
            .AddCookie("Cookies")
            .AddOpenIdConnect("oidc", options =>
            {
                options.SignInScheme = "Cookies";

                //44341 is the port of Identity.API project
                options.Authority = "https://localhost:44341";

                options.RequireHttpsMetadata = false;

                options.ClientId = "mvc";

                options.ClientSecret = "secret";

                options.ResponseType = "code id_token";

                options.SaveTokens = true;

                options.GetClaimsFromUserInfoEndpoint = true;

                options.Scope.Add("api1");

                options.Scope.Add("offline_access");

            });

Integration test code use this httpclient:
             var client = mvcFactory.CreateClient(new
             Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactoryClientOptions()
            {
                HandleCookies=true,
                AllowAutoRedirect=false,
                BaseAddress=new Uri ("https://localhost:44332/")
            })

or this from the identity model's code:
            var client = new BrowserClient(new BrowserHandler(mvcHandler))
            {
                AllowCookies=true,
                BaseAddress=new Uri("https://localhost:44332/"),
                AllowAutoRedirect=false
            };

Then run the test show this error:
Message: System.Net.CookieException : An error occurred when parsing the Cookie header for Uri 'https://localhost:44332/Home/Login'.
---- System.Net.CookieException : The 'Path'='/signin-oidc' part of the cookie is invalid.

Do that because I want get the access_token from
HttpContext.GetTokenAsync("access_token");
Because I do the oidc with the authorize feature, so I can get access token by used the id and secure,but this token didn't had the correct role for access the protected api.
So I do above code to simulator the login round trip to get the logined access_token.

Then today I check the source code of the .net core 's CookieContainerHandler  here
and the handler of the identity sample code here
exception throw in the SetCookies method of the class CookieContainer.
That all info now  I can provide.

I just ran into a very similar problem today when trying to get an integration test working. I managed to solve it by setting the cookie paths like this:
.AddOpenIdConnect(OpenIdConnectDefaults.AuthenticationScheme, options =>
				{
					options.CorrelationCookie.Path = "/";
					options.NonceCookie.Path = "/";

It seems like the cookie paths defaults to the same value as that of options.CallbackPath. I think that "/" would be a better default for the cookie paths. (Some more security minded person might disagree...)

After devising my own solution I also found this:
https://github.com/aspnet/AspNetCore/blob/d8381656429addead2e5eb22ba1356abfb419d86/src/Azure/AzureAD/test/FunctionalTests/WebAuthenticationTests.cs#L192

@twogood Thanks so much , I'll test your solution later  : )
So I want keep this issue still open status.
@brockallen
@AutismPatient

@twogood It's work!!!Thanks so much.It's really useful to use the cookie,or I have do much code work in the project code to do simulated.
And with your help , I have reach the last step of the process of the integration test.And the last problem here https://github.com/IdentityServer/IdentityServer4/issues/3067
It's seem like that is an issue,we can discuss in the new thread 😀

FYI, there is more information about the unerlying but on https://github.com/dotnet/corefx/issues/27520 and here https://github.com/dotnet/corefx/issues/29651
Once that last issues is addressed this workaround should no longer be necessary.


speechbrain.nnet.loss.transducer_loss.py vs torchaudio.transforms.RNNTLoss

Hi! In PyTorch 1.10 the RNNTLoss was added. Will you maintain the speechbrain transducer_loss in the future? Should I prefer PyTorch RNNTLoss over it?

Hi, we are on the process of benchmarking both @aheba . It is highly probable that we will maintain both in the end, as the torch loss won't enable users to do research on this loss, while our implementation does.

Thank you for the answer. Will you publish the results of your benchmarking? It's interesting for me because PyTorch release notes describe the implementation as following:

The implementation is consistent with the original loss function in  Sequence Transduction with Recurrent Neural Networks, but relies on code from Alignment Restricted Streaming Recurrent Neural Network Transducer.

In the second paper the authors pay particular attention to the token emission delays and propose the modified RNN-t loss called "Alignment Restricted RNN-T Loss". So PyTorch implementation may perform significantly different than the standard RNN-T Loss from the first paper.

There is no reason for us not making the benchmark public @aheba. But this is still on the to-do list, so we do not know when it will be up :-)

Hi @kokamido , good point,
Let me open a PR to support RNN-T torchaudio.

Hi @kokamido , The PR  #1199  is merged, Know we do support both RNN-T loss from torchaudio and our.
In next days, I will push a PR on adding:
1- FastEmit Transducer loss regularisation for more streamable Transducer model
2- Work on decoding part with a stateless decoding

Hi @kokamido , The PR #1199 is merged, Know we do support both RNN-T loss from torchaudio and our.
In next days, I will push a PR on adding: 1- FastEmit Transducer loss regularisation for more streamable Transducer model 2- Work on decoding part with a stateless decoding

@aheba
Do you plan to make the benchmarks public?


Add try/catch statement to E2.

Adds a try / catch statement to E2 that allows users to catch any errors that occur inside of the block, and if so, run the catch block, setting the variable name provided to a new local variable that contains the error string.

NYOOOOM


Fix gmem to smem WAW conflict in awq gemm kernel

Motivation
Fix the WAW(write after write) conflict bug in awq gemm CUDA kernel.
Modification
Before, this kernel use a wrong offset computation(gmem -> smem, dim-N).
Now, use a var(upper_n_) to avoid WAW conflict.

@lvhan028 @lzhangzz


Lepiter navigation broken after exception on specific page

On a brand new GT, version 1.0.977, select the page Working with Python source files in the Pages view of the GT book. This causes the debugger to pop up. After this, selecting any other page in the book only changes the title of the page displayed in the right-hand view to the newly selected page's title, but the contents remain unchanged.

There are two problems here:

we should not get an exception for selecting a page in the first place
we should not break lepiter if we do

I added a fix for the initial exception.


Speed up Brightness, Contrast transformations based on SOLT insights

Based on the benchmark SOLT library is faster in Brightness and Contrast in three channel uint8 images.
We can absorb the insights from SOLT our library

[x] Speed up Brightness
[x] Speed up Contrast

Implemented in https://github.com/albu/albumentations/pull/269


Document cli usage

Hello,
First of all I would like to say thank you for what you did,
Now to the question
you have a lot of screen shots but only one usage explained, i saw already that someone asked about the slack, but i didn't see how to use notifications on mac,
it will make things more easier for people if you will provide that

Cheers @igormursa-newstore for your feedback. I'm planning on fully documenting the usage soon. Sorry I have not done this sooner.
As for desktop notifications, simply add --notify onto the end of the command.

Thank you ;)

Check out https://github.com/jacobmarshall/pokevision-cli/tree/master/docs for some initial documentation I quickly put together.


Format document?

Any chance this could be extended to prettyprint the json objects in the .jsonl file, or just a row at a time?

Hello
This is something I've thought about, being able to fold/unfold each line to pretty print (without modifying the actual file if possible)
But this is way more work and I still didn't take the time to get back to coding this extension.


Correcting KeyError happening in quickstart notebook when "level" is scalar

Hello, when pulling the repo and running the quickstart notebook I got KeyError with the load_test_data and DataGenerator because level is a scalar value. I proposed a fix which I think will not impact other utilisation of this code (when level is not a scalar).

Thanks for that. Happy to merge.


spacy-model-en_core_web 3.3.0

Actions:

Fix python in host
Add setuptools and wheel in run
Add license_family

We can skip s390x as it's noarch python outputs

Skipping builds because they don't compile will put a roadblock in the way of a later automated build. For this reason, I tend to disagree with skip: True  # [s390x] - reason: it doesn't build.

I've tested it locally:
conda create -n test_spacy -c c3i_test2 spacy-model-en_core_web_sm
conda activate test_spacy

❯ python
Python 3.10.4 (main, Mar 31 2022, 03:37:37) [Clang 12.0.0 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import spacy
>>> nlp = spacy.load("en_core_web_sm")
>>> doc = nlp(u"This is a sentence.")
>>> doc
This is a sentence.
>>> import spacy
>>> import en_core_web_sm
>>>
>>> nlp = en_core_web_sm.load()
>>> doc = nlp(u"This is a sentence.")
>>> doc
This is a sentence.

No issues


AWS::EC2::KeyPair Ref error

*cfn-lint version: 0.61.2
Description of issue.
With a KeyPair such as
  KeyPair:
    Type: AWS::EC2::KeyPair
    Properties:
      KeyName: MyKeyPair
      KeyType: ed25519

If you reference that KeyPair, such as KeyName: !Ref KeyPair, cfn-lint returns the follow error, even though this deploys as expected to CloudFormation:
E3008: Property "KeyName" has no valid Refs to Resources at Resources/MyInstance/Properties/KeyName/Ref

This one doesn't change that much but yes if its high frequency change than I think it should be considered.  Our goal will be to try to discover and find issues before deploying a template and this is one of those areas that we can help with because there are instances where it is unknown on what to use a Ref or GetAtt (and what GetAtt attribute to use).  I would love to automate this more so open to ideas on what can be done there.


Change base template from GitHub default to other that supports custom JavaScript & CSS

With the new #5 and even if using simple string replace with IDEs the relations between items is getting harder to maintain, even for a simple MVP.
Changing the base template (instead of optimize the #5) can be a alternative for short term.

For the current complexity #2, sadly, this strategy here maybe would not be sufficient.


Notification controller crashes when trying to send alerts to Alertmanager

When the notification controller tries to send an alert to Alertmanager it throws an error and crashes the pod.
Flux version is v0.23.0
Current version of notification controller running in cluster is v0.18.1
Below is the yaml used to setup the provider and alerts
apiVersion: notification.toolkit.fluxcd.io/v1beta1
kind: Provider
metadata:
  name: alertmanager
  namespace: flux-system
spec:
  type: alertmanager
  address: http://<myurl>/api/v2/alerts/
---
apiVersion: notification.toolkit.fluxcd.io/v1beta1
kind: Alert
metadata:
  name: errors
  namespace: flux-system
spec:
  providerRef:
    name: alertmanager
  eventSeverity: error
  eventSources:
    - kind: GitRepository
      name: '*'
    - kind: Kustomization
      name: '*'
    - kind: HelmRelease
      name: '*'
    - kind: ImageRepository
      name: '*'
    - kind: ImagePolicy
      name: '*'
    - kind: ImageUpdateAutomation
      name: '*'

The logs show an event being dispatched but then errors out.
`{"level":"info","ts":"2021-11-17T17:04:45.649Z","logger":"event-server","msg":"Dispatching event: version list argument cannot be empty","reconciler kind":"ImagePolicy","name":"my-app","namespace":"flux-system"}`

panic: assignment to entry in nil map

goroutine 353 [running]:
github.com/fluxcd/notification-controller/internal/notifier.(*Alertmanager).Post(0xc000a506c0, 0xc000620230, 0xb, 0xc000620240, 0xb, 0xc000046258, 0x18, 0xc0005ac0c0, 0x24, 0xc0004fc140, ...)
	/workspace/internal/notifier/alertmanager.go:69 +0x20e
github.com/fluxcd/notification-controller/internal/server.(*EventServer).handleEvent.func1.1(0x0, 0x0, 0xc000231950, 0xc0004dc2a0, 0x1f17e20, 0xc000a506c0, 0xc000620230, 0xb, 0xc000620240, 0xb, ...)
	/workspace/internal/server/event_handlers.go:225 +0x75
created by github.com/fluxcd/notification-controller/internal/server.(*EventServer).handleEvent.func1
	/workspace/internal/server/event_handlers.go:224 +0xdb8

Is there something wrong with my configuration sending alerts to Alertmanager?

Is there something wrong with my configuration sending alerts to Alertmanager?

No matter the configuration the controller should never crash but log the error and continue. Thanks for reporting this bug!


Bundling the driver in Metabase OSS fails

There's an error when you bundle the latest driver in the OSS version of the product:
ERROR driver.impl :: Error loading driver namespace clojure.lang.ExceptionInfo: Could not locate metabase/driver/starburst__init.class, metabase/driver/starburst.clj or metabase/driver/starburst.cljc on classpath. {:classloader #object[clojure.lang.DynamicClassLoader 0x498f5728 "clojure.lang.DynamicClassLoader@498f5728"], :classpath-urls (), :system-classpath ("/app/metabase.jar")}

If you bundle the driver in the EE version of the product, everything works

nevermind, it was just a problem of mine


Support Hadoop KMS

Based on https://github.com/prestosql/presto/pull/1002

Ready for review.

There are other open calls in HdfsParquetDataSource and BackgroundHiveSplitLoader.

This commit title sounds strange:

Update Hive-plugin configuration for KMS key provider cache TTL

How about

Allow configuring Hadoop KMS key provider cache TTL

There are other open calls in HdfsParquetDataSource

The code is unused, I am removing it.

and BackgroundHiveSplitLoader.

This is code for symlinks. Do you know how can I test this?

AC. Hopefully everything still works 😉

I was waiting for these changes to be merged. Hive tables with avro schema file hosted within a kerborized hdfs location was not working before and I can confirm that this PR is fixing that issue.
Thanks @findepi


New ERR_load_xxx_strings() functions should not be public

The util/mkerr.pl script will automatically create new ERR_load_xxx_stinrgs() functions where needed and make them public. This results in PRs like #10394 adding these functions to "missingcrypto.txt" to avoid having to document them - which is the wrong thing to do. We shouldn't be adding new public functions unless we expect applications to actually call them.
Probably util/mkerr.pl needs to be updated so that it doesn't add these functions to public headers.

I'd be happy to do so.  I need ideas on how to best register the new ones, so util/mkerr.pl doesn't suddenly start to remove old ones.

Either way, they should all be deprecated

I'd be happy to do so. I need ideas on how to best register the new ones, so util/mkerr.pl doesn't suddenly start to remove old ones.

One possibility is to do it the same way that find-doc-nits knows when we introduce newly undocumented functions without complaining about old ones. We have a text file somewhere containing the list of ERR functions that should remain public.

Either way, they should all be deprecated

Agreed.


Style engine interoperability on the server side (SSR with Styled-Components)

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡
This is not really a feature, but rather a suggestion for better documentation about the style engine interoperability. It seems to work perfectly on the client side with webpack.resolve.alias. However, on serverside setups which access packages directly from node_modules, webpack.resolve doesn't solve the problem.
After hours and hours of trial and error, the workaround I use for now is a codemod written using jscodeshift to change the import, export and require calls from @material-ui/style-engine to @material-ui/style-engine-sc. I belive I am not the only one to run into this problem. So I wanted to check if you legends would be happy for me to document this usecase.
If you do like the idea, where should we keep the codemod (As a gist? As a package? Or just document it?)
Thanks a lot for MUI v5. I really like this release. I also understand if you don't want to consider this at this stage. In that case, this issue itself can act as a workaround for those like me.
Examples 🌈
Full codemod is as follows:
/**
 * Mutate the library name recursively
 * eg: `require('@material-ui/styled-engine')` AND `wrapperFunc(require('@material-ui/styled-engine'))`
 */
function replaceValue(arg) {
  if (arg && arg.value === '@material-ui/styled-engine') {
    arg.value = '@material-ui/styled-engine-sc';
  }
  if (arg && arg.arguments) {
    arg.arguments.forEach(arg => {
      replaceValue(arg);
    });
  }
}

export default function transformer(file, api) {
  const j = api.jscodeshift;
  const root = j(file.source);

  // Replace imports
  root.find(j.ImportDeclaration).forEach(p => replaceValue(p.value.source));

  // Replace named exports
  root.find(j.ExportNamedDeclaration).forEach(p => replaceValue(p.value.source));

  // Replace default exports
  root.find(j.ExportDefaultDeclaration).forEach(p => replaceValue(p.value.source));

  // Replace require calls
  root
    .find(j.Program)
    .nodes()[0]
    .body.forEach(node => {
      if (node.type !== 'VariableDeclaration') return;
      for (const declarator of node.declarations) {
        declarator.init &&
          declarator.init.arguments &&
          declarator.init.arguments.forEach(replaceValue);
      }
    });

  return root.toSource();
}

An alternative approach would be to use patch-package to rewrite the library name on postinstall step. I didn't take that approach myself because there were too many usages of @material-ui/style-engine in the code. We could potentially suggest patching as a workaround if the @material-ui/style-engine library is kept in a single file which would act as a proxy for all other usages. But I reckon that would be more fragile than the codemod approach.
Motivation 🔦
Style-engine interoperability doesn't work seamlessly with server side rendering.

Thanks @pupudu for sharing your solution. Let's wait to see if this will be a pain for more people, and if that is the case, we may consider adding it to the documentation.


implemented dataframe.cov

ref #1929
Implement DataFrame.cov
>>> kdf = ks.DataFrame([(1, 2), (0, 3), (2, 0), (1, 1)],
...                   columns=['dogs', 'cats'])
>>> kdf.cov()
                  dogs      cats
        dogs  0.666667 -1.000000
        cats -1.000000  1.666667

Codecov Report

Merging #2142 (7987192) into master (d7f6e88) will decrease coverage by 2.23%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #2142      +/-   ##
==========================================
- Coverage   95.37%   93.14%   -2.24%
==========================================
  Files          60       60
  Lines       13694    13601      -93
==========================================
- Hits        13060    12668     -392
- Misses        634      933     +299

Impacted Files
Coverage Δ

databricks/koalas/missing/frame.py
74.57% <ø> (-25.43%)
:arrow_down:

databricks/koalas/frame.py
95.65% <85.71%> (-0.84%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
28.20% <0.00%> (-64.36%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
47.82% <0.00%> (-52.18%)
:arrow_down:

databricks/koalas/missing/series.py
60.56% <0.00%> (-39.44%)
:arrow_down:

databricks/koalas/__init__.py
80.26% <0.00%> (-11.85%)
:arrow_down:

databricks/koalas/missing/indexes.py
88.63% <0.00%> (-11.37%)
:arrow_down:

databricks/conftest.py
89.09% <0.00%> (-10.91%)
:arrow_down:

databricks/koalas/typedef/typehints.py
86.22% <0.00%> (-9.19%)
:arrow_down:

... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f6e88...7987192. Read the comment docs.

Hi @LSturtew, since Koalas has been ported to Spark as pandas API on Spark, would you like to migrate this PR to the Spark repository? I may also do that for you.


fix: passing max_length to vllm engine args

Current behavior: max_length is not passed to vllm args.
New behavior: It is now passed.
Reason: Trying to run Mistral 7B would just OOM as they have "max_position_embeddings": 32768,. max_length is not passed to the Engine args, so it would just take this value.
HF accelerate seems to run this fine though. I'm not sure if they have some sane defaults.
Test:
Before:
Initializing an LLM engine with config: model='Open-Orca/Mistral-7B-OpenOrca', tokenizer='Open-Orca/Mistral-7B-OpenOrca', tokenizer_mode=auto, revision=None, tokenizer_revision=None, trust_remote_code=False, dtype=torch.bfloat16, max_seq_len=32768, download_dir=None, load_format=auto, tensor_parallel_size=8, quantization=None, seed=1234)

After:
Initializing an LLM engine with config: model='Open-Orca/Mistral-7B-OpenOrca', tokenizer='Open-Orca/Mistral-7B-OpenOrca', tokenizer_mode=auto, revision=None, tokenizer_revision=None, trust_remote_code=False, dtype=torch.bfloat16, max_seq_len=4096, download_dir=None, load_format=auto, tensor_parallel_size=8, quantization=None, seed=1234)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi! Thanks for this! I think we should also pass max_model_len to the init method to keep syntactic compatibility with vLLM and have something like:
assert not (max_length is not None and max_model_len is not None), "Either max_length or max_model_len may be provided, but not both"
max_length = max_model_len if max_model_len is not None else max_length

cc: @haileyschoelkopf

May I ask where is max_model_len from?

Sorry, I didn't quite understand the question.

May I ask where is max_model_len from?

It's introduced in your PR.

Thank you for clarifying in discord! I have made the changes.

Thanks for this PR! Could you just run pre-commit run --all-files to satisfy the linter before we merge this?

Thanks for the reminder. I just ran it.

Thanks very much!


Add Test to TabularExplainer comparing against SHAP implementation

We should have a test comparing the output of the TabularExplainer against the output of the KernelSHAP implementation of the well known shap package.
This test does not need to be a perfect result in terms of the exact same values. This of course will only work for first order interactions (SVs).

A way of doing this is to run shap on a fixed model locally on your machine and copy the results from SHAP into the test case. I would like to omit having shap as a dependency in our test environment because it is too unreliable.
I did this similarly in the treeshap-iq comparison: https://github.com/mmschlk/shapiq/blob/d4f0d45eca24d95a174e74779ae87134ed107523/tests/tests_explainer/tests_tree_explainer/test_tree_treeshapiq.py#L84

this will work for max_order=1, which currently throws ValueError: The maximum order must be at least 2.

SHAP is a bit unstable and benchmark and exact computer is the better comparison/check.


Modified the DeployPackagesLocally script

It should now:

Generate .nupkg files in Build/../Packages (create the folder if needed)
Move them over to their corresponding folder in ~/.nuget/packages
Unzip them
Create an empty .sha512 file in the target folder

How to get on with debugging locally now:
The only prerequisite is that the project that you want to debug locally needs to have a package source feed into ~/.nuget/packages by specifying some Nuget.config file with a package source pointing to that root .nuget/packages folder.

cd into the folder that has Source and Build in root (For example blah/Runtime/)
execute ./Build/DeployPackagesLocally.sh
Make sure that the package references for the packages you want to debug locally are set to use version 1000 (should work with wildcard aswell)
Try dotnet clean && nuget restore / dotnet restore if it doesn't work

Still a WIP, some more fine tuning remains


Add Position PlaySound methods

Convenience methods for specifying a position instead of XYZ coordinates.

No problem for me, except that it would probably be preferable for those to call the already existing playSound methods to reduce boilerplate code

Yeah, good idea


Utils.js: function copyFile always prints "chmod  on  failed after copying, ignoring".

solution is to check if there actually was an error, ex.
if (err) {
    _event.emit('log', 'chmod ' + stats.mode + ' on ' + dest + ' failed after copying, ignoring');
}

also mentioned in #141

Actualy, whole copy file method is pretty fucked up...

Is there a planned release now that this issue is closed? My team's CI environment relies upon an npm release.
Apologies for nagging ;)
Thanks for the fix!

Yeah, sometime today (Irish time).
On Wed, 28 Jan 2015 15:11 Mike Ball<EMAIL_ADDRESS>wrote:

Is there a planned release now that this issue is closed? My team's CI
environment relies upon an npm release.
Apologies for nagging ;)
Thanks for the fix!
—
Reply to this email directly or view it on GitHub
https://github.com/mllrsohn/node-webkit-builder/issues/147#issuecomment-71850091
.

@adam-lynch Great - thanks so much.

1.0.8 published.


Error for input channels > 1

https://github.com/dwromero/ckconv/blob/master/demo/construct_your_own_ckconv_layer.ipynb
Changing the input to
# Input:
length = 1000
input_channels = 2
batch_size = 4

input_signal = torch.rand([batch_size, input_channels, length])
output = ckconv1(input_signal)

causes this error:
     87     # 6. Optionally, add a bias term before returning.
     88     if bias is not None:
---> 89         out = out + bias.view(1, -1, 1)
     90
     91     return out

RuntimeError: The size of tensor a (5) must match the size of tensor b (10) at non-singleton dimension 1```

HI @johnp-4dvanalytics ,
Thanks for your question and  your interest in our work :)
I think that the error is arising because you are not defining a CKConv of matching dimensions here:
In [4]:
in_channels = 1 # --> should be replaced by 2.
out_channels = 10
hidden_channels = 32
bias = True
omega_0 = 30.0

ckconv1 = CKConv(in_channels, out_channels, hidden_channels, bias, omega_0)

Could you please try that and let me know if that solves the issue?
Best,
David

Thanks! That fixes it


.editorconfig file enforces spaces if you have EditorConfig VS Extension

See also:

http://editorconfig.org/
https://visualstudiogallery.msdn.microsoft.com/c8bccfe2-650c-4b42-bc5c-845e21f96328

Looks good. :shipit:


Other genomes

Hi,
Your browser looks great
Could it support any Ensembl genomes for example http://fungi.ensembl.org/Schizosaccharomyces_pombe/Info/Index
Cheers,
Danny

Many thanks,
Yes I would like to have Biodalliance on our webserver for the Ensembl version of S. pombe  genome


Expose solver name on Settlement struct

I'm not sure this approach is the best, but it would be nice to know in our logs which solvers are responsible for the settled trades (to get an idea which ones are performing best and potential later attribution).
Because of "settlement merging" we cannot really do this attribution exact. In this PR I'm adding a solver field to the settlement struct which each solver can set to their name. In the merging face, if two solutions of the same solver get merged we keep that name, otherwise we set it to some other value.
Next up, I'd change the metric looging methods to add a solver label to each trade/simulation event.
Test Plan
CI

Because of "settlement merging" we cannot really do this attribution exact.

At the moment we only merge settlements by the same solver.
I'm not happy with storing the solver name inside of Settlement because that struct shouldn't know about solvers. It would be nicer if we could do this just in a driver wrapper struct liked RatedSettlement. But if it is really awkward there I am ok with doing it this way.

Implemented the suggestion with another wrapper struct. Let me know what you think.


Fix thesis

Fixed thesis listing and bunch of tests that were broken because of the db changes.

Changes Unknown when pulling 5dc3620ae4f089461c9677c0bb44d896cc384549 on fixThesis into ** on master**.

Changes Unknown when pulling 5c07ad65dbf8c4160f3097ce888875df6d3ab1fd on fixThesis into ** on master**.


preferredChain logic might not be sufficient to differentiate all possible chains

Just as a heads up. No immediate action should be required.
see: https://letsencrypt.org/2020/12/21/extending-android-compatibility.html

What about the alternate chain? Today, some ACME clients are able to instead request an alternate chain, if their user has configured it. We currently provide the option of getting the chain: Subscriber Certificate < – R3 < – ISRG Root X1 We will continue to offer this same chain as an alternate. However, note that most ACME clients don’t yet have a way to select this alternate chain (for example, Certbot selects chains by looking to see if they contain a given Issuer Name, but this chain doesn’t contain any Issuer Names which the high compatibility chain above doesn’t). We’ll be working with ACME client developers to create more flexible chain selection mechanisms going forward.

This in fact the case with the current ACME staging: which looks like (from https://community.letsencrypt.org/t/incomplete-alternate-certificate-chains-at-staging-area/145830/6)
This is the primary chain of issuance:

Leaf

(STAGING) Artificial Apricot R3

(STAGING) Pretend Pear X1

(STAGING) Doctored Durian Root CA X3 (not served)
This was and is the alternate chain of issuance.
Note 1: (STAGING) Doctured Durian Root CA X3 is expired (deliberately so - see https://community.letsencrypt.org/t/staging-doctored-durian-root-ca-x3-is-expired-breaks-test-environment/145689/2) & is not compatible with some use cases.
Note 2: (STAGING) Pretend Pear X1 is cross signed by itself and Doctored Durian

Leaf

(STAGING) Artificial Apricot R3

(STAGING) Pretend Pear X1  (not served)

The current preferred chain selection method provides no mechanism to select the alternate chain:
If we enter "(STAGING) Pretend Pear X1" then we get the primary chain because (STAGING) Pretend Pear X1 is self-signed by itself & cross signed by Doctored Durian  - "(STAGING) Pretend Pear X1" is a complete subset of the issuer string of (STAGING) Pretend Pear X1 in the primary chain and therefore the primary chain is always selected via the current preferred chain logic.

Took a closer look at this today and, with v5 of acme-client being on the horizon, opted for fixing this behavior with a breaking change in a45a3383ad86357e1674ae82e22814d91f77b897. This change will iterate through all certificates and prioritize the chain with a positive issuer match closest to the root, which should solve the problem.
Using staging as an example:
Primary chain: leaf (4) <- apricot (3) <- pear (2) <- durian (1)
Alternate chain: leaf (3) <- apricot (2) <- pear (1)
Preferring apricot or pear will now return the alternate, since they both have less distance to root compared to the primary.
Thanks for the input on this! :+1:

Published with v5.0.0, alternate chain selection should now be possible.


⚠ SceneTime has degraded performance

In 4bbe644, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 10936 ms

Resolved: SceneTime performance has improved in 4bc8630 after 12 minutes.


Add default keymap documentation

I didn't find any place to view the default mappings (except the code) so I created one.
Thought about creating a description column but the commands are quite self explanatory.

So nice, thank you @Janis-Leuenberger.
You wrote "When using macOS ctrl refers to the command key", which is true, except for the ctrl+w command because cmd+w is already used by the OS and ctrl+insert which is PC thing I guess.
Just out of curiosity, are you using or testing lite-xl on a Mac ? If yes I am interested to know what do you think of the keymap bindings. I am not sure if they are okay for a macOS application.

I'm testing lite-xl with a MacBook Pro 2015 11.3. The shortcuts using alt won't work. I haven't used lite-xl to really code yet so I can't tell if the mappings are good.

I am sort of blind to what happens on the Mac because I don't have one. If you ever find some specific things that needs to be fixed or changed you can open an issue. In addition I think some users will have a Mac keyboard and other may use a PC keyboard and they may behave differently.

It seems the project doesn't get much love from the apple community. I'd be happy to help, though I'm unfamiliar with the technologies used.

I think we have little or no Mac users but this is not very surprising. It was only very recently that I was able to produce a proper Mac application package with retina support. In addition Mac users have very high expectations about software standards and they want to have a native UI. Lite-xl doesn't use native manOS file open dialog, menus etc and some users will just dismiss the application for this reason. In addition I cannot test myself and optimize the application for the macOS as I can do on Windows and Linux.
If you want to help and try lite-xl do it as you feel. I don't want to sell lite-xl to macos users at all prices but I will be glad to improve things if I have some feedback.


Frontend

What should the ECS process from start-to-finish look like? Something like:
import Recs

main = do
  run . build $ do
    parallel [ mySys1, mySys2 ]
    mySys3 `after` mySys1
    mySys4 `after` mySys4Cleanup

mySys1 =
  emap (read @(Velocity, Time) -&- write @Position)
       (do
         (MkPosition v, MkTime t) <- bag
         tag (MkPosition $ p + dT *^ v))

mySys2 =
  emap (write @(Particle, Kinetic))
       (do
         MkParticle t <- bag
         if t < 0
           then untag @(Particle, Kinetic)
           else tag (MkParticle $ t - dT)

mySys3 =
  -- 'edo' allows you to manually run queries, spawn/despawn/get/tag/untag specific entities
  -- 'emap' is an 'edo' wrapper that launches straight into an archetype traversal
  edo (write @Velocity -&- inherit mySys2)
      (forM_ [0..1000] (const (make $ MkVelocity 0.0)) >> mySys2)
...

Because of #7, the type signature goes from:
System ([reads here], [writes here]) m ()

to
System [reads] [writes] [morphs] commands m ()

which is a lot uglier (but necessary for performance?).

Current query primitives:
select @w @s     Select for systems with 's' with permission 'w'
tags             Enable insertion/removal for
low              Enable arbitrary entity spawning/destruction

Some extra properties (TODO):
exclusive        Blocks all other systems from running


Replication Handling

If the cluster has a replication level of 2 and a volume goes down permanently, are the files on the other second volume being replicated to another/new volume automatically or how is this being done?
If so, is there a timeout, e.g. volumeID X unreachable withing 5 min, start replicating to new volume?
If there is a timeout, can this be configured due to server maintenance issues etc. and/or can the volume be shut down for maintenance  only?

the volumes will become read only.

all volumes will become read only? If so, there will be write errors everywhere? That would be horrible if we have 1000+ volumes. The probability that a volume will crash is high, the more volumes we have.
If not, there is no automatic replication like HDFS etc. has, we have to do it manually? That would also not also not very helpful at all. :(

the volumes with missing replica will become read only.

OK, so, I just have to get it right:
I got 10 volumes, replication level: 2  - there are 5 volumes, every volume has 1 replica.
If volume 1 has replica 6, if volume 1 goes down, volume 6 is read only. There is enough space available over the 10 volumes, but the replica 6 would not be automatic scheduled to other volumes that it becomes writable again?

volume 1 will be read only.
On Mon, Oct 16, 2017 at 1:30 AM, kw005<EMAIL_ADDRESS>wrote:

OK, so, I just have to get it right:
I got 10 volumes, replication level: 2 - there are 5 volumes, every volume
has 1 replica.
If volume 1 has replica 6, if volume 1 goes down, volume 6 is read only.
There is enough space available over the 10 volumes, but the replica 6
would not be automatic scheduled to other volumes that it becomes writable
again?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/chrislusf/seaweedfs/issues/572#issuecomment-336816947,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABeL7-EwshFyHHJ27AXSWys_OwsJEAejks5ssxQ-gaJpZM4P54Lt
.

The new replica has to done manually?


Fixes #3362 (Possible wrong behavior in HttpResponseDecoder/HttpRequestDecoder for large header/initline/content)

This is a partial fix for issue #3362 as discussed in the issue.
Motivation
HttpResponseDecoder and HttpRequestDecoder in the event when the max configured sizes for HTTP initial line, headers or content is breached, sends a DefaultHttpResponse and DefaultHttpRequest respectively. After this HttpObjectDecoder gets into BAD_MESSAGE state and ignores any other data received on this connection.
The combination of the above two behaviors, means that the decoded response/request are not complete (absence of sending LastHTTPContent). So, any code, waiting for a complete message will have to additionally check for decoder result to follow the correct semantics of HTTP.
If HttpResponseDecoder and HttpRequestDecoder creates a Full* invalid message then the request/response is a complete HTTP message and hence obeys the HTTP contract.
Modification
Modified HttpRequestDecoder, HttpResponseDecoder, RtspRequestDecoder and  RtspResponseDecoder to return Full* messages from createInvalidMessage()
Result
Fixes the wrong behavior of sending incomplete messages from these codecs

AUTOMATED MESSAGE for ADMINS:Please verify and accept the pull request.To accept, say @netkins acceptTo build again, say @netkins buildTo whitelist the author, say @netkins whitelist

@NiteshKant accept

@netkins accept

Nice catch. Cherry-picked: 381cf3f (4.0), b19a12b (4.1), 4aca2987d399e32ae28e8479b33497ac312bf65b (master)


Make fill_form more robust by requiring form ID.

Current implementation for fill_form attempts to find fields by their names.
However, if the same name is found in multiple places, this method will either
fail with a InvalidElementStateException exception or the wrong field may be
filled.
Please see #564 for more info.

@andrewsmedina mind taking a look at this? If it makes sense, I can update tests.

Hmm perhaps I should make form_id optional? Also, add an optional name argument, so that people can still use the original functionality, but if a name or id are passed, then look for a form with it?

Another possible solution:
diff --git a/splinter/driver/webdriver/__init__.py b/splinter/driver/webdriver/__init__.py
index cad1eba..d1cc559 100644
--- a/splinter/driver/webdriver/__init__.py
+++ b/splinter/driver/webdriver/__init__.py
@@ -417,12 +417,20 @@ class BaseWebDriver(DriverAPI):

     attach_file = fill

-    def fill_form(self, form_id, field_values):
-        form = self.find_by_xpath(
-            '//form[contains(@id, "{0}")]'.format(form_id))
+    def fill_form(self, field_values, form_id=None, name=None):
+        form = None
+
+        if name is not None:
+            form = self.find_by_name(name)
+        if form_id is not None:
+            form = self.find_by_xpath(
+                '//form[contains(@id, "{0}")]'.format(form_id))

         for name, value in field_values.items():
-            elements = form.find_by_name(name)
+            if form:
+                elements = form.find_by_name(name)
+            else:
+                elements = self.find_by_name(name)
             element = elements.first
             if (
                     element['type'] in ['text', 'password', 'tel'] or

@omaciel nice catch. Can you add a test to cover #564?

@andrewsmedina will try though time is kinda tight this week :/ Could I also ask you to add a hacktoberfest label to #564 ? :)

@omaciel I will add the label. But all PR's open in October are valid for hacktober fest. If you want, you can close this PR and open another PR.

@andrewsmedina tests are passing/failing and I'm not sure that I can look into all the different permutations... can you gimme a hand?

@omaciel all fill_form tests are here: https://github.com/cobrateam/splinter/blob/d3719283e29c4aae31dbaefacac29fbe2d5a331d/tests/form_elements.py
my suggestion is run in your machine against only one driver. I believe that flaskdriver is a good option. You can use this command to do it:
./run_tests.py -w tests/test_flaskclient.py

@andrewsmedina I had to ask for help on this since getting lxml installed on a virtualenv on a MAC is a pain!!! Anyhow, it looks like your tests have been failing for a while so I don't expect that we will see a green build...

The tests are unstable on travis :(
But the flask driver tests are stable. And still ok with your PR. So, LGTM

@andrewsmedina it fails to build lxml for me but someone ran the test you suggested (on Linux) and all tests passed.
Building wheels for collected packages: lxml
  Running setup.py bdist_wheel for lxml ... error
  Complete output from command /Users/omaciel/.virtualenvs/splinter/bin/python -u -c "import setuptools, tokenize;__file__='/private/tmp/pip-build-t4Irzs/lxml/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" bdist_wheel -d /tmp/tmp2UPB0tpip-wheel- --python-tag cp27:
  Building lxml version 3.6.4.
  Building without Cython.
  Using build configuration of libxslt 1.1.29
  Building against libxml2/libxslt in the following directory: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/lib
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build/lib.macosx-10.12-intel-2.7
  creating build/lib.macosx-10.12-intel-2.7/lxml
  copying src/lxml/__init__.py -> build/lib.macosx-10.12-intel-2.7/lxml
  copying src/lxml/_elementpath.py -> build/lib.macosx-10.12-intel-2.7/lxml
  copying src/lxml/builder.py -> build/lib.macosx-10.12-intel-2.7/lxml
  copying src/lxml/cssselect.py -> build/lib.macosx-10.12-intel-2.7/lxml
  copying src/lxml/doctestcompare.py -> build/lib.macosx-10.12-intel-2.7/lxml
  copying src/lxml/ElementInclude.py -> build/lib.macosx-10.12-intel-2.7/lxml
  copying src/lxml/pyclasslookup.py -> build/lib.macosx-10.12-intel-2.7/lxml
  copying src/lxml/sax.py -> build/lib.macosx-10.12-intel-2.7/lxml
  copying src/lxml/usedoctest.py -> build/lib.macosx-10.12-intel-2.7/lxml
  creating build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/__init__.py -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  creating build/lib.macosx-10.12-intel-2.7/lxml/html
  copying src/lxml/html/__init__.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
  copying src/lxml/html/_diffcommand.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
  copying src/lxml/html/_html5builder.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
  copying src/lxml/html/_setmixin.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
  copying src/lxml/html/builder.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
  copying src/lxml/html/clean.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
  copying src/lxml/html/defs.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
  copying src/lxml/html/diff.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
  copying src/lxml/html/ElementSoup.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
  copying src/lxml/html/formfill.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
  copying src/lxml/html/html5parser.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
  copying src/lxml/html/soupparser.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
  copying src/lxml/html/usedoctest.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
  creating build/lib.macosx-10.12-intel-2.7/lxml/isoschematron
  copying src/lxml/isoschematron/__init__.py -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron
  copying src/lxml/lxml.etree.h -> build/lib.macosx-10.12-intel-2.7/lxml
  copying src/lxml/lxml.etree_api.h -> build/lib.macosx-10.12-intel-2.7/lxml
  copying src/lxml/includes/c14n.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/config.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/dtdvalid.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/etreepublic.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/htmlparser.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/relaxng.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/schematron.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/tree.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/uri.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/xinclude.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/xmlerror.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/xmlparser.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/xmlschema.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/xpath.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/xslt.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/etree_defs.h -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  copying src/lxml/includes/lxml-version.h -> build/lib.macosx-10.12-intel-2.7/lxml/includes
  creating build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources
  creating build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/rng
  copying src/lxml/isoschematron/resources/rng/iso-schematron.rng -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/rng
  creating build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl
  copying src/lxml/isoschematron/resources/xsl/RNG2Schtrn.xsl -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl
  copying src/lxml/isoschematron/resources/xsl/XSD2Schtrn.xsl -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl
  creating build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
  copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_abstract_expand.xsl -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
  copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_dsdl_include.xsl -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
  copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_schematron_message.xsl -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
  copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_schematron_skeleton_for_xslt1.xsl -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
  copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_svrl_for_xslt1.xsl -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
  copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/readme.txt -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
  running build_ext
  building 'lxml.etree' extension
  creating build/temp.macosx-10.12-intel-2.7
  creating build/temp.macosx-10.12-intel-2.7/src
  creating build/temp.macosx-10.12-intel-2.7/src/lxml
  cc -fno-strict-aliasing -fno-common -dynamic -arch x86_64 -arch i386 -g -Os -pipe -fno-common -fno-strict-aliasing -fwrapv -DENABLE_DTRACE -DMACOSX -DNDEBUG -Wall -Wstrict-prototypes -Wshorten-64-to-32 -DNDEBUG -g -fwrapv -Os -Wall -Wstrict-prototypes -DENABLE_DTRACE -arch x86_64 -arch i386 -pipe -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/libxml2 -Isrc/lxml/includes -I/System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c src/lxml/lxml.etree.c -o build/temp.macosx-10.12-intel-2.7/src/lxml/lxml.etree.o -w -flat_namespace
  cc -bundle -undefined dynamic_lookup -arch x86_64 -arch i386 -Wl,-F. build/temp.macosx-10.12-intel-2.7/src/lxml/lxml.etree.o -L/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/lib -lxslt -lexslt -lxml2 -lz -lm -o build/lib.macosx-10.12-intel-2.7/lxml/etree.so
  ld: file not found: /usr/lib/system/libsystem_darwin.dylib for architecture x86_64
  clang: error: linker command failed with exit code 1 (use -v to see invocation)
  error: command 'cc' failed with exit status 1

  ----------------------------------------
  Failed building wheel for lxml
  Running setup.py clean for lxml
Failed to build lxml
Installing collected packages: lxml
  Running setup.py install for lxml ... error
    Complete output from command /Users/omaciel/.virtualenvs/splinter/bin/python -u -c "import setuptools, tokenize;__file__='/private/tmp/pip-build-t4Irzs/lxml/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-cRdv21-record/install-record.txt --single-version-externally-managed --compile --install-headers /Users/omaciel/.virtualenvs/splinter/include/site/python2.7/lxml:
    Building lxml version 3.6.4.
    Building without Cython.
    Using build configuration of libxslt 1.1.29
    Building against libxml2/libxslt in the following directory: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/lib
    running install
    running build
    running build_py
    creating build
    creating build/lib.macosx-10.12-intel-2.7
    creating build/lib.macosx-10.12-intel-2.7/lxml
    copying src/lxml/__init__.py -> build/lib.macosx-10.12-intel-2.7/lxml
    copying src/lxml/_elementpath.py -> build/lib.macosx-10.12-intel-2.7/lxml
    copying src/lxml/builder.py -> build/lib.macosx-10.12-intel-2.7/lxml
    copying src/lxml/cssselect.py -> build/lib.macosx-10.12-intel-2.7/lxml
    copying src/lxml/doctestcompare.py -> build/lib.macosx-10.12-intel-2.7/lxml
    copying src/lxml/ElementInclude.py -> build/lib.macosx-10.12-intel-2.7/lxml
    copying src/lxml/pyclasslookup.py -> build/lib.macosx-10.12-intel-2.7/lxml
    copying src/lxml/sax.py -> build/lib.macosx-10.12-intel-2.7/lxml
    copying src/lxml/usedoctest.py -> build/lib.macosx-10.12-intel-2.7/lxml
    creating build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/__init__.py -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    creating build/lib.macosx-10.12-intel-2.7/lxml/html
    copying src/lxml/html/__init__.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
    copying src/lxml/html/_diffcommand.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
    copying src/lxml/html/_html5builder.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
    copying src/lxml/html/_setmixin.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
    copying src/lxml/html/builder.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
    copying src/lxml/html/clean.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
    copying src/lxml/html/defs.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
    copying src/lxml/html/diff.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
    copying src/lxml/html/ElementSoup.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
    copying src/lxml/html/formfill.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
    copying src/lxml/html/html5parser.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
    copying src/lxml/html/soupparser.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
    copying src/lxml/html/usedoctest.py -> build/lib.macosx-10.12-intel-2.7/lxml/html
    creating build/lib.macosx-10.12-intel-2.7/lxml/isoschematron
    copying src/lxml/isoschematron/__init__.py -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron
    copying src/lxml/lxml.etree.h -> build/lib.macosx-10.12-intel-2.7/lxml
    copying src/lxml/lxml.etree_api.h -> build/lib.macosx-10.12-intel-2.7/lxml
    copying src/lxml/includes/c14n.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/config.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/dtdvalid.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/etreepublic.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/htmlparser.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/relaxng.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/schematron.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/tree.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/uri.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/xinclude.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/xmlerror.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/xmlparser.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/xmlschema.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/xpath.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/xslt.pxd -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/etree_defs.h -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    copying src/lxml/includes/lxml-version.h -> build/lib.macosx-10.12-intel-2.7/lxml/includes
    creating build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources
    creating build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/rng
    copying src/lxml/isoschematron/resources/rng/iso-schematron.rng -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/rng
    creating build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl
    copying src/lxml/isoschematron/resources/xsl/RNG2Schtrn.xsl -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl
    copying src/lxml/isoschematron/resources/xsl/XSD2Schtrn.xsl -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl
    creating build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
    copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_abstract_expand.xsl -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
    copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_dsdl_include.xsl -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
    copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_schematron_message.xsl -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
    copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_schematron_skeleton_for_xslt1.xsl -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
    copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_svrl_for_xslt1.xsl -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
    copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/readme.txt -> build/lib.macosx-10.12-intel-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
    running build_ext
    building 'lxml.etree' extension
    creating build/temp.macosx-10.12-intel-2.7
    creating build/temp.macosx-10.12-intel-2.7/src
    creating build/temp.macosx-10.12-intel-2.7/src/lxml
    cc -fno-strict-aliasing -fno-common -dynamic -arch x86_64 -arch i386 -g -Os -pipe -fno-common -fno-strict-aliasing -fwrapv -DENABLE_DTRACE -DMACOSX -DNDEBUG -Wall -Wstrict-prototypes -Wshorten-64-to-32 -DNDEBUG -g -fwrapv -Os -Wall -Wstrict-prototypes -DENABLE_DTRACE -arch x86_64 -arch i386 -pipe -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/libxml2 -Isrc/lxml/includes -I/System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c src/lxml/lxml.etree.c -o build/temp.macosx-10.12-intel-2.7/src/lxml/lxml.etree.o -w -flat_namespace
    cc -bundle -undefined dynamic_lookup -arch x86_64 -arch i386 -Wl,-F. build/temp.macosx-10.12-intel-2.7/src/lxml/lxml.etree.o -L/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/lib -lxslt -lexslt -lxml2 -lz -lm -o build/lib.macosx-10.12-intel-2.7/lxml/etree.so
    ld: file not found: /usr/lib/system/libsystem_darwin.dylib for architecture x86_64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    error: command 'cc' failed with exit status 1

    ----------------------------------------
Command "/Users/omaciel/.virtualenvs/splinter/bin/python -u -c "import setuptools, tokenize;__file__='/private/tmp/pip-build-t4Irzs/lxml/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-cRdv21-record/install-record.txt --single-version-externally-managed --compile --install-headers /Users/omaciel/.virtualenvs/splinter/include/site/python2.7/lxml" failed with error code 1 in /private/tmp/pip-build-t4Irzs/lxml/

@andrewsmedina
$ ./run_tests.py -w tests/test_flaskclient.py
.................................................................................................................................................................
----------------------------------------------------------------------
Ran 161 tests in 1.611s

OK

@omaciel thanks

@andrewsmedina thank you too! When should I expect a new version in pypi?


Get NGINX working properly

I didn't find it earlier, but there is a good guide with example config on in the gunicorn documentation.

This is a more or less fixed now. Just need to get the web uploader working, but that can be handled in a separate issue.


ENH Matt's Edits

This PR has my edits.

OK @CJ-Wright. This one is ready for review and merging once we are happy with it.

@beckermr this looks great! Some minor copyedit suggestions then I think this can go in!

done! ready to merge!


Only compatible with node 8.8.0

Because of coveralls#request#hawk which depends on hoek which enforces engine >=8.8.0
https://github.com/hapijs/hoek/blob/master/package.json#L11
In yarn this results actually in failures installing..
@diasdavid I believe we wanted to switch to codecov anyway so maybe we can drop coveralls?

This currently stops me from updating the version of aegir in borc, which in turn stops me from releasing a new version of borc :(

joi also causes the failure and the newest version of Aegir only supports >=8.9.

error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=8.9.0".

Coveralls have been dropped.
Please reopen the issue if it's still a problem.


The provided ScrollController is currently attached to more than one ScrollPosition.

This issue occur when change the date in DayView()  and scroll the calendar.

start getting it when I updated to 1.1.0 and in weekview calendar still rendered and scrolled fine but become not-clickable, for DayView seems working fine

Experiencing the same when using WeekView, version 1.1.0, any known workaround?

This happened to me


Add initial OSG 23 support (SOFTWARE-5628)

We have to use development instead of minefield since HTCSS packages aren't available in minefield (I think we need to add the HTCSS daily repos as an external repo?).

I added the external repos necessary to make minefield work. Here is what I did:
# how to add condor repos as external repos

for el in el8 el9
do
	for ser in 23.0 23.x
	do
		osg-koji add-external-repo htcondor-${ser}-${el}-daily https://research.cs.wisc.edu/htcondor/repo/${ser}/${el}/'$arch'/daily/
	done
done
# make note of the id in the "created external repo" messages

# now add the external repos to the development tags
for el in el8 el9
do
	for serrepo in 23.0,23-main 23.x,23-upcoming
	do
		IFS=, read ser repo <<<$serrepo
		osg-koji add-external-repo -t osg-${repo}-${el}-development htcondor-${ser}-${el}-daily
	done
done

# to set the merge_mode (necessary because 23-build inherits from 23-development)
# in koji db:
select * from tag_external_repos where external_repo_id in (60,61,62,63);
begin;
update tag_external_repos set merge_mode='bare' where external_repo_id in (60,61,62,63);
# check if everything is ok
commit;

# then remove the 10.x repos
for el in el8 el9
do
	for level in daily rc update release
	do
		osg-koji remove-external-repo htcondor-10.x-${el}-${level} --alltags
	done
done

# also deleted some of my experiments
osg-koji remove-target kojira-fake-osg-23-main-el8-release-plus-condor
osg-koji remove-tag osg-23-main-el8-release-plus-condor


Current Version Display

This PR adds a display of the current version and version currently selected on the show page for both response sets and questions. Please review how it looks and let me know any stylistic changes that should be made.
Make sure you have checked off the following before you issue your Pull Request:

[N/A] Added unit tests for new functionality
[x] Passed all unit tests using rails test with 90%+ coverage
[N/A] Added cucumber tests for any new functionality
[x] Passed all cucumber tests using bundle exec cucumber
[x] Passed overcommit hooks, including running all code through Rubocop
[N/A] If any database changes were made, run rake generate_erd to update the README.md

Closing because I accidentally request merge into master instead of dev branch


drivers: NXP LPSPI Async API broken

Tracking issue for what appears to be broken support for CONFIG_SPI_ASYNC in the lpspi driver.
west build -b mimxrt1024_evk -p always tests/drivers/spi/spi_loopback -DCONFIG_SPI_ASYNC=y
SPI_ASYNC is enabled by default for the spi_loopback test except that someone has apparently added
kconfig overlays to disable testing of the spi async api and disable this symbol for platforms with an LPSPI.

------ TESTSUITE SUMMARY START ------

SUITE FAIL -   0.00% [spi_loopback]: pass = 0, fail = 1, skip = 0, total = 1 duration = 0.221 seconds
 - FAIL - [spi_loopback.test_spi_loopback] duration = 0.221 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION FAILED

    Assertion failed at WEST_TOPDIR/zephyr/tests/drivers/spi/spi_loopback/src/spi.c:592: spi_async_call_cb: (ret is true)
one or more events are not ready
 ERROR: cannot fail in test phase 'teardown()', bailing

    Assertion failed at WEST_TOPDIR/zephyr/tests/drivers/spi/spi_loopback/src/spi.c:592: spi_async_call_cb: (ret is true)
one or more events are not ready
 ERROR: cannot fail in test phase 'teardown()', bailing

    Assertion failed at WEST_TOPDIR/zephyr/tests/drivers/spi/spi_loopback/src/spi.c:592: spi_async_call_cb: (ret is true)
one or more events are not ready
 ERROR: cannot fail in test phase 'teardown()', bailing

This is also failing for mr_canhubk3 board, only when used together with DMA:
west build -p -b mr_canhubk3 tests/drivers/spi/spi_loopback -T drivers.spi.loopback.lpspi.dma


Replace all old Select Modal with new Select Modal

[x] Receive:

[x] Select Account
[x] Select Token

[x] Buy:

[x] Select Account
[x] Select Token

[x] Home:

[x] Select Token
[x] Customize

[x] Manage account:

[x] Import Account
[x] Create Account
[x] Attach Account

[x] Flatlist screen: Filter

[x] Stake Actions

[x] Stake
[x] Unstake
[x] Withdraw
[x] Cancel Unstake
[x] Claim reward

[x] Import network

[x] Import token

[x] Import NFT

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-192-864-merge-2023-07-06T10-39-40.ipa
Devices test: IP 11
Validation passed.

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-199-895-merge-2023-07-14T04-19-55.ipa
@Quangdm-cdm Please re-check:

[ ] Create a new account

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-199-895-merge-2023-07-14T11-09-39.ipa
Devices test: IP 11
Validation passed.


7 New renderers

Hello,
First of all thanks for the benchmark, it was really helpfull to see all the libraries available, how they can be used to implements the cubes benchmark and how they perform.
On my fork I regrouped fork from others contributor that included different libraries and added 2 new libraries. This was useful for my comparison, and I was thinking why not share it back to the community.
This PR contains :

7 new renderer : Mesh.js, ZRender, CanvasKit, Pts, Easeljs, svgjs and also a Dom version
Readme reformatted as a table to show all libraries
Konva, Fabrics, Paper now use requestAnimationFrame
Pixi has a hdpi option that can be used if we uncomment it (performance aren't as good ofc)

@Enzuo whoa, that's a lot of work, thank you!
We'll review the changes this week. 👍

@Enzuo Thank you for this PR! That's quite a lot of work.
Do you think there can any further be improvements to it? Other examples maybe?


Workload VM in 'RunContainerError' state after Kubernetes cluster reboot

I am running a kubernetes cluster (single node) with virtlet running on a VM (say A). I am able to run VMs and virtlet example for ubuntu-vm (say B).
However, when I reboot my VM (A), all kubernetes services recover and become available. However, the VM (B) I had deployed, remains in the status 'RunContainerError'. Here is a sample describe pod output when this happens -
  Warning  Failed   19s               kubelet, kubemaster  Error: "/run/virtlet.sock": rpc error: code = 2 desc = failed to create domain "b3c4e0f9-1184-5394-6dee-fb381ca95c45": virError(Code=1, Domain=10, Message='internal error: process exited while connecting to monitor: I1016 15:42:14.853945    6474 vmwrapper.go:66] Obtaining PID of the VM container process...
E1016 15:42:14.854254    6474 vmwrapper.go:89] Failed to obtain tap fds for key "b8b9cbfe-d153-11e8-870e-0050563d373c": server returned error: bad fd key: "b8b9cbfe-d153-11e8-870e-0050563d373c"')
  Normal  Pulled  6s (x9 over 1m)  kubelet, kubemaster  Container image "virtlet.cloud/ubuntu" already present on machine

I have the same problem https://github.com/Mirantis/virtlet/issues/786.
I deployed virtlet on a single-node kubenertes cluster.
After creating a vm in k8s,it works fine , and the instance file is in the directory /var/lib/virtlet:
ll /var/lib/virtlet/volumes/ -hs
4.0K drwxr-xr-x 2 root root 4.0K October 17 16:08 ./
4.0K drwxr-xr-x 5 root root 4.0K October 17 16:13 ../
20M -rw------- 1 64055 syslog 20M October 17 16:17 virtlet_root_7bfdd7f7-347b-5ed1-60b3-81cfc72ab1ba
but when i reboot the k8s node ,the vm files in the /var/lib/virtlet/volumes/ directory are missing:
ll /var/lib/virtlet/volumes/ -hs
4.0K drwxr-xr-x 2 root root 4.0K 10月 17 16:19 ./
4.0K drwxr-xr-x 5 root root 4.0K 10月 17 16:18 ../


Data series missing in bar chart for 100% zoom

There seems to be a rendering issue with bar charts (both horizontal and vertical) at 100% browser zoom. At least one series is not visible when it renders. However, on increasing zoom, the missing series shows up. The missing series also shows up if any on of the other series is deselected from the legend.
This problem is observed of Chrome(39.0.2171.95 m) and Firefox(28.0 and 38.0.6). It is working fine for IE11.
c3.js version is 4.11
Snapshot attached below for reference. Green and Violet series are missing even though their values should are high enough for the bars to be visible.

I ran into this issue as well - the resolution was to remove my space option.
, bar: {
  space: 0.25,
}


Do not rescue all errors for redis backed stores

It is a very bad idea to rescue all redis errors (including errors for invalid commands). We can't know when we messed things up in code, because all errors will be silently swallowed. It is better to rescue only connection-related errors. RedisCacheStore already rescues connection errors, so no need to do it manually.

Nice find. I agree.
Thank you!

Released in v6.3.0.

Hey @fatkodima @grzuy 👋
This PR re-introduces a problem which was fixed in https://github.com/kickstarter/rack-attack/pull/421
How's one supposed to handle a CommandError exception? For example, if the connection is ok but Redis is busy loading the database into memory, it'll return a -LOADING response which will raise a CommandError in the application. What is the best way to handle such errors when they bubble up?

Hey @fatkodima @grzuy wave
This PR re-introduces a problem which was fixed in #421
How's one supposed to handle a CommandError exception? For example, if the connection is ok but Redis is busy loading the database into memory, it'll return a -LOADING response which will raise a CommandError in the application. What is the best way to handle such errors when they bubble up?

Hi @cristiangreco,
Yes, we had some back and forth with that. Sorry for any inconvenience.
Can you please open an issue reporting what see it's happening in the latest version vs what you expect to happen so that we can discuss there, others chime in, and have a decision on what we want to do?
Thanks in advance!