Javascript: add hint to Use Multiple Conditional (Ternary) Operators

Add hint to Use Multiple Conditional (Ternary) Operators (https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/use-multiple-conditional-ternary-operators/ and https://guide.freecodecamp.org/certifications/javascript-algorithms-and-data-structures/basic-javascript/use-multiple-conditional-ternary-operators/)

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@greggubarev Thanks for the many great articles for these challenges.
Just a quick note - the
-------
title
-------

at the top is necessary for Gatsby to properly parse the article, so please be careful not to delete it (I just added it back in for you).

Ok, thank you!


Simple validation - Add support for log EIP #197

@devsclaus we have reached pr nr 200. Let's celebrate this afternoon with a beer😊🍺

Yep was just told the neighbors will come by for a beer. We have some x-mas beers left.


[MM-33989] Show bindings in all threads and post menus

Summary
No Apps currently have any channel-specific bindings. This PR makes it so we are no longer hiding bindings in threads and post menus. This includes commands and post menu items.
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-33989
Awaiting merge of feature/cloud-apps -> master https://github.com/mattermost/mattermost-mobile/pull/5226

Building app in separate branch.

Building app in separate branch.

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/14538
https://circleci.com/gh/mattermost/mattermost-mobile/14537

Artifact links:
https://14538-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.apk
https://14537-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.ipa

@mickmister I have tested this on iOS and Android and the bindings now display in threads when a post is long pressed making it consistent with when the slash command bindings are shown.
One thing  to follow up on here is with ephemeral post made by MM Apps. Theses posts will always show as new root posts and not replies. I'm not sure if this is something that would still need to be implemented but the current UX is not ideal.

Open a thread of replies such that the main thread is no longer visible.
Long press one of the posts
Use an app such as http-hello or Service Now to perform an action where the app makes a system post to provide feedback
Observed: System post is not visible. It is created in the main thread and I must close the reply thread to see it.

@DHaussermann Ran the detox suite against this PR and didn't see any issues related to it. There were failing tests locally but those were expected.

I addressed Dylan's comment about ephemeral messages in the last commit

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/14555
https://circleci.com/gh/mattermost/mattermost-mobile/14554

Artifact links:
https://14555-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.ipa
https://14554-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.apk

@mickmister this is strange as I still see the same behavior where the post is made as a new root post in the channel and not the reply thread.
I used builds from this post here https://github.com/mattermost/mattermost-mobile/pull/5232#issuecomment-804953881

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/14584
https://circleci.com/gh/mattermost/mattermost-mobile/14583

Artifact links:
https://14584-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.ipa
https://14583-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.apk

I have tested this and the issue described is resolved.
However, I also notice that the binding in the post menu are now visible in things such as saved posts, search results and pinned posts.
@aaronrothschild I'm not sure if this should be the case here. Previously these posts would not show the bindings I thought this was the expected behavior. Any thoughts on this?


fix: toast styling

Coverage remained the same at 87.767% when pulling 40fa40b991f78d0b44b8e1895d4efd5c44e9e4ea on ciduarte/toast-fix into 2bcb16e6374a6900223de97c7d4d2d6c103631b3 on master.

:tada: This PR is included in version 12.0.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


pathpol: Add Policy to PathReq and SegReq capnp

Adds low and mid-level objects to represent path-policies.
Contributes #2816
Contributes #2817

This change is

It's not yet clear we will need this in the near future, so we close it for now.


Atom and Brackets AppImages are out-of-date

Hi,
I was hoping that bintray.com would have a "flag package out of date" option like the Arch User Repository (https://aur.archlinux.org) has, but as it doesn't I'll have to report that Atom 1.9.9 is presently the latest stable version of Atom (as opposed to 1.9.8, which is presently the latest an AppImage is built) and Brackets 1.6 isn't the latest version of Brackets available, 1.7 is.
Thanks for your time,
Brenton

Builds triggered.

Thanks, oh I should also mention that the latest Geany is 1.28 not 1.24.1.

Keep in mind that this entire repository is essentially just showcases for AppImage, the real objective is for the upstream projects to provide AppImages (like MuseScore, Scribus, Krita, KDevelop, Etcher and others already do). So if you are indeed interested in the latest and greatest, it would be best to convince the upstream application projects to provide AppImages, ideally as part of their CI pipeline (like MuseScore, for example, does).


Add build instructions?

I am quite interested by the B compiler, but couldn't find a way to compile/interpret/whatever the .bmx files. Please add build instructions, if you have the time, it would make everything clearer.

Done. .bmx is BlitzMax, created by Mark Sibly. At the time I originally uploaded YBC it wasn't open source, but it has since been released and you can find it on GitHub too. There's an alternative implementation here as well, but I haven't tested it with that one.
BlitzMax tries to manage building internally as far as possible, which is why there are no makefiles or anything like that: the actual build instructions are basically "compile ybc.bmx".


Add timezone mount to bootstrap

[x] Update checksum
[x] Test on device

@matteodelabre looks like the label check hasn't properly reported it's status?

@matteodelabre looks like the label check hasn't properly reported it's status?

Looks like you made your PR against stable, so it’s using the workflow files from that branch, which do not include the pr-labels workflow yet.

Looks like you made your PR against stable, so it’s using the workflow files from that branch, which do not include the pr-labels workflow yet.

Fixing this requires rebasing your branch on testing, so I’ll let you do that.

Fixing this requires rebasing your branch on testing, so I’ll let you do that.

Looks like I'll have to fix this up and recreate it. We should probably merge stable into testing every so often to make it easier to rebase when we accidentally do this.

Looks like I'll have to fix this up and recreate it. We should probably merge stable into testing every so often to make it easier to rebase when we accidentally do this.

@matteodelabre Okay, fixed

@matteodelabre Okay, fixed

Thanks @Eeems! I wanted to test your changes but I ran into this error which seems to have been introduced before your PR.

Thanks @Eeems! I wanted to test your changes but I ran into this error which seems to have been introduced before your PR.

Turns out systemd refuses to enable the bind mount unless it’s named after the target path (so usr-share-zoneinfo.mount). I changed that and also made sure that the new unit is cleaned up in error-cleanup().

Turns out systemd refuses to enable the bind mount unless it’s named after the target path (so usr-share-zoneinfo.mount). I changed that and also made sure that the new unit is cleaned up in error-cleanup().

Well spotted. Not sure how I missed that during testing, I must have used a version where I hadn’t made the change yet.

Well spotted. Not sure how I missed that during testing, I must have used a version where I hadn’t made the change yet.

@raisjn could you test on your rM2?

@raisjn could you test on your rM2?

Test scenarios:

Test upgrading the toltec-boostrap package
Run bootstrap on existing install
Run entware-reenable on existing install where it's disabled
Run entware-reenable on existing install where it's already enabled
Run bootstrap on device without entware/toltec

Test scenarios:

Test upgrading the toltec-boostrap package
Run bootstrap on existing install
Run entware-reenable on existing install where it's disabled
Run entware-reenable on existing install where it's already enabled
Run bootstrap on device without entware/toltec

on rM 2 in order of testing:

Run bootstrap on device without entware/toltec » :heavy_check_mark:
Run bootstrap on existing install » :heavy_check_mark:
Run entware-reenable on existing install where it's disabled » :x: see logs below
Run entware-reenable on existing install where it's already enabled » :x: see same logs below

reMarkable: ~/ bash eetest
Downloading https://bin.entware.net/armv7sf-k3.2/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/entware
Downloading https://toltec-dev.org/testing/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/toltec
eetest: command substitution: line 75: syntax error near unexpected token `|'
eetest: command substitution: line 75: `| uniq)'

Test upgrading the toltec-boostrap package » (:heavy_check_mark:) Worked but also triggered a re-installation of entware for me.

on rM 2 in order of testing:

Run bootstrap on device without entware/toltec » :heavy_check_mark:
Run bootstrap on existing install » :heavy_check_mark:
Run entware-reenable on existing install where it's disabled » :x: see logs below
Run entware-reenable on existing install where it's already enabled » :x: see same logs below

reMarkable: ~/ bash eetest
Downloading https://bin.entware.net/armv7sf-k3.2/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/entware
Downloading https://toltec-dev.org/testing/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/toltec
eetest: command substitution: line 75: syntax error near unexpected token `|'
eetest: command substitution: line 75: `| uniq)'

Test upgrading the toltec-boostrap package » (:heavy_check_mark:) Worked but also triggered a re-installation of entware for me.

We also may want to trigger the timezone check when updating the toltec-bootstrap package. Haven't checked whether this is already done.

We also may want to trigger the timezone check when updating the toltec-bootstrap package. Haven't checked whether this is already done.

* Run entware-reenable on existing install where it's disabled » x see logs below
* Run entware-reenable on existing install where it's already enabled » x see same logs below

reMarkable: ~/ bash eetest
Downloading https://bin.entware.net/armv7sf-k3.2/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/entware
Downloading https://toltec-dev.org/testing/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/toltec
eetest: command substitution: line 75: syntax error near unexpected token `|'
eetest: command substitution: line 75: `| uniq)'

Interesting. I re-ran entware-reenable on my rM1 in both scenarios and I don’t get any error. Can you confirm that we have the same entware-reenable script? Mine has a SHA-256 sum of 701173003cda882067d97d2f7f9fb8a18d2c17ac888e9646dee5acda3f34ae67. Can you also provide us with the Bash version that’s running on the rM2? On rM1, I have 4.4.12(1).

* Test upgrading the toltec-boostrap package » (heavy_check_mark) Worked but also triggered a re-installation of entware for me.

I don’t think just upgrading toltec-bootstrap should trigger the reenable script, since the package itself doesn’t contain any install script. Can you confirm @Eeems?

* Run entware-reenable on existing install where it's disabled » x see logs below
* Run entware-reenable on existing install where it's already enabled » x see same logs below

reMarkable: ~/ bash eetest
Downloading https://bin.entware.net/armv7sf-k3.2/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/entware
Downloading https://toltec-dev.org/testing/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/toltec
eetest: command substitution: line 75: syntax error near unexpected token `|'
eetest: command substitution: line 75: `| uniq)'

Interesting. I re-ran entware-reenable on my rM1 in both scenarios and I don’t get any error. Can you confirm that we have the same entware-reenable script? Mine has a SHA-256 sum of 701173003cda882067d97d2f7f9fb8a18d2c17ac888e9646dee5acda3f34ae67. Can you also provide us with the Bash version that’s running on the rM2? On rM1, I have 4.4.12(1).

* Test upgrading the toltec-boostrap package » (heavy_check_mark) Worked but also triggered a re-installation of entware for me.

I don’t think just upgrading toltec-bootstrap should trigger the reenable script, since the package itself doesn’t contain any install script. Can you confirm @Eeems?

I don’t think just upgrading toltec-bootstrap should trigger the reenable script, since the package itself doesn’t contain any install script. Can you confirm @Eeems?

Correct, this shouldn't happen.

on rM 2 in order of testing:
* Run bootstrap on device without entware/toltec » heavy_check_mark

* Run bootstrap on existing install » heavy_check_mark

* Run entware-reenable on existing install where it's disabled » x see logs below

* Run entware-reenable on existing install where it's already enabled » x see same logs below

reMarkable: ~/ bash eetest
Downloading https://bin.entware.net/armv7sf-k3.2/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/entware
Downloading https://toltec-dev.org/testing/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/toltec
eetest: command substitution: line 75: syntax error near unexpected token `|'
eetest: command substitution: line 75: `| uniq)'

* Test upgrading the toltec-boostrap package » (heavy_check_mark) Worked but also triggered a re-installation of entware for me.

Line 75 is echo -e "${packages[@]}\n${available_packages[@]}" | sed 's/ /\0/g' | sort | uniq -d | awk '{print $1}' | xargs -r opkg install --force-reinstall, which is a line I didn't touch. It also looks good to me. Perhaps $available_packages and $packages are empty?

I don’t think just upgrading toltec-bootstrap should trigger the reenable script, since the package itself doesn’t contain any install script. Can you confirm @Eeems?

Correct, this shouldn't happen.

on rM 2 in order of testing:
* Run bootstrap on device without entware/toltec » heavy_check_mark

* Run bootstrap on existing install » heavy_check_mark

* Run entware-reenable on existing install where it's disabled » x see logs below

* Run entware-reenable on existing install where it's already enabled » x see same logs below

reMarkable: ~/ bash eetest
Downloading https://bin.entware.net/armv7sf-k3.2/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/entware
Downloading https://toltec-dev.org/testing/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/toltec
eetest: command substitution: line 75: syntax error near unexpected token `|'
eetest: command substitution: line 75: `| uniq)'

* Test upgrading the toltec-boostrap package » (heavy_check_mark) Worked but also triggered a re-installation of entware for me.

Line 75 is echo -e "${packages[@]}\n${available_packages[@]}" | sed 's/ /\0/g' | sort | uniq -d | awk '{print $1}' | xargs -r opkg install --force-reinstall, which is a line I didn't touch. It also looks good to me. Perhaps $available_packages and $packages are empty?

Interesting. I re-ran entware-reenable on my rM1 in both scenarios and I don’t get any error. Can you confirm that we have the same entware-reenable script? Mine has a SHA-256 sum of 701173003cda882067d97d2f7f9fb8a18d2c17ac888e9646dee5acda3f34ae67. Can you also provide us with the Bash version that’s running on the rM2? On rM1, I have 4.4.12(1).

Line 75 is echo -e "${packages[@]}\n${available_packages[@]}" | sed 's/ /\0/g' | sort | uniq -d | awk '{print $1}' | xargs -r opkg install --force-reinstall, which is a line I didn't touch. It also looks good to me. Perhaps $available_packages and $packages are empty?

Got the problem. My fault. I took the latest file from here, but copy&pasted the content into nano which made a long line wrap. If I fix that the file matches with your hash, Mattéo.
That was my change. Makes sense that the command didn't work:
72,73c72
<     available_packages=$(gunzip -c /opt/var/opkg-lists/* | grep -E '(Package:)|(Version:)' | sed 's|Package: ||' | tr '\n' ' ' | sed -r 's| Version: ([^ ]+) | \1\n|g' | sort
< | uniq)
---
>     available_packages=$(gunzip -c /opt/var/opkg-lists/* | grep -E '(Package:)|(Version:)' | sed 's|Package: ||' | tr '\n' ' ' | sed -r 's| Version: ([^ ]+) | \1\n|g' | sort | uniq)

I re-tested:

Run entware-reenable on existing install where it's disabled
Run entware-reenable on existing install where it's already enabled

For my test, I had remux installed, disabled opt.mount and usr-share-zoneinfo.mount and removed these unit files as well. The first reenable didn't reinstall remux to add the file again. I added rm2fb and installed remux (which was listed as removed?). After that I ran the second test and it reinstalled remux and rm2fb.
I would say this is not an issue with this specific PR, but entware-reenable might not reinstall if the firmware gets updated and disables toltec/entware.

Interesting. I re-ran entware-reenable on my rM1 in both scenarios and I don’t get any error. Can you confirm that we have the same entware-reenable script? Mine has a SHA-256 sum of 701173003cda882067d97d2f7f9fb8a18d2c17ac888e9646dee5acda3f34ae67. Can you also provide us with the Bash version that’s running on the rM2? On rM1, I have 4.4.12(1).

Line 75 is echo -e "${packages[@]}\n${available_packages[@]}" | sed 's/ /\0/g' | sort | uniq -d | awk '{print $1}' | xargs -r opkg install --force-reinstall, which is a line I didn't touch. It also looks good to me. Perhaps $available_packages and $packages are empty?

Got the problem. My fault. I took the latest file from here, but copy&pasted the content into nano which made a long line wrap. If I fix that the file matches with your hash, Mattéo.
That was my change. Makes sense that the command didn't work:
72,73c72
<     available_packages=$(gunzip -c /opt/var/opkg-lists/* | grep -E '(Package:)|(Version:)' | sed 's|Package: ||' | tr '\n' ' ' | sed -r 's| Version: ([^ ]+) | \1\n|g' | sort
< | uniq)
---
>     available_packages=$(gunzip -c /opt/var/opkg-lists/* | grep -E '(Package:)|(Version:)' | sed 's|Package: ||' | tr '\n' ' ' | sed -r 's| Version: ([^ ]+) | \1\n|g' | sort | uniq)

I re-tested:

Run entware-reenable on existing install where it's disabled
Run entware-reenable on existing install where it's already enabled

For my test, I had remux installed, disabled opt.mount and usr-share-zoneinfo.mount and removed these unit files as well. The first reenable didn't reinstall remux to add the file again. I added rm2fb and installed remux (which was listed as removed?). After that I ran the second test and it reinstalled remux and rm2fb.
I would say this is not an issue with this specific PR, but entware-reenable might not reinstall if the firmware gets updated and disables toltec/entware.

I would say this is not an issue with this specific PR, but entware-reenable might not reinstall if the firmware gets updated and disables toltec/entware.

Should we try to fix it as part of this, or as part of a different PR?

I would say this is not an issue with this specific PR, but entware-reenable might not reinstall if the firmware gets updated and disables toltec/entware.

Should we try to fix it as part of this, or as part of a different PR?

I would say this is not an issue with this specific PR, but entware-reenable might not reinstall if the firmware gets updated and disables toltec/entware.

Should we try to fix it as part of this, or as part of a different PR?

Ok, scratch that as well. Redid the test with faking a fw update and now it worked fine. Not sure what I missed in the last test.

I would say this is not an issue with this specific PR, but entware-reenable might not reinstall if the firmware gets updated and disables toltec/entware.

Should we try to fix it as part of this, or as part of a different PR?

Ok, scratch that as well. Redid the test with faking a fw update and now it worked fine. Not sure what I missed in the last test.


Validate Data documentation issue

Rasa version: 1.6.1
Rasa SDK version (if used & relevant):1.6.1
Rasa X version (if used & relevant):
Python version:3.6.9
Operating system (windows, osx, ...):ubuntu18.04
Issue:I am currently using the rasa nlu component alone. My application involves a third party user uploading their nlu.md file. I would like to validate it. I am using rasa=1.6.1 As per the documentation,it says Validator class has from_files() method [ https://rasa.com/docs/rasa/user-guide/validate-files/ ], but thats not the case when I checked the rasaHQ github page Latest rasa validator.py
https://github.com/RasaHQ/rasa/blob/master/rasa/validator.py
Error (including full traceback):
Traceback (most recent call last):
  File "valid_rasa.py", line 9, in <module>
    validator = Validator.from_files(
AttributeError: type object 'Validator' has no attribute 'from_files'

Command or request that led to error:
import logging
from rasa import utils
from rasa.core.validator import Validator

logger = logging.getLogger(__name__)

# utils.configure_colored_logging('DEBUG')

validator = Validator.from_files(
                                 nlu_data='data/nlu.md'
                                 )

validator.verify_all()

Content of configuration file (config.yml) (if relevant):

Content of domain file (domain.yml) (if relevant):

Thanks for the issue, @wochinge will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

@rohithch21 Thanks for brining this up! The documentation seems to be outdated here.
Instead you have to use Validator.from_importer which expects an instance of the importer class (https://rasa.com/docs/rasa/api/training-data-importers/) . By the way, you can also use the command line interface to validate the data (rasa data validate)

related to https://github.com/RasaHQ/rasa/issues/6070


/block and /block/transactions staking support

Description
Block endpoint already returns transaction operations related to input and outputs although deposits and withdrawals have been introduced later on cardano-db-sync. The goal of this ask is to be able to support such information.
Withdrawals
Withdrawals are stored in withdrawal table and are linked to tx by withdrawal.tx_id. A new operation to represent withdrawal should be introduced.
Ideally, 3 kind of operations will need to be represented:

The system paying the rewards to the stake accounts incrementing the stored value.
The value decreasing operation on the stake account when the funds are move away from the ledger state
A value incrementing operation assigning the new balance to the unspent to be created when withdrawing.

As rewards are paid at the same block it would be impossible return them. We can page transactions if a block has many of them but we cannot page transaction operations. That being said, we won't be able to generate (1) therefore (2) will result in a rosetta-cli error which cannot be recovered yet (there is something called BalanceExceptions but that will not work for our use case yet, Coinbase team is thinking about this). That being said, we won't be introducing a negative amount operation but we will put it in the metadata section. See this thread for more info.
Note: the following example is based on this transaction.
{
  operation_identifier: {
    index: 2 // Real index should be used
  },
  type: operationType.WITHDRAWAL,
  status: 'success',
  account: {
    address: 'stake1u92c70hqnvnd3rav9mwuwu4fak55enndhtd7nlhy8x7kqqgav37kp'
  },
  metadata: {
    amount: {
      value: '-14520198574',
      currency: {
        symbol: 'ADA',
        decimals: 6
      }
    }
  }
}

Steps to introduce this change:

Update src/server/models.ts#TransactionWithInputsAndOutputs to include withdrawals as well. Please rename it to something more meaningful, maybe something related to the amount of data the transaction holds, like PopulatedTransaction or similar.
Update src/server/db/blockchain-repository.ts#fillTransaction  to also populate withdrawals as it's done with inputs and outputs. Consider using this query as it seems to be the one we need but for a single transaction hash.
Update src/server/utils/data-mapper.ts#mapToRosettaTransaction to include withdrawal operations:

They must be appended after the inputs, i.e., first index should be latest input index + 1 (fist output index should be latest withdrawal index + 1)
All outputs should depend on withdrawals as well so output.related_operations should all the inputs and withdrawal ids

Testing
We introduced db-snapshot testing to make it easier to test with real data and look for weird cases as well (genesis, etc) but if we wanted to do the same with real withdrawals our snapshot db would be huge to be pushed to a repository (> 2GB as opposed to a few MB) because the first block where a real withdrawal is around 4.5M.
That being said, there are different tests that we need to do:

Check our e2e suite is still working (no actions needed)
Add new tests to the current ones. To do so, we will need to manually insert a fake block in the DB with proper withdrawal information. Using the before mentioned transaction and block is strongly recommended

That can be done in test/e2e/jest-setup/jest-setup.ts after setupPostgresContainer for example

We need to be make sure rosetta-cli check:data still works

Deploy the new version (using the commit as build context for docker) on our mainnet testing server.
Execute check:data for a block range containing block 4512070.
Execute check:data for the whole chain. This test is going to fail as reconciliation for staking address is going to fail.

Deposits
Transactions have a field name deposit (that goes ot a common pot). If a transaction contains a non-zero deposit value, a new operation needs to be created to represent that:
Note: the following example is based on this transaction.
{
  operation_identifier: {
    index: 2 // Real index should be used
  },
  type: operationType.STAKE_KEY_REGISTRATION,
  status: 'success',
  amount: {
    value: '2000000',
    currency: {
      symbol: 'ADA',
      decimals: 6
    }
  }
}

Steps to introduce this change:

Update src/server/models.ts#Transaction to include a deposit field.
Update src/server/utils/data-mapper.ts#mapToRosettaTransaction to create the operation in case transaction deposit is not zero

Testing
New data should be inserted in order to create a transaction with deposit (as it's likely that there won't be any for our snapshot db).

Check our e2e suite is still working (no actions needed)
Add new tests to the current ones. To do so, we will need to manually insert a fake block in the DB with proper withdrawal information. This transaction and block is strongly recommended.
We need to be make sure rosetta-cli check:data still works

Deploy the new version (using the commit as build context for docker) on our mainnet testing server.
Execute check:data for a block range containing block 4490544.
Execute check:data for the whole chain. This test is going to fail if withdrawals are introduced.

Implemented here https://github.com/input-output-hk/cardano-rosetta/pull/215


Test "TXT register space accessible" should not check if HeapBase is 0

It looks like HeapBase is left 0 if firmware doesn't do TXT initialisation. However the TXT space is accessible in that case as it doesn't read as ~0, so the test should return success.

So remove this check completly?

maybe there's another non-zero field that can be tested instead TXT.PUBLIC.KEY maybe?

I think the error comes from strict devmem case

I think the error comes from strict devmem case

that should generate an internal error

#158 Addresses this issue


Remote captive core setup documentation on website out of date

What version are you using?
Horizon 2.14
Go 1.17
What did you do?
Follow the documentation steps to setup Remote Captive Core: https://developers.stellar.org/docs/run-api-server/remote-core/
What did you expect to see?
Expected everything to work out of the box.
What did you see instead?
Everything went well until running the command to start the captive core.
From the documentation:
stellar-captive-core-api
--stellar-core-binary-path=$(which stellar-core)
--captive-core-config-append-path=/etc/default/stellar-captive-core-stub.toml
--history-archive-urls="https://history.stellar.org/prd/core-testnet/core_testnet_001"
--port=8001
Error:
Error: unknown flag: --captive-core-config-append-path
Command that worked for me:
stellar-captive-core-api --stellar-core-binary-path=$(which stellar-core) --captive-core-config-path "/home/ubuntu/stellar-captive-core.cfg" --history-archive-urls="[urls omitted here]" --port=8001
It seems the website docs are out of date?

Remote captive-core has been deprecated


output window not scrolling to bottom

Version 1.10.0-insider
Commit b7dc5cd88bd76d368db5b7c9972c088f533e2bfd
Date 2017-02-15T15:35:32.349Z
Shell 1.4.6
Renderer 53.0.2785.143
Node 6.5.0
OS: ubuntu 16.04
Steps to Reproduce:

Run a tasks.json command
watch the output window

There are other reports about "autoscroll to bottom". My output window is auto scolling, but it doesn't scroll to far enough to show the final line, the final line being very important when my command finishes (I like to && echo done after my build scrips), and the final "done" is below the final visible line, behind the status bar of the window (floating window or fullscreen)

but if i manually scroll to the end

This happens on every build, even if I put the cursor in the output window and control-home (the cursor is quickly removed from focus, and the window doesn't continue to hold to the end (enough, but partially). If I wait until the task completes and put the cursor in the window and press ^home, i DO see the full text.
Also I understand that I can view the spinning task notification:

But I do prefer to see the final line of my builds
One solution is to add some empty newlines to my makefiles

even in zen mode i dont see the final line

AH, when the task complete, the window appears to bounce back up near the top
Maybe this is more like the other bug reports about not holding an autoscroll behavior

hmm, it might be an issue with short tasks, I just finished a very long output command that DID show the final line

@payonel  Output now always autoscrolls - unless you enable the scroll lock action.
If you can constantly reproduce this can you please provide steps so we can further investigate?
For instance you could create a small repository on github for which we could reproduce this behavior and then fix the issue.
When the last line is not revelead - can you manually scroll in order to reveal it?

I noticed the lock icon, but my output is not locked
repro is consistent, but there seems to be a dependency on the length (# of lines) of the output to hit this.
I'll update later for fine grain details on repro

Great - looking forward to repro steps

Reopening once we get repro steps.

Sorry! got busy.
Easy repro
tasks.json
{
    "version": "0.1.0",
    "command": "./script.sh",
    "isShellCommand": true,
    "args": [],
    "showOutput": "always"
}

script.sh
for n in $(seq 1 20); do
    echo $n
done

output window:

note the position of the scroll bar, and the unlocked scroll

Thanks, reopening and assinging to march to investigate then

does not repro in latest
Version 1.10.0-insider
Commit 40fecfaa77f01672e8a147be71f6f7ccb9cf8a12
Date 2017-02-27T14:13:35.653Z
Shell 1.4.6
Renderer 53.0.2785.143
Node 6.5.0

@payonel thanks for checking it because I tried reproing 2 days ago and was having a hard time.


fixed ISR example

fixed a bug in the callback function
used meaningful variable names
added better comments

Thanks for the fixes. That sample (along with most of the other IoT samples and templates) are receiving a significant refresher that will make this existing version of the app obsolete. I'll accept your pull request, but please be aware that it will be wiped out when that major update occurs.


Added search to docs

Added search through Pagefind
Created doc dialog system
Moved navigation drawer to dialog system
Fixed navigation drawer not opening bug

pnpm check currently fails due to a bug in vite-plugin-svelte:  https://github.com/sveltejs/vite-plugin-svelte/pull/912
Once this PR is released check should pass again.

pnpm check currently fails due to a bug in vite-plugin-svelte: sveltejs/vite-plugin-svelte#912
Once this PR is released check should pass again.

This is now fixed 👍

I've patched up the look and feel to make it in general more consistent.
I've moved SearchDialog to /Dialog.
Portal and Dialog components are not touched because not only the Search depends on them (also the drawer). So putting them in a Search folder is incorrect.

idle:

typing:

no results:

hover/focus state:

mobile view:


Cleanup Bazel workarounds for gRPC and apple_rules

gRPC 1.60.x does not compile out of the box with Bazel v7.  Bazel v7 requires a newer version of apple_rules than what gRPC uses.
We can override the version of apple_rules, but that requires some careful initialization of the C++ toolchain.
Alternatively, it would be nice if gRPC did not require these rules when compiling only C++ targets.
None of these things are true now, but once either becomes true we can remove the code overriding and initializing apple_rules from our project.

Need to check if gRPC has resolved their portion of this issue.


Checks for variable mismatches between values.py and other files (and/or a more informative error message)

I found that my values.py file didn't copy over, so I was stuck with the default.  I was shown "openpilot unavailable waiting for controls to start".
I was able to reliably reproduce this error message:

/data/openpilot/selfdrive/car/[BRAND]/values.py is perfectly configured for the candidate car.
Have a fingerprint and/or firmware version(s) successfully detected by the comma2 when starting the car.
In values.py have the class CAR not match other files.

For a Sonata, for example, open values.py and comment out the FPv1 and FPv2 fingerprints, save, reboot comma2, start car.  All is fine and dashcam mode for an unsupported car is shown, as expected.
Uncomment the FPv1 and FPv2 fingerprints in values.py, change all references of class CAR "SONATA" to "SONATA_ERROR", save, reboot comma2, start car, see "openpilot unavailable waiting for controls to start".
In other scenarios, such as changing all but one class CAR instance of "SONATA" in values.py, OpenPilot fails to start with a syntax error which I guess could be intended, but at least it's more informative.
Unless there's actually another known situation which can cause this, maybe there could be a more informative error message in which OP/comma2 successfully fingerprints a car but the problem is still with the syntax consistency.  I've seen a few mentions of this in other forks on Discord, so my guess is it's just a small typo that the authors may not easily notice if their car isn't the one with the problem.

Although this is a dev kit, we intentionally don't show much debugging information in the onroad UI. The only reason a regular user would see the "Waiting for controls to start" alert is if controlsd crashed, which is extremely uncommon. The full traceback is in the logs and available when you SSH into your device.

Although this is a dev kit, we intentionally don't show much debugging information in the onroad UI. The only reason a regular user would see the "Waiting for controls to start" alert is if controlsd crashed, which is extremely uncommon. The full traceback is in the logs and available when you SSH into your device.


Support for redux and Graphql

Is this a bug report?
(write your answer here)

Did you try recovering your dependencies?

(Write your answer here.)
Which terms did you search for in User Guide?

(Write your answer here if relevant.)
Environment

(paste the output of the command here)
Steps to Reproduce

(Write your steps here:)

Expected Behavior

(Write what you thought would happen.)
Actual Behavior

(Write what happened. Please add screenshots!)
Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

Add info for Grphql and redux as well

Why? State management is highly opinionated and "personal preference". True about GraphQL too.
At best, perhaps we should have a blurb in the docs that says something like "create-react-app does not dictate how you - if at all - do global state management. We, therefore, do not include any libraries, by default, related to global state management and it's up to you to make those decisions for your app."

CRA supports both redux and graphql. What's the purpose of this issue?

Closing this as unactionable.  There shouldn't be anything stopping you from bringing redux and graphql into your app.


AudioPlayer blocks UI on Andorid

The call to prepare() can take a long time to execute, because it might involve fetching and decoding media data. So, as is the case with any method that may take long to execute, you should never call it from your application's UI thread.
https://developer.android.com/guide/topics/media/mediaplayer.html#preparingasync

Thanks for pointing it out, @the4thfloor ! Duly noted!
Indeed this needs to be fixed in the pursuit of a better user experience for audioplayers (and flame games).
I'm guessing just popping a new Thread and calling prepare() there should do the trick, but my knowledge of Android is not yet absolutely mastered, so I don't know if that's the best and most elegant solution.
Would you like to submit a PR?

I created a PR (https://github.com/luanpotter/audioplayer/pull/8)
it is a little bit more than expected :-(

Released on 0.5.0


Check branch before cloning

If the branch doesn't exist on the remote, expand the scan scope to all branches.

Looks good to me.
I would recommend bumping Go to version 1.21 (in go.mod and in .github/workflows/testing.yml). 1.21 is in pretty minimal these days.


Added support for Java 9 and up

Support for java > 8 is broken.
The code assumes that java -version outputs 1.x:
    if ( java.version[ 0 ] !== '1' || ( java.version[ 0 ] === '1' && java.version[ 2 ] <= '8' ) ) {
      throw new Error( '\nUnsupported Java version used: ' + java.version + '. v1.8 is required!' );
    }

Java 9 java -version:
java version "9.0.4"
Java(TM) SE Runtime Environment (build 9.0.4+11)
Java HotSpot(TM) 64-Bit Server VM (build 9.0.4+11, mixed mode)

Java 10 java -version:
java version "10.0.1" 2018-04-17
Java(TM) SE Runtime Environment 18.3 (build 10.0.1+10)
Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.1+10, mixed mode)

Fixed the check and updated the README to reflect support for Java 8+.

I don't think grunt-html should be responsible to test the Java version. With composer it's possible to test for the php/java version perhaps a similar approach exists for npm?

Or we remove that check altogether?

All checks have failed

The linter is complaining about some silly missing spaces. Could you check that out?

Hi @jzaefferer, I fixed the linter issues. I'm new to this type of JavaScript formatting with spaces all over the place :).

Yeah, its a special style. I stopped using it on newer projects a while ago.
Anyway, this looks fine now, I'll merge. Thanks for the contribution!


Publish v2.0.1

[x] blocked by https://github.com/adobe/aio-cna-core-config/issues/6
[x] update aio-cna-core-config dep to ^1.0.14

Published https://github.com/adobe/aio-cli-plugin-config/releases/tag/2.0.1


Blank app WAP WinUI 3 Desktop template does not work out of the box

This issue has been moved from a ticket on Developer Community.

Create a new [Experimental] Blank App. Packaged with WAP (WinUI 3 in Desktop)
Don't change the default minimum and target windows versions.
Hit F5 to run it.
You will get 2 compiler errors as in the screenshot: CS8773	Feature 'file-scoped namespace' is not available in C# 9.0. Please use language version 10.0 or greater.
Fix those errors by changing the namespaces to the old format (without the ;).
Hit F5 to run it.
You will get: System.Reflection.TargetInvocationException
HResult=0x80131604
Message=Exception has been thrown by the target of an invocation.
Source=System.Private.CoreLib
StackTrace:
at System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean wrapExceptions, Boolean& canBeCached, RuntimeMethodHandleInternal& ctor, Boolean& hasNoDefaultCtor)
at System.RuntimeType.CreateInstanceDefaultCtorSlow(Boolean publicOnly, Boolean wrapExceptions, Boolean fillCache)
at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean skipCheckThis, Boolean fillCache, Boolean wrapExceptions)
at System.Activator.CreateInstanceT
at WinRT.WeakLazy`1.get_Value()
at Microsoft.UI.Xaml.Application._IApplicationStatics.get_Instance()
at Microsoft.UI.Xaml.Application.Start(ApplicationInitializationCallback callback)
at MyChessSolverPro.Program.Main(String[] args) in D:\PROJECTS\MyChessSolverPro\MyChessSolverPro\obj\x86\Debug\net5.0-windows10.0.19041.0\App.g.i.cs:line 26

This exception was originally thrown at this call stack:
[External Code]
Inner Exception 1:
COMException: Class not registered (0x80040154 (REGDB_E_CLASSNOTREG))
Expected behavior is for a template to work out of the box.
That means correct .NET version, Correct C# version, and no runtime exceptions!!!

Original Comments
Danny Cohen on 9/15/2021, 11:17 AM:
Deploy seems to work. Maybe this kind of template should not run under DEBUG?
Another problem with this template:
Project - Properties - Build - General - Warning Level, I can’t select anything from the pull down menu.
It shows my selection for a second and than reverts to empty.
Danny Cohen on 9/15/2021, 11:54 AM:
I found my mistake, the Package Project should be selected before hitting F5 to run in DEBUG.
However, the template is based on .Net 5 instead of .Net 6 and the pull down menu bug still exists.
Feedback Bot on 9/16/2021, 01:04 AM:
We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

Original Solutions
(no solutions)

@alwu-msft FYI

Closing as there is nothing to fix; this was user error.


use browserify to bundle npm modules

Currently stripe.js and openfb.js versions are maintained manually by updating the js file in app/vendor
Instead, we should use npm to add these dependencies and grunt-browserify to bundle them as we do for bower. Ideally npm + grunt + browserify should be the preferred way, all modules available in npm should be removed from bower (e.g. lodash, ionic, angular...)

@dbaq are you familiar with this? ionic comes with bower, but npm + browserify are more mainstream.
If it is a quick fix could you please do it? otherwise it can wait after alpha.
Currently we have lodash loaded both on package.json (needed by Gruntfile.js) and bower.json (needed in the app)


Remove AC

Backwards-compatibility is maintained at the level of the C runtime, but not the wrappers or C/C++ compilations:
rs2_cah_trigger, for example, was removed -- code using it will not compile.
Likewise, the options for TRIGGER and RESET are still there, but nothing supports them and so they have been removed from most wrappers.
Interfaces like calibrated_sensor are still there, but no longer in use.

I'll update the warning count (it goes down) once I have a LibCI run

I think we need a dedicated unit-test of cross version testing - exe compiled with 2.4[1-5] that invokes the deprecated calls with dll compiled with v.2.46+

Not a bad idea


ssh to nixos guest running in vmware fails on master

Issue description
I am running nixos in a vmware guest on Windows 10.
SSH to the guest fails after building nixos from the master branch on nixpkgs.
bcf736b325cb (main/master, main/HEAD) python: pyjwt: fix build

OpenSSH version is 7.9p1
The same works if I use the 18.09 branch.
636b2b2da96c (main/release-18.09) linuxPackages.{spl,zfs}: 0.7.11 -> 0.7.12

OpenSSH version is 7.7p1
SSH logs do not provide any useful information.
Settting IPQoS ssh option on client as suggested some other tickets does not help in this case.
Steps to reproduce

Run NixOS in vmware guest. Use NAT for networking.
Use Nixpkgs from the master for nixos-rebuild instead of a channel.
Try to SSH to guest.

SSH log from the server in the fail case
sshd[19543]: debug2: fd 4 setting O_NONBLOCK
sshd[19543]: debug2: fd 7 setting O_NONBLOCK
sshd[19543]: debug1: server_init_dispatch
sshd[19543]: debug1: server_input_channel_open: ctype session rchan 1 win 1048576 max 16384
sshd[19543]: debug1: input_session_request
sshd[19543]: debug1: channel 0: new [server-session]
sshd[19543]: debug2: session_new: allocate (allocated 0 max 10)
sshd[19543]: debug1: session_new: session 0
sshd[19543]: debug1: session_open: channel 0
sshd[19543]: debug1: session_open: session 0: link with channel 0
sshd[19543]: debug1: server_input_channel_open: confirm session
sshd[19543]: debug1: server_input_channel_req: channel 0 request pty-req reply 1
sshd[19543]: debug1: session_by_channel: session 0 channel 0
sshd[19543]: debug1: session_input_channel_req: session 0 req pty-req
sshd[19543]: debug1: Allocating pty.
sshd[19541]: debug2: session_new: allocate (allocated 0 max 10)
sshd[19541]: debug1: session_new: session 0
sshd[19543]: debug1: session_pty_req: session 0 alloc /dev/pts/0
sshd[19543]: debug1: server_input_channel_req: channel 0 request env reply 0
sshd[19543]: debug1: session_by_channel: session 0 channel 0
sshd[19543]: debug1: session_input_channel_req: session 0 req env
sshd[19543]: debug2: Ignoring env request LANG: disallowed name
sshd[19543]: debug1: server_input_channel_req: channel 0 request env reply 0
sshd[19543]: debug1: session_by_channel: session 0 channel 0
sshd[19543]: debug1: session_input_channel_req: session 0 req env
sshd[19543]: debug2: Ignoring env request LC_ALL: disallowed name
sshd[19543]: debug1: server_input_channel_req: channel 0 request shell reply 1
sshd[19543]: debug1: session_by_channel: session 0 channel 0
sshd[19543]: debug1: session_input_channel_req: session 0 req shell
sshd[19543]: Starting session: shell on pts/0 for vmandela from <IP_ADDRESS> port 40874 id 0
sshd[19543]: debug2: fd 3 setting TCP_NODELAY
sshd[19543]: debug2: channel 0: rfd 11 isatty
sshd[19543]: debug2: fd 11 setting O_NONBLOCK
sshd[19544]: debug1: Setting controlling tty using TIOCSCTTY.
sshd[19543]: Read error from remote host <IP_ADDRESS> port 40874: Connection reset by peer
sshd[19543]: debug1: do_cleanup
sshd[19541]: debug1: do_cleanup
sshd[19541]: debug1: PAM: cleanup
sshd[19541]: debug1: PAM: closing session
sshd[19541]: pam_unix(sshd:session): session closed for user vmandela

This seems to be a VMWare issue. I am using the workaround listed in [1] below.

Adding "IPQoS 0x00" to /etc/ssh/sshd_config

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1624437
[2] https://communities.vmware.com/thread/597244


No display of found Anki cars

Already discovered Anki-Cars should not be displayed again during the BLE search

already fixed


Unable to deploy pages

This could very well be GitHub's online service outage, but I'm not sure where to submit issues for that.
Right now our pages deployment workflow failed on this action. Both gh-pages branch and workflow based deployment have been tried. V2 and V1 are used by those methods.
Deployment outputs bunch of:
Getting Pages deployment status...
Current status:

then workflow timed out.

Tested again and now it works.


enh: reduce front pg connection pool size

Description
We increased the number of pods, but we haven't recuced the # of connections per instance. We're getting dangerously close to max out the DB, and we'e had some related errors.
Risk

Deploy Plan

@PopDaph  here's an example: https://app.datadoghq.eu/logs?query=unhandled &cols=host%2Cservice&event=AgAAAY7v3Iup_xmY3AAAAAAAAAAYAAAAAEFZN3YzSko2QUFEeWc0TjZCU0NEZ3dBTwAAACQAAAAAMDE4ZWYwMDEtNDk3MS00YWIxLWFmYzQtMjc4ZjU3ZjA3ZDJm&fromUser=true&index=*&messageDisplay=inline&refresh_mode=sliding&storage=hot&stream_sort=desc&viz=stream&from_ts=1713275112862&to_ts=1713361512862&live=true


Make facility optional on shipped order import

What is the motivation for adding/enhancing this feature?

If a user is importing shipped orders, then the facility dropdown should be optional and in the background the app should auto select the current logged in facility of the user so that user does not have to map it.

Verified the changes and are working fie in release v2.5.1. Hence, closing this ticket.


testing: false positives for examples with comments at end

What version of Go are you using (go version)?

go version go1.17 darwin/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/adowns/Library/Caches/go-build"
GOENV="/Users/adowns/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/adowns/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/adowns/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.17"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/adowns/workspace/text/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/4c/1b3s36l94blb6xg1_4p_13800000gn/T/go-build2465748359=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
I ran this test in a test file:
func ExampleThisTestShouldNotPass() {
	fmt.Println("meow")

	// Output:
	// bark

	// TODO: foo bar
}

What did you expect to see?
The test fail
What did you see instead?
The test passed.
I saw this in a real example with the ExampleMatcher here, which I reported in  https://github.com/golang/go/issues/48361.

Also reproduces on the playground: https://play.golang.org/p/0wPM6durES5.

IMO this is working as intended, the testing package documentation says:

Example functions may include a concluding line comment that begins with "Output:"

I your example the Output line comment is not "concluding" so the Example is not processed as an check-output one.

@ALTree In that case, the broken examples should probably just be addressed by moving the non-Output comments before the Output comment.

IMO this is working as intended

@ALTree: I agree, but it worries me that this allowed a broken example to be around for 4 years.
Interestingly, it only fails this way when there is another comment after the output. See here where it still fails when it is more code after the output: https://play.golang.org/p/RRN7vl8KayA

@ameowlia I agree that this is behavior that is subtle and hard to catch. What if the testing tool's heuristic was changed to only process CommentGroups that begin with Output:? It would be able to ignore that TODO comment, and the output comment could be placed anywhere in the function, without affecting the test result.

What if the testing tool's heuristic was changed to only process CommentGroups that begin with Output:?

@smasher164  - I looked into this today (code here). I would like to try to contribute this if others think it is an acceptable solution.
The main argument against this fix that I can see is "what happens if an example has multiple output commentblocks"? In that case I would suggest returning the first one and ignoring later ones. Multiple outputs seems like flagrant disregard for the spec. Adding a comment at the end (the issue I reported here) seems like an accident that would be nice to protect against.
Alternatively we could add a go/vet warning to make sure that output commentblocks are always the last commentblock. This seems a little heavy handed though.

Regarding the vet approach, this would at least need to satisfy the requirement of high frequency. It is not clear at the moment how frequent this issue is.
Another approach is to perhaps make the documentation more clear.

It is not clear at the moment how frequent this issue is.

Yeah, the bug in x/text/language's example might be a rare exception. Running an *analysis.Analyzer on a corpus of open source code might give a better idea of how frequently this pops up. Without that information, it seems heavy handed both to change how comments are processed and to add a vet check.
Updating the documentation seems like a good option. Right now, testing says

Example functions may include a concluding line comment that begins with "Output:" and is compared with the standard output of the function when the tests are run. (The comparison ignores leading and trailing space.)

@matloob

I wrote a parser, ran it against this repo, and found one example: https://github.com/golang/go/issues/48494. I plan on running it against golang.org/x/... repos today.
❓ @smasher164 - Any advice on how to run against a "corpus of open source code"?

❓ @smasher164 - Any advice on how to run against a "corpus of open source code"?

I typically run tools like that over my GOPATH, assuming I have a decent number of packages installed. For instance, this is what I did for the string(int) conversion vet check: https://github.com/golang/go/issues/32479#issuecomment-570003094, https://github.com/golang/go/issues/32479#issuecomment-570078978.
I guess nowadays with go modules, I'd run that over the vendor directory in some project that imports a large number of dependencies? I couldn't find an official way to list all major versions of modules in the cache, but this might work:
$ find $(go env GOMODCACHE) -type f -name go.mod |
while read fname; do echo "${fname#$(go env GOMODCACHE)/}" |
cut -f1 -d"@"; done |
sort -u

I think a vet check is the right place to fix this. See checkExample in golang.org/x/tools/go/analysis/passes/tests. It already checks that examples have the right name and signature. It could check that the // Output: comment is in the right place, too.

Good point. I guess we don't need to worry about the frequency of this pattern because we are just extending an existing checker with a simple logic?

Good point. I guess we don't need to worry about the frequency of this pattern because we are just extending an existing checker with a simple logic?

Right, exactly. Just reporting something that was already buggy.

I ended up running the parser against the top 1000 open source golang repos based on stars and I found 5 additional instances of the bug(after removing duplicates from vendoring).

Project Name
Links

golang/go
buggy test, github issue

golang/text
buggy test, github issue

miekg/dns
buggy test, github issue

m3db/m3
buggy test, github issue

cuelang/cue -> cue-lang/cue
buggy test, github issue

zalando/skipper
buggy test, github issue

smartcontractkit/chainlink
buggy test, github issue

@jayconrod  - I'll start working on extending the checkExample vet check. Thank you for the point in the right direction.

@ameowlia Nice finds. I bet there are a lot more out there, too. Thanks for working on this.


Update api.md

Asar unpack multiple directories is possible.
Edit if you like... 👍

I don't understand. This documentation seems to be for the asar script, not using electron-packager directly.

Sorry about that.
Is this better?

I think this a bit too verbose. A sentence that states that you can use glob syntax to specify multiple directories (and perhaps one example of this) is sufficient.

there, Better?

That's better, thanks.
Regarding **/{sub_dir1/sub_sub_dir,sub_dir2}/*:

Is the trailing /* necessary?
Would this pattern also match /<dir>/parent_dir/sub_dir2?

It's even worse due to how asar works at this moment.
I'm gonna make a PR to fix that later.
asar-unpack-dir
String
Unpacks the dir to app.asar.unpacked directory whose names exactly or pattern match this string. The asar-unpack-dir is relative to dir.
Some examples:

asar-unpack-dir=sub_dir will unpack the directory /<dir>/sub_dir
asar-unpack-dir=**/{sub_dir1/sub_sub_dir,sub_dir2}/* will unpack the directories /<dir>/sub_dir1/sub_sub_dir and /<dir>/sub_dir2, but it will note include their subdirectories.
asar-unpack-dir=**/{sub_dir1/sub_sub_dir,sub_dir2}/** will unpack the subdirectories of the directories /<dir>/sub_dir1/sub_sub_dir and /<dir>/sub_dir2.
asar-unpack-dir=**/{sub_dir1/sub_sub_dir,sub_dir2}/**/* will unpack the directories /<dir>/sub_dir1/sub_sub_dir and /<dir>/sub_dir2 and their subdirectories.

As it currently stands, this PR has too many unrelated changes to it, so I'm not inclined to merge it until just the glob syntax changes remain. For more information on our pull request policy, please see: https://github.com/electron-userland/electron-packager/blob/master/CONTRIBUTING.md#filing-pull-requests

I made a new pull request: https://github.com/electron-userland/electron-packager/pull/347


Suppress Curl output

The -s option means that no spare output gets sent from Curl, showing up in the Alfred debugging screen, see the Curl manual.

Silent or quiet mode. Don't show progress meter or error messages. Makes Curl mute. It will still output the data you ask for, potentially even to the terminal/stdout unless you redirect it.

this looks good @simonwheatley i'll get this merged in.

@simonwheatley i also updated iwill.sh and the alfred workflow file to reflect this change.


Images: expose dimensions as parameters

Second that.

the requirement has evolved a little bit:

if no dimensions are set, then crop scale to default (300x200) -> no breaking changes for existing users
if both dimensions are set, then keep current behavior (crop scale to dimension)
if an empty array is set image:{dims:[]} - then let the image take its space up to 100% of the width without constraining the height. Useful for projects using the widget full screen
There are two other cases but I don't think we need to implement them right now:
image:{dims:[x,0]}: constrained width but no constraint on height
image:{dims:[0, y]}: constrained height but no constraint on width.

@TheoTomalty thoughts?

Implemented in PR #20.


Partially revert PR 55723 to fix OOM in testing

#55723 fixes an actual bug in our testing infrastructure, but doubles memory usage on my machine, causing OOMs where I hit the max memory limit of my system and the OS starts killing processes.
This PR effectively reverts that change. I hate this, but I hate OOMing my machine more and #55723 was not supposed to have caused any behavior changes.

What's the correct fix? What's the lifetime of this cache?

I have no idea what the correct fix is; it seems like this cache lives forever. It's not a simple Map either so I nope'd out last night, but I'll stare at it harder.

I guess the idea is to cache mostly lib.d.ts files but it attempts to cache literally everything, failing only because of the broken key bug you fixed. Failing something very simple like only caching files in certain directories or with lib-like file names, maybe a simple MRU cache would do it.

I guess the idea is to cache mostly lib.d.ts files but it attempts to cache literally everything, failing only because of the broken key bug you fixed. Failing something very simple like only caching files in certain directories or with lib-like file names, maybe a simple MRU cache would do it.

The problem is that it actually succeeds and returns the same AST even when the options change... but miraculously it doesn't break anything, probably the files in shadow roots don't actually change on these option differences? They sure would depending on the JSDoc mode :(
Now that TS Congress is over I'm going to look at this harder before doing the pure revert. But it's possible Sheetal will save the day with some insight faster than me 😄

I think it’s not broken because of the extra getFullText() === content check. So stuff in the cache is being overwritten and then not used when it doesn’t match.

Gating this on "only cache if it's a lib.d.ts file" still produces the problem, unfortunately. I see no reason why this memory should be sticking around, either; the compiler tests explicitly try and drop the only reference to this stuff.

Should I just merge this as-is to get memory usage back to "normal"? I still want to figure out how to do this right but I definitely didn't intend this when I sent the original PR :(

Vfs is caching only typescript lib files because those are the only ones on the shadow root and available. So I think for those files it doesn't matter if they account for script target or not since the result is going to be same?

Unfortunately WSL's kernel is too old for me to properly measure this, but watching htop's total system memory usage by eye, I can see:

With the original code before my original PR, my memory usage goes from 2.87GB to 17.3GB
After my original PR (main), I see 3.19GB grow to 31.3GB
With main but only allowing caching on lib.d.ts files, I see 3.18GB grow to 33.0GB

I've so far not been able to find any way to fix this while keeping an accurate cache key.

Vfs is caching only typescript lib files because those are the only ones on the shadow root and available. So I think for those files it doesn't matter if they account for script target or not since the result is going to be same?

I observed it caching files that aren't lib.d.ts files, unfortunately. And even so, lib.d.ts files can be parsed with differing options (e.g. JSDocParsingMode), so reusing them may not actually be safe.

I'm just going to merge this for now as it's effectively a revert; the memory usage is really hurting me while working on other other changes :(


merge from template-kronos-app

.github/workflows/pr_labeler.yml

chore(actions): merge from template .github/workflows/pr_labeler.yml

:tada: This PR is included in version 1.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.11.0
GitHub release

Your semantic-release bot :package::rocket:


added jenkins key variable to readme

Updating readme for changes in https://issues.jboss.org/browse/AGDIGGER-230

ping @PhilipGough  @aliok


Improve the definition of SimpleUnitOfMeasure (stylistic change only). Fixes #84.

@uscholdm I have not added to the release notes for this item. It seems to me we don't want to put such a trivial item in the release notes -

@uscholdm Sorry, Michael, I reviewed and merged, since it was trivial, just trying to move the process along 😸


⚠ Multimedia BRN has degraded performance

In 57eb337, Multimedia BRN (https://mbrn.in/ping.html) experienced degraded performance:

HTTP code: 200
Response time: 17631 ms

Resolved: Multimedia BRN performance has improved in dcf6546.


Does a soft bounce trigger a Postmark::InactiveRecipientError

I would like to handle soft bounces, but I'm not sure if a soft bounce is triggering a Postmark::InactiveRecipientError. Looking at the implementation, I'm guessing it's not.
Does anyone know how to catch soft bounce errors?
I did read the wiki about error handling: https://github.com/ActiveCampaign/postmark-rails/wiki/Error-Handling

@pgraham3 thanks for the clear answer! 👍


What argument does insert method accept?

Apologies if this is in the wrong place, if it is, where is the best place to post this question?
I am trying to rescale a bitmap image. As far as I can tell the process should involve:

Create a BitmapFactory instance that is the original image size.
Insert the image into the BitmapFactory canvas.
Use the resize (or resizeWidth/resizeHeight) function to scale the image.
4 Convert the image to an imagesource and save.

My code for doing this is:
        var image = ImageSource.fromFile(file_path);
        var bmp = BitmapFactory.create(width, height);

        bmp.dispose(function(b) {
            // Causes an out of memory exception
            b.insert(image.toBase64String(Enums.ImageFormat.jpeg));

            // Causes a "Not valid bitmap" exception.
            //b.insert(image);

            // Tried on android, Causes a "Not valid bitmap" exception.
            //b.insert(image.android);

            // Causes a "Not valid bitmap" exception.
            //b.insert(file_path);

            var b2 = b.resize({
                width: thumb_width,
                height: thumb_height
            });

            var thumb_image = b2.toImageSource();

            thumb_image.saveToFile(
                temp_thumb_path,
                Enums.ImageFormat.jpeg
            );
        });

I have tried to use the insert function in several ways, but loading from a base64 string results in an out of memory exception.
I have also tried passing an imagesource object, a native object or a file path and all cause a "Not valid bitmap" exception.
Is this correct? Can I only insert from a base64 string? Or am i using this incorrectly?
Any help greatly appreciated...

Yes, you tried it the right way, but I forgot to implement it!
I released version 1.4.1 that is now able to use the following kind of objects:

Base64 strings (the way you tried, but as you see: it needs a lot of memory and time)
ImageSources (it reads the underlying native object automatically)
native objects like Bitmap or UIImage

Hi Mkloubert,
No probs, thanks for the quick update.
I have updated to 1.4.1, but now I get the following error (both for ImageSource and android Bitmap object):
Error: java.lang.IllegalStateException: Immutable bitmap passed to Canvas constructor
Stack trace is:
    android.graphics.Canvas.<init>(Canvas.java:142)
    com.tns.Runtime.callJSMethodNative(Native Method)
    com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:865)
    com.tns.Runtime.callJSMethodImpl(Runtime.java:730)
    com.tns.Runtime.callJSMethod(Runtime.java:716)
    com.tns.Runtime.callJSMethod(Runtime.java:697)
    com.tns.Runtime.callJSMethod(Runtime.java:687)
    com.tns.gen.java.lang.Runnable.run(java.lang.Runnable.java)
    android.os.Handler.handleCallback(Handler.java:739)
    android.os.Handler.dispatchMessage(Handler.java:95)
    android.os.Looper.loop(Looper.java:234)
    android.app.ActivityThread.main(ActivityThread.java:5526)
    java.lang.reflect.Method.invoke(Native Method)
    com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
    com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

According to Stack Overflow, the working bitmap needs to be converted to a mutable bitmap on android (not tested on iOS yet).
I have tried to change: https://github.com/mkloubert/nativescript-bitmap-factory/blob/master/plugin/BitmapFactory.android.js#L43
To something like:
    this._isDisposed = false;
    this._nativeObject = bitmap;
    this._options = opts;
    var mutable = bitmap.copy(android.graphics.Bitmap.Config.ARGB_8888, true);
    this._c = new android.graphics.Canvas(mutable);

However this again causes an out of memory exception.
There is some more info here on a solution with minimal memory implications but to be honest this is a bit beyond me :-s.
Any ideas?

Managed to test insert (and resize) on iOS and it works like a dream :-)

@iOS: 👍
@Android:
Thanks for the code examples! :-)
I used them to release version 1.5.0 with a new helper function that should be fix the memory leaks:
The function is called makeMutable(). It works on Android and iOS.
var BitmapFactory = require('nativescript-bitmap-factory');

// this can be:
//
// * a native object like Bitmap or UIImage
// * an IBitmap
// * an ImageSource
var nativeObj;

var mutable = BitmapFactory.makeMutable(nativeObj);

By default this will clone the nativeObj in memory, but you can define a "stradegy" to clone it by submitting custom options that have the following interface:
/**
 * Options for 'makeMutable()' functon.
 */
export interface IMakeMutableOptions {
    /**
     * Dispose current bitmap or not.
     *
     * Default: (false)
     */
    disposeCurrent?: boolean;
    /**
     * Options for handling temp data / files.
     */
    temp?: {
        /**
         * This is only used if stradegy is 'Custom' and
         * is used to define the custom temp directory.
         *
         * This can be a string or a native object that represents a file
         * like java.lang.File on Android.
         */
        directory?: any;
        /**
         * The stradegy.
         *
         * Default: Memory
         */
        stradegy?: TempFileStradegy;
    };
}

The disposeCurrent property means it will recycle / dispose the submitted image after a "clone" has been created successfully. This is (false) by default and should only be set to (true) if you do not need the original image anymore.
In the temp section you can define the stradegy property:
/**
 * List of temp file stradegies.
 */
export declare enum TempFileStradegy {
    /**
     * Memory
     */
    Memory = 1,
    /**
     * Cache directory
     */
    CacheDir = 2,
    /**
     * External directory
     */
    ExternalCacheDir = 3,
    /**
     * Custom directory
     */
    Custom = 4,
}

You can choose beetween:

Memory: Clone in memory (default)
CacheDir: Saves the cloned image to a temporary file that is stored in cache directory (Android only); this version should NOT need additional permissions, bebause files are stored inside the app directory
ExternalCacheDir: Saves the cloned image to a temporary file that is stored in EXTERNAL cache directory (Android only); this may require additional WRITE_EXTERNAL_STORAGE permissions
Custom: You also can use a custom directory (path) what is defined in the temp.directory property in the options object (Android only); Default: Cache directory.

"Android only" means: Also works on iOS, but has no effect, because currently anything is cloned in memory there.
Example:
import BitmapFactory = require('nativescript-bitmap-factory');

// your "native" image object
let nativeObj: any;

let opts: BitmapFactory.IMakeMutableOptions = {
    disposeCurrent: true,

    temp: {
        stradegy: BitmapFactory.TempFileStradegy.CacheDir,
    }
};

let mutable = BitmapFactory.makeMutable(nativeObj, opts);

Just letting you know, these seems to be working as expected on iOS and Android, cheers for the help :-)


Detect Infinispan protocol errors and fail the service

@enmasse-ci run tests profile=shared-iot

:x: Test Summary :x:
TEST_PROFILE: shared-iot
TEST_CASE:
TOTAL: 29
PASS: 24
FAIL: 2
SKIP: 3
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testDeviceCredentials in io.enmasse.systemtest.iot.registry.InfinispanDeviceRegistryTest
testCreateForNonExistingTenantFails in io.enmasse.systemtest.iot.registry.InfinispanDeviceRegistryTest

@dejanb @ctron Should this be closed or is it waiting for some other PR?

@dejanb @ctron Should this be closed or is it waiting for some other PR?

I forgot about this one. Will take another look.

I just re-tested this one. It seems that the client is actually re-connecting, it just takes a bit longer than expected.


PSoc64 - Fixing some warnings

Description

Checklist:

[x ] I have tested my changes. No regression in existing tests.
[x ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run

/bot run

/bot run check

/bot run checks


Disable conditional allow overlap

[#58] As discussed in #55 and documented in the docs once this PR is merged an error will be thrown if conditional marker-allow-overlap is found.
Aceptance criteria

[ ] Load some css where the marker-allow-overlap is not conditional and check there is no errors.
[ ] Load some css where the marker-allow-overlap is conditional and check an error is thrown.

Regarding to the zoom issue.
The zoom is not in the filters array (we have this.filters and this.zoom).
Carto generates the js rules adding a "zoom" filter by default so when there are no filters the rules are like this:
if(zoom < infinity) {  // Always true
  _value = 'foo';
}

This was making the filtered value to always return true.
I changed that and I removed a bug to create a new one!
I guess I have to change the CARTO code again, to consider the zoom for the filtered field only when the zoom is smaller than the maximun value.

I guess I have to change the CARTO code again, to consider the zoom for the filtered field only when the zoom is smaller than the maximum value.

I opened an issue to take care of this: https://github.com/CartoDB/carto/issues/40


 First thing I noticed is that sometimes when dragging a gizmo of a brush the camera will get stuck in a loop where it constantly alternates between hand mode and look-around mode, also said gizmos are practically unusable, to resize a brush you have to grab a yellow tab and drag it  along the axe of a green that appears when you do so, BUT IT JUST DOESN'T WORK you have to fish around for the green line because this software is filled with hatred towards all carbon-based life forms apparently.

Even the real hammer editor is less buggy than whatever this is

You can also try RealtimeCSG. Your Editor version is too new and we moved on to work on a new project called Chisel Editor together with the Author of RealtimeCSG.

Why don't use pro builder?
Is free now.

Even the real hammer editor is less buggy than whatever this is

Well. A Unity editor version would be useful, to start. A video, instead of a picture of the outlined problems would also help a ton. We can't fix the problem without information to help us fix it. Help us help you, instead of putting us on blast because you're frustrated.

Why don't use pro builder?
Is free now.

I'm not going to comment on ProBuilder, but I'm going to say that you should at least try SabreCSG, or RealtimeCSG. If you're familiar with editors like UDK or UE 2 and below, or hammer, etc., then you probably already know why not.


2.0.0

[x] Tweaks to maps - New schema:

"ID1": {
  "meta": {
    "name": "Map List 1"
  },
  "maps": [
    {
      "map": "Sturgeon Shipyard",
      "mode": "Clam Blitz"
    },
    {
      "map": "Sturgeon Shipyard",
      "mode": "Clam Blitz"
    },
    {
      "map": "Sturgeon Shipyard",
      "mode": "Clam Blitz"
    }
  ]
}

[x] New casters schema - Schema:

        "aAa": {
            "name": "First Caster",
            "twitter": "@CasterFirst",
            "pronouns": "he/him"
        },
        "bBb": {
            "name": "Second Caster",
            "twitter": "@CasterSecond",
            "pronouns": "she/her"
        }

[x] Rename scenes - "main", "teams", "stages" (Likely dropping support for LI Schedule)
[x] Refactor music, so overlays only need to access the "nowPlaying" replicant to get access to the currently playing song, manual or last.fm
[x] Allow the last.fm username to be set within the dashboard
[x] When creating a map list, use the generated ID as the default name
[x] Map importing - Make map and mode name validation case insensitive
[x] Rename CSS classes to be in accordance to accepted conventions (eg. className -> class-name)
[x] General code quality tweaks (Will probably end up installing a formatter)
[x] Review replicant names
[x] Don't concatenate team names when importing teams, leave it to the components displaying them (graphics, dashboard panels)
(...more? Might add to the issue.)

I forgot to close this issue...


🐛 Bug ➾ cannot uninstall ligo plugin without error

🚥 Status (Internal Taqueria Team Use Only)

[ ] 🔬 Investigated and Verified
[ ] ⚗ Solution Identified and Designed
[ ] 🧫 Dev Implementation of Fix
[ ] 🧪 Fix Tested and Validated
[ ] 🏆 PR Merged

🆘 What happened?
tried to uninstall the ligo plugin and it gives error
"The @taqueria/plugin-ligo plugin experienced an error when getting information about the @taqueria/plugin-ligo plugin."
Lack of self-awareness?
🆘 Steps to Reproduce?

taq install @taqueria/plugin-ligo
verify it installed ok
taq uninstall @taqueria/plugin-ligo
"The @taqueria/plugin-ligo plugin experienced an error when getting information about the @taqueria/plugin-ligo plugin."

🪵 Relevant log output
No response
🐘 How impactful is this bug?
🤯 Major disruption
⏱ Prevalance
everytime
💻 Operating System
Windows -> Linux VM
🕸 System Architecture
x64
🌮 Taqueria Version
v0.24.2
🌿 Node.js Version
v16.13.1
☎ Contact Details
<EMAIL_ADDRESS>Code of Conduct

[X] I agree to follow this project's Code of Conduct

Closing: edge case


ARROW-12267: [Rust] Implement support for timestamps in JSON writer

Rationale
I want to write timestamps to JSON (e.g. https://github.com/influxdata/influxdb_iox/pull/1104) and when I did so I got a panic :)
When I tried to write aTimestampNanosecondArray I got the following error:
thread 'influxdb_ioxd::http::tests::test_query_json' panicked at 'Unsupported datatype: Timestamp(
    Nanosecond,
    None,
)', /Users/alamb/.cargo/git/checkouts/arrow-3a9cfebb6b7b2bdc/3e825a7/rust/arrow/src/json/writer.rs:326:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Changes
Add support for DataType::Timestamp, and tests for same
I did not add support for the other date / time / duration types, but instead filed a ticket to add such support: https://issues.apache.org/jira/browse/ARROW-12317

FYI @houqp

I am thinking of adding an option to return these type of values as numbers instead of human readable strings for better ser/de performance, what do you think about that?

@houqp  I think an option for such behavior is a reasonable idea.
One question I have is if dates / timestamps / etc are produced as numbers, how would the other side know what type to use?
Like if we made JSON like this:
{
  "name": "foo",
  "time":<PHONE_NUMBER>
}

Is time a Timestamp? A Time? a u64? something else?

The caller would need to obtain the response schema first, in most cases, the schema should be static. In case of API responses, it would be part of the API spec.
I would expect most of the users to use the string encoded format and only resort to numbers for performance critical use-cases. For example, in Airflow, by changing the column type from string encoded date time to timestamp numbers, we reduced the frontend load time by almost 90% :)

@houqp  thanks -- that makes sense. Sending timestamps encoded as strings is definitely not a good idea for performance :)


Z-indexing of elements when dropping

I'm dragging and dropping from an "admin" drawer that slides out from the right and overlays the droppable zones by about 100px.
If I start the dragging process and change my mind and drag BACK to the drawer and drop there, the z-indexing of the drawer over the droppable zone is ignored and the drop still occurs underneath the drawer.

Thought I followed your template exactly. Oh well.


License?

Hey there! Amazing work on this new paper. Can you all specify a license for your work? I'm the founder of NatML and I would like to bring this model to NatML Hub.
Also, do you accept pull requests? If you all provide an open-source license for your work, I would like to add a link to the NatML implementation of your model in the README. A lot of augmented reality developers in Unity will find this work very useful. Thank you!

Sounds good. Do you accept pull requests? I'd like to add a link to a demo in Unity Engine using NatML.


(Feature suggestion) Multi-core window capture

Hi there!
Is it possible to capture windows async?
I researched it myself briefly but wasn't sure if PrintWindow could be used async.
If so, this would be an amazing additional as generally capturing just one window at 30 FPS can be enough to max out a single core on a lot of CPUs.
Thanks! :)

Thank you for the suggestion.
But it seems impossible to use capture functions asynchronously. At the beginning phase of the development, I implemented async capture but the performance wasn't improved...

Thanks for your fast response on this!
I wasn't sure it would be possible but I wanted to ask to check! :)


xf86_input_wacom: 0.35.0 -> 0.36.0

Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:

built on NixOS
ran /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/xsetwacom -h got 0 exit code
ran /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/xsetwacom --help got 0 exit code
ran /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/xsetwacom -V and found version 0.36.0
ran /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/xsetwacom --version and found version 0.36.0
ran /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/isdv4-serial-debugger -h got 0 exit code
ran /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/isdv4-serial-debugger --help got 0 exit code
ran /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/isdv4-serial-debugger -V and found version 0.36.0
ran /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/isdv4-serial-debugger --version and found version 0.36.0
ran /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/isdv4-serial-inputattach -h got 0 exit code
ran /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/isdv4-serial-inputattach --help got 0 exit code
ran /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/isdv4-serial-inputattach -V and found version 0.36.0
ran /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/isdv4-serial-inputattach -v and found version 0.36.0
ran /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/isdv4-serial-inputattach --version and found version 0.36.0
found 0.36.0 with grep in /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0
directory tree listing: https://gist.github.com/ceac89f2f9f39c6b3da0882790d97699

cc @cillianderoiste for review

Success on x86_64-linux (full log)
Attempted: xf86_input_wacom
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0
shrinking /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/isdv4-serial-inputattach
shrinking /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/xsetwacom
shrinking /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin/isdv4-serial-debugger
shrinking /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/lib/xorg/modules/input/wacom_drv.so
gzipping man pages under /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/lib  /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0/bin
patching script interpreter paths in /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0
checking for references to /tmp/nix-build-xf86-input-wacom-0.36.0.drv-0 in /nix/store/ipx3qfwcd0g7wnmnqxq008fws2n8ldg4-xf86-input-wacom-0.36.0...

No attempt on x86_64-darwin
The following builds were skipped because they don't evaluate on x86_64-darwin: xf86_input_wacom
No partial log is available.

Success on aarch64-linux (full log)
Attempted: xf86_input_wacom
Partial log (click to expand)
shrinking /nix/store/fj4qxqm6342fx5arg5z3rdj3xb2qksc6-xf86-input-wacom-0.36.0/bin/isdv4-serial-inputattach
shrinking /nix/store/fj4qxqm6342fx5arg5z3rdj3xb2qksc6-xf86-input-wacom-0.36.0/bin/isdv4-serial-debugger
shrinking /nix/store/fj4qxqm6342fx5arg5z3rdj3xb2qksc6-xf86-input-wacom-0.36.0/bin/xsetwacom
shrinking /nix/store/fj4qxqm6342fx5arg5z3rdj3xb2qksc6-xf86-input-wacom-0.36.0/lib/xorg/modules/input/wacom_drv.so
gzipping man pages under /nix/store/fj4qxqm6342fx5arg5z3rdj3xb2qksc6-xf86-input-wacom-0.36.0/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/fj4qxqm6342fx5arg5z3rdj3xb2qksc6-xf86-input-wacom-0.36.0/lib  /nix/store/fj4qxqm6342fx5arg5z3rdj3xb2qksc6-xf86-input-wacom-0.36.0/bin
patching script interpreter paths in /nix/store/fj4qxqm6342fx5arg5z3rdj3xb2qksc6-xf86-input-wacom-0.36.0
checking for references to /build in /nix/store/fj4qxqm6342fx5arg5z3rdj3xb2qksc6-xf86-input-wacom-0.36.0...
/nix/store/fj4qxqm6342fx5arg5z3rdj3xb2qksc6-xf86-input-wacom-0.36.0

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: xf86_input_wacom
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: xf86_input_wacom
Partial log (click to expand)
shrinking /nix/store/z3zg7qxwi16ghm0c6pi9j6q20m240235-xf86-input-wacom-0.36.0/bin/isdv4-serial-inputattach
shrinking /nix/store/z3zg7qxwi16ghm0c6pi9j6q20m240235-xf86-input-wacom-0.36.0/bin/isdv4-serial-debugger
shrinking /nix/store/z3zg7qxwi16ghm0c6pi9j6q20m240235-xf86-input-wacom-0.36.0/bin/xsetwacom
shrinking /nix/store/z3zg7qxwi16ghm0c6pi9j6q20m240235-xf86-input-wacom-0.36.0/lib/xorg/modules/input/wacom_drv.so
gzipping man pages under /nix/store/z3zg7qxwi16ghm0c6pi9j6q20m240235-xf86-input-wacom-0.36.0/share/man/
strip is /nix/store/ijmisi52n5wbwybg5ldysa6af01zy5dl-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/z3zg7qxwi16ghm0c6pi9j6q20m240235-xf86-input-wacom-0.36.0/lib  /nix/store/z3zg7qxwi16ghm0c6pi9j6q20m240235-xf86-input-wacom-0.36.0/bin
patching script interpreter paths in /nix/store/z3zg7qxwi16ghm0c6pi9j6q20m240235-xf86-input-wacom-0.36.0
checking for references to /build in /nix/store/z3zg7qxwi16ghm0c6pi9j6q20m240235-xf86-input-wacom-0.36.0...
/nix/store/z3zg7qxwi16ghm0c6pi9j6q20m240235-xf86-input-wacom-0.36.0

Failure on x86_64-linux (full log)
Attempted: xf86_input_wacom
Partial log (click to expand)
cannot build derivation '/nix/store/vkax8jcq5j0cxpry9gfrjirrzkyy2kfs-dbus-1.10.24.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/55q0hd7iis8rcdny26jx8bvwk94ds8z9-libXmu-1.1.2.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/3m7w7wkcb7h0cqawaqfl23n51k7mmnr2-libXpm-3.5.12.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/w0nvvwksl6phcf0x2g3g72xf2kjw9hgw-libXaw-1.0.13.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/rpnz45in5lkdjp5r2glvllx9b0b203ip-llvm-5.0.1.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/lrqnnjzy4f73apgc37zdv0lixyvwia4h-mesa-noglu-17.3.6.drv': 33 dependencies couldn't be built
cannot build derivation '/nix/store/fhvxi8qd64n57dz3l1livzs6vy4m12xg-epoxy-1.5.0.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/f4916ylsd1kymj6kkf347j8g9li089f9-xorg-server-1.19.6.drv': 59 dependencies couldn't be built
cannot build derivation '/nix/store/2hq2ci9ri80vilmg8ga0nqn5r2i1dj0l-xf86-input-wacom-0.36.0.drv': 17 dependencies couldn't be built
error: build of '/nix/store/2hq2ci9ri80vilmg8ga0nqn5r2i1dj0l-xf86-input-wacom-0.36.0.drv' failed


Automated cherry pick of #1962: add copyright api climc

Cherry pick of #1962 on release/2.10.0.
#1962: add copyright api climc

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@b775c58). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/2.10.0   #1964   +/-   ##
================================================
  Coverage                  ?   7.61%
================================================
  Files                     ?     410
  Lines                     ?   63103
  Branches                  ?       0
================================================
  Hits                      ?    4804
  Misses                    ?   57888
  Partials                  ?     411

Flag
Coverage Δ

#aFlag
7.61% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b775c58...c155d8f. Read the comment docs.

/lgtm
/approve


chore: remove evidence namespace

Closes https://github.com/celestiaorg/celestia-app/issues/1081

github pages fails to deploy b/c this branch lives on my fork

Codecov Report

Merging #1615 (cbd9443) into main (e905143) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1615   +/-   ##
=======================================
  Coverage   49.17%   49.17%
=======================================
  Files          84       84
  Lines        4948     4948
=======================================
  Hits         2433     2433
  Misses       2277     2277
  Partials      238      238

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Will re-open PR with a branch pushed to this repo 😞


Fix coap_client coverity issue

Fix uninitialized variable.
Coverity-CID: 190969
Fixes: #13850

Codecov Report

Merging #13981 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13981      +/-   ##
==========================================
+ Coverage   52.24%   52.27%   +0.03%
==========================================
  Files         307      307
  Lines       45444    45444
  Branches    10511    10511
==========================================
+ Hits        23741    23757      +16
+ Misses      16911    16899      -12
+ Partials     4792     4788       -4

Impacted Files
Coverage Δ

subsys/testsuite/ztest/src/ztest.c
72.72% <0%> (+7.43%)
:arrow_up:

subsys/testsuite/ztest/include/ztest_assert.h
77.77% <0%> (+38.88%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a44011...c493bc7. Read the comment docs.


Remove unnecessary condition

In cupy/cuda/compiler.py

Remove unnecessary condition, replacing with assert.
Make preprocess private by prefixing with _.

(No need to backport)

jenkins, test this please.

LGTM!


Publish button redirect issue

when click on publish button the database affected successfully, but you need to reload the page to see the effect

@devmesh check this out

@phpMuhammed Unable to reproduce this, could you give more info on this?

Okei, my fault. I was able to reproduce this issue. This happens when you create a draft that doesn't have a parent resource.

Thank you for reporting this, this is now fixed in 1.0.2


Move commands from client to bundle, add ProveGssfPossessionCommand

Depends on https://github.com/SURFnet/Stepup-Middleware/pull/46

@rjkip

:+1:


Add support for loading TrueType font files.

In the ImageFormatter class, we can load ttf fonts that already exists in the operating system.
However, the "font_name" argument does not accept a custom font (a filename or a file-like object containing a ttf font).
I hope that this pull request solves this problem.

I think this is a good feature to have, only two questions:

how to handle different font styles? At the moment this is impossible.
I think it's more idiomatic to check for hasattr(obj, 'read') to check for file-like objects, no?

We can maybe ask the user to provide different styles of the font only if he wants to use a custom font.
You are right. I will change it.

Thanks! Could you please update the documentation of the parameter (in the docstring of ImageFormatter)?

Yes, of course!
I also noticed that the "FreeTypeFont" font object can take multiple styles if the specified font is a variation font. (See https://pillow.readthedocs.io/en/stable/reference/ImageFont.html#PIL.ImageFont.FreeTypeFont.get_variation_names)
So we could associate each style (in the "fonts" dict) with its font object ?

I tested it and cannot instantiate new font objects with different styles because it throws an OSError.
The only solution I think is to use the "set_variation_by_name" method (https://pillow.readthedocs.io/en/stable/reference/ImageFont.html#PIL.ImageFont.FreeTypeFont.set_variation_by_name) to switch the style of the font, but it requires changing the code of the ImageFormatter class.

Sorry for the long inactivity, I wasn't available at the moment.
I added a get_style function to get the specified style of the font in get_font.
The code is tested and it works! The pr can be merged.

This also looks good to me, but there's no test for it (nor do I see how this can be tested easily.) @birkenfeld , @Jean-Abou-Samra , any concerns with that? I'm not super happy to merge code without tests but I don't see an easy way to test image based output.

I'm not super happy to merge code without tests but I don't see an easy way to test image based output.

No, I don't see one either, especially that font stuff is so platform-dependent :( So I think it's OK if this doesn't have tests.

Merged for 2.16. Let's see if this works in the wild, thanks for the contribution!


simple recursion throws LLVM exception in 0.29.0

My original goal for recursion from issue #136 was working after the introduction of support for simple recursion, but now in v 0.29.0 this simple example has broken:
import numpy as np
from numba import jit

@jit(nopython=True, nogil=True)
def _updateNodeRecursive2(last):
    if last > 3:
        return

    for i in range(4):
        last += 1
        _updateNodeRecursive2(last)

@jit(nopython=True, nogil=True)
def _constructTree2():
    last = np.int32(-1)
    _updateNodeRecursive2(last)

def test():
    _constructTree2()

produces:
python: /test/llvm-3.8.1.src/lib/ExecutionEngine/ExecutionEngine.cpp:218: void llvm::ExecutionEngine::addGlobalMapping(llvm::StringRef, uint64_t): Assertion `(!CurVal || !Addr) && "GlobalMapping already established!"' failed.
Aborted (core dumped)

Can you tell us which python version and OS you are using?  I tried on Mac and Linux with python3.5 and cannot reproduce the problem.

This is python 2.7.10, both on Linux 2.6.32-642.6.2.el6.x86_64 and Linux 2.6.32-279.11.1.el6.x86_64.
llvmlite (0.14.0), LLVM version 3.8.1

Are you using the conda packages?  Or, did you build numba, llvmlite, or llvm from source?

Does the error occur by just running test() from the snippet?
I tested with centos5 2.6.18-410.el5 x86_64 and newer ubuntu14.04 3.13.0-32 x86_64 and still can't reproduce the problem.
Since there's nogil=True, did you see the problem in a multithreaded execution?

This is built from source, not conda. Yes the error occurs just as:
$ python
Python 2.7.10 (default, Dec  3 2015, 16:18:18)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-4)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import test2
>>> test2.test()
python: /dnelson/test/llvm-3.8.1.src/lib/ExecutionEngine/ExecutionEngine.cpp:218: void llvm::ExecutionEngine::addGlobalMapping(llvm::StringRef, uint64_t): Assertion `(!CurVal || !Addr) && "GlobalMapping already established!"' failed.
Aborted

I have deleted the nogil=True and the behavior is identical.

I have also verified the same behavior on python 2.7.12 on "windows bash"/Ubuntu:
$ python
Python 2.7.12 (default, Dec  6 2016, 16:01:22)
[GCC 4.8.4] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import test2
>>> test2.test()
python2.7.12: /home/dnelson/llvm-3.8.1.src/lib/ExecutionEngine/ExecutionEngine.cpp:218: void llvm::ExecutionEngine::addGlobalMapping(llvm::StringRef, uint64_t): Assertion `(!CurVal || !Addr) && "GlobalMapping already established!"' failed.
Aborted (core dumped)
$ uname -a
Linux HOSTNAME 3.4.0+ #1 PREEMPT Thu Aug 1 17:06:05 CST 2013 x86_64 x86_64 x86_64 GNU/Linux
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 14.04.5 LTS
Release:        14.04
Codename:       trusty

I am surprised we cannot reproduce?

The conda build of LLVM applies 4 patches from the LLVM bug tracker that have not been merged yet:
https://github.com/numba/llvmlite/blob/master/conda-recipes/llvmdev/meta.yaml#L16-L23
(The comments give links for each patch.)
I think the next step will be for @sklam to build without those patches and see if the problem appears.

I have verified the problem is not present in the conda packages (on the same system):
Python 2.7.12 |Anaconda 4.2.0 (64-bit)| (default, Jul  2 2016, 17:42:40)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)] on linux2

conda                     4.2.13                   py27_0
llvmlite                  0.14.0                   py27_0
numba                     0.29.0              np111py27_0

I cannot see that any of those patches have anything to do with the error, but I guess it must be somewhere in there.

The only other possibly relevant difference is that we compile LLVM with gcc 4.8 on CentOS 5.

I can reproduce now.  Our build recipe didn't enable assertion.  Building with assertion reveals the error.