ios Orientation.lockToLandscape() Error

*** Terminating app due to uncaught exception 'UIApplicationInvalidInterfaceOrientation', reason: 'Supported orientations has no common orientation with the application, and [RCCTabBarController shouldAutorotate] is returning YES'
*** First throw call stack:
What problem?
please help me

Same issue around here.

Same issue here.

I found a solution,  just add supportedOrientations={['portrait', 'landscape']} on my Modal component.

Can you allow both portrait and landscape but still lock it on only one of them ?

I'm having the same issue. Did anyone find a solution?

Hey @andyesp, my workaround was create a timeout before lockToLandscape, Something like this
setTimeout(function(){ Orientation.lockToLandscape(); }, 100)

I am using a component with webview and setTimeout did not solve =/

Got the same error.
There is my analysis (I know nothing on iOS native development, so this is mainly trial/error, code reading and logic) :

You request to lock to landscape so supportedInterfaceOrientationsForWindow returns now 'Landscape'.
You're phone is still in Portrait position. Portrait is not Landscape : Supported orientations has no common orientation with the application
Some controller somewhere says : You should be able to autorotate. [RCCTabBarController shouldAutorotate] is returning YES
iOS catches the incoherence and crashes.

As a workaround, I edit my controller.

Import "Orientation.h"
Changes return YES by return  [Orientation getOrientation] == UIInterfaceOrientationMaskAllButUpsideDown
Dirty but it works.

+1

I got this error while using a Modal and the solution at https://github.com/yamill/react-native-orientation/issues/246#issuecomment-347427696 fixed it for me.

I got this error while using a Modal and the solution at #246 (comment) fixed it for me.

Thanks. Error with modal for me.

the issue still unresolved for 4 Years :))

yes, I am facing the same issue.
Can anyone help me to resolve this?
I have updated all of my Modals like below:
<Modal
        visible={true}
        supportedOrientations={['portrait', 'landscape']}
      >
      </Modal>

please, any help?


Use prebuilt static image from distroless mirror

Use prebuilt static distroless image with 1337:1337 user/group

@sergii-ssh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
9a9dd7fa2d5f3d07a2e6ac1dbcefc81a140ca31c
link
true
/test release-notes_istio

unit-tests_istio
9a9dd7fa2d5f3d07a2e6ac1dbcefc81a140ca31c
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@sergii-ssh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
9a9dd7fa2d5f3d07a2e6ac1dbcefc81a140ca31c
link
true
/test unit-tests_istio

release-notes_istio
9a9dd7fa2d5f3d07a2e6ac1dbcefc81a140ca31c
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Workbench Panels are not handling tokens with multiple values correctly.

Linked ES Issue: https://jira.splunk.com/browse/SOLNESS-24192
Workbench panel 'Get Parent Process Info' and the prebuilt panel 'workbench_panel_get_parent_process_info' which it uses don't function correctly when the multiple artifacts of an ES investigation are explored. The search query in the panel 'workbench_panel_get_parent_process_info' doesn't consider that the tokens used in the query may have multiple values which may need to be 'AND'ed or 'OR'ed. Along with that, the 'Get Parent Process Info' workbench panel also needs to be modified to correctly use 'Value Prefix', 'Value Suffix' and delimiters taking multiple values for the tokens into account.
There are other workbench panels like 'Get Authentication Logs For Endpoint' and 'Get Process Information For Port Activity' which also face the same issue.

@knadkarni-splunk : those work bench searches are intended to work with single artifacts only. There is no easy way currently to customize those with our current tooling.

@patel-bhavin Can't the panels be designed to take multiple values for tokens into account (Using delimiters ,value prefix and value suffix)? Can this be addressed in an upcoming release?

@knadkarni-splunk : After doing a bunch of testing/tweaks with our current script that generates es_investigations.conf , it seems like we might be able to handle multiple values.
That said, it looks like a size-able amount of work as we'd have to update all the searches in the response tasks directory. Will keep you posted on when this will be ready

@P4T12ICK : tracking this in https://github.com/splunk/security-content/pull/new/workbench_issue_697

This issue is fixed in 3.10.0. Thank you @knadkarni-splunk for creating this and giving details


ldc can't link embedded python properly on ubuntu

and probably anywhere Py_ENABLE_SHARED is false.
symptom:
ImportError: /usr/lib/python3/dist-packages/numpy/core/multiarray.cpython-32mu.so: undefined symbol: PyExc_SystemError
ramification:
can't use numpy and other extensions
solution: insert -rdynamic early in the link flags. unfortunately, ldc rearranges flag order, and exposes no way to override.
other solution: go back to gcc for link command. please no.

Is -rdynamic the only possible workaround? Quick googling shows that many solve this problem just by adding  dlopen("libpython<PYTHON_VERSION>.so.1", RTLD_LAZY | RTLD_GLOBAL); before Py_Initialize()

LDC has recently changed the linker flag order behavior. Please try again, and otherwise open an issue with LDC, thanks!

I assume this would be in 1.6?

Yes indeed, 1.6.0 has that.

Ok. will check it out when I  get some time.

there wouldn't happen to be a quicker way to install than build from source, would there? on 16.04, apt-get serves 0.17.1

curl -fsS https://dlang.org/install.sh | bash -s install ldc

https://dlang.org/download.html

@JohanEngelen
FYI: We can do it even a bit shorter: curl i.dlang.io | bash -s ldc
Since yesterday we also have a documentation page for the installer: https://dlang.org/install.html

Looks like ubuntu stopped building python with Py_ENABLE_SHARED=false, so this might not be much of an issue anymore.

@wilzbach

FYI: We can do it even a bit shorter: curl i.dlang.io | bash -s ldc

Brevity here is useless, and harms intelligibility. The original one at least makes it clear that you are downloading a shell script, and that you are installing ldc.
The installer page is very nice. (link needs to be added to the top menu!)

ubuntu 12.04 has an appropriate python build.
With pyd from master and ldc 1.6.0, the following code is sufficient to trigger the aforementioned symptom:
auto context = new InterpContext();
context.py_stmts("import numpy");

This issue has been collecting dust long enough that I do not remember how to get link to work with -rdynamic. Will need to play with it.


[DISCUSS] Add a Python interface

A Python interface would make this project more approachable to Python devs.
It's relatively easy to add an initial Python interface with Stainless, but customizations would be needed of course.
Here's an example repo that's built with Stainless.
Let me know what you think!

Thanks for bringing this up! I've been using PyIceberg to talk with the Iceberg REST interface:

Some things don't work yet (creating tables), but that will hopefully be resolved soon 👍

@Fokko - oh, that's cool 😎
Here's the video where the Daft team talks about the Python interface they created.
Do you think we should also add a pip install unitycatalog like interface where devs can access this lib directly via Python?

Do you think we should also add a pip install unitycatalog like interface where devs can access this lib directly via Python?

For sure, I think there is room for another library that talks unity REST API. 👍

I think it's healthiest to probably have:

SDK generated with Stainless (in lock-step with the OpenAPI spec)

A higher-level Python SDK if you envision deeper integrations with other tools such as Daft, Pandas, Polars etc. basically it would chain the API calls for higher level functionality such as reading tables into other frameworks.

A higher-level Python SDK if you envision deeper integrations with other tools such as Daft, Pandas, Polars etc. basically it would chain the API calls for higher level functionality such as reading tables into other frameworks.

I believe we should also be able to do this within the same unitycatalog package, offering both the low level and high level apis for engine developers / end users respectively.


WithHealth: Wait 2s before showing not synced (fix #262)

Since I couldn't reproduce myself, can you package the .dmg and post it here?

I don't think it's possible to build the .dmg from Linux with electron-builder

For some reason I forgot you were on linux, then let's merge and I'll send the .dmg to Björn for testing


 There is likely additional logging output above.
10287 verbose exit [ 1, true ]

_

It failed on

Minimal Qt 5.14.1 setup:
Archive already exists at /Users/zhoux/Library/Caches/nodegui-mini-qt-nodejs/5.14.1-0-202001241000qttools-MacOS-MacOS_10_13-Clang-MacOS-MacOS_10_13-X86_64.7z. Skipping download....
Extracting /Users/zhoux/Library/Caches/nodegui-mini-qt-nodejs/5.14.1-0-202001241000qttools-MacOS-MacOS_10_13-Clang-MacOS-MacOS_10_13-X86_64.7z to /Users/zhoux/sites/github/svelte-projects/svelte-nodegui-starter/node_modules/@nodegui/nodegui/miniqt ...
Archive already exists at /Users/zhoux/Library/Caches/nodegui-mini-qt-nodejs/5.14.1-0-202001241000qtbase-MacOS-MacOS_10_13-Clang-MacOS-MacOS_10_13-X86_64.7z. Skipping download....
Extracting /Users/zhoux/Library/Caches/nodegui-mini-qt-nodejs/5.14.1-0-202001241000qtbase-MacOS-MacOS_10_13-Clang-MacOS-MacOS_10_13-X86_64.7z to /Users/zhoux/sites/github/svelte-projects/svelte-nodegui-starter/node_modules/@nodegui/nodegui/miniqt ...
Qt Tools for Minimal Qt: 5.14.1 installation was setup successfully.  outDir: /Users/zhoux/sites/github/svelte-projects/svelte-nodegui-starter/node_modules/@nodegui/nodegui/miniqt
Qt Base for Minimal Qt: 5.14.1 installation was setup successfully.  outDir: /Users/zhoux/sites/github/svelte-projects/svelte-nodegui-starter/node_modules/@nodegui/nodegui/miniqt

<EMAIL_ADDRESS>prebuild:install /Users/zhoux/sites/github/svelte-projects/svelte-nodegui-starter/node_modules/@nodegui/nodegui
prebuild-install --backend=cmake-js --runtime=napi --verbose

prebuild-install info begin Prebuild-install version 5.3.6
prebuild-install info looking for cached prebuild @ /Users/zhoux/.npm/_prebuilds/f8b84e-nodegui-v0.25.0-napi-v3-darwin-x64.tar.gz
prebuild-install http request GET https://github.com/nodegui/nodegui/releases/download/v0.25.0/nodegui-v0.25.0-napi-v3-darwin-x64.tar.gz
prebuild-install http 404 https://github.com/nodegui/nodegui/releases/download/v0.25.0/nodegui-v0.25.0-napi-v3-darwin-x64.tar.gz
prebuild-install WARN install No prebuilt binaries found (target=3 runtime=napi arch=x64 libc= platform=darwin)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>prebuild:install: prebuild-install --backend=cmake-js --runtime=napi --verbose
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prebuild:install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?
npm ERR!  Failed at the<EMAIL_ADDRESS>prebuild:install script.

That’s failed on one of NodeGUI’s install scripts; could you file this issue on the NodeGUI repo instead? I myself am not sure how its installation process works.

Thought: it may (or may not) be something to do with the path at which you installed it containing unsafe punctuation:
https://github.com/nodegui/nodegui/issues/827


Text Embedding Inference Server

Trying to follow the directions in the FAQ for setting up TEI and as far as I can tell, they're full of errors, at least for my windows environment. Considering there's no mention of linux or windows and you're obviously catering to windows users as well, this is a frustrating problem (and far too common in this space).
Regarding
docker run -d --gpus '"device=0"' --shm-size 3g -v $HOME/.cache/huggingface/hub/:/data -p 5555:80 --pull always ghcr.io/huggingface/text-embeddings-inference:0.6 --model-id BAAI/bge-large-en-v1.5 --revision refs/pr/5 --hf-api-token=$HUGGING_FACE_HUB_TOKEN --max-client-batch-size=4096 --max-batch-tokens=2097152
'"device=0"'
throws an error. Needs to be 0.
$HOME/.cache/huggingface/hub/:/data
throws an error. On windows, you probably don't want to do this for performance reasons, but
C:\Users\[user]\.cache\huggingface\hub\:/data
works.
"Then for h2oGPT ensure pass:" makes no sense. What is this supposed to mean? I'm guessing you mean you should run something like:
C:\Users\[user]\AppData\Local\Programs\h2oGPT\Python\python.exe "C:\Users\[user]\AppData\Local\Programs\h2oGPT\h2oGPT.launch.pyw" --hf_embedding_model=tei:http://localhost:5555 --cut_distance=10000
--hf_embedding_model=tei:http://localhost:5555 --cut_distance=10000
throws an error:
ValueError: Path tei:http://localhost:5555 not found
I haven't been able to fix that one because I don't even know where to start.
"or whatever address is required." is not helpful
C:\Users\J\AppData\Local\Programs\h2oGPT\..\src
C:\Users\J\AppData\Local\Programs\h2oGPT\pkgs\..\src
C:\Users\J\AppData\Local\Programs\h2oGPT\..\iterators
C:\Users\J\AppData\Local\Programs\h2oGPT\pkgs\..\iterators
C:\Users\J\AppData\Local\Programs\h2oGPT\..\gradio_utils
C:\Users\J\AppData\Local\Programs\h2oGPT\pkgs\..\gradio_utils
C:\Users\J\AppData\Local\Programs\h2oGPT\..\metrics
C:\Users\J\AppData\Local\Programs\h2oGPT\pkgs\..\metrics
C:\Users\J\AppData\Local\Programs\h2oGPT\..\models
C:\Users\J\AppData\Local\Programs\h2oGPT\pkgs\..\models
C:\Users\J\AppData\Local\Programs\h2oGPT\..\.
C:\Users\J\AppData\Local\Programs\h2oGPT\pkgs\..\.
Torch Status: have torch: True need get gpu torch: False CVD: None GPUs: 1
Fontconfig error: Cannot load default config file: No such file: (null)
fatal: not a git repository (or any of the parent directories): .git
Traceback (most recent call last):
  File "C:\Users\J\AppData\Local\Programs\h2oGPT\h2oGPT.launch.pyw", line 35, in <module>
    main()
  File "C:\Users\J\AppData\Local\Programs\h2oGPT\pkgs\win_run_app.py", line 150, in main
    _main()
  File "C:\Users\J\AppData\Local\Programs\h2oGPT\pkgs\win_run_app.py", line 136, in _main
    main_h2ogpt()
  File "C:\Users\J\AppData\Local\Programs\h2oGPT\generate.py", line 12, in entrypoint_main
    H2O_Fire(main)
  File "C:\Users\J\AppData\Local\Programs\h2oGPT\src\utils.py", line 65, in H2O_Fire
    fire.Fire(component=component, command=args)
  File "C:\Users\J\AppData\Local\Programs\h2oGPT\pkgs\fire\core.py", line 141, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "C:\Users\J\AppData\Local\Programs\h2oGPT\pkgs\fire\core.py", line 475, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "C:\Users\J\AppData\Local\Programs\h2oGPT\pkgs\fire\core.py", line 691, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "C:\Users\J\AppData\Local\Programs\h2oGPT\src\gen.py", line 1664, in main
    model=get_embedding(use_openai_embedding, hf_embedding_model=hf_embedding_model,
  File "C:\Users\J\AppData\Local\Programs\h2oGPT\src\gpt_langchain.py", line 461, in get_embedding
    embedding = HuggingFaceEmbeddings(model_name=hf_embedding_model, model_kwargs=model_kwargs)
  File "C:\Users\J\AppData\Local\Programs\h2oGPT\pkgs\langchain_community\embeddings\huggingface.py", line 65, in __init__
    self.client = sentence_transformers.SentenceTransformer(
  File "C:\Users\J\AppData\Local\Programs\h2oGPT\pkgs\sentence_transformers\SentenceTransformer.py", line 77, in __init__
    raise ValueError("Path {} not found".format(model_name_or_path))
ValueError: Path tei:http://localhost:5555 not found

It's true that things in the FAQ are heavily geared towards linux/x86 explanations.  One would need to be able to understand both and translate to windows.

If you are using the one-click windows installer as a base, that will also be behind main branch.  If you want to keep up with bleeding edge that's in main, need to use the manual installer.  I only added TEI 1 week ago.
It's not hard, it's just a script that's run.  Then it will be able to work with that FAQ element.

@ChathurindaRanasinghe is working on a stable release, it's been in works, but our company is too small to do everything you are asking for.

Good luck.


[Provider Audit] provider.validatornode.com

We have completed all the prerequisite steps as outlined below. If you could review/audit our provider we'd be appreciative.
Our contact information follows

Name                                                       ValidatorNode
Discord handle or Telegram handle        ourlink_validatornode
Contact email address<EMAIL_ADDRESS>
Provider details are - provider.validatornode.com
URL - https://provider.validatornode.com:8443
Address - akash1whyxrlu7srr55kte4w2rxlmvzduj3je0gqlzjn
Prerequisite Steps:
1. Make sure your provider has community provider attributes:
  Example:
  $ provider-services query provider get akash1<REDACTED> -o text
  ...
  attributes:
  ...
  - key: host
  value: akash
  - key: tier
  value: community

Ref documentation:.
2. Make sure your provider *.ingress resolves to your provider IP (ideally worker node IP)
host <anything>.ingress.<yourdomain>

Example:
$ host anything.ingress.akash.pro
anything.ingress.akash.pro is an alias for nodes.akash.pro.
nodes.akash.pro has address <IP_ADDRESS>

More info on what DNS records should look like are available in the Akash Documentation here.

3. Please make sure your Akash provider doesn't block any Akash specific ports.

If you are using a firewall, please follow this doc:
https://docs.akash.network/providers/build-a-cloud-provider/akash-cloud-provider-build-with-helm-charts/step-9-firewall-rule-review
If you are behind NAT, then you need to make sure these ports are open between your provider worker nodes and the internet.

Audit Steps:
1. Title the issue: " [Provider Audit]: Provider Address" (e.g. "[Provider Audit]: provider.europlots.com")
2. Wait for response via comments. If no issues during provider Audit, process will be complete, provider should start bidding on leases, and Audit ticket will be closed.
3. If there are issues during the provider Audit, debug those issues, and Audit will be complete.
4. Audit Issue will be closed by core team member.

:red_circle:  I am not getting the bids for dseq 13841271
you can see your provider logs for additional information using this command:

kubectl -n akash-services logs akash-provider-0 --tail=1000000 | grep 13841271

it is possible that you haven't upgraded your provider for the mainnet8 yet or your RPC is out of sync, please provide me with the outputs from running these commands:
kubectl -n akash-services get pods -o custom-columns='NAME:.metadata.name,IMAGE:.spec.containers[*].image'

kubectl -n akash-services get pods

kubectl get events -A --sort-by='{.metadata.creationTimestamp}'

kubectl get pods -A --sort-by='{.metadata.creationTimestamp}'

If you did upgrade to the mainnet8 and your RPC node seem to be working (i.e. indexing the blocks) then you may just need to bounce the akash-provider pod using this command:
kubectl -n akash-services delete pod akash-provider-0

:yellow_circle:  you are exposing beta3 storage class, yet you aren't offering it:

$ provider-services query provider get akash1whyxrlu7srr55kte4w2rxlmvzduj3je0gqlzjn -o text
...
- key: capabilities/storage/1/class
  value: beta3
- key: capabilities/storage/1/persistent
  value: "true"
- key: capabilities/storage/2/class
  value: beta3
- key: capabilities/storage/2/persistent
  value: "true"

this is not a big issue, you can always add it later.
But it is better if you only add these attributes when your provider actually provides the persistent storage.
Also, the 1st class should have default value instead of beta3, e.g.:
- key: capabilities/storage/1/class
  value: default
- key: capabilities/storage/1/persistent
  value: "true"
- key: capabilities/storage/2/class
  value: beta3
- key: capabilities/storage/2/persistent
  value: "true"

Can you submit another deployment and check for bids?
I believe our RPC Node was off-line during the last audit testing. We had maintenance scheduled on the node and unfortunately, the tech forgot to restart the server when the network changes were complete. As for now, everything is up and running as expected.
As for our storage classes, we set them to beta3 but the keep defaulting back to SSDHD. Any ideas?

We have this in our provider.yaml file
feat-persistent-storage
true
capabilities/storage/1/class
default
capabilities/storage/1/persistent
true
capabilities/storage/2/class
beta3
capabilities/storage/2/persistent
true

But when we look at our listing on the cloudmos.io site we see this (see attached image)

;

ingress test :green_circle:
$ curl d4stsgbmupd57efiqmet15jk9g.ingress.validatornode.com
<!DOCTYPE html>

$ curl -k https://d4stsgbmupd57efiqmet15jk9g.ingress.validatornode.com
<!DOCTYPE html>

nodePort test :green_circle:
speedtest :green_circle:
root@app-b5bb56766-n4fz8:~# speedtest
Retrieving speedtest.net configuration...
Testing from Choopa, LLC (<IP_ADDRESS>)...
Retrieving speedtest.net server list...
Selecting best server based on ping...
Hosted by PFM Host (New York, NY) [42.37 km]: 4.567 ms
Testing download speed................................................................................
Download: 628.07 Mbit/s
Testing upload speed......................................................................................................
Upload: 952.73 Mbit/s

disk speed tests :green_circle:
root@app-b5bb56766-n4fz8:~# curl -sL yabs.sh | bash -s -- -ig
# ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## #
#              Yet-Another-Bench-Script              #
#                     v2023-11-30                    #
# https://github.com/masonr/yet-another-bench-script #
# ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## ## #

Wed Dec  6 10:02:40 UTC 2023

Basic System Information:
---------------------------------
Uptime     : 7 days, 12 hours, 19 minutes
Processor  : Intel Xeon Processor (Cascadelake)
CPU cores  : 8 @ 2992.968 MHz
AES-NI     : ✔ Enabled
VM-x/AMD-V : ❌ Disabled
RAM        : 15.6 GiB
Swap       : 0.0 KiB
Disk       : 328.1 GiB
Distro     : Ubuntu 22.04.3 LTS
Kernel     : 5.10.0-25-amd64
VM Type    :
IPv4/IPv6  : ✔ Online / ❌ Offline

IPv4 Network Information:
---------------------------------
ISP        : The Constant Company
ASN        : AS20473 The Constant Company, LLC
Host       : Vultr Holdings, LLC
Location   : Piscataway, New Jersey (NJ)
Country    : United States

fio Disk Speed Tests (Mixed R/W 50/50) (Partition overlay):
---------------------------------
Block Size | 4k            (IOPS) | 64k           (IOPS)
  ------   | ---            ----  | ----           ----
Read       | 140.26 MB/s  (35.0k) | 743.30 MB/s  (11.6k)
Write      | 140.63 MB/s  (35.1k) | 747.21 MB/s  (11.6k)
Total      | 280.89 MB/s  (70.2k) | 1.49 GB/s    (23.2k)
           |                      |
Block Size | 512k          (IOPS) | 1m            (IOPS)
  ------   | ---            ----  | ----           ----
Read       | 1.12 GB/s     (2.1k) | 1.23 GB/s     (1.2k)
Write      | 1.18 GB/s     (2.3k) | 1.32 GB/s     (1.2k)
Total      | 2.30 GB/s     (4.5k) | 2.55 GB/s     (2.4k)

YABS completed in 35 sec

provider signed!
tx 15D4D79DAC53BFD5C92B4A8A8D6C3FF440E62D394A2C6F36DA7C29EF3C1D3A53

But when we look at our listing on the cloudmos.io site we see this (see attached image)

For the cloudmos related questions - please seek the support in the #ecosystem-cloudmos Akash Network Devs discord.


Move shared services into Porter bundles

PR for issue https://github.com/microsoft/AzureTRE/issues/1177
NOTE: This PR is stacked onto https://github.com/microsoft/AzureTRE/pull/1219
What is being addressed
Currently, shared services (Firewall, Gitea and Nexus) are deployed as part of make tre-deploy command and are part of core terraform module.
That makes it impossible to opt out of Firewall, and cumbersome to configure whether Gitea or Nexus should be deployed.
In this pull request, Porter bundles are made for these shared services.
This PR is also ground work for automatic update of shared services in the future (https://github.com/microsoft/AzureTRE/issues/23).
How is this addressed

[x] Moved firewall terraform module to shared services
[x] Merged routetable and terraform modules, as their functionality is very similar
[x] Initialised Porter bundles for Terraform, Gitea and Nexus
[x] Testing strategy: While I carefully eyeballed terraform plan output to make sure there are no unexpected changes, I did not run E2E tests (as they require additional set up). A successful run on CI of these before merging this branch is needed.

Note: Bug in Terraform provider
It turns out that Azure Firewall currently can't be destroyed from Terraform (but can from Portal).
Link to the issue in the azurerm Terraform provider: hashicorp/terraform-provider-azurerm#14866
To deploy this change, we would have to ask everybody to manually delete Firewall in their dev deployment, as well as delete it manually for the CI deployment.
Note: Creation of the Service Principal
Following merge of this pull requests, developers will have to create a Service Principal if needed to deploy Firewall, Gitea or Nexus. A doc will be created on Wiki / in Markdown on how to do this.

This PR has now moved to here:  https://github.com/microsoft/AzureTRE/pull/1226
(I couldn't change the base branch to be in upstream, and not in fork :( )


Faction code

Based on #85
Move as much faction code as possible to the faction files.

I added a 'new-changes' branch on gaia-viewer to adapt it to the changes, if you want to test them with viewer.

@rzulian If you approve all three PRs you can just merge this one & close the others.


SAMZA-2550: Move side input processing to use RunLoop

Issues: Side input consumption / processing currently happens in two threads in ContainerStorageManager; one thread polling messages from SystemConsumers and writing entries to the stores, and another thread executing store flush.
Moving this processing to RunLoop will simplify further changes needed to support transactional state in standby containers, as that requires ssp/task level choose control and queuing of messages within a task, something that RunLoop already does.
Other benefits of this change include making it easier in the future to implement features like broadcast streams, side input priorities, side input concurrency etc. It is also an incremental step toward addressing SAMZA-2494, which may require side inputs to eventually be merged back into SamzaContainer's RunLoop instance in order for side input exceptions to be propagated back to container.
Changes: Consolidates the two side input threads in ContainerStorageManager by instead constructing instances of SideInputTask which are executed by a single RunLoop instance/thread.
New side input processing metrics emitted by SamzaContainerMetrics and TaskInstanceMetrics are given their own namespace in order to differentiate from the primary container / run loop.
Tests: Existing tests are left in place.
API Changes: None.
Upgrade Instructions: None.
Usage Instructions: None.

@lakshmi-manasa-g @bharathkk can you help review this?


Different issue points when using FileTransform@2

Question, Bug, or Feature?
Type: Bug
Enter Task Name: FileTransform@2
Environment
Server - Azure Pipelines
Issue Description
When using FileTransform@2 to tranform config files after build we are experiencing some weird behaviour...
If we run the above pipeline with the same two inputfiles, we get different errors on each run. Some runs it finishes an action at a point where it failed in the previous run.
The pipeline step
    steps:     - task: FileTransform@2       inputs:         folderPath: '$(System.DefaultWorkingDirectory)'         xmlTransformationRules: '-transform buildFiles\App.Debug.config -xml BuildFiles\App.config -result $(artifactBatchConfig)'
Task logs
Executing SetAttributes (transform line 41, 164)
System.NullReferenceException: Object reference not set to an instance of an object.
at Microsoft.Web.XmlTransform.XmlTransformationLogger.ConvertUriToFileName(XmlDocument xmlDocument)
at Microsoft.Web.XmlTransform.XmlTransformationLogger.LogWarning(XmlNode referenceNode, String message, Object[] messageArgs)
at Microsoft.Web.XmlTransform.Transform.ApplyOnAllTargetNodes()
Exception while transforming: System.NotSupportedException: The given path's format is not supported.
at System.Security.Permissions.FileIOPermission.EmulateFileIOPermissionChecks(String fullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.StreamWriter.CreateFile(String path, Boolean append, Boolean checkHost)
at System.IO.StreamWriter..ctor(String path, Boolean append, Encoding encoding, Int32 bufferSize, Boolean checkHost)
at System.IO.File.InternalWriteAllText(String path, String contents, Encoding encoding, Boolean checkHost)
at OutcoldSolutions.ConfigTransformationTool.TransformationTask.Execute(String destinationFilePath, Boolean forceParametersTask).
on /configuration/securityConfiguration/authorizationProviders/add/rules/add[@name='AnsoegningRKI_Gem']
Applying to 'add' element (no source line info)
Set 'name' attribute
Set 'expression' attribute
Set 2 attributes
Done executing SetAttributes
Executing SetAttributes (transform line 42, 177)
on /configuration/securityConfiguration/authorizationProviders/add/rules/add[@name='AnsoegningRKI_CheckFirmaRKIGem']

Set 'expression' attribute
System.NullReferenceException: Object reference not set to an instance of an object.
at Microsoft.Web.XmlTransform.XmlTransformationLogger.ConvertUriToFileName(XmlDocument xmlDocument)
at Microsoft.Web.XmlTransform.XmlTransformationLogger.LogWarning(XmlNode referenceNode, String message, Object[] messageArgs)
at Microsoft.Web.XmlTransform.Transform.ApplyOnAllTargetNodes()
Exception while transforming: System.NotSupportedException: The given path's format is not supported.
at System.Security.Permissions.FileIOPermission.EmulateFileIOPermissionChecks(String fullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.StreamWriter.CreateFile(String path, Boolean append, Boolean checkHost)
at System.IO.StreamWriter..ctor(String path, Boolean append, Encoding encoding, Int32 bufferSize, Boolean checkHost)
at System.IO.File.InternalWriteAllText(String path, String contents, Encoding encoding, Boolean checkHost)
at OutcoldSolutions.ConfigTransformationTool.TransformationTask.Execute(String destinationFilePath, Boolean forceParametersTask).
Set 2 attributes
Done executing SetAttributes
Executing SetAttributes (transform line 38, 165)
on /configuration/securityConfiguration/authorizationProviders/add/rules/add[@name='AnsoegningRKI_Hent']
If we run the same two files through this powershell it works as expected (as it does in Visual Studio build as well)
`function applyConfigTransformation($src,$xdt,$dst){
Add-Type -Path "C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Microsoft\VisualStudio\v16.0\Web\Microsoft.Web.XmlTransform.dll"
try{
$doc = New-Object Microsoft.Web.XmlTransform.XmlTransformableDocument
$doc.PreserveWhiteSpace = $true
$doc.Load($src)
$trn = New-Object Microsoft.Web.XmlTransform.XmlTransformation($xdt)
if ($trn.Apply($doc)){
  $doc.Save($dst)
}
else{
  throw "Transformation terminated with status False"
}

}
catch{
Write-Output $Error[0].Exception
}
}`

@AllanMichaelsen  Can you please set the variable "System.debug" with value "true". Redeploy and share logs at RM_Customer_Queries at microsoft dot com

@AllanMichaelsen  Can you please confirm if you're still facing the issue? I haven't received any logs from you until now. Thanks!

Sorry for the late reply. A decision was made to transform in the project file instead as there was no time to wait for a solution. If no one else is experiencing this issue it could be a problem in the file structure somehow but I can't say for sure.
I can't send further logs as transformation in this manner has been stopped.

From: Eavanshi Arora<EMAIL_ADDRESS>Sent: Wednesday, December 18, 2019 8:41:31 AM
To: microsoft/azure-pipelines-tasks<EMAIL_ADDRESS>Cc: Allan Michaelsen<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/azure-pipelines-tasks] Different issue points when using FileTransform@2 (#11856)
@AllanMichaelsenhttps://github.com/AllanMichaelsen Can you please confirm if you're still facing the issue? I haven't received any logs from you until now. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/azure-pipelines-tasks/issues/11856?email_source=notifications&email_token=AKCYMKHH4GMEFM6ZVZWNSITQZHH2XA5CNFSM4JSQG4OKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHFHFNI#issuecomment-566915765, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKCYMKHQRHW4BT2U2363Q2TQZHH2XANCNFSM4JSQG4OA.

Closing this in that case. Please comment if you face the issue again in the future.


handle truncated images

Also logs the file path for any images that cause an exception

LGTM, thanks!


Update README: Fix a minor space issue

Fixes: #108
Signed-off-by: Nitesh Konkar<EMAIL_ADDRESS>

lgtm

lgtm


Made the nav-bar anchored and added CSS for the dark mode

Related Issue
Making the navbar anchored for better navigation.
Closes: #134
Are you creating this PR under Hacktoberfest
Yes, I'm opening this PR under hacktoberfest.
Describe the changes you've made
I've made changes to the HTML pages index, contact and resources. Also I've added some styling to CSS.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.

Screenshots

@centurion6x Great work, Thank you for contributing.

It's been an amazing experience. Also, I'm working on the other issue. I'll put a pr once I finish.


Evaluate on test more often than once per epoch

An epoch can last a long time, maybe even the whole training duration
https://github.com/lucidrains/DALLE2-pytorch/blob/main/train_decoder.py#L328
Introducing a eval_every_n_steps param would be great

In parallel with this, I think we need to also a parameter for quantifying how much time is spent doing evaluation versus training. Evaluation is an incredibly heavy operation because it involves sampling hundreds of images from the decoder and as such may take as much time as an entire training loop if parameters are set up naively. In this case, doing multiple evaluations per epoch would be very wasteful. This is useful for large scale distributed runs where the training loop will be many millions of samples, but should not be encouraged for anything below around 5 million sample training loops.

save_every_n_samples": 2000000 and epoch_samples": 10000000 are not super convenient
because what would be much better is "sample every N minutes" and "evaluate every N minutes"
like every hour is good and that vary wildly depending on sample/s


raw asserts and assertions can return promises

All asserts expose a raw assert (that doesn't emit events etc, just return a promise that is rejected or resolved depending on the outcome of the assert).
Since raw asserts return a promise to communicate it's outcome I made it possible for an assert function to return a promise as an alternative to just true or false. This opens up for asynchronous asserts but a deferred resolution will not work ATM for integrators that rely on exceptions to be thrown as failures.
The current tests for failure in test-helper spy on referee.fail. This makes things a bit harder than if they would just look for emission of fail, error or pass. If calling of fail was not part of the contract one could make have more elegant handling of exceptions for failures.
Don't be afraid to hurt my feelings codewise. I think the rawAssert could be more elegant in supporting promises from assert-function but my imagination failed me at the moment.

I would like to use the term plain on concept level and test on code level.
Thus we would have a unit test "assertions expose plain asserts via test method".
@cjno, does something speak against it?

Not that I can think about.

:+1:


Default to Apache Kafka instead of Redpanda

We chose to use Redpanda over Apache Kafka (AK) for our testing as it has a noticeably lower footprint.
However, Redpanda is licensed under BUSL which can be problematic for some organizations. Further, as Dependency-Track is an OSS project under a truly open foundation (OWASP), we should not depend on commercial solutions per default. Instead, we should default to Apache Kafka, which is Apache-2.0 licensed, just like DT itself.
Further, we may want to replace Redpanda Console with something like https://github.com/provectus/kafka-ui (for the same licensing reason).
In summary, the following needs to be done:

The default docker-compose.yml should use Apache Kafka

~We can use the bitnami/kafka image which supports KRaft and does not depend on Zookeeper~
Should use official apache/kafka image, see https://github.com/DependencyTrack/hyades/issues/854#issuecomment-1980594100
Should consider using apache/kafka-native variant, see https://github.com/DependencyTrack/hyades/issues/854#issuecomment-2199485302

e2e tests should either:

Use AK instead of Redpanda
Run against both AK and Redpanda

Continuing to use Redpanda in unit and integration tests is fine

We should still test how AK behaves here, perhaps it's not as bad as we think
AK-powered dev services are available through Strimzi

As of v3.7.0, Kafka has an official Docker image now:

https://hub.docker.com/r/apache/kafka
https://github.com/apache/kafka/blob/trunk/docker/examples/README.md
https://github.com/apache/kafka/blob/trunk/docker/examples/jvm/single-node/plaintext/docker-compose.yml

Requested addition of Apache Kafka native to Quarkus Dev Services here: https://github.com/quarkusio/quarkus/issues/43272


fixed a bad link for local dev page

Description
I noticed this routed to an old page on the old dev site
Reviewer Notes
Maybe confirm this is the page we intended to route to.
Related Issue(s) / Ticket(s)
n/a
Screenshot(s)
n/a

@mmfred can you confirm if this is the page where this was intended to route to?

going to merge then fix this based on @mmfred suggestions.


Is this PAID?

Looks like even when running locally it needs the services of leap which seem to be always paid for
If that's the case not cool, as this is advertised as open source
Hope I am wrong :)

Hi @Sequential-circuits! If you have a powerful GPU at home, you can write your own code to run stable diffusion training and inference locally and tweak the code to work with your setup.
Feel free to leverage any parts of the template that are helpful!


Run Error

I Try you library always error after login success...!

but is oke for send & receive message

Hey, thanks for trying out the library!
I have just tried it again and I can't reproduce your error. So it would be interesting to know which message should be decoded and causes the error.
You could change the readNode method within the BinaryDecoder class to find out what the message contains.
Something like this:
// Conversation messages
case BinaryConstants.Tags.BINARY_8:
    byte[] bin8 = readBytes(readByte() & 0xff);

    // Insert here
    System.out.println("BIN8: " + new String(bin8));

    base64Decoded = Base64.getEncoder().encodeToString(
    WebMessageInfo.parseFrom(bin8).toByteArray());

    break;

Be aware that the message may contain personal information before you post it.
For now you may comment out the exception if it should bother you.
Thanks again for helping!

***** No personal information here 😄  *****
This is end before error :

Hm, that's strange.
The "message" messages are always encoded in protobuf format, so it's strange that the message is directly readable without artifacts.
Can you tell me if this is a "normal" text message or something else?
I would guess that this is a status message, right?
In fact, I have never tested status messages that contain only text, because for some reason they don't load on my device and I never bothered about it :satisfied:

I would guess that this is a status message, right?
yes this status message.....

Yes.... This bug, after the status message has been more than 24 hours and there are no more, there are no errors
Thanks job 👍


[Doc Improvement][Microsoft Entra typo fixes][4223172]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/bot-features.md
90
14
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Enable GuardDuty in all enabled by default regions

This PR enables GuardDuty in all remaining AWS 'enabled by default' regions and enrols all currently enrolled accounts from eu-west-1 and eu-west-2, including:

us-east-1
us-east-2
us-west-1
us-west-2
ap-south-1
ap-northeast-2
ap-southeast-1
ap-southeast-2
ap-northeast-1
ca-central-1
eu-central-1
eu-west-3
eu-north-1
sa-east-1

AWS best practices
AWS recommend that AWS GuardDuty is enabled in all supported regions. Due to the way GuardDuty works, GuardDuty only reports findings in originating regions to ensure data analysed doesn't cross AWS regional boundaries. For global services, findings are tied to us-east-1.
Cost
As most of the above regions shouldn't/won't be being used by teams, the impact of cost is likely to be very low but will likely rise in us-east-1 as we start capturing global events.
Most accounts should be enrolled in a free 30-day trial if it has not been enabled in these regions before, so we can do some analysis toward the end of that if useful.

It might be worth filtering out certain accounts until we understand the impact of cost across the MOJ /cc @TomTucka

@jakemulley Let's get this live. In terms of costs, I think we keep an eye for the next couple of months, and if the cost is prohibitive, we can address it then.


Range: How to increase the knob size?

I am using simple ion-range. I want to increase the size of the knob of the ion-range. How to set the width and height of the knob?

Hello! Thank you for opening an issue with us!
The Ionic Framework issues list is designated for the reporting of bugs with the Ionic Framework or for requesting new features. As this seems like more of a support question I am going to close this issue.
I urge that you ask this question on our forum or on our slack channel.
Thanks for using Ionic!


Added more asssertion methods

Additional assertion methods added to make it easier to cast the content of a ContentResult to a type for further assertions. This also includes an additional BeCreatedResult() assertion helper.

I think we need to have a joint talk in the ATC core team about, if we need/want to upgrade to .NET 5 and C# 9 - before we just do it - because this can have big impact.
Arguments for we do NOT do it yet, could be:
1 .NET is not in LTS yet
2. do we have full support all the way for .NET 5 and C # 9.

Revert to dotnet 3.1 - create new issue, so we can have a discussion in the ATC core team, before we go forward the this small change with a big impact.

This is not upgrading to NET5, the library still targets 3.1. I just had to update the build SDK and C# version to get it to actually build here, as it was locally. The alternative is to change the projects global.json to lock it down to the 3.1 SDK version.
Otherwise, folks like me who have .net5 installed locally will run into issues where the local build system is using NET5 SDKs and the CI is used SDK 3.1.x, potentially giving warnings and reporting things as broken, when they are not. This is due to the many more nullable annotations in .NET5, and the changes to the analyzers that are part of NET5.

@egil you need to also install the .NET Core 3.1.x SDK or runtime to be able to run the smoke tests. In my own projects I run smoke tests against .NET Standard 2.0, .NET Core 2.1 and 3.1, .NET Fx 4.7.2, and .NET 5. You can use this as a reference or I can help you


Update dw-mule-functions-lookup.adoc

{test: 'hello '} is not the valid json.
so I have correct it i.e. {"test":"hello "}
Writer's Quality Checklist
Before merging your PR, did you:

[ ] Run spell checker
[ ] Run link checker to check for broken xrefs
[ ] Check for orphan files
[ ] Perform a local build and do a final visual check of your content, including checking for:

Broken images
Dead links
Correct rendering of partials if they are used in your content
Formatting issues, such as:

Misnumbered ordered lists (steps) or incorrectly nested unordered lists
Messed up tables
Proper indentation
Correct header levels

[ ] Receive final review and signoff from:

Technical SME
Product Manager
Editor or peer reviewer
Reporter, if this content is in response to a reported issue (internal or external feedback)

[ ] If applicable, verify that the software actually got released

Thank you for your contribution, @myselfabdulqadeer. We will review and verify it. However, to merge this or future contributions from you, we require that you sign a CLA.
We might choose to create a separate PR for this issue so that we can fix the issue you report. Thx again!

The object of the example mentioned in this PR is described as a DW object which is valid. It's not necessarily a JSON object.
This PR is closed for the abovemention reason.


[Add] Logging for each message of GPTAssistant

@IANTHEREAL @ekzhu
Why are these changes needed?
It solves the logging issue with GPTAssistant Sequential chats, where only the last message of a sequential step was being logged, rather than logging each GPTAssistant Agent interaction.
Related issue number
Closes #2644
Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Added Fix to resolve #2697

@ekzhu @WaelKarkoub this check is failing "ContribTests / RetrieveChatTest-Ubuntu (3.9) (pull_request)" any idea why ? and how do we fix it ?

@ekzhu @WaelKarkoub this check is failing "ContribTests / RetrieveChatTest-Ubuntu (3.9) (pull_request)" any idea why ? and how do we fix it ?

See if adding --no-cache-dir flag to the pip install in .github/workflows/contrib-tests.yml at L110 helps

@sonichi @ekzhu @WaelKarkoub i ran the pre-commit run --all-files on my side, all the checks pass. But the workflows in github are failing, how do we fix them, and make all checks pass. Are these checks failing for other PRs as well ?

These are the error messages found from failed checks, how do we fix them during workflow runs ?

Looks like this is dormant, if you want to pick this up again please feel free to reopen. Thanks!


fe() example doesn't edit file when EDITOR contains option

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce
This is not an issue with fzf but one of the examples in the wiki. I appreciate they're maintained by the community. Please let me know where I should raise this question if it's not here.
There's an example of opening a file:
fe() {
  IFS=$'\n' files=($(fzf-tmux --query="$1" --multi --select-1 --exit-0))
  [[ -n "$files" ]] && ${EDITOR:-vim} "${files[@]}"
}

If EDITOR is set to 'gvim --remote', the follwing error occurs after picking a file:
fe:3: command not found: gvim --remote

This is fixed if I hardcode the editor in line 3:
[[ -n "$files" ]] && gvim --remote "${files[@]}"

My Linux scripting is not good enough to fix this to use the $EDITOR properly! What is the fix to stop me having to hardcode the editor and option?

This is not an issue with fzf but one of the examples in the wiki.

relevant comment by the maintainer (link to comment (14/Jul/23))

[!IMPORTANT]
junegunn:  ... the wiki needs an overhaul. The pages are written by the community, and sadly, there has been no quality control at all. I don't know which ones are working and which ones are not. But I just don't have time to go through the code.

If EDITOR is set to 'gvim --remote', the follwing error occurs after picking a file:
fe:3: command not found: gvim --remote

gvim --remote is being treated as a single command, rather than gvim as a command and --remote as an option

idea 1:  set EDITOR  as an array
export EDITOR=(gvim --remote)

fe() {
  IFS=$'\n' files=($(fzf-tmux --query="$1" --multi --select-1 --exit-0))
  [[ -n $files ]] && "${EDITOR[@]:-vim}" -- "${files[@]}"
}

idea 2: read EDITOR as string and create an editor  array
export EDITOR='gvim --remote'
# works in zsh, bash works with 'read -ra'
fe() {
 IFS=' ' read -rA editor <<< "${EDITOR:-vim}"
 IFS=$'\n' files=($(fzf-tmux --query="$1" --multi --select-1 --exit-0))
 [[ -n "$files" ]] && "${editor[@]}" -- "${files[@]}"
}

Thanks for the two ideas. The first one produces the same error. The second one is more hopeful. It opens, in gvim, the file selected but also a new (blank) buffer, which has the focus.

Thanks @LangLangBart for the reply.
Regarding the wiki, maybe we should remove the pages so as not to confuse users and migrate the examples to a new separate repository (something like fzf-examples?) and start over with a tighter review process.

The complete function is now:
fe() {
 IFS=' ' read -rA editor <<< "${EDITOR:-vim}"
 IFS=$'\n' files=($(fzf-tmux --query="$1" --multi --select-1 --exit-0))
 [[ -n "$files" ]] && "${editor[@]}" "${files[@]}"
}

adjusted with the use of:

eval,
become action introduced in version 0.38.0 and
the placeholder expression for all selected lines {+}

should work on zsh/bash 🍀

export EDITOR='gvim --remote'
fe() {
  fzf-tmux --query "$1" --multi --select-1 --exit-0 \
    --bind "enter:become:$(eval echo "${EDITOR:-vim}") {+}"
}

Thanks again @LangLangBart for the updated function. I'm constantly surprised at FZF's features - it's a fantastic piece of software!
Is it worth updating the wiki with your improved version?
There is an fo() function on the wiki which edits the file by default (like fe()) or opens the selection if ctrl-o is pressed.
# Modified version where you can press
#   - CTRL-O to open with `open` command,
#   - CTRL-E or Enter key to open with the $EDITOR
fo() {
  IFS=' ' read -rA editor <<< "${EDITOR:-vim}"
  IFS=$'\n' out=("$(fzf-tmux --query="$1" --exit-0 --expect=ctrl-o,ctrl-e)")
  key=$(head -1 <<< "$out")
  file=$(head -2 <<< "$out" | tail -1)
  if [ -n "$file" ]; then
    [ "$key" = ctrl-o ] && open "$file" || ${editor[@]} "$file"
  fi
}

Could this be updated using the new method?

@Praful

Is it worth updating the wiki with your improved version?

I think so, but then again I think we should find a better way to manage examples.

Could this be updated using the new method?

Yes with an additional binding like so. The new become action can replace many simple use cases of --expect.
export EDITOR='gvim --remote'
fe() {
  fzf-tmux --query "$1" --multi --select-1 --exit-0 \
    --bind "enter:become:$(eval echo "${EDITOR:-vim}") {+}" \
    --bind "ctrl-o:become:open {+}"
}


Fix VarianceChecker's relativeVariance

Fixes #21625

I struggled (after lots of time) to find a counter-example that causes it to crash, which isn't any proof, particularly as it's not my strong suit.  But then I also found some evidence - I think in method param symbol checking? - where only the upper bound is checked ever.  So that kind of encouraged to push forward.  Then ultimately by symmetry those "was: error" really stood out against the other cases.  So those are my 3 weakish reasons.

I struggled (after lots of time) to find a counter-example that causes it to crash, which isn't any proof, particularly as it's not my strong suit.

Yes, I also gave it go but couldn't come up with a counter-example either given the settup is quite involved.

But then I also found some evidence - I think in method param symbol checking? - where only the upper bound is checked ever.

I'm not familiar with that, is there a specific method you can point to?

Then ultimately by symmetry those "was: error" really stood out against the other cases.

Yes, those can indeed look surprising at first, but I still think it is correct to have an error in both LA cases but only in the first of the NL cases. Because the NL cases infer the poly-kinded lower bound Nothing which effectively removes one-half of the checks. Whereas the LA cases need to consider the type lambda for both the upper and lower bound of F, leading to an error in both F_LA_LB and F_LA_UB but from different sides of the check.
type F_LA_LB[X >: L] >: X // error: >: L
type F_LA_UB[X >: L] <: X // error: >: L

type F_NL_LB[X <: L] >: X // error: <: L
type F_NL_UB[X <: L] <: X // ok

But then I also found some evidence - I think in method param symbol checking? - where only the upper bound is checked ever.

I'm not familiar with that, is there a specific method you can point to?

I misremembered.  It's not the method parameters only have their upper bound checked, it's that method parameters are checked separately than the method result type.  But that doesn't shed much light on type constructor lower bounds.
I still think the asymmetry is wrong.
Another approach, perhaps, would be to only warn if the parameter is used, then a lower bound that doesn't use the type parameter wouldn't warn, and Nothing/Any wouldn't be different.


Add tags to blog posts

Closing this issue - the leading-edge observatory client already implements this feature.


HTML Description broken when upgrading from 5.5.1 to 5.6.3

Hi,
Recently, I've upgraded from version 5.5.1 to 5.6.3.
After the upgrade, my API description (HTML) was broken. Looks like you start to clean some styles.
Please note that the HTML is auto-generated.
Here is an example of the description field:
c.SwaggerDoc("v1", new OpenApiInfo {
                    Title = "API DOCUMENTATION",
                    Version = "v1",
                   Description = "
 Test
"+
                                 "
Get Token - Sample Request
"+
                                 "
“curl -X POST http://site.com -H 'content-type: application/x-www-form-urlencoded' -d 'grant_type=client_credentials&client_id=6779ef20e75817b79602&client_secret=mY5zM5nh7MR8gpj5yG9iIQ%3D%3D'”
"

                });

In version 5.5.1 it looks like:

From dev tools you can see all styles:

After updrage to 5.6.3 it looks like:

From dev tools looks like there are no more styles:

Please, advise.
Thanks

This looks like a question for the swagger-ui folks rather than Swashbuckle, and so I suggest you create an issue there instead. Here's the related swagger-ui versions in use by Swashbuckle:
Swashbuckle 5.5.1 => swagger-ui 3.26.0
Swashbuckle 5.6.3 => swagger-ui 3.32.5

This looks like a question for the swagger-ui folks rather than Swashbuckle, and so I suggest you create an issue there instead. Here's the related swagger-ui versions in use by Swashbuckle:
Swashbuckle 5.5.1 => swagger-ui 3.26.0
Swashbuckle 5.6.3 => swagger-ui 3.32.5

Issue opened

Issue opened

As Swashbuckle is a downstream project, I think you should frame the issue in terms of swagger-ui rather than Swashbuckle - IMO that will increase the likelihood of it being addressed.
For example provide the generated Swagger JSON and screenshots of the UI instead of SB specific configuration etc

As Swashbuckle is a downstream project, I think you should frame the issue in terms of swagger-ui rather than Swashbuckle - IMO that will increase the likelihood of it being addressed.
For example provide the generated Swagger JSON and screenshots of the UI instead of SB specific configuration etc


(WIP) Meta implementation

For discussion before this goes any further
Currently the obvious 15 tests fail.
This implements all the internal methods that rely on the arity of a function through metadata. It also tracks the source function and name of a function.
An obvious extension of this is to do native unwrapping (for example doing currying and partial and other decorators in a single method as lodash does [big benefit!])
The main motivation of this is (for me) is a) a big perf benefit by avoiding arity and b) enables us to later implement restParams which will be a substantial improvement in several places in the code base (it didn't make sense to implement this through arity). Overall this enables a couple follow up optimizations
Points of interest:

Should it be added to an object publicly   or use a symbol
What should be included
Should repl stuff be added

Benchmarks to follow (in case its not obvious the benefit): http://jsperf.com/ramda-currying-cost/4

There have been several things lately that made us talk about including metadata, although off-hand I can't recall what they were.  I don't have any strong objection to it.
But I'm bothered by this change.  We discussed a while ago (#140) some of the rationale for properly reporting the arity of our functions.  To my mind, nothing has changed.  It's a matter of being good citizens.  We don't know how consumers of Ramda functions or of functions generated via Ramda functions will then use them.  If we break the contract the user has with some other tool that needs to know the arity of functions passed to it, it's entirely our fault, not the user's, and not that of the other tool.  I'd rather not be in that circumstance.
While we're not turning Javascript into Haskell, Ramda does seem to be pushing for a somewhat stronger typing of functions than is typical in Javascript.  I believe that this helps people work with Javascript as a functional language.  And properly reporting arity is part of how we we do this.

I looked over the jsperf, and it seems to me to prove a few things:

standard lodash is quite a bit faster than Ramda for this case
lodash-fp is suprisingly slower than standard lodash
there seems to be little difference between Ramda and Ramda meta

I didn't understand what you meant about including "repl stuff".

I looked over the jsperf, and it seems to me to prove a few things:

standard lodash is quite a bit faster than Ramda for this case
lodash-fp is suprisingly slower than standard lodash
there seems to be little difference between Ramda and Ramda meta

This is the first step of closing that gap as I mention in the issue comments; this will enable various new optimization strategies

i think we may have to pay the price of arity. but i still want to pursue this line and see where it leads.

Very few libraries rely on function.length that don't allow the user to
override the property (e.g. curryN). Thinking about it the metadata
properties should be exposed publicly.
Based on a quick & dirty grep closing this door will make it hard to
improve the performance on the following functions any further without a
ton of boiler plate (methods that would benefit heavily from restParams)

curry and curryN
partial*
converge
flip
func
All invoker results
lift
useWith
Any function using checkForMethod

On Thu, Mar 12, 2015 at 8:29 AM, Michael Hurley<EMAIL_ADDRESS>wrote:

i think we may have to pay the price of arity. but i still want to pursue
this line and see where it leads.
—
Reply to this email directly or view it on GitHub
https://github.com/ramda/ramda/pull/907#issuecomment-78470705.

Very few libraries rely on function.length that don't allow the user to override the property (e.g. curryN).

But the point is not what other current libraries do or don't do.  It's a matter of what we do.  If another library altered a user's functions in such a way, she could not comfortably pass them to Ramda without having to manually choose their arities.  That would burden her code.  That's why I wouldn't want Ramda to do it to her for her interoperation with another library.
Sure, I'd love to improve our performance.  But that will always be secondary to me to having an API I prefer.

it seems as though function.length is getting less and less respect. rest params do not play well with function.length. Are we going to ignore them, or come to some accommodation?

We can also add a function that returns a function that corresponds to
metadata.arity. Maybe rename arity arityN?
On Fri, Mar 13, 2015 at 11:17 AM, Michael Hurley<EMAIL_ADDRESS>wrote:

it seems as though function.length is getting less and less respect. rest
params do not play well with function.length. Are we going to ignore
them, or come to some accommodation?
—
Reply to this email directly or view it on GitHub
https://github.com/ramda/ramda/pull/907#issuecomment-79036404.

Are we going to ignore [rest params], or come to some accommodation?

As far as I can tell, although they are very useful, they are useful for creating variadic functions.  And Ramda will probably never play particularly nicely with variadic functions.  At the very least, we might well auto-curry them to the wrong lengths.
I don't think there's any good way around this.  With good reason, Ramda gently pushes toward slightly more strongly-typed functions than are the norm in JS.  It is more opinionated in this than some of the bigger libraries, because its goals are different.  It's not meant to be a multi-paradigm toolkit that will work with whatever style you want.  It's meant to support a very specific style of coding.  It's hard to see where most variadic functions would fit with that style.

We can also add a function that returns a function that corresponds to metadata.arity. Maybe rename arity arityN?

That sounds like locking the barn after the horse has escaped.  The problem is how Ramda is being a good citizen, not how it would offer ways for a user to clean up after it.
There's something bothering me about the approach here, and it encompasses all of the metadata ideas, even though I've had at least somewhat positive feelings about them.  The problem is that at the moment we deal with all functions on the same basis: whether they are native functions, Host object functions, user functions, third-party library functions, Ramda functions, or functions created by calls to Ramda functions, they get treated the same.  If we start tagging functions with metadata, and dealing with them on that basis, we make everything but the Ramda, and Ramda-created functions in some way second-class citizens.  Maybe that won't ever have a deleterious effect, but it makes me worry.

@megawac -- ok to close this?

up to you guys - still valuable iin my opinion if you were asking
On Mon, May 11, 2015 at 7:55 PM, Michael Hurley<EMAIL_ADDRESS>wrote:

@megawac https://github.com/megawac -- ok to close this?
—
Reply to this email directly or view it on GitHub
https://github.com/ramda/ramda/pull/907#issuecomment-101077017.

i think it's worth exploring, subject to @CrossEye 's constraints. not sure how difficult that makes it to thread the needle

@megawac: Yours have been some of the most valuable contributions to the library.  Of course we're asking!  Of course I disagree with many of your suggestions.  But I disagree with many of those from @buzzdecafe and @davidchambers, too.  Hashing these things out and coming up with useful compromises is what makes for a good codebase.

first question: can we use function metadata to "multi-dispatch" e.g.: At present we can only dispatch to a function with the same name: R.chain(f, Maybe.Just(1)) works because Just has a chain method. But what if we want to dispatch from chain to an object with a flatMap method? A lookup in the metadata might be a good way to go?

i think we should revive this. I've been playing with this idea and like it. I propose we work around the arity thing by providing a public function to set correct function.length, but internally we use something like this. then we can also set other meta-properties e.g. to support debugging.
@megawac lmk if you want to/have time to pick this up, or if you want to pass it off.

I propose we work around the arity thing by providing a public function
to set correct function.length, but internally we use something like this.

Great! I think lodash is planning to do the same ()
Want to move this to a ramda branch to allow more contributors? I'm pretty
busy for the next couple days but can spend some more time on it next week
On Fri, Jun 5, 2015 at 4:40 PM, Michael Hurley<EMAIL_ADDRESS>wrote:

i think we should revive this. I've been playing with this idea and like
it. I propose we work around the arity thing by providing a public function
to set correct function.length, but internally we use something like this.
then we can also set other meta-properties e.g. to support debugging.
@megawac https://github.com/megawac lmk if you want to/have time to
pick this up, or if you want to pass it off.
—
Reply to this email directly or view it on GitHub
https://github.com/ramda/ramda/pull/907#issuecomment-109433317.

created meta branch

((:bell:))

Excuse me but can anybody explain what this meta stuff actually does? I'm not learning much by looking at the code in this PR and I have not found explanations elsewhere.
We store some data about our functions and somehow use it? How is that different from today where the arity of our functions is implicit information based on which curry function is called? Am I correct that these ideas are inspired from Lodash?

@paldepind: I'm not sure that these ideas were exactly inspired by lodash, but @megawac, who, though not as active now, was in the past one of our most prolific contributors, and helped us figure out a number of thorny issues, including some serious performance ones.  He has long-suggested this approach to us.  @megawac is a committer on Underscore, I believe, and has also been active in lodash.  Lodash has definitely adopted this approach.  I don't think Underscore has; it would make their source code significantly more complicated, something I know that @jashkenas is loathe to do.
The basic idea is that instead of wrapping and returning new functions, we could often decorate existing functions with a ramdaProperties (or some such) object that details information about such things as whether the function is curried, what parameters have been partially applied with which values,  Instead of wrapping functions in our arity-controlling wrappers, we could just keep an arity property in this expando.  Then when we run, we could interpret this metadata, thereby skipping many of the nested calls to which Ramda is prone.
There are many reasons that this might be worth considering.  Such notions as debug-only settings or declarative type-checking might be significantly easier to do if each one was simply an application of some meta-data to be interpreted later.
Of course this means that the actual application of our functions would be significantly more complex.  But there is a very good chance that we would gain significant performance.  This is most telling when you run performance comparisons between Ramda and lodash:  for many (most?) of our functions, Ramda runs just as fast as lodash, often faster, in Chrome.  But in Firefox, where there is a much greater cost to function invocations, Ramda can be substantially slower.  I expect a great deal of this has to do with the number of fewer function calls needed, partly because of this metadata.
To my mind, performance will only drive our decisions when there are egregious problems.  We are building a library designed to support a certain style of work.  It's all about the API.  Some time after 1.0, we might want to take this on, but it's not a driving factor.  So that's not enough of a reason for me to consider this.  But some of the other reasons sound like good ones.
However, it scares me a fair bit, too.  Most of our functions are simple, both in conception and in implementation.  Creating a function runner that works universally for every conceivable combination of curries, placeholders, dispatch configurations, debug settings, and type validators, strikes me as a nasty, bug-prone operation that might not be easily decomposeable into smaller ones.  Obviously we can takes some inspiration from the lodash version, but their internal style is so different from our own that it might not offer us much help, and it would probably offer none for our carrying this notion to things like dispatching and type validation.  I'm also worried but what I suggested earlier, that this might somehow privilege Ramda functions over user ones.  But that might be something we end up not having to worry about; it's a problem I can imagine creating, depending on how this is implemented.
In any case, that's a description.  And as seems to be happening lately, there's two sides to this, and I seem to be squarely on both of them!  :frowning:

i agree this may cut both ways. but i would much rather explore interesting approaches and understand their implications rather than foreclose them.

Absolutely.   I want to see where this might go.   I want to see what might happen with your compose changes.   I want to see if we can return curried functions everywhere, at least by default.
Metadata interests me less than some of the others, because in the end its mostly about implementation.   And while I recognize how important a good implementation is, I much more interested at first in the API that's being built.

Thank you for the write up @CrossEye. I still don't fully get it I'm afraid :(
My best guess right now is that this means we should have mega-functions that can cover a bunch of different cases by taking a small specification of what they should do.
But, how for instance would this allow us to avoid the arity function? Every time a user partially applies a function he needs to get a new function back with the correct arity? How can one avoid that?

i think what the _meta proposal is driving at is instead of decorating the function we care about with more and more wrapper functions, we assign decorations to a property on the function object.

@buzzdecafe Then why not just create on single wrapper function that can do all the wrapping? Like:
var someFunction = doEverythingWrapper({
  dispatchesOn: 'someProperty',
  arity: 3,
  // Lots of stuff
}, function() {
  /* actual function */
});

Definitely possible but it'd probably be hard for others to understand (see
lodash baseWrapper) and difficult to tune for jit optimizations. The
advantage being less loc
On Jun 13, 2015 8:21 AM, "Simon Friis Vindum"<EMAIL_ADDRESS>wrote:

@buzzdecafe https://github.com/buzzdecafe Then why not just create on
single wrapper function that can do all the wrapping? Like:
var someFunction = doEverythingWrapper({
dispatchesOn: 'someProperty',
arity: 3,
// Lots of stuff
}, function() {
/* actual function */
});
—
Reply to this email directly or view it on GitHub
https://github.com/ramda/ramda/pull/907#issuecomment-111705980.

@megawac How is it different from attaching the data directly to the function? In both cases the meta handling function will receive the function and the meta data?

https://github.com/ramda/ramda/commit/976c7cf15c91713a6db0d8cafa822c2dfa4fbd44

@simon the result is roughly equivalent (jack of all wrappers vs current
focussed wrappers) but I feel like this way is more explicit, at least for
now. I would prefer to now store this on an expando but it wouldn't be
feasible for legacy environments (requires weakmap as in lodashs
implementation)
On Jun 13, 2015 9:29 AM, "Michael Hurley"<EMAIL_ADDRESS>wrote:

Closed #907 https://github.com/ramda/ramda/pull/907.
—
Reply to this email directly or view it on GitHub
https://github.com/ramda/ramda/pull/907#event-330193236.

@megawac Ok. The other way seems more intuitive to me. But there are probably things I'm not seeing. In any case I think the do everything wrapper

I'm not a fan of adding enumerable properties for meta data. This means in some environments it'll show up for all kinds of methods that iterate over the function. The nice thing about lodash's approach is it has no side effects on the function. In fact, you can remove it (there's builds with it removed) and things still just work.

That won't work for ramdas case where tracking some metadata is paramount
(such as arity)
On Jun 13, 2015 10:25 AM, "John-David Dalton"<EMAIL_ADDRESS>wrote:

I'm not a fan of adding enumerable properties for meta data. This means in
some environments it'll show up for all kinds of methods that iterate over
the function. The nice thing about lodash's approach is it has no side
effects on the function. In fact, you can remove it (there's builds with it
removed) and things still just work.
—
Reply to this email directly or view it on GitHub
https://github.com/ramda/ramda/pull/907#issuecomment-111713267.

Ramda has introduced a fair amount of inconsistency with dispatching so I guess this just adds to it then.

concern troll much?


Name gRPC client consistently

Purpose
Name gRPC client consistently as I find it confusing that it's known under both ConcordiumGRPCClient and ConcordiumNodeClient. The readmes use the latter name, but it's exported under the former.
Changes
Rename ConcordiumNodeClient to ConcordiumGRPCClient as that's the name under which it's exported. It looks to me like ConcordiumNodeClient is used only internally within common-sdk.
Also changed the export from default to named by the class.
If it cannot be renamed for some reason that I missed, I still think the README should be updated to reflect the exported name.
Checklist

[ ] My code follows the style of this project.
[ ] The code compiles without warnings.
[ ] I have performed a self-review of the changes.
[ ] I have documented my code, in particular the intent of the
hard-to-understand areas.
[ ] (If necessary) I have updated the CHANGELOG.

Looks good to me, but the CHANGELOG has to be updated to reflect the changes made.

Looks good to me, but the CHANGELOG has to be updated to reflect the changes made.

Are you sure? I believe the changes are all internal (except for the documentation changes which I consider fixes but not related to a particular version). I think changelog is for externally visible changes.

Looks good to me, but the CHANGELOG has to be updated to reflect the changes made.

Are you sure? I believe the changes are all internal (except for the documentation changes which I consider fixes but not related to a particular version). I think changelog is for externally visible changes.

ping @orhoj

Looks good to me, but the CHANGELOG has to be updated to reflect the changes made.

Are you sure? I believe the changes are all internal (except for the documentation changes which I consider fixes but not related to a particular version). I think changelog is for externally visible changes.

@concordium/common-sdk is a published library (albeit not directly used by end users), but the breaking changes should still be documented in the CHANGELOG.
Theres a release branch collecting the next round of breaking changes (PR #206), which you could set as the base branch for this PR.

Looks good to me, but the CHANGELOG has to be updated to reflect the changes made.

Are you sure? I believe the changes are all internal (except for the documentation changes which I consider fixes but not related to a particular version). I think changelog is for externally visible changes.

@concordium/common-sdk is a published library (albeit not directly used by end users), but the breaking changes should still be documented in the CHANGELOG.
Theres a release branch collecting the next round of breaking changes (PR #206), which you could set as the base branch for this PR.

But my point is that the changes are not breaking because the exported name is unchanged. Or am I missing something?

But my point is that the changes are not breaking because the exported name is unchanged. They're not externally visible at all. Or am I missing something?

It is public: https://www.npmjs.com/package/@concordium/common-sdk

I see what you mean, but you can theoretically still import the class from the actual file lib/GRPCClient instead of from the index file, in which case it would be breaking? Maybe it doesn't matter when it is not the export from index, I honestly have no idea.
Anyhow, if we include this in the next major release it won't matter anyway?

I suppose that would break (I expected the whole lib to be compiled down to a single file). I think whether or not it's a breaking change then boils down to whether or not this is a supported use case? Don't we want users to import everything from @concordium/common-sdk?
I can fix the merge conflicts (it's just a string search/replace) and also add the changelog entry if you think it's relevant (I still don't think it is)?

I suppose that would break (I expected the whole lib to be compiled down to a single file). I think whether or not it's a breaking change then boils down to whether or not this is a supported use case? Don't we want users to import everything from @concordium/common-sdk?
I can fix the merge conflicts (it's just a string search/replace) and also add the changelog entry if you think it's relevant (I still don't think it is)?

Yeah, let's just skip the changelog as the top level stays the same.. I think that's fair.

@soerenbf Rebased and included a few more replacements (see https://github.com/Concordium/concordium-node-sdk-js/pull/191/commits/83534b1f41cfa1723ded82777772e7cb588df80a).
I'm assuming that the remaining occurrences of ConcordiumNode (in packages/nodejs/src/client.ts, packages/nodejs/src/index.ts, and pages/misc-pages/grpc-v1.md) are for V1 and shouldn't be replaced?


Make calls to eth_sendRawTransaction (more) idempotent

We see as issue mentionned here, see especially this comment:
Duplicated messages are rare, and as such not well managed. Besu and geth are not idempotent and returns an error. dapps (MM included) do not distinguish this case from any error and consider the tx failed.
There could be multiple causes for the duplicated requests, for example:

With keepalive connections, it is possible that server will close
the connection and the client will start sending a request a the
same time. This case is specifically outlined in RFC 2616,
https://tools.ietf.org/html/rfc2616#section-8.1.4

Proposal; make Besu idempotent in this case, so the duplication is invisible for dapps.

We will research this and see if there is room in the rpc spec to return something other than an error in the case of an already-in-mempool transaction by txhash

Manually marking as stale, please update if this is still required.


Execute mvn clean to reduce image size

After https://github.com/fabric8io-images/s2i/blob/master/karaf/s2i/assemble#L127 a mvn clean should also be executed to remove build artifacts. This should result in an even smaller image size.

A possible option would be to add a clean add the end

@jcordes73 would you agree that if we did #76 then this could be closed?


Index testing changes from 3/14

May need to change the motor control in the Index/Intake default commands depending on the sensor placement and intake (index?) top roller redesign

Having two commands running IndexSubsystem simultaneously seems a bit off to me. I get that it works because we're modifying different parts of index and not adding requirements for one of the commands, but it's not ideal and signals to me that intake + index might need to be reorganized in the future (not before Sammamish though).

I agree, going forward it may be best to merge the two subsystems as one since most of the commands that we are using are calling both of the subsystems. This is something we can address after the comp this weekend though


Build command should automatically save open files

Had this idea during trying to make different screens. Any ideas if it could cause some problems?

When a new screen is created, all files are updated within the .brilliant/device-files.json directory. However, attempting to save all currently open files may result in unintended saving of other files (even after filtering out Python files) that are not meant for the device.

Done


changed the way x_try is sent to minimize - fixes #350

LGTM (verified that this fixes the issue and is backwards compatible).

Any forecast when this will be included on pypi?

Hey @Rizhiy, see #339 and https://github.com/pypa/pypi-support/issues/2144
In the meantime you can do pip install git+https://github.com/fmfn/BayesianOptimization to install directly from source.


[feature] support user to define the success status codes of HTTP protocal

Description
As mentioned in https://github.com/dromara/hertzbeat/issues/978, now that we have added the enhancement to the backend of HTTP collect, why don't we provide a place that user can input what they think are success status codes.
This maybe only need some changes on frontend codes.
Task List
No response

custom define success status code can be add int api monitor  type
not need to change frontend code. We can update frontend input ui by Monitoring Template Yml https://raw.githubusercontent.com/dromara/hertzbeat/master/manager/src/main/resources/define/app-api.yml

custom define success status code can be add int api monitor  type
not need to change frontend code. We can update frontend input ui by Monitoring Template Yml https://raw.githubusercontent.com/dromara/hertzbeat/master/manager/src/main/resources/define/app-api.yml


API documentation is missing some text found in source files

The API documentation is apparently missing some subheadings.
Compare, for example, this source .md file
https://github.com/mmomtchev/rlayers/blob/main/src/style/RStyle.md
with the generated output
https://mmomtchev.github.io/rlayers/api/#styles
You can see that all the subheadings are missing from the API documentation, making it very hard to interpret.

As you may have seen from my profile, I am currently unemployed and living on social welfare because of an extortion on a galactic scale, involving the French and EU justice system, the French police, the French bar association, and a number of large IT companies such as Google, Facebook, Twitter and Microsoft. In order to intimidate me, people are posting simultaneously on my projects. Yours is one of these comments.

I am sorry, I wasn't aware of your personal life. I'm merely a fellow developer that enjoy using your library and found a place for improvement and thought I'd let you know. No harm meant, and certainly not here to intimidate you, nor have I been posting simultaneously on any of your other projects. Don't know where you got that from...
I'm sorry to hear about your dilemma and wish you all the best.

I wonder why this guy thinks that the room that he is getting sent into is a psychiatric ward? Maybe we can all try to show him that this is his new office?


only warn for isolation mismatch in @preconcurrency context

Much like how we do for an isolation mismatch for a call within
a closure that is @preconcurrency, references should also only
warn about the isolation issue too.
The reason why there is a mismatch is that the completion-handlers
are considered @Sendable, which disables the isolation inheriting
behavior of other, non-Sendable closures.
resolves rdar://97184231

@swift-ci please test


html message content not encoding

I'm trying to send html code to the dialog but it doesn't seem to work.
let options = {
	html: true,
	loader: false,
	reverse: true,
	okText: 'Submit',
	cancelText: 'Cancel',
	animation: 'zoom',
	backdropClose: true
};
this.$dialog.confirm('a test').then(function () {
	console.log('Clicked on proceed')
})

The result I get in the dialog is:
a test

Ignore me, my mistake the options weren't being parsed!

Alright @arkid


[WFCORE-1077] Update the regular expression to correctly split out the username and password.

Windows Build 2651 outcome was FAILURE using a merge of 9cc3fabec8a730c8a3e86b106a7e8e026c9a1b2e
Summary: Cannot start build runner Build time: 00:17:15

Core - Full Integration Build 2255 outcome was FAILURE using a merge of 9cc3fabec8a730c8a3e86b106a7e8e026c9a1b2e
Summary: Execution timeout (new); tests passed: 3249, ignored: 363 Build time: 01:16:04

Retest this please

retest this please

Full integration - Windows Build 700 outcome was FAILURE using a merge of 9cc3fabec8a730c8a3e86b106a7e8e026c9a1b2e
Summary: Cannot start build runner Build time: 00:00:17

This could use a unit test that shows that a matcher using this pattern produces the expected results.


[OP]  Add apply lambda op to use with UDFs

Is your feature request related to a problem? Please describe.
df.apply and df.apply(lambda: x.. ) are two methods commonly used to apply UDFs in W&D model preprocessing and feature engineering.
Describe the solution you'd like
We should be able to create UDFs and use with df.apply or df.apply(lambda: x...)
Additional context
cudf does not have apply or apply lambda functionality yet. There is applymap method that applies an elementwise function to transform the values in the Column.
Pandas example:
pdf = pd.DataFrame({'display_id':['1', '2','3', '4'], 'clicks':[0, 1, 1, 0], 'views':[1, 5,10, 3]})
pdf.loc[:, 'ctr'] = pdf.apply(ctr_udf, axis=1)
pdf.head()

     display_id  clicks  views  ctr
0	1	0	1	0.0
1	2	1	5	0.2
2	3	1	10	0.1
3	4	0	3	0.0

I don't think we should be letting people apply python functions at the row level. Can we restrict this to operations happening at the dataframe or series level instead? If we are calling a python function per row we won't be able to have acceptable performance (which is why there isn't an 'apply' function in cudf right now).
For your example of calculating CTR, we could add something where the calculation per GDF chunk looks like:
gdf['ctr'] = gdf['views'] / gdf['displays']

instead of using an apply function. The idea here is that we are declaring the work that needs done in python, but the actual work is done on the gpu using cudf.   (also take a look https://github.com/NVIDIA/NVTabular/pull/84#discussion_r438953563 for how to express a similar idea as a NVT operator).

In https://github.com/NVIDIA/NVTabular/pull/84 , I created the lambda function on DataFrame Level, which would support this op, as well

@bschifferer lambda should be used with applymap right?

No, I think you can apply it like:
f = lambda gdf: gdf['clicks']/gdf['views']
gdf['ctr'] = f(gdf)

I got the point of performance, but I believe not allowing the user to define custom apply functions might be very limiting for feature engineering.
A Data Scientist could play with both cuDF (for speed) and Pandas (for flexibility) in the same pipeline, if data fits in memory. But I don't know if he would be able to use NVTabular for performance and then use Pandas for unsupported custom apply functions.
In that case, could we have something like tf.py_function to define custom functions?
https://www.tensorflow.org/api_docs/python/tf/py_function


NIFI-3636: Lazily copy FlowFile Attributes Hash Map instead of doing …

…so eagerly.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Reviewing...

For the GC stuff, we should have some unit tests if possible, to verify the Map reference is retained until modification

0001-NIFI-3649-Buffer-node-responses-when-replicating-HTT.patch snuck in there

Sorry about that. Fixed & pushed.

+1 LGTM, built and ran unit tests and contrib-check. Tested with 3-node secure NiFi cluster using sample flows (including site-to-site), all looks good. Thanks! Merging to master.


Update to allow Symfony 7 and test on PHP 8.3

Hi
I've updated the composer.json to allow Symfony ^7.0 and change the CI layout to test it against SF 7 but also 8.3 which release few days ago.
Do you want to keep supporting SF 5.4 (which ended its bug fixes period and entered security fix only https://symfony.com/releases/5.4) ? I can update this PR accordingly
I can also update to only allow 6.4 version instead of all 6.* if needed.

Hi! Thanks for the contribution :heart:
Yes I would like to keep Symfony 5.4 as it's the LTS version right now.
Looks like we have a dependency issue with Jane:
   Problem 1
    - Root composer.json requires jane-php/json-schema ^7.4 -> satisfiable by jane-php/json-schema[v7.4.0, ..., v7.5.5].
    - jane-php/json-schema[v7.4.0, ..., v7.5.5] require symfony/console ^4.4 || ^5.0 || ^6.0 -> found symfony/console[v4.4.0, ..., v4.4.49, v5.0.0, ..., v5.4.32, v6.0.0, ..., v6.4.1] but these were not loaded, likely because it conflicts with another require.
  Problem 2
    - jane-php/json-schema-runtime[v7.4.0, ..., v7.5.5] require symfony/serializer ^4.4 || ^5.0 || ^6.0 -> found symfony/serializer[v4.4.0, ..., v4.4.47, v5.0.0, ..., v5.4.33, v6.0.0, ..., v6.4.1] but these were not loaded, likely because it conflicts with another require.
    - Root composer.json requires jane-php/json-schema-runtime ^7.4 -> satisfiable by jane-php/json-schema-runtime[v7.4.0, ..., v7.5.5].

Good catch :+1:
Will need this PR to be reviewed, merged and released then https://github.com/janephp/janephp/pull/774
I let the PR as is with SF 5.4 :)

any news here?
https://github.com/janephp/janephp/pull/774 has been merged!

It has been close in favor or https://github.com/janephp/janephp/pull/768 ; which is still open :crossed_fingers:

I'm currently looking at this PR as JanePHP is now compatible with SF7.

Thanks a lot for your contribution! A release will be done today :+1:


Fix #8798: $refs TypeScript type definition

Fixes #8798
When you refer to $refs, the type if always something truthy, while it is possible that the value is undefined.
Without this change, one can refer to a ref that is undefined, but TypeScript thinks it is Element or Vue.
This PR added undefined type to the type of $refs. This way it is more type-safe when using $refs.
What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[x] Yes
[ ] No

If yes, please describe the impact and migration path for existing applications:
This change will break code written in TypeScript which does not null-check the value of this.$refs.foo.
The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:
- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
Other information:

The test is failing, but the failed test seems to be unrelated to my change.

Hi @Hoishin, I don't think this is a safe change. It won't make any change when users don't turn on strictNullChecks. And if users do turn on it, it only forces them to cast non-null.
If you do want to ensure type safety when using refs, you probably should use class style component and refine $refs typing there. Example: https://github.com/vuejs/vue-class-component/blob/master/example/App.vue#L58-L60

I already use class style component, but didn't know that usage. It's awesome to know.
For the the first half of the comment, IMO, by having them to cast to non-null, they make sure it's actually non-null, so it doesn't deny the benefit of this change.
Anyways I do understand that it doesn't pay off for the cost, especially when the next major version will have big changes regarding TS.
Hopefully the TypeScript refactoring for 3.0 will bring much better TypeScript experience.


Parametrize Controller-Manager to pick Resources/Limits from values.yaml

What steps did you take and what happened:
We enabled image-cleaner on AKS cluster
The eraser-controller-manager pod goes quickly CrashLoopBackOff
State:          Waiting
Reason:       CrashLoopBackOff
Last State:     Terminated
Reason:       OOMKilled
This is leading to bunch of eraser-aks pods in completed state not being cleaned up as controller isn't working.
What did you expect to happen:
the pod being stable with given limits
Anything else you would like to add:
I tried manually increasing memory limits and it works fine. It easily consumes more than 50Mi
Just like all other containers (scanner, remover etc) take parameterized resource requests/limits from values.yaml file, please make sure manager pod also has this capability.
We're blocked as we cannot use this helm chart without increasing memory.
Environment:

Eraser version: 1.2.1
Kubernetes version: (use kubectl version): 1.25.6

Hey @ayushiaks - I've got some follow up questions here
I'm a little confused as to how you're using Eraser. You say you enabled the Image Cleaner addon on an AKS cluster, but if that were the case, you wouldn't be using a Helm chart at all.
If you are in fact using the Helm chart and not the addon, the values can be configured with the .Values.deploy.resources value.

Thanks for pointing out, I was looking at the wrong yaml -> config/manager/manager.yaml
Closing the issue


Don't add git dep in gemspec

Description
Introducing git as a dependency in the <gem-name>.gemspec file introduces a problem for those of us isolating our applications within Docker containers that don't otherwise need git.

Sure, I totally agree with you. Thanks 👍


All other notifications disappears if i click on one

Hi,
Describe the bug
if I have 5 notifications (5 new mails) on my phone. If I open one of them all other notifications disappears.
I want only the one clicked to disappear.
To Reproduce
easy
Expected behavior
Just close the notification that i click on
Environment (please complete the following information):

K-9 Mail version: 5.600
Android version: 11
Device: samsung s20+
Account type: IMAP

This should be fixed in K-9 Mail 5.909.