Guest Additions version mismatch could be due to a logical issue in getting guest version

The latest version of vagrant-vbguest, at the time of writing this, is 1.11.0.
Looking at the master branch it seems we rely on the installer's guest_version method to determine the active version as reported by the Guest. I am using Ubuntu guest, so the Ubuntu installer delegates the responsibility to the Linux installer from which it inherits.
The logical issue is with the method that loads the guest version guest_version. See: https://github.com/dotless-de/vagrant-vbguest/blob/master/lib/vagrant-vbguest/installers/linux.rb#L80
This method is calling super to load the driver determined guest version. But as a side effect it is also assigning the @guest_version instance variable. Note, the super method is delegating to the Base installer. The base installer reads the value from the driver and is in the format ''5.0.18 r106667'. This is then assigned to the @guest_version.
The logical issue with the guest_version method is we read the driver_version by altering the response of super; super.to_s[/^(\d+\.\d+.\d+)/, 1]. So the value assigned to driver_version is '5.0.18'.
When we go to determine the version reported by VBoxService, we also do the same altering of the response; data.to_s[/^(\d+\.\d+.\d+)/, 1]. So the check for the driver_version being different than fails since the versions are the same. When they are different we invoke a warning of their difference.  This is expected behavior.
The problem is we rely on the driver version and VBoxService reported versions to be different to set the @guest_version. This assignment should be independent of version mismatch as it is still the guest version that we have calculated.
The method then completes and returns @guest_version'; which is still set to '5.0.18 r106667'.
I believe that the assignment of the @guest_version = v should be done outside and after the comparison of the versions.
So the fix might be to move the assignment outside below the if statement.
If I have made any assumptions that aren't correct please provide details. Thanks.

Please see my pull request: #214
Its a little more thorough than my description above.

PR merged.

For those who are also affected by this issue, I wrote a quick script to help me sync the version if they change after I upgrade:
https://gist.github.com/NeMO84/95e93346e81dbb2b75dd677922addbda
Hope it helps.


feat: more infrastructure for tactic documentation

This is the groundwork for a tactic index in generated documentation, as there was in Lean 3. There are a few challenges to getting this to work well in Lean 4:

There's no natural notion of tactic identity - a tactic may be specified by multiple syntax rules (e.g. the pattern-matching version of intro is specified apart from the default version, but both are the same from a user perspective)
There's no natural notion of tactic name - here, we take the pragmatic choice of using the first keyword atom in the tactic's syntax specification, but this may need to be overridable someday.
Tactics are extensible, but we don't want to allow arbitrary imports to clobber existing tactic docstrings, which could become unpredictable in practice.

For tactic identity, this PR introduces the notion of a tactic alias, which is a syntax specification that is really "the same as" an existing tactic, but needs to be separate for technical reasons. This provides a notion of tactic identity, which we can use as the basis of a tactic index in generated documentation. Tactic aliases are specified using a new @[tactic_alias IDENT] attribute, applied to the new tactic syntax. It is an error to declare a tactic syntax rule to be an alias of another one that is itself an alias. Documentation hovers now take aliases into account, and display the docs for the canonical name.
Tactic tags, created with the register_tactic_tag command, specify tags that may be applied to tactics. This is intended to be used by doc-gen and Verso. Tags may be applied using the @[tactic_tag TAG1 TAG2 ...] attribute on a canonical tactic parser, which may be used in any module to facilitate downstream projects introducing tags that apply to pre-existing tactics. Tags may not be removed, but it's fine to redundantly add them. The collection of tags, and the tactics to which they're applied, can be seen using the #print tactic tags command.
Extension documentation provides a structured way to document extensions to tactics. The resulting documentation is gathered into a bulleted list at the bottom of the tactic's docstring. Extensions are added using the tactic_extension TAC command. This can be used when adding new interpretations of a tactic via macro_rules, when extending some table or search index used by the tactic, or in any other way. It is a command to facilitate its flexible use with various extension mechanisms.

@robertylewis I think this should meet your needs now - please give it a whirl at let me know! I don't want to merge before you've had a chance to validate that it supports the workflow that you're looking for.

Also as written on Zulip: I think we should use this only for tactics for now, and avoid overdesigning too early. A tactic index is more important than an attribute index. Then we can see whether this should be generalized to a mechanism that works for all those (and is further user-extensible) or whether we should just create the ones we need - I'd like to work through a few examples of each category to see how much they overlap in practice.

One further question: the term "alias" seems a bit poorly chosen. Perhaps "alternate" would make more sense?

Or "alternative"?

I like that, but I'll use alt to make the attribute name a bit shorter (@[tactic_alt theRealTactic]).

!bench

!bench

@Kha - what do you think? Is that performance hit too severe?


new peak shape for MJD

Implement gaussian+low-E side tail for MJD partitions.
Idea: add a key in the partition.json (under fit_group?) for specifying the peak shape to use for partitions listed in that file, eg "signal_shape": "gaussian" or "signal_shape": "gaussian_plus_lowEtail".
In this way, we can handle differently different experiments
@tdixon97 any opinion?

Yes of course that works, although it becomes a bit 'hardcoded' but idk a better way to do this..

the only not-hardcoded way would be via the config.json, but I think there you lose some freedom... There you could specify something like:
        "events": [
            "legend-0vbb-config/events_gerda.json",
            "legend-0vbb-config/events_l200.json",
            "legend-0vbb-config/events_mjd.json",
        ],
        "partitions": [
            "legend-0vbb-config/partitions_gerda.json",
            "legend-0vbb-config/partitions_l200.json",
            "legend-0vbb-config/partitions_mjd.json"
        ],
        "signal_shape": [
            "gaussian",
            "gaussian",
            "gaussian_plus_lowEtail"
        ],

Anyway, we can set the gaussian as the default shape and let the user specify only when the other shape has to be used

yeah i meant that ideally one could input directly a formula, but its very hard to implement, i think it belongs in the partitions file not the config file?

so i agree with your original suggestion, its just a pity that you have to rely on names for shapes, but idk a way around it (similar for the background shapes).

the new peak shape works after https://github.com/sofia-calgaro/ZeroNuFit.jl/commit/3d46a628329bc30a52990b67930e760e57425866 and was tested

succesfully for MJD only
succesfully for L200 only (where we don't add any gamma/frac/tau parameter and don't specify signal_shape
succesfully for the combination MJD+L200

However, in a combined fit, the fit does not work if we change the order, eg if we fit L200+MJD (this is related to the number of partitions for which we want to include the prior gamma ... this has to be handled better...)

Missing features:

add data+model plot with modified peak shape for given partitions


Use more extensible JSON signature as the Basic Authentication header token

Hi, this is a really nice functional extension to IPFS gateway. Yet, it would be great if we could make it easily extensible to support more blockchain signatures like ethereum, solana, etc.
So, here is one proposal: instead of using Basic Authentication header token in format of

Authorization: Basic <base64(PubKey:SignedMsg)>

How about using base64 JSON signature like:

Authorization: Basic <base64({"chain":xx, "address":xx, "msg":xx, "sig":xx, "timestamp":xx})>

For example, "chain" value "ethereum / polkadot / crust" indicates an ethereum / polkadot / crust signature respectively.

A bit more explanation why "_ timestamp_" is needed.  This is try to fix the REPLAY security issue.
Since any party could follow our guideline to host an IPFS W3Auth Gateway and contribute to Polkadot or Crust Apps. A malicious IPFS W3Auth Gateway operator could eavesdrop user's Basic Authentication header token, and use that to REPLAY user's IPFS requests, forever.
Including a "timestamp" gives the header token a TTL (Time-To-Live), like 5 minutes. The IPFS W3Auth Gateway could simply fail an expired signature tokens. This is an imperfect but lightweight solution that makes our gateway much more securer. We could give it a thought.

We're like changing to format CHAIN.PUBKEY:SIG compatible with most of http basic auth call.

I didn't see much activity here. Replay is a serious concern by @gavfu and timestamps as part of the signature payload could mitigate it. Will it be addressed? @badkk  suggestion does not solve that.
Are there plans for more advanced challenge-response schemes?

Yes, reply attack is a serious problem in this situation. But finally we think TTL is not the best idea to solve it, and the whole coversation is paused here(a little bit long tho😂) Any more thoughts on this? @mmyyrroonn


Update prometheus role for running with new data model

Wait for updates in kubernetes role, also possible needed changes in prometheus role.


[$500] Workspace - Chat shows both removed user and invited user's message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/

Tap profile icon

Tap workspaces

Tap create new workspace

Tap members

Tap invite

Select an user

Tap next

Delete the default invite message

Enter any message

Tap invite

Select the invited user

Tap remove to remove the user

Tap invite

Enter the same removed user email id and select

Tap next

This time with "default invite" Message, tap invite

As secondary user, open the invite workspace chat

Expected Result:
The workspace chat must show only invite message with which user was currently invited ie., default invite message
Actual Result:
The workspace chat shows previously invited and removed "custom invite message" and currently invited "default invite message"
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.59
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/7940226c-be2a-4772-8574-00b6eafb9759
https://github.com/Expensify/App/assets/78819774/7ee03c4a-b811-435f-8bd0-cebcd9d7591c
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01eabdead056f9e1af
Upwork Job ID:<PHONE_NUMBER>015164416
Last Price Increase: 2023-09-20

I am really swamped right now and have to prep for Saastr keynote day after at some point. So going to rotate this.

I want to be a  contributor for your project .

i want to be a contributor

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0131169e1e04804037

can you assign this job to me ?

@saifali069 Thank you for your interest here. Please checkout the contributing guide and follow proposal template.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0170075c594c192a25

Still looking for proposals

No proposals yet...

Might send this over to SWM/CS

No progress on this yet Melvin

Hi, I am Kacper from Callstack and I would like to work on this issue. 🔧

Please re-state the problem that we are trying to solve in this issue.
User should be able to see only recent Workspace invitation message.
What is the root cause of that problem?
Response received from call to api?command=OpenReport holds entire history of messages in Workspace <-> User context, including ones that were removed by undoing the invitation.
What changes do you think we should make in order to solve the problem?
In order to solve the problem, we might want to discard previous invitation messages when new invitation comes in. This should be done on backend side, as it involves changes to data integrity/storage logic.
By doing that, we will receive correct data when calling api?command=OpenReport.
What alternative solutions did you explore?
What is perceived as a bug, might ironically be a feature here - from my investigation, all invitations are made in isolation, with each invitation being separate request, possibly (quite likely) sent at various times.
System looks like is based on those isolated requests and prohibiting such behaviour seems to be fighting against the tides. If we would like to change that, it will require system-level changes described above.
As a last resort workaround, highly not recommended, we might filter out previous messages on frontend side, but this would require frontend app to distinguish between previous and current invitation message. From my understanding is not currently possible without changing backend response from api?command=OpenReport, which will put us at the same spot as with original proposal :D

@kacper-mikolajczak Thanks for the proposal. Your RCA makes sense. I think you are right here, we have nothing to do, this is working as expected.
🎀 👀 🎀 C+ reviewed
Asking for confirmation to close this. cc @greg-schroeder

Hey @grgia can you help confirm this should be closed per: https://github.com/Expensify/App/issues/26316#issuecomment-1730308624?

bump @grgia can you help me confirm this?

I think we can consider this a feature as of right now, closing.


Missing @sveltejs/kit/* docs

Describe the bug
The docs include a section for the generated modules ($app/*, $lib and $service-worker) but not the @sveltejs/kit/* ones: https://kit.svelte.dev/docs#modules
We should add some. Not sure where the best place for it is. We can probably omit adapter-utils since that will presumably become obsolete with #2215.
Reproduction
visit https://kit.svelte.dev/docs, look for the docs, find no docs
Logs
No response
System Info
N/A
Severity
annoyance
Additional Information
No response

I think this is mainly just import { sequence } from '@sveltejs/kit/hooks';, so we should probably put that with the handle docs


Passing in additional hash value in automate add_disk method

When added an "independent" disk, it will not be included in VM snapshot.
The automate add_disk method is only passing along disk_name and disk_size as you can see here:
def add_disk(disk_name, disk_size_mb, options = {})
sync_or_async_ems_operation(options[:sync], "add_disk", [disk_name, disk_size_mb])
end
However, the backend method supports passing a few additional properties: :thinProvisioned, :dependent and :persistent
def raw_add_disk(disk_name, disk_size_mb, options = {})
raise _("VM has no EMS, unable to add disk") unless ext_management_system
run_command_via_parent(:vm_add_disk, :diskName => disk_name, :diskSize => disk_size_mb,
:thinProvisioned => options[:thin_provisioned], :dependent => options[:dependent], :persistent => options[:persistent])
end
Please help to provide passing the additional hash values to support setting the other fields.
Thanks,
Casius.

I would also like to see this addressed.

Fixed in PR #14350


Change breakdown_keys to use XorReplicated to avoid bit-decomposition calls

There is a TODO for this in sort_by_breakdown_key() in aggregate_credit.rs. bit_decompose_breakdown_key is taking the majority of time in the aggregate_credit step.

This was fixed by @taikiy in #418.


Solving the issue with golangci-lint

Codecov Report

Merging #4 (2fe3f9b) into master (6ebee4e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   86.87%   86.87%
=======================================
  Files          30       30
  Lines         564      564
=======================================
  Hits          490      490
  Misses         45       45
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ebee4e...2fe3f9b. Read the comment docs.


Type cast before normalize perceiver

What does this PR do?
Modifies the feature extractor call to make the inputs to BatchFeature always numpy arrays. This ensures the type of the returned pixel_values matches those requested with return_tensors. The conversion to numpy arrays happens before normalization to ensure consistent rescaling is done on the inputs.
This solution means the return_tensors=None default can stay and that the behaviour is as expected for any combination of the do_xxx flag values.
Note: there were no previous tests for the feature extractor, so I didn't extend. I'm assuming this was done for a reason?
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[x] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Fix #211: include non-html filenames in page_ids

This refactoring adds consideration for filenames without a ".html" extension when listing all page_ids (e.g. when generating a sitemap).  For example, when using the Haml gem, a file named "template.haml" will now cause "template" to appear in HighVoltage.page_ids. (Previously, this required the file have a ".html.haml" extension, even though that was not required by the Haml gem itself.)
This also removes the assumption that template filename extensions consist of only lower-case alpha characters.  For example, if someone decides to go wild and create a template engine based on the m4 macro language, "template.html.m4" would now appear as "template" in HighVoltage.page_ids.
This also now allows (static or templated) plain text files to appear in HighVoltage.page_ids with their extension intact.  For example, "foo.txt.erb" and "bar.txt" will appear as "foo.txt" and "bar.txt".
This also reduces the number of disk accesses when listing page_ids.

👍

Thanks @jonathanhefner - closing this in favor of https://github.com/thoughtbot/high_voltage/pull/266 which keeps Page intact but utilizes ActionView::Template.template_handler_extensions as introduced here.

(Reposting https://github.com/thoughtbot/high_voltage/pull/266#issuecomment-379351817 here, for posterity)
The reason I took this approach was that it resulted in less complexity (fewer moving parts, fewer lines of code).  It was also more performant (fewer object allocations and fewer system calls per request).  Also the name Page seemed to be a misnomer, because Page objects could represent file paths which were explicitly not pages.  It seemed like the only purpose of the Page class was to obfuscate filtering logic that was part of PageCollector.


Add NacosConfigurationTests

Describe what this PR does / why we need it
After using IDEA checktstyle，Add NacosConfigurationTests

The modified problems by checkstyle are：
add a blank line at the end of the file;
modify the order of annotations.


Enable page view based on standard quranic script

I personally enjoy reading from a physical book since the pages are tactile and can be distinguished. It would be great if we could organize the ayat to view by page based on the standard Othmani quranic script.

i thought i did this, did you guys not put it in?
On Wed, Nov 18, 2015 at 6:30 PM Reshad Noorzay<EMAIL_ADDRESS>wrote:

I personally enjoy reading from a physical book since the pages are
tactile and can be distinguished. It would be great if we could organize
the ayat to view by page based on the standard Othmani quranic script.
—
Reply to this email directly or view it on GitHub
https://github.com/quran/quran.com-frontend/issues/180.

@reshadn it exists. hit the book icon and itll give you the reading mode, which is formatted like the book - we can do more to make it pretty though

True there is a reading mode but it's designed as one continuous page vs
page-by-page. For example you can't see the left and right page like in a
book.  Unless I'm missing something.
On Thu, Nov 19, 2015, 10:44 AM Mohamed El Mahallawy <
<EMAIL_ADDRESS>wrote:

@reshadn https://github.com/reshadn it exists. hit the book icon and
itll give you the reading mode, which is formatted like the book - we
can do more to make it pretty though
—
Reply to this email directly or view it on GitHub
https://github.com/quran/quran.com-frontend/issues/180#issuecomment-158152103
.

the continuous layout is very fine but, there is 2 things that could be improved / fixed /added.

There is a bug, where if you hover on the last word , it jumps down to the next line, (rendering you unable to hover the last word and see the meaning)
It would be nice to have a view, where it is sorted by "page", so that the words are placed exactly where they are in the medina mushaf

ah yes @reshadn that'd be nice. I feel like it's a nice to have


release

Could you make a release of this?

i can look into it, however this project has been kind of obsoleted by the new msix stuff

@aL3891 ok no problem. I ll compile it if necessary. Thanks!


Update account and compliance data labels to the new data dictionary

Definition of Ready

[x] Does this meet the INVEST criteria?
[x] Does this have a clearly defined user?
[x] Does this have an estimate?
[x] Does this have acceptance criteria?
[x] Does this have sufficient context (wireframes, business rules, etc.)?
[x] Is this traceable to a feature, epic, or PI?

User Story
As a CAMPD user I want the account data labels to be consistent with the EPA data dictionary so that I can understand the data
Acceptance Criteria
Given that a user has made a GET request to an account API endpoint with the file type set to JSON
When data is returned
Then the allowance JSON labels are consistent with the Master label data dictionary (see context)
Given that a user has made a GET request to a compliance API endpoint with the file type set to csv
When data is returned
Then the csv allowance labels are consistent with the Master label data dictionary (see context)
Given that a user has made a GET request to a compliance API endpoint with the file type set to JSON
When data is returned
Then the allowance JSON labels are consistent with the Master label data dictionary (see context)
Given that a user has made a GET request to an account API endpoint with the file type set to csv
When data is returned
Then the csv allowance labels are consistent with the Master label data dictionary (see context)
Given that a user has selected preview data on the custom data download for allowance data and compliance data
When the functionality is displayed
Then the data labels are consistent with the Master label data dictionary (see context)
Given that a user has navigated to the account swagger page
When the example schema is displayed
Then the values contain a description
AND the description is consistent with the Master Data dictionary (see context)
Given that a user has navigated to the compliance swagger page
When the example schema is displayed
Then the values contain a description
AND the description is consistent with the Master Data dictionary (see context)
Developer Notes

the scope of this ticket includes updating the api endpoint parameters and adding descriptions (see context)

Allowance API endpoints include: Allowance holdings, allowance transactions, account info,  compliance (emissions based), compliance (allowance based)
CSV Labels that need to be updated
| Data Type | Current CSV Label | New CSV Label |
|---|---|---|---|
| Allowance holdings, transactions, account info  | Program | Program Code |
JSON labels that need to be updated

Data Type
Current JSON label
New Json label

Allowance Holdings, Account Info
orisCode
facilityId

Allowance Holdings, Transactions
prgCode
programCodeInfo

Allowance Holdings, Account Info
ownDisplay
ownerOperator

Allowance Transactions
sellOrisplCode
sellFacilityId

Allowance Transactions
sellSourceCat
sellSourceCategory

Allowance Transactions
sellOwnDisplayName
sellOwner

Allowance Transactions
buyOrisplCode
buyFacilityId

Allowance Transactions
buySourceCat
buySourceCategory

Allowance Transactions
buyOwnDisplayName
buyOwner

Account Information
program
programCodeInfo

Does this Story require 508 Testing?

[ ] Implementing a new authoring tool that will produce code / content for the application
[ ] Implementing a 3rd party widget that will be part of the application
[ ] Adding new / updating custom functionality
[ ] Adding new / updating a page template
[ ] Adding new / replacing existing functionality (unless the replacement has already passed 508 testing)
[ ] Full Site Review prior to a scheduled EPA 508 review
[ ] Planning a video that will appear on the application
[ ] Producing a video that will appear on the application
[ ] Producing Training materials
[ ] Producing documents

Context
(User journeys, design mockups, architectural diagrams, business rules, data element definitions)

1. Confirm or change name for parameters:
Keep/Change

unitType
Keep

unitFuelType
Keep

controlTechnologies
Keep

program
change name to programCodeInfo

sourceCategories
change name to sourceCategory

opHoursOnly
change name to operatingHoursOnly

2. Need parameter descriptions for:
New Description

unitFuelType
Primary or Secondary fuel types combusted by the unit.

controlTechnologies
Method or equipment used by the combusion unit to minimize Hg, NOx, PM, or SO2 emissions.

beginDate
Begin date for a given period of a unit's emissions.

endDate
End date for a given period of a unit's emissions.

opHoursOnly
Indicator of whether or not a request should return only data for hours where a unit operated.

sourceCategories
Unit classification in terms of its primary function.

transactionBeginDate
Begin date for a given period of an account's allowance transaction history.

transactionEndDate
End date for a given period of an account's allowance transaction history.

page
Page number of data being requested

perPage
Number of results per page

Refer to Final_CAMPD_Master Data Labels List_EPA CAMD_v1.0 here
Testing
Test Case: TC397
Tester: @JanellC
Definition of Done

[x] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[x] Has the code been unit tested and peer reviewed?
[x] Have the functional tests been executed?
[x] Have all defects been reviewed and dispositioned, resolved, or deferred?
[ ] Has the user story been accepted by the Product Owner?
[x] Is the user story ready to be deployed to the test/staging environments?

Allowance Transactions
The data preview table is not returning all of the available data for allowance transactions. This ticket will address this issue
** Data preview table is missing data**
The data preview table is missing data that is available via the allowance transactions API endpoint. If you run the query for 03/23/1993, oris code= 602, and state =MD, the API returns data for facility id (transferee), buy source cat, and owner (transferee)  . However this data isn't available in the data preview or when you download the file.

https://easey-dev.app.cloud.gov/api/account-mgmt/allowance-transactions?transactionBeginDate=1993-03-23&transactionEndDate=1993-03-23&orisCode=602&state=MD

Fields mappings

TC397 passed @tlageman-epa


[Idea] [Pager] Emit page changes while scrolling

It would be useful to be able to subscribe to page changes while scrolling. Here is a side-by-side example of our current desired behaviour (left) vs accompanist (right):
https://user-images.githubusercontent.com/17993806/114008159-8a6e5380-9894-11eb-93e7-194e85042f33.mp4

So this is actually what we had previously, but we changed it in #299 to only update the selected page after a scroll has finished.
Maybe we should add an option parameter for this, as different scenarios require different behaviors.

On second thoughts, I'm not actually sure this is the behavior we want. The example above isn't really a pager, it's a carousel, and VerticalPager isn't really built for that use-case. For example, it's not really built to handle a continuous scroll which goes beyond the height (or width) of 1 item.

No worries - totally agree. Any idea if theres plans for snapping support in LazyColumn/Row? Or alternatively would this library ever offer a carousel composable?

I'm not aware of a public issue, so please go ahead and create one: https://goo.gle/compose-feedback.

Or alternatively would this library ever offer a carousel composable?

Probably not. It's too similar to LazyColumn or LazyRow that it wouldn't be worth it imo. Note, you can do this yourself by suppling your own flingBehavior to LazyColumn, and scrolling the items are required. LazyListState should expose enough information for you to implement this.

I'm going to close this here, as I don't think there's anything for us to do here.


Experimental Component - RadioButtonGroup

This epic is to include all the issues for making this component easily consumable.
A user can discover the experimental component on the System site and understand why and how to use it.

closing, this is a React component only and shouldn't need any updates for experimental


Option to change default umask for mkhomedir_helper

I noticed that currently the site agent uses mkhomedir_helper to create the auto-generated user home directories, but there is no way to change it's default umask value.
In our configuration we would like to use umask 0077, but this seems like something worth exposing in the site agent configuration file.

ok, makes sense, will add to the dev log

available option in the latest develop branch


Fix statistics sensor honouring max_age

Breaking Change:

If max_age is configured, this change will keep updating the statistics even when none of the observed entities change their state. That means that after some time all recorded states are purged and the statistics sensor itself changes to state unknown instead of just keeping its old state indefinitely. Also, some attributes (total, min_age, change, change_rate, mean, stdev) will change to unknown.
You should ensure that any automations that interrogate the statistics sensor's state and attributes can handle unknown.
This change is necessary to fix the behavior for use-cases where the observed entities are not regularly changing their state (for example counters), but the statistics sensor should change its state as time passes.
Description:
The statistics sensor currently only updates its own state if any of the observed entities change their state. If max_age is configured then all outdated entity states will be purged before updating its own state.
However, if none of the observed entities actually change their state, then no outdated entity states will be purged, and the calculated statistics are going out of date.
This change will introduce an additional update of the sensor at the time when the next stored state would need to be purged, hence always keeping the statistics up to date.
Related issue (if applicable): fixes #19800
Pull request with documentation for home-assistant.io (if applicable): n/a
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: statistics
    entity_id: sensor.pulse_counter
    max_age:
      minutes: 10

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

Just rebased and fixed the two issues from the review.

Rebased, let's see if that fixes the build.

Thanks!


Inflated dependency tree when using ngxtension

Please reduce the required (production) dependencies of ngxtension. (This is somehow related to #156)
Reason:
Currently ngxtension requires nx, @nx/devkit and ts-morph as production dependencies. These packages are enormous and blow up the transitive dependencies in projects using ngxtension. Also, because of this, security scans (like Blackduck) currently see Nx and its dependencies as production code, which causes problems in our use case.
I cannot see a reason why these dependencies cannot be declared as devDependencies instead.
Thanks for this great library!

Hi Kaemmelot,
The reason why nx, @nx/devkit, and ts-morph is dependencies instead of devDependencies is because of ng add. Now, this assumption was based on my experience with the package managers' behavior from before (they do not install devDependencies by default) but I think they change now. I can take a look.

This seems to be a bigger problem than I initially realized. I have been experimenting with this over the last few days and I now assume that there is a structural problem with the package managers or the concept of migrations included within a library in general.
First of all, nx does not seem to be used by the schematics/migrations, neither for Angular CLI nor for Nx. @nx/devkit and ts-morph are in fact required for these schematics/migrations to work.
In NPM it seems to be impossible to provide a package that can be partially used in production and development at the same time. At least when the dependencies differ.
I think there are a few unfavorable ways to handle such cases:

Add devopment dependencies to dependencies or peerDependencies and depend on tree shaking to get rid of them in production (as currently done for ngxtension)
Provide two separate packages, one for development and one for production (one could argue about separation of concerns here)
Bundle required development dependencies with bundleDependencies into the package (destroys all package management benefits)
Maybe it would be possible to use peerDependencies with an optional flag in their meta data and tell the library users to install these dependencies later on if needed (does not work with Angular schematics/Nx migrations)

I guess what would be really needed here is either peerDevDependencies or an additional dev flag in peerDependenciesMeta to provide transitive development dependencies.
Not sure what the best course of action would be in this case.

Closing this in favor of #410
Let's move our discussion over there as wel


Option to auto save tabs

Some people may prefer not having to manually click the tick mark on every tab to be saved.
A configuration option to automatically save every new tab in every saved/permanent window -- would be very useful.

#129


Babel ES6 JavaScript Grammar

Babel ES6 JavaScript Grammar not work with .js files.

I'm guessing that you have tree-sitter turned on. See https://github.com/gandm/language-babel/issues/491 and see if that helps.

@gandm
You were absolutely right! Many thanks! For a week I suffered and could not understand what was happening :)

Glad that fixed it for you.


Benchmark tar files

This PR gives velcom the ability to benchmark arbitrary tar files. These tar files can be uploaded by an admin via the queue page.
It also includes an overhaul of the backend config file options and example config file. The example config now contains more detailed documentation of all its contents. Therefore we suggest to use the new example config as a basis for your config file from now on. For more information, see #173.
@Kha You can merge this PR whenever you want. Please use a fast-forwarding merge instead of the github UI so stable stays on the main branch (like in #112).

Apparently this PR invalidates all current repo admin tokens (although after resetting them, they work again). If that's fine with you, you can still merge it, otherwise I'll try to fix it soon.

That seems to have fixed it.


test: failing test for constructor purge

https://github.com/unjs/ofetch/issues/180

Closing due to changes in destr, see linked PR.

Waiting until destr fix has been published, will add the working test then ☺

I think we can close this as was upstream issue and now fixed.


Update mentions to include names of people being mentioned/tagged

Changed mentions from an array of ID's to an object containing the ID of the people tagged and the names that they were tagged with.

Can we help to clean this up a little?
You seem to do all the work to get the value for JSON.parse(m.delta.data.prng) 3 times. Is there some reason we can't just store that in a variable and then access several things from it? I feel like it would go a long way towards making this readable.

I've updated the code to look cleaner.

@cthuluhoop123 see any issues with this?
If not I will merge :)

Seems fine to me :)

Thanks @RtzLi 😄


Enhance Query hooks

Modify Query.on()

Add new parameter to allow automatic removal of registered hook after next process()
Registering a Query.on() hook now returns a unique hookID to allow application control for unregistering

Add method to Query Class

Query.off(id: number) - remove a registered hook

** Add tests **

Unit tests for Query hook registration and removal

** Update docs **

Modify documentation in Digging Deeper > Query Class

Awesome! 🎉  Thank you so much! I'll merge this and make a release tonight. I'll leave it open just until then.


[tagger] add kube_cronjob tag

What does this PR do?
Add kube_cronjob tag in the tagger. Applies to container metrics, metrics from autodiscovery, and logs.
Motivation
Feature request
Additional Notes
Also fix some error handling issues that go vet spotted.

@hkaj I think a rebase should fix the run_tests_deb-x64


How to set formParameters?

Hi there,
I'm trying to create a stub with some form parameters. According to the doc, I need to set formParameters, but I cannot find it in this library.
Is this not implemented or am I missing something.
Thanks.

I’d be happy to help. Let me take a look and see what/if I can do anything (disclaimer, TS is not my strength 😁)

@akefirad I was able to get to it
feel free to take a look at the pull request. i will try to merge that and create a release later today

@akefirad https://www.npmjs.com/package/wiremock-captain/v/3.4.0 should solve it
thanks for raising the issue!

Thanks for quick response!


[Unified Checkpoint] update async_save_info

PR types
Bug fixes
PR changes
Others
Description
Overwrite async_save_info.json file to fit the change of world_size.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update Ambient Light Sensor support

Reflect spec redesign and rename to 'Ambient Light Sensor'
Update Chrome, Firefox, and Edge implementation status
Update Demo and Article accordingly
Update Notes

Fix #4191

Looks good, thank you!


Installation fails due to pymatgen wheel build error

Description:
Dear author, I tried to install ChatMOF on my machine, but the installation failed during the pip install -e . step.
Steps to Reproduce:

$ git clone https://github.com/Yeonghun1675/ChatMOF.git
$ cd ChatMOF/
$ pip install -e .

Environment:

OS: Ubuntu 20.04
Python Version: 3.9

Error Message:

  Building wheel for pymatgen (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for pymatgen (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [586 lines of output]
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build/lib.linux-x86_64-cpython-310
      creating build/lib.linux-x86_64-cpython-310/pymatgen
      creating build/lib.linux-x86_64-cpython-310/pymatgen/alchemy
      copying pymatgen/alchemy/__init__.py -> build/lib.linux-x86_64-cpython-310/pymatgen/alchemy
    (Other copies omitted)
      running build_ext
      /tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/Cython/Compiler/Main.py:384: FutureWarning: Cython directive 'language_level' not set, using '3str' for now (Py3). This has changed from earlier releases! File: /tmp/pip-install-le48hem5/pymatgen_f4b87c9bfd87448d98306e2dbb11350b/pymatgen/optimization/linear_assignment.pyx
        tree = Parsing.p_module(s, pxd, full_module_name)
      Compiling pymatgen/optimization/linear_assignment.pyx because it changed.
      [1/1] Cythonizing pymatgen/optimization/linear_assignment.pyx
      building 'pymatgen.optimization.linear_assignment' extension
      creating build/temp.linux-x86_64-cpython-310
      creating build/temp.linux-x86_64-cpython-310/pymatgen
      creating build/temp.linux-x86_64-cpython-310/pymatgen/optimization
      gcc -pthread -B /root/miniconda3/envs/mof/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /root/miniconda3/envs/mof/include -fPIC -O2 -isystem /root/miniconda3/envs/mof/include -fPIC -I/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/numpy/core/include -I/root/miniconda3/envs/mof/include/python3.10 -c pymatgen/optimization/linear_assignment.c -o build/temp.linux-x86_64-cpython-310/pymatgen/optimization/linear_assignment.o
      In file included from /tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/numpy/core/include/numpy/ndarraytypes.h:1969,
                       from /tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/numpy/core/include/numpy/ndarrayobject.h:12,
                       from /tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/numpy/core/include/numpy/arrayobject.h:4,
                       from pymatgen/optimization/linear_assignment.c:1167:
      /tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:17:2: warning: #warning "Using deprecated NumPy API, disable it with " "#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
         17 | #warning "Using deprecated NumPy API, disable it with " \
            |  ^~~~~~~
      pymatgen/optimization/linear_assignment.c: In function ‘__pyx_pf_8pymatgen_12optimization_17linear_assignment_16LinearAssignment___init__.isra.0’:
      pymatgen/optimization/linear_assignment.c:20070:7: warning: ‘__pyx_v_last’ may be used uninitialized in this function [-Wmaybe-uninitialized]
      20070 |   int __pyx_v_last;
            |       ^~~~~~~~~~~~
      pymatgen/optimization/linear_assignment.c:20868:19: warning: ‘__pyx_v_j2’ may be used uninitialized in this function [-Wmaybe-uninitialized]
      20868 |         __pyx_t_5 = __pyx_v_j1;
            |         ~~~~~~~~~~^~~~~~~~~~~~
      pymatgen/optimization/linear_assignment.c:20084:7: note: ‘__pyx_v_j2’ was declared here
      20084 |   int __pyx_v_j2;
            |       ^~~~~~~~~~
      pymatgen/optimization/linear_assignment.c:21602:96: warning: ‘__pyx_v_m’ may be used uninitialized in this function [-Wmaybe-uninitialized]
      21602 |                 (__pyx_v_v[__pyx_v_j1]) = (((__pyx_v_v[__pyx_v_j1]) + (__pyx_v_d[__pyx_v_j1])) - __pyx_v_m);
            |                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
      pymatgen/optimization/linear_assignment.c:20080:26: note: ‘__pyx_v_m’ was declared here
      20080 |   __pyx_t_5numpy_float_t __pyx_v_m;
            |                          ^~~~~~~~~
      gcc -pthread -B /root/miniconda3/envs/mof/compiler_compat -shared -Wl,-rpath,/root/miniconda3/envs/mof/lib -Wl,-rpath-link,/root/miniconda3/envs/mof/lib -L/root/miniconda3/envs/mof/lib -Wl,-rpath,/root/miniconda3/envs/mof/lib -Wl,-rpath-link,/root/miniconda3/envs/mof/lib -L/root/miniconda3/envs/mof/lib build/temp.linux-x86_64-cpython-310/pymatgen/optimization/linear_assignment.o -o build/lib.linux-x86_64-cpython-310/pymatgen/optimization/linear_assignment.cpython-310-x86_64-linux-gnu.so
      /tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/Cython/Compiler/Main.py:384: FutureWarning: Cython directive 'language_level' not set, using '3str' for now (Py3). This has changed from earlier releases! File: /tmp/pip-install-le48hem5/pymatgen_f4b87c9bfd87448d98306e2dbb11350b/pymatgen/util/coord_cython.pyx
        tree = Parsing.p_module(s, pxd, full_module_name)
      warning: pymatgen/util/coord_cython.pyx:214:25: Non-trivial type declarators in shared declaration (e.g. mix of pointers and values). Each pointer declaration should be on its own line.
      warning: pymatgen/util/coord_cython.pyx:263:41: Non-trivial type declarators in shared declaration (e.g. mix of pointers and values). Each pointer declaration should be on its own line.

      Error compiling Cython file:
      ------------------------------------------------------------
      ...
          #ensure correct shape
          fcoords1, fcoords2 = np.atleast_2d(fcoords1, fcoords2)

          pbc = lattice.pbc
          cdef int n_pbc = sum(pbc)
          cdef int n_pbc_im = 3 ** n_pbc
                                ^
      ------------------------------------------------------------

      pymatgen/util/coord_cython.pyx:91:26: Cannot assign type 'double' to 'int'
      Compiling pymatgen/util/coord_cython.pyx because it changed.
      [1/1] Cythonizing pymatgen/util/coord_cython.pyx
      Traceback (most recent call last):
        File "/root/miniconda3/envs/mof/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/root/miniconda3/envs/mof/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/root/miniconda3/envs/mof/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 251, in build_wheel
          return _build_backend().build_wheel(wheel_directory, config_settings,
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 434, in build_wheel
          return self._build_with_temp_dir(
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 419, in _build_with_temp_dir
          self.run_setup()
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 341, in run_setup
          exec(code, locals())
        File "<string>", line 72, in <module>
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/__init__.py", line 107, in setup
          return distutils.core.setup(**attrs)
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 185, in setup
          return run_commands(dist)
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
          dist.run_commands()
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
          self.run_command(cmd)
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/dist.py", line 1233, in run_command
          super().run_command(command)
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
          cmd_obj.run()
        File "/tmp/pip-build-env-wbpn5mzr/normal/lib/python3.10/site-packages/wheel/bdist_wheel.py", line 364, in run
          self.run_command("build")
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
          self.distribution.run_command(command)
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/dist.py", line 1233, in run_command
          super().run_command(command)
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
          cmd_obj.run()
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/_distutils/command/build.py", line 131, in run
          self.run_command(cmd_name)
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
          self.distribution.run_command(command)
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/dist.py", line 1233, in run_command
          super().run_command(command)
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
          cmd_obj.run()
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/command/build_ext.py", line 88, in run
          _build_ext.run(self)
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 345, in run
          self.build_extensions()
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 467, in build_extensions
          self._build_extensions_serial()
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 493, in _build_extensions_serial
          self.build_extension(ext)
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/setuptools/command/build_ext.py", line 249, in build_extension
          _build_ext.build_extension(self, ext)
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/Cython/Distutils/build_ext.py", line 122, in build_extension
          new_ext = cythonize(
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/Cython/Build/Dependencies.py", line 1134, in cythonize
          cythonize_one(*args)
        File "/tmp/pip-build-env-wbpn5mzr/overlay/lib/python3.10/site-packages/Cython/Build/Dependencies.py", line 1301, in cythonize_one
          raise CompileError(None, pyx_file)
      Cython.Compiler.Errors.CompileError: pymatgen/util/coord_cython.pyx
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pymatgen
  Building wheel for wget (setup.py) ... done
  Created wheel for wget: filename=wget-3.2-py3-none-any.whl size=9656 sha256=106955b99c520cf194f186f093239e3639ef96cc714584dbaebb927ddfb6c493
  Stored in directory: /root/.cache/pip/wheels/7a/6d/bb/2e81753127056d3756de433bcb983900f50a990432a36f1d7e
  Building wheel for docopt (setup.py) ... done
  Created wheel for docopt: filename=docopt-0.6.2-py2.py3-none-any.whl size=13705 sha256=71d4b1fb12cd50a2101115c580f2beb731f26e4bf8ff69932c3e722be01dd707
  Stored in directory: /root/.cache/pip/wheels/0c/5e/6b/8820c3d6f05aeae3801db2c9c003c0c14d93c917680a448396
  Building wheel for jax (pyproject.toml) ... done
  Created wheel for jax: filename=jax-0.4.14-py3-none-any.whl size=1535361 sha256=2e26df1cd82c6b5f5a06ad93295e3e05607da327f6b468de7c0921777d059e86
  Stored in directory: /root/.cache/pip/wheels/bd/98/b3/a1b1d2f550e2ccd1ebfb7d1162af448dd2a3a16051c076fbaf
  Building wheel for future (setup.py) ... done
  Created wheel for future: filename=future-0.18.3-py3-none-any.whl size=492025 sha256=89fc6a6b4d4a2ab3a70c42de7aa9f83df15c9bbb6934c813b6c44fd7181f37a3
  Stored in directory: /root/.cache/pip/wheels/6e/54/16/2ab500319d13efeeee4b2007aab5a01589dc775fb1a1f617c5
Successfully built timeout_decorator wikipedia wget docopt jax future
Failed to build pymatgen
ERROR: Could not build wheels for pymatgen, which is required to install pyproject.toml-based projects

Hi @Andy6M,
First of all, thank you very much for your interest in our ChatMOF project.  We have checked the installation error you sent us. We have confirmed that this issue occurs with the PORMAKE library. (PORMAKE is a library for generating MOFs.) For unknown reasons, PORMAKE does not seem to be installing at the moment. We have informed the authors of PORMAKE that we hope to resolve this issue and will let you know if it is resolved.

Hi @Yeonghun1675,
Thanks for the quick update on the PORMAKE issue. I appreciate your team looking into it. I'll await further updates. 감사합니다.
Best,
Andy6M

Hello @Andy6M ,
It's been a while. I'm reaching out to troubleshoot some issues with our code. I think you should be able to use it normally now, but please let me know if you run into any further issues.


Typings: fix the return type of QueryBuilder.execute()

execute() turns a query builder into a promise, but the return type of that promise in turn depends on the subtype of query builder. I removed it from QueryBuilderBase and added it to each of the subtypes, which should get the return type right. There might be a more clever way to do this, but I couldn't figure anything out and this does work.
Fixes #608.

Maybe I should've add a test for this, though?

Coverage remained the same at 95.798% when pulling 43b1e2cd24b6ab4657c1ce8eea36bac6bf960200 on kblomster:execute-typings into fb43aedb6d32072607d91317341dd559fd39a2dc on Vincit:master.

Thanks, @kblomster !
I think we could define an interface to reduce this diff. Do you think this is better/as readable?
export interface Executable<T> extends Promise<T> {
  execute(): Promise<T>
}

export interface QueryBuilderSingle<T> extends
  QueryBuilderBase<T>, ThrowIfNotFound, Executable<T> { }

export interface QueryBuilderUpdate<T> extends
  QueryBuilderBase<T>, ThrowIfNotFound, Executable<number> {

}
export interface QueryBuilderInsert<T> extends
  QueryBuilderBase<T>, ThrowIfNotFound, Executable<T[]> { }

In any event, any typings diff should require either a change to an existing test, or a new test, please.

Ah, I didn't think of that. I considered the interface solution at first but for some reason I didn't realize that the new interface could be merged with the Promise, so it looked kinda messy. Your idea is more DRY-ish and looks nicer. I'll change it to that.
Re: tests: I was trying to come up with some way to test for the absence of methods of the query builder and couldn't figure out a way to do it, but I've now realized that was a brainfart and there's no point to that. I'll get on it.
As an aside, while I was poking around I noticed TS 2.6 breaks a lot of stuff, but I'll file a separate issue for that.

As an aside, while I was poking around I noticed TS 2.6 breaks a lot of stuff, but I'll file a separate issue for that.

Done--can you review #623 please?

@mceachen You're leaving me in the dust, here! I'm not so quick at this yet :)
I'll take a look and rebase this on top of it after you've merged it.

@kblomster Sorry, I thought you might be asleep/past working hours! If the rebase isn't clean because the prettier diffs, please let me clean up the mess. Sorry about that, I didn't think about this pending PR.

@mceachen Oh, no worries! It is getting late here indeed, so I'll get to this tomorrow, but it's no problem, it's like five lines of code I need to fix.

Coverage remained the same at 95.779% when pulling 1791faa64c8d0521e68ab80329379caaf241911b on kblomster:execute-typings into 09a729670c97aef96976e4c6e554ad377d549efe on Vincit:master.

@mceachen I've pushed a new attempt. Could use your 👀  when you have the time.
After some waffling back and forth on what to test, I ended up simply adding execute() to all the query builder signature change tests. At first I was thinking I'd add a function that took a query builder and tested that it was both chainable and executable, but maybe that's overkill? What are your thoughts?

I think we should have both non-execute and execute calls in the examples. Can you only add .execute to, say, the 5 unique types of results, and revert the others?
Thanks!

I went with the first option you proposed, mostly. Let me know if you have any further comments regarding how I did it, I don't mind making cosmetic changes.

Coverage remained the same at 95.779% when pulling f37b3d82dd424b5a706ef39739abf6dcc668a759 on kblomster:execute-typings into a325eb82a757962568c89281affd67e371cd16b6 on Vincit:master.

Coverage remained the same at 95.779% when pulling f37b3d82dd424b5a706ef39739abf6dcc668a759 on kblomster:execute-typings into a325eb82a757962568c89281affd67e371cd16b6 on Vincit:master.

Thanks!

Thank you too for your patient and helpful reviews!


Retrieve compressed logs by default

Starting in Elasticsearch 6.0.0, when logs are rolled they will be compressed by default. This means that a support diagnostics dump should obtain these compressed logs too, otherwise a support diagnostics dump could be missing valuable logs for diagnosing an issue.
Relates elastic/elasticsearch#25660

I think I'm going to put this one to a support team vote before I do anything about it. That setting to not pull rolled logs when specified was put in by request. There's potentially a lot of output there and we were getting diags that were either too big to attach or took a while to upload/download.
The output gets compressed, so is having the archived logs in compressed format going to buy you much other than possible speeding up the packaging?  Doesn't seem like there would be an appreciable size difference.
I can appreciate you want as much information as possible. But if it's a high severity incident you're playing beat the clock to some degree and that extra few minutes can make a difference both at the customer and the support level. I've already asked customers to run with the archived option when the current logs didn't suffice.
So this is one I'll raise at the next group meeting.
I'm getting ready to do a few other things though.  Let me ask you this.  If it didn't pull everything but checked for the previous couple of versions or so as long as they didn't go over a certain size threshold would that be OK?

I would vote to have the last three days by default. My reasoning is that I often get a diagnostic where rollover happened ~1h before diagnostic collection. Getting the previous day fixes that issue, and getting 2 days prior helps understand how long the issue might have been happening. That is my 2¢


matcha-gtk-theme: 2020-12-07 -> 2021-01-12

Motivation for this change
Update to version 2021-01-12
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 109129 1

1 package built:

matcha-gtk-theme

Result of nixpkgs-review pr 109129 1

1 package built:

matcha-gtk-theme

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109129 run on x86_64-linux 1

1 package built:

matcha-gtk-theme

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109129 run on x86_64-linux 1

1 package built:

matcha-gtk-theme


Remove dangling quotes from vfio-user.rst

This improves rendering on github quite a bit.

Oops! Thanks @dreiss  - do you mind adding your Signed-off-by ?


Statusline is set to two lines but only top line is filled

Just when you have selected your character, the top window is set to two lines. However, only the top line is filled with reverse spaces, so some random piece of text just sticks around on line 2. When the game starts properly, the second line is filled with reverse characters as well.

(In this case "ARCHERY" happened to be on line 2 when the statusline was created)

Thanks for reporting. I made a fix in the latest story file


Conditionally set source_path_size in the loaders and docs

Handle no source path in get_source_size.
Conditionally set source_path_size in the loaders and docs.

Not sending the source_path_size in doc and loader both, if it is None.
Changing default value of size to None. We may have to handle in-memory source path for loader source path.
rest all looks good to me.

It seems in-memory source path for loader source path is handled automatically, @Raj725 correct?

@rahul-trip Yes, the get_source_size function returns None and that's handled later.


Fix ResponseInit in Fetch API

As you can see here all ResponseInit properties are optional

I will drop this PR because I'm going to update whole Fetch API extern


Feat map to zip

Save volumes and parcellation maps to a zip file. See e2e/volumes/test_tozip.py for example code.
Notes:

Saves meshes as .gii
Each volume of a map returns a readme.
It was decided in dev meeting on 2024.01.25 that there should be a level before calling fetch, i.e., get_volume so that the over arching design pattern remains (fetch takes out user to inter-operable data types). However, this created a lot of overhead which is not expected when getting a volume object should not cause. It also made the code more complicated. (see https://github.com/FZJ-INM1-BDA/siibra-python/pull/554/commits/6867cff79fea8572ae6b37b7590c17515cc33616)

Unit test test/retrieval/test_retrieval_download_file.py is failing due to data-proxy being down.

@AhmetNSimsek I need more guidance to respond to this issue.

if we wanted it once, did the situation change in any way so that we ask ourselves whether or not it would still be done?
what are advantages and disadvantages of doing it?
is it a matter of merging this PR or are there additional efforts implied to finish it?

In general I do think we should implement download of zips, especially since it is already available in siibra-explorer and I think the functionality should be provided from siibra-python (not be implemented twice). I do not consider it urgent. If the explorer-functionality is so far independent, I am happy to reconsider it for siibra-python v2.
@AhmetNSimsek I need more guidance on this issue.
* In how far did the situation change so that we need to reconsider our past agreement to implement it?

When the explorer was switching to version 1 of siibra-python, this was a must. But now that the explorer will switch from version 0.4 to version 2 directly, it was not a big necessity.

* what are advantages and disadvantages?

This PR allows downloading maps from siibra-python, which would be a good addition, but not sure it is a necessity. siibra-python version 2 handles and covers several points (see PR description) this PR solves better.

* is it a matter of merging this PR or are there additional efforts implied to finish it?

Currently, this draft utilizes Subvolume class to handle getting regional masks. This needs to be updated to use another class (ExtractedVolume?). Then it can be merged.

Stale. https://github.com/FZJ-INM1-BDA/siibra-python/pull/624 solves most of the issues better but does not include to_zip method. Since it is rather modular, it can be taken from this PR in the future.


Add support for Embedded DataTable from Editor

Hi there,
I'd like to suggest support for embedded DataTables from DataTables Editor.
Examples: https://editor.datatables.net/examples/datatables/
Field Type: https://editor.datatables.net/reference/field/datatable
This adds an embedded datatable to a DataTables editor instance which allows it to be used as a select, if the parent table that the editor is associated with is using AJAX, it will also pull the options from AJAX. (see the 'Server Script' on this example for an example: https://editor.datatables.net/examples/datatables/select.html - the AJAX data from the example also shows this data at the bottom)
See the DataTables Editor PHP Library implementation here: https://editor.datatables.net/docs/1.6.0/php/class-DataTables.Editor.Options.html
Thanks.

I want the library to be as easy to use as possible. I don't want to complicate it with the Editor plugin. Thanks for the advise.


SITE-000 :: update column class names

Updates the new class name convention from -*c to *-col for clarity and memorability.
Updates the changelog

@ActiveCampaign/site

@NickCiliak they will primarily be for the instances you mentioned. My initial thought was to limit them as well, but I couldn't come up with a strong argument for limiting them. If you think it is option overload, it's no problem to put more limits in place

@cameronjbrand I'm in favor of limiting them in order to reduce file size, and if we find ourselves needing more options we can add them in.

@NickCiliak updated!


Add coverage function report to travis-ci runs

Can you elaborate on the intention here? Is this meant to amend coverage information to the CI output, or will the coverage data just be printed to the CI logs?

Well, I'd prefer to push things to a service like coveralls.io but nobody liked that patch :)
I think it's useful to be able to see the coverage levels for submitted PRs, even if it isn't easy to compare it to the parent commit.

I didn't have a chance to look into your other proposal (yet). But I think having some service would be more useful. I think that just lacked some justification/discussion. What does it give us, how does it work, etc.

You can take a look at lorax and pykickstart as good examples of how coveralls.io looks over time:

https://coveralls.io/github/weldr/lorax
https://coveralls.io/github/pykickstart/pykickstart

It is linked to the github repo the same way travis-ci is, and when the upload runs from inside travis it includes the credentials to link to the correct repo without having to do a bunch of extra setup.
I'm sure there are other services out there, this is just the one I'm most familiar with, and we have been using it for years with minimal issues with it.


Clearance::User email validation strict_mode: true option has no effect

The Clearance::User email validation strict_mode: true option has not had any effect since strict_mode: true option was deprecated (and removed) in email_validator v2.0.0.
Strict validation was reintroduced as mode: :strict in email_validator v2.2.0
The email_validator gem was updated in clearance https://github.com/thoughtbot/clearance/commit/793d8ada5ca1ec75c12847dc96eb8d2a81b2a01a (v2.1.0).
Our app's test suite caught it when we upgraded from clearance v1.16 to v2.5 by unit testing that invalid@example (no fqdn) was expected to be an invalid email.
Proposed solutions (choose one):

Restore the strict validation behavior: up the email_validator version minimum to ~> 2.2 and change strict_mode: true to mode: :strict.
Or, keep the current clearance behavior as of v2.5.0 (non-strict validation) and remove strict_mode: true from email validation, since it's dead code.

Whether we keep strict validation or not, we should update clearance's test suite to check for the desired effect.
I'd be happy to open a PR, but need a decision on which solution to implement.

I also stumbled across this issue.  I feel like choice 1. makes the most sense, change to mode: strict


feat: data source shares

to implement #1497 - shares data source
Test Plan

[x ] acceptance tests

References
https://docs.snowflake.com/en/sql-reference/sql/show-shares

@mlorek thank you for your contribution


[Reproduce] GPT4 pass@1 0.0

I try to reproduce the result on GPT4 but get 0 in pass1.

Have you uncommented these lines?
https://github.com/BloopAI/COBOLEval/blob/bcfb08628becd1be89450a0da7cd92bcdfa45a46/scripts/evaluation.py#L112
Note the disclaimer above

Thank you very much, I didn't pay attention to that part.

The results from my rerun with GPT-4 closely align with our previous outcomes. However, the results obtained using the bloopai/mAInframer-7b model, both with Complete and Infill, in the new commit #5 are very poor. Could you guide me on reproducing the results of bloopai/mAInframer-7b?
Thank you.

Hey @hieutrungdao, thanks for flagging. Looking into this.

@hieutrungdao , the results were obtained using VLLM for inference to speed up things.
See branch vllm_infill for vllm implementation:
https://github.com/BloopAI/COBOLEval/compare/main...vllm_infill
from generate import  VLLMInfill
from utils import Model

model = Model(name="bloopai/mAInframer-7b", tokenizer="codellama/CodeLlama-7b-hf", prefix_token="<PRE>", suffix_token="<SUF>", middle_token="<MID>", eos_token="</s>")

infiller = VLLMInfill(model)
infiller.eval()

The previous code should generate the completions, then:
python scripts/evaluate_functional_correctness.py

after setting run_folder inside evaluate_functional_correctness.py to the preds/bloopai/mAInframer-7b should get the results from the blog post.
I just ran the 7b model and got 6.16% pass@1. Using the HuggingFace generator I get ~4% which as you said it is quite poor (still looking into why they generate different completions).

#6 fixes the issue of Hugging Face infilling giving a different pass@1 result. Closing it


New Wallet not mining

hello, i have set up a small mining pool for verge with about 500Gh on blake2s, i could not get a block on 48 hrs running non stop, looking at my blake2s.log file i found this errors:
18:15:33: XVG 2054281 - diff 13544747.158115184 job 522 to 145/145/145 clients, hash 545540.144/1530901212.545 in 1.3 ms
18:15:55: XVG 2054281 - diff 13544747.158115184 job 523 to 145/145/145 clients, hash 535762.673/1530901212.545 in 1.4 ms
18:16:15: Verge 2054282 not reporting
18:16:16: XVG 2054283 - diff 13544747.158115184 job 524 to 145/145/145 clients, hash 528200.539/1572276920.992 in 1.3 ms
18:16:36: Verge 2054283 not reporting
18:16:37: XVG 2054284 - diff 13544747.158115184 job 525 to 146/146/146 clients, hash 533105.231/1572276920.992 in 1.4 ms
18:16:57: Verge 2054285 not reporting
18:16:58: XVG 2054286 - diff 10123889.088431366 job 526 to 146/146/146 clients, hash 534306.585/1175183041.707 in 1.5 ms
18:17:18: Verge 2054286 not reporting
18:17:19: XVG 2054287 - diff 10123889.088431366 job 527 to 146/146/146 clients, hash 539064.468/1175183041.707 in 1.3 ms
18:18:01: Verge 2054289 not reporting
18:18:02: XVG 2054290 - diff 10123889.088431366 job 528 to 148/148/148 clients, hash 569413.579/1207827015.087 in 1.4 ms
18:18:22: Verge 2054290 not reporting
18:18:23: XVG 2054291 - diff 10123889.088431366 job 529 to 148/148/148 clients, hash 573013.264/1207827015.087 in 1.4 ms
18:18:43: Verge 2054291 not reporting
18:18:44: XVG 2054292 - diff 10123889.088431366 job 52a to 147/147/147 clients, hash 568189.734/1207827015.087 in 1.4 ms
18:19:04: Verge 2054292 not reporting
18:19:05: XVG 2054293 - diff 10123889.088431366 job 52b to 147/147/147 clients, hash 564438.892/1242336358.376 in 1.4 ms
18:19:26: XVG 2054293 - diff 10123889.088431366 job 52c to 147/147/147 clients, hash 583800.714/1242336358.376 in 1.4 ms
Any ideas why is not working, a different coin for the same pool is working great... got a lot of those "Verge 2054XXX not reporting"
this is my config file, i am running Ubuntu 16 on a VPS
rpcuser=yiimprpc
rpcpassword=XXXXXXXXXXXXX
rpcport=5610
rpcthreads=8
rpcallowip=<IP_ADDRESS>
onlynet=ipv4
maxconnections=12
daemon=1
algo=blake
gen=0
alertnotify=echo %s | mail -s "Verge alert!"<EMAIL_ADDRESS>blocknotify=/var/stratum/blocknotify pool2mine.com:5766 561 %s

you don't need gen=0
also, make sure you are using 4.0clearnet branch

duplicate of #708 i think... will consolidate both of you on that issue
@pool2mine feel free to re-open if you feel your issue is different .. and make sure you did what justin suggested about the gen=0 and 4.0clearnet


add support for starttls on smtp connections

add a config option for enabling starttls (defaulting to false)

Sorry for the late reply. Thanks for the PR. mokey underwent some major code refactoring. This has been included in v0.5.1.


Update acts_as_copy_target.rb

Fix issue where adding a column mapping erase others column names.

@pa657 thanks for the pull request, could you add a test case that fails without this change?

fix with test case/

@diogob Thanks to you for this very useful gem.
Without it, dealing with big amount of data is very painful...
Best regards


fix page_shape for rm tensor sharding

Addresses this issue: https://github.com/tenstorrent-metal/tt-metal/issues/4319

Is this pr still needed or can it be closed?
There was an actual fix for interleaved_to_sharded op pushed to main so the second commit in this pr should be removed.

@tt-aho the first commit I think needs to be there, the page shape that was returning for bfloat16 was too big otherwise. Should I separate that PR?

You can just remove the second commit from this pr since it is no longer needed after rebase

@tt-aho haha nvm, its been a while, looks like that commit was already pushed to main as it was cherry-picked in another PR.
Closing this one now


Build is marked as "successful" although a backend error occurred

Component
agent
Describe the bug
When having a backend error in the config, i.e. a malformed env var, the step and build are marked as successful even though they should be marked as "failed".

k8s backend
System Info
{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-6ab9f802"}

Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

Is it fixed?


Table variant

Fix #95
Test URLs (Schedule):

Before: https://main--sling--aemsites.aem.page/whatson/sports/baseball/000-mlb-network-free-preview
After: https://95-table-style--sling--aemsites.aem.page/whatson/sports/baseball/000-mlb-network-free-preview

Test URLs (Playoff):

Before: https://main--sling--aemsites.aem.page/whatson/sports/nhl/nhl-stanley-cup-playoffs-schedule-sling
After: https://95-table-style--sling--aemsites.aem.page/whatson/sports/nhl/000-nhl-stanley-cup-playoffs-schedule-sling

There are quite a few things to look at, I tried to capture them in this screenshot.


ibm-ups: Use object_t constructor with enum arg

The sdbusplus object_t constructor with a boolean third argument should
no longer be used.  The constructor with an enum third argument should
be used instead.
Signed-off-by: Shawn McCarney<EMAIL_ADDRESS>Change-Id: Ic46b8b6ebecd5c2cbde4434a2c3c27aabfa4771b

This PR is intended to make the same change to the ibm-ups application that was made to the other phosphor-power applications here:  https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-power/+/52661


Carousel Component Enhancement

The problem
We are adding enhancements to the carousel component in AEM where we can select a style (Block Card, Callout Quote,
Image) determining what card type item will be shown in the carousel. The problem we are experiencing is the Callout quote or Image styles retain their original CSS styling. For example, the callout quote text is retaining its text size which makes the height of the card item long.
The solution
The solution would be to add CSS enhancements to the carousel component to be able to handle callout quote sizing and image sizing/positioning. See attachment for reference of how each style is reacting within the carousel component.
Actual Results with Callout Quote and Image added to the carousel:
Callout Quote:

Image:

Existing carousel with block item:
Block:

@drukerk  Can you provide a copy of the code you are using to assemble the carousel?  Thanks.

@RobertaJHahn - Below is the code we are using for the carousel.
Carousel Code

                <dds-carousel data-sly-test="${!wcmmode.edit}"
                              class="${model.nonFullWidth ? 'dds--carousel-non-full-width' : ''}${wcmmode.preview ? ' hide-component-information' : ''}">
                    <sly data-sly-test="${model.blockCard}"
                         data-sly-resource="${'items' @ resourceType='adobe-cms/components/content/organisms/carousel/carousel-items-container'}"></sly>
                    <sly data-sly-test="${model.calloutQuote}"
                         data-sly-resource="${'items' @ resourceType='adobe-cms/components/content/organisms/carousel/carousel-items-quote-container'}"></sly>
                    <sly data-sly-test="${model.image}"
                         data-sly-resource="${'items' @ resourceType='adobe-cms/components/content/organisms/carousel/carousel-items-image-container'}"></sly>
                </dds-carousel>

                            <sly data-sly-test="${model.blockCard}"
                                 data-sly-resource="${'items' @ resourceType='adobe-cms/components/content/organisms/carousel/carousel-items-container'}"></sly>
                            <sly data-sly-test="${model.calloutQuote}"
                                 data-sly-resource="${'items' @ resourceType='adobe-cms/components/content/organisms/carousel/carousel-items-quote-container'}"></sly>
                            <sly data-sly-test="${model.image}"
                                 data-sly-resource="${'items' @ resourceType='adobe-cms/components/content/organisms/carousel/carousel-items-image-container'}"></sly>

                        <button part="prev-button" class="bx--btn bx--btn--secondary bx--btn--icon-only bx--carousel__navigation__btn">
                            <svg focusable="false"
                                 preserveAspectRatio="xMidYMid meet"
                                 xmlns="http://www.w3.org/2000/svg"
                                 fill="currentColor"
                                 aria-hidden="true"
                                 width="20"
                                 height="20"
                                 viewBox="0 0 32 32">

                                <path d="M20 24L10 16 20 8z"></path>
                            </svg>
                        </button>
                        1 / ${model.pageCount}
                        <button part="next-button" class="bx--btn bx--btn--secondary bx--btn--icon-only bx--carousel__navigation__btn">
                            <svg focusable="false"
                                 preserveAspectRatio="xMidYMid meet"
                                 xmlns="http://www.w3.org/2000/svg"
                                 fill="currentColor"
                                 aria-hidden="true"
                                 width="20"
                                 height="20"
                                 viewBox="0 0 32 32">

                                <path d="M12 8L22 16 12 24z"></path>
                            </svg>
                        </button>

Carousel items container code for block card, callout quotes, and image
<sly data-sly-use.container="com.adobe.cq.wcm.core.components.models.LayoutContainer"></sly>
<sly data-sly-test="${wcmmode.edit}" data-sly-use.allowed="com.day.cq.wcm.foundation.AllowedComponentList"></sly>
<sly data-sly-test.isAllowedApplicable="${allowed.isApplicable}"
     data-sly-test="${isAllowedApplicable}"
     data-sly-use.allowedTemplate="allowedcomponents.html"
     data-sly-call="${allowedTemplate.allowedcomponents @ title=allowed.title, components=allowed.components}"></sly>
<sly data-sly-test="${!isAllowedApplicable}" data-sly-repeat="${container.items}">

</sly>
<sly data-sly-test="${!isAllowedApplicable && !wcmmode.disabled}"
     data-sly-resource="${resource.path @ resourceType='core/wcm/components/container/v1/container/new', appendPath='/*', decorationTagName='div', cssClassName='new section'}"/>

Hi! Thanks for sharing. I created two codesandbox's for carousel with image and carousel with callout quote. Looks like this might be just an implementation issue.
image: https://codesandbox.io/s/brave-voice-049rj?file=/index.html
callout quote: https://codesandbox.io/s/amazing-river-erggs?file=/index.html

@druckerk  Any more issues or questions?  Can we close?

Closing.  No response from @druckerk

@RobertaJHahn - Thank you for the response and sandbox examples. I was able to get the carousel implementation to work properly with Callout Quotes and Images. This ticket is good to close.

9/21 Slack comment:


The Debug button jumps when I open the context menu with the right mouse button.

Hello VSCode! <3
There was a problem when I open the context menu with the right mouse button in the package.json file, then my "Debug" button jumps a few pixels down. When I click anywhere (i.e. close the menu), the button returns to its place. It seems to be a small problem, but I think it's worth fixing it!
And yes, this problem appears when I changed the scale from the standard, i.e. made the scale larger than the standard.
(Ctrl+=)

/gifplease

The other day I opened VSCode, and I could not repeat this bug. Very strange.
However, I am attaching two screenshots.

The second screenshot shows that the context menu is open. It is in this case that the Debug button in the code is displaced. Literally 1-2 pixels. But now I don't see this problem.


Reactions to API review changes + Globalisation support

There are some small reaction changes here to API review. Basically we've moved all of the compiler-helper parts of the runtime to Components.CompilerServices if they are purely implementation details of the runtime.
The exception to this is most of the functionality for @bind... because we want that to be callable by user-code.

The other part of this is that we're using a new BindConverter set of APIs for bind. This is part of the new globalisation functionality because these APIs treat culture correctly as a parameter. This is a more full-featured replacements for BindMethods which is being removed.

Make sure to look at commits because the baseline updates are pretty large.
The generated code for bind-Value (on a component) has been simplified.

@ajaybhargavb @NTaylorMullen @SteveSandersonMS - someone please 😆

The failures here I think are related to a need to rebase.


Update how we generate all_slow.json

We need to simplify the ByDirection<SlowZonesResponse[]> to ByDirection<SlowZoneResponse>, assuming there's only one active slow zone per track segment. This requires verification by reviewing the code that generates all_slow.json
The current all_slow.json doesn't contain historical values for every single day but aggregates over multiple days, which might lead to inaccuracies in duration for selected days.

@idreyn Please review this when you have a few minutes as this goes back to our discussion from Thursday. Feel free to edit the description.

I think we should actually consider generating an all_slow.json for every day in history — I think there'd be too much data to squeeze into that json file if we added a time series for every slow zone.

I'm missing some context here, but one file per day would require reading a
lot of files to do timeseries displays.
Better would be one file per slowzone - but it's tricky because they can
change in duration as our baseline drifts around. And we'd want 2 weeks
context before or after.
Maybe we're not talking about per-slowzone timeseries displays though, the
traveltime graphs do that pretty well.
On Mon, Feb 5, 2024 at 11:48 AM Ian Reynolds @.***>
wrote:

I think we should actually consider generating an all_slow.json for every
day in history — I think there'd be too much data to squeeze into that json
file if we added a time series for every slow zone.
—
Reply to this email directly, view it on GitHub
https://github.com/transitmatters/data-ingestion/issues/74#issuecomment-1927450287,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACA26AROMNZHC6UTWFPKHTTYSEEOZAVCNFSM6AAAAABC2IL2DCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRXGQ2TAMRYG4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I'm missing some context here, but one file per day would require reading a lot of files to do timeseries displays. Better would be one file per slowzone - but it's tricky because they can change in duration as our baseline drifts around. And we'd want 2 weeks context before or after. Maybe we're not talking about per-slowzone timeseries displays though, the traveltime graphs do that pretty well.
…
On Mon, Feb 5, 2024 at 11:48 AM Ian Reynolds @.> wrote: I think we should actually consider generating an all_slow.json for every day in history — I think there'd be too much data to squeeze into that json file if we added a time series for every slow zone. — Reply to this email directly, view it on GitHub <#74 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACA26AROMNZHC6UTWFPKHTTYSEEOZAVCNFSM6AAAAABC2IL2DCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRXGQ2TAMRYG4 . You are receiving this because you are subscribed to this thread.Message ID: @.>

We had discussed creating a dynamo table for this data, though I think that would incur a cost.

I'm missing some context here, but one file per day would require reading a
lot of files to do timeseries displays.

I think that's true, but I also think we are already doing all of those reads in analyze_for_slow(). We'd just need to hold on to the un-averaged travel time and slow time a little longer.

We had discussed creating a dynamo table for this data, though I think that would incur a cost.

We tend to be pretty liberal about spinning up Dynamo tables without worrying about their cost!

Closing this as it is needed here instead: https://github.com/transitmatters/slow-zones/issues/43


Add markdown documentation

Great! Thanks for your work. I'm wondering how we should generate API documentation. Is DocFX feasible?

This is up to @yhmo - I sent a question about that on Slack. docfx would indeed be ideal for just generating API docs from the source code, but if the goal is to get markdown files that will be rendered like the other language reference APIs (e.g. Python), that's probably not going to be possible, and a lot of manual work will be needed.
@yhmo I'll wait for your answer on this.

The API Reference can be an MD file with some sections to categorize APIs. The sections are not required to be consistent with other SDKs. Just clear to users is ok. For example: Connections, Database, Collection, Partition, Index, Utility, etc.

I've just pushed API reference docs which are basically copy-pasted from the comments already present in the code.
@weianweigan could you give this additional comment another quick review?
@yhmo I'm hoping we can get this up on the website as quickly as possible!
/cc @luisquintanilla

Great! We have the API document now. I notified @yhmo. Should we merge this PR first?

I think so - let me know if you need anything else from me here.

I think so - let me know if you need anything else from me here.

OK！Thanks!


Update release process documentation

Problem
Releasing the Transaction Tool application requires a process that involves developer credentials that might not be included as part of the initial documentation.
Solution
Update the existing release documentation for the Transaction Tool.
Alternatives
No response

I added an item to the end of this notion page, documenting the process as it is currently done:
https://www.notion.so/swirldslabs/Releases-1a7ee497af2d4d2d9bf4f344b5e02bbd


Test support for Windows, MacOS.

I'm on Linux (Debian) and I can confirm that it works on Linux. I'd like a Windows-user and a MacOS-user to confirm that the code compiles + runs without any issues.
According to this SFML Forum:

All the SFML code you write should compile without issues on all the supported platforms without modification.
And if you stick to standard C++ and avoid any platform and compiler specific code then that should also be true for the rest of your application.

So if the code compiles, then it must mean that there is no need for a seperate Windows SFML version. Thus, we'd able to remove this directory.
Here's a task list for each platform:

[ ] Windows
[x] Linux
[ ] MacOS

is there a Windows build?

@RomKart After some testing I realized, windows/macos is not supported at the moment. I'll be working on this issue in the coming days.


gofmt errors not reported/displayed on editor

Gofmt seems to correctly catch any errors I introduce to my go code, but those errors don't seem to propagate to Atom's message panel.  I know that gofmt is returning the errors because the errors show up in the Console tab of the Dev Tools.
For example, if I have the following code:
foo := []string{
   "a",
   "b"
}

On save, gofmt reports to the Console an error like this:

gofmt: (stderr) :134:6: missing ',' before newline in composite literal

However, I wouldn't see anything happen (not even formatting) without Dev Tools and the Atom status bar would report "No Issue" as well.
I am on Atom v1.5.4 and have the following packages installed:

go-plus / 4.1.0
autocomplete-go / 1.0.5
builder-go / 1.0.0
go-config /1.1.4
go-get / 1.0.3
gofmt / 1.1.3
gometalinter-linter / 1.1.0
gorename / 1.0.1
navigator-godef / 1.0.2

builder-go should be picking that up. In general, format errors are build errors, so they would be duplicative if I also sent them to linter for display. The question is: why aren't you seeing them show up as a result of builder-go. If you create an errant file (disabling format on save for a moment) and then run go install . in the terminal, do you see the errors?

Ah, that makes sense.  Unfortunately (and I apologize for not making this clear earlier), my go code actually needs to get built with my company's internal libraries, and thus, we don't actually run go build/install to build our code.  So, even if I run go install ., it won't even compile.  I was mostly just looking for auto-formatting using gofmt/goimports.
So, the next curious thing for me is that I've now noticed that these build errors I expect to get would actually get displayed on files in one directory but not files in another sibling directory.  For example, if I add the errant lines as above to files in dir A, I actually do see an error on the editor like this:
gometalinter / warning / missing ',' before newline in composite literal (golint).  If I copy the same errant file to dir B, I get "No Issues" displayed instead.  Do you have any ideas why this would be the case?  I've also ran golint <path to file> on dir A and dir B, and they both return the same error missing ',' before newline in composite literal.
I'm guessing this may be coming from the gometalinter, so I'm happy to move this thread to that repo if you'd like.


refactor: test DateEditor svelte component

Types of changes
Done by pairing with @claremacrae
Internal changes:

[x] Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
[x] Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

Make DateEditor.parsedDate available for testing
Create DateEditorWrapper component to test the DateEditor
Add tests showing current behaviour

Motivation and Context

Prepare to TDD date picker's behaviour

How has this been tested?

Unit tests

Checklist

[x] My code follows the code style of this project and passes yarn run lint.
[x] My change has adequate Unit Test coverage.

Terms

[x] My contribution follows this project's contributing guide
[x] I agree to follow this project's Code of Conduct

@claremacrae please note that I added 4 commits with cosmetics on top of what we wrote together


refactor cmake, add installation target

Currently, it is not possible to install this project globally on a system. This commit does two things:

It changes global compilation settings like language level to be target specific
It adds an installation target that allows other users to install the package globally on their systems

When this lib is installed, users can find it in their CMake projects via find_package and link it via target_link_library.

Thank you very much for this great contribution.

Hi chmike. In future releases, please don't forget to increase the version number located in the root CMakeLists file. I forgot to mention that.

I  will try to do that. I should make a new release soon.


Update to new radiuss docker containers

Updates us to the new shared RADIUSS containers (thanks @davidbeckingsale and @chapman39 ).
This also moves us to a system installed (and installed on the docker container) clang-format 14. I only applied the basic changes that were made by make style.

This is ready for a review. I have some follow up PRs that depend on this:

Style changes (line column limit, enforced brackets on single line if statements, etc)
Github action that styles our code based on a comment in the PR


Updated background color

Issue #99
I have updated the background color in Cpp page. @ankitapuri @arpit456jain
Please check if it is working in your system.

@arpit456jain is the color scheme fine?

yes


Minor help text adjustment for previous commit

Help text now mirror 0.5-5s refresh range

Thanks