A+ Token UI

Description of the PR
Adds the UI for inserting the token. The look of the UI is very basic as we're not sure yet if we're going to use tokens. The user is prompted for the token as needed, so the dialog isn't actually shown anywhere yet.
Testing

unit
integration
manual

- [x] new unit tests created
- [ ] all unit tests pass

- [ ] new integration tests created
- [x] all integration tests pass

- [x] manual testing went well

Have you updated the TESTING.md or other relevant documentation?

[ ] Yes
[ ] Not yet. I will do it next.
[x] Not relevant

question shall we have an Action or something to ask for a token?

That would probably useful, so maybe an item in the A+ menu? And then API actions check if the token has been entered, and if not, prompt the user for it

question shall we have an Action or something to ask for a token?

That would probably useful, so maybe an item in the A+ menu? And then API actions check if the token has been entered, and if not, prompt the user for it

this sounds good, will you implement it as a part of this task?

question shall we have an Action or something to ask for a token?

That would probably useful, so maybe an item in the A+ menu? And then API actions check if the token has been entered, and if not, prompt the user for it

this sounds good, will you implement it as a part of this task?

Yep I'll add the action :+1:


Media keys not working.

Operating system
Microsoft Windows [Version 10.0.22621.963]
YouTube Music Desktop App Version
v0.9.7
Bug description
instead of reopening #41 i decided to make a new thread as im unsure if im having the same bug
my media keys seem to not be caught by the app.
Steps to reproduce
No response
Relevant log output
the command provided and location provided seems to not exist

Been using media keys and its working fine. Could you provide me your keyboard name?

steelseries apex 3

im on Microsoft Windows [Version 10.0.19045.2364] it should work, probably an issue with your keyboard software.
but it could also be an issue if you have multiple media sources

Media keys are not working for me on Ubuntu 22.10. Do I need any extra setup for it?
I'm using Logitech G512. Media keys from my laptop keyboard (Dell inspiron) are not working either

Also having the same issue in Fedora with wayland - is there any way to diagnose?
Output from xev when touching the play/pause key:
KeyPress event, serial 34, synthetic NO, window 0x3a00001,
    root 0x49a, subw 0x0, time 367409856, (6,596), root:(3209,1018),
    state 0x10, keycode 172 (keysym 0x1008ff14, XF86AudioPlay), same_screen YES,
    XLookupString gives 0 bytes:
    XmbLookupString gives 0 bytes:
    XFilterEvent returns: False

KeyRelease event, serial 34, synthetic NO, window 0x3a00001,
    root 0x49a, subw 0x0, time 367409922, (6,596), root:(3209,1018),
    state 0x10, keycode 172 (keysym 0x1008ff14, XF86AudioPlay), same_screen YES,
    XLookupString gives 0 bytes:
    XFilterEvent returns: False

I am on a macbook with macOS 13.4 and having same problem with both laptop keyboard and Logitech G512.
I think this should be a important issue?

Media keys are currently not working for me on Fedora 39 running wayland.
When I press the media key all I get is a circle with a line through it. Fedora seems to not be recognizing the app as a media player.
App version: 0.11.6

I had the same issue, my media keys weren't connected by default on my sway config. I am not on my desktop, I can try to update this tomorrow with my config.

So this is the relevant information on my ~/.config/sway file.
I use pactl (PulseAudio) to bind the key
set $pctl playerctl -p playerctld
bindsym XF86AudioPrev exec --no-startup-id $pctl previous
bindsym XF86AudioNext exec --no-startup-id $pctl next
bindsym XF86AudioPlay exec --no-startup-id $pctl play-pause
bindsym XF86AudioStop exec --no-startup-id $pctl stop
bindsym XF86AudioMute exec pactl set-sink-mute @DEFAULT_SINK@ toggle
bindsym XF86AudioRaiseVolume exec pactl set-sink-volume @DEFAULT_SINK@ +5%
bindsym XF86AudioLowerVolume exec pactl set-sink-volume @DEFAULT_SINK@ -5%

# This is something else i found to be able to control multiple sources
const hasChainMail = items.some(item => item.includes('chainmail'));

I'm on MacOS Sonoma on a Macbook Air M1 and the media keys are not working. I'm using a Apple Magic keyboard with touch id.


MQTT adapter

Are there any plans for an MQTT adapter?

Thank you for requesting features!
MQTT is a famous messaging protocol so of course I'm willing to implement MQTT adapter for Kiara. But currently I'm so busy that I don't have enough time to add features that I won't use for the time being.
I would appreciate it if someone can help to do this.


Handle interface block layout

Offset and alignment of blocks should be handled correctly. The current implementation seems to ignore the memory layout. The following code snippet fails as pos is aligned to the base alignment of vec4
// GLSL code
uniform layout(std140);
uniform Light {
    vec3 pos;
    vec3 color;
};

// host code
#[derive(Copy, Clone)]
struct LightData {
    pos: [f32; 3],
    color: [f32; 3],
}

implement_uniform_block!(LightData, pos, color);

The offset/alignment is supposed to be checked when you draw. That's what DrawError::UniformBlockLayoutMismatch and LayoutMismatchError are for.
Could you give more information about what fails? A panic? No error and the shader not working?
Note that it is well-known that some drivers sometimes don't respect the standard when it comes to alignment of vec3s. However glium queries the data from the implementation, so it shouldn't trigger bugs.

Here is the output from the console:
thread '<main>' panicked at 'called `Result::unwrap()` on an `Err` value: UniformBlockLayoutMismatch { name: "Light", err: MemberMismatch { member: "color", err: OffsetMismatch { expected: 16, obtained: 12 } } }', ../src/libcore\result.rs:734

The error occurs on submitting a draw call with the fragment shader. target.draw(&vertex_buffer, &index_buffer, &program, &uniforms, &Default::default()).unwrap();

Well, that's the expected behavior.
Glium can't align data for you. You have to use something like this: https://github.com/tomaka/glium/blob/master/examples/gpgpu.rs#L33

Ok, thanks (:
Closing this.


Create CDK code to basic Rollups Infra

We should import some CDK code from cartesi-rollups infra but make adjusts for best practices during the process.

[ ] Postgres RDS should be on a separate Stack
[ ] Pack Constructs into self-contained modules
[ ] Reuse the constructs in separate Stacks if needed
[ ] ...

References:

https://github.com/kevinslin/open-cdk
https://aws.amazon.com/blogs/devops/best-practices-for-developing-cloud-applications-with-aws-cdk/
https://docs.aws.amazon.com/cdk/v2/guide/best-practices.html

Not relevant any longer


Fix Release workflow when triggered manually

Hello Peter,
I did some additional tests and observed that when Release workflow is triggered manually it will checkout the latest code and not the one specified by passed tag.
This fix will consider manually passed tag for code checkout. You can run it again for 0.2.0 release and it will replace assets with the new ones compiled from the appropriate tag.
Thank you!

Thank you!


crates publishing team

👋 Hi @GuillaumeGomez and @antoine-de, you two are the only "user-owners" of the geos crate on crates.io, so only you can edit that crate's owners on crates.io.
Following up on https://github.com/georust/meta/pull/21, I created a new geos-publishers team for publishing to crates.io with you as maintainer.
Could you please update the crate owners? Specifically:

[ ] @GuillaumeGomez or @antoine-de: update geos crate owners on crates.io:

cd geos

# 💥 remove large publishing team
cargo owner --remove github:georust:core

# 🔐 add small publishing team
cargo owner --add github:georust:geos-publishers

# make sure everything looks good 👀
cargo owner --list

[ ] @GuillaumeGomez: update geos-sys crate owners on crates.io:

cd geos

# 💥 geos-sys didn't have the georust/core team as a team-owner
# 🔐 add small publishing team (assuming you'd prefer to share a publishing team between geos and geos-sys crates)
cargo owner --add github:georust:geos-publishers

# 🚨 @GuillaumeGomez: note that you are the *sole* user-owner of the geos-sys crate.
# Consider adding another user-owner so that someone can still update the crate owners if you become inaccessible. Maybe @antoine-de?
cargo owner --add antoine-de

# make sure everything looks good 👀
cargo owner --list

If there's anyone else you'd like to be able to publish the crates, feel free to add them to your publishing team, or as a user-owner. Consider that user-owners, as opposed to owners-via-team, can themselves edit the crate's owners, which could be desirable, or not, depending.
Once you switch the publishing team, no one else will be able to publish until either they are added to the new publishing team or added as a user-owner.
Let me know if you have any questions, or you can review https://github.com/georust/meta/pull/21.

I'll when there will be another maintainer showing up. :)

@GuillaumeGomez can you clarify what you mean?

Sure: what I meant is simply that I don't think handing the maintenance to a team is a good idea. However, if someone contributes to geos crates, I have no issue to add them as well (that's what I did for gtk-rs). Currently we are two already, so the chances of both of us disappearing at the same time is quite low.

@GuillaumeGomez there seems to be a misunderstanding of this GitHub Issue. the goal of this is to limit, not expand, who can publish the geos crate. currently everyone in the georust github organization can publish it. when you have some time, please read https://github.com/georust/meta/pull/21. the goal

Oh! My bad. Then I'll do shortly. Sorry for the misunderstanding...

I get the following error:
$ cargo owner --remove 'github:georust:core'
    Updating crates.io index
       Owner removing ["github:georust:core"] from crate geos
error: failed to remove owners from crate geos

Caused by:
  api errors (status 200 OK): could not find the github team georust/core

$ cargo owner --list
    Updating crates.io index
GuillaumeGomez (Guillaume Gomez)
antoine-de (Antoine D)
github:georust:core (Core)

weird. @GuillaumeGomez can you try making the changes in the UI here? https://crates.io/crates/geos/owners

And done! Closing it then.

looks like georust/core is still an owner: https://crates.io/crates/geos/owners
i wonder if this is a crates.io bug?

 I got the message saying it was removed though... Opening an issue for them then.

The team was removed successfully from the owners list. Closing then.


Refactor from httpServices to Model pattern

Added command in Dockerfile for mac m1
Changed dockerfile of front-end to working on hot reload
Moved all high level function to models and only http verbs on the httpService. httpService.js is the layer, where developer can replace the axios with any other tools to communicate with API.

@fereloper brother, can you describe what problem are you trying to solve in this PR please?

Next question,  why use class in javascript instead of functions?  🙂

Thanks for your support brother, but I am not accepting any pull requests from others. Please accept my sincere apology. I appreciate your time and efforts.


Substring search and replacement

Serves two purposes:

[ ] detect and replace original LUTs if fixed offsets are different
[ ] detect and replace original names (e.g. "King Menelik", "Fort Akbar" etc.)

Found a few releases in the wild that critically depend on Task 1.


app.test_client is not thread-safe

Currently, using app.test_client() together with multi-threaded environment will fail:
from concurrent.futures import ThreadPoolExecutor

from flask import Flask, jsonify

app = Flask(__name__)

@app.route("/info")
def info():
    return jsonify({"status": "success"})

app.testing = True
with app.test_client() as client:

    def check(*args):
        return client.get("/info")

    with ThreadPoolExecutor(5) as tpe:
        print(tpe.map(check, range(5)))

with
Traceback (most recent call last):
  File "/Users/X/.pyenv/versions/flow-venv-3.9/lib/python3.9/site-packages/flask/ctx.py", line 399, in pop
    self.app.do_teardown_request(exc)
  File "/Users/X/.pyenv/versions/flow-venv-3.9/lib/python3.9/site-packages/flask/app.py", line 2370, in do_teardown_request
    for name in chain(request.blueprints, (None,)):
  File "/Users/X/.pyenv/versions/flow-venv-3.9/lib/python3.9/site-packages/werkzeug/local.py", line 316, in __get__
    obj = instance._get_current_object()  # type: ignore[misc]
  File "/Users/X/.pyenv/versions/flow-venv-3.9/lib/python3.9/site-packages/werkzeug/local.py", line 513, in _get_current_object
    raise RuntimeError(unbound_message) from None
RuntimeError: Working outside of request context.

Obviously, this can be solved by running the app as standalone (see http://www.prschmid.com/2013/01/multi-threaded-unit-test-for-flask-rest.html), but then I have to add manual error control and re-rise and do not get proper tracebacks while testing, and code coverage is also not given.

Duplicate of #4734
Do not push the client globally around all tests, that's not the correct way to use it. Only push the client if you need to preserve the request global after a test request is evaluated, and only around the code that needs it. In your example, you do not need to push the client at all, only created it.
client = app.test_client()

Thanks for the feedback, so I'd need to make sure each test client is thread-local. Wouldn't it make sense to drop a hint for this somewhere in the documentation?


Add support for adoption of existing Flow Logs and Security Groups

Issue #, if available: https://github.com/aws-controllers-k8s/community/issues/1946
Description of changes:
This proposed fix add support for additionalKeys needed to support adoption of Security Groups and FlowLogs as requested on the issue linked above.
The following adoption instructions will now work:
apiVersion: services.k8s.aws/v1alpha1
kind: AdoptedResource
metadata:
  name: my-flow-log
spec:
  aws:
    nameOrID: fl-xxxxxxx
    additionalKeys:
      resourceID: vpc-xxxxxx
      resourceType: VPC
  kubernetes:
    group: ec2.services.k8s.aws
    kind: FlowLog
---
apiVersion: services.k8s.aws/v1alpha1
kind: AdoptedResource
metadata:
  name: my-sg
spec:
  aws:
    nameOrID: sg-xxxxxx
    additionalKeys:
      name: "My GroupName"
  kubernetes:
    group: ec2.services.k8s.aws
    kind: SecurityGroup

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/ok-to-test

Tried to find an example of an adopted check to use as a baseline, but couldn't find one. For these two resources adoption, we should create a new Security Group manually, and create a new VPC with flow log enabled. How should I proceed with this? I don't want to stand up new resources that will be hard to tear down after, and I don't fully understand the e2e workflow.

Tried to find an example of an adopted check to use as a baseline, but couldn't find one. For these two resources adoption, we should create a new Security Group manually, and create a new VPC with flow log enabled. How should I proceed with this? I don't want to stand up new resources that will be hard to tear down after, and I don't fully understand the e2e workflow.

Instead of creating everything manually, you can use ACK it self to provision those resources... once provisioned you can annotate those resources with a delete-retain-policy and try to adopt right after. https://aws-controllers-k8s.github.io/community/docs/user-docs/deletion-policy/

@pcolazurdo Did you test those changes locally? happy to merge if you say it worked for locally. We need a global plan to add resource adoption tests..

I've done some more testing and there is an issue with the Security Group adoption that I haven't been able to solve as this seems to be an issue with this particular API and how the runtime manager required fields.
The name property in the Security Group Resource is a required property for creation, but because it can be mutated later, it shouldn't be considered as an Identity property. The problem seem to be that the existing specs doesn't let you define a property as required for creation but not for reading (ReadOne). Defining the Name property as an additionalKey for adoption produce the side effect that if the Name specified in the adoption CRD is different that the existing on AWS, the property will be mutated, which is undesired side effect that can break existing environments. We need to find a way to specify properties as required for creation but optional for read.
I'll write a but report on the runtime repo with this
I'll also create a different PR for the VPC Flow Logs piece. In this case, the AWS API doesn't allow mutation so there is no side effect if the user makes a mistake when defining the values of the additionalKeys.


Model query using the with handler returns always all entities

I found that there is a mistake when making a condition using the with handler. To better understand the issue, I have covered the problem by creating a test based on yours owns. It is possible that I haven't understood the way to use the with handler but to be sure I prefer to share you my test to detect if it is or not a critical issue.
I have seen that in order to query a model relationship to get posts, the mechanism of the with handler seems to be broken and returns by default all entries from an entity.
Tested on release v0.31.7.
import { createStore } from 'test/support/Helpers'
import Model from 'app/model/Model'

describe('Feature – Relations – Retrieve – Constraint', () => {
  class User extends Model {
    static entity = 'users'

    static fields () {
      return {
        id: this.attr(null),
        posts: this.hasMany(Post, 'user_id')
      }
    }
  }

  class Post extends Model {
    static entity = 'posts'

    static fields () {
      return {
        id: this.attr(null),
        user_id: this.attr(null),
        published: this.boolean(false),
        user: this.belongsTo(User, 'user_id')
      }
    }
  }

  const store = createStore([{ model: User }, { model: Post }])

  store.dispatch('entities/users/create', {
    data: [{ id: 1 }, { id: 2 }, { id: 3 }]
  })

  store.dispatch('entities/posts/create', {
    data: [{ id: 1, user_id: 1, published: true }, { id: 2, user_id: 1, published: true }, { id: 3, user_id: 2, published: false }]
  })

  /*
    * Reminder:
    * user_1 has published posts [1, 2]
    * user_2 has no published post
    * user_3 has published post [4]
  */

  // only user_1 has at least one published post
  const expected_value = 1

  it('can resolve constraint using with orm query statement', () => {

    // get users who have post id 1 in their posts relationship
    const users = store.getters['entities/users/query']()
      .with('posts', (query) => {
        query.where('published', true)
      })
      .get()

    expect(users.length).toEqual(expected_value)

  })

  it('can resolve constraint using with native query statement', () => {

    const users = store.getters['entities/users/query']().with('posts').get().slice()
    const results = users.filter( (user) => {
      return user.posts.some( (post) => {
        return post.published == true
      })
    })

    expect(results.length).toEqual(expected_value)

  })

})

Mocha output
  Feature – Relations – Retrieve – Constraint
    1) can resolve constraint using with orm query statement
    ✓ can resolve constraint using with native query statement

  1 passing (65ms)
  1 failing

  1) Feature – Relations – Retrieve – Constraint
       can resolve constraint using with orm query statement:
     Error: expect(received).toEqual(expected)

Expected: 1
Received: 3
      at Context.<anonymous> (.tmp/mocha-webpack/1554412366220/webpack:/test/feature/relations/Retrieve_Constraint.spec.js:60:1)

As you can see, the orm query statement has returned all entities instead of returning only one entity.
BTW : the test file https://github.com/vuex-orm/vuex-orm/blob/master/test/feature/relations/Retrieve_Constraint.spec.js#L51 is wrong because it returns more than one result but you couldn't see that before because it was tested only on the first entry result.
Thanks!

@pimeo Hi! thank you for the feedback!
The result is expected. To get the "users" which has matching relation constraints, you should use has or hasWhere.
The with constraint limits the number of relation, not the model that is queried.
So for your example, it is expected that you get all users. To get only the users that have posts with published value of true, you need to do this.
const users = store.getters['entities/users/query']()
  .with('posts')
  .whereHas('posts', (query) => {
    query.where('published', true)
  })
  .get()

This is documented here:
https://vuex-orm.github.io/vuex-orm/guide/relationships/retrieving-relationships.html#querying-relationship-existence

Hi @kiaking
Thanks for you answer. I will test your example to verify that the expected value is right (and I can provide you the test if you want to add to the current tests).
Also to be clear with the documentation when I see the following example:
// Get all users with posts that have `published` field value of `true`.
const user = User.query().with('posts', (query) => {
  query.where('published', true)
}).get()

/*
  [
    User {
      id: 1,
      name: 'john',
      posts: [
        Post: { id: 1, user_id: 1, body: '...', published: true },
        Post: { id: 2, user_id: 1, body: '...', published: true }
      ]
    },

    ...
  ]
*/

Can you confirm me that this is a valid and expected code/output result, and that we won't have posts as results with published state set to false (via a test file by example)?
Section of the documentation linked: Relation Contraints

Ohh sorry yeah that documentation's comment is a bit confusing. It sounds like it returns only the matching "users" rather than "posts".

Can you confirm me that this is a valid and expected code/output result, and that we won't have posts as results with published state set to false (via a test file by example)?

Yes. We have a simpler test case for this.
  it('can resolve relation constraint', () => {
    const store = createStore([{ model: User }, { model: Post }])

    store.dispatch('entities/users/create', {
      data: [{ id: 1 }, { id: 2 }, { id: 3 }]
    })

    store.dispatch('entities/posts/create', {
      data: [{ id: 1, user_id: 1 }, { id: 2, user_id: 1 }, { id: 3, user_id: 2 }]
    })

    const expected = {
      $id: 1,
      id: 1,
      posts: [
        { $id: 1, id: 1, user_id: 1, user: null }
      ]
    }

    const users = store.getters['entities/users/query']()
      .with('posts', (query) => {
        query.where('id', 1)
      })
      .first()

    expect(users).toEqual(expected)
  })

Here there are 2 posts relates to the user with id of 1 but we only retrieve the post with the id of 1. If we were to fetch all users on above test case, then the result would be like below.
[
  {
    id: 1,
    posts: [
      { id: 1, user_id: 1 }
    ]
  },
  {
    id: 2,
    posts: []
  },
  {
    id: 3,
    posts: []
  }
]

Ok now it's clear ! Thank you for your response. I will close the ticket.

Great! Sorry for the confusion. I'm planning to rewrite the whole documentation before hitting v1.0.0 so I'll make sure to update doc to be easier to understands. Thank you for the feedback! 🤝


Currency only displayed in Euro

Dear Team,
I could see only amount/value in Euro in CRM
how can we change this?
Thanks,
Sameer

Hi Sameer
Sorry for the delayed response - for some reason Github stopped notifying me....
In any case - Pipeline CRM uses the currency of the current User. So if you are logged in as a UK user, you see GBP, if you are a US user you get USD, and users from the Eurozone see EUR.
If however, you wish for the ability to switch between currencies for the same user, please flag it as a feature request, and we will consider it in the upcoming version.
Hope this helps. Thanks for using Pipeline :+1:
Theo

I am not able to flag it as feature request
please help

You just did :-)
Let me just play back the request - I will add a setting in pipeline.config which sets the currency, overriding the user's culture. Will that work for you?


Make si_status method more compatible

Now that this PR has been merged, siginfo_t::si_status is a method for some targets and a field on others. This PR adds the method on targets that already expose the field, which lets the method be used without target detection.
I think this change is backward compatible, but it would be better if someone else could confirm that. The struct would now have a method and a field with the same name on some targets. If that's incompatible, another method could be added that accesses the field or calls the method depending on the target, but this is cleaner.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Thanks!
@bors r+

:pushpin: Commit 29b4faed15becc3a7e90fd30d5daf55f06e297d7 has been approved by JohnTitor

:hourglass: Testing commit 29b4faed15becc3a7e90fd30d5daf55f06e297d7 with merge f26757a8fd1978fb3503884adc63a0e812bfe25c...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing f26757a8fd1978fb3503884adc63a0e812bfe25c to master...

Thank you too!


PHP 7.2 support

Fix issue #747

Our organization still uses a lot of microservices in zend1, we plan on keep using zend1 for a long time. I do not understand why this forced deprecation. It is unnecessary obsolescence.

@sh4ka

It is unnecessary obsolescence.

Sorry, but it was necessary. Version 2 was released 5 September 2012. After this date version 1 was supported 4 more years! How many versions should be maintained in parallel?

Please take a look at https://github.com/zf1s - a “composeable” zf1 with some fixes added. All components are available on packagist.org with zf1s/ namespace and we are still keeping php 7.2+ compatibility.


Use of WidgetBase raises ParamFutureWarning

I'm on panel==1.5.0rc2 and param==2.1.1.
I have a custom CompositeWidget that I noticed started raising a ParamFutureWarning. After some inspection I can see the problem is is caused by the fact that the WidgetBase.value is a Parameter while my CustomWidget.value is a String.
I think this will be cause general problems as WidgetBase is now intended to be mixed into all kinds of custom widgets.
Reproduce
import panel as pn
from panel.widgets.base import WidgetBase
import param

class CustomWidget(pn.viewable.Viewer, WidgetBase):
    value = param.String()

    def __panel__(self):
        return self.param.value

CustomWidget(value="Hello World").servable()

/home/jovyan/repos/mt-pm-reporting/script.py:5: ParamFutureWarning: String parameter 'CustomWidget.value' failed to validate its default value on class creation, this is going to raise an error in the future. The Parameter type changed between class 'CustomWidget' and one of its parent classes (Viewer, WidgetBase) which made it invalid. Please fix the Parameter type.
Validation failed with:
String parameter 'CustomWidget.value' only takes a string value, not value of <class 'NoneType'>.
  value = param.String()

Workaround
Change param.String() to param.String(""). Then the ParamFutureWarning will not be raised.

@jbednar @maximlt pinging you for visibility.

It's also due to allow_None being computed dynamically. It's set to True in the superclass but, in that case, wrongly overridden at the sub-class level
import param

class A(param.Parameterized):
    x = param.Parameter()

class B(A):
    x = param.String()

print(A.x)
print(A.param.x.allow_None)
print(B.x)
print(B.param.x.allow_None)

None
True
None
False

They are a couple of tests that capture this (somewhat buggy) behavior:
https://github.com/holoviz/param/blob/e54dd51d99fa768a8ce08f2414b44d8fe3fab534/tests/testparameterizedobject.py#L1294-L1326


Occasional IndexError on empty segments

I ran into this error: IndexError: arrays used as indices must be of integer (or boolean) type - this happens when a segment is empty (same issue as this on openai's whisper). A fix has been implemented on openai's whisper here: https://github.com/openai/whisper/pull/1317
Could you implement the same fix for whisper-at, too? Thanks!

Thanks so much for pointing this out and provide the solution.
From https://github.com/openai/whisper/pull/1317/files, it seems only two lines of code needs to be added. We will have to do a brief test to see if that breaks something else, if no, it will be fixed in the next version.
Before that, you can install with pip -e and manually add those two lines as a workaround.
-Yuan


Preserve Token Uncertainty from Whisper output

For noisy audio (songs etc.) the transcripts may contain errors.
Users should be informed about possible mistakes.

Preserve Token Uncertainty info from whisper output
Add functionality to visualize uncertainty in text.

https://github.com/EtienneAb3d/WhisperHallu
https://github.com/openai/whisper/discussions/679


Genesis device resets planet build queue

While swapping to the default production plan after resetting a planet is certainly better than deleting it entirely, it'd be nice if it just... didn't reset the queue at all (which is present in OG stars - build queue is preserved after resetting).

Does it preserve partially built items? That seems weird.

It appears not - I tested it in a max game and it doesn't look to keep anything at all.


Prevent inconsistencies when cancelling service binding/instance creations

The first commit (1f9d43a4a11127d1560a9b56637c0b45badb9b74) refactors ServiceCredentialBindingMixin into ServiceOperationMixin to also be used by RouteBinding and ManagedServiceInstance.
The second commit (6616c370e70a959ec2757d42fa247c1d35f5b36a) adds a new 'create initial' state to service operations to distinguish between
requests that have not been responded to and operations that are being processed asynchronously by the broker.
The reasoning for this change is the following scenario:
sequenceDiagram
  participant Client
  participant Cloud Controller
  participant CCDB
  participant Some Routing Component
  participant Service Broker

  Client->>+Cloud Controller: create
  Cloud Controller->>CCDB: insert
  activate CCDB
  Cloud Controller->>+Some Routing Component: provision
  Note over Some Routing Component: some delay

  rect rgba(255, 0, 0, .2)
    Client->>+Cloud Controller: delete
    Cloud Controller->>+Some Routing Component: deprovision
    Some Routing Component->>Service Broker: #
    Service Broker-->>Some Routing Component: 410 Gone
    Some Routing Component-->>-Cloud Controller: #
    Cloud Controller->>-CCDB: delete
    deactivate CCDB
  end

  Some Routing Component->>Service Broker: provision (cont.)
  Service Broker-->>Some Routing Component: 201 Created
  Some Routing Component-->>-Cloud Controller: #
  Cloud Controller->>-CCDB: update
  Note over CCDB: already deleted!

When a creation is delayed for some reason (up to 60 seconds until the request times out), it is possible that an impatient client issues a deletion request in parallel that might lead to a situation where an instance is created by the service broker, but the Cloud Controller already removed it from its database. To mitigate this inconsistency, the Cloud Controller would need to trigger an orphan mitigation; but this is solely done within the service client implementation, i.e. only as a result of communication errors, not based on state inconsistencies.
The alternative approach implemented in this PR is the introduction of a new 'create initial' state that is set in ServiceCredentialBindingAppCreate, ServiceCredentialBindingKeyCreate, ServiceRouteBindingCreate and ServiceInstanceCreateManaged. In most cases the 'initial' state is semantically treated as 'in progress', but when checking for a blocking operation before accepting a delete request, it is treated as such and results in an error being reported to the client:
sequenceDiagram
  participant Client
  participant Cloud Controller
  participant CCDB
  participant Some Routing Component
  participant Service Broker

  Client->>+Cloud Controller: create
  Cloud Controller->>CCDB: insert
  activate CCDB
  Cloud Controller->>+Some Routing Component: provision
  Note over Some Routing Component: some delay

  rect rgba(255, 0, 0, .2)
    Client->>+Cloud Controller: delete
    Cloud Controller-->>-Client: 422 Unprocessable
  end

  Some Routing Component->>Service Broker: provision (cont.)
  Service Broker-->>Some Routing Component: 201 Created
  Some Routing Component-->>-Cloud Controller: #
  Cloud Controller->>-CCDB: update
  deactivate CCDB

The Open Service Broker API specification allows for delete requests being processed in parallel to create requests (which should semantically be treated as a cancel operation). This requirement is still fulfilled, but limited to create requests already accepted and asynchronously processed by the broker. So this change has no effect on the following scenario:
sequenceDiagram
  participant Client
  participant Cloud Controller
  participant CCDB
  participant Some Routing Component
  participant Service Broker

  Client->>+Cloud Controller: create
  Cloud Controller->>CCDB: insert
  activate CCDB
  Cloud Controller->>+Some Routing Component: provision
  Some Routing Component->>Service Broker: #
  Service Broker-->>Some Routing Component: 202 Accepted
  Some Routing Component-->>-Cloud Controller: #
  Cloud Controller->>+Some Routing Component: poll
  Note over Some Routing Component: some delay

  rect rgba(255, 0, 0, .2)
    Client->>+Cloud Controller: delete
    Cloud Controller->>+Some Routing Component: deprovision
    Some Routing Component->>Service Broker: #
    Service Broker-->>Some Routing Component: 202 Accepted
    Some Routing Component-->>-Cloud Controller: #
    Cloud Controller->>-CCDB: update
  end

  Some Routing Component->>Service Broker: poll (cont.)
  Note over Service Broker: last_operation now
indicates the state of
the deprovision request
  Service Broker-->>Some Routing Component: 200 OK
  Some Routing Component-->>-Cloud Controller: #
  Cloud Controller->>-CCDB: delete
  deactivate CCDB

[x] I have reviewed the contributing guide

[x] I have viewed, signed, and submitted the Contributor License Agreement

[x] I have made this pull request to the main branch

[x] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

If my understanding is correct, the user impact of this change is as such:
Before:

User creates instance or binding
User quickly deletes instance or binding BEFORE initial provision has completed
The record in CCDB gets deleted, and the actual instance or binding is left around.

After:

User creates instance or binding
User quickly deletes instance or binding BEFORE the initial provision has completed
The user gets a 422 in response because the CCNG refused to delete service instances or bindings that are in the process of being provisioned

Do I have that right?
I think that makes sense.  I suppose there could be issues where pipelines or other automation could run into this, and it will look like a new bug to some users.  Probably not a real issue, because that pipeline wouldn't have been concerned with whether or not the provision succeeded in the first place to delete so quickly...

Your summary is correct, with one minor addition: CCNG responds with 422 if the instance or binding is in state 'initial', i.e. the request was not yet accepted by the broker.
If the broker already got the request and processes the creation asynchronously, the user is still able to delete (i.e. cancel) it.

@philippthun that is OK with me


[BUG] Edge install failed (Cannot install msedge on win32)

Our edge pipelines failed last night

Playwright Version: 1.32.0
Operating System: Windows
.NET version: 6
Browser: Edge
Extra: Azure Agent machine

Code Snippet
Code from pipeline Yaml
          - script: 'pwsh playwright.ps1 install --force msedge'
            workingDirectory: '$(System.DefaultWorkingDirectory)\drop\'
            displayName: 'playwright install Edge'

Describe the bug
Last night issue, job is split over 3 agents and all 3 failed to install
Starting: playwright install Edge
==============================================================================
Task         : Command line
Description  : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
Version      : 2.212.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
==============================================================================
Generating script.
Script contents: shell
pwsh playwright.ps1 install --force msedge
========================== Starting Command Output ===========================
"C:\Windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "D:\a\_temp\42144494-d7c1-48ef-a88d-22a2ca555063.cmd""
Failed to install browsers
Error: Cannot install msedge on win32
##[error]Cmd.exe exited with code '1'.
Finishing: playwright install Edge

night before install worked as expected
Starting: playwright install Edge
==============================================================================
Task         : Command line
Description  : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
Version      : 2.212.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
==============================================================================
Generating script.
Script contents: shell
pwsh playwright.ps1 install --force msedge
========================== Starting Command Output ===========================
"C:\Windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "D:\a\_temp\66ccfb19-aacb-445c-bbf5-604543b30828.cmd""
Downloading Microsoft Edge
Installing Microsoft Edge

ProductVersion   FileVersion      FileName
--------------   -----------      --------
112.0.1722.68    112.0.1722.68    C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe

Finishing: playwright install Edge

Is it still failing or was this just a few hours last night? Most likely its caused by temporary issues with Edge's update servers.


training test shows filenotfounderror of benchmark/set5

Running train.py in pycharm, shows filenotfounderror in datasets/benchmark/Set5/...
Readme  says set5 is for test, so is the data needed in training process?
thx

The Set5 dataset is used to verify during training that everything is proceeding normally. It's just for monitoring the training trend of the model and does not participate in model selection.

ok, is there a download link on the cloud drive for mainland?
thx

@Estella12 We have released the download link of Baidu Disk at here.

thx


User should be redirected to intended page on register

Currently AuthenticatesUsers will redirect a user to an "intended" private page if access attempted prior to logging in. RegistersUsers should work the same. Whether a user has an account already or needs to register, they should still both go back to the intended page. Currently RegistersUsers only goes to the user dashboard (or whatever is triggered by RedirectsUsers).

duplicate #16432

I would say that it's up to the developer to decide whether or not to expose private URL's if that's the case. I don't understand what sort of URL would be non-existent if it's being generated/exposed publicly in the first place. Seems like a very rare situation and in that case, wouldn't it be up to the developer to link directly to /register or /login instead (if there is a chance the content doesn't exist)? I'd really like to see a use case for this issue that @taylorotwell refers to. There's no guarantee that the content/page is there either even IF the user account already exists. Case in point:
Guest goes to /businesses/create to create a business page
Guest is prompted to sign in
Guest doesn't have an account so they click on Register
Guest creates user account, then gets redirected to their dashboard page
New user signs out, then clicks on that same link /businesses/create again
New user signs in with account just created
New user actually lands on business creation form like expected

I would say that the issue @taylorotwell is concerned about is just as likely to happen whether the user has an account or is registering for the first time. It's up to the developer to expose the protected URL or not. I would say that if I don't want my users to do a specific user-only task immediately upon sign in, I would simply refer to /login on all my links instead of specific auth-only tasks. That's a developer decision.

No plans on changing this right now.


Implement autodistill-kosmos2

Search before asking

[X] I have searched the Autodistill issues and found no similar feature requests.

Description
Kosmos-2 is a multimodal language model that you can use to detect objects in images.
We would love to make Kosmos-2 a base model so that people can easily use the model!
To learn about contributing a new base model to Autodistill, check out our base model implementation guide and template.
Use case
Zero-shot object detection.
Additional
No response
Are you willing to submit a PR?

[ ] Yes I'd like to help by submitting a PR!

This model is now available at https://github.com/autodistill/autodistill-kosmos-2.


[Target] Replace IsaAnalyzer with Target Features

This is clean up to use the new target.features instead of IsaAnalyzer.

Looks good, but did you mean to commit python/MANIFEST.in?

What do you mean? 🙈


ParsePush.subscribeAsync("") throwing TargetInvocationException on Windows Phone 8

I'm using VS Express for Windows Phone 2012 to develop my Windows Phone 8 apps.
I followed the WP8 quickstart guide and did everything right.
I'm using the latest relaease (1.6.1).
Here is my code:
ParseClient.Initialize("AppKey". "DotNetKey");
await ParsePush.SubscribeAsync("");
await ParseAnalytics.TrackAppOpenedAsync();

Any ideas why it's throwing the Exception?

Can you perhaps post the stack trace of the exception here?

Sure, sorry about that.
_innerException	{Parse.ParseException: Invalid response from server ---> System.ArgumentException: Input JSON was invalid.
   at Parse.Internal.Json.Parse(String input)
   at Parse.Internal.ParseCommandRunner.<>c__DisplayClass2.<RunCommandAsync>b__1(Task`1 t)
   --- End of inner exception stack trace ---
   at Parse.Internal.ParseCommandRunner.<>c__DisplayClass2.<RunCommandAsync>b__1(Task`1 t)
   at Parse.Internal.InternalExtensions.<>c__DisplayClass1`2.<OnSuccess>b__0(Task t)
   at Parse.Internal.InternalExtensions.<>c__DisplayClass7`1.<OnSuccess>b__6(Task t)
   at System.Threading.Tasks.ContinuationResultTaskFromTask`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Parse.Internal.InternalExtensions.<>c__DisplayClass7`1.<OnSuccess>b__6(Task t)
   at System.Threading.Tasks.ContinuationResultTaskFromTask`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Parse.Internal.InternalExtensions.<>c__DisplayClass7`1.<OnSuccess>b__6(Task t)
   at System.Threading.Tasks.ContinuationResultTaskFromTask`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at SRLib.LauncherPage.<RegisterForPushNotifications>d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<ThrowAsync>b__3(Object state)}	System.Exception {Parse.ParseException}

@richardjrossiii Still not able to use parse in WP8.
Any news here?
Thanks in advance

@richardjrossiii I'm experiencing the same issue. Can you provide a workaround for this? Seems this has also gone unanswered here; https://parse.com/questions/unable-to-push-notifications-to-wp8-through-the-dashboard

@hhartz @richardjrossiii
In Lumia 520 with WP 8.1, it crashes.
In Lumia 530 with WP 8.1, it doesn't crash but the notifications don't arrive in the device.

Closing as out of date.


Events at 00:00 UTC need to be investigated

Describe the bug
At v1.3.0 release, I observed End of Civil Twilight not working. The problem seemed to go away when the day changed from April 19 to April 20. On the 19th, the end of twilight was 00:00 UTC. This should be investigated.
https://aa.usno.navy.mil/api/rstt/oneday?ID=gt_trigr&date=2023-4-19&coords=42,-71.5&tz=0

{
"apiversion": "4.0.1",
"geometry": {
"coordinates": [
-71.5,
42.0
],
"type": "Point"
},
"properties": {
"data": {
"closestphase": {
"day": 20,
"month": 4,
"phase": "New Moon",
"time": "04:12",
"year": 2023
},
"curphase": "Waning Crescent",
"day": 19,
"day_of_week": "Wednesday",
"fracillum": "1%",
"isdst": false,
"label": null,
"month": 4,
"moondata": [
{
"phen": "Rise",
"time": "09:48"
},
{
"phen": "Upper Transit",
"time": "16:23"
},
{
"phen": "Set",
"time": "23:11"
}
],
"sundata": [
{
"phen": "End Civil Twilight",
"time": "00:00"
},
{
"phen": "Begin Civil Twilight",
"time": "09:30"
},
{
"phen": "Rise",
"time": "10:00"
},
{
"phen": "Upper Transit",
"time": "16:45"
},
{
"phen": "Set",
"time": "23:31"
}
],
"tz": 0.0,
"year": 2023
}
},
"type": "Feature"
}

Forced 00:00 for various events and observed no issues with/without offsets.


how to visualize the results using my model

how to visualize the results using my model not using the model online

Hi! I have a very rough file I use internally. I may help you in a direction. It is possible to visualise predictions, labels (with score) and GT boxes, from a given annotationfile. I do not have time to clean it up. https://gist.github.com/JacobBITLABS/8ec7de95d693d9ae8044d3d0a5123302


Document how to make sure a job lands on a specific node selector

Toleration + node selector

broader "Getting Started" docs should have a path that points a user to these more complex workflows


!!

Describe the bug

To Reproduce

Expected behavior

Screenshots

Applicable Versions:

Netlify CMS version: [e.g. 2.0.4]
Git provider: [e.g. GitHub, BitBucket]
OS: [e.g. Windows 7]
Browser version [e.g. chrome 22, safari 11]

Node.JS version:

CMS configuration

Additional context

Hi @ab180-wontakkim can you share some more information on the issue you're experiencing?

@erezrokah Oh sorry 'Netlify' directly guided to here when it crashed. I even didn't realize that I created ticket. I couldn't check what was issue so you can ignore this ticket.
Thanks for your help though


Update aws-core, http-client-spi, ... to 2.17.47

Updates

software.amazon.awssdk:aws-core
software.amazon.awssdk:http-client-spi
software.amazon.awssdk:netty-nio-client

from 2.17.42 to 2.17.47.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, semver-patch

Superseded by #543.


Color of disabled and/or not in task blocks is sometimes missing

When working with disabled blocks, e.g. copying or simply any server interaction, the color of the block disappears. Further the handling during and after using the simulation or debug simulation leads to wrong opacity and/or color. Some examples:
block disabled, initial ok

after opening code view, not ok

after leaving focus, not ok

block not in task, initial ok

after opening and closing debug mode, not ok

Tested. Issue solved.


Return appropriate http response codes

Description
From what I can tell the response code for all requests is set to 200 even for calls that hit rate limits, according to this comment the graph node expects a NOT OK(specifically 429) response code to retry a call that hit a rate limit.
I'm not sure if there's a spec that defines all response codes, but last I checked the eth json rpc spec doesn't have this detail.
Steps to reproduce

Observe that a 200 ok response is returned for json rpc calls that "reverted" due to the rate limit.

Additional context
No response
Hedera network
other
Version
<EMAIL_ADDRESS>Operating system
None

IMO, in general the graph should not be rate limited, even if the appropriate response code is returned, there's a retry limit anyways, so there's the possibility of blocks/data being skipped.

@dimitrovmaksim do you know what happens once the retry limit is reached?
Also it's got more to do with an event handler making an eth_call request and the hedera relay returning a call "revert" response instead of a rate limit response.

For consuming blocks at least it think it skips the block after 10 or 15 retries

@dimitrovmaksim hmm, does it ever try to recover and reconstruct subgraphs on the skipped blocks. It doesn't make much sense that it would skip blocks and consume later blocks that may only make sense given txs in previous skipped blocks.

Tbf it's hard to track all that is happening with the logs spam. Will have to test it again somehow. I may be wrong for the skipping, I may be confusing with fetching the transaction receipt


[Review] VasudevJaiswal

GitHub Profile Link
https://github.com/VasudevJaiswal

Nice profile! I liked it a lot. I have made a pull request in your README profile repository for some minor improvements. 🙂
Thank you for sharing your awesome profile with the community! 😄

Duplicate Information on your profile:

(last links on your profile)

YouTube review

YouTube review link

What do you mean by this?

YouTube review link

I think they meant where will it be reviewed on youtube @schmelto
https://www.youtube.com/user/eddiejaoude it'll be reviewed on this channel when Eddie does the live stream for reviews, press the bell icon and subscribe to get notified @VasudevJaiswal

@schmelto  Yes you understand what i want to say 😊

Requested Changes 😉

[ ] What's the GitHub icon above the about me section?
[ ] Too many <br>/whitespace
[ ]  if you like what i do, maybe consider buying me a coffee/tea 🥺👉👈 can be plain text (to save space)

Feedback

[x] I personally like the sophisticated, minimal, and informative design ❤
[x] It is pretty informative and cool 😍
[x] You are a part of the EddieHub Org 🤩

Copy This Checklist Paste It Into An Comment Then Keep It Updated With Your Workflow. I will update mine once I see your checklist is updated 😃

Nice profile! It's great to see that you've put your coding profile URLs as well, along with the social ones. Let's connect on Twitter.

User blocked from Org


Fixing issues with Mixture-based act()

Description
This PR fixes the issues we were having with the mixture-based activation functions for the LSTM layer.
Changes Made
The changes made are simple; take max(1E-6, var_a) for the mixture_sigmoid and mixture_tanh activation functions.
Note for Reviewers
I diagnosed the issue by first benchmarking the ReLU vs. MixtureReLU, Sigmoid vs. MixtureSigmoid &  Tanh vs. MixtureTanh on the MNIST dataset using FNN and CNN architectures. The bottomline is that ReLU outperforms MixtureReLU but MixtureSigmoid & MixtureTanh outperform their locally linearized counterpart. In no case there was any numerical errors while running the classification setup.
When running on time series with the LSTM architecture, I realized that the nan values occurred only when both the candidate and input gates were using mixture-based activation functions. By imposing a minimum value of 1E-6 for the variance of the mixture sigmoid and tanh gates, we fix the issue without affecting the performance on either the LSTM nor on the classification.
I did not change the activation function for the LSTM layer in this PR as we will first go through an extensive benchmark to decide which of the locally linearized or the mixture-based perform better. This fix should enable to go forward with the remax for the attention mechanism.

@lhnguyen102 I forgot to modify the GPU code. I will do it and reopen it.


Support more EVM networks

After https://github.com/fractal-framework/fractal-contracts/issues/70 is done, support them in the webapp

No longer applies


Consistent and simple ./out directory structure

Describe The Problem To Be Solved
The ./out directory is currently complex to understand. The output of a build process is typically the input for post-processing the images which could be Flash-Programming, Signature-Tool, Cloud-based OTA service, etc.  A default setting for the ./out directory should be therefore simple and consistent across the tools.
Proposed structure for multi-core projects (exemplified with csolution-examples/DualCore)
./Hello.csoution.yml                                     // location of csolution.yml is the base directory for ./out
./out/FRDM-K32L3A6/HelloWorld_cm0plus.axf
./out/FRDM-K32L3A6/HelloWorld_cm0plus.axf.map
./out/FRDM-K32L3A6/HelloWorld_cm0plus.bin
./out/FRDM-K32L3A6/HelloWorld_cm0plus.hex
./out/FRDM-K32L3A6/HelloWorld_cm4.axf
./out/FRDM-K32L3A6/HelloWorld_cm4.axf.map
./out/FRDM-K32L3A6/HelloWorld_cm4.bin
./out/FRDM-K32L3A6/HelloWorld_cm4.hex

In a nutshell, all output artifacts of a target are in the same directory. Each *.cproject.yml file has a project name which is used as output name.

NOTE: The build-type is not part of the directory naming, as it would otherwise require to adjust post-processing steps for each different build-type. Build-types are used to create test, debug, and release builds depending on the need of a project. In many cases there might be different build-types used during development, i.e. the tools should make it easy to mix a HelloWorld_cm4 release build with a HelloWorld_cm0plus debug or test build.

NOTE: This proposal requires to review the output: node.

The toolchain should get command line options to change the ./out directory structure when required. For example:
--out-dir t/b/c could generate a directory structure with <target-type>/<build-type>/<compiler-name> .

One thing to consider here is that post-processing tools can (should?) use the output node in the generated cbuild.yml files to locate the output binaries. See the discussion here: https://github.com/Open-CMSIS-Pack/devtools/issues/778. This is how the Csolution extension locates binaries.
That means the tools don't need to understand how the output and output-dirs nodes are processed by the build tools, and tools don't need to care if the out directory has a complex structure.
However, I think a simpler output directory structure could help the user to understand what is going on, if we can still support all of the use cases.

Matt is there a description of the default behavior of the Csolution extension.  Does this consider multi-project solutions?

I'm worried about the number of potential file conflicts behind .o and CMakeLists.txt etc if all output files are in the same folder.
On the two points:
out directory is complex - I don't really agree. Separating build output per project context really makes it less complex IMO since I can easily connect the dots of where something ends up.
Post-processing tools should find the elf files - This is a problem indeed, but I agree with @mcgordonite , it could be solved by the output property recorded in the cbuild.yml. If post-processing tools are run as a post-build-step we could consider modifying or adding a new access sequence e.g. $CurrentOutputFile(elf)$ that would expand to the file path for the elf file (in the current context) and could be passed as a parameter to any post build script (or use the existing $Output($BuildType$$TargetType$)$).
New point:
Finding import library for trustzone - On this, instead of guessing the import file name, I suggest again that a access sequence should be used here

@slhultgren there is no change to the .tmp directory that holds all the artifacts that you describe above (.o, CMakeLists.txt, etc.).  So the build process itself has separate directories for each build and target type.
The output-dirs: control is today already flexible enough to configure the out directory the way described. All that is needed is:
  output-dirs:
    outdir: ./out/$TargetType$/

So you can experiment with it.

Examples in this https://github.com/Open-CMSIS-Pack/csolution-examples/pull/10/files are not configured this way.

Replaced by context-set discussion


TODO: Treat Excluded Elements Closed by /> as Completed

For example, in Blogger XML tags, someone can write external

Result after parsed by HTML.singleQuote(string):

The code above assumes that a JavaScript code starts from line 1 and end in line 6:
+
-

-
-
-


Update installation instruction

Fixes #566.
Signed-off-by: Ahmet Alp Balkan<EMAIL_ADDRESS>

cool, thanks!


Article's  tag is generated with  closing even it is a void element

The HtmlHelperExtensions.AssetImage method builds an img tag which than renders as

The img tag is a void element. So it should be rendered as just  (HTML5, HTML) or self-closed  (HTML5, XHTML).
I suggest to add one of the following lines just before the return image; statement to fix this.
image.TagRenderMode = TagRenderMode.SelfClosing; // XHTML-like
image.TagRenderMode = TagRenderMode.StartTag; // HTML-like

I'd go with SelfClosing

As you have mentioned:

Void elements only have a start tag; end tags must not be specified for void elements.

I would also vote for self-enclosing since Images on the sample MVC image widget for EMS also use a self-closing tag.

Fully busy now, hopefully in a month or so.


Adding Code Climate badge to readme

The badges have been updated to the flat design to match the Travis badges. Wondering if there is anything else you would like updated on this PR?


Add methods for sideloading vertices and disabling dynamic assembly loading

This pull request adds support for disabling dynamic assembly loading and for "sideloading" vertices by initializing a Vertex object and passing it into the CRA Worker directly. These changes are motivated by the constraints of two different programming environments:
Universal Windows Platform: UWP apps cannot load assemblies dynamically at runtime. The sideloading interface provides an alternate means of initializing vertices.
.NET Core on Linux: Unlike UWP, .NET Core on Linux allows dynamically loading assemblies, but problems arise when one CRA Worker overwrites the assemblies that an already-running CRA Worker has dynamically loaded. The ability to explicitly disable dynamic assembly loading was added to support .NET Core on Linux.
Each of the two added features (sideloading vertices and disabling dynamic assembly loading) is designed so that it does not interfere with the normal-case usage of CRA. To access these features, developers simply call additional methods before running CRAWorker.Start().
This PR also adds a .NET Standard 2.0 target to CRA.ClientLibrary, since a .NET Standard build is required for UWP development, and CRA is completely .NET Standard-compliant anyways.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: nlebeck sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Implementing groups to tweet for different issues

#21 @UserStefan: "Implementing groups to tweet for different issues (it is unsorted, need some more structure for better overview. also i would like to stream my own trip)."

How is this supposed to work?

You post a status and it is displayed in a specific group/ressort. Lets say we have DTSG Race, so people in the race post in DTSG Race group/ressort. Or we have OnMyWayToHitchgathering group, so people on their way to hitchgathering post there status in this group.
If we have this, we also can display only this group-ticker on a certain place/homepage. Makes it nice to play with it. Like on Hitchwiki "People are actually going to the Hitchgathering, follow us on our journey." or "This is my personal Hitchticker which gives you short updates, where i am and what i am doing."

My idea is: When we have this feature, people might be more tempted to use the ticker in a creative way, play with it and have fun to ticker messages. This is a very basic idea, to make the thing living and not just being a dead application, that nobody cares about. I think tickers are a very funny thing and can make hitchhiking trips become exciting for the public.
If we have this, we can also call for ticker-gatherings and ask people to submit a tweet for a certain topic (like ticker here for some outstanding act of kidness, that you received by your driver). [Sorry, i am just writing some ideas down, which i would include in the hitchwiki article for giving some inspiration about how to use this thing and make people engage]. We also can have a "FAQ-Ticker" for short question and answering. Or an "Hitchwiki progress ticker". Whatever comes up. Whatever makes sense. Whatever people want.
It is like Twitter, but only for hitchhikers and nomads, much more basic and Open Source (which is most important. Non-Profit, ideologically clean and IF we can engage enough people, it exsts the potential to make something special out of it. Something funny, where we like to have a look into.)

Maybe something like using hashtags during specific events and have the ability to sort on the website by hashtag ( e.g. hitchticker.org/dtsg/,  hitchticker.org/hitchgathering/,) and so on?
Would require participants to use that tag for each message, though.

+1
Simple thing which can be used in sooo many ways.

Yes, hashtags were my first thought as well, just didn't want to push in that direction :)

Then go. Push more pls. We need to bring it to a point now, where we can kinda close the first develompent stage.

Hastags are already in? Can we close this?
is it working like hitchticker.info/hitchgathering/ for #hitchgatherng?


Monk Create Index Documentation

While doing this:
users.index({"username": 1}, {unique: true});
I get a deprecation notice like this:
DEPRECATED (collection.ensureIndex): use collection.createIndex instead (see https://Automattic.github.io/monk/docs/collection/createIndex.html)
But on the documentation page ie https://Automattic.github.io/monk/docs/collection/createIndex.html, no such warning is listed. So I guess documentation needs a update about deprecation?

Unfortunately, it also returns a promise now.

@ndabAP  Yeah, let me make the necessary changes and make a pull request.
Sorry I am late with my reply, was busy with other projects.


[FEATURE] Warns, mutes, etc should allow to include a message for context

Is your feature request related to a problem? Please describe.
sending out warns for specific messages tends to be somewhat anoying, as concrete context is often missing.
Proposed feature
when including message links in warns, mutes, etc, the respective message should be fetched and included in the database entry, and somehow included in the !notes output.
One way to implement this could be to copy over the linked message into a #context channel or just modlog automatically (in an embed) and then including a link to that message in the notes entry.
Additional context

ill try this uwu


Channel selection breaks when segmentation mask without obs is present

The selection of specific channels does not work if the xarray object contains a segmentation mask but no obs.
# works
sd_1 = spatial_data.load_image_data(image, channel_coords=markers).pp["DAPI"]
print(sd_1)
# doesn't work (KeyError: '_obs')
sd_2 = spatial_data.load_image_data(image, channel_coords=markers).pp.add_segmentation(segmentation).pp["DAPI"]
print(sd_2)
# temporary workaround
sd_3 = spatial_data.load_image_data(image, channel_coords=markers).pp.add_segmentation(segmentation).pp.add_observations().pp["DAPI"]
print(sd_3)

A workaround would be to always add obs when a segmentation mask is added. Ideally, the presence of cells should not interfere with the channel selection in any way.

Yes true, should be an easy fix. I'll take care of that.


Be able to manage machines/nodes with a single file instead of two

Currently we handle the general case where multiple nodes can share a machine, but in fact many service instances don't require this. For them it's painful to have to manage machines/nodes in two separate files.
Instead the importer should support a way of importing both from a single file. Or else Seiso should be able to automatically create machines from the nodes. Either might work.
Requested by Randy McCoy, Mike Nash

Related: issue #9


Added support for multiple parameter dictionaries

I did some testing and it seemed to work fine, but the table needs some more testing with modifying saved states.

@cohansen I am running into a gql error message on parce edit
Error: field 'id' not found in type: 'parcel_to_parameter_dictionary'
at reqHasura (requests.ts:159:11)
at async Object.createParcelToParameterDictionaries (effects.ts:877:20)
at async saveParcelToParameterDictionaries (ParcelForm.svelte:269:54)


docs(architecture): proofread, updated Dart app

Note that there are two commits: one for each of TS- and Dart-side changes.

e2e tests now also cover the tax calculator.
Dart app updated to match TS (it had no sales tax calculator).
TS sample source cleanup (e.g. removed many unnecessary docregions).
Prose updated to include @kwalrath's revisions from a while ago, with some of my edits as well.

Contributes to #1598 and #1508.

@kwalrath @thso : Dart-side commit ready for review.
@Foxandxss @wardbell : TS-side commit ready for review. As usual, it is best to review the .jade file while ignoring changes in indentation. Note that most of the TS Jade file edits were from Kathy's work from a while back.

Looking good! Once you address a few comments, the Dart side is good to go.

Dart-side issues addressed.

LGTM! @Foxandxss or @wardbell, who's going to review the TS side?

@Foxandxss : please see my response to your line comment. Otherwise, are we good to go on this one?

Please update ts/architecture.jade as follows:
line 84: "Look inside such a file and we'll see a declaration such as this one."
line 384: "They tend to appear within an element tag as attributes do,"

I am uncomfortable with certain changes in the e2e tests, most especially the tests-that-are-not-tests such as
  it(`selects ${targetHero.name} from hero list`, function () {
    let hero = element(by.cssContainingText('li', targetHero.name));
    hero.click();
    // Nothing specific to expect other than lack of exceptions.
  });

and
  it(`can update hero name`, () => {
    addToHeroName(nameSuffix);
    // Nothing specific to expect other than lack of exceptions.
  });

The second is also not accepted because it delegates to addToHeroName, a helper function that is used exactly ONCE, in this place only. That move detracts from readability and maintenance w/o compensating benefits.
I think I know why you created these tests; they are a clever way to slip in an async operation w/o waiting for it. But they depend upon test order which test suites should not do. Move one of these tests and the suite fails.
I realize that a great number of our e2e tests have this failing (when you see beforeAll loading the browser just once, you can guess that cross-test pollution is a likely risk). I accept that to make these tests faster. But I don't accept splitting what is actually ONE test over two tests in order to avoid the async setup operation.  Please think of a better way.

Unfortunately, this PR is NOT based on an IdeaBlade branch. That means I can't fix it.
You and Kathy have the ability to add branches to ideablade/angular.io.
Please base all future PRs on branches in  ideablade/angular.io or at least all future branches that involve this many changes.

@wardbell : thanks for the feedback. I believe that all of your concerns have been addressed in the last commit (https://github.com/angular/angular.io/pull/1807/commits/f38496f1a11831da67d772bb7ab2d1766830fe25). Let me know if there is anything else.

Thanks. Merging.


Inherit stdio when opening the editor

Fixes #3.  Hopefully, this doesn’t break anything for you.  But as this is the same as spawn_editor does when spawning an editor, I’m quite confident that it is correct.

Sweet, thanks for investigating and fixing


Guzzle Issue

graze/guzzle-jsonrpc[3.0.0, ..., 3.2.1] require guzzlehttp/guzzle ^6.0 -> found guzzlehttp/guzzle[6.0.0, ..., 6.5.x-dev] but it conflicts with your root composer.json require (^7.0.1).
- digitaldonkey/ethereum-php dev-master requires graze/guzzle-jsonrpc ~3.0 -> satisfiable by graze/guzzle-jsonrpc[3.0.0, 3.1.0, 3.2.0, 3.2.1].
- Root composer.json requires digitaldonkey/ethereum-php 9999999-dev -> satisfiable by digitaldonkey/ethereum-php[].

Can you add support guzzlehttp/guzzle ^7.0 please ?


Internal refactor

This is a collector of all ideas/issues we would like to fix in sylvia internals that are not API breaking.
Issues

[ ] #288

In https://github.com/CosmWasm/sylvia/pull/282 and https://github.com/CosmWasm/sylvia/pull/283 we started a discussion regarding:

moving all querier-related implementation to module querier
moving all remote-related implementation to module remote
moving all multitest-related implementation to module multitest
avoid using AddSelfPath  and similar structures in favor of a better model generated by the parser


Introduce workspaces

Workspaces allow jobs within a build to share files from one stage to the next.

Depends on

travis-ci/casher#46
travis-ci/travis-scheduler#189

@BanzaiMan are the PRs for casher and scheduler backwards compatible? eg. should we get those merged and deployed?
Also, do you have a build on staging to demo this on?
Annnnnd are we using the Travis repo ID or GitHub ID in the urls?

casher PR is backward compatible, so it hasn't been tested that way.
scheduler PR is; if the config setting doesn't exist, it'll just be ignored.
Neither Travis repo ID nor GitHub ID is used; just the build ID.

Needs travis-yml work to correspond to the change.

@BanzaiMan lets have a call/catchup on Monday about the next steps to getting this merged and more widely tested

travis-ci/casher#46 in production → https://travis-ci.org/BanzaiMan/travis_production_test/builds/549861457 (backwards compat)


Provider auth on all platforms

Im pretty tired at this point.
I updated to one of the dev versions and made it work again, it was straight forward (except my other issue on windows: https://github.com/supabase-community/supabase-flutter/issues/239).
After the update to 1.0.1 no platform works except on my live version because Im still using the dart implementation and package there. Looks like my Google Oauth configuration is correct.
I checked multiple official documentations at multiple places and I can't find the issue...

await Supabase.initialize(
    url: EnvironmentHelper.supabaseUrl,
    anonKey: EnvironmentHelper.supabaseKey,
    authCallbackUrlHostname: 'callback',
    localStorage: const CustomHiveLocalStorage(),
  );

<intent-filter>
      <action android:name="android.intent.action.VIEW" />
      <category android:name="android.intent.category.DEFAULT" />
      <category android:name="android.intent.category.BROWSABLE" />
      <data android:scheme="com.sesa.cryptowulf.dev" android:host="callback" />
</intent-filter>

@override
  Future<bool> signInWithGoogle() async {
    return await _supabaseClientService.get().auth.signInWithOAuth(
          Provider.google,
          redirectTo:
              'com.sesa.cryptowulf.${EnvironmentHelper.envName}://callback',
        );
  }

It looks like everything is fine If I watch the auth logs but the redirect back does not work. The browser wants to Redirect to localhost:3000.

@Sesa1988
So that issue is that with the most recent version of supabase-flutter, specifying redirectTo does not change the redirect URL, correct?

except on my live version because Im still using the dart implementation and package there

What version of supabase-dart are you using for this one?

@Sesa1988
So that issue is that with the most recent version of supabase-flutter, specifying redirectTo does not change the redirect URL, correct?

except on my live version because Im still using the dart implementation and package there

What version of supabase-dart are you using for this one?

Its looks like it, the browser should connect to my specified URL and not localhost or?
Yes its on the latest one and I was using the latest dart package for supabase.

@Sesa1988
Within the project that is not working properly, could you open pubspec.lock and see what version of gotrue is being used?

There was an issue with gotrue v1.0.1 with redirect. If the version you are using is not v1.0.2, could you delete your pubspec.lock file and rerun pub get?

(Or to not update other packages, run dart pub upgrade gotrue. This should do the trick as well, but verify in pubspec.lock as Tyler said.)

Okay thanks I will try that.
First I thought its maybe because of my forked versions for the Windows implementation at the other issue but this should not be in any relation.
I will update the other issue with my new findings.

@Vinzent03 Thanks for sharing that trick! I keep forgetting that one 😂
@Sesa1988
Thanks for bearing with us!

It looks like Im already using the 1.0.2 version.
gotrue:
    dependency: transitive
    description:
      name: gotrue
      url: "https://pub.dartlang.org"
    source: hosted
    version: "1.0.2"

@Sesa1988
So sorry there. Found a bug in the code. Fixing it right now!

@Sesa1988
So sorry there. Found a bug in the code. Fixing it right now!

Thanks a lot! :)

@Sesa1988 Redirect issue should fixed now!

@Sesa1988 Redirect issue should fixed now!

I tested google auth and it works now on Android, iOS, and macOS.


A GlideElement of type GlideElementVariables will not display in output pane (for non-SCTask/RITM records)

If you attempt to view the output for a variable field belonging to a record that is not on the sc_task/sc_req_item table, Xplore will fail to display the result in the output pane and instead appears to load forever:

In the above pictured case, the variables were associated to the record by way of Record Producer.
Worth noting: despite the preview not working for the field itself, it is still possible to view individual variables in the output by dotwalking to them:

Interesting. Please can you try using Xplore 4.8 and see if you get the same thing?
P.S. Would you be happy to share your theme?

Will do that soon-ish when I get a moment alone with the instance.
By the way, I'm actually using Chromium's dark mode switches (via configuration options exposed in Qutebrowser), not a dedicated theme. All the colors you see here are just HSL rotations of the default theme
In any case, here's the color codes, just in case they may offer any inspriation:

Element
Color

BG
#121212

Accent BG
#212121

Light BG
#28282A

Error BG
#3B2C2D

Warn BG
#232111

Info BG
#1D2E35

Green BG
#202D1C

FG
#DFDFDF

Accent FG
#CCCCCC

Dark FG
#B5B5B5

Gutter FG
#999999

Error FG
#EF827B

Warn FG
#B0905C

Info FG
#AFB3B5

Green FG
#689D64

Comment FG
#DF8231

Keyword FG
#FFA1FF

Parameter FG
#DCA1FF

Variable FG
#8CB6FF

Number Literal FG
#73C199

String Literal FG
#FF8263

Other Literal FG
#FDCBFF

Green Button
#5CB85C

Red Button
#D9534F

Link
#5999D8

I finally got around to testing this. The issue seems to be fixed! I upgraded directly to 4.9, so I'm not sure if the issue was fixed in the prior release or current release.


Linting errors mitigated

Task: task-[work-item-number]
Link: preview
[Explain the context of this pull request here]
Testing

Step one
Step two
Expected result:

Additional information
[Optional]
Contributor checklist

[ ] Did you update the description of this pull request with a review link and test steps?
[ ] Did you submit a changeset? Changesets are required for all code changes.
[ ] Does your pull request implement complex UI logic (js/ts)? Consider adding an integration test to test your user flow.
[ ] Does your pull request add a new page to the documentation site? Add your new page for automated accessibility testing in /integration/tests/accessibility.

@AaronAstle Could you please add a changeset?


Intialization of Metric Reporter

Description:
Current handler impl initialize the MetricReporter only when a request is made. But we need it to be intialialized at the server start up to make sure that any problems with the configurations are noticed and handled before traffic reaches the instance.

@ruks We need to start work on this

ACK


Incorrectly use raises annotations

Presently procedures are annotated raises: [SomeDefect] this causes warnings cause raise is only meant for CatchableErrors there is no Defect tracking.

I'm surprised that there's no Defect tracking. I'll figure this out a bit later, wish I saw this before making the last release.

You could tag your procs with your own Defective then on any consuming modules push forbids: [Defective], but yea that aside there is nothing.


Why don't authors use popular libraries like Llamaindex, Langchain?

Hello,
I've read the first few chapters of the book and paused at the data processing section because I was curious why the author chose not to use libraries like LlamaIndex or LangChain.
I'm asking because these libraries seem to offer many tools that are similar to the modules the author explains how to build.
Thanks!

Hello,
The book's scope is to teach you how to build these components and how they work under the hood, not to provide you with one-liners that only scratch the surface.


Error installing nugrant 2.1.2 with vagrant 1.8.1

Hi everybody.
I'm trying a manual install of nugrant 2.1.2 on windows, with a vagrant plugin install nugrant-2.1.2.gem and I have this error:
C:/HashiCorp/Vagrant/embedded/lib/ruby/2.2.0/rubygems/package.rb:522:in `rescue in verify': No such file or directory @ rb_sysopen - nugrant-2.1.2.gem (Gem::Package::FormatError)```

I tried with an older version of Vagrant (1.7.4) and it works.

I saw that Vagrant 1.7.4 run with Ruby 2.0.0 instead of Vagrant 1.8.1 who use Ruby 2.2.0
Is it possible that Ruby has broke the thing?

Thanks

Quite possible. Thanks for the report, I will check this out over the weekend and ensure Nugrant works with Vagrant 1.8+.
Will keep you posted.

Hi,
I just tested Nugrant 2.1.2 with Vagrant 1.8.1 and it installed successfully. I then re-read your post and realized you are doing a manual install. Should have caught this earlier.
From what I read, you are not doing it correctly. Either you do not really want a "manual" installation in such case you should drop the version and the .gem suffix: vagrant plugin install nugrant to get the latest (or for a specific version vagrant plugin install nugrant -v 2.1.0).
Or, you really want a manual installation in which case, you are not specifying the location to the gem file correctly. The error message is saying so: No such file or directory @ rb_sysopen - nugrant-2.1.2.gem
But you also say that it works when you tried with Vagrant 1.7.4. Is it possible you did not run the exact same command.
Here what I tried to reproduce below. Closing for now. Feel free to re-open if you still think it's a bug. In which case, please provide the exact same steps as below but with your own results so I can investigate further.
Best regards,
Matt
Matt@WORKSTATION ~
$ vagrant -v
Vagrant 1.8.1

Matt@WORKSTATION ~
$ ruby -v
ruby 2.2.3p173 (2015-08-18 revision 51636) [i386-mingw32]

Matt@WORKSTATION ~
$ bundle -v
Bundler version 1.10.6

Matt@WORKSTATION ~
$ mkdir -p /tmp/nugrant-issue-30

Matt@WORKSTATION /tmp
$ cd /tmp/nugrant-issue-30

Matt@WORKSTATION /tmp/nugrant-issue-30
$ git clone https://github.com/maoueh/nugrant.git
Cloning into 'nugrant'...

Matt@WORKSTATION /tmp/nugrant-issue-30
$ cd nugrant/

Matt@WORKSTATION /tmp/nugrant-issue-30/nugrant (master)
$ git checkout -b nugrant-2.1.2 v2.1.2
Switched to a new branch 'nugrant-2.1.2'

Matt@WORKSTATION /tmp/nugrant-issue-30/nugrant (nugrant-2.1.2)
$ bundle install
[Redacted]
Use `bundle show [gemname]` to see where a bundled gem is installed.

Matt@WORKSTATION /tmp/nugrant-issue-30/nugrant (nugrant-2.1.2)
$ rake build
nugrant 2.1.2 built to pkg/nugrant-2.1.2.gem.

Matt@WORKSTATION /tmp/nugrant-issue-30/nugrant (nugrant-2.1.2)
$ vagrant plugin install pkg/nugrant-2.1.2.gem
Installing the 'pkg/nugrant-2.1.2.gem' plugin. This can take a few minutes...
Installed the plugin 'nugrant (2.1.2)'!


update to newer version, see what has changed

I have to move some files into newly created functions first to move them


Drop ruby 2.1

Ruby 2.1 has been deprecated, so drop it from the supported ruby versions.

Maybe a little bit early?

Coverage remained the same at 100.0% when pulling f1270e796eae880978e76fa32c9d0821804242d6 on drop-ruby-2.1 into 3dfa27dd1caaaf827e9f90c273c14abff0e1acb8 on master.

Coverage remained the same at 100.0% when pulling f1270e796eae880978e76fa32c9d0821804242d6 on drop-ruby-2.1 into 3dfa27dd1caaaf827e9f90c273c14abff0e1acb8 on master.

Coverage remained the same at 100.0% when pulling f1270e796eae880978e76fa32c9d0821804242d6 on drop-ruby-2.1 into 3dfa27dd1caaaf827e9f90c273c14abff0e1acb8 on master.

Coverage remained the same at 100.0% when pulling f1270e796eae880978e76fa32c9d0821804242d6 on drop-ruby-2.1 into 3dfa27dd1caaaf827e9f90c273c14abff0e1acb8 on master.

Coverage remained the same at 100.0% when pulling f1270e796eae880978e76fa32c9d0821804242d6 on drop-ruby-2.1 into 3dfa27dd1caaaf827e9f90c273c14abff0e1acb8 on master.

Coverage remained the same at 100.0% when pulling f1270e796eae880978e76fa32c9d0821804242d6 on drop-ruby-2.1 into 3dfa27dd1caaaf827e9f90c273c14abff0e1acb8 on master.


Historic data is 1 week behind

Hello, thanks for your amazing API.
The historic data for any country seems to be one week behind real time, for eg for India the api as of today (22nd April) shows 17th April as the latest date and the same is true for any other country

Hey @Mativve, the issue was with the API. Sorry for the late response. The issue has been resolved
There's a sync job that fails at times. I'm planning to move this to a better server to improve the reliability.


[Event QR] add button for create QR in QR submenu

Add a button to create a QR-Check-In code in the "Check-In" submenu.
Current Implementation

Currently the button to create a QR code only exists on the main page and the users are unable to create a QR code from the "Check-In" submenu. This is against the expected behaviour of the application.
Suggested Enhancement

Add a button or an entry to create a code in the submenu of the "Check-In" page.
Expected Benefits

better UX, closer to an expected behaviour of the app

Hey @nilsriesenberg 👋
Thank you for your contribution here!
This is closely related to the issue #469 "Remove event tile on main screen" which asks to bundle all features of the event-registration in one place.
If you also think that your suggestion is already covered in #469, I'd ask you to close this issue, monitor #469 and if necessary to comment there.
Thank you & stay safe!

@Ein-Tim Thanks i was not aware of this issue being already existent. The searchfunction did not lead me to it.
Closed Issue #495 and moved suggesstions to #469.
https://github.com/corona-warn-app/cwa-wishlist/issues/469#issuecomment-831435870

@nilsriesenberg @Ein-Tim Thanks.

Corona-Warn-App Open Source Team


README.md: Add merge chance badge

Motivation for this change
It's a cool little badge that might convince people to contribute to Nixpkgs. The numbers seem a little skewed but I checked the beta version that filters out top contributors and they're similar ( 98.65% / 0.24 days). And the data looks fine.
The only real risk is that the badge's website might die, but the README has had many badges come and go.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I would put it next to the other badges.

I would put it next to the other badges.

OK, moved it to the top.

OK, moved it to the top.

AFAICS there is currently only 74 PRs taken into account in the data, this is hardly representative of the current ~90000 PR. Will the data size increase over time?
I'm happy if those numbers reflect a reality for some of us, but as far as I'm concerned, for the past two years of my monthly contributions I have not experienced such high "Merge Chance" near that 0.24 days median, except for trivial PRs bumping a minor version or following up a previous big PR whose merge revealed bugs.
Also this badge only counts "PRs made by outsiders (not owners/members)", but in Nixpkgs being a member happened easily and rapidly for me (I was requested to add my name to the maintainers list to get my PR merged), yet it has only given me rights to add tags (after having enabled 2FA), but no rights to merge or else (and as a matter of fact my PRs still remain many months reviewed and validated but not merged).
All this to say, it's great to have such metric, but it would be greater (and more meaningful) if we could have them for more PRs and also for members. Please don't feel obliged or blocked by my request, I don't know if it is an easy task or not to do, it's just a (naive) wish.

AFAICS there is currently only 74 PRs taken into account in the data, this is hardly representative of the current ~90000 PR. Will the data size increase over time?
I'm happy if those numbers reflect a reality for some of us, but as far as I'm concerned, for the past two years of my monthly contributions I have not experienced such high "Merge Chance" near that 0.24 days median, except for trivial PRs bumping a minor version or following up a previous big PR whose merge revealed bugs.
Also this badge only counts "PRs made by outsiders (not owners/members)", but in Nixpkgs being a member happened easily and rapidly for me (I was requested to add my name to the maintainers list to get my PR merged), yet it has only given me rights to add tags (after having enabled 2FA), but no rights to merge or else (and as a matter of fact my PRs still remain many months reviewed and validated but not merged).
All this to say, it's great to have such metric, but it would be greater (and more meaningful) if we could have them for more PRs and also for members. Please don't feel obliged or blocked by my request, I don't know if it is an easy task or not to do, it's just a (naive) wish.

Regarding 74 there is an issue open https://github.com/PiotrZakrzewski/merge-chance/issues/4 that might increase it to 100-200 once resolved. I don't think that would change the statistics though.
As far as PRs being open and unmerged, I agree it's a problem - there was a Discourse thread from 2019, and of course the "PRs ready for review" threads see a lot of activity. I haven't looked at it much but the site code is open source, it's probably easy to modify to get different statistics. The outsider detection definitely isn't working right since jonringer is included as a "outsider" contributor but he's actually on the release team.

Regarding 74 there is an issue open https://github.com/PiotrZakrzewski/merge-chance/issues/4 that might increase it to 100-200 once resolved. I don't think that would change the statistics though.
As far as PRs being open and unmerged, I agree it's a problem - there was a Discourse thread from 2019, and of course the "PRs ready for review" threads see a lot of activity. I haven't looked at it much but the site code is open source, it's probably easy to modify to get different statistics. The outsider detection definitely isn't working right since jonringer is included as a "outsider" contributor but he's actually on the release team.

Service no longer works.


Code Audits?

Is your feature request related to a problem? Please describe.
I really like the idea of this project, and really want to make this my primary browser. The developer has done some really great work. However, how do I know that there is no malicious code being inserted by the developer? I can't really trust it to do things like my online banking.
Describe the solution you'd like
Make a company out of this project. There is more than enough demand (I think). This could be like the chromium equivalent of Firefox. Rely on donations to generate revenue. Once you establish a company, you will build your credibility and hopefully can have external 3rd parties audit the code changes you are making.
Describe alternatives you've considered
Blindly trusting the dev.
Additional context

A few things:

I agree that code audits are good, because they get more people to look critically through the code, which helps attract more people to the project. However, I don't think code audits are the only way to build trust, or even the best way to build trust for a project that is constantly changing (because Chromium is constantly evolving).
This is issue is fundamentally about trust. In that case, I don't know if creating a company would actually help solve the trust issue, even though they could help us get code audits. Perhaps a non-profit organization or even some donation system would be better, as those also show a bigger commitment/responsibility.

This is issue is fundamentally about trust. In that case, I don't know if creating a company would actually help solve the trust issue, even though they could help us get code audits. Perhaps a non-profit organization or even some donation system would be better, as those also show a bigger commitment/responsibility.

I wanted to chime in on this. I think that forming some sort of organization going forward is going to be the next major step for the whole idea of an Ungoogled Chromium browser, regardless of who is developing it.  We're way too loose and too few in numbers. Having an organization would not only serve as a rally point for organizing devs behind the cause, but it could also strengthen the project enough so it becomes a successor to Google Chrome. Basically like starting the next Mozilla but instead of Netscape we're using Chromium.
My only caveat is that I would like to see it USA, CAN, or EU based. There's too much riff raff coming from CHN and RUS lately, so incorporating in those parts of the world would be a bad idea for Western adoption.


Carthage fails

*** Fetching SwiftDate
*** Checking out SwiftDate at "3.0.9"
*** xcodebuild output can be found in /var/folders/8h/mdz9rybx5dv4jgg64fqz8k700000gp/T/carthage-xcodebuild.uuB0GU.log
*** Building scheme "SwiftDate-OSX" in SwiftDate.xcodeproj
*** Building scheme "SwiftDate-WatchOS" in SwiftDate.xcodeproj
*** Building scheme "SwiftDate-iOS" in SwiftDate.xcodeproj
*** Building scheme "SwiftDate-tvOS" in SwiftDate.xcodeproj
** CLEAN FAILED **
The following build commands failed:
Check dependencies
(1 failure)
** BUILD FAILED **
The following build commands failed:
Check dependencies
(1 failure)
A shell task (/usr/bin/xcrun xcodebuild -project /Volumes/Transcend/Document/Malisa/Carthage/Checkouts/SwiftDate/XCode/SwiftDate.xcodeproj -scheme SwiftDate-tvOS -configuration Release -sdk appletvsimulator ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build) failed with exit code 65:
** CLEAN FAILED **
The following build commands failed:
Check dependencies
(1 failure)
** BUILD FAILED **
The following build commands failed:
Check dependencies
(1 failure)

This is not related to SwiftDate, please see this issue :)

Hi, I have problem with Carthage too.
Simple github "malcommac/SwiftDate" on my Cartfile
carthage 0.17.2
xcode 7.3.1
When I run carthage update --platform iOS --no-use-binaries
The output is:
*** Skipped building SwiftDate due to the error:
Dependency "SwiftDate" has no shared framework schemes for any of the platforms: iOS
Other project in the same Cartfile works.
Thanks.

Can you check with the new build?


OpenKh.Tools.ImageViewer Improvements

Given a recent discovery by Topaz and I that KH2 does in fact support custom color palette sizes, it's important to note that two things lead to problems when using these custom IMD files in the viewer:

The viewer does not read the size directly from the header, expecting a palette size of 16, 256, or 16,777,215, causing the viewer to crash. This happens only when a palette size is between but not equal to the aforementioned values.
For blank pixels, PNGQuant is setting the RGBA values to 47 70 4C 00. Crazycatz' editor changes the format due to using nQuant instead. If OpenKH is changing the expected image format to match Crazycatz' algorithm, it might be responsible for the attached image looking how it does.

Edit: The second point has been discovered to be wrong, but Crazycatz' generation is still incorrect and should not be used as a basis. KH2 does accept images with less than or equal to 128 colors (perhaps 256 too) without Red and Blue channel obfuscation.
Attached is also an archive with three IMD files and two PNG images with their limited color palettes.

Custom IMDs + Images.zip - Download

crashes the viewer.imd should be fine.

ImageViewer will be able to open it with slight changes...
 OpenKh.Kh2/Imgd.cs | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/OpenKh.Kh2/Imgd.cs b/OpenKh.Kh2/Imgd.cs
index f13d60b..e1f27de 100644
--- a/OpenKh.Kh2/Imgd.cs
+++ b/OpenKh.Kh2/Imgd.cs
@@ -153,14 +153,18 @@ namespace OpenKh.Kh2

         private byte[] GetClut8()
         {
+            var maxClutIndex = Clut.Length / 4;
             var data = new byte[256 * 4];
             for (var i = 0; i < 256; i++)
             {
                 var srcIndex = Ps2.Repl(i);
-                data[i * 4 + 0] = Clut[srcIndex * 4 + 0];
-                data[i * 4 + 1] = Clut[srcIndex * 4 + 1];
-                data[i * 4 + 2] = Clut[srcIndex * 4 + 2];
-                data[i * 4 + 3] = Ps2.FromPs2Alpha(Clut[srcIndex * 4 + 3]);
+                if (srcIndex < maxClutIndex)
+                {
+                    data[i * 4 + 0] = Clut[srcIndex * 4 + 0];
+                    data[i * 4 + 1] = Clut[srcIndex * 4 + 1];
+                    data[i * 4 + 2] = Clut[srcIndex * 4 + 2];
+                    data[i * 4 + 3] = Ps2.FromPs2Alpha(Clut[srcIndex * 4 + 3]);
+                }
             }

             return data;

@kenjiuno I was into this issue too. So far I solved it in a similar way you did. You can see my commit here: https://github.com/Xeeynamo/OpenKh/commit/ca655ecf5e24d97541effd2c7680ef2281d5bac7
Still there is the problem of the texture with the wrong palette. I honestly have no idea how to fix it at the moment :/

@kenjiuno I was into this issue too. So far I solved it in a similar way you did. You can see my commit here: ca655ec

Thanks for checking about it! I'll check it later

Still there is the problem of the texture with the wrong palette. I honestly have no idea how to fix it at the moment :/

I have tested these 3 IMD files upon my pcsx2.  By injecting each IMD into P_EX100.a.fm.
crashes the viewer.imd

face 6-bit 48 colors.imd

face 8-bit 256 colors.imd

I'm just interested in how face 6-bit 48 colors.imd and face 8-bit 256 colors.imd are generated.

The game either doesn't run a check at all or only checks if the color palette size is >= 16. (Not sure which but both are possible since the game only chooses to not accept images if their color count is < 16.) As a result, if the target image's color count is only 128 instead of 256, 128 * 4= 512 bytes for the palette size instead of the usual 1024.
In short, the formula being used to generate these IMDs is as simple as (target color count) * 4 = (palette size)

@Vladabdf The error message in the second and third image are only thrown if you use pcsx2 with a debugger or from within visual studio.

Fixed the crash on #93

crashes the viewer.imd works now.


Fix package manager references

Fix leftover references to yarn, since we've moved to pnpm.

Codecov Report

Merging #635 (9c5753e) into main (230439b) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #635   +/-   ##
=======================================
  Coverage   93.23%   93.23%
=======================================
  Files          16       16
  Lines         473      473
  Branches       63       63
=======================================
  Hits          441      441
  Misses         32       32

Impacted Files
Coverage Δ

scripts/templates/scss.ts
100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Use one version of xunit

Noticed this in Component Governance: We are using multiple versions of xunit in the C# projects; bump IntegrationTests so we are only using one.

Codecov Report

Merging #3009 (b5337a6) into main (4dcc49c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3009   +/-   ##
=======================================
  Coverage   29.02%   29.02%
=======================================
  Files         304      304
  Lines       36326    36326
=======================================
  Hits        10545    10545
  Misses      25781    25781

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.