[Feature] dict query function

What type of PR is this：

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Problem Summary(Required) ：
implement function 'dict_mapping' support query a primary key table, and return a numeric value column.
dict_mapping(dict_table, keys... [, value_column])
argument:
dict_table: STRING, with 'db.table' or 'table' format, needs a table to exist and is the primary key model.
keys: same as dict_table pk length, order, and type, not support implicit type cast.
value_column: STRING optional, if don't specific value column, find first AUTO_INCREMENT column as value column, value column must be BIGINT type.
strict_mode: BOOLEAN optional, default is false, in strict mode, the query will be failed if dict record does not exist.
return:
BIGINT, the actual value of value column.

Use case:
Create a primary key table with auto-increment column as the global dictionary.
use 'dict_mapping' function when loading data to the base table, mapping the string type key to ordered number, then use BITMAP type to create rollup mv speed up count distinct query.
Detail:
Intercept 'dict_mapping' function in SQL planner, and transfer dict table metadata in TExprNode to BE. DictQueryExpr does real work using TableReader multi_get API query records from dict table and return id.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

Can you add more descriptions about this dict-query function?

What's the usage scene for this function?
Do other database systems have this function?
Can you add some docs for this function in docs/ later?

[FE PR Coverage Check]
:heart_eyes: pass : 295 / 337 (87.54%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/AggregationAnalyzer.java
0
1
00.00%
[325]

:large_blue_circle:
com/starrocks/analysis/DictQueryExpr.java
12
19
63.16%
[46, 47, 48, 53, 54, 55, 69]

:large_blue_circle:
com/starrocks/planner/OlapTableParamGenerator.java
157
182
86.26%
[53, 135, 148, 168, 169, 177, 179, 180, 209, 229, 254, 264, 265, 266, 267, 272, 273, 274, 278, 283, 284, 285, 305, 306, 326]

:large_blue_circle:
com/starrocks/sql/analyzer/ExpressionAnalyzer.java
100
109
91.74%
[1478, 1494, 1497, 1530, 1563, 1600, 1601, 1602, 1603]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/ScalarOperatorVisitor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AstToStringBuilder.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/planner/OlapTableSink.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/DictQueryOperator.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/plan/ScalarOperatorToExpr.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/transformer/SqlToScalarOperatorTranslator.java
5
5
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 295 / 343 (86.01%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/AggregationAnalyzer.java
0
1
00.00%
[325]

:large_blue_circle:
com/starrocks/analysis/DictQueryExpr.java
12
19
63.16%
[46, 47, 48, 53, 54, 55, 69]

:large_blue_circle:
com/starrocks/planner/OlapTableParamGenerator.java
157
188
83.51%
[55, 109, 110, 111, 141, 154, 174, 175, 176, 177, 178, 185, 187, 188, 217, 237, 262, 272, 273, 274, 275, 280, 281, 282, 286, 291, 292, 293, 313, 314, 334]

:large_blue_circle:
com/starrocks/sql/analyzer/ExpressionAnalyzer.java
100
109
91.74%
[1468, 1484, 1487, 1520, 1553, 1590, 1591, 1592, 1593]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/ScalarOperatorVisitor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AstToStringBuilder.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/planner/OlapTableSink.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/DictQueryOperator.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/plan/ScalarOperatorToExpr.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/transformer/SqlToScalarOperatorTranslator.java
5
5
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 134 / 153 (87.58%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/AggregationAnalyzer.java
0
1
00.00%
[325]

:large_blue_circle:
com/starrocks/planner/OlapTableSink.java
3
5
60.00%
[410, 418]

:large_blue_circle:
com/starrocks/analysis/DictQueryExpr.java
12
19
63.16%
[46, 47, 48, 53, 54, 55, 69]

:large_blue_circle:
com/starrocks/sql/analyzer/ExpressionAnalyzer.java
97
106
91.51%
[1455, 1477, 1480, 1513, 1546, 1578, 1579, 1580, 1581]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/ScalarOperatorVisitor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AstToStringBuilder.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/DictQueryOperator.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/plan/ScalarOperatorToExpr.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/transformer/SqlToScalarOperatorTranslator.java
5
5
100.00%
[]

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: liuyufei9527:x: liuyufeiliuyufei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

[FE PR Coverage Check]
:disappointed: fail : 119 / 166 (71.69%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/service/FrontendServiceImpl.java
0
32
00.00%
[2001, 2002, 2003, 2005, 2006, 2007, 2009, 2010, 2012, 2013, 2014, 2016, 2017, 2018, 2019, 2020, 2021, 2023, 2024, 2026, 2027, 2028, 2029, 2030, 2031, 2032, 2033, 2034, 2035, 2036, 2037, 2038]

:large_blue_circle:
com/starrocks/sql/analyzer/AggregationAnalyzer.java
0
1
00.00%
[325]

:large_blue_circle:
com/starrocks/planner/OlapTableSink.java
3
5
60.00%
[411, 419]

:large_blue_circle:
com/starrocks/analysis/DictQueryExpr.java
12
19
63.16%
[46, 47, 48, 53, 54, 55, 69]

:large_blue_circle:
com/starrocks/sql/analyzer/ExpressionAnalyzer.java
82
87
94.25%
[1540, 1562, 1565, 1598, 1631]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/ScalarOperatorVisitor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AstToStringBuilder.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/DictQueryOperator.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/plan/ScalarOperatorToExpr.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/transformer/SqlToScalarOperatorTranslator.java
5
5
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 123 / 176 (69.89%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/service/FrontendServiceImpl.java
0
32
00.00%
[2001, 2002, 2003, 2005, 2006, 2007, 2009, 2010, 2012, 2013, 2014, 2016, 2017, 2018, 2019, 2020, 2021, 2023, 2024, 2026, 2027, 2028, 2029, 2030, 2031, 2032, 2033, 2034, 2035, 2036, 2037, 2038]

:large_blue_circle:
com/starrocks/sql/analyzer/AggregationAnalyzer.java
0
1
00.00%
[325]

:large_blue_circle:
com/starrocks/analysis/DictQueryExpr.java
12
19
63.16%
[46, 47, 48, 53, 54, 55, 69]

:large_blue_circle:
com/starrocks/planner/OlapTableSink.java
8
11
72.73%
[398, 411, 419]

:large_blue_circle:
com/starrocks/sql/analyzer/ExpressionAnalyzer.java
86
96
89.58%
[1537, 1538, 1573, 1599, 1606, 1628, 1631, 1661, 1662, 1676]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/ScalarOperatorVisitor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AstToStringBuilder.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/DictQueryOperator.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/plan/ScalarOperatorToExpr.java
4
4
100.00%
[]

Does this feature can  cherry-pick to 2.5, or it depend on some new feature of Primary Key model after 2.5?

Does this feature can cherry-pick to 2.5, or it depend on some new feature of Primary Key model after 2.5?

This function is based on multi_get api for the short path scanning for primary key table.


OSX quarantined mex files

I received an email from a user that she could not start qMRLab. I figured that it was because OSX (Catalina 10.15.7) quarantined mex files.
sudo xattr -r -d com.apple.quarantine $qMRLab_directory

sudo find $qMRLab_directory -name \*.mexmaci64 -exec spctl --add {} \;

This solved the problem, I will add this to the documentation under a new section (Known Issues) under Installation.

I figured that it was because OSX (Catalina 10.15.7) quarantined mex files.

Wait, what? The latest OSX version quarintined all the mex files on systems?

They could not help but quarantine something in 2020. Interestingly, I had the exact same MATLAB and OS versions with the user, but I did not run into this issue. All I know is that Catalina is not being a research friendly release so far, and Big Sur does not make things better.

It may depend on how the user downloads qMRLab. As I understand it, Safari does the quarantining rather than something at OS level. Certainly, if people download QUIT via Safari it gets quarantined, but if they use curl it doesn't. I've just realised I haven't tried downloading QUIT via Chrome, I should try that and see what happens.

@spinicist thanks! That makes sense, I always use git, probably why I bypassed this issue (similar to curl does, I guess). It is worth experimenting safari/chrome downloads and add them into documentation. At any rate, making quarantine decision based on through which channel they are downloaded rather than what is downloaded almost sounds like a fallacy.


Bots can't talk to Nadeko?

Is there anything preventing a bot from issuing NadekoBot commands? (I have tried, and it seems to ignore the messages) I'll keep digging.

It's not an issue. Bots are prevented from triggering eachother.

Is this behavior specific to Nadeko or Discord?
On Mon, Mar 13, 2017 at 11:22 AM, kongslien<EMAIL_ADDRESS>wrote:

It's not an issue. Bots are prevented from triggering eachother.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Kwoth/NadekoBot/issues/1126#issuecomment-286140229,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASQdmdI8qC9YYijkJU5LKPUDMUCFrJCks5rlV8agaJpZM4MbZlo
.


Feature/previous saved state

Hi,
This PR tentatively adds a _previous_saved_state, which stores the _saved_state AFTER it has been updated because the changes have been persisted in the database.
This new state allows users to inspect the changes persisted to the database in an after_event callback, for example.
It adds new methods:

has_changed
get_previous_saved_state()
get_previous_changes()

I also improved the documentation with examples of is_changed, get_saved_state(), get_changes(), and rollback.
Best,

@roman-right Can you have a look? Are you interested in this feature?

Tests are green again !

Hey @paul-finary ,
Sorry for the delay. This feature looks interesting! Thank you!
As it can potentially increase RAM usage, could you please add a respective config to the settings with disabled by default?

If I'll be slow about this PR again, pls ping me in Discord

Hey @paul-finary , Sorry for the delay. This feature looks interesting! Thank you! As it can potentially increase RAM usage, could you please add a respective config to the settings with disabled by default?

Sure thing, I updated the PR!

Merged. Thank you, @paul-finary !


Embeddings Extractors

import torchtext
import torchvision

from relevanceai.operations_new.processing.feature_extractor import FeatureExtractor

x = torch.randn(10, 3, 224, 224)
model = torchvision.models.resnet34()

fx = FeatureExtractor(model, layer_name="avgpool")

vectors = fx(x) # vectors of samples passed through model exitting as avgpool layer````

```from relevanceai.operations_new.processing.feature_extractor import EmbeddingsExtractor

x = torch.tensor([1, 4, 78, 34, 234, 2, 0, 0, 0, 0, 0])
model = torchtext.models.RobertaModel(torchtext.models.roberta.RobertaEncoderConf())

fx = EmbeddingsExtractor(model)
vectors = fx(x) # vectors associated with tokens in x```

Yeah does this:
from relevanceai.operations_new.processing.feature_extractor import EmbeddingsExtractor

x = torch.tensor([1, 4, 78, 34, 234, 2, 0, 0, 0, 0, 0])
model = torchtext.models.RobertaModel(torchtext.models.roberta.RobertaEncoderConf())

fx = EmbeddingsExtractor(model)
vectors = fx(x) # vectors associated with tokens in x

Does this produce word or sentence/paragraph embeddings?


HDDS-6267. Recon is accessing mock classes.

What changes were proposed in this pull request?
Refactor MockSCMHAManager and MockRatisServer class names.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6267
How was this patch tested?
Tested with CI tests

Thanks @aswinshakil for the patch, @avijayanhwx for the review.


Generate Random action ID. fix ActionID check

Hi,
We have noted that after sending a couple AsyncAction requests, the main goroutine stops receiving and processing new events. This could be caused by ActionID being statically set to 'gamigeneral'
We have added some randomness to it.
We also think that sending actions line by line may cause some problems when you have multiple processes sending request in  the same socket. The patch I provided is grouping those and sending in one packet. sending it line by line isn't also as much efficient as sending grouped ones.
The check for empty ActionID does not look right and I think it didn't work as expected.
I also spotted that if have have two separate connection handlers, one only receiving events and the other sending actions, at some point the one receiving events stops  doing it. This may be caused by some variables being shared between instances but we were unable to fix it yet.
csiwek @Nexmo

hi,
thanks i will check those points

hi,
can you try the latest change


Fixes #3875. Add left and right tab sides with alignments to the TabView.

Fixes

Fixes #3875

Proposed Changes/Todos

[x] Add tabs on left and right with alignments feature. Note that alignments are only noticed on tabs on left and right because tabs on top and on bottom the tabs length are always justified to the text length.

Pull Request checklist:

[x] I've named my PR in the form of "Fixes #issue. Terse description."
[x] My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
[x] My code follows the Terminal.Gui library design guidelines
[x] I ran dotnet test before commit
[x] I have made corresponding changes to the API documentation (using /// style comments)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any poor grammar or misspellings
[x] I conducted basic QA to assure all features are working

@tig there are 4 unit tests failing because the Clip is returning a empty region when the down arrow being draw. This only happen when it's needed to draw over the tab border, which could be possible because the down arrow super-view is the TabRow and the last tab. Only when the selected tab is the last on the botton the down arrow is draw. I need your help to find what it's causing this failure, please. Here the unit tests failing:
Add_Three_TabsSide_Left_ShowInitialLine_False_ChangesTab_Height5

    Expected:
───────────────────┐
Tab1 hi            │
────╮              │
Tab2│              │
────▼──────────────┘
 But Was:
───────────────────┐
Tab1 hi            │
────╮              │
Tab2│              │
────╯──────────────┘

Add_Three_TabsSide_Left_ShowInitialLine_True_ChangesTab_Height5

Expected:
╭──────────────────┐
│Tab1 hi           │
├────╮             │
│Tab2│             │
╰────▼─────────────┘
 But Was:
╭──────────────────┐
│Tab1 hi           │
├────╮             │
│Tab2│             │
╰────╯─────────────┘

Add_Three_TabsSide_Right_ShowInitialLine_False_ChangesTab_Height5

Expected:
┌───────────────────
│hi             Tab1
│              ╭────
│              │Tab2
└──────────────▼────
 But Was:
┌───────────────────
│hi             Tab1
│              ╭────
│              │Tab2
└──────────────╰────

Add_Three_TabsSide_Right_ShowInitialLine_True_ChangesTab_Height5

Expected:
┌──────────────────╮
│hi            Tab1│
│             ╭────┤
│             │Tab2│
└─────────────▼────╯
 But Was:
┌──────────────────╮
│hi            Tab1│
│             ╭────┤
│             │Tab2│
└─────────────╰────╯

The strange is if there isn't enough space to add another tab an vertical line is added and the down arrow is draw. This issue only happens if the height fit exactly the tabs than can be currently visible.
────┐
Ta h│
──╮ │
  ▼─┘

┌────
│h Ta
│ ╭──
└─▼

It was a bug with the _rightDownScrollIndicator using the MoveSubviewToStart method instead of the MoveSubviewToEnd. Fixed in https://github.com/gui-cs/Terminal.Gui/pull/3876/commits/c93230689be4a4181e919b40f561a6e7f2d818f4.


Unable to prevent deviceLocale from overriding App Locale (Happened on Android)

Describe the bug
Due to "didChangeLocales" in root_controller always replace locale from deviceLocale instead of App's locale, I am unable to prevent deviceLocale from overriding my App's Locale.
This issue happen is due to GetMaterialApp uses root_controller, hence whenever didChangeLocales is called, "didChangeLocales" in root_controller will be called.
**Reproduction code
example:
  @override
  void didChangeLocales(List<Locale>? locales) {
    Get.asap(() {
      final locale = Get.deviceLocale;
      if (locale != null) {
        Get.updateLocale(locale);
      }
    });
  }

Due to settings in root_controller, everytime when user change the deviceLocale, it will always override the App's locale.
To Reproduce
Steps to reproduce the behavior:

Load the App once, locale is "en_US"
Go to Android Settings, change device Language
Go to App, all the String with .tr will be translated even though I did set it to update.

Expected behavior

Device Locale shouldn't override the App's Locale that was manually set by user.

Screenshots

Flutter Version:
3.0.3
Getx Version:
4.6.5
Describe on which device you found the bug:
ex: Android phone
Minimal reproduce code
N/A

I faced this problem too. Is there any progress or maybe a workaround how to make this update conditional?


Picker

Need to implement the Picker.
func (p *Picker) Next(peer string) (index int)

Implemented a first version.


How to highlight a diff

Is your feature request related to a problem? Please describe.
I use this to teach. I need lines added/removed to be as clear as possible.
Describe the solution you'd like
I want to be able to include lines that are removed and lines that are added, where the removed lines are highlighted in red with a - to the left, and the added lines in green with a + to the left.
Describe alternatives you've considered
Other than forking this library, which I really haven't time to do, or using another, and there don't seem to be other options, none.
Additional context
Take a look at the Git diffs for pull requests for an example of what I'm talking about.

Other than forking this library, which I really haven't time to do, or using another, and there don't seem to be other options, none.

You probably mean well, but this line comes across as-if you don't have time to implement a diff so instead you're trying to have some open source maintainer do it for you for free.
I don't have time to implement this feature either. But I'd happily discuss this feature with you to come up with a plan. First off I'm not entirely convinced it belongs in this module, but if it can be done elegantly enough I'd be open to it.

It's a feature suggestion. If there is no interest from others, then I certainly don't expect you to make the effort. But I'd be surprised if this wasn't something very useful to people. After all, tutorials are a common use of syntax highlighting.
If no one else wants to tackle it, then I'll either do it (happy to do a pull request if it works), or will give up on it and do without.

@chasm this demo needs to be updated to current api, but gives a decent idea of userland implementation -- https://github.com/conorhastings/react-syntax-highlighter/blob/master/demo/diff.js

closing as there is no action to be taken here, you can use the above example + attach a css class to line and add the + - in css


fix bug: NullPointException when hook view click; do not init trojan when space is not enough; rename version 0.1.2

fix bug: NullPointException when hook view click; do not init trojan when space is not enough; rename version 0.1.2

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


gfauto: If/else statements missing braces after pretty printing

As seen in the example below, after gfauto has reduced a found crash it should have formatted the variant shader and the reference shader. This should include adding braces where needed. However, this has not happened in a case where a "bad image" bug was found:
Reference:
...
        else
         if(int(gl_FragCoord[1]) < 270)
          {
           grey = 0.5 + float(data[8]) / 10.0;
          }
         else
          {
           discard;
          }
 _GLF_color = vec4(vec3(grey), 1.0);
...

Variant:
...
                   else
                    {
                     if(int(gl_FragCoord[1]) < 270)
                      {
                       grey = 0.5 + float(data[8]) / 10.0;
                      }
                     else
                      {
                       discard;
                      }
                    }
                  }
                }
              }
            }
          }
        }
      }
    }
  }
 _GLF_color = vec4(vec3(grey), 1.0);
...

Two shaders were missing braces, so I added them manually. Merged in https://github.com/google/graphicsfuzz/pull/995


Prioritize score not readable with screenreader

Testing #6329
On Windows, I have microsoft/vscode open and prioritized the notifications.
I then tried navigating the Notifications section with NVDA's speech visualizer open. I found that I could reveal and read the hover with Ctrl+K Ctrl+I, but that I was not able to see the notification score show up in the speech visualizer while navigating around.

I think that score is intended for debugging purposes.
However, it just uses decorations for the score. I think we should just make sure the score is in the hover.


doc: Sync updated model-runtime.proto file from modelmesh repo

Motivation
The docs dir in this repo contains a copy of the model-runtime.proto service definition from the model-mesh repo. It was recently updated with clearer comments for a couple of the RPC methods.
Modifications
Sync the latest version to this repo.
Signed-off-by: Nick Hill<EMAIL_ADDRESS>

/lgtm


Add Unified Memory

Send some comments via direct message. The short summary:

Add the list of missing CUDA features
Add system requirements for Unified Memory
Add Performance improvements tips
Allocation APIs for System-Allocated Memory? Is this supported?

@matyas-streamhpc Please rebase your branch on docs/develop

@matyas-streamhpc rebased the branch.

@neon60 Looks good. Some editorial tweaks:
Reorganize the content to:

Change title to Unified memory management

Document structure

Introduction (instead of Concept)
System requirements
Unified memory programming models
Using Unified memory management
Example

We have not explained Explicit memory management in the document. It would be good to list the differences between EMM and UMM. Consider adding the description after the visual.

@matyas-streamhpc Can we update the visual to include APU for context as an example of UMM architecture?

@matyas-streamhpc @yhuiYH added some comments from a user standpoint. Please feel free to use or ignore them. Let me know if they are not technically applicable or relevant.

@matyas-streamhpc @yhuiYH added some comments from a user standpoint. Please feel free to use or ignore them. Let me know if they are not technically applicable or relevant.

@Rmalavally @yhuiYH Thank you very much for your feedback. I updated the page, accordingly.

Please fix the following rst issues:
HIP\docs\reference\unified_memory_reference.rst:12: WARNING: Duplicate C++ declaration, also defined at reference/unified_memory_reference:10.
Declaration is '.. cpp:function:: hipError_t hipMallocManaged (void **dev_ptr, size_t size, unsigned int flags)'.
HIP\docs\reference/unified_memory_reference.rst:8: CRITICAL: Duplicate ID: "group___memory_m_1gaadf4780d920bb6f5cc755880740ef7dc".
HIP\docs\reference/unified_memory_reference.rst:8: WARNING: Duplicate explicit target name: "group___memory_m_1gaadf4780d920bb6f5cc755880740ef7dc".
HIP\docs\reference/unified_memory_reference.rst:15: WARNING: doxygenfunction: Cannot find function "hipMemoryAdvise" in doxygen xml output for project "HIP 6.2.0 Documentation" from directory: HIP\docs\doxygen\xml
HIP\docs\reference/unified_memory_reference.rst:17: WARNING: doxygenfunction: Cannot find function "hipMemRangeAttribute" in doxygen xml output for project "HIP 6.2.0 Documentation" from directory: HIP\docs\doxygen\xm


Added multiselect + start/stop for the session

Added multiselect + start/stop for the session.
Description
Multiselect
It is now possible to select multiple torrents by holding Ctrl while clicking on a torrent row. Selected torrents can be deleted together.
Screenshots:
Multiple selected torrents:

Delete torrents modal:

Session start/pause
Added buttons to start/pause session (all torrents).
Screenshots:

Motivation and Context
@antonsoroko asked for this.
How Has This Been Tested?
Tested on PC + mobile.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Translation

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

thank you!
it works good.
the only strange change i noticed is that now when you click on torrent second time ui will not close info panel, like it was before.
is it intentional?
also i have a question/idea: would it be possible to make table "sortable"? like by size or ratio.
would you be interested in implementing such feature? :-)

the only strange change i noticed is that now when you click on torrent second time ui will not close info panel, like it was before.
is it intentional?

It isn't. Thanks, fixed.

also i have a question/idea: would it be possible to make table "sortable"? like by size or ratio.

I've pushed some commits that add basic sorting by Name, Size, Seed ratio, Download rate and Active seeds (in respective columns).
Please note, that due to not having non-formatted data, sorting by size works incorrectly in some cases like this:

I sort by the size field but as it's preprocessed, I can't effectively compare KB to MB and GB and so on. To fix this I need to get bytes size from the backend.

cool, thank you.
btw, how sorting is done for Seed ratio, Download rate and Active seeds? since they have 2 columns inside.
also Size has embedded status - so no sort for status.
maybe it would make sense to somehow make sort for each column? (like add more columns headers)

@elgatito
btw, is there a reason why elementum uses humanize.Bytes instead of humanize.IBytes?
i mean
// Bytes produces a human readable representation of an SI size.
//
// See also: ParseBytes.
//
// Bytes(82854982) -> 83 MB

vs
// IBytes produces a human readable representation of an IEC size.
//
// See also: ParseBytes.
//
// IBytes(82854982) -> 79 MiB

would it make sense to change all Bytes to IBytes?

@antonsoroko I don't like "MiB" labels. 1024 vs 1000 is not so important in Elementum for me.

Also it would be helpful to add creation_date or any other field that is used to order torrents returned from /torrents/list.

it is actually sorted by *.torrent files modification time:
https://github.com/elgatito/elementum/blob/b202237f078a07557f2f11c42eb6cffa89f6987a/bittorrent/service.go#L1125
not sure yet how to pass this info to api.

@Dim0N22 @antonsoroko List of torrents is always returned sorted by exact order of adding to libtorrent.

I understand. The problem is that there is no way of returning back to the default order after sorting the torrents as there is no "add_date" or at least sequential id returned from the api.
Let's say I sorted the torrents by size. Then I want to disable the sorting and return back to the default order. There is no easy way of doing it.

@elgatito in a PR i basically take "torrent file modification time" (which is used to sort torrents before adding them to libtorrent) and just expose it. not sure what is wrong with this.

@Dim0N22 I have approved added_time column in torrents list. If you can test with the latest elementum code, then we can include all changes in the next release.

also size_bytes is available now.
i am still curious about
https://github.com/elgatito/plugin.video.elementum/pull/754#issuecomment-844974567
:-)

@Dim0N22 I have approved added_time column in torrents list. If you can test with the latest elementum code, then we can include all changes in the next release.

Thanks, updated sorting order.

also size_bytes is available now.

Thanks, fixed sorting by size.

btw, how sorting is done for Seed ratio, Download rate and Active seeds? since they have 2 columns inside.

I've mentioned that

I've pushed some commits that add basic sorting by Name, Size, Seed ratio, Download rate and Active seeds (in respective columns).

In short this means that column containing multiple values are sorted by the first one in the column.

also Size values have embedded status - so no sort for status.
maybe it would make sense to somehow make sort for each column? (like add more columns headers)

Unfortunately having multiple columns looks bad on mobile. Maybe one day we'll rewrite current table to a custom one so that it looks good both on mobile and desktop, but not in this PR.
Overall, I think this PR is ready for review and merge.

Unfortunately having multiple columns looks bad on mobile. Maybe one day we'll rewrite current table to a custom one so that it looks good both on mobile and desktop, but not in this PR.

got it.

Overall, I think this PR is ready for review and merge.

i did some quick testing - works good. thank you.

Okay, merging


Langlib string.length() does not return number of codepoints

Description:
It should return number of codepoints but at the moment it returns java's string.length()
Steps to reproduce:
Affected Versions:
1.0.1
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

@manuranga, With your string refactoring, will this issue be resolved?

@manuranga Can we resolve this issue ?

Yes, this is fixed with BString migration.


[improvement-#15268][subprocess] subprocess task cannot pass parameters which come from sub process instance

Purpose of the pull request

plz close this issue : #15268

Brief change log
Verify this pull request

This pull request is code cleanup without any test coverage.

Codecov Report
Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (43f5f24) 38.14% compared to head (22b2b66) 38.09%.
 Consider uploading reports for the commit 1f82a7b to get more accurate results

Files
Patch %
Lines

.../runner/task/subworkflow/SubWorkflowLogicTask.java
0.00%
27 Missing :warning:

...ster/runner/execute/MasterTaskExecuteRunnable.java
0.00%
1 Missing :warning:

...cheduler/server/master/runner/task/ILogicTask.java
0.00%
1 Missing :warning:

...subworkflow/SubWorkflowLogicTaskPluginFactory.java
0.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15277      +/-   ##
============================================
- Coverage     38.14%   38.09%   -0.05%
+ Complexity     4672     4665       -7
============================================
  Files          1280     1281       +1
  Lines         44519    44547      +28
  Branches       4794     4796       +2
============================================
- Hits          16982    16972      -10
- Misses        25672    25710      +38
  Partials       1865     1865

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BEAM-22] Improve ParDoEvaluator Factoring

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

This moves shared code into a common location.
Clone DoFn instances before constructing the DoFnRunner to
avoid races.

R: @dhalperi

LGTM

@tgroh : please backport


Enable pyright reportOptionalMemberAccess

Depends on #612

Codecov Report
Base: 82.46% // Head: 81.59% // Decreases project coverage by -0.87% :warning:

Coverage data is based on head (a89f59c) compared to base (4317976).
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
- Coverage   82.46%   81.59%   -0.87%
==========================================
  Files          78       78
  Lines        6084     6085       +1
==========================================
- Hits         5017     4965      -52
- Misses       1067     1120      +53

Impacted Files
Coverage Δ

quetz/metrics/tasks.py
77.77% <100.00%> (+0.50%)
:arrow_up:

quetz/pkgstores.py
42.73% <0.00%> (-11.50%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Llm search

also I remember Ask AI is a POC (it also does not include any tests), but way are we adding it to the dev branch?

To me the whole AISearch API belongs in Pluto, not Saturn. It is mainly based on redirection, this is one of the reasons Pluto was introduced for. Also, we already have ExternalSearch logic, which is really similar to this and stays within Pluto. To me Saturn should be all about our internal storage, not redirecting to external services

There is a bit of logic around managing the chats and chat history, not sure it would be correct to put business logic to the gateway layer. I still believe it should be a separate service, not a part of Pluto nor Saturn. It would also let us easily toggle the whole feature

Could you also make the naming more consistent? Especially the clases are currently named from LLM search, Fulltext search, AI search to just "convestation". I would prefix everything "AI" or "Llm" and then decide on single name afterwards, preferably "AISearch...", ince this is how the API endpoint is named now. Then instead of:
= llm
== Conversation.js
== FulltextAPI.js
== LlmSearchPage.js
you would have:
= ai
== AISearchPage.js
== AISearchAPI.js
== AISearchConversation.js or AISearchPanel.js


Test enhancement

Changed log

Add php-7.4 version test during Travis CI build.
According to the PHPUnit fixtures reference, it should use protected function setUp.
To be consistency, it should use the self to make PHPUnit assertion calls for all test classes.

This change is

Thank you so much!! Sorry that it took me 18 months to see this PR!
It is included in v2.6.0.


Add network isolation for training and processing jobs & Inter container encryption in sagemaker training and hyper parameter tuning job

Describe your changes
Issue ticket number and link
Checklist before requesting a review

[ ] I updated CHANGELOG.MD with a description of my changes
[ ] If the change was to a module, I ran the code validation script (scripts/validate.sh)
[ ] If the change was to a module, I have added thorough tests
[ ] If the change was to a module, I have added/updated the module's README.md
[ ] If a module was added, I added a reference to the module to the repository's README.md
[ ] I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
Commit ID: ef2efaea756bb7742f384488c12a77716fe8d658
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
Commit ID: fda03416bc71c88be46b83d1a571b56458e5c8a4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
Commit ID: 80328e0e6b55c1c182a975bb70cfdf85b2516a22
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
Commit ID: a1fbbeabe0fd586bb6df9c96429e7922addcd862
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
Commit ID: aae0259242fd5d3977c0d2bf26d69c72356691da
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
Commit ID: ee1ead15acdca4fcea24852d8b537443e7546ff7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
Commit ID: 7a37863a019e585846be3c3e679b28cdd4fef722
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
Commit ID: f3a13051dd67cdf0e898b24482afe8defbf72e88
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
Commit ID: d7edf09bbfe58e6372dfb017ba2924717d58ca1b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


[WIP] keep secrets in encrypted form in memory

Description
This proposal attempts to reduce the likelihood of sensitive data being exposed.
Issue reference
#750
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[x] End-to-end tests passing
[ ] Extended the documentation
[ ] Specification has been updated
[ ] Provided sample for the feature

@flier this PR is very old and I am closing it for now to keep PRs manageable across all our repos. Feel free to reopen when you plan to work on it again.
Looking forward to your contribution, thanks!


Updating link to specs

This link https://github.com/ipld/specs/blob/master/block-layer/content-addressable-archives.md says it should point to here instead https://ipld.io/specs/transport/car/

1000 blessings to you sir ✨ 🎷 🐩


feat:🎸 add the create issue button

In this PR we added the button for creating an issue for the repo where not supported the version X
Closes #14

Thanks for this!


prefixItems is unsupported (OpenAPI 3.1)

What are the steps to reproduce this issue?

use prefixItems in the openapi (version 3.1)

What happens?
Orval will crash saying ovt - Error: All arrays must have an items key define
What were you expecting to happen?
Client will be generated
Any logs, error output, etc?
Swagger Example

Any other comments?
{
    "openapi": "3.1.0",
    "info": {
        "title": "Fail Example",
        "version": "0.1.0"
    },
    "paths": {
        "/api/v1/building/": {
            "get": {
                "tags": [
                    "Version 1",
                    "Building"
                ],
                "summary": "Get Buildings",
                "operationId": "get_buildings",
                "responses": {
                    "200": {
                        "description": "Successful Response",
                        "content": {
                            "application/json": {
                                "schema": {
                                    "$ref": "#/components/schemas/Polygon"
                                }
                            }
                        }
                    }
                }
            }
        }
    },
    "components": {
        "schemas": {
            "Polygon": {
                "properties": {
                    "type": {
                        "const": "Polygon",
                        "title": "Type",
                        "default": "Polygon"
                    },
                    "coordinates": {
                        "items": {
                            "items": {
                                "prefixItems": [
                                    {
                                        "type": "number"
                                    },
                                    {
                                        "type": "number"
                                    }
                                ],
                                "type": "array",
                                "maxItems": 2,
                                "minItems": 2
                            },
                            "type": "array"
                        },
                        "type": "array",
                        "title": "Coordinates"
                    }
                },
                "type": "object",
                "required": [
                    "coordinates"
                ],
                "title": "Polygon",
                "description": "Polygon Model."
            }
        }
    }
}

Having the same issue, everywhere else my spec is valid. Can't find any info online for this specific issue either.

I can confirm this issue. Using python and pydantic, defining a type with a tuple_positional_schema generates a prefixItems key. Changing the type's json schema to a List instead of a Tuple in my openapi generator works as a temporary (less robust ) fix.

Any news on this?

Just encountered the same error, as well as countless must have required property '$ref' or must match exactly one schema in oneOf errors alongside the Error: All arrays must have an items key define error 😕
Is there any workaround so far?

@Pierstoval I was able to fix it. My Swagger doc is auto-generated by NestJS Swagger. The problem was that arrays of a 'simple type' such as a number or a string didn't have a type in the Swagger JSON. So at first I had:
@ApiProperty({ required: false, isArray: true })
@Expose()
numberArray?: number[];

Once I changed all those arrays to the following:
@ApiProperty({ required: false, isArray: true, type: Number })
@Expose()
numberArray?: number[];

The schema added the correct type and it was instantly fixed. So all I had to do was add the correct type property to the ApiProperty decorator. Hope this helps!

I get the same error, would be very helpful if error was correlated with schema line number - that would help to narrow down the issue.


This is scary. At step 8,000 I'm getting decent English and passable Cherokee!

This is via the run interactive script.
IMS-Toucan-samples-step-8000.zip

Glad to hear that it's working on Cherokee! My hearing is untrained for tone, so I'm not sure how well the tone works, but I could definitely hear distinct phonemes, which is usually a sign that it is not going to fail, but instead keep improving. You can call the set_utterance_method of the InferenceInterface object and pass a path to a file from the cherokee training set. If you have little training data for a certain language, the quality can improve when you use a speaker from the training set of the language that you want to use. The quality of the speaker transfer across languages scales with the amount of data it has seen. The default speaker is the speaker of the first sample in the union of datasets that you train on.


Update client.py

The current function url for the official Supabase client is incorrect. I am fixing it by modifying the self.function_url to the correct rpc endpoint.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Currently for supabase environments that end in .co the incorrect function url is used. This results in being unable to utilize supabase functions.
What is the new behavior?
Corrected the url used so that functions can be used.
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

Hey @s360darrius,
Thanks for the PR! The functions url here refers to Edge functions rather than Database Functions / RPC
To make use of Database functions one would call the .rpc() function on postgrest-py

Going to close this for now but feel free to let us know if there are further questions


Test Puzzle with Orchestrator Integration

Kindly specify the names of env you want to specify in the given format [dev,stage,qa]

spaship dev

Deployment started for dev. Please check SPAship Manager for more details.

Deployment started for dev. Please check SPAship Manager for more details.

Build & Deployment Process Started Successfully, please check SPAship Manager for more details.

Kindly specify the names of env you want to specify in the given format [dev,stage,qa]


API: expose np dtypes in dask.array namespace

[x] Towards #10387
[x] Tests added / passed
[x] Passes pre-commit run --all-files

Copying my comment from the linked issue:

FWIW, exposing these would help with early adoption of Dask into SciPy. Now that we have array_api_compat.dask.array, we should be able to get our array-agnostic code working.
The slight problem at the minute is that in our tests, we make some assumptions about very basic things that NumPy, CuPy and PyTorch's main namespaces - and the standard - all have in common, such as xp.float64. This assumption has allowed us to reduce diffs quite a lot by avoiding (so far) unnecessary calls to get the wrapped namespaces.
I understand that resolution to this may be somewhat blocked on a resolution to whether converging the main namespace or adding a separate namespace is desirable in gh-8750. For now though, even just exposing the dtypes as @ogrisel suggested would be helpful. Thanks!

See https://github.com/scipy/scipy/pull/20956 for the failures caused in SciPy's test suite without this.

Can one of the admins verify this patch?
Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

thanks @jacobtomlinson !


#237 masterpass css improvment

Coverage decreased (-0.2%) to 99.839% when pulling 4093da2be9eb5b0b9ac8d51b9deb43131401d411 on TPWDCEE-425 into 1afee4196adb5073a298dd68c301f51dafba8e5a on master.

Coverage remained the same at 100.0% when pulling a056a0f57d645683e219fb87388b2040e7027b4f on TPWDCEE-425 into 1afee4196adb5073a298dd68c301f51dafba8e5a on master.

Coverage remained the same at 100.0% when pulling ab31fe68fe70729d832b2ab7664ebc75a23898ca on TPWDCEE-425 into 1afee4196adb5073a298dd68c301f51dafba8e5a on master.


The flink job is running on yarn, but failed on DS

When I start  a  flink job on DS,  the task always  fail in a few seconds ,however   It's still running on yarn.
Why?

@Dipsy-chen Which version? dev branch?

@Dipsy-chen Which version? dev branch?

V1.3.4  .

I get it.  DS  "yarnHaIps"  parame  is invalid ,because my yarn HA Backup master node  was down .
After configuring the "singleYarnIp" parameter, DS return to normal


Small fixes and changes

What does this PR do?
CLIGeneratorSubCommand -> CLISubCommand
As mentioned on #12, I changed the name of the service, its resource property (is now name) and its generate method (is now `handle), so other CLI commands can make use of it on the future.
Fix for unkown options on CLICommand.generate
On CLISHBuildCommand, I was relying on the fact that generate ignored unknown options, but after the change from #14 , it was allowing them and some commands started throwing an error regarding the unknown options.
So instead of fixing it and only sent supported options, something I'll do later, it made more sense to only allow unknown options on generate when the command itself supports unknown options.
Change the output path for fonts.
To make it short, if you have more than one web font on your project, the generated directory will end up having ALL of their files together... not cool.
Now, the new path for fonts is statics/fonts/[name]/[name].[hash].[ext] (the .[hash] is still only for production), so each font is saved inside a folder with its own name.
Change the way the CLI clean command behave
Previously, if you didn't specify a target name for the CLI clean command, it would delete the entire distribution directory.
Well, after the changes of #12 , this command was quite "aligned" with build and run, where if you didn't specify a target, they would use the "default target", so that was the change.
Now, if you don't specify a target name, it will clean the files for the "default target", and to remove the entire distribution directory, you need to use the new flag --all (or -a).
Detect SSR
While experimenting with SSR (Server Side Rendering), I noticed that importing React on the Node target would generate a "false positive" and mark the target as a browser, so I added a dictionary of expressions on the Targets Finder that would identify frameworks that can also be used on Node.
The only added case for now is React, so if you import react and react-dom/server, the target is identified as a Node target.
How should it be tested manually?
yarn test
# or
npm test

Pull Request Test Coverage Report for Build 66

27 of 27 (100.0%) changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 64:
0.0%

Covered Lines:
1390

Relevant Lines:
1390

💛  - Coveralls


Fix docs for asset names in hex

The code PR (https://github.com/input-output-hk/cardano-node/pull/3211) was merged, but not this update to the docs. I think this should be merged too?

bors merge


Explicitly expire prometheus metrics when apps are deleted

The goal of this PR is to fix the problems we've been seeing around stale metrics in prometheus.  They exist for a few reasons:

metrics aren't removed when apps are deleted
metrics for a given cell aren't removed when the app migrates to another cell
metrics for an instance aren't removed when the app scales down.

This PR fixes 1. and 2. but not 3.
We previously tried to fix this issue in #30, by expiring metrics after a TTL, but this caused separate problems: rare events, such as 500s on certain apps, would mean that the metric would regularly appear and disappear.  When combined with the fact that we don't set up counters to start from 0, this meant that we could not consistently detect the presence of 500 errors using prometheus's rate function.
The approach in this PR is:

add a way for the fetcher to communicate to the sender when an app is created or deleted
split the prometheus sender's {Counter,Gauge,Histogram}Vec instances up by app guid
when an app is deleted, reset all of its metrics
remove the cell_id label entirely, so that we avoid the problem of stale metrics from old cells

This works fine, and the idea is good, but I am worried about the old instances when scaling up and down. I think the tenants would complain about ghost metrics in the stream.
The application main loop receives the application information including the instance count, but I am not sure if it gets updated.
I wonder if we could send the number of instances in the app to the senders there. The problem is that we would send a metric with the number of instance for every metric, which is weird.
Other option is that the fetcher keeps track of all the App struct (e.g.hash), instead of only the GUID, and if it changes it emits metrics for some values from that struct (instances, quota, etc.).
Finally the prometheus sender could monitor the number of instances, and if it lower than the latest value, delete the old metrics in the vector.
What do you think?

Talked with @philandstuff about the instances problem.  His team is in contact with the main consumer of the prometheus feature, so they will get feedback if this becomes a problem.
Once the tests are fixed, I will be happy to merge.
As a follow up later we might be able to:

modify the fetcher to provide an additional channel reporting any app properties change (e.g. state, number of instances)
modify the app to emit metrics to the sender based on this new channel (e.g. running_instances).
modify prometheus to keep one vector per app and instance, and delete the vectors if the reported running instances is reduced.


Camera not showing when adding new accessory.

I deleted the camera accessory when I was troubleshooting the 405 error discussed previously. I have the latest version of the plugin and have added the token to my config. I can't unfortunately get the camera to show when adding new accessory.
logfile.log

[2018-12-16 20:05:54] [Nest-cam] Create camera - Demi's Room
So we did find the camera and exposed it to HomeKit. Can you try go to ~/.homebridge/persist and remove the AccessoryInfo for just the camera?

That did the trick, much appreciated!


Try to add users' online status in Redis again if it's have been removed in Redis unexpectedly when refreshing heartbeat

To not mix the logic of refreshing heartbeat on Redis and keep the logic as simple as possible, we close the local sessions instead of trying to register them again currently.


Reduce AWS library size

Jira: N/A
KBC: N/A
Before asking for review make sure that:
Checklist

[x] New client method(s) has tests
[x] Apiary file is updated

Release

[x] I gave the PR a proper label:

major (BC break)
minor (new feature)
patch (backwards compatible fix)
no release (just test changes)

Prošel mi phpstan a test na založení tabulky, tak předpokládám, že je to OK :)


add -add flag to docker run

It would be nice to have a new flag to allow adding a file (not mounting) inside the container before running it.
This could deprecate the insert command that is weirdly limited to URL and bring the CLI experience in line what what you can do in a Dockerfile

@proppy hiiii! is this still relevant? do you think we still need it :)

@jfrazelle yes, there is still no clean way to add a set of files to a container and commit from the CLI/API, w/o a Dockerfile or messing with stdin.

@proppy is it ok if we close this with the assumption that #13171 will solve your issue?

Sure.

thanks!


When setting time and region to Dutch, calendar to gregorian: timeAgoSinceNow returns null

example of time notation

figured out it didn't have anything to do with the lib. sorry for any time wasted :|


Retrieve data from elements

I was able to get the elements value with the following snip before version 3.0.0
options.elements.forEach((element) => {
  console.log( element.id + '= ' + element.value );
})

This is no longer working for elements values that where populated manually and then submitted, but it work for values that where populated with the initial request script.

NVM, this worked for me:
elements.forEach((element) => {
  console.log( element.id + '= ' + element.value );
})

@nicomar2000 That's the correct approach for v3 to use elements in the local state instead of options.
Let us know if there is anything else.


parameter eeli - psomhorst

@psomhorst . I believe this is the branch that the dashboard is currently running on, however there was no PR associated to it and it is probably out of date since #168.
This needs to be resolved if we want people to be able to use the dashboard.

Yes, indeed.
This was created for the GUI demo. However, it depends on some code that has not been merged to main yet. It requires #223 to be merged, and then this branch to be updated to match the latest changes.
Blocked by #223

Closed in #269


Normalize example.com URLs in input and output

There were a few cases where HTML input and JSON output mixed schemes for URLs like http://example.com and https://example.com and where the URL in the JSON output lacked a trailing slash.
This PR normalizes on http:// since it's the more widely-used protocol in the remainder of the test suite and adds a trailing slash in cases where the resulting value is http://example.com/.

@jgarber623 Just checking if this PR is ready or still in-progress?

@gRegorLove It should be ready! Came across a case I missed (thus the extra push today).
I'll resolve the conflicts with master and then we should be good!

@gRegorLove Conflicts resolved, so this should be good to go! 👍

Have a personal wip for the same thing but opted for using https as schema for the url context. For one it promotes the use of tls and looks more modern but more importantly a lot of the test cases that have a base tag use http://example.com. With this change non of them would assert the handling of the url set by the base tag.

I don't have a strong preference between http and https example.com in the tests. Looks like there's still a mixture of them in this PR, though.
I think we should resolve https://github.com/microformats/microformats2-parsing/issues/9 before merging the trailing slashes update.

Also let's get this trailing slash fix merged because this is for valid URLs […]

I strongly disagree. This PR introduces a test about adding slashes that currently fails in all parsers on microformats.io (tested: Go, PHP, Python, Ruby; sadly Node is offline) and the specification is not clear about whether this normalisation should be applied at all.
It just so happens that the discussion about this is taking place in microformats/microformats2-parsing#9. We can (and maybe should) split it off into a new issue, but there is no denying that we are currently only on step two of the mf2 change control: propose a resolution. (Or possibly step 4, iterating on said resolution, depending on how far you feel the conversation has gotten.)
I think it sets a very weird precedent to add something to the test suite that has no documented  implementer consensus nor even a single live demonstrable implementation.


Derive Default and Eq where possible

We can't use Rust's default deriving mechanism, until https://github.com/rust-lang/rust/issues/26925 and https://github.com/rust-lang/rust/issues/7671 are fixed.
But fortunately, there's a crate for that.

I'm skeptical about this, since we're bringing in an extra external dependency just for something we can do in a few trivial lines anyway? Also take note that the crate also seems to be unmaintained


Nuxt3 nuxt.config

i see you add plugin to your nuxt.config
it is not necessary
The plugins directory, each file of which will be auto-registered as a Nuxt 3 plugin.

and if you want your plugin to work only in client side, just add .client to the name of the file
e.g.  super-matomo-plugin.client.ts


Error when create new bot

Hi,
I want to create a new Node Core Bot with Language bit I get an error:
Error calling npm to fetch template. Please ensure that node and npm are installed and available on your system. Full error message: Command failed with ENOENT: npm root -g --prefix /home/XXX/BotFrameworkComposer/.yo-repository --loglevel error spawnSync npm ENOENT
I'm using Ubuntu 18.04. I have check my node and npm version: npm -v      6.14.11 node -v     v14.8.0 but it is still failing. What can I do?

I have the same problem with the Bot Framework Composer v0.0.2

Hi @AdriVazquez and @arotena
If you are running the standalone electron/app, and not running your own build of Composer, can you please got to the Help->About menu, then click copy. That should give more version info. For example, I have:
Version:  2.0.0-nightly.260069.26b6d19
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0

@tonyanziano

Hi, this is my info:
Version:  2.0.0
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0

I was not able to reproduce this on the most recent Nightly version on Ubuntu 18.04.3 LTS with Node 16.4.1 and npm v7.18.1.
Can you please try the most recent nightly release found here?

@AdriVazquez @arotena How do you both normally start your .AppImage apps? Do you double click the shortcut after making it executable?
If so, please try starting your Composer installation via the terminal as a workaround.

Open a terminal tab
Navigate to where Composer is installed
run the command ./BotFramework-Composer-<version>-linux-x86_64.AppImage

Perfect @tonyanziano this works for me. Thank you!!

@tonyanziano That is!
running the command works for me. Although it would have been a good way from the beginning, I had not thought about it because I followed the instructions in https://docs.microsoft.com/en-us/composer/install-composer?tabs=linux.
Thank you

@arotena @AdriVazquez Would you please tell us how did you install NodeJs on your Ubuntu?

Hi @hatpick
I follow this tutorial with the option 3
The result of which node in my terminal is: /home/xxxxx/.nvm/versions/node/v12.2.0/bin/node

@arotena the reason you have the original issue is that node is not on your PATH (env variable) when you run Composer normally. In order for nvm to manage multiple versions of node, it needs to keep the executables under .nvm and then add it to current user profile PATH.
Ubuntu runs AppImage apps in a different context that does not load your user bash profile. So as a result it's not aware of the path that nvm uses for executables. To fix that, you need to create a couple of symlinks to make node and npm available for all users:
sudo ln -s `which node` "/usr/local/bin/node"
sudo ln -s `which npm` "/usr/local/bin/npm"


Integrate CoIR

Very cool work that should be easy to integrate given their format: https://github.com/CoIR-team/coir

Should we ask if the team behind would like to interesting in the PR?

Fixed in #1130


Add ISSUE_TEMPLATE.md and PULL_REQUEST_TEMPLATE.md

Pull Request (PR) description
Add ISSUE_TEMPLATE.md and PULL_REQUEST_TEMPLATE.md
This Pull Request (PR) fixes the following issues
n/a
Task list

[x] Added an entry under the Unreleased section in the CHANGELOG.md? Entry
should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md?
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help?
[ ] Comment-based help added/updated?
[ ] Localization strings added/updated in all localization files as appropriate?
[ ] Examples appropriately added/updated?
[ ] Unit tests added/updated?
See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible)?
See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to
DSC Resource Style Guidelines
and Best Practices?

This change is

Codecov Report

Merging #227 into dev will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev    #227   +/-   ##
=====================================
  Coverage   0.92%   0.92%
=====================================
  Files         36      36
  Lines       4013    4013
=====================================
  Hits          37      37
  Misses      3976    3976

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b373b...4712c58. Read the comment docs.

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

CHANGELOG.md, line 44 at r1 (raw file):

- Fixed PSSA custom rules in:
  - xExchActiveSyncVirtualDirectory.psm1
- Added ISSUE_TEMPLATE.md and PULL_REQUEST_TEMPLATE.md

Can we escape the underscore '_'?

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

CHANGELOG.md, line 44 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Can we escape the underscore '_'?

Done

Comments from Reviewable

@johlju Thanks for the tip & trick, I didn't know about escape character. Ready for LGTM 😄

Almost ready for LGTM. Just need you to rebase since I merged the other PR. :)

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Rebase done :smiley_cat:

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


EDAM class 'differentical gene expression analysis' needs fixing

EDAM class 'differentical gene expression analysis' is listed within EDAM with
a URI of http://edamontology.org/operation_3223, but is imported into SWO as http://edamontology.org/operation_3742. Need to investigate if this is due to an old import, and then fix it.

I have confirmed that this is a bug in an older version of EDAM, and all that is required is an update of the EDAM OWL file to the latest stable version.

The update to 1.7 removed this class from SWO. For future reference, we already have a similar class in SWO, SWO_7000018.


Add sensor type interface

Add interfaces for sensor type and i2c scan
Add interface to get/set the sensor type and to scan and set
i2c address of connected sensor.
This is necessary if the cable is not already configured for the
setup or if a special setup is needed.

Updated documentation and add missing type hints


First cluster implementation

Description
As solution for issue https://github.com/bosun-monitor/bosun/issues/2443
Same as https://github.com/bosun-monitor/bosun/pull/2345 with solving conflicts and some new api endpoints
Were added new api endpoints:
POST /api/cluster/recover_cluster
Api endpoint Is used to manually force a new configuration in order to recover from a loss of quorum where the current configuration cannot be restored, such as when several servers die at the same time. This works by reading all the current state for this server, creating a snapshot with the supplied configuration, and then truncating the Raft log. This is the only safe way to force a given configuration without actually altering the log to insert any new entries, which could cause conflicts with other servers with a different state.
WARNING! This operation implicitly commits all entries in the Raft log, so in general, this is an extremely unsafe operation. If you've lost your other servers and are performing a manual recovery, then you've also lost the commit information, so this is likely the best you can do, but you should be aware that calling this can cause Raft log entries that were in the process of being replicated but not yet be committed to be committed.
Example:
$ curl -s <IP_ADDRESS>:8071/api/cluster/status | jq .
{
  "State": "Candidate",
  "Nodes": [
    {
      "Address": "<IP_ADDRESS>:10002",
      "State": "Follower"
    },
    {
      "Address": "<IP_ADDRESS>:10014",
      "State": "Follower"
    }
  ],
  "Stats": {
...
  }
}
$ curl -XPOST <IP_ADDRESS>:8071/api/cluster/recover_cluster -d '{"members": [{"address": "<IP_ADDRESS>:10002"}]}'
{
  "State": "Leader",
  "Nodes": [
    {
      "Address": "<IP_ADDRESS>:10002",
      "State": "Leader"
    }
  ],
  "Stats": {
...
  }
}

POST /api/cluster/change_master - move leadership to another node in cluster
Example:
$ curl -s <IP_ADDRESS>:8071/api/cluster/status | jq .
{
  "State": "Leader",
  "Nodes": [
    {
      "Address": "<IP_ADDRESS>:10002",
      "State": "Leader"
    },
    {
      "Address": "<IP_ADDRESS>:10014",
      "State": "Follower"
    }
  ],
  "Stats": {
    ...
  }
}
$ curl -XPOST <IP_ADDRESS>:8072/api/cluster/change_master -d '{"id": "<IP_ADDRESS>:10014", "address": "<IP_ADDRESS>:10014"}'
{"status":"error","error":"cannot transfer leadership to itself"}
$ curl -XPOST <IP_ADDRESS>:8072/api/cluster/change_master -d '{"id": "<IP_ADDRESS>:10002", "address": "<IP_ADDRESS>:10002"}'
{"status":"error","error":"node is not the leader"}
$ curl -XPOST <IP_ADDRESS>:8071/api/cluster/change_master -d '{"id": "<IP_ADDRESS>:10014", "address": "<IP_ADDRESS>:10014"}'
{"status":"ok"}
$ curl <IP_ADDRESS>:8071/api/cluster/status | jq .
{
  "State": "Follower",
  "Nodes": [
    {
      "Address": "<IP_ADDRESS>:10002",
      "State": "Follower"
    },
    {
      "Address": "<IP_ADDRESS>:10014",
      "State": "Leader"
    }
  ],
  "Stats": {
...
  }
}

Type of change
From the following, please check the options that are relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How has this been tested?
Checklist:

[x] This contribution follows the project's code of conduct
[x] This contribution follows the project's contributing guidelines
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Hi @svagner, thanks a lot for the contribution. 🙌 Is it worth creating an issue first to discuss the approach and keep this PR for the technical discussion?
Can I also ask you to please use the template that's generated when you open a PR and fill in the details? This makes it easier for us to review bigger changes and contributions like this one. That'd be much appreciated.

Hi @svagner, thanks a lot for the contribution.  Is it worth creating an issue first to discuss the approach and keep this PR for the technical discussion?
Can I also ask you to please use the template that's generated when you open a PR and fill in the details? This makes it easier for us to review bigger changes and contributions like this one. That'd be much appreciated.

I'll create issue then. We already have a couple of them, but there was no movement about clustering. Also, there is some discussion in prev MR, but anyway it is not bad to have a separate issue for discussion

New implementation is in https://github.com/bosun-monitor/bosun/pull/2472