DailyProgress_0804

Large Scale Rust Project Maintaince
talk about NEAR blockchain development maintain experience

Electric Capital Developer Report(2021)  - deserve to look at it

architecture.md: provide shortcut of finding where to change code when you want to  add new function or bug fix;  Keep it short and make it with minimal posible to be outdated when future system upgrade
其作用一是帮助开发者（尤其是外部开发者）尽快知道到哪里去修改code，当要添加新功能或者bugfix时； 二是该文件内容尽可能简明扼要，抓住重点，这样不会因为日后系统升级，让该文档内容变得易于过时

Code Map:  describe module function(but not too detailed);  describe interface or constraint with other modules (architecture invariants)

Project Compile Time:  first glance, it's not a big issue; but it's a multiplier for everything basic.
if your project's compile time already long,  you will take more time to solve it(project will be changed).
the ONLY solution is:  always care for compile time, eg. every PR will invoke CI, and diff compile time.

cargo build --timings
Cargo.lock -- check if we actually need these dependencies

Test Driven:   the issues list as below:

one implementation triggers  many test cases modification
writing test case takes more effort than function itself
our tests should always care for function behavior than code
Data Driven Test (i want to know more about how it is, let's see more in NEAR)

NEAR Ceritified Developer 每月课程


[Snyk] Security upgrade puma from 6.0.2 to 6.4.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `rubygems` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

fixtures/dora/Gemfile
fixtures/dora/Gemfile.lock

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

581/1000  Why? Recently disclosed, Has a fix available, CVSS 5.9
HTTP Request Smuggling SNYK-RUBY-PUMA-6146928
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Puma has been updated.


Add more specific 'object' types, including GO Configs

This PR

Updates the Documentation

Describe the changes below:
When I improved the type for TextCreator's config parameter earlier, I noted that some other creators had similar issues, which caused me to look into other places where object is used as a type, specifically in parameters and return types.
I'm not entirely done, I plan on doing a bit more, but so far I think I have covered most of the game object creators. Currently I set the config parameter in ImageCreator and BlitterCreator to accept a SpriteConfig object, since they accept the same config as a sprite. Would it be better to have the types separate, or should SpriteConfig be renamed perhaps?
Also, I noticed a couple of GOs like DOMElement and the shape objects don't seem to have a Creator. Was there any specific reason for this, or just that they weren't really needed? I could probably create them if you want.

Thanks for this - I'm happy to merge it as-is, but could you please fix the merge conflicts first? Looks like some defs for Game Objects no longer part of 3.50 (like Quad).

Sure! I'll have a look at what more I was thinking of doing, and fixing the merge conflicts. Will probably be a week until I have time though, if I don't forget.

I think everything should be in order now. Completed the ParticleEmitterManagerConfig I had left unfinished (and uncommitted), and added a config typedef for Mesh too.

👍


Change test loggers to zaptest

:tickets: Ticket(s): Closes #151

:construction_worker: Changes
This replaces all logger usages with zaptest, which pipes log output to testing.T::Log.
Why? Try debugging this. This change lets test failures only display the logs relevant to a failed test or test case, and makes log output compatible with go test -v.
:flashlight: Testing Instructions
try go test -v, or fail a test on purpose and notice that not every test's output gets dumped out at the same time anymore

this is most relevant to you @suujia !

There's some strange race condition in zaptest - I've opened up https://github.com/uber-go/zap/issues/687 to ask about it

Got an update which would explain the test failure:
https://github.com/uber-go/zap/issues/687#issuecomment-473382859

t.Log is safe for concurrent use, but it's not safe to call t.Log as the test is ending, which I think is causing the race detector to go off. You should make sure that any background goroutines are stopped before the test ends.

jk fixed it as of 4ed6ee7


File open error

Hello!
The following error occurs when I select to open an XOSC file:
osc filename:  /XXX/OpenScenarioEditor/pyesmini/resources/xosc/straight_500m.xosc
disable_ctrls = False , use_viewer =  True , threads =  True , recordFile =
Traceback (most recent call last):
File "OpenScenarioEditor.py", line 462, in openxml
self.gui.load_file(self.xmlfn)
File "/XXX/OpenScenarioEditor/gui_qt.py", line 1122, in load_file
self.reload()
File "/XXX/OpenScenarioEditor/gui_qt.py", line 894, in reload
oscFile=True)
File "/XXX/OpenScenarioEditor/pyesmini/pyesmini/pyesmini.py", line 103, in init
self.se = CDLL(dir_path + "/libesminiLib.so")
File "/XXX/anaconda3/lib/python3.7/ctypes/init.py", line 364, in init
self._handle = _dlopen(self._name, mode)
OSError: /XXX/OpenScenarioEditor/pyesmini/pyesmini/libesminiLib.so: cannot open shared object file: No such file or directory

@yumianhuli2 Can you provide more information on how you run the program and more about the environment?

Hi！
I followed the instructions below:
Building and running on Linux
First clone the repository:
git clone https://github.com/ebadi/OpenScenarioEditor ~/OpenScenarioEditor
To build and run on Ubuntu (tested on 20.04), simply run the following command that automatically downloads Environment Simulator Minimalistic (esmini) , PyEsmini and required resources/dependencies.
cd ~/OpenScenarioEditor
./run.sh
But
My OS is :Ubuntu18.04
Error message is: OSError: /XXX/OpenScenarioEditor/pyesmini/pyesmini/libesminiLib.so: cannot open shared object file: No such file or directory. Maybe because of the lack of this file？
Thank you!

Maybe because of the lack of this file？

Yes, but run.sh clone a repository and build that file automatically. Please first remove pyesmini and report back what is the result of running run.sh

Hi!
If first remove pyesmini
A lot of errors like below:
OSError: /XXX/../OpenScenarioEditor/pyesmini/pyesmini/libesminiLib.so: cannot open shared object file: No such file or directory

Please remove the mentioned directory again and run the following
./run.sh &> log.txt
And upload the file here.

Hi!
The file is here
log.txt

It seems that the pyesmini directory is not removed since I was expecting this line to be executed.
Please run the following and upload the log.txt again:
rm -rf ~/OpenScenarioEditor
git clone https://github.com/ebadi/OpenScenarioEditor ~/OpenScenarioEditor
cd  ~/OpenScenarioEditor
./run.sh &> log.txt

It seems that the pyesmini directory is not removed since I was expecting this line to be executed. Please run the following and upload the log.txt again:
rm -rf ~/OpenScenarioEditor
git clone https://github.com/ebadi/OpenScenarioEditor ~/OpenScenarioEditor
cd  ~/OpenScenarioEditor
./run.sh &> log.txt

Hi!
it worked,But it doesn't seem to be working yet.
log is here
log.txt

the link to the previous C++ repo version?

What do you mean? Which version?
I inspected the log file but found nothing. Let's try these instead:
cd ~
rm -rf ~/OpenScenarioEditor
git clone https://github.com/ebadi/OpenScenarioEditor ~/OpenScenarioEditor  > ~/log0.txt
cd  ~/OpenScenarioEditor
sudo apt install git python3-pip python3-pyqt5  ;     pip3 install PyQt5  > ~/log1.txt
git clone https://github.com/ebadi/pyesmini pyesmini > ~/log2.txt
cd pyesmini ; ./build.sh > ~/log3.txt
python3 OpenScenarioEditor.py > ~/log4.txt

As you see in log3.txt some packages are still not installed. Run these commands to installed all dependence.
sudo apt install build-essential git pkg-config libgl1-mesa-dev libpthread-stubs0-dev libjpeg-dev libxml2-dev libpng-dev libtiff5-dev libgdal-dev libpoppler-dev libdcmtk-dev libgstreamer1.0-dev libgtk2.0-dev libcairo2-dev libpoppler-glib-dev libxrandr-dev libxinerama-dev curl cmake
sudo apt install git python3-pip python3-pyqt5

and try again these commands:
https://github.com/ebadi/OpenScenarioEditor/issues/10#issuecomment-1108087320

Please check /pyesmini/build.sh
1, the tag should be ec2f3e7256c97d32b1a97f0cb8b9bf7f5085bc7e
2, follow https://esmini.github.io/index.html#_build_esmini_quick_guide


Incorrect change of volume

When you change the volume for one speaker, it changes immediately on all connected devices - both on the master and on the slave.

Partially fixed in 128baab


fix(benchpress): update benchpress dependencies and config

Closes #348

Just discussed this with @jeffbcross over Hangouts.. The benchpress fixes required didn't make it into the last release, so we'll need to wait on this for a couple of days.
@jeffbcross, I'm going to close this one for now, until we're able to get a working PR.


android studio   Running failed

I created a new Flutter project.  android studio  Console log:

Error running Gradle:
Exit code 1 from: /Users/haoran1/Desktop/flutter_app/android/gradlew app:properties:
Download https://dl.google.com/dl/android/maven2/com/android/tools/lint/lint-gradle-api/26.1.2/lint-gradle-api-26.1.2.jar

Project evaluation failed including an error in afterEvaluate {}. Run with --stacktrace for details of the afterEvaluate {} error.
FAILURE: Build failed with an exception.

Where:
Build file '/Users/haoran1/Desktop/flutter_app/android/app/build.gradle' line: 25

What went wrong:
A problem occurred evaluating project ':app'.

Could not resolve all files for configuration 'classpath'.
Could not find lint-gradle-api.jar (com.android.tools.lint:lint-gradle-api:26.1.2).
Searched in the following locations:
https://jcenter.bintray.com/com/android/tools/lint/lint-gradle-api/26.1.2/lint-gradle-api-26.1.2.jar

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 50s
Finished with error: Please review your Gradle project setup in the android/ folder.
Logs

Mmmmm-2:flutter_app haoran1$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v0.9.4, on Mac OS X 10.14 18A391, locale zh-Hans-CN)
[!] Android toolchain - develop for Android devices (Android SDK 28.0.1)
✗ Android license status unknown.
[!] iOS toolchain - develop for iOS devices (Xcode 10.0)
✗ ideviceinstaller is not installed; this is used to discover connected iOS devices.
To install, run:
brew install --HEAD libimobiledevice
brew install ideviceinstaller
✗ ios-deploy not installed. To install:
brew install ios-deploy
[✓] Android Studio (version 3.2)
[✓] VS Code (version 1.28.2)
[✓] Connected devices (1 available)
! Doctor found issues in 2 categories.
How should I solve this problem?

I've got the same exact issue.

I've got the same exact issue.

I have solved it.#23404

@370966584 thanks!
Merging with #23404


cdk-describedby-message-container appears twice with SSR / Angular Universal

Bug, feature request, or proposal:
Bug
What is the expected behavior?
For cdk-describedby-message-container to appear only once in DOM
What is the current behavior?
It appears twice; appears first in the SSR-rendered output by Angular Universal, and then again after the SPA has fully loaded.
What are the steps to reproduce?

Create an Angular Universal application with material / CDK
Create component which causes describedby messages to be created
Launch the Universal application

What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular CLI: 6.1.0-rc.0
Node: 10.2.1
OS: win32 x64
Angular: 6.1.0-beta.1
angular-devkit 0.7.0-rc.0
angular/cdk 6.2.1
angular/material 6.2.1
ngtools/webpack                  6.1.0-rc.0
schematics/angular               0.7.0-rc.0
schematics/update                0.7.0-rc.0
rxjs                              6.2.1
typescript                        2.7.2
webpack                           4.9.2
nguniversal/common 6.0.0
nguniversal/express-engine 6.0.0
nguniversal/module-map-ngfactory-loader 6.0.0
Is there anything else we should know?

I have the same behavior on my universal build. The Dailog box shows twice as seen here:

@jelbourn @mmalerba @crisbeto @vivian-hu hey guys, I'll be overwhelmed if i get a reply on this thread. I am using angular universal for SSR and i am still getting this issue. Any help guys?


feat(tag): tag validation pattern for new tag naming rules

to allow select existing too-long name tag (>40 chars)
skip creating of too-long name tag (>40 chars)

resolve #2595

Fixed this issue?
https://user-images.githubusercontent.com/4065233/182564744-e62724d7-8fe0-4ebd-b2f7-78ece6f35656.mov


connection pool doesn't not respect request callback on socket error

Hello,
I've just reported a problem with tedious not calling the request callback when a socket error occurs.
https://github.com/pekim/tedious/issues/324
However, If the above issue was fixed there is still a problem with how the connection pool deals with connection errors.  currently in tedious on a socket error the error event gets emitted before it internally routes to the error state:
https://github.com/pekim/tedious/blob/master/src/connection.js#L485-L487
This means that the error handling in the connection pool will set the state to STATE.FINAL before the correct error handler is run.  This is because the error handler of the connection pool calls .close() on the connection before the the error state has been routed to properly:
https://github.com/pekim/tedious-connection-pool/blob/master/lib/connection-pool.js#L81-L95
    var handleError = function(err) {
        self.log('connection closing because of error');

        connection.removeListener('end', endHandler);
        connection.close(); // <--- because the error event is emitted before the error state is routed this causes the error state always to route to STATE.FINAL

        pooled.status = RETRY;
        pooled.con = undefined;
        if (pooled.timeout)
            clearTimeout(pooled.timeout);

        pooled.timeout = setTimeout(createConnection.bind(self, pooled), self.retryDelay);

        self.emit('error', err);
    };

This issue may not matter except in the future if it's possible to get request callbacks in tedious when a socket error occurs.  I just wanted to make note of this issue.

Hello I have created a pull request to address this issue:
https://github.com/pekim/tedious-connection-pool/pull/24


Payload type unknown when defining optional property?

This is for version 0.8.0.
const action = createAction<{ input?: string }>('ACTION')
type ActionType = ReturnType<typeof action> // ActionType.payload === unknown

const action = createAction<{ input?: string, input2: string }>('ACTION')
type ActionType = ReturnType<typeof action> // ActionType.payload === { input?: string | undefined; input2: string }

Somehow, if there is only one property and it's optional, it converts it type to unknown

Oh dear.
@phryneas , @jessidhia : any ideas?

Phew. Yup.
The feature detection for TS<3.5 was leaking both cases (TS<3.5 and TS>=3.5), exposing the pre-3.5 behaviour.
Back then, we could not distinguish between the empty object default case and unknown, so it would fall back to unknown behaviour if the object looked like an empty object (which is the case here).
We can fix this for TS>=3.5, but in old versions this will be the behaviour if something possibly looks like an empty object.
( fixed TS version feature detection would look like this:
export type AtLeastTS35<True, False> = [True, False][IsUnknown<ReturnType<<T>() => T>, 0, 1>]

)
Question is: is it worth it supporting old TS versions, which should be our minimum requirement? I guess we should still support 3.4, which is from march 2019, even if it hurts a little :/

Yeah, 3.4 seems reasonable to support, even if it's a bit of a pain.

I might be even able to fix it for pre-3.5... PR coming in.

Fix published as 0.8.1.  Hopefully that should resolve this - let us know if there's still an issue!


Using an array for URL breaks the code

Declaring Urls as described here will break the code and cause Error
Current Behavior
Error occurs. You get
Uncaught TypeError: url.match is not a function
    at YouTube.load (YouTube.js:170)
    at Object.onMount (Player.js:83)

Expected Behavior
Player should load both URL and give option to play either (similar to when loading playlist).
Steps to Reproduce
Create player like
<ReactPlayer playing url={['https://www.youtube.com/watch?v=d46Azg3Pm4c', 'https://www.youtube.com/watch?v=eVsXVzSse8I']} />
Environment

Browser: Chrome
Operating system: MacOs 10.15.5

Passing an array to url only applies to file paths, when you want to provide multiple different types for the same video (eg video/webm and video/ogg) to improve cross-browser support.
You can use playerVars to play several Youtube videos as a playlist, although this is not documented and not very obvious:
<ReactPlayer
  url='https://www.youtube.com/watch?v=oUFJJNQGwhk' // First video in playlist
  playing
  controls
  config={{
    playerVars: {
      listType: 'playlist',
      playlist: 'jNgP6d9HraI,_8UJBrnYBW4' // Second and third videos, comma separated
    }
  }}
/>

I suppose it would be nice if ReactPlayer did this automatically for arrays of youtube URLs…


build: Cross-compile to Scala 2.12

Done:

SBT file adapted for cross-compilation
Ambiguities due to Scala 2.12 SAM ambiguity resolved.

To Do:

Make tests succeed
Test doc generation

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: nightscape sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@drdarshan @mhamilton723 a lot of tests are failing because there seem to be missing datasets, possibly/probably caused by this
ERROR: The subscription of 'ce1dee05-8cf6-4ad6-990a-9c80868800ba' doesn't exist in cloud 'AzureCloud'.

I assume this subscription requires permissions to log in and retrieve the datasets, correct?
If so, is there a way I can get the datasets to test locally, or do you have to test this in your environment?

Hey @nightscape thanks so much for this great PR.
Datasets can be downloaded from
https://mmlspark.blob.core.windows.net/installers/datasets-2019-05-02.tgz

/azp run

Hi @mhamilton723, I had a look at the errors in the build, but at first glance I don’t see how they could be caused by the Scala 2.12 switch.
Unfortunately, I’ve been pulled into other topics and can’t spend much more time on this.
Would it be ok to chicken out here?

@nightscape, appreciate you taking it this far. Just rebased on top of some latest test flakiness ixes so well see how it goes :)

/azp run

/azp run

/azp run

For some reason, Github didn't pick up the changes I made to my branch.
Possibly caused by the recent hickups: https://www.githubstatus.com/
Will try changing something and force-pushing again.

@imatiach-msft, the build seems stuck...
Could you trigger it again?
Thank you!

/azp run

done!

@imatiach-msft the build seems to have failed?
Unfortunately I can't see the exact error, only that /bin/bash exited with status 1 which is not very helpful...

/azp run

sorry let me rerun and then I will report the error.  The devops project really needs to be made public as this is unsustainable, external devs need to be able to see the errors... tagging @mhamilton723 .

wow I see tons of build failures everywhere lol
scala_2.12_build_log.txt

seems like a bunch of our dependencies don't have 2.12 versions yet?

@imatiach-msft right. I assume this is a new dependency, afair I had this branch compiling locally before I rebased on master.
Will try to get a 2.12 build for https://github.com/linkedin/isolation-forest

Askes for a 2.12 build here: https://github.com/linkedin/isolation-forest/issues/14

also adding @eisber  for the isolation forest dependency

I wonder if there is some way to make this an optional dependency for now for scala 2.12 build...

@jverbus should be able to help with the dependency. he built the artifacts for spark 2.3.0 vs 2.4.3

@imatiach-msft @eisber I updated to the newly released isolation-forest version for Scala 2.12 (thanks @jverbus !) and rebased on master.
Unfortunately, I don't see any results from the CI run. Does that have to be triggered manually?

/azp run

@eisber unfortunately I still don't see the exact error in the Azure pipeline.
Would you be so kind to paste the relevant parts here?
Thank you!

sorry for the long delay...
Info Provided - Suite ClassBalancerSuite took 4.357s
[info] - yield proper weights
[info] + Test yield proper weights took 0.844s
Info Provided - Shutting down spark session
[info] CacherSuite:
20/06/04 12:10:09 WARN CacheManager: Asked to cache already cached data.
20/06/04 12:10:10 WARN CacheManager: Asked to cache already cached data.
20/06/04 12:10:10 WARN CacheManager: Asked to cache already cached data.
[info] - Serialization Fuzzing
[info]   + Creating a spark session for suite CacherSuite
[info] + Test Serialization Fuzzing took 0.416s
20/06/04 12:10:10 WARN CacheManager: Asked to cache already cached data.
[info] - Experiment Fuzzing
[info] + Test Experiment Fuzzing took 0.002s
20/06/04 12:10:10 WARN CacheManager: Asked to cache already cached data.
[info] - Be the identity operation
[info] + Test Be the identity operation took 0.027s
Info Provided - Suite CacherSuite took 0.445s
Info Provided - Shutting down spark session
[info] SummarizeDataSuite:
20/06/04 12:10:10 WARN Utils: Truncated the string representation of a plan since it was too large. This behavior can be adjusted by setting 'spark.debug.maxToStringFields' in SparkEnv.conf.
[info] - Serialization Fuzzing
[info]   + Creating a spark session for suite SummarizeDataSuite
[info] + Test Serialization Fuzzing took 7.856s
[info] - Experiment Fuzzing
[info] + Test Experiment Fuzzing took 1.413s
[info] - Smoke test for summarizing basic DF - schema transform
[info] + Test Smoke test for summarizing basic DF - schema transform took 0.017s
[info] - Smoke test for summary params
[info] + Test Smoke test for summary params took 0.007s
[info] - Smoke test for summarizing basic DF
[info] + Test Smoke test for summarizing basic DF took 1.611s
[info] - Smoke test for summarizing missings DF
[info] + Test Smoke test for summarizing missings DF took 1.552s
[info] - Smoke test for subset summarizing missings DF
[info] + Test Smoke test for subset summarizing missings DF took 0.47s
Alert Provided - Suite SummarizeDataSuite took 12.926s
Info Provided - Shutting down spark session
[info] RepartitionSuite:
[info] - Serialization Fuzzing
[info]   + Creating a spark session for suite RepartitionSuite
[info] + Test Serialization Fuzzing took 0.389s
[info] - Experiment Fuzzing
[info] + Test Experiment Fuzzing took 0.002s
[info] - Work for several values of n
[info] + Test Work for several values of n took 0.058s
[info] - Should allow a user to set the partitions specifically in pipeline transform
[info] + Test Should allow a user to set the partitions specifically in pipeline transform took 0.058s
Info Provided - Suite RepartitionSuite took 0.507s
Info Provided - Shutting down spark session
[info] BatchIteratorSuite:
ratio: 1.0039155890709441, Batched: 2338ms, normal: 2329ms
[error] Using Spark's default log4j profile: org/apache/spark/log4j-defaults.properties
[error] OpenJDK 64-Bit Server VM warning: You have loaded library /tmp/mml-natives8324893102437100607/libopencv_java320.so which might have disabled stack guard. The VM will try to fix the stack guard now.
[error] It's highly recommended that you fix the library with 'execstack -c ', or link it with '-z noexecstack'.
[info] Could not generate getters and setters for class com.microsoft.ml.spark.automl.BestModel due to no default constructor
[info] Could not generate getters and setters for class com.microsoft.ml.spark.automl.TuneHyperparametersModel due to no default constructor
[info] Could not generate getters and setters for class com.microsoft.ml.spark.featurize.AssembleFeaturesModel due to no default constructor
[info] Could not generate getters and setters for class com.microsoft.ml.spark.featurize.CleanMissingDataModel due to no default constructor
[info] Could not generate getters and setters for class org.apache.spark.ml.PipelineModel due to no default constructor
[info] Could not generate getters and setters for class com.microsoft.ml.spark.featurize.text.TextFeaturizerModel due to no default constructor
[info] Could not generate getters and setters for class com.microsoft.ml.spark.isolationforest.IsolationForestModel due to no default constructor
[info] Could not generate getters and setters for class com.microsoft.ml.spark.lightgbm.LightGBMClassificationModel due to no default constructor
[info] Could not generate getters and setters for class com.microsoft.ml.spark.lightgbm.LightGBMRankerModel due to no default constructor
[info] Could not generate getters and setters for class com.microsoft.ml.spark.lightgbm.LightGBMRegressionModel due to no default constructor
[info] Could not generate getters and setters for class org.apache.spark.ml.PipelineModel due to no default constructor
[info] Could not generate getters and setters for class com.microsoft.ml.spark.stages.TimerModel due to no default constructor
[info] Could not generate getters and setters for class com.microsoft.ml.spark.train.TrainedClassifierModel due to no default constructor
[info] Could not generate getters and setters for class com.microsoft.ml.spark.train.TrainedRegressorModel due to no default constructor

Hmm, the only errors I see are the ones about OpenCV:
[error] Using Spark's default log4j profile: org/apache/spark/log4j-defaults.properties
[error] OpenJDK 64-Bit Server VM warning: You have loaded library /tmp/mml-natives8324893102437100607/libopencv_java320.so which might have disabled stack guard. The VM will try to fix the stack guard now.
[error] It's highly recommended that you fix the library with 'execstack -c ', or link it with '-z noexecstack'.

I honestly don't have any clue what to do with them.
Could anyone from the Azure team take it from here?

@mhamilton723 any inputs on the status , will there be 2.12 support for mmlspark soon?

Any chance to push this forward?

@nightscape a small fix to your branch would be to:
sed -i 's/scala-2.11/scala-2.12/' src/it/scala/com/microsoft/ml/spark/codegen/CodegenConfig.scala

Overall I think this needs to be pushed over the line by someone from the Azure team like @eisber, @imatiach-msft or @mhamilton723.
If someone from the Azure team tells me "Look, make these 3 changes and we'll take it from there", I'd be happy to.
But right now I won't invest more time until there is a commitment to actually get this merged.

@nightscape Thank you for your contribution!
@eisber , @imatiach-msft , @mhamilton723  - We have been using this successfully at ZipRecruiter.
Happy to see this small changes merged.

Hi @imatiach-msft - greetings from Spark-land. I know a few of our customers love mmlspark and would love to use it on Spark 3. I see this and a related PR basically have that working. If I can help review, glad to - they'd love to get it released when you have a moment!

@nightscape  I try to use "sbt clean package" to build mmlspark from this branch and generate a jar file. But I can't use the python API for lightgbm. The error information is "ModuleNotFoundError: No module named 'mmlspark.lightgbm._LightGBMClassifier' ". I estimate my building command is not correct. So what is the correct command to build mmlspark with python API.

@hanbing1587 unfortunately I don't know either...
I just changed the Scala version settings and fixed all compile errors.

related to #912?

related to #912?

Definitely. I have no idea why the other PR got closed though, or why this one doesn't receive any love...
The Open Source part of this repo leaves room for improvement :stuck_out_tongue_closed_eyes:

Definitely. I have no idea why the other PR got closed though, or why this one doesn't receive any love...
The Open Source part of this repo leaves room for improvement :stuck_out_tongue_closed_eyes:

closing as we already support scala 2.12


Add instructions to enable Webpack Hot Reload to SETUP.md

Describe the bug
Information about Webpack is not present in SETUP.md. It needs to be updated.
The new_UI uses webpack to bundle the javascript module and assets. So to see any changes made to the simulator code aka. Hot Reload, on the local server, we need to start the webpack-dev-server.
This can be done by running the command bin/webpack-dev-server .
This instruction needs to be added to the SETUP.md file.
Are you working on this issue? (Yes/No)
No

Hey @sal2701 ,Can I work on this?

Sure @arjungarg07, go ahead.

I have made the changes as requested, Please review @sal2701. Thanks


rx == 0 or ry == 0 ellipse or rectangle can paralyze Cairo port, at least.

During the investigation of my patch for Issue #67, I found my cairo port is paralyzed by the ellipse or rectangles with rx == 0 or ry == 0. I think Skia and CoreGraphics ports are safe from this issue, because they have direct functions to draw ellipse or rounded-rectangle.
Cairo has no direct functions to draw ellipse or rounded-rectangle, so I inserted cairo_scale() to stretch the circle or rounded-corner of the rounded rectangle. Maybe, cairo_scale(cr, 0, scale_y) or cairo_scale(cr, scale_x, 0) and following cairo_arc() makes cairo confused, and all following objects are not drawn correctly.
So, I drafted a patch to replace "rx == 0 or ry == 0 ellipse" by a squashed bounding-box, and to replace "rx == 0 or ry == 0 rounded rectangle" by normal rectangle.
Another option might be "if an ellipse or a rounded-rectangle with rx==0 or ry==0, do not take it as a drawable element". I wish if the experts give some comments on the direction we should go.

If rx and ry are non-zero, like,
<svg xmlns="http://www.w3.org/2000/svg" width="300" height="200" viewBox="0 0 300 200">
  <ellipse cx="150" cy="50" rx="25" ry="25"/>
  <rect x="120" y="120" width="60" height="60" rx="15"  ry="15"/>

  <ellipse cx="50"  cy="50" rx="1" ry="25"/>
  <rect x="20"  y="120" width="60" height="60" rx="1"   ry="15"/>

  <ellipse cx="250" cy="50" rx="50" ry="25"/>
  <rect x="220" y="120" width="60" height="60" rx="150" ry="15"/>
</svg>

The result is looking like

But, if rx == 0, like,
<svg xmlns="http://www.w3.org/2000/svg" width="300" height="200" viewBox="0 0 300 200">
  <ellipse cx="150" cy="50" rx="25" ry="25"/>
  <rect x="120" y="120" width="60" height="60" rx="15"  ry="15"/>

  <ellipse cx="50"  cy="50" rx="0" ry="25"/>
  <rect x="20"  y="120" width="60" height="60" rx="0"   ry="15"/>

  <ellipse cx="250" cy="50" rx="50" ry="25"/>
  <rect x="220" y="120" width="60" height="60" rx="150" ry="15"/>
</svg>

The source at abfb9aac9e14369a6f1ee67a961331c953111639 gives such result.
. You can find the rx == 0 elements (at the left side) are not drawn, and, following elements at the right sides are not drawn at all. It is what I call as "paralyzed".

The source at abfb9aac9e14369a6f1ee67a961331c953111639, including my 2 patches (one for ellipse, another for rounded-rectangle), the result is like this.

The web browsers would show such results.

According to https://svgwg.org/svg2-draft/shapes.html#EllipseElement a value of 0 for either rx or ry disables the rendering of the element. Same for r on circle or width/height on rect.
So we should skip the element if one of the attributes is 0.


https://issues.apache.org/jira/browse/CAMEL-10158

Support to add tags to workflow execution in camel-aws component

Thanks :-)
The PR has been merged, can you close the PR? Also, can you documentation here:
http://camel.apache.org/aws-swf.html
You'll need a signed ICLA with Apache Software Foundation

Sure. I will sign ICLA and wait for the approval before editing the documentation.

Hi @davsclaus can you grant Karma to @ssharma? His username is sidshar
I don't know if I can grant Karma on Confluence.

@ssharma I granted you Karma


feat: new home page

closes: #ISSUE_Number

Change logs

Describe your change clearly, including what problem is being solved or what document is being added or updated.

Contributor's checklist
Here are some reminders before you submit your pull request:

Make sure that your Pull Request has a clear title and commit message. You can take the Git commit template as a reference.
Sign the Contributor License Agreement as prompted for your first-time contribution (One-time setup).
Learn the code contribution and doc contribution guides for better collaboration.
Make sure that your changes deployment preview is successful.
List your communications in the GitHub Issues or Discussions (if has or needed).
Feel free to ask for the @cloudberrydb/doc team or other people to help review and approve.

Now the preview failed, plz update to fix it. Thanks.


In and array contains

This is a PR to a PR, contains fixes to tests.

Sorry, not meant to be created on this repo.

If you decide to contribute this in the future let us know, I'd be happy to review it. :)

@collinjackson There is already a PR for this feature #1405. I sent my PR to thus fork to add on his work. So ya please review that PR once completed. If he doesn't reply I will open it  here.

@rosariopfernandes Can you satisfy the CLA here. The PR that you sent is not functional and you are not keeping up with it. I have added some fix over your PR. This is a feature that a lot of developers are waiting upon. Let's make its way to the stable package version. :-)

@awazgyawali I'd suggest sending this PR to my fork, as you originally intended to.

Great, glad to get you on the thread. i have signed it there too. Lets hope.for the best.

@googlebot I consent.

Amazing @rosariopfernandes . @collinjackson  I think you can start the review process.

Thanks so much for the contribution!
/cc @ditman @hterkelsen - just a heads up that this might require merging as you're federating the plugin

/cc @ditman @hterkelsen - just a heads up that this might require merging as you're federating the plugin

Thanks for the heads up! The code is already inside the plugin subdir, so all should be good. I'll make sure to keep my branches up to date while doing the platform interface and the web version!


Recommendations for large list of strings

Note already asked this in main repo..
I tried to convert my 125 million domains to a unique set of integers but the integer values exceeded the max for 64bit ints. Does anyone know a way to solve this? Maybe something obvious I am not seeing.

Answered in the main repo https://github.com/gvinciguerra/PGM-index/issues/8#issuecomment-743433253 ;)


Tracking Issue for merging cargo-information/cargo info to Cargo

Summary
Rust Internals: https://internals.rust-lang.org/t/feedback-on-cargo-info-to-prepare-it-for-merging/20369
Original issue: https://github.com/rust-lang/cargo/issues/948
Implementation: TBD
Documentation: TBD
We developed 'cargo-information' as a solution for #948
Features:

Works with all registries that are compatible with Cargo
Fetches and displays basic package information (name, version, owners, etc.)
Shows package dependencies and their versions
Provides information about package features

And in the last six months, we have released 8 versions and had 3,428 downloads. At the same time, we have covered almost all the features it needs. So I think it is a good time to merge it back into Cargo and prove it to all Cargo users.
Unresolved Issues

[ ] We want to report some crates.io metrics in this command as well, we will do that after we merge it back into Cargo See: https://github.com/hi-rustin/cargo-information/issues/20
[ ] After the public dependency feature is stable, we should consider what dependencies we want to show in this command. See: https://github.com/hi-rustin/cargo-information/issues/138

Future Extensions
No response
About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

@rustbot claim

Curious, what is the role of this tracking issue.  I'm assuming we can't have this feature be unstable and instead must insta-stable it like cargo add and cargo remove.  At which point, we are just tracking the command being merged which the original issue can handle.  Likely, the tasks listed are not blockers.  This is a UX heavy command and we have a lot of flexibility of adding / removing functionality.

As a hub connecting to other issues? That said, we can create a label Command-info for this purpose.


Dino Catalog refactor

What changed:

Created a "Dino" class and moved matching logic into it
DinoCatalog class now only handles storing/searching the dino database
Moved all printing logic in DinoPrinter
Moved all application level logic into "DinoApp" class
Other cleanup based on previous review

@jmtai: Please close this PR and resubmit with comments from Hound and myself addressed. Also fix the printing of the dinosaur so that it meets the requirements that is listed in the README. Currently when dinosaurs are printed out only the names are printed and not all it's facts.

@incazteca: The printing works as described in the README.  The "print" command will print out all the dino facts after a find command is processed.  The wording in the description was slightly ambiguous so I chose to print a compact result list for the find command, but allow the user to retrieve the full printout manually if desired.

This is looking good.  Take a look at the suggestions and refactor a bit.  I don't think a resubmission is necessary.  Good work!


[TASK] Create Github issue template

Create a issue template.
The template could be shared with other communi projects such as communi-desktop.

Read:
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository


Dissallow same parameter signature in overloads

I think the below overloads are ambiguous:
namespace Greet {
    export function sayHi(): number
    export function sayHi(): string
    export function sayHi(): string | number {
        if (Math.random() > 0.5) {
            return '';
        }
        else {
            return 1;
        }
    }
}

// What
typeof Greet.sayHi(); // What is the type?

Since, we are selecting a return type based on the parameter signature. But, what if the parameter signature is the same on multiple overloads? Nowadays, if the checker cannot find an appropriate overload it takes the first one. I think this is quite an unsafe approach. In the above example, it is clear that sayHi() cannot be narrowed to either string or number based on parameter signature selection, since there is only one parameter signature (), and thus should have the return type string | number only.
What I propose, is to error on the overload that has the same parameter signature:
namespace Greet {
    export function sayHi(): number // Error: Multiple same parameter signature on overload
    export function sayHi(): string // Error: Multiple same parameter signature on overload
    export function sayHi(): string | number {
        if (Math.random() > 0.5) {
            return '';
        }
        else {
            return 1;
        }
    }
}
``

There is something else involving generics:
function sayHi<T extends string>(): T;
function sayHi<T extends object>(): keyof T;
function sayHi(): string { ... }

it can match conditionally by type even without using inference:
sayHi<'a'>(); // 'a'
sayHi<{b: number}>(); // 'b'

If the compiler should enforce that it should keep this behavior intact. Generic constraints contribute identity to the signature.
In other words it should only complain when it sees indistinguishable overloads (overloads ONLY different in their return type). Not having this rule enforced haven't got me into trouble so far though.

I was thinking about type parameter as well, though didn't give an example on it.
paramater signature = type parameter signature + value parameter signature

I think this one is also require for #6606. Since, the following expression is ambiguous:
typeof Greet.sayHi();

https://github.com/Microsoft/TypeScript/issues/13225 is in similar vein.

Just for your information, the proposed behavior is implemented in pre TS1.1. But it is removed in later releases.
http://stackoverflow.com/questions/25022331/overloads-cannot-differ-only-by-return-type
Also, the spec disallow same parameter signature in ambient function declaration.

Duplicate of https://github.com/Microsoft/TypeScript/issues/13225


dead links

why not just take it down?

Are the links ok now?

https://github.com/alpinelinux/alpine-netboot/blob/master/alpine-ipxe/x86_64/ipxe.lkrn

but I eventually found what I was looking for on the original site anyway :P

@paigeadelethompson have you a link?


MRG, FIX: Fix volume morph with multiple labels

See latest.inc, basically only the first volume label would be interpolated when morphing a source space with multiple subvolumes and using mri_resolution=True.
This was found while working toward fixing #7564, so this has a bunch of stubs where support for 'mixed' will eventually need to be added (it actually doesn't look so bad!).

thanks @larsoner


Diagram for project-edition-scene activity

Pure3D data is organised by project, then by edition, then by scene.
An edition consists of one 3D model, i.e. one .glb or .gltf file with 3D data, plus 1 or more accompanying scene files.
Scenes are json files that reflect the initial point of view in a model, but it can also have annotations and metadata of tours, overlays and articles.
We need a detailed view of what to display on project pages, edition pages, and scene pages.
Here is a coarse screenshot of an edition page:

Here you see just one scene and below you see buttons to open the scene in a variety of viewers (here just voyager) and in a variety of versions per viewer. And, if the user is authorised, (s)he can launch the viewer in edit mode by means of the update button.
Questions to be answered:

Which information to show on the right? Specify for project/edition/scene pages?
Which (summarized) project information do we display on edition and scene pages?
Which (summarized) edition information do we display on scene pages?
Do we provide links to the articles in order to view them outside any 3d viewer? We could make the articles folder navigable.

Questions about editing:

How should an editing user end an editing session? We could add a button [Save and quit editing].
If a user wants to edit a scene, but there is already an editing session open for that scene, should we inform the user of the name of the current editor?

Costas, Susan, can we assign this issue to you?

For the other question, we will need some time to work on this. To some extend this comes out of our wireframes, but we will need to work a bit more on this.

I noticed that if you have a voyager-story open with unsaved changes and you want to leave the page, you get already a message. Very good of voyager!

Concerning the other questions:
here is a case where it is easy to overspecify. You can also wait a little, see the evolving backbone, discover its opportunities, and then steer more precisely what information you want to have were.
You could use screenshots of the backbone, use them as wireframes, and annotate them with the things you want to have changed.

We are working hard to get the backbone published on the acceptance server, so that you have the means to do the above.


NSError as a result of validation

NSError as result of validation methods will help find out what directly wrong with JSON

yay! this is a really important feature! thanks :)
My only requests -  is they any way you could base it on the develop branch, there are a couple of changes on there that might affect this. It should hopefully be a matter of rebasing and modifying a couple of methods.... if it's more than that let me know.

Done. Merge 'master' with 'develop' branch

https://github.com/samskiter/KiteJSONValidator/pull/10


Update the sql file for the model selection

Update the sql file for the model selection

merged using #1136


Adding O8S timeline syncs

The diff may not be super useful, so I'll summarize the changes (beyond simply adding syncs). My group got to 1389 on this, so up to that is script-generated, past that is hand-made from fflogs. Preserved your existing naming for the most part.

Added the Thunder/Fire hits of Celestriad
Fixed some slight +/- 1s timing issues
Added all non-starstrafe Soaks (The Path of Light, renamed for clarity), since they were included, albeit inconsistently, later on in the fight. Having specific timing for them is useful for dodging into it.
Added All Things Ending to Past/Future End during Starstrafe. The ATE cast on the normal ones is fast enough (3s) that it's not worth timing it, but there's a bigger gap in that one (8s).
Also added Meteor hit (the stack) during Starstrafe
Added some missing Ultimas (1328, 1358, 1543)
Added a missing Ultimate Embrace (1364)
Changed tether times to activation rather than appearance

This is untested so far. I go in again on Friday, I just wanted to put it up now in case there's anything glaring

Tested it out tonight, worked well as far as we saw (end of third forsaken).
Longest pull is here: https://www.twitch.tv/videos/234577658?t=2h20m42s

Dang it, I forgot to try this myself tonight.  Let me know if you're able to give this timeline a test all the way through and then I'll be happy to merge it.  I feel like the existing one does pretty well, so mostly just want to give a new one a smoke test before changing it.

Tested it all the way through: https://www.twitch.tv/videos/237540234
Log: https://www.fflogs.com/reports/VQ1G82gczRJyCL9Y/#fight=14
There was some weirdness right at the end:
OnSync: 1590 (prev: 1590.107) (this ultima synced correctly)
OnSync: 1597 (prev: 1595.377)
OnSync: 1598 (prev: 1597.733)
OnSync: 1632 (prev: 1632.843)

The corresponding events don't really line up very well:
00:09:55.196 | Kefka 1 Ultima
00:10:00.714 | Graven Image 4 casts Intemperate Will |
00:10:01.560 | Kefka 1 casts Wings Of Destruction
00:10:36.219 | Kefka 1 begins casting Light Of Judgment

I decided to take out the Graven sync, since it's a separate unit and runs on a different timer, even though the earlier tether syncs were more or less right on the mark. The fact that one synced from .377 and the next synced from .733 indicates that the real boss is still operating on whole-second units. I bumped up the timeline since 09:55.196 to 00:10:01.560 is rightly a 6 second gap with rounding.
I also discovered that the ending Ultima crescendo is a different ability ID, so I fixed that as well. The last line was likely just the drift from not having synced in a while.

Congrats on the clear! Thanks again for the testing and all the timeline additions.  I'll go ahead and merge this.
Also, I wonder if the last ultimas are different because it gives a buff and isn't just damage on its own.


Allow custom events

I'd like to get some opinions on this...  I'm not sure if this is CommonWeb's problem to solve, or not.
CommonWeb kind of abstracts away the idea of what tracking backend you are using, so it's not entirely clear how I can track things that don't fall under the CommonWeb umbrella (ie: someone entered failed CC details into stripe checkout).
I know I could technically access the Keen client by digging through the internals of CommonWeb, but that's brittle and not ideal.
It might be nice to have a function like CommonWeb.customEvent, that essentially just wraps CommonWeb.Callback. Perhaps it would also merge in the global properties.

Yeah, I think custom events make sense here. The main benefit of going through CW instead of direct-to-keen is all the CW data model goodness you get to keep.

Interface could be something simple like:
CommonWeb.trackCustomEvent("click", $(".thing"), { "moar" : "properties" });

Or, like I think you were saying, just give access to a function that logs an event through CW and takes the properties you want to include:
$(".thing").click(function (event) { CommonWeb.sendCustomEvent({ "moar" : "properties" }});

Seems like offering both options wouldn't be too hard.

That trackCustomEvent interface seems a little weird. I get what you're going for, but it seems pretty verbose for what we want to achieve.
I'm not sure if this is better, because it's kind of non-standard for javascript, but it might be more readable:
$('.thing').on('click', CommonWeb.customEvent({ "moar" : "properties" }));

That would essentially just return an bound instance of CommonWeb.sendCustomEvent. This has the added benefit of not being so intertwined with jQuery - CommonWeb.customEvent() could be passed as the callback for any sort of event handler.
Thoughts?

Like it.
On Thu, Mar 5, 2015 at 1:50 PM, Joe Wegner<EMAIL_ADDRESS>wrote:

That trackCustomEvent interface seems a little weird. I get what you're going for, but it seems pretty verbose for what we want to achieve.
I'm not sure if this is better, because it's kind of non-standard for javascript, but it might be more readable:
$('.thing').on('click', CommonWeb.customEvent({ "moar" : "properties" }));

That would essentially just return an bound instance of CommonWeb.sendCustomEvent. This has the added benefit of not being so intertwined with jQuery - CommonWeb.customEvent() could be passed as the callback for any sort of event handler.
Thoughts?
Reply to this email directly or view it on GitHub:
https://github.com/keen/common-web/issues/15#issuecomment-77437850

@josephwegner, was anyone able to get this done?
This would be a really cool feature.


can't replicate results

It seems it was introduce by the PR #1 by @Franzsardoma . Instead of reverting it, i pulled the threashold much higher. I'm not sure if this is the correct way, but for now it should work. Here's the change i made: https://github.com/arakis/Net3dBool/commit/19a16a5f43d54e0f0b360dcfee30181298d60fa8
@Franzsardoma @wtaisto any idea?


How do I make it yank to system clipboard by default?

It works correctly when I e.g. copy a line: "+yy
Then I can successfully paste into other applications.
However I want to copy with just yy, without having to specify the + buffer every time. How do I achieve that?
I've tried adding to my .vimrc file: ":set clipboard=unnamedplus". My understanding is that it should use the "+" buffer by default when I do that. However it does not work.

That behavior wasn't implemented yet. The unnamedplus branch in #14 should do it -- can you try that out for me?

I have switched to this branch and now it works!
I have also changed plugin code to call "wl-copy --primary", so now it works exactly as I want - I can paste with middle click.
Thank you for swift help!

I merged that branch, so you should be able to go back to master now. I also added a new commit to master that lets you pass extra arguments to wl-copy and wl-paste. That should let you pass --primary without modifying the script. It's documented in the README.


Fix incorrect path cropping in RequestShortener

Fix https://github.com/webpack/webpack/issues/9764

What kind of change does this PR introduce?
bugfix

Does this PR introduce a breaking change?
No

Yes, I need some time to understand CI problem
And then I can add tests

@evilebottnawi Add unit tests for RequestShortener

/cc @sokra

Thanks


FunC cannot compile try-catch that always returns

Compilation of the following contract
contract TryCatchTester {
    get fun testTryCatch(): Int {
        try {
            throw(101);
        } catch (e) {
            return e;
        }
    }
}

fails with

Func compilation error: /Users/anton_1/ton/tact/contract-throw/throw_TryCatchTester.code.fc:25:1: error: previous function return type (tuple, int) cannot be unified with implicit end-of-block return type (): cannot unify type () with (tuple, int)
}

To me it looks like a FunC issue. As a workaround, one can add something like nativeThrowUnless(1111111, false) after the try-catch statement: Tact's return reachability analysis won't complain and FunC is happy to compile the program with unreachable code.

I guess we can append a return statement filled with null() values to the very end of each function, but I don't like this idea

@anton-trunov have a look at this strange behaviour from FunC:
((int), int) $TryCatchTester$_fun_testTryCatch2((int) $self) impure inline_ref {
    var (($self'counter)) = $self;
    try {
        throw_if(101, true);
        return (($self'counter), 42);
    } catch (_, $e) {
        return (($self'counter), $e);
    }
    return ();

    ;; warning: unreachable code
}

((int), int) $TryCatchTester$_fun_testTryCatch2((int) $self) impure inline_ref {
    var (($self'counter)) = $self;
    try {
        throw_if(101, true);
        return (($self'counter), 42);
    } catch (_, $e) {
        return (($self'counter), $e);
    }

    ;; error: previous function return type (int, int) cannot be unified with implicit end-of-block return type (): cannot unify type () with (int, int)
}

@Gusarich Can you please open an issue about this here: https://github.com/ton-blockchain/ton/issues?

oh, my bad. copied the wrong function.
the error was thrown for this one:
((int), int) $TryCatchTester$_fun_testTryCatch4((int) $self) impure inline_ref {
    var (($self'counter)) = $self;
    try {
        throw(101);
    } catch (_, $e) {
        return (($self'counter), $e);
    }
}

basically the same one you originally noticed. it happens because there's no return in try block.

got it
I reported it here: https://github.com/ton-blockchain/ton/issues/1056 (although I already did that unofficially)


Unit builder leaves fourth materia slot empty in some situations

The unit builder appears to sometimes leave the fourth materia slot empty when optimizing a build.  I haven't pinned down the exact conditions to trigger it, and I believe I have only noticed it so far for the JP version.  When it does happen, however, it is consistent (that is, it still happens after retrying to rerun the optimizer), and if I manually set a materia in that final slot (but not pin it), even one that improves the build, the optimizer removes it when it is next run.  If I do pin the item in the fourth slot and re-run the optimizer, it leaves the third materia slot empty.
This bug does not happen when I turn off "use new JP formula." (It is on by default.)
I'm wondering if this might be related to the issue in #259.  However, the builds the optimizer creates for me already use Genji Glove to obtain dual wield.
Example: Trying to optimize Seabreeze Dark Fina 7*'s magic damage, using only equipment I own (all other settings at their default value; it also happens if I allow the builder to use all items.) If I have the builder use farmable TMRs, it does populate the fourth materia slot.
Builder URL: http://ffbeEquip.com/builder.html?server=JP#07d79d10-d87e-11e8-934b-6988b23621bf

Using the fewest slot possible is part of the optimization process. It allows to easilly further customize the build, with a killer for instance. It should however only happens if it cannot add anything to that 4th slot to improve the build. Is that the case here ?

No, that's not the case here.  I can easily add additional materia to increase the build goal.  After playing around with the builder some more, it appears the major issue is when the "Use new JP damage formula" setting is on.  The builds in my initial comment were for magic damage builds (though I thought the new JP damage formula only applied to physical damage, but it has an effect on magical damage in FFBEEquip), but I can also recreate the issue with physical damage under some situations.
For example: Unit is Randi 7*; maximize physical damage multicast; use my equipment (with or without farmable TMRs).  If I have no additional item bans or pinned items, it looks to be ok: with new JP formula / without new JP formula (same items, actually).
If I then pin the weapon to be my enchanted Mana Sword, I get an empty materia slot with the new JP formula: with / without.  For the build using the new formula, I could fill in anything that gives ATK in the last materia slot to increase the build goal calculated value: example.

An additional observation: I've only been able to recreate this bug (so far) while using my own units and equipment.  If I use all items instead, the builder works as expected.  I'm attaching my exported unit and item lists (but given .txt extensions since GitHub refuses to attach .csv files), but without #282, I don't think it'll be of much help. (It also looks like the exported item list doesn't include item world enchantments, so that might cause issues recreating the bug.)
FFBE_Equip - Unit collection.csv.txt
FFBE_Equip - Equipment.csv.txt


Curios integration

While this is only my personal opinion, I would suggest adding new dedicated curios slots for the various wireless grids (or several of a generic slot for them), with a unique icon. There are a lot of mods out there with curios integration that make use of the generic 'curio' slot, meaning it often forces an unfair choice onto the player.
An alternative would be to 'force' extra generic 'curio' slots onto players, though this could lead to confusion for some, especially server admins/modpack authors when planning how many slots of what type to enable.


fix: maintain whitespace around templated values

I noticed while following the docs (specifically https://templ.guide/syntax-and-usage/expressions) that for the following template:
package main

templ greet(prefix string, p Person) {

{ prefix } { p.Name }{ exclamation }

}

The whitespace between {prefix} and {p.Name} is not preserved.  This is an attempt to fix that.

You're absolutely right. Good spot, thanks for that! I checked and saw that people have been putting in   at work.
This is much better!

I took a look at this yesterday, it does look great, but I realised that the templ fmt removes whitespace between templated values, so I wanted to think about this change and if/how it interacts with templ fmt, hence the pause.
There's an open issue around the formatting behaviour which I need to revisit. I've had a few attempts at it, but haven't managed to get something I'm 100% happy with yet.
From discussion with @joerdav, I think the way we might go with formatting is simply to add additional indentation where it's missing, but do nothing more than that - i.e. no whitespace removal, and then on generation, normalise whitespace according to HTML rules (i.e. collapse runs of whitespace down to a single space).

My thought would be that formatting should remove extra whitespace where it's found, but leave a single character of whitespace. This is so there's no differences between the formatted template, and what gets generated.  Just my two cents.

@noaoh the difficulty being that it seems everyone wants to format their HTML differently in templ, some want all their elements to be displayed on new lines similar to prettier, others want some elements to be inlined and not others.
So I think the best medium is that templ fmt doesn't destroy any whitespace, but maybe can add some in cases where the intent is obvious, like turning the following into a block element:

hello

    hello

Great job, thanks for sorting that out - it's much appreciated.
The formatting changes were just fixed, and this PR worked perfectly in conjunction.


Cannot find file

I just installed VisualRust into vs2013 (Windows 10) and created a test executable project. The code of main.rs is unchanged from the initial "hello, world" printing. When I click run I get the following error:
Error	1	The system cannot find the file specified
   at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
   at System.Diagnostics.Process.Start()
   at VisualRust.Build.Rustc.ExecuteInner()	C:\Program Files (x86)\MSBuild\VisualRust\VisualRust.Rust.targets	53	5	Test

I have rustc installed and in my path. Running rustc -V gets me this:

PS C:\Users\Martin> rustc -V
rustc 1.3.0-beta.1 (dc12f5ee1 2015-08-06)

I'm not certain if it is relevant, but running cargo -V gets me:

PS C:\Users\Martin> cargo -V
cargo 0.4.0-nightly (553b363 2015-08-03) (built 2015-08-03)

@martindevans, can you check your registry settings, as described in #187? Just want to confirm it is the root cause, so that we can fix properly.

Yep, this is a duplicate of that other issue. I had an old rust in the registry, deleting that fixed the issue.

Closing as duplicate of #187


MSAA render targets resolve too many times

By default render targets are created with autoResolve true.
This results in many unnecessary resolves due to forwardRenderer calling updateEnd on the device for every rendered layer, which itself autoResolves render targets.
Ideally render targets would be resolved automatically only when they are:

dirty
about to be used as a texture in a rendering operation

When multi-sampled RTs are used, there could be multiple resolves taking place.
The automatic resolve takes place inside device.updateEnd(), which gets called by:

forward renderer at the end of each layer (this is to support RT being set on a layer, which is not officially supported, but still works). At the very least it should not be called when layer has no meshes and does not clear.
By drawQuadWithShader functions. Those are possibly executing resolves for each time a quad is rendered, which could be an issue if more quads are rendered to a single RT

related to https://github.com/playcanvas/model-viewer/pull/174

related https://github.com/playcanvas/engine/issues/2396

Another thing: the current implementation of resolve doesn't check first whether the render target is actually multisampled before invoking the gl function. We must either only resolve RT when _samples > 1 or expose _samples so user can do the same.

We must either only resolve RT when _samples > 1

Done locally, nice one! PR later with other fixes.

closing down, as this issue has been addressed by #4317


Video end callback

Please add video callback to detect when video has ended

  /// Video end callback, change the video in this callback.   Function? onVideoEnd;
There is a video end callback named 'onVideoEnd' in the FlickManager.

Seen. Thank you. I have another question which is not related to this topic but is there a way I can pre-burfer videos in a listview builder before they are shown on screen?

Currently, we don't have caching setup. So it's not supported yet.


Typescript error when importing in ES6 style

When trying to import vee-validate in the main.ts file of a TypeScript-forced project like import VeeValidate from 'vee-validate', an error like the follows is emitted:
TS1192: Module '"path_to_project/node_modules/vee-validate/types/index"' has no default export.
Changing the import to import * as VeeValidate from 'vee-validate' vanishes the error.
FYI.

Thanks for reporting this.


Question

If I want to change clean/noisy_trainset/testset_wav. What should I need to notice?

Could you give me some advice?

If I want to use 44100Hz, how to change layers?

It is actually a bit of an open question. Right now the input sample size is 214 which is roughly 1 second of data for 16kHz sampled audio. For 44.1kHz, if you use the same number of samples (214 samples), it will be roughly 0.35 seconds.
You have two options to begin with:

stick to 2*14 samples for 44.1kHz audio. This would make your operating window to roughly 0.35 seconds. And train your model.
if you want to use the same 1s operating window, then you will need a much bigger sample size (may be 2**16 samples). With this you could run into GPU memory issues as well.

So I would suggest to start with option 1. Then you will also need longer filters, right now it is 31. As a rule of thump, scale it by a factor of (44.1k/16k). Then only you will get similar frequency resolution for your filters.
The performance may not be comparable to the current model which uses 1s window since in your approach you are operating at ~0.35s window.

I used my data which is 1 second and changed it to 16kHz from 44100hz with the tool "sox". I guess this process will change the data's feature a lot??
If I use stride 3, I just need 310. Will it better than 216?? Or this will cut more features make it worse than before?
I will get 0.35 seconds, if I still use 2**14 for 44.1kHz. What it will be got in 0.35 seconds? Will it get the data from 0 seconds to 0.35 seconds, or choose the data in random size from 0 seconds to 1 seconds?

You will need to prepare your data accordingly and feed it to the model. You can use prepare_data.py as a starting point and then make your changes.
In this dataset also, it was originally 44.1kHz and was downsampled to 16kHz. If it is only speech, then 16kHz is enough.

What's the meaning of making the 'clean_test_segan1d.mat'? I don't see the program has used it.

I used sox -b 16 -r 16000 to change my data but it sounds a little bit different from before.

How much data should I prepare?

It depends on how much training data you have. More data is always better.

I am not sure I understand your use-case. May be you may not need something complex like this for your task. May be it would be better to use some simpler speech enhancement or noise suppression system for your task.

I saw the example clean_testset_wav is like the first pircture. But my noisy_testset_wav is like the second picture.
Why their sample encoding and bit rate are different?

Which python library did you use to measure the data? (pesq, stoi, cd ...)

I used different tools for measuring the quality. Regarding your previous question, I think you are looking at different wav files. The duration also is mismatched. Did you listen to both wav files and are you sure they are the same?

Can you share the tools?
Now my lighter files after testing can denoise correctly. But the output "Precision" and "Sample Encoding" are different from your example files. So I want to know. Why my files are wrong after testing?
I used your example files to run the training and testing is the same as your clean_testset_wavs.
Here are my training file and testing file.

And this is my output file.


Added Mathematics Society of The University of Waterloo

The Mathematics Society of The University of Waterloo is a society
for undergraduate math students at the school.
Students within the society have email addresses at the
mathsoc.uwaterloo.ca subdomain.
cc @DrTeePot, President of the UWaterloo Mathematics Society.

Thanks!


Reliable way of getting video and audio containing formats from JSON

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2022.06.29 (update instructions) or later (specify commit)
[X] I've searched the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
I am currently working on the ytdl_hook from mpv.
It runs yt-dlp with -J and then parses the JSON.
Currently it just assumes that everything that doesn't have a vcodec set (== null or == 'none') is an audio format. The problem with that is that things like storyboards from YouTube also get recognized as audio formats.
The README says:

ba, bestaudio: Select the best quality audio-only format.  Equivalent to best*[vcodec=none]

Indicating that logic to be true.
But the README also says:

ba*,  bestaudio*:  Select  the  best  quality  format  that  contains  audio.  It may also contain video.  Equivalent to best*[acodec!=none]

Implying that all formats that have audio are guaranteed to have acodec != null and acodec != 'none'.
The README however never states that != null and != none are guaranteed for vcodec or acodec if the format contains video or audio respectively.
Is there a reliable way of getting all the formats containing video and all the formats containing audio without also getting any other formats (e.g. storyboards from YouTube) from the JSON?
P.S. I'm not a native english speaker, so maybe I'm wrong on this.
The README contains

b*, best*: Select the best quality format that contains either a video or an audio

but I think the word 'either' indicates xor, where as this should be a logical or. I suggest changing it to 'video and/or audio' to make it less ambiguous.
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

if acodec!='none', the format has an audio. Similar for video
Eg:
video-only = vcodec!='none' && acodec=='none'
audio-only = vcodec=='none' && acodec!='none'
pre-merged = vcodec!='none' && acodec!='none'
storyboard = vcodec=='none' && acodec=='none'
PS: null represents that we don't know what the codec is, and is not the same as 'none'

Don't close the issue. I'll take a look at your suggestions about the README later

Wow that was fast, thank you.

I just tested it, and unfortunately this still recognizes non video formats from this json as videos. But I guess that just means that yt-dlp just doesn't know that they are not videos.
As a solution to that, I ended up also checking resolution != null and resolution != "audio only", but I guess that wouldn't be a good general solution then.

According to the json given in the issue, yt-dlp thinks they are videos. But I cannot reproduce their result and would need more info to say what exactly is hapenning


[Feature Request]: Convert BASE64 to PDF

Feature Description
We store some images and archives in base64 inside a database, and we need to convert to PDF this files manually.
It will be awesome if Stirling could convert the files, and provide an API to this.
Why is this feature valuable?
No response
Suggested Implementation
Some documentations: https://base64.guru/converter/decode/pdf
Additional Information
No response
No Duplicate of the Feature

[X] I have verified that there are no existing features requests similar to my request.

Is this a PDF file which was converted to Base64 at some point?
So the file itself is a fully valid PDF file just encoded to Base64?
This seems like a very niche feature that I cant see applicable to many users, Why was this converted to Base64 in first place, what was the usecase?

Is this a PDF file which was converted to Base64 at some point? So the file itself is a fully valid PDF file just encoded to Base64?
This seems like a very niche feature that I cant see applicable to many users, Why was this converted to Base64 in first place, what was the usecase?

Hi, could you assign this issue to me? I’d like to work on it.

Is this a PDF file which was converted to Base64 at some point? So the file itself is a fully valid PDF file just encoded to Base64?
This seems like a very niche feature that I cant see applicable to many users, Why was this converted to Base64 in first place, what was the usecase?

Hello,
We convert PDFs to base64 to store them "as text" in a database, then we need to decript to see the content of the PDF.

Is this a PDF file which was converted to Base64 at some point? So the file itself is a fully valid PDF file just encoded to Base64?
This seems like a very niche feature that I cant see applicable to many users, Why was this converted to Base64 in first place, what was the usecase?

Hello,
We convert PDFs to base64 to store them "as text" in a database, then we need to decript to see the content of the PDF.

Why not just decode the PDF the same way it was encoded?

@PingLin8888 maybe this is your solutions: https://it-tools.tech/base64-file-converter
As this is a not a non-technical-user issue, i can understand why it should not be added.


fixed possible panic if token is malformed

A panic occurs due to the Valid() method call on a non initialized token object if the token signature is malformed.

Thanks for the contribution.  I haven't had a chance to look at it in detail but I can see already where the possible panic occurs.  What about removing the check on token.Valid?  Does an expired but otherwise cryptographically valid token also return an error?  I haven't looked at the jwt-go source yet, but I'll take a look before merging this.

You are welcome. If the token is invalid the error field is not nil and contains an ValidationError with the related error flag ValidationErrorSignatureInvalid. See https://github.com/dgrijalva/jwt-go/blob/master/parser.go#L122.  There you can see that the error field is only nil if the token passed the validation.

any news on this?


All values in "users_in_photo" are undefined?

Okay so I'm using the following filter:
filter: function(image){
    image.taggedUsers = "";
    for(var i = 0; i<image.users_in_photo.length; i++) {
        image.taggedUsers += image.users_in_photo[i].username + ", ";
    }
    return image.users_in_photo.length>0;
}

So basically I generate a string containing the usernames of all users_in_photo.
However, the string that is created always contains "undefined, undefined, etc" Now, the array I'm getting for users_in_photo does contain the correct number of users, because there is always the correct number of "undefined"s in the string created based on how many people are tagged in the photo.
I've tried this with username, profile_picture, id, and full_name, and they all are undefined. So either I'm accessing them incorrectly or they aren't being pulled from the API.
Any thoughts?

@nwsm I believe you want this:
filter: function(image){
    image.taggedUsers = "";
    for(var i = 0; i<image.users_in_photo.length; i++) {
        image.taggedUsers += image.users_in_photo[i].user.username + ", ";
    }
    return image.users_in_photo.length>0;
}

The username is under the user object in each entry:
"users_in_photo": [{
    "user": {
        "username": "kevin",
        "full_name": "Kevin S",
        "id": "3",
        "profile_picture": "..."
    },
    "position": {
        "x": 0.315,
        "y": 0.9111
    }
}]

Ahhh I see. This is working as intended, thank you.


Please support accessing Home Assistant via TLS

Hello
Many thanks for creating this bridge. It's such a great feature for local control. I look forward to seeing it developed to become the defacto Matter bridge solution for HASS.
Please consider implementing TLS support for accessing HASS (Home Assistant)

Thanks for your feedback.
Can you provide more details?
I am using a library created by home assistant to connect to home assistant. This library seems to support https/wss.
Did you get any error message? Can you provide an error log? Did you use a custom self signed certificate for home assistant?

Thank you for the prompt response.
Yes I have HASS behind Traefik and I access it via https (443). When I tried to configure Matterbridge to connect to https://homeassistant.home.lan it simply failed with error:
Failed to start plugin matterbridge-home-assistant: 1

I think I should add an option to set the log level in the dockerfile to show more details.
It seems that you are using a self signed certificate. Those certs are never accepted by anyone. You would need to either (1) disable ssl checks for the docker container or (2) add your own cert to the trust store.

try setting the env variable NODE_TLS_REJECT_UNAUTHORIZED=0. But i am not sure if the ws library considers this variable.

you could try to mount your custom cert to any path in the container (e.g. /cert) and set the environment variable NODE_EXTRA_CA_CERTS to match the cert file path (e.g. /cert/my-cert).

please tell me if any of those worked.
In generell this is not a problem with matterbridge or matterbridge-home-assistant, but I’ll add a FAQ when we got it working with your setup.

Adding NODE_TLS_REJECT_UNAUTHORIZED=0 has done the trick. I'm connected via Traefik just fine now. Thank you

Okay 👌🏼 thank you for the feedback. I’ll add some hint to the readme or an extra faq page.
just to have it mentioned:
Setting the NODE_TLS_REJECT_UNAUTHORIZED variable, completely disables SSL verification for node.js. This is not recommended and definitely a security issue (man in the middle attacks are possible if they have access to your local network).
Actually it is nearly as bad as having no ssl at all. In some cases of local communication it’s fine to do - if you know what you are doing.
It is always better to tell the application about the self signed certificate it should trust. With that no man in the middle attack would be possible. On the other hand you need to do extra steps to configure that properly (option 2 of my previous post).


feat(scaffolder): port Bitbucket Server PR action to Bitbucket Cloud

This PR ports the Bitbucket Server PR action to Bitbucket Cloud.
The goal was to stay as close to the original code as possible for consistency, so some parts of the code might not be the most elegant, but maybe that's something that should be cleaned up in both actions in another PR.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] All your commits have a Signed-off-by line in the message. (more info)

@acierto as mentioned in the description, most of the code (including the lines you commented on) are a straight copy from the Bitbucket Server version. Is this something we want to fix now? I was thinking maybe this should happen in a separate PR for both Bitbucket Cloud and Bitbucket Server.

@benjdlambert  wdyt?


Pad function wrap mode

Relates to #57672
I've added wrap padding as an option to the pad function. Much of the code I carried over from the MirrorPad op. The main difference between the two implementations is the ToInputCoord function:
https://github.com/mattbahr/tensorflow/blob/4833ab97fc7cbdabef6be49d621084930800c4a8/tensorflow/core/kernels/wrap_pad_op.h#L273-L284
https://github.com/tensorflow/tensorflow/blob/3abf81fad44f809d6607165b0907d5dd1e0c8b46/tensorflow/core/kernels/image/mirror_pad_op.h#L284-L295
An alternative to this solution could be to update the MirrorPad op to handle WRAP mode on top of REFLECT and SYMMETRIC. This would eliminate the duplicated code and not require the maintenance of a brand new op, but I wasn't sure if that might be increasing the scope of that op beyond what it should be.
This implementation works as is on CPU and GPU. I haven't gotten to TPU or XLA yet.
See the NumPy documentation for how padding should work in wrap mode: https://numpy.org/doc/stable/reference/generated/numpy.pad.html

Hi @cantonios Can you please review this PR? Thank you .

Hi @jsmeredith , Can you please review this PR? Thank you

Hi @jsmeredith , Can you please review this PR? Thank you

Hi @jsmeredith , Can you please review this PR? Thank you

Hi @jsmeredith , Can you please review this PR? Thank you

Hi @jsmeredith , Can you please review this PR? Thank you

Hi @jsmeredith , Can you please review this PR? Thank you

Hi @jsmeredith , Can you please review this PR? Thank you

Hi @rdzhabarov , Can you kindly review this PR? Thank you!


Allow encoding of attributes to automatically fetch values without knowing separator or position

This is still work in progress but just thought I'd put up what I got so far to see if there is any interest.
I was looking at using the encode feature to reduce attributes and have their values fetched from value template attributes.
The issue I had was I have two delimiters # and :, I use the # to denote the next following is an ID and then I use : for everything else.
Example:
Account#${accountId}:Company#${companyId}:Product#${productId}:Batch#${batchId}

With the existing functionality this would not work with encode.
I wondered if it was possible to automatically get attribute values based on the template and the field name.
So this is what I have so far. The way it would work is it would switch to "auto" mode if you don't define a delimiter and position in the encode param but just give the attribute that has the value template.
Of course this would need careful use, for example if your template was ${id}-${anotherId}-${andAnotherId} and all 3 IDs were UUIDs then it would probably return the wrong values as the - everywhere would cause problems with identifying where one placeholder ends and one starts. So it would be up to the developer to make sure they understood the limitations of this and planned accordingly.
I still need to:

test thoroughly with some real data in a table
improve the regex in the getValueFromTemplate method
add more unit tests for the getValueFromTemplate method

Would appreciate any early feedback on:

are you even interested in this
is the utils.js file the right place to put the method (I first put it on Model class but was difficult to unit test)
my regex-fu is pretty bad, any advice to improving the regex in the method (think it's too restrictive right now)

Already found that this fails completely when the separators between placeholders is always the same (e.g ${accountId}#${companyId}#${productId}#${batchId}). Looking to see if there is anyway I can support that but this seems like exactly the sort of case the existing encode functionality would be perfect for.

So I realised that the way I was doing it would probably just cause headaches. I've added a new method getValuesFromTemplate with tests gets all the values from a template and it's value.
This seems more robust, the only issue is if you're using simple delimiters and the values in the placeholders will also contain it. (e.g using - and having UUIDs).
The main issue here is that the way I'm currently using it then you'd be calling it for every value you want to pull out of the template. I'd look at storing it once parsed the first time so we can easily get values again should we have another attribute that has it's value encoded in the same template.
Still work in progress but think I'll stop here and wait for feedback just in case this isn't something you'd want.

closing for now, haven't had the time to really work this into a proper solution, might come back to it later

Okay, understand.


Ghast Glitch

A Ghast Goes To The OverWorld And when it does in the overworld there are alot of ghasts, around 50 that my friend found :(

Any datapacks installed? Other mods?

no datapacks or mods, its only origins
On Sun, 25 Jul 2021 at 22:36, Alluysl @.***> wrote:

Any datapacks installed? Other mods?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apace100/origins-fabric/issues/374#issuecomment-886241172,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUX2HNVPIAU4L6KH7BQH74DTZRKSNANCNFSM474CH3UA
.


Is it possible to assign an id to a polyline path?

I would like to target the individual polylines on a map using jQuery SVG but the individual path elements do not have IDs. Is this possible?

Also see #1010 if we decide to do this.


Enhancement: extend the aad app add command with support for specifying a certificate

We should extend the aad app add command with support for specifying a certificate to register with the app. We already support generating secrets, but there are organizations who prefer using certificates instead and it would be good to support both not to exclude anyone.

That is a nice catch @milanholemans. It is indeed a duplicate. Will be closing it from our end


Update tasks datasets

Updated this script so we can create training data which is batched efficiently for the periodic table dataset which should have a train/dev/test split now. The smiles and lm-eval datasets are small enough that we can do this batching but I haven't updated e.g. the hf datasets script because they are normally just large blocks of text where this isn't needed and would be too slow.
Since the functions are reused between the two scripts, I moved them into utils.

tiny nit pick but I noticed use of the type hint list which isn't available in Python 3.8 (which I think we currently use in some places). You could swap those for the typing.List hint.

Good spot! I have changed it :)


Ensure that builds within the cache aren't considered Git repositories

Summary
Some packages encode logic to embed the current commit SHA in the version tag, when built within a Git repo. This typically results in an invalid (non-compliant) version. Here's an example from pylzma: https://github.com/fancycode/pylzma/blob/ccb0e7cff3f6ecd5d38e73e9ca35502d7d670176/version.py#L45.
This PR adds a phony, empty .git to the cache root, to ensure that any git commands fail.
Closes https://github.com/astral-sh/uv/issues/1768.
Test Plan

Create a tag on the current commit, like v0.5.0.
Build pylzma, using a cache within the repo:

rm -rf foo
cargo run venv
cargo run pip install "pylzma @ https://files.pythonhosted.org/packages/03/d8/10ef072c3cd4301a65a1b762b09eefa02baf8da23b9ea77ebe9546499975/pylzma-0.5.0.tar.gz" --verbose  --cache-dir bar

Perhaps worth mentioning that this does mean people can’t version the cache and check it into Git (I don’t think?).

I guess the “best” version of this would be to put the .git in the temporary directory when building, but then omit it when we persist the build to the cache.


Andoid placeholder not work

node - v8.9.4
npm - v5.6.0
react-native - 0.53.0
react - v16.2.0
native-base - v2.4.5

Expect
Show placeholder on Android, iOS works well
Result
Show first Picker.Item element
I changed to default <Picker.Item label={label]} value={null}/> and show this now, but I need remove that item for current work

@ihusak Android Picker does not support placeholder, documented

I changed to default <Picker.Item label={label]} value={null}/> and show this now, but I need remove that item for current work

I did not get this, can you be more clear

@ihusak I have stated above that

Android Picker does not support placeholder, documented

It's already 2019, and Picker still not supporting placeholder in Android.

It's already 2019, and Picker still not supporting placeholder in Android.

You can do like this:
//return each items after mapping over the list items
const selectionItems = props.selectionList.map((item, index) => {
return <Picker.Item key={index + 1} label={item.code ? item.name : item} value={item} />;
})
// this is the important part. put the placeholder value in the array by appending the value at the beginning of the array. Since placeholder prop is not selected in Android.
selectionItems.unshift(<Picker.Item key={0} label={props.placeholder} color={colors.primaryGrey} />)

{selectionItems}

It's already 2020, and Picker still not supporting placeholder in Android.

It's already 2020, and Picker still not supporting placeholder in Android.

Picker doesn't show placeHolder value in Android.
<Picker
mode="dropdown"
iosIcon={}
style={{
color: '#174A7A',
fontSize: 20
}}
placeholder="Select your Country*"
placeholderStyle={{ color: "#bfc6ea", fontSize: 20 }}
selectedValue={this.state.selected}
onValueChange={this.onValueChange.bind(this)}>

Picker placeholder doesn't work in Android

Picker placeholder doesn't work in Android.

I think it's not going to be supported in android

I think it's not going to be supported in android

It's already 2021, and Picker still not supporting placeholder in Android.

It's already 2021, and Picker still not supporting placeholder in Android.

It's already 2021, and Picker still not supporting placeholder in Android

It's already 2021, and Picker still not supporting placeholder in Android

It`s already February 2021 and Picker still not supporting placeholder in Android

It's already March 2021 and Picker still not supporting placeholder in Android

It's already April 2021 and Picker still not supporting placeholder in Android

It's already Jun 2022 and Picker still not supporting placeholder in Android , right?

It's 2023 and Picker still not supporting placeholder in android

26 July 2023
Picker still not supporting placeholder in android :(


#3718: Added date to changelog

This PR is in reference to PR #3727
@humitos @stsewd Please have a look to the changes made here

Thank You @humitos :) :)

Hi @agjohnson just wanted to know the status of the PR. Is there anything to be updated from my side?

Thank you :) @agjohnson :tada:


changing CI to kicad 8.0.1

Tested on Swoop, successfully built gerbers.
Building on GlowTower (Kicad 8 Project)


Upgrade golang

Summary: This upgrades our golang SDKs to the latest patch version
to pull in bug fixes and security fixes.
Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Existing tests should provide enough coverage.

Superseded by #1319


logGammaL loses precision near zero

logGammaL loses precision near zero. For parameters less than 1e-3 it do not provide 14 digits promised by documentation any more. Precision of logGamma deteriorates much slower in this range and reach 1e-14 for x < 1e-4. I don't know whether this is property of algorithm or bug in implementation.
x    relative error

1.25e-6    2.335247745808626e-11
6.82e-5    4.5200406627037583e-13
2.46e-4    1.2419479169108893e-13
8.8e-4      7.069995230776526e-14
3.12e-3    7.69901613260452e-16
Gamma function value up to 20 decimal digits were computed using mpmath python library.

Migrated to math-functions


Prevent possibly unbound variable in history response handler

When handling history responses, the response future in future might be unbound in the HistoryError handler.
Split this in three steps to reduce error handling clutter:

Obtain future from correlation ID, which is possibly unknown
Check that this future is not already done, i.e. the response was not handled already
Parse history response, set result or exception of the response future accordingly

I think I understand what you are trying to do, but I don't understand the comment.

What does it mean that "the future in future is unbound"?
Is this something that happened to you, or did you determine this an issue through the method of staring at the code?
How does the handling of HistoryError have any say here? Do you men the internal handler which just does set_exception rather than set_result? Or the "outside" Handler in user code, that should happen well after any of this?

I can only see the critical case happening when a client receives two successive messages with the same correlation id - which would be a bug in another agent, but sure, could happen - and the second _on_history_response gets handled by the loop before asyncio.wait_forself._request_futures[...] completes leading to the removal of the future from the map.

* What does it mean that "the future in `future` is unbound"?

Unfortunate wording. The local variable future is only set in the try: ... block, so if we try to use it in an except ...: ...-clause, python might raise an UnboundLocalError.
Sure, right now there is no except ...:-clause that references future before it was set, but that's not easy to see.

* Is this something that happened to you, or did you determine this an issue through the method of staring at the code?

Staring at the code and having pyright complain about it.

* How does the handling of `HistoryError` have any say here? Do you men the internal handler which just does `set_exception` rather than `set_result`? Or the "outside" Handler in user code, that should happen well after any of this?

If I understand correctly what you are asking:
I am talking about the internal error handler which just does future.set_result.
In my mind the single error handler was just to complicated, it tried to handle three different kinds of (unrelated) error conditions.  And for me it was not immediatly clear what line raises what exception, so I split it up.

I can only see the critical case happening when a client receives two successive messages with the same correlation id - which would be a bug in another agent, but sure, could happen - and the second _on_history_response gets handled by the loop before asyncio.wait_forself._request_futures[...] completes leading to the removal of the future from the map.

Yes, that is (probably) correct.  It was just that the handling for "this is an unknown correlation ID" and "this response was handled already" were lumped together.  I think that if a response future can be retrieved from self._request_futures it is actually never done, but I did not want to remove the code handling this condition.
I am not sure if the code under except (..., asyncio.InvalidStateError) ever ran in practice.

I

* What does it mean that "the future in `future` is unbound"?

Unfortunate wording. The local variable future is only set in the try: ... block, so if we try to use it in an except ...: ...-clause, python might raise an UnboundLocalError.
Sure, right now there is no except ...:-clause that references future before it was set, but that's not easy to see.

* Is this something that happened to you, or did you determine this an issue through the method of staring at the code?

Staring at the code and having pyright complain about it.

I'd argue it can't happen because self._request_futures[correlation_id] will never raise a HistoryError. But sure, it's more obvious that way.

I am not sure if the code under except (..., asyncio.InvalidStateError) ever ran in practice.

Ah I skimped over the asyncio.InvalidStateError now being replaced by the apocalyptic future.done() check.


Forgotten pr's

I check the history and find a lot of issues, the last active time of which is at least 6 days. (20 in total)
My filter is "is:pr is:open updated:<2020-06-24"
Here are pr's on README:
#1432 #1287 #1286 #769
Here are pr's on YamlCreate.ps1:
#1159 #478 #462 #451 (#462 is better than #451)
Here are pr's on Issue template:
#1135 #481
Here are pr's on general yaml files:
#2059 #1938 #1315 #561 #332 (If #332 is a joke, should we close it?)
Here are pr's that might lack "blocking issue" tag:
#756 #545
Here are confilcted pr's (and should be closed or add a fail tag):
#1193 #445
.editorconfig: #334

@qiancy98 I'll take a look at those.

The README.md PRs are all merged now.

I've asked @KevinLaMS to look at the YamlCreate.ps1 PRs.

I've merged the Issue Template PRs, but I needed to move a link out of the comment, so that's waiting on a team approver.

It seems that you don't like the "block issue" tag, do you? If it is this case, I will delete related texts. Thanks.


New booking does not set the correct end time.

Describe the bug
New booking does not set the correct end time. If a booking is made for an activity e.g. VR, which has a booking duration of 60 min, the next booking made will utilise the duration of the previous booking unless the state of the form is completely update.
To Reproduce
Create a new booking for e.g VR, which has a duration of 30 mins.
Create another booking with another category which has a different duration, e.g xbox.
If the name and time haven't been changed, then the duration of the booking will be incorrect when added.
Expected behavior
A booking made after another will be added but the duration of the booking will be incorrect.
Priority
P2 - The application is usable but the bug may cause frustration to the user and have unnecessary negative consequences for the users visitors.
Screenshots/Video
Currently not available
Desktop
OS: Mac OS Ventura 13.4.1 / WIndows 11
Browser: Chrome, Firefox, Safari, Edge
Resolution -
Version -

Mobile/Tablet
Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Screen size: [e.g. 4.75, 5.5]
Mobile Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context

Bug has been fixed
https://github.com/aob123/book-me-in/assets/63284233/5db1e5e0-869f-4951-af30-18c84df726c2


Cannot unmarshal struct when key is also ASCII escaped

package main

import (
        "fmt"

        "encoding/json"

        gjson "github.com/goccy/go-json"
)

type obj struct {
        Msg string `json:"消息"`
}

func main() {
        // \u6D88\u606F are escaped charecters for Chinese word "消息"
        b := []byte(`{"\u6D88\u606F":"\u6D88\u606F"}`)

        o := obj{}
        json.Unmarshal(b, &o)
        fmt.Printf("got json object: %+v\n", o)

        o = obj{}
        gjson.Unmarshal(b, &o)
        fmt.Printf("got gjson object: %+v\n", o)
}

Expected
go run /tmp/t.go
got json object: {Msg:消息}
got gjson object: {Msg:消息}

Actual
go run /tmp/t.go
got json object: {Msg:消息}
got gjson object: {Msg:}

@harshavardhana Thank you for the reporting ! I will fix this issue with https://github.com/goccy/go-json/pull/237


createClass() will be removed from React

Howdy,
createClass() will be removed from React in 16 version. Are you going to update your lib?

@clayallsopp do you plan to upgrade this plugin to support React v16 or should we be making efforts to create-react-class as advised by in the console warnings?
Cheers
Kyle

If anyone makes a PR,  I will review it and publish the package. @clayallsopp nor me is currently actively developing the package

Ok i'll try, but since React no longer supporting mixins, update will have breaking changes: package function will be used as HOC.
class YourComponent extends React.Component {...}

connectToBackbone(YourComponent, options);