Script to check if reno release note was committed to the wrong place

Summary
Following the same check added to Terra at Qiskit/qiskit-terra#8320
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.514%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
694

Relevant Lines:
831

💛  - Coveralls


RavenContext changes

This is a fairly large proposal for the change of how instances of RavenContext are kept and accessed.
Disclaimer: I have also been unable to find any documentation pertaining to the feature and its use, so I apologize for any misunderstanding on my part.
The required functionality (please correct me if I am wrong):

Using multiple Raven instances should be possible, as such one context per thread per Raven instance should be accessible
The functionality should be unchanged in case one instance if being used
Static helpers such as "Breadcrumbs" should set data on all RavenContext instances that are active
The RavenServletRequestListener should clear all Raven contexts when a request is complete.

Some rationale about the changes:
I wrote a test to test the functionality and I could not make it "work"
public class BreadcrumbsTest {

    @Tested
    private Raven raven = null;
    @Injectable
    private Connection mockConnection = null;
    @Injectable
    private Event mockEvent = null;
    @Injectable
    private EventBuilderHelper mockEventBuilderHelper = null;

    @Test
    public void testBreadcrumbsPropagation() {
        Breadcrumb breadcrumb = new BreadcrumbBuilder()
                .setCategory("myCat")
                .setLevel("ERROR")
                .setMessage("Message")
                .build();
        final List<Breadcrumb> match = new ArrayList<>();
        try(RavenContext context = new RavenContext() ){
            context.activate();
            //raven.getContext();
            raven.addBuilderHelper(new ContextBuilderHelper(raven));
            Breadcrumbs.record(breadcrumb);
            assertThat(raven, equalTo(Raven.getStoredInstance()));
            Raven.getStoredInstance().sendEvent(new EventBuilder()
                    .withMessage("Some random message")
                    .withLevel(Event.Level.INFO));
            // There is an event in the context, but none in the event as there are two stores....
            assertThat(context.getBreadcrumbs().next(), equalTo(breadcrumb));

        }
        match.add(breadcrumb);
        new Verifications() {{
            Event event;
            mockConnection.send(event = withCapture());

            assertThat(event.getBreadcrumbs(), equalTo(match)) ;
        }};
    }
}

In case of an externally provided context (and created in a try-with-resources block) the breadcrumbs would not actually be propagated to the event. Note the commented out raven.getContext(); line, which actually makes the test pass, but highlights the difference in instances that exist.
I was also quite confused with the implementation of AutoCloseable on the context, as this implies using try-with-resources, but I cannot see any way of associating such a context with a Raven instance.

Contexts are definitely confusing. For the record, they are modeled after the Python SDK here: https://github.com/getsentry/raven-python/blob/master/raven/context.py
I think you're right that the AutoCloseable is unnecessary. I'm not sure why a user would need/want to new up their own RavenContext, it's supposed to be taken care of for them.
I think the root issue that your PR points out is that nothing is currently implicitly creating an activate RavenContext for threads, so there is no activate context available for Breadcrumbs (or other classes) to make use of.
I need to think about your changes some more, thanks.

Note to self: ThreadLocal references are dropped when a thread dies, but we need to make sure we don't hold references to old contexts (or anything else) in these static maps.

I think the ideas here are superseded by this: https://github.com/getsentry/raven-java/pull/348/commits/26eebc36f6581411e51b7ce23ce0f8c2c6ddfb93
We were able to simplify a lot of stuff by tossing the "active" context stuff. I'm going to document context/breadcrumbs more and release this with 8.0.0.


give warning when source file not found

CodeChecker store command should warn when a source file is not found and so the plist is skipped.

We already have a warning for this: https://github.com/Ericsson/codechecker/blob/master/libcodechecker/libhandlers/store.py#L231


Issues with Shiny Stats in DB

Most of our stats are de-duped by ID of pokemon, like pokemon_stats and pokemon_iv_stats
But with shiny stats we de-dupe by account+ID, as the same pokemon can be seen by multiple accounts and shiny depends on account
Therefore stats like hundo and shundo can't be compared
Therefore calculating the real shiny odds from DB is impossible, because pokemon_iv_stats total is different from shiny total (because of account+ID de-dupe)
We might need to come up with a valid solution, to make the stats better.
One possible solution might be to add a new column to pokemon_shiny_stats to reflect the total... Or we simply stop de-duping by account+ID and we only count the shiny of first account encountering. With the latter the behavior would be identical over all stats.

The shiny stats needs to be all encounters from all accounts (and know the account) as shiny are per account.
The other stats should be per pokemon.
If the total isn't in pokemon_shiny_stats it should be (I thought it was when I talked through this with @comstud ), as you are right you can't use the iv stats as the denominator

Shiny stats do look at all encounters from all accounts (only counting each account once per encounter id).
But, there is no non-shiny version of the same thing (or a total) in the DB (there is for prometheus). In the PR I did, I avoided any DB migrations. So, yeah, there is currently no way to use the DB compute odds/%.
I think the easiest solution and the one that may make the most sense is to just add a 'total' column to the 'pokemon_shiny_stats' table. I can fix this real easily.

Hm. Given all of those stats tables have the same schema at the moment, I'm wondering if it would be better to add a new table with the totals.... which could then also have the same schema. But that feels a little strange to me.
I wouldn't think adding a new column would break blissey...  And whatever is trying to compute shiny odds could just be adjusted to look @ sum(count)/sum(total) or whatever. But maybe @dkmur has opinions.

I dunno, what do you think about this:
https://github.com/UnownHash/Golbat/pull/202

Hm. Given all of those stats tables have the same schema at the moment, I'm wondering if it would be better to add a new table with the totals.... which could then also have the same schema. But that feels a little strange to me.
I wouldn't think adding a new column would break blissey... And whatever is trying to compute shiny odds could just be adjusted to look @ sum(count)/sum(total) or whatever. But maybe @dkmur has opinions.

Blissey doesnt use any of the "rdm stats tables" of Golbat, just pokemon_area_stats, so no preference from that perspective

Hm. Given all of those stats tables have the same schema at the moment, I'm wondering if it would be better to add a new table with the totals.... which could then also have the same schema. But that feels a little strange to me.
I wouldn't think adding a new column would break blissey... And whatever is trying to compute shiny odds could just be adjusted to look @ sum(count)/sum(total) or whatever. But maybe @dkmur has opinions.

The total is unlike any other total - it is total encounters; so it makes sense to keep it with the numerator


Update Pattern.py

The code for the given pattern is written.

output does not match with given pattern


i18n(fr): update cli-reference.mdx

Description (required)
Adds changes from #9895 and #10018 to the French translation of cli-reference.mdx

Related issues & labels (optional)

Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File
Note

fr/reference/cli-reference.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Create a DAO AutoIndex or LazyIndex to only create Indices when first used

From<EMAIL_ADDRESS>on February 19, 2014 11:58:48
Either create an AutoIndex which automatically adds indices when a new sort-order is selected or else create a LazyIndex decorator which defers the creation of an Index until it is first used.  Alternatively, this could be built in to TreeIndex so that it doesn't build it's tree-index until it wins its first plan auction.
This feature would save memory in applications with a lot of indices (like QuickCompose).
Original issue: http://code.google.com/p/foam-framework/issues/detail?id=203

There are still issues with AutoIndex, including that it only builds for orderBy queries, not for where. The query optimizer generally has not fully matured yet.


Support grayscale image encodings for cameras

There are many gray scale cameras on the market.  It would make sense to support this type of image encoding.
Using 8-bit or 16-bit gray scale images would also potentially yield bandwidth savings over having to send full 24 bit RGB images.
Inspired by: https://github.com/osrf/subt/pull/727/files#r552981266

We could leverage this : https://github.com/gazebosim/gz-rendering/blob/1e415bb1a3d374b15d9c6cb86be76b2b269711fb/include/ignition/rendering/PixelFormat.hh#L37 cc @deepanshubansal01 and make changes here and downstream : https://github.com/gazebosim/gz-sensors/blob/efe31516ea49d43c3be1c093835eba8b6f978c17/src/CameraSensor.cc#L211-L224

8 bit grayscale support was added recently: https://github.com/gazebosim/gz-sensors/pull/220

8 bit grayscale support was added recently: #220

Should we add a similar support for 16 bit as well?

Based on the discussion offline, I will proceed with adding 16 bit support as well.

The support for both the 8 bit and 16 bit grayscale image format has been implemented. We can close this issue now ig.


Newer VS2019

Seems like even though this post was just updated 4 months ago there is some out-dated info. Basically most of the Identity stuff is not viewable or "exposed":
The generated project provides ASP.NET Core Identity as a Razor Class Library. The Identity Razor Class Library exposes endpoints with the Identity area. For example:
/Identity/Account/Login
/Identity/Account/Logout
/Identity/Account/Manage

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 94bfd895-d2af-390b-0801-428b36a27ff4
Version Independent ID: 0e0d870e-e49a-e16c-c259-68d58e701b8f
Content: Introduction to Identity on ASP.NET Core
Content Source: aspnetcore/security/authentication/identity.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hello @EdwardL75 ... It says that the endpoints are exposed in the Identity area, and those remarks are correct.
If you want the actual pages added to the app, then you "scaffold" them in ...
https://docs.microsoft.com/aspnet/core/security/authentication/scaffold-identity


SASS-1218 - navigation for employment details EOY

Description
updated navigation to align with E3.1 flow
Add a link to the relevant story in Jira
SASS-934
Checklist PR Reviewer
Before Reviewing

[x]  Have you pulled the branch down?
[x]  Have you assigned yourself to the PR?
[x]  Have you moved the task to “in review” on JIRA?
[ ]  Have you checked to ensure all dependencies are up to date?
[ ]  Have you checked to ensure its been rebased against the current version of master?

Whilst Reviewing

[ ]  Have you run the tests?

[ ]  Have you looked at the JIRA story to make sure all Acceptance Criteria has been met?

After Reviewing

[ ]  Have you checked for merge conflicts or any changes in the current master that may affect the current pull request? i.e. does it need another rebase?
[ ]  Have you checked to make sure there are no builds in the pipeline before you merge?
[ ]  Have you moved the task to “in pipeline” on Jira?

[x]  Have you rebased against the current version of master?
[x]  Have you checked code coverage isn’t lower than previously?

After PRs been raised

[x]  Have you checked the PR Builder passes?

PR for performance tests: https://github.com/hmrc/income-tax-submission-performance-tests/pull/30

uk.gov.hmrc:play-frontend-hmrc is behind a version, it needs a bump to 1.4.0-play-28


Enable autologging within configuration file

Mlflow offers a some autologging functionnalities for the most common machine learning frameworks (keras, tensorflow, xgboost...). It would be nice to be able to configure these autologging parametersin the mlflow.yml configuration file.

Advantages of mlflow autologging: it logs metrics automatically  during training, and not at the end of the node, which is convenient. For most models, this can be overcome with callbnacks so this is not a big issue.
Drawbacks of mlflow autologging: It logs parameters / models / metrics  without names which makes tracking very hard to read. This also conflicts with kedro-mlflow native parameters tracking (which is much more readable) so it is hard to integrate.

Decision: I won't support autologging for now, but I'll document how one can customize it with #442.


Are entity IDs internal or do they match Wikidata or WIkipedia's Ids?

Hi,
I'm considering this library for Entity linking, but within my application I need to find the corresponding Wikipedia URL.
Using your example, I tried Blink's Bert Id(97598) as Q97598 and pageid:97598 but I get completely different entities, so I'm wondering how I could get the KB id.
Wikidata results, using https://www.wikidata.org/w/api.php?action=wbgetentities&format=xml&props=sitelinks&ids=Q97598&sitefilter=frwiki
<api success="1">
<script/>
<entities>
<entity type="item" id="Q97598">
<sitelinks>
<sitelink site="frwiki" title="Else Quecke">
<badges/>
</sitelink>
</sitelinks>
</entity>
</entities>
</api>

Results as page ID using https://en.wikipedia.org/w/api.php?action=query&prop=info&pageids=97598&inprop=url
{
    "batchcomplete": "",
    "query": {
        "pages": {
            "97598": {
                "pageid": 97598,
                "ns": 1,
                "title": "Talk:Geneva County, Alabama",
                "contentmodel": "wikitext",
                "pagelanguage": "en",
                "pagelanguagehtmlcode": "en",
                "pagelanguagedir": "ltr",
                "touched": "2020-05-05T21:27:47Z",
                "lastrevid": 805052689,
                "length": 3123,
                "fullurl": "https://en.wikipedia.org/wiki/Talk:Geneva_County,_Alabama",
                "editurl": "https://en.wikipedia.org/w/index.php?title=Talk:Geneva_County,_Alabama&action=edit",
                "canonicalurl": "https://en.wikipedia.org/wiki/Talk:Geneva_County,_Alabama"
            }
        }
    }
}

Thanks for any help on this

@thepartisan101 Thanks for considering using the library. In the interactive mode, you can pass --show_url to show the url of wikipedia entity.
The displayed id is in corresponding to the row number in entity.jsonl file (downloaded from the download_models.sh script). Note id starts from 0. You can find more information in the entity.jsonl file, including the entity title, text, wikipedia url, etc.

Updated README to include information above.


Fix typo in drag_and_drop directory name

This PR just fixes the drag_and_drop directory name (darg_and_drop -> drag_and_drop)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey, good catch! Could you also fix the corresponding import?
https://github.com/livebook-dev/livebook/blob/79d6a9e6a2d1544b53dab73239b92ab241e4e802/assets/js/app.js#L25

No prob, loving this project! Nice work 🚀


Mail::Address#display_name returns encoded or decoded value

Related to #359 and #411, the Mail::Address#display_name method will return either an encoded or a decoded string depending on whether encoded or decoded was called last. Reading the code, this seems very intentional (display_name, along with other methods, explicitly refers to @output_type, which is set to :encode or :decode by the encoded and decoded methods), but it's extremely counterintuitive. Why should calling encode on an address suddenly change the return value of display_name? I would expect the result of display_name to always be decoded; this method (along with domain, local, etc.) should be independent of the wire protocol.
For example, suppose you have a debug flag that conditionally logs the message being processed. Turning debugging on/off will change the output:
def extract_name(message, logger=nil)
  if logger
    logger.debug "Extracting address from #{message}"
  end
  message[:from].addrs.first.display_name
end

extract_name(Mail::Message.new("From: Tony =?UTF-8?B?Tm92w6Fr?= <tony@example.com>"))
# => "Tony Novák"
extract_name(Mail::Message.new("From: Tony =?UTF-8?B?Tm92w6Fr?= <tony@example.com>"), Logger.new(nil))
# => "Tony =?UTF-8?B?Tm92w6Fr?="

I propose doing away with @output_type entirely. Thoughts?

I agree that this behaviour is confusing. I'd love to see a pull request that changes the way this works. I assume they'd hold off on merging a change like this until a major version release since it would change the API of the object, but I for one would love to see this happen.


Accessors + Callsites + Borrowing

This PR contains two commits:

The first changes the emission of the bases of accessors to use load_borrow when possible.
When we are emitting a direct argument for a callsite and we have a owned parameter, this commit performs a formal access borrow.

rdar://29791263

@swift-ci Please test and merge

The problem that this PR hit is that the +0 self hack makes guaranteed self parameters extend lifetimes in a fragile way.
The solution is to eliminate the hack and use a formal evaluation scope for these copies and eliminate the hack. I am preparing a PR that does that now.


Access Control with Google OAuth 2.0

Hello,
I'm trying to have this working but is not clear to me (I've readed all the documentation, also the useful links) how to implement the Client - Server authentication flow.
I understand that this module doesn't implement the frontend for authenticate the user so I have to get the Token by myself (Making a request to Google) this is specified in the documentation - "How the actual client accessing the protected resources got its access token is not relevant to this Apache Resource Server setup."
But my question is when I have my token provided by Google, how can I make a request to the apache server in order to authenticate someone? Thanks in advance.

The client would send the token as usual in an Authentication header in the form Authentication: Bearer <token.
Also note that that token does not authenticate a user or a client. It merely allows the one presenting the token to get access to some protected resource. If you want to authenticate users you need the regular OIDC flow.

Thanks for the fast answer, but I don't want to know about that level of depth yet... I mean how can I create a request with curl for example in order to test that my token is correct? is that possible? Again my problem is that I don't understand after read the documentation how to implement OAuth2 authentication with this module.
It seems to be a great one but I appreciate some help, maybe it can be useful for new users that want to implement this solution and doesn't know how to start.

You can use the token agains a resource protected by mod_auth_openidc as follows: curl -H "Authorization: Bearer <token" https://<host>/<protected-resource>

I have a token that I retrieved from google and have verified that it is valid.
When I use it as such, it works fine:
curl -H "Authorization: Bearer $token" https://www.googleapis.com/plus/v1/people/me
When I use it with my apache server running mod_auth_openidc, I get Permission denied.
All I am changing is the URL, from https://www.googleapis.com/plus/v1/people/me to the one that references my apache server.  When I access my apache url from my browser, it works.  When I access it via CURL with the Authorization: header, it gets permission denied.
Thoughts?


crash

First of all, thank you for the great project!
my issue:
After 'npm run dev' I get '[nodemon] app crashed - waiting for file changes before starting...', does anyone know what could be the issue?

Did you run npm install first?

yes!


Add variable default values support

Fallback to variable default value, if the variable value is not provided.
Deduplicate variable definitions.

This looks interesting!
Can you provide an example of the output before/after this for the fetch/apollo snippets that you've changed in your PR description, and then I can look at getting this merged?

Before
The variable default value $name: String! = "graphql" is provided in the query, but there is no const name = "graphql"; in the code:

After
The variable default value $name: String! = "graphql" is provided in the query, and there is const name = "graphql"; in the code:

If the variable value is provided {"name": "prisma"}, the variable default value $name: String! = "graphql" is overrided, and there is const name = "prisma"; instead of const name = "graphql"; in the code:

But the default value is already provided in the query itself - this change would effectively move the default out of the query and always provide a default in code. Why duplicate the default definition?


Platform specific constants accessed in enum_string_N.go causes compilation errors

Hey!
First of all, exciting to see a new VK wrapper for Go! Im interested in evaluating it for my https://github.com/johanhenriksson/goworld project, and willing to contribute if it works out well :) I'd like to depend on a library that I could keep up to date myself if required.
I noticed there's been little testing on OSX, and indeed it does not seem to work at the moment. Tried to run one of the samples quickly, and im running in to these compilation errrors (excluded a bunch more similar ones):
# github.com/bbredesen/go-vk
../../../go/pkg/mod/github.com/bbredesen/go-vk@v0.0.0-20230304041510-33ed978b8bfd/enum_win32_string_0.go:21:9: undefined: FullScreenExclusiveEXT
../../../go/pkg/mod/github.com/bbredesen/go-vk@v0.0.0-20230304041510-33ed978b8bfd/enum_string_5.go:496:8: undefined: ERROR_FULL_SCREEN_EXCLUSIVE_MODE_LOST_EXT
../../../go/pkg/mod/github.com/bbredesen/go-vk@v0.0.0-20230304041510-33ed978b8bfd/enum_string_6.go:975:8: undefined: STRUCTURE_TYPE_EXPORT_FENCE_WIN32_HANDLE_INFO_KHR
../../../go/pkg/mod/github.com/bbredesen/go-vk@v0.0.0-20230304041510-33ed978b8bfd/enum_string_6.go:976:8: undefined: STRUCTURE_TYPE_EXPORT_SEMAPHORE_WIN32_HANDLE_INFO_KHR

Most of them have _WIN32 or _NV in their names, so I assume they are just platform specific constants not available on my platform. Perhaps they need to be moved into conditionally compiled files?
I haven't had a chance to look at the code generator yet, is there any support for keeping certain defines/code in platform specific go files?

The plan on the base issue here is is to remove go:build tags from the enum type files, but to leave them in place around commands, structs, extensions, etc.
The enum files will still have their Vulkan platform names, and the platform-specific types will be generated to their own platform_string.go files, just without the build guards.


use system specific acceptance radius for multirotor takeoff

Fixes #3684
The condition for reaching takeoff waypoint is the same as on my mission update. Also had to update the isolated takeoff item altitude because the acceptance radius won't be used anymore. Tested in sitl/hil

The root cause of the issue for me seems to be that all acceptance radii are zero. So this PR fixes takeoff, but not the other waypoints.

In SITL they are/were NAN for some reason. If they were zero it would work as it is.

This fix does only use the system acceptance radius for takeoff like we want it anyway, and by chance is also a workaround for sitl issue.

Applied on master


[PyTorch] TransformerLayer: add support for Falcon architecture

Falcon-40b and Falcon-180b are two exciting publicly available models. Currently, transformer-engine does not support their architecture because in their implementation self attention and mlp are not computed in sequence. Instead, the blocks (layer norm -> self attention) and (layernorm -> mlp) are fed with the input into the layer. In a computational graph these operations are thus in parallel. In the Falcon configs this is denoted as new_decoder_architecture. This PR introduces this feature and thus makes it possible to finetune Falcon models with transformer-engine. We would be really happy if this feature finds it's way into transformer-engine.
Two notes on the implementation:

I denoted the new option parallel_attention_mlp. I am not sure if this is a perfect naming, this is up for discussion.
I created a new method _bias_dropout_add() in order to keep the new code clear
Falcon models do not have a bias, accordingly I think that a pretty clean solution is to set return_bias=False for attention and mlp and then use bias dropout add. For models using parallel_attention_mpl and bias, this might not be optimal.

/te-ci

Thanks for proceeding so quickly with this PR 🥳

/te-ci pytorch

Thanks for fixing my spelling mistakes ... sorry for that. The tests failed because there was one last occurance of parallel_attention_ml. I fixed that and ran the tests locally. Now it should be fine.

/te-ci pytorch

/te-ci pytorch

Tim's attempt to run the CI failed due to network issue apparently, I just retried it.

Merged. Thank you @Marks101 for the contribution!

Great, thank you for the support!


Worker Disabled?

I just noticed in the Link function of Angular-PDF that you call PDFJS.disableWorker. Is there is a specific reason you are explicitly disabling this?
Thank you for this fantastic library!

No specific reason - do you need it to be enabled? Maybe we can pass it in as an option.
To refresh myself, I'm also looking at the pdf.js code examples and in the comments I see some reasons stated not disabling it.

I don't need it, they just cite better/non-blocking performance in supported browsers with it enabled. I just wanted to make sure there wasn't a known issue that prevented it from being enabled. I've been running it since yesterday with it enabled and have not seen any issues.

Thanks for checking it in use. Please feel free to close this issue then 🤗


libcxl: Check afu link when read from PSA mmio return all FFs

Presently libcxl will return an error or raise a SIGBUS when it reads
all FFs from PSA mmio space. This prevents returning wrong values to
the caller when the CXL card has fenced due to an eeh error. But this
posses problems as for some AFUs all FFs might be a valid value for a
PSA register and when read libcxl might incorrectly assume the card to
be fenced and indicate an error to the caller.
We fix this problem by memory mapping the afu descriptor from sysfs to
the process address. When libcxl mmio space read functions
cxl_mmio_read{64,32}() read all FFs we check the first word of the
mapped afu descriptor to see if it all FFs. If yes we assume the card
has fenced and we return an error to the caller. Else we assume the
read value as valid and return a success to the caller with all FFs as
result.
This patch introduces three new internal functions:

cxl_open_afudesc(): Maps the afu sysfs attr named 'afu_desc' to
process address space.

cxl_close_afudesc(): Unmaps and closes the afu descriptor from the
process address space.

cxl_afu_link_ok(): Reads the first word from mapped afu descriptor
and returns 1 if its not all FFs else returns 0 indicating link
down. In case there was an error mapping afu_desc it returns '0'

Signed-off-by: Vaibhav Jain<EMAIL_ADDRESS>

Corresponding kernel changes posted for review :

cxl: Re-factor cxl_pci_afu_read_err_buffer()
cxl: Introduce afu_desc sysfs attribute
cxl: Provide user-space access to afu descriptor on bare metal
kernfs: Check KERNFS_HAS_RELEASE before calling kernfs_release_file()

thank you


Improve error handling and logging in HTTP::Server

Currently HTTP::Server logs (or at least it tries: #9067) every error, including those produced by a sudden client disconnection. These changes aim to:

Log everything through Log api
Ignore errors raised when a client connection is lost
Don't write back headers (with status 500) or error messages when there was some content sent already

Changes are made to HTTP::Server::RequestProcessor, HTTP::ErrorHandler and HTTP::LogHandler. The last one used to receive an optional IO to customize where to write the logs, so this could be seen as a breaking change. Although not so big, I think.
fixes #9067

There should be an initializer accepting a Log instance so users can use a custom configured one
Why? That's the point of the new logging framework, that provides flexibility to change the backend for each source. Otherwise, would you provide flexibility to change any logger in the std?

You can easily have different HTTP servers running side by side. And I would like to treat the log messages from a server that serves say an internal JSON API differently than from a server that serves public HTML requests. I don't want all log entries mangled at http.server but separate log sources at myapp.public_http and myapp.json_api.
This could technically be implemented as a context-based filter. But using a different log source is more approriate. Context-based filtering could handle different vhosts for example.
Such a flexibility is certainly not necessary for typical loggers. But LogHandler is an explicit tool to configure log handling for an HTTP application and it should offer some options for customizability.

I think I covered all the comments and changes requested. I tested it a lot with a "real" app in different scenarios and the results feel reasonable to me.
I also added the remote address and HTTP version to the log entries to make it more similar to other frameworks.

We can't have three (!) different locations where status information about a request gets logged. That's a total mess.

Well, I agree just 50%. It's not actually status information that it's logged in three places. Request status is logged just in one place: LogHandler. Is the error logging that it's duplicated between LogHandler and ErrorHandler

Maybe we need to consider the whole approach to these handlers, see my comment on log_handler_spec.cr

I agree and I've been discussing this for more than 1h with @bcardiff at the phone and I've been moving around the code several times without settling for any option. I was trying to keep the Rack design but it's not possible to "make it right" this way. As I said above, the alternative is make the LogHandler not a regular Handler but something that's plugged to the RequestProcessor.
Anyway, I think this is an improvement, and actually a fix, over the design that we currently have. That again, it's not "our" design, but a translation of the Rack design. I'll open a RFC with a proposal to make this different but for now we can merge this that solves issues we currently have without changing the design too much.

I'd prefer to have the logging built into the server, and not a handler. We already have existing ways to configure logging levels, and I think a handler ends up duplicating that.

Yes, maybe not embedded because I’d like to keep it configurable in case anyone want to log differently, but definitely not as a handler. I’ll return to this once I close more priority things.


32-bit support for MABS v3 UR1?

Has 32-bit support been removed from MABS v3 UR1? Or has this page just been modified strangely from the RTM version of the same page?
If 32-bit support has been explicitly removed, you will need to add a comment to explicitly mention this on the page, because it is not clear. Additionally you should probably link to the release notes that stated this was going to happen. We may have been accidentally caught out without notification...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52f7582c-c2a6-87bb-d236-2066e727c90c
Version Independent ID: 1cbc7ee7-2518-137a-f6d6-d1d62a1a1bc3
Content: MABS (Azure Backup Server) V3 UR1 protection matrix - Azure Backup
Content Source: articles/backup/backup-mabs-protection-matrix.md
Service: backup
GitHub Login: @dcurwin
Microsoft Alias: dacurwin

@webash Thank you for the feedback. This issue is being assigned to the content author to evaluate and update as appropriate.

#reassign:SujayJDesai

@webash Thanks for reaching out to us. The 32 bit agent support has been removed from the MABS v3 UR1. This has been documented under What's new section here - https://docs.microsoft.com/en-us/azure/backup/backup-mabs-whats-new-mabs#whats-new-in-mabs-v3-ur1 and also in the KB article here - https://support.microsoft.com/en-in/help/4534062/update-rollup-1-for-microsoft-azure-backup-server-v3
Generally we document only known issues under release notes. But to make it more clear we will also add note on the protection matrix page.

The note has now been added. Thanks for your suggestion.
#please-close

Its pretty crazy that a breaking change like this came down automatically via Windows Update. We didn't receive any kind of notification in advance that such a thing might occur. Thanks for adding the note, I think that might help other confused people in future.


Hey Team, I am trying to use remote module with Terraform Cloud and Terraform Init command fails with unauthorized error

I have created .env file with TF_TOKEN_app_terraform_io environment variable
I have terraform.rc files in my repository that has credential block to terraform cloud api token. I don't know what else to try here and make this work.
I appreciate any help here.

This repository is only for the Azure Devops extensions for calling terraform.  And the issues here are for reporting bugs or requesting features.  I believe StackOverflow would be a more appropriate place for your question.
Thanks


Fix PytestWarning: Error when trying to teardown test databases: Runt…

Fix PytestWarning: Error when trying to teardown test databases: RuntimeError("generator didn't stop after throw()") #95

@makaramkd that doesn't solve the problem at all ... and it actually brings issues, since its much better to delete databases after a test run

@makaramkd that doesn't solve the problem at all ... and it actually brings issues, since its much better to delete databases after a test run

I agree that its better to drop the database, but I think that this is also a way bevause the flags: --reuse-db and --create-db are eliminating the issue as the tests are reusing the test database or creating a new database if there is a change in the schema.
So now Ill try to drop the database after the test.


fix: actually set 1 as the CC version when assuming V1 is supported

fixes: #6048

@zwave-js-bot automerge


Expressions with parenthesis are not parsed correctly

Hi!
Very good job for developing this. I like the operator overloading feature, but I found a problem where expressions have parenthesis. The following snippet
    expression(name = "my_expr") {
      (SourceType.Time.HOUR_1_24 `==` 1) `||` (SourceType.Time.HOUR_1_24 `==` 13)
    }

generates
<Expression name="my_expr">[HOUR_1_24] == 1 || [HOUR_1_24] == 13</Expression>

while it was expected to generate
<Expression name="my_expr">([HOUR_1_24] == 1) || ([HOUR_1_24] == 13)</Expression>

The first one, without parenthesis, is not evaluated correctly. This happens with all of the other operators. One solution would be to add parenthesis for all operator arguments. I don't know if it is possible to overload the () operator (not invoke).

Hi!
It's unfortunately not possible to override parentheses behavior in Kotlin, but that's okay, you only need to prefix them with p so it becomes a function call, which will carry the parentheses over into the arithmetic expression.

that's a nice solution. I missed that utility. Thanks!


Agent executor tool invocation doesn't recognize ToolInputParsingException error

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain.js documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain.js rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
The following tool always returns as successful (with empty observation), even if it fails schema validation.
enum CampaignOptimizationKPI {
  None = 'none',
  Conversions = 'conversions',
  Clicks = 'clicks',
  CTC = 'ctc',
  VideoCompletion = 'video-complation',
  Other = 'other',
}

const briefSchema = z.object({
  requestedKPIs: z.nativeEnum(CampaignOptimizationKPI).optional(),
});

const toolName = 'submit-campaign-brief';

const tool = new DynamicStructuredTool({
  name: toolName,
  description: 'submit incremental/full updates about the campaign brief object',
  schema: briefSchema,
  returnDirect: false,
  func: async (input) => {
    console.log('[2]', '|', toolName, '|', 'calling onChange with:', updatedBriefData);

    return 'OK, brief updated';
  },
});

Error Message and Stack Trace (if applicable)
No response
Description
I'm invoking a langchain tool through an agent executor, with a wrong schema.
Langchain doesn't identify the error as a ToolInputParsingException, therefore my chain proceeds and I get wrong results.
This is my tool definition (simplified for the example):
enum CampaignOptimizationKPI {
  None = 'none',
  Conversions = 'conversions',
  Clicks = 'clicks',
  CTC = 'ctc',
  VideoCompletion = 'video-complation',
  Other = 'other',
}

const briefSchema = z.object({
  requestedKPIs: z.nativeEnum(CampaignOptimizationKPI).optional(),
});

const toolName = 'submit-campaign-brief';

const tool = new DynamicStructuredTool({
  name: toolName,
  description: 'submit incremental/full updates about the campaign brief object',
  schema: briefSchema,
  returnDirect: false,
  func: async (input) => {
    console.log(input);
    return 'OK, brief updated';
  },
});

The following input fails schema validation:
 {
    requestedKPIs: 'ctr',
  }

This is the stack trace:
Error: Received tool input did not match expected schema
    at DynamicStructuredTool.call (index.js:85:1)
    at async executor.js:474:1
    at async Promise.all (:5555/acc/5/campaigns/344/v/1/index 0)
    at async AgentExecutor._call (executor.js:466:1)
    at async AgentExecutor.invoke (base.js:55:1)
    at async RunnableSequence.invoke (base.js:1140:1)
    at async Object.getAssistantResponse (openai.api.ts:61:15)

This error is checked in executor.js for its instance type, but not recognized as the correct instance.

With this error being swallowed and never thrown, I don't have no ways to handle schema validation problems. This is bad,
Please assist. 🙏
System Info
<EMAIL_ADDRESS>node v20.11.0
yarn v1.22.22

This is not helpful, I need a human hand here

The issue is in the output parser. For example, if you are using react, then this line is to blame for raising an Error instead of an OutputParserException. Changing:
throw new Error(`Could not parse LLM output: ${text}`);

to
throw new OutputParserException(`Could not parse LLM output: ${text}`);

solves the issue for me. If you can validate that this works for you too, I'll submit a pr.

Your fix works and looks good, I think you should open a PR, although it's not exactly my case as I'm using open ai functions agents and not a react agent


[Slider] Pass this.state.value into onDragStop & onDragStart

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Someone I know was having issues getting the slider value back when the user stops sliding. It was being passed back whilst sliding (onChange) but that's now what they were after.
From what I can see, the only way of getting that value is creating a ref on the Slider component and accessing this.refs.slider.getValue() within the onDragStop method. Like the onChange method, the second param is now the slider value. I also added the same to onDragStart for consistency.

@Ehesp I don't get it. What the issue with onChange in the first place? I would rather not increase the API surface if not necessary.
Providing a second parameter doesn't look like something standard.

From what I can see, the only way of getting that value is creating a ref on the Slider component and accessing this.refs.slider.getValue()

Well, most component method should probably be considered internal.
I think that imperative method like getValue should be deprecated.

@Ehesp I'm gonna close this PR. We forward the onDragStart so user can still have access to native DOM event, not to hack around. I think that it would be better to fix the core issue. Thanks anyway!

I believe there is a valid use case where you cannot use onChange but you still need to access this.state.value. It is as follows:
The slider.value is mapped to global state which is constantly incrementing. You would like to set that global state onDragEnd which would then change the slider position.
You can't use onPosChange because you need to update the global state, and updating it in onPosChange would be a loop.
This problem is clear if you want to use the slider for a media player. You want to keep the progress bar in sync with the music, and then update the music position when the onDragEnd is triggered.
What do you think?

I also have a use case where I want stuff happening when the slider moves (e.g. changing grey scale in a canvas), while some DOM change should only happen on release, because otherwise the slider moves too fast for the action to complete (in this case, resizing a second slider). In other words, any event callback that takes more time to complete than for the slider to move by 1 tick cannot be triggered onChange.
Having the value available onDragEnd would allow for instance to construct a range slider (with two handles) made of two simple sliders easily. The size of the second needs to change only when the first is released.
I don't understand what the issue is to passing the value just like onChange does. The event object is not enough since event.target.value is undefined as well.
To complete the OP comment, a ref on the slider will not have the current slider value but only that of the previous tick.

You can't use onPosChange because you need to update the global state, and updating it in onPosChange would be a loop.

@karlfloersch I was thinking about exposing a callback property that is called when the slider position drag is over. We could call it onChangeEnd. Or do you have another idea of API that we could expose to solve the issue (without going against the DOM specification)?

In other words, any event callback that takes more time to complete than for the slider to move by 1 tick cannot be triggered onChange.

@jdelafon Sounds like an issue on userland. For this use cases, why not throttling the callback?
Actually, I feel like you are having issues with handling the asynchronous aspect of the <Slider />.
I pretty sure though issues could be solved on userland taking advantage of the exposed property with RxJs (bindCallback, throttle and withLatestFrom).

Because firstly, you want the onChange event to really fire on every tick, and secondly throttle will silence the observable for a duration, which means that you could (will most likely) miss the only tick that is meaningful for the onDragStop event: the last one.
But I am not really familiar with this, and I am not saying there is not some way to do it somehow. I've always had the onMouseUp-like event I needed until now. Anyway, if you plan adding an onChangeEnd event, that is all good.

@oliviertassinari Adding onChangeEnd sounds good. Though curious, is the reason you don't want to add the slider.value to onDragStop because onDragStop is a common web API? Basically, you don't want to confuse people by providing a non-standard call?
Just to verify, onChangeEnd get called one time when you stop dragging the slider, correct? And is it true that every time onDragStop is called, onChangeEnd will be called, and visa versa?

Basically, you don't want to confuse people by providing a non-standard call?

Yes indeed.
I'm gonna submit a PR with the change. Would be awesome if you can have a look once it's done.
Having a look at some other popular <Slider /> component:

https://github.com/mpowaga/react-slider
https://github.com/davidchin/react-input-range
https://github.com/react-component/slider
It looks like onAfterChange is the most common used name for this behavior.

@oliviertassinari I'd be happy to review the PR! 😄 using onAfterChange then makes sense to me.

I have noticed one use case that you might not be able to handle even with the new callback.
What about a user using the keyboard to change the value?

doesn't seem like onAfterChange or onChangeEnd was added?


Fix errors in composition/inertia-modifier page

The code samples were using EN DASH rather than HYPHEN-MINUS! I assume this is just a formatting issue introduced by some editor, but it is super painful and non-obvious because the code still compiles ( it is just a string literal) but results in a runtime error that doesn't say what is wrong.
Also fixed an issue where the name of a variable wasn't consistent and kept alternating between snapDownModifier and snapForwardModifier.

@arcadiogarcia : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jwmsft Hi Jim, could you review this pull request? Thanks.

@arcadiogarcia , thanks for submitting this update.
#sign-off


Move scripts to src folder

make sure this doesn't break anything

tested a few times, works as it should

alr

will prob need to resolve the conflicts before merging


Cannot find module 'binding-v3.0.4-node-v51-darwin-x64/lzma_native.node'

Hey guy, I'm getting stuck with this issue:

v7.10.0 is already installed.
Now using node v7.10.0 (npm v4.2.0)
Resolved requirements: { SYNC_SERVER_FOLDER: 'sync',
SYNC_ARCHIVE: 'realm-sync-cocoa-2.1.10.tar.xz',
SYNC_ARCHIVE_ROOT: 'core' }
No lockfile found at the target, proceeding.
Extracting realm-sync-cocoa-2.1.10.tar.xz => /Volumes/Data/WORKS/ReactNative/CreditCardMobileApp/node_modules/realm/vendor/realm-ios
{ Error: Cannot find module '/Volumes/Data/WORKS/ReactNative/CreditCardMobileApp/node_modules/lzma-native/binding-v3.0.4-node-v51-darwin-x64/lzma_native.node'
at Function.Module._resolveFilename (module.js:470:15)
at Function.Module._load (module.js:418:25)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at /Volumes/Data/WORKS/ReactNative/CreditCardMobileApp/node_modules/lzma-native/index.js:13:14
at Object.
In either case, you shouldn’t be using Node 7, it’s been unsupported for more than half a year now.

Thanks @addaleax for replying very quickly.
I'm using node v8.7.0
But maybe the problem come from the xcode-command-line-tool. I'm still using MAC Sierra, not High Sierra, with Xcode v9.0. I'm upgrading my Xcode and try to check it out before report the problem again.

@kent2508 The first lines of what you pasted say that you are using Node 7.10?

Oh sorry, I installed node on 2 location with npm and brew. They installed different versions.


Error when committing container

I have created a container in an AWS t2.small instance with 30G of storage. There I have installed opencv and tensorflow.
Thanks

Please use this template for reporting issues?
https://github.com/docker/docker/blob/master/.github/ISSUE_TEMPLATE.md

The problem was the instance didn't have enough memory, solved after doing the same process in an instance with 80 G storage.

@manucarbonell can you please share more about your solution?
What did you mean by "doing the same process in an instance with 80 G storage."
instance meaning your hosting server or the container?
it will be much appreciated.

@dbsquared a bigger AWS instance (host / server)


Young/green horizon

LGTM

Change the title of this PR, young/green_horizon describes almost 0 of what’s in this pr


x/tools/gopls: rename on a method receiver should rename all receivers for the type

What version of Go are you using (go version)?

example.com$ go version
go version devel +2be7788f8 Fri Oct 9 02:49:19 2020 +0000 linux/amd64

example.com$ go version -m $(which gopls)
/usr/local/google/home/bcmills/bin/gopls: devel +186f0220d0 Mon Oct 5 11:12:24 2020 -0400
        path    golang.org/x/tools/gopls
        mod     golang.org/x/tools/gopls        v0.5.1  h1:AF3Uh7HF08SZpKFfgJO6zfF3bbxyDXWqdkK4kMXiQ1o=
        dep     github.com/BurntSushi/toml      v0.3.1  h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
        dep     github.com/google/go-cmp        v0.5.1  h1:JFrFEBb2xKufg6XkJsJr+WbKb4FQlURi5RUcBveYu9k=
        dep     github.com/sergi/go-diff        v1.1.0  h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
        dep     golang.org/x/mod        v0.3.0  h1:RM4zey1++hCTbCVQfnWeKs9/IEsaBLA8vTkd0WVtmH4=
        dep     golang.org/x/sync       v0.0.0-20200625203802-6e8e738ad208      h1:qwRHBd0NqMbJxfbotnDhm2ByMI1Shq4Y6oRJo21SGJA=
        dep     golang.org/x/tools      v0.0.0-20200930165741-f1523d29dbb9      h1:1R38tQp22dcHpTKJPjgVa16FhlDy/kHEaCM/ndi/FIc=
        dep     golang.org/x/xerrors    v0.0.0-20200804184101-5ec99f83aff1      h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
        dep     honnef.co/go/tools      v0.0.1-2020.1.5 h1:nI5egYTGJakVyOryqLs1cQO5dO0ksin5XXs2pspk75k=
        dep     mvdan.cc/gofumpt        v0.0.0-20200802201014-ab5a8192947d      h1:t8TAw9WgTLghti7RYkpPmqk4JtQ3+wcP5GgZqgWeWLQ=
        dep     mvdan.cc/xurls/v2       v2.2.0  h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=

example.com$ ls -d ~/.emacs.d/elpa/eglot-*
/usr/local/google/home/bcmills/.emacs.d/elpa/eglot-20200830.1254

example.com$ emacs --version
GNU Emacs 27.1

Does this issue reproduce with the latest release?
Yes.
What did you do?
Initial state:
-- go.mod --
module example.com

go 1.16
-- main.go --
package main

import "fmt"

type T struct{}

func (x *T) String() string {
	return fmt.Sprintf("%T{}", x)
}

func (x *T) Clone() *T {
	y := new(T)
	*y = *x
	return y
}

func main() {}

emacs -nw main.go
Move the point to the first method receiver (main.go:7:6).
M-x eglot-rename
Enter a new name (such as t) for the method receiver.

What did you expect to see?
Per http://golang.org/wiki/CodeReviewComments#receiver-names:

Be consistent, too: if you call the receiver "c" in one method, don't call it "cl" in another.

Since the file already satisfied that consistency rule before the rename, I expect it to satisfy that rule after the rename, too: all of the method receivers should have been renamed to the new name entered in step (4).
What did you see instead?
Only the receiver for the one method was renamed.
gopls log:

[Trace - 15:40:27.246 PM] Sending request 'initialize - (1)'.
Params: {"processId":712138,"rootPath":"/tmp/tmp.hs2uMVS9fG/example.com/","rootUri":"file:///tmp/tmp.hs2uMVS9fG/example.com/","initializationOptions":null,"capabilities":{"workspace":{"applyEdit":true,"executeCommand":{"dynamicRegistration":false},"workspaceEdit":{"documentChanges":false},"didChangeWatchedFiles":{"dynamicRegistration":true},"symbol":{"dynamicRegistration":false},"configuration":true},"textDocument":{"synchronization":{"dynamicRegistration":false,"willSave":true,"willSaveWaitUntil":true,"didSave":true},"completion":{"dynamicRegistration":false,"completionItem":{"snippetSupport":true},"contextSupport":true},"hover":{"dynamicRegistration":false,"contentFormat":["markdown","plaintext"]},"signatureHelp":{"dynamicRegistration":false,"signatureInformation":{"parameterInformation":{"labelOffsetSupport":true}}},"references":{"dynamicRegistration":false},"definition":{"dynamicRegistration":false},"declaration":{"dynamicRegistration":false},"implementation":{"dynamicRegistration":false},"typeDefinition":{"dynamicRegistration":false},"documentSymbol":{"dynamicRegistration":false,"hierarchicalDocumentSymbolSupport":true,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]}},"documentHighlight":{"dynamicRegistration":false},"codeAction":{"dynamicRegistration":false,"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}}},"formatting":{"dynamicRegistration":false},"rangeFormatting":{"dynamicRegistration":false},"rename":{"dynamicRegistration":false},"publishDiagnostics":{"relatedInformation":false}},"experimental":null}}

[Trace - 15:40:27.246 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":{"codeActionKinds":["quickfix","refactor.extract","refactor.rewrite","source.fixAll","source.organizeImports"]},"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"documentOnTypeFormattingProvider":{"firstTriggerCharacter":""},"renameProvider":true,"foldingRangeProvider":true,"executeCommandProvider":{"commands":["generate","fill_struct","regenerate_cgo","test","tidy","undeclared_name","upgrade_dependency","vendor","extract_variable","extract_function","gc_details","generate_gopls_mod"]},"callHierarchyProvider":true,"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"Build info\n----------\ngolang.org/x/tools/gopls v0.5.1\n<EMAIL_ADDRESS>h1:AF3Uh7HF08SZpKFfgJO6zfF3bbxyDXWqdkK4kMXiQ1o=\n<EMAIL_ADDRESS>h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=\n<EMAIL_ADDRESS>h1:JFrFEBb2xKufg6XkJsJr+WbKb4FQlURi5RUcBveYu9k=\n<EMAIL_ADDRESS>h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=\n<EMAIL_ADDRESS>h1:RM4zey1++hCTbCVQfnWeKs9/IEsaBLA8vTkd0WVtmH4=\n<EMAIL_ADDRESS>h1:qwRHBd0NqMbJxfbotnDhm2ByMI1Shq4Y6oRJo21SGJA=\n<EMAIL_ADDRESS>h1:1R38tQp22dcHpTKJPjgVa16FhlDy/kHEaCM/ndi/FIc=\n<EMAIL_ADDRESS>h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=\n<EMAIL_ADDRESS>h1:nI5egYTGJakVyOryqLs1cQO5dO0ksin5XXs2pspk75k=\n<EMAIL_ADDRESS>h1:t8TAw9WgTLghti7RYkpPmqk4JtQ3+wcP5GgZqgWeWLQ=\n<EMAIL_ADDRESS>h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=\n"}}

[Trace - 15:40:27.248 PM] Sending notification 'initialized'.
Params: {}

[Trace - 15:40:27.248 PM] Received notification 'window/showMessage'.
Params: {"type":4,"message":"Loading packages..."}

[Trace - 15:40:27.248 PM] Received request 'workspace/configuration - (1)'.
Params: {"items":[{"scopeUri":"file:///tmp/tmp.hs2uMVS9fG/example.com/","section":"gopls"},{"scopeUri":"file:///tmp/tmp.hs2uMVS9fG/example.com/","section":"gopls-example.com"}]}

[Trace - 15:40:27.249 PM] Sending notification 'textDocument/didOpen'.
Params: {"textDocument":{"uri":"file:///tmp/tmp.hs2uMVS9fG/example.com/main.go","version":0,"languageId":"go","text":"package main\n\nimport \"fmt\"\n\ntype T struct{}\n\nfunc (x *T) String() string {\n\treturn fmt.Sprintf(\"%T{}\", x)\n}\n\nfunc (x *T) Clone() *T {\n\ty := new(T)\n\t*y = *x\n\treturn y\n}\n\nfunc main() {}\n"}}

[Trace - 15:40:27.249 PM] Sending notification 'workspace/didChangeConfiguration'.
Params: {"settings":null}

[Trace - 15:40:27.250 PM] Sending request 'textDocument/documentSymbol - (2)'.
Params: {"textDocument":{"uri":"file:///tmp/tmp.hs2uMVS9fG/example.com/main.go"}}

[Trace - 15:40:27.254 PM] Sending response 'workspace/configuration - (1)' in 5ms.
Result: [null,null]

[Trace - 15:40:27.327 PM] Received request 'client/registerCapability - (2)'.
Params: {"registrations":[{"id":"workspace/didChangeWatchedFiles-0","method":"workspace/didChangeWatchedFiles","registerOptions":{"watchers":[{"globPattern":"**/*.{go,mod,sum}","kind":7},{"globPattern":"/tmp/tmp.hs2uMVS9fG/example.com/**/*.{go,mod,sum}","kind":7}]}}]}

[Trace - 15:40:27.327 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2020/10/09 15:40:27 go env for /tmp/tmp.hs2uMVS9fG/example.com/\n(root /tmp/tmp.hs2uMVS9fG/example.com)\n(go version go version devel +2be7788f8 Fri Oct 9 02:49:19 2020 +0000 linux/amd64\n)\n(valid build configuration = true)\n(build flags: [])\nGOINSECURE=\nGONOPROXY=\nGOMOD=/tmp/tmp.hs2uMVS9fG/example.com/go.mod\nGOPROXY=https://proxy.golang.org,direct\nGOPATH=/tmp/tmp.hs2uMVS9fG/_gopath\nGOPRIVATE=\nGOCACHE=/usr/local/google/home/bcmills/.cache/go-build\nGONOSUMDB=\nGO111MODULE=auto\nGOFLAGS=\nGOROOT=/usr/local/google/home/bcmills/sdk/gotip\nGOSUMDB=sum.golang.org\nGOMODCACHE=/tmp/tmp.hs2uMVS9fG/_gopath/pkg/mod\n\n"}

[Trace - 15:40:27.329 PM] Sending response 'client/registerCapability - (2)' in 1ms.
Result:

[Trace - 15:40:27.588 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2020/10/09 15:40:27 go/packages.Load\n\tsnapshot=0\n\tdirectory=/tmp/tmp.hs2uMVS9fG/example.com\n\tquery=[./... builtin]\n\tpackages=2\n"}

[Trace - 15:40:27.628 PM] Received notification 'window/showMessage'.
Params: {"type":3,"message":"Finished loading packages."}

[Trace - 15:40:27.629 PM] Received request 'workspace/configuration - (3)'.
Params: {"items":[{"scopeUri":"file:///tmp/tmp.hs2uMVS9fG/example.com/","section":"gopls"},{"scopeUri":"file:///tmp/tmp.hs2uMVS9fG/example.com/","section":"gopls-example.com"}]}

[Trace - 15:40:27.671 PM] Sending response 'workspace/configuration - (3)' in 41ms.
Result: [null,null]

[Trace - 15:40:27.719 PM] Received response 'textDocument/documentSymbol - (2)' in 469ms.
Result: [{"name":"T","detail":"struct{...}","kind":23,"range":{"start":{"line":4,"character":5},"end":{"line":4,"character":15}},"selectionRange":{"start":{"line":4,"character":5},"end":{"line":4,"character":6}}},{"name":"(*T).String","detail":"()","kind":6,"range":{"start":{"line":6,"character":0},"end":{"line":8,"character":1}},"selectionRange":{"start":{"line":6,"character":12},"end":{"line":6,"character":18}}},{"name":"(*T).Clone","detail":"()","kind":6,"range":{"start":{"line":10,"character":0},"end":{"line":14,"character":1}},"selectionRange":{"start":{"line":10,"character":12},"end":{"line":10,"character":17}}},{"name":"main","detail":"()","kind":12,"range":{"start":{"line":16,"character":0},"end":{"line":16,"character":14}},"selectionRange":{"start":{"line":16,"character":5},"end":{"line":16,"character":9}}}]

[Trace - 15:40:30.981 PM] Sending request 'textDocument/signatureHelp - (3)'.
Params: {"textDocument":{"uri":"file:///tmp/tmp.hs2uMVS9fG/example.com/main.go"},"position":{"line":6,"character":6}}

[Trace - 15:40:30.981 PM] Sending request 'textDocument/hover - (4)'.
Params: {"textDocument":{"uri":"file:///tmp/tmp.hs2uMVS9fG/example.com/main.go"},"position":{"line":6,"character":6}}

[Trace - 15:40:30.981 PM] Received response 'textDocument/signatureHelp - (3)' in 0ms.
Result: null

[Trace - 15:40:30.982 PM] Sending request 'textDocument/documentHighlight - (5)'.
Params: {"textDocument":{"uri":"file:///tmp/tmp.hs2uMVS9fG/example.com/main.go"},"position":{"line":6,"character":6}}

[Trace - 15:40:30.982 PM] Received notification 'window/logMessage'.
Params: {"type":1,"message":"2020/10/09 15:40:30 no signature help: cannot find an enclosing function\n\tposition={6 6}\n"}

[Trace - 15:40:30.982 PM] Received response 'textDocument/hover - (4)' in 0ms.
Result: {"contents":{"kind":"markdown","value":"```go\nvar x *T\n```"},"range":{"start":{"line":6,"character":6},"end":{"line":6,"character":7}}}

[Trace - 15:40:30.982 PM] Received response 'textDocument/documentHighlight - (5)' in 0ms.
Result: [{"range":{"start":{"line":6,"character":6},"end":{"line":6,"character":7}},"kind":1},{"range":{"start":{"line":7,"character":28},"end":{"line":7,"character":29}},"kind":1}]

[Trace - 15:40:35.647 PM] Sending request 'textDocument/rename - (6)'.
Params: {"textDocument":{"uri":"file:///tmp/tmp.hs2uMVS9fG/example.com/main.go"},"position":{"line":6,"character":6},"newName":"t"}

[Trace - 15:40:35.648 PM] Received response 'textDocument/rename - (6)' in 0ms.
Result: {"documentChanges":[{"textDocument":{"version":0,"uri":"file:///tmp/tmp.hs2uMVS9fG/example.com/main.go"},"edits":[{"range":{"start":{"line":6,"character":6},"end":{"line":6,"character":7}},"newText":"t"},{"range":{"start":{"line":7,"character":28},"end":{"line":7,"character":29}},"newText":"t"}]}]}

[Trace - 15:40:36.160 PM] Sending notification 'textDocument/didChange'.
Params: {"textDocument":{"uri":"file:///tmp/tmp.hs2uMVS9fG/example.com/main.go","version":2},"contentChanges":[{"range":{"start":{"line":7,"character":28},"end":{"line":7,"character":29}},"rangeLength":1,"text":"t"},{"range":{"start":{"line":6,"character":6},"end":{"line":6,"character":7}},"rangeLength":1,"text":"t"}]}

Some questions:

If the receiver names aren't currently consistent, should we rename them all to be consistent?
If we can't rename a receiver because the new name would conflict with another name in the method body, should we fail the entire rename operation or rename as many receivers as we can?

From a user perspective, I think it's better to rename even if the receiver names are not consistent at the moment, and rename as many receivers as possible.


[BUG] weave with some doctypes creates a tempdir that is not deleted

description
Using weave with doctype=md2html and leaving fig_path unspecified results in a temp dir (the kind made by mktempdir) left in the out_path. My guess is this code is responsible.
This behaviour is inconsistent with the doc, which says it will default to DEFAULT_FIG_PATH:

fig_path::Union{Nothing,AbstractString} = nothing: Where figures will be generated, relative to out_path. By default (i.e. given nothing), Weave will automatically create $(DEFAULT_FIG_PATH) directory.

If a tempdir is used, I would expect it to be deleted after calling the function that creates it.
versions

using InteractiveUtils; versioninfo():

Julia Version 1.6.2
Commit 1b93d53fc4 (2021-07-14 15:36 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin18.7.0)
  CPU: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, skylake)
Environment:
  JULIA_EDITOR = code

using Pkg; Pkg.status():

julia> using Pkg; Pkg.status()
      Status `/private/var/folders/g6/w_cfz8c507j6mbt5mdv7wt_h0000gn/T/jl_bzbN9C/Project.toml`
  [44d3d7a6] Weave v0.10.10

minimum reproducible steps

I have only tested with doctype="md2html" but I think it would be true of any doctype that ends with "2pdf" or "2html".
Example document called weave_test.jl:
#' ## Test
x = 1

weave call which creates a tempdir that is not deleted:
weave("./weave_test.jl"; doctype="md2html", out_path=".")

weave call which creates a "figures" dir as expected, and no tempdir:
 weave("./weave_test.jl"; doctype="md2html", out_path=".", fig_path="figures")

The output HTML is as expected:

I can confirm I have the same issue when weaving .jmd files. My platform is:
julia> using InteractiveUtils; versioninfo()
Julia Version 1.7.0
Commit 3bf9d17731 (2021-11-30 12:12 UTC)
Platform Info:
  OS: macOS (arm64-apple-darwin21.1.0)
  CPU: Apple M1
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, cyclone)
Environment:
  JULIA_EDITOR = code
  JULIA_NUM_THREADS =

and package version:
julia> using Pkg; Pkg.status()
      Status `~/.julia/environments/v1.7/Project.toml`
  [44d3d7a6] Weave v0.10.10

When using a file called test.jmd with:
# hello

this is a test!

```julia
5 + 5

after calling `weave("test.jl")` in the directory with output there is a temp folder that was not cleaned up "jl_X8p1Qs"


Importing 1.9.0 Villagers causes null exception

When executing   npm run build:src && npm run start , te tool imports all sheets but fails on creating the json files. The only values that are null on the villager spreadsheed are Furniture List & Furniture Name List, so I assume that this is causing the error.
Error:

><EMAIL_ADDRESS>build:src
> ./node_modules/typescript/bin/tsc

><EMAIL_ADDRESS>start
> /bin/rm -rf ./json/combined ./json/data ./json/raw && node ./build/index.js

✔ finished: Editors' Copy - Data Spreadsheet for ACNH
✖ error

An error occurred while converting
Error: Quota exceeded for quota metric 'Read requests' and limit 'Read requests per minute per user' of service 'sheets.googleapis.com' for consumer 'project_number:191970772851'.

Retrying attempt #2 in 30 seconds...

✔ finished: Translations - Updated for 1.9.0
/mnt/d/Programmieren/Repos/Github/animal-crossing/build/util/separate.js:11
    return string.split(separator).map((string) => string.trim());
                  ^

TypeError: Cannot read property 'split' of null
    at Object.separate (/mnt/d/Programmieren/Repos/Github/animal-crossing/build/util/separate.js:11:19)
    at Object.<anonymous> (/mnt/d/Programmieren/Repos/Github/animal-crossing/build/handlers/villagers.js:19:45)
    at Module._compile (node:internal/modules/cjs/loader:1108:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10)
    at Module.load (node:internal/modules/cjs/loader:973:32)
    at Function.Module._load (node:internal/modules/cjs/loader:813:14)
    at Module.require (node:internal/modules/cjs/loader:997:19)
    at require (node:internal/modules/cjs/helpers:92:18)
    at /mnt/d/Programmieren/Repos/Github/animal-crossing/build/index.js:50:57
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
npm ERR! code 1
npm ERR! path /mnt/d/Programmieren/Repos/Github/animal-crossing
npm ERR! command failed
npm ERR! command sh -c /bin/rm -rf ./json/combined ./json/data ./json/raw && node ./build/index.js

fixed by this pull request


Template micro-syntax closure and 'bind only to public class members'

This
<div *ngFor="let smile of smile">
  <smile-cmp [smile]="smile"></smile-cmp>
</div>

constructor(private smile: SmileService,

will provide error
You can bind only to public class members.

Good catch! I'll include fix in one of the next releases. Since the issue is not very high-priority, the fix might not be introduced as part of beta.5.

Having the same exact problem right now.
Quite annoying :D

In fact, there are two issues here:

The smile inside ngFor should be reported, since it's not public.
The smile declared in the lexical scope of <div/> should not be reported.

Publishing a fix for the second one.


Add support for partonomy placement using organ codes

Added support for partonomy placement using organ codes in addition to ccf_annotations. This means that all docs can be placed in the partonomy/anatomical structure search. Ideally the IRIs come from somewhere else, but right now I'm placing them as a lookup in the add_partonomy.py file.

@bherr2 did you create your branch off “test-release”? This is the default branch that also contains the recent changes. We only use master branch for release purpose.

@bherr2 did you create your branch off “test-release”? This is the default branch that also contains the recent changes. We only use master branch for release purpose.

Oh ok, I didn't know. Anything I need to change? Looks like you already switched the branch for me.

@bherr2 yes I’ve changed the base branch. And the CI checks all passed after you updated your branch. Thanks.
@mccalluc i don’t know much about the changes. If you think they look good, I’ll get this PR merged and redeployed on TEST.

I've put getting a single-source-of-truth for organs on the agenda for tomorrow.

October 1, 2021 Jonathan asserted that the Ontology API is the right place to capture this information, and it will be in place soon, and will be accessed via hubmap-commons.

Oh jesus, are you really closing this PR because of that? Just accept that not everything can be perfect 100% of the time and add this useful bit of code.

Waiting on mapping to be provided in hubmap-commons: https://github.com/hubmapconsortium/commons/issues/61

Talked with Nils: He wants to get this in without waiting for the backing ontology work. I'll make a commit to add a test case that distinguishes the two paths.

Added the IRIs to organ_types.yaml, rather than starting another list that will need to be merged.
If there are multiple partonomy nodes, include all paths in the facets we output. In the fake test examples, these don't make much sense, but hopefully in the real world, the IRI from the two letter code would already be in what we get from the RUI-JSON. (ES doesn't care whether a single value or a single-valued-list is given: They index the same.)
Test cases for the different combinations.

@yuanzhou : In your court.

@bherr2 @mccalluc FYI, I've redeployed the changes on DEV and TEST, will also do a reindexing.


I'm really enjoying using this library, but I found one (maybe more) problem.
When I use 'input' element, MistCSS generates the interface like this:
interface Mist_input extends React.DetailedHTMLProps<React.HTMLAttributes<HTMLInputElement>, HTMLInputElement> {
  ...
}

And this gives me an error:

Perhaps the correct interface would be:
interface Mist_input extends React.DetailedHTMLProps<React.InputHTMLAttributes<HTMLInputElement>, HTMLInputElement> {
  ...
}

I was trying to make a dictionary like src/html.ts but I found a more efficient way.
In this PR, I would like to introduce a new generic type utility that derives the JSX interfaces from the user's environment, freeing you from the hassle of constantly updating your library when new elements are added to HTML, or when there are changes to React. (And it also prevents unexpected problems... maybe...)
If you do not like the change, feel free to drop this PR, but anyway, I think the problem written above should be solved.
Thank you for reading my PR, have a nice day.

Hey @honeymaro
Great PR, it simplifies things. Thanks!


Please provide a cookbook for SF classic to SFMC migration

This will significantly reduce the time to move to from SF classic to SFMC. I had to read all the SFMC docs to understand what to do. This should be straightforward. Please also add how application certificates should be deployed. I found that it is the same process as in SF classic, but since the docs said SFMC manages the cluster certificate which has the same domain name as the application SSL cert, there is some confusion. In SF classic, the cluster owner deploys the application SSL and cluster certificate as the same certificate.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 658484bc-b80c-dd6f-9d90-4f3d86d64e4a
Version Independent ID: ed97f53e-bcd1-06a7-7804-13dbbbbb92bb
Content: Service Fabric managed clusters - Azure Service Fabric
Content Source: articles/service-fabric/overview-managed-cluster.md
Service: service-fabric
GitHub Login: @tomvcassidy
Microsoft Alias: tomcassidy

@chitturs
Thanks for your feedback! We will investigate and update as appropriate.

@tomvcassidy
Can you please check and add your comments on this doc update request as applicable.

@chitturs
I've delegated this to content author @, who will review it and offer their insightful opinions.

Hi @chitturs ! Great suggestion. I've put an item on the backlog and will suggest it to the product team immediately. I think they'll be interested in getting this topic documented quickly, because we want to promote more migration to managed clusters.
I will ping this issue again when the doc is published.
For now, thank you for your suggestion, and if you have any others, please let us know.
#please-close


Add back button listener widget

This widget is a back button listener so apps using Router API can intercept the back button pressed event in a friendly way.
It fixes the issue #74437
Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I signed the CLA.
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.
PS: I'm not so sure about the tests. Would you be able to help @chunhtai? I feel like I should be testing the dispose method that it is indeed removing the callback, but I couldn't find any examples on how to do that.

@chunhtai

wouldn't onBackPressed be better called as onPressed?
is there a way we could attach a custom route dispatcher? for example i created on, wrapped the Router into BackButtonListener and passed to both, so it would comprehensively replace WillPopScope (i tried to do so, but faced some problems)

@chunhtai

wouldn't onBackPressed be better called as onPressed?

we use onPressed for single tap callback all over the place in framework, it may be confusing. However, you have a point, onBackPressed is not descriptive enough as well. I suggested we change it to onBackButtonPressed

is there a way we could attach a custom dispatcher? for example i created one, wrapped the Router into BackButtonListener and passed the dispatcher to both, so it would comprehensively replace WillPopScope (i tried to do so, but faced some problems)

I am not sure I understand the setup. Can you explain in more detail?

I am not sure I understand the setup. Can you explain in more detail?

nevermind


WIP: V1 Migration Tooling

Updated with several fixes from the review, per slack convo handing over to @staebler


Upgrade to 5.1.1 to fix avro issue

This issue with the AVRO converters: https://github.com/confluentinc/schema-registry/issues/968
is short of a deal-breaker, because it fails for all data types that are not supported by JSON.
It is being fixed with 5.2.0 and 5.1.1. I had a look to see if I could update the Dockerfile and open a PR, but you host your own dependencies and I don't see 5.1.1 being uploaded in there.
Is there any way to help out to get a new release of the container that uses 5.1.1?
Thanks

Thanks for the report @javierholguera. If the bug isn't present in 5.0.x I'd suggest to use our latest tag or 2.0 (it's the same) until we get this sorted out. Usually, we wait for the corresponding Kafka patch (2.1.1 in this case) in order to issue an update in our Kafka builds.


TASK [lacework : add the lacework key (apt)] is failing

Hi there,
The step lacework : add the lacework key (apt) is failing on my server, it is not apparent why this is failing and I do not know enough about apt-key to debug this myself.
FAILED! => {"after": ["EE0CC692", "80AFD0B6", "0C9A5DF9", "C0B21F32", "EFE21092", "991BC93C"], "before": ["EE0CC692", "80AFD0B6", "0C9A5DF9", "C0B21F32", "EFE21092", "991BC93C"], "changed": true, "fp": "18E76630", "id": "18E76630", "key_id": "18E76630", "msg": "apt-key did not return an error, but failed to add the key (check that the id is correct and *not* a subkey)", "short_id": "18E76630"}

It appears to be for this step: https://github.com/alannix-lw/lacework-agent-ansible-role/blob/main/tasks/main.yml#L13

Thank you for reporting this @nhairs-finder!  It looks like one of our old signing keys expired on March 25th, 2022.  We no longer use it, so I've removed it from the tasks and will release a new version in just a few minutes.

Not a problem @alannix-lw :)
Looks like everything is working with version 2.0.1 (tested across all our servers):
TASK [lacework] *********************************************************************************************************************************************

TASK [lacework : add the lacework repo (yum)] ***************************************************************************************************************
skipping: [redacted.domain]
skipping: [redacted.domain]
skipping: [redacted.domain]
skipping: [redacted.domain]
skipping: [redacted.domain]

TASK [lacework : add the lacework key (apt)] ****************************************************************************************************************
ok: [redacted.domain]
ok: [redacted.domain]
ok: [redacted.domain]
ok: [redacted.domain]
ok: [redacted.domain]

TASK [lacework : add the lacework repo (apt)] ***************************************************************************************************************
ok: [redacted.domain]
ok: [redacted.domain]
ok: [redacted.domain]
ok: [redacted.domain]
ok: [redacted.domain]

TASK [lacework : install the lacework datacollector (apt/yum)] **********************************************************************************************
ok: [redacted.domain]
changed: [redacted.domain]
changed: [redacted.domain]
changed: [redacted.domain]
changed: [redacted.domain]

TASK [lacework : wait until /var/lib/lacework/config/ is created] *******************************************************************************************
ok: [redacted.domain]
ok: [redacted.domain]
ok: [redacted.domain]
ok: [redacted.domain]
ok: [redacted.domain]

TASK [lacework : generate config.json] **********************************************************************************************************************
ok: [redacted.domain]
changed: [redacted.domain]
changed: [redacted.domain]
changed: [redacted.domain]
changed: [redacted.domain]

PLAY RECAP **************************************************************************************************************************************************
redacted.domain   : ok=12   changed=1    unreachable=0    failed=0    skipped=3    rescued=0    ignored=0
redacted.domain  : ok=12   changed=2    unreachable=0    failed=0    skipped=3    rescued=0    ignored=0
redacted.domain   : ok=12   changed=2    unreachable=0    failed=0    skipped=3    rescued=0    ignored=0
redacted.domain : ok=12   changed=1    unreachable=0    failed=0    skipped=3    rescued=0    ignored=0
redacted.domain : ok=12   changed=2    unreachable=0    failed=0    skipped=3    rescued=0    ignored=0


new feature: Expore if OpenDAL can support KvikIO (aka Nvidia GPUDirect Storage)

Feature Description
GPUDirect Storage
Nvidia GPUDirect Storage is a technology introduced by Nvidia that enables GPUs to read files directly.

With GPUDirect Storage:

Higher Bandwidth: GDS offers 2x-8x higher bandwidth by enabling direct data transfers between storage and GPU, bypassing CPU involvement.
Lower Latency: Explicit and direct transfers reduce latency by 3.8x and ensure stable latency even as GPU concurrency increases.
Reduced CPU Load: DMA engines near storage reduce CPU load, maintaining higher bandwidth with minimal CPU utilization, and GPU utilization remains near zero during data transfers.
Superior IO Bandwidth: GPUs achieve higher IO bandwidth (215 GB/s) compared to CPUs (50 GB/s).
Scalable Storage Access: GDS allows fast access to large data sets, whether stored locally or remotely, nearly saturating GPU bandwidth by combining data transfers from various sources (CPU memory, local storage, remote storage).
Efficient Data Caching: Large distributed data sets can be cached in local storage, and working tables can be cached in CPU memory for collaborative use with the CPU, enhancing overall system performance.

cuFile
Nvidia exposes GDS support via cuFile which included in CUDA toolkit.
KvikIO
KvikIO is a High Performance File IO lib.
KvikIO is a Python and C++ library for high performance file IO. It provides C++ and Python bindings to cuFile, which enables GPUDirect Storage (GDS). KvikIO also works efficiently when GDS isn't available and can read/write both host and device data seamlessly. The C++ library is header-only making it easy to include in existing projects.
Problem and Solution
Perhaps OpenDAL could implement a service based on kvikio, allowing our users to interact with GDS using the familiar OpenDAL API.
kvikio currently offers only C++ and Python APIs. Those interested should first create a Rust binding for kvikio. To explore the performance of GDS, one should also have the CUDA toolkit and a compatible graphics card.
Additional Context
No response
Are you willing to contribute to the development of this feature?

[ ] Yes, I am willing to contribute to the development of this feature.

Interesting! What a shame I don't have a Nvidia GPU.

Interesting! What a shame I don't have a Nvidia GPU.

AMD has similar technology called DirectGMA, but I'm not sure if it can read files.

This is definitely an ambitious idea, and I would like to explore it further. However, after some research, I found that even if we create a Rust binding for KvikIO, it might not be sufficient.
The reason is that to utilize GDS, we need to use the CUDA API to manage GPU memory. Unfortunately, there is not yet a mature Rust library for CUDA. In KvikIO’s examples, to create a GPU memory buffer for KvikIO to read/write, they use APIs from cuda_runtime_api.h in C++ and CuPy in Python. These APIs are fully supported by Nvidia, and creating a Rust binding for them would be challenging.
If we use KvikIO without CUDA, as demonstrated in the example in the KvikIO repo (cpp/examples/basic_no_cuda.cpp), it won't use GPU memory at all. See the discussion in the issue for more details.
We could still try some third-party libraries like cudarc; maybe it will be sufficient for our use case. Perhaps others might have better ideas?


DNSSEC module reports green with no working keys

Annoying issue this, for example "gislaved.se", where 2 dnskeys exist at child and another one as DS at .SE. (3 different keys). In this case DNSCheck correctly reports "Parent DS does not refer to SEP at child" at level NOTICE (which is good, it could be prepub etc), what it does NOT report is that no valid chain of trust can be found at all. So basically this should be just as bad as DS at parent and no DNSKEY at child, which results in ERROR.
This might not have been possible to achieve without resorting to real dnssec-validation (not just comparing ID's), but considering how the world looks today we kinda need this check to "work". ;p
I also wonder what this message means: "Parent DS(gislaved.se) refers to invalid key at child: DS(gislaved.se/5/1/63802)"?! It's only INFO level, but not sure what it means... ;p ;)
Full test here: "http://dnscheck.iis.se/?time=1324998266&id=1924934&view=basic&lang=&test=standard"

I agree, if you find any more issues plz report them ASAP. I'm trying to get time from Calle to fix this one, if we can fix any other dnssec-related stuff at the same time that'd be groovy.
The other issues I've seen/heard of, when looking, seem more to be related to unclear error messages (the text itself). As long as a broken zone gives ERROR I'm happy, we can fiddle with messages later. ;)

How about a grey button if you don't have any DS? Now it is green if the zone has a DNSKEY (with not DS) when it is working... Please fix this.

"Parent DS(gislaved.se) refers to invalid key at child: DS(gislaved.se/5/1/63802)" is the message generated when the cryptographic verification of the child DNSKEY fails. The message emitted is confusing and should probably be changed, and the severity of the message raised considerably, but as far as I can tell the check is being made.

Commit 8aeedd87e1109cd40b36562b6fe3496db5f3f1ae adds a message if there are no valid DS/DNSKEY pairs between parent and child.


After Update Still "List Empty Issue"

Source information
Yomiroll 14.31
Source language
All
Steps to reproduce

Ref.: to Issue #3049

Expected behavior
Loading the Anime
Actual behavior
Video list is Empty error
Aniyomi version
Preview r7513
Android version
Android 12
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Source information
Yomiroll 14.31
Source language
All
Steps to reproduce

Ref.: to Issue #3049

Expected behavior
Loading the Anime
Actual behavior
Video list is Empty error
Aniyomi version
Preview r7513
Android version
Android 12
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Same problem

Yes not yet fixed I think


Add note about batching into README.md

Currently, the users which use github readme as a reference often try to upload either all the points they have in one upsert request, or upsert points one-by-one, which are not recommended ways of uploading.
We either need to add comments about batching, or examples.

#516


Add externals config to webpack bundling configuration of core project

@tunglt1810, I'll be tackling this near term. I appreciate the attempt, but we need slightly more explicit external mappings for this to work for all of our supported use cases


Patch failed to be applied but succeeded message is shown

Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1734090304591509
Issue OwnerCurrent Issue Owner: @gedu

cc @mountiny

Two relevant patch failures...

[ ] react-native-community/netinfo turbomodule patch
[ ] react-navigattion-core patch

@gedu I have seen couple people being slowed down by this, would you be able to prioritize this issue please?

@pac-guerreiro Will take a look at this, @mountiny you can assign the issue to him

@gedu @mountiny PR is live now - https://github.com/Expensify/App/pull/54355 😄

I'll be away until January 2nd but someone should take care of my work 😄 Happy holidays! 🎉

Waiting for @mountiny to review the PR

BugZero Checklist:

[ ] [Contributor] Classify the bug:

Bug classification

Source of bug:

[ ] 1a. Result of the original design (eg. a case wasn't considered)
[ ] 1b. Mistake during implementation
[ ] 1c. Backend bug
[ ] 1z. Other:

Where bug was reported:

[ ] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
[ ] 2b. Reported on staging (eg. found during regression or PR testing)
[ ] 2d. Reported on a PR
[ ] 2z. Other:

Who reported the bug:

[ ] 3a. Expensify user
[ ] 3b. Expensify employee
[ ] 3c. Contributor
[ ] 3d. QA
[ ] 3z. Other:

[ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:

[ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:

[ ] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:

Regression Test Proposal
Precondition:

Test:

Do we agree 👍 or 👎


ISPN-5450 Remote queries fail when security is enabled and current user is not an ADMIN

jira: https://issues.jboss.org/browse/ISPN-5450
this is for 7.2.x!

It's in. Thanks @anistor


Update for Onnx Convert() documentation, limited to ONNX-ML

Afaik, current version of ML.NET Convert() to ONNX supports just ONNX-ML. This is an update for Onnx Convert() documentation so it is limited to ONNX-ML behavior when mentioning examples. ONNX-ML is currently supported only by WinML.
CoreML and additional Onnx Backends might come in the future, though.
ONNX-ML is part of the ONNX standard that provides functionality for classic ML and pipelines. It is a superset of core ONNX. Many frameworks like Caffe2 and CNTK will not support ONNX-ML since they are focused on DNN.
AWS, Yahoo, and others have expressed interest in ONNX-ML but their products do not currently support it. This might change in the future. Export through ONNX-CoreML converter should be possible in the future, as well.
Summary
I eliminated references to CoreML and TensorFlow and left an example related to the currently supported target platforms by ONNX-ML which is WinML.
Fixes dotnet/docs#Issue_Number (if available)

Closing the PR as it should be done at the the source code /// comments at the dotnet/machinelearning repo, since the ML.NET API Reference is auto-generated from the source code.


No more stacked RoboDrobe

About the PR
Removes the physics defying phenomena involving a RoboDrobe creating a perfect atomic copy of itself.
Why / Balance
Because having a double stacked RoboDrobe is silly and it makes no sense
Technical details
I removed like 2 lines from a YAML file

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:

Ive chosen to remove the changelog in accordance to the significance guidelines.


We identified a connection issue that was unmonitored with a Redis connection to our MX servers.  This has been resolved and we have put monitoring in place.  Thank you for your patience.

          We identified a connection issue that was unmonitored with a Redis connection to our MX servers.  This has been resolved and we have put monitoring in place.  Thank you for your patience.

Originally posted by @titanism in https://github.com/forwardemail/status.forwardemail.net/issues/868#issuecomment-2091091249

This is not fixed. I’m getting connection timeout right now from exchange online to your service.
If it is fixed is broken itself again you forwarding wait times are 5 1/2 minutes

The waiting time is super long in last few days, it takes minutes to receive emails.

Yes, but why is it so long, you also seem to miss this point that your
servers are actually in timing out to request from other mail systems?
It should not be acceptable for emails to take five minutes, If this is in
your terms of service that it can take extended period of time to receive
emails please let me know so I can move off your infrastructure or at least
consider options.
Your monitoring seems to say everything is online even though emails have
been delayed by up to 5 minutes.
Lee Croucher *
🐻| @.** | w:https://a6n.co.uk http://www.a6n.co.uk/
http://facebook.com/artic6 http://us.linkedin.com/in/artic6
http://twitter.com/artic6 http://flickr.com/photos/croucher_lee
http://itunes.apple.com/app/artic6 http://drive.google.com/artic6
On Fri, 14 Jun 2024 at 10:43, Leng Yue @.***> wrote:

The waiting time is super long in last few days, it takes minutes to
receive emails.
—
Reply to this email directly, view it on GitHub
https://github.com/forwardemail/status.forwardemail.net/issues/1048#issuecomment-2167656899,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD7S725IBDFIU6DR4WTGT3ZHK3NDAVCNFSM6AAAAABJJV7GKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRXGY2TMOBZHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yes, but why is it so long, you also seem to miss this point that your servers are actually in timing out to request from other mail systems? It should not be acceptable for emails to take five minutes, If this is in your terms of service that it can take extended period of time to receive emails please let me know so I can move off your infrastructure or at least consider options. Your monitoring seems to say everything is online even though emails have been delayed by up to 5 minutes. Lee Croucher * 🐻| @.** | w:https://a6n.co.uk http://www.a6n.co.uk/ http://facebook.com/artic6 http://us.linkedin.com/in/artic6 http://twitter.com/artic6 http://flickr.com/photos/croucher_lee http://itunes.apple.com/app/artic6 http://drive.google.com/artic6
…
On Fri, 14 Jun 2024 at 10:43, Leng Yue @.> wrote: The waiting time is super long in last few days, it takes minutes to receive emails. — Reply to this email directly, view it on GitHub <#1048 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD7S725IBDFIU6DR4WTGT3ZHK3NDAVCNFSM6AAAAABJJV7GKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRXGY2TMOBZHE . You are receiving this because you authored the thread.Message ID: @.>

I am a user instead of dev lol


[METAL] Split kernels and compile them separately

Refactor Metal module to build each kernel separately. This should help
to avoid potential problem then generated blockSize is more than
maxTotalThreadsPerThreadgroup.
Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@tqchen please take a look again


NTR farnesyltransferase inhibitor

New Term Label: farnesyl transferase inhibitor
Definition: Farnesyl transferase inhibitors are small-molecule inhibitors that selectively inhibit farnesylation of a number of intracellular substrate proteins such as Ras. Farnesyl transferase inhibitors represent a new class of agents that target signal transduction pathways responsible for the proliferation and survival of diverse malignant cell types.
Definition source: https://www.medchemexpress.com/Targets/Farnesyl Transferase.html
Synonym exact: none
Cross Reference: NCI Thesaurus Code:  C1856
Parent term: enzyme inhibitor agent therapy MAXO:0000648
OCIDID: 0000-0003-4830-7530

added ntr. It is available in the latest release. Will see if Mike will update POET
Thanks so much for your help

Great!!! Thank you so much!
It’s been such a pleasure working with you
Megan

On May 16, 2023, at 12:34 PM, Leigh Carmody @.***> wrote:
added ntr. It is available in the latest release. Will see if Mike will update POET
Thanks so much for your help
—
Reply to this email directly, view it on GitHub https://github.com/monarch-initiative/MAxO/issues/543#issuecomment-1550173006, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6PY2EFBY6SPOG5D3NTXJD3XGPCENANCNFSM6AAAAAAXOFXJ24.
You are receiving this because you authored the thread.


Solving failure: remote repository at https://go.googlesource.com/text does not exist, or is inaccessible: : exit status 128

as title

GFW?


All files have no line breaks

I wanna edit some of the code but the files dont have line breaks, and Im too lazy to paste it into a text box and copy it back to notepad, cuz it fixes it.

try Notepad++
it's good , and it have javascript support

Neither do the MD files, the ini, or botnames.txt.

Notepad++ support a lot of file type
try it , you will know!

I use Notepad++

I'm busy getting info on the new gamemode, but I would love it if you want to create a pull request.

Use atom.io or Brackets..
Notepad++ is shit for programming (my opion)
I also started with Notepad++ but I never want it back now.

Thanks for the tip. If anyone can get the line breaks to work, I would be happy to merge a pull request.


fix attribute names for Zilean > v1.5.1

This is simply copied from https://github.com/rivenmedia/riven/pull/618/files, and it seems necessary for the latest Zilean changes :)

thanks!


fresh cocorico install issues

Q
A

Bug report?
[ ]

Feature request?
[ ]

Support request?
[y]

I have done two cocorico installs before and they went very smooth. However, with the new version there have been lot of problems. I have installed fresh cocorico and this is the result.

Apache error log reads  PHP Fatal error:  Allowed memory size of 536870912 bytes exhausted (tried to allocate 536870920 bytes) in /var/www/html/vendor/symfony/symfony/src/Symfony/Component/Intl/Data/Bundle/Reader/BundleEntryReader.php on line 134
memory_limit is set to -1 in php.ini file
And cocorico on first run loads extremely slowly.
Please advice me on how to fix the above two issues.
Thanks
Ravi Kumar

Hi @rkhyd
we don't have these issues on our side and since SF 3.4 upgrade Cocorico is very more speed.
Maybe you missed to set correctly something.
Could you give more informations :

What is your version of Cocorico (commit number).
What does return this command sh ./bin/init-db php --env=dev Take care it will initialize your DB data
What does return this command sh./bin/init-mongodb php --env=dev Take care it will initialize your MongoDB data
What are errors in your var/log/dev-yyy-mm-dd.log?

Feel free to reopen it if issue persists

Hi,
It seems there is a solution to the related  slowness issue here https://github.com/Cocolabs-SAS/cocorico/issues/389

hi @cocolabssas
I tried the install again on a new server, and the result is the same as above where i can see two menus and the internal server error at the bottom.
This happens when we try to use prod instead of dev in these steps
php bin/console cache:clear --env=prod mv web/.htaccess.prod.dist web/.htaccess chmod 744 bin/init-db && ./bin/init-db php --env=prod chmod 744 bin/init-mongodb && ./bin/init-mongodb php --env=prod php bin/console assets:install --symlink web --env=prod  php bin/console assetic:dump --env=prod
Can you please test it and confirm this as a bug.. thank you.