ISO 8601 Date format gets http:422 Unprocessable Entity

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
@app.get("/dateParm")
def dateParm( mydate: date = Query("2022-04-06T00:00:00.000Z")) -> bool:
    return {"result":True}

Description
Python FastAPI cannot process a date with the ISO8601 datetime format. I am calling the server from a Java client and am getting "422 Unprocessable Entity" This is way to strict! I know Node, Java, and Salesforce parse this correctly and truncate the time portion.
I have posted this in stackoverflow and received a workaround using union.   https://stackoverflow.com/questions/71770916/python-fastapi-iso-8601-date-format-gets-http422-unprocessable-entity
Please consider fixing this problem, and allowing the ISO format for Date type definitions.
Operating System
Windows
Operating System Details
No response
FastAPI Version
0.88.0
Python Version
3.9
Additional Context
StatusCode=422: Unprocessable Entity

Did you try initializing a Python date object in query params as default?

All date types fail whether in a Query Param or a field within a class
object if given a full ISO string. I am just trying to get interoperability
between java and salesforce.
The example I gave was just the simplest example to reproduce the problem.
@app.get("/dateParm")
def dateParm( mydate: date = Query("2022-04-06T00:00:00.000Z")) -> bool:
return {"result":True}
Thanks
Steve
On Sun, Dec 11, 2022 at 11:56 AM Irfanuddin Shafi Ahmed <
@.***> wrote:

Did you try initializing a Python date object in query params as default?
—
Reply to this email directly, view it on GitHub
https://github.com/tiangolo/fastapi/issues/5760#issuecomment-1345603893,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6Q3MEULMJ2CXY537VKSZLWMYBS5ANCNFSM6AAAAAASYIN4WQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

It works fine for me.
from datetime import datetime

from fastapi import FastAPI, Query

app = FastAPI()

@app.get("/dateParm")
def date_param(mydate: datetime = Query("2022-04-06T00:00:00.000Z")):
    print(mydate)
    print(type(mydate))
    return {"result": True}

Gives:
INFO:     Started server process [15420]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)

2023-04-06 00:00:00+00:00
<class 'datetime.datetime'>
INFO:     <IP_ADDRESS>:51239 - "GET /dateParm?mydate=2023-04-06T00%3A00%3A00.000Z HTTP/1.1" 200 OK

Your example is using a datetime type. It needs to be date type. The
system is being too strict, when it receives an ISO datetime for a date.
@app.get("/dateParm")
def date_param(mydate: date = Query("2022-04-06T00:00:00.000Z")):
print(mydate)
print(type(mydate))
return {"result": True}
On Mon, Dec 12, 2022 at 11:52 AM Irfanuddin Shafi Ahmed <
@.***> wrote:

It works fine for me.
from datetime import datetime
from fastapi import FastAPI, Query
app = FastAPI()
@app.get("/dateParm")def date_param(mydate: datetime = Query("2022-04-06T00:00:00.000Z")):
print(mydate)
print(type(mydate))
return {"result": True}
Gives:
INFO:     Started server process [15420]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)
2023-04-06 00:00:00+00:00
<class 'datetime.datetime'>
INFO:     <IP_ADDRESS>:51239 - "GET /dateParm?mydate=2023-04-06T00%3A00%3A00.000Z HTTP/1.1" 200 OK
—
Reply to this email directly, view it on GitHub
https://github.com/tiangolo/fastapi/issues/5760#issuecomment-1346870741,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6Q3MATJWYXGHA77RMVMC3WM5J6TANCNFSM6AAAAAASYIN4WQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

If you pass datetime object to date variable , it is expected to fail.
This has nothing to do with FastAPI. The validation is done by Pydantic.

Try this,

from datetime import datetime, date

from fastapi import FastAPI, Query

app = FastAPI()

@app.get("/dateParm")
def date_param(mydate: datetime | date = Query("2022-04-06T00:00:00.000Z")):
    print(mydate)
    print(type(mydate))
    return {"result": True}

Thanks for the reply. Does Pydantic actually do the marshalling of the
data, or just the validation? If it decodes the data, do you think it's
reasonable to suggest a fix since the string is an ISO standard.
Steve
On Wed, Dec 14, 2022 at 10:58 AM Irfanuddin Shafi Ahmed <
@.***> wrote:

Try this,
from datetime import datetime, date
from fastapi import FastAPI, Query
app = FastAPI()
@app.get("/dateParm")
def date_param(mydate: datetime | date = Query("2022-04-06T00:00:00.000Z")):
print(mydate)
print(type(mydate))
return {"result": True}
—
Reply to this email directly, view it on GitHub
https://github.com/tiangolo/fastapi/issues/5760#issuecomment-1351685737,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6Q3MCZW6MTGXXKSWCIE7DWNHVDTANCNFSM6AAAAAASYIN4WQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Pydantic serializes and deserialize data as well. And it is rightly doing so in this case.
In python, if you give ISO datetime string, your type should be datetime. If you want date then send only date as a string. You can always extract date from a datetime object as well.


Allowing on-prem azure devops repos

:clipboard: Description
Hello,
the current azure service seems to be hardwired to work only with the public domain https://dev.azure.com. I looked into extending the service to accept an azure base url. But this doesn't seem easily possible, a couple of other services allow baseurls to be supplied. I wasn't able to fiddle one in for azure myself :'( Perhaps someone better at js would have an easier time?
Cheers,
Manuel

I'm actually going to close this as a duplicate of #3429
In particular I'd point back to https://github.com/badges/shields/issues/3429#issuecomment-489795661 and the second point within relative to API compatibility. We do have precedent for this with SonarCloud vs. SonarQube, but I know the API surface for Azure DevOps Server has evolved enough over the years that I'd still strongly suggest we start with some form of versioning scheme


Levels LoS overwrites ATV LoS with "Points on token" algorithm

I am so fond of your module that I am bothering you with a 3rd issue this morning :)
It seems  that Levels LoS overwrite ATV LoS when "Points on token" algorithm is selected. On the other hand, it works correctly (using ATV LoS algorithm) if you select Area 2D or 3D algorithm.
The problem about Levels LoS is that it uses a center-center or center-corners algorithm (enabled or disabled by selecting "Precise token visibility" option in Levels settings).
LoS decided by Levels (corner of the token)

Levels activated and Precise token visibility selected
ATV set to Points on token and Foundry default (9 points)

LoS decided by ATV

Levels deactivated
ATV set to Points on token and Foundry default (9 points)

Can you just unselect Precise token visibility? Or does that still not work?

Even if you just unselect Precise token visibility, it still does not work.

This will be fixed in v0.6.0. It will no longer defer to Levels. In addition, you can approximately replicate the Levels' Precise token visibility and Exact token visibility by using the inset control I am adding in v0.6.0.


How to check if a file exists

Hi,
I looked at the source code but I didn't find how to check if a file exists before reading.
Thanks

Hey @alecava58, the user can only select files that are present. You can indeed have a file handle for a file longer than the actual file lives. I will explore the exact behavior for this and ensure there is a way to discover if the file no longer exists.

Hi Kristoffer, thanks for quick reply.
What I'm looking for is a function like System.IO.File.Exists(filename) and if the function returns true upload the file in client memory.

You can't open arbitrary files. Only files that the user has directly opened or files present in directories that the user has chosen directly. In the directory case, you can very easily get a list of all files and folders in it and continue from there.

Ok. I understand.
Thanks for sharing your useful library.

I'm keeping this issue open to explore what exceptions we should get when trying to read a file that has been moved.


Prevent "cannot use a string pattern on a bytes-like object"

Fixes #21207

Thanks, looks good.

Cherry-picked for 3.0.7.


🐛[BUG] Impossible to get data from Input.Group in renderFormItem

🐛 bug
I've created a column called Price which consists of Input.Group and 3 Inputs, I'm planning to use data from this Input.Group in the request method of ProTable. The problem is when I click on the Query button values from Input.Group don't pass to request params
📷 复现步骤 [清晰描述复现步骤，让别人也能看到问题] Steps to reproduce

🏞 期望结果 [描述你原本期望看到的结果] Expected result
Data from Input.Group should pass to the request method.
💻 复现代码 [提供可复现的代码，仓库，或线上示例] Reproducible code
Column code:
`{
  title: 'Price',
  dataIndex: 'price',
  renderFormItem: (item, props) => (
    <Input.Group compact {...props}>
      <Input
        style={{ width: 100, textAlign: 'center' }}
        placeholder="Minimum"
      />
      <Input
        className="site-input-split"
        style={{
          width: 30,
          borderLeft: 0,
          borderRight: 0,
          pointerEvents: 'none',
        }}
        placeholder="~"
        disabled
      />
      <Input
        className="site-input-right"
        style={{
          width: 100,
          textAlign: 'center',
        }}
        placeholder="Maximum"
      />
    </Input.Group>
  ),
},

`
Pro-table code:
`<ProTable
      headerTitle="Inquiry form"
      actionRef={actionRef}
      rowKey="id"
      toolBarRender={(action, { selectedRows }) => [
        <Button
          icon={<PlusOutlined />}
          type="primary"
          onClick={() => handleModalVisible(true)}>
          New
        </Button>,
        selectedRows && selectedRows.length > 0 && (
          <Dropdown
            overlay={
              <Menu
                onClick={async e => {
                  console.log('delete');
                  console.log(e.key);
                  if (e.key === 'remove') {
                    await handleRemove(selectedRows);
                    action.reload();
                  }
                }}
                selectedKeys={[]}>
                <Menu.Item key="remove">Delete</Menu.Item>
                <Menu.Item key="approval">Batch approval</Menu.Item>
              </Menu>
            }>
            <Button>
              Actions <DownOutlined />
            </Button>
          </Dropdown>
        ),
      ]}
      tableAlertRender={(selectedRowKeys, selectedRows) => (

          chosen{' '}

            {selectedRowKeys.length}
          {' '}
          item

            Total number of service calls{' '}
            {selectedRows.reduce((pre, item) => pre + item.callNo, 0)} Ten
            thousand

      )}
      request={params => queryRule(params)}
      columns={columns}
      rowSelection={{}}
    />`

© 版本信息

"@ant-design/pro-layout": "^5.0.8",
"@ant-design/pro-table": "2.1.11",
"antd": "^4.1.0",
"umi-request": "^1.2.19"

Input.Group don't have value and onChage
you need create a component

I replaced Input.Group with a div tag and now the div tag has value attribute but this attribute saves only the last value entered in one of the inputs (minimum or maximum). For example, if you enter 22 in minimum input and click "查 询" the div has a value 22 than if you enter 33 in maximum input the div has value 33. What I want to achieve is that when I enter a number in both inputs it should return me values from both inputs.
Please take a look an example: https://codesandbox.io/s/dumi-demo-qz2kr?file=/demo.tsx
After click on "查 询" pay attention to the console output, there you'll see Object with a key called price, the price has only one number not two from minimum and maximum inputs.

+1 me too!


fix: blocking during image upload

Fixed blocking when uploading images from files or clipboard.

Hi, the interaction sent by the block user when the file is uploaded is not very reasonable, especially if the user may encounter a weak network

Are there any reasons about why blocking user during image uploading?


Roll engine 75387dbc147d..089c740841e8 (29 commits)

https://github.com/flutter/engine/compare/75387dbc147d...089c740841e8
git log 75387dbc147d1cee8164f5d61582eab8ba1e5058..089c740841e8f9f43cfbe9cd119a228da5fbe4d1 --no-merges --oneline
089c74084 Roll fuchsia/sdk/core/mac-amd64 from lCQWEeR_Ert7t_qAbMRycwrRyZC-dIprYPyPJzwPmg4C to EYnRdXFT9l-d8Qkz4zeTRXnqfV3KQzpQhoPs1r0-740C (flutter/engine#9759)
b22410ef6 Include SkParagraph headers only when the enable-skshaper flag is on (flutter/engine#9758)
2cd650d26 Minimal integration with the Skia text shaper module (flutter/engine#9556)
f775f5e4d Re-enable the Wuffs GIF decoder (flutter/engine#9466)
aca048236 Make all shell unit tests use the OpenGL rasterizer. (flutter/engine#9746)
bc57291ff Make FLEViewController's view an internal detail (flutter/engine#9741)
9776043ea Synchronize main thread and gpu thread for first render frame (flutter/engine#9506)
f600ae830 Use libc++ variant of string view and remove the FML variant. (flutter/engine#9737)
564f53f0a Revert "Improve caching limits for Skia (#9503)" (flutter/engine#9740)
b453d3c3d libtxt: fix reference counting of SkFontStyleSets held by font asset providers (flutter/engine#9561)
fa7627d17 Fix backspace crash on Chinese devices (flutter/engine#9734)
56885f79b Let pushColorFilter accept all types of ColorFilters (flutter/engine#9641)
6dccb21e6 Roll src/third_party/skia 96fdfe0fe88e..af4e7b6cf616 (1 commits) (flutter/engine#9735)
8511d9b47 Roll fuchsia/sdk/core/mac-amd64 from byM-kyxL4bemlTYNqhKUfJfZoIUrCSzS6XzsFr4n9-MC to lCQWEeR_Ert7t_qAbMRycwrRyZC-dIprYPyPJzwPmg4C (flutter/engine#9742)
b3bf0a182 Roll fuchsia/sdk/core/linux-amd64 from I2Qe1zxgckzIzMBTztvzeWYsDgcb9Fw-idSI16oIlx8C to KGmm_RIJoXS19zTm2crjM3RYpmp5Y03-fLUeVdylbTYC (flutter/engine#9743)
7e568232a Fix windows test by not attempting to open a directory as a file. (flutter/engine#9745)
6cf0d1350 Roll src/third_party/skia a3ffaabcc4f2..96fdfe0fe88e (5 commits) (flutter/engine#9731)
49a00aed8 Fix Fuchsia build. (flutter/engine#9730)
b3bb39b0b Roll src/third_party/dart 06c3d7ad3a...09fc76bc51 (flutter/engine#9728)
2284210f4 Make the license script compatible with recently changed Dart I/O stream APIs (flutter/engine#9725)
ad582b508 Rework image & texture management to use concurrent message queues. (flutter/engine#9486)
1dcd5f52b Roll src/third_party/skia 6b82cf638682..a3ffaabcc4f2 (24 commits) (flutter/engine#9726)
129979cab Revert "Roll src/third_party/dart 06c3d7ad3a..7acecda2cc (12 commits)" (flutter/engine#9724)
8020d7e43 Roll src/third_party/skia 56065d9b875f..6b82cf638682 (3 commits) (flutter/engine#9718)
e24bd7846 Roll src/third_party/dart 06c3d7ad3a..7acecda2cc (12 commits)
3d2668c35 Reland isolate group changes
802bd1518 iOS platform view opacity (flutter/engine#9667)
3b6265b74 Roll src/third_party/dart b5aeaa6796..06c3d7ad3a (44 commits)
887e05233 Refactor ColorFilter to have a native wrapper (flutter/engine#9668)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6324628232863744

Commit queue failed; closing this roll.


More locales

The ability to add locale to this list, otherwise the language keeps changing

The locale list is based on predefined values from New Bing. We cannot modify it arbitrarily.


Getting the same result for all articles !

I trained your code 20k with articles , it gives me the same summary for all articles ?
what is your results ?

results like this" islamists islamists islamists islamists islamists islamists islamists islamists islamists islamists islamists islamists islamists islamists islamists " ,why?

The code is wrong don't  use it


feat: add support for socks5 proxy

Closes https://github.com/usebruno/bruno/issues/389

Hi @rqbazan,
currently there are two runtime - implementations. Could you please add your socks proxy support for the CLI too.
https://github.com/rqbazan/bruno/blob/feat/add-support-for-socks5-proxy/packages/bruno-cli/src/runner/run-single-request.js

Hi @mirkogolze!
Sure 👍

Many Thanks @rqbazan for adding Socks5 support to Bruno 🚀 🚀
Merged!


How to update shape in RenderObjcet instead of painting from scratch

Hello.
I have a custom LeafRenderObjectWidget that receives the count of rectangles as an input parameter and draws the rectangles.
every time that paint function calls it gives a new PaintingContext so I can't save the already drawn rectangles, and I have to draw them again.
I wish I could save the previously drawn rectangles and only draw the new one.
because of the performance issues, I need to update my canvas instead of painting from scratch.
in this provided example the paint function only draws the latest rectangle.
class MyCustomShape extends LeafRenderObjectWidget {
  final int count;

  const MyCustomShape({Key? key, required this.count}) : super(key: key);

  @override
  RenderObject createRenderObject(BuildContext context) {
    return MyCustomShapeRenderObject(count);
  }

  @override
  void updateRenderObject(
      BuildContext context, covariant RenderObject renderObject) {
    MyCustomShapeRenderObject myCustomShapeRenderObject =
        renderObject as MyCustomShapeRenderObject;
    myCustomShapeRenderObject.count = count;
  }
}

class MyCustomShapeRenderObject extends RenderBox {
  late int _count;

  MyCustomShapeRenderObject(int count) {
    _count = count;
  }

  bool initialPaint = true;
  bool needTick = false;
  bool newCandle = false;
  bool needTransform = false;
  bool needHorizontalcount = false;
  bool needVerticalcount = false;
  bool needColor = false;

  set count(int value) {
    if (_count == value) {
      return;
    }
    _count = value;
    markNeedsPaint();
  }

  /// set size as large as possible
  @override
  void performLayout() {
    size = Size(constraints.maxWidth, constraints.maxHeight);
  }

  @override
  void paint(PaintingContext context, Offset offset) {
    context.canvas.drawLine(
        Offset(100 * _count.toDouble() , 0),
        Offset(100 * _count.toDouble(), 100),
        Paint()
          ..color = Colors.red
          ..strokeWidth = 10);
  }
}

also, I have tried to save the canvas using context.canvas.save() and restore it in the next paint run. but because the PaintingContext object is not the same. it can't restore the previously painted shapes.
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.0.5, on Microsoft Windows [Version 10.0.19044.1889], locale en-US)
Checking Android licenses is taking an unexpectedly long time...[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[√] Chrome - develop for the web
[!] Visual Studio - develop for Windows (Visual Studio Build Tools 2019 16.11.8)
    X The current Visual Studio installation is incomplete. Please reinstall Visual Studio.
[√] Android Studio (version 2021.2)
[√] VS Code (version 1.70.2)
[√] Connected device (2 available)
[√] HTTP Host Availability

! Doctor found issues in 1 category.

Hi @r-mzy47,
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community#community-grid for resources and asking questions like this. You may also get some help if you post it on Stack Overflow with a minimal code sample that clearly describes your problem.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and we will reopen it.
Thank you


No file error message using open_mfdataset

Code Sample, a copy-pastable example if possible
A "Minimal, Complete and Verifiable Example" will make it much easier for maintainers to help you:
http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports
# Your code here

Problem description
[this should explain why the current behavior is a problem and why the expected output is a better solution.]
Expected Output
Output of xr.show_versions()

# Paste the output here xr.show_versions() here

I am linking to an opendapp server which works fine using xarray.open_dataset(url) on individual files, but I get an error message saying:
Traceback (most recent call last):
File "", line 1, in
File "C:\Python\Anaconda2\lib\site-packages\xarray\backends\api.py", line 561, in open_mfdataset
raise IOError('no files to open')
IOError: no files to open
when using xarray.open_mfdataset(url)
url="http://opendap.bom.gov.au:8080/thredds/dodsC/agcd/tmax/anomaly/r005/01day/"+yr+"/*.nc"
I am using Anaconda. I have updated everything:
xr.show_versions()
INSTALLED VERSIONS
commit: None
python: 2.7.12.final.0
python-bits: 32
OS: Windows
OS-release: 7
machine: AMD64
processor: Intel64 Family 6 Model 60 Stepping 3, GenuineIntel
byteorder: little
LC_ALL: None
LANG: en_AU
LOCALE: None.None
xarray: 0.10.3
pandas: 0.20.3
numpy: 1.14.2
scipy: 0.17.1
netCDF4: 1.2.2
h5netcdf: None
h5py: 2.6.0
Nio: None
zarr: None
bottleneck: None
cyordereddict: None
dask: 0.17.2
distributed: 1.21.6
matplotlib: 1.5.1
cartopy: 0.15.0
seaborn: 0.7.1
setuptools: 23.0.0
pip: 9.0.1
conda: 4.4.10
pytest: 2.9.2
IPython: 4.2.0
sphinx: 1.4.1

sorry: yr is a string ie "2018"
ie url="http://opendap.bom.gov.au:8080/thredds/dodsC/agcd/tmax/anomaly/r005/01day/2018/*.nc"

Thanks for the report. Looking at open_mfdataset:
https://github.com/pydata/xarray/blob/99b457ce5859bd949cfea4671db5150c7297843a/xarray/backends/api.py#L558-L564
you'll see we are using glob to expand the path names. This is not likely to work for URLs. I'm not 100% sure if it is even possible to do a path expansion on OpenDAP datasets.
If you can do the expansion yourself, that would be the easiest workaround.

Indeed, glob does not work for URLs.
However, we could (and should) improve this error message, to clarify what's going on here. Actually, we should probably raise an error message is paths is a string starting with http:// or https:// before trying glob.


test-branch/execute-job/wrong-comment-on-pr/6f74899f-fce8-420b-b58d-8e0dc5b55d88

PR for testing 72c74516b3d461799b53843b9402d6bf10e384b8

comment 1


JoWilder: QuestionAnswers feature

A list of all answers a player attempted on a question

 JoWilder: QuestionAnswers feature

This feature is called "answers" in the old JoWilderExtractor.
It should be configured in JOWILDER.json as a per_count feature, with prefix = Q and count = 19, just as before.

441c532e16bbbf725c26bf12290f36a121f086b5


Issue with all players not being displayed

 When we get a lot of people in the server names stop appearing, and nil are people that left but not in the server any longer.

Update


Write a JDBC vector data provider

We need the ability to read vector data from JDBC data sources with a user-specified query.

Due to the lack of generic SQL available for handling spatial fields, this ticket was replaced with #463 for handling Postgis specifically.


Compatibility with Deployer 7.X

Hi,
Have you planned to make it compatible with Deployer 7.X ?

Yes, definitely, but I am unable to because of this issue: https://github.com/deployphp/deployer/issues/3485. Please voice your opinion in the issue :)
Until then we are stuck on v6 :(

You can't make a temporally patch with this solution?
https://github.com/deployphp/deployer/issues/3485#issuecomment-1482596556

As you can see from my comments it doesn't work

I missed it 😭

I just released an 1.0.0@alpha that works in my tests that is compatible with v7. Maybe you could test it out?


Fix ensureEnds function to use File.separator instead of default "/" …

…unix separator

ensureEnds function always look for "/" (unix file separator) even on
windows. This causes issues in Jenkins when your workspace is T:\
If you use custom workspace and set to T:\ or some root drive then
ensureEnds function adds additional "" resulting in "T:\".
getRelativepath which uses this function then ends up adding
".." in remote target path. This results in 500 error from artifactory.
Deploying artifact: https://artifactory.garmin.com/artifactory/Marine-Builds/Regression/ByJob/Mar-Man-openstack-win-TEST/19/../Artifacts/me.txt
ERROR: remote file operation failed: T:\ at hudson.remoting.Channel@522d50a:os-cw7x-e1c: java.io.IOException: Failed to deploy file. Status code: 500 Response message: Artifactory returned the following errors:
Path element cannot end with a dot: Marine-Builds/Regression/ByJob/Mar-Man-openstack-win-TEST/19/../ Status code: 500

This patch addresses this issue by fixing ensureEnds to check for
passed in separator instead of default "/"

Change-Id: Ib08c01ba235e51b2bb752f929805eee8f4fa4407

How to reproduce the error

Jenkins 2.73.2 and configure artifactory plugin in global configuration
Latest artifactory plugin
Download spec with spec referenced below

        {
            "files":
            [
                {
                    "pattern": "Artifacts/**",
                    "target": "M-Builds/Regression/ByJob/$JOB_NAME/$BUILD_NUMBER/",
                    "flat": "False",
                    "explode": "False"
                }
            ]
        }

Have a shell step with the following script.

echo "hello from test job"
if [ -d Artifacts ]; then
  rm -rf Artifacts
fi
mkdir Artifacts
touch Artifacts/me.txt
touch Artifacts/me2.txt

Run the job to reproduce the error
Now rerun the same job with this fix for build-info-extractor library.

Thanks for contributing the code @sendil-d!
I added another commit on top of yours, to further simplify the code.

cool thanks for improving it further.
Do you know when this change will be pulled in to https://github.com/JFrogDev/jenkins-artifactory-plugin?
Thanks for your help.
Sendil

@sendil-d,
The upcoming Jenkins Artifactory Plugin release will include this fix. We don't yet have a final ETA for the release though.
We can publish a snapshot version which includes this fix if you'd like.

Ok. Thanks. I will wait for the future release.
Sendil
On Tue, Mar 27, 2018 at 5:33 PM, Eyal Ben Moshe<EMAIL_ADDRESS>wrote:

@sendil-d https://github.com/sendil-d,
The upcoming Jenkins Artifactory Plugin release will include this fix. We
don't yet have a final ETA for the release though.
We can publish a snapshot version which includes this fix if you'd like.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JFrogDev/build-info/pull/159#issuecomment-376697818,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aj9WPb8RqdBS1MJsKsKTulXBQHGsCqBKks5tir5WgaJpZM4S4_Bh
.


Added a new benchmark

This adds a new benchmark that corresponds better to plaintext tech empower.
The results are significantly different:

BenchmarkDotNet=v<IP_ADDRESS>6-develop, OS=Microsoft Windows 10.0.14393
Processor=Intel(R) Core(TM) i7-6700 CPU 3.40GHz, ProcessorCount=8
Frequency=3328130 Hz, Resolution=300.4690 ns, Timer=TSC
dotnet cli version=1.0.0
  [Host]     : .NET Core 4.6.25009.03, 64bit RyuJIT
  Job-XONKRQ : .NET Core 4.6.25009.03, 64bit RyuJIT

RemoveOutliers=False  Runtime=Core  Server=True
LaunchCount=3  RunStrategy=Throughput  TargetCount=10
WarmupCount=5

Method
ParserType
Mean
StdErr
StdDev
Median
Scaled
Scaled-StdDev
RPS
Allocated

ParsePlaintext
Microsoft.AspNetCore.Server.Kestrel.Internal.Http.KestrelHttpParser
1,092.6828 ns
4.1382 ns
22.6660 ns
1,087.1981 ns
1.00
0.00
915,178.65
105 B

ParsePlaintextEmpower
Microsoft.AspNetCore.Server.Kestrel.Internal.Http.KestrelHttpParser
1,727.7537 ns
2.0451 ns
11.2017 ns
1,728.1608 ns
1.58
0.03
578,786.21
350 B

ParsePipelinedPlaintext
Microsoft.AspNetCore.Server.Kestrel.Internal.Http.KestrelHttpParser
905.7965 ns
1.0490 ns
5.7455 ns
905.0324 ns
0.83
0.02
1,104,000.78
105 B

ParseLiveAspNet
Microsoft.AspNetCore.Server.Kestrel.Internal.Http.KestrelHttpParser
4,099.8906 ns
12.7577 ns
69.8771 ns
4,085.0964 ns
3.75
0.09
243,908.95
1.12 kB

ParsePipelinedLiveAspNet
Microsoft.AspNetCore.Server.Kestrel.Internal.Http.KestrelHttpParser
4,223.0298 ns
10.7948 ns
59.1254 ns
4,206.6177 ns
3.87
0.09
236,796.82
1.12 kB

ParseUnicode
Microsoft.AspNetCore.Server.Kestrel.Internal.Http.KestrelHttpParser
7,703.6693 ns
86.9043 ns
475.9947 ns
7,460.3653 ns
7.05
0.45
129,808.27
1.97 kB

ParseUnicodePipelined
Microsoft.AspNetCore.Server.Kestrel.Internal.Http.KestrelHttpParser
8,034.6914 ns
24.9243 ns
136.5158 ns
7,972.3444 ns
7.36
0.19
124,460.29
1.97 kB

BTW, should we trim the names of the "parser type"? The table got very wide.

@KrzysztofCwalina,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

cc: @shiftylogic

Add a pipelined version also?
Does it included a Connection header? (Is implied by HTTP1.1)
On 2 March 2017 at 16:44, Krzysztof Cwalina<EMAIL_ADDRESS>wrote:

This adds a new benchmark that corresponds better to plaintext tech
empower.
The results are significantly different:
BenchmarkDotNet=v<IP_ADDRESS>6-develop, OS=Microsoft Windows 10.0.14393Processor=Intel(R) Core(TM) i7-6700 CPU 3.40GHz, ProcessorCount=8Frequency=3328130 Hz, Resolution=300.4690 ns, Timer=TSC
dotnet cli version=1.0.0
[Host]     : .NET Core 4.6.25009.03, 64bit RyuJIT
Job-XONKRQ : .NET Core 4.6.25009.03, 64bit RyuJIT
RemoveOutliers=False  Runtime=Core  Server=True  LaunchCount=3  RunStrategy=Throughput  TargetCount=10  WarmupCount=5
Method ParserType Mean StdErr StdDev Median Scaled Scaled-StdDev RPS
Allocated
ParsePlaintext Microsoft.AspNetCore.Server.Kestrel.Internal.Http.
KestrelHttpParser 1,092.6828 ns 4.1382 ns 22.6660 ns 1,087.1981 ns 1.00
0.00 915,178.65 105 B
ParsePlaintextEmpower Microsoft.AspNetCore.Server.Kestrel.Internal.Http.
KestrelHttpParser 1,727.7537 ns 2.0451 ns 11.2017 ns 1,728.1608 ns 1.58
0.03 578,786.21 350 B
ParsePipelinedPlaintext Microsoft.AspNetCore.Server.Kestrel.Internal.Http.
KestrelHttpParser 905.7965 ns 1.0490 ns 5.7455 ns 905.0324 ns 0.83 0.02
1,104,000.78 105 B
ParseLiveAspNet Microsoft.AspNetCore.Server.Kestrel.Internal.Http.
KestrelHttpParser 4,099.8906 ns 12.7577 ns 69.8771 ns 4,085.0964 ns 3.75
0.09 243,908.95 1.12 kB
ParsePipelinedLiveAspNet Microsoft.AspNetCore.Server.
Kestrel.Internal.Http.KestrelHttpParser 4,223.0298 ns 10.7948 ns 59.1254
ns 4,206.6177 ns 3.87 0.09 236,796.82 1.12 kB
ParseUnicode Microsoft.AspNetCore.Server.Kestrel.Internal.Http.
KestrelHttpParser 7,703.6693 ns 86.9043 ns 475.9947 ns 7,460.3653 ns 7.05
0.45 129,808.27 1.97 kB
ParseUnicodePipelined Microsoft.AspNetCore.Server.Kestrel.Internal.Http.
KestrelHttpParser 8,034.6914 ns 24.9243 ns 136.5158 ns 7,972.3444 ns 7.36
0.19 124,460.29 1.97 kB
BTW, should we trim the names of the "parser type"? The table got very wide.

You can view, comment on, or merge this pull request online at:
https://github.com/aspnet/KestrelHttpServer/pull/1424
Commit Summary

Added a new benchmark

File Changes

M test/Microsoft.AspNetCore.Server.Kestrel.Performance/
RequestParsing.cs
https://github.com/aspnet/KestrelHttpServer/pull/1424/files#diff-0
(15)

Patch Links:

https://github.com/aspnet/KestrelHttpServer/pull/1424.patch
https://github.com/aspnet/KestrelHttpServer/pull/1424.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/KestrelHttpServer/pull/1424, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABFwrqUt-GcBk5OYSH-FHFHIDL78775yks5rhvHVgaJpZM4MRO8U
.

@benaadams, could you please fix formatting of your comment? Seems like you are using some tool to respond and it made a bit of a mess.

Fixed, replied via email :)

I think it would be good to add pipelined version, but the tests already take long to run. I would almost say we should remove  the test that does not send any headers, but I wanted to keep it for now so we know the initial delta, as the removal would reset the baseline.
As to connection header, I got the headers list from @davidfowl. The connection header was not there.

@KrzysztofCwalina we need to add this benchmark in feature/dev-si as well (that's the baseline)

Changed headers, renamed the fields, and updated the perf results with now just 2 headers.

@davidfowl, I will submit a similar PR to dev-si


chore(workflows): switch Ubuntu runners to 24.04

:tada: This PR is included in version 2.2.10 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Buffer usage

Support plan

Which support plan is this issue covered by? (Community, Sponsor, Enterprise):Community
Currently blocking your project/work? (yes/no):Yes
Affecting a production system? (yes/no):Yes

Context

Node.js version: v18.16.0
Release Line of Formidable (Legacy, Current, Next):Current
Formidable exact version: 3.5.1
Environment (node, browser, native, OS): v18.16.0, Brave, Linux, PopOS
Used with (popular names of modules): @prisma/client, @cosmicjs/sdk

What are you trying to achieve or the steps to reproduce?

import cosmic from "~~/lib/cosmic.mjs";
import formidable from "formidable";

export default defineEventHandler(async (event) => {
  if ((event.node.req.method = "POST")) {
    const form = formidable({});
    await form.parse(event.node.req, (err, fields, files) => {
      if (err) {
        console.log(err);
        return;
      }
      console.table(files?.file[0]);
      const media = /*files?.file[0]*/ {
        originalname: files?.file[0].originalFilename,
        buffer: files?.file[0].buffer,
      };
      //console.log(media);
      return { media };
    });
    /*console.log(media);
    try {
      const data = await cosmic.media.insertOne({
        media: media,
        folder: "nuxt-test",
      });
      return { Success: true, data };
    } catch (error) {
      console.log(error.message);
    }*/
  }
});

What was the result you got?
None. Coz I cannot get a buffer
What result did you expect?
A buffer  Ican use to upload the image coz the cosmic API need a buffer

Search for similar issues and examples

@R0N1n-dev
I think you can check this example https://github.com/node-formidable/formidable/blob/master/examples/forceBuffer.js


fix/feat: make SearchBar's view height adjustable; add new properties

Description
Fixes #3985 #4081
Test Code
import flet as ft

def main(page: ft.Page):
    page.window.always_on_top = True
    page.theme_mode = ft.ThemeMode.LIGHT
    page.add(
        ft.SearchBar(
            controls=[ft.ListTile(title=ft.Text("Hello"))],
            view_header_height=30,
            on_tap=lambda e: e.control.open_view(),
            width=350,
            view_size_constraints=ft.BoxConstraints(max_height=170, max_width=350),
            bar_hint_text="Search",
            bar_hint_text_style={
                ft.ControlState.HOVERED: ft.TextStyle(color=ft.colors.YELLOW, size=20)
            },
            bar_padding=ft.padding.symmetric(10, 10),
            bar_text_style=ft.TextStyle(color=ft.colors.RED, size=20),
            bar_border_side=ft.BorderSide(color=ft.colors.BLUE, width=2),
            bar_shape=ft.RoundedRectangleBorder(radius=0),
            bar_elevation=00.0,
            view_elevation=5.0,
            bar_shadow_color=ft.colors.BLUE,
        )
    )

ft.app(target=main, view=ft.AppView.WEB_BROWSER)

Summary by Sourcery
Fix the SearchBar component to make its view height adjustable and enhance it by adding properties for view size constraints and header height, allowing for more flexible layout configurations.
Bug Fixes:

Fix the issue with the SearchBar component by making its view height adjustable.

Enhancements:

Add support for view_size_constraints and view_header_height properties in the SearchBar component to allow more flexible layout configurations.

Summary by Sourcery
Make the SearchBar component's view height adjustable and enhance its flexibility by adding new properties for layout and style customization. Introduce utility functions for parsing widget state properties to support dynamic configurations.
Bug Fixes:

Fix the issue with the SearchBar component by making its view height adjustable.

Enhancements:

Add support for view_size_constraints and view_header_height properties in the SearchBar component to allow more flexible layout configurations.
Introduce new properties for SearchBar such as bar_shadow_color, bar_surface_tint_color, bar_elevation, bar_border_side, bar_shape, bar_text_style, bar_hint_text_style, and bar_padding to enhance customization options.
Implement new utility functions for parsing widget state properties, including parseWidgetStateDouble, parseWidgetStateInt, parseWidgetStateBool, parseWidgetStateEdgeInsets, parseWidgetStateOutlinedBorder, and parseWidgetStateTextStyle to support dynamic property handling.

@sourcery-ai review

Hi,
Thank you for that.
I've just upgrade the Flet but even so the new properties aren't available. Will they be available in  a new version realise?

They are available in the latest prerelease: pip install flet --pre -U


Cannot convert value of type 'String?' to type 'OptionalArgument'

Describe the bug
A clear and concise description of what the bug is.
Forced to cast optional values with OptionalArgument(some-value) instead of being able to pass swift optionals directly inside of Selection.Mutation's
The Error(s):
Cannot convert value of type 'String?' to expected argument type 'OptionalArgument<String>' or Cannot convert value of type '[String]?' to expected argument type 'OptionalArgument<[String]>'  when trying to pass optional values to a Selection.Mutation
To Reproduce
Steps to reproduce the behavior:
struct UserDao: Identifiable {
  let id: String
  let name: String?
}

struct CreateUser {
  let user: UserDao
  let errors: [String]
}

struct UserForm {
  let id: String
  let name: String?
}

private static func userSelection() -> Selection<UserDao, Objects.User> {
    return  Selection.User {
      UserDao(id: try $0.id(), name: try $0. name())
  }
}

static func updateUser(form: UserForm) {
   let user = userSelection()

   let updateUser = Selection.UpdateUserPayload { u in
      CreateUser(user: try u.user(selection: user), errors: try u.errors())
   }

  // Name errors here
  let query = Selection.Mutation {
      try $0.updateUser(id: form.id, name: name, selection: updateUser.nullable)
  }

  // If changed to below it will work fine:
  let name = OptionalArgument(form.name)
  let query2 = Selection.Mutation {
       try $0.updateUser(id: form.id, name: name, selection: updateUser.nullable)
   }
}

Expected behavior
Expect to be able to pass swift optional types directly into the Selection Mutation without conversion.
Screenshots
n/a
Smartphone (please complete the following information):

Device: iPhone 12 simulator
OS: iOS 12
Browser: n/a
Version n/a

Additional context
Maybe this is working as intended and should be a feature request/enhancement

Hey 👋 !
Thank you for opening this issue! Yea, it's not exactly a feature but not a bug either. OptionalArgument is not exactly the same as a Swift Optional value.  I suggest you check out the docs that have an updated section on OptionalArgument type https://www.swift-graphql.com/docs/querying#optional-arguments.

If you are curious why we need a completely different structure to represent optional values, it's because the way OptionalArgument is implemented, it can self-reference itself, which is a common thing in the input parameters of the GraphQL schemas (e.g. a filtering tree structure that references itself).


Update API calls from V1 endpoints

Either move to the latest endpoint, or since we are already bringing in the SDK into the block, change to using that instead
Opinion @Bucknalla ?

@phil-d-wilson yeah I think we just standardise using the SDK if we're already using it

@phil-d-wilson I was talking with Carlo and he's been actually working in the background to fix this for some of the QA work he's been doing for the Fin so he will be pushing a branch shortly that addresses a bunch of things. It should also be ES6 compliant so it'll be super easy to take what I started working on for the TS rewrite and apply that as well.

Sounds great @Bucknalla ! I'm happy to contribute to the TS work.

@phil-d-wilson @Bucknalla WIP PR here https://github.com/balenablocks/finabler/pull/29

@phil-d-wilson @Bucknalla was this resolved with #31 since that took place of #29 in a reorganization?

@mehalter yes!


I want the LSP Hover Request to show the structure of a definition when I hover over its name

As an AaC user of the LSP, I want the LSP Hover Request to show the structure of a definition when I hover over its name, so that I can access the structure of a definition on-demand.
AC:

[x] When the user hovers over the name of a definition in the context, the definition's structure is returned as the hover response content

This should be merged after #377 as I branched from that.

I was having a lot of fun testing this out, but I noticed that the window is a little small, but this seems like a long-lived issue in VSCode: https://github.com/microsoft/vscode/issues/14165


parallelize topic sub/unsub handles

Coverage remained the same at 97.428% when pulling e5d9c8af59c8689893de77acd077738132f021a3 on behrad:parallelize_sub_handle into 7e1fdebc7c2f543ea0703e33aa4d38791109f251 on mcollina:master.

thx


Need ruby version on prompt

What do you mean? What about making your own prompt using the git_super_status function? Reopen if this does not address your question.


Add async logic to DELETE

Adapt existing async polling
Add GC summary

Testing:

manual testing with demo_server as-is and temporarily modified to return location header on delete

Closes #655 #653


Write tests with jest (Coverage 100%)

As promised, here the tests written in jest.
Created a second pull request, so that you have it easier to test your workflow with the
updated dependencies.
For the tests to work I did the following:

[x] all the steps from my other PR #14
[x] cleaned up package.json and removed unneeded entries
[x] added jest (^3.6.0), jest-styled-components (^6.2.2), react (^16.6.0), react-dom (^16.6.0),
react-test-renderer (^16.6.0), @babel/preset-react (^7.0.0), babel-jest (^23.6.0) &
babel-core (^7.0.0-bridge.0, needed for jest to work flawlessly with Babel 7) as devDependencies
[x] wrote tests for convertors.js (Line, Function & Statement Coverage @ 100%,
Branch Coverage @ 80%)
[x] wrote tests for index.js (Line, Function & Statement Coverage @ 100%,
Branch Coverage @ 83.33%)

=============================== Coverage summary ===============================
Statements   : 100% ( 36/36 )
Branches     : 81.82% ( 9/11 )
Functions    : 100% ( 14/14 )
Lines        : 100% ( 30/30 )
================================================================================

Things that might be further done:

bump Branch coverage to 100% (but as some of the branches jest complains about are private
I have no clue at the moment, how this could be done)
Add test report to README.md to "brag about it" ^^

"Breaking" changes:

Adding react & react-dom at their latest version is necessary for the tests - but as they are deps
for styled-components v4, too, Users should already have them, as mentioned in the last PR
Having all the new glitter (this does not really change anything, but adds a nice touch ; )

I squashed the commits for your convenience.
Edit: Nearly forgot: This PR closes #1

@timhagn do you think you can resolve the conflicts and rebase? that'd be helpful! but if you can't no worries :)

#done : )

Will close this for now and open another, less intrusive one : ).


Add automated testing using Travis CI

41 undefined names (variables that are not defined or imported -- May raise NameError at runtime)
flake8 testing of https://github.com/zephyrproject-rtos/zephyr on Python 3.7.
$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
./doc/conf.py:71:4: F821 undefined name 'tags'
if tags.has("svgconvert"):
   ^
./doc/conf.py:194:4: F821 undefined name 'tags'
if tags.has('release'):
   ^
./scripts/dts/gen_defines.py:191:9: F821 undefined name '_err'
        _err("missing 'label' property on {!r}".format(dev.parent))
        ^
./scripts/dts/testdtlib.py:1215:46: F821 undefined name 'alias'
            fail("no node found for path " + alias)
                                             ^
./scripts/dts/dtlib.py:243:29: F821 undefined name '_T_LABEL'
            elif tok.id in (_T_LABEL, _T_REF):
                            ^
./scripts/dts/dtlib.py:243:39: F821 undefined name '_T_REF'
            elif tok.id in (_T_LABEL, _T_REF):
                                      ^
./scripts/dts/dtlib.py:247:30: F821 undefined name '_T_LABEL'
                if tok.id is _T_LABEL:
                             ^
./scripts/dts/dtlib.py:250:38: F821 undefined name '_T_REF'
                    if tok.id is not _T_REF:
                                     ^
./scripts/dts/dtlib.py:264:28: F821 undefined name '_T_DEL_NODE'
            elif tok.id is _T_DEL_NODE:
                           ^
./scripts/dts/dtlib.py:271:28: F821 undefined name '_T_OMIT_IF_NO_REF'
            elif tok.id is _T_OMIT_IF_NO_REF:
                           ^
./scripts/dts/dtlib.py:278:28: F821 undefined name '_T_EOF'
            elif tok.id is _T_EOF:
                           ^
./scripts/dts/dtlib.py:292:40: F821 undefined name '_T_DTS_V1'
        while self._peek_token().id is _T_DTS_V1:
                                       ^
./scripts/dts/dtlib.py:297:41: F821 undefined name '_T_PLUGIN'
            if self._peek_token().id is _T_PLUGIN:
                                        ^
./scripts/dts/dtlib.py:310:44: F821 undefined name '_T_LABEL'
            while self._peek_token().id is _T_LABEL:
                                           ^
./scripts/dts/dtlib.py:313:41: F821 undefined name '_T_MEMRESERVE'
            if self._peek_token().id is _T_MEMRESERVE:
                                        ^
./scripts/dts/dtlib.py:373:28: F821 undefined name '_T_DEL_NODE'
            elif tok.id is _T_DEL_NODE:
                           ^
./scripts/dts/dtlib.py:381:28: F821 undefined name '_T_DEL_PROP'
            elif tok.id is _T_DEL_PROP:
                           ^
./scripts/dts/dtlib.py:404:26: F821 undefined name '_T_LABEL'
            if tok.id is _T_LABEL:
                         ^
./scripts/dts/dtlib.py:406:28: F821 undefined name '_T_OMIT_IF_NO_REF'
            elif tok.id is _T_OMIT_IF_NO_REF:
                           ^
./scripts/dts/dtlib.py:436:28: F821 undefined name '_T_BITS'
            elif tok.id is _T_BITS:
                           ^
./scripts/dts/dtlib.py:446:28: F821 undefined name '_T_CHAR_LITERAL'
            elif tok.id is _T_CHAR_LITERAL:
                           ^
./scripts/dts/dtlib.py:452:28: F821 undefined name '_T_STRING'
            elif tok.id is _T_STRING:
                           ^
./scripts/dts/dtlib.py:455:28: F821 undefined name '_T_REF'
            elif tok.id is _T_REF:
                           ^
./scripts/dts/dtlib.py:458:28: F821 undefined name '_T_INCBIN'
            elif tok.id is _T_INCBIN:
                           ^
./scripts/dts/dtlib.py:479:26: F821 undefined name '_T_REF'
            if tok.id is _T_REF:
                         ^
./scripts/dts/dtlib.py:486:28: F821 undefined name '_T_LABEL'
            elif tok.id is _T_LABEL:
                           ^
./scripts/dts/dtlib.py:514:28: F821 undefined name '_T_LABEL'
            elif tok.id is _T_LABEL:
                           ^
./scripts/dts/dtlib.py:535:26: F821 undefined name '_T_STRING'
        if tok.id is not _T_STRING:
                         ^
./scripts/dts/dtlib.py:567:30: F821 undefined name '_T_LABEL'
            if tok.id is not _T_LABEL:
                             ^
./scripts/dts/dtlib.py:615:31: F821 undefined name '_T_CHAR_LITERAL'
        if tok.id in (_T_NUM, _T_CHAR_LITERAL):
                              ^
./scripts/dts/dtlib.py:806:26: F821 undefined name '_T_SKIP'
            if tok_id is _T_SKIP:
                         ^
./scripts/dts/dtlib.py:812:26: F821 undefined name '_T_INCLUDE'
            if tok_id is _T_INCLUDE:
                         ^
./scripts/dts/dtlib.py:821:26: F821 undefined name '_T_LINE'
            if tok_id is _T_LINE:
                         ^
./scripts/dts/dtlib.py:827:26: F821 undefined name '_T_EOF'
            if tok_id is _T_EOF:
                         ^
./scripts/dts/dtlib.py:831:31: F821 undefined name '_T_EOF'
                return _Token(_T_EOF, "<EOF>")
                              ^
./scripts/dts/dtlib.py:835:27: F821 undefined name '_T_DEL_PROP'
            if tok_id in (_T_DEL_PROP, _T_DEL_NODE, _T_OMIT_IF_NO_REF) or \
                          ^
./scripts/dts/dtlib.py:835:40: F821 undefined name '_T_DEL_NODE'
            if tok_id in (_T_DEL_PROP, _T_DEL_NODE, _T_OMIT_IF_NO_REF) or \
                                       ^
./scripts/dts/dtlib.py:835:53: F821 undefined name '_T_OMIT_IF_NO_REF'
            if tok_id in (_T_DEL_PROP, _T_DEL_NODE, _T_OMIT_IF_NO_REF) or \
                                                    ^
./scripts/dts/dtlib.py:843:29: F821 undefined name '_T_MEMRESERVE'
            elif tok_id in (_T_MEMRESERVE, _T_BITS) or tok_val == "]":
                            ^
./scripts/dts/dtlib.py:843:44: F821 undefined name '_T_BITS'
            elif tok_id in (_T_MEMRESERVE, _T_BITS) or tok_val == "]":
                                           ^
./scripts/dts/dtlib.py:918:28: F821 undefined name '_T_REF'
        if label.id is not _T_REF:
                           ^
41    F821 undefined name 'tags'
41

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.

F821: undefined name name
F822: undefined name name in __all__
F823: local variable name referenced before assignment
E901: SyntaxError or IndentationError
E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree

We've started to have pylint run as part of our CI flow.  Is this still relevant?

https://lukeplant.me.uk/blog/posts/pylint-false-positives

lukeplant.me.uk/blog/posts/pylint-false-positives

Adding @ulfalizer one of our resident python experts.

@cclauss
Hello,
Those are all false positives, and are suppressed in our automatic pylint check that just got integrated. We've fixed all the warnings from pylint (and suppressed a few false positive ones).
There's a # pylint: disable=undefined-variable for tags in doc/conf.py for example.
Our pylint configuration is here.

For what it's worth, I agree that pylint's default configuration is way too nitty. Useful warnings tend to get drowned out in a flood of complaints about short variable names and wrong hanging indents and stuff.
pylint can be tamed into a useful and non-annoying tool though. I summed up what warnings I left disabled here, along with motivations.


docs(sandbox): add rfc for persisting options and values

What?
Include an RFC for persisting options and data values.
Why?
Each field plugin usually has a sort of different options defined, and
it's common either to refresh the Field Plugin Sandbox page during
development/test or to switch from one field plugin to another.
Doing so, it would be nice to, somehow, persist both options and their
corresponding values. This way the user would not need to recreate all
of them while refreshing the Sandbox page or switching between field plugins.
This PR opens a discussion on how we should proceed in dealing with this scenario.
[View Rendered →]

After scanning trough your RFC, here is just me thinking out loud:
What if we in a way combined the approaches? So per default, we would store the information inside the local storage. In case the user wants to share the sandbox, there would be a button that would generate the URL with the encrypted query parameter 'options' (just an example). In our Sandbox we would check if this parameter is present and decrypt it and if it is valid then populate the options form.
This way we would have the option locally and only once we decide to share it, we would encrypt the values and put it into the query param.
However, there might be drawbacks to this approach too, such as:

Browser Link size limitations

Another thing I am thinking of is, what if we said: This link is sharable only for one hour. When the user clicks the share button, the options would be stored in a database as an entry that would expire after one hour. After the entry is saved into the database it will create an id, that will be used in the query parameter. When the sandbox is open with the id n the query parameter it will check if it is valid and populates the option fields.
Here I am not sure about the potential security issues.

@demetriusfeijoo @BibiSebi @johannes-lindgren
In my opinion, it's too risky to automatically include the options in the URL. If we include the options automatically in the URL before the user consents, there's a chance the user may share or leak this URL without knowing. It should be more clear. Instead, we can display a button to copy the URL with options included. When the button is clicked, we can show a warning that sharing the link with others may pose a security risk.
Also, this RFC is missing another approach which is to get the options from the Manifest file. We also discussed about this a lot, so we need to thoroughly discuss it here as well. As Bibi said, it can be a combination of some options.

Manifest file + Click to copy URL with options included
LocalStorage + Click to copy URL with options included
Manifest file as initial value + LocalStorage to store any changes on top of it + Click to copy URL with options included

I think maybe 3 is too much and it's difficult to understand which options take priority over others.

@BibiSebi when you said "encrypted query," which secret key do you think we could use? Between a person sharing a URL and a person receiving a shared URL, it's hard to imagine a secret key that both people have (either manually or programmatically on Storyblok). As long as user explicitly clicks a button to create a URL with options included, it's perhaps not too necessary to encrypt it. What do you think?
And yeah, we could consider using KV to store the information which expires in an hour (for example), and only those who have the URL can access to it. That makes sense. We could consider it later, when we really need to cover the browser limit.

@demetriusfeijoo @BibiSebi

https://saturncloud.io/blog/what-is-the-maximum-length-of-a-url-in-different-browsers/
2KB for Chrome seems good enough for most of use-cases, as our options is literally configurations for the field plugin, but not any user-created large data to store.

@demetriusfeijoo awesome. could you then update the markdown file to reflect all this discussion? :)

Here's my reasoning:
Regardless of the feature that we consider in this thread, we know that we want to persist the default options in version control so that we can deploy the complete field plugin with the CLI. At the moment, the CLI deploys the code using the name, but the default options are missing. Thus, we know that we will have a manifest file at some point. The question is whether we will use it for this feature.
There are two features that would be nice to have:

Shareability: the ability to share options in code reviews etc
Presets: the ability to save time when developing, by not having to type manually

Number 1) seems more important for me than number 2).
To share options, the options somehow need to be serialized (1):

URL query params solution solves this in the most flexible way; anyone can simply include the URL via a text message. A drawback is that it can easil in you leaking secrets.
The manifest file is shareable via the source code. If the field plugin is deployed, the manifest will also be available from a URL. The drawback is that you cannot share secrets, as they don't belong in version control. The benefit is that it prevents you from accidentally leaking secrets. It's also only letting you share the defaults. You cannot easily sat "try this URL (X) to try this feature, and this other set of options with this other URL (Y) to try this other feature)".
localStorage does not address this issue

Using a database seems complex to me. The sandbox doesn't have authentication at the moment, which probably would be required.
We should also consider other properties such as

language
content
story

It might be nice to make these shareable as well. These cannot be included in the manifest file though, as they do not describe the plugin itself. But they could be included in the URL.
TLDR
I guess I reached the same conclusion:
A. Both option B and D require this feature.
B. The most important thing is to bootstrap from the manifest. But how do we get the options in the manifest into the app? It's going to require you to first be able to load the options via the URL. A Vite plugin could read the manifest file and generate a URL.
D. Second priority is to be able to generate a new URL after medications of the default options
I think we probably should sync the URL query. It could lead to leaked secrets, but do we protect against this by requiring a button click? (The dream scenario is one with the app bridge, where we are no longer forced to store secrets in options)

@johannes-lindgren thanks for your thorough feedback. You're right. In order to do B, we need to do A first. I missed that part.
About D, I think a button click is safer than syncing the URL automatically. Once the button is clicked, we can show a warning to user that says something like

The URL to this sandbox is copied to clipboard. It contains the following options:
SHOPIFY_TOKEN: ABCDE
BLAHBLAH_TOKEN: DEF
Be aware in case the URL contains sensitive information.

Even after clicking the button, the URL in the url bar doesn't change. It's just copied to the clipboard, meaning the URL stays the same as the initially loaded one (either the one from the manifest file, or previously copied one).

The URL to this sandbox is copied to clipboard. It contains the following options:
SHOPIFY_TOKEN: ABCDE
BLAHBLAH_TOKEN: DEF
Be aware in case the URL contains sensitive information.

Even after clicking the button, the URL in the url bar doesn't change. It's just copied to the clipboard, meaning the URL stays the same as the initially loaded one (either the one from the manifest file, or previously copied one).

Good idea, makes sense.

@demetriusfeijoo If I understand correctly, @johannes-lindgren and I agree on A -> B -> D.
A: We are able to use options from the URL
B: We read manifest file and print out proper URL with those query parameters from vite dev command
D: We provide a button for the "click-to-copy-url" experience.
So, we'd better ship these 3 altogether for better DX, but the order of implementing this would be A -> B -> D.
What do you think?

Obfuscating options might be too much at this point, in my opinion.
Can you give me an example about query parameter collision? I'm not sure if I understand it.

Hey @eunjae-lee,
you didn't misunderstand me at all, after our call I realized I took a way different from the way you were expecting, so that was the confusion, no worries.
The RFC was updated accordingly to what we agreed in our call: to cover what main aspects we discussed here and also to be as simple as possible.
If there is any other point I missed to include in the RFC, please let me know.


Include npm command to run playwright tests from reg-pilot-webapp

[ ] command is npm run ui-tests

@aydarng will confirm this command after the issue is complete.

@TaniyaBhadauria now that @aydarng has completed the changes for multi-user test data generation:

See the complete SignData.json

See the individual parts here

Could you review these and update this issue to let us know if you are prepared to meet to run through them to determine if we have satisfied what is needed for the UI multi-user test scenarios?

@TaniyaBhadauria can we close this?


Prevent publication in more invalid states

At the moment the only thing which prevents a publication is the presence of a hold flag, but this is not the only state in which publishing a document is an invalid operation.
Add some more condition checks to the publish flow around a document's name, court code and NCN.
What next?
We should be able to expose a list of reasons a document isn't publishable, so we can relay them to editors.

I've done some poking around with having a default Judgment which passes, and because of the way the class and API are bolted together it's a massive pain to mock the right things.
There's another planned refactor when this model supports editing which will tidy this up and reduce a lot of boilerplate, so I'm inclined to leave this case out of the current tests (because it's already a well-tested class) unless we actually find a bug involving it.


Tweaking concat! macro to accept bytes string

Hi, I'm working on tweaking a bit the concat! macro in order to make it accepting bytes string as well (and making the output dependent of the first argument's type), but I don't know if it needs a RFC or not, so I ask it here (after some guy's advices on IRC).
Also, if you have some ideas about better ways to accept bytes string in concat! macro (I was thinking about making a concat_bytes! macro instead for example), feel free to tell me. :)

Interesting idea.  Any updates?

I just happened to need this today!

Looks like @KokaKiwi put it in a crate in the end.

Closing in favor of https://github.com/rust-lang/rfcs/pull/2509.


⚠ Bofrost.lu has degraded performance

In 87b0ca1, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1315 ms

Resolved: Bofrost.lu performance has improved in a15cd32 after 6 minutes.


Task1447_Drug_Extraction

@Ishani-Mondal, I have fixed the key issue. But, now the issue is: output of instances is not a list. I am not able to change it, could you make the each output of instances a list?

@Ishani-Mondal, I have fixed the key issue. But, now the issue is: output of instances is not a list. I am not able to change it, could you make the each output of instances a list?

Sure, thanks a lot @swarooprm, it was really helpful.

tests are green now. I had a quick look at your task, it looks good. Just one question: task1447 and 1448 seem to be same (?)

@mattf1n, wondering if you can help review these tasks?

@gkaramanolakis, can you review tasks in this PR?

Thanks @gkaramanolakis
@Ishani-Mondal, can you resolve the merge conflicts in the readme file so that we can go ahead and merge this PR?
I tried to do it in UI, but am unable to do so. You need to do it in the command line.

@swarooprm , sure, but could you please come on a call sometime so it I would be able to quickly resolve the same?

Thanks @gkaramanolakis @Ishani-Mondal, can you resolve the merge conflicts in the readme file so that we can go ahead and merge this PR? I tried to do it in UI, but am unable to do so. You need to do it in the command line.

@swarooprm , sure, but could you please come on a call sometime so it I would be able to quickly resolve the same?


Allow bypass SSL Handshake

Is your feature request related to a problem? Please describe.
Yes, one of my college try to mock service with invalid https certificate
Describe the solution you'd like
Add some option (cli startup option for sake of simplcity) to allow this
Describe alternatives you've considered
import the SSL certificate in castlemock java's keychain ... Ouch very boring 😞
What do you think Karl?

Hi @mhewedy.
I haven't mocked a service with an invalid https certificate, but I can imagine that Java's default behavior is to fail upon this. I agree that it would be nice to add this as a feature option. The current workaround is to simply add the certificate to their Java keychain.
Have you thought about any solution for how to disable the certificate check?
Once again, great idea!
Best regards,
Karl Dahlgren

Yes.. and I have it ready... I will send PR soon, please review it and let's discuss about it.

Excellent! Looking forward to see it 😄

The feature is now part of Castle Mock 1.36 which has now been released and is available on https://castlemock.com and Docker.

Thank you very much @karldahlgren , much appreciated 😄 👍


how to test: battery not charging/blink

Is there a way to test how this will look like?
`@keyframes blink {
to {
color: #D8DEE9;
}
}
#battery.warning:not(.charging) {
animation-name: blink;
animation-duration: 0.5s;
animation-timing-function: linear;
animation-iteration-count: infinite;
animation-direction: alternate;
}`

Check your states in the battery config


slowly prepare to drop node 8 support

Since Node 8 is ending its life in 2019-12-31, we should slowly start preparing at least 'todo' list (half a year seems to be a short period of time, but we might run out of time).

I guess all 'promisify' stuff will disappear since node 10 supports promised version of most of functions (in node 10 it's experimental - in node 12 it's stable)

It might be a chance to release Stryker 3.0,
maybe do stuff like: (#1610, #1457), #1589, #1514, #1508, #1472, #1473 try to clean up issues a bit (which are solved, which aren't or won't)

This is a bit early IMHO 😅
As for your issues.

#1589, #1472, #1473, #1457, #1610 can be done whenever we want. No need to wait for a major release, since they shouldn't require a breaking change.
#1514 requires a major change in how mutation is done. I've discussed this face to face with @simondel  and the easiest thing will be to build it next to the current mutation implementation and let people opt-in with an --expermimentalMutationSwitching command line flag (or something like it). That way we can actually release it before we remove the old implementation while keeping it all backward compatible. I'll update #1514 as well.

@kmdrGroch would you agree with this? In that case, we can just keep this issue open and focus on the removal of all legacy and deprecated code.

@nicojs I was thinking also in dropping node 8 support which is a bit breaking (goodbye node8 users). But yea, no need to hurry, just pointing out, in my opinion, things should be done


Build single-binary networks

This is an idea I want to leave here for discussion.
Currently, we have 2 kinds of tests:

Unittests, which use localrest to simulate a network.
Full fledged network tests, using docker-compose (see tests/system).

However, full-fledged integration tests are quite expensive (require to spawn a container, no sharing of data, etc...). One possibility to test network would be to be able to generate a single binary which  exposes a network via the usual Node API, but internally uses LocalRest for networking.
With a sensible CLI, it could also possibly allow to test multiple network configurations (e.g. introducing bad nodes) without recompilation.

So currently we have system integration tests (https://github.com/bpfkorea/agora/tree/v0.x.x/tests/system) which spawns 3 docker images of the node, with 3 different configuration files (https://github.com/bpfkorea/agora/tree/v0.x.x/tests/system/node under {0,1,2}/config.yaml), and a runs a test defined here. The full pipeline is run via ci/system_integration_test.d
However, spawning 3 docker images is expensive and won't scale very well. One thing we'd like to do is to have an intermediate between the LocalRest tests we have in source/agora/test and the full-fledge (complete) system integration tests described here.
This can be done by having a special main that creates nodes based on its arguments. All it would need is the ability to read multiple config files, and instantiate multiple Node as a result. A good starting point is to look at this code.

Also it is probably best to make it another "target", or configuration. This is what we are currently doing with agora-cli: https://github.com/bpfkorea/agora/blob/c7314c21700c526d6ee496090694bef46dc9da54/dub.json#L41-L71

@Geod24 I am going to use LocalRest to create nodes according to the config file.
Is it correct to use LocalRest?

When we discussed the topic in our sprint planning, I thought so.
However, using LocalRest would prevent the client talking to any node, so all things considered I don't think it should use it.

Done in #592


Supporting MLFLOW_TRACKING_URI file:// based schemas

Hello, and thanks for this useful capability.
I'm trying to avoid having to start an mlflow server where I'm using MLFLOW_TRACKING_URI  starting with file:// but still want to export from it. I get an error similar to #56, Mlflow host or token is not configured correctly
The problem is that __init__.py in export_run.py tries to start a dbx REST client, which doesn't support MLFLOW_TRACKING_URI. The client is only ever used by the _export_notebook function.
Since I don't need notebook import/export functionality (and I don't believe this is supported by opensource mlflow), starting this client isn't necessary.
I've attached a basic PR which fixes the issue for me (I appreciate it may not be mergeable), but there are various other places in the codebase where a client is started in an init method and apparently only used for databricks import, e.g. in import_run.py.

PR: #77


Fixed #29774 -- Check for tty on stdin processing shell command

sys.stdin.read() blocks waiting for EOF in shell.py, which will
likely never come if the user provides input on stdin via
keyboard before the shell starts. Added check for a tty, and
skip reading stdin if it's not present.
This still allows piping of code into the shell (which should
have no TTY and should have an EOF), but also doesn't cause it
to hang if multi-line input is provided.

Did you consider adding a test? bf6392bb7565c21f01ed6f682b8558dcf1cc8070 added the modified line.

I think the existing tests are sufficient. test_stdin_read handles the case where isatty is False, but there is input in stdin, and test_shell_with_[i|b]python_not_installed should handle the case where stdin isn't ready, meaning that either reason why the if statement would eval to True should be covered.


Add default implementation of WrapCustomizable that wraps to snake case

This PRs adds the WrapToSnakeCase protocol which allows an automatic wrapping to snake case. By making a model adopt to the WrapToSnakeCase protocol,
struct Book {
    let title: String
    let nrOfPages: Int
    let authorName: String
    let pictureURL: String?
}

extension Book: WrapToSnakeCase {}

will produce the following dictionary when wrapped:
{
    "title": "Game of Thrones",
    "nr_of_pages": 694,
    "author_name": "George R. R. Martin",
    "picture_url": "http://t0.gstatic.com/images?q=tbn:ANd9GcSQl7Kuali9GsWHGLzKX-IvP6tn3T1Pd_qDgMIzloF7gT_t8fAu"
}

We wrote this internally because our API expects snake case and thought it might be useful to others. Don't hesitate to say so if you feel like this doesn't belong in the core framework.

@JohnSundell Is this something that you think would be useful?

@johannth Really late to the party here, sorry about that. This is awesome - but could it be implemented as an enum instead, and returned as part of WrapCustomizable?
protocol WrapCustomizable {
    var wrapStyle: WrapStyle { get }
}

extension WrapCustomizable {
    var  wrapStyle: WrapStyle { return .camelCase } // Could be overriden with .snakeCase
}

What do you think?

Would love if this could target the swift3 branch, as it's about to get merged into master :)

@johannth Hope you don't mind, but I took this implementation, tweaked it a bit and added it for Wrap 2.0: https://github.com/JohnSundell/Wrap/pull/17 😄 Thanks a lot for providing this - I think it's gonna be a great addition to the library!

Implemented in Wrap 2.0 :)

Sorry for the late reply, I was OOO. This looks great, thanks for your feedback. Congrats on 2.0!

@johannth No problems, thanks for contributing to it 🎉


proposal: species ideas/bodytypes

corgis
any taurs
any dog breed
wiener dogs
new bodytypes
buff
femenine
short
tall
etc

@Alexofp pls acklowledge me

Either learn to fork and make a pull request or move on. I don't think they would make a new animation system for taurs.
We've discussed this topic (not with the repo owner) on discord and so far we only got those answers

oh ok but are other types ok

i can't code i need help

this is the futrthest i got with my species before i gave up

hello i tried to make a species blurrans

Hello, please do not spam others inbox and start learning. All the resources are here to get you started https://github.com/Alexofp/BDCC/wiki
If you don't succeed, try try again.
If you have any questions regarding modding please visit our discord modding-help channel.
@Alexofp please close this as not planned

Yeah, this is not the place to ask for new species, sorry


No prompt to make a network connection

First TrueOS Desktop use of a PersonaCrypt device that was last used with PC-BSD CURRENT.
To the right of the default panel, there's nothing network-related.
Weird, because TrueOS Desktop has automatically connected to an open network.
I'll save details, to add here later.

I restarted the OS, logged on as a different user. The network icon is present.

Prior to the restart:
$ ifconfig
re0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=8209b<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,WOL_MAGIC,LINKSTATE>
        ether 00:1e:8c:b5:62:98
        inet6 fe80::21e:8cff:feb5:6298%re0 prefixlen 64 scopeid 0x1
        nd6 options=23<PERFORMNUD,ACCEPT_RTADV,AUTO_LINKLOCAL>
        media: Ethernet autoselect (none)
        status: no carrier
lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> metric 0 mtu 16384
        options=600003<RXCSUM,TXCSUM,RXCSUM_IPV6,TXCSUM_IPV6>
        inet6 ::1 prefixlen 128
        inet6 fe80::1%lo0 prefixlen 64 scopeid 0x2
        inet <IP_ADDRESS> netmask 0xff000000
        nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
        groups: lo
wlan0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        ether 00:1c:bf:cf:bf:c4
        inet6 fe80::21c:bfff:fecf:bfc4%wlan0 prefixlen 64 scopeid 0x3
        inet <IP_ADDRESS> netmask 0xfffffff0 broadcast <IP_ADDRESS>
        nd6 options=23<PERFORMNUD,ACCEPT_RTADV,AUTO_LINKLOCAL>
        media: IEEE 802.11 Wireless Ethernet DS/1Mbps mode 11g
        status: associated
        ssid BTWi-fi channel 1 (2412 MHz 11g) bssid 52:64:d9:1e:a8:3a
        regdomain FCC country US authmode OPEN privacy OFF txpower 30 bmiss 7
        scanvalid 60 bgscan bgscanintvl 300 bgscanidle 250 roam:rssi 7
        roam:rate 5 protmode CTS wme
        groups: wlan
$ date ; uptime ; ifconfig -a
Thursday 11 August 2016 at 18:50:47 BST
 6:50p.m.  up 54 mins, 0 users, load averages: 0.41, 0.38, 0.34
re0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=8209b<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,WOL_MAGIC,LINKSTATE>
        ether 00:1e:8c:b5:62:98
        inet6 fe80::21e:8cff:feb5:6298%re0 prefixlen 64 scopeid 0x1
        nd6 options=23<PERFORMNUD,ACCEPT_RTADV,AUTO_LINKLOCAL>
        media: Ethernet autoselect (none)
        status: no carrier
lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> metric 0 mtu 16384
        options=600003<RXCSUM,TXCSUM,RXCSUM_IPV6,TXCSUM_IPV6>
        inet6 ::1 prefixlen 128
        inet6 fe80::1%lo0 prefixlen 64 scopeid 0x2
        inet <IP_ADDRESS> netmask 0xff000000
        nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
        groups: lo
wlan0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        ether 00:1c:bf:cf:bf:c4
        inet6 fe80::21c:bfff:fecf:bfc4%wlan0 prefixlen 64 scopeid 0x3
        nd6 options=23<PERFORMNUD,ACCEPT_RTADV,AUTO_LINKLOCAL>
        media: IEEE 802.11 Wireless Ethernet OFDM/36Mbps mode 11g
        status: associated
        ssid BTWi-fi channel 1 (2412 MHz 11g) bssid 52:64:d9:1e:a8:3a
        regdomain FCC country US authmode OPEN privacy OFF txpower 30 bmiss 7
        scanvalid 60 bgscan bgscanintvl 300 bgscanidle 250 roam:rssi 7
        roam:rate 5 protmode CTS wme
        groups: wlan
$ drill
Error: error sending query: No (valid) nameservers defined in the resolver
$

Your PersonaCrypt home directory might have the network tray autostart entry disabled (look in ~/.config/autostart/ or view it within the lumina-config utility).
If I recall, the network tray utility looks for the existance of a "wlan" device when deciding if it should start up. Not sure if that relates to the problem (logged in before the wlan device was ready?), but that is all I can think of for this problem. In either case, it does not appear to be a problem with Lumina itself, but rather something on your system or home dir.


Change appropriate "preview" references to "beta"

Bookmarks and any reference to service preview versions were not changed.

I wasn't sure whether to change a script in there for Java, so I added a TODO. Should a doc or blurb be added as to why we decided to change?

Closing in favor of https://github.com/Azure/azure-sdk/pull/1536. I believe I have captured everything you have here in my PR but please let me know if I missed something.


⚠ Fetchers has degraded performance

In 6a9c399, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 498 ms

Resolved: Fetchers performance has improved in 77acd53.


Issue 760 better processed variable

Description
Refactored solution to make it a dictionary that contains all of the solution variables. This automatically creates ProcessedVariable objects when required, so that the solution can be obtained much more easily. The solution object can also be exported, either the full object (with .save) or just an array with the data (with .save_data)
Fixes #760
Fixes #725
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[x] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[ ] No style issues: $ flake8
[ ] All tests pass: $ python run-tests.py --unit
[ ] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.
Further checks:

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

Hey @tinosulzer looks good. Couple things might want to consider. A dedicated notebook explaining the different ways to access the solution data. At the moment all examples get you to use quickplot but it's useful to know you can use solution as a dictionary directly and behind the scenes processed variables are created. The problem with this approach is that you can't do solution.keys() to get the options and solution.data.keys() only contains ones already processed so it's not obvious to the user what to do necessarily hence why an example might be useful. Another wrinkle with the functionality is that when stepping the solution if you want to access the data after each step it doesn't get automatically updated when the solutions re appended together. This is a fairly subtle thing and a experienced user who is stepping can probably work out that they need to manually call solution.update on the variable after appending. But worth knowing about so again could go in the example. I'm happy to write it and you can review it tomorrow to see if I got it all

@tinosulzer  Feel free to change or move that new example. Also , do the notebooks get tested? If not I have a script that can do it on travis

Thanks @TomTranter , that example notebook is very clear. Note in the example you chose the stepped solution stops at the voltage cut-off while the full solution goes right through it (this is a bug in scipy) so it might be better to use a shorter t_eval to avoid confusion
Some ways I can think of getting around those issues you picked up on

Write a method solution.keys() that returns model.variables.keys(). This is perhaps a bit dangerous as solution.values() and solution.items() would not act correspondingly. So perhaps safer to leave as-is and refer any questions to the example notebook.
Add functionality to solution.append to automatically update any variables that have already been created. I had been meaning to do this anyway but forgot when I came back to this issue recently. I can't think of any downside with doing this?

Examples do get tested on travis and you can run locally with
python3 run-tests.py --examples


Ability to multiselect videos from various page to add to playlist

Came up when a creator was adding many videos to a single playlist

We now have a last used playlist in the context menu.


bypass OOBE not working

navigate_to_screen( BandScreens.OobePressButtonToStart ) doesn't bypass the oobe mode
Response: Error: {'is_error': True, 'facility': <Facility.ModuleFireballUI: 195>, 'code': 1}
[band is in OOBE stage 4]

Which device? I only tried it on my Band 1.

Band 2
somehow i once managed to bypass the band by using a combination of the commands:
OOBE_SET_STAGE, OOBE_FINALIZE, NAVIGATE_TO_SCREEN and CARGO_SYSTEM_SETTINGS_OOBE_COMPLETED_SET
but until now i couldn't reproduce it :-(

I am also trying to bypass the OOBE screen on my Band 2 but I have yet to get my device to be able to connect to my computer (Windows). It will ask me to verify the PIN numbers then will say OSError: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. I get the Error: {'is_error': True, 'facility': <Facility.ModuleFireballUI: 195>, 'code': 1} error after verifying the PIN numbers in Linux, similar to @mkay56.

It's possible that Band 2 actually needs some OOBE steps to be completed before letting the app switch the screen to final one.


Spacy Scikit-learn Multithreaded Training Prediction Issue

I'm using the multithreaded-training branch and when I run:
python -m rasa_nlu.train -c config.json -t 3
I get this:
/usr/local/lib/python2.7/dist-packages/sklearn/metrics/classification.py:1113: UndefinedMetricWarning: F-score is ill-defined and being set to 0.0 in labels with no predicted samples. 'precision', 'predicted', average, warn_for)

TL;DR this isn't an error but I would recommend you add more training data.
The model still trains and runs correctly I presume? The warning you see is actually related to how the training data is used & can also occur with 1 thread.
Let's say you have 2 intents. Part of the f-score is the number of examples correctly predicted to be each intent. If you have very few training examples for, say, intent_1, then when your data is split into training and test sets it can happen that your test set doesn't have any examples of intent_1. That means the f-score isn't defined & scikit-learn has to fall back on a default.

That explains it thoroughly. Thank you Alan.

Thank you very much amn41 :+1:

hello I have the same problem and I have not been able to solve it
I have
training 1277 objects
test 15000 objects
If I use accuracy or f1_micro, it works for me, how can it be solved, help!


Does not work beyond 1 sub-directory level

Issues:

Entering an includePath loses its context, so importing from that attempts to import from the Flyfile's root directory
Error Reporting returns incorrect parent path (due to loss of context)

Example Structure:
styles/
  |-- app.sass
  |-- imports/
    |-- _first.sass
    |-- config/
      |-- _second.sass
      |-- _third.sass

// app.sass
@import first

// _first.sass
@import config/second

// _second.sass
@import third

// flyfile
yield this
  .source('styles/app.sass')
  .sass({
    outputStyle: 'compressed',
    includePaths: ['styles/imports'],
    indentedSyntax: true
  })
  // ...

This will be its error:
File to import not found or unreadable: third
Parent style sheet: ~/code/_second.sass  # <--- also, wrong path

That error path should be: ~/code/styles/_second.sass
Worth noting:
Running ./node_modules/.bin/node-sass styles/app.sass works perfectly.

@kashiro could you replicate this?

I'll check it. sorry for your patience .  :sweat_drops:  @lukeed

no worries, thanks!

@lukeed
I could do it. :+1:  no problem...
plz check it.
fly-sass-sample.zip

Ahh....  I found the problem.
Even though I typed this.source('styles/app.sass') in the example above, I was actually using: this.source('styles/**/*.sass')
Your example works -- thanks!
This will also work: styles/*.sass.
So, it still has something to do with the wildcard glob, but I'm happy to close this issue if you'd like. Thanks for following up on this!

in this case, you should set file path you want to compile to css.
that must not include import file.
so styles/**/*.sass is wrong.
It is same if you use other build tools.
anyway I'm happy to support you :+1:

:clap:


Integrate go report card service to give a check and add a badges for the project

here is a report about edgex-go : https://goreportcard.com/report/github.com/edgexfoundry/edgex-go
cc @jpwhitemn @drasko

I don't particularly see an action item here. It's a nice tool that we can run on the fly but this looks to me like an FYI rather than an issue to be solved. Could be shared via EdgeX-GoLang mailing list or, alternatively, RocketChat.

@yanghua @tsconn23 I would like that we add this badge to our GitHub README.
@yanghua we need too do the linting first and push this to A+.

I do not want a series of tiny code formatting changes interleaving with PRs to support the Delhi roadmap.

@tsconn23 are you proposing that we whould reject this task and close the issue?
Our code is not linted: https://goreportcard.com/report/github.com/edgexfoundry/edgex-go#golint and having a badge on the GitHub page that shows A+ would be more attractive for contributors.
How do you propose that we do these code improvements, which are not big issues/milestones for Delhi? We just reject them and never improve code quality?

@drasko Taking examples from #194 and #198 PRs have been submitted toward California goals which include refactoring that moves us toward the goals outlined in these recommendations. Why can't this issue be addressed the same way?
OR, if you like, why not close this umbrella topic (which I maintain would be more relevant as a topic on a mailing list or Rocket Chat) and create an issue for each file called out in the linting step on the report card site and address a specific PR for each file being cleaned up? I do not want 30 PRs tied to this one issue and I do not want one massive PR addressing all of the report card edits.

I think open a issue is also a way of discussing.
Most popular Go projects have this badge, such as :

openfaas
influxdb
beego
....

Does this a disincentive problem need to be discussed? Actually, I think it is an obvious improvement for EdgeX.
As @drasko said, this is good for EdgeX's code quality. If a stranger did not know about EdgeX. Some badges would be the primary impression, those badges would give the potential contributors confidence.
The first step, I just want to integrate with the go report card and add a badge for the project, not related to refactor the code, it's future work.
However, I think the refactor work should be done to let the badge shows "A+". About linting, we can consult at one TSC meeting to get a suitable time point?
I think code quality is a continuing process. Firstly, we should make our code looks good for us and strangers(through badge). Then, we can add some build plugins or CI tools to make imperative check for all PRs.
Firstly, I just want to add a badge for EdgeX, then we can discuss how to refactor code.
cc @tsconn23

@yanghua Well which one is it -- Add the badges or address the linting? The subject line of this issue covers both, but there's a new PR #281 that only adds a badge to the Readme. This illustrates what I'm saying. I request to close this issue and create one for the badge. Associate PR #281 to it. Then create an issue for each file in which you plan to address the linting defects.

hi @tsconn23 maybe my expression is poor. The issue's original goal is add a badge. the keyword "integrate" means use go report card's service to scan and give us a report. But the discuss between you and drasko mention the 'linting' so I was brought into it.
if the PR #281 be merged, I will close this issue. And then open another issue to discuss the linting , check tools and code quality. That means this issue just refer to add a badge about go report card.
Do you agree with me? Or I change the issue's title?

@yanghua @drasko Once PR #281 is merged, then please close this issue. Going forward, subsequent edits to address the linting should have their own issues. Thanks.

@drasko and @tsconn23 thanks, more discussion about code quality and code linting we can go into issue #286 , closing this issue mapping the merged PR #281


x/tools/go/analysis/passes/slog: nil panic in isAttr via analysisutil.IsNamed

What version of Go are you using (go version)?

$ go version
go version devel go1.21-39c5070712 Thu Jul 6 23:23:41 2023 +0000 darwin/arm64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
％ go env
GO111MODULE=''
GOARCH='arm64'
GOBIN='/Users/fsouza/bin'
GOCACHE='/Users/fsouza/Library/Caches/go-build'
GOENV='/Users/fsouza/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS='-modcacherw'
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/fsouza/.cache/go/path/pkg/mod'
GONOPROXY='git.sr.ht'
GONOSUMDB='git.sr.ht'
GOOS='darwin'
GOPATH='/Users/fsouza/.cache/go/path'
GOPRIVATE='git.sr.ht'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/Users/fsouza/.cache/go/sdk/gotip'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/Users/fsouza/.cache/go/sdk/gotip/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='devel go1.21-39c5070712 Thu Jul 6 23:23:41 2023 +0000'
GCCGO='gccgo'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/Users/fsouza/Projects/os/p/s3-upload-proxy/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/rz/8d0l4yp51sd3jh9f34x7pkg80000gn/T/go-build1879486314=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?
$ go test -c

The s3-upload-proxy package was using slog from golang.org/x/exp/slog, and I wanted to migrate it to the standard library one (see PR: https://github.com/fsouza/s3-upload-proxy/pull/511). I ran into a weird issue when trying to run tests though, and since the error happens in a package that doesn't have any tests, I realized that the issue happened during compilation and tried to run go test -c to see what would happen, and voila, there's the error.
I tried creating a smaller reproducer, but failed to do so. Unfortunately I don't have much time in my hands to try to dig into this issue, so I figured I could report it in case someone else has more time. It's possible that I'm doing something very wrong here, but even in that case, I'm not sure if getting a panic from the build process is the right thing to do?
Steps to reproduce from "scratch":
％ git clone -b build-with-1.21rc2 https://github.com/fsouza/s3-upload-proxy.git
％ go -C s3-upload-proxy test -c

What did you expect to see?
Successful compilation of the test binary.
What did you see instead?
％ go test -c
# github.com/fsouza/s3-upload-proxy
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x1043fa738]

goroutine 44 [running]:
go/types.(*Package).Path(...)
        ../../../../.cache/go/sdk/gotip/src/go/types/package.go:33
cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil.IsNamed(...)
        ../../../../.cache/go/sdk/gotip/src/cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil/util.go:126
cmd/vendor/golang.org/x/tools/go/analysis/passes/slog.isAttr(...)
        ../../../../.cache/go/sdk/gotip/src/cmd/vendor/golang.org/x/tools/go/analysis/passes/slog/slog.go:142
cmd/vendor/golang.org/x/tools/go/analysis/passes/slog.run.func1({0x1044fa680?, 0x14000191c40})
        ../../../../.cache/go/sdk/gotip/src/cmd/vendor/golang.org/x/tools/go/analysis/passes/slog/slog.go:90 +0x268
cmd/vendor/golang.org/x/tools/go/ast/inspector.(*Inspector).Preorder(0x1400081a000, {0x140006a3be8?, 0x1?, 0x104236e2c?}, 0x140006a3bf8)
        ../../../../.cache/go/sdk/gotip/src/cmd/vendor/golang.org/x/tools/go/ast/inspector/inspector.go:81 +0x98
cmd/vendor/golang.org/x/tools/go/analysis/passes/slog.run(0x140007240d0)
        ../../../../.cache/go/sdk/gotip/src/cmd/vendor/golang.org/x/tools/go/analysis/passes/slog/slog.go:55 +0x8c
cmd/vendor/golang.org/x/tools/go/analysis/unitchecker.run.func5.1()
        ../../../../.cache/go/sdk/gotip/src/cmd/vendor/golang.org/x/tools/go/analysis/unitchecker/unitchecker.go:354 +0x734
sync.(*Once).doSlow(0x1044ab720?, 0x140001a5470?)
        ../../../../.cache/go/sdk/gotip/src/sync/once.go:74 +0x100
sync.(*Once).Do(...)
        ../../../../.cache/go/sdk/gotip/src/sync/once.go:65
cmd/vendor/golang.org/x/tools/go/analysis/unitchecker.run.func5(0x10468f060)
        ../../../../.cache/go/sdk/gotip/src/cmd/vendor/golang.org/x/tools/go/analysis/unitchecker/unitchecker.go:305 +0x134
cmd/vendor/golang.org/x/tools/go/analysis/unitchecker.run.func6.1(0x0?)
        ../../../../.cache/go/sdk/gotip/src/cmd/vendor/golang.org/x/tools/go/analysis/unitchecker/unitchecker.go:376 +0x34
created by cmd/vendor/golang.org/x/tools/go/analysis/unitchecker.run.func6 in goroutine 1
        ../../../../.cache/go/sdk/gotip/src/cmd/vendor/golang.org/x/tools/go/analysis/unitchecker/unitchecker.go:375 +0x4c

Reproduced on tip.
The panic is in vet, run as part of tests.
Simpler reproducer:
package main

import (
	"errors"
	"log/slog"
)

func main() {
	err := errors.New("xxx")
	slog.Error("foo", err)
}

cc @jba

Tools was vendored in via a different CL. This should be fixed.


[Improvement] Cropping

What happens

Click on Image and select Crop
Crop (by zooming or dragging)
Save changes (Save as)
Will not be cropped, but just be copied.

Expected behavior

Click on Image and select Crop
Crop (by zooming or dragging)

not having to click the tiny text-only apply button, but apply automatically gets executed on pressing Save Copy

Saved changes

Smartphone (please complete the following information):
Irrelevant
Additional context
Look at the UI design of Samsung Gallery or Google Photos or Fossify Gallery (F-Droid)

Could it be that you just forgot to click the "apply" button before saving the picture. This is necessary for the crop to be actually saved.
As this behavior is unexpected and a copy is saved anyway, I don't see a reason why the changes don't get applied automatically once you save the picture.

You are right, it is just bad UI design.

Hello, how do you have cropping feature ? I'm using 3.0.0 version and when I press edit icon, I get "no apps can perform this action". It works before upgrade.


Update from upstream

Update prosemirror-tables from the upstream repo.

oops sorry, this went to the wrong repo.