Support ConversionReview for webhooks

Problem
I would like to be able to improve the state of CRD versioning and supply an easy extra endpoint to an existing admission controller capable of dealing with version conversion and help avoid problems like #774.
This feature is outlined in webhook conversion, and the structs are defined in apiextensions-apiserver/types.go (very similar to AdmissionReview)
See also versions in custom resource definitions.
Solution
A similar job to implementing the structs in kube::core::admission that we did for the initial admission controller feature (but without the hard setup parts since that's mostly done).
Note that these structs are also not in k8s-openapi and need special impls from us in kube-core. We also need to extend or write a new example with the new webhook behaviour.
Edit: We also need to support the conversion flag for CRDs in kube-derive. But can lift this to a separate issue once we have away to test it.
Documentation
This needs an example and needs documentation. Documentation should also ideally be added as part of the controller guide in https://github.com/kube-rs/website/issues/5 but that can come later.

Core types for this have been added in #999. Outstanding for integration with the CustomResource derive is outstanding in kube-derive.

I've read up on this issue a bit and just want to see if I understood the outstanding bit of work correct :)
Basically the plumbing is all there to create the actual webhook along the same lines as shown in https://github.com/kube-rs/kube/blob/main/examples/admission_controller.rs just with the ConversionReview types as parameters instead.
The missing piece is to extend kube-derive to allow setting the conversion field of the CRD to webhook and specify details to reach that service?
This would probably be mostly manual configuration as I presume the necessary service, pod, ... objects that influence this would be part of deploying the operator and not known to kube-rs?

which currently has to be done manually by tweaking the CRD

When you say "manually tweaking" do you mean manually after kube-rs has generated the crd, or is there a way in kube-rs to add the conversion settings programmatically? I haven't been able to find how I could do this atm without this issue being resolved, but thats probably just me :)

Extremely late reply @soenkeliebau

do you mean manually after kube-rs has generated the crd, or is there a way in kube-rs to add the conversion settings programmatically?

I originally meant that we could set the conversion property  on the crd in kube-derive in the crdspec here: https://github.com/kube-rs/kube/blob/2e5e4dedf662e5e6c24ecc97692aa6883b51fe55/kube-derive/src/custom_resource.rs#L396-L415
but you might be right that this is a property best set outside, since it only applies when users have multiple crd instances all deriving CustomResource, and in those cases it feels repetitive to set it everywhere.
Maybe the best way forward is to simply add a helper method to configure the property (if needed) via https://github.com/kube-rs/kube/blob/main/kube-core/src/crd.rs

No worries @clux :)
I played around with this a bit back in the day: https://github.com/stackabletech/hdfs-operator/blob/f0c4140d5b0487aa08813005feb2f8f853efbc6d/rust/operator-binary/src/stackable-hdfs-operator.rs#L83
And that seemed to work ok-ish. Not terribly convenient, but I guess a helper method would help here.
I guess a more integrated approach would be a "top level" struct that can be annotated with conversion settings and the supported versions which then hides away the call to merge_crds and adding the conversion settings.
Sort of like this
pub mod versioned {
    use super::*;

    #[derive(VersionedCustomResource)]
    #[kube(
    versions = ["v1", "v2"],
    conversion = "...",
    )]
    pub struct HdfsClusterSpec {
        //...
    }
}

But this was just written down pretty much as I thought about it, there will be about 30 issues with this that I have not thought about yet :)

Ah, thank you, that's very helpful.
Given how large the Webhook struct is, it's probably not practical to do a #[kube(conversion = ...)] attr for this.
We could potentially export a fn here that lets the user pass in a Webhook:
fn set_conversion_webhook(mut crd: Crd, webhook: Webhook) -> Crd {
   crd.spec.conversion = Some(CustomResourceConversion {
        strategy: "Webhook".to_string(),
        webhook: Some(webhook),
    }
    crd
}

since that's at least a safe go-enum setter. however, this is a fairly small and awkward thing to import as a simple fn, so probably not the biggest deal to users.
maybe it makes sense to have a pub trait CustomResourceDefinitionExt to bundle these various helpers on as a long term thing if there are more behaviour that are commonly implemented on CustomResourceDefinition though.

helm configuration of webhooks

It feels pretty awkward to configure properties on a crd in helm charts to me. They are generally assumed to be static enough to be installable OOB.
If you're that deep into the operator world that you need conversion webhooks, wouldn't it make more sense to streamline the installation for users so that the operator (with the conversion hook) is installed in the place the crd is pointing at by default?

For 99% of use cases I agree, yes.
The scenario that I was thinking of is a user running two different versions of, say, the hdfs operator in the same Kubernetes. Both operators are configured to only reconcile resources in specific namespaces so they do not fight with each other.
Since the CRD is cluster scoped we can only point at one of the operators at any given time in the conversion webhook, and this has to be the higher version, because only this will know how to convert all versions.
By hard coding this in the Helm chart, that distinction becomes hard I think..
But, thinking about it a bit more, the better way would probably be to include a service in the helm chart that points at the operator and target the correct operator version via a labelselector..
So in the CRD we simply say "hdfs-conversion-hook" as the service name and in our helm charts we make sure that that service has a label selector pointing at the latest installed operator version, so that no traffic is routed to older operators.
Scenarion is a bit niche I guess though ..

Do we want to move forward with the helper fn you sketched above?
If so, should we move it straight to a CustomResourceDefinitionExt or wait until more candidates raise their head?
Happy to create a PR, even though you pretty much already wrote all the code above :)

Let's wait for now to see if there are other useful things that pop up. I've referenced it from https://github.com/kube-rs/kube/issues/428. Given that there's nothing we really should do in kube-derive, we can close this issue as done :-)


[META] Improve error logging

[ ] Update Rollbar gem.
[ ] Fix poor error logging. Errors that...

... don't provide context.
... don't take advantage of Rollbar detail view.
... group incorrectly at Rollbar.
... are false negatives (not actual errors).
...

I have been researching the new Rollbar gem. I have been going over the changelog and the methods we use to report exceptions are deprecated (but not gone yet) in the newer versions.
Everything appears to be working in the latest (2.8.0) version, although more testing is needed and we get a lot of deprecation notices.
The newer alternative is much nicer:

Allows reporting exception and message (specially useful for grouping)
Automatically adds user and request data
Allows any extra data
Easy logging levels: Rollbar.debug(), Rollbar.info(), etc.

With that in mind, proposed plan for this meta:

Update rollbar gem
Add a wrapper for new rollbar functions? Probably fine that we use the new Rollbar functions directly, as they seem to have everything we needed to create the wrappers for.
New code uses new functions
Start updating old code to use new wrappers. Prioritize reports without context or that group incorrectly. We should also consider Rollbar grouping rules.
Remove deprecated Rollbar calls and wrappers

Thoughts? @juanignaciosl @gfiorav

I mostly agree:
1.- Ok.
2.- Not sure about what you mean. We should keep using wrapper methods, we don't want Rollbar all around the project, hiding it behind wrappers is much better.
3.- Depending on the mismatch. If new wrappers are useful, let's use them. Taking advantage of new gem features using the same wrappers would be a win, but I don't know if it's convenient or feasible. Maybe when we see the code we can discuss better.
4.- Not sure about what you mean. If you mean "rewrite current wrapper calls to use the new wrappers" I wouldn't do it. It's a HUGE task. Id' focus on the most frequent errors.
5.- Ok about the gem, wrappers depend on previous comments.
Please keep the PRs as small as possible :_).

Related to #6611.


import { generateRows} from "./helpers" not found

Hey =)
I'm trying to install your library here in my application and your generaterows from the 'helper' are not being found. Anyway, I'm looking in the docs of https://reactabular.js.org/#/data/ and not finding an answer for this, actually I don't want to use generated values, I have a few values to start my table, but I have no idea how to input this in my store(change the generateRows for my rows instead)
Could you enlight me?

Hi,
The helpers come from here. You are not actually meant to use them. I'm primarily using them to generate mock data and handle basic tasks that go beyond the table implementation.
If you can set up a little example I can run, I don't mind having a look.

Thanks for your time @bebraw , now I'm trying to get the data from my custom json. Actually, I'm already able to do that, but when i load my custom json I cannot edit the fields, my console output that the editing is undefined. Tryin' to solve here, do you have any tip for this issue?

const predefinedRows = [
   { "combustivel" : "Flex",
  "imagem" : null,
  "marca" : "Volkswagem",
  "modelo" : "Gol",
  "placa" : "FFF-5498",
  "valor" : 20000
  },
  { "combustivel" : "Gasolina",
  "imagem" : null,
  "marca" : "Volkswagem",
  "modelo" : "Fox",
  "placa" : "FOX-4125",
  "valor" : "20000"
  },
  { "combustivel" : "Alcool",
  "imagem" : "http://carros.ig.com.br/fotos/2010/290_193/Fusca2_290_193.jpg",
  "marca" : "Volkswagen",
  "modelo" : "Fusca",
  "placa" : "PAI-4121",
  "valor" : "20000"
  }

];

I know the problem is in generate_rows.js, I'm trying not no mock the values and deliver my own values.

I don't see anything obviously wrong in your data definition. I would have to see the Reactabular bits to say anything concrete. You can find the editing interface here.


Generic chooser: links on result list lead to JSON response

Issue Summary
Using the middle click on an entry in the result lists opens a JSON in a new tab.
It seems like the chooser modal uses this url to get its info on how to react on the selected result:

Unfortunately, this leads some users to this page:

To avoid having clueless users open a JSON page:
Can we use a different data-attribute to load the relevant data, but keep the edit-url in "href", so the middle click would work? Alternatively change the link to a button.
I've found https://github.com/wagtail/wagtail/issues/5408, which is basically the same issue with the page chooser, but in that case the link uses an anchor.
Steps to Reproduce

Install the bakerydemo
Log into the CMS and use a model chooser, e.g. open http://<IP_ADDRESS>:8000/admin/pages/82/edit/#panel-child-content-authors-section and change the existing selection with "Choose another Person".

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Technical details

Python version: 3.11
Django version: 4.2.x
Wagtail version: 5.2.x, latest main (6.1-dev)
Browser version: Firefox 123 (Linux)

Working on this

Anyone can contribute to this. View our contributing guidelines, add a comment to the issue once you’re ready to start.

@th3hamm0r did the users right click and open in a new tab? How did they get the JSON response. The JavaScript is meant to make that link change the filtering within the modal.

@lb- Middle click (by clicking on the mouse wheel).
Yes, ctrl+click and click are handled by js, middle click bypasses it somehow.

Looks like there is a separate "auxclick"-event to handle those clicks:
https://developer.mozilla.org/en-US/docs/Web/API/Element/auxclick_event

Wow. Learned something new today,
I guess technically these elements should be buttons which is the callout in #5408
I remember now I did a PR to fix this actually https://github.com/wagtail/wagtail/pull/9209 but it wasn't merged and it got painful to rebase haha.
The branch is still there though, maybe worth revisiting. We may also have some nicer options with Stimulus adoption though.
Maybe this bug can be closed and flagged as a duplicate of #5408 - and that issue updated to reflect Choosers generally.


Trim timeline image has bug (timeline not showing images on every video select)

File: video_thumbnail.dart

after that timeline does not show images

Hi~
Thank you for the report. If i understand well you cannot generate any thumbnails from any video selected ?
Looking at your screenshots it seems to be an error related to video_thumbnail package. It might be worth taking a look there.
Are you facing this error using video_editor previous version (before 1.2.5) as well ?

Any Solution ?

Yes this is what i meant by thumbnail. The component that you are seeing above is just the video player.
We are using another package to generate them -> video_thumbnail package. The error is related to this library, so i can recommend you to try the example of this lib and if the error still occurs to open an issue there.

I am already using example. Not working ...
On Fri, Apr 1, 2022 at 6:41 AM Maël @.***> wrote:

Yes this is what i meant by thumbnail. The component that you are seeing
above is just the video player.
We are using another package to generate them -> video_thumbnail package
https://github.com/justsoft/video_thumbnail. The error is related to
this library, so i can recommend you to try the example of this lib and if
the error still occurs to open an issue there.
—
Reply to this email directly, view it on GitHub
https://github.com/seel-channel/video_editor/issues/82#issuecomment-1085304376,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKU42X4NFU4FX4XZOO3BGA3VCZH5BANCNFSM5SBJGU4A
.
You are receiving this because you authored the thread.Message ID:
@.***>

I meant the example of the video_thumbnail package.

this example of the video_thumbnail package
https://github.com/justsoft/video_thumbnail is working fine separately.
Kindly guide me please to solve this issue. I have to deliver the app.
today.
Thank you Very much bro
On Fri, Apr 1, 2022 at 2:57 PM Maël @.***> wrote:

I meant the example of the video_thumbnail package
https://github.com/justsoft/video_thumbnail.
—
Reply to this email directly, view it on GitHub
https://github.com/seel-channel/video_editor/issues/82#issuecomment-1085698804,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKU42X7I3ZI3VAVSGWDJNELVC3B7LANCNFSM5SBJGU4A
.
You are receiving this because you authored the thread.Message ID:
@.***>

Unfortunately i am not able to reproduce your issue.
Do you have this error only with a single file or all of them ?
Would you be able to provide the file which throw the error ?

I meant do you have this errors with every videos or all of them?

I've open a similar issue on video_thumbnail package : https://github.com/justsoft/video_thumbnail/issues/106
Please checkout the 1.4.1 release.


Update README.yaml "gatway" -> "gateway"

fixed typo in Description section "Gatway" -> "Gateway"
what

why

references

/terratest


undefined behavior when using undefined to delete a key in a store that was initialized with undefined

Describe the bug

it seems to be behaving inconsistently, if the property is already set to undefined it doesn't delete it, otherwise it deletes it.

thank @fabiospampinato  for the summary
Your Example Website or App
https://playground.solidjs.com/anonymous/d299daac-96c8-4670-b857-4d99e706fbfe
Steps to Reproduce the Bug or Issue
see playground logs, where it logs 'a' in state
App1

initialize key a with undefined
when checking 'a' in state before,  it return true
but after setting key to undefined  to trigger delete, the key remain and the after check is also true.

App2

initialize key a with a value (defined)
when checking 'a' in state before and after setting to undefined it
works as expected. setting key to undefined in solid deletes the key

Expected behavior
it is expected that setting a key to undefined will delete the key, to create a more consistent experince.
Screenshots or Videos
No response
Platform
playground
Additional context
No response

I'm not going to lie. We're likely never going to fix this. Atleast not before 2.0 timeline with the new store mechanisms. We aren't going to parse through every value checking for undefined on initialization or set. There is unwrap but it has early exits. And even then for the path-based syntax I imagine it will work the same since one is a value and one is a "command". Like if you set an object with an undefined value we don't delete it. It's only happening on merge and direct set. The mental model here for the setter is a DSL and in so this is by design.

This issue main focus is not the initial  store value being undefined, but rather that you can't delete it if it was.
there is no need to eagerly check the store ( hopefully ) , to check in the time of delete, if the key exists, delete it.


"version" key (which is the tag) is coming as null when using git-cliff npm. But the same works using terminal

Is there an existing issue for this?

[X] I have searched the existing issues

Description of the bug
"version" key (which is the tag) is coming as null when using git-cliff npm. But the same works using terminal
Steps To Reproduce
npm i git-cliff
add a repository to read commits from with --context, --output, --context.json
see the context.json file
Expected behavior
context.json file has version value as null
It should have a tag value
Screenshots / Logs
No response
Software information

Operating system: macOS
Rust version:
Project version: 2.2.2

Additional context
No response

There might be confusion here. The top level version value refers to the current version, null means that there might be unreleased changes. Can you check again?
I get the same result for both git-cliff --context and npx git-cliff --context:
$ git clone https://github.com/orhun/git-cliff && cd git-cliff

$ git-cliff --no-exec --context | jq .[].version | head -n 5
null
"v2.2.2"
"v2.2.1"
"v2.2.0"
"v2.1.2"

$ npx git-cliff --no-exec --context | jq .[].version | head -n 5
null
"v2.2.2"
"v2.2.1"
"v2.2.0"
"v2.1.2"

Understood. Thank you @orhun


Minor: Fix name in ArrayFunctionRewriter, error not panic if Expr::GetStructField is planned

Which issue does this PR close?
N/A
Rationale for this change
While debugging a DataFusion upgrade in InfluxDB the different names for the same thing is making it hard to understand what is going on
What changes are included in this PR?

Change name reported by ArrayFunctionRewriter to be correct
Update error to reflect how these should be rewritten

Are these changes tested?

Are there any user-facing changes?

@jayzhan211  has a better fix in https://github.com/apache/datafusion/pull/10568


Markdown format image scaled

Markwon version: 3.0.1-SNAPSHOT

I want to display an image with something like "![](https:xxx.png)"
AsyncDrawable doesn't supply a way to change imageSize but the actual size of the image is loaded async
The default implementation of ImageSizeResolver scale the image to fit the canvas width. But canvas width is quit small because the placeholder (OBJ image) initializes the width of canvas so when the image is loaded, it's scaled

So how could I display an image with more reasonable size? Is implementing a custom ImageSizeResolver the right way?

Hello @yjouyang !
Native markdown does not support specifying sizes for images (based on commonmark specification). But native markdown supports HTML. So, if you are using HtmlPlugin, all you have to do is change ![](https:xxx.png) -> <img src="https:xxx.png" width="30%" >. <img> tag actually allows specifying image size in multiple ways:

width=100px - image will be 100px in width, height will be calculated based on this value and scaled down/up to keep the ratio
width=100% - the same as above, but image will take full width of a canvas (height will be determined automatically)
width=100px height=100px will make image this exact size
width=100% height=100% is not possible, as height in percents is not supported

Also,

The default implementation of ImageSizeResolver scale the image to fit the canvas width. But canvas width is quit small because the placeholder (OBJ image) initializes the width of canvas so when the image is loaded, it's scaled

can be true only if you have TextView.width=wrap_content (which I doubt). And... in this case image won't change TextView.width because it doesn't work this way. The only customization that default ImageSizeResolver is doing is - scale image down if it's width exceeds canvas width. Otherwise it will be kept untouched (unmodified).
You can also write own implementation of ImageSizeResolver to fit your needs. And there you can go crazy 😄

@noties Thank you for your reply!
And yep, I have TextView.width=wrap_content and it must be wrap_content, which kind of drives me mad right now.
However, I find a way to make the image scaled properly. Although the textview is wrap_content, but I can calculate its max width, which should be considered when displaying the image. So I call AsyncDrawable.initWithKnownDimensions with the max width, and reset the drawable result which will recalculate the bounds of the drawable.
It seems to work nicely, but I think it's a little tricky. Do you have any better idea?

Hello @yjouyang !
Well, if it works for your specific needs, I would say that it is fine 😄 . Just out of curiosity, can you show how you are doing it? In case someone will also have this problem

@noties Although I've make it work, I'm still wondering if there is an "official" way to support TextView with wrap_content?
Code:
data class Dimension(val canvasWidth: Int, val textSize: Float)

private class DrawableLoader(private val context: Context, private val dimension: Dimension? = null): AsyncDrawableLoader() {

    .....

    override fun cancel(destination: String) {
        requestTracker.remove(destination)?.get()?.cancel()
    }

    override fun load(destination: String, drawable: AsyncDrawable) {
        val assetDrawable = LocalSticker.fromUrl(destination)?.run { AssetsReader.createDrawable(context, this.assetPath()) }
        if (assetDrawable != null) {
            drawable.setResult2(assetDrawable)
            return
        }
        ImageLoader.with(context)
                .load(destination).also {
                    requestTracker[destination] = WeakReference(it)
                }
                .fetch(object : ImageLoader.LoadListener<String, Drawable> {
                    override fun onResourceReady(model: String?, resource: Drawable?) {
                        requestTracker.remove(destination)
                        drawable.setResult2(resource!!)
                    }

                    override fun onException(exception: Exception?, model: String?) {
                        requestTracker.remove(destination)
                        drawable.setResult2(ContextCompat.getDrawable(context, R.drawable.bg_image_load_failed)!!)
                    }
                })
    }

    fun AsyncDrawable.setResult2(drawable: Drawable) {
        dimension?.let {
            initWithKnownDimensions(it.canvasWidth, it.textSize)
        }
        drawable.apply {
            setBounds(0, 0, intrinsicWidth, intrinsicHeight)
        }.let {
            this.result = it
            this.bounds = it.bounds
        }
    }
}

canvasWidth in Dimension is the max display width of TextView, so image will show fitting it's original size instead of being scaled

Hello @yjouyang !
Thanks for sharing your code. Now we can officially state to use your solution as the official way to deal with images in a TextView with width=wrap_content 😉 🙌 !


micro_ros_stm32cubemx_utils/microros_static_library_ide/libmicroros/include not found.

Thanks to the developers for providing such a project.
But I am in some trouble . It seems to be possible to install the dependencies in this script, but the readme doesn't explain how to do it, and when I followed the steps, I found that the micro_ros_stm32cubemx_utils/microros_static_library_ide/libmicroros/include not found.
Can someone please give me more detailed instructions on how to do this?

Could you please explain which is your error and how to replicate it with enough information?

micro_ros_stm32cubemx_utils/extra_sources/microros_time.c: In function 'clock_gettime':
micro_ros_stm32cubemx_utils/extra_sources/microros_time.c:32:5: error: unknown type name 'TimeOut_t'
   32 |     TimeOut_t xCurrentTime = { 0 };
      |     ^~~~~~~~~
micro_ros_stm32cubemx_utils/extra_sources/microros_time.c:44:5: warning: implicit declaration of function 'vTaskSetTimeOutState' [-Wimplicit-function-declaration]
   44 |     vTaskSetTimeOutState( &xCurrentTime );
      |     ^~~~~~~~~~~~~~~~~~~~
micro_ros_stm32cubemx_utils/extra_sources/microros_time.c:48:47: error: request for member 'xOverflowCount' in something not a structure or union
   48 |     ullTickCount = ( uint64_t ) ( xCurrentTime.xOverflowCount ) << ( sizeof( TickType_t ) * 8 );
      |                                               ^
micro_ros_stm32cubemx_utils/extra_sources/microros_time.c:51:33: error: request for member 'xTimeOnEntering' in something not a structure or union
   51 |     ullTickCount += xCurrentTime.xTimeOnEntering;
      |                                 ^
make: *** [Makefile:208: build/microros_time.o] Error 1

on stm32f103c8t6  with freertos enable on stm32cubemx interface cmsis_v2

It seems to be related to your include path, is FreeRTOS correctly being included in the included path?

Same here. The "Using this package with STM32CubeIDE" guide suggests adding "libmicroros/include" folder to build settings but this folder is missing in the repo.


Translate tasks/run-application/horizontal-pod-autoscale-walkthrough

from #10903

/assign

/lgtm
/approve

Refered : #10980


Backdoor to facilitate upload of large datasets

Need
A way to upload datasets larger than what the container allows
Approach

[ ] Create a script to manually add the dataset links, metadata and assets to the database for the appropriate collection

Note
Talk to Pablo re: S3 locations
Use db/tunnel for db access
Use cxg_admin to execute with new command
This partially addresses bug: Processing Container falls over on 29GB Dataset

This is addressed by the ongoing Curation APIs work, so closing.


Fix scoped buffer test to init and shut down Platform::Memory.

Problem
TestScopedBuffer is failing due to a merge issue between https://github.com/project-chip/connectedhomeip/pull/2918 and #2987

Summary of Changes
Fix the test to init and shutdown Platform::Memory.

Duplicate of https://github.com/project-chip/connectedhomeip/pull/3050


rename downstream-test-go to actions-downstream-test

Ref knative/community#540
/cc @evankanderson

/lgtm
/approve


Ci 1 10 fixes

Fixin updates on deps and k8s min version bump to 1.25

/lgtm
/approve

/override "codecov/patch"


max_images defaults to 3 images instead of batch_size in tf.image_summary

Even though the default value for the max_images parameter in tf.image_summary is None, a maximum of 3 images are displayed by default.
It looks like this is by design, but I can't find it mentioned in the documentation.  Should a note be added to the docs, or possibly the default value changed to 3 instead of None?
import tensorflow as tf

images = tf.Variable(tf.truncated_normal([10, 48, 48, 1]))

tf.image_summary("max_images_bug_no_param", images) # 3 images displayed

tf.image_summary("max_images_bug_none_param", images, max_images=None) # 3 images displayed

tf.image_summary("max_images_bug_100_param", images, max_images=100) # 10 images displayed

with tf.Session() as sess:
    sess.run(tf.initialize_all_variables())
    summary_op = tf.merge_all_summaries()
    writer = tf.train.SummaryWriter('max_images_bug')
    summary_str = sess.run(summary_op)
    writer.add_summary(summary_str, 0)

Fixed.  You're correct that the default in Python should be 3 instead of None so that it shows up in the docs.  Thanks!


Cannot use within a flow embedded in a public digital experience

Experiencing similar issues as previously stated. Is this use case intended and if so, is there any available support?
The component displays as expected when using the flow debug.

Duplicate of #3


Percentage going over 100.

Small issue I've noticed in the output for paratests : the percentage is often over 100.
Exemple:
$ $(pwd)/vendor/bin/paratest -c $(pwd)/app/phpunit.xml.dist $(pwd)/src/
Running phpunit in 5 processes with /home/travis/build/project/vendor/bin/phpunit
Configuration read from /home/travis/build/project/app/phpunit.xml.dist
...............................................................  63 / 159 ( 39%)
............................................................... 126 / 159 ( 79%)
............................................................... 189 / 159 (118%)
......................
Time: 53 seconds, Memory: 12.75Mb
OK (211 tests, 1091 assertions)

As you can see here, the percentage shown is 118%. Any idea how this can happen?
Could it be because of skipped / incomplete / @depend tests ?

I would like to propose a fix for this issue at https://github.com/brianium/paratest/tree/percentage-fix
With the fix, every ExecutableTest knows the expected count of testmethods to be contained in the result. If the real results contain more tests than expected, the total count of tests is increased accordingly.
The phenomenon you can observe is that the total test count increases while running the dataProviders with an increasing percentage that will never get above 100%.
With https://github.com/aik099/qa-tools that now contains a total of 671 tests, it looks like this:
Paratest:
Running phpunit in 10 processes with */vendor/bin/phpunit

Configuration read from */qa-tools/phpunit.xml.dist

...............................................................  63 / 510 ( 12%)
............................................................... 126 / 538 ( 23%)
............................................................... 189 / 556 ( 33%)
............................................................... 252 / 576 ( 43%)
............................................................... 315 / 587 ( 53%)
............................................................... 378 / 602 ( 62%)
............................................................... 441 / 617 ( 71%)
............................................................... 504 / 631 ( 79%)
............................................................... 567 / 644 ( 88%)
............................................................... 630 / 662 ( 95%)
.........................................

Time: 2.64 seconds, Memory: 11.50Mb

OK (671 tests, 5153 assertions)

PHPUnit:
PHPUnit 4.4.1 by Sebastian Bergmann.

Configuration read from */qa-tools/phpunit.xml.dist

...............................................................  63 / 671 (  9%)
............................................................... 126 / 671 ( 18%)
............................................................... 189 / 671 ( 28%)
............................................................... 252 / 671 ( 37%)
............................................................... 315 / 671 ( 46%)
............................................................... 378 / 671 ( 56%)
............................................................... 441 / 671 ( 65%)
............................................................... 504 / 671 ( 75%)
............................................................... 567 / 671 ( 84%)
............................................................... 630 / 671 ( 93%)
.........................................

Time: 3.8 seconds, Memory: 45.50Mb

OK (671 tests, 5153 assertions)

Summary:
Cons:

still wrong total count (at least at the beginning)

Pros:

total count as accurate as paratest knows at the given time
total count always higher than passed test count
percentage always <= 100% (and never decreasing)

Why not execute dataProviders in advance?
Executing the dataProviders from paratest provides a different environment than executing them from phpunit. So this might harm the stability and applicability of paratest only in favor of a "better" text output (bad trade in my opinion). Likewise, executing phpunit twice per testcase only to get the correct count up-front will harm the effectiveness of paratest because process spawning is expensive.... again in favor of a better text output.
I think this fix is a fair tradeoff between representative progress output and simplicity.
Sorry for the wall of text but I would really like to get feedback on this ;)

In any case having <100% is better (except for shop discount :smile: ) then we have currently.

This is definitely an improvement. I don't think I am a fan of the idea of executing dataProviders in advance, for pretty much the same reasons @julianseeger mentioned above.
I wonder if we need perfect parity with PHPUnit here on text output? It seems reasonable to not have a total count available for concurrent tests. Would the usefulness of ParaTest be hurt if we removed the right side of the counts and the percentage?
PHPUnit 4.4.1 by Sebastian Bergmann.

Configuration read from */qa-tools/phpunit.xml.dist

...............................................................  63
............................................................... 126
............................................................... 189
............................................................... 252
............................................................... 315
............................................................... 378
............................................................... 441
............................................................... 504
............................................................... 567
............................................................... 630
.........................................

Time: 2.64 seconds, Memory: 11.50Mb

OK (671 tests, 5153 assertions)

I wonder if we need perfect parity with PHPUnit here on text output? It seems reasonable to not have a total count available for concurrent tests. Would the usefulness of ParaTest be hurt if we removed the right side of the counts and the percentage?

The total count probably doesn't matter but the percentage seems to be of interest as a measure of progress. In #129 , @grongor even mentioned that he would prefer his own fork (that counts all dataProvider executions of a testmethod as one single test) over the paratest origin. The result is exactly this: correct/usable percentage but completely incorrect total count.
So we could make a tradeoff:
...............................................................  63 ( 12%)
............................................................... 126 ( 23%)
............................................................... 189 ( 33%)
............................................................... 252 ( 43%)
............................................................... 315 ( 53%)
............................................................... 378 ( 62%)
............................................................... 441 ( 71%)
............................................................... 504 ( 79%)
............................................................... 567 ( 88%)
............................................................... 630 ( 95%)
.........................................

I think that is totally acceptable. I certainly don't want to step on any toes if the majority of people using this prefer the 0/0 format - even if the numbers are incorrect.


Thank you

I'm a beginner, this is the best nim puppy, this nim library that I've been waiting for helps me a lot, hopefully it will be developed more thanks developer

Thank you, I am glad you found this library useful!

nice work....
saved my day...
this is a nim version of requests ( python library )


⚠ Elibs has degraded performance

In 2d29e5b, Elibs (https://elibs.unmer.ac.id) experienced degraded performance:

HTTP code: 200
Response time: 6804 ms

Resolved: Elibs performance has improved in 4d63586.


bump(*)

esp openshift/library-go#500

/retest

convention for commit messages on vendor changes is Bump (*) since you bump it all

/approve
/lgtm


Updated Travis CI configuration (slack, hhvm, php 7.2, locked, coveralls) + docs rebase

removed Slack integration
removed build on HHVM
added build on PHP 7.2
added build on locked version (composer.lock is no longer ignored)
removed documentation build configuration (as it is now handled by zendframework/zfbot)
rebased docs - renamed documentation directory: doc -> docs

Thanks, @webimpress


XmlPoke saves a file with BOM even if I choose UTF8 without BOM Encoding
What is Expected?
XmlPoke saves an XML file without BOM
What version of Cake are you using?
Cake 0.23.0
Are you running on a 32 or 64 bit system?
64 bit
What environment are you running on?  Windows? Linux? Mac?
Windows 10
How Did You Get This To Happen? (Steps to Reproduce)

Copy XML from the example and save it as UTF8 file

    <?xml version="1.0" encoding="utf-8" ?>
<configuration>
    <appSettings>
        <add key="server" value="testhost.somecompany.com" />
    </appSettings>
</configuration>

Execute code from the example but with Encoding specified

    var file = File("test.xml");
    XmlPoke(file, "/configuration/appSettings/add[@key = 'server']/@value", "productionhost.somecompany.com", new XmlPokeSettings { Encoding = new UTF8Encoding(false) });

The file encoding was changed to UTF8 with BOM

Would seem encoding is only used with XmlPokeString and should probably be used here too.

Hello, I'll try to fix it


Crash on Client Start-Up

Been getting this crash with the latest versions. I believe its a conflict with CoFHCore, not to sure though.
https://www.dropbox.com/s/ho26i9we5q9a29d/crash-2015-04-13_21.41.58-client.txt?dl=0

Turns out its a problem with Forge's new Fluid registry. Downgraded Forge to .1291 and fixed the issue.


Bug: Docs: Flag --ipv4-native-routing-cidr has been deprecated in cli tool

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Deprecation warning following the docs for Native-routed Datapath Modes using cilium CLI.
Doc Reference:
https://docs.cilium.io/en/v1.13.0-rc4/network/clustermesh/clustermesh/
Deprecated command:
cilium install --ipv4-native-routing-cidr=<IP_ADDRESS>/9

results in output:
Flag --ipv4-native-routing-cidr has been deprecated, This can now be overridden via `helm-set` (Helm value: `ipv4NativeRoutingCIDR`).

Instructions should be replaced with
cilium install --helm-set "ipv4NativeRoutingCIDR=<IP_ADDRESS>/9"

Cilium Version
cilium version
cilium-cli: v0.12.12 compiled with go1.19.4 on linux/amd64
cilium image (default): v1.12.5
cilium image (stable): v1.12.5
cilium image (running): unknown. Unable to obtain cilium version, no cilium pods found in namespace "kube-system"
Kernel Version
N/A - Documentation bug only.
Kubernetes Version
AKS - but not relevant.
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello @jspaleta , @christarazi
I would like to pick this up
Could you please lead me to the file where the changes need to be implemented or any other resources to get me started

Hi @jspaleta and @christarazi, I don't see a PR for this issue. Can I work on it?


Mysql2::Error: Data too long for column 'output' at row 1

Describe the bug
Postal version 2.3.1 is intermittently failing to send emails with the error: Mysql2::Error: Data too long for column 'output' at row 1. This issue appears to be similar to previously reported incidents from 2022 and before; however, solutions from those incidents have not resolved the problem.
This is happening on a completely new installation of Postal, and all steps were followed according to the official documentation.
To Reproduce
Steps to reproduce the behavior are not fully determined as the issue is intermittent. It usually occurs during normal send operations.

Send an email with Postal.
Occasionally, the error Mysql2::Error: Data too long for column 'output' at row 1 is observed.
The message fails to send and is queued for a retry.

Expected behavior
Emails should be sent without encountering a 'Data too long' error for the 'output' column.
Environment details

OS: Ubuntu 22
Postal version: 2.3.1
Database: mariadb
Installation type: docker

Additional information/context
The 'output' column in the relevant database table may need to be verified for adequate length. It is suggested that the issue might pertain to larger-than-expected data being written to the 'output' column.
Support Ref: J-RECCKY0PSB
Any assistance or guidance to resolve this would be greatly appreciated.

This happens when the data returned from the SMTP or HTTP Endpoint is longer than 255 characters. Most of the time this isn't an issue because these servers are not all that talkative but, regardless, it shouldn't fail.
I've pushed a fix for this which I'll release in 2.3.2 a bit later.
In the meantime, you can either disable strict mode on your database make those columns bigger to accommodate the larger output.


Render to views on Android/iOS

At some point we want to render to specific android and ios views and not to the whole screen. This is currently unsupported by winit.
Sadly it is not enough to render to a surface provided by the NDK/UIKit/AppKit. We also need to hook into the input handlers of iOS and Android. Maybe we should think about removing the complete winit dependency and handle all gestures in the corresponding SDKs and control the maplibre view from there. This means that the input handlers would be written in Swift/Kotlin/JavaScript instead of Rust.
iOS:

Difficult because winit is bound to the main UIApplicationView

https://github.com/rust-windowing/winit/blob/cbba00d3600fa49394dac8538be17a438031622a/src/platform_impl/macos/window.rs#L388
https://github.com/rust-windowing/winit/issues/802
https://github.com/rust-windowing/winit/issues/1281

Android:

Difficult because winit is bound to the main NativeActivity

https://github.com/rust-windowing/android-ndk-rs/issues/262
https://github.com/rust-windowing/winit/blob/cbba00d3600fa49394dac8538be17a438031622a/src/platform_impl/android/mod.rs#L783
use JNA instead of JNI? https://github.com/java-native-access/jna

Gestures

Here is now pint-to-zoom is handlen on Android: https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/view/ScaleGestureDetector.java

Take a look at #91 when thinking about adding gesture/input handling.

This is a relevant update I believe: https://github.com/rust-windowing/winit/pull/3758


[Table] Add React node support to TablePagination.lableRowsPerPage

[ ] I have followed (at least) the PR section of the contributing guide.

Closes #20488

I couldn't push on your branch, I have continued the pull request on #21226 :)


Slow documentation loads

The documentation is questionably slow in loading and rendering taking several seconds to download everything, then another couple to render the actual page content.

Such load times are totally unacceptable! @Jayesh333 we should get this fixed asap.

There are couple of ways of doing that -

improvising the current code of handlebars itself
making it entirely static or using something like Hugo as suggested by @Xeoncross

Before improving it we should first measure the current performance though. So that we can later measure the improvements.

Shouldn't the CDN be helping us here? Lets not rule that out either.

Yess it should be helping out here. Let's debug and figure out first what's causing the slow down

You have this in your html head:
  <style>
    .async-hide {
      opacity: 0 !important
    }
  </style>
  <script>
    (function (a, s, y, n, c, h, i, d, e) {
      s.className += ' ' + y;
      h.start = 1 * new Date;
      h.end = i = function () {
        s.className = s.className.replace(RegExp(' ?' + y), '')
      };
      (a[n] = a[n] || []).hide = h;
      setTimeout(function () {
        i();
        h.end = null
      }, c);
      h.timeout = c;
    })(window, document.documentElement, 'async-hide', 'dataLayer', 4000, {
      'GTM-5KWD7NC': true
    });
  </script>

It seems to set the class of html to async-hide (opacity: 0 !important;) and removes it after 4000 ms.

I wondered at first if the documentation was built using space cloud, so I was concerned by its performances. It look like it's not the case, but this issue gives a poor image of the project.

@PascalLeMerrer that's a fair point. Will try and get that fixed asap!

Resolved


Improve max concurrent downloads

Related issues and pull requests

Closes #201

Description
Better semaphore usage to enforce max_concurrent_downloads. Also bubble up max_concurrent_downloads all the way to the CLI. cc @drnextgis
Checklist

[x] Add docs
[x] Update CHANGELOG

Codecov Report
Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.00%. Comparing base (962f749) to head (5695b25).

Files
Patch %
Lines

src/stac_asset/_functions.py
93.93%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
- Coverage   85.04%   85.00%   -0.05%
==========================================
  Files          16       16
  Lines        1050     1060      +10
==========================================
+ Hits          893      901       +8
- Misses        157      159       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi @gadomski, Curious in what fashion you see batching as improving the downloads?  It immediately makes me think of one worker getting stuck with the two big jobs, while 2 or 3 other workers go idle after finishing up there tiny jobs.

Curious in what fashion you see batching as improving the downloads? It immediately makes me think of one worker getting stuck with the two big jobs, while 2 or 3 other workers go idle after finishing up there tiny jobs.

Yeah, it's a good point. The batching was a not-well-thought-through solution to incorrect fast-failing (#201) but I could probably do something better to allow new tasks in while still failing quickly. I'll mark this as draft as I think about it.

Yeah, it's a good point. The batching was a not-well-thought-through solution to incorrect fast-failing (#201) but I could probably do something better to allow new tasks in while still failing quickly. I'll mark this as draft as I think about it.

I got you there.  Feels like asyncio.TaskGroup is in the neighborhood of what you're looking for.  From the docs:

The first time any of the tasks belonging to the group fails with an exception other than asyncio.CancelledError, the remaining tasks in the group are cancelled. No further tasks can then be added to the group.

Looks like quattro has a backport.

@ircwaves can you take a look? I just moved the acquire inside of the task so we build all the tasks, but don't start locking until we execute, which I think should do the trick.

Also cc @drnextgis to take a look as well to make sure we're still fixing #201

It worked perfectly! With the fix, the original issue is no longer reproducible. 👍

@gadomski the only concern I have is that, although it prints only one stack trace, the number of ERROR: lines can vary, and it's unclear why they might sometimes be the same. Here is the output I got with the fix:
$ stac-asset -v DEBUG download --fail-fast --path-template '${satl:outcome_id}' --http-timeout 5 --max-concurrent-downloads 5
ERROR: SL-newsat26-20240714T082256583786Z-micro-L0-v0.5.8[analytic] - TimeoutError:
ERROR: SL-newsat26-20240714T082256583786Z-micro-L0-v0.5.8[analytic] - TimeoutError:
ERROR: SL-newsat26-20240714T082256583786Z-micro-L0-v0.5.8[analytic] - TimeoutError:
ERROR: SL-newsat26-20240714T082256583786Z-micro-L0-v0.5.8[analytic] - TimeoutError:
10/13:   0%|▌                                                                                | 2.02M/468M [00:01<00:54, 8.99MB/s, 4 errors, 23 skips]Traceback (most recent call last):
  File "/home/denis/git/stac-asset/env/bin/stac-asset", line 8, in <module>
    sys.exit(cli())
  File "/home/denis/git/stac-asset/env/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/home/denis/git/stac-asset/env/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/home/denis/git/stac-asset/env/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/denis/git/stac-asset/env/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/denis/git/stac-asset/env/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/home/denis/git/stac-asset/src/stac_asset/_cli.py", line 188, in download
    asyncio.run(
  File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
    return future.result()
  File "/home/denis/git/stac-asset/src/stac_asset/_cli.py", line 298, in download_async
    output = await download()
  File "/home/denis/git/stac-asset/src/stac_asset/_cli.py", line 281, in download
    return await _functions.download_item_collection(
  File "/home/denis/git/stac-asset/src/stac_asset/_functions.py", line 355, in download_item_collection
    await downloads.download(messages)
  File "/home/denis/git/stac-asset/src/stac_asset/_functions.py", line 152, in download
    raise error
  File "/home/denis/git/stac-asset/src/stac_asset/_functions.py", line 145, in download
    results = await asyncio.gather(*tasks)
  File "/home/denis/git/stac-asset/src/stac_asset/_functions.py", line 176, in download_with_lock
    return await download.download(messages=messages)
  File "/home/denis/git/stac-asset/src/stac_asset/_functions.py", line 59, in download
    raise error
  File "/home/denis/git/stac-asset/src/stac_asset/_functions.py", line 49, in download
    await download_asset(
  File "/home/denis/git/stac-asset/src/stac_asset/_functions.py", line 431, in download_asset
    raise error
  File "/home/denis/git/stac-asset/src/stac_asset/_functions.py", line 419, in download_asset
    await client.download_href(
  File "/home/denis/git/stac-asset/src/stac_asset/client.py", line 120, in download_href
    raise err
  File "/home/denis/git/stac-asset/src/stac_asset/client.py", line 102, in download_href
    async for chunk in self.open_href(
  File "/home/denis/git/stac-asset/src/stac_asset/client.py", line 78, in open_href
    async for chunk in self.open_url(
  File "/home/denis/git/stac-asset/src/stac_asset/http_client.py", line 165, in open_url
    async for chunk, _ in response.content.iter_chunks():
  File "/home/denis/git/stac-asset/env/lib/python3.10/site-packages/aiohttp/streams.py", line 66, in __anext__
    rv = await self._stream.readchunk()
  File "/home/denis/git/stac-asset/env/lib/python3.10/site-packages/aiohttp/streams.py", line 441, in readchunk
    await self._wait("readchunk")
  File "/home/denis/git/stac-asset/env/lib/python3.10/site-packages/aiohttp/streams.py", line 311, in _wait
    with self._timer:
  File "/home/denis/git/stac-asset/env/lib/python3.10/site-packages/aiohttp/helpers.py", line 735, in __exit__
    raise asyncio.TimeoutError from None
asyncio.exceptions.TimeoutError
10/13:   0%|▌                                                                                | 2.02M/468M [00:01<04:01, 2.02MB/s, 4 errors, 23 skips]


Fixes to docs and an example

I found over at openff-docs that train-gnn-notebook.ipynb had broken at some point since 0.2.2. This fixes that. I think this'll let us bring the central examples up to date with nagl but I'm not sure. Then I found that the API docs were not very complete - they were failing to a bug in Sphinx 5, so I've upgraded to Sphinx 6 and MyST 1.0... which then opened a big can of worms.
Changes made in this Pull Request:

Add version argument to train-gnn-notebook.ipynb
Update Sphinx to 6.x
Update MyST to 1.0
Switch to Conda Forge DGL in examples and docs environments
Update autosummary templates to work with Sphinx 6
Fix new Intersphinx link format for MyST 1.0 (it's now (<Link text>)[inv:<package>#<reference>] instead of (<Link text>)[<package>:<reference>])
Fix docstring warnings where possible (main one was that continuing lines in lists in RST must be indented to match the start of the text of the line, not the list signifier)

So it's:
1. this is a very long
   sentence
2. point two

not
1. this is a very long
sentence
2. point two

Questions:

Would you like me to set up a GitHub Action to run the examples?
There are some MyST warnings from theory.md and training.md because the relevant parts of the API seem to have been moved - how should they be updated?

/home/joshmitchell/Documents/openff/nagl/docs/theory.md:91: WARNING: 'myst' cross-reference target not found: 'openff.nagl.storage.record.MoleculeRecord.from_openff' [myst.xref_missing]
/home/joshmitchell/Documents/openff/nagl/docs/theory.md:91: WARNING: 'myst' cross-reference target not found: 'openff.nagl.storage.record.MoleculeRecord.from_precomputed_openff' [myst.xref_missing]
/home/joshmitchell/Documents/openff/nagl/docs/training.md:17: WARNING: 'myst' cross-reference target not found: 'openff.nagl.storage.record.MoleculeRecord' [myst.xref_missing]
/home/joshmitchell/Documents/openff/nagl/docs/training.md:55: WARNING: 'myst' cross-reference target not found: 'openff.nagl.nn.dataset.DGLMoleculeLightningDataModule' [myst.xref_missing]

PR Checklist

[ ] Tests?
[ ] Docs?
[ ] CHANGELOG updated?
[ ] Issue raised/referenced?

Codecov Report

Merging #73 (9d3e90d) into main (64f9c25) will decrease coverage by 0.23%.
Report is 2 commits behind head on main.
The diff coverage is 50.00%.

Additional details and impacted files

Amazing, thank you @Yoshanuikabundi!

Would you like me to set up a GitHub Action to run the examples?

This would be great -- yes please!

There are some MyST warnings from theory.md and training.md because the relevant parts of the API seem to have been moved - how should they be updated?

The storage classes don't exist anymore as I've mostly moved towards just using plain Arrow datasets instead, which were more flexible when trying to work with multiple/custom targets. Looking through theory.md, those references could just be removed since for training a openff.nagl.molecule._dgl.molecule.DGLMolecule is just constructed from an OpenFF Molecule (for inference, a networkx-enabled openff.nagl.molecule._graph.molecule.GraphMolecule may be constructed instead).
For the training.md document I have code I'd like to adapt to replace that (and generally update the documentation) -- unfortunately I don't have that exactly to hand at the moment as most of it's on the lilac cluster, which I've temporarily lost access to for the moment. The DGLMoleculeLightningDataModule has generally been replaced by a configuration classes, specifically openff.nagl.config.data.DataConfig.

Mmm OK maybe we should leave further docs changes for a future PR then! I'll see if I can put together a quick examples runner to finish this one off.

Thanks @Yoshanuikabundi! The changes all look good to me so far, let me know when you're after an official review :-)

@Yoshanuikabundi just picking this back up again, should I keep waiting to review in case you're planning any future changes or is this good to go? :-)

I think the changes in this PR fixed #93 too, hurray! Thank you very much @Yoshanuikabundi for the great work here.

Ah awesome! Sorry, I completely dropped this on the floor and forgot about it.


Merge to live!

Docs Build status updates of commit 85faabc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/concepts/browsers-used-by-office-web-add-ins.md
:white_check_mark:Succeeded

docs/concepts/privacy-and-security.md
:white_check_mark:Succeeded

docs/concepts/requirements-for-running-office-add-ins.md
:white_check_mark:Succeeded

docs/concepts/resource-limits-and-performance-optimization.md
:white_check_mark:Succeeded

docs/design/add-in-commands.md
:white_check_mark:Succeeded

docs/design/add-in-design.md
:white_check_mark:Succeeded

docs/design/task-pane-add-ins.md
:white_check_mark:Succeeded

docs/develop/add-in-manifests.md
:white_check_mark:Succeeded

docs/develop/asynchronous-programming-in-office-add-ins.md
:white_check_mark:Succeeded

docs/develop/automatically-open-a-task-pane-with-a-document.md
:white_check_mark:Succeeded

docs/develop/bind-to-regions-in-a-document-or-spreadsheet.md
:white_check_mark:Succeeded

docs/develop/create-addin-commands.md
:white_check_mark:Succeeded

docs/develop/create-and-debug-office-add-ins-in-visual-studio.md
:white_check_mark:Succeeded

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded

docs/develop/develop-office-add-ins-for-the-ipad.md
:white_check_mark:Succeeded

docs/develop/dialog-api-in-office-add-ins.md
:white_check_mark:Succeeded

docs/develop/install-latest-office-version.md
:white_check_mark:Succeeded

docs/develop/loading-the-dom-and-runtime-environment.md
:white_check_mark:Succeeded

docs/develop/localization.md
:white_check_mark:Succeeded

docs/develop/make-office-add-in-compatible-with-existing-com-add-in.md
:white_check_mark:Succeeded

docs/develop/office-versions-and-requirement-sets.md
:white_check_mark:Succeeded

docs/develop/read-and-write-data-to-the-active-selection-in-a-document-or-spreadsheet.md
:white_check_mark:Succeeded

docs/develop/specify-office-hosts-and-api-requirements.md
:white_check_mark:Succeeded

docs/develop/troubleshoot-sso-in-office-add-ins.md
:white_check_mark:Succeeded

docs/develop/understanding-the-javascript-api-for-office.md
:white_check_mark:Succeeded

docs/excel/co-authoring-in-excel-add-ins.md
:white_check_mark:Succeeded

docs/excel/custom-functions-authentication.md
:white_check_mark:Succeeded

docs/excel/custom-functions-batching.md
:white_check_mark:Succeeded

docs/excel/custom-functions-best-practices.md
:white_check_mark:Succeeded

docs/excel/custom-functions-debugging.md
:white_check_mark:Succeeded

docs/excel/custom-functions-dialog.md
:white_check_mark:Succeeded

docs/excel/custom-functions-errors.md
:white_check_mark:Succeeded

docs/excel/custom-functions-json-autogeneration.md
:white_check_mark:Succeeded

docs/excel/custom-functions-json.md
:white_check_mark:Succeeded

docs/excel/custom-functions-localize.md
:white_check_mark:Succeeded

docs/excel/custom-functions-naming.md
:white_check_mark:Succeeded

docs/excel/custom-functions-overview.md
:white_check_mark:Succeeded

docs/excel/custom-functions-parameter-options.md
:white_check_mark:Succeeded

docs/excel/custom-functions-requirements.md
:white_check_mark:Succeeded

docs/excel/custom-functions-save-state.md
:white_check_mark:Succeeded

docs/excel/custom-functions-troubleshooting.md
:white_check_mark:Succeeded

docs/excel/custom-functions-volatile.md
:white_check_mark:Succeeded

docs/excel/custom-functions-web-reqs.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-advanced-concepts.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-core-concepts.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-events.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-overview.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-worksheets.md
:white_check_mark:Succeeded

docs/excel/performance.md
:white_check_mark:Succeeded

docs/excel/xll-compatibility-requirements.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add crossplane framework for testing

Problem: We want a way to verify nginx configuration reliably in our tests. This is especially useful when introducing new policies, without the desire for testing nginx functionality directly.
Solution: Added a framework for getting the nginx config and passing through crossplane into a structured JSON format for easier parsing.
Because we now use a local container for crossplane in our functional tests, we'll only support running these tests in a kind cluster.
Closes #2014
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING doc
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that all unit tests pass after adding my changes
[ ] I have updated necessary documentation
[x] I have rebased my branch onto main
[x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

I have hereby read the F5 CLA and agree to its terms


sporulation position query?

currently
development
--reproduction
----sexual reproduction
------gametogenesis
----conjugation
but sporulation (which is the fungal equivalent to
gametogenesis)
is under
cell growth and maintenance
--sporulation
----sporulation (sensu Fungi)
I don't think sporulation necessarily needs a cell
growth and maintenance parentage?
sporulation can't have a conjugation parentage because
sporulation can occur without
conjugation, but it should probably go under
reproduction, ?
Reported by: ValWood
Original Ticket: "geneontology/ontology-requests/1522":https://sourceforge.net/p/geneontology/ontology-requests/1522

thanks www.movied.org


Initial attempt to run the new e2e

What
Enable the e2e steps for running the new implementation.
Tasks

[ ] Configure the Daily trigger (JJBB, Pipeline).
[ ] Validate the commands work as expected.
[ ] Add slack message.

:broken_heart: Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-11-18T15:06:31.884+0000

Duration: 8 min 59 sec

Commit: c3bd8027c7d3ad6a32f6528e6f0c7678112a19fc

Test stats :test_tube:

Test
Results

Failed
1

Passed
139

Skipped
0

Total
140

Test errors
Expand to view the tests failures
Test / CLI screenshots with device emulation – CLI screenshots with device emulation

no error details
Expand to view the stacktrace
 Error: Failed: "Error SyntaxError: Unexpected end of JSON input could not parse data '{\"type\":\"screenshot/block\",\"_id\":\"71bb77ed1acf85f13f1e8a2ab3cf3401850f7b9d\",\"@timestamp\":1637248430643757.2,\"root_fields\":{\"os\":{\"platform\":\"linux\"},\"package\":{\"name\":\"@elastic/synthetics\",\"version\":\"1.0.0-beta.17\"}},\"blob\":\"/9j/2wBDAAYEBQYFBAYGBQYHBwYIChAKCgkJChQODwwQFxQYGBcUFhYaHSUfGhsjHBYWICwgIyYnKSopGR8tMC0oMCUoKSj/2wBDAQcHBwoIChMKChMoGhYaKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCj/wAARCAFyALQDASIAAhEBAxEB/8QAFQABAQAAAAAAAAAAAAAAAAAAAAj/xAAUEAEAAAAAAAAAAAAAAAAAAAAA/8QAFAEBAAAAAAAAAAAAAAAAAAAAAP/EABQRAQAAAAAAAAAAAAAAAAAAAAD/2gAMAwEAAhEDEQA/AKpAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA'"
    at Env.it (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-417/src/github.com/elastic/synthetics/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:95:24)
    at it (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-417/src/github.com/elastic/synthetics/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:100:21)
    at Suite.<anonymous> (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-417/src/github.com/elastic/synthetics/__tests__/cli.test.ts:147:3)
    at addSpecsToSuite (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-417/src/github.com/elastic/synthetics/node_modules/jest-jasmine2/build/jasmine/Env.js:444:51)
    at Env.describe (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-417/src/github.com/elastic/synthetics/node_modules/jest-jasmine2/build/jasmine/Env.js:414:11)
    at describe (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-417/src/github.com/elastic/synthetics/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:88:18)
    at Object.<anonymous> (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-417/src/github.com/elastic/synthetics/__tests__/cli.test.ts:32:1)
    at Runtime._execModule (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-417/src/github.com/elastic/synthetics/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-417/src/github.com/elastic/synthetics/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-417/src/github.com/elastic/synthetics/node_modules/jest-runtime/build/index.js:746:10)

Steps errors
Expand to view the steps failures

Runs the tests

Took 1 min 7 sec . View more details here
Description: ./node_modules/.bin/jest --ci --reporters=default --reporters=jest-junit

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

I've just committed to #393: https://github.com/elastic/synthetics/pull/393/commits/7548a835458282ef42c9ab1b97ff30ce2233974d
Therefore this PR won't be needed anymore


[webapi] Autoamtion tests for Deviceadaptation

Impacted TCs num(approved): New 0, Update 2, Delete 0
Unit test Platform: Crosswalk Project for Android 15.44.374
Unit test result summary: Pass 2, Fail 0, Blocked 0

What about the baseline of arm devices?

Typo error in summary: 's/Autoamtion/Automation'

LGTM


为ImageViewer支持按索引显示功能

##为ImageViewer支持按索引显示功能

当前ImageViewer支持预览，但是支持从0开始，较多的场景下需要从指定索引预览，viewer.js支持从指定索引显示，添加相关功能。

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


FTLB Models for Deployment Testing

Train models on HPC for the FTLB to be used in deployment testing. There should be models for each of the following meters:

FTLB Main Electricity
FTLB Chilled Water (CHW) Consumption
FTLB Hot Water (HW) Consumption

I will email the data set link to @JanghyunJK.
Important! Ensure the following settings when training these models:

Time interval should be 15 minutes. Note: targets are at a more granular resolution, but I think the data processing pipeline is set up to handle this now, correct?
Set intervals to left-closed (bin_closed = "left" and optionally bin_label = "left")
Use architecture "alfa"
Train quantiles [0.1, 0.2, ..., 0.9]
Ensure the resulting models can be executed on CPU. I think this just means I will need to have a build of Wattile with #244 merged?

Time proxy variables (sin/cos, binary indicators, etc.) are at your discretion based on what has worked well. Or just use all of them if you like. :)
This issue is for progress tracking. Let me know if there are questions.

just uploaded new data to HPC

@stephen-frank trained model results for different combinations of bin_closed and bin_label are uploaded in the shared folder. I'll send an email shortly with specific link to the folder location.

I think there are some issues when bin_closed = left. I will gather info and post a bug.

Received FTLB models from Janghyun. Closing as complete!


Installation instructions update.

Users using react: 16.9.0 and react-native: 0.61.5 should not be dragging the fonts folder into the project in xcode. They only need to update the PList.

We’ve just released a major new version with significant changes and improvements. If you’re still experiencing this issue after upgrading, please open a new issue with updated details. We're closing all the very old issues to get on top of things. Thanks for your patience!


[FEATURE] Freeze VM before live backup

Is your feature request related to a problem? Please describe.
Freeze VM to avoid users keep writing data during live backup.
Describe the solution you'd like
Try to call freeze and unfreeze for VMI.
Additional context
https://github.com/kubevirt/kubevirt/pull/5942

Duplicate of #1723 .


Update to latest Go SDK to fix STS issues

Type of Demand:
Please update Go SDK reference to also include latest change to https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/services/sts/endpoint.go#L10 which updates STS endpoints accordingly.
Detailed Description:
Release v1.61.1 of Go SDK should be added to vendor.

CLI does not depend on this file, so this file update will not affect cli. If you have any questions, please let us know


Fix nested associations style

Apparently col-md-offset-2 was not the proper class to set.
Before:

After:

I'm going to make another PR to fix checkbox's style

Not so simple...


Musikdroid Landscape Mode?

Sorry if I missed it in the settings - just been playing with Musikcube/Musikdroid for the last hour or so...
Musikdroid does not seem to have a landscape mode when running on a tablet?
Any plans for that in the future?
Thanks.

I'd like to add onto this and request an "upside down portait" mode as well as landscape- because of where my charging cable is, i'll use my tablet upside down sometimes, which musikdroid doesn't seem to support either.

it's purposely locked to portrait mode. I've forked the repository and made the change AndroidManifest.xml file in musikdroid/app/src/main folder. You can delete any lines android:screenOrientation="portrait". This will allow the device to rotate based on the orientation of the device. Will play around with it see how it performs on a few devices and if it makes sense will create a pull request

Thanks for investigating this. My intent is to possibly use this app for in-car music on a "homemade" android head unit (probably RPi or other SBC based).


Project name added to user-agent

For downloads, if the ProjectName is present in a job ad for the plugin, it is added to the user-agent in the http request header.

@bbockelm I currently have it so that the user-agent is set to the project name if it is present for downloads. I do have two questions:

Should I also add this to the header for uploads too on top of downloads?
I cannot seem to find this ProjectName as a jobad attribute from when running jobs and even in the condor manual, I'm not sure how it is populated, is this a custom classad?


Created README in Norwegian

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: orthodoxparadox sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for taking the time to contribute this localization pull request. However, we are not able to accept contributions to this historical reference repository at this time.


reduce cache busting for gotohelm

c30e78984cd87a5732c7860bec4473886f9d90c3 reduce cache busting for gotohelm
As genschema uses reflection, it needs to import the redpanda chart's
gocode which results in needing to rebuild gotohelm and genpartial much
more frequently than strictly is necessary which slows down development.
This commit splits the source regex filters for gotohelm, genpartial, and
genschema by each package such that changes to the redpanda chart don't
required gotohelm to be needlessly rebuilt. This should improve both CI
and local development iteration times.
As an added bonus, this commit also add nix fmt to CI.

error: builder for '/nix/store/wasfc4ykgbh7f5wqc60k6cm7yq2mdxqg-genpartial-0.0.0-go-modules.drv' failed with exit code 1;
       last 25 log lines:
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > Running phase: buildPhase
       > go: downloading github.com/cockroachdb/errors v1.11.1
       > go: downloading golang.org/x/exp v0.0.0-20231226003508-02704c960a9b
       > go: downloading golang.org/x/tools v0.17.0
       > go: downloading github.com/stretchr/testify v1.8.4
       > go: downloading github.com/cockroachdb/logtags v0.0.0-2023011820[175](https://github.com/redpanda-data/helm-charts/actions/runs/8791264667/job/24125084184?pr=1242#step:5:176)1-21c54148d20b
       > go: downloading github.com/cockroachdb/redact v1.1.5
       > go: downloading github.com/getsentry/sentry-go v0.18.0
       > go: downloading github.com/gogo/protobuf v1.3.2
       > go: downloading github.com/kr/pretty v0.3.1
       > go: downloading github.com/pkg/errors v0.9.1
       > go: downloading golang.org/x/sys v0.17.0
       > go: downloading github.com/davecgh/go-spew v1.1.1
       > go: downloading github.com/pmezard/go-difflib v1.0.0
       > go: downloading gopkg.in/yaml.v3 v3.0.1
       > go: downloading github.com/kr/text v0.2.0
       > go: downloading github.com/rogpeppe/go-internal v1.11.1-0.20231026093722-fa6a31e0812c
       > go: downloading golang.org/x/text v0.14.0
       > go: downloading golang.org/x/mod v0.14.0
       > go: github.com/redpanda-data/helm-charts/cmd/genpartial tested by
       >      github.com/redpanda-data/helm-charts/cmd/genpartial.test imports
       >       github.com/redpanda-data/helm-charts/pkg/testutil: no required module provides package github.com/redpanda-data/helm-charts/pkg/testutil; to add it:
       >   go get github.com/redpanda-data/helm-charts/pkg/testutil
       For full logs, run 'nix log /nix/store/wasfc4ykgbh7f5wqc60k6cm7yq2mdxqg-genpartial-0.0.0-go-modules.drv'.
error: 1 dependencies of derivation '/nix/store/bi[198](https://github.com/redpanda-data/helm-charts/actions/runs/8791264667/job/24125084184?pr=1242#step:5:199)h7r0g5ws8x65in3n21llns2fbij-genpartial-0.0.0.drv' failed to build
task: Failed to run task "ci:lint": exit status 1

https://github.com/redpanda-data/helm-charts/actions/runs/8791264667/job/24125084184?pr=1242#step:5:198

error: builder for '/nix/store/wasfc4ykgbh7f5wqc60k6cm7yq2mdxqg-genpartial-0.0.0-go-modules.drv' failed with exit code 1;
       last 25 log lines:
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > Running phase: buildPhase
       > go: downloading github.com/cockroachdb/errors v1.11.1
       > go: downloading golang.org/x/exp v0.0.0-20231226003508-02704c960a9b
       > go: downloading golang.org/x/tools v0.17.0
       > go: downloading github.com/stretchr/testify v1.8.4
       > go: downloading github.com/cockroachdb/logtags v0.0.0-2023011820[175](https://github.com/redpanda-data/helm-charts/actions/runs/8791264667/job/24125084184?pr=1242#step:5:176)1-21c54148d20b
       > go: downloading github.com/cockroachdb/redact v1.1.5
       > go: downloading github.com/getsentry/sentry-go v0.18.0
       > go: downloading github.com/gogo/protobuf v1.3.2
       > go: downloading github.com/kr/pretty v0.3.1
       > go: downloading github.com/pkg/errors v0.9.1
       > go: downloading golang.org/x/sys v0.17.0
       > go: downloading github.com/davecgh/go-spew v1.1.1
       > go: downloading github.com/pmezard/go-difflib v1.0.0
       > go: downloading gopkg.in/yaml.v3 v3.0.1
       > go: downloading github.com/kr/text v0.2.0
       > go: downloading github.com/rogpeppe/go-internal v1.11.1-0.20231026093722-fa6a31e0812c
       > go: downloading golang.org/x/text v0.14.0
       > go: downloading golang.org/x/mod v0.14.0
       > go: github.com/redpanda-data/helm-charts/cmd/genpartial tested by
       >      github.com/redpanda-data/helm-charts/cmd/genpartial.test imports
       >       github.com/redpanda-data/helm-charts/pkg/testutil: no required module provides package github.com/redpanda-data/helm-charts/pkg/testutil; to add it:
       >   go get github.com/redpanda-data/helm-charts/pkg/testutil
       For full logs, run 'nix log /nix/store/wasfc4ykgbh7f5wqc60k6cm7yq2mdxqg-genpartial-0.0.0-go-modules.drv'.
error: 1 dependencies of derivation '/nix/store/bi[198](https://github.com/redpanda-data/helm-charts/actions/runs/8791264667/job/24125084184?pr=1242#step:5:199)h7r0g5ws8x65in3n21llns2fbij-genpartial-0.0.0.drv' failed to build
task: Failed to run task "ci:lint": exit status 1

https://github.com/redpanda-data/helm-charts/actions/runs/8791264667/job/24125084184?pr=1242#step:5:198

Fixed!


Flipping in flow

I have seen that in the test code, for the horizontal flipping of x component of optical flow, the image is reversed and the reversed image is deducted from 255. Why dont we just take the reversed image instead? This is the line 71 of video temporal prediction which is
255 - img_x[:, ::-1]
Thanks in advance

Hi thank you for bringing this up. Actually I didn't write this part of the code, I borrowed it from this repo (https://github.com/yjxiong/caffe/blob/action_recog/action_python/VideoTemporalPrediction.py), which is the earliest repo on deep CNNs for action recognition.
I think as long as you keep it consistent, you can use reversed image as well. It is just a kind of data augmentation to make the prediction results more robust.  And 255 - img_x[:, ::-1] may achieve the best performance.


build: prevent to push without building api schema

tbd

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.08%. Comparing base (fbc042c) to head (492f473).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #684   +/-   ##
=======================================
  Coverage   74.08%   74.08%
=======================================
  Files         255      255
  Lines       11096    11096
=======================================
  Hits         8221     8221
  Misses       2875     2875

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


asim/kustoking/add-websession-paloaltonetworks

Required items, please complete
Change(s):

Added Palo Alto Web Filtering

Reason for Change(s):

New features

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

Hi @KustoKing :
Few more comments:

ApplicationProtocl -> rename to NetworkApplicationProtocol
EventCount -> rename from the EventCount field rather than setting to 1. Just in case it is ever different.
NetworkDirectoin = based on FlexString2
DeviceExternalId -> rename to DvcId
DvcIdType = "Other"
DvcHostname -> DvcName.
Dvc = DvcHostname
Map the Translated fields.
DeviceCustomString4 is SrcZone, not DvcZone. Also map DeviceCustomString5 to DstZone.
You need to project Type.
There are other device actions, that you need to take into account.
Interesting flags:

0x02000000—IPv6 session. Might be more correct than inspecting the address.
0x00080000 —X-Forwarded-For value from a proxy is in the source user field. Hard to use now, but we need to keep in mind if we get relevant samples

Please use named parameters.

OK

"This ASIM parser supports normalizing Palo Alto PanOS threat event logs delivered using CEF to the ASIM WebSession normalized schema. The Palo Alto threat events are generated by the Palo Alto URL filtering module and collected using the Palo Alto Networks connectors, Common Event Format (CEF) via AMA connector, or the Common Event Format (CEF) via Legacy Agent connector to the CommonSecurityLog table."

Here I tried to be consistent, but also improve on the network original.
OK


main: Wire up --log-level, add some debug logging

There doesn't seem to be much usage of logrus here, but I find debug logging very useful.

(Only lightly tested locally here, I'm on a ✈ at the moment, and the Go module fetch step ruins things there)

I especially like that we info pulling image now because that tended to be a bit slow and it looked like bib was hanging.

Well that didn't get printed as we were only logging at error level, not info.  I changed it to be an unconditional print for now.

Looks like testing farm disk space issues again

processing tar file(write /big-file3: no space left on device): exit status 1

(I thought I'd adjusted the fmt.Printf, but now finally fixed)

This one isn't critical but could probably go in, right?


Eclipse Temurin should have vendor as Eclipse and not Adoptium

To be consistent with the terminology used elsewhere, the API should describe the Eclipse Temurin vendor as "Eclipse" or possibly "Eclipse Foundation" / "eclipse" etc. and not "Adoptium".
Given the API is already live, it may be desirable to allow "adoptium" as an alias for "eclipse" for some time so as not to break existing users.

@johnoliver is this complete now?

Thanks for the notification. Yes, it is a breaking change for code that depended upon the old value, and it would appear that the com.company.newjdkavailable code has been written to deal only with specific vendor values.
Hopefully this is the last time this vendor identity needs to change, but it is good practice to have default behavior for an unknown value in such cases where you don't control the enum input.


Add edpm_extra_mounts role to configure default and extra mounts

Default mounts are added early on bootstrap stage, by default create 1GB and 2MB huge pages
Extra mounts are empty by default and
are required to allow mounting /var/lib/nova/instance in nfs. This part is called on configure-os stage when network elements are created
Closes: https://issues.redhat.com/browse/OSPRH-7088

There is an issue in the roles/edpm_extra_mounts/molecule/default/verify.yml with line endings. Nothing a quick pre-commit run wouldn't fix.


[WFLY-8225] Elytron Subsystem Upgrade and backport ongoing integration work

:bangbang: Commits from this branch are used in numerous other topic branches so please do not cherry-pick or rebase. :bangbang:
Depends on https://github.com/wildfly/wildfly-core/pull/2202
The following can be resolved with this PR: -
https://issues.jboss.org/browse/WFLY-8206
https://issues.jboss.org/browse/WFLY-8208
https://issues.jboss.org/browse/WFLY-8090
https://issues.jboss.org/browse/WFLY-8225
https://issues.jboss.org/browse/WFLY-7936
https://issues.jboss.org/browse/WFLY-8229

Retest this please


there is no st cookie

Something about the login process probably changed. There is no st cookie in the Eurosportplayer anymore.
No login possible this way

yup. no more st cookie, can't log into the service anymore...


issue 214 minor bug in session.apply_span_src

Codecov Report

Merging #255 (243f62f) into master (d57f1a7) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   75.95%   75.94%   -0.01%
==========================================
  Files          44       44
  Lines       13847    13849       +2
==========================================
+ Hits        10517    10518       +1
- Misses       3330     3331       +1

Impacted Files
Coverage Δ

exetera/core/dataset.py
73.87% <0.00%> (-0.68%)
:arrow_down:

exetera/core/session.py
72.86% <100.00%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57f1a7...243f62f. Read the comment docs.


resource limits dont get adjusted after host spec's change

Rancher versions:
rancher/server: 1.5.9
Docker version: (docker version,docker info preferred)
1.12.6
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
ubuntu 16.04
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
VM
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
HA
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:

add host
power off host, resize in terms of mem/cpu
view host through edit view

Results:
The host resource limits havent changed from when the host had lower spec's. The hosts actual resources were re-detected just fine, but the host resource limits weren't recalculated.

They are set specific values in the database, initially defaulted to the size at the time the host is added but can be changed by the user later.

sure they can, but host spec changes are detected when an agent restarts, why not readjust these as well?

Because there is currently no way to distinguish "The user set it to X" from "The user never set it but it was automatically set to X at the time the host was added".   It's just a number in the database.
You need a way to know the difference to be able to decide whether it should be updated or not when the host is suddenly Y instead of X.  Such as storing null or -1 as a signal that the host's size should be used, and storing a real number only if specifically set by the user.

That makes perfect sense. Thanks @vincent99

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


CLI wallet functionality tests

We need functional tests for wallet commands in CLI. Some memory-backed single-node network can be used for that. But I don't want #1354 to ever happen again.

Closed via #1378.


Merge remote-tracking branch 'refs/remotes/juanpablopizarro/master'

Esto es una prueba

please create a pull request from your topic branch to your master branch.

please use your own master.


Add Background Image and nav bar to Blog section page

Problem
-The Blog Page has no background to it and the CSS is also incomplete. Even the navbar is not proper
Suggestion

I will add the background image and make the CSS of the page better and also will add a proper navbar.

Please assign me this issue @SahityaRoy

I would like to solve the issue by adding CSS , background image and nav bar to the blog section page. Please assign this issue to me.

Hey,Can I work upon this issue under GSSOC 2022.

I am a participant under GSSOC 2022. I would like to work on the issue. Please assign it to me


Doc update

Coverage remained the same at 19.06% when pulling 68a81f362de71a34ac0e47597936397d8c0e610b on enolfc:docs into d9a6c4637979b94fb117cdee25fa2e661f71c1ab on IFCA:master.


Question: How would one use failover?

Hello,
I got two servers I'd like to use as lighthouses,
I managed creating a connection between server A or B and client, all good.
However I'd like to use server A as main server and B as failover,
preferrably via one hostmap entry if possible.
Best regards,
Alex

At the moment I don't think this is possible, you can list multiple lighthouses and if i understand correctly, nebula will try to use whatever lighthouse is available. Outside of nebula however you could use a load balancer and have that sit infront of your lighthouses.

Dear Editor: Gay City News
The ONLY issue of your paper I have ever read, was the one entitled: “Impeach Rumsfeld”, where there were photos of the Iraqi prisoners being tortured (Private Lindy EnglandPin auf Disturbing Things , in which all of the senior officers of the US Military: Don’t Ask, Don’t Tell were listed by name.
Pin auf Disturbing Things
10.08.2012 - Lynndie England holding a leash attached to a prisoner at Abu Ghraib prison in Iraq were many prisoners were tortured and abused.
The last time I saw Donald Rumsfeld, was at the Brooklyn Public Library, Grand Army Plaza:
Each ACCOUNT, was allowed to use the computers for an hour at a time. There are camera strategically located throughout the building.
That day, Lindsay strolled in casually, and slipped into the seat next to mine. I immediately did a search for “Lindsay Lohan” after which images of her filled the screen.
Wolé Fayemi v Kings County, Mustafa, Jenardinan et al
Arrived un a private ambulette ordered by Jedediah Burack. Picked up at 280 E21st Street, 1B:
Dr Jinardinan. What should I call you?
DINO: Dino
Dr J: Why do you want to be called that?
DINO: are you willing to sign a Non Disclosure Agreement?
Dr. J: ...Very well.
You will spend the next 72 hours sleeping on the floor of the overcrowded Emergency Room, which is infested with cockroaches and mice, during which time Sukanye of WB11 news, will watch you as you’re crying (laughing), and then you will he visited by Sarah, who will ask you to sign a deposition re: Class Action Lawsuit. You will have a brief meeting with a #PsychobabblebullshitArtist, who will ask you to sign the admission papers, while your brothers high school classmate, Joel Abramson, watches silently.
Dr J: I will assign then assign you to Dr. Colin Powell, III’s son: Director of the FCC, and you will spend the next 7 months there against your will, force injected Haloperidol 3 times a day. You’ll probably pass out and drool, when you’re not screaming at the top of your lungs and telling crazy stories about your girlfriend in San Francisco before your ex-wife: bit.ly/jailbait_juaperez.
Ever since I relayed, on Google Plus, that OBVIOUSLY, the Iraq War was just like Cosovo.
As The CEO of Hard Hat Bid explained it to me, approximately 6 months before the 9/11 bombings, “war is business”. We tear things down, so that we can profit from the contracts to rebuild”
Curiously, after the bombings, the US was hesitant about sending troops in during the summer (it was too hot they said)...
Wolé M. Fayemi
Motorious Automotive, llc
347-499-2253

On Oct 23, 2020, at 8:47 PM, bonedaddy<EMAIL_ADDRESS>wrote:

At the moment I don't think this is possible, you can list multiple lighthouses and if i understand correctly, nebula will try to use whatever lighthouse is available. Outside of nebula however you could use a load balancer and have that sit infront of your lighthouses.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Why one or the other, both is better.
As I understand, when both are defined in the config they are both used and provides more redundancy.  This is what I am currently running -- 2 lighthouses in separate AWS regions and 6 clients, some in the AWS regions and 1 as gateway with unsafe routes on my home LAN -- all have both lighthouses in the config.  I can stop either lighthouse at anytime and traffic keeps flowing between the nodes.

Why one or the other, both is better.
As I understand, when both are defined in the config they are both used and provides more redundancy.  This is what I am currently running -- 2 lighthouses in separate AWS regions and 6 clients, some in the AWS regions and 1 as gateway with unsafe routes on my home LAN -- all have both lighthouses in the config.  I can stop either lighthouse at anytime and traffic keeps flowing between the nodes.

Since there hasn't been any recent discussion on this ticket explaining the motivations for failover (active/passive, as opposed to active/active), I'm closing this issue out as stale/not planned.


migrate to dockerfile-plus to use Dockerfile imports

This would benefit the project in various ways:

Keep Docker container philosophy
Separate build stages to make rebuilding faster
Reduce clutter caused by bash scripts

https://github.com/edrevo/dockerfile-plus

closing for now


'add a new note' functionality

WHEN I enter a new note title and the note’s text
THEN a "Save Note" button and a "Clear Form" button appear in the navigation at the top of the page

now functional


Updating Missing EquivalentBuiltInParser property

Required items, please complete.
Change(s):

Adding 'EquivalentBuiltInParser' property for Vectra XDR Audit Logs Event ASIM Parser
Adding missing property in unifying parsers

Reason for Change(s):

Missing Property

Version Updated:

0.1.0

Testing Completed:

NA

Checked that the validations are passing and have addressed any issues that are present:

NA

cancelling this PR. Raised another - https://github.com/Azure/Azure-Sentinel/pull/9032


README: Razor syntax highlighting

https://github.com/github/linguist/blob/bf853f1c663903e3ee35935189760191f1c45e1c/lib/linguist/languages.yml#L2617-L2630

Cool, ty! My vs-code  doesn't understand this.


Rerun clang-tidy fix

This is fix against missing source files happened to get merged at once.

Closing in favor of #24459


Transition.noTransition is not handled in the GetPageRoute class

Hi, the Transition.noTransition is not working so I dig into the source code and found that it is not handled in the buildTransitions method. Where the NoTransition class is defined in default_transitions.dart but not used.
Can you please check into this issue? Thanks

I'll fix it, thanks

Fix on 3.4.0


add docs for dms serverless

adds a paragraph about dms serverless, and details for the configuration that can be set for serverless.

One suggestion: we can add a section for Replication Configs, similar to the one we have for Replication Instances in the docs.

The section refers to the resource browser though, and we don't have a resource browser for serverless yet.

Thanks for clarifying, maybe in that case we could create a backlog item for this and we are good to go for this PR then 👍

I have already created a backlog item last week 😄


Count specifies packets received, not packets sent

Count on Unix ping specifies the number of packets to send, whereas in this library, it waits for Count received packets.
This means that you will see more than the desired number of packets sent if you get any packet loss, or your ping time is higher than your interval.
Replicable if you run with the arguments "-c 10 -i 1ms"; you will see more than 10 packets sent, 10 packets received.

I can fix it oversending packets easily, I will have to think about having it count based on number sent to make sure there are no unintended consequences. Most likely it means there needs to be a per-packet timeout.


BookToAnki

Scan image, use OCR on text, extract characters
Crazy adaptation:
Apply OCR to video feed, of a GoPro of someone in China (sort by frequency)

I think to get quality flashcards that accurately reflect the source text, OCR may not be good enough (artefacts, OCR failures, image processing libraries, OCR library etc. needed).
I don't think anyone is going to photograph their textbook then make flashcards from it.
@danielt998 shall we close this as not going to be implemented?

I kind of disagree, still think this could be useful sorry (doesn't necessarily matter if OCR is not 100%)

In that case we should probably go with http://tess4j.sourceforge.net/ (Apache License 2.0)
If we're hosting on a server, we should ask users if their test is simplified, traditional, or mixed - detection would use a quite of resources, and to serve more users we'd need to make each interaction as lightweight as possible.

How computationally expensive is OCR? And would using a frontend library for that be an option?

https://github.com/naptha/tesseract.js/blob/master/README.md apparently runs either in browser or in node
OCR could be several seconds per A4 page, one page per thread. Could be slow if many users try to OCR many docs at the same time. Could email them when done if queue is long.

yeah then I don't know, it would really depend on what server capacity we had if we were to produce a web frontend. We could still implement for the desktop app though :)

leave OCR to the users, or another repo. Out of scope for H2A


Bug - The docs rendering scripts are skipping functions

The function reference is missing functions that are available in the runtime.

The bug was that uncategorized docs were not being assigned by default to the general category as before. For now, this is restored, but a better fix will be to require functions to be categorized or force a compiler error.

fixed, and sorted alphabetically as well