Edge-node deployment: Issue at while running join cluster in openness 20.06.01

Hi,
While deploying edge-node(sh deploy_ne.sh nodes) failing at below step.
Can you please help me to resolve this?
TASK [kubernetes/worker : join the cluster] **********************************************************************************************************
task path: /home/sysadmin/Devika/openness/openness_20_06_01/openness-experience-kits/roles/kubernetes/worker/tasks/main.yml:39
fatal: [node01]: FAILED! => {
"changed": true,
"cmd": [
"kubeadm",
"join",
"<IP_ADDRESS>:6443",
"--token",
"hbkw5a.3sh15d4v11u93n2x",
"--discovery-token-ca-cert-hash",
"sha256:b722978135b66f3e0bd92f1a17044116c030f5ecf5a40fdd5c1143fcb8b35abe",
"--v=2"
],
"delta": "0:00:00.446995",
"end": "2020-09-17 18:15:54.716672",
"rc": 1,
"start": "2020-09-17 18:15:54.269677"
}
STDOUT:
[preflight] Running pre-flight checks
[preflight] Reading configuration from the cluster...
[preflight] FYI: You can look at this config file with 'kubectl -n kube-system get cm kubeadm-config -oyaml'
STDERR:
W0917 18:15:54.338674   27359 join.go:346] [preflight] WARNING: JoinControlPane.controlPlane settings will be ignored when control-plane flag is not set.
I0917 18:15:54.338790   27359 join.go:371] [preflight] found NodeName empty; using OS hostname as NodeName
I0917 18:15:54.338827   27359 initconfiguration.go:103] detected and using CRI socket: /var/run/dockershim.sock
I0917 18:15:54.338885   27359 preflight.go:90] [preflight] Running general checks
I0917 18:15:54.339121   27359 checks.go:249] validating the existence and emptiness of directory /etc/kubernetes/manifests
I0917 18:15:54.339133   27359 checks.go:286] validating the existence of file /etc/kubernetes/kubelet.conf
I0917 18:15:54.339142   27359 checks.go:286] validating the existence of file /etc/kubernetes/bootstrap-kubelet.conf
I0917 18:15:54.339151   27359 checks.go:102] validating the container runtime
I0917 18:15:54.421970   27359 checks.go:128] validating if the service is enabled and active
I0917 18:15:54.535699   27359 checks.go:335] validating the contents of file /proc/sys/net/bridge/bridge-nf-call-iptables
I0917 18:15:54.535740   27359 checks.go:335] validating the contents of file /proc/sys/net/ipv4/ip_forward
I0917 18:15:54.535761   27359 checks.go:649] validating whether swap is enabled or not
I0917 18:15:54.535783   27359 checks.go:376] validating the presence of executable conntrack
I0917 18:15:54.536018   27359 checks.go:376] validating the presence of executable ip
I0917 18:15:54.536137   27359 checks.go:376] validating the presence of executable iptables
I0917 18:15:54.536151   27359 checks.go:376] validating the presence of executable mount
I0917 18:15:54.536246   27359 checks.go:376] validating the presence of executable nsenter
I0917 18:15:54.536264   27359 checks.go:376] validating the presence of executable ebtables
I0917 18:15:54.536274   27359 checks.go:376] validating the presence of executable ethtool
I0917 18:15:54.536284   27359 checks.go:376] validating the presence of executable socat
I0917 18:15:54.536295   27359 checks.go:376] validating the presence of executable tc
I0917 18:15:54.536304   27359 checks.go:376] validating the presence of executable touch
I0917 18:15:54.536322   27359 checks.go:520] running all checks
I0917 18:15:54.626142   27359 checks.go:406] checking whether the given node name is reachable using net.LookupHost
I0917 18:15:54.626288   27359 checks.go:618] validating kubelet version
I0917 18:15:54.671267   27359 checks.go:128] validating if the service is enabled and active
I0917 18:15:54.678175   27359 checks.go:201] validating availability of port 10250
I0917 18:15:54.679493   27359 checks.go:286] validating the existence of file /etc/kubernetes/pki/ca.crt
I0917 18:15:54.679505   27359 checks.go:432] validating if the connectivity type is via proxy or direct
I0917 18:15:54.679535   27359 join.go:441] [preflight] Discovering cluster-info
I0917 18:15:54.679562   27359 token.go:78] [discovery] Created cluster-info discovery client, requesting info from "<IP_ADDRESS>:6443"
I0917 18:15:54.687385   27359 token.go:116] [discovery] Requesting info from "<IP_ADDRESS>:6443" again to validate TLS against the pinned public key
I0917 18:15:54.693495   27359 token.go:133] [discovery] Cluster info signature and contents are valid and TLS certificate validates against pinned roots, will use API Server "<IP_ADDRESS>:6443"
I0917 18:15:54.693508   27359 discovery.go:51] [discovery] Using provided TLSBootstrapToken as authentication credentials for the join process
I0917 18:15:54.693514   27359 join.go:455] [preflight] Fetching init configuration
I0917 18:15:54.693518   27359 join.go:493] [preflight] Retrieving KubeConfig objects
I0917 18:15:54.711364   27359 preflight.go:101] [preflight] Running configuration dependant checks
I0917 18:15:54.711380   27359 controlplaneprepare.go:211] [download-certs] Skipping certs download
I0917 18:15:54.711389   27359 kubelet.go:111] [kubelet-start] writing bootstrap kubelet config file at /etc/kubernetes/bootstrap-kubelet.conf
I0917 18:15:54.712842   27359 kubelet.go:119] [kubelet-start] writing CA certificate at /etc/kubernetes/pki/ca.crt
I0917 18:15:54.713948   27359 kubelet.go:145] [kubelet-start] Checking for an existing Node in the cluster with name "node01" and status "Ready"
error execution phase kubelet-start: cannot get Node "node01": nodes "node01" is forbidden: User "system:bootstrap:hbkw5a" cannot get resource "nodes" in API group "" at the cluster scope
To see the stack trace of this error execute with --v=5 or higher
MSG:
non-zero return code
PLAY RECAP *******************************************************************************************************************************************
node01                     : ok=173  changed=42   unreachable=0    failed=1    skipped=72   rescued=0    ignored=5
[root@controller openness-experience-kits]#
Thanks,
Devika

Can anyone please help me on this?
Thanks & Regards,
Devika

Hi @Jaladi-Devika
Our team is looking at this error, we'll get back to you soon

Hi @Jaladi-Devika
The machines you used for deployment were clean and fresh install of centos7? We noticed that this error can occur if there was already deployed kubernetes cluster

Hi @tomaszwesolowski ,
Worker-node is clean and fresh. I tried running clean_ne.sh script multiple times as well.
Can you please suggest how to clear this error?
Thanks & Regards,

Are you able to connect from one machine to another (node to controller)?

@tomaszwesolowski ,
Yes am able to do ssh from  node to controller and controller to node both.

@tomaszwesolowski ,
Is there any update? can you please update on this issue? Its blocking our activity.
Thanks & Regards,
Devika

Hi @Jaladi-Devika,

Could you please try to deploy it again but with --v=5 in https://github.com/open-ness/openness-experience-kits/blob/openness-20.06.01/roles/kubernetes/worker/tasks/main.yml#L40
Do you deploy whole cluster from scratch with openness 20.06.01? If not, what is openness and k8s version on you controller node?

Hi @kamilpoleszczuk ,
I Have deployed cluster from openness 20.06.01 and I didn't install k8s maually.
Will try deploying nodes with --v=5

Hi @kamilpoleszczuk ,
Tried deploying node with --v=5 but still failed.
TASK [kubernetes/worker : join the cluster] **********************************************************************************************************
task path: /home/sysadmin/Devika/openness/openness_20_06_01/openness-experience-kits/roles/kubernetes/worker/tasks/main.yml:39
fatal: [node01]: FAILED! => {
"changed": true,
"cmd": [
"kubeadm",
"join",
"<IP_ADDRESS>:6443",
"--token",
"w617sc.43ay3zl2m4nninao",
"--discovery-token-ca-cert-hash",
"sha256:b722978135b66f3e0bd92f1a17044116c030f5ecf5a40fdd5c1143fcb8b35abe",
"--v=2"
],
"delta": "0:00:00.464564",
"end": "2020-09-29 18:22:17.655099",
"rc": 1,
"start": "2020-09-29 18:22:17.190535"
}
STDOUT:
[preflight] Running pre-flight checks
[preflight] Reading configuration from the cluster...
[preflight] FYI: You can look at this config file with 'kubectl -n kube-system get cm kubeadm-config -oyaml'
STDERR:
W0929 18:22:17.221318   14827 join.go:346] [preflight] WARNING: JoinControlPane.controlPlane settings will be ignored when control-plane flag is not set.
I0929 18:22:17.221375   14827 join.go:371] [preflight] found NodeName empty; using OS hostname as NodeName
I0929 18:22:17.221493   14827 initconfiguration.go:103] detected and using CRI socket: /var/run/dockershim.sock
I0929 18:22:17.221548   14827 preflight.go:90] [preflight] Running general checks
I0929 18:22:17.221595   14827 checks.go:249] validating the existence and emptiness of directory /etc/kubernetes/manifests
I0929 18:22:17.221606   14827 checks.go:286] validating the existence of file /etc/kubernetes/kubelet.conf
I0929 18:22:17.221611   14827 checks.go:286] validating the existence of file /etc/kubernetes/bootstrap-kubelet.conf
I0929 18:22:17.221618   14827 checks.go:102] validating the container runtime
I0929 18:22:17.307511   14827 checks.go:128] validating if the service is enabled and active
I0929 18:22:17.393573   14827 checks.go:335] validating the contents of file /proc/sys/net/bridge/bridge-nf-call-iptables
I0929 18:22:17.393644   14827 checks.go:335] validating the contents of file /proc/sys/net/ipv4/ip_forward
I0929 18:22:17.393666   14827 checks.go:649] validating whether swap is enabled or not
I0929 18:22:17.393691   14827 checks.go:376] validating the presence of executable conntrack
I0929 18:22:17.393964   14827 checks.go:376] validating the presence of executable ip
I0929 18:22:17.394115   14827 checks.go:376] validating the presence of executable iptables
I0929 18:22:17.394306   14827 checks.go:376] validating the presence of executable mount
I0929 18:22:17.394409   14827 checks.go:376] validating the presence of executable nsenter
I0929 18:22:17.394424   14827 checks.go:376] validating the presence of executable ebtables
I0929 18:22:17.394434   14827 checks.go:376] validating the presence of executable ethtool
I0929 18:22:17.394444   14827 checks.go:376] validating the presence of executable socat
I0929 18:22:17.394456   14827 checks.go:376] validating the presence of executable tc
I0929 18:22:17.394465   14827 checks.go:376] validating the presence of executable touch
I0929 18:22:17.394483   14827 checks.go:520] running all checks
I0929 18:22:17.493330   14827 checks.go:406] checking whether the given node name is reachable using net.LookupHost
I0929 18:22:17.493469   14827 checks.go:618] validating kubelet version
I0929 18:22:17.565367   14827 checks.go:128] validating if the service is enabled and active
I0929 18:22:17.575277   14827 checks.go:201] validating availability of port 10250
I0929 18:22:17.575922   14827 checks.go:286] validating the existence of file /etc/kubernetes/pki/ca.crt
I0929 18:22:17.575934   14827 checks.go:432] validating if the connectivity type is via proxy or direct
I0929 18:22:17.575966   14827 join.go:441] [preflight] Discovering cluster-info
I0929 18:22:17.575990   14827 token.go:78] [discovery] Created cluster-info discovery client, requesting info from "<IP_ADDRESS>:6443"
I0929 18:22:17.601475   14827 token.go:116] [discovery] Requesting info from "<IP_ADDRESS>:6443" again to validate TLS against the pinned public key
I0929 18:22:17.636075   14827 token.go:133] [discovery] Cluster info signature and contents are valid and TLS certificate validates against pinned roots, will use API Server "<IP_ADDRESS>:6443"
I0929 18:22:17.636098   14827 discovery.go:51] [discovery] Using provided TLSBootstrapToken as authentication credentials for the join process
I0929 18:22:17.636106   14827 join.go:455] [preflight] Fetching init configuration
I0929 18:22:17.636110   14827 join.go:493] [preflight] Retrieving KubeConfig objects
I0929 18:22:17.646727   14827 preflight.go:101] [preflight] Running configuration dependant checks
I0929 18:22:17.646749   14827 controlplaneprepare.go:211] [download-certs] Skipping certs download
I0929 18:22:17.646764   14827 kubelet.go:111] [kubelet-start] writing bootstrap kubelet config file at /etc/kubernetes/bootstrap-kubelet.conf
I0929 18:22:17.649858   14827 kubelet.go:119] [kubelet-start] writing CA certificate at /etc/kubernetes/pki/ca.crt
I0929 18:22:17.652126   14827 kubelet.go:145] [kubelet-start] Checking for an existing Node in the cluster with name "node01" and status "Ready"
error execution phase kubelet-start: cannot get Node "node01": nodes "node01" is forbidden: User "system:bootstrap:w617sc" cannot get resource "nodes" in API group "" at the cluster scope
To see the stack trace of this error execute with --v=5 or higher
MSG:
non-zero return code
PLAY RECAP *******************************************************************************************************************************************
node01                     : ok=173  changed=42   unreachable=0    failed=1    skipped=72   rescued=0    ignored=4
[root@controller openness-experience-kits]#

Hi @Jaladi-Devika,
from logs attached:
"kubeadm", "join", "<IP_ADDRESS>:6443", "--token", "w617sc.43ay3zl2m4nninao", "--discovery-token-ca-cert-hash", "sha256:b722978135b66f3e0bd92f1a17044116c030f5ecf5a40fdd5c1143fcb8b35abe", "--v=2" so --v=5 was not applied.
Could you please provide output from kubectl describe node of your controller node?

hi @kamilpoleszczuk ,
here is the output of "kubectl describe node controller"
[root@controller openness-experience-kits]# kubectl describe node controller
Name:               controller
Roles:              master
Labels:             beta.kubernetes.io/arch=amd64
beta.kubernetes.io/os=linux
kube-ovn/role=master
kubernetes.io/arch=amd64
kubernetes.io/hostname=controller
kubernetes.io/os=linux
node-role.kubernetes.io/master=
Annotations:        node.alpha.kubernetes.io/ttl: 0
ovn.kubernetes.io/cidr: <IP_ADDRESS>/16
ovn.kubernetes.io/gateway: <IP_ADDRESS>
ovn.kubernetes.io/ip_address: <IP_ADDRESS>
ovn.kubernetes.io/logical_switch: join
ovn.kubernetes.io/mac_address: a6:b9:40:40:00:03
ovn.kubernetes.io/port_name: node-controller
CreationTimestamp:  Tue, 08 Sep 2020 17:03:00 +0530
Taints:             node-role.kubernetes.io/master:NoSchedule
Unschedulable:      false
Lease:
HolderIdentity:  controller
AcquireTime:
RenewTime:       Tue, 29 Sep 2020 19:59:24 +0530
Conditions:
Type                 Status  LastHeartbeatTime                 LastTransitionTime                Reason                       Message

NetworkUnavailable   False   Thu, 17 Sep 2020 13:28:50 +0530   Thu, 17 Sep 2020 13:28:50 +0530   FlannelIsUp                  Flannel is running on this node
MemoryPressure       False   Tue, 29 Sep 2020 19:56:16 +0530   Tue, 08 Sep 2020 17:02:55 +0530   KubeletHasSufficientMemory   kubelet has sufficient memory available
DiskPressure         False   Tue, 29 Sep 2020 19:56:16 +0530   Tue, 08 Sep 2020 17:02:55 +0530   KubeletHasNoDiskPressure     kubelet has no disk pressure
PIDPressure          False   Tue, 29 Sep 2020 19:56:16 +0530   Tue, 08 Sep 2020 17:02:55 +0530   KubeletHasSufficientPID      kubelet has sufficient PID available
Ready                True    Tue, 29 Sep 2020 19:56:16 +0530   Thu, 17 Sep 2020 13:25:12 +0530   KubeletReady                 kubelet is posting ready status
Addresses:
InternalIP:  <IP_ADDRESS>
Hostname:    controller
Capacity:
cpu:                4
ephemeral-storage:  256710176Ki
hugepages-1Gi:      0
hugepages-2Mi:      2Gi
memory:             16138772Ki
pods:               110
Allocatable:
cpu:                4
ephemeral-storage:<PHONE_NUMBER>10
hugepages-1Gi:      0
hugepages-2Mi:      2Gi
memory:             13939220Ki
pods:               110
System Info:
Machine ID:                 e7e0d38b4e154d76aef4cebf17de6dc4
System UUID:                326605B6-8F27-11E4-A70B-CC493E523800
Boot ID:                    fb9cce7d-911d-49ab-9889-8830632ac0e7
Kernel Version:             3.10.0-957.el7.x86_64
OS Image:                   CentOS Linux 7 (Core)
Operating System:           linux
Architecture:               amd64
Container Runtime Version:  docker://19.3.9
Kubelet Version:            v1.18.4
Kube-Proxy Version:         v1.18.4
PodCIDR:                      <IP_ADDRESS>/24
PodCIDRs:                     <IP_ADDRESS>/24
Non-terminated Pods:          (20 in total)
Namespace                   Name                                                          CPU Requests  CPU Limits  Memory Requests  Memory Limits  AGE

kube-system                 coredns-6955765f44-b9zfl                                      100m (2%)     0 (0%)      70Mi (0%)        170Mi (1%)     21d
kube-system                 coredns-6955765f44-n9nrv                                      100m (2%)     0 (0%)      70Mi (0%)        170Mi (1%)     21d
kube-system                 etcd-controller                                               0 (0%)        0 (0%)      0 (0%)           0 (0%)         12d
kube-system                 kube-apiserver-controller                                     250m (6%)     0 (0%)      0 (0%)           0 (0%)         12d
kube-system                 kube-controller-manager-controller                            200m (5%)     0 (0%)      0 (0%)           0 (0%)         12d
kube-system                 kube-flannel-ds-amd64-psstr                                   100m (2%)     100m (2%)   50Mi (0%)        50Mi (0%)      12d
kube-system                 kube-multus-ds-amd64-h4t4b                                    100m (2%)     100m (2%)   50Mi (0%)        50Mi (0%)      12d
kube-system                 kube-ovn-cni-tgxtm                                            0 (0%)        0 (0%)      0 (0%)           0 (0%)         12d
kube-system                 kube-ovn-controller-64b46fd7d4-dj2ld                          0 (0%)        0 (0%)      0 (0%)           0 (0%)         12d
kube-system                 kube-proxy-qvtdx                                              0 (0%)        0 (0%)      0 (0%)           0 (0%)         21d
kube-system                 kube-scheduler-controller                                     100m (2%)     0 (0%)      0 (0%)           0 (0%)         12d
kube-system                 ovn-central-7dd57dff9-tdkdm                                   500m (12%)    0 (0%)      300Mi (2%)       0 (0%)         12d
kube-system                 ovs-ovn-2v4wd                                                 200m (5%)     1 (25%)     1Gi (7%)         1Gi (7%)       12d
openness                    docker-registry-deployment-5776d7c7c5-ttblr                   0 (0%)        0 (0%)      0 (0%)           0 (0%)         12d
openness                    nfd-release-node-feature-discovery-master-58d4b46578-9q94p    0 (0%)        0 (0%)      0 (0%)           0 (0%)         12d
openness                    syslog-master-254z8                                           100m (2%)     500m (12%)  128Mi (0%)       128Mi (0%)     12d
telemetry                   custom-metrics-apiserver-fb988c8c7-tr4zm                      0 (0%)        0 (0%)      0 (0%)           0 (0%)         12d
telemetry                   grafana-6b4f99684-b9bss                                       0 (0%)        0 (0%)      0 (0%)           0 (0%)         12d
telemetry                   prometheus-server-6f6f89c9ff-zmh7k                            0 (0%)        0 (0%)      0 (0%)           0 (0%)         12d
telemetry                   telemetry-aware-scheduling-75596fd6b4-tfg58                   0 (0%)        0 (0%)      0 (0%)           0 (0%)         12d
Allocated resources:
(Total limits may be over 100 percent, i.e., overcommitted.)
Resource           Requests      Limits

cpu                1750m (43%)   1700m (42%)
memory             1692Mi (12%)  1592Mi (11%)
ephemeral-storage  0 (0%)        0 (0%)
hugepages-1Gi      0 (0%)        0 (0%)
hugepages-2Mi      1Gi (50%)     1Gi (50%)
Events:
[root@controller openness-experience-kits]#

hi @kamilpoleszczuk,
Any update on this? Any clue what is the issue?
THanks & Regards,
Dviks

Hi @Jaladi-Devika,
As error execution phase kubelet-start: cannot get Node "node01": nodes "node01" is forbidden: User "system:bootstrap:w617sc" cannot get resource "nodes" in API group "" at the cluster scope To see the stack trace of this error execute with --v=5 or higher is k8s error, --v=5 could give some useful information. Is there any specific reason why controller was set up separately and then ./deploy_ne.sh nodes was executed?

HI @kamilpoleszczuk ,
No specific reason, actually every time we used to deploy like this only 1st controller and then edge-node.

Hi @Jaladi-Devika, does the problem still appear? If not, do you agree to close this ticket, and reopen it if need be?

@Jaladi-Devika Closing ticket. Please let me know, when the problem is visible again.


Unable to process unmanaged instance group with managed_instance_group.py

managed_instance_group.py doesn't give an option to create unmanaged instnace group. In case of creation of unmanaged instnace group instance template should not be required.

Was your expectation from the ' Managed Instance Group' template to support 'Unmanaged Instance group' or you would rather looking for an ' Unmanaged Instance Group' Template? ( I understand the functional overlap, however the MIG template is much more complex because of the InstanceTemplate dependency. )

Separate template just for the Unmanaged Instance Group would be the simplest solution. As you wrote it's much simpler than MIG template.


chore(main): release 1.5.1

:robot: I have created a release beep boop
1.5.1 (2024-03-26)
Bug Fixes

main: Removed inclusion of the _version.py file in autoapi (39ba2c7)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/CoreySpohn/lod_unit/releases/tag/v1.5.1 :sunflower:


Request code review for rspec  branch

In this branch, using Rspec testing framework we have added spec to check the status of the game in all conditions (win, tie or still playing).

Please Note: there's no issues with rubocop on our end, but for some reason stickler says otherwise

turned out GitHub wasn't receiving file permissions from commits

We have deleted the "main" file.
We have added a new class to control the board.
We split the main method into smaller ones.
We have added specs for all the public methods.

Status :ambulance: Required Changes :ambulance:

Hi @javitocor and @Spayco :wave:,
Wow a short pointed readme, contains most of the information that is needed to play the game. But the project structure does not seem like possessing all the requirements yet. Check out the points below and try to fix the issues.

We write tests to ensure that the individual units are performing properly. So as much as, you can test your classes and their methods, the more you are confirming that they are performing properly. But the way you have structured your project seems like, it is conflicting OOP principles. Your methods are tightly coupled. That is why is a struggling situation for you to add more test. It would be better for you if you schedule a meeting with a TSE to discuss more on this topic.

Mandatory Changes

You can use let to assign a variable that will be used in your test.
https://github.com/Spayco/Tic-Tac-Toe-Game/blob/8a6f3ec304cbfb2df546223004711e854cee96fe/spec/game_spec.rb#L6-L18
before line 7 you can add the following line:

let(:checker_game_on) { Game.new('SpaYco', 'Javier') }

then you can remove the following line from the chunk.
checker_game_on = Game.new('SpaYco', 'Javier')
2. I agree with the previous TSE. Still, the number of methods you have tested are few.

Optional Changes

All classes are kept in the lib directory. (screenshot from Pathwright)
The code should respect the single responsibility rule for methods (i.e. each method does exactly one thing). (screenshot from Pathwright)

Please fix the above-mentioned issues and send another review request.

:herb: Happy Coding :herb:
Shakhawat Hossain

We have added specs for all the methods within String class
We have added the variable "let" to make the spec code better
All the public methods in classes string, board and game are tested
Every one of our methods does one single thing

Added "let" variable to board class specs


Avoid recomputing sin/cos in rotate main loop

Not tested

thanks. sincosf is not really standard math.h and is only a GNU C extension, so preferably it comes with proper guards. i'll do that when I get to it after NIPS. (for example, I am not sure yet if it is present in bionic C of android where this library is used, or in iOS where it is also used.)

there are a couple of other sin/cos in the same file that can be lifted out of one or both loops as well.


[Bug]: getSession and refreshSession don't update the session property

Summary
Calling getSession and refreshSession don't update the session property.
Reproduction Steps
Use either method to refresh or get your session using access/refresh tokens.
Expected Results
Afterward, the session property is updated, and subsequent requests are properly authenticated.
Actual Results
The session property is not modified by getSession or refreshSession, meaning subsequent requests are not authenticated.
What operating systems did you experience this bug? (We'll count Docker as an operating system.)
macOS
Operating System Version
15.2 (24C101)
ATProtoKit Version
main
Additional Context
No response

Actually, has this been handled by 739254e?

I'll look into it with respect to refreshSession. getSession will be a tiny bit more tricky, since the response to the request will pretty much be the same (unless the token was revoked, expired, or nonexistent), but I'll see what I can do there.
As for your question, yes: the helper methods of that commit is used to update create a new UserSession object in ATProtocolConfiguration.session. Is it still not working? I made sure they were tested to work properly...

Is it still not working? I made sure they were tested to work properly

I apologise — I filed this before I saw that a lot of work had been done this week. Filing this issue was sitting on my to do list since our conversation on Discord earlier in the week — I only had time for it yesterday.

It's fine. For now, I'm going to close the issue, but if it doesn't work, then please re-open the issue and I'll look into it.
That said, when it comes to getSession specifically, I'm struggling to understand why it should update ATProtocolConfiguration.session. When you want to get that session, you need the access token. When the response is made, it doesn't give you a ton of information, and rarely does it ever change (this isn't a limitation with my library, but with how that request works in the AT Protocol). Could you explain to me what the use case would be for it to change (save for if the token(s) is/has expired/revoked)? I guess there's a disconnect with respect to what I'm understanding.

I guess there's a disconnect with respect to what I'm understanding.

No, I doubt that!
So maybe my thinking is not correct? My thought process was that on making a request:

Try with the access token we have (is this getSession(…)?). If that fails:
Use the refresh token to refresh the access token, and use the updated access token (which would update the local user session). If that fails:
Authenticate and retrieve a new refresh/access token pair and use that access token (and update the local user session).

So perhaps getSession(…) updating the user session is pointless? 🤔


UI: parse docker error object on docker api calls

Problem
Docker can sometimes send an error object embedded in the response of api calls
Tasks

look for that obj, and act accordingly

CNR


Update /transparency and /selection

In short:

Add our initiatives to /transparency
Add funding decision graphic to /selection

The .png image was removed with commit 27c193c5ccdcdc35cc97c2652acf71691f96e183 - so that's why the image doesn't show.


Suppress Findings

Is it possible to suppress an EOL finding?  For example, xeol is indicating that the EOL for spring-boot is coming. THere's no newer version to upgrade to, so i want to suppress this. Is that possible? I do not see any documentation on what the configuration file can take.
NAME         VERSION  EOL         DAYS EOL  TYPE
spring-boot  3.1.5    2024-05-18  100       java-archive
1 error occurred:
        * discovered EOL packages
        ```

this is a good idea. since we dont have a CVE or other stable ID like a vulnerability scanner, we could hijack our fingerprinting logic to use in suppressing findings
https://github.com/xeol-io/xeol/blob/main/xeol/match/fingerprint.go

Thanks. Just to be clear, this is a capability not possible in xeol currently?

Nope, not currently possible


Calculator By using node.js

Hey ! buddy
I made a calculator by using node.js. it is really amazing.
can i add that to your project .
would please assign me this task ?

ok

Could you assign me this project?

GO on


Fix DPI for MSTSC for retina screens [$25]

There is a $25 open bounty on this issue. Add to the bounty at Bountysource.

Obsolete now we're using parsec.


dropdown in landscape mode has extra space and is not displayed correctly

🐛 Bug Report
Trying components which have a drop down list (such as Select or Autocomplete) in landscape mode results in the list having extra space, which I assume is caused because of the mobile notch.
In portrait mode dropdowns are shown just fine.

To Reproduce
Steps to reproduce the behavior:
const SelectComponent = () => {
  const [selectedIndex, setSelectedIndex] = React.useState(new IndexPath(0));
  return (
    <Layout style={{minHeight:10,width:200}} level='1'>
      <Select
        selectedIndex={selectedIndex}
        onSelect={index => setSelectedIndex(index)}>
        <SelectItem title='Option 1'/>
        <SelectItem title='Option 2'/>
        <SelectItem title='Option 3'/>
      </Select>
    </Layout>
  );
};

export default SelectComponent ;

Expected behavior
Dropdowns being shown correctly in any mode
UI Kitten and Eva version

Package
Version

@eva-design/eva
2.0.0

@ui-kitten/components
5.0.0

Thanks in advance

Hi, @soheilaGhayour. Thanks for noticing the issue. The issue seems to be appeared because of your StatusBar configuration on Android. Specifically for Android, we've ModalService that could apply your current Status Bar height into all modal-based components like: Select, Popover, Modal, ect.
Please, paste this code into your application in order to enable Status Bar height support:
...
import { ModalService } from '@ui-kitten/components'

ModalService.setShouldUseTopInsets = true
...


Add clang-format

Could you provide some additional context on this, when I run the command, the file doesn't get created, and from looking at the man page, it seems like clang-format doesn't depend on this file being in $HOME.

Alright, I would suggest adding a sentence or two about how you can put the file in your project dir or any of the parent directories at the top, though. If you want to do that, go ahead, otherwise I'll do it myself in a couple of hours.
Thanks for your help!


Gift cards: better surface expiry date

Following up on this thread: https://opencollective.slack.com/archives/C0RMV6F8C/p1569949743159400
We had multiple cases of people that couldn't find their gift cards because they were expired and they didn't know the reason. We should make that clearer.
A few ideas have been suggested in this thread:

[ ] Make sure that it's not possible to redeem an expired gift card and that the error message is clear (should already be the case).

[ ] Add the expiry date on the gift card displayed on the redeem page

[ ] Continue to show expired gift cards up to one month after their expiry date in the contribution flow, but make them disabled in the list and add a Expired tag.

Because (3) is more complex, we should tackle (1) and (2) in priority and eventually follow up with (3) in a separate issue.

@znarf can we tackle this in the redeem page changes you are doing?

@piamancini Nothing I'm taking care of. Maybe for Ben as part of https://github.com/opencollective/opencollective/issues/2536

Thanks for the heads up, I'll take care of that as part of https://github.com/opencollective/opencollective-frontend/pull/2929

thanks ben!

Still two boxes to check. First improvement made in https://github.com/opencollective/opencollective-frontend/pull/2929

Closing, will follow up with the last item in https://github.com/opencollective/opencollective/issues/2673


docs: added a setting status page.

This PR adds a new page for setting the bot's status.

[x] My pull request is made against the dev branch.
[x] I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
[x] I have ensured that all methods and functions are fully documented using doxygen style comments.
[x] I tested my commits, by adding a test case to the unit tests if needed
[x] I have ensured that I did not break any existing API calls.
[x] My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
[x] I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

Corrected the misc.md subpage creation, removing the "<title>" from the line.

Too much cod, but it's beatiful!11!!1!1!11

this would be better if we then show in a second example how to set the status on a timer e.g. with a guild count in it. pay attention though to the fact that the presence is set per shard so you'll need to loop all shards to set presence properly

I like that idea! I'll get onto that now.

this would be better if we then show in a second example how to set the status on a timer e.g. with a guild count in it.

The suggested example has now been added and is ready for a review!


Remove: TheDocumentFoundation.LibreOffice.PreRelease version <IP_ADDRESS>

## Newer versions exist in repo
Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

URL: https://downloadarchive.documentfoundation.org/libreoffice/old/<IP_ADDRESS>/win/x86_64/LibreOffice_<IP_ADDRESS>_Win_x64.msi
(Automated message - build 598)

Hi @Trenly,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 876.)

URL: https://downloadarchive.documentfoundation.org/libreoffice/old/<IP_ADDRESS>/win/x86_64/LibreOffice_<IP_ADDRESS>_Win_x64.msi
Status Code: 200
(Automated message - build 876)

@stephengillie - intentional removal


Add a passthrough relationship

Let's assume there's an ingress.
Let's assume X talks to Y through the ingress.
If I put all the relationships through the ingress, the peer-to-peer information (from/to) is lost:
X1 -> ingress
X2 -> ingress
ingress -> Y1
ingress -> Y2

I propose to be able to specify a "pass through" relatinship this way:
X1 -> ingress -> Y1
X2 -> ingress -> Y2

I took a look at doing this, and it's not particularly straightforward given how the DSL currently works. I'll keep this in the back of my mind, but closing the issue for now.


cohere: Add types to clients and drop v4 support from partner package

cohere: Add types to clients and drop v4 support from partner package

Do in partner repo!
https://github.com/langchain-ai/langchain-cohere


When "allow cantrip preparing" setting is enabled - allow "prepared" filter to exclude unprepared cantrips

Hey, love the module. If it is possible, could you please implement an enchancement, which allows to declutter spell list by removing unprepared cantrips with filter? Thank you

Tidy v2.7.0 now have this feature. Give it a try and see what you think.

Closing as completed.


[BUG]: i can not log in my account

How are you running AnythingLLM?
Docker (remote machine)
What happened?
for some reason, when i insert the credentias it says: Error: Could not validate login.
i already refresh the stack on docker, somebody can help´me?

Are there known steps to reproduce?
No response

This is not the place to post this issue. If you are in password mode your password is the ENV for AUTH_TOKEN in the storage folder .env file.


[S] Spike: How to connect Day Use Pass to Data Register

This ticket is to determine how to connect DUP and the data register and to develop an approach that covers all areas of DUP that may be affected.
Acceptance Criteria:

Investigate where Park name is used and where it will be affected in DUP by connecting to an external api/the data register (ie. DU pPublic, export report, admin, keycloak)
Document approach for how connect in #288 (linked below)

Notes:

blocks #288 in DUP repo: https://github.com/bcgov/parks-reso-api/issues/288

For Public:  There are no changes to make as the data feed for parks all comes from the api.
For Admin:

On Edit the Park Name field needs to be turned into a non-modifiable field, just how the Park ORCS field works.
If DUP adds a 'New Park' feature, the admin page should show a search page that queries the data register.  This way the user can pick based on name/orcs/etc and that is used to see the park name in the back-end of the DB.

For API:
The general idea is to cache the data from the data register overnight and keep all queries for DUP locked into the DUP API.

nightly job to query the data register should query based on orcs and update the park name field when a change is detected on the pk: park.  Facilities do not need to be updated as they do not have the name property on their object.
Existing passes don't need to be changed as the key is off of orcs.  Their display name can remain 'old' and will not have an impact other than the display name field being out of date.  It is not very performant to update the 100,000's of records with the new name.
Facilities will need to be updated to use an identifier as opposed to keying off of name if the data register starts to serve out those names.
The reservations object needs to be converted to use the orcs identifier in the PK instead of the name.  Currently it is reservations::<name>::<facility> This is a breaking change that will need to be done before we allow name changes to happen.
In doing the reservation object change, a displayName field should be attached to the object as it currently only exists on the pk.  See writeFacility, writeModifier, writePass lambda functions.
Data model for DUP should be created and stored in a NoSQL Workbench file and committed to the repository.
Future improvements for the data register are to build a push mechanism to tell DUP to update as opposed to having DUP poll nightly.


Add c-bata to kubeflow org as a member

I started to contribute to Katib.

/ok-to-test
/lgtm
Contributions: https://github.com/kubeflow/katib/pulls?q=author%3Ac-bata+

/assign @theadactyl

Hi @abhi-g! Could you review this PR?

Thanks @c-bata for your contributions.
/approve


Bug: Can't use BlurEffect with Scrollview

Adding a blue effect to a scrollview causes an exception
<ScrollView>
    <ScrollView.Effects>
        <uranium:BlurEffect Mode="Dark" />
    </ScrollView.Effects>

<!--    <content> -->
</ScrollView>

I get the following error when running

Not sure it is related, but I can't seem to get the blue effect to work in the following scenario:
<Grid>
        <Grid.Effects>
            <uranium:BlurEffect Mode="Dark" />
        </Grid.Effects>
        <ScrollView>
              <!--    <content> -->
         </ScrollView>
</Grid>

Doing so shows nothing that is blurred

By the way, settting WidthRequest is required for android since it can't calculate the size of parent of parent automatically

I was able to get it to work by placing a grid around the scrollview that had the effect + adding the width to the grid
I did notice that the AccentOpacity is not bindable. Was that a design decision?

I was able to get it to work by placing a grid around the scrollview that had the effect + adding the width to the grid
I did notice that the AccentOpacity is not bindable. Was that a design decision?

PlatformEffects are not BindableObject and designed by doıtnet/maui, So there is no way to define BindableProperties to Effects. They still reflect runtime changes but {Binding } extension can't be used at the moment

There is nothing to do on my side for android implementation of blur. If there is a better implementation on native android we can move to it.
https://github.com/mmin18/RealtimeBlurView repository seems stale for now but it was the best option for the first implementation of blurs.


Why was pointfree dot replaced by ^ ?

The previous version had better ergonomics.
This version makes it uglier, doesn't translate verbatim from Haskell, and requires more fingers to type

Thanks for your comment.
I completely agree. That was my concern, too. The caret symbol is not only very ugly but also misleading.
So, I reverted to using dot notation again.
Like the expression (_ + 5) . (8 * _) Syntax Error cannot be caught without manipulating ast. To addrress this, I had to the rule for . composition:

Wrap the functions in fx when using lambda expressions and .

All my test have passed, but I would appreciate any feedback on potential issues it might have.
As you know, using the . symbol for function composition requires me to work on __getattr__.
Overriding __getattr__, so-called an attribute fallback, is quite risky compared to other noraml binary operator like __xor__, __or__, __mul__, and so on. That was the primary reason I decided to avoid using . symbol for composition operator.
Thanks for your suggestion and, I hope you enyoy it!

@thyeem oh wow, brilliant! Thanks for reconsidering it!


Stateless actor timer invocation.

Description
Stateless actor timer invocation.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #134
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[X] Code compiles correctly
[X] Created/updated tests
[ ] Extended the documentation

Validated using example and adding a debug message to confirm it was the new code being executed on triggering timer (FIRE NEW VERSION!!!!):
== APP == INFO:     <IP_ADDRESS>:63846 - "PUT /actors/DemoActor/d7627040-27b8-4f73-9394-6075ca406d95/method/remind/myremind HTTP/1.1" 200 OK

== APP == FIRE NEW VERSION!!!!

== APP == time_callback is called - timer_state

== APP == INFO:     <IP_ADDRESS>:63846 - "PUT /actors/DemoActor/1/method/timer/demo_timer HTTP/1.1" 200 OK

== APP == FIRE NEW VERSION!!!!

== APP == time_callback is called - timer_state

== APP == INFO:     <IP_ADDRESS>:63846 - "PUT /actors/DemoActor/1/method/timer/demo_timer HTTP/1.1" 200 OK

== APP == INFO:     <IP_ADDRESS>:63857 - "GET /healthz HTTP/1.1" 200 OK

@artursouza please ensure that PR build is working.

This change is validated with the example. See description. Also, the build is also working.


NetworkHasControlOfEntity Issues

The pull request that was merged #1 has an issue here where it may never return.
In my testing this can cause beds to not delete if the script gets locked in this loop and the vehicle is then deleted. There should be a timeout or something similar put into it to prevent this.
https://github.com/glitchdetector/fivem-functional-flatbed/blob/f49a516a051896b3b8639c8fa89d1b66cb845b69/flatbed.lua#L245

After som debugging, i found out that this happens when the raycast returns 0 which means it hasn't found a vehicle on the bed... For some reason the if statement 'if newCar then' does nok work correctly.
I changed it to 'if newCar ~= 0 then'. And then made an else statement for when the raycast returns 0.
This prevents the script  from ever going into the infinite loop you are mentioning. There are some addon cars that the raycast just wont find. Therefore i also added so that if the raycast returns 0 it instead uses the last car that i entered, which should be the car i drove onto the bed. This has been working flawlessly ever since.

@Mikkelhost hello I had found the same problem your changes interests me a lot
just like the LSPD model problem or the fact that a non-mechanic can control the maneuver
if you could share me your work thank you very much, the author does not seem to update the script anymore or correct all this

Thats my fix of breaking the function othzerwise
                                if newCar ~= 0 then                                     local carPos = GetEntityCoords(newCar, false)                                     NetworkRequestControlOfEntity(newCar)                                     while not NetworkHasControlOfEntity(newCar) do Wait(0) end                                     AttachEntityToEntity(newCar, bed, 0, attachmentOffset[1] + vector3(0.0, 0.0, carPos.z - bedPos.z - 0.50), attachmentOffset[2], 0, 0, false, 0, 0, 1)                                     car = newCar                                     DecorSetInt(veh, "flatbed3_car", VehToNet(newCar))                                     attached = true                                     DecorSetBool(veh, "flatbed3_attached", attached) 								else 									attached = false                                 end


Relax check for reviewer checklist

Details
Use indexOf instead of startsWith. It is common for reviewers to add something at the start of the comment that made this check fail.
It is unlikely that we will find ## Reviewer Checklist as part of a comment that is not the real reviewer checklist.

Fixed Issues

$ https://github.com/Expensify/App/issues/13244
Tests

Add a reviewer checklist typing something of top of the comment before the title ## Reviewer Checklist in this PR

[x] Verify that no errors appear in the JS console

QA Steps

Add a reviewer checklist typing something of top of the comment before the title ## Reviewer Checklist in a PR that is under review in App

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

cc @tgolen

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@aldo-expensify Can you QA this internally?

@aldo-expensify Can you QA this internally?

I think this has to be QA'd when it reaches production, once that happens, I can take care of it

There is no staging or production environment for the GH actions, so this can be QAed as soon as it was merged.

QAing now then!

QA passed: https://github.com/Expensify/App/pull/13442#issuecomment-1343347968

🚀 Deployed to production by @chiragsalian in version: 1.2.38-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add menu item options into config

Client apps can now either (a) supply their own menu icons, or (b) entirely use their own icons and actions (through use of the ..navigationBarItems modifier).
I refactored the code some too. Sorry it was a fairly large refactor as Xcode/SwiftUI was causing me difficulties and it made debugging the problem easier to split things out into more independent View's. I think it does, however, improve readability.
This should (hopefully!) be a non-breaking change. Other applications using this package should still work with no change.

This should resolve: https://github.com/Vidhyadharan24/SideMenu/issues/5

This should resolve: https://github.com/Vidhyadharan24/SideMenu/issues/5

@crspybits that's a lot of work, I will have a look at it.

Happy to answer any questions you might have about this PR. I'm actively using my changed fork of your repo in https://apps.apple.com/us/app/neebla/id1244482164 (and see https://github.com/SyncServerII/Neebla/). Would be happy to switch back to this repo if this was merged in.


Could I do a code review?

Hi,
I'm not sure if you remember me but we were in the same team at that AI camp about a year ago.
I'm glad you're interested in Rust! It's been my language of choice for a couple of months now. Reading through the code, I see some things I could fix. Would you be interested?
If you'd like to see some of the code I've written in Rust, here's an example: https://github.com/V5Reveng/cli

@mattfbacon Of course, I remember you! It was a lot of fun making the Fake News Detector with you.
I would really appreciate it if you could do a code review. I am fairly new to Rust, so it would be great to have you look over the code. Thanks!

One thing I'm wondering: if I make it so that all the config variables can be set via the environment, do you still want them to be able to be set from the command line arguments?

If you're able to make it so the config variables can be set via the environment, I don't think we would need to be able to set the config variables via command line arguments. Feel free to make the functionality and remove the set-var command line feature. Just make sure to update the READMe once you're done. Thanks!


Unable to use Firebase Crashlytics with Mac Catalyst app when installed using SPM

[REQUIRED] Step 1: Describe your environment

Xcode version: 12.0 beta 6
macOS Catalina 10.15.6
Firebase SDK version: branch 6.32-spm-beta
Firebase Component: Crashlytics
Component version: 6.32-spm-beta
Installation method: Swift Package Manager

[REQUIRED] Step 2: Describe the problem
When trying to use FirebaseCrashlytics in macCatalyst app, following compilation errors happen:
ld: symbol(s) not found for architecture x86_64
Undefined symbol: _CTRadioAccessTechnologyCDMA1x
Undefined symbol: _CTRadioAccessTechnologyCDMAEVDORev0
Undefined symbol: _CTRadioAccessTechnologyCDMAEVDORevA
Undefined symbol: _CTRadioAccessTechnologyCDMAEVDORevB
Undefined symbol: _CTRadioAccessTechnologyEdge
Undefined symbol: _CTRadioAccessTechnologyGPRS
Undefined symbol: _CTRadioAccessTechnologyHSDPA
Undefined symbol: _CTRadioAccessTechnologyHSUPA
Undefined symbol: _CTRadioAccessTechnologyLTE
Undefined symbol: _CTRadioAccessTechnologyWCDMA
Undefined symbol: _CTRadioAccessTechnologyeHRPD
Undefined symbol: _OBJC_CLASS_$_CTTelephonyNetworkInfo

Steps to reproduce:

Install Firebase Crashlytics via SPM
import Firebase
Try to compile for macCatalyst

Opinion
I think this is happening because most of those constants are marked as API_UNAVAILABLE(macos).
Probably errors originate from here.
Possible solution - exclude calls to those constants using #if TARGET_OS_MACCATALYST, although i'm not 100% sure it's a complete solution for macCatalyst.

@DenTelezhkin Thanks for the report. Your suggestions sounds reasonable. We'll investigate more deeply this week.

Actually, it looks like those symbols should be available for Catalyst.
I'm able to work around by explicitly linking CoreTelephony:

I'll continue to investigate if there's a way to make this automatic.

@paulb777 Linking CoreTelephony explicitly works on my side too, thanks!
FYI, I also tried PR you opened to fix this(#6419), but it did not work on my side, producing the following:
Unknown type name 'CTTelephonyNetworkInfo'
Use of undeclared identifier 'CTRadioAccessTechnologyGPRS'
Use of undeclared identifier 'CTRadioAccessTechnologyEdge'
Use of undeclared identifier 'CTRadioAccessTechnologyWCDMA'
Use of undeclared identifier 'CTRadioAccessTechnologyHSDPA'
Use of undeclared identifier 'CTRadioAccessTechnologyHSUPA'
Use of undeclared identifier 'CTRadioAccessTechnologyCDMA1x'
Use of undeclared identifier 'CTRadioAccessTechnologyCDMAEVDORev0'
Use of undeclared identifier 'CTRadioAccessTechnologyCDMAEVDORevA'
Use of undeclared identifier 'CTRadioAccessTechnologyCDMAEVDORevB'
Use of undeclared identifier 'CTRadioAccessTechnologyeHRPD'
Use of undeclared identifier 'CTRadioAccessTechnologyLTE'
Use of undeclared identifier 'CTTelephonyNetworkInfo'


Content changes listings, hold and publish flows as specified in Design Review

Changes in this PR:
Content changes listings, hold and publish flows as specified in Design Review
Trello card / Rollbar error (etc)
https://trello.com/c/6SUqtJGI/1444-eui-design-review-of-current-site
Screenshots of UI changes:
Reorder text for unpublished header
Before

After

Omit colons in subheadings
Before

After

Change text from Go to Sort
Before

After

Change put on hold header and button
Before

After

HOLD & PUBLISH FLOW CHANGES
Change notification banner text for hold and publish (hold images below publish notifications is done same)
Before

After

Change on-hold success header text
Before

After

Change unhold header and button
Before

After

Change unheld notification banner text
Before

After

Change unheld success header text
Before

After

Change publish header and button
Before

After

Change publish success header text
Before

After

Change unpublish header and button
Before

After

Change unpublished success header text
Before

After

[ ] Requires env variable(s) to be updated

 [EUI] Design Review of current site


File Error Handling

PULL REQUEST
Summary
Adds error handling for both .zip and too large file size. It doesn't use the default React USWDS because it was too difficult. Error handling is all custom. Includes the tests for the functionality as well
Large file error

Wrong file type error

Related Issue
Fixes #876 and #875

@KennethSkylight thanks for the screenshots!
few things:

the alignment on the left is not all aligned, all elements should have the same vertical alignment on the left. not sure how else to explain that better in writing (perhaps the file input box and buttons below should be shifted to the right to align with the text above it? does that make sense?)
also this can be addressed in a separate ticket since it's not specifically about the error design, but I just noticed in the blue box, the "this tool is..." text oddly cuts off to be on a second line seemingly for no reason. is it possible to get "site." to be in the first line so it's not unnecessarily 2 lines of text? if that's too tricky here I'll document as a future improvement

@sarahtress Here's the new alignment

@KennethSkylight looks good for the alignment! any thoughts on being able to fix in the blue box "site." being on the next line? I can add that to a future improvement if it's too much for this ticket, just lmk!

@sarahtress oops my bad didn't commit that change.


[merge] highlighting of diff chunks should always be present

Repro:

Put long files in the three panes of the CM merge view
Scroll down.

Expected:
The green/red highlighting is immediately visible.
Actual:
The green/red highlighting only appears after a delay.

This is an optimization -- drawing the highlighting and connectors for a huge document is expensive, so the addon does it lazily, for the current viewport. I can add an option to turn this off, if you want, but I'm not responsible for any slowdown that might cause.

We don't have the connectors anymore (since we switched to using the aligned diffs) and I don't see why the diff marking classes should be any more or less expensive to add than the classes already added to tokens for syntax highlighting.

Syntax highlighting also happens lazily. It's just well enough integrated with the drawing code that you (usually) don't notice. (In general, there's no DOM created for stuff outside of the viewport.)


[question/request] output_metrics_options availability HTTP probe

To whom it may concern,
I was wanting to use output_metrics_options in the HTTP probe but apparently its only available in the external type.  Is there a reason for this?  I would love to be able to add additional tags to whatever probe type i can - specifically environment without having to write Prometheus regex labels.
Thanks!
ie:
  http_probe {
    protocol: HTTPS
    output_metrics_options {
      additional_labels: "environment=location1,service=example"
    }
  }

@jbkc85 If you're looking for output_metrics_options only for additional labels, there is another way to do it (though it's not released yet):
https://github.com/google/cloudprober/blob/ee717b051237150cd3a03825f033c789867887e3/probes/proto/config.proto#L100-L112
Though I understand that output_metrics_options can be useful for HTTP probes regardless in case you want to parse metrics from HTTP probe output.

I just released a new version v0.10.5 that has support for the additional_label field. Also added an example. Since this particular issue seems to be just about that, marking it closed. I've file a different feature request to build metrics from the HTTP probe output: #297.


Allow types from other crates with table!

This doesn't affect infer_schema! yet (which is where this is most
important), but it lays the groundwork required. Additional modules to
import types from can be specified by writing using types from list::of::paths. Due to how use works here, these will always need to
be relative to the crate root, and self or super will be
inconsistent.
This shouldn't matter, since the most common case is going to be to
import types from a third party crate, which means there will usually be
extern crate whatever at the root.
For the table! macro to finish, we now need to know all of the
following:

table name
schema name
table body
primary key
type modules

Only two of those things are mandatory, so we basically have to have
3! branches in the table! macro to handle every combination of
information that could be given. I'm not sure if there's a way that we
can just have one branch per optional piece, but I don't believe we can.

@killercup What are you imagining your syntax would look like for infer_schema!?

Updated, needs a re-review.


"Hidden = true" in icon theme's "index.theme" file is not respected

nwg-look shows icon themes in its "Icon theme" tab that have the property "Hidden" set to "true" in the theme's "index.theme" file. You're not really supposed to do that: https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
In this case, it's the "Adwaita" and "AdwaitaLegacy" themes that are visible.

Well, from now on the Adwaita cursor theme is invisible. To be able to get back to it, one needs to edit the icon.theme file. I'm not sure if I like it.


Need samples for .net core, ASP.net, Blazor, WinUI

It would be great to have samples for more than just UWP and WPF. Other technologies also need to do localization:

.net core
ASP.net
Blazor
WinUI
...

e.g. asp.net.

You simple create a new project called "Myproject.Resources".
Install Microsoft MAT and add translations
In your other project add/reference Myproject.Resources and use e.g. the Myproject.Resources.[yourlocation].Resources.MyTranslatedString

It is simple putting your resx files in a separate assembly for reuse in the project and you keep your resx resources up-to-date via MAT.
update the source language strings in the .resx file and for the other languages you update your xlf files.
see: https://stackoverflow.com/questions/1142802/how-to-use-localization-in-c-sharp/60000088#60000088

I understand the process, but it would be useful to have actual samples for other technologies, so that you can see how resource binding works in each kind of app.

@PaulDempsey-ms Hello! I madea pull request with the Asp Core demo you requested.

Blazor Server might use also some examples :-)

Oh great!
I would love to contribute to that too.

I use WPF + .Net 6, the MAT not working for me ((.
The MAT can't find any resources (.resx) in my project.
It works if I use *.resw files (by path : /strings/en-US/.resw) instead *.resx , but the MAT clears all my translations each time after building my project.
Please add a sample on how to use WPF + .Net 6 + Windows App SDK.
Thanks.


Accept bootindex=off to remove device (disk or nic) from UEFI Boot list

Omitting the bootindex parameter to QEMU prevents OVMF firmware from attempting to boot the device.  This is useful for when you need NICs but have no reason to boot from them (skip the dreaded PXE v4, v6, HTTP v4, v6 long boot timeouts. \o/

@hallyn please double check this works for you as well.


Restore trailing slash accidentally removed in https://github.com/apache/beam/pull/25665

This unbreaks the container.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @abacn


[CHORE] Update .gitignore for JetBrains IDE and pyenv user

I assume you are all vscode users. This PR will make jetbrains fanatics happy 😉

thanks for making this issue @MeepoWin! Yeah we are vscode users lol


Atom IDE getting blurried

Hi, I have a problem that is very annoying and I really want to fix it. My Atom IDE is getting blurried with no apparent reason and when I click under the blurried space it goes normal again.

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us halfway :grinning:


fixed touch detection to select topmost scatterspot

Summary
This pull request fixes an issue with the touch detection logic in the scatter chart where the incorrect scatter spot is selected when multiple spots overlap. The current implementation selects the first matching spot in the list, which is visibly behind other spots, as the spots are rendered in chronological order (last spot in list rendered on "top). This change ensures that the topmost spot is selected when multiple spots overlap.
Changes Made

Updated the handleTouch method in scatter_chart_painter.dart to iterate through the scatter spots in reverse order. This ensures that the topmost spot is selected when multiple spots overlap.

Rationale
In scatter charts, when multiple spots overlap, users expect to select the topmost spot. The previous implementation selected the first matching spot, which could be behind others if there are intersecting spots. By iterating through the spots in reverse order, the touch detection logic now correctly selects the topmost spot.
Testing

Verified that the touch detection now selects the topmost spot correctly when multiple spots overlap.

Screenshots (if applicable)
In the below screenshot, the light blue spot was not previously selectable as the larger orange spot (being rendered earlier) was always returned first by handleTouch. With this change, the spots are able to be selected as one would expect (topmost first).

Checklist

[x] I have tested the changes locally and they work as expected.
[x] I have ensured that my code follows the code style of this project.

Nice!
Thanks for contributing!


⚠ Jerry Savelle Ministries International Australia has degraded performance

In 18c8bd4, Jerry Savelle Ministries International Australia (https://jsmiaustralia.org) experienced degraded performance:

HTTP code: 200
Response time: 10378 ms

Resolved: Jerry Savelle Ministries International Australia performance has improved in e141a38 after 9 minutes.


⚠ Fortnite has degraded performance

In cd4d26f, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1755 ms

Resolved: Fortnite performance has improved in 01deede.


improve update strategy to recalculate diff if resource has changed since last fetch, and if diff still matches, perform update

this improvement should help in scenarios where non-significant part of resource keeps on changing (for example /status) while user is reviewing changes. to avoid having to restart deploying again, kapp should try to recalc diff and if it's still the same, go ahead and apply it.

implemented in https://github.com/k14s/kapp/commit/d237d9454ff5b22bb045d9f0ed0df03a15cbe700 and https://github.com/k14s/kapp/commit/06192504e066d2ddbbc1d045c196d1de2641252d

included in https://github.com/k14s/kapp/releases/tag/v0.15.0


Rewrite C++ class to use records with native values instead of uint32 everywhere

Similar to VHDL generators.

Consider making nested namespaces instead of each field defining the full namespace hierarchy.


Add a favicon to the website

Add a favicon.
Before:

After:

I checked this PR locally. The fav icon works as expected in my Firefox and chromium browser. Approve

Thanks, merged


Tasks decorator

Tasks decorator + fixes

Thank you @tomerlf1 for this new functionality!
In general, PR LGTM (considering my comments) and I think we can submit it.
More changes will be applied / requested in the near future regarding the code
style, comon readability and best practices.


Instrument creation function on client side

Send instruction to the server for creation of new instrument.
Should include the feature to:

check if the instrument  is already exist on the server
automatically create a proxy object for this new instrument

Consider using the configuration file(YMAL) for finding the correct instrument driver.


Do row rendering in angular zone

What kind of change does this PR introduce? (check one with "x")

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
When using virtual scrolling, after scrolling down, the event listeners for the newly rendered rows are created outside of the angular zone, which breaks automatic change detection from these event listeners.
Angular Material Tooltip stop working after virtual scrolling #1321
Virtual scroll causes issues with auxilary (named) routes #1223
Can't select a row when I scroll down with a mouse #1216
Dialog not working after scrolling #1348
What is the new behavior?
The scroll event is emitted from inside an angular zone so event emitters in the row templates are run the in the same zone and change detection works automatically.
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Would be nice to get this merged as this is currently breaking my entire application when scrolling in the table and clicking a row.
I've been forced to downgrade to 11.0.4 for the time being, but that has it's own set of bugs.

@amcdnl, seems like this is causing a bunch of issues.
For me causing router links to not work once scrolling down.
I know you guys are super busy, just checking if this hasn't been merged due to no time, or if there is an issue with the fix itself.
Would like to start a discussion of other possible solutions if this won't be merged due to it having performance implications.

@deeg we were trying to inspect any effect on the performance this might have. Running it in the zone would trigger angular's change detection, which is essentially what we want here, but we wanted to do more tests and understand how much this will affect performance, so we don't have to go back and revert it later on.

@marjan-georgiev, thanks for the update. I'm currently doing the same and haven't seen any issue with making it run inside the zone.
I am not rendering millions of rows, but have tested it out with 1000+ rows rendered at once.
If anyone is interested to use a version with scrolling running in zone, you can replace your package.json:
"@swimlane/ngx-datatable": "semanticresearch/ngx-datatable#scroll-in-zone",
The only difference from release v13 is making scrolling happen inside zone:
https://github.com/semanticresearch/ngx-datatable/commits/scroll-in-zone

I think we're good to merge this. Thank you for the contribution!


Adding guide for installing mkcert on archlinux

I created an AUR PKGBUILD to quickly install mkcert on ArchLinux: https://aur.archlinux.org/packages/mkcert-git/.

Thank you! Can I ask why the -git suffix?
Also, should I ping you when I make a v1 release?

-git is simply an Arch User Repo package naming convention (meaning tha package originates from a working/master branch of an open-source project's git repo).

Makes sense, I was asking because I have now tagged v1, so maybe it's appropriate to make a PKGBUILD targeting that instead of master?

I could do both. It's common to have the git pkgbuild and the stable version pkgbuild.


now you can change the level of message in the DDMultiFormatter

fix #486

I still think that there is a logic error in mixing unformatted/formatted messages in the same variable.
You have no way to know if the contents are formatted or not, plus you modify that the original message the log call as it was sent.

Thinking we should have another approach to this problem https://github.com/CocoaLumberjack/CocoaLumberjack/issues/486#issuecomment-93724285.


Feat(infra.ci) switch kubernetes agents from publick8s to temp-privatek8s

Bump Jenkins Weekly image + charts
Use a namespace jenkins-agents as first step
Split Jenkins credentials into cik8s and temp-privatek8s (secrets loaded into sops)

Merging this PR as per https://hackmd.io/v2VSDa8KT_C28TYnmN6fjQ?view#Next-steps-WiP.
Please note that it will impact the management:

No more infra.ci for no (but a replacement running in a private cluster, only available through kubectl port-forward for nopw)
plugin-infra-site management disabled (#1862)
updatecli disabled (https://github.com/updatecli/updatecli/issues/431)
release.ci will be updated (helm chart update from #1860 not applied yet to production)
Traefik ingress will be bumped (patch updated from #1856 not applied yet to production)

All checks are 👍
Helmfile diff matches expectations


Hydrogen bundling

WHY are these changes introduced?
As part of the project to unify Shopify CLI surfaces, we want to include Hydrogen commands in the bundling.
⚠ The changes in this PR are actually small, 95% of the line changes are package.json/manifest/documentation

WHAT is this pull request doing?

Bundle @shopify/cli-hydrogen and statically load its commands.
Some improvements and cleanup in the bundle scripts
Update manifests, readme, documentation...
For some reason, I had to fix some tests in ui-extensions-server-kit

How to test your changes?
You can test by installing version 0.0.0-experimental-20240524145437 which contains the changes from this branch.
Try running any hydrogen command like:
shopify hydrogen init
shopify hydrogen build
shopify hydrogen dev
...

Post-release steps

shopify.dev docs should be updated after this PR is released. A manual PR should be opened with the new autogenerated docs.

Measuring impact
How do we know this change was effective? Please choose one:

[ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[ ] I've considered possible documentation changes
[ ] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

I've detected a couple issues in hydrogen commands when using specific flags. I'll probably fix them in a different PR, but i'll hold on merging this PR for now (to not compromise the next release)


Run memory leaks check for c code

I can create a shell script or a Makefile target to run C code under valgrind memcheck. @SanjoDeundiak , can you update ticket description, please?


Adding wrapper

Not a lot to say here, it just seems to work (locally anyway)
https://github.com/dockstore/dockstore/issues/3833

Would be nice if this were used on CircleCI as well. I can't even tell how Maven gets installed there; I guess it's part of the JDK image.

Oops, i think i forgot to put a comment in the CircleCI config file for that. it just so happens the JDK image had the exact same maven version as what we were using

it just so happens the JDK image had the exact same maven version as what we were using

Same thing goes for maven on the machine executor image we use - our version is luckily preinstalled.

Any ideas when 3.7.0 (which has the wrapper included) is coming out?

No idea
https://maven.apache.org/docs/history.html  looks like one or two years between releases so maybe soon?


Server URI is parsed incorrectly when the URI is relative

When parsing this document with OpenAPI.NET, it parses the server URL as: http:///v2, while it should only parse /v2 and not append http:// to it.
swagger: "2.0"
info:
  description: "This is a sample server Petstore server.  You can find out more about Swagger at http://swagger.io or on irc.freenode.net, #swagger.  For this sample, you can use the api key \"special-key\" to test the authorization filters"
  version: 1.0.0
  title: Swagger Petstore YAML
  termsOfService: "http://swagger.io/terms/"
  contact:
    email<EMAIL_ADDRESS>  license:
    name: Apache 2.0
    url: "http://www.apache.org/licenses/LICENSE-2.0.html"
basePath: /v2
tags:
  - name: pet
    description: Everything about your Pets
    externalDocs:
      description: Find out more
      url: "http://swagger.io"
  - name: store
    description: Operations about user
  - name: user
    description: Access to Petstore orders
    externalDocs:
      description: Find out more about our store
      url: "http://swagger.io"
schemes:
  - http

Thanks for reporting @selman92.
V2 spec splits out the URL into multiple parts, including basePath, host and schemes. In V3, these are all combined into the Server Object url.
Since our model is based on V3, when we read V2 document, we need to reconstruct the URL based on the given info. In your case, we use the http in schemes and the /v2 in basePath to construct the URL http:///v2. This V3-based DOM now conveys the same meaning as your original V2 doc.
Note that the host in the URL is empty. Ideally, we should be able to populate the host with "the host serving the documentation" but we do not have that information. We'll probably need to include an option for the caller to supply that information.

That's true. From a practical standpoint, I agree it makes more sense to just output /v2 as a relative URL. For this case specifically, if you remove the scheme: -http part, I think you will get the desired output. Would that work in your case, or do you need to specify HTTP?
Longer discussion:
I think we are in a weird technical situation. We are given the information that the scheme is 'http'. If we were to only add /v2 to the DOM, we would be dropping information which could have been retained. If we keep the http, then we run into a weird http:////v2, which is not a valid URL.
Your V2 document is saying "Use the default host, with relative path /v2, and force the scheme to be http". From my reading of the V2 and V3 specs, this is actually something that I think V3 doesn't support. I can't specify a scheme unless I also explicitly specify a host since it's now just one URL property.
Since there's no way to represent this is V3, it seems like dropping the information on scheme when host is not present (i.e. outputting just /v2) might be the right thing to do.
@darrelmiller Does this align with your understanding of this V2/V3 URL differences?


How do US based RSEs participate?

hey @ggorman ! I absolutely love this idea - documentation is overlooked and especially not catered for the academic / research cohort.
I'm a US based RSE, and there are a few groups similar to the UK Research Software Engineer Association, but not quite as established ([the ussri is focused on sustainability and only has reached out to a small number]. On the other hand, I know of teams at Princeton, a growing team at Harvard, and then scattered individuals like myself that do a lot of work in the cloud, and also care about software engineering for science.
How do we participate too?

I only just saw this @vsoch  apologies!
We are planning to run similar events in the USA next year, maybe if you drop me a line to my email I can keep you posted when we have more details

Will do! We now are working on usrse (the UK equivalent) so likely we can bring in many folks!

https://www.github.com/usrse
https://www.twitter.com/us_rse

I'll send this all in an email.


fix typo in README

cecause -> because

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @behnoodk 👋 thanks a lot for catching this and submitting the PR. In order for us to merge the PR, you still need to accept our CLA. Could you please do that so we can go ahead and merge? 🙂

@nikolasburk done ✔

Thanks so much 🙏


Series comparison to NumPy scalar fails

Comparing a dask Series with a NumPy scalar or 0D array fails in certain cases. Here is a minimal reproducible example:
import dask.dataframe as dd
import pandas as pd

np.float64(5.2) >= dd.from_array(np.arange(10))

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-18-d905075c0565> in <module>()
      1
----> 2 np.float64(10) >= dd.from_array(np.arange(10))

~/miniconda/envs/anacondaviz/lib/python3.6/site-packages/dask/dataframe/core.py in __array_wrap__(self, array, context)
   1704     def __array_wrap__(self, array, context=None):
   1705         if isinstance(context, tuple) and len(context) > 0:
-> 1706             index = context[1][0].index
   1707
   1708         return pd.Series(array, index=index, name=self.name)

AttributeError: 'numpy.ndarray' object has no attribute 'index'

I can reproduce this using all releases in the dask 0.17.x series.

cc @martindurant this might be a good issue if you have time
On Tue, Apr 10, 2018 at 11:18 AM, Philipp Rudiger<EMAIL_ADDRESS>wrote:

Comparing a dask Series with a NumPy scalar or 0D array fails in certain
cases. Here is a minimal reproducible example:
import dask.dataframe as ddimport pandas as pd
np.float64(5.2) >= dd.from_array(np.arange(10))

AttributeError                            Traceback (most recent call last)
 in ()
1
----> 2 np.float64(10) >= dd.from_array(np.arange(10))
~/miniconda/envs/anacondaviz/lib/python3.6/site-packages/dask/dataframe/core.py in array_wrap(self, array, context)
1704     def array_wrap(self, array, context=None):
1705         if isinstance(context, tuple) and len(context) > 0:
-> 1706             index = context[1][0].index
1707
1708         return pd.Series(array, index=index, name=self.name)
AttributeError: 'numpy.ndarray' object has no attribute 'index'
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/3392, or mute the thread
https://github.com/notifications/unsubscribe-auth/AASszHQV1Rp5uH9jCguuPd_Yt7-FYMb-ks5tnNtpgaJpZM4TOlMB
.

I also get an error for the same code, but not the same error. Running from master.
In [20]: np.float64(5.2) >= dd.from_array(np.arange(10))
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-20-f79e026dfad4> in <module>()
----> 1 np.float64(5.2) >= dd.from_array(np.arange(10))

TypeError: operand type(s) all returned NotImplemented from __array_ufunc__(<ufunc 'greater_equal'>, '__call__', array(5.2), Dask Series Structure:
npartitions=1
0    int64
9      ...
dtype: int64
Dask Name: from_array, 1 tasks): 'ndarray', 'Series'

In [22]: np.__version__
Out[22]: '1.13.3'

In [23]: dask.__version__
Out[23]: '0.17.2+49.g7cd5143'

I'm getting the same error as @martindurant.
It looks like np.float64(5.2) is getting converted to a 0-dimensional array (i.e. np.array(5.2)) when inputted into __array_ufunc__. Because of this, the isinstance check for Number fails
https://github.com/dask/dask/blob/b64e694032ee43273fafd47359df5237af1dacb0/dask/dataframe/core.py#L347-L349
and an error is thrown.
I can look into adding an extra check in __array_ufunc__ for 0-dimensional np.ndarrays

If anyone has time to fix this that would be welcome.
On Mon, Apr 23, 2018 at 6:13 PM, James Bourbeau<EMAIL_ADDRESS>wrote:

I'm getting the same error as @martindurant
https://github.com/martindurant.
It looks like np.float64(5.2) is getting converted to a 0-dimensional
array (i.e. np.array(5.2)) when inputted into array_ufunc. Because of
this, the isinstance check for Number fails
https://github.com/dask/dask/blob/b64e694032ee43273fafd47359df52
37af1dacb0/dask/dataframe/core.py#L347-L349
and an error is thrown.
I can look into adding an extra check in array_ufunc for
0-dimensional np.ndarrays
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/3392#issuecomment-383739840, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszOF1wnTNV_W_DuQj9Iu0FE9QlgOJks5trlIDgaJpZM4TOlMB
.

I can take this one up


fix of issue no #71

Added routes for non-existing pages/urls
Added png for the error code-404

fixes #71

@razzat008 thank you for your PR. Please include the issue number in the body of the pull request (also). For now, I've edited it, if you don't mind.


build problem

Hi, when I build the gateway-rs, some problem occurs. could anyone help me? Thanks

Don’t use the -r option to cross.
On Sun, Jan 14, 2024 at 03:04 Bei-Ji-Quan @.***> wrote:

Hi, when I build the gateway-rs, some problem occurs. could anyone help
me? Thanks
default.png (view on web)
https://github.com/helium/gateway-rs/assets/89368507/b79b4f49-3e95-4135-81e3-17cd4070d5a0
—
Reply to this email directly, view it on GitHub
https://github.com/helium/gateway-rs/issues/476, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACZBSLQ7L7ETRBMXKZBO3YOONQJAVCNFSM6AAAAABBZ6LPO6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4DANRUGQ3DQMI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

It's the same with out -r.

“cargo build --target x86_64-unknown-linux-gnu --release“   can works. But It can not be used for build aarch64 release on a x86_x64_amd machine

Can you use cargo make like the README indicates?

I do not see cargo make in README. Do you means "cross build --profile  --release build" ?


Fixed typo in codecvt.md

codecvt should be in namespace std, not stdt

@jmittert : Thanks for your contribution! The author, @, has been notified to review your proposed change.


Onboarding Request

Your Twitch username
Nighttblade

Added you back. Let me know if it doesn't work. I might have to do additional clean up since you were previously onboarded

Looks like its still not working, tested a few requests this morning.  Let me know if you need anything from my side.

Okay I'm on vacation so my availability is a little iffy, but I'll check on it soon. I think I have to delete something on my end and then make you go through the onboarding steps again. I'll let you know when to do that.

  Enjoy vacation and don't worry about it.  Thank you again.

Seems to be working again. <3 Thank you Saxy!


search suggestion clear button looks really weird

Fixed in the latest self-explanatory commit.

still weird :/
what did you fix?


I met this error when run

Hi, @zdyang @ouzoh @ankonzoid
I met this error when run similar_images_TL.py .
elxAir:similar_images_TL elx$ python3 similar_images_TL.py
Using TensorFlow backend.
Traceback (most recent call last):
File "similar_images_TL.py", line 17, in
from vgg19 import VGG19
File "src/vgg19.py", line 26, in
from keras.applications.imagenet_utils import _obtain_input_shape
ImportError: cannot import name '_obtain_input_shape' from 'keras.applications.imagenet_utils' (/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/keras/applications/imagenet_utils.py)
What's wrong to me?

@bemoregt.. had the same error. refer this and try changing the module
from keras.applications.imagenet_utils ...
to
from keras_applications.imagenet_utils.. here https://github.com/ankonzoid/artificio/blob/9398c0a180dc8eb0e1b6aa38adfb57e5a54f58b5/similar_images_TL/src/vgg19.py#L26

Hi, @rahulkishan-mobbed
Thanks a lot !

Sorry for late reply, use latest version of repo where I've changed everything to user tensorflow keras now (+ many more updates + cleaner code).


Picker not display in Item component

I cant display Picker component in Item.
<Container>             <Content>                 <Item stackedLabel >                     Picker                     <Picker                         supportedOrientations={['portrait']}                         mode="dialog"                         selectedValue="choose"                         onValueChange={(item) => {                         }}                     >                         <Item label="Choose" value="choose" />                     </Picker>                 </Item>             </Content>         </Container>
native-base : 2.1.5

@bahadircivelek Item for Picker and Input are both different.
For this to work, use Picker.Item for Item inside Picker.
<Container><Content><Item stackedLabel >Picker<Picker
                iosHeader="Select one"
                mode="dropdown"
                selectedValue={this.state.selected1}
                onValueChange={this.onValueChange.bind(this)}>
                <Picker.Item label="Wallet" value="key0" />
                <Picker.Item label="ATM Card" value="key1" />
                <Picker.Item label="Debit Card" value="key2" />
                <Picker.Item label="Credit Card" value="key3" />
                <Picker.Item label="Net Banking" value="key4" />
              </Picker></Item></Content></Container>

I try with your code but I getting the following error

Try removing stackedLabel from Item.
There seems to be some issue with stackLabel. Will be fixed in the next release.

I removed stackedLabel but I'm having the same issue.

its a but look here : https://github.com/GeekyAnts/NativeBase/pull/939

Ah! Yes, the issue seems to be with Item itself. The issue has been resolved. Will be released in the next release.
For now you can remove Item wrapper around Picker and go ahead

Item issue fixed with the latest version 2.2

@SupriyaKalghatgi Its not working

@anil1712 Yes that works partially for iOS and not for Android
<Item/> with stackedlabel is designed to work mainly with Input components. So this may not work properly.
Having Picker with this, is not an intended use-case
#1369