Cleave If you hit a foe, attack an adjacent target at the same attack bonus but take -2 AC.
Damage Reduction (10/evil) You have Damage Reduction against all except Evil attacks.
Darkvision (60 feet) You can see in the dark (black and white only).
Energy Resistance, Electricity (10) You have the specified Energy Resistance against Electricity attacks.
Energy Resistance, Fire (10) You have the specified Energy Resistance against Fire attacks.
Fly (100 feet, Good) You can fly!
Immunity to Acid You are immune to acid damage.
Immunity to Cold You are immune to cold damage.
Immunity to Petrification You are immune to Petrification.
Low-Light Vision See twice as far as a human in dim light, distinguishing color and detail.
Poison Resistance +4 (Ex) You have the listed resistance to poison.
Power Attack -4/+8 You can subtract from your attack roll to add to your damage.
Protective Aura (+4, 20 ft.) (Su) Defense against evil creatures and lesser globe of invulnerability.
Spell Resistance (25) You have Spell Resistance.
Truespeech (Su) Speak with any creature that has a language.
Uncanny Dodge (Ex) Retain Dex bonus to AC when flat-footed.

I got this statblock from Hero Lab.  You might benefit from retesting with aonprd.com.  Sometimes Hero Lab truncates some of the descriptions.
I used the latest Pathfinder system and your latest module to test this.


Client Javascript SDK as a package

Not really a issue with this repo itself, but I'm kinda in a hurry.
But I'd like to know why there isn't a npm / yarn package to Twilio Client Javascript SDK 1.4.
I'm trying to use the voice service, following this repo as a tutorial, but implementing it in React Native.
Is this package for browser usage only? How could I have access to Twilio.Client on react-native?
I already implemented a programmable-chat with success, using the provided packages twilio-chat and twilio-common.
Meanwhile, is there any way of importing a remote file or using a local javascript file (twilio.min.js) to a react-native app?
Thanks in advance.
EDIT:
Further research lead me to believe that this SDK only work for browsers since it has to deal with audio events, connection status etc. Correct me if I'm wrong. I'm now trying to implement react-native-twilio-programmable-voice .

Are you trying to use Twilio SDK with ReactNative-web? I'm in the same thing currently, I hope we can get some response from Twilio itself...

Hi @RUIFERNANDE5 , @piranna ,
If you are building a react-native app with webpack you can use the following loader to require the twilio client sdk https://www.npmjs.com/package/webpack-require-http
+1 to creating an npm module for https://media.twiliocdn.com/sdk/js/client/v1.4/twilio.min.js

you can use the following loader to require the twilio client sdk https://www.npmjs.com/package/webpack-require-http

That's cool! :-D Although in that case I would include a bundled copy of the library... Or do a npm package and publish it, too :-) But this should be done by Twilio, not by a particular... That's not serious by their side...

By the way, the non-minimified version of the library seems that has been packaged by using browserify, so it should be easy to import...

@piranna  @joliveros
I'm actually trying to integrate it with react-native mobile ios/android.
However I don't know how would this package work cuz of features like WebRTC that are intrinsic to browsers..

@RUIFERNANDE5 ,
you could try patching the twilio.js file to use https://github.com/oney/react-native-webrtc
Besides that I'm not sure that we will support react-native specifically so this may be the only route.

@joliveros What do you mean by patching?

@RUIFERNANDE5,
You could copy the twilio.js file locally and add these lines to the top of the file
var WebRTC = require('react-native-webrtc');
var {
  RTCPeerConnection,
  RTCIceCandidate,
  RTCSessionDescription,
  RTCView,
  MediaStream,
  MediaStreamTrack,
  getUserMedia,
} = WebRTC;

which effectively provides the global WebRTC functions the script needs which are not available in react-native.

You could copy the twilio.js file locally and add these lines to the top of the file

Nice trick! :-) So could this way support ReactNative both on Android, iOS and web/electron?

There's already a react-native-twilio npm module, although it's one year old. There are some more recent forks, maybe it can be useful to your job and also we could contact to the original package maintainer to give us the module name to publish this more complete and recent one, how do you both see it?

@piranna,
That looks like a good start! Thanks for finding that. I have some experience with react-native. I will be happy to make a PR which updates the module. I may have something by Monday, unless you guys beat me to it. :smile:

unless you guys beat me to it

I'll left you free the road :-) Good luck! :-D
The main problem that seems to be with react-native-twilio is that makes directly use of low level iOS libraries, and uses directly the REST API. I think the alternative proposed here of combining the oficial Twilio Javascript client with react-native-webrtc module would be a better and cleaner alternative.

+1 to that. I'll give it a shot :smile:

@joliveros @piranna currently trying, any idea how would I import the Twilio.Device? I tried var Twilio = require('./twilio.js'); but got a empty object.

Maybe you would need to use de-browserify.

I also needed to declare window.navigator.userAgent with a RN package

@piranna I'll give it a shot, thanks for helping out guys!

@RUIFERNANDE5 , @piranna ,
this seems to be a more up-to-date module: https://github.com/hoxfon/react-native-twilio-programmable-voice

this seems to be a more up-to-date module: https://github.com/hoxfon/
react-native-twilio-programmable-voice

No ReactNative-web support :-(

@joliveros, have you got any progress? :-) If not, how do you suggest that I take a look at it?


Signature help option and keyboard shortcuts

Support the same keyboard interactions as VS Code:

Mod-Shift-Space to open
Escape to close

Add an automatic/manual option in the settings.
We had a brief discussion about naming and agreed to go with "Parameter help" for now. VS Code uses "Parameter hints". LSP uses "Signature help" but that's a more complicated notion for our users. We might revisit.

Code change looks good now, apart from the weird naming inconsistency that we should discuss.

Code change looks good now, apart from the weird naming inconsistency that we should discuss.

We discussed briefly and went with "Parameter help". Might revisit.

e4fd137 updates the script to remove keys not in en.json.

e4fd137 updates the script to remove keys not in en.json.

Looks good!


Filtering a 'with' clause

According to @tabacitu's reply in #101, it's possible to add an eager-loaded relationship clause (i.e. a 'with' clause) to the query via addClause(). I've got a Campaign model and CampaignSession model with the 'campaign_id' column on the campaign_sessions table being a foreign key of the 'id' column on the campaigns table. The basic 'with' clause in my CampaignsCrudController is then:
$this->crud->addClause('with', 'campaignSessions');

This works fine, but I need to specify additional query constraints for the eager-loaded query. I tried something like this without success:
$this->crud->addClause('with', ['campaignSessions' => function ($query) {
	$query->select(['campaign_id', 'name AS campaign_name']);
}]);

Using this constrained clause, I looked at the contents of $this->crud->query and found that although the 'eagerLoad' closure's parameters contained a $query object, the latter was empty.
Is it possible to have a constrained 'with' clause?

Hi @sijones-uk ,
Never tried it myself, but it should work. Maybe try a different operation in the closure, see if that one applies?
If not, since the $crud property is public, you can also do this:
$this->crud->query = $this->crud->query->with(['campaignSessions' => function ($query) {
    $query->where('title', 'like', '%first%');
}]);

Does this fix it?
Cheers!

Thanks Christian. I tried both of the following without success:
$this->crud->addClause('with', ['campaignSessions' => function ($query) {
	$query->where('id', '=', 1);
}]);

$this->crud->query = $this->crud->query->with(['campaignSessions' => function ($query) {
	$query->where('id', '=', 1);
}]);

When I looked at the query output via dd($this->crud->query); for the latter, I got the result you can see here ($query is empty):

The weird thing is that the eager loading works, but the closure function containing the constraints is never used.

Thanks Christian. I tried both of the following without success:
$this->crud->addClause('with', ['campaignSessions' => function ($query) {
	$query->where('id', '=', 1);
}]);

$this->crud->query = $this->crud->query->with(['campaignSessions' => function ($query) {
	$query->where('id', '=', 1);
}]);

When I looked at the query output via dd($this->crud->query); for the latter, I got the result you can see in the attached image.

After more investigation, I found that if I create an Eloquent Builder object and attempt to add the eager loading via the setEagerLoads() method, the constraint isn't added. It seems that there's a wider problem, so I reported it here. The only way I'd be able to add the constraint using Backpack would be if I could somehow add a 'with' clause to $this->crud->model. It doesn't look like that's possible though.

@sijones-uk tried using scopes?

Just closing to tidy up, if you need more help feel free to shout :)

@sijones-uk ,
Just pushed an update:

relationships used in columns are now automatically eager loaded;
you can now use this syntax too: $this->crud->with('campaignSessions'), if campaignSessions is a relationship on a model;

Cheers!

Thanks @tabacitu

@sijones-uk Have you had any luck constraining the eager loaded relationship?

@victorlap I may be late, but hope it helps someone who needs to constrain a eager loading query.
As @tabacitu  has suggested in this thread above, I eager loaded with constraint and assigned to the crud's query builder.
$this->crud->query = $this->crud->query->with(['followings' => function($query) {                     $query->where('journey_user.deleted_at', null);                 }             ]);
When I dumped my $this->data['entries'], i found all the objects from my parent model was loaded along with relationships which were empty (thanks to the constraints). So later I rejected the entries which had the relations object empty.
So this is how I did:
`public function index()
{
    $this->crud->hasAccessOrFail('list');

    $this->crud->query = $this->crud->query->with(['followings' => function($query) {
                $query->where('journey_user.deleted_at', null);
            }
        ]);
    $this->data['crud'] = $this->crud;
    $this->data['title'] = ucfirst($this->crud->entity_name_plural);

    // get all entries if AJAX is not enabled
    if (!$this->data['crud']->ajaxTable()) {
        $this->data['entries'] = $this->data['crud']->getEntries();
        $this->data['entries'] = $this->data['entries']->reject(function ($value, $key){
            return $value->followings->count() < 1;
        });
    }

    return view($this->crud->getListView(), $this->data);
}`

It work for me

$this->crud->addClause('orWhereHas', 'juego' , function ($query) use($permission) {
$query->where('nombre', '=', $permission);
});


[BUG] [BACKPORT v2.8] Apps don't appear for standard user in 2.8 with certain conditions in place.

Note that this issue doesn't happen in 2.9

Setup

Rancher version: 2.8
Rancher UI Extensions: none
Browser type & version: Firefox 124.0.2

Describe the bug
Three apps are installed by admin, and the standard user ("user01") has been given limited access.
The InstalledApps count field reports 1, 2, or 3 apps depending on which namespaces have been selected,
but no apps appear in the details table.
To Reproduce
See https://jira.suse.com/browse/SURE-6972?focusedId=1336398&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-1336398 for full repro steps
Result
See above
Expected Result
See above

Internal reference: SURE-6972
Not reproducible in 2.9-head only 2.8.x

Tests pass on v2.8-68e5d43e449fcd3ef73baf1caee98da6f0104eed-head


Allow disabling depth prepass with r_depthShaders

This cvar can be used to demonstrate that #119 is caused by a faulty depth shader. Or to quantify the performance benefits of depth shaders.
AFAIK disabling them shouldn't affect the final result of rendering, so it does not need to be a cheat var. But I could be wrong. So in case the performance benefits turn out to be negative on some system, depth shaders could be turned off.

Another bug suspected to be caused by a faulty depth shader is #334. This could be tested by reverting the workaround 3c7061af2e2da7b219380d726f062f7eb9466e95. I don't know which map has this though.

But I could be wrong.

The benefit is performance, yes. Also, I think you can make it non-latch and instead do the check in R_AddDrawSurface().

AFAIK disabling them shouldn't affect the final result of rendering, so it does not need to be a cheat var. But I could be wrong.

Actually, there is. We have some shaders that use the current depth image: generic, global fog, motion blur and SSAO. While global fog and SSAO would be rendered after all depth is written anyway, the other 2 won't.

Also, it would probably break portals.

Also, I think you can make it non-latch and instead do the check in R_AddDrawSurface().

Just tried this but it wasn't totally convenient since the depth mask bits of the main shader are modified depending on whether there is a depth shader. I'd have to make a backup copy of the depth bits.

We have some shaders that use the current depth image: generic, global fog, motion blur, SSAO and dynamic light shaders (depthtile1/2 and lighttile). While global fog and SSAO would be rendered after all depth is written anyway, the other 5 won't.

Hmm yeah the light tile is a deal breaker. I don't think any of the others are problems but lighting definitely is. I'll make this a cheat cvar for debugging then.

I have realized that even dynamic lights can be made to work, if we disable the last two planes in the lighttile frustum bounds check. But I will do this later.


Expose workspace folders via a readonly getter

I could not figure out how to get information about the current workspace roots (important in a multi-root workspace), so I added a getter for it.
If we want to enforce that it is only accessed after ready is resolved, we could have ready resolve to it and remove the getter.

Specifically, the reason I needed this is these commits: https://github.com/SnakeskinTpl/language-tools/pull/8/files/7f54af2eaffee9085209975609521fe0db86b9b9..98e2571ba34e1dcbf1ad30412f8752cd5c160a67
If there is a better way to implement multi-root workspace support (with separate config files in each) using existing APIs, please let me know.


Going negative on points breaks placement

ah yeah - that is because if the player can't spend their political will/money to create a new building they can't select the button.
There should probably be some notification like a flash of red or alert saying you don't have enough will/money to create this building. (If we are going this route)


[FIX #4196] Rails/RelativeDate constant complains on lambda and proc

Fixes the following case for Rails/RelativeDate cop:
CONST = -> { 1.year.ago }
Before this fix it would show:
bug.rb:1:1: C: Rails/RelativeDateConstant: Do not assign ago to constants as it will be evaluated only once.
CONST = -> { 1.year.ago }

As reported here.

I'll merge this because I want to cut a release and I'll fix it myself.

Looking more closely in the code - this part bad_node = node.descendants.find { |n| bad_method?(n) } makes no sense to me. We should simply be inspecting whatever's the rhs on this assignment. @smakagon I'd appreciate it if you can take a look at improving this code when you have some time.

@bbatsov sure, I'll try to refactor that cop and add more specs.


[QUESTION] Configuring Logstash

Question
I want to integrate nestjs-pino into existing project to automatically have request ID and URL in logs. However, I am stuck at a point where I need to update existing configuration with logstash. Is it possible to include a guide for configuring logstash in README or just as a response to this question?

google pino logstash


Restart the project after enabling the plugin. The layout switching display mode button at the bottom of the plug-in disappears

Every time you need to switch the plug-in in Project--->Tools to display the button normally

Thank you for the report, I made some changes for 3.x #5 and 4.x #6 branch, let me know if you still encounter the same problem.


Rendering fails everytime. The rendering percentage stays at 0%. How do i fix this?

Did you just extract ffmpeg? If you used the ffmpeg download link corrscope suggests, did you extract both the .exe and the .dll files? They're both necessary.

I missed one file now it works thanks for your help.


您好 通义千问如何做继续预训练？

Reminder

[X] I have read the README and searched the existing issues.

System Info
您好 通义千问如何做继续预训练？
Reproduction
您好 通义千问如何做继续预训练？
Expected behavior
No response
Others
No response

see examples


Landscape photo taken with iOS orientation lock enabled is taken as portrait

Is this a bug report?
Yes

Have you read the Contributing Guidelines?
Yes
Environment
(Please include the following information along with any other relevant environment details.)
CameraKit Version:  1.2.0
iOS Device: iPhone 6S
iOS Version: 12.1.4
Steps to Reproduce

(Write your steps here:)

Enable orientation lock in iOS
Run the sample app
Rotate the device to lansdscape
Take a photo
Save the photo
See the photo taken and saved as portrait (rotated 90 degrees)

Expected Behavior

Photo taken in lanscape should be saved as landscape even if orientation lock is enabled in iOS (same as the default camera app)
Actual Behavior

Photo taken in lanscape is save rotated 90 degrees when iOS orientation lock is enabled.
Reproducible Demo

Sample app in this repo.

Fix idea: use CoreMotion to detect "real" device orientation instead of UIDeviceOrientation

Thanks for these detailed tickets @igorkulman - we will get a patch release out for this soon!

any update for this? or maybe a workaround on how to solve this at the moment?


TODO in RabbitBindingCleaner

see https://github.com/spring-cloud/spring-cloud-stream/blob/9dfa9c92186deab9861b6069c3caa264e41cc2cc/spring-cloud-stream-binders/spring-cloud-stream-binder-rabbit/src/main/java/org/springframework/cloud/stream/binder/rabbit/RabbitBindingCleaner.java#L59

This is obsolete since the rabbit-binder is moved to a different repo altogether.


Add Dark Mode Feature

Issue: Add Dark Mode Feature
Description
We need to implement a Dark Mode toggle for the application. Your task is to create a dark mode that can be switched on or off by the user. The theme should persist across sessions (store preference locally).
Steps to Contribute

Fork the Repository

Click the Fork button at the top right of this repository's page to create a copy of the repo under your GitHub account.

Clone it to Your Local Machine

Open your terminal and use the following command to clone the repo:git clone https://github.com/your-username/repo-name.git

Add Dark Mode

Implement a dark mode toggle that allows users to switch between light and dark themes.
The dark mode should affect the entire application, including backgrounds, text colors, and component styles.
Ensure that the dark mode preference is stored using localStorage so that it persists even after the page is refreshed or reopened.

Push Your Changes

After adding the dark mode feature, commit your changes using:git add .
git commit -m "Added dark mode feature"
git push origin main

Create a Pull Request

Head back to the repository on GitHub, and click on Compare & pull request. Provide a meaningful description of your changes and create the pull request.

Thank you for contributing! We're excited to see the dark mode feature in action. 🌙✨

Hi I can do this can u pls assign it to me

Yes, now you can do it.


Fixes the display name issues for tables, and tags count

Summary of Changes
WIP: Made some changes in atlasclient, waiting for them to be fixed and released before this change.
This PR involves three changes:

Fixes the table display name for Atlas Proxy.
Add support for tags count.
Fixes the setup.py requirements package synching issue.

Tests
Based on the changes above, I needed to modify the atlas proxy test cases.
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes.
[x] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[x] PR passes make test
[x] I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message"

Codecov Report

Merging #69 into master will increase coverage by 0.02%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   74.11%   74.14%   +0.02%
==========================================
  Files          19       19
  Lines         989      994       +5
  Branches       84       84
==========================================
+ Hits          733      737       +4
- Misses        234      235       +1
  Partials       22       22

Impacted Files
Coverage Δ

metadata_service/config.py
100% <ø> (ø)
:arrow_up:

metadata_service/entity/table_detail.py
100% <ø> (ø)
:arrow_up:

metadata_service/proxy/atlas_proxy.py
88.02% <93.75%> (-0.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493cb79...406ded4. Read the comment docs.

@feng-tao @jinhyukchang ready for review

@verdan  CI fails

@feng-tao yes, because the new atlasclient is not yet released. Will be fixed once that's there. Will ping you once done.

@feng-tao ready for review. We need to fork the atlasclient as the maintainer was not active enough, and we want to speed up the development on Amundsen-Atlas now.

thanks @verdan !


test(dtslint): add share

Description:
This PR adds dtslint tests for share.
Related issue (if exists): #4093

Pull Request Test Coverage Report for Build 7676

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.2%) to 96.967%

Files with Coverage Reduction
New Missed Lines
%

src/internal/observable/fromPromise.ts
1
87.5%

src/internal/observable/fromIterable.ts
2
95.24%

src/internal/observable/fromObservable.ts
2
83.33%

Totals

Change from base Build 7671:
0.2%

Covered Lines:
5786

Relevant Lines:
5967

💛  - Coveralls


Bug with i18n & Language Code pl

Test Repo: https://bitbucket.org/MunifTanjim/hugo-test
Hugo Version: v0.29
OS: Ubuntu 16.04
Site Setup
/config.toml
baseURL = "http://example.org/"
title = "Hugo Test Site"

[languages.en]
lang = "en"
[languages.fr]
lang = "fr"
[languages.pl]
lang = "pl"

/i18n/en.toml
[test]
one = "test en {{ .Count }}"
other = "test en {{ .Count }}"

/i18n/pl.toml
[test]
one = "test pl {{ .Count }}"
other = "test pl {{ .Count }}"

/layouts/index.html
<!DOCTYPE html>

  <title>{{ .Site.Title }}</title>

{{ i18n "test" 1 }}

{{ i18n "test" 2 }}

Site Output
localhost:1313/
test en 1
test en 2

localhost:1313/pl/
test pl 1
test

Description
As you can see, the plural (i.e. other part of the i18n file) translation is not being detected when the language code is pl. But it works for any other language code.
I've reproduced the same bug with Hugo v0.28 & v0.27 too. Didn't tried with older versions than those though.

It is probably a duplicate of a related issue ... somewhere. There is a fix in the works, but no-one has taken the time to "do it".

Polish's plural form has 4 categories (one, few, many and other) according to the Unicode spec, which seems referenced by go-i18n. So, pl.toml should have 4 entires like below.
[test]
one = "test pl {{ .Count }}"
few = "test pl {{ .Count }}"
many = "test pl {{ .Count }}"
other = "test pl {{ .Count }}"

Probably we can show more user-friendly message?

Okay, this is not a bug.
Perhaps this issue should be closed.


How to profile my super slow webNN implementation (sd-turbo img2img)

I am trying to make a webNN example for sd-turbo image-to-image: https://github.com/eyaler/webnn-developer-preview/blob/main/demos/sd-turbo/index.js
I used the vae encoder from: https://huggingface.co/schmuell/sd-turbo-ort-web/ without any changes to the model. I also tried other ones, but this worked for me where others did not.
I probably didn't do the latents sampling as intended, but it is working. You can try it here: https://eyaler.github.io/webnn-developer-preview/demos/sd-turbo/ you need to tick the image-to-image checkbox, and it uses a default input image I provided (sorry). My main issue is the encoder takes 100x-300x the time compared to the original flow without the encoder (40-120 sec compare to 400 ms). You can compare by unticking the image-to-image checkbox. This suggests to me that something is very wrong with the way I hooked up the model, or that I missed some basic adjustment steps. I would be grateful for any insights on potentially obvious reasons for the large discrepancy and how to approach debugging this.

@eyaler Great work and idea for image-to-image usage!
The inputs of the vae encoder you are using:
sample / name: sample
tensor: float16[batch_size,num_channels,height,width]

But your code of override is freeDimensionOverrides: { batch: 1, channels: 3, height: 512, width: 512 },
in https://github.com/eyaler/webnn-developer-preview/blob/main/demos/sd-turbo/index.js#L316
Please try freeDimensionOverrides: { batch_size: 1, num_channels: 3, height: 512, width: 512 },  at first?
https://huggingface.co/schmuell/sd-turbo-ort-web/blob/main/vae_encoder/config.json
CC @Honry

@ibelem Oh Wow! fixing the argument names makes it 100x time faster! Thanks!!
However, now that the optimization is kicking in I have saturation issues that I guess are related to float16 casting. My next steps:

While the large performance hit makes it clear that optimizations were not working - I am not sure why the free dimensions would be connected with casting issues. Maybe everything stays on the CPU? I played with graphOptimizationLevel and indeed it seems that if i don't completely fix the free dimensions - that is equivalent to disabling all graph optimizations - which surprised me. Indeed there are use cases where dimensions are not fixed. Are these cases not ready for WebNN on GPU?
I will try the instance normalization cast fix mentioned in another issue and if it works - will try to make a script, as it seems to be quite a verbose and non-trivial process to do.
I plan to open an issue on onnx-runtime to suggest that wrong arguments names in free dimensions override will raise an error or at least a warning. I never want my models to run 100x slower due to a typo or wrong name, and I could not find a warning.
Also, initial tests show that the fixed 1.19.0-dev.20240804-ee2fe87e2d onnx-runtime version of the original demo is significantly faster than both 1.19.2stable and 1.20.0-dev.20240928-1bda91fc57. Is this expected? if not I will follow up with an onnx-runtime issue

@eyaler
WebNN EP needs specify fixed integer values via freeDimensionOverrides for all the symbolic dimensions (https://onnxruntime.ai/docs/tutorials/web/env-flags-and-session-options.html#freedimensionoverrides), otherwise the optimizations will not be applied.

I plan to open an issue on onnx-runtime to suggest that wrong arguments names in free dimensions override will raise an error or at least a warning.

Please file a bug to microsoft/onnxruntime :)

Initial tests show that the fixed 1.19.0-dev.20240804-ee2fe87e2d onnx-runtime version of the original demo is significantly faster than both 1.19.2stable and 1.20.0-dev.20240928-1bda91fc57.

Please use single model to run the tests and provide detailed performance data among these ORT dists, then we can check what happened in newer ORT versions. Thanks a lot!

@ibelem Thanks!
For throwing an error on bad names and emphasizing in the docs the need to fix all dimensions, i opened https://github.com/microsoft/onnxruntime/issues/22300
My saturation issue has been solved by fixing the VAE encoder instance normalization as discussed, and i put the fixed model here: vae encoder. I made a helper script based on onnx2text here: https://github.com/eyaler/webnn-developer-preview/blob/main/demos/sd-turbo/fix_instance_norm.py - perhaps not generic enough, but may help give people the direction needed
I am actually seeing ~10x run time inconsistencies even with repeat inference with the same library version. Specifically, I see the VAE encoder or UNET getting slower after a hitting the generate button a few times in my web demo. I will investigate further.


Added few missing functionalities in NN and tensors.

Also testing the pipelines

Oh great; was going to ask if someone was working on scalar-tensor ops! Is idea to have implicit conversions to Scalar or add overloads? e.g. public static implicit operator Scalar(double value){…}

@joemoorhouse for the moment we you need to explicitly convert into scalars. For example we do
 weights.Eq(1.ToScalar()).Sum(new[] { 1L }) * (-1).ToScalar() + 0.5.ToScalar();

which is terrible! Please open an issue and feel free to fix this if you want to!

Tests pass now (thanks @artidoro). I am going to merge this.


Error: Component definition is missing display name

I'm receiving this error in Vercel, which exits the build in the Layout.tsx file on line 27:
const dynamicProps = {
  loading: () => <Loading />
};

const SignUpView = dynamic(() => import('@components/auth/SignUpView'), dynamicProps);

const ForgotPassword = dynamic(() => import('@components/auth/ForgotPassword'), dynamicProps);

const FeatureBar = dynamic(() => import('@components/common/FeatureBar'), dynamicProps);

Error: Component definition is missing display name react/display-name
It seems to be a linting error, but I've exhausted my options.
I've got the latest version of this repo, which includes NextJS 11.0.0 and Typescript 4.3.4.

I have ignored this rule for now in .eslintrc, but it seems more like a hack:
{
  "extends": "next",
  "rules": {
    "react/display-name": "off"
  }
}


Add prometheus server + use go 1.19

Based on https://github.com/crowdsecurity/go-cs-bouncer/pull/16
Fixes https://github.com/crowdsecurity/cs-firewall-bouncer/issues/166

Superseded by #199


Remove RenderingBuffer from the API

The conversation in #282 suggests that, probably, the RenderingBuffer object should be a Lomse internal object, and any application using Lomse should just pass a ptr. to the image buffer and its size. The stride value should be something computed by Lomse as it has information for doing it.
I have to study this modification. Any comments and ideas about this and about any other possible changes to improve the API for rendering scores are welcome!

I wouldn't remove the option completely to supply a stride. It allows to draw in a sub area of the bitmap.

Very good point! Thank you.
It has also given me a clue as to how to do solve #12 ! Great!


Particles fly in square shape

To calculate the speed of the particles you should use an angle and speed and not speedX and speedY because what happens now is that particles flying in diagonal have twice the speed over particles flying parallel to the axes.

Hi Boris,
feel free to contribute a proposal. Actually I'm extending the animation right now. It will add different shapes to the "fountain"...


SQLServer error when column type is "geography"

An error is thrown in the doctrine package, in AbstractPlatform if your table has a column type of "geography".  My current workaround is to temporarily edit that file and have it return "string" instead of throwing an exception.
The documentation also fails to mention how you can actually use the "paths" in the config. Here is an example, to show how Spatie Permissions and the Laravel Database Notifications can be included when generating
    'paths' => [
        'Illuminate\Notifications\\' => 'vendor\laravel\framework\src\Illuminate\Notifications',
        'Spatie\Permission\Models\\' => 'vendor\spatie\laravel-permission\src\Models'
    ],

Submitting this issue so I can find this again next time I need to generate models and need to remember how to fix it.

https://github.com/mstaack/laravel-postgis/issues/144
Just needed to add the types to config/database.php
    'dbal' => [
        'types' => [
            'geometry' => \Doctrine\DBAL\Types\StringType::class,
            'geography' => \Doctrine\DBAL\Types\StringType::class,
        ]
    ],


Document with of squish

Fixes https://github.com/perl6/doc/issues/1490
Is explanatory enough?

That's good enough. Thanks!


chore: short cut instance for non-dependent FunLike

This eliminates (fun a ↦ β) α in the type when applying a FunLike.
Not sure about the name.

Zulip

!bench

!bench

I have an idea, let me see how far I get...

Answer: not far enough. expandCoe does a headBeta on the expression, which means that this shortcut instance does work but any tricks inside the original instance's type does not. So the way to go is indeed either a change in Lean core or to have this shortcut instance.

What would the change to Lean core look like?

What would the change to Lean core look like?

I think we'd need to modify expandCoe to do more aggressive β reduction. (But I haven't tried out if that indeed works.)

Following discussion on Zulip and testing in #8185, you should delete the new instance and replace FunLike.hasCoeToFun with
instance (priority := 100) hasCoeToFun : CoeFun F (fun _ ↦ ∀ a : α, β a) where
  coe := @FunLike.coe _ _ β _ -- need to make explicit to beta reduce for non-dependent functions

this will expose the function signature to beta reduction and yield the same benefits with the duplicate instance.

@negiizhao Please let us know your thoughts on this PR. Your insight on the performance impact from the extra beta expansion, your identification of a viable fix, and the hard work in making Mathlib build are the vast majority of the work here.
Given the benefits, it would be nice to get this merged asap. 🙏

What is the difference between the files in this PR and #8185? Can we close this one in favor of #8185?

Great! 😊 Can you adjust the title and body of the PR and quickly compare to the fixes in #8185 to make sure things are as minimal as possible before merging? Thanks!
bors delegate+

!bench

I'm happy with this now, thanks! I'd like to jump into an editor once the cache is ready and fiddle with a couple proofs; please ping me if this PR is green and I haven't already done so. If I don't respond, I'm fine with it being merged in 8 hours.

bors merge


What is the difference between Infer and Infer:Eradicate

I used these two tools to scan a variety of projects. But I found that their warning types are almost the same, though the number of the type varies. Eradicate produces much more warnings than Infer for the same type, like "ERADICATE_PARAMETER_NOT_NULLABLE". Thus I am very curious about the reason behind it. I know that Eradicate makes use of @Nullable annotation, so is it because Infer does not use the annotation?

Eradicate checks that @Nullable annotations are used correctly and consistently, whereas other checkers like biabduction or pulse look for program paths where they think NULL can be dereferenced, regardless of @Nullable annotations. So, eradicate is more like a type system, whereas other analyses in infer typically do not rely on code annotations.


Typo "a Azure Databricks"→"an Azure Databricks"

https://learn.microsoft.com/en-us/azure/databricks/administration-guide/users-groups/users

#PingMSFTDocs

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4807a67b-42ba-fb6a-5cd9-d46c1a64c89a
Version Independent ID: 36df8466-f784-90d2-be17-bd6318eb5779
Content: Manage users - Azure Databricks
Content Source: databricks/administration-guide/users-groups/users.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@hyoshioka0128
Thanks for your feedback! We will investigate and update as appropriate.

@hyoshioka0128
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


#11 - Update Draftail integration

Update Draftail integration#11
Replaces the overriden initEditor with the registerPlugin as detailed in wagtail's extending draftail docs.
Notes:

Theres an issue with this approach detailed in the PR comments see.
The PR will be easier to review by commits with the main changes in 96558db which needs review, other commits are mainly around moving things around to tidy up the code a little.

This all looks good as far as the switch to the new Draftail API, but I see React errors in the console that you will have to investigate.
If it helps, I’ve been working on instructions to work with a build of Wagtail with React in dev mode for easier troubleshooting: https://gist.github.com/thibaudcolas/962bbf8f86ffe9aed5fe3e0a85257ca4

The project requires some ENVs set, which will likely be the cause of the errors


Make top-level XML parsing more robust

This PR introduces proper XML (rather than string) parsing, so any compliant .dc file will work - not just ones that happen to have whitespace in the right places. XML queries have also been made more specific, as existing .//Objects/* queries were too global and TPT screens would incorrectly match on them.

I think this PR is solid. Tested on my system at home.

@loopj this is ready to merge if you are happy with it.

Thanks @filmackay and @loopj  -- I'm just doing some diligence on the change of XPath expressions.


Synchronous Invokation

I know it goes against node's grain but is there any way to invoke the PS commands synchronously?

Hey @cawoodm ,
First of all sorry it took me a long time to answer. 💯
Second of all, what do you mean when you say synchronously?
Basically, PS invoke most of his commands synchronously:

PowerShell is a task automation and configuration management framework from Microsoft, consisting of a command-line shell and associated scripting language built on the .NET Framework. wikipedia

Let me know if you need further help ... maybe you can add an example...
GL and THx :+1:


CSS: Restrict center-alignment to nested  in "math" class

This is how the built-in Sphinx themes do it:
https://github.com/sphinx-doc/sphinx/blob/eb44c73b81ff4e603d9452018d145ff3c204f71f/sphinx/themes/basic/static/basic.css_t#L642-L644
I hope this is actually correct SASS ...
In case you are wondering, one example where the unrestricted centering of the math class has unintended consequences is here: https://nbsphinx.readthedocs.io/en/latest/code-cells.html#Math.

What is the unintended consequence in the link you provided? That the formula is left-aligned rather than centered?

@jessetan Sorry, I should have clarified that, it's not obvious ...
The example uses an extension that uses additional CSS to left-align class MathJax_Display, but that's not the point of this PR.
It's about the third output with mixed text and math. This should be left-aligned instead of centered.
And in all other Sphinx templates that I tried it was.

Math is centered everywhere in this theme. Do you feel that left aligning math is always better than centering? Or are you more bothered by the inconsistent look in your output?
Since that is caused by an extension that left aligns MathJax output, would an adjustment to that extension or some custom CSS be enough for your use?

Do you feel that left aligning math is always better than centering?

No, that's not what I'm saying. I'm just suggesting that the RTD theme should do the same as the default Sphinx themes and all 3rd party themes. Display math will still be centered, as it was intended.
I'm sorry about my example above, it's really not obvious, but you shouldn't worry too much about it. Just forget it.
The point is: The default themes and all 3rd party themes are using this CSS, so there is no reason not to do the same.
There is really no downside, so what are you worried about?

In the current state of the theme, this left-aligns the equation label instead of centering it for display math.
I suggest we prioritize #383, then see what needs to be done for this PR.

@jessetan OK, I see. This is because right now the math CSS is completely broken, and I agree that it is important to fix #383 ASAP.
Once it is fixed, my suggestion here will also work.
I've left a comment over there (https://github.com/rtfd/sphinx_rtd_theme/pull/383#pullrequestreview-182938248), probably everything can be fixed in one go.

I like the suggestion to simply include this in the work combined effort in #383


Fix for: undefined method downcase for nil:NilClass

Signed-off-by: Kapil Chouhan<EMAIL_ADDRESS>Description

Fixed NilClass error
Ensured chef-style on the code changes made

Related Issue
Fixes: #44
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

@kapilchouhan99 This plugin is going to need to be updated for the config changes in Chef 16. Check the ruby 2.7 unit tests. They're very very red and that's valid.


bug: ion-label floating not working properly it disappears

Bug Report
Ionic version:

[x] 4.4.0
Current behavior:

Label with position float disappears when get focused to ion-input
Expected behavior:

should not disappear as previous versions
Steps to reproduce:

Create a project using ionic v4.4.0

Create an ion-item with

<ion-item>
      <ion-label position="floating">
        <div class="lstn-subtitle1">
          {{ 'LBL_FULL_NAME' | translate}}
        </div>
      </ion-label>
      <ion-input clearInput formControlName="fullname">
      </ion-input>
</ion-item>

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.12.0 (C:\Users\sheri\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework               : @ionic/angular 4.4.0
   @angular-devkit/build-angular : 0.12.4
   @angular-devkit/schematics    : 7.3.6
   @angular/cli                  : 7.3.8
   @ionic/angular-toolkit        : 1.4.1

Cordova:

   cordova (Cordova CLI) : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms     : android 8.0.0
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 4.0.1, (and 11 other plugins)

System:

   NodeJS : v10.15.3 (C:\Program Files\nodejs\node.exe)
   npm    : 6.4.1
   OS     : Windows 10

Thanks for the issue. Please provide a Codepen, Plunker, etc. that I can use to reproduce this. I am not able to see it in a Codepen: https://codepen.io/brandyscarney/pen/bywKmV?editors=1010

Thanks for the issue. Please provide a Codepen, Plunker, etc. that I can use to reproduce this. I am not able to see it in a Codepen: https://codepen.io/brandyscarney/pen/bywKmV?editors=1010

I don't know why this is happening, i tried it my self in a new project and it's working gr8 with no problems
i figured out that

got it from my browser, but the weird thing that the label is disappearing !!.
i solved it for now by forcing this by
.item-has-focus.label-floating.sc-ion-label-md-h,
.item-has-placeholder .label-floating.sc-ion-label-md-h {
    color: var(--ion-color-primary-contrast);
}

Thanks for the response!  The label was updated to use the primary color on focus to match the Material Design spec. You may want to search your project for --ion-color-primary to see where you are overriding this color. The primary color is used as an accent color throughout several Ionic components and I wouldn't recommend overriding it to white as it will make a lot of defaults look off. Here is where we set them in our Angular starters: https://github.com/ionic-team/ionic-conference-app/blob/master/src/theme/variables.scss#L23
You can see changing the primary color to white here immediately makes segment look like it is missing a button: https://ionicframework.com/docs/theming/color-generator
Here's a way to change just the label color on item focus:
.item-has-focus ion-label {
  color: purple !important;
}

The reason for !important is this issue: https://github.com/ionic-team/ionic/issues/17425

yes you are right
thanks for help


Support multi-cluster Radius

Overview of feature request
The current state of Radius is that we deploy Radius to a single Kubernetes cluster and then run the applications on that same Kubernetes cluster.
This isn't the long term vision. For organizations that have have more than one cluster to manage, they should use one instance of Radius to deploy applications to multiple environments and clusters. Radius gets better when you have fewer instances (not more) because features like Application Graph should span environments.
Acceptance criteria

Radius environments can represent a Kubernetes cluster separate from the one where it's hosted.
Radius can be hosted outside of a Kubernetes cluster, using durable technologies like cloud databases and message queues.

AB#10430

/cc @willtsai - something to consider for our longer-term backlog


Support shuffle region join in biallelic genotyper

Attempted in #268 but was not performant. Closing for now.


Add suport for line chart

This PR add support to plot line chart.
Add example for line chart.

Thanks for contributing!
Line charts are available by leveraging scatter plots, can you explain how this is different? I don't want to add extra chart types if they can be done with the existing set.
It might be worth me adding a line example to the code using the scatter plot code, I would be happy to do that if this isn't merged.

As far as I understand to use Scatter instead of Line chart we need to be able to set showLine: true, but currently I don't see this property.

The scatter chart supports all the same properties as the line chart. By default, the scatter chart will override the showLine property of the line chart to false.

And in general, it could work just by setting r#type: "line", but it's not possible ofc due to private types and it makes sense. But would be nice to have wrapper for Line charts or add showLine config at least

Hi @DDtKey!
I've added a line chart to the examples, please let me know if this is not suitable for your use case/doesn't answer your question.


Managed Expressions

Changes

Implements managed expressions
Closes #574

Examples
To verify release is actually working (and not just releasing at program exit):
void setManageInstance([[maybe_unused]] WolframLibraryData libData, mbool mode, mint id) {
  std::string time = std::to_string(std::time(nullptr));
  if (mode == 0) {
    sets_.emplace(id, nullptr);
    std::system((std::string("echo \"create ") + time + "\" >> /tmp/sr").c_str());
  } else {
    sets_.erase(id);
    std::system((std::string("echo \"delete ") + time + "\" >> /tmp/sr").c_str());
  }
}

$ ./test.wls eventDeduplication && cat /tmp/sr
create<PHONE_NUMBER>
delete<PHONE_NUMBER>
create<PHONE_NUMBER>
delete<PHONE_NUMBER>
create<PHONE_NUMBER>
delete<PHONE_NUMBER>
...
create<PHONE_NUMBER>
delete<PHONE_NUMBER>
create<PHONE_NUMBER>
delete<PHONE_NUMBER>
create<PHONE_NUMBER>
delete<PHONE_NUMBER>

This change is

@daneelsan I'm not sure why but your comments aren't showing up in reviewable for me...

Should [[maybe_unused]] be removed here?
Done.

@daneelsan I'm not sure why but your comments aren't showing up in reviewable for me...

Should [[maybe_unused]] be removed here?
Done.


Avoid calling Path.getParent in TabletFile constructor

@dlmarion - Have you tried running before and after bench marks with this change using https://github.com/dtspence/accumulo-jmh-test ? I'm curious what the difference is and whether we still need to actually avoid the validation entirely or if we can bring it back if this is fast enough.
Also, even though my change in #3502 changes things to avoid the validation entirely when not needed by not loading the ReferencedTabletFile, we still need to validate in MetadataConstraints (#3505 and #3506) so any optimization would be still worthwhile.

@dlmarion - Have you tried running before and after benchmarks with this change using https://github.com/dtspence/accumulo-jmh-test ?

Not yet.

@dlmarion - Have you tried running before and after benchmarks with this change using https://github.com/dtspence/accumulo-jmh-test ?

Not yet.

Alright, I have some time and can re-run the benchmarks on this a little later tonight. I already have everything set up from when I was working on lazy loading so it will be quick and I can post the results.

Benchmark before this change running against the current 2.1 branch:
Warmup Iteration  0.015 ms/op
Iteration   1: 0.011 ms/op
Iteration   2: 0.010 ms/op
Iteration   3: 0.010 ms/op

0.011 ±(99.9%) 0.003 ms/op [Average]
(min, avg, max) = (0.010, 0.011, 0.011), stdev = 0.001
CI (99.9%): [0.007, 0.014] (assumes normal distribution)

Benchmark after this change running against the current 2.1 branch:
Warmup Iteration  0.009 ms/op
Iteration   1: 0.006 ms/op
Iteration   2: 0.006 ms/op
Iteration   3: 0.006 ms/op

0.006 ±(99.9%) 0.003 ms/op [Average]
(min, avg, max) = (0.006, 0.006, 0.006), stdev = 0.001
CI (99.9%): [0.003, 0.009] (assumes normal distribution)

No surprise that the change here is not quite as fast as not doing validation altogether as shown in #3501 and #3502 but it's still a very nice improvement. I haven't had a chance yet to actually go through the validation changes itself to verify it's correct but assuming the updated validation logic looks good we could incorporate a combination of both.
I think the following might be a good combination to do:

Make sure we validate file metadata on insertion/updates in MetadataConstraints. This is the work that is being done with #3504 and #3505. The validation done here could still be switched to using a more optimized version in the constructor (the change in this PR) to make it faster when we do need to validate and we need to eagerly load the TabletFile.
Avoid validating when we don't need to. This would mostly be the case when we have existing files already in metadata so when reading it should have been validated when it was inserted/updated (assuming we do number 1). This is the work that is part of #3502 and #3501.

Would be good to rerun the perf test on the latest version of this.

Would be good to rerun the perf test on the latest version of this.

you have any more changes? Good with this implementation?

you have any more changes? Good with this implementation?

Yeah I took a quick look and I think it looks good.

This seems ok to me but will require a lot of refactoring to merge into main. AbstractTabletFile contains the file name now so I am wondering if the FileParts class will need to get moved there. Also things were renamed but the merge won't work since TabletFile still exists but is now an interface so git won't be able to figure out the old version got renamed.
So when this is merged I can take a look at fixing main, probably through some manual fixing to make this patch work with the refactoring.
I can re-run performance tests if everyone is good with the implementation.

Benchmark update after the latest changes is below. Looks to be almost the same, maybe just slightly faster.
Warmup Iteration  0.009 ms/op
Iteration   1: 0.006 ms/op
Iteration   2: 0.005 ms/op
Iteration   3: 0.006 ms/op

0.006 ±(99.9%) 0.001 ms/op [Average]
(min, avg, max) = (0.005, 0.006, 0.006), stdev = 0.001
CI (99.9%): [0.004, 0.007] (assumes normal distribution)

There are significant conflicts because of the TabletFile refactoring done in main so I went ahead and did the work to merge 2.1 forward with this change and to rework the patch to be compatible with main here: https://github.com/apache/accumulo/pull/3510
Since there were some significant differences I did a PR to get another set of eyes on it


[Feature] - Provide a way to showcase the current page Describtion by linking

Description:
When a domain is linked with the resource it does not show a description for the current page and instead it uses a global one that is the same for each one.
Proposed Solution:
Add a specified section for each page
Alternatives:
Or add code that adds sections of the page as a description.

Here is a way to add one Manually for each page:

By using " description: " tag in the information section of each page

The default value is located under " _config.yml "

Example of Default description, is added when no specified one exists on the file.

This is using a manual each page version, which could be done with a code, though it would make sense to summaries each page instead as the introduction might not always serve it properly.


https://appr.tc not working with microsoft edge

Browsers and versions affected

Microsoft Edge 41.16299.15.0

Description
When i tried to join a room from different pc using microsoft edge, both the browser is stuck at ice candidate  connecting state. From there nothing happens anymore. I have tried with chrome & edge. Same thing happens there also.

But if i join from the same pc it works.
Steps to reproduce

Go to https://appr.tc
Create a room with microsoft edge & connect another user to the same room
Users must be in different pc

Expected results
Call should be connected
Actual results
Call is stuck at connecting state

We have had it working at one point but we do not actively maintain it. Feel free to figure out the error and submit a PR and I will review it. Currently do not have enough cycles to do this myself.

I tried video call from Google Chrome [Version 68.0.3440.84 (Official Build) (64-bit)] to Microsoft Edge [Microsoft Edge 42.17134.1.0, Microsoft EdgeHTML 17.17134] from Apprtc, I get the following error in Edge console.


SOLVED_____________chapter 7 - {"error":"Error: Material-UI: capitalize(string) expects a string argument."}

/client/core/Menu.js
In place of this code:
{/* <Button color={isActive(history, "/cart")}> */}
i inserted this other code:
<Button style={isActive(history, "/cart")}>

Thank you for sharing this improvement


Display whether fellow maintainers/owners have enabled 2FA

What's the problem this feature will solve?
Currently package owners can't determine if their fellow owners/maintainers have enabled 2FA on their accounts, which makes it difficult to maintain a certain level of security for a given package.
Describe the solution you'd like
On the list of roles for a project, display a label next to each user which indicates whether 2FA is enabled or disabled.
Additional context
Blocked on #5790, otherwise this would allow any attacker to determine the 2FA status for a given user.

We are not going to be able to finish implementing this within the scope of the OTF-funded work we're currently doing on PyPI security, so I'm removing it from this milestone.

This issue is no longer blocked.

I'm going to have a go at it. If you don't see anything in a week's time, please consider this ticket free to grab, otherwise note that someone is on it :)


🐛 Bug Report: Cleanup of deleted documents in postgres index

📜 Description
Deleted question shows up in search suggestion.
👍 Expected behavior

Question should not come up in search suggestions in Backstage

👎 Actual Behavior with Screenshots

Question comes up in search suggestions in Backstage (even after multiple days)

👟 Reproduction steps

Delete a question from Qeta plugin
Question still comes up in search suggestions in Backstage (even after multiple days)
As per Qeta plugin, its related to postgres index cleanup. issue

📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

I'll just note first that the pg documents store for the search plugin is a community maintained one. But I looked into it a bit:
Tests indicate that it indeed is expected to delete documents that no longer exist in the next run. As far as I know we haven't had any reports of this failing before at least.
But it seems that the deletion is based on hashes of the documents. Could it be that these documents actually change every single time for some reason? For example, is there an always-advancing timestamp inside it or something like that?
Pinging @backstage/discoverability-maintainers to perhaps continue on this one

Hello @gaurav517, thanks for opening the issue. And thanks for looking into it @freben.
As @freben mentioned the pg search module is community maintained so we will not be able to pick this ticket up for now. However I'll add a "help wanted" label to it as it seems to at least need some investigation based on what @freben mentions above.
@freben any chance you can clarify what you mean by "Could it be that these documents actually change every single time for some reason?"?

@freben any chance you can clarify what you mean by "Could it be that these documents actually change every single time for some reason?"?

Yeah I was wondering if it could be the case, that first an ingestion happens where the document had hash A, but the next ingestion the (from the user's point of view) same document had hash B. And then no deletion happens for A since the hash has changed for something that actually should have been considered the same document.
Maybe this doesn't apply here though 🤔 Mostly thinking out loud. Ideally A should have been deleted then, and if the original issue was that a deletion of remote data happened, then there shouldn't exist any B to replace it either. So I am probably following the wrong train of thought here.


feat: Send message to Twitch Chat on 'fork' events

Related to #12

@orestes also resolve the conflicts 😅


Newest Merge Breaks App

The branch and merge example that @breezycool used to show me the work flow seems to break the application. Upon successful login, page displays a RedBoxError with message: 'TypeError: Cannot read property 'map' of null'

Nevermind, I just realized that it only crashes when I log in with my account, which I artificially created in the parse dashboard. This is probably the source of the error. Login with all other accounts work as expected


Wrong JSON field name for Code in TokenRequest

Bug report
Describe the bug
The field Code in types.TokenRequest has a wrong name in the struct field tag.
Therefore, code exchange for grant type "pkce" does not work and returns an error:
{"code":400,"error_code":"validation_failed","msg":"invalid request: both auth code and code verifier should be non-empty"}
The name in the field tag is currently code, but ought to be auth_code instead.
To Reproduce

Initiate a PKCE flow via the /auth/v1/authorize endpoint and save the returned code verifier in a cookie

Receive callback and parse code

Create a TokenRequest with the grant type "pkce" and set Code to the parsed code and the verifier to the one saved in step 1:

Call Token and pass the TokenRequest object from step 3

You will receive the error mentioned above

Expected behavior
No error, access token should be received correctly.

Addressed by #6


HtmlParser not having unescape attribute error while downloading

[i] : Downloading subtitle(s)
[i] : Downloading (001 Course Agenda.id)
[*] : 13.46KB/13.46KB 100.00% |##############################| 10.62kB/s
[i] : Downloaded  (001 Course Agenda.id)
Traceback (most recent call last):
File "D:\Downloads\udemy-dl-1.0\udemy-dl-1.0\udemy-dl.py", line 606, in
main()
File "D:\Downloads\udemy-dl-1.0\udemy-dl-1.0\udemy-dl.py", line 576, in main
udemy_obj.course_download(
File "D:\Downloads\udemy-dl-1.0\udemy-dl-1.0\udemy-dl.py", line 361, in course_download
self.downalod_subtitles(
File "D:\Downloads\udemy-dl-1.0\udemy-dl-1.0\udemy-dl.py", line 123, in downalod_subtitles
self.convert(filename=filename, keep_vtt=keep_vtt)
File "D:\Downloads\udemy-dl-1.0\udemy-dl-1.0\udemy\vtt2srt.py", line 105, in convert
timecode = self._generate_timecode(seq, unescapeHTML(line))
File "D:\Downloads\udemy-dl-1.0\udemy-dl-1.0\udemy\utils.py", line 196, in unescapeHTML
data = clean.unescape(s)
AttributeError: 'HTMLParser' object has no attribute 'unescape'
I am using Python version 3.9. If any specific version of python is required for this like 2.7?

If it is of any help, I have the same problem.
The output is as follows
[i] : Downloading chapter : (1 of 14)
[i] : Chapter (01 Intro_ The 10 Days of React)
[i] : Found (10) lecture(s).
[i] : Lecture(s) : (1 of 10)
[i] : Downloading (001 What Problem Does React Solve_)
[*] : 136.39MB/136.39MB 100.00% |##############################| 3.99MB/s
[i] : Downloaded  (001 What Problem Does React Solve_)
[i] : Downloading asset(s)
[i] : Downloading (001 Approach-1-Reference-Code)
[i] : Downloaded  (001 Approach-1-Reference-Code)
[i] : Downloading asset(s)
[i] : Downloading (001 Approach-2-Reference-Code)
[i] : Downloaded  (001 Approach-2-Reference-Code)
[i] : Downloading subtitle(s)
[i] : Downloading (001 What Problem Does React Solve_.en)
[*] : 17.69KB/17.69KB 100.00% |##############################| 22.48kB/s
[i] : Downloaded  (001 What Problem Does React Solve_.en)
Traceback (most recent call last):
File "E:\Training\MyUdemy\Udemy-dl\udemy-dl-master\udemy-dl.py", line 611, in
main()
File "E:\Training\MyUdemy\Udemy-dl\udemy-dl-master\udemy-dl.py", line 581, in main
udemy_obj.course_download(
File "E:\Training\MyUdemy\Udemy-dl\udemy-dl-master\udemy-dl.py", line 363, in course_download
self.download_subtitles(
File "E:\Training\MyUdemy\Udemy-dl\udemy-dl-master\udemy-dl.py", line 123, in download_subtitles
self.convert(filename=filename, keep_vtt=keep_vtt)
File "E:\Training\MyUdemy\Udemy-dl\udemy-dl-master\udemy\vtt2srt.py", line 108, in convert
timecode = self._generate_timecode(seq, unescapeHTML(line))
File "E:\Training\MyUdemy\Udemy-dl\udemy-dl-master\udemy\utils.py", line 202, in unescapeHTML
data = clean.unescape(s)
AttributeError: 'HTMLParser' object has no attribute 'unescape'

@softsmith and @alokverma75 can you guys stick to python 3.8 i didn't tested with python3.9 as of yet will test once i get free time and fix for now it should work fine with python3.8.x

Hi Nasir,
Thanks a lot for the reply.
I moved to python 3.8.6. and now after installing 2 more required packages
m3ua8 and skyscraper its giving below error after login successfully using
cookie
Traceback (most recent call last):on ..
File "udemy-dl.py", line 606, in
main()
File "udemy-dl.py", line 576, in main
udemy_obj.course_download(
File "udemy-dl.py", line 283, in course_download
course = udemy.course(
File "E:\Udemy Courses\udemy-dl-1.0\udemy\udemy.py", line 40, in course
return Udemy(url, username, password, cookies, basic, skip_hls_stream,
callback)
File "E:\Udemy Courses\udemy-dl-1.0\udemy\internal.py", line 65, in
init
super(InternUdemyCourse, self).init(*args, **kwargs)
File "E:\Udemy Courses\udemy-dl-1.0\udemy\shared.py", line 300, in
init
self._fetch_course()
File "E:\Udemy Courses\udemy-dl-1.0\udemy\internal.py", line 78, in
_fetch_course
self._info = self._real_extract(self._url,
skip_hls_stream=self._skip_hls_stream)
File "E:\Udemy Courses\udemy-dl-1.0\udemy\extract.py", line 603, in
_real_extract
course_id, course_info = self._extract_course_info(url)
File "E:\Udemy Courses\udemy-dl-1.0\udemy\extract.py", line 274, in
_extract_course_info
portal_name, course_name = self._course_name(url)
TypeError: cannot unpack non-iterable NoneType object
Please share any specific Python version needed for this?
Regards
Alok
On Sun, Oct 11, 2020 at 3:11 PM Nasir Khan<EMAIL_ADDRESS>wrote:

Closed #571 https://github.com/r0oth3x49/udemy-dl/issues/571 via 4608ec3
https://github.com/r0oth3x49/udemy-dl/commit/4608ec3e29e94e74ef7146b894e97002498acd2b
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/r0oth3x49/udemy-dl/issues/571#event-3863519811, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AM7STLMSFRU2DWI65KUMRMDSKF4VFANCNFSM4SGSKUSQ
.

@alokverma75 to fix the cannot unpack non-iterable thing, you have to precede the course url with "www", it can't be "https://udemy.com/course-name", has to be "https://www.udemy.com/course-name"


wlroots 0.15.0

There are some breaking changes for the next wlroots release, and more may be added between now and when it is released. I'm going through their changes listed here and checking to see if we need to do something about them. This may need updating as they add more changes - current version is from 25th August.

Changes for packagers

backend: make DRM and libinput backends optional (#3058): the x11-backend build option has been superseded by the backends option.

Doesn't affect us.

Breaking changes for compositors
These changes can affect most compositors.

Nuke wlr_list (#3002): wlr/types/wlr_list.h has been removed. wlr_tablet.paths and wlr_tablet_pad.paths are now wl_array instead of wlr_list.

Doesn't affect us.

Stabilize wlr_box API (#3011)

wlr_box_from_pixman_box32 and wlr_box_rotated_bounds have been removed.
wlr/types/wlr_box.h has been moved to wlr/util/box.h (a redirection with a warning is still in place).
Unnecessary wlr_box.h includes have been replaced with forward declarations in public wlroots headers.

Just need to move box.py #50 and remove wlr_box_rotated_bounds #51

backend/drm: preserve mode order from kernel (#3078): the order of wlr_output.modes has been reversed for the DRM backend to match the kernel's ordering. Compositors are advised to use wlr_output_preferred_mode instead of relying on mode order.

This doesn't affect pywlroots directly but may affect any compositors that use it.

layer-shell: replace close() with destroy() (#3108): replace wlr_layer_surface_v1_close calls with wlr_layer_surface_v1_destroy and ensure the wlr_layer_surface_v1 isn't used after that call.

Needs some changes. #51

Breaking changes for custom backends and renderers
These changes are unlikely to affect compositors that don't have a custom
backend or renderer.

render/egl: make most functions private (#2985)

Doesn't affect us.

surface: make wlr_subsurface_create private (#2993)

Just need to remove the signature from ffi_build.py #51

render: drop wlr_renderer_impl.texture_from_{pixels,dmabuf} (#2997)
Remove wlr_resource_get_buffer_size (#3023)

wlr_resource_get_buffer_size has been removed.
wlr_client_buffer_import has been split into two functions: wlr_buffer_from_resource and wlr_client_buffer_create.

buffer: drop wlr_client_buffer.resource (#3039)
output: add generic wlr_output_export_dmabuf implementation (#2955): wlr_output_impl.export_dmabuf has been dropped.

None of these affect us.

render: drop wlr_renderer_impl.init_wl_display (#3062)

This needs some changes to Renderer and ffi_build.py.

Drop legacy output APIs (#3044): wlr_output_impl.{attach,rollback}_render and wlr_output_state.buffer_type have been removed.

Replace pending_buffer_type with pending_attach_render #51
Of course, we'll need to keep this up to date as they add more changes. Once 0.15 upstream is released we can cross reference this with their changelog and then release with our breaking changes from #51.

This should be good now! Release is out.


Crossplane - Onboarding beta users on the DFDS Crossplane packages

What: Enable real users to use our Crossplane setup on Hellman
Why: Collect feedback so we can make Crossplane setup is ready to be generally available for the rest of DFDS

[x] Agreement with Pirates team on the role of Piloting
[x] Identify the resources that will be part of the onboarding (AWS, Kafka topics)
[x] Idetify the outcome
[ ] Migrate existing resources to Crossplane
[ ] Training of the team
[ ] Facilitate feedback

Crossplane Resources:
AWS Cloudfront (Alpha)
AWS Route53 (Alpha)
AWS Certificate  (Beta)
AWS Bucket (Beta)
Kafka topics (https://github.com/dfds/crossplane-configuration-dfds/tree/confluent/topic-xrd/package/confluent/topic/v1)

The outcome

Make XRDs are available through dfds configuration package
Make examples of claims that provisions resources that builds the infrastructure for the CIAM according to the specification
Test the examples in sandbox environment
Train the team to use these claims
Enable the team to use these claims in the production setup by removing any obstacles
Facilitate Feedback

#507 and #508 spawned


Rule evaluation fails when two MVEL rule has same priority

Given the below fact
public class Product {
    private String division;
    private String restriction;
    public String getDivision() {
        return division;
    }
    public void setDivision(String division) {
        this.division = division;
    }
    public String getRestriction() {
        return restriction;
    }

    public void setRestriction(String restriction) {
        this.restriction = restriction;
    }
}

and the test case as
@Test
    public void shouldRestrictProductByMatchingAgainstRangeRestriction() {
        RulesEngineParameters parameters = new RulesEngineParameters()
                .priorityThreshold(Integer.MAX_VALUE)
                .skipOnFirstAppliedRule(false)
                .skipOnFirstFailedRule(false)
                .skipOnFirstNonTriggeredRule(false);
        DefaultRulesEngine rulesEngine = new DefaultRulesEngine(parameters);
        Product product = new Product();
        product.setDivision("500");
        Facts facts = new Facts();
        facts.put("product", product);
        // create rules
        org.jeasy.rules.api.Rule divisionRule1 = new MVELRule()
                .name("restricted by division")
                .description("check if division is in restricted list")
                .priority(1)
                .when("200 == product.division")
                .then("product.setRestriction('trn:sellingrestriction:uuid:range')");
        org.jeasy.rules.api.Rule divisionRule2 = new MVELRule()
                .name("restricted by division")
                .description("check if division is in restricted list")
                .priority(2)
                .when("400 == product.division")
                .then("product.setRestriction('trn:sellingrestriction:uuid:range')");
        org.jeasy.rules.api.Rule divisionRule3 = new MVELRule()
                .name("restricted by division")
                .description("check if division is in restricted list")
                .priority(1)
                .when("500 == product.division")
                .then("product.setRestriction('trn:sellingrestriction:uuid:range')");
        // create a rule set
        Rules rules = new Rules();
        rules.register(divisionRule1);
        rules.register(divisionRule2);
        rules.register(divisionRule3);
        //create a default rules engine and fire rules on known facts
        rulesEngine.fire(rules, facts);
        // it throws NPE since the rule engine does not set restriction
    Assert.assertTrue(product.getRestriction().contains("trn:sellingrestriction:uuid:range"));
    }

Note: perfectly works for division == 200 and 400, fails for division 500

Hi,
In your example, divisionRule1 and divisionRule3 have the same name, same description and same priority. They are considered equal so only divisionRule1 is registered:
[main] INFO org.jeasy.rules.core.DefaultRuleListener - Engine parameters { skipOnFirstAppliedRule = false, skipOnFirstNonTriggeredRule = false, skipOnFirstFailedRule = false, priorityThreshold =<PHONE_NUMBER> }
[main] INFO org.jeasy.rules.core.DefaultRuleListener - Registered rules:
[main] INFO org.jeasy.rules.core.DefaultRuleListener - Rule { name = 'restricted by division', description = 'check if division is in restricted list', priority = '1'}
[main] INFO org.jeasy.rules.core.DefaultRuleListener - Rule { name = 'restricted by division', description = 'check if division is in restricted list', priority = '2'}
[main] INFO org.jeasy.rules.core.DefaultRuleListener - Known facts:
[main] INFO org.jeasy.rules.core.DefaultRuleListener - Fact { product : org.jeasy.rules.mvel.Product@2ac1fdc4 }
[main] INFO org.jeasy.rules.core.DefaultRuleListener - Rules evaluation started
[main] INFO org.jeasy.rules.core.DefaultRuleListener - Rule 'restricted by division' has been evaluated to false, it has not been executed
[main] INFO org.jeasy.rules.core.DefaultRuleListener - Rule 'restricted by division' has been evaluated to false, it has not been executed

java.lang.NullPointerException
	at org.jeasy.rules.mvel.TestProduct.shouldRestrictProductByMatchingAgainstRangeRestriction(TestProduct.java:51)

As you can see, only divisionRule1 and divisionRule2 are registered. divisionRule3 is not registered and hence not applied. You test fails because product.getRestriction() is null since no rule was triggered.
Does this help?

Hi,
I ran the test by giving unique name to each rule, it started working.
So my question is here what is the equality condition of two rules , should not it be other than name?
A rule is composed of action and condition, so i strongly feel equality should be derived from action and condition combination. Please share your thought on this.

So my question is here what is the equality condition of two rules

This is a FAQ. Two rules are equal if they have the same name, description and priority. See here.

A rule is composed of action and condition, so i strongly feel equality should be derived from action and condition combination. Please share your thought on this.

If two rules have different condition and/or actions, they are different, so they should definitely have different names. My thoughts on this is that the set {name, description, priority} is enough to identify a rule.


Visualizer

Coverage decreased (-15.5%) to 73.775% when pulling ba3dbbc50a1415e48c2812c900d9da886045e52d on boothby:visualizer into 1cd406c474aba05656ee3e09302255a7c96e6d32 on dwavesystems:master.


Added memory implementations of file sources and added tests for tree ordering

Pretty much decoupled source files from their implementation and implemented memory variants of ISourceProvider and ISourceFile. This makes it possible to test more parts of the codebase.

Does the in-memory implementation serve a purpose other than for unit tests? If not, can we move it to a separate assembly?

Currently they serve no other purpose. We could move it to the test assembly in a separate namespace.


Handle pke bootstrap errors in cluster creation

If the PKE bootstrap ends with error (as per the exit code sent to the new api endpoint from #3174), terminate the cluster creation and set ERROR state (all cloud providers).
May use the same signal that's sent when the first master calls back to /ready with the config.

May use the same signal that's sent when the first master calls back to /ready with the config.

What does that mean? You don't need to use the same signal, you can have a separate signal or just send a cancellation request to the workflow. But that's an implementation detail.


Update for libsemigroups 0.3.2

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Travis has been waiting to run the build for about 24 hours, anyone have any idea what's up?

@isuruf any suggestions?

@james-d-mitchell, there was an error with the anaconda token which has now been fixed. You'll have to restart the following builds though,
https://travis-ci.org/conda-forge/libsemigroups-feedstock/builds/268133579
https://circleci.com/gh/conda-forge/libsemigroups-feedstock/9

Thanks @isuruf! I merged it already, since at some point the build was showing as "pass all checks".


When a Folder is Grouped by File Type, the File Type Headings Do Not Always Update

Description
When a Folder is Grouped by File Type, the File Type Headings Do Not Always Update.
E.g. instead of Microsoft PowerPoint Presentation it sometimes says ``pptx File`.
If you have 2 panes open, in one it may say Microsoft PowerPoint Presentation and the other pane it might say ``pptx File`.
Steps To Reproduce
Keep opening folders with many file types.
Sometimes it fails to identify the descriptive time type.
Requirements
Be consistent. Use descriptive name.
Files Version
<IP_ADDRESS>
Windows Version
10.0.22621.2134
Log File
debug.log

Thanks for the report, I've added this to the project board.

Thank you for your feedback, we're going to continue tracking this in #14433.


Linter - add error on leaf package when importing missing deps

For now, whenever we import a package inside a package that is NOT set as a depency, we have no error/warning at all.
The consequence of that is we can forget a dependency, and when a consumer installs a package, it is missing a dep and triggers an error.
We should probably create a lint rule to detect imports that are missing in deps.

Is this about about adding a warn/error on importing module that had not been previously declared in leaf package.json dependency?

Julien took a look and was blocked.
Other people can take a look.


[Bug] I don't know if it is really a bug, but there's no more the opction with Region, Co-op support, etc

Checklist

[X] I will only use English in my report.
[X] I have used the search function for open and closed issues to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

Questions

[X] xCloud officially supports my country/region.
[X] The bug doesn't happen when I disable Better xCloud script.
[X] The bug didn't happen in previous Better xCloud version (name which one).

Device
Desktop
Device
Chrome
Operating System
Windows 10
Android app/Browser Version
Crhome 27.0.6533.120
Better xCloud Version
5.5.6
Game list
Inicial Page
Reproduction Steps
I oppened xCloud site onde day before this bug comes, and now i can't have access to other options, i didn't changed anything envolving the scrip, and tried to reinstall it.
Screenshot/video

Those settings are only available when you're logged in

i was alredly logged in


React Native ignores aspectRatio on Video elements

Description
Please have a look at this snack:
https://snack.expo.io/@yolpsoftware/groaning-nachos
Please open the snack in a separate window (link to the right of the “Web” tab in the right sidebar).
When you resize the window a bit, you’ll notice some strange behavior:

Even though both the <Video> and their direct parents have width: 100% and aspectRatio: 1.333, the height of the <Video> elements always stays the same. The aspectRatio prop is not respected:

(might be an error in Snack) When the window is big enough for the two videos to fit in, their parents get a height of 0, so they are rendered on top of each other. As soon as you make the window smaller, this behavior disappears.

Why is that so?
React Native version:
React Native 0.63
Expo SDK Version: 39
Platforms(Android/iOS/web/all): web / iOS (Android not tested)
Steps To Reproduce
https://snack.expo.io/@yolpsoftware/groaning-nachos
Expected Results
I want the video elements to fill the width of their parent, but their height should be set according to the aspectRatio prop.
Snack, code example, screenshot, or link to a repository:
https://snack.expo.io/@yolpsoftware/groaning-nachos

com

com

com?

Sorry, RN doesn't have Video component. Please file an issue to Expo.

Sorry, RN doesn't have Video component. Please file an issue to Expo.


PixiGraphics (Rectangle, Circle,...) cannot inherit to their children

Today I tested (learned) the functionality of the react hooks (like your position update) and the pass parameters using props. And I found something unexpected.
If I nest a htmlContainer or a rectangle into a sprite like in your example in https://mcastiello.github.io/pixi-reactive/#/index/components/pixihtmlcontainer/ :
  const [trackSize, setTrackSize] = useState(0);
  const setSpritePosition = useCallback((position) => (position + 4) % trackSize, [trackSize]);
  const [position, update] = useReducer(setSpritePosition, 0);

  return (
            <PixiSprite texture={'ship'} x={position} y={props.y} alignY={0.5} >
                <PixiHtmlContainer >
                    <Balloon >{'Spaceship #1'}</Balloon>
                </PixiHtmlContainer>
            </PixiSprite>
)

everything works as expected.
If I nest a sprite into a rectangle,
      <PixiGraphics>
        <Rectangle x={position} y={20} width={200} height={200} borderRadius={10}>
          <PixiSprite texture={'ship'} x={300} y={0} alignY={0.5} >
            <FillStyle color={0x444444} alpha={0.75} />
          </PixiSprite>
      </PixiGraphics>

the only thing that updated by the props and the position-hook is the rectangle by itself. The PixiSprite and all his childrens stay untouched.
So I nest a htmlElement into a rectangle... and fascinating things happened.
      <PixiGraphics>
        <Rectangle x={position} y={props.y} width={200} height={300} borderRadius={10}>
        <PixiHtmlContainer >
            <Balloon >{'Spaceship #1'}</Balloon>
          </PixiHtmlContainer>
          <PixiSprite texture={'ship'} x={300} y={0} alignY={0.5} >
            <FillStyle color={0x444444} alpha={0.75} />
          </PixiSprite>
        </Rectangle>
      </PixiGraphics>

the htmlContainer walks in the inverted direction of the rectangle, we can see that something is processed by the hooks. The props affected only the rectangle. And if I delete the Sprite in this construction, the other two elements will be erased. But if the Rectangle stays alone all works fine.
I tried that also with the Circle and the same effects happened. Probably all PixiGraphics are affected.

That is because rectangles and any other shape or style are not display objects, they are logical objects that can only make sense within the PixiGraphics element.
You should not add display objects as children of a shape. You can add them as children of the PixiGraphic element if you want

This may be. Either way, something is wrong with the update events.
Because pixi-reactive doesn't work in codesandbox, i implement a little example you can clone from https://github.com/Sylraka/pixi-reactive-examples . You can try it yourself.
The boardGlobal set the props for primitive-card one and two. The first time the scene rendered the props will transfer correctly. But if the props are changed in runtime, the rerendering will not triggered from the onUpdate lifecycle.
Furthermore the onClick-methods from the primitive cards are not triggering by clicking and I have no idea why. Instead of this they trigger by the first render of the site. The only working onClick-method is from boardGlobal, maybe because it has his own PixiCanvas?
Can you do something about it?

The click is not triggering because you are calling the function instead of passing a callback reference.
Try this:
      <PixiSprite texture={'ship'} alignY={0.5} alignX={0.5}
                cursor={CursorType.Help}
                buttonMode={true} interactive={true} onClick={() => printProps(this.props.cardProps)} />

I think it is also worth noting that this is not how react works.
const clicktest = () => {
    console.log("cardProps 1 and 2 changed!");
    cardProps1.text = 'neuer text';
    cardProps1.x = 0;

    cardProps2.text = 'neuer text';
    cardProps2.x = 0;
}

You are updating the content of an object, but you are passing the object by reference to the props. This means that React do not see any changes in the reference, hence it does not update the element.
You may want to use a reducer function instead of an external callback, and be mindful of generating a new object instead of modifying the previous state.
I hope this helps.

To pass a callback reference works for the PixiSprite-element, here it works yet :)
Sorry, now I see that the problem "call a function with values" is a typical react-beginner-problem.
But not all Elements accept that onClick-method. The PixiGraphics-element still won't trigger as well as the PixiContainer-element. According to your documentation they should be able to do that.
And as for the props: what do you suggest for their update lifecycle? How do I recognize that I pass the props by reference? is there a way to pass them by value? Or is there another way to tell React that the props have changed?

When it comes to the PixiContainer, that is something you need to ask the Pixi devs, I can't remember now, but you may need to define a hit area to make it clickable. The PixiGraphics is basically the same of a Sprite, so there's no reason why it should not trigger a click. Make sure you made it interactive and set buttonMode to true.
About React, you may want to have a look at the useReducer hook: https://reactjs.org/docs/hooks-reference.html#usereducer

I updated the example in https://github.com/Sylraka/pixi-reactive-examples .
Like you say the update lifecycles are working fine with an integrated hook.
The PixiGraphics element is clickable after setting interactive and buttonMode (shame on me), only the CursorType is not displayed correctly.
The PixiContainer isn't clickable with hitArea either. I think the hitArea don't create any clickable area. If I add some area to the working Pixi-Sprite (see primitive-card1), it lost his clickability.

The prop to set the cursor type is cursor not CursorType


Allow other preemption signals than SIGUSR1

🚀 Feature

Automatically save a checkpoint when receiving a SIGTERM, or at least don't overwrite existing handlers for it.
Motivation
When running on a SLURM cluster, Lightning automatically saves a checkpoint when receiving a SIGUSR1. This is cool; however, it ignores SIGTERM and overrides any pre-existing handler. I'm running on a SLURM cluster where my jobs may be pre-empted after receiving SIGTERM, so I would like to save a checkpoint on receiving this signal as well.

Pitch
Allow the user to specify on which signal Lightning should autosave a checkpoint, e.g. via
trainer = Trainer(autosave_on=signal.SIGTERM) # default: signal.SIGUSR1

Alternatives

Change nothing. Signal handlers can still be overwritten during training/validation/test step, but this is awkward and not the right place to do it.
Remove the SIGTERM handler or allow it to be customized, e.g. for forwarding it to SIGUSR1.

I also would like to see this feature. I'm using AWS SageMaker, and there is also SIGTERM sent when stopping a Training Job. Since I use MLflow for logging checkpoints I upload artifacts inside a custom on_train_end implementation.


documentSelector from server capability have lower priority

https://github.com/Microsoft/vscode-languageserver-node/blob/e3b566dc9e6ae60fa3d6641c3bb480634e4a0ad8/client/src/common/features.ts#L539
let options: RO & { documentSelector: DocumentSelector } = (Is.boolean(capability) && capability === true ? { documentSelector } : Object.assign({}, capability, { documentSelector })) as any;

It works as expected when documentSelector of capability is null, but overrides the documentSelector when it is a valid value.
Seems documentSelector from capability should have higher priority when it's not null or undefined, otherwise there's no need for it.

There's another bug at the same function.
export declare type NotebookDocumentSyncRegistrationOptions = NotebookDocumentSyncOptions & StaticRegistrationOptions;

NotebookDocumentSyncRegistrationOptions is not TextDocumentRegistrationOptions but it has id which is not used according to code
} else if (TextDocumentRegistrationOptions.is(capability)) {
  const id = StaticRegistrationOptions.hasId(capability) ? capability.id : UUID.generateUuid();
  const selector = capability.documentSelector || documentSelector;
  if (selector) {
    return [id, Object.assign({}, capability, { documentSelector: selector })];
  }
} else if (Is.boolean(capability) && capability === true || WorkDoneProgressOptions.is(capability)) {
  if (!documentSelector) {
    return [undefined, undefined];
  }
  let options: RO & { documentSelector: DocumentSelector } = (Is.boolean(capability) && capability === true ? { documentSelector } : Object.assign({}, capability, { documentSelector })) as any;
  return [UUID.generateUuid(), options];
}

Good catch. Moving to LSP Node repository.


Investigate internal Parquet file partitioning options

The EPA CEMS data is "only" a few GB when compressed and stored on disk as Parquet, and could easily be stored in a single file, if there were other ways to partition the data for efficient reading of selected states or years internally.   PyArrow clearly has a lot of dataset partitioning options, but I'm not sure which if any of them other than "hive" style partitioning can be used seamlessly with Pandas. See also #924
Based on the Parquet Intake catalogs that Carbon Plan has published, it seems like Intake expects files named by partition, rather than the directory partitioning that's built in to the pd.to_parquet() method and PyArrow. (e.g. epacems-2019.pq). Can we still have fast access to individual year/state combinations if the data is aggregated into larger chunks? It seems like this is supposed to be possible, with the different columns and row-groups individually addressable within the Parquet format. But I'm not sure I understand how to ensure that row groups correspond to state/year combinations, or whether the performance difference is even worth the trouble.
To be able to split the data processing up into a bunch of independent tasks, it seems like we do still need to be writing to different files, but if the performance of a single large file is good enough, maybe what we do is write out to separate annual files (each of which is like 200MB) and then concatenate them all into a single Parquet file at the end for distribution / use. That way we wouldn't need to worry about the directory based partitioning.

[x] Figure out how to read from our hive partitioned data, and concatenate a bunch of those partitions into a single output Parquet file.
[x] Concatenate CEMS Parquet files into a single file and test access speed.
[x] Concatenate CEMS Parquet files into annual files and test access speed.

Okay, re-writing the EPA CEMS hourly dataset using pyarrow.parquet.ParquetWriter to append individual state-year row groups like this:
def epacems_one_file(
    years: List[int],
    input_dir: str,
    outfile: str,
    states: List[str] = pudl.metadata.enums.EPACEMS_STATES,
) -> None:
    schema = pa.parquet.read_table(
        source=input_dir,
        filters=year_state_filter(years=[2020], states=["ID"])
    ).schema

    pqwriter = pa.parquet.ParquetWriter(
        where=outfile, schema=schema, compression="snappy", version="2.6",
    )

    for year in years:
        for state in states:
            table = pa.parquet.read_table(
                source=input_dir, filters=year_state_filter(years=[year], states=[state]),
            )
            pqwriter.write_table(table)
            del table

    if pqwriter:
        pqwriter.close()

Allows the data to be read out quickly using DNF filters just like with the Hive partitioned data, but it lets you put the data in whatever arrangement of files in a directory that you want, including a single big file as above.
epacems_dir = pudl_settings["parquet_dir"] + "/epacems"

emissions_categories =  {
    "so2_mass_measurement_code": pd.CategoricalDtype(),
    "co2_mass_measurement_code": pd.CategoricalDtype(),
    "nox_mass_measurement_code": pd.CategoricalDtype(),
    "nox_rate_measurement_code": pd.CategoricalDtype(),
}

epacems_one_file(
    years=range(1995,2021),
    input_dir=epacems_dir,
    outfile="test-epacems-monolithic.pq",
)
epacems_monolithic_df = pd.read_parquet(
    "test-epacems-monolithic.pq",
    engine="pyarrow",
    filters=year_state_filter(years=[2019, 2020], states=["CO", "TX", "ID"]),
    use_nullable_dtypes=True,
).astype(emissions_categories)
epacems_monolithic_df.info(show_counts=True, memory_usage="deep")

It takes the same amount of time to read the data out of one big file as a bunch of little ones, so it seems like performance isn't a consideration, except insofar as we need to make sure each state-year row group is written individually.
However, if we're distributing the EPA CEMS processing task across multiple threads / CPUs / nodes, they can't all be writing into the same big Parquet file. So it might make sense to break up the work into (say) annual chunks each of which takes a couple of minutes, and then once they're done, combine all of those files into a single Parquet file for simple distribution. But it could also be 26 yearly files, or 1274 state-year files if that's better for some reason in the context of the Intake catalogs (e.g. if it wants to local caching per-file, then it would make sense to break the data down into state-year chunks so that those smaller chunks can be downloaded by users more conveniently in the background, and we don't have to pay more data egress fees than necessary).
There's something I don't understand going on with the schema. For some reason the emissions mass/rate codes are coming out as strings rather than categories, which doubles the size of the dataframes, and doesn't match the schema they should have been written with. There's also some difference between the Resource.to_pyarrow() schema, and the schema as it's read off of the disk above, maybe due to the hive partitioning? Or the fact that it's got pandas metadata embedded in it? Will have to investigate more, but that's not this issue.

I think we know enough about how these partitions / row groups work to close this issue now and move on to #1495.


Discussion: Extensibility - Who wants to extend LibMan?

Would you like to extend LibMan for your own purposes?
If so, what are your needs?
Do you want to create a new provider for serving library files?
If so:

Which provider/s are you looking to create?
What kind of properties would your provider need?

More generally, what are you looking for in an extensibility model?

In my case, I am interested in the ability to add git repository as a provider.

I echo what @xzegga suggested about a git repo provider.  However, there is a work-around for this via jsdelivr.  See https://www.jsdelivr.com/features#gh
For example, WET-BOEW is not available on any provider:
{
  "version": "1.0",
  "defaultProvider": "jsdelivr",
  "libraries": [
    {
      "library"<EMAIL_ADDRESS>      "destination": "wwwroot/lib/wet-boew/dist/themes-gc-intranet"
    },
    {
      "library"<EMAIL_ADDRESS>      "destination": "wwwroot/lib/wet-boew/dist/wet-boew/"
    }
  ]
}

I think the same format, but replacing "jsdelivr" with "github", could be the way to go.

How can wet-boew not be available on any provider?  How do they expect us to use it, then?


Overscroll on mobile

You seem to be able to scroll down additional white space on mobile. Note: this may be an iOS12 only bug so verify on an older phone

Seems to be related to the MobileNav component inside PageHeaderBar


Update templates to include google's maven repository

Going forward, Android support libraries are published on maven (instead of bundling them with the SDK). Many plugins depend on these. To avoid requiring plugin users to add the maven repository to their app this change adds the repository to the template for flutter create.
This also bumps the support-annotations dependency to 25.4.0 (which also requires the new maven repository).

See https://github.com/flutter/plugins/pull/141.

Update the examples as well? (Could be a separate patch.)

@skybrian will sent out a separate patch.


Load balancer status dissapears after upgrading kubeware

If I upgrade a kubeware using a rolling-upgrade with service replace strategy, the status of the load balancer associated to the service dissapears in K8s.
This happens when we try to preserve the current nodePort for the service port exposed. If we don't specify the current nodePort then K8s will change it for a new random one and the load balancer will stop working since it'll be using the old one, so either we preserve it or somehow update the LB config.

Maybe this nodePort preserving issue has been fixed? Have a look at the following links before working on this issue:
this commit
PR 24180
Issue 23551


MECS-Publishers listed as predatory publishers - False Positive?

Hi,
I sent this email to<EMAIL_ADDRESS>
I noticed that MECS-Press is listed as one of the possibly predatory publishers here:

https://predatoryjournals.com/publishers/

Can you please reach them and provide facts/information so that they remove your name from their list?

This link might be helpful for providing them the information they are looking for:
http://thinkchecksubmit.org/check/

This was their response:
https://predatoryjournals.com/publishers/, this website was only founded in 24 January 2017, this is a joke for our publisher, which has existed for more 9 years!

MECS Journals are free charge publishing for any authors in the world, you can find these information in our website, and you can ask any authors from published papers.

So, thanks for your information again, and if possible, please help to inform this website to remove our publisher name from the list soon.

In any case, thanks for your information and help.

I should mention that I have, and my colleagues have published in their journals for free. No price was paid at any time from submission to publication. They also provided relevant review comments before publication.
And if it is not obvious already, I am by no means affiliated/related with MECS publishers.

I just came across a paper published by MECS and as I was reading I realized it was poorly written. There were typos and some sentences made no sense. That's why I decided to check whether it was published by a predatory publisher and how I got here. The quality of the text was bad enough to get me wondering so that might mean something but can anybody confirm MECS is a good-quality publisher? I just don't want to go around citing papers that have not been peer-reviewed.