Update version 3.4.1

Description
Update version 3.4.1

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@Prerit12 please review PR again, uodated the docs

@hitesh-kumar-mahour please review the PR


When attempting to install, dependency "pygeos" gives: module 'configparser' has no attribute 'SafeConfigParser'

Description
When attempting to install squidpy, I got the error:
AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean 'RawConfigParser'?
This appears to be an issue with pygeos's versioneer file, but that project appears to be deprecated in favor of shapely. Attempting to install pygeos on its own produces the same error while shapely installs without issue.
Minimal reproducible example
In Windows command prompt, with administrator permissions:
py -m pip install squidpy
Traceback

...
 Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [35 lines of output]
      <string>:8: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
      C:\Users\gegua\AppData\Local\Temp\pip-install-7gveaeps\pygeos_509fb143a42f4536b77e25e06ae78187\versioneer.py:421: SyntaxWarning: invalid escape sequence '\s'
        LONG_VERSION_PY['git'] = '''
      Could not find geos-config executable. Either append the path to geos-config to PATH or manually provide the include_dirs, library_dirs, libraries and other link args for compiling against a GEOS version >=3.5.
      Compiling pygeos/_geometry.pyx because it changed.
      Compiling pygeos/_geos.pyx because it changed.
      [1/2] Cythonizing pygeos/_geometry.pyx
      [2/2] Cythonizing pygeos/_geos.pyx
      Traceback (most recent call last):
        File "C:\Users\gegua\AppData\Local\Programs\Python\Python312\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 353, in <module>
          main()
        File "C:\Users\gegua\AppData\Local\Programs\Python\Python312\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\gegua\AppData\Local\Programs\Python\Python312\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\gegua\AppData\Local\Temp\pip-build-env-svo8upi_\overlay\Lib\site-packages\setuptools\build_meta.py", line 325, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\gegua\AppData\Local\Temp\pip-build-env-svo8upi_\overlay\Lib\site-packages\setuptools\build_meta.py", line 295, in _get_build_requires
          self.run_setup()
        File "C:\Users\gegua\AppData\Local\Temp\pip-build-env-svo8upi_\overlay\Lib\site-packages\setuptools\build_meta.py", line 311, in run_setup
          exec(code, locals())
        File "<string>", line 214, in <module>
        File "C:\Users\gegua\AppData\Local\Temp\pip-install-7gveaeps\pygeos_509fb143a42f4536b77e25e06ae78187\versioneer.py", line 1480, in get_version
          return get_versions()["version"]
                 ^^^^^^^^^^^^^^
        File "C:\Users\gegua\AppData\Local\Temp\pip-install-7gveaeps\pygeos_509fb143a42f4536b77e25e06ae78187\versioneer.py", line 1412, in get_versions
          cfg = get_config_from_root(root)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\gegua\AppData\Local\Temp\pip-install-7gveaeps\pygeos_509fb143a42f4536b77e25e06ae78187\versioneer.py", line 342, in get_config_from_root
          parser = configparser.SafeConfigParser()
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

hi @azguan yes this is a known issue ith python 3.12 we will fix it soon but don't have an estimate now, easier it is to not use python3.12 with squidpy


[#1996] Fix *CountriesFilter override countries

AllCountriesFilter and AllCountriesMultipleFilter use COUNTRIES_OVERRIDE
to substitute custom countries used to narrow the total list of
countries.
For example: ['W3']
will be replaced with: [('W3', 'Online')]
since this value is set in the settings.py.

Merging since I want to release this today.


Created FloydWarshall.java

They are not considering dsa,cp,algorithm repository :(
all the pr will not be considered in hacktoberfest but your contribution will be for lifetime, this will help many students to practice dsa .
Thank you for your contribution :)
you can contribute to other repo

Ah, That's Okay!
Glad to contribute.


ESA_2095 layout changes

Chatter post function not enabled on provider accounts, adding action so users can post updates manually to a provider account.
Also on the drug cards so that teams can be tagged when a drug record needs an update.
Quality of life layout change, small config.

@MeganWeston  tagging for approval process, ticket for review: https://hlth.atlassian.net/browse/ESA-2095

approved


⚠ GitHub has degraded performance

In 44d69ab, GitHub (https://www.githubstatus.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 193 ms

Resolved: GitHub performance has improved in eede334.


Assertion failure at lib/Runtime/Language/CacheOperators.inl:367

The debug build of ChakraCore crashes with assertion failure.
PoC:
(function () {
    function func_0() {
    }
    func_0.prototype = {
        foo() {
            super.a = '';
        }
    };
    var var_0 = new func_0();
    Object.defineProperty(var_0, 'a', {});
    var_0.foo();
}());

Commit: e055dbb
Build Option: None
OS: Ubuntu 18.04.1 LTS
Arch: x86_64

Thanks @leeswimming for reporting the issue.
I can confirm the assert is reproing.
This happens when we try to set property to the super.


Added HTTPD reverse proxy

Created a frontend reverse proxy for Jenkins and Nexus
New URLs:
Jenkins: http://<host>/jenkins
Nexus: http://<host>/nexus

I am continuing to expose the backend services for now so they can still be reached by existing applications for the time being

@sabre1041 how do I test this?

@etsauer There is no automated provision of cloud instances. You can use the following instructions:

Create new instance in OpenStack. (small with ose-base and CICD security group)
Create 10GB volume and attach to instance at /dev/vdb
Pull code code and run provisiong/cicd-install

Verification:
Jenkins will be available at http://<server>/jenkins
Nexus will be available at http://<server>/nexus

@sabre1041 i would switch out the apache index page with links to /jenkins and /nexus

@etsauer added a default index file to provide links to Jenkins and Nexus services

Ok, looks good.


fix: rstudio logo format for non-chrome browsers

This PR fixes a strange issue with the display of the RStudio logo for Kubeflow Notebooks on non-chrome browsers.

This looks good!


Build: rename "infrakit" target to "binaries"

This also makes 2 changes to docs:

remove the -k option to make, as i think we should generally fail-fast on binary builds
use the binaries target to allow users to avoid running tests

Current coverage is 74.21% (diff: 100%)

Merging #211 into master will increase coverage by 0.09%

@@             master       #211   diff @@
==========================================
  Files            16         16
  Lines          1109       1109
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            822        823     +1
+ Misses          208        207     -1
  Partials         79         79

Powered by Codecov. Last update eb00b11...fb04039


Added details of new hackerone programs

Adding new H1 programs OpenMage, Cirrus Insight, Panther Labs.
Please let me know if any changes are needed.

Thank you @nikhilgeo for adding new programs to the list.

Thank you @nikhilgeo for adding new programs to the list.


STM32 L562 Nucleo - TF-M sample hardfault

Hello everyone,
I'm trying to run a TF-M example on the STM32 L562 Discovery Kit. I followed the example steps provided on the board’s page (https://docs.zephyrproject.org/latest/boards/st/stm32l562e_dk/doc/index.html).
However, when I run the example, I keep getting a Hard Fault error. When I connected to the debug tool to understand the cause of the Hard Fault, I noticed that the program counter (PC) was stuck at 0x0c000c28. When I checked this address in memory, I found it was empty.
What steps could I take to diagnose or resolve this issue?
To Reproduce

west build -b stm32l562e_dk/stm32l562xx/ns samples/tfm_integration/tfm_ipc/
./build/tfm/api_ns/regression.sh
west flash

Expected behavior
he expected output for TF-M IPC is provided at the very bottom of the example documentation.
https://docs.zephyrproject.org/latest/samples/tfm_integration/tfm_ipc/README.html
Logs and console output

Environment (please complete the following information):
Ubuntu 24.04
Zephyr SDK 0.17.0
Commit: e90c58a

Same as https://github.com/zephyrproject-rtos/zephyr/issues/77847. I propose to close this one and focus on the oldest one.

Marking closed due to duplicate.


Native menus on Linux

Why there is still no native menus on linux?

Duplicate of https://github.com/adobe/brackets/issues/7236
Brackets-Electron has native menus on Linux: https://github.com/zaggino/brackets-electron/releases

I will try it out, thank you.


[Annotations] charLimit === 0 means unlimited (bug 1782564)

Changing the charLimit in JS had no impact, so this patch aims to fix
that and add an integration test for it.

/botio test

/botio test


Example of usage with parm $alFileStructure in function Copy-AlSourceFiles

Could you please provide an example of how to use the parameter $alFileStructure in function Copy-AlSourceFiles
I cant find any documentation about it.
Thanks

Will be in a blog post within the next week or so, but basically it is a function, which determines the placement of files.
Below is a sample, which will place files in 3 outer folders (My, Modified and BaseApp) and then after types underneath.
$myModifiedObjects = @("page21","table18")
$alFileStructure = { Param ([string] $type, [int] $id, [string] $name)

    if ($myModifiedObjects.Contains("$type$id")) {
        $folder = "Modified"
    }
    elseif (($id -ge 50000 -and $id -le 99999) -or ($id -gt<PHONE_NUMBER>)) {
        $folder = "My"
    }
    else {
        $folder = "BaseApp"
    }

    switch ($type) {
        "page"     { "$folder\Pages\$($name).$($type).al" }
        "table"    { "$folder\Tables\$($name).$($type).al" }
        "codeunit" { "$folder\Codeunits\$($name).$($type).al" }
        "query"    { "$folder\Queries\$($name).$($type).al" }
        "report"   { "$folder\Reports\$($name).$($type).al" }
        "xmlport"  { "$folder\XmlPorts\$($name).$($type).al" }
        "profile"  { "$folder\Profiles\$($name).$($type).al" }
        "dotnet"   { "$folder\$($name).al" }
        ".rdlc"    { "$folder\Layouts\$($name).rdlc" }
        ".docx"    { "$folder\Layouts\$($name).docx" }
        ".xlf"     { "$folder\$($name).xlf" }
        default { throw "Unknown type '$type'" }
    }
}

cool. Thanks


Q&A : Best configuration between GitLab and GitHub

I was asking myself a question about difference between configuration file in GitHub and GitLab.
On this project secrets on Gitlab, the configuration file used for detecting secrets is differents from the default
gitleaks.toml on GitHub. Why ? Some rules concerning the same secret have different regex, for example
SendinBlue API token :
In gitLab repo :
[[rules]]
id = "Sendinblue API token"
description = "Sendinblue API token"
regex ='''xkeysib-[a-f0-9]{64}\-(?i)[a-z0-9]{16}'''

In Github
[[rules]]
description ="Sendinblue API token"
id ="sendinblue-api-token"
regex ='''(?i)\b(xkeysib-[a-f0-9]{64}\-(?i)[a-z0-9]{16})(?:['|\"|\n|\r|\s|\x60]|$)'''
secretGroup =1
keywords = [
"xkeysib-",
]

Thanks in advance for your help !

@GridexX
Github rules are better. Gitlab rules lag behind a bit as the review process is more time consuming.
The major differences between the rules are the inclusive of keywords in the github configuration which provide a major performance improvement, and a more restrictive regex to reduce false positives.


BGP route not withdrawn for svc with externalTrafficPolicy=Cluster and empty endpoint list

Is this a bug report or a feature request?:
bug report
What happened:
A service of type loadBalancer, announced via BGP, lost all its pod because their health checks failed. The endpoint list was empty because of that, but metallb kept announcing the IP address.
For externalTrafficPolicy=Local, the announcement was withdrawn.
What you expected to happen:
With no healthy endpoints, the announcement should be withdrawn. For us, this is required in the context of a failover to another datacenter where the service is still healthy.
How to reproduce it (as minimally and precisely as possible):
Single-Pod deployment (e.g. nginx) with a service of type LoadBalancer and externalTrafficPolicy=Cluster
When scaling the deployment down to 0, the announcement stays up, but shouldn't.
Anything else we need to know?:
As mentioned the withdrawal of the announcement when the cluster does not contain a healthy endpoint anymore is essential for a redundancy failover to another datacenter.
Environment:

MetalLB version: 0.6.2 and 0.7.3
Kubernetes version: 1.11.2
BGP router type/version: Cisco 9k
OS (e.g. from /etc/os-release): ContainerLinux 1855.4.0
Kernel (e.g. uname -a): 4.14.67-coreos

This is kinda working as designed, because I didn't expect this use case. Your fix sounds great though.


markdown table support?

For Feature Requests
bookstack can support table with '|--|--|' style?
For Bug Reports

BookStack Version:0.15.2
PHP Version:7.0.12
MySQL Version:5.6

Yes, bookstack already support table, example:

key
value

a
1

The coluns able to align text.
In the example above, the text will be centralized.
If you want to align to left, use: |:-| and right: |-:|
Simple like that!


add description to featured event

pull plaintext from google calendar event. ignore [#] and {#} tags used for links and images.

place underneath meta


Error of sims needing target, but the advanced option button to add targets cannot be found in usual spot

Was messing with phase 4 sims for ret paladin, set up an undead cleave sim with 4 targets, all set at patchwerk, the sim ran fine, i went to change it back to mess with different scenarios, and could not remove the added targets, the when i refreshed the page, i could not run the sim with a popup error of "Error: Encounter has no targets! Try adding some targets first.", went to add targets back, and the green advanced options button is no longer there to edit the fight scenarios, and none of the pre built options seem to have targets either

You can fix this with Restore Defaults (from the top right coghweel button).
Its an error with removing targets where they look like you're not removing them (haven't looked into why) and you end up removing them all and then it bugs the UI with 0 targets.


"distinctUntilChanged", "retry" and "timeoutWith" docs are not rendered properly

[ ] The distinctUntilChanged operator docs is not being rendered properly. Please check the image:

The operator implementation, however, contains the documentation, but for some reason, it is spread across multiple overloaded functions, so this might be causing the problems.
Proposed fix in #6756.

[ ] The same case is with retry operator:

[ ] And timeoutWith operator:

@jakovljevic-mladen any update on this? I still see no documentation for some operators..

@yousafnawaz Nothing yet. I proposed a fix for
distinctUntilChanged in #6756, but that PR is still in review.
I don't yet have fixes for the other two operators. I will work on them, but I can't promise when.

@yousafnawaz, these issues are fixed and deployed to the rxjs.dev site. If you notice another issue, feel free to open new ticket.


Is it possible to extend the current ViewModel?

Hi Manuel,
is it possible to "extend" the ViewModel with the properties of a collection object, f.e. something like this:
Template.question.viewmodel({

autorun:[
    function() {
        var check = Questions.find({id:FlowRouter.getParam("id")});
        if(check.count()) {
            _.extend(this,check.fetch()[0]);
           console.log(this.title());
        }

    }
]
});

A question object would look like this {title:'Hello',userId:1234}

Use the load method.
On Mar 3, 2016 2:44 AM, "dnish"<EMAIL_ADDRESS>wrote:

Hi Manuel,
is it possible to "extend" the ViewModel with the properties of a
collection object, f.e. something like this:
Template.question.viewmodel({
autorun:[
function() {
var check = Questions.find({id:FlowRouter.getParam("id")});
if(check.count()) {
_.extend(this,check.fetch()[0]);
console.log(this.title());
}
}

]
});
A question object would look like this {title:'Hello',userId:1234}
—
Reply to this email directly or view it on GitHub
https://github.com/ManuelDeLeon/viewmodel/issues/197.

Uff... thanks, I've just searched for "extend" in the docs and didn't find anything :D


Inherited scopes

I have components inside components
Designer have events designer:alt alt to show and hide it
ServiceTable have events designer.service:left, designer.service:right, designer.service:up, designer.service:down

Is there way to enable scope designer and designer.service in same time or other case how I can do it

I have some variants how to develop it, for example put it in one scope and check active ServiceTable or not. But when we have two or more Inherited components (scopes) with same events left, right or other, they all fire and it's performance drop down a little! )

I'm having trouble understanding your example.  Can you post some code?
Are you trying to have two scopes triggered simultaneously?  That's not how scopes work.  Well, it's not how they were meant to work.  Why not just check the current scope from your bound function (i.e. whatever you attached via HI.on()) and dispatch appropriately?
Or you could just bind both scopes simultaneously if you need the same function to be called under both:
HI.on(['designer:alt alt', 'designer.service:alt alt'], toggleDesigner);

That would make the toggle work in both scopes.  Does that make sense?

var HI = new window.HumanInput(window, { logLevel: 'DEBUG' })

// COMPONENT DESIGNER

HI.pushScope('designer')

function onLeft() {
  console.log('LEFT')
}

function onRight() {
  console.log('RIGHT')
}

function onService1() {
  // Some doings to exit from service2, etc... if in it
  HI.pushScope('service1')
  // AFTER THAT I WANT THAT `designer` scope work and `designer.service1` too
}

function onService2() {
  // Some doings to exit from service1, etc... if in it
  HI.pushScope('service2')
  // AFTER THAT I WANT THAT `designer` scope work and `designer.service2` too
}

HI.on('designer:left', onLeft)
HI.on('designer:right', onLeft)
HI.on('designer:1', onService1)
HI.on('designer:2', onService2)

// COMPONENT DESIGNER.SERVICE1

function onService1R() {
  console.log('SERVICE1 PUSH R')
}

HI.on('designer.service1:r', onService1R)

// COMPONENT DESIGNER.SEVICE2

function onService2R() {
  console.log('SERVICE2 PUSH R')
}

HI.on('designer.service2:r', onService2R)

For this sort of situation...  Wouldn't it be better to simply create another instance of HumanInput and simply destroy it when no longer in use?  If you need more than one scope to fire at a time I'm not sure how to handle it otherwise because there's no straightforward way to say, "this scope and these sub-scopes but not those subscopes."
I mean, how do I tell which scopes are enabled or not?  The whole scope system was meant to disable all parent scopes while the child scope was active.    The idea is for simple dialogs and popups and whatnot.
For more sophisticated stuff you can just use multiple instances of HumanInput and enable/disable them on demand.

I'm going to close this comment since I haven't heard back from you.  I'm willing to make changes to add more advanced scopes but I need a better use case/example.


SavedModel Integration

Hi all, thank you for the amazing product. Really love what you have done so far!
Going forward, I would really love to see integration with Tensorflow SavedModel for CloudML deployment. So far I was able to achieve this fairly easily with my own code, however, I had to work around model finalization in tensorforce.model.init. If you can add this functionality to work out of the box, I think it will help enable faster adoption.

Hey, thanks for letting us now - we will see what we can do there, although (see other issues), there are a lot of structural things in the next 2-3 months until we have a more stabilised version ready for deployments, sorry about that
We will provide docker containers for benchmarking purposes soon though

Hi guys, thank you for addressing this issue. @michaelschaarschmidt is there a a deployment example that I can get help from? I am trying to use a model learnt through PPOAgent in deployment through the Tensorflow C++ api. In the trained model, I supply a stacked 1D image array in "states_spec". For the deployment code, I use tensorflow's C++ API to load the meta graph and add to the session. A snippet from my deployment code -
// Read in the protobuf graph we exported
MetaGraphDef graph_def;
status = ReadBinaryProto(Env::Default(), pathToGraph, &graph_def);
if (!status.ok()) {
throw std::runtime_error("Error reading graph definition from " + pathToGraph + ": " + status.ToString());
}
// Add the graph to the session
status = session->Create(graph_def.graph_def());
if (!status.ok()) {
throw std::runtime_error("Error creating graph: " + status.ToString());
}
While adding the graph to the session, I get the following error -
"terminate called after throwing an instance of 'std::runtime_error'
what():  Error creating graph: Invalid argument: Input 1 of node ppo/actions-and-internals/categorical/sample/Select was passed int64 from ppo/actions-and-internals/categorical/sample/ArgMax:0 incompatible with expected int32."
After debugging, I found that this is coming from the "actions_spec" which expects int32.
However, I am not completely sure at this point,how to resolve this.
Any help or an example if it already exists would help a lot. It doesn't necessarily have to be in C++.
Thank you

Hello, im not certain why 64 is passed. In general, have a look at util tf.datatype, where data type conversion happens from specifciations. Maybe we need to add a mapping for 64 bit data types there? I added these mappings now so maybe that helps..

Hi @michaelschaarschmidt, I resolved it. It was a tensorflow issue on my end. Thank you for the awesome work that you have done.

On roadmap.


fix tpb api for searches with only one page of results

the current implementation returns an empty list if no pagination links are shown. tpb hides those links for searches with only one page of results.

Coverage remained the same at 100.0% when pulling 1318d10761c52d68aa9b9b7c35237666ee5f2c66 on flurischt:master into ed31d9a4bdef6ee893798481a59374ea325dbb44 on DandyDev:master.

Coverage remained the same at 100.0% when pulling 5fd82ae1e7acf88194c24bf854274c9b801e7656 on flurischt:master into ed31d9a4bdef6ee893798481a59374ea325dbb44 on DandyDev:master.

Thanks for the fix!


Setting REMOVE_VOLUMES=1 causes docker-gc to exit with status 1

Description
When setting REMOVE_VOLUMES=1 and there are no volumes found in Docker then docker-gc exits with status code 1 because of grep returning 1 when it has not found any matches.
How to reproduce

Make sure that no Docker volumes exist on the system
Run REMOVE_VOLUMES=1 docker-gc

What do you expect
docker-gc should exit with status code 0.
What happened instead
docker-gc exits with status code 1.
Software:

bash version: Any

Full backtrace
$ docker volume ls
DRIVER              VOLUME NAME
$ sudo REMOVE_VOLUMES=1 ./docker-gc
$ echo $?
1

The main problem we have with this currently is that we call docker-gc from a systemd unit and systemd then marks the unit as failed.

@mattnworb @davidxia There's an open PR to fix this issue (#202) that is waiting to be merged. Would you be able to merge the PR or provide feedback, please?

Sorry for the delay. I just merged it.


Error: No executable schema named 'undefined' is available. Have you setup '@keystone-alpha/app-graphql'?

I tried following the https://v5.keystonejs.com/keystone-alpha/auth-passport/#api guide to implementing an auth system, however, I am getting the following error and can't seem to figure out why I am getting the error.
I have the latest version of keystone, auth-passport, app-graphql.
UnhandledPromiseRejectionWarning: Error: No executable schema named 'undefined' is available. Have you setup '@keystone-alpha/app-graphql'?
    at Keystone.executeQuery (/home/ajmain/Desktop/breezy-CMS/node_modules/@keystone-alpha/keystone/lib/Keystone/index.js:189:11)
    at Strategy._ServiceStrategy [as _verify] (/home/ajmain/Desktop/breezy-CMS/node_modules/@keystone-alpha/auth-passport/lib/Passport.js:412:34)
    at processTicksAndRejections (internal/process/task_queues.js:86:5)
(node:22954) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:22954) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
{ TokenError: Bad Request
    at Strategy.OAuth2Strategy.parseErrorResponse (/home/ajmain/Desktop/breezy-CMS/node_modules/passport-oauth2/lib/strategy.js:358:12)
    at Strategy.OAuth2Strategy._createOAuthError (/home/ajmain/Desktop/breezy-CMS/node_modules/passport-oauth2/lib/strategy.js:405:16)
    at /home/ajmain/Desktop/breezy-CMS/node_modules/passport-oauth2/lib/strategy.js:175:45
    at /home/ajmain/Desktop/breezy-CMS/node_modules/oauth/lib/oauth2.js:191:18
    at passBackControl (/home/ajmain/Desktop/breezy-CMS/node_modules/oauth/lib/oauth2.js:132:9)
    at IncomingMessage.<anonymous> (/home/ajmain/Desktop/breezy-CMS/node_modules/oauth/lib/oauth2.js:157:7)
    at IncomingMessage.emit (events.js:198:15)
    at endReadableNT (_stream_readable.js:1139:12)
    at processTicksAndRejections (internal/process/task_queues.js:81:17)
  name: 'TokenError',
  message: 'Bad Request',
  code: 'invalid_grant',
  uri: undefined,
  status: 500 }

@Nakzz I don't seem to be able to access that repository.
It seems like this might be a general support question\request? If so it might be better to point you to our community Slack channel: http://community.keystonejs.com/ You will find an answer here much faster.
If we find a specific bug with either passport of graphQL we can raise a new issue.


aws-sdk-core/endpoint_provider.rb:67:in block in partition_matching_region': undefined method match' for nil:NilClass (NoMethodError)

Just installed and get this error.
I'm not a ruby developer, so not sure what information i can provide. let me know!
terraforming ec2
/usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/aws-sdk-core/endpoint_provider.rb:67:in `block in partition_matching_region': undefined method `match' for nil:NilClass (NoMethodError)
Did you mean?  catch
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/aws-sdk-core/endpoint_provider.rb:66:in `each'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/aws-sdk-core/endpoint_provider.rb:66:in `find'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/aws-sdk-core/endpoint_provider.rb:66:in `partition_matching_region'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/aws-sdk-core/endpoint_provider.rb:55:in `get_partition'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/aws-sdk-core/endpoint_provider.rb:26:in `endpoint_for'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/aws-sdk-core/endpoint_provider.rb:10:in `resolve'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/aws-sdk-core/endpoint_provider.rb:80:in `resolve'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/aws-sdk-core/plugins/regional_endpoint.rb:24:in `block in <class:RegionalEndpoint>'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/seahorse/client/configuration.rb:70:in `call'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/seahorse/client/configuration.rb:205:in `block in resolve_defaults'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/seahorse/client/configuration.rb:57:in `each'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/seahorse/client/configuration.rb:57:in `each'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/seahorse/client/configuration.rb:204:in `resolve_defaults'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/seahorse/client/configuration.rb:200:in `value_at'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/seahorse/client/configuration.rb:189:in `block in resolve'
	from /usr/local/Cellar/ruby/2.3.1/lib/ruby/2.3.0/set.rb:306:in `each_key'
	from /usr/local/Cellar/ruby/2.3.1/lib/ruby/2.3.0/set.rb:306:in `each'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/seahorse/client/configuration.rb:189:in `resolve'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/seahorse/client/configuration.rb:177:in `apply_defaults'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/seahorse/client/configuration.rb:150:in `build!'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/seahorse/client/base.rb:68:in `build_config'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/seahorse/client/base.rb:19:in `initialize'
	from /usr/local/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.3.14/lib/seahorse/client/base.rb:105:in `new'
	from /usr/local/lib/ruby/gems/2.3.0/gems/terraforming-0.9.1/lib/terraforming/resource/ec2.rb:6:in `tf'
	from /usr/local/lib/ruby/gems/2.3.0/gems/terraforming-0.9.1/lib/terraforming/cli.rb:203:in `tf'
	from /usr/local/lib/ruby/gems/2.3.0/gems/terraforming-0.9.1/lib/terraforming/cli.rb:190:in `execute'
	from /usr/local/lib/ruby/gems/2.3.0/gems/terraforming-0.9.1/lib/terraforming/cli.rb:31:in `ec2'
	from /usr/local/lib/ruby/gems/2.3.0/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
	from /usr/local/lib/ruby/gems/2.3.0/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
	from /usr/local/lib/ruby/gems/2.3.0/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
	from /usr/local/lib/ruby/gems/2.3.0/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
	from /usr/local/lib/ruby/gems/2.3.0/gems/terraforming-0.9.1/bin/terraforming:5:in `<top (required)>'
	from /usr/local/bin/terraforming:23:in `load'
	from /usr/local/bin/terraforming:23:in `<main>'

avoided this by specifying the region .
terraforming ec2 --region=us-west-2

Sorry for late reply.
I reproduce this error, without setting 'AWS_REGION' environment variable. This is an error of AWS SDK, not of Terraforming itself.
Please set AWS_REGION=us-west-2 environment variable and it should work well 💡
If you still have the same error, please reopen this issue.
Thanks.


Fix: could not build Release version of nugets

@gasparnagy ?

@leotsarev What kind of error do you get? How do you try to build them?

@leotsarev Thx!


⚠ ClamAV has degraded performance

In c75491e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 234 ms

Resolved: ClamAV performance has improved in 725f48c.


Boolean schema is incorrectly typed as number

// schemas.ts

export const schemas = {
  string: z.string,
  number: z.number,
  boolean: z.number /* --> should be z.boolean */,
  unknown: z.unknown,
  null: z.null,
  undefined: z.undefined,
  date: dateSchema,
  literal: z.literal,
  union: z.union,
  array: z.array,
  object: z.object,
};

This leads to always triggering the invalid type error when using q.boolean()

GitHub Copilot has failed me! Thank you so much for catching this, we'll get the PR merged in and released ASAP!

Okay, released via 0.5.2!

Thank you!


Add mwait function

This is my first pull request so I am not sure how to format this, Anyways what this does is that it adds a mwait function which allows you to wait in microseconds, can be really handy when dealing with loops.

Tested this, I am on macos and it works. It may not work when compiled to WASM but it will in Windows, Linux, & macOS.

Checks arent passing, I will close this until I can fix this.

Thank you for the interest in Luau, but we are not going to accept this PR even if fixed.
Additions like this should first go through the RFC process described here https://github.com/luau-lang/rfcs
But I can tell you upfront that the RFC for this will not be accepted.
No need to worry though, embedders of Luau can add any custom C functions to the global environment that they need in their applications, they don't have to be available in default configuration. And everyone can make a custom fork.

Thanks for the follow up, I will try to have my future pull requests follow the RFC format.
But I have a question, I was trying to implement gotos to the Luau language and was really stuck with the AST, I got it to parse correctly but couldn't get the data sent to the bytecode generator.
Is there any documentation on how Luau can be updated and it's C API?


Keystone Door Logic Fix

Currently, most keystone doors require almost all keystones to make sure nothing gets stuck in logic. With 40 keystones, this highly skews logic

Alternative added in 0.2.0


Use riscv-gcc from system packages

Convert build system to use riscv-gcc from system packages. This will make it much easier to use this scripting system. Having to build a newlib RISC-V compiler is fine, and it doesn't take a long time, but it's still a chore that might be unnecessary.

Added in the latest release!


Fix: Launch configurations were not being deleted

@nahiluhmot
The test was not testing for launch configuration deletion as well, so we missed this.

@tlunter Exciting, but I'm not clear on how the diff fixes the issue.

The failure happens here: https://github.com/swipely/aerosol/pull/44/files#diff-32e03f45a0a2fb2a9ae48fbdc7ba0ebdL62
Since deleting? was raising because the auto_scaling_group_name was not being passed in in an array, we were skipping over removing the launch configuration.

:+1:


onComplete() not playing nice with DCE full

Actuate 1.8.7 - HTML5 target - DCE full option.
If I do this:
Actuate.tween(coverup, 0.5, { alpha:1 } ).onComplete(function () {trace ("not working");});
then I get an exception saying that Cannot read property 'onComplete' of null

I blame DCE because if I turn it off it works.
(BTW: is dce actually worth it? I am starting a new project being DCE friendly but I am not sure of why should I use DCE)

This appears fixed in GIT version. Had issue with 1.8.7 release


ST3 PHP Format Code doesn't works

I'm using Linux Mint 17.3 (Ubuntu 14.04), Sublime Text 3 and I've installed CodeFormatter using "Package Control: Install Package" method. I have PHP 5.6.19-1 too, set chmod +x to file fmt.phar and restart ST3.
When I run Format Code on a php file, the console shows:
['php', '/home/rafael/.config/sublime-text-3/Packages/CodeFormatter/codeformatter/lib/phpbeautifier/fmt.phar', '--psr2', '--indent_with_space=4', '--enable_auto_align', '--visibility_order', '--smart_linebreak_after_curly', '--dry-run', '--no-backup', '-']
But nothing occurs. The php code des not change and still unformatted.
Can you help me?

@rfrancorj can you show me your CF settings? I can not reproduce bug on my Ubuntu 15.10

The problem is that I'm using short php tag "<? ..." instead of "<?php ..."
If I change my php tags to  it works perfectly.
Can you fix CF to works with  ?
My CF settings are:
{
"codeformatter_debug": false,
"codeformatter_php_options":
{
    "syntaxes": "php", // Syntax names which must process PHP formatter
    "php_path": "/usr/bin/php", // Path for PHP executable, e.g. "/usr/lib/php" or "C:/Program Files/PHP/php.exe". If empty, uses command "php" from system environments
    "format_on_save": false, // Format on save
    "php55_compat": false, // PHP 5.5 compatible mode
    "psr1": false, // Activate PSR1 style
    "psr1_naming": false, // Activate PSR1 style - Section 3 and 4.3 - Class and method names case
    "psr2": true, // Activate PSR2 style
    "indent_with_space": 4, // Use spaces instead of tabs for indentation
    "enable_auto_align": true, // Enable auto align of = and =>
    "visibility_order": true, // Fixes visibility order for method in classes - PSR-2 4.2
    "smart_linebreak_after_curly": true, // Convert multistatement blocks into multiline blocks

    // Enable specific transformations. Example: ["ConvertOpenTagWithEcho", "PrettyPrintDocBlocks"]
    // You can list all available transformations from command palette: CodeFormatter: Show PHP Transformations
    "passes": [],

    // Disable specific transformations
    "exclude": []
},

"codeformatter_js_options":
{
    "syntaxes": "javascript,json", // Syntax names which must process JS formatter
    "format_on_save": false, // Format on save
    "indent_size": 4, // indentation size
    "indent_char": " ", // Indent character
    "indent_with_tabs": false, // Indent with one tab (overrides indent_size and indent_char options)
    "eol": "\n", // EOL symbol
    "preserve_newlines": false, // whether existing line breaks should be preserved,
    "max_preserve_newlines": 10, // maximum number of line breaks to be preserved in one chunk
    "space_in_paren": false, // Add padding spaces within paren, ie. f( a, b )
    "space_in_empty_paren": false, // Add padding spaces within paren if parent empty, ie. f(  )
    "e4x": false, // Pass E4X xml literals through untouched
    "jslint_happy": false, // if true, then jslint-stricter mode is enforced. Example function () vs function()
    "brace_style": "collapse", // "collapse" | "expand" | "end-expand". put braces on the same line as control statements (default), or put braces on own line (Allman / ANSI style), or just put end braces on own line.
    "keep_array_indentation": false, // keep array indentation.
    "keep_function_indentation": false, // keep function indentation.
    "eval_code": false, // eval code
    "unescape_strings": false, // Decode printable characters encoded in xNN notation
    "wrap_line_length": 0, // Wrap lines at next opportunity after N characters
    "break_chained_methods": false, // Break chained method calls across subsequent lines
    "end_with_newline": false, // Add new line at end of file
    "comma_first": false // Add comma first
},

"codeformatter_css_options":
{
    "syntaxes": "css,less", // Syntax names which must process CSS formatter
    "format_on_save": false, // Format on save
    "indent_size": 4, // Indentation size
    "indent_char": " ", // Indentation character
    "indent_with_tabs": false, // Indent with one tab (overrides indent_size and indent_char options)
    "selector_separator_newline": false, // Add new lines after selector separators
    "end_with_newline": false, // Add new line of end in file
    "newline_between_rules": false, // Add new line between rules
    "eol": "\n" // EOL symbol
},

"codeformatter_scss_options":
{
    "syntaxes": "scss", // Indentation size
    "format_on_save": false, // Format on save
	"indent_size": 2, // Indentation size
	"indent_char": " ", // Indentation character
	"indent_with_tabs": false, // Indent with one tab (overrides indent_size and indent_char options)
	"selector_separator_newline": true, // Add new lines after selector separators
	"end_with_newline": true // Add new line of end in file
},

"codeformatter_html_options":
{
    "syntaxes": "html,asp,xml", // Syntax names which must process HTML formatter
    "format_on_save": false, // Format on save
    "indent_size": 4, // indentation size
    "indent_char": " ", // Indentation character
    "indent_with_tabs": false, // Indent with one tab (overrides indent_size and indent_char options)
    "exception_on_tag_mismatch": false, // If the last closing tag is not at the same indentation level as the first opening tag, there's probably a tag mismatch in the file
    "expand_javascript": false, // Expand JavaScript inside of <script> tags (also affects CSS purely by coincidence)
    "expand_tags": false, // Expand tag attributes onto new lines
    "minimum_attribute_count": 2, // Minimum number of attributes needed before tag attributes are expanded to new lines
    "first_attribute_on_new_line": false, // Put all attributes on separate lines from the tag (only uses 1 indentation unit as opposed to lining all attributes up with the first)
    "reduce_empty_tags": false, // Put closing tags on same line as opening tag if there is no content between them
    "custom_singletons": "" // Custom singleton tags for various template languages outside of the HTML5 spec
},

"codeformatter_python_options":
{
    "syntaxes": "python", // Syntax names which must process Python formatter
    "format_on_save": false, // Format on save
    "indent_size": 1, // indentation size
    "indent_with_tabs": true, // Indent with tabs or spaces
    "max_char": 80, // Width of output lines in characters.
    "assignment": " = ", // This is how the assignment operator is to appear.
    "function_param_assignment": "=", // This is how function-parameter assignment should appear.
    "function_param_sep": ", ", // This is how function parameters are separated.
    "list_sep": ", ", // This is how list items are separated.
    "subscript_sep": "=", // This is how subscripts are separated.
    "dict_colon": ": ", // This separates dictionary keys from values.
    "slice_colon": ":", // this separates the start:end indices of slices.
    "comment_prefix": "# ", // This is the sentinel that marks the beginning of a commentary string.
    "shebang": "#!/usr/bin/env python", // Hashbang, a line-one comment naming the Python interpreter to Unix shells.
    "boilerplate": "", // Standard code block (if any). This is inserted after the module doc string on output.
    "blank_line": "", // This is how a blank line is to appear (up to the newline character).
    "keep_blank_lines": true, // If true, preserve one blank where blank(s) are encountered.
    "add_blank_lines_around_comments": true, // If true, set off comment blocks with blanks.
    "add_blank_line_after_doc_string": true, // If true, add blank line after doc strings.
    "max_seps_func_def": 3, // Split lines containing longer function definitions.
    "max_seps_func_ref": 5, // Split lines containing longer function calls.
    "max_seps_series": 5, // Split lines containing longer lists or tuples.
    "max_seps_dict": 3, // Split lines containing longer dictionary definitions.
    "max_lines_before_split_lit": 2, // Split string literals containing more newline characters.
    "left_margin": "", // This is how the left margin is to appear.
    "normalize_doc_strings": false, // If true, normalize white space in doc strings.
    "leftjust_doc_strings": false, // If true, left justify doc strings.
    "wrap_doc_strings": false, // If true, wrap doc strings to max_char.
    "leftjust_comments": false, // If true, left justify comments.
    "wrap_comments": false, // If true, wrap comments to max_char.
    "double_quoted_strings": false, // If true, use quotes instead of apostrophes for string literals.
    "single_quoted_strings": false, // If true, use apostrophes instead of quotes for string literals.
    "can_split_strings": false, // If true, longer strings are split at the max_char.
    "doc_tab_replacement": "....", // This literal replaces tab characters in doc strings and comments.

    // Optionally preserve unassigned constants so that code to be tidied
    // may contain blocks of commented-out lines that have been no-op'ed
    // with leading and trailing triple quotes.  Python scripts may declare
    // constants without assigning them to a variables, but CodeFormatter
    // considers this wasteful and normally elides them.
    "keep_unassigned_constants": false,

    // Optionally omit parentheses around tuples, which are superfluous
    // after all.  Normal CodeFormatter behavior will be still to include them
    // as a sort of tuple display analogous to list displays, dict
    // displays, and yet-to-come set displays.
    "parenthesize_tuple_display": true,

    // When CodeFormatter splits longer lines because max_seps
    // are exceeded, the statement normally is closed before the margin is
    // restored.  The closing bracket, brace, or parenthesis is placed at the
    // current indent level.  This looks ugly to "C" programmers.  When
    // java_style_list_dedent is True, the closing bracket, brace, or
    // parenthesis is brought back left to the indent level of the enclosing
    // statement.
    "java_style_list_dedent": false
},

"codeformatter_vbscript_options":
{
    "syntaxes": "vbscript", // Syntax names which must process VBScript formatter
    "format_on_save": false, // Format on save
    "indent_size": 1, // indentation size
    "indent_char": "\t", // Indentation character
    "indent_with_tabs": true, // Indent with one tab (overrides indent_size and indent_char options)
    "preserve_newlines": true, // Preserve existing line-breaks
    "max_preserve_newlines": 10, // Maximum number of line-breaks to be preserved in one chunk
    "opening_tags": "^(Function .*|Sub .*|If .* Then|For .*|Do While .*|Select Case.*)", // List of keywords which open a new block
    "middle_tags": "^(Else|ElseIf .* Then|Case .*)$", // List of keywords which divide a block, but neither open or close the block
    "closing_tags": "(End Function|End Sub|End If|Next|Loop|End Select)$" // List of keywords which close an open block
},

"codeformatter_coldfusion_options":
{
    "syntaxes": "coldfusion,cfm,cfml", // Syntax names which must process Coldfusion Markup Language formatter
    "format_on_save": false, // Format on save
    "indent_size": 2, // indentation size
    "indent_char": " ", // Indentation character
    "indent_with_tabs": false, // Indent with one tab (overrides indent_size and indent_char options)
    "exception_on_tag_mismatch": false, // If the last closing tag is not at the same indentation level as the first opening tag, there's probably a tag mismatch in the file
    "expand_javascript": false, // Expand JavaScript inside of <script> tags (also affects CSS purely by coincidence)
    "expand_tags": false, // Expand tag attributes onto new lines
    "minimum_attribute_count": 2, // Minimum number of attributes needed before tag attributes are expanded to new lines
    "first_attribute_on_new_line": false, // Put all attributes on separate lines from the tag (only uses 1 indentation unit as opposed to lining all attributes up with the first)
    "reduce_empty_tags": false, // Put closing tags on same line as opening tag if there is no content between them
    "custom_singletons": "" // Custom singleton tags for various template languages outside of the HTML5 spec
}

}

Fixed in version 3.1.3


Create packaging and documentation

Using the Flask development server is not ideal for production. Whatever technology choice is picked, there needs to be a packaged, easy way to deploy the code. Ideally, this would be created to run at boot on something like a Raspberry Pi.
Areas that need to be explored:

[ ] Generating services on various OS
[ ] Packaged VM that auto-runs
[ ] Container services (likely not)?

Container services (likely not) - rude!


Fix cmdref always displaying "name"

This previously passed the content [name] instead of the value of the name variable, causing every cmdref call to render as #name

Thanks.


Get file name without extension

All our path types should support this together with the FileName member.

I think here I can substring extension length


Make buttons toggleable backwards by right-clicking

This pull request adds a new groundbreaking feature to Prefab.
It makes buttons toggleable backwards by right-clicking on them.
And it also adds a tooltip that says how to toggle the buttons.

Needs further testing after resolving merge conflicts


chore: rename RegisterAccount rpc and msgs to RegisterInterchainAccount

Description

Rename RegisterAccount rpc to RegisterInterchainAccount
Rename MsgRegisterAccount to MsgRegisterInterchainAccount
Rename MsgRegisterAccountResponse to MsgRegisterInterchainAccountResponse
Reorder fields: owner comes before connection_id

closes: #2230
closes: #2233

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Codecov Report

Merging #2253 (0ceeaff) into main (fcdb0fc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2253   +/-   ##
=======================================
  Coverage   79.51%   79.51%
=======================================
  Files         175      175
  Lines       12075    12075
=======================================
  Hits         9601     9601
  Misses       2049     2049
  Partials      425      425

Impacted Files
Coverage Δ

...nterchain-accounts/controller/keeper/msg_server.go
91.66% <100.00%> (ø)

...s/27-interchain-accounts/controller/types/codec.go
100.00% <100.00%> (ø)

...ps/27-interchain-accounts/controller/types/msgs.go
92.30% <100.00%> (ø)


IE11 issue

This is a strange one: it does not work in IE 11 as complains about not being able to understand the parameteres with default empty values, paased into a function:
let sanitizeText = function (text, sociaType = '') {...}
Converted into ES5,  still does not work and no errors this time.

Hello @dbaronov
Thanks for reporting this bug, as you can see, IE11 has no support for functions default parameters http://kangax.github.io/compat-table/es6/
The distribution file of the script is already converted in ES5.
If you find a fix, a contribution will be appreciated.

Managed to get this error on text select:

Mmh. It seems that there is an error in the generateTooltip function with IE 11. Maybe he's not able to make dynamics appendChild ...
Let me konw if you find any solution.
Thanks :)

PR for your review is available here: https://github.com/VincentLoy/share-selected-text/pull/13 .

Thanks a lot @dbaronov I'll check it out !

Fixed in #13


Fix for sort order in select/topN query cache

When historical caching is enabled (probably also broker caching -- not tested in our configuration), and a select or topN query is issued, and then a following query with "descending": true is set, the cached query returns the ascending result (or vice versa), often resulting in invalid paging identifiers.
The CacheKey for these queries doesn't include the "descending" flag; this change adds it, and fixes the problem.
Open to suggestions on how to unit test this. Maybe CachingQueryRunner should include some consecutive topN / select tests?

For unit tests I'd suggest adding tests to SelectQueryQueryToolChestTest (which doesn't seem to exist yet) that verify that if "descending" is tweaked, that the cache key changes. It would be similar to the cache key tests in TopNQueryQueryToolChestTest.
Looks like a solid bug fix for select -- I bet it took so long for someone to notice because by default, caching for select is disabled.
The change doesn't look necessary for topN though. It doesn't expose the "descending" scan order as an option and even if it did, it shouldn't change the results much, since topN does its own sorting anyway. If it did change the results it would only be because it might make the topN approximation fall out a different way.
Could you please also fill out the project CLA at http://druid.io/community/cla.html?

Ah yes, good points. I changed topN only incidentally; the production failure we saw was for select, and we do enable select caching specifically as we use it a lot.
I will revert the topN change. The select change should back-port as-is to 0.10.x and 0.9.x also, unlike topN.
And I'll try to put a unit test together and do the CLA thing.

Added unit test; please take a look.

LGTM, thanks for the patch! Will merge it after the automated checks pass.

Would you like me to also submit pull requests backporting to 0.10.x and 0.9.x?
We are still using 0.9.x and I am locally backporting it anyway...

We aren't still issuing releases from those branches, so no thanks.

Ok, good to know. Will upgrade our own infra then. :)


Redundancy - Unify functions

Currently, parse-torrent.remote tries to parse it as non-remote before trying to fetch from remote source index.js#L50-L60.
On WebTorrent it happens too torrent.js#L190-L207
I think parse-torrent should expose one function only (the remote one) as the main and only function.
I also don't understand why this exists if it will be assigned here

The reason that both exist is that sometime you want to parse a torrent synchronously. It's the same reason that fs.readFile and fs.readFileSync exist in Node.js.
Sorry, I wasn't able to see your code links because the codebase has since changed. Hint: Next time, hit the "y" key after selecting the lines you want to link to, and you will get a permalink.


Fixes #2111 RemoveNonDocument ordering issue

Fixes #2111 RemoveNonDocument ordering issue
Correctly traverses the linked list while removing elements.
This was reported by NTVS team when they discovered a crash in their version of this file.

👍


Made website SEO friendly

Related Issue
Fixes #358
Description
[Please include a brief description of the changes or features added]
I have added the appropriate meta tags and links which helps the website to become SEO friendly.
Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]
Kindly let me know if there are any changes to be made.

@chaanakyaaM Just update the branch

sry but i didn't understood.

ok


[SPARK-23924][SQL] Add element_at function

What changes were proposed in this pull request?
The PR adds the SQL function array_position. The behavior of the function is based on Presto's one.
This function returns element of array at given index in value if column is array, or returns value for the given key in value if column is map.
How was this patch tested?
Added UTs

Test build #89266 has started for PR 21053 at commit d7ec6cc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2264/
Test PASSed.

Test build #89266 has finished for PR 21053 at commit d7ec6cc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ElementAt(left: Expression, right: Expression) extends GetMapValueUtil
abstract class GetMapValueUtil extends BinaryExpression with ImplicitCastInputTypes
case class GetMapValue(child: Expression, key: Expression) extends GetMapValueUtil

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89266/
Test FAILed.

retest this please

Test build #89284 has started for PR 21053 at commit d7ec6cc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2280/
Test PASSed.

Test build #89284 has finished for PR 21053 at commit d7ec6cc.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ElementAt(left: Expression, right: Expression) extends GetMapValueUtil
abstract class GetMapValueUtil extends BinaryExpression with ImplicitCastInputTypes
case class GetMapValue(child: Expression, key: Expression) extends GetMapValueUtil

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89284/
Test FAILed.

Test build #89313 has started for PR 21053 at commit bb0ab45.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2295/
Test PASSed.

cc @ueshin

Test build #89313 has finished for PR 21053 at commit bb0ab45.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89313/
Test FAILed.

retest this please

Test build #89321 has started for PR 21053 at commit bb0ab45.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2302/
Test PASSed.

Merged build finished. Test PASSed.

Test build #89321 has finished for PR 21053 at commit bb0ab45.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89321/
Test FAILed.

Test build #89336 has started for PR 21053 at commit 0146945.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2314/
Test PASSed.

Merged build finished. Test PASSed.

Test build #89336 has finished for PR 21053 at commit 0146945.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89336/
Test FAILed.

Test build #89356 has started for PR 21053 at commit 35844f8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2325/
Test PASSed.

Test build #89356 has finished for PR 21053 at commit 35844f8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89356/
Test FAILed.

Test build #89383 has started for PR 21053 at commit 013a53e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2334/
Test PASSed.

Test build #89383 has finished for PR 21053 at commit 013a53e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89383/
Test FAILed.

Test build #89403 has started for PR 21053 at commit 5bdee7e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2349/
Test PASSed.

Test build #89403 has finished for PR 21053 at commit 5bdee7e.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class GetMapValue(child: Expression, key: Expression)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89403/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2407/
Test PASSed.

Test build #89476 has finished for PR 21053 at commit 98465b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class GetMapValue(child: Expression, key: Expression)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89476/
Test PASSed.

Test build #89502 has started for PR 21053 at commit c734607.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2430/
Test PASSed.

Test build #89502 has finished for PR 21053 at commit c734607.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89502/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2450/
Test PASSed.

Test build #89528 has started for PR 21053 at commit 68e8907.

Test build #89528 has finished for PR 21053 at commit 68e8907.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89528/
Test PASSed.

Test build #89545 has started for PR 21053 at commit 2fbb1e8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2466/
Test PASSed.

Test build #89545 has finished for PR 21053 at commit 2fbb1e8.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89545/
Test FAILed.

Merged build finished. Test FAILed.

Test build #89553 has started for PR 21053 at commit 96dd82b.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2474/
Test PASSed.

Test build #89554 has started for PR 21053 at commit 90e026e.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2475/
Test PASSed.

Merged build finished. Test PASSed.

Test build #89553 has finished for PR 21053 at commit 96dd82b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #89554 has finished for PR 21053 at commit 90e026e.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #89552 has finished for PR 21053 at commit 06fb27e.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89553/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89552/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #89558 has started for PR 21053 at commit 90e026e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2478/
Test PASSed.

Test build #89558 has finished for PR 21053 at commit 90e026e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89558/
Test PASSed.

Thanks! merging to master.

thank you very much for your comments


GH-2015 solr elastic upgrade

GitHub issue resolved: #2015
Briefly describe the changes proposed in this PR:

bump versions for Solr, Lucene and Elasticsearch
implement new method (abstract class has changed in ES)

PR Author Checklist:

[x] my pull request is self-contained
[ ] I've added tests for the changes I made
[x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change
[x] every commit has been signed off

Note: we merge all feature pull requests using squash and merge. See RDF4J git merge strategy for more details.

How does this PR relate to the existing PR #2016?

I've closed the older PR because this one seems to use slightly newer versions.
I'm currrently trying to decide if we want to risk merging this in for the 3.2 release. I'll check out the branch locally to play a little.

Built locally, all tests green, also tried out a lucene sail running from workbench, works as expected. Happy to merge.

Hang on. I just noticed that this PR changes 4 files, while PR #2016 changed 7. Taking a closer look to see what's different.

Alright, to be safe, I'm not including this for 3.2, we'll schedule for 3.3 instead. Also saves me having to respin the IP log, I just realized....

sorry @hmottestad , didn't realize that you've already created a PR for this

@barthanssens I hadn't put in the work to get the CQs approved....that's the real job ;)

Btw. Our users can easily upgrade to a newer version of elasticsearch on their own. I've been running 6.8.7 with the ElasticsearhStore for a while now.
Upgrading here was triggered by the need to support a newer jdk version, since the old Elasticsearch doesn't run on jdk 13 and that stop us from upping the version in our CI.

Thanks @barthanssens , looks good!


Search Function (tools in the right toolbar) searchs files by name

It's possible to add file name search in the global search?
When types for example toto.json, the result shows all files that contains toto.json

Do you know about Quick Open (Ctrl/Cmd+P) ?

Thanks, the function is a part of the solution.
Sometimes, we needs the list of files (ex: all files .json) and modify something on each files.
the view "memorize" the last files opened.
The Ctrl+P only used to go to 1 file.
PS: Why shortcut is the "default" shortcut of printing element?

If you use the right-arrow key on an item in the Quick Open list it opens that file, removes it from the list, and leaves you in the list ready to do the same for another entry.

Thanks


Support Rust in JetBrains

Per request on Discord, we need to implement the following extension point:
  <extensionPoint qualifiedName="org.rust.runConfigurationExtension"
                        interface="org.rust.cargo.runconfig.CargoCommandConfigurationExtension"
                        dynamic="true"/>

Still blocked on the aforementioned issue

Blocked by intellij-rust/intellij-rust#10027

I think it's now safe to assume that issue will never be addressed, as the intellij-rust plugin was deprecated and there are no new commits ever since. So now we're no longer blocked by that issue, but rather by our search for an extension point (that might not yet exist) for controlling the run configuration in RustRover runs. I tried asking in the JetBrains slack without much luck so far, so I posted in the plugin development forum (which according to the IntelliJ Platform Plugin SDK docs is the right place for questions and problems related to plugin development, next to the slack channel).

Need to open an issue on the youtrack https://youtrack.jetbrains.com/issues/RUST

Need to open an issue on the youtrack https://youtrack.jetbrains.com/issues/RUST

I created a post on the plugin development forum (and asked in the #intellij-platform slack channel), which is what the plugin SDK docs say to do. I think that issue tracker is for RustRover end users, not plugin developers.

We already used youtrack to ask them for changes/features and they were quite receptive. The forum/slack is for triage/support but if we need a feature request/suggestion then it goes to the tracker.
https://youtrack.jetbrains.com/issue/IDEA-336189/Make-QsTargetConfigurationExtension-public


Error with latest aframe

I'm seeing the following error when using this library with the latest version of aframe (master not on npm):
Uncaught (in promise) TypeError: Cannot read property 'clearRect' of undefined

If possible it would be nice to support the latest version of aframe because it has WebVR 1.0 support and will likely be publishing a release to npm soon.

Sure, I'll see what I can do

render() in "draw" component is being called prior to a canvas element being created and context being set.  Inside draw component's init() you can call createCanvas to prevent this.

@Goblinlordx Thanks for finding this. I've been very busy lately so feel free to hand over a pull request and I'll run it straight through. Otherwise maybe this weekend it'll happen?

:+1:
https://github.com/maxkrieger/aframe-draw-component/pull/5/files

Thanks again! 👍


added  support for SE|Hydrogen, biomass/coal split for SE|Solids

removed  implementation again, instead added the explicit gas/coal versions.
(was unsure about implications of the  thing, need more time to understand that

oh, I thought I could do a second (separate) pull request with the unit changes for the economy. sorry that this got automatically included in the first pull request.


Facebook API Call using ng2-facebook-sdk

I am using ng2-facebook-sdk to call some facebook endpoint on our project.
I have logged in using login endpoint of ng2-facebook-sdk.
I am trying to call acounts endpoint with manage_pages, publish_pages, pages_show_list options
FB.api(
"/{user-id}/accounts",
function (response) {
if (response && !response.error) {
/* handle the result */
}
}
);
how can I use the ng2-facebook-sdk endpoint to do this?

@BearandYoon you will need to use the api method.
constructor(fb: FacebookService){ ... }

getAccounts() {

  this.fb.api('/{user-id}/accounts').then((resonse) => console.log(response));

}


Mparticle custom action

Requires API key and secret to Mparticle's batch API
Takes either user data or event data and batches them to their API

To whoever is reviewing this PR - I noticed that for large (5000+ rows) action execution, the action performs fine and sends all the data appropriately, but because the streaming takes longer than Looker's timeout window, the user still receives a 404 email indicating that the action did not complete successfully. Is this a bug on Looker's side? I am returning new Hub.ActionResponse({ success: true }) in the same way that I see other actions doing.

  MparticleAction unit tests
    action
      ✓ errors if there is no apiKey
      ✓ errors if there is no apiSecret
      ✓ errors if there is no data_type
      1) errors if there is not at least one userIdentity
    asJSON
      ✓ supported format is json_detail_lite_stream on lookerVersion 6.2 and above

Just this one error left it looks like in your tests

@phillipperalez Hmm that is odd, it was working before and I haven't changed that flow - I see it working as expected in the action itself, do you see anything about the test or error throwing that might be weird? I tried to keep to the same style as I saw in other actions

Running the test locally it doesn't seem like the Each row must specify at least 1 identity tag. is getting thrown with the sample data. Looking into it too

https://github.com/4mile/looker-actions/blob/658e55ca29f8a1df6917087620f9819823185e16/src/actions/mparticle/mparticle_transaction.ts#L227
Since a table_calculation isn't in the sample_data that you made, you are trying to do a foreach on something that is null


[iOS] keyboardAppearance of TextField has no impact

iOS 12.0
Flutter 0.8.2
Setting the keyboardAppearance property of TextField to Brightness.dark does not change the keyboard - it remains light themed.
flutter doctor -v output:
[✓] Flutter (Channel beta, v0.8.2, on Mac OS X 10.13.6 17G65, locale de-DE)
    • Flutter version 0.8.2 at /Users/kounex/Documents/Development/path_included/flutter
    • Framework revision 5ab9e70727 (2 weeks ago), 2018-09-07 12:33:05 -0700
    • Engine revision 58a1894a1c
    • Dart version 2.1.0-dev.3.1.flutter-760a9690c2

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/kounex/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.0, Build version 10A255
    • ios-deploy 1.9.2
    • CocoaPods version 1.5.0

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 24.2.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] VS Code (version 1.27.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.18.0

[!] Connected devices
    ! No devices available

! Doctor found issues in 1 category.

Please add the output of flutter doctor -v.

Also ran into this today.
$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel dev, v0.10.0, on Mac OS X 10.13.6 17G65, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.1)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.0)
[✓] Android Studio (version 3.1)
[✓] VS Code (version 1.28.0)
[✓] Connected device (2 available)

• No issues found!

I'm having the same issue ..

maybe related to commit #18562 ?

#24334 seems to be a fix for this


⚠ Bofrost.at has degraded performance

In c489a0d, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1213 ms

Resolved: Bofrost.at performance has improved in 870f621.


Addition of a non-projection-based method of removing EOG and ECG artifacts.

Describe the new feature or enhancement
The current SSP and ICA methods of removing EOG and ECG artifacts are really effective, but they do completely zap out 2 or even 3 ranks of data. With many-channel MEG and EEG recordings, that's usually fine, but since MNE-Python is getting used more and more for EEG analysis, also low channel count EEG analysis, perhaps it would be nice to provide an alternative method that is more conservative.
In the past, I've played around with regression-based approaches (regress out the EOG channels from the data), which do work pretty well, but recently @rkobler developed the SGEYESUB algorithm that may be superior.
Do others agree this is worth adding to MNE-Python?
Describe your proposed implementation
Implement mne.preprocessing.sgeyesub following the reference implementation. It needs epochs of blinks and saccades, which are usually recorded in a dedicated segment of the experiment where the participant is following on-screen directions for blinking and moving their eyes. If you don't have such a segment in your experiment, mne.preprocessing.make_eog_epochs could be a decent substitute.
Describe possible alternatives
We could decide SSP/ICA is good enough and if people want other algorithms, they can make their own extension packages. Alternatively, we could merge in mne_sandbox.preprocessing.eog_regression instead.

I'd add the "standard" regression approach first, because that's widely used (and often requested). I have implemented one of the first regression-based approached described in Hillyard & Galambos (1970) here. Can you explain what's different in the approach you implemented in mne-sandbox (Croft & Barry, 2000)? I've never seen SGEYESUB used before, so it seems rather niche and I would probably not add it right away (at least not before the standard regression approach is available).

Croft & Barry first extract blink and saccade epochs and create ERPs. Then they compute the regression weights on those ERPs. The idea being that the ERPs contain a pretty pure blink without other ongoing EEG, so the weights will be more accurate. Once you have the weights, you apply them on the raw data like in your approach. Blinks and saccades are processed separately, but with the same idea: first make ERPs, then perform the regression.

Perhaps it's time then to move the EOG regression out of the sandbox into MNE-Python proper ;)

I think so too! It would be nice if that function had a parameter to choose from Croft & Barry and Hillyard & Galambos (since the latter is very often still used today).

Describe your proposed implementation
Implement mne.preprocessing.sgeyesub following the reference implementation.

reference implementation is GPL-3, which IIUC carries a "same license for the library" requirement.  We'd need to request permission to relicense as BSD-3 if the plan is to simply translate the MATLAB implementation into Python.

A bonus provided by @rkobler's paper is a nice set of validation datasets we can use to test our implementation: https://osf.io/2qgrd

reference implementation is GPL-3

I'll keep that in mind if we do end up implementing SGEYESUB.

A bit OT, but I find it a bit sad that both the paper by Kobler et al. (2020) as well as the cited Schlögl et al. (2007) completely ignore relevant prior literature. The regression approach dates back to Hillyard and Galambos (1970), and a useful implementation (using the same data and separate coefficients for blinks and movements) was presented by Gratton, Coles and Donchin (1983). The latter is the "reference" implementation which I think we should provide before anything else (maybe even in simplified form with just one set of coefficients for both blinks and movements).

among the variants is their one you would consider the go to method for
this task?
I would like to avoid implement/maintain/test many small variants that lead
to
comparable results.

Message ID: @.***>

I'd prefer the one from Gratton et al. (1984), this is the most used one IMO. All of them are pretty similar anyway and also comparable in terms of performance. So it's basically about how to estimate the regression coefficients. I think the code that's already available in the sandbox is a good starting point.

If I look at the spectrum of variants, it occurs to me that most of them have to do with deciding on what type of data to fit the regression weights. If we go for a .fit()/.apply() style API, it would leave the user a lot of flexibility on which methodology to use. What I don't like about that approach though is that it makes it less straightforward to "just apply the method". Perhaps being opinionated on an approach is more desirable. :thinking:

I'd prefer the one from Gratton et al. (1984)
This one? https://www.sciencedirect.com/science/article/abs/pii/0013469483901359?via%3Dihub

Perhaps being opinionated on an approach is more desirable. 🤔

+1

Message ID: @.***>

Yes, this one! And yes, the differences between the various regression methods is which data to fit the coefficients on, so a fit/apply API would be perfect! To make it easier to apply, we could then provide a wrapper function for e.g. the Gratton et al. approach.

https://mne.tools/stable/generated/mne.preprocessing.regress_artifact.html 😅


433MHZ RF + IR + WiFi Remote Control

Device Infomation JSON File
No response
Detail Informations
Hi,
There is a lot of small RF + IR bridge, used with Smart Life Wifi on chinese sites (Al*Express for example), very useful to upgrade old RF or IR devices to Smart Life.
An integration will give a full access to a lot of materials : roller shutters, ...
Thanks

Hot 433MHZ RF Remote Control Tuya IR WiFi Remote Control Smart Universal Infrared Smart works with Alexa Google Home : 10$ only

Thanks @Madcat-76310!
I am adding more information to this ticket as I have the same context!
I successfully use a non-Tuya Broadlink RM4 Pro IR/RF broadcaster device with the homebridge-broadlink-rm plugin to control 6 roller blinds with RF control.
I am recently testing a Tuya-supported  eMylo WiFi Smart IR RF Remote Controller, USB Smart IR RF Remote Control, partly due to the large number of Tuya devices in my environment, with a test of controlling one of those blinds.
The Tuya eMylo device and the "Roller Shades" device appear in the Smart Life app, and the roller shades can be controlled via the Smart Life app.
These devices appear in the Apple Home app but are showing "Not Supported."
I've included screenshots of the Smart Life Screens and Home app screens and JSON from the IR/RF device and the Roller shades device as reported to Homebridge by the Tuya plugin.
I'm also including JSON for one of the blinds successfully operated through the Home app via the Broadlink RM4 Pro and plugin.
I hope these help some!

{
    aid => 146,
    services => [
      {
        characteristics => [
          {
            description => "Identify",
            format => "bool",
            iid => 2,
            perms => ["pw"],
            type => 14,
          },
          {
            description => "Manufacturer",
            format      => "string",
            iid         => 3,
            maxLen      => 64,
            perms       => ["pr"],
            type        => 20,
            value       => "Tuya Inc.",
          },
          {
            description => "Model",
            format      => "string",
            iid         => 4,
            maxLen      => 64,
            perms       => ["pr"],
            type        => 21,
            value       => "h5znnnqmnvw0decb",
          },
          {
            description => "Name",
            format      => "string",
            iid         => 5,
            maxLen      => 64,
            perms       => ["pr"],
            type        => 23,
            value       => "Infrared + RF UR01",
          },
          {
            description => "Serial Number",
            format      => "string",
            iid         => 6,
            maxLen      => 64,
            perms       => ["pr"],
            type        => 30,
            value       => "e0c3c7b8f8113b8e",
          },
          {
            description => "Firmware Revision",
            format => "string",
            iid => 7,
            perms => ["pr"],
            type => 52,
            value => "1.7.0-beta.53",
          },
          {
            description => "Configured Name",
            format => "string",
            iid => 8,
            perms => ["ev", "pr", "pw"],
            type => "E3",
            value => "Infrared + RF UR01",
          },
          {
            description => "Status Active",
            format => "bool",
            iid => 9,
            perms => ["ev", "pr"],
            type => 75,
            value => 1,
          },
        ],
        iid => 1,
        type => "3E",
      },
    ],
  },

{
    aid => 149,
    services => [
      {
        characteristics => [
          {
            description => "Identify",
            format => "bool",
            iid => 2,
            perms => ["pw"],
            type => 14,
          },
          {
            description => "Manufacturer",
            format      => "string",
            iid         => 3,
            maxLen      => 64,
            perms       => ["pr"],
            type        => 20,
            value       => "Tuya Inc.",
          },
          {
            description => "Model",
            format      => "string",
            iid         => 4,
            maxLen      => 64,
            perms       => ["pr"],
            type        => 21,
            value       => "0000003nzf",
          },
          {
            description => "Name",
            format      => "string",
            iid         => 5,
            maxLen      => 64,
            perms       => ["pr"],
            type        => 23,
            value       => "Roller Shutters",
          },
          {
            description => "Serial Number",
            format      => "string",
            iid         => 6,
            maxLen      => 64,
            perms       => ["pr"],
            type        => 30,
            value       => "eb9c5e6fad740ed4f3ojwj",
          },
          {
            description => "Firmware Revision",
            format => "string",
            iid => 7,
            perms => ["pr"],
            type => 52,
            value => "1.7.0-beta.53",
          },
          {
            description => "Configured Name",
            format => "string",
            iid => 8,
            perms => ["ev", "pr", "pw"],
            type => "E3",
            value => "Roller Shutters",
          },
          {
            description => "Status Active",
            format => "bool",
            iid => 9,
            perms => ["ev", "pr"],
            type => 75,
            value => 1,
          },
        ],
        iid => 1,
        type => "3E",
      },
    ],
  },

Example JSON from Apple Home-working roller shades controlled via a Braodlink RM4 Pro IR/RF broadcaster with the Braodlik RM plugin; this device is the same category.
{
    aid => 51,
    services => [
      {
        characteristics => [
          {
            description => "Identify",
            format => "bool",
            iid => 2,
            perms => ["pw"],
            type => 14,
          },
          {
            description => "Manufacturer",
            format      => "string",
            iid         => 3,
            maxLen      => 64,
            perms       => ["pr"],
            type        => 20,
            value       => "Broadlink",
          },
          {
            description => "Model",
            format      => "string",
            iid         => 4,
            maxLen      => 64,
            perms       => ["pr"],
            type        => 21,
            value       => "RM Mini or Pro",
          },
          {
            description => "Name",
            format      => "string",
            iid         => 5,
            maxLen      => 64,
            perms       => ["pr"],
            type        => 23,
            value       => "Living Room Street Blinds",
          },
          {
            description => "Serial Number",
            format      => "string",
            iid         => 6,
            maxLen      => 64,
            perms       => ["pr"],
            type        => 30,
            value       => "a9882a2c-9b97-4ac5-89df-9d390ae07f8f",
          },
          {
            description => "Firmware Revision",
            format => "string",
            iid => 7,
            perms => ["pr"],
            type => 52,
            value => "4.4.15",
          },
        ],
        iid => 1,
        type => "3E",
      },
      {
        characteristics => [
          {
            description => "Name",
            format      => "string",
            iid         => 9,
            maxLen      => 64,
            perms       => ["pr"],
            type        => 23,
            value       => "Living Room Street Blinds",
          },
          {
            description => "Current Position",
            format      => "uint8",
            iid         => 10,
            maxValue    => 100,
            minStep     => 1,
            minValue    => 0,
            perms       => ["ev", "pr"],
            type        => "6D",
            unit        => "percentage",
            value       => 0,
          },
          {
            "description"  => "Position State",
            "format"       => "uint8",
            "iid"          => 11,
            "maxValue"     => 2,
            "minStep"      => 1,
            "minValue"     => 0,
            "perms"        => ["ev", "pr"],
            "type"         => 72,
            "valid-values" => [0, 1, 2],
            "value"        => 2,
          },
          {
            description => "Target Position",
            format      => "uint8",
            iid         => 12,
            maxValue    => 100,
            minStep     => 1,
            minValue    => 0,
            perms       => ["ev", "pr", "pw"],
            type        => "7C",
            unit        => "percentage",
            value       => 0,
          },
        ],
        iid => 8,
        type => "8C",
      },
    ],
  },


[BUG] Unable to enable NVIDIA A30 SR-IOV GPU Devices in Harvester

Describe the bug
Unable to enable NVIDIA A30 SR-IOV GPU Devices in Harvester
To Reproduce
Steps to reproduce the behavior:

enable nvidia driver toolkit
enable GPU in SR-IOV GPU Devices
device will not enable

Expected behavior

GPU devices should enable and be viewable in GPU devices and vGPU's should be assignable to VM's

Support bundle
[
supportbundle_504f86b3-e0c2-4621-947e-bbfdf3e22e8c_2024-03-19T17-17-15Z.zip
](url)
Environment

Harvester ISO version: 1.3.0
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): Baremetal with Gigabyte G492-HA0

Hi @ibrokethecloud, could you help me take a look at this one if you're available?
I found some error messages in support bundle file, do you have any ideas about this one?

In harvester-system/nvidia-driver-runtime pod
Installing nvidia driver from HTTPENDPOINT/NVIDIA-Linux-x86_64-vgpu-kvm.run, and this is env setting for this pod. Is it normal to use HTTPENDPOINT string here?env:
- name: DRIVER_LOCATION
  value: HTTPENDPOINT/NVIDIA-Linux-x86_64-vgpu-kvm.run

In harvester-system/harvester-pcidevices-controller

error syncing 'harvester0-00001c000': handler on-gpu-change: error during readiness check: error during command execution: unable to upgrade connection: container not found (\"nvidia-driver-ctr\"), requeuing
pcideviceclaim harvester0-00001c000 is already in use with vm windows11 in namespace saravm, but I couldn't find any pcidevicecalim in SBK.
nvidia.com/GA100GL_A30_PCIE device plugin failed to deregister: rpc error: code = Unavailable desc = transport is closing","pos":"device_manager.go:250","reason":"rpc error: code = Unavailable desc = transport is closing

Needed to follow instructions in https://docs.harvesterhci.io/v1.3/advanced/addons/nvidiadrivertoolkit/


Not working

Hi,
I am using this on RISC V, RV32I and doing this:
    uint32_t dest1 = 0xDEADBABE;     uint32_t dest2 = 0xDEADBEEF; printf("Hello, World! dest1 = 0x%08X, dest2 = 0x%08X", dest1, dest2);
likewise
printf("Hello, World! dest1 = 0x%08X, dest2 = 0x%08X", 0xDEADBABE, 0xDEADBEEF);
prints "Hello, World! dest1 = 0x%, dest2 = 0x%"
Also:
printf("Timebase = %d s %d ns", s3, ns3);
prints "Timebase = % s % ns" ....

Could you figure out the problem?

Yes sorry I had implemented all shifts except for SLL, sorryyyyyyyy!


Hovering over JSDoc annotation resolves differently to Intellisense

Issue Type: Bug
It's possible when hovering over the JSDoc annotation for it to resolve to a different object to what Intellisense will autocomplete to.
To re-create ...
// account.js

/**
 * @class
 */
class Account {
  constructor () {
    this.foo = 'foo'
  }
}

module.exports = {
  Account
}

// index.js

const { account } = require('./account.js')

/**
 * @param {Account} a
 */
const main = (a) => {
  a.foo = ''
}

Hovering over the JSDoc will resolve it to the lib.d.ts Account interface but when typing the a.foo in main it will autocomplete to the correct Account class.
VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:56:38.504Z)
OS version: Darwin x64 18.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz (8 x 2700)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (1.87GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (10)

Extension
Author (truncated)
Version

scratchpad
awe
0.1.0

insert-unicode
bru
0.6.0

vscode-standardjs
che
1.2.3

gitlens
eam
9.8.5

nunjucks-template
ese
0.1.2

vscode-docker
ms-
0.7.0

addDocComments
ste
0.0.8

code-spell-checker
str
1.7.17

vscodeintellicode
Vis
1.1.8

vscode-todo-highlight
way
1.0.4

@brendanarnold  I'm trying to repro this now and having trouble with this part:

but when typing the a.foo in main it will autocomplete to the correct Account class.

I'm just not seeing that autocomplete?
In my observation, the Account type from account.js isn't visible from index.js so it makes sense that it resolves to the one from lib.dom.d.ts.  This all seems by design to me.

@minestarks
Yeah I just revisited the test case setup and cannot reproduce myself now either with 1.42.0.
What I find instead is that if you name the Account class something else that Intellisense resolves the class in main.js but when you name the class back to Account the built-in reference takes precedence.
Happy to close the issue.

Well, it may still be a bug. Let me write up a clearer repro of what I think is the problem.
// account.js

// @ts-check

/**
 * @class
 */
class Account {
    constructor() {
        this.foo = 'foo'
    }
}

/**
 * @class
 */
class OtherName {
    constructor() {
        this.foo = 'foo'
    }
}

module.exports = {
    Account,
    OtherName
}

// bar.js

// @ts-check

const { Account, OtherName } = require('./account.js')

/**
 * @type {Account}
 */
let a;
a.foo // error: Property 'foo' does not exist on type 'Account'

/**
 * @type {OtherName}
 */
let b;
b.foo // OK

Expected: Account resolves to the imported type, Actual: the lib.dom.d.ts type is preferred.
This could potentially be by design, but I suspect not since the TypeScript "equivalent" favors the imported Account type:
// account.ts

/**
 * @class
 */
class Account {
    foo: number
}

/**
 * @class
 */
class OtherName {
    foo: number
}

export { Account, OtherName }

// b.ts

import { Account, OtherName } from './account'

let a: Account
a.foo // OK

let b: OtherName
b.foo // OK

@sandersn  any comment on the JSDoc behavior in https://github.com/microsoft/TypeScript/issues/32845#issuecomment-584220441 ? Expected?

It is not expected. It's a bug in the commonjs require AND the commonjs module.exports handling; your Typescript example works exactly the same way in JS if you just change the extensions (and use foo = 1 instead of foo: number).
Basically, it looks like require fails to import the type meaning of Account, so type reference resolution finds interface Account from lib.dom.d.ts first. OtherName, on the hand, also doesn't import the type meaning, but falls back to JS-style value resolution after the compiler can't find a type named OtherName.
There might be an existing issue tracking this. #25533 is basically right as far as I remember.