[BUG] Colour change between reading an writing xlsx

🐛 Bug Report
Between reading in a given xlsx and writing it out, I am seeing the cell and border colours change.
Lib version: 3.0.2
Screenshot of input and output file, as seen in Numbers on macOS X:

Steps To Reproduce

async function createExcelSpreadsheet(filePath, data, options: any = {}) {

    const workbook = new Workbook();
    let worksheet;

    if (options.template) {
        const templatePath = './templates/xlsx/my-template.xlsx';
        await workbook.xlsx.readFile(templatePath);
        worksheet = workbook.getWorksheet(1);
    }

    if (!worksheet) {
        worksheet = workbook.addWorksheet('Sheet 1');
    }

    if (options.columns) {
        worksheet.columns = options.columns;
    }

    worksheet.addRows(data);

    await workbook.xlsx.writeFile(filePath);

    return filePath;
}

The expected behaviour:
The styling should not change for unmodified cells, between input and output.
Possible solution (optional, but very helpful):

I have attached the two files. Note the initial one was created in Numbers and exported as xlsx. The second was slightly modified to take out data that was not to be shared.
my-template.xlsx
output.xlsx

Decided to dig a bit further. The first cell on the first row has the following style:
{
  "numFmt": "@",
  "font": {
    "size": 11,
    "color": {
      "indexed": 9
    },
    "name": "Calibri"
  },
  "border": {
    "left": {
      "style": "thin",
      "color": {
        "indexed": 11
      }
    },
    "right": {
      "style": "thin",
      "color": {
        "indexed": 11
      }
    },
    "top": {
      "style": "thin",
      "color": {
        "indexed": 11
      }
    },
    "bottom": {
      "style": "thin",
      "color": {
        "indexed": 11
      }
    }
  },
  "fill": {
    "type": "pattern",
    "pattern": "solid",
    "fgColor": {
      "indexed": 10
    }
  },
  "alignment": {
    "vertical": "bottom"
  }
}

What I notice is the colours are using indexed values, rather than hex values. I could not see any indication of indexed colour support in the docs and no evidence that exceljs tries converting the indexed values to hex values.
Extracting the source xlsx I do see an xl/styles.xml document. which contains the following block:
	<colors>
		<indexedColors>
			<rgbColor rgb="ff000000" />
			<rgbColor rgb="ffffffff" />
			<rgbColor rgb="ffff0000" />
			<rgbColor rgb="ff00ff00" />
			<rgbColor rgb="ff0000ff" />
			<rgbColor rgb="ffffff00" />
			<rgbColor rgb="ffff00ff" />
			<rgbColor rgb="ff00ffff" />
			<rgbColor rgb="ff000000" />
			<rgbColor rgb="ffffffff" />
			<rgbColor rgb="ff3f6797" />
			<rgbColor rgb="ffaaaaaa" />
		</indexedColors>
	</colors>

The colour as indexed 10 is "3f6797", which is what is shown in the original.
In the output file, the indexed colours are indeed different, with no reference to colour '3f6797':
		<indexedColors>
			<rgbColor rgb="ff000000" />
			<rgbColor rgb="ffffffff" />
			<rgbColor rgb="ffff0000" />
			<rgbColor rgb="ff00ff00" />
			<rgbColor rgb="ff0000ff" />
			<rgbColor rgb="ffffff00" />
			<rgbColor rgb="ffff00ff" />
			<rgbColor rgb="ff00ffff" />
			<rgbColor rgb="ff000000" />
			<rgbColor rgb="ffffffff" />
			<rgbColor rgb="ffff0000" />
			<rgbColor rgb="ff00ff00" />
			<rgbColor rgb="ffaaaaaa" />
		</indexedColors>

+1
Mine is similarly because the original file is using indexed colors that are somehow getting overwritten

I have the same problem, turn out the cause is Numbers's xlsx file. After change to Excel's xlsx file problem fixed


1.1.0 beta1: Javascript injection bug (possible XSS vulnerability) with malicious file uploads

I will not discuss details here, please contact me at tomreyn at megaglest d0t org for details.
(I would have contacted you but there is no public information on how to report security issues to you - maybe this could be added to the website or wiki, ideally in the form of an e-mail address and a corresponding OpenPGP key).

Yeah, the security-related workflow is still not very well set up (http://www.elkarte.net/community/index.php?topic=3808.0), feel free to drop me an email at<EMAIL_ADDRESS>

I have just made technical details available to emanuele45 by e-mail. This e-mail also discusses the suggested security incident handling and security patch development work flows.

I have the fix for that ready, I have just to apply it on the public repo before pushing the release.
I'm not sure I'll be able to pack everything before the 15th, likely it will be the week after.

emanuele45:

I have the fix for that ready, I have just to apply it on the public repo before pushing the release.
I'm not sure I'll be able to pack everything before the 15th, likely it will be the week after.

Thanks for the update, Emanuele. By 'release', do you mean another beta
or a stable release? I will try to find some time to test another beta
if there will be one.
Tom

Beta 2
The stable needs at least B2, maybe B3 and a couple of RC.
I hope in the next pair of months to speed up a bit again and develop
the idea of automate the release process, that alone would be a very
useful thing. nods


Add Processes() to client

Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

Codecov Report

Merging #941 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #941   +/-   ##
=======================================
  Coverage   59.55%   59.55%
=======================================
  Files           5        5
  Lines         759      759
=======================================
  Hits          452      452
  Misses        199      199
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ec5c30...ff54c88. Read the comment docs.

LGTM


CIS Red Hat Enterprise Linux 8 Benchmark v3.0.0

Feature Request or Enhancement

Feature []

Summary of Request
The DRAFT CIS Red Hat Enterprise Linux 8 Benchmark v3.0.0 is available for download and review
This consensus period is scheduled to close on 19 October 2023, pending any new comments and open tickets.

Hi
Im just finishing off V3 this week, it has taken almost a complete rewrite, due to all the changes. At the same time i have updates the audit as well.
This will be in pre-release to subscribers before releasing to the community in approx 3 months.
Thanks
uk-bolly

This will be in pre-release to subscribers before releasing to the community in approx 3 months.

I'm also interested ...What is involved in becoming a subscriber?  Which git repo tag/branch is used for this V3 pre-release version?
Thanks

This will be in pre-release to subscribers before releasing to the community in approx 3 months.

I'm also interested ...What is involved in becoming a subscriber? Which git repo tag/branch is used for this V3 pre-release version? Thanks

hi @toddtherod
The latest release remediation code is in a restricted repo currently only available to subscribers to lockdown enterprise. While the audit code is available now in the public repo.
There is more information about the subscription at https://lockdownenterprise.com.
I hope that helps, if you have any questions feel free to ask here or join the discord community and find out more.
Discord Server
thanks
uk-bolly

I'm testing the devel branch since 3.0.0 was merged by
https://github.com/ansible-lockdown/RHEL8-CIS/pull/351

Raising a few eyebrows...


factories for everything

Replace load_model and such with factories, encapsulating the configuration.

related to this: add support to specify a learning rate scheduler.

PR: https://github.com/mila-iqia/cookiecutter-pyml/pull/100

done in #100


Make glamorous work out of the box with preact

Original issue: https://github.com/developit/preact/pull/653#issuecomment-297111106
At the moment there are a couple of snags while working with preact:

preact doesn't handle the autoFocus attribute in the same way that react does, and, at the moment, does not declare that autoFocus (it uses autofocus) is a valid prop on html intrinsic elements in its typescript definition. Glamorous, on the other hand, only whitelists autoFocus as a prop to be passed on to the intrinsic element, so it does not pass autofocus on. @kentcdodds suggested using forwardProps, but I'm not sure how to use that in this case just yet and it seems like it'd be a hack.
React is a peer-dependency of glamorous, which means you get a warning if you don't have it installed.
Glamorous requires preact-compat. Ideally it would work w/o it.

I've created a small glamorous version for preact that skips all the attributes check.
https://www.npmjs.com/package/preact-glam
I will dig into how to enable compatibility with preact for glamorous out of the box. That would be awesome


heap-use-after-free in ex_cbuffer

Hello.
I found a heap-use-after-free bug in vim.
Please confirm.
Thanks.
Summary: heap-use-after-free
OS: CentOS 7 64bit
Version: b254af3
PoC Download: free_ex_cbuffer.zip
Steps to reproduce:
1.Download the .POC files.
2.Compile the source code with ASan.
3.Execute the following command
: ./vim -u NONE -Z -X -e -s -S $POC -c :qa!
=================================================================
==22864==ERROR: AddressSanitizer: heap-use-after-free on address 0x61a00001b088 at pc 0x000000ee0956 bp 0x7ffe1d926970 sp 0x7ffe1d926968
READ of size 4 at 0x61a00001b088 thread T0
    #0 0xee0955 in ex_cbuffer /home/karas/vim/src/quickfix.c:5569:32
    #1 0x847da1 in do_one_cmd /home/karas/vim/src/ex_docmd.c:2908:2
    #2 0x82727d in do_cmdline /home/karas/vim/src/ex_docmd.c:1071:17
    #3 0x813fb7 in do_source /home/karas/vim/src/ex_cmds2.c:4411:5
    #4 0x810477 in cmd_source /home/karas/vim/src/ex_cmds2.c:4024:14
    #5 0x810596 in ex_source /home/karas/vim/src/ex_cmds2.c:3999:2
    #6 0x847da1 in do_one_cmd /home/karas/vim/src/ex_docmd.c:2908:2
    #7 0x82727d in do_cmdline /home/karas/vim/src/ex_docmd.c:1071:17
    #8 0x82c835 in do_cmdline_cmd /home/karas/vim/src/ex_docmd.c:671:12
    #9 0x1658084 in exe_commands /home/karas/vim/src/main.c:2953:2
    #10 0x1651bc6 in vim_main2 /home/karas/vim/src/main.c:800:2
    #11 0x1642d2d in main /home/karas/vim/src/main.c:429:12
    #12 0x7f24abc4282f in __libc_start_main /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:291
    #13 0x41aaa8 in _start (/home/karas/vim/src/vim+0x41aaa8)

0x61a00001b088 is located 8 bytes inside of 1216-byte region [0x61a00001b080,0x61a00001b540)
freed by thread T0 here:
    #0 0x4baa50 in __interceptor_cfree.localalias.0 (/home/karas/vim/src/vim+0x4baa50)
    #1 0xbf0b8b in vim_free /home/karas/vim/src/misc2.c:1801:2
    #2 0xe96e04 in ll_free_all /home/karas/vim/src/quickfix.c:1419:2
    #3 0xe967ba in qf_free_all /home/karas/vim/src/quickfix.c:1432:2
    #4 0x148f76a in win_free /home/karas/vim/src/window.c:4692:5
    #5 0x14abdf4 in win_free_mem /home/karas/vim/src/window.c:2572:5
    #6 0x1475d99 in win_close /home/karas/vim/src/window.c:2413:10
    #7 0x5062cf in do_buffer /home/karas/vim/src/buffer.c:1456:10
    #8 0x50d85f in do_bufdel /home/karas/vim/src/buffer.c:1133:8
    #9 0x89ad33 in ex_bunload /home/karas/vim/src/ex_docmd.c:5535:19
    #10 0x847da1 in do_one_cmd /home/karas/vim/src/ex_docmd.c:2908:2
    #11 0x82727d in do_cmdline /home/karas/vim/src/ex_docmd.c:1071:17
    #12 0x9bc1d0 in apply_autocmds_group /home/karas/vim/src/fileio.c:9719:2
    #13 0x983745 in apply_autocmds /home/karas/vim/src/fileio.c:9253:12
    #14 0xedf37b in ex_cbuffer /home/karas/vim/src/quickfix.c:5530:28
    #15 0x847da1 in do_one_cmd /home/karas/vim/src/ex_docmd.c:2908:2
    #16 0x82727d in do_cmdline /home/karas/vim/src/ex_docmd.c:1071:17
    #17 0x813fb7 in do_source /home/karas/vim/src/ex_cmds2.c:4411:5
    #18 0x810477 in cmd_source /home/karas/vim/src/ex_cmds2.c:4024:14
    #19 0x810596 in ex_source /home/karas/vim/src/ex_cmds2.c:3999:2
    #20 0x847da1 in do_one_cmd /home/karas/vim/src/ex_docmd.c:2908:2
    #21 0x82727d in do_cmdline /home/karas/vim/src/ex_docmd.c:1071:17
    #22 0x82c835 in do_cmdline_cmd /home/karas/vim/src/ex_docmd.c:671:12
    #23 0x1658084 in exe_commands /home/karas/vim/src/main.c:2953:2
    #24 0x1651bc6 in vim_main2 /home/karas/vim/src/main.c:800:2
    #25 0x1642d2d in main /home/karas/vim/src/main.c:429:12
    #26 0x7f24abc4282f in __libc_start_main /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:291

previously allocated by thread T0 here:
    #0 0x4babd8 in malloc (/home/karas/vim/src/vim+0x4babd8)
    #1 0xbece08 in lalloc /home/karas/vim/src/misc2.c:954:21
    #2 0xbecd57 in alloc /home/karas/vim/src/misc2.c:852:13
    #3 0xe9b711 in ll_new_list /home/karas/vim/src/quickfix.c:1536:23
    #4 0xe9200f in ll_get_or_alloc_list /home/karas/vim/src/quickfix.c:1564:16
    #5 0xedefb6 in ex_cbuffer /home/karas/vim/src/quickfix.c:5514:7
    #6 0x847da1 in do_one_cmd /home/karas/vim/src/ex_docmd.c:2908:2
    #7 0x82727d in do_cmdline /home/karas/vim/src/ex_docmd.c:1071:17
    #8 0x813fb7 in do_source /home/karas/vim/src/ex_cmds2.c:4411:5
    #9 0x810477 in cmd_source /home/karas/vim/src/ex_cmds2.c:4024:14
    #10 0x810596 in ex_source /home/karas/vim/src/ex_cmds2.c:3999:2
    #11 0x847da1 in do_one_cmd /home/karas/vim/src/ex_docmd.c:2908:2
    #12 0x82727d in do_cmdline /home/karas/vim/src/ex_docmd.c:1071:17
    #13 0x82c835 in do_cmdline_cmd /home/karas/vim/src/ex_docmd.c:671:12
    #14 0x1658084 in exe_commands /home/karas/vim/src/main.c:2953:2
    #15 0x1651bc6 in vim_main2 /home/karas/vim/src/main.c:800:2
    #16 0x1642d2d in main /home/karas/vim/src/main.c:429:12
    #17 0x7f24abc4282f in __libc_start_main /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:291

SUMMARY: AddressSanitizer: heap-use-after-free /home/karas/vim/src/quickfix.c:5569:32 in ex_cbuffer
Shadow bytes around the buggy address:
  0x0c347fffb5c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c347fffb5d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c347fffb5e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c347fffb5f0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c347fffb600: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x0c347fffb610: fd[fd]fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c347fffb620: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c347fffb630: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c347fffb640: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c347fffb650: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c347fffb660: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Heap right redzone:      fb
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack partial redzone:   f4
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==22864==ABORTING

=================
[Acknowledgement]
This work was supported by ICT R&D program of MSIP/IITP. [R7518-16-1001, Innovation hub for high Performance Computing]

Hi,
On Mon, Dec 18, 2017 at 4:19 PM, gy741<EMAIL_ADDRESS>wrote:

Hello.
I found a heap-use-after-free bug in vim.
Please confirm.
Thanks.
Summary: heap-use-after-free
OS: CentOS 7 64bit
Version: b254af3
PoC Download: free_ex_cbuffer.zip

When I uncompress this file, the resulting file contains some undecipherable
data. Can you attach a sample Vim script to reproduce this problem?
Thanks,
Yegappan

Steps to reproduce:
1.Download the .POC files.
2.Compile the source code with ASan.
3.Execute the following command
: ./vim -u NONE -Z -X -e -s -S $POC -c :qa!
=================================================================
==22864==ERROR: AddressSanitizer: heap-use-after-free on address
0x61a00001b088 at pc 0x000000ee0956 bp 0x7ffe1d926970 sp 0x7ffe1d926968
READ of size 4 at 0x61a00001b088 thread T0
#0 0xee0955 in ex_cbuffer /home/karas/vim/src/quickfix.c:5569:32
#1 0x847da1 in do_one_cmd /home/karas/vim/src/ex_docmd.c:2908:2
#2 0x82727d in do_cmdline /home/karas/vim/src/ex_docmd.c:1071:17
#3 0x813fb7 in do_source /home/karas/vim/src/ex_cmds2.c:4411:5
#4 0x810477 in cmd_source /home/karas/vim/src/ex_cmds2.c:4024:14
#5 0x810596 in ex_source /home/karas/vim/src/ex_cmds2.c:3999:2
#6 0x847da1 in do_one_cmd /home/karas/vim/src/ex_docmd.c:2908:2
#7 0x82727d in do_cmdline /home/karas/vim/src/ex_docmd.c:1071:17
#8 0x82c835 in do_cmdline_cmd /home/karas/vim/src/ex_docmd.c:671:12
#9 0x1658084 in exe_commands /home/karas/vim/src/main.c:2953:2
#10 0x1651bc6 in vim_main2 /home/karas/vim/src/main.c:800:2
#11 0x1642d2d in main /home/karas/vim/src/main.c:429:12
#12 0x7f24abc4282f in __libc_start_main
/build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:291
#13 0x41aaa8 in _start (/home/karas/vim/src/vim+0x41aaa8)
0x61a00001b088 is located 8 bytes inside of 1216-byte region
[0x61a00001b080,0x61a00001b540)
freed by thread T0 here:
#0 0x4baa50 in __interceptor_cfree.localalias.0
(/home/karas/vim/src/vim+0x4baa50)
#1 0xbf0b8b in vim_free /home/karas/vim/src/misc2.c:1801:2
#2 0xe96e04 in ll_free_all /home/karas/vim/src/quickfix.c:1419:2
#3 0xe967ba in qf_free_all /home/karas/vim/src/quickfix.c:1432:2
#4 0x148f76a in win_free /home/karas/vim/src/window.c:4692:5
#5 0x14abdf4 in win_free_mem /home/karas/vim/src/window.c:2572:5
#6 0x1475d99 in win_close /home/karas/vim/src/window.c:2413:10
#7 0x5062cf in do_buffer /home/karas/vim/src/buffer.c:1456:10
#8 0x50d85f in do_bufdel /home/karas/vim/src/buffer.c:1133:8
#9 0x89ad33 in ex_bunload /home/karas/vim/src/ex_docmd.c:5535:19
#10 0x847da1 in do_one_cmd /home/karas/vim/src/ex_docmd.c:2908:2
#11 0x82727d in do_cmdline /home/karas/vim/src/ex_docmd.c:1071:17
#12 0x9bc1d0 in apply_autocmds_group /home/karas/vim/src/fileio.c:9719:2
#13 0x983745 in apply_autocmds /home/karas/vim/src/fileio.c:9253:12
#14 0xedf37b in ex_cbuffer /home/karas/vim/src/quickfix.c:5530:28
#15 0x847da1 in do_one_cmd /home/karas/vim/src/ex_docmd.c:2908:2
#16 0x82727d in do_cmdline /home/karas/vim/src/ex_docmd.c:1071:17
#17 0x813fb7 in do_source /home/karas/vim/src/ex_cmds2.c:4411:5
#18 0x810477 in cmd_source /home/karas/vim/src/ex_cmds2.c:4024:14
#19 0x810596 in ex_source /home/karas/vim/src/ex_cmds2.c:3999:2
#20 0x847da1 in do_one_cmd /home/karas/vim/src/ex_docmd.c:2908:2
#21 0x82727d in do_cmdline /home/karas/vim/src/ex_docmd.c:1071:17
#22 0x82c835 in do_cmdline_cmd /home/karas/vim/src/ex_docmd.c:671:12
#23 0x1658084 in exe_commands /home/karas/vim/src/main.c:2953:2
#24 0x1651bc6 in vim_main2 /home/karas/vim/src/main.c:800:2
#25 0x1642d2d in main /home/karas/vim/src/main.c:429:12
#26 0x7f24abc4282f in __libc_start_main
/build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:291
previously allocated by thread T0 here:
#0 0x4babd8 in malloc (/home/karas/vim/src/vim+0x4babd8)
#1 0xbece08 in lalloc /home/karas/vim/src/misc2.c:954:21
#2 0xbecd57 in alloc /home/karas/vim/src/misc2.c:852:13
#3 0xe9b711 in ll_new_list /home/karas/vim/src/quickfix.c:1536:23
#4 0xe9200f in ll_get_or_alloc_list
/home/karas/vim/src/quickfix.c:1564:16
#5 0xedefb6 in ex_cbuffer /home/karas/vim/src/quickfix.c:5514:7
#6 0x847da1 in do_one_cmd /home/karas/vim/src/ex_docmd.c:2908:2
#7 0x82727d in do_cmdline /home/karas/vim/src/ex_docmd.c:1071:17
#8 0x813fb7 in do_source /home/karas/vim/src/ex_cmds2.c:4411:5
#9 0x810477 in cmd_source /home/karas/vim/src/ex_cmds2.c:4024:14
#10 0x810596 in ex_source /home/karas/vim/src/ex_cmds2.c:3999:2
#11 0x847da1 in do_one_cmd /home/karas/vim/src/ex_docmd.c:2908:2
#12 0x82727d in do_cmdline /home/karas/vim/src/ex_docmd.c:1071:17
#13 0x82c835 in do_cmdline_cmd /home/karas/vim/src/ex_docmd.c:671:12
#14 0x1658084 in exe_commands /home/karas/vim/src/main.c:2953:2
#15 0x1651bc6 in vim_main2 /home/karas/vim/src/main.c:800:2
#16 0x1642d2d in main /home/karas/vim/src/main.c:429:12
#17 0x7f24abc4282f in __libc_start_main
/build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:291
SUMMARY: AddressSanitizer: heap-use-after-free
/home/karas/vim/src/quickfix.c:5569:32 in ex_cbuffer
Shadow bytes around the buggy address:
0x0c347fffb5c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c347fffb5d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c347fffb5e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c347fffb5f0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c347fffb600: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x0c347fffb610: fd[fd]fd fd fd fd fd fd fd fd fd fd fd fd fd fd
0x0c347fffb620: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
0x0c347fffb630: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
0x0c347fffb640: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
0x0c347fffb650: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
0x0c347fffb660: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable:           00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone:       fa
Heap right redzone:      fb
Freed heap region:       fd
Stack left redzone:      f1
Stack mid redzone:       f2
Stack right redzone:     f3
Stack partial redzone:   f4
Stack after return:      f5
Stack use after scope:   f8
Global redzone:          f9
Global init order:       f6
Poisoned by user:        f7
Container overflow:      fc
Array cookie:            ac
Intra object redzone:    bb
ASan internal:           fe
Left alloca redzone:     ca
Right alloca redzone:    cb
==22864==ABORTING
=================
[Acknowledgement]
This work was supported by ICT R&D program of MSIP/IITP. [R7518-16-1001,
Innovation hub for high Performance Computing]

@vim-ml
Hello,
I do not know.
This is a damaged Vim script and  random data.
Are you unable to reproduce?
@dpelle has experience minimizing test cases.
Thanks.

Although it can be useful to find bugs by throwing a garbage script at Vim, we do need to be able to get a reasonable script to reproduce it.  It's hard enough to track down leaks with valid code.  Unless someone sees what is happening and ideally be able to reproduce it, I would close this issue.

@qy741 wrote:

@dpelle has experience minimizing test cases.

I'll find time to minimize it later today, and hopefully come
up with a short command or script to reproduce this
bug and a few other bugs reported by @qy741.

I can reproduce it with vim-8.0.1406 with this simpler case:
$ ./vim -u NONE -c'sv x' -c'au * * bw' -clb -cq
Vim: Caught deadly signal SEGV

Vim: Finished.
Segmentation fault (core dumped)

$ valgrind --num-callers=50 ./vim -u NONE -e -s -c'sv x' -c'au * * bw' -clb -cq
==7897== Memcheck, a memory error detector
==7897== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==7897== Using Valgrind-3.14.0.GIT and LibVEX; rerun with -h for copyright info
==7897== Command: ./vim -u NONE -e -s -csv\ x -cau\ *\ *\ bw -clb -cq
==7897==
==7897== Invalid read of size 4
==7897==    at 0x5221D3: ex_cbuffer (quickfix.c:5569)
==7897==    by 0x468ABC: do_one_cmd (ex_docmd.c:2908)
==7897==    by 0x464D3D: do_cmdline (ex_docmd.c:1071)
==7897==    by 0x625A4C: exe_commands (main.c:2953)
==7897==    by 0x625A4C: vim_main2 (main.c:800)
==7897==    by 0x6245E4: main (main.c:429)
==7897==  Address 0xce430f8 is 8 bytes inside a block of size 1,216 free'd
==7897==    at 0x4C2ECF0: free (vg_replace_malloc.c:530)
==7897==    by 0x51B9D7: qf_free_all (quickfix.c:1432)
==7897==    by 0x5D60A0: win_free (window.c:4692)
==7897==    by 0x5D3C83: win_free_mem (window.c:2572)
==7897==    by 0x5D3C83: win_close (window.c:2413)
==7897==    by 0x410BD2: do_buffer (buffer.c:1456)
==7897==    by 0x411B9A: do_bufdel (buffer.c:1133)
==7897==    by 0x46F1D3: ex_bunload (ex_docmd.c:5535)
==7897==    by 0x468ABC: do_one_cmd (ex_docmd.c:2908)
==7897==    by 0x464D3D: do_cmdline (ex_docmd.c:1071)
==7897==    by 0x492EA7: apply_autocmds_group (fileio.c:9719)
==7897==    by 0x48B519: apply_autocmds (fileio.c:9253)
==7897==    by 0x5220B7: ex_cbuffer (quickfix.c:5530)
==7897==    by 0x468ABC: do_one_cmd (ex_docmd.c:2908)
==7897==    by 0x464D3D: do_cmdline (ex_docmd.c:1071)
==7897==    by 0x625A4C: exe_commands (main.c:2953)
==7897==    by 0x625A4C: vim_main2 (main.c:800)
==7897==    by 0x6245E4: main (main.c:429)
==7897==  Block was alloc'd at
==7897==    at 0x4C2DBF6: malloc (vg_replace_malloc.c:299)
==7897==    by 0x4D4E87: lalloc (misc2.c:954)
==7897==    by 0x522009: ll_new_list (quickfix.c:1536)
==7897==    by 0x522009: ll_get_or_alloc_list (quickfix.c:1564)
==7897==    by 0x522009: ex_cbuffer (quickfix.c:5514)
==7897==    by 0x468ABC: do_one_cmd (ex_docmd.c:2908)
==7897==    by 0x464D3D: do_cmdline (ex_docmd.c:1071)
==7897==    by 0x625A4C: exe_commands (main.c:2953)
==7897==    by 0x625A4C: vim_main2 (main.c:800)
==7897==    by 0x6245E4: main (main.c:429)
(more errors after that)

It's again a case of using a rogue autocommand that
wipes out the buffer.

Hi Dominique,
On Tue, Dec 19, 2017 at 12:31 AM, Dominique Pellé
<EMAIL_ADDRESS>wrote:

I can reproduce it with vim-8.0.1406 with this simpler case:
$ ./vim -u NONE -c'sv x' -c'au * * bw' -clb -cq
Vim: Caught deadly signal SEGV

Thanks for the simplified test. I am attaching a patch for this
crash with a test.
Regards,
Yegappan

Vim: Finished.
Segmentation fault (core dumped)
$ valgrind --num-callers=50 ./vim -u NONE -e -s -c'sv x' -c'au * * bw' -clb
-cq
==7897== Memcheck, a memory error detector
==7897== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==7897== Using Valgrind-3.14.0.GIT and LibVEX; rerun with -h for copyright
info
==7897== Command: ./vim -u NONE -e -s -csv\ x -cau\ *\ *\ bw -clb -cq
==7897==
==7897== Invalid read of size 4
==7897==    at 0x5221D3: ex_cbuffer (quickfix.c:5569)
==7897==    by 0x468ABC: do_one_cmd (ex_docmd.c:2908)
==7897==    by 0x464D3D: do_cmdline (ex_docmd.c:1071)
==7897==    by 0x625A4C: exe_commands (main.c:2953)
==7897==    by 0x625A4C: vim_main2 (main.c:800)
==7897==    by 0x6245E4: main (main.c:429)
==7897==  Address 0xce430f8 is 8 bytes inside a block of size 1,216 free'd
==7897==    at 0x4C2ECF0: free (vg_replace_malloc.c:530)
==7897==    by 0x51B9D7: qf_free_all (quickfix.c:1432)
==7897==    by 0x5D60A0: win_free (window.c:4692)
==7897==    by 0x5D3C83: win_free_mem (window.c:2572)
==7897==    by 0x5D3C83: win_close (window.c:2413)
==7897==    by 0x410BD2: do_buffer (buffer.c:1456)
==7897==    by 0x411B9A: do_bufdel (buffer.c:1133)
==7897==    by 0x46F1D3: ex_bunload (ex_docmd.c:5535)
==7897==    by 0x468ABC: do_one_cmd (ex_docmd.c:2908)
==7897==    by 0x464D3D: do_cmdline (ex_docmd.c:1071)
==7897==    by 0x492EA7: apply_autocmds_group (fileio.c:9719)
==7897==    by 0x48B519: apply_autocmds (fileio.c:9253)
==7897==    by 0x5220B7: ex_cbuffer (quickfix.c:5530)
==7897==    by 0x468ABC: do_one_cmd (ex_docmd.c:2908)
==7897==    by 0x464D3D: do_cmdline (ex_docmd.c:1071)
==7897==    by 0x625A4C: exe_commands (main.c:2953)
==7897==    by 0x625A4C: vim_main2 (main.c:800)
==7897==    by 0x6245E4: main (main.c:429)
==7897==  Block was alloc'd at
==7897==    at 0x4C2DBF6: malloc (vg_replace_malloc.c:299)
==7897==    by 0x4D4E87: lalloc (misc2.c:954)
==7897==    by 0x522009: ll_new_list (quickfix.c:1536)
==7897==    by 0x522009: ll_get_or_alloc_list (quickfix.c:1564)
==7897==    by 0x522009: ex_cbuffer (quickfix.c:5514)
==7897==    by 0x468ABC: do_one_cmd (ex_docmd.c:2908)
==7897==    by 0x464D3D: do_cmdline (ex_docmd.c:1071)
==7897==    by 0x625A4C: exe_commands (main.c:2953)
==7897==    by 0x625A4C: vim_main2 (main.c:800)
==7897==    by 0x6245E4: main (main.c:429)
(more errors after that)
It's again a case of using a rogue autocommand that
wipes out the buffer.

diff --git a/src/quickfix.c b/src/quickfix.c
index 6e80ddfca..1a9da025c 100644
--- a/src/quickfix.c
+++ b/src/quickfix.c
@@ -5520,14 +5520,6 @@ ex_cbuffer(exarg_T *eap)
#endif
int		res;

if (eap->cmdidx == CMD_lbuffer || eap->cmdidx == CMD_lgetbuffer

  || eap->cmdidx == CMD_laddbuffer)

{
qi = ll_get_or_alloc_list(curwin);
if (qi == NULL)

  return;

}

#ifdef FEAT_AUTOCMD
switch (eap->cmdidx)
{
@@ -5549,6 +5541,15 @@ ex_cbuffer(exarg_T *eap)
}
#endif

if (eap->cmdidx == CMD_lbuffer

  || eap->cmdidx == CMD_lgetbuffer

  || eap->cmdidx == CMD_laddbuffer)

{
qi = ll_get_or_alloc_list(curwin);
if (qi == NULL)

  return;

}
if (*eap->arg == NUL)
buf = curbuf;
else if (*skipwhite(skipdigits(eap->arg)) == NUL)
diff --git a/src/testdir/test_quickfix.vim b/src/testdir/test_quickfix.vim
index 8d0c198ba..c5e902130 100644
--- a/src/testdir/test_quickfix.vim
+++ b/src/testdir/test_quickfix.vim
@@ -3031,3 +3031,10 @@ func Test_ll_window_ctx()
enew | only
endfunc

+" The following test used to crash vim
+func Test_lbuffer_crash()

sp Xtest
au QuickFixCmdPre * bw
lbuffer
au! QuickFixCmdPre
+endfunc

Hi Bram,
On Mon, Dec 18, 2017 at 11:42 PM, Bram Moolenaar
<EMAIL_ADDRESS>wrote:

Although it can be useful to find bugs by throwing a garbage script at Vim,
we do need to be able to get a reasonable script to reproduce it. It's hard
enough to track down leaks with valid code. Unless someone sees what is
happening and ideally be able to reproduce it, I would close this issue.

I have the fixes for all the reported crashes. All of them are caused by an
autocmd removing the window/buffer which is still being used by the
quickfix code. I am trying to come up with simple test cases to reproduce
the crashes.
Regards,
Yegappan

Yegappan wrote:

On Mon, Dec 18, 2017 at 11:42 PM, Bram Moolenaar
<EMAIL_ADDRESS>wrote:

Although it can be useful to find bugs by throwing a garbage script at Vim,
we do need to be able to get a reasonable script to reproduce it. It's hard
enough to track down leaks with valid code. Unless someone sees what is
happening and ideally be able to reproduce it, I would close this issue.

I have the fixes for all the reported crashes. All of them are caused by an
autocmd removing the window/buffer which is still being used by the
quickfix code. I am trying to come up with simple test cases to reproduce
the crashes.

Very good.  I'll hold off from the other reported problems related to
quickfix then.
--
In a world without fences, who needs Gates and Windows?
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Yegappan wrote:

On Tue, Dec 19, 2017 at 12:31 AM, Dominique Pell=C3=A9
<EMAIL_ADDRESS>wrote:

I can reproduce it with vim-8.0.1406 with this simpler case:
$ ./vim -u NONE -c'sv x' -c'au * * bw' -clb -cq
Vim: Caught deadly signal SEGV

Thanks for the simplified test. I am attaching a patch for this
crash with a test.

Thanks.  I had just made a fix for this, it's very similar.
--
Don't drink and drive.  You might hit a bump and spill your beer.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


How to add Limit, Offset and Order By clause to Raw chain method?

Your Question
The query that I am trying is
err = gdb.Raw(sqlQuery, qp.WhereArgs...).Offset(qp.Offset).Limit(qp.Limit).Order(qp.Order).Scan(&dbRecords).Error
This was working fine before but after migrating to v1.24.0 these clauses are not working. Even after applying the Limit, all records are getting returned.
Docs here https://gorm.io/docs/method_chaining.html mention that Raw can’t be used with other chainable methods to build SQL.
I need to use union all query and so I am using Raw. I have tried adding Limit order by in the raw query itself like this
    querySuffix := " select * from temp1 R0 " +
	whereClause1 +
	" union all " +
	" select * from security_audit_entry_data S0" +
	whereClause2 +
	") T0"

queryClause := " offset " + strconv.Itoa(qp.Offset) + " limit " + strconv.Itoa(qp.Limit) + " order by " + qp.Order

sqlQuery := queryPrefix + querySuffix + queryClause.

err = reusableDB.Debug().Raw(sqlCount, qp.WhereArgs...).Count(&count).Error
This is giving error
near "offset": syntax error

The document you expected this should be explained
https://gorm.io/docs/method_chaining.html

Expected answer

If you're still looking for a workaround, this issue includes an example.


Add monokai theme background

Having a black / drak background is useful

It's already there. Go to color themes and choose any of the theme you want. Monokai is also supported


improvements to incentives try 3

This takes some of the improvements of #317 and puts them into the old algo

Not so conservative lol

If I understood correctly, the change made in this PR uses an accumulation store to calculate the total locked amount and use it to calculate the reward per lockup, instead of iterate over them and sum up. I think this is a simple enough change to merge prelaunch.

I thought so as well, except we found out the problem is it fails simulation bank invariants


Needed policy and procedures

Here's an issue to keep track of smaller thing we may want to have policy and procedures documented for.

Astropy Project Calendar. Who has access, what events go there, how to indicate level of openness.
mailing lists: astropy users, astropy-dev, astropy-core-maintainers, astropy-coordinators, etc.

Maybe can add to https://github.com/astropy/astropy-project/blob/main/policies/permissions.md ?


Please add a Disable / Remove button for coins in Dashboard

Image just to give an idea :)

pushed this in latest commit.


Custom Variables as intermediate outputs

Is it possible to set the custom variable in one stage, and later on apply it somewhere else? Or even throughout the whole release pipeline?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 611642f0-881f-10b9-ae94-3c562001d1f0
Version Independent ID: 41efb94b-4c7a-64a3-b23b-70c8634ae727
Content: Release variables  and debugging - Azure Pipelines
Content Source: docs/pipelines/release/variables.md
Product: devops
GitHub Login: @alexhomer1
Microsoft Alias: ahomer

Thank you for your feedback. I have passed this on to the product team for advice.

Passing variables across stages is not supported. You will have to write it to a persistent store and retrieve it in subsequent stage(s)


CSV import not handling commas correctly

a CSV field that is encapsulated in double quotes is not handled properly when it contains a comma.
for example, the following CSV line has 4 elements but the parser indicates 5 because of the comma in field 2 although it is encapsulated in double quotes:
GO:0006351,"transcription, DNA-templated",biological_process|biological_process_or_activity|biological_entity|named_thing,GO:0006351
thanks!

@PhillipsOwen Thanks for reporting this bug.
This is now fixed on master.


Add betabinomial logpmf/pmf and tests

Similar to  #5608, this PR adds logpmf/pmf for betabinomial in jax.scipy.stats
Tests included.

I'm runningn into a small problem with this PR re: testing as per @jakevdp 's suggestion.  When I use jtu.rand_default in the test, the parameters generated look something like the following:

k = [1., -0.38,  1.36, -0.84]
n = [[ 2.0,  4.23,  0.7,  -1.07],
     [ 0.01,  0.7,   2.08,  2.5 ],
     [-0.92,  0.74, -3.81, -0.54]]

a = [[ 2.77, -0.7,   3.07, -4.9 ],
     [-2.61, -3.69, -3.24, -0.5 ],
     [ 1.78,  5.4,  -1.03,  1.2 ]]

b = [[-0.42],
     [-0.68],
     [-0.04]]

loc = [[0.],
       [ 3.06],
       [-4.31]]

If I compare my implementation of the logpmf (without the where in the return call), I get something like...
import jax.numpy as jnp
from jax import lax
import jax.scipy as lsp

import scipy as osp
import numpy as np

k, n, a, b, loc = map(jnp.array, [k, n, a, b, loc])
lsp.stats.betabinom.logpmf(k=k, n=n, a=a, b=b, loc=loc)

>>>DeviceArray([[ -1.2188828,        -inf,   0.3208853,         nan],
                             [ -7.949671 , -13.266653 , -10.89188  ,  -6.595767 ],
                             [ -1.5104122,  -1.5108628,         nan,  -3.7848833]],            dtype=float32)

Comparing this directly with scipy's implementation of the logpmf
k = np.floor(k) - loc
combiln = -np.log(n + 1) - osp.special.betaln(n - k + 1, k + 1)
combiln + osp.special.betaln(k + a, n - k + b) - osp.special.betaln(a, b)
>>>array([[ -1.2188818,        -inf,   0.3208878,         nan],
                 [ -7.949671 , -13.266655 , -10.891884 ,  -6.595765 ],
                 [ -1.5104126,  -1.5108645,         nan,  -3.784882 ]],
                dtype=float32)

Nice, looks similar.  However, calling scipy's betabinom logpmf directly yeilds nan
osp.stats.betabinom.logpmf(k=k, n=n, a=a, b=b, loc=loc)
>>>array([[nan, nan, nan, nan],
                 [nan, nan, nan, nan],
                 [nan, nan, nan, nan]])

Which is problematic because this is what is compared in the tests.
Running tests under Python 3.8.5: /Users/demetri/opt/miniconda3/envs/jax/bin/python
[ RUN      ] LaxBackedScipyStatsTests.testBetaBinomLogPmf_float32[4]_float32[3,4]_float32[3,4]_float32[3,1]_float32[3,1]
W0204 14:08:25.821909<PHONE_NUMBER> xla_bridge.py:135] No GPU/TPU found, falling back to CPU. (Set TF_CPP_MIN_LOG_LEVEL=0 and rerun for more info.)
[  FAILED  ] LaxBackedScipyStatsTests.testBetaBinomLogPmf_float32[4]_float32[3,4]_float32[3,4]_float32[3,1]_float32[3,1]
======================================================================
FAIL: testBetaBinomLogPmf_float32[4]_float32[3,4]_float32[3,4]_float32[3,1]_float32[3,1] (__main__.LaxBackedScipyStatsTests)
LaxBackedScipyStatsTests.testBetaBinomLogPmf_float32[4]_float32[3,4]_float32[3,4]_float32[3,1]_float32[3,1]
testBetaBinomLogPmf_float32[4]_float32[3,4]_float32[3,4]_float32[3,1]_float32[3,1](shapes=((4,), (3, 4), (3, 4), (3, 1), (3, 1)), dtypes=(<class 'numpy.float32'>, <class 'numpy.float32'>, <class 'numpy.float32'>, <class 'numpy.float32'>, <class 'numpy.float32'>))
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/demetri/opt/miniconda3/envs/jax/lib/python3.8/site-packages/absl_py-0.11.0-py3.8.egg/absl/testing/parameterized.py", line 282, in bound_param_test
    return test_method(self, **testcase_params)
  File "tests/scipy_stats_test.py", line 433, in testBetaBinomLogPmf
    self._CheckAgainstNumpy(scipy_fun, lax_fun, args_maker, check_dtypes=False,
  File "/Users/demetri/gitrepos/jax/jax/test_util.py", line 915, in _CheckAgainstNumpy
    self.assertAllClose(numpy_ans, lax_ans, check_dtypes=check_dtypes,
  File "/Users/demetri/gitrepos/jax/jax/test_util.py", line 847, in assertAllClose
    self.assertArraysAllClose(x, y, check_dtypes=False, atol=atol, rtol=rtol)
  File "/Users/demetri/gitrepos/jax/jax/test_util.py", line 814, in assertArraysAllClose
    _assert_numpy_allclose(x, y, atol=atol, rtol=rtol)
  File "/Users/demetri/gitrepos/jax/jax/test_util.py", line 133, in _assert_numpy_allclose
    np.testing.assert_allclose(a, b, **kw)
  File "/Users/demetri/opt/miniconda3/envs/jax/lib/python3.8/site-packages/numpy-1.19.5-py3.8-macosx-10.9-x86_64.egg/numpy/testing/_private/utils.py", line 1527, in assert_allclose
    assert_array_compare(compare, actual, desired, err_msg=str(err_msg),
  File "/Users/demetri/opt/miniconda3/envs/jax/lib/python3.8/site-packages/numpy-1.19.5-py3.8-macosx-10.9-x86_64.egg/numpy/testing/_private/utils.py", line 764, in assert_array_compare
    flagged = func_assert_same_pos(x, y, func=isnan, hasval='nan')
  File "/Users/demetri/opt/miniconda3/envs/jax/lib/python3.8/site-packages/numpy-1.19.5-py3.8-macosx-10.9-x86_64.egg/numpy/testing/_private/utils.py", line 740, in func_assert_same_pos
    raise AssertionError(msg)
AssertionError:
Not equal to tolerance rtol=0.0005, atol=0.0005

x and y nan location mismatch:
 x: array([[nan, nan, nan, nan],
       [nan, nan, nan, nan],
       [nan, nan, nan, nan]])
 y: array([[ -2.0639  ,   4.959385,  -4.269639,        nan],
       [-11.134994, -13.355612, -10.916795,  -6.697731],
       [ -1.443631,  -1.582576,        nan,  -3.863479]], dtype=float32)

It looks like scipy [does a check to see if all of n, a, and b are positive.  If not, I think it returns nan.  This might be to prevent singularities in the betaln call since the beta function is defined for non negative integers.
So, what should I do in this case?  Should I implement the same sort of argcheck in the logpmf?  If I don't the tests won't pass with jtu.rand_default.

I'll also add that the tests pass if I do as other tests do and clip some of the variables.
    def args_maker():
      k, n, a, b, loc = map(rng, shapes, dtypes)
      k = np.floor(k)
      a = np.clip(a, a_min = 0.1, a_max = None)
      b = np.clip(b, a_min = 0.1, a_max = None)
      n = np.ceil(n)
      loc = np.floor(loc)
      return [k, n, a, b, loc]

Hmm... I don't think scipy's behavior here is necessarily something we want to emulate here.
I think it's fine to only test positive values against scipy and add a separate test that explicitly checks that out-of-range inputs lead to inf or nan where appropriate. What do you think?

Yep, I agree.  Let me see if I can write something up for this then.

I don't see any other examples of testing distributions to see if poor parameterizations result in inf or nan.  For instance, the testBernoulliLogPmf test forces p to be between 0 and 1 through application of expit.  Additionally, mu in testPoissonLogPmf is forced to be positive as well.
If we want to test that the distributions fail in predictable ways:
a) What would be the best way of doing that?  Should I just do something like self.assertAlClose( inf, lax_fun(k,n,a,b,loc) (there doesn't seem to be an assertAllEqual).
b) Should other distributions (i.e. all bounded distributions like the poisson and bernoulli) be checked in this way?

You're right that we don't have great test coverage for out-of-bound inputs... if you want to ignore that in this case, it's probably OK.
If you do want to tackle it, I'd probably use self.assertArraysEqual() (which is a thin wrapper around np.testing.assert_array_equal).
Adding such tests to other distributions would be worthwhile as well; it might be worth using something like the op_record approach in lax_numpy_test.py in order to have a single test of invalid values for multiple distributions. But that doesn't have to be part of this PR if you don't want to go down that route!

OK, this is at a place where I am happy with it.  I'm going to open another issue re: some differences with original scipy and lax scipy.

I'm going to run some additional tests on GPU & TPU backends – I'll let you know if those uncover any issues.

Sweet. Once you run the GPU/TPU checks then I will squash.  Just gimme the thumbs up when ready

Everything looks good! We'll get this merged.

Thanks for the contribution! Just FYI I ended up having to do a minor patch to make the new function work with older scipy, which is currently not tested via github CI (I have a PR at #5654 to rectify this).

Cool.  Is there anything I should know for future PRs?

Just that we need compatibility back to scipy 1.2... betabinom was added in 1.4. The updated test in #5654 should catch that for future PRs.


Drop Python 3.6 support

Python 3.6 is way past its EOL date. It is also not being tested in CI. I think it should be dropped.

This was done in https://github.com/elastic/elastic-transport-python/releases/tag/v8.11.0, thanks. 8.15 should drop Python 3.7.


Index for Matching People to citation searches

When users search for words that are found in citations, we need to respond with associated people as well.  @jrmerz suggested that the elastic search best practice for this is probably to create a new index that is researcher based and indices all citations.  I suppose that this could also just be added to the current people card, since realistically the scores from the citation should be incorporated with the scores from the persons page as well. @Vensberg has volunteered to help @jtyzzer with weights if that is needed.

This is currently using the following indexes which are calculated by the post-process.js class:
    "lastCitation.publication" : {
      "type" : "text"
    },

    "lastCitation.label" : {
      "type" : "text"
    },

    "_.top20Citation.publication" : {
      "type" : "text"
    },

    "_.top20Citation.label" : {
      "type" : "text"
    }


Cannot run on ubuntu

With python (v2.7):
$ python fetchd.py -s 0x467d3b01ca6c94a9a6053c437c9e5310a63589a5 -r 0x2fd4f3ae10608cd6192339e72d4f6a0c182dee22 -n btc --rpcPort 8545 --fetch -d --gasPrice<PHONE_NUMBER>00
Traceback (most recent call last):
  File "fetchd.py", line 9, in <module>
    from pyepm import api, config, __version__
  File "/usr/local/lib/python2.7/dist-packages/pyepm/api.py", line 17, in <module>
    from serpent import get_prefix, decode_datalist
ImportError: cannot import name get_prefix

With python3
$ python3 fetchd.py -s 0x467d3b01ca6c94a9a6053c437c9e5310a63589a5 -r 0x2fd4f3ae10608cd6192339e72d4f6a0c182dee22 -n btc --rpcPort 8545 --fetch -d --gasPrice<PHONE_NUMBER>00
Traceback (most recent call last):
  File "fetchd.py", line 9, in <module>
    from pyepm import api, config, __version__
  File "/usr/local/lib/python3.4/dist-packages/pyepm/api.py", line 13, in <module>
    from colors import colors
ImportError: No module named 'colors'

Works with python 2.7. I think the backport of the modules didn't go so well (colors, StringIO).

@ajunge I also updated the readme in November: https://github.com/ConsenSys/btcrelay-fetchd#recommended

Closing this since there have been several updates since this was filed.  Python 2.7 should work

It wont work in python 2.7. Most of the other dependencies are compatible only with python 3. like eth-hash


[Vue 3] Rendered events do not update when events prop is updated from outside the component

Note: This may be a bug caused by the change to how Vue 3 handles array mutations.

Working on a project that customizes the calendar a lot. One interaction for the user is a click somewhere in the view to add one of three types of events. To achieve this, I am trying to add a "temporary" event to where the user has clicked:
// [... imports, etc.]

// the events passed as a prop
const events = ref(appointments)

// temporary event
const tempEvent = ref()

// handle user click
function onCellClick(ev) {
  tempEvent.value = {
    start: ev.date,
    end: addMinutes(ev.date, 5),
    split: ev.split,
    title: 'Add event',
  }

  // add temporary event to the end of the events array
  events.value = [...appointments, tempEvent.value]
}

The problem I am facing is the VueCal component not updating the rendered events. The internal mutableEvents array does indeed update, but the view does not.
Vue-Cal Version: 4.2.0
Vue Version: 3.0.5

Seems like it was a problem on my end. Managed to get an empty project working. Closing the issue.


Node Import Module Errors

Hi, encountering some errors when importing using the usual way..
import {treeify} from 'treeify'
Node and typescript giving errors.
Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: ..../node_modules/treeify-js/dist/treeify.js require() of ES modules is not supported.
And typescript errors.
Could not find a declaration file for module 'treeify-js'. '..../backend/node_modules/treeify-js/dist/treeify.js' implicitly has an 'any' type. Try npm install @types/treeify-js if it exists or add a new declaration (.d.ts) file containing declare module 'treeify-js';
node error is resolved by deleting from your package.json "type": "module".
The type errors are resolved by adding to your dist folder a file named:
treeify.d.ts
export declare function treeify(data: any[], configure: Object): any; export declare function untreeify(tree: Object, childrenName: string): any;

import like this:
import { treeify } from 'treeify-js'

the package name is treeify-js but not treeify, cus treeify has been used.


Cannot run adult.py

Hi,
I have been unable to run the adult.py script. I downloaded adult.data, adult.test and adult.names from UCI, and beyond removing extra white spaces in the csv files I didn't make any modifications. However, I keep getting this error:
On experiment 0
Traceback (most recent call last):
  File "adult.py", line 472, in <module>
    run_experiments('baseline', num_exp, path_to_save_experiments +'baseline/')
  File "adult.py", line 410, in run_experiments
    X_train, X_test, y_train, y_test, X_gender_train, X_gender_test, y_gender_train, y_gender_test, dataset_orig_train, dataset_orig_test = preprocess_adult_data(seed = i)
  File "adult.py", line 47, in preprocess_adult_data
    dataset_orig = get_adult_data()
  File "adult.py", line 36, in get_adult_data
    df.drop(delete_these, axis=1, inplace=True)
  File "/Users/me/.pyenv/versions/subspace-robust/lib/python3.7/site-packages/pandas/core/frame.py", line 4315, in drop
    errors=errors,
  File "/Users/me/.pyenv/versions/subspace-robust/lib/python3.7/site-packages/pandas/core/generic.py", line 4153, in drop
    obj = obj._drop_axis(labels, axis, level=level, errors=errors)
  File "/Users/me/.pyenv/versions/subspace-robust/lib/python3.7/site-packages/pandas/core/generic.py", line 4188, in _drop_axis
    new_axis = axis.drop(labels, errors=errors)
  File "/Users/me/.pyenv/versions/subspace-robust/lib/python3.7/site-packages/pandas/core/indexes/base.py", line 5591, in drop
    raise KeyError(f"{labels[mask]} not found in axis")
KeyError: "['race_ Amer-Indian-Eskimo' 'race_ Asian-Pac-Islander' 'race_ Black'\n 'race_ Other' 'sex_ Female' 'native-country_ Cambodia'\n 'native-country_ Canada' 'native-country_ China'\n 'native-country_ Columbia' 'native-country_ Cuba'\n 'native-country_ Dominican-Republic' 'native-country_ Ecuador'\n 'native-country_ El-Salvador' 'native-country_ England'\n 'native-country_ France' 'native-country_ Germany'\n 'native-country_ Greece' 'native-country_ Guatemala'\n 'native-country_ Haiti' 'native-country_ Holand-Netherlands'\n 'native-country_ Honduras' 'native-country_ Hong'\n 'native-country_ Hungary' 'native-country_ India' 'native-country_ Iran'\n 'native-country_ Ireland' 'native-country_ Italy'\n 'native-country_ Jamaica' 'native-country_ Japan' 'native-country_ Laos'\n 'native-country_ Mexico' 'native-country_ Nicaragua'\n 'native-country_ Outlying-US(Guam-USVI-etc)' 'native-country_ Peru'\n 'native-country_ Philippines' 'native-country_ Poland'\n 'native-country_ Portugal' 'native-country_ Puerto-Rico'\n 'native-country_ Scotland' 'native-country_ South'\n 'native-country_ Taiwan' 'native-country_ Thailand'\n 'native-country_ Trinadad&Tobago' 'native-country_ United-States'\n 'native-country_ Vietnam' 'native-country_ Yugoslavia'] not found in axis"

Do you have any advice on what I might be doing wrong?
Thank you!

Apologies, I had not noticed I could run the adult_notebook. That's working for me.


Unexpected highlighting behavior when end is not defined

From @mhchem on April 25, 2018 9:20
With this simplified .tmLanguage file, the whole document should be formatted a comment (because I use a begin without and end).
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
    <dict>
        <key>scopeName</key>
        <string>text.test</string>

        <key>patterns</key>
        <array>
            <dict>
                <key>begin</key><string>^.</string>
                <key>name</key><string>comment</string>
            </dict>

            <dict>
                <key>begin</key><string>.</string>
                <key>name</key><string>invalid</string>
            </dict>
        </array>
    </dict>
</plist>

This works fine unless the document contains the word undefined.

I guess this is a "end is undefined" issue where undefined is taken literally.
The issue can be avoided by setting end to a never-matching regexp (like <key>end</key><string>^\b$</string>). And maybe that could be put into the highlighting code: if undefined, use ^\b$ instead of the string undefined.
Copied from original issue: Microsoft/vscode#48654

I think we never ran into this because a grammar with a begin statement and a missing end statement is illegal... So our resolution could be to throw the entire rule out.

It's your decision. All I can say is that I read the documentation differently. (My understanding of "If there is no match for the end pattern, the end of the document is used." was that I can leave out the end to achieve a match till the end of the document.)


Introduce "name" parameter in Metric Tensor

🐞 Problem
Provision of name parameter is already there in the base class BaseRelativityTensor and now it's time to extend it to MetricTensor.
🎯 Goal

[ ] change symbolic/metric.py
[ ] Introduce name in predefined metrics in symbolic/predefined

📋  Steps to solve the problem

Comment below about what you've started working on.
Add, commit, push your changes
Submit a pull request and add this in comments - Fixes #<put issue number here>
Ask for a review in comments section of pull request
Celebrate your contribution to this project 🎉

@ritzvik I would like to take up this issue. Can I work on this?

Sure @JeS24

Sure @JeS24
@shreyasbapat Will connect on Riot, later today.


Only use the last CoreFoundation reference on Apple platforms

Now that CoreFoundation is no longer exposed on new platforms, ie except for Darwin and linux, apple/swift-corelibs-foundation#2878, change this last reference that was added years ago, before RunLoop._stop() was available. Removing the CoreFoundation interface broke building XCTest for Android, just like on Windows, which this patch fixes.
@millenomi and @compnerd, if this won't work for some reason, just let me know and I could try another approach.

@swift-ci test

@buttaface it is possible to build XCTest against Foundation.framework from Darwin which wont provide _stop.  I think that the work you have done here is actually desirable, but perhaps we need to back-pedal a small amount and leave the old path around, or alternatively, provide a shim in that case that bridges _stop.  I think that the shim is actually nicer because it keeps a single path through the code.

Alright, changed it to keep using the CF API on Darwin platforms, and the provisional _stop() API everywhere else.

@swift-ci test

@stmontgomery any objections? CoreFoundation isn't meant to be accessible on non-Darwin platforms, this is now strictly a bug fix, even though it has the side effect of printing the deprecation warning.

Yes thanks @compnerd and @buttaface, this LGTM now.
Not necessarily for this PR, but should we eventually be adopting @_implementationOnly for the import CoreFoundation, even on Darwin, to avoid re-exporting CoreFoundation in XCTest's module?

I think that it might be a good idea - it would mean that the behavioural differences would be minimal when using XCTest on the various platforms.


TomlArray support for IsMultiline

This is a quick & dirty implementation, but it seems OK.
https://toml.io/en/v1.0.0#array
contributors = [
  "Foo Bar<EMAIL_ADDRESS>  { name = "Baz Qux", email =<EMAIL_ADDRESS>url = "https://example.com/bazqux" }
]

Hi!
Thanks for the PR and sorry for quite the delay on the response!
From the looks of it, it appears like you're essentially reimplementing TomlArray.ToString with the only difference of it including newlines. I'd rather not have duplicate functionality.
How about instead doing something like the following?

Move code of TomlArray.ToString() to its own separate TomlArray.ToString(bool multiline) overload
Have TomlArray.ToString() call TomlArray.ToString(false)
Have TomlArray.WriteTo call TomlArray.ToString(IsMultiline) instead of ToInlineToml() (I initially made it call that instead of ToString because it makes for a bit more readable code; if you look at the default ToInlineToml() implementation, it just calls ToString())
Finally modify TomlArray.ToString(bool multiline) so that

When multiline = false, it uses " " as  starting/ending whitespace and $"{TomlSyntax.ITEM_SEPARATOR} " as item separator (i.e. current behaviour)
When multiline = false, it uses Environment.NewLine as starting/ending whitespace and $"{TomlSyntax.ITEM_SEPARATOR}{Environment.NewLine}" as item separator. You might also add some prefixing spacing if you want. Either way, I'd probably reuse the string.Join to keep overall code short

That's fair, I'll make those changes and update the PR when I have a moment.

The PR has been updated.
I ended up making the chained appends an if branch because it seemed a bit messy to do ?: inside the Appends. Let me know if that's what you would prefer anyway.

Nice, this looks good to me!
One small thing before I'll PR this: I think that instead of two separate Joins you could put the separator strings into variables as follows:
var arrayStart = multiline ? $"{Environment.NewLine}  " : " ";
var arraySeparator = multiline ? $"{TomlSyntax.ITEM_SEPARATOR}{Environment.NewLine}  " : $"{TomlSyntax.ITEM_SEPARATOR} ";
var arrayEnd = multiline ? Environment.NewLine : " ";

and then have just one Append/Join with these variables:
sb.Append(arrayStart)
    .Append(arraySeparator.Join(RawArray.Select(n => n.ToInlineToml())))
    .Append(arrayEnd);

This should end up a bit more legible (no need for duplicate array construction). I personally don't mine the use of ?: in this way since it ends up being more readable in the end.
Do tell how you end up proceeding. I'm fine with merging this as-is, although I'll likely do the above change myself should you decide not to.

I had considered that, if that's what you'd prefer then that would work too!
I'll make the change.

PR has been updated.

Looks good to me now!
Thank you again for the PR. I'll merge it now but won't likely release a new version right away since there are some issues to look at. I'll try to handle them as soon as possible.

No problem! I'm using my own fork at this point, bouncing from this PR and back, with all those extra forced commits is me fixing issues from duplicating changes.


Warn to use nix-on-droid switch --flake

If one has a ~/.config/nix-on-droid/flake.nix, likely from bootstrapping with flakes, and attempts to nix-on-droid switch without the --flake switch, we should print a warning: you have a flake.nix, you probably meant to run nix-on-droid-switch --flake .config/nix-on-droid.

I agree, just installed nix-on-droid with flakes enabled but nix-on-droid switch was not returning an useful error message. This would be a great addition!


Graceful service shutdown on stop

What is the recommended approach to ensuring a graceful termination of the SQL service on container termination?  Correct me if I'm wrong, but my understanding is that this is blocked on Windows container images until Windows containers receive notifications that come in docker 1.14.0.  But such a thing should be possible for the Linux image?

On Linux, the sqlservr process will receive a SIGTERM signal and shut down gracefully in the case of docker stop.    If you want to be really gentle you can use docker stop -t 30 or something like that to give the sqlservr process more than 10 seconds to shut down gracefully.

Thank you kindly!


There should be a need to publish events before they are visible to players

An event should need some kind of publishing. Only after publishing the event should be visible to players.

like in git - we want to stage a event bevor committing

As soon as the time based event system is available, it would be awesome to set a publishing date/time at which the notifications will be send and the event is visible to the players


how to set min max value in config

Dear Sir
I am trying to set min max value in config through service how should I do that
any sample will be appreciated

Actually, I only planned to have parse/format/validation/link capabilities implemented in the service while min/max/step defined outside.
You can see it at:
https://github.com/sagiegurari/angular-number-input/blob/master/docs/api.md#NumberInputService
I could modify it to allow the service to define those.
If you wish i'll implement that maybe later today/tomorrow.

Hi sir
Thank you very much for your kind attention. I'll appreciate if you
implement that
regards
Mousa
On Mon, Jul 11, 2016 at 4:36 PM, Sagie Gur-Ari<EMAIL_ADDRESS>wrote:

Actually, I only planned to have parse/format/validation/link capabilities
implemented in the service while min/max/step defined outside.
You can see it at:
https://github.com/sagiegurari/angular-number-input/blob/master/docs/api.md#NumberInputService
I could modify it to allow the service to define those.
If you wish i'll implement that maybe later today/tomorrow.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sagiegurari/angular-number-input/issues/1#issuecomment-231715835,
or mute the thread
https://github.com/notifications/unsubscribe/AGW49nZEeubwpOTNsF2fQG9i0Rn86Owdks5qUjHPgaJpZM4JJRw5
.

you can now set min/max/step via service.
please check it to see if it is working good for you.

Hi sagie
Thanks a lot
Regards
Mousa
On Mon, Jul 11, 2016 at 10:50 PM, Sagie Gur-Ari<EMAIL_ADDRESS>wrote:

you can now set min/max/step via service.
please check it to see if it is working good for you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sagiegurari/angular-number-input/issues/1#issuecomment-231819847,
or mute the thread
https://github.com/notifications/unsubscribe/AGW49oP4deHKcBgEDAXeoZ5ZT-tbBDvEks5qUolggaJpZM4JJRw5
.


[Bug]: Config Error button behind Title Bar buttons on Windows 11

Current Behavior
The Config Error button that appears when there is an error in the config files is being placed behind the title bar buttons for minimize, maximize, and close on Windows 11.
This makes it very hard to click on as only the very edge of the button sticks out further than the minimize button:

Expected Behavior
The button should be moved to the left side of the title bar buttons or to another more convenient location in the window.
Steps To Reproduce

Install waveterm on Windows 11
Open any waveterm json config files and input a character that breaks syntax.
Save the broken syntax file.
Observer the Config Error button appear in the upper right corner.
Attempt to click on the Config Error button.

Wave Version
v0.9.0
Platform
Windows
OS Version/Distribution
Windows 11 - Version: 22H2 - build: 22621.4317
Architecture
x64
Anything else?
Awesome application, looking forward to its further development! ;)
Questionnaire

[ ] I'm interested in fixing this myself but don't know where to start
[ ] I would like to fix and I have a solution
[ ] I don't have time to fix this right now, but maybe later

This also affects the update button:

This is a known issue with our tab code refactoring, unfortunately the fix is a bit complicated so for now I'd recommend disabling the window controls overlay by setting window:nativetitlebar to true in the settings.json


Fix MongoError conflict error

With the latest version of Mongo, $setOnInsert creates a conflict on update which throws an error MongoError: Updating the path 'pathName' would create a conflict at 'pathName' } (see this issue). Skipping it seems to fix the problem.

I got my server throwing too because of this.
please consider this PR !
Thx btw

This solution presented a problem when pushing a subschema to the array that had a defaultValue. My workaround was inverting the order of pull and push ifs:
`// Handle the case where we are $pushing an object into an array of objects and we
// want any fields missing from that object to be added if they have default values
if (this.operator === '$push') return defaultValue;
// Handle the case when pulling an object from an array the object contains a field
// which has a defaultValue. We don't wan't the default value to be returned in this case
if (this.operator === '$pull' || this.isUpdate) return;`

Thanks for the update @AlanOrtega91. I've updated the PR so that it only bypasses $setOnInsert if no default value is found as this is mainly what we want to avoid.

Keeping this open in case my change in 1.5.4 doesn't fix this

Here is an example of where the error shows
`
Pacientes = new Mongo.Collection("pacientes");
let Schema = new SimpleSchema({
idMedico: { type: String, regEx: SimpleSchema.RegEx.Id },
notasMedicasCompletas: { type: Array, defaultValue: [] },
"notasMedicasCompletas.$": { type: NotaMedicaCompletaSchema },
});
let NotaMedicaCompletaSchema = new SimpleSchema({
_id: { type: String, regEx: SimpleSchema.RegEx.Id },
idReceta: { type: String, regEx: SimpleSchema.RegEx.Id, optional: true },
});
Pacientes.attachSchema(Schema);
//It shows the error here
Pacientes.update(
{
idMedico:,
"notasMedicasCompletas.idReceta": idReceta
},
{
$unset: {
"notasMedicasCompletas.$.idReceta": ""
}
}
);
`


Add some test support for BSDs

Part of #78
This PR attempts to use https://github.com/vmactions/freebsd-vm to run tests in CI on a FreeBSD target. It appears to use VirtualBox virtualization on a MacOS host.
If I manage to get things working on this target then I'll try NetBSD and Solaris as well.

Looks like we've got some tests running in FreeBSD along with a failure: https://github.com/rust-lang/socket2/runs/1679158951?check_suite_focus=true#step:3:1567
failures:

---- only_v6 stdout ----
thread 'main' panicked at 'assertion failed: `(left != right)`
  left: `true`,
 right: `true`: initial value and argument are the same', tests/socket.rs:772:1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Looks like we've got some tests running in FreeBSD along with a failure: https://github.com/rust-lang/socket2/runs/1679158951?check_suite_focus=true#step:3:1567
failures:

---- only_v6 stdout ----
thread 'main' panicked at 'assertion failed: `(left != right)`
  left: `true`,
 right: `true`: initial value and argument are the same', tests/socket.rs:772:1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@KodrAus fixed the test issue in #196.

@KodrAus fixed the test issue in #196.

Done! Let's see if it passes now.
You may also be interested in https://github.com/vmactions/freebsd-vm/issues/8, which explains why the FreeBSD output contains a lot of garbled text right now before it gets to our code.

Done! Let's see if it passes now.
You may also be interested in https://github.com/vmactions/freebsd-vm/issues/8, which explains why the FreeBSD output contains a lot of garbled text right now before it gets to our code.

Looks like we're green now.
If you like I should be able to follow this one up with NetBSD and Solaris too.

Looks like we're green now.
If you like I should be able to follow this one up with NetBSD and Solaris too.

@KodrAus thanks. Adding NetBSD and Solaris would be great.

@KodrAus thanks. Adding NetBSD and Solaris would be great.


Consider removing the initial parameter value from the SGD type

Need a convincing example showing how this would simplify the library.

There is actually a good argument against this change.  Both run and runIO need explicit access to the initial parameter set in order to be able to return it if the producer of dataset elements is empty.


UI design for factorial/partial factorial experiment support

Tracking UI design in this issue. Algorithm development is tracked in #393
@zackcl could you link or attach your figma designs here?

The key frames:

@zackcl Hi Zack! Can you please refresh the content of this item with your latest UI designs. I think the links are probably still correct but the screenshots are out of date.

@mswartzCL Sure, I will do it once some of the design details are fixed (still need to settle on how the combination-aliases should be included in the api/assign response structure).

@mswartzCL I've updated the content with the latest UI designs.

Here's the updated UI design for factorial experiments as we discussed (link to the document).
Changes:

Have a separate Decision Points table above the Factors table
The factor row has a Description field instead of Site and Target
The Alias column should be renamed to Payload
The Conditions table has a Condition column instead of factor names
No toggle button to switch between the Factors and Conditions table in the Design step
As soon as there is more than one factor, the Conditions table will appear below the Factors table
The whole modal would be scrollable as the content grows, but the modal's height would remain fixed, as it is now
The details page should also be updated accordingly


Debounce BSDT Save Button

Critical Changes
Changes
Updates BSDT Save button to prevent multiple records being created if clicked more than once.
Issues Closed
New Metadata
Deleted Metadata
Definition of Done
Refer to Asteroids DoD document to see any additional details for the items below

[ ] Any net new LWC work has Sa11y tests & 50% or above lines JEST test coverage
[ ] CRUD/FLS is enforced in Apex
[ ] Permission sets are updated to account for CRUD|FLS|Tab|Classes
[ ] Field sets are updated to account for new fields
[ ] UX approval or UX not necessary
[ ] Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name (https://github.com/SalesforceFoundation/PMM/pull/303)
[ ] All acceptance criteria have been met

[ ] Developer
[ ] Code Reviewer
[ ] QA

[ ] PR contains draft release notes
[ ] QE story level testing completed

W-14109899


Documentation update required: Error while using the myql client npm package

Description:
When trying to run the server using nodemon dbServer.js, an error occurs: Client does not support authentication protocol requested by server; consider upgrading MySQL client.
Solution:
Resetting your password will solve this problem. Appropriate documentation changes are required for that.
@Harshdev098 Please assign this issue to me and add hacktoberfest and gssoc-ext labels to it.

Its not only issue of resetting a password or giving right password in .env file, its necessary to shift the mysql to latest versions or mysql2

Its not only issue of resetting a password or giving right password in .env file, its necessary to shift the mysql to latest versions or mysql2

Yes that's true, As of now, updating mysql to mysql2 requires a lot of changes so I'll update the documentation for temporary solution for this problem. Later, I'll try to modify mysql to mysql2.


Decide on js framework

might be backbone.js, still looking.

For complexity maybe Foundation...
...30 mins later...
A BIG NO, NO!


Upgrade material-ui

Upgrade material-ui to 1.0.0-beta.36 as well as react-scripts-ts to 2.13.0 as material-ui required a newer version of @types/react

closing since material-ui-next doesn't seem to work with the latest react-scripts-ts


[ibex] Align behavior of BUS.INTEGRITY in the peripheral registers

When SecureIbex is set Ibex checks bus data integrity internally. Any issues will be signaled as a core alert rather than an integrity alert. Instead Ibex should indicate when a major alert is specifically bus related so it can signaled as an integrity alert.
A PR to alter Ibex is allow this is available: https://github.com/lowRISC/ibex/pull/1534
Once merged Ibex should be vendored over and the new alerts wired up appropriately.

#11076 fixes this


No clear means to delete a user account is visible within the beta.dreamstudio.ai user interface

Come on, folks.  Stop trying to trap user data forever through shitty UI conventions that don't even allow the user to delete their account and data.
I'm no legal expert, but I'd bet European GDPR specialists would have a field day with your frontend devs.
Let me delete my account.

You don't have to be offensive and rude, and open github tickets for irrelevant projects in github.
This repo is the SDK, not related to the "shitty UI conventions" in any way.
GDPR doesn't require a button to let you do this, you can contact the company data officer with your request and they have 30 days to delete your data.

@ebelliveau it sounds like that was a frustrating experience. I've brought this gh issue directly to the attention of our Chief Information Security Officer, who I anticipate will be reaching out to you shortly. I assure you: any failings of our UI are not from designs to trap your data but are rather a function of the accelerated schedule we imposed on ourselves to get these tools out to everyone as quickly as we reasonably could.

There.
Is.
No.
User.
Tooling.
To.
Delete.
One's.
Account.
I don't care if it's the SDK; someone in the mix needs to be made aware of this and have the issue passed upwards.  Close it if you must, but I'd rather be heard than sat frustrated trying to accomplish basic auth things with no clear resolution path.

@ebelliveau it sounds like that was a frustrating experience. I've brought this gh issue directly to the attention of our Chief Information Security Officer, who I anticipate will be reaching out to you shortly. I assure you: any failings of our UI are not from designs to trap your data but are rather a function of the accelerated schedule we imposed on ourselves to get these tools out to everyone as quickly as we reasonably could.

Thank you.  I appreciate this.

Close if it you must

I'll leave this open until I can be sure the issue is at least being tracked somewhere better and you're in good hands.

Right-on.  Thank you, @dmarx.


docs: Update docs to indicate do-not-disrupt does not block expiration

Fixes #N/A
Description
Update docs to indicate do-not-disrupt does not block expiration
How was this change tested?
NA
Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.125%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
5774

Relevant Lines:
8866

💛  - Coveralls


Fix CharacterInstantiation.cs-Bug

Console error message stating script bug in the array.  Index Out Of Range Exception error message.

@branchbark What file should we look at? 207 files is a lot to look through.

Closing this as I reverted the script change back.  Need to investigate this further.


Move install of gtest to DependencyInstaller.sh.

For https://github.com/The-OpenROAD-Project/OpenROAD/issues/5530.
Tested with clean build and make test.
Minor issue if a system gtest is present. I added a FIXME :
# FIXME: The override does not work if a system gtest is present so something more should be done.
Conversely our install will still be used if a system gtest is install afterwards

It shouldn't be an big issue as even if system gtest is installed. It can be removed (and reinstalled) and our gtest install will be used.
I'll try to find a fix for that.

Yeah. I'm personally opposed to this. Sorry I forgot to respond to your original issue, but pull the system GTest is exactly what we want to avoid. Most of the time Gtest is just directly included in a repo this is a nicer alternative to committing the files to the repo.
This is just generally the way Gtest asks you to install into your repo. https://github.com/google/googletest/blob/main/googletest/README.md#build-with-cmake

I understand your company has firewall rules that's blocking this stuff, and I think a better approach for you is to be able to override the URL to a local file. We could dependency install a tar file somewhere on the system and then point Fetch content at that, but I just fear a super super old version of gtest that just happens to be installed on someones machine.

@QuantamHD I don't know what you mean by "pulling the system GTest". I do exactly things the same way as in DependencyInstaller.sh.
Who are the "we" in "what we want to avoid"?
AFAIK:

OpenSTA and abc are submodules
DependencyInstaller.sh manages over 20 dependencies
Gtest is the single dependency manage by the build system

So can you explain why Gtest have an exception?
I noticed cudd has been recently added into DependencyInstaller.sh. Why not integrated into the build system as got gtest?

By the system GTest I mean the version the user happened to install.
We is in general the project, but I don't speak for everyone. What I worry about is getting a really old version of Gtest where the tests don't work because the user has an out of date version of Gtest. Gtest in particular is finicky about versions and changes frequently which is why most projects just include it in their build tree.
If we can avoid relying on a system dependency that's more ideal since we build it in tree rather than relying on something on the system. Ideally we could just build and statically link our transitive dependency closure from source and do away with dependency installer entirely. But for now every dependency that doesn't have to be in the dependency installer is one less platform issue we run into.

I'm totally fine if you want to download the gtest zip file somewhere on the system from the dependency installer and point fetch content at that file. It achieves the same thing as pulling it from github.

I clearly understand that we want to use our own installed version of gtest (1.13.0) and not the system one installed with apt. The PR does this and I tested version 1.13.0 is used whatever the system one is installed or not. But indeed it is installed in /usr/local. If /usr/local should be avoided, all the prefixes in deps installer should be modfied to a local directory then.

We assume that we can install to /usr/local so I don't see this as an issue.  We do allow a prefix to be specified for those that need it.

This PR is fine. I personally dislike /usr/local install stuff and would happily remove it all if we could, but that's a personal issue, and if this helps you use OpenROAD we should move ahead with it.

Rebasing.
clang-tidy-review fails because the CI is not update with new deps.
I guess the 2 builds too although oddly the details show all steps green.

Is there anything more to do in this PR?
The CI needs to be updated to make the checks pass. I don't know how to do it.


Remove owner role and replace with user

Overview
This commit removes the owner role and replaces it back with the user
role, which was accidentally removed during a refactor. This also aligns
the datamodel with the enum constraints currently in the database.
Testing Instructions

run ./scripts/load_development_data/
start server: ./scripts/server
start frontend: npm start
Log in, get JWT and make an authenticated request to the users endpoint with the JWT supplied. No 500s should be shown

+1


Inconsistent Colors

Issue Type: Bug
Im having some problems with colors in javascript(first image). this started happening after i installed the c/c++ extension to visual code, but even after i removed the extension the problem kept happening. i tried even disabling the javascript language defaults, the the second image happend, the words that had problems in javascript have problems even in the plain text mode. its very strange, i tried other themes and all the ones that i tested have the same insconsistense. another thing, the console.log command, that is supposed to be green in the default theme starts green when i tepe it, but a few moments later it turns into blue, same thing with the other words, just after opening vscode the colors are normal, but then, out of nowhere they change to this weirdeness. i event tried reinstalling vscode, but it didnt help.

VS Code version: Code 1.43.0 (78a4c91400152c0f27ba4d363eb56d2835f9903a, 2020-03-09T19:44:52.965Z)
OS version: Linux x64 5.3.0-40-generic snap

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7 CPU         860  @ 2.80GHz (8 x 2933)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: disabled_off_okvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
0, 0, 1

Memory (System)
7.71GB (1.12GB free)

Process Argv
--force-user-env --no-sandbox --unity-launch --no-sandbox

Screen Reader
no

VM
0%

Extensions (4)

Extension
Author (truncated)
Version

vscode-eslint
dba
2.1.1

beautify
Hoo
1.5.0

atom-keybindings
ms-
3.0.6

debugger-for-chrome
msj
4.12.6

(1 theme extensions excluded)

Looks like duplicate of #92654
Please check that issue and close this issue if it's duplicate.
You can try "editor.semanticHighlighting.enabled": false in your settings to disable Semantic Highlight.
However not sure what happens on second screenshot. Are this before/after JS/TS features finished initialization?

/needsMoreInfo
What theme are you using? Is second screen with theme enabled?

I had the same problem using Dracula theme. After doing what @IllusionMH said, the colors are back to normal.

Looks like duplicate of #92654
Please check that issue and close this issue if it's duplicate.
You can try "editor.semanticHighlighting.enabled": false in your settings to disable Semantic Highlight.
However not sure what happens on second screenshot. Are this before/after JS/TS features finished initialization?

I have the same problem using Adapta Nokto color theme by "Linux Themes for VS Code". This happens after JS/TS features finished.

See https://github.com/microsoft/vscode/wiki/Semantic-Highlighting-Overview#semantic-highlighting
duplicate of https://github.com/microsoft/vscode/issues/92308


Disable tqdm bars in non-interactive environments

Replace disable=False with disable=None in the tqdm bars to disable them in non-interactive environments (by default).
For more info, see a similar PR in huggingface_hub.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


fix std::atomic_bool for msvc2013

As discussed on cpp_redis repository (issue 37) this should fix the errors related to std::atomic_bool.

Perfect, thanks a lot!


[Bug]: Google BigQuery - ERROR: com.google.common.util.concurrent.ExecutionError: java.lang.NoSuchMethodError: 'java.lang.String com.google.auth.Credentials.getUniverseDomain()'

Apache Hop version?
2.9.0
Java version?
java 22 2024-03-19
Operating system
Windows
What happened?
When I set a limit of 39,999 on a query, it works fine. However, if I remove the limit or change it to => 40,000, the query fails with the following error:
"ERROR: com.google.common.util.concurrent.ExecutionError: java.lang.NoSuchMethodError: 'java.lang.String com.google.auth.Credentials.getUniverseDomain()'"

Issue Priority
Priority: 0
Issue Component
Component: Database

Does anyone have a chance to check this? Is this a bug or is there a workaround?

.take-issue

which libraries have you copied over from the Simba JDBC driver?
I think you will have to replace the google-auth-library-credentials and google-auth-library-oauth2-http under lib/beam folder

Hi,
Thanks for your help.
I'm using the version 1.23.0 in both folders (\hop\lib\beam) and (\hop\plugins\databases\googlebigquery\lib):
Below the output for all files from:
\hop\plugins\databases\googlebigquery\lib:
api-common-2.32.0.jar
gax-2.49.0.jar
gax-grpc-2.43.0.jar
google-api-client-2.3.0.jar
google-api-services-bigquery-v2-rev20240211-2.0.0.jar
google-auth-library-oauth2-http-1.23.0.jar
google-cloud-bigquerystorage-3.2.0.jar
google-http-client-jackson2-1.42.3.jar
google-oauth-client-1.36.0.jar
GoogleBigQueryJDBC42.jar
grpc-google-cloud-bigquerystorage-v1-3.2.0.jar
grpc-google-cloud-bigquerystorage-v1beta1-0.174.0.jar
grpc-google-cloud-bigquerystorage-v1beta2-0.174.0.jar
json-20240205.jar
proto-google-cloud-bigquerystorage-v1-3.2.0.jar
proto-google-cloud-bigquerystorage-v1beta1-0.174.0.jar
proto-google-cloud-bigquerystorage-v1beta2-0.174.0.jar
threetenbp-1.6.9.jar
\hop\lib\beam:
akka-protobuf_2.11-2.5.32.jar
akka-slf4j_2.11-2.5.32.jar
antlr4-runtime-4.7.jar
auto-value-annotations-1.8.2.jar
avro-1.11.3.jar
beam-model-job-management-2.56.0.jar
beam-model-pipeline-2.56.0.jar
beam-runners-direct-java-2.56.0.jar
beam-sdks-java-core-2.56.0.jar
beam-vendor-bytebuddy-1_11_0-0.1.jar
beam-vendor-grpc-1_60_1-0.2.jar
beam-vendor-guava-32_1_2-jre-0.1.jar
byte-buddy-1.12.18.jar
classgraph-4.8.162.jar
commons-codec-1.15.jar
commons-compress-1.26.0.jar
commons-io-2.15.1.jar
commons-lang3-3.9.jar
commons-logging-1.1.3.jar
compress-lzf-1.1.jar
conscrypt-openjdk-uber-2.5.2.jar
curator-client-5.4.0.jar
curator-framework-5.4.0.jar
curator-recipes-5.4.0.jar
error_prone_annotations-2.10.0.jar
google-api-client-2.2.0.jar
google-auth-library-credentials-1.23.0.jar
google-auth-library-oauth2-http-1.23.0.jar
google-http-client-1.42.3.jar
google-http-client-gson-1.42.3.jar
grpc-alts-1.60.1.jar
grpc-api-1.60.1.jar
grpc-auth-1.60.1.jar
grpc-context-1.60.1.jar
grpc-core-1.60.1.jar
grpc-grpclb-1.60.1.jar
grpc-netty-1.60.1.jar
grpc-netty-shaded-1.60.1.jar
grpc-protobuf-1.60.1.jar
grpc-protobuf-lite-1.60.1.jar
grpc-stub-1.60.1.jar
gson-2.10.jar
guava-32.1.2-jre.jar
hamcrest-2.1.jar
hop-engine-beam-2.9.0.jar
httpclient-4.5.13.jar
httpcore-4.4.15.jar
jackson-annotations-2.15.0.jar
joda-time-2.12.1.jar
json-simple-1.1.1.jar
json4s-ast_2.12-3.7.0-M11.jar
json4s-core_2.12-3.7.0-M11.jar
json4s-jackson_2.12-3.7.0-M11.jar
json4s-scalap_2.12-3.7.0-M11.jar
jsr305-3.0.2.jar
kryo-5.3.0.jar
kryo-shaded-4.0.2.jar
log4j-api-2.19.0.jar
log4j-core-2.19.0.jar
metrics-core-4.2.12.jar
metrics-jvm-4.2.12.jar
metrics-logback-4.2.12.jar
minlog-1.3.1.jar
netty-all-4.1.89.Final.jar
netty-buffer-4.1.89.Final.jar
netty-codec-4.1.89.Final.jar
netty-codec-dns-4.1.89.Final.jar
netty-codec-haproxy-4.1.89.Final.jar
netty-codec-http-4.1.89.Final.jar
netty-codec-http2-4.1.89.Final.jar
netty-codec-memcache-4.1.89.Final.jar
netty-codec-mqtt-4.1.89.Final.jar
netty-codec-redis-4.1.89.Final.jar
netty-codec-smtp-4.1.89.Final.jar
netty-codec-socks-4.1.89.Final.jar
netty-codec-stomp-4.1.89.Final.jar
netty-codec-xml-4.1.89.Final.jar
netty-common-4.1.89.Final.jar
netty-handler-4.1.89.Final.jar
netty-handler-proxy-4.1.89.Final.jar
netty-handler-ssl-ocsp-4.1.89.Final.jar
netty-resolver-4.1.89.Final.jar
netty-resolver-dns-4.1.89.Final.jar
netty-resolver-dns-classes-macos-4.1.89.Final.jar
netty-transport-4.1.89.Final.jar
netty-transport-classes-epoll-4.1.89.Final.jar
netty-transport-classes-kqueue-4.1.89.Final.jar
netty-transport-native-unix-common-4.1.89.Final.jar
netty-transport-rxtx-4.1.89.Final.jar
netty-transport-sctp-4.1.89.Final.jar
netty-transport-udt-4.1.89.Final.jar
opencensus-api-0.31.1.jar
opencensus-contrib-http-util-0.31.1.jar
paranamer-2.8.jar
perfmark-api-0.26.0.jar
proto-google-common-protos-2.14.0.jar
protobuf-java-3.23.2.jar
protobuf-java-util-3.23.2.jar
scala-library-2.12.17.jar
slf4j-api-2.0.4.jar
woodstox-core-6.4.0.jar
zookeeper-3.8.4.jar
zstd-jni-1.5.2-2.jar
Tks!

You still have the error? it seems we still shipped /hop/lib/beam/google-auth-library-credentials-1.12.1.jar and this one did not have that Method

Hi,
google-auth-library-credentials-1.12.1.jar is the original and I get the original error. Today I updated to google-auth-library-credentials-1.23.0.jar  and I still have the same error.

yup, it seems the Simba dependencies are not matching with our own at the moment and there is no easy fix for this. I'll try and get it sorted out but there won't be a short term fix

I suggest using the bigquery input, this one works with the Hop engine too

Unless I'm wrong, "Beam BigQuery Input" doesn't work with "Local Engine" - only on DataFlow engine - which is too expensive for me for now.
Please let me know if there is anything I can do to work around this issue.
Tks

works with the local engine, just tested it. And it is also marked this way in the documentation.
https://hop.apache.org//manual/latest/pipeline/transforms/beambigqueryinput.html

Hi,
Ok.
For Input they works well as a workaround.
Thanks!

lowering Prio as there is a solution.


Browser-sync not found - npm run watch

When running npm run watch I get Error: Cannot find module 'browser-sync'.
I noticed that it was removed from the package.json for a new laravel-mix-jigsaw but does not appear to be working.
Appears to be this merge.
https://github.com/tightenco/jigsaw/commit/d912252a1acc33b2a6ae504d882a0f8563de63c2
Is there a different way to run it that just hasn't been added to the docs or that i'm missing.
Thanks

Thanks! Fixed in tightenco/laravel-mix-jigsaw#4.


[#112499245] Setup Garden to block all outgoing traffic to fix security groups.

https://www.pivotaltracker.com/story/show/112499245
what?
As part of investigating the acceptance tests, we discovered that the
security groups where not working as expected. Actually, we were not
blocking any traffic after migrating to diego.
The reason is some misconfiguration in the garden. The garden release
must be configure to block the traffic by default, and the security groups
will open access as needed.
Context
In this PR we will:

Group all the security group configuration in one file to simplify the
config management.
Block all traffic by default in garden

How to test this?
Without the PR, the app containers can connect to any IP in the internal
network. With the PR, only public IPs.

Deploy CF as described in the README.md
start some application:

cf create-space -o GDS test
cf target -o "GDS" -s "test"
mkdir static && cd static
echo hello > index.html
cf push my_static_app -b staticfile_buildpack -p .
 3. SSH to the machine running the app using bosh ssh:
    ```
CONCOURSE_IP=...
ssh -i ~/gds/paas-cf/id_rsa -l vcap $CONCOURSE_IP -L 25555:<IP_ADDRESS>:25555 -fN
bosh target localhost
bosh ssh colocated_z1 --gateway_host $CONCOURSE_IP  --gateway_user vcap --gateway_identity_file ~/gds/paas-cf/id_rsa

Login on the app garden container:

ps -fea |grep  bin/wsh  | sed -n 's|./([^/])/bin/w[s]h.*|\1|p' | head -n 1
/var/vcap/data/garden/depot/bcls1khbmhd/bin/wsh --socket /var/vcap/data/garden/depot/bcls1khbmhd/run/wshd.sock --user vcap bash
 5. Perform some network tets with curl:
    ```
curl http://www.google.com # should work

curl http://<IP_ADDRESS>:4001 # Change the IP with a etcd node ip from `bosh vms | grep etcd`. This should not work.

Who?
Anyone but @keymon or @timmow

One way of testing this PR, is actually reviewing the PR #81, because the security groups test needs this change to work,.

Tested by successfully running acceptance tests from https://github.com/alphagov/paas-cf/pull/81


Small fixes in dataset-fetch.py

wget spams a lot with its download status, so silence it.
parallel wget for each batch

lgtm 👍