Update Apilyzer to treat core.iterators as API

Refactoring done for #1390 requires the Apilyzer plugin to run on core.iterators, ensuring there is no internal types in the API.

This should be a simple single line addition to the apilyzer-maven-plugin configuration in core/pom.xml

I modified the core/pom.xml as so:
-                <include>org[.]apache[.]accumulo[.]core[.]iterators[.]IteratorUtil[$]IteratorScope</include>
+                <include>org[.]apache[.]accumulo[.]core[.]iterators[.].*</include>

And saw the following failures:
  METHOD_RETURN        org.apache.accumulo.core.iterators.IteratorEnvironment       getServiceEnv(...)                  org.apache.accumulo.core.spi.common.ServiceEnvironment
  FIELD                org.apache.accumulo.core.iterators.user.VisibilityFilter     cache                               org.apache.commons.collections4.map.LRUMap
  FIELD                org.apache.accumulo.core.iterators.user.TransformingIterator log                                 org.slf4j.Logger

I added the first method to IteratorEnvironment as a replacement for AccumuloConfiguration.  It seems that SPI has now entered into the quasi-API limbo, where iterators have lived for some time.  Perhaps SPI should be declared as public API along with iterators.  Even if SPI doesn't affect data like iterators do, it has a nice way to access server configuration.
It seems like the LRUMap was made protected so users could override it with a different implementation. Whatever the case, I think this type could be a java.util.Map.
The logger should probably just be private.

Could add an "allows" line for the service environment instead of promoting it to public API. It might be okay to have it leak into the public API, as long as it's documented carefully, and just treat it as an excepted case.

After some discussion with @keith-turner and @ctubbsii, I think we should treat iterators as SPI.  They are pluggable server mechanisms, that can be affected by internal server changes, similar to the other plugins in the SPI.   I think, along with the other SPI packages, we should only guarantee compatibility across bug fix versions.

Perhaps SPI should be declared as public API along with iterators.

Pluggable interfaces in SPI related to scan execution and caching are tightly coupled to Accumulo's internal model for executing scans.  If these interfaces are in the API it could make it very difficult to change the internal execution model for scans.  The reason is because it may require going through a deprecation cycle where a single release supports an old and new model of executing scans, which may not be practical.  Also the interfaces related to scan execution and caching only impact scan performance, never scan data returned.

They are pluggable server mechanisms, that can be affected by internal server changes, similar to the other plugins in the SPI.

I thought it made sense to place iterators in the public API because they can change the data returned by scans and are tightly coupled to a users data and queries.  I can take a stab at this.

I took created a draft PR #1426 where I attempted to pull iterators in to the API from Apilyzer perspective.  I also attempted to document/define SPI in that PR.


Add support for 90 and 270 degree text rotation

Closes #28
This PR adds support for non-screwy 90 and 270 degree rotations in terminal mode. There's a performance hit when using these rotation values, however, as the byte array returned by to_bitmap() has to be transmuted. I was wondering about just storing another array of chars with the transmute preapplied, but we'd be using double the memory in dev mode. It'd probably get optimised out in release mode which is worth something.
I also have to keep track of where the char is and use set_draw_area() appropriately otherwise the text ends up looking like this:

I couldn't see anything in the datasheet that would help out here unfortunately.

Hm, that is nice. But I'm wondering whether we should leave it (it being rotation) for "Enhanced TerminalMode" which will have to keep the position anyway to properly react to special character and possibly implement the line shifting (instead of wrapping) and keep this one simple.

Yeah, I'm not happy that this adds quite a bit of complexity to the mode. Having it be stateless (i.e. no set_draw_area()) is really nice. I'll make a new PR which just adds some doc text explaining that terminal mode doesn't support 90 and 270º rotations to replace this one.


koord-scheduler: optimize the flow of restore Reservation

Ⅰ. Describe what this PR does
Optimize the flow of restore Reservation from NodeInfo in BeforePreFilter instead of AfterPreFilter.
In the previous implementation, it was necessary to cooperate to modify the scheduling state before and after the PreFilter to ensure the consistency of the data view. The overall performance is relatively poor, and some of the original interfaces cannot help to process data correctly. For example, unmatched reservations are not passed to each plugin, resulting in some data not being corrected, resulting in scheduling results in some scenarios that do not meet expectations.
Now it is optimized to process data concurrently in BeforePreFilter, and removes a lock, which improves the overall performance, and can better coordinate each plugin to process their own internal state.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[x] I have written necessary docs and comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in make test

/lgtm


JPEGmini plugin

It's a paid OS X only app, but it has the best result in lossy minifying JPEGs in my experience.
http://www.jpegmini.com/
Inspiration: https://github.com/JamieMason/ImageOptim-CLI/blob/99432e8a2452ba9c58b7355b52c1f063e912caa1/src/imageOptimBashLib#L412-L429

How does it compare to mozjpeg?

Not sure. The thing about JPEGmini is that it doesn't have any options. It just does a really good lossy minification by default.

Using the images provided on their website without using any options with mozjpeg.

I guess not.


Lincs

Data stored on renci nfs. File path specified in parser.
Need review before completion of PR since no test ran for the new LICNS parser.

How did you obtain the LINCS files that are parsed here? I believe all of the LINCS data is dependent on cell line in which gene expression is measured, so I'm a little worried about saying a compound positively/negatively regulating some gene without providing the cell contexts in which it was measured.

The code looks great at a glance. I would probably delete some of the template comments, and it's also 2024 now ;)
But lets address JMs question before I start testing. Maybe we can use the anatomical context qualifier? The biolink docs actually mention a "experimental_context_qualifier" that has HeLa cells as the example, but I don't think that's actually in the model. I'm not sure if there is one for cell types otherwise.


build from source in jetson nano bazel report error

Click to expand!
Issue Type
Build/Install
Have you reproduced the bug with TF nightly?
Yes
Source
source
Tensorflow Version
r2.6
Custom Code
Yes
OS Platform and Distribution
linux ubuntu18.04 jetpack461
Mobile device
No response
Python version
3.8
Bazel version
3.7.2
GCC/Compiler version
7.5.0
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
i want install tensorflow-cpu==2.6 on jetson nano and python>=3.8 jetpack 4.61
Standalone code to reproduce the issue
git checkout r2.6
./configure
You have bazel 3.7.2- (@non-git) installed.
Please specify the location of python. [Default is /home/jetson/miniforge3/envs/py38/bin/python3]:

Found possible Python library paths:
  /home/jetson/miniforge3/envs/py38/lib/python3.8/site-packages
Please input the desired Python library path to use.  Default is [/home/jetson/miniforge3/envs/py38/lib/python3.8/site-packages]

Do you wish to build TensorFlow with ROCm support? [y/N]:
No ROCm support will be enabled for TensorFlow.

Do you wish to build TensorFlow with CUDA support? [y/N]:
No CUDA support will be enabled for TensorFlow.

Do you wish to download a fresh release of clang? (Experimental) [y/N]:
Clang will not be downloaded.

Please specify optimization flags to use during compilation when bazel option "--config=opt" is specified [Default is -Wno-sign-compare]:

Would you like to interactively configure ./WORKSPACE for Android builds? [y/N]:
Not configuring the WORKSPACE for Android builds.

bazel --output_base=/home/jetson/experiment/tensorflow_pkg build //tensorflow/tools/pip_package:build_pip_package

Relevant log output
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.devtools.build.lib.unsafe.StringUnsafe (file:/home/jetson/.cache/bazel/_bazel_jetson/install/55993bca119e0c9410de59d485012347/A-server.jar) to constructor java.lang.String(byte[],byte)
WARNING: Please consider reporting this to the maintainers of com.google.devtools.build.lib.unsafe.StringUnsafe
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

Hi @Stave604671 ,
From the log stack it seems related to java environment and logged under warning and it might not affect the build. Could you please confirm whether the build is failing or just you want to report about warnings ?
With latest versions I am sure there is no problem with builds.We have tested the builds on Ubuntu VMs and found success.Could you please confirm whether any reason for sticking to TF 2.6 version as we are not actively supporting the older versions. Request you to please cross check with latest versions.
I have cross checked the build with Master and could not notice any such warning. Please refer to attached logs below.
(bazel2) suryanarayanay@surya-ubuntu20:~/tensorflow$ bazel build //tensorflow/tools/pip_package:build_pip_package &>60343logs.txt

INFO: Options provided by the client:
  Inherited 'common' options: --isatty=0 --terminal_columns=80
INFO: Reading rc options for 'build' from /home/suryanarayanay/tensorflow/.bazelrc:
  Inherited 'common' options: --experimental_repo_remote_exec
INFO: Reading rc options for 'build' from /home/suryanarayanay/tensorflow/.bazelrc:
  'build' options: --define framework_shared_object=true --define tsl_protobuf_header_only=true --define=use_fast_cpp_protos=true --define=allow_oversize_protos=true --spawn_strategy=standalone -c opt --announce_rc --define=grpc_no_ares=true --noincompatible_remove_legacy_whole_archive --enable_platform_specific_config --define=with_xla_support=true --config=short_logs --config=v2 --define=no_aws_support=true --define=no_hdfs_support=true --experimental_cc_shared_library --experimental_link_static_libraries_once=false --incompatible_enforce_config_setting_visibility
INFO: Reading rc options for 'build' from /home/suryanarayanay/tensorflow/.tf_configure.bazelrc:
  'build' options: --action_env PYTHON_BIN_PATH=/home/suryanarayanay/miniconda3/bin/python3 --action_env PYTHON_LIB_PATH=/home/suryanarayanay/miniconda3/lib/python3.10/site-packages --python_path=/home/suryanarayanay/miniconda3/bin/python3
INFO: Reading rc options for 'build' from /home/suryanarayanay/tensorflow/.bazelrc:
  'build' options: --deleted_packages=tensorflow/compiler/mlir/tfrt,tensorflow/compiler/mlir/tfrt/benchmarks,tensorflow/compiler/mlir/tfrt/jit/python_binding,tensorflow/compiler/mlir/tfrt/jit/transforms,tensorflow/compiler/mlir/tfrt/python_tests,tensorflow/compiler/mlir/tfrt/tests,tensorflow/compiler/mlir/tfrt/tests/ir,tensorflow/compiler/mlir/tfrt/tests/analysis,tensorflow/compiler/mlir/tfrt/tests/jit,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_tfrt,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_jitrt,tensorflow/compiler/mlir/tfrt/tests/tf_to_corert,tensorflow/compiler/mlir/tfrt/tests/tf_to_tfrt_data,tensorflow/compiler/mlir/tfrt/tests/saved_model,tensorflow/compiler/mlir/tfrt/transforms/lhlo_gpu_to_tfrt_gpu,tensorflow/core/runtime_fallback,tensorflow/core/runtime_fallback/conversion,tensorflow/core/runtime_fallback/kernel,tensorflow/core/runtime_fallback/opdefs,tensorflow/core/runtime_fallback/runtime,tensorflow/core/runtime_fallback/util,tensorflow/core/tfrt/eager,tensorflow/core/tfrt/eager/backends/cpu,tensorflow/core/tfrt/eager/backends/gpu,tensorflow/core/tfrt/eager/core_runtime,tensorflow/core/tfrt/eager/cpp_tests/core_runtime,tensorflow/core/tfrt/gpu,tensorflow/core/tfrt/run_handler_thread_pool,tensorflow/core/tfrt/runtime,tensorflow/core/tfrt/saved_model,tensorflow/core/tfrt/graph_executor,tensorflow/core/tfrt/saved_model/tests,tensorflow/core/tfrt/tpu,tensorflow/core/tfrt/utils
INFO: Found applicable config definition build:short_logs in file /home/suryanarayanay/tensorflow/.bazelrc: --output_filter=DONT_MATCH_ANYTHING
INFO: Found applicable config definition build:v2 in file /home/suryanarayanay/tensorflow/.bazelrc: --define=tf_api_version=2 --action_env=TF2_BEHAVIOR=1
INFO: Found applicable config definition build:linux in file /home/suryanarayanay/tensorflow/.bazelrc: --host_copt=-w --copt=-Wno-all --copt=-Wno-extra --copt=-Wno-deprecated --copt=-Wno-deprecated-declarations --copt=-Wno-ignored-attributes --copt=-Wno-array-bounds --copt=-Wunused-result --copt=-Werror=unused-result --copt=-Wswitch --copt=-Werror=switch --copt=-Wno-error=unused-but-set-variable --define=PREFIX=/usr --define=LIBDIR=$(PREFIX)/lib --define=INCLUDEDIR=$(PREFIX)/include --define=PROTOBUF_INCLUDE_PATH=$(PREFIX)/include --cxxopt=-std=c++17 --host_cxxopt=-std=c++17 --config=dynamic_kernels --distinct_host_configuration=false --experimental_guard_against_concurrent_changes
INFO: Found applicable config definition build:dynamic_kernels in file /home/suryanarayanay/tensorflow/.bazelrc: --define=dynamic_loaded_kernels=true --copt=-DAUTOLOAD_DYNAMIC_KERNELS
Loading:
Loading: 0 packages loaded
Analyzing: target //tensorflow/tools/pip_package:build_pip_package (0 packages loaded, 0 targets configured)
INFO: Analyzed target //tensorflow/tools/pip_package:build_pip_package (0 packages loaded, 1343 targets configured).

INFO: Found 1 target...
[0 / 15] [Prepa] BazelWorkspaceStatusAction stable-status.txt
[82 / 119] Compiling src/util.cpp; 0s local ... (8 actions, 7 running)
[83 / 119] Compiling src/idl_gen_text.cpp; 2s local ... (8 actions running)
[84 / 119] Compiling src/idl_gen_text.cpp; 3s local ... (8 actions running)
[85 / 119] Compiling src/idl_gen_text.cpp; 4s local ... (8 actions running)
[89 / 119] Compiling src/idl_gen_python.cpp; 4s local ... (8 actions running)
[90 / 119] Compiling src/idl_gen_python.cpp; 6s local ... (8 actions running)
[91 / 119] Compiling src/idl_gen_python.cpp; 8s local ... (8 actions running)
[94 / 119] Compiling src/idl_gen_rust.cpp; 9s local ... (8 actions running)
[99 / 119] Compiling src/idl_gen_cpp.cpp; 8s local ... (7 actions running)
[103 / 119] Compiling src/idl_gen_cpp.cpp; 10s local ... (8 actions running)
[105 / 119] Compiling src/idl_gen_cpp.cpp; 13s local ... (8 actions running)
[123 / 318] Compiling src/idl_gen_java.cpp; 8s local ... (8 actions running)
[132 / 318] Compiling src/idl_parser.cpp; 11s local ... (8 actions running)
[140 / 318] Compiling src/idl_parser.cpp; 15s local ... (8 actions running)
[150 / 318] Compiling src/idl_parser.cpp; 20s local ... (8 actions running)
[169 / 318] Compiling src/google/protobuf/compiler/python/pyi_generator.cc; 4s local ... (8 actions running)
[186 / 318] Compiling src/google/protobuf/compiler/java/field.cc; 3s local ... (8 actions running)
[206 / 318] Compiling src/google/protobuf/compiler/csharp/csharp_helpers.cc; 2s local ... (8 actions running)
[231 / 318] Compiling src/google/protobuf/struct.pb.cc; 5s local ... (8 actions running)
[264 / 318] Compiling src/google/protobuf/compiler/cpp/message.cc; 10s local ... (8 actions, 7 running)
[302 / 318] Compiling src/google/protobuf/descriptor.cc; 12s local ... (8 actions, 7 running)
[372 / 451] Compiling src/google/protobuf/descriptor.cc; 6s local ... (8 actions, 7 running)
[419 / 451] Compiling src/google/protobuf/text_format.cc; 5s local ... (8 actions, 7 running)
[649 / 3,019] Compiling llvm/lib/TableGen/TGParser.cpp; 7s local ... (8 actions, 7 running)
[734 / 3,019] Compiling llvm/lib/Support/Path.cpp; 4s local ... (8 actions, 7 running)
[807 / 3,019] Compiling llvm/utils/TableGen/AsmMatcherEmitter.cpp; 10s local ... (8 actions, 7 running)
[844 / 3,019] Compiling llvm/utils/TableGen/AsmWriterEmitter.cpp; 10s local ... (8 actions, 7 running)
[947 / 3,019] Compiling llvm/lib/Support/Program.cpp; 3s local ... (8 actions, 7 running)
[1,059 / 3,024] Compiling mlir/tools/mlir-tblgen/OpFormatGen.cpp; 11s local ... (8 actions, 7 running)
[1,438 / 3,028] Compiling tensorflow/core/ir/ops.cc; 19s local ... (8 actions, 7 running)
[1,517 / 3,028] Compiling tensorflow/core/protobuf/meta_graph.pb.cc; 9s local ... (8 actions, 7 running)
[1,641 / 3,034] Compiling tensorflow/core/common_runtime/device_set.cc; 8s local ... (8 actions, 7 running)
[1,693 / 3,034] Compiling tensorflow/core/common_runtime/inline_function_utils.cc; 13s local ... (8 actions, 7 running)
[1,759 / 3,034] Compiling tensorflow/core/grappler/optimizers/memory_optimizer.cc; 20s local ... (8 actions, 7 running)
[2,035 / 3,347] Compiling tensorflow/core/grappler/optimizers/auto_mixed_precision.cc; 19s local ... (8 actions, 7 running)
[2,315 / 3,349] Compiling mlir/lib/IR/OperationSupport.cpp; 6s local ... (8 actions, 7 running)
[2,648 / 3,349] Compiling tensorflow/core/transforms/utils/eval_utils.cc; 7s local ... (8 actions, 7 running)
[2,976 / 3,349] Compiling tensorflow/core/ir/importexport/convert_types.cc; 7s local ... (8 actions, 7 running)
[3,293 / 3,349] Compiling tensorflow/core/util/tensor_bundle/tensor_bundle.cc; 14s local ... (8 actions running)
[4,197 / 10,183] Compiling tensorflow/core/kernels/reverse_op.cc; 39s local ... (8 actions running)
[5,137 / 11,053] Compiling tensorflow/core/kernels/ragged_tensor_to_tensor_op.cc; 28s local ... (8 actions running)
[5,433 / 11,065] Compiling tensorflow/lite/kernels/conv.cc; 28s local ... (8 actions running)
[5,525 / 11,066] Compiling tensorflow/dtensor/mlir/dtensor_allreduce_scatter_optimization.cc; 31s local ... (8 actions running)
[5,921 / 11,329] Compiling tensorflow/compiler/mlir/lite/transforms/optimize.cc; 47s local ... (8 actions running)
[6,100 / 11,329] Compiling tensorflow/core/kernels/fft_ops.cc; 32s local ... (8 actions running)
[6,443 / 11,329] Compiling tensorflow/core/kernels/gather_nd_op_cpu_impl_3.cc; 9s local ... (8 actions, 7 running)
[6,950 / 11,329] Compiling tensorflow/core/kernels/cwise_op_xlogy.cc; 33s local ... (8 actions, 7 running)
[7,367 / 11,329] Compiling tensorflow/compiler/mlir/tensorflow/transforms/localize_var_handles.cc; 27s local ... (8 actions, 7 running)
[7,776 / 11,330] Compiling tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.cc; 182s local ... (8 actions, 7 running)
[8,295 / 11,330] Compiling llvm/lib/Target/AArch64/GISel/AArch64PreLegalizerCombiner.cpp; 17s local ... (8 actions, 7 running)
[8,635 / 11,330] Compiling tensorflow/dtensor/mlir/op_to_device_cluster.cc; 28s local ... (8 actions, 7 running)

My build interrupted by VM disconnection.But I am sure it can be succeeded. Please check with latest versions and let us know if having issues. Thanks!

From the log stack it seems related to java environment and logged under warning and it might not affect the build. Could you please confirm whether the build is failing or just you want to report about warnings ?
With latest versions I am sure there is no problem with builds.We have tested the builds on Ubuntu VMs and found success.Could you please confirm whether any reason for sticking to TF 2.6 version as we are not actively supporting the older versions. Request you to please cross check with latest versions.
I have cross checked the build with Master and could not notice any such warning. Please refer to attached logs below.

Thank you very much for your reply to my question. My requirement is within the scope of edge calculation. The operating system supported by jetson nano affects glibc<=2.28. So the higher version of me is a little difficult. In addition, the version of java --version here is this, I do not know whether you are consistent with this under the virtual machine, or bazel3.7.2 requires other versions of java to successfully compile tensorflow.
java --version
openjdk 11.0.18 2023-01-17
OpenJDK Runtime Environment (build 11.0.18+10-post-Ubuntu-0ubuntu118.04.1)
OpenJDK 64-Bit Server VM (build 11.0.18+10-post-Ubuntu-0ubuntu118.04.1, mixed mode)
In this picture, I used to install the gpu. The gpu and cpu have the same problem. I will feed back the screenshot of the failed installation of the cpu version to you later。

Hi @Stave604671 ,
I have not installed java environment as latest default build seems not supporting java builds. I have cross checked the .bazelrc-TF2.6v file in TF 2.6 version and found there are default java tool chains are built which is not the case with latest versions.Please refer to .bazelrc file of TF 2.12 for reference which has no default build for java.
May be this will throw some pointers on your issue.
I would like to know whether your project or OS has dependencies with java.
Our team also not actively supporting TF2.6 version now as it is quiet older.
So is there any way you can able replicate the issue with latest versions.Since our build instructions were tested only for Ubuntu OS as per attached source

Hi @Stave604671 ,
I have not installed java environment as latest default build seems not supporting java builds. I have cross checked the .bazelrc-TF2.6v file in TF 2.6 version and found there are default java tool chains are built which is not the case with latest versions.Please refer to .bazelrc file of TF 2.12 for reference which has no default build for java. May be this will throw some pointers on your issue.
I would like to know whether your project or OS has dependencies with java.
Our team also not actively supporting TF2.6 version now as it is quiet older.
So is there any way you can able replicate the issue with latest versions.Since our build instructions were tested only for Ubuntu OS as per attached source

Hi @Stave604671 ,
You can find the bazel versions and GCC versions required for each version from the documentation source.
For Tf 2.12v :

Version
Python version
Compiler
Build tools

tensorflow-2.12.0
3.8-3.11
GCC 9.3.1
Bazel 5.3.0

There is no need to set  _TF_MIN_BAZEL_VERSION or  _TF_MAX_BAZEL_VERSION.Required bazel version for each version mentioned in source code here. Please download bazel 5.3.0 version or bazelisk. Bazelisk will use the bazel versions configured for respective TF version automatically. Please follow the documentation instructions here.
Please try with correct configurations and let us know if still fails. Thanks!


mock_observables update

major rework of mock_observables.
This update adds optimized and semi-parallelized pair counters, and two point correlation functions.

@aphearin give this a run through the testing suite on your machine.  Let me know if anything fails, or I forgot to include something.

Looks great to me on a first run through. At this point, the sub-package is sufficiently mature that the best way to improve it is just to start using it. I'm going to go ahead and merge.


Color variable.language differently from other variables

Issue or RFC Endorsed by Atom's Maintainers
N/A
Description of the Change
Both textmate and tree-sitter scopes language variables (this, super, arguments) as variable.language in JavaScript (After https://github.com/atom/language-javascript/pull/620 is merged). These should be colored differently from other variables.
Looks like this:

Alternate Designs

Different color. I just picked one at random that was already defined. Ideas for a color is welcome.
Move this to base so it applies to every language and not just javascript where we have the only variable.language with tree-sitter after https://github.com/atom/language-javascript/pull/620 is merged. It's possible we will add more variable.language to other languages shortly and they already exist in textmate.

Possible Drawbacks
People that disabled tree-sitter likes the red color:

Verification Process
I checked that this is colored differently with tree-sitter enabled and https://github.com/atom/language-javascript/pull/620 merged
Release Notes

Changed the color of language variables in JavaScript to be different from other variables

/cc: @maxbrunsfeld @simurai

I just picked one at random

I'm a little worried that this particular color choice (the yellow-ish one) will be too big of a change for right now. After releasing 1.32, we've gotten a lot of feedback that people find color changes really disruptive.
Currently, normal variables are just the base text color: light gray in one-light-syntax, and black in one-dark-syntax. I think I'd be more comfortable with the change if we were to make these "special language variables" a subtle variation of that color. So on one-light, something close to black, and on one-dark, something close to light gray. Does that make sense?
It may be too disruptive to introduce a whole new color though.

Another option would be to make language.variable the same color as the base text, except bold-face.

@simurai, @Ben3eeE
Overall, when making color choices, I'd like to start thinking it something like this:

Functions have a base color (in one-light, blue).

Special, built-in functions (e.g. require) have a related color.

Types have a base color (in one-light, blueish-green).

Special, built-in types (e.g. int) have a related color.

Property names have a base color (in one-light, red).

Special, built-in property names (e.g. __proto__) have a related color.

Variables have a base color (in one-light, black).

Special, built-in variables (e.g. this) have a related color.

Strings have a base color (in one-light, green)

Special kinds of strings (e.g. regexes) have a related color.

Constructors have a base color (in one-light, yellow)

Special kinds of constructors have a related color.

And so on.
Coming from TextMate, we didn't always have clear enough information to follow such a framework, but now we do. Does that way of thinking about it make sense?

@maxbrunsfeld Thanks for the review 💯 I understand your vision a lot more now. This will help me out a lot when making tree-sitter scope changes 👍 Maybe we should document this somewhere 💭
@simurai Thanks for the review 🙇 I added a commit to address both points of review feedback:

Color it differently
Move it to base

In this commit I removed coloring red for any .variable and added a new shade of mono for these variables.
I also made it bold. It's entirely up to you if you want to keep this or not. Feel free to commit directly here or comment with what you would like me to change 🙂 I am just suggesting and I'm really bad at making things look good 😅
I chatted with @maxbrunsfeld on slack to suggest holding off on merging the language-javascript PR until this is reviewed and approved. Because we can't ship one fix without the other. Making it red.red again just feels wrong.

This change as it proposed now is gonna require some thorough test plan and verification process to go over all languages and how they scope variable.
Some prerequsite changes to better support this PR:
https://github.com/atom/language-javascript/pull/620 & https://github.com/atom/language-typescript/tree/b3-sync-with-javascript
https://github.com/atom/language-ruby/pull/250
The latest commit scopes variable.language and variable.support with the same color. The difference is that variable.language is bold.

Coming from TextMate, we didn't always have clear enough information to follow such a framework, but now we do. Does that way of thinking about it make sense?

Maybe we should document this somewhere

A guide would be great. When it comes to syntax highlighting, 2 parts are very clear:

Language packages define the scopes. E.g. variable.language
Themes define the colors. E.g. @mono-4: hsl(@syntax-hue, 14%, 60%);

But then there is this 3rd aspect: What scope should have what color? Or how do the scopes relate to each other? And here it's where things get very hand-wavy. Currently it's fined in the themes, but I think to really be able to decide, you need to understand, use and care about a language. Not sure if all theme authors do (me included 😇 ). Some options that might reduce the "randomness":

Like suggested above, have a guide/convention that themes hopefully follow.
Move the styling e.g. .syntax--support { color: @mono-4; } entirely into language packages. Then language authors can not only add the scopes, but also add the logic how the scopes relate to each other. Themes are left with defining only the colors.
Bring Atom core into the mix:

Themes define the color variables.
Atom core uses these variables to add a certain default. Think about moving _base.less into core. Then there is basic syntax highlighting for any language.
Language packages can customize, if the core styles aren't enough.

are probably not possible without breaking a lot.

Anyways, back to this PR.

Feel free to commit directly

I replaced mono-4 with mono-2. The difference seemed too small to introduce another shade of grey. We could add a 4th, but then maybe stretch it out more and make the others a bit lighter/darker. Here the example I used to test:
function a() {
  foo.aw    // default            @mono-1
  window.aw // variable.support   @mono-2
  this.aw   // variable.language  @mono-2 + bold
}

One dark
One light

Using bold, is something the One themes don't really do, but maybe ok to start using bold more.

I removed coloring red for any .variable and added a new shade of mono for these variables.

Hmm.. that feels a bit too drastic. In Less it would be:

Before
After

People might say: "Why are the variables not colored anymore?".

People might say: "Why are the variables not colored anymore?".

Yeah. You're right it's gonna break textmate grammars and not make much difference to tree-sitter. We should definitely revert that change. It would also break keyword arguments that we restored color to in Atom 1.32.1 by adding the variable class to them.

Option 2 + 3 are probably not possible without breaking a lot?

Yeah I think these would break a lot of things. Having a guide/convention both for scopes that grammars should apply and how they should be colored in relation to each other would be nice to have. Scopes seem to be kinda standard for every core grammar, maybe it's because that's how they get colored or maybe there is some convention already that I don't know about. But there are some differences. For example php has a whole lot of red with one-dark because it decided to scope local variables as variable.other.php which is red in one-dark. Other languages don't scope local variables and they have the @mono-1 color.
In the WIP pr to add a tree-sitter php grammar I have currently removed this local variable scope but I am considering adding it back as with a different class that is not colored by one-syntax. local-variable maybe. This combined with some small changes I made to my personal stylesheet makes php look like other languages with one-syntax. But given the feedback we got from other changes we made it's likely that's gonna get a lot of complaints 😅

Using bold, is something the One themes don't really do, but maybe ok to start using bold more.

I don't mind if you want to change it. I just added bold because that was what was suggested 🙂

@sadick254 This can be closed, it's no longer relevant now that #20524 is merged. It would be good to also merge https://github.com/atom/language-javascript/pull/690 to fully support reserved variables like this, super, etc.

@Ben3eeE Closing this has it has been superseded by https://github.com/atom/atom/pull/20524. Thank you for your contribution.


Can't get access to response data from a downstream service

Describe the bug
Hello, I would like to get access to the response data returned by a downstream service. In particular, in the below krakend.json, I attempt to log the status code of the response. However, I'm getting 0 (zero). What am I doing wrong? I started off the krakend docker playground. Thanks.
Your configuration file
The content of your krakend.json. When using the flexible configuration option, the computed file can be generated using FC_OUT=out.json
{
  "$schema": "https://www.krakend.io/schema/v3.json",
  "version": "3",
  "timeout": "3000ms",
  "name": "internal-resources",
  "endpoints": [
    {
      "endpoint": "/splash",
      "method": "GET",
      "output_encoding": "json",
      "backend": [
        {
          "url_pattern": "/shop/campaigns.json",
          "host": [
            "http://fake_api:8080"
          ],
          "extra_config": {
            "modifier/lua-backend": {
              "post": "print(response.load():statusCode())",
              "allow_open_libs": true
            }
          }
        }
      ]
    }
  ]
}

Commands used
How did you start the software?
docker-compose up krakend_ce fake_api

Expected behavior
I expect to see 200 in the logs

only the no-op pipes keep the status code from the response.
check https://www.krakend.io/docs/endpoints/status-codes/#returning-the-status-codes-of-the-backend for more details


Error in default e-mail validation

This is a valid e-mail:
<EMAIL_ADDRESS>But saripaar show as inválid.

@eumagnun Will upgrade to the latest commons validator code base or will add it manually.

Sorry friend,  i don't understand..
Who will upgrade it?  I can do it in my project?

You can make the change if you clone the project and build it yourself. Or else you may have to wait till I push the changes.


How to visualize a heatmap with numbers using Leaflet map?

I wish to create a heatmap similar to the following:
http://www.trulia.com/local/san-francisco-ca/tiles:1|points:1_crime
With the number changes at different zoom level - the number can appear in a mouse-hover window instead of directly showing on the map.
Any idea how to make this with Leaflet map?

Hi, and thanks for using Leaflet!
This issue tracker is used for bugs and new feature discussions. That means that questions on how to use Leaflet and similar is better discussed at Stackoverflow or gis.stackexchange.com.


Option to Disable Fade/Blur Effect at Banner Bottom Area

Hi, I have a small request. I would appreciate it if you could provide an option to disable the fade/blur effect at the bottom area of the banner. The current fade style looks great, and I definitely want to keep it as it is because it's dope, but I would also like the option to disable this effect when needed. I tried implementing this on my own with CSS, but nothing seems to work. An option to toggle this effect or a CSS snippet to disable it would be greatly appreciated.
Please find the attached image for reference.

Here's a snippet to disable these effects.
[data-light-theme=Asri] body:not(.body-asri--mobile) .protyle-background.without-icon .protyle-background__img,
[data-light-theme=Asri] body:not(.body-asri--mobile) .protyle-background .protyle-background__img:not(.fn__none),
[data-dark-theme=Asri] body:not(.body-asri--mobile) .protyle-background.without-icon .protyle-background__img,
[data-dark-theme=Asri] body:not(.body-asri--mobile) .protyle-background .protyle-background__img:not(.fn__none) {
    margin-bottom: 0
}

[data-light-theme=Asri] .protyle-background__img::after,
[data-dark-theme=Asri] .protyle-background__img::after {
    display: none
}

[data-light-theme=Asri] .protyle-background__img img,
[data-dark-theme=Asri] .protyle-background__img img {
    mask-image: unset
}

Regarding a toggle feature - I plan to develop a comprehensive plugin that will consolidate all theme-related style toggles (including these blur and fade-out effects). While I haven't had time to implement this yet, you can use this snippet as an interim solution until the plugin is ready.

Thanks, that was quick. I'm excited about the plugin and looking forward to it. You have done a great job overall with this theme, and I think this is currently the best theme in SiYuan. I really appreciate your efforts.


[WIP] Adding ability to qualify the entry point of the main assembly

Trying to resolve the correct entry point of the main assembly.  I don't think this can be done the absolute right way without further support from mono-wasm -- i.e. a way to read the EntryPoint metadata from the assembly.
Until then, I'm proposing an alternative -- resolve the EntryPoint MethodInfo during the build process, and supply that detail in the boot config data, along with the entry point assembly.  I think this a pretty reasonable compromise and removes the hard-codedness of assuming an entry point with a namespace == assembly name, and fixed class and method names.
I'm submitting this PR to start a discussion on this approach -- these changes are tested and working, but they're a bit hacky, so if this approach is acceptable, there is a bit more clean up left.

Thanks - this makes sense! I definitely agree it would be good to stop having the hardcoded assumption about the entrypoint being {assemblyname}.Program::Main.
Suggestion 1:
It might be preferable not to use Assembly.Load(clientApp) inside the build process, just to avoid any possibility that loading the assembly into the build process has unexpected side-effects. Ideally this would be by using Assembly.ReflectionOnlyLoad, but that's not available on .NET Core as far as I know. But we could use Mono's Cecil library to determine the entry point without using Assembly.Load - we're already using Cecil during the build process to discover the chain of references (https://github.com/aspnet/Blazor/blob/dev/src/Microsoft.AspNetCore.Blazor.Build/Core/FileSystem/FrameworkFiles/ReferencedAssemblyFileProvider.cs#L63).
Suggestion 2:
One minor point is that instead of the custom {assemblyname}@{namespace},{type},{method} format it would be nice if we used the standard CLR-style [{assemblyname}]{namespace}.{type}::{method}() format. Examples:

[YourApp]YourApp.Program::Main()
[YourCompany.YourApp]YourCompany.YourNamespace1.YourNamespace2.AppStartup::StartupApp()

I know it's a bit more work on the parsing side, but will at least be familiar at a glance to .NET developers.
Your thoughts?

I’m thinking why not decorate the entry point with a attribute, this would then allow better descriptive code generation and commenting around usage and if the entrypoint accepts any args, which at present is also hardcoded to an empty string array.
attribute could be
namespace myCompany
{

public static class myApp
{
[WebAssemblyEntryPoint()]
[WebAssemblyEntryPointAcceptsArgs(true)]
public static void main(string[] args)
{}
}
}

IMHO this would also open the door for having multiple entrypoints per wasm and could allow switching of wasm without additional downloading, assuming the generation of blazor.js was don’t in such away that the scripts supported it.
This is simply a brain dump of an idea, would love to hear your thoughts before doing a POC/PR

@SteveSandersonMS, thanks for the feedback.
Regarding suggestion 1:  yes, already discovered that ReflectionOnlyLoad is not supported on Core.  Also looked at System.Reflection.Metadata, but that didn't include the needed metadata.  I didn't think of Cecil -- great idea, thanks, I'll look into incorporating that.
Regarding suggestion 2:  actually the way that I currently have it formatted was just a quick hack to experiment with the idea and test it out with minimal changes to the existing config structure and touch as little as possible of the existing code.  Moving forward with this approach, what I was thinking is actually keeping the main assembly attribute untouched and adding a new entry-point attribute to the boot config data.  This new attribute would use the format {namespace}.{type}.{method}, so a full example:
<script src="/_framework/blazor.js"
    main="Sample.BlzrApp.dll" entry-point="Sample.BlzrApp.Program"
    references="lib1.dll,lib2.dll,..."></script>

This format is more consistent with the way the entry point is declared within an MSBuild file (the StartupObject property) or the compiler CLI parameter /main.  They simply let you qualify the class, the method name is assumed (required?) to be Main.
Now this does force you to use a Main method, but that is actually stipulated by the platform, so not something we're introducing in Blazor.  Thoughts?

@grahamehorner, if we stay with a console-style project format, I don't think it's necessary to add a new attribute for this purpose.  As the project format already has indicators in the form of the StartupObject property in the MSBuild file, which in turn gets passed on to the CSC compiler as a parameter to qualify the entry point.
However, I see that @SteveSandersonMS has indicated in #7 that he wants to move from netcoreapp2.0 project type to netstandard2.0 -- if that's the case, then we will need to come up with a way to flag the entry point.
Regarding entry point args, with the changes in #93, I think the simplest way to support that would be to allow a user-specified args="arg1,arg2,arg3" attribute in the boot <script> tag.  If found and the entry point method takes an array of string as a parameter, the entry point would get invoked with these args passed in.

@ebekker IMHO the args should simply follow the same as a commandline which is split on a space and not a comma the args can the be passed to the aspnet ConfigurationBuilder or what ever the developer wishes just like a console app; with regards to moving to netstandard 2.0 I can understand why and think any work/changes/development that is carried out should be mindful of this probability and should be done in such away that such a change wouldn’t have massive implications or a redevelopment.
I also believe that the injection of the script tag into the index.html may be something that limits options, ie. if I wish my hosting page to dynamically inject multiple wasm entrypoints with some server side user context/args I would be using a RazorPages *.cshtml with some code behind that injected the blazor-configure for each of the entrypoints

Thanks again @ebekker - this is now merged :)


Update hugo to 0.107.0 and hugo-install to >=4.0.1

Summary
Update hugo to the latest version, there are various performance improvements and bug fixes.
Hugo has changed how they name the packages so hugo-install needs to support that.
Basic example
N/A
Motivation
Improvements in hugo
Checks

[X] Read Create a Pull Request
[N/A] Supports all screen sizes (if relevant)
[N/A] Supports both light and dark mode (if relevant)
[X] Passes npm run test

So, according to the logs the problem was package-lock.json being not synchronised. I've fixed that. Hopefully that's sufficient.


Feature/postgres grammar support UUID

UUID support as column type and as primary key type.
Can also search directly as type UUID.

@sdispater Could you please merge this if you're okay with it?

🙏

@inventionlabsSydney I don't think @sdispater will have time to look at it. I've sudo taken over this project. I've been merging a lot of PR's lately and looking at issues as the Masonite framework (my main maintainer project) is slowing down and getting ready for a release.
My only problem with this (and I will test it when it's done) is that what about mysql and sqlite migrations?
If we merge this in what will happen when I merge it on a MySQL database? Orator is supposed to be database agnostic so we can't merge database specific features. It would either need to come as a feature of all 3 or map the UUID to something on mysql databases.

Hey @josephmancuso Thanks so much for getting back to me.
So currently I'm working on MySQL and SQLite support for UUID.
I'm happy to hold off and provide those prior to merging, I can definitely see the rationale as to ensuring all DB's support all functionality.
Thanks,
Karl.

Hey @inventionlabsSydney! Nice to meet you... I`m looking for same on Orator :) Need any help with MySQL and SQLite support for UUID ?
Maybe works like Django, using something like "extension" when build the table for Postgres, importing JSONField().
Im still starting with Orator, so its possible Im talking completely out of the scope.

@rfschubert Hey sorry I was on holidays!
Yeah I'd really like someone to do the MySQL and SQLite support!
Lets go through it this week if you'd be okay with that?

Where did this land? Still in development?

@inventionlabsSydney @rfschubert Did either of you make progress on MySQL and SQLite support ?
I'm considering this PR for https://github.com/MasoniteFramework/orator

Hey guys,
Sorry I haven't been responding I've been incredibly swamped.
I will work on this very shortly and get the base to work fro MySQL and SQLite.
@mandarvaze I'm going to sync with your fork and start making my changes.

Bump
Any ide on when this will be implemented please?

Hello there.
Any update about it? It's quite important to avoid using uuid as a string and performance issue on databases

Hello there.
Any update about it? It's quite important to avoid using uuid as a string and performance issue on databases

Any update ? @inventionlabsSydney

@circulon @RyanAquino @digmunhoz Have you guys looked into https://github.com/MasoniteFramework/orm? Its in version 1 at the moment and we could deff work on a solution to there


Duplicate plugin

@lorisleiva  I just found there's already a vuepress-plugin-disqus(created by you) when I run yarn publish.  I've made a mistake. I should've searched it on npm before working on it.
I currently release it as vuepress-plugin-disqus-comment, but I'm looking forward to integration.
There're some extra features in my duplicate plugin, such as:

config globally
build-in SSR friendly component
use vuepress's $lang as default language

Here's my duplicate vuepress-plugin-disqus.

Hi there 👋
Yeah definitely, I'm always trying to improve my open source contributions.
Maybe do one PR for each of these additions/changes so that we can discuss each matter separately.
Thanks for opening this issue. 👍


⚠ Bofrost.de has degraded performance

In 0a182e3, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1403 ms

Resolved: Bofrost.de performance has improved in 92925f0 after 9 minutes.


Load overlay maps in the tileserver

an_gambiae_map.zip
Use the example map here to build a script that converts a tif into an mbtiles file using the output from #7
This mbtiles file should be loaded with the tile server manually for now and we should use lessons learnt from this story to generate a new one about updating the config file automatically. The idea being eventually that a modeller might upload a tif file and then the system will automatically generate the mbtiles file and update the config. This may be a step too far and it may be a support process to update the maps but we won't know till after this story.
The list of maps returned by the API also needs to be updated, this depends on #74
Acceptance criteria:

[x] model output tif files can be converted to mbtiles files
[x] model outputs can be served as layers from the tile server
[x] the API returns the correct list of layers based on what is served from the tile server.

All AC met.
I have successfully converted a sample model tif file to an mbtiles file (an_gambiae_map.tif to an_gambiae_map.mbtiles).
A GET request made to http://localhost:1234/vector-api/config/tile-server-overlays will return the layers.


Does not work with non-integer ID

hi, I use uuid for primary keys, and therefore cannot use your bundle, how difficult is to change the code to support non-integer ids?
thanks

@calvera Is will be possible in a few days when v3.0.0 is released.

so looking forward to it :) thanks


Update app icon for the Front-End Box

Hello, guys!
Just updated the icon for the Front-End Box app.
Merge it please.
Thanks!

Looks good!


failed to launch chromium browser process errors

get errors on launch of browser process; below is the error from terminal which happens for all browser processes trying to launch.
INFO     | metagpt.utils.mermaid:mermaid_to_file:38 - Generating /Users/lopezdp/DevOps/Ai_MetaGPT/workspace/test_app/resources/competitive_analysis.pdf..

Error: Failed to launch the browser process! spawn /usr/bin/chromium ENOENT

TROUBLESHOOTING: https://pptr.dev/troubleshooting

    at ChildProcess.onClose (file:///Users/lopezdp/DevOps/Ai_MetaGPT/node_modules/@puppeteer/browsers/lib/esm/launch.js:253:24)
    at ChildProcess.emit (node:events:513:28)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12)
    at onErrorNT (node:internal/child_process:485:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)

I used the following:
brew install chromium && which chromium
I obtained the path where chromium was installed, then I replaced the executablePath values in /config/puppeteer-config.json with the values obtained from the terminal after chromium installation and it worked.


Enable smartypants for curly quotes, ... ellipsis, -- en dash, --- em…

… dash.
Fixes https://github.com/observablehq/notebook-runtime/issues/73 - saves us seconds or perhaps hours of meticulously curling quotes.

Our options here are:

Keep the current behavior
Invest some time on getting marked's smartypants mode up to par with Medium's intelligence and then turn smartypants on
Turn smartypants on, and set a backlog item to improve the quote-curling

My preference is for the last one, of course, because smartypants is only wrong a fraction of the time and in those cases we can override it by adding an explicit-direction-quote, and also because even of the really well-written notebooks out there, most people who aren't us aren't going to spend the time typing curled quotes and ... etc when most of the time platforms do that for them.

Closing; still in favor of enabling smartypants, but we'd need consensus to do it.


fix(notification-box): Notification window doesn't close on clear all action

run tests

Check styles

#1193 instead


Publish toggle

@viktor-yakubiv It looks ugly but the functionality is in there. We can play with styles later.

@Joozty do you want me to merge or you would like (me) to work on it more?

I changed the colours and animation. If you want me to work on it more please tell me what's should be improved.


How to hide not-meaningful APIs

I wanted to create REST API in one project with requirement that it only have GET method (is for read only)... However documentation via ApiDocu still puts the documentation from persenter to the documentation:

How can I get rid of it (the second row)?

@repli2dev Can you show me your presenter code?

Yes, here: https://github.com/datoszs/czech-lawyers/blob/develop/app/API/Presenters/AdvocateAutocompletePresenter.php

It didn't help, the generated API doc looks still the same.

@repli2dev Aaaah, sorry. Fixed in 1.2.10

Installed ublaboo-router 1.2.10, regenerated API doc, but nothing has changed.

@repli2dev Have you flushed the cache?

Yes :/


Make this package work with the latest version of Kotti.

@reedobrien Hi. Is there any interest in this should this PR now be closed and deleted?

Thank you very much @mgrbyte.


FR: use litellm for easy support of mistral, anthropic, openrouter, ollama, huggingface etc

Hi,
I've been using litellm for a while now, it's a python library that enables using pretty much any API you can want for LLMs (Mistral, openrouter, localai, huggingface, azure, anthropic, etc).
And they support async too!
I think it would be nice to avoid being too reliant on OpenAI vs other providers.
Is that something that could be done ?

I came here to see if Claude support was planned as their latest model is reported to be good for coding.
Something like this would be great and it would take the pressure off this project to support more models directly.

I would love Claude support, are you working on litellm integration?

I would love Claude support, are you working on litellm integration?

If you follow what I did it already works with Claude through litellm.

ogpt.nvim is a derivative plugin with support for other api

For mistral, here's my config.yaml:
model_list:
  - model_name: gpt-4-0125-preview
    litellm_params:
      model: mistral/mistral-large-latest
      api_key: REDACTED

Launch the proxy with litellm --config config.yaml --port 5000
Add this to your chatgpt.nvim config: api_host_cmd = "echo http://<IP_ADDRESS>:5000",
I seem to be having issues with their docker though

@thiswillbeyourgithub Have you tried using docker compose? That's what worked for me.
I created a simple docker folder with their docker-compose.yaml and my own proxy_server_config.yaml and it works great.

I didn't try docker compose and wanted to test their docker run directly. I'll get to it someday thanks

For openrouter, you can use something like this
{
    'jackMort/ChatGPT.nvim',
    event = 'VeryLazy',
    config = function()
      require('chatgpt').setup {
        api_host_cmd = 'echo -n https://openrouter.ai/api',
        api_key_cmd = 'echo ' .. your_openrouter_apikey_as_string,
        api_type_cmd = 'echo localai',
        openai_params = {
          model = 'openai/gpt-4o-mini',
          max_tokens = 300,
        },
        openai_edit_params = { model = 'openai/gpt-4o-mini'}
      }
    end,
    dependencies = {
      'MunifTanjim/nui.nvim',
      'nvim-lua/plenary.nvim',
      'folke/trouble.nvim',
      'nvim-telescope/telescope.nvim',
    },
  },


"brew install awk" breaks z

If you install the copy of awk from Homebrew, it causes z to break.
brew install awk
==> Installing awk from homebrew/homebrew-dupes
==> Downloading http://www.cs.princeton.edu/~bwk/btl.mirror/awk.tar.gz
Already downloaded: /Library/Caches/Homebrew/awk-20121220.tar.gz
==> make CC=clang CFLAGS= YACC=yacc -d
🍺  /usr/local/Cellar/awk/20121220: 4 files, 168K, built in 2 seconds

After you install awk, running z, with or without arguments prints..
z
awk: illegal statement
 source line number 68

you want to install gawk from homebrew, which works just fine with z


Suggested updates to core-devel

Work in progress; will keep adding commits here until the return of our illustrious leader..

Still can't get the webcam viewer working. I see this error:
Traceback (most recent call last):
  File "/home/luke/work/pyacq/pyacq/viewers/imageviewer.py", line 61, in poll_socket
    data = data[::-1,:,:]
TypeError: byte indices must be integers, not tuple

..and then the next time I run the example, I can't open the camera anymore until rebooting (no zombie processes, and no other applications can open the camera either).


Fixing the droppable settings to allow changing tolerance

Changed line 339 to allow the tolerance parameter from the jquery ui droppable element, so it can be changed from 'intersect' to any of the 4 options availavble. If not provided, uses default 'intersect' tolerance.

No. Use jqyoui-options attribute to pass any valid options supported by jQueryUI Draggable.


Wrong realization of 'minus operation' [maybe] of Date object

I run the following code in Characore-1.11.15 and get a very odd output. I do not know why the output is so strange. The two print should be same output, both 0. However, the first is -5 in ch. I think there must be something wrong in ch's realization.
The code:
var tmp = new Date() - new((2, function() { return Date })());
print(tmp);

var tmp1 = new Date() - new(Date);
print(tmp1);

print("BT_FLAG");

Output
-5
0
BT_FLAG

The result should be:
0
0
BT_FLAG

ISec Lab
2019.12.21

Done a bit of digging this is not a bug. The difference arrises on creation of the Date objects, not when doing the subtraction.
The numeric value of a Date object is a timestamp in milliseconds - there is a 5 millisecond jitter on timestamps in chakracore - introduced intentionally as a spectre mitigation.


nvcc failed in pytorch1.0

How to change your code to run with pytorch1.0? Thank you!

#10 might help you


Fix: make derive default work again

I accidentally skipped it for all structs instead of all enums...
Fixes a bug in #241.

Thank you!


[RNGP] chore: migrate ReactActivityDelegateTest to AssertJ

Summary:
Issue: #45596
Changelog:
Migrated to AssertJ within file:

ReactActivityDelegateTest.kt

[Android] [Changed] - Migrated ReactActivityDelegateTest

Test Plan:
Run ./gradlew -p packages/gradle-plugin test

@cortinico, this is done!


Deprecate and remove the input contrast prop

The contrast prop, when applied to Select, TextInput, or Textarea (one would also expect it on TextInputWithTokens but it's not available there) renders an input with a subtle background, somewhere between the default and disabled styling:

In dark theme it has no effect:

The documentation says this prop:

Changes background color to a higher contrast color

But ironically it actually reduces the contrast between the text and background.
This prop is problematic because, as shown above, it can make active inputs look disabled. This can and has caused confusion for users, and so the recommendation and effort has been to avoid using it in GitHub UI (including in PVC components). We've been considering getting rid of it for a while, so  let's get it done.

I agree that we should get rid of the contrast prop. It's purpose was so you could have an input on a "secondary" background color (#f6f8fa) match the contrast of an input on a "primary" background color (#ffffff). However, it's often misused.
Here's an image for demonstration purposes:

I'm worried about a default transparent background breaking designs where we're only able to reach the 3:1 contrast minimum because of the white input background.
I think this use-case is pretty rare and can be safely handled with style overrides.

I will remove it in Figma. @mperrotti please always ping me in issues like this so I can take care of the Figma work. Thanks 🙏


Fixed #27844 -- Added optimizemigration management command

Hi,
Tackling https://code.djangoproject.com/ticket/27844
I made a quite specific choice for the logic of the command. By default, it overwrites the named migration. But if some manual porting is required, it will rather try to create a replacement migration. My thought was that, if functions need manual porting, we don't want to lose the code by overwriting the migration file.
Tell me what you think of this :)
I might also have missed spots where documentation should be added

Hi @felixxm
Thanks a lot for the review :100:
I rebased, reformatted and addressed your comments. I hope I didn't miss any :)


⚠ Bofrost.be has degraded performance

In 140862c, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 3636 ms

Resolved: Bofrost.be performance has improved in f66b964.


new script: silverbullet

Description
I was looking into Silverbullet today and while installing it in a debian LXC I created this install and update script. Since Silverbullet was already requested (#127) and it's already on the backlog, I figured: why not.
Fixes #127
Type of change
Please check the relevant option(s):

[ ] Bug fix (non-breaking change that resolves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
[x] New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:

[x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
[x] Testing performed (I have tested my changes, ensuring everything works as expected)
[x] Documentation updated (I have updated any relevant documentation)

Additional Information (optional)
I intentionally decided against using the silverbullet upgrade command, since this would require installing and running the entire deno build. Using pre-built binary just feels better for production use.
Ref: https://silverbullet.md/Install/Deno#Upgrading
Related Pull Requests / Discussions
If there are other pull requests or discussions related to this change, please link them here:

Related PR #

It's not worth checking every line for now, there are so many errors and things that don't fit the conventions of our system.
Please check correspondence objects such as kimai, snipe-it, komga, vikunja, bookstack etc.

It's not worth checking every line for now, there are so many errors and things that don't fit the conventions of our system.
Please check correspondence objects such as kimai, snipe-it, komga, vikunja, bookstack etc.

I could really use some pointers then. I used the scripts to install and update Silverbullet on my running Debian LXC, so I am wondering what errors there are.
To be quite frank, it is impossible at the moment to find "the right way" to do things, and I get the feeling it keeps changing with every PR I create..
I looked at traefik, trilium, debian and zoraxy, which I recently updated, when creating the scripts.
I did add some improvements (or so I thought), like checking the service is actually running after install and update. Is this what you are referring to?

To visualize my point, this is a side-by-side comparison of the updated scripts between vikunja and the newly added silverbullet. The boilerplate code is all the same, the things that are different are because it's a different app that's being installed.

Short review only with the mobile phone. We don't do the whole thing with services etc. like this. In general, take a look at current scripts and not the ones you mentioned above, which have not been revised for ages.

Thanks for the review! Will address asap.

I just noticed, the project card for this wasn't moved to "In PR" yet. Can someone take care of it for transparency?


Multi-line or long text entries in boxes are not displayed properly when loaded in the editor

If the length of a string value exceeds the default width of the field, the text spills over. Fields will automatically resize themselves when actively typing a long string, but the behavior upon loading is wonky:

One thought: Adding height: auto; to the edittext CSS styling might fix this


How to change working-directory ?

Is it possible to add a feature to change the directory where poetry install is executed with an optional argument like working-directory ?

If you set the POETRY_HOME environment variable, it should be respected I believe. See https://github.com/snok/install-poetry/issues/127 :+1:

Thanks a lot!

@sondrelg Sorry, I misunderstood answer. I'm looking for a way to change the path where 'poetry install' is executed, not where poetry is installed.

I was completely mistaken.. snok/install-poetry does not run poetry install, so this issue was meaningless.

Just in case this helps or someone else checks this in the future:
- name: poetry install
   working-directory: /app
    run: poetry install


Fix line length

It might be nice for some of the earlier commits in this had better title lines than Fix Line Length. Can you rebase so they're more like Fix line length in Heathcheck Controller and so on?

@SteveMarshall will do that once I finish with all. I will go back and add what I fixed.

@SteveMarshall changed it!!

How do we feel about trailing )s?
For example:
token = encryptor.encrypt_and_sign(
   attach_vo_number(
     remove_unused_slots(
       booked_visit, @confirmation.slot),
     @confirmation))

versus:
token = encryptor.encrypt_and_sign(
  attach_vo_number(
    remove_unused_slots(
      booked_visit, @confirmation.slot
    ),
    @confirmation
  )
)

I prefer the latter, but am open to leaving it as the former if
everyone else is fine with that?

@SteveMarshall I feel the same as you about trailing )s: I think it's more consistent with the rest of the codebase to put them on a new line.

Tested on preprod, but email processing is not working, so I can't test the staff admin side. Blocked until queue processing is fixed.

Emails should be working on preprod again now, @EGiataganas. Test when ready! (And rebase against master, perhaps?)

@SteveMarshall :+1: Thank you very much. Will do that now.

@SteveMarshall @threedaymonk Tested on preprod & email processing is working.


bug: http response stream not interruptible

Preparations:

cd packages/platform-node/examples
tsx ./http-tag-router.ts
visit http://localhost:3000/users/stream in browser

Steps:

send ctrl+c to the server process

Observed:
Process don't exit
Expected:
Process exits

It looks like one way to do it, is via:
const GetUsers = UserRouter.useScoped((router) =>
  Effect.gen(function*() {
    const ps = yield* PubSub.unbounded<Uint8Array>()
    yield* Effect.addFinalizer(() => ps.shutdown) // doesn't help

but shouldn't the http server terminate the listening to the Stream instead?
the above would never allow streams to be finished, even if you wanted the request to be uninterruptible


Remove println statment

When starting up the server a few messages are printed using fmt. Can we use a logging library instead so that these statements can be enabled and disabled as required? Using the logging library gives us more control.
I noticed that k8s.io/klog/v2 was imported and used else where in the code base but it did not appear in the go.mod so I have run a go mod tidy to ensure the dependencies are up to date.

Already cleaned this up in another commit


Fixed timer display bug, removed extra files

Closing since Krista also fixed this bug in her new branch.


Migration of the example app backend from Parse

Parse is shutting down. I'm evaluating to migrate a copy of the example app to Backendless (similar to Parse) or to Baasbox (an open source alternative) in order to modify it and test it . Have the creators of this app chosen yet an alternative to Backendless?

Hi @NicolaGiulietti! Thank you for looking into this! :)
Yes, Backendless does indeed look like a good candidate and as you mention there are several alternatives. We've been busy working on integrating Chateau into our apps for the last few months so that is why we are a bit behind on pushing changes to the open source part of if.
The next push will contain quite a few breaking changes to some of the APIs (mostly related to the Message and Conversation data sources and the use cases which operates on them). After that is done we were planning to start on migrating the example app away from Parse.
Any input or prototyping is very welcome as well as suggestions for other backend alternatives to consider.
Thanks again for contributing!
--Erik


feat: Idempotency helper utility

Issue #, if available: #218
Description of changes:
Implementing RFC #218. I'll be working together with @igorlg on this.
Todos

[x] Implement caching
[x] Update caching implementation with LRU / max size
[x] Review/replace error handling implementation (especially the pickle bit, which currently causes security baseline to fail the build)
[ ] Add unit tests and complete integration tests
[x] Review/remove table creation logic/implementation
[x] Add logging
[ ] Add docs
[x] Add payload validation
[x] Improve exception handling for unrecoverable errors from persistence layer

Checklist

[X] Meet tenets criteria
[ ] Update tests
[ ] Update docs
[x] PR title follows conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #245 (ee46124) into develop (fa34d82) will decrease coverage by 0.86%.
The diff coverage is 88.48%.

@@             Coverage Diff             @@
##           develop     #245      +/-   ##
===========================================
- Coverage    99.88%   99.02%   -0.87%
===========================================
  Files           70       83      +13
  Lines         2600     2968     +368
  Branches       109      133      +24
===========================================
+ Hits          2597     2939     +342
- Misses           3       21      +18
- Partials         0        8       +8

Impacted Files
Coverage Δ

...bda_powertools/utilities/idempotency/cache_dict.py
71.42% <71.42%> (ø)

...da_powertools/utilities/idempotency/idempotency.py
87.87% <87.87%> (ø)

...da_powertools/utilities/idempotency/persistence.py
90.76% <90.76%> (ø)

...ambda_powertools/utilities/idempotency/__init__.py
100.00% <100.00%> (ø)

...bda_powertools/utilities/idempotency/exceptions.py
100.00% <100.00%> (ø)

...lambda_powertools/utilities/data_classes/common.py
93.75% <0.00%> (-6.25%)
:arrow_down:

aws_lambda_powertools/tracing/tracer.py
98.89% <0.00%> (-1.11%)
:arrow_down:

aws_lambda_powertools/metrics/base.py
100.00% <0.00%> (ø)

aws_lambda_powertools/logging/logger.py
100.00% <0.00%> (ø)

aws_lambda_powertools/logging/formatter.py
100.00% <0.00%> (ø)

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa34d82...ee46124. Read the comment docs.

Codecov Report

Merging #245 (ee46124) into develop (fa34d82) will decrease coverage by 0.86%.
The diff coverage is 88.48%.

@@             Coverage Diff             @@
##           develop     #245      +/-   ##
===========================================
- Coverage    99.88%   99.02%   -0.87%
===========================================
  Files           70       83      +13
  Lines         2600     2968     +368
  Branches       109      133      +24
===========================================
+ Hits          2597     2939     +342
- Misses           3       21      +18
- Partials         0        8       +8

Impacted Files
Coverage Δ

...bda_powertools/utilities/idempotency/cache_dict.py
71.42% <71.42%> (ø)

...da_powertools/utilities/idempotency/idempotency.py
87.87% <87.87%> (ø)

...da_powertools/utilities/idempotency/persistence.py
90.76% <90.76%> (ø)

...ambda_powertools/utilities/idempotency/__init__.py
100.00% <100.00%> (ø)

...bda_powertools/utilities/idempotency/exceptions.py
100.00% <100.00%> (ø)

...lambda_powertools/utilities/data_classes/common.py
93.75% <0.00%> (-6.25%)
:arrow_down:

aws_lambda_powertools/tracing/tracer.py
98.89% <0.00%> (-1.11%)
:arrow_down:

aws_lambda_powertools/metrics/base.py
100.00% <0.00%> (ø)

aws_lambda_powertools/logging/logger.py
100.00% <0.00%> (ø)

aws_lambda_powertools/logging/formatter.py
100.00% <0.00%> (ø)

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa34d82...ee46124. Read the comment docs.

@cakepietoast I've left some comments above. Sorry if some have been already discussed as I may have missed the conversation as I joined this thread very late (but basically because I'm very interested in this util) - let me know if I can help in any other way.

@cakepietoast I've left some comments above. Sorry if some have been already discussed as I may have missed the conversation as I joined this thread very late (but basically because I'm very interested in this util) - let me know if I can help in any other way.

@cakepietoast @heitorlessa Once you think the api for this is stable enough, i don't mind running some beta testing against a build of this.

@cakepietoast  maybe we can later reference this utility (or to a blog post) from the warning in the SQS Batch Processing docs


It's bugged

Challenge Size your Images has an issue.
User Agent is: Mozilla/5.0 (X11; CrOS x86_64 8530.81.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.103 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

<link href="https://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">

CatPhotoApp

Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.

Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.

@goku582 Please click the help button and get feedback on your code in the chat room. You have an error and have not met one of the criteria.


What needs to change for v2.2?

I will get around to testing this, but there are some great new performance increases and features, and some breaking changes. Does it effect FairyGUI?
https://discuss.cocos2d-x.org/t/cocos-creator-v2-2-0-released/47937

Best regards

Yes. It has been tested under cocos creator v2.2.

We have tested  it under cocos creator v2.2。

confirmed, it works on 2.2.0 ccc


No controls for Desert Biomes, Ice Spike biomes missing in oceans

When I tried the mod I noticed there are no controls for Desert Biomes in the world generation. The way to get the frequency up for now is to scale down the frequency of all the other biomes. It would however be nice if controls would be added. I've also noticed there are no ice spike biomes generating, although I could understand if these were left out to get a more realistic world. Maybe a toggle for this biome or biomes in general would be nice.

There are temperate/moisture sliders in v0.0.8
Ice spikes biomes 100% do spawn, they're just rare


When viewing an incoming request, show the available inventory for each item requested

Current behavior
When viewing a request (requests#show), it currently just shows a breakdown of what the request is for -- the user cannot see whether or not they have the inventory on hand to satisfy this.
Desired behavior
Adjacent to the requested quantities, have another column called "Estimated on-hand"  that provides the current total of on-hand inventory for that item. Remember that inbound requests are dealing with CanonicalItem supertypes directly, so query based on the partner_key and sum across all storage locations.
Criteria for Acceptance
Please also write a test to cover this feature, and ensure you run rubocop -a and correct any violations before pushing (Travis will complain otherwise). If you write any Model or Controller methods, please test those as well.

I'm currently working on this but I can't assign myself in GitHub


fix(es/typescript): Strip class modifiers

Description:

BREAKING CHANGE:

Related issue (if exists):

I found that we can include this patch in 1.7.8

The ts-type strip still needs one or two additional fix.

I found that we can include this patch in 1.7.8. Can you fix the CI failures?

patch-section.sh removed in c977c2bec2b0f9771031ed6ebc15bffb0f33eae0.
How to fix it?

You can do cargo install cargo-link2 and do cargo link ../ from ./bindings. Sorry, I forgot documenting it.

error: the #[global_allocator] in swc_malloc conflicts with global allocator in: swc_malloc

The CI process has failed due to a conflict with swc_malloc. Could you help me? @kdy1

I'll take on this


Frontend: Fix Self with sub obligations

cc @sonmarcho, I will just go ahead and fix that, I'll let you cherry pick that commit in the charon merging branch

Ok thanks! Ping me once this is done.


[$250] mWeb-distance rate-Selected Distance rate amount (IQD 0.7) is not shown in rate page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to https://staging.new.expensify.com/home
Tap on profile icon -- workspaces-- workspace
Tap more features -- Enable distance rate
Tap profile and change currency to IQD
Tap back
Tap distance rates -- rate -- rate

Expected Result:
Selected Distance rate amount (IQD 0.7) must be shown in rate page
Actual Result:
Selected Distance rate amount (IQD 0.7) is not shown in rate page. Rate page shows amount as zero
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/057ca424-7d51-413e-8c31-d6d46e989e3b
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fe275e58c3e4afa6
Upwork Job ID:<PHONE_NUMBER>794199886
Last Price Increase: 2024-07-18

We think that this bug might be related to #vip-vsp

@greg-schroeder  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@greg-schroeder Can you help to confirm the expected behaviour here? As the IQD currency doesn't support decimals, so it's the expected behaviour to show zero in the amount input.

Should we replace rate IQD 0.7 with IQD 0 ?
This should be expected as IQD currency doesn't support decimals

@eh2077 sorry do you mean the currency itself doesn't support non-integer values? I'm not sure that's true is it? 🤔

@greg-schroeder Yes

@greg-schroeder Can you help to clarify how we should move forward with https://github.com/Expensify/App/issues/44846#issuecomment-2227373806 ? Given there're indeed a few currencies that doesn't support decimals.

I don't know, according to the internet it does support decimals so I'm not really sure where that's coming from. I'll ask the team though.

Not overdue, we're waiting for clarification from team

discussion: https://expensify.slack.com/archives/C01SKUP7QR0/p1721862196701789

We're going to close this per the internal discussion. From Tom

I agree it’s a little weird how we take the default USD distance rate and convert it into the workspace currency (so in this case it comes out at 0.7 IQD when you enable distance, and that currency likely starts at 1 or something), but that’s consistent with what we’ve been doing for years across OldDot.
In reality, I think anyone who is going to be using distance rates in foreign countries will enable the feature and immediately change the rate to what’s accurate in their local currency when setting it up.
So I think we can just close this and not worry about it, as it has very minimal impact in reality. :+1:


[FR]: Font size for table

Contact Details
No response
Present your request
It would be great to have a specific font size for all DB Folder views.  I would like to see more on my screen for DB folder as compared to a normal text file.  A general font size setting would be great.
For which platform do you request this request??
Desktop

Hi @ShravanSunder ,
We have a compact mode on ddbb settings to reduce the space per row.
Also the plugin is using the font size configuration of Obsidian.
Tell me if that solve your use case

@RafaelGB What i mean is that it would be good for DB Folders (being a spreadsheet) to have a different font size configuration compared to other obsidian documents.  It makes it easier to see in the spreadsheet use case.

I will investigate about to create a percentage setting of the Obsidian font size with a scroll just like pagination

Font size selector included =)
https://user-images.githubusercontent.com/11924043/206704088-5ba427ea-4850-4380-84cd-1c040d0eba7e.mov

I really like this feature! I just tested the 3.1.0-beta.1 release (installed via BRAT) and the font adjustment only works for non-text cells. I am working on Linux and have not tested this on other platforms yet.
Also: It would be nice to have some text-size indicator and/or "reset to standard size" button in the settings to see what font size is currently selected.


TypeError: Dataset_Custom.init() got an unexpected keyword argument 'seasonal_patterns

bash ./scripts/multivariate_forecast/Traffic/iTransformer.sh

fixed in https://github.com/thuml/iTransformer/commit/5ea0159de754533447ff014e0df659e90e52fc02


Possible to auto align the text?

I mean, align the text printed to the output something like:

It will do this if you send it that way... tabs mare supported as well.
Debugview can't know how/what to align so you have to that yourself.
Selecting a proportionally spaced font like Courier otherwise it won't look
right...
On Mon, Sep 13, 2021, 01:51 pepeu93 @.***> wrote:

I mean, align the text printed to the output something like:
[image: image]
https://user-images.githubusercontent.com/82878129/133006732-d4c4e66c-97d7-4ba8-a1e0-6f33349150b1.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CobaltFusion/DebugViewPP/issues/377, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNITBFITEN5RXNTUKRAW2LUBU4IHANCNFSM5D4T3NFA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


foundry latest update

Description:
Since there were some changes to deploy scripts we will need to update erc-20 and other extensions .args.mjs files.
To test:
Run:
yarn dev

In second terminal:
yarn cli -s foundry

Checkout the README: https://github.com/scaffold-eth/scaffold-eth-2/tree/foundry
To test erc-20 exmaple:
yarn cli -s foundry -e scaffold-eth/create-eth-extensions:foundry-update-erc-20

Thanks @rin-st lol was planning to tag you today but you already reviewed it!! Merging this!


contaiers: Add information about pre-build.conf

As per:
https://github.com/foundriesio/ci-scripts/commit/0039b6e3ca04b31295ecf7c5fa44c0fb9354a087
Signed-off-by: Andy Doan<EMAIL_ADDRESS>

@mike-scott - as per the change Gwen submitted today.
@MatthewCroughan - just and FYI.

Docs for 8daef41a09b4210ab8655f785dd89a10f3f1591c are browesable at: https://ci.foundries.io/projects/fio-docs/builds/574/docs/artifacts/html/index.html


Merge various fixes into master

TBD

How is #517 different from #516?  They seem to have a lot of the same
content in them... ?
On Mon, Nov 28, 2022 at 6:26 AM John R @.***> wrote:

@johnrandolph https://github.com/johnrandolph requested your review on:
#517 https://github.com/faucetsdn/udmi/pull/517 Merge various fixes
into master.
—
Reply to this email directly, view it on GitHub
https://github.com/faucetsdn/udmi/pull/517#event-7903493330, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIEPDZIIAP5NMJPIUNJ6LLWKS6JLANCNFSM6AAAAAASJJUVBA
.
You are receiving this because your review was requested.Message ID:
@.***>


Where can I find my cached documents?

Where can I find the post-conversion content of a document that has already been converted?

Is there even an option to open it on LlamaCloud? The sandboxed content is lost if I ever click the history section and the Job ID returns an unformatted mess...


✨ Support fallback fonts in Text Editing preferences

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Hello,
Currently, the Text Editing settings allow users to select one font only. In many cases, one font is not enough to cover up the Unicode characters that need. We could use multiple fonts to work as a font chain, just like the CSS font-family.
In Cocoa, there is a way to combine multple fonts as one NSFont instance, sample code:
static func combinedFont(from fontNames: [String], size: CGFloat) -> NSFont? {
    guard let primary = fontNames.first, let primaryFont = NSFont(name: primary, size: size) else { return nil }
    let primaryDescriptor: NSFontDescriptor = primaryFont.fontDescriptor
    let descriptors: [NSFontDescriptor] = fontNames.dropFirst().map { name -> NSFontDescriptor in
        return primaryDescriptor.addingAttributes([.name: name])
    }
    let descriptor: NSFontDescriptor = primaryDescriptor.addingAttributes([.cascadeList: descriptors])
    return NSFont(descriptor: descriptor, size: size)
}

Describe alternatives you've considered
Maybe we could put a TextField in Text Editing settings, let users to enter the font names they wanted.
Additional context

@ososoio I agree that this is particularly useful when not all fonts have the same character support.
@CodeEditApp/maintainers How would we like to handle this? How would this look in Settings (in the new SwiftUI form format)?


functional_tests_extended  Wrote some functional tests and configured on Preview

Wrote some functional tests and configured on Preview

Closing as out of date and redundant and doesn't do anything.

Closing as out of date


cGAN brainstorming

issue for brainstorming and material collection

@seblehner, @konradmayer, @alexanderkann

ESRGAN paper: https://arxiv.org/pdf/1809.00219.pdf
Application of ESRGAN and modification to use PSD as loss, turning the Generator into a supervised problem and removing the Discriminator for better performance: https://ml4physicalsciences.github.io/2019/files/NeurIPS_ML4PS_2019_75.pdf


Ada-Trader-Mariana-Pipes

Ada Trader
Congratulations!
Comprehension Questions

Question
Answer

How do Backbone Views help structure your code?
Views in Backbone are like controllers in Ruby, It helps to connect data with the DOM.

Did you use jQuery directly in your Views? How, and why?
I can't use jQuery directly in the views, I need to use this.$(selector) in order to use jQuery. I used to select elements at the DOM.

What was an example of an event you triggered? Why did you need to trigger it?
I trigger when a quote is buy or sell. I need to trigger this event because is a different type of event that I customize.

In what was is unit testing in JavaScript similar to unit testing in Ruby? In what ways is it different?
The structure is very similar with the it and describe.

Ada Trader
What We're Looking For

Feature
Feedback

Core Requirements

Git hygiene
This is a good start, but I would like to see more frequent and granular commits with more descriptive messages

Comprehension questions
yes

Organization

Models and collections are defined in separate files
yes

Code that relies on the DOM is located in or called by $(document).ready
yes

Functionality

Quote prices change when clicking Buy and Sell
yes

The Trade History updates when buying and selling a quote
yes

A user can create an open order using the Order Entry Form
yes

An open order removes itself from the open orders and updates the Trade History when fulfilled
no

General

Has separate views for different parts of the app
yes

Uses events (listening/handling and triggering) to manage different behavior in views
yes

Practices good standards for views (ES6 syntax, doesn't directly use jQuery, returns this in render)
yes

Error handling for the Order Entry Form
no

Testing

Has unit tests for models
no

Overall

This is a good start, but this submission is missing functionality that comes from connecting an Order to a Quote. Coordinating events across multiple components of a complex application is the core learning goal of this assignment, and making that connection is an important part of realizing that goal.
Event-driven programming is an important tool for the modern software engineer, especially in an asynchronous context like front-end JavaScript. It's also very different than the message-driven paradigm we've studied so far. Designing such programs is a unique challenge, as is knowing when and when not to use event-driven techniques. By this point you're probably mostly focused on your capstone project, but it would be worthwhile to spend some time focusing on this. Let me know if you want to sit down and work through making those connections together.


Add heal context

Merge heal context to master and bump version.
ref: helxplatform/development#671

Will push to pypi from master then merge helxplatform/appstore#91.


fix minChatLevel parsing

plug.dj stores the minimum chat level on the room meta object,
not directly on the room object.

nice catch! merged and closed.


NH-65069 Add lambda layer build-publish workflows

First PR to start adding APM Python lambda layer build-publish workflows. It would be great to get this on main for the first time to start test runs on GH then fix and enhance.
Adds 3 workflows:

build_publish_lambda_layer_x86_64
build_publish_lambda_layer_aarch
publish_lambda_layer which is called by each of above

Some key features:

The build_publish_* flows are manually triggered for now, assuming called on main and not multiple times.
Zip archive is generated by make aws-lambda target, same as local builds.
AWS CLI is used to publish to our staging account. I did a manual test of the command on my local (with a wrong name) to layer solarwinds-apm-python_0_18_0_aarch64
The published ARNs are supposed to be arn:aws:lambda:<region>:<account>:layer:solarwinds-apm-python-<arm64|x86_64>-0_18_0:1 at least for now.

I will need some help adding a new secret STAGING_LAMBDA_ROLE_ARN. I'm going to refine naming and versioning of APM Python layer in a future PR. I will probably also add a single workflow to trigger both arch builds.
Please let me know what you think!

Could you trigger the workflows one this branch to see an example run ?

Could you trigger the workflows one this branch to see an example run ?

Right, I could have done this with a temp on-PR trigger!
I also just realized I want to run the aarch builds on an EC2 runner. I'm going to close this one without merging and put in a new PR later.


Usability improvements

Hey @mathieudutour
This branch is not ready for a pull request actually, because A) I broke some things along the way and B) some of the things I tried are not made in the proper React way. I wanted to share it anyways to start the talks about some of the ideas ;)
I've also added a few notes in the commit messages and some comments in the specific files… And I'm still figuring out how to properly collaborate in a project via github so if I'm doing something wrong please let me know :)
Some of the things I'm stuck with:

Dismissing previous instances of the QuickLook element when we open a new one. The previous approach of using an Overlay layer to capture clicks implies the need of a "click to dismiss" action.
Styling a single tree-item-list row (only the deepest level hovered, not the whole tree) to show that one can click anywhere in the row to interact with that element.

I'll comment with some pointer about how to do it the "react way".
There are some merge conflicts because I worked on the master branch in the same time. To resolve them:

checkout master
pull
checkout your branch
git merge master
resolve the conflicts (by removing the >>>>>>>>>> in the conflicting files and keeping only what you need)
commit

Great, I'll push the big green button :D

:tada:


Add Socket.IO to get WebSocket requests when API starts

Proposed changes

Add NGINX configurations for Socket.IO in production
Initialize Socket.IO on the server
Create context for WebSockets (partially for #176)

Resolves #174
Checklist

[x] Are the issues being addressed linked to this PR?
[x] Do all commit messages start with the issue number?
[x] Are all code changes sufficiently tested?
[x] Are there screenshots for UI changes?

@davidvandusen When we were walking through this with the group last week, you mentioned that some parts of this ticket (#174) can be extracted for future tickets. Is this still the case, or should I aim to fulfill the following two things mentioned in the original issue?

The Socket.IO connection has access to the Express session and is able to access the principal_id of the connected user. Users that are not logged in cannot establish a WebSocket connection.

Express route handler have access to the Socket.IO instance so that they can emit messages to rooms.


'checkNetworkQualityConfigurations' function executes unexpectedly when 'checkNetworkQualityCatchAllConfiguration' should be used

Before submitting a Setup Your Mac bug report, please review the open swiftDialog issues to help determine the source of the issue.

Describe the bug
While using version 1.10.0-rc26, the network quality test feature is not functioning as expected. The checkNetworkQualityCatchAllConfiguration function does not seem to be used despite having the appropriate variables set. Instead, it falls back to checkNetworkQualityConfigurations.
To Reproduce

Set welcomeDialog=userInput [Default]
Set promptForUsername="false"
Set prefillUsername="false"
Set promptForComputerName="false"
Set promptForAssetTag="true"
Set promptForRoom="false"
Set promptForConfiguration="false"
Set configurationDownloadEstimation="true"
Execute the script via macOS Terminal and observe the incorrect Network Quality results in the Welcome dialog, and no network results in the Setup Your Mac Dialog

Expected behavior
The welcome dialog should show one Network Quality estimate for the Catch-all configuration, and not show the three configuration time estimates. The Setup Your Mac dialog should also display the Catch-all Network Quality estimate.
Code/log output
Note: this is just a snip-it, not a complete log...
2023-04-28 16:41:55 - WELCOME DIALOG: Starting networkqualityTest …
2023-04-28 16:41:56 - WELCOME DIALOG: Write 'welcomeJSON' to /var/tmp/welcomeJSONFile.HHd …
2023-04-28 16:41:56 - WELCOME DIALOG: Display Welcome dialog 'infobox' animation …
2023-04-28 16:41:56 - WELCOME DIALOG: Display 'Welcome' dialog …
2023-04-28 16:42:13 - # # # SETUP YOUR MAC VERBOSE DEBUG MODE: Line No. 2237 # # #
/Users/jlonergan/Desktop/Setup-Your-Mac-via-Dialog-1.10.0-rc26-reference.bash: line 174: 91069 Terminated: 15          welcomeDialogInfoboxAnimation "$myPID"
2023-04-28 16:42:13 - WELCOME DIALOG: Completed networkqualityTest …
2023-04-28 16:42:13 - WELCOME DIALOG: 562.47 (Mbps)
2023-04-28 16:42:13 - WELCOME DIALOG: Configuration One Estimated Seconds: 218
2023-04-28 16:42:13 - WELCOME DIALOG: Configuration One Estimate: 0h:3m:38s
2023-04-28 16:42:13 - WELCOME DIALOG: Configuration Two Estimated Seconds: 399
2023-04-28 16:42:13 - WELCOME DIALOG: Configuration Two Estimate: 0h:6m:39s
2023-04-28 16:42:13 - WELCOME DIALOG: Configuration Three Estimated Seconds: 654
2023-04-28 16:42:13 - WELCOME DIALOG: Configuration Three Estimate: 0h:10m:54s
2023-04-28 16:42:13 - WELCOME DIALOG: Network Quality Test: Started: 4/28/23, 4:41:56 PM, Ended: 4/28/23, 4:42:13 PM; Download: 562.47 Mbps, Responsiveness: 102
2023-04-28 16:42:17 - WELCOME DIALOG: jlonergan entered information and clicked Continue
execution error: Error: TypeError: undefined is not an object (evaluating 'JSON.parse(env)['Configuration']['selectedValue']') (-2700)
execution error: Error: TypeError: undefined is not an object (evaluating 'JSON.parse(env)['Department']['selectedValue']') (-2700)
execution error: Error: TypeError: undefined is not an object (evaluating 'JSON.parse(env)['Building']['selectedValue']') (-2700)
2023-04-28 16:42:17 - WELCOME DIALOG: • Computer Name:
2023-04-28 16:42:17 - WELCOME DIALOG: • User Name:
2023-04-28 16:42:17 - WELCOME DIALOG: • Asset Tag: 00000
2023-04-28 16:42:17 - WELCOME DIALOG: • Configuration:
2023-04-28 16:42:17 - WELCOME DIALOG: • Department:
2023-04-28 16:42:17 - WELCOME DIALOG: • Building:
2023-04-28 16:42:17 - WELCOME DIALOG: • Room:
2023-04-28 16:42:17 - # # # SETUP YOUR MAC VERBOSE DEBUG MODE: Line No. 775 # # #
2023-04-28 16:42:17 - WELCOME DIALOG: PolicyJSON Configuration:
2023-04-28 16:42:17 - WELCOME DIALOG: jlonergan did NOT specify a new computer name

Screenshots

Environment (please complete the following information):

OS version - macOS 13.4 Beta 3
Script version  1.10.0-rc26

Additional context
Add any other context about the problem here.

Thanks for reporting this use-case, @jonlonergan.

@jonlonergan: Will you please test 1.10.0-rc27 and advise if the issue is resolved?

Thank you Dan - will test 1.10.0-rc27 on Monday and report back.

Thanks for the report and confirmation, @jonlonergan.


Create test for this method

I'm not sure if this is the right place to ask or if there is existing solution for that, but after few hours of googling I was not able to find it. I'm searching for a functionality or extension which will allows me to right click on a method name and create instantly a test for this method. If there is no such solution at the moment, do you plan to add it in the future?

Which programming language are you using.

C++ / Go / Typescript / Javascript

Can you please file corresponding requests for C++ & Go in their repositories.

This is outside the scope of VSCode, but such functionality could be implemented as an extension.