[SPARK-10265][Documentation, ML] Fixed @Since annotation to ml.regression

Here is my first commit.

Can one of the admins verify this patch?

Jenkins, test this please.

ok to test

@ehsanmok according to the above warning message, we have any conflicts with the master. So I'd like to explain how to resolve that. And I'd like to review this PR after the first test pass.
When I have conflicts with the master after sending a PR, I always do the following operations.
# now, you are on your branch. In this case, it's `SinceAnn`.
# where, `upstream` is the `apache/spark` repository.
# if you set the different name on your local computer, replace `upstream` with the name..
git fetch upstream
git rebase upstream/master

# resolve the conflicts

# make sure to check coding style warnings before pushing it to github.
./dev/lint-scala

# push it to github
# where, `origin` is your github repository. In this case, It's `ehsanmok/spark`.
git push -f origin SinceAnn

If you have any questions, please don't hesitate to ask.

@yu-iskw Thank you very much for the detailed explanations! I just want to make sure that when I resolve the conflicts (also "Scalastyle checks passed") and do git rebase --continue, it shows unmerged files, so should I git add <files> and then git merge SinceAnn --no-ff?

@ehsanmok it depends on the situation. Since I don't know what kind of files appeared as unmerged files, it's hard to decide if you need to add them or not.

@yu-iskw should be fine now. Please test it.

ok to test

@mengxr can you run the test when you have time.
BTW, does everyone have the privilege to run tests in this case?

ok to test

add to whitelist

Merged build triggered.

Merged build started.

Test build #44842 has started for PR 8728 at commit 4f7c36f.

Test build #44842 has finished for PR 8728 at commit 4f7c36f.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * final class DecisionTreeRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n  * final class GBTRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n  * class IsotonicRegression @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)\n  * class LinearRegression @Since(\"1.3.0\") (@Since(\"1.3.0\") override val uid: String)\n  * final class RandomForestRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44842/
Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #44989 has started for PR 8728 at commit 175d75e.

Test build #44989 has finished for PR 8728 at commit 175d75e.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * final class DecisionTreeRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n  * final class GBTRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n  * class IsotonicRegression @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)\n  * class LinearRegression @Since(\"1.3.0\") (@Since(\"1.3.0\") override val uid: String)\n  * final class RandomForestRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44989/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #45042 has started for PR 8728 at commit beaa3aa.

@ehsanmok thanks for the update. We should dd @Since to public classes and public methods

DecisionTreeRegressionModel
GBTRegressionModel
IsotonicRegressionModel
LinearRegression.setWeightCol and LinearRegression.setSolver
LinearRegressionModel
LinearRegressionTrainingSummary
RandomForestRegressionModel

Test build #45042 has finished for PR 8728 at commit beaa3aa.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * final class DecisionTreeRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n  * final class GBTRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n  * class IsotonicRegression @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)\n  * class LinearRegression @Since(\"1.3.0\") (@Since(\"1.3.0\") override val uid: String)\n  * final class RandomForestRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n

@yu-iskw Thanks for the correction. I think, DecisionTreeRegressionModel is a private[ml] class, right? so does GBTRegressionModel, IsotonicRegressionModel, LinearRegressionModel and RandomForestRegressionModel. And LinearRegressionTrainingSummary is a public method in a private class, so needs a tag?
I assume LinearRegression.setWeightCol and LinearRegression.setSolver should be tagged as 1.6.0, right?

@ehsanmok

DecisionTreeRegressionModel  is a public class. The constructor paramter is private[ml].
GBTRegressionModel  and so on are also public classes.
setWeightCol  and setSolver should be since 1.6.0.

Merged build triggered.

Merged build started.

Test build #45047 has started for PR 8728 at commit fa61502.

@ehsanmok thanks for the update!

Add  @Since to totalIterations. It seems to be a public variable.
https://github.com/ehsanmok/spark/blob/fa6150269fa52b8ac019373158f5438c933f0e7e/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala#L433
And @Since to LinearRegressionSummary's public variables, such as explainedVariance
Add @Since to RandomForestRegressor's pubic variables, such as supportedImpurities

@yu-iskw Thank you very much for your patients. I wouldn't have imagined how much I would learn by doing this starter task.

Merged build triggered.

Merged build started.

Test build #45047 has finished for PR 8728 at commit fa61502.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * final class DecisionTreeRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n  * final class GBTRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n  * class IsotonicRegression @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)\n  * class LinearRegression @Since(\"1.3.0\") (@Since(\"1.3.0\") override val uid: String)\n  * final class RandomForestRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45047/
Test PASSed.

@ehsanmok no problem. I appreciate your first contribution!
@mengxr LGTM

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45053/
Test FAILed.

Jenkins, retest this please

Merged build triggered.

Merged build started.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45059/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, test this please.

Merged build triggered.

Merged build started.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45065/
Test FAILed.

Merged build finished. Test FAILed.

@mengxr there is something wrong with Jenkins. It failed to fetch source code from github 3 times in a row. Could you help us?

test this please

Merged build triggered.

Merged build started.

Test build #45128 has started for PR 8728 at commit 55e1317.

Test build #45128 has finished for PR 8728 at commit 55e1317.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * final class DecisionTreeRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n  * final class GBTRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n  * class IsotonicRegression @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)\n  * class LinearRegression @Since(\"1.3.0\") (@Since(\"1.3.0\") override val uid: String)\n  * final class RandomForestRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45128/
Test PASSed.

Merged into master. Thanks!


scroll_to_line does not work while scroll active is disabled

(3.2.stable.official) In rich text, scroll active tool tip says while either true or false, scroll_to_line will scroll rich text but this is not true in latest version of godot

Could you formulate that sentence properly once again? Can't understand what it says. Try to describe a scenario which causes that issue.

Are you using _ready() func to perform that scrolling? Like:
func _ready(): 	$RichTextLabel.scroll_to_line(4)
I've tried to replicate it - and even I've disabled scrolling, I am still able to offset it with above code.
Could you record simple GIF with issue? Or prepare simple project which reproduces that error?

Im changing the line on a timer timeout
func _on_LineChange_timeout(): 	if globals.level != 0: 		linecred += 1 		linelist += 1 		$Credits.scroll_to_line(linecred) 		$Results/TimeList.scroll_to_line(linelist) 		$Results/DeathsList.scroll_to_line(linelist) 		if linecred >= 36: 			$Credits.scroll_to_line(0) 			linecred = 0 		if linelist >= n - 5: 			$Results/TimeList.scroll_to_line(0) 			$Results/DeathsList.scroll_to_line(0) 			linelist = 0 	else: 		print("Looks like ya hecked up mister")
Heres a video, the list of times/deaths would scroll down until it reached the end then reset and 'credits' would scroll up the bottom area on the previous version of Godot. Was functioning fine before i updated :x hope i'm not making a silly mistake here now ive posted this.

Are you able to reproduce that issue with similar setup as mine?

The issue comes when Scroll Active in Rich Text Label is set false (when scroll bar is hidden) the on hover message for Scroll Active says scrolling is not blocked completely, see scroll_to_line https://streamable.com/37hl6

OK, I've got it now. It was actually connected with other issue reported back then - please go to my PR to find out more :)

This seems to work correctly in 3.2.2 beta3.


List of build warnings with VisualDSP++ 5.0 update 10

Duktape version: 1.4.0
goal description from makefile:
Release/duktape.doj :duktape.c duktape.h duk_config.h $(VDSP)/Blackfin/include/time.h $(VDSP)/Blackfin/include/yvals.h $(VDSP)/Blackfin/include/xcycle_count.h $(VDSP)/Blackfin/include/limits.h $(VDSP)/Blackfin/include/cycle_count_bf.h $(VDSP)/Blackfin/include/stdio.h $(VDSP)/Blackfin/include/stdlib.h $(VDSP)/Blackfin/include/stdlib_bf.h $(VDSP)/Blackfin/include/string.h $(VDSP)/Blackfin/include/stdarg.h $(VDSP)/Blackfin/include/setjmp.h $(VDSP)/Blackfin/include/stddef.h $(VDSP)/Blackfin/include/math.h $(VDSP)/Blackfin/include/ymath.h $(VDSP)/Blackfin/include/math_bf.h $(VDSP)/Blackfin/include/fract_typedef.h $(VDSP)/Blackfin/include/fract_math.h $(VDSP)/Blackfin/include/ccblkfn.h $(VDSP)/Blackfin/include/builtins.h $(VDSP)/Blackfin/include/sys/builtins_support.h $(VDSP)/Blackfin/include/fr2x16_typedef.h $(VDSP)/Blackfin/include/r2x16_typedef.h $(VDSP)/Blackfin/include/raw_typedef.h $(VDSP)/Blackfin/include/sys/anomaly_macros_rtl.h $(VDSP)/Blackfin/include/sys/mc_typedef.h $(VDSP)/Blackfin/include/fr2x16_math.h $(VDSP)/Blackfin/include/fr2x16_base.h $(VDSP)/Blackfin/include/r2x16_base.h $(VDSP)/Blackfin/include/stdint.h
@echo ".\duktape.c"
$(VDSP)/ccblkfn.exe -c .\duktape.c -file-attr ProjectName=spu_cims_a -O -Ov100 -save-temps -path-output .\Release -structs-do-not-overlap -const-strings -no-multiline -D OMIT_SQLITE -D DUK_OPT_FORCE_BYTEORDER=1 -D WORDSIZE=32 -D SYSTEM_CLOCK_133 -D NETWORK -D WITHOUT_DEBUG=0 -I web -I rs485 -I can -I audio -I include -I ../kernel/vainos -I ../kernel/vainos/ports/blackfin -I ../include -I ../include/netservice -D__PROCESSOR_SPEED=400000000 -double-size-64 -double-size-any -Ofp -guard-vol-loads -decls-strong -cplbs -sdram -warn-protos -Wremarks -Wsuppress 0001,1461,0826,1123,1124,1707 -Werror 0260,0173,0186,0188,0428,0514,0549,0836,1269,1635 -si-revision 0.3 -proc ADSP-BF537 -o .\Release\duktape.doj -MM
duk_config.h
/* OVERRIDE_DEFINES */
#define DUK_USE_PACKED_TVAL
#ifdef DUK_COMPILING_DUKTAPE
pragma file_attr("prefersMem=internal")
#endif //#ifdef DUK_COMPILING_DUKTAPE
#undef DUK_USE_ARCH_STRING
#define DUK_USE_ARCH_STRING "ADSP-BF537"
#undef DUK_USE_COMPILER_STRING
#define DUK_USE_COMPILER_STRING "VisualDSP++"
#undef DUK_USE_OS_STRING
#define DUK_USE_OS_STRING "VainOS"
// DUK_OPT_JSON_STRINGIFY_FASTPATH
#define DUK_USE_JSON_STRINGIFY_FASTPATH
// DUK_OPT_INTERRUPT_COUNTER
#undef DUK_USE_INTERRUPT_COUNTER
// DUK_OPT_DEBUGGER_SUPPORT
#undef DUK_USE_DEBUGGER_SUPPORT
// DUK_OPT_FASTINT
#define DUK_USE_FASTINT
// DUK_OPT_NO_REFERENCE_COUNTING
#define DUK_USE_REFERENCE_COUNTING
// DUK_OPT_NO_MARK_AND_SWEEP
#define DUK_USE_MARK_AND_SWEEP
// DUK_OPT_NO_VOLUNTARY_GC
#define DUK_USE_VOLUNTARY_GC
// DUK_OPT_NO_STRICT_DECL
#define DUK_USE_STRICT_DECL
// DUK_OPT_NO_REGEXP_SUPPORT
#define DUK_USE_REGEXP_SUPPORT
// DUK_OPT_STRICT_UTF8_SOURCE
#undef DUK_USE_STRICT_UTF8_SOURCE
// DUK_OPT_NO_OCTAL_SUPPORT
#define DUK_USE_OCTAL_SUPPORT
// DUK_OPT_NO_SOURCE_NONBMP
#define DUK_USE_SOURCE_NONBMP
// DUK_OPT_NO_BROWSER_LIKE
#undef DUK_USE_BROWSER_LIKE
// DUK_OPT_NO_SECTION_B
#define DUK_USE_SECTION_B
// DUK_OPT_NO_NONSTD_FUNC_STMT
#undef DUK_USE_NONSTD_FUNC_STMT
// DUK_OPT_NONSTD_FUNC_CALLER_PROPERTY
#undef DUK_USE_NONSTD_FUNC_CALLER_PROPERTY
// DUK_OPT_NO_NONSTD_ARRAY_SPLICE_DELCOUNT
#undef DUK_USE_NONSTD_ARRAY_SPLICE_DELCOUNT
// DUK_OPT_NO_NONSTD_ARRAY_CONCAT_TRAILER
#undef DUK_USE_NONSTD_ARRAY_CONCAT_TRAILER
// DUK_OPT_NO_NONSTD_ARRAY_MAP_TRAILER
#undef DUK_USE_NONSTD_ARRAY_MAP_TRAILER
// DUK_OPT_NO_NONSTD_ARRAY_WRITE
#undef DUK_USE_NONSTD_ARRAY_WRITE
// DUK_OPT_NO_ES6_OBJECT_PROTO_PROPERTY
#define DUK_USE_ES6_OBJECT_PROTO_PROPERTY
// DUK_OPT_NO_ES6_OBJECT_SETPROTOTYPEOF
#define DUK_USE_ES6_OBJECT_SETPROTOTYPEOF
// DUK_OPT_NO_ES6_PROXY
#define DUK_USE_ES6_PROXY
// DUK_OPT_NONSTD_FUNC_SOURCE_PROPERTY
#undef DUK_USE_NONSTD_FUNC_SOURCE_PROPERTY
// DUK_OPT_NO_COMMONJS_MODULES
#undef DUK_USE_COMMONJS_MODULES
// DUK_OPT_NO_FILE_IO
#undef DUK_USE_FILE_IO
// DUK_OPT_NO_JX
#define DUK_USE_JX
// DUK_OPT_NO_JC
#define DUK_USE_JC
// DUK_OPT_LIGHTFUNC_BUILTINS
#undef DUK_USE_LIGHTFUNC_BUILTINS
// DUK_OPT_NO_ZERO_BUFFER_DATA
#define DUK_USE_ZERO_BUFFER_DATA
// DUK_OPT_NO_BUFFEROBJECT_SUPPORT
#undef DUK_USE_BUFFEROBJECT_SUPPORT
// DUK_OPT_NO_BYTECODE_DUMP_SUPPORT
#undef DUK_USE_BYTECODE_DUMP_SUPPORT
// DUK_OPT_ASSERTIONS
#undef DUK_USE_ASSERTIONS
void ErrorHandler(duk_context* ctx, duk_errcode_t code, const char* msg);
#define DUK_USE_PANIC_HANDLER(code,msg) ErrorHandler(ctx,(code),(msg))
// Variable, stores system ticks counter
extern volatile unsigned long SystemTicks;
#define DUK_USE_DATE_GET_NOW(ctx)						((6819934800000L+SystemTicks)/5.0)
#define DUK_USE_DATE_GET_LOCAL_TZOFFSET(d)	0

.\duktape.c
"duk_api_stack.c", line 1748: cc0128: {D} warning: loop is not reachable from
preceding code
DUK_UNREACHABLE();
^
"duk_api_stack.c", line 1749: cc1045: {D} warning: missing return statement at
end of non-void function "duk_get_length"
}
^
"duk_api_stack.c", line 1995: cc0111: {D} warning: statement is unreachable
return ret;
^
"duk_api_stack.c", line 2017: cc0111: {D} warning: statement is unreachable
return ret;
^
"duk_api_stack.c", line 2651: cc0128: {D} warning: loop is not reachable from
preceding code
DUK_UNREACHABLE();
^
"duk_api_stack.c", line 2652: cc1045: {D} warning: missing return statement at
end of non-void function "duk_get_type"
}
^
"duk_api_stack.c", line 2720: cc0128: {D} warning: loop is not reachable from
preceding code
DUK_UNREACHABLE();
^
"duk_api_stack.c", line 2721: cc1045: {D} warning: missing return statement at
end of non-void function "duk_get_type_mask"
}
^
"duk_bi_array.c", line 745: cc1665: {D} warning: variable "have_delcount" is
possibly used before its value is set in loop
DUK_UNREF(have_delcount);
^
"duk_bi_date.c", line 326: cc0128: {D} warning: loop is not reachable from
preceding code
DUK_DDD(DUK_DDDPRINT("fell out of char loop without explicit accept/reject -> reject"));
^
"duk_bi_date.c", line 1023: cc1665: {D} warning: variable "rc" is possibly
used before its value is set in loop
DUK_UNREF(rc);  /* unreferenced with some options */
^
"duk_bi_logger.c", line 104: cc1665: {D} warning: variable "data" is possibly
used before its value is set in loop
DUK_UNREF(data);
^
"duk_bi_logger.c", line 105: cc1665: {D} warning: variable "data_len" is
possibly used before its value is set in loop
DUK_UNREF(data_len);
^
"duk_bi_math.c", line 139: cc1665: {D} warning: variable "cx" is possibly used
before its value is set in loop
DUK_UNREF(cx);
^
"duk_bi_math.c", line 140: cc1665: {D} warning: variable "sx" is possibly used
before its value is set in loop
DUK_UNREF(sx);
^
"duk_heap_stringtable.c", line 565: cc0128: {D} warning: loop is not reachable
from preceding code
DUK_UNREACHABLE();
^
"duk_heap_stringtable.c", line 566: cc1045: {D} warning: missing return
statement at end of non-void function
"duk__find_matching_string_probe"
}
^
"duk_hobject_props.c", line 3116: cc0128: {D} warning: loop is not reachable
from preceding code
DUK_UNREACHABLE();
^
"duk_hobject_props.c", line 3117: cc1045: {D} warning: missing return
statement at end of non-void function
"duk__handle_put_array_length_smaller"
}
^
"duk_hobject_props.c", line 3676: cc0128: {D} warning: loop is not reachable
from preceding code
DUK_UNREACHABLE();
^
"duk_hobject_props.c", line 4211: cc0128: {D} warning: loop is not reachable
from preceding code
DUK_UNREACHABLE();
^
"duk_hobject_props.c", line 5222: cc0128: {D} warning: loop is not reachable
from preceding code
DUK_UNREACHABLE();
^
"duk_js_compiler.c", line 5743: cc1665: {D} warning: variable "pc_before_expr"
is possibly used before its value is set in loop
DUK_UNREF(pc_before_expr);
^
"duk_js_compiler.c", line 5744: cc1665: {D} warning: variable "pc_after_expr"
is possibly used before its value is set in loop
DUK_UNREF(pc_after_expr);
^
"duk_js_executor.c", line 1005: cc0128: {D} warning: loop is not reachable
from preceding code
DUK_UNREACHABLE();
^
"duk_js_executor.c", line 1074: cc0128: {D} warning: loop is not reachable
from preceding code
DUK_UNREACHABLE();
^
"duk_js_executor.c", line 2136: cc0128: {D} warning: loop is not reachable
from preceding code
DUK_UNREACHABLE();
^
"duk_js_executor.c", line 4499: cc0128: {D} warning: loop is not reachable
from preceding code
DUK_UNREACHABLE();
^
"duk_js_ops.c", line 116: cc0128: {D} warning: loop is not reachable from
preceding code
DUK_UNREACHABLE();
^
"duk_js_ops.c", line 117: cc1045: {D} warning: missing return statement at end
of non-void function "duk_js_toboolean"
}
^
"duk_js_ops.c", line 250: cc0128: {D} warning: loop is not reachable from
preceding code
DUK_UNREACHABLE();
^
"duk_js_ops.c", line 251: cc1045: {D} warning: missing return statement at end
of non-void function "duk_js_tonumber"
}
^
"duk_replacements.c", line 78: cc0177: {D} remark: function "duk_repl_isinf"
was declared but never referenced
DUK_INTERNAL int duk_repl_isinf(double x) {
^
"duk_util_bufwriter.c", line 281: cc0177: {D} remark: function
"duk_raw_read_u16_be" was declared but never referenced
DUK_INTERNAL DUK_ALWAYS_INLINE duk_uint16_t duk_raw_read_u16_be(duk_uint8_t **p) {
^
"duk_util_bufwriter.c", line 293: cc0177: {D} remark: function
"duk_raw_read_u32_be" was declared but never referenced
DUK_INTERNAL DUK_ALWAYS_INLINE duk_uint32_t duk_raw_read_u32_be(duk_uint8_t **p) {
^
"duk_util_bufwriter.c", line 305: cc0177: {D} remark: function
"duk_raw_read_double_be" was declared but never referenced
DUK_INTERNAL DUK_ALWAYS_INLINE duk_double_t duk_raw_read_double_be(duk_uint8_t **p) {
^
"duk_util_bufwriter.c", line 323: cc0177: {D} remark: function
"duk_raw_write_u16_be" was declared but never referenced
DUK_INTERNAL DUK_ALWAYS_INLINE void duk_raw_write_u16_be(duk_uint8_t **p, duk_uint16_t val) {
^
"duk_util_bufwriter.c", line 334: cc0177: {D} remark: function
"duk_raw_write_u32_be" was declared but never referenced
DUK_INTERNAL DUK_ALWAYS_INLINE void duk_raw_write_u32_be(duk_uint8_t **p, duk_uint32_t val) {
^
"duk_util_bufwriter.c", line 345: cc0177: {D} remark: function
"duk_raw_write_double_be" was declared but never referenced
DUK_INTERNAL DUK_ALWAYS_INLINE void duk_raw_write_double_be(duk_uint8_t **p, duk_double_t val) {
^
"duk_api_stack.c", line 3345: cc0177: {D} remark: function
"duk_get_borrowed_this_tval" was declared but never referenced
DUK_INTERNAL duk_tval *duk_get_borrowed_this_tval(duk_context *ctx) {
^
"duk_api_stack.c", line 1479: cc0177: {D} remark: function
"duk_require_hcompiledfunction" was declared but never referenced
DUK_INTERNAL duk_hcompiledfunction *duk_require_hcompiledfunction(duk_context *ctx, duk_idx_t index) {
^
"duk_bi_date_unix.c", line 38: cc0177: {D} remark: function
"duk_bi_date_get_now_time" was declared but never referenced
DUK_INTERNAL duk_double_t duk_bi_date_get_now_time(duk_context *ctx) {
^
"duk_bi_date_unix.c", line 49: cc0177: {D} remark: function
"duk_bi_date_get_local_tzoffset_gmtime" was declared but never
referenced
DUK_INTERNAL duk_int_t duk_bi_date_get_local_tzoffset_gmtime(duk_double_t d) {
^
"duk_strings.c", line 23: cc0177: {D} remark: variable "duk_str_not_buffer"
was declared but never referenced
DUK_INTERNAL const char duk_str_not_buffer = "not buffer";  / still in use with verbose messages */
^
"duk_hobject_props.c", line 2822 (col. 2): cc1975: {D} remark: variable "obj"
may be used before being set
"duk_hobject_props.c", line 2783 (col. 3): cc1975: {D} remark: variable "obj"
may be used before being set
"duk_hobject_props.c", line 2774 (col. 2): cc1975: {D} remark: variable "obj"
may be used before being set
"duk_hobject_props.c", line 2795 (col. 5): cc1975: {D} remark: variable "
arr_idx" may be used before being set
"duk_js_compiler.c", line 2188 (col. 6): cc1975: {D} remark: variable "d3" may
be used before being set
Build completed successfully.

Thanks, I'll look into these in more detail.
At a quick glance I think these are mostly caused by no-return functions related to error handling (some are not, and are fixable). This causes either unreachable code warnings for follow-up code (e.g. a return after an error) or uninitialized value warnings if there's no follow-up code like a return (the compiler thinks a control path exists where a variable is not initialized, for example). These are a bit difficult to resolve portably because one easily ends up choosing between warnings rather than eliminating them for all compilers.


fix: use nullpool in the celery workers [WIP]

SUMMARY
Changes celery db requests from superset.db to the scoped_session that uses null pool to avoid using same db sessions across multiple celery workers.
More context on the problem can be found in the linked issue.
Fixes https://github.com/apache/incubator-superset/issues/10530
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

unit tests
dropbox staging

ADDITIONAL INFORMATION

[x] Has associated issue: https://github.com/apache/incubator-superset/issues/10530

Was this confirmed to fix the error? There have been similar errors reported for email alerts, so pretty awesome if this solves these problems completely.

Was this confirmed to fix the error? There have been similar errors reported for email alerts, so pretty awesome if this solves these problems completely.

@villebro still iterating on it, will post an update once confirmed

Codecov Report

Merging #10819 into master will decrease coverage by 4.16%.
The diff coverage is 71.28%.

@@            Coverage Diff             @@
##           master   #10819      +/-   ##
==========================================
- Coverage   65.40%   61.23%   -4.17%
==========================================
  Files         802      804       +2
  Lines       37872    37936      +64
  Branches     3561     3561
==========================================
- Hits        24770    23232    -1538
- Misses      12996    14518    +1522
- Partials      106      186      +80

Flag
Coverage Δ

#cypress
?

#javascript
61.58% <ø> (-0.07%)
:arrow_down:

#python
61.03% <71.28%> (+0.13%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/cli.py
40.00% <33.33%> (+0.06%)
:arrow_up:

superset/tasks/schedules.py
76.87% <62.29%> (+1.12%)
:arrow_up:

superset/utils/celery.py
85.71% <85.71%> (ø)

superset/sql_lab.py
80.28% <100.00%> (+1.59%)
:arrow_up:

superset/tasks/alerts/observer.py
100.00% <100.00%> (ø)

superset-frontend/src/SqlLab/App.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/explore/App.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/dashboard/App.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/explore/index.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/dashboard/index.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 196 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4a992...1036e9c. Read the comment docs.

Was this confirmed to fix the error? There have been similar errors reported for email alerts, so pretty awesome if this solves these problems completely.

@villebro I've confirmed that this fix is working for us, I've ran alerts and reports over night with high frequency & the issue has stopped happening


⚠ Bofrost.at has degraded performance

In 47626a7, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1227 ms

Resolved: Bofrost.at performance has improved in c0eb58b.


Update contoso-migration-oss-db-to-azure.md

URL needs to point to the video not a blog about the video.

@chhavinij : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@deltadan please review and incorporate the correct URL as mentioned in the PR.

@deltadan @ktoliver please review, approve and merge this PR.


Scope has changed

Hi there,
I ran the final complete example of https://developers.google.com/api-client-library/python/auth/web-app but encountered the following warning:
builtins.Warning
Warning: Scope has changed from "https://www.googleapis.com/auth/drive.metadata.readonly" to "https://www.googleapis.com/auth/plus.moments.write https://www.googleapis.com/auth/plus.profile.agerange.read https://www.googleapis.com/auth/plus.me https://www.googleapis.com/auth/userinfo.profile https://www.googleapis.com/auth/plus.circles.members.read https://www.googleapis.com/auth/userinfo.email https://www.googleapis.com/auth/plus.login https://www.googleapis.com/auth/drive.metadata.readonly https://www.googleapis.com/auth/plus.profile.language.read".
I have no idea why it shows this warning; I can find "https://www.googleapis.com/auth/drive.metadata.readonly" in https://developers.google.com/identity/protocols/googlescopes.
But it seems it's the following that is correct based on https://developers.google.com/identity/protocols/googlescopes
SCOPES = ['https://www.googleapis.com/auth/drive.metadata.readonly']
API_SERVICE_NAME = 'drive'
API_VERSION = 'v3'
instead of the following in your complete example:
SCOPES = ['https://www.googleapis.com/auth/drive.metadata.readonly']
API_SERVICE_NAME = 'drive'
API_VERSION = 'v2'
But the warning remains even after my change.
Could you check this?

Thank you.
Paul

I cannot replicate this.  Here is the output from my terminal when I run the flask application with my own credentials and hit the /test endpoint with my browser.  I authenticate successfully and see the API repsonse.
$ bin/python flaskapp.py
 * Serving Flask app "flaskapp" (lazy loading)
 * Environment: production
   WARNING: Do not use the development server in a production environment.
   Use a production WSGI server instead.
 * Debug mode: on
 * Running on http://localhost:8080/ (Press CTRL+C to quit)
 * Restarting with stat
 * Debugger is active!
 * Debugger PIN: 667-656-456
<IP_ADDRESS> - - [31/Jul/2018 10:27:42] "GET / HTTP/1.1" 200 -
<IP_ADDRESS> - - [31/Jul/2018 10:27:42] "GET /favicon.ico HTTP/1.1" 404 -
<IP_ADDRESS> - - [31/Jul/2018 10:27:48] "GET /test HTTP/1.1" 302 -
<IP_ADDRESS> - - [31/Jul/2018 10:27:49] "GET /authorize HTTP/1.1" 302 -
<IP_ADDRESS> - - [31/Jul/2018 10:27:59] "GET /oauth2callback?state=8jD6DeqxU6nimTEKmLEGSAfW3Rveof&code=4/AABUxE1GXHsDTL5meFFsvgQlOn83WwqQijzgUAdeDUwJcHC21fWlSBW3uFdfM-T-YlzCAYO3yjRZmajAg2Eu3H8&scope=https://www.googleapis.com/auth/drive.metadata.readonly HTTP/1.1" 302 -
<IP_ADDRESS> - - [31/Jul/2018 10:28:01] "GET /test HTTP/1.1" 200 -

Here's a diagnosis from another project with a similar symptom:
https://github.com/gratipay/gratipay.com/issues/2862

It's pretty weird that there is no issue after I tried the same settings in a brand-new project...


sentinel示例，添加sentinel配置，实现sentinel示例功能，以及运行说明。

Describe what this PR does / why we need it
Improve the sentinel sample feature
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM


Implement DCO Checker

Descriptions
Add DCO checker to validate signoff from contributors
Examples
https://github.com/dcoapp/app
https://github.com/apps/dco

Done!


Updated commit and refreshed generated code

Updated commit, main changes:

Models namespace removed
Updated documentation and field name of CompletionsUsage.CompletionTokens

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.AI.OpenAI


Patch to turn off image comparison

Incorporate changes from the patch in https://github.com/conda-forge/e3sm_diags-feedstock/pull/5 to turn off image comparison. Using a different matploblib version can cause enough differences in the plots to cause tests to fail. This change disables the image comparison part of the tests by default.

@forsyth2  Hey, let's just have that in the feedstock repo. I think it is still good to have the checker on here...

@chengzhuzhang Sounds good, but perhaps it might be good to add the option to turn image checking on/off? (i.e., I could merge this PR but with the check_images option defaulting to True).

@chengzhuzhang, I don't think we want to intentionally have patches like this in the feedstock repo.  I think you want an environment variable that determines if images get checked or not.  It would be set to one value in the CI here and the other in CI on the feedstock.  But there would not be a patch.  So you just need to replace the function argument here with an environment variable.  If the variable isn't present, you'll need to decide what the default should be.  I'm fine either way.

@xylar @forsyth2 Thank you, both!  Having an environment variable to switch the image checker one and off seems to be the best approach here.

#463 (update the version number) is ready to merge once this pull request merges.


Check for correct props in Flow or prop-types

Issue: #2897
What I did
Added a getPropTypes function to check if the propType is coming from Flow(propType.elements) or prop-types(propType.value), and used it in all type components.
Also changed the label prop in FlowTypeButton.js to union in order to test the change.
How to test
Run storybook kitchen sink app (yarn storybook), no "cannot read property length of undefined" error displayed in Comments from Flow declarations story if you define union prop type in FlowTypeButton.js.

Most of the other type components use value field. Should we apply this change there as well?

Missed that, makes sense to apply it there as well, ill try to create a more centralized solution.
Btw what is the bitHound - Dependencies that keeps failing? am I missing something? or should I pull this solution into a different branch than master?

You shouldn't wory about it, it's an optional check

Awesome, what do you think about my suggested solution? did I miss anything?

I added more types, but since the last merge new test fails deploy/netlify — Deploy preview failed

Live example
For some reason, it displays literal | literal instead of actual values

Plus, PrettyPropType doesn't seem to prettify flow shapes, but it's probably a separate issue

I added literal type for flow enums, it displays the enum values correctly now in the table


Convert build to GitHub Actions

This PR solves https://github.com/delta-io/delta/issues/792

@rajagurunath by the way, are you interested in moving the build to GitHub Actions for https://github.com/delta-io/connectors as well?

@rajagurunath by the way, are you interested in moving the build to GitHub Actions for https://github.com/delta-io/connectors as well?

Thanks for Suggesting, Happy to take the task. will start looking into Connectors Repo.


It appears that "shoppingCartEnabled" is set incorrectly in HeaderNavbar.ascx

https://github.com/Adoxio/xRM-Portals-Community-Edition/blob/master/Samples/MasterPortal/Views/Shared/HeaderNavbar.ascx#L16
Current line is <% var shoppingCartEnabled = string.IsNullOrEmpty(shoppingCartUrl); %> but shouldn't this be the opposite? e.g. <% var shoppingCartEnabled = !string.IsNullOrEmpty(shoppingCartUrl); %>
The logic being that is the Shopping Cart URL is present then it is enabled. The current logic is the opposite, which causes the Shopping Cart button to not be displayed.

I am inclined to agree with you but I haven't used the functionality to confirm. If you would like to move this forward you can try modifying the logic and seeing if the cart works afterwards.

I flipped it and the Shopping Cart button appears, and I see the "Checkout" page. However when attempting to pay, I'm running into issues with the included Authorize.Net assembly-- Says it needs a strong name.

I suspect the Authorize.Net assembly isn't physically present, as it isn't distributed with the project. There is also an issue (#101) with the current Authorize.Net implementation which will be a hurdle as well.

Yes, I know. :)  I actually reported that issue.
Anyhow, I just included a copy of the source (https://github.com/AuthorizeNet/sdk-dotnet) to the solution and signed that project it with the same SNK as the MasterPortal solution which seems to have done the trick for now.
I'm currently in the process of migrating a legacy 7.0.0012 portal. Ultimately the goal is to upgrade the Authorize.Net SDK from 1.9.7 to 2.x to use a non-deprecated integration method. But for now, I just want to get the portal and CRM upgrade squared away before I tackled the ecommerce side.

OK 😄
I would be mindful of the effort this will take as I don't think any of this functionality is supported in online portals, but I'm sure others would be happy if you were to get this working.


Add --verbose flag

It would be really useful to have a --verbose flag to say exactly what the argv arguments to spawn, or the single command line to CreateProcess, is. At the moment I'm having to guess it.

https://github.com/jacereda/fsatrace/compare/file-args implements it:
fsatrace v<more flags> - -- cp /bin/ls /tmp/

Have you thought about a more traditional syntax? I could imagine anything with a leading - (e.g. -v and --verbose) being treated as a flag, the first non-flag argument being the output file, and the remaining non-flag arguments being the command line. Coupled with the traditional -- syntax to say all subsequent flags are arguments even if they begin with -, you can still write:
fsatrace --verbose - -- cp /bin/ls /tmp/

But in fact the -- becomes optional (in this example) and you are following the same rules as lots of other programs.

Yes, at some point. Maybe even use getopt now that VS is no longer in the equation. I'm not in a hurry with this though, getting the right behaviour should now be the priority.


MWPW-159423: Link urls are not resolved on Main Milo catalog and give 404

Removed the adobe.com: 'origin' rule from the stageDomainsMap to not covert them to --cc--adobecom.hlx.live/--cc--adobecom.hlx.page
Resolves: MWPW-159423
Test URLs:

Before: https://main--cc--adobecom.hlx.live/products/catalog?martech=off&georouting=off
After: https://mwpw-159423-link-mapping  --cc--adobecom.hlx.live/products/catalog?martech=off&georouting=off
(added a space after the 'mapping' to make this link invisible for PSI check)
For PSI check:
https://mwpw-159423-link-mapping--cc--adobecom.hlx.live/products/animate/free-trial-download?martech=off&georouting=off

@mirafedas is there any alternative solution? I don't know why but this doesn't look like the right solution to me.

@yesil this is what @robert-bogos (who introduced the stageDomainsMap) suggested. Why this solution doesn't look right to you, are there some use cases I'm not aware of?


[ClangImporter] Don't crash when a bad override affects NSErrors.

Most of the time the name importer does a good job deciding whether to import a particular method as throwing or not. However, when a method is an override, it skips all that work and assumes the decisions made for the superclass method apply here as well—which makes sense, since you're going to get the subclass implementation if you call the superclass's entry point. This can really throw things off if the types don't match up, though. Handle the one case where this is legal according to the rules of Objective-C, and make sure we don't import methods in the other cases.
rdar://problem/30705461

@swift-ci Please test

Latest version LGTM, thank you!

@swift-ci Please smoke test


Batch mode for document APIs

Related to #16713, closed a long time ago.
@jobergum I agree, the batch mode to index data is more than useful. Calling tens of thousands times the API is really not good.
@frodelu Personally, I would very much accept a single error code for the whole batch. For instance the first document with an error. In my client code, I just do not commit if any error is detected in a whole batch call, to prevent any issues.

That ticket was "while we wait for http/2". Now we have http/2 and there is no reason to add batch.

We send documents one by one, and let http/2 optimize the transfer. Cool.

Now we have http/2
I guess this means for Cloud and all self hosted?

Are there examples of sending a "batch" of document updates with HTTP/2?
Does it depend on the client language?
How do we manage error catching?

You don't need batch with HTTP/2 since it is fully asynchronous.
The client language needs to have a HTTP client that supports HTTP/2 but most do by now I think.
Each request may fail with an error even though it is asynchronous.

I found https://github.com/vespa-engine/pyvespa/blob/master/vespa/application.py#L1082, which uses async, semaphores and coroutines to loop on a document for async batch updates.
It looks to me that batch with Vespa is currently the responsibility of clients: depending on the programming language, one has  to build the asynchronous loop calls. And we know this is a difficult problem.
Would not it be better to implement the batch in the backend, rather than in the front-end?

Thanks for the detailed answer. I'll manage the chunks!


chore(*): add charts

add charts/ holding all Helm charts
add docs/ holding all Helm chart artifacts and index.yaml, to be served as helm repo via https://azure.github.io/brigade-charts
add Makefile
add brigade.js

Ref https://github.com/Azure/brigade/issues/718

Merging this initial PR; will require some chart refreshes until they are removed from respective repos once we cut over...


Phase 1, Topic 2 has a dead link

Supposed to redirect to a page explaining "Why use a CLI"
Actual Behavior sends you to Red Hat site with a 404 error
Steps to Reproduce the Problem

Go to phase 1 topic 2
Click on the link

Specifications

Version: Arc Search 1.33.1
Platform: iPad OS
Subsystem: Links/Navigation

resolved, thank you


Non-unique practice names causing issue on Analyse page

Here are a couple of examples (as spotted by @richiecroker):
https://openprescribing.net/analyse/#org=practice&orgIds=99P,99Q&numIds=21480000100&denom=total_list_size&selectedTab=summary
https://openprescribing.net/analyse/#org=practice&orgIds=99P,99Q&numIds=0212000B0&denom=total_list_size&selectedTab=summary

The issue is caused, I assume, by the fact that practice names are not unique but Highcharts (as we currently have it configured) assumes that category labels are unique.
I remember seeing somewhere in the Highcharts release notes that it now supports non-unique category  names via some kind of config setting so we should look into that.

Small update:
Just setting uniqueNames to false on the xAxis configuration does solve the problem on initial load, but then it breaks the chart badly if you move the time-slider.

Can we merge all practice names with their practice code? I.e. so they appear as
"Collingwood surgery, A87004"?
This would probably help some users distinguish between practices as well, and allow searching by code e.g. in practice search page - e.g. here the names are similar and some postcodes are also similar:

We recently had a user ask how to tell which practice he was looking at since they shared both name and address.
It wouldn't make a difference to the appearance of analyse search results because in the image @evansd  posted above, the names are truncated anyway.

Oh that's a nice suggestion. I think we should definitely try that on the Analyse page as hopefully it will fix that problem with very little work.
I don't think we should merge them everywhere as it's useful to be able to control where and how the codes appear, but it would probably make sense to display them in the list of practices (and somewhere on the dashboard itself, if we don't already).

A user has raised a query relating to an alert for this analysis: https://openprescribing.net/analyse/#org=practice&orgIds=E87742&numIds=6.1.2&denom=total_list_size&selectedTab=summary

There are 2 surgeries with a similar name
The Golborne Medical Centre
Mine is E87742, on the data it is now showing as the other surgery!


Support task history search on updatedAt

Added support to the backend to also query on the updatedAt field. Then we will be able to do queries like, 'everything running on slave x at 10am' with  combo of the startedAt and updatedAt values.
TODO:

[x] UI changes for specifying updatedAt

This has been working well, further tweaks to task search will come in future PRs


parallelization?

This may be reaching a bit, but is it possible to modify this so I can run it in multiple ttys in parallel? Sometimes while doing updates there will be a slow downloading file (5-10 mins) which kind of halts my other cask updates due to the bottleneck. If I open a new terminal and run the script again, I will inevitably get a PR with multiple commits and other weirdness.
I understand that this probably not a problem that anyone other than myself experiences, and I have other work arounds. I would even be willing to try and submit a PR if there was some guidance around what to change. Presumably there is a hardcoded git checkout path for the new branch, which if it was variable each time the script ran would avoid this issue?

We could do it, but I doubt it’d be worth it. One way to go about it:

When cding into the directory of the cask to change, check the branch.
If master, proceed as usual.
If the branch name starts with ${cask_repair_branch_prefix}, git clone the repo in a temporary directory, cd into that and start at 1.

But the git clone will itself take a while. Simpler way:

After figuring out the cask’s repo, cp -r that into a temporary directory.
cd to the temporary directory and continue as usual.

It’d take a lot more disk space, but nothing a reboot wouldn’t get rid of.

A rather extreme solution that would let you do this without any changes to cask-repair is multiple installs of brew.
Installation.md#multiple-installations


Do not allow to finalize if there are insufficient points in the importing project

add server based validation
enhance UI finalization modal to perform validation and prevent user from moving forward

PR: #1261

:+1:


WASM runtime max heap size

Fixes #30278
Marek ... I'm confused on the setting you provided ... 256 MiB (BTW, they won't allow us to use MiB, so I'm just going to show bytes and write "bytes" for this guidance) ... anyway ... 256 MiB ... or 268,435,456 bytes.
According to https://github.com/dotnet/runtime/blob/main/src/mono/wasm/build/WasmApp.Common.targets, the default is listed a lot higher ...

$(EmccMaximumHeapSize) - Maximum heap size specified with emcc. Default value:<PHONE_NUMBER> or size of the DLLs, whichever is larger. Corresponds to -s MAXIMUM_MEMORY=... emcc arg.

... 2,147,483,648 bytes ... 2 gigs.
So ... is the remark in that file incorrect on the default? If so, what's the actual default value?
Otherwise, the PR is ready for review.

Internal previews

📄 File
🔗 Preview link

aspnetcore/blazor/host-and-deploy/webassembly.md
Host and deploy ASP.NET Core Blazor WebAssembly

In that case, we don't need to describe the app's DLLs being larger than the default value. I removed that, and I added a bit on how the default value may too large and prevent the app from running.


Camera on android has no preview with rn 0.19.0

I managed to build with camera for android, but no preview is available. Do you guys have any idea why?

Guys, any idea how to see the camera preview on android?

What do you see @rpopovici? Can you provide some other details about your app and environment? I may be able to help having been in a similar position to you earlier today.

Yes, I am building with react native 0.19.0-rc on Genymotion. I did all the suggested fixes like switching to ViewGroupManager and added user permisions. Anyway, the camera module loads, but I see no preview(transparent background). If I take a picture it works on the emulator, but on the device I get this error:

I discovered why the camera on android it's not showing preview. Apparently RCTCameraViewManager.setType() is never called. If I add setCameraType(2); in RCTCameraView constructor I can see the preview. Now, the question is: why settings JS props don't call the native counterparts in java code?

This is related to the fact that @ReactProp annotated props are never called. Any idea why?

Using a brand new RN 0.19 project and installing from:

npm install react-native-camera@https://github.com/lwansbrough/react-native-camera.git --save

and following the new instructions in the docs I get no camera preview and the following error when hitting capture:

couldn't find key type in dynamic object

@rpopovici Can you give an exact example of where you added setCameraType(2); ?

The latest incarnation of react-native-camera is totally busted with rn 0.19 on android.
You have to do the following to make it work:
1 Include View and add ...View.propTypes under propTypes in Camera.js
2 Rename REACT_CLASS in your android RCTCameraViewManager to  REACT_CLASS = "RCTCamera";  in order to match the iOS name.
3. Add setCameraType(2); setAspect(0); at the end of your RCTCameraView constructor. This is needed because ReactProps annotations are ignored for some reason..

Can you guys submit a pull request if you've managed to fix some functionality? Thanks!

@lwansbrough done!

This is the first fix where I've seen the Camera working, but the Capture button isn't visible over top. I'm using a new project and the default example.

Interesting. That should be a relatively easy fix - just need to make sure sub views are being added correctly. Just going to take a look at the PR now.

Going to take a closer look at this later.

Yes, adding children to Camera does not work for now. You can add your image with position absolute outside camera tag.

I updated to react native 0.19 and I'm using @rpopovici fixes. I see the preview perfect, but when I press the capture button I get an error. Anybody knows why could happen this?
 Exception in native call from JS
unknown:React: com.facebook.react.bridge.NoSuchKeyException: couldn't find key type in dynamic object
unknown:React: 	at com.facebook.react.bridge.ReadableNativeMap.getInt(Native Method)
unknown:React: 	at com.lwansbrough.RCTCamera.RCTCameraModule.capture(RCTCameraModule.java:154)
unknown:React: 	at java.lang.reflect.Method.invoke(Native Method)


Data files are not included with pip install

pip install . works after a git clone, but pip install pepdata has no matrices or data folder in site-packages/pepdata

I believe this is because data and matrices need __init__.py. See http://stackoverflow.com/questions/13307408/python-packaging-data-files-are-put-properly-in-tar-gz-file-but-are-not-install


Upgrade to sentry 3.12.1

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          24     24
=====================================
  Hits           24     24

Impacted Files
Coverage Δ

lib/index.js
100% <ø> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d363554...8fdd2ab. Read the comment docs.

👀 @hankim813 @tsholmes for review

@hankim813 @Rowno
This release isn't live yet; what else needs to happen to get this live?

@Rowno @WesleyDRobinson forgot to put release commit on top of this. i'll do that today and deploy this.


Fix incorrect submobject count of multi-part Tex/MathTex mobjects by stopping them from adding empty submobjects

Currently, whenever a Tex or MathTex mobject specified via multiple parts where one of the parts renders individually to an empty SVG, like
MathTex("1", "^{", "0")

where the second part doesn't contain any glyphs to be rendered, we are adding an VectorizedPoint as a submobject to these mobjects. This messes up the glyph count, which is responsible for which glyphs are included in which submobject group, and leads to various issues (e.g., formulas only being written partially in Write or Create animations).
This PR disables this behavior (with, as far as I can tell, no drawbacks -- rendering still works for both OpenGL and Cairo, and git blame indicates that this behavior was originally implemented to make Tex/MathTex work with the OpenGL renderer; we must have fixed this some other way in the meantime).

Might be a good idea to use strict=True when iterating over the different Tex objects in the behavior test. That way differences in sizes of iterables are accounted for, and not trimmed as the default behavior of zip is to do.

Might be a good idea to use strict=True when iterating over the different Tex objects in the behavior test. That way differences in sizes of iterables are accounted for, and not trimmed as the default behavior of zip is to do.

Good idea! 976975c

Good idea! 976975c

Actually, this requires Python 3.10 and up, we'll have to do without for now.

Thanks for the speedy review!

general q: do we need a graphical test for this?

I think for testing this particular bug the non-graphical test checking that the glyphs produced by the split mobject coincide point-wise with the glyphs from the non-split one is sufficient.


4.20

(f) iter++->empty() is legal.
The expression means move iter to point to the next element and check if that string is empty.

In this case its means move iter to point to the next element and  check if the original string pointed by iter is empty.
Best regards

Thanks for pointing out. Updated file.


add payload to connection event

Is there any option to add a payload to the connection event?
The socket io library seems to enable this:
var socket = io.connect('http://localhost:3000', {   query: {token: token} });
yet I don't see a way to do so using this wrapper library, since the connection is being made automatically in the constructor

export class Socket_TEST extends Socket {
constructor() {
    super({ url: '<URL>, options: {"rememberUpgrade":true,
                                                "transports":["websocket","polling"],
                                                "secure":true,"rejectUnauthorized":true,
                                                "autoConnect":false
                                              } });

}

init(token){
  this.ioSocket.query = {token:token};
}

}
//call socket init and then connect
this.socket.init();
this.socket.connect();


Allow to use connection pool for Redis

Summary
This PR allows to use connection_pool for Redis connections:
config.pool = { size: 5, timeout: 1, url: 'redis://localhost:6379' }

* If url is not provided, default REDIS_URL will be used.
** Is not compatible with redlock_servers

@adis-io thank you for the effort to improve the library!
It turns out that Redlock 2.0 is using RedisClient. RedisClient does provide connections pooling.
Redlock servers can be configured for ActiveJob::Uniqueuess. Example:
redis_config = RedisClient.config(url: ENV.fetch('REDIS_URL'))

redis_pool = redis_config.new_pool(
  timeout: ENV.fetch('REDIS_POOL_TIMEOUT', 0.5.seconds).to_f,
  size: ENV.fetch('RAILS_MAX_THREADS', 5).to_i
)

ActiveJob::Uniqueness.configure do |config|
  config.redlock_servers = [redis_pool]
end

No changes required in this gem to support connections pooling.


Timeout Method

I am trying to fix a weird issue that is causing me to not be able to stay connected and/or start a connection to the Discord API.
Is there a method to set the timeout of the bot when it is first connecting?

In terms of timeout, no, none is currently provided for the Main WebSocket. What error are you having?

Is this related to #149 ? It appears to be. Please Dont open additional issues for the same problem.

No, this is not a duplicate, setting the timeout connection would be a workaround for that issue I was having.

https://github.com/TakahikoKawasaki/nv-websocket-client/issues/64

As an answer has been provided and there has been no change on this I am closing it. Feel free to reopen if you have additional issue.

I'm not looking for that. I'm simply just looking for a #timeout(int) in JDA.
So we can set our own time for the connection to time out.

I'm the author of nv-websocket-client which is used in the implementation of JDA.
WebSocket class and WebSocketFactory class in nv-websocket-client provide methods to set a timeout value used for connection establishment. The following is an excerpt from README.md.

There are two ways to set a timeout value for socket connection. The first way is to call setConnectionTimeout(int timeout) method of WebSocketFactory.
// Create a WebSocket factory and set 5000 milliseconds as a timeout
// value for socket connection.
WebSocketFactory factory = new WebSocketFactory().setConnectionTimeout(5000);

// Create a WebSocket. The timeout value set above is used.
WebSocket ws = factory.createSocket("ws://localhost/endpoint");

The other way is to give a timeout value to a createSocket method.
// Create a WebSocket factory. The timeout value remains 0.
WebSocketFactory factory = new WebSocketFactory();

// Create a WebSocket with a socket connection timeout value.
WebSocket ws = factory.createSocket("ws://localhost/endpoint", 5000);

The timeout value is passed to connect(SocketAddress, int) method of java.net.Socket.

It sounds that @Swedz requests that JDA provide an interface to accept a timeout value and pass it to nv-websocket-client. For example, connect() method of WebSocketClient.java can be improved.

@TakahikoKawasaki Now that I'm diving into the code I notice that 0 is consider as "no timeout", or infinite timeout. Currently, JDA allows WebsocketFactory to use the default timeout which is 0. The issue was originally open in relation to #149 due to the fact that on attempting to connect, the WS would get Connection Reset: Timeout or something similar.
Providing a timeout for the Websocket wouldn't actually fix the problem that @Swedz was having due to the fact that we were already using an infinite timeout yet still hitting a problem with reaching a timeout.

In the Java layer, timeout should never happen when 0 is specified. However, it seems that in the real world, underlying layers such as the network stack of operating system may raise "timeout" even when an upper layer requests "no timeout". The length of such implicit timeout depends on each platform, but basically, it's too long for interactive applications. By specifying an explicit non-zero value as timeout, for example 5 seconds, interactive applications can improve user experience. So, it is meaningful to provide an interface to specify timeout.

Yes, I still plan to provide such a setting, specifically through the JDABuilder, however it was more of a question of "I wonder why this is even an issue". I read through some of the closed issues on the NV Websocket github and saw the multitude of issues related to timeout, many of them harking back to implementation details at the JVM C level.
Thank you for your responses.

This is finally in JDA as of 637247619b3a64a845f2ac0a1d0f6b8c1b333612 / 3.0.BETA2_150


Add servicebuilder blade tools template

Add servicebuilder blade tools template; creates a project containing three modules using a multi-project Gradle build configuration; takes project name argument and a package path argument; the package path argument specifies the root package in which service builder classes are to be generated; use existing package substitution instead of creating a new one

@gamerson FYI, When you create a new servicebuilder project and run buildService, the following method is generated in the API module's FooLocalServiceWrapper class:
@Override
public com.liferay.portal.kernel.dao.orm.IndexableActionableDynamicQuery getIndexableActionableDynamicQuery() {
	return _fooLocalService.getIndexableActionableDynamicQuery();
}

This creates a compilation error since com.liferay.portal.kernel.dao.orm.IndexableActionableDynamicQuery is not on the classpath. I didn't run into this issue yesterday so I'm assuming it's due to a recent service builder module update. I checked the blade.servicebuilder.svc project and running buildService there produces the same error.

@jrao  can you open a issue for that and @AndyWu2015  can take a look.

Just started reviewing :) :octocat: Sent from GH.

Merged, thanks! See 8a849ba...b8bb3af :octocat: Sent from GH.

Thanks @jrao for the contribution.  I hope more is to come! :)

Created https://github.com/gamerson/liferay-blade-tools/issues/17. Looking forward to making more contributions!

Hi @jrao why there is no src/main/java and src/main/resources folder in svc and api project ?

@AndyWu2015 Hi Andy, a src/main/java gets generated in the api project when you run gradle buildService. Similarly, src/main/java and a src/main/resources folders get generated in the svc project. I thought it's simplest to let service builder create the folders.

have tried it 。Yes , this is simple . @jrao


Add averaged calculation of normals

For points, which belong to two different surfaces, the calculation of the normal provided by cubit may unfortunately not lead to the same result within extrude_mesh_normal_to_surface  and therefore causes a failure  of the method.
However, by ignoring the failure, the remaining extrusion of the surface seems to work fine.
I am proposing two options with this MR:

Make user-defined tolerances -  For the aneurysm example I am currently working on, the tolerance for the normals with 1e-7  is sufficient.
Use an average normal -  Simply compute the average of the two normals (Current restriction: If a point belongs to more than two surfaces, we are making an error within the averaging).

@isteinbrecher
You once mentioned that this functionality should principally be moved away from the cubit wrapper, any update on that?
Do we need to test this additionally ?

I added here additionally one test case where we actually test the surface extrusion with an aneurysm geometry.

@knarfnitram you should be able to click the merge button now.


Upgrade to API version 4?

Hi. This is an excellent tool, thanks for this! Are there any plans to upgrade this to use the V4 version of the GitLab API? V3 has been deprecated as of GitLab 9.5 (we're past version 10 now).
Update for those in search of a solution: since I wasn't able to find any other tools that can propagate my global admin labels across my instance that also work with the latest version of GitLab, I made one myself: https://www.npmjs.com/package/gitlab-fix-labels. It also addresses #11.
Cheers!

Yes, sadly this tool no longer works for me since we upgraded our server. It probably wouldn't be that hard to switch to v4, but I expect most users to just switch to another tool.

It doesn't seem that Xunnamius's project can copy labels from one project to another. It looks like it can only copy the admin labels to a project.


Release v0.20.0

@shadaj There's a typo in the arg name for flow-legacy:
https://github.com/apollographql/apollo-codegen/blob/v0.20.0/packages/apollo-codegen/src/cli.ts#L128


Work unit update has Integrity Error

Need a further investigation on vocms008
IntegrityError: (IntegrityError) (1452, 'Cannot add or update a child row: a foreign key constraint fails (wmagent.wmbs_frl_workunit_assoc, CONSTRAINT wmbs_frl_workunit_assoc_ibfk_2 FOREIGN KEY (fileid, run, lumi) REFERENCES wmbs_file_runlumi_map (fileid, run, lumi) ON DELETE CA)') 'INSERT INTO wmbs_frl_workunit_assoc (workunit, firstevent, lastevent, fileid, run, lumi) VALUES (LAST_INSERT_ID(), %s, %s, %s, %s, %s)' (0,<PHONE_NUMBER>, 14453L, 193556L, 31L)

Well damn. Maybe multiple jobs trying to run on the same file, run, and lumi? I'll have to look at the design, but it seems like the step or task should be in there too. Even workflow is not enough, I imagine since in the tree workflow we'll have that situation.

Just for the record for debugging:
The problem was there is no entries for wmbs_file_runlumi_map table. For below task.
/sryu_ReRecoSkim_reqmgr2_170926_221527_1536/DataProcessing/DataProcessingMergeRECOoutput/skim_2012A_BTag/skim_2012A_BTagMergeSKIMStreamHighLumi
MariaDB [wmagent]> select * from wmbs_file_runlumi_map where fileid=14453 and run=193556 and lumi=31;
Empty set (0.00 sec)
I wonder whether following function is causing problem
https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/DataStructs/Mask.py#L188
called by here
https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/WMBS/Subscription.py#L642
FYI here are the all the lumis for above file
MariaDB [wmagent]> select * from wmbs_file_runlumi_map where fileid=14453 and run=193556;
+--------+--------+------+------------+
| fileid | run    | lumi | num_events |
+--------+--------+------+------------+
|  14453 | 193556 |   41 |       NULL |
|  14453 | 193556 |   42 |       NULL |
|  14453 | 193556 |   43 |       NULL |
|  14453 | 193556 |   44 |       NULL |
|  14453 | 193556 |   45 |       NULL |
|  14453 | 193556 |   46 |       NULL |
|  14453 | 193556 |   47 |       NULL |
|  14453 | 193556 |   48 |       NULL |
|  14453 | 193556 |   49 |       NULL |
|  14453 | 193556 |   50 |       NULL |
+--------+--------+------+------------+
file name for 14453 - /store/unmerged/sryu/BTag/RAW-RECO/HighLumi-ReRecoSkim_reqmgr2-v11/00000/40F0CE12-39A3-E711-A9DC-FA163E7DD2FC.root


chore(master): release 1.5.0

:robot: I have created a release beep boop
1.5.0 (2023-05-11)
Features

add code-see diagrams (e503880)
add code-see diagrams (e852440)

Bug Fixes

ci: file naming (f0149fb)
unable to detect app namespace (828d94b)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/laravel-starter-tpl/releases/tag/v1.5.0 :sunflower:


Fixing OpenCV configuration related issues

Description
This pull request contains the configuration of OpenCV to the project. Also, this solves the previous configuration issues in the maven dependencies as well.
Type of change

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] This change requires a documentation update.

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Current Status

Let's ignore the workspace.xml.

Actually I have added .idea/**/workspace.xml this to gitignore. Can't understand how it ended up here.

@ivantha shall we merge this, then I will send another draft PR which has that drag-drop related changes.


MINTHOL proposal (39)

A draft proposal. I had some problems with the validator and external links, please see this issue for discussion.
Thanks!

Hi, please also engage with the community about your project at the Algorand Forum
https://forum.algorand.org/t/xgov-41-minthol-art-the-next-generation-loyalty-program-and-coupon-platform/9942

Hi! I will fix and finalize things today. I am also checking the forum in a sec, thanks for the heads up!

Hi @nonfungibleab ! I fixed the name and external links and set the proposal status to final. I hope everything else is okay. I will also keep an eye on the algo forums.
Thanks!

I really like the idea since it is a straightforward, real-life application of blockchain and a great use of NFTs.
The project seems well-thought-out: it has an interesting business model, multiple sources of revenue to become sustainable, and envisions team enlargement to deliver on the ambitious goals. I especially like the vision of using the blockchain in the background and not bothering the users with it unless they want to.
Some comments on how the proposal itself could be further improved:

Include links to your experiences (e.g. LinkedIn or projects) for convenience for xGovs to easily verify your claims.
Under point # 3, there is no video link.
The structure is rather difficult to follow, especially to see what you are even asking the xGovs to fund. If I understand correctly, you intend to develop a (mobile?) app for scanning of QR codes and reading of NFC tags that represent physical coupons? Also for the perk discovery and registration system, could you describe in more detail how that will look like - so that xGovs will be able to verify that you delivered on the promise.
Include your competition analysis - both in physical and blockchain space; to address why is your product better and what's the market size? Similar as you addressed it on the Forum.
How will the grant be spent? Will ALGO be sold on the market? If yes, using DEXs or CEXs? Or will a loan be taken against it in DeFi/CeFi? Would you perhaps be willing to vest the awarded funds?

@ShaperOfEntropy Thanks! I don't think I can modify my xgov entry anymore, which is fine. It is how it should work. I will modify and expand my "whitepaper" though.
Quick answers here in the meantime:

I am not a big fan of LinkedIn but I can add links to my OSS projects, talks, and articles.

Thanks, will fix it. That part is going to be added to the platform in a few weeks max too.

Yeah, I get this feedback often. I will try to clarify things. I won't work on a traditional app for now and stick with a (progressive) web app (web page). App stores are picky and it's difficult for crypto projects to qualify, especially if they include payments in crypto. App stores are also picky when it comes to porn and adult content and I don't intend to censor my platform, rather let the community do the work via subdomain filtered sites. These subdomains will also serve as kind of whitelabel solutions for loyalty programs of big brands which do not wish to display the minthol brand. Whitelabel is also something that does not pair well with apps. You can't really upload 100s of versions of the "same" app with different skin to the store.

I am working to provide an experience as close as possible to traditional apps though. The recent web API developments make this possible imo.

Yeah, I plan to work on this. It will take some time though. I want to triple-check numbers about competitors before I publish anything.

Spending the grant largely depends on my next few months. I am actively trying to raise funds and as it is going badly, I am also working on monetizing the product ASAP. If none of these work out I will probably sell the funds in multiple steps but in a relatively short timeframe to fund myself. Otherwise, I will keep it as capital for future expansion when favorable market arrives. I am not planning to take a loan against it either way.


Discord

Add discord support

Hi @BenHerbst , thanks for the message. Do you have any particular problems you would need to solve?

I think you got me wrong, i meant you should support discord as a platform for sending to, like slack


02.04.01 - Habit Event Details

Focus
Habit Events
Partial US
As a doer, I want to view a given habit event and all its available details.
Reason
This allows users to reflect on what they did on a particular day in more detail than simply "Completed a habit"
Story Points
1
Risk Level
Low

Finished as of #94


Connect to multiple computers/filesystems at the same time

Is there a way to do that atm?

You can open two separate VS Code windows to accomplish. Due to the architecture of the extension, it would be highly difficult to make it connect to multiple computers in the same instance.


[QUESTION] - Is it possible to define optional route parameter?

Describe the Question
Sometime it's necessary to use optional route parameter while defining routes. For instance, for defining i18n, I would need to define endpoints as:
router.GET("/:lang/terms", hertz.HandlerFunc)

Here I explicitly need to define the lang while using route.
/en/terms
/es/terms

Expected behavior
If I could define the route as similar
router.GET("/:lang?/terms", hertz.HandlerFunc)

I could define the default lang as required when I try to access /terms. And any time I can pass param to override default /es/terms

Already supported：https://www.cloudwego.io/docs/hertz/tutorials/basic-feature/route/

@welkeyever I'm sorry but I didn't find any example associated with optional param

I'm afraid it's not optional, or is it?
router.GET("/:lang/terms", hertz.HandlerFunc)

Can I call above route using /terms and not /en/terms?

not support

I think it's a good feature to add to library.

I think it's a good feature to add to library.
Feel free to contribute your thoughts if you can~

This may break the current way of constructing the trie - /terms and /en/terms belong to two different nodes.

/assign

In fact, all the frameworks I know that support optional param route , only support trailing use, for example /hello/:world?,            /:world?/hello is not supported, it's too complex, in fact I think we should avoid using routes this way

This issue will be closed due to inactivity. Please feel free to reopen it if there is anything new.


push_notifications: Lock message while we mark it pending for push.

Deleting a message can race with sending a push notification for it. b47535d8bb67 handled the case where the Message row has gone away -- but in such cases, it is also possible for access_message to succeed, but for the save of user_message.flags to fail, because the UserMessage row has been deleted by then.
Take a lock on the Message row over the accesses of, and updates to, the relevant UserMessage row.  This guarantees that the message's (non-)existence is consistent across that transaction.
Partial fix for #16502.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

This makes sense, merged, thanks @alexmv!


Doesn't work when form data is posted using the FormData object with AJAX.

It doesn't "see" the fields unless they're appended to the action url.

I see you posted this to StackOverflow as well, so let's move the issue there as this is not an express-validator issue.


Missing GPG key

The procursus repo is signed with GPG, but I can't find where the public key is. This package is labeled as the keyring, but it doesn't seem to have the same key. I think that the fingerprint of the signed repo is 664421BE84375685 and the one in the package is 6430292CF9551B0E. Any ideas where I can get the right key?

this repository is running a custom fork of procursus, which does not have GPG signatures and keys set up.


Add scripts section to pyproject.toml

When I converted Manifester to pyproject.toml, I did not include a project.scripts section. As a result, an executable for the Manifester CLI is not installed when the Manifester package is installed. This PR adds a project.scripts section to pyproject.toml so the Manifester CLI is easily accessible.

@JacobCallahan just to clarify, do you mean in the Unit Tests section of workflows/codeql-analysis.yml?

@JacobCallahan I'm not totally certain which installation you're referring to, but Manifester gets installed in the Unit Tests section of the codeql-analysis GitHub Action and in the Setup and Build section of the python-publish GitHub Action. I've added a call to manifester --help to the former and can add it to the latter as well if you would like.


TLS Issues

After the installation script was deployed, I downloaded ovpn to the client. When the client connected, the error message was connection timeout. I checked the log and the above error was displayed! Why is that?

+1

This has to do with filtering/censorship in your country, not a problem with the installer.


Any Type

In the introduction it says:

Why not make every new instantiation of a class have their instance variables types be inferred as the program is written?
The answer is that if every new instantiation of a class was different from every other instantiation, the type inference phase becomes exponential. You would have to wait a very, very, veeeeeeery long time for the program to compile (and believe us: we tried hard to make it fast).

I am trying to understand this better.
One thing that confuses me is that it seems to me that I could write a wrapper class (a bit simplified for example sake):
    class Any(T)
      def initialize(value : T)
        @value = value
      end
      def method_missing(s, *a, &b)
        @value.send(s, *a, &b)
      end
    end

And then write Box as:
    class Box
      def initialize(contents : Any)
        @contents = contents
      end

As long as I convert objects to Any objects when passing them to Box, it's going to act as if it is generic even though its not.
So in thinking about this, why can't Crystal do the same thing? If it can't guarantee an inferred type (or a compatible union) the just treat it like an Any.

Closed in favor of #2733


SQL on 1433 instance / no 1434 UDP needed - question

Hi @freddydk Please, I can see the port 1434 UDP is still needed (and Sql Browser service as well).  Is there any chance to switch to the static mode and access the named instance without SQLBrowser and 1434 UDP?

OK, I think I have found a solution. So I will close the issue. Sorry!!!


Redundant message should be removed from the installer.

Expected behavior
Redundant message should be removed from the installer.
Actual behavior
Even though the properties are merged, we are getting the following message in the installer
If you have Gauge installed already and there are any manual changes in gauge.properties file, a backup of it has been taken at GAUGE_INSTALL_LOCATION\share\gauge\gauge.properties.bak. You can restore these configurations later.

Suggestion
Remove the message

Fix should be available in nightly >= 20-7-2017


wip

[CI] Staging environment is at http://cap-staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-8022/docs/

[CI] Staging environment is at http://cap-staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-8022/docs/


Small update to cql4browsers removing commas

Small update to the cql-execution enigne. This PR is to keep cql4browsers up to date.
Related PR in the cql-execution engine: https://github.com/cqframework/cql-execution/commit/ce30329519ffedf64cbb9264548ec9dd551b1c40
Submitter:

[x] This pull request describes why these changes were made.
[x] This PR is into the correct branch.
[x] Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
[x] Tests are included and test edge cases
[x] Tests have been run locally and pass (remember to update Gemfile when applicable)
[x] Code coverage has not gone down and all code touched or added is covered.

In rare situations, this may not be possible or applicable to a PR. In those situations:

Note why this could not be done or is not applicable here:
Add TODOs in the code noting that it requires a test
Add a JIRA task to add the test and link it here:

[x] Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

[x] JIRA test links: N/A
[x] Justification for using JIRA tests: N/A
[x] JIRA tests have been added to sprint: N/A

Reviewer 1:
Name: @c-monkey

[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases
[x] You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

[x] JIRA tests have been run and pass
[x] You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:
Name: @losborne

[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[x] You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

[x] JIRA tests have been run and pass
[x] You agree with the justification for use of JIRA tests or have provided input on why you disagree

@jbradl11 The front end coverage decreased from:
Statements   : 56.95% ( 6823/11981 )
Branches     : 39.97% ( 1791/4481 )
Functions    : 47.24% ( 1120/2371 )
Lines        : 54.69% ( 6106/11165 )

to:
Statements   : 55.03% ( 7757/14095 )
Branches     : 36.33% ( 1886/5191 )
Functions    : 45.12% ( 1272/2819 )
Lines        : 52.55% ( 6851/13036 )

Thereby decreasing our coverage beneath the threshold.
There are no regressions or coverage decreases in the regression tests.

For me the cql_qdm_patientapi coverage is the same for both branches:
Statements   : 63.3% ( 1359/2147 )
Branches     : 33.66% ( 239/710 )
Functions    : 50.94% ( 245/481 )
Lines        : 60.03% ( 1143/1904 )

Bonnie bonnie-v2.1 as it is vs Gemfile modified to point to this branch also show the same coverage for me:
Statements   : 56.95% ( 6823/11981 )
Branches     : 39.97% ( 1791/4481 )
Functions    : 47.24% ( 1120/2371 )
Lines        : 54.69% ( 6106/11165 )

@c-monkey if you are able to reproduce your results we should look at what is causing the discrepancy.

@losborne  As a sanity check, I again very deliberately went and did a bundle exec rake tmp:clear and still got the same coverage results. Maybe I'm doing something wrong: I commented out the git gem reference and uncommented the relative path reference. Look at the SHA of your referenced cql_qdm_patientapi in the Gemfile.lock, is it d3f449a7c6a66799396b2c92fa2057562af2c7a5?


Fix ScalaDoc runs

The second commit introduces testSuite/test:doc in the CI matrix to verify that we can always run ScalaDoc on a project with all sorts of crazy JS stuff.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1341/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/1696/
Test PASSed.


Banner isn't at the bottom of the screen on iPhone 12 Pro

Godot version
3.5.1
Plugin version
v2.1.1
Phone information
iPhone 12 Pro, ios 16
Issue description

The banner isn't at the bottom of the screen -- instead, it has crept up to cover my content.
Steps to reproduce
This seems to be true whether or not I have respect_safe_area turned on.
Additional context
No response

Thank you for opening this Issue, we will investigate this.


How do I add port to autoxgb serve

autoxgb serve --model_path outputs/mll --host <IP_ADDRESS> --debug

I don't see the option for port

Sorry, I figure it out. Usually I search docs but I guess --help would work.


AdvDuplicator stuck at opening

This doesn't happen to every save I have, but some saves of mine which worked perfect yesterday suddenly stop working today.
I wasn't pasting or doing anything, it just started happening by random to random people on my server.
When I load them up TODAY they get stuck at opening and never reach ready "Advanced duplicator is busy" while some random props of my creation are gone, and they're random each time.
Restarting the game/server doesn't fix the issue.

Can I have a copy of the save?

Can you describe what update version the advdupe2 was on yesterday when it was working and what it is now?

This is the save file:
beachslide5.txt
I don't quite know where exactly the version is written at but this is the file I used before it happened:
advdupe2-master.zip
I have used the same version today and just today it seemed to stop working so I tried updating Wiremod & Advanced Duplicator 2 to the lastest version incase I haven't had the last version but it was the same thing.
The version I'm using now is the most updated version and it still causes that error, today morning I used yesterdays version and it still did the same.
The only difference with the updated versions that I see is "Advanced Duplicator gives out less 'advanced duplicator 2 is busy' than before but still has the same issue" which might be just my imagination.

Thanks. I'll run some tests when I get home.

Did it really work when using that .zip? That's a really recent version. I'll try it now.

Your dupe works fine for me. Can you try loading it in singleplayer?

Also can you ask the server owner to look for "advdupe2" in his server's lua_errors_server.txt

Won't be able to help until I get more information.

Sorry I was asleep,
Yes it was the Zip.
I think I found the problem,  I have SPC installed (Smart Prop Control) so that might be what's causing it because I just checked the lua_errors_server.txt file it seems I have this error:
[ERROR] addons/smartpropcontrol/lua/autorun/smartsauce/plugins/sv_advdupe.lua:269: this install lacks the codec version to parse the dupe (have rev 4, need rev 5)

error - [C]:-1
Decode - addons/smartpropcontrol/lua/autorun/smartsauce/plugins/sv_advdupe.lua:269
3. func - addons/advdupe2-master/lua/advdupe2/sv_networking.lua:293
4. unknown - lua/includes/extensions/net.lua:32

See https://github.com/wiremod/advdupe2/issues/164


Ratings API returns duplicate reviews

This listing, which is from an app running 2.0.15, is showing duplicate reviews because the ob/ratings call gives the same review twice.
{
    "average": 5,
    "count": 2,
    "ratings": [
        "zb2rhjkM5GhwzbBufztNfWJp7FsBvi5JFT9WPKZrCpGXoxh7k",
        "zb2rhjkM5GhwzbBufztNfWJp7FsBvi5JFT9WPKZrCpGXoxh7k"
    ],
    "slug": "kali-bubba-5g"
}

I don't know if it's related, but the same user has zero returned for their ratingCount and averageRating in their profile call.

Don't think this is still an issue.


typo, the port of consul is 8500

The command should be same as $ docker run -d -p 4000:4000 swarm manage -H :4000 --replication --advertise <IP_ADDRESS>:4000 consul://<IP_ADDRESS>:8500 in Step 5. Create Swarm cluster

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:CodeJuan/swarm.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Good catch!
LGTM
Thanks @CodeJuan

LGTM.
Thanks @CodeJuan! I wonder how we missed this :open_mouth:


Implement test cases to all classes in testing document

In order to better guarantee our logic works as anticipated we must test our code. The testing document can be found here.

Working on joint unit testing 1 - 6


Cannot run the plugin

I've been running into some issues with running the command, not sure if the README.md is not updated or if I'm not understanding, but every time I try to run git_status(path: "./' or just git_status, I get an exception, respectively class or module required and Invalid default value for path, doesn't match verify_block. Any idea how to go around this?
Thank you

@kirakik Thanks for the bug report.
It's a problem of the plugin.
I'm working on it, and will let you know once it's working.
Thanks

@kirakik The problem is fixed on version 0.1.3
Please run fastlane update_plugins to update the plugin version.
I will close this issue, if you have any further issues, please let me know, and reopen this issue.
Thanks


wrap source_version git cmd in a try catch

@see https://github.com/zodern/meteor-up/issues/807
On my local machine (Ubuntu 18, terminator shell) the command fail because it does not seem to be triggered in the correct folder when running tests. This is just a quickfix to avoid failure

Oh sorry I didn't see this and fixed it myself :(


Pow.Plug.authenticate_user on a graphql resolver (without conn)?

Has anyone ever tried this?
I was trying to authenticate users through graphql, here's my code (found on one of the issues here: #61)
  def login(_parent,  %{ email: _email,  password: _password } = params,  _info) do
    config = Application.get_env(:my_app, :pow, [])
    conn = Pow.Plug.put_config(%Plug.Conn{}, config)

    conn
    |> Pow.Plug.authenticate_user(params)
 end

but it is returning an:
{:error, %Plug.Conn{adapter: {Plug.MissingAdapter, :...}, assigns: %{}, before_send: [], body_params: %Plug.Conn.Unfetched{aspect: :body_params}, cookies: %Plug.Conn.Unfetched{aspect: :cookies}, halted: false, host: "www.example.com", method: "GET", owner: nil, params: %Plug.Conn.Unfetched{aspect: :params}, path_info: [], path_params: %{}, port: 0, private: %{pow_config: [user: MyApp.Accounts.User, repo: MyApp.Repo, web_module: MyAppWeb, extensions: [PowResetPassword, PowEmailConfirmation, PowPersistentSession], controller_callbacks: Pow.Extension.Phoenix.ControllerCallbacks, web_mailer_module: MyAppWeb, mailer_backend: MyAppWeb.Pow.Mailer, routes_backend: MyAppWeb.Pow.Routes]}, query_params: %Plug.Conn.Unfetched{aspect: :query_params}, query_string: "", remote_ip: nil, req_cookies: %Plug.Conn.Unfetched{aspect: :cookies}, req_headers: [], request_path: "", resp_body: nil, resp_cookies: %{}, resp_headers: [{"cache-control", "max-age=0, private, must-revalidate"}], scheme: :http, script_name: [], secret_key_base: nil, state: :unset, status: nil}

How do you do this properly? Thanks!

Nevermind, I already got a workaround with this.

Hi, the error monad is returned when the user can't be authenticated with the provided params: https://hexdocs.pm/pow/1.0.23/Pow.Plug.html#authenticate_user/2

Hi, the error monad is returned when the user can't be authenticated with the provided params: https://hexdocs.pm/pow/1.0.23/Pow.Plug.html#authenticate_user/2

But I'm pretty sure I'm providing the correct params though.

It's expected to be string key map, so try with:
  def login(_parent,  %{email: email,  password: password},  _info) do
    config = Application.get_env(:my_app, :pow, [])
    conn = Pow.Plug.put_config(%Plug.Conn{}, config)

    Pow.Plug.authenticate_user(conn, %{"email" => email, "password" => password})
 end

Maybe it should accept atom keys though.

@danschultzer - it worked! Thank you so much, but yeah, it should accept atom keys.

Hi @alvnrapada
I am getting  "pow plug not found ...." error. It basically tries to check :plug field in config object. It would be great if you can provide pow configuration from config.exs file.


expression property is unexpectedly added to the other step

Describe the Bug
Race condition?
Steps to Reproduce the Bug or Issue

Click setHeader step
Input simple expression
Click log step
Click setHeader step
Change the language to constant
Input constant expression
Click log step
Click setHeader step

Screenshots or Videos
https://github.com/KaotoIO/kaoto-next/assets/265462/016f203d-f42b-4bc9-b60f-de1473e3b1c2
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 0.30.0]

ExpressionEditor.handleOnChange is invoked only on setHeader node. It would be written at some different place...

#416 could be coming from a same root cause with this one. If I close the step configuration form every time before opening another one, this doesn't happen.

So when I click setHeader step and then log step, the form for the log step is rendered with setHeader model, then re-rendered with weirdly updated model
my print debug
>>>> Rendering Form for log-3832 {"id":"setHeader-7669","expression":{"constant":{"expression":"a"}}}
CanvasForm.tsx:60
>>>> Rendering Form for log-3832 {"id":"log-1675","message":"template message2","expression":{"simple":{}}}

If I understand correctly, the model object is retrieved after the initial rendering through useEffect() here
https://github.com/KaotoIO/kaoto-next/blob/main/packages/ui/src/components/Visualization/Canvas/CanvasForm.tsx#L38
Then it triggers re-render?
@lordrip is my assumption legit? do you have an idea to solve this in React in general?

@igarashitm I think there's part of the truth on that. After debugging it, the property in the wrong node is added here.
This is what we're doing at the moment:

Set model=undefined in line #69
If the parentModel.expression property is defined (node definition) we parse it, otherwise, we try to check what the expression might be. Since we don't have such a property, we exhaust the for statement in line # 77 .
In line # 84, if we haven't figured out which expression it was, we set the parentModel.expression property in line # 85

The latter is what is ultimately causing the property to be added to the component.
Now, the first question remains, why the isExpressionAwareStep property is not updated and attempts to show the ExpressionEditor component?

Alright, this is what's happening:

Click on setHeader
Since we have defaults coming from the useState, the useEffect is skipped.
isExpressionAwareStep is calculated, and returns true, since setHeader contains an expression property.
The ExpressionEditor component is shown.

Now, when clicking on log, here's what happens:

The props.selectedNode property change
The ExpressionEditor component is still shown as the isExpressionAwareStep property is not recalculated yet but the selectedNode is the log
The ExpressionEditor adds the property to the wrong node
The pending useEffect gets executed causing another rerender, in this case also forcing to recalculate the useMemo isExpressionAwareStep property, hence hiding the ExpressionEditor

Your PR (https://github.com/KaotoIO/kaoto-next/pull/461/files) fixes it because useMemo gets recalculated as soon as the property changes.


Error trying to pull ramalama:latest-rocm: manifest unknown

Fedora 40 with an AMD GPU (RADEON RX 7900 XTX):
I have this error when trying to run ramalama:
$ ramalama
Trying to pull quay.io/ramalama/ramalama:latest-rocm...
Error: initializing source docker://quay.io/ramalama/ramalama:latest-rocm: reading manifest latest-rocm in quay.io/ramalama/ramalama: manifest unknown

You can apply this patch:
https://github.com/containers/ramalama/pull/360
Or just run this and it should work:
ramalama --image quay.io/ramalama/ramalama:latest run
Sorry we changed the container name urls. That's a pretty mean GPU with loads of VRAM. Interested to see what kinda results you get there 😎


Why does aboutlibraries-core require minSdkVersion 21?

Why does aboutlibraries-core require minSdkVersion 21? Any new fancy APIs needed? I'm still stuck on 19 (just like most Google libraries out there), so I cannot use the library :(
Manifest merger failed : uses-sdk:minSdkVersion 19 cannot be smaller than version 21 declared in library [com.mikepenz:aboutlibraries-core-android-debug:10.0.0-b08] C:\foo\.gradle\caches\transforms-3\8875de10245fc7b512e35cfea83ae738\transformed\aboutlibraries-core-debug\AndroidManifest.xml as the library might be using APIs not available in 19
	Suggestion: use a compatible library with a minSdk of at most 19,
		or increase this project's minSdk version to at least 21,
		or use tools:overrideLibrary="com.mikepenz.aboutlibraries.core" to force usage (may lead to runtime failures)

@znakeeye I'll have a look, possibly the min sdk version for core can be lower.
During the beta, it was mainly due to simplicity, as the ui modules match the same min requirement.
Due to compose being 21+ though the UI modules won't get a lower API version.

Perfect. Could you please create a new release soon. This is stopping me from integrating with the lib 🙁


Server Sizing Recommendations

Why isn't there server sizing recommendations in this docs collection? Am I missing it?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 54585ff0-1a67-0fd0-3169-e0cc98d45b4b
Version Independent ID: 702fd06d-fd2f-48c6-ac57-5f8a6afe84da
Content: Welcome to Remote Desktop Services in Windows Server 2016
Content Source: WindowsServerDocs/remote/remote-desktop-services/Welcome-to-rds.md
Product: windows-server-threshold
GitHub Login: @ChristianMontoya
Microsoft Alias: chrimo

I came here for the same.  Did you ever find sizing recommendations/best practices?

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


Revert "Ease engines requirement"

Reverts vscode-neovim/vscode-neovim#2163
The singular support release has been completed, so we can roll back to our higher engine version

Isn't this reintroducing the issue described in #2163? I don't think it's necessary to update to the latest version of VS Code since we aren't using the new APIs. However, I suggest removing core-js and using findLast from lodash instead.

Yes, you're correct. At minimum, we need to change the version requirement to ^1.89.0, instead of just 1.89.0 However, as @theol0403 suggested, this was meant to be a one-time thing. I think in general it's likely a good thing for us to stay as up to date as possible
That said, I wouldn't mind staying on ^1.89.0 until we need a new feature, so long as we revert https://github.com/vscode-neovim/vscode-neovim/pull/2087 so our tsconfig is still correct. We shouldn't declare that we can compile with ES2023 if we can't actually.

It should be modified in a few months, and upgrading is not necessary unless absolutely required. As for the version requirement to ^1.89.0 you mentioned, this is just a devDependence, and for now, changing it doesn't have any impact.

It should be modified in a few months, and upgrading is not necessary unless absolutely required.

If that's our stance, we should roll back ES2023 support, Node 18 (which 1.89 runs) does not support all of its features

In the future, we can upgrade to newer VSCode engines more slowly. For now, we will target the newest version because we have code which depends on it.


[path_provider] getApplicationSupportDirectory in android i get /data/data/ instead of /data/

I want to take screenshot of a particular widget and store it in getApplicationSupportDirectory
When i use native code in android, I am using getFilesDir()
But it does not work as expected.
final dir= await getApplicationSupportDirectory();
print(dir.path);

/data/user/0/com.myapp/files
In android,
Log.d("Dir", String.valueOf(getFilesDir()));

D/Dir: /data/user/0/com.myapp/files
In android, log.d outputs the same location as it was printed in flutter.
But, When i try to access the file in android with native java code,
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)
I/flutter (16569): PlatformException(error, Failed to find configured root that contains /data/data/com.myapp/files/pic.png, null)
D/ViewRootImpl(16569): ViewPostImeInputStage processPointer 0
D/ViewRootImpl(16569): ViewPostImeInputStage processPointer 1

File file = new File(getFilesDir(), imageName);

This is how i tried to access the file in android.
Where does the /data/data/ comes from?

Hi @maheshkumar2150
can you please provide your flutter doctor -v ,
your pubspec.yaml
and a reproducible minimal code sample.
Thank you

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.