HDFS-16846. EC: Only EC blocks should be effected by max-streams-hard-limit configuration

In HDFS-16613, the dfs.namenode.replication.max-streams-hard-limit configuration will only affect decommissioning DataNode, but will not distinguish between replication blocks and EC blocks. Even if DataNodes have only replication files, they will always generate high network traffic. So this configuration should only effect EC blocks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 35s

trunk passed

+1 :green_heart:
compile
1m 39s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 31s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
1m 39s

trunk passed

+1 :green_heart:
javadoc
1m 18s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 49s

trunk passed

+1 :green_heart:
shadedclient
26m 19s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 23s

the patch passed

+1 :green_heart:
compile
1m 28s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 28s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 58s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 52 unchanged - 0 fixed = 53 total (was 52)

+1 :green_heart:
mvnsite
1m 29s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 34s

the patch passed

+1 :green_heart:
shadedclient
25m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
322m 27s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

440m 56s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5143

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux bf3729f582af 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 37adbb0946a609490f9a17c569a288606bdf12a0

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/1/testReport/

Max. process+thread count
2413 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@tasanuma Yes, you are right,  when decommission DNs, both ec blocks and replication blocks are belong to replication tasks.
And in DatanodeDescriptor class, replication blocks and ec blocks are both in 'BlockQueue replicateBlocks'. I think if we want to distinguish ec blocks and replication blocks in replication tasks when decommissioning dns, we need to put ec blocks in another variable in DataNodeDescriptor class besides 'replicateBlocks', such as 'BlockQueue ecReplicatedBlocks'. Do you agree me?

@lfxy I agreed. Let's go with the plan.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 40s

trunk passed

+1 :green_heart:
compile
1m 50s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 38s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 23s

trunk passed

+1 :green_heart:
mvnsite
1m 51s

trunk passed

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m  0s

trunk passed

+1 :green_heart:
shadedclient
26m 46s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 33s

the patch passed

+1 :green_heart:
compile
1m 37s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 37s

the patch passed

+1 :green_heart:
compile
1m 28s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  0s

the patch passed

+1 :green_heart:
mvnsite
1m 39s

the patch passed

+1 :green_heart:
javadoc
1m  3s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 33s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 49s

the patch passed

+1 :green_heart:
shadedclient
26m 11s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
329m  5s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  1s

The patch does not generate ASF License warnings.

453m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5143

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 24301c5a2f73 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 65d0009e367c0f35bc2fe14564f03f8743b1e9ba

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/2/testReport/

Max. process+thread count
2215 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 27s

trunk passed

+1 :green_heart:
compile
1m 39s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 30s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 47s

trunk passed

+1 :green_heart:
javadoc
1m 16s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 34s

trunk passed

+1 :green_heart:
shadedclient
22m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 20s

the patch passed

+1 :green_heart:
compile
1m 24s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 24s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 83 unchanged - 0 fixed = 87 total (was 83)

+1 :green_heart:
mvnsite
1m 26s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
3m 31s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html
hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
24m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
421m 54s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 21s

The patch does not generate ASF License warnings.

533m 25s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs

Nullcheck of pendingList at line 1859 of value previously dereferenced in org.apache.hadoop.hdfs.server.blockmanagement.DatanodeManager.handleHeartbeat(DatanodeRegistration, StorageReport[], String, long, long, int, int, int, VolumeFailureSummary, SlowPeerReports, SlowDiskReports)  At DatanodeManager.java:1859 of value previously dereferenced in org.apache.hadoop.hdfs.server.blockmanagement.DatanodeManager.handleHeartbeat(DatanodeRegistration, StorageReport[], String, long, long, int, int, int, VolumeFailureSummary, SlowPeerReports, SlowDiskReports)  At DatanodeManager.java:[line 1859]

Failed junit tests
hadoop.hdfs.TestFileAppend4

hadoop.hdfs.server.namenode.TestReconstructStripedBlocks

hadoop.hdfs.TestLeaseRecovery2

hadoop.hdfs.server.datanode.TestDataNodeTcpNoDelay

hadoop.hdfs.server.namenode.TestHostsFiles

hadoop.hdfs.server.namenode.TestUpgradeDomainBlockPlacementPolicy

hadoop.hdfs.server.blockmanagement.TestPendingReconstruction

hadoop.hdfs.server.blockmanagement.TestBlockManager

hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics

hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness

hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport

hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure

hadoop.hdfs.TestMissingBlocksAlert

hadoop.hdfs.server.namenode.ha.TestStandbyIsHot

hadoop.hdfs.server.blockmanagement.TestNodeCount

hadoop.hdfs.server.namenode.TestProcessCorruptBlocks

hadoop.hdfs.server.datanode.TestReadOnlySharedStorage

hadoop.hdfs.server.namenode.TestRedudantBlocks

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication

hadoop.hdfs.TestBlockStoragePolicy

hadoop.hdfs.server.datanode.TestDeleteBlockPool

hadoop.hdfs.server.blockmanagement.TestHeartbeatHandling

hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks

hadoop.hdfs.server.mover.TestStorageMover

hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage

hadoop.hdfs.server.datanode.TestDataNodeMetrics

hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5143

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b6c9bc9a24f8 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e03aff22c47e6f44bd23ba2602b544aa886f7108

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/3/testReport/

Max. process+thread count
3342 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m  1s

trunk passed

+1 :green_heart:
compile
1m 51s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 41s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 20s

trunk passed

+1 :green_heart:
mvnsite
1m 52s

trunk passed

+1 :green_heart:
javadoc
1m 23s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m  0s

trunk passed

+1 :green_heart:
shadedclient
26m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 31s

the patch passed

+1 :green_heart:
compile
1m 39s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 39s

the patch passed

+1 :green_heart:
compile
1m 29s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  2s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 83 unchanged - 0 fixed = 87 total (was 83)

+1 :green_heart:
mvnsite
1m 35s

the patch passed

+1 :green_heart:
javadoc
1m  4s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 56s

the patch passed

+1 :green_heart:
shadedclient
26m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
499m 12s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 29s

The patch does not generate ASF License warnings.

622m 38s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestHeartbeatHandling

hadoop.hdfs.server.datanode.TestBlockRecovery2

hadoop.hdfs.server.namenode.TestProcessCorruptBlocks

hadoop.hdfs.TestSetrepIncreasing

hadoop.hdfs.server.namenode.TestHostsFiles

hadoop.hdfs.TestFileAppend4

hadoop.hdfs.server.datanode.TestDataNodeTcpNoDelay

hadoop.hdfs.server.blockmanagement.TestNodeCount

hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness

hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.server.mover.TestStorageMover

hadoop.hdfs.server.datanode.TestDeleteBlockPool

hadoop.hdfs.server.namenode.TestFSEditLogLoader

hadoop.hdfs.server.namenode.TestUpgradeDomainBlockPlacementPolicy

hadoop.hdfs.server.datanode.TestReadOnlySharedStorage

hadoop.hdfs.server.namenode.ha.TestStandbyIsHot

hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication

hadoop.hdfs.TestLeaseRecovery2

hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics

hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage

hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics

hadoop.hdfs.TestMissingBlocksAlert

hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure

hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport

hadoop.hdfs.server.namenode.TestRedudantBlocks

hadoop.hdfs.server.blockmanagement.TestBlockManager

hadoop.hdfs.server.blockmanagement.TestPendingReconstruction

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5143

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ffbff76bd9b9 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5ce5d5557f553398807ed03a58ef1e598c2e410b

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/4/testReport/

Max. process+thread count
2804 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 47s

trunk passed

+1 :green_heart:
compile
1m 45s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 34s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 18s

trunk passed

+1 :green_heart:
mvnsite
1m 39s

trunk passed

+1 :green_heart:
javadoc
1m 17s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 50s

trunk passed

+1 :green_heart:
shadedclient
27m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 27s

the patch passed

+1 :green_heart:
compile
1m 32s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 32s

the patch passed

+1 :green_heart:
compile
1m 27s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  3s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 86 unchanged - 0 fixed = 90 total (was 86)

+1 :green_heart:
mvnsite
1m 46s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 37s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 46s

the patch passed

+1 :green_heart:
shadedclient
28m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
497m 34s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 10s

The patch does not generate ASF License warnings.

622m 55s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport

hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics

hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting

hadoop.hdfs.server.namenode.TestHostsFiles

hadoop.hdfs.server.datanode.TestBlockRecovery2

hadoop.hdfs.TestSetrepIncreasing

hadoop.hdfs.TestMissingBlocksAlert

hadoop.hdfs.TestBlockStoragePolicy

hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness

hadoop.hdfs.server.namenode.TestUpgradeDomainBlockPlacementPolicy

hadoop.hdfs.server.mover.TestStorageMover

hadoop.hdfs.server.blockmanagement.TestBlockManager

hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.server.namenode.TestReconstructStripedBlocks

hadoop.hdfs.server.namenode.TestRedudantBlocks

hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks

hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes

hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage

hadoop.hdfs.server.blockmanagement.TestNodeCount

hadoop.hdfs.server.datanode.TestReadOnlySharedStorage

hadoop.hdfs.server.datanode.TestDataNodeTcpNoDelay

hadoop.hdfs.server.blockmanagement.TestHeartbeatHandling

hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication

hadoop.hdfs.server.namenode.TestProcessCorruptBlocks

hadoop.hdfs.server.datanode.TestDataNodeMetrics

hadoop.hdfs.server.datanode.TestDeleteBlockPool

hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics

hadoop.hdfs.server.blockmanagement.TestPendingReconstruction

hadoop.hdfs.TestFileAppend4

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5143

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c9b245c05c82 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6b90a1523400a1d3d7ac2a3c4c0797ce48e6c175

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/5/testReport/

Max. process+thread count
2606 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 30s

trunk passed

+1 :green_heart:
compile
1m 52s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 40s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 22s

trunk passed

+1 :green_heart:
mvnsite
1m 45s

trunk passed

+1 :green_heart:
javadoc
1m 25s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m  2s

trunk passed

+1 :green_heart:
shadedclient
26m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 30s

the patch passed

+1 :green_heart:
compile
1m 40s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 40s

the patch passed

+1 :green_heart:
compile
1m 28s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 28s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 86 unchanged - 0 fixed = 88 total (was 86)

+1 :green_heart:
mvnsite
1m 34s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 47s

the patch passed

+1 :green_heart:
shadedclient
26m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
387m 18s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  3s

The patch does not generate ASF License warnings.

510m 11s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5143

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 90c154170cfa 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 86140acf2a8c7147861f8373c8f28e9f4c2fa459

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/6/testReport/

Max. process+thread count
2227 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m  2s

trunk passed

+1 :green_heart:
compile
1m 51s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 39s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 21s

trunk passed

+1 :green_heart:
mvnsite
1m 51s

trunk passed

+1 :green_heart:
javadoc
1m 25s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m  2s

trunk passed

+1 :green_heart:
shadedclient
26m 42s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 30s

the patch passed

+1 :green_heart:
compile
1m 38s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 38s

the patch passed

+1 :green_heart:
compile
1m 26s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 26s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 85 unchanged - 1 fixed = 87 total (was 86)

+1 :green_heart:
mvnsite
1m 33s

the patch passed

+1 :green_heart:
javadoc
1m  2s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 33s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 44s

the patch passed

+1 :green_heart:
shadedclient
26m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
400m 45s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

522m 48s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestDatanodeManager

hadoop.hdfs.TestLeaseRecovery2

hadoop.hdfs.server.mover.TestMover

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5143

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 7d19f58bea3f 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c605ce7e54f34f55d99168e9c3b53bd3526d1ae7

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/7/testReport/

Max. process+thread count
2130 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 28s

trunk passed

+1 :green_heart:
compile
1m 35s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 30s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 18s

trunk passed

+1 :green_heart:
mvnsite
1m 40s

trunk passed

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 35s

trunk passed

+1 :green_heart:
shadedclient
24m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 26s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 27s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 27s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
1m  8s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 85 unchanged - 1 fixed = 87 total (was 86)

+1 :green_heart:
mvnsite
1m 31s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 23s

the patch passed

+1 :green_heart:
shadedclient
22m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
294m  3s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  4s

The patch does not generate ASF License warnings.

405m 50s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5143

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 938214d752c3 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c63e7d235c2442cbea7dafe9c66de0ae0992eac5

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/9/testReport/

Max. process+thread count
3041 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 24s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 20s

trunk passed

+1 :green_heart:
compile
2m 12s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 59s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 32s

trunk passed

+1 :green_heart:
mvnsite
2m  1s

trunk passed

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 56s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 22s

trunk passed

+1 :green_heart:
shadedclient
31m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 46s

the patch passed

+1 :green_heart:
compile
1m 49s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 49s

the patch passed

+1 :green_heart:
compile
1m 39s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 39s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
1m  5s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 85 unchanged - 1 fixed = 87 total (was 86)

+1 :green_heart:
mvnsite
1m 45s

the patch passed

+1 :green_heart:
javadoc
1m  9s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 42s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m  6s

the patch passed

+1 :green_heart:
shadedclient
29m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
390m 14s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  2s

The patch does not generate ASF License warnings.

528m 46s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

hadoop.hdfs.server.mover.TestMover

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5143

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 73590333eed2 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7ffcb8352e48c2c255c150f8e88f5e40f3f190dd

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/8/testReport/

Max. process+thread count
1984 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  4s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 51s

trunk passed

+1 :green_heart:
compile
2m 15s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 59s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 38s

trunk passed

+1 :green_heart:
mvnsite
2m  9s

trunk passed

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 54s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 37s

trunk passed

+1 :green_heart:
shadedclient
29m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 30s

the patch passed

+1 :green_heart:
compile
1m 39s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 39s

the patch passed

+1 :green_heart:
compile
1m 28s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 85 unchanged - 1 fixed = 86 total (was 86)

+1 :green_heart:
mvnsite
1m 36s

the patch passed

+1 :green_heart:
javadoc
1m  3s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 48s

the patch passed

+1 :green_heart:
shadedclient
26m 55s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
395m 25s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  5s

The patch does not generate ASF License warnings.

528m 13s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5143

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 43e292ac8134 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4222b09357bb43765dad98be7e55837be038c7a9

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/10/testReport/

Max. process+thread count
2082 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  9s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 28s

trunk passed

+1 :green_heart:
compile
2m 11s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 59s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 31s

trunk passed

+1 :green_heart:
mvnsite
2m 13s

trunk passed

+1 :green_heart:
javadoc
1m 38s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 49s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 13s

trunk passed

+1 :green_heart:
shadedclient
29m 43s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 43s

the patch passed

+1 :green_heart:
compile
1m 54s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 54s

the patch passed

+1 :green_heart:
compile
1m 40s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 11s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 85 unchanged - 1 fixed = 86 total (was 86)

+1 :green_heart:
mvnsite
1m 48s

the patch passed

+1 :green_heart:
javadoc
1m 14s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 46s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 13s

the patch passed

+1 :green_heart:
shadedclient
29m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
389m 33s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

526m 12s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5143

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 33618ae528a4 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6e569b1cb1611bbea8a5db4d49dfdefcc0a5fc66

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/11/testReport/

Max. process+thread count
2034 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  9s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 24s

trunk passed

+1 :green_heart:
compile
1m 51s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 48s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 23s

trunk passed

+1 :green_heart:
mvnsite
1m 52s

trunk passed

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 48s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
5m  3s

trunk passed

+1 :green_heart:
shadedclient
28m 54s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 38s

the patch passed

+1 :green_heart:
compile
1m 43s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 43s

the patch passed

+1 :green_heart:
compile
1m 30s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 85 unchanged - 1 fixed = 86 total (was 86)

+1 :green_heart:
mvnsite
1m 39s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 39s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m  1s

the patch passed

+1 :green_heart:
shadedclient
27m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
382m  8s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

510m 15s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestObserverNode

hadoop.hdfs.TestLeaseRecovery2

hadoop.hdfs.server.mover.TestMover

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5143

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 8d8336c5df53 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 02b5388102e578a7c8e97682672db7d412c6f32f

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/12/testReport/

Max. process+thread count
2094 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5143/12/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Merged it. Thanks for your contribution and fixing this issue, @lfxy!


20221112 fuzz test compile execute

This is the mostly fully fledged outcome of the work i started in feb (20220204-fuzzer) .  I've learned a lot from arvid, advice other rust people.
./compiler-fuzz.sh generates and runs programs in a few different ways and panics when any of the results don't match.  There may still be things the fuzzer generates which aren't supposed to be allowed, so it isn't being made part of the test suite yet.

My intention for this code is to start exploring how to get this stuff going.  This is solid progress toward the goal of getting more rigorous fuzz testing into the build.
as far as the file structure goes, i followed https://rust-fuzz.github.io/book/cargo-fuzz/tutorial.html
and since i have more than one fuzz target potentially, i've put them in subdirs.
Is there a way you'd like (as a reviewer) me to label subdirectory membership so that it's easier to understand when coming in?

Ok i see, what you're taking objection to is the lack of the fuzz_targets subdir?

Thanks, the previous tutorial material I had read suggested that cargo needed to be run with special options (and so i isolated that part), but apparently that isn't needed now.

My intention for this code is to start exploring how to get this stuff going. This is solid progress toward the goal of getting more rigorous fuzz testing into the build.
as far as the file structure goes, i followed https://rust-fuzz.github.io/book/cargo-fuzz/tutorial.html and since i have more than one fuzz target potentially, i've put them in subdirs.
Is there a way you'd like (as a reviewer) me to label subdirectory membership so that it's easier to understand when coming in?

The tutorial says fuzz targets go in:
fuzz/fuzz_targets/<fuzz target name>.rs

Which is what I would expect.

Moved fuzz program to fuzz/fuzz_targets/programs.rs

thanks to your advice, now that fuzzing is working right, it found a leak.
fix for that is included.


chore: deps-dev upgrades, see full list in Description

Dev Instructions: Restart your IDE after using yarn to update all the packages.
label: needs-insider-smoke-test
Description

build(deps-dev): bump @codemirror/view from 0.19.32 to 6.0.3 (equivalent to #825 and #874 )
build(deps-dev): bump @tsconfig/svelte from 1.0.10 to 3.0.0 (this upgrade surfaced the fixes from #867 and is likely also important for esbuild to continue functioning correctly)
build(deps-dev): bump tslib from 2.3.1 to 2.4.0 (equivalent to #782)
build(deps-dev): bump typescript from 4.5.4 to 4.7.4 (equivalent dependabot PR not found)
build(deps-dev): bump prettier from 2.4.1 to 2.7.1 (equivalent dependabot PR not found)
build(deps-dev): bump svelte-check from 2.7.2 to 2.8.0 (equivalent dependabot PR not found)
build(deps-dev): bump svelte-preprocessor from 4.10.1 to 4.10.7 (equivalent dependabot PR not found)
build(deps-dev): bump svelte from 3.48.0 to 3.49.0 (equivalent dependabot PR not found)
build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.7.0 to 5.30.5 (equivalent to #855 )
build(deps-dev): bump @typescript-eslint/parser from 5.7.0 to 5.30.5 (equivalent might be in #855 otherwise not found)
build(deps-dev): bump eslint from 7.22.0 to 8.19.0 (equivalent dependabot PR not found)
build(deps-dev): bump eslint-plugin-prettier from 3.x to 4.2.1 (equivalent to #841)
build(deps-dev): bump builtin-modules from 3.2.0 to 3.3.0 (equivalent dependabot PR not found)
build(deps-dev): bump esbuild-svelte from 0.6.0 to 0.7.1 (equivalent dependabot PR not found)
build(deps-dev): bump esbuild from 0.13.15 to 0.14.48 (equivalent to #870, still pinning to exact version in package.json)
fix: Fix EditTask.svelte import of chrono-node to not break after esbuild upgrade
chore(deps-dev): add prettier-plugin-svelte to style lint .svelte files
chore: format EditTask.svelte to match project code style
build(deps-dev): remove unused import of @types/node (was also behind, no dependabot PR found)
build(deps-dev): bump @types/jest from 26.0.22 to 28.1.4 (equivalent dependabot PR not found)
build(deps-dev): bump jest from 27.3.1 to 28.1.2 (equivalent dependabot PR not found)
build(deps-dev): add jest-environment-jsdom to deps-dev (jest 28 no longer includes it, requires separate installation or tests fail)
build(deps-dev): bump ts-jest from 27.0.7 to 28.0.5 (equivalent dependabot PR not found)
build(deps): bump chrono-node from 2.2.6 to 2.3.9 (equivalent dependabot PR not found)

Motivation and Context
package.json/yarn.lock: Get rid of a bunch of dependency upgrade debt. After this PR the only yarn outdated is Obsidian API, which I did not touch since I did not want to affect the minimum Obsidian version required. This should hopefully decrease the chances of issues with future upgrades, including to the Obsidian API and give the maintainer some breathing room on handling/batching non-security-related dependency upgrades.
The changes to EditTask.svelte are to fix #764 (line 2) and have it follow the code style of the project by running prettier on it (the other lines).
How has this been tested?
Automated tests pass locally on my Windows dev machine and on GitHub Actions in my fork. Smoke tested the final result of this batch on Obsidian stable 0.14.15 on Windows.
Needs Obsidian insider smoke-test.
I'd also be happy to know if a dev on some non-Windows platform can confirm that the dev experience is still working after yarn install all of the package updates and restarting their IDE.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] Internals

Checklist:

[x] My code follows the code style of this project and passes yarn run lint.

I agree to the Code of Conduct.

This is amazing. Thank you ever so much. I've got quite a busy weekend - will pick it up when I get a block of time free - in the next day or two.

This should hopefully decrease the chances of issues with future upgrades, including to the Obsidian API and give the maintainer some breathing room on handling/batching non-security-related dependency upgrades.

Music to my ears!

All smoke tests passed on insider build 0.15.5 on Mac, with distribution created after:

deleting node_modules
yarn install
Restart WebStorm
yarn dev
Copy distribution to TestVault - and run the smoke tests

Also inspected whole project in WebStorm, and warnings seemed pretty much as before.

Thank you @AnnaKornfeldSimpson  ❤
Just one question: do you know why both these moment versions are required in yarn.lock. Could I delete the older one?
https://github.com/obsidian-tasks-group/obsidian-tasks/pull/872/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deR3353-R3362
<EMAIL_ADDRESS>  version "2.29.2"
  resolved "https://registry.yarnpkg.com/moment/-/moment-2.29.2.tgz#00910c60b20843bcba52d37d58c628b47b1f20e4"
  integrity sha512-UgzG4rvxYpN15jgCmVJwac49h9ly9NurikMWGPdVxm8GZD6XjkKPxDTjQQ43gtGgnV3X0cAyWDdP2Wexoquifg==

<EMAIL_ADDRESS>  version "2.29.4"
  resolved "https://registry.yarnpkg.com/moment/-/moment-2.29.4.tgz#3dbe052889fe7c1b2ed966fcb3a77328964ef108"
  integrity sha512-5LC9SOxjSc2HF6vO2CyuTDNivEdoz2IvyJJGj6X8DJ0eFyfszE0QiEd+iXmBvUP3WHxSjFH/vIsA0EN00cgr8w==

Just one question: do you know why both these moment versions are required in yarn.lock. Could I delete the older one?
https://github.com/obsidian-tasks-group/obsidian-tasks/pull/872/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deR3353-R3362
...
I do and it's not related to this PR but knowledge from when I did #854 - the obsidian API is dependent on the older version of moment. When I looked the other day (before 0.15.5 insider was released) there was not a version of the Obsidian API that was dependent on the new .4 moment yet (and even if there is now, we wouldn't be able to deliver that api bump to folks on stable/non-insider).

Thank you. I was hoping to be able to remove the older moment, as it is showing up as a serious problem in dependabot alerts.

Also inspected whole project in WebStorm, and warnings seemed pretty much as before.

Do you have a way to share any of the warnings that seem actionable? My less-fancy IDE and the open source scanning tools I have found have no warnings other than the old version of moment mentioned above?

Not in a way that's easy for me to share them right now. For some of them, it will be quicker for me to go ahead and fix them. For others, I will probably just create issues some time soon.


0.1.12 can no longer be used in Ember component's didInsertElement()

0.1.12 introduced an error that makes it unusable in Ember 3.0 (didn't test 3.1 yet). Unfortunately the commit is too long to find the proper line, but the effect is

ember-console.js:29 Unhandled error: TypeError: Cannot read property 'commit' of null
renderer.js:167 Uncaught Error: infinite rendering invalidation detected

Basic example to reproduce (anybody knows how to set up an JSFiddle (or similar) with Ember etc.? Sorry):
//app/components/pull-to-refresh.js
import Component from '@ember/component';
import PullToRefresh from 'npm:pulltorefreshjs';

export default Component.extend({

  classNames: ['pull-to-refresh'],

  didInsertElement() {
    this._super(...arguments);

    PullToRefresh.init({
      mainElement: '.pull-to-refresh',
      });
  },
});

// app/templates/some-view.hbs
<div class="some-view">
    {{#pull-to-refresh}}
        ...
    {{/pull-to-refresh}}
</div>

The view some-view can be opened with v0.1.11, cannot be opened with v0.1.12

module.exports = PullToRefresh
add it

My apologies, I rebuilt the library not using an UMD format, I fixed and released v0.1.13 right now!


Historical Work Page | BE

Link to Ticket
Description of Changes Made
This refactors the existing Work Page model to pave way for the introduction of a new Work Page model based on the new designs.
Key Changes

Rename WorkPage to HistoricalWorkPage
Create AbstractPageScreenShot and AbstractPageAuthor, so that, upon subclassing, we can create a page ParentalKey to whichever Page model we choose. In this PR, we do this for the HistoricalWorkPage above. We'll be able to do this for the new WorkPage
Remove some unused code (mainly tags on work pages)
update references to WorkPage so that they now refer to HistoricalWorkPage
Ensure that  HistoricalWorkPage cannot be created in Wagtail Admin (we want people to create the new WorkPages instead)

How to Test
In Wagtail Admin, go to Pages > Torchbox > Work: http://<IP_ADDRESS>:8000/admin/pages/6/.

You should see the old Work Pages there, and they should be called Historical Pages
You should be able to edit the existing pages
You should not be able to create a Historical Work Page

Screenshots

Expand to see more

MR Checklist

[x] Add a description of your pull request and instructions for the reviewer to verify your work.
[x] If your pull request is for a specific ticket, link to it in the description.
[x] Stay on point and keep it small so the merge request can be easily reviewed.
[x] Tests and linting passes.

Unit tests

[ ] Added
[x] Not required

Documentation

[ ] Updated build docs
[ ] Updated editor guidelines (https://docs.google.com/document/d/1PAWccdQ4tfaZsrEWmpDhvP3GH5RRmBOARFVp4b-kje8/edit?usp=sharing)
[x] Not required

Browser testing

[ ] I have tested in the following browsers and environments (edit the list as required)

Latest version of Chrome on mac
Latest version of Firefox on mac
Latest version of Safari on mac
Safari on last two versions of iOS
Chrome on last two versions of Android

[x] Not required

Data protection

[ ] Not relevant
[x] This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Accessibility

[ ] Automated WCAG 2.1 tests pass
[ ] Manual WCAG 2.1 tests completed
[ ] I have tested in a screen reader
[ ] I have tested in high-contrast mode
[ ] Any animations removed for prefers-reduced-motion
[x] Not required

Sustainability

[ ] Images are optimised and lazy-loading used where appropriate
[ ] SVGs have been optimised
[ ] Perfomance and transfer of data considered
[ ] If JavaScript is needed alternatives have been considered
[ ] New font variants have not been added
[x] Not required

Pattern library

[ ] The pattern library component for this template displays correctly, and does not break parent templates
[ ] The styleguide is updated if relevant
[x] Changes are not relevant the pattern library

@engineervix I have now merged the fe changes for the historical work page to the integration branch


[Bug]: AxiosError: Request failed with status code 401

Please note: any submissions with insufficient reproducible information will be marked as 'Waiting for customer input' and may be closed is there is no response
Describe the bug

Following the procedure outlined on Microsoft's Learn site (https://learn.microsoft.com/en-us/microsoftteams/platform/sbs-botbuilder-conversation-ai?tabs=vscode%2Cviscode) and using information provided by this repository and https://www.youtube.com/watch?v=oj3jr9OJfR0 to connect to Azure OpenAI instead of Open AI, it fails with:

[onTurnError] unhandled error: AxiosError: Request failed with status code 401
I have updated the key, I have specified the endpoint, I am using the DeploymentName (not model), I am using the correct planner object and there is no reference to the model in my config.json as per the article.
To Reproduce

The steps to reproduce this behavior are outlined at https://learn.microsoft.com/en-us/microsoftteams/platform/sbs-botbuilder-conversation-ai?tabs=vscode%2Cviscode

I pointed to my Azure Open AI model instead. Using the Key, DeploymentName, endpoint and proper planner object.
Expected behavior

Expect to type in "hi" and get a response.

Screenshots

Desktop(s) (please complete the following information):

OS: Windows 11 Pro 21H2 - 22000.1455
Browser Edge (115.0.1901.200 (Official build) (64-bit))

Additional context

I was using my own method of sending a JSON Payload to Azure Open AI model using /extensions/chat/completions and Axios was failing with the same 401 error (even though it was working in postman, same url, same key, same payload) The additional error i was getting was stating the payload was wrong and there was a wrong type: text... which made me go every which way to adjust my JSON and would always throw the same error using axios (same as we see here)... but i changed it to use the superagent library and the same url, key and payload worked fine. Feels like something is up with Axios.

Well I got it to work by commenting out the "moderator" pieces. The sample provided in this repository has moderator commented out already, however the learn module at Microsoft is not commenting out the moderator and it fails with the axios library error.


Refactored flashloader can't normalize data

This is somehow related to bam correction. In the timed_dataframe, delayStage positions are not the same as in the dataframe after bam correction, if parquets are created with the new flash loader. Currently, no idea why.

A major difference between the old and new loader is the dask index: It is continous in the old loader, and very sparse in the new loader:
Old:

New:

It's related to the bam correction and the mean offsetting:
Old:

New:

Old:

New:

It seems there are a lot of empty entries in the timed_dataframe, where actually not even a photon pulse was present.

The computation time with the parquet generated with the new loader also is >2 as long.

I think the slowdown is because of this section being offloaded to dask
https://github.com/OpenCOMPES/sed/blob/86978c08be702f550ae10c04be1357cc012ebcf0/sed/loader/flash/loader.py#L610-L614

It seems there are a lot of empty entries in the timed_dataframe, where actually not even a photon pulse was present.

This was requested feature by Davide (#307) that the timed dataframe should contain all available values from pulses and not just ones where electrons are detected.

This was requested feature by Davide (#307) that the timed dataframe should contain all available values from pulses and not just ones where electrons are detected

Indeed, but these should also only contain valid pulses, where actual shots exist

Indeed, but these should also only contain valid pulses, where actual shots exist

Yes, this comes from the flash data structure of storing 1000 pulses for each train.
The simple way I can think to adapt this is a hard threshold the pulseId for timed_dataframe. Because it's not nans that are stored in bam column but zeros. (In other pulse resolved channels might be zero)
@kutnyakhov any ideas?

A major difference between the old and new loader is the dask index: It is continous in the old loader, and very sparse in the new loader:

This is just because nan drop takes place after loading the buffer files.

sp._timed_dataframe = sp._timed_dataframe[sp_50826._timed_dataframe["pulseId"] < 500].ffill()
ffill should happen with overlap but in general, something like this would fix the issue of noramlizing data

There should be a permanent fix. Probably beet to look for the first nonzero entry from the back or so. Another config entry I would avoid if possible

That's not the reason. Even if I disable the sector split, it's still slow.

Might be it's slow because of indexes
https://docs.dask.org/en/stable/generated/dask_expr._collection.DataFrame.set_index.html#dask_expr._collection.DataFrame.set_index
But I will think of a solution that allows the correct electron and timed dataframes and also be fast.

If directly loading the parquet files, first thing to notice is that the new loader produces ~6.5 times more entries compared to the old one, and also the number of entries and remaining NaN is much different:
This is the output of df.count().compute on two directly loaded parquet dataframes (single file):
Old:
trainId                      423643
pulseId                      423643
electronId                   423643
timeStamp                    423643
dldPosX                      423643
dldPosY                      423643
dldTimeSteps                 423643
cryoTemperature              423643
dldTimeBinSize               423643
extractorCurrent             423643
extractorVoltage             423643
sampleBias                   423643
sampleTemperature            423643
tofVoltage                   423643
pulserSignAdc                  9184
monochromatorPhotonEnergy      4571
gmdBda                        44019
bam                          423341
delayStage                    43846
dldSectorID                  423643
dtype: int64

New:
trainId                      2782954
pulseId                      2782954
electronId                   2782954
dldPosX                       423643
dldPosY                       423643
dldTimeSteps                  423643
pulserSignAdc                  25630
bam                          2563000
timeStamp                       2563
monochromatorPhotonEnergy         27
gmdBda                           264
delayStage                       263
sampleBias                      2563
tofVoltage                      2563
extractorVoltage                2563
extractorCurrent                2563
cryoTemperature                 2563
sampleTemperature               2563
dldTimeBinSize                  2563
dtype: int64

Clearly, the performance with the old files is much superior, also their storage size is a fac.tor 2 or so smaller. This should be changed again.

Regarding the timed_dataframe, does it really make a difference if this is computed on the pulse rather than the train level? This would make things super much simple and more performant. I think it's worth checking if that makes a practical difference, if you e.g. take the mean of a train and normalize by this.

If directly loading the parquet files, first thing to notice is that the new loader produces ~6.5 times more entries compared to the old one, and also the number of entries and remaining NaN is much different: This is the output of df.count().compute on two directly loaded parquet dataframes (single file): Old:

Yes this is simply because we are not dropping nans from electron columns before saving the files (how it was done before):
https://github.com/OpenCOMPES/sed/blob/86978c08be702f550ae10c04be1357cc012ebcf0/sed/loader/flash/loader.py#L610-L614
If we do that, the dataframe becomes much smaller.
This doesn't work with if we want to keep the pulse data even without electrons.
One solution could be to save a df and df_timed parquet and then load both per file. Technically it's also possible to save a parquet for each run and just divide the 'per file' into row groups.

Clearly, the performance with the old files is much superior, also their storage size is a fac.tor 2 or so smaller. This should be changed again.

I can of course bring back the old behavior (saving after dropping nans) so we can run tests to see if that is the performance bottleneck.
File size is not the biggest issue because parquet files are quite small.

Regarding the timed_dataframe, does it really make a difference if this is computed on the pulse rather than the train level? This would make things super much simple and more performant. I think it's worth checking if that makes a practical difference, if you e.g. take the mean of a train and normalize by this.

I thought we  just had a discussion today about monochromator and using the pulse channel for it instead of train. Perhaps I misunderstood but I can't shed light on whether it's useful or not.
@balerion if you are still using sed, could you explain your usecase?

as expected, from my tests, binning performance stays same if i remove nans before saving (index is monotonic then like in main branch version. You can test from branch fix-459

Something is still different. While the speed is back to normal, the result looks quite different:
Old:

New:

Fixed:

It appears to attach the wrong delay stage values (?)

Counts for the same file:
Old:

New:

Fixed:

There are 2567 trains in this file, and 257 different unique delay stage position values

closed by #469


Silent installation doesn't work on Windows

What's wrong?
The documentation says to use /S.  This still brings up a dialog.
Steps to reproduce
Run inst.exe /s.  Dialog box to accept license appears.
System information
Windows 2022
Software version
Grafana Alloy v1.0.0
Configuration
n/a

Logs
n/a

Problem solved: must be a capital "S" in /S.  This is noted in the NSIS documentation.

Problem solved: must be a capital "S" in /S.  This is noted in the NSIS documentation.


_AppCtxGlobals causes assigning-non-slot warning from pylint and mypy

Describe how to replicate the bug.

I'm doing the fairly standard thing of adding a g.user property on the appcontext in my app, but pylint is complaining with:
Assigning to attribute 'user' not defined in class slots (assigning-non-slot)

Ignoring the pylint warning makes mypy complain very loudly error:
"AppContext" has no attribute "user"

This can be reproduced using the docs https://flask.palletsprojects.com/en/2.0.x/appcontext/#storing-data, which tell the user to store the db on g using: g.db = connect_to_database().
If we're not supposed to be setting random properties there any more then the docs probably need fixing. maybe we're supposed to use db = g.setdefault("db", connect_to_database()) now?

Python version: 2.0.0
Flask version: 3.9.4

This looke like a duplicate of #4020

_AppCtxGlobals doesn't set __slots__, but it looks like the type of flask.globals.g is incorrectly marked as AppContext (which also doesn't define slots, so not sure why that's the error).

I'll reopen the original issue, this is still a duplicate. Thanks for reporting it.


doc(kfp): connecting KFP SDK client to API generic introduction

Fixes https://github.com/kubeflow/pipelines/issues/5690
Fixes https://github.com/kubeflow/website/issues/2732
Major changes:

introduce generic way to connect KFP SDK client to API
introduce how to configure KFP SDK client with env vars
add an example section for referring to the generic connect KFP SDK client to API doc
fix usages of KFP v2 compiler, we should use KFP v1 compiler with mode=V2_COMPATIBLE instead.
added a new script: ./scripts/kfp_nb_to_md.sh, it converts all KFP notebooks in one batch, so we won't forget any one of them.

/hold
This is for review first, more work needed after review.

/unhold
/approve

Merging this to resolve current confusions, feel free to keep commenting and I'll improve the doc over time.


samples: boards: mimxrt595_evk_cm33: system_off: misc cleanups

Remove unnecessary includes
Remove redundant definitions (sample is not portable anyway)
Use printf
Check for device readiness
Do not check for zero ticks (not possible for the given timeout/driver), also, driver should likely error for such case anyway
Check for all error codes

Can you add CONFIG_REGULATOR=y to the prj.conf file? Testing this sample it seems that it is not being turned on, but it should be (I suspect that this was also broken before this PR). With those changes this sample works for me

hmm but the application doesn't use the regulator API, so the setting must be enabled somewhere else. where/how is it being used?

hmm but the application doesn't use the regulator API, so the setting must be enabled somewhere else. where/how is it being used?

This board has the PCA9420 on it- that regulator can have the voltage mode selected via two input pins. On the RT595 EVK, those pins are routed to a few special signals on the SOC that will toggle when the part enters low power mode. So while the sample does not use the regulator API, power management on this board requires the regulator in order to function. It looks like what is needed here is to default CONFIG_REGULATOR to enabled at the board level when CONFIG_POWEROFF=y, just as we do when CONFIG_PM=y: https://github.com/zephyrproject-rtos/zephyr/blob/33c922a771aee12e329de1a10c6fc65b0e01ed4a/boards/arm/mimxrt595_evk/Kconfig.defconfig#L32

hmm but the application doesn't use the regulator API, so the setting must be enabled somewhere else. where/how is it being used?

This board has the PCA9420 on it- that regulator can have the voltage mode selected via two input pins. On the RT595 EVK, those pins are routed to a few special signals on the SOC that will toggle when the part enters low power mode. So while the sample does not use the regulator API, power management on this board requires the regulator in order to function. It looks like what is needed here is to default CONFIG_REGULATOR to enabled at the board level when CONFIG_POWEROFF=y, just as we do when CONFIG_PM=y:
https://github.com/zephyrproject-rtos/zephyr/blob/33c922a771aee12e329de1a10c6fc65b0e01ed4a/boards/arm/mimxrt595_evk/Kconfig.defconfig#L32

Thanks for the details, added a new patch enabling regulator if poweroff is also enabled.


Services: Improved behavior when the first route to the server doesn't work

Description
Before, the Service Client would only try the very first route to the Service Server. Now, it will go through all routes until it finds one that works.
Cherry-pick to

none

On GH Actions, some Unit Tests are now failing:
4: [  PASSED  ] 10 tests.
4: [  FAILED  ] 1 test, listed below:
4: [  FAILED  ] ClientServer.ClientConnectEvent
4:
4:  1 FAILED TEST
 4/14 Test  #4: test_clientserver ................***Failed   72.27 sec

Technically speaking, the hostname resolution is async:
https://github.com/eclipse-ecal/ecal/blob/c0116ac9727f4b19d5c20146a61049a15cab2cb1/ecal/service/ecal_service/src/client_session_impl_v1.cpp#L85
But obviously, you need to wait for the hostname resolution and the connection establishement to finish, before the service can return any response.
The reason for the high timeout is, that eCAL doesn't use the immediate callbacks from the service library
How it should be:

eCAL detects service server via registration layer
Service client resolves hostname
Service client connects to service server
...
Service server is deleted
Service client immediately fires disconnection callback which is forwarded to the user

How I think it is implemented:

eCAL detects service server via registration layer
Service client resolves hostname
Service client connects to service server
...
Service server is deleted
Service client fires disconnection callback, but this is not used
...
eCAL runs registration layer and detects that the server is gone
eCAL tries to reconnect the client to the server anyways (I didn't debug it, only looked at the logs. But for some reason this seems to happen)
Service client resolves the hostname
Service client connects to non existing service server (fails)
eCAL fires a custom disconnection callback


feat: set a default --security-path for swift_package_tool

Add support for setting a custom --security-path. This also ensures the global path is not used.

I am not familiar with when/why one would need to use --security-path. Can we update an example to use it?

The --security-path sets the path for the fingerprints of the manifests and artifacts. Without setting this SPM will use a global path over in ~/.swiftpm. While i was testing the Swift Package Registry work (which ill have a PR up for soon) I ended up poisoning my global cache (my registry implementation returned a bad SHA during development) and found it incredibly confusing how to reset that global cache.
For users of @swift_package it makes sense IMO to keep this path local to the Bazel workspace (in this case within the rules runfiles). If folks want to use global caches they can instead not use @swift_package.
I added an example using security_path over here

I added an example using security_path over here

Sorry that I missed that. Thank you!


OS X: Media keys stop working after sleeping and resuming

Repro steps:

Play something, and then pause it
Put your Mac to sleep
Turn it on again
=> The play/pause, next, and previous keys will stop working with the app at this point.

Killing and restarting the app fixes the issue.

Can't replicate this issue.  Please provide a screencast or something of it happening

Neither can I. I think it was some random fluke.


Register version 0.1.2

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/50925
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.2 -m "<description of version>" bfb00c1f7364984fa25ba57821a57c387e68496a
git push origin v0.1.2


Revise the Minecraft dictionary

Uhm... you made the branch on upstream

...:woman_facepalming:
and even worse is that there is an useless tag now!


Followed instructions with go get, not working

I use go 1.9 with raspbian.
I used showterm to record what I did: https://showterm.io/cb14bb0eed3c2c78bf497

Thank you for the report.
Since make tries to build JS files, you need npm. However, the repo has prebuild files already, so the task is not mandatory. I removed the task from make not to require installing npm.

I have npm, I retried, but it gave me the same error. What should I do?

I updated the Makefile again. Could you try it on the latest master?

Closing as no recent activities. Feel free to reopen if you still have the issue.


Unknown Issue

I have installed r77 for test on several servers from Windows Server 2012 to windows Server 2022,and I have exprienced the same issue.,which  server's service like RDP,IIS,FTP server,etc refuses outside connection(the server is still online,just won't access connection) after a few weeks R77 installed.Since I don't have physical access on all those servers so I have no idea what happens.On the other hand,if I uninstall R77 on those servers,they will work fine.

Weird... Also tricky to debug it. Can you pinpoint what server is not working (RDP, HTTP or FTP) ? A reproduction on Windows client OS would be preferrable, as I currently don't have VM's for Windows Server.
I usually try things like disabling the hooks until the error no longer occurrs to find out which hook is responsible, and then pinpoint the error within that hook.

RDP,HTTP,FTP Server,MSSQL Server,mysql and etc are all not working


NPM Package

Noticed that pulling the module from NPM wasn't working so I went ahead and forked this repo and put it up on NPM.
https://www.npmjs.com/package/wamda-typeahead

Is this fork of typeahead still being maintained?  If so, why is it not on NPM?

The reality is that it isn't being maintained all that well. Do either of you want to pitch in?

@jcrben I would like to help. I use typeahead for multiple projects and need to ensure that it is well maintained.

I maybe wrong but I saw corejs-typeahead on npm so I think this issue has to be closed.

Here is a link to the package: https://www.npmjs.com/package/corejs-typeahead

It looks like it wasn't published by the corejavascript folks, but rather by ~mariusz-kraj. I don't know who this is. Maybe this person?
At any rate, I don't trust it.
https://www.npmjs.com/~mariusz-kraj

Just realize we have two issues open regarding the same general topic: releasing a new NPM package. I'm going to close this issue in favor of the earlier #55. Let's take the discussion over there.


Cannot define custom bantime per service

The fail2ban manual says that bantime can be over-ridden in a jail.  You can define it in fail2ban_services, but it's just ignored when rendering jail.local.j2.
If you give me a week or two, I'd be glad to write and test a patch.

That would be nice.
Is it possible that the fail2ban version is too old?

I don't mean that fail2ban ignores the entry, but rather that this role never puts it in the config file in the first place.


typescript support

I work on some project that uses clappr and typescript under the hood. So I typed most of clappr modules locally. And I would like to add these ts definions to clappr repo. What do you think about this?

Hi @andrepolischuk. Sure, feel free to open a PR to add these ts definitions.
Thanks!

@towerz Hey, would you please consider posting your type file? This would be a useful addition to this project.  Related request: #1899


IS the font applicable with the androidX library ?

Hello,
Thanks for your past support to do the font global but for some reason, I had to move to androidx , so I moved the project and updated all java and xml files.
Is it compatible with it or no ? thus we don't have any more

com.android.support:appcompat

Hi,
Yes it should work without a problem, I might upload a demo app that uses AndroidX.

Hmm I will check soon about it but i did implement it and then I got some error on running the app. I will recheck later about it.

Ok thanks, let me know if you found some issues with the library. Btw try running your app without this library first.

As promised here is a Demo AndroidX app the uses Typer. So far it works well with AndroidX without an issue!


GET returned 404 Not Found

System information

OS Platform and Distribution: manylinux2014
TensorFlow version: git HEAD
Python version: 3.6 - 3.9
Installed using virtualenv
Bazel version (if compiling from source): 3.7.2
GCC/Compiler version (if compiling from source): 10

Describe the problem
File missing on mirror?
20:49:09     Analyzing: target //tensorflow/tools/pip_package:build_pip_package (243 packages loaded, 3941 targets configured)
20:49:09     Analyzing: target //tensorflow/tools/pip_package:build_pip_package (409 packages loaded, 16799 targets configured)
20:49:09     WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/google/XNNPACK/archive/dfe763f462d3569323de6caa085d8b06ce38eb7b.zip failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found
20:49:09     INFO: Analyzed target //tensorflow/tools/pip_package:build_pip_package (433 packages loaded, 25206 targets configured).

Provide the exact sequence of commands / steps that you executed before running into the problem
20:49:09     bazel clean --expunge
20:49:09     export BAZEL_LINKLIBS=-l%:libstdc++.a
20:49:09     bazel build --config=nonccl //tensorflow/tools/pip_package:build_pip_package --verbose_failures
20:49:09     mkdir tensorflow-pkg
20:49:09     bazel-bin/tensorflow/tools/pip_package/build_pip_package --cpu --project_name tensorflow_aarch64 ./tensorflow-pkg

Hi @Saduf2019 ! Could you look into this issue?

@hrw
Can you please confirm if this issue occurs with the stable version of tensorflow as the nightly could have daily updates, can you let us know if it works fine on stable tested version 3.4/2.5 or 2.6

This was on Linaro CI. Our 'manylinux tensorflow nightly' job builds Tensorflow in a loop for Python 3.[6789] versions.
Log: https://ci.linaro.org/job/ldcg-python-manylinux-tensorflow-nightly/89/console
It looks like it built git HEAD for Python 3.6 and then started for 3.7 and failed.
Build of TF:
set -xe
source /tmp/workspace/venv-cp37-cp37m/bin/activate
expect configure_tensorflow
bazel clean --expunge
export BAZEL_LINKLIBS=-l%:libstdc++.a
bazel build --config=nonccl //tensorflow/tools/pip_package:build_pip_package --verbose_failures
mkdir tensorflow-pkg
bazel-bin/tensorflow/tools/pip_package/build_pip_package --cpu --project_name tensorflow_aarch64 ./tensorflow-pkg

Our Ansible playbooks/roles used for building: https://git.linaro.org/ci/job/configs.git/tree/ldcg-python-manylinux-tensorflow/ansible (parent dir has build.sh and build-manylinux2014-wheels.sh scripts which install and run Ansible).

I am aware that build scripts I use may need some improvements. All comments are welcome.

It built: https://snapshots.linaro.org/ldcg/python/tensorflow-manylinux-nightly/20210909-90/tensorflow-aarch64/
Closing. Sorry for mess.

And another one:
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/llvm/llvm-project/archive/f5b8f1247cd9d1b18b7b95f6f197d4d654597529.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found
WARNING: Download from http://mirror.tensorflow.org/github.com/tensorflow/runtime/archive/cf83c1cba92cb2ae97c08399531685fd9ccfe983.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found
Can't you first mirror and THEN commit? I have daily build so it fetches HEAD and do build. At some moment during 24h.


[Bug]: Error: NotFoundError - Resource not found while implementing llama index with Azure OpenAI for fine-tuning

Bug Description
During the implementation of the llama index with Azure OpenAI for fine-tuning, the following error occurred:
Retrying llama_index.llms.openai.base.OpenAI._chat in 0.6394267984578837 seconds as it raised NotFoundError: Error code: 404 - {'error': {'code': '404', 'message': 'Resource not found'}}.

Version
0.10.22
Steps to Reproduce
Code snippet:
# Perform query to retrieve the contexts and answers for the generated questions

self.llm = OpenAI(
    api_base=self.azure_openai_endpoint,
    api_key=self.azure_openai_api_key,
    api_version=self.azure_openai_api_version,
    model=self.model,
    temperature=self.temperature
)

query_engine = index.as_query_engine(similarity_top_k=2, llm=self.llm)

Additional Information:
The error seems to be related to a NotFound error with code 404 indicating that the requested resource was not found.
Problem Statement:
The issue occurs while trying to execute the query using Azure OpenAI. The error message suggests that the resource being requested is not found.
Solution Required:
Please provide guidance on how to resolve this issue as I am unsure how to proceed.
Relevant Logs/Tracbacks
No response

@dosu-bot
I've already successfully generated training and evaluation data using Azure openai, but I'm getting an error when I try to use the query engine. Could you please review this again?

@loyal812 please double check that you've specified the correct model name that you've deployed.
Here's an example that works for me
from llama_index.llms.azure_openai import AzureOpenAI

aoai_api_key = "YOUR_AZURE_OPENAI_API_KEY"
aoai_endpoint = "YOUR_AZURE_OPENAI_ENDPOINT"
aoai_api_version = "2023-07-01-preview"

llm = AzureOpenAI(
    model="gpt-35-turbo",
    deployment_name="YOUR_AZURE_OPENAI_COMPLETION_DEPLOYMENT_NAME",
    api_key=aoai_api_key,
    azure_endpoint=aoai_endpoint,
    api_version=aoai_api_version,
)


33714 Crash fixes for GLTF2 and FBX

A bugfix for https://github.com/godotengine/godot/issues/33714. Not sure if it fixes all the bugs though.

Thanks!


Expand __var__ hook args using Makefile vals.

Currently, amslah can automatically run a HOOK specified in the amslah.cfg before invoking G++. This hook can include any fixed args, as long as they are in the cfg line.
However, what if we want to call the hook with arbitrary dynamic args, like perhaps passed in -D flags?
In order for the HOOK to be dynamic, we need an explicit syntax to eval on, which will be __var__, since the double _ is not too common, and $ can cause lots of expansion edge case bugs.
Now, given this amslah.cfg & a Makefile var of REV=666,
HOOKS: zemi --board_rev=__REV__
HOOKS_POST: python3 check_flash.py
MCU: SAMD51N20A
CFLAGS: -Werror

__REV__ Is automatically expanded, and the HOOK is called as
zemi --board_rev=666

lgtm


Publish to PyPI with CircleCI

This pull request adds scaffolding needed for automatically running tests, building and deploying to PyPI using CircleCI.

Add license and url keys to setup.py
Modify tox.ini to run the tests for Python 2.7 and 3.4 (instead of 2.7 and 3.5) as these are the minimum required versions.
Add circle.yml for running tox for every commit and building + deploying to PyPI for every tagged commit.

The tag regexp is /^v[0-9.]$/.
The PyPI username and password have to be given in CircleCI env variables PYPI_USERNAME and PYPI_PASSWORD.

Closes #90.

CircleCI has not yet been enabled for this project.

Merged this in order to try out the CircleCI. It's still in progress


feat: update compute task workflow

Description

How has this been tested?


#180 Fix compatibility with Bitbucket 8.0

Removed the usage of TaskEvent and related classes which are not available in Bitbucket 8.0.
Using Comment events with CommentSeverity#BLOCKER to perform PR task related operations.
Fixed unit tests
Bumped POM version to 3.1.0-SNAPSHOT
Replaced 7.6.0 with 8.0.0-breakit-m13 to be used for running integration tests.

https://github.com/atlassian-labs/atlassian-slack-integration-server/issues/180

@mvlasovatl @utluiz Can you please add yourselves as reviewers in this PR. I am not able to add reviewers, seems like some permission issue.

Hi folks, we're aiming to update Atlassian's internal Bitbucket DC instance on 21 March and need an 8.0-compatible version of this plugin before we can do that. Would you be able to review this ASAP so we can get a new release and prepare for the upgrade? Thank you!


window is not the size of the video

The video player have fixed width = 150 and height = 100. To solve that i'd have to to manualy change the _set_frame_size() function.

@carlosneto726 I am unsure what you mean by video player have fixed width and height. Could you please elaborate. You should easily be able to fill the width and height.

let's say I want to play a video of size 1000 x 600, I call the play() function to play the video, but the video only shows in 150 X 100. Is there a way to do this? I'm sorry if I came across as ignorant or anything like that.
How it is:

How i want:

I am also facing this exact same issue

@Brandon4466 @carlosneto726 sorry for the late reply. I am guessing you haven't resized the window. The frame resides in the window. If this is not what you meant can you create a MRE

That works, thanks!


Generated Pull Request Title/Message Instructions

This is similar to #526  but for Pull Requests.  Is there going to be a different setting for it? Or can we use the new github.copilot.chat.commitMessageGeneration.instructions for the PRs as well?

I think we probably want a separate setting for this.