Ansible Installer is not working for previous versions to 0.8.0

When you use ansible installer from master, with istio.release_tag_version with 0.7.1, it results on the following error.

TASK [istio : Copy definition file] ********************************************
fatal: [localhost]: FAILED! => {"changed": true, "cmd": ["cp", "~/.istio/istio-0.7.1/install/kubernetes/istio-demo.yaml", "/tmp/ansible.QlxBG3JcPb/def.yml"], "delta": "0:00:00.920507", "end": "2018-06-12 06:02:08.022152", "msg": "non-zero return code", "rc": 1, "start": "2018-06-12 06:02:07.101645", "stderr": "cp: cannot stat '/home/jenkins/.istio/istio-0.7.1/install/kubernetes/istio-demo.yaml': No such file or directory", "stderr_lines": ["cp: cannot stat '/home/jenkins/.istio/istio-0.7.1/install/kubernetes/istio-demo.yaml': No such file or directory"], "stdout": "", "stdout_lines": []}
to retry, use: --limit @/home/jenkins/workspace/install-istio/istio/install/ansible/main.retry

@gbaufake in PR https://github.com/istio/istio/pull/6144 @geoand is aware of this problem.

@gbaufake Can you please see if  #6144 fixes your problem?

@geoand
I think it won't solve my problem since the backport for older versions will be dropped.
Checking the old branches may solve it (I have tested for 0.7.1 and it seems to be fine)

The PR will only work for 0.8. I am pretty sure it won't work for older versions (although I haven't tried it)


Clearly document the limitations with known_hosts

In order to successfully connect to a repo using ssh, among other things, 2 things are required:

An entry for the Git server must be present in the ~/.ssh/known_hosts file.
The entry must be in the ssh-rsa format, not ecdsa-sha2-nistp256.

Either one of the above steps missing results in a NPE.
java.lang.NullPointerException: null
	at com.jcraft.jsch.Session.checkHost(Session.java:802) ~[jsch-0.1.50.jar:na]
	at com.jcraft.jsch.Session.connect(Session.java:342) ~[jsch-0.1.50.jar:na]
	at org.eclipse.jgit.transport.JschConfigSessionFactory.getSession(JschConfigSessionFactory.java:116) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar:<IP_ADDRESS>412180710-r]
	at org.eclipse.jgit.transport.SshTransport.getSession(SshTransport.java:136) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar:<IP_ADDRESS>412180710-r]
	at org.eclipse.jgit.transport.TransportGitSsh$SshFetchConnection.<init>(TransportGitSsh.java:262) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar:<IP_ADDRESS>412180710-r]
	at org.eclipse.jgit.transport.TransportGitSsh.openFetch(TransportGitSsh.java:161) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar:<IP_ADDRESS>412180710-r]
	at org.eclipse.jgit.transport.FetchProcess.executeImp(FetchProcess.java:136) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar:<IP_ADDRESS>412180710-r]
	at org.eclipse.jgit.transport.FetchProcess.execute(FetchProcess.java:122) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar:<IP_ADDRESS>412180710-r]
	at org.eclipse.jgit.transport.Transport.fetch(Transport.java:1115) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar:<IP_ADDRESS>412180710-r]
	at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:130) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar:<IP_ADDRESS>412180710-r]
	at org.eclipse.jgit.api.CloneCommand.fetch(CloneCommand.java:178) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar:<IP_ADDRESS>412180710-r]
	at org.eclipse.jgit.api.CloneCommand.call(CloneCommand.java:125) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar:<IP_ADDRESS>412180710-r]

JGit hasn't realized that the year is 2017 and still use a mailing list to report bugs which is more time than I'm willing to spend (do they also use Yahoo chat for Dev communication?). Thus, I think, Spring Cloud should document this clearly and also suggest a fix. The fix is to remove any existing entries from known_hosts that's using ecdsa-sha2-nistp256 for the Git server and put in a new entry in ssh-rsa format by running the command below:
ssh-keyscan -t rsa GIT_SERVER >> ~/.ssh/known_hosts

@asarkar aren't both points already called out in the documentation?

If you don’t use HTTPS and user credentials, SSH should also work out of the box when you store keys in the default directories (~/.ssh) and the uri points to an SSH location, e.g. "git@github.com:configuration/cloud-configuration". It is important that all keys in ~/.ssh/known_hosts are in "ssh-rsa" format. The new "ecdsa-sha2-nistp256" format is NOT supported.

Are there some changes you think we should make to this?  If so would you like to submit a PR for them?

@ryanjbaxter I think the section you quoted specifies the format of the keys but doesn't say that those must be present in the known_hosts file, or if there is a way to bypass this; perhaps there is a property you can set to automatically accept the key; it won't be the most secure system, but less hassle for Dev. For a cmd line ssh client, having the key previously present in the known_hosts file is not a requirement; the clients asks you when you attempt to make a connection to a new server. This can even be bypassed by passing oStrictHostKeyChecking=no.
NPE is not acceptable in any case because then the user, me, has to debug someone else's code to find out what they're looking for. Throwing an exception with a relevant error message is ok too.

@ryanjbaxter I think the section you quoted specifies the format of the keys but doesn't say that those must be present in the known_hosts file

I think that is what is being said in this sentence.

It is important that all keys in ~/.ssh/known_hosts are in "ssh-rsa" format.

Perhaps it could be stated more explicitly?
I agree that the NPE is not very dev friendly but it is not Spring Cloud that is throwing the NPE it is JGit (at least that is what I can see from the stack trace you provided), so I am not so sure what we can do about it.  If you think that the documentation can be enhanced to help out, we are open to suggestions.

@ryanjbaxter I'll submit a PR.

https://github.com/spring-cloud/spring-cloud-config/pull/632

Resolved via #632 ?

@izeye yes
@asarkar for future reference, if in the description of your PR you say something like "Fixes #"  GitHub will automatically close the issue when the PR is merged.


ssl.SSLError: [SSL: HTTP_REQUEST] http request (_ssl.c:2635)

I have installed all dependencies and run the server, but when the server receives a request, it throws an error ssl.SSLError: [SSL: HTTP_REQUEST] http request (_ssl.c:2635).
I executed the command openssl req -x509 -newkey rsa:4096 -nodes -out cert.pem -keyout key.pem -days 365  to generate a self-signed certificate and it created two files cert.pem and key.pem in the current directory. Is there any impact if I fill in the values arbitrarily when setting them?

If you are testing it on your local machine, it will not have any impact with the self-assigned certificate and you should have access with no problem. If you want to make it public, then it is better to use a real certificate.


Add functions to add and refresh scores

In this branch, I implemented the following functions:

A function to add names and scores to the api.
A function to get names and scores from the api and display to the dom
A function to refresh the page

I'm sorry but what you're asking me to do is not clear. This to-do list is different from this project. What folder are you asking me to clone to?
Sent from Yahoo Mail on Android
On Thu, Feb 9, 2023 at 1:21 PM, Juliana @.***> wrote:
@julie-ify requested changes on this pull request.
Hi @Divinity-dev,
Good job so far!
Highlights!

Good feature branch name ✔
No linter errors ✔
Descriptive pull request ✔
Descriptive commit messages ✔
Good code organization and working app ✔
Descriptive README ✔

Hello ✋ , you have done well reaching this point of the milestone 🤝 . But there are some issues that you still need to work on to go to the next project but you are almost there!
Status: Required Changes ♻ ⛔

Kindly provide the correct for cloning the repo. I don't think we are using todo list link here.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread and tag me @julie-ify if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Thank you.
Sent from Yahoo Mail on Android
On Thu, Feb 9, 2023 at 1:55 PM, Abdelmejid Oumer @.***> wrote:
@amejid approved this pull request.
Hi @Divinity-dev,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights

Linter checks passing ✔
API functionality working as expected ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In README.md:

@@ -101,7 +101,7 @@ Clone this repository to your desired folder:

  cd my-folder
-  git clone https://github.com/Divinity-dev/To-do-list.git
+  git clone https://github.com/Divinity-dev/Leaderboard

[OPTIONAL] I highly suggest you remove the lines starting with > Describe... from your README file to make it professional. They are just instructions on what to do there. 🥸

Example

[OPTIONAL] I think it would be great to add content to the FAQ section or remove it completely since it is an optional section. 😎

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


SearchPreview filters are not connected in the UI

Tell us where you are using Dejavu (Hosted web app, Chrome extension, Docker Image, Within appbase.io)
Chrome extension
What is the version of Dejavu that you are using?
2.0.5
Describe the issue that you are seeing, or the feature request :-), include any screenshots as necessary.
Using the SearchPreview tab, define several filters and enable the Count for each record. When selecting a value, it would be extremely helpful for all other filters to update the count of their records based on the filter already selected
If your issue deals with accessing Elasticsearch cluster, share the necessary steps to replicate the behavior (the configuration.yml settings, where your ES cluster is hosted, any relevant logs).
If your issue deals with a UI issue, share with us a screenshot of the failing network request or the browser console log showing the error.

@ilulir We don't want to include this as a default behavior in the Search Preview UI as it triggers extra queries, and can cause a rate limit error (when using multiple facets) on freely hosted appbase.io apps.
However, this can be done when you export the code to Codesandbox as the underlying library that is used for Search Preview supports this via the react prop. You can also do so much more. :-)
Hope this helps!

What about updating the filter counts after a search is executed?
Currently, whenever I perform a search, the filter option numbers don't get updated, which kind of renders the filters useless.
Now, it does not really need a lot of extra queries, it just needs to add some aggregations on the main query.


Hotfix develop - Fix Sass syntax issue with clean-import-paths rule

clean-import-paths doesn't work with Sass syntax. This fixes that issue.
Fixes #179
DCO 1.1 Signed-off-by: Ben Griffith<EMAIL_ADDRESS>

Blocked by #205 - must merge first.

No longer blocked.

:+1:


Fix typo in builder/dispatchers.go

Signed-off-by: David Calavera<EMAIL_ADDRESS>

LGTM

LGTM


Ship PS module within tasks

After the problem with https://www.powershellgallery.com/ it is worth look into the possibility to include the Episerver deployment API module into the tasks.

#79


hubCallback method not working in flutter android and .net signalr2

I am having some problems getting the hub callback method to trigger in flutter.
I am able to connect to the signalr server and send a message to the server, but on the broadcastMessage it does not hit the flutter client hubcallback.
Please see my code below.
Flutter / Android:
Future<void> initPlatformState() async {
    signalR = SignalR(
        "ServerURL",
        "ChatHub",
        hubMethods: ["broadcastMessage"],
        statusChangeCallback: _onStatusChange,
        hubCallback: _onNewMessage);
  }

_onNewMessage(String? methodName, dynamic message) {
    print('MethodName = $methodName, Message = $message');
  }

_buttonTapped() async {
    await signalR.invokeMethod("Send", arguments: <dynamic>["Name", "Message"]).catchError((error) {
      print(error.toString());
    });
  }

ChatHub Server :
using Microsoft.AspNet.SignalR;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using System.Web;

namespace SignalRChat
{
    public class ChatHub : Hub
    {
        public void Send(string name, string message)
        {
            // Call the broadcastMessage method to update clients.
            Clients.All.broadcastMessage(name, message);
        }
    }
}

I also have the same problem, do you have a solution? @Zafoid

I also have the same problem, but everything is normal in the debug environment, and the release version received hubCallback @AyonAB @Zafoid @rsyd29 @mohas


Support for company fields in tracking code pageview event

https://github.com/mautic/mautic/pull/5611

Hehe, you fixed the first issue before I submitted the comment, but the second still stands.


scope values can't be seen in modal div

Hi. I'm trying to add my parent controller's scope value inside my modal div but it just wouldn't show. Any ideas?
HMTL

    ...

{{project.name}}

    <project-modal></project-modal>

    ...

I'm a bit new to Angular and  might have missed something.

Could you make an example like on a codepen on something of the kind?

Hey.
I'm having the same issue. Scope value fails to display after init.
Here's codepen: http://codepen.io/anon/pen/VvGwpg
I don't see any errors in Console. I tried some tricks, like changing value after render, but it doesn't seem to work.

The above commit fixes @kdembler issue. But I'm not sure whether or not it fixes the original issue.

Closed for now, if the above commit didn't fix the issue, then I'll re-open it.


update babel, babel-core, esprima-fb

I thought stuff would be broken but I guess not?

Shouldn't be broken, thank you!


swift-pons

swift-pons - Protocol-Oriented Number System in Pure Swift :large_orange_diamond:
Is this under Math?

Math makes sense

thanks, @vsouza!


[T6A3][W13-C2] Li Wanghuan

Do not finish. Still working

Avoid accumulating unrelated changes into a single PR.
Tip: If you are currently on branch1 and want to create a new branch2, you need to switch back to master branch before creating branch2. If not, changes in branch1 will appear in the PR created from branch2 later.

@liwanghuan
Some comments added. Please ack & close the PR after reading comments.


use of DNS query ID in connection map key is probably going to lead to issues

DNS ID is a 16 bit value.  In large environments this may not be enough space to prevent collisions.  We split the traffic up over an arbitrary number of goroutines, so a simple fix is to spin up more goroutines such that each routine gets fewer values and lowers the chances of collision.  A long term solution probably involves adding some other items to the map key.

This issue should be closed, the query id was fixed by @artyomtkachenko


Remove have_enqueued_jobs matcher

Matcher is pointless given that you can do...
expect(AwesomeJob).to have(1).jobs
# or
expect(AwesomeJob).to have(1).enqueued.jobs

Remove, or ideally keep with a message telling people to use the other syntax

have doesn't work anymore for Rspec 3.2, what do you recommend using instead?

Never mind, I just used
expect(DaWorker.jobs.size).to eq(5)


RFC; Promote coffee-script as peerDependency in scripts

At present quite a lot of hubot-* plugins list one coffee-script version or another as a dependency. Of those, many are specifing the same version that hubot itself depends on, and thus it should only been needed for testing and should probably be in devDependencies.
Some scripts however require more recent versions of coffee-script for various reasons, by listing it in peerDependencies rather than dependencies we get the benefit of npm detecting conflicting scripts at install time rather than waiting for everything to explode when bin/hubot gets executed.
Given that coffee-script isn't in the script template's _package.json at all (and doesn't need to be) I'm not sure what the best approch here would be (assuming this all makes sense).
One possibility is porting #27 over to allow optionally specifing the coffee-script version at app creation time, at which point we have the generator write it into peerDependencies as part of the generation. The only problem I forsee with this is that it might not be apparent at creation time that a newer version than 1.6.3 might be required. To combat this a sane default for new scripts might be ^1.6.3.
This could potentially lead to some weirdness where a peerDependencies conflict should have arisen but a package erroneously lists the version constraint as ^1.6.3 while in reality requiring a more recent minimum version. My hope is that with some clear documentation it should be a relatively trivial fix (update package.json so next time it will conflict and warn the end user about incompatible scripts at install time).
Hope all that makes some semblance of sense, look forward to hearing your thoughts!

I think this is line with my thinking, thanks for putting it together!
I had some concerns about peerDependencies is I've seen references to it going away, but I was just reading https://github.com/npm/npm/issues/6565 that it's less being deprecated, as the behavior being changed.

Reading that, it sounds like the "correct" way to do this would be to end up with a tree that looks like this:
<EMAIL_ADDRESS>/home/mal/code/mybot
├─┬<EMAIL_ADDRESS>│ └── dependencies (not coffee-script)
├─┬<EMAIL_ADDRESS>│ └── dependencies (not coffee-script)
├─┬<EMAIL_ADDRESS>│ └── dependencies (not coffee-script)
└──<EMAIL_ADDRESS>

package
dependency
peerDependency

mybot
coffee-script@*
none

hubot
none
<EMAIL_ADDRESS>

hubot-example
none
coffee-script@*

hubot-wants-fresh-coffee
none
<EMAIL_ADDRESS>

Which leaves the app to install coffee-script but the current version of hubot and the installed plugins restrict which version that is by adding their various requirements as peerDependencies such that the version that actually gets installed satisfies all parties.
I also brought over your suggestion from #27 about leaving the default coffee-script requirement as a wildcard, as that makes a lot of sense given that hubot and other more fussy plugins can then whittle that down into whatever they agree upon.
Obviously this would require changes to hubot in addition to the generator changes. A few scripts might require a small update to move from a direct dependency on coffee-script to a peerDependency, but my suspicion is that that number will be relatively low given that it doesn't seem to have been well known that it was possible to use a version above 1.6.3 until recently.

It occurs to me that the wildcard could be problematic in certain situations; for instance:

Install plugin that uses 1.9.x feature yet specifies wildcard
Install plugin that explicitly peerDepends on 1.7.x

This would result in breaking the first plugin only when a correctly versioned legacy plugin was installed. I'm uncertain of the best way to catch this besides running tests against all coffee versions ^1.6.3 and up when the peerDependency is a wildcard and if any fail encouraging the author to correct it.
The problem with this is that it significantly raises the bar on getting into plugin writing. Indeed many current plugins lack tests and they may never have been run.

After letting it stew for a while, it occured to me that all of this is only truely necessary if hubot continues to hard lock the coffee-script version. Without that lock all new and reinstalls of hubots would upgrade to the latest version of coffee-script. Since we'd keep the major version lock, this would avoid breaking changes (I know 1.9 had one, but it looks to be relatively minor, so long as they don't do it again).
Without breaking changes, any scripts (and indeed hubot itself) should "just work" on the latest version of coffee.
This would then re-orient this RFC toward whether coffee-script should be in the devDependencies of the script template for testing, or if it should simply remain ommited entirely.

As an aside, it feels weird that we didn't see this sooner, but it's also entirely possible my brain forgot the reason why the hubot lock on coffee-script can't be released ... :frowning:

Have continued mulling this over and gone over the various threads on the topic again (#27, #6, github/hubot#863, github/hubot#770 and #11). I see two options based on the various suggestions and ideas put forward:

NOTE: The 1.7.1 used below could be anything that matches ^1.7.0 (it simply has to be after the registration changed happened (1.7.0) to make life easy when running tests.
A

hubot removes from explicit dependency on<EMAIL_ADDRESS>hubot adds<EMAIL_ADDRESS>to devDependencies (for testing)
hubot adds<EMAIL_ADDRESS>to peerDependencies (for running)
generator app adds coffee-script@* to dependencies (npm v3 compat)
generator script adds<EMAIL_ADDRESS>to devDependencies (for testing)
generator script adds<EMAIL_ADDRESS>to peerDependencies (for running)

B

hubot bumps lock from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>Leave the app generator as is; no dependency on coffee-script
Add<EMAIL_ADDRESS>to devDependencies in the script generator

Pros (A)

It ensures only one version of coffee-script gets installed
It lets npm deal with finding common ground between hubot and plugins on which coffee-script to use.
It leverages peerDependencies correctly in an npm v3 world

Cons (A)

If a script requires a different version of coffee-script both dev and peer deps need updating...

...but still only as bad as the current<EMAIL_ADDRESS>dep

Pros (B)

Less changes

Cons (B)

Multiple versions of coffee-script installed

Last script to be installed gets it's version of coffee-script used (unpredictable, as current)

Not clear that script needs a non-dev dep adding to use a never version outside of tests

Both approaches will require that the version specified by hubot and the script generator stay in sync going forward, but I see no way to avoid that since new scripts should be testing against whatever hubot is currently requiring. However this should be palatable as the only reason I can forsee for another version change is a major bump of coffee-script which will require more work than just this anyway.
FWIW I personally much prefer A based upon the P&C lists.

Secret Option C
Another option could be to alter the Gruntfile build/release process to precompile all .coffee files before pubishing to npm, this way everything would be plain old Javascript and we just bypass the whole coffee-script/peerDependencies nightmare.

Given the feedback provided in npm/npm#7569 it would seem to me that A is the way to go. It offers the most flexibilty while ensuring compatability between hubot and installed scripts, and also that the version of coffee-script is idempotent (rather than just the version used by whatever script happens to be last in package.json).
@technicalpickles if that makes sense to you, I'd be happy to cook up some pull requests for the outlined changes?

This seems like a very bad idea. What exactly is wrong with having multiple CoffeeScript versions installed? Hubot modules should directly declare their dependencies in package.json instead of relying on an implicit global dependency in Hubot core - this'll only lead to version hell which npm is designed on purpose to prevent.

As a concrete example changes like #86 or even just bumping the coffee-script version - this will create all sorts of breakage outside of Hubot core, which is where it should stay. See also http://module.party/

There's nothing wrong per se with having multiple coffeescript versions installed. The problem is that at some point, one coffee executable is run:

bin/hubot (generated from this repo) calls bin/hubot (from github/hubot)
bin/hubot from github/hubot has #!/usr/bin/env coffee

hubot relies on coffee-script having been required, which makes it possible to require coffee files. Many hubot packages are just coffee script files, rather than transpiled javascript.
If there are incompatibilities with the version of coffee script you run in your instance of hubot, and a package you depend on that are .coffee rather than transpiled, then you are going to have problems. I believe that peerDependency at least solves that problem.
A better, longer term solution would be encouraging script  packages to transpile to javascript, but that is a bigger thing.

Ah right. That makes sense, thanks.
I guess this issue is more of a bandaid then - the long-term solution being getting module authors to transpile their stuff.


fix dictionary cannot be sorted after inserting some null values

Proposed changes
Issue Number: close #xxx
Problem summary
coredump:
#0  0x000055cf7bf6a1b8 in doris::vectorized::ColumnDictionary<int>::Dictionary::convert_code (code=@0x7f92ea19e098: 0, this=0x7f92ea117220) at /root/doris-1.2.1-rc01/be/src/vec/columns/column_dictionary.h:442
#1  doris::vectorized::ColumnDictionary<int>::convert_dict_codes_if_necessary (this=<optimized out>) at /root/doris-1.2.1-rc01/be/src/vec/columns/column_dictionary.h:250
#2  doris::vectorized::ColumnDictionary<int>::convert_dict_codes_if_necessary (this=0x7f92ea117200) at /root/doris-1.2.1-rc01/be/src/vec/columns/column_dictionary.h:242
#3  0x000055cf7c433a20 in doris::segment_v2::SegmentIterator::_convert_dict_code_for_predicate_if_necessary (this=this@entry=0x7f92ea11fc00) at /root/doris-1.2.1-rc01/be/src/olap/rowset/segment_v2/segment_iterator.cpp:1249
#4  0x000055cf7c43edca in doris::segment_v2::SegmentIterator::next_batch (this=0x7f92ea11fc00, block=<optimized out>) at /root/doris-1.2.1-rc01/be/src/olap/rowset/segment_v2/segment_iterator.cpp:1164
#5  0x000055cf7c7271da in doris::BetaRowsetReader::next_block (this=0x7f9178a83c00, block=0x7f91780da800) at /root/doris-1.2.1-rc01/be/src/olap/rowset/beta_rowset_reader.cpp:277
#6  0x000055cf8004af81 in doris::vectorized::VCollectIterator::Level0Iterator::next (this=0x7f92ea1001c0, block=0x7f91780da800) at /root/doris-1.2.1-rc01/be/src/vec/olap/vcollect_iterator.cpp:267
#7  0x000055cf8004a749 in doris::vectorized::VCollectIterator::Level1Iterator::_normal_next (this=0x7f92ea100260, block=0x7f91780da800) at /root/doris-1.2.1-rc01/be/src/vec/olap/vcollect_iterator.cpp:533
#8  0x000055cf8004ca6e in doris::vectorized::VCollectIterator::Level1Iterator::next (this=<optimized out>, block=<optimized out>) at /root/doris-1.2.1-rc01/be/src/vec/olap/vcollect_iterator.cpp:359
#9  0x000055cf80049d5a in doris::vectorized::VCollectIterator::next (this=this@entry=0x7f9178a7f1b8, block=<optimized out>) at /root/doris-1.2.1-rc01/be/src/vec/olap/vcollect_iterator.cpp:187
#10 0x000055cf80041395 in doris::vectorized::BlockReader::_direct_next_block (this=0x7f9178a7ee00, block=<optimized out>, mem_pool=<optimized out>, agg_pool=<optimized out>, eof=0x7f92f5ff65b6) at /root/doris-1.2.1-rc01/be/src/vec/olap/block_reader.cpp:167
#11 0x000055cf80047279 in doris::vectorized::BlockReader::next_block_with_aggregation (this=<optimized out>, block=<optimized out>, mem_pool=<optimized out>, agg_pool=<optimized out>, eof=<optimized out>) at /root/doris-1.2.1-rc01/be/src/vec/olap/block_reader.h:45
#12 0x000055cf8024302d in doris::vectorized::NewOlapScanner::_get_block_impl (this=0x7f9178a74c00, state=<optimized out>, block=0x7f91780da800, eof=0x7f92f5ff65b6) at /var/local/ldb-toolchain/include/c++/11/bits/unique_ptr.h:173
#13 0x000055cf80224f13 in doris::vectorized::VScanner::get_block (this=this@entry=0x7f9178a74c00, state=state@entry=0x7f93393fe300, block=block@entry=0x7f91780da800, eof=eof@entry=0x7f92f5ff65b6) at /root/doris-1.2.1-rc01/be/src/vec/exec/scan/vscanner.cpp:53
#14 0x000055cf8022239f in doris::vectorized::ScannerScheduler::_scanner_scan (this=<optimized out>, scheduler=<optimized out>, ctx=0x7f9178bb6800, scanner=0x7f9178a74c00) at /root/doris-1.2.1-rc01/be/src/vec/exec/scan/scanner_scheduler.cpp:234
#15 0x000055cf7ca75805 in std::function<void ()>::operator()() const (this=<optimized out>) at /var/local/ldb-toolchain/include/c++/11/bits/std_function.h:560
#16 doris::FunctionRunnable::run (this=<optimized out>) at /root/doris-1.2.1-rc01/be/src/util/threadpool.cpp:45
#17 doris::ThreadPool::dispatch_thread (this=0x7f9338457400) at /root/doris-1.2.1-rc01/be/src/util/threadpool.cpp:534
#18 0x000055cf7ca6bbef in std::function<void ()>::operator()() const (this=0x7f9337edd478) at /var/local/ldb-toolchain/include/c++/11/bits/std_function.h:560
#19 doris::Thread::supervise_thread (arg=0x7f9337edd460) at /root/doris-1.2.1-rc01/be/src/util/thread.cpp:454
#20 0x00007f93543d6ea5 in __pthread_mutex_unlock_full () from /lib64/libpthread.so.0
#21 0x0000000000000000 in ?? ()

Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.96 seconds
load time: 494 seconds
storage size:<PHONE_NUMBER>7 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230111131433_clickbench_pr_77790.html

Could you add a regression test?

Hi @dataroaring , I have added a case.


add simple example to readme

i have to read all the readme to write a simplest countdown. I think this example will be good for guys like me who see countdown.js for first time

hello?

How is that much different than the one already in the readme?
var timerId =
  countdown(
    new Date(),
    function(ts) {
      document.getElementById('pageTimer').innerHTML = ts.toHTML("strong");
    },
    countdown.HOURS|countdown.MINUTES|countdown.SECONDS);


Correct link to boot2docker vhost-proxy

The information about vhost-proxy seems to have moved to a separate file within the boot2docker project.

Thanks!


Fix GoDoc link in docs

Description of changes: Fix the casing for the GoDoc link, so it points to the correct API on the page.
Also updated the README to work with the structure assumed by the configuration file.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


chore(deps): upgrade dependencies

Description

chore(deps): upgrade dependencies

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[ ] Roll Forward
[X] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Timeout Triggered

Hi there,
I just came by to take a look at what all the fuss of Rust is about. I saw the website had a "Try Rust" thing which was nice. All I did was hit "Run" and it didn't seem to work. Is this expected behavior? Kind of off-putting

So, this does run code dynamically, so if the playpen is down, this can happen. /cc @alexcrichton

Ah yeah this is just an intermittent error, so closing.


Update stub placeholders for Laravel 5.1

The latest version of Laravel 5.1 changed the placeholders to be more PSR2 friendly.
{{class}} is now DummyClass
{{table}} is now DummyTable.
This fixes the bug whereby the sluggable:table command would not be able to do all str_replace actions.

I didn't update the use of {{column}} as I wasn't sure if that would impact anything currently in development.  If you'd prefer the entire stub (and str_replace in SluggableMigrationCreator) changed as a single patch let me know and I'll bundle it all up into one PR.

This is great. Yeah, go ahead and update the {{column}} usage as well.  Add it to this MR, and I'll M it all.
Thanks!

Any update on this?

I made the extra changes on the same day and updated the PR with all tests passing.
I see now it's showing a potential branch conflict though.  Please let me know if you needed me to do anything further.

I pushed a few other changes yesterday, so if you just rebase your branch off of master you should be good to go.
(Likely, the conflicts are because I converted the entire code-base to PSR-2, so all the tab indents are spaces now.  Github can't handle that kind of merge easily.  In fact, since your PR changes are pretty small, you're probably best off just pulling down master, rebranching and re-doing your changes, and pushing that PR instead.)


prevent Bedrock placement

fixes #32

This pull request is closed until the restructuring of the code base is done. Furthermore Protocol::IsValidBlock is not intended to be used in the way I did use it: It only checks if a block exists in the Protocol, not if it's a "good" or "bad" block.


Add DSU structure

I have verified leader and merge.
https://atcoder.jp/contests/practice2/submissions/51687201

Verification is incomplete


broken enchant:  block reach on mystical agriculture red armor breaks the flight aspect of it

Minecraft version & Mod Version:
1.12.2-1.15.8
Single player or Server:
single player
Describe problem (what you were doing / what happened):
using the enchant block reach on mystical agriculture red armor breaks the flight aspect of it
Crash log (if any):
doesnt crash
(If this is a suggestion and not a bug report, delete all this and just write your suggestion!)

Did you have anything in the charm slots?
When i tried with just basic red armor by itself it was working fine for me, both reach and flight:
https://imgur.com/a/aP8NoDp

nope nothing in the slots but for me block reach broke the armor hmm

Charlie's Towny Pack-1.9.zip
heres my "current" version of my modpack if u wanna test on that cause for all i know either its something else in the pack or on mystical agricultres end that might be broken but i dont know hmm

Ill import it tomorrow and see what happens

What other mods add custom survival flight in there? Does draconic have something that gives flight? or aether legacy?

draconic has the draconic armor (orange) for flight and as for aether legacy umm idk if it adds flight lol

https://vignette.wikia.nocookie.net/mlp/images/c/c5/Phoenix_wright_hold_it.png/revision/latest?cb=20130324182312
[hold it!]
aether adds it's own form of attack range reach and block reach through valkyrie tools.
and fancy that I've actually just discovered that having had used block reach on a piece of armor just completely overwrote and broke the attack range for my valk tools and also for my botania pride ring.
They had been working just prior to enchanting a diamond chestplate with reach and putting it on. The Cyclic reach is massive and I had previously thought it was the combination of my reach and the pride ring reach. But upon taking off reach and just equipping the pride ring, I found the ring no longer worked. and neither did the reach on the valkyrie tools in aether, nor the recently added reach tinker tool buff from aether tinkers valkyrie modifier.
Dieing didn't fix this for me.
so it appears your enchant might be messing with everyone elses. however interestingly the valkyrie lance doesn't seem to have issue with it's attack range so it must be built into the item or something.
I also had actually went to report the pride ring not giving me attack range, and when doing some science this is when I had noticed it. heres the issue I had just posted before my realization.
https://github.com/Vazkii/Botania/issues/2660

latest.log
as requested and from wat i could tell nothing to even give any hints

I just tested with Cyclic 1.17.2, Mystical 1.6.13 and forge <IP_ADDRESS>60.
Full set of red armor gives me flight. block reach is enchanted on it, both reach and flight working for me.  which was the original report at the top.
As for the other piece, yes it looks like if more than one mod messes with player reach then forge cant handle it gracefully ( im not sure how to make them compatible i guess they arent, its not like hearts or armor).  Thank you very much for the log file.
Also it looks like #870 linked to this and might resolve this partially.
Only solution here is to configure the modpack to remove all "reach" abilities except one, doesnt matter which.  Then players should not have issues.  Cyclic enchant is easy to disable in config file.
For now i will mark this as resolved and closed .  new issues are always welcome !


Roll Flutter Engine from 2be41c6d0152 to 3173b09e1875 (2 revisions)

https://github.com/flutter/engine/compare/2be41c6d0152...3173b09e1875
2023-03-03<EMAIL_ADDRESS>Roll Skia from a0ab1e734490 to d953c63dd96b (9 revisions) (flutter/engine#40035)
2023-03-02<EMAIL_ADDRESS>Remove PlatformConfiguration and ViewConfiguration (flutter/engine#40012)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Prevent function scrollbar from obscuring expand button

Fixes #2955
Gives the expand button in the Function node code editor a higher z-index then the text area so it appears over the top of the scrollbar.

Coverage remained the same at 67.389% when pulling c480f96d308a82fa52bbc24acccbf340bb321da6 on scrollbar-expand into 20dbf7c5f4b59f9b33f5f309bec49e97920208ae on master.


Epsxe 2.0 Not Working w/ RegEmu32

^Title.

ePSXe 2.0 ?! =O

https://www.youtube.com/watch?v=P3ALwKeSEYs

Done, give it a try.
About Pokopom, it's possible a plugin bug (might affect pcsxr too). But, I cannot fix Pokopom bugs as my source is messed up with yet another pokopom rewrite...

oh ok. pokopom worked great for me with tapcios hack in the previous epsxe though. brb, trying new update.

Yes, it's the v0.1-28 one. Note that for some reason, the zip files had v0.2... which was wrong.

Ok, cool. It works now. But I don't see the dialgue for it anymore in the cmd window. Is that intentional? Also, in the ini, I don't see the changed values with the new plugins and new options and what not. I just see the old options and what is shown in the emu and how you have it set up, is not reflecting what is in the regemu32.ini.

I replaced the patcher some time ago. It's a very simple one now, but very fast.
I just tested ePSXe 2.0 and it seems to be working fine. Without an INI file, it will show the setup guide and once that's done you'll have all the basic settings. Mess with the video settings and that section will show up in the INI file too.

Ok, but I don't see the mention of the plugins i have running. I have petesgpu2.9 2.0 in but it still shows "VideoPlugin"="gpuPeteOpenGL2Tweak.dll"
I have my ff9 memory card in the first slot with the 2nd slot disabled and it's still showing me this:
"Memcard1"="E:\Users\T Dean Jr\My Documents\Games\CONSOLE\EMULATORS\SONY\Playstation\Playstation\memcards\Final Fantasy Anthology.mcr"
"Memcard1Enable"="1"
"Memcard2"="E:\Users\T Dean Jr\My Documents\Games\CONSOLE\EMULATORS\SONY\Playstation\Playstation\memcards\Final Fantasy VII pt-2.mcr"
"Memcard2Enable"="1"
So that means most settings are still going right to the real registry (unless they have an ini somewhere that stores info locally now).

It's possible that you might have unpatched the exe. Delete the INI file and make sure a new one is created when you run the emu. If not, patch and try again.

Ok. I deleted the ini. I deleted the exe of epsxe and patched it again and replaced. When I open up epsxe, all my settings are still the same (the way I want them). When I close epsxe, the regemu32.ini forms, but when I open it, it's blank. But epsxe still works and has all my settings as I want them. First start dialogue doesn't happen again either.

Try with these files: TEST

Ok, works. What different did you do than I?
I tried dropping the exe into regemu and I tried running the exe of the regemu :P

Those are cleanly downloaded files, with the exe patched. I patched it by dropping ePSXe.exe into Regemu.exe. If you do that a second time however, it will get unpatched.

Ok, cool. Thanks.

If the application complains about missing functions, just make an issue. But sometimes all the registry lines are made during installation and the game just reads them, making the ini with the proper entries would be up to the user.

So I just tried it again by myself and only dropped the fresh exe in once. Still blank ini. What directory do you have it in? I think it may be a long director / directory space issue because it isn't working right when I do it mayself in my current directory I have it in.

You can confirm that by trying again in a short directory path with no spaces.

I tried it just on the root of the c drive. Nothing happening when I patch it and start epsxe. Old versions did work on things without issue. I dunno what's going on now.

Make a folder on C called test (root might require admin rights) and copy the exe and the patcher there. Open a console window to that folder and use the patcher from there.

Just to leave the points of what I did for the zip I gave you.

Download ePSXe and Regemu again.
Extract ePSXe.
Extract Regemu into ePSXe's folder.
Drag ePSXe.exe into Regemu.exe.

I suppose I could make CRC checks after extraction and after patch. Then you can compare with what you're getting. Somehow, something's not working properly in  your end and I cannot reproduce it.

so the whole process has to take place in epsxe's folder? I've just been extracting the emu exe, regemu dll, and regemu exe into a newly created folder and dragging it in the the regemu exe from there.

No, it doesn't have to. But I've detailed the process of what I did so you can try and reproduce the results. I've done it again and added the CRCs so that you can compare them.

all of the crcs are as you wrote them. viewed them from a winrar archive. after patched, the epsxe exe retains the same crc. so for some reason the program isn't patching. maybe the dialogue was a good idea to see what was going on. Here's a video proving that I did it like I was supposed to:
https://youtu.be/DnI6W8242V0

lol, all you did was right. I am concerned with the popup asking for authorization though.
Anyhow, try and do the same but instead of drag and drop use the console/terminal. You'll get the feedback from the program to tell you if something was patched or not. Also, try from a normal terminal and from a terminal with admin rights.
In the mean time, I'll see about giving you a build of the patcher with plenty of them dialogs.

That popup usually happens when I get a file from someone else's computer. That's normal.
I dragged teh regemu.exe on to epsxe.exe instead and all it did was start the emulator.
If I start as admin the regemu.exe, a console appears and then quickly disappears. Does the same as if I start it without admin rights.

I think I found the bug. Rename the folder where you extracted Regemu to ASD or something else. Make sure it doesn't have Regemu in its name.

Yep, changing the folder name makes it work.

New version uploaded. See if this one works please.

Ok, it works now with the program name as the folder.

Yay! Thanks for all the testing.

np glad you figured it out!


Pr 740 followups

This is #740 from @gavingmiller squashed into one commit and then with some additional changes add on top to wrap that work item up.
This partially addresses #611 and rspec/rspec-mocks#898.
Can someone from @rspec/rspec review this before we merge?

LGTM

And me, merge when green!


update Depth Meter for world height changes

Depth Meter uses player coords + configurable offsets instead of layer + section data to calculate the virtual depth of the player in the Abyss. The Depth reading is given in minecraft blocks, not corresponding to canon depth.

Can you explain to me a bit about WorldGuard? Like what it does/can do and why we want to depend on it?
Also, are you saying 'dont fix the depth meter until we fix WorldGuard' or 'you can fix it now, but I'd like to change it to depend on WorldGuard in the future'

if this makes any sense lol
Issue with depth meter rn is that DW defines a section as the cube you are in.
With WG regions we can split that cube into more than one section, meaning depth meter will show accurate layer info and depth (still canon but thats cuz MiA config says that it should)

build is down so I can't easily check when the actual transition is between Edge and Forest, so lets say that its at a depth of 1000.
name: §x§D§B§4§0§4§0Edge of the Abyss
    sub: §x§B§A§1§E§1§E0-1350 meters
    deathMessage: at the §x§D§B§4§0§4§0Edge of the Abyss§f :redw:§f
    depth:
      start: 0
      end: 1000

In AbyssLocationAction.kt, layer = player.location.section.layer . If I just change the start and end depths in the config, will player.location.section.layer correctly give the right layer, or do we need to update how each section knows what layer(s) it's on as well (with WG or whatever)

If i got dero right, all it would do is let us specify sections accurately and therefore layers aswell.  When DW uses WG regions instead of the system right now to define sections, it should all more or less be accurate. Right now, afaik, the only issues is with the depth not displaying correctly because you are over the threshold of said layer, therefore causing the jumps

naruhodo. So I'm waiting on worldguard regions

Yes, will probably still be issues with the old math for calculating etc. But hold of until then


Website broken on narrow screens

Content is hidden.

There should:

be test that the navbar is not wider than XXX.
logo should collapse on small screen. Svg can be responsive
be test that the navbar is not wider than XXX.
be test that the navbar is not wider than XXX.

@ellisonbg when are your summer student working ? Do you have a specific tag for thing you want them to work on ?

They start next week full time. Initially I am giving them medium sized
projects that will last about a week on JupyterLab and the website. This
will expand to cover the docs, ipywidgets and notebook as well. They are
initially spending a lot of time just learning as well...
On Mon, Jun 6, 2016 at 9:22 PM, Matthias Bussonnier <
<EMAIL_ADDRESS>wrote:

@ellisonbg https://github.com/ellisonbg when are your summer student
working ? Do you have a specific tag for thing you want them to work on ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/jupyter.github.io/issues/102#issuecomment-224171474,
or mute the thread
https://github.com/notifications/unsubscribe/AABr0P0N2Scm9Vi5hcfwTGmYTy2ultGOks5qJPIggaJpZM4Ivifo
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

What type of sphinx directive? In other words, what would it do?
On Wed, Jun 8, 2016 at 9:52 AM, Matthias Bussonnier <
<EMAIL_ADDRESS>wrote:

Great, feel free to ping me, I think we can do a better job this year if
we get early good habit.
We could need to write a custom Sphinx directive for the jupyter doc.
Would that be a "small" project ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/jupyter.github.io/issues/102#issuecomment-224654899,
or mute the thread
https://github.com/notifications/unsubscribe/AABr0Ahd8X3ryg0oCXiU15d5pTwNKMcRks5qJvNIgaJpZM4Ivifo
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

What type of sphinx directive? In other words, what would it do?

Hum, long to describe... in 2 words:
Take a yaml-like (or whatever) structure and render the content of this page, which right now is hardcodded as html which prevent cross-linking, force duplication of templates with 1 word change in all of them with jupyter-sphinx-themes, as well as a few other drawbacks.
If yes I can make a longer description.

Fernando, Carol, Jamie and I talked yesterday about some docs stuff.
@willingc is going to try to consolidate the build of our docs into a
single repo using git submodules - might solve some of these issues. But
yes, this type of thing might be within scope for the students eventually.
On Wed, Jun 8, 2016 at 10:02 AM, Matthias Bussonnier <
<EMAIL_ADDRESS>wrote:

What type of sphinx directive? In other words, what would it do?
Hum, long to describe... in 2 words:
Take a yaml-like (or whatever) structure and render the content of this
page http://jupyter.readthedocs.io/en/latest/, which right now is
hardcodded as html which prevent cross-linking, force duplication
https://github.com/jupyter/jupyter/tree/master/docs/source/_templates
of templates
https://github.com/jupyter/jupyter-sphinx-theme/tree/master/jupyter_sphinx_theme/jupyter
with 1 word change in all of them with jupyter-sphinx-themes, as well as a
few other drawbacks.
If yes I can make a longer description.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/jupyter.github.io/issues/102#issuecomment-224658651,
or mute the thread
https://github.com/notifications/unsubscribe/AABr0GHF-nwkn81mCSUkwsMjnGBbYhVrks5qJvXDgaJpZM4Ivifo
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Fernando, Carol, Jamie and I talked yesterday about some docs stuff.

is that somewhere ?

@willingc is going to try to consolidate the build of our docs into a
single repo using git submodules

I think subtree might be an alternative, and I'm a bit unsure why submodules.
Travis might be able to consolidate docs in one place though.

But
yes, this type of thing might be within scope for the students eventually.

Do you want me to (try to) make a longer description ?

Can you sync up with @willingc to see how her experiment with
subtrees/submobules relates to this?
On Wed, Jun 8, 2016 at 10:52 AM, Matthias Bussonnier <
<EMAIL_ADDRESS>wrote:

Fernando, Carol, Jamie and I talked yesterday about some docs stuff.
is that somewhere ?
@willingc https://github.com/willingc is going to try to consolidate
the build of our docs into a
single repo using git submodules
I think subtree might be an alternative, and I'm a bit unsure why
submodules.
Travis might be able to consolidate docs in one place though.
But
yes, this type of thing might be within scope for the students eventually.
Do you want me to (try to) make a longer description ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/jupyter.github.io/issues/102#issuecomment-224673624,
or mute the thread
https://github.com/notifications/unsubscribe/AABr0Hm1f9s81aBcnNrGze2Z_qSkyPLdks5qJwFHgaJpZM4Ivifo
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Sure.

@Carreau @ellisonbg I have started tagging some issues in different repos as sprint-friendly:calpoly. Most are docs issues for now but I'm curating issues for a SciPy sprint or the interns to work on as time permits.

@Carreau I assigned myself as well here as a reminder to sync up with you on alternative builds of the docs. Doing some research today and tomorrow of some of the large docs projects (sentry, mozilla, openstack, django) to see which use submodules or subtrees. If you have 30 minutes on Friday for a webchat, we can talk about what I find.

@Carreau This doesn't seem to be a problem anymore (I believe I made a fix earlier in the year). Are you still experiencing it? We are also going to be pushing a reworking of the navigation in the next few weeks.

No it's better it's still off when exactly at 768px width. You have another funky double transition at 991px -> 992px and 992px -> 993px, but that's in bootstrap.min.css so I doubt you can do anything about these. feel free to close.


Cleanup networkdb state when the network is deleted locally

Fixes https://github.com/docker/libnetwork/issues/1387
When a worker node doesn't have any more tasks on a network, the network gets deleted and the service db for that network also gets removed. When a task on that network starts again service records should be populated again. This wasn't happening correctly because the earlier state in the networkdb wasn't fully cleaned up. Changes to address this are..

cleanup the network db state when a network is removed on a node
while the network is in the going away state do not include the state for this network in the bulksync
also, do not process the table events coming from the peers for this network.

Signed-off-by: Santhosh Manohar<EMAIL_ADDRESS>

LGTM


The Sims 1 CTDs for Windows 8.1 users after 0.3.2

This did not occur before version 0.4.0. This was originally mentioned in https://github.com/FaithBeam/Sims-1-Complete-Collection-Widescreen-Patcher/issues/61.
I then tested Windows 8.1 to see if the issues @Gaerthal-Estelmist mentioned were related to it, and encountered the same crash to desktop with a variety of configs including CPU affinity, borderless vs exclusive mode, and DisplayResolution=app. I have not been able to reproduce the same crash on later Windows versions such as 11 which I personally use with no issues.
The DDC log lists no errors. The Sims error log is unhelpful and simply lists "access_violation" as the error.

Unfortunately, I don't have Windows 8.1 anymore, so I can't debug the issue on my end.
Please try to get a crash dump as described here: https://github.com/narzoul/DDrawCompat/issues/50#issuecomment-520162844
Also, enable debug logs by setting LogLevel=debug in DDrawCompat.ini, and attach the debug logs along with the crash dump.

Sims.exe.3032.dmp.zip
DDrawCompat-Sims.log
According to this post, the "dirty" version of 0.4.0 fixed it for Windows 7, but did not help here on 8.1.

DDrawCompat-Sims.log
Sims.exe.3724.dmp.zip

Thanks, I will test again when I get home in a couple of hours!

That worked! (low fps is just from running in VM.)
It needs CPUAffinity=all and especially AltTabFix=keepvidmem in order to be fully stable.

I don't get it. Why didn't it work with just the Windows 7 fix then? The debug log fix shouldn't be needed unless someone's running the game with LogLevel=debug, and that's the only other issue I fixed compared to the Win7 patch.

I don't get it. Why didn't it work with just the Windows 7 fix then? The debug log fix shouldn't be needed unless someone's running the game with LogLevel=debug, and that's the only other issue I fixed compared to the Win7 patch.

You asked me to enable the debug logs. Without that, the windows 7 fix only works.

Yes, but in one of your posts in the widescreen patch issue, you said that the Win7 patch didn't work on 8.1:

Interesting choice to upgrade to an even older version lol. Sadly that file did not fix the problem for 8.1.

Or did you also have debug logs enabled back then?

The Win 7/8 crashes are fixed in v0.5.0.


[csl] update CSL public APIs to use milliseconds unit for period

This commit updates public APIs for getting and setting CSL period to use milliseconds unit instead of the internal ten symbols unit. This makes the APIs easier to use.
The CSL APIs have been renamed to follow the otLinkGet/SetCsl{Item}() pattern, which is the common naming style of OpenThread. This renaming will make the APIs more consistent and avoid potential confusion with the now-removed APIs, which used a different unit for CSL period.
This commit also updates the related CLI CSL commands:

The csl period expects the given period to be in milliseconds.
The csl command (which outputs all CSL parameter) shows the CSL period in millisecond unit (e.g., "Period: 160ms").

The NCP spinel SPINEL_PROP_THREAD_CSL_PERIOD is also updated to use millisecond unit for CSL period.
The related test script are updated to use the new unit, in particular the test harness setCSLperiod() in harness-thci/OpenThread.py is updated (no need to convert from msec).
This commit also adds new helper methods to convert CSL period to and from milliseconds and the ten symbols unit. When converting between the two units, the value is rounded to the nearest integer. For example, if the CSL period is 212 in ten symbols unit, which maps to 212 * 0.160 = 33.92 milliseconds, the value of 34 milliseconds is returned. Or if the target CSL period is 23 milliseconds, the converted value will be 144 (in units of ten symbols) which maps to 144 * 0.160 = 23.04 milliseconds instead of 143 which maps to 22.88 milliseconds.

Have you considered switching the API to microseconds? Apart from allowing all possible CSL Period values we could get rid of the rounding methods by just allowing exact multiples of 10 symbols on the setter.

Thanks @edmont. I think this is a good idea.

Have you considered switching the API to microseconds? Apart from allowing all possible CSL Period values we could get rid of the rounding methods by just allowing exact multiples of 10 symbols on the setter.

Thanks @edmont. I think this is a good idea.

Submitted the PR below to use usec

https://github.com/openthread/openthread/pull/9285 which uses usec.

Closing this PR in favor of the new one.


feat: add a post_filter support

Q
A

Bug fix?
N

New feature?
Y

BC breaks?
N

Deprecations?
N

Fixed tickets
N

Add the post_filter support in the convertElasticsearchBody function.
I also discover the Simple query object which can simply convert an array into an Elastica query object. So I took the opportunity to refactor the convertElasticsearchBody function in order to avoir bool query with a single must sub-query

Nice pr! Indeed like the simpleQuery and also the removal of the deprecation


Clickable text

Assalamu Alaikum,
is there a way to make the text clickable like in this image

We haven't implemented it yet, it's in the roadmap.


[SPARK-34503][DOCS][FOLLOWUP] Document available codecs for event log compression

What changes were proposed in this pull request?
This PR is a follow-up of https://github.com/apache/spark/pull/31618 to document the available codecs for event log compression.
Why are the changes needed?
Documentation.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual.

cc @tgravescs

Thank you, @tgravescs and @viirya .

Test build #135612 has started for PR 31695 at commit 7ed1d8d.

Test build #135612 has finished for PR 31695 at commit 7ed1d8d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Thank you, @maropu !
Merged to master.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135612/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40191/


Move format_prop to format.py

Currently the static method format_prop is within the Tag class, making it hard to reuse. It should be moved to the utils/format.py file.

@ElijahAhianyo You may want to base your code on https://github.com/reflex-dev/reflex/pull/1636, where I have already moved some of format_prop functionality out of the Tag class... this would give a head start and help avoid merge conflicts.

Fixed via #1714


Deployment using the configured environment settings as per EIP82

Using the configuration settings using the package file as per EIP82
environments:
  morden:
    objects:
      auth_factory1:
        class: DSAuthFactory
        address: '0x7639a37b8ecbd68e15b8e173897c6c0dea462452'

We should be able to deploy to Live, Morden, Cloud (Strato), Package Manager (npm) etc etc

this EIP82 is no more

this EIP82 is no more


refactor: run storage object examples without scripts

Fixes #3656

This change is

FYI, this is code complete and can be reviewed.
I made it a draft because some of the examples will fail at runtime without the varargs PR #3795 but it won't require any code changes here. I verified all the examples run fine in my local client.


chore(npm): shrinkwrap dependencies

We should start shrinkwrapping dependencies since so many fast-moving projects are used in this project. Right now we lock dependencies in package.json, which gets us some protection, but we should shrinkwrap to protect from dependencies of dependencies.
We should re-use tools from angular/angular, like the script that generates a clean shrinkwrap file.

I don't think we need this, as long as we keep our top-level dependencies locked down to exact versions. The most high-churn projects are angular, rxjs, System, and zone, which are all locked to exact versions.


Variable initialization do not eval last expression

Fix for this issue
With this PR, variable initialization will not be push into the expressions array.
Inline variable initialization with an output is still valid.  let x = 1; x  will output 1

@funny-vince Thanks for the contribution, this change would be a solid improvement.
One small issue: while the statement
const number = 1;
number;

Does print '1', it appears that the nearly equivalent expression
const numbers = [1,2,3];
numbers;

Will not print anything, even though
const numbers = [1,2,3]; numbers;

Does give the expected result.
The 'eval' function tends to return some unpredictable results at times, it may be worth confirming that this behavior isn't being caused by eval.

@StephenGrider Hi, thanks for your answer. Fixing the issue you have mentioned will break the evaluation of loop with variable initialization in their declaration. For now I cannot help you, I'm sorry for this. Your code works great with eval(), but I found many small bugs while trying to fix this issue. I don't know what are you plan and your goal for JSPlaygrounds, but if you want a neat playground (like JS Bin and JSFiddle) there is probably many things to think about and a lot of code to change/write. If you need help with this, I will be more than happy to help you, but for now, I cannot fix this issue without changing a lot of the existing code.

no problem


TEMP

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#18  👈 (View in Graphite)
#17
#16
main-lachie

This stack of pull requests is managed by Graphite. Learn more about stacking.


Tab to URL Bar

In "Enter Destination URL" window, one cannot use tab to go to box to enter URL. In effect, one must use a pointer device in order to get to URL bar.

The address bar is in focus by default now, but you have to get an app file that's been compiled more recently, see #188


Prevent polluting styles of other CodeMirror instances

As an application of CodeMirror, SimpleMDE should not pollute/override global CodeMirror styles because there might be another CodeMirror on the page used for other purposes.
This PR introduces two changes:

Change the CodeMirror theme name to simplemde and use cm-s-simplemde as a style namespace. This prevents SimpleMDE styles from overriding global CodeMirror styles.

Change class names editor-xxx to simplemde-xxx. This prevents possible style collision with other "editors" (the term editor is too common).

Thank you for contributing, however, this is something I'd like to do with SimpleMDE 2.0. There are a couple of issues regarding converting to SASS and using a container so that styles don't overlap.

Oh, that's a good news! What's the plan about version 2? I'm eager to try it :-)

Currently I have a lack of time, so it may be a little while before I get around to developing 2.0. You can track the milestone for progress updates as they occur.


GUACAMOLE-567: Warn if network connection appears unstable.

This change adds an additional UNSTABLE tunnel status to the JavaScript API, allowing the tunnels to report unstable network conditions in a potentially implementation-dependent way. The web application has been modified to display this as a small warning notification in the lower-left corner of the client screen:

Both the HTTP and WebSocket tunnels currently implement this by tracking the last time any data was received from the server at all (not the time since last frame, but the time since any data was received), flagging themselves as unstable if no data has been received for at least 2 seconds.
Additional handling of HTTP and WebSocket error codes has also been added, such that network errors reported by the browser are recognized as such.

OK - changed "is being established" to "is established" for the OPEN state.


Fixes broken links for in-depth examples on README.md

Issue #57

I did not recognize the link did not work. Thank you for fixing it!


Button not rotating anymore

button is not rotating anymore when clicked since last npm install (yesterday). I've set the degrees prop at 360 but nothing happens. anyone else having this issue?

closing as no one is replying to the issue...


Python2nix builder fails for older dependencies without pyproject.toml

#flake.nix
{
  description = "Pyproject building a uv project";

  inputs = {
    nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";
    pyproject-nix = {
      url = "github:nix-community/pyproject.nix";
      inputs.nixpkgs.follows = "nixpkgs";
    };

    uv2nix = {
      url = "github:adisbladis/uv2nix";
      inputs.pyproject-nix.follows = "pyproject-nix";
      inputs.nixpkgs.follows = "nixpkgs";
    };
  };

  outputs = inputs @ {
    nixpkgs,
    flake-parts,
    pyproject-nix,
    uv2nix,
    ...
  }:
    flake-parts.lib.mkFlake {inherit inputs;}
    {
      systems = nixpkgs.lib.systems.flakeExposed;

      perSystem = {
        config,
        pkgs,
        ...
      }: let
        inherit (nixpkgs) lib;

        workspace = uv2nix.lib.workspace.loadWorkspace {workspaceRoot = ./.;};

        # Create package overlay from workspace.
        overlay = workspace.mkPyprojectOverlay {
          sourcePreference = "wheel"; # or sourcePreference = "sdist";
        };

        python = pkgs.python3;
        pythonSet =
          (pkgs.callPackage pyproject-nix.build.packages {
            inherit python;
          })
          .overrideScope
          overlay;
        devPackages = with pkgs; [python uv];

      in {

        devShells.dev = pkgs.mkShell {
          packages = devPackages;
        };
        devShells.default = let

          # Override previous set with our overrideable overlay.

          # Build virtual environment
          virtualenv = pythonSet.mkVirtualEnv "dev-env" {
            pytest = [];
          };
        in
          pkgs.mkShell {
            packages = [virtualenv ];
            shellHook = ''
              # Undo dependency propagation by nixpkgs.
              unset PYTHONPATH
              # Get repository root using git. This is expanded at runtime by the editable `.pth` machinery.
              export REPO_ROOT=$(git rev-parse --show-toplevel)
            '';
          };

      };
    };
}

#pyproject.toml
[project]
name = "pytest"
version = "0.1.0"
description = "Add your description here"
readme = "README.md"
requires-python = ">=3.12"
dependencies = [
    "docopt>=0.6.2",
]

[build-system]
requires = [ "hatchling","setuptools"]
build-backend = "hatchling.build"

gives
ModuleNotFoundError: No module named 'setuptools'
ERROR Backend 'setuptools.build_meta:__legacy__' is not available.

I also tried
[build-system]
requires = [ "setuptools"]
build-backend = "setuptools.build_meta"

But this fails the same way. I could use the hacks module, but I feel there is a better way using overriding one of the pyproject hooks to set something equivalent to pyproject = false in nixpkgs' buildPythonPackage if a pyproject toml is not found.

but I feel there is a better way using overriding one of the pyproject hooks to set something equivalent to pyproject = false in nixpkgs

That mental model is a bit wrong.
What you're seeing is https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/#fallback-behaviour, which does indeed work without a pyproject.toml.
What happens here is that uv2nix doesn't try and taper over deficiencies of the lock file, so no build-systems are added as a default.
You'll have to override the package as described in https://nix-community.github.io/pyproject.nix/builders/overriding.html#sdist.
The long term fix would be https://github.com/astral-sh/uv/issues/5190

I see, so add setuptools to the uv lock and an overlay that adds setuptools for each deficient dependency like so:

Setuptools and a number of other important build systems and their dependencies are already packaged, so you don't need to add those to your project.
Sources are inherited from nixpkgs, but packaged differently.
I should add the list of these packages to the docs.

Would it be worth always adding setuptools to the buildInputs to avoid such a situation, or could this lead to nasty behavior in the future?

I don't think it's unreasonable to implement that as a default for sdist builds in uv2nix: https://github.com/adisbladis/uv2nix/pull/44.
pyproject.nix contains the lower level bits and doesn't even have any abstraction where this would fit.
I'm going to close this issue, as there isn't anything actionable on the pyproject.nix side of things.


define _mm256_set_m128i for gcc compilers < 8.0

Resolves #45
Please let me know if are logical or stylistic changes are needed, this is my first time add missing instructions.

Thanks for finding and fixing the error.
I checked the code, and it seems to be able to merge without any problems with the current code.
Thanks again for your first contribution.


fix(sc): StackItem serialization of zero values

Fixes #348
When the VM creates the OpCodes for StackItems of null, false or zero values, the OpCode returned is 0000. This means to read off zero bytes. Unfortunately, our implementation of StringStream does not check if it reads zero and throws an error if attempting to read from the end of the stream.
This changes the implementation of StackItem to first check if we are reading zero bytes. If we are, use a default value as indicated by the StackItemType.

That looks great :+1: Thanks

Award snowypowers 200 points

https://neoscan.io/transaction/630c74684cc6dad330397c63e8c7aa6403c043cc1f241638cff87e3b97a40716


What software would you like us to add to our image catalog? (one per issue please)
haproxy
which versions of the containerized software do you need?
2.6.7 (latest lts release)
Add some justification for why this specific image and versions are important.
This is a high performance reverse proxy which are commonly internet facing and would be great with a fast and high security base image like wolfi

Thanks! I'll add it to the list. If there's a use case behind this and you'd like to discuss more, feel free to contact me: adrian at chainguard.dev.

has anyone volunteered yet? if not, i can give it a try.

We (Chainguard) haven't assigned anyone and I don't think we have capacity this year, so please go ahead! That would be amazing :)

Thanks for getting started on this one!


Awesome work

I do not have any questions, just want to say this work is aaaaaaaawesome.
It deserves more attention from the self-supervised learning community.
I believe the conditional motion propagation pretext task will play an important role in the future, serving as one crucial component of a multi-task self-supervised learning framework.

Thank you for your attention, we are constructing a self-supervised learning toolbox under open-mmlab, which will include plenty of representative works, also including CMP, and our new work in CVPR 2020. Please stay tuned!


Add github action build

I think you might want to squash these all when merging, as there is no meaningful debug commit message


Add misc decorations

Provide option ?misc=N (clamped to 0-255) to attempt placing N misc stuff, like altar, push block, etc.
N defaults to 2, can end up with 0 misc stuff.
Also adds floor generic variation and spikes. Floor generic variation could be improved by including the 1x2, 2x1 and 2x2 textures

Probably place_* and render_* should be taken out of the sheets.rs file into their own, plus move stuff like neighbor check and floorstyled texture coords to some utility file. I'm happy to do it, given some input on how it would make sense.

one thing i'd probably do is pull out the large match statemets into functions per biome
Not sure how you mean? Do I just

match biome {
    Biome::Cave => generate_cave_misc(...);
    ...
}

Or is there some smart Rust-way to do something like
match biome {
    _ => generate_misc<_>(...);
}

Or something like that?

Not really a smart way i can think of :skull:

In that case it is done  :P


Source Generator no longer runs since updating to 2.0.0

Describe the Bug
After Updating ThisAssembly to from 1.5.0 to 2.0.0 I can no longer access the ThisAssembly.Info properties like ThisAssembly.Info.Description

As they come from 3rd party tools, not from my project:

Steps to Reproduce
update from "ThisAssembly.AssemblyInfo" to 2.0:
<PackageReference Include="ThisAssembly.AssemblyInfo" Version="2.0.0">
Expected Behavior
code can be called var Description = ThisAssembly.Info.Description; fine as in 1.5.0
In my csproj I have set thoise 2 entries:
<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
<CompilerGeneratedFilesOutputPath>Generated</CompilerGeneratedFilesOutputPath>

and I no longer see the genereted ThisAssembly.AssemblyInfo.g.cs file only the ApplicationConfiguration.g.cs which includes the generated calls for ApplicationConfiguration.Initialize();

Hi there! Some questions:

Is this an intellisense or a build error? (Try filtering for build in the error list)
Does it also fail when doing dotnet build in the CLI?
Does closing and reopening the solution make a difference?

Thanks!

I created a new console app, added the package, and verified that the intellisense doesn't work at first, but after first build, it does. Seems to be something in VS since I'm not doing anything different on that front.

If you delete bin/obj without closing the source file, you see the same effect:

(note the Build + Intellisense in the drowdown). Doing a "full build" fixes it automatically though.
Does that match your experience?

closing/reopening make no different and also deleting the obj nuget folder makes no difference.
This is a compile error as the generated class is not found I can't compile the project at all no matter if I try it from VS2022 or cli with dotnet.

Could you share which package you're using? ThisAssembly.AssemblyInfo or ThisAssembly (metadata package)?
Also, would you mind creating a blank console app, adding the same package and using WriteLine as I did above? If you see the same error, would you mind running dotnet build -bl and attaching the binlog? 🙏

I use this one:
https://www.nuget.org/packages/ThisAssembly.AssemblyInfo/2.0.0
and before updating I was using the 1.5.0 version which is now unlisted?
https://www.nuget.org/packages/ThisAssembly.AssemblyInfo/1.5.0
I'm now out of office for the rest of the day, I'll try to compare the build with 1.5.0 and 2.0.0 tomorrow.

Yeah, I have unlisted 1.5 in favor of 2.0.

Why is the dll missing? What have you changed?

ok, after looking at the commits (which are horrible as there are a lot of meaningless commits "Bump files with dotnet-file sync" which is awfull to see what commits do, you need to check every commit what is changed) I found this commit.
This explains the dependency on ThisAssembly.Constants and here is my issue. With MSBuild Structured Log Viewer I can see that the task to transfer my assembly infos into constants is not called so the Constants Source generator can only transfer my dummy constants I've added to check if this code generator is called.

ThisAssembly.AssemblyInfo is indeed just a special case of Contants (most packages are, now). That should not be the issue at all.
Could you please create a repro project? I simply cannot reproduce your issue as-is. The fact that those targets are greyed out do not indicate much (could have run previously already, for example). Without either a repro project or a binlog, there isn't much I can do :(

I've created a demo that works fine with 1.5.0 and fails with 2.0.3. It is an empty .net 8 WinForms application but includes all reference nugets as in my real application but it depends on subversion for version control.
You need to checkout the code from the repo with svn/TortoiseSVN and open the sln in trunk
ThisAssembly.AssemblyInfo.Demo_SVN_Repo.zip
If I downgrade the package to 1.5.0 I get the generated files.

Could you please create a repro project? I simply cannot reproduce your issue as-is.

Did you have some time to look at it? You need use svn checkout file:/// with path to create a working copy and get the project.

Able to reproduce as a first party consumer and with `dotnet build` in CLI.

This seems to only happen when upgrading from a previous version. Remove ThisAssembly from your csproj file, run dotnet clean, then readd the updated version through: dotnet add package ThisAssembly --version 2.0.3

Roslyn does heavy caching of intermediate files. I'd suggest deleting bin/obj recursively and try again.
I do not have or use svn to test this locally from the provided zip. I doubt it has anything to do with source control, to a simple zip of the actual sources should be enough if it does repro.

As already said, clearing obj/bin makes no difference.
without svn the code doesn't compile as I've added Unclassified.NetRevisionTask I also use in my project. You wanted all references, you get all references in the demo

That's great actionable investigation, thanks! I'll look into it ASAP.

Got the fix 💪 https://github.com/devlooped/ThisAssembly/pull/422

Got the fix 💪 #422

nope, still the same error. The translation to constants runs but generates crap (Company gets project name, version is <IP_ADDRESS> not my version from Unclassified.NetRevisionTask) so the default values. And the Copyright, Description from AssemblyInfo.cs are not translated and so I still have compile error CS0117: 'ThisAssembly.Info' does not contain a definition for 'Description'

It looks like whatever you're using is not playing nice and is generating a non-partial ThisAssembly. Plz bring the issue to them.
Without a repro, it's kinda impossible to see what you see. All my tests and daily usage shows it's working as designed. I have never used that Unclassidified thing.

Without a repro, it's kinda impossible to see what you see. All my tests and daily usage shows it's working as designed. I have never used that Unclassidified thing.

I've posted a repro which you ignore the whole time. I'll stick on 1.5.0 which works and ignore all newer updates.

and your "fix" is to ignore my configured GenerateAssemblyInfo value and set the values to the data which the SDK sets when GenerateAssemblyInfo is true. And this is what I DON'T want. I set the value to false for reasons!

I do not have or use svn to test this locally from the provided zip. I doubt it has anything to do with source control, to a simple zip of the actual sources should be enough if it does repro.

That is not something I can work off of as a repro. Plz provide a github repo if that is easier for you.
Could you elaborate on why it's what you DON'T WANT, what I did? I studied the SDK targets carefully and there's no side effect from my fix. You might disagree with how I fixed it, but that's a different matter. What side effect are you seeing that is problematic? Please provide a clean repro I can simply clone or download (without having to install any software), and I can look at it.

Also, I'd be more than happy to review a PR that fixes it in a better way for your scenario.

Again, there is a sideeffect, your changes causes that data are read from the csproj and no longer from my AssemblyInfo.cs and this causes issues with my consumed Unclassified.NetRevisionTask package. It doesn't support this and the subversion revision is not added to the version. I have to do this as there is no Subversion SourceLink provider , so I need to add the SVN revision to the version number to see which version the user is running so that I can checkout this revision to debug the issue. So I MUST set GenerateAssemblyInfo to false. And as I use Subversion, putting this on Github is useless 🤦. I debugged the issue, found the casue, provided you a repro and you only complain and complain.
I've add the working thisassembly.assemblyinfo.1.5.0.nupkg now to my solution and added a source entry to the nuget.config to use this solution folder as source, so that restore always works and I'll ignore now all updates of your package and use 1.5.0 until something breaks it

Well, I guess you can also report to that Unclassified.NetRevisionTask package that they are incompatible with this package.
As I mentioned, I'd gladly take a PR if this is critical for you. I don't have the bandwidth to do this for free, and this is the first and only time someone ever reported such an issue.
Thanks.


[PDI-13315] [v2] Subjobs called from jobs are duplicating result rows

@mattyb149 review it please.
This is suggested instead of https://github.com/pentaho/pentaho-kettle/pull/889
The behavior implemented is like in JobEntryTrans when execute transformation on the local machine:
if subjob result contains rows, they are used as the JobEntryJob result rows
if subjob result contains no rows, JobEntryJob result rows stay unchanged

I hope this fixes this bug :)

@mattyb149
see also https://github.com/pentaho/pentaho-kettle/pull/1047 (SP-1680 - backport to 5.3)


Resource Accounts

With Teams PS Module 3.0, 3.1 and 3.1.1, Grant-CsOnlineVoiceRoutingPolicy no longer appears to work on Resource Accounts.  I've tried with both powershell 5.1 and 7.2.1 with zero success and results with the following:
Grant-CsUserPolicy_GrantExpanded: C:\Users\user\OneDrive\Documents\PowerShell\Modules\MicrosoftTeams\3.1.0\netcoreapp3.1\custom\PsExt\Grant-CsUserOrTenantPolicy.ps1:61
Line |
61 |              Microsoft.Teams.ConfigAPI.Cmdlets.internal\Grant-CsUserPo …
|              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| User does not exist
Currently the only way I can apply a voice routing policy to a Resource Account is to down grade the Teams Module to 2.6.0
K.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a58aa424-e87c-e4cb-d6a3-49a0d842f831
Version Independent ID: 8d1e09fa-7896-56e8-c294-8cac6c35d8d3
Content: Grant-CsOnlineVoiceRoutingPolicy (SkypeForBusiness)
Content Source: skype/skype-ps/skype/Grant-CsOnlineVoiceRoutingPolicy.md
Service: skypeforbusiness-powershell
GitHub Login: @tomkau
Microsoft Alias: tomkau

additional note, get-csonlineuser for the resource account name works, and it is assigned the Phone Standard - Virtual User license.  I also tried removing the policy from another resource account that has been working for months, with the same "User does not exist" result.

I can also confirm that I am having the same issue with the last few iterations of TeamsPS.
I have the issue with both new and existing RA's and have to resort to downgrading to 2.6 for it to work for me.
`Grant-CsOnlineVoiceRoutingPolicy -Identity 'RA_SIP' -PolicyName "Policy_name"
Microsoft.Teams.ConfigAPI.Cmdlets.internal\Grant-CsUserPolicy : User does not exist
At C:\Program Files\WindowsPowerShell\Modules\MicrosoftTeams\3.1.1\net472\custom\PsExt\Grant-CsUserOrTenantPolicy.ps1:61 char:13

        Microsoft.Teams.ConfigAPI.Cmdlets.internal\Grant-CsUserPo ...

        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : InvalidOperation: ({ Identity = ...ntUserRequest }:<>f__AnonymousType56`3) [Grant-CsUserPolicy_GrantExpanded], Ex
ception
FullyQualifiedErrorId : ClientError,Microsoft.Teams.ConfigAPI.Cmdlets.Generated.Cmdlets.GrantCsUserPolicy_GrantExpanded
`

As per the documentation I have also tried the account in other formats such as  SIP address, UPN and the user's Active Directory display name and get the same error.

The issue was resolved Thursday morning for all 3.x teams ps modules.  About an hour AFTER I redid customer documentation for  with the 2.6 module...  at the same time having another cx migrating from lync to downgrade from 2.6to 2.3.1 as the move csuser broke...  really hope for more stability and consistency at some point, keeping up and keeping everyone functioning is quite maddening
Sent from my mobile device

From: David Eberhardt @.>
Sent: Sunday, February 13, 2022 4:37:39 AM
To: MicrosoftDocs/office-docs-powershell @.>
Cc: Korbyn72 @.>; Author @.>
Subject: Re: [MicrosoftDocs/office-docs-powershell] Resource Accounts (Issue #8932)
Yes, have the same, but not for all versions and not consistently across all tenants. Very weird behaviour going on.
Also here: #8930https://github.com/MicrosoftDocs/office-docs-powershell/issues/8930
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/office-docs-powershell/issues/8932#issuecomment-1038081676, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG32UAN43H2GZEYRMZP5IXLU26QZHANCNFSM5N36WX3Q.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>

Hi all,
Thank you for your feedback.
I have tested it with 3.1.1 in a lab tenant and it works for me.
If you still have this issue, I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome, let me know if it can be called out in the docs.
Please follow this link to contact support for business products: https://docs.microsoft.com/office365/admin/contact-support-for-business-products.
Please keep us posted here on the resolution to feed whatever information you discover into the content.

@dariomws Thank you very much for the contribution and sharing this explanation. @Korbyn72
Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed to close it as here we are limited to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

I did call in a log a support case, they responded with using set-csonlinevoic.... completely wrong command and purpose...  eventually they saw the light and escalated internally to engineering and closed my case.
Sent from my mobile device

From: Yogesh Kumar @.>
Sent: Sunday, February 20, 2022 4:45:56 AM
To: MicrosoftDocs/office-docs-powershell @.>
Cc: Korbyn72 @.>; Mention @.>
Subject: Re: [MicrosoftDocs/office-docs-powershell] Resource Accounts (Issue #8932)
@dariomwshttps://github.com/dariomws Thank you very much for the contribution and sharing this explanation. @Korbyn72https://github.com/Korbyn72
Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed to close it as here we are limited to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/office-docs-powershell/issues/8932#issuecomment-1046230133, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG32UAPM7GW7PCS5AGKWCSLU4DPAJANCNFSM5N36WX3Q.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>

You can reclose the case, I posted 7-10 days ago that it was fixed, but I believe it was from posting here and talking to Support was a waste of 48 hours
Sent from my mobile device

From: Office Content Publishing @.>
Sent: Sunday, February 20, 2022 2:25:50 PM
To: MicrosoftDocs/office-docs-powershell @.>
Cc: Korbyn72 @.>; Mention @.>
Subject: Re: [MicrosoftDocs/office-docs-powershell] Resource Accounts (Issue #8932)
Reopened #8932https://github.com/MicrosoftDocs/office-docs-powershell/issues/8932.
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/office-docs-powershell/issues/8932#event-6107876896, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG32UAKB27QERUXJF6HYTMDU4FS65ANCNFSM5N36WX3Q.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>

It is so frustrating... We run Teams PS Module 3.1.1 and today we have been hit by the same issue with ressource accounts:
Grant-CsTenantDialPlan -Identity $UPN -PolicyName "Policy"
Grant-CsUserPolicy : User does not exist
FullyQualifiedErrorId : ClientError,Microsoft.Teams.ConfigAPI.Cmdlets.Generated.Cmdlets.GrantCsUserPolicy_GrantExpanded

@olanga, please try the latest version of the module (4.4.1).


How to revert after completed arrange pictures

This assumes that the original pictures are now deleted.
Only the SmartArt remains.
Now we have to extract the original pictures.

We do not delete original pictures, only hide them. So reverting is easy. We have already done in error recovery.
Closing this issue.


Easy way to remove capo (piano)

Add an easy and fast way to remove any capo. It's really important for any pianist.
It would also be nice to remember this choice for the whole website.

I added #1463 for piano support in general. Selecting piano as the instrument should just disable capo automatically.
There probably should be a separate toggle that is persisted across the site to disable capo for those playing instruments that don't typically use a capo (bass, lead guitar, ukulele, mandolin, etc).

The piano mode is a nice idea. But keep the capo tool available because some digital keyboards have a transpose function.

Good point. Sounds good.


can this code run on a cpu machine？

I run on a cpu machine with default args,   I got the following errors：
num_params:  167301123
INFO:root:Variables info has been saved.
5%|#####5                                                                                | 1533/30681 [3:21:15<61:40:30,  7.62s/it]INFO:root:epoch 1 is done
INFO:root:# test evaluation
INFO:root:# get hypotheses
Traceback (most recent call last):
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1334, in _do_call
return fn(*args)
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1319, in _run_fn
options, feed_dict, fetch_list, target_list, run_metadata)
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1407, in _call_tf_sessionrun
run_metadata)
tensorflow.python.framework.errors_impl.InvalidArgumentError: indices[33,100] = 100 is not in [0, 100)
[[{{node encoder_1/positional_encoding/embedding_lookup}}]]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "train.py", line 81, in
hypotheses = get_hypotheses(num_eval_batches, num_eval_samples, sess, y_hat, m.idx2token)
File "/data/gpu_codes_bak/echothuang/transformer-master/utils.py", line 144, in get_hypotheses
h = sess.run(tensor)
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 929, in run
run_metadata_ptr)
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1152, in _run
feed_dict_tensor, options, run_metadata)
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1328, in _do_run
run_metadata)
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1348, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: indices[33,100] = 100 is not in [0, 100)
[[node encoder_1/positional_encoding/embedding_lookup (defined at /data/gpu_codes_bak/echothuang/transformer-master/modules.py:295) ]]
Caused by op 'encoder_1/positional_encoding/embedding_lookup', defined at:
File "train.py", line 48, in
y_hat, eval_summaries = m.eval(xs, ys)
File "/data/gpu_codes_bak/echothuang/transformer-master/model.py", line 163, in eval
memory, sents1 = self.encode(xs, False)
File "/data/gpu_codes_bak/echothuang/transformer-master/model.py", line 50, in encode
enc += positional_encoding(enc, self.hp.maxlen1)
File "/data/gpu_codes_bak/echothuang/transformer-master/modules.py", line 295, in positional_encoding
outputs = tf.nn.embedding_lookup(position_enc, position_ind)
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/ops/embedding_ops.py", line 316, in embedding_lookup
transform_fn=None)
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/ops/embedding_ops.py", line 133, in _embedding_lookup_and_transform
result = _clip(array_ops.gather(params[0], ids, name=name),
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/util/dispatch.py", line 180, in wrapper
return target(*args, **kwargs)
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/ops/array_ops.py", line 3273, in gather
return gen_array_ops.gather_v2(params, indices, axis, name=name)
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/ops/gen_array_ops.py", line 3748, in gather_v2
"GatherV2", params=params, indices=indices, axis=axis, name=name)
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/framework/op_def_library.py", line 788, in _apply_op_helper
op_def=op_def)
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/util/deprecation.py", line 507, in new_func
return func(*args, **kwargs)
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 3300, in create_op
op_def=op_def)
File "/home/user_00/tensorflow_env/yes/envs/tensorflow_p3/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 1801, in init
self._traceback = tf_stack.extract_stack()
InvalidArgumentError (see above for traceback): indices[33,100] = 100 is not in [0, 100)
[[node encoder_1/positional_encoding/embedding_lookup (defined at /data/gpu_codes_bak/echothuang/transformer-master/modules.py:295) ]]

I got the same errors

Filling up shuffle buffer.....
.....
shuffle buffer filled.....
.....
indices[111,100]=100 is not in [0,100].......
.....
i met those errors in my CPU machine