check if archivedJobs table exists, before running migration

https://github.com/Shippable/admiral/issues/2857
https://github.com/Shippable/admiral/issues/2858

closing this since this won't work on centos


add @mertcb to techdocs CODEOWNERS

#8294

@jhaals

Hey @mertcb, thank you so much for offering support by adding yourself to CODEOWNERS for TechDocs. We have noted and appreciate all the contributions you have made so far (around TechDocs). Know that you are valuable to the community. As of now, we @backstage/techdocs-core (and Backstage core in general) are in the process of figuring out how to extend our ways of working and include more diversity in the maintenance model. A more formal model will help us establish a stronger relationship among the TechDocs maintainers and will be beneficial to the community. Until then, we would like to close this PR. But we'll be back. And thanks again!


Documentation about the entire stack and usage..

the documentation about a sample real architecture and usage in a u2fval based enviroment is fragmented (a lot) insufficient and dispersive, making a real example with a app in a small network with a small amount of users/devices can be more useful..
i've found this "https://developers.yubico.com/u2fval/Manuals/u2fval.1.html" after hours, but there isn't a complete and a detailed view about a real implementation case.
Firstly registration of yubikeys, and user association/managemnt example it's lacking.
.

closed with no answer?


make form inputs red

Current coverage is 95.97%

Merging #583 into dev will decrease coverage by -0.38% as of a179e2a

@@              dev    #583   diff @@
=====================================
  Files          24      24
  Stmts        2499    2512    +13
  Branches      224     225     +1
  Methods         0       0
=====================================
+ Hit          2408    2411     +3
  Partial        45      45
- Missed         46      56    +10

Review entire Coverage Diff as of a179e2a

Powered by Codecov. Updated on successful CI builds.

Yep. Looks good. Thanks.


get_current_number metric should be a gauge

Currently this metric is set up as a counter, but should be a gauge. The plugin is logging these errors:
[2017-05-22T15:38:08,748][ERROR][RestPrometheusMetricsAction] Can not increment metric index_get_current_number with value -4.000000, skipping
[2017-05-22T15:38:09,668][ERROR][RestPrometheusMetricsAction] Can not increment metric indices_get_current_number with value -2.000000, skipping
ES 5.4.0 + plugin version: <IP_ADDRESS>

Since I switched all counters to gauge, this must be solved now.

@vvanholl is it backported to 2.3.5 too? I'm getting it there. It is a pitty, that we need new version of the plugin for every version of ES :(


When check and release unused JVMObjectTracker objects, change the speed adaptively according to current objects count.

When check and release unused JVMObjectTracker objects, change the speed adaptively according to current objects count.

[Current coverage][cc-pull] is 82.33%

Merging [#488][cc-pull] into [master][cc-base-branch] will increase coverage by 0.15%

@@             master       #488   diff @@
==========================================
  Files            48         48
  Lines          5080       5101    +21
  Methods         975        978     +3
  Messages          0          0
  Branches        648        649     +1
==========================================
+ Hits           4175       4200    +25
+ Misses          619        615     -4
  Partials        286        286

Powered by Codecov. Last updated by [33b87b4...97a0cec][cc-compare]
[cc-base-branch]: https://codecov.io/gh/Microsoft/Mobius/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/Microsoft/Mobius/compare/33b87b4b0f2ae09e5398f59eafb634bb2682cbb0...97a0cecf4aa6021332991fd19875b5a268813557
[cc-pull]: https://codecov.io/gh/Microsoft/Mobius/pull/488?src=pr

LGTM


istioctl x uninstall --revision 1-7-0 is broken

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities/
To ask questions about how to use Istio, please visit https://discuss.istio.io
)
Bug description
https://preliminary.istio.io/latest/docs/setup/upgrade/#uninstall-old-control-plane is not working
Affected product area (please put an X in all that apply)
[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Expected behavior
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
How was Istio installed?
Environment where bug was observed (cloud vendor, OS, etc)
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

cc @linsun

The issue is fixed with above PR, closing it


Proposal to use provider from including module instead of instantiating within the module

Is your feature request related to a problem? Please describe.
When using this module as part of another module that also uses the vsphere provider it is a bit unwieldy to also have the provider instantiate its own instance of the vsphere provider.  I'd like to propose the removal of the provider block within this module and instead rely on terraform's ability to inherit providers from the parent module (https://www.terraform.io/language/modules/develop/providers)
Describe the solution you'd like
Removal of the :
provider "vsphere" {
  user                 = var.vsphere_user
  password             = var.vsphere_password
  vsphere_server       = var.vsphere_server
  allow_unverified_ssl = true
}

black as well as associated input variables from the module and instead rely on provider inheritance.
Describe alternatives you've considered
No response
Additional context
More than happy to submit a PR making these changes if you are interested.

@jcsmith the provider block has been removed from within the module. Thank you for your proposal and if there's anything else you'd like to see improved please let me know.


Add PR template

I would like to add a pull request template for this repository. Please assign me this issue under GSSOC'24.

We already have a template @suhanipaliwal. Closing the issue, please re-open if necessary.


updating algolia ui

Codecov Report

Merging #147 (cfe1688) into master (fc513d6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   79.67%   79.67%
=======================================
  Files         123      123
  Lines       11338    11338
  Branches     1175     1175
=======================================
  Hits         9033     9033
  Misses       2305     2305

Flag
Coverage Δ

unittests
79.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f670cbd...cfe1688. Read the comment docs.


Rename vllm.logging to vllm.logging_utils

Hopefully Fixes #10133
Done from mobile, untested at the moment

@youkaichao FYI, since you filed the corresponding issue

Avoiding naming collisions is an impossible task if we want to avoid all possible collisions to allow running code from within any arbitrary vllm source directory.

we only do it in case-by-case, only do it when we find annoying cases.


Feat: Adding artist page

Describe the feature
currently the artist page is showing coming soon . I want to add a fully working artist page
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

What are you going to implement ? Give some info @anwesha2002

@Subhajit098 in the API there are options for getting artist's song. so by calling that api and retrieving data and showing it to the frontend I will make this entire artist page

Ok go ahead


Add setup documentation to README

Can you when you have a chance add some basic installation installation information , my guess if you are generating on schedule via cron, so peut-être the example puppet cron code or just  assumptions like file paths  and such. :)

The interface itself needs no installation procedure at all. You can even use it without a web server if you add http: in front of the jquery javascript call in index.html.
As for generating the reports, I'm using the script you provide as example in puppet-catalog-diff. I don't have crontabs yet, this is my next step :smile:

Actually, I have the catalog-diff tool and the catalog-diff-viewer on the puppetdb machine, and I run the catalog-diff tool as puppet.
This way, I can use the normal Puppet certificate to connect to the Puppetmaster and localhost:8080 for the PuppetDB, store the resulting JSON file locally, and have it loaded by the interface using jquery (just a getJSON call, see index.html's example of using loadReport().

@raphink could you elaborate on your last comment. If I have generated a directory of reports on disk and I have this application running on a webserver on same host how can I pre-seed the drop down menu with the reports?

@traylenator see index.html from the prod branch. The reports must be located in the data/ directory relative to the page.

@raphink thanks!! got that working.

Cool.


Wrapped function causes runtime error.

dartpad
I'm not sure how to describe this issue.
abstract class Interface {}

class Model implements Interface {}

class Lens<A> {
  final A Function(A) get;
  const Lens(this.get);
}

void main() {
  Lens<Interface> a = Lens<Model>((a) => a);
  print(a.get); /// Script error / type '(Model) => Model' is not a subtype of type '(Interface) => Interface'
}

I'm trying to chain lenses (functional references) and this problem comes up when I'm dealing with inheritance hierarchies.
Implicit-casts are set to false so I'm expecting some kind of safety there, but I'm not sure if this scenario is just something that I have to somehow be careful about?
I'd at least expect that that program would not compile, but instead, it crashes on the print call.
Is there a way to deal with this?

The problem is that you are specifying that you want a Lens<Model>. The current Dart rules for variance only have one form: Covariance for every type parameter of a generic class, with dynamic checks at all occasions where there is no static guarantee that the requirement is satisfied.
We have plans to add support for statically safe variance (covariance, contravariance, invariance) to Dart, so you will (if we proceed to do this, which is quite likely) be able to specify the variance on each type parameter, and then there will be static checks that the rules necessary for soundness are respected.
In particular, if you were to declare as covariant with class Lens<out A> { ... } then you would not be able to have the instance variable named get, because it has a non-covariant occurrence of the type variable A. So you would have to use the more strict invariant mode, using class Lens<inout A> {...}, and this would imply that there is no subtype relationship between Lens<Model> and Lens<Interface>.
So you would still not be able to have Lens<Interface> a = Lens<Model>(...);, but now it would be a compile-time error rather than a run-time error.
So what you can do now is to treat Lens as if its type parameter were invariant; you won't get the static checks to enforce that, yet, but you can do it manually.

Thank you very much for the workaround and the clear explanation.


Add several "all powers" built-ins

Closes #1419

Not sure if all powers of 3 is useful but whatever. Why isn't this under list digraphs?

I placed it in the miscellaneous digraph space for consistency with all multiples.
Do you think there's a power more suitable than 3? If so, it can be changed to that. I just thought 3 was a sensible one to have.

Fair enough. I'll remove it a little bit later


updates existing yuba data and runs .Rmd, generating data objects

closes #40
merging into combined-habitat-updates

Hi Maddee, we can find your comments when you're back but I wanted to take some notes here based on what you said in slack --

floodplain: they provided us floodplain acres for two different reaches. is there a way to combine them without converting to wua (i.e., using the lengths of the river miles to combine them, which is what I did?)
removed the floodplain threshold
fixed nomenclature for in-channel vs instream


New methods on DateTime (lastDayOfMonth, lastDayOfWeek, firstDayOfWeek)

Looking for lastDayOfMonth like feature, found this StackOverflow question and I really liked the way Yogesh Parwani mixed Chris Buckett and Kai Sellgren awnsers. As pointed by Juniper Belmont on Buckett's answer, I do think this could be a new feature or at least pointed on the official documentation that these values could be obtained like this.
Code bellow:
extension DateTimeExtension on DateTime {

  DateTime get firstDayOfWeek => subtract(Duration(days: weekday - 1));

  DateTime get lastDayOfWeek => add(Duration(days: DateTime.daysPerWeek - weekday));

  DateTime get lastDayOfMonth => month < 12 ? DateTime(year, month + 1, 0) : DateTime(year + 1, 1, 0);
}

cc @lrhn for thoughts
My initial reaction is we probably wouldn't put this in the SDK. I could imagine putting this into a utility package, but it's not a good fit for any of our existing core packages.

We don't have a package:core, which is where it would fit.
I'm not completely opposed to putting DateTime extensions in dart:core, but I don't see this as features that will be widely used, which is one of the criteria for going into a dart: library (widely used by many users, or heavily used by some users, and something you'll only ever need one canonical version of, so we might as well provide it - or something which requires native interop with the runtime system).
The "firstDayOfWeek" is contentious, since some people (incorrectly :stuck_out_tongue:) consider Sunday the first day of the week, even though it is obviously Monday. That suggests having separate packages that you can choose between.
Maybe we should have a package:calendar (name currently taken by a 4-year-stale package.)
(Also, don't use Duration when calculating dates. Better implementation:
extension DateTimeFirstLast on DateTime {
  DateTime get firstDayOfWeek => DateTime.utc(year, month, day + 1 - weekday);
  DateTime get lastDayOfWeek => DateTime.utc(year, month, day + 7 - weekday);
  DateTime get firstDayOfMonth => DateTime.utc(year, month, 1);
  DateTime get lastDayOfMonth => DateTime.utc(year, month + 1, 0);
  DateTime get firstDayOfYear => DateTime.utc(year, 1, 1);
  DateTime get lastDayOfYear => DateTime.utc(year, 12, 31);
}

which isn't affected by the time of the DateTime object it's called on, and uses UTC to represent time-less dates as recommended.)

@FMorschel you should submit a PR to the time package: https://github.com/jogboms/time.dart

As this request is now on https://github.com/jogboms/time.dart as suggested, I'm closing this issue.


Add entity properties to rego evaluation context.

Summary
This change adds the entity's properties as defined by the provider to the REGO evaluation context, making it possible to use them as arguments to e.g. data sources.
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[X] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Manual tests.
Review Checklist:

[X] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[X] Checked that related changes are merged.

coverage: 55.012% (+0.003%) from 55.009%
when pulling c9876e4ec406b380505e3ac366f3651ad1870f30 on feat/add-properties-to-rego-engine
into 9286b3173e53065ad0ee4013cd09ea83bd86fd6a on main.

sorry @JAORMX, linter was complaining.


hCaptcha not showing challenge

When I tried to implement it keep buffering and never show the challenge

I have provided Internet permission
I have attempted all sizes
Using com.github.hcaptcha:hcaptcha-android-sdk:1.1.0
Using androidx.appcompat:appcompat:1.2.0

The code I'm using is
final String SITE_KEY = "site key here";
final HCaptchaConfig hconfig = HCaptchaConfig.builder()
        .siteKey(SITE_KEY)
        .apiEndpoint("https://js.hcaptcha.com/1/api.js")
        .size(HCaptchaSize.NORMAL)
        .loading(true)
        .build();

HCaptcha.getClient(MainActivity.this).verifyWithHCaptcha(hconfig)
    .addOnSuccessListener(new OnSuccessListener<HCaptchaTokenResponse>() {
        @Override
        public void onSuccess(HCaptchaTokenResponse response) {
            String userResponseToken = response.getTokenResult();
            showMessage("Success! Token: " + userResponseToken );
        }
    })
    .addOnFailureListener(new OnFailureListener() {
        @Override
        public void onFailure(HCaptchaException e) {
            showMessage("Error: " + e.getMessage() );
        }
    });

@Amitoj02 maybe you observe some errors in logcat?

@Amitoj02 please try with one of the test sitekeys: https://docs.hcaptcha.com/#integration-testing-test-keys and if that works, double-check the sitekey entered.

Alright, so I tried to compile again and it actually worked magically . Maybe I missed something or it was temporary issue.


Update to gRPC client

Quite a few things to unpack here. So I've updated the plugin to use the gRPC client instead and while doing that I also took a few ideas from the SQL persistence plugin.
There are a few breaking changes that needs to be documented here as well. I'll gladly help with that if you want to merge this.
As this plugin isn't really maintained anymore and we'll likely use it in production in the near future I'd also like to offer my support and maybe take over maintenance if you want me to?

@MattiasJakobsson the build system has been restored for this project - you should be good to go now with your modernization efforts here! Please let us know if we can help


Code health: Remove unused aes_x86core.c

I'd prefer to keep it around. It's reference implementation used as template for some of assembly modules. Even though the module has x86 in its name, x86 in not the only platform that "stems" from this implementation...

On related note there is couple of similar files in poly1305, i.e. templates, also keepers...

Ok.  I did notice the comments about the similar poly1305 files being templates, would you mind adding a similar comment in aes_x86core.c, to make sure we're all clear on this?
Meanwhile, I'm closing this.


Stopped working

Seems like Google have changed something as the extension isn't working for me anymore.

Could you provide more detailed information on it?
What is your browser and what is your extension version?

Yes sorry.
Version 64.0.3282.167 (Official Build) (64-bit)
Mac Os 10.13.3
Google Search "View Image" Button 1.3
It was working for a few days.

Hmm. I'm using the same version as yours but it works for me.
What is your console log saying? You can check in by pressing F12 on chrome, and select the "console" tab, and refreshing the search page, and then click any images on the list.

Just to add to conversation, using latest chrome on windows 10 64bit and it works perfectly fine, I see no changes from google. Just updated chrome now, to check, and it's fine.

Hmm. Now its working. Must have been a strange glitch either in the browser or in my brain.


Bump requirements and fix flake deps

Coverage remained the same at 90.501% when pulling 348f8668845413e1fdab2ed7dec15025caad9e3c on bump_requirements into 9118a786982a771f4361137e7c1fd397b01699f4 on develop.

Coverage remained the same at 90.501% when pulling 8552b1b53e1e042c32e019cf1433de356f60a104 on bump_requirements into 9118a786982a771f4361137e7c1fd397b01699f4 on develop.

+1

+1


Response headers are not added to returned error

Related to: #81
I noticed that the request headers are only being added to the returned error if the function returns prematurely.
Would be nice if someone could take a look at it.
https://github.com/microsoft/kiota-http-go/blob/b162cb63903518fdf02bd4e281e7729bcad899fc/nethttp_request_adapter.go#L811-L813

Hi @NerdJeremia
Thanks for using kiota and for reaching out.
I'm not sure I'm following what the issue here is, would you mind expanding please?

Thanks for the additional information.
I'm not sure why the headers are hoisted at the same level as the error.
Can you share the context of the Get/post/patch/put method please? As well as the error definition?

Sure. This is the definition of the error
type CmpErrorResponse struct {
    i2ae4187f7daee263371cb1c977df639813ab50ffa529013b7437480d1ec0158f.ApiError
    code *CmpErrorCode
    description *string
    details *string
    stacktrace *string
    typeEscaped *CmpErrorType
}

// ApiError is the parent type for errors thrown by the client when receiving failed responses to its requests
type ApiError struct {
	Message            string
	ResponseStatusCode int
	ResponseHeaders    *ResponseHeaders
}

In my understanding the ResponseHeaders should be in the field ResponseHeaders of the ApiError.
But it seems to me that they are not correctly added in the code I referenced at the top.

Thanks for sharing the additional information.
The fact the ResponseStatusCode is also intriguing. I'm not able to reproduce the behaviour locally.
The best thing is probably to:

clone the kiota repositories locally
use local references for all of them (add replace in all kiota repos to the abstractions one, add replace in your repo to the kiota ones)
debug and step through the code to better understand what's going on.
share the findings here.

Thanks for your reply. I will try it.

Hey @baywet,
Sorry for the late reply but these are the things I found:
In the throwIfFailedResponse method where the errValue gets set:
errValue, err := rootNode.GetObjectValue(errorCtor)
TheCreateCmpErrorResponseFromDiscriminatorValue function of our generated code gets called which then calls the NewCmpErrorResponse function and that calls the NewApiError function of the https://github.com/microsoft/kiota-abstractions-go package. This creates a new API error with empty ResponseHeaders.
package models

import (
    i2ae4187f7daee263371cb1c977df639813ab50ffa529013b7437480d1ec0158f "github.com/microsoft/kiota-abstractions-go"
    i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91 "github.com/microsoft/kiota-abstractions-go/serialization"
)

type CmpErrorResponse struct {
    i2ae4187f7daee263371cb1c977df639813ab50ffa529013b7437480d1ec0158f.ApiError
    code *CmpErrorCode
    description *string
    details *string
    stacktrace *string
    typeEscaped *CmpErrorType
}
func NewCmpErrorResponse()(*CmpErrorResponse) {
    m := &CmpErrorResponse{
        ApiError: *i2ae4187f7daee263371cb1c977df639813ab50ffa529013b7437480d1ec0158f.NewApiError(),
    }
    return m
}
func CreateCmpErrorResponseFromDiscriminatorValue(parseNode i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91.ParseNode)(i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91.Parsable, error) {
    return NewCmpErrorResponse(), nil
}
func (m *CmpErrorResponse) Error()(string) {
    return m.ApiError.Error()
}
func (m *CmpErrorResponse) GetCode()(*CmpErrorCode) {
    return m.code
}
func (m *CmpErrorResponse) GetDescription()(*string) {
    return m.description
}
func (m *CmpErrorResponse) GetDetails()(*string) {
    return m.details
}
func (m *CmpErrorResponse) GetFieldDeserializers()(map[string]func(i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91.ParseNode)(error)) {
    res := make(map[string]func(i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91.ParseNode)(error))
    res["code"] = func (n i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91.ParseNode) error {
        val, err := n.GetEnumValue(ParseCmpErrorCode)
        if err != nil {
            return err
        }
        if val != nil {
            m.SetCode(val.(*CmpErrorCode))
        }
        return nil
    }
    res["description"] = func (n i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91.ParseNode) error {
        val, err := n.GetStringValue()
        if err != nil {
            return err
        }
        if val != nil {
            m.SetDescription(val)
        }
        return nil
    }
    res["details"] = func (n i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91.ParseNode) error {
        val, err := n.GetStringValue()
        if err != nil {
            return err
        }
        if val != nil {
            m.SetDetails(val)
        }
        return nil
    }
    res["stacktrace"] = func (n i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91.ParseNode) error {
        val, err := n.GetStringValue()
        if err != nil {
            return err
        }
        if val != nil {
            m.SetStacktrace(val)
        }
        return nil
    }
    res["type"] = func (n i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91.ParseNode) error {
        val, err := n.GetEnumValue(ParseCmpErrorType)
        if err != nil {
            return err
        }
        if val != nil {
            m.SetTypeEscaped(val.(*CmpErrorType))
        }
        return nil
    }
    return res
}
func (m *CmpErrorResponse) GetStacktrace()(*string) {
    return m.stacktrace
}
func (m *CmpErrorResponse) GetTypeEscaped()(*CmpErrorType) {
    return m.typeEscaped
}
func (m *CmpErrorResponse) Serialize(writer i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91.SerializationWriter)(error) {
    if m.GetCode() != nil {
        cast := (*m.GetCode()).String()
        err := writer.WriteStringValue("code", &cast)
        if err != nil {
            return err
        }
    }
    {
        err := writer.WriteStringValue("description", m.GetDescription())
        if err != nil {
            return err
        }
    }
    {
        err := writer.WriteStringValue("details", m.GetDetails())
        if err != nil {
            return err
        }
    }
    {
        err := writer.WriteStringValue("stacktrace", m.GetStacktrace())
        if err != nil {
            return err
        }
    }
    if m.GetTypeEscaped() != nil {
        cast := (*m.GetTypeEscaped()).String()
        err := writer.WriteStringValue("type", &cast)
        if err != nil {
            return err
        }
    }
    return nil
}
func (m *CmpErrorResponse) SetCode(value *CmpErrorCode)() {
    m.code = value
}
func (m *CmpErrorResponse) SetDescription(value *string)() {
    m.description = value
}
func (m *CmpErrorResponse) SetDetails(value *string)() {
    m.details = value
}
func (m *CmpErrorResponse) SetStacktrace(value *string)() {
    m.stacktrace = value
}
func (m *CmpErrorResponse) SetTypeEscaped(value *CmpErrorType)() {
    m.typeEscaped = value
}
// CmpErrorResponseable
type CmpErrorResponseable interface {
    i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91.Parsable
    GetCode()(*CmpErrorCode)
    GetDescription()(*string)
    GetDetails()(*string)
    GetStacktrace()(*string)
    GetTypeEscaped()(*CmpErrorType)
    SetCode(value *CmpErrorCode)()
    SetDescription(value *string)()
    SetDetails(value *string)()
    SetStacktrace(value *string)()
    SetTypeEscaped(value *CmpErrorType)()
}

These then never get set to hold the values of the actual response headers in the throwIfFailedResponse method (at least in our case).
I was able to set them afterwards using reflection like this:
err = errValue.(error)
spanForAttributes.RecordError(err)
errRef := setApiErrorResponse(err, response, responseHeaders)
if errRef != nil {
		// Handle the error
		return err
}
return err

func setApiErrorResponse(errValue error, response *nethttp.Response, responseHeaders *abs.ResponseHeaders) error {
	val := reflect.ValueOf(errValue).Elem() // Elem returns the value that the pointer 'errValue' points to

	// Check if the struct has the field 'ApiError'
	apiErrorField := val.FieldByName("ApiError")
	if !apiErrorField.IsValid() {
		return &abs.ApiError{
			Message:            "ApiError field could not be set",
			ResponseStatusCode: response.StatusCode,
			ResponseHeaders:    responseHeaders,
		}
	}

	// Construct the ApiError we want to set
	apiError := abs.ApiError{
		ResponseStatusCode: response.StatusCode,
		ResponseHeaders:    responseHeaders,
	}

	// Set the field - this requires that the field is settable (exported)
	if apiErrorField.CanSet() {
		apiErrorField.Set(reflect.ValueOf(apiError))
	} else {
		return &abs.ApiError{
			Message:            "ApiError field could not be set",
			ResponseStatusCode: response.StatusCode,
			ResponseHeaders:    responseHeaders,
		}
	}

	return nil
}

I don’t think it is ideal but I was able to set the proper response headers that way.

Thanks for the additional information @nerdjeremia
You are correct, the request adapter should be setting the headers here like it does at line 800
https://github.com/microsoft/kiota-http-go/blob/243b44c14bc67e132e140d5d2c43b4e4caba8a2f/nethttp_request_adapter.go#L811
I don't think there's a need for reflection, a type assertion should be enough like we're doing above.
Would you be willing to submit a pull request to correct the issue?

Thanks for the reply.
Yes I can fix the issue but I don't think using type assertion will work since the error returned at the end is of a custom type from the generated code which will be different for everyone I guess.
I think we can either use reflection or pass the response headers through all the functions to where the new ApiError gets created.

Something you might not have noticed is that all custom errors inherit from ApiError. So type assertions should work (pointer to pointer)

Am I missing something?
This is what I tried:
err = errValue.(error)
test := err.(*abs.ApiError)
test.ResponseHeaders = responseHeaders

Right, because it's actually one of the member types that's an API error.
What if we:

introduced an ApiErrorable interface at the abstractions level
had two methods (SetResponseHeaders, SetStatusCode) defined in the interface
had ApiError implement those methods
use that interface for the type assertion here
(because custom error types derive from API error, they should match that interface)

Thoughts?

Sounds like a plan I will take a look

Hi @baywet,
I tested it locally and it worked! Thanks for the suggestion.
I opened a PR in the abstractions repo: https://github.com/microsoft/kiota-abstractions-go/pull/123
After that I will create a PR in this repo to fix the issue.


WebSocketServer

Trying to upload the ws2812_controller code to the ESP8266 gives an error that no such file or directory can be found for  #include<WebSocketServer.h>. Is there another library or Github file that needs to be installed for this?

Apologies, issue was already solved in a closed thread.


Add solutions of already solved c# task sheets

Describe the task
Add solutions of already solved task sheets.
Steps
Steps to do:

ctrl + c and ctrl + v

42ae81d


Delete mention of nonexistent watcherPath param

Hi @viispade, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

thanks!


Update iniLabs -> iniVation. Use newest libcaer 3.2.0, requires new firmware/logic.

Update iniLabs -> iniVation. Use newest libcaer 3.2.0, requires new firmware/logic.

@supitalp can you ptal?

Thanks for reverting to CMake 3.10 Luca. I will test that asap and merge.


Bank::unix_timestamp_from_genesis use saturating math

Problem

unix_timestamp_from_genesis will panic if the multiplication overflows
In many tests we use new_no_wallclock_throttle_for_tests which will set ns_per_tick = u128::MAX
In all these tests, the multiplication will overflow if the function is called
This was found in #1260 when logs were enabled in the test_write_persist_loaded_addresses test

Summary of Changes

Make unix_timestamp_from_genesis use saturating math to avoid overflows
For real values of ns_per_tick we should be unlikely to ever hit the overflow; on mnb:

ns_per_slot = 400000000
u128::MAX / ns_per_slot = 8.507059173023461586584365185794205286375 × 10^29

so if agave's still around well after the sun has died we'll have to come up with a better fix
Fixes #

thank you for fixing this one! 🫶 LGTM, but I'll wait for @ryoqun to have a chance to look at it!

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.1%. Comparing base (ad12ea3) to head (e12ccd3).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #1290     +/-   ##
=========================================
- Coverage    82.1%    82.1%   -0.1%
=========================================
  Files         893      893
  Lines      236936   236934      -2
=========================================
- Hits       194705   194700      -5
- Misses      42231    42234      +3


fix(timestamp): fixes timestamp bug

:tada: This PR is included in version 1.39.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Multi party-trend x.domain() bug with undefined election dates

undefined

Nevermind, wasn’t a bug, just what it looks like when Danish media go absolutely bonkers with daily polls.


allow_net_admin unsupported in gke-cluster-autopilot

Unable to enable NET_ADMIN feature in autopilot module

expose allow_net_admin in google_container_cluster
add variable for  allow_net_admin  to gke-cluster-autopilot

Feature in magic modules
Code Example
# gke-cluster-autopilot/main.tf
resource "google_container_cluster" "cluster" {
  provider        = google-beta
  project         = var.project_id
  name            = var.name
  description     = var.description
  location        = var.location
  allow_net_admin = var.allow_net_admin
  node_locations = (
    length(var.node_locations) == 0 ? null : var.node_locations
  )
...

# gke-cluster-autopilot/variables.tf
variable "allow_net_admin" {
  description = "Whether to enable NET_ADMIN feature."
  type        = bool
  default     = false
}

This field was added in version 4.76.0 of the provider

Can I be given permission to raise this as a pull request?

Please do, you don't need any permissions to open a PR.

Ive been unable to push my branch eunanhardy/add-net-admin-autopilot. keeps telling me I dont have permission and should fork. Ive verified that I am logged in on all git clients and tried multiple times any suggestions?

Yes, create a fork and submit your pull request from there.


Wrong area cropped when the image doesn't fill the whole available space

Cropper keeps cropping the wrong area and sometimes crashes with width <= 0 for me.
The issue seems to be that I used a fixed ratio image and a layout that leaves empty space left and right of the image. Cropper doesn't seem to take that into account.
Here is the repro. Edit activity_main.xml in the edmondo sample to include the following code snippet:
<com.edmodo.cropper.CropImageView
android:id="@+id/CropImageView"
android:layout_width="match_parent"
android:layout_height="150dp"
android:layout_marginTop="@dimen/content_padding"
android:adjustViewBounds="true"
android:scaleType="centerInside"
android:src="@drawable/butterfly" />
Notice that the layout is constraint to 150dp. This causes the image to not fill the entire width (match_parent). The cropping seems to be offset by that blank space.

For my test case, line 273 in CropImageView has this value in the debugger:
final float transX = matrixValues[Matrix.MTRANS_X]; // transX: 125.0
Line 277 sets bitmapLeft to 0. I I override that to -125 (negative of transX), the correct image is cropped.
final float bitmapLeft = (transX < 0) ? Math.abs(transX) : 0;
There is the following comment. There seems to be a special case left or top edge is outside the bounds.
// Ensure that the left and top edges are not outside of the ImageView bounds.
Naively, I'd think that the correct code for line 277 is the following. The Matrix describes the transform. Whatever horizontal displacement happened during the transform should be reverted. However, I don't know what special cases the current code is trying to correct.
final float bitmapLeft = -transX;

Is this fixed on some version?
I got it on both 1.0.1 and on 2.0.0

I have a feeling that this project is dead. There is another project with almost the same name that's much more active. That project doesn't have this issue.
https://github.com/ArthurHub/Android-Image-Cropper

ok thanks

        make  CropImageView  init with the width and height of bitmap：

set ViewGroup.LayoutParams

I have a feeling that this project is dead. There is another project with almost the same name that's much more active. That project doesn't have this issue.
https://github.com/ArthurHub/Android-Image-Cropper

thanks 👍


Update completion-provider.js

Hi @iofjuupasli there has been a recent massive refactoring (it has been a long time coming).
Unfortunately that has caused conflict to your PR.
I've taken your changes and made a commit with acknowledgement of your contribution: #107
Please do review it, cheers.


Export a base Component class

Exports the GOVUKFrontendComponent class as Component, making it available to use as base for components outside of GOV.UK Frontend.
Updates tests and JSDoc to reflect.
Closes #5327

From a developer perspective, looks good to me.


How to get collision information between agent and scene?

Habitat-Sim version
vx.x.x
Habitat is under active development, and we advise users to restrict themselves to stable releases. Are you using the latest release version of Habitat-Sim? Your question may already be addressed in the latest version. We may also not be able to help with problems in earlier versions because they sometimes lack the more verbose logging needed for debugging.
Main branch contains 'bleeding edge' code and should be used at your own risk.
Docs and Tutorials
Did you read the docs? https://aihabitat.org/docs/habitat-sim/
Did you check out the tutorials? https://aihabitat.org/tutorial/2020/
Perhaps your question is answered there. If not, carry on!
❓ Questions and Help
We try to use ContactPointData,
but it doesn't work.
Is there anything wrong with the way we used or we should use other sensor ? Thank you very much!

Hey, @hpf9017, I'd need to see how you use it to know if there is an issue or bug.
FYI: the ContactPointData should be updated by calls to Simulator.step_world() and Simulator.perform_discrete_collision_detection().
It can be queried with Simulator.get_physics_contact_points().
It should contain any contacts recorded by Bullet collision detection between active collision shapes as specified by the configured collision groups (see CollisionGroupHelper).


Upgrading material-dialogs version and adding checkBoxPrompt to picker

I needed the checkbox prompt functionality, so I upgraded the library version and included the checkbox information on the callback of the picker.
Maybe it could be implemented in a more generic way, to all the callbacks. Tell me what you think about it.

This is super duper cool!! Thank you! I will check this out tomorrow, very excited to update the types and API with support for this! Thanks for your initial work!!

Taking a quick look, I think this would be an option we would add to OptionsCommon - https://github.com/aakashns/react-native-dialogs#type-optionscommon
We would add possibly two keys:

optional boolean option called shouldShowCheckbox? - falsy doesnt show
optional boolean option called defaultCheckboxValue? - only works if shouldShowCheckbox is truthy.

Or is it better to start options with same prefix, so people know its related. So checkboxShouldShow and checkboxDefaultValue?
And whenever this is set to true, the action promise resolves with boolean value of isChecked? (or checkboxIsChecked?)

Hey @felipemartim when trying to merge this to here, then merge it to aakashns/react-native-dialogs I messed it up. It was not auto merging anymore.
They merged my patch-4 to master just the other day. May you please check out master from https://github.com/aakashns/react-native-dialogs and then submit these changes there please. I'll then join submit a PR to your PR to add in the types and javascript api support.

May you please check out master from https://github.com/aakashns/react-native-dialogs and then submit these changes there please
Sure! I also tried to create the PR directly into the original repository, but it wouldn't merge nicely. Later today I'll do that.

It seems that "checkbox" is supported by input type, plain type, and list type dialogs. Would be awesome if you could add it to all 3! :)

Sorry, I'm just too swamped right now, but I believe I can do that by next week.

Hey @felipemartim - no pressure or rush, I was just excited to get this functionality it. Just curious on what your schedule looks like?


Refresh

Re-render with conda-smithy version 2.4.5. Package the license file. Switch to using a stronger checksum (sha256 instead of md5). Bumps build number to 1 to get a build with the license file.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


[MKLDNN] Support quantized rnn towards v1.6.x

Description
Mirror PR of #18001, towards v1.6.x branch. In this PR, we add support of quantization flow of the rnn operator. Currently, only the LSTM mode supports INT8 inference.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Add _contrib_quantized_rnn op.
[x] Add asymmetric quantization - _contrib_quantized_asym op, to quantize FP32 data to U8 data using scale and shift.
[x] Add MXNET_USE_WEIGHT_CACHE to control rnn init behavior.
[x] Support data layout in NDArrayIter. Specifically, NDArrayIter supports only NCHW layout by default, and there is no way to support other layouts, like sequential TNC layout. This PR makes some changes to NDArrayIter to leverage the feature (assuming that N represents the batch).
[x] Move MKLDNNRnnMemMgr to individual layer.

##Comments##

Performance results will be added to #18001.

@ciyongch @TaoLv @pengzhao-intel

@mxnet-label-bot add [mkldnn]

Accuracy and performance: https://github.com/apache/incubator-mxnet/pull/18001#issuecomment-612741705

CI checks passed. Please take a review. @ciyongch @TaoLv @pengzhao-intel

LGTM for the current implementation, but we still need another DNNL patch (or DNNL version upgrade) to mitigate the overhead of _contrib_quantize_asym operator.

LGTM for the current implementation, but we still need another DNNL patch (or DNNL version upgrade) to mitigate the overhead of _contrib_quantize_asym operator.

Sure, let's wait for the patch.

LGTM for the current implementation, but we still need another DNNL patch (or DNNL version upgrade) to mitigate the overhead of _contrib_quantize_asym operator.

Thanks, we can upgrade DNNL a little later and I will merge this PR for early testing.


“Copy name” and more actions when browsing code

... button in right nav when browsing dir
Replace right bar nav with ... button when viewing code
Add following options:

“Copy path”
“Copy name”
“Share URL”
“Share content” (field only)

Sent with GitHawk

I can start work on this. and assuming you meant files only instead of field only?


Update README.md to specify report output

Fixes Issue
The location of the reports was not specified. Previously, all reports were sent to the location of the scan.
Description of Change
Add support for location of scan results.
Please add a description of the proposed change
Have test cases been added to cover the new functionality?
yes/no

Can one of the admins verify this patch?

Thanks for the PR


Fix import issue for @/lib/utils in frontend

Problem
The frontend was encountering runtime errors due to missing imports from @/lib/utils. The problem was from the root .gitignore including "/lib" which was probably not meant for the frontend directory, so the frontend's lib folder wasn't tracked.
Solution
I've added the folder "library" (instead of "lib" so the root gitignore doesn't interfere with the frontend files) and added utils.ts that folder.
Changes made
Added library/utils.ts, and replaced all @/lib/utils imports with @/library/utils
Testing
I've tested these changes locally and confirmed that:
The build process completes without errors.
Imports using @/library/utils now work correctly.
Git is tracking the utils.ts file as expected.

Good catch!


[SSoC 2.0] FAQ Template Website Ready

Title - FAQ Accordion
Issue Number - 427
close issue #427

Screenshot

@Avdhesh-Varshney please attach the working video in README.md file and here in conversation section too.

@shubhisingh184 @Vikash-8090-Yadav sir, please again review this pr
Working Video

https://github.com/Vikash-8090-Yadav/Future.WebNet/assets/114330097/90a0d095-d9aa-45c6-812e-e03107299232


KongConsumer Secrets being required to exist before the KongConsumer causes some friction for deployments

Current Behavior
Prior to v2.x of the ingress controller we had the problem #729 wherein the data-plane can become completely locked up when KongConsumers with reference Secret credentials were configured in such a way that was in violation of unique constraints in the Kong Gateway (from our purposes here, the "data-plane").
#2015 attempted to correct for this in the validation webhook, however in order to do more complete prevention it added the requirement that any Secret that is referenced must exist prior to the KongConsumer. This requirement causes some friction with deployments and goes against the grain of object references in Kubernetes, while also effectively avoiding the data-plane lockup rooted in consumer credential unique constraint violations.
The purpose of this issue is to improve upon the solution to the original problem so that we can still avoid data-plane lockups, but without having to force users to split their manifests into stages as this is a bit unnatural for Kubernetes operations (save perhaps with CRDs, but we want to avoid having our KongConsumers working anything like CRDs).
Expected Behavior
When I deploy a manifest containing KongConsumers which reference Secret credentials, and also contains the Secret objects themselves I should get a successful apply and not have to consider order of operations.
Kong Ingress Controller version
v2.x.x and up

Kubernetes version
any

We're currently tracking this issue in https://github.com/Kong/kubernetes-ingress-controller/issues/2195 as something that should be resolved by that related feature.

Closing in favor of #2195


OCW-2 Merge

Some tweaks to the Kurdistan theme, and the fix for Google's latest version of oauth2client library.

Coverage increased (+0.03%) to 69.65% when pulling 3a185d6921e3f08da505352e4aac2a7edccc9e27 on master into 10c9742e98dbd732d43dd71729f410ca0c763cab on production.

Coverage increased (+0.03%) to 69.65% when pulling 9079f413e98dfcc61824227d5fa1c37c1a5b0173 on master into 10c9742e98dbd732d43dd71729f410ca0c763cab on production.


Additional options requried

On Windows, I added these options to "phantom.create(function (ph) { .. }" to overcome a couple of errors (module weak not found; security issue).
,{
        dnodeOpts: {
            weak: false
        },
        parameters:{
            'web-security': 'no'
        }
  }

+1
I need those options too, it would be great to be able to set phantomjs options when using this gulp plugin


Issue/dict path improvs (#7789)

Pull request opened by the merge tool on behalf of #7789

Merged into branches iso7 in d37275418708a1df7bb5511500093709a82fe7d9


Enable key mappings in select mode

Thanks for your awesome plugin.
I'm currently using this plugin with the configuration from lspconfig and I encountered a problem with snippet completion.
Some snippets have placeholders, when the completion plugin jumps to the placeholder, neovim will get into SELECT mode. Then I can overwrite the placeholder. In some cases, I want to just jump to another snippet node leaving the placeholder unchanged. I found all key mappings don't work in select mode. I wonder if there is a way to enable key mappings in select mode.

@dragove You can specify modes for mapping.
cmp.setup {
  mapping = {
    ['<Tab>'] = cmp.mapping(cmp.mapping.select_next_item(), { 'i', 's' }),
  }

or
cmp.setup {
  mapping = {
    ['<Tab>'] = cmp.mapping({
      i = cmp.mapping.select_next_item(),
      s = cmp.mapping.select_next_item(),
    }),
  }

It works, thanks. For the ones who come for solution, can consider below config:
cmp.setup {
  mapping = {
    ['<Tab>'] = cmp.mapping(function(fallback)
      if cmp.visible() then
        cmp.select_next_item()
      elseif luasnip.expand_or_jumpable() then
        luasnip.expand_or_jump()
      else
        fallback()
      end
    end, { 'i', 's' }),
    ['<S-Tab>'] = cmp.mapping(function(fallback)
      if cmp.visible() then
        cmp.select_prev_item()
      elseif luasnip.jumpable(-1) then
        luasnip.jump(-1)
      else
        fallback()
      end
    end, { 'i', 's' })
  }
}


OAuth2 Provider Requires Scope (not Scopes) to be passed to the token service

Hello,
We are working on setting up our VC-API Implementation to use OAuth2 security. Our security provider (Azure AD) requires scope to be passed in addition to audience. Has anyone encounter a similar requirement where scope need to be passed to authenticate?
In the VC Implementation code. https://github.com/w3c-ccg/vc-api-test-suite-implementations/blob/main/lib/oauth2.js. We see scopes as an option, but that does not work for Azure AD. Our proposed changes would be to update this code to look for scope in addition to scopes.
Thoughts?

The mesur.io implementation requires scope as well, you may be able to format your config following our example.

Thanks, I look through the mesur.io implementation and they are passing scopes to their issuers and verifiers . We need to pass scope to OAuth2 provider.

@tsnyder-gs1us Yes, we specify scope in the "issuers" and "verifiers" configuration sections. These scopes are passed through to the token request endpoint when getting new auth tokens for those purposes - the problem here as you pointed out is that the code was using scopes instead of scope in the request body for the token. I've proposed a PR to fix.

Assigning @aljones15 to fix this issue in the test suite code. We'll let you know when we have a new version with the fix deployed @tsnyder-gs1us and @brownoxford.


Submit all chat messages to results

While we're at it already, you could help me with another thing ;)
When working with the Chat component, I want submit all the chat messages of one trial/chat to the results as a list (As shown below).

However, my current method is super clumsy and I'm sure that there are way more elegant methods to solve this.
For my first tries, I tweaked the Chat component, such that I can reference the chatbox, and then extract all the messages from it:
methods: {
    submit_chat() {
      var container = [];
      for(var i=0; i<document.getElementById('chatbox_1').children.length; i++){
        var msg = document.getElementById('chatbox_1').children[i];
        var msg_text = msg.textContent;
        container.push(msg_text);
      }
      this.$magpie.addResult({ question: this.$magpie.currentTrial.QUD, answer: container});
      }
  }

Can you maybe give me a hint on how to access the messages variable from the Chat component directly/ how to improve this?
I think it would be nice to have an inbuilt function which does this automatically.
It would be also great to add the participant ID to this to distinguish between chat message authors, e.g. like:
container = [ "1 --- hey", "2 --- hello", "1 --- what's up", "2 --- nothing" ]

But I think this will be somewhat annoying with the method I'm currently using.,.

Good point! I've just added an event to the component, so you can use it as follows:
	  <Screen>
        <template #0="{responses}">
          <Chat :messages.sync="responses.messages"></Chat>
          <button
            @click="
              $magpie.addTrialData(responses);
              $magpie.nextScreen();
            "
          >
            Next
          </button>
        </template>
      </Screen>

Note that this hasn't been released and that there have been significant changes to the API since the last release (eg. renaming addResult to addTrialData)

Great! Thanks @marcelklehr!
I'll look out for the next release then...


Can Paddle implement a time domain and frequency domain input PANNs of Cnn14

Feature Request
Currently, Paddle only has the frequency domain input version of PANNs, but Python sometimes has both domain and frequency domain input versions of PANNs. I want to test whether time domain input can bring benefits to the service in Paddle
model file:https://zenodo.org/record/3987831
code:https://github.com/qiuqiangkong/audioset_tagging_cnn

收到，后续我们会排期，增加这个feature


fix(deps): update terraform terraform-ibm-modules/cbr/ibm to v1.24.0

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cbr/ibm (source)
module
minor
1.23.5 -> 1.24.0

Release Notes

terraform-ibm-modules/terraform-ibm-cbr (terraform-ibm-modules/cbr/ibm)
v1.24.0
Compare Source
Features

updated fscloud module to optionally take list of location for zones (#472) (478f5fb)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

:tada: This issue has been resolved in version 2.11.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


pt 2.0: Prompt object is very different to be subclassed

At the 2.0 branch, I found that the Prompt is very difficult to be subclassed because the whole app and layout are computed in one big function _create_application. It would be nice to dissect this function into smaller pieces to allow more customizability. For instance, I really want to customize the layout in some way, but it is currently quite impossible.

Good point. I'll see what I can do.

_create_application creates a bunch of objects. I think it would be better to have a _create_... for each object. In other words, _create_application should only create the Application (https://github.com/randy3k/Rice/blob/62e6518e248b3d9ba90c6da468b9a438ef8efc5c/rice/deps/prompt_toolkit/shortcuts/prompt.py#L468), and call other methods (or take in arguments) to create the other objects, like _create_layout, _create_buffer, and so on.


Add/Change import and annotations

Good afternoon
I am trying to create a recipe to migrate from SpringFox to OpenApi 3, and I have some doubts, is there any recipe to add or change "import"? and is there any recipe to add or change annotations at class or method level?
Thank you very much for everything

hi @josemariavillar
A SpringFox -> OpenApi 3 recipe sounds very interesting, if you would like some help sorting out some of these details, we can schedule some time to do some pair programming.
As for your questions:
There is an AddImport recipe that can handle both normal and static imports. In fact, this recipe/visitor is also aware of import styles and will insert the import in the correct location and also handle things like folding imports into a *.
The inverse of this is the RemoveImport which is style-aware and also will manage things like unfolding imports from a "*".
The good news with these two visitors is that there are helper methods on the JavaVisitor to make this relatively painless:

These methods will only add an import if the type is actually in use within the compilation unit.
As for adding/changing an annotation, there is no dedicated recipe for this however, this can be easily accomplished using the JavaTemplate
The template allows you to write a small snippet of code (as text) which is then compiled into an AST. It then uses a coordinate system to either insert or replace the newly generated elements into your existing AST.
There are good examples of how this can be accomplished in the JavaTemplateTest:

The first time you use JavaTemplate, it can be a bit overwhelming, we have some guides in our documentation to help you get started: https://docs.openrewrite.org/tutorials/modifying-methods-with-javatemplate
This will cover things like the coordinate system and introducing new types into your template.

thank you very much for everything


chore(revm): separate post state crate

Move post state to a separate crate under revm/

PostState is supposed to be generic, moving it to the revm crate doesnt make sense to me

@onbjerg posting response here for clarity as well. PostState is for aggregating execution results. currently, we are fine moving it under revm until we decide on the direction we take with generic executors

Codecov Report

Merging #2289 (c8c91e4) into main (db1e6cb) will decrease coverage by 0.03%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #2289      +/-   ##
==========================================
- Coverage   72.19%   72.16%   -0.03%
==========================================
  Files         472      472
  Lines       57068    57069       +1
==========================================
- Hits        41200    41186      -14
- Misses      15868    15883      +15

Flag
Coverage Δ

integration-tests
19.15% <ø> (-0.01%)
:arrow_down:

unit-tests
66.84% <ø> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/blockchain-tree/src/blockchain_tree/mod.rs
89.83% <ø> (ø)

...kchain-tree/src/blockchain_tree/post_state_data.rs
0.00% <ø> (ø)

crates/blockchain-tree/src/lib.rs
100.00% <ø> (ø)

crates/blockchain-tree/src/test_utils/executor.rs
50.00% <ø> (ø)

crates/blockchain-tree/src/test_utils/factory.rs
71.42% <ø> (ø)

crates/payload/basic/src/lib.rs
0.30% <ø> (ø)

crates/revm/revm-post-state/src/lib.rs
89.81% <ø> (ø)

crates/revm/src/executor.rs
89.62% <ø> (ø)

crates/revm/src/lib.rs
100.00% <ø> (ø)

crates/stages/src/stages/execution.rs
93.49% <ø> (ø)

... and 7 more

... and 7 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I think let's let Bjerg own the PostState-related refactors as it interacts with his work? Or is this something that's blocking you Roman?

alright, i made a workaround for my circular dependency. closing for now


[FEATURE] Add support for inclusive naming

Add support for inclusive naming by deprecating the master nomenclature.
See meta issue https://github.com/opensearch-project/opensearch-clients/issues/16 for details.

@VachaShah combing through the code, I don't see any references of master or whitelist. Is there anything else I should be looking for?

@harshavamsi That should be all. Since this is a high level client, there might not be any such references.