YARN-9834. Allow using a pool of local users to run Yarn Secure Conta…

…iner in secure mode
Signed-off-by: Shanyu Zhao<EMAIL_ADDRESS>https://issues.apache.org/jira/browse/YARN-9834

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
2157
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
45
Maven dependency ordering for branch

+1
mvninstall
1113
trunk passed

+1
compile
557
trunk passed

+1
checkstyle
90
trunk passed

+1
mvnsite
110
trunk passed

+1
shadedclient
892
branch has no errors when building and testing our client artifacts.

+1
javadoc
88
trunk passed

0
spotbugs
93
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
208
trunk passed

_ Patch Compile Tests _

0
mvndep
19
Maven dependency ordering for patch

-1
mvninstall
24
hadoop-yarn-server-nodemanager in the patch failed.

-1
compile
79
hadoop-yarn in the patch failed.

-1
javac
79
hadoop-yarn in the patch failed.

-0
checkstyle
73
hadoop-yarn-project/hadoop-yarn: The patch generated 19 new + 382 unchanged - 1 fixed = 401 total (was 383)

-1
mvnsite
25
hadoop-yarn-server-nodemanager in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedclient
265
patch has errors when building and testing our client artifacts.

-1
javadoc
28
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 9 new + 0 unchanged - 0 fixed = 9 total (was 0)

-1
findbugs
27
hadoop-yarn-server-nodemanager in the patch failed.

_ Other Tests _

-1
unit
52
hadoop-yarn-api in the patch failed.

-1
unit
26
hadoop-yarn-server-nodemanager in the patch failed.

-1
asflicense
31
The patch generated 1 ASF License warnings.

6146

Reason
Tests

Failed junit tests
hadoop.yarn.conf.TestYarnConfigurationFields

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1446

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux eaaeab1ea91e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 6a9f7ca

Default Java
1.8.0_222

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/1/artifact/out/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/1/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/1/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/1/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/1/artifact/out/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/1/artifact/out/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/1/artifact/out/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/1/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/1/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
415 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
18
Maven dependency ordering for branch

+1
mvninstall
1197
trunk passed

+1
compile
560
trunk passed

+1
checkstyle
86
trunk passed

+1
mvnsite
114
trunk passed

+1
shadedclient
891
branch has no errors when building and testing our client artifacts.

+1
javadoc
77
trunk passed

0
spotbugs
85
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
210
trunk passed

_ Patch Compile Tests _

0
mvndep
17
Maven dependency ordering for patch

+1
mvninstall
76
the patch passed

+1
compile
529
the patch passed

+1
javac
529
the patch passed

-0
checkstyle
82
hadoop-yarn-project/hadoop-yarn: The patch generated 31 new + 382 unchanged - 1 fixed = 413 total (was 383)

+1
mvnsite
90
the patch passed

-1
whitespace
0
The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1
shadedclient
749
patch has no errors when building and testing our client artifacts.

+1
javadoc
74
the patch passed

-1
findbugs
95
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1
unit
57
hadoop-yarn-api in the patch failed.

-1
unit
1348
hadoop-yarn-server-nodemanager in the patch failed.

-1
asflicense
47
The patch generated 1 ASF License warnings.

6525

Reason
Tests

FindBugs
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Possible doublecheck on org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.instance in org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.getInstance(Configuration)  At SecureModeLocalUserAllocator.java:org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.getInstance(Configuration)  At SecureModeLocalUserAllocator.java:[lines 84-86]

Failed junit tests
hadoop.yarn.conf.TestYarnConfigurationFields

hadoop.yarn.server.nodemanager.TestNodeManagerReboot

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1446

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a77206a24c7f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e04b8a4

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/2/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/2/artifact/out/whitespace-eol.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/2/artifact/out/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/2/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/2/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/2/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/2/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
1121
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
43
Maven dependency ordering for branch

+1
mvninstall
1027
trunk passed

+1
compile
490
trunk passed

+1
checkstyle
87
trunk passed

+1
mvnsite
104
trunk passed

+1
shadedclient
891
branch has no errors when building and testing our client artifacts.

+1
javadoc
84
trunk passed

0
spotbugs
83
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
187
trunk passed

_ Patch Compile Tests _

0
mvndep
18
Maven dependency ordering for patch

+1
mvninstall
70
the patch passed

+1
compile
443
the patch passed

+1
javac
443
the patch passed

-0
checkstyle
85
hadoop-yarn-project/hadoop-yarn: The patch generated 30 new + 381 unchanged - 1 fixed = 411 total (was 382)

+1
mvnsite
97
the patch passed

-1
whitespace
0
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1
shadedclient
752
patch has no errors when building and testing our client artifacts.

+1
javadoc
79
the patch passed

-1
findbugs
92
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1
unit
62
hadoop-yarn-api in the patch failed.

-1
unit
1310
hadoop-yarn-server-nodemanager in the patch failed.

-1
asflicense
51
The patch generated 1 ASF License warnings.

7264

Reason
Tests

FindBugs
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Possible doublecheck on org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.instance in org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.getInstance(Configuration)  At SecureModeLocalUserAllocator.java:org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.getInstance(Configuration)  At SecureModeLocalUserAllocator.java:[lines 85-87]

Failed junit tests
hadoop.yarn.conf.TestYarnConfigurationFields

hadoop.yarn.server.nodemanager.TestNodeManagerReboot

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1446

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux e71c484ed9f0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e04b8a4

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/whitespace-eol.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/3/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
442 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
42
Maven dependency ordering for branch

+1
mvninstall
1033
trunk passed

+1
compile
496
trunk passed

+1
checkstyle
90
trunk passed

+1
mvnsite
103
trunk passed

+1
shadedclient
903
branch has no errors when building and testing our client artifacts.

+1
javadoc
85
trunk passed

0
spotbugs
85
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
188
trunk passed

_ Patch Compile Tests _

0
mvndep
41
Maven dependency ordering for patch

+1
mvninstall
74
the patch passed

+1
compile
444
the patch passed

+1
javac
444
the patch passed

-0
checkstyle
88
hadoop-yarn-project/hadoop-yarn: The patch generated 30 new + 382 unchanged - 1 fixed = 412 total (was 383)

+1
mvnsite
97
the patch passed

-1
whitespace
0
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1
shadedclient
751
patch has no errors when building and testing our client artifacts.

+1
javadoc
80
the patch passed

-1
findbugs
91
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1
unit
60
hadoop-yarn-api in the patch failed.

-1
unit
1317
hadoop-yarn-server-nodemanager in the patch failed.

-1
asflicense
49
The patch generated 1 ASF License warnings.

6245

Reason
Tests

FindBugs
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Possible doublecheck on org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.instance in org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.getInstance(Configuration)  At SecureModeLocalUserAllocator.java:org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.getInstance(Configuration)  At SecureModeLocalUserAllocator.java:[lines 85-87]

Failed junit tests
hadoop.yarn.conf.TestYarnConfigurationFields

hadoop.yarn.server.nodemanager.TestNodeManagerReboot

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1446

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 027e04a0ef2c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 2358e53

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/4/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/4/artifact/out/whitespace-eol.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/4/artifact/out/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/4/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/4/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/4/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/4/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
48
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
42
Maven dependency ordering for branch

+1
mvninstall
1314
trunk passed

+1
compile
657
trunk passed

+1
checkstyle
96
trunk passed

+1
mvnsite
108
trunk passed

+1
shadedclient
1065
branch has no errors when building and testing our client artifacts.

+1
javadoc
84
trunk passed

0
spotbugs
96
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
213
trunk passed

_ Patch Compile Tests _

0
mvndep
18
Maven dependency ordering for patch

+1
mvninstall
81
the patch passed

+1
compile
490
the patch passed

+1
javac
490
the patch passed

-0
checkstyle
87
hadoop-yarn-project/hadoop-yarn: The patch generated 32 new + 382 unchanged - 1 fixed = 414 total (was 383)

+1
mvnsite
98
the patch passed

-1
whitespace
0
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1
shadedclient
899
patch has errors when building and testing our client artifacts.

+1
javadoc
77
the patch passed

-1
findbugs
94
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1
unit
62
hadoop-yarn-api in the patch failed.

+1
unit
1333
hadoop-yarn-server-nodemanager in the patch passed.

-1
asflicense
50
The patch generated 1 ASF License warnings.

7083

Reason
Tests

FindBugs
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Possible doublecheck on org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.instance in org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.getInstance(Configuration)  At SecureModeLocalUserAllocator.java:org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.getInstance(Configuration)  At SecureModeLocalUserAllocator.java:[lines 91-93]

Failed junit tests
hadoop.yarn.conf.TestYarnConfigurationFields

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1446

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 0eca54961b92 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / b7ae8a9

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/5/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/5/artifact/out/whitespace-eol.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/5/artifact/out/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/5/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/5/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/5/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
413 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
53
Maven dependency ordering for branch

+1
mvninstall
1213
trunk passed

+1
compile
527
trunk passed

+1
checkstyle
91
trunk passed

+1
mvnsite
89
trunk passed

+1
shadedclient
1003
branch has no errors when building and testing our client artifacts.

+1
javadoc
67
trunk passed

0
spotbugs
81
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
188
trunk passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
72
the patch passed

+1
compile
482
the patch passed

+1
javac
482
the patch passed

-0
checkstyle
87
hadoop-yarn-project/hadoop-yarn: The patch generated 37 new + 384 unchanged - 1 fixed = 421 total (was 385)

+1
mvnsite
84
the patch passed

-1
whitespace
0
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1
shadedclient
846
patch has no errors when building and testing our client artifacts.

+1
javadoc
63
the patch passed

-1
findbugs
90
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1
unit
55
hadoop-yarn-api in the patch failed.

+1
unit
1286
hadoop-yarn-server-nodemanager in the patch passed.

-1
asflicense
45
The patch generated 1 ASF License warnings.

6561

Reason
Tests

FindBugs
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Possible doublecheck on org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.instance in org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.getInstance(Configuration)  At SecureModeLocalUserAllocator.java:org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.getInstance(Configuration)  At SecureModeLocalUserAllocator.java:[lines 115-117]

Failed junit tests
hadoop.yarn.conf.TestYarnConfigurationFields

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1446

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux e493854a9eaf 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / f209722

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/6/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/6/artifact/out/whitespace-eol.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/6/artifact/out/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/6/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/6/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/6/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
306 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1446/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 25s
trunk passed

+1 :green_heart:
compile
9m 46s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
8m 42s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
1m 41s
trunk passed

+1 :green_heart:
mvnsite
1m 41s
trunk passed

+1 :green_heart:
shadedclient
19m 41s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 38s
hadoop-yarn-api in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javadoc
0m 41s
hadoop-yarn-server-nodemanager in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
1m 21s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
1m 39s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 47s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 21s
the patch passed

+1 :green_heart:
compile
9m 31s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
9m 31s
the patch passed

+1 :green_heart:
compile
8m 11s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
8m 11s
the patch passed

-0 :warning:
checkstyle
1m 31s
hadoop-yarn-project/hadoop-yarn: The patch generated 40 new + 376 unchanged - 1 fixed = 416 total (was 377)

+1 :green_heart:
mvnsite
1m 29s
the patch passed

-1 :x:
whitespace
0m  0s
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
16m 21s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 38s
hadoop-yarn-api in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javadoc
0m 32s
hadoop-yarn-server-nodemanager in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
1m 10s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

-1 :x:
findbugs
1m 42s
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1 :x:
unit
0m 56s
hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
22m 55s
hadoop-yarn-server-nodemanager in the patch passed.

-1 :x:
asflicense
0m 42s
The patch generated 1 ASF License warnings.

143m 36s

Reason
Tests

FindBugs
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Possible doublecheck on org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.instance in org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.getInstance(Configuration)  At SecureModeLocalUserAllocator.java:org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.getInstance(Configuration)  At SecureModeLocalUserAllocator.java:[lines 115-117]

Failed junit tests
hadoop.yarn.conf.TestYarnConfigurationFields

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1446

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux d6ee547d0006 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e756fe35909

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt

whitespace
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/whitespace-eol.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

findbugs
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/3/testReport/

asflicense
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/3/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
309 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 53s

Maven dependency ordering for branch

-1 :x:
mvninstall
22m 11s
/branch-mvninstall-root.txt
root in trunk failed.

-1 :x:
compile
5m 42s
/branch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
hadoop-yarn in trunk failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
5m 25s
/branch-compile-hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn in trunk failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
checkstyle
1m 38s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m 24s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 34s

trunk passed

+1 :green_heart:
shadedclient
20m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 18s

the patch passed

-1 :x:
compile
5m 38s
/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
hadoop-yarn in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
javac
5m 38s
/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
hadoop-yarn in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
4m 53s
/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
4m 53s
/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
1m 25s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn-project/hadoop-yarn: The patch generated 32 new + 317 unchanged - 1 fixed = 349 total (was 318)

+1 :green_heart:
mvnsite
1m 34s

the patch passed

-1 :x:
javadoc
0m 34s
/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 generated 10 new + 89 unchanged - 10 fixed = 99 total (was 99)

-1 :x:
javadoc
0m 32s
/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 10 new + 196 unchanged - 0 fixed = 206 total (was 196)

-1 :x:
spotbugs
1m 56s
/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
21m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 52s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
23m 34s

hadoop-yarn-server-nodemanager in the patch passed.

-1 :x:
asflicense
0m 36s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

146m 42s

Reason
Tests

SpotBugs
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Possible doublecheck on org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.instance in org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.getInstance(Configuration)  At SecureModeLocalUserAllocator.java:org.apache.hadoop.yarn.server.nodemanager.SecureModeLocalUserAllocator.getInstance(Configuration)  At SecureModeLocalUserAllocator.java:[lines 115-117]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1446

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux dd86caca400e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / beca49dfbf9f9bcedd1346b1a62cfb0905c075fd

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/1/testReport/

Max. process+thread count
698 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1446/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


General/Imaging - How to constrain/exclude not needed information from the common building blocks in the usecase specific situations?

Comparing the eHN guideline to the logical model v1.1 we have found that the model covers 90% of the eHN dataset (the 10% is key image information). However, we do find that the logical model as is, specifically the common building blocks, is much larger and general than required/requested from eHN.
How do we compose a usecase specific dataset, that does not require all of the extra data elements?
What we see now is a mixed approach to build common building blocks in the common tab. And in parallel a usecase specific dataset for the various report bodies. In the imaging report body, for instance, there is a need for only the modality device ID, for this there is a reference made to the building block Device C.12, which includes Device ID. That would be sufficient for the usecase, however inside the building block includes various other elements that were not requested from the eHN guideline.

Code
Cardinality
Data element
Description
Data type
Preferred Code   System

C.12
1..1
Device
Device information
Backbone Element

C.12.1
1..*
Identifier
An   identifier of the device which is unique within in a defined scope. Multiple   identifiers can be used.
Identifier

C.12.2
0..1
Manufacturer
Name of device   manufacturer
string

C.12.3
0..1
Manufacture date
The date and time   when the device was manufactured
dateTime

C.12.4
0..1
Expiry date
The   date and time beyond which this device is no longer valid or should not be   used (if applicable).
dateTime

C.12.5
0..1
Lot number
Lot number of   manufacture
string

C.12.6
0..1
Serial number
Serial number   assigned by the manufacturer
string

C.12.7
0..*
Name
The name and name   type of the device as known to the manufacturer and/or patient
string

C.12.8
0..1
Model number
The manufacturer's   model number for the device
string

C.12.9
0..1
Version
The actual design of   the device or software version running on the device
string

C.12.10
0..*
Type
Device type
Coded
SNOMED CT, EMDN

C.12.11
0..*
Note
Device notes and   comments
Text

So how to proceed? Will we make maximum datasets or how can we constrain building blocks to meet the minimal needs of each usecase? Maybe you can clarify the chosen strategy on this?

Related to #11
Obligations is one way to do that. Worth discussing.

Well, it is quite common that FHIR IG includes more details then logical model requires. Actually, it is also quite common to report details of the device used for imaging procedure including device model and manufacturer. I can provide examples of the report which contains device details.
So, use of the device logical model instead of just a modality code is appropriate to my opinion unless we, for some reason, want to restrict it.
FHIR ig can of course further constrain device resource use. However I do not see the need for this restrictions in the logical model.
Best regards
Hynek
Odesláno z aplikace Outlook pro iOShttps://aka.ms/o0ukef

Od: Rutt Lindström @.>
Odesláno: Monday, December 16, 2024 11:46:14 PM
Komu: Xt-EHR/xt-ehr-common @.>
Kopie: Subscribed @.***>
Předmět: Re: [Xt-EHR/xt-ehr-common] General/Imaging - How to constrain/exclude not needed information from the common building blocks in the usecase specific situations? (Issue #72)
Related to #11https://github.com/Xt-EHR/xt-ehr-common/issues/11
Obligations is one way to do that. Worth discussing.
—
Reply to this email directly, view it on GitHubhttps://github.com/Xt-EHR/xt-ehr-common/issues/72#issuecomment-2547152114, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGNB5D2WZNOFQCLFHPP2B6D2F5Q4NAVCNFSM6AAAAABTWMK5HSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBXGE2TEMJRGQ.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


A11y_A11y_.NETOnlineREPL_Benchmark_.NET Editor_Screen reader: Screen readers does not give more information for the suggestion in the editor.

Environment details:
https://docs.microsoft.com/
Browser: Chromium Edge Version 80.0.361.50 (Official build) (64-bit)
OS Details:Windows 10
GitHubTags:#A11yTCS;#A11ySev2;#A11y_.NETOnlineREPL_Benchmark;#.NET Online REPL;#Benchmark;#DesktopWeb;#Win10;#MAS1.3.1;#Accessibility;#.NET Online REPL;#Narrator;#NVDA;#chromiumEdge;#Chrome;#A11yMAS;
Repro Steps:
1.Hit the URL "https://docs.microsoft.com/" and login with appropriate credentials.
2.Tab till "Enter focus Mode" button and press enter.
3.Start narrator and navigate till the editor and type any alphabets.
4.Observe the narrator readings.
Actual Result:
In the editor section when type aa alphabet there are suggestion but the narrator does not announce the suggestion are updated and it does not give the information to navigate inside the suggestion.
Expected Result:
Narrator must give more instruction to navigate inside the suggestion using Down/Up arrow.
User Impact:
Screen readers users will not understand the suggestions are present they don not understand how to navigate inside all suggestions.
Attachment:
790_A11y_.NETOnlineREPL_.NET Editor_Screen reader.pptx

Closing as external. This is a Monaco issue.

#Closed;


virtual-scroll: attempted to use view after destroyed errors

These occasionally pop up, need to investigate root cause

I am getting these a lot!!!!  As a temporary workaround, I added a simple check to see if the view is destroyed in CdkVirtualForOf._updateContext.  Although this makes my browser console window less red, I imagine there is an underlying problem somewhere else.
Here is my patch:
CdkVirtualForOf.prototype['_updateContext'] = function (this: any) {
    const count = this._data.length;
    let i = this._viewContainerRef.length;
    while (i--) {
        let view = this._viewContainerRef.get(i) as EmbeddedViewRef<CdkVirtualForOfContext<any>>;
        if (!view.destroyed) {
            view.context.index = this._renderedRange.start + i;
            view.context.count = count;
            this._updateComputedContextProperties(view.context);
            view.detectChanges();
        }
    }
}

@grant77 are you seeing this with autosize strategy or fixed size strategy? so far I've only seen it with autosize

Fixed size strategy.

If you're able to create a reproduction I'd love to see it, would probably be easier to debug with the fixed size strategy

I'll try to put something together tomorrow.

Here you go:
https://angular-material2-issue-zdwqlh.stackblitz.io
Note:  My VirtualDataSource is a work in progress.  Basically, I am trying to pull data in chunks from my API as they scroll. You should get  a plethora of errors as you scroll.  The error is:
** ERROR Error: ViewDestroyedError: Attempt to use a destroyed view: detectChanges

Here you go:
https://stackblitz.com/edit/angular-material2-issue-huoqn3
Note: My VirtualDataSource is a work in progress. Basically, I am trying to pull data in chunks from my API as they scroll. You should get a plethora of errors as you scroll. The error is:
** ERROR Error: ViewDestroyedError: Attempt to use a destroyed view: detectChanges

Your welcome.  Thanks for fixing  #12869 so quick.  I have forked the demo above and added three things:

The fix you gave me from #12869 regarding viewChange inside zone.  I removed the setInterval hack.
Uncommented the patch for CdkVirtualForOf._updateContext that suppresses the errors so you can see what I am logging.
tap(data => console.log(data.length)) as last rxjs thing in DataSource to write the data length.

https://stackblitz.com/edit/angular-material2-issue-eeiups
I don't see it logging anything but 10000.

Hmm, ok maybe I'm wrong then. Your data source must be doing something interesting that I'm not capturing.
I tried to make a simpler DataSource for the sake of debugging: https://stackblitz.com/edit/angular-material2-issue-nxvupb?file=app/app.component.ts I noticed that this one is fine if I leave the length constant, but if I uncomment the line randomizing the length and scroll to the end of the list I start to get the same kind of errors. I assumed yours must be having similar issues, but it sounds like maybe something else is going on

This is mind-boggling.  I modified your demo a little bit, and now I can get the errors again, but not as easily as I could with my demo.    Here you go:
https://stackblitz.com/edit/angular-material2-issue-ijb5fc

If it's helpful, I have another test case here. Steps:

Open Chrome mobile simulator (not necessary, but makes the issue more consistently reproducible for me)

Navigate to https://websign.cyph.wang/simple-master#account

Login in with username elon and password hunter2

Quickly scroll up and down a bunch of times

Also seeing this issue and it appears quite a lot when the collection is updated.  Can't seem to figure out exactly what's happening, but I can trigger it consistently if I filter the collection by certain items.  Although once it's been triggered the first time, it can happen randomly (and sometimes even in an infinite loop).

I had similar issues but managed to completely overcome it by fiddling with the templateCacheSize:
<div *cdkVirtualFor="let item of items; templateCacheSize: 100" class="example-item">{{item}}</div>
See documentation at https://material.angular.io/cdk/scrolling/overview

@Kim-Andersen thanks for the tip - seems to solve the issue for me!

I've just noticed in our code that the trackBy code was using an incorrect function signature (it was comparing on the first parameter which is index and not the item in the list).  Since fixing this, I'm not seeing the issue so far (even without the templateCacheSize change).

@Kim-Andersen  - Thanks Kim. Your solution worked for me. I know in recent version of material they fixed this issue but I really dont have scope to upgrade the version as my application is live and there is no plan to invest on the upgrade task


Tracer and OkHttp: what happen when apply sampler for both of them?

Question
Hi there, I have some questions about sampling.
I'm sorry if my doubts are documented somewhere, but I didn't find anything here or in the official doc.
Looking into the code, I found two different Sampler interfaces:

one into android-core
another into the android-trace

As far as I understood the former is applied at OkHttp level, the latter when you register an AndroidTracer through AndroidTracer.Builder().setSampleRate(double).

My first doubt is how do the two work together? What If I apply both of them?
Correct me if I'm wrong, but looking into the code:

given that you set AndroidTracer.Builder().setSampleRate(globalRate);
given that you added a DataDogInterceptor (application) or a TracingInterceptor (network) with a RateBasedSampler;
the RateBasedSampler is triggered at the network level and some span is sampled;
then the sampled span is injected into the AndroidTracer;
then the sampler set with the globalRate is applied.

Is this flow correct?

My second doubt is about the DeterministicSampler implementation of the andorid-core sampler.
Is it a head-based sampling like the TraceIdRatioBased OpenTelemetry sampler?
This is specifically to understand if apply the DeterministicSampler into the Android client and a TraceIdRatioBased on some backend services as well, means that when a span is sampled from the Android client then also the related spans for the same trace_id are sampled on the backend as well.

Hi @alecarnevale  and thanks for contacting us.
Regarding the sampling rates from the AndroidTracer and the TracingInterceptor, they are as you thought cumulative.
The former one simply asks how many spans (out of all the one the tracer receives) should be kept, and the latter asks how many network requests should have a span created for it.
And indeed the sampling works as Head Based sampling, as describe in the documentation you're mentionning. In theory the DeterministicSampler should give you the same sampling on both Android and the Backend, assuming we use the same Deterministic sampling algorithm (our Android implementation uses the same implementation as our Backend Java Agent).

Hi @xgouchet thanks for your reply, that's all clear now.


chore(scripts): add multiarch build for release-docker.sh (linux/arm64/v8,linux/amd64)

Hey! fix #39
I also saw, that the Dockerfile for the shrink test is wrong (it uses the DockerfileTestGrow Dockerfile): https://github.com/matzegebbe/k8s-ephemeral-storage-metrics/blob/master/scripts/release-docker.sh#L26
Since you're not always pushing the latest updates, and I had problems with --load, I used a function to help myself. It works through. Thank you for your project!

Your arm build is available in 1.10.1


Patch group metric aggregation

Seems there is a bug since the refactoring that results in an error if the group has tasks with different metrics. I've made adjustments to follow the older implementation.
cc: @baberabb

Will be merging #1441 instead of this since they conflict!


double Click is not working on cell of ag-grid.

Hi , I am using ag-grid and ondoubleClicked of cell , I want to redirect to other page , but    rowDoubleClicked is not working.
$scope.gridOptions = {
columnDefs: columnDefs,
rowData: rowData,
rowSelection: 'multiple',
angularCompileRows: true,
rowDoubleClicked: onSelectionChanged
};
Thank You

please check the docs, if putting callbacks on the gridOptions, you put 'on' in the method name

function onSelectionChanged(){
var selectedRows = $scope.gridOptions.api.getSelectedRows();
var selectedRowsString = '';
selectedRows.forEach( function(selectedRow, index) {
if (index!=0) {
selectedRowsString += ', ';
}
selectedRowsString += selectedRow.Id;
    });
    $scope.Id =selectedRowsString;

    $scope.selectid = selectedRowsString;

    if(selectedRowsString){

        $state.go('EditProject);

    }
}

$scope.gridOptions = {
columnDefs: columnDefs,
rowData: rowData,
rowSelection: 'multiple',
angularCompileRows: true,
onrowDoubleClicked: onSelectionChanged
};
Hello ceolter , I put 'on' in the method name as above code but it is still do not working. can you suggest
what I am doing wrong in above code .
I am able to execute event onSelectionChanged but my requirement is double click.
Thank You

@jprathore - assuming your using Angular? have you tried adding the $scope to the prefix on the event call back function?
$scope.gridOptions = [
  ...
  onRowDoubleClicked: $scope.onRowDoubleClicked,
  ...
];

@pete-hotchkiss  I tried onRowDoubleClicked: $scope.onRowDoubleClicked, but it still does not trigger any event on double click of ag-grid cell.

needs to be camel case, ie capital R
$scope.gridOptions = {
columnDefs: columnDefs,
rowData: rowData,
rowSelection: 'multiple',
angularCompileRows: true,
   onRowDoubleClicked: onSelectionChanged
};


Error running REPL: local variable is never mutated

Hello,
I'm trying to run ziglisp with zig version 0.14.0-dev.839+a931bfada.
When I try zig run src/main.zig, as per the README, I get
src/main.zig:19:9: error: local variable is never mutated
    var env = try init();
        ^~~
src/main.zig:19:9: note: consider using 'const'
src/main.zig:71:9: error: local variable is never mutated
    var buffer: []u8 = try alloc.alloc(u8, len);
        ^~~~~~
src/main.zig:71:9: note: consider using 'const'
src/main.zig:88:9: error: local variable is never mutated
    var result = try C.alloc.alloc(ValueRef, sexprs.len);
        ^~~~~~
src/main.zig:88:9: note: consider using 'const'

I'll open a branch to change these var to const, you can merge it if you want (or not, up to you ^^)

forked the code and opened a PR on my version of the repo :)
https://github.com/tubo28/ziglisp/pull/2


refactored tests

Refactored tests to be more concise with fixtures.

Coverage increased (+0.7%) to 65.084% when pulling 1bc9541e2788b8d682db3c2090ca92db97a5d457 on tests into f8e9b4390b1c573f0f52ce4be0e4fdd085b28e3d on master.

fixes #246


DDEV cannot start with Composer 2.5.2: exec: "/bin/sh": stat /bin/sh: no such file or directory

Is there an existing issue for this?

[X] I have searched the existing issues

Run a Diagnostic and Paste Link Here
https://gist.github.com/oliverklee/a4be1f923367cd4b933e9afba7da1571
Expected Behavior
ddev start runs without error messages (just like with Composer 2.5.1).
Actual Behavior
ddev start creates this error message:
failed to solve: process "/bin/sh -c export XDEBUG_MODE=off; composer self-update --stable || composer self-update --stable || true; composer self-update 2.5.2 || composer self-update 2.5.2 || true" did not complete successfully: exit code: 1
Failed to start maschinenrichtlinie: ComposeCmd failed to run 'COMPOSE_PROJECT_NAME=ddev-maschinenrichtlinie docker-compose -f /home/klee/public_html/maschinenrichtlinie/.ddev/.ddev-docker-compose-full.yaml up --build -d', action='[up --build -d]', err='exit status 17', stdout='#1 [drud/ddev-dbserver-mariadb-10.3:v1.21.4-maschinenrichtlinie-built internal] load .dockerignore
#1 transferring context: 2B done
#1 DONE 0.0s

#2 [drud/ddev-dbserver-mariadb-10.3:v1.21.4-maschinenrichtlinie-built internal] load build definition from Dockerfile
#2 transferring dockerfile: 591B done
#2 DONE 0.1s

#3 [drud/ddev-webserver:v1.21.4-maschinenrichtlinie-built internal] load .dockerignore
#3 transferring context: 2B done
#3 DONE 0.1s

#4 [drud/ddev-dbserver-mariadb-10.3:v1.21.4-maschinenrichtlinie-built internal] load metadata for docker.io/drud/ddev-dbserver-mariadb-10.3:v1.21.4
#4 DONE 0.0s

#5 [drud/ddev-dbserver-mariadb-10.3:v1.21.4-maschinenrichtlinie-built 1/2] FROM docker.io/drud/ddev-dbserver-mariadb-10.3:v1.21.4
#5 DONE 0.0s

#6 [drud/ddev-webserver:v1.21.4-maschinenrichtlinie-built internal] load build definition from Dockerfile
#6 transferring dockerfile: 1.28kB done
#6 DONE 0.1s

#7 [drud/ddev-webserver:v1.21.4-maschinenrichtlinie-built internal] load metadata for docker.io/drud/ddev-webserver:v1.21.4
#7 DONE 0.0s

#8 [drud/ddev-webserver:v1.21.4-maschinenrichtlinie-built 1/7] FROM docker.io/drud/ddev-webserver:v1.21.4
#8 DONE 0.0s

#9 [drud/ddev-dbserver-mariadb-10.3:v1.21.4-maschinenrichtlinie-built 2/2] RUN (groupadd --gid 1000 "klee" || groupadd "klee" || true) && (useradd  -l -m -s "/bin/bash" --gid "klee" --comment '' --uid 1000 "klee" || useradd  -l -m -s "/bin/bash" --gid "klee" --comment '' "klee" || useradd  -l -m -s "/bin/bash" --gid "1000" --comment '' "klee" || useradd -l -m -s "/bin/bash" --comment '' klee )
#9 CACHED

#10 [drud/ddev-dbserver-mariadb-10.3:v1.21.4-maschinenrichtlinie-built] exporting to image
#10 exporting layers done
#10 writing image sha256:8b8d84815e8a92d5facb956340bbd27f8ab1cd3edcf569e37af4e94981df75e1 done
#10 naming to docker.io/drud/ddev-dbserver-mariadb-10.3:v1.21.4-maschinenrichtlinie-built done
#10 DONE 0.0s

#11 [drud/ddev-webserver:v1.21.4-maschinenrichtlinie-built 2/7] RUN (groupadd --gid 1000 "klee" || groupadd "klee" || true) && (useradd  -l -m -s "/bin/bash" --gid "klee" --comment '' --uid 1000 "klee" || useradd  -l -m -s "/bin/bash" --gid "klee" --comment '' "klee" || useradd  -l -m -s "/bin/bash" --gid "1000" --comment '' "klee" || useradd -l -m -s "/bin/bash" --comment '' klee )
#11 CACHED

#12 [drud/ddev-webserver:v1.21.4-maschinenrichtlinie-built 3/7] RUN export XDEBUG_MODE=off; composer self-update --stable || composer self-update --stable || true; composer self-update 2.5.2 || composer self-update 2.5.2 || true
#12 0.301 runc run failed: unable to start container process: exec: "/bin/sh": stat /bin/sh: no such file or directory
#12 ERROR: process "/bin/sh -c export XDEBUG_MODE=off; composer self-update --stable || composer self-update --stable || true; composer self-update 2.5.2 || composer self-update 2.5.2 || true" did not complete successfully: exit code: 1
------
 > [drud/ddev-webserver:v1.21.4-maschinenrichtlinie-built 3/7] RUN export XDEBUG_MODE=off; composer self-update --stable || composer self-update --stable || true; composer self-update 2.5.2 || composer self-update 2.5.2 || true:
#12 0.301 runc run failed: unable to start container process: exec: "/bin/sh": stat /bin/sh: no such file or directory
------
', stderr='failed to solve: process "/bin/sh -c export XDEBUG_MODE=off; composer self-update --stable || composer self-update --stable || true; composer self-update 2.5.2 || composer self-update 2.5.2 || true" did not complete successfully: exit code: 1'

Steps To Reproduce

In my TYPO3 project, set composer_version: "2.5.2" in .ddev/config.yaml.
ddev start

Anything else?
#4617 might be related.

I've got the same issue, tried with different composer versions, but to me /bin/sh seems to be the culprit!?

So far I'm not able to reproduce this issue.
Pro tip: to force Docker to rebuild the containers you can use ddev debug refresh. This will also upgrade Composer to the latest version.

Closing - the issue seems to be related to this project using Node.js 18 (which is tracked #4614, and downgrading to Node.js 16 gets this working again.

Thank you.

Hmm, nodejs_version: "16" here, I will investigate and reopen/create a new issue if I find out sth. new.


bug: doc not showing for all functions/methods

In the list of completion items, highlighting a function or method sometimes shows the doc, sometimes not. I cannot find what causes to not show. This was working perfectly well on CoC and omnifunc shows them all.
Here's an example of what's happening:
https://user-images.githubusercontent.com/208711/132111608-d064cd50-4e85-4f12-92d7-1c335aea5d57.mp4
Let me know if you need more info. This is the last thing that prevents me to switch from CoC :)

I will investigate it.

@primalmotion I can't reproduce this now. Could you try this with latest cmp?

i'm having a problem similar to this. All function of vim not show documentation (only function). I don't know if it's a problem with lsp or plugin.

LspInfo:

-- my config
local cmp = require'cmp'
cmp.setup{
  completion = {
    completeopt = 'menu,menuone,noinsert',
  },
  snippet = {
    expand = function(args)
      require'luasnip'.lsp_expand(args.body)
    end,
  },
  mapping = {
    ['<CR>'] = cmp.mapping.confirm({ select = true }),
    ['<Esc>'] = cmp.mapping.close()
  },
  formatting = {
    format = function(entry, vim_item)
      vim_item.kind = require("lspkind").presets.default[vim_item.kind] .. " " .. vim_item.kind
      vim_item.menu = ({
        buffer = "[Buffer]",
        nvim_lsp = "[LSP]",
        luasnip = "[LuaSnip]",
        nvim_lua = "[Lua]",
        latex_symbols = "[Latex]",
      })[entry.source.name]
      return vim_item
    end
  },
  sources = {
    { name = 'luasnip' },
    { name = 'nvim_lua' },
    { name = 'vsnip' },
    { name = 'path' },
    { name = 'latex_symbols' },
    { name = 'nvim_lsp' },
    { name = 'buffer' },
    { name = 'emoji' }
  }
}

@aspeddro It is not a LSP completion. It is nvim_lua's item.

Thank you @hrsh7th. Fixed

I updated to latest, and it seems to work fine for me now. Thanks!

sorry. reopening. I missed your PR


Update GAN blog post

Fixes #67

[x] headers are incremented by #
[x] typo fixed
[x] cells are merged
[x] links to docs are updated

@trsvchn I updated a part of text of the markdown but notebook is not updated. Can you please sync them. I did the following: https://github.com/pytorch-ignite/pytorch-ignite.ai/pull/128/commits/5a7652b2a4227045ad9f4d8f880bbd0ddd1cb3b6


Fix downloadTorrent : Add missing path parameter to function

Path is completely ignored as it is not passed down to the download function. It currently returns a stream which is not the expected behavior as per the documention

Please update to npm


Adds docs on how to export/import data

Will you add some (like five hosts over two weeks) dummy test data to the repo for experimenting?

I can do that but in another PR (I can make now). Before I do though, I'm worried about them being out of date, it's basically going to get out of date like immediately for example whenever your PR merges.


Setup automated builds

The latest image right now represents the most recent image I personally built and pushed. We need to set up automated quay image builds.

@jmontleon started on this, but it turns out we need a multi-stage build to first build the project inside of a container, then copy that into the final container. Means this will require some rework of the Dockerfile similar to the CPMA build: https://github.com/fusor/cpma/blob/master/Dockerfile


Conflict of titlepage-pdf with margin figure captions

I'm using titlepage-pdf format for a quarto document. It works great except that when I use that format, the captions for margin figures are clipped to ~0.75" and the caption is hyphenated and wraps around to the next line. If I use the standard pdf format, the caption extends across the full width of the margin before wrapping. I've attached the pdf file produced using titlepage-pdf (see p. 2 of the file)
Tester.pdf
with format: titlepage
Figure 1: Empiri-
cal CDF

with format: pdf
Figure 1: Empirical CDF

format: pdf or titlepage-pdf
editor: visual
\newgeometry{left=10mm,right= 80mm,top=25mm,bottom=25mm}
#| label: fig-ecdfm
#| fig-cap: Empirical CDF
#| echo: false
#| include: true
#| column: margin
#| fig-pos: center
#| fig-width: 4
#| fig-asp: .75
#| out-width: 2.5in

  x <- rnorm(10000,-0.75,1)
  hist(x)

\clearpage
\restoregeometry
`

Seems to have to do with the \usepackage{geometry} call. I can replicate with format: pdf by adding geometry. titlepage-pdf has a \usepackage{geometry} call backed in.

---
  title: Test case
  format:
    pdf:
      documentclass: scrartcl
      geometry:
        - top=30mm
        - left=20mm
  ---

  # Introduction

  \newgeometry{left=10mm,right= 80mm,top=25mm,bottom=25mm}

  ```{r}
  #| label: fig-ecdfm
  #| fig-cap: Empirical CDF
  #| echo: false
  #| include: true
  #| column: margin
  #| fig-pos: center
  #| fig-width: 4
  #| fig-asp: .75
  #| out-width: 2.5in

    x <- rnorm(10000,-0.75,1)
    hist(x)
  ```

 \clearpage
 \restoregeometry

After adding the geometry include with not success,I tried your example with the same result. Then I took out the documentclass: scrartcl and the result was correct, as I had gotten with 'just' pdf format. When I change the format from pdf: default to titlepage-pdf: default, the shortened caption came back. Is pdf with 'documentclass: scrartcl' the same as titlepage-pdf?


Kestrel http/2 problems with Kaspersky enabled

Describe the bug
After switching from running Kestrel behind an naginx reverse proxy to standalone
we've started experiencing some page load problems. We've been able to narrow it down
to Kaspersky antivirus software.
Kestrel is configured to serve
Microsoft.AspNetCore.Server.Kestrel.Core.HttpProtocols.Http1AndHttp2

$dotnet --info

Host (useful for support):
  Version: 2.2.6
  Commit:  7dac9b1b51

.NET Core SDKs installed:
  No SDKs were found.

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.2.6 [/usr/share/dotnet/shared/Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.2.6 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.2.6 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

Application is run within a docker container using a current  microsoft/dotnet:2.2-aspnetcore-runtime image
The page won't load reporting a protocol error. This happens in all available browsers (Chrome,
Firefox, Edge).
We've found that disabling secure connections scanning in kaspersky:
https://help.kaspersky.com/KESWin/11.1.0/en-US/175124.htm
solves the issue.
The page in question is https://e-adm.pl
I'm aware that this report is rather vague, but I wasn't able to collect any
additional information (browser consoles show no informaciton).
Is there any possible additional info I could provide to help resolve this issue?

We've been able to narrow it down to Kaspersky antivirus software.
We've found that disabling secure connections scanning in kaspersky solves the issue.

Doesn't that mean you've solved the issue? I'm not sure what could be done in Kestrel to avoid this?

This sounds like an issue with Kaspersky. Which isn't unsurprising, if they're trying to intercept HTTPS.
There is nothing we can do here, HTTP/2 needs to run over HTTPS. If Kaspersky stops the use of HTTPS then the solution is to uninstall Kaspersky.


Build Luigi App with React

Tutorial: https://developers.sap.com/tutorials/luigi-app-react.html
I'm having a problem running the core app. I've raised two other issues that suggest that there could be some problem with the steps. I noticed, there's a slight difference as well in babel and react node modules. I find this difficult to troubleshoot. Can please help to advise what could be the problem?
This is my project repo -- luigi-react-ui5
Here's the error after executing npm start
jhodel: react-core-mf git@master > npm start

><EMAIL_ADDRESS>start /Users/jhodel/git/luigi-react-ui5/react-core-mf
> node scripts/start.js

compilation.getCache is not a function
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `node scripts/start.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/jhodel/.npm/_logs/2021-01-05T09_56_52_124Z-debug.log

Hello,
It seems like a webpack version issue. You have to downgrade webpack to 6.3.2.
Please refer to those two discussions
https://forum.framework7.io/t/fresh-create-project-not-working/12657
https://forum.framework7.io/t/impossible-to-compile-app-compilation-getcache-is-not-a-function/12661/4
I hope this solution will solve your issue.
Thanks

Hello,
It seems like a webpack version issue. You have to downgrade webpack to 6.3.2.
Please refer to those two discussions
https://forum.framework7.io/t/fresh-create-project-not-working/12657
https://forum.framework7.io/t/impossible-to-compile-app-compilation-getcache-is-not-a-function/12661/4
I hope this solution will solve your issue.
Thanks

Thanks! It fixed my issue.
However, I've run into another issue coming from Home.jsx file. I found out that it is due to the latest version of fundamental-react module. I downgraded it to "fundamental-react": "^0.11.0"

Thanks! It fixed my issue.
However, I've run into another issue coming from Home.jsx file. I found out that it is due to the latest version of fundamental-react module. I downgraded it to "fundamental-react": "^0.11.0"

Thanks helped me a lot. In my case it helped to downgrade the webpack to 6.2.1.


Whisper example missing NNDecodingTask definition

Description
I am going through the whisper BlindAI example in examples/whisper/BlindAI_Whisper.ipynb and one of the classes used -- NNDecodingTask -- is not defined in the notebook. Can the definition of this class be added so that it will be possible to export different Whisper models (small, large, multi-language etc)?
Why this modification is needed?
Great tutorial that can't be followed 100%...
What documents need to be updated

[ ] examples/whisper/BlindAI_Whisper.ipynb

FYI, the fixed notebook has been pushed on the repo, you can find it here:
https://github.com/mithril-security/blindai/blob/master/examples/whisper/BlindAI_Whisper.ipynb


Does setSrd() only work with interrupt?

Hi, I have a problem with readSensor() function, I thought this would work with setSrd() and whenever there is a data (according to the sample rate) it returns positive. But with testing it I saw that this is not true.
What is the correct way of using setSrd()? Is it meant to be used with interrupt?
By the way, very nice and useful library. Thanks a lot.

Can you post more information:

What version of the library are you using?
What microcontroller?
What breakoutboard? Are you using SPI or I2C?
Post the simplest example code that demonstrates the problem.

I'm not sure what version fixed it, but the SRD works as expected in the current version of the library, v5.6.0


TC-ACT-2.2 - Need verification steps to verify action-list atribute

Issue :

Need verification steps to verify action-list attribute that is test-step 3 to 4e.
This PR contains the details of the verification for endpoint-list attribute but not for action-list attribute

Test-plan reference :
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/actions.adoc#tc-act-2-2-primary-functionality-with-server-as-dut
@jwinder-ca @leorozendaal Can I get any information on it

The action-list depends on the device, no?  It's a list of what actions the device supports.
This does not seem like an SDK issue to me...


Uptime enforcement not scaled with connection time

My understanding was that uptime enforcement should be based on uptime percentage scaled according to the node's connection time, but having observed the results from the most recent minting it seems that is not the case.
Checking the code I see that this uptime percentage, which is explicitly not scaled
https://github.com/threefoldtech/minting_v3/blob/3b59eee6393c959828e39d84cd34e760e272d83b/minting/src/main.rs#L2054-L2055
is also used for the SLA enforcement:
https://github.com/threefoldtech/minting_v3/blob/3b59eee6393c959828e39d84cd34e760e272d83b/minting/src/main.rs#L2077
Therefore a DIY node that connected after more than 5% of the period has passed can't possibly pass this check and therefore won't mint. Is this the intended behavior?

This is indeed intended. Uptime scaling in the  period was implemented initially since we wanted farmers to migrate from v2 to v3 ASAP, and not doing that would mean farmers should wait until roughly the period end to avoid loss of rewards. The plan was to remove this after most of the v2 farmers had migrated (i.e. to only enable it for a couple of months). The comment is a leftover which should have been removed, but also indicates why we still had the scaling when we switched to linear payments on V3: in a linear payment scheme, the scaling of both the period to the actual time between connecton and period end, and the scaling of the payout based on uptime in the aforementioned calculated range, cancel out. Essentially, if a node is started roughly 3.045 days  before the period end, and is online for 100% of the time, it will get 10% of the reward, irrespective if of whether we calculate the reward  for 100% of the shorter duration, or if we calculate 10% uptime in the total period. So at this point, the only purpose of the code was to have the start date nicely marked in the overview file. Since we now enforce the SLA again, this changes is reverted back to what was initially intended. It should further be noted that scaling this has always been considered a bad idea, since it undermines the idea of SLA entirely as long as a node id is cheap to create.


Yank arci-speak-cmd 0.1.0 and release v0.0.3

https://doc.rust-lang.org/cargo/commands/cargo-yank.html

Done! Thank you @taiki-e


Implement appinfo extension for purge/restart command requests

This commit implements the extension to the /api/v1/appinfo local profile
endpoint, which allows the server to submit purge/restart commands
for locally running application instances.
This functionality is already documented in api/PROFILE.md under
AppInfo.
Test is prepared here: https://github.com/lf-edge/eden/pull/744
Signed-off-by: Milan Lenco<EMAIL_ADDRESS>

The interval is 1 minute. I would like it to be less, say no more than 30 seconds.
With radio silence, the expectation of the (same) customer was that a config change might take few tens of seconds to apply but no more than 1 minute.

Yeah the fact that it takes 60 seconds to just notice the command, then some time to execute it, is quite slow for this local communication. Do you want to do a PR to drop this to 10 seconds? (Perhaps with a configItem to be able to raise it if the communication to a local profile server is expensive; often the LPS is on the same edge node so it is definitely free.)

@eriknordmark I will open another PR where this currently constant time interval is turned into a config property.


Update install.sh to install python-pip

python-pip isn't installed by default on Kali docker images.

Thanks for the catch!


Word wrap work incorrect on txt file!

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: VSCodeSetup-x64-1.83.1
OS Version: win11

Steps to Reproduce:

This is orign txt file,It has three paragraphs, each with a four-space indent at the top of the line.

When I use vscode open it,The entire paragraph is indented by four Spaces, not just the first line

This is my vscode config about word wrap

I already tried to delete all data what about vscode then reinstall vscode, but nothing has changed, I want to know how to configure vscode to achieve the same effect as txt editor?

It sounds like you would like to configure "editor.wrappingIndent": "none"


Stop nagging about "latest" when I'm on "latest LTS"

Summary of the new feature / enhancement
As a developer stuck on LTS for compatibility with Microsoft's GitHub and Azure Pipeline agents, I don't want to be nagged about versions I'm not allowed to use.
I really do want to know when there's a new LTS release, but the current implementation means that every time I open a new terminal tab, I'm being nagged to change my mind about using the LTS release!
I've had to disable the POWERSHELL_UPDATECHECK for my sanity, but what I really want is to set it to "LTS"
Proposed technical implementation details (optional)
When a user is on an LTS release, only nag if they are not on the latest LTS.
When a new LTS release comes out, notify about the LTS update, and casually remind us of the other upgrade options.
When a LTS release is end-of-life (and there's a new major (minor) LTS version) then you should make the nag specifically about that and make it very clear what the current LTS release is.

P.S. Using an Environment Variable to control update checks in an app that supports side-by-side and portable installs just does not work as intended. I'm currently running LTS and Preview versions side-by-side at work. I'm avoiding the current release because of compatibility issues with the LTS -- so I use Preview as my daily driver, and test everything in LTS.
Personally, I can make this work by setting the system environment POWERSHELL_UPDATECHECK = 0 and then setting it to LTS or Default as appropriate in my windows terminal profile (which requires editing the .json), but this doesn't seem like something anyone should need to do -- especially since PowerShell itself controls the defaults in those terminal configs.

Why doesn't Default have an LTS entry?
https://github.com/MicrosoftDocs/PowerShell-Docs/blob/main/reference/7.3/Microsoft.PowerShell.Core/About/
about_Update_Notifications.md (possible write)

Off turns off the update notification feature
Default is the same as not defining POWERSHELL_UPDATECHECK:

LTS releases notify of updates to lts and stable releases
Stable releases notify of updates to stable releases
Preview releases notify of updates to stable and preview releases

LTS only notifies of updates to long-term-servicing (LTS) GA releases

nag specifically about EOL of LTS release

Were the Default code modified to correspond with the above adding a notification of EOL might complicate things.

Preview/RC releases don't appear to notify of updates to GA releases.
$ pushd /tmp/PowerShell-Docs/reference/7.3/Microsoft.PowerShell.Core/About
/tmp/PowerShell-Docs/reference/7.3/Microsoft.PowerShell.Core/About ~
$ ed -s about_Update_Notifications.md <<<'31,44p'
PowerShell only return notifications for updated GA releases. Preview and
Release Candidate (RC) releases notify of updates to preview, RC, and GA
releases.

The update notification behavior can be changed using the
`POWERSHELL_UPDATECHECK` environment variable. The following values are
supported:

- `Off` turns off the update notification feature
- `Default` is the same as not defining `POWERSHELL_UPDATECHECK`:
  - GA releases notify of updates to GA releases
  - Preview/RC releases notify of updates to GA and preview releases
- `LTS` only notifies of updates to long-term-servicing (LTS) GA releases

$ popd
~
$

@spaette the problem is that I can't easily set the Stable and the LTS versions to only check their own updates and their own updates only without doing weird stuff with short cuts or by editing the Windows Terminal config.
Simply put, this is wrong:

Default is the same as not defining POWERSHELL_UPDATECHECK:

LTS releases notify of updates to lts and stable releases

I don't need LTS to tell me there is a higher version number Stable release.

The problem is that LTS is checking both versions.

It it worthwhile to elaborate on the .md file's mentioned 2 channels and 3 endpoints?

I'm not sure that I understand what you mean - English is not my native language.

Absent looking at the code it would seem from the documentation that channels and endpoints are utilised.
$ pushd /tmp/PowerShell-Docs/reference/7.3/Microsoft.PowerShell.Core/About
/tmp/PowerShell-Docs/reference/7.3/Microsoft.PowerShell.Core/About ~
$ ed -s about_Update_Notifications.md <<<'29,33p'
By default, PowerShell subscribes to one of two different notification channels
depending on its version/branch. Supported, Generally Available (GA) versions of
PowerShell only return notifications for updated GA releases. Preview and
Release Candidate (RC) releases notify of updates to preview, RC, and GA
releases.
$ ed -s about_Update_Notifications.md <<<'45,50p'
The following endpoints are currently used for determining the latest version of
each channel:

- `LTS`: https://aka.ms/pwsh-buildinfo-lts
- `Stable`: https://aka.ms/pwsh-buildinfo-stable
- `Preview`: https://aka.ms/pwsh-buildinfo-preview
$ popd
~
$

2 channels

tools/packages.microsoft.com/mapping.json
the above file lists channels stable and preview
I would solicit the opinion of someone more familiar with the code.
src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs
I would venture to guess the above file is relevant.


GM Camera: use ECM brake pressed bit

It appears different GM camera platforms use different ECMAcceleratorPos->BrakePedalPos to cancel. Our Bolt for example is around 8, however the Silverado is around 20.

Our Bolt (threshold of 8): https://pastebin.com/hAxDqcZS https://user-images.githubusercontent.com/25857203/200418683-eb2953c0-bf39-45bb-ba02-e6acf0ab5a0e.png
Silverado 1500 (threshold of 8): https://pastebin.com/ULftqEw7 https://user-images.githubusercontent.com/25857203/200418699-7ef601f5-f714-4ec7-8df2-b8e4b95f52e8.png

Some times to cancel for the Silverado are upwards of a second! This means we'd try to cancel before the camera did, and cause a FCW/fake cruise fault.
If we use a threshold of 20 for the Silverado, the timings look much more similar to our Bolt:

https://pastebin.com/TtN9bmkS

Since this will be cumbersome to maintain for all the different possible thresholds in the same platform of cars (Camera-ACC), we can use a brake pressed bit which captures this threshold.
We couldn't previously do this for the older platform since the Volts can have a faulty brake pedal housing and the bits did not capture what the position signal did (https://imgur.com/a/tC7sk3c). My guess is the bits are calibrated to the brake pedal's floor reading, however the ACC system also does a sanity check on the uncalibrated position signal, which seems like a bug.
If we use the EBCMBrakePedalPosition->BrakePressed bit, it closely matches our Bolt's current threshold, as well as the Silverado's threshold of ~20:

Bolt w/ bit: https://pastebin.com/BKP9X9tQ
Silverado w/ bit: https://pastebin.com/mdh3x2Fe

Also, the ECM brake bit isn't what the camera looks at like we thought, it's much too delayed: https://user-images.githubusercontent.com/25857203/200418296-81556eef-6a7b-4bb6-a5ec-30e23d92200f.png
EBCMBrakePedalPosition->BrakePressed actually looks correct.

This might not catch everything, you can fault if you engage shortly after releasing the brake pedal

Turns out the fault I hit is a pre-existing fault. Even if the brake pos is zero, and all bits are zero, if the user recently braked hard and then enabled, the ECM faults... So no regression there. The ECM bit is actually more delayed than the other bits (and brake pos threshold), so this means we reduce the chances of this fault

The new times of the Silverado using the ECM engine status bit. Everything looks good!


Positional vs named arguments on PHP 8

Hi,
I'm making some tests with Behat on PHP 8 (rc).
The MixedArgumentOrganiser will sometimes inject numered arguments mixed with named arguments, which throws the following error:

Fatal error: Cannot use positional argument after named argument

I was wondering why use numered arguments instead of named arguments?

This should be fixed in #1313 - review is welcome
Position is simply the last fallback once type and name have failed to match, partly for legacy regex reasons:
/**
 * @Given /I have (\d+) bananas/
 */
function bananas ($number)

Closing as will be resolved in https://github.com/Behat/Behat/pull/1313


Why not just Capy?

It's a good idea. My preference is to be descriptive with what the app does for now.


Release v24.12

Description
PR for release v24.12
Issue reference
Fixes # (issue-number)
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:

Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

[ ] New Feature: A non-breaking change that adds new functionality.
[ ] Optimization: A code change that improves performance.
[ ] Examples: A change to existing or additional examples.
[ ] Bug Fix: A non-breaking change that addresses an issue.
[ ] Documentation: Updates to documentation or new documentation for new features.
[ ] Refactoring: Non-functional changes that improve the codebase.
[ ] Style: Non-functional changes related to code style (formatting, naming, etc).
[ ] Testing: Additional tests to improve coverage or confirm functionality.
[ ] Other: (Insert description of change)

Key checklist:

[ ] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[ ] All unit tests pass: $ nox -s tests
[ ] The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.
Further checks:

[ ] Code is well-commented, especially in complex or unclear areas.
[ ] Added tests that prove my fix is effective or that my feature works.
[ ] Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

Proceeding with release as the current failed tests are due to test calibration.


Client supplied ID is used to look up existing clients in inheritSession, while the store of existing actually uses the server assigned if one exists.

I am still debugging and investigating this, so hopefully it is not human error. Figured I would post in case anyone else is experiencing it or able to easily reproduce it.
Happens to me on versions > 2.6.0, I did not test lower than that because my code is not compatible without some changes, so I decided to try to investigate the issue (or my misconfiguration).
I am using protocol version 5 clients (mqttjs, specifically).
Here is my server config:
server := mqtt.New(&mqtt.Options{
		InlineClient: true,
		Capabilities: &mqtt.Capabilities{
			MaximumClients:               math.MaxUint16,
			MaximumSessionExpiryInterval: 0,              // maximum number of seconds to keep disconnected sessions
			MaximumMessageExpiryInterval: 60 * 60 * 24,   // maximum message expiry if message expiry is 0 or over
			ReceiveMaximum:               1024,           // maximum number of concurrent qos messages per client
			MaximumQos:                   1,              // maxmimum qos value available to clients
			RetainAvailable:              1,              // retain messages is available
			MaximumPacketSize:            0,              // no maximum packet size
			TopicAliasMaximum:            math.MaxUint16, // maximum topic alias value
			WildcardSubAvailable:         1,              // wildcard subscriptions are available
			SubIDAvailable:               1,              // subscription identifiers are available
			SharedSubAvailable:           1,              // shared subscriptions are available
			MinimumProtocolVersion:       3,              // minimum supported mqtt version (3.0.0)
			MaximumClientWritesPending:   1024 * 8,
		},
	})

Here is my client settings:
 keepalive: 60,
  reconnectPeriod: 5000,
  clean: false, //I've tried true as well, and with no assigned client id below
  clientId: 'bob',
  debug: true,
  rejectUnauthorized: false,

Here is a screenshot of both my client simultaneously connected, and not being forcefully disconnected (also no client takeover occurred according to my logs.

Now if I publish a message, only one of them gets it (the latest to connect I think). Now this does seem like a client takeover.
So the 2 issues are:

Client who was taken over, is not disconnected
client event of this exchange is not set or happening (I log client takeovers, and not being detected)

Here is the code I am using to do that which used to work I think in older versions:
func (h *ConnectionStatusHook) OnDisconnect(client *mqtt.Client, err error, expire bool) {
	if client.StopCause() == packets.ErrSessionTakenOver {
		logErr := h.LogConnectionState(client.ID, CLIENT_TAKEOVER)
		if logErr != nil {
			sentry.CaptureException(err)
			h.Log.Error("Error logging client takeover", "error", err)
		}
		return
	}

On the metrics page I can see:
{
"version": "2.6.4",
"started":<PHONE_NUMBER>,
"time":<PHONE_NUMBER>,
"uptime": 323,
"bytes_received": 322,
"bytes_sent": 442,
"clients_connected": 2,
"clients_disconnected": 0,
"clients_maximum": 3,
"clients_total": 2,
"messages_received": 2,
"messages_sent": 3,
"messages_dropped": 0,
"retained": 0,
"inflight": 0,
"inflight_dropped": 0,
"subscriptions": 1,
"packets_received": 22,
"packets_sent": 22,
"memory_alloc": 3694592,
"threads": 15
}

Which is my 2 clients. Since its not being disconnected I guess is why the client stop isn't being detected. What's also interesting is the subscriptions count is actually only 1. Also when I ctrl+c the 2 terminals with the connections, I get the debug log of each disconnecting (and using the same client id).
So the root of the issue I think is the lack of the disconnect.
I'll try to see if I can find a fix or where the issue is!

I think I found the issue. Whether or not this is a 'bug', or a misunderstanding of assigning client IDs, yet to be determined 😅
The problem:
The stored check for client ID in inherit session uses the client's ID they define. The one in the existing client store, uses the server-assigned client identifier.
So I think this happens:

client bob connects
client bob is assigned by server the client ID 'steve'
client bob tries to connect from a different terminal now
the check looks for 'is bob in existing?', no, only 'steve' is in existing
inheritSession does not happen
both clients remain connected and occupy the same client ID
you can also see this manifest in the disconnect logs when I connect the 2 terminals one after the other:

mqtt-1  | time=2024-07-19T14:18:54.125Z level=DEBUG msg="client disconnected" error="websocket: close 1006 (abnormal closure): unexpected EOF" client=admin/77768965-05bf-4f1f-91ed-44cb83b915e7 remote=<IP_ADDRESS>:49364 listener=ws
mqtt-1  | time=2024-07-19T14:18:54.125Z level=INFO msg="client disconnected" hook=ConnectionStatusHook client=admin/77768965-05bf-4f1f-91ed-44cb83b915e7 expire=true error="websocket: close 1006 (abnormal closure): unexpected EOF"
mqtt-1  | time=2024-07-19T14:18:54.129Z level=WARN msg="" listener=ws error="websocket: close 1006 (abnormal closure): unexpected EOF"

I will work on a PR that does this: If client has an assigned client identifier, use that to look up existing clients, instead of the client-defined client id.
In the meantime let me know if there is a more appropriate fix.

I have a confirmed fix by just using cl.ID which has the correct assigned, instead of the pk.Connect.ClientIdentifier.
Will open a PR shortly.

I realized a few reasons why this may not have manifested to others before:

I set this client ID assignment manually from my ownOnConnectAuthenticate hook,  manual client assignment is likely not too wide spread (but crucial for our workflow)
when clients give no client id to mochi, it by default generates a random string, I suppose most client takeover flows just take the clients client-id at face value which is a more common use case, otherwise they are always random

@SimonMacIntyre:

Is cl.Properties.Props.AssignedClientID only re-assigned when it is not empty (only occurs when client ID was empty in Connect)? If so, then #417 seems to be fine. Otherwise, it would be a protocol violation.
Given cl.Properties.Props.AssignedClientID is manually re-assigned, cl.ID should also be changed as there are many references based on cl.ID.

@thedevop

It is only assigned when pk.Connect.ClientIdentifier is empty yes, which satisfies MQTT-3.2.2-16!
You're right, mochi is already doing that:

But now you are making me wonder if I should swap the PR back to the original implementation before I changed it, which is just using cl.ID since it should be correct in all cases. AKA, it will be the client supplied normally, and the server assigned if client does not supply one.
Rather than do the If check on the cl.Properties.Props.AssignedClientId, just reference cl.ID everytimg, I Think that makes sense!

I feel using cl.ID in inheritClientSession is reasonable. However, this is mutable, perhaps that's the reason @mochi-co used the pk.Connect.ClientIdentifier instead. Let's hear from him if he's ok to change that to use cl.ID.


chicken: 4.11.0 -> 4.13.0

Motivation for this change
https://lists.nongnu.org/archive/html/chicken-announce/2017-12/msg00005.html
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

The patch from 4.11.0 has been reproduced so that it applies cleanly. See commit message for details about the chicken-ssql version bump.

Was it necessary to refresh the patch? Normally we do not do it when the patch applies as is.

Not necessary, but it applied with fuzz and it was simple enough to reproduce from 4.13.0, so I did. Shall I revert it?

I would drop it from the PR because it is confusing, but this is not a requirement. (The previous update of the patch was significant: https://github.com/evhan/nixpkgs/commit/cd01aab44415a339fa4d85475f7819ab90ca1112 .)

Done, cheers.


Fix example checkboxes

Added suggested changes by @nickcolley and changed id and name values.

Fixes #661

You can preview this change here:
Built with commit 20eecfed6069de159ae8f35e59f04921537142f6
https://deploy-preview-662--govuk-design-system-preview.netlify.com

Thanks for this @DebsDee – the change looks great 👍
There's an unrelated change to the package lock file in 'first commit' which shouldn't be part of this – I suspect it's because you're using a different version of npm to the team, so when you ran npm install it updated the lock file.
Are you able to remove that commit? I can tidy it up on your behalf if not.

Sorry, I didn't explain that very well! I've updated the PR to just include the commit which changes the checkbox ids, without the commits that alter package-lock.json.
Thanks again!


False positive domain redirect detection

Describe the bug
In our application we redirect user to a language-specific version of the page, but unlighthouse says that it's a different domain, and it's going to be ignored.
➜  ~ npx unlighthouse --site https://website.com/en

 WARN  Redirected URL goes to a different domain, ignoring. `https://website.com/en.

So we end up with the infinite Waiting for routes... message without any change.
Reproduction
npx unlighthouse --site https://cdprojektred.com
System / Nuxt Info
System:
    OS: macOS 13.3.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 816.31 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.12.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.19.2 - /usr/local/bin/npm
  Browsers:
    Chrome: 113.0.5672.92
    Safari: 16.4

Hey @Maclay74, thanks for the issue.
I've pushed up a fix to support subdomains that will be available in v0.6.0 which will be released today at some point.


TypeError: TranscriptionClient.init() got an unexpected keyword argument 'callback'

I ran into an issue when executing the example_client.py, it would throw this error:
`
$ python examples/example_client.py
Traceback (most recent call last):
File "/home/rpi/WhisperLive/examples/example_client.py", line 26, in
client = TranscriptionClient(
^^^^^^^^^^^^^^^^^^^^
TypeError: TranscriptionClient.init() got an unexpected keyword argument 'callback'
`
Using the following  versions:

Raspberry Pi OS 64-bit Debian 12 (bookworm)
Python 3.11.2

@AIWintermuteAI  I ran into a similar problem how do i solve this? I appreciate the help

How are you installing WhisperLive? You should make sure you pip install my fork and not the upstream.

I'll just drop the commands that I've issued through the terminal, following your procedure from your youtube channel:
Whisper Live Installation
sudo apt-get update && sudo apt-get upgrade
python -m venv venvs/whisper
source venvs/whisper/bin/activate
git clone https://github.com/AIWintermuteAI/WhisperLive.git
cd WhisperLive/
pip install -e .
pip install piper-tts
pip install "numpy<2.0"
python3 run_server.py --port 9090
--backend faster_whisper
New terminal session for the client
source venvs/whisper/bin/activate
cd WhisperLive/
python examples/example_client.py

Interesting. I'll take a look this week.

@AIWintermuteAI  appreciate it!

Cannot reproduce this on my side, it still looks like you have some other installation of WhisperLive on your system, which for some reason is what gets picked during the import.
You can try
(whisper) ubuntu@ubuntu-laptop:~/github/WhisperLive$ pip show whisper_live
Name: whisper-live
Version: 0.4.1
Summary: A nearly-live implementation of OpenAI's Whisper.
Home-page: https://github.com/collabora/WhisperLive
Author: Collabora Ltd
Author-email<EMAIL_ADDRESS>License: MIT
Location: /home/ubuntu/github/WhisperLive
Editable project location: /home/ubuntu/github/WhisperLive
Requires: faster-whisper, ffmpeg-python, kaldialign, numba, onnxruntime, openai-whisper, PyAudio, scipy, soundfile, torch, torchaudio, websocket-client, websockets
Required-by:

Location: /home/ubuntu/github/WhisperLive
This shows the location of the installed package.
You can also search for whisper_live on your system and see if there are multiple ones installed.


#204 fix caching issue for eth_getStorageAt

I think that issue #204 was caused by using incorrect index for block tag parameter for eth_getStorageAt, as a result storage index was used to cache, which led to cache returning same results for different block nubmers. I've fixed issue and added tests for this and a few other methods with block tag parameter.

only took a $230 bounty   https://gitcoin.co/funding/details?url=https://github.com/MetaMask/metamask-extension/issues/602


Update ngImageEditor.js

there is no information of the size of the boot image

thank you for your pull request.
You committed file that is created by build Gruntfile.
So i will commit some files.