Color Coding SPSecurityGrid

Category

[ ] Question
[ ] Bug
[x] Enhancement

Authors
@russgove , @hugoabernier
Expected or Desired Behavior
I was wondering how hard it would be to create an alternate view of this part.  The basic layout and most of the web-part would be the same.
The only difference would be that instead of having a drop down with each of the permission types, rank the types by "severity" and apply a color scale to the severity.  Then instead of a solid gray circle icon, set the color based on the permission level.
I've done this on a smaller simpler scale today on premise where Red means Full Control, Yellow means Contribute, Green means read.  This would make it easy to get an idea of who has what level of permissions in general at a quick glance.
Expanding on my simple color scheme, one that might have a little more detail might be:

Red - anyone who can edit site/list settings (Full Control, Edit)
Purple - any who can approve
Yellow - anyone who can contribute (edit files)
Green - anyone who can read

Here's kind of what I am thinking it would look like:

Thanks for your contribution! Sharing is caring.

Hi @mikezimm,
i like your idea, i hope to upgrade this to the latest spfx release this year, and will look into color coding as well.
Alsomhoping tomget it working with azure AD groups.
Russell

Hi @mikezimm
I'm hoping you'll be able to help me test this:

OK, Theres working version in my repo at https://github.com/russgove/sp-dev-fx-webparts/tree/master/samples/react-securitygrid

@russgove ,
I'm trying to clone your fork now but it's currently at download marker 600MB... I think I may be getting all the files, not just the source folder... will let you know if it works though.

@russgove ,
I cloned your fork, switched to dev, npm installed using gitDesktop.
Then I got the following error about isDomainIsolated:
After that I tried npm install again and didn't get any errors.
However, when I load it on the page it does not seem to show any data like it does in the master branch.
The first screenshot shows the web part on the page with property pane open... looks like I have the option to edit colors, but you can see there is no data in the grid part.
The second screenshot shows what I see when I click the edit colors button.... again looks like it's just not loading any data for me.  I tried in 2 different tenants in both Chrome and IE.
Thoughts?
Error - Unknown
 JSON validation failed:
C:\Users\myfolder\projects\Git\russ-sp-dev-fx-webparts\samples\react-securitygrid\config\package-solution.json

Error: #/solution
       Additional properties not allowed: isDomainIsolated
[17:27:57] ==================[ Finished ]==================
Error - Unknown
 JSON validation failed:
C:/Users/myfolder/projects/Git/russ-sp-dev-fx-webparts/samples/react-securitygrid/config/package-solution.json

Error: #/solution
       Additional properties not allowed: isDomainIsolated

Hey, after i posted last email, i,found a bug (if no permissions selected it would,error out). I pushed an update about an hour ago. please get latest when u can.
Sent from my iPad

On Dec 3, 2019, at 5:41 PM, mikezimm<EMAIL_ADDRESS>wrote:
@russgove ,
I cloned your fork, switched to dev, npm installed using gitDesktop.
Then I got the following error about isDomainIsolated:
After that I tried npm install again and didn't get any errors.
However, when I load it on the page it does not seem to show any data like it does in the master branch.
The first screenshot shows the web part on the page with property pane open... looks like I have the option to edit colors, but you can see there is no data in the grid part.
The second screenshot shows what I see when I click the edit colors button.... again looks like it's just not loading any data for me. I tried in 2 different tenants in both Chrome and IE.
Thoughts?
Error - Unknown
JSON validation failed:
C:\Users\myfolder\projects\Git\russ-sp-dev-fx-webparts\samples\react-securitygrid\config\package-solution.json
Error: #/solution
Additional properties not allowed: isDomainIsolated
[17:27:57] ==================[ Finished ]==================
Error - Unknown
JSON validation failed:
C:/Users/myfolder/projects/Git/russ-sp-dev-fx-webparts/samples/react-securitygrid/config/package-solution.json
Error: #/solution
Additional properties not allowed: isDomainIsolated
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

and after you click 'edit permissions,and colors', ther is a menu on the rop of that panel. you need to,click 'add permission' to add a row. (i should make it add a blank row by default if there are no selected permissions)
Sent from my iPad

On Dec 3, 2019, at 5:41 PM, mikezimm<EMAIL_ADDRESS>wrote:
@russgove ,
I cloned your fork, switched to dev, npm installed using gitDesktop.
Then I got the following error about isDomainIsolated:
After that I tried npm install again and didn't get any errors.
However, when I load it on the page it does not seem to show any data like it does in the master branch.
The first screenshot shows the web part on the page with property pane open... looks like I have the option to edit colors, but you can see there is no data in the grid part.
The second screenshot shows what I see when I click the edit colors button.... again looks like it's just not loading any data for me. I tried in 2 different tenants in both Chrome and IE.
Thoughts?
Error - Unknown
JSON validation failed:
C:\Users\myfolder\projects\Git\russ-sp-dev-fx-webparts\samples\react-securitygrid\config\package-solution.json
Error: #/solution
Additional properties not allowed: isDomainIsolated
[17:27:57] ==================[ Finished ]==================
Error - Unknown
JSON validation failed:
C:/Users/myfolder/projects/Git/russ-sp-dev-fx-webparts/samples/react-securitygrid/config/package-solution.json
Error: #/solution
Additional properties not allowed: isDomainIsolated
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@russgove ,
Ok, got the commit 350e5d5f (fix if no permissions selected).  I can now see my groups and edit colors.  Concept is pretty cool because the end user can do just about anything they want.
Here's what I see now:  I can edit the colors for a level and see empty circles (not solid gray like before).  But the color is not visible yet.  Maybe your still working on it?

@russgove ,
I see some color now on people, but not groups yet:
I had an idea also to make it easier to select some pre-built options.  If I can get a chance today, I will try to build it up and send it to your repo.

@russgove ,
I forked your fork, made some updates and created a pull request back to you.
I've never done this before so I apologize if I messed something up.
Basically, this is the result:
In property pane, you have a dropdown to pick a color scheme... (Screenshot 1 - red arrow).
You select it, refresh the page and it populates your selectedPermissions[] array (Screenshot 1 - yellow highlight).
I wasn't able to get it to re-render without a refresh but I am pretty new at SPFx/react so you may be able to get it working smoother.
As you can see by the second screenshot, I actually did get it to work.
How you can manage all those choices and in a separate file and easily create new configurations.  Let me know if you want to do any kind of skype or team call and I can walk you through it.

Thanks mike,I have some pressing issues in my “day” job. Can I ping you in 2 weeks?
Sent from my iPhone

On Dec 4, 2019, at 6:23 PM, mikezimm<EMAIL_ADDRESS>wrote:
@russgove ,
I forked your fork, made some updates and created a pull request back to you.
I've never done this before so I apologize if I messed something up.
Basically, this is the result:
In property pane, you have a dropdown to pick a color scheme... (Screenshot 1 - red arrow).
You select it, refresh the page and it populates your selectedPermissions[] array (Screenshot 1 - yellow highlight).
I wasn't able to get it to re-render without a refresh but I am pretty new at SPFx/react so you may be able to get it working smoother.
As you can see by the second screenshot, I actually did get it to work.
How you can manage all those choices and in a separate file and easily create new configurations. Let me know if you want to do any kind of skype or team call and I can walk you through it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

No problem Russell,
I’ll keep poking at it as well.  By the time you get back to it there will probably be a few more updates.
Regards,
From: Russell gove<EMAIL_ADDRESS>Sent: Wednesday, December 4, 2019 9:23 PM
To: SharePoint/sp-dev-fx-webparts<EMAIL_ADDRESS>Cc: Mike Zimmerman<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [SharePoint/sp-dev-fx-webparts] Color Coding SPSecurityGrid (#1009)
Thanks mike,I have some pressing issues in my “day” job. Can I ping you in 2 weeks?
Sent from my iPhone

On Dec 4, 2019, at 6:23 PM, mikezimm <notifications<EMAIL_ADDRESS>wrote:
@russgove ,
I forked your fork, made some updates and created a pull request back to you.
I've never done this before so I apologize if I messed something up.
Basically, this is the result:
In property pane, you have a dropdown to pick a color scheme... (Screenshot 1 - red arrow).
You select it, refresh the page and it populates your selectedPermissions[] array (Screenshot 1 - yellow highlight).
I wasn't able to get it to re-render without a refresh but I am pretty new at SPFx/react so you may be able to get it working smoother.
As you can see by the second screenshot, I actually did get it to work.
How you can manage all those choices and in a separate file and easily create new configurations. Let me know if you want to do any kind of skype or team call and I can walk you through it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-fx-webparts/issues/1009?email_source=notifications&email_token=AL2ZDVRMM5AC3FPHAJOUHWLQXBQYFA5CNFSM4I3V2XP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF7HUOY#issuecomment-561936955, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AL2ZDVT2YQMLL2IEE7BDNKDQXBQYFANCNFSM4I3V2XPQ.

Mike, THANK YOU!
This looks great!
Hope to get back to this next week.
I found a  big issue in that if you use the webpart on a subsite it does
not seem to pull in the sharepoint groups. Have you noticed that ?
On Thu, Dec 5, 2019 at 9:25 AM mikezimm<EMAIL_ADDRESS>wrote:

No problem Russell,
I’ll keep poking at it as well. By the time you get back to it there will
probably be a few more updates.
Regards,
From: Russell gove<EMAIL_ADDRESS>Sent: Wednesday, December 4, 2019 9:23 PM
To: SharePoint/sp-dev-fx-webparts<EMAIL_ADDRESS>Cc: Mike Zimmerman<EMAIL_ADDRESS>Mention <
<EMAIL_ADDRESS>Subject: Re: [SharePoint/sp-dev-fx-webparts] Color Coding SPSecurityGrid
(#1009)
Thanks mike,I have some pressing issues in my “day” job. Can I ping you in
2 weeks?
Sent from my iPhone

On Dec 4, 2019, at 6:23 PM, mikezimm<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
@russgove ,
I forked your fork, made some updates and created a pull request back to
you.
I've never done this before so I apologize if I messed something up.
Basically, this is the result:
In property pane, you have a dropdown to pick a color scheme...
(Screenshot 1 - red arrow).
You select it, refresh the page and it populates your
selectedPermissions[] array (Screenshot 1 - yellow highlight).
I wasn't able to get it to re-render without a refresh but I am pretty
new at SPFx/react so you may be able to get it working smoother.
As you can see by the second screenshot, I actually did get it to work.
How you can manage all those choices and in a separate file and easily
create new configurations. Let me know if you want to do any kind of skype
or team call and I can walk you through it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<
https://github.com/SharePoint/sp-dev-fx-webparts/issues/1009?email_source=notifications&email_token=AL2ZDVRMM5AC3FPHAJOUHWLQXBQYFA5CNFSM4I3V2XP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF7HUOY#issuecomment-561936955>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/AL2ZDVT2YQMLL2IEE7BDNKDQXBQYFANCNFSM4I3V2XPQ>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SharePoint/sp-dev-fx-webparts/issues/1009?email_source=notifications&email_token=AASNDHDJQFFV3KBQBA7BD3LQXEFOHA5CNFSM4I3V2XP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGA353A#issuecomment-562151148,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASNDHEHYJUKFYR2JYRH3V3QXEFOHANCNFSM4I3V2XPQ
.

@russgove ,
Yes I did notice that groups were not showing a permission "level" in the webpart.
But since I have only tested on a subsite, I just thought it was yet to be finished.
If you need any help testing let me know...
Also note that I created a new "Issue" to add an enhancement #1081.  I think that's what we are supposed to do to track that discussion separately right?

Ah, that was not an issue , was 'as desigened' . I never show the sp groups, only AD groups.
I finished [i think] the color coding. It now lets the user select the colors as well as the person confifiguring the webpart.
I'll tale a look at your PR this weekened. So you added some preset configurations and Icons?
Can wait to have a look!

One other thing on the color PR I sent... I put a placeholder in the pre-configured object for a "Label" with the color so we can put a word that people recognize (like "Full Control") instead of "manageWebs".
Or maybe we can tap into the roles definition you already have.... (see screenshot).  Do you know if the role definitions you get back in your call are browser language dependent?  If so, maybe in our pre-configured section, we could find a way to tag a specific role and get the highlighted "name" property.

Hi,
those role definitions are configurable by the end user, so we can't rely on them. I like your idea though. I am going to add. a friendly name to display on the legend.
i just uploaded an intitial version to let you select icons.
russell
Sent from my iPad

On Dec 9, 2019, at 10:08 AM, mikezimm<EMAIL_ADDRESS>wrote:
One other thing on the color PR I sent... I put a placeholder in the pre-configured object for a "Label" with the color so we can put a word that people recognize (like "Full Control") instead of "manageWebs".
Or maybe we can tap into the roles definition you already have.... (see screenshot). Do you know if the role definitions you get back in your call are browser language dependent? If so, maybe in our pre-configured section, we could find a way to tag a specific role and get the highlighted "name" property.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hey @mikezimm  thanks again for helping make these samples better.
It looks like @russgove made some of the changes you described. I'll mark this issue as closed, but absolutely feel free to open a new issue with more suggestions.


GH-15058: [C++][Python] Native support for UUID

Rationale for this change
See #15058.
UUID datatype is common in throughout the ecosystem and Arrow as supporting it as a native type would reduce friction.
What changes are included in this PR?
This PR implements logic for Arrow canonical extension type in C++ and a Python wrapper.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes, new extension type is added.

Closes: #15058

mentioned https://github.com/apache/arrow/issues/15058#issuecomment-1687558148 , do we need to remove that?

Key error: A type extension with name uuid already defined

Looks Ruby already got support for UUID?

Hi @rok , can you please summarize where you're stuck at with UUIDs? I see some installation failures

@arogozhnikov I think it was mostly about lack of reviews :)
I've rebased, let's see what current problems are.

Integration failures seem unrelated. It would be good to check again after https://github.com/apache/arrow/pull/41264 merged to be sure.

I've opened a seperate PR for the format change. If there's no objections I'd like to call for a ML vote tomorrow.

@jorisvandenbossche any idea who'd have time to review this?

@rok I'm taking a look. Thanks for being persistent :-)

Thanks for the review @pitrou! I've addressed all comments and waiting to see if CI shakes out any problems.

@rok Github claims there are conflicts above. Can you take a look?

Also, there are test failures in Python now :-)

Rebased. I'm not sure what the value_type method missing error when pickling is about. Checking.

I think python should be ok now.

Ping @jorisvandenbossche

Thanks everyone!

Thanks a lot @rok!
As another possible follow-up, would we want to support inferring and converting uuid.UUID objects in the python->arrow conversion layer? (although not sure if that's something people would be waiting for)

@jorisvandenbossche that sounds convenient! I've opened https://github.com/apache/arrow/issues/43855 and will get around to it if someone else doesn't sooner :).


Updating the filteringTerms files when Framework schema is updated

I've created a PR in the Framework to adjust the filtering terms descriptions to the three options: ontology term, alphanumeric filter or custom filter.
If the PR is approved, the filteringTerms.json files in the Models would no longer be valid, a review and update would be necessary.

Adressed in #65