× Encountered error while trying to install package. ╰─> dpviewer

Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/DPVO/DPViewer/setup.py", line 123, in <module>
          setup(
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/__init__.py", line 87, in setup
          return distutils.core.setup(**attrs)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 148, in setup
          return run_commands(dist)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 163, in run_commands
          dist.run_commands()
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 967, in run_commands
          self.run_command(cmd)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/dist.py", line 1214, in run_command
          super().run_command(command)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/command/install.py", line 68, in run
          return orig.install.run(self)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/command/install.py", line 664, in run
          self.run_command('build')
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 313, in run_command
          self.distribution.run_command(command)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/dist.py", line 1214, in run_command
          super().run_command(command)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/command/build.py", line 135, in run
          self.run_command(cmd_name)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 313, in run_command
          self.distribution.run_command(command)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/dist.py", line 1214, in run_command
          super().run_command(command)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/command/build_ext.py", line 79, in run
          _build_ext.run(self)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 339, in run
          self.build_extensions()
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 448, in build_extensions
          self._build_extensions_serial()
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 473, in _build_extensions_serial
          self.build_extension(ext)
        File "/DPVO/DPViewer/setup.py", line 116, in build_extension
          subprocess.check_call(
        File "/root/miniconda3/envs/dpvo/lib/python3.10/subprocess.py", line 369, in check_call
          raise CalledProcessError(retcode, cmd)
      subprocess.CalledProcessError: Command '['cmake', '--build', '.', '--verbose', '-j']' returned non-zero exit status 2.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

× Encountered error while trying to install package.
╰─> dpviewer

note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.
(dpvo) root@System-Product-Name:/DPVO#

even using docker still facing the similar problem as in https://github.com/princeton-vl/DPVO issue

Hi. Are you trying to build with 11.8.1? Or something like <cuda_version>.1 ? I think there's a thread https://github.com/princeton-vl/DPVO_Docker/issues/2#issuecomment-1316192370 here that suggests to use 11.8.0 instead.
My platform:

Ubuntu 20.04
CUDA Version: 12.0 (actual Version 11.6 by checking nvcc -V)
Installing with 11.8.0

Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/DPVO/DPViewer/setup.py", line 123, in <module>
          setup(
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/__init__.py", line 87, in setup
          return distutils.core.setup(**attrs)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 148, in setup
          return run_commands(dist)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 163, in run_commands
          dist.run_commands()
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 967, in run_commands
          self.run_command(cmd)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/dist.py", line 1214, in run_command
          super().run_command(command)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/command/install.py", line 68, in run
          return orig.install.run(self)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/command/install.py", line 664, in run
          self.run_command('build')
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 313, in run_command
          self.distribution.run_command(command)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/dist.py", line 1214, in run_command
          super().run_command(command)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/command/build.py", line 135, in run
          self.run_command(cmd_name)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 313, in run_command
          self.distribution.run_command(command)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/dist.py", line 1214, in run_command
          super().run_command(command)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/command/build_ext.py", line 79, in run
          _build_ext.run(self)
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 339, in run
          self.build_extensions()
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 448, in build_extensions
          self._build_extensions_serial()
        File "/root/miniconda3/envs/dpvo/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 473, in _build_extensions_serial
          self.build_extension(ext)
        File "/DPVO/DPViewer/setup.py", line 116, in build_extension
          subprocess.check_call(
        File "/root/miniconda3/envs/dpvo/lib/python3.10/subprocess.py", line 369, in check_call
          raise CalledProcessError(retcode, cmd)
      subprocess.CalledProcessError: Command '['cmake', '--build', '.', '--verbose', '-j']' returned non-zero exit status 2.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

× Encountered error while trying to install package.
╰─> dpviewer

note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.
(dpvo) root@System-Product-Name:/DPVO#

even using docker still facing the similar problem as in https://github.com/princeton-vl/DPVO issue

yeah I face the same issue. Have you solved this

yes, you should install a more recent version of cmake. The problem is that the default Cmake in ubuntu image does not support the latest CUDA_VERSION compilation flags.
Do this to fix:
sudo apt purge -y cmake
wget https://github.com/Kitware/CMake/releases/download/v3.27.0/cmake-3.27.0-linux-x86_64.sh
chmod +x cmake-3.27.0-linux-x86_64.sh
./cmake-3.27.0-linux-x86_64.sh --skip-license --prefix=/usr/local
export PATH=/usr/local/bin:$PATH
pip install ./DPViewer

yes, you should install a more recent version of cmake. The problem is that the default Cmake in ubuntu image does not support the latest CUDA_VERSION compilation flags.
Do this to fix:
sudo apt purge -y cmake
wget https://github.com/Kitware/CMake/releases/download/v3.27.0/cmake-3.27.0-linux-x86_64.sh
chmod +x cmake-3.27.0-linux-x86_64.sh
./cmake-3.27.0-linux-x86_64.sh --skip-license --prefix=/usr/local
export PATH=/usr/local/bin:$PATH
pip install ./DPViewer

Practice has shown that this is true, I encountered this mistake:
  CMake Error at /DPVO/DPViewer/build/temp.linux-x86_64-cpython-310/CMakeFiles/CMakeTmp/CMakeLists.txt:15 (add_executable):
    CUDA_STANDARD is set to invalid value '17'

  CMake Error at /usr/share/cmake-3.16/Modules/FindCUDA/select_compute_arch.cmake:114 (try_run):
    Failed to generate test project build system.
  Call Stack (most recent call first):
    CMakeLists.txt:15 (CUDA_DETECT_INSTALLED_GPUS)

My Solution:
wget https://cmake.org/files/v3.27/cmake-3.27.0-linux-x86_64.sh
chmod +x cmake-3.27.0-linux-x86_64.sh
sh ./cmake-3.27.0-linux-x86_64.sh --skip-licence --prefix=/usr/local --exclude-subdir
echo 'export PATH=/usr/local/bin:$PATH' >> ~/.bashrc
source ~/.bashrc
cmake --version


Scatterplot layer: Radius updates

Hi,
I am observing the following problems when trying to update the radius of elements in the Scatterplot layer:
    updateCount++;
    let getScatterplot = ()=>{
      return new ScatterplotLayer({
        id: 'scatter-plot',
        data: scatterPlotData || [],
        getPosition: d => [d.lon, d.lat, d.elevation],
        getColor: d => [Math.floor(Math.random()*255), Math.floor(Math.random()*255), Math.floor(Math.random()*255)],
        getRadius: d => Math.random() * 10,
        updateTriggers: {
          instanceColors: {updateCount},
          instanceRadius: {updateCount}
        }
      });
    }

throws:
"AssertionError: undefined == true
    at AttributeManager.invalidate (http://localhost:8080/js/app.js:189025:29)
    at ScatterplotLayer._diffUpdateTriggers (http://localhost:8080/js/app.js:188791:31)
    at ScatterplotLayer.diffProps (http://localhost:8080/js/app.js:188695:15)
    at LayerManager._updateLayer (http://localhost:8080/js/app.js:190290:33)
    at LayerManager._matchSublayers (http://localhost:8080/js/app.js:190137:21)
    at LayerManager._updateLayers (http://localhost:8080/js/app.js:190089:25)
    at LayerManager.updateLayers (http://localhost:8080/js/app.js:189910:34)
    at DeckGL._updateLayers (http://localhost:8080/js/app.js:149339:13)
    at DeckGL.componentWillReceiveProps (http://localhost:8080/js/app.js:149321:13)
    at http://localhost:8080/js/app.js:31672:24"

(Visually, the example changes the colors of the dots, on each draw, but not the radii.)
Any ideas?

@MoritzStefaner You were getting this error because the 32 bit ScatterplotLayer did not have an instanceRadius attribute (radius was encoded inside instancePositions).
The referenced PR updates the code to generate better errors when referencing undefined attributes in updateTriggers, and updates ScatterplotLayer(32) to have same attributes as ScatterplotLayer64, including instanceRadius. This should fix the issue.

Ah, that makes sense! Thanks for the swift reply!

Thanks! Might be another issue, but I updated to 3.1.0 now, and get the following warnings / errors:
warning.js:36Warning: Failed prop type: Cannot call a class as a function
    in DeckGL (created by Motion)
    in Motion (created by MapView)
    in MapView (created by App)
    in div (created by App)
    in App

log.js:54Program scatter-plot-program: Attribute 2:instancePositions not supplied

(layer definition is same as above) - any ideas? Has the API changed?

https://github.com/uber/deck.gl/pull/244 landed last night, fixes the instancePositions issue. Will be published today.

The warning looks like a React PropTypes mixup. Will take a look.

@MoritzStefaner 3.1.1 published, give it a try.

I ran into the same problem and this fixed it. Thanks.

@ibgreen Works fine now, thanks!


Support OTP 25

remove deprecated :race_conditions dialyzer option
Add new :missing_return and :extra_return dialyzer options
Update Elixir/Erlang CI versions

@jjcarstens Thanks for starting this. I believe that it will pass CI once the mix.lock file pulls in the new OTP 25-based Nerves systems.

Since you DM'd that you timed out tonight, I went ahead and fixed. Here's the result is e858d6219b39ffbed8037fa73ad9004aec435c8f.


Slack integration acts as if it is mandatory

Describe the bug
I'm trying to start the API on development mode and I can't get it started because I'm missing valid environment variables for the Slack integration
To Reproduce
Steps to reproduce the behavior:

Delete all variables refering to the Slack integration from the .env file
Run the API with `yarn dev'
The app will crash

Expected behavior
Deleting the variables should allow the API to run as the integration should not be mandatory
Screenshots
If applicable, add screenshots to help explain your problem.

Possible solutions
A solution would be to check for the definition of the needed env variables before trying to initialize the SlackService. Check the screenshot below:
Before the fix

After the fix

Here we have a conditional to check for the needed variables before trying to initialize the app. The code above works for both scenarios:

When the variables are not defined at all
When the variables are in the .env file but have no value.

I can apply the fix and upload the changes if you approve this solution. Please let me know.

Thanks @bernestdev please create a Pull Request to merge this 🙌


Anyone know of a good UI kit that works with Jeet?

Just curious if anyone is combining Bootstrap or Semantic UI with Jeet with great success.

@corysimmons Hey Cory, just discovered Jeet and wondering if you can recommend any guides to using a UI Kit with Jeet.

@rpanjwani Haven't stumbled upon any. Seems pretty straight forward unless the UI kit is tangled up with the UI kit's grid system.
For instance:
<button class="btn btn-big">Click Me</button>

button
  j-column(1/2)

...should work with most UI kits unless the UI kit specifies .btn is supposed to be a certain width or something.


chore: bump TS

Summary
3.7 is out 🎉 I haven't actually tried to run this, just opening up a PR 😀
https://devblogs.microsoft.com/typescript/announcing-typescript-3-7/

Test plan
Green CI?

Yeahhhhh that looks a lot like a TS bug https://circleci.com/gh/facebook/jest/73686?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

It looks like a regression to me... @orta?

https://github.com/facebook/jest/blob/0fd5e3cdd80a866623f1f0cf2385fef38015d51f/packages/jest-circus/src/utils.ts#L101-L125

I had a quick look into this for my own learning, but I think @jeysal might be right: this looks like it might be a bug in TS.
This fixes it:
export const getEachHooksForTest = (test: Circus.TestEntry) => {
    const result: {
        beforeEach: Array<Circus.Hook>;
        afterEach: Array<Circus.Hook>;
    } = { afterEach: [], beforeEach: [] };
    let block: Circus.DescribeBlock | undefined | null;

    do {
        block = test.parent;
        const beforeEachForCurrentBlock = [];

        for (const hook of block.hooks) {
            switch (hook.type) {
                case 'beforeEach':
                    beforeEachForCurrentBlock.push(hook);
                    break;
                case 'afterEach':
                    result.afterEach.push(hook);
                    break;
            }
        }
        // 'beforeEach' hooks are executed from top to bottom, the opposite of the
        // way we traversed it.
        result.beforeEach = [...beforeEachForCurrentBlock, ...result.beforeEach];
    } while (block.parent);
    return result;
};

Here's a Playground Link for easy playing around :)

Confirmed it's a bug in TS.
It's been fixed and merged into master.
You can work around it for now by just doing const hooks = block.hooks;
The root reason is that TS creates a circular reference itself in attempting to check for exhaustiveness 😬

Thanks @G-Rath! I'll apply the workaround locally and push 👍

Wait, what's the fix? const hooks = block.hooks; does't change anything, and the first thing you pasted always does block = test.parent; which would end up in a loop, no?

Wait, what's the fix? const hooks = block.hooks; does't change anything,

Sorry I should have been clearer: You don't use hooks - it's literally the assignment of the variable before the loop causes TS to use a slightly different analysis path and so doesn't create the circular reference.
Alternatively, doing
        if (!block.hooks) {
            break;
        }

before the look would work too.

the first thing you pasted always does block = test.parent; which would end up in a loop, no?

It shouldn't, b/c the do { .... } while(block.parent) should mean it bails when the parent isn't defined.

Found a tweak that was relatively clean 🤞

Codecov Report

Merging #9145 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #9145   +/-   ##
=======================================
  Coverage   64.83%   64.83%
=======================================
  Files         278      278
  Lines       11732    11732
  Branches     2882     2882
=======================================
  Hits         7607     7607
  Misses       3508     3508
  Partials      617      617

Impacted Files
Coverage Δ

packages/jest-circus/src/utils.ts
15.38% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a7b42...2630dac. Read the comment docs.


Updating path params

I have an existing path definition in AWS API Gateway as follows:
  /equipment/{equipmentKey}:
    get:
      summary: Equipment
      description: >
        The Equipment endpoint returns a Equipment for the specified id.
      parameters:
        - name: equipmentKey
          in: path
          description: Unique identifier for the Equipment.
          type: string
          required: true
          format: string
      tags:
        - Equipment
      x-amazon-apigateway-integration:
        type: aws
        uri: arn:aws:apigateway:us-east-1:lambda:path/2015-03-31/functions/arn:aws:lambda:us-east-1:XXXXXXXXXXXX:function:GetEquipment/invocations
        credentials: arn:aws:iam::XXXXXXXXXXXX:role/lambda_gateway_execution
        httpMethod: POST
        requestTemplates:
          application/json: |
            "${input.params('equipmentKey')}"
        responses:
          default:
            statusCode: "200"
            responseParameters:
              method.response.header.Access-Control-Allow-Headers : "'Content-Type,X-Amz-Date,Authorization,X-Api-Key'"
              method.response.header.Access-Control-Allow-Methods : "'*'"
              method.response.header.Access-Control-Allow-Origin : "'*'"
          Error 404.*:
            statusCode: "404"
          Error:.*:
            statusCode: "500"
      responses:
        '200':
          description: A single Equipment.
          headers:
            Access-Control-Allow-Headers:
              type: "string"
            Access-Control-Allow-Methods:
              type: "string"
            Access-Control-Allow-Origin:
              type: "string"
          schema:
            $ref: '#/definitions/Equipment'
        '404':
          description: Unexpected error
          schema:
            $ref: '#/definitions/Error'
        '500':
          description: Unexpected error
          schema:
            $ref: '#/definitions/Error'

When I try to run --update and --deploy with the definition changed to be as follows (changed the path param from equipmentKey to id and from a string to integer) I receive the error following the changed path definition below.
  /equipment/{id}:
    get:
      summary: Equipment
      description: >
        The Equipment endpoint returns a Equipment for the specified id.
      parameters:
        - name: id
          in: path
          description: Unique identifier for the Equipment.
          type: integer
          required: true
          format: int32
      tags:
        - Equipment
      x-amazon-apigateway-integration:
        type: aws
        uri: arn:aws:apigateway:us-east-1:lambda:path/2015-03-31/functions/arn:aws:lambda:us-east-1:XXXXXXXXXXXX:function:GetEquipment/invocations
        credentials: arn:aws:iam::XXXXXXXXXXXX:role/lambda_gateway_execution
        httpMethod: POST
        requestTemplates:
          application/json: |
            "${input.params('id')}"
        responses:
          default:
            statusCode: "200"
            responseParameters:
              method.response.header.Access-Control-Allow-Headers : "'Content-Type,X-Amz-Date,Authorization,X-Api-Key'"
              method.response.header.Access-Control-Allow-Methods : "'*'"
              method.response.header.Access-Control-Allow-Origin : "'*'"
          Error 404.*:
            statusCode: "404"
          Error:.*:
            statusCode: "500"
      responses:
        '200':
          description: A single Equipment.
          headers:
            Access-Control-Allow-Headers:
              type: "string"
            Access-Control-Allow-Methods:
              type: "string"
            Access-Control-Allow-Origin:
              type: "string"
          schema:
            $ref: '#/definitions/Equipment'
        '404':
          description: Unexpected error
          schema:
            $ref: '#/definitions/Error'
        '500':
          description: Unexpected error
          schema:
            $ref: '#/definitions/Error'

Error:
2015-12-08 15:24:41,450 INFO - Creating resource '{id}' on XXXXXX
2015-12-08 15:24:41,597 ERROR - Error importing API definition
com.amazonaws.services.apigateway.model.BadRequestException: Resource with id 'null' has more than o
ne variable component as a direct child: [{equipmentKey}, {id}] (Service: null; Status Code: 400; Er
ror Code: null; Request ID: b6cc47fc-9de9-11e5-8a67-63e272a659cc)
        at com.amazonaws.http.AmazonHttpClient.handleErrorResponse(AmazonHttpClient.java:1239)
        at com.amazonaws.http.AmazonHttpClient.executeOneRequest(AmazonHttpClient.java:823)
        at com.amazonaws.http.AmazonHttpClient.executeHelper(AmazonHttpClient.java:506)
        at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:318)
        at com.amazonaws.hal.client.HalClient.invoke(HalClient.java:235)
        at com.amazonaws.hal.client.HalClient.postResource(HalClient.java:98)
        at com.amazonaws.hal.client.HalResourceInvocationHandler.invoke(HalResourceInvocationHandler
.java:117)
        at com.sun.proxy.$Proxy32.createResource(Unknown Source)
        at com.amazonaws.service.apigateway.importer.impl.sdk.ApiGatewaySdkApiImporter.createResourc
e(ApiGatewaySdkApiImporter.java:233)
        at com.amazonaws.service.apigateway.importer.impl.sdk.ApiGatewaySdkSwaggerApiImporter.create
Resources(ApiGatewaySdkSwaggerApiImporter.java:157)
        at com.amazonaws.service.apigateway.importer.impl.sdk.ApiGatewaySdkSwaggerApiImporter.update
Resources(ApiGatewaySdkSwaggerApiImporter.java:374)
        at com.amazonaws.service.apigateway.importer.impl.sdk.ApiGatewaySdkSwaggerApiImporter.update
Api(ApiGatewaySdkSwaggerApiImporter.java:83)
        at com.amazonaws.service.apigateway.importer.impl.ApiGatewaySwaggerFileImporter.updateApi(Ap
iGatewaySwaggerFileImporter.java:58)
        at com.amazonaws.service.apigateway.importer.ApiImporterMain.execute(ApiImporterMain.java:14
3)
        at com.amazonaws.service.apigateway.importer.ApiImporterMain.main(ApiImporterMain.java:74)

I would expect this change to update without issue but is there a reason this shouldn't work?

Looks like a bug. To get you unblocked, just remove the method from your Swagger, update, and then add the new one back and update again

Thank you, is this a bug with the importer or with API Gateway itself?

@etzlers
It looks like a bug with the importer. As workaround, you can follow what @rpgreen mentioned. We will prioritize to fix this issue.

Swagger/OpenAPI import is now generally available in the API Gateway REST API, the AWS CLI and all AWS SDKs. You can also import and export Swagger definitions using the API Gateway console. This release addresses many of the open issues and feedback in this repository.
I would encourage you to migrate your workflow to the standard AWS tools. aws-apigateway-importer will receive minimal support from the API Gateway team going forward.
Any feedback or issues with the new importer should be directed to the official API Gateway forums.
Thanks,
Ryan

Hey I am getting same error, looks like not yet fixed.
   "/travelPlan/{travelNumber}/{windowStartTime}": {
      "get": {
        "tags": [
          "travel-plan-controller"
        ],
        "summary": "gettravelPlanBytravelNumberAndDate",
        "operationId": "gettravelPlanBytravelNumberAndDateUsingGET",
        "consumes": [
          "application/json"
        ],
        "produces": [
          "application/json"
        ],
        "parameters": [
          {
            "name": "travelNumber",
            "in": "path",
            "description": "travelNumber",
            "required": true,
            "type": "string"
          },
          {
            "name": "windowStartTime",
            "in": "path",
            "description": "windowStartTime",
            "required": true,
            "type": "ref"
          }
        ],
        "responses": {
          "200": {
            "description": "OK",
            "schema": {
              "type": "array",
              "items": {
                "$ref": "#/definitions/travelPlan"
              }
            }
          }
        }
      }
    },
    "/travelPlan/{travelPlanID}": {
      "get": {
        "tags": [
          "travel-plan-controller"
        ],
        "summary": "gettravelPlanBytravelPlanID",
        "operationId": "gettravelPlanBytravelPlanIDUsingGET",
        "consumes": [
          "application/json"
        ],
        "produces": [
          "application/json"
        ],
        "parameters": [
          {
            "name": "travelPlanID",
            "in": "path",
            "description": "travelPlanID",
            "required": true,
            "type": "string"
          }
        ],
        "responses": {
          "200": {
            "description": "OK",
            "schema": {
              "$ref": "#/definitions/travelPlan"
            }
          }
        }
      }
    },

 2016-04-13 14:17:55,009 ERROR - Error importing API definition
com.amazonaws.services.apigateway.model.BadRequestException: Resource with id 'null' has more than one variable component as a direct child: [{travelNumber}, {travelPlanID}] (Service: null; Status Code: 400; Error Code: null; Request ID: 696adb1a-0154-11e6-9a83-2f6b8d40333a)
  at com.amazonaws.http.AmazonHttpClient.handleErrorResponse(AmazonHttpClient.java:1389)
  at com.amazonaws.http.AmazonHttpClient.executeOneRequest(AmazonHttpClient.java:902)
  at com.amazonaws.http.AmazonHttpClient.executeHelper(AmazonHttpClient.java:607)
  at com.amazonaws.http.AmazonHttpClient.doExecute(AmazonHttpClient.java:376)
  at com.amazonaws.http.AmazonHttpClient.executeWithTimer(AmazonHttpClient.java:338)
  at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:287)
  at com.amazonaws.hal.client.HalClient.invoke(HalClient.java:235)
  at com.amazonaws.hal.client.HalClient.postResource(HalClient.java:98)

This case is actually different.  API Gateway's built-in importer creates intermediate resources for you (even if they don't have methods associated with them) since every resource needs to have a parent.  That means that this Swagger file would result in resources with the following paths if the import was successful:
/
/travelPlan
/travelPlan/{travelPlanID}
/travelPlan/{travelNumber}
/travelPlan/{travelNumber}/{windowStartTime}
In this case, /travelPlan/{travelPlanID} and /travelPlan/{travelNumber} are ambiguous because API Gateway doesn't know which one you meant if an operation was performed on it.  A (good) argument could be made that if the methods don't also conflict, there isn't any ambiguity and so should be allowed.  I will add this for consideration to API Gateway's backlog.
In the meantime, a workaround would be to rename the variable to something like {travelPlanIDorNumber} and use that in both Swagger paths.


[spaceship] add new languages

Hi Guys
With spaceship can i do that?

Is it possible to add a new version for an app with Spaceship?
Is it possible to add a new language for an app with Spaceship?

B

Yes, it supports all that, please check out the source code for more information
e.g. https://github.com/fastlane/fastlane/blob/master/spaceship/lib/spaceship/tunes/application.rb#L153 and https://github.com/fastlane/fastlane/blob/master/spaceship/lib/spaceship/tunes/app_version.rb#L197

I hope that helps, feel free to submit a PR improving the docs if you feel like it helps other users, any help appreciated 👍

@KrauseFx thanks

hope that helps, feel free to submit a PR improving the docs if you feel like it helps other users, any help appreciated

sure

Awesome, thanks @bolom 👍

@KrauseFx i don't see in the doc a way to delete a screenshoot. We can just upload?

You can also delete, you might want to dive into the deliver source code, which does all of those things 👍

ah thanks @KrauseFx


Add number representation assists

Reimplemented assists from this PR https://github.com/rust-analyzer/rust-analyzer/pull/3683 with current APIs.

I've decided not to add options about size of the groups so behaviour is similar to clippy's.
Minimal number length is also taken from clippy.

Thanks!
bors r+


Hello when insert an Item it uses the json file but when quering it loads the whole index in memory

Hello thank you for this project, I want to understand it correctly when adding new index with embedding it appends to json file but when queering it loads entire index into memory (first is that correct please?)
The questions is if I have thousand of embedding in  an index it will overload the memory how to prevent that, is there a way to do similar search in-disk instead of in-memory please?
cc @Stevenic

what is the difference between vectra and HNSWLib please? cc @Stevenic

Hey there @hamidpro sorry for the delay... You are correct... Vectra loads the entire index into memory which is what makes it so fast.  It's really geared for smaller indexes with maybe a few thousand entries.  If you have hundreds of thousands of entries or your entries change a lot then you're probably better off using something else.  I haven't looked too closely at HNSWLib but it looks pretty good from what I've seen.  I built vectra because I wanted something insanely fast that would do everything against a small in-memory vector db. I also wanted something that was free. :)
i'm not sure you'll find anything faster then vectra but that speed comes with tradeoffs. There are lots of improvements that could be made to vectra but there are so many other choices, like HNSWLib, that have a ton of bells and whistles that I don't see the point in trying to compete with those libraries feature for feature.  I'd love to add re-ranking for example but even that feature requires adding a bunch of complexity I'm not crazy about.


Suppress stack trace so users can focus in message.

Addresses https://github.com/scala-js/scala-js/issues/3596#issuecomment-502246833
From Scala.js user perspective, long stack trace of LinkingException does not help.

I don't think this is the best way to improve this. Instead I think the sbt plugin should catch LinkingExceptions, and turn them into sbt's MessageOnlyException. The stack trace should be preserved for other use cases than the sbt plugin.


Setting STAN_NUM_THREADS to illegal value should produce an error

From @martinmodrak on July 23, 2018 14:29
Summary:
Illegal values of STAN_NUM_THREADS now make the library use one thread. An error should be thrown instead.
Description:
As discussed on the forums, the current behavior of using one thread when STAN_NUM_THREADS has unusable value should be changed to throwing an error. Unusable values are:

Non-integer values (including trailing chars after an integer, e.g. 1H should still be illegal, despite some C functions being willing to parse it to integer as 1).
Negative values less than -1 (-1 is reserved for as many threads as there are cores)
Zero

Current Version:
v2.18.0
Copied from original issue: stan-dev/stan#2591

From @wds15 on July 23, 2018 16:52
thanks for opening the issue, but we need to move this to stan-math where the change needs to be done. There is an issue mover, but I don't recall where and how.


plyr not loaded with Require.js define dependency

Hi,
I'm trying to load plyr via Require.js by using a module dependency like that:
define(['jquery', 'plyr'], function (jquery, plyr) {
plyr.setup(); // plyr is null
});
But the problem is that plyr is null.
I didn't used shim option since I saw that plyr is using define as expected by Require.js.
Do you have any idea why is this not working ? I also tried to do a require directly, but same result the module plyr is not loaded.

For information I fixed the problem by changing the module declaration inside plyr.js file like so:
 } else if (typeof define === 'function' && define.amd) {
// AMD
define([], function () { return factory(root, document); });
} else {
As you can see I changed the null value by an empty array and I return the value from the factory so that I can use the plyr setup method in my own module.
I don't know if I'm doing right since I'm completely new on require.js, but for development purpose I will work like that for now. If you can enlight me on that issue when you get time, I'll appreciate :+1:
Thank you for you help!

Sorry, I'm going to need some help with this one. I've not used the module setup a great deal myself.

Hi Sam,
I don't really know the changes required here but what I know is that I passed last couple of days to implement requirejs with node.js and the way the files or optimized and required is just a pain in... so I checked and it seems that webpack is the new robust method for that. So I'll change my implementation of plyr and will come back to you if I got better knowledge on AMD modules.

@SamPotts I can confirm that @franceer's implementation helped me integrate this correctly with require.js.

To add more info on this. I now use webpack with node.js to build my js files and the problem went away. For those using node.js, webpack seems so much better than require.js :)

This should be fixed in v1.9.0 - could you give it a go? Bear in mind there were also several breaking changes so check the changelog

The problem persist in 2.0.5, just tried it

Feel free to jump in a with PR. Cheers

I missed to specify that the fix that was merged above (#326) is not in 2.0.5. I don't know if this is wanted (because it was merged after that release or whatever) or not

You're right! I think it's been lost in another merge. I'll re-add it now. Sorry about that.

Just pushed a new version with the merge fixed up. Let me know if that's fixed it? 👍

yay it works! Thank you

@SamPotts I think we can close this 😄

Ta

Hi ,
It is not working for me
requirejs.config({
baseUrl: 'js',
paths: {
    'jquery':'jquery',
    'bootstrap':'lib/bootstrap.min',
    'greensock':'lib/TweenMax.min',
    'waypoint':'lib/jquery.waypoints.min',
    'modernizr':'lib/modernizr',
    'aos':'lib/aos',
    'plyr':'lib/plyr',
    'home':'home',

},
shim: {

    'modernizr': [ "jquery" ],
    'bootstrap': ["jquery"],
    'aos': ["jquery"],

},

});
define(['jquery','modernizr','aos','greensock','waypoint','enhance','bootstrap','plyr'], function($,modernizer,AOS) {
$(document).ready(function(){
plyr.setup();
});
});


Merge master branch to prTesting1_201903121019 branch

OPS Build status updates of commit 89b98ad:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


introduce Count

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 7 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.05%) to 6.537%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

hi.go
0
7
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
64

Relevant Lines:
979

💛  - Coveralls


LND erroring out when restoring wallet with funds and open channels with funds

Background
I had a running copy of lnd on a Raspberry Pi 3, and ran out of diskspace due to the growth of the blockchain so it crashed and I could not restore it.  I built a new machine, sync'ed bitcoind and installed lnd. I created a wallet based on my old password and seed words. Initially it came up to sync, but is now crashing immediately. I had funds in both the wallet and channels. I understand the issue with channel funds, and am primarily after the wallet funds that are on-chain, but the restore of funds using create does not seem to be working.
I think I can restore the funds by using my 24 seed words on a standard wallet and transferring them from there, but I thought it was good to report this since it seems to be a bug.
Your environment

lnd version 0.11.1-beta commit=v0.11.1-beta
Ubuntu 20.04.1 LTS
Bitcoin Core version v<IP_ADDRESS>-b99a1633b

Steps to reproduce
Generally a common setup. One difference this has is that it is using REST due to a web service on this machine:
restlisten =localhost:8888
lnd& causes this error for me.
Expected behavior
I would expect to see the wallet funds, but none of the channels that were previously set up.
Actual behavior
[INF] CHBU: Starting chanbackup.SubSwapper
2020-11-08 19:11:30.282 [ERR] LTND: unable to start server: unable to refresh backup file: unable to extract on disk encrypted SCB: chacha20poly1305: message authentication failed

It sounds like you perhaps started lnd on this machine previously with another seed. It's trying to update the existing channel backup but that is encrypted with another wallet seed.
Try removing (perhaps make a backup of the file somewhere, just in case) the file in ~/.lnd/data/chain/bitcoin/mainnet/channel.backup.
Or if you did run a node on this machine before (maybe just while trying something out?), maybe you're better off renaming the whole .lnd folder to something else and starting over cleanly.

moving the channel.backup to a new filename and restarting lnd solved the problem. Thanks!


Snowflake + BigQuery ADBC drivers for Java

What feature or improvement would you like to see?
Hey all, now that there's an ADBC driver for both BigQuery and Snowflake, I was wondering what it might take to have these available in Java as well?
Is there any possibility of creating bindings to the Go driver similar to Python and other languages, or does it have to be implemented purely in Java? Unfortunately, neither the Snowflake nor BigQuery JDBC drivers expose any way to use the Arrow results directly... you always have to go through the JDBC conversion. I'd love to be able to query those DWHs and keep the results in Arrow the entire time.

My plan is still to try to create JNI bindings, yes. If that's acceptable I'd like to start on that when I get a chance. The JDBC drivers would not be preferable for the reasons you list, but maybe eventually we'd have to work something out if pure-Java is a hard requirement.

Awesome!! I don't have much experience with bindings between languages so not sure how much I can contribute code-wise, but more than happy to help with testing!

Duplicate of #2027.


docs: Add documentation

Title.

Self-approved.

why did you delete the license?

why did you delete the license?

Wait, I did?

why did you delete the license?

Wait, I did?

why did you delete the license?

Wait, I did?

I have no idea with that then. I just moved to MIT and it still shows up in the branch though.

oh ok


I can't integrate your wonderful library into my react native

Hello
I can't integrate your wonderful library into my react native project
I'm getting an error
error
error: bundling failed: Error: Unable to resolve module lune from D:\projeckts\compass-react-native-non-expo-master\src\Compass.js: Module lune does not exist in the Haste module map
This might be related to https://github.com/facebook/react-native/issues/4968
To resolve try the following:

Clear watchman watches: watchman watch-del-all.
Delete the node_modules folder: rm -rf node_modules && npm install.
Reset Metro Bundler cache: rm -rf /tmp/metro-bundler-cache-* or npm start -- --reset-cache.
Remove haste cache: rm -rf /tmp/haste-map-react-native-packager-*.
at ModuleResolver.resolveDependency (D:\projeckts\compass-react-native-non-expo-master\node_modules\metro\src\node-haste\DependencyGraph\ModuleResolution.js:183:15)
at ResolutionRequest.resolveDependency (D:\projeckts\compass-react-native-non-expo-master\node_modules\metro\src\node-haste\DependencyGraph\ResolutionRequest.js:52:18)
at DependencyGraph.resolveDependency (D:\projeckts\compass-react-native-non-expo-master\node_modules\metro\src\node-haste\DependencyGraph.js:283:16)
at Object.resolve (D:\projeckts\compass-react-native-non-expo-master\node_modules\metro\src\lib\transformHelpers.js:264:42)
at dependencies.map.result (D:\projeckts\compass-react-native-non-expo-master\node_modules\metro\src\DeltaBundler\traverseDependencies.js:399:31)
at Array.map ()
at resolveDependencies (D:\projeckts\compass-react-native-non-expo-master\node_modules\metro\src\DeltaBundler\traverseDependencies.js:396:18)
at D:\projeckts\compass-react-native-non-expo-master\node_modules\metro\src\DeltaBundler\traverseDependencies.js:269:33
at Generator.next ()
at asyncGeneratorStep (D:\projeckts\compass-react-native-non-expo-master\node_modules\metro\src\DeltaBundler\traverseDependencies.js:87:24)
DELTA  [android, dev] ./index.js ░░░░░░░░░░░░░░░░ 0.0% (0/1), failed.

package.json
{
"name": "CompassReactNative",
"version": "0.0.1",
"private": true,
"scripts": {
"start": "react-native start",
"test": "jest"
},
"dependencies": {
"luna": "^1.6.3",
"react": "16.8.6",
"react-native": "0.60.5",
"react-native-easy-grid": "^0.2.1",
"react-native-sensors": "^5.3.0",
"suncalc": "^1.8.0"
},
"devDependencies": {
"@babel/core": "^7.5.5",
"@babel/runtime": "^7.5.5",
"babel-jest": "^24.8.0",
"jest": "^24.8.0",
"metro-react-native-babel-preset": "^0.55.0",
"react-test-renderer": "16.8.6"
},
"jest": {
"preset": "react-native"
}
}

I'm afraid I can't help here! It looks like the error is happening outside this project, and I'm afraid I don't know anything about react-native. Sorry :(

I will never forgive myself for this mistake
I wrote LUNA instead of LUNE


Setting the pose of the models through code

Hi, we want to test out our method for various problem configurations such as different initial locations of the vessels.
In Gazebo, there is a topic or service /gazebo/set_model_state that is subscribed by Gazebo and change the states of the models.
Is there any way to do this in the provided simulator?
Thank you!

yeah we have a service for teleporting entities. Assuming your USV is named usv, you can move it like so:
ign service -s /world/coast/set_pose --reqtype ignition.msgs.Pose --reptype ignition.msgs.Boolean --timeout 300 --req 'name: "usv", position: {x: -1400, y: 1, z: 0.3}'


Design a Logo and Add it as Favicon to Enhance Brand Credibility

Under gssoc-exd2024 :
The ML Fusion Labs platform currently lacks a logo, which impacts brand identity and recognition. A logo is essential for building user trust and brand credibility. Additionally, a favicon (a small icon visible in the browser tab) would improve the user experience by providing a visual cue associated with the website.
This issue involves two tasks: designing a logo for ML Fusion Labs and adding it as a favicon on the website.
A logo will improve brand recognition and build trust among users.
A favicon enhances user experience by giving a visual cue on the browser tab, making the website more professional.

Hi @manninookala, assigned this issue.
make sure to join discord channel: https://discord.gg/FZxBRpTEeH, for further communication and updates.
make sure to complete this issue for the next 2 days.

@vivekvardhan2810
Resolved the Issue, added the favicon & Logo.
Added it to the pull request.
Thank you.

@manninookala why did you close the issue

@vivekvardhan2810 I have fixed the issue and added it to the pull request. So I have closed the Issue.
Am I not allowed to close it this way?

@manninookala No you shouldn't close, untill i merge it. I am reopening this issue.
Once i will merge it then i will close this issue.

@vivekvardhan2810 Ok. Thanks for letting me know. This is my first time contributing. Thanks for letting me know.


question: how does it work?

Hello,
Awesome project!
I have a question before spending the time using it:
I deployed k8s on CoreOs before: one would setup a cluster, which uses etcd for discovery: you need 3 nodes+ to get started. Flannel then uses etcd for communication in the cluster, and then docker runs using flannel as its networking layer. Once docker runs then k8s can use it to deploy / orchestrate containers.

Are you running docker in docker, with the lower level docker some priviledge container using the host networking layer?

Hello @streamnsight!
I can clearly understand your confusion, it took me some month to get understanding fully in this topic.
This is how kubernetes-on-arm works:
First time only

Write the sd card
On first boot, run kube-config install. That installs everything Kubernetes needs.
Reboot

Every other case:

The node starts up
If Kubernetes is enabled by kube-config earlier, everything starts up by automatically

Otherwise, run kube-config enable-master or kube-config enable-worker, depending on whether if you have setup it before

Step one: system-docker starts up. This is a system docker daemon, which runs services that the main docker daemon needs.
Step two: etcd starts up on system-docker. It uses the /var/lib/etcd directory as data store.
Step three: flannel starts up on system-docker. It uses etcd as data store for the FLANNEL_SUBNET. Outputs a subnet file to /var/lib/flannel/subnet.env.
Step four: Now the main docker daemon is started. It uses the flannel subnet file.
Step five: The k8s-(master|worker) service is started. These services contains two containers at the moment: kubelet and kube-proxy. kube-proxy just manages the network, separately of the other things.
Step six: kubelet starts up and if no master services is running (and it is a master) it will start the three master containers: apiserver, controller-manager and scheduler.

After that Kubernetes is up and running
Upstream docs: https://github.com/kubernetes/kubernetes/blob/master/docs/getting-started-guides/docker-multinode.md
What is hyperkube?
It's Kubernetes all-in-one binary. It includes kubelet, kube-proxy, apiserver, controller-manager and scheduler.
So, instead of maintaining five different binaries (and docker images) one is much easier.
Why do one want this system? It's so complicated!
This issue discusses it: https://github.com/kubernetes/kubernetes/issues/13424#issuecomment-136574485
This is a very flexible system, package the binaries and other required things into one docker image, and you don't have to think about which OS the container then lands on.
It's also very easy to tear down:
kube-config disable stops Kubernetes
docker rmi $(docker images -q) removes all docker images and includes the kubernetes images.
What is the difference between kube-config and kubectl?
The difference is that kubectl manages the cluster, which pods you run... Basicly everything that Kubernetes has to offer.
kube-config is my own utility for installing Kubernetes on ARM, it starts and stops Kubernetes on a node, makes it possible to build the binaries yourself, outputs some machine info and installs the required packages for running Kubernetes.
Hope this helps!

Thanks!
my only remaining confusion is with etcd: you say it uses /var/lib/etcd for storage but don't you need 3 nodes to even get it started?
Other question about building: all this happens on the Pi, right? Have you looked at cross compiling binaries on another machine to make things faster?
Can I up the version numbers in the version file to get latest k8s? or is there known issues? (i'd like to use v1.1.1)
Thanks

Hello @yorele
No, etcd doesn't have to be clustered, it works fine with just one instance (it elects itself as leader)
Yes, everything builds on the Pi
The only way I think could make it faster is to use a Scaleway machine.
 This makes sense because of cAdvisor: https://github.com/kubernetes/kubernetes/issues/8772
Yes, there are known issues with v1.1.1 and higher when building on non-amd64 platforms: https://github.com/kubernetes/kubernetes/issues/17060
But, it shouldn't be hard to patch that on a separate patch branch.
And yeah, you only have to edit the value in images/version.sh
I'm working on a quite big release just now, v0.6.0, here I described some of the new features: https://github.com/luxas/kubernetes-on-arm/issues/2#issuecomment-155439315

do i understand that this recent PR to k8s https://github.com/kubernetes/kubernetes/pull/13901#issuecomment-156572186 is meant to take over some of your deployment steps?

@streamnsight Yes and no.
When this gets merged, it won't affect this project at all.
However, I always strive to share as much as possible code with core Kubernetes.
So maybe something will be common.
But you are free to use any deployment strategy, of course :)

@streamnsight Just be aware that master is equal to v0.5.8, while dev the branch is where I push new (sometimes unstable, used for testing) code. When I consider dev ready, it will be merged to master as v0.6.0

@luxas
Seems like it should be possible to compile on x86 or x64 using qemu, even in docker
Check out these 2 projects:
https://github.com/dweinstein/dockerfile-qemu-arm-chroot
https://github.com/moul/docker-binfmt-register
The second one is the easiest to get started with qemu in docker, but you'll need to put you data in a volume as explained in the first one.
I got my ARM images to run on my ubuntu x64 machine in a few minutes.
However, at this point, compiling kubernetes does not work because of a bug in go 1.5, but it seems like it should be fixed in 1.5.2 (see https://github.com/golang/go/issues/13024)

Thanks for the links.
I will investigate it.
Yes, I agree that it would be nice if one could compile this on amd64 machines.

On 16 Nov 2015, at 20:54, streamnsight<EMAIL_ADDRESS>wrote:
@luxas
Seems like it should be possible to compile on x86 or x64 using qemu, even in docker
Check out these 2 projects:
https://github.com/dweinstein/dockerfile-qemu-arm-chroot
https://github.com/moul/docker-binfmt-register
The second one is the easiest to get started with qemu in docker, but you'll need to put you data in a volume as explained in the first one.
I got my ARM images to run on my ubuntu x64 machine in a few minutes.
However, at this point, compiling kubernetes does not work because of a bug in go 1.5, but it seems like it should be fixed in 1.5.2 (see golang/go#13024)
—
Reply to this email directly or view it on GitHub.

@yorele Now I've released v0.6.0 which features v1.1.2 k8s as you requested.

@streamnsight Now I've made it possible to compile Kubernetes for ARM on a amd64 machine.
https://gist.github.com/luxas/e319b314f22b18243b1d
Thanks for the links you gave me earlier. They helped.
I'll close this now. If you have additional questions, just ask :)

awesome... thanks!

Awesome Christmas gift
awesome... thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/luxas/kubernetes-on-arm/issues/16#issuecomment-167356082
.


Blog post about backward compatibility

To be published tomorrow.

Ping @davidzchen to make sure the blog is re-published, I do not think things are automated yet.

Who can review/approve this?

I assigned @damienmg as a reviewer, please pick a team member as reviewer for your next blog post.

I've made some edits and have some questions - see the updated .md file

Above I suggested changing a line to "If your tests with the new change are successful, you can update to the new version", but "tests" is a bad word to use in this context as well because I don't mean "bazel test".
Maybe something like:
"After verifying your project with the released changes, you can update to the new version."

LGTM!
Yes, we can use "flag".
Yes, we should announce when a flag is removed.
Yes, as long as the flag is present, user can decide to enable or disable it.
It's primarily for Skylark, but it may be used for the rest of Bazel.
I'm going on vacation, feel free to push with your changes.
Thanks a lot!

Okay thanks, Laurant I'll make these last changes on Monday.
Have a good vacation!

@damienmg
Damien,
Before we publish this blog post, I'd like to confirm the following with the larger Bazel team:

Can you confirm if the larger Bazel team is introducing incompatible changes (so elsewhere in the code, not just in the extensions/skylark area)? If so, we will need a topic about backward compatibility outside of the extensions section (currently: https://docs.bazel.build/versions/master/skylark/backward-compatibility.html).
Is everyone okay with the process to introduce incompatible changes behind flags (need to confirm especially if other teams are introducing incompatible changes)? If we're announcing this we need to do it consistently.
Is everyone okay with the process to announce the progression of incompatible changes in the release notes? If so, I'll add info about this to the contribute page (I'm working on a section about doc contributions).
Blog post states that once we hit 1.0, major versions will be ~once a year. This okay to state?

My  take:

Yes we encourage people to use flags for incompatible changes. Let's not block this blog post on reshuffling other documentation. Feel free to update it later after documentation is updated.
Yes, but not all incompatible changes need to have a flag (it is up to individual teams on case-by-case basis)
Yes - they MUST be announced in release notes
Yes.

Dmitry was faster than I, seconding what Dmitry said.

Thanks Dmitry and Damien - if not all incompatible changes need a flag, we need a bit of rewording. PTAL, after these change I'm okay with publishing.
Changes:

reworded a line to: "For most breaking changes, we will add a flag"
added:  "Verify your project again with the new version, as some small incompatible changes are not introduced behind flags."

@damienmg and @dslomov can you look at the two changes above and let me know if this is good to publish?

LGTM

It's still not on https://blog.bazel.build/?

ping @davidzchen for a deployment.


RedGifs extractor seems to cache the auth/temporary token and never expire it

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2022.10.04 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
I am using commit 2530b68d4476fe6cb4b25897b906cbb1774ca7c9 (10/21/2022) as a library in a long running Python process to download videos from Redgifs. There have been recent changes to Redgifs that require an auth token, and I'm extremely impressed with how quickly this project has been able to keep up.
I noticed that when my Python process starts, the first few downloads have no issue. The following logs are written to stdout for the first download:
[RedGifs] video_name: Fetching temporary token
[RedGifs] video_name: Downloading video info

Subsequent downloads seem to skip fetching the token; I am guessing it gets cached.
[RedGifs] video_name: Downloading video info

I am using the following code to check that a video exists before it gets downloaded, and it fails here:
            with YoutubeDL({}) as ydl:
                info = ydl.extract_info(url, download=False)
                assert info['url']

Once the token expires, I start to see
ERROR: [RedGifs] video_name: Unable to download JSON metadata: HTTP Error 401: Unauthorized (caused by <HTTPError 401: 'Unauthorized'>); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U

So,

I think the cached token should be invalidates after some TTL
If there is some way (via an option or something) to invalidate the cached token, that works too.

I won't speculate any further since I'm already making an assumption about the token being cached.
Thanks all. If someone can check my assumption and maybe point me at the token code, I'll see if I can submit a PR myself.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
This is covered in the problem description.

Looking at the code some, what do you think about this solution? Note I am new to this codebase as of a few minutes ago.
https://github.com/yt-dlp/yt-dlp/blob/c66ed4e2e5b1a904687120afda0003b77d326c22/yt_dlp/extractor/redgifs.py#L81
Here perhaps HTTP 401 could be handled by removing the authorization header from self._API_HEADERS, and then the request can be retried.

That seems like a good idea. I would wrap in a try-except and call self._fetch_oauth_token(video_id) on 401 only, then retry the _download_json.

Hmm... I started a fix, but I think it's trickier. Just from reading, it seems that the implementation of PostProcessor._download_json from common.py handles HTTPError and may not re-raise. I was trying to follow where the error gets logged, but the indirection from __create_download_methods makes that not really very straightforward. I see that some extractors override _download_json, and I wonder if that will be needed here too.
I'll work on something, but don't let me stop someone more familiar with the code from stepping in with a quick fix. :)

you can use something like this:
try:
    self._download_json(...)

except ExtractorError as e:
    if not isinstance(e.cause, urllib.error.HTTPError) or e.cause.code != 401:
        raise

    ...

Thanks, I made the fix and tested it under a debugger. Opening a PR now.

FWIW the linked PR has been running just fine in my long-running Python process, so for me the issue is resolved.

I hope we can get a merge ASAP if the pull is good


[io] SpecH5 seg fault when the file is not spec file

If possible test the file before opening it with the C code to check that it is spec and raise an IOError instead of set fault.

We need to figure out a reasonable criterion for determining that a file is indeed a spec file, without having to read the complete file. Is it good enough to ensure that there is a "\n#S" or a "\n#F" within the first N lines ? N=100 or N=10?
Can there be exotic cases where the file starts with many comment lines (#C), or any other header or empty lines?

PyMca is just testing the first 2 lines to start by #F or #S and nobody has complained yet ...


Freshdesk access

Any chance I could get access to the repository of incoming info@ requests for usability research?

Sure thing, Jane.  I'll add you as an agent now. Let me know if you have questions.


Link to 'Manage Local Users' points to Windows 7 and Server 08 to 12 page

Under How to manage local user accounts the link to Manage Local Users points to the page for Windows 7, Windows Server 2008, Windows Server 2008 R2, Windows Server 2012. Is the info still relevant to Windows 10, Windows Server 2016 and Windows Server 2019; since the information on the Local Accounts page is related to them?
I also get the below alert on that page, which lead me to think that something changed:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 74d32ee6-c7ff-9328-97d6-40ad82c73392
Version Independent ID: 01f10cbb-4cae-077f-8245-7b0ada8305d7
Content: Local Accounts (Windows 10)
Content Source: windows/security/identity-protection/access-control/local-accounts.md
Product: w10
Technology: windows
GitHub Login: @DulceMontemayor
Microsoft Alias: dansimp

@officedocsbot assign @jvsam

Hm, that is an interesting link combination. The link you refer to is initially a TechNet link, but it changes to a docs.microsoft.com link:

https://technet.microsoft.com/library/cc731899.aspx (which redirects to the link below)
https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2008-R2-and-2008/cc731899(v=ws.11)?redirectedfrom=MSDN

I wonder if there is any existing Docs page it could be linked to instead, or if that role has been replaced by Azure or Domain Controller management.

Is the info still relevant to Windows 10, Windows Server 2016 and Windows Server 2019; since the information on the Local Accounts page is related to them?

Hi @Amorpheuz, thanks for your feedback. The alert is normal, but I understand that it may be confusing since the link points to information related to the previous versions. @illfated, I thought of the same thing, but in the Active Directory Accounts, it implies the information is still relevant for 'default local user accounts for a member or standalone server or for a Windows client.' This thread in the Tech Community is interesting, see a comment from a user - 'create a local account the "old" way'. And in this TechNet question, an external resource was provided by MSFT for Windows 10, and upon checking, it has the same steps. Can you please check if you have time, @illfated? Thanks.

Fair point, it is still possible to manage local users in Windows 10, but with slightly different settings and UI dialog boxes, compared to earlier versions. Browsing the pages you provided links to, I notice that it mostly references the use of Local Users and Groups (or the command lusrmgr.msc). I am fairly sure it is also possible to manage local users in Windows 10 Settings, based on personal experience with a Windows Server 2016 Active Directory domain and a handful of Windows 10 Pro computers converted from Windows 7 or Windows 8. When I need to log in as a local user, I do it in the form of replacing the domain name with the computer name, for example Guest-PC\Administrator, and from there I can choose whether to use Local Users and Groups (via Control Panel or Computer Management) or Windows 10 Settings\Accounts to manage local users.
The question now seems to be: How do we proceed to update or replace the page to accurately depict the process of accessing local users in Windows 10?

I did go through those docs afterwards and lusrmgr.msc stays the same, so the steps provided do provide accurate information in case of Windows Server 2019. It isn't possible to use lusrmgr in Windows 10 (Home) atleast, as shown here:

Instead you have to use the new settings; where clicking on Create a local user account under Family & other users leads to a Bing page which in turn is generated from Microsoft Support but due to lack of breadcrumbs, I can't find where other related articles to the same might be located.

@Amorpheuz : Please note that this repository (MicrosoftDocs/windows-itpro-docs) only concerns itself with Windows 10 Professional and its Enterprise licensed versions in relation to Windows Server or Azure, not Windows 10 Home. The scenario shown in your images is to be expected when you are not using Windows 10 Pro in an Enterprise or Domain scenario.

That being said, it is still necessary to propose a solution to missing documentation on how to manage local users and groups in Windows 10 related to Windows Server 2016/2019 Domains or even when using Azure AD. We need updated images from Windows 10 Professional for this, as well as possibly rewritten and validated documentation page(s) to replace the current page(s).

@illfated I don't have any information if there is a plan to write a doc set specifically for Windows 10 Pro or to update the existing doc set—it would seem to require extensive content revision and/or update. The possible challenge when it comes to time and effort—even if done incrementally—is that the updates will require thorough review & technical verification. If you see any contents that are easy to amend, please create a PR. By the way, here's the resource for the graphics guidelines, perhaps you already know, if not FYI.
Hi @DulceMontemayor is there any plan to update the How to manage local accounts doc? Please consider this as a suggestion from the community. Thank you.

Fair point. I will set it aside for the moment, maybe pick it up again next weekend and see if there is anything existing somewhere else to be used.
I must admit that I do not fancy planning a full set of new pages and their directory structure.

Hi @illfated are you planning to propose amendments or updates to this documentation, if not, I believe we can close this issue. Thanks.

Sorry, I must admit that I have not been able to find any useful and up to date material to cover this issue as a solution. Without any extra input or feedback from others, I will not be able to contribute with any useful material the size of a full page or pages in a working hierarchy.

@illfated that is fine. It'll be quite an undertaking. For now, let's just tag this as a suggestion.
Hi @DulceMontemayor, not sure if this is already in your backlog. If not, kindly take a look at this community suggestion if you have time. Thank you and we look forward to seeing (and reading!) the updates to the docs.
@Amorpheuz thank you again for bringing this to our attention. We will now close this issue, but please continue to send your feedback and suggestions to improve the quality of the Microsoft documentation. Thanks for being part of the Microsoft Docs community!

@officedocsbot close


Output disappears when hitting enter/return/newline

It seems that in general Hydrogen will keep output in place when you modify the line that you've just evaluated. For example,
foo(3)  #output here

if you edit this to say foo(2) after evaluating it, the "#output here" will stay in place. You can even insert many more characters and the output will flow along to the right. But if you hit enter to go to the next line, it disappears. I try to remember to hit enter before evaluating, but it's difficult.
This would help screencasting go better :)

Currently I insert a marker at the end of the line, and when the marker gets changed, I remove it. This makes evaluating partial lines work well, but I'm not wedded to it.
What would be a better behavior for you?

I think hitting an 'esc' key would be a better choice?
From time to time you get a really long line of return value and it's hard to close that result box.
It's quite annoying to enter newline and hit backspace to remove the newline just to remove the output.
Though 'esc' key might collide with other behaviors :\

@YoungxHelsinki I think you may be misunderstanding the intent of my bug. I'm saying that I don't want the output to disappear, but it does when I press enter. FWIW there's a keypress, cmd-alt-backspace, that removes all output from the current buffer.
@willwhitney I have no idea about the implementation details; I don't know anything about the internal model for atom buffers. I just think that if I hit enter after running a line, the output shouldn't disappear. Would it perhaps be feasible to put the secret marker at the beginning of the line instead of the end?

I can definitely make it stick around, I'm just looking for the best behavior (regardless of implementation) for you. Do you still want to be able to close a single inline result without closing all of them? Or is that totally unnecessary?
Making esc clear the results on the line might be a good option. I'll have to figure out if that breaks anything else.
@YoungxHelsinki you can also use the shortcut to remove all results (default ctrl-alt-backspace), but I understand you may want to clear only one of them.

@willwhitney I guess it would be nice to clear individual results too. There are "x" icons to close on multi-line output, what about having the same for result bubbles? I guess a keystroke for "clear output on current line" could also be useful.

Adding a keymap-able command to clear the output from the current line would be really useful. I usually don' t need the output from the pop-up for very long after first seeing it, so I almost always end up clicking the 'X' with the mouse after reviewing the contents.
Also more on-topic for the original post, I agree that adding a new line below the current line shouldn't clear the output on that line. It feels unexpected when it happens.

I've tried to address this issue here.
The idea is to move the cursor down automatically after showing the output.
If there are no lines after the executed code, then a new line is inserted.
If you like this behaviour, I will submit a PR.

@n-riesco that's a reasonable thing to do. You should probably only move the cursor down if it's on a line included in the code block being executed — Hydrogen also finds the first code block above the cursor, so this could result in unexpected behavior otherwise. Also should take into account the case of executing a selection that doesn't cover the whole line.
Maybe another improvement relevant to this is to use the presence of the output bubble as a clean/dirty indicator on the code that generated it. That is, have the output bubble associated with the region of the buffer that was sent to the kernel for execution, and when that region changes, remove the bubble.

On 02/09/15 16:27, Will Whitney wrote:

You should probably only move the cursor down if it's on a line included in the code block being executed

OK, I will fix that.

Also should take into account the case of executing a selection that doesn't cover the whole line.

How do you mean?

Here's an alternative idea (inspired by the jupyter notebook):

[shit-alt-enter] to run a code block (current behaviour)
[ctrl-alt-enter] to run a code block and move one line down

Like this:

If some text is selected when Hydrogen is run, it will execute exactly and only that text. So you don't want to move the cursor when they've selected seventy in the above example.

[shift-alt-enter] to run a code block (current behaviour)
[ctrl-alt-enter] to run a code block and move one line down

That's a great idea. I'd merge that PR.

OK, now I get it.
Let me sum up what the PR would do (please, correct me if I'm wrong):

bind [shift-alt-enter] to the current behaviour

for [ctrl-alt-enter], I can see 4 cases:
1.1 (no text selected, cursor not on the last row) => execute code and move down
1.2 (no text selected, cursor on the last row) => insert line, move down, and execute code
2.1 (text selected, cursor not on the last row) => execute code and move down
2.2 (text selected, cursor on the last row) => execute code, move down and insert line

We should include the possibility that the cursor is on the line below the code block:

Then the possibilities look like this:
(no text selected)
    (cursor within code block)
        (cursor not on last row) => execute and move down
        (cursor on last row) => execute code, move down and insert line
    (cursor below code block) => execute and do not move
(text selected)
    (cursor not on the last row) => execute code and move down
    (cursor on the last row) => execute code, move down and insert line

Does that make sense?

Yes, it does (again, I had forgotten about the case 'cursor below code block'!).
I'll give this PR a go.

Great!
On Wed, Sep 2, 2015 at 1:23 PM Nicolas Riesco<EMAIL_ADDRESS>wrote:

Yes, it does (again, I had forgotten about the case 'cursor below code
block'!).
I'll give this PR a go.
—
Reply to this email directly or view it on GitHub
https://github.com/willwhitney/hydrogen/issues/76#issuecomment-137178332
.


Checking operator tests for flakiness

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:

[ ] Unit Test
[ ] E2E Test

How to test changes / Special notes to the reviewer:

/test all

/test v4.14-kuttl-parallel

/test v4.14-kuttl-parallel

/approve
/lgtm

/test v4.13-kuttl-parallel

/retest

/test v4.14-kuttl-parallel

/test v4.14-kuttl-parallel

/approve
/lgtm

/lgtm
/approve


import error

we need to import the Silder component from @chakra-ui/slider instead of @chakra-ui/react, which can be confusing for new users 😄

Hey, can you give us more details on your setup? For example which React / Chakra UI version you are using and please if it's possible if you can create a CodeSandbox.
I've tried to recreate it and to me the Slider works if you import it from @chakra-ui/react:
https://codesandbox.io/s/floral-grass-3q2pi5?file=/src/index.tsx:106-111

Closing this since there was no further discussion for this issue.


chore(main): release 2.151.0

:robot: I have created a release beep boop
2.151.0 (2024-11-04)
Features

async the logic for cloning feature states into a cloned environment (#4005) (02f5f71)
ci: add command to rollback migrations (#4768) (483cc87)
export: Add support for edge identities data (#4654) (f72c764)
permissions: update endpoints to expose tag-supported perms (#4788) (43e68c1)

Bug Fixes

Extend user first name length to 150 characters (#4797) (364c565)
hide view features from associated segment overrides (#4786) (49ff569)
Set tag to get or create (#4790) (fedd296)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.151.0
:sunflower:


"Unsupported item key" errors

Hi @AceSlash !
Thanks for writing and sharing this zabbix ZoL template, unfortunately it isn't working properly for me yet.
Before I get onto my actual problem, could you please update the description on https://share.zabbix.com/zfs-on-linux from:
"The documentation has moved to github: https://github.com/AceSlash/zabbix_zfs-on-linux" to something like:
"Please use the newer version of this template available from https://github.com/AceSlash/zabbix_zfs-on-linux"
I am running zabbix 4.0 under Ubuntu 18.04. The ZoL host I'm trying to monitor is proxmox VE / Debian 9. I removed the older version of your template and user parameters and replaced them with the updated ones from this repo, but after restarting the zabbix agent on my PVE server I see these errors in the zabbix-agent log:
18508:20190605:093052.533 Starting Zabbix Agent [demeter.cs.salford.ac.uk]. Zabbix 4.0.8 (revision 2b50c941de).
 18508:20190605:093052.534 **** Enabled features ****
 18508:20190605:093052.534 IPv6 support:          YES
 18508:20190605:093052.534 TLS support:           YES
 18508:20190605:093052.534 **************************
 18508:20190605:093052.534 using configuration file: /etc/zabbix/zabbix_agentd.conf
 18508:20190605:093052.534 agent #0 started [main process]
 18509:20190605:093052.535 agent #1 started [collector]
 18510:20190605:093052.535 agent #2 started [listener #1]
 18511:20190605:093052.536 agent #3 started [listener #2]
 18512:20190605:093052.536 agent #4 started [listener #3]
 18513:20190605:093052.537 agent #5 started [active checks #1]
 18513:20190605:093052.546 active check "zfs.arcstats[arc_dnode_limit]" is not supported: Unsupported item key.
 18513:20190605:093052.546 active check "zfs.arcstats[arc_meta_limit]" is not supported: Unsupported item key.
 18513:20190605:093052.546 active check "zfs.arcstats[arc_meta_used]" is not supported: Unsupported item key.
 18513:20190605:093052.546 active check "zfs.arcstats[bonus_size]" is not supported: Unsupported item key.
 18513:20190605:093052.546 active check "zfs.arcstats[c_max]" is not supported: Unsupported item key.
 18513:20190605:093052.546 active check "zfs.arcstats[c_min]" is not supported: Unsupported item key.
 18513:20190605:093052.546 active check "zfs.arcstats[data_size]" is not supported: Unsupported item key.
 18513:20190605:093052.546 active check "zfs.arcstats[dbuf_size]" is not supported: Unsupported item key.
 18513:20190605:093052.547 active check "zfs.arcstats[dnode_size]" is not supported: Unsupported item key.
 18513:20190605:093052.547 active check "zfs.arcstats[hdr_size]" is not supported: Unsupported item key.
 18513:20190605:093052.547 active check "zfs.arcstats[hits]" is not supported: Unsupported item key.
 18513:20190605:093052.547 active check "zfs.arcstats[metadata_size]" is not supported: Unsupported item key.
 18513:20190605:093052.547 active check "zfs.arcstats[mfu_hits]" is not supported: Unsupported item key.
 18513:20190605:093052.547 active check "zfs.arcstats[mfu_size]" is not supported: Unsupported item key.
 18513:20190605:093052.547 active check "zfs.arcstats[misses]" is not supported: Unsupported item key.
 18513:20190605:093052.547 active check "zfs.arcstats[mru_hits]" is not supported: Unsupported item key.
 18513:20190605:093052.547 active check "zfs.arcstats[mru_size]" is not supported: Unsupported item key.
 18513:20190605:093052.547 active check "zfs.arcstats[size]" is not supported: Unsupported item key.
 18513:20190605:093052.547 active check "zfs.fileset.discovery" is not supported: Unsupported item key.
 18513:20190605:093052.547 active check "zfs.get.param[zfs_arc_dnode_limit_percent]" is not supported: Unsupported item key.
 18513:20190605:093052.547 active check "zfs.get.param[zfs_arc_meta_limit_percent]" is not supported: Unsupported item key.
 18513:20190605:093052.547 active check "zfs.pool.discovery" is not supported: Unsupported item key.

Thanks for your help!

Currently, the only bit of ZFS data I am getting under zabbix is the ZFS on Linux version.

I may be able to fix this by changing everything from active to passive checks but I'd like to know what the proper solution is.

I am using the ZoL_with_sudo.conf userparameters file, seeing as zpool and zfs are located under /sbin under PVE.

Oops!
I had copied the user parameters file into the sudoers.d dir by mistake. After copying it to the right place and restarting it looks like its working now.

hey @danboid ,
Just a quick note about the usage of sudo. On Ubuntu 18.04, you have ZoL version 0.7+, so you don't need sudo. The fact that the "zfs" and "zpool" binaries are in "/sbin" doesn't matter.
You should remove the sudo rights and directly use the ZoL_without_sudo.conf parameter file (don't forget to remove the other one).

Thanks for the tip but the ZoL host I'm monitoring is Debian 9.

Oh sorry I misread. If you can, I would install ZoL from the Debian backports to get ZoL 0.7.12, which is a lot better than the outdated 0.6.5 that is in the standard repository.

I'm pretty sure proxmox bundle their own kernel and ZFS packages, which are likely as up to date as backports. Best stick with theirs I think.

It may be a good idea to check the version shipped with proxmox then, they may well use the 0.7 branch ;)

It definitely is using 0.7, I'm not not sure of the micro version.


Html minifier

It clearly improves the output sized.
Regarding the last two options sortAttributes and sortClassNames: won't impact the plain-text size of the output. However, they form long repetitive chains of characters that should improve compression ratio of gzip used in HTTP compression.

Only issue I can imagine is someone using [type="javascript"] as a selector. But I've never seen anyone use that.


[fix][env]Fix potential incompatible java opts caused by IS_JAVA_8

Motivation
Same  with #14711,  fix  wrong IS_JAVA_8 check
Modifications
Use $JAVA instead of java
Documentation
Check the box below or label this PR directly.
Need to update docs?

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] no-need-doc
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-added
(Docs have been already added)

/pulsarbot run-failure-checks


upcoming events

it'd be neat if our website listed upcoming events -- a subset of the startup-edmonton calendar maybe?

I'm going to keep #69 open for this. Let's put any ideas there.


Avoid running tf command if it is not tf environment

On the new MicroBuild server there is no TFS environment. Remove the unnecessary commands in the build process.

Hi @zhengbli, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Zhengbo Li). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

:+1: