how config OHIF to clearcanvas server

dear all,
i wanted connect OHIF to clearcanvas server using wado?
how config file in OHIF ?
thank all.

I haven't tried to do this before, but I think this should possible.  I will try to set it up and share my results.

dear you? do you had document config in OHIF?
thank.

I tested with ClearCanvas image server and it's working fine.  A couple of things to be aware of: (1) ClearCanvas doesn't support DicomWeb, only WadoURI.  You'll have to use DIMSE for getting metadata.  Also, since I'm running my meteor instance locally, but sending WADO requests to another server (CC image server), I am running a proxy that listens on port 1001 and forwards the requests to my CC server (on port 1000 at host 'radserve').
Here's what I used:
{
"servers": {
"dicomWeb": [
{
"name": "ClearCanvas",
"wadoUriRootNOTE" : "either this uri is not correct for wado-uri or wado-uri is not configured on ClearCanvas currently",
"wadoUriRoot" : "http://localhost:1001/wado/PACSAE",
"qidoRoot": "http://radserve:1000",
"wadoRoot": "http://radserve:1000/wado/PACSAE",
"qidoSupportsIncludeField": false,
"imageRendering" : "wadouri",
"requestOptions" : {
"auth": "none:none",
"logRequests" : false,
"logResponses" : false,
"logTiming" : false
}
}],
"dimse": [{
"name": "ClearCanvas",
"peers": [
{
"host" : "radserve",
"port" : 105,
"aeTitle" : "PACSAE",
"default" : true,
"supportsInstanceRetrievalByStudyUid": false
},
{
"host" : "<IP_ADDRESS>",
"port" : 11112,
"aeTitle" : "OHIFDCM",
"default" : true,
"server" : true
}
]
}]
},
"defaultServiceType": "dimse"
}

Dear,
I want to connect OHIF to XNAT server with wado?
How to configure files in OHIF?
thank you all.

Dear,
I want to connect OHIF to XNAT server with wado?
How to configure files in OHIF?
thank you all.

Dear,
I want to connect OHIF to XNAT server with wado?
How to configure files in OHIF?
thank you all.

@radicalrob Could you give a sample proxy to forward to server support DIMSE (WadoURI only)
Thanks!

@Iam0620, I'm going to close this issue. In general, you're much more likely to receive a response if you create a new issue as old/closed issues are infrequently monitored. Simply reference the old issue in your new one.
Thanks for understanding! ^_^


Generate bundle ignore RelatedImages from config/manifests/bases

Bug Report

What did you do?

generate bundle using kustomize with RelatedImages in config/manifests/bases/my.clusterserviceversion.yaml
What did you expect to see?

The generated CSV should include the provided RelatedImages
What did you see instead? Under which circumstances?
The generated CSV does not include the provided RelatedImages
used to worked until v1.19.0

Environment
Operator type:

/language go

Kubernetes cluster type:
vanilla

$ operator-sdk version
v1.19.1
(worked with v1.19.0)

$ go version (if language is Go)

$ kubectl version

Possible Solution
Merge the provided RelatedImages with the auto detected.
Suspected PR that introduced the change: #5656

Additional context

Hi @rollandf, does this issues exist with a recent version of operator-sdk? v1.19.1 is well over a year and a half old, just trying to gauge if this issue still exists. Thanks.

Hi, yes it still exists in latest version.
Example of base yaml:
https://github.com/Mellanox/network-operator/blob/master/config/manifests/bases/nvidia-network-operator.clusterserviceversion.yaml#L78

Thanks for confirming...As a workaround, operator-sdk can build the related images section in the csv with the following:
USE_IMAGE_DIGESTS=true make bundle

This pins the images to the proper sha value and also builds the related images section.

/remove-lifecycle stale

/remove-lifecycle stale


Internal error trying to parse:  var 0= $__require("15");

Ok, I didn't expect this to work, but my first pass at getting my project built (hopefully the customizations I've made don't cause too many problems here) is going pretty badly:
var path = require('path');
var Builder = require('systemjs-builder');
var builder = new Builder('/', 'jspm.config.js');

builder
//.buildStatic('js/**/*', 'bazout.js', {   // same thing, but produces error with "28" instead of "15"
.buildStatic('js/*', 'bazout.js', {
  sourceMaps: true,         // just garbage because of the error
  lowResSourceMaps: false,  // what is this supposed to do?
  format: 'amd',
  minify: false,
  mangle: false
  })
.then(function () {
  console.log('Build complete.');
})
.catch(function (err) {
  console.log('Build error:');
  console.log(err);
});

PS D:\workspace\Content> node .\systemjs-builder-test.js
Build error:
[Error: Internal error trying to parse:

var 0= $__require("15");
    var global = this, __define = global.define;
    global.define = undefined;

null:1:5: Unexpected token 0]

Not sure what to make of that. Anyway, in the meantime I'm going to attempt to take a more piecewise approach. Ah, worth noting, grep -R "var 0=" * produces no results.
Update:
Sweet! Some stuff builds, eg
.buildStatic('js/modules/*', 'bazout.js', {

But I'm still perplexed by that error message.
Update:
I've traced down this to a file (the rest of it builds now) I created to work around global namespace pollution (this was your proposal to hopefully eliminate the need for this):
var SmogHighcharts = require('highcharts-lib');

delete window.Highcharts && delete window.HighchartsAdapter;

getOwnPropertyNames(SmogHighcharts).forEach(function (key) {
  module.exports[key] = SmogHighcharts[key];
});

trying to sfxify a minorly more verbose version of that file:
.buildStatic('js/highcharts-stub.js', 'bazout.js', {

PS D:\workspace\Content> node .\systemjs-builder-test.js
Build error:
[Error: Internal error trying to parse:

var 0= $__require("3");
    var global = this, __define = global.define;
    global.define = undefined;

null:1:5: Unexpected token 0]

I feel like the error message could be a little more helpful...
Update:
Well, obviously I'm trying to run this in node, so I changed the stub to exactly
var SmogHighcharts = require('highcharts-lib');

var global_ = window || global;
delete global_.Highcharts && delete global_.HighchartsAdapter;

getOwnPropertyNames(SmogHighcharts).forEach(function (key) {
  module.exports[key] = SmogHighcharts[key];
});

But I get exactly the same error. My node-fu isn't what it could be at the moment, so not sure if there's something different I should be doing. Anyway, still doesn't work.
Update:
The offending line appears to be
var SmogHighcharts = require('highcharts-lib');

I can leave the rest of the file intact if I stub out SmogHighcharts. Or exclude it from the build. But, I would prefer not to exclude it from the build.

I believe it's related to this line:
https://github.com/systemjs/builder/blob/master/compilers/cjs.js#L136
The builder using is using
0

As variable name. I don't know if its a bug or edge case.
How can i repro this?

Thanks, yes this is a bug in that globals handling. We need to validate the variable names.

Actually this isn't a bug.
@sberney it sounds like you've just set System.config({ meta: { 'some-module': { globals: ['x'] } }), where globals as an array value is not supported.

Thanks, I'll look into it. Preliminary recreation attempts failed, but I've
been busy myself. Error message still very much unintuitive.
Le 5 janv. 2016 10:36 AM, "Guy Bedford"<EMAIL_ADDRESS>a écrit :

Actually this isn't a bug.
@sberney https://github.com/sberney it sounds like you've just set System.config({
meta: { 'some-module': { globals: ['x'] } }), where globals as an array
value is not supported.
—
Reply to this email directly or view it on GitHub
https://github.com/systemjs/builder/issues/441#issuecomment-169091482.


Add functional download tests

I picked up work on #43 again and noticed that there's no test coverage for the skipped / uptodate logic, which need to be added first. The tests also revealed a problem with the current skipped logic.

Thanks a lot. Very thorough and very good code quality! I added some comments and merge the PR.


How to reproduce the results of BYOL

I want to reproduce the result of BYOL by myself. However, I'm not sure how to use multi machine to train the ImageNet Dataset in batch size 4096, can you give a simple example?

Refer to: https://pytorch.org/docs/stable/distributed.html#launch-utility


File based routing causes full-page refresh and not hot reload

Describe the bug
When i'm using the file-based routing with @tanstack/router-vite-plugin everytime i'm doing a simple change in the route component the whole page refreshes. That doesn't happen when using code-based routing. Is this expected?
Your Example Website or App
https://stackblitz.com/edit/github-g4hol2?file=src%2Fmain.tsx
Steps to Reproduce the Bug or Issue

Go to route.component
Just change the text or styling

Expected behavior
I expected to just hot reload the content that changed, without full page refresh. For example when changing a div's styling should immediate show the change in my screen.
Screenshots or Videos
No response
Platform

OS: macOS
Browser:  Chrome
Version: [e.g. 91.1]
@tanstack/react-router : 1.8.3
@tanstack/router-vite-plugin: 1.8.2

Additional context
No response

No still the issue persists

This is fixed in the latest version :) Cheers!


FR: addressbook-query restrict result properties

Following https://tools.ietf.org/html/rfc6352#section-10.4 it is possible to limit the properties of the vcards to be returned by a addressbook-query.
So basically we should be capable to process a request like this
<?xml version="1.0" encoding="UTF-8"?>
<C:addressbook-query xmlns:D="DAV:" xmlns:C="urn:ietf:params:xml:ns:carddav">
  <D:prop>
    <D:getetag/>
    <C:address-data>
      <C:prop name="VERSION"/>
      <C:prop name="UID"/>
      <C:prop name="NICKNAME"/>
      <C:prop name="EMAIL"/>
      <C:prop name="FN"/>
      <C:prop name="TEL"/>
    </C:address-data>
  </D:prop>
</C:addressbook-query>

@evert are you interested in accepting an PR on this?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/37992122-fr-addressbook-query-restrict-result-properties?utm_campaign=plugin&utm_content=tracker%2F294006&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F294006&utm_medium=issues&utm_source=github).

Yes, I think this would be awesome! I feel that it would be good to:

Consider the CalDAV variant, even if you don't implement it right away. At least think about how that would work as well, because as usual the CalDAV variant is more complex than the CardDAV variant and generally there's some benefits to doing the harder one first.
Always include certain properties whether they were requested or not. Specifically, VERSION, UID should always be in there and maybe also FN. This way if a client requests a minimal object, the vcard will always still be valid. I realize this is a deviation of the spec, but I think it's worth it.

Hey @DeepDiver1975 ,
Thanks for all the commits. Must have been a lot of work. Especially with the subtle changes between versions.  I don't think owncloud uses 3.0 any more, so 3.1 onwards would have been fine. I only care about adding features to older versions if anyone wants them, and even then I rather not. So basically pick ownclouds minimum sabre/dav version and go with that.
I find it easier to implement the feature at the oldest version, and then merge upwards. So I'd first develop it in 3.0, then merge it into 3.1, then 3.2, etc. This makes things a lot easier because things are typically more easily forwards compatible, and I this is how I literally always merge (always forward, never backward) so up to this day it should always be pretty easy to merge from any version to the next.

You might have done this too, I wasn't sure... but if you started with the newest and worked backwards it was probably a bit harder than it should have been.
cheers and thanks again!

I'm happy to help out with stuff like this. Given a decent unit test suite backports are not that hard :wink:


Improve runtest defaults, add changelog, update --version flag, add --force flag, refactor Rlibs

Changes

Adds a --force flag to allow for re-initialization of a workdir
Fixes error with testrun in DESEQ2
Decreases the number of samples being run with testrun, essentially running tinytest as default and removing tinytest as an option
Reads version from VERSION file instead of github repo link
Added a CHANGELOG
Refactor R library handling
Adds missing mm10 parameters
Removes some testing from annotation report gopeaks due to latency

Issues

[x] fixes #96
[x] fixes #97
[x] fixes #112
[x] fixes #113
[x] fixes #115
[x] fixes #116
[x] fixes #118
[x] fixes #121
[x] fixes #125

PR Checklist
(~Strikethrough~ any points that are not applicable.)

[x] This comment contains a description of changes with justifications, with any relevant issues linked.
[x] Update docs if there are any API changes.
[x] Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

Can you edit the title of this PR to be a short description of the changes?

My test run failed in the GO enrichment rule:
Quitting from lines 19-52 [setup] (_go_enrichment.Rmd)
Error in `install.packages()`:
! unable to install packages
Backtrace:
  1. BiocManager::install(new.packages, INSTALL_opts = "--no-lock")
  2. BiocManager:::.install(...)
  3. BiocManager:::.install_repos(...)
  4. BiocManager:::.inet_install.packages(...)
  6. base::tryCatch(...)
  7. base (local) tryCatchList(expr, classes, parentenv, handlers)
  8. base (local) tryCatchOne(expr, names, parentenv, handlers[[1L]])
  9. value[[3L]](cond)
 10. BiocManager:::.inet_error(e)
Execution halted

The good news is all other jobs passed!

Finished testing these changes - everything went to completion. ready for you to test again @kelly-sovacool !

test run submitted
bash /data/CCBR_Pipeliner/Pipelines/CARLISLE/carlisle-dev-sovacool/carlisle --runmode=init --workdir=/data/sovacoolkl/carlisle_test_iss-113_2
bash /data/CCBR_Pipeliner/Pipelines/CARLISLE/carlisle-dev-sovacool/carlisle --runmode=runtest --workdir=/data/sovacoolkl/carlisle_test_iss-113_2


add TargetCluster URL in InternalWorkspace's status

requires #308

/hold

/hold

With those changes you've suggested, lgtm

/unhold


I cannot clone github repository https://github.com/kosiwojciech/Hello-World.git

Hello,
While I try to clone github repository to work on my computer I receive fatal error with information below:
git clone https://github.com/kosiwojciech/Hello-World.git c:\Users\A311992\Desktop\EDX kurs\HelloWorld\Hello-World
Cloning into 'c:\Users\A311992\Desktop\EDX kurs\HelloWorld\Hello-World'...
fatal: unable to access 'https://github.com/kosiwojciech/Hello-World.git/': Could not resolve host: github.com
What I can do with that to work on my repository from GitHub with Visual Studio on my computer?
WK

This seems unrelated to VS Code. Please try asking on stackoverflow to start and post back here if you only see this while using VS Code


Add method execution

New Feature:
Being able to execute a method instead of navigate by this way can navigate to a external link or add Windows to the UI by code.

I have added the request feature usage as follwows:
 AbstractNavigationDrawer drawer = NavigationDrawerBuilder.get()
  ...
  .withClickableElement("Custom Action", VaadinIcons.EDIT, clickEvent -> Notification.show("Yay!"))
  ...
  .build();


nextjs redirects strip query parameters

It seems query parameters are being stripped off the URL when using nextjs redirects.
If you add something like this to the next.config.js
module.exports = {
  async redirects() {
    return [
      {
        source: '/one',
        destination: '/newplace',
        permanent: true,
      },
      {
        source: '/two/:path*',
        destination: '/newplacetwo/:path*',
        permanent: true,
      },
    ]
  },
};

Then test running nextjs in development mode it passes the query parameters along as per the documentation:
curl --head http://localhost:3000/one\?x\=1
HTTP/1.1 308 Permanent Redirect
Location: /newplace?x=1

Then deploy via tf-next and test:
curl --head https://d3il86aqaEXAMPLE.cloudfront.net/one\?x\=1
HTTP/2 308
content-length: 0
server: CloudFront
date: Thu, 07 Apr 2022 22:40:07 GMT
cache-control: public,max-age=31536000,immutable
location: /newplace

Same if we use the :path* redirect. Locally in nextjs:
curl --head http://localhost:3000/two/tree\?x\=2
HTTP/1.1 308 Permanent Redirect
Location: /newplacetwo/tree?x=2

and no query string when deployed via tf-next:
curl --head https://d3il86aqaEXAMPLE.cloudfront.net/two/tree\?x\=1
HTTP/2 308
content-length: 0
server: CloudFront
date: Thu, 07 Apr 2022 22:38:23 GMT
cache-control: public,max-age=31536000,immutable
location: /newplacetwo/tree

Hi, thanks for the detailed report!
Yes seems like the query string is not appended, will take a look soon.

Hi, I had a look at this issue and from what I've been able to gather so far:
By default nextjs redirects URLs with trailing slash to non-trailing slash counterpart
This means the first entry in the routes list generated by tf-next build will be
    {
      "src": "^(?:\\/((?:[^\\/]+?)(?:\\/(?:[^\\/]+?))*))\\/$",
      "headers": {
        "Location": "/$1"
      },
      "status": 308,
      "continue": true
    },

Which causes the Location header for the redirect to be set sans query params at https://github.com/milliHQ/terraform-aws-next-js/blob/a5a8fb55878c391f2c832656cc843526839d43e8/packages/proxy/src/proxy.ts#L191
        if (headers) {
          for (const originalKey in headers) {
            const originalValue = headers[originalKey];
            const value = resolveRouteParameters(originalValue, match, keys);
            combinedHeaders[originalKey] = value;
          }
        }

Currently, I've been adding the query param back to the location header as a workaround for this issue but not sure if this is the best way to go about it since it likely defeats some of the performance enhancement logic provided by this package?
        if (headers) {
          for (const originalKey in headers) {
            const originalValue = headers[originalKey];
            const value = resolveRouteParameters(originalValue, match, keys);
            combinedHeaders[originalKey] = value;
            // Pass query params through to Location header.
            if (originalKey == 'Location') {
              combinedHeaders[originalKey] = value + '?' + parsedUrl.searchParams.toString();
            }
          }
        }`

Took a look at how Vercel handles it and it seems like they always append the original search params to the Location header:
curl --head https://some.vercel.app/one\?x\=1
HTTP/2 308
location: /newplace?x=1
cache-control: public, max-age=0, must-revalidate
x-vercel-cache: MISS

What's interesting here ist that Vercel does not cache the response although 308 is a permanent redirect.
Even repeated requests result in a cache MISS.
We currently issue an cache-control: public,max-age=31536000,immutable on these redirects.
So I would vote to use the same solution for our implementation:

Original querystring is always appended to Location header
Cache control becomes public, max-age=0, must-revalidate for redirect responses

This has now been fixed in v0.12.2.


HasDomainOnChildNodes doesn't work on Umbraco v11

Describe the bug
Umbraco 11.4.2 - Url Tracker: 11.0.1
I have the same bug on v11 as this one that I also reported:
HasDomainOnChildNode does not work on multisite Umbraco v10
Same exact issue seems to be chasing the plugin on 11 :D.

Hi again! Thanks for letting me know! I think I simply forgot to merge my changes from the v10 fix into the v11 version. Version 11.1.0-beta.1 should release somewhere in the next hour if the build & release pipeline succeed. Could you check if that version works as expected? It should contain all fixes and changes that were made in v10.

As it turns out, the release did in fact not succeed. I'll be back with another update when this is fixed

Alright, now the release has succeeded, release 11.1.0-beta.1 should have the fix included

Yeah I just tested on Umbraco 11.4.2 and the beta seems to be working fine. I noticed on Nuget you have a 12 version, was wondering if you want to update that one too?

Thanks for the test, I'll release a full version soon as well.
As for Umbraco 12, it should already have all the fixes. I had apparently already merged the fixes from v10 into v11, I had just forgotten to release a new v11 version. v12 was based on the v11 develop branch, and should therefore already be up-to-date.

Awesome! Thanks a lot for the quick replies and fixes. Much appreciated. I can verify the beta you released works for me.

Fix has been released in version 11.1.0


Is there a CatchAll Intend?

In case the user calls an intend I haven´t implemented?
Greetings
Andre

I believe Alexa picks the last or the first skill when it understands the invocation name, but not the language, but I don't know for sure.

I rather search for a CatchAll possiblity in den alexa-app

@rokka If you find out how to do that, please let us know!

Probably worthy of some research to figure out what happens on the JSON side, when user specifies something but Alexa can't figure out what intent to deliver it to.  I'm currently using a bunch of YES/NO things, but since I'm using the built in Amazon intents, I also have to have at least one custom utterance to make it work, so I wire that to an intent that does nothing.. and I'm frequently seeing that intent called when user comes up with completely unexpected things, or makes an affirmative that Alexa doesn't recognize.
The official kit includes a 'Unhandled' item, which is mostly used when you are implementing different states, but when I was messing with that, I was getting a lot of calls to Unhandled, despite having not implemented any states yet.
While trying to figure out what Unhandled actually does, I also ran across that the official kit has a potentially useful call for when a new session begins (regardless of what intent is triggered or how), and when a session is ending.  I know it's easy to implement new session beginning in .pre() here, but i don't see an obvious way to do session ending . . maybe it's similar to .pre but in .post ?
anyway, getting off topic, sorry

@ericblade Open feature requests please and make PRs!

Short Answer: This is an issue that only Amazon can really fix since it's near impossible to tell if the intent selected actually matches what the user intended (no pun intended).
Long Answer:This is more of a problem with NLP, since the Alexa backend handles the translation of the phrase to a specified intent. Alexa has what I like to call a speech-to-intent service, in which Alexa takes a phrase and spits out the best intent it could match with. Normally, the way most speech-to-intent services choose the best intent is that they evaluates the sample utterances provided for each intent with the phrase the user said and assigns a confidence score from 0 to 1, with 0 being 0% confidence and 1 being 100% confidence. The intent with the highest confidence score is the one selected to be sent to the skill.
Most speech-to-intent services also have a "Default Fallback Intent" in which if the highest confidence level of all intents is less than a certain confidence level, like 50% for example, then it would send a "Default Fallback Intent" which would normally respond with "I am sorry, I didn't quite understand what you wanted to do." Unfortunately, Alexa doesn't have such a thing so even if the best intent has a 10% confidence, it's still sent to the skill, and since we don't know what confidence score the intent has, it's practically impossible to figure out if it's even accurate.
API.AI is similar to Alexa, in that it also has a speech-to-intent service, but it has a "Default Fallback Intent".

There is a setting to configure what is the minimum confidence score for the best intent to be selected.

In this case, any intent selected whose confidence score is lower than 30% will be rejected and the "Default Fallback Intent" will be sent instead.

On another note, if you meant that if there's an intent implemented while building the model but not implemented in the code, then that could work. At the moment, alexa-app will throw an error saying "NO_INTENT_FOUND", but PRs are welcome.

The new SDK implements an "Unhandled" event. Add this function to the intent handlers:
'SessionEndedRequest': function () {
console.log('session ended!');
this.emit(':saveState', true);
},
'Unhandled': function () {
console.log('Unhandled function');
speechOutput = DIDNT_GET_THAT_MSG;
this.response.speak(speechOutput).listen(HELP_REPROMPT_MSG);
this.emit(RESPONSE_READY_STATUS);
}

I could be wrong, but I believe the "Unhandled" event handler in alexa-sdk is for the use-case where a user triggers an intent that's declared in your interaction model, but isn't actually defined in your code.
(In this library, we just throw a "NO_INTENT_FOUND" error when that happens)


Improve Fuzz CI

My original plan was to run fuzz testing in CI separately with both x86_64 and i686 arch.
Unfortunately, I got issues with the i686 fuzzing https://github.com/RCasatta/rust-bitcoin/actions/runs/1265153484 and apparently specifying different targets is not supported https://github.com/rust-fuzz/honggfuzz-rs/blob/f45aef1b59736fcfc215eca09aca42e49bbf36db/src/bin/cargo-hfuzz.rs#L23
Nevertheless, I think there are some advantages in doing fuzzing in CI separately (faster, better report), however, there are some disadvantages (what launched from the CI is not exactly the same script launched locally). For this reason, I am not sure if 3e310d3c261335e2cda919a3c261b6591ca0e32e is desirable and if yes, if we want to remove fuzzing in the nightly test.
In case we keep the fuzzing in the nightly test I think 9049eef7004e1f52f19352ce0cc362d152fe3a11 is desirable because it saves about 30 seconds for other tests that don't need those deps.

Why do we have such a big diff with all temporary files (which should never get into git) removed?

Why do we have such a big diff with all temporary files (which should never get into git) removed?

which should never get into git

Those files are fuzzing test cases stimulating different program paths. Fuzzers could recreate those by running and searching for various inputs, but it could take a long time. Providing those to the CI ensures many program paths are tested even if the fuzzing runs for just 30 seconds, that's why they are committed into git.

Why removed?

fuzz targets deserialize_decimal and deserialize_udecimal are not there anymore (maybe renamed?) so that files are not used anymore.

Using rust stable toolchain since honggfuzz is supporting it -> https://github.com/rust-bitcoin/rust-bitcoin/issues/667#issuecomment-928096644


Team member integration invite user

Notion card
Summary

Preview

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to
not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Checklist:

[ ] I have manually tested all workflows
[ ] I have performed a self-review of my own code
[ ] I have added automated tests for my code

Closing this as another PR is raised with all the changes


Add some details on production deployment for new config

@jkk I added you as a collab on this repo FYI. I believe you should be able to merge and commit without my approval, if you so desire

thanks, i'm professionally conditioned to need an approver by now ;).


adding TruSwap Coin token

adding TruSwap Coin token

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

I can help refer this https://github.com/zakimzf/profile/pull/1
PS: If you don't need my help..then please ignore this!

how sir?
On Sat, Mar 26, 2022 at 2:15 PM Mohd Zakiuddin Faiz <
@.***> wrote:

I can help refer this zakimzf/profile#1
https://github.com/zakimzf/profile/pull/1
PS: If you don't need my help..then please ignore this!
—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/pull/23245#issuecomment-1079673883,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVINGOVIEMQOO7GFQ244JEDVB35U7ANCNFSM5RWGKCYQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

my TG @Saqib_VAN
On Sat, Mar 26, 2022 at 5:57 PM TRS TruSwap @.***> wrote:

how sir?
On Sat, Mar 26, 2022 at 2:15 PM Mohd Zakiuddin Faiz <
@.***> wrote:

I can help refer this zakimzf/profile#1
https://github.com/zakimzf/profile/pull/1
PS: If you don't need my help..then please ignore this!
—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/pull/23245#issuecomment-1079673883,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVINGOVIEMQOO7GFQ244JEDVB35U7ANCNFSM5RWGKCYQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

you didn't change any files.....


Profiling framework: core performance-logging implementation

Pull Request Description
Implement #181038002: Profiling framework: core performance-logging implementation.
Important Notes

~An unanticipated complexity: for a proc macro to create a wrapper, it needs to generate a call to the wrapped function, based on the input signature. Doing this for any possible signature would be complicated, and I don't see any other crate that solves the problem already. For the initial implementation, I have included support for basic fn and async fn function and method calls. What I have not implemented is support for all the possible destructuring-binds that can be performed in function signatures. Destructuring in signatures isn't common in the Enso codebase. If someone does apply #[profile] to a function with such a signature, it will fail at compile time with a note that that isn't supported; rewriting the function to work without destructuring in the signature is trivial.~ [Edit: the wrapper doesn't have to have the same bindings as the callee, just the same number and type of arguments; we can bind everything to arbitrary idents]
For performance, I have used unsafe in two different areas: for NonZeroU64 in Timestamp (sound as long as Timestamp doesn't wrap, and it won't for 53 million years), and to support shared mutable access to profiler::MEASUREMENTS. The latter is to avoid the overhead of a RefCell check for every logged measurement; soundness of the construct is ensured by a simple rule (documented in a source note).
~Due to reliance on JS performance.now(), the implemented tests are WASM tests. run's test support should identify them automatically; to test the crate by hand, you can use wasm-pack test --node~ [Edit: mock implementation]
I've used an environment variable to set profiling level, e.g. ENSO_MAX_PROFILING_LEVEL=task. This avoids needing to propagate cargo feature flags between crates.
~CLion doesn't seem to be able to display the expansion of the proc macro, but cargo-expand works if you'd like to see the generated code.~

Checklist
Please include the following checklist in your PR:

[x] The documentation has been updated if necessary.
[x] All code conforms to the Scala, Java, and Rust style guides.
[x] All documentation and configuration conforms to the markdown and YAML style guides.
[x] All code has been tested where possible.

[ci no changelog needed]

Added benchmarks.
Performance impact: Except at low numbers of measurements, run time is dominated by growing the vector. I'm measuring about 1.6ns per logged measurement, when accumulating 10k measurements. I think the cost of the unavoidable performance.now() will be on the order of 1μs, in which case our overhead is within 0.1% of an optimal implementation.
Performance variability impact: There's no easy way to measure this, so I'm speaking theoretically here. The only operation expected to have a significantly variable cost is the Vec::push to grow the MEASUREMENTS log; it sometimes needs to reallocate. However even at its most expensive, it should be on the order of a 1μs (for reasonable numbers of measurements); so the variance introduced by this framework shouldn't disturb even very small measurements (I expect <1% added variability for a 1ms measurement).

I need to change the structure of the wrapped code generated by #[profile] so that it is compatible with any context (e.g. the current implementation won't work in a trait impl). Will do that tomorrow, the fix is straightforward.

Added benchmarks.
Performance impact: Except at low numbers of measurements, run time is dominated by growing the vector. I'm measuring about 1.6ns per logged measurement, when accumulating 10k measurements. I think the cost of the unavoidable performance.now() will be on the order of 1μs, in which case our overhead is within 0.1% of an optimal implementation.
Performance variability impact: There's no easy way to measure this, so I'm speaking theoretically here. The only operation expected to have a significantly variable cost is the Vec::push to grow the MEASUREMENTS log; it sometimes needs to reallocate. However even at its most expensive, it should be on the order of a 1μs (for reasonable numbers of measurements); so the variance introduced by this framework shouldn't disturb even very small measurements (I expect <1% added variability for a 1ms measurement).

Perfect! Two additional questions:

Could you write these notes next to the benchmark suite as a comment? It would be amazing to read your findings when reading the code.
I've got an idea but I'm not sure yet what to think about it – what about creating a test that runs both Vec::push and our framework and if our framework runs longer than x * time_of_vc_push it fails? This way we will catch the situation when someone creates some changes to the code which break the perf. I believe that it would be possible to find an x which is big enough to not be affected by the time variance and small enough to catch bad modifications of this codebase in the future. What do you think about it? Do you think it's doable / worth it?

JetBrains IDE status
I've just tested these macros with different versions of JetBrains IDEs. (I was surprised to find that IntelliJ`s current macro bugs are completely non-overlapping with CLion's.)

#[profile] fn
define_hierarchy!

IntelliJ 2021.3.1
:heavy_check_mark:
:x:

IntelliJ EAP 221.3427.89
:heavy_check_mark:
:x:

CLion 2021.3.2
:x:
:heavy_check_mark:

CLion EAP 221.3427.90
:heavy_check_mark:
:heavy_check_mark:

:x: = IDE doesn't know about items generated by the macro
:heavy_check_mark: = working
Here's what we can do
To avoid missing docs in anyone's IDE:

CLion users will need to use EAP (prelease) builds of CLion until the next release. I don't know if this affects anyone but me; I've brought it up on Discord.
for IntelliJ users: expand define_hierarchy! (e.g. with cargo-expand), and check the results into source. This macro expansion step must be repeated any time we make changes to the define_hierarchy! implementation, but I don't anticipate needing to do that often. Once IntelliJ can handle the macro, we can remove the generated code from git and run the macro directly.

@wdanilo how does this sound for IDE support?

I've just tested these macros with different versions of JetBrains IDEs. (I was surprised to find that IntelliJ`s current macro bugs are completely non-overlapping with CLion's.)

The IDE should not affect this. Could you see if they are running the same version of the Rust plugin and the configuration (including experimental features) is the same?
If so, and you see any difference, this is something I'd consider of being worth of reporting to the Rust plugin developers.
Well, actually any failures with latest plugin version with experimental macro expansion enabled should be reported IMHO, they are currently patching this feature quite actively.

I found the root of the problem: using proc_macro::Span methods to obtain file/line info (which requires the proc_macro_span crate feature) causes the IDE's macro expansion to fail with not implemented. We use those methods to build the measurement's label, which doesn't affect the information the IDE needs from macro-expansion (signatures and docs). So, I'll add a feature to the crate that enables/disables attaching file/line info to measurements; by default it is disabled (so the IDE can build the crate), but the run build commands will enable the feature.
(The variation in results I thought was caused by editor version seems to have been caused by something else.)

We could use Criterion as our microbenchmark runner--it supports regression testing, and adds smart statistical analysis and other features to cargo bench

Sure, but also we should merge it as soon as possible. Using Criterion with all these features sounds like a big task (but I might be wrong). Anyway, when can we merge this approx? :)

@mwu-tow Could you force-merge this? It says merge is blocked by "Code owner review" but I have an approval by a code owner; I think it is only blocked by CI. The CI failures are: some signature issue on Windows, definitely unrelated; and, no CHANGELOG entry, but this is internal tooling, so I don't think it needs one.

@kazcw FYI, you can add [ci no changelog needed] anywhere in your PR description or in the last commit message and it will skip CHANGELOG.md check.

@mwu-tow New build failures here (after I did a merge commit so CI would see the [ci no changelog needed] annotation)

@kazcw The failures were due to Enso Standard Library example test accessing an external URL that was apparently not responsive at the time. Let's follow up with Engine Team on Discord.


Confirm SQL Server 2008/2008R2 ESU timelines

Hi Team! I've seen in the referenced doc that as part of subtitle "SQL Server on Azure VMs" for Benefits for Extended Security Updates it points out that you can have ESU free for three years past the end of support date. For that particular case we know it would be until July 2022.
However, there is also another documentation https://docs.microsoft.com/en-us/lifecycle/products/microsoft-sql-server-2008-r2
which points out a fourth year for ESU.
I believe that we need to update this information as from this referenced page, it seems to have only 3 years of ESU for SQL Server 2008/2008R2 and generates some confusions with the other url.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 89223ae2-d21a-20df-90f1-75d6a7ef2600
Version Independent ID: 89223ae2-d21a-20df-90f1-75d6a7ef2600
Content: End of support options - SQL Server
Content Source: docs/sql-server/end-of-support/sql-server-end-of-support-overview.md
Product: sql
Technology: install
GitHub Login: @rwestMSFT
Microsoft Alias: randolphwest

@pablojavierf -- thank you for your close reading.
@rwestMSFT -- please look into this issue.

Hi Pablo. Thanks for noting this. The page is already staged, and will be published sometime in June.
#please-close


fix: scheduled jobs not running when mqtt disabled

Fixes #3404

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 6 (0.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.007%) to 21.569%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/Gateway.ts
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

lib/Gateway.ts
1
17.84%

Totals

Change from base Build<PHONE_NUMBER>:
-0.007%

Covered Lines:
3728

Relevant Lines:
18400

💛  - Coveralls


SHOW TAG with a WHERE does not work for tags with _ as prefix

root@influxdb-p01:/srv# influx -version
InfluxDB shell version: 1.1.0

> select time, "_group", "_room", "heartbeat.latest" from vmware_sys

vmware_sys

time	_group	_room	heartbeat.latest
2016-11-18T16:03:17Z	"mfcf-test"	"m33101"	30
2016-11-18T16:04:37Z	"mfcf-service"	"lost(mc3015)"	30
2016-11-18T16:05:13Z	"mfcf-research"	"m33101"	30
2016-11-18T16:06:51Z	"mfcf-service"	"mc3015"	30
2016-11-18T16:07:52Z	"mfcf-service"	"mc3015"	30
2016-11-18T16:08:57Z	"mfcf-staff"	"mc3015"	0
2016-11-18T16:09:52Z	"mfcf-service"	"m33110"	30

> SHOW TAG VALUES FROM "vmware_sys" WITH KEY = "_room" WHERE "_group" = "mfcf-test"

vmware_sys

key	value
_room	"lost(mc3015)"
_room	"m33101"
_room	"m33110"
_room	"mc3015"

### expected to only have "m33101"

> SHOW TAG VALUES FROM "vmware_sys" WITH KEY = "_room" WHERE "vmware_sys"."_group" = "mfcf-test"

Success! (no results to display)
### expected result of "m33101"

I think you have the wrong quotes in your where clause.

Maybe the extra "vmware_sys" in the where clause is causing problems:
Does this work:
SHOW TAG VALUES FROM "vmware_sys" WITH KEY = "_room" WHERE "_group" = "mfcf-test"
SHOW TAG VALUES FROM "vmware_sys" WITH KEY = "_room" WHERE "_group" = 'mfcf-test'

that was already tested as the first attempt.
> SHOW TAG VALUES FROM "vmware_sys" WITH KEY = "_room" WHERE "_group" = "mfcf-test"

retried changing " to '
SHOW TAG VALUES FROM "vmware_sys" WITH KEY = "_room" WHERE "_group" = 'mfcf-test'
It lists everything... it's not filtering using the WHERE

seems that this is being tested...:
https://github.com/influxdata/influxdb/blob/af72d9b0e4ebe95be30e89b160f43eabaf0529ed/influxql/parser_test.go#L1420

could it be an issue with the under scores?

humm perhaps its because '_group' is a KEY not a metric value.

@steverweber I think it's because the tag keys have _ a prefix.  We rewrite some meta queries an use _ as a special internal character.  I believe it's failing here: https://github.com/influxdata/influxdb/blob/master/tsdb/shard.go#L1270
@jsternberg

I'll remove the _ and retest.

this might be the issue... I'll preform another test to be %100

confirmed. `HasPrefix(tag.Val, "_")
I did feel that me using an _  was asking for trouble but it did't jump out at me when reading the documents.... Perhaps some extra documents would be helpful to close this issue.

also i should note that I need to be careful where i use " and '.
this worked.
SHOW TAG VALUES FROM "vmware_sys" WITH KEY = "x_fqdn" WHERE "x_group" = 'mfcf-test'

Some more info on this issue from my experience:
SELECT * FROM "event" WHERE "_name" = 'value' : no results
SELECT * FROM "event" WHERE "_name" =~ /value/ : no results
SELECT * FROM "event" WHERE "_name" =~ /*/ : correct results
SELECT * FROM "event" WHERE "_key1" = 'value1' : correct results
SHOW TAG VALUES WITH KEY = "_name"
name: event
key	value
---	-----
_name	value
_name	testing

Of course all the above queries should return some results. So it looks like at least there is some clash when the tag name is _name

@cv711 Yes.  The workaround currently is to not use _ as prefix for tag names.

related:
https://github.com/influxdata/influxdb/issues/6011


Changes to front end in Fava 1.25 break fava-envelope

Fava-envelope 0.5.6 installed with Fava 1.24.4 working correctly.
Upgrade fava to 1.25, and Envelope Budget main screen fails to load.
Likely due to changes in front-end.
Error from Fava is generic.
Error from systemctl:
Jul 19 09:17:17 fava fava[4809]:     return _cached_url_for(endpoint, **values)
Jul 19 09:17:17 fava fava[4809]:   File "/usr/local/lib/python3.10/dist-packages/flask/helpers.py", line 256, in url_for
Jul 19 09:17:17 fava fava[4809]:     return current_app.url_for(
Jul 19 09:17:17 fava fava[4809]:   File "/usr/local/lib/python3.10/dist-packages/flask/app.py", line 2031, in url_for
Jul 19 09:17:17 fava fava[4809]:     return self.handle_url_build_error(error, endpoint, values)
Jul 19 09:17:17 fava fava[4809]:   File "/usr/local/lib/python3.10/dist-packages/flask/app.py", line 2020, in url_for
Jul 19 09:17:17 fava fava[4809]:     rv = url_adapter.build(  # type: ignore[union-attr]
Jul 19 09:17:17 fava fava[4809]:   File "/usr/local/lib/python3.10/dist-packages/werkzeug/routing/map.py", line 917, in build
Jul 19 09:17:17 fava fava[4809]:     raise BuildError(endpoint, values, method, self)
Jul 19 09:17:17 fava fava[4809]: werkzeug.routing.exceptions.BuildError: Could not build url for endpoint 'extension_report' with values ['bfile', 'currency', 'month', 'report_name']. Did you forget to specify values ['extension_name']?

Same issue here. Any update on this?

Still an issue as far as I'm aware.

should be fixed in 0.5.7

Verified working on:

Beancount 2.3.5
Fava 1.26
Fava-envelope 0.5.8


use full consistent reads

This switches us to fully consistent reads of relationships which ensures after any action has been taken a subsequent read request will return the most up to date information.
This resolves an issue seen when directly after creating a role, a client may fail to assign a subject to the newly created role.

When we develop and implement an eventually consistent model both of these options would only make sense then. Until then, we will need to be strictly fully consistent.


Incremental export

Done
Added a settings item: "Incremental export"

When enabled, during an export, the files modified time is checked against the last time it was exported. If the file's modified time is before or equal to the last export time the file is skipped and a message is displayed.

Fixes: https://github.com/KosmosisDire/obsidian-webpage-export/issues/152
QA

Enable the feature
Export your vault / a file - the first time will always export as there is no record of a file already being exported
See that the vault / file is exported correctly - make a note of the files creation time
Export your vaul / the file again
See the Notice popup that files were skipped
Check the files and compare to the previous file creation/ modified time, it shouldn't have changed
Modify a file and repeat, check the modified time of the exported file is different
Turn the setting off and repeat
A new version of the file(s) should be there
Rejoice in all the energy you've saved and how you've helped the planet.

This is amazing! Thank you for taking the time to do this. I am pretty busy right now, but I will certainly look this over and merge it when I have time. Thanks again!


Update project to Swift 5

The project is very well structured, any code change was necessary. This update prevent new projects using swift 5 to get warnings.

@ezefranca LGTM. Let me merge your PR. Thank you for your contribution.


Cannot set Preference color-palette-overrides

When setting 'color-palette-overrides' I get the following error in the javascript debug window (firefox)
[15:34:58.042] "Preference color-palette-overrides is not an array or object: {'0':'#073642','1':'#dc322f','2':'#859900','3':'#b58900','4':'#268bd2','5':'#d33682','6':'#2aa198','7':'#eee8d5','8':'#002b36','9':'#cb4b16','10':'#586e75','11':'#657b83','12':'#839496','13':'#6c71c4','14':'#93a1a1','15':'#fdf6e3'}"

In my .gotty file I intered
color_palette_overrides = "{'0':'#073642','1':'#dc322f','2':'#859900','3':'#b58900','4':'#268bd2','5':'#d33682','6':'#2aa198','7':'#eee8d5','8':'#002b36','9':'#cb4b16','10':'#586e75','11':'#657b83','12':'#839496','13':'#6c71c4','14':'#93a1a1','15':'#fdf6e3'}"

Within the Preference object.

Thank you for the report.
Confirmed that a bug. I'll fix it by the next release.

@TheOneValen meanwhile, you can writ like below:
  color_palette_overrides = ["#073642","#dc322f","#859900","#b58900","#268bd2","#d33682","#2aa198","#eee8d5","#002b36","#cb4b16","#586e75","#657b83","#839496","#6c71c4","#93a1a1","#fdf6e3"]

that works, thank you!

Thank you for this. I was trying to figure out how I would specify the colors for the "default 16" to make them mirror the original IBM PC VGA stuff, and this will do the trick nicely.

I now have a nicely solarized (dark) gotty. Do you intent to start a wiki or some other form of documentation. I could put the configuration there for other people to use.

I'm glad to hear you got a good color scheme :+1:
I'm afraid I'm not going to open the wiki pages on this repo for now because unfortunately I don't have much time to manage them (I might change my mind in the feature).

Now hterm preferences are handled in a better way.


[Feature request] Autoselect second clip in history

Please add autoselect the second value in the clipboard history.
When I call up a history, I often want to insert the previous value; To do this, just press the history hotkey and enter. ClipX has this function - it's convenient.
https://i.imgur.com/k7hDhCS.png

Please add autoselect the second value in the clipboard history.
When I call up a history, I often want to insert the previous value; To do this, just press the history hotkey and enter. ClipX has this function - it's convenient.
Interesting. Alt+V the menu and always display 2. Or change Alt+C so that 1 is always 2. But even now you can insert it like this, but I press Alt+C+2. You can try in the menu settings to auto-select 2 items from the top. The problem is that the menu can be changed in any way you want. Perhaps for my version https://github.com/AndreyKaiu/CLCL-EN-RU-JP-Plugins I will do it as you want, as soon as I have time.

Thanks.
I don't want to change the history range or any special hotkey.
I want the history popup to appear with the second clip selected as I showed.

I don't want to change the history range or any special hotkey.
I want the history popup to appear with the second clip selected as I showed.

I can only show this implementation in my version
https://github.com/AndreyKaiu/CLCL-EN-RU-JP-Plugins

Thanks. But I think that you only need to take into account the history of the clipboard (including the current value): if there are fewer than N entries, then select the last one; if the history is empty, do not select anything.
N=2, "no history" in the clipboard and restarted CLCL:

Thanks. But I think that you only need to take into account the history of the clipboard (including the current value): if there are fewer than N entries, then select the last one; if the history is empty, do not select anything.

It is only highlighted, and the choice is up to the user. In normal use there will always be 2 buffers, at least the one that remains in history from the last time. So I won’t complicate this, since the story can be placed not at the top, but somewhere in the middle. Everything should be simple, then there will be fewer problems.


feat: randomization support [WIP REFERENCE - DO NOT MERGE]

Adds randomization support via --random CLI flag or random option in browser
Random seed is created if not supplied for deterministic test runs

QUESTIONS:
Automatic Seed Creation
How should we handle automatic seed creation?
Issues:

Some reporters (XUnit in particular) are extremely fussy about output.
If we were to simply echo the automatically created seed to the console, problems would happen

Suggestions:

In the browser, this can simply be displayed.
Output a .mocha-seed.txt file or something.  This file would not be read from; only written to.
Disable automatic seed creation; require a seed for operation.  Trivially generate a seed via Mocha.seed() in the browser, or --generate-seed on the CLI.

Update, Nov 20 2016:
"Specification"

"Automatic" seed generation is not (yet?) available, due to concerns about output and reporter support / conflicts.
A seed is required for randomization.
On the command line:

Mocha can generate a seed via mocha --generate-seed.  A random seed will be printed to the console.
--random <seed> will enable randomization.

In the browser:

Mocha can generate a seed via mocha.seed().
Enable randomization thru mocha.options({random: mocha.seed()}) before calling mocha.run().

For Mocha's purposes, a seed is a positive integer which is less than or equal to the value of Number.MAX_SAFE_INTEGER, which is typically<PHONE_NUMBER>740991.
Acceptable formats for seeds are numbers (decimal, octal, hexadecimal) or strings that will convert via parseInt().
Mocha will use a hexadecimal representation for display purposes.
When randomizing tests, they are only randomized within the context of a suite.  In other words, suites will still run in order, but the tests within them will not.

TODO

[x] Add --generate-seed
[x] Add --random <seed>
[x] Seed validation
[x] Unit tests
[ ] Display active seed in HTML reporter
[ ] Docs
[ ] Support MOCHA_SEED environment variable.  This would ease usage in CI envs.
[ ] Node integration tests
[ ] Browser integration tests

cc @mochajs/mocha

cc @TimothyGu

Thanks for putting time into this one peeps!

@ScottFreeCode @TimothyGu Thanks for looking this over.  I'll implement the suggested changes

I don't think my questions in the description were answered though.
If I'm deciding, I'll go with --generate-seed so I don't have to deal with the file system.

I'm not familiar with the current situation of browser testing. How do reporters interact with browsers? Can I use, say, the XUnit reporter with the browser? If yes, will the XUnit output be made to the browser console?

so this is how it works on the CLI:
# generate the seed first
$ mocha --generate-seed
0x10FFFA5D98AE6F

# run tests with the seed
$ mocha --random 0x10FFFA5D98AE6F test/acceptance/random.js --reporter spec

  random option
    seed
      ✓ should be a valid seed
      ✓ should return a finite number
      ✓ should return a hex string
    when Mocha is instantiated with "random" option
      and that option is "false"
        ✓ should not populate the "randomConfig" option
      and that option is undefined
        ✓ should not populate the "randomConfig" option
      and that option is not an integer or convertable string
        ✓ should throw
      and that option is a valid seed
        randomConfig
          ✓ should define a function to shuffle tests in the "shuffleTests" prop
          ✓ should define a "seed" prop
          ✓ should be defined
          ✓ should define a hexadecimal representation in the "hex" prop

  10 passing (24ms)

For comparison, without randomization:
$ mocha test/acceptance/random.js  --reporter spec

  random option
    seed
      ✓ should return a hex string
      ✓ should be a valid seed
      ✓ should return a finite number
    when Mocha is instantiated with "random" option
      and that option is "false"
        ✓ should not populate the "randomConfig" option
      and that option is undefined
        ✓ should not populate the "randomConfig" option
      and that option is not an integer or convertable string
        ✓ should throw
      and that option is a valid seed
        randomConfig
          ✓ should be defined
          ✓ should define a "seed" prop
          ✓ should define a hexadecimal representation in the "hex" prop
          ✓ should define a function to shuffle tests in the "shuffleTests" prop

  10 passing (24ms)

@TimothyGu Generally, if you're in a browser, your only available reporter is the HTML reporter.
If you're in a headless reporter, then the HTML reporter is going to just dump HTML into your terminal, and you'll want one of the console-based reporters, like spec.  I would also assume something with the complexity of nyan would not work in this context.  Furthermore, I doubt a reporter like json-stream would work in a PhantomJS context, but who knows.
I don't use Mocha in a browser context without Karma to hold my hand, so I'm not the best source of information on this topic.  @mantoni is much more qualified to elaborate on which reporters are supported, if he cares to.

What's left to do:

[ ] Display active seed in HTML reporter
[ ] Write integration tests to assert deterministic, random order of tests within a suite context
[ ] Docs
[ ] Support MOCHA_SEED environment variable or something.  This would ease usage in CI envs.

note to self:
Karma setup would look something like:
var seed = require('mocha').seed();
console.log('Mocha seed: ' + seed);
config.set({
  frameworks: ['mocha'],
  client: {
    random: seed
  }
});

SauceLabs is taking a big ol' dump trying to run our tests in IE8.  Considering the test-windows/appveyor branch hasn't been merged, it's not specific to my changes or @TimothyGu's changes there.  Curiously, the pr tests pass, but the push tests fail.  Must have something to do with trying to run in a branch.  At least that's something to go on for SauceLabs--they're waiting for my reply to a ticket about this.

@TimothyGu @boneskull Pretty much all the reporters work in PhantomJS, too. The trick is to redirect console output and to provide a shim for process.stdout. I do this with brout and then set Mocha.process.stdout = process.stdout (see mocaccino browser setup). With this setup, even the nyan reporter output is redirected properly to the terminal.

woohoo finally

So basically needs more tests. But I don't necessarily need to be the person to write them.

Is there an updated description of what needs to happen to push this over the line? We would like to randomize our mocha builds to bring the flaky tests to the surface.

not so much.  new features are frozen until we get traction on immediate coverage needs.  though I haven't had any time to pay attention to where we're at there

@boneskull this sounds good. Worth pursuing now coverage in better place? Or do you think given where codebase is now there's a better alternative approach here?

@fearphage thanks for the reviews, but this PR is just here as a reference. It's got a whole bunch of merge conflicts. I edited the title & OP to make that more clear.
If you're interested in the work (great! 🙌) the right next step would be to send a separate PR.


Residence slimefun error

Description (Required)
Error log, ancient altar cant be used
Steps to reproduce the Issue (Required)
no idea
Expected behavior (Required)
altar should work
Server Log / Error Report
(https://pastebin.com/5HEa19Ab)
Server specs (Required)

Server Software: This server is running Paper version git-Paper-155 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 99cf01f)
Minecraft Version: 1.18.1

FULL plugins list (Required)
AdvancedPortals, ajParkour, ArmorStandTools, AuctionHouse, AuthMe, bAnnouncer*, BlockParticles, ClickSort, CMILib, CoreProtect, dynmap, Dynmap-WorldGuard*, DynMap_Residence, EpicReplant, Essentials, EssentialsChat, EssentialsDiscord, EssentialsGeoIP, EssentialsProtect, EssentialsSpawn, ExoticGarden, ExtraGear, FakaHedaMinequery, FluffyMachines, GMusic, GSit, HolographicDisplays, InventoryRollbackPlus, Jobs, JumpPads, LuckPerms, Multiverse-Core, Multiverse-Inventories, Multiverse-NetherPortals, MyCommand, MythicMobs, PlaceholderAPI, PlayTime*, PrivateStorage, ProtocolLib, Residence, SignShop, SkinsRestorer, sleep-most, Slimefun, SoulJars, TAB, TNTRun_reloaded, UberEnchant, Vault, Votifier, VotingPlugin, WorldBorder, WorldEdit, WorldGuard, WorldGuardExtraFlags, WorldSpawn*

This is the "dough" issue tracker, I think you are looking for the Residence issues tracker:
https://github.com/Zrips/Residence/issues

Why dought had to change registerModule(Server, ...) to registerModule(PluginManager, ...) where it basically is doing the same, you are still retriving the plugin via Server interface. Can't you add backward support for Server too ?
Zrips had not respond to any issue ever.


Android license error

Haven't found any "SDK Tools (Obsolete)" in sdk tools section in android studio 3.6.3

Hi @49paunilay
Please check 'Hide Obsolete Packages` and you will see it
This platform is not meant for assistance on personal code.
Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Improved 'purge_page_from_cache' to purge the url for any managed language

Rebase of https://github.com/wagtail/wagtail/pull/3024 with some cleanups

I noticed that in testing that, by default, this purges URLs for 86 different languages. I think we should make this feature disabled by default and you opt in to it by setting the specific languages you want to purge in the WAGTAILFRONTENDCACHE setting

@kaedroho I'll be happy to go on on this, but I cannot work on it before than two months at least

@kaedroho do you prefer a common settings for each defined backend or a specific setting for each backend?

@pyMan I prefer a common setting for all backends. So perhaps a separate setting is the best way to go.

@kaedroho I should be done

Merged in b3fa09b95ed7474a3307a6afa317e0d504e2fc86 - thanks @pyMan and @kaedroho!


IGate GPS not working

Using a TBeam v1.0.  Enabled GPS in the config file. IGate doesn't obtain a GPS position.

Try flashing this code in case a previous project has taken the GPS out of NEMA. Monitor the serial console, and you'll see what is going on.

That did the trick.  The TBeam's are very "sensitive" to firmware changes.  I had to totally erase the flash, then reset the GPS.  Finally the IGate would use/display the GPS info on APRS.FI


⚠ Bofrost.de has degraded performance

In 617dfbc, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1020 ms

Resolved: Bofrost.de performance has improved in 4538adc after 10 minutes.


RESTler via Docker

I would like to try out RESTler, but I have Ubuntu 19.04, which does not seem to support .NET 5.0. Furthermore, if RESTler turns out to be useful for our project, it would be great if RESTler can be executed elsewhere (e.g. Gitlab CI) easily, too.
So what is the easiest way to run RESTler on a (old) Linux machine?
Is there a Docker image available? If not, what is the best approach to create one? Use mcr.microsoft.com/dotnet/aspnet:5.0-buster-slim as basis and install Python and RESTler on top of it?

@DavidFarago
We do build a docker image for RESTler. You can see the dockerfile used to build the image https://github.com/microsoft/restler-fuzzer/blob/main/docker/Dockerfile
The image is available on docker hub https://hub.docker.com/_/microsoft-restlerfuzzer-restler.
The image is the code tagged v7.3.0.

@DavidFarago
You might also want to take a look at the https://github.com/microsoft/rest-api-fuzz-testing (RAFT) project. With RAFT you can run RESTler using either an Azure deployment or locally on your machine using the raft_local.py script.  There is also a github action https://github.com/marketplace/actions/rest-api-fuzz-testing-raft-action you can use to integrate RESTler into your github pipelines.

The image is available on docker hub https://hub.docker.com/_/microsoft-restlerfuzzer-restler.

This image appears to be private — is there a public release pending?

@acdha  -
public image is accessible here:
mcr.microsoft.com/restapifuzztesting/restler-agent:v3.latest
@mgreisen  - could you add tags to the RESTLer docker readme file ?

@acdha -
public image is accessible here:
mcr.microsoft.com/restlerfuzzer/restler:v7.3.0

Thanks!

@acdha,
I've also just updated the readme with an example on how to pull the image.

Thank you very much. I do not understand how to call Windows exes in the docker image, so I was not able to follow the tutorial directly.
All Python code is calling .NET DLLs and is not an alternative implementation of your F# code, right? RESTler/engine/restler.py does not offer any options for compiling, does it? The grammar you can pass is the compilation of your openapi specification?
I am now mounting both my openapi spec and your restler-fuzzer repo into the docker container and am calling python3 restler-quick-start.py --api_spec_path ../scheduling-server/openapi.yaml --restler_drop_dir /RESTler. restler_working_dir/Test/RestlerResults/experiment167/restler_grammar_grammar_167.py shows me that my openapi.yaml was successfully compiled, the smoke test is working, too.
Thank you very much, this helped me to get RESTler started -- as well as RAFT.
I wanted to continue with https://github.com/microsoft/restler-fuzzer/blob/main/docs/user-guide/QuickStart.md, but am a bit lost:

I cannot find a restler_quick_start_results.json
the log in restler-fuzzer/restler_working_dir/RestlerLogs as well as the Python code of restler-quick-start.py suggest that it only performs a smoke test in test mode. Am I supposed to increase coverage now in test mode or in fuzzing mode?

Any executable you find on the container has been compiled with dotnet, so you can run it using the dotnet command. https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet

@acdha, I've also just updated the readme with an example on how to pull the image. If you search for restler on hub.docker.com you will see it now.

Could you please refer me to where the readme file is? Is there an example about how to pull the image and fuzz test with it?
I am trying to run the RESTler container by adding the following to my project's docker-compose file:
...
restler:
  image: mcr.microsoft.com/restlerfuzzer/restler:v7.4.0

Where do I need to pass the spec file?
I am getting the following output:
> Task :startServiceAndWait
--no-ansi option is deprecated and will be removed in future versions. Use `--ansi never` instead.
postgres uses an image, skipping
mockserver uses an image, skipping
endpoint-policy uses an image, skipping
restler uses an image, skipping
--no-ansi option is deprecated and will be removed in future versions. Use `--ansi never` instead.
Creating network "cbe905cc8bfbea0f108d51115b9f0add_myproject__default" with the default driver
Pulling restler (mcr.microsoft.com/restlerfuzzer/restler:v7.4.0)...
v7.4.0: Pulling from restlerfuzzer/restler
Digest: sha256:1d47b455e963f93c67198372d47ca1f10274415a9c75b3e1aa39d381b5adbc88
Status: Downloaded newer image for mcr.microsoft.com/restlerfuzzer/restler:v7.4.0
Creating cbe905cc8bfbea0f108d51115b9f0add_endpoint-policy__mockserver_1 ...
Creating cbe905cc8bfbea0f108d51115b9f0add_endpoint-policy__postgres_1   ...
Creating cbe905cc8bfbea0f108d51115b9f0add_endpoint-policy__restler_1    ...
Creating cbe905cc8bfbea0f108d51115b9f0add_endpoint-policy__restler_1    ... done
Creating cbe905cc8bfbea0f108d51115b9f0add_endpoint-policy__postgres_1   ... done
Creating cbe905cc8bfbea0f108d51115b9f0add_endpoint-policy__mockserver_1 ... done
Creating cbe905cc8bfbea0f108d51115b9f0add_endpoint-policy__myproject_1 ...
Creating cbe905cc8bfbea0f108d51115b9f0add_endpoint-policy__myproject_1 ... done
--no-ansi option is deprecated and will be removed in future versions. Use `--ansi never` instead.
--no-ansi option is deprecated and will be removed in future versions. Use `--ansi never` instead.
--no-ansi option is deprecated and will be removed in future versions. Use `--ansi never` instead.
--no-ansi option is deprecated and will be removed in future versions. Use `--ansi never` instead.
--no-ansi option is deprecated and will be removed in future versions. Use `--ansi never` instead.
Will use localhost as host of postgres
Will use localhost as host of mockserver
Will use localhost as host of myproject
Will use localhost as host of restler
Probing TCP socket on localhost:58912 of service 'postgres_1'
TCP socket on localhost:58912 of service 'postgres_1' is ready
Probing TCP socket on localhost:58913 of service 'mockserver_1'
TCP socket on localhost:58913 of service 'mockserver_1' is ready
Probing TCP socket on localhost:58914 of service 'myproject_1'
Waiting for TCP socket on localhost:58914 of service 'myproject_1' (TCP connection on localhost:58914 of service 'myproject_1' was disconnected right after connected)
Waiting for TCP socket on localhost:58914 of service 'myproject_1' (TCP connection on localhost:58914 of service 'myproject_1' was disconnected right after connected)
TCP socket on localhost:58914 of service 'myproject_1' is ready
--no-ansi option is deprecated and will be removed in future versions. Use `--ansi never` instead.
--no-ansi option is deprecated and will be removed in future versions. Use `--ansi never` instead.

...

BUILD SUCCESSFUL in 1m 51s
14 actionable tasks: 13 executed, 1 up-to-date

It would be great if someone could update the documentation and show how to use the docker version, for Linux users.


--pod-cider argument description in not accurate

[Enter feedback here]
Hi
the description of the argument --pod-cider is stating:
"A CIDR notation IP range from which to assign pod IPs when kubenet is used."
however this argument is now also used for the Azure CNI Overlay feature to define, well, the pod cider :)
I suggest updating the description accordantly.
Thanks
@zioproto

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d75c3a8d-1187-bea1-a7d4-7ebba71c1790
Version Independent ID: 75b0c352-762e-16ae-5cc6-d807ffc1dc3f
Content: az aks
Content Source: latest/docs-ref-autogen/aks.yml
Service: azure-kubernetes-service
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@erezbatish-ms We are looking into it and get back to you for any additional information.

route to CXP team

The argument is --pod-cidr and --pod-cidrs. Can anyone with access correct the typo in the Issue title ? thanks

azure-cli source code contains this information here:

https://github.com/Azure/azure-cli/blob/90ef28c5d4a627c07f9d5758fa3bb35877875dbe/src/azure-cli/azure/cli/command_modules/acs/_help.py#L255
https://github.com/Azure/azure-cli/blob/90ef28c5d4a627c07f9d5758fa3bb35877875dbe/src/azure-cli/azure/cli/command_modules/acs/_help.py#L267

#reassign:schaffererin


Renamed policies toc entry to policy

Renamed policies toc entry to policy as requested by @DCtheGeek

Docs Build status updates of commit f0ed626:
:clock10: Full build: the average full build time is 28 min(s) 58 sec(s), this is based on the last 467 build(s) for this repository.


draft/resume-0.2 implementation, message history support

This got big and messy. A few notes:

I got worried about history replay overrunning the client's sendq, particularly in cases where the client is joined to multiple busy channels. Instead, I added an interface to do blocking writes to the client's socket, bypassing the sendq. Based on my understanding of how progress works in Oragono, this shouldn't cause any problems, because we're writing to the client's socket from the client's own goroutine, and we're not holding any locks while we do it.
I think we might want to add a note to the spec that servers SHOULD verify resume tokens using a constant-time string comparison function, if one is available. (Python 3.6 has secrets.compare_digest, and Go has subtle.ConstantTimeCompare.)
This needs an irctest. It also probably needs more manual testing than I've done (I just unsystematically checked a few different cases of RESUME, with different cap negotiations and different unaffected clients observing the resume.) If you have suggestions about obscure cases to check, I can check them.

Loootsa changes. Looks pretty nice from a browse through. Note to self, maybe change LIST to use sendInternal(true as well so that large responses from that can't overload clients, and make sure that command is penalised more heavily in terms of fakelag than regular commands? (and add the SAFELIST ISUPPORT token).

Pending benchmarks, we might be able to switch all sending of command responses to clients to use BlockingWrite --- keeping the asynchronous Write only for delivery of PRIVMSG and the like.

(Under the current implementation, this is simplified considerably by ResponseBuffer, since no data is actually sent until the final call to ResponseBuffer.Send, which occurs while no locks are held. So we could just call SetBlocking(true) on all of those buffers. But that would make it impossible to do #259.)

Overall, no worries with this implementation from the looks of it. We'll eval those additional possible changes to LIST and such going forward. Thanks for the awesome work on this mate, really appreciate the time you've put into it :)


infobox missing in the browse panel

@zarifbekturdiev see the difference between whg and the Mehdie tool

Check, please @tomersagi

Looks great.


New-AzureRmServiceFabricCluster creates KeyVault without access permissions and fails

When running the first powershell sample "Use the default cluster template that ships in the module
" the KeyVault created does not have any access permissions which causes the cluster setup command to fail: "New-AzureRmServiceFabricCluster : 2:22:54 PM - System.AggregateException: One or more errors occurred. --->
Microsoft.Azure.KeyVault.Models.KeyVaultErrorException: Operation returned an invalid status code 'Forbidden'"
Manually adding permissions for the user account running this to the new KeyVault and running the command again works.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6202fb05-c2b0-b87f-71c9-5683e54f5e0c
Version Independent ID: 39505638-9926-fbc6-a795-3d7699859cde
Content: Create an Azure Service Fabric cluster
Content Source: articles/service-fabric/service-fabric-cluster-creation-via-arm.md
Service: service-fabric
GitHub Login: @aljo-microsoft
Microsoft Alias: aljo

Thanks for the feedback! We are currently investigating and will update you shortly.

I ran into the same issue on Friday (3/8/2019).
Also, the PowerShell sample initializes two variables ($vaultName="myvault" and $vaultResourceGroupName="myvaultrg") but doesn't pass it into the New-AzureRmServiceFabricCluster command causing the Key Vault name to be called "mycluster" and doesn't create a separate resource group for the Key Vault.

@Taharez @jessenguyen7 I just ran through the power shell example modifying it with my own resource names and it worked as expected.
$resourceGroupLocation="westus"
$resourceGroupName="micahsfcluster"
$vaultName="micahsfvault"
$vaultResourceGroupName="micahsfvault"
$CertSubjectName="micahsfcluster.westus.cloudapp.azure.com"
$certPassword="Password123!@#" | ConvertTo-SecureString -AsPlainText -Force
$vmpassword="Password4321!@#" | ConvertTo-SecureString -AsPlainText -Force
$vmuser="myadmin"
$os="WindowsServer2016DatacenterwithContainers"
$certOutputFolder="c:\certificates"

New-AzureRmServiceFabricCluster -ResourceGroupName $resourceGroupName -Location $resourceGroupLocation -CertificateOutputFolder $certOutputFolder -CertificatePassword $certpassword -CertificateSubjectName $CertSubjectName -OS $os -VmPassword $vmpassword -VmUserName $vmuser

Using just the example as written with the exception of changing the DNS name as it is already taken
$resourceGroupLocation="westus"
$resourceGroupName="mycluster5555"
$vaultName="myvault"
$vaultResourceGroupName="myvaultrg"
$CertSubjectName="mycluster5555.westus.cloudapp.azure.com"
$certPassword="Password123!@#" | ConvertTo-SecureString -AsPlainText -Force
$vmpassword="Password4321!@#" | ConvertTo-SecureString -AsPlainText -Force
$vmuser="myadmin"
$os="WindowsServer2016DatacenterwithContainers"
$certOutputFolder="c:\certificates"

New-AzureRmServiceFabricCluster -ResourceGroupName $resourceGroupName -Location $resourceGroupLocation -CertificateOutputFolder $certOutputFolder -CertificatePassword $certpassword -CertificateSubjectName $CertSubjectName -OS $os -VmPassword $vmpassword -VmUserName $vmuser

I see a vault is created called myvalult5555 but also another vault is created myvault

@aljo-microsoft  could you take a look?

@MicahMcKittrick-MSFT I did the same thing (just the example with changed names/location), so not sure what is going on. Some difference in version of one of the modules?

@Taharez
Recommendation is to use AZ Group Deployment with a template. All Wrapper PS commands are intended to ease the provisioning of non production clusters.
https://docs.microsoft.com/azure/service-fabric/service-fabric-best-practices-infrastructure-as-code
@MicahMcKittrick-MSFT
#please-close the command works as intended.


[UTOPIA-1260] Increase size of text input field on collection/use/disclosure table

Description
This PR includes the following proposed change(s):

Added textArea to types list
Added function to test if textArea type or not
Added conditionals in InputText to display textarea if textArea type is detected

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Updating Testing Framework(s)
[ ] Version change

How Has This Been Tested?
Using already available tests, haven't added any other cases.
Development Dependency Working Agreement

[x] My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
[ ] My code DOES include the importing of new dependencies into the DPIA ecosystem
If new dependencies are being introduced to the DPIA ecosystem:
[ ] The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readable
[ ] The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

[ ] N/A
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to project documentation or diagrams that reflect my changes
[x] New and existing unit tests pass locally with my changes
[x] My code follows Airbnb React Style Guidelines

API Development Changes

[x] N/A
[ ] I have performed a self-review of my own code
[ ] My code follows standards and practices outlined in the BC Government API Development Guidelines
[ ] New and existing unit tests pass locally with my changes
[ ] My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

Changes look great! Thank, @NoorChasib
Some tad bits upgrades suggested in the comments above


Chronicles of Darkness 8-Again/9-Again/Rote

Is there a way to include the 8/9/rote quality of World of Darkness.
Also, the ability to separate which rolls are rolls and which rolls are rerolls would be nice.

Have you heard about DiceParser. It is a dice bot for discord and it provides a way to manage COD dice system.
To do it:
!6d10e10c[>7]
Explode on 10, count dice higher than 7.
To add it to your server: https://discordapp.com/oauth2/authorize?&client_id=279722369260453888&scope=bot&permissions=0


Do not propagate keep-old flag for new formulae

When brew-test-bot is called with --keep-old it will pass this flag to
the bottle command. For new formulae this results in an error.

For new formulae this results in an error.

Is it possible to just not pass this flag in this case? How is it being called?

Here is an exert from the Test commands block for Linuxbrew on CircleCI:
... brew tap homebrew/dupes && brew tap linuxbrew/xorg && brew test-bot --tap=homebrew/core --keep-old --verbose

Note that even with this change passing --keep-old flag will still lead to a failure for existing formulae that do not have a bottle block.

Thanks @maxim-belkin!


Sankaku (chan. and capi.) not downloading

What steps will reproduce the problem?
Setting the source to Sankaku and trying to download an images
What is the expected behavior? What do you get instead?
To download images
On capi. - not downloading, on chan. - loads the same picture
How often does this problem occur? On which sources?
All the time. capi.sankaku and chan.sankaku
What version of the program are you using? On what operating system?
6.0.3 windows 7
Please provide any additional information below
Trying to find images with capi.sankaku:
[13:17:43.765][Info] [capi.sankakucomplex.com][Json] Loading page https://capi.sankakucomplex.com/post/index.json?page=1&limit=20&tags=ishikei_(nise_midi_doro_no_kai)
[13:17:46.258][Info] [capi.sankakucomplex.com][Json] Receiving page https://capi.sankakucomplex.com/post/index.json?page=1&limit=20&tags=ishikei_(nise_midi_doro_no_kai)
[13:17:46.301][Info] [capi.sankakucomplex.com][Json] Parsed page https://capi.sankakucomplex.com/post/index.json?page=1&limit=20&tags=ishikei_(nise_midi_doro_no_kai): 20 images, 0 tags (380), -1 total (2091), -1 pages (105)
Try to dowload:
[13:18:38.407][Info] Batch download started.
[13:18:38.413][Info] Loading images 'https://capi.sankakucomplex.com/post/index.json?page=1&limit=200&tags=ishikei_(nise_midi_doro_no_kai)'
[13:18:38.414][Info] [capi.sankakucomplex.com][Json] Loading page https://capi.sankakucomplex.com/post/index.json?page=1&limit=200&tags=ishikei_(nise_midi_doro_no_kai)
[13:19:04.666][Info] [capi.sankakucomplex.com][Json] Receiving page https://capi.sankakucomplex.com/post/index.json?page=1&limit=200&tags=ishikei_(nise_midi_doro_no_kai)
[13:19:04.667][Error] [capi.sankakucomplex.com][Json] Loading error: Error transferring https://capi.sankakucomplex.com/post/index.json?page=1&limit=200&tags=ishikei_(nise_midi_doro_no_kai) - server replied: Internal Server Error (401)
[13:19:04.668][Warning] [capi.sankakucomplex.com] No valid source of the site returned result.
Trying to download with chan.sankaku:
loads the same picture

Just edit the capi to capi-beta to solve that.

The sankaku complex source which is automatically deliverd with the installation of grabber works fine without any problems

"Just edit the capi to capi-beta to solve that."
[19:20:57.464][Info] [capi-beta.sankakucomplex.com][Json] Loading page https://capi-beta.sankakucomplex.com/post/index.json?page=1&limit=20&tags=ishikei
[19:21:07.690][Info] [capi-beta.sankakucomplex.com][Json] Receiving page https://capi-beta.sankakucomplex.com/post/index.json?page=1&limit=20&tags=ishikei
[19:21:07.732][Info] [capi-beta.sankakucomplex.com][Json] Parsed page https://capi-beta.sankakucomplex.com/post/index.json?page=1&limit=20&tags=ishikei: 20 images, 0 tags (380), -1 total (-1), -1 pages (-1)
[19:21:12.453][Info] Batch download started.
[19:21:12.471][Info] Loading images 'https://capi-beta.sankakucomplex.com/post/index.json?page=1&limit=200&tags=ishikei'
[19:21:12.472][Info] [capi-beta.sankakucomplex.com][Json] Loading page https://capi-beta.sankakucomplex.com/post/index.json?page=1&limit=200&tags=ishikei
[19:21:53.457][Info] [capi-beta.sankakucomplex.com][Json] Receiving page https://capi-beta.sankakucomplex.com/post/index.json?page=1&limit=200&tags=ishikei
[19:21:53.458][Error] [capi-beta.sankakucomplex.com][Json] Loading error: Error transferring https://capi-beta.sankakucomplex.com/post/index.json?page=1&limit=200&tags=ishikei - server replied: Internal Server Error (401)
[19:21:53.458][Warning] [capi-beta.sankakucomplex.com] No valid source of the site returned result.
Nothing changed
"The sankaku complex source which is automatically deliverd with the installation of grabber works fine without any problems"
I have no idea why, but after reinstalling chan.sankaku worked (only with "regex" source, JSON return "Loading error", XML and RSS causes a crash).

Yeah it only works with regix but that should also be the only enabled by default in the latest version

Actually on my another project called KngetPy it's works good.

Hmmmm, See https://github.com/Bionus/imgbrd-grabber/issues/1321

None of the Sankaku Complex sources work for me. I've compile from 63251cb since it fixed an issue I and others were having. I managed to get imgbrd-grabber to display images with a given tag but I was not able to download them and I have not been able to get a list of any images again, it just says "No valid source of the site returned (a) result."


Mod is only using deprecated 'modmenu:clientsideOnly' custom value but it is not.

I was getting this: WARNING! Mod ambientenvironment is only using deprecated 'modmenu:clientsideOnly' custom value! This is no longer needed and will be removed in 1.18 snapshots.
so I deleted the
  "custom": {
    "modmenu:clientsideOnly": true
  },

from the fabric.mod.json file but for some reason, the warning still shows up.
https://github.com/TerraformersMC/ModMenu/wiki/API
If I don't add any Discord link or library badge then I should not have a modmenu JSON object within the custom object, right?

[...] the warning still shows up.

This is not possible as far as I'm aware. Please upload the mod jar that is causing this issue.

https://github.com/TerraformersMC/ModMenu/wiki/API
If I don't add any Discord link or library badge then I should not have a modmenu JSON object within the custom object, right?

Correct, it is completely optional.

Ok, this was caused because after you edit the fabric.mod.json file and save it you need to "update the archive" -

The popup got under the main window and I didn't see it.
Sorry!


Updated knox to 2.3.2

Thank you for the contribution. It was merged directly as 4153d8b2dc056bcf60dae28d4be117933a6e5cf5 to keep commit history cleaner. Your contribution is still credited to you.


Different number of parameters than reported for ChangeFormer

@wgcban When I try to get the number of parameters, I get this: 67,308,786(~67M). I am using torchsummary to get the number of parameters. What could be the reason? I did not change anything in the code and am using the same LEVIR shell script to launch training. It seems to be different than what you reported (~41M)
Thanks!

Hi @zaidbhat1234 For me it showed ~41M as the number of trainable parameters. I will check it again and confirm with you.

Hi @wgcban Thanks! Please let me know if it still shows 41M for you and how you measured it.

@wgcban Nevermind. I figured it was due to some changes I made in the architecture. Have you tried to train a bigger (more parameters) model for ChangeFormer? Could you please highlight the impact of increasing the number of parameters.

@zaidbhat1234 I did not try training bigger models due to the longer pre-training time. But you can always try. Based on my experience, bigger transformer models usually perform better, provided you tune the model correctly. Thanks.


Better error message for !eval when using input

Currently snekbox returns this error message

Which is not descriptive enough to show that we don't explicitly support input() and it can be just replaced by a string.
#2255

I think that's a separate issue that could be opened on this repo though. Even if we did support input users would get an EOFError if they forgot to supply it, so improving that response would make sense anyway.

I think the nicest way would probably be to leave the error message as is and insert a message above/below it with information, something along the lines of:

Sure, I also think the same. Assign the issue to me and I will make a quick pr.


Laboratory work #7, Skachkova Anastasia - 20FPL2

Necessary implementation of loading your dataset.

It's time to write the loading of your dataset.


[WIP] adding osx release to github actions

Trying out releasing from github actions.

works!

yes... gonna change the name


Add submit questionnaire button to sdc module

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1088
Description
Clear and concise code change description.

Show submit questionnaire button when layout is default.
Show Submit questionnaire button instead of Next button on last page when layout is paginated
Add onSubmit callback onSubmit button click
Make visible, invisible,  and Gone submit button through custom style.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct
[x] I have read the Contributing page
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
[x] I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

when Submit questionnaire button visibility declared as gone in custom style in catalog app

https://user-images.githubusercontent.com/86107848/155719129-dc376bbf-f201-4c08-8dd8-19da0360ef7e.mov

by default submit questionnaire button visibility is visible and only visible when scroll reach at the bottom of the page in default layout and  on last page when layout is paginated.

https://user-images.githubusercontent.com/86107848/155718699-0e1fb165-ca3a-4f51-991a-880dba4bfee3.mov

can you make the submit button always visible in this case - i think showing and hiding it depending on scroll seems a bit strange.
alternatively, i think we could make the submit button an additional item in the recycler view so it will be just at the bottom of the questionnnaire. but we should check with @shelaghm on that one. for now the simplest implmentation that is consistent with the paginated layout is just to always show this button.

@santosh-pingle @jingtang10
My perspective is that for default layout the submit button is only visible at the bottom of the whole questionnaire. The behavior I'm hoping to encourage is that users go through the whole survey. I want to avoid people accidentally clicking submit too early because it's visible to them, but they didn't know the survey was longer.

can you make the submit button always visible in this case - i think showing and hiding it depending on scroll seems a bit strange.
alternatively, i think we could make the submit button an additional item in the recycler view so it will be just at the bottom of the questionnnaire. but we should check with @shelaghm on that one. for now the simplest implmentation that is consistent with the paginated layout is just to always show this button.

https://user-images.githubusercontent.com/86107848/170464391-f414837f-9209-4025-909e-37544c89b3e9.mov

can you make the submit button always visible in this case - i think showing and hiding it depending on scroll seems a bit strange.
alternatively, i think we could make the submit button an additional item in the recycler view so it will be just at the bottom of the questionnnaire. but we should check with @shelaghm on that one. for now the simplest implmentation that is consistent with the paginated layout is just to always show this button.

@santosh-pingle @jingtang10 My perspective is that for default layout the submit button is only visible at the bottom of the whole questionnaire. The behavior I'm hoping to encourage is that users go through the whole survey. I want to avoid people accidentally clicking submit too early because it's visible to them, but they didn't know the survey was longer.

@shelaghm in the paginated layout at the moment, we have the prev/next buttons always always visible. this is inconsistent with what you suggested here. should we change that too? if that's the case - we can probably add a follow-up pr to change both (single/multiple page layouts)

https://user-images.githubusercontent.com/86107848/170643589-97b059ff-772b-4736-b683-6a5c1a0f8960.mov


Add the ability to view an image labeled as a link without displaying it

Often there is no picture displayed in a note, but just a link to it. The picture is shown only when you hover over the link. In this mode the picture is not opened by the plugin.
I need this function every day dozens of times. For its sake I have to use the Hover editor plugin. But it is not so convenient and fast.

Hi, what is the editing mode of your note, e.g. reading, source mode, or live preview? Normally, when your note can display images in reading or live preview mode, not just a link like ![[image.jpg]] in source mode, you can click and preview the image via this plugin. So, I guess that your note is in source mode? If this so, you can try to switch to reading or live preview mode.

The picture cannot be opened through the plugin in both read and edit mode.
I attached a video where I tried to show what I mean. First I open the image with the plugin and everything works fine there.
But then there is an example with a picture as a link, which is not displayed as a picture, but just as a link. When I hover over it, it is displayed with Obsidian itself, but I can't open it with the plugin (as in the beginning of the video).
I try to do it in edit mode and in view mode. In both cases I can't open the image with the plugin.
https://github.com/user-attachments/assets/63c24ffe-9b74-4c0a-a8ae-19bc1bedd308

Pic_20241120_103540.mp4

The cause may be that the image 'CPU and memory' does not start with an exclamation mark. Normally, we use ![[image.jpg]] to display an image, while this format [[image.jpg]] is simply a file link. So try to add an exclamation mark before that.

Pic_20241120_103540.mp4

The cause may be that the image 'CPU and memory' does not start with an exclamation mark. Normally, we use ![[image.jpg]] to display an image, while this format [[image.jpg]] is simply a file link. So try to add an exclamation mark before that.

In my usage scenario, I often purposely remove the “!” in front of a picture so that it doesn't show up until I hover over it.
I often have to write condensed text with lots of pictures. In order to keep the note visually concise, I remove the default display of pictures, leaving the option to quickly display the picture I want when hovering over a link to it. That is, you get a sentence that has words that are links to pictures. Of course, the link and the word are related in meaning.
The point is that such links often give me additional context, which I usually remember, but from time to time I can forget something somewhere and hovering over a picture helps to quickly refresh my memory.
In my case, if all the pictures are displayed at once (i.e. I put a “!” in front of them), the note will be visually cluttered, cumbersome and it will be difficult to quickly read the overall gist of the note. Often I may have 4-7 links per sentence that are pictures.
When reading such notes, when the picture pops up when you hover over the link, it often happens that its size is too small. That's where your plugin would help me. I could open the pop-up picture through it and enlarge it to the desired size.
Also in such notes it is often necessary to quickly open several such pictures, adjust their size and put them next to each other. Here your plugin could also help a lot.
In general, I have long been in need of this functionality almost every day. If there is a technical possibility to realize this, it would really help me with my work. Thank you for your attention and desire to understand the problem. 🙏


ci(): use GitHub actions instead of appveyor & travis

ATM only have the publish workflow ported (next is the testing workflow to replace travis), which should publish to GitHub packages when run, although I need to test it (on my fork). And assuming we don't care about publishing to NuGet and GH packages, then no more dealing with the nuget API key expiring every year, so that's nice.
Some questions on this, I'm assuming we want to run the tests before doing the publishing, right? And when do we want to trigger the workflow? ATM I just have it set to run when triggered manually, but that should be able to be set up to run on pushing a version tag.

Some questions on this, I'm assuming we want to run the tests before doing the publishing, right?

yes

And when do we want to trigger the workflow? ATM I just have it set to run when triggered manually, but that should be able to be set up to run on pushing a version tag.

Manual is fine for now. Let's just be sure to document the "release steps" similar to here. That makes the surface-area visible, and then we decide whether it makes sense to ever automate these steps.
Explicit is usually better, at least to start with. Implicit triggers like publish-on-tag can be surprising.

Okay, this is ready for review; added the test workflow, the tests are run before the publishing part of the publish workflow, and got the publish workflow to publish a package finally after some trial and error.
Only thing left I guess is documentation on how to publish a package, which is pretty easy, just update the version file in src/NvimClient.API/NvimClient.API.csproj and run the workflow.
I can put the above (formatted in steps) at the bottom of the README, sound good? (Note that the last step is obviously only available for maintainers; I guess that could be in the README maybe? not 100% sure . . .)
Also, I'll make a follow-up PR after this swapping out the CI status badges for the new GH actions ones (unless there's a way to do that without merging this first?).

Only thing left I guess is documentation on how to publish a package, which is pretty easy, just update the version file in src/NvimClient.API/NvimClient.API.csproj and run the workflow.
I can put the above (formatted in steps) at the bottom of the README, sound good?

yes

(Note that the last step is obviously only available for maintainers; I guess that could also be in the README maybe with the steps? not 100% sure . . .)

only maintainers can "release" anyway. Don't need to mention it.

Before I merge, thoughts on https://github.com/neovim/nvim.net/pull/14#discussion_r704787352 ?
Also, just a note, once this is merged I'll wait to publish the package until I add the documentation for the public members it's giving warnings about (see here), so that's available in the release.


docs: update color palette

Update the color palette in the docs!

@emilwidlund Maybe you'll want to have a look at this 😊