How to customize UAA login page?

Is there a document to customize UAA login page?

The only things customizable are listed below
login.branding.company_name:
    description: This name is used on the UAA Pages and in account management related communication in UAA
  login.branding.product_logo:
    description: This is a base64 encoded PNG image which will be used as the logo on all UAA pages like Login, Sign Up etc.
  login.branding.square_logo:
    description: This is a base64 encoded PNG image which will be used as the favicon for the UAA pages
  login.branding.footer_legal_text:
    description: This text appears on the footer of all UAA pages
  login.branding.footer_links:
    description: These links appear on the footer of all UAA pages. You may choose to add multiple urls for things like Support, Terms of Service etc.
    example:
      linkDisplayName: linkDisplayUrl

You seem to be using a custom UAA service broker that we don't manage. The steps provided were for updating the bosh deployed UAA.  Can you provide more details on the service broker. Is this Pivotal SSO Service?

I don't think it is Pivotal SSO Service. I'm developing in SAP cloud platform(cloud foundry). I use UAA + "SAP ID Service" as my Authentication and Authorization server.


Improve discoverability of your work on HF

Hi,
Niels here from the open-source team at Hugging Face. Congrats on your work! I discovered your work through the paper page: https://huggingface.co/papers/2407.18054 (feel free to claim the paper so that it appears at your HF account!).
However there are a couple of things which could improve the discoverability of your work, which I've listed below.
Upload checkpoints in seperate model repos, make sure download stats work
I see the models are already on the hub which is great, however we recommend pushing checkpoints to individual model repos so that download stats work.
Here's a guide: https://huggingface.co/docs/hub/models-uploading#upload-a-pytorch-model-using-huggingfacehub. The PyTorchModelHubMixin is suited for custom PyTorch models, as is the case here.
Let me know if you need any help regarding this!
Cheers,
Niels
ML Engineer @ HF 🤗

Hi,
Niels here from the open-source team at Hugging Face. Congrats on your work! I discovered your work through the paper page: https://huggingface.co/papers/2407.18054 (feel free to claim the paper so that it appears at your HF account!).
However there are a couple of things which could improve the discoverability of your work, which I've listed below.然而，有一些事情可以提高你的作品的可发现性，我在下面列出了这些。
Upload checkpoints in seperate model repos, make sure download stats work
I see the models are already on the hub which is great, however we recommend pushing checkpoints to individual model repos so that download stats work.
Here's a guide: https://huggingface.co/docs/hub/models-uploading#upload-a-pytorch-model-using-huggingfacehub. The PyTorchModelHubMixin is suited for custom PyTorch models, as is the case here.
Let me know if you need any help regarding this!
Cheers,
Niels ML Engineer @ HF 🤗

Thanks , we will add this support soon.

Great!
Btw, HustVL does have an organization on the hub: https://huggingface.co/hustvl
Would be great to make them available there!

Hi @xiazhi1 I saw your email, would it be possible to contact someone part of the HustVL organization on HF and ask for access?

HI @xiazhi1 I saw you pushed a checkpoint here: https://huggingface.co/hustvl/LKCell-L. Great!
However I also see you removed the Mixin: https://github.com/hustvl/LKCell/commit/8583e6abcf00f82ffeaf94e46cfe9c352ed1278d, any reason for this?
Let us know if there's any problem with it :)

HI @xiazhi1 I saw you pushed a checkpoint here: https://huggingface.co/hustvl/LKCell-L. Great!
However I also see you removed the Mixin: 8583e6a, any reason for this?
Let us know if there's any problem with it :)

That was a wrong upload. We will upload our weights to https://huggingface.co/hustvl Please stay tuned.


pass daemon name and directory path to hook

Since we might be running multiple blackholes, passing the daemon name to a hook may be favorable for identifying the invoking daemon. For example, the hook may display the name in a desktop notification.
Also, the path to the directory may be used in different use cases, such as opening a file viewer, etc.
Tasks:

[x] implement the feature
[x] test the feature
[ ] document the feature

Done in commit https://github.com/GochoMugo/blackhole/commit/ef98e5afab83e776a4d5c43fe17c2851ee5f673b.


Adds custom ingredients method

Resolves #1
Overview:

Adds the custom method ingredients to get the ingredients in a recipe from thecookingguy.com

Changes:
'recipe_scrapers/thecookingguy.py'

adds normalize_string import
finds all list elements in the div class
normalizes each string from the list elemets

Testing:
Ran the following commands in the python console and got the expected output of a list of strings representing the ingredient list.

from recipe_scrapers import scrape_me
scraper = scrape_me("https://www.thecookingguy.com/recipes/chili-cumin-lamb")
scraper.ingredients()

Looks good to me, tested with https://www.thecookingguy.com/recipes/chili-cumin-lamb and https://www.thecookingguy.com/recipes/chicken-shawarma, both worked as expected and ignored subheadings as expected.


The github repo web interface still has a reference to readthedocs.io in repo title description

Agent Version
Any
Operating System
github.com web interface
OpenStack Release
Any
Description
The github.com web interface has a link to readthedocs.io in the repo description
Deployment
Goto https://github.com/F5Networks/f5-openstack-agent and read the repo discription

Fixed.


Another Neovim Editor Plugin

Issue
After using the existing neovim aider plugin (which was great), I've decided to build a different one with different features.
Namely, I didn't want aider to auto track all buffer files that are open.

This  plugin integrates with a neovim fuzzy file picker to select one or multiple files to add
It allows using visual mode text selection (highlighting text) in-conjunction with prompting for a question to /ask
It auto keeps the sessions alive when toggled so the context remains active

There are several AI plugins in Neovim for editing files and asking questions that I've used quite a bit. However, taking advantage of the incredible existing functionality of aider, and only focusing on the Neovim integration parts, enables easily building a plugin that surpasses them all. Thank you for building this incredible tool!
https://github.com/aweis89/aider.nvim
Version and model info
It uses whatever aider command is in PATH, so it supports the latest version

Thanks for trying aider and filing this issue and making a new editor integation!


Model Reproducibility Issue

Hello, when I used the command sh scripts/SparseTSF/etth1.sh to reproduce the results from the paper, I found that the predictions with sequence lengths of 336 and 720 differ significantly from the results reported in the paper. However, the results for the first two lengths are within a reasonable range. Could you please help me understand why this discrepancy might be occurring?

Hello, the results you reran seem to be correct and consistent with ours. We recently fixed a longstanding bug in this code framework (see description in TFB), which caused the last batch of data to be dropped during the testing phase. This bug mainly affected performance on small datasets, such as ETT1 and ETTh2.

    This probably means that you are not using fork to start your
    child processes and you have forgotten to use the proper idiom
    in the main module:

        if __name__ == '__main__':
            freeze_support()
            ...

    The "freeze_support()" line can be omitted if the program
    is not going to be frozen to produce an executable.

为什么会出现这个问题

    This probably means that you are not using fork to start your
    child processes and you have forgotten to use the proper idiom
    in the main module:

        if __name__ == '__main__':
            freeze_support()
            ...

    The "freeze_support()" line can be omitted if the program
    is not going to be frozen to produce an executable.

为什么会出现这个问题

我也遇到了这个问题，我认为可能是作者实在linux环境下跑的代码，linux系统中可以使用多个子进程加载数据，而在windows系统中可能因为缺少某个系统调用而无法进行此操作。
解决办法：在run_longExp.py中，num_workers的默认值改为0即可解决问题，但会导致数据加载慢的问题
parser.add_argument('--num_workers', type=int, default=10, help='data loader num workers')

    This probably means that you are not using fork to start your
    child processes and you have forgotten to use the proper idiom
    in the main module:

        if __name__ == '__main__':
            freeze_support()
            ...

    The "freeze_support()" line can be omitted if the program
    is not going to be frozen to produce an executable.

为什么会出现这个问题

我也遇到了这个问题，我认为可能是作者实在linux环境下跑的代码，linux系统中可以使用多个子进程加载数据，而在windows系统中可能因为缺少某个系统调用而无法进行此操作。 解决办法：在run_longExp.py中，num_workers的默认值改为0即可解决问题，但会导致数据加载慢的问题 parser.add_argument('--num_workers', type=int, default=10, help='data loader num workers')

确实这个问题，我改了之后不报错了，但在交通数据集上跑得很慢.


fix array for numpy support

The __array__ method of numpy is changed, as specified in https://numpy.org/doc/stable/reference/generated/numpy.ndarray.array.html
Sometimes an extra parameter will be passed to __array__ by numpy methods, in that case, instead of throwing the defined as expected, a TypeError: __array__() takes 1 positional argument but 2 were given will be thrown so it will be confusing.
It is similar to the change in tensorflow https://github.com/tensorflow/tensorflow/commit/fc0f0e61ca9fe3ca3b9b58f51bcf00e0643ed9e3

This code can produce the problem
import tensorflow as tf
from tensorflow.python.keras.engine import keras_tensor
import numpy as np
kt = keras_tensor.KerasTensor(
        type_spec=tf.TensorSpec(shape=(1, 2, 3), dtype=tf.float32))
np.asarray(kt, dtype=np.int)

it throws

TypeError: array() takes 1 positional argument but 2 were given

the expected behavior should be like the result of
import tensorflow as tf
from tensorflow.python.keras.engine import keras_tensor
import numpy as np
kt = keras_tensor.KerasTensor(
        type_spec=tf.TensorSpec(shape=(1, 2, 3), dtype=tf.float32))
np.asarray(kt)

Which throws

TypeError: Cannot convert a symbolic Keras input/output to a numpy array. This error may indicate that you're trying to pass a symbolic value to a NumPy call, which is not supported. Or, you may be trying to pass Keras symbolic inputs/outputs to a TF API that does not register dispatching, preventing Keras from automatically converting the API call to a lambda layer in the Functional Model.

Thanks for the PR!

@tomerk
Kindly, did you find out how to solve this issue :
TypeError: Cannot convert a symbolic Keras input/output to a numpy array. This error may indicate that you're trying to pass a symbolic value to a NumPy call, which is not supported. Or, you may be trying to pass Keras symbolic inputs/outputs to a TF API that does not register dispatching, preventing Keras from automatically converting the API call to a lambda layer in the Functional Model.
Please help..

Hi @AliSaeed86, in the latest versions of TensorFlow we have made this error provide a clearer explanation, and actionable workarounds.
E.g. in colab.sandbox.google.com, running the following:
import tensorflow as tf

@tf.function
def foo(x):
  return x

inp = tf.keras.Input(shape=(3, 2))
foo(inp)

Will error out with:
TypeError: You are passing KerasTensor(type_spec=TensorSpec(shape=(None, 3, 2), dtype=tf.float32, name='input_4'), name='input_4', description="created by layer 'input_4'"), an intermediate Keras symbolic input/output, to a TF API that does not allow registering custom dispatchers, such as `tf.cond`, `tf.function`, gradient tapes, or `tf.map_fn`. Keras Functional model construction only supports TF API calls that *do* support dispatching, such as `tf.math.add` or `tf.reshape`. Other APIs cannot be called directly on symbolic Kerasinputs/outputs. You can work around this limitation by putting the operation in a custom Keras layer `call` and calling that layer on this symbolic input/output.

Thanks @tomerk for your fast reply.
I am new to tensorflow and keras, please forgive my ignorance.
Kindly, does that mean i can change KerasTensor to a numpy during model building through building a custom layer ?
Thanks in advance.


['Create habit' page edit mode] Inconsistency in the information message after Picture Upload

Environment:
OS: macOS Ventura 13.4
Browser: Google Chrome Version 114.0.5735.133
Reproducible: always
Pre-conditions

Registered user is logged in https://www.greencity.social/.
“My space” page is open.

Steps to Reproduce

Click on the 'Add New Habit' button.
Click on the 'Create habit' button.
Locate the ‘Picture (optional)’ field.
Upload file with 'webp' format.

Expected result
The information message should be displayed as "Upload PNG or JPG only. File size should be less than 10MB" and highlighted in red to indicate the importance of the message.
Actual result
The information message is displayed as "Download PNG or JPG only. File size should be less than 10MB" instead of "Upload PNG or JPG only. File size should be less than 10MB".
Screenshots

User story and test case links
"Change request to #1001 . Add new custom habit https://github.com/nromanen/pratical_testing_2022/issues/192"

The information message is changed correctly, but highligted in grey color, must be in RED.

I will fix itSent from my iPhoneOn 10 Aug 2023, at 12:03 PM, Vadym @.***> wrote:
The information message is changed correctly, but highligted in grey color, must be in RED.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were assigned.Message ID: @.***>


Add testing for sct_deepseg

After https://github.com/neuropoly/spinalcordtoolbox/pull/2639 is merged, we should implement testing.

Testing will also include check of inference fields (threshold, etc.), after #2695 is solved.


npm run generate and dynamic routes

Hi there,
I can't get dynamic routes to work with nuxt generate.. I must be missing something?

create the starter project (vue init nuxt/starter )
add the folder/file "pages/posts/_id.vue"
npm run generate

the docs tell me I should get an error (Could not generate the dynamic route /posts/:id, please add the mapping params in nuxt.config.js (generate.routeParams).)
But i don't get this error, its simply ignored and there is no file in the dist folder. Even if I do add the mapping params it is still ignored?
"npm run dev" works as expected
Thanks

Hi, you may be looking an outdated documentation.
Please refer to https://nuxtjs.org/api/configuration-generate/#routes


Replace ServerSide Joins with Dataloader Batches

Going forward
After leveraging server side joins in a real production scenario it seem not a good option to resolve GraphQL queries.
The complexity and the computation needed to leverage dynamic joins is not worth.
GraphQL-thinky will now go in another direction, still leveraging batching and performant queries but this time with Dataloader in place.

No Server side joins between resolved fields

Yes, batching ids and queries computation, with intelligent comparison of similar queries to reduce round trips to the Database.

Customisable query batching

Will be one of the first library to orchestrate internally Dataloader to perform efficient queries

Progress

The first working version is now under testing, the results are pretty good and efficent
Beta release out  npm 0.4.0-beta-1 working branch dataloader-branch
Full version, Shipping in a week or two

Breaking changes

I tried to keep breaking change at the minimum, here the list:

Replaced limit argument with offset
Working Progress...

Beta release out  npm 0.4.0-beta-1 working branch dataloader-branch
TODO

[ ] Order By argument
[ ] More unit tests around the ModelLoader class
[ ] Introduced FlowTypes, increase flow coverage
[ ] Tidy Up Code and comments

0.4.0-beta-3 almost out, The following changes are done:

Refactored whole code base, removing redundant code of previous versions
Dataloader now can prime result safely if is not requested to select specific fields
Added useful error messages, through the code base
Improve whole stability of the library, Performance are pretty good
Refined Relay Connection

Stay tuned for the release

0.4.0-beta-3 Released!
Current Stage
The query resolution of the library has been successfully migrated to use Dataloader batch and cache instead of joins across the schema. General bug fixes and smaller overall codebase, Server side Relay ready, and Integration tests are all passing.
What's next?
The library is preparing for the official version 0.4. There wouldn't be any further optimizations on the query resolution side until the v0.4 is out. The todo list above has to be completed before move forward.
Notes
As I accepted the challenge to optimize graphql-thinky for a production environment, the entry of Dataloader in the project was needed BUT experimental. With few schemas on my whiteboard I could see that it could work if I only could try. The overall effort that i spent on it is absolutely
gratifying.
To the Community
As the project is moving forward, the community help is very precious in terms of feature and improvements. If you have any doubt, question or consideration please feel very welcome to open an issue! 👍


"HaxeToolkit/haxe/lib/extension-webm/git/ndll/Windows64/extension-webm.ndll does not exist"

After installing all of the necessary downloads, I also installed Visual studio 2019. When I try to build the game, (lime test windows) I get the error HaxeToolkit/haxe/lib/extension-webm/git/ndll/Windows64/extension-webm.ndll does not exist

you will need to download this on your cmd prompt. lime rebuild extension-webm windows please close this once resolved.

you will need to download this on your cmd prompt. lime rebuild extension-webm windows please close this once resolved.

if anything else is wrong , please refer back to the building.md here.

you could also take one mods extension-webm.ndll and on the HaxeToolkit/haxe/lib/extension-webm/ndll/Windows, copy the gitignore then make a folder called Windows64 then paste the 2 files, done!!!

you could also take one mods extension-webm.ndll and on the HaxeToolkit/haxe/lib/extension-webm/ndll/Windows, copy the gitignore then make a folder called Windows64 then paste the 2 files, done!!!

it's like super easy for me lol


[23.11] gleam: 1.0.0 backport

(cherry picked from commit 104fab360483d68fc874f21885a830fc869bbfd5
Description of changes

Backport to bump Gleam to v1.0.0 due to current stable version being out of date and unsupported.
Original PR #293776
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/gleam-1-0-release-overlay/41199/2


Secure connections to the Hawkular-Metrics

New features

Add token authentication support and support for SSL connections

Tests

Integration testing should use init() method to test its behaviour also

Bugs

Fix StoreTimeseries pointer mess up in calling registerIfNecessary with goroutine

Misc

Update Hawkular-Metrics driver to 0.5.1

Can one of the admins verify this patch?

ok to test

LGTM. Thanks @burmanm! Is Open shift managing heapster releases separately or do you want me to make a new release sometime soon?

@vishh For now I believe the next release will come in time anyway (around mid of October is the cut-date for new features), if you had planned a later release date, then I'll need to ask someone who knows more ;)


eroshare links should download from mirror

The site spacescience.tech provides a mirror of eroshare (With content being hosted on the Internet Archive's Wayback Machine). The mirrors been up for ~ a month
The eroshare ripper should both rip from spacescience.tech when given a eroshare link (https://eroshare.com/dt0kt9hu -> https://spacescience.tech/dt0kt9hu) and accept spacescience.tech links

Looks like this mirror is down but there's a new one: via https://eroshae.com/ -- content also sourced from wayback machine. Example: https://eroshae.com/dt0kt9hu (NSFW)

I see you already updated your PR with eroshae.
(copying my comment from the PR:)

Also, rather than relying on a rehost, we could actually set up the redirects to internet archive / wayback machine on our own. There's basically two things to look for: the site pages (which are backed up in wayback machine) and the content, which is also hosted on the internet archive, and we can pull the link format directly out of a rehost like eroshae and extrapolate the redirect.


Minor: port last test from parquet.rs

Which issue does this PR close?
Follow on to https://github.com/apache/arrow-datafusion/pull/8560
Related to https://github.com/apache/arrow-datafusion/issues/8206.
Rationale for this change
While porting tests in parquet.rs to sqllogictests @hiltontj noticed there was a disabled test that could be ported.
The test predates most of DataFusion / the parquet crate's ability to read structured data / arrow-rs's ability to print it so it was somewhat akward in its original form. Given the better support now things are in much better shape
What changes are included in this PR?

port final test and remove parquet.rs module

Are these changes tested?
all tests

Thank you for the review @comphead


Add natscli download

The natscli can be used with nats that comes with openfaas/faasd
https://github.com/nats-io/natscli/releases/
Example use-case where I needed this -> https://lucasroesler.com/posts/2021/event-driven-faasd-with-postgres/ from @LucasRoesler

@developer-guy or @nitishkumar71 would you like to take this one?

yes, I would like so 🙏


Different App

is this the source code for https://itunes.apple.com/tw/app/ai-liao-li/id554065086 ?
it seems like this repo is not the source code for this ios app.

This repo is a tvOS app, not an iOS app.
However, it is bundled with the iOS app https://itunes.apple.com/tw/app/ai-liao-li/id554065086 in the App Store. They are different apps sharing the same title.


Template isn't working v2

templating isn't work after adding any code to it

Same happened to me

Same here.
<a href>
  <img alt src(unknown)>
</a>

Omit the template option and it works, but would be good to have control.

Did you manage do get code inside the template running? Mine doesn't.


Azure open ai working keys found in .env

Hi You have uploaded your azure open ai keys in env file.

Thanks mate <3


Octave Interface

Since we have a Matlab interface does it make sense to do the same for Octave? I noticed that Swig had a note in there releases about supporting Octave 4.2 so it seems it may be supported in the standard swig.

The first version of this is in #209


Preferred citation format

Currently there is no straightforward way to cite OpenFAST as a whole and give credit to the main authors of the code or the people that heavilly contributed with research on making it happen.
This is more of a discussion than a feature request.
Is there some default citation for openFAST as a whole or the modules should be individually adressed?

Good question.
In a recent paper, I referenced OpenFAST quite generically e.g.:
"OpenFAST (formerly known as FAST) [1] models the ...."
"REFERENCES
[1] Web page https://github.com/OpenFAST/openfast (accessed May 7, 2018)."
But I agree that this is very generic and doesn't really identify specific contributions.  Depending on what I want to refer to, I've also referenced specific OpenFAST-related publications e.g. here is the AIAA SciTech 2013 paper describing the FAST modularization framewok:
"[4] Jonkman, J. M. “The New Modularization Framework for the FAST Wind Turbine CAE Tool.” 51st AIAA Aerospace Sciences Meeting including the New Horizons Forum and Aerospace Exposition, 7–10 January 2013, Grapevine (Dallas/Ft. Worth Region), TX [online proceedings]. URL: http://arc.aiaa.org/doi/pdf/10.2514/6.2013-202. AIAA-2013-0202. Reston, VA: American Institute of Aeronautics and Astronautics, January 2013; NREL/CP-5000-57228. Golden, CO: National Renewable Energy Laboratory."
But I'd be happy to hear what others recommend.

What do you think about:
OpenFAST vX.Y.Z (Accessed May 7, 2018). Available at https://github.com/openfast/openfast/.

I think Google Scholar will track OpenFAST vX.Y.Z

I would suggest something more inclusive - for example, 4-5 authors/coders or people the namelist of people that contributed to approximately 90% of the whole code and functionality. I'm not very familiar with the contribution history of FAST and OpenFAST to provide such a name list.

I'm not sure it is common to reference a website / software in terms of lead developers.  I think the citations identified above are more common in literature.
Some of the biggest contributors to OpenFAST (and its predecessor, FAST) are (in alphabetical order, by last name) :
Marshall Buhl
Greg Hayman
Jason Jonkman
Bonnie Jonkman
Rafael Mudafort
Andy Platt
Mike Sprague
But there are many, many others who provided important contributions to the software over the years.

We could maybe add a entry on zenodo https://zenodo.org/ , that gives us a DOI to use for references.
See for instance this guide:
https://guides.github.com/activities/citable-code/#finishing-up

So we've done this with FLORIS and I've been thinking about it for OpenFAST also, but I'm just not sure what it really gets us in addition to another reference to the software. I guess this would set the citation format, but I'm not really a fan of its method. For FLORIS, zenodo says:
Rafael M Mudafort, paulf81, bayc, Pete Bachant, ejsimley, Katherine Fleming, & jrannoni. (2019, June 25). NREL/floris: v1.1.4 (Version v1.1.4). Zenodo. http://doi.org/10.5281/zenodo.3256660

In this case, paulf81 and bayc are GitHub usernames and the authors are listed in order of most contributions.

I see that it's indeed not the best output... I'd think that as long as you provide the bibtex entry for the latex users and the preferred citation string for other users, it would be fine. For the bibtex entry, you can add  doi = {XX.XXXX/zenodo.XXXXXXX}.  But that's just a suggestion.
Last time I used the suggested citation format with the github repository, the journal I submitted to replaced it by . Available at http://doi.org/github.com/OpenFAST/OpenFAST/  which is not ideal either (maybe I should I paid attention to it.. )


Reporting warning information when the env variables in yaml files are not set

Environment values in YAML files are very important to make sure the assets are created correctly. If environment values are not set, error codes returned from backend will be shown to end users, which make end users confused. So we should give clear warning messages to end users when env variables are empty.

Duplicated with #399. Close this one.


Don't match every Jira issue found in PR description

(continuing from https://github.com/atlassian/github-for-jira/issues/119#issuecomment-1010360037)
Recently you released a feature where a Jira issue ID like TEST-12 can be included in the description of a PR and automatically linked to the issue.
This is great, but it's common to refer to multiple tickets within the description of a PR, and the PR itself only be associated with one Jira ticket.
Personally, I would only expect a PR to be linked to a Jira issue if it matched something like fixes [TEST-12] or closes [TEST-12]. A special keyword would ideally be required before the issue ID, and the issue ID be "linked" i.e. wrapped with [ and ].
Any chances you could refine this feature to provide more control over this linking?

Down vote.

@AlecRust We'll have a conversation internally about this as for the most part our customers wanted this current functionality to associate all tickets in body.  I'm curious about your use case though and would like to know more.  Maybe give some examples.  We're curious to know why you're referencing other tickets and why having that PR associated with multiple tickets is an issue.
There are a few ways to approach this that I think would work for everyone, but we need to document all the use cases first.
Thanks!

Thanks @mboudreau. I'm looking for more control over whether a PR counts as "development work for this Jira issue" like GitHub provides. For example, if a GitHub PR description contains this:
Following work in #123, this PR does X and fixes #321

It will create an association with the #123 GitHub issue, but it won't close it i.e. it's not development work for that issue. The fixes part before #321 however makes it special and means the merging of the PR will close issue #321 i.e. it is development work for that issue.
This difference between a PR merely referencing an issue vs a PR being development work for an issue is what I'm looking for.
Personally, for this integration I would expect the following matching:

TEST-12 - Do nothing as it's not written with link syntax to a Jira issue.
[TEST-12] - Turn the text into a link to the Jira issue (as it does currently)
fixes [TEST-12] - Associate the PR as "development work" on the Jira issue
closes [TEST-12] - Associate the PR as "development work" on the Jira issue

Hi @AlecRust, thanks for you feedback!
Atlassian is currently trying to build up a graph of devops information. For example, from above, issue 123 is related to 321 via the fix PR. But right now, the graph is still a tree with the issue as the root.
What you're describing would require having different types of arcs in the devops graph. This is quite a while away, in part because UX for setting the arc type would likely be language dependent.
I'll forward the feedback to the team that is building out the graph, and we'll leave this issue open to ensure we keep gathering feedback. However, given how many customers have requested issue key identification in the PR body, we will bias toward keeping issue association as low friction as possible.
Cheers!
Christian

Would it be possible to enable customers to enable/disable each type of automatic linking? We're also experiencing tickets resolving/closing unexpectedly due to their mention in a PR body or linking in a review. It seems like enabling granular control of the linking capability would be a simple way to satisfy most customer needs.

to add another example we commonly use, i may write in a description: "Additional work has been cut from the scope of this PR and will be done in ticket X" to demonstrate that we have a ticket to keep track of the followup work and that it will not fall through the cracks. But now the followup ticket closes on pr merge...

There is an easy workaround (although ugly, but anyway, just to mention for the sake of completeness): if you replace - in issue key with something else (space, underscore), the association won't be created... ("TEST 123" – not an issue key,  "TEST_123" – not an issue key, "TEST -123" – not an issue key)

It's a very common use case to include an "out of scope" section in a Pull Request description to indicate tickets that were not fixed in the PR.
This new functionality is causing out-of-scope tickets to be linked to PRs and then automatically moved to "done" based on our automations when the PR merges.
It would be very nice to be able to toggle off this functionality or set an explicit pattern that picks up only certain tickets linked in a Pull Request description.

Hi,
I think a lot of developers would be really really happy if y'all limit the complexity of your ticket matching. Less maintenance for the JIRA developers + less work for the rest of us who are constantly undoing JIRA automations.
Since it is a very widespread, accepted practice that devs reference ticket numbers in the titles of pull requests, how about:
Only link JIRA tickets to pull requests if and only if there's a corresponding ticket number in the pull request title. Ignore all comments, descriptions, commit messages, etc.
Do you want proof that it's a widespread and accepted practice? I just took a look at your open pull requests:

I few this differently and the current implementation is less complex IMO.  Many developers gather a list of commits within a single PR where each commit might reference different tickets they resolve.  This is used by our server side teams but also more widely used by our mobile developers since it does require them to publish an app to the respective testing tracks.  Therefore, it is still imperative to parse commits within a PR for knowing what JIRA tickets to associate with that PR.  It seems overly redundant to then have a developer manually add all associated ticket numbers to the PR title when the information is already there in the included commits.

Thanks for explaining your concern 🙂  I feel there may be a misunderstanding though.

It seems overly redundant to then have a developer manually add all associated ticket numbers to the PR title when the information is already there in the included commits.

I have no interest in changing the way commits are parsed, or PR titles. I am talking only about the PR description.
The problem is, that the matching of Jira ticket numbers within PR descriptions is too aggressive.
It currently matches against any instance of a ticket ID in PR description e.g. TEST-123 and links it in Jira as "development work against this ticket" which is too aggressive, considering it's common to mention other tickets in a PR description. There is no control over this behaviour. I have to not refer to other tickets which are useful when making a PR, to avoid this linking.

Given a PR description like this:
### Current Problem

Following [VS-111], some more issues have been identified with thing.

### Proposed Solution

Fix the thing so that it doesn't do thing.

---

closes [VS-222]
precursor to [VS-333]

I expect:

VS-111 to be a link
VS-222 to associated this PR as development work against this ticket
VS-333 to be a link

I'm not sure what the status of this issue is, but a good workaround I've found is to put your other ticket references in a PR comment instead of the description. Those don't get picked up either

I would also love this. At organizations I have worked at recently it is common practice to link follow-up or related tickets in the PR description as additional context. Relying only on the title/branch/commit message worked well for us so having the ability to toggle back to the previous behavior would be fantastic. Alternatively more sophisticated keyword based control would be interesting but I'd be happy with the previous behavior as a configuration option.

I would even say that it is dangerous. We found our-self in a situation that a follow up ticket that was mentioned in the PR description was automatically merged and we only got it done, cause we remembered that it was important. But it means that automation failed us on very-very quietly.
This might hurt badyl trust in JIRA automation (like in our case).

Bump. Tickets are unexpectedly being marked as done and merged when they are:

mentioned in the description of the merged PR
written as "ticket 2237" (ie, not using the {projectName}-{ID} pattern)
and hyperlinked to the Jira ticket

This is problematic because the work hasn't begun yet and it will get lost.

I would propose the following solution.

For any keys prefixed with an exclamation mark, ignore them. That would allow !TEST-12 to not automatically link to the Jira issue.
Similarly, [!TEST-12] could be replaced with something like [!TEST‐12](https://instance-domain/browse/TEST-012)

The dash in the link label is U+2010 to avoid matching.
The leading zero on in URL's number portion of the key also avoids matching, but should correctly redirect (at least for the Cloud version).

In lieu of such a feature being added to this Jira App, one can use a regexp find-and-replace when the PR description/title are edited. Something like this regexp and replace should work.
Pattern:
/\[!([\p{L}][\p{L}\p{Nd}_]{1,255})-(\p{Nd}{1,255})\](?!\()/giu

Result:
[!$1‐$2](https://instance-domain/browse/$1-0$2)
    ^ This is U+2010

This is also catching us out - tickets are getting incorrectly closed because someones mentions them in a PR description. 😢

Absurd that this is still not resolved. Just give us the ability to set patterns to match on.


Missing the data of one province and two regions of China

Referring to ISO 3166-2:CN , Taiwan, Hong Kong and Macao are parts of China.
This pull request supplements the geojson data and document.

Coverage remained the same at 70.757% when pulling b6637cab9c3ea5beab383dfda8ce6b46eb25e47c on roganw:fix_missing_region into e121a8585e753e0e659f52da2bec6b5bc7f79444 on apache:master.

Coverage remained the same at 70.757% when pulling b6637cab9c3ea5beab383dfda8ce6b46eb25e47c on roganw:fix_missing_region into e121a8585e753e0e659f52da2bec6b5bc7f79444 on apache:master.


CLI: add input parameters for point matching and features to improve matching

(to match API parameters)

snap to intersection
indicate side of street
accurate matching of dual carriageways (+ bidirectionality)
Bearing tolerance
Search radius


Can you add TextAlign in ToastConfig ?

I want my toast in center screen. So i must download your source and modify it. Can you add TextAlign in ToastConfig ?

I don’t understand what you’re giving me here.  This is a PR of my v6.6 branch.  There is no commits from you to merge!?


PyInstaller compatibility

To support freezing apps with wgpu-py, we need to take a couple of things into account:

PyInstaller can't see dynamic imports, so static imports of specific backends are required; otherwise nested dependencies are not included in the frozen app. See https://github.com/almarklein/wgpu-py/pull/18#issuecomment-569410315 for the original discussion.
Our package data (wgpu/resources folder) won't be included automatically either, unless we submit a hook to the pyinstaller repo or users write their own, containing a call to collect_data_files('wgpu.resources'). See https://github.com/pyinstaller/pyinstaller/blob/develop/PyInstaller/hooks/hook-certifi.py for an example

Progress:

[x] Implement the new hook system in wgpu-py
[x] Test it in CI using the PR branch of PyInstaller
[x] Make a release of wgpu-py so PyInstaller can use it in their tests.
[x] PyInstaller branch merged (https://github.com/pyinstaller/pyinstaller/pull/4582)
[ ] PyInstaller 4 release
[ ] Update wgpu-py dev requirments to use pyinstaller>=4 instead of the branch

Submitting a hook that simply ads the whole resourced dir should be easy enough. Let's get to that once we have a release that includes binaries.

Created the hook here: https://github.com/Korijn/pyinstaller/commit/c4f43a07516c3b45083ed0eab28a999ee23f7de8
Still need to test and verify it works

Updated first comment to keep track of progress.

@Korijn @almarklein the branch has been merged in. The new hook-api is "live" in development. 4.0 should be released before lockdown is over (So should 4.1 for that matter).

@Korijn @almarklein the branch has been merged in. The new hook-api is "live" in development. 4.0 should be released before lockdown is over (So should 4.1 for that matter).

Thanks for the heads up! I've updated the first comment accordingly.

I just realized this has probably gone to production a while ago. We can test and close this :)


Update README.md

Add a snippet to the install section that adds "atob()" to the global namespace on node <16.
Should close #59 and close #57.

Thank you 🙏
I’ll update website too.


typedef: split "callback-parameter" from "parameter"

There should be an option to split callback parameter from parameter typedef. One of the reasons for this is that type inference can flow the other way in Typescript, for example in the following code:
let a = document.createElement('a');
a.addEventListener('click', (event) => {
  // something
});

the type of event can be inferred as MouseEvent by the compiler, however given the current typedef: parameter option, user would be forced to put something there, which usually is Event. Event is worse than what could be inferred.
This also occurs for the following:
let p = new Promise(function(resolve, reject){
  // do something
});

Both resolve and reject would be inferences by the compiler. However with typedef: parameter, user could be easy overwriting with something that's worse, such as Function

In this proposal, do you want the "parameter" option to only apply to named functions then? And prefer type inference for anonymous functions?
This sounds similar to #669 and my general advice would be to try the --noImplicitAny compiler option rather than the typedef rule if you want to leverage type inference. But i'll leave this issue open for further discussion.

That would only work for new code, not copy and pasted code.
Not sure if it is possible to look at all callbacks with dual declarations and see if one side is better than the other. If it is heuristically display it.

Display if the better definition is from .d.ts
Display if the better definition is in user's code somewhere else
Don't display if better code in user's code, and user is calling .d.td

+1 typescript is smart enough to infer the types but tslint keep warning me missing typedef, especially callbacks.
It would be great to split them.

@erictsangx is your use of the typedef rule also for legacy code that has been copied over to TS as @leonyu mentioned above? I'm trying to understand the motivation for using the rule. I generally don't think it's useful since the compiler does a lot of inference work for you and noImplicitAny forces typedefs everywhere else.

@adidahiya Do you mean the motivation for typedef in general or for a callback-parameter option? There are a few reasons I see for the rule:
// what in the world is myVar???
let myVar = mysteriousObj.mysteriousFunc();
// ah, it's a spaceship!
let myVar: Spaceship = mysteriousObj.mysteriousFunc();

// all good, right?
function doubleExp(a: number, b: number, c: number): number {
  let step1 = a ** b;
  let step2 = b ** c;
}
// ah, compiler error because we don't return a number!
// w/o the typedef, we wouldn't have caught this

@JKillian I guess it's a stylistic choice then. Personally I wouldn't want to require a typedef in either of those cases.

mysteriousFunc would have a better name in a real codebase, and same goes for myVar. At least one of those should indicate that you're getting a spaceship, so I would find the : Spaceship redundant.
Call sites for doubleExp would infer that it returns void, so the compiler would complain if you tried to use the result as a number. Without static analysis of the whole program, yeah we'd be forced to be very explicit about all typedefs, but I prefer to have the compiler do most of the work.

@JKillian
let myVar = mysteriousObj.mysteriousFunc();

The type annotation is not required in order to know the type of myVar; I think your example is suggesting this rule is useful in order to be clear to the reader what the type is. However you can easily use your editor/whatever to get the information about what type the compiler has inferred for myVar via TypeScript services. E.g. in Neovim I have this bound to \-h - this shows me the type of the 'thing' at the cursor position. Hovering over the 'thing' in Atom shows it as a tooltip.
For what it's worth, our configuration is as follows:
// tsconfig.json

...
  noImplicitAny: true
  noImplicitReturns: true
...

// tslint.json

...
    "typedef": [
      true,
      "call-signature"
    ]
...

This forces us to be explicit about return types. Reason this is useful:
function Test() {
    // complicated implementation...
    // many lines.....
    return 5;
}

We intended this function to be void... but as part of some refactoring somebody made it return a value. Being forced to be explicit about return types forces the signature to drive the implementation.
Although I note (how we missed this before I'm not sure) that the typedef rule does not seem to apply to arrow functions... which is a bug:
let x = (y: number) => 5; // no error: BUG
let z = function(y: number) { return 5; }; // tslint error: expected call-signature to have a typedef

In this regard I think the typedef rule could be amended for the call-signature option to only require a call signature if it can't be inferred from usage. That would still mean both of the examples above are errors, but if either a function or arrow function were used as an argument (and hence be constrained by the type of the signature of that function/method) then the return type would be optional.
Part of me thinks this would require #680... another part thinks possibly not?

An example:
function fn(cb:(date:Date)=>void):void {
    cb(new Date);
}

fn((problemHere)=> {
    console.log(problemHere.getDate());
});

Typescript understands problemHere  is  a Date, thus it allows calling getDate.
However, tslint warns problemHere should has a typedef if I enable typedef parameter.
I can see typescript has its own type checking and it is good at type inference. So I would rather leave it to the compiler and use tslint to check my code style.

@adidahiya @myitcv Yes, with the variable example I was suggesting it for readability as opposed to functionality. Agreed that code naming conventions / a good IDE alleviate the need for this most of the time, however, if you're just visually scanning code I could see it being useful from time to time. Either way though, just a matter of personal preference for most devs, and in general it's probably unneeded. I think case 2), with function return types makes more of a functional difference.
@erictsangx Thanks for the example, that's a reasonable thing to want. I think what might work best for you is to turn off the parameter option and enable the noImplicitAny compiler option.

☠ TSLint's time has come! ☠
TSLint is no longer accepting most feature requests per #4534. See typescript-eslint.io for the new, shiny way to lint your TypeScript code with ESLint. ✨
It was a pleasure open sourcing with you all!

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


jsx-max-props-per-line, maximum param, object style

Hello everyone!
I have some problem with this rule jsx-max-props-per-line
It says that i can use it like "react/jsx-max-props-per-line": [2, { maximum: { single: 3, multi: 1 } }]
but my eslint config says that maximum should be integer, not object.
Explain me please why docs example does not work in my case? The same situation happens in VS code.
My main goal is : according to my style guide if > 3 props/attributes per line in jsx it should be soft-wrapped to new line and become multiline with 1 attr/props per line. Maybe anyone know some?
my logs:
Problem with ESLint reformatting:
.eslintrc.js:
Error: .eslintrc.js: Configuration for rule "react/jsx-max-props-per-line" is invalid:
Value {"single":3,"multi":1} should be integer.
Error: .eslintrc.js: Configuration for rule "react/jsx-max-props-per-line" is invalid:
Value {"single":3,"multi":1} should be integer.

at ConfigValidator.validateRuleOptions (C:\projects\web\node_modules@eslint\eslintrc\lib\shared\config-validator.js:144:23)
at C:\projects\web-ufs\node_modules@eslint\eslintrc\lib\shared\config-validator.js:199:18 at Array.forEach ( ) at ConfigValidator.validateRules (C:\projects\web\node_modules@eslint\eslintrc\lib\shared\config-validator.js:196:34)
at ConfigValidator.validateConfigArray (C:\projects\web\node_modules@eslint\eslintrc\lib\shared\config-validator.js:322:18)
at CascadingConfigArrayFactory._finalizeConfigArray (C:\projects\web\node_modules@eslint\eslintrc\lib\cascading-config-array-factory.js:493:23)
at CascadingConfigArrayFactory.getConfigArrayForFile (C:\projects\web\node_modules@eslint\eslintrc\lib\cascading-config-array-factory.js:299:21)
at CLIEngine.isPathIgnored (C:\projects\web\node_modules\eslint\lib\cli-engine\cli-engine.js:973:18)
at ESLintPlugin.invokeESLint (C:\Program Files\JetBrains\WebStorm 2020.2.3\plugins\JavaScriptLanguage\languageService\eslint\bin\eslint-plugin.js:100 :23)
at ESLintPlugin.fixErrors (C:\Program Files\JetBrains\WebStorm 2020.2.3\plugins\JavaScriptLanguage\languageService\eslint\bin\eslint-plugin.js:81:21)

What version of eslint-plugin-react do you have? The object form of the config was added in v7.26.0 (and we're up to v7.27.0 now)

What version of eslint-plugin-react do you have? The object form of the config was added in v7.26.0 (and we're up to v7.27.0 now)

Hello! Thanks for feedback.
My config is:
"eslint": "7.32.0",
"eslint-config-airbnb-typescript": "12.3.1",
"eslint-config-prettier": "8.3.0",
"eslint-import-resolver-webpack": "0.13.0",
"eslint-plugin-import": "2.22.1",
"eslint-plugin-jest": "24.3.6",
"eslint-plugin-jsx-a11y": "6.4.1",
"eslint-plugin-prettier": "3.4.0",
"eslint-plugin-react": "7.23.2",
"eslint-plugin-react-hooks": "4.2.0",
"prettier": "2.4.1",
Now i see, my version is v7.23.2. So i can just upgrade my eslint-plugin-react and everything will work?

I'd start with that - and also, use ^ for everything. Pinning versions in package.json is useless (and harmful), since lockfiles exist.

I'd start with that - and also, use ^ for everything. Pinning versions in package.json is useless (and harmful), since lockfiles exist.

Thank you very much! Now it is working correct! =)
But my config contradicts itself - more than 3 props in a row cannot be (and it linted now), but when saving, prettier transfers everything to one line (as max line length is 140).

Indeed, prettier conflicts with a number of eslint rules. You need to extend the prettier shared config, as well, so conflicting rules are disabled.

Thanks a lot for your answers! It was helpful!
I suspect that it will only be possible to find out at random?) I mean what rules can be conflicting with each other.

That's why the prettier config exists - someone manually audited every rule and collected them into one shared config that disables them all.


Unable to get the parsed tree data when statement is incomplete

Generated parser:
kestrelParser.zip
Code
function handle_errors(e) { return true; }

  try {
    treeData = parser.parse("proc2 =", null, handle_errors).children[0];
  } catch (e) {
    console.debug("uncaught error:", e)
  }

Expected: can get treeData after parsing even if the statement is incomplete.

Well, before parsing is complete, there is no single tree, but several fragments of trees.
You can find them in the instance of the parser state, ParserState.value_stack (https://github.com/lark-parser/lark/blob/master/lark/parsers/lalr_parser.py#L92).
If you have an idea on how to make an API out of that, let me know.

Ok, I got it. I'll get the data from ParserState.value_stack. Thanks!

Happy to help.


[SWA-226] Fix detailed rejection emails with rejection reason are not being sent

What is the problem?
Convection has several templates for rejection emails that each correspond to a reason for which a submission can be rejected (artist submission, fake artwork, etc.)
In the current manual rejection flow, an email is sent before an admin has a chance to select a rejection reason. As a result, collectors receive the default rejection email template, which does not explain why their submission was rejected.
Why does this matter?
One of our quarterly goals is to improve the NPS (net promoter score) of the Sell with Artsy flow, and user research shows that the shock of being rejected is a contributing factor to that low score.
What is the solution?
When an admin manually rejects a submission, do not immediately schedule the email to be sent.
Send a rejection email when the rejection reason is updated on a submission instead.
What should happen if an admin never selects a rejection reason?
We will update the rejection flow in Convection to show the rejection reasons after “Rejection” is clicked, and only send an email after one of the reasons is selected.
If an admin later updates the rejection reason after the initial rejection, we won’t send an email to the user, but we will update the submission in the database.

The solution we found after some iterations is to replace the current rejection flow with a modal. The modal will prevent us from having a rejected submission without a rejection reason.
https://user-images.githubusercontent.com/554507/153185815-d0510b16-0ec0-4be9-abe0-4867e357f4b2.mov

Looks good! Just a few UI notes:

Can you make popup height the same as content size, I would like to get rid of white space under the save button
Add space between a radio button and a reason label.
Align a reason label in the center (vertically)

Looks good! Just a few UI notes:

Can you make popup height the same as content size, I would like to get rid of white space under the save button
Add space between a radio button and a reason label.
Align a reason label in the center (vertically)
Disable the save button until you select a reason

Thanks for the review, initially I just copy-pasted the same modal we have for offer rejections and didn't want to change much but I pushed some changes to improve both.
reason selection is now required
I opted to have this instead of a logic to control the button state, let me know what do you think.

vertical alignment adjustments

LGTM! But I think you can remove 'Please select one'
https://github.com/artsy/convection/blob/main/app/views/admin/submissions/show.html.erb#L67

Nice catch, thanks! b4a9600


Compile error

I am having a compile error when running truffle compile (latest node, python 2.7, all according to instructions):
Migrations.sol:7:3: Error: Expected token Semicolon got 'RBrace'
➜  app git:(master) truffle compile
Compiling Conference.sol...
Compiling Migrations.sol...
Error compiling:
Migrations.sol:7:3: Error: Expected token Semicolon got 'RBrace'
}
^
Compilation failed. See above.

➤ Andrew Milich commented:
I'm also experiencing this issue in addition to other compilation errors after addressing this.

➤ Archie Norman commented:

1

➤ Canalytic commented:
me too

➤ wukong5 commented:
me to

➤ Adwind commented:
Error compiling:
Migrations.sol:7:3: Error: Expected token Semicolon got 'RBrace'
}
^
Compilation failed. See above.

➤ wukong5 commented:
is there anybody who can solve this,please help

➤ Henry commented:
I'm having the same issue, too.  :/

➤ Shikhar Mahajan commented:
Any updates?

➤ Debadri Dutta commented:
open the migrations.sol file using sublime or any other text editor and put a semicolon after _ inside the if function.
1 ( https://user-images.githubusercontent.com/24243687/32277682-3b06de9e-bf39-11e7-8e46-44ac4283904a.JPG )


Emeritus status and recognition

Contributors to our community have not been publicly recognized in a way that outlives their significant participation. This is problematic because one of the key benefits of being part of this project is its potential to help people move forward in their careers, and that often requires public documentation.
My proposal
This proposal has two elements:

create an emeritus status formalized as participants who have made substantial contributions in a particular area in the past but have stepped away from that line of work. Specifically, people who have been co-authors but have not been part of more recent research efforts since their co-authorship would be given emeritus author status. Alternatively people who have committed to engineering efforts and have not contributed in development since the last publication or milestone would be given emeritus engineering status. Other types of emeritus status would be developed for other types of contribution (e.g., design, governance). Participants with emeritus status would: be listed on our public web presence, be relieved of ongoing responsibilities, and remain active in slack for as long as they prefer. Emeritus status would be automatically issued on a per category basis. The public listing of the status could be optionally withdrawn if the participant so chose. Participants who are emeritus would be able to reengage the community as any other participant if they chose to continue their work with us.
create a page to document community members emeritus status and make it available to the public. In the short term, this could be a list of people put on a static page as part of our web presence. Individuals could ask to be removed if they were uncomfortable with being listed publicly.

To break consensus use this template. You may also install this template to your account by following these instructions.

Duplicates https://github.com/crowdresearch/collective/issues/5


Implement CMS decryption

Implement CMS decryption

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Adding exclusions

Hi!
Is it possible to add the F3+Esc pause screen to exclusions?

If anyone is wondering the same, I found out that it's the net.minecraft.class_433

Hi, is there a way of getting the F3 + Esc pause screen to exclusions but still have the in game menu screen background to blur? Thanks :)


Sonar Cloud Code quality (backend)

Title of ticket:
Description
This covers all things reported on BCGov sonar cloud
https://sonarcloud.io/project/issues?languages=py&resolved=false&sinceLeakPeriod=true&types=CODE_SMELL&id=bcgov_foi-flow
DOD

[ ] make fixes
[ ] Confirm fixes
[ ]
[ ]
[ ]

No of reported issues -> 20

A general sanity is sufficient.

Python reported issues are addressed.

Complete.


feat: immutable data for downstream SFNs & observe data tags at server side

Immutable messaging support sfn concurrent processing
Zipper tags acknowledge (TODO: need to explain the benefits here)

This change is

@chenjunbiao please resolve conflicts, I'll merge it.


How to allow players to give players permission to use certain commands without OPing them

Can you like, execute as console instead?

There is a flag to execute a command in the console.


Fix connection error outside mainland of China

Fix connection error outside mainland of China

see apis/init.py


[AutoPR] hanaonazure/resource-manager

Created to accumulate context: hanaonazure/resource-manager

(message created by the CI based on PR content)

Codecov Report

Merging #4967 into master will decrease coverage by 3.91%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master    #4967      +/-   ##
==========================================
- Coverage   52.71%    48.8%   -3.92%
==========================================
  Files       11020     6609    -4411
  Lines      230773   185137   -45636
==========================================
- Hits       121660    90358   -31302
+ Misses     109113    94779   -14334

Impacted Files
Coverage Δ

...aonazure/azure/mgmt/hanaonazure/models/__init__.py
56.25% <ø> (-43.75%)
:arrow_down:

...hanaonazure/models/hana_management_client_enums.py
100% <ø> (ø)
:arrow_up:

...mgmt-hanaonazure/azure/mgmt/hanaonazure/version.py
100% <100%> (ø)
:arrow_up:

.../mgmt/hanaonazure/models/monitoring_details_py3.py
36.36% <25%> (+3.03%)
:arrow_up:

...afactory/azure/mgmt/datafactory/models/__init__.py
50.67% <0%> (-49.33%)
:arrow_down:

...ights/azure/applicationinsights/models/__init__.py
51% <0%> (-49%)
:arrow_down:

...e/cognitiveservices/vision/face/models/__init__.py
51.08% <0%> (-48.92%)
:arrow_down:

...services/language/textanalytics/models/__init__.py
51.16% <0%> (-48.84%)
:arrow_down:

...iveservices/search/entitysearch/models/__init__.py
51.25% <0%> (-48.75%)
:arrow_down:

azure-eventgrid/azure/eventgrid/models/__init__.py
51.25% <0%> (-48.75%)
:arrow_down:

... and 4518 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd42979...c66aaf9. Read the comment docs.


Common denominator for list of fractions

Feature request: support for creating common denominator for list of fractions.
I need Fraction(4, 4) to return {s: 1, n: 4, d: 4} instead of simplifying it to {s: 1, n: 1, d: 1}.
Also, I need a function that takes a list like:
[
  Fraction(2, 1),
  Fraction(3, 2),
  Fraction(4, 3),
  Fraction(5, 4),
  Fraction(6, 5),
]

and returns:
[
  {s: 1, n: 120, d: 60},
  {s: 1, n:  90, d: 60},
  {s: 1, n:  80, d: 60},
  {s: 1, n:  75, d: 60},
  {s: 1, n:  72, d: 60},
]

That is, the fractions have a common denominator equal to lcm(1,2,3,4,5,6) → 60. The converted list of fractions is easier to compare (just sort on the nominator).

I think this lacks one important thing: Fraction.js always reduces fractions immediately. So scaling by 60/60 scales by 1. But your use-case should be possible with Fraction.js pretty straightforward:
const arr = [
  Fraction(2, 1),
  Fraction(3, 2),
  Fraction(4, 3),
  Fraction(5, 4),
  Fraction(6, 5),
];

const lcm = arr.reduce((a, b) => a.lcm(b), new Fraction(1));

const result = arr.map(x => ({s: 1, n: x.n * lcm.n / x.d, d: lcm.n}));

Which results in exactly your desired output:
[
  {s: 1, n: 120, d: 60},
  {s: 1, n:  90, d: 60},
  {s: 1, n:  80, d: 60},
  {s: 1, n:  75, d: 60},
  {s: 1, n:  72, d: 60},
]

Thanks for your quick, elaborate and helpful reply. Works as advertised.
Yet, the result is a list of Objects rather than Fractions. I’d like to standardize on a single type throughout, preferably Fraction. Perhaps Tone as new type, as an augmented class of Fraction.
What is the rationale for Fraction.js to immediately reduce the fraction? What are the objections against not reducing?
Also, should future versions of Fraction.js add support for these kind of things?

The strongest reason for the immediate reduction is numerical stability. Most problems that arise - also that come up as issue here - are due to overflows, which can occur even with a few simple additions, since you must scale for a common denominator each time. There was an option already present in the past, called Fraction.REDUCE = false, which allowed to turn off the reduction. Ultimately, this feature was removed after causing other internal problems since you have to think through this for every function.
So as Fraction.js deals with ratios the decision was made to always keep the reduced form. I don't know what you're trying to achieve, but what you could do is copying over the internal function newFraction() and use it in a modified form outside the Fraction.js scope like so:
function newFraction(n, d) {

  if (d === 0) {
    throw Fraction['DivisionByZero'];
  }

  var f = Object.create(Fraction.prototype);
  f["s"] = n < 0 ? -1 : 1;

  n = n < 0 ? -n : n;

  f["n"] = n;
  f["d"] = d;
  return f;
}

const lcm = arr.reduce((a, b) => a.lcm(b), new Fraction(1));

const result = arr.map(x => newFraction(x.n * lcm.n / x.d, d: lcm.n));

This keeps the objects in a Fraction.js envelope, but of course does not prevent Fraction.js to reduce the ratio after upcoming operations.

I see. Thanks for pointing that out.
Also thanks for the modification suggestion. I’ll absorb it into my experiment.
Have a nice week.


Change query to get user reviews to avoid github API limitation

Questions
Answers

Description?
Due to a github API limitation when retrieving more than 1000, we change the way we get the user's reviews from github GraphQL API

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes #23

How to test?
Review report results must be correct :D

Possible impacts?
-

Hello @Progi1984 would it be possible please to be a little more detailed when reviewing Pull Requests? 😊  I see your review feedbacks are quite short, sometimes you dont even write a word 😄
From Google's Engineering Practices documentation

How to write code review comments

Be kind.
Explain your reasoning.
Balance giving explicit directions with just pointing out problems and letting the developer decide.
Encourage developers to simplify code or add code comments instead of just explaining the complexity to you.

From Gergely Orosz on Stackoverflow blog

Good code reviews ask open-ended questions instead of making strong or opinionated statements. They offer alternatives and possible workarounds that might work better for the situation without insisting those solutions are the best or only way to proceed. These reviews assume the reviewer might be missing something and ask for clarification instead of correction.

Better code reviews are also empathetic. They know that the person writing the code spent a lot of time and effort on this change. These code reviews are kind and unassuming. They applaud nice solutions and are all-round positive.

I know this is a difficult topic, and it's hard to balance the pressure of all awaiting code reviews versus the time it requires to write longer review, but you told me many times that "quality of the code is not something that is negotiable", so why not apply this mindset to code reviews and consider "quality of code review is not something that is negotiable" ? 😄  👍

Thanks @sowbiba


How to get rid of "__start/" etc. ?

Currently I am using (VS)code under Ubuntu 22.04 LTS with the Pylance extension, when I type the following code:
 for l in range(1, L_max+1):

     rpow = (r0 / r) ** (l + 2)

     if abs(Clm[index]) > vsmall:

         Nlm = FuncNlm(l,0) / r0

         Bsph += rpow * Nlm * np.array([
             Clm[index] * (l+1) * assoc_legendre(l, 0, costheta),
             -Clm[index] * FuncDlm(l, 0, costheta),

in the code editor, the text is shown with several additions like '_start/', '__stop/' and many other variables names which are listed in the function arguments as can be seen on the attached screenshot. I did not find a way to tune Pylance settings in order to get rid of all these unwanted "decorations".  In fact I do not know if these things have a name, therefore I do not find how to fix this.
Any help is more than welcome.
Thanks in adavance

turn this setting off


Support ordered list states in python sdk and fnapi runner

This is a follow-up PR of #30317, where we support ordered list state in java sdk.
Here we implement ordered list state for python sdk. We also add the support of ordered list state into Python FnApi runner for debug and testing purpose.

R: @robertwb @acrites

@robertwb Could you please take another look? Thanks!


Fixed or Comment Out Test

All test are passing now. I'll fix and debug the commented out/ skip tests in a future pull request.
pytest test/quick_tests/ => 370 passed, 1 skipped, 10 warnings

Great, all tests passing now, thanks!

Thanks for doing this! The (commented out) normalizer tests should be correct, but I changed the code a bit and so the results are in a slightly different form, and these results are hard to write by hand...


Regenerate docs in master

This is the first update, for what will be the 0.65 docs
Microsoft Reviewers: Open in CodeFlow

@stmoy @vmoroz FYI
The content has already been reviewed on the code repo since these are coming from the IDLs, let me know if you have any questions/concerns.


Update rochester arch name in result files

ibm-rochester to ibmq-rochester
Also double check correct architecture name used in transpilation code

Context:
ibm_rochester is the architecture defined by pyzx in pyzx.routing.architectures,
while ibmq-rochester is the corresponding platform in metriq.info.

It makes more sense to keep the architecture defined by pyzx as data source in the experiment results, and only convert the string appropriately during post processing, as required metriq API.


Jenkins kubernetes-plugin:v0.10

Filed as #328 but I haven't signed a CLA yet
The latest version of the kubernetes-plugin for Jenkins expects a container named "jnlp" or it will create one for you.  This is bad because it results in your jobs sometimes running against the wrong container.  Not sure how it chooses or what was intended by this change.
This version of the plugin is not installed by the chart (still on v0.8 as of the last chart update) but you still wind up with this version installed if you follow the auto-upgrade prompts presented by Jenkins admin console.  I rebuilt the master-image for myself and upgraded that way instead.
Confusingly, setting the name of the PodTemplate in values.yaml also sets the name of the container.  Not sure what a PodTemplate with multiple containers or separate jnlp container would look like.  I like the idea of separating the JNLP service, but I'm not sure putting it in a separate container is the best way.
Docker Slaves plugin uses Compose in an interesting way to accomplish what I assume is the same goal... but I digress!  This appears to be a breaking change coming down the pipe, heads-up.

Just read over #315, looks like exactly the hero we need
I will clone that and give it a try.

Looks like we are all set


enhance: Adds support to generate CSVs in MacOS

This commit adds support to generate CSVs in Darwin environments. Sed command in Linux accepts different arguments for inplace replacement than Darwin's which makes existing generation scripts incompatible with Darwin environments.
Signed-off-by: Ashish Ranjan<EMAIL_ADDRESS>

/lgtm


Fix case where a specific controller handedness is set but only non-handed interactions exist

Overview
In many cases, handed interactions are overridden to point to the default interactions in classes that don't need different one:
https://github.com/microsoft/MixedRealityToolkit-Unity/blob/ec3ae303cf832bc532edb57083b7edd96eaeb075/Assets/MRTK/Providers/WindowsMixedReality/XR2018/Controllers/BaseWindowsMixedRealitySource.cs#L27-L31
However, this isn't a requirement that we've previously enforced. So, this PR updates the code to double check that the handed interactions aren't null before using them. If they're null, the non-handed default interactions are used.
Changes

Fixes: https://github.com/microsoft/MixedRealityToolkit-Unity/issues/7528

/azp run

:shipit:


GetProductTickerAsync productType=XrpUsd

Hello!
When Call GetProductTickerAsync with XrpUsd
threw exception: CoinbasePro.Exceptions.CoinbaseProHttpException: NotFound
GDAX.Api.ClientLibrary Version=1.0.44
Thanks!

hey! @gggustavo. XRP was suspended as of today (January 19, 2021). You can read more about it here: https://blog.coinbase.com/coinbase-will-suspend-trading-in-xrp-on-january-19-2e09652dbf57

hey! @gggustavo. XRP was suspended as of today (January 19, 2021). You can read more about it here: https://blog.coinbase.com/coinbase-will-suspend-trading-in-xrp-on-january-19-2e09652dbf57

Thanks @dougdellolio

Thanks @dougdellolio


The console window displays garbled characters when type

Description
When type "dotnet --info" in console window, it displays garbled characters in the output information. My computer language is Japanese.
Configuration
You can find my configuration in the attachment

Duplicate of #6614


error when exporting

Downloaded a release and tried to run ./jsonconsul export -json-values -prefix="helios"
panic: interface conversion: interface is string, not map[string]interface {}

goroutine 1 [running]:
github.com/vsco/jsonconsul.consulToNestedMap(0x0, 0x0, 0xc20804a101, 0xc20803cae0, 0x0, 0x0)
	/Users/abhi/Dropbox/projects/gostuff/src/github.com/vsco/jsonconsul/consul.go:64 +0x747
github.com/vsco/jsonconsul.(*JsonExport).GenerateJson(0xc2080440f0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/Users/abhi/Dropbox/projects/gostuff/src/github.com/vsco/jsonconsul/export.go:107 +0x8d
github.com/vsco/jsonconsul.(*JsonExport).Run(0xc2080440f0, 0x0, 0x0)
	/Users/abhi/Dropbox/projects/gostuff/src/github.com/vsco/jsonconsul/export.go:128 +0x4b
main.main()
	/Users/abhi/Dropbox/projects/gostuff/src/github.com/vsco/jsonconsul/cmd/main.go:42 +0x1b0

goroutine 7 [runnable]:
net/http.(*persistConn).readLoop(0xc20806e0b0)
	/Users/abhi/vsco/tools/vendor/go/1.4.2/src/net/http/transport.go:928 +0x9ce
created by net/http.(*Transport).dialConn
	/Users/abhi/vsco/tools/vendor/go/1.4.2/src/net/http/transport.go:660 +0xc9f

goroutine 8 [select]:
net/http.(*persistConn).writeLoop(0xc20806e0b0)
	/Users/abhi/vsco/tools/vendor/go/1.4.2/src/net/http/transport.go:945 +0x41d
created by net/http.(*Transport).dialConn
	/Users/abhi/vsco/tools/vendor/go/1.4.2/src/net/http/transport.go:661 +0xcbc

Thanks for the report @davidneudorfer!
Working on a repro case. Could you supply us with a sample of your key names with the slashes? It looks like you may have a nested keyspace that may be causing the problem.


Remove Omnibus

Chef Infra client is effectively EOL, and Omnibus development seems all but abandoned.
This work should be completed in two phases to minimize disruption to existing Omnibus-based Firezone users:
Phase 1

[x] Improve docs around migrating to Docker
[x] Add deprecation notice to the postinst script for Omnibus-based users to be warned of the deprecation

Phase 2

[x] Remove omnibus/ build dir and related files/dirs
[x] Remove CI pipeline build/publish
[ ] Shut down self-hosted runners
[ ] Cloudsmith EDIT: Keep the Cloudsmith packages published for existing instances to use

Any plans to use the Open Build service? I mean having native packages may help the users.

@mzs114 Unfortunately there's a prohibitive amount of work involved in replacing Omnibus and omnibus-ctl with OBS and documenting and maintaining native packages going forward. Docker simplifies building, distributing, and maintaining the Firezone web service substantially for us, freeing up resources to improve Firezone.
See our build from source documentation for instructions on building the Firezone portal itself if you'd like to build from source. Configuration can then be done via environment variables.

This has been mostly complete in the cloud branch.


Added Example for Minimal API Implementation using MemoryServerless Client

Motivation and Context (Why the change? What's the scenario?)

Implementation for .NET Core Minimal Api as a sample
Sample can be leveraged for ingestion of documents and asking questions to the same as an API integration (for apps which do not want to deploy the Memory Service but want to leverage API for integration)

High level description (Approach, Design)

Implementation of document ingestion and query using MemoryServerless Client
Exposes endpoint for ingestion of multiple files in a document
Exposes endpoint for querying the ingested data
Example can be leveraged by users who need to leverage an api integration to interact with KernelMemory without deploying the MemoryService

@dluc, Hope you are doing good !! Can you please help in reviewing this PR? Please let me know in case you have any suggestions would be happy to contribute here

@SwagataChaudhuri thanks for the PR. I was wondering, should we extend the existing minimal API adding those extra features like CORS? I'm not sure about having an example of a web API when the repo includes and existing web API, considering that we offer also a web client, and both provides the same entire memory API, vs a new endpoint. What do you think?

@dluc , completely agree with you but a small concern I see with web service is that since that needs to be run from the source as of now and I thought of creating a sample using the kernel memory package so that developers can look up to that as a sample and can create their own.

@dluc , completely agree with you but a small concern I see with web service is that since that needs to be run from the source as of now and I thought of creating a sample using the kernel memory package so that developers can look up to that as a sample and can create their own.

that's correct, though we're about to change that, the Service project will be using the packages like other apps. So in essence, one still needs to download the Service code to run it (like one would download the example here) but everything else will come via nuget.
My main concern though, is that the Service project has a minimal API designed so that one doesn't have to write any custom HTTP client, leveraging https://www.nuget.org/packages/Microsoft.KernelMemory.WebClient, which has the same methods of the Serverless memory, for instance:
// Instantiate HTTP client talking to KM service
var memory = new MemoryWebClient("http://<IP_ADDRESS>:9001/", "secret api key");

await memory.ImportDocumentAsync("file1.pdf");

This might add to a duplicate then, let me close this PR


initial kuttl setup for KUDO Kafka MWT

This PR adds initial setup of MWT using KUTTL

updated the README.md of the mwt directory as it was missing what we actually are trying to achieve with this automation


How do I upgrade the version of WinObjC used with a project?

If I used 0.1 to convert my project earlier, can I delete the 0.1 folder and put 0.2 in its place and use the newer version of the bridge without issue?

In general, yes.
Please be sure to look at the [breaking change] (https://github.com/Microsoft/WinObjC/issues?q=is%3Aissue+"BREAKING+CHANGE"+is%3Aclosed) announcements first to see if there are any that will impact you.
Re-run vs-importer and port over any changes you made after running vsimporter last time.
Please open issues if you run into anything.


Support Prefork Python Server Model

#10155 Is the bulk of the work

This is still happening on grpc-python 1.8.4

Closing this in favor of https://github.com/grpc/grpc/issues/15334, which is mainly tracking client-side fork support but should also be used to discuss server-side use cases.


Strip content of regexes from path before sorting

When a regex contains a question mark (for instance, for an optional parameter, a negative lookahead, or a non-capturing group), the children of the route are not correctly sorted anymore, because they're cut off at the first question mark. This change removes the content of the regex before sorting.
Additionally, I've changed the test command to ensure it runs on Windows as well.

Great find, going to merge and release. I'll probably re-visit the sorting solution at some point so that the number of segments comes from path-parser. But will do for now 👍


RFC: Supporting include statement.

Motivation
When writing tests for complex queries, we need to prepare data before executing queries. The most general approach is to execute insert into statements. However, mixing a lot of insert statements with queries in one file may lead to a large file which is difficult to maintain and understand.
Proposal
A good practice is to split these statements into small files and use include statements to merge them together. For example, tpch e2e tests may  consist of several files: one file for creating tables, one file for each table's data, and one file for all queries, and eventually we use include command to concat them together.
include "create.slt"
include "insert_nation.slt"
include "insert_lineitem.slt"

query R
select * from lineitem;

This is not a feature of original sqllogtest, but it’s really useful, so +1 for this.
I prefer to use “source” instead of “include”.

Resolved in https://github.com/singularity-data/sqllogictest-rs/pull/8


How can i send message to other devices connected with the same socket?

Hello Guys,
This code is working very fine for me, even all android devices also connecting with the socket.
Now i want to send messages to other devices connected with the socket as me.
And also want to send message to individual also.
Can anybody suggest me anything?

The WebSocketUser object is used to keep track of different connections.
In the send() method, you need to specify the WebSocketUser (or a class that inherits from WebSocketUser (in future versions, a class that implements the WebSocketUser interface)) of the connection that you want to send the message to.
Closing because this is not a bug, it is a support request.  If you still need additional support, please feel free to reply to this despite it being closed.

Thanks @ghedipunk


Improve robustness of test_runner

Ensure that intr_test for Status-type interrupts is cleared after using it within PlicTest, because otherwise subsequent tests may fail.
Helps test_runner run multiple times without an intervening system-global reset, and better supports test reordering.

I've pushed a second commit, having tracked down and resolved the continuously-asserted interrupt that occurs with repeated downloads/runs of the test_runner program without intervening IP block reset. This will also permit tests to be executed after the plic_tests function.


Vendor swarmkit caa9c95

Vendor a new swarmkit for 1.13.2
This brings in one fix: https://github.com/docker/swarmkit/pull/1835
It addresses #29730 for 1.13.2.
cc @thaJeztah @yongtang

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "vendor-swarmkit-caa9c95" git@github.com:aaronlehmann/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Updated the vendoring to include a second fix.

There are two Jenkins failures on Windows.
The first is related to #30890 and should have been fixed in #30893
02:04:41 ----------------------------------------------------------------------
02:04:41 FAIL: docker_cli_build_test.go:533: DockerSuite.TestBuildLastModified
02:04:41
02:04:41 docker_cli_build_test.go:555:
02:04:41     out, _ = dockerCmd(c, "run", name, "ls", "-le", "/file")
02:04:41 docker_utils.go:505:
02:04:41     c.Assert(result, icmd.Matches, icmd.Success)
...
...

The second failure seems to be caused by network failure:
 FAIL: docker_cli_build_test.go:4585: DockerSuite.TestBuildNotVerboseFailureWithNonExistImage
02:05:09
02:05:09 docker_cli_build_test.go:4598:
02:05:09     c.Fatal(fmt.Errorf("Test[%s] expected that quiet stderr and verbose stdout are equal; quiet [%v], verbose [%v]", testName, qstderr, vstdout+vstderr))
02:05:09 ... Error: Test[quiet_build_not_exists_image] expected that quiet stderr and verbose stdout are equal; quiet [Sending build context to Docker daemon 2.048 kB

02:05:09 Step 1/1 : FROM busybox11
02:05:09 Get https://registry-1.docker.io/v2/: dial tcp: lookup registry-1.docker.io: getaddrinfow: No such host is known.
02:05:09 ], verbose [Sending build context to Docker daemon 2.048 kB

02:05:09 Step 1/1 : FROM busybox11
02:05:09 repository busybox11 not found: does not exist or no pull access
02:05:09 ]
02:05:09

the lastmodified error can be ignored; fix for the 1.13.x branch is included in https://github.com/docker/docker/issues/31140

LGTM


notif settings screen: Always show server-push-setup-banner if it applies

In addition to the dismissable banner on the home screen that we started showing in #5090.
Related: #1507

Thanks for the review! Merged.


Support for multiple data types within a relationship

Let's imagine that I had a relationship which could contain multiple types of data. For instance, consider the following example:
"choices": {
       "links": {
         "self": "/api/orders/42/relationships/choices",
         "related": "/api/orders/42/choices"
       },
       "data": [
         {
           "type": "recipes",
           "id": "1"
         },
         {
           "type": "wines",
           "id": "2"
         },
         {
           "type": "recipes",
           "id": "3"
         },
         {
           "type": "wines",
           "id": "4"
         },
         {
           "type": "recipes",
           "id": "5"
         },
         {
           "type": "wines",
           "id": "6"
         }
       ]
}

If all of these were Recipes, I could represent this in Java with HasMany choices. But since they're mixed, is the only way to handle this HasMany and cast check? Or is there a more graceful way to support this use case?

As far as I know, there is no way but to cast every Resource you get from a HasMany<Resource> instance in Java.
But you can workaround that in specific cases. For example, have Choice class extends Resource and Wine and Recipe extends Choice. Then, perform some OOP magic in Choice.


Question Regarding Azure Arc

[Is there a way for a user to download updates to an intermediate location and apply them manually as opposed to allowing Azure access to their endpoint?  I am working with a customer that his highly restrictive security policies that prevent direct Azure ARC to server connection]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6c0c36de-1d68-dad7-3218-d3e33fb8145b
Version Independent ID: 32a28486-8028-b727-c742-437f6505e720
Content: Azure Arc overview - Azure Arc
Content Source: articles/azure-arc/overview.md
Service: azure-arc
GitHub Login: @JnHs
Microsoft Alias: jenhayes

@TreyJonesBBAtHoc
Thanks for your feedback! We will investigate and update as appropriate.

reassign:johnmarco

Hey @TreyJonesBBAtHoc -- can you clarify, is focus of the question just the update content for servers or also the connection between the Arc agent and Azure?

Hi @TreyJonesBBAtHoc - as we haven't heard back so that we can better understand your question, we're going to close this issue now. If you do still have questions about this please let us know.
#please-close


Suspending ColorPicker's process rapidly causes a PC to become unusable.

ℹ Computer information

PowerToys version: 0.21.1
PowerToy Utility: ColorPicker
Running PowerToys as Admin: No
Windows build number: 2004, Build 19041.450

📝 Provide detailed reproduction steps (if any)

Run Powertoys
Wait ~1 second
Suspend the process of ColorPicker using Resource Monitor or PsSuspend

✔ Expected result
Windows continues as normal
❌ Actual result
Input text seems to becomes buffered and is written out at an extremely slow rate that makes a computer unusable.
📷 Screenshots
I'll attach a video here in a bit

And this is a prime example of why #142 has to be carefully implemented if it ever becomes a powertoy

Thanks for reporting the issue, however, you're doing an unsupported scenario and PT can't control what others processes do via admin tooling.  Win32 does not directly support suspending and PT is a Win32 process.  Since the framework doesn't directly support suspending directly, depending on when the process was suspended, tons of different code paths could be affected.

admin tooling.
Just to verify, the process can be suspended without admin rights and even automatically by Windows and Antivirus programs. The simplest fix for this would be to have powertoys executable itself occasionally check module process state. If Powertoys becomes packaged as a UWP app this issue might occur to those users and cause major issues, I'm not UWP expert though.

https://docs.microsoft.com/en-us/windows/uwp/launch-resume/app-lifecycle


Free gas network: upfront cost exceeds account balance

Description
I want to deploy a smart contract in a free gas private network with Besu's latest stable version (23.7.1). Besu answers Upfront cost exceeds account balance error.
Acceptance Criteria

The private network uses London fork or later (I can deploy it if I modify the genesis file to use a previous fork)
The balance of the account used to deploy a contract has a balance of zero
The smart contract is successfully deployed

Steps to Reproduce (Bug)
I've found this error with many configurations (IBFT2, QBFT, different Besu versions), but here I'll describe the simplest way to reproduce it:

Create a free gas network using Quorum-dev-quickstart: npx quorum-dev-quickstart@latest --clientType besu --orchestrate false --quorumKeyManager false --privacy false --monitoring none --blockscout false
Edit .env file to use BESU_VERSION=23.7.1.
(Optional, doesn't make a difference) Adjust the block size and contract size in the genesis file.
Run the network: docker compose up -d
Deploy a smart contract. To test it, you can use a sample Truffle project as suggested in the SC info section.

Expected behavior: Get information about the deployed contracts and their addresses.
Actual behavior: Truffle returns the following error: Upfront cost exceeds account balance.
Frequency: Always
Logs (if a bug)
I haven't identify any relevant logs in Besu.
In the current quorum-dev-quickstart Besu version (23.4.1) I saw this error, but it is apparently fixed.
Versions

Software version: 23.7.1

Smart contract information
I've seen the error deploying many different smart contracts, but you could use this one to test it:

Solidity version: ^0.8.13
Repo with minimal set of deployable/reproducible contract code: Metacoin.

Configuration:

Install dotenv and HDWalletProvider.
Uncomment the two related lines in truffle-config.js
Create a .env file with a property called DEPLOYER_MNEMONIC and a random mnemonic.
Add the following network to  truffle-config.js (with the recommended configuration guidelines or not, it doesn't make a difference).
Run  npx truffle migrate --network local

    local: {
      provider: () =>
        new HDWalletProvider({
          mnemonic: process.env.DEPLOYER_MNEMONIC,
          providerOrUrl: "http://localhost:8545", // "https://node1.ethereum.bclab.dev"
        }),
      network_id: "*",
    },

@gomezgoiri Can you share the actual genesis file that is being used please?
I suspect it's not got the "zeroBaseFee": true config, see https://besu.hyperledger.org/stable/private-networks/how-to/configure/free-gas#4-enable-zero-base-fee-if-using-london-fork-or-later
Note, the latest version of quickstart should have it already: https://github.com/Consensys/quorum-dev-quickstart/blob/master/files/besu/config/besu/QBFTgenesis.json#L14-L17

I haven't changed the genesis file.
By default, it takes the default genesis file you commented.
Anyway, if you change BESU_CONS_ALGO to IBFT it will use this one instead, with the same result.
So I'd say that either default genesis files in quorum-dev-quickstart are not ok, or the problem lies somewhere else.

Hi @gomezgoiri I've got an example of doing this as well as extending the contract for use in a DApp.
On version 0.2.3 of the quickstart look up the dapps/quorumToken folder. Docs here https://besu.hyperledger.org/development/private-networks/tutorials/quickstart#smart-contract-and-dapp-usage
Also would recommend using hardhat instead of truffle

Hi @joshuafernandes , thanks for the reference.
So far I've been using Truffle without problems with other versions of Besu (actually, even with the current one if london fork is not used in the genesis file), but I'll consider to migrate to hardhat if it is the only way to avoid issue I described above.

So far I've been using Truffle without problems with other versions of Besu (actually, even with the current one if london fork is not added to the genesis file), but I'll consider to migrate to hardhat if it is the only way to avoid issue I described above.

@gomezgoiri Could you share the exact scripts/commands that are failing with truffle please so we can try to recreate? I believe the only issues we've seen so far have been with quickstart config/docs or the smart contract scripts. It is not clear there is an issue with Besu itself yet.

Could you share the exact scripts/commands that are failing with truffle please so we can try to recreate?

Maybe you already did in the description, in which case ignore this :)
@joshuafernandes can confirm but there might be an issue with the quickstart scripts when using solc 0.8+

@gomezgoiri Could you share the exact scripts/commands that are failing with truffle please so we can try to recreate?

As you said, I'd already shared the steps to reproduce it.
Anyway, I've recreated and uploaded the sample Truffle project for your convenience  here.
For comparison, I've also added the Hardhat configuration to the project. Hardhat does allow to deploy the contract.

BTW, I'm also experimenting with Polygon Supernet over the same Besu gas zero network and I've experienced this Upfront cost exceeds account balance error too.
I was trying to send a transaction signed by an account with zero balance (note that rootchain fund sends a custom ERC20 token, not the native coin):
polygon-edge rootchain fund --private-key [priv-key-account-with-zero-balance]
99 --json-rpc http://<IP_ADDRESS>:8545 --addresses 0x77C1eedFf656477462ce16084fE5Dc7F8a2507B9 --amounts 1000 --
stake-token 0x67311C86194748CBb1F4f0d69E684Ab7FeE9C62E --mint

This new scenario is more complex for me to explain, but what I want to suggest is that this error might be affecting more tools than Truffle (in this case, polygon-edge).

Hi @gomezgoiri
Thanks for this, this is a really good data point to start off with. Could you confirm that you can deploy, read & write with hardhat? Also looks like you're using the latest solc 0.8.20 and hardhat is fine - this is consistent with what I've been seeing as well.
With truffle & web3 deploys appear to be on quite working right at the moment and we'll use your repo to look into things.
Cheers
Josh

Anyway, I've recreated and uploaded the sample Truffle project for your convenience here.

@gomezgoiri Thanks for this, very helpful! I was able to recreate, think I know what's going on...
Attaching a couple of logs showing the RPC requests that are sent to besu by truffle and hardhat respectively.
besu-with-truffle.log
besu-with-hardhat.log
Both call eth_estimateGas which I would expect to be non-zero since free gas networks still use gas, it's just the price is 0.
Hardhat calls eth_feeHistory before calling eth_sendRawTransaction with 0 set in the max/priority gas price params (I decoded the raw RLP using https://toolkit.abdk.consulting/ethereum#transaction)
whereas Truffle calls eth_gasPrice before eth_sendRawTransaction with non-zero set in the gas price params.
Besu allows zero-priced transactions through but will still attempt to spend ETH is the incoming transaction tells it to, hence the truffle error.
Now what's interesting is that for my quickstart network, both eth_feeHistory and eth_gasPrice return 0 for the price...
➜  quorum-test-network curl -X POST --data '{"jsonrpc":"2.0","method":"eth_gasPrice","params":[],"id":53}' http://<IP_ADDRESS>:8545
{
  "jsonrpc" : "2.0",
  "id" : 53,
  "result" : "0x0"
}

➜  quorum-test-network curl -X POST --data '{"jsonrpc":"2.0","method":"eth_feeHistory","params": ["0x5", "latest", [20,30]],"id":1}' http://<IP_ADDRESS>:8545
{
  "jsonrpc" : "2.0",
  "id" : 1,
  "result" : {
    "oldestBlock" : "0x3",
    "baseFeePerGas" : [ "0x0", "0x0", "0x0", "0x0", "0x0", "0x0", "0x0", "0x0", "0x0", "0x0", "0x0", "0x0", "0x0" ],
    "gasUsedRatio" : [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ]
  }
}

which suggests to me that there's a bug in truffle because it's not respecting the response to eth_gasPrice and setting the gas price params to non-zero anyway.

Hi @gomezgoiri, does my previous comment answer your question and are you happy to close this issue?

Yes, @joshuafernandes I was able to deploy the project with Hardhat.
Thanks @siladu, I'll assume that it is a bug in Truffle (and possibly in polygon-edge) then. I'll check their issues and open a new one there if nobody has raised the flag yet. It is ok for me if you close this one.


scriptparameter tool variables (input/output files) ought not be also defined as configuration value

Write a meaningful exception, if a user tries to redefine a scriptparameter of a tool as configuration value (cvalue). Redefinition as configuration value undermines the filename-pattern mechanism. Alternatively, one may consider clearly defining the interaction between script-parameters, filename patterns and c-values in some other way (whatever that may be).

As discussed briefly, the current configuration mechanism will always prefer the parameter over the configuration value. This is because we create a higher priority configuration object which holds the parameters and imports all other configuration objects in the configuration hierarchy. Y

So no warning or error message intended? We see people abuse the mechanism and use the scriptparameter incorrectly (w/o filename pattern!) and instead use a c-value.

My browser died. I could not finish...
I think it is totally legit to abort workflow execution. But note, that this should only apply for output parameters.

Why only for output files? Because input files can be set via configuration values?

You fixed this, right?

Nope.


nixos/nextcloud: add Strict-Transport-Security

Motivation for this change
This commit adds a Strict-Transport-Security header to
the nginx config file generated by the nextcloud module.
The Strict-Transport-Security header is recommended in
official guide for hardening Nextcloud installations:
https://docs.nextcloud.com/server/16/admin_manual/installation/harden_server.html
Further, if it is not set, we see a warning in the security scan results
in the Nextcloud admin panel:
The "Strict-Transport-Security" HTTP header is not set to at least "15552000" seconds. For enhanced security, it is recommended to enable HSTS as described in the security tips

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers

@GrahamcOfBorg test nextcloud.basic


[zh] sync kms-provider.md

Sync with en text:
content/zh-cn/docs/tasks/administer-cluster/kms-provider.md

See preview please.

/approve