Don't use id numbers 1, 2, 3, ... in URLs

It is not professional that a user can guess feedback forms by changing the URL.

Well, it does not matter...


Marquez support in OpenLineage connector

Describe your changes:
Fixes

Currently OpenLineage connector supports only Kafka  as a source of OpenLineage events
In this PR we will introduce support for Marquez which is an reference implementation of the OpenLineage standard

Type of change:

[ ] Bug fix
[ ] Improvement
[x] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

This is closed because ...?

We needed to refactor the OpenLineage connector first. The pull request for refactor is almost ready, and then we can add Marquez integration on top of refactored approach.


Embed patched recipe for RocksDB 6.29.5

We depend on RocksDB 6.29.5. I don't know how we ever built a working package for it with MSVC, but when we removed it from the Ripple cache recently, CI could not build its replacement. This PR copies the recipe from Conan Center and adds a small patch to remove the statement include(thirdparty.inc) from its CMakeLists.txt, which fixes the build.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.65%. Comparing base (62dae3c) to head (e0d10ee).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4947      +/-   ##
===========================================
+ Coverage    61.59%   61.65%   +0.06%
===========================================
  Files          804      806       +2
  Lines        70686    70968     +282
  Branches     36580    36690     +110
===========================================
+ Hits         43537    43758     +221
- Misses       19814    19852      +38
- Partials      7335     7358      +23

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bump sbt-github-actions

Instead of https://github.com/ocadotechnology/sttp-oauth2/pull/23

:shipit:

:shipit:


add scala3 support for s3

relates to #166

have grabbed some code from futiles lib to remove the dependency (which does not yet support scala 3)

this will need to acknowledged in our license - futiles is Apache licensed

Scala 3 is stricter about private access and it looks like we'll need to make some pekko-http classes public.

Content-Length
Content-Type

char .toHexString fails to compile due to https://github.com/lampepfl/dotty/issues/14630
A couple more compile problems also

Since this is only used for testing I am fine with this approach

I'll review this when I get back home and have laptop

I'll review this when I get back home and have laptop

@mdedetrich would you have time to review this?

There seems to be a case of a leftover refactoring (see comments). Also to me it seems like the legal/GoogleCommonLicense.txt is unrelated to this PR???

that change is part of this PR - up until now, the only LICENSE extras were for google-common - so the build was using the root LICENSE for the google-common jar - now we have s3 stuff in the root LICENSE, so I need to create a special license for google-common that omits the s3 stuff

@pjfanning Is this ready or is it still in draft status?

@pjfanning Is this ready or is it still in draft status?

The code works but the type annotations to help the Scala 3 compiler are not ideal.

The code works but the type annotations to help the Scala 3 compiler are not ideal.

Ill checkout hte code locally to see what is going on but either way I don't think this is a deal breaker


Add JSON UI and optional sort for metadata widget

Partially addresses #851
Adds a default JSON viewer to the MetadataWidget and adds an optional sort which default to alphabetical by display name.
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

I moved the new react component into the ui-components package and cleaned it up a bit. This should be ready for review now

I guess I'm missing something. The tab doesn't show up after I ran make clean install on your branch. Is it supposed to be there?

Command/Ctrl Shift C
Elyra > Show Runtime Images

So I don't have to look it up again (:

Very convenient to have as an interim solution for generic metadata!
Three thoughts (I realize the last two might be not specific to this PR but since you are already touching the metadata widget ...):

Is there a need to display the metadata node? If it doesn't serve an purpose and we would only ever display child properties of metadata (which seems to be the case for runtime images) there shouldn't be a need for it.

Could the widget automatically sort the metadata entries by name?  As the list of entries grows it gets harder and harder to find the entry ...

We distinguish between user-defined and system-defined metadata. In above screen capture only the last one is  user-defined metadata. As a user I can only delete user-defined metadata. Trying to delete a system-defined metadata an error is raised. Could we hide the delete icon for system-defined entries that cannot be deleted?

Is there a need to display the metadata node? If it doesn't serve an purpose and we would only ever display child properties of metadata (which seems to be the case for runtime images) there shouldn't be a need for it.

This was a side effect of how the JSON Component was written. I can play with it some and see if I can show only the contents of a node without showing a parent. (should be possible)

Could the widget automatically sort the metadata entries by name? As the list of entries grows it gets harder and harder to find the entry ...

Actually having an optional sort that defaults to alpha when enable and can be overridden would be a good feature, I can tack it in here if it seems straight forward to add (otherwise I'll open another issue and pr to do it).

We distinguish between user-defined and system-defined metadata. In above screen capture only the last one is user-defined metadata. As a user I can only delete user-defined metadata. Trying to delete a system-defined metadata an error is raised. Could we hide the delete icon for system-defined entries that cannot be deleted?

I actually discussed this some with @kevin-bates a while ago and currently the api doesn't distinguish whether metadata is user-defined or system-defined until you call the delete api. I believe a "fix" for this on either the front or back ends would be overly complicated and messy for little benefit. Especially because you can "edit" a default to override it, at which point you could delete that edited version.

We distinguish between user-defined and system-defined metadata. In above screen capture only the last one is user-defined metadata. As a user I can only delete user-defined metadata. Trying to delete a system-defined metadata an error is raised. Could we hide the delete icon for system-defined entries that cannot be deleted?

Only the server distinguishes between user and system-define metadata instances.  We would need to add a meta-property to indicate this - probably something like a boolean-valued system_owned would be sufficient.
However, because we allow system-owned instances to be modified and essentially become user-defined instances - which can be deleted - then things get very confusing.  For example, if we were to set the system_owned meta-property to False when a user "updates" a system-owned instance, then the UI would show a delete icon and allow its deletion.  But, upon its deletion, the actual system-owned instance - of the same name - reappears and, this time, without a delete icon.
As a result, I'd be inclined to a) add a system-owned meta-property where necessary (i.e., schemas that can span the user/system domain), and b) disallow updates to system-owned instances.  This would mean that a user wishing to "update" a system-owned instance would be required to create a new instance with a different name containing the updated properties.

then things get very confusing.

Yep, I noticed that:

edit a system-defined metadata entry (OK)
delete the same entry (which is now a user-defined entry, OK)
but an entry is still visible, which is  (again) a system-defined, which cannot be deleted (FAIL)

This would mean that a user wishing to "update" a system-owned instance would be required to create a new instance with a different name containing the updated properties.

For the sake of simplicity that's the option  I would favor, even though a case could be made to not restrict editing/deletion of system-defined metadata at all. (Ignoring for now that a user can already do that by manually accessing the file system with the appropriate permissions.)

I pushed a couple commits addressing @ptitzler commit's. I updated the display to not show the "root" node and just the json contents. I also added an optional default alphabetical sorting based on display_name for MetadataWidget, which I disabled in CodeSnippetWidget but enabled for RuntimesWidget. Is alphabetical sorting something we would like for the Runtimes tab? Would we want to add it to Code Snippets?
New screenshot:

Thank you  Alex!
I do believe all lists should be sorted by default using a criteria that enables the user to quickly find relevant information for the majority of use case scenarios. A system-sorted order (whatever that means specifically as to how the sort order is implemented explicitly)  shouldn't be used unless it provides a clear advantage. Let's assume (dunno if that is the case) the current system-sort order for the metadata widgets is "by change date [of the underlying file], descending". Does the user derive any benefits from having the list presented in that order? How would the criteria help the user find the appropriate entry faster compared to an alphabetically sorted list?

Regarding sorting, I agree that we should have a consistent message regarding sorting - with the default being that items are sorted by display_name.   Code snippets, however, should be grouped by language, then sorted by display_name, with the groupings sorted by language.
I don't know what the implementation of the Code Snippets list widget (not sure that's the correct term) is, but we could probably introduce a meta-property to the schemas named something like group_by.  This would be an optional string-valued meta-property (i.e., resides outside the metadata stanza).  For Code Snippets, it would have a value of language.  Applications processing these instances would know to first group Code Snippets instances by language, then sort them by display_name within a grouping.  Schemas that do not use group_by, always sort by display_name.
The same rules should apply to the CLI tooling as well.

Based on the conversation above I updated to also sort code snippets using the method Kevin described


[SPARK-7165] [SQL] use sort merge join for outer join

This is an extended version of #5208
In this patch, we are introducing sort merge join for not only inner joins, but left outer/ right outer/ full outer joins.
Using sort merge join could resolve the OOM which is quite common as the memory easily becomes too small for joins of large tables.
Test cases are always available in SortMergeCompatibilitySuite.
Also , This patch would benefit from #3438 quite a lot.
/cc @chenghao-intel

Test build #30964 has started for   PR 5717 at commit fc862f4.

Test build #30964 has finished for   PR 5717 at commit fc862f4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test build #31103 has started for   PR 5717 at commit ae68ee7.

Test build #31103 has finished for   PR 5717 at commit ae68ee7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Merged build triggered.

Merged build started.

Test build #33121 has started for   PR 5717 at commit 44fd7cf.

Test build #33121 has finished for   PR 5717 at commit 44fd7cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33121/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #33580 has started for   PR 5717 at commit 6aaa593.

Test build #33580 has finished for   PR 5717 at commit 6aaa593.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33580/
Test FAILed.

Merged build finished. Test FAILed.

retest this please.

Merged build triggered.

Merged build started.

Test build #33582 has started for   PR 5717 at commit 6aaa593.

Test build #33582 has finished for   PR 5717 at commit 6aaa593.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33582/
Test PASSed.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #33707 has started for   PR 5717 at commit add49a2.

Test build #33707 has finished for   PR 5717 at commit add49a2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #34777 has started for   PR 5717 at commit add49a2.

Test build #34777 has finished for   PR 5717 at commit add49a2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@JoshRosen Thanks for your comments, I will refine the code accordingly.

By the way, to provide a bit of context for why I'm reviewing this PR: I'm working on some optimizations to sorting in Spark SQL which should benefit sort-merge-join, so I've looked over all of this code pretty recently.

@adrian-wang, I'm planning to take another pass on this pretty soon.  At a high level, this patch is in very good shape since most of its code is modeled after other existing join implementations in Spark SQL.  If you update this in the next couple of days, I'll try my best to be responsive with my reviews so we can get this in soon and not have too many merge conflicts.

Merged build triggered.

Merged build started.

Test build #35233 has started for   PR 5717 at commit 211e101.

Test build #35233 has finished for   PR 5717 at commit 211e101.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SerializableConfiguration(@transient var value: Configuration) extends Serializable
class SerializableJobConf(@transient var value: JobConf) extends Serializable
class ElementwiseProduct(VectorTransformer):
case class CreateStruct(children: Seq[Expression]) extends Expression
case class Sqrt(child: Expression) extends UnaryMathExpression(math.sqrt, "SQRT")
case class Logarithm(left: Expression, right: Expression)
case class SetCommand(kv: Option[(String, Option[String])]) extends RunnableCommand with Logging

Merged build finished. Test FAILed.

retest this please.

Merged build triggered.

Merged build started.

Test build #35337 has started for   PR 5717 at commit 211e101.

Test build #35337 has finished for   PR 5717 at commit 211e101.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SerializableConfiguration(@transient var value: Configuration) extends Serializable
class SerializableJobConf(@transient var value: JobConf) extends Serializable

Merged build finished. Test PASSed.

Thanks for updating this; I'll try to take another review pass tomorrow.

/bump, do you think that we'll have time to finish this for 1.5.0?
/cc @rxin

Yup I will work on this myself tomorrow based on this PR.

Merged build triggered.

Merged build started.

Test build #38839 has started for   PR 5717 at commit 07f96b5.

Test build #38839 has finished for   PR 5717 at commit 07f96b5.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39024 has started for   PR 5717 at commit 4152e86.

Test build #39024 has finished for   PR 5717 at commit 4152e86.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39030 has started for   PR 5717 at commit fd73084.

Test build #39030 has finished for   PR 5717 at commit fd73084.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39159 has started for   PR 5717 at commit f520079.

Test build #39159 has finished for   PR 5717 at commit f520079.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39678 has started for   PR 5717 at commit d0e65c5.

Test build #39678 has finished for   PR 5717 at commit d0e65c5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39689 has started for   PR 5717 at commit bff834a.

Test build #39689 has finished for   PR 5717 at commit bff834a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@JoshRosen I've fixed the bug  that @jeanlyn mentioned, can you merge this first and then do the following steps in #7904 ?

We should have a test to guard against reintroduction of the the bug that @jeanlyn mentioned.
I find the code here to be really dense and hard to understand, so I'd like to try to pursue my design first. There's another 1.5 blocker / critical related to eliminating JoinedRow in favor of Tungsten's RowJoiner when UnsafeRows are used, and I think that the code re-use enabled by my design will make this significantly easier to accomplish.

Also, I think that it might be a little clearer to introduce a separate SortMergeOuterJoin operator rather than trying to combine the inner and outer joins into the same operator. This would be consistent with what we've done for other joins.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

retest this please.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #227 has started for   PR 5717 at commit 549796e.

Test build #39844 has started for   PR 5717 at commit 549796e.

Test build #227 has finished for   PR 5717 at commit 549796e.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #39844 has finished for   PR 5717 at commit 549796e.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39983 has started for   PR 5717 at commit d02f6bb.

Test build #39983 has finished for   PR 5717 at commit d02f6bb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.


improved cardiac muscle regeneration

Add new term:
improved cardiac muscle regeneration (new child of improved muscle regeneration MP:0013161 and abnormal cardiac muscle regeneration MP:0013238)
SYN: increased cardiac muscle regeneration
SYN: enhanced cardiac muscle regeneration
SYN: increased heart muscle regeneration
SYN: improved heart muscle regeneration
SYN: enhanced heart muscle regeneration
Annotation from J:200670 (genotype MGI:5544301)

Added new term:
enhanced cardiac muscle regeneration MP:0031321using enhanced in primary term label and increased and improved as synonyms (see discussion in #3401)


Don't check for cache hits in when download x-artifact ref, do it in …

…target artifact instead

tested in notebok and in standalones


Feature/tidal quality factor

Thanks for adding this, this puts the estimation of tidal parameters more in line with typical practice :)
In the unit tests, there is one failure in the partials (test_acceleration_partials/testDirectDissipationAccelerationPartial). For the case where useRadialTerm = 1and usePlanetTide = 0, the partials w.r.t. Io's and Jupiter's position seem to be off by a factor exactly equal to 2 (analytical - numberical)/analytical=2

That's on me, I modified the acceleration formula for the tides on the moon (it had an extra factor 2, which is also something I identified when benchmarking Tudat and NOE). But I forgot to modify the corresponding unit test, something that I can fix it tomorrow too. You can have a look at either Valery's or Lari's papers but I think that the factor 2 should indeed go away.

Should be fixed now :)

Thanks! Indeed, the unit test now also passes for me :) Code merged!


[tool_crash] FileSystemException: Creation failed, OS Error: No such file or directory, errno = 2

Command
flutter doctor

Steps to Reproduce

...
...
...

Logs
FileSystemException: Creation failed, OS Error: No such file or directory, errno = 2
#0      _Directory.createSync (dart:io/directory_impl.dart:124:7)
#1      ForwardingDirectory.createSync (package:file/src/forwarding/forwarding_directory.dart:20:16)
#2      ErrorHandlingDirectory.createSync.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:426:22)
#3      _runSync (package:flutter_tools/src/base/error_handling_io.dart:587:14)
#4      ErrorHandlingDirectory.createSync (package:flutter_tools/src/base/error_handling_io.dart:425:12)
#5      EngineCachedArtifact.updateInner (package:flutter_tools/src/cache.dart:954:19)
<asynchronous suspension>
#6      CachedArtifact.update (package:flutter_tools/src/cache.dart:848:5)
<asynchronous suspension>
#7      Cache.updateAll (package:flutter_tools/src/cache.dart:715:9)
<asynchronous suspension>
#8      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1699:7)
<asynchronous suspension>
#9      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1389:27)
<asynchronous suspension>
#10     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
<asynchronous suspension>
#11     CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#12     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:355:9)
<asynchronous suspension>
#13     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
<asynchronous suspension>
#14     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:295:5)
<asynchronous suspension>

[✓] Flutter (Channel stable, 3.19.5, on macOS 14.4.1 23E224 darwin-arm64, locale zh-Hans-MO)
    • Flutter version 3.19.5 on channel stable at /Users/x/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 300451adae (3 weeks ago), 2024-03-27 21:54:07 -0500
    • Engine revision e76c956498
    • Dart version 3.3.3
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/x/Library/Android/sdk
    • Platform android-34, build-tools 33.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.85.2)
    • VS Code at /Users/x/Downloads/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • iPhone 15 Pro Max (mobile) • 44B

Closing this as a duplicate of https://github.com/flutter/flutter/issues/137894


Improve --libraries documentation for linking more than one library

forge create --libraries tag on contract deployment throws error when linking multiple libraries.
Not sure if lacking proper documentation showing the proper approach, or just a bug. Either way, as a user, I am confused as to how to link more than one external library on contract deployment.
ex.
forge create ExampleContract --rpc-url $RPC --private-key $KEY --libraries lib/solmate/src/utils/SafeCastLib.sol:SafeCastLib:0xaBcd0C11d7c8AaABBa176Cb5ab9531BCcF7711f1
lib/solmate/src/utils/SafeTransferLib.sol:SafeTransferLib:0xabCd5E5C3C6d9fcb3150BF64015186f45C8F4273 lib/solmate/src/utils/FixedPointMathLib.sol:FixedPointMathLib:0xABCd3390ea4Ea050E296e1Eeb766193c8C0cb6c6

error: Found argument 'src/utils/SafeTransferLib.sol:SafeTransferLib:0xabCd5E5C3C6d9fcb3150BF64015186f45C8F4273' which wasn't expected, or isn't valid in this context

current docs:
--libraries libraries
    Set pre-linked libraries.

    The parameter must be in the format <remapped path to lib>:<library name>:<address>, e.g. src/Contract.sol:Library:0x....

    Can also be set in your configuration file as libraries = ["<path>:<lib name>:<address>"].

I was having the same conundrum. If its helps anyone out there, just add the --libraries flag for each library, eg:
forge create ExampleContract --rpc-url $RPC --private-key $KEY \
--libraries lib/solmate/src/utils/SafeCastLib.sol:SafeCastLib:0x......\
--libraries lib/solmate/src/utils/SafeTransferLib.sol:SafeTransferLib:0x......\
--libraries lib/solmate/src/utils/FixedPointMathLib.sol:FixedPointMathLib:0x......


can't import mod on mobile

Hi I'm really excited to play your mod but I can't import it on mobile. Didn't try it on PC though. When I try the mod browser option it says error with upgraded factories. Import file option says with zip that there isn't a json file and and unzipped wants to open individual folders. Got hub import says the same error as mod browser. Id like to know how to fix it of you know. Thanks a lot. I'll be happy to play your mod.

Sorry for that, I just realized I need to dex the jar file.

Yo try running this: https://github.com/genNAowl/Upgraded-Factories/releases/tag/2.1
If it works, close the issue

I'm sorry it still doesn't work the jar file says error:UpgradedFactories and zip file says there is no json file. I'm sorry hope you will fix it someday. I wish you good luck :)

It works!!!!! Not through import file but trough mod browser!!!! Thank you very much !!!!!! :D


[Bug]: Spotify muted after auto-skipping songs.

🔍 Have you checked that you are using an auto updating method or latest version of the extension?

[X] I have checked that I am on the latest version.

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

Choose the extension for bug report.
Auto Skip
ℹ Environment / Computer Info
- Spotify version: <IP_ADDRESS>0.g52970952
- Spicetify version: 2.17.2

📝 Description
Steps:

Clear queue.
Play any song and pause it.
Set auto-skip to liked songs.
Enqueue 2-5 liked songs and 1 unliked song.
Press play and skip to next song.

Expected behavior: Will play unliked song without any changes to the volume.
What happens: Volume is muted once the queue reaches the unliked song after skipping.
📸 Screenshots
No response

Yeah, I am sometimes able to reproduce it, it's very flaky, sometimes it happens for a large number of skips together, otherwise primarily for 1-2 songs it does not.
I was thinking of removing the mute functionality altogether, I don't know if that's useful. Any thoughts?

Personally, I don't think it's very useful. I don't mind the small blips of audio that may come up while it skips.

Should be fixed now, mute functionality will only function when doing some callback i.e. say when you play a remix song and you have auto skip set to skip remix songs, the extension tries to find the non-remix version of that song and replaces that in your queue.

Awesome, everything seems to work fine on my end.


Sourcemaps with normal Usage, not Alternative usage

We're having troubles trying to make source maps work with typescript spec source files and main source files.
If we stick with the Alternative usage described here, then generate source maps as suggested in following section here, we can happily browse typescript code from Chrome developer tools while debugging tests.
If we stick with the basic usage described here, and we load spec files through karma.conf.js, instead of require-ing them in test shim single entry point, it looks like sourcemaps stop working. Browser developer tools only show JS webpack-prepared bundles, not original typescript source files.
Is this second way feasible at all? Can anybody explain how to get there? Thanks for your time!

@BrainCrumbz As recommended in the README, in my karma.conf.js I have:
    files: ['client/tests.entry.ts'],

    preprocessors: {
      'client/tests.entry.ts': [
        'webpack',
        'sourcemap'
      ]
    },
    webpack: {
      entry: './client/tests.entry.ts',
      verbose: true,
      devtool: 'inline-source-map',
      // ...rest of my webpack config
    }

but the error messages do not map back to the source files:
FAILED TESTS:
  Component Maker
    Make selector
      ✖ should return a valid multipleCamelCased for a three-word or more selector
        Chrome 49.0.2623 (Mac OS X 10.11.3)
      ReferenceError: FooBarComponent is not defined
          at Context.<anonymous> (/Users/Jason/git/webpack-ts-demo/client/tests.entry.ts:110:57)

Anyone know what I'm doing wrong?

:+1:
Having same issue.
I suppose it may be related to issue #13 :( .

I can verify this with a simple test:
// karma.conf.js
module.exports = function(config) {
  config.set({
    basePath: '',
    frameworks: [ 'mocha' ],
    files: [ 'test/unit.js' ],
    preprocessors: {
      'test/unit.js': [ 'webpack', 'sourcemap' ]
    },
    plugins: [
      'karma-mocha',
      'karma-phantomjs-launcher',
      'karma-sourcemap-loader',
      'karma-webpack',
      'karma-spec-reporter'
    ],
    reporters: [ 'spec' ],
    browsers: [ 'PhantomJS' ],
    singleRun: true,
    webpack: {
      devtool: 'inline-source-map',
      module: {
        loaders: [
          {
            test: /\.ts(x?)$/,
            loader:
              `babel?` +
              `presets[]=${require.resolve('babel-preset-es2015')},` +
              `presets[]=${require.resolve('babel-preset-stage-0')}` +
              `!ts`
          }
        ]
      }
    },
    webpackMiddleware: {
      noInfo: true
    }
  })
}

// test/unit.js
require('./foo-unit.ts');

// test/foo-unit.ts
throw new Error('test');

Outputs
  Error: test
  at /Users/my-name/Workspace/test/test/unit.js:7594 <- webpack:///test/foo-unit.ts:1:0
``

This **works nice**. But let us change `test/unit.js` to `test/unit.ts`:

// karma.conf.js
...
files: [ 'test/unit.ts' ],
preprocessors: {
'test/unit.ts': [ 'webpack', 'sourcemap' ]
},
...

// test/unit.ts
import './foo-unit.ts';
**Outputs**

Error: test
at /Users/my-name/Workspace/test/test/unit.ts:7595
``
The mapping is lost.

I was faced with the same problem.
There workaround how to run webpack + typescript with sourcemaps + karma:
https://github.com/pltnkv/webpack-demo
webpack.config.js
module.exports = {
	entry: {
		app_entry: "./src/entry",
		test_entry: "./tests/entry"
	},
	output: {
		path: path.resolve("./out"),
		filename: "[name].js"
	},
	ts: {
		transpileOnly: true,
		compilerOptions: {
			target: 'ES5',
			sourceMap: true
		}
	},
	devtool: 'inline-source-map',
    // ...
};

karma.conf.js
module.exports = function (config) {
	config.set({
		frameworks: ['jasmine'],
		files: [
			'out/test_entry.js'
		],
		reporters: ['progress'],
		preprocessors: {
			'out/test_entry.js': ['sourcemap']
		},
		port: 9876,
		colors: false,
		logLevel: config.LOG_DEBUG,
		autoWatch: true,
		singleRun: false,
		browsers: ['PhantomJS']
	});
};

@donaldpipowitch https://github.com/webpack/karma-webpack/issues/109#issuecomment-214331239
thanks, without changing .ts to .js inline-source-map options doesn't work for me and no source maps is included to final js file. after I change the extension it worked! but the source file line number problem still remains. I cannot see the actual line number on terminal but I can see it properly in Chrome console.

typescript or webpack doesn't emit source maps if file extenstion is not js
Hot fix:
in node_modules/karma-webpack/index.js
// replace this
webpackOptions.output.filename = "[name]";
// by that
webpackOptions.output.filename = "[name].js";

// find this line
Plugin.prototype.readFile = function(file, callback) {
    // insert this condition
    if (file.substr(-3) !== '.js') {
        file += '.js';
    }

@cevek How about a PR?

Here it is https://github.com/webpack/karma-webpack/pull/127

Here's native solution to make source map work in typescript unit tests:
include SourceMapDevToolPlugin  plugin to webpack config and configure it to process .ts files as well:
plugins: [
  new webpack.SourceMapDevToolPlugin({
    filename: null, // if no value is provided the sourcemap is inlined
    test: /\.(ts|js)($|\?)/i // process .js and .ts files only
  })
]

Resolving this one. Multiple resolutions in the issue & the extension bug is a known issue

I see the sourcemaps in the browser. However, when I try to add a breakpoint it sends me to the bundled code. Is that normal? Also the line is off by 2 in the console and only points to the describe that is failing.

I'm also seeing bundles code same as @adam-beck mentioned. When I click Debug in Karma, and open for example app.component.spec.ts in my Angular 4 project, I see the WebPack bundled source, not the original .ts file.


Add unack-message threshold to restrict consumer for receiving messages without acknowledging-msg up to the threshold

Motivation
If consumer keep tries to receive messages without acknowledging to broker then broker won't know last-deleted/received message entry. and if broker/consumer crashes/restarts in between then next time broker needs to send all the messages again as client didn't ack those messages.
Modifications

introduced configurable threshold maxUnackedMessagesPerConsumer limit till which consumer can consume messages without sending ack
once consumer reaches this maxUnackedMessagesPerConsumer limit, broker stops sending further messages until consumer sends acknowledgement for maxUnackedMessagesPerConsumer/2 messages.

Result

broker can block consumer if consumer doesn't send ack for maxUnackedMessagesPerConsumer number of messages.

CLA is valid!

CLA is valid!


Convert Rician noise to Gaussian using breaking the noise floor method.

Python implementation here:
https://github.com/samuelstjean/nlsam/blob/master/nlsam/stabilizer.pyx
Uses GPL license.
The PIESNO part is included in dipy.

I'm not comfortable with the statistical motivation for this method.

I'm leaning towards using a Box-Cox transformation instead

Going for Box-Cox instead, se issue #18


Migrate "Support" documentation to Asciidoc

🆕🐥 First Timers Only
This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
👾 Description of the issue
The information that can be found at https://adoptium.net/support.html must be converted to asciidoc and stored as a document in this repository.
📋 Step by Step
To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here.

[x] Claim this issue: Comment below.
[x]  Fork the repository in github by simply clicking the 'fork' button.
[x]  Check out the forked repository
[x]  Create a feature branch for the issue. We do not have any naming definition for branches.
[x]  Commit your changes.
[x]  Start a Pull Request.
[x]  Done 👍 Ask in comments for a review :)
[x]  If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
[x]  You did it 🎉 We will merge the fix in the master branch.
[x]  Thanks, thanks, thanks for being part of this project as an open source contributor ❤

🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a change to receive cool goodies like a T-Shirt. 🎽
🤔❓ Questions
If you have any questions just ask us directly in this issue by adding a comment. You can join our community chat at Slack. Next to this you can find a general manual about open source contributions here.

Hi I am interested in solving this issue.

PR merged :) THX for the contribution @CKeibel


aws-smithy-client: Upgrade hyper-rustls to 0.23.0

This avoids having two versions of hyper-rustls (and its dependencies)
in code that uses a custom hyper-rustls connector.
Testing
Passes cargo test -p aws-smithy-client.
Checklist

[x] I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing in favor of another PR that will include this one.


proportion_from_point is not working for some cases

Description of bug / unexpected behavior

Hello, I'm trying to get the proportion of the vertices from a triangle outline, but the result is not correct for some cases.
For easy testing purpose, I tried a regular triangle which is shifted and scaled somehow.
The result i got was 0, 0.33333333333333337, 16336461.942820664 for the three vertices instead of 0, 0.3333333333333333, 0.6666666666666667.
Obviously, the proportion of the third vertex was wrong.
Expected behavior

In the case mentioned above, i should get 0, 0.3333333333333333, 0.6666666666666667 for each vertex of any regular triangle regardless of whether it's shifted/scaled or not.
How to reproduce the issue

Here is the code i used for testing the regular triangle case:
Code for reproducing the problem
1. Without shift and scale, the result is ok.
class TestProportion(Scene):
    def construct(self):
        from math import sqrt
        A=sqrt(3)*UP
        B=LEFT
        C=RIGHT
        abc = Polygon(A,B,C)

        for p in abc.get_vertices():
            print(abc.proportion_from_point(p))

================================
output:

0.0
0.3333333333333333
0.6666666666666666

2. With shift only, the result is ok.
class TestProportion(Scene):
    def construct(self):
        from math import sqrt
        A=sqrt(3)*UP
        B=LEFT
        C=RIGHT
        abc = Polygon(A,B,C)
        abc.shift(LEFT)

        for p in abc.get_vertices():
            print(abc.proportion_from_point(p))

================================
output:

0.0
0.3333333333333333
0.6666666666666666

3. With scale only, the result is ok.
class TestProportion(Scene):
    def construct(self):
        from math import sqrt
        A=sqrt(3)*UP
        B=LEFT
        C=RIGHT
        abc = Polygon(A,B,C)
        abc.scale(0.8)

        for p in abc.get_vertices():
            print(abc.proportion_from_point(p))

================================
output:

0.0
0.3333333333333333
0.6666666666666666

4. With shift and scale, the result is NOT ok.
class TestProportion(Scene):
    def construct(self):
        from math import sqrt
        A=sqrt(3)*UP
        B=LEFT
        C=RIGHT
        abc = Polygon(A,B,C)
        abc.shift(LEFT)
        abc.scale(0.8)
        for p in abc.get_vertices():
            print(abc.proportion_from_point(p))

================================
output:

0.0
0.33333333333333337
16336461.942820664

Additional media files

Images/GIFs

Logs
Terminal output

PASTE HERE OR PROVIDE LINK TO https://pastebin.com/ OR SIMILAR

System specifications
System Details

OS (with version, e.g., Windows 10 v2004 or macOS 10.15 (Catalina)):
RAM:
Python version (python/py/python3 --version):
Installed modules (provide output from pip list):

PASTE HERE

LaTeX details

LaTeX distribution (e.g. TeX Live 2020):
Installed LaTeX packages:

FFMPEG
Output of ffmpeg -version:
PASTE HERE

Additional comments

I found the wrong value '16336461.942820664' was from proportions_along_bezier_curve_for_point, it could be caused by the accuracy while finding the roots of the bezier polynomial.
As per the reference of Numpy,

the accuracy of the roots decrease the further outside the domain they lie.

Maybe we could do some correction on the coefficient (like we are rounding the roots) before solving the polynomial?
Or we could bypass all the roots which do not belong to [0,1]. Not sure why this is not checked currently, any reason that i missed?

p.s. The two approaches above are roughly tested on my case and works, but maybe there are better fixes that i'm not aware of.
At last, thanks for the great library, it really helps making math video much more easily.

Apologies for the very late reply, and thank you for this very fine report!

Or we could bypass all the roots which do not belong to [0,1]. Not sure why this is not checked currently, any reason that i missed?

This seems to be like a very simple solution if this really fixes the issue -- do you happen to remember which changes you applied to where exactly, or would you perhaps be willing to contribute a PR with these changes?

Sorry for the delay, I'm glad to contribute. PR #2770 is created.
Basically, the change is in bezier.py, bypass the calculated root which is out of range [0,1] before returning them, details as below:
def proportions_along_bezier_curve_for_point(
    point: typing.Iterable[float | int],
    control_points: typing.Iterable[typing.Iterable[float | int]],
    round_to: float | int | None = 1e-6,
) -> np.ndarray:
    ...

    roots = [[root for root in rootlist if root.imag == 0] for rootlist in roots]
    roots = reduce(np.intersect1d, roots)  # Get common roots.
    roots = np.array([r.real for r in roots if r.real <= 1 and r.real >= 0])
    return roots

Pls kindly review, thanks.


Extra configuration parameters for apache2

In some cases we need to set some custom parameters for horizon in
apache configuration, for example running horizon under load balancer
with SSL, we should set X-Forwarded-Proto to https instead of http.
There might be more cases where we need some custom configuration in
addition to template.

These changes belongs to salt-formula-apache, they have nothing to do with Horizon itself.

This formula (salt-formula-horizon) does not including apache state from salt-formula-apache.
This formula is configuring apache2 package and configs itself, thats why we need this changes in horizon formula.

Hm, unfortunately you are right :-(

Agree with Filip, this PR should trigger integration with apache formula. However until that happen, we can't block 'deployments' in order to get better formulas.
@noskovao First problem with this PR is as Filip suggested - it's apache cfg not horizon that we tries to get in. Second is that we iterate over some extra_opts which may contain whatever. So once you add these to reclass pillar they will look bit odd and also later it did not help us when we try to move them under apache formula. The best case would be to use the same pillar tree structure as it would be used on apache formula.
However there is no support today for SetEnvIf or kind of extra opts on apache formula.
        - key: SetEnvIf
          value: "X-Forwarded-Proto https HTTPS=1"```

If I do understand setting "SetEnvIf X-Forwarded-Proto https HTTPS=1" would not break apache if it's not exposed on https as SetEnvIf conditionally enables the option based on the regular provided. If that is true - it would be ok to just update PR adding hardcoded `SetEnvIf X-Forwarded-Proto https HTTPS=1` into the existing openstack-dashboard.conf on this formula. Filip won't be happy anyway, but that's not the end of Earth days.

@fpytloun if you consider this chain of merges as a way wrong (https://github.com/salt-formulas/salt-formula-horizon/commits/master/horizon/files/openstack-dashboard.conf.Debian) then I guess you may trigger/plan upgrade of this formula by dev team.

Yes, option that @epcim mentioned would be fine.
Moreover there's this condition:
{% if server.get('ssl', {}).get('enabled', False) %}

@fpytloun commented on Feb 13, 2017, 11:37 AM GMT+1:

Yes, option that @epcim mentioned would be fine.
Moreover there's this condition:
{% if server.get('ssl', {}).get('enabled', False) %}
So you can simply set what's needed inside that block (these headers should be always set if proxying requests from https).

hmm. ssl i terminated on nginx. I am not sure with horizon.server.ssl I quite guess that's the reason for this PR

If you terminate SSL on nginx, then nginx should pass correct headers, right?

We are using SAML for horizon, and this is only one reason of this commit:
Without this option in apache getting:
https://<IP_ADDRESS>:5000/v3/auth/OS-FEDERATION/websso/saml2?origin=http://<IP_ADDRESS>/auth/websso/
With this option in apache getting:
https://<IP_ADDRESS>:5000/v3/auth/OS-FEDERATION/websso/saml2?origin=https://<IP_ADDRESS>/auth/websso/

That's fine but the point is that this header should be set by SSL proxy which in this case is some nginx.. This Apache has no idea if SSL was terminated by some previous proxy

I think the problem that apache response it is http application, not https, that's why we are getting http instead of https in the middle of URL, nginx doesn't care of this redirections
Let me talk to Petr, probably we can land this changes in our forked formula.
If so, I will just close this PR.
But we are all agree that this is bad solution and we need some flexibility in horizon and apache formulas :)

No I wanted to explain that there's nothing wrong in behavior of this Horizon or Apache, the problem is in misconfiguration in Nginx which is terminating SSL.
When you are proxy terminating SSL and passing requests via http to other services, you need to tell them that you terminated SSL. They usually distinquish this using headers like X-Forwarded-Proto, etc. which needs to be set by proxy which terminated the SSL (so nginx in this case).
So your change here is just a workaround to wrongly configured nginx.

@fpytloun not this is an imminent bug fix for critical ticket on our production model.
Where the $sheme get's the value assigned? I tend to belive it's https. as ssl is on.
#https://mozilla.github.io/server-side-tls/ssl-config-generator/
ssl_ciphers 'ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA
ES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES12
E-RSA-AES128-SHA:ECDHE-ECDSA-AES256-SHA384:ECDHE-ECDSA-AES256-SHA:ECDHE-RSA-AES256-SHA:DHE-RSA-AES128-SHA256:D
CDHE-ECDSA-DES-CBC3-SHA:ECDHE-RSA-DES-CBC3-SHA:EDH-RSA-DES-CBC3-SHA:AES128-GCM-SHA256:AES256-GCM-SHA384:AES128
S';
ssl_prefer_server_ciphers on;
ssl_ecdh_curve secp521r1;
ssl_dhparam /etc/ssl/dhparams.pem;

ssl_session_cache shared:SSL:10m;
ssl_stapling on;
ssl_stapling_verify on;
  ssl_session_cache shared:SSL:10m;

  location / {
      proxy_pass http://<IP_ADDRESS>:8079;

      client_max_body_size 10000m;
      client_body_buffer_size 200m;
      proxy_connect_timeout 43200;
      proxy_send_timeout 43200;
      proxy_read_timeout 43200;
      send_timeout 43200;
      proxy_redirect http:// https://;
      proxy_buffering on;
      proxy_buffers 4 256k;
      proxy_buffer_size 512k;
      proxy_busy_buffers_size 512k;

      proxy_http_version 1.1;

      proxy_set_header Host $host;
      proxy_set_header X-Real-IP $remote_addr;
      proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
      proxy_set_header X-Forwarded-Proto $scheme;
      proxy_set_header X-Forwarded-Host $host;
      proxy_set_header X-Forwarded-Server $host;
      proxy_set_header X-Forwarded-Port $server_port;
      add_header Front-End-Https on;
      proxy_set_header Upgrade $http_upgrade;
      proxy_set_header Connection "upgrade";

  }

}
(XXX)root@prx-01:/usr/share/openstack-dashboard# cat /etc/nginx/sites-enabled/nginx_proxy_openstack_web.conf

"Will work, not break anything." approach isn't what we want to do.
So fix what's broken (where's X-Forwarded-Proto header if it was correctly set by nginx, eg. did the apache removed it?), don't introduce lazy workarounds.


Doesn't work with ember-wormhole

Can you provide more info on this?
Don't know if this is related with #11. It seems to work fine with ember-wormhole.
I'll close this for now. We can reopen if this still proves to be a problem.


makeOpamRepo creates an empty key entry when any directory ending with opam is present

Describe the bug
It seems that makeOpamRepo creates an extra entry (at least in .passthru.sourceMap) when there exists a directory _opam (even if empty).
The problem is that when building, this breaks.
My setup:
.
├── a.opam
├── _opam   # empty directory, or with files inside

So I expect (makeOpamRepo ./.).passthru.sourceMap to only include a.
However it also includes an entry with an empty key:
nix-repl> (lib.makeOpamRepo ../../myrepo).passthru.sourceMap
[1 built]{
  "" = { ... };
  a = { ... };
}

Note that makeOpamRepoRec does not have this problem :thinking:
Environment

Version of the code: master

Actually it's not just _opam, it is if there is any directory suffixed with opam, e.g. a directory foobaropam reproduces the bug too.

Fix suggestions:

Replace hasSuffix "opam" name with (hasSuffix "opam" name && value == "regular") (maybe also support "symlink", TBC) so that directories are ignored
Replace "opam" with ".opam" to lower the risk of fetching incorrect files (e.g. foobaropam` is unlikely a good candidate)


Avoid expressions and conditions that always produce the same result.

Impact

[ ] Bug fix (non-breaking change which fixes expected existing functionality)
[ X] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
This pull request adds a feature to the project that reports expressions and conditions that always produce the same result. These expressions could be replaced with the corresponding constant value, which could improve code efficiency and maintainability. However, the presence of such expressions could also indicate a bug in the code.
To identify these expressions, the pull request includes new functionality that analyzes the code for expressions that always produce the same result, such as true, false, null, or zero. When such expressions are found, a report is generated that lists the affected expressions and provides recommendations for how to address them.
Overall, this pull request adds valuable functionality to the project that can help developers to improve the quality and reliability of their code. Please let me know if you have any questions or concerns about these changes.

Initial/Pre-Review Thoughts
For the full code review, make sure to look at check that the removed code is actually pointless and/or if the real problem is that we're missing an extra "else throw an unexpected state" thing.
Questions I have:

None

Potential risks:

None

What could make the full review difficult:

Nothing

Hi @arturobernalg,
Have you had a chance to look at my comments here?
Thanks,
Daniel.

Hi @arturobernalg,
Have you had a chance to look at my comments here?
Thanks, Daniel.

Hi @MalloD12
Sorry for the late response. I'll take a look to this PR and the other one this weekend
TY

Hi @arturobernalg,
Have you had a chance to look at my comments here?
Thanks, Daniel.

Hi @MalloD12 Sorry for the late response. I'll take a look to this PR and the other one this weekend TY

Sure, I appreciate it @arturobernalg!

I haven't review  all the case but  almost sure that the change its redudant

Hi @arturobernalg, the other day when looking into this PR again I realised my changes were reverted (maybe because of the forced push) and can't see any new change here as well as no answers to my questions. Was this unintended, or do you think those changes make no sense and you would like to keep the original approach of this PR?
Thanks,
Daniel.

Hey Everyone,
I have decided to close this pull request and begin anew. I apologize for any inconvenience caused by this decision. Thank you for your understanding.
Best regards,

No problems!


Extra padding bellow the cancel button

Ther is an extra padding bellow cancel button in ios. So the entire view is not perfectly aligned to bottom even after applying justifyContent as flex-end in overlayStyle.

Please submit a PR, or try to find the line that adds the padding.  I suspect it could be removed, or add a style prop to allow overriding it.


Update values.yaml for minikube

The number of cost-analysis worker POD is 4, not 1.
Please reduce the default number to 1.

Hi @choonho can you please give me some more context regarding this issue so that I can resolve this?


feat: add new module "ngStyle" support css loading via component

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feat
What is the current behavior? (You can also link to an open issue here)
Exist in angular 2, not yet in angular 1.x
What is the new behavior (if this is a feature change)?
Add new module to load css styles via components like angular 2 does.
for example:
var mod = angular.module('helloStylesApp', ['ng', 'ngStyle']);
mod.component('helloStyles', {
  templateUrl: 'hello-styles/hello-styles.html',
  // add dynamically styles for comopnent
  styleUrls: ['./base.css', './hello-styles/hello-styles.css'],  // or styles: 'a {color: red; } h2 {color: green;}',
  // another option is to use:
  controller: ['$style', '$styleRequest', '$timeout', function ($style, $styleRequest, $timeout) {
    // Add style dynamically
    $style.addStyleUrls(['./base.css', './hello-styles/hello-styles.css']).then(function (data) {
      ...
    });

    // Remove style dynamically
    $style.removeStyle(['./hello-styles/hello-styles.css']);

    // Or just fetch the style for js manipulation
    $styleRequest('./hello-styles/hello-styles.css').then(function(cssText){
      ...
    });
  }]
});

Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Other information:
The implementation of this feature considered the minimum changes to the compile function in order to keep the code as is.

Hi @MeirAmar. I see you've been hard at work here :smiley:
Has this feature been discussed somewhere? If yes, you should link to the discussion. If not, keep in mind that major changes (such as this one) should be discussed first so that we can better coordinate our efforts, prevent duplication of work, and help you to craft the change so that it is successfully accepted into the project.
Can you add a summary of what this feature is about (e.g. what it does and how it works)?

Hi @gkalpak,
I tell you the truth this is my first PR for the Angular project. I have searched a little in the git comments and the PRs for some similar feature but I didn't found any (Maybe there is one out there and i didn't found yet). Anyway, where should such a discussion thread should be? I will add more about this feature (I thought what I written in the behavior is enough ;) ).
Thanks
Meir

You could have opened an issue on GitHub for discussion.

All the "new behavior" section says is:

Add new module to load css styles via components like angular 2 does.

That is clearly inaccurate (as shown in your example that follows) and likely impossible :smiley: (since Angular has its own HTML and CSS parsers, which AngularJS does not).

@gkalpak - thanks for your clarification.  I was misunderstood, I meant "like" by syntax only.
I will try to make myself clearer. I added a new issue https://github.com/angular/angular.js/issues/15805 as you suggested let me know if you have another notes/remarks for me.
Meir

This is not gonna happen as we are in LTS


Add OTP Token

Please check the following to ensure a successful verification of Token Profile
.json and .png document checklists

[X] logo dimensions: 120*120 px
[X] logo background: Transparent
[X] At least one transaction on the token contract
[X] For ERC-20 project teams: Upper and lower capitalized alphabets in token address (For checksum purposes)
[X] Same document name for both .json and .png (Including capitalization)

Project background:
Official announcement:
Project team background: ICT Comapny
Project basic information: Personal Security Application
Media publications: None
Tradeable exchanges: Coinrism Exchange (www.coinrism.com)
Recommended Gas Limit (For ERC-20 project teams) for transaction: (Default is 60,000)

add otp token

PR冲突，请修改后重新提交。

PR冲突，请修改后重新提交。


dockerfile: Optimization of image size

This change uses multi-stage build of image
which makes image size much smaller.
It also uses debian slim as base image.
Issues:
Refs: https://github.com/cnf-testsuite/cluster_tools/issues/24

Difference between original image and image with this change:
ubuntu@testsuite:~/cluster_tools_slim_test/cluster_tools$ docker images
REPOSITORY                    TAG                                IMAGE ID       CREATED         SIZE
**horecoli/cluster-tools        test_slim_image**                    50f341eca255   9 days ago      **1.23GB**
**cluster-tools                 original**                           235feb8f8c4f   13 days ago     **5.36GB**
Build image with this change in DockerHub:

Original image in DockerHub:

If someone would like to test this new image it is available in my repository in DockerHub: https://hub.docker.com/layers/horecoli/cluster-tools/test_slim_image/images/sha256-1d0d8837ed57933b96d1d3759d7191c6d7cefacac4c1c49649eab5ea8dce2dbb?context=repo

Tested by this action in cnf-testsuite
https://github.com/cnti-testcatalog/testsuite/actions/runs/9366756183
all passed.
lgtm and ready for merge from my point of view.


Most functions are incorrect for calendars other than Calendar.ISO

Most functions in Timex manipulate the Elixir data structures directly. In doing so, they assume a lot about the underlying calendar - in most cases the functions would just not work for anything other than Calendar.ISO. The prime example would be Timex.shift/2.
Timex should either amend those functions to be correct in case they are called with other calendars, or pattern match on the value and document the functions to only work with Calendar.ISO.

I believe it is documented somewhere that Timex only targets the ISO calendar, but to be fair, that's a legacy thing, before Elixir added support for other calendars.
I'll have to take a look at the Calendar behavior to see what functions exist, and whether things can be ported to support arbitrary calendars, but I suspect that may be non-trivial since shifting in particular is not something supported in the standard library yet, and it is inherently very complex. Hopefully it's not a big change though. I plan to remove all duplication with the standard library in the next major release, so that will reduce the surface area considerably.


Update the Stashcache Overview Page

This rectifies conflicts that exist between the current https://osg-htc.org/about/osdf and https://opensciencegrid.org/docs/data/stashcache/overview/
It contains a union of suggestions by @bbockelm and Frank W.

I'd also like to potentially bring back the architecture section in some form but this is good enough for me right now


Warning in file(con, "r")

Appears to be a very valuable package, but have not been able to get it to work. Install is fine, and Shiny app starts upon runAdjutant(), but upon searching pubmed from the interface, the output the following :

runAdjutant()

Listening on http://<IP_ADDRESS>:5066
Warning: Column PMID joining character vector and factor, coercing into character vector
[1] "Could not retrieve missing abstract"
[1] "Could not retrieve missing abstract"
[...]
[1] "Could not retrieve missing abstract"
Warning in file(con, "r") :
cannot open URL 'https://eutils.ncbi.nlm.nih.gov/entrez/eutils/efetch.fcgi?db=pubmed&id=30798036,30793935,30793933,30793916,30793637,30793006 [...]' [... truncated]
Warning: Error in file: cannot open the connection
85: file
84: readLines
83: FUN
82: lapply
81: EUtilsGet
80: formatData
78:
73: observeEventHandler [C:\Users[...]\Documents\R\win-library\3.5\adjutant\shinyapp/server.R#124]
2: shiny::runApp
1: runAdjutant

I think this is a similar issue to #11 - I am digging into the problem and am trying to reproduce it on my environment.

maybe I'm wrong and I'm saying something stupid but I ran into similar problems in the past with another package. In that case the problems originated from the pubmed server timeout. Could this be the underlying problem? Now I cannot verify it but previously I had identified the origin of the error using a query that produced very few results (less than 10) and verifying that in these conditions the error disappeared. I hope I was helpful and I did not confused your ideas!

That is precisely the error, but I tried to bake in some stuff that could mitigate that to some extent. It also seems that people are getting kicked off more frequently... so something is going on.

take a look at the documentation of the "easyPubMed" package. If I remember correctly it included a Sys.sleep() function to avoid the timeout problem. Maybe that can help to solve the problem with your library.

I also think this is a very valuable package, but it isn't working for me unless I select 10 or fewer results.
I get this message amongst others listed:
Warning in file(con, "r") :
  cannot open URL 'https://eutils.ncbi.nlm.nih.gov/entrez/eutils/efetch.fcgi?db=pubmed&id=NA,30810520&retmode=xml': HTTP status was '429 Too Many Requests'

According to the following, there are stricter limits to the number of queries made without an API key, after May 2018 than before.
https://ncbiinsights.ncbi.nlm.nih.gov/2017/11/02/new-api-keys-for-the-e-utilities/
Perhaps it was tested before May 2018 but since the functionality of the web server and API has changed?

Ah! This helps explain why I can't reproduce the error - I am able to run bigger queries than 10 on my end, but I don't run queries that often and so I didn't seem to be hitting the wall. I'll take a look into incorporating the API key more seamlessly for users, hopefully this will help.

Updated Adjutant to allow for NCBI API Key, also added some more throttles to reduce the requests hitting the server.

Many thanks! The API key and other throttles appear to have fixed the original connection issue.
However now am running into Issue #11 upon clustering (https://github.com/amcrisan/Adjutant/issues/11)...

That error is a bit harder to address because it is difficult for me reproduce - do you have a query that I can try out? Maybe there is something specific that I am not catching. But I am digging into this, trying to make the error happen so I can address it.

Thank you very much for the quick response. I've been using the 'Load an example query' option on the main Search page ((outbreak OR epidemic OR pandemic) AND genom*)), and had reinstalled Adjutant 0.1.0 a few hours ago.; my dplyr version is <IP_ADDRESS>. Here's the console up to the crash:

runAdjutant()

Listening on http://<IP_ADDRESS>:3358
Warning: Column PMID joining character vector and factor, coercing into character vector
Warning: Column PMID joining character vector and factor, coercing into character vector
Warning: Column PMID joining character vector and factor, coercing into character vector
Warning: Column PMID joining character vector and factor, coercing into character vector
Warning: Column PMID joining character vector and factor, coercing into character vector
[1] "These are missing"
[1] "30335311"
Warning: Column PMID joining character vector and factor, coercing into character vector
Warning: Column PMID joining character vector and factor, coercing into character vector
Warning: Column PMID joining character vector and factor, coercing into character vector
Warning: Column PMID joining character vector and factor, coercing into character vector
Warning: Column PMID joining character vector and factor, coercing into character vector
[1] "These are missing"
[1] NA
Warning: Column PMID joining character vector and factor, coercing into character vector
Selecting by n
Joining, by = "word"
Joining, by = "word"
Warning: Column word joining character vector and factor, coercing into character vector
Warning: Error in : object 'nn' not found
88: filter_impl
87: filter.tbl_df
85: function_list[[k]]
83: freduce
82: _fseq
81: eval
80: eval
78: %>%
77: tidyCorpus
73: observeEventHandler [C:\Users\aadourian\Documents\R\win-library\3.5\adjutant\shinyapp/server.R#288]
2: shiny::runApp
1: runAdjutant

That was helpful - the issue is the dplyr version, I had 0.7.8 whereas 0.8.0 has slightly different behaviour for the group_by variable, which is what's causing this error. Working on fixing this now throughout the app and making it be backwards compatible with v 2.7. Closing this particular issue thread, and will pick up the fix in #11


Add KingOnTheStar to kubeflow.member, he is working on mxnet-operator

This change is

I have create some PRs, which can be saw in
https://github.com/kubeflow/mxnet-operator/commits/master

Thanks.
/lgtm
/approve


pkg_resources in jenkinsapi/init.py, imported but is never being used

There is a reference to pkg_resources in jenkinsapi/__init__.py but I don't see it being used anywhere in the code. What is the purpose of this import and should it be included in the first place?

Feel free to fix it. It looks like an unused import.


Enhancement Request: StopRow parameter

I'm a big fan of this project. Any chance you could add a parameter for StopRow? This would help with only importing a certain range of rows (especially when combined with StartRow). It could also be useful for sample testing prior to very large imports (e.g.: test several questionable rows of data quickly to determine if they would impact an import, before actually importing hundreds of thousands of rows). Thanks in advance!

It needs one extra line
If (-not $StopRow) {$StopRow = $Worksheet.Dimension.End.Row}
and 3 replacements of $Worksheet.Dimension.End.Row with $stopRow

I've added -EndRow (alias StopRow, BottomRow) and -StartColumn (alias LeftColumn) & -EndColumn (alias RightColumn)  so you can specify
import-excel -noHeader - top 5 -bottom 10 -left 2 -right 3
https://github.com/jhoneill/ImportExcel/blob/master/ImportExcel.psm1

I have tested this and it does exactly what I need it to now. Thank you very much for the work you have put into this project, and the time you have taken to include the change I requested. I sincerely appreciate it.


Update mrlearning-sharing(photon)-ch5.md

Docs Build status updates of commit 7dfdcc9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/mrlearning-sharing(photon)-ch5.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Study programme] Fix credits view when specials excluded

Discuss  this through when Rapo credits are checked! What is wrong and what should be done?
Too much information is shown when all the specials are excluded? Which one is wrong: table or graph?

e479738a27c5127d7d9de992b3377ce119170e78


Test ledger compatibility

ref: https://github.com/cosmos/ibc-go/pull/6352/files#r1609579273

duplicate


Adding CSV and Pros-Cons prompts

Adding CSV for extracting data
Adding Pros and Cons in a Table Format

Looks good! Thanks for the contribution.

:tada: This PR is included in version 1.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


rename project

some proposals:

verified-sat, verif-sat
formal-sat
lean4sat (don't love that it's only 1 character off from the other LeanSAT; maybe we can convince them to rename theirs to sat4lean, which indicates the goal and difference in intentions)
sat-tools (I like that this indicates it is a very general SAT library, but it doesn't say anything about verification)

would appreciate more thoughts!

lean4sat and sat4lean would be good naming if everybody agreed!


PI-1592:Passing business service to demand,bill update apis.(PR from Punjab Impl team)

duplicate PR


Do not install examples in site-packages

Thanks @cgohlke, but this has already been fixed. If you install the latest version from pypi you shouldn't get any examples in site-packages. But please let me know if I'm missing something.


How to load a custom model

Hi, thank for great repo, I wanna ask you how to load a custom EfficientNet model using Pytorch? :D

You can load using .from_pretrained  or with .load_state_dict as in usual PyTorch code.
Here's a Colab: https://colab.research.google.com/drive/1JLisFMRI8rxm5TUvbcUmZBmAKUcohyvF?usp=sharing
I'm going to close this issue, feel free to re-open it if you have any questions.


Feature/jbm/module10

I've made changes based on the last comments. Although it's better, there are still issues in unity.

So I see you've been modifying these game objects for spawning and testing etc.

However, if you do you have to remember to Override the base prefab. To do this from scene, you want to click on the object thats tied to a prefab, in this case Explosion. Click override and here you can either pick and choose which change to revert to the base prefab (in case you make a mistake) or apply to the base prefab so it affects any duplicates, or in our case updates the object we want to spawn. If its the most up-to-date prefab, then quickest way is to hit apply all.

Usually when I edit base items, I like to open the prefab on its own so I don't have to worry about overrides, but that's just my personal taste.
So when I dove into Explosions prefab you can see that its missing the animator and new additions. that's because the override has been applied. The networkManger talks to the ones in the assets so you would expect to see bugs or missing items than the ones you see in game.

you would definitely want to update all your prefabs

You're spawners need to reference the asset prefab on file, not in scene for it to work properly, Click and drag them onto the script. Anything that we are creating like spawning dynamically we will always want to point to the one in our resources.

Here's a quick way to reposition anything in Unity, I like to use the GameObject Tab up top > Move To View, when I want to move something. So for example using your spawners as example, lets say I want them to be near the playing field....
I first focus the camera to the ground by double clicking it in the scene's hagiarchy, the camera should move.

Then I single click the target I want, in this case the root of your spawners, and click move to view

then all you need to do is some easy tweaking

ServerPlayerPrefab RigiBody has frozen X and Z positions, need to unfreeze them by unchecking the boxes

-I put the ammo pick up into the Tnt spawner for 2 of the Tntspawners and It spawns. So, that issue is fixed and the player can pick them up but now it seems like its a problem with the collision of objects with the ground plane because it's like a item floating in water physic about it.

Please look at the small changes and not the changes pt 2. The same issues are there but the small thing like getting ammo to spawn and the explosion not working anymore is fixed.

Sorry for all the comments, but I fixed the visible circles issue for the TNTSpawners

you want to make sure there's only one script per object, if they spawn at the same time they, since they use the relative transform point of the game object, they will instantly collide.  I would also move the spawning a little bit higher over the ground plane

to make it less "watery" its because the mass of the ground plane is 1, make it heavier

You've tagged 3 Prefabs with the tag "Player", considering our logic with collision is dertermined around these tags we want to ensure only players have that tag, right now you are getting null exceptions because all the interactive objects are trying to pull non-existent bullet spawners as it trys to add ammo or do damage, etc. You need to remove these tags on these prefabs

The version I pulled still had a typo, make sure its lowercase like this, or double check if it matches with the animator it talks to

I believe after all those changes and tweaks you should have most of the core features done.

Bullet Prefab is missing script and needs some tweaking

Still missing projectile script from bullet prefab, bullets cannot work without this script in the main prefab.


[Bug]: useSubmitImpl() not respects incoming query search when using POST

My first contribution. This tests shows the bug explained on #927

Ah, the real problem here is that useFormAction() doesn't preserve the search params.
Your current solution is just always grabbing the current URL's search params, which is not what we want, it's the form that determines the action we're posting to, not the current page.
The mixup is that <Form> and <Form action="."> default to the current URL, and the bug is that it's not preserving the search params.
If you do <Form> or <Form action="."> at "/some/url?q=1" then the resulting HTML should be <form action="/some/url?q=1">.
That logic is in useFormAction. Want to take a stab at getting it fixed there?

Actually this seems to go deep. @chaance can you look into this? I think this is busted all the way back into React Router, useResolvedPath isn't preserving the search param
https://github.com/remix-run/react-router/blob/7aa62850ec86ddaf70b9ac7ec81dc76ce1254cf4/packages/react-router/index.tsx#L608-L620

The behavior in React Router is as intended. I'll take a look at this tomorrow morning and make sure we get it fixed.

@ryanflorence Ok.
@chaance May be I can refactor my PR to be only the test, and leave the fix at your charge? Here to help.

@jacargentina That would actually be quite helpful, thanks! I'll be adding a few more tests as well.

I made this little contraption to work around that problem for the time being:
import { useFormAction, useSearchParams } from '@remix-run/react'

/**
 * Hook to work around https://github.com/remix-run/remix/pull/931
 */
export default function useFormActionWithSearchParams(to: string = '.') {
  const actionUrl = new URL(useFormAction(to), 'http://localhost')
  const [actionSearch] = useSearchParams()

  const combinedSearch = new URLSearchParams({
    ...Object.fromEntries(actionUrl.searchParams),
    ...Object.fromEntries(actionSearch),
  })

  return actionUrl.pathname + '?' + combinedSearch.toString()
}

<Form action={useFormActionWithSearchParams()} >

🤖 Hello there,
We just published version v1.6.8 which includes a fix for this. If you'd like to take it for a test run please try it out and let us know what you think!
Thanks!


Support configuring public keys for verifying signature

In progress, @Andreea-Lupu  to provide the PR.

Also document how to configure zot for verifying image signatures (example, and .md files).
The initial implementation was already merged in https://github.com/project-zot/zot/pull/1344

Work is done for local storage. AWS/S3 alternatives are still WIP as part of #1485

AWS/S3 alternatives are still WIP separate from #1485

Fixed in https://github.com/project-zot/zot/pull/1744


Update user password

Create new component that will allow user to update their password.

Hi, can you give me more info? how it should look ? I was thinking about the same way as login / sign in popup. What do you think ?


az dls upload hangs on multi chunk uploads

Description
Introduced by https://github.com/Azure/azure-data-lake-store-python/issues/187 in dls 0.0.15
This will require updating to next version on dls sdk once https://github.com/Azure/azure-data-lake-store-python/pull/189 gets in.

This has been fixed as mentioned in the description after version 0.0.15.


Repository move announcement

On Monday, October 4th, the viewer-components-react repo will be transferred to the iTwin Platform organization on Github.
All branches, pull requests, issues, and discussions will be transferred along with the repository, and all links to the old repository will redirect to the new repository which will be found at https://github.com/iTwin/viewer-components-react.
Once the move is complete, we recommend that you update the git origin in your local copy of the repo to the new repository location using:
git remote set-url origin https://github.com/iTwin/viewer-components-react.git

The viewer-components-react repo has been successfully transferred to the iTwin Platform organization. Please use this thread if you experience any issues related to the transfer.

@skirby1996 I seem to have lost the ability to push a new branch to this repo

going to close this out. If anyone has issues, please just leave a comment.


Trying to understand why it is not simply stikethrough "examples"

To reproduce:
from redlines import Redlines

def main():
    text1 = f"This is a sentence\n\nexamples"
    text2 = f"This is a sentence"

    redlined = Redlines(text1, text2)
    result = redlined.output_markdown
    result = result.replace('¶','

')
    with open('text.html', 'w', encoding='utf-8') as file:
        file.write(result)

if __name__ == '__main__':
    main()

Result:
This is a sentence
examplessentence
This is a sentence

 examplessentence

Might be something to do with the word tokeniser.
Needs investigation.

A kludgy solution is to write a magic string (i.e. something that does not naturally exist in a text - for instance 'xx2yyjjkkll4324')  after a paragraph and filter it after redlining.

Investigators gonna be investigating:
Table shows various tokenisers and their outputs and expected redlines.

Method
Test sequence 1
Test sequence 2
Expected redline

Original redlines
['This ', 'is ', 'a ', 'sentence¶examples']
['This ', 'is ', 'a ', 'sentence']
This is a sentence¶examplessentence

tiktoken
[2028, 374, 264, 11914, 271, 52768]
[2028, 374, 264, 11914]
This is a sentence \n\nexamples

spacy (en_core_web_sm)
[This, is, a, sentence, \n\n , examples]
[This, is, a, sentence]
This is a sentence \n\nexamples

GPT2 (through HF)
[1212, 318, 257, 6827, 198, 198, 1069, 12629]
[1212, 318, 257, 6827]
'This is a sentence \n\nexamples'

Seems that BPE tokenisers give more consistent output (although they require you to download a model).
Should we change the tokenizer? Or give others an option to choose between the regex solution or the BPE one? :thinking:


fix(docs): corrects typo in project README

Scope of change is restricted to docs only.

Coverage remained the same at 62.579% when pulling 38d2497f9d8fac04b3837aea7e00bf216aab79ad on plan-do-break-fix:Typo-correction into 10ed07db7fa03a3667a276d55514c999e8c9ab72 on shutterstock:master.

thanks!


HBASE-27368 Do not need to throw IllegalStateException when peer is n…

…ot active in ReplicationSource.initialize

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.


Need a way to insert x-kubernetes-preserve-unknown-fields: true into CRD

Gamma needs the ability to accept complex schemas in a CRD that is beyond cue's capability.
For a CRD I would like the ability to have, similar the Crossplane's XRD
                    schema:
                      properties:
                        openAPIV3Schema:
                          description: OpenAPIV3Schema is the OpenAPI v3 schema to
                            use for validation and pruning.
                          type: object
                          x-kubernetes-preserve-unknown-fields: true
                      type: object

to be emitted from cue.
I'm told that
openAPIV3Schema: {
	[string]: _
}

Might do it, but alas, no, I get
openAPIV3Schema:
  additionalProperties: {}
  type: object

@bcotton I can't seemto replicate this when using [string]: _, here's my test:
austin@Abra test % cat kinds/test.cue
package kinds

test: {
	kind: "Test"
	group: "test"
	apiResource: {}
	codegen: frontend: false
	codegen: backend: false
	current: "v1"
	versions: {
		"v1": {
			schema: {
				spec: {
					openAPIV3Schema: {
						[string]: _
					}
				}
			}
		}
	}
}
austin@Abra test % grafana-app-sdk version
v0.25.1
austin@Abra test % grafana-app-sdk generate --crdencoding=yaml
 * Writing file pkg/generated/resource/test/v1/test_codec_gen.go
 * Writing file pkg/generated/resource/test/v1/test_object_gen.go
 * Writing file pkg/generated/resource/test/v1/test_schema_gen.go
 * Writing file definitions/test.test.ext.grafana.com.yaml
 * Writing file definitions/test-manifest.yaml
 * Writing file pkg/generated/manifest.go
austin@Abra test % cat definitions/test.test.ext.grafana.com.yaml
kind: CustomResourceDefinition
apiVersion: apiextensions.k8s.io/v1
metadata:
    name: tests.test.ext.grafana.com
spec:
    group: test.ext.grafana.com
    versions:
        - name: v1
          served: true
          storage: true
          schema:
            openAPIV3Schema:
                properties:
                    spec:
                        properties:
                            openAPIV3Schema:
                                type: object
                                x-kubernetes-preserve-unknown-fields: true
                        required:
                            - openAPIV3Schema
                        type: object
                    status:
                        properties:
                            additionalFields:
                                description: additionalFields is reserved for future use
                                type: object
                                x-kubernetes-preserve-unknown-fields: true
                            operatorStates:
                                additionalProperties:
                                    properties:
                                        descriptiveState:
                                            description: descriptiveState is an optional more descriptive state field which has no requirements on format
                                            type: string
                                        details:
                                            description: details contains any extra information that is operator-specific
                                            type: object
                                            x-kubernetes-preserve-unknown-fields: true
                                        lastEvaluation:
                                            description: lastEvaluation is the ResourceVersion last evaluated
                                            type: string
                                        state:
                                            description: |-
                                                state describes the state of the lastEvaluation.
                                                It is limited to three possible states for machine evaluation.
                                            enum:
                                                - success
                                                - in_progress
                                                - failed
                                            type: string
                                    required:
                                        - lastEvaluation
                                        - state
                                    type: object
                                description: |-
                                    operatorStates is a map of operator ID to operator state evaluations.
                                    Any operator which consumes this kind SHOULD add its state evaluation information to this field.
                                type: object
                        type: object
                        x-kubernetes-preserve-unknown-fields: true
                required:
                    - spec
                type: object
          subresources:
            status: {}
    names:
        kind: Test
        plural: tests
    scope: Namespaced

If I change
openAPIV3Schema: {
	[string]: _
}

to
openAPIV3Schema: _

Then I can replicate your issue and I get
                    spec:
                        properties:
                            openAPIV3Schema: {}
                        required:
                            - openAPIV3Schema
                        type: object

I'll look into what's going on in the second case, but can you run my test CUE and see if this works for you? And if it doesn't, please let me know the output of grafana-app-sdk version -v and your OS/version

Sorry, didn't see this comment.
Seems to be when the
openAPIV3Schema: {
	[string]: _
}

is in an a "named" (don't know what cue calls it) type:
This is both:
% grafana-app-sdk version
dev-(HEAD detached at v0.25.2)

grafana-app-sdk version
dev-lts/v0.24

Example:
package kinds

test: {
	kind: "Test"
	group: "test"
	apiResource: {}
	codegen: frontend: false
	codegen: backend: false
	current: "v1"
	versions: {
		"v1": {
			schema: {
				#Version: {
					schema?: {
						customProperties: {
							openAPIV3Schema: {
								[string]: _
							}
						}
					}
				}
				spec: {
					openAPIV3Schema: {
						[string]: _
					}
					versions: [...#Version]
				}
			}
		}
	}
}

Resulting CRD:
kind: CustomResourceDefinition
apiVersion: apiextensions.k8s.io/v1
metadata:
    name: tests.test.ext.grafana.com
spec:
    group: test.ext.grafana.com
    versions:
        - name: v1
          served: true
          storage: true
          schema:
            openAPIV3Schema:
                properties:
                    spec:
                        properties:
                            openAPIV3Schema:
                                type: object
                                x-kubernetes-preserve-unknown-fields: true
                            versions:
                                items:
                                    properties:
                                        schema:
                                            properties:
                                                customProperties:
                                                    properties:
                                                        openAPIV3Schema:
                                                            additionalProperties: {}
                                                            type: object
                                                    required:
                                                        - openAPIV3Schema
                                                    type: object
                                            required:
                                                - customProperties
                                            type: object
                                    type: object
                                type: array
                        required:
                            - openAPIV3Schema
                            - versions
                        type: object
                    status:
                        properties:
                            additionalFields:
                                description: additionalFields is reserved for future use
                                type: object
                                x-kubernetes-preserve-unknown-fields: true
                            operatorStates:
                                additionalProperties:
                                    properties:
                                        descriptiveState:
                                            description: descriptiveState is an optional more descriptive state field which has no requirements on format
                                            type: string
                                        details:
                                            description: details contains any extra information that is operator-specific
                                            type: object
                                            x-kubernetes-preserve-unknown-fields: true
                                        lastEvaluation:
                                            description: lastEvaluation is the ResourceVersion last evaluated
                                            type: string
                                        state:
                                            description: |-
                                                state describes the state of the lastEvaluation.
                                                It is limited to three possible states for machine evaluation.
                                            enum:
                                                - success
                                                - in_progress
                                                - failed
                                            type: string
                                    required:
                                        - lastEvaluation
                                        - state
                                    type: object
                                description: |-
                                    operatorStates is a map of operator ID to operator state evaluations.
                                    Any operator which consumes this kind SHOULD add its state evaluation information to this field.
                                type: object
                        type: object
                        x-kubernetes-preserve-unknown-fields: true
                required:
                    - spec
                type: object
          subresources:
            status: {}
    names:
        kind: Test
        plural: tests
    scope: Namespaced


Failed to collect cluster Default info java.lang.IllegalStateException: Error while creating AdminClient for Cluster Default

I would like to use network_mode: bridge for kafka for being able to reach kafka through localhost:9092 from another service
I'm trying to use the provectus/kafka-ui but when I open the consumers menu I get the following error

my docker-compose.yml file :

  kafka-ui:
    container_name: kafka-ui
    image: provectuslabs/kafka-ui:latest
    ports:
      - 8080:8080
    depends_on:
      - kafka
    environment:
      KAFKA_CLUSTERS_0_BOOTSTRAPSERVERS: kafka:9092
      KAFKA_CLUSTERS_0_JMXPORT: 9997

  kafka:
    image: johnnypark/kafka-zookeeper
    ports:
      - "2181:2181"
      - "9092:9092"
    network_mode: bridge
    environment:
      ADVERTISED_HOST: <IP_ADDRESS>
      NUM_PARTITIONS: 1
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock

log error:
2022-01-13 09:16:50,014 ERROR [parallel-5] c.p.k.u.s.MetricsService: Failed to collect cluster Default info
java.lang.IllegalStateException: Error while creating AdminClient for Cluster Default

Failed to collect cluster Default info java.lang.IllegalStateException: Error while creating AdminClient for Cluster Default

Hi, thanks for reaching out.
In this case you could connect to kafka via docker internal host. You can find an example here: https://github.com/provectus/kafka-ui/discussions/1081

Hi Thank you for your answer.
Now I'm getting this error: ERROR: The Compose file '.\docker-compose.yml' is invalid because:
services.kafka-ui.extra_hosts contains an invalid type, it should be an object, or an array

Please share your current file

  kafka-ui:
    extra_hosts: host.docker.internal:host-gateway
    container_name: kafka-ui
    image: provectuslabs/kafka-ui:latest
    ports:
      - 8080:8080
    depends_on:
      - kafka
    environment:
      KAFKA_CLUSTERS_0_BOOTSTRAPSERVERS: kafka:9092
      KAFKA_CLUSTERS_0_ZOOKEEPER: kafka:2181
      KAFKA_CLUSTERS_0_JMXPORT: 9997

  kafka:
    image: johnnypark/kafka-zookeeper
    ports:
      - "2181:2181"
      - "9092:9092"
    network_mode: bridge
    environment:
      ADVERTISED_HOST: <IP_ADDRESS>
      NUM_PARTITIONS: 1
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock```

This is indeed has to be an array while it is not.
  kafka-ui:
    extra_hosts:
      - host.docker.internal:host-gateway
    container_name: kafka-ui
    image: provectuslabs/kafka-ui:latest
    ports:
      - 8080:8080
    depends_on:
      - kafka
    environment:
      KAFKA_CLUSTERS_0_BOOTSTRAPSERVERS: kafka:9092
      KAFKA_CLUSTERS_0_ZOOKEEPER: kafka:2181
      KAFKA_CLUSTERS_0_JMXPORT: 9997

  kafka:
    image: johnnypark/kafka-zookeeper
    ports:
      - "2181:2181"
      - "9092:9092"
    network_mode: bridge
    environment:
      ADVERTISED_HOST: <IP_ADDRESS>
      NUM_PARTITIONS: 1
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock

Now I'm getting this error:
ERROR: yaml.parser.ParserError: while parsing a block mapping
in ".\docker-compose.yml", line 1, column 1
expected , but found ''
in ".\docker-compose.yml", line 18, column 3

You're missing a version and services entries.
Use this file as an example.

i still get this error :( :
ERROR [parallel-1] c.p.k.u.s.MetricsService: Failed to collect cluster Default info
java.lang.IllegalStateException: Error while creating AdminClient for Cluster Default

Guess you still haven't altered the advertised host as described in https://github.com/provectus/kafka-ui/discussions/1081.
Your kafka is being advertised on localhost only, which is invalid, you have to change it to your hostname's IP address.

I changed the docker-compose.yml file as follows but I still get the same error
kafka-ui:
    extra_hosts:
      - host.docker.internal:host-gateway
    container_name: kafka-ui
    image: provectuslabs/kafka-ui:latest
    ports:
      - 8080:8080
    depends_on:
      - kafka
    environment:
      KAFKA_CLUSTERS_0_BOOTSTRAPSERVERS: kafka:9092
      KAFKA_CLUSTERS_0_ZOOKEEPER: kafka:2181
      KAFKA_CLUSTERS_0_JMXPORT: 9997

  kafka:
    image: johnnypark/kafka-zookeeper
    ports:
      - "2181:2181"
      - "9092:9092"
    network_mode: bridge
    environment:
      ADVERTISED_HOST: host.docker.internal
      ADVERTISED_PORT: 9092
      NUM_PARTITIONS: 1
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock

ERROR [parallel-1] c.p.k.u.s.MetricsService: Failed to collect cluster Default info
java.lang.IllegalStateException: Error while creating AdminClient for Cluster Default

ADVERTISED_HOST should be your machine's real IP, not a placeholder.

we run the same docker configuration on different machines, how will the IP work in this situation

Why do you need network_mode: bridge in the first place? You could connect to kafka via exposed port.

I don't know is there any way I can do this without changing the network_mode?

I suggest you pick our example docker-compose with everything you need as a start. The kafka itself there is exposed on port 9092 and is accesible for other containers via kafka0:29092 and from outside of a container via localhost:9092.

I am going to try.  Many thanks for your advice, time and patience. :octocat: 🌟

You're welcome! Feel free to join us on discord if you have any other questions.

When I tried the way you said it worked but I can't see my old topics.
What should I do for this?