1.14 support

I'm trying to make a Realistic Minecraft, and all the mods and recourse packs are using version 1.14. The reason I want this mod in my mod pack is to make the trees fall realistically. None of the other mods recreated the same effect, so I decided to use this one. If the team releases a 1.14 version, it would be a big help.
I have tried force running it, but it crashed. I don't know any other thing to try, so I'm asking for this version.
If you find any mod that replicates the effect, or release a version of this mod that only has the falling tree effect, please inform me.

We are not back porting to other versions. Either use 1.12 or update to 1.16.5.

are there any realistic texture packs for 1.12 then?

I imagine there are tons for both versions but I don't know of any specific ones.

I was thinking urban recourse pack, but it was not for 1.12, so if you can give me any mods that make the tree fall, that could also help. Or like I said in the question, would it be possible to make a version of the mod with only the falling effect?

No. If you’re so keen on using this resourcepack specifically why not just port it yourself?
Anyway, I’m sorry but this is not a search engine. Do your own research.

Ok thank you!


Useless verbose if condition

https://github.com/memcached/memcached/blob/7d6907e659d60512abe7db2154bae039caddee32/items.c#L1008
This if condition is never expanded, what is its purpose?

That's a good one, thanks! Probably snuck in during a refactor.


refactor(pitch): ♻ extract reference static constant

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1127

Relevant Lines:
1127

💛  - Coveralls


ERR_PROXY_CONNECTION_FAILED (-130)

Hi,
Since 3 days, i'm not able to connect to my society Mattermost server with my Mattermost Desktop 4.2.0 (same with 4.1.2 version).
Before, it was working like a charm.
I can't find the reason why the problem suddently occured.
The message on this white page is :

Cannot connect to Mattermost
We're having trouble connecting to Mattermost. If refreshing this page (Ctrl+R or Command+R) does not work please verify that:
Your computer is connected to the internet.
The Mattermost URL https://mattermost.dockr.bluexml.com/mysociety is correct.
You can reach https://mattermost.dockr.bluexml.com/mysociety from a browser window.
ERR_PROXY_CONNECTION_FAILED (-130)

When i try to access the server from a browser, all is ok.
I'm working on Mageia (ex-Mandriva) and I doesn't have any proxy setting.
Do you have an idea of a configuration which could help me to resolve this issue ? Or how I could see some error logs ?
Thanks

@mavidot Hi there. thanks for your report. In order for me to try to reproduce the issue, would you mind answering:

whether you use Mageia 6.1 or any older version?
from where did you download and install the Desktop app from?
if I still have issues reproducing the issue, getting ready to create a test account on your instance.
are you running the EE edition of Mattermost?

Ok, I have resolved the issue this weekend. It was not about mattermost. It was the "Network Manager" tool of Mageia which was broken and did not want to start. It was neither stopped or started. It was on an intermediate state. And I don't know why a proxy configuration was set inside of it (I have never done this).
But now, the Mageia Network Manager is OK, I have disabled the proxy configuration and all is OK.
Thank's for attention.
Have a nice day because Mattermost is healthy :-)


Create Browser Application and Dockerfile #75

What it does

create a dedicated browser application
adapt product so that frontend code is useable from browser app as well
move electron:rebuild to laters stage to avoid conflicts between both applications
Create Dockerfile with Github Workflow and adapt Readme

How to test

Check whether electron based app is still working
Test browser application with yarn browser start
Test Dockerfile and image with instructions from Readme

Review checklist

[x] as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

noticed however that there's a mismatch between the plugins of the electron and browser app. In particular the 'vscode.git' extension stood out to me, as I recall it might be broken in Theia (at least for the electron version).

That's correct. I can confirm that the browser version is affected by the same problem:
https://github.com/eclipse-theia/theia/issues/12173

Thank you for the update! The changes look good and work well for me.

Regarding the windows verification Job. This was failing with "out of heap" errors on the github verification Jobs. Increasing the heap using the node options did not help. It was working locally in my Windows VM however.
My solution is to stop running the prepare-step in parallel, so the browser and electron app are built after each other now.

FYI, the issue with vscode built-in git is supposed to be fixed, so we could switch to using them, if we want: https://github.com/eclipse-theia/theia/pull/12295


[Suggestion] Allow use of const enum values in computed properties in type literals and interfaces

Considering how const enum operates at compile-time, it seems odd that the following is not valid:
const enum Ids {
    alpha = 1
}

interface Foo {
    [Ids.alpha]: string
}

when it should be precisely equivalent to:
interface Foo {
    [1]: string
}

which compiles just fine.
Proposal
Allow const enum values to be used in computed property specifiers in interface declarations and type literals, just as well-known symbols are today.

#10770 / #5579

Ah, I missed #10770 because I was filtering on currently open issues, and then #5579 didn't reference const enums in the description.


add https://polygonjs.com in webgl

Hello,
I'd like to suggest Polygonjs, a WebGL design tool, if that's okay.
Don't hesitate if you have any questions,

thanks v much!


Automatically rename columns which name would collide with a keyword

During inference, if a column has the same name as a Rust keyword,
automatically rename it to the {column}_ in diesel print-schema and
infer_schema! and add the corresponding #[sql_name] attribute

cc #967 #342

This behavior should be mentioned in the docs for infer_schema!


Can we perform server-side pagination/searching/sorting using SlickGrid ?

Hi,
I am very new to SlickGrid. Pardon me if this is a silly question. But I wanted to know, if it is possible to perform server-side pagination using SlickGrid.
I have just been assigned a new project and it is running on SlickGrid. It seems to be working fine but when we have a very large data from the server-side, the API response seems to be lagging and hence the delay in result.
So, if anyone can guide me how to go about this situation and does SlickGrid provides any out of the box API to perform these things ?

Firstly, you might want to look at my [repo] (https://github.com/6pac/SlickGrid). This one is about two years out of date.
Server side paging can be done with AJAX, look at http://6pac.github.io/SlickGrid/examples/example6-ajax-loading.html


New install not working

The command '/bin/bash -o pipefail -c apt-get install -y chromium ffmpeg git' returned a non-zero code: 100

please fix ;)

Hello, in order to help you, please provide the docker logs.

docker logs inside HA?
Please tell me how.

Logger: homeassistant.components.hassio
Source: components/hassio/websocket_api.py:138
Integration: Home Assistant Supervisor (documentation, issues)
First occurred: 18 september 2023 om 09:37:44 (9 occurrences)
Last logged: 08:50:55

Failed to to call /addons/06c15c6e_whatsapp/install - The command '/bin/bash -o pipefail -c apt-get install -y chromium ffmpeg git' returned a non-zero code: 100
Failed to to call /store/repositories - Can't add https://github.com/gajosu/whatsapp-ha-addon, already in the store
Failed to to call /addons/f4fdf59d_whatsapp_addon/stats - Container addon_f4fdf59d_whatsapp_addon is not running
Failed to to call /addons/reload -
Failed to to call /addons/06c15c6e_whatsapp/install - string index out of range

E: Failed to fetch http://deb.debian.org/debian-security/pool/updates/main/c/chromium/chromium-common_116.0.5845.110-1%7edeb11u1_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://deb.debian.org/debian-security/pool/updates/main/c/chromium/chromium_116.0.5845.110-1%7edeb11u1_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://deb.debian.org/debian-security/pool/updates/main/c/chromium/chromium-sandbox_116.0.5845.110-1%7edeb11u1_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

Removing intermediate container 4c0e2559f5b6

23-09-19 10:07:33 INFO (MainThread) [supervisor.homeassistant.api] Updated Home Assistant API token
23-09-19 10:09:27 INFO (MainThread) [supervisor.homeassistant.secrets] Request secret github
23-09-19 10:14:34 INFO (MainThread) [supervisor.homeassistant.secrets] Request secret github
23-09-19 10:19:41 INFO (MainThread) [supervisor.homeassistant.secrets] Request secret github
23-09-19 10:24:47 INFO (MainThread) [supervisor.homeassistant.secrets] Request secret github
23-09-19 10:29:54 INFO (MainThread) [supervisor.homeassistant.secrets] Request secret github
23-09-19 10:30:04 INFO (MainThread) [supervisor.docker.addon] Starting build for 06c15c6e/amd64-addon-whatsapp:2.3.7

this is the problem
E: Failed to fetch http://deb.debian.org/debian-security/pool/updates/main/c/chromium/chromium-common_116.0.5845.110-1~deb11u1_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://deb.debian.org/debian-security/pool/updates/main/c/chromium/chromium_116.0.5845.110-1~deb11u1_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://deb.debian.org/debian-security/pool/updates/main/c/chromium/chromium-sandbox_116.0.5845.110-1~deb11u1_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]

I have updated the base image 5a9281bbe0d8f3d1607b319ccd4b90b50a60b239 possibly this will fix the problem.

thanks but still a problem..

23-09-21 20:52:05 INFO (MainThread) [supervisor.docker.addon] Starting build for 06c15c6e/amd64-addon-whatsapp:2.3.7
23-09-21 20:52:17 ERROR (MainThread) [supervisor.docker.addon] Can't build 06c15c6e/amd64-addon-whatsapp:2.3.7: The command '/bin/bash -o pipefail -c npm install npm@latest -g' returned a non-zero code: 127
23-09-21 20:52:17 ERROR (MainThread) [supervisor.docker.addon] Build log:
Step 1/20 : FROM ghcr.io/hassio-addons/debian-base:7.1.0
 ---> 0c8b93657ca1
Step 2/20 : ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
 ---> Using cache
 ---> 350402e40884
Step 3/20 : RUN apt-get update && apt-get install -y curl gnupg2 && curl -sL https://deb.nodesource.com/setup_14.x | bash - && apt-get install -y nodejs git
 ---> Using cache
 ---> 76877d6838a5
Step 4/20 : RUN apt-get install -y chromium ffmpeg git
 ---> Using cache
 ---> 8b7815ae5411
Step 5/20 : COPY rootfs /
 ---> Using cache
 ---> e4aa26964315
Step 6/20 : WORKDIR /app
 ---> Using cache

any update? @gajosu

any update? @gajosu

@gajosu still no fix?

I've just updated the node version to 18, this has allowed the workflow of the build to pass, it's possible that this change will solve your problem.

Hi @gajosu , still not able to install :(

In theory, the new base image solves the problem, I can release a minor version for you to test, even if the previous image is being applied.

Thank you, it's working just fine now.
The update did indeed the fix


MusicGen text encoder substitution

Question
How to apply my text encoder into the MusicGen model?
My Understanding of the MusicGen Model
In case my question is unclear due to my understanding of the model is wrong, please correct me.

Input the text into a T5 model, and save its hidden state.
Put the hidden state we just got into a Transformer, and we get EnCodec tokens.
Feed the Encodec tokens to the Encodec Decoder, and we get music.

What I want to do
Replace the T5 encoder with what I trained, supposing that the feature is still the same for the same music target.

For anyone who wants to do that, I think the answer is to modify the T5EncoderModel loading function here


Adding a better error message for user defined functions

An attempt to addresses #58.

@odow @mlubin

Is it easy to add a test case for this?

Sure.  How does one catch warnings in Base.test?

Once I merge the other PR and we switch to Base.Test instead of FactCheck: @test_throws Exception func_that_throws()

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is 0%.

@@         Coverage Diff          @@
##           master   #70   +/-   ##
====================================
  Coverage       0%    0%
====================================
  Files           4     4
  Lines         644   646    +2
====================================
- Misses        644   646    +2

Impacted Files
Coverage Δ

src/nl_write.jl
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b0988...7cbd39d. Read the comment docs.


bugfix: fix return code when pull image occurred error

Signed-off-by: HusterWan<EMAIL_ADDRESS>1.Describe what this PR did
fix return code when pouch pull image occurred error
2.Does this pull request fix one issue?
fixes https://github.com/alibaba/pouch/issues/237
3.Describe how you did it
4.Describe how to verify it
[root@docker-registry github.com]# pouch pull docker.io/library/centos:ttt
docker.io/library/centos:ttt: resolving      |--------------------------------------|
elapsed: 0.4 s                total:   0.0 B (0.0 B/s)
Error: failed to pull image: docker.io/library/centos:ttt not found
[root@docker-registry github.com]# echo $?
1

5.Special notes for reviews

Thanks for your work. I suggest you could add this email<EMAIL_ADDRESS>in your github settings. Then github will detect you are not the-first-time-contributor and you can be list in the contributor list of pouch, since github uses emails to check this.
In addition, in the PR description, if this PR fixes some issue, you should fixes #num, then if the pr is merged, github will automatically close issue num. If you just add #num , no auto-close will happen.
@HusterWan

LGTM

@allencloud thanks for your guide, i have reconfigured my github setting

LGTM
Thanks a lot. @HusterWan


Add optional simple lure attraction feature

👍
@TheSavior review, please.

Can someone explain what lure attraction is, in this context - what the feature enables?

What is "help to test" ? i can do something for help the integration ?

@MFizz Patch for move_to_fort for enable "lure_attraction". You already include some of my code in your PR about cluster (lambda lure selection) but this patch dont do the same of your : bot will be attracted by lure and not go directly on lure.
Sorry for

@z4ppy it means that we want more ppl to test for some time before merging.

I love it :+1:

@MFizz it's just a normal MoveToFort but giving priority to fort with lures.

@MFizz maybe we can merge both PR, using yours clusters points (very nice work) injected in move_to_fort with a new abstract attraction feature (cluster/lure/other). What do you mean about that ?

@z4ppy @MFizz's task is isolated and can be combined with yours. It's better to keep each task isolated like we have now.

I agree : i mean about many task for waypoint/attraction/map generation and some navigators for consume it (spiral, move_to_fort, ...). Too many navigator can't works (i mean), we will see some priority problem with the current system (who can preempt first ?)

Works pretty great - moviing from lure to lure and catching a lot of pokemon on the way :+1:

working great :+1:

I have an error, or maybe I do it wrong...
Traceback (most recent call last):
  File "pokecli.py", line 39, in <module>
    from pokemongo_bot import logger
  File "/Users/user/PokemonGo-Bot/pokemongo_bot/__init__.py", line 14, in <module>
    from cell_workers import PokemonCatchWorker, SeenFortWorker, MoveToFortWorker, InitialTransferWorker, EvolveAllWorker
  File "/Users/user/PokemonGo-Bot/pokemongo_bot/cell_workers/__init__.py", line 5, in <module>
    from move_to_fort_worker import MoveToFortWorker
  File "/Users/user/PokemonGo-Bot/pokemongo_bot/cell_workers/move_to_fort_worker.py", line 2, in <module>
    from pokemongo_bot.constants import Constants
ImportError: No module named constants

please add slow down/camping near a fort with lures, to incerase possibility to catch pokemon


frontend: config.example.js could work better with default docker-compose settings

Just after cloning this project, and (stupidly?) following the README's instructions to simply copy config.example.js over to config.js, and then launching docker-compose up --build, we encounter 404s in the frontend as it attempts to reach the backend on the wrong port.
Suggestion is to make the example config a bit nicer out of the box, by harmonizing its settings with the values defined in the docker compose file.
Sample patch removed the 404s:
--- a/frontend/app/config.example.js
+++ b/frontend/app/config.example.js
@@ -21,7 +21,11 @@ const isDev = !(isProd || isTest)
 const LOGGING_ENABLED = isDev
 const LOG_LEVEL = DEBUG

-const SERVER_URL = '' // set this if your API server is different from the frontend server
+const backendPort = process.env.API_PORT || 5000
+const backendHost = process.env.API_HOST || 'localhost'
+
+// change this if your API server is different from the frontend server
+const SERVER_URL = `http://${backendHost}:${backendPort}`

 const SITE_NAME = 'Flask React SPA'
 const COPYRIGHT = 'Company Name'

@briancappello ok, I pushed
https://github.com/briancappello/flask-unchained/pull/8
Since the original issue I was talking about here is resolved by your latest commits, I'll close this one out.
Thanks!


New version: GovernmentOfThePRC.GuangdongProvince.YueZhengYi version …

…3.0.53000.92

https://github.com/microsoft/winget-pkgs/pull/198782#discussion_r1884676840

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

https://github.com/microsoft/winget-pkgs/pull/198782#issuecomment-2541342488


Fix _load_model loading errors when cfg.LIB=="TF" and DocTr is used

When pytorch and tensorflow are available at the same time and cfg.LIB=="TF", the use of doctr will load the zip model file of tensorflow by torch.load in _load_model.

Thanks for spotting the issue and providing a fix!


Command_L to Control_L (only in Terminal) interfering with ⌘␣ Spotlight invocation

I'd like to see the *“Command_L to Control_L (only in )” settings special-case ⌘␣, such that it's still passed to the system to invoke Spotlight.
Pending this being implemented, is there an easy way to special-case or exclude particular key-combinations from that functionality, when it is enabled?

Please use new setting that will be added by this private.xml:
https://github.com/tekezo/Files/blob/master/Karabiner/private.left_command_to_left_control_terminal/private.xml
How to use private.xml:
https://pqrs.org/osx/karabiner/document.html#privatexml

@tekezo I've improved upon this somewhat:
https://gist.github.com/ELLIOTTCABLE/e353793e628467ff45c1
Unfortunately, I'm running into the following issue: with ⌘␣ and ⌘⇧␣ remapped, I still can't cycle in both directions through the app-switcher; after ⌘␣'ing, as soon as I hit ⇧, the app-switcher closes before I can hit ␣ again to move backwards through the switcher.
Here's what EventViewer has to say about it:
eventType:keyMod          code:0x0        name:                flags:                                   misc:KeyCode::A	characters:
eventType:keyMod          code:0x3b       name:Control_L       flags:Ctrl                               misc:KeyCode::CONTROL_L	characters:
eventType:keyMod          code:0x38       name:Shift_L         flags:Shift Ctrl                         misc:KeyCode::SHIFT_L	characters:
eventType:keyMod          code:0x3b       name:Control_L       flags:Shift                              misc:KeyCode::CONTROL_L	characters:
eventType:keyMod          code:0x37       name:Command_L       flags:Shift Cmd                          misc:KeyCode::COMMAND_L	characters:

You can solve it by changing shift keys to lazy shift keys.
Please enable following prepared settings:

Shift_L to Lazy_Shift_L
Shift_R to Lazy_Shift_R


Provide example using new Meteor imports directory structure

I'm having some trouble getting useraccounts to work with the new imports directory structure as described in Application Structure.
I've looked at the todos example app, however that app overrides the built-in templates. When I remove the importation of the custom templates, no Sign In form appears. Maybe I need to explicitly import the default built-in templates, but I don't know what to write.
So currently there is no example code that shows how useraccounts, with its built-in templates, can be implemented in Meteor 1.3 with modules.
Please update the boilerplate code to the latest Meteor version and refactor the code to use modules and associated import statements.
Thank you.

I solved my problems (caused by a last-resort "catch-all" route) so I don't need an example anymore. But you should probably update the boilerplates anyway to keep up with Meteor.

@tab00 can you share some code of the catch-all route please?
also did you have to override the templates or did you manage to make the default ones work?
I keep getting "login forbidden" in either case, but I might be missing something

FlowRouter.route('/:id', { action(params, queryParams) { BlazeLayout.render("App_body", { main: "content" }); } });
This route allows a URL like site.com/idchosenbyuser to be handled (like facebook.com/username or soundcloud.com/channelname). But it also means that site.com/somerubbishtext would be handled by the same route (and you'd need to write extra code to handle the case when such an ID doesn't exist). That's why I call it a catch-all route, because it will catch anything that matches site.com/sometext.
I didn't need to override any default templates. The official Meteor Todos example does some overriding but it's not necessary.


Prompt results in 400 Bad Request

At the moment pretty much every second request I give to copilot results in a 400 Bad Request but requesting the same thing 2 seconds later just works as intended.

System:

(Desktop, Home-Network)

VS Code Version: 1.86.0-insider (user setup)
OS Version: WINDOWS_NT x64 10.0.22621
Logs:

2024-01-12 16:45:02.386 [info] [auth] Logged in as NurRobin
2024-01-12 16:45:02.656 [info] [chat] copilot token chat_enabled: true
2024-01-12 16:45:02.656 [info] [auth] Got Copilot token for NurRobin
2024-01-12 16:53:59.841 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 16:53:59.841 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 16:53:59.841 [info] [chat fetch] chat model gpt-4
2024-01-12 16:54:00.285 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 442 ms
2024-01-12 16:54:00.286 [info] [chat fetch] Request ID for failed request: ,266ad272-13a5-48a3-a780-112a2d819b84
2024-01-12 16:54:00.287 [info] [chat fetch] Unhandled status from server:,400,Bad Request

2024-01-12 16:54:01.920 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 16:54:01.920 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 16:54:01.920 [info] [chat fetch] chat model gpt-4
2024-01-12 16:54:03.683 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 1761 ms
2024-01-12 16:54:19.187 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-12 16:54:19.201 [info] [streamChoices] request done: requestId: [7137bf3d-7989-467f-90bc-93ca7ad72ea7] responseId: [9e323522-b92a-4bf0-8353-ffd23dc76ad6] model deployment ID: [x8d3c95500d67]
2024-01-12 16:54:19.225 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 16:54:19.225 [info] [chat fetch] modelMaxTokenWindow 8192
2024-01-12 16:54:19.225 [info] [chat fetch] chat model gpt-3.5-turbo
2024-01-12 16:54:20.045 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 819 ms
2024-01-12 16:54:20.249 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-12 16:54:20.250 [info] [streamChoices] request done: requestId: [d1a2ac97-ddb8-4b75-8ce2-59c21ab7a1fe] responseId: [2e274667-64e0-425b-a1d1-e807ad1f19d6] model deployment ID: [x338b9c029b38]
2024-01-12 16:57:28.296 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 16:57:28.296 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 16:57:28.296 [info] [chat fetch] chat model gpt-4
2024-01-12 16:57:28.703 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 406 ms
2024-01-12 16:57:28.705 [info] [chat fetch] Request ID for failed request: ,0ab42e6b-3426-452c-ac6a-42fc2ff666d1
2024-01-12 16:57:28.707 [info] [chat fetch] Unhandled status from server:,400,Bad Request

2024-01-12 16:57:32.571 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 16:57:32.571 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 16:57:32.571 [info] [chat fetch] chat model gpt-4
2024-01-12 16:57:35.851 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 3280 ms
2024-01-12 16:57:53.290 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-12 16:57:53.292 [info] [streamChoices] request done: requestId: [3390eeba-1480-4f5d-88da-ad08ff0f6889] responseId: [11b2a728-8cac-4fb5-88d8-c41c9ed53249] model deployment ID: [x8d3c95500d67]
2024-01-12 16:57:53.305 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 16:57:53.305 [info] [chat fetch] modelMaxTokenWindow 8192
2024-01-12 16:57:53.305 [info] [chat fetch] chat model gpt-3.5-turbo
2024-01-12 16:57:54.089 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 784 ms
2024-01-12 16:57:54.199 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-12 16:57:54.200 [info] [streamChoices] request done: requestId: [9b550b2e-43d1-4042-97b4-4e64a327977f] responseId: [ec38e3aa-a1f4-46e5-9327-e0d46b255a24] model deployment ID: [x338b9c029b38]
2024-01-12 16:59:04.903 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 16:59:04.903 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 16:59:04.903 [info] [chat fetch] chat model gpt-4
2024-01-12 16:59:05.037 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 134 ms
2024-01-12 16:59:05.038 [info] [chat fetch] Request ID for failed request: ,1dcbc660-15f9-4d04-86c5-9194619c8bcc
2024-01-12 16:59:05.039 [info] [chat fetch] Unhandled status from server:,400,Bad Request

2024-01-12 16:59:13.925 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 16:59:13.925 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 16:59:13.925 [info] [chat fetch] chat model gpt-4
2024-01-12 16:59:15.701 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 1775 ms
2024-01-12 16:59:32.997 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-12 16:59:32.999 [info] [streamChoices] request done: requestId: [f0ee73d8-b8ec-462f-9ded-7929a91853f0] responseId: [087e4b3a-60ae-4768-8bf0-959f75f6c0d0] model deployment ID: [x8d3c95500d67]
2024-01-12 16:59:33.010 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 16:59:33.010 [info] [chat fetch] modelMaxTokenWindow 8192
2024-01-12 16:59:33.010 [info] [chat fetch] chat model gpt-3.5-turbo
2024-01-12 16:59:34.265 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 1254 ms
2024-01-12 16:59:34.643 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-12 16:59:34.644 [info] [streamChoices] request done: requestId: [3c646d98-0269-41f7-94e2-6a92383b173e] responseId: [eb7b2c6c-ed60-4f75-93fa-99c19ca19df2] model deployment ID: [x338b9c029b38]
2024-01-12 17:00:31.354 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 17:00:31.355 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 17:00:31.355 [info] [chat fetch] chat model gpt-4
2024-01-12 17:00:31.478 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 122 ms
2024-01-12 17:00:31.479 [info] [chat fetch] Request ID for failed request: ,49bda088-2c99-41a1-a514-2788a8c1d0ff
2024-01-12 17:00:31.480 [info] [chat fetch] Unhandled status from server:,400,Bad Request

2024-01-12 17:00:33.022 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 17:00:33.022 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 17:00:33.022 [info] [chat fetch] chat model gpt-4
2024-01-12 17:00:35.436 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 2413 ms
2024-01-12 17:00:49.975 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-12 17:00:49.981 [info] [streamChoices] request done: requestId: [7db28cf5-4180-4003-a869-382f5cd3f8f5] responseId: [da21639b-8577-4c6f-82b7-849822c6f0fd] model deployment ID: [x8d3c95500d67]
2024-01-12 17:00:50.014 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 17:00:50.014 [info] [chat fetch] modelMaxTokenWindow 8192
2024-01-12 17:00:50.014 [info] [chat fetch] chat model gpt-3.5-turbo
2024-01-12 17:00:50.838 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 823 ms
2024-01-12 17:00:50.980 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-12 17:00:50.981 [info] [streamChoices] request done: requestId: [33ddab24-1789-4aa7-b81c-3f7157a3ccde] responseId: [10dc935e-c33d-4e18-8e01-3b552e0d78d9] model deployment ID: [x338b9c029b38]
2024-01-12 17:01:47.267 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 17:01:47.270 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 17:01:47.270 [info] [chat fetch] chat model gpt-4
2024-01-12 17:01:47.485 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 214 ms
2024-01-12 17:01:47.487 [info] [chat fetch] Request ID for failed request: ,e87cc845-460f-4357-9635-a2c8dd424be4
2024-01-12 17:01:47.490 [info] [chat fetch] Unhandled status from server:,400,Bad Request

System:
(Laptop, University-Network)

VS Code Version: 1.86.0-insider (user setup)
OS Version: WINDOWS_NT x64 10.0.19045
Logs:

2024-01-12 17:18:00.779 [info] [FetcherService] Using Helix fetcher
2024-01-12 17:18:00.780 [info] [gitExtensionService] Initializing Git extension service.
2024-01-12 17:18:00.780 [info] [gitExtensionService] Successfully activated the vscode.git extension.
2024-01-12 17:18:00.780 [info] [gitExtensionService] Enablement state of the vscode.git extension: true.
2024-01-12 17:18:00.780 [info] [gitExtensionService] Successfully registered Git commit message provider.
2024-01-12 17:18:02.968 [info] [auth] Logged in as NurRobin
2024-01-12 17:18:03.526 [info] [chat] copilot token chat_enabled: true
2024-01-12 17:18:03.526 [info] [githubTitleAndDescriptionProvider] Initializing GitHub PR title and description provider provider.
2024-01-12 17:18:03.526 [info] [githubTitleAndDescriptionProvider] GitHub.vscode-pull-request-github extension is not yet activated.
2024-01-12 17:18:03.527 [info] [auth] Got Copilot token for NurRobin
2024-01-12 17:18:03.592 [info] [auth] Logged in as NurRobin
2024-01-12 17:18:03.597 [info] [chat] copilot token chat_enabled: true
2024-01-12 17:18:03.597 [info] [auth] Got Copilot token for NurRobin
2024-01-12 17:18:19.015 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 17:18:19.015 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 17:18:19.015 [info] [chat fetch] chat model gpt-4
2024-01-12 17:18:21.122 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 2107 ms
2024-01-12 17:18:22.421 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-12 17:18:22.423 [info] [streamChoices] request done: requestId: [c09d867e-1c3a-4ea9-b6c6-54befa537e39] responseId: [99f04038-bc9c-45c9-b1ac-9597a7b503bb] model deployment ID: [x8d3c95500d67]
2024-01-12 17:18:22.519 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 17:18:22.519 [info] [chat fetch] modelMaxTokenWindow 8192
2024-01-12 17:18:22.519 [info] [chat fetch] chat model gpt-3.5-turbo
2024-01-12 17:18:23.145 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 625 ms
2024-01-12 17:18:23.215 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-12 17:18:23.216 [info] [streamChoices] request done: requestId: [f621c024-ac2b-41b1-879e-01722a02f232] responseId: [50ccf6c3-3c77-464b-b73c-14f017926358] model deployment ID: [x338b9c029b38]
2024-01-12 17:18:30.446 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 17:18:30.446 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 17:18:30.446 [info] [chat fetch] chat model gpt-4
2024-01-12 17:18:30.585 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 137 ms
2024-01-12 17:18:30.586 [info] [chat fetch] Request ID for failed request: ,c67530d8-87c5-4732-b98a-adefa1cbeb34
2024-01-12 17:18:30.588 [info] [chat fetch] Unhandled status from server:,400,Bad Request

2024-01-12 17:18:33.375 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 17:18:33.375 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 17:18:33.375 [info] [chat fetch] chat model gpt-4
2024-01-12 17:18:34.836 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 1460 ms
2024-01-12 17:18:36.362 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-12 17:18:36.364 [info] [streamChoices] request done: requestId: [7eead491-84cc-42d4-b3ef-c5216bf55618] responseId: [753bbd7e-906a-425e-af4b-0c3f443c2fe6] model deployment ID: [x8d3c95500d67]
2024-01-12 17:18:36.370 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 17:18:36.370 [info] [chat fetch] modelMaxTokenWindow 8192
2024-01-12 17:18:36.370 [info] [chat fetch] chat model gpt-3.5-turbo
2024-01-12 17:18:37.152 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 782 ms
2024-01-12 17:18:37.188 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-12 17:18:37.190 [info] [streamChoices] request done: requestId: [3a76e36a-b1b1-4c6b-838a-8ad0bf8232ee] responseId: [a87c820e-1395-40f0-a4a0-4c19dc9ac947] model deployment ID: [x338b9c029b38]
2024-01-12 17:18:39.565 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 17:18:39.565 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 17:18:39.565 [info] [chat fetch] chat model gpt-4
2024-01-12 17:18:39.696 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 130 ms
2024-01-12 17:18:39.697 [info] [chat fetch] Request ID for failed request: ,85ef52cc-7184-4193-a0a8-67fd7d5aa1bf
2024-01-12 17:18:39.698 [info] [chat fetch] Unhandled status from server:,400,Bad Request

2024-01-12 17:18:42.119 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 17:18:42.119 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 17:18:42.119 [info] [chat fetch] chat model gpt-4
2024-01-12 17:18:43.719 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 1600 ms
2024-01-12 17:18:44.750 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-12 17:18:44.752 [info] [streamChoices] request done: requestId: [3f5d7d89-93f1-4f87-83d6-febaf38f3cc9] responseId: [ba3ddb5a-cc53-4e68-94de-ed374696d098] model deployment ID: [x8d3c95500d67]
2024-01-12 17:18:44.758 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 17:18:44.758 [info] [chat fetch] modelMaxTokenWindow 8192
2024-01-12 17:18:44.758 [info] [chat fetch] chat model gpt-3.5-turbo
2024-01-12 17:18:45.523 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 764 ms
2024-01-12 17:18:45.578 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-12 17:18:45.579 [info] [streamChoices] request done: requestId: [e65b4219-8308-4bbd-8341-08af7ca4b368] responseId: [f44dfcac-fe71-4bde-8f6c-8b47aca4b9d0] model deployment ID: [x338b9c029b38]
2024-01-12 17:18:47.721 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-12 17:18:47.721 [info] [chat fetch] modelMaxTokenWindow 4096
2024-01-12 17:18:47.721 [info] [chat fetch] chat model gpt-4
2024-01-12 17:18:47.845 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 124 ms
2024-01-12 17:18:47.846 [info] [chat fetch] Request ID for failed request: ,46e62f1b-a7f1-435f-b06d-212124472d18
2024-01-12 17:18:47.848 [info] [chat fetch] Unhandled status from server:,400,Bad Request

Steps to Reproduce:

Ask Copilot-Chat something
Results in 400 Bad Request

We believe there was a service incident that has since been mitigated. Let me know if you still see this

unless the incident is happening again it seems to be a bigger problem as its happening again

There was a bug in the client, a new version has been released to fix this.

Happening again despite of having the newest version

Can you paste the logs as text instead of as images so I can look up the requests to understand why they failed

024-01-18 22:06:33.526 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-18 22:06:33.526 [info] [chat fetch] modelMaxPromptTokens 3072
2024-01-18 22:06:33.526 [info] [chat fetch] modelMaxResponseTokens 3738
2024-01-18 22:06:33.526 [info] [chat fetch] chat model gpt-4
2024-01-18 22:06:33.971 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 445 ms
2024-01-18 22:06:33.972 [info] [chat fetch] Request ID for failed request: ,7f293cf9-a302-4a56-9a5e-9d56e76b1d12
2024-01-18 22:06:33.972 [info] [chat fetch] Unhandled status from server:,400,Bad Request

2024-01-18 22:08:20.874 [info] [FetcherService] Using Helix fetcher
2024-01-18 22:08:20.874 [info] [gitExtensionService] Initializing Git extension service.
2024-01-18 22:08:20.874 [info] [gitExtensionService] Successfully activated the vscode.git extension.
2024-01-18 22:08:20.874 [info] [gitExtensionService] Enablement state of the vscode.git extension: true.
2024-01-18 22:08:20.874 [info] [gitExtensionService] Successfully registered Git commit message provider.
2024-01-18 22:08:21.402 [info] [auth] Logged in as NurRobin
2024-01-18 22:08:21.722 [info] [chat] copilot token chat_enabled: true
2024-01-18 22:08:21.722 [info] [githubTitleAndDescriptionProvider] Initializing GitHub PR title and description provider provider.
2024-01-18 22:08:21.722 [info] [githubTitleAndDescriptionProvider] GitHub.vscode-pull-request-github extension is not yet activated.
2024-01-18 22:08:21.722 [info] [auth] Got Copilot token for NurRobin
2024-01-18 22:08:21.732 [info] [auth] Logged in as NurRobin
2024-01-18 22:08:21.733 [info] [chat] copilot token chat_enabled: true
2024-01-18 22:08:21.733 [info] [auth] Got Copilot token for NurRobin
2024-01-18 22:08:27.814 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-18 22:08:27.814 [info] [chat fetch] modelMaxPromptTokens 3072
2024-01-18 22:08:27.814 [info] [chat fetch] modelMaxResponseTokens 3738
2024-01-18 22:08:27.814 [info] [chat fetch] chat model gpt-4
2024-01-18 22:08:28.175 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 360 ms
2024-01-18 22:08:28.175 [info] [chat fetch] Request ID for failed request: ,cce02d1f-ced5-4467-b0f7-2efac27214a2
2024-01-18 22:08:28.177 [info] [chat fetch] Unhandled status from server:,400,Bad Request

2024-01-18 22:09:48.331 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-18 22:09:48.331 [info] [chat fetch] modelMaxPromptTokens 3072
2024-01-18 22:09:48.331 [info] [chat fetch] modelMaxResponseTokens 3738
2024-01-18 22:09:48.331 [info] [chat fetch] chat model gpt-4
2024-01-18 22:09:48.476 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 145 ms
2024-01-18 22:09:48.476 [info] [chat fetch] Request ID for failed request: ,bbd1ad17-46ab-488b-80fa-05cefd71ea93
2024-01-18 22:09:48.478 [info] [chat fetch] Unhandled status from server:,400,Bad Request

2024-01-18 22:10:16.213 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-18 22:10:16.213 [info] [chat fetch] modelMaxPromptTokens 3072
2024-01-18 22:10:16.213 [info] [chat fetch] modelMaxResponseTokens 3738
2024-01-18 22:10:16.213 [info] [chat fetch] chat model gpt-4
2024-01-18 22:10:16.349 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 136 ms
2024-01-18 22:10:16.349 [info] [chat fetch] Request ID for failed request: ,3fff1d05-63e4-403b-b0ae-eddd9b8ab55b
2024-01-18 22:10:16.350 [info] [chat fetch] Unhandled status from server:,400,Bad Request

2024-01-18 22:10:40.475 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-18 22:10:40.475 [info] [chat fetch] modelMaxPromptTokens 3072
2024-01-18 22:10:40.475 [info] [chat fetch] modelMaxResponseTokens 3716
2024-01-18 22:10:40.475 [info] [chat fetch] chat model gpt-4
2024-01-18 22:10:41.472 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 997 ms
2024-01-18 22:10:42.377 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-18 22:10:42.378 [info] [streamChoices] request done: requestId: [5612696c-59b3-4161-9142-17fe294a672e] responseId: [5612696c-59b3-4161-9142-17fe294a672e] model deployment ID: [wda6aab3977b]
2024-01-18 22:10:42.496 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-18 22:10:42.496 [info] [chat fetch] modelMaxPromptTokens 7168
2024-01-18 22:10:42.496 [info] [chat fetch] modelMaxResponseTokens 1093
2024-01-18 22:10:42.496 [info] [chat fetch] chat model gpt-3.5-turbo
2024-01-18 22:10:43.548 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 1052 ms
2024-01-18 22:10:43.755 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-01-18 22:10:43.756 [info] [streamChoices] request done: requestId: [5326cadf-6c10-4f99-8aeb-5d2ab7386eeb] responseId: [5326cadf-6c10-4f99-8aeb-5d2ab7386eeb] model deployment ID: [x79f089449d1b]
2024-01-18 22:10:45.080 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-18 22:10:45.080 [info] [chat fetch] modelMaxPromptTokens 3072
2024-01-18 22:10:45.080 [info] [chat fetch] modelMaxResponseTokens 3738
2024-01-18 22:10:45.080 [info] [chat fetch] chat model gpt-4
2024-01-18 22:10:45.209 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 129 ms
2024-01-18 22:10:45.210 [info] [chat fetch] Request ID for failed request: ,fab6e29c-ebc9-4950-ab04-e4f3cce03231
2024-01-18 22:10:45.210 [info] [chat fetch] Unhandled status from server:,400,Bad Request

2024-01-18 22:10:57.286 [info] [chat fetch] url https://api.githubcopilot.com/chat/completions
2024-01-18 22:10:57.286 [info] [chat fetch] modelMaxPromptTokens 3072
2024-01-18 22:10:57.286 [info] [chat fetch] modelMaxResponseTokens 3738
2024-01-18 22:10:57.286 [info] [chat fetch] chat model gpt-4
2024-01-18 22:10:57.425 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 139 ms
2024-01-18 22:10:57.425 [info] [chat fetch] Request ID for failed request: ,d1584e19-9403-4fd8-8b0b-6bb479fc72d9
2024-01-18 22:10:57.426 [info] [chat fetch] Unhandled status from server:,400,Bad Request

Thanks for the logs, this was caused by your query being too long. Better error messaging has been added and will be in the next pre-release tomorrow.


Do not use endpoints to deploy links

@steiler When reviewing #1475 I noticed the indirection you used to deploy links
you called (endpoint).Deploy, which called associated (link).Deploy.
I find this indirection unnecessary, and propose to deploy links directly. For that I store []Link under the node implementation so that we can call (link).Deploy without touching endpoints.
Check this PR, if you're ok with it, I will push it to the existing PR.

this stuff started to break =(
Couldn't figure why, but there seems to be a data race as well
==================
WARNING: DATA RACE
Read at 0x00c000ca0cf8 by goroutine 51:
  github.com/srl-labs/containerlab/nodes.(*DefaultNode).AddNetlinkLinkToContainer()
      /root/srl-labs/containerlab/nodes/default_node.go:407 +0xa4
  github.com/srl-labs/containerlab/nodes/linux.(*linux).AddNetlinkLinkToContainer()
      <autogenerated>:1 +0xe8
  github.com/srl-labs/containerlab/links.(*LinkVEth).Deploy()
      /root/srl-labs/containerlab/links/link_veth.go:159 +0xd1e
  github.com/srl-labs/containerlab/nodes.(*DefaultNode).DeployLinks()
      /root/srl-labs/containerlab/nodes/default_node.go:469 +0x13d
  github.com/srl-labs/containerlab/nodes/linux.(*linux).DeployLinks()
      <autogenerated>:1 +0x76
  github.com/srl-labs/containerlab/clab.(*CLab).scheduleNodes.func1()
      /root/srl-labs/containerlab/clab/clab.go:411 +0x10b1
  github.com/srl-labs/containerlab/clab.(*CLab).scheduleNodes.func3()
      /root/srl-labs/containerlab/clab/clab.go:437 +0xd8

Previous write at 0x00c000ca0cf8 by goroutine 50:
  github.com/srl-labs/containerlab/runtime/docker.(*DockerRuntime).postStartActions()
      /root/srl-labs/containerlab/runtime/docker/docker.go:574 +0x184
  github.com/srl-labs/containerlab/runtime/docker.(*DockerRuntime).StartContainer()
      /root/srl-labs/containerlab/runtime/docker/docker.go:567 +0x684
  github.com/srl-labs/containerlab/nodes/linux.(*linux).Deploy()
      /root/srl-labs/containerlab/nodes/linux/linux.go:56 +0x2a6
  github.com/srl-labs/containerlab/clab.(*CLab).scheduleNodes.func1()
      /root/srl-labs/containerlab/clab/clab.go:405 +0xdf0
  github.com/srl-labs/containerlab/clab.(*CLab).scheduleNodes.func3()
      /root/srl-labs/containerlab/clab/clab.go:437 +0xd8

Goroutine 51 (running) created at:
  github.com/srl-labs/containerlab/clab.(*CLab).scheduleNodes()
      /root/srl-labs/containerlab/clab/clab.go:437 +0x509
  github.com/srl-labs/containerlab/clab.(*CLab).CreateNodes()
      /root/srl-labs/containerlab/clab/clab.go:271 +0x5d0
  github.com/srl-labs/containerlab/cmd.deployFn()
      /root/srl-labs/containerlab/cmd/deploy.go:234 +0x2c24
  github.com/spf13/cobra.(*Command).execute()
      /root/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:940 +0x152f
  github.com/spf13/cobra.(*Command).ExecuteC()
      /root/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:1068 +0xe24
  github.com/spf13/cobra.(*Command).Execute()
      /root/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:992 +0x4f
  github.com/srl-labs/containerlab/cmd.Execute()
      /root/srl-labs/containerlab/cmd/root.go:46 +0x44
  main.main()
      /root/srl-labs/containerlab/main.go:10 +0x29

Goroutine 50 (running) created at:
  github.com/srl-labs/containerlab/clab.(*CLab).scheduleNodes()
      /root/srl-labs/containerlab/clab/clab.go:437 +0x509
  github.com/srl-labs/containerlab/clab.(*CLab).CreateNodes()
      /root/srl-labs/containerlab/clab/clab.go:271 +0x5d0
  github.com/srl-labs/containerlab/cmd.deployFn()
      /root/srl-labs/containerlab/cmd/deploy.go:234 +0x2c24
  github.com/spf13/cobra.(*Command).execute()
      /root/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:940 +0x152f
  github.com/spf13/cobra.(*Command).ExecuteC()
      /root/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:1068 +0xe24
  github.com/spf13/cobra.(*Command).Execute()
      /root/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:992 +0x4f
  github.com/srl-labs/containerlab/cmd.Execute()
      /root/srl-labs/containerlab/cmd/root.go:46 +0x44
  main.main()
      /root/srl-labs/containerlab/main.go:10 +0x29
==================

Even with the data race the simple linux lab with one veth link sometimes deploys, but sometimes fails with
❯ dclab dep -c -t private/linux.clab.yml
INFO[0000] Containerlab v0.0.0 started
INFO[0000] Parsing & checking topology file: linux.clab.yml
INFO[0000] Destroying lab: linux
INFO[0000] Removed container: clab-linux-l1
INFO[0000] Removed container: clab-linux-l2
INFO[0000] Removing containerlab host entries from /etc/hosts file
INFO[0001] Removing /root/srl-labs/containerlab/clab-linux directory...
INFO[0001] Creating docker network: Name="clab", IPv4Subnet="<IP_ADDRESS>/24", IPv6Subnet="2001:172:20:20::/64", MTU="1450"
INFO[0001] Creating lab directory: /root/srl-labs/containerlab/clab-linux
INFO[0002] Creating container: "l2"
INFO[0002] Creating container: "l1"
ERRO[0003] failed deploy links for node "l2": failed to Statfs "": no such file or directory
ERRO[0003] failed deploy links for node "l1": file exists
WARN[0003] Cannot parse export template /etc/containerlab/templates/export/auto.tmpl: template: auto.tmpl:42:22: executing "auto.tmpl" at <$l.A.Node.ShortName>: can't evaluate field A in type links.Link
INFO[0003] Adding containerlab host entries to /etc/hosts file
INFO[0003] 🎉 New containerlab version 0.43.0 is available! Release notes: https://containerlab.dev/rn/0.43/
Run 'containerlab version upgrade' to upgrade or go check other installation options at https://containerlab.dev/install/
+---+---------------+--------------+----------+-------+---------+----------------+----------------------+
| # |     Name      | Container ID |  Image   | Kind  |  State  |  IPv4 Address  |     IPv6 Address     |
+---+---------------+--------------+----------+-------+---------+----------------+----------------------+
| 1 | clab-linux-l1 | 9449dd4ecb53 | alpine:3 | linux | running | <IP_ADDRESS>/24 | 2001:172:20:20::3/64 |
| 2 | clab-linux-l2 | 41de39914ffb | alpine:3 | linux | running | <IP_ADDRESS>/24 | 2001:172:20:20::2/64 |
+---+---------------+--------------+----------+-------+---------+----------------+----------------------+

The file exists for l1 likely is the culprit...

So in my view this is the wrong approach.
Looking at it from a physical perspective, a node has interfaces (Endpoints) and the wire / connection between these interface (Link) connect these nodes.
Endpoints themselfes contain properties, e.g. their state but also the mac address etc. These are all very clear attributes of the a nodes specific interface. By assigning the Link to the node, you again end up in a situation, where you have to first figure out which side of a link in meant to be associated with a certain node, to figure out the relevant attributes.
This specific association will reapper in the case of graphing, where you will also need to know which endpoint is associated to a node.
By implementing it this way, the good thing is, that on e.g. veth links, we will not need any dependency manager any more to deploy the links as soon as both ends of the link are readily deployed.
Overall my vote is clearly against this proposal.

Further I think the part you missed is here:
https://github.com/srl-labs/containerlab/pull/1507/files#diff-d435b691711a25fa1a5f1a75919a459ef9cf34304ac6ccf0e84e3ec008fef543R111-R115
In the original PR, each node calls Deploy in the endpoint. Which first sets the EndpointDeploymentState or so to Ready and then calls deploy in the link. The link then checks if both sides of the link are already in Ready state, because it might be that the other end of the link the endpoints node is not even deployed and running yet.
Only if both endpoints are in ready state the link deployment is good to go.
In your implementation you straight away try to deploy the links on the link.deploy call and thats probably also where one of the races comes from, you'r deploying links twice, like both nodes trigger the link deployment.
Lets stick to the original approach, I strongly beleave it is the right abstraction and provides for the most flexibility when it comes to further development and extensibility.

@steiler do we have a single case where in the original approach endpoint.Deploy doesn't directly cause its associated link.Deploy and does something valuable?
And in my world from a physical pov you don't "deploy" endpoints, you deploy links, which in veth cases have endpoints

No, not yet.

merged into #1475


Update live.tests.yml samples display name to be shorter.

Follow-up to fix https://github.com/Azure/azure-sdk-for-cpp/pull/5818#discussion_r1683273672

/check-enforcer override

/azp run cpp - core - ci


modules-closure: don't ignore all deps if the first is builtin

Motivation for this change
The previous version resulted in modules being omitted entirely
because the first dependency listed for them by modprobe was
built-in. Now, only the actual built-in modules will be ignored when
building the closure.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

~TODO: test if this fixes the issue for me in practice~ it does!
@ofborg test boot

https://github.com/NixOS/nixpkgs/pull/92081/ for prior art

That's much better!


[Bug Report] Datetime-picker not popup when click the button

Mint UI version
2.2.8
OS/Browsers version
mac/chrome
Vue version
2.3.3
Reproduction Link
https://jsfiddle.net/miyalee/pj71jkyw/418/
Steps to reproduce
just run it and click the button
What is Expected?
the picker will show like
https://mint-ui.github.io/docs/#/zh-cn2/datetime-picker
What is actually happening?
nothing happened
comment:
it appear when I update 2.2.7 to 2.2.8, it is work on version 2.2.7, but has console a error,
I have note this<!-- <script<EMAIL_ADDRESS>-->, you can try it
there are some new way to use it? but I didn't see any diff on doc
I use datetime-picker on my company project，please fix it as soon as possible, or tell us how to use, thank you

Fixed in 2.2.9

@Leopoldthecoder 好快！谢谢


Changes to enable compilation under Visual Studio (2015)

Hi,
If you're interested, I am making available some changes I had to make to your very useful zstr library so that it would compile under Microsoft Visual Studio.   Most notably, Microsoft's compiler doesn't recognize and/or/not keywords.
Thanks,
-Mark Wood

Thanks for the heads up.
Regarding the operators, would it be an option to simply include <ciso646> as  mentioned here: https://connect.microsoft.com/VisualStudio/feedback/details/312168/still-no-support-for-keywords-like-and-in-vc ? I don't have or use VS so I can't test this myself.
Also, I noticed in 2 places you replaced std::strerror(errno) by a fixed-length buffer when constructing exceptions. Is there a compelling reason for that?

Hi David,
Thanks for considering my pull request.
On the strerror suggested change, the code as is results in a warning in Visual Studio (which actually gets flagged as an error) about unsafe code – I guess strerror is considered unsafe because of the possibility for buffer overflow.
With respect to the and/or/not,  I did try just now including ciso646 at the beginning of my file as you suggested, before including your zstr.hpp, but I was not able to get it to work on Visual Studio for some reason.   (I didn’t even know some compilers supported and/or/not, so I was surprised to see them in use, but I can understand if you find them more readable).
-Mark
p.s.
If you prefer to keep the and/or/not, I’ll probably just keep my fork and merge updates as need be.   However, I did spend a little time trying to understand why it didn’t work.
The ciso646.h file in turn includes iso646.h, which includes the following:
#if !defined(__cplusplus) || defined(_MSC_EXTENSIONS)
#define and   &&
...
__cplusplus would be defined to be true so that part of the disjunction will fail, although it does make me wonder why that clause was present.  However, _MSC_EXTENSIONS should be defined by default as far as I can tell, so the disjunction as a whole should be true.  Looking at the preprocessor output, nevertheless it for some reason skipped over the guts of the iso646.h include file.
#line 1 "c:\program files (x86)\microsoft visual studio 14.0\vc\include\iso646.h"
#pragma once
#line 20 "c:\program files (x86)\microsoft visual studio 14.0\vc\include\iso646.h"
given that my include of  is the very first define in the file I was just using to test this, I’m drawing a blank as to why the Visual Studio compiler is skipping the guts of this include.
From: Matei David<EMAIL_ADDRESS>Sent: Monday, February 13, 2017 3:26 PM
To: mateidavid/zstr<EMAIL_ADDRESS>Cc: Mark D Wood<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [mateidavid/zstr] Changes to enable compilation under Visual Studio (2015) (#2)
[CAUTION: This email originated from outside of Kodak Alaris. Do not click links or open attachments unless you recognize the sender and know the content is safe.]

Thanks for the heads up.
Regarding the operators, would it be an option to simply include  as mentioned here: https://connect.microsoft.com/VisualStudio/feedback/details/312168/still-no-support-for-keywords-like-and-in-vchttps://urldefense.proofpoint.com/v2/url?u=https-3A__connect.microsoft.com_VisualStudio_feedback_details_312168_still-2Dno-2Dsupport-2Dfor-2Dkeywords-2Dlike-2Dand-2Din-2Dvc&d=DwMFaQ&c=skUQKLuTFULvQUMqV0uyBaBvPxsA7Wk8MKjvMTLjY3w&r=dVP8q3Z1EokhCbGxwR5tDGFdTWdheZybnjr5LYHJwZ8&m=XEr7K_NHVQXnirWwLXBRn-a8x0w19tKPcJUQjCqXfUU&s=eVnl_BLPx7FchPho_sHJMjB-caIXzpbMJJCd-E61j4Y&e= ? I don't have or use VS so I can't test this myself.
Also, I noticed in 2 places you replaced std::strerror(errno) by a fixed-length buffer when constructing exceptions. Is there a compelling reason for that?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mateidavid_zstr_pull_2-23issuecomment-2D279511605&d=DwMFaQ&c=skUQKLuTFULvQUMqV0uyBaBvPxsA7Wk8MKjvMTLjY3w&r=dVP8q3Z1EokhCbGxwR5tDGFdTWdheZybnjr5LYHJwZ8&m=XEr7K_NHVQXnirWwLXBRn-a8x0w19tKPcJUQjCqXfUU&s=M4AsZ9GSGOf_UdCH7K4oEY1uaJ36MlxhzjkiZNfCFtQ&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AIjG1iariAsnahyybFrTNE-5FtWcuHSd9Jks5rcLxfgaJpZM4L-5FooR&d=DwMFaQ&c=skUQKLuTFULvQUMqV0uyBaBvPxsA7Wk8MKjvMTLjY3w&r=dVP8q3Z1EokhCbGxwR5tDGFdTWdheZybnjr5LYHJwZ8&m=XEr7K_NHVQXnirWwLXBRn-a8x0w19tKPcJUQjCqXfUU&s=PipmeLTRmKHTGYVJbU0SJJhNdSD9K7lgoneVP4eN1Fo&e=.

Ok, thanks. I pulled this into a dev branch and added a SO-inspired platform-specific way of wrapping strerror. As you might notice from the CI error log for your original PR, strerror_s seems to be windows-specific. Please try out dev on windows and let me know if it works.

That worked.  I just added a few more casts so that now Visual Studio won’t generate any warnings (the other issue was flagged in a more serious way); if you want to pull those too, you’re welcome to them.
Thanks for making the changes.   Your utility was very useful to me.
-Mark
p.s. this is really the first time I’ve used in git other than a very superfical way; hopefully the pull request on the branch was done correctly.
From: Matei David<EMAIL_ADDRESS>Sent: Monday, February 13, 2017 11:37 PM
To: mateidavid/zstr<EMAIL_ADDRESS>Cc: Mark D Wood<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [mateidavid/zstr] Changes to enable compilation under Visual Studio (2015) (#2)
[CAUTION: This email originated from outside of Kodak Alaris. Do not click links or open attachments unless you recognize the sender and know the content is safe.]

Ok, thanks. I pulled this into a dev branch and added a SO-inspired platform-specific way of wrapping strerror. As you might notice from the CI error log for your original PR, strerror_s seems to be windows-specific. Please try out dev on windows and let me know if it works.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mateidavid_zstr_pull_2-23issuecomment-2D279606061&d=DwMFaQ&c=skUQKLuTFULvQUMqV0uyBaBvPxsA7Wk8MKjvMTLjY3w&r=dVP8q3Z1EokhCbGxwR5tDGFdTWdheZybnjr5LYHJwZ8&m=0rNDuYfqc1-brnigdnk69XOXFsACa_L4EJE9Yd_YUDo&s=p24YW5OPzLoxW-P_Wxs-tast1hNY-zeV9Vz7sNSrgBo&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AIjG1oGrTZ7OAjRvZPpLq80AEci3msT5ks5rcS9ygaJpZM4L-5FooR&d=DwMFaQ&c=skUQKLuTFULvQUMqV0uyBaBvPxsA7Wk8MKjvMTLjY3w&r=dVP8q3Z1EokhCbGxwR5tDGFdTWdheZybnjr5LYHJwZ8&m=0rNDuYfqc1-brnigdnk69XOXFsACa_L4EJE9Yd_YUDo&s=l0iAjSNC9rJNsKNmzmb6dRN66Al5MNauQMiJ4VxMYGQ&e=.

BTW, sorry I didn’t catch that strerror_s was a Microsoftism.
From: Matei David<EMAIL_ADDRESS>Sent: Monday, February 13, 2017 11:37 PM
To: mateidavid/zstr<EMAIL_ADDRESS>Cc: Mark D Wood<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [mateidavid/zstr] Changes to enable compilation under Visual Studio (2015) (#2)
[CAUTION: This email originated from outside of Kodak Alaris. Do not click links or open attachments unless you recognize the sender and know the content is safe.]

Ok, thanks. I pulled this into a dev branch and added a SO-inspired platform-specific way of wrapping strerror. As you might notice from the CI error log for your original PR, strerror_s seems to be windows-specific. Please try out dev on windows and let me know if it works.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mateidavid_zstr_pull_2-23issuecomment-2D279606061&d=DwMFaQ&c=skUQKLuTFULvQUMqV0uyBaBvPxsA7Wk8MKjvMTLjY3w&r=dVP8q3Z1EokhCbGxwR5tDGFdTWdheZybnjr5LYHJwZ8&m=0rNDuYfqc1-brnigdnk69XOXFsACa_L4EJE9Yd_YUDo&s=p24YW5OPzLoxW-P_Wxs-tast1hNY-zeV9Vz7sNSrgBo&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AIjG1oGrTZ7OAjRvZPpLq80AEci3msT5ks5rcS9ygaJpZM4L-5FooR&d=DwMFaQ&c=skUQKLuTFULvQUMqV0uyBaBvPxsA7Wk8MKjvMTLjY3w&r=dVP8q3Z1EokhCbGxwR5tDGFdTWdheZybnjr5LYHJwZ8&m=0rNDuYfqc1-brnigdnk69XOXFsACa_L4EJE9Yd_YUDo&s=l0iAjSNC9rJNsKNmzmb6dRN66Al5MNauQMiJ4VxMYGQ&e=.

I'm glad it was useful. Just to finish this- where are the casts, I don't see them. I merged your PR "by hand", by adding your repo as a remote, branching dev from master, and merging your master onto dev. Can you add the casts in a commit against the current dev?

I guess the cleanest way, so that all commits show in this PR, would be to pull my commits from dev into your master, add stuff to your master, then push it to your origin/master. Something like:
git remote add upstream https://github.com/mateidavid/zstr.git  # if not done already
git remote update
git checkout master
git merge upstream/dev
# add more edits here...
git add [...]
git commit -m "more edits"
git push

I had forgotten to do the push.  Hopefully things are pushed correctly now.
$ git commit -m "typecasts to keep VS happy"
[master 1ff570f] typecasts to keep VS happy
1 file changed, 5 insertions(+), 5 deletions(-)
50411946@lustroc-3px4vy1 MINGW64 ~/Projects/zstr.git/src (master)
$ git push
fatal: The current branch master has no upstream branch.
To push the current branch and set the remote as upstream, use
git push --set-upstream origin master

50411946@lustroc-3px4vy1 MINGW64 ~/Projects/zstr.git/src (master)
$ git push --set-upstream origin master
Counting objects: 4, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 456 bytes | 0 bytes/s, done.
Total 4 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
Branch master set up to track remote branch master from origin.
To https://github.com/markdwood/zstr.git
4024a9d..1ff570f  master -> master
From: Matei David<EMAIL_ADDRESS>Sent: Tuesday, February 14, 2017 10:43 AM
To: mateidavid/zstr<EMAIL_ADDRESS>Cc: Mark D Wood<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [mateidavid/zstr] Changes to enable compilation under Visual Studio (2015) (#2)
[CAUTION: This email originated from outside of Kodak Alaris. Do not click links or open attachments unless you recognize the sender and know the content is safe.]

I guess the cleanest way, so that all commits show in this PR, would be to pull my commits from dev into your master, add stuff to your master, then push it to your origin/master. Something like:
git remote add upstream https://github.com/mateidavid/zstr.git  # if not done already
git remote update
git checkout master
git merge upstream/dev
add more edits here...
git add [...]
git commit -m "more edits"
git push
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mateidavid_zstr_pull_2-23issuecomment-2D279743442&d=DwMFaQ&c=skUQKLuTFULvQUMqV0uyBaBvPxsA7Wk8MKjvMTLjY3w&r=dVP8q3Z1EokhCbGxwR5tDGFdTWdheZybnjr5LYHJwZ8&m=wXUW1Ln8vM6A3_WtkuC4sDcslHOXcWd3VU5fzC6imB0&s=eRIMIoobdI6rdegm6bI5OjDpIvU4Cm1zYDpoEGP7PGk&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AIjG1l3XGsTfMwjXHCICD1z-2Dei0h-2DQZEks5rcct1gaJpZM4L-5FooR&d=DwMFaQ&c=skUQKLuTFULvQUMqV0uyBaBvPxsA7Wk8MKjvMTLjY3w&r=dVP8q3Z1EokhCbGxwR5tDGFdTWdheZybnjr5LYHJwZ8&m=wXUW1Ln8vM6A3_WtkuC4sDcslHOXcWd3VU5fzC6imB0&s=qQpoN2SbRVA_sOdw2fGg6gpegQyCXmGmrG-tR2WAgic&e=.

Ok, thanks. I merged the PR, but I removed the casts and reverted to using size_t for buff_size, which is unsigned, so hopefully that will eliminate the warnings. I don't remember why I chose to use a signed type there, it doesn't make much sense.

Just to confirm, Visual Studio is quite happy w/ your latest changes (no warnings).   I was out of the office last week and didn’t have a chance to try this earlier.
Thanks.
-m
From: Matei David<EMAIL_ADDRESS>Sent: Tuesday, February 14, 2017 10:26 PM
To: mateidavid/zstr<EMAIL_ADDRESS>Cc: Mark D Wood<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [mateidavid/zstr] Changes to enable compilation under Visual Studio (2015) (#2)
[CAUTION: This email originated from outside of Kodak Alaris. Do not click links or open attachments unless you recognize the sender and know the content is safe.]

Ok, thanks. I merged the PR, but I removed the casts and reverted to using size_t for buff_size, which is unsigned, so hopefully that will eliminate the warnings. I don't remember why I chose to use a signed type there, it doesn't make much sense.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mateidavid_zstr_pull_2-23issuecomment-2D279907242&d=DwMFaQ&c=skUQKLuTFULvQUMqV0uyBaBvPxsA7Wk8MKjvMTLjY3w&r=dVP8q3Z1EokhCbGxwR5tDGFdTWdheZybnjr5LYHJwZ8&m=8TCVxw2LeET5ka7Wy7FTCdjCq7FopzDzdJNa90exigA&s=fzs60SZDWjtJlYjZ7xbeWSEj3UXJce_YxW_P5wZNUAU&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AIjG1qBq1SxFuURoZQRd-2DZHvFyCvABV-5Fks5rcnBigaJpZM4L-5FooR&d=DwMFaQ&c=skUQKLuTFULvQUMqV0uyBaBvPxsA7Wk8MKjvMTLjY3w&r=dVP8q3Z1EokhCbGxwR5tDGFdTWdheZybnjr5LYHJwZ8&m=8TCVxw2LeET5ka7Wy7FTCdjCq7FopzDzdJNa90exigA&s=ihc5K7xBUMCdvKmKHvYSul9mZRZvDsmmr5riPCw_N3g&e=.


enable iPXE boot

This depends on stackhpc/kayobe#140

Have the dependent changes in kolla, kolla-ansible and kayobe been backported to the stackhpc/pike branches?

Created a PR for kayobe stackhpc/pike: https://github.com/SKA-ScienceDataProcessor/alaska-kayobe-config/pull/66

stackhpc/kayobe##145 is now merged. This should be good to go.


Vulnerability roundup 92: traefik-1.7.21: 1 advisory [4.7]

search, files

[ ] CVE-2020-15129 CVSSv3=4.7 (nixos-20.03)

Scanned versions: nixos-20.03: 925ae0dee63.
Cc @ehmry
Cc @lethalman
Cc @moredhel
Cc @vdemeester

Since #97564 was merged this can be closed.


Correctly truncate VM

Problem
https://github.com/neondatabase/neon/issues/9240
Summary of changes
Correctly truncate VM page instead just replacing it with zero page.
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

test_pg_regress times out now. Do you know why that can happen?

I copied some more comments from the corresponding postgres function here.

If it's difficult to write tests using just SQL commands, one approach is to write a bespoken little C test extension that explicitly calls smgrtruncate() to truncate the VM etc. In this case, I don't think it's too hard to hit all the codepaths from SQL either though. Or you can do both; more tests is generally better.

If it's difficult to write tests using just SQL commands, one approach is to write a bespoken little C test extension that explicitly calls smgrtruncate() to truncate the VM etc. In this case, I don't think it's too hard to hit all the codepaths from SQL either though. Or you can do both; more tests is generally better.

It is not a problem to create zero page at PS (caused by VM truncation).
The problem is how to cause clearing of all-visible bit for this page because prior to clear all-visible we first need to set all-visible and somehow prevent this change from been propagated to PS.

I see only one way how this error con be reproduced - please look at RelationTruncate:
	/* Prepare for truncation of the visibility map too if it exists */
	vm = smgrexists(RelationGetSmgr(rel), VISIBILITYMAP_FORKNUM);
	if (vm)
	{
		blocks[nforks] = visibilitymap_prepare_truncate(rel, nblocks);
		if (BlockNumberIsValid(blocks[nforks]))
		{
			forks[nforks] = VISIBILITYMAP_FORKNUM;
			nforks++;
		}
	}
        ...
	if (RelationNeedsWAL(rel))
	{
                ...
		lsn = XLogInsert(RM_SMGR_ID,
						 XLOG_SMGR_TRUNCATE | XLR_SPECIAL_REL_UPDATE);
	}

It first update VM page in visibilitymap_prepare_truncate and then wan-log this truncation.
If VM page is throw away between this two events, then we actually have zeroed page in PS.
But it seems tone impossible toreliably reproduce it without patch Postgres code in adding fail point in this place.

I see only one way how this error con be reproduced - please look at RelationTruncate:
	/* Prepare for truncation of the visibility map too if it exists */
	vm = smgrexists(RelationGetSmgr(rel), VISIBILITYMAP_FORKNUM);
	if (vm)
	{
		blocks[nforks] = visibilitymap_prepare_truncate(rel, nblocks);
		if (BlockNumberIsValid(blocks[nforks]))
		{
			forks[nforks] = VISIBILITYMAP_FORKNUM;
			nforks++;
		}
	}
        ...
	if (RelationNeedsWAL(rel))
	{
                ...
		lsn = XLogInsert(RM_SMGR_ID,
						 XLOG_SMGR_TRUNCATE | XLR_SPECIAL_REL_UPDATE);
	}

It first update VM page in visibilitymap_prepare_truncate and then wan-log this truncation. If VM page is throw away between this two events, then we actually have zeroed page in PS. But it seems tone impossible toreliably reproduce it without patch Postgres code in adding fail point in this place.

I don't follow. If the page is thrown away between modifying the VM page and WAL-logging, then the pageserver would still contain the old non.-zero version of the VM page, and there would be no truncation in the pageserver.

I don't follow. If the page is thrown away between modifying the VM page and WAL-logging, then the pageserver would still contain the old non.-zero version of the VM page, and there would be no truncation in the pageserver.

So what will happen in most cases on VM truncations:

VM page is update on compute
SMGR_TRUNCATE record is appended to the WAL
VM pages is written and FPI is appended to the WAL
So in PS for this VM page we have sequence: SMGR_TRUNCATE,FPI after applying which we will get non-zero page.
But if eviction happened between 1 and 2,  then we will get:
VM page is update on compute
VM pages is written and FPI is appended to the WAL
SMGR_TRUNCATE record is appended to the WAL
In this case the sequence will be FPI,SDMGR_TRUNCATE which produce zero VM page.

I tried also "brute force" truing to reproduce the problem not deterministically, but more or less reliably, by running many concurrent tasks performing relation truncation:
import threading
from fixtures.neon_fixtures import NeonEnv

#
# Test that VM is properly truncated
#
def test_vm_truncate(neon_simple_env: NeonEnv):
    env = neon_simple_env

    n_iterations = 100
    n_threads = 16

    threads = []
    endpoint = env.endpoints.create_start("main")

    con = endpoint.connect()
    cur = con.cursor()
    cur.execute("CREATE EXTENSION neon_test_utils")

    def truncate(tid):
        con = endpoint.connect()
        cur = con.cursor()
        cur.execute("set enable_seqscan=off")
        cur.execute(f"create table t{tid}(pk integer primary key, counter integer default 0, filler text default repeat('?', 200))")
        for i in range(n_iterations):
            cur.execute(f"insert into t{tid} (pk) values (generate_series(1,1000))")
            cur.execute(f"delete from t{tid} where pk>1")
            cur.execute(f"vacuum t{tid}")
            cur.execute(f"update t{tid} set counter=counter+1")
            cur.execute("SELECT clear_buffer_cache()")
            cur.execute(f"select count(*) from t{tid}")
            cur.execute(f"delete from t{tid}")

    for i in range(n_threads):
        t = threading.Thread(target=truncate, args=(i,))
        threads.append(t)
        t.start()

    for t in threads:
        t.join()

... but still without any success.


heating issue for apple macbook air

the apple macbook air is getting heated whenever i use vs code .this issue is being seen recently just 2 days . before the same work was working without much efforts and heat.

Please see https://github.com/Microsoft/vscode/wiki/Performance-Issues and include information about the currently and previously installed versions of VS Code and check if it goes away when running with extensions disabled.


Want to know more/participate

You can email me
Or ask directly in that issue

You can ask here directly !


SyntaxError: possible import expression rejected around line {N}

Hello, Figam Developers.
I am developer of figma codegen (plugin). Thank you for developing this wonderful thing. 🥇

While looking for a place to report, I found a similar Pull Request and am posting the issue here. (ref. https://github.com/figma/plugin-typings/issues/36)
An error occurs if you include import( in the bundle file.
I run prettier at runtime, but the service terminates unexpectedly due to an alert, so I cannot develop the plugin.
Even if it is not a prettier, problems can occur in major libraries.
example bundle file
"use strict";
(() => {
  // src/index.ts
  figma.codegen.on("generate", () => {
    console.log("import(");
    return [];
  });
})();
//# sourceMappingURL=index.js.map

If you do not understand the situation, please ask a question.
I would appreciate it if you could fix it :)

Hi @eliot-liner, this is expected behavior.
For now, you can get around this limitation by using string concatenation:
"use strict";
(() => {
  // src/index.ts
  const IMPORT_STRING = "im" + "port";
  figma.codegen.on("generate", () => {
    console.log(`${IMPORT_STRING}(`);
    return [];
  });
})();

@knguyen-figma thanks for answer.
If this were my code, I could change it as you suggested, but it's in the comments in the bundle file of the library I'm using.
The library I am using at runtime is called “prettier”.
And I don't know why this is expected behavior. Shouldn't imports in comments or console logs be excluded from errors?

I've had to fix by post-processing the js after it's built. Silly bug.

I am doing that too. 😞


Error when dropping macros outside of the hotbar

When I try dropping a macro outside of the bar this error shows up and the macro isn't removed.
https://user-images.githubusercontent.com/13217785/196255196-f21a7152-bda4-471e-a1d1-b62e2c2e79db.mp4

Thanks for the report. What game system, and do you have any other modules enabled?
This was a bug in the previous version of CHB and I didn't do anything to fix it, and couldn't reproduce it, so thanks for this. I was hoping it was squashed by the core update somehow.

My pleasure to help 😄
I'm using Cyberpunk Red and using 46 mods:

Interesting. Can you reproduce in safe mode (without any modules that
aren't required by the system?? I'm particularly curious if it's Token
Hotbar that is causing the problem. It could be the system also. I'll
install it and give it a shot later today.
On Mon, Oct 17, 2022 at 9:59 PM Victor Marques @.***>
wrote:

My pleasure to help 😄
I'm using Cyberpunk Red and using 46 mods:
[image: image]
https://user-images.githubusercontent.com/13217785/196317536-a8d30dc5-a8f6-4e67-8b94-94538423e2d3.png
[image: image]
https://user-images.githubusercontent.com/13217785/196317570-2435eb33-5eda-42bf-8c40-74880112e3f8.png
[image: image]
https://user-images.githubusercontent.com/13217785/196317604-5bfee723-471a-4125-a5e5-80bf362ae912.png
—
Reply to this email directly, view it on GitHub
https://github.com/Norc/foundry-custom-hotbar/issues/123#issuecomment-1281709750,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APNL7OZ26N4OK4MJC23TRU3WDX77BANCNFSM6AAAAAARHKX3T4
.
You are receiving this because you commented.Message ID:
@.***>

Thanks, it might be a system thing then, I'll give it a go. Appreciate the
report and investigation.
On Tue, Oct 18, 2022 at 9:16 AM Victor Marques @.***>
wrote:

Yup, same issue with just the Custom Hotbar module enabled
—
Reply to this email directly, view it on GitHub
https://github.com/Norc/foundry-custom-hotbar/issues/123#issuecomment-1282370597,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APNL7O5I6RWBQQTJACIUZUTWD2PKTANCNFSM6AAAAAARHKX3T4
.
You are receiving this because you commented.Message ID:
@.***>


WIP Beta 28: added some Windows release notes from changelog

@MagnusS @dave-tucker @friism @mchiang0610  @mstanleyjones
Starting updates for Beta 28, please do not merge this PR until we are ready to publish.
Signed-off-by: Victoria Bialas<EMAIL_ADDRESS>

@dave-tucker docs updates for Beta 28


overrideUrlLoading param added to chatbox

Sometimes, open the url in a browser is not the best option. For example: an OGG audio file has no player support in iOS browsers, so we could open a flutter dialog to play the file correctly (using a VLC player or other third party plugin).
With the overrideUrlLoading param, we can add custom behavior to urls without affecting the natural flow.
The updates were basically in 3 places:
final Future<bool> Function(Uri uri)? overrideUrlLoading; // line 86 - the new optional widget param

// ...

this.overrideUrlLoading, // line 107 - the new optional widget param in constructor

// ...

// lines 260 to 276
var overridden = widget.overrideUrlLoading == null
            ? false
            : await widget.overrideUrlLoading!(navigationAction.request.url!);
        if (!overridden) {
          if (navigationAction.navigationType ==
              NavigationType.LINK_ACTIVATED) {
            if (await launchUrl(navigationAction.request.url!)) {
              // We launched the browser, so we don't navigate to the URL in the WebView
              return NavigationActionPolicy.CANCEL;
            } else {
              // We couldn't launch the external browser, so as a fallback we're using the default action
              return NavigationActionPolicy.ALLOW;
            }
          }
          return NavigationActionPolicy.ALLOW;
        }
        return NavigationActionPolicy.CANCEL;

All the other updates was just the VS Code formatOnSave editor setting in action.

Closing due to unnecessary number of lines changed


[Bug]: Configuring sourceMap: { js: 'source-map' } in the production environment cannot decode stack traces.

Version
System:
    OS: Windows 10 10.0.19042
    CPU: (12) x64 11th Gen Intel(R) Core(TM) i5-11500 @ 2.70GHz
    Memory: 12.17 GB / 31.71 GB
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (127.0.2651.74)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    @rsbuild/core: ^1.0.4 => 1.0.4
    @rsbuild/plugin-less: ^1.0.1 => 1.0.1
    @rsbuild/plugin-react: ^1.0.2 => 1.0.2
    @rsbuild/plugin-styled-components: ^1.0.1 => 1.0.1

Details
In the output configuration, setting sourceMap: { js: 'source-map' } results in inconsistent source code parsing behavior between the development and production environments, with the production environment not working as expected.
The development environment interface is as follows:

The production environment interface is as follows:

Reproduce link
https://github.com/wendy0512/rsbuild-sourcemap-repro
Reproduce Steps

In the output configuration, set sourceMap: { js: 'source-map' }.

Run rsbuild dev and observe the network resources in the development environment.

Run rsbuild build and observe the network resources in the production environment.

Minimal reproduction has been added.

Sorry, after upgrading @rsbuild/core from 1.0.4 to 1.0.8, the example still does not display as expected. @chenjiahan

Hi there!
It's also affecting modern.js framework. I notice this when trying to implement sentry in my app.

Fixed in https://github.com/web-infra-dev/rspack/releases/tag/v1.0.10


"Audit mode available" table does't match https://docs.microsoft.com/en-us/windows/security/threat-protection/microsoft-defender-atp/exploit-protection#review-exploit-protection-events-in-windows-event-viewer, which options support audit mode indeed?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7ecdf2c7-5cdd-2454-fb4e-8d462e490e43
Version Independent ID: c135d150-fa2b-68cd-ba0b-c688f618a3a1
Content: Customize exploit protection - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/customize-exploit-protection.md
Product: w10
GitHub Login: @levinec
Microsoft Alias: ellevin

I'm pretty sure that EAF at least has audit mode available with event ID 13

Sorry for being pedantic here, but would you be able to edit & move most of the text from the title line down into your main comment text box, to replace the text "[Enter feedback here]" ? The ticket title only needs a very brief description, maybe something like:
"Audit mode available" table & support options
Feel free to at least copy the entire title line into the main comment, it would help a lot with reading the issue.

Thank you very much for the follow-up, both of you. 🙂 👍🏻

Closing via #8765


ts_query_ls: 1.0.1 -> 1.4.1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I noticed there is a newer version available when I was about to run nixpkgs-review, maybe bump it to 1.4.1 first?

Great point, thanks :)

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 361022

x86_64-darwin

:white_check_mark: 1 package built:

ts_query_ls


Intimidate calculations

https://pathofexile.gamepedia.com/Intimidate
Intimidate doesn't proc on RF or Scorching Ray or any skill that doesn't "hit", but if you mark the Intimidate, it still adds +10% damage on the tooltip. This can cause confusion with some players who are planning new builds.

What's your point here? You can also mark shock and many other things, they are there in case you want the effect added, it doesn't have to be related to RF at all.

The DPS calculations using the Intimidate bonus even when it doesn't work is the same as if the "was hit by Lightning" added the 40% damage even when the build doesn't have EE. The Intimidate doesn't affect skills that don't "hit", so if a player has the Belt of the Deceiver, all skills should add the 10% bonus damage to the DPS tooltip, except the ones that doesn't hit.
The whole point of having a tool to plan a build and test different sets of equipment is not having to buy it in-game. If something is wrong in the calculations, it has to be fixed.

This is an issue, but not for the reason YurihOI seems to think it is.
It has nothing to do with a skill's ability to proc Intimidate (if you manually set it as active, the program should consider it to be active regardless of your ability to proc it) and more to do with the fact that 3.1.0 changed it so Intimidate now causes enemies to take 10% increased Attack Damage.
Path of Building is still applying the increase to spell damage as well, which is simply an oversight.

This is finally fixed in the next update. Sorry for the delay!


(QENG-4823) Add Hipchat Notifier

This PR adds in a separate Lambda to write notifications to a hipchat
channel when the "REAPER TERMINATION" text is found in the CloudWatch
Logs.

This looks good to me. I am wondering if it might be possible to get some very brief docs, specifically about how this figures into deployment?

@jwrothchild I've added a section about the hipchat notifier in the components section; ready for further review.


log is not show in my chrome

i follow the instructions but why my log is not print in my Chrome

Have you set the log level?
The default level is warn, so log.warn('hello') should work, but log.info('hello') won't appear, unless you call log.setLevel('info') (or below) first.

Closing for inactivity, but do let me know if you're still having issues.


[JENKINS-33861] Added support for the Unity3dBuilder Plugin

Unity3dBuilde
JENKINS-33861

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

please rebase to master and squash your commits

this PR contains an unwanted commit, please try to rebase again

This is supported by the automatically generated DSL:
job('example') {
  steps {
    unity3dBuilder {
      unity3dName('unity-5.2.1')
      unstableReturnCodes('2,3')
      argLine('-batchmode')
    }
  }
}


Edit on Github in footer broken

Description
There are many flaws with the documentation which need to be updated but in order to do that they must be editable on github. This link at the footer of pages such as this: http://docs.django-cms.org/en/latest/reference/plugins.html is broken
## Steps to reproduce
Load page, click link
Expected behaviour
Link should not be a 404
Actual behaviour
Link is a 404
Additional information
None

All the documentation is in the django CMS GitHub repository. Contributions with fixes and improvements are welcome, as described in Contributing documentation

The part of the theme which builds this link is here; https://github.com/divio/docs-theme/blob/master/src/furo/theme/furo/page.html#L113
              {% if check_meta and 'github_url' in meta %}
                 {{ _('Edit on GitHub') }}
              {% else %}
                 {{ _('Edit on GitHub') }}
              {% endif %}

Closing this as the new docs theme doesn't have this option.


Programmatically scroll to section header

Is there any way to programmatically scroll to a particular section header? I have buttons along the top of my ListView which represent the different section headers, and I want to scroll to the appropriate section upon tapping them. Is this possible?

did you find a solution for this issue ?

Not yet.
On Mon, Jan 12, 2015 at 4:32 AM, dimitrireef<EMAIL_ADDRESS>wrote:

did you find a solution for this issue ?
—
Reply to this email directly or view it on GitHub
https://github.com/applidium/HeaderListView/issues/41#issuecomment-69545530
.

Hello,
You should call #smoothScrollToPosition(int) or #setSelection(int) on the underlying ListView while passing numberOfCellsBeforeSection(int section) as argument.


HDFS-11111. Delete items in .Trash using rm should be forbidden witho…

159

 Quality gate: Passed
 Everything looks good
Details


Links in m.notices aren't clickable

See https://matrix.to/#/!GnEEPYXUhoaHbkFBNX:matrix.org/$15348428597757NKBHu:maunium.net

Oops, duplicate of #2281. I blame GitHub search not checking pluralized forms of my search query.


Don't put the homu database in /home/servo/homu directory

We recently deleted the main main.db database by accident while debugging a Homu problem; the /home/servo/homu directory was blown away and the database with it.
To make it harder to blow away the database inadvertently, we should put the database in a different location. I think /var/homu/main.db would be a good option. We also need to add a Salt state to pre-create the /var/homu directory with the correct permissions for Homu to use it.
Homu first needs to land an option to change the main.db location.
Files:

homu/files/cfg.toml
homu/init.sls

No test necessary for now.
cc @larsbergstrom

Yeah, that makes sense :-)

This has been fixed in Homu, so this is open for anyone to work on!

@aneeshusa I'd like to help out here.

@Coder206 It's yours, please ask if you have any questions!

This was fixed by #476, which has been deployed. Thanks @Coder206!


Randomly stop working with base64 return type

As in title, the plugin seems to randomly stop working if is set:
this.imageLoaderConfig.setImageReturnType('base64');.
This happens on both iOS and Android devices.
No errors on logs even if this.imageLoaderConfig.enableDebugMode();

If you're still experiencing issues, please re-open with steps to reproduce.


OSS-Fuzz: ASSERT: latch_block_iter != fn->end() && "Could not find the latch."

OSS-Fuzz issue: ASSERT: latch_block_iter != fn->end() && "Could not find the latch."
@s-perron for info.

I believe this is invalid spir-v.  There is a selection merge whose header is lexicographical contained in a few other construct, but its merge block is not.

@alan-baker Can you confirm that this spir-v is invalid and figure out how to change the validator?

The validator ignores unreachable blocks. It can't make reasonable decisions about graph roots in unreachable sections.
That said, this testcase fails validation for a bad decoration of DescriptorSet on an OpPhi.

this testcase fails validation for a bad decoration of DescriptorSet on an OpPhi.

I had removed that decoration to try to reproduce the error.

The validator ignores unreachable blocks.

I'm assuming you agree that the CFG is invalid.  Are you trying to say that the validator will not be able to catch this case, or that is explaining why it does not currently catch it?

The validator doesn't attempt to validate the unreachable sections. Dominance as defined in the SPIR-V spec breaks down for unreachable blocks (forms a tautology). I don't expect the validator would ever care about the unreachable section. I'd suggest the optimizer also mostly ignore unreachable blocks.

I looked at this again.  I'm not sure how I got to my original analysis, or maybe something changed.  The problem is the single block loop.  Merge return calls CFG::SplitLoopHeader, and that function cannot handle a single-block loop.


Examples

Can you add some examples using 2 or more io emitters?

Please take a look at: https://github.com/socketio/socket.io-emitter#examples


Make common dv code ot agnostic

Fixes #2948.

I will go ahead and merge this in now. We can address any additional fixes in future PRs.