Vault 0.10+ key value store v2 support

Hi guys.
Vault v 0.10 provides new version of key/value storage by default. Of course using new version of vault you still can configure kv store v1 and it works perfectly with spring-vault library, also I think application code can be adjusted, but I found following differences. And finally, v2 supports versioning and configuration endpoints.
Do you have a plan to upgrade library to provide transparent ability to use v1 and v2 without any changes in code?

Operation
Difference

Read
There is only difference in path.

List
There is only difference in path.

Create/Update
Difference in path and new version uses POST for both update and create operations. + for v2 payload should be wrapped into "data" object.

Remove
Difference in path.

Docs:
https://www.vaultproject.io/api/secret/kv/kv-v1.html
https://www.vaultproject.io/api/secret/kv/kv-v2.html

Duplicate of #239

We can't really provide a transparent interface as all operations need to stay aware they are using a versioned backend.

We added a dedicated Key-Value API with #246 to provide at least read/list/delete methods in a consistent form for versioned and non-versioned backends. Updates require specific inputs  (e.g. version number for CAS) and reading through the new API is limited as it strips off all versioning details.


Chimera familiar

The player can feed the chimera to make it grow bigger and gain more damage and speed. When it gets big enough the player can ride it. Also, if you feed it a golden apple the goat will detach and become a separate familiar 🙂

Man, this one is just fantastic! Love the detachable goat haha


[e2e]: go tag main config-ldflags-assets-prerelease-tag slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v34.0.216
Run: https://github.com/slsa-framework/example-package/actions/runs/6463952693
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Trigger: push
Branch: v34.0.216
Date: Tue Oct 10 02:29:24 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/v34.0.217
Run: https://github.com/slsa-framework/example-package/actions/runs/6477193894
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Trigger: push
Branch: v34.0.217
Date: Wed Oct 11 02:29:20 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/v34.0.218
Run: https://github.com/slsa-framework/example-package/actions/runs/6503275253
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Trigger: push
Branch: v34.0.218
Date: Fri Oct 13 02:33:21 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/v34.0.219
Run: https://github.com/slsa-framework/example-package/actions/runs/6515003570
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Trigger: push
Branch: v34.0.219
Date: Sat Oct 14 02:26:02 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/v34.0.220
Run: https://github.com/slsa-framework/example-package/actions/runs/6521449647
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Trigger: push
Branch: v34.0.220
Date: Sun Oct 15 02:32:30 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/v34.0.221
Run: https://github.com/slsa-framework/example-package/actions/runs/6528241046
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Trigger: push
Branch: v34.0.221
Date: Mon Oct 16 02:32:54 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/v34.0.222
Run: https://github.com/slsa-framework/example-package/actions/runs/6541731815
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Trigger: push
Branch: v34.0.222
Date: Tue Oct 17 02:26:22 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/v34.0.223
Run: https://github.com/slsa-framework/example-package/actions/runs/6555402117
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets-prerelease-tag.slsa3.yml
Trigger: push
Branch: v34.0.223
Date: Wed Oct 18 02:31:38 UTC 2023
Tests are passing now. Closing this issue.


[Request for comments] GraphQL proof of concept

Ref #8258
I would like someone to review and provide comments on the direction I am taking with implementing a GraphQL api in Gitea.
Scope of POC: query repository, top level fields exposed via REST api are returned, as well as branches/collaborators. Also attempting to adhere to the Relay specification (like GitHub/GitLab seems to do). I'm using https://github.com/graphql-go/graphql.
Some examples:
General GraphQL query for some repo information.

Query by global id
Note the normal id is available as "rest_api_id". Ids in GraphQL/Relay are recommended to be opaque, technically the id is the typname:id base64 encoded.

Forward pagination
Relay is cursor based and you can paginate forward or backward from any position. To achieve this I added the ability to provide the desired offset to the ListOptions struct

Backward pagination

Authorization
I attempted to replicate the same auth as in the REST api. The REST api defines these via function calls when the routes are declared. I couldn't re-use these directly because they return something like http 401, but in GraphQL you just return an error as part of the response. I tried to isolate the logic to utility methods where it made sense though.
In this example see that if you don't supply the auth token, you can't see the collaborators, though you can still get back the top level repo fields.

I recommend using the gqlgen package.

Schema first — Define your API using the GraphQL Schema Definition Language.
Type safe — You should never see map[string]interface{} here.
Codegen — Let us generate the boring bits, so you can build your app quickly.

I recommend using the gqlgen package.

Schema first — Define your API using the GraphQL Schema Definition Language.
Type safe — You should never see map[string]interface{} here.
Codegen — Let us generate the boring bits, so you can build your app quickly.

I looked at gqlgen to start but I had trouble getting started, and graphql-go while more low-level seemed easier (to me) to integrate (and it is still being maintained). But I'm new to GraphQL and still consider myself a beginner at Go so perhaps that was the problem. If some of the maintainers feel that is the superior library then I could look at it again, but will wait and see.

You can see the benchmark: https://github.com/appleboy/golang-graphql-benchmark
gqlgen's performance better than go-graphql. We need to consider two-point in the feature.

maintenance
performance

@appleboy I will give it a shot, thanks for the input.

Schema first — Define your API using the GraphQL Schema Definition Language.

Just for your information, the graphql creators do not recommend schema first as it's not very flexible. Here's an interesting write up on the topic https://www.prisma.io/blog/the-problems-of-schema-first-graphql-development-x1mn4cb0tyl3

Schema first — Define your API using the GraphQL Schema Definition Language.

Just for your information, the graphql creators do not recommend schema first as it's not very flexible. Here's an interesting write up on the topic https://www.prisma.io/blog/the-problems-of-schema-first-graphql-development-x1mn4cb0tyl3

@patcito  and interesting read, thanks. The framework I used for this PR graphql-go is code first like mentioned, declaring the schema in code isn't pretty but it did really make the relay boilerplate a whole lot easier. But on the other hand gqlgen does seem to have some features beyond just generating off a vanilla schema like directives.

@patcito an interesting read, thanks. The framework I used for this PR graphql-go is code first like mentioned, declaring the schema in code isn't pretty but it did really make the relay boilerplate a whole lot easier. But on the other hand gqlgen does seem to have some features beyond just generating off a vanilla schema like directives.

@bhalbright I agree and I think graphql-go is better for this reason.

@bhalbright I agree and I think graphql-go is better for this reason.

Thanks, I was going to try to also prepare a PR using gqlgen to do the same as this poc (but lacking free time, so make take a little while). I'm not sure who gets to decide :)

I worked on re-doing this proof of concept with gqlgen as suggested by @appleboy for a little while, but in the end I'm personally more comfortable with a code-first approach, rather than using a generator. I like how in graphql-go I can re-use a lot of the api structs from the rest api with no modifications or special configuration. Also, I think it is easier to add the relay connection i.e. paging in graphql-go. The schema file you create in gqlgen to generate off of definitely is a lot prettier than the code-first schema, but that isn't enough to make me want to learn all the nuances of the generation. I'm sure there's good answers to all these points and gqlgen is a great technology, but it is more of a comfort level for me. I'm not sure I understand how the maintenance with gqlgen would be easier, but I don't have deep experience with either technology. Also performance was mentioned, but the graphql-go, while lagging behind the others still seemed reasonable.
With all that said, I'm going to try to work to get this cleaned up and submit a real pr with some unit tests, and probably an ini switch to turn on/off. The maintainers can then decide whether they want this or it has to be done in a different framework.

@bhalbright Please fix conflicts

@bhalbright Please fix conflicts

sure, I have let this pr get stale, been meaning to come back to it. hopefully I can spend some time on it soon

I don't envision having the time necessary anytime soon to get this to where it would need to be to be accepted :( If anyone is interested, feel free to pick this up, using this as a starting point or a reference.

I don't envision having the time necessary anytime soon to get this to where it would need to be to be accepted :( If anyone is interested, feel free to pick this up, using this as a starting point or a reference.

This is in progress for a while now, I'm closing it to avoid stale pull requests. Please reopen when it's ready for review.


Perl spits out warning about locales

The texinfo test suite has a number of failures due to a message about locales.
See: https://github.com/ZOSOpenTools/texinfoport/issues/17 for details.
@IgorTodorovskiIBM not sure if this is related to recent changes in Perl or not - perhaps an env var isn't set right now - but this
could always have been there (new tests now running).

Digging in a little bit, it appears to be because 'ispunct' is giving the wrong answers for the UTF8 locale. Here's a testcase:
test>clang -fzos-le-char-mode=ascii punctest.c
test>./a.out
C: ispunct('#'):256
UTF-8: ispunct('#'):0

test>clang punctest.c
test>./a.out
C: ispunct('#'):16
Unable to set locale to UTF-8

test>cat punctest.c
#include <ctype.h>
#include <stdio.h>
#include <locale.h>

int main() {
  printf("C: ispunct('#'):%d\n", ispunct((unsigned char) ('#')));
  if (!setlocale(LC_ALL, "en_US.UTF-8")) {
    fprintf(stderr, "Unable to set locale to UTF-8\n");
    return 8;
  }
  printf("UTF-8: ispunct('#'):%d\n", ispunct((unsigned char) ('#')));
  return 0;
}

Defining your own locale: https://www.ibm.com/docs/en/zos/3.1.0?topic=lu-under-zos-shell

Creating a custom locale: https://www.ibm.com/docs/en/zos/3.1.0?topic=ilcs-customizing-locale


actually deprecate US CA Santa Clara county

Summary
Looks like we accidentally chucked the wrong month in the date. 🤷

This is failing the test suite, isn't this how we should be handling deprecations?

This is failing the test suite, isn't this how we should be handling deprecations?

I think that is OK. @jzohrab ?


New implementation

A new Go port of Shadowsocks has been forked into Shadowsocks organization
https://github.com/shadowsocks/go-shadowsocks2
This implementation is a clean rewrite. I believe it lays a better foundation for future improvement than the legacy Go port.
As suggested by @madeye here https://github.com/shadowsocks/shadowsocks-org/issues/38#issuecomment-277497449, I'm inviting @lixin9311 to discuss if there is chance of collaboration.

awesome work


V2 - Company Not Found - Focus is moved out of New Organization popup when hit on TAB key

Prerequisite

Create a CLA group with CCLA enabled
Add github repository for the CLA group

Steps to Follow

Login to Github as corporate contributor
Navigate to the repository used in prerequisite
Create PR
CLA check fails
Click on CLA NOT SIGNED
Contributor is redirected to Contributor Console
Click on Proceed as a Corporate Contributor
8.Click on building icon
Click on Organization not listed? + Click Here
Enter Organization website
Hit TAB key
Focus is moved out of popup. Focus should be on next field. User should be able to move to next fields with TAB key
Issue reported by Steve
When hitting the Tab key to go between text entry fields in the modal dialog, the Tab key actually goes to edit the text field in the disabled pane behind the modal.

@amolsontakke3576, simple fix, let’s use the HTML attributes to allow the user to properly tab through the form controls.

Focus is shifted to next field i.e. "Enter Organization Name" but the suggestions are still displayed to the user, hence rejecting the issue fix:
Please refer the below screencast for more details:

Verified successfully today. moving the ticket to QA Done for further review. Please refer the screencast as below:


[ZEPPELIN-912] Apply new mechanism to GeodeOqlInterpreter

What is this PR for?
This PR applies the new interpreter registration mechanism to Geode Oql interpreter.
What type of PR is it?
Improvement
Todos
Added interpreter-setting.json
What is the Jira issue?
Jira: https://issues.apache.org/jira/browse/ZEPPELIN-912
How should this be tested?
Test locally.
Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Thanks for the contribution. LGTM.

@jongyoul Thanks for the review!

@jongyoul Thanks for the review!
On Sat, Oct 22, 2016, 09:05 Jongyoul Lee<EMAIL_ADDRESS>wrote:

Thanks for the contribution. LGTM.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/zeppelin/pull/1550#issuecomment-255536945, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADQu6fZIeBbA_-pS06slb1krp-AeUNrTks5q2jRhgaJpZM4Kd21o
.


EntityRef not getting updated in the ui for Journal Entry

Having some difficulty getting the Journal Entry to attach an EntityRef to the line item. I've tried manually creating the EntityRef array and passing it to the Line::create method. I've also tried creating the IPPEntityRef object beforehand and adding that to the line.
I can't seem to get it to work.
 $entityTypeEnum = new IPPEntityTypeEnum(['value' => 'Customer']);

        $entityRef = new IPPReferenceType(['name' => $this->entityRef[0]->DisplayName, 'value' => $this->entityRef[0]->Id]);

        Log::debug(collect($entityRef)->toArray());

        $this->linesArray[] = Line::create([
            'JournalEntryLineDetail' => [
                'PostingType' => $postingType,
                'AccountRef' => [
                    'value' => $accountRef['Id'],
                    'name' => $accountRef['Name']
                ],
                //neither of these work.
                // 'Entity' => $this->entityRef, //getting this value by selecting the customer in a query earlier in this class.
                'Entity' => [
                    'Type' => $entityTypeEnum,
                    'EntityRef' => $entityRef,
                ],
            ],
            'DetailType' => 'JournalEntryLineDetail',
            'Amount' => $amount / 100,
            'Description' => $description
        ]);

        Log::debug($this->linesArray);

I've also tried this to create the EntityRef beforehand based on what I'm seeing in the source code. When I do this I don't get an error, but it still doesn't work.
 $refType = new IPPReferenceType(['name' => $this->entityRef[0]->DisplayName, 'value' => $this->entityRef[0]->Id]);

        $entityRef = new IPPEntityTypeRef(['Type' => 'Customer', 'EntityRef' => $refType]);

  $line = Line::create([
            'JournalEntryLineDetail' => [
                'PostingType' => $postingType,
                'AccountRef' => [
                    'value' => $accountRef['Id'],
                    'name' => $accountRef['Name']
                ],
            ],
            'DetailType' => 'JournalEntryLineDetail',
            'Amount' => $amount / 100,
            'Description' => $description
        ]);
        $line->Entity = $entityRef;

The above seems to come the closest to matching the object structure detailed in the QBO API docs for the journal entry, and it's not erroring out, just not understanding why it's also not populating the "Name" field when I view the Journal Entry.
I've also tried adding the Name field manually to a Journal Entry in the UI, then pulling it from the API and looking at how it's stored. It's coming back like this:
 \QuickBooksOnline\API\Data\IPPEntityTypeRef::__set_state(array(
             'Type' => 'Customer',
             'EntityRef' => '58',
          )),

I then tried to mimic that structure. Again, it didn't fail, but didn't update the Name field.
Has anyone successfully created a Journal Entry with the "Name" field filled in using this EntityRef parameter? Can someone explain what I'm missing here? I've been beating my head against the wall on this for too long.

Hi! Did you solve this? I have the same problem.


Do not skip nullable flag in Geo and Index references

Summary of the changes / Why this improves CrateDB
Checklist

[ ] Added an entry in CHANGES.txt for user facing changes
[ ] Updated documentation & sql_features table for user facing changes
[ ] Touched code is covered by tests
[ ] CLA is signed
[ ] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Hi @mfussenegger, can you take a look?
Context: needed Geo/Index reference constructors accepting nullable/doc values from analyzer (add column implementation) and noticed that both don't have such ctors.
As a consequence, we lose nullable and hasDocValue for GeoReference in TableInfo. IndexReference avoids this due to special handling


Improve Ruby guide

Why:

The wildcard doesn't work in setup-ruby: https://github.com/ruby/setup-ruby/issues/251
Update to the latest version of setup-ruby: https://github.com/ruby/setup-ruby/releases/tag/v1.97.0

Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Update to the latest version of setup-ruby: https://github.com/ruby/setup-ruby/releases/tag/v1.97.0

I did this because the previous version referenced, v1.75.0 (https://github.com/ruby/setup-ruby/commit/477b21f02be01bcb8030d50f37cfec92bfa615b6), does not support Ruby 3.1.

@dentarg
Thanks so much for opening a PR! I'll get this triaged for review :zap:

Thanks for following up! I followed up with the product team and opened an internal issue, but we haven't had time to implement it. I just moved the issue to the open source repo (https://github.com/github/docs/issues/17365), so you or anyone else is welcome to make the update.


Adding tag=authentication in pan_system logs

Hi guys,
is there a reason why system authentication logs (e.g. admin login, using web gui or ssh) are not tagged with tag=authentication for the CIM Authentication Data Model?
This could be useful for Enterprise Security implementation, since there are rules about authentication problem (e.g. Brute Force) that rely on the Authentication Data Model, so tag=authentication.
Thanks in advance!

Impossible! Per Sales and the Pan Docs the TA is Fully [Common Information Model] (CIM) compliant and designed for use with [Splunk Enterprise Security], 100% never any issues....
Did this ever get resolved for you?


SW-2775 Support localized enum names in search API

During code generation, generate properties files with human-readable (display)
names in English and gibberish for all the enum constants. These files are
considered build artifacts since they're generated from the database, but the
files for additional locales will go in src/main/resources/i18n.
Update the generated enum code so it loads localized names from the properties
files as needed. The English name continues to be available via the displayName
property, but it'll be removed in an upcoming change.
Update the search implementation so it uses the display names for the current
locale for matching, sorting, and rendering the query results.

Current dependencies on/for this PR:

main

PR #913

PR #914

PR #915   👈

This comment was auto-generated by Graphite.


fatal: Not a git repository (or any of the parent directories): .git

Not sure if it's properly an error on TTY once it happens on ruby-2.6.0dev, but requiring tty lib prints a git error out, even when -W0 flag is set it makes no difference:
Ruby version:
➜  test ruby --version
ruby 2.6.0dev (2018-07-06 trunk 63870) [x86_64-linux]
Weird git message:
➜  test ruby -W0 -e "require 'tty'; p 'ok'"
fatal: Not a git repository (or any of the parent directories): .git
"ok"
RVM version:
➜  test rvm --version
rvm 1.29.4 (latest) by Michal Papis, Piotr Kuczynski, Wayne E. Seguin [https://rvm.io]

Found the issue, it only happens when requiring tty package and do not happen when requiring a sub-package like tty-table for example, checking the tty.gemspec file at line 17:
spec.files = `git ls-files`.split($/)

Looks like the issue is right there, checking on this conversation on bundler package: https://github.com/bundler/bundler/issues/2039#issuecomment-10128200
They found a better way to sort out those files like:
spec.files = Dir['lib/**/*.rb'] + Dir['bin/*']
spec.files += Dir['[A-Z]*'] + Dir['test/**/*']
spec.files.reject! { |fn| fn.include? "CVS" }

so I simple did on my local gemspec:
  #spec.files         = `git ls-files`.split($/)
  spec.files = Dir['lib/**/*.rb'] + Dir['bin/*']
  spec.files += Dir['[A-Z]*'] + Dir['test/**/*']
  spec.files.reject! { |fn| fn.include? "CVS" }

and dan-dah, it worked like a charm, I'm gonna open a PR for that

Hi,
Thanks for trying out tty gem!
First of all, as a general point you shouldn't be really using require 'tty'. This library is a meta gem for scaffolding terminal apps. It is not meant to be used as a direct requirement. In future, I'm planning on having a manifest file that pulls in latest tty packages and injects them into scaffolded application without actually requiring them directly in gemspec. I would encourage you to directly specify and use the tty gems you need, mix and match! Similar to coinpare
When you require the tty file it loads all the plugins by reading them from the tty.gemspec and I can only assume evaluating the spec.files= assignment in the process. On the other hand, the tty-table uses exactly the same code as hundreds of Ruby gems generated with bundler see tty-table gemspec with a difference that it doesn't evalute gemspec when required, only on installation.
Having read https://github.com/bundler/bundler/pull/2023 & https://github.com/bundler/bundler/issues/1043 I can see both sides of the issue. There is certainly a good case for dropping reliance on external utility such as git to ensure that things with tty can be packaged easily. It would be prudent to ensure that no necessary files are skipped in the process such as dotfiles etc...
I do appreciate you bringing this to my attention and working on the fix. I'm not saying this is not the solution that I will end up using, but I need a little bit of time to investigate and make my mind up. In the meantime let's continue the dialogue and work on the solution.

perfect @piotrmurach totally agreed, one of my solutions I use a good bunch of tty libs, so it's easier  require tty straight forward, but have replaced by each gem I meant to use, indeed got ruby vm bootup time reduced, so the best option is really requiring only needed gems, haven't checked memory footprint yet
About the fix, I submitted a PR, I know it's a minor issue and the changes I made can impact in the whole solution ans user experience, so feel free to reject it or, even better, add your comments here or on the PR and I make the needed changes

Hey @quirinux I've changed gemspec to read a manifest file in order to figure out which files to include which heavily relies on your findings.
Thanks for bringing this to my attention and coming up with a solution! ❤ I will release shortly.

it is a such good idea, better than mine, cheers


Webpack tries to use less module as less-loader

Do you want to request a feature or report a bug?
Report a bug

What is the current behavior?
I'm trying to use less-loader in a webpack configuration but when running webpack, it's trying to use the less module. So it's giving me the following error: Error: Module '/path/to/project/node_modules/less/index.js' is not a loader (must have normal or pitch function). This is suppose to happen if a configure less as loader instead of less-loader, but I have it configured correctly.
If the current behavior is a bug, please provide the steps to reproduce.
Add less and less-loader and try to compile. This is my full config:
const path = require('path');
const webpack = require('webpack');
const autoprefixer = require('autoprefixer');
const cssnano = require('cssnano');
const packageJson = require('./package.json');

const rootDirs = [
  path.resolve(__dirname, 'app'),
  path.resolve(__dirname, 'test'),
  path.resolve(__dirname, 'vendor'),
];

module.exports = {
  resolve: {
    modules: [
      ...rootDirs,
      path.resolve(__dirname, 'public'),
      'node_modules',
    ],
    extensions: ['.js', '.jsx', '.less'],
  },
  entry: {
    frontoffice: [ './app/app.jsx' ],
  },
  output: {
    path: path.resolve(__dirname, '../builds'),
    publicPath: '/',
    filename: '[name].entry.js'
  },
  plugins: [
    //new webpack.DefinePlugin({
      //'process.env': { APP_VERSION: JSON.stringify(packageJson.version) },
    //}),
  ],
  module: {
    rules: [
      {
        test: /\.jsx?$/,
        include: rootDirs,
        use: [
          {
            loader: 'babel-loader',
            options: {
              presets: [ ['es2015', { modules: false }], 'stage-0', 'react' ],
            },
          }
        ],
      },
      {
        test: /\.css$/,
        use: [
          {
            loader: 'style-loader',
          },
          {
            loader: 'css-loader',
            options: {
              sourceMap: true,
              localIndentName: '[name]__[local]--[hash:base64:5]',
            },
          },
          {
            loader: 'postcss-loader',
            options: {
              sourceMap: true,
              plugins: () => [ autoprefixer, cssnano({ safe: true}) ],
            },
          },
        ]
      },
      {
        test: /\.less$/,
        use: [
          {
            loader: 'style-loader',
          },
          {
            loader: 'css-loader',
            options: {
              sourceMap: true,
              localIndentName: '[name]__[local]--[hash:base64:5]',
            },
          },
          {
            loader: 'postcss-loader',
            options: {
              sourceMap: true,
              plugins: () => [ autoprefixer, cssnano({ safe: true}) ],
            },
          },
          {
            loader: 'less-loader',
            options: {
              sourceMap: true,
            },
          }
        ]
      },
      {
        test: /\.woff([^2].*)?$/,
        use: [
          {
            loader: 'file-loader',
            options: {
              name: '/[name].[ext]',
            },
          },
        ]
      },
      {
        test: /\.woff2(.*)?$/,
        use: [
          {
            loader: 'file-loader',
          }
        ],
      },
      {
        test: /\.ttf(.*)?$/,
        use: [
          {
            loader: 'url-loader',
            options: {
              limit: 10000,
              mimetype: 'application/octet-stream',
            },
          },
        ],
      },
      {
        test: /\.eot(.*)?$/,
        use: [
          {
            loader: 'file-loader',
          }
        ],
      },
      {
        test: /\.otf$/,
        use: [
          {
            loader: 'url-loader',
            options: {
              limit: 10000,
              mimetype: 'application/octet-stream',
            },
          },
        ],
      },
      {
        test: /\.svg(.*)?$/,
        use: [
          {
            loader: 'url-loader',
            options: {
              limit: 10000,
              mimetype: 'image/svg+xml',
            },
          },
        ],
      },
      {
        test: /\.jpg$/,
        use: [
          {
            loader: 'url-loader',
            options: {
              limit: 10000,
              mimetype: 'image/jpg',
            },
          },
        ],
      },
      {
        test: /\.png$/,
        use: [
          {
            loader: 'url-loader',
            options: {
              limit: 10000,
              mimetype: 'image/png',
            },
          },
        ],
      },
    ],
  },
};

And these are the versions of the relevant packages:
 "less": "^2.7.2",
 "less-loader": "^2.2.3",
 "webpack": "^2.2.1",
 "webpack-dev-server": "^2.3.0"

What is the expected behavior?
It should compile the bundle.
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.

Could you add the full error message?

Sure, this is the full error message:
 68% building modules 1262/1300 modules 38 active ...ds/order/styles/containers/order.less/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/loader-runner/lib/loadLoader.js:35
                        throw new Error("Module '" + loader.path + "' is not a loader (must have normal or pitch function)");
                        ^

Error: Module '/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/less/index.js' is not a loader (must have normal or pitch function)
    at loadLoader (/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/loader-runner/lib/loadLoader.js:35:10)
    at iteratePitchingLoaders (/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/loader-runner/lib/LoaderRunner.js:169:2)
    at iteratePitchingLoaders (/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/loader-runner/lib/LoaderRunner.js:165:10)
    at /Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/loader-runner/lib/LoaderRunner.js:173:18
    at loadLoader (/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/loader-runner/lib/loadLoader.js:36:3)
    at iteratePitchingLoaders (/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/loader-runner/lib/LoaderRunner.js:169:2)
    at runLoaders (/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/loader-runner/lib/LoaderRunner.js:362:2)
    at NormalModule.doBuild (/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/webpack/lib/NormalModule.js:129:2)
    at NormalModule.build (/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/webpack/lib/NormalModule.js:180:15)
    at Compilation.buildModule (/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/webpack/lib/Compilation.js:142:10)
    at factoryCallback (/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/webpack/lib/Compilation.js:324:11)
    at /Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/webpack/lib/NormalModuleFactory.js:242:4
    at /Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/webpack/lib/NormalModuleFactory.js:93:13
    at /Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/tapable/lib/Tapable.js:204:11
    at NormalModuleFactory.params.normalModuleFactory.plugin (/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/webpack/lib/CompatibilityPlugin.js:52:5)
    at NormalModuleFactory.applyPluginsAsyncWaterfall (/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/tapable/lib/Tapable.js:208:13)
    at onDoneResolving (/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/webpack/lib/NormalModuleFactory.js:68:11)
    at onDoneResolving (/Users/lars/Development/Ruby/platform/app/assets/javascripts/frontoffice/node_modules/webpack/lib/NormalModuleFactory.js:189:6)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)
error Command failed with exit code 1.

Ok, my bad. The problem was that somewhere deep in the code, there were some calls to less-loader directly when importing some files, but those calls were written without the -loader part.


Prioritise short-term updates for getting started page

Sorting out insights for getting started page and identify the actions
Goal: Identify the short-term wins/updates and document the long-term wins/updates

Mocca Goal: build a backlog for the wins and updates required (include size)


Sorting money

Hey, is there a way to sort currency? For example: values $11.0 and $104.0 get sorted the wrong way since it assumes that everything is a string.

I was able to make it work using slots for formatting and treating everything as floats

Good to hear that you solved the issue..
Cheers,
Ruby.


Make target $(CHART_TEMPLATE_PATH)/mutatingwebhookconfiguration.yaml should be removed from Makefile as no mutating webhook is enabled

Remove from target $(CHARTS_DIRECTORY)/harbor-operator-$(RELEASE_VERSION).tgz

it can be kept, no much impact


Help! Track doesnt load in android device

Everything working fine in web but when in android emulator even in real device this is happen

same story

it is all about restriction. this song works perfect" 'http://mpsound.ru/uploads/tracks/510496811_572314412_1814582943.mp3'

Me too. Everything working perfectly on web browser, but in android device It's can't play the song.

Can you please try the new version? I just upgraded the module to Ionic 3. It should work by simply removing and adding the module back again npm install<EMAIL_ADDRESS>

Any update on this from original poster? Is this still happening? Did you try to update the package?
If this isn't happening anymore please close this issue. Thanks!

It´s happening again with 3.2.0

Solved! It´s not adding into package.json even with npm install ionic-audio --save. Added it manually.


change the default browser to Chrome if -b is not supplied

Launch chrome instead of Firefox if no argument is supplied for -b
@DramaFever/qa

LGTM


I want to use strict type to get contract response

Currently, typechain plugin for hardhat generates code like:
getUserCredential(
    _userId: BigNumberish,
    overrides?: CallOverrides
  ): Promise<
    ([
      BigNumber,
      [string, string, string],
      [string, string],
      BigNumber,
      BigNumber,
      BigNumber,
      ... & {
      id: BigNumber;
      context: [string, string, string];
      types: [string, string];
      expirationDate: BigNumber;
      issuanceDate: BigNumber;
      issuer: BigNumber;
      credentialSubject: ([string, BigNumber, string] & {
        key: string;
        value: BigNumber;
        rawValue: string;
      })[];
      credentialStatus: [string, string, BigNumber] & {
        id: string;
        _type: string;
        revNonce: BigNumber;
      };

What is the reason for returning an untyped array? When I use JSON.stringify on the result of the getUserCredential function, I receive an array instead of an object. How can I obtain only an object as the result of the getUserCredential function?

@ilya-korotya most likely what you get from TypeChain is an array with additional properties attached (& {...} part). This is unfortunately how ethers.js was designed.
You can simply ignore the fact that it's an array and focus on object fields.


Minor Bug fixes

Please make sure you've read the pull request section of our code contribution guidelines.
When filling in a section please remove the help text and the above text.
Summary
MM-10923 - Emoji cut off in header
MM-10930 - Improving reactions and emoji picker
MM-10959 - Fixing emoji picker in RHS expanded
MM-10963 - Updating image modal for tablets
MM-10660 - Single image expand and collapse icon
Ticket Link
https://mattermost.atlassian.net/browse/MM-10923
https://mattermost.atlassian.net/browse/MM-10930
https://mattermost.atlassian.net/browse/MM-10959
https://mattermost.atlassian.net/browse/MM-10963
https://mattermost.atlassian.net/browse/MM-10660
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Ran make check-style to check for style errors (required for all pull requests)
[ ] Ran make test to ensure unit and component tests passed
[ ] Added or updated unit tests (required for all new features)
[ ] Has server changes (please link)
[ ] Has redux changes (please link)
[x] Has UI changes
[ ] Includes text changes and localization file (.../i18n/en.json) updates
[ ] Touches critical sections of the codebase (auth, posting, etc.)

@asaadmahmood looks like there are some build errors?

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

@esethna Build passed.

Spinmint test server created at: http://i-0ba721a4786d01510.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-0ba721a4786d01510

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-00aab1d00601c7ec5.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-00aab1d00601c7ec5

Spinmint test server destroyed

@esethna @asaadmahmood I think we should consider holding off on updating the emoji picker for now since this is going to conflict a lot with the changes required for the gfycat integration

@hmhealey These are just few lines of css changes for the emoji picker. If you want, you can push me the gfycat branch if you're having trouble, and I can merge the css changes I don't think it's going to be that big of an issue. Since there are just not a lot of changes.

@asaadmahmood We've asked them to make a lot of changes already, so I'd rather not make them deal with additional merge conflicts since the changes that you're making directly conflict with theirs which are high priority for 5.1. If the changes you're making are to fix the linked bugs, we can deal with those conflicts, but some of these look like they're unrelated improvements rather than bug fixes.

@esethna I've removed my changes.  Was just looking at the Gfycat channel, and it looks like the feature might need some help with the styling. I can then add these changes when I'm doing the styling improvements there.


Exclude unnecessary file from cmake

The fact that there are quotes is a good sign that VS has automatically added it.
NoLogging commit introduced it, so it was not in the release. This change will go in now.

The NoLogging commit introduced it, so it was not in the release. This change will go in now.


os: consider syscall.EEXIST in os.IsExist

Note that I'm not very categorical in my issue title, but this debugging of a subtle Afero file system bug has given me enough gray hairs to at least deserve an issue/discussion.
The program below runs fine on *nix but fails on Windows (it compiles fine):
package main

import (
	"log"
	"os"
	"syscall"
)

func main() {
	if !os.IsExist(syscall.EEXIST) {
		log.Fatal("failed")
	}
}

I assume that syscall.EEXIST will never happen on Windows, and then it should probably also not be defined for Windows. I guess that ship has sailed, but you should then consider to expand os.IsExist on Windows to also include this error. Because there may be other people creating file system abstractions that can be bitten by this.
/cc @spf13

I assume that syscall.EEXIST will never happen on Windows,

syscall.EEXIST will never happen on Windows,

and then it should probably also not be defined for Windows.

It should not be defined on Windows.
As far as I remember (I could be wrong), when first Windows version of Go appeared, we copied modified UNIX version of syscall package to make all other packages work. And only later we started writing Windows code in packages other than syscall.

I guess that ship has sailed,

Maybe we can remove these symbols in Go 2. Whatever Go 2 is.

but you should then consider to expand os.IsExist on Windows to also include this error. Because there may be other people creating file system abstractions that can be bitten by this.

I don't see syscall.EEXIST used under $GOROOT on Windows. I doubt anyone uses syscall.EEXIST on Windows. I think, expanding os.IsExist to include syscall.EEXIST will confuse this matter even more. I think we should leave it alone.
syscall package is platform specific. You cannot assume that syscall.EEXIST will behave one way or the other on Windows.
Alex

I doubt anyone uses syscall.EEXIST on Windows.

I linked to a widely used example in my issue report:
https://github.com/spf13/afero/commit/5e9f8ecaa4af2dddc638b1a8a4a58834f54878aa

I doubt anyone uses syscall.EEXIST on Windows.

I linked to a widely used example in my issue report:

Fair enough. I take my word about "anyone uses syscall.EEXIST on Windows". But my point still stands - you assumed things about syscall.EEXIST that were never there. You fixed your code. I don't think there is anything else to do.
Alex

you assumed things about syscall.EEXIST that were never there.

Let me be clear: This is not my code. I fixed some other person's code. And the repository I linked to is owned by a person that happens to also be on the Go team at Google -- which may indicate that this is a mistake that is a little bit too easy to make.

And the repository I linked to is owned by a person that happens to also be on the Go team at Google -- which may indicate that this is a mistake that is a little bit too easy to make.

Everyone makes mistakes. Only people who don't write code do not make mistakes.
The person who wrote the code, should not have used syscall.EEXIST on Windows. That is the mistake here as far as I am concerned. How do you propose to stop feature developers to use syscall.EEXIST on Windows by changing os.IsExist?
Alex

@bep you could propose a documentation change to warn readers about this...

This sounds to me like a documentation change needs to be made.
I'm the one who wrote the offending code originally. If there were better
docs, I wouldn't have.
On Mon, Dec 17, 2018 at 2:24 PM Liam<EMAIL_ADDRESS>wrote:

@bep https://github.com/bep you could propose a documentation change to
warn readers about this...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/29295#issuecomment-447966688, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAKlZO8lrArEd93EwRBb4Im7poXyO_Jaks5u5--BgaJpZM4ZVMKy
.

This sounds to me like a documentation change needs to be made.

Any documentation sounds good to me. I just do not know what to say - Do not use EEXIST!? It would require some explanation of why not to use.

But once we made that mistake, it seems that we may as well carry it forward to functions like os.IsExist, for precisely this reason: because some code that runs on Windows may start using it.

I do not see reason for syscall.EEXIST to be used on Windows. So I believe code with syscall.EEXIST is broken. I don't see how making os.IsExist(syscall.EEXIST) return true helps in this situation.
What would the code that uses syscall.EEXIST would look like?
Alex

The code that uses syscall.EEXIST would look like
// Special purpose file system later available on both Unix and Windows.
func (mfs *MyFileSystem) Open(path string) (*MyFile, error) {
    if mfs.noSuchPath(path) {
        return nil, syscall.EEXIST // this error is available on both Unix and WIndows
    }
    ...
}

The code that uses syscall.EEXIST would look like

Sorry my message is long.
It is mistake (in my opinion) to import syscall package into the source file that is compiled for both Windows and Linux (I assumed your code builds on both *_linux.go and *_windows.go).
I know source files like that happens here and there, but I find they always causes problems for me.
For example, for https://github.com/golang/go/issues/28477#issuecomment-437645844 I tried to make $GOROOT/os/pipe_test.go to work on Windows. So I removed !windows from +build line, and the pipe_test.go file "nearly" builds. pipe_test.go file uses syscall package in many places, but since it builds I decided to try and make it work. Unfortunately it is not easy - Linux and Windows versions are similar (they have similar symbols), but semantically everything works differently. Linux process uses 0, 1, 2 for stdin, stdout, stderr, but Windows do not. Linux can have extra file handles passed to the new process, but Windows cannot. It was very confusing and time consuming to debug.
Also, please show what mfs.noSuchPath does. If mfs.noSuchPath uses os package to implement its logic, then mfs.noSuchPath should just return whatever error it receives from os package. If mfs.noSuchPath does not uses os package, then you should not be using os.IsExist to test returned errors. Unless you write tests that show it is OK to use os.IsExist.
Also not many people will be writing code like yours. But os.IsExist code is read by everyone. If we are to make code change, we would need some good comment there explaining the problem and our reasoning.
Also, if we start worrying about people using syscall.EEXIST incorrectly only because EEXIST name exists on both Windows and Linux, we should worry about many other errors in syscall package: ENODEV, ENOEXEC and many others. Should we also try and make syscall.Syscall "safer" to use for people who just build their Linux code on Windows?
Alex


New nixos executable

Issue description
nixos-rebuild interface looks a bit archaic. Maybe we can have a better Nixos frontend CLI?
Just brain dump, but...
Technical details
Basic features:

installable as package, even on non-nixos
is named nixos
is written in C++ and binds to Nix C++ library (or maybe Haskell? Nodejs? What you think?)
autocomplete, ncurses, Nix 2.0
commit to Git by default on each rebuild, warns on used .nix files outside of git repo

Subcommands
First I'll describe existing nixos-rebuild switches, that should go into new command:

nixos-rebuild switch -> nixos rebuild, nixos rebuild --boot --activate
nixos-rebuild boot -> nixos rebuild --no-activate
nixos-rebuild test -> nixos rebuild --no-boot
nixos-rebuild build -> nixos build
nixos-rebuild dry-x -> nixos x --dry, nixos x --test
nixos-rebuild --build-host -> nixos --build-on
nixos-rebuild --target-host -> nixos --deploy-to
nixos-rebuild switch --rollback -> nixos rollback opens a curses screen so you can select what to rollback to

Then, existing commands should be intergrated. All of those should work on non-NixOS:

nixos-option X -> nixos option X
nixos-generate-config -> nixos config --default, outputs to stdout
nixos-install -> nixos install
nixos-container XXX -> nixos container XXX
nixos-version -> nixos -v, nixos --version. nixos -vv should be same as nix-info

Some external projects should be merged in:

nixos-infect -> nixos infect --confirm-infect, also nixos infect --confirm-infect --deploy-to

And probably some new stuff added:

show all options -> nixos options, the output should be fast and compatible with FZF
lustrate thing -> nixos lustrate --confirm-lustrate
nixos options --edit should start a webserver, browser and provide interactive point-and-click editing experience

Anything missed?

Related issue: https://github.com/NixOS/nixpkgs/issues/51198
I think nixos-lib (or equivalently nixos lib) should contain all NixOS activation scripts, rewritten in C++/Rust/Go/whatever.

nixos-rebuild just got an edit command :) https://github.com/NixOS/nixpkgs/pull/56241

I think I mentioned this before somewhere but SLNOS doesn't use nixos-rebuild (because there's no /etc/nixos equivalent in SLNOS) and does a lot of this with a simple bash script, e.g.:

$ slnos build --on machine --for other-machine other-machine.nix
$ slnos build --on machine --for other-machine

(both do the same thing) will build other-machine.nix (this will be its configuration.nix, but you can specify several files at the same time and it will then generate a temporary nix file with imports a-la NixOps) on machine, nix-copy over to other-machine. switch, boot, test, and etc are selected interactively after the fact, or with

$ slnos build --on machine --for this-machine this-machine.nix temporary-networking-changes.nix --and-then test

(I do this one all the time.)
I don't see why nixos can't do the same.

Another thing I'd like to see supported is -L/--print-build-logs for nixos-rebuild, which already exists for nix build.

this is still needed to make NixOS more userfriendly
a next step could be a usable prototype as wrapper in python or whatever you like

Since my last comment I have discovered nix-top, which I use to see what a build is currently struggling with.

This is not just about usability by the way, there is a lot of duplication in the nixos-* tooling. They all accept roughly the same nix options,  which get passed through to nix calls. And actually they do get out of sync with both nix itself and each other from time to time..

Looks like nixos-rebuild build-vm[-with-bootloader] is missing a subcommand.

commit to Git by default on each rebuild

This is an antipattern and I really hope there will be an option to disable this!

Not stale, I hope?

How about nixos gc -d for nix-collect-garbage -d && /nix/var/nix/profiles/system/bin/switch-to-configuration boot?

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixpkgs-cli-working-group/30517/5

I've made a precursor to this that's still in very early stages, just to see where it can go. The repo is here, I'd like to see how far this can be taken.


feat: added ability to be compiled under project with extensions

UIApplication.sharedApplication cannot be compiled under project with extension targets, so I make a tiny fix on this.

What's the compilation error? Is that API unavailable in extensions? 😯

Yes, UIApplication.sharedApplication is unavailable in extensions. 😂

I found that in iOS 13, when a presentationController like  FLEXGlobalsTableViewController and FLEXHierarchyTableViewController dismissing with a swipe, resignKeyAndDismissViewControllerAnimated:BOOL:completion cannot get called. This will cause a bug because keywindow is not set back.  I make a tiny fix on this.

I have fixed this in the 4.0 branch on my fork, take a look

(Haven't gotten around to merging this PR yet but I will)

With your permission, I would like to refactor this PR into a compile-time check using preprocessor directives. I have my code ready to push to your fork and merge.
Unfortunately, Xcode does not provide a preprocessor variable to detect whether the target is an extension, so we will have to instruct users to add a define for FLEX_TARGET_IS_EXTENSION in their project settings.
What are your thoughts?


Images problem

Hello!
My repository documentation has some images in their own folder but docsify refuses loading it.
Here is my repository and here is the website.
As an example:

Everything is working Here in the github

But it's not working here
Can you help me fix this?

You should use Tutorials/1/ContactList.PNG.
This is a known problem, I haven't idea how to solve it.

with
![Contact List](Tutorials/1/ContactList.PNG "Contact List")
Github refuses loading it


Fix samples to run with latest kestrel

Replaced beta1 with * in project.json and added routing configuration in MVC sample.

Hi @drussilla, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.msopentech.com.

TTYL, MSOTBOT;

@drussilla, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSOTBOT;

The dev branch should have this


Fix headers in github markdown renderer

At the moment, github does not render hashtags directly followed by a
string as headers, by adding a space between the hashtags, Github will now
properly see it as as headers, and the file will look better.

@ferrybig, thank you :)


Use Guice injector for instantiate IRetryAnalyzer

TestNG Version
7.4.0
Expected behavior
Test has been launched
Actual behavior
org.testng.TestNGException: Cannot instantiate class org.testng.IRetryAnalyzer
Test case sample
@Guice(modules = GuiceModule.class)
public class TestRetry {

    @Test(retryAnalyzer = IRetryAnalyzer.class)
    public void test() {
        assert false;
    }
}

public class GuiceModule extends AbstractModule {

    @Override
    protected void configure() {
        bind(IRetryAnalyzer.class).to(Retry.class);
    }
}

public class Retry implements IRetryAnalyzer {
    private int count = 1;

    @Override
    public boolean retry(ITestResult result) {
        return !result.isSuccess() && count-- > 0;
    }
}

Why I need this?
I use dependency injections inside my IRetryAnalyzer implementation, so I got NullPointerException if some @Inject private MyDependency field; are present in the Retry class.

After check the source code, it may not work for values of Test using @Guice, so maybe you could use Retry directly in @Test(retryAnalyzer = Retry.class), I think this @Guice only works for inject. if not, @juherr could please give some comments about this.

I confirm that @Test(retryAnalyzer = Retry.class) is the best option.
I think a workaround could be possible via https://javadoc.jitpack.io/com/github/cbeust/testng/master/javadoc/org/testng/annotations/ObjectFactory.html
where you can force the injection by guice (the callback is expected for any object created by testng).
But it is not a common use-case and can't tell if it will work easily.

Yes, @Test(retryAnalyzer = Retry.class) is obvious solution, but my Retry class looks like:
public class Retry implements IRetryAnalyzer {
    private final int count;
    @Inject
    private Retry(MyExternalDependency dependency) {
        count = dependency.getCount();
    }

    @Override
    public boolean retry(ITestResult result) {
        return !result.isSuccess() && count-- > 0;
    }
}

So, I need Guice to resolve and provide MyExternalDependency
@juherr , any chance to use org.testng.internal.objects.GuiceBasedObjectDispenser for IRetryAnalyzer instance creation?
I could implement this by my self, if possibility exists.

@juherr - Please allow me some time. I will have to get back on this.

@qwez , @bj-9527 , @krmahadevan , I do not fully understand the discussion here, however, it would be great if you could add a use-case to TestNG DI discussion (feel free to request editing permissions or just comment)

@krmahadevan have you had a chance to look on this?
@juherr btw, actually, I'am not looking for a workaround (I have one). I think this issue is a bug or feature request, isn't it? All other instances (like DataProvider) are being created with Guice, but RetryAnalyzer is not. Why?

@qwez - No. I havent found time yet. I will try to get to this as soon as i get some time.


Fix the bug for issue #46 (getRotationPitch returns NaN).

GearVRf-DCO-1.0-Signed-off-by: Guodong Rong
<EMAIL_ADDRESS>

Now we only do scaling when rotation_ is updated.

Codes look good to me.
@santhyago Can you help check again with your test codes?


File permissions on intended config and doc files

Issue Summary
for every build run, any files that have been pulled from git that have had a change from someone else have the perms 0644, when I run the build playbook, I get a lot of change messages as part of the [arista.avd.eos_cli_config_gen : Generate eos intended configuration] and [arista.avd.eos_cli_config_gen : Generate device documentation] tasks.
I think this is due to the default perms git gives files, vs the perms that arista ansible avd is setting.  I see that the mode is set to 0664 in a lot of places in the arista.avd collection.
Ideally I would like to not see a change for hosts that have not got a config change.  This file perms change is masking that.
The umask on the system is set to 0022, which is our company default, and I think generally the system default on most distributions.  Would it be more sensible to have the permissions in AVD set to 0644 which would align with system umask defaults?
Which component(s) of AVD impacted
[arista.avd.eos_cli_config_gen : Generate eos intended configuration]
[arista.avd.eos_cli_config_gen : Generate device documentation]
How do you run AVD ?
Ansible CLI (with virtual-env or native python)
Steps to reproduce
1. git pull the repo that someone else has changed some host config on, built and committed.
2. run the build locally

Relevant log output
changed: [lotnlom208 -> localhost]
--- before
+++ after
@@ -1,2 +1,2 @@
-mode: '0644'
+mode: '0664'
 path: /data/home/rhall/git/ansible-avd/inventory/prod/documentation/devices/lotnlom2a.md

Contributing Guide

[X] I agree to follow this project's Code of Conduct

Today the the changed mode is also considered a change, so the file will be updated. It is the first time I have heard about issues with this, so I do not agree it is a general issue as such. My suggestion would be a configuration knob to control the mode of the generated artifacts.
I think this might have been changed/fixed as part of the recent refactoring of eos_cli_config_gen, so if you could run a test with 4.9.0-dev1 (remember to install updated python dependencies).

@rich9474 please test again with the latest AVD version 4.9.0. Thanks.


Updated link per bug request

https://office.visualstudio.com/DefaultCollection/MAX/Office and O365 Content/_workitems/edit/2639333
old: link to the https://www.microsoft.com/procurement/supplier-contracting.aspx
new: https://www.microsoft.com/en-us/procurement/supplier-contracting.aspx#SSPA

.


Missing export options at top right

I'm not seeing the export options (pdf, print, ect..) at the top right conner is this implemented?

I guess it is currently not supported. But from my point of view it would be great to have. If you have the spare time you could make a pull request and add this exporting file to the package.

@jhuenges I just add the extra file to compatibly folder I also need the no data module. It might better to do it this way that way each user can decide what modules they want to use.

Hi, was this ever added to the project? And if so, how can it be implemented?
and thanks for the great package.

Hey @acomito! This was never added to the package. Currently my time is limited, but you are welcome to open a pull request. The link to the export file is still the correct one. Just add it to the lib folder and reference it in package.js


Replace k8s.io/utils/pointer with k8s.io/utils/ptr

Stops using the deprecated package.
Kind
/kind cleanup
Release Note
NONE

I didn't know k8s.io/utils/pointer had been deprecated. Thanks for letting me know!
/lgtm


See multiple client cursor

I can see my friend's cursor 2 times, one real and another one reversed

+1
When the real cursor is bottom right another cursor is mirrored over the origin of my screen to the top right, upside-down.

Thanks for you findings, however this ticket is a
Duplicate of #25


Change near/far clip plane

Firstly, big fan - thanks for making this. I noticed the "far" clip plane seems to be 100 which was too small for me, i've modified the projection matrix in my project to be 0.1 to 1000
Could this be made customizable or changed?

I ran into this same issue and set up a PR to add this option in #13 - thanks @vaneenige and @Jijjy !

Merged in https://github.com/vaneenige/phenomenon/pull/13 and published to npm!


Fix authentication

Because time.Now() is called twice, it may return different results on a
slow machine, causing an invalid authentication header to be generated.

thanks!.


feat: Add x86-64 AVX2 support

This PR adds the very basic x86-64 AVX2 support. I can get

178.91791 tokens/s, 2 threads
298.54083 tokens/s, 32 threads

Demo show:
     Running `target/release/crabml-cli 'Hello, World'`
Hello, Worldie. He was very stubborn but he liked to do things his own way. One day, he saw a razor lying on the ground and he knew he shouldn't touch it. Excited, he paused and stood in front of it. He saw his reflection on the shelf. Suddenly, he felt a cold wind. He jumped and ran away but was in pain when he saw a mean old selfish wolf blocking his way. The wolf said toanna, "What are you doing here? This is my place and I don't want to give sugar around it. You'll have to help me!"
Crawie was afraid and he didn't know what to do. No matter how much he tried to move, he couldn't. Finally, he felt exhausted.
Just then, the mean old wolf came around the corner. He said, "If you take some sugar from there and I won't mind". awardedngtop's crying, Rayie offered the wolf. But the wolf wolded him and it turned to a mean witch and made Annie even more poutier and barjine had come to his aid. And
178.91791 tokens/s, 2 threads
RUSTFLAGS="-C target-feature=+avx2" cargo run --release "Hello, World"  176.16s user 8.36s system 802% cpu 23.004 total

Let me fix the CI.


fix(EU): update default of ScheduleChargingClimateRequestOptions::DepartureOptions::days to non-empty to avoid API error

Server rejects schedule charge/climate request when day is empty

Thank you for this!


adds frontend.yml for containerization

Per containerization documentation
This adds a frontend-yml file to malware

Codecov Report
Base: 0.00% // Head: 0.00% // No change to project coverage :thumbsup:

Coverage data is based on head (4a5e584) compared to base (1f08fdf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #50   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files          36      36
  Lines         549     549
  Branches      179     179
======================================
  Misses        499     499
  Partials       50      50

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@adonispuente I believe this needs to go into a 'deploy' directory, eg deploy/frontend.yaml.  Because when I run malware-detection-backend tests I get this error (and I see its looking in the deploy directory):
14:39:00 2022-09-29 04:39:00 [ WARNING] [          MainThread] http response 404 for url https://raw.githubusercontent.com/RedHatInsights/malware-detection-frontend/1f08fdf806695925fde1137c520e0119e57f8c4f/deploy/frontend.yaml, checking for template in current working dir...


bug/partion_pdf import statement not completing execution

Describe the bug
Import Statement is taking forever to execute:
I have tried to import
from unstructured.partition.pdf import partition_pdf
and the import statement is taking  forever to execute.
I am using conda python - 3.10.
To Reproduce
I am running this code in a conda environment. I created an unstructured environment using the environment.yml file in the GitHub repository. I installed Poppler using conda forge and tesseract-ocr by downloading the .exe file. The first line of code is
from unstructured.partition.pdf import partition_pdf
and it is completing the execution. There are no errors but, it is not completing the execution.
Expected behaviour
I just expect the execution to be complete, but it is not completing even after 2 hours of running the code.

Trying to narrow down whether it is something specific to PDF.

@scanny
This happens with most of the partition packages that I tried to import

I have no problem when I try to import partition_via_api

I have no problem with import unstructured

These import statements don't complete even if I leave the computer running for a hour

Can you try interrupting the wait with ^C and check the stack trace that you get? Maybe do that a few times and see if the results are consistent then post it here. That should give some idea where things are hanging.

Closing as incomplete.
@viboognesh if you have more information on this, please feel free to reopen :)


Spark/HDFS leader can die, causing our cluster to discover the true depths of sadness

See #123. Essentially, since we bid spot instances for all of the instances in our cluster, the Spark master and HDFS namenode run on a spot instance. If and when this instance is revoked, our cluster achieves a deepness of despair that is truly bleak. Our worker nodes fail, but cannot be recovered since our Spark/HDFS workers and Spark jobs rely on knowing the master IP via parameters, and we cannot meaningfully restart them (pointed at a new master) without modifying the jobstore.
To fix this, we have worked out a modest proposal:

@hannes-ucsc will add hooks to the überscript that identify when a cluster has lost a node, and kills all of the nodes in a cluster. This is crude, but suffices.
@hannes-ucsc will update cgcloud so that we can tag instances (e.g., the master), which makes it easy to dynamically find the master IP.
@fnothaft will restructure the adam_pipeline to resolve some other issues (job decomposition) that make it impossible to reliably restart the ADAM jobs due to lack of input/output checkpointing

Or, just run on-demand instances.

[ ] @hannes-ucsc https://github.com/BD2KGenomics/toil/issues/706
[ ] @fnothaft #134

Will be resolved by BD2KGenomics/toil#786


Is there a way to render based on what latex content returned from database?

@apendua, is there a way to render based on what latex content returned from database?
For example, in my template I have

{{#mathjax}}{{content}}{{/mathjax}}

and this content is from a helper function
Template.templatename.helpers({
  content: () => Contents.findOne().content
});

@tonystevens Yes, definitely.
However, you may want to put your content in {{{...}}} to prevent HTML escaping. Please let me know if it helped.

Thanks @apendua, it works. A follow up question, if the helper function returns an array of message that contains id and content (content is in latex format),
Template.templatename.helpers({
  messages: () => Messages.find({}) // returns [message], message {id:String, content:String}
});

and in the template, I have

{{#each message in messages}}
  {{message.id}}
  {{#mathjax}}
    {{{message.content}}}
  {{/mathjax}}
{{/each}}

the message.content won't render.
Do you know if there is a way to resolve this?

Never mind, I figured it out offline. Thanks, @apendua

@tonystevens Cool! Let's close the ticket then


CompositeData for multiple processing inputs

Is your feature request related to a problem? Please describe.
In many data processing tasks there are multiple distinct inputs, e.g. generating the smartspim template or training a model. We added minimal support for this in #1166 in the form of a list of input locations, but discussed a plan to add additional context explaining the selection of those inputs.
Describe the solution you'd like
class CompositeData(AindModel):
    """Description of a group of data assets used together"""
    data_assets: List[str] = Field(..., title="Data assets")
    shared_metadata: Optional[AindGenericType] = Field(
        default=None,
        title="Shared metadata",
        description="Common attributes that provide context for this grouping of assets"
    )
    curation_purpose: Optional[str] = Field(
        default=None,
        title="Curation purpose",
        description="Reason for grouping assets together for processing"
    )

Describe alternatives you've considered
The most obvious alternative is to create a separate DataProcess stage for "curation" or the like, with no inputs and the list of curated assets as an output parameter. Other contextual fields could be entered as notes or parameters of the process.
Additional context
One advantage of a separate object for this is that it would be easier to write a script to run a new process on the same set of data assets as a previous processing result (could be a common use case for model evaluation etc).
Unclear if this would be reused/allowed anywhere other than the input field of DataProcess
This is also related to the discussion https://github.com/AllenNeuralDynamics/aind-data-schema/discussions/1148

I wonder if we can be more specific about the shared metadata. Not sure what that looks like, I just want to avoid this being a huge dump.

Yes I guess we'd discussed limiting that to something like "Key shared attributes used to select this group of assets" - maybe the title could actually be "Defining metadata" or "Defining attributes"?

@dbirman added the 2.0 label to this to keep it on your radar as something that Saskia and I thought should be coordinated with that update.

this should probably also include a bit of upgrader work checking for existing metadata that uses a comma-separated list in the current fields like input_location etc (probably not many but at least a few)


Extend to support jdk11 as well

Hi there,
I tried to use your Action on this past weekend, but you're using Maven for Java 8, whereas the app I am building is on Java 11. There's a fork of your repo that creates subfolders for Java 8 + Java 11, and I opened up a PR against that one so that it works a bit nicer.
I was wondering if you're interested in extending support in your repo to support jdk11 as well. If so, I could open up my PR directly on your repo as you're the original Action maker (we could keep the generic action at jdk8 so it's backwards compatible).

Hi,
the main problem I see here is that I am publishing the Action in the Workshop (it's a beta test). I wrote about it with a GitHub Staff, but it is not planned to support the multiple folder actions, like in your repository.
Actually I would say most applications are build in Java 8, so upgrading the complete Action wouldn't make sense.
I eventually will create other standalone actions for Java 10 and 11.
Please let me know if you know any workarounds for the problem.

Nope, I can't think of another way to do it if not multiple folders. That being said, I've seen a few other repos using multiple folders for different actions.
It's not exactly the same thing, but the principle is similar. For example, in the docker actions: login, cli, and tag are all in subfolders.  (Also Azure has a github actions repo with subfolders for different actions.)
In any case, do whatever you think is best. I am okay using my fork at the minute, although one day I would like to delete it and use yours or someone else's Maven action.

Hey, should I close this issue, or would you like to keep it open for longer?

I think I can close it. I will add the newer java versions as new actions, but it's a matter of time when I can add them.


How to write Doc String for Enums ?

I want to get the Doc String for every single Enum Item like Timing.Setup.LoginDialog if I hover them ( in this case I want to hover LoginDialog and see 30 Seconds - Maximum Time.. ) in VSCode.
Here the Example Code:
from enum import Enum

class Timing:

    class Setup(Enum):
        Open = 300  # 5 Minutes - Maximum Time the Setup Application needs to open
        LoginDialog = 30  # 30 Seconds - Maximum Time the Fadein of the Login Dialog needs

@dschiller This looks like a feature request on language server. Moving to the LS repo.


chore: convert dash into an extra dependency

Since __init__.py doesn't import dash_wrappers.py, there shouldn't be any ImportErrors. In the future, you can consider having a contrib package with useful stuff like the dash_wrappers and other useful abstractions.
I also edited the README.md a bit for the new install instructions.

@0xMochan could you update the github workflow files to also install the newly optional dash dependencies? CI needs those to run the smoke tests

Apparently, you have to run poetry update first so that the extras are available to poetry install. I'm not sure how to run the tests locally, but I was able to get the package to install.


Print message on ^D exit

It seems pry nor irb output any message when exiting, so for now I've opted to at least exit with a newline in b25bada206b2fe5451ee30767ccc45b6ea164311.

:+1:


fix ctest label for transaction tests on CI

I think the solution to the slow tests (when running ctest ...) is for me to just transition to the existing integration guard in the test/utils.   I'll open a ticket for that conversion, and add that work in here.


Initial RoutingRSocketConnector implementation

Simple usage looks like (RoutingRSocketClient is of course optional).
RoutingRSocketClient client = RoutingRSocketConnector.create()
		.routeId(id)
		.serviceName("ping")
		.toRSocketClient(TcpClientTransport.create(port));

client.requestChannel(Flux.interval(Duration.ofSeconds(1)).map(i -> {
		ByteBuf data = ...
		ByteBuf routingMetadata = client.address("pong");
		// or ByteBuf routingMetadata = client.address(tags -> 						logger.debug("Sending ping" + id);
		return DefaultPayload.create(data, routingMetadata);
});

In general LGTM. However, I would add a Route interface as we discussed that previously and than make make RoutingRSocketClient implements RSocketClient, Route and then RoutingRSocket implements RSocket, Route.
WDYT, @spencergibb?

Remind me what Route looks like

@spencergibb Guess it should be a simple interface like the following:

interface Router {
  void encodeAddressMetadata(CompositeByteBuf metadataHolder, Consumer<Tags.Builder> tagsConsumer)
}

Oh, right. Yes. I'll do that.

I missed this part.

and then RoutingRSocket implements RSocket, Route.

Are you suggesting I wrap RSocket that also implements Route?


feat: Implement python binding

Work in progress.
Related issue: https://github.com/gluesql/gluesql/issues/480.
TODO: Write some binding test codes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 98.619%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
46286

Relevant Lines:
46934

💛  - Coveralls


next: prep for @next release

We should probably update all these spots on the site as well:

Closing this in favor of #1347 b/c lazy and don't want to resolve all the merge conflicts :)