AttributeError: 'dict' object has no attribute 'name'

System information

Have I written custom code: No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Mac OS X Catalina
TensorFlow installed from: binary
TensorFlow version:  2.2.0.dev20200427
Python version: 3.7.5

Describe the current behavior
I get the error

AttributeError: 'dict' object has no attribute 'name'

when I try to plot a model, with tf.keras.utils.plot_model, where I specify the loss to the compile method as a dictionary. According to the documentation, this should be possible and this was actually possible in TF 2.1 (i.e. until recently I was using the exact same code with TF 2.1 and no error was thrown).
Describe the expected behavior
No error.
Standalone code to reproduce the issue
import tensorflow as tf

def get_model(input_shape, num_classes=10):
    model_input = tf.keras.layers.Input(shape=input_shape)
    x = tf.keras.layers.Conv2D(6, 3)(model_input)
    x = tf.keras.layers.Flatten()(x)
    model_output = tf.keras.layers.Dense(num_classes, name="my_output_layer")(x)
    model = tf.keras.Model(model_input, model_output)
    model.summary()
    return model

def train():
    model = get_model((28, 28, 1))

    model.compile(loss={"my_output_layer": "categorical_crossentropy"})

    # IF YOU COMMENT THIS, NO ERROR OCCURS!!!
    tf.keras.utils.plot_model(model, to_file="model.png", show_shapes=True)

if __name__ == '__main__':
    train()

I installed pydot with pip install pydot. The version that was installed is 1.4.1.
Clearly, the error is due to the fact that plot_model thinks that the loss is also a layer.
I need to use TF 2.2 because I am using another library that requires the nightly version of TF.

@nbro
I ran the code shared above and do not face any error on nightly, please find the gist here.

@Saduf2019 If I run your notebook, I get the error I am reporting above. Please, run it again!

I get this error in tf 2.1, but only if I use
weights = Input(shape=(1,), dtype=tf.float32, name='l2_weight') model = tf.keras.Model(     inputs=tuple([input, weights, y_true]),     outputs=tuple([y_pred])) model.add_loss(     weighted_squared_error(y_true, y_pred, weights), name='weighted_loss') model.compile(optimizer=opt(learning_rate=lr))
Using this code works fine, but it's no use because I want to be able to use a custom loss function with weights as an input:
model = tf.keras.Model(     inputs=input, outputs=y_pred) model.compile(optimizer=opt(lr=lr), loss='binary_crossentropy')

@nbro
Yes i confirm on rerunning the gist i am able to see the error.

When this happens, tensorflow appears to have appended an empty dictionary to model._layers. A workaround for the moment is, once the model has been compiled, to use:
model._layers = [layer for layer in model._layers if not isinstance(layer, dict)]

System information

Have I written custom code: No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Mac OS X Catalina
TensorFlow installed from: binary
TensorFlow version:  2.2.0.dev20200427
Python version: 3.7.5

Describe the current behavior
I get the error

AttributeError: 'dict' object has no attribute 'name'

when I try to plot a model, with tf.keras.utils.plot_model, where I specify the loss to the compile method as a dictionary. According to the documentation, this should be possible and this was actually possible in TF 2.1 (i.e. until recently I was using the exact same code with TF 2.1 and no error was thrown).
Describe the expected behavior
No error.
Standalone code to reproduce the issue
import tensorflow as tf

def get_model(input_shape, num_classes=10):
    model_input = tf.keras.layers.Input(shape=input_shape)
    x = tf.keras.layers.Conv2D(6, 3)(model_input)
    x = tf.keras.layers.Flatten()(x)
    model_output = tf.keras.layers.Dense(num_classes, name="my_output_layer")(x)
    model = tf.keras.Model(model_input, model_output)
    model.summary()
    return model

def train():
    model = get_model((28, 28, 1))

    model.compile(loss={"my_output_layer": "categorical_crossentropy"})

    # IF YOU COMMENT THIS, NO ERROR OCCURS!!!
    tf.keras.utils.plot_model(model, to_file="model.png", show_shapes=True)

if __name__ == '__main__':
    train()

I installed pydot with pip install pydot. The version that was installed is 1.4.1.
Clearly, the error is due to the fact that plot_model thinks that the loss is also a layer.
I need to use TF 2.2 because I am using another library that requires the nightly version of TF.

When this happens, tensorflow appears to have appended an empty dictionary to model._layers. A workaround for the moment is, once the model has been compiled, to use: model._layers = [layer for layer in model._layers if not isinstance(layer, dict)]
Your example would therefore read:
import tensorflow as tf

def get_model(input_shape, num_classes=10):
    model_input = tf.keras.layers.Input(shape=input_shape)
    x = tf.keras.layers.Conv2D(6, 3)(model_input)
    x = tf.keras.layers.Flatten()(x)
    model_output = tf.keras.layers.Dense(num_classes, name="my_output_layer")(x)
    model = tf.keras.Model(model_input, model_output)
    model.summary()
    return model

def train():
    model = get_model((28, 28, 1))

    model.compile(loss={"my_output_layer": "categorical_crossentropy"})
    model._layers =
    # IF YOU COMMENT THIS, NO ERROR OCCURS!!!
    tf.keras.utils.plot_model(model, to_file="model.png", show_shapes=True)

if __name__ == '__main__':
    train()

For some reasons, the last layer in my model._layers is a ListWrapper, and I am using multiple loss functions.
Thus, I am using the following snippet as a workaround:
from tensorflow.keras.layers import Layer
model._layers = [
    layer for layer in model._layers if isinstance(layer, Layer)
]
plot_model(model)

This is fixed with tf-nightly 2.4.0-dev20200828.
See gist for your reference. Thanks!


no longer broadcast the install_referrer intent

"react-native-iap": "^2.4.9"
"react-native": "^0.59.5"
Android
I received an email from Google as below.

Hello Google Play Developer,
We recently announced that we’ll be deprecating the install_referrer intent broadcast mechanism. Because one or more of your apps uses this intent to track referrals, we wanted to ensure you make the switch before March 1, 2020. After this date, new versions of the Play Store app will no longer broadcast the install_referrer intent after app installs.
Action required
Migrate to the Play Install Referrer API to track your app installs for the following apps and/or games.
The Play Install Referrer API offers better performance, uses a secure communication channel between your app and the Play Store, and offers a more robust solution against spoof and attribution fraud.

It may happen due to below receiver
<receiver
            android:name="com.google.android.gms.measurement.AppMeasurementInstallReferrerReceiver"
            android:enabled="true"
            android:exported="true"
            android:permission="android.permission.INSTALL_PACKAGES" >
            <intent-filter>
                <action android:name="com.android.vending.INSTALL_REFERRER" />
            </intent-filter>
        </receiver>

How to resolve this?

Since I'm not sure how I can resolve this issue, I hope you can provide any further ideas on how to overcome this problem.

@hyochan
Google play has suggested required action as below.  this might be useful to you.
Migrate to the Play Install Referrer API to track your app installs.

Looks like you are using old version of react-native-iap. Please try our recent one which starts from 4.0.0+


Honda Nidec using wrong blinker message

Describe the bug
When doing lane changes on Honda Nidec, the stalk state is used. This causes the lane change alert to show for a split second and doesn't allow the convenience blinker to be used for lane change assist like on other makes.
How to reproduce or log data
Get in a Nidec, try to change lanes.
Device/Version information:
Route Coming Soon

Dongle ID:
Route:
Timestamp:
Commit hash:
Car make/model: Honda Civic 2017

Think this is also true for Honda Bosch and HKG

HKG should be fine.

If anyone has a car with this issue, please post a route!

I'm unsure if this is the same bug, but my blinker is now only prompting for lane change about 30% of the time - 2018 honda bosch. The rest of the time I just have to fight the car to change lanes. This route has many instances of it happening (I always indicate, so every turn or lane change I had my blinker on)
053abdc1032b7ecf|2021-06-15--16-32-36
I will also note that you caught me right in the middle of setting up a dev environment, so it is indicating correctly that it's using my fork rather than the official release2 channel, but I promise I have not made any alterations from the release2 branch. I don't mind switching back and giving a new route if it's that important, just no promises on how soon (probably tomorrow).

@ChadBailey if you're looking to do dev work, this is a great first PR. Essentially, the issue here is that the signal we use to get the blinker state from the car is wrong. I believe in this case, the signal is actually the stalk position. You'll likely need to find a new signal using Cabana, then set it here.

Sounds good, I'll give it a shot!

After lots of searching, I could never isolate any other values that may be representing the blinker data. That said, I'm new to this and wouldn't be surprised if it were right in front of my face the entire time.
None the less, I may take another swing tomorrow if someone else hasn't solved it by then.

If you post a Cabana share link of a route you're willing for others to look at, you can get more eyes on the problem.
Cabana, "Get Share Link" button puts a magic link on the clipboard that anyone can use, paste it into this github bug.

Did some looking on a Honda Accord, but couldn't find anything besides the stalk position.
For the future I wrote this script that prints out any "new" bitflips. Makes finding stuff like this a little easier. https://github.com/commaai/openpilot/pull/21294

Here is the special drive I did to debug this:
https://my.comma.ai/cabana/?route=053abdc1032b7ecf|2021-06-15--19-37-48&exp=1655402158&sig=od3e5tFljosaLcRGiVMis%2BhKawTRKixXc7f%2FZKw8XPc%3D&max=1&url=https%3A%2F%2Fchffrprivate-vzn.azureedge.net%2Fchffrprivate3%2Fv2%2F053abdc1032b7ecf%2Fa0ae5ed2d534a1903539f193386e289b_2021-06-15--19-37-48
I followed this routine:
Normal blinker usage ("clicked" into place and didn't hold)
Left blinker 10 blinks
Right blinker 10 blinks
Held stalk for blinker - did not allow to "click" into place
Left blinker 10 blinks
Right blinker 10 blinks
Quickly "bumped" stalk for "comfort blinker" that automatically runs for 3 blinks
Left blinker 3 blinks
Right blinker 3 blinks
You should be able to confirm by loading the 2018 Honda Accord and plotting the existing blinker data location to observe 2 long activations followed by a short activation for both blinkers

Did some looking on a Honda Accord, but couldn't find anything besides the stalk position.
For the future I wrote this script that prints out any "new" bitflips. Makes finding stuff like this a little easier. #21294

How would one run this? Just execute it or would I need to first kill the running processes for panda+openpilot?

No need to kill anything. It subscribes directly to boardd.

I've written an implementation that I'll be testing for a bit @ https://github.com/ChadBailey/openpilot/tree/feature/comfort_lane_change
you're free to test as well if you like (fair warning, i haven't tried it even once so it might be very broken) - for something like this i think i prefer to test for a while before i open any pull request to make sure it "feels right" and behaves as expected in all scenarios.

I've finished my first test. The good and bad news is it does absolutely nothing lol

I was thinking something like this (untested): https://github.com/commaai/openpilot/pull/21387/files

I was thinking something like this (untested): https://github.com/commaai/openpilot/pull/21387/files

This seems like a fantastic approach, but I wasn't able to determine that the blinker light data was available for my vehicle (2018 accord 1.5T). I didn't know the name though, so I'll take a look tonight and see if it's available.
In the event it's not, perhaps another way to make this more polished is to use the solution I was attempting but also have it only apply if the vehicle has the feature.

I’m using the stalk position in that PR.

Ohhh I see now, sorry I didn't realize this had components for both light and stalk updates for multiple cars at first glance.
I like the solution, I think it's a more rigid approach that handles the concern at the vehicle layer which is where it should be handled.
I'm happy to test tonight and report back.
Note about "stealth lane changes":
I guess the only outstanding question would be from a user experience standpoint - would anyone lacking a comfort signal desire the ability to "stealth lane change" by fast-bumping the stalk to initiate a change with no indicator. more importantly, even if they desire it, would we want to support that. Im of the opinion it shouldn't be allowed for safety reasons (and imagine you feel the same) I just wanted to make that use case clear for us and any future people reading this.

Tested, left detailed notes in #21387 .
I can't recall if this was ever the behavior, but was surprised to find I felt it improved the lane change experience more than I was expecting it would. Thanks for opening the bug report @VirtuallyChris!
Regarding my prior concern

blinker is now only prompting for lane change about 30% of the time

That was a complete fluke, I've never had that happen again. I must have unknowingly messed something up.


Update Calling SDK in the quickstart samples to the latest version

Purpose
Updated to the latest calling SDK to fix a WebRTC standard change affecting Chrome, Edge, and Safari.
https://azure.microsoft.com/en-us/updates/upgrade-to-azure-communication-services-calling-javascript-sdk-110-by-31-july-2021/
Does this introduce a breaking change?

- [ ] Yes
- [x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Follow the instructions to run the code in READMEs. (Typically just npm i and  npx webpack-dev-server --entry ./client.js --output bundle.js --debug --devtool inline-source-map)

What to Check

Make sure calls are working.

@akania @cwhil2492 @alkwa-msft can some of you please review & merge? thanks :)

Hi @petrsvihlik, good to merge?

Go for it.
On Tue, Aug 10, 2021, 20:47 Chris Whilar @.***> wrote:

Hi @petrsvihlik https://github.com/petrsvihlik, good to merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure-Samples/communication-services-javascript-quickstarts/pull/16#issuecomment-896230067,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACK3FQKGB3WHKBHHAY3WRYTT4FX4TANCNFSM5BIBM66Q
.


(PDB-1797) testing support for jessie

This sets up the config for acceptance testing on debian eight.

reopening on stable

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/171/
Test FAILed.


WIP: try to fix https://github.com/fsharp/FSharp.Compiler.Service/issues/721

Will test it today in the evening
ref https://github.com/fsharp/FSharp.Compiler.Service/issues/721

I don't really know what the right thing to do here is.  The TargetFrameworkVersion is the target for which we are generating code, and is independent of whether you want to run the F# compiler using .NET Core or .NET Framework.   The way you run the compiler is just orthogonal, though 99% of the time TargetFrameworkVersion is a fine guess.
I suppose it just depends whether you have .NET Core or .NET Framework available on your machine.   I don't know how to determine that.  This is why Roslyn ended up with two packages, just pushing the problem up another level.  The world keeps being bifurcated.  It's very difficult to stop but we need to try
@enricosada Do you have any ideas here?   I like the idea of a unified package but I don't see any good guidance on working out which is the preferred compiler toolchain

@dsyme is right, one thing is target fw, other is current runtime of msbuild.
we discussed a bit that in https://github.com/dotnet/netcorecli-fsc/issues/75 for another stuff.
you should check $(MSBuildRuntimeType) property (with null check because probably doesnt exists in msbuild 14)

About choose toolchain (use fsc full, fsc netcore, fsc full on mono) in same fsproj.
That is something i want to support, and sort of work already, but need to cleanup (FscToolPath_netcoreapp1_0 is orrible, i need to change that).
Atm if you run with <DontRunFscWithDotnet>true</DontRunFscWithDotnet> (ref FSharp.NET.Core.Sdk.targets#L158 will run fsc.exe, but i want to cleanup, is just an hack atm, to use TP in new fsproj and check both fsc behaviour (for my development).
Idea is instead of use orrible properties like FscToolPath_netcoreapp1_0 (unused atm), to add item metadata about avaiable fsc
<AvaiabileFscTool Include="$(MSBuildThisFileDirectory)netcoreapp1.0/fsc.dll">
   <Runtime>netcoreapp1.0</Runtime>
   <RuntimeType>Core</RuntimeType> <!-- so i know if i need to prefix `dotnet` -->
</AvaiabileFscTool>
<AvaiabileFscTool Include="$(MSBuildThisFileDirectory)/net45/fsc.exe">
   <Runtime>netcoreapp1.0</Runtime>
   <RuntimeType>Full</RuntimeType> <!-- no prefix, or `mono` if not windows -->
</AvaiabileFscTool>

in the fsproj, user can choose to add <FscToolPreferredRuntime>netcoreapp1.0</FscToolPreferredRuntime> and the target file will filter AvaiabileFscTool with that
that's the idea for fsc.
So on msbuild.exe (full) will use full fsc, on netcore the netcoreapp, and on mono the full version (run by mono)
Obv a good FscToolPath is something nice to have for current sdk, because that' how things work now.

@dsyme obv the part about AvaiabileFscTool is just an idea, to support and use multiple compiler in same package easy. but i want to discuss a bit before. i added the unused properties FscToolPath_netcoreapp1_0 just in case i needed it (and was useful in some diagnostics of bugs with users already)

Ah, I didn't realise at the start that the distinction is for fsc runtime, not code generation target. Now things make a bit more sense.
I am currently rerunning the VS Setup so that I can also test this with net core.

@0x53A like that seems ok. should work for your use case, i think the old target doesnt use  FscTaskAssemblyPath but hardcode the one install with VS, so i ok.
@dsyme i need to try this PR locally before merge.
i want to test with netcore/full/mono msbuild.
i think is better to add some integration test in this repo too, to check that package.
I'll send a PR stealing from https://github.com/Microsoft/visualfsharp/pull/2250 who already included that, sigh 😢 .

@enricosada Thank you for your help!
One other issue is the Microsoft.FSharp.Targets. Roslyn overwrites their target files to include the one from the nuget package: https://github.com/dotnet/roslyn/blob/master/build/NuGetAdditionalFiles/Microsoft.Net.Compilers.props#L29
While our nuget also includes the Microsoft.FSharp.Targets, it isn't really possible to overwrite it due to the way the defaul fsproj is structured:
When installing the nuget, the props file is included at the top, but the current fsproj include it like this:
  <Choose>
    <When Condition="'$(VisualStudioVersion)' == '11.0'">
      <PropertyGroup Condition="Exists('$(MSBuildExtensionsPath32)\..\Microsoft SDKs\F#\3.0\Framework\v4.0\Microsoft.FSharp.Targets')">
        <FSharpTargetsPath>$(MSBuildExtensionsPath32)\..\Microsoft SDKs\F#\3.0\Framework\v4.0\Microsoft.FSharp.Targets</FSharpTargetsPath>
      </PropertyGroup>
    </When>
    <Otherwise>
      <PropertyGroup Condition="Exists('$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets')">
        <FSharpTargetsPath>$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets</FSharpTargetsPath>
      </PropertyGroup>
    </Otherwise>
  </Choose>
  <Import Project="$(FSharpTargetsPath)" />

So without manually modifying the fsproj, there is no way to override the .targets from this nuget.
This is an issue for example if there is a new compiler parameter.

This is why Roslyn ended up with two packages, just pushing the problem up another level. The world keeps being bifurcated. It's very difficult to stop but we need to try

Roslyn bifurcated afaik because they bundle the csc inside two different stuff (dotnetcli and VS), so was easier just use two packages :D

@0x53A

So without manually modifying the fsproj, there is no way to override the .targets from this nuget.

I don't think there's any way to fix it.  However I would love if someone would go fix this stuff at the root core of the problem - the templates that are included in the Visual F# Tools - and just make sure that the targets path is at least defined by a variable, or some other fundamental fix.  The fact that so many F# project files unavoidably rely on a machine-path installed set of F# targets is really storing up trouble for the long term

@dsyme The easiest way would be to only set the path inside the fsproj if it is not already set.
Changing that in the template shouldn't be hards, but that would obviously only apply to new projects.
Do you have a hook inside VS where such a transformation could be applied on opening the project?

For example simply changing to this:
...
        <FSharpTargetsPath Condition="'$(FSharpTargetsPath)' == ''>$(MSBuildExtensionsPath32)\..\Microsoft SDKs\F#\3.0\Framework\v4.0\Microsoft.FSharp.Targets</FSharpTargetsPath>
...
        <FSharpTargetsPath Condition="'$(FSharpTargetsPath)' == ''>$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets</FSharpTargetsPath>
...
  <Import Project="$(FSharpTargetsPath)" />

so as not to override an existing FSharpTargetsPath setting

@dsyme i dont think is possibile to fix that with old fsprj, the whole sdk was using hardcoded paths or relative to sdk/extensions dir. Is risky, for what? you cannot change old templates..
the new fsproj fix that. there is no need anymore to worry about.
target file is inside FSharp.NET.Sdk package, so build are deterministic. All target are like that from packages like Microsoft.NET.Sdk

@enricosada so I should NOT try to set the targets file in this nuget? Then I will revert  0c70c11

the new fsproj fix that. there is no need anymore to worry about.

That's fine once we update the Visual Studio .NET Framework templates to use the new .fsproj. (However Microsoft might not do that for .NET Framework tempaltes because they may want to maintain VS2017 --> VS2015 compat, so projects created with VS2017 can be edited by teams using VS2015 as long as they don't use F# 4.1 features - I'm not sure).

@dsyme i dont think is possibile to fix that with old fsprj, the whole sdk was using hardcoded paths or relative to sdk/extensions dir. Is risky, for what? you cannot change old templates..

Yes, agreed, though editing the templates to check if FSharpTargetsPath is already set seems harmless

@0x53A I think setting FSharpTargetsPath is fine, it will just be ignored (overridden) by nearly all existing project files that this package gets integrated into.

Yes, agreed, though editing the templates to check if FSharpTargetsPath is already set seems harmless

Ah yes, chaning VS2017 old fsproj templates, yes :D

@0x53A I think setting FSharpTargetsPath is fine...

@enricosada Do you agree it is OK to set this?  Even if it is ignored/overridden?  Seems ok to me

think setting FSharpTargetsPath is fine, it will just be ignored (overridden) by nearly all existing project files that this package gets integrated into

Yes, sry, i checked.
i used LanguageTargetsandFSharpLanguageTargets` in
https://github.com/dotnet/netcorecli-fsc/blob/master/src/FSharp.Sdk/Sdk/Sdk.targets#L21

@enricosada Ah I see.
But regardless should't the setting of FSharpTargetsPath be conditional on the .NET Framework compiler toolchain, i.e. only set it when when this is false?
Condition="'$(MSBuildRuntimeType)' == 'Core'">

Wouldn't setting FSharpTargetsPath be conditional on the TargetFramework, not on the MSBuildRuntimeType?

Wouldn't setting FSharpTargetsPath be conditional on the TargetFramework, not on the MSBuildRuntimeType

no, becasue new fsproj can build all frameworks, you cannot rely on TargetFramework.
Let me see if i can find a msbuild property about new sdk vs old

Let me see if i can find a msbuild property about new sdk vs old

Yes that's what we need.

Ah yeah...
So we have:
old SDK vs new SDK
TargetFramework=Full vs TargetFramework=NetCore (and maybe mono, but I think that is the same as Full?)
MSBuildRuntimeType Full vs Core

old SDK vs new SDK
yes.

TargetFramework
that's the usual (full/pcl), but now there is also netstandard1.6, or netcoreapp1.0 for example

MSBuildRuntimeType Full vs Core
yes, because exists msbuild.exe and dotnet msbuild (the netcoreapp version of msbuild console app)

So, i have better memory than expected.
pratically the package for C# tried to embedded the old target time ago afaik.
i copy/pasted same c# workflow time ago, but not implmented anything for old targets (because is not my area)
https://github.com/dotnet/netcorecli-fsc/blob/master/src/FSharp.NET.Sdk/build/FSharp.NET.Current.Sdk.targets#L37-L52
And yes, i use FSharpTargetPath for new sdk in https://github.com/dotnet/netcorecli-fsc/blob/27791ecbcea992146f1dd652b3e83da03d215dba/src/FSharp.NET.Sdk/build/FSharp.NET.Current.Sdk.targets#L55
But checking new sdk 1.0.1, i see no more that, just targets for new code. i think they just abandoned the idea maybe. I chcked dotnet/sdk but i lost atm :D
@dsyme @0x53A maybe we should do that in another PR?
@dsplaisted @eerhardt there is a why to know if the target is execute in new sdk (with Microsoft.NET.Sdk) or old sdk (the targets file like VS <= 2015)?

@enricosada So you're saying we should not set FSharpTargetsPath at all in this PR, until we determine if there's a way to know if the targets are executed in new SDK (i.e. with Microsoft.NET.Sdk) ? (and we would only set it if it's false)

Isn't the targets file coupled to the actual version of fsc used?
So wouldn't you also want to override the targets file in case of the new sdk?

Isn't the targets file coupled to the actual version of fsc used?

is not, is tied more to fsc task used and sdk used. fsc args are stable, and retro compatible afaik

So you're saying we should not set FSharpTargetsPath at all in this PR, until we determine if there's a way to know if the targets are executed in new SDK (i.e. with Microsoft.NET.Sdk) ? (and we would only set it if it's false)

that's better, or give me some time to test, i dont want to break things 😄

Well, as long as the SDK is also on nuget, it doesn't really matter if the targets file is in the sdk nuget or in the FSharp.Compiler.Tools nuget, since you can just update both. =)
The current problem is that it uses the targets from the installed visual studio.

I have created a new issue for FSharpTargetsPath: https://github.com/fsharp/fsharp/issues/676

@0x53A Could you add notes in the README.md about how to add the FSHarp.Compiler.Tools to an existing project?  Thanks

I assume I should update the readme.md in the visualfsharp repo?

@dsplaisted @eerhardt there is a way to know if the target is execute in new sdk (with Microsoft.NET.Sdk) or old sdk (the targets file like VS <= 2015)?

Officially there isn't a way yet.  See https://github.com/dotnet/sdk/issues/534
Unofficially, there are ways to accomplish this.  One way (again not officially supported) is how the targets in .NET Standard are doing it:  https://github.com/dotnet/standard/blob/master/Microsoft.Packaging.Tools/tasks/targets/Microsoft.Packaging.Tools.targets#L11-L12

I assume I should update the readme.md in the visualfsharp repo?

No the one in this repo - they are additive - they haven't yet been merged (some of the last remaining changes)

thx for info @eerhardt !


Legend colors with theme ggplot2

The example line graph in the documentation shows the legend colors as grey boxes for theme ggplot2 only.
In an example plot that I created, even setting the legend colors manually does not fix the legend colors in the plot. Sample code for this:
using CairoMakie, ColorSchemes;

set_theme!(theme_ggplot2());
f = Figure()
labelV = ["lbl $j" for j = 1 : 3];
n = length(labelV);
elements = [PolyElement(color = ColorSchemes.corkO[16 * i]) for i in 1:n];
# To verify that RGB values differ across entries
@show elements
Legend(f[1,1], elements, labelV);
f

results in:

The same with theme_minimal() works as expected:

Ah must be wrong drawing order, in all but the ggplot themes the patch backgrounds are transparent

Thank you!


Improve Disruption Candidacy Documentation

Karpenter's current documentation on this is relatively sparse, with the Control Flow section of the disruption docs going into some amount of detail.
It would be good to add a dedicated section to the disruption docs for candidacy. Minimally, I think it should cover the following topics:

What does being a candidate mean for the different disruption types

Consolidation is an interesting case since nodes don't need to be underutilized to be considered candidates. This may be surprising to users, and is important to document since this is surfaced as a metric.

What conditions must be met for a node to be considered a candidate

Document the general set of conditions as well as disruption type specific conditions (e.g. terminationGracePeriod overriding the do-not-disrupt and PDB check for expiration and drift).

Note: the docs are still located in the AWS provider repo, but I'm opening this here since it has do with an upstream concept.

/kind documentation

/triage accepted


Added a new example at examples/dynRoutingFRR

Hello,
First : congrats to all the developers for their job.
I'm contributing with an example describing how to use FRR to simulate dynamic routing (bgp here) in a Mininet topology.
It's based on the job of @qyang18 here while using FRR.
It's the result of a hard work making the different tools work together.
The example was tested on the Mininet VM with the up-to-date master branch and it's working without any issue.
I'm sure it will save time for many people around.

Hi,
I made some enhancements to make the code and result better.

Hello!
Im not sure wether this helps or not but in mininet you could create private dirs for the hosts. I run FRR in complex topoligies with that feature and it does not require any mount, unmount or manual directory creation. For example in #927. With that you possibly cut a few line from this commit.

Hello,
I've just tried your suggestion, unfortunately, there are some constraints I can't handle with privateDirs preventing the daemons from working.
In fact, I installed FRR using the standard distrib packages (under the mininet VM). The daemons are launched with unprivileged frr user. Thus, the daemons need to have the write access to be able to start correctly (and allow vtysh to function).
By using privateDirs, directories are created by "root" and the code becomes incoherent cause I have to put privateDirs in the build() method and handle the chown cmd inside the LinuxRouter class.
To make things a bit simpler, I reduced the number of the directories needed to one (/tmp/<routername).
Let me know your thoughts.


assigment flag --set and --values gives different behavior

Hi,
when I set a parameter for example "testArray" using --set testArray={1,2,3}. It works as expected and assign an array to "testArray" but if I set "testArray" with same value in a file and use --values "testArray" get assigned to a map. Is this correct behavior?
Output of helm version:
Client: &version.Version{SemVer:"v2.9.1", GitCommit:"20adb27c7c5868466912eebdf6664e7390ebe710", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.9.1", GitCommit:"fdf9fd4cc35df7d146f9d34eabd70a85a467f07a", GitTreeState:"clean"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.6", GitCommit:"a21fdbd78dde8f5447f5f6c331f7eb6f80bd684e", GitTreeState:"clean", BuildDate:"2018-07-26T10:17:47Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"", Minor:"", GitVersion:"v1.10.4", GitCommit:"5ca598b4ba5abb89bb773071ce452e33fb66339d", GitTreeState:"", BuildDate:"2018-06-27T08:25:31Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Yes, this is correct behaviour. YAML's syntax is testArray: [1, 2, 3] or
testArray:
  - 1
  - 2
  - 3

--set is a custom string parsing library, and its syntax can be found here: https://docs.helm.sh/using_helm/#the-format-and-limitations-of-set
Hope this answers your question!

thank you for your reply and explanation.
it would be nice if --set also could use [] instead of {} for arrays then it would be consistent.


K8SPXC-1341: Fix resizing PVCs if some are not used by pods

CHANGE DESCRIPTION
Problem:
If there are some PVCs which are not used by any pod (for example after scale down) operator waits for them to resize but k8s doesn't resize them because they're unused.
Solution:
Only resize used PVCs.
CHECKLIST
Jira

[x] Is the Jira ticket created and referenced properly?
[x] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[x] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[x] Is an E2E test/test case added for the new feature/change?
[x] Are unit tests added where appropriate?
[x] Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

[x] Are all needed new/changed options added to default YAML files?
[x] Did we add proper logging messages for operator actions?
[x] Did we ensure compatibility with the previous version or cluster upgrade process?
[x] Does the change support oldest and newest supported PXC version?
[x] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

pitr-gap-errors-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

pvc-resize-5-7
passed

pvc-resize-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 39 out of 39

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1625/commits/5055d5555a2e8e3c378421da1ef3b829a5c463f4
image: perconalab/percona-xtradb-cluster-operator:PR-1625-5055d555


Update pulumi-terraform to a9a9ca8157

This PR updates pulumi-terraform to a9a9ca8157, and re-runs code generation

Merging and will create a CHANGELOG entry before release


Autotiling does not directly support edge-based tilesets.

Godot version:
3.0
Issue description:
Autotiling does not directly support edge-based tilesets.
By edge-based, I mean a tileset, with the following layout:

Tilesets with this layout are quiet common and necessary for "1d-objects", like streets, rivers, fences,...
It would be a great improvement, if they could be used more easily.
The intuitive way, does not work:
Here is, what happens, if the user currently tries to use such a tileset:
The 2x2 bitmask, obviously is corner-based, so for ege-based tileset, we would need the 3x3 bitmask. However, if I set the 3x3 bitmask up like this:

I will get this layout as a result:

(the four bottom tiles in the left arrangement are incorrect)
And if I change the bitmask to this (filling in the holes):

I get this result:

The left one is a bit better now, but the right one is wrong.
This goes wrong, because the 3x3-bitmask includes the corners, but this tileset only uses edges.
Possible workaround
I found a work around to make the 3x3-bitmask work with the tileset, but it is rather complicated. To make it work, we need a tileset of all 47 possible bitmasks. That means, we have to copy the same tiles multiple times:

Then, set up this bitmask:

And it works, we get the desired result:

I think, this workaround is not optimal: The user has to edit the tileset, and insert the same information (the same tile) multiple times.
Please make it easier to use edge-based tilesets.
Possible solution
Here are some ideas for solving this issue. Maybe you find one of them useful:

introduce a "wildcard" bit. By that, I mean the possibility to set a bit to "I don't care", instead of either "on" (red) or "off" (transparent). That way, the user could set all the corner bit to "I don't care" and the tileset would work right away. Wildcard-bits would also be useful, when using autotiling for hex-grids.
Let the user select a "bit-template" that defines which of the 9 bits should actually be used for matching and which ones should be ignored. That way, the user could select a plus-shaped template that would only include the four edges, but not the corners.
Add a third type of bitmask "edge" that is plus-shaped (the same as the bullet point before, but less flexible, because the user cannot chose the template shape freely, only from a list of predefined ones).
Allow multiple bitmasks for each tile. Currently, one bitmask can have many different tiles (many tiles can share the same bitmask), but a tile cannot have multiple bitmasks. If this were possible, the user would not need to copy the image of the tile as I showed above.

(If I explained anything badly, please ask, I can try to explain more)

this is the problem with the current autotile system. there was a guy that made a suggestion that would fix these issues.
https://github.com/godotengine/godot/issues/18134

introduce a "wildcard" bit. By that, I mean the possibility to set a bit to "I don't care", instead of either "on" (red) or "off" (transparent). That way, the user could set all the corner bit to "I don't care" and the tileset would work right away. Wildcard-bits would also be useful, when using autotiling for hex-grids.

This is the most versatile way to do this.


test single exe builds

if this works,
dotnet publish -r win-x64 -c Release /p:PublishSingleFile=true /p:DebugType=none --self-contained

it works, now single exe releases


Put OLM bundle under release publish

Signed-off-by: Dinar Valeev<EMAIL_ADDRESS>

@k0da it probably makes sense to rename WF file from helm_publish to publish_artifacts.yaml, and WF to Publish Artifacts to reflect the WF contents, as OLM bundle is not technically a helm chart.

Arguable, it just triggers other workflow which uses Helm as source for manifests. From my POV it still quite pure helm task.

what about changing the event type in olm_pr.yaml job from

we would lose a way to hot-fix existing bundle by manually triggering the action. I had to that for instance for this issue using this pipeline (resulting pr)

Arguable, it just triggers other workflow which uses Helm as source for manifests. From my POV it still quite pure helm task.

@k0da what about changing the event type in olm_pr.yaml job from:
on:
  workflow_dispatch:

to
on:
  release:
    types:
      - published

This way it is triggered by release event in parallel with help_publish.

Making it separate would release it in parallel, I think we still want to smoke test helm itself and only after use its artifacts to build OLM


How to remove a page extension of a removed page?

We have created a page extension for the page "Cross Reference List" in the past.
This page is marked obsolete in BC17.
We have marked all the added fields as Obsolete and removed them in the next version of our add-on.
What remains is an empty page extension:
#pragma warning disable AL0432
pageextension 11169130 "AXI CrossReferenceList" extends "Cross Reference List"
#pragma warning restore AL0432
{
layout
{
}
}
We are now building for BC version 20 and get the error:
##[error]\base\src\pageextension\AXICrossReferenceList.pageextension.al(2,57): error AL0247: The target Page "Cross Reference List" for the extension object is not found
But if we try to remove the page extension we get the error:
error AS0029: The 'PageExtension' with ID '11169130' and name 'AXI CrossReferenceList' was found in the previous version, but is missing in the current extension. This will break dependent extensions.
What do we need to do to fix this?

Maybe this is related to my issue #6583
Where do you get the AS0029 error? Within your build pipeline (using  Run-AlPipeline)?
We have found out, that the App Source Validation (Upload to Partner Source) does not complain if we simply remove our empty Page Extension. Currently we are having a similar issue with Enum Extension #6824.
I hope I can also remove that one, like we did with the obsolete Page Extensions.

Hi @ralf-escher,
We are using ALOps for our build pipeline and in the BC20-build we get this error.
I have also posted this on Yammer: https://www.yammer.com/dynamicsnavdev/#/Threads/show?threadId=1435605430247424 and got the comment to ignore the AS0029 error, so now the build is succesfull.
I still hope this will be fixed in the final release of BC20, because I think we might get a problem then.

I am affected as well, as my app extended the Item Cross Reference feature as well. I now needed to delete my page extension object.
Luckily, this was only an app for on-premises (yet I'm still using the AppSourceCop to be able to upload it later). So I have just disabled rule AS0029 completely. And I have to remember to restore it once my app version is released.
But if your app is already on AppSource, then you're kinda doomed.
@qutreson, please prioritize! Microsoft has started to delete objects and will continue to do so. This rule blocks us totally.

@NKarolak
as mentioned above you can simply remove your Page Extension, even if the App Source Cop is complaining in your build pipeline (see #6583)

Thanks @ralf-escher, but the error also pops up in my VS Code when attempting to build the app. Hence, I see no alternative. How come you don't get the error in VS Code?

Hi @NKarolak,
we keep an almost empty page extension until our release.
For an Enum Extension I had to keep the Enum Values (App Source Cop), which on the other hand lead to a compiler error   , here I could only solve the problem by using pragma (#6824). I hope I can remove this Enum Extension after the next major release.

We also had page extensions for Item Cross Reference and we removed it.
I used a build pipeline without checking against the previous app.
The validation in the App Source was successful.

AppSource validation currently ignores the rule AS0029 because of this specific issue.

We have added support for obsoleting page extensions and page customizations from AL extension version 9.0.599475


Link images to relevant docs

Makes it easier for people looking to replicate a certain screen, rather than searching through the wiki.

That's cool, but with the next release (2.3) we are moving to Read The Docs instead of the wiki. http://promotion.readthedocs.org/en/master/

Spirit of the commit stands though, I'd suggest linking the README to the appropriate RTD pages.

Absolutely, and thanks for contributing.


Couple questions

Any thoughts or opinions about potentially setting up a gitter.im channel for hotchocolate stuff, for stuff like questions that may not make sense to file a bug for (like this)?
I know there were some issues you had, and some issues that I participated in regarding stuff around automatic type conversion etc. With that work, would it be likely that needign to explicitly create and registering ObjectType will always be necessary?
Should the fixes to the type conversion stuff be a part of the 6.0 preview 5?

I have created a slack channel https://join.slack.com/t/hotchocolategraphql/shared_invite/enQtNDUyMjIxOTc1MTU3LWNlN2ViMGM5YTVhMWI3MzcwNDdjOTVkYWQ5ODZkMjJiODIwZjY5MzYzODc1Zjg5NDE5ZDQ4Zjk0MGExZWMzZGY
for this. I do not know gitter but if that is a better tool for that I am all yours :)

this works, I just dont want to be polluting issue system for general questions

One of my issues is with list of string for example. In .net a list of string allows the list to be null and the elements to be null. But how do we derive from a List type that the element is non-nullable or that the list is non-nullable. Another thing is how can I declare UnionTypes for example. For now you can most of the time go with clean .net classes. But there are cases were you have to explicitly declare types.

And I think those are places where having the ability to manually map / manipulate the descriptors make sense.


Steps undefined with Ruby And and But step definitions

👓 What did you see?
Some steps in our project are not recognized by the "Go to definition (F12)" feature of VS code
✅ What did you expect to see?
all steps in "features/**/*.feature" are recognized, if they exist
📦 Which tool/library version are you using?
Version: 1.89.1 (user setup)
Commit: dc96b837cf6bb4af9cd736aa3af08cf8279f7685
Date: 2024-05-07T05:13:33.891Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Windows_NT x64 10.0.22631
cucumber: 1.10.0
🔬 How could we reproduce it?

create a new cucumber project or use existing one
copy the below step definition examples into "features/step_definitions/"

Feature: go to definition in VS code

  Scenario: when VS code find definitions to go to
    Given step is found by cucumber extension
    And this step is not found
    Then this step is found
    When it starts with "When" it can be found
    Given steps are always good to find, even with parameter "text"
    Given at the end of the ruby feature file seems important?!

copy the following into a feature file in "features/"

# frozen_string_literal: true

Given(/^step is found by cucumber extension$/) do
  # no need to have something
end

And(/^this step is not found$/) do
  # this step is not found by cucumber go to
end

Then(/^this step is found$/) do
  # steps starting with Then are found
end

Given(/^steps are always good to find, even with parameter "(\w+)"$/) do |para|
  # steps with "Given" seems always good and also with a parameter
end

When(/^it starts with "When" it can be found$/) do
  # this step is new and starts with "And"
end

Given(/^at the end of the ruby feature file seems important?!$/) do
  # some text
end

let cucumber extension index the files
steps starting with "And" are not recognized

📚 Any additional context?
https://github.com/cucumber/vscode/assets/39296120/0d8da0c4-d87d-4a4f-a028-f0b518d4dce5

Great catch @SkyFips - appreciate the detailed report. Fix implemented. Will be available in the next release (1.11.0), pending completion of additional enhancements. Keep the contributions coming 🙌

Actually even java script were having exactly same issue. Could you please help us with javascript too in your next release.

@kieran-ryan Javascript/typescript has the same issue. Please fix it too.

Mmh, And and But steps normally require one of the Given/When/They keyword in your step-definition/step-implementation but not the And(or: But) decorator.
In your example above, the And steps follows a Given step.
Therefore, the And step in the feature file is actually a Given step definition, like:
# PROBLEMATIC: Step definition from above
# WAS: And(/^this step is not found$/) do
Given(/^this step is not found$/) do
  # this step is not found by cucumber go to
end


How to identify whether the content of the  rec files for training are correctly generated?

I train the vgg on the MS-Celeb-1M, finding that it doest's converge at all.
I'm convinced that it has something to do wtih the dataset itself, because this can perform well on others datasets, and I also use part of  MS-Celeb-1M to change the number of the classes and samples of the dataset, but the result is the same.
I wonder who have the similare experience. I in particular suspect the input data which is wrongly generated by the im2rec program. But I don't know how to identify whether the rec files is correct.
By cafefully observing the print of the training, it is curious during  every epoch that it gets the same Train-accuracy and Validation-accuracy.
INFO:root:Epoch[1] Batch [100]	Speed: 1249.03 samples/sec	Train-accuracy=0.000031
INFO:root:Epoch[1] Batch [200]	Speed: 1225.23 samples/sec	Train-accuracy=0.000078
INFO:root:Epoch[1] Batch [300]	Speed: 1221.93 samples/sec	Train-accuracy=0.000039
INFO:root:Epoch[1] Resetting Data Iterator
INFO:root:Epoch[1] Time cost=366.774
INFO:root:Saved checkpoint to "./model/msimg-0002.params"
INFO:root:Epoch[1] Validation-accuracy=0.000059
INFO:root:Epoch[2] Batch [100]	Speed: 1248.00 samples/sec	Train-accuracy=0.000031
INFO:root:Epoch[2] Batch [200]	Speed: 1250.36 samples/sec	Train-accuracy=0.000078
INFO:root:Epoch[2] Batch [300]	Speed: 1257.64 samples/sec	Train-accuracy=0.000039
INFO:root:Epoch[2] Resetting Data Iterator
INFO:root:Epoch[2] Time cost=361.297
INFO:root:Saved checkpoint to "./model/msimg-0003.params"
INFO:root:Epoch[2] Validation-accuracy=0.000059
INFO:root:Epoch[3] Batch [100]	Speed: 1240.24 samples/sec	Train-accuracy=0.000031
INFO:root:Epoch[3] Batch [200]	Speed: 1232.99 samples/sec	Train-accuracy=0.000078
INFO:root:Epoch[3] Batch [300]	Speed: 1230.92 samples/sec	Train-accuracy=0.000039

The clean list of  MS-Celeb-1M has around 500,000,000 images and 10,000 classes. with this type of scale of data, I find it difficult to adapt a suitable learning rate into to converge.

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!


[Term Discussion] Publication Data

According to the definition of Publication Data

Publication Data is a Research Data intended to appear in a scientific publication.

It is true that Publication data is a subclass of Research Data.
But, the comment of Publication data is part of Research Data and Analysed Data is somewhat confusing because if suppose Publication Data is a subclass of Analyzed data then it inherently also a research data.
I would suggest that there is a connection between Publication Data and Dataset (disjoint union of Analysed Data, Metadata, and Raw Data) connection would be:
PublicationData hasDataset Dataset

Research Data is data in a research context. Raw Data and Analysed Data are subclasses of Research Data.
Dataset is Research Data + Metadata. For example Raw Dataset = Raw Data + Metadata, Analysed Dataset = Analysed Data + Metadata
Publication Data is a subclass on Research Data by definition (as it is all or a part of Raw/Analysed data), but I agree that in practice you don't publish data without metadata, so Publication Data could be related directly to Dataset. In real case, Publication Data will be on a persistent Data Repository as standalone, so I agree in connecting it with "hasDataset".

We agree that PublicationData hasDataset Dataset

comment: There is something missing regarding the activity generate the Publication Data from Dataset.

Dataset is disjunction class of Research Data + Metadata

Publication data = a Dataset associated to a Paper
we must know the provenance:
Dataset = some Data + Metadata
Data wasGenerated by User using analysis/instrument/...

if we want to add another Agent that puslishes the PublicationData, that's ok

Research Data is data in a research context. Raw Data and Analysed Data are subclasses of Research Data.
Dataset is Research Data + Metadata. For example Raw Dataset = Raw Data + Metadata, Analysed Dataset = Analysed Data + Metadata
Publication Data is a subclass on Research Data by definition (as it is all or a part of Raw/Analysed data), but I agree that in practice you don't publish data without metadata, so Publication Data could be related directly to Dataset. In real case, Publication Data will be on a persistent Data Repository as standalone, so I agree in connecting it with "hasDataset".

According to the discussion on 25.01.2022
ResearchData: prov:Entity
    hasMetadata some Metadata
    prov:wasAttributedTo some ResearchUser
AnalysedData: ResearchData
    prov:wasGeneratedBy some DataAnalysis
RawData: ResearchData
    prov:wasGeneratedBy some Measurement
PublicationData: prov:Entity
    isStoredBy some DataRepository
    prov:wasAttributedTo some ResearchUser
    prov:wasDerivedFrom some Dataset
Dataset: prov:Collection
    prov:hadMember some AnalysedData, RawData
    hasMetadata some Metadata
    prov:hadMember some Dataset
    isStoredBy some DataCollaborationPlatform
Metadata: prov:Entity
    isStoredBy some MetadataRepository
    prov:wasAttributedTo ResearchUser

Research Data is data in a research context. Raw Data and Analysed Data are subclasses of Research Data.
Dataset is Research Data + Metadata. For example Raw Dataset = Raw Data + Metadata, Analysed Dataset = Analysed Data + Metadata
Publication Data is a subclass on Research Data by definition (as it is all or a part of Raw/Analysed data), but I agree that in practice you don't publish data without metadata, so Publication Data could be related directly to Dataset. In real case, Publication Data will be on a persistent Data Repository as standalone, so I agree in connecting it with "hasDataset".

 As a small remark, I would add that Dataset isStoredBy some DataCollaborationPlatform but also by some DataRepository

Research Data is data in a research context. Raw Data and Analysed Data are subclasses of Research Data.
Dataset is Research Data + Metadata. For example Raw Dataset = Raw Data + Metadata, Analysed Dataset = Analysed Data + Metadata
Publication Data is a subclass on Research Data by definition (as it is all or a part of Raw/Analysed data), but I agree that in practice you don't publish data without metadata, so Publication Data could be related directly to Dataset. In real case, Publication Data will be on a persistent Data Repository as standalone, so I agree in connecting it with "hasDataset".

 Maybe an alternative could also be consider PublicationData a subclass of Dataset?

Sure, i will add it into the newest iteration.

Research Data is data in a research context. Raw Data and Analysed Data are subclasses of Research Data.
Dataset is Research Data + Metadata. For example Raw Dataset = Raw Data + Metadata, Analysed Dataset = Analysed Data + Metadata
Publication Data is a subclass on Research Data by definition (as it is all or a part of Raw/Analysed data), but I agree that in practice you don't publish data without metadata, so Publication Data could be related directly to Dataset. In real case, Publication Data will be on a persistent Data Repository as standalone, so I agree in connecting it with "hasDataset".

 Maybe an alternative could also be consider PublicationData a subclass of Dataset?

I think based on our discussion back then, we rather put the PublicationData prov:wasDerivedFrom Dataset rather than subclass of Dataset because to get a PublicationData there is a curation process from Dataset which we model in prov as was derived from.

Research Data is data in a research context. Raw Data and Analysed Data are subclasses of Research Data.
Dataset is Research Data + Metadata. For example Raw Dataset = Raw Data + Metadata, Analysed Dataset = Analysed Data + Metadata
Publication Data is a subclass on Research Data by definition (as it is all or a part of Raw/Analysed data), but I agree that in practice you don't publish data without metadata, so Publication Data could be related directly to Dataset. In real case, Publication Data will be on a persistent Data Repository as standalone, so I agree in connecting it with "hasDataset".

According to the discussion on 25.01.2022
ResearchData: prov:Entity
    hasMetadata some Metadata
    prov:wasAttributedTo some ResearchUser
AnalysedData: ResearchData
    prov:wasGeneratedBy some DataAnalysis
RawData: ResearchData
    prov:wasGeneratedBy some Measurement
PublicationData: prov:Entity
    isStoredBy some DataRepository
    prov:wasAttributedTo some ResearchUser
    prov:wasDerivedFrom some Dataset
Dataset: prov:Collection
    prov:hadMember some AnalysedData, RawData
    hasMetadata some Metadata
    prov:hadMember some Dataset
    isStoredBy some DataCollaborationPlatform
Metadata: prov:Entity
    isStoredBy some MetadataRepository
    prov:wasAttributedTo ResearchUser

I think the question to you @mpanighel and @rossellaaversa whether all of the classes i defined above should have the attribution to ResearchUser?

I agree with the wasAttributedTo ResearchUser for all the classes.
I assume that AnalysedData or RawData don't have ResearchUser because they are subclassed of ResearchData.
Is is possible to have multiple or different ResearchUser? E.g., RawData wasAttributedTo user1 and AnalysedData wasAttributedTo user2?
Still missing that Dataset isStoredBy some DataCollaborationPlatform but also by some DataRepository

I agree with the wasAttributedTo ResearchUser for all the classes. I assume that AnalysedData or RawData don't have ResearchUser because they are subclassed of ResearchData. Is is possible to have multiple or different ResearchUser? E.g., RawData wasAttributedTo user1 and AnalysedData wasAttributedTo user2?
Yes this would be fine since they are a subclass of ResearchData
Still missing that Dataset isStoredBy some DataCollaborationPlatform but also by some DataRepository
Sure i will add it now, sorry i missed it.

Thanks for your feedback, ill merge it now

as #16, we close the issue.

Dataset is the "selection" of raw/analysed data (according to scientific problem)
We publish Dataset
Publication Data: Dataset needed to validate the results presented in a Scientific Publication or appearing in it. It may include Raw Data, Analysed Data and all the relevant Metadata on Measurement and Data Analysis to validate them.


Pluginzie Persisted Operations with provided client info

Motivation and Context
This change is to implement the feature requested in https://github.com/wundergraph/cosmo/issues/1278 by:

Expose Persisted Operations Client interface in pkg directory
Refactor ClientInfo struct into pkg/client interface and allow providing customized client info which can be used as inputs for FetchPersistedOperations

HI @janeli1, due to the refactor in #1330 I think this PR will be become obsolete. @df-wg can based on your findings add a test case to ensure that this has been addressed.

HI @janeli1, due to the refactor in #1330 I think this PR will be become obsolete. @df-wg can based on your findings add a test case to ensure that this has been addressed.

Hi, May I know how to use APQ to allow providing customized client info which can be used as keys for FetchPersistedOperations? In our use case, querying PO is not only based on PO hash, but also other information, such as app version, app name, etc.

@janeli1 my bad, the comment was intended for https://github.com/wundergraph/cosmo/pull/1286


feat: restyle the project

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

GitHub release
1.2.0
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


[Dynamic Region] supply extra integartion tests for gc_worker and storage in raftstore-v2.

What is changed and how it works?

Issue Number: ref #15409
What's Changed:

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note
None.

/cc @tonyxuqqi @overvenus

/cc @SpadeA-Tang @bufferflies
PTAL, thx

new_cluster should be used in any case, just like

new_cluster should be used in any case, just like

got, I've misread the definition of test_case. I' re-check it.


[18.03] gnome3.gdm: fix CVE-2018-14424

Motivation for this change
This backports the changes done in the 2.28 branch of gdm to address the
issue.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: gnome3.gdm
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: gnome3.gdm
Partial log (click to expand)
shrinking /nix/store/arqbzf0vlcpvqnjzp5bcb28c5iv2jf9q-gdm-<IP_ADDRESS>/sbin/gdm
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/arqbzf0vlcpvqnjzp5bcb28c5iv2jf9q-gdm-<IP_ADDRESS>/lib  /nix/store/arqbzf0vlcpvqnjzp5bcb28c5iv2jf9q-gdm-<IP_ADDRESS>/libexec  /nix/store/arqbzf0vlcpvqnjzp5bcb28c5iv2jf9q-gdm-<IP_ADDRESS>/bin  /nix/store/arqbzf0vlcpvqnjzp5bcb28c5iv2jf9q-gdm-<IP_ADDRESS>/sbin
patching script interpreter paths in /nix/store/arqbzf0vlcpvqnjzp5bcb28c5iv2jf9q-gdm-<IP_ADDRESS>
/nix/store/arqbzf0vlcpvqnjzp5bcb28c5iv2jf9q-gdm-<IP_ADDRESS>/etc/gdm/PreSession/Default: interpreter directive changed from "/bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
/nix/store/arqbzf0vlcpvqnjzp5bcb28c5iv2jf9q-gdm-<IP_ADDRESS>/etc/gdm/PostLogin/Default.sample: interpreter directive changed from "/bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
/nix/store/arqbzf0vlcpvqnjzp5bcb28c5iv2jf9q-gdm-<IP_ADDRESS>/etc/gdm/PostSession/Default: interpreter directive changed from "/bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
/nix/store/arqbzf0vlcpvqnjzp5bcb28c5iv2jf9q-gdm-<IP_ADDRESS>/etc/gdm/Init/Default: interpreter directive changed from "/bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/arqbzf0vlcpvqnjzp5bcb28c5iv2jf9q-gdm-<IP_ADDRESS>...
moving /nix/store/arqbzf0vlcpvqnjzp5bcb28c5iv2jf9q-gdm-<IP_ADDRESS>/sbin/* to /nix/store/arqbzf0vlcpvqnjzp5bcb28c5iv2jf9q-gdm-<IP_ADDRESS>/bin

Success on aarch64-linux (full log)
Attempted: gnome3.gdm
Partial log (click to expand)
strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/77q764p2qsgbkklrywxfly3xrd56s695-gdm-<IP_ADDRESS>/lib  /nix/store/77q764p2qsgbkklrywxfly3xrd56s695-gdm-<IP_ADDRESS>/libexec  /nix/store/77q764p2qsgbkklrywxfly3xrd56s695-gdm-<IP_ADDRESS>/bin  /nix/store/77q764p2qsgbkklrywxfly3xrd56s695-gdm-<IP_ADDRESS>/sbin
patching script interpreter paths in /nix/store/77q764p2qsgbkklrywxfly3xrd56s695-gdm-<IP_ADDRESS>
/nix/store/77q764p2qsgbkklrywxfly3xrd56s695-gdm-<IP_ADDRESS>/etc/gdm/PostSession/Default: interpreter directive changed from "/bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
/nix/store/77q764p2qsgbkklrywxfly3xrd56s695-gdm-<IP_ADDRESS>/etc/gdm/PreSession/Default: interpreter directive changed from "/bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
/nix/store/77q764p2qsgbkklrywxfly3xrd56s695-gdm-<IP_ADDRESS>/etc/gdm/PostLogin/Default.sample: interpreter directive changed from "/bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
/nix/store/77q764p2qsgbkklrywxfly3xrd56s695-gdm-<IP_ADDRESS>/etc/gdm/Init/Default: interpreter directive changed from "/bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/77q764p2qsgbkklrywxfly3xrd56s695-gdm-<IP_ADDRESS>...
moving /nix/store/77q764p2qsgbkklrywxfly3xrd56s695-gdm-<IP_ADDRESS>/sbin/* to /nix/store/77q764p2qsgbkklrywxfly3xrd56s695-gdm-<IP_ADDRESS>/bin
/nix/store/77q764p2qsgbkklrywxfly3xrd56s695-gdm-<IP_ADDRESS>

@GrahamcOfBorg test gnome3-gdm

Success on x86_64-linux (full log)
Attempted: tests.gnome3-gdm
Partial log (click to expand)
machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 38.38s
cleaning up
killing machine (pid 596)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/jkhkpzyz8zxn4rrysgx1g3lmnkaxq80v-vm-test-run-gnome3-gdm

Success on aarch64-linux (full log)
Attempted: tests.gnome3-gdm
Partial log (click to expand)
machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 72.06s
cleaning up
killing machine (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/gjiyn280j6mxvf2nmhb3a1mq49v715r2-vm-test-run-gnome3-gdm


support additional event properties

There are a number of properties in the v3 Events endpoint (http://docs.puppetlabs.com/puppetdb/2.0/api/query/v3/events.html) that don't seem to be stored in the Event type:

containing-class
file
line

Support for these would be nice, especially "containing-class". I don't know if I'll get around to a PR for this, but I'll try.

This is now supported via commit https://github.com/puppet-community/pypuppetdb/commit/cf38890e2954897bb8b044853ffccfe79c783393 :smile:


Fixed Duplicated Sphinx Extension

Fixes #850

Removed Duplicated Sphinx Extension

>>> from poliastro.plotting import OrbitPlotter
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name 'OrbitPlotter' from 'poliastro.plotting'

Changed from poliastro.plotting import OrbitPlotter to  from poliastro.plotting import OrbitPlotter2D

Thanks for the pull request @iamabhishek0! You also found another bug, good :relaxed:

@jorgepiloto do you want to merge? :) Thanks @iamabhishek0!

Sure! Everything looks good for me :rocket:


Add vm.fail/vm.cond_fail for propagating errors

Add a new vm.fail/vm.cond_fail pair of ops. These should be like vm.break/vm.cond_break but without the continuation, and maybe could take a status value as well (I think hal.semaphore returns status?). Adding an enum for the status values would be useful.
Some design work needed here to ensure that introducing the failures don't defeat coroutine-based execution. I think it's fine for the initial expected uses (iree.unreachable, shape assertions, etc) but will be something to ensure we don't rely on.

Initial version done in #1593.


Sort error when using Repository functions

Describe the bug
I have implemented the Tree NestedSet behaviour as outlined in the Gedmo Doctrine Extensions repository (https://github.com/doctrine-extensions/DoctrineExtensions/blob/main/doc/tree.md).
Unfortunately following the documentation yields the following error: Invalid sort options specified: field - root, direction - asc. When taking the executed queries from the debug bar and manually executing an SQL query I can see that the query to retrieve data is relatively simple and follows the expected response of a nested set query. The issue seems to be code related.
I am using Symfony 6.1.4, PHP 8.1.8, Gedmo 3.8.0, Stof 1.7.0
I am not doing anything fanciful my code follows the examples within the documentation.
There is another report of the same error at: https://stackoverflow.com/questions/73580608/symfonys-gedmo-tree-throws-sorting-error
To Reproduce
Steps to reproduce the behavior:

Follow the guide to implement the Category entity with PHP8 attributes
Run doctrine migrations to have the necessary DB tables created
Add tree data via the Entity Manger and persist
Attempt to use the childrenHierarchy function in any example within the documentation

Expected behavior
Either a multidimensional array of tree items or alternatively if you decide to decorate the free, a HTML version of the Nested Set.
Additional context
I am unsure whether the fault here is in the Doctrine Extensions library of the implementation of the bundle.

This should be reported to https://github.com/doctrine-extensions/DoctrineExtensions as that's where all the logic is implemented


Craig asks to delete this when adding google_v2_supremacy_circuit

I meant to do it as part of the other PR, but this will do fine. I'll wait until that one is merged.

Automerge: started

Automerge done.


[Detailed Portion] Add GL/Payroll/Tax Codes to NewDot

DESIGN DOC:  Here
Deadline: August 1st, 2024
Assignee: @rushatgabhane
Price: $500
Coming from this internal GH, we need a C+ to:

[ ] Build new pages for adding GL Code and Payroll code to Categories/GL code to Tags/Tax code to Taxes
[ ] Build the menu items for Categories, Tags and Taxes
[ ] Complete the onyx pieces (for offline first) for showing & modifying all the new data, etc.
[ ] Fill these sections out in the above Design Doc

@rushatgabhane @Gonals is going to be our internal engineer on this!

Rushat killed it, waiting for implementation

@rushatgabhane mind giving us a breakdown of where we're at?

Policy category - Add GL Code
PR approved - https://github.com/Expensify/App/pull/43149
Backend merged
Policy category - Add Payroll Code
Awaiting C+ review by @hoangzinh - https://github.com/Expensify/App/pull/43151
Backend merged
Tags - Add GL Code
Awaiting C+ review and backend is not deployed yet. - https://github.com/Expensify/App/pull/43155
Taxes - Add tax code
Awaiting backend PR and deployment so I'm holding on that - https://github.com/Expensify/App/pull/43156

Ongoing! Mind giving an update here, @rushatgabhane ?

@dylanexpensify same as above.
Only thing is, the frontend is ready for Tax Code page - https://github.com/Expensify/App/pull/43156

Nice, thank you!

Update: All PRs except Tax code on production.
Tax code - https://github.com/Expensify/App/pull/43156

NICE! Looks like Tax code is on prod as of 3 days ago 🎉 What's left for us to close this out and get you paid @rushatgabhane?

@dylanexpensify no all set!

@dylanexpensify i guess we're paying per issue? https://github.com/Expensify/App/issues/44255#issuecomment-2246108882
So $250 x 4 tasks. Does this sound right?

@rushatgabhane ah yeah, we can do by issue! Have they all had the payment summaries added?

@dylanexpensify yes they have. Thank you : )

nice! Great work here man!


update zephyr 3.2 patch to include armclang build fixes

Pull in commits needed from upstream zephyr to enable building zephyr 3.2 tree for armclang compiler.

@albertofloyd this is now updated against the master branch and includes all the fixes.


Implement Toeplitz matrices

About the PR

[x] Implement Toeplitz matrices in torch
[x] Implement batch Toeplitz matrices in torch
[x] Unit test against scipy
[ ] Use it in separation.py

Let's merge this as is and make another PR to integrate it into separation.py WDYT?

Done at 0978b4e6492613a5efa6051e27c5f85fe0e9ccae

Have you checked if it is backpropagable now?

Yes it is I imagine that at least sdr and sar. Since sri is sometimes inf and manually assigned I expect in those cases the graph to be broken. Anyway its better to avoid nans


Content packs not auto loading steams

I'm trying to auto load streams as content packs with auto load but they are not appearing. It does add them in the UI /system/contentpacks but I have to manually apply them.
Graylog version v2.4.6+ceaa7e4
docker create --link mongo \
    -p 9000:9000 -p 12201:12201 -p 514:514 -p 5555:5555 \
    --name graylog \
    -e GRAYLOG_CONTENT_PACKS_LOADER_ENABLED=true \
    -e GRAYLOG_CONTENT_PACKS_AUTO_LOAD=tcp-input.json,my-stream.json \
    -e GRAYLOG_CONTENT_PACKS_DIR=data/contentpacks \
    ... other env values ...
    graylog/graylog:2.4

Wondering if this is an issue or something I've misconfigured.

Hi,
in general that should work. Do you see any error in the server logs related to content pack loading?

See the following when I look for content pack related stuff in graylog logs.
2018-08-07 13:52:26,037 ERROR: org.graylog2.bundles.BundleImporter - Error while creating entities in content pack. Starting rollback.
java.lang.IllegalStateException: No default index set configured. This is a bug!
    at com.google.common.base.Preconditions.checkState(Preconditions.java:459) ~[graylog.jar:?]
    at org.graylog2.indexer.indexset.MongoIndexSetService.getDefault(MongoIndexSetService.java:105) ~[graylog.jar:?]
    at org.graylog2.indexer.MongoIndexSetRegistry.getDefault(MongoIndexSetRegistry.java:145) ~[graylog.jar:?]
    at org.graylog2.bundles.BundleImporter.createStream(BundleImporter.java:573) ~[graylog.jar:?]
    at org.graylog2.bundles.BundleImporter.createStreams(BundleImporter.java:557) ~[graylog.jar:?]
    at org.graylog2.bundles.BundleImporter.runImport(BundleImporter.java:189) [graylog.jar:?]
    at org.graylog2.bundles.BundleService.applyConfigurationBundle(BundleService.java:112) [graylog.jar:?]
    at org.graylog2.periodical.ContentPackLoaderPeriodical.doRun(ContentPackLoaderPeriodical.java:196) [graylog.jar:?]
    at org.graylog2.plugin.periodical.Periodical.run(Periodical.java:77) [graylog.jar:?]
    at java.lang.Thread.run(Thread.java:748) [?:1.8.0_171]
2018-08-07 13:52:26,085 INFO : org.graylog2.inputs.InputStateListener - Input [Syslog TCP/5b69a4194cedfd0001f3c24d] is now STARTING
2018-08-07 13:52:26,067 ERROR: org.graylog2.periodical.ContentPackLoaderPeriodical - Uncaught exception in periodical
java.lang.RuntimeException: java.lang.IllegalStateException: No default index set configured. This is a bug!
    at org.graylog2.bundles.BundleImporter.runImport(BundleImporter.java:200) ~[graylog.jar:?]
    at org.graylog2.bundles.BundleService.applyConfigurationBundle(BundleService.java:112) ~[graylog.jar:?]
    at org.graylog2.periodical.ContentPackLoaderPeriodical.doRun(ContentPackLoaderPeriodical.java:196) ~[graylog.jar:?]
    at org.graylog2.plugin.periodical.Periodical.run(Periodical.java:77) [graylog.jar:?]
    at java.lang.Thread.run(Thread.java:748) [?:1.8.0_171]
Caused by: java.lang.IllegalStateException: No default index set configured. This is a bug!
    at com.google.common.base.Preconditions.checkState(Preconditions.java:459) ~[graylog.jar:?]
    at org.graylog2.indexer.indexset.MongoIndexSetService.getDefault(MongoIndexSetService.java:105) ~[graylog.jar:?]
    at org.graylog2.indexer.MongoIndexSetRegistry.getDefault(MongoIndexSetRegistry.java:145) ~[graylog.jar:?]
    at org.graylog2.bundles.BundleImporter.createStream(BundleImporter.java:573) ~[graylog.jar:?]
    at org.graylog2.bundles.BundleImporter.createStreams(BundleImporter.java:557) ~[graylog.jar:?]
    at org.graylog2.bundles.BundleImporter.runImport(BundleImporter.java:189) ~[graylog.jar:?]
    ... 4 more

Not sure what to make of it to be honest, hopefully makes more sense to someone else.

The default index set in Elasticsearch that is created during first start-up is not there. Maybe your ES cluster is in an error state or not accessible at all?

Running the following locally gets me this scenario:
docker run --name mongo -d mongo:3

docker run --name elasticsearch \
    -e "http.host=<IP_ADDRESS>" \
    -e "xpack.security.enabled=false" \
    -d docker.elastic.co/elasticsearch/elasticsearch:5.6.2

docker create --link mongo --link elasticsearch \
    -p 9000:9000 -p 12201:12201 -p 514:514 -p 5555:5555 \
    --name graylog \
    -e GRAYLOG_CONTENT_PACKS_LOADER_ENABLED=true \
    -e GRAYLOG_CONTENT_PACKS_AUTO_LOAD=input.json,streams.json \
    -e GRAYLOG_CONTENT_PACKS_DIR=data/contentpacks \
    -e GRAYLOG_WEB_ENDPOINT_URI="http://<IP_ADDRESS>:9000/api" \
    graylog/graylog:2.4

docker cp /tmp/contentpacks/. graylog:/usr/share/graylog/data/contentpacks/

docker start graylog

Elastic search doesn't seem to be in an error state as far as I can tell.
Not used elastic search too much so is this a case of needing to wait a bit for elastic search to start and settle itself or do I need to set something up in elastic search before I start graylog to get the default index set?
GrayLog does eventually start up and work as expected so it's either fixing this issue itself of waiting until that index is there?

That's possible, there shout be a log message about it later in the file. Usually you expose the data directory of the ES container anyways to keep state of the system. If you let it create once the import of the content pack should work then.

Yep looks like that was it 👍
Started elastic search and followed the logs unitl I saw
[2018-08-07T14:37:25,519][INFO ][o.e.c.m.MetaDataCreateIndexService] [XZjuckQ] [.triggered_watches] creating index, cause [auto(bulk api)], templates [triggered_watches], shards [1]/[1], mappings [triggered_watch]

And started graylog after that, streams and inputs all accounted for and present after that.
Also as far as exposing the data directory in ES using AWS ES anyway the above was just a local example.
Thanks for the help here :)

I have the same issue but when using docker-compose.yml
Here is my stack:
  mongo:
    image: mongo:4.2
    restart: on-failure:3

  elasticsearch:
    image: docker.elastic.co/elasticsearch/elasticsearch-oss:7.10.0
    env_file: .env_elasticsearch
    ulimits:
      memlock:
        soft: -1
        hard: -1
    deploy:
      resources:
        limits:
          memory: 1g
    restart: on-failure:3

  graylog:
    image: graylog/graylog:4.0
    env_file: .env_graylog
    entrypoint: /usr/bin/tini -- wait-for-it elasticsearch:9200 --  /docker-entrypoint.sh
    depends_on:
      - mongo
      - elasticsearch
    ports:
      - 9999:9000
      - 12201:12201/udp
      - 12401:12401/udp
    restart: on-failure:3
    volumes:
      - ./graylog/contentpacks:/usr/share/graylog/data/contentpacks

content packs are linked with volume, the .env_graylog file contents are:
GRAYLOG_CONTENT_PACKS_AUTO_INSTALL=nginx.json
GRAYLOG_CONTENT_PACKS_DIR=data/contentpacks
GRAYLOG_CONTENT_PACKS_LOADER_ENABLED=true

When I log into graylog's panel I only see the nginx pack in the list of available packeges, but need to install it by clicking the button.
As you can see I have added depends_on to the yaml so graylog should start after mongo and elastic.
What else should I do?


Get thumbnail URL to *.png for iobroker visualization

Is your feature request related to a problem? Please describe.
I would like to display a thumbnail as a preview in my home automation system. I use the ioBroker for this. Unfortunately, I can't find a way to always display the current thumbnail as an html script/widget via an http command.
Describe your setup
Voron 2.4
Rpi4
ioBroker
Describe the solution you'd like
I would prefer a URL or a script that always writes a file on the RPi, e.g. Thumbnail.png, which is overwritten with each print and I can thus access it as a unique URL. Or as a JSON script or something similar.

This is outside of scope for this integration. This integration is trying to expose native moonraker interface in Home Assistant.


[Alpine] make test fail in CI

version: 1.10.0
PR: https://github.com/alpinelinux/aports/pull/12104
Problems:

Charset test fail (https://cloud.drone.io/alpinelinux/aports/13316/2/1 L1004)
charset_test.go:94:   Error: Not equal
make test-sqlite:  **TestAPIGitTags ** (https://cloud.drone.io/alpinelinux/aports/13329/2/1 L1138)
api_repo_git_tags_test.go:54 |   expected: "user2" | actual  : "drone"

the charset test can be deactivated ... but remove make test-sqlite is not what i like to do ..
PS: make-sqlite only fail in drone but the same test PASS in travis ?!?

is make-sqlite an depricated test @lunny ?

@6543 I don't think so. make test-sqlite is a part of all the tests.
Look at the fail test, it seems the request's token is unavaible?
expected<EMAIL_ADDRESS>actual  : "noreply@drone"

ref: https://drone.gitea.io/go-gitea/gitea/15841/1/14

I close this Issue since the PR without the test-sqlite is merged now ...


CI for Node

Create a CI workflow node.

npm test
shell: /bin/bash -e {0}

<EMAIL_ADDRESS>test /home/runner/work/github-actions-for-ci/github-actions-for-ci
npx standard && npx jest

npx: installed 505 in 21.516s
No tests found, exiting with code 1
Run with --passWithNoTests to exit with code 0
In /home/runner/work/github-actions-for-ci/github-actions-for-ci
7 files checked.
testMatch: /tests//.[jt]s?(x), **/?(.)+(spec|test).[tj]s?(x) - 0 matches
testPathIgnorePatterns: /node_modules/ - 7 matches
testRegex:  - 0 matches
Pattern:  - 0 matches
npm ERR! Test failed.  See above for more details.
Error: Process completed with exit code 1.


Follow dark mode preference

This sets the the color scheme according to prefers-color-scheme (that follows the global dark mode setting in Gnome). You can still toggle the dark mode from the menu.

Awesome, can you run npm run format and npm run lint to pass code style build checks? Thanks!

Also curious, I am unable to test this on Windows and Mac. Would I be able to test this on a CCRMA linux machine?

You can set dark or light mode directly in your browser. In Firefox it's in the General tab under Website appearance. Automatic would be set by your desktop environment or operating system. In Chromium it's in Appearance -> Mode. Unfortunately setting it directly to light or dark is broken for me. The automatic part (Device) works though. Maybe it's only broken on Linux?!

I'm not sure when this was added in macOS and Safari, but there should be the same options as in Gnome and Firefox/Chrome.

Hmm interesting, I'm trying to switch light and dark mode settings on Chrome (Windows) but it doesn't seem to do anything. Maybe this only affects on Gnome?
In the past, the IDE theme used to similarly read browser light/dark mode but I ran into the issue of if your OS was dark but you wanted a light IDE, what is the source of truth? If you manually set it to light, how should the theme load after refreshing the page? Because of this confusion, I removed reading the browser theme to be OS theme agnostic.

In Chromium it didn't work for me either. I think that's a browser bug because it even follows my desktop setting when I explicitly choose dark mode. I checked that with this github repo page as github implements this too. Be aware that Github's main page (not logged in) is always dark.

In the past, the IDE theme used to similarly read browser light/dark mode but I ran into the issue of if your OS was dark but you wanted a light IDE, what is the source of truth? If you manually set it to light, how should the theme load after refreshing the page? Because of this confusion, I removed reading the browser theme to be OS theme agnostic.

Oh, I see. I think the correct thing to do then would be to save the setting as a cookie and have the options dark, light, and system. We do the same as the browser itself.

Oh, I see. I think the correct thing to do then would be to save the setting as a cookie and have the options dark, light, and system. We do the same as the browser itself.

Gotcha, yeah we only save the cookie for light/dark, not yet system. That would be a good feature...

This mostly works now. Though removing the Event Listener doesn't work. So even if you chose dark or light mode it still follows your browser or desktop setting. Maybe you understand why this doesn't work.

Format and lint don't agree on the formatting of switch statements?

Okay, I just didn't remove the event listener but returned early instead if colorPreference is not "system". This works now. It's rebased and ready to be merged.

I've implemented what we talked about on the way home. What do you think about the wording?

The dark mode toggle is now gone when turning on system preference.
https://ccrma.stanford.edu/~ntonnatt/webchuck-ide/

Rebased to dev.

It all seems to work! Could you put ChucK time first in the view dropdown to save a label? This way dark mode would be at the end of the dropdown? Then we can just call the label Theme to be neutral?

I know you removed the button now but when it was system but did you like the disabled button look? You can add disabled:opacity-50 button class to the html for the button, and set themeButton.disabled = true. Not sure if you liked it this way or not. I think it could be a bit more helpful?

Obey to Terry's orders ✓
Update https://ccrma.stanford.edu/~ntonnatt/webchuck-ide/ ✓
I forgot about the disabled option. I think it's better.

LGTM


typeahead: "keydown" events for Enter and Arrow keys should be ignored while "composition"

First, I describe what is the "composition".
In CJK language regions, people use some software named "IM" (input method) to input heir local language text. For example, when I search a Japanese term "日本語" (means "Japanese language") in a Zulip instance with Firefox, I need to do:

Click the search field.
Activate the IM. The "composition" session starts.
Type keys: n, i, h, o, and n. (in a composition session)
Hit the Space key to convert the text to Japanese term. "日本" is suggested. (in a composition session)
Hit the Enter key to determine the text "日本". (in a composition session)
Type keys: g, and o. (in a composition session)
Hit the Space key to convert the text to Japanese term. "語" is suggested. (in a composition session)
Hit the Enter key to determine the text "語". (in a composition session)
Deactivate the IM. The "composition" session ends.
Hit the Enter key again to search "日本語" on Zulip.

While the composition session, "keydown" events for special keys (Enter and Arrow) are handled by the IM to choose a term from variations or determine the choice. Thus I hit the Enter key three times in this case. The first time and the second are notified only to IM, so Zulip receives only the third time.
And, there is one problem on lately development build of Firefox.

1446401 - Start to dispatch keydown/keyup events even during composition in Nightly and early Beta
Intent to ship: Start to dispatch "keydown" and "keyup" events even if composing (only in Nightly and early Beta) - Google Group

Due to the change, now development build of Firefox (aka Nightly) notifies "keydown" events to the webpage, for all keyboard operations while "composition" sessions. As the result, the search field shows suggested results while I'm typing alphabet keys. This is good improvement, but there is one new problem: when I hit the Enter key to determine a chosen term, it is also notified to Zulip. Thus, when I just determine the first part term "日本" of the joined term "日本語", Zulip unexpectedly handles the Enter key to search the part "日本" and I cannot input following part "語" anymroe.
To fix this problem, Zulip need to ignore keydown events for Enter and Arrow keys while the composition session. While a composition session, all keydown events have the isComposing  property with true value, so you just need to return when the property is true. Could you apply this change to Zulip?
Environment:

Zulip 1.8.0
Mozilla Firefox Nightly 62.0a1
Ubuntu 16.04LTS + IIIMF ATOK X3

For example:
field.addEventListener('keydown', (event) => {
  if (/^(Enter|Arrow(Up|Down|Right|Left))$/.test(String(event.key) &&
      event.isComposing)
    return;

  ... // codes to do typeahead search
});

@piroor thanks for the thorough research!  We can definitely make something like this happen soon.

@zulipbot claim


[SPARK-18114][HOTFIX] Fix line-too-long style error from backport of SPARK-18114

What changes were proposed in this pull request?
Fix style error introduced in cherry-pick of https://github.com/apache/spark/pull/15643 to branch-2.0.
How was this patch tested?
Existing tests

Test build #67914 has started for PR 15719 at commit c56011e.

Merging in branch-2.0. I'm waiting for this to cut rc2.

Yep, sorry for this right in the middle of RC time. The change itself should be a perfectly fine bug fix.

Can you close this?

Test build #67914 has finished for PR 15719 at commit c56011e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67914/
Test PASSed.

Merged build finished. Test PASSed.


Add "back to top" button in all pages

For now, the "back to top" button is present only in home page, I would like to add it in all the other pages where it is missing.
@vishanurag Kindly assign me under the labels gssoc and hacktoberfest

@somyadipghosh Can you please assign me this issue?

@somyadipghosh You have assigned two members...but I raised the issue...kindly check...shall I start working on it?

@somyadipghosh please add level label also

@swathivemula7 you can start working on it, i've messed up, sorry for the issues.


fix: avoid stutter when starting playback on web

Description
Setting currentTime of AudioElement after calling play can cause a stutter, if the browser is able to start playback of the audio immediately and execution after play is delayed by other tasks in the event loop.
By setting currentTime before calling play this issue can be avoided.
Checklist

[x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
[x] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[x] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
[x] I have updated/added relevant examples in example.

Breaking Change

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

Related Issues

I'll try it out :)

OK, I've tried #1469, and while it does make the issue I'm having less likely it still happens sometimes.

@Gustl22 Friendly ping. Is there anything else I need to do?

I'll also try your branch ;) But I also wonder, what is the technical reason to avoid stutter, when setting the position before playing.

@blaugold Thank you very much for your contribution!


CloudFrontDistributionNoOutdatedSSL: Does not allow for s3 static hosting via cloudfront

What is the problem?
When using a cloudfront to front a static s3 hosted website as an origin, cloudfront may only use http-only

HTTP Only – CloudFront uses only HTTP to access the origin. This is the default setting when the origin is an Amazon S3 static website hosting endpoint and cannot be changed.

This conflicts with the CloudFrontDistributionNoOutdatedSSL rule which marks it as non compliant
            if (originProtocolPolicy != OriginProtocolPolicy.HTTPS_ONLY) {
              return NagRuleCompliance.NON_COMPLIANT;
            }

Reproduction Steps
When using isWebsite = true, S3Origin uses a HttpOrigin (aka CustomOriginConfig) which triggers the rule validation
    const bucket = Bucket.fromBucketArn(this, `Bucket`, `arn:aws:s3:::fake-bucket`);
    (bucket as any).isWebsite = true;

    new Distribution(this, `Distribution`, {
      domainNames: [`fake-domain.com`],
      certificate: Certificate.fromCertificateArn(this, `Certificate`, `arn:aws:acm:us-east-1:12121321:certificate/1b3b1b3b-1b3b-1b3b-1b3b-1b3b1b3b1b3b`),
      minimumProtocolVersion: SecurityPolicyProtocol.TLS_V1_2_2021,
      sslSupportMethod: SSLMethod.SNI,
      logBucket: Bucket.fromBucketArn(this, `LogBucket`, `arn:aws:s3:::fake-log-bucket`),
      logIncludesCookies: false,
      defaultBehavior: {
        viewerProtocolPolicy: ViewerProtocolPolicy.REDIRECT_TO_HTTPS,
        origin: new S3Origin(bucket),
      },
    })

What did you expect to happen?
It should exclude the S3 Origin as the security of the connections is ensured by AWS.
What actually happened?
[Error at /ReproStack/Distribution/Resource] AwsSolutions-CFR5: The CloudFront distributions uses SSLv3 or TLSv1 for communication to the origin.

cdk-nag version
2.28.114
Language
Typescript
Other information
No response

I don't think this is a valid exception for the rule. While AWS guarantees the security of the connection between CloudFront and S3, this does not apply to the security of the connection between the viewer and CloudFront.
You can use https with S3 buckets if you use a custom certificate/DNS. That being said that's still not compliant with the rule because while you can use "redirect http to https" you can't use the "https only".


⚠ Spryr has degraded performance

In e306150, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 6392 ms

Resolved: Spryr performance has improved in 5023117 after 7 minutes.


add github actions for gradle based builds

updates #1297

thanks a lot @atomfrede !

Bounty claimed https://opencollective.com/generator-jhipster/expenses/73020

@atomfrede : approved


Can't Send Email or Invitation Link

It was working fine but today i can't send invitation mails or invitation link is not working either with an error of
Traceback (most recent call last):
  File "/srv/zulip-venv-cache/0106a9fc82c8ee43b34e776f6871df9c89f3974f/zulip-py3-venv/lib/python3.6/site-packages/django/core/handlers/exception.py", line 41, in inner
    response = get_response(request)
  File "/srv/zulip-venv-cache/0106a9fc82c8ee43b34e776f6871df9c89f3974f/zulip-py3-venv/lib/python3.6/site-packages/django/core/handlers/base.py", line 187, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/srv/zulip-venv-cache/0106a9fc82c8ee43b34e776f6871df9c89f3974f/zulip-py3-venv/lib/python3.6/site-packages/django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "./zerver/views/registration.py", line 474, in accounts_home_from_multiuse_invite
    multiuse_object=multiuse_object)
  File "./zerver/views/registration.py", line 444, in accounts_home
    send_confirm_registration_email(email, activation_url, request.LANGUAGE_CODE)
  File "./zerver/views/registration.py", line 367, in send_confirm_registration_email
    language=language, context={'activate_url': activation_url})
  File "./zerver/lib/send_email.py", line 117, in send_email
    if mail.send() == 0:
  File "/srv/zulip-venv-cache/0106a9fc82c8ee43b34e776f6871df9c89f3974f/zulip-py3-venv/lib/python3.6/site-packages/django/core/mail/message.py", line 348, in send
    return self.get_connection(fail_silently).send_messages([self])
  File "/srv/zulip-venv-cache/0106a9fc82c8ee43b34e776f6871df9c89f3974f/zulip-py3-venv/lib/python3.6/site-packages/django/core/mail/backends/smtp.py", line 104, in send_messages
    new_conn_created = self.open()
  File "/srv/zulip-venv-cache/0106a9fc82c8ee43b34e776f6871df9c89f3974f/zulip-py3-venv/lib/python3.6/site-packages/django/core/mail/backends/smtp.py", line 64, in open
    self.connection = self.connection_class(self.host, self.port, **connection_params)
  File "/usr/lib/python3.6/smtplib.py", line 251, in __init__
    (code, msg) = self.connect(host, port)
  File "/usr/lib/python3.6/smtplib.py", line 336, in connect
    self.sock = self._get_socket(host, port, self.timeout)
  File "/usr/lib/python3.6/smtplib.py", line 307, in _get_socket
    self.source_address)
  File "/usr/lib/python3.6/socket.py", line 724, in create_connection
    raise err
  File "/usr/lib/python3.6/socket.py", line 713, in create_connection
    sock.connect(sa)
OSError: [Errno 113] No route to host

The error is pretty clear -- there's no route from your Zulip server to the server you've configured to handle outgoing email for it.  Likely a firewall configuration issue.   See https://zulip.readthedocs.io/en/latest/production/requirements.html#network-and-security-specifications.


External link url must contain a host

While the url http:/path-to-page is a valida URL it is not
valid for our purpose as we require the host that we are redirecting
to.
https://trello.com/c/nQfP94ph/312-search-admin-url-validation-in-search-admin-breaks-if-theres-only-one-slash

Hi,
Looks good. Could be good to add more feedback to the user?
Maybe something along the lines of
uri.is_a?(URI::HTTP) && uri.host.present?
record.errors[attribute] << "host (i.e www.example.com) not present" if !uri.host.present?

Though probably a neater way of doing it..?

@Rosa-Fox took a bit of effort but think this might be nicer.

It is still falling through to 'invalid url' if the host is not valid.
[1] pry(#<UrlValidator>)> value
=> "http:/path-not-host"
[2] pry(#<UrlValidator>)> uri = parse(value)
=> #<URI::HTTP http:/path-not-host>
[3] pry(#<UrlValidator>)> unless uri&.host
[3] pry(#<UrlValidator>)*   msg = options[:message] || (uri ? "is an invalid URL" : "does not have a valid host")
[3] pry(#<UrlValidator>)*   record.errors[attribute] << msg
[3] pry(#<UrlValidator>)* end
=> ["is an invalid URL"]

Briefly tried to figure out a solution, but will continue tomorrow!

@Rosa-Fox had the logic the wrong way around, this has now been fixed and the tests improved


Matching IETF draft. Using L not lambda

Feedback from @martinthomson was that we should not use lambda as it's hard to type.

Thank you both!