Common Controls 12.1v1 is being duplicated in the report

🐛 Summary
Common Controls 12.1v1 is being duplicated in the report.
Not sure what the reason for this is.
To reproduce
Steps to reproduce the behavior:
Run ScubaGoggles on the main branch with commoncontrols as a baseline selected.
Expected behavior
Only a single instance of 12.1 is being displayed
Any helpful log output or screenshots

This is actually by-design, though I'm sure there's a better way we could have done it.

The first row in the report corresponds to the arrow at the top, i.e., "Currently unable to check that Google takeout is disabled for services without..", which for some reason doesn't produce a log event.
The second row corresponds to "apps with individual admin control[s]," which do produce a logs event.

EDIT: I just checked. While what I said was once upon a time true, the top part does produce a log event now. So I would recommend implementing a check for that and combining the output of those two rows into a single row.


npm run start:firefox not loading firefox

Hi there,
I love to seeing the work on cross browser web extension starter kits.
I've been trying to get npm run start:firefox to work, I've commented out all the parts that run chrome, but I must have missed something because chrome keeps showing up.
Terminal output:

Changes made to start.js (switched from tsx)

Any help would be greatly appreciated. Thanks!

Hey @samuelmburu ,
thanks for giving this starter kit a try. I just pushed a patch that makes the start script a bit more robust. Can you give it a spin and let me know if it works?


Support for Face ID

I couldn't find anything for copy/updating an entry with face ID authentication. Is there anything required to support it or is the OS already handling that with the current query values?
Any plans to support Face ID instead of Touch ID when the device is capable of it?

@BennX I don't find face ID specific API in Keychain services. Local Authentication API has biometryType as readonly property. So I assume requiring touch ID falls back face ID UI automatically by iOS. Probably we don't need to do anything to support face ID.

@kishikawakatsumi ... the situation seems to be worse. From what I have found in the API docs and after checking with the miraculous internet, Apple has added FaceID support for LocalAuthentication framework, but not to Keychain APIs. Testing with simulator seems to confirm this so far for us, hopefully we will get some good news when we have a new device in our hands...

There is a post of a Apple dev that says:

FaceID does not work in the Xcode 9 GM due to a framework bug.
For now the best thing to do is to test on an iPhone 8 and ensure everything works with Touch ID.

https://forums.developer.apple.com/thread/86779

@BennX Thank you

Hi guys, I'd like to ask that this issue is reopened. By now Face ID works, so I don't see a reason why this project cannot support it. I'm not getting an ugly warning on iPhone X: "This app was designed to support Touch ID. It has not been updated for Face ID." Thanks!

@svdo You need to put NSFaceIDUsageDescription in your Info.plist...

Ah, I was looking in the wrong direction, thank you!


Add this language to GitHub's language detector

..when the name is finalized :-) Skylark files (.bzl, for example) are currently detected as Python files in GitHub's UI.
See https://github.com/github/linguist

Skylark is essentially a subset of Python.  Does it need to be treated differently from Python?

There are things in Python that you can't do in Skylark, so I feel that labeling it as Python (at least on GitHub UI) will be misleading.


[Request] Enable validation after getting data from server

First of all, thanks for your work with this library.
I'm using it to validate some forms in an app and it worked fine for register/login until I've reached the point of having it in an edit form.
The problem is that I can't pass any default value when I get data from server.
This is a WIP example of my edit user form
import React, { useEffect, useState } from 'react';
import axios from 'axios';
import { useTranslation } from 'react-i18next';
import { makeStyles } from '@material-ui/styles';
import Paper from '@material-ui/core/Paper';
import Typography from '@material-ui/core/Typography';
import Toolbar from '@material-ui/core/Toolbar';
import LockIcon from '@material-ui/icons/Lock';
import LockOpenIcon from '@material-ui/icons/LockOpen';
import Grid from '@material-ui/core/Grid';
import { Container } from '@material-ui/core';
import TextField from '@material-ui/core/TextField';
import useForm from '../../hooks/useForm';

const useStyles = makeStyles(theme => ({
  root: {
    flexGrow: 1,
  },
  isLocked: {
    cursor: 'pointer'
  },
  form: {
    width: '100%',
    marginTop: theme.spacing(1),
    marginRight: theme.spacing(2),
    marginLeft: theme.spacing(3),
  },
}));

export default function UserDetail({ match }) {
  const userId = match.params.id;
  const classes = useStyles();
  const { t } = useTranslation();

  const [user, setUser] = useState({});
  const [isLocked, setIsLocked] = useState(true);

  const stateSchema = {
    name: { value: '', error: '' }
  };

  const stateValidatorSchema = {
    name: {
      required: true,
      validator: {
        func: value => /^([A-Za-z\s]{2,20})$/.test(value),
        error: t('user.form.validation.name'),
      },
    },
  };

  function onSubmitForm() {
    console.log('submit')
  }

  function fetch() {
    axios.get(`${process.env.REACT_APP_API_PATH}/users/${userId}`)
      .then(response => {
        setUser(response.data);
      })
      .catch(error => {
        console.log(error.response);
      })
  }

  useEffect(() => {
    fetch();
  }, []); // eslint-disable-line

  const {
    values,
    errors,
    dirty,
    handleChange,
    handleSubmit,
    disable,
  } = useForm(stateSchema, stateValidatorSchema, onSubmitForm);

  const { name } = values;

  return (

      <Container maxWidth={'md'}>
        <Paper>
          <Toolbar>
            <Grid container>
              <Grid item md={11} xs={11}>
                <Typography variant="h6">
                  {t('user.toolbar.title')}
                </Typography>
              </Grid>
              <Grid className={classes.isLocked} onClick={() => setIsLocked(!isLocked)} item md={1} xs={1}>
                {isLocked ? <LockIcon fontSize={'large'} /> : <LockOpenIcon fontSize={'large'} />}
              </Grid>
            </Grid>
          </Toolbar>

            <form
              className={classes.form}
              onSubmit={handleSubmit}
              noValidate
            >
              <Grid container spacing={3}>
                <Grid item xs={12} sm={6}>
                  <TextField
                    required
                    fullWidth
                    disabled={isLocked}
                    InputLabelProps={{ shrink: true }}
                    id="name"
                    name="name"
                    label={t('user.form.fields.name')}
                    value={name}
                    onChange={handleChange}
                    error={errors.name.length > 0 && dirty.name}
                    helperText={errors.name}
                  />
                </Grid>
              </Grid>
            </form>

        </Paper>
      </Container>

  );
}

As you can see, I'm getting user data from a server and my idea is to update the initial state of the value and also trigger the validation as soon as this value is there (dirty = true).
I'm quite new with React so I'd appreciate any help.

Hi @JuanWilde  you need to define your stateSchema as state to be able to update the form once  data fetching happened.
See this example.
// Your new stateSchema define as local state
const [stateSchema, setStateSchema] = useState({value: '', error: ''});

function fetch() {
    axios.get(`${process.env.REACT_APP_API_PATH}/users/${userId}`)
      .then(response => {
        setStateSchema({value: response.data, error: ''});
      })
      .catch(error => {
        console.log(error.response);
      })
  }

Thanks, it worked :)

Hi @JuanWilde Thank you for raising this issue, Please disregard what I said before. I made a fix on the code regarding on this. Instead use the setFieldValue({name: 'name', value: 'Your form value'}) top level API to update the specific value of a field and it takes a parameter object contais name and value that let you specify what field to be updated. Let me know if this works for you. Thanks

Hi! Your last fix seem to do the trick. The only thing I miss is the change of the dirty state of the field. because after setting the value coming from the server I still see the value from utils.js
export const REQUIRED_FIELD_ERROR = 'This is required field';

Yea I notice it. I made an update to create setStateSchema top level API to set a brand new initialState for your fields and also the errors. See my example here.

Cool! Thank a lot for your time updating this tool! I won’t be able to test it until next week but I’ll post my results ASAP!

No worries @JuanWilde I'm very thankful that you found and raise those issues. I hope someone can also contribute in this library. Please stay tune for the next incoming updates ^_^

HI! I had time to check the latest changes and with this approach now is working fine! I'll update other forms in my project and let you know if any issue is found :)
Thanks

Hi @llauderesv
As per your this example -
https://codesandbox.io/s/react-form-validation-e7jlq?file=/src/Form.js:1860-1867
the button is still disabled. Can you please help me out?
Thanks in advance :-)

Hi @akash-int
As per the example all fields are required. That's the reason why the button is still disabled.
You need to fill-out the tags field so that button become enabled.

Hi @llauderesv
I have tried with one field also. Even after setting value to that one particular field also the button remains still disabled 😔

Hi @akash-int
Can you show your link of your code so that I can check it.

Hi @llauderesv
Sorry! I have tried to create a sandbox example but as I have many more dependencies so unable to show you the example.
But in your this example https://codesandbox.io/s/react-form-validation-e7jlq?file=/src/Form.js:1860-1867
I have tried by removing tags field from everywhere of your code. So after that first_name & last_name these two fields are required: true & I'm updating value by -
setStateSchema({
first_name: { value: "Ellie", error: "" },
last_name: { value: "Eilish", error: "" }
});
// setFieldValue({ name: 'first_name', value: 'Hello' }); // this is commented out
// setFieldError({ name: 'first_name', error: 'Vince' }); // this is commented out
so after that also button remains still disabled

Hi @llauderesv
I have modified a bit your example please check & let me know how to enable the disabled button I'm stuck at this point :-(
https://codesandbox.io/s/elastic-shamir-9nszl?file=/src/Form.js
Thanks in advance!

Hi @akash-int
Sorry for the late response. I noticed that this is bug the code and I already fixed it (See my latest commits). But anyway I already updated the sandbox with latest code so that you can check your example if it's already working.
Let me know if encounter any problem. Thanks!

Hi @llauderesv
First of all thanks for the update. Can you please share the updated sandbox link here so that it'll be very helpful for me :-)


Fix/cancel index polling

Fixes ENG-854

@jamespohalloran  I made mind updates. Mind taking another look?


SIGSEGV in Reconciler

Expected Behavior
Should run fine
Actual Behavior
Leads to a segmentation violation.
Steps to Reproduce the Problem

Created TaskRun on OpenShift 3.11

apiVersion: tekton.dev/v1alpha1
kind: TaskRun
metadata:
  name: git-mirror-run
spec:
  serviceAccount: git-mirror
  taskRef:
    name: git-mirror-task
  inputs:
    params:
      - name: srcRepo
        value<EMAIL_ADDRESS>      - name: destRepo
        value: git@github.com:foo/bar_common.git

Additional Info
Logs print:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x134621b]

goroutine 204 [running]:
github.com/tektoncd/pipeline/pkg/reconciler/v1alpha1/taskrun.(*Reconciler).checkTimeout(0xc0004956c0, 0xc00037a280, 0xc000940c30, 0xc0009012f8, 0xc00090f820, 0x0, 0x69e489)
	/workspace/go/src/github.com/tektoncd/pipeline/pkg/reconciler/v1alpha1/taskrun/taskrun.go:536 +0x9b
github.com/tektoncd/pipeline/pkg/reconciler/v1alpha1/taskrun.(*Reconciler).reconcile(0xc0004956c0, 0x19aa620, 0xc0007f1d10, 0xc00037a280, 0xed4be7aee, 0x27a75a0)
	/workspace/go/src/github.com/tektoncd/pipeline/pkg/reconciler/v1alpha1/taskrun/taskrun.go:264 +0x3fd
github.com/tektoncd/pipeline/pkg/reconciler/v1alpha1/taskrun.(*Reconciler).Reconcile(0xc0004956c0, 0x19aa620, 0xc0007f1d10, 0xc000bdc780, 0x1f, 0xc00097e8a8, 0x19aa620)
	/workspace/go/src/github.com/tektoncd/pipeline/pkg/reconciler/v1alpha1/taskrun/taskrun.go:171 +0x58b
github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller.(*Impl).processNextWorkItem(0xc00059d200, 0x175be00)
	/workspace/go/src/github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller/controller.go:330 +0x514
github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller.(*Impl).Run.func1(0xc00089c7f4, 0xc00059d200)
	/workspace/go/src/github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller/controller.go:282 +0x51
created by github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller.(*Impl).Run
	/workspace/go/src/github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller/controller.go:280 +0x1a5

@abergmeier which version of tekton is running ?

Tried both 0.5.0 and 0.5.1.

Interesting… :thinking: Was that TaskRun created before 0.5.x or after ?
Somehow you are running into a case that shouldn't happen… as Timeout.Duration should never be nil at that point. The only case it can happen are :

The TaskRun is older, thus it's not present … I feel we will need to fix that (and backport it :sweat_smile:)
The webhook didn't make his work (which I am really doubtful about it)

TaskRun was created with 0.5.0.

@abergmeier the webhook sets default values, and in there, the default, configured, timeout for all TaskRun. So that Timeout field should never be nil post 0.5.0.
Did you have pre-existing TaskRun before deploying 0.5.0 ? (aka did you update the controller with already existings TaskRuns)

@abergmeier the webhook sets default values, and in there, the default, configured, timeout for all TaskRun. So that Timeout field should never be nil post 0.5.0.

Without knowing the technical details - this sounds brittle to me.

Did you have pre-existing TaskRun before deploying 0.5.0 ? (aka did you update the controller with already existings TaskRuns)

Not at all - this is a fresh cluster :)

/kind bug
/assign

FYI, I ran into the exact same issue in the same place an hour ago with taskRun when following the https://github.com/tektoncd/pipeline/blob/master/docs/tutorial.md.

@carltonmason thanks :angel: which version of kubernetes (and/or OpenShift) are you using ?
@carltonmason @abergmeier can you display what kubectl get mutatingwebhookconfiguration says ?

can you display what kubectl get mutatingwebhookconfiguration says ?

$ oc get mutatingwebhookconfiguration
NAME                 CREATED AT
webhook.tekton.dev   2019-07-12T12:50:53Z

@abergmeier @carltonmason are you using Task or ClusterTask for those ?

are you using Task or ClusterTask for those ?

Task

I am using Tekton 0.5.1 release on Mac and I am using Task.
ckmason@carltons-mbp:tekton-learn$ minishift version
minishift v1.33.0+ba29431
ckmason@carltons-mbp:tekton-learn$ oc version
oc v3.11.0+0cbc58b
kubernetes v1.11.0+d4cacc0
features: Basic-Auth

Server https://<IP_ADDRESS>:8443
kubernetes v1.11.0+d4cacc0

oc get mutatingwebhookconfiguration
NAME                 CREATED AT
webhook.tekton.dev   2019-07-15T21:20:34Z

Thanks for the quick fix.


Fixing errors because of changes in the AzureRM API

Replacing SubscriptionId with Id in two places to enable script to successfully run.

@jeroenterheerdt,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


[docs] Add a topic about Jenkins integration

\cc @DevExpress/testcafe-docs
fixes #1850

I followed the steps in the PR, I have given the commands in the 'Execute Shell' instead of 'Windows Batch Command'
I tried using 'nightmare' and "chrome:headless" for the browser
Looks like Jenkins can't find any browsers
I get the below errors

node_modules/.bin/testcafe nightmare tests/ -r xunit:res.xml
ERROR Unable to establish one or more of the specified browser connections. This can be caused by network issues or remote device failure.

node_modules/.bin/testcafe chrome:headless tests/ -r xunit:res.xml
ERROR Was unable to open the browser "chrome:headless" due to error.
Error: Unable to run the browser. The browser path or command template is not specified.

testcafe -b doesn't yield any output
Please suggest

Hi @sunainajain , let's continue our discussion on our forum: https://testcafe-discuss.devexpress.com/t/steps-for-jenkins-setup/607

@testcafe-build-bot \retest


Adobe XD design

Can you please provide Adobe XD design as well? I can open the .sketch file with XD but some stuff are missing.
Many thanks.

I don’t have XD and don’t really use it but would be happy to accept a version of the design in XD as a contribution


Use getter for the nextTestRunUrl. Implement Runner.src() and Runner.filter(). Add temporary ugly adapter for the old fixture compiler.

\cc @AlexanderMoskovkin @churkin @kirovboris
@VasilyStrelyaev please, check the strings in tests and error messages.
P.S. src/compiler/old contains old fixture compiler code without modification. You shouldn't review it, since it will be replaced with the new compiler later.

lgtm

tests are failing.

FPR

lgtm

lgtm

lgtm

thx


New contribution document Contents

I am planning to write a new contribution documentation CONTRIBUTING.md. Based on this, I will update the webpage's contribution doc.
I am planning to write these things.

The current content (like how to compile query frontend) + custom docker image
How our current CI works
Link to the design doc, concepts doc, research paper
How to work on clipper admin
Useful information (ex, https://github.com/ucbrise/clipper/issues/683) -> 683 should not be in contribution doc.
How to deploy KubernetesContainerManager (based on https://github.com/ucbrise/clipper/issues/598). The contents can be changed.

Please recommend me more contents!

From my experience more on the logging process - how could we understand how it's being sent, how to redirect it somewhere else or use another tool to gather the logging data and so on would be useful.

@jacekwachowiak For sure! That will be a very important part. I will definitely add it.

One more thing - I was testing Clipper with different frameworks and so I have some basic working examples on most of them: PySpark, PyTorch, MXNet, Tensorflow, Scikit, XGBoost in form of easy Jupyter notebooks. Do you think it's worth to add them to the repository so that you can check Clipper deployment without really writing any code and then go from it to more specific solutions? I know the documentation has some code snippets and there is a pair of examples for python and metrics but it's not complete and the documentation may be confusing (it was in case of MXNet and Tensorflow for me). If so, I would create a PR as soon as I clean up the notebooks I have. For some frameworks (TF, Pyspark) I have also a K8s version.

That actually sounds amazing! We will appreciate any form of contribution to the project. You can write them under example folder. Feel free to create new directories if there's no proper category for your tutorial!

@jacekwachowiak Thanks again for awesome work!

This is my basic structure.

Quick Start
Guideline

Feature Request
Pull Request
How to Answer Issues

How to Start
Style Guides

C++
Python

Development

CI
Client Library Develpment (clipper-admin)

Debug
Logging

Core Development

Want to learn Clipper

Simple Explanation

Concepts
Architecture

Resources

I was wondering if some hints or good practices about Clipper deployment on different versions of Kubernetes - GKE, EKS. bare metal and so on could be included. It can save a lot of time, if you're sure that your cluster is ready for Clipper. I saw quite a few issues about Clipper never initializing correctly on Google's Kuberenetes or AWS, taking a long time or working only partially and I think it's a safe assumption that a big part of clusters come from those providers. (Yesterday I tried briefly to start Clipper on GKE assuming the out-of-the-box approach - default cluster, default python, default Clipper setup and no luck). For now if I am not wrong, the documentation says a K8s cluster must be provided but past experiences show that things like the proxy, RBAC, permissions matter a lot.

@jacekwachowiak Good point. I agree with you. Seamless integration with those public cloud services and minikube will be one of our primary goals in the future releases. For now, it is a little hard to write docs for all of different versions of Kubernetes because we don't have sufficient examples yet. Maybe the initial contribution doc wouldn't contain them, but we should definitely add them as time goes. Thanks for the great feedback.


Remove "from x cimport class C"

(and "from x cimport struct S"/"from x cimport union U")
This appears to be an old Pyrex feature introduced in
https://github.com/cython/cython/commit/9bac9c2e014ed63c2ac435e9b431fae124fba668
to provide a way of "forward cimporting" a class. I originally tried to make
a test for it, but couldn't actually come up with a useful way
of using it in the intended way, where the name would be unavailable
initially but avaialble later.
It looks to be completely untested, and responsible for some missing
coverage in Nodes.py (https://github.com/cython/cython/issues/4163).
The large section containing
if kind == 'struct' or kind == 'union':  # 8479 ↛ 8480

I propose to fix the missing coverage by killing off the feature.
The only people I could find using this syntax were H5Py, who
look to have removed their sole use of it 3 years ago
https://github.com/h5py/h5py/commit/8d2498c7f5e3fec884ff56e9aca905c325d82484
Therefore it seems a good candidate to go in Cython 3

FWIW looking at the Pyrex changelog (https://www.csse.canterbury.ac.nz/greg.ewing/python/Pyrex/version/CHANGES.txt)
<IP_ADDRESS>
-------

[...]

Deprecations:

  - The features introducted in 0.9.8 and <IP_ADDRESS> for cross-forward-declaring
    extension types between .pxd files turn out to be unnecessary, since
    the circular import problems they are aimed at can be avoided using
    ordinary forward delcarations in the .pxd files ahead of any cimports.

[...]

<IP_ADDRESS>
-------

 [...]

  - There's now an even easier way to forward-declare a struct, union
    or extension type in another module:

    	from blarg cimport class Foo

    This simultaneously cimports the name Foo and forward-declares
    it as an extension type. As well as 'class', you can also use
    'struct' or 'union'.

so it looks like this feature didn't last too long in Pyrex either.

I propose to fix the missing coverage by killing off the feature.>

+1, I also knew nothing about it.


python3Packages.volkszaehler: 0.3.0 -> 0.3.2

Motivation for this change
Update to latest upstream release 0.3.2
Change log: https://github.com/home-assistant-ecosystem/python-volkszaehler/releases/tag/0.3.2
Fix build (https://hydra.nixos.org/build/159218463)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 147112 run on x86_64-linux 1

2 packages built:

python38Packages.volkszaehler
python39Packages.volkszaehler


Use case/function

Hello,
I'm curious and really happy/interested about babili, so I have one question.
Does babili minify and uglify code? Because when running babili with my build step I don't seem to be saving as much as when using UglifyJSPlugin. Which is why I'm wondering if it also uglifies the code removing space, etc to save bytes. If not what is the encouraged/best way to go about uglyfying the code to once babili minifies it?
Also are there any tips for making sure that babili always outputs as small files as possible?

You can pass in some babel opts - http://babeljs.io/docs/usage/options/
minified: true,
compact: true,
comments: false,
// or
shouldPrintComment() { return false; }

@boopathi what would that look like in .babelrc? is it like in an options: {..}?

If you're using babili as CLI, babelrc wouldn't work. You have to pass --no-comments from CLI.
If you're using babel-preset-babili, you can add the above options in babelrc and pass in other options alongside presets.
{
  "presets": ["es2015"],
  "env": {
    "production": {
      "presets": ["babili"],
      "comments": false
    }
  }
}


Float input can't be None

Bug Description
All int inputs can be none and fallback to default behaviours of the component. For floats, it should be the same; however currently it's always required
Reproduction
Any float input
Expected behavior
To leave it empty and let the component computes a default
Who can help?
No response
Operating System
any
Langflow Version
any
Python Version
3.12

hi @nicoloboschi
It was a frontend treatment that was different on the FloatComponent and the IntComponent.
#3953


Property sheets use inconsistent case for labels

Describe the bug
Our use of case for property labels is all over the map. We should use consistent case for property labels.

We need to conform to Sentence case, however the inconsistent in your example comes off of the component schemas.


test: update live-reload test to reduce flakes

assign dynamic port to proxy server
remove RXJS finalize in favor of finally

Tried several runs and didn't see any flakes.


Failed to save to specified file

Hello!  Thanks for providing this very useful plugin!
Occasionally, I get this error.

Thanks

Very old issue, maybe already fixed. => closed.


Support advertising Pod CIDRs via BGP

This pull request implements the ability to advertise a node's Pod CIDR configuration via BGP.
In doing so modifications are made to our k8s event handling infrastructure. The most notable change being the support for "Notification Chains".  This pattern is described further in this issue: https://github.com/cilium/cilium/issues/15471
A new flag is made available to the Agent for configuring Pod CIDR BGP announcements:
 --bgp-announce-pod-cidr                                Announces the node's pod CIDR via BGP

Fixes: https://github.com/cilium/cilium/issues/15015

👀

addressing this:
Interesting situation: when a node is deleted, will Cilium even get a chance to run this logic? Does K8s allow daemonsets to exit gracefully? If Cilium doesn't, then the pod CIDRs will not be withdrawn and the routes will stay on the BGP router
after some deliberation with @christarazi and @andreek we dug up the follow error handling clause from the BGP-4 spec.
Per https://datatracker.ietf.org/doc/html/rfc4271#section-6.1
The phrase "the BGP connection is closed" means the TCP connection
   has been closed, the associated Adj-RIB-In has been cleared, and all
   resources for that BGP connection have been deallocated.  Entries in
   the Loc-RIB associated with the remote peer are marked as invalid.
   The local system recalculates its best routes for the destinations of
   the routes marked as invalid.  Before the invalid routes are deleted
   from the system, it advertises, to its peers, either withdraws for
   the routes marked as invalid, or the new best routes before the
   invalid routes are deleted from the system.

This indicates to us, a best effort BGP route withdrawal mechanism will be adequate as long as the ToR routers follow the correct spec.
I'll continue this PR with Chris's initial plan, check for a Delete node event and plug in the necessary UNSET method into the MetalLB fork.

@ldelossa It seems the commits aren't authored properly, but some are. I think the ones that say "Louis DeLosSantos committed" are not being tied to your GitHub account / email.

test-me-please

test-me-please

test-me-please

@christarazi yeah, this grew legs while picking up the branch half way and hacking on it further.
I'll squash your suggestions here and see what it looks like. If its possible to cleanly squash things more or reorder the commits further I'll take a stab at it.

Right now I'm signed off on the commits as well, does that imply "co-author" ?

I've interpreted "signed off" as ACKed / approved, but I imagine these interpretations vary among the Cilium team. "Co-author" will actually cause GH to also attribute the commit to you. It's what I prefer to use when I work on some code with other(s).

@christarazi git history cleaned up.

@christarazi licenses fixed.

test-me-please

test-me-please

test-me-please

test-me-please

blocked on https://github.com/cilium/cilium-cli/issues/367

We tried the cilium agent build with this pr on our test setup.
It crashed while trying to advertise on a  session.
Our bgp neighbours don't answer immediatly to the bgp open.
However, metallb has no problem advertising its VIPs.
I've joined a smal log of a bgp agent that crash.
log-crash-podcidrs-bgp-1.txt

@sbskas thanks for reporting this -  I will investigate this further.

@sbskas  - Can you please try with the latest code. The line number you have listed in that log does not exist.
If you continue to experience this issue can you open an issue and assign me? Thanks.

/test

Created flake ticket: https://github.com/cilium/cilium/issues/17664
I cannot reproduce the failing runtime test when running the Ginkgo tests locally.


Media Lib deserialze taking longer time

I'm working one of the migration project from  7.2 140526 to 7.2 160123, Started using unicorn for content move from lower ver to 7.2 16.   Serialization is done in few mins for media lib about 565 mb size. while sync with new database content node items are done fast. But media lib sync is taking about 10 mins per file
Both the database are reside on the same data
Below is the console message
[U] master:/sitecore/media library/Dewalt/Images/Safety_Recall/2005RepairProgramfor1373nailerrepair (f3ec0ba1-1a81-467d-9381-7064da72dc1c)

Template: Serialized 'Image', Source 'Image'

[T] from Image to Image
[U] master:/sitecore/media library/Dewalt/Images/Safety_Recall/2007DEWALTDC305recipsaw (b5cb48fe-a12a-4041-b529-d1c20d41b754)

Template: Serialized 'Image', Source 'Image'

[T] from Image to Image

I have also attached the item the yaml and log files.
Sitecore version 7.2. 160123 and Unicorn version 4
2005RepairProgramfor1373nailer.zip
Note: I have setup separate sitecore instance for deserialize. Another instance is running using the same database for website content delivery.

It appears that the template ID of the serialized item, and the item in Sitecore do not match. This is causing it to deserialize the blob each time, which is slow. Verify your IDs match between the items.
You mentioned using Unicorn 4 - which version? Some of the earlier prerelease versions had some silly bugs (the current versions are being used in a production site). Does the same issue happen with 3.3.x?


Update error messages to indicate the correct recipe-script to use when running standardized script on wrong backend

Description of Problem
See my comment in #6 and my other comment for more context. We're currently using a standardized npm script to run a specific recipe using the npm config value. For example
npm run node --cookbook:recipe=MyRecipeName
npm run node --cookbook:recipe=BrowserExample
npm run browser --cookbook:recipe=HalogenExample

The problem arises when we use this standardized script to run a browser-only recipe. For example
npm run node --cookbook:recipe=HalogenApp

The error message should say "This recipe doesn't work on the Node.js backend. It only works on the browser backend. Please run <correct command> instead." (or vice versa for Node-only recipes)
Unfortunately, we currently get this:
$ npm run run --cookbook:recipe=RoutingHashHalogen

> cookbook@ run /home/jordan/Programming/Git Projects/purescript-cookbook
> spago run --main $npm_package_config_recipe.Main

[info] Installation complete.

[info] Build succeeded.
/home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect.Aff/foreign.js:532
                throw util.fromLeft(step);
                ^

ReferenceError: window is not defined
    at exports.window (/home/jordan/Programming/Git Projects/purescript-cookbook/output/Web.HTML/foreign.js:5:3)
    at /home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect/foreign.js:12:16
    at /home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect/foreign.js:12:16
    at __do (/home/jordan/Programming/Git Projects/purescript-cookbook/output/Halogen.Aff.Util/index.js:36:183)
    at runAsync (/home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect.Aff/foreign.js:98:20)
    at run (/home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect.Aff/foreign.js:333:22)
    at /home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect.Aff/foreign.js:639:15
    at drain (/home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect.Aff/foreign.js:120:9)
    at Object.enqueue (/home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect.Aff/foreign.js:141:11)
    at Object.run (/home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect.Aff/foreign.js:638:23)
[error] Running failed; exit code: 1
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! cookbook@ run: `spago run --main $npm_package_config_recipe.Main`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the cookbook@ run script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jordan/.npm/_logs/2020-06-11T01_41_20_388Z-debug.log

There's a few ways we could approach this:

check whether the recipe has a specific file. If it does, then assume the recipe can be run for that particular target. This is easiest to do, but doesn't come with any real guarantees.
check whether a specific file in the recipe's folder that contains the backends for which it can compile contains the targeted backend. If it does, run the target; otherwise, print an error with list of targets. This is easier to maintain, but doesn't come with any real guarantees.
check the recipe's spago.dhall file and see whether a specific package is included in the list of dependencies (e.g. via cat spago.dhall plus some additional bash scripting). This is more reliable than other approaches, but can lead to false positives (i.e. someone installs a dependency they don't use)
attempt to run the program and print an error message encouraging user to try other targets. Probably the best way, but I'm not sure how to do this via make yet since every command run in make is done in a separate shell.

For 4, we could use .ONESHELL to remove that limitation, but I'm not sure whether that's desirable...

I'm thinking either 1 and/or 2 to generate all valid makefile targets.
We might also be able to do something clever to generate these from the recipe table.
We could then investigate CI options for running these recipes (I suspect there are a few good ways to do this). That will catch any invalid backends mistakenly marked as supported.
If the CI plans don't pan out, we could also include a note before the table of recipes with a link to a later "Troubleshooting" section that contains a few examples of errors encountered when attempting to run on an unsupported backend. For example: ReferenceError: window is not defined means browser is an invalid backend.

For example: ReferenceError: window is not defined means browser is an invalid backend.

Thinking about this more... the error arises because spago run wraps the output of spago build in a require(./output/Recipe.Main).main(); right? In other words, if we added a separate file that includes something like below and ran that script, it would suffice, correct?
var script = require("./output/Recipe.Main);
try {
  script.main();
} catch e {
  console.log("This recipe cannot be run in the Browser.");
}

Then running a recipe would be
spago bundle-app -m Main -t file.js
node browserFile.js

That's worth a shot.
It may be good to reword the error message a bit to:

The following error may be caused by incompatibility with the browser. See <link to troubleshooting section in readme> for more information.

Then rethrow the original error.

Yeah, that wording is better. Let's go with that.

I added a node.js file in the RoutingHashHalogen file:
var script = require("../../output/RoutingHashHalogen.Main");
try {
  script.main();
} catch (error) {
  console.log("This recipe cannot be run on Node.");
  console.log("");
  console.log(error);
}

then ran node recipes/RoutingHashHalogen/node.js, which produced this output:
/home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect.Aff/foreign.js:532
                throw util.fromLeft(step);
                ^

ReferenceError: window is not defined
    at exports.window (/home/jordan/Programming/Git Projects/purescript-cookbook/output/Web.HTML/foreign.js:5:3)
    at /home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect/foreign.js:12:16
    at /home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect/foreign.js:12:16
    at __do (/home/jordan/Programming/Git Projects/purescript-cookbook/output/Halogen.Aff.Util/index.js:36:183)
    at runAsync (/home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect.Aff/foreign.js:98:20)
    at run (/home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect.Aff/foreign.js:333:22)
    at /home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect.Aff/foreign.js:639:15
    at drain (/home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect.Aff/foreign.js:120:9)
    at Object.enqueue (/home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect.Aff/foreign.js:141:11)
    at Object.run (/home/jordan/Programming/Git Projects/purescript-cookbook/output/Effect.Aff/foreign.js:638:23)
[error] Running failed; exit code: 1

I presume this is caused by runHalogenAff?
So, it doesn't look like my "script wrapper" idea will work...


Some inquires about the confidence offset calculation

Hi jinsun!
I looking through #16 . And your lastest version.
if I understand correctly, for a new training model, there is no need to compute the relative coordinate ww and hh.
I think there should better use a if judgement for reduce the computional complexity?
Here:
                ww = idx_off % self.k_f
                hh = idx_off // self.k_f

                if ww == (self.k_f - 1) / 2 and hh == (self.k_f - 1) / 2:
                    continue

                offset_tmp = offset_each[idx_off].detach()

                # NOTE : Use --legacy option ONLY for the pre-trained models
                # for ECCV20 results.
                if self.args.legacy:
                    offset_tmp[:, 0, :, :] = \
                        offset_tmp[:, 0, :, :] + hh - (self.k_f - 1) / 2
                    offset_tmp[:, 1, :, :] = \
                        offset_tmp[:, 1, :, :] + ww - (self.k_f - 1) / 2

                conf_tmp = ModulatedDeformConvFunction.apply(
                    confidence, offset_tmp, modulation_dummy, self.w_conf,
                    self.b, self.stride, 0, self.dilation, self.groups,
                    self.deformable_groups, self.im2col_step)
                list_conf.append(conf_tmp)

            conf_aff = torch.cat(list_conf, dim=1)
            aff = aff * conf_aff.contiguous()```

The calculation you mentioned is still needed to "skip" the reference at the patch center.
You may check how aff and aff_ref are calculated to understand this process!

Ok, yeah, I understand. thx


Add selinux-policy-targeted and distribution-gpg-keys

This is part of reusing the bib container to build base images; rpm-ostree wants to have a policy to bootstrap from currently.
For distribution-gpg-keys, it allows .repo files to reference those unconditionally.
Also, reuse a "make package lists declarative" model I've used in other places.  It'd be nice to try to semi-standardize this of course, or even better upstream it into dnf.
We're looking at adding a different Containerfile in https://github.com/osbuild/bootc-image-builder/pull/174 and this way it can source the same requirements.

To be clear my goal is to be able to apply this change to the centos-bootc repo:
diff --git a/.github/workflows/build-image.yml b/.github/workflows/build-image.yml
index 13b9623..d500f4f 100644
--- a/.github/workflows/build-image.yml
+++ b/.github/workflows/build-image.yml
@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest

     container:
-      image: quay.io/centos-bootc/builder:latest
+      image: quay.io/centos-bootc/bootc-image-builder:latest
       options: --privileged

     strategy:

Because just from a mechanics perspective, we're already shipping nearly all the relevant code in this container image anyways right now.
That said, I guess I could try to teach rpm-ostree not to hard require selinux for this case, but I can't imagine there's any problems in having the extra dependencies here for now.


Delete duplicate sensio_framework_extra config

It exists already as https://github.com/symfony/demo/blob/bbe5180a8c3b6886ea59227df83de59a4573e586/config/packages/sensio_framework_extra.yaml

Tobias, thanks a lot for this and all the other fixes you sent for the Symfony Demo app.


trimHeadFrames: Discarded unknown attribute and Source Maps not Applying

OS:

[ ]  Windows
[ x]  MacOS
[ ]  Linux

Platform:

[ x]  iOS
[ ]  Android

Output of node -v && npm -v && npm ls --prod --depth=0
v10.12.0
6.4.1
<EMAIL_ADDRESS>/Users/***/***
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
Config:
Sentry.config(environment.SENTRY_DSN).install();

I have following issue:

Steps to reproduce:

Populate index.js with the react native plugin for sentry
Create a Logger file and initialise sentry
Run the uploadSourceMaps script to bundle and upload our artifacts
This  trimHeadFrames: Discarded unknown attribute has nothing to do with artifacts it seems because the error is still the same when I delete them all

// index.js

import './polyfill';
import { AppRegistry } from 'react-native';
import { App } from './src/App';
import { name as appName } from './app.json';
import Raven from 'raven-js';

require('react-native-sentry/lib/raven-plugin')(Raven);

AppRegistry.registerComponent(appName, () => App);

// Logger.ts

Sentry.config(environment.SENTRY_DSN).install();

Sentry.setRelease(environment.RELEASE);
Sentry.setTagsContext({
  environment: environment.APP_ENV,
  react: true,
});

// uploadSourceMaps.sh

SOURCE_MAP_PATH='.dist/main.jsbundle.map'
SOURCE_PATH='.dist/main.jsbundle'

rm -rf .dist/main.jsbundle.map
rm -rf .dist/main.jsbundle
react-native bundle \
  --dev false \
  --entry-file index.js \
  --bundle-output $SOURCE_PATH \
  --sourcemap-output $SOURCE_MAP_PATH

./node_modules/@sentry/cli/sentry-cli \
  --auth-token $SENTRY_AUTH_TOKEN \
  releases \
  --org *** \
  --project *** \
  files $RELEASE \
  upload $SOURCE_PATH "~/main.jsbundle" \

./node_modules/@sentry/cli/sentry-cli \
  --auth-token $SENTRY_AUTH_TOKEN \
  releases \
  --org *** \
  --project *** \
  files $RELEASE \
  upload-sourcemaps $SOURCE_MAP_PATH \
  --rewrite \
  --validate

Actual result:

Stack traces aren't source mapped on the Sentry issue
Sentry issue displayed message There was 1 error encountered while processing this event trimHeadFrames: Discarded unknown attribute

Expected result:

I expected no errors and I expected my stack trace to be source mapped

Solved:
Turns out my environment tag that I was logging with didn't match the environment of my artifacts. So I just removed that.
Sentry.setTagsContext({
  // environment: environment.APP_ENV,
  react: true,
});

@rmit-s3539777-abgier-avraha did you ever find out what could be causing the trimHeadFrames: Discarded unknown attribute? I'm getting the same message

@cruzach I didn't but does it affect anything for you? My source maps started working after removing the environment property.

Doesn't seem to be affecting anything.
But even then, it's an eye sore so was curious what the root cause might be/how to get rid of it

Hey, this can be safely ignored. This issue only surfaced recently because we implemented stricter payload validation on the server. We will fix this in the next major version of the SDK.

I am closing all old issues, please if this is still a problem feel free to revive it.
Also, consider moving to our new SDK @sentry/react-native if it still happens there please open a new issue.


Fully document service_mesh lib.

Enhancement Proposal
The example in the service_mesh lib docs is not very in depth. Lets make it more detailed.

todo from #13:

[ ] https://github.com/canonical/istio-beacon-k8s-operator/pull/13#discussion_r1773582345
[ ] https://github.com/canonical/istio-beacon-k8s-operator/pull/13#discussion_r1773585120
[ ] https://github.com/canonical/istio-beacon-k8s-operator/pull/13/files#r1778980694


AccessViolationException when launching the game on Linux

When using the program (versions 3.0.4 and 3.0.3) on Linux with the game version 4.7, the game launches but the fps cap is not modified (stuck with in-game setting).
Before 4.7 it was working fine and I haven't updated anything else except the game, so that latest update must be the cause of the problem (or maybe it revealed a bug in wine/Linux that wasn't a problem in the other versions).
It seems that unlockfps_nc.exe gets an exception when it tries to modify the memory to change max fps.
Setting the env variable WINEDEBUG=+seh on the command line shows this exception:
Application: unlockfps_nc.exe
CoreCLR Version: <IP_ADDRESS>11
.NET Version: 8.0.2
Description: The process was terminated due to an unhandled exception.
Exception Info: System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
Stack:
   at unlockfps_nc.Utility.ProcessUtils.PatternScan(IntPtr, System.String)
   at unlockfps_nc.Service.ProcessService.SetupData()
   at unlockfps_nc.Service.ProcessService+<Worker>d__18.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Threading.Tasks.VoidTaskResult, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[unlockfps_nc.Service.ProcessService+<Worker>d__18, unlockfps_nc, Versio"...
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Threading.Tasks.VoidTaskResult, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[unlockfps_nc.Service.ProcessService+<Worker>d__18, unlockfps_nc, Versio"...
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Threading.Tasks.VoidTaskResult, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[unlockfps_nc.Service.ProcessService+<Worker>d__18, unlockfps_nc, Versio"...
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(System.Runtime.CompilerServices.IAsyncStateMachineBox, Boolean)
   at System.Threading.Tasks.Task.RunContinuations(System.Object)
   at System.Threading.Tasks.Task`1[[System.Boolean, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].TrySetResult(Boolean)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.Boolean, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].SetExistingTaskResult(System.Threading.Tasks.Task`1<Boolean>, Boolean)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.Boolean, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].SetResult(Boolean)
   at unlockfps_nc.Service.ProcessService+<UpdateRemoteModules>d__22.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Boolean, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[unlockfps_nc.Service.ProcessService+<UpdateRemoteModules>d__22, unlockfps_nc, Version=<IP_ADDRESS>,"...
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Boolean, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[unlockfps_nc.Service.ProcessService+<UpdateRemoteModules>d__22, unlockfps_nc, Version=<IP_ADDRESS>,"...
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Boolean, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[unlockfps_nc.Service.ProcessService+<UpdateRemoteModules>d__22, unlockfps_nc, Version=<IP_ADDRESS>,"...
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(System.Runtime.CompilerServices.IAsyncStateMachineBox, Boolean)
   at System.Threading.Tasks.Task.RunContinuations(System.Object)
   at System.Threading.Tasks.Task.TrySetResult()
   at System.Threading.Tasks.Task+DelayPromise.CompleteTimedOut()
   at System.Threading.TimerQueueTimer.Fire(Boolean)
   at System.Threading.TimerQueue.FireNextTimers()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool+WorkerThread.WorkerThreadStart()

For reference, I installed the game using Heroic Games Launcher, and the game is running using proton-ge

Just wanted to mention this happens on Windows too and it disables the 120fps change from working. You never know how good you have it until it's taken away from you! I hope it turns out to be an "easy" fix.
Thanks again @34736384 for the continued hard work!

Since the newest Genshin update, the program is also not working for me (Windows 11). My error code is different though.
"ReadProcessMemory failed with code :299 Only a part of a ReadProcessMemory or WriteProcessMemory request was completed"
Hopefully @34736384 can manage to find a workaround. I remember reading in recent Genshin dev updates that they would be making changes that specifically made it harder for third party tools to work. I guess this is what they were referring to.
Game feels absolutely unplayable for me at 60FPS after being used to 165FPS. Crazy that Hoyoverse have not natively / officially enabled this feature in 2024 (and are instead actively working to disable third party support).

Since the newest Genshin update, the program is also not working for me (Windows 11). My error code is different though.
"ReadProcessMemory failed with code :299 Only a part of a ReadProcessMemory or WriteProcessMemory request was completed"
Hopefully @34736384 can manage to find a workaround. I remember reading in recent Genshin dev updates that they would be making changes that specifically made it harder for third party tools to work. I guess this is what they were referring to.
Game feels absolutely unplayable for me at 60FPS after being used to 165FPS. Crazy that Hoyoverse have not natively / officially enabled this feature in 2024 (and are instead actively working to disable third party support).

Your issue is different from OP's, the latest version doesn't event have that error string

When using the program (versions 3.0.4 and 3.0.3) on Linux with the game version 4.7, the game launches but the fps cap is not modified (stuck with in-game setting). Before 4.7 it was working fine and I haven't updated anything else except the game, so that latest update must be the cause of the problem (or maybe it revealed a bug in wine/Linux that wasn't a problem in the other versions).
It seems that unlockfps_nc.exe gets an exception when it tries to modify the memory to change max fps. Setting the env variable WINEDEBUG=+seh on the command line shows this exception:
Application: unlockfps_nc.exe
CoreCLR Version: <IP_ADDRESS>11
.NET Version: 8.0.2
Description: The process was terminated due to an unhandled exception.
Exception Info: System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
Stack:
   at unlockfps_nc.Utility.ProcessUtils.PatternScan(IntPtr, System.String)
   at unlockfps_nc.Service.ProcessService.SetupData()
   at unlockfps_nc.Service.ProcessService+<Worker>d__18.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Threading.Tasks.VoidTaskResult, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[unlockfps_nc.Service.ProcessService+<Worker>d__18, unlockfps_nc, Versio"...
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Threading.Tasks.VoidTaskResult, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[unlockfps_nc.Service.ProcessService+<Worker>d__18, unlockfps_nc, Versio"...
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Threading.Tasks.VoidTaskResult, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[unlockfps_nc.Service.ProcessService+<Worker>d__18, unlockfps_nc, Versio"...
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(System.Runtime.CompilerServices.IAsyncStateMachineBox, Boolean)
   at System.Threading.Tasks.Task.RunContinuations(System.Object)
   at System.Threading.Tasks.Task`1[[System.Boolean, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].TrySetResult(Boolean)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.Boolean, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].SetExistingTaskResult(System.Threading.Tasks.Task`1<Boolean>, Boolean)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[[System.Boolean, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].SetResult(Boolean)
   at unlockfps_nc.Service.ProcessService+<UpdateRemoteModules>d__22.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Boolean, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[unlockfps_nc.Service.ProcessService+<UpdateRemoteModules>d__22, unlockfps_nc, Version=<IP_ADDRESS>,"...
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Boolean, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[unlockfps_nc.Service.ProcessService+<UpdateRemoteModules>d__22, unlockfps_nc, Version=<IP_ADDRESS>,"...
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Boolean, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[unlockfps_nc.Service.ProcessService+<UpdateRemoteModules>d__22, unlockfps_nc, Version=<IP_ADDRESS>,"...
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(System.Runtime.CompilerServices.IAsyncStateMachineBox, Boolean)
   at System.Threading.Tasks.Task.RunContinuations(System.Object)
   at System.Threading.Tasks.Task.TrySetResult()
   at System.Threading.Tasks.Task+DelayPromise.CompleteTimedOut()
   at System.Threading.TimerQueueTimer.Fire(Boolean)
   at System.Threading.TimerQueue.FireNextTimers()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool+WorkerThread.WorkerThreadStart()

For reference, I installed the game using Heroic Games Launcher, and the game is running using proton-ge

will fix

what is the unlocker running on? wine? it seems like an issue of LoadLibraryEx not working properly

what is the unlocker running on? wine? it seems like an issue of LoadLibraryEx not working properly

wine, or rather proton, which is wine with some extra components.
i'm encountering the same issue and I simply use "Proton Experimental" from steam and launch it from the command line.

Since the newest Genshin update, the program is also not working for me (Windows 11). My error code is different though.
"ReadProcessMemory failed with code :299 Only a part of a ReadProcessMemory or WriteProcessMemory request was completed"
Hopefully @34736384 can manage to find a workaround. I remember reading in recent Genshin dev updates that they would be making changes that specifically made it harder for third party tools to work. I guess this is what they were referring to.
Game feels absolutely unplayable for me at 60FPS after being used to 165FPS. Crazy that Hoyoverse have not natively / officially enabled this feature in 2024 (and are instead actively working to disable third party support).

Same here, I also get the code 299 error

I'm on windows 11 pc, only thing that changed was this genshin update

what is the unlocker running on? wine? it seems like an issue of LoadLibraryEx not working properly

wine, or rather proton, which is wine with some extra components.
i'm encountering the same issue and I simply use "Proton Experimental" from steam and launch it from the command line.

Can I contact you privately? I do not have the necessary resources to set up a wine environment

@GodfreyZ You have to update to the latest release. Next time you should take a look at recently closed issues, that problem was already resolved there.

what is the unlocker running on? wine? it seems like an issue of LoadLibraryEx not working properly

wine, or rather proton, which is wine with some extra components.
i'm encountering the same issue and I simply use "Proton Experimental" from steam and launch it from the command line.

Can I contact you privately? I do not have the necessary resources to set up a wine environment

This is how I installed the game:

Install Heroic Games Launcher (since I use Arch I installed it from the AUR).
From Heroic, login with an Epic Games account and download Genshin (you have to get the game from the store for it to appear in your library).
When installing, under "show wine settings", select the wine version you want (I personally use proton-ge-custom-bin, but you can also install proton 9.0 or proton experimental from steam). I tried using wine 9.10, but it wasn't able to launch the game.
Once Heroic has downloaded the launcher, you should be able to just install the game normally. You should disable "Use Steam Runtime" in Heroic ("Other" tab in the game's settings) with the default installation path, because the game will think that there is no space available (once fully installed, "Use Steam Runtime" made no difference for running the game).
Last step is to set "Select an alternative EXE to run" under "Advanced" settings tab to the path of unlockfps_nc.exe. Next time you launch the game, you will get a prompt to install dotnet 8. Once downloaded, use "Run EXE on prefix" at the bottom of the "Wine" settings tab, and after that you should be good to go.

Alternatively, you can manually download the installer and add it in Steam as a non-steam game, then choose proton as a compatibility layer in the properties, or you could also use lutris. I am a bit less familiar with these solutions, but they should work as well as Heroic.

@Remi4001 I try this in lutris with the proton GE 9.6 version, and the fps are still in 60. Even if the unlocker is working

@Remi4001 I try this in lutris with the proton GE 9.6 version, and the fps are still in 60. Even if the unlocker is working

That's the issue; the unlocker is not working correctly. It launches the game and crashes right after, before setting the new fps cap. Before 4.7, the unlocker would stay open in the system tray

but now the icon disappears after lauching the game.

The old version i was usinggive the code 299 message.
I downloaded the march release (newest one) and it works... under windows 10. on linux, it whines that it needs dotnet framework 8, and that particular package is broken in proton. i'm assuming that basically moving to dotnet 8 stranded all linux users out of the unlocker :(

@GraveUypo dotnet 8 needs wine 9.x (see https://github.com/34736384/genshin-fps-unlock/issues/353#issuecomment-2040545824). For me the dotnet 8 version was working fine until genshin 4.7.

@GraveUypo dotnet 8 needs wine 9.x (see #353 (comment)). For me the dotnet 8 version was working fine until genshin 4.7.

that did the trick, it works now. phew. game opens, and it's unlocked. via lutris.
Thanks.
had a little scare (probably the mobile UI thing in hindsight) since my keyboard and mouse were weird but i fixed that by deleting all config files

Tested on Ubuntu live with wine 9.0 and I can confirm that it is indeed an issue with LoadLibraryEx not mapping the entire image as read-only

net8.0-windows.zip Here is a test build, could you please test it and let me know if it resolves the issue

Works great for me, thanks!

net8.0-windows.zip Here is a test build, could you please test it and let me know if it resolves the issue

Works great for me, thanks!

Thank you, I will make a release build soon

It works here too. Sorry for my useless feedback earlier, and thanks for this.

There are not still a build yet? We cannot compile since WPF and WinForms are not in linux.

https://github.com/34736384/genshin-fps-unlock/releases/tag/v3.2.0


fix error on ingress or service name not specified

What does this PR do?
Fix template from erroring when name is omited

:shipit:


how change zindex sprites?

Hello! how are you?
how change the zindex of sprites ?
I want it is behind of my icons.

Hi @alenigrelli. Could you share some details about the code? Are you using the same layer?


In the plugin mode of dotnet8, the native related dll files in runtimes cannot be loaded correctly.

Type of issue
Code doesn't work
Description
In the plugin mode of dotnet8, the native related dll files in runtimes cannot be loaded correctly.
When using Microsoft.EntityFrameworkCore.Sqlite in a plug-in, if it is not introduced in the main project. an exception will be throwed.
Unable to load DLL 'e_sqlite3' or one of its dependencies: The specified module could not be found. (0x8007007E)
   at SQLitePCL.SQLite3Provider_e_sqlite3.NativeMethods.sqlite3_libversion_number()
   at SQLitePCL.SQLite3Provider_e_sqlite3.SQLitePCL.ISQLite3Provider.sqlite3_libversion_number()
   at SQLitePCL.raw.SetProvider(ISQLite3Provider imp)
   at SQLitePCL.Batteries_V2.Init()
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

The sample code Url : https://github.com/DevStudy/PluginSample/tree/dev/v1
Page URL
https://learn.microsoft.com/zh-cn/dotnet/core/tutorials/creating-app-with-plugin-support
Content source URL
https://github.com/dotnet/docs/blob/main/docs/core/tutorials/creating-app-with-plugin-support.md
Document Version Independent Id
f25a6e1a-cb10-867b-0522-a377bf9d016b
Article author
@jkoritzinsky
Metadata

ID: 06023407-704f-0ace-e89a-eedd9f95a007
Service: dotnet-fundamentals

Impletment the class AssemblyLoadContext 's method
protected override IntPtr LoadUnmanagedDll(string unmanagedDllName)
{
}
and it's solved


[ISSUE #1699] Fix wrong topic max length in TopicValidator

What is the purpose of the change
Fix wrong topic max length in TopicValidator when broker check topic length
link #1699
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.06%) to 50.584% when pulling d378af77ac4222b13c30e5548f380608c198f09f on RongtongJin:fix_topic_max_length into f7c21db6fc47b5a89f71162e2212be19dd88ecc7 on apache:develop.


Parallax on Firefox Developer Edition

I'm getting this message on Firefox Developer Edition 49.0a2 (2016-06-29)

This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects for further details and to join the discussion on related tools and features!

Any fix?
Thanks!

Almost all parallax effects rely on JS with a scroll handler. I don't see this a problem that needs to be fixed.


Add bison and flex in deps

Dependency added in Velox since https://github.com/facebookincubator/velox/commit/eb79237434026360ba3009e3c56b3b227ef6321c

for macos its not required, for linux yes I can build a image or like here we can add the apt-get install command before building the binary..


unable to press press the checkbox. The html code just shows up instead

i have a simple table

so here the checkbox is created directly by this extension with the snippet
<input type="checkbox" unchecked id="b80aa5">

even tho it renders properly, it is un clickable. when i try to click the box in live preview, it changes to

i am able to check and uncheck the checkbox in readonly mode, but it makes life difficult. hope so one will look into it.

Hi, this is because of live preview mode while editing.
Don't really have time to fix right now, as a workaround it should work as expected in view mode (click the book top right, or hit ctrl+e or ⌘+e)

Hey,
Just take your time to fix this. I will leave this issue open until then so others may see it.
Might be better if u could update the readme. Section - How to use


Improved trigram.

This makes trigram to use only letters and digits as tokens, so that query like "Scared Squirrel" will not match "United States".
It is not the fix, but an improvement.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@7688e2a). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             develop     #560   +/-   ##
==========================================
  Coverage           ?   96.41%
==========================================
  Files              ?      123
  Lines              ?     3631
  Branches           ?      319
==========================================
  Hits               ?     3501
  Misses             ?       90
  Partials           ?       40

Impacted Files
Coverage Δ

datahub/search/elasticsearch.py
95.9% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7688e2a...7e32a21. Read the comment docs.


Wiberg Order Not Found

Hi,
I am having issues running the following simple script:
from fragmenter import fragment, chemi
m= chemi.smiles_to_oemol('OC1(CN(C1)C(=O)C1=C(NC2=C(F)C=C(I)C=C2)C(F)=C(F)C=C1)[C@@H]1CCCCN1')
f = fragment.WBOFragmenter(m)
f.fragment()
f.depict_fragments(fname="example.pdf")
Here is the error I am getting:

Traceback (most recent call last):
File "/Users/emmawu/Downloads/frag_test.py", line 23, in
frag_engine.fragment()
File "/Users/emmawu/anaconda3/lib/python3.6/site-packages/fragmenter/fragment.py", line 874, in fragment
self._get_rotor_wbo()
File "/Users/emmawu/anaconda3/lib/python3.6/site-packages/fragmenter/fragment.py", line 958, in _get_rotor_wbo
self.rotors_wbo[bond] = b.GetData('WibergBondOrder')
File "/Users/emmawu/anaconda3/lib/python3.6/site-packages/openeye/oechem.py", line 11734, in GetData
return _oechem.OEBase_GetData(self, *args)
ValueError: GetData: WibergBondOrder not found.

I get the same error when trying to run the example script. I am not entirely sure what is causing the error. Any feedback is appreciated! Thank you!
Best,
Emma

Hm, it may be something with the breaking changes in the 2020 OpenEye
toolkit. Could you try downgrading to the 2019 OpenEye toolkit? Your script
ran for me in the old version.
conda install -c openeye openeye-toolkits=2020
If you've already downgraded and it's still breaking, could you post the
output of conda list so we can see what else might be happening?
On Wed, Sep 30, 2020 at 8:03 PM ewu20<EMAIL_ADDRESS>wrote:

Hi,
I am having issues running the following simple script:
`from fragmenter import fragment, chemi
m =
chemi.smiles_to_oemol('OC1(CN(C1)C(=O)C1=C(NC2=C(F)C=C(I)C=C2)C(F)=C(F)C=C1)[C@
@h https://github.com/h]1CCCCN1')
f = fragment.WBOFragmenter(m)
f.fragment()
f.depict_fragments(fname="example.pdf")`
Here is the error I am getting:
Traceback (most recent call last):
File "/Users/emmawu/Downloads/frag_test.py", line 23, in
frag_engine.fragment()
File
"/Users/emmawu/anaconda3/lib/python3.6/site-packages/fragmenter/fragment.py",
line 874, in fragment
self._get_rotor_wbo()
File
"/Users/emmawu/anaconda3/lib/python3.6/site-packages/fragmenter/fragment.py",
line 958, in _get_rotor_wbo
self.rotors_wbo[bond] = b.GetData('WibergBondOrder')
File
"/Users/emmawu/anaconda3/lib/python3.6/site-packages/openeye/oechem.py",
line 11734, in GetData
return _oechem.OEBase_GetData(self, *args)
ValueError: GetData: WibergBondOrder not found.
I get the same error when trying to run the example script. I am not
entirely sure what is causing the error. Any feedback is appreciated! Thank
you!
Best,
Emma
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openforcefield/fragmenter/issues/65, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD4STV2VZRVM2E3SASKAF63SIPWQ5ANCNFSM4R73AEAQ
.

Thank you @j-wags ! Downgrading to the 2019 version of Openeye worked for me!


xfail array and map cast to string tests

Related to #11436 and #11437.  Marked the failing tests as xfail or ignore to unblock premerge and nightly builds.

build

CI is failing due to #11436

build

build


network services does not building VRF and iBGP peering in overlay if neighbor has services defined

Issue Summary
For mlag pairs,  if side A has services defined (ex: l3 interface) but side B does not.  AVD will not build VRF definition and iBGP peering in the overlay on side B node.  eos_designs should automatically build that to improve resiliency for single attached services.
Workaround: use node_type.filter.always_include_vrfs_in_tenants
Which component(s) of AVD impacted
eos_designs
How do you run AVD ?
Ansible AWX
Steps to reproduce
-define a mlag pair in node_type
-define a tenant with a l3_interface on side A of the mlag pair.
-> switch A config will include iBGP peering with side B but Side B will not have the VRF or iBGP peering

Relevant log output
No response
Contributing Guide

[X] I agree to follow this project's Code of Conduct

cross-posting the closing message of #4530
TL;DR: The penalty hit of 70 to 80% in the fact phase just to solve the corner case is not worth it. Use the workaround described in the issue.
So after careful consideration we have decided with @ClausHolbechArista to close this PR and deem it not feasible at the time with the existing code structure.
To be able to know which VRFs are in my MLAG peer I need to compute the filtered_tenants in the fact phase which is taking a lot of extra time. We have observed a 70-80% time penalty during the fact phase on the repo which is not something that we think is a good solution to impose on every AVD users for such a corner case.
I will remove the issue from AVD 5.0 milestone and we will take another stab at it later once the code structure has changed.


Bug: Error EPERM when merge

Describe the bug
When create a project, and merge with a dir that have .git, it will throw an error when Project setup: Read xxx
errno: -4048,
syscall: 'open',
code: 'EPERM',
Screenshots

Version
On version v2.4.2

This bug has been fixed in 3582d5a6fdebd816c6eb777043d22cc53d76f8a8
It will be fix at release v2.4.3


Error setting device message

stationary  : WARNING  : unable to change position: Error Setting Device: Header value 342 must be of type str or bytes, not type 'int'
I keep getting those messages, maybe some change in API again. Will try to look into this issue soonish...

@springjools this is a change in requests 2.11.0. You simply need to convert your Content-Length headers that are currently ints to strings.

Fixed by commit 91849ac64b4bbe59e7a2916c3b6ab2849dd46a2b. Thanks Jools !


Update index.html

The design is fully responsive with no conflicts anywhere. I've shared the link, so you can check it yourself. Additionally, all screenshots and videos are working perfectly.
https://github.com/user-attachments/assets/1a0704d3-ea78-4ba6-a153-aa0cfbf8c589
https://github.com/user-attachments/assets/7e957b9d-cee6-4415-8c7d-a54cba7bde12

Now check

issue number?

#419

@Ek-ta-bharti , you did not create an issue , you did not follow issue guidelines , you did not follow PR guidelines , hence we are closing both your PR's , kindly follow the correct steps from next time !

you do not have any open issue as of now


Client reply off

Hey,
Its possible to tell Redis to not reply to commands of a certain client by using the client reply off command (http://redis.io/commands/client-reply).
I wonder how will the library behave in this situation, considering its possibly waiting for a response from the server for each request.

It's indeed a interesting command...To support it, maybe we can add a flag to the Redis#condition variable to indicate the status of client reply. If the status is not ON, then we just don't add the command to the command queue.

Hello. Can ioredis be used when setting client reply off ?


Enabled haas.cfg to parse camelCase names for classes.

Please merge this asap so that I can make changes that depends on this.

+1

Could you please update the description for why we need to support camelCase?
Thanks!

+1, merging


Remove vendor-patches from packages/ as moving

see https://github.com/symplify/vendor-patches/pull/3

@TomasVotruba pending workflow for vendor-patches split and rector check seems can be removed from required workflow on CI

@samsonasik Done :heavy_check_mark:

Thank you. All checks have passed :tada:  @TomasVotruba it is ready for review.

Looks good :+1: Thanks


Flutter support

@simolus3 did an awesome job laying the foundations for a drop in replacement I think, see prior art: sqlite3.dart

Instead of using the sqlite3 library from the OS, you can also ship a custom sqlite3 library along with your app. You can override the way this package looks for sqlite3 to instead use your custom library. For instance, if you release your own sqlite3.so next to your application

Looks possible via dart:ffi C-bindings / DynamicLibrary
Or even via wasm route, supplying replacement for sqlite3.wasm for broader Flutter platform support
Reference


Timeout with acquireTokenSilent in Microsoft Edge Chromium

Please follow the issue template below. Failure to do so will result in a delay in answering your question.

Library

[x]<EMAIL_ADDRESS>
Framework
Angular 9 Working directly with the msal.js 1.2.2 library
Description
Getting a timeout error when trying to get acquireTokenSilent in  Microsoft Edge Chromium Version 84.0.522.59 when calling Azure B2C Tenant.
Error Message
URL navigated to is https://{B2CTenant}.b2clogin.com/{B2CTenant}.onmicrosoft.com/b2c_1a_gs1us_ac_signin_v1/oauth2/v2.0/authorize?response_type=token&scope=https%3A%2F%{B2CTenant}.onmicrosoft.com%2Fusermgmtapilocal%2Fcompany.read%20https%3A%2F%{B2CTenant}.onmicrosoft.com%2Fusermgmtapilocal%2Fdemo.read%20openid%20profile&client_id={clientID}&redirect_uri=https%3A%2F%2Flocalhost%3A6420&state=8a6bcf44-8023-4fca-b72d-312052d88bad&nonce=a655090e-5100-437f-af05-9e7c3baf7200&client_info=1&x-client-SKU=MSAL.JS&x-client-Ver=1.2.2&login_req=0f9619f0-b980-4708-82e8-e6c964c869b0-b2c_1a_gs1us_ac_signin_v1&domain_req=a136b191-4415-4ed5-bf91-d7c94247cfcd&domain_hint=organizations&CompanyId=99999999&client-request-id=c0463f93-c938-43c5-848c-96a3708da3fc&prompt=none&response_mode=fragment, Token renewal operation failed due to timeout.
Security

[X ] Is this issue security related? Yes, trying to acquire token for calling Web API

Regression

[X ] Did this behavior work before? Yes, this worked in msal 1.0.2. version. msal 1.2.2 successfully works with Chrome.

Reproduction steps
After redirecting back from the Azure B2C Login screen. Trying to acquire token to call Azure B2C Secured (Scoped) ASP.NET Web API.
Expected behavior
Calling acquireTokenSilent  works successfully in Edge Chromium.
Browsers/Environment

[X] Edge

Hey, @toddfsnyder! Timeouts can happen for many reasons. Are there any other errors in the browser console? Also, are you using hash routing in Angular? Is this issue consistently reproducible, or is it intermittent? And finally, does this only happen with Edge Chromium, or is it reproducible in other browsers as well? Thanks!

Chrome and Firefox both work fine. We are only seeing this issue in Edge Chromium. Below are the other warnings/errors we are getting. The issue happens every time, sometimes if we refresh the browser the application will load.
SameSite Cookie Warnings:
A cookie associated with a cross-site resource at http://b2clogin.com/ was set without the SameSite attribute. A future release of Microsoft Edge will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.
search:1 A cookie associated with a cross-site resource at http://{B2CTenant}.b2clogin.com/ was set without the SameSite attribute. A future release of Microsoft Edge will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.
Other Error
authentication.service.ts:429 acquireTokenSilent: error: ClientAuthError: Token calls are blocked in hidden iframes
A cookie associated with a cross-site resource at http://b2clogin.com/ was set without the SameSite attribute. A future release of Microsoft Edge will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.
search:1 A cookie associated with a cross-site resource at http://{B2CTenant}.b2clogin.com/ was set without the SameSite attribute. A future release of Microsoft Edge will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.
authentication.service.ts:429 acquireTokenSilent: error: ClientAuthError: Token calls are blocked in hidden iframes

Hi @toddfsnyder.

ClientAuthError: Token calls are blocked in hidden iframes

This error happens when the page that you use for the redirect_uri for acquireTokenSilent itself calls acquireTokenSilent on page load.
I noticed you are using your homepage as your redirect_uri, which means your homepage will load in the hidden iframe, which may be causing the timeouts. For acquireTokenSilent calls, you can use a blank html page as your redirect_uri, which will remove the ClientAuthError and may fix the timeouts.
Could you please try that and let us know if it works for you?


Deprecate recognizing Boolean isFoo() as a property

Groovy 4 no longer recognizes these methods as properties.
You need to use either:

boolean isFoo()
Boolean getFoo()

@bot-gradle test QF

I've triggered the following builds for you:

QuickFeedback build

@bot-gradle test QF

I've triggered the following builds for you:

QuickFeedback build

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build


Chore: replace spectron with playwright

Related: https://github.com/electron-userland/spectron/issues/1045
The primary goal of this PR is to unblock our electron upgrade PR #4232 which is blocked by spectron flaking out on windows and blocking future upgrades due to its deprecation.
Improvements

less flake in the playwright attaching to window mechanism
runs twice as fast
fails fast when missing build artifact

Scoped out

screenshot/tracing on fail
test writing guidance
retry logic
videos

Notes:

windows doesn't start properly so theres a forced reload in the test setup, this should be investigated separately
locking to single instance doesn't work in playwright, this should be investigated separately
users who may have been using the undocumented env var INSOMNIA_DATA_PATH may get logged out because of the setPath fallback used for controlling migration context. something we tried that we don't seem to need now

Considered in this scope

[x] docs, designed initially to be operated as spectron was
[x] screenshot/video on fail, going to delay into a PR that adds the more powerful tracing support
[x] locking issue, going to delay into an investigation
[x] test setup fixtures, going to delay into the tracing PR above
[x] better insomnia request collection fixture, not required
[x] decide on playwright config, defaults are okay for now
[x] decide if this PR should include code re-use abstraction, not yet

Closes INS-1300
Closes INS-1147

Thank you for your thoughts and concerns I hear you and hope to address them to your satisfaction.

I know you've chosen to descope writing utilities/page objects from this PR. In theory that's fine, it's a work in progress, but we're deleting a lot of valuable code and if we slightly alter the approach we can take a step up from Spectron instead of start from scratch. Note that what we are changing is the test framework, and from what I've seen in this PR that doesn't need to involve writing things from scratch.

Playwright and Spectron are not a 1:1 API match, there are new playwright specific conventions to learn and adapt, and it is unwise to learn and adapt to them as one contributor in a single PR.

The existing page object approach of writing an e2e test is agnostic of the framework being used. If you look at the overall functions - click a request, click send, click a tab, open a dropdown - and how they are parameterized, they describe user actions, and the implementation describes how the test framework should handle those user actions.

The reason this code uses playwright recordings for its runs are to separate any of my personal opinions about test structuring from the replacement effort, while creating an opportunity to revisit existing conventions, I agree the modules were very useful in making readable spectron tests possible, and we will certainly want to pull in some of the ideas with playwright. However I strongly believe the introduction of abstractions over test structure should happen carefully as these tests have a huge impact on the contribution experience, so we have a duty to keep them as lean and fast as possible to maximise return on investment.

We've changed our test framework from Spectron to Playwright. Updating the page object implementations to work with Playwright's API will allow us to keep the existing tests (which are much more readable than the what I'm reviewing in this PR) and continue from there.

Readability is subjective and not something I aim to improve in this PR, only to provide us with a starting point to build confidence in our e2e testing.

I have a strong opinion that it is not necessary to delete all of the existing tests and page objects and start again. This is feedback about the overall approach, please don't take it as a request to increase the scope of this PR. How can we help ourselves build on top of what's already written, instead of writing from scratch?

We can build on top by writing new tests ourselves on top of this minimal safety net, to show the value of required abstractions.
My goal is to eliminate barriers to contribution, to me this means making it intuitive, easy to change and with as little indirection as possible.


yo rn-toolbox:assets command hangs

$ yo rn-toolbox:assets --splash ./icons/4648x4648.png --ios
? Name of your react-native project MyProject
Wrote<EMAIL_ADDRESS>Wrote<EMAIL_ADDRESS>Wrote<EMAIL_ADDRESS>Wrote ./ios/MyProject/Images.xcassets/LaunchImage.launchimage/Default-Portrait.png
Wrote ./ios/MyProject/Images.xcassets/LaunchImage.launchimage/Default-Landscape.png
Wrote<EMAIL_ADDRESS>Wrote<EMAIL_ADDRESS>Wrote<EMAIL_ADDRESS>Wrote<EMAIL_ADDRESS>Wrote<EMAIL_ADDRESS>Wrote<EMAIL_ADDRESS>identical ios/MyProject/Images.xcassets/LaunchImage.launchimage/Contents.json
 conflict ios/MyProject.xcodeproj/project.pbxproj
? Overwrite ios/MyProject.xcodeproj/project.pbxproj? (ynaxdH)

and i can't type y,n,x ... or anything to finish it, seem i can't say YES for the overwrite ...question
macOS mojave 10.14.4
$ node -v
v10.15.3
$ npm show yo version
2.0.6
$ npm show generator-rn-toolbox version
3.11.1
$ gem list | grep 'bundler'
bundler (2.0.2)

--force i just found out this param, it helps me get over this for now
yo rn-toolbox:assets --splash ./icons/4648x4648.png --ios --force

Hello, we just revamped the generator 😁
For up to date icon and splashscreen generation please use @bam.tech/react-native-make
The new version is Yeoman free and uses the standard React-Native cli plugin architecture so it should solve your issue 😉


Cannot access published endpoint in the local environment

Steps to reproduce

Install Walrus: docker run -d -p 80:80 -p 443:443 -p 30000-30100:30000-30100 --privileged sealio/walrus:v0.5.0-rc1
Create a containerservice with nginx image, 80:80 port
Wait until the deployment succeeds and access the endpoint.

Result
The endpoint is inaccessible.
Environment

Walrus version: v0.5.0-rc1

Additional context
It's using the internal IP of the walrus server container. It works when changing the IP to the Walrus server address.

Environment

Walrus version: main 9a4516ef8771ed0bdce4acb990f084aa4e9a2a11
UI version: dev-88faa21

Test Result: pass


lolbins detection from sigmahq

This PR contains scenarios from sigmahq for lolbins detection on windows.
Scenario are automatically generated from the WIP sigma pipeline : https://github.com/buixor/pySigma-backend-crowdsec

tested on upsttream 1.5.2 and it works (ping @AlteredCoder )


Bug/84 make zip content top level

Fixes #84

LGTM. Only contents of dist folder are placed inside zip


Go 1.23 build and analyze failure in 2.18.3

We were utilizing the default init action that downloads the latest bundle available, once 2.18.3 was released our autobuild and analyze steps starting failing with the following error:
2024/09/04 14:10:55 internal error: error "package requires newer Go version go1.23" (*errors.errorString) without position
  2024/09/04 14:10:55 internal error: error "package requires newer Go version go1.23" (*errors.errorString) without position
  2024/09/04 14:10:59 internal error: package "entgo.io/ent/entc/gen" without types was imported from "entgo.io/contrib/entproto"
  2024/09/04 14:10:59 Extraction failed for .: exit status 1
  2024/09/04 14:10:59 Extraction failed for all discovered Go projects.
  Error: We were unable to automatically build your code. Please replace the call to the autobuild action with your custom build steps. Encountered a fatal error while running "/opt/hostedtoolcache/CodeQL/2.18.3/x64/codeql/go/tools/autobuild.sh".  See the logs for more details.

We do install the correct version of Go using GitHub actions and that does not seem to overwrite the version this is using. When we pin ourselves back to 2.18.2 in the init step everything works as expected.

Hi @coryjohnson-flume 👋🏻
We don't officially support Go 1.23 with CodeQL at the minute, although we expect to ship changes in the next CodeQL release (anticipated for next week) to support Go 1.23.
We updated golang.org/x/tools from v0.23.0 to v0.24.0 in CodeQL 2.18.3. The error you are getting seems to be related to trying to build a project that specifies a version of Go greater than the version of the Go libraries that (in this case) our CodeQL integration for Go was built with.
My main suggestion for you would be to wait until the new CodeQL version is out (likely the end of next week) since I would then expect this error to disappear again.
If this error occurs in a public repo, it would also be useful for us if you could link to it.

Here's one @mbg help that's helpful.

Hi @brettcurtis, thanks for that link. I can see that there are some non-critical errors in that workflow run related to Go 1.23, but generally nothing overly problematic that stops the run from succeeding overall. I have confirmed that there are no errors at all with the changes that we expect to ship in this week's CodeQL release though.

We encountered this issue in an update to go1.22.6 today, in 2.18.4. (Run.) Sorry, I had a brief look and couldn't find a release schedule for the repo, so I'm not sure if this is still just waiting for the next release.

Hi @dagood 👋🏻
I am afraid that I am not sure I see how your issue and the run you linked to relate to Go 1.23. We shipped Go 1.23 support in CodeQL 2.18.4 and would expect projects which use the Go 1.23.x toolchain to work now.
The log you linked to seems to show only a generic error that CodeQL found Go code, but did not extract any of it. Since your actual build step seems to be successful in that run and I can see that your CodeQL workflow does generally work aside from for that PR, I'd suggest the following:

Re-run the CodeQL workflow with debugging enabled
Open a new issue for this over in the https://github.com/github/codeql repository

I will go ahead and close this issue, since I believe the Go 1.23 issues are resolved with the release of CodeQL 2.18.4.


Make sure plugin is not initialized twice, e.g. in case of server restart

hapi-swagger throws an error (i.e. Cannot set views manager more than once) when restarting the hapi server in the same process (see example below).
const server = new Hapi.Server();
server.register([
  inert,
  vision,
  {
    register: HapiSwagger,
    options: {
      enableDocumentation: true,
      // other options
    }
  }
]).then(() => {
  return server.start();
}).then(() => {
  return server.stop();
}).then(() => {
  return server.start();
}).catch((err) => {
  console.error(err); // outputs "Cannot set views manager more than once"
});

This is not as extreme use case as you might think. I am starting and stopping the hapi server multiple times during integration tests.
In any case, this functionality is supported by hapi, so I figured hapi-swagger should support it as well.
Cheers,

Coverage decreased (-0.1%) to 99.876% when pulling a663faf879394b4c6e1a24816a4fb68ff0cef1ad on visionmobile:master into 4fdd0c90af028811c7bb3b71b75ff4777310543f on glennjones:master.

Hi, thanks for this PR its now in v6.0.0 on NPM


initial code for Portworx

Closing this PR, as we raised following PR to repo called terraform-ibm-cluster-storage to capture portworx functionalities
https://github.com/terraform-ibm-modules/terraform-ibm-cluster-storage/pull/1