Fixed typescript definition file.

The structure of the typescript definition file was not properly exposing the global ifvisible object. I rearranged the exports and added a declare statement to properly export ifvisible.

@mikesigs Thanks for this. I'm porting the library to Typescript at the moment https://github.com/serkanyersen/ifvisible.js/blob/typescript-port/ifvisible.ts
So hopefully autocomplete in ts will be much more reliable soon.
Thanks

The changes weren't so much about better autocomplete, so much as allowing my solution to compile.


feat: add flag '--no_sum_check' to support no kcl.mod.lock generation

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

add flag --no_sum_check to avoid the generation of 'kcl.mod.lock'

2. What is the scope of this PR (e.g. component or file name):

kpm add/kpm run/kpm update
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[x] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[x] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

35 of 73 (47.95%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.5%) to 38.804%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/api/kpm_run.go
2
3
66.67%

pkg/client/client.go
33
35
94.29%

pkg/package/package.go
0
5
0.0%

pkg/opt/opt.go
0
6
0.0%

pkg/cmd/cmd_run.go
0
7
0.0%

pkg/cmd/cmd_add.go
0
8
0.0%

pkg/cmd/cmd_update.go
0
9
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
2.5%

Covered Lines:
1421

Relevant Lines:
3662

💛  - Coveralls


Converting paragraph by pattern matching is not working on mobile

On desktop if the user type any of the following patterns followed by a space in the paragraph node, then SuperEditor will convert the node type:

* (unordered list)
1. (ordered list)
--- (horizontal rule)

On mobile, the same patterns do not trigger the node conversion.

Cc @matthew-carroll


add varbase.estimate_achievable_tmid_precision

links to periodbase.get_snr_of_dip, and is a useful sanity check that
whatever parameters you are getting from your lightcurve fitting
actually make sense.
it's here, and not in periodbase.__init__ because it relates more to
lightcurve fitting than periodograms.

Thanks!
I think it would be useful to set up a varbase/transits.py module for this to go in along with other stuff you might want to put in there, instead of putting it into the top level module. You can copy over the modtemplate.py from here: https://github.com/waqasbhatti/astrobase/blob/master/astrobase/modtemplate.py.

Good idea! Done.

Merged. Thanks again!


Optimize CatalogRecycleBin query table with same name

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] others

Which issues of this PR fixes ：

Fixes #3585
Problem Summary(Required) ：

Reconstruct CatalogRecycleBin into triple DbId, TableId, Info.


[WIP] delete notifications to not return result

Coverage decreased (-0.6%) to 87.797% when pulling 66fe1702deb887552b1cf4e1d0e615dc49601f1b on notifications-returning into 3ffbbd2027336f89adb027b587dfec6062066307 on master.


"disable transparent hugepage" task actually do nothing

To configure kernel the task is using "command" module which is not respect operator ">". So this task just print to "stdout": "never > /sys/kernel/mm/transparent_hugepage/enabled"
To really change kernel config you have to use module "shell"

Thanks!


PAINT_035 Testcase for FillBucket fail when all testcases get tested

When all testcases get tested, the fillbucket test cases fail due to a changed canvas.
When tested alone, all fill bucket tests work without any problems at all.
Suggesting: Implementing a general "clean canvas" for all testcases which resets the canvas each time so we can use a clean canvas every time we have to test it.

fixed with #94


 They have been ignored, or old ones used instead.
E: Encountered a section with no Package: header
E: Problem with MergeList /var/lib/apt/lists/ports.ubuntu.com_dists_xenial-backports_main_binary-armhf_Packages
E: The package lists or status file could not be parsed or opened.

Looks like this error occurs within the install script of PocketSphinx.
Would you please provide which step you were at? Make sure the update/upgrade steps went fine.

@dlsagayaraj
Please provide details or I'll close the issue
Merci de fournir plus d'information ou je fermerai ce ticket

Vu qu'il n'y a pas eu d'activité de @dlsagayaraj sur le post depuis 18 jours je prends la liberté de fermer ce ticket.


Patch TitleBar to be correctly displayed on Windows 10X Preview

Fixes #1077
Description of the changes:

Force the visibility (visible) and the height (32px) of the Titlebar when running on Windows 10X
Update MaxVersionTested to get access to the real DeviceFamily

How changes were validated:

Tested with 10X Emulators

Merged with #1027


Replace tailwindcss with windicss?

Since it's a better / faster compiler that produces the same result, but has even a few more features.
I've been trying to do it in my fork of this template, but I can't completely do away with postcss, since I also use it for things like postcssNested. And right now I can't get both to work. I wonder if you'd know a way to include both and if you think it's worth it to migrate this template to windicss.

Sapper's lifespan is too short for me to be interested.

Okay :-)

Wrote more in #28


Next steps for deploying every passing build

Coverage remained the same at 99.815% when pulling dc1a85d70e449cfe6e329419635039d5a1255bdf on basvodde:master into 80ddf905f18bc53b673c3743cdf870ccd13fa16e on cpputest:master.


Bump version to 1.0.12

I don't think this needs to be a pull request, since we don't need to merge the commit into master.  You can bump the version to 1.0.12 in the release branch and not merge the change.  Then update the code version to 1.0.13pre1 and release versions in README.md to 1.0.12 in a separate commit, which is merged to the master branch.


Illegal access error

on my minecraft 1.7.10, whenever I use the morph mod it crashes and says illegal access error and some other gibberish. I have the latest version of forge and every other mod works. BTWS im on a mac.

#65, read my edit on the OP


How to reflect the consumption gap between SNN and CNN

What parameters are provided to compare the difference in energy consumption between the two, such as the amount of computation?

Instead of opening a new issue, please use the converted discussion thread:
https://github.com/jeshraghian/snntorch/discussions/92


clickable filenames

if the filenames of error sources had spaces around where they're shown in the square brackets, they'd be clickable in various smart terminals.
current
Error: Token Tree Building
   ╭─[samples/tree_error.txt:1:38]
 1 │example token { tree file } ( words
   │                                     ╰ Expected: ["token_tree", "close_paren"], Found: None

wanted
Error: Token Tree Building
   ╭─[ samples/tree_error.txt:1:38 ]
 1 │example token { tree file } ( words
   │                                     ╰ Expected: ["token_tree", "close_paren"], Found: None

This has now been implemented and will be in the next release.


Qt Wallet type filter problem on restart

This issue is with the current develop branch.
The Type filter dropdown on the Transactions tab are not set correctly after restarting the wallet.
Steps to reproduce:

Open Qt wallet.
Go to Transactions tab and filter using the Type dropdown (e.g., Sent To or Received With).
Close the wallet.
Open the wallet and view transactions.
The Type dropdown will show "All" but it will still be filtering on the value used.

I do not see this issue with the Date dropdown (e.g., Last Week) or the text filters.

I can duplicate this with a many input wallet but not with a sub 50k tx wallet.

My 7K tx wallet has this problem.  I haven't tried larger wallets.


Adding VBA examples for worksheets

Using the existing HelloWorldVBA.ps example, I modified it to:

Add some VBA code to a specific worksheet: `AddWorksheetVBA.ps1
Add a VBA module with some code, then call that code in ALL worksheets in a workbook: AddModuleMultipleWorksheetVBA.ps1

In both cases the VBA highlights the selected row and column in a cross hair style.
VBA sourced from: https://docs.microsoft.com/en-gb/office/vba/excel/Concepts/Cells-and-Ranges/highlight-the-active-cell-row-or-column
Thanks for this incredibly helpful module.
Hope these examples help,
Craig

Thank you @caosborn for the PR. Looking forward to checking this out.

Thanks for the example and the PR  @caosborn. Good stuff!


Version on pub.dev is 2.2.1 instead of 2.3.0

As a result, the fix of (https://github.com/pikaju/flutter-maps-launcher/pull/32) is not published, so the plugin is still not compatible with AGP 8.0
Relevant comment: (https://github.com/pikaju/flutter-maps-launcher/pull/32#issuecomment-1985597947)

Yup; while the changelog mentions compatibility with AGP 8.x, downloading the source bundle from the version tab on pub shows that the relevant section is missing in android/build.gradle.
Workaround for now is referencing the package from git:
maps_launcher:
  git:
    url: https://github.com/pikaju/flutter-maps-launcher.git
    ref: master

@pikaju any chance on publishing such version?

Up ?

Any update on this @pikaju ?

any update @pikaju  ?

@pikaju there seems to be a couple of  PRs waiting for this,  namely #45 and #50?

Hey, it seems I may have forgot to publish it or something? However, there should be a new version 3.0.0 now. Please try it out, it should fix a whole lot of issues. Sorry for the wait!


Add a simple replay system

This pull request adds a simple replay system to the engine.
Replays are simply recordings of your finished songs (story mode only) using json files.
If you're in story mode game will save a recording of your game to assets/replays folder for every song you finish.
Game will ignore the recordings if charting mode is enabled or it is not in story mode.
You can press the ALT key in freeplay to gain access to replays for current selected song.
If any replay exists for the current selected song, menu will look like this:

Otherwise:

Also includes some little softcoding for making the replays softcoded as possible, such as centered Alphabet etc.
They are little changes and do not change the engine in any way.

looks neat.
but uh could you maybe make an option for it because some people dont want there uh storage space to get so full.

looks neat. but uh could you maybe make an option for it because some people dont want there uh storage space to get so full.

if you do then ill use it for my psych engine with alot of needed features.

looks neat. but uh could you maybe make an option for it because some people dont want there uh storage space to get so full.

They do not take space at all, though sure.

oh boi

looks neat. but uh could you maybe make an option for it because some people dont want there uh storage space to get so full.

They do not take space at all, though sure.

thanks man

oh boi

not surprised to see you here

Looks cool but I feel like you should improve the menu, it kind of just works but it should also be easy to navigate since the replays are eventually going to take up a lot of space in the menu that will be hard to look through

I'm sorry but replays are absolute ass and 99% useless.
Pretty much any PC nowadays can run a basic screen recorder.

the replay doesn't save 💀

a bit late but you should put a freeplay version (ik he's acc it's dead)


Append bundled dependencies into LICENSE file

This PR is to append license information about dependencies to LICENSE file.
It also update NOTICE file, clearly stating they are binary dependencies.

@mrutkows @houshengbo Please review if you are OK with the LICENSE file format. After this PR gets merged, I will adopt the same format in other repos.

Created a separate issue #879 with all the comments from here, merging this for now.


Investigate integration with Orb

Look into ways to integrate https://github.com/ns1labs/orb to provide advanced cross-regional observability for k8gb

Stale, no demand by community, closing


Publish documentation on upgrading from PG version 11 (OIDS)

What should we add to our content collections?
Creating a documentation page that will list out a query to help customers identify which tables use OIDS currently. Once they have this list, they can then alter the tables and move forward with upgrade.
Spawned from support case: https://aiven.lightning.force.com/lightning/r/Case/5005J00000YfFZwQAN/view
Jira: https://aiven.atlassian.net/browse/SRE-7454
Is this something you would work on yourself?
[x] I plan to open a pull request for this

After further internal discussions, this is no longer required. Will create an internal KB and a separate doc for DO


Attachments not showing up in e-mail

If customer is creating ticket by e-mail and file is attached, it doesnt show up in e-mail.  We handle most of our tickets by e-mail.

Hello! Attachments are still not working. Are they supposed to work? What can be done about this? Can we sponsor you so that you develop the email attachment handling? We cannot have a ticketing system that does not support attachments (and ever worse, just ignores them) as many customers often send attachments.

Hmmmm i have tested attachments and they are working fine for me.  Could you email me the pdf you are testing with and I will try and recreate the problem- scott at helpy.io
Scott

Hey @scott! I sent email you requested.


YouTube track keeps restarting at 3-4 seconds mark

I installed Mopidy, Mopidy-YouTube extension and also configured YouTube API key.  I can search using Mopidy WebClient but when I select and play YouTube Track it starts and restarts at 4 seconds and keeps restarting.

I'm experiencing the same issue, both with and without using the Youtube API key, trying to play from Youtube from the Iris web-ui.
Looking at the websockets, it seems like clicking on a track only triggers status updates, no request is sent to play the track.

Is this still a problem with the current version?

I'll assume this is resolved.


SPLAT-1340: platform-external/fix: correct the status information for 4.14+

Fix platform external documentation considering the 4.14 backport https://github.com/openshift/installer/pull/7581

/assign @elmiko

looks mostly good to me, just a couple minor suggetions

Thanks @elmiko , reviewed!


./inference_usbCam_face.py 0 issue

Hi, when i run ./inference_usbCam_face.py 0, there is a issue as below:
File "./inference_usbCam_face.py", line 108, in <module>     (boxes, scores, classes, num_detections) = tDetector.run(image)   File "./inference_usbCam_face.py", line 73, in run     feed_dict={image_tensor: image_np_expanded})   File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 900, in run     run_metadata_ptr)   File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 1058, in _run     raise RuntimeError('Attempted to use a closed Session.') RuntimeError: Attempted to use a closed Session.
Could you help me to check the issue?

luckly, i have fixed the issue.

Hi @liupanpan ,
Would you please spend a few minutes to share your experience on how did you solved this problem?
With regards!

same issue here... Investigating.


Not working on Windows 10

Your server always fails on Windows 10, on _listener.Start(); in RedHttpServer.cs on Windows 10 with exception System.Net.HttpListenerException: 'Access is denied'
I just curious: have you ever tested your code before publishing?

I have been quite busy with education and haven't been very active on this project for some time, so my reply now is likely meaningless. Your problem is that the server needs admin rights on Windows 10 to listen to the wildcard '*', which it will try to.
I've decided to stop maintaining the .NET Framework version and focus on the .NET Core version, and since this problem is related to the .NET Framework version, I will be closing this ticket. I hope you solved this long ago, and sorry for the (very) late reply.


Fix removed user in offline is not crossed

Details

Fix removed user in offline is not crossed
Fixed Issues

$ https://github.com/Expensify/App/issues/42792
PROPOSAL:
Tests

Create a room
Invite some user
Go offline
Go to member page of the room
Remove a user
Verify that this issue is crossed

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Create a room
Invite some user
Go offline
Go to member page of the room
Remove a user
Verify that this issue is crossed

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/161821005/04e514c5-8de3-4eea-8b9b-7b5178153cc5

Android: mWeb Chrome
https://github.com/Expensify/App/assets/161821005/f05ba12a-f5ba-4d6b-9179-009625145bcc

iOS: Native
https://github.com/Expensify/App/assets/161821005/a3dda175-bd0f-4837-8793-e2d415d9da18

iOS: mWeb Safari
https://github.com/Expensify/App/assets/161821005/d2023fa7-554f-42d8-8098-6174437078cc

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/161821005/1214b0e3-ddec-40f5-90c3-5a98f7736a85

MacOS: Desktop
https://github.com/Expensify/App/assets/161821005/dd47a060-7ae3-48fe-9f9a-f515535b519b

I don't know much about the context here 🤔 am I needed here? 😄

didn't mean to close the PR 🙇

@akinwale Friendly bump.

Thanks for the bump. Missed this as I wasn't assigned. Will get to it today.

@puneetlath Please assign me here so that I can complete the review.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/4160319/00b5b83d-1df1-44bf-aca5-ca6a88bc7301

Android: mWeb Chrome
https://github.com/Expensify/App/assets/4160319/4614e1c5-765e-4dd9-94dc-8b77ffe109fb

iOS: Native
https://github.com/Expensify/App/assets/4160319/d982a6cf-80b4-4867-922e-a3880c47fe2e

iOS: mWeb Safari
https://github.com/Expensify/App/assets/4160319/f73279ec-25c7-46b9-913a-0af6f4a57682

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/4160319/2076399a-433d-4b0b-8850-f61f55ff5547

MacOS: Desktop
https://github.com/Expensify/App/assets/4160319/5667a426-2fb8-4fdd-9c20-59012ebdf803

the member count should not reduce while the user is crossed out. Please fix this.

I think the member count should reduce since it's current behavior of production.
cc @puneetlath Can you please confirm this?

the member count should not reduce while the user is crossed out. Please fix this.

I think the member count should reduce since it's current behavior of production.

@nkdengineer That's the current behaviour because the previous PR (that caused this regression) was merged and deployed. You can test from an earlier release prior to this PR being merged (e.g. 1.4.60-13) to confirm what the behaviour should be.

@akinwale We don't change any thing for the member count in ReportDetailsPage. The logic to calculate the member count is updated in this PR https://github.com/Expensify/App/pull/39796

@akinwale We don't change any thing for the member count in ReportDetailsPage. The logic to calculate the member count is updated in this PR #39796

Ok, makes sense. Everything should be OK then.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


AttributeError: 'module' object has no attribute 'Client'

Hi,
I am running into this issue:
Traceback (most recent call last):
  File "alooma.py", line 1, in <module>
    import alooma
  File "/root/alooma.py", line 6, in <module>
    api = alooma.Client(api_key=API_KEY, hostname=ACCOUNT_NAME)
AttributeError: 'module' object has no attribute 'Client'

This is my python code:
import alooma
API_KEY = "SECRET" # example
ACCOUNT_NAME = "SECRET"

api = alooma.Client(api_key=API_KEY, ACCOUNT_NAME=ACCOUNT_NAME)
INPUT_NAME = 'TestInput'
input_data = api.get_input_by_name(INPUT_NAME)[0]

Tried on both: Python 2.7.16 and Python 3.7.3.
Any idea what might be the root-cause of this issue?
Regards.

try relative import
import .alooma
or go for absolute import
import alooma.alooma

@yassineaboukir I ran into the same issue and figured out it was caused by me naming my script alooma.py, which conflicts with the installed package alooma since that package also  contains a file named alooma.py. The error is caused by Python trying to import your alooma.py as a package, which of course doesn't define any Client method or class.
Renaming the script file to literally anything else resolved the issue for me.


Hooks for profiling

It would be useful to be able to have hooks at various points during dispatch:

Before firing currentReducer
After currentReducer is complete
Before firing all listeners (pass in listeners array)
Before firing each listener (pass in the listener)
After firing each listener
After firing all listeners

Additionally, if we add the displayName for the wrapped React component when using @connect as a property to the listener, we'd be able to determine what component is being updated.

It would be useful to be able to have hooks at various points during dispatch

Points 1 to 6 can be implemented in userland as a “store enhancer”—essentially a createStore -> createStore function. You can take a look at https://github.com/tappleby/redux-batched-subscribe for what the implementation could roughly look like (with different logic, of course). Basically you'd wrap reducer in constructor, wrap listener in subscribe, and expose some methods to read the measurements.
Something like
redux-hook // or something like that
export default function hook(wrapReducer, wrapListener) {
    return (next) => (reducer, initialState) => {
        const store = next(wrapReducer(reducer), initialState);
        return {
            ...store,
            subscribe: (listener) => {
                return store.subscribe(wrapListener(listener));
            }
        };
    };
}

Usage:
store/configureStore.js
import hook from 'redux-hook'; // above

export let measurements = {}; // todo: update them

const trackReducer(reducer) {
    return (state, action) => {
        // todo: begin measurements
        let result = reducer(state, action);
        // todo: end and record measurements
        return result;
    };
}

const trackListener(listener) {
    return () => {
        // todo: begin measurements
        listener();
        // todo: end and record measurements
    };
}

const finalCreateStore = hook(trackReducer, trackListener)(createStore);

export default function configureStore(initialState) {
    return finalCreateStore(reducer, initialState);
}

store/index.js
import configureStore from 'store/configureStore';
const store = configureStore();
// ...

Additionally, if we add the displayName for the wrapped React component when using @connect as a property to the listener, we'd be able to determine what component is being updated.

Isn't that <connect result>.WrappedComponent.displayName?

Closing for inactivity.


Added piccolo integration.

Signed-off-by: Pavel Kirilin<EMAIL_ADDRESS>

@AliSayyah, could you please check if I implemented it correctly.

Hey @s3rius
I'll check it out tomorrow if that's ok.


'No known model deployment with id [my-elser-model]' in "retrievers_intro_notebook"

I had a local setup using Elastic Stack 8.14. I tried to run the notebook at https://github.com/elastic/elasticsearch-labs/blob/main/supporting-blog-content/introducing-retrievers/retrievers_intro_notebook.ipynb with some modification to make it work with my local setup.
I have an error with the following code:
for model_id in ["my-elser-model","my-e5-model"]:
    result = es.perform_request(
        "POST",
        f"/_ml/trained_models/{model_id}/deployment/_update",
        headers={"content-type": "application/json", "accept": "application/json"},
        body={"number_of_allocations": 1},
    )

However, I do not have error with the following code:
for model_id in [".elser_model_2","my-e5-model"]:
    result = es.perform_request(
        "POST",
        f"/_ml/trained_models/{model_id}/deployment/_update",
        headers={"content-type": "application/json", "accept": "application/json"},
        body={"number_of_allocations": 1},
    )

Please be noted that I did not install the linux_x6 version since I ran it on my macOS computer.
In addition, the following code:
response = es.search(
    index="imdb_movies",
    body={
        "retriever": {
            "standard": {
                "query": {
                    "text_expansion": {
                        "overview_sparse": {
                            "model_id": "my-elser-model",
                            "model_text": movie_search,
                        }
                    }
                }
            }
        },
        "size": 3,
        "fields": ["names", "overview"],
        "_source": False,
    },
)

for hit in response["hits"]["hits"]:
    print(f"{hit['fields']['names'][0]}\n- {hit['fields']['overview'][0]}\n")

It gave me the error like:

However, the following code does not give me any error:
response = es.search(
    index="imdb_movies",
    body={
        "retriever": {
            "standard": {
                "query": {
                    "text_expansion": {
                        "overview_sparse": {
                            "model_id": ".elser_model_2",
                            "model_text": movie_search,
                        }
                    }
                }
            }
        },
        "size": 3,
        "fields": ["names", "overview"],
        "_source": False,
    },
)

for hit in response["hits"]["hits"]:
    print(f"{hit['fields']['names'][0]}\n- {hit['fields']['overview'][0]}\n")

We should be creating the inference services (https://www.elastic.co/guide/en/elasticsearch/reference/current/put-inference-api.html) under those names. Behind the scenes it will deploy ELSER or e5 model if not available automatically. Im unsure why it failed to create an inference deployment. Could you try again and see the error for deploying my-e5-model or my-elser-model.
thanks


skip stats building if no stats is enabled

What changes were proposed in this pull request?
If no stats is enabled, we don't have to keep things in memory.
How was this patch tested?
N/A

I'll merge this as a simple improvement.


Fix a regression in the traffic_ctl host status subcommand.

the traffic_ctl host status subcommand was unable to fetch the proper status stats as the reason tag was not used in the search.  This fixes the problem so that host status is now found for all reason tags.
Should also be backported to 8.0

I'm pretty sure that this was not in the 8.0.2 release.

Cherry picked to 8.1.0.


TCPHandle custom.

Hello.
First of all thanks for the library. And second, can we remove the "final" operator of the TCPHandle class and have the loop.resource  () method accept the custon class of TCPHandle?
Example:
class TCPHandleExtended : public uvw::TCPHandle { }; //other code.... 	auto loop = uvw::Loop::getDefault(); 	auto tcpExtended = loop->resource<TCPHandleExtended>(); //other code....
Mi ingles no es bueno. Thanks!

🤔 Can I ask you what would be the purpose of this? I mean, why do you want to extend the tcp handle?

It is to create classes like Server or Client. It's an idea. With libuv I created my classes extending from uv_tcp_t and thus start the class together with the necessary handle

I'd rather suggest to use a data member for that. There is nothing wrong in removing the final, though conceptually a server uses a handle while it is not a handle.

As I prefer composition over inheritance in this kind of situation, I like
the final keyword on every handle.
Il giorno dom 16 mag 2021 alle 11:55 Michele Caini @.***>
ha scritto:

I'd rather suggest to use a data member for that. There is nothing wrong
in removing the final, though conceptually a server uses a handle while
it is not a handle.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/skypjack/uvw/issues/243#issuecomment-841794286, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPVRMXRKOXKAP7J32IB46TTN6JB7ANCNFSM446JPGPA
.

--
@fiorentinoIng https://twitter.com/fiorentinoing -
@.***

Ok, I close the ticket.


Minor: fixed DQ edit test case issue and searchIndexDetails typescript issue

Describe your changes:

Fixed edit test case error issue and cypress test
searchIndexDetails typescript issue

Type of change:

[ ] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

The main focus of this PR is DQ and searchIndexDetails cypress, Which is passing, the rest of the failures are already assigned to respective feature owner and its work in progress!


README.md Grammar changes are required in this file.

Is there an existing issue for this?

[X] I have searched the existing issues

Issue Description
README.md This file needs grammar changes.
Suggested Change
README.md This file needs grammar changes.
Rationale
No response
Urgency
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

I have worked on this. @varshith257, @Anishkagupta04 Can you assign me under GSSOC 24?


ClickHouse syntax error on each query

System information:

Operating system (distribution) and version: Windows 7
DBeaver version: <IP_ADDRESS>206051253
Additional extensions: None

Connection specification:

Database name and version: ClickHouse <IP_ADDRESS>5
Driver name: com.clickhouse.jdbc.ClickHouseDriver
Do you use tunnels or proxies (SSH, SOCKS, etc)? : No

Describe the problem you're observing:
Before each user query to clickhouse dbeaver sends an extra one which fails with log message from clickhouse.
Seems like no effect to user queries.
Steps to reproduce, if exist:
Perform any query
Include any warning/errors/backtraces from the logs
ClickHouse error:
2022.06.27 00:34:11.822167 [ 52535 ] {be708644-dd61-4f03-a15f-2658ba4b6b6e} <Error> executeQuery: Code: 62. DB::Exception: Syntax error: failed at position 72 ('Client'): Client as DEFAULT_VALUE, Application name as DESCRIPTION union all select CustomHttpHeaders as NAME, toInt32(0) as MAX_LEN,  as DEFAULT_VALUE, Custom HTTP heade. Expected one of: token, Comma, FROM, PREWHERE, WHERE, GROUP BY, WITH, HAVING, WINDOW, ORDER BY, LIMIT, OFFSET, SETTINGS, UNION, EXCEPT, INTERSECT, INTO OUTFILE, FORMAT, end of query. (SYNTAX_ERROR) (version <IP_ADDRESS>5 (official build)) (from <IP_ADDRESS>:52522) (in query: select ApplicationName as NAME, toInt32(0) as MAX_LEN, ClickHouse Java Client as DEFAULT_VALUE, Application name as DESCRIPTION union all select CustomHttpHeaders as NAME, toInt32(0) as MAX_LEN, as DEFAULT_VALUE, Custom HTTP headers as DESCRIPTION union all select CustomHttpParameters as NAME, toInt32(0) as MAX_LEN, as DEFAULT_VALUE, Customer HTTP query parameters as DESCRIPTION), Stack trace (when copying this message, always include the lines below):

Can't reproduce this.
The error text says that you execute some long SELECT query which fails because of syntax error. This text definitely comes not from dbeaver.
How do you execute a query?
Note that ctrl+enter executes currently selected query while alt+x executes entire script.

I found this query - this is from clickhouse jdbc driver, method getClientInfoProperties.
Seems like some of connection parameters are undefined, which leads to the empty placeholder in query: "...toInt32(0) as MAX_LEN,  as DEFAULT_VALUE, ..."

What Clickhouse driver version do you use? You can get the version number from the Test Connection dialog.

ClickHouse JDBC Driver clickhouse-jdbc 0.3.2 (revision: 1795272)

Can you please provide log files? You can find instruction here: https://github.com/dbeaver/dbeaver/wiki/Log-files
Also, a screenshot of the Query Manager would be handy (in case it contains the failed queries).

`2022-06-29 16:33:10.891 - Connect with '~::ch:testdb' (com_clickhouse-181a025a773-2df0a47c513f38a2)

Start DBeaver Generic Plug-in [org.jkiss.dbeaver.ext.generic <IP_ADDRESS>206051253]
Start DBeaver Clickhouse Support [org.jkiss.dbeaver.ext.clickhouse <IP_ADDRESS>206051253]
2022-06-29 16:33:10.931 - Execution context opened (~::ch:testdb; Main; 2)
2022-06-29 16:33:11.145 - Error reading and setting client application name: Code: 62. DB::Exception: Syntax error: failed at position 72 ('Client'): Client as DEFAULT_VALUE, Application name as DESCRIPTION union all select CustomHttpHeaders as NAME, toInt32(0) as MAX_LEN,  as DEFAULT_VALUE, Custom HTTP heade. Expected one of: token, Comma, FROM, PREWHERE, WHERE, GROUP BY, WITH, HAVING, WINDOW, ORDER BY, LIMIT, OFFSET, SETTINGS, UNION, EXCEPT, INTERSECT, INTO OUTFILE, FORMAT, end of query. (SYNTAX_ERROR) (version <IP_ADDRESS>5 (official build))
, server ClickHouseNode(addr=http:<IP_ADDRESS>:8123, db=testdb)@-1638935699
2022-06-29 16:33:11.146 - Execution context opened (~::ch:testdb; Metadata; 3)
2022-06-29 16:33:11.153 - Error reading and setting client application name: Code: 62. DB::Exception: Syntax error: failed at position 72 ('Client'): Client as DEFAULT_VALUE, Application name as DESCRIPTION union all select CustomHttpHeaders as NAME, toInt32(0) as MAX_LEN,  as DEFAULT_VALUE, Custom HTTP heade. Expected one of: token, Comma, FROM, PREWHERE, WHERE, GROUP BY, WITH, HAVING, WINDOW, ORDER BY, LIMIT, OFFSET, SETTINGS, UNION, EXCEPT, INTERSECT, INTO OUTFILE, FORMAT, end of query. (SYNTAX_ERROR) (version <IP_ADDRESS>5 (official build))
, server ClickHouseNode(addr=http:<IP_ADDRESS>:8123, db=testdb)@-1638935699
2022-06-29 16:33:11.303 - Connected (com_clickhouse-181a025a773-2df0a47c513f38a2, ClickHouse JDBC Driver [clickhouse-jdbc 0.3.2 (revision: 1795272)])
2022-06-29 16:33:11.312 - Duplicate object name 'INFORMATION_SCHEMA' in cache SimpleObjectCache. Last value: information_schema
2022-06-29 16:33:11.326 - Duplicate object name 'ENUM' in cache ClickhouseDataTypeCache. Last value: Enum
2022-06-29 16:33:11.326 - Duplicate object name 'BOOL' in cache ClickhouseDataTypeCache. Last value: bool
2022-06-29 16:33:11.326 - Duplicate object name 'ARRAY(ENUM)' in cache ClickhouseDataTypeCache. Last value: Array(Enum)
2022-06-29 16:33:11.327 - Duplicate object name 'ARRAY(BOOL)' in cache ClickhouseDataTypeCache. Last value: Array(bool)
2022-06-29 16:33:11.435 - Execution context closed (~::ch:testdb, 2)
2022-06-29 16:33:11.443 - Error reading and setting client application name: Code: 62. DB::Exception: Syntax error: failed at position 72 ('Client'): Client as DEFAULT_VALUE, Application name as DESCRIPTION union all select CustomHttpHeaders as NAME, toInt32(0) as MAX_LEN,  as DEFAULT_VALUE, Custom HTTP heade. Expected one of: token, Comma, FROM, PREWHERE, WHERE, GROUP BY, WITH, HAVING, WINDOW, ORDER BY, LIMIT, OFFSET, SETTINGS, UNION, EXCEPT, INTERSECT, INTO OUTFILE, FORMAT, end of query. (SYNTAX_ERROR) (version <IP_ADDRESS>5 (official build))
, server ClickHouseNode(addr=http:<IP_ADDRESS>:8123, db=testdb)@-1638935699
2022-06-29 16:33:11.484 - Table 'testdb.unknown' not found in metadata catalog
2022-06-29 16:33:55.409 - Execution context closed (~::ch:testdb, 2)
2022-06-29 16:33:55.419 - Error reading and setting client application name: Code: 62. DB::Exception: Syntax error: failed at position 72 ('Client'): Client as DEFAULT_VALUE, Application name as DESCRIPTION union all select CustomHttpHeaders as NAME, toInt32(0) as MAX_LEN,  as DEFAULT_VALUE, Custom HTTP heade. Expected one of: token, Comma, FROM, PREWHERE, WHERE, GROUP BY, WITH, HAVING, WINDOW, ORDER BY, LIMIT, OFFSET, SETTINGS, UNION, EXCEPT, INTERSECT, INTO OUTFILE, FORMAT, end of query. (SYNTAX_ERROR) (version <IP_ADDRESS>5 (official build))
, server ClickHouseNode(addr=http:<IP_ADDRESS>:8123, db=testdb)@-1638935699
2022-06-29 16:33:55.425 - Table 'testdb.unknown' not found in metadata catalog`

Apparently ClickHouse Java Client as DEFAULT_VALUE should be 'ClickHouse Java Client' as DEFAULT_VALUE - same issue exists in latest patch release. I'll fix it in next release.

fixed in the scope of #17879


Error when Resetting Partners Password

Our jurisdictional partner in Detroit tried to reset their password and was unable to do so. They received the reset email, but an error was thrown up once they tried to submit their new password. I was able to replicate the issue and received the same error message. This is a medium priority issue.
Private Zenhub Image

This is an issue seemingly only on detroit
seems like its caused by TypeORM using too long of a column alias during the actual querying of the DB. Which is causing issues later down the line in TypeORM once it gets a response from the DB

@YazeedLoonat is there anything to be done about this now or are we waiting for the Prisma swap to hopefully fix?


Re-trying the PR #881: Migrating native sim from GCC to Clang.

A set of 3 PRs: Q#RT, QDK, IQ# repos.
A set of the latter 2 are expected to require a branch-specific e2e build or a merge of the former one first.

/azp run

Please review.

Any more feedback please?
Any approvals?


Fix loadless signals in the design

WARNING:Par:283 - There are 85 loadless signals in this design. This design will cause Bitgen to issue DRC warnings.

Closing this as the HDMI2USB-jahanzeb-firmware is no longer under development.
All active development is now on the HDMI2USB-misoc-firmware which supports both the Atlys and Opsis boards and has loads of other new features!


Update to Flutter beta channel

SchedulerBinding.instance is now non-nullable, so the unnecessary_non_null_assertion diagnostic is triggered.
To fix, I ran "dart fix --apply", since this diagnostic can be fixed automatically.
Increases the patch version of this package, since the API isn't changing.

Hi @johnpryan - thanks for the contribution. I do not think this change makes sense until the framework API change lands on stable.

Its in stable now?


[Event Request] page 6510 "Item Tracking Lines" - OnRegisterItemTrackingLinesOnBeforeValidateExistingQuantityBase

To clarify this request: When an item tracking line already exists i.e. T337 record(s) exist then afterwards you might want to update certain secondary fields (Identified by procedure EntriesAreIdentical and parameter IdenticalArray[2]). We do not want to validate the Rec."Quantity (Base)" again when TempTrackingSpecification."Quantity (Base)" is zero in that case.
procedure RegisterItemTrackingLines(SourceTrackingSpecification: Record "Tracking Specification"; AvailabilityDate: Date; var TempTrackingSpecification: Record "Tracking Specification" temporary)
...
if IsCorrection then begin
Rec."Quantity (Base)" += TempTrackingSpecification."Quantity (Base)";
Rec."Qty. to Handle (Base)" += TempTrackingSpecification."Qty. to Handle (Base)";
Rec."Qty. to Invoice (Base)" += TempTrackingSpecification."Qty. to Invoice (Base)";
//A200F0000.Event20.02.os
//end else
//    Rec.Validate("Quantity (Base)", "Quantity (Base)" + TempTrackingSpecification."Quantity (Base)");
//A200F0000.Event20.02.oe
//A200F0000.Event20.02.ns
end else begin
IsHandled := false;
OnRegisterItemTrackingLinesOnBeforeValidateExistingQuantityBase(Rec, TempTrackingSpecification, CurrentRunMode, IsHandled);
if not IsHandled then
Rec.Validate("Quantity (Base)", "Quantity (Base)" + TempTrackingSpecification."Quantity (Base)");
end;
//A200F0000.Event20.02.ne
[IntegrationEvent(false, false)]
local procedure OnRegisterItemTrackingLinesOnBeforeValidateExistingQuantityBase(var TrackingSpecification: Record "Tracking Specification"; var TempTrackingSpecification: Record "Tracking Specification" temporary; CurrentRunMode: Enum "Item Tracking Run Mode"; var IsHandled: Boolean)
begin
    //A200F0000.Event20.02
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 43761.


Document UMassObserverProcessor

Documentation section for UMassObserverProcessor.

Provide a description of what a UMassObserverProcessor is and when is convenient to use versus a  UMassProcessor.
Highlight the differences between a UMassObserverProcessor and a UMassProcessor

Documentation and examples added!


Added APT/Debian Packager to package managers for MacOS and combined PR #1702

Description
This adds support for APT/dpkg package manager for macOS when being used.
Added support by providing information for new iOS and iPadOS devices. This was initially apart of PR# 1702
Features
This add the number of APT/dpkg packages installed on macOS.
This will allow for Host, CPU, and GPU tags to display correct and accurate information for newer iOS and iPadOS devices. Huge thanks to @NotZoeyDev for providing this information about the new devices.

Fix the indentation, otherwise no issues.

Fix the indentation, otherwise no issues.

I was using nano on macOS so indentation is little weird for me. It showed up fine on nano, but looked wrong on vscode. When I pushed it right now the indentation seem fined, but now it looks weird on github web editor.

Indentation is four spaces. Nano might be inserting tabs.

Can fix on my end. :)

Thank you! Sorry for the little inconvenience.


cannot identify image file <_io.BytesIO object

OS: Ubuntu18.04
Python: 3.6
torch: 1.6
CUDA: 10.1
GPU: RTX 2080 X2
Hi, I prepared  custom dataset flower_photos (can be find from tensorflow tutorial) with size 128. Then I encouned the error as title told. How can I solve it?

Sorry, I missed --size=128 parameter while training.


preparing kusto for cli generation

adding kusto test scenario

Automation for azure-sdk-for-go

Automation for azure-sdk-for-python

Can one of the admins verify this patch?


Fix ColladaExporter submesh index bug

🦟 Bug fix
Fixes #761
Summary

The fix IMO is straightforward, use the iteration index to include properly the missing submeshes to the exported SubMeshes array.
I closed the previous PR because I had to rebase in top of ign-gazebo5.
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Would it be possible to add a test with submeshes to https://github.com/ignitionrobotics/ign-gazebo/blob/ign-gazebo5/test/integration/collada_world_exporter.cc ?

@chapulina Sure! I'll add a test there for submeshes with this PR

@chapulina I added a test for sub-meshes as you asked me, the model from fuel that started the issue.
Please note though that the test only checks if there's an output, and the issue addressed with this PR was silently failing as the exported result was incorrect.

I can confirm that I had the same issue and went through fixing it and... Wrote the same fix locally, then when opening a PR I saw this branch :sweat_smile:

The test also seems to add quite a lot of binaries

Agreed, ideally we'd use a model as simple as possible, with just enough meshes and textures to test the functionality.

@chapulina @luca-della-vedova Thanks for your comments, I added a simpler test case taken from ign-common tests.

Is the mesh_with_submeshes.dae needed?

@nkoenig I addressed your comment with f1596eb. Actually the extra file was the box.dae, the intented file to test was the one with submeshes :disappointed_relieved:. Thanks!

Force-pushed to rebase on top of updated ign-gazebo5, commits weren't changed.


cannot directly visit https://www.permaplant.net/maps/2

Describe the Bug
No response
Steps to Reproduce the Problem
go to https://www.permaplant.net/maps/2
Expected Result
map opens
Actual Result
404
PermaplanT version
master
Operating System
Linux
Browser
Firefox
Versions of other relevant software/extensions
No response
Additional info/logs
No response

give me 10 minutes

fix rolled out 😄 (see infra repo)

Great, everything works again! :heart: Let us call it a day :+1:


Update to rust-url 1.0

The code change is not strictly necessary but it saves a String allocation.
This is not a breaking change since Url is not part of the public API.

Neat!

Please publish a git2-curl version, to help Cargo ship only one copy of rust-url :)

Done!


[BUG] Cleanup tfvars

Is there an existing issue for this?

[X] I have searched the existing issues

What type of issue are you facing
bug report
Describe the bug

Add *.tfvars to .gitignore to follow best practices. Otherwise customers might by accidentally committed
Adjust code of samples
Adjust documentation of samples

Expected Behavior
n/a
Steps To Reproduce
n/a
Add screenshots to help explain your problem
n/a
Additional context
n/a

PR #157 fixes the following.

Adjust code of samples
Adjust documentation of samples
Add *.tfvars to .gitignore (It is already part of .gitignore)


Fix: Fixed issue with browsing WSL drives

Resolved / Related Issues

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #11272

Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[x] Are there any other steps that were used to validate these changes?

Navigated through a WSL distribution
For network shares it still asks for credentials

Notes

I dont think AuthenticateNetworkShare is needed for WSL distributions, it is now skipped
Problem was probably introduced with #11193

What exectly do you mean with that? Is there anything else i should test?

I meant that you were normalizing the path but then you were using the raw path instead of the normalized one. Now you changed that and it's ok


Feature/persistent storage

Hey, I just made a draft Pull Request!
i am adding persistent storage such as redis for auth cache, so the system can become scalable.
this is still work in progress , and would like to have recommendations and contributions.

@NishkarshRaj


generic enums fail to produce correct schemas for variants

Background

Take the todo-axum crate

add a generic enum type with an alias, as recommended in docs:
    #[derive(ToSchema, Serialize, Deserialize, Clone)]
    #[aliases(TestEnumString = TestEnum<String>)]
    pub(super) enum TestEnum<T> {
        Video(T),
    }

add a field of this type to struct Todo:
        test: TestEnumString,

...and a corresponding element to the components:
        components(
            schemas(todo::Todo, todo::TodoError, todo::TestEnumString)
        ),

run the example. swagger's OpenApi gives the following error:
Resolver error at paths./todo.get.responses.200.content.application/json.schema.items.properties.test.oneOf.0.properties.Video.$ref
Could not resolve reference: Could not resolve pointer: /components/schemas/T does not exist in document does not exist in document

🤬

This makes sense, but...
Question
How do I get utoipa to stop adding T to the OpenApi?
Failed workaround
The docs seem to say that enum variant configuration options for #[schema(...)] support...

all variant specific configuration options e.g. if variant is UnnamedStruct then unnamed struct type configuration options are supported.

...but this does not seem to be true. Unnamed struct type configuration options include as =, so I tried #[schema(as = Video(String))] before Video(T), and it failed with
unexpected attribute: as, expected any of: example, default, title, format, value_type, rename, deprecated

Current (working) workaround

Define yet another type,
    #[derive(ToSchema, Serialize, Deserialize, Clone)]
    pub(super) enum TestEnumString {
        Video(String),
    }

Replace #[aliases(TestEnumString = TestEnum<String>)] with #[schema(as = TestEnumString)].

🤩

...but this seems a little hack-y.
I can include fuller source code if need be.

I stumbled into this issue myself as well.
In case it helps someone reading:
For my personal use case, I attempted to create an enum NotRequired<T> wrapper as a way to represent non-nullable, non-required optional fields, since utoipa automatically treated Option<T> fields as nullable even when setting #[serde(default, skip_if="Option::is_none")] attributes. I was able to work around this by instead using the #[schema(schema_with)] attribute like so:
#[derive(ToSchema)]
struct Example {
    #[schema(schema_with = String::schema)] // resulting schema has `field: string`
    field: Option<String>
}

This will be fixed here with full generics support #1034


Nice to have: search by LTLA codes

E.g. E08000037

would be very redundant but it should work if they're added to the extra search terms e.g. https://github.com/theosanderson/covince/blob/master/public/data/area-search.json. Probably better to handle it as a special case on the UI 👍🏽

Yeah I was hoping that might do the trick - this was a note to self, but you reminded me quite how easy it was so done :) Thanks for setting up the infrastructure!


Mismatch of python/pandas/numpy versions leads to error under very specific circumstances

Snakemake version
Tested with 7.6.1 (latest) and 5.32.1
Describe the bug
This is an incredibly weird bug that only occurs under very (!) specific circumstances. Unfortunately, exactly those that I currently have in my production code... It took me a while to distill this down to a truly minimal example. Download the example here, and let's walk through it:
First, we want to run snakemake in a conda environment:
# env-parent.yaml
name: snakemake-7.6.1
channels:
  - bioconda
  - conda-forge
dependencies:
  - snakemake=7.6.1
  - python ==3.7.10
  - pandas=1.3.1
  - numpy=1.21.0

Use this environement:
mamba env create -f env-parent.yaml
conda activate snakemake-7.6.1

We also have an environment specifically for a rule:
# env-rule.yaml
channels:
  - bioconda
  - conda-forge
dependencies:
  # This is where the version mismatch is happening.
  # With 3.10, we get the error, with 3.7.10 not,
  # as that is also what's used in the parent environment.
  - python ==3.10

With that, we can then run the following:
# Snakefile
import pandas as pd

# We need to load a config (does not need to contain anything interesting),
# and then need to add a key to it via pandas.
# The table does not need to contain much, just enough to not fail reading.
# We do not even need to use this config anywhere downstream.
configfile: "config.yaml"
config["table"] = pd.read_csv("table.tsv", sep='\t', dtype=str)

# Edit: Just using a DataFrame suffices:
# config["table"] = pd.DataFrame()

# We need to use a rule-specific conda environemnt, and we need to use a script.
rule all:
    output:
        "dummy.txt"
    conda:
        "env-rule.yaml"
    script:
        # The script just touches the output file.
        "script.py"

via
snakemake --use-conda --cores 1 --conda-frontend mamba
# mamba or conda frontend does not matter

This leads to the following error:
ImportError: Unable to import required dependencies:
numpy:

Full error message
File "/home/lucas/Software/miniconda/envs/snakemake-7.6.1/lib/python3.7/site-packages/pandas/__init__.py", line 16, in <module>
    raise ImportError(
ImportError: Unable to import required dependencies:
numpy:

IMPORTANT: PLEASE READ THIS FOR ADVICE ON HOW TO SOLVE THIS ISSUE!

Importing the numpy C-extensions failed. This error can happen for
many reasons, often due to issues with your setup or how NumPy was
installed.

We have compiled some common reasons and troubleshooting tips at:

    https://numpy.org/devdocs/user/troubleshooting-importerror.html

Please note and check the following:

  * The Python version is: Python3.10 from "/home/lucas/Downloads/tmp/.snakemake/conda/c8bba9192d80f12dcd954355d2a0791e/bin/python"
  * The NumPy version is: "1.21.0"

and make sure that they are the versions you expect.
Please carefully study the documentation linked above for further help.

Original error was: No module named 'numpy.core._multiarray_umath'

If any of the parts described as "need" in the Snakefile above are not given (not loading a config file, not adding a key to it via pandas, not using a separate conda environment for the rule, not using a script in the rule), the error does not occur. It also disappears if we match the python versions in the two environments.
I originally discovered the bug because of a rule-specific conda environment that simply loaded a tool instead of python itself, but the tool then pulled the conflicting python version into the environment. That has originally led me to discover this bug. As a side note - if anyone knows a solution to this problem that is easier than specifying the python version explicitly in every rule-specific environment, please let me know!

Thank you @dariober for your input, also on stack overflow!
I have played around with this a bit more, and it seems to me that Snakemake does indeed nest/stack the conda environments, which is (I think) both a good idea (to make tools easily available), and a bad idea (because then conflicts can occur).
A more general look at the problem
The problematic case is as follows: Run snakemake with a specific set of python/numpy/pandas versions, but have a rule whose env either directly or indirectly pulls a conflicting set of versions (this is what originally caused my trouble).
In my case, when loading tool X, conda detected that tool X needs python and pandas, and loaded versions that are conflicting with the versions in the parent env from which snakemake was run. So, unless this rule env also specifies these versions explicitly, we get an error.
A test case
I have prepared another minimal test case to show this.
Our test is just to see which versions are being used:
# script.py
#!/usr/bin/python

import sys
import numpy
import pandas

print("python:", str(sys.version.split(' ')[0]))
print("numpy: ", numpy.__version__)
print("pandas:", pandas.__version__)

When running this as-is on my terminal, I get this baseline:
python3 ./script.py
# python: 3.8.10
# numpy:  1.20.3
# pandas: 1.2.4

Now let's see what Snakemake makes out of this. We start with the parent env from before:
# env-parent.yaml
name: snakemake-7.6.1
channels:
  - bioconda
  - conda-forge
dependencies:
  - snakemake =7.6.1
  - python =3.7.10
  - numpy =1.21.0
  - pandas =1.3.1

and run this through a minimal Snakefile:
rule all:
    conda:
        "env-rule.yaml"
    script:
        "script.py"

First we run this just within the parent env, without --use-conda, to ignore the env-rule.yaml file:
mamba create -f env-parent.yaml
conda activate snakemake-7.6.1

python script.py
# python: 3.7.10
# numpy:  1.21.0
# pandas: 1.3.1

snakemake --cores 1
# python: 3.7.10
# numpy:  1.21.0
# pandas: 1.3.1

which is what we expect: In both cases, when just running the script on the terminal, and running it via Snakemake, the versions from the conda env in which we run snakemake are used, and not the ones on my system.
Now we want to use the rule env that changes the python version:
# env-rule.yaml
channels:
  - bioconda
  - conda-forge
dependencies:
  - python ==3.10

With that, once we use conda for the rule execution, we fail:
snakemake --cores 1 --use-conda
#  * The Python version is: Python3.10 from ".../.snakemake/conda/f0ba209f958698b71e45e56d1afb0938/bin/python"
#  * The NumPy version is: "1.21.0"

This does not even get past the import, but shows that indeed the rule-specific python version is used, but the numpy version from the parent env, and not from my system! So indeed Snakemake is stacking/nesting envs here - and that is causing trouble when tool dependencies pull in conflicting versions.
The question
How can we prevent this from happening, other than having to specify python/numpy/pandas explicitly in those rule envs that otherwise would pull in conflicting versions due to them being an implicit dependency of some other tool that is requested in the rule-specific environment?


Performance issue when extracting large archives.

Example archive: https://storage.googleapis.com/pub-packages/packages/fhir-0.4.0.tar.gz
Iterating through the entries and getting their content is really slow on a relatively modern CPU. Possibly buffering / buffer sizing / buffer copies are at fault here.

Thanks for the report! Can you post how you go iterate though the files? Are you just calling hasNext() and then write the contents to a file?

Hmm, I can't reproduce...
import 'dart:io';
import 'package:tar/tar.dart';

Future<void> main() async {
  final u =
      'https://storage.googleapis.com/pub-packages/packages/fhir-0.4.0.tar.gz';
  final c = HttpClient();
  final req = await c.getUrl(Uri.parse(u));
  final res = await req.close();
  final reader = TarReader(res.transform(gzip.decoder));

  while (await reader.moveNext()) {
    final header = reader.current.header;
    var size = 0;
    await reader.current.contents.forEach((chunk) {
      size += chunk.length;
    });
    print('${header.name}: $size bytes');
  }
  await reader.cancel();
  c.close();
}

void main() async {
  final rs = await http.get(Uri.parse(
      'https://storage.googleapis.com/pub-packages/packages/fhir-0.4.0.tar.gz'));
  final decompressed = gzip.decode(rs.bodyBytes);
  final reader = TarReader(Stream.fromIterable([decompressed]));
  final sw = Stopwatch()..start();
  while (await reader.moveNext()) {
    final entry = reader.current;
    final content = await entry.contents.toList();
    print(
        '${sw.elapsed} ${entry.header.name} ${entry.header.size} ${content.length}');
  }
}

0:00:00.789303 CHANGELOG.md 6456 1
0:00:01.930241 LICENSE 1080 1
0:00:03.067631 README.md 13657 1
0:00:04.183780 build.yaml 592 1
0:00:05.329544 example/lib/main.dart 3145 1
0:00:06.472146 example/pubspec.yaml 262 1
0:00:07.633339 lib/dstu2.dart 74 1
0:00:08.806767 lib/dstu2/basic_types/basic_types.dart 53 1
0:00:09.978639 lib/dstu2/basic_types/element.dart 1234 1
0:00:11.162848 lib/dstu2/basic_types/element.freezed.dart 6918 1

hmm, if everything is a single chunk then I bet ChunkedStreamReader might do something slow..

        if (_buffer.isNotEmpty) {
          if (size < _buffer.length) {
            final output = _buffer.sublist(0, size); // this is probably slow
            _buffer = _buffer.sublist(size);         // probably also slow...
            size = 0;
            yield output;
            _reading = false;
            break;
          }

Good news in pub we do streaming consumption... so this shouldn't be a problem :D

Yeah, sublist is super-slow. A relevant part from package:buffer for building a view:
https://github.com/isoos/buffer/blob/master/lib/buffer.dart#L423-L426

@isoos As a temporary workaround, you can make the operation much faster by splitting the streams into chunks of 512:
extension on List<int> {
  Stream<Uint8List> get chunksForTar {
    const blockSize = 512;
    final buffer = this is Uint8List
        ? (this as Uint8List).buffer
        : Uint8List.fromList(this).buffer;
    final amountOfBlocks = (length + 1) ~/ blockSize;

    return Stream.fromIterable(Iterable.generate(amountOfBlocks, (i) {
      final start = i * blockSize;
      final blockLength = min(blockSize, length - start);
      return buffer.asUint8List(start, blockLength);
    }));
  }
}

Yeah, that could work, but in the end I've updated the download and extraction code here: https://github.com/dart-lang/pana/pull/883

Also checked the other use-cases in pub-dev, and we are doing the parsing with a stream from File.openRead() which should be fine.

I tried to benchmark this specific scenario some more, by downloading fhir-0.4.0.tar.gz and deflating it to a tar file. I then ran 50 iterations with the current implementation, the faster chunked stream implementation and a custom chunking implementation specialized on fixed-length blocks.
Here is the median of 50 iterations (which is way faster than running it once, probably due to JIT kicking in):

Implementation
Stream from tar file
Read single chunk

Current tar / current async
1087ms
too long to test

Current tar / PR from Jonas
725ms
327ms

Custom in tar
508ms
134ms

package:archive
unsupported
98ms

Almost all of the difference between the fastest package:tar and package:archive is spent verifying checksums (not done by archive) and detecting advanced headers, so I'm ok with that.
I think the takeaway here is that async IO is slow (dartbug.com/44006), I reckon that we'll be plenty fast if the chunked stream reader also supports specializations for Uint8List.

This has been fixed in tar version 0.5.1.


Secure GitHub Pages Site With HTTPS

Currently, the GitHub Pages site for this repository is served over both HTTP and HTTPS, with no redirects from the insecure HTTP site to the secure HTTPS site:

http://google.github.io/styleguide/pyguide.html
https://google.github.io/styleguide/pyguide.html

The security benefits of HTTPS-by-default are clear. Google itself gives a ranking boost to HTTPS sites, and Chrome displays a "Not Secure" indicator for HTTP sites.
This can be fixed by checking the "Enforce HTTPS" box in the repository settings, under the "GitHub Pages" section:
https://help.github.com/en/github/working-with-github-pages/securing-your-github-pages-site-with-https#enforcing-https-for-your-github-pages-site
Thank you.

Done, thanks!


open_memstream [used by esp-console] fails when CONFIG_HEAP_TASK_TRACKING: assert failed: insert_free_block tlsf.c:358 (current && "free list cannot have a null entry") (IDFGH-11345)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.2-dev-3775-gb4268c874a
Espressif SoC revision.
ESP32-S3 (QFN56) (revision v0.1)
Operating System used.
Linux
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
None
Development Kit.
ESP32-S3-WROOM-1
Power Supply used.
USB
What is the expected behavior?
Provided the following program:
#include <stdio.h>

void app_main(void)
{
        char *ptr = NULL;
        size_t size = 0;
        FILE *fp = open_memstream(&ptr, &size);
        if (fp != NULL) {
                fclose(fp);
        }
}

And the following config:
CONFIG_HEAP_TASK_TRACKING=y

Legit code should run properly and not crash.
What is the actual behavior?
Crash as per the following traceback:
I (303) main_task: Started on CPU0
I (313) main_task: Calling app_main()

assert failed: insert_free_block tlsf.c:358 (current && "free list cannot have a null entry")
HINT: CORRUPT HEAP: heap metadata corrupted resulting in TLSF malfunction.
Make sure you are not making out of bound writing on the memory you allocate in your application.
Make sure you are not writing on freed memory.
For more information run 'idf.py docs -sp api-reference/system/heap_debug.html'.

Backtrace: 0x4037585a:0x3fc983e0 0x40379a5d:0x3fc98400 0x4037f8b9:0x3fc98420 0x4037f596:0x3fc98540 0x4037e7ee:0x3fc98570 0x403760e8:0x3fc98590 0x40376158:0x3fc985c0 0x4037618f:0x3fc985e0 0x4037f911:0x3fc98600 0x4200cee1:0x3fc98620 0x4200bf0a:0x3fc98640 0x4200bf8b:0x3fc98670 0x4200803d:0x3fc98690 0x42017f97:0x3fc986c0 0x4037a2c1:0x3fc986f0
0x4037585a: panic_abort at /home/alonbl/esp-idf/components/esp_system/panic.c:472

0x40379a5d: esp_system_abort at /home/alonbl/esp-idf/components/esp_system/port/esp_system_chip.c:93

0x4037f8b9: __assert_func at /home/alonbl/esp-idf/components/newlib/assert.c:81

0x4037f596: insert_free_block at /home/alonbl/esp-idf/components/heap/tlsf/tlsf.c:358 (discriminator 1)
 (inlined by) block_insert at /home/alonbl/esp-idf/components/heap/tlsf/tlsf.c:388 (discriminator 1)
 (inlined by) block_trim_used at /home/alonbl/esp-idf/components/heap/tlsf/tlsf.c:517 (discriminator 1)
 (inlined by) tlsf_realloc at /home/alonbl/esp-idf/components/heap/tlsf/tlsf.c:1197 (discriminator 1)

0x4037e7ee: multi_heap_realloc_impl at /home/alonbl/esp-idf/components/heap/multi_heap.c:245

0x403760e8: heap_caps_realloc_base at /home/alonbl/esp-idf/components/heap/heap_caps.c:445

0x40376158: heap_caps_realloc at /home/alonbl/esp-idf/components/heap/heap_caps.c:479

0x4037618f: heap_caps_realloc_default at /home/alonbl/esp-idf/components/heap/heap_caps.c:259

0x4037f911: _realloc_r at /home/alonbl/esp-idf/components/newlib/heap.c:54

0x4200cee1: memcloser at /builds/idf/crosstool-NG/.build/xtensa-esp-elf/src/newlib/newlib/libc/stdio/open_memstream.c:282 (discriminator 4)

0x4200bf0a: _fclose_r at /builds/idf/crosstool-NG/.build/xtensa-esp-elf/src/newlib/newlib/libc/stdio/fclose.c:96 (discriminator 1)

0x4200bf8b: fclose at /builds/idf/crosstool-NG/.build/xtensa-esp-elf/src/newlib/newlib/libc/stdio/fclose.c:125 (discriminator 1)

0x4200803d: app_main at /home/alonbl/esp-idf/examples/system/console/basic/main/main.c:9

0x42017f97: main_task at /home/alonbl/esp-idf/components/freertos/app_startup.c:208

0x4037a2c1: vPortTaskWrapper at /home/alonbl/esp-idf/components/freertos/FreeRTOS-Kernel/portable/xtensa/port.c:137

Steps to reproduce.
Attached [1] a trivial example project.
Use:
idf.py set-target esp32s3
idf.py build

[1] example.zip
Debug Logs.
No response
More Information.
Turning off CONFIG_HEAP_TASK_TRACKING makes it work, so either the problem is in the task tracing or in the open_memstream(), I guess it is in the task tracing as it does work properly.
It is important as components/console/commands.c::esp_console_cmd_register() is using open_memstream() so any application with console support cannot be run with CONFIG_HEAP_TASK_TRACKING.

This is probably the same issue as https://github.com/espressif/esp-idf/issues/12498, given that there's a realloc in the backtrace.

Thanks!
Closed as dup of #12498


jsonschema dependency

In schema.py you import from jsonschema.protocols import Validator for the purposes of adding a type hint. As far as I can see, this is the only reason why you need to depend on jsonschema >=4. Unfortunately, the community has not been speedy on adopting jsonschema >=4 in many, many places (for instance here and here).
I was wondering if it makes sense to remove the type hint or at least have something like the following, and then drop the dependency for jsonschema back down to 3.x?
try:
    from jsonschema.protocols import Validator
except ImportError:
    from typing import Any
    Validator = Any

While not ideal, the way it is currently means that there is a lot of packages that cannot co-exist with jupyter in the conda ecosystem right now.

Resolved via #59.


How to use

How to use bro!!

How to fix this please creator explain

This is really confusing


Youtube Bridge min_duration and max_duration are broken

description: adding a value to either min_duration or max_duration will break the feed output.
To Reproduce
Steps to reproduce the behavior:

enter a valid channel id
add min_duration=1 or max_duration=400
click "html" output
no ouput
go back try without any value set for min_duration or max_duration and the feed shows up as expected

reproducible on several independent instances

Seems like there is also a problem on Youtub search ...

Will try to get a look at this, if nobody has done so before

Confirmed with channel id UC-4uelKAWhQCuktowofw4aA
Entering no min duration returns correctly the page
Entering min duration of 1 renders an empty page
Apache error logs indicates no specific error, but rather quite mundane log messages

Seems like there is a link with implementation of #670 by @LogMANOriginal : the skipFeeds() method seems to be called somewhere it shouldn't be. More precisely, check this line (in `bridges/YoutubeBridge.php#collectData()@236)
	if(!empty($url_feed) && !empty($url_listing)) {
		if(!$this->skipFeeds() && $xml = $this->ytGetSimpleHTMLDOM($url_feed)) {
			$this->ytBridgeParseXmlFeed($xml);

If I remove the $this->skipFeeds() call, all of a sudden, it starts to work (at least for users and channels).

If I remove the $this->skipFeeds() call, all of a sudden, it starts to work (at least for users and channels).
this is in essence what I wrote in the bug issue "5. go back try without any value set for min_duration or max_duration and the feed shows up as expected"
when you remove skipFeeds you basically remove duration filters and the entire feed shows as expected
I think the problem is here:
$durationText = trim($element->find('div.timestamp span', 0)->plaintext);
the div.timestamp span does not exists on the youtube page anymore
it should look for something like:
12:14

This bug been resolved ?

I cannot reproduce this issue on my private instance. It's possible that the error is the result of rate limiting or that it has been resolved.

still actual issue.
if min_duration/max_duration specified, feed is empty.
reproduced on rss-bridge version dev.2022-06-14 (git.master.936ae8c)

@em92, you marked as a maintainer of this bridge, could you take a look?

The problem is here:
diff --git a/bridges/YoutubeBridge.php b/bridges/YoutubeBridge.php
index 7aa101e7..0879c7dc 100644
--- a/bridges/YoutubeBridge.php
+++ b/bridges/YoutubeBridge.php
@@ -350,6 +350,9 @@ class YoutubeBridge extends BridgeAbstract
                 if (isset($jsonData->contents)) {
                     $channel_id = $jsonData->metadata->channelMetadataRenderer->externalId;
                     $jsonData = $jsonData->contents->twoColumnBrowseResultsRenderer->tabs[1];
+                    if (!isset($jsonData->tabRenderer->content->sectionListRenderer)) {
+                        throw new \Exception('Unable to parse json data');
+                    }
                     $jsonData = $jsonData->tabRenderer->content->sectionListRenderer->contents[0];
                     $jsonData = $jsonData->itemSectionRenderer->contents[0]->gridRenderer->items;
                     $this->parseJSONListing($jsonData);

@csisoap ping

The problem is here:
diff --git a/bridges/YoutubeBridge.php b/bridges/YoutubeBridge.php
index 7aa101e7..0879c7dc 100644
--- a/bridges/YoutubeBridge.php
+++ b/bridges/YoutubeBridge.php
@@ -350,6 +350,9 @@ class YoutubeBridge extends BridgeAbstract
                 if (isset($jsonData->contents)) {
                     $channel_id = $jsonData->metadata->channelMetadataRenderer->externalId;
                     $jsonData = $jsonData->contents->twoColumnBrowseResultsRenderer->tabs[1];
+                    if (!isset($jsonData->tabRenderer->content->sectionListRenderer)) {
+                        throw new \Exception('Unable to parse json data');
+                    }
                     $jsonData = $jsonData->tabRenderer->content->sectionListRenderer->contents[0];
                     $jsonData = $jsonData->itemSectionRenderer->contents[0]->gridRenderer->items;
                     $this->parseJSONListing($jsonData);

@csisoap ping

I have pushed a fix at #3192

The problem is here:
diff --git a/bridges/YoutubeBridge.php b/bridges/YoutubeBridge.php
index 7aa101e7..0879c7dc 100644
--- a/bridges/YoutubeBridge.php
+++ b/bridges/YoutubeBridge.php
@@ -350,6 +350,9 @@ class YoutubeBridge extends BridgeAbstract
                 if (isset($jsonData->contents)) {
                     $channel_id = $jsonData->metadata->channelMetadataRenderer->externalId;
                     $jsonData = $jsonData->contents->twoColumnBrowseResultsRenderer->tabs[1];
+                    if (!isset($jsonData->tabRenderer->content->sectionListRenderer)) {
+                        throw new \Exception('Unable to parse json data');
+                    }
                     $jsonData = $jsonData->tabRenderer->content->sectionListRenderer->contents[0];
                     $jsonData = $jsonData->itemSectionRenderer->contents[0]->gridRenderer->items;
                     $this->parseJSONListing($jsonData);

@csisoap ping

I have pushed a fix at #3192

it works, thank you, guys!


Why masterService in values.yaml ?

Hi all,
I read how this chart works and I don't understand why is there masterService in values.yaml.
Because service is defined with {{ template "uname" . }}-headless which is exactly the concatenation of clusterName  and nodeGroup  {{ .Values.clusterName }}-{{ .Values.nodeGroup }}.
In helpers :
{{- define "uname" -}}
{{ .Values.clusterName }}-{{ .Values.nodeGroup }}
{{- end -}}

In service.yaml :
kind: Service
apiVersion: v1
metadata:
  name: {{ template "uname" . }}-headless

But in statefulset.yaml :
          - name: discovery.zen.ping.unicast.hosts
            value: "{{ .Values.masterService }}-headless"

Feel free to reopen this issue if you still have questions.
An important note is that this no longer needs to be specified unless your using dedicated node groups and don't use master as the name of your master node group. https://github.com/elastic/helm-charts/pull/78


Required array fields cannot be used in type safe raw queries

Bug description

When using [] fields that are required, e.g.
model Lists {
  id           String     @id @default(cuid())
  strings      String[]
}

Trying to query against this model using Pydantic will cause an error, e.g.
model = await client.lists.create({})

# this will cause an error because `strings` is not allowed to be `None`
found = await client.query_first('SELECT * FROM Lists WHERE id = $1', model.id, model=Lists)

Expected behavior

An empty list should be set instead.

This was fixed in #484.


Add Slots generic parameter to DefineComponent

What problem does this feature solve?
Currently, to define a Vue component with typed slots, you can't use DefineComponent as the slots are manually set to Readonly<InternalSlots>.
A hacky workaround is to use a generator function that returns defineComponent(...).
The return type of this generator function is a constructor type which tries to emulate DefineComponent:

What does the proposed API look like?
For manually setting the type:
export createGenericListComponent<T extends { id: string }>(): DefineComponent<
  { items: T[] }, // Props
  { default: ({ item }: { item: T }) => VNode[] } // Slots
>

In the future it would be awesome, if Slots would be infered out of the template / render function.
Or a defineSlots<...>() macro could be provided instead, like with defineProps<...>()?

I also expect this feature to be implemented in the feature, especially slot can be infered out

FYI https://vue-macros.sxzz.moe/macros/define-slots.html


Support repo-config v0.9 properly

This repo recently moved to repo-config v0.9. While the dependabot PR for the upgrade passed, the release notes for repo-config suggest more changes. This commit tries to add these additional requirements for repo-config v0.9 upgrade.

Also I notice you didn't add the fix to have git-support in pyproject for the test-installation ci job.

It is because there is no test-installation step for this repo (which is by intention), so this step does not apply here.


Improve and distinguish different errors for IllegalInsertData

What type of enhancement is this?
API improvement
What does the enhancement do?
When implementing Erlang client for GreptimeDB, I found that the error message returned by server was confusing, especially the Illegal insert data.
It happens in several cases but doesn't contain a useful message.
https://github.com/GreptimeTeam/greptimedb/blob/2cf828da3c946f09c02a1779c18899970f0a6158/src/common/grpc-expr/src/insert.rs#L297
https://github.com/GreptimeTeam/greptimedb/blob/2cf828da3c946f09c02a1779c18899970f0a6158/src/common/grpc-expr/src/insert.rs#L331
Distinguishing different errors for IllegalInsertData will help users and SDK developers.
Implementation challenges
No response

@killme2008
I'd like to work on this. By the way, do we need to add unit tests for this?

@NiwakaDev Cool assigned it to you.
It would be great if you could add some unit tests for it, you can find some tests in https://github.com/GreptimeTeam/greptimedb/blob/develop/tests-integration/tests/grpc.rs


Stop calling Mirador a IIIF "reference implementation"

Because it's not, and there's (apparently) no will to make it one. Imagine all of these words linked to multi-year outstanding issues.  And then these words to issues being actively worked on that fall outside of the specifications.
This is what reference implementation means:
https://en.wikipedia.org/wiki/Reference_implementation

(Point made)

:+1:


Does not work for absolute file paths

Due to join being used here instead of using resolve.

Also it can generate hashes with 15 or less characters due to parseInt(out.join(""), 2).toString(16). I will add a fix for that in the same pull request.

Awesome, thanks @qgustavor !

I'll publish a new version - are you using this in a real project or were you just browsing?

I'm using it to deduplicate photos in a database for a government backed project.

That sounds great! Any chance I can mention that in the README?

That's fine. I only have the Instagram page of the project at the moment, the website is still in the works: https://www.instagram.com/pddugyn/ (I guess they removed all posts due to electoral laws requiring it since we will vote for a new mayor in October, so the city mall must not use their socials).


Better binding between repository definitions and content

For rpm-ostree, we encourage a model where a git repository stores both the equivalent of Dockerfile as well as the rpm-md .repo files.
atomic-reactor seems to take the .repos on the command line as a URL.  Unless the build system is in control over that URL, reproducibility goes out the window.  (Yes, I can find the URL from the build log, but it might change or go away, if it's e.g. stored in someone's Dropbox or whatever)
How about a model where the repositories are handled via ADD or something in Dockerfile, but they can be overridden as well by the build system based on repo ID?  (I may commit a .repo file for centos-7 into my git, but a production build system would want to override that with a URL to its local cache)

I'm sorry but I don't follow. Could you please provide an example?

At my employer we have a deployment of atomic-reactor, and we also have an internal file server http://people.example.com/~user.  A person doing a build uploaded a foo.repo file to http://people.example.com/~user/foo.repo, and did a build from there.
But the release engineering infrastructure isn't in control over that location.  It could change, be deleted etc. at any time by the builder.  That harms reproducibility.
At least I think the input .repo file should be expanded in the logs and/or exposed by the Koji task frontend as an artifact.
Even better would be requiring the.repo file to live in the same git repository as the Dockerfile, so they're both owned by the rel-eng infrastructure.

The reason we chose currently implemented solution is that koji verifies that all packages present in an image were built in koji (rpmqa plugin) and then koji verifies that those are signed with proper keys. Therefore we don't care about repos, we care about packages.
Also, this doesn't force you to use this feature. You can store the repo in git and then ADD it within dockerfile.

At least I think the input .repo file should be expanded in the logs and/or exposed by the Koji task
frontend as an artifact.

Very good suggestion, will do.
@pbabinca wanna weigh in?

It looks like logging the repo content is already handled.
Closing due to lack of interest and activity on the remaining of the request. If you're still interested feel free to reopen it.


Update use-case-diagram.rst

The commit currently has no changes. Is there anything else coming?

As the pull request does not contain any changes, I’m closing it now.


add aggregation model plugin

Types of changes

[x] Enhancement (project structure, spelling, grammar, formatting)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

A description of the changes proposed in the Pull Request
Adds a model that aggregates impact metrics for individual graph nodes. This model has to be included in the model pipeline for each node in order to aggregate the node's impacts. The metrics to aggregate are defined in the impl as aggregation-metrics.
There is the option to aggregate using an average (mean) but the default is to sum the impacts.
The aggregated values are returned as aggregate-metric, where metric is each of the given aggregation-metrics, w.f. aggregate-carbon, aggregate-energy etc.
contributes to https://github.com/Green-Software-Foundation/if/issues/273

Not actual since it's integrated directly into if.


Unautorized request does not return CORS headers

Hi!
When testing your code, everything seems to be fine, and I really like your solution over the more cumbersome alternative solutions, but there seems to be a problem when using CORS in case of an unauthorized request (401), possibly even all failed requests (4xx and 5xx):
When a request is made to a controller action decorated with [Authorize] and using an invalid or expired token, a 401 response is returned as expected, but the CORS headers are not being returned. This causes the client not being able to recognize the status code.
Steps to replicate:

Set up a Web.API project as described in your blog post
Install Microsoft.AspNet.WebApi.Cors (currently 5.2.6)
Enable it in WebApiConfig:

// Not restricting anything while debugging
var cors = new System.Web.Http.Cors.EnableCorsAttribute("*", "*", "*");
config.EnableCors(cors);

Decorate a controller action with [Authorize]
Make a call to the controller action from a different domain (or at least a different port), using an expired token
The response will be 401, but without CORS Headers

The cause is line 76:
return Task<HttpResponseMessage>.Factory.StartNew(() => new HttpResponseMessage(statusCode) { });
Changing this line to the following will solve the issue::
 return base.SendAsync(request, cancellationToken)
Since this solution pushes the request further down the pipeline, instead of immediately returning, this solution consumes more resources for each request, so this might not be the right solution for everybody. Alternatively one could manually add the missing headers before returning, but I don't think that would be a good idea.
Would you by any chance have a better solution for this problem?

Thanks . will look into it some time this week.

resolved this current comment. code checked in


Unable to compile

Can be compiled.
cd async-graphql
cargo build --all

Could not compile.
cd async-graphql/async-graphql-derive
cargo build

I don't know what makes this different.

This issue prevented us from releasing a new version, because the cargo package cannot pass.

compiles fine here...

seems that the update of the syn crate breaks things. I get std::cmp::Eq is not implemented for syn::ty::TypePath

But why “build all” works, it’s strange.

If you put this in Cargo.toml it works
syn = { version = "1.0.20", features = ["full", "extra-traits"] }

Tomorrow I try, I am now in drink. 😂

Do you want me to commit?

Yes.🤝

Alright!
You would not think that there is more features than "Full" :laughing: My guess is that its a cargo bug when some other crate compiles this feature cargo does not re-compile the crate without the feature.

@IcanDivideBy0 Now the tests faile with "async-graphql is not presetn in Cargo.toml. Could you look into? Its because of your latest commit.

@nicolaiunrein tests are fixed now

I leave this issue open for further investigation

Not sure if it relates to this issue. But unions seem to be broken. Union tests are working fine, but taking even the simple example from tests:
#[async_graphql::SimpleObject]
struct MyObj {
    id: i32,
    title: String,
}

#[async_graphql::Union]
enum Node {
    MyObj(MyObj),
}

and putting it somewhere else, gives me:
error: It should be a struct.
  --> tide/starwars/src/main.rs:24:1
   |
24 | / enum Node {
25 | |     MyObj(MyObj),
26 | | }
   | |_^

I tried it in my code using the latest version (1.11.3) and in the tide/starwars example (v 1.11.0). And I think interfaces are broken too.

The published version of union is not defined that way.

struct Node（ MyObj）
like this

So it is how it will be defined in the future version or what do you mean by published version? But this is how it's stated in the book and the union tests. It's a bit confusing.

They have been changed to Enums in #75 which got merged to the release branch after 1.11.3

Ok thanks, I've missed that. So I was just at the wrong place at the wrong time.

@krevativ I think you actually uncovered a problem with our current workflow. I'm going to look into updating the docs generation to only run when we tag

@krevativ Upgrade async-graphql to 1.12.1.


HV-1531 Regroup the ValidatorFactory scoped properties in ValidatorFactoryContext

https://hibernate.atlassian.net/browse/HV-1531

Jenkins, retest this please

Merged, thanks!

Nice, thanks @marko-bekhta!