Adjust integration test to not use XDM device details

Device details are already sent in Target Delivery API using well defined objects. We should not duplicate these details in the Delivery API parameters block.
Description

Related Issue

None
Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA or I'm an Adobe employee.
[ ] I have made any necessary test changes and all tests pass.
[ ] I have run the Sandbox successfully.

We've discussed this in Slack. We'll be adjusting the activity itself to be based on different XDM data fields.


[release/v2.6] HorizontalPodAutoscalers display metrics wrong

Rancher Server Setup

Rancher version: v2.6.3 (3c1d5fac3)
Installation option (Docker install/Helm Chart): Helm Chart

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): Kubespray

Proxy/Cert Details:

Information about the Cluster

Kubernetes version: v1.21.1
Cluster Type (Local/Downstream): Downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): Kubespray

User Information

What is the role of the user logged in: Admin

Describe the bug
In deployed HorizontalPodAutoscalers with two metrics, it displays duplicated value.
To Reproduce
Perform Deployment with two metrics(CPU and Memory)
apiVersion: autoscaling/v2beta2
kind: HorizontalPodAutoscaler
metadata:
  name: backend-app
spec:
  scaleTargetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: backend-app
  minReplicas: 1
  maxReplicas: 10
  metrics:
    - type: Resource
      resource:
        name: cpu
        target:
          type: Utilization
          averageUtilization: 80
    - type: Resource
      resource:
        name: memory
        target:
          type: Utilization
          averageUtilization: 80

Open tab HorizontalPodAutoscalers then open info about hpa
compare values with console kubectl get hpa backend-app
Result
In all metrics item rancher display CPU metrics displays
Expected Result
In CPU, the CPU target values and in Memory, memory target values should be shown.
Screenshots

Additional context

@izaac @sowmyav27 @slickwarren @anupama2501 - please check this issue

@vincent99 @izaac @sowmyav27 @slickwarren @anupama2501 @luthermonson @MbolotSuse also reproduced in v2.6.4

Reproduced on v2.6.8

@vincent99 @izaac @sowmyav27 @slickwarren @anupama2501 @luthermonson @MbolotSuse

can confirm, this is still an issue on v2.7.0-rc8.
Repro steps:

create a deployment with replica=2 using ranchertest/mytestcontainer

I also set container resource limits (1000 cpu and mem) and reserves (250 cpu and mem)

create an HPA targeting the deployment, specifying 80 utilization for CPU and 70 utilization for mem
wait for the HPA to get to an active state
observe that the mem and cpu usage is reported as the same

(cpu usage is much closer to 0)

observe that the mem and cpu usage is reported as the same

Why current CPU and current memory usage is equal on this page?(6938624)

closing in favor of existing filed issue: https://github.com/rancher/dashboard/issues/2555


How big project can be reasonably build with jab?

Hi,
I have been trying to find out how large project can jab support so I have created this branch: https://github.com/kiminuo/jab/tree/feature/di-boom (100 000 classes)
I'm unable to even build this. :-) So just out of curiousity, do you have any idea how large project can be used with jab? I'm after your gut feeling not that much about some precise numbers.
Thanks!
PS: I think that at this point I have hit .NET compiler limit and not really Jab's limit.

That's a great question and something that I haven't measured or optimized a lot in code.
I'm not sure we can achieve reasonable build times for 100 000 classes without some kind of a caching mechanism provided by C# compiler. At the same time, I'm confident the current source has a lot of inefficiencies that can be fixed.

I have created this branch https://github.com/kiminuo/jab/tree/feature/di-boom-no-reg which does not register classes to the container (as opposed to what https://github.com/kiminuo/jab/tree/feature/di-boom does) and .NET compiler can compile it just fine:
PS C:\temp\jab\src\samples\ConsoleSample> Measure-Command { dotnet build }

Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 6
Milliseconds      : 851
Ticks             : 68515706
TotalDays         : 7,93005856481481E-05
TotalHours        : 0,00190321405555556
TotalMinutes      : 0,114192843333333
TotalSeconds      : 6,8515706
TotalMilliseconds : 6851,5706

So unfortunately, it looks like this is on Jab's side. Not saying this is a common scenario to have 100,000 classes in a project but at least we have a rough estimate what is "too many".

Yep, Roslyn itself is way more optimized and well designed than Jab is. I'll keep this issue open to track perf optimization of the generation.

Looked into this. Actually, after some simple optimization in https://github.com/pakrym/jab/pull/70 Jab takes a reasonable 3sec to produce a generated file. What takes forever is roslyn trying to parse and compile the resulting 100MB service provider implementation.

ASP.NET Core has ~1500 (AddTransient|AddSingleton|AddScoped) calls across all sources and tests. I'd say 2000 a good baseline for too many services :).


Performances improvement

fixes #522

TODO:

[ ] Responsive map

Hmm, I actually kind of liked being able to see multiple players at once (easier to do direct comparisons)

Actually I think what we can do with this is make a separate tab called laning and just display a subset of data like stats@10.  We can keep the performance table as is (but remove the small map)


When page is viewed by owner show them how much they have contributed by owning the gorilla

@JasoonS Is this still applicable too?

Yes, this hasn't been implemented. Also the owner has to click the buy button to even show the gorrilla as theirs (by unlocking their ethereum account in metamask...)


[Perhaps just a configuration question] Cooperation with osc

For development on Open Build Service (OBS) (used for development of the openSUSE Linux distribution) we use specific custom versioning system (which I hate, but that's besides the point here), which leaves in the root of every project directory .osc/. So, of course I have let g:rooter_patterns+=['.osc/'] in my ~/.vim/vimrc.
However, that is not perfect solution. Substantial part of my work on the projects we need to work with expanded tarballs and modifying patches for the individual packages. We use quilt for that. When I expand the tarball with quilt I get subdirectory with the name of the tarball, which has always subdirectory patches/.
So, for example. There is a directory Factory/python/ which has a subdirectory .osc/ (i.e., Factory/python/.osc/) and the expanded tarball is in Factory/python/Python-2.7.17/ and there is always subdirectory patches/ in it (i.e., Factory/python/Python-2.7.17/patches/). Obviously, the root of this expanded tarball should be in Factory/python/Python-2.7.17/.
I guess, something like let g:rooter_patterns+=['.osc/../*/patches/', '.osc/'] is not possible, right? Would it be possible to delegate the decision to some custom-made function, where I could apply this more complicated logic? How to hook up vim-rooter with some custom function (kind of reverse of what FindRootDirectory())?

I would think this should work: let g:rooter_patterns=['patches/', '.osc/'] – unless you have patches/ directories elsewhere that shouldn't trigger vim-rooter.
Also, if you're setting g:rooter_patterns in your vimrc, you'll need = not += but I'm sure that's a typo; Vim would complain if you actually did that.

I would think this should work: let g:rooter_patterns=['patches/', '.osc/'] – unless you have patches/ directories elsewhere that shouldn't trigger vim-rooter.

That’s actually a great idea, thank you. So simple!

Also, if you're setting g:rooter_patterns in your vimrc, you'll need = not += but I'm sure that's a typo; Vim would complain if you actually did that.

Yes, I have found out. What I wrote here was just lovely dream, which didn’t materialize unfortunately.

python@stitny$ ls -ld Python-2.7.17/patches
lrwxrwxrwx 1 matej users 2 Feb  8 23:16 Python-2.7.17/patches -> ..
python@stitny$ ls -ld .osc
drwxr-xr-x 2 matej users 4096 Feb  8 23:30 .osc
python@stitny$ grep rooter ~/.vim/vimrc
" for vim-rooter
let g:rooter_change_directory_for_non_project_files = 'current'
let g:rooter_patterns=['.git', '.git/', '_darcs/', '.hg/', '.bzr/', '.svn/', 'patches', '.osc/']
let g:rooter_use_lcd = 1
let g:rooter_resolve_links = 0
let g:rooter_silent_chdir = 1
python@stitny$ vim Python-2.7.17/Lib/opcode.py
python@stitny$

When I open vim (actually neovim) with the above mentioned command, I get :pwd giving me /home/matej/build/devel:languages:python:Factory/python, not expected /home/matej/build/devel:languages:python:Factory/python/Python-2.7.17.

Does the  root Factory/python/ directory contain any of .git, .git/, _darcs/, .hg/, .bzr/, or .svn/?  vim-rooter does a depth-first (height-first?) search over the patterns, not a breadth-first search.
It should be patches/.
Is this saying the patches/ directory is a symlink?  Python-2.7.17/patches -> ..

Does the root Factory/python/ directory contain any of .git, .git/, _darcs/, .hg/, .bzr/, or .svn/? vim-rooter does a depth-first (height-first?) search over the patterns, not a breadth-first search.

It contains .osc/ directory, nothing else.

It should be patches/.

Even when it is a symlink?

Is this saying the patches/ directory is a symlink? Python-2.7.17/patches -> ..

Yes.

As per https://github.com/airblade/vim-rooter/issues/98#issuecomment-495164169, I think vim-rooter is correctly finding the patches symlink; but when Vim looks for the parent of patches, it actually looks for the parent of the directory patches links to.
There isn't much we can do about this without making the plugin a lot more complicated.

As per #98 (comment), I think vim-rooter is correctly finding the patches symlink; but when Vim looks for the parent of patches, it actually looks for the parent of the directory patches links to.

But, I have let g:rooter_resolve_links = 0 so it shouldn’t resolve the symlink, should it?

That option applies to the file you are opening, not the rooter pattern(s).  If a rooter pattern is a link, Vim automatically resolves it.
Here's an example.
$ mkdir -p p/q
$ mkdir -p a/b
$ touch p/q/foo
$ ln -nfs p/q a/b/c
$ tree
.
├── a/
│   └── b/
│       └── c -> ../../p/q/
├── p/
│   └── q/
│       └── foo
$ vim
:echo fnamemodify('a/b/c/', ':p')
" p/q  (not a/b/c)

Vim-rooter finds patches/ on the file system as expected but reads it as .. i.e. Python-2.  It's not possible to stop vim resolving the link.

It's not possible to stop vim resolving the link.

Well, it is all in https://github.com/airblade/vim-rooter/blob/8a0a201a17fae3f7656b99f74d67741986faba37/plugin/rooter.vim#L104 , isn’t it?
Couldn’t this function be modified, so it would check whether one patterns is a symlink and behave better?

I have just changed vim-rooter's implementation (9b1fc7a) so it supports globs and breadth-first search.  Please could you update and let me know whether it solves your problem?

Wow! It seems like working with this configuration:
" for vim-rooter
" Change to file's directory (similar to autochdir).
let g:rooter_change_directory_for_non_project_files = 'current'
let g:rooter_patterns += ['patches', '.osc/']
let g:rooter_use_lcd = 1
let g:rooter_resolve_links = 0
let g:rooter_silent_chdir = 1

Actually. Not exactly. The directory layout is thus:
python-bidict@stitny$ tree -d -A .
.
└── bidict-0.19.0
    ├── assets
    ├── bidict
    ├── bidict.egg-info
    ├── docs
    │   └── _static
    └── tests
        └── properties

When I cd bidict-0.19.0 and just open vim, then :pwd gives me /home/matej/build/devel:languages:python/python-bidict/bidict-0.19.0, which is correct. But when I start in that directory vim README.rst, then pwd gives me /home/matej/build/devel:languages:python/python-bidict/bidict-0.19.0, which is obviously wrong.

OK, now, I am confused. It seems to work now. Let me play with it a little bit more, and I will reopen eventually.


Fixed incorrect amount and Judo ID response mapping.

Incorrect mappings:

judoId - expected NSString, but got an NSNumber;
originalAmount - expected JPAmount, but got an NSString;
netAmount - expected JPAmount, but got an NSString;

Brain died and didn't think this through.


Cannot install node 18.12.1

Description:
I can't setup node version 18.12.1, seems like the installation was failed.
Attempting to download 18.12.1...
Acquiring 18.12.1 - x64 from https://github.com/actions/node-versions/releases/download/18.12.1-3486235546/node-18.12.1-linux-x64.tar.gz
Received HTTP status code 403.  This usually indicates the rate limit has been exceeded
Falling back to download directly from Node
Acquiring 18.12.1 - x64 from https://nodejs.org/dist/v18.12.1/node-v18.12.1-linux-x64.tar.gz
Extracting ...
/bin/tar xz --strip 1 --warning=no-unknown-keyword -C /home//ghub-runner-02-1/_work/_temp/feda96cb-2999-4572-97c8-82edc9eae7d5 -f /home//ghub-runner-02-1/_work/_temp/1b12f401-bf01-4e4c-aea0-ddab8ea827b8
Adding to the cache ...
Done
Environment details:
Warning: /home//ghub-runner-02-1/_work/_tool/node/18.12.1/x64/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /home//ghub-runner-02-1/_work/_tool/node/18.12.1/x64/bin/node)
node:
Warning: node: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.28 not found (required by node)
npm:
Warning: node: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.28 not found (required by node)
And then when I tried to use it
Run: npm config set proxy $CONDUCTOR_PROXY_FULL
node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by node)
Action version:
V 3.5.1
Platform:

[X] Ubuntu
[ ] macOS
[ ] Windows

Runner type:

[ ] Hosted
[X] Self-hosted

Tools version:
npm: 8.19.2
Repro steps:

name: "Setup Node"
uses<EMAIL_ADDRESS>with:
node-version: '18.12.1'
name: "Install dependencies"
run: |
npm install

Expected behavior:
Node with version 18.12.1 installed and working
Actual behavior:
Cannot execute any command, the error occurs.

Hello @Andrurodr. Thank you for your report. Which version of ubuntu do you use ?

Hello ! I'm using Ubuntu 18.04.5

I think it is an expected behaviour. We have similar issue related to this https://github.com/actions/setup-node/issues/507. Node 18 is compatible with Linux distributions based on GLIBC 2.28 or later but Ubuntu 18.04 uses older one.
For now I'm going to close the issue because the issue comes from the system.

@dmitry-shibanov I'm facing this issue as well trying to build a self hosted runner on ubuntu 22.04. using actions/setup-node@v3 to install node 18 yields the same glibc error here, even though the image is supposed to have a higher version glibc (2.35 I believe)

Hello @francois-codes. I've tried to reproduce the issue but everything works as expected. I think it is an issue with your set up of image.

@dmitry-shibanov yes, thank you, I found the problem was that while I was pushing new images, github was still trying to use older outdated images. It works fine and the issue I had was not related to this repo


Bug in PaymentRequest class in lib/paymentrequest.py

From lib/paymentrequest.py at line 187:
class PaymentRequest:

    def __init__(self, data, error=None):
        self.raw = data
        self.error = error
        self.parse(data)
        self.requestor = None # known after verify
        self.tx = None

    def __str__(self):
        return self.raw

^ self.raw above is sometimes a bytes object. This causes python runtime to throw an exception when doing str(request) on a PaymentRequest object (see #770).
I would like to fix this -- (perhaps if isinstance(self.raw, bytes).. bla).  Or some other approach.
So.. what's the deal here? Suggestions? Should I just fix it by detecting bytes and encoding to string?

Is it possible to do:
return str(self.raw)

Yes. Why not?
Wanted a sanity check on it. I'll double-check tomorrow if any code even calls this function (I suspect it doesn't, else we would have seen this earlier).  So yeah I'll probably fix this tomorrow, then. Thanks for looking at this too.

It does seem a bit cheeky :stuck_out_tongue:

Do you know if there is a reason why self.raw is sometimes bytes? Does it make sense to fix that instead and assert that it is a string?

Despite my needing to go to bed, I couldn't resist.
It turns out this is definitely a bug.  Sometimes the attr is an str, sometimes a bytes object.  The fix of str(self.raw) is definitely the way to go.
This bug exists in upstream as well.  I'll be sure to inform them about it.

Oh -- hey Marcel. Didn't see your question.
Actually on closer inspection and from my reading of the code it's supposed to be a bytes object.  The function at the top of the file: get_payment_request basically is responsible for writing to self.raw.  If you read the codepath it puts a bytes object in there in every branch.
So yeah no need to enforce it be a string -- it looks like other code expects a bytes object there.
But good suggestion otherwise (if the above were not the case that would have been the good approach).

Guys let's not just push random stuff.  Raw as the name clearly indicates it's bytes.

This isn't "random stuff".  Keep up.  If you don't know what's going on, don't say negative stuff, please.
It's demoralizing.
In a python str class method you can't return bytes.  You have to return string.. else you get a TypeError exception.
This isn't random stuff.  This fixes a crash I got on iOS.
The class was buggy. This fixes it.

It does make sense that self.raw is bytes, but why implement __str__ in the first place? I'm assuming it was just for debugging

Right you are.     It's just for debugging.  But -- you know -- might as well fix it since it's clearly not to spec.. even for debugging. :)


fluorinates

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[f]

/trunk merge


Reproducable crash with pyo3 and tensorflow

Bug Description
We encountered a very similar sounding issue to #2032 #1623 - but "luckily" for us the crash happens quite reliably!
It doesn't seem specific to tensorflow as it seems to crash similarly with some pytorch code
Steps to Reproduce
Create simple project, and virtual env with tensorflow (pandas also included as it was in the original Python snippet, but I don't think it is relevant)
$ cargo new --bin pyo3_tf_crash
$ cd pyo3_tf_crash/
$ python -m venv _venv
$ source _venv/bin/activate
$ pip install tensorflow pandas

$ cat Cargo.toml
[package]
name = "pyo3_tf_crash"
version = "0.1.0"
edition = "2021"

[dependencies]
pyo3 = {version = "0.17.1", features = ["auto-initialize"]}

And finally, src/main.rs
use pyo3::prelude::*;

static CODE: &'static str = r#"import pandas
d = [
    {'status': 'a', 'title': 'title 1'},
    {'status': 'b', 'title': 'title 2'},
]

data = pandas.DataFrame(d)
sentiment_label = data.status.factorize()

maxlen = 30

from tensorflow.keras.preprocessing.text import Tokenizer
from tensorflow.keras.preprocessing.sequence import pad_sequences
from tensorflow.keras.models import Sequential
from tensorflow.keras.layers import LSTM,Dense, Dropout, SpatialDropout1D
from tensorflow.keras.layers import Embedding

tokenizer = Tokenizer(num_words=5000)
tokenizer.fit_on_texts(data.title.values)

encoded_docs = tokenizer.texts_to_sequences(data.title.values)
padded_sequence = pad_sequences(encoded_docs, maxlen=maxlen)

vocab_size = len(tokenizer.word_index) + 1

embedding_vector_length = 32
model = Sequential()
model.add(Embedding(vocab_size, embedding_vector_length, input_length=maxlen))
model.add(SpatialDropout1D(0.25))
model.add(LSTM(50, dropout=0.5, recurrent_dropout=0.5))
model.add(Dropout(0.2))
model.add(Dense(1, activation='sigmoid'))

model.compile(loss='binary_crossentropy',optimizer='adam', metrics=['accuracy'])

history = model.fit(padded_sequence, sentiment_label[0], validation_split=0.2, epochs=2, batch_size=32)
"#;

fn start_py_thread() {
    std::thread::spawn(move || loop {
        use pyo3::prelude::*;
        Python::with_gil(|py| {
            py.run(CODE, None, None).unwrap();
        });
    });
}

fn main() {
    // Acquire then drop GIL
    let gil = Python::acquire_gil();
    std::mem::drop(gil);

    // Start thread doing Python things
    start_py_thread();

    loop {
        println!("Waiting");
        std::thread::sleep(std::time::Duration::from_secs(1));
    }
}

Run the script, and when the model fitting runs for the second time, it will crash (usually a segfault, but I think may occasionally either abort or deadlock)
$ cargo run
   Compiling pyo3_tf_crash v0.1.0 (/home/dbr/Desktop/pyo3_tf_crash)
warning: use of deprecated associated function `pyo3::Python::<'py>::acquire_gil`: prefer Python::with_gil
  --> src/main.rs:56:23
   |
56 |     let gil = Python::acquire_gil();
   |                       ^^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

warning: `pyo3_tf_crash` (bin "pyo3_tf_crash") generated 1 warning
    Finished dev [unoptimized + debuginfo] target(s) in 0.77s
     Running `target/debug/pyo3_tf_crash`
Waiting
Waiting
Waiting
Waiting
Waiting
[...]
Waiting
Epoch 1/2
Waiting
Waiting
Waiting
Waiting
Waiting
Waiting
1/1 [==============================] - ETA: 0s - loss: 0.6860 - accuracy: 1.0000Waiting
1/1 [==============================] - 8s 8s/step - loss: 0.6860 - accuracy: 1.0000 - val_loss: 0.7145 - val_accuracy: 0.0000e+00
Epoch 2/2
1/1 [==============================] - 0s 101ms/step - loss: 0.6703 - accuracy: 1.0000 - val_loss: 0.7226 - val_accuracy: 0.0000e+00
Waiting
Epoch 1/2
Segmentation fault

Backtrace
#0  __GI___pthread_mutex_lock (mutex=0x1b0) at ../nptl/pthread_mutex_lock.c:67
#1  0x00007ffff7bc3fac in ?? () from /lib/x86_64-linux-gnu/libpython3.9.so.1.0
#2  0x00007ffff7bc443e in PyEval_AcquireThread () from /lib/x86_64-linux-gnu/libpython3.9.so.1.0
#3  0x00007fffa3328195 in pybind11::gil_scoped_acquire::gil_scoped_acquire() () from /home/dbr/Desktop/pyo3_tf_crash/_venv/lib/python3.9/site-packages/tensorflow/python/client/_pywrap_tf_session.so
#4  0x00007fffa3345b5c in pybind11::cpp_function::initialize<pybind11_init__pywrap_tf_session(pybind11::module_&)::{lambda(TF_Operation*, char const*)#25}, pybind11::object, TF_Operation*, char const*, pybind11::name, pybind11::scope, pybind11::sibling>(pybind11_init__pywrap_tf_session(pybind11::module_&)::{lambda(TF_Operation*, char const*)#25}&&, pybind11::object (*)(TF_Operation*, char const*), pybind11::name const&, pybind11::scope const&, pybind11::sibling const&)::{lambda(pybind11::detail::function_call&)#3}::_FUN(pybind11::detail::function_call&) () from /home/dbr/Desktop/pyo3_tf_crash/_venv/lib/python3.9/site-packages/tensorflow/python/client/_pywrap_tf_session.so
#5  0x00007fffa33468fc in pybind11::cpp_function::dispatcher(_object*, _object*, _object*) () from /home/dbr/Desktop/pyo3_tf_crash/_venv/lib/python3.9/site-packages/tensorflow/python/client/_pywrap_tf_session.so
#6  0x00007ffff7b2dc93 in ?? () from /lib/x86_64-linux-gnu/libpython3.9.so.1.0
#7  0x00007ffff7ae7a50 in _PyObject_MakeTpCall () from /lib/x86_64-linux-gnu/libpython3.9.so.1.0
#8  0x00007ffff7a992f2 in _PyEval_EvalFrameDefault () from /lib/x86_64-linux-gnu/libpython3.9.so.1.0
[...]

Your operating system and version
Linux/Debian 11 Bullseye
Your Python version (python --version)
Python 3.9.2
Your Rust version (rustc --version)
rustc 1.62.0
Your PyO3 version
0.16.4 and 0.17
How did you install python? Did you use a virtualenv?
Using system Python via apt, virtualenv used as per repo-steps
Additional Info
Haven't tested the trimmed down reproduction example on Windows, but the code in it's original application crashed on both Linux and Windows

Oh just noticed Python::acquire_gil(); is deprecated in 0.17 - but changing it to Python::with_gil(|_py|{}); crashes identically

Thank you for sharing this - I'll try to have a play with this in the next week or two and see if I can deduce anything.

With apologies it's taken me a long time to get around to testing this. I've just done so on both Windows and Linux with the latest tensorflow and PyO3 main, and I don't get a segfault.
Instead I get a deadlock at this line:
model.add(Embedding(vocab_size, embedding_vector_length, input_length=maxlen))

Just copy-pasting that script twice doesn't deadlock, so I suspect there's some interaction with py.run which is trigering this. We've had some other recent reports of issues with py.run (#2891, #2927). I think this one will need some debugging, I'll try and take another look soon.

I was having a problem that looks like this, fixed by importing pytorch on main rust thread/before spawning threads.

I also ran into a similar issue with PyTorch. This is a more-or-less minimal example that causes a crash (STATUS_HEAP_VIOLATION) which goes away if I first import torch in the main thread.
use pyo3::Python;
use std::{thread, time::Duration};

fn main() {
    Python::with_gil(|py| {
        // Adding `import torch` below fixes the issue
        // Python::run_bound(py, "import torch; print('Hello from Python')", None, None).unwrap();
    });

    thread::spawn(|| loop {
        run_pytorch_thing()
    });

    loop {
        thread::sleep(Duration::from_secs(1));
        print!(".")
    }
}

fn run_pytorch_thing() {
    Python::with_gil(|py| {
        Python::run_bound(
            py,
            r#"
import torch
import tempfile
import os

layer = torch.nn.Linear(3, 2)
x = torch.tensor([1.0, 2.0, 3.0])

temp_path = os.path.join(tempfile.gettempdir(), 'weights.pt')
torch.save(layer.state_dict(), temp_path)
print(f'Saved weights to: {temp_path}')

new_layer = torch.nn.Linear(3, 2)
new_layer.load_state_dict(torch.load(temp_path, weights_only=True))
loaded_output = new_layer(x)
print(f'Loaded output: {loaded_output}')
os.remove(temp_path)
            "#,
            None,
            None,
        )
        .unwrap();
    });
}

Cargo.toml:
[dependencies]
pyo3 = { version = "0.22.6", features = ["auto-initialize"] }
# or
# pyo3 = { version = "0.23.1", features = ["auto-initialize"] }

I'm not sure if the problem is directly related to loading weights or if this could be simplified, but it doesn't seem to appear when I just run basic pytorch operations (e.g. multiplying a few tensors together).
This is with PyTorch 2.4.0, Python 3.12.3 on Windows 11 (x64)


Replaced Ansible 2.2 specific check_mode: no

Replaced Ansible 2.2 specific check_mode: no with backwards compatible always_run: yes

Is ansible 2.2 an issue for you? Which ansible version do you use?

Seeing the ERROR: check_mode is not a legal parameter in an Ansible task or handler failure on openstack-ansible mitaka and newton which are pinned at <IP_ADDRESS>.

Alright, let's keep always_run then.
OpenStack guys, are you done with ansible 1.9.4?

liberty: v1.9.4-1
mitaka: stable-1.9 (819c51c)
newton: <IP_ADDRESS>
ocata: <IP_ADDRESS>
So.. it's getting there but I expect most folks are still on 1.9.

@Logan2211 alright thanks.

Thanks!  I was running Ansible 2.1.2 because I was just being lazy and didn't upgrade yet.  @leseb what versions of Ansible do we officially support?

Master and v2.0 aim for 2.2 support.

OK.  I'll switch to 2.2.0 now.  Hopefully it doesn't have as many bugs as 2.1.0

@jsaintrocc no sure about this... I'm already blocked in https://github.com/ceph/ceph-ansible/pull/995 because of a bug in 2.2 and this feature is so crucial for us :(


[WIP] [Core] Setup umd build

Resolves #262
Hi first time contributor here,
npm run build:umd script creates a standalone MaterialUI.js in the build/umd dir. Likewise npm run build:min creates a minified version MaterialUI.min.js.
I tried including it in a script tag and the components were available under the MaterialUIobject, but I haven't tested it completely. Is this sufficient?
I included react-tap-event-plugin as an external, though I'm not sure if it has an external build. Should it remain?

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@ANich Nice work.
One thing I think is important however we arrive at it is allow the component imports defined in the examples to work as-is. This way we will be able to push them as-is to codepen or similar via API without having to rewrite the imports (although we'll still need to take care of putting the theme on context).
@EloB did something similar to that here: https://github.com/callemall/material-ui/issues/3997#issuecomment-210472322 (explanation is a couple of comments down).

Hey @mbrookes thanks!
Hmm, did you mean some way to get all of the components available under the window instead of a MaterialUI object? See 1f4165c , index.umd.js exports getMuiTheme and MuiThemeProvider
Related: is exporting all of these from index.umd.js fine? They are exposed as MaterialUI.getMuiTheme etc.

Hmm, did you mean some way to get all of the components available under the window instead of a MaterialUI object?

I'm not sure if that's possible (but what do I know?!), and if we're going to have to do some kind of inline code-mode on the docs site examples when they are pushed to the codepen API in order to get them working with a standalone build, it may not matter so much what the imports look like.
However, @EloB's approach means that the import at least resembles something that would work (albeit inefficiently without tree shaking) if you were to copy them from codepen into a local project:
import { Tabs, Tab } from 'material-ui';

@ANich Could you post a link to this working in codepen or jsfiddle or similar?
I uploaded the umd lib to a branch on my repo, and tried to access it via rawgit.com in a copy of @EloB's fiddle, but couldn't get it to recognise the imports.

Here's @EloB's version working with the Card example from the docs site.
To make the examples work, all we'd need to do is:

replace the import directory 'material-ui/ComponentName' with 'material-ui' for any components used
add the react-dom and react-tap-event-plugin imports,
add a call to injectTapEventPlugin();
and replace the export with:

ReactDOM.render((
React.createElement(ExampleName)
), document.getElementById('someId'));

Should be possible to do that on the fly, but worst case we can have a build script that converts the examples as part of the docs site build.

@mbrookes

Is that even possible? :)

No idea :sweat_smile:
I'm not exactly sure what you mean by:

One thing I think is important, however we arrive at it, is allow the component imports currently defined in the examples to work as-is.

By as-is do you mean verbatim?

However, if we're going to have to do some kind of inline code-mode on the docs site examples when they are pushed to the codepen API in order to get them working with a standalone build, it may not matter so much what the imports look like.

@ANich Could you post a link to this working in codepen or jsfiddle or similar?

Sure thing: https://jsfiddle.net/jfr174ck/2/
I took the first example from the usage page and ran it through the babel repl.
This was my interpretation of what someone might write if they were using the umd build without babel or any other node technology in their workflow. That being said, React, ReactDOM must also be included separately and babel would have to be included separately from a CDN or js file to access imports or jsx.
Here's my rawgit URL
(Rawgit is pretty cool thanks for the new tool!)

@mbrookes With @ANich latest push, we should have all of the components and style related files exported under index (in his new index.umd.js). So you should be able to import everything you need (including things like MuiThemeProvider) from material-ui or in another words (MaterialUi.MuiThemeProvider)
Also, in the umd build, react-tap-event-plugin is now bundled and injectTapEventPlugin() is automatically called (this is because there isn't a browser build for react-tap-event-plugin).
What do you think of this approach?

Should be possible to do that on the fly, but worst case we can have a build script that converts the examples as part of the docs site build.

I agree, sounds like a good build related activity. If the approach for making the browser build looks good, maybe we could merge this first. That way we can get it up in a CDN for our next release and start sorting out codebin integration.

@ANich Looks like there is some interesting behavior when we click the Button, getting some errors in the console. Not sure if it's code or build related yet...mmmm

@ANich Looks like there is some interesting behavior when we click the Button, getting some errors in the console. Not sure if it's code or build related yet...mmmm

@newoga Yeah you're right. Also for some reason, I couldn't reproduce the errors on Firefox.
For reference, these are the errors on Chrome:
react.js:19106 Uncaught Invariant Violation: addComponentAsRefTo(...): Only a ReactOwner can have refs.

What do you think of this approach?

TBH I much prefer the resulting code in codepen using the alternate approach. It bears a much closer resemblance to the original examples, having ES6 imports, and will make it easier to go both directions - taking a modified example from codepen and dropping it back into the docs site for further testing and development when fixing an issue in with a Material-UI component.

This was my interpretation of what someone might write if they were using the umd build without babel or any other node technology in their workflow.

Are you suggesting this might be used outside of code play-pens? Material-UI isn't intended to be used as a monolithic lib, so to me the primary use-case is pretty clear, and we should be developing towards that, rather than a hypothetical user who don't want to use build tools. If their own code is so simple that it doesn't need to be modular, then dragging a 1.5MB library along for the ride would be crazy. 😜

@mbrookes This PR isn't about modifying examples, just creating the browser build of Material-UI (which is a stepping stone to using it for examples on sites like codebin and jsfiddle). How this is currently setup is pretty much how every other React project creates their browser build. It's up to the user to include additional dependencies like React, and babel if they want to use ES6.
Maybe I'm not understanding what alternative approach your are suggesting. Could you re-explain? :)

@newoga

This PR isn't about modifying examples, just creating the browser build of Material-UI

To use with the examples. In codepen.
So how the build is generated, and what the resulting imports look like when used in a code play-pen is absolutely relevant.

Maybe I'm not understanding what alternative approach your are suggesting.

The one that results in a browser build that can be used like this:
https://github.com/callemall/material-ui/pull/4342#issuecomment-221972953

@mbrookes Your requirements (and codepen compatibility) is satisfied by this PR minus a few differences, which is why I'm confused what you're asking for?

replace the import directory 'material-ui/ComponentName' with 'material-ui' for any components used

That's done. All components and files underneath styles are now accessible under material-ui. This is being done in index.umd.js.

add the react-dom and react-tap-event-plugin imports,
add a call to injectTapEventPlugin();

That's fine, provided the user loads react and react-dom themselves. Call to injectTapEventPlugin() isn't necessary with this alternative build because it is included and ran for you. This is the only difference as far as I can see with what you suggested.

and replace the export with:

That's also not a problem.

The only problem I think we have is related to an error we're getting in some browsers (which I think is related to material-ui's use of react-addons-transition-group. We'll probably have to require react-with-addon.js browser build instead and make react-addons-transition-group external in the webpack build as well.

Your requirements (and codepen compatibility) is satisfied by this PR minus a few differences, which is why I'm confused what you're asking for?

No, it's me that's confused. 😜  Webpack is a black art (that I haven't studied), so I can only base my assessment on the end result, rather than the webpack config, which is why I asked for a working jsfiddle.
I should probably have linked to my codepen or jsfiddle rather than the comment, but the main difference between the two that I'm concerned about is this:
<MaterialUI.RaisedButton label="Default" />

(or this:)
const {RaisedButton} = MaterialUI;

<RaisedButton label="Default" />

instead of this:
<RaisedButton label="Default" />

Ping @ANich / @newoga

@ANich Can you fix that react-addons-transition-group issue if you haven't done so already?

We also need to decide what the target directory should be - build is for the NPM package.

We also need to decide what the target directory should be - build is for the NPM package.

I agree. 👍 I've seen /dist used in another projects for this type of build.

@newoga Sounds good. Also, what about the object name? MUI?

@newoga Sounds good. Also, what about the object name? MUI?

I don't have a strong opinion about that one. I find most projects just pick the pascal case of their package name. But I wouldn't argue if the consensus was leaning towards something else.

If that's the norm, I'm fine with that.

If that's the norm, I'm fine with that.

@mbrookes  I've left it as MaterialUI per Pascal Case

We also need to decide what the target directory should be - build is for the NPM package.

I agree. :+1: I've seen /dist used in another projects for this type of build.

I've changed the directory to dist and added it to the .gitignore,
See 342f497

@ANich Can you fix that react-addons-transition-group issue if you haven't done so already?

@newoga I'm not 100% sure where to go with this, I've tried using react-with-addons.js instead of the regular package and added react-addons-transition-group as an external in webpack. See: https://jsfiddle.net/jfr174ck/9/ Still investigating..
This might be useful, changing the order of the external scripts (MaterialUI.js before react-dom.js) changes the error but the animation still doesn't fire. https://jsfiddle.net/jfr174ck/8/

@ANich Interesting. I just noticed we also have react-addons-create-fragment as a dependency. Maybe that needs to be external too. I'll try your branch a little later and give it a try.
In package.json:
    "react-addons-create-fragment": "^15.0.1",
    "react-addons-transition-group": "^15.0.1",

@newoga @mbrookes @ANich
I got this working by adding the following externals:
(fiddle: https://jsfiddle.net/xyLye7jn/1/)
      'react-addons-transition-group': {
        root: ['React', 'addons', 'TransitionGroup'],
        commonjs2: 'react-addons-transition-group',
        commonjs: 'react-addons-transition-group',
        amd: 'react-addons-transition-group',
      },
      'react-addons-create-fragment': {
        root: ['React', 'addons', 'createFragment'],
        commonjs2: 'react-addons-create-fragment',
        commonjs: 'react-addons-create-fragment',
        amd: 'react-addons-create-fragment',
      },

@ANich any desire to finish this up? it's 20 lines of code away.

@nathanmarks Yeah definitely, thanks for taking a look. I'll update the PR in a day or two when I get a chance!

@nathanmarks @newoga @mbrookes Updated the code :+1:   https://jsfiddle.net/jfr174ck/12/
I did a rebase and pushed to my branch, do I need to anything else to get this merged?

What is missing in this to be merged? :)

The versions generated with this are going the version that will eventually go to CDNS?

Ping @nathanmarks @newoga @mbrookes

Just tested this and seems like there is a problem:
MaterialUI.js:79 Uncaught TypeError: Cannot redefine property: MuiThemeProvider

MuiThemeProvider is exported both from index.js and styles/index.js so the UMD wrapper tries to export it twice, which fails.
Perhaps stuff from styles should be exported under different var (MaterialUIStyles) or under a property in the main var (MaterialUI.Styles)?

Can be used to generate rollp.js it

I tried this but I am getting errors when I load the module. Also npm install && npm run build:umd is broken as of 4 days ago since the react-tap-event-plugin updated.
If I load the MaterialUI.js as text/babel it gives error Cannot find class React.
If I load it as text/javascript it gives error, "Uncaught TypeError: Cannot redefine property: MuiThemeProvider" On line 79 of MaterialUI.js  "Object.defineProperty(exports, key, {"

@nealeu Do icons and touch events work for you?  Im thinking if I should just try and apply this umd build patch to the next branch, which removes reacttouchevents and uses onClick.

@vans163 So far, yes.  The only issue I've found so far is with un-docked Drawer.  swipe to open and close work okay, but click on overlay to dismiss doesn't work.  I'm adding an explicit close icon at the top of in the menu to deal with that.

@nealeu Good to know it can actually work.  I will just to apply this to the next branch and see if the switch to using onClick fixes the undocked Drawer issue.

Hi,
I agree.  It took me longer than you to hit problems, but  Material UI is broken without onTouchTap (e.g. Snackbar action uses it and does not provide an onClick alternative).
My feeling on this is that Material UI should work fully with onClick so that it's desktop compatible.
I think a separate pull request is needed which is to use onClick in the places it is needed.
I'll start one.

@nealeu The 'next' branch I think is the one that uses onClick in most places, even though its called onTouchTap (for backwards compatibily as I understand it), it has no dependency on react-tap-event-plugin. But the next branch is totally undocumented and when I switch to it with my working code, it just rendered a blank page.

@vans163 Ah thanks.  I hadn't spotted that.  I'll rebase off it and see how I go.

@nealeu Be careful its missing components compared to master, I think the pull req you opened is more accurate. next seems to be a beast of its own.

I'm closing this PR as #262 has been resolved. Thanks for your help guys.


improvement Forbid LocalDeployManager drop node

Proposed changes
Issue Number: close #xxx

Forbid LocalDeployManager drop nodes to prevent errors in the cluster.info file from causing nodes to be dropped.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall


lightdm-slick-greeter: init at 1.5.9

Description of changes
Didn't see this packaged and I wanted to use it for my LightDM greeter. I think a lot of people are accustomed to using this because it is the default on Linux Mint and whatnot.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Did the requested changes. I had to make a minor change to add actual support for numlockx and remove the hardcoded path I didn't notice before.

I took the liberty to force push some changes, tested this in a VM and seems to work. I will do some more tests in a few days.

@bobby285271 thanks for cleaning up the PR! I definitely did miss a few buildInputs for the scripts and other things in the derivation (I only checked if the package was running successfully), and didn't know if I had to include all the options for it in the module or not; including all of the options instead of just leaving it does seem like a nightmare to maintain, now that I think about it.
Also pretty cool that Cinnamon switched to slick-greeter as the default; changing default behavior isn't something I wanted to do without approval or something, though, so I held off on that. Nice to see it here though 😄

Mint defaults to this greeter since 18.2 so I though we can probably follow what upstream does. I don't have preferences on greeters and/or DMs (I am actually using Pantheon greeter in most cases since I maintain Pantheon) so I won't mind to revert those changes if requested.

Changing to whatever mint uses is fine. I just newer switched to that greeter since it wasn't ported and I didn't have the resources for that.

Is there anything else that needs to be done? Or are we okay to merge?

Is there anything else that needs to be done? Or are we okay to merge?

As far as Im concerned this is good to merge, just waiting on others who reviewed to take another look.


SPIKE: Fix overlapping UI elements in bootstrap wizard if height of terminal window is insufficient

Text inputs or git providers table in the bootstrap wizard in gitops run are mangled if the height of the terminal window is insufficient.
Examples of "mangled" or overlapping elements if terminal window is too low:

Resizing the window fixes the issue:

Supposedly, adding a Bubble Tea viewport component around the UI elements should fix this issue and make the UI reserve space for inputs. How to set viewport height in this case properly (and if it needs to be set to a fixed value at all) and make it adapt to different number of flag text inputs for different git providers requires further research.

The initial simple fix (wrapping controls with a viewport of fixed height) didn't work. It looks like it's a complex issue with displaying more lines than the terminal window height. So, this issue requires more research. I plan to return to it later.

I've decided to retry the viewport fix from scratch, created a basic prototype based on the Bubble Tea pager example and copied most of inputs from the bootstrap wizard there. So, for the prototype the viewport protects the inputs from being mangled if the terminal height is insufficient:
https://user-images.githubusercontent.com/8824708/197051600-fcdafa7a-d5ca-49e8-b2f3-4af7113f8b92.mov
When using arrow buttons to scroll up and down, if the terminal height is insufficient (in the first part of the video), the UI controls look as expected (I have not copied the entire text inputs style on focus/blur code, but the basic code works fine).
Only when using the terminal scrollbar to scroll, the previous rendered part of the UI disappears until redrawing is forced with either up or down arrow or mouse wheel scrolling (which resents the terminal scrollbar position to the bottom).
As @ozamosi said,

You can't affect the terminal's scroll bars - they're part of the terminal itself, whereas the program is running in a TTY. Imagine the program as a java applet or a flash animation, and the user clicked the back button.

I think the APIs were designed for the terminal "window" to be a printer and the "contents" to just be paper :thinking_face: Bubbletea's rendering is basically just to hit backspace until it's at the top left corner, and then echoes a full screen of characters.

I also came across some issues related to weird scrollbars behavior and redrawing content in the terminal (when using alt a screen buffer/alt screen):
https://github.com/charmbracelet/bubbletea/issues/349
https://github.com/xtermjs/xterm.js/issues/802
So, the issue with the screen not repainted when scrolling the terminal window with system scrollbars is by design and not a Bubble Tea bug.


Add combinations method for HList

This is very cool, and I'd be happy to merge it on purely technical grounds. Before I do, can you give an example of a use that would motivate including it in the main library as opposed to, say, as an example?

I can't give an example. well... I wrote some algorithms in a type level. it's just hobby. I needed a typeclass of combinations for those. and then I found a permutations method in HList, so I was think that a combinations method is also useful for shapeless.

Fair comment wrt permutations.
OK, I'm happy to include this. But I wonder if it would make sense to move Combinations0 to the top level: if I'm reading it correctly this represents "combinations of some fixed length N" and that strikes me as being at least, if not more useful than "all combinations".

Why do you think 'useful as "all combinations"' ?
Combination0 connot check length alone. I think that it's not necessary move to the top level.

Am I misunderstanding? I read Combinations0[N, L] as producing all combinations of elements from L of length exactly N.

No you're right. ah.. come to think of it, it could be nice. so, I move it to the top level.

moved :)

I'm afraid I'm getting a bit confused ... my apologies :-(
I think I misunderstood initially and thought that Combinations produced all combinations (or all lengths) of elements from L, whereas Combinations0 produced all combinations of exactly length N of elements from L. It was on that (mis)understanding that I asked you to move Combinations0 to the top level.
But looking again now, it seems that Combinations is already producing combinations of exactly N elements. So what is Combinations0 doing? It has exactly the same signature as Combinations, so why is a distinct type class needed here?

I wanted check length the same as other type classes, like a "At type class" or "Slice type class". Because I was think that it's more useful. But "Combination" cannot check length alone, so I added "Combination0". I had no choice but to do so...
And I wrote the wrong comment by mistake... my apologies :(
https://github.com/milessabin/shapeless/pull/590/files#diff-03fe632291a854a01a374f4b97f30489R720

I removed Combination0. This version is cannot check length. like this. but simple.
Which do you think is better this version or an old version.

My apologies for taking so long to get back to you on this :-(
This looks just fine ... many thanks! Merging :-)

I guess it may be useful for random testing


[SANDBOX PROJECT ONBOARDING] Xline

Welcome to CNCF Project Onboarding!
This is an issue created to help onboard your project into the CNCF after the TOC has voted to accept your project.
We would like to complete onboarding within one month of acceptance.
From the project side, please ensure that you:

[x] Understand the project proposal process and reqs: https://github.com/cncf/toc/blob/main/process/project_proposals.md#introduction
[x] Understand the services available for your project at CNCF https://www.cncf.io/services-for-projects/
[x] Ensure your project meets the CNCF IP Policy: https://github.com/cncf/foundation/blob/master/charter.md#11-ip-policy
[x] Review the online programs guidelines: https://github.com/cncf/foundation/blob/master/online-programs-guidelines.md
[x] Understand the trademark guidelines: https://www.linuxfoundation.org/legal/trademark-usage
[x] Understand the license allowlist: https://github.com/cncf/foundation/blob/master/allowed-third-party-license-policy.md#approved-licenses-for-allowlist
[x] Is your project working on written, open governance? see https://contribute.cncf.io/maintainers/governance/
[x] Slack: Are your slack channels migrated to the Kubernetes or CNCF Slack? (see https://slack.com/help/articles/217872578-Import-data-from-one-Slack-workspace-to-another for more details)
[x] Is your project in its own separate neutral github organization?
[x] Submitted a Pull request to add your project as a sandbox project to https://landscape.cncf.io
[x] Create maintainer list + add to aggregated https://maintainers.cncf.io list by submitting a PR to it
[x] Artwork: Submit a pull request to https://github.com/cncf/artwork with your artwork
[x] Domain: transfer domain to the CNCF - https://jira.linuxfoundation.org/plugins/servlet/theme/portal/2/create/63

Things that CNCF will need from the project:

[x] Provide emails for the maintainers added to https://maintainers.cncf.io in order to get access to the maintainers mailing list and ServiceDesk -<EMAIL_ADDRESS>is the best email to send those to
[x] Trademarks: transfer any trademark and logo mark assets over to the LF - https://github.com/cncf/foundation/tree/master/agreements has agreements
[x] GitHub: ensure 'thelinuxfoundation' and 'caniszczyk' are added as initial org owners, this helps us make sure we have continuity of GH ownership that we will onboard to our GitHub Enterprise instance: https://github.com/enterprises/cncf
[x] GitHub: ensure DCO or CLA are enabled for all GitHub repositories of the project
[x] GitHub: ensure that that the CNCF Code of Conduct (or your adopted version of it) are explicitly referenced at the project's README on GitHub
[x] Website: ensure LF footer is there and website guidelines followed (if your project doesn't have a dedicated website, please adopt those guidelines to the README file of your project on GitHub).
[x] Website: Analytics transferred to<EMAIL_ADDRESS>[x] OpenSSF Best Practices Badge: Start on an OpenSSF Best Practices Badge https://bestpractices.coreinfrastructure.org/en

Things that the CNCF will do or help the project to do:

[x] Devstats: add to devstats https://devstats.cncf.io/
[x] Insights: add to LFX Insights https://insights.v3.lfx.linuxfoundation.org/
[x] Events: update CFP + Registration + CFP Area forms
[x] ServiceDesk: confirm maintainers have read https://www.cncf.io/services-for-projects/
[x] CNCF Welcome Email Sent to confirm maintainer list access
[x] Book time with the team with http://project-meetings.cncf.io
[x] Adopt a license scanning tool, like FOSSA or Snyk

Since there was only one task left here and it was optional (and it's something you can do at any time later) I'm closing this task.
Congratulations on completing onboarding!

[ ] Book time with the team with http://project-meetings.cncf.io/


Update image preview extractor to be compatible with Clowder V2

Related to https://github.com/clowder-framework/pyclowder/issues/70

Closing as duplicate of #34


If a replace a file with the same file in the watched directory nothing happens

This is possibly an edge case. If I add a file to the watched directory and if the same file already exists in the watched directory no change is detected. The file is identical, same file extension, content and last modified date.
I am monitoring the directory for add and change events.
Chokidar Options
const options:  = {
	persistent: true,
	ignoreInitial: true,
	awaitWriteFinish: true,
	usePolling: true,
	alwaysStat: true,
	useFsEvents: true,
	binaryInterval: 100
};

Expected behavior
The action of pasting a file into the directory is observed

Disable awaitwritefinish


Overscroll effect not smooth as IOS

I have implement this project in my project. this is working in it. but gettng some issue with that. I have found Overscroll effect not smooth as IOS. and when I scroll listview at bottom overscroll then it top part comes over other view so its look like overlap view

Same problem. Awsome project, but IOS looks much smoother.

use elevation

Could you give me propercode for using elevation so I can use it in my ;project @Paoneking

This can be solved by placing the list-view as a child of a frame-layout. I've done so myself in the example project, e.g. with the vertical recycler view - you can use that for reference.


feat(Facade): detect when Array.forEach callback has more than 1 arg

Whenever a function (function expression or arrow function) is passed to Array.forEach(), makes sure the function takes exactly one parameter (as expected by Dart - JS could have up to 3 params).
Note that no check is performed when the callback is an identifier (a.forEach(myFn)).
Supersedes #213

LGTM, though see note.

Closing as not really useful (we have to rely on the Dart Analyzer for exhaustive checks anyway)


Solid Arrow Buttons

Solid Arrow Buttons
[FEATURE]: Arrow buttons in tailwind #48
The purpose of this Pull Request is to fix #48
Description
Added Arrow buttons as shown in reference image.
How you solved
Created a component with https://play.tailwindcss.com/ and modified ..tailwind_ui_components/tailwind_components/ and component.js
Screenshots

Checklist

[ ✔ ] I have Made this contribution as per the CONTRIBUTING guide in this repo
[ ✔ ] I have tested in local Environment.
[ ✔ ] I have made the fix as per issue converstaion
[ ✔ ] I have starred the repository ⭐

@Kabiirk ,
Welcome to our community, great work
Also check for other component issues too!


Open ATV7.0 ; 7.1

quick report - after sending files to image atv 7.0 and 7.1, user.bouqet not vissible on TV screen, but they are in the folder etc/enigma2/ . thank you

Hi,
I'm not sure that problem is in the program, because:

This branch is not stable. And can present more surprises. Just wait for updates.
I also have 7.0 build from 19.02.2022 for testing. I don't see any problems with this.

If you are sure that the problem is in the program or Enigma2 settings, then send me your settings set. I'll test it on my Box.


Email address validatin using Cleave.js

How do we format an email address ?
I did not find anything about this in the official documentation.

@begueradj This is not a validation library.

You are right, sorry for the terminology, I edited to replace "validate" by "format".
Thank you.

I don't think it is possible using Cleave.js. Because Cleave formats its input based on fixed length blocks. An email doesn't have fixed length blocks.

I guess you are right, thank you very much @radiantshaw :) I am closing this issue then :)


Initial commit to add the deployment configuration for Jenkins

This PR is just the commit to add the Jenkins build file into the repository. It adds the features to run checkout, build, deploy, and test in Jenkins pipeline. The optimization will be done to the script in future.
Closes-Bug: #4335

Description

Related issue and scope

[x] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[x] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[ ] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #4345 into master will decrease coverage by 4.26%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4345      +/-   ##
=========================================
- Coverage   85.56%   81.3%   -4.27%
=========================================
  Files         169     169
  Lines        7830    7830
  Branches      535     535
=========================================
- Hits         6700    6366     -334
- Misses       1130    1464     +334

Impacted Files
Coverage Δ

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-95.24%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-92.6%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-84.62%)
:arrow_down:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
4% <0%> (-52%)
:arrow_down:

...in/scala/org/apache/openwhisk/common/Counter.scala
40% <0%> (-20%)
:arrow_down:

.../scala/org/apache/openwhisk/utils/Exceptions.scala
20% <0%> (-20%)
:arrow_down:

...whisk/connector/kafka/KafkaProducerConnector.scala
72.5% <0%> (-15%)
:arrow_down:

...nwhisk/core/database/cosmosdb/CosmosDBConfig.scala
94.11% <0%> (-5.89%)
:arrow_down:

...rg/apache/openwhisk/common/ForcibleSemaphore.scala
88.46% <0%> (-3.85%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb4e4df...f908255. Read the comment docs.

Is this the base PR to replace travis to jenkins?

No. This is to slow us to run longer CI on a configuration with multiple distributed invokers.


(chore)docs: update getting started doc with analytics note

Add note for analytics in getstarted page

Signed-off-by: ksatchit<EMAIL_ADDRESS>

LGTM, However post the changes in env, does the user required to restart any service if yes that needs to be documented. Else its good to merge.

After changing the ENV the operator will be restarted, And any chaos run after that will not send the analytics data


Migrating the model to Livox Horizon

Thanks for your excellent work. I download and infer the toy dataset you provide and the performance is good. Now I want to use the model in my Livox Horizon with 80x25 FoV and similar point density to 64-line LiDAR. When I use your tools to generate range image and residual image, I just change the pose.txt and calib.txt to my own and everything is alright, I can generate correct range image and residual image. But when I try to infer my data using the model, I meet this error the range image generation function in salsanext. Are there any possible reasons?

Hey @Psyclonus2887,
The pretrained model is with a fixed input size of the range image.
As the error reports, the do_range_projection function does not work for the Livox LiDAR. You need to first change the range projection function for Livox LiDAR.
When using a new sensor, you may also need to train a new model, since the sizes and distributions of point clouds are totally different from that of Velodyne LiDARs.

Thanks a lot. Are there any differences between the range projection method in utils/gen_residual_images.py and that in salsanext? Cause when using utils/gen_residual_images.py, I can generate good range projection images as follows. So I think it may not be the problem of range projection function.

There should not be a big difference between these two range projection functions and your range projection looks okish.
But you could also see that there are lots of empty pixels and after the spherical projection the range information of the Livox sensor is very sparse.
I would guess LMNet will not work well with this type of input data. I guess use directly the range image from Livox is even better than using our spherical range projection.

Thank you. I have found the reason. The point cloud from Horizon contains some nan points where the depth of these points are 0. In the function in utils, there is a limitation with maxrange and minrange. But in the function in salsanext, there are no such limitation, which leads to illegal input when generating range image. I cut the noise points when generating bin files from Horizon. And the infer procedure can be done.

You are right, the result of prediction is not good.

But from the visualization result all the point cloud are classified into dynamic, that is weird. Maybe it is because I don't set the configuration right. The point density from Horizon LiDAR is similar to HDL-64, in a accumulation time of 0.1s. And the residual image when N=1 is like follows.

so what can the problem be? I have several thoughts:

The characteristic of non-repeat scanning mode. Although the point density is enough, the distribution makes it different  to infer by your network.
The azimuth limitation. the 80 degree FoV reduce the performance of your network.
Any advice will be appreciate. Thank you very much! BTW, what do you mean when you say "use directly the range image from Livox is even better than using our spherical range projection"?

Thanks for the feedback.
Yes, the pre-trained model was trained on totally different LiDAR data with different distributions. It is expected to perform badly.
Possible solution:

using denser and correct range projection of Livox LiDAR and re-train our network. (As shown below, it's from the Livox website and I have no idea how to generate it)
using a 3D network that is not bound with the range representation. (We just submit one work to RAL/IROS and will release the code later)

Thank you very much for your fast reply. I will try both these methods. Looking forward to your new work!

Thanks for using our code.
Since it's more about another setup, I would like to close this issue.
If you find our code and answers helpful, I'll appreciate it if you could give our repo a star to let more people use and push it forward.
Feel free to reopen this issue if needed.


The HelloTriangle example handles VK_FORMAT_UNDEFINED, which is not allowed by the spec

In this example:
https://github.com/KhronosGroup/Vulkan-Samples/blob/7e26046720669d82d19d4525f2bb7308efd4b55b/samples/api/hello_triangle/hello_triangle.cpp#L444
It calls vkGetPhysicalDeviceSurfaceFormatsKHR and then checks if the first entry is VK_FORMAT_UNDEFINED.
However, according to the spec of vkGetPhysicalDeviceSurfaceFormatsKHR:

The number of format pairs supported must be greater than or equal to 1. pSurfaceFormats must
not contain an entry whose value for format is VK_FORMAT_UNDEFINED.

So that check is not needed.

Thanks for raising this. This is probably a left-over from the very early days of Vulkan, where this wasn't explicitly defined in the spec.


Update API documentation with new taxon ranks

Apparently, the API documentation has never been updated to mention the new taxon ranks that were recently added to the NCBI-taxonomy and that are also supported by Unipept.
@bmesuere Since the old version of the API (v1) is still accessible, we should also keep track of the documentation for this version and all of the ranks supported in that version. Should we change the URL of the docs from unipept.ugent.be/apidocs/pept2taxa to unipept.ugent.be/apidocs/v2/pept2taxa (and idem for v1)? What's your opinion on this?

Since none of the calls were changes and only some ranks, I would just add a message to the docs where appropriate.


scripts: utils: add include migration script

All includes are now prefixed with <zephyr/...>, even though the old
include paths can still be used when CONFIG_LEGACY_INCLUDE_PATH=y, an
option still enabled by default. Migrating large projects can be tedious
and time consuming. This patch provides a script that can be used to
migrate any Zephyr-based project to the new include path. It is used
like this:
  python $ZEPHYR_BASE/scripts/utils/migrate_includes.py \
         -p path/to/zephyr-based-project

Signed-off-by: Gerard Marull-Paretas<EMAIL_ADDRESS>

added missing continue statement, please re-review @henrikbrixandersen @stephanosio


Restore workspaces

Follow up to https://github.com/StarcounterPrefabs/Launcher/issues/211
Changes made after Launcher 3.1.6 caused workspaces to be reloaded when switching from one workspace to another. This is causing reset of presentation state, which is unwelcome by applications developer.
Let's bring back the functionality that existed in Starcounter 2.1.177 + Launcher 3.1.6, which kept the initial state of the workspace when switching back to it.
There are two parts of this task (HTML and C#). I will make the HTML part

Later, I will also add Selenium integration tests for this

Work is done on a branch: https://github.com/StarcounterPrefabs/Launcher/tree/restore_workspaces
I think that HTML part is done, but there is still come problem with the C# part. Every HTTP GET with Accept: application/json-patch+json request causes a replace operation on the whole workspace.
The below gif illustrates the problem (see until the end, when the patch is presented). The red counter on the top of the page should say "Launcher has created 1 workspaces" through the whole gif.
@chrhol I need your help with this. Can you please take a look?

I will take a look. I wonder what have changed from the old version? If a workspace already exists it's reused in the Launcher so the problem must be somewhere inside Starcounter.

Found the reason. The internal handling of newly added siblings is to mark the main object (in this case the workspace json) as replaced and send the whole json.
This worked before due to that no siblings were changed, but after we added the callback a new sibling is always added on a merge.
I will add an issue in Starcounter to fix this somehow. We need to keep track of which siblings we had before the merge and only send what's been changed.

Just a note on this: On the server everything is reused, the replace happens on the client-side

https://github.com/Starcounter/Starcounter/issues/3465

Great that you've found the problem. Looking forward the solution.

The fix is now up and running in Launcher master branch, including tests.
@malx122 now workspaces again support preserving of presentation state (scrollbars, etc) and no longer rely on URL parsing to find the current workspace.


[tcgc] add test for @clientName on templated parameter

add test for: https://github.com/Azure/typespec-azure/issues/699#event-12593890119

No changes needing a change description found.

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/738/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/738/


Add a way to run ./tools/build_website.js in "watch" mode

auto-compile on file changes:
$ ./tools/build_website.js watch

Should also start http-server on build/website

Fixed in b33a014. Use node tools/dev_website.


Architectures Intel 32-bit when submit to the App Store

Integration Method:  Manual
Xcode Version: 111.4
Library Version: 3.6.0
Platform: iOS
Language: Objective-C
Description:
When I submit my app I got this warning:

This is wrong, because its iOS, why to include desktop arch's in the lib?
Expected Behavior:
Don't use wrong architectures and no warnings when submitting for App Store.

Hey it’s been so nice to have you guys back in my life

hi @KAMIKAZEUA , the issue has been fixed in v3.6.1. I'm closing this issue for now, please feel free to to reopen it if the problem still exists.


FATAL ERROR: 'Default Biblio Status' must be either 'current' or 'snapshot'. Got 'current'

For whatwg/dom, /url, /fetch, /notifications.
Please do some regression testing before updating on the server...

(Reported at https://github.com/tabatkins/bikeshed/issues/940 for streams)

Fixed. :(


Reverse VBO order for line and outline, so that outline is drawn before line

See https://github.com/tangrams/tangram-es/issues/502

Partially resolved by https://github.com/tangrams/tangram/commit/77e436c64225262c80fa67361170e47565574dd2.
Note that we still have issues with outlines drawing on top of intersecting line fills from the same style. For correct ordering, all outlines for the style should be consolidated under all line fills. Fixing this is more difficult, as it's not currently easy for us to place all outlines in the VBO before all fills. A possible future solution is a bucketed draw call architecture, where outlines are tracked as a separate draw call (either in a separate VBO, or a different range in the same VBO as the line fills).


Handle update errors

Supersedes and closes #19.
Fixes #17.
Depends on https://github.com/atom/atom/pull/11314.
This PR introduces some UI for the auto-update error state:

@simurai @thedaniel: I'd :heart: to have your feedback on this, since you worked on #12.
/cc: @atom/core

Can we actually display the error somewhere? Otherwise it's just kind of a sad failure 😢

Can we actually display the error somewhere? Otherwise it's just kind of a sad failure 😢

Totally, the error gets logged out to console here.

Could we display that in the UI instead of the generic text?

Good call, I was mainly concerned about the error not being human-readable, but skimming through the squirrel source seems like all the errors can be showed to the user. Thanks, @joshaber! :sparkles:
I have updated the screenshot and I believe this is good to go! :ship:

:metal:


ASP.NET Core Angular 2 Starter Application (.NET Core)

I am trying to run the template "ASP.NET Core Angular 2 Starter Application (.NET Core)" found in http://blog.stevensanderson.com/2016/10/04/angular2-template-for-visual-studio, but I get the error:
The imported project "C:\Program Files\MSBuild\Microsoft\VisualStudio\v14.0\DotNet\Microsoft.DotNet.Props" was not found. Confirm that the path in the  declaration is correct, and that the file exists on disk. d:\temp\Angular2Application1\Angular2Application1.xproj.

That error occurs if you've installed .NET Core tooling preview 3 or later on your machine (which happens if you install VS2017RC).
To fix it, you can add a global.json file at the root of your project containing this:
{
  "sdk": { "version": "1.0.0-preview2-1-003177" }
}

A better solution though, instead of using the VS project template, is to use the Yeoman generator, which produces much more up-to-date projects. To do this, create an empty directory somewhere, then in a command prompt, run:
cd your-empty-directory
npm install -g yo generator-aspnetcore-spa
yo aspnetcore-spa

If you have any trouble with that, make sure you have an up-to-date version of Node.js (e.g., version 6+).

Thank you very much for your feedback.
I get the error mentioned when I create the project, so there is no directory yet, and therefore there is nowhere to put the global.json file. I attach the screenshots:

How else can I resolve this problem?
Unfortunately, I cannot use npm, because I am behind a firewall. I attach the log file of npm:
npm-debug.log.txt
If I cannot use the template, is there a sample Visual Studio project with Angular2?

I installed ASP.NET Core 1.1 (dotnet-dev-win-x<IP_ADDRESS>-preview2-1-003177.exe), and now I could create a new project with the template "ASP.NET Core Angular 2 Starter Application (.NET Core)", but I get the following message in the output window:
PATH=.\node_modules.bin;C:\Program Files\Microsoft Visual Studio 14.0\Web\External;%PATH%;C:\Program Files\Microsoft Visual Studio 14.0\Web\External\git
C:\Program Files\dotnet\dotnet.exe restore "d:\temp\Angular2Application2.vs\restore.dg" -s "C:\Program Files\Microsoft SDKs\NuGetPackages"
log  : Restoring packages for d:\temp\Angular2Application2\project.json...
error: Unable to resolve 'Microsoft.AspNetCore.AngularServices (>= 1.0.0)' for '.NETCoreApp,Version=v1.0'.

npm-debug.log.txt

Are you using VS2017 RC?
I may be wrong, but I believe that is for VS2015 (notice the project.json) as opposed to the XML & .csproj that's required for 2017.

Yes, I am using VS2017 RC. Do I have to install VS2015 to use the template "ASP.NET Core Angular 2 Starter Application (.NET Core)"?

I would prefer to stay on VS2017 RC. Can you perhaps provide a version for VS2017 RC?

I'm not sure if the Template has a 2017 version, Steve would have to answer that one for you. But there is of course the 2017 version available under the generator-aspnet-spa.
Also I would definitely talk with IT and get npm available as it's such a crucial part of development these days, you'll need it! The templates and VS install things through npm, I'm not even sure those would work unless you had access?

What is the generator-aspnet-spa?

It uses yeoman to generate the application, it's a command-line version of the Template packs (it's much easier to update projects with it as well).
npm i -g yo generator-aspnetcore-spa (installs both yeoman and the generator) with npm
yo aspnetcore-spa runs the generator (from there, you select angular2, and any other options you want (one of them being VS2015 or VS2017), it'll then install everything for you) Then you can open it in Visual Studio, etc.

I have not succeeded to make npm use the proxy. Is it not possible to work without npm? Would it be possible to get the Visual Studio 2017 RC project with all the dependencies downloaded?

The problem is Visual Studio itself will use npm to download these dependencies regardless, so even if you could pull it down you'd run into the same problem.
Can you contact IT about it, npm is one of those things that needs to be accessible :(

I now installed VS2015, but I get the following error in the Output window:
PATH=.\node_modules.bin;C:\Program Files\Microsoft Visual Studio 14.0\Web\External;%PATH%;C:\Program Files\Microsoft Visual Studio 14.0\Web\External\git
C:\Program Files\dotnet\dotnet.exe restore "d:\temp\Angular2Application4.vs\restore.dg" -s "C:\Program Files\Microsoft SDKs\NuGetPackages"
log  : Restoring packages for d:\temp\Angular2Application4\project.json...
error: Unable to resolve 'Microsoft.AspNetCore.AngularServices (>= 1.0.0)' for '.NETCoreApp,Version=v1.0'.
log  : Restoring packages for tool 'Microsoft.AspNetCore.Razor.Tools' in d:\temp\Angular2Application4\project.json...
log  : Restoring packages for tool 'Microsoft.AspNetCore.Server.IISIntegration.Tools' in d:\temp\Angular2Application4\project.json...
log  : Restoring packages for tool 'Microsoft.DotNet.Watcher.Tools' in d:\temp\Angular2Application4\project.json...
log  : Writing lock file to disk. Path: d:\temp\Angular2Application4\project.lock.json
log  : d:\temp\Angular2Application4\Angular2Application4.xproj
log  : Restore failed in 34712ms.
Errors in d:\temp\Angular2Application4\Angular2Application4.xproj
Unable to resolve 'Microsoft.AspNetCore.AngularServices (>= 1.0.0)' for '.NETCoreApp,Version=v1.0'.
PATH=.\node_modules.bin;C:\Program Files\Microsoft Visual Studio 14.0\Web\External;%PATH%;C:\Program Files\Microsoft Visual Studio 14.0\Web\External\git
C:\Program Files\dotnet\dotnet.exe restore "d:\temp\Angular2Application4.vs\restore.dg"
log  : Restoring packages for d:\temp\Angular2Application4\project.json...
log  : Retrying 'FindPackagesByIdAsyncCore' for source 'https://www.nuget.org/api/v2/FindPackagesById()?id='Microsoft.AspNetCore.AngularServices''.
log  : Response status code does not indicate success: 407 (authenticationrequired).
log  : Retrying 'FindPackagesByIdAsyncCore' for source 'https://www.nuget.org/api/v2/FindPackagesById()?id='Microsoft.AspNetCore.AngularServices''.
log  : Response status code does not indicate success: 407 (authenticationrequired).
error: Failed to retrieve information from remote source 'https://www.nuget.org/api/v2/FindPackagesById()?id='Microsoft.AspNetCore.AngularServices''.
error: Response status code does not indicate success: 407 (authenticationrequired).
error: Failed to retrieve information from remote source 'https://www.nuget.org/api/v2/FindPackagesById()?id='Microsoft.AspNetCore.AngularServices''.
error:   Response status code does not indicate success: 407 (authenticationrequired).


Fix Build::compile_objects deadlock on failure

Fixed  #844

This PR does not fix the #844 problem for me unfortunately. I've applied it on top of main and it hangs both with and without patch.

This PR does not fix the #844 problem for me unfortunately. I've applied it on top of main and it hangs both with and without patch.

Thanks for the quick reply!
I will have a look at other part of Build::compile_objects, although I do think this PR is still worth merging since it indeed fixed a potental deadlock/

This PR does not fix the #844 problem for me unfortunately. I've applied it on top of main and it hangs both with and without patch.

On a second thought, this is actually reasonable given that there is no compilation failure in opencv.

Superseded by #849


In the Lookup deleteWordLeft does not work as in the editor

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace.  VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[x] Lookup.  Dendron's Lookup Command
[ ] Views.  Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema.  Dendron Schemas
[ ] Pod.  Data import from / export to Dendron
[ ] Publish.  External Site Publish
[ ] Markdown.  Markdown features, such as syntax support and features

Describe the bug
When editor.wordSeparators includes period ., but does not include dash -, and the cursor is positioned after dev.python.libs.some-awesome-lib, in the editor deleteWordLeft deletes all characters after the last period. Whereas
in the Lookup deleteWordLeft deletes all characters after the last dash. That is, it considers the dash to be a word separator.
To Reproduce
Steps to reproduce the behavior:

Create the note dev.python.libs.some-awesome-lib
Press Ctrl + L to lookup a note
Press the right arrow to move the cursor after the last character
Press Ctrl + Backspace to execute deleteWordLeft
Notice which characters were deleted

Expected behavior
The input field of the lookup contains the characters dev.python.libs.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information)

OS: Windows 10
VS Code 1.62.3
Dendron 0.71.0

Additional context
Add any other context about the problem here.
Dendron Log file
Please attach the output of > Dev:Dendron: Open Logs here

So this is part of the QuickInput widget default which is unfortunately not something we control. Could you see if VSCode has a ticket already addressing this and if not, submit it there? https://github.com/microsoft/vscode/issues

https://github.com/microsoft/vscode/issues/110057#issuecomment-723284582

Those inputs use simple HTML <input> elements, and those do not support these commands.

Good news! A feature request to add this functionality to QuickInput has been added to the backlog:
https://github.com/microsoft/vscode/issues/64694

awesome! thanks for the update


[solved] skin reset after the hero died

I temporarily solved the problem of skin reset after the hero died, but there may be some bugs, you can download the zip from v13.5 if you encounter any problems, please contact me.
ps: When a game is over, you need to manually close the League of Legends (TM) Client in the task manager

how did you solve it?

I optimized my code by learing evalexp's code, now you don't have to close it manually when game is over.

结束时有概率会未响应，大概3次有1次，

@youngman2000 你用的是我之前的版本吧，现在的应该不会有这个问题

而你我的朋友，是真正的英雄！

hi sometimes when i take a skin my game just closes and i need to reconnect i dont have it every game aber some games somehow maybe there is a fix for that?

@lilhalfuct98 I haven't encountered this problem, but you can try the latest version to see if this problem still occurs.

i have 13.5 already

See #337

Commit 9928813 fixes the problem.


feat(#174): arc github lock

In this pull I've fixed bug with broken user registration via Arc<Mutex<GitHub>>, introduced new tests to catch this problem in the future.
closes #174
History:

feat(#174): works
feat(#174): enable tests
feat(#174): enable repo tests
feat(#174): enable fakehub tests
feat(#174): enable doc tests
feat(#174): clean for check
feat(#174): test
feat(#174): registers_with_extra_fields

PR-Codex overview
This PR focuses on enhancing thread safety in the FakeHub structure by using Arc<Mutex<GitHub>>, ensuring concurrent access is managed properly. Additionally, it refactors various functions and updates user handling to improve reliability and maintainability.
Detailed summary

Changed github in FakeHub to Arc<Mutex<GitHub>> for thread safety.
Updated main() method to return Arc<Mutex<GitHub>>.
Refactored user handling in multiple handlers to lock the GitHub instance before accessing users.
Modified Coordinates struct to hold a reference to FakeHub.
Adjusted method signatures to accept references where appropriate.
Enhanced tests to validate user registration and properties.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@h1alexbel can we wait this pr before merging this one?

@l3r8yJ I think yes, if it would be fast to merge types PR

@l3r8yJ take a look, please

@l3r8yJ take a look, please

@l3r8yJ take a look, please

@l3r8yJ take a look, please

@h1alexbel Hey there, awesome work on your contribution! 👍 You've earned +4 points, which breaks down like this: +4 base points, +6 for your 139 hits-of-code (nice job!), but -16 because there wasn't a code review (oops!). We bumped it up by +9 to keep you motivated. Your total balance is now +63. Remember, code reviews are super important - they can boost your points and improve code quality. Keep the contributions coming and aim for that sweet spot of 200-800 hits-of-code for max points! Keep up the great work!


WIP: try to make breaking test for ZMQ

Based on issues out at XPD (may not work, as this may be an XPD specific issue).

@danielballan this was the ZMQ thing I was discussing earlier.


feat(runtime): export built-in presets

Export all built-in presets as individual preset key/function pair. The main purpose of this is to be able to use presetIcons online without needing to use bundler. With separate presets, each of them can be used with their respective options.
As for the existing cdns, we can consider deprecating all but core and full. core is the recommended one to be used for integration, while full is for showcase shortcut.

Closing this due to inactive. Feel free to bring it back if you still think it's necessary. Thanks.


runWarpServer (mostly) prevents Warp's concurrency

runWarpServerSettings uses withLowerToIO which creates a thread that receives requests to interpret a Sem and can do only one at a time.
If you run several requests in parallel, they'll get handled sequentially in this case:
data Block m a where
  Block :: Int -> Block m ()

$(makeSem ''Block)

runBlockIO :: Member (Embed IO) r => Sem (Block ': r) a -> Sem r a
runBlockIO =
  interpret
    ( \(Block seconds) ->
        embed $ threadDelay $ seconds * 10 ^ 6
    )

type MyAPI = "wait" :> Capture "x" Int :> Get '[JSON] Int

server :: Member Block r => ServerT MyAPI (Sem r)
server = wait

wait :: Member Block r => Int -> Sem r Int
wait x = do
  block x
  pure x

main :: IO ()
main =
  runWarpServer @MyAPI 8888 True server
    & runBlockIO
    & runM

Note that there's one exception to this issue: if your effect is solely Embed (here, if your replace the Block effect with Embed IO and use embed $ threadDelay instead of block, you'll see parallel execution of the handlers.
If you use serveSem directly, you get parallel execution too:
main :: IO ()
main =
  Warp.run 8888 $ serveSem @MyAPI interpretServer server
 where
  interpretServer = runM . runBlockIO

If this can't be easily fixed, this should at least be documented.

Thanks for the report @kephas. Do you want to have a go at fixing the problem and submitting a PR? I haven't touched this code in a long time and may not get a chance to look at this for a while.


Question on multi-agent pose

Hello,
Not an issue, so feel free to label as question!
Thanks for releasing lightning-pose. Is there a way to make it work with multi-agent videos, or is the added complexity of handling spatiotemporal constraints on different tracklets the difficult part here?

Hey @jpoberhauser, thanks for checking out the repo!
Currently we do not support multi-agent pose estimation. While we think the techniques we've introduced (context architecture, unsupervised losses) will work in this problem setting, we have not yet pursued this.
However, we have been experimenting with the ensemble kalman smoother in the multi-agent setting with good results, so if you have some multi-agent data I'd suggest trying that out. You can find the repo here: https://github.com/paninski-lab/eks.
The repo contains example scripts, including this most basic one that just uses temporal information (no pose pca/multiview information): https://github.com/paninski-lab/eks/blob/main/scripts/singlecam_example.py. This would be the easiest place to start.

Thanks for the info. I will certainly take a look.


for v2, after save, load does not work

Please search your question on previous issues, stackoverflow or other search engines before you open a new one.
For bugs and unexpected issues, please provide following information, so that we could reproduce on our system.
Environment info
Operating System: Windows 10
CPU: i7
C++/Python/R version: Python 3.6
Error Message:
[LightGBM] [Fatal] Wrong size of feature_names
Traceback (most recent call last):
File "W10CoinLightGBMFinalSubmissionV2_bestscore_0.124101-Copy1.py", line 350, in
bst2 = lgb.Booster(model_file="model.txt")
File "C:\Users\ryutek\Anaconda3\lib\site-packages\lightgbm-0.1-py3.6.egg\lightgbm\basic.py", line 1223, in init
ctypes.byref(self.handle)))
File "C:\Users\ryutek\Anaconda3\lib\site-packages\lightgbm-0.1-py3.6.egg\lightgbm\basic.py", line 47, in _safe_call
raise LightGBMError(_LIB.LGBM_GetLastError())
lightgbm.basic.LightGBMError: b'Wrong size of feature_names'
Reproducible examples
Steps to reproduce

Saved model to model.txt with 95 features
When trying to load, the error happens: bst = lgb.Booster(model_file="model.txt")

can you provide a reproducible example with codes?

Also, can you provide the model file if you can't provide the dataset?

model.txt
This is a simple code line to load the model and an error occurs here. The model file is attached.
import lightgbm as lgb
bst = lgb.Booster(model_file="model.txt")

I see, it's a bug, the feature name is split by space in model file and some of your feature name has a space inside (creativeNameCotainsWeek 7).
@guolinke how do you think to fix it?

@wxchan convert the space to "_" when set the feature names?
I think do it in the cpp side may be better.

If we change the feature names, would the user notice it?
How about we use '\n' instead of space? I think '\n' won't appear in feature names (in most cases).

@guolinke What about preventing users from training a model when features have a space? - or, wrap each feature name with double quotes ""? We could also use another delimiter which should never be in feature names (return carriages, etc.).

@Laurae2 , if add "", it will be not so straightforward to split.
I think we output some warnings and then replace these space symbols to _ or - .


get endpoints, proper/pooled db connection

Most of the hound errors are garbage but there are a few semicolon-related ones that are prob needed. Review app is down but gonna look at the code @EricNatelson