Bug AL Goto Definition

Describe the bug
al/gotodefinition' failed with error: 'Index was outside the bounds of the array.
To Reproduce

In VS-Code Open File AL "Codeunit 7301 Whse. Jnl.-Register Line - Base Application.al"
In trigger OnRun set the cursor on "RegisterWhseJnlLine"
Right mouse click, the Popup Menu opens
Select "Goto Definition".

AL Code to reproduce the issue
"Codeunit 7301 Whse. Jnl.-Register Line - Base Application.al" from BC17
Expected behavior
Jumping to the Function Header
Screenshots
5. Versions:

AL Language:  6.1.362735

Business Central: DE Business Central 17.0 (Plattform 17.0.16974.0 + Anwendung 17.0.16993.0)

Extended error information:
[Error - 14:13:22] Please report this issue to https://github.com/microsoft/al/issues including information on how to reproduce it, if possible.
Processing of message 'al/gotodefinition' failed with error: 'Index was outside the bounds of the array.'
Details:
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at Microsoft.Dynamics.Nav.EditorServices.Protocol.FilePathHelper.ParsePreviewFileUrl(Uri uri) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\FilePathHelper.cs:line 97
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.ReferenceSymbolDefinitionManager.GetDeclaringSymbolAsync(Uri previewUri, CancellationToken token) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\ReferenceSymbolDefinitionManager.cs:line 137
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.ReferenceSymbolDefinitionManager.GetContentAsync(Uri previewUri, LaunchConfiguration configuration, CancellationToken token, Boolean relyOnCachedValue) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\ReferenceSymbolDefinitionManager.cs:line 73
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.ReferenceSymbolDefinitionManager.GetDefinitionForSymbolAtPositionAsync(Uri previewUri, Position requestPosition, LaunchConfiguration configuration, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\ReferenceSymbolDefinitionManager.cs:line 101
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.AlDefinitionRequestHandler.ProcessRequestAsync(AlDefinitionRequest request, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\AlDefinitionRequestHandler.cs:line 50
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.NavServerRequestHandler2.HandleAsync(T request, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\NavServerRequestHandler.cs:line 40    at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.RequestHandlerBase1.HandleAsync(JToken requestContents, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\RequestHandlerBase.cs:line 65
at Microsoft.Dynamics.Nav.EditorServices.Protocol.RequestRegistry.Process(Message message) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Endpoints\RequestRegistry.cs:line 80
[Error - 14:16:32] Please report this issue to https://github.com/microsoft/al/issues including information on how to reproduce it, if possible.
Processing of message 'al/gotodefinition' failed with error: 'Index was outside the bounds of the array.'
Details:
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at Microsoft.Dynamics.Nav.EditorServices.Protocol.FilePathHelper.ParsePreviewFileUrl(Uri uri) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\FilePathHelper.cs:line 97
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.ReferenceSymbolDefinitionManager.GetDeclaringSymbolAsync(Uri previewUri, CancellationToken token) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\ReferenceSymbolDefinitionManager.cs:line 137
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.ReferenceSymbolDefinitionManager.GetContentAsync(Uri previewUri, LaunchConfiguration configuration, CancellationToken token, Boolean relyOnCachedValue) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\ReferenceSymbolDefinitionManager.cs:line 73
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.ReferenceSymbolDefinitionManager.GetDefinitionForSymbolAtPositionAsync(Uri previewUri, Position requestPosition, LaunchConfiguration configuration, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\ReferenceSymbolDefinitionManager.cs:line 101
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.AlDefinitionRequestHandler.ProcessRequestAsync(AlDefinitionRequest request, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\AlDefinitionRequestHandler.cs:line 50
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.NavServerRequestHandler2.HandleAsync(T request, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\NavServerRequestHandler.cs:line 40    at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.RequestHandlerBase1.HandleAsync(JToken requestContents, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\RequestHandlerBase.cs:line 65
at Microsoft.Dynamics.Nav.EditorServices.Protocol.RequestRegistry.Process(Message message) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Endpoints\RequestRegistry.cs:line 80
VS Code version: Code 1.51.0 (fcac248b077b55bae4ba5bab613fd6e9156c2f0c, 2020-11-05T18:18:23.642Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 x 3600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
63.87GB (57.65GB free)

Process Argv
--crash-reporter-id b4f2f8df-195c-401b-a7e7-21b28aea869c

Screen Reader
no

VM
0%

Extensions (5)

Extension
Author (truncated)
Version

vscode-guid
hea
1.4.20

al-object-designer
mar
0.2.4

vscode-language-pack-de
MS-
1.51.2

al
ms-
6.1.362735

crs-al-language-extension
wal
1.3.2

I imagine there was more to the error than that one line, in which case, pasting the full error log would help MS fix this.

What solution do you have open? What is your environment?

Original objects from BC 2020 Wave 2 Cronus (unchanged)
I've created a single project

What settings do you have for you project?

How can I export the settings?

I don't have a settings.json file

We'll try to repro as is. Other than the issue in go to definition, does the solution compile?

I haven't tried and I don't want to do it. I only want to inspect the object so I load it into a fresh solution.

Hi, I have the same issue with Error Message
[Error - 16:57:43] Please report this issue to https://github.com/microsoft/al/issues including information on how to reproduce it, if possible.
Processing of message 'al/gotodefinition' failed with error: 'Index was outside the bounds of the array.'
Details:
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at Microsoft.Dynamics.Nav.EditorServices.Protocol.FilePathHelper.ParsePreviewFileUrl(Uri uri) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\FilePathHelper.cs:line 97
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.ReferenceSymbolDefinitionManager.GetDeclaringSymbolAsync(Uri previewUri, CancellationToken token) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\ReferenceSymbolDefinitionManager.cs:line 137
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.ReferenceSymbolDefinitionManager.GetContentAsync(Uri previewUri, LaunchConfiguration configuration, CancellationToken token, Boolean relyOnCachedValue) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\ReferenceSymbolDefinitionManager.cs:line 73
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.ReferenceSymbolDefinitionManager.GetDefinitionForSymbolAtPositionAsync(Uri previewUri, Position requestPosition, LaunchConfiguration configuration, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\ReferenceSymbolDefinitionManager.cs:line 101
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.AlDefinitionRequestHandler.ProcessRequestAsync(AlDefinitionRequest request, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\AlDefinitionRequestHandler.cs:line 50
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.NavServerRequestHandler2.HandleAsync(T request, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\NavServerRequestHandler.cs:line 40    at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.RequestHandlerBase1.HandleAsync(JToken requestContents, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\RequestHandlerBase.cs:line 65
at Microsoft.Dynamics.Nav.EditorServices.Protocol.RequestRegistry.Process(Message message) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Endpoints\RequestRegistry.cs:line 80
The problem is probably with al-object-designer extension. When I deactivate it, VSC seems to bestable

Thanks for the input @Jiribu73 !  @oki-g are you using any other extensions that might interfere? Can you try disabling them?

Without al-object-designer I can't find/open the base app object.
The source of the base file might be wrong. There is no function named RegisterWhseJnlLine ! The function is named "code":

You can open .app object with AZ AL Dev Tools/AL Code Outline (andrzejzwierzchowski.al-code-outline) extension instead, find C7301 and Go to Definition shows you the definition of the file. And if you use Go to Definition on the RegisterWhseJnlLine it jumps to this function - which is inside this Codeunit further.
My question to @atoader is wher is the problem - if only because of al-object-designer extension - I like it to use it.

I have the same issue, it's when opened an object from AL Object Designer but just moving the mouse over the code of a standard object appears a list of errors related to AL Language extension, that is trying to load something.

This looks to me an issue in the external extension. Probably you should contact its developer.  By the way the AL language server does support go to definition within DAL files if you target runtimes >= 5.2.

If you assume that an extension is responsible for this error, you (Microsoft) should contact the developer and fix this issue together. I'm not in the position to decide, who is responsible for it. So be kind and help us users with this. I've given you the log files, now it's your turn. I#m off.

@oki-g
We have asked you to uninstall all extensions and try goto definition scenario without that. You can create a Hello World and navigate to a DAl object.  If your scenario does not work it is a bug on our end.
We only deal here with issues related to the AL language server.


Feature request: Standalone/Server mode

Hello,
Thanks a lot, portal is a great addition to the Clojure ecosystem.
I wonder if that was possible to create a standalone server mode, and clients could connect to it by sending request to the server.  In my mind , you could start a server portal with babashka in a a given port (say 1664), then any client (clj/CLJS) could send edn data to the server through http request. Optimally, a tap register function would be provided so that user just have to provide the port of the server.
This would disentangle portal from the client process and ease the integration with other tools (such as emacs) and shadow-CLJS/hot reloading) and ithe workflow would then resemble to the nrepl/socket repl.
An example of such implementation is the shadow-CLJS inspect server.
Best regards,
David

Hi @davidpham87, thanks for the kind words!
Portal could provide a client API but it would provide less functionality since it wouldn't have access to runtime objects. I added https://github.com/djblue/portal/commit/0d39d476ef4203292871b6b0ab89c57a6112e6a2 as an example of what could be done currently with portal. Is this kind of what you were thinking?

Hi @djblue,
Thanks a lot for the swift answer! Yes, this is what I have been thinking about!
As for your comment, I might be using clojure in the wrong way, but I try to code as much as possible with data, and if I need to introspect an object, I try to convert it to a hash-map before I tap it.
In terms of ergonomics, I wish we could have a flag to portal.main such that we could invoke portal standalone this way:
bb -cp `clojure -Spath -M:portal/cli` -m portal.main --standalone --port 1664

(or have the usual shortcut -s and -p).
As for the client, it would be great if this is included directly inside the portal api, so that we could have it on both Clojure and ClojureScript. But as it is now, I can already use it!
I am going to try to incorporate portal with my clomacs configuration :-)
Best regards,
David

@djblue thanks for this, portal keeps surprising me with how easy it is to set up in different environments! This time tap>-ing from Cloudflare workers :)

@martinklepsch Thanks a lot for the code snippet, we should totally find a way to merge this into the library. @djblue Would you welcome a pull request?

@martinklepsch thanks for the ClojureScript client example!
@davidpham87 I would definitely welcome a pull request! Since you've opened this issues, I've been thinking a lot about how a remote API would enable a bunch of useful workflows. https://github.com/djblue/portal/tree/client-api is what I have done so far but it could use more work.
I'm thinking the clients could live under portal.client.<platform>, for example:

portal.client.jvm
portal.client.web
portal.client.node
portal.client.clr
portal.client.erlang

I recently added https://github.com/djblue/portal/commit/b7cf00b9ca7ea8ffaeff8ed30fa644fcd373c63b. So I'm hoping in the future, you will be able to pipe all tap>s to a single portal and quickly determine which runtime they came from 👌

@davidpham87 the changes have been merged to master and will be part of the next release. I made the following updates:
Rename client fns from send! to submit

Use submit to more closely match portal.api/submit
Default to edn for transport as it provides the highest level of serialization fidelity.
Include metadata when printing edn
Default to tagged literals when reading edn

Thanks again for this awesome contribution!


Add Job to Check for Image Tag and Pull Policy

https://github.com/envoyproxy/gateway/pull/263 adds a Make target that updates the EG image tag and pull policy to all testing in a Kind cluster. A CI job should be created to ensure that the image is always "envoyproxy/gateway-dev:latest" and the imagePullPolicy is "Always".

@danehans is this issue relevant, or can this be closed ?

No, this is still needed The kube-install-image target changes these settings A Job should be created to ensure these are not set in PRs.

Is this issue still needed?


2020-11-20 GUARD-904 Invalid-Signature

Summary
Fixed issue with generating request signature when JSON body contains not-ASCII chars.
Example:
String 1.5”–1.7” should be percent encoded as 1.5 %E2%80%9D %E2%80%93 1.7 %E2%80%9D
” - %E2%80%9D
Previously this char was encoded as %201D
More information about percent encoding can be found here:
https://developer.twitter.com/en/docs/authentication/oauth-1-0a/percent-encoding-parameters

@fabulaspb , Is there a library we can use to do this escaping? Can we add a test, at least for the failing scenario? Also, does it fail only for variation inventory pushes because it's the only case we might have special characters in the Url?
I'm not sure that adding OAuth 1.0 library with lot of dependencies is good idea especially for old V1 project. Added tests to cover the case when json body contains not-ASCII chars which should be encoded by byte.
Yes, it can fail only when we push back quantity info from V1 because JSON body can contains special chars.

@fabulaspb , this can now be closed since GUARD-888 & GUARD-904 are now combined: https://github.com/skuvault/etsyAccess/pull/22


UAVCAN in JAVA?

Hello All.
There are implementations of UAVCAN in JAVA?
Thank you.
Andrew.

No, but you're welcome to propose one!
Meanwhile you may find PyUAVCAN helpful.
Please submit further questions either to the mailing list or to the chat room. This issue tracker is for issues only. Thanks!


MDATP licensing requirements is incorrect

MDATP licensing requirements is incorrect, see also: https://www.microsoftpartnercommunity.com/t5/UK-Modern-Workplace-Community/Announcing-Microsoft-Defender-Advanced-Threat-Protection-MDATP/gpm-p/16338

Microsoft is removing the Windows E3 license pre-requirement from Microsoft Defender Advanced Threat Protection (MDATP). CSP partners will be able to purchase MDATP for all their supported devices, regardless of their Windows E3 license ownership. To enable this business model, Microsoft is launching standalone offer for CSP on March 2, 2020. In addition, there is no change to existing Windows E5, Microsoft 365 E5 Security and Microsoft 365 E5 offers as those offerings will continue including MDATP.
Product Offer:
Microsoft Defender Advanced Threat Protection e2dcab13-1365-417a-b624-4901e2b252f5
Microsoft Defender Advanced Threat Protection for Education 1a7a1bcc-c7bf-4c6b-b55d-d79a6e3bb3ee

Microsoft Defender Advanced Threat Protection requires one of the following Microsoft Volume Licensing offers:
Windows 10 Enterprise E5
Windows 10 Education A5
Microsoft 365 E5 (M365 E5) which includes Windows 10 Enterprise E5
Microsoft 365 E5 Security
Microsoft 365 A5 (M365 A5)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b8aca66a-5a8b-64d2-7201-a7b915c5d309
Version Independent ID: c3cc0543-db20-a8f2-288c-d1dea5ea479f
Content: Minimum requirements for Microsoft Defender ATP - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/minimum-requirements.md
Product: w10
Technology: windows
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@louisgohl thank you for reaching out and helping improve MS Docs. Just for clarity, are you suggesting removing the 6 x licenses as per your message above and adding the product offer details? I see this article has been updated recently so please have another look and let me know if you still recommend changes to this article.

@louisgohl We are closing this issue as there hasn't been a response from your side regarding the specific article where the issue stems from.
Feel free to re-open this issue by clarifying the problematic document and we'd be glad to come up with content updates.
Thank you for providing feedback.


HADOOP-18255. Fix fsdatainputstreambuilder.md reference to hadoop bra…

Description of PR
fsdatainputstreambuilder.md refers to hadoop 3.3.3, when it means whatever ships off hadoop branch-3.3

JIRA: HADOOP-18255

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 42s

trunk passed

+1 :green_heart:
shadedclient
58m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
1m 22s

the patch passed

+1 :green_heart:
shadedclient
20m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

84m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4378/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4378

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint

uname
Linux 684b24d4b430 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6b3daa442aa7d63a5c0f989cf99e8e09626c0cf4

Max. process+thread count
713 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4378/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

The patch looks good. Will commit it.
Thanks @ashutoshcipher  for the patch.

we havent got a release number for branch-3.3; any value is trouble. I've proposed calling it 3.4.0 as it is big enough, in other docs I'm using hadoop.next https://github.com/steveloughran/fs-api-shim#orgapachehadoopfsshimfsdatainputstreamshim
not sure what is best for our internal docs...why i'd ignored this PR

no, just leave alone for now. it's only in trunk


why ?

Hi, that was looking a great simple idea to me. Was it transformed into a new project or integrated in a different form in Jupyterlab ?

step 1: trying to move to setuptools
step 2: retry


Agents should have a MeasuredMeasurables attribute

This should return all of the measurables the agent has added measurements to. It should be in order of when the agent has submitted the most recent measurement. Pagination should be done using the edges/nodes model.
The purpose of this query is for the agent page, where we want to show the recent measurables they have worked on.

I replaced this by this issue:
https://github.com/OAGr/foretold/issues/121


Added poll() with a time out of 10 minutes for building images.

NB: the current implementation does not prevent a stage from running longer than the poll timeout; i.e. if a stage prints a character within the poll timeout the poll call gets re-scheduled again. To have a maximum timeout we need to record the start time and then if we come back from read or poll compare it to the start time and throw an error if we over the limit. Also need to adjust the poll timeout dynamically to be smaller in consecutive runs. Also I dont think we kill the process yet, do we?

NB: the current implementation does not prevent a stage from running longer than the poll timeout; i.e. if a stage prints a character within the poll timeout the poll call gets re-scheduled again. To have a maximum timeout we need to record the start time and then if we come back from read or poll compare it to the start time and throw an error if we over the limit. Also need to adjust the poll timeout dynamically to be smaller in consecutive runs. Also I dont think we kill the process yet, do we?

Thanks for the feedback!
I have implemented all the comments here :smile:

Could you please rebase this PR either as one commit, or if you prefer several then make sure they follow the same style as the rest of the repo? I left a couple of comments inline. Thanks again for working on this!

Am I understanding correctly, squash the commits into one for the PR?

Could you please rebase this PR either as one commit, or if you prefer several then make sure they follow the same style as the rest of the repo? I left a couple of comments inline. Thanks again for working on this!

Am I understanding correctly, squash the commits into one for the PR?

Yes, please. I think this all belongs in one patch, and also please describe in the commit message why you are making the change, how it works, and if there are any gotchas. I'm just looking over this other PR by @gicmo which I think show-cases the style we try to adhere to pretty nicely: https://github.com/osbuild/osbuild/pull/879/commits (I know different projects do PRs/commits differently).

Probably out of the scope for this PR, but I realised when coding the ostree-image test for the LUKS PR that I think what would be right level of the abstraction here is custom subprocess spawn helper that runs a command has a timeout but also returns a value that has stdout captured like we have in CompletedBuild; additionally on every new data to stdout of the spawned process a callback is called, so we have something like:

def on_stdout(data):
    print(stdout)

result = run([`bwrap`], timeout=<timeout>, stdout=on_stdout)

data = result.stdout
ret = result.returncode

In short: a wrapper that allows one to stream the data but also capture it with a timeout.

This looks good to me! Just need to add tests (and probably in the process we will need to make the timeout configurable, or the tests will take forever).

new cmd option added,
In the middle of fixing old tests and adding new ones with the new timeout option :smile:


[Cosmetic] Favicon is still the blue icon

@lcoenen @buckwierd
This has been reported at least twice before guys.
Please update the favicon to our orange icon.

Looks like it was done. I allow myself to close this issue as completed.


LimeTabularExplainer with dummy variables?

I would like to use the LIME tabular explainer on a classifier and feature-set that includes numeric and dummy/indicator variables.
The tutorial for LIME tabular explainer (https://marcotcr.github.io/lime/tutorials/Tutorial - continuous and categorical features.html) mentions numeric variables and categorical variables. I could pass the dummy variables as 'numeric', but the tutorial says the explainer will base explanations on the mean and standard deviation. The mean of a dummy variable is certainly meaningful, but I don't think the standard deviation is.
Alternatively, I could do an inverse dummy-encoding to collapse sets of dummy variables back into categorical columns, but ideally would prefer not to do this.
Is there a recommended way to handle dummy/indicator variables with LIME tabular explainer?
Thanks!

Assuming your dummy variables are the result of encoding some categorical feature, you have to collapse it back to categorical columns. The reason is that LIME will perturb the example in ways that will be nonsensical if you leave the variables encoded. For example, let's say you encoded some variable size = {small, med, large} into three binary variables, so that [0, 0, 1] means large and [1, 0, 0] means small. If you just pass the encoded array into LIME, it will generate perturbed samples like [1, 1, 1], which have no meaning.

ok thanks for the answer.

Marco, i believe a related question to this thread.
In TensorFlow some of the features are constructed and only generated in runtime (Bucketing certain variable, crossing, one hot encoding etc). That means that in the "train" numpy array that is passed to the tabular explainer they do not exist. Do I need to recreate them and add them to that array?
Also does the "train" numpy array has to contain only the features used?
Unrelated, i get "TypeError: can't multiply sequence by non-int of type 'float'" from the discretize.py .. any quick idea why?
Thanks


Not Working with Login - 404 Error

When click on sign in it displays 404 error unless we remove ?back-my-account from URL http://<IP_ADDRESS>:8088/prestashop/en/login?back=my-account

Hi, thanks for reporting.
Please provide more info to try to reproduce

PS version
module version/branch
languages/shops configuration

PrestaShop version: <IP_ADDRESS>
Module version: Release 0.10.0 (stable)
Languages: 2 (en/ur) | {ur = Urdu}
Shop: 1 (no multishop)

Sorry for inconvenience. Module is working correctly, I wrongly installed forked version! Sorry for inconvenience once again.
Thanks for such a nice contribution (Y)

Closing.

:) have a nice WE


add workspaces input field to support non-root projects

Thanks for the great action 🏆  we use it in one of our projects and it raises an error with the default configuration, because of caching being enabled. This happens, if your main Cargo.toml is in a sub-folder and this can be easily mitigated by leveraging the workspaces field in the Swatinem/rust-cache action.
Error
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
    at ExecState._setResult (/home/runner/work/_actions/Swatinem/rust-cache/v2/dist/restore/index.js:7784:25)
    at ExecState.CheckComplete (/home/runner/work/_actions/Swatinem/rust-cache/v2/dist/restore/index.js:7767:18)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/Swatinem/rust-cache/v2/dist/restore/index.js:7661:27)
    at ChildProcess.emit (node:events:514:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
  commandFailed: {
    command: 'cargo metadata --all-features --format-version 1 --no-deps',
    stderr: '\x1B[1m\x1B[31merror\x1B[0m\x1B[1m:\x1B[0m could not find `Cargo.toml` in `/home/runner/work/xyz/xyz` or any parent directory\n'
  }
}

Thank you for the PR. Adding some support for projects where the Rust code is not in the project root is nice to have.


Set up "YAML Config Integration" milestone & group any relevant  issues together

Reviewing some of the other issues here I see a few around using yml files for configs etc. which I think would add decent value to the application. There was other things I would like to have myself so I figured the best thing would be to gather everything under a single "parent feature" (milestone?) to discuss what's needed and add related issues.
I have a few suggestions for functionality (big one for me is yml profiles, list all/select when running instance etc etc) that would be good to have as part of this but I'll wait to see what everyone thinks before opening 10 new issues for everything 😄

[ ] #23 use actuator prefix from application.yml

[ ] #22 use port from application.yml

No worries Damian, open as many ideas you could have... it's free!!
Are all welcome!
:)

#23 #22

Appreciate your ideas!
To be honest, I have been thinking quite a lot about this feature when @cforce point it out.
I end up thinking this would be an overengineering solution, in other words, to avoid two input fields, we should create an algorithm that will have to find application file (properties or yml), will have to parser them (two parsers) and, moreover, we will have to deal with exceptions (file not found, properties not found).
Personally. sounds too much to avoid couple fields in a form, what do you think?

@ErnestOrt
a.)
If you use the Spring Boot Maven or Gradle plugins to create an executable jar, you can run your application using java -jar, as shown in the following example:
$ java -jar target/myapplication-0.0.1-SNAPSHOT.jar
b.)
The Spring Boot Maven plugin includes a run goal that can be used to quickly compile and run your application. Applications run in an exploded form, as they do in your IDE. The following example shows a typical Maven command to run a Spring Boot application:
$ mvn spring-boot:run
You might also want to use the MAVEN_OPTS operating system environment variable, as shown in the following example:
$ export MAVEN_OPTS=-Xmx1024m
c.)
The Spring Boot Gradle plugin also includes a bootRun task that can be used to run your application in an exploded form. The bootRun task is added whenever you apply the org.springframework.boot and java plugins and is shown in the following example:
$ gradle bootRun
You might also want to use the JAVA_OPTS operating system environment variable, as shown in the following example:
$ export JAVA_OPTS=-Xmx1024m
So from what i see running the app using the application.yml packaked with the jar (instead overwriting it like you do in EcosystemManagerpublic void startInstance(String id, String port, String vmArguments, Integer startingDelay) throws CreatingSettingsFolderException, ReadingEcosystemException, RunningMicroserviceScriptException, SavingEcosystemException, InterruptedException {
log.info("Starting instances id: [{}] port: [{}] vmArguments: [{}] startingDelay: [{}]", id, port, vmArguments, startingDelay);) its the standard way the executable jat shall will launch. If you wanna optional use a different profile you can still  do that by passing arg (-Dspring.profiles.active=)   or  EXPORT/SET SPRING_PROFILES_ACTIVE=

@ErnestOrt Yeah I've been mulling over this in my head trying to figure out a good approach here, and I definitely agree with your points but I do think we should still think about adding config profile support maybe as part of the launch instance? If the profile specific yml isn't found spring reverts back to the defaults in your base application.yml so it's not going to cause any exceptions at that point.
@cforce
man use the code blocks when showing some examples for the sake of our eyes 😄. And the normal way to run spring boot apps is mvn spring-boot:run with your profile set as a vm arg like you say or else in your bootstrap.yml file, but I don't see why you would want to or need to overwrite whatever the user's memory settings are for their machine. If you need to set these do it at the application level not at the environment level.


快进到See you again

笑死我了

See you again: Few-shot mamba2 enhanced the Code generation in the complex constraint and multiple instructions


merge dev/bc out to develop

new outsub bc (prim, qtot, non-reflective)
lgtml recommendations
integration spectra with propagator

Codecov Report

Merging #6 (f883b62) into develop (dcf3c4b) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           develop      #6   +/-   ##
=======================================
  Coverage     0.00%   0.00%
=======================================
  Files           14      14
  Lines         1125    1132    +7
=======================================
- Misses        1125    1132    +7

Impacted Files
Coverage Δ

flowdyn/integration.py
0.00% <0.00%> (ø)

flowdyn/meshbase.py
0.00% <ø> (ø)

flowdyn/modelphy/euler.py
0.00% <0.00%> (ø)

flowdyn/solution/euler_riemann.py
0.00% <0.00%> (ø)

flowdyn/modelphy/base.py
0.00% <0.00%> (ø)

flowdyn/modelphy/shallowwater.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcf3c4b...f883b62. Read the comment docs.


Jaeger dependencies page does not work as expected on jaeger-production-template.yml

Jaeger Dependencies page does not work as expected on jaeger-production-template.yml
Always throws the following exception,

Request URL:https://jaeger-query-jaeger.xyz.xip.io/api/dependencies?endTs=1497450385942&lookback=604800000

Response:
{"data":null,"total":0,"limit":0,"offset":0,"errors":[{"code":500,"msg":"Error reading dependencies from storage: Cannot execute this query as it might involve data filtering and thus may have unpredictable performance. If you want to execute this query despite the performance unpredictability, use ALLOW FILTERING"}]}

The CQL error is odd and should be looked at (sounds like a schema mismatch), but even if it worked there wouldn't be any data returned since we don't have the job yet that aggregates the data for dependencies diagram.

I have a reproducer it's because of C* version used in jpkroehling/cassandra
ccm create test -v 3.0.12 -n 3 -s
MODE=test sh plugin/storage/cassandra/schema/create.sh | ccm node1 cqlsh
go run cmd/query/main.go  --query.static-files=jaeger-ui-build/build/ -cassandra.keyspace=jaeger_v1_test

after running create.sh you will see ``:179:ConfigurationException: Unable to find custom indexer class 'org.apache.cassandra.index.sasi.SASIIndex'.
I think jaeger-cassandra-schema-job should fail if there is such an error.
@jpkrohling could you please look at it? There are two parts clarify or use standard C* image (related to #11 ) and fix schema job to fail in there is an error.

also related issue is https://github.com/uber/jaeger/issues/244

Fixed in #24


[hotfix][avro] Link to Hadoop Integration in Avro format documentation

What is the purpose of the change
As discussed in #12523, we prefer to link https://ci.apache.org/projects/flink/flink-docs-master/ops/deployment/hadoop.html instead of giving the download link of hadoop uber jar.
Besides, I updated the dependency table into tabs for better displaying.

cc @danny0405 @JingsongLi

Thanks @danny0405 , Merging...


ocaml-packages.{ppx_cstubs,ppx_bitstring}: build with latest ppxlib

Motivation for this change
The 2 remaining packages using 0.22.0 are compatible with 0.23.0
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Looks like a duplicate.

Indeed, except for the bitstring changes.

I reverted the ppx_cstubs changes and kept just the bitstring changes. For reference, this is the ppx_cstubs PR: https://github.com/NixOS/nixpkgs/pull/144535


Revert User Agent to gcloud-ruby

[closes #883]

@blowmage This looks good, thanks for acting on this issue! Will merge when green.


Help required with understanding workflow

I'm building a small proof-of-concept but am having issues getting dependencies to work correctly. In the example below, the PrintNumbers task runs and prints the numbers 1 to 10. After that, I'd expect that the PrintMoreNumbers task would then start and do the same thing. However, what actually happens is the PrintNumbers task starts again. Could someone assist in pointing out what I am overlooking?
class PrintNumbers(luigi.Task):
    def run(self):
        for i in range(1, 10):
            print("PrintNumbers" + str(i))
            time.sleep(1)
        print("PrintNumbers Completed.")

class PrintMoreNumbers(luigi.Task):
    def requires(self):
        return(PrintNumbers())
    def run(self):
        for i in range(1, 10):
            print("PrintMoreNumbers" + str(i))
            time.sleep(1)
        print("PrintMoreNumbers Completed.")

if __name__ == '__main__':

    luigi.run(['PrintMoreNumbers'])

Here is the output - I'm running from Windows for PoC

Thanks all

PrintNumbers doesn't write any output, so PrintMoreNumbers never knows when PrintNumbers completes. If you want to mock the output of that task, you can do the following
from luigi import mock

class PrintNumbers(luigi.Task):
    def output(self):
        return mock.MockTarget('mock_target')
    def run(self):
        for i in range(1, 10):
            print("PrintNumbers" + str(i))
            time.sleep(1)
        print("PrintNumbers Completed.")
        self.output().open('w').close()

For future reference, direct usage questions like this to the mailing list.

Ah, I thought it was related to the output also. I see that all the examples had it as well but thought it was optional and that it used the PID to determine if it was still running.
I appreciate your help and will be sure to post to the mailing list in future.

Hey, I was just reading through this issue list, and it seems like this one could be closed as the issue/support request seems to have been resolved.


[DAP] mason dap setup not call handle to init dap client

Version confirmation

[X] Confirm

Following prerequisites

[X] Confirm

Neovim version
0.9.1
Operating system/version
macos lastest
Terminal name/version
kitty
$TERM environment variable
No response
Branch info
main (Default/Latest)
Fetch Preferences
SSH (use_ssh = true)
How to reproduce the issue

create a demo cpp: main.cpp
open file directly through nvim: nvim main.cpp
test command: DapContinue or F6
got error message:

Expected behavior
Normally start debug process
Actual behavior
No response
Additional information
I think it's because plugin loading order cause,
mason-nvim-dap must be after mason setup. ref
I tried to modify the dependencies  like this, problem no longer occurs:
{ "jay-babu/mason-nvim-dap.nvim", dependencies = { { "neovim/nvim-lspconfig" } } },

hmm this is a bit strange cause there is no connection between nvim-dap itself and Mason. Have you installed codelldb in Mason?

Nope, They are all installed automatically

hmm this is a bit strange cause there is no connection between nvim-dap itself and Mason. Have you installed codelldb in Mason?

It's no connection between nvim-dap itself and Mason, but i think mason-nvim-dap depended on mason to get some info like this in mason-nvim-dap:
---@param handlers table<string, fun(source_name: string, methods: string[])> | nil
---@return nil
local function setup_handlers(handlers)
	handlers = handlers or {}
	local Optional = require('mason-core.optional')
	local source_mappings = require('mason-nvim-dap.mappings.source')
	local registry = require('mason-registry')
	local notify = require('mason-core.notify')

This shouldn't be the root cause b/c for Lazy.nvim a plugin will be loaded once it's required.

No, I haven't modified these two parts. It's a bit strange. After I synced the plugin, the problem disappeared. 😓
This situation makes me very confused.

This situation makes me very confused.

This is probably because the old cache (luac under XDG_CACHE_HOME/nvim) wasn't properly cleaned up. Since it is highly likely that Lazy.nvim used its cached spec, which stored your previous plugin snapshot. Then mason-nvim-dap.nvim attempted to read plugin definition from that old location and failed hard.

I wanna ask how the direct dependency relationship between mason-nvim-dap and mason is determined in this situation.

mason-nvim-dap depends on mason and mason-nvim-dap will properly setup mason if it was not initialized explicitly.


Bump up CRT version with included fix for forced unwrapping

Describe the feature
When CRT fixes #212 we will need to include the update in our release.
Use Case
Ensure customers who use Swift SDK dont run into this issue!
Proposed Solution
No response
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

Blocked until CRT publishes a fix

Fixed in aws-crt-swift 0.23.0, moving back to Todo

Already shipped, closing.


[Snyk] Upgrade @contentstack/cli-utilities from 1.5.1 to 1.5.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @contentstack/cli-utilities from 1.5.1 to 1.5.2.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released a month ago, on 2023-09-11.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Changing base branch to development


test(ticdc): Fix kv ut meet panic: close of closed channel in cdc/kv

What problem does this PR solve?
Issue Number: close #4135
What is changed and how it works?
(1) use atomic int to avoid close channel many times
(2) use a smaller connectionAge and heartbeat interval to shorten closed connection detcetion
Check List
Tests

Unit test

Code changes
Side effects
Related changes
Release note
`None`.

Codecov Report

Merging #4318 (b16d227) into master (08da001) will increase coverage by 0.2055%.
The diff coverage is 50.6566%.

Flag
Coverage Δ

cdc
59.3345% <63.0573%> (+0.6897%)
:arrow_up:

dm
52.0583% <37.4637%> (-0.1963%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #4318        +/-   ##
================================================
+ Coverage   55.1722%   55.3777%   +0.2055%
================================================
  Files           485        495        +10
  Lines         59829      61066      +1237
================================================
+ Hits          33009      33817       +808
- Misses        23484      23831       +347
- Partials       3336       3418        +82

/run-leak-test
/run-verify

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

/run-kafka-integration-test

/run-verify

/run-leak-test

/run-leak-test
/run-verify

/run-integration-test

/run-leak-test
/run-verify

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

/run-integration-test

/run-leak-test
/run-verify

/run-kafka-integration-test

/run-kafka-integration-test
/run-verify

/merge

I will hold this pr for one day and continuous running the verify to check if we can affectively avoid timeout.

/run-leak-test

/run-leak-test
/run-verify

/merge

/run-leak-test
/run-verify
/run-dm-compatibility-test
/run-kafka-integration-test

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

/run-leak-test
/run-verify

/merge

/run-leak-test
/run-verify


chore: remove segment persister

Since we have already moved segmentpersister to batch servcice, so we can delete original code in feature module.

@Ubisoft-potato, please delete the manifest files.

@Ubisoft-potato, please delete the manifest files.

Done!


Add Bullet configuration option to monitor contacts

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

61 of 78 (78.21%)  changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 89.003%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

vulp/actuation/tests/InterfaceTest.cpp
0
1
0.0%

vulp/actuation/BulletInterface.h
2
8
25.0%

vulp/actuation/BulletInterface.cpp
25
35
71.43%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
1813

Relevant Lines:
2037

💛  - Coveralls


IPv6 support

This pull request adds IPv6 multicast scans by introducing the IPVersion field to the Settings struct, defaulting to IPv4 to not break the compatibility. However, settings IPVersion: IPv6 will execute the same peer discovery service, just for IPv6 instead.
The code is a bit ugly at some points, because both ipv4.PacketConn and ipv6.PacketConn does not implement net.PacketConn. Therefore I treated them as an empty interface.
Please tell me what you think and thanks a lot for this library!

Random note regarding testing: I wrote a small Dockerfile which launches - after enabling IPv6 - some containers for testing.
$ cat Dockerfile
FROM golang:1.11

WORKDIR /peerdiscovery
COPY . .
RUN go build ./examples/main.go

CMD ["/peerdiscovery/main"]

$ docker build -t peertest .
. . .

# run the following command in multiple terminals
$ docker run -t --rm peertest

Seems like Travis CI does not like IPv6:

IPv6 network: IPv6 is not available

@geistesk This is awesome! Thanks so much for this PR, its really incredible.
If you don't mind, could you also add the Dockerfile and update the README with your testing? I think your test is really clever and want to make sure everyone knows about it. If you are busy, I can also merge this now and add it myself later :)

@schollz Thanks for your fast and nice response :)
I've just updated the PR. Does this look good for you?

This is great, thanks so much!


Pass uid as ansible_operator_meta.uid

Feature Request
Describe the problem you need a feature to resolve.

There are times during an Ansible Operator reconcile, when a k8s resource is created outside of Operator process. In order to help clean-up such resources by making them owned by the custom resource that is being reconciled, we will need to get hold of the uid of the custom resource. We can always fetch the custom resource in the Operator reconcile and get hold of the uid, but the custom resource might already have been fetched by the SDK and it can pass uid as ansible_operator_meta.uid. That would save an extra fetch on the custom resource.
Describe the solution you'd like.
Described above as part of problem statement.
Passing the uid as ansible_operator_meta.uid is an additive change and should not affect any Ansible Operator adopter

/language ansible

when a k8s resource is created outside of Operator process
Don't really understand what you mean by this. If a resource is created outside the operator process, it should be handled by whatever created it, not the operator's controller. Do you have an example of what you mean here?

The only thing like that I can think if is when you create something like a Deployment which has dependent resources, those should be handled by the controller for the Deployment resource.

The only thing like that I can think if is when you create something like a Deployment which has dependent resources, those should be handled by the controller for the Deployment resource.

There are two examples in the usecase that I work on...

When a StatefulSet is created, the PVCs that get created from the volumeClaimTemplates of StatefulSet are not owned by anyone. The ownerReferences for the PVCs needs to be specified in the StatefulSet.volumeClaimTemplates

In the CloudPak for Data platform from IBM that I work on, we have a usecase where certain resources like ConfigMap objects get created in a different container which is owned by the platform (triggered via a REST API call from Operator). Those ConfigMap objects which are created outside need to be owned later upon creation  (not really an atomic operation though).


Could not download real-capture data (Bi et al)

Hi! Thanks for the wonderful work!
When I download the real-world data using this, I only get two .txt for each object.

I haven't found other resource for this dataset. Could you please share the complete dataset?
Sorry for the bother and looking forward to your reply!

Hello, @raynehe,
Were you able to find the dataset?

@Kai-46, I am having access issues with the data and the Google Drive URL seems to have access issues(Gdown is giving a permission error). Could you please help on this issue?


Add Algeria holidays

Useful links:

https://en.wikipedia.org/wiki/Public_holidays_in_Algeria
https://www.timeanddate.com/holidays/algeria/

Implemented in #1176


python3Packages.APScheduler: fix build

Motivation for this change
Fix build

Remove pytest-cov

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 139321 run on x86_64-linux 1

7 packages built:

flexget
home-assistant
python38Packages.APScheduler
python38Packages.python-telegram-bot
python39Packages.APScheduler
python39Packages.python-telegram-bot
vorta


Add kernLib

Implement a library for producing optimal kerning tables. This involves three pieces: load, optimize, save.
The main input object we'll work with is a huge matrix of glyph-glyph kern values. Ie. no classes. All classes are expanded. One of the sparse matrix representations should be good enough. The load functions load kerning data from variety of formats (UFO, binary, AFDKO, ...) into the matrix form.
The optimizer, which might have various tunable parameters, takes the input kern matrix and produces optimal classes left and right classes, the class-based kern matrix, and the residual exception kern matrix. Though, that can be divided into deducing classes, and separately breaking the matrix down.  There will be tolerance parameters. Possibly even bucketize the values to get better compression (an idea that Tim Ahrens introduced to me); eg. by rounding X number of lower bits to 0.
The save routines convert the optimization output to various formats: UFO kern groups / dict, GPOS subtables, AAT kerx subtables, AFDKO dump, etc.
Optimizer should have tunable parameters that can optimize both for OpenType and AAT kerning formats.

Note that this has nothing to do with autokerning. This is a purely font binary file size optimizer.  This, however, might be able to find unintended kerning errors.
A few years ago I started some experiments with Singular Value Decomposition as well as k-Clustering. Neither was satisfactory or finished.  That code is here: https://github.com/behdad/playground/blob/master/eigenkernfea/eigenkernfea.py

A few first thoughts:
• For reference, here is the kerning palettization code Behdad mentioned.
• Could there be a parameter that allows for slightly lossy compression (i.e. kerning class generation) apart from the palettization? In other words, a certain allowed deviation of the final pair value compared to the input.
• Conceptually, should the input matrix distinguish between explicit zero values (i.e. the type designer says, “this kerning value must be zero”) and undefined values? Of course, one would rarely find zero-value kerning when reading in an OT font but I feel it may be valuable when using “design input” directly.
• Would it make sense to try and use a source that defines which pairs could possibly occur, or, more precisely, how likely a pair is to occur? I am thinking of a pair frequency list like the one I have  here. Knowing (or, assuming) that certain pairs will not occur in real life will allow for more grouping, i.e. fewer classes and exceptions.
The approach could be to say, the tool limits the number of pairs to x, while minimizing the total error (missing or slightly off kerning values) in a typical document. I am regularly doing this when creating webfonts for my clients (other type designers and foundries).
One challenge is to deduce the frequency of glyph pairs that do not have Unicode values but are activated via OT features. They could adopt the frequencies of their respective “parent glyph(s)” but possibly with a factor (say, A.sc-V.sc is less likely to occur than A-V).

Singular Value Decomposition and k-Clustering are far beyond my knowledge of computer science, but, from a quick look at the illustrations in Wikipedia, it seems that these methods treat the data as points in a real 2D space, in other words, the order of the rows and columns is relevant. Is this right?
In contrast, in our 2D expanded kerning matrix, one could re-order the columns or rows without any effect on the font (but drastically changing which points are close to each other). In that sense, our matrix has additional irrelevant information (the order of rows and columns), which me must ignore when determining the classes. But maybe I am completely misunderstanding what your code does.

@m4rc1e how does that tool differ from https://github.com/adobe-type-tools/kern-dump?

@moyogo thanks, never realised this existed. This does exactly what I need https://github.com/adobe-type-tools/kern-dump/blob/master/getKerningPairsFromOTF.py.

Singular Value Decomposition and k-Clustering are far beyond my knowledge of computer science, but, from a quick look at the illustrations in Wikipedia, it seems that these methods treat the data as points in a real 2D space, in other words, the order of the rows and columns is relevant. Is this right?

No. They treat the data for each row as a point in a high-dimensional space, with each column a dimension...

Will happen when it happens.


[storage-initializer] add support for aws sts

/kind feature
Describe the solution you'd like
currently the only understood AWS credentials are the following environment variables:
AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY.
Another common and more secure method of authenticating a connection in kubernetes is to use STS federation and kube projected token. The approach is described here1. All standard aws clients understand this approach based on the well known environment variables so normally one decides which to use by populating certain environment variable and not others.
But because here the client is really a minio client and not a aws s3 client, the sts federation approach is not automatically understood.
The request is to add this capability.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

#831  Should solve this.
PR => #1472

How does this decision affect users that do not use AWS infrastructure?  Why are proprietary solutions creeping into an open source project?
Sent from my iPhone

On Apr 10, 2021, at 07:49, Dan Sun @.***> wrote:

Closed #1451.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@ReggieCarey Support doesn't mean you have to use it or that it is the only option to use.

Hi guys,
I'm soo glad this is fixed, however there seems to be some missing dependencies in order to make this work with the provided upstream components.
I think the docker image quay.io/aipipeline/kfserving-component referenced in the Kubeflow Pipelines samples in component.yaml file is still not updated to the 0.6 release.  I can adapt my use-case to run the component image on private repo but I would like to help if possible.
I don't know which CI is in charge of docker building,
@iptizer  , @DavidSpek, is there some other PR, maybe (https://github.com/kubeflow/pipelines/issues/5700) still in need of attention? Can I be of any help to this issue somehow?


Windows GUI: Fix installer out path after assets

Fix https://github.com/MediaArea/MediaInfo/pull/960#issuecomment-2508390115

Shouldn't it be added also to https://github.com/MediaArea/MediaInfo/blob/master/Source/Install/MediaInfo_GUI_Windows_x64.nsi#L156 ?

Shouldn't it be added also to https://github.com/MediaArea/MediaInfo/blob/master/Source/Install/MediaInfo_GUI_Windows_x64.nsi#L156 ?

Not needed because there is immediately a SetOutPath at https://github.com/MediaArea/MediaInfo/blob/a1eea673df423b4b98cd3b036f7acaf057c60940/Source/Install/MediaInfo_GUI_Windows_x64.nsi#L159 before any further file operations. This difference is why I missed it in the combined installer.

I prefer to normalize the order of lines between installers so we don't miss such issue in the future.
I force pushed the removal of your "hot fix" and the reordering of lines and also the the horizontal position of the lines depending on the arch, so it is easier to do a diff between the installer files.

By the way, how/where do you see the impact of the fix? In practice I don't see a difference on Win11 (I am very new to this OS, so I may miss a lot of things).

I force pushed the removal of your "hot fix"

Can just remove me as author then won't have the unverified tag.

By the way, how/where do you see the impact of the fix? In practice I don't see a difference on Win11 (I am very new to this OS, so I may miss a lot of things).

Before this fix, some files were wrongly placed in Assets folder. The files in install folder should be as follows:
>tree /f "C:\Program Files\MediaInfo"
C:\PROGRAM FILES\MEDIAINFO
│   History.txt
│   LIBCURL.DLL
│   License.html
│   MediaInfo.dll
│   MediaInfo.exe
│   MediaInfo.url
│   MediaInfo_InfoTip.dll
│   MediaInfo_PackageHelper.dll
│   MediaInfo_SparsePackage.msix
│   MediaInfo_WindowsShellExtension.dll
│   ReadMe.txt
│   resources.pri
│   uninst.exe
│   WebView2Loader.dll
│
├───Assets
│       Square150x150Logo.scale-400.png
│       Square44x44Logo.altform-unplated_scale-400.png
│       Square44x44Logo.scale-400.png
│
└───Plugin
    ├───Custom
    │       en.Example.csv
    │       en.Example_HTML.csv
    │       Example.csv
    │       Example_HTML.csv
    │       fr.Example.csv
    │       it.Esempio.csv
    │       it.Esempio_HTML.csv
    │       Table by fields, compact (HTML).csv
    │       Table by fields, short (HTML).csv
    │       Table by fields, standard (HTML).csv
    │       Table by fields, verbose (HTML).csv
    │       Table by streams, compact (HTML).csv
    │       Table by streams, short (HTML).csv
    │       Table by streams, standard (HTML).csv
    │       Table by streams, verbose (HTML).csv
    │       XML.csv
    │       zzz_Contrib - Dusil (HTML).csv
    │
    ├───Language
    │       ar.csv
    │       be.csv
    │       bg.csv
    │       ca.csv
    │       cs.csv
    │       da.csv
    │       de.csv
    │       en.csv
    │       es.csv
    │       eu.csv
    │       fa.csv
    │       fr.csv
    │       gl.csv
    │       gr.csv
    │       hr.csv
    │       hu.csv
    │       hy.csv
    │       id.csv
    │       it.csv
    │       ja.csv
    │       ka.csv
    │       ko.csv
    │       lt.csv
    │       nl.csv
    │       pl.csv
    │       pt-BR.csv
    │       pt.csv
    │       ro.csv
    │       ru.csv
    │       sk.csv
    │       sq.csv
    │       sv.csv
    │       th.csv
    │       tr.csv
    │       uk.csv
    │       zh-CN.csv
    │       zh-HK.csv
    │       zh-TW.csv
    │
    ├───Sheet
    │       Example.csv
    │       Export example.csv
    │
    └───Tree
            Example.csv

Before this fix, some files were wrongly placed in Assets folder. The files in install folder should be as follows:

Sorry, I wanted to mean what is the impact on not having the asset found by the DLL?

Before this fix, some files were wrongly placed in Assets folder. The files in install folder should be as follows:

Sorry, I wanted to mean what is the impact on not having the asset found by the DLL?

The PNG images are referenced by the MSIX. Without them, the taskbar icon will be missing.

The PNG images are referenced by the MSIX. Without them, the taskbar icon will be missing.

I missed something. Here it is with the NSI installer, I don't see about which MSIX you are talking about.

The PNG images are referenced by the MSIX. Without them, the taskbar icon will be missing.

I missed something. Here it is with the NSI installer, I don't see about which MSIX you are talking about.

The XML manifest inside MediaInfo_SparsePackage.msix references the PNGs in the Assets folder.

And what is the impact? I use the buggy installer and MediaInfo icon is seen in the taskbar (as in the past without the sparse package).

The impact is as I mentioned in https://github.com/MediaArea/MediaInfo/pull/979#issuecomment-2508953646. Some files are wrongly placed in the wrong place that's all. No change/effect in functionality. The only way to detect the buggy installer is to inspect the install directory.

Some files are wrongly placed in the wrong place that's all. No change/effect in functionality.

I don't get it: if no change/effect, why installing them? We can just not install them (and remove the reference from the MSIX).
I guess that you add them for a reason, I try to understand how they are used.

I don't get it: if no change/effect, why installing them? We can just not install them (and remove the reference from the MSIX). I guess that you add them for a reason, I try to understand how they are used.

See my edit. The wrongly placed files are not the PNGs or any of the new files that are used by the Windows 11 context menu. So there is no change in functionality there. I mean the fix of installer has no effect on functionality not that the files we are installing has no effect.
Unrelated to this fix, the MSIX has to reference the PNGs to be valid. The PNGs have to be present for the taskbar icon.

The PNGs have to be present for the taskbar icon.

Oops, right, I was thinking the wrong way.
OK, I reformulate my question: before the sparse package, the task bar was using the MediaInfo binary icon, does it mean that now the PNG is used?
A related question: what is the actual impact of having the sparse package? My understanding of your previous comments is that it shows something as more win11 compatible, how to see it?

before the sparse package, the task bar was using the MediaInfo binary icon, does it mean that now the PNG is used?

Yes that is what I found out. When there is a package installed, it behaves like a MSIX packaged app so the AppxManifest and PNGs are used instead of binary icon. Since it is a sparse package, the Assets are in the install directory instead of in the MSIX itself. I have seen other applications packaging the Assets in MSIX instead which results in missing taskbar icon as well as uselessly large MSIX file.

A related question: what is the actual impact of having the sparse package?

The main purpose of the sparse package here is to gain access to the new modern context menu. You can see the new DLL is referenced in the AppxManifest along with all the file extensions we want to register.
In general, the sparse package grants an application package identity. This enables an unpackaged app to use features that require package identity which are traditionally only accessibly by packaged apps. Other features that require package identity other than the new context menu can be found here: https://learn.microsoft.com/en-us/windows/apps/desktop/modernize/modernize-packaged-apps

how to see it?

If you see Task Manager or Process Explorer and enable the package name column, you will see that MediaInfo has a package name when the sparse package is installed. That is package identity. Sparse package makes the app more like a MSIX/Store packaged app.

Snapshot 20241130-2 looks good.

The main purpose of the sparse package here is to gain access to the new modern context menu.

This is what I was missing, thank you for the explanation.
(I remind now that you already explained it but I forgot it, it is so weird to have to add a PNG for having what we were having without the MSIX but we need the MSIX for acceding the context menu)

@JeromeMartinez side note: Probably can replace MediaInfo UWP store version with a packaged VCL or Qt one so that achieve feature parity and no need to maintain so many different code. If not mistaken some of Microsoft's updated pre-installed apps from the Store are not using UWP anymore.

Probably can replace MediaInfo UWP store version with a packaged VCL or Qt one so that achieve feature parity and no need to maintain so many different code.

We created the UWP version for having a presence on the Windows App Store before they accept Win32 apps. We need to think about if the UWP version still have a value added (UI more "Windows"? Well, it seems that people don't really see a Windows style), if not we may switch to the VCL (for the moment) one.

UWP version still have a value added (UI more "Windows"? Well, it seems that people don't really see a Windows style)

From what I see, UWP is abandoned by Microsoft themselves. Microsoft's own apps are mostly updated to use WinUI3. That is the new 'Windows style' for Windows 11 with Mica material. Microsoft now encourages use of Windows App SDK/WinUI or WPF as development platform. There is also a guide from Microsoft to migrate from UWP to Windows App SDK.

From what I see, UWP is abandoned by Microsoft themselves.

Not stable... But right, maybe time for us to move from UWP and push the VCL version on the Windows Store. But I guess this will not be easy to move, but having the Win11 option also on the Windows Store is needed, I'll check with @g-maxime when we have time for that.

But I guess this will not be easy to move, but having the Win11 option also on the Windows Store is needed

I never published apps to store but a rough idea I have is to modify the sparse package manifest to turn it into a fully packaged win32 app. Or modify the Qt MSIX manifest for the VCL one. Then the graph/ffmpeg plugins can probably be published to store as a dependent but optional package if not wanting to bundle everything together. Something like what I done for the Qt MSIX should be publishable to Store with working context menu. Not 100% sure it will work since I never published to Store.

Then the graph/ffmpeg plugins can probably be published to store as a dependent but optional package if not wanting to bundle everything together.

People using the Store don't really care about package sizes, so all in one there :).

Something like what I done for the Qt MSIX should be publishable to Store with working context menu.

We will try...


The required SQLite PDO driver IS NOT enabled.

I am running a windows 10 vm with php-8.1.2
i extracted all  the files and ran the command php -S localhost:8080 but I got the error
"The required SQLite PDO driver IS NOT enabled."
i edited php file like so

;extension=pdo_pgsql
extension=pdo_sqlite
;extension=pgsql
;extension=shmop

; The MIBS data available in the PHP distribution must be installed.
; See https://www.php.net/manual/en/snmp.installation.php
;extension=snmp

;extension=soap
;extension=sockets
;extension=sodium
extension=sqlite3
;extension=tidy

but still got the same error

Did you restart apache or whatever you use?

yes i did but still got the same error

Run phpinfo(); on a page and check if your PHP says that PDO SQLite is enabled.


Zoom without CTRL/CMD

Is your feature request related to a problem? Please describe.
I am using egui_plot to draw a plot and currently have to press ctrl/cmd in order to zoom in and out with the scroll wheel.
Describe the solution you'd like
I want to zoom in and out with the scroll wheel directly without having to press ctrl/cmd.
Describe alternatives you've considered
Somehow hacking that in myself. But this got even harder because now scrolling is done by egui and seems to be strictly coupled with ctrl/cmd.

We do have an example at least: https://github.com/emilk/egui/tree/0f6310c598b5be92f339c9275a00d5decd838c1b/examples/custom_plot_manipulation.

When I drag two fingers across my trackpad, I get 2D scroll events. That should pan the plot, not zoom. I don't see how you would distinguish that from a 1D scroll action on a mouse.

When I drag two fingers across my trackpad, I get 2D scroll events. That should pan the plot, not zoom. I don't see how you would distinguish that from a 1D scroll action on a mouse.

Dragging (if that's what you mean by pan) should only be done with pressing down.
I want to recreate something that feels like Google Maps or something

I can see why you would want that. For contrast, the Maps app on my Mac works pretty similar to egui_plots, with pinch-to-zoom and scroll-to-pan.
I guess we want to add some settings then so users can control this behavior.


excludeMonitors still sends alert

Describe the bug
Alerts still get sent out (slack in our case) on a prefix for monitors that are set to be excluded.
Provide an example
config.yml
monitors:
  - file: monitorRPKI
    channel: rpki
    name: rpki-monitor
    params:
      thresholdMinPeers: 1
      checkUncovered: true

  - file: monitorROAS
    channel: rpki
    name: roas-monitor

prefixes.yml
111.222.333.0/24:
  description: myprefix
  asn:
    - 394256
  ignoreMorespecifics: false
  ignore: false
  excludeMonitors:
    - rpki-monitor
    - roas-monitor

Slack alert
rpki
The route 111.222.333.0/24 announced by AS394256 is not covered by a ROA. Top 1 most used AS paths: [redacted].

Expected behavior
No alert to be sent for prefixes that have excludeMonitors set. So no rpki/ROA alerts for prefixes with "rpki-monitor" set.
Are you using the binary or the source code?
Binary - 1.27.0
Thanks
Andrew
Tech Futures / AS394256

Hi @andrewmgee,
Thanks for reporting this. The only way I was able to reproduce this is if there is the option to monitor the AS in addition to the prefix. Could you confirm that you have in prefixes.yml something like:
options:
  monitorASns:
    '394256':
      group: noc

In that case, the alert is sent (despite the excludeMonitors set in prefixes.yml) because it gets matched by AS and not by prefix.
I can push a fix for monitorRPKI (not for monitorROAS) if you confirm me what described above.
Happy new year!

Hi @andrewmgee,
Thanks for reporting this. The only way I was able to reproduce this is if there is the option to monitor the AS in addition to the prefix. Could you confirm that you have in prefixes.yml something like:
options:
  monitorASns:
    '394256':
      group: noc

In that case, the alert is sent (despite the excludeMonitors set in prefixes.yml) because it gets matched by AS and not by prefix.
I can push a fix for monitorRPKI (not for monitorROAS) if you confirm me what described above.
Happy new year!

Hey @massimocandela
Yes, I do have the below in the prefixes.yml:
options:
  monitorASns:
    '394256':
      group: default

Fix for monitorRPKI would be much appreciated.
Thanks!
Happy new year!

Hey @massimocandela
Yes, I do have the below in the prefixes.yml:
options:
  monitorASns:
    '394256':
      group: default

Fix for monitorRPKI would be much appreciated.
Thanks!
Happy new year!

This is fixed, currently in release branch. It will go out with v1.26.1
Thanks again for reporting.

This is fixed, currently in release branch. It will go out with v1.26.1
Thanks again for reporting.


Cannot set codename for Content Group

I'm trying to script my models using TypeScript (migrating form JavaScript). When adding a new Content Type using the following code I get an error:
const BrandTypeData = (builder: ContentTypeElementsBuilder
    ): ContentTypeModels.IAddContentTypeData => {
    return {
        name: 'Brand',
        codename: 'brand',
        content_groups: [{
                codename: 'general',
                name: 'General'
            },
            {
                codename: 'seo',
                name: 'SEO'
            }
        ],
        elements: [...

The error I see is:

Type '{ codename: string; name: string; }' is not assignable to type 'IAddContentTypeContentGroup'.
Object literal may only specify known properties, and 'codename' does not exist in type 'IAddContentTypeContentGroup'.ts(2322)

I appreciate my codename here would match the default, but in some cases I wanted to be super-sure what I was getting so that I could add element to the type knowing I have the correct codename. Using vanilla JS for the import worked fine for this, but in TypeScript there is a limitation which looks like it is in the definition for `IAddContentTypeContentGroup
Is there a reason for it missing, or is it an oversight?

Fixed in vnext


fix: don't use the TypeScript parser for .js files

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
This patch limits the @typescript-eslint/parser to files with the .ts or .tsx extensions. This allows the original eslint / Standard.js parser to handle .js files instead.
Now, if the user activates babel-eslint to get Flow or other language extensions for js files, @typescript-eslint/parser can coexist peacefully with that.
Is there anything you'd like reviewers to focus on?
I originally discovered this issue as swansontec/eslint-config-standard-kit#3, so I have already made this same fix over there. However, I think the fix deserves to live upstream.
Another benefit is that this change makes these errors harder to get:
Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: rollup.config.js.
The file must be included in at least one of the projects provided

These errors used to happen because the @typescript-eslint/parser handed everything, but typical tsconfig.json files don't include everything. Working around this required hacks like the tsconfig.eslint.json file located in this repository, but those hacks are unnecessary now.

There is a mention of whether it's possible to extends inside overrides, here:

A glob specific configuration can have extends setting, but the root property in the extended configs is ignored.

Thanks!


Fix json-editor size in create collection and filters in browse / watch collection

change injected style height by min-height
set default size to 250px

Codecov Report

Merging #385 into 2.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x     #385   +/-   ##
=======================================
  Coverage   85.89%   85.89%
=======================================
  Files          38       38
  Lines         723      723
=======================================
  Hits          621      621
  Misses        102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b454c...9cff1af. Read the comment docs.


Fix potential typo in model configuration assignments

User description
The configuration file appears to have a possible typo in the model assignments. It seems that the values for model and model_turbo are swapped. Specifically:

model should reference gpt-4o-2024-08-06.
model_turbo should reference gpt-4-turbo-2024-04-09.

This PR corrects the assignments to align with expected naming conventions.

PR Type
bug_fix

Description

Corrected a typo in the configuration file where model and model_turbo were incorrectly assigned.
Ensured model references gpt-4o-2024-08-06 and model_turbo references gpt-4-turbo-2024-04-09.

Changes walkthrough 📝
Relevant filesBug fix

configuration.tomlFix typo in model configuration assignments

pr_agent/settings/configuration.toml
Corrected the assignment of model and model_turbo.  model now references gpt-4o-2024-08-06.  model_turbo now references gpt-4-turbo-2024-04-09.

+2/-2

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Its not a typo.
OpenAI made a mess of the model names. The "turbo" model is actually the slow and better one
We might update the default models, but it will be for different models

closing, as this PR is not relevant


(SERVER-251) Add a couple of more jruby flush tests

This commit adds a couple of more JRuby pool flush tests:

Make multiple JRuby flush requests back-to-back and ensure that
nothing obviously bad happens.

Ensure that a file handle open from Ruby code run in a
ScriptingContainer is not automatically invalidated when a
pool flush is requested.

  Wrong branch target.  Closing....


Dirk failed to obtain account available in ethdo

After a new validator got activated on mainnet, Vouch tried to access the account on Dirk, which failed to obtain the account from ethdo. Listing all accounts in ethdo, the account that Dirk failed to obtain was visible there.
Here is the log from Dirk:
{"level":"trace","service":"fetcher","impl":"mem","path":"account-01/validators/007","time":"2021-02-26T08:59:59+01:00","message":"Fetching account"}
{"level":"trace","service":"fetcher","impl":"mem","path":"account-01/validators/007","time":"2021-02-26T08:59:59+01:00","message":"Fetching wallet"}
{"level":"trace","service":"fetcher","impl":"mem","path":"account-01/validators/007","time":"2021-02-26T08:59:59+01:00","message":"Wallet found in cache"}
{"level":"warn","service":"fetcher","impl":"mem","path":"account-01/validators/007","error":"no account with name \"validators/007\"","time":"2021-02-26T08:59:59+01:00","message":"Account not found"}
{"level":"warn","service":"signer","impl":"standard","error":"failed to obtain account by name: no account with name \"validators/007\"","result":"denied","time":"2021-02-26T08:59:59+01:00","message":"Did not obtain account; denied"}

After a simple restart of Dirk, it was able to find the account and sign messages with it.

Dirk keeps a cache of known and unknown accounts, to speed up signing.  In this situation an account was added, but after a request to Dirk had been made for the account.  In this situation Dirk retains the negative cache entry, hence the mismatch.
Invalidating the cache here would be relatively expensive in terms of going back to the filesystem each time to look up potential negative entries, and so is not something that we would look to implement.  As mentioned, a restart would clear the cache in this situation and allow Dirk to use the new account.


Incompatibility with autocomplete-plus tab completion

Emmet's tab completion clobbers autocomplete-plus's tab completion. I don't think this used to be the case until a few updates ago. Can we make Emmet using tab configurable?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/9223899-incompatibility-with-autocomplete-plus-tab-completion?utm_campaign=plugin&utm_content=tracker%2F535900&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F535900&utm_medium=issues&utm_source=github).

I believe the fix is to add this to your keymaps.cson:
'atom-text-editor[data-grammar~="css"]:not([mini])':
    'tab': 'autocomplete-plus:activate'

I haven't tried it, though.

Like @silvenon said, you can fix this by editing your keymaps.cson file. It's surprisingly flexible and allows you to customize most keybindings to satisfy your needs. That being said, I agree that perhaps the default keybindings should be modified to fix this.
During my initial switch to Atom, there were three things that bugged me about autocomplete:

When using Vim mode, pressing escape would exit insert mode rather than closing autocomplete.
Pressing tab would expand using Emmet rather than confirming the autocomplete suggestion.
Pressing ctrl-space would open autocomplete rather than autocomplete+.

I was able to fix all of these by adding the following to my keymap file. (Finding out how easy it is to do this was a pleasant surprise, considering I spent hours trying to do the same thing in the Coda version of Emmet a few months ago.)
# Prevent escape from changing Vim modes when autocomplete is open

'atom-text-editor.vim-mode.autocomplete-active':
  'escape': 'autocomplete-plus:cancel'

# Prevent tab from expanding using Emmet when autocomplete is open

'atom-text-editor.autocomplete-active:not([mini])':
  'tab': 'autocomplete-plus:confirm'

# Allow ctrl-space to toggle autocomplete-plus

'atom-text-editor.autocomplete-active':
  'ctrl-space': 'autocomplete-plus:cancel'

'atom-text-editor:not(.autocomplete-active)':
  'ctrl-space': 'autocomplete-plus:activate'

If you want to use Tab with Autocomplete and Emmet, this is what I do.
Install autocomplete-plus and autocomplete-snippets (and whatever other autocomplete-plus provider packages you want):
apm install autocomplete-plus autocomplete-snippets

Next, edit your keymap.cson file (File > Open Your Keymap) and paste this at the bottom:
# Stop emmet from hijacking tab from snippets and autocomplete
'atom-text-editor.autocomplete-active:not([mini])':
  'tab': 'autocomplete-plus:confirm'

# Stop emmet from hijacking tab from snippet tab stops
'atom-text-editor[data-grammar="text html basic"]:not([mini]), atom-text-editor[data-grammar~="jade"]:not([mini]), atom-text-editor[data-grammar~="css"]:not([mini]), atom-text-editor[data-grammar~="sass"]:not([mini])':
  'tab': 'snippets:next-tab-stop'

This allows you to still use Tab with Emmet, but only when the autocomplete popup is not open.

If you start typing, and autocomplete pops up, you can press Tab for autocomplete.
If autocomplete doesn't pop up (because there are no matches), you can press Tab and get an Emmet expansion.
If autocomplete does pop up, but you want to use an Emmet expansion, you can press Esc to close the autocomplete popup and then press Tab for an Emmet expansion.

The reason you need to install autocomplete-snippets is because Emmet takes precedence over snippets, but if you have an autocomplete popup open and this keymapping in place, then the snippet will take precedence.
The best of both worlds. The only downside I've seen so far is that you can't expand Emmet abbreviations while in a snippet tab stop context. You can remove the second keymapping above, but they you won't be able to navigate snippet tab stops at all. I haven't found a way to escape a snippet tab stop context.

@jordanbtucker Was really hoping this would fix it, but no :(
Just completely stops Emmet from having element expansions from working.
Maybe this is because of updates since this was posted?
Am using Atom 0.194.0, Emmet 2.3.8 and Autocomplete Plus 2.12.0 on Windows 7 Pro x64.

Hmm, yep same here.
Isn't the best approach to give an option in the Emmet settings to choose the expand button? Like autocomplete-plus lets you switch between tab, enter and tab+enter? I would be happy with just Emmet expanding with shift+apple+e and leave the tab button just for traditional auto completes.
At the moment I just have to have Emmet disabled since its not playing well with other packages :S

@krypsin @jedrichards I'm not able to reproduce the issue even after updating Atom and its packages. Can you open the Keybinding Resolver (Packages > Keybinding Resolver > Toggle), then press Tab, take a screenshot, and post it here?

The ultimate solutions for this issue is to extend autocomplete-plus package for detecting available snippets by prefix. E.g. the workflow should look like this:

Emmet overrides Tab key completely
When you try to expand something, Emmet extracts abbreviation from current caret position.
If this is a simple abbreviation like foo or div, ask autocomplete-plus for matched abbreviations.
If returned result is non-empty list, abort Tab key handling and pass event further. Otherwise expand abbreviation as usual. Or maybe use matched snippets as Emmet abbreviation parts.

This will greatly reduce amount of hacks and quirks required to handle Tab key properly.
I did a quick look on autocomplete package and didn’t found valid ways to retrieve snippets matching given abbreviation. Maybe someone (or me, eventually) will contribute such improvement to autocomplete package?

@sergeche Thanks for the research and potential solution. It's probably best to post that in the autocomplete-plus repo so the developers can see it.

@jedrichards big thanks for your instructions!

@jordanbtucker Thanks for the temporary solution. Works great.

Worked for me, thanks!  But I had to delete this line which was already in my Keymaps.cson file:
'atom-text-editor[data-grammar~="jsx"]:not([mini])':   'tab': 'emmet:expand-abbreviation-with-tab'

@jordanbtucker Thank you so much for your solution. It works for the most part, however it doesn't work when getting emmet to generate a bit of code from a more advanced emmet instruction, like div.foo.

@damirkotoric If you're having trouble, please follow the steps outlined in my previous comment and I'll take a look. Thanks.

Thanks @jordanbtucker the problem seemed to have been that I also tied the enter key to the same function as the tab key, but that causes problems.

I could be missing something but adding a keymapping for the tab disables the tab for indent.

Heads up. I've switched to Visual Studio Code and haven't touched Atom in months, so I don't know how accurate my solution is anymore.
Also, I haven't run into any issues with Emmet and autocomplete ("code completion" as VS Code calls it) since switching to VS Code.

Check out new alpha of Emmet 2, which is solely an autocomplete+ provider: https://github.com/emmetio/atom-plugin

I just installed emmets-snippets-compatibilty plugin.

@micos7 what is the outcome of using that

I've installed Atom 1.46.0 x64 with emmet 2.4.3 after reinstalling Windows 10 Pro two days ago and forgot to backup by keymap file beforehand. I used to have emmet on Ctrl+E and just let Atom do it's thing with tab but now emmet is overriding tab for everything, so I can't add indents anywhere but the very start of lines or use snippets anywhere in any file that emmet matches. I've tried various solutions found all over the web for this, but they don't work for me - they either add one specific tab behaviour before emmet takes over again in all other cases, or disable tab completely for everything. Yes I am reloading Atom between keymap edits, and no I do not use autocomplete-plus or any other custom autocomplete packages.
I'm just going to have to delete the tab declaration from emmet's own keymap and hope I remember to do so every time the package updates.
My ideal solution: Atom's settings should provide an easy way to edit / disable package key bindings.
Acceptable solution: any package with keybindings should make them configurable in the package settings without requiring users to edit config files manually, especially not package config files which will be overwritten when the package updates.

The next version of Atom plugin will capture abbreviation as you type and act as autocomplete provider (autocomplete-plus is bundled with Atom by default), same as new Sublime Text plugin: https://github.com/emmetio/sublime-text-plugin

The Atom package emmet-snippets-compatibility-but-less-extreme solved the problem easily to me.


Pdf.js ES5 version contains non ES6 syntax(Arrow functions)

Attach (recommended) or Link to PDF file here: dummy.pdf
Configuration:

Web browser and its version: Internet Explorer
Operating system and its version: Windows 10
PDF.js version: 2.7.570 (es5) and 2.8.39 (es5)
Is a browser extension: No

Steps to reproduce the problem:

Just open the pdf file on Internet Explorer

What is the expected behavior? (add screenshot)
Showing the pdf file

What went wrong? (add screenshot)
pdf.js contains arrow function which is not supported on Internet Explorer

Duplicate of #12906


IntelliSense tips rendering on top of others and with wrong height

In some cases you can get into a mess where the IntelliSense tips render on top of another and where they do not scale to the amount of text provided.

VSCode Version: 1.6.1
OS Version: OSX 10.11.6 (15G1004)

Steps to Reproduce:

Included photos on how to reproduce this. For this example I just have a Python script with a few commands.

Case No. 1

Case No. 2

@adamabernathy this is an issue (https://github.com/DonJayamanne/pythonVSCode/issues/368) with the Python extension.
The issue has been resolved and fix will be in the next release.

fyi @joaomoreno


WF-73 Added tests for new workflow process-instance STOP endpoint

Hey @taylordowns2000. I have added the stop-process-instance endpoint and fixed a related bug in swagger.yml. Refering to our previous chat, I'm satisfied that there is solid case to provide a way to stop a process instance. Here is a similar implementation for Camunda.


[WFRP4e System] Items with 0.01 encumbrance (like coins) sometimes give very precise Encumbrance values

Sometimes the Encumbrance Counter gives really precise values such as "1.1400000000000001"
To reproduce:
Create a character. Give it varying amounts of odd coins (or other items with 0.1 or 0.01 encumbrance). At certain values the Encumbrance Counter will not round up or down correctly.
From: thefirst5foundry: 11.315wfrp4e: 7.1.2wfrp4e-core: 5.0.2Active Modules: quick-insert

I report something similar earlier:
https://github.com/moo-man/WFRP4e-FoundryVTT/issues/1751


Update README.md

Just adding something to the stretch goals

Had another conflict so i moved my text to the very bottom hopefully this doesnt mess up any other submissions


[Feature]: Vesting tokens in Polkaswap

User stories

As a
I want to
So that

Founder/advisor of the team
I want to send RLST tokens to receivers with additional conditions
To be sure holders will get the tokens and can interact with them in some time

Acceptance criteria

The user wants to vest tokens to another user.

The Polkaswap allows vesting tokens on the Asset page in the button Send.

The user clicks on the button Send

The Polkaswap shows the default fields of sending token + switcher by clicking the user can see

Period of vesting

Select a period

Per day
Per week
Per month

Select the day of the month
In a month only 30 days

Percentages of tokens to unlock each period

The user provides all required information and clicks on the button Send

The Polkaswap uses vesting pallets to send tokens to the receiver.

Definition of Done

Each user can vest tokens to another address.
The user can set up of period to unlock tokens and a token percentage on the account of the receiver.
The receiver gets tokens and for some period they will be unlocked.

Verified on https://exchange-1564.dev.sora2.tachi.soramitsu.co.jp/#/wallet


Documentation is somewhat out of date

I'd like to automate API documentation generation, and improve its visual design. I've begun adding markup comments on several of the endpoint files, but the input format is still nebulous and I need to write a generator that consumes them.

This is loosely a continuation of #61

Late update, the generator is written and can be operated through npm run generate-docs, and the loader page is done, but the documentation itself is still incomplete. I need to either write a resolver for TS types or manually add all of the output fields as @return things.


Disable flaky test on Cygwin

Unclear why sending a SIGQUIT signal sometimes works and sometimes doesn't but it's probably some kind of race condition in Cygwin's emulation layer.
Fixes: https://github.com/quickjs-ng/quickjs/issues/184

Can we try SIGTERM perhaps? I think I saw the OpenBSD or FreeBSD port change the test that way.

I'd be surprised if that fixes the issue but sure, I'll open another PR.

It's clear from the CI that #203 didn't fix it. Merging this.


go/parser: support type alias

Support finding symbal in the package which has type alias defination in.

Unfortunately this doesn't work - type aliases need to retain all the methods of the original type.
For example, in the code below, doing a godef on the "Encode" in x.Encode does not find any definition, but it should.
package main
import "encoding/json"
func main() {
type foo = json.Encoder
x := new(foo)
_ = x.Encode
}

It might be nice to merge this with a FIXME at least for the short term. With this patch the parser will regard a package with type aliases as parseable, but in master if you call godef on a type that is even in the same package as a type alias, it won't work at all. For me godef is totally broken w/o this patch when I use type aliases.
I'd offer to code up the full fix but I'd have to learn more godef internals...

Superceded by #77


We should use code mirror.

Using Code mirror readers would be able to modify the javascript on the fly while reading. The changes would be reflected back in the visualization. Something like IPython Notebook.
What do you guys think?

@Ghost---Shadow  I think the first phase would be to complete all the chapters. After that, we could add Code Mirror. It's not a necessity, more like a feature.

That is why I closed it. Too much hassle.


Could de.rub.nds.tlsattacker:Attacks:3.6.0 drop off redundant dependencies to loose weight?

@JonSnowWhite Hi, I am a user of project de.rub.nds.tlsattacker:Attacks:3.6.0. I found that its pom file introduced 47 dependencies. However, among them, 5 libraries (10%) have not been used by your project (the redundant dependencies are listed below). Reduce these useless dependencies can help prevent conflicts between library versions. MeanWhile, it can minimize the total added size to projects. It can also help enable advanced scenarios for this project.
This PR helps de.rub.nds.tlsattacker:Attacks:3.6.0 lose weight :) I have tested the revised configuration in my local environment. It is safe to remove the unused libraries.
Best regards

Can one of the admins verify this patch?

Without having tried it - I vaguely remember that you need these dependencies if you are building TLS-Attacker with something newer than Java 8.