Focus input on label-click. Fixes #31

This change is

Adding for="input" doesn't prevent the host element from being temporarily focused which gives a nasty outline blink. Also, it's possible to click on the host element without clicking the label or the input:

I'd propose listening for click events on the host element and then manually focusing the input.

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

Just CSSing the outline is enough for not having the blinking border.
I would rather not add code about events, listening to click does not prevent the blinking effect, but it fixes clicking in a different area.
So probably if we want to fix all cases we need the outline: none, click => focus(), label for=. I'm not 100% positive about the click solution, elements extending control-state might have other focusable/clickable elements in its dom tree.

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

I don't think we have any choice not to add the event listeners because currently the focus is lost when you click outside the input (and label)

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

Done.

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

One more bug in Safari, focus highlight is not removed when defocusing by clicking outside the input:

open material design demo in Safari
focus an input
click somewhere else to remove the focus

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

vaadin-control-state-mixin.html, line 62 at r1 (raw file):

      this.addEventListener('focus', e => this._focus(e));
      this.addEventListener('blur', () => this._setFocused(false));
      this.addEventListener('click', e => this._focus(e));

Normally the focus happens after mousedown already, the following click is pretty late. Can we use mousedown here?

vaadin-input.html, line 71 at r1 (raw file):

    </style>

    <label id="label" for="input" on-click="focus">[[label]]</label>

In Shady DOM ids are global, for="input" always focuses the first input on the page. Happens in Safari at least. Steps:

open material design demos in safari
click 3rd input’s label
first input is focused. 3rd input is highlighted, but does not have focus.

Comments from Reviewable

One more bug in Safari, focus highlight is not removed when defocusing by clicking outside the input:

Apparently It was failing before this PR. We we did a refactoring we thought the listener should be set to the host element. Moving the listener to the focusable internal element fixes it.
Done

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.

vaadin-control-state-mixin.html, line 62 at r1 (raw file):
Previously, platosha (Anton Platonov) wrote…
Normally the focus happens after mousedown already, the following click is pretty late. Can we use mousedown here?

We need to move the focus, once the focus has actually been set to any element in the component.
The only way to do in mousedown is preventing, but we don't want to do that.

vaadin-input.html, line 71 at r1 (raw file):
Previously, platosha (Anton Platonov) wrote…
In Shady DOM ids are global, for="input" always focuses the first input on the page. Happens in Safari at least. Steps:

open material design demos in safari
click 3rd input’s label
first input is focused. 3rd input is highlighted, but does not have focus.

Done.

Comments from Reviewable

When defocusing with Shift+Tab, the focus highlight is not removed. Hapens in both Chrome and Safari, does not happen in master.
For all these focus and blur cases, should we maybe add tests?

Reviewed 2 of 3 files at r2.
Review status: 2 of 3 files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

Reviewed 1 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

Test for blur is quite difficult. The only reliable way is in shadow dom when you can blur natively. I already spent a lot of time trying to make blur tests work in FF

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

Shift+Tab should work correctly now

Review status: 2 of 3 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Reviewed 2 of 3 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Reviewed 1 of 1 files at r3, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Error thrown upon opening Ribbon Workbench from XRMtoolbox

After having many issues connectig the XRMtoolbox with 2fa it now works. Sadly this happens when opening the ribbon workbench (message pops up before even showing the application):
Error
An error occured when trying to display this plugin:
Cannot cast an object of type Microsoft.Xrm.Sdk.WebServiceClient.OrganizationWebProxyClient
to type Microsoft.Xrm.Sdk.Client.OrganizationServiceProxy.
OK

Thanks for reporting this. You will need to use the Ribbon Workbench as a solution installed until this is fixed. Thanks again.

From: xrmthomas<EMAIL_ADDRESS>Sent: Tuesday, September 25, 2018 6:29 pm
To: scottdurow/RibbonWorkbench
Cc: Subscribed
Subject: [scottdurow/RibbonWorkbench] Error thrown upon opening Ribbon Workbench from XRMtoolbox (#33)
After having many issues connectig the XRMtoolbox with 2fa it now works. Sadly this happens when opening the ribbon workbench (message pops up before even showing the application):
Error
An error occured when trying to display this plugin:
Cannot cast an object of type Microsoft.Xrm.Sdk.WebServiceClient.OrganizationWebProxyClient
to type Microsoft.Xrm.Sdk.Client.OrganizationServiceProxy.
OK
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fscottdurow%2FRibbonWorkbench%2Fissues%2F33&data=02|01||1e3ec05036ae411244e808d6230c6dc0|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636734933611456528&sdata=4ZCwwE2XrYVMLnFKNfQf%2FDM6dmJfIDmckH0hV38zhIg%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACvPUYP0d1LiNFhe4Pqna5gSjjvM37vyks5uemfvgaJpZM4W5ISY&data=02|01||1e3ec05036ae411244e808d6230c6dc0|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636734933611456528&sdata=cYdXcpcWFTKGJWFSR%2BB4ByIDFiSXX3IT8EPeYIN6uUo%3D&reserved=0.

Dear Scott,
That's a super fast response right there, thanks a lot! I will use the RWB the old "old fashion" way for now.
Please let me know if there's anything I can do to make your life easier while resolving this, I'd be happy to assist!
With kind regards
Thomas van de Vosse
Van: Scott Durow
Verstuurd: woensdag 26 september 08:33
Onderwerp: Re: [scottdurow/RibbonWorkbench] Error thrown upon opening Ribbon Workbench from XRMtoolbox (#33)
Aan: scottdurow/RibbonWorkbench
Cc: Thomas van de Vosse, Author
Thanks for reporting this. You will need to use the Ribbon Workbench as a solution installed until this is fixed. Thanks again.

From: xrmthomas<EMAIL_ADDRESS>Sent: Tuesday, September 25, 2018 6:29 pm
To: scottdurow/RibbonWorkbench
Cc: Subscribed
Subject: [scottdurow/RibbonWorkbench] Error thrown upon opening Ribbon Workbench from XRMtoolbox (#33)
After having many issues connectig the XRMtoolbox with 2fa it now works. Sadly this happens when opening the ribbon workbench (message pops up before even showing the application):
Error
An error occured when trying to display this plugin:
Cannot cast an object of type Microsoft.Xrm.Sdk.WebServiceClient.OrganizationWebProxyClient
to type Microsoft.Xrm.Sdk.Client.OrganizationServiceProxy.
OK
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fscottdurow%2FRibbonWorkbench%2Fissues%2F33&data=02|01||1e3ec05036ae411244e808d6230c6dc0|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636734933611456528&sdata=4ZCwwE2XrYVMLnFKNfQf%2FDM6dmJfIDmckH0hV38zhIg%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACvPUYP0d1LiNFhe4Pqna5gSjjvM37vyks5uemfvgaJpZM4W5ISY&data=02|01||1e3ec05036ae411244e808d6230c6dc0|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636734933611456528&sdata=cYdXcpcWFTKGJWFSR%2BB4ByIDFiSXX3IT8EPeYIN6uUo%3D&reserved=0.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/scottdurow/RibbonWorkbench/issues/33#issuecomment-424601033, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AphxR5xHcJPP9187Ts_-IInyV12XWsfcks5uex-wgaJpZM4W5ISY.

Hey @scottdurow
Any ideas when we might get this fixed?
Ollie

Hi @OliverFlint @scottdurow ,
I am having the same issue. How can we fixe this ?
Bobby


Fix metadata history

Closes: https://github.com/oceanprotocol/market/issues/773
Changes proposed in this PR:

Getting the transaction Id from the DDO rather than using the graphQL query
Removing unused networkId

This works as it is, however it gives a type error if event isn't defined in the DDO.d.ts
I have edited Ocean.js here: https://github.com/oceanprotocol/ocean.js/pull/965

made obsolete by #794


MDD/Hesperomys comparison: Hyracoidea through Pilosa

Continuing #22, #23, #26, #27, #28 with a number of small orders. There are a number of spelling issues, and some taxonomic disagreements in the lagomorphs.
Hyracoidea
Straightforward accepted changes:

New splits

Dendrohyrax validus < D. arboreus (minor: MDD has a typo in the comment, "form" for "from", and is missing page numbers for the Mammals of Africa reference, should be 158–161)

Relatedly, I noticed that there is a subspecies Dendrohyrax arboreus mimus recognized by Mammals of Africa; MDD also lists mimus as a synonym for arboreus. However, the original name was Procavia mima, and I believe it is a noun in apposition because there is no Latin adjective mimus. Therefore, the correct combination is Dendrohyrax arboreus mima.
Lagomorpha
Straightforward accepted changes:

New splits

Lepus altamirae < L. californicus
Pronolagus saundersiae < P. rupestris
Sylvilagus holzneri < S. floridanus
Ochotona argentata < O. pallasii
Ochotona vizier < O. rufescens
Ochotona qionglaiensis < O. thibetana
Ochotona turuchanensis < O. alpina

New mergers

Sylvilagus cognatus, S. robustus -> S. holzneri
Ochotona gloveri -> O. erythrotis
Ochotona morosa -> O. cansus
Ochotona fengii -> O. thibetana

Other taxonomic changes

Brachylagus idahoensis -> Sylvilagus idahoensis

Spelling changes

Ochotona roylei -> O. roylii

Recently extinct species

Prolagus sardus

Leporidae
Lepus microtis vs. L. victoriae (-)
I use Lepus microtis (agreeing with MSW 3), MDD uses Lepus victoriae (agreeing with HMW and Mammals of Africa).
MDD acknowledges that microtis is older but retains victoriae because it was used in previous publications and because microtis is a nomen nudum. I looked at the original description of microtis and it is definitely not a nomen nudum; Heuglin gives a thorough description that runs for about a page. The holotype is still in existence in Stuttgart. I don't find the argument that victoriae is in common usage particularly convincing either, since MSW3 used microtis and the species has previously been known under various other names.
Ochotonidae
Ochotona dabashanensis and O. xunhuaensis (-!)
I have these two as valid species, MDD synonymizes them under Ochotona sikimaria.
MDD cites Wang et al. (2020), but their tree places Ochotona sikimaria distant (within subgenus Ochotona) from dabashanensis and xunhuaensis (within subgenus Alienauroa, sister to O. sacraria). Therefore, I don't think synonymy with sikimaria is supported by the sources. However, a case could be made for synonymizing xunhuaensis and dabashanensis, as they are not reciprocally monophyletic; xunhuaensis would have priority.
Prolagidae
MDD puts Prolagus in its own family Prolagidae; I place it within Ochotonidae.
There is little hard evidence here (nobody seems to have gotten aDNA for Prolagus yet, for one), but the western European paleontological literature mostly keeps Prolagus within Ochotonidae. The most explicit discussion is in Angelone et al. (2014). However, Russian authors tend to follow Erbajeva and recognize the family Prolagidae. Prolagus apparently has a long independent history, going back into the Oligocene.
This is entirely a subjective question; I chose to put Prolagus within Ochotonidae because that's what almost all recent papers discussing it do. (Prolagus is a fairly common fossil in the Miocene and Pliocene of Europe.)
Ref: Angelone, C., Prieto, J. and Gross, M. 2014. Complement to the study of the pikas (Lagomorpha, Ochotonidae) from the Middle Miocene of Gratkorn, Austria. Palaeobiodiversity and Palaeoenvironments 94(1):125-134. doi:10.1007/s12549-013-0146-4
Microbiotheria
I accept the reclassification of Dromiciops into two species.
(Nothing to discuss in Macroscelidea, Monotremata, Notoryctemorphia, and Paucituberculata.)
Peramelemorphia
Straightforward accepted changes

Recently extinct species

Chaeropus ecaudatus
Chaeropus yirratji
Macrotis leucura

New splits

Isoodon peninsulae and I. auratus < I. obesulus

New mergers

Microperoryctes ornata -> M. longicauda (though I'd cite HMW instead of the Red List)

Peramelidae
Microperoryctes/Peroryctes spelling (-/+)
There are a few discrepancies around gender agreement in Microperoryctes and Peroryctes:

Hesp Microperoryctes longicaudus vs. MDD longicauda
Hesp Microperoryctes murinus vs. MDD murina
Hesp Peroryctes raffrayanus vs. MDD raffrayana

The generic names come from Greek ὀρύκτης oryktes "digger", which is masculine. Other similar names in extant mammals, like Notoryctes, Tachyoryctes, and Oryzorictes are consistently treated as masculine. Indeed, when Thomas named Peroryctes, he listed the type species as "P. raffrayanus". However, when Stein named Microperoryctes he used the feminine murina.
I think longicauda is reasonably interpreted as a noun in apposition, so I'm going to change back to MDD's term. However, the other two are clearly adjectives and I believe the masculine form is correct.
AI: Confirm and publish
Perissodactyla
Straightforward accepted changes

New mergers

Equus burchellii -> E. quagga
Equus onager -> E. hemionus
Ceratotherium cottoni -> C. simum

Pholidota
Manidae
Phataginus tetradactylus vs. tetradactyla (-)
MDD has tetradactyla, I have tetradactylus.
Phataginus is a masculine name, tetradactyla is an adjective, so the name should agree in gender with the genus. (Compare Cyclopes didactylus, which was originally Myrmecophaga didactyla.)
AI: Confirm and publish
Pilosa
Straightforward accepted changes

New splits

Bradypus crinitus < B. torquatus

Comment on subspecies/synonyms: pretty much all spelling differences at the synonym level will be ‘corrected’ to your list in the end because I hand typed them all and there are A TON of errors, so spelling wise, it’s fine to just leave the synonyms as they are for now and we’ll deal with it when we get there.
Lepus microtis vs. L. victoriae (-) – I’ll go ahead and use microtis, as the only reason I used victoriae was as a relict from starting with the HMW taxonomy. I didn’t really agree with using victoriae in the first place but never really had the push to change it.
Ochotona dabashanensis and O. xunhuaensis (-!) – So, I screwed the comments on this one up a bit on the MDD, they should both be considered synonyms of O. syrinx, not O. sikimaria (the correct comment should be this under O. syrinx: ‘has included O. sacraria and has been included under huangensis (now a synonym of dauurica); includes dabashanensis and xunhuaensis’, and not under O. sikimaria. I fixed that after sending you my matched list. Lissovsky, 2014 synonymized huangensis under dauurica and applied the name syrinx to the taxon formerly known as huangensis, also synonymizing xunhuaensis under the newly established O. syrinx. Liu et al., 2017 described dabashanensis, which was found to be paraphyletic with specimens labeled as xunhuaensis (= O. syrinx, which they do briefly acknowledge in their paper) by Wang et al., 2020, thus supporting the inclusion of dabashanensis under O. syrinx. I would strongly suggest using this arrangement, although I am up for discussion since Wang et al., 2020 did not strictly state that they were synonymizing dabashanensis under xunhuaensis (= O. syrinx). I also talked about it with Lissovsky out of pure confusion when working on the taxonomy of Ochotona for the Illustrated Checklist, and that is the arrangement he recommended.
Lissovsky, A.A. 2014. Taxonomic revision of pikas Ochotona (Lagomorpha, Mammalia) at the species level. Mammalia 78(2): 199–216.
Liu, S. Y., Jin, W., Liao, R., Sun, Z. Y., Zeng, T., Fu, J. R., ... & Chen, L. M. (2017). Phylogenetic study of Ochotona based on mitochondrial Cyt b and morphology with a description of one new subgenus and five new species. Acta Theriologica Sinica, 37(1), 1-43.
Wang, X., Liang, D., Jin, W., Tang, M., Liu, S., & Zhang, P. (2020). Out of Tibet: Genomic Perspectives on the Evolutionary History of Extant Pikas. Molecular Biology and Evolution, 37(6), 1577-1592.
Prolagidae – I will move Prolagus to Ochotonidae based on your recommendation: Angelone, C., Prieto, J. and Gross, M. 2014. Complement to the study of the pikas (Lagomorpha, Ochotonidae) from the Middle Miocene of Gratkorn, Austria. Palaeobiodiversity and Palaeoenvironments 94(1):125-134. doi:10.1007/s12549-013-0146-4
Hesp Microperoryctes longicaudus vs. MDD longicauda – retaining MDD (as you are)
Hesp Microperoryctes murinus vs. MDD murina – changing to Hesperomys on MDD.
Hesp Peroryctes raffrayanus vs. MDD raffrayana – changing to Hesperomys on MDD.
Phataginus tetradactylus vs. tetradactyla (-) – will change to match Hesperomys.

Thanks for the explanation around Ochotona, it's indeed quite confusing. I'll synonymize both of these species under syrinx as you suggest.


fix(remix-react): fix <Form> submit to not break formMethod functionality

Closes: #2162 and #3613 (supersedes both) – credits to @mdoury and @nrako

the <Form> component – unlike native <form> - does not respect the formmethod attribute set
on the submitter (the button submitting the form).

[x]  ~Docs~ N/A
[x]  Tests

Testing Strategy:
<Form method="post">
  <input name="eat" value="pizza" />
  <button type="submit"> Submit with GET </button>
</Form>
// should submit with a GET to `/?eat=pizza` but instead do a POST

See integration Bug-Report-Test via commit: 37b0140
test: failing test with <Form> not respecting formMethod 06333c1  Thu, 30 Jun 2022 00:33:15 +0200
Bug report integration test demonstrating how the `<Form>` component –
unlike native `<form>` - does not respect the `formmethod` attribute set on
the submitter (the `<button>` submitting the form).

fix(remix-react): submit <Form> w/method set by submitter formmethod bfd1f88  Thu, 30 Jun 2022 00:32:22 +0200
Fix `<Form>` component by not passing the form's `method` into the
`options` when calling the `submit(target, options)` function (created with
the `useSubmit()` hook). This ensures that the option does not take
precedence on any `formethod` set on the submitter which otherwise break the
`formmethod` functionality.

Since #3094 and #3094 the `<Form>` passes the "submitter" (if any) as the
`target` to the `submit(target, options)` (`useSubmitImpl`) which will
attempt to read the `formmethod`, `formaction` and `formenctype` attributes
on the target. Therefore, the responsability to infer which method should be
used should solely be on `useSubmitImpl` for the given
`target`.

Co-authored-by: Maxime Doury<EMAIL_ADDRESS>

That’s odd. I’m confident the functionality is broken, but I was able to work around it. I’ll create a repro example, then try to see why the tests aren’t catching it.

I can also confirm that this issue still occurs for me in the current release.

I am facing the same issue in the current release.

Until PR #4053 is merged in, you can use patch-package. It's literally a single line change. Copy this patch to your patches folder.
https://gist.github.com/kiliman/5a8dac031da8d545dc293fdcf82e9135

Until PR #4053 is merged in, you can use patch-package. It's literally a single line change. Copy this patch to your patches folder.
https://gist.github.com/kiliman/5a8dac031da8d545dc293fdcf82e9135

there's two solutions to this problem, the one provided by that PR and this. the issue is due to defaulting Form to method=get, which we should, however we check for options.method (and friends) lower in the component where options.method is always set as it has a default value in Form. I still lean toward the fix in #4053, but I'll leave it up to discussion


Problem when moving to "previous" picture...

Hi! Thank you for this Module! :)
It made it possible for my mirror to double as a "Photo frame" at the same time as being the MM. :)
Here is the problem:
I'm using HA (Node Red) to send notifications to the mirror for control, when moving "forward" in the picture queue it works, but when moving backwards it "stop" at random intervals. It does not "sick" at the same picture all the time...
So, here is the test setup.
I setup a specific Album (MM-Test) added 10 pictures (numbers) and recorded the "forward" and "backwards" clicks...
Here is the "clip"... Not sure what's going on or if it helps... :)
https://github.com/hermanho/MMM-GooglePhotos/assets/1011699/d733b238-f322-4461-b1a7-0bf7fdc1f23c
Let me know if you need anything else or what I'm doing wrong... :)
Thank you!
Best regards Erik

Hi Erik, could you please try branch https://github.com/hermanho/MMM-GooglePhotos/tree/fix/170 to see if it is working as expected?

Morning! Looks like its working! :) At least with the 10 pictures in the test album. :)
Another thing I'm noticing now is the the "fade" only happens when the picture shows, not when it's going away... It fades in but not out... But maybe that's in my end?
Anyway thank you! :)

Not sure, I would take time to diagnostic the face out. Let me release the fixing for backwards first.

Previous picture is now working. :) Thank you!


Add support for new Object reading type

With the new Object reading type the service should handle JSON as an object type if the Resource ValueType is Object. The JSON should be marshaled to a map[string]interface{} and set to the Value for and Object reading.

@cloudxxx8 , can you add this capabilities.


Twitter has stopped supporting data_widget_id for many of their widgets

I'd like to begin thank you for this awesome project.  I was very eager to use it in my own app, but I ran into trouble tracking down the data_widget_id for a user timeline.  Just wanted to let you know that it looks like the twitter team are ending support for ID's altogether.  See discussion here, in particular,

The new model means that there are no "widgets" as such any more - so there are no IDs.

Hope you are able to find a work-around or perhaps point users toward an alternate solution without too much grief.

Thanks for letting me know about this change. It looks like I'll be able to work around this.  Hopefully I'll have something in place by the end of the week.

@ShannonHeylmun I have a PR open that should address this: #21
Could you give it a whirl and see if this meets your needs? To embed a user timeline, you'd do something like this:
<twitter-timeline twitter-timeline-type='profile'
                  twitter-timeline-screen-name="'IAmAru'"
                  twitter-timeline-options='{"height": 500}'>
</twitter-timeline>

Version 0.6.0, with support for the new timeline embed capabilities, has been released. Thanks!

Looks excellent.  Very much appreciated!


feat(utils): remove utils#toHexInLittleEndian which is deprecated

Remove utils#toHexInLittleEndian which is deprecated
BREAKING CHANGE: Remove utils#toHexInLittleEndian which is deprecated

Codecov Report

Merging #476 into develop will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #476      +/-   ##
===========================================
- Coverage    95.26%   95.23%   -0.04%
===========================================
  Files           41       41
  Lines         1500     1490      -10
  Branches       298      296       -2
===========================================
- Hits          1429     1419      -10
  Misses          71       71

Impacted Files
Coverage Δ

packages/ckb-sdk-utils/src/convertors/index.ts
100.00% <100.00%> (ø)


Fix missing results in merged streams

hey @jpinsonneau
I've found a bug while poc'ing around new "return traffic" feature. I easily spot the bug with my PoC but it's harder to spot it with the current state, although it is definitely here. We can chat about that if you want.
Also took this opportunity to add a couple of stats that can be useful for debugging

thanks @jpinsonneau :)
/approve


Update an expected removal version.

Target Live Date: 2019-10-23

[ ] This has been reviewed and approved by (NAME)
[ ] I have run npm test locally and all tests pass.
[ ] I have added the appropriate type-something label.
[ ] I've staged the site and manually verified that my content displays correctly.

CC: @petele

:+1:

:+1:

:tada: This has been pushed live to https://developers.google.com/web/


Ensure GITHUB_ACCESS_TOKEN is passed to local binderhub

JupyterHub only passes requested environment variables to it's services.
Hopefully this finally fixes https://github.com/jupyterhub/binderhub/issues/1608

Wieeee!!!!!!!! Thank you for your work with binderhub, super happy about it!!


Request - 1.10.2 - Support for village box books and pokecube pokedex.

Title says it all.

The village box
In regards to the pokedex I don't expect to be able to open it because it has its own GUI and a bunch of other functions. I just want to store it there.

You can add books to the config files yourself. Even if @GirafiStudios does this by default you'd still need to update/delete your existing config for it to work.

Yeah as Joshie said you can add the book yourself in config/enchiridion/ssp.json.
I just did a release for 1.10.2 the other day adding support for more books, not planning to do any 1.10.2 releases anytime soon, unless it is a major bug.


Add system for logging errors via system chaining

Can now return anyhow::Result<()> from systems if you chain log_error

As there are no obtrusive changes I'll merge


Order groups by most recent chat activity

Reduced the create-notification block
Setting up for separate group/slug/questions notifications to show how many new unseen contracts there are on a group
Order groups by most recent chat activity on the sidebar and 'My groups' tab on the groups homepage


CAMEL-11424 Fix potential endless wait in camel-olingo2 and camel-olingo4

This fixes and issue where unhandled exceptions and runtime errors would cause responseHandler to never be triggered causing the routes to hang forever.

Thanks for the PR it has been merged. Do you mind closing this?


Port CLOTH3D dataset into SoftGym

Hi @Xingyu-Lin ! Could you please include the code you used in your recent paper (Mesh-based Dynamics with Occlusion Reasoning for Cloth Manipulation) to use the meshes of the CLOTH3D dataset in SoftGym?

We will release the code soon. Please stay tuned!


chores: add dependabot.yml to update dependency & upgrade all dependencies

Description

使用dependabot.yml来让dependabot自动升级依赖
更新了所有依赖

Checklist:

[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Have you linted your code locally prior to submission?
[ ] Have you successfully ran app with your changes locally?

Motrix relies on some old versions of npm packages, and cannot use automatic upgrades to the latest versions. This is a useless feature that you request to merge without verifying that it can run.


Error "json: invalid use of ,string struct tag, trying to unmarshal unquoted value into int64"

Grafana
Zabbix
Grafana-Zabbix Plugin

8.3.1
5.4.9
4.2.4

A few days ago , I updated the zabbix from 5.2.2 to 5.4.9
At the same time , I reinstall the grafana and grafana-zabbix plugin , but when I create the panel , I got this error
By the way , my zabbix use Elasticsearch to store history data
Thanks for helping
grafana.log
request_details.txt

solved the problem? please help me

yes, i m use elastic. thank you, i replace a few line, how to compiled?

please tell me how to compiled?

please tell me how to compiled?

https://alexanderzobnin.github.io/grafana-zabbix/installation/run_from_master/

ansible@ansible:~/grafana-zabbix-4.2.9$ make dist
yarn build
00h00m00s 0/0: : ERROR: [Errno 2] No such file or directory: 'build'
make: *** [Makefile:42: dist-frontend] Error 1
ansible@ansible:~/grafana-zabbix-4.2.9$ sudo make dist
yarn build
00h00m00s 0/0: : ERROR: [Errno 2] No such file or directory: 'build'
make: *** [Makefile:42: dist-frontend] Error 1
don't work

don,t work(
Entrypoint undefined = extract-text-webpack-plugin-output-filename
[../node_modules/css-loader/dist/cjs.js!../node_modules/sass-loader/dist/cjs.js!./sass/grafana-zabbix.dark.scss] 41.1 KiB {0} [built]
    + 2 hidden modules

Child extract-text-webpack-plugin ../node_modules/extract-text-webpack-plugin/dist ../node_modules/css-loader/dist/cjs.js!../node_modules/sass-loader/dist/cjs.js!sass/grafana-zabbix.light.scss:
Entrypoint undefined = extract-text-webpack-plugin-output-filename
[../node_modules/css-loader/dist/cjs.js!../node_modules/sass-loader/dist/cjs.js!./sass/grafana-zabbix.light.scss] 41.1 KiB {0} [built]
+ 2 hidden modules
Infinitely performs
problem signed plugin
could you build for me 4.2.9 ver ?


Add a one-page User Guide

This user guide would help users to get started with the program.

Merged. Thanks for taking a look, @jjkester!


Tests break with RxJava 2.0.2+

I am trying to investigate what exactly is going on, but currently, if you update the library to 2.0.2 and beyond and run the tests, RxLifecycleTest.testBindLifecycle and RxLifecycleTest.testBindLifecycleOther fail with the test observer being disposed.
I am thinking it might be related to this PR?
https://github.com/ReactiveX/RxJava/pull/4873

Thanks for reporting. It is indeed related to that PR.
Fixing it only involved modifying tests, so I'm not going to release a new version of RxLifecycle; the internals of the library are still sound.

Ah okay, glad to hear it! 👍


Fix sprite being repositioned while an animation played

Sprite would become misaligned when an animation was played on the character in RPG Maker MV. This fix involved rewriting how rotations are handled entirely to avoid relying on the sprite's pivot property.

PR is way too large. Simplify this.


Touchscreen scrolling is not passed through to mouse-mode applications

When using mouse mode applications such as tmux and vim, Surface Book touchscreen scrolling is not properly forwarded to the app.
For example, if I start vim ~/.bashrc and enter set mouse=a, I would expect touchscreen scrolling to scroll through the file.
Instead, I "break out" of Vim and scroll past it.
This is on Windows 14965.

@lilred I bet this also happens on Linux.  The problem is that scroll-wheel scrolling is actually implemented by passing the terminal escape sequences (which you can see if you ever accidentally disconnect from ssh while in tmux).  I'm guessing that Microsoft implements touchscreen scrolling as smooth scrolling directly in Windows (by passing it directly to the scroll widget of the associated window).
@zadjii-msft might be able to tell you what the prospects are for adding in this behavior.

@fpqc I'm no stranger to the mechanics of scrolling, see for example #1390 :)

I bet this also happens on Linux.

That may be so. I have no way to check right now! But trackpad scrolling on BoW is passed through to mouse-mode applications (albeit poorly), so I'm still hopeful.

@lilred Out of curiosity, does touchscreen scrolling work for normal cmd/powershell? I don't have a touchscreen machine on hand to verify for myself.
Without any more info, I'd assume that this is probably related to #1390

@zadjii-msft Time to requisition a surface book?

Touchscreen scrolling works perfectly in all three of cmd, powershell and bash. The problem is that bash handles touchscreen scrolling differently from mouse scrolling when within a mouse mode application.

So, after investigating this today, it turns out that adding touch support isn't all that trivial of a fix. Any touch support we have right now is support that we get for free from the OS itself. I'm creating backlog items to add more support for touch in a future release.
Until then, touch scrolling will still work outside VT mouse mode, and touch clicking/dragging will work in VT mouse mode. Sorry there's not a better outcome to this, but it's now definitely on our radar.

Thanks for keeping us up to date.

So, after investigating this today, it turns out that adding touch support isn't all that trivial of a fix. Any touch support we have right now is support that we get for free from the OS itself.

Don't forget to file a bug with the relevant team(s), maybe they can help out :)

Thanks for the discussion.
Closing this issue since:

This issue is being tracked on our internal bug tracker, but is dependent on us overhauling the Console's input and rendering system - work that is in the queue but will take a while to complete
This is the WSL issues repo, but this is an issue in Console which has its own Console GitHub Repo
GitHub doesn't allow issues to be moved between repos, preserving posters' identity :(

If you have further asks/issues, please file new issues on our Console GitHub Repo.


The current checkboxes status doesn't make sense if unhide one subscription when the checkbox 'Select All Subscriptions' is selected and all subscriptions are hidden

Storage Explorer Version: 1.29.0-dev
Build Number: 20230316.7
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Ventura 13.2.1 (Apple M1 Pro)
Architecture: ia32/x64
How Found: From running test cases
Regression From: Not a regression
Steps to Reproduce

Open ACCOUNT MANAGEMENT panel -> Hide all subscriptions under one azure account.
Check the checkbox for the 'Select All Subscriptions'.
Unhide one subscription.
Check whether the current checkboxes status makes sense.

Expected Experience
The current checkboxes status makes sense.

Actual Experience
The current checkboxes status doesn't make sense.

Fix merged into main. Part of the fix was disabling select all when all subscriptions are hidden.

Verified this issue on the build 20230319.3. Fixed.
'Select All Subscriptions' is disabled when all subscriptions are hidden.


Fix logging via toml

Description
Wrap AttributeError when try to configure logging via config section. Cfg file doesn't support inheritance enough for logging configuring, so we can skip logging configuring via config section when cfg-based config used.
Motivation and Context
Fix #2592
Have you tested this? If so, how?
Test included. Failed before fix, success after

As I commented https://github.com/spotify/luigi/issues/2592#issuecomment-446577334, 2.8.0 didn't have this issue before the bug was introduced in later PR. However we just release 2.8.1 yesterday that that became a broken version. Any progress on this PR?

I've added explicit check for LuigiConfigParser.

LGTM. @dlstadther @Tarrasch any thought? I wasn't following the original PR.

@dlstadther please merge and release a hotfix, thanks!

@honnix Done

Awesome. Thanks!


pull request for e2e test at 11/19/2016 20:26:06

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Does not work for a list in json

Suppose there is a json list with multiple json objects then this plugin only takes its first object and does not deal with others. It is bad when there is a root list of multiple objects. I can look into this if you allow me to.

Suppose there is a json list with multiple json objects then this plugin only takes its first object and does not deal with others. It is bad when there is a root list of multiple objects. I can look into this if you allow me to.

Thanks for your issue.

It's hard to tell what we want when list[0] is a number, list[1] a bool, list[2] an object, and list[3] is a nested array.

If you need only one definite class that contains all the key-value pair in the list, it's ok to take an action like for-each, but how could the plugin knows that you are not in the situation 1 ?

As far as I know, most of the json plugins deal with list in the same way as this one, such as GsonFormat.
In the situation 1, I suggest you to use List instead of definite types.
And situation 2, you may put all the key-value pairs to list[0], before you give the json string to this plugin.
It's really hard to consider all the situations, I'm sorry.


Improve performance of hash-set

Pycket is several order of magnitude slower for this operation. Racket probably does something much more fancy for its immutable hash tables.
Example:
#lang racket/base
(define d (make-immutable-hasheq '()))
(time
  (void
    (let loop ([i 0] [a d])
      (if (= i 100000) a
        (begin
          (loop (+ i 1) (hash-set a i i)))))))

Right now we even get the complexity wrong. Since we always copy, in pycket this code is quadratic, as opposed to n log n or something.
Fixing this will be annoying though, don't think anybody implemented immutable data structures in rpython yet.
Carl Friedrich
On April 29, 2015 8:11:38 PM GMT+02:00, Spenser Bauman<EMAIL_ADDRESS>wrote:

Pycket is several order of magnitude slower for this operation. Racket
probably does something much more fancy for its immutable hash tables.
Example:
#lang racket/base
(define d (make-immutable-hasheq '()))
(time
 (void
   (let loop ([i 0] [a d])
     (if (= i 100000) a
       (begin
         (loop (+ i 1) (hash-set a i i)))))))

Reply to this email directly or view it on GitHub:
https://github.com/samth/pycket/issues/164

Right now, Racket uses AVL-trees keyed on the hash code. It's switching soon to using HAMTs. We won't have acceptable performance until we do something similar.

If we want to go down that road we should try to see whether we can reuse this port of clojure's persistent dict here:
https://github.com/alex/optimizer-model/blob/master/optimizer/utils/persistent_dict.py
Not rpython, but probably fairly close. And it has tests!
Carl Friedrich
On April 29, 2015 8:19:27 PM GMT+02:00, Sam Tobin-Hochstadt<EMAIL_ADDRESS>wrote:

Right now, Racket uses AVL-trees keyed on the hash code. It's switching
soon to using HAMTs. We won't have acceptable performance until we do
something similar.

Reply to this email directly or view it on GitHub:
https://github.com/samth/pycket/issues/164#issuecomment-97530252

Pixie is also rpython based and has implementations of persistent vectors, (hash) maps and sets. Maybe these could be useful here, too?

I've adapted the Pixie's HAMT implementation to work with Pycket. eq-/eqv-hashes are fully supported. equal-hashes will require some cleverness to get working, but we can easily support anything that does not need to call back into the evaluator.


abnormal reticulophagy

Add new term:
abnormal reticulophagy (child of abnormal autophagy MP:0008260)
DEF: any anomaly in the selective autohagy process in which parts of the endoplasmic reticulum are loaded into autophagosomes, delivered to the vacuole, and degraded in response to changing cellular conditions
DEF SOURCE: GO:0061709
SYN: abnormal autophagy of the endoplasmic reticulum
SYN: abnormal autophagy of the ER
SYN: abnormal ER-phagy
Annotations in J:210399, J:256708

Added new term abnormal reticulophagy MP:0030938 and all synonyms suggested above.
Also added an EQ statement for abnormal mitophagy MP:0014046.


Improve getServer() parser

Fixes this error:
connect to whois server failed: dial tcp: lookup
tcp///whois.namecheap.com: Servname not supported for ai_socktype
Observed on an org TLD domain, whose whois response contains:
Registrar WHOIS Server: http://whois.namecheap.com

Hello @zcalusic
Thanks for your PR.


Decouple Authentication Logic from tournamentService in updateMatchInTournament Method

Currently, the updateMatchInTournament method in tournamentService directly receives a token, making tournamentService implicitly responsible for user authentication and authorisation. Not ideal as it mixes business logic with security concerns.

Fixed with JwtTokenProvider to handle token and ClubServiceClient to handle communication from tournament to club microservices


Getting rid of an Ajax call in the core styles CKeditor plugin

After you removed the async: false setting from the Ajax call, the snippets button couldn't be added to CKeditor's toolbar making snippets unusable.
This pull request gets all our snippets and custom classes while preparing all our editor's data and then sends it to the editor along with all the other config variables.
No more Ajax call and the editor loads way faster

I did a quick test of this pull request and the snippets and editor work as expected.

Definitely an improvement over the ajax call, this is a great improvement.

thanks!


Piano Hand Hardware Design Review

A formal report of all hardware design progress and ideation for the Piano Hand.

To start off this semester, me and Revanth have decided to start the development of a hardware design review document/report. In general, this report will be a compilation of the design process we have used throughout the semester, any research performed into different systems and processes, and of plans for continuous development and integration of the project. As of right now the structure has yet to be finalized but will be soon, with weekly assignments given to y'all alongside whatever CAD work is needed, such as like writing one to two paragraphs about a new design choice the team made, or actuation research. Ultimately by the end of the sem, we should hopefully have a foundation of an industry standard report for ARC, and all relevant stakeholders, including ourselves, to truly cherish. Thus I wanted to make this project an ongoing issue within GitHub and will soon be making follow-up posts regarding the matter.
Why a paper?
The purpose of this deliverable is to not only create a record of the Piano Hand's progress throughout the upcoming months and semester as a tool for ARC and planning future project work, but mainly to offer all of us a professional document to validate our hard work, and show off to recruiters, companies, and professors alike in the future. Per personal experiences, I can attest to the value of having a paper/report under your name, especially as this early stage in our undergraduate and professional lives, as a tool of distinguishing ourselves from other candidates and demonstrating to engineering and tech firms, how we have already developed a lot of the skills we are looking for: Technical writing, research, systems engineering to name a few. Moreover, this will be a chance for us to communicate the research and knowledge we have gained through this project in a very professional and marketable manner, as yet another edge offered for our career development.
However, this document will not have the standards needed to offer the many things I have mentioned, unless we all chip in, and so I really hope you all can contribute in some way, beyond the amazing work we will be doing with CAD and actual hardware.

Completed at Design Review


whitelist jest-cucumber

Needed for adding types to jest-cucumber-fusion

It's now in the production branch, so Definitely Typed's CI will get the new whitelist next time it runs.

Hmmm, doesn't seem to be picked up, travis is still erroring on jest-cucumber not being in whitelist: https://travis-ci.org/github/DefinitelyTyped/DefinitelyTyped/builds/669114160?utm_source=github_status&utm_medium=notification

It's working now that I cleared Travis' cache again. Maybe I didn't successfully clear it yesterday.


Automatic initializetion

For the code to work users currently need to initialize in the main function using TizenHelperMethods.initialize();
It would be nice if we can make this process automatic

I would like to help you out with this, could you please tell me how I can test the application locally? I don't have a TV on hand to test it, are there any alternatives for developmental purposes?


Edit button for documentation pages

Resolves https://github.com/Microsoft/pxt/issues/143
For any documentation page this adds a link to the corresponding Markdown on GitHub - it is necessary to set the URL to the GitHub repository in pxtarget.json (I have already done this for pxt-microbit).

Can we automatically read the github URL from package.json if available?

@pelikhan Reading from package.json was an option (pxt-microbit already had the GitHub URL there), but the advantage of adding it in pxtarget.json is that the contents of that file were already being passed to the Markdown rendering function, so it was the smallest change I could make. I did also consider scraping the URL from git remote -v, but I didn't want to risk exposing private repository URLs in the future.


[Global Procedure Request] - codeunit 7312 "Create Pick" - local procedure to global procedure

Dear Support,
Could You please modify the CreateNewWhseDoc from local procedure to global proceedure in codeunit 7312 "Create Pick"?
<<<<< Original >>>>>
 local procedure CreateNewWhseDoc(OldNo: Code[20]; OldSourceNo: Code[20]; OldLocationCode: Code[10]; var FirstWhseDocNo: Code[20]; var LastWhseDocNo: Code[20]; var NoOfSourceDoc: Integer; var NoOfLines: Integer; var WhseDocCreated: Boolean)
<<<<< Modified >>>>>
procedure CreateNewWhseDoc(OldNo: Code[20]; OldSourceNo: Code[20]; OldLocationCode: Code[10]; var FirstWhseDocNo: Code[20]; var LastWhseDocNo: Code[20]; var NoOfSourceDoc: Integer; var NoOfLines: Integer; var WhseDocCreated: Boolean)
Additional context
After an upgrade, we have to reuse this from a custom procedure, and we can not call it due to it is a local procedure.
Thanks for Your help in advance!
Internal work item: AB#557536

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 26910.


feat: expose version information over prometheus

Fixes #6113
example output:
# TYPE reth_info gauge
reth_info{version="0.1.0-alpha.16",build_timestamp="2024-01-23T23:51:00.013862000Z",cargo_features="",git_sha="1cd87a9",target_triple="aarch64-apple-darwin",build_profile="debug"} 0

perhaps group prometheus + version_metrics under metrics module?

right, good idea, will do that


wallet-sdk / fix stx address derivation instead of stxPrivateKey in name fetching

Description
This Pull Request fixes the latest release of stacks JS (3.1.0) where names resolution was adjusted in this PR

How does this impact application developers
Non Applicable
Link to relevant issues and documentation
https://github.com/blockstack/stacks.js/pull/1117

Type of Change

[ ] New feature
[x] Bug fix
[ ] API reference/documentation update
[ ] Other

Does this introduce a breaking change?
Non Applicable

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@kyranjamie @kantai @friedger Hello Guys can you take a look at this i am trying the latest version of StacksJS (3.1.0) and it fails to restore the wallet accounts primarily  because:
1- restoreWalletAccount now requires the network instance to be present
2- there was a bug when fetching names that was trying to fetch it using the private key instead of the account address
I Hope this fix is sufficient and can get published ASAP

@kyranjamie @kantai @friedger Changing the stxPrivateKey that was introducd in the mentioned PR  has been removed in this commit the change caused inconsistency between the returned value from generateWallet function and restoreWalletAccounts function therefor producing a different stxAddress and can't resolve the account's holdings.

cc @friedger @pradel

@ma-aboelenein Changing the stx address was the whole point of the PR. Can you please add a test that establish your findings?

@friedger i don't think that is necessary, the problem is the following after i generate the wallet from an existing seed phrase calling restoreWalletAccounts returns the same address for all the accounts instead the one containing a .id.stx name the address is different due to the wallet SDK replacing the stxPrivateKey of the account and thus resulting in a different stxAddress that doesn't contain the assets that i have in the account since it's registered under the old address, when i remove the part where the sdk regenerate the private key the name is fetched correctly due to the new introduced logic and the old stxAddress is returned as usual along with the assets.

@friedger Also the new way we resolve the names of the accounts should also be introduced in the auth library specifically in makeAuthResponse because it fails to verify the auth response in doPublicKeysMatchUsername for names that are not signed by the walletKey

@markmhx can you tag along in this?

@ma-aboelenein correct, that is why the lookup of .btc names fails. This needs to be fixed by the Hiro wallet, the SDK provides the tools to do this in a flexible way

@ma-aboelenein correct, that is why the lookup of .btc names fails. This needs to be fixed by the Hiro wallet, the SDK provides the tools to do this in a flexible way

Can you elaborate please where do that fall under the two comments or maybe hop on a call tomorrow to discuss this?

@friedger i don't think that is necessary, the problem is the following after i generate the wallet from an existing seed phrase calling restoreWalletAccounts returns the same address for all the accounts instead the one containing a .id.stx name the address is different due to the wallet SDK replacing the stxPrivateKey of the account and thus resulting in a different stxAddress that doesn't contain the assets that i have in the account since it's registered under the old address, when i remove the part where the sdk regenerate the private key the name is fetched correctly due to the new introduced logic and the old stxAddress is returned as usual along with the assets.

@friedger Also the new way we resolve the names of the accounts should also be introduced in the auth library specifically in makeAuthResponse because it fails to verify the auth response in doPublicKeysMatchUsername for names that are not signed by the walletKey

@ma-aboelenein restoreWalletAccounts is an implementation of restoring where the derivation path for the stx address is selected depending on ownership of a username. If the user has a name registered with the default wallet address then that address is used. If the user has a name registered with the default data address then that address is used as wallet address and data address. If you want to use a different selection algorithm for the derivation paths, e.g. based on the balances of the wallet address and the data address, you need to implement your own restoreWalletAccounts. Maybe we should pass in the selectStxDerivation function as a parameter, if you think that wallet builders want to make different choices. You can also overwrite the wallet address by setting the private key based on your choice for the derivation path.
 stxPrivateKey: derivePrivateKeyByType({
              rootNode,
              index,
              derivationType: stxDerivationType,
            }),

Re profile signatures, all profiles need to be signed by the walletKey, that is part of the protocol. The Hiro Wallet did sign with the data wallet in the past, therefore the verification method correctly rejects most of the profiles for .btc names. The Hiro Wallet needs to fix that by resigning the profiles.

@ma-aboelenein Here is the improved tests that would have catch this error: https://github.com/friedger/stacks.js/commit/f51614c4eff2ad4a00edcc34c5ef10ffb3cbd3ae

There are outstanding actions here based on @friedger's feedback

There are outstanding actions here based on @friedger's feedback

where do you just we move on from here, the private key changing procedure is a breaking change that i think we need to discuss a little bit more

@ma-aboelenein The first part of your PR about the private key was fixed by https://github.com/hirosystems/stacks.js/commit/6bd5fd9bddf1b277a021a8b15cf82f5a336a9fa6
The second part of your PR (removing the stxPrivateKey) should not be merged because it would not respect usernames owned by other keys than the data key. With 3.1.1, we have a way that wallets can select which derivation path the user wants to use.
I think this PR can be closed.

@ma-aboelenein The first part of your PR about the private key was fixed by 6bd5fd9
The second part of your PR (removing the stxPrivateKey) should not be merged because it would not respect usernames owned by other keys than the data key. With 3.1.1, we have a way that wallets can select which derivation path the user wants to use.
I think this PR can be closed.

@friedger i agree with you this is no longer relevant but can you elaborate more on the way wallets can select the derivation path

Are there any issues remaining or can this be closed?


How to calculate the used GPU memory for each part as in the paper?

Hi @QipengGuo @KaiLv69 @ayyyq
Thanks for the nice work, I am wondering how to calculate the detailed used GPU memory as illustrated in the paper, such as the results in the Table 1. What tools did you use for the calculations?

Hi, we use gc (https://gist.github.com/dojoteef/26cd46f7cc38b38e6f443c5f62411aa3) and torch.cuda.memory_reserved() to profile memory usage.

Hi, we use gc (https://gist.github.com/dojoteef/26cd46f7cc38b38e6f443c5f62411aa3) and torch.cuda.memory_reserved() to profile memory usage.

Thanks a lot!


[BUG] Removed YAML files were added back in

Reproduction steps
This PR removed some YAML files that are superseded by Python test scripts:
https://github.com/project-chip/connectedhomeip/pull/28583
This PR added back the deleted files:
https://github.com/project-chip/connectedhomeip/pull/28829
Bug prevalence
100%
GitHub hash of the SDK that was being used
b3c0ac1
Platform
core
Platform Version(s)
No response
Anything else?
No response

@manjunath-grl Please help with this.

@plauric Removed those tests in PR 28985 please verify and close the ticket.

@manjunath-grl Please also remove Test_TC_RVCOPSTATE_2_1.yaml
Test_TC_RVCOPSTATE_2_3.yaml

@plauric Above mentioned YAML'S are not there in certification folder. Please verify it once.
https://github.com/manjunath-grl/connectedhomeip/tree/master/src/app/tests/suites/certification


Win wp update

Hi,
I am ancronie from engagement dev team. I have see some update to do to be more accurate.
Best Regards
Cronier Antoine

Hi @ancronie, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@ancronie, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, AZPRBOT;


RDK-592: Update radio index at capability structure

The structure wifi_radio_capabilities_t has radio index field which should be initialized.
Signed-off-by: Tomasz Kilarski<EMAIL_ADDRESS>

https://jenkins.code.rdkcentral.com/job/github-triggered/20558/ started

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/13924/ started

https://jenkins.code.rdkcentral.com/job/build-component/55774/ started.

Smoke tests for ['build-rpi-broadband'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/122443/

Smoke tests for ['build-tur-bb'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/122444/

Smoke tests for ['build-rpi-broadband'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/122446/


Gradle modernization and dependency updates

update dependencies
target latest sdk
update gradle wrapper
fix lint warnings in gradle files
remove need for BetterViewPager
fix lint warnings in MaterialCalendarView around constant creations
remove need to specify build tools since they are included in the gradle plugin now
use dcendents android maven plugin to properly generate pom file dependencies for library
mark source as java 8 compatible

LGMT! Thank you for your hard work!


Add a "close event" button in the editor

Or click the event again to close it

"Close Event" button would be nice still, there's a lot of unused real estate to the right of the event.

I think the blank space at the left of the event solves this. Need to be documented, but it works since 0.3. I'm closing this for now


Web VR Anyone?

hey,
Has anyone toyed around with getting this working with WebVR compatible browsers? I haven't touch webvr in a while. But I may take a crack at it if I get some spare time soon.
Francois

I'll give it a try sometime in the future, it's definitely on the list.


The TextFiled lost it focus when click other blank areas.

The problem happened when I upgraded the flutter to 2.5.3 (like the first gif picture). I don't hope it lost focus (like the second gif picture).

By the way, The cursor height becomes shorter when I delete all characters from TextField (like the following picture).

flutter doctor -v
[√] Flutter (Channel stable, 2.5.3, on Microsoft Windows [Version 10.0.17763.2237], locale    en-US)
    • Flutter version 2.5.3 at D:\SDK\Flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • FLUTTER_GIT_URL = https://gitee.com/mirrors/Flutter.git
    • Framework revision 18116933e7 (4 days ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at D:\SDK\Android
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = D:\SDK\Android
    • ANDROID_SDK_ROOT = D:\SDK\Android
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • CHROME_EXECUTABLE = C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.11.5)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.11.31729.503
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 4.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[√] IntelliJ IDEA Community Edition (version 2021.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.2.3
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5486

[√] VS Code (version 1.55.2)
    • VS Code at C:\Users\Zhanghuifeng\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.15.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.17763.2237]
    • Chrome (web)      • chrome  • web-javascript • unknown
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 94.0.992.50

• No issues found!

simple code
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'TextField Demo',
      theme: ThemeData(primarySwatch: Colors.teal),
      home: Scaffold(
        body: Center(
          child: SizedBox(
            width: 200,
            height: 80,
            child: TextField(
              controller: TextEditingController(text: "Hello"),
              minLines: 1,
              textAlignVertical: TextAlignVertical.center,
              cursorHeight: 14,
              decoration: InputDecoration(
                border: const OutlineInputBorder(),
                hintText: "HintText",
                labelText: "LabelText",
                hintStyle: const TextStyle(fontSize: 14),
                labelStyle: const TextStyle(fontSize: 15),
                counterText:  "",
              ),
            ),
          ),
        ),
      ),
    );
  }
}

Hello! I think you're reporting 2 different issues. As far as I understand, the first one actually is an improvement, in the material design system official page the text field example behaves like in the new example you're showing (unfocusing the text field after clicking outside), please check their guidelines here: https://material.io/components/text-fields.
Anyway, the second one seem to be a valid issue IMO.

@MCarlomagno
I agree that is a good improvement. But it prevents me from inserting new text at the cursor of the TextField (as in the example below). Because when I click the button, it goes out of focus, and I can't get the cursor position.


What does this error?

There are no miners, so this error occurs?

Your pool can't connect to the zcash daemon

How to fix the error?

restart demaon or check the .Conf regarding your connection


Emoji svg

Updates the svg cleaner tool, adds most missing SVG (excepting flags), and applies the cleaner to the svg.

this is fantastic.
If i can add a suggestion, i see you passed SVGO over the svgs, adding the width and height to the main tag that helps a lot.
The point is that for 128px people already have pngs, faster to open and parse. I would use a bigger width/height value ( 512px up ) since when using svg as normal images shrinking down is always possible while enlarging requires tweaking the svg header ( if opened as a raster )

Hmmm, that's an option.  Originally the goal was to build a version of the emoji font using embedded svg instead of png, but that's been on hold for a few years.  And we could also tweak the extent during the build process were we to revive that.  File a feature request at the upstream googlei18n/noto-emoji repo.

to be honest the font is cool, but for the web svgs are the best thing.
Every OS has a different emoticon set, we are using this SVG set as a glyph substitution in order to give the same experience to all users.
And works pretty good.
We manually tweak the svgs to be 512px so they do not look pixellated on big font sizes.


OpenSSL OQS unable to open mlddsa44 key from pkcs12 that is created with IAIK-PQ (Post-Quantum) library

Describe the bug
we are using a IAIK java library to create mldsa44 key and certificate and store into a PKCS#12 in java.
Trying to open the pkcs12 in openssl oqs failed.
Recompiled the oqs provider with  -DNOPUBKEY_IN_PRIVKEY=ON and it didn't work aswell.
Attached is pkcs#12 created in java code.
pqckeycert2.zip

To Reproduce
Steps to reproduce the behavior:
Opening the pkcs12 with oqs provider fails with below error.
`$openssl pkcs12 -in ./pqckeycert2.p12  -passin pass:123456
Bag Attributes
friendlyName: acme.com
localKeyID: 2D 32 35 39 32 32 34 35 35 37
Error outputting keys and certificates
00A4EEA3CA7F0000:error:1E08010C:DECODER routines:OSSL_DECODER_from_bio:unsupported:crypto/encode_decode/decoder_lib.c:102:No supported data to decode.  Input type: DER, Input structure: PrivateKeyInfo
00A4EEA3CA7F0000:error:0300009C:digital envelope routines:pkey_set_type:unsupported algorithm:crypto/evp/p_lib.c:1566:
00A4EEA3CA7F0000:error:03000076:digital envelope routines:evp_pkcs82pkey_legacy:unsupported private key algorithm:crypto/evp/evp_pkey.c:42:TYPE=mldsa44
Recompiled OQS Provider with  -DNOPUBKEY_IN_PRIVKEY=ON, fails with the same error.$openssl pkcs12 -in ~/pqckeycert2.p12  -passin pass:123456
Bag Attributes
friendlyName: acme.com
localKeyID: 2D 32 35 39 32 32 34 35 35 37
Error outputting keys and certificates
00D41F85407F0000:error:1E08010C:DECODER routines:OSSL_DECODER_from_bio:unsupported:crypto/encode_decode/decoder_lib.c:102:No supported data to decode.  Input type: DER, Input structure: PrivateKeyInfo
00D41F85407F0000:error:0300009C:digital envelope routines:pkey_set_type:unsupported algorithm:crypto/evp/p_lib.c:1565:
00D41F85407F0000:error:03000076:digital envelope routines:evp_pkcs82pkey_legacy:unsupported private key algorithm:crypto/evp/evp_pkey.c:42:TYPE=mldsa44
`
Expected behavior
openssl oqs should open p12 created in third-party IAIK library.
Environment (please complete the following information):
Redhat 8
Please run the following commands to obtain the version information:
master branch of openssel and oqsprovider

That PKCS#12 key uses OID <IP_ADDRESS>.<IP_ADDRESS><IP_ADDRESS>, which is not the ML-DSA OID, it's the old OID used for the IPD version for testing purposes.
The IAIK library needs to be updated to the correct OID (and if it hasn't been already, the encoding from https://datatracker.ietf.org/doc/draft-ietf-lamps-dilithium-certificates/ - still under development).

The failure happens in oqsprov/oqsprov_keys.c,  while calling d2i_ASN1_OCTET_STRING() function which return NULL.
The privatekey that came from the PKCS#12 has size 2560, which is passed to d2i_ASN1_OCTET_STRING().  d2i_ASN1_OCTET_STRING expects ASN.1 octet encoded string and fails because input is not a ASN.1 octet string but a raw key bytes.
1212 OQSX_KEY *oqsx_key_from_pkcs8(const PKCS8_PRIV_KEY_INFO *p8inf, 1213                               OSSL_LIB_CTX *libctx, const char *propq) { 1214     OQSX_KEY *oqsx = NULL; 1215     const unsigned char *p; 1216     int plen; 1217     ASN1_OCTET_STRING *oct = NULL; 1218     const X509_ALGOR *palg; 1219     STACK_OF(ASN1_TYPE) *sk = NULL; 1220     ASN1_TYPE *aType = NULL; 1221     unsigned char *concat_key; 1222     const unsigned char *buf; 1223     int count, aux, i, buflen, key_diff = 0; 1224 1225     if (!PKCS8_pkey_get0(NULL, &p, &plen, &palg, p8inf)) 1226         return 0; 1227 1228     if (get_keytype(OBJ_obj2nid(palg->algorithm)) != KEY_TYPE_CMP_SIG) { 1229         oct = d2i_ASN1_OCTET_STRING(NULL, &p, plen);


baseline_comg

Hi!Do you have the best checkpoints for a trained baseline without RL?

Hi
I have moved my workplace to another place, so I lost some information about the previous work (including the weight after the first stage).
So sorry for that.
Best regards


Lack of documentation and configuration for AsyncProducer circuit breaker

Hi.
Seems that sarama lacks documentation for AsyncProducer circuit breaker. There is none.
Also, circuit breaker configuration (errorThreshold, successThreshold, timeout) is not available from outside and their values are hardcoded in async_producer.go.
Additionally, there is no good way for a user of sarama to understand that circuit breaker is open for him to be able to do something about that. In the usual case when someone is sending hundreds of thousands of messages per second and prints all the errors, he will get hundreds of thousands of errors printed.
I think that this needs fixing or at least mentioning in docs.
Version: last master (61d6997607d1fa1f0d565dac179053597e8e7a64)

You are probably right that this could be improved, but I would note the reasons that I did not originally document it or make it configurable:

The circuit-breaker configuration was intentionally fairly conservative; the only adjustment I can think that users might want to do is to make it more aggressive, not less?
Its placement into the producer was intended to be fairly transparent: it should only cause messages to fail if they would have failed anyway for a "real" reason. It makes the failure more efficient but shouldn't fundamentally affect behaviour.

I am not opposed to exposing some documentation or configuration, but given the above I am curious what case you are running into where the circuit breaker is causing problems? If you are sending hundreds of thousands of messages (and thus getting hundreds of thousands of errors), then it seems likely that something has gone wrong with your kafka connection and you would be getting those errors with or without a breaker in the middle?

Suppose I am producing 100000 msg/sec. And suppose my Kafka cluster is down. In a case when there is no circuit breaker I would get N errors per sec where N = 1 second / timeout. This is 1 message per second for 1 second timeout. Perfectly normal to write these errors to log file for example.
With circuit breaker, I am getting 100000 errors/sec. Because timeout is virtually non-existent in this case. I am getting the error right away. 100000 errors/sec is too excessive I think.
Additionally, as I have already mentioned, I don't know whether these errors are from the circuit breaker or not. This particular error is being sent straight from circuit breaker package that you use. Without any wrapping. So sarama does not have this error exported, it is not part of saramas API and I cannot use equality to understand which error it is.
If I could, I could add 1s timeout for example.

Suppose I am producing 100000 msg/sec. And suppose my Kafka cluster is down. In a case when there is no circuit breaker I would get N errors per sec where N = 1 second / timeout.

And then you run out of memory, because 10 seconds later you have a million messages queued up with nowhere to go?
If you're handling that volume of messages and the cluster is down, aren't you basically forced to drop those messages anyway? And doesn't that count as an error? Or do you have some sort of internal disk queueing you can use to hold them in the meantime?

This particular error is being sent straight from circuit breaker package that you use. Without any wrapping. So sarama does not have this error exported, it is not part of saramas API and I cannot use equality to understand which error it is.

Hmm, yes this is a problem. The error is exported from the breaker package, so you can absolutely just import that package and then check against breaker.ErrBreakerOpen but that should definitely be documented.

And then you run out of memory, because 10 seconds later you have a million messages queued up with nowhere to go? If you're handling that volume of messages and the cluster is down, aren't you basically forced to drop those messages anyway? And doesn't that count as an error? Or do you have some sort of internal disk queueing you can use to hold them in the meantime?

It is a contrived example. So you may be right.
But I don't see the need for circuit breaker here. At least it should be configurable or there should be a way to turn it off.

But I don't see the need for circuit breaker here.

The circuit-breaker is needed for situations where a significant part, but not all, of the cluster goes down (e.g. 6 of 12 brokers, or something like that). In that case there will be partitions with no active leaders; without a circuit breaker the entire producer would slow to a crawl while trying to process each message. The circuit-breaker opens to keep the messages flowing, allowing messages to the remaining online partitions to be produced.

It is a contrived example.

Kafka is a dangerous system for contrived examples because of some design subtleties. If you have a real use case please feel free to open a new ticket.


Web - Book travel - There is hover effect on "Save money on ..." and "Get realtime updates.."

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4661870
Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to FAB > Book travel
Hover over "Save money on your bookings" and "Get realtime updates and alerts"

Expected Result:
There will be no hover effect on "Save money on your bookings" and "Get realtime updates and alerts" (production behavior)
Actual Result:
There is hover effect on "Save money on your bookings" and "Get realtime updates and alerts"
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/655bed1e-4483-416b-b9ae-12f251bcfcee
View all open jobs on GitHub

Thanks all for the help here by tagging the offending PR and sharing the insights on the issue.
Fixing this issue here at #44219 since this is a regression from #43987
cc @MonilBhavsar

Payment will be handled in https://github.com/Expensify/App/issues/41901. Closing.


Deleting todos in app that haven't yet transitioned causes them to animate weirdly

They seem to be missing an initial state.
To reproduce, go to app -> The animate directive. Hit x on any todo item before clicking on anything else

Fixed


[AI Agent idea] GreenThumb AI for gardening enthusiasts

Description
GreenThumb is an AI for gardening enthusiasts. It offers advice on plant care, soil analysis, and garden design, helping individuals cultivate thriving and beautiful gardens.
Additional Information
No response

/assign @manmohanhunjan


Unable to process request for 'PostSpendTx'

When I tried to send 0.01 test ae token to node2,
curl -X POST -H "Content-Type: application/json" -d '{"recipient_pubkey":"BA8rCMut8z8if9YZd+1AIZAOuABkIL5ycSHbzNvQkQmtdDKaCHjnI0VKzhDOTTrW9s4d8ewX0Gas62GbpsJ7lhI=", "amount":0.01, "fee":1}' http://<IP_ADDRESS>:3113/v1/spend-tx
I got this:
2017-12-09 23:12:16.981 [error] <0.6903.0> Unable to process request for 'PostSpendTx': {wrong_param,'SpendTx',schema,#{error => wrong_type,path => [<<"amount">>],schema => [{<<"type">>,<<"integer">>},{<<"format">>,<<"int64">>}],type => data_invalid}}
Sending the integer amount is OK.

Hi @jdgcs ,
Thank you for yor comment. Epoch currently only accepts integers for spend transactions: both for the amount and for the fee. In the future a fractions could also be spend but then again - they'd be just integers of some other denomination.

thx!


COLLECTIONS-869: Add unwinding iterator

Implements COLLECTIONS-869.
Adds an iterator that will present an Iterator<Iterator> as an Iterator

Hi @Claudenw
Please see my comment in COLLECTIONS-869.

Not necessary as per discussion on Jira.  Closing without merge.


[videa] Add new extractor

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[x] New extractor
[ ] New feature

Description of your pull request and other information
This is a new extractor for videa.hu (hungarian videosharing site). After I finished my work, I realized that somebody also tried to develop similar plugin to videa.hu site, but it wasn't include to the master repo for several reason #8181
This extractor also supports embedded videos.

Do you want to be credited as one of the authors of youtube-dl? If so under what name?

Oh, thank you, that would be nice. Under "Bagira"


Update kind-projector to 0.11.3

Updates org.typelevel:kind-projector from 0.11.2 to 0.11.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "kind-projector" } ]

labels: library-update, semver-patch

Codecov Report

Merging #915 (3a76e65) into develop (0856e87) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #915      +/-   ##
===========================================
- Coverage    89.60%   89.50%   -0.11%
===========================================
  Files          119      119
  Lines         9869     9869
  Branches       494      494
===========================================
- Hits          8843     8833      -10
- Misses        1026     1036      +10

Impacted Files
Coverage Δ

...in/scala/com/twitter/algebird/scalacheck/Gen.scala
90.90% <0.00%> (-9.10%)
:arrow_down:

...main/scala/com/twitter/algebird/monad/Reader.scala
52.94% <0.00%> (-5.89%)
:arrow_down:

...src/main/scala/com/twitter/algebird/Interval.scala
72.17% <0.00%> (-3.48%)
:arrow_down:

...re/src/main/scala/com/twitter/algebird/QTree.scala
78.57% <0.00%> (-1.20%)
:arrow_down:

...a/com/twitter/algebird/immutable/BloomFilter.scala
95.08% <0.00%> (-0.82%)
:arrow_down:

.../main/scala/com/twitter/algebird/BloomFilter.scala
93.80% <0.00%> (-0.45%)
:arrow_down:

.../scala/com/twitter/algebird/immutable/BitSet.scala
96.57% <0.00%> (+0.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0856e87...3a76e65. Read the comment docs.

Codecov Report

Merging #915 (3a76e65) into develop (0856e87) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #915      +/-   ##
===========================================
- Coverage    89.60%   89.50%   -0.11%
===========================================
  Files          119      119
  Lines         9869     9869
  Branches       494      494
===========================================
- Hits          8843     8833      -10
- Misses        1026     1036      +10

Impacted Files
Coverage Δ

...in/scala/com/twitter/algebird/scalacheck/Gen.scala
90.90% <0.00%> (-9.10%)
:arrow_down:

...main/scala/com/twitter/algebird/monad/Reader.scala
52.94% <0.00%> (-5.89%)
:arrow_down:

...src/main/scala/com/twitter/algebird/Interval.scala
72.17% <0.00%> (-3.48%)
:arrow_down:

...re/src/main/scala/com/twitter/algebird/QTree.scala
78.57% <0.00%> (-1.20%)
:arrow_down:

...a/com/twitter/algebird/immutable/BloomFilter.scala
95.08% <0.00%> (-0.82%)
:arrow_down:

.../main/scala/com/twitter/algebird/BloomFilter.scala
93.80% <0.00%> (-0.45%)
:arrow_down:

.../scala/com/twitter/algebird/immutable/BitSet.scala
96.57% <0.00%> (+0.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0856e87...3a76e65. Read the comment docs.


Add systemd support

Hi. I was applying this change to my version of the Tomcat cookbook but we need to run tomcat as a specific user.
The original recipe has attributes for the tomcat user/group but this patch does not seem to use that (tomcat/tomcat is hardcoded in tomcat.service.erb. I'm trying to change it in my cookbook but having some problems that I haven't quite figured out how to solve. In short the cookbook doesn't seem to be applying the template over the /usr/lib/systemd/system/tomcat.service file that the package manager installs from the tomcat package.
But, I'm sure I'll figure that out eventually. Basically I just wanted to mention that the user/group should probably be configurable in the tomcat.service.erb template.

Thanks, that was a small oversight on our part. My colleague will have a new version up soon.

Done!

Thanks guys... just out of curiosity, have you tested whether this works? I'm trying this on CentOS 7 and I don't see the /usr/lib/systemd/system/tomcat.service getting updated with the correct username/pass... it still just has tomcat/tomcat which I believe is coming from the tomcat rpm package that is installed.
I'm about to dive into this a bit more and I'll report back if I figure it out but I just wanted to check whether you guys had verified that the user/group is actually being changed in that file.

We did test the original commit heavily but admittedly didn't have time today to test this small change. On further review, I see that we did make a mistake as it should respect the LWRP and not fetch the user/group directly from the node attributes. We'll fix this ASAP.

Well, I found some time to take a look here and in short this is what I found out. I should note that I'm not experienced in neither ruby nor Chef and furthermore I'm pretty confused about all this LWRP concept (for example what you're saying in your comment above).
In the instance.rb provider there is an if/else that checks whether the new_resource.name == 'base' or something else. If the name is 'base', there is not a whole lot that gets done. However, if the name is something else, there is a lot of stuff done, among which is applying the tomcat.service.erb template to /usr/lib/systemd/system/tomcat.service.
In other words, the systemd template is never applied for the base instance. It is only applied when you have defined multiple instances.
I've never gotten the multiple instances stuff to work properly and frankly I've given up on this cookbook since Opscode have said that they're going to rewrite it completely. But this is something that I need to get working so I'm wondering whether the systemd service template should be added to the "base instance if block" just like it is in the else block?

We've not formally used this cookbook yet but as I understand it, using the base instance means mostly using the files as provided by the package manager. This means that you cannot do certain things like change the user it runs as; this appears to be by design.
Using the base instance is the default and the Kitchen tests do not change this so perhaps we should do further testing with multiple instances in order to see whether we run into whatever issues you have.
/usr/lib/systemd/system/tomcat.service itself is never overwritten. If you look more closely, you'll see that it names the file according to the instance name, such as tomcat-foo.service.
I have not seen Chef (no longer Opscode!) state that this cookbook will be rewritten. I'm a little surprised as I consider it to be one of the better ones.

Well, I asked a question about this on the mailing list and got this response:
http://lists.opscode.com/sympa/arc/chef/2015-01/msg00274.html
Not quite sure what that means though, whether they're talking about a full rewrite or just a partial one.
At any rate, regarding what you said about the cookbook customizations only being possible on the "non-base instances", that would work okay for us if we could get a non-base install to work at all. I tried defining one with the minimal set of attributes to keep things simple but no matter what I tried, I could never get it to work. I always got an error stating something about not being able to create a symlink called /usr/share/tomcat/bin because there was already a folder called /usr/share/tomcat/bin or something silly like that (I may be getting the exact path wrong... typing this from memory).
So I'm at a bit of a loss as to how these customizations on the Tomcat cookbook ever worked since they only seem to be applied to the custom instances that I can't for the life of me get to work in the first place :-)
Here is the extremely simple cookbook I made to test the "custom instance" behavior of the tomcat recipe... and no matter what I do, it doesn't seem to work. Any pointers appreciated of course.
https://github.com/StFS/tomcat-cookbook-test

Found the cause. I'll lump the fix in with #116 tomorrow as I believe it only affects Tomcat 7 on Fedora and RHEL.

Great news... out of curiosity, what was it?

Done. It was this line.
Multiple instances should work now but you will still have permission problems if you change the user/group. This is partly due to a flaw in the RHEL scripts. I have filed a separate pull request (#122) to address this problem but you should look at our yakara branch to get all the fixes in one place.
Even this pull request isn't quite the end of the story. /etc/tomcat-foo/tomcat-users.xml is installed with mode 0660 and won't be readable by your user unless you put them in the tomcat group. Alternatively you may be able to fix up the permissions of this file in your own cookbook.

I just realised that I had broken Debian-based systems that use systemd like Jessie. For some reason, they still use a SysVinit script so we should stick to the old method there. This led me to look at other distros. openSUSE should work but Arch and recent Fedora releases will need further work.


Retry button not again loading the data in cart section

When user click on the retry button it is not loading .

I will be fix it

Can you assign this issue to me with labels gssoc-ext and hacktoberfest


Contribute to tflearn

@MarvinTeichmann thank you for this implementation of FCN in tensorflow. This is exactly what I was looking for. I'd like to humbly suggest you port your work into tflearn. I think that your implementation of _upscore_layer as well as the loss function you've defined would be very useful in tflearn.

Thanks for the hint and good idea. I have implemented the upscore_layer  and the semantic segmentation loss to tflearn. Can you have a short look at it? I have no experience with tflearn. Needed to do some changed to fit in to the framework but have cannot test whether it works now.
If everything is good like this I will open a pull request to tflearn.

@MarvinTeichmann wow, that was fast :D. I can take a closer look tonight, but I think it makes sense to open a pull request sooner rather than later. The maintainer, @aymericdamien, of tflearn will be able to give the most substantive feedback.
I only get a few hours a day to work on these things, but I'd like to contribute an example that recreates the FCN using tflearn and your new layers and loss.

@MarvinTeichmann that indeed looks really great! It would definitely be useful for our users. Do not hesitate to send us a pull request :) Just my suggestion is to move the 'semantic segmentation loss' to 'objectives.py' file instead of 'losses.py' file, and change 'logits'/'labels' arguments name to 'y_pred'/'y_true', for consistency with other objective functions.
@FreakTheMighty You can go ahead, thanks :)

@aymericdamien I've started working on porting @MarvinTeichmann networks here. https://github.com/MarvinTeichmann/tflearn/pull/1 I'm  sure I will get stuck along the way, but I think it will be good experience.
One thing I noticed about the weak_cross_entropy_2d_loss objective is that it takes arguments where tflearn objectives are passed as strings into the solver. How would that interface work in tflearn?

Yes, because of the extra argument, it couldn't directly be called as a string argument in regression layer, however, loss argument can be a function, so it could be something like:
def my_loss(y_pred, y_true):
  return tflearn.weak_cross_entropy_2d_loss(y_pred, y_true, num_classes=10)
net = ...
net = tflearn.regression(net, loss=my_loss)

Another approach would be to remove num_classes argument and calculate it automatically by checking dimension of y_true. So passing just
net = ...
net = tflearn.regression(net, loss='weak_cross_entropy_2d_loss')

will work

Merged in tflearn/tflearn#137.


Add support for Romanian counties

The infection rates in Romanian counties tend to vary a lot, so it would be very useful to us if you could make a per-county view. We are providing daily new cases per county data as a JSON api at https://covid19.geo-spatial.org/external/charts_vasile/assets/json/cazuri_zile_long.json - 4 fields, Data is data in YYYY-MM-DD format, Judet is county, Cazuri total is total cases and Cazuri noi is new cases.
Unfortunately per-county testing data isn't available, but I've noticed that for e.g. Russia you're using the country test rate as a proxy, so if you could do that here as well, it should be as good as it gets given public info.
Thank you very much for working on this, and let me know if there's anything we can help with!

Hi Ruxandra,
I filed this recently for data from the ECDC. I didn't see Romania unfortunately. Taking a look at the JSON file you linked to, I think we would need more information to incorporate it into the calculator.
The data that would make it easiest to support Romanian counties is:

date
county name
daily 7-day prevalence (number of new cases in the last 7 days divided by total population)

Note that the ECDC dataset divides number of new cases in the last 14 days per 100k inhabitants. This is also acceptable (though we would prefer "number of new cases in the last 7 days per 100k inhabitants").
https://github.com/microcovid/microcovid/issues/711

Hello!
I've updated the JSON to include daily 7-day and 14-day (in case you need it) prevalence per 100k
{
"Data": "2020-04-02",  //date
"Judet": "Alba", //county
"Populatie": 323778, //population
"Cazuri total": 9, //total number of cases
"Cazuri noi": 0, // daily cases
"Cazuri noi 7 zile": 0, //new cases in the last 7 days
"Cazuri noi 14 zile": 0, //new cases in the last 14 days
"Incidenta 7 zile/100k": 0, //incidence per 100k inhabitants in the last 7 days
"Incidenta 14 zile/100k": 0 //incidence per 100k inhabitants in the last 14 days
}
Thank you!

Thanks for the quick update! Turns out I didn't need the 7/14 days data, but I did need the population data you included in that update as well.
I've done a quick check, but can you test this out too?
https://deploy-preview-715--microcov.netlify.app/

Thank you, looks good - does this mean we can remove the 7/14 days data from the json (new cases in the last X days + incidence, or just incidence)? It's feeding off a manually updated spreadsheet so I'd rather keep it as simple as possible.
Forgot to mention, but the source of this data is the geo-spatial.org community - https://covid19.geo-spatial.org/despre would be a good credit link. We'll let you know if we ever manage to get per-county testing data (the government doesn't currently release it, unfortunately).

Thank you, looks good - does this mean we can remove the 7/14 days data from the json (new cases in the last X days + incidence, or just incidence)? It's feeding off a manually updated spreadsheet so I'd rather keep it as simple as possible.
Forgot to mention, but the source of this data is the geo-spatial.org community - https://covid19.geo-spatial.org/despre would be a good credit link. We'll let you know if we ever manage to get per-county testing data (the government doesn't currently release it, unfortunately).

Yes, you can safely remove
"Cazuri noi 7 zile": 0, //new cases in the last 7 days
"Cazuri noi 14 zile": 0, //new cases in the last 14 days
"Incidenta 7 zile/100k": 0, //incidence per 100k inhabitants in the last 7 days
"Incidenta 14 zile/100k": 0 //incidence per 100k inhabitants in the last 14 days

Shout out to both of you for making this happen! Thanks!!

Thank you as well!
Btw, sorry to bug, but the Region field no longer shows up when selecting Romania (either in the preview linked in this thread or on the main site). It used to show up yesterday, so looks like there may be a bug somewhere?

Oh! I'm sorry, I took the prevalence update out of the changes here to separate the "look for this new data" part from the "use this new data for the calculator" part, but forgot to do the second part. It should now be available!
https://github.com/microcovid/microcovid/pull/726


Add support of relative paths for git.ignoredRepositories

This PR fixes #76892

@joaomoreno You were right, converting the path into a URI and then getting its fsPath is breaking path on Linux, so I've removed it. Pull request is ready to be merged now :)

@joaomoreno Is there anything wrong with this PR? I'm not sure why it isn't merged yet, and I don't want conflicts to appear in future due to further changes.
If I can help with something, please let me know.

Thanks! :fireworks:


Pass pipeline vnet to spring mysql live test arm template

Some azure resources (sql) cannot be accessed by VMs in a vnet even if they have public access enabled. In these cases we have to set up the vnet rules in the arm template at deploy time (instead of via azure policy).
Relies on https://github.com/Azure/azure-sdk-tools/pull/8452

/azp run java - spring - tests

Hi @benbp , seems not work https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3877084&view=logs&j=3b7ed7b8-bcd3-50fd-895b-9d4997552555&t=af96931c-f6b5-5af5-6006-b2008357a7d4&l=502

/azp run java - spring - tests

Merging with one failing test, looks to be unrelated. @trande4884 to follow up.


Update free-programming-books.md

Doesn't really seem like a book to me, it's just a web page

Yes, just a cheat sheet.

Perhaps it should be added to a repo such as https://github.com/LeCoupa/awesome-cheatsheets


Device Communication queue occasionally gets stuck

This is a situation I've seen quite a few times:
Device communication queue stops processing at some points, probably because microcontroller responds with a message that isn't treated as a command acknowledgement.

Could possibly use fbp-spec to set up some stress-tests of this. Might require #13 to give proper results though

The queue and device communication protocol has had massive changes now, to be released in Microflo 0.7


EntityFrameworkConfigurationSource sample is out of date

The code here: https://github.com/aspnet/Docs/tree/master/aspnet/fundamentals/configuration/sample/src/CustomConfigurationSource
Which shows up in this doc: http://docs.asp.net/en/latest/fundamentals/configuration.html
Needs to be updated to take into account many renames and API changes in configuration.

@ardalis Is this getting addressed as part of https://github.com/aspnet/Docs/pull/1231?


Doc: new DSL components are missing from cheat-sheet on master

New WebSockets
New JMS
Pebble

Closed by e6efca0dc32c07856c69efc20f56d0703e7e900c


Update Makefile with updated task commands

What does this PR do?
This change updates the makefile with updated task run commands.
This change is needed to run the task in the MITVPC instead of private subnet in the stage/prod vpc
Helpful background context
Originally, we ran the task in our regular vpc in a private subnet, this is required to run in the MITVPC though with an MIT IP.
How can a reviewer manually see the effects of these changes?
These makefile commands come directly from terraform, so should be correct, but they can be tested locally as well.
What are the relevant tickets?

https://mitlibraries.atlassian.net/browse/DLSPP-131

Requires Database Migrations?
NO
Includes new or updated dependencies?
NO

Looks good to me.


Relax required_rubygems_version?

Hi,
Would it be possible to relax the required_rubygems_version requirement? Given that Heroku still ships Rubygems 2.6 with Ruby 2.4 and Rubygems 2.7 with Ruby 2.5 makes it a bit hard to use this gem there.
remote:        Running: bundle install --without development:test --path vendor/bundle --binstubs vendor/bundle/bin -j4 --deployment
remote:        Bundler Output: Warning: the running version of Bundler (1.15.2) is older than the version that created the lockfile (1.17.3). We suggest you upgrade to the latest version of Bundler by running `gem install bundler`.
remote:        Fetching gem metadata from https://rubygems.org/..............
remote:        Fetching version metadata from https://rubygems.org/..
remote:        Fetching dependency metadata from https://rubygems.org/.
remote:        haml-rails-2.0.0 requires rubygems version >= 3.0.0, which is incompatible with
remote:        the current version, <IP_ADDRESS>
remote:
remote:  !
remote:  !     Failed to install gems via Bundler.
remote:  !
remote:  !     Push rejected, failed to compile Ruby app.

Cheers,
Florian

Agreed, same with AWS Beanstalk. The commit that added doesnt describe any technical reason to have it so high.

@theflow 👋 just merged a depfu PR that broke our deployment due to this.
haml-rails should get a changelog to warn people of such things. looking into the commit-history is not a feasible solution.

travis-ci is also still on an incompatible older version of rubygems.

Same for semaphoreCI

Please do release a relaxed required_rubygems_version.

We are working at our company (i think like many others) with the Ubuntu LTS versions and it's packages. Latest LTS ist 18.04 and it's coming with rubygems version 2.7.6 (<IP_ADDRESS> on 16.04) - so we are actually not able to use haml-rails 2.0.0

Can a developer please comment on this?

We have the same issue with AWS OpsWorks, Chef 11 and rails 5.

Still impacting Heroku.

Right. Fixed via #154.