add make_salt_sfc_restore.py

Adds https://github.com/COSIMA/access-om2/blob/2911891/tools/make_salt_sfc_restore.py
This needs some tweaks to meet the requirements of the README, particularly adding provenance metadata. @ezhilsabareesh8 would you have time to do that before we merge this PR?

related: https://github.com/COSIMA/access-om3/issues/207

From the metadata it looks like this was also needed. We should include it in the script so it's a one-step process.
ncatted -O -a units,time,m,char,months since 0001-01-01 00:00:00 salt_sfc_restore.nc
ncrename -O -v so,salt mean_salinity_of_0_and_10m.nc

ncdump -h /g/data/ik11/inputs/access-om2/input_20201102/mom_01deg/salt_sfc_restore.nc
netcdf salt_sfc_restore {
...
// global attributes:
		:comment = "This salinity distribution is based on WOA13v2 where the land values are filled in with a conjugate gradient method. It is a simple average of land-filled salinity data at the depth of 0 and 10 meters." ;
		:history = "Fri Jun 28 12:31:42 2019: ncatted -O -a units,time,m,char,months since 0001-01-01 00:00:00 salt_sfc_restore.nc\nFri Dec  1 14:47:24 2017: ncrename -O -v so,salt mean_salinity_of_0_and_10m.nc" ;
		:NCO = "netCDF Operators version 4.7.7 (Homepage = http://nco.sf.net, Code = http://github.com/nco/nco)" ;
}

Oops, converting to draft. I'm not sure this is a good way to go, since this script also needs a lot of other code from https://github.com/COSIMA/access-om2/blob/master/tools. Do we want all that here as well?

@ezhilsabareesh8 would you have time to do that before we merge this PR?

@aekiss Yes I can do that, also there are some dependencies required for make_salt_sfc_restore.py, for example make_remap_weights.py, which also needs to be included if we move make_salt_sfc_restore.py to om3-scripts.


Add a message Serving Flask app (module "app.py" will be lazily loaded) to flask run related to #2706

When running flask run having FLASK_DEBUG=1 the lazy_loader options defaults to True and it causes the app to be loaded only when first request comes causing errors to be raised only to werkzeug debugger (on browser)
problem
When starting the command flask run you see Serving Flask app.. message even if the app module cannot be located because the error will only raise later. It can cause confusion and the false impression that the app module was successfully found.
To be noticed and have it explicitly in logs I added:
 * Lazy loader mode: on to the messages
$ flask run
 * Serving Flask app "app.py"
 * Environment: development
 * Debug mode: on
 * Lazy loader mode: on
 * Running on http://<IP_ADDRESS>:5000/ (Press CTRL+C to quit)
 * Restarting with stat
 * Debugger is active!
 * Debugger PIN: 189-281-652

Relates to #2706
But I think the problem is still by displaying  * Serving Flask app "app.py" while the app.py was not located yet, maybe the better option would be to change that message to something more explicit like:
 * Serving Flask app  (The module "app.py" will be lazily loaded)
What do you think? let me know and I update this PR

@davidism

I really don't want to add more messages to the dev server. The standard way for users to see errors when running the app is to see the error in the debugger. Thanks for looking into this, but I don't think this should change.

@davidism ok, we can avoid adding extra messages, but what do you think of changing the current one to * Serving Flask app (The module "app.py" will be lazily loaded) as it is explicit.
I know the usual way is seeing errors in the debugger, but this is not an application error this is a load error, the same way shell and routes command shows explicit error in the command line and also errors are shown in command line when lazy loader is False.
I can imagine a scenario where developer is counting on the stdout messages to assert some functional test.

That's better, but the message is really out of proportion compared to the rest of the output (and for how important the message will usually end up being).
 * Serving Flask app "app.py" (lazy loading) seems better.

I don't really predict this preventing any questions one way or the other though. Whether the messages are long or short, most users who are confused by not seeing the traceback immediately will probably not know what "lazy loading" is. I still think it's fine letting users see the error in the debugger only.

@davidism updated to * Serving Flask app "app.py" (lazy loading)

@davidism I also could not find any entry to that lazy loader behavior in http://flask.pocoo.org/docs/0.12/cli/#cli
If you think it is a good idea to have it I can add it to the docs later.

Docs describing when the app is loaded, where to see errors, and why lazy loading is used with the reloader would be good. They should be in server.rst, not cli.rst.


fix: code fix wrapJsxInFragment not working in new JSX emit

I implemented "Wrap in JSX Fragment" in #37917. It explicitly detects if the JSXEmit is React or ReactNative. When TypeScript supports the new JSX emit comes out, this file didn't be changed to reflect the new change. The result is this code fix is not working when using the new JSX emit.

Duplicate of #43635


Asking for help implementing this with AlpineJS

Overview
This is probably not a bug but me implementing this wrong. I use AlpineJS to init a lottie animation with lottie-web. This works fine. But as soon as I try to make it interactive (in this case on scroll), I'm running into this error:
TypeError: undefined is not a function (near '...lottieInteractivity.create...')

I can't figure out what I'm doing wrong. Hoping someone can enlighten me. Thanks in advance.
Code
<figure
    class="md:col-span-6"
    x-data="{ animation: '' }"
    x-init="
        animation = lottie.loadAnimation({
            container: $el, // This is the current element in Alpine
            renderer: 'svg',
            path: '{{ block:animation }}' // This comes from a CMS
        }),
        LottieInteractivity.create({
            mode: 'scroll',
            player: animation,
            actions: [
                {
                  visibility: [0, 1],
                  type: 'seek',
                  frames: [0, 100],
                },
            ],
        });
    "
>

Solved this by looking at the react documentation.
import { create } from '@lottiefiles/lottie-interactivity';
window.create = create
window.Alpine = Alpine
Alpine.start()

<figure
    x-data="{ animation: '' }"
    x-init="
        animation = lottie.loadAnimation({
            container: $el,
            renderer: 'svg',
            autoplay: false,
            loop: false,
            path: 'MY_ANIMATION'
        }),
        create({
            mode: 'scroll',
            player: animation,
            actions: [
                {
                visibility: [0, 1],
                type: 'seek',
                frames: [0, 100],
                },
            ],
        })
    "
>

@robdekort  Could you help me out with this? I'm trying to get it to work, and I've done similar to you, but I get in the console
Alpine Expression Error: lottie is not defined
Any ideas?

Make sure you got this:
import Alpine from 'alpinejs'
import lottie from 'lottie-web'
import { create } from '@lottiefiles/lottie-interactivity';

// Init Lottie
window.lottie = lottie
window.create = create

// Call Alpine.
window.Alpine = Alpine
Alpine.start()

That worked! I didn't need import { create } from '@lottiefiles/lottie-interactivity';, I just needed to add window.lottie = lottie
Thanks so much :)

Nice. Glad to be of help.


Add percentile range graphic to exploratory equity view

Who is this PR for?
Insights team, principals
What problem does this PR fix?
exploratory analysis
What does this PR do?
Adds on to the awesome work in https://github.com/studentinsights/studentinsights/pull/1609, to see the range of scores as well, and see what that suggests.
Screenshot (if adding a client-side feature)
In isolation:

With other STAR context:

@alexsoble https://github.com/studentinsights/studentinsights/pull/1609 is awesome, and super thought provoking!  This was one of the questions I kept asking looking at the data.  This adds more noise for sure (and is just for exploratory purposes).

selfie

👍


Make import specific

I'm working on the conda-forge PyPI mapping. One of the data sources is the import field. Ideally, each package should have a unique import name. The BundesAPI usage of the deutschland namespace combines with the lack of specificity in the import name to lead to all the BundesAPI packages being associated to only deutschland. Let's see if we can fix that...
Note: I don't want to rebuild, so I don't bump build number.

Checklist

[X] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[X] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Here's the list:
'de-bundesrat', 'de-ladestationen', 'de-strahlenschutz', 'de-autobahn', 'de-bundestag', 'de-dwd', 'de-interpol', 'de-jobsuche', 'de-mudab', 'de-nina', 'de-polizei-brandenburg', 'de-risikogebiete', 'de-smard', 'de-travelwarning', 'de-zoll', 'de-pegel-online', 'de-vag', 'de-abfallnavi', 'de-ausbildungssuche', 'de-berufssprachkurssuche', 'de-bundeshaushalt', 'de-bundestag-lobbyregister', 'de-coachingangebote', 'de-dip-bundestag', 'de-ecovisio', 'de-feiertage', 'de-hochwasserzentralen', 'de-marktstammdaten', 'de-studiensuche', 'de-tagesschau', 'de-entgeltatlas', 'de-pflanzenschutzmittelzulassung', 'de-weiterbildungssuche', 'de-dashboarddeutschland', 'deutschland'

@maresb I maintain the packages here on Conda-forge but I am not a developer of these packages. Still for me it is fine to merge these changes and I can try to apply the same changes to the other packages in the list. Should I merge this pull request?

@conda-forge-admin, please rerender

@jan-janssen, thanks for the quick response!
This is a pure conda-forge issue, so no need to contact the upstream maintainers.
If you could try to apply the corresponding change to the other packages, that would be amazing!!!
I think it was a mistake to rerender, but up to reverting the rerender, I think this should be ready to merge. Thanks!

I just removed the rerender, so it should be safe to automerge this one.
Thanks so much for taking the lead on this, it looks like a lot of work! :heart:

Thanks so much for taking the lead on this, it looks like a lot of work! ❤

@maresb I created the other corresponding pull request, maybe you can take a quick look at them and then we can merge them all.

Thanks so much @jan-janssen, looks perfect! (Up to one capitalization issue where I submitted a PR.)
I wonder if it's feasible for Grayskull to generate this correctly...

All done - great work !

This is excellent, thank you so much for all your work on this!!!

It worked!!! Thanks so much @jan-janssen for making this possible!
https://github.com/regro/cf-graph-countyfair/commit/7ccb68ae5c8631935c31b781dc04a714a88f6a34#diff-fc588ed17723e5046ca3d20d5d2088f8c295466340598bb4155d3f8ad5fd9422


Reusing the same Dependabot triggering workflow

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2863  👈
#2862
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatChen and the rest of your teammates on  Graphite


Adding both text as well as an image to a field

Version: 1.16.0
I have a larger field in a PDF document that requires me to enter some text but also add my signature as an image.
I have not found a way to add both (the field would be large enough). Is there a way to do this?

I don't think so. Not sure if I understand your question though. Visuals and examples would help.


[tutorials] Cleaned up documentation

Signed-off-by: Dmitry Ermilov<EMAIL_ADDRESS>

1. line 82;  The set of samples packaged with the SDK showcase**s**

2. line 91: .. and can therefore not be used on Microsoft Windows 7 -may be it's better to change on  "and thus/therefore can't be used on Microsoft Windows 7"

3. line 164: gaps (stalls?) in the processing pipelines **cant be filled easily.**
   4: line 169; We**'ll** explore this approach further

Thank you!


Is this still working?

The core logic should still work, though you may need to update the regexes yourself.

I did successfully install the mangopi setup.py
But the terminal doesn't recognize this command.
Could you please try yourself and update the code to be working?
I'd be highly appreciate your help.
Thanks

Ah, I see where the confusion might be.  After you install mangopi, you need to open a python console via python before running the code in Usage.

If this works, the mangopi would download the manga images to the same directory?
Or, it just gives me the response in JSON format?


Add ExtraProgramPages app call field support

TODO: update go sdk to 1.9.0 when released to access ExtraProgramPages field
Summary

Use ExtraProgramPages from app create txn in accounting
Add TotalExtraAppPages and TotalAppSchema calculated fields to account response

Test Plan
Existing tests? Please point which tests need to be updated

could you make travis happy?

For testing, please enable this section in the validator and add the new apps-total-extra-pages field:
https://github.com/algorand/indexer/blob/develop/cmd/validator/struct_processor.go#L74
For automated tests, we don't have a great way to do it. You could modify the bash tests. There should be some data for the total schema, but you'd have to check the total pages equals 0:
https://github.com/algorand/indexer/blob/develop/test/common.sh
The last option would be to add a go integration test, this is pretty cumbersome though, so maybe the bash script is easier:
https://github.com/algorand/indexer/blob/develop/idb/postgres/postgres_integration_test.go#L788

could you make travis happy?

I guess after go sdk release and updating the reference.

@algorandskiy The swagger spec file also needs the extra pages field in TransactionApplication (line 1571).

@algorandskiy The swagger spec file also needs the extra pages field in TransactionApplication (line 1571).

Nice catch, thank you, I thought it shares ApplicationParams with apps but it does not.

Updated go sdk to 1.9.0
Can someone explain how to add e2e_subs test into test suite data?

Codecov Report

Merging #545 (3a6acfa) into develop (2f4aa0b) will decrease coverage by 0.10%.
The diff coverage is 5.55%.

@@             Coverage Diff             @@
##           develop     #545      +/-   ##
===========================================
- Coverage    34.18%   34.07%   -0.11%
===========================================
  Files           24       24
  Lines         4842     4860      +18
===========================================
+ Hits          1655     1656       +1
- Misses        2948     2964      +16
- Partials       239      240       +1

Impacted Files
Coverage Δ

accounting/accounting.go
47.56% <0.00%> (-0.20%)
:arrow_down:

idb/postgres/postgres.go
27.57% <5.88%> (-0.20%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4aa0b...3a6acfa. Read the comment docs.

Thanks Tolik and Will for pointing to the test suite. Added extra pages test.

Updated go sdk to 1.9.0
Can someone explain how to add e2e_subs test into test suite data?

@brianolson - penny for your thoughts ?

Removed Applications and GetAccounts tests for now - they require some additional setup and I can't figure out what. Will do add these in a separate PR.

Updated go sdk to 1.9.0
Can someone explain how to add e2e_subs test into test suite data?

@brianolson - penny for your thoughts ?

There is some documentation here, but it depends on deprecated features of indexer...
https://github.com/algorand/indexer/tree/develop/test#integration-test

There's a small fix needed to misc/buildtestdata.sh; I'm working on running this now to re-prove that system.

This makes buildtestdata.sh work,
but indexer develop branch fails the resulting data; hopefully the code changes in this PR fix that.

@algorandskiy the no rounds issue is because we changed these helpers to lookup the round. To add this test I modified your code as follows:
                err := state.AddTransaction(&txnRow)
                require.NoError(t, err)
+
+               block := test.MakeBlockForTxns(test.Round, &txn)
+               blockImporter := importer.NewDBImporter(db)
+               txnCount, err := blockImporter.ImportDecodedBlock(&block)
+               assert.NoError(t, err, "failed to import")
+               assert.Equal(t, 1, txnCount)
        }

        err = db.CommitRoundAccounting(state.RoundUpdates, test.Round, &types.BlockHeader{})
@@ -946,4 +953,14 @@ func TestAppExtraPages(t *testing.T) {
        var ap AppParams
        err = encoding.DecodeJSON(paramsStr, &ap)
        require.Equal(t, uint32(1), ap.ExtraProgramPages)
+
+       rows, _ := db.GetAccounts(context.Background(), idb.AccountQueryOptions{EqualToAddress: test.AccountA[:]})
+       num := 0
+       for row := range rows {
+               require.NoError(t, row.Error)
+               num++
+               require.NotNil(t, row.Account.AppsTotalExtraPages, "we should have this field")
+               require.Equal(t, uint64(1), *row.Account.AppsTotalExtraPages)
+       }
+       require.Equal(t, 1, num)
 }

Thank you Will, added Applications and GetAccounts tests back.


[firebase_analytics, firebase_crashlytics] deprecating the install_referrer intent ( Migrate to the Play Install Referrer API)

Google is changing install referer api and current install_referrer intent  will be deprecating.
Is there any plans to migrate this plugin ?
Thanks.

Hello Google Play Developer,
We recently announced that we’ll be deprecating the install_referrer intent broadcast mechanism. Because one or more of your apps uses this intent to track referrals, we wanted to ensure you make the switch before March 1, 2020. After this date, new versions of the Play Store app will no longer broadcast the install_referrer intent after app installs.
Action required
Migrate to the Play Install Referrer API to track your app installs for the following apps and/or games.

Closing due to age and the latest versions of Core and Analytics Android SDKs are now in use.


Having issues reusing component in a new module.

I'm submitting a ...
[ ] bug report
[ ] feature request
[X] question about the decisions made in the repository

I'm having issues reusing components in ng2-admin. I am new to the NgModule concepts, and I can't seem to find out a way to reuse UI that is already built within the application.
Such as
I've imported both NgModule and NgaModule into my 'NewModule.ts' page, as I figured that's all I needed to do to reuse the ba-card element, but for some reason or another it just keeps throwing an error and will not load the page now, unless I remove the  from the New.component.html.
Can someone help me with this?

Idk why but the issue isn't happening anymore, imported NgaModule, and now everything works. Must have just been a weird bug at the time. Who knows.


What is the official way to type connect ( from flow-typed/react-redux) after 0.85?

I recently updated to the latest version of flow. I keep looking around, whether it's docs, existing issues, library definition but I can't find anything to answer my question:
How do I type connect after flow 0.85?
I'm on flow 0.93 now, my react-redux type definition from flow-typed is up to date, and I just keep having the following issue:
Missing type annotation for OP. OP is a type parameter declared in function
type [1] and was implicitly instantiated at call of connect [2].

     src/views/component/myStuff/index.js
      83│   }
      84│ }
      85│
 [2]  86│ const MyStuff = connect(mapStateToProps, mapDispatchToProps)(
      87│   reduxForm({ form: FORM_NAME })(injectIntl(DefaultCollection)),
      88│ );
      89│

     flow-typed/npm/react-redux_v5.x.x.js
 [1] 131│   declare export function connect<-P, -OP, -SP, -DP, S, D>(
     132│     // If you get error here try adding return type to your mapStateToProps function
     133│     mapStateToProps: MapStateToProps<S, OP, SP>,
     134│     mapDispatchToProps: DP,
     135│     mergeProps?: null | void,
     136│     options?: ?Options<S, OP, SP, MergeOPSPDP<OP, SP, DP>>,
     137│   ): Connector<P, OP, MergeOPSPDP<OP, SP, $ObjMap<DP, Bind<D>>>>;

I'm pretty desperate at this point to make it work, every flow update has been painful but this one is perhaps the most complex one I've had to do in a while. I've found many answers but none of them seem to work or are outdated.
I'm probably not the only one stuck on this one, it would be nice to have more migration guides when that kind of breaking changes happens.

Have a look at the tests alongside the flow-typed libdef.  That's the best way to see up-to-date recommended practices: https://github.com/flow-typed/flow-typed/blob/master/definitions/npm/react-redux_v5.x.x/flow_v0.89.x-/test_connectDispatch.js
I don't personally use mapDispatchToProps (find it easier to just pass dispatch as a prop and create the actions where needed, seeing as usages can be checked with Dispatch / Action types), but with just mapStateToProps I do it like this:
type OwnProps = $ReadOnly<{|
  comingFromOutside: string,
|}>;

type Props = $ReadOnly<{|
  ...OwnProps,
  comingFromConnect: string,
  dispatch: Dispatch,
|}>;

function MyComponent(props: Props) {
  // ...
}

export default connect<Props, OwnProps, _, _, _, _>((state: State) => ({
  comingFromConnect: state.foo,
})(MyComponent);

Thank you, this makes immediately more sense
Are there any plans to update the current documentation for Redux?
Also it looks like there are some other dependencies involved with this update right?
This is what I'm getting, despite updating to the latest version of eslint-plugin-flowtype
error  in ./src/views/profile/defaultCollection/index.js

Syntax Error: SyntaxError: Unexpected token, expected ; (85:28)

  83 | }
  84 |
> 85 | export default connect<Props, OwnProps, _, _, _, _>(mapStateToProps, mapDispatchToProps)(
     |                             ^
  86 |   reduxForm({ form: FORM_NAME })(injectIntl(DefaultCollection)),
  87 | );
  88 |

In my case, most of the times passing six wildcards just work:
connect<*, *, *, *, *, *>(mapStateToProps, mapDispatchToProps)

I'm using latest Flow and<EMAIL_ADDRESS>definition from flow-typed

Are there any plans to update the current documentation for Redux?

Good point.  The flow-typed react-redux definitions have been iterating pretty fast, so the flow.org documentation could probably do with an update.

Also it looks like there are some other dependencies involved with this update right?

Yeah type-hinting functions like that is a recent syntax development, so you'll need something up-to-date.  I'm using babel-eslint (10.0.1) as the parser defined in eslintrc.  I think that will solve _ undefined errors too if _ now has special meaning in Flow generics.

In my case, most of the times passing six wildcards just work:

They're recommending against wildcard usage now (on grounds of it significantly slowing down typechecking), I think it's going to be removed at some point soon.  I think the underscore has different semantics, although not completely sure as I haven't seen much discussion of it.

_ is equivalent to not passing a type argument. So connect<_,_,_,_,_,_>(mapStateToProps, mapDispatchToProps) is exactly equivalent to connect(mapStateToProps, mapDispatchToProps).
When you don't pass type arguments, Flow implicitly instantiates a type variable an passes that to the call. So connect(mapStateToProps, mapDispatchToProps) becomes:
let A, B, C, D, E, and F be fresh type variables: connect<A,B,C,D,E,F>(mapStateToProps, mapDispatchToProps)
_ lets you explicitly specify some arguments, but let Flow do implicit instantiation for only the ones you use _ for.
Closing this issue as the discussion here about redux typings are better suited to the flow-typed repo.

Yeah type-hinting functions like that is a recent syntax development, so you'll need something up-to-date. I'm using `babel-eslint` (`10.0.1`) as the parser defined in eslintrc. I think that will solve `_ undefined` errors too if _ now has special meaning in Flow generics.

I'm on "@babel/core": "7.3.3", "babel-eslint": "10.0.1", "eslint-plugin-flowtype": "3.4.2", and "eslint-loader": "2.1.2", and I' m still seeing this eslint error:
  85:41  error  '_' is not defined  no-undef
  85:44  error  '_' is not defined  no-undef
  85:47  error  '_' is not defined  no-undef
  85:50  error  '_' is not defined  no-undef

✖ 4 problems (4 errors, 0 warnings)

@MaximeHeckel  Very strange, the underscores don't trigger no-undef for me under the following setup:
"flow-bin": "^0.93.0" "@babel/core": "^7.3.3" "babel-eslint": "^10.0.1" "eslint-plugin-flowtype": "^3.4.2"
---
parser: babel-eslint
plugins: [flowtype, react, react-hooks]
extends:
  - eslint:recommended
  - plugin:flowtype/recommended
  - plugin:react/recommended

Not sure what further to suggest, sorry!

I'm on "flow-bin": "0.89.0" "@babel/core": "7.3.3", "babel-eslint": "10.0.1", "eslint-plugin-flowtype": "3.4.2", and "eslint-loader": "2.1.2", and I' m still seeing this eslint error:
  85:41  error  '_' is not defined  no-undef
  85:44  error  '_' is not defined  no-undef
  85:47  error  '_' is not defined  no-undef
  85:50  error  '_' is not defined  no-undef

✖ 4 problems (4 errors, 0 warnings)

Did you found solution to this?

Hi, I'm facing the same issue. "Parsing error: Unexpected token". Did you find a solution? Thanks


[BUG] TypeError: color must be int or single-element tuple

Describe the bug
A clear and concise description of what the bug is.
pytorch 1.13.1
cuda 11.6
python3.9
Additional context
Add any other context about the problem here.
when train qmnist data:  raise except as follows:
py", line 2128, in rotate
return self.transform((w, h), AFFINE, matrix, resample, fillcolor=fillcolor)
File ".conda/envs/paddle_env/lib/python3.9/site-packages/PIL/Image.py", line 2453, in transform
im = new(self.mode, size, fillcolor)
File ".conda/envs/paddle_env/lib/python3.9/site-packages/PIL/Image.py", line 2670, in new
return im._new(core.fill(mode, size, color))
TypeError: color must be int or single-element tuple
TypeError: color must be int or single-element tuple

assume you're using auto-augment/rand-augment as those are only places with rotate, those augmentations are only configured for color use, so you'd have to modify for mono, also generally for mono use you need to set mean/std for dataset to a single value tuple instead of 3-channel values used by default


[Twitch] still getting ads when subscribed to streamer

i am subscribed to a streamer but my live captured streams still get the commercial break screen
is there any way to make twitch not serve ads to LiveStreamDVR since my account does not get ads on that channel due to being subscribed

Use TTvlol or http proxy to get bo ads


OSError: input_filepath  does not exist

When generating a video I get this error:
Traceback (most recent call last):
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask\app.py", line 1488, in call
return self.wsgi_app(environ, start_response)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask\app.py", line 1466, in wsgi_app
response = self.handle_exception(e)
^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask_cors\extension.py", line 176, in wrapped_function
return cors_after_request(app.make_response(f(*args, **kwargs)))
^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask\app.py", line 1463, in wsgi_app
response = self.full_dispatch_request()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask\app.py", line 872, in full_dispatch_request
rv = self.handle_user_exception(e)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask_cors\extension.py", line 176, in wrapped_function
return cors_after_request(app.make_response(f(*args, **kwargs)))
^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask\app.py", line 870, in full_dispatch_request
rv = self.dispatch_request()
^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask\app.py", line 855, in dispatch_request
return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)  # type: ignore[no-any-return]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\MoneyPrinter-Enhanced-main\Backend\main.py", line 333, in generate
process_music(music_file)
File "C:\MoneyPrinter-Enhanced-main\Backend\tiktokvoice.py", line 230, in process_music
tfm.build(input_file, lowvol_file)
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\sox\transform.py", line 593, in build
input_format, input_filepath = self._parse_inputs(
^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\sox\transform.py", line 493, in _parse_inputs
file_info.validate_input_file(input_filepath)
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\sox\file_info.py", line 248, in validate_input_file
raise IOError(
OSError: input_filepath  does not exist.
The input_filepath is blank.
I should probably add that I also installed google.generativeai manually and added the libmad-0.dll and libmp3lame-0.dll to the sox directory because of previous errors I was able to troubleshoot alone.

Sox is a problem on Windows, as far as I understood from other people. I do not have have a windows system at hand currently, but it needs a tutorial on its own for installation.
Probably the problem with input_filepath is created by backslashes.
If you look at code, I'm using relative paths, Unix style, for both the web part and the filesystem part. I'm not sure how to handle the paths correctly. I think os.path is the best way, I will try to change stuff so it won't create any more problems

I just pushed a change that should solve the specific problem in your issue, but it's not guaranteed for the rest of code. Will update ASAP

Tested it and now the error is different:
Traceback (most recent call last):
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask\app.py", line 1488, in call
return self.wsgi_app(environ, start_response)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask\app.py", line 1466, in wsgi_app
response = self.handle_exception(e)
^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask_cors\extension.py", line 176, in wrapped_function
return cors_after_request(app.make_response(f(*args, **kwargs)))
^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask\app.py", line 1463, in wsgi_app
response = self.full_dispatch_request()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask\app.py", line 872, in full_dispatch_request
rv = self.handle_user_exception(e)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask_cors\extension.py", line 176, in wrapped_function
return cors_after_request(app.make_response(f(*args, **kwargs)))
^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask\app.py", line 870, in full_dispatch_request
rv = self.dispatch_request()
^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\flask\app.py", line 855, in dispatch_request
return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)  # type: ignore[no-any-return]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\MoneyPrinter-Enhanced-main\Backend\main.py", line 333, in generate
process_music(music_file)
File "C:\MoneyPrinter-Enhanced-main\Backend\tiktokvoice.py", line 230, in process_music
tfm.build(input_file, lowvol_file)
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\sox\transform.py", line 593, in build
input_format, input_filepath = self._parse_inputs(
^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\sox\transform.py", line 496, in _parse_inputs
input_format['channels'] = file_info.channels(input_filepath)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\sox\file_info.py", line 82, in channels
output = soxi(input_filepath, 'c')
^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users%username%\AppData\Local\Programs\Python\Python312\Lib\site-packages\sox\core.py", line 153, in soxi
raise SoxiError("SoXI failed with exit code {}".format(cpe.returncode))
sox.core.SoxiError: SoXI failed with exit code 1

Can  you confirm that sox works in cmd? For example:
sox -v 0.5 some.mp3 out.mp3
This should reduce the volume of a file named some.mp3 at 50% and save as new file out.mp3

Yup, sox works as intended, just tested it out with an mp3 song

It should be fixed now


Fix 649 - Use EditorView for placeholder instead of ViewPlugin

Seems like with the latest release, ViewPlugins don't play so well as decorations, especially if they are borderline to cross a line.
I've taken inspiration from this and updated the placeholder plugin helper function. It seems to work, even though you might have something else in mind.
There may be more ViewPlugins that stopped working (so this may have be a breaking change? 🤔)
https://github.com/codemirror/codemirror.next/issues/649
https://github.com/fonsp/Pluto.jl/issues/1779

That was a bug in the code that drew the decorations. https://github.com/codemirror/view/commit/a5c02551139e0c takes care of it.


mermaid 8.0 is coming and call for documentation contributors

First of all, a good news for mermaid users
mermaid 8.0 stable version is coming soon.  🎉
You can install the beta version to have a try now!
Major changes:

mermaid 8.0 works with d3 version 4 (bye d3 version 3)
it allows you to specify xAxis date format easily
it allows you to specify your own CSS or the whole theme easily
diagram CSS is scoped in its own ID so it won't pollute the DOM
flowchart curves are supported.
SequenceDiagram: Add support for multiple alt else statements
All dependencies libraries have been updated to the latest version
It's pretty modern and it has no problem working together with webpack & parcel
lots of issues fixed and lots of small improvements

Call for documentation contributors. ❤
Documentation is here: https://mermaidjs.github.io/ It's based on GitBook and its source code is here: https://github.com/mermaidjs/mermaid-gitbook
Its content is pretty dated. Lots of knowledges there are even wrong.
So please contribute to the documentation.
How
Recently I closed lots of issues in the following projects:

https://github.com/knsv/mermaid
https://github.com/mermaidjs/mermaid.cli
https://github.com/mermaidjs/mermaid-live-editor

From those recently closed issues, you can find lots of mermaid usage information which is more correct than the current documentation. For example, mermaid diagram now uses inline CSS instead of external CSS file (this is mainly to make the SVG file portable, so you can download it.)
If you know something useful about mermaid, or you know something is wrong in the documentation. Please fork https://github.com/mermaidjs/mermaid-gitbook and send PRs.
Thank you very much!

Hi is there a deadline to complete this documentation? or will v8 be held up until documentation is sufficiently updated?
Either way I'd be happy to help out as I have just spent some time reading through your code :). Would be great to be directed to the sections that need more help than others?

@renegare there isn't a deadline because this is a community project run by volunteers. For now you can install and try the pre-release versions. At the moment it is<EMAIL_ADDRESS>For the documentation, I think we should include the major changes we made for v8.  I made a list above. So maybe you can pick one or more to document them.  :)
For example: https://mermaidjs.github.io/flowchart.html doesn't mention anything about flowchart curves are supported. We can add the content there.

Hi. I am interested in contributing. It would be helpful to know where to begin.

hi @tylerlong, how’s the maintenance status of this repo? I haven’t seen anyone pushing anything since april!


display a popup message after submitting get in touch form and add message length validation

#337
Pull Request Checklist

[x] I have added screenshots and videos to show before and after the working of my code.
[x] I have ensured that the screen size is set to 100% while making the video.
[x] I have synced the latest fork with my local repository and resolved any conflicts.
[x] I understand that if any the above conditions are not met , my PR will not be MERGED .

kindly video of the same

Uploading WhatsApp Video 2024-10-06 at 11.30.59_a4e5a0b5.mp4…

@ANSHIKA-26
https://github.com/user-attachments/assets/2500b700-83b3-4fab-bbf7-8ec724494c3e


refactor(e2e): create goToUrl

I agree, that it can be tedious  - what I am not sure of now is how turning into a class solves the issue? Can you drop a quick example here?

will merge it now as is, and will refactor later


Create wrappers for VARIANT and PROPVARIANT structures

VARIANT and PROPVARIANT structures are commonly used in COM APIs. Essentially, they are containers for a large union that carries many types of data.
Here's the current way of creating a VARIANT struct that holds a BSTR type:
final variant = calloc<VARIANT>();
variant.ref
  ..vt = VARENUM.VT_BSTR // define the type of VARIANT
  ..bstrVal = BSTR.fromString('I am a happy BSTR').ptr; // set the value

// Do something with the VARIANT...

// Clean up
VariantClear(variant);
calloc.free(variant);

As you can see, it's a bit verbose. In v6, I plan to create wrappers for these structures using extension types.
Here's how the wrapper for VARIANT could look like:
/// Represents a pointer to [VARIANT] struct.
extension type const Variant(Pointer<VARIANT> _) implements Pointer<VARIANT> {
  /// Constructs an empty VARIANT.
  Variant.empty() : this(calloc<VARIANT>());

  /// Whether this VARIANT is empty.
  bool get isEmpty => _.ref.vt == VARENUM.VT_EMPTY;

  /// Constructs a VARIANT holding a [BSTR] value.
  static VariantBSTR bstr(String value) => VariantBSTR(value);

  // ...

  /// Releases the memory allocated for this VARIANT.
  void free() {
    VariantClear(this);
    calloc.free(this);
  }
}

/// Represents a VARIANT holding a [BSTR] value.
extension type const VariantBSTR._(Variant _) implements Variant {
  /// Constructs a VARIANT holding a [BSTR] value.
  factory VariantBSTR(String value) {
    final variant = Variant.empty();
    variant._.ref
      ..vt = VARENUM.VT_BSTR
      ..bstrVal = BSTR.fromString(value).ptr;
    return VariantBSTR._(variant);
  }

  /// The [BSTR] value stored in this VARIANT.
  String get value => ref.bstrVal.toDartString();
  set value(String value) => ref.bstrVal = BSTR.fromString(value).ptr;
}

// ...

With this wrapper, the original example simply becomes:
final variant = Variant.bstr('I am a happy BSTR');

// Do something with the VARIANT...

// Clean up
variant.free();

I just encountered this similar problem，haha


maturin 0.11.0 now can package type stub file for you

https://github.com/PyO3/maturin/pull/567
FYI.

Thanks for the heads up. I tried to update it now and found it introduced issues in the library.
I have created https://github.com/PyO3/maturin/issues/591 for followup on the issue. I'm holding update until then :)

Closed by merging #23


Size of image buffer is 38400 rather than 9600

Describe the bug
If I want to use ILI9341 LCD (320x240), the value of img->pixLength() in updateScreen() in libs/st7735---screen/scree.cpp is 38400. But it should be 9600.
To Reproduce
Steps to reproduce the behavior:

Set LCD related parameters as follows in config.ts. (If I use parameters of ST7735, LCD works fine)

export const PIN_DISPLAY_SCK = DAL.P0_1;
export const PIN_DISPLAY_MISO = DAL.P0_24;
export const PIN_DISPLAY_MOSI = DAL.P1_2;
export const PIN_DISPLAY_CS = DAL.P0_5;
export const PIN_DISPLAY_DC = DAL.P1_5;
export const PIN_DISPLAY_RST = DAL.P1_3;
export const PIN_DISPLAY_BL = DAL.P1_7;

export const DISPLAY_TYPE = 9341
export const DISPLAY_WIDTH = 320
export const DISPLAY_HEIGHT = 240
export const DISPLAY_CFG0 = 0x08
export const DISPLAY_CFG1 = 0x0010ff
export const DISPLAY_CFG2 = 50

Add "game": "file:../game" to "dependencies" category of pxt.json.
Then from the makecode editor, I can use [Scene] category. If I use [Set background image to ()] block and download uf2 file to my board, my board blinks LED irregularly.
I found it entered target_panic(PANIC_GC_TOO_BIG_ALLOCATION). It is because it satisfies if (numbytes > GC_MAX_ALLOC_SIZE) condition in void *gcAllocate(int numbytes) in libs/base/gc.cpp. The value of GC_MAX_ALLOC_SIZE is 16k while numbytes is 38416.
If I change GC_MAX_ALLOC_SIZE to larger value, like 64k, then this panic doesn't happen.
But target_panic(PANIC_SCREEN_ERROR) happens. Because img->width() * mult != display->width condition and img->height() * mult != display->displayHeight condition are satisfied in updateScreen() of libs/st7735---screen/scree.cpp.
Followings are related values:
For the explanation why img->pixLength() should be 9600, please refer to https://github.com/lancaster-university/codal-core/pull/118. This PR is closed but I think the calculation result is correct.

display->doubleSize : 1
mult : 2
img->bpp : 4
img->width() : 320   ---> it should be 160, since actually use LCD as 160x120 resolutuion
img->height() : 240   ---> it should be 120, since actually use LCD as 160x120 resolutuion
display->width : 320
display->height : 240
img->pixLength() : 38400 ---> it should be 9600, since actually use LCD as 160x120 resolutuion

I think if the image buffer size is corrected, the PANIC_GC_TOO_BIG_ALLOCATION panic will not happen.

I think I found a way.
I can modify arguments of image.create() in pxt-common-packages\libs\screen---st7735\targetoverrides.ts to fix image size to 160x128 or 160x120.
I will close this issue.


Added 'Dragon scale' upgrade to CalculateGains method

The latest update to CookieClicker added the "Dragon scale" upgrade, which affects CpS.

Thanks for your work.  I'll take a look when I get a chance.

With approval of #319 this is no longer needed. Thanks for your work though!


IMPORTANT - HTTPS Certificate invalid. Nothing is working

See: https://alexa-node-red.bm.hardill.me.uk/

Bugger I was sure that was next week. I'm away from home at the moment will
fix as soon as I get home tomorrow
On 15 Aug 2017 16:24, "Cryptix"<EMAIL_ADDRESS>wrote:

See: https://alexa-node-red.bm.hardill.me.uk/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hardillb/node-red-alexa-home-skill-web/issues/26, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABt6jWWHFw0QKpe5S9D7g5im7Wkq-1Eeks5sYbgkgaJpZM4O3ur-
.

Great! Ps: How I can donate? c:

I have good experience with the acme.sh LE Script, works like a charm by cronjob.

It doesn't work on bluemix, I have a workaround, it just requires manually
uploading the certs to the console. It will get done early afternoon
tomorrow.
On 15 Aug 2017 19:09, "Marco G"<EMAIL_ADDRESS>wrote:

I have good experience with the acme.sh
https://github.com/Neilpang/acme.sh LE Script, works like a charm by
cronjob.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hardillb/node-red-alexa-home-skill-web/issues/26#issuecomment-322544103,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABt6jQsMufobzdXId3LzC0Gid3vtpt7Oks5sYd7egaJpZM4O3ur-
.

Certificate should be updated, all should be working again now.

Yeee, nice!


Bug in picker

If you scroll hard and just stop the scroll it can get stuck between two values
Is there a fix? I use 1.1.2

can confirm this bug. just scroll fast and then click to stop. do it couple times, it will stop in a mid-value

My current (dirty) solution is to see if the state is correct
Written in Kotlin:
        var currentState = 0
        wheel.setOnWheelChangeListener(object: WheelPicker.OnWheelChangeListener {
            override fun onWheelSelected(position: Int) {
            }

            override fun onWheelScrollStateChanged(state: Int) {
                currentState = state
            }

            override fun onWheelScrolled(offset: Int) {
            }
        })

And if the currentState != WheelPicker.SCROLL_STATE_IDLE the wheel is incorrect set

Do you know if the wheel can auto slide ? To have a button and to start scrolling by its own ?

See the last line of code in this part of method run() that I have added - seems to "take care" of the problem (and also the problem that I had whereby I could with a bit of care position the wheel between two entries in the wheel
``    @Override
public void run() {
    if (mScroller.isFinished()) {
        int position = (-mScrollOffsetY / mItemHeight + mSelectedItemPosition) % mData.size();
        position = position < 0 ? position + mData.size() : position;
        if (isDebug)
            //BA.Log("TAG" + position + ":" + mData.get(position) + ":" + mScrollOffsetY);
        mCurrentItemPosition = position;
        if (null != mOnItemSelectedListener)
            mOnItemSelectedListener.onItemSelected(this, mData.get(position), position);
		    //BA.Log("in run = " + mData.get(position));
        if (null != mOnWheelChangeListener) {
			//BA.Log("in run = " + mData.get(position));
            mOnWheelChangeListener.onWheelSelected(position);
			//BA.Log("in run" + position);
            mOnWheelChangeListener.onWheelScrollStateChanged(SCROLL_STATE_IDLE);
        }
		setSelectedItemPosition(position);
    }

Removing this code in ActionUp of OnTouchEvent:
if (isClick) break;
seems to resolve the problem. I didn't found any side effects of this.

Any news on this? Or does someone know how to fix this without modifying the WheelPicker.java?

OK cool, this seems to be fixed in master, however not in 1.1.2 release version.


Add init to arrow/mapper

Summary
Fix not packaged due to missing __init__.
How to test
Checklist

[ ] I have added unit tests to cover my changes.
[ ] I have added integration tests to cover my changes.
[ ] I have added the description of my changes into CHANGELOG.
[ ] I have updated the documentation accordingly

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below).

# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.02 :warning:

Comparison is base (08425db) 78.68% compared to head (700e3b4) 78.67%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.2.0     #943      +/-   ##
==================================================
- Coverage           78.68%   78.67%   -0.02%
==================================================
  Files                 231      232       +1
  Lines               26408    26411       +3
  Branches             5257     5257
==================================================
- Hits                20780    20778       -2
- Misses               4403     4405       +2
- Partials             1225     1228       +3

Flag
Coverage Δ

macos-11_Python-3.8
?

ubuntu-20.04_Python-3.8
78.67% <100.00%> (+<0.01%)
:arrow_up:

windows-2019_Python-3.8
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...maro/plugins/data_formats/arrow/mapper/__init__.py
100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Did you run all the tests after installing from the package? (no ./datumaro in sys.path and pip install -e .)

Yes, I have confirmed most of tests (except using in plugins/openvino_plugin/samples) are passed and the package contains arrow/mapper directory as well.


Found issue setInnerHTML and resolved for last preact (simple patch)

With preact we ve got some issue from setInnerHTML on state change
Finally with lot of test, i found the clue of it: (and it's simple patch)
Line 154 change the line
} else if (vchildren && vchildren.length || null != fc) innerDiffNode(out, vchildren, context, mountAll, hydrating || null != props.dangerouslySetInnerHTML);
to
} else if (vchildren && vchildren.length || null != fc) innerDiffNode(out, vchildren, context, mountAll, hydrating , null != props.dangerouslySetInnerHTML);
nota: comma between hydrating and null

Hi there,
By adding the comma, you're passing the result of null != props.dangerouslySetInnerHTML as a 6th argument to innerDiffNode, which only accepts 5 arguments. This has the same effect as removing the code entirely, so it's unlikely to be correct.
Can you provide more details about the issue you're running into?

in fact after did that i have got no one issue after changing state to display my popover, My application is quite complex; all the website work perfectly i didn't see any trouble after changing that
So maybe the code removed was not good
the website working with preact is:
https://www.skiscool.fr
You can check the size , i optimized react fully (from 500kb -> 100 kb) thanks to your preach and the last uglifyjs-webpack-plugin
Nota
(maybe interesting to know)
i use the last version of babel 7.0.0-alpha.20 and the version loose work fully with preact too

With Preact X the content of dangerouslySetInnerHTML will only change, when the actual value does :tada:

this bug is driving me mad... i'm sorry but how come you couldn't just merge the solution from this issue 2 years ago? preact X is still alpha what's the reason behind not fixing it. people still use 8.


PRO and AUPRO metrics

Description

This PR adds the PRO AUPRO metrics, and the metrics are used by the base task. The PRO score is evaluated at the optimal threshold (based on F1).

Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Known Issues

The PRO metric has a high computational complexity. The current implementation is optimized to run on the GPU, running it on CPU will cause significant delays in the code execution.

Checklist:

[x] My code follows the pre-commit style and check guidelines of this project.
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing tests pass locally with my changes

This one is outdated. I also have some doubts about the implementation, because it runs too slow on CPU. I will revisit the implementation and submit a new PR. Closing this for now.


The acceptance length is not being reproduced

Hi, thanks for your great work!
I am calculating the acceptance length of EAGLE-2 using LLaMA-2-13B. I modified the code in evaluation/gen_ea_answer_llama2chat.py and model/ea_model.py to return the length.
evaluation/gen_ea_answer_llama2chat.py
for question in tqdm(questions):

    choices = []
    for i in range(num_choices):
        torch.manual_seed(i)
        conv = get_conversation_template("llama-2-chat")
        sys_p = "You are a helpful, respectful and honest assistant. Always answer as helpfully as possible, while being safe.  Your answers should not include any harmful, unethical, racist, sexist, toxic, dangerous, or illegal content. Please ensure that your responses are socially unbiased and positive in nature.\n\nIf a question does not make any sense, or is not factually coherent, explain why instead of answering something not correct. If you don't know the answer to a question, please don't share false information."
        conv.system_message = sys_p
        turns = []
        idxs = []
        ars = []    # add
        new_tokens = []
        wall_time = []
        for j in range(len(question["turns"])):
            qs = question["turns"][j]
            conv.append_message(conv.roles[0], qs)
            conv.append_message(conv.roles[1], None)
            prompt = conv.get_prompt() + " "
            input_ids = tokenizer([prompt]).input_ids

            torch.cuda.synchronize()
            start_time = time.time()
            output_ids, new_token, idx, ar = model.eagenerate(
                torch.as_tensor(input_ids).cuda(),
                temperature=temperature,
                log=True
            )
            torch.cuda.synchronize()
            total_time = time.time() - start_time
            output_ids = output_ids[0][len(input_ids[0]):]

            if conv.stop_token_ids:
                stop_token_ids_index = [
                    i
                    for i, id in enumerate(output_ids)
                    if id in conv.stop_token_ids
                ]
                if len(stop_token_ids_index) > 0:
                    output_ids = output_ids[: stop_token_ids_index[0]]

            output = tokenizer.decode(
                output_ids,
                spaces_between_special_tokens=False,
            )
            if conv.stop_str and output.find(conv.stop_str) > 0:
                output = output[: output.find(conv.stop_str)]
            for special_token in tokenizer.special_tokens_map.values():
                if isinstance(special_token, list):
                    for special_tok in special_token:
                        output = output.replace(special_tok, "")
                else:
                    output = output.replace(special_token, "")
            output = output.strip()

            if conv.name == "xgen" and output.startswith("Assistant:"):
                output = output.replace("Assistant:", "", 1).strip()

            turns.append(output)
            idxs.append(int(idx))
            ars.append(sum(ar)/len(ar)) # add
            new_tokens.append(int(new_token))
            wall_time.append(total_time)
            conv.messages[-1][-1] = output
        # torch.cuda.empty_cache()
        choices.append({"index": i, "turns": turns, "idxs": idxs, "new_tokens": new_tokens, "wall_time": wall_time, "ar": ars}) # fix

model/ea_model.py
input_len = input_ids.shape[1]
        reset_tree_mode(self)
        draft_tokens, retrieve_indices,tree_mask,tree_position_ids, logits, hidden_state, sample_token = initialize_tree(
            input_ids, self, past_key_values, logits_processor
        )
        new_token = 0
        ar = [] # add
        for idx in range(max_length):
            self.base_model.model.tree_mask = tree_mask
            draft_tokens=draft_tokens.to(input_ids.device)

            logits, hidden_state_new, outputs = tree_decoding(
                self,
                draft_tokens,
                past_key_values,
                tree_position_ids,
                input_ids,
                retrieve_indices,
            )
            #retrieve_indices=tree_buffers["retrieve_indices"]
            #logits = logits[0, retrieve_indices]
            draft_tokens=torch.cat((draft_tokens,padding),dim=1)
            candidates=draft_tokens[0,retrieve_indices]
            best_candidate, accept_length, sample_p = evaluate_posterior(
                logits, candidates, logits_processor
            )
            ar.append(accept_length) # add

            input_ids, draft_tokens, retrieve_indices,tree_mask,tree_position_ids, new_token, hidden_state, sample_token = update_inference_inputs(
                input_ids,
                candidates,
                best_candidate,
                accept_length,
                retrieve_indices,
                logits_processor,
                new_token,
                past_key_values_data,
                current_length_data,
                self,
                hidden_state_new,
                sample_p
            )

            if is_llama3:
                if stop_token_id in input_ids[0, input_len:].tolist():
                    break

            if self.tokenizer.eos_token_id in input_ids[0, input_len:].tolist():
                break
            if new_token > max_new_tokens:
                break
            if input_ids.shape[1] > max_length:
                break
        if not log:
            return input_ids
        else:
            return input_ids, new_token, idx, ar # add

However, during reproduction, I obtained relatively low values, and even after retraining the model, the results remained low.

I have a couple of questions regarding this:

Is there something wrong with the modified length-related code?
Currently, the acceptance length reproduction is not occurring. What could be the reasons for this?

question 2: +1 token issue, see this: https://github.com/SafeAILab/EAGLE/issues/132#issuecomment-2365218737

question 2: +1 token issue, see this: #132 (comment)

Thank you for confirming. It means that I just need to add one more token to the final length for the target model, right?

Yes, the author’s results seem to align with the results you presented after +1 token.

Thank you so much! Did you resolve the issue with  https://github.com/SafeAILab/EAGLE/issues/143#issue-2576608730

Yes, the author’s results seem to align with the results you presented after +1 token.

No, I am still unable to run the EAGLE-2 code branch directly.

For question 1, your length-related codes are right, since my implementation is same as yours.
Btw, I'm wondering have you ever evaluated the accept length of author released checkpoints EAGLE-Qwen2-7B-Instruct on mt-bench? I’d like to compare it with my results, as I’ve experienced lower accept lengths with the released EAGLE-Qwen2 checkpoints.

No, I am still unable to run the EAGLE-2 code branch directly.

I think that gen_ea_alpha_llama2chat.py is not needed in EAGLE-2. In the case of alpha, it is only related to the performance of the draft model that concatenates features and tokens. Therefore, I think we can use the code from EAGLE-1.

EAGLE-Qwen2-7B

I haven't experimented with EAGLE-Qwen2-7B. I am currently only working on LLaMA2-13B-chat.

For question 1, your length-related codes are right, since my implementation is same as yours.
Btw, I'm wondering have you ever evaluated the accept length of author released checkpoints EAGLE-Qwen2-7B-Instruct on mt-bench? I’d like to compare it with my results, as I’ve experienced lower accept lengths with the released EAGLE-Qwen2 checkpoints.

I haven't experimented with EAGLE-Qwen2-7B. I am currently only working on LLaMA2-13B-chat.


Issues with some DiSky syntaxes executed at same time

DiSky version: v4.7.0 (latest)
Skript version: v2.6.4 (latest)
Paper version: 1.16.5-R0.1-SNAPSHOT
Link to debug file: https://pastebin.com/8Sk5sU0k
When executing the same function two times in a row, with differents arguments, but without delay, DiSky syntaxes that require a restaction can cause "trigger" to be cloned, even if it's a function, event, custom effect etc...
Code example:
options:
    bot: test
    id1: message_id_1
    id2: message_id_2
    channel: channel_id_of_messages

function test(n: number):
    set {_bot} to bot named "{@bot}" # Storing bot object
    set {_c} to channel with id "{@channel}" with bot {_bot} # Storing channel object
    if {_n} is 1:
        set {_id} to "{@id1}" # Storing message id 1 for first execution
    if {_n} is 2:
        set {_id} to "{@id2}" # Storing message id 2 for second execution
    retrieve message with id "%{_id}%" from {_c} using bot {_bot} and store it in {_m} # Retrieving message
    edit message {_m} to show "Edit ##%{_n}%" # Editing message with {_n} variable

on load:
    test(1)
    test(2)

With that code, normally, because the variable {_n} is not modified, first message should be edited with text "Edit #1" and the second message "Edit #2", but it's not the case, output in Discord:

Adding log messages helps to better understand the issue: (using skript-reflect for events hashcode)
options:
    bot: test
    id1: message_id_1
    id2: message_id_2
    channel: channel_id_of_messages

function test(n: number):
    broadcast "&aStart %{_n}% - %event.hashCode()%" # NEW: Log message at start of the function
    set {_bot} to bot named "{@bot}" # Storing bot object
    set {_c} to channel with id "{@channel}" with bot {_bot} # Storing channel object
    if {_n} is 1:
        set {_id} to "{@id1}" # Storing message id 1 for first execution
    if {_n} is 2:
        set {_id} to "{@id2}" # Storing message id 2 for second execution
    broadcast "&6Check %{_n}% - %event.hashCode()%" # NEW: Log message before DiSky syntaxes !!!
    retrieve message with id "%{_id}%" from {_c} using bot {_bot} and store it in {_m} # Retrieving message
    edit message {_m} to show "Edit ##%{_n}%" # Editing message with {_n} variable
    broadcast "&cEnd %{_n}% - %event.hashCode()%" # NEW: Log message after DiSky syntaxes
on load:
    test(1)
    test(2)

Log messages contains the {_n} variable and the hashcode of the event, to better see the issue of "trigger" clone.
Output in console of the second code:

You can see that after DiSky syntaxes, the first function has been voided, and is now the second function, having the same {_n} variable, and the same event by looking at hashcode. The first function is a clone of the second, in the code, test(1) only work at the start of the function, but after DiSky syntaxes, test(1) is now test(2). Running the code result in having two times test(2) in the code, but none of test(1).
If DiSky syntaxes are modified with JDA methods (using skript-reflect), the issue is gone, and functions work properly.
For retrieving messages:
    set {_msg} to {_c}.retrieveMessageById("%{_id}%").complete()

For editing messages:
    set {_edit} to new MessageEditBuilder()
    {_edit}.applyCreateData({_msgbuilder}.build())
    {_msg}.editMessage({_edit}.build()).queue()

That's not a bug on DiSky but on Skript: The effect that causes this is the retrieve member.
When managing stuff that JDA or DiSky does not cache, we have to send a new request to Discord's API and wait for its answer.
Thanks to DiSky, all the "request" effects (including editing/retrieving/deleting) are async, which means they run on another Thread to not lock the one Minecraft is running (as waiting for the response would take ms).
Skript's function does not support timings & delays, which means any async effect from DiSky (and from other addons tho) won't make the excepted behavior. The only way to fix that currently is to use skript-reflect's custom syntax, as they do supports timings.

Also, retrieveMessageById is the method that ask the requests to Discord, and you're locking your thread (aka losing lots of performance) using complete on it.


version: Drop build type from version

We only have a single signing key, so this always appends upload to the version name. That's not helpful but it's also causing a problem where the automatically generated Google Play release name is too long.
https://phabricator.endlessm.com/T33465

Looking at the Jenkins output it worked:
[INFO]:    # Add version number to android package
[INFO]:    # Android package renamed to kolibri-debug-0.16.0.dev0+git.20220928203123-a9479b9.apk

Then there is a failure with a Java null pointer exception.

retest this please


Please 2024.1 EAP support

Describe the need of your request
This doesn't work with 2024.1 EAP
Proposed solution
Update
Alternatives you've considered
No response
Additional context
No response

I have solved the issue and it will be available in the next release.


Test failures: "Insecure dependency in require while running with -T switch"

cpanm (App::cpanminus) 1.7001 on perl 5.019009 built for darwin-2level
Work directory is /Users/ether/.cpanm/work/1393210028.14770
You have make /usr/bin/make
You have LWP 6.05
You have /usr/bin/tar: bsdtar 2.6.2 - libarchive 2.6.2
You have /usr/bin/unzip
Checking if you have ExtUtils::MakeMaker 6.31 ... Yes (6.90)
Checking if you have ExtUtils::Install 1.46 ... Yes (1.62)
Searching App::Ack on mirror http://mirrors.gossamer-threads.com/CPAN ...
Downloading index file http://mirrors.gossamer-threads.com/CPAN/modules/02packages.details.txt.gz ...
--> Working on App::Ack
Fetching http://mirrors.gossamer-threads.com/CPAN/authors/id/P/PE/PETDANCE/ack-2.12.tar.gz
-> OK
Unpacking ack-2.12.tar.gz
Entering ack-2.12
Checking configure dependencies from META.json
Checking if you have ExtUtils::MakeMaker 0 ... Yes (6.90)
Configuring ack-2.12
Running Makefile.PL
Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for ack
Writing MYMETA.yml and MYMETA.json
-> OK
Checking dependencies from MYMETA.json ...
Checking if you have Term::ANSIColor 1.10 ... Yes (4.02)
Checking if you have Cwd 3.00 ... Yes (3.47)
Checking if you have File::Spec 3.00 ... Yes (3.47)
Checking if you have File::Basename 1.00015 ... Yes (2.85)
Checking if you have Text::ParseWords 3.1 ... Yes (3.29)
Checking if you have File::Glob 1.00015 ... Yes (1.23)
Checking if you have Pod::Usage 1.26 ... Yes (1.63)
Checking if you have ExtUtils::MakeMaker 0 ... Yes (6.90)
Checking if you have Carp 1.04 ... Yes (1.32)
Checking if you have Getopt::Long 2.35 ... Yes (2.42)
Checking if you have File::Next 1.10 ... Yes (1.12)
Checking if you have Test::Harness 2.50 ... Yes (3.30)
Checking if you have File::Temp 0.19 ... Yes (0.2304)
Checking if you have Test::More 0.98 ... Yes (1.001002)
Building and testing ack-2.12
cp Inverse.pm blib/lib/App/Ack/Filter/Inverse.pm
cp ConfigLoader.pm blib/lib/App/Ack/ConfigLoader.pm
cp Resource.pm blib/lib/App/Ack/Resource.pm
cp Collection.pm blib/lib/App/Ack/Filter/Collection.pm
cp Is.pm blib/lib/App/Ack/Filter/Is.pm
cp Match.pm blib/lib/App/Ack/Filter/Match.pm
cp Extension.pm blib/lib/App/Ack/Filter/Extension.pm
cp Basic.pm blib/lib/App/Ack/Resource/Basic.pm
cp Ack.pm blib/lib/App/Ack.pm
cp IsGroup.pm blib/lib/App/Ack/Filter/IsGroup.pm
cp ConfigDefault.pm blib/lib/App/Ack/ConfigDefault.pm
cp ConfigFinder.pm blib/lib/App/Ack/ConfigFinder.pm
cp Resources.pm blib/lib/App/Ack/Resources.pm
cp Filter.pm blib/lib/App/Ack/Filter.pm
cp Default.pm blib/lib/App/Ack/Filter/Default.pm
cp FirstLineMatch.pm blib/lib/App/Ack/Filter/FirstLineMatch.pm
cp ExtensionGroup.pm blib/lib/App/Ack/Filter/ExtensionGroup.pm
cp ack blib/script/ack
/Users/ether/perl5/perlbrew/perls/19.9/bin/perl5.19.9 -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/ack
Manifying blib/man1/ack.0
/Users/ether/perl5/perlbrew/perls/19.9/bin/perl5.19.9 t/runtests.pl 0 0 "blib/lib" "blib/arch" t/*.t t/lib/*.t
Running tests on blib/script/ack
# Testing App::Ack 2.12, File::Next 1.12, Perl 5.019009, /Users/ether/perl5/perlbrew/perls/19.9/bin/perl5.19.9
# Using Test::More 1.001002 and Test::Harness 3.30
t/00-load.t .................. ok
t/ack-1.t .................... ok
t/ack-c.t .................... ok
t/ack-color.t ................ ok
t/ack-column.t ............... ok
t/ack-create-ackrc.t ......... ok
t/ack-dump.t ................. ok
t/ack-f.t .................... ok
t/ack-files-from.t ........... ok
t/ack-filetypes.t ............ ok
t/ack-g.t .................... ok
t/ack-group.t ................ ok
t/ack-h.t .................... ok
t/ack-help-types.t ........... ok
t/ack-help.t ................. ok
t/ack-i.t .................... ok
t/ack-ignore-dir.t ........... ok
t/ack-interactive.t .......... skipped: You need to install IO::Pty to run this test
t/ack-invalid-ackrc.t ........ skipped: Don't yet have a reliable way to ignore the Unicode complaints from Pod::Perldoc
t/ack-k.t .................... ok
t/ack-known-types.t .......... ok
t/ack-line.t ................. skipped: You need to install IO::Pty to run this test
t/ack-m.t .................... ok
t/ack-match.t ................ ok
t/ack-n.t .................... ok
t/ack-named-pipes.t .......... ok
t/ack-o.t .................... ok
t/ack-pager.t ................ skipped: You need to install IO::Pty to run this test
t/ack-passthru.t ............. ok
t/ack-print0.t ............... ok
t/ack-removed-options.t ...... ok
t/ack-s.t .................... ok
t/ack-show-types.t ........... ok
t/ack-type-del.t ............. ok
t/ack-type.t ................. ok
t/ack-v.t .................... ok
t/ack-w.t .................... ok
t/ack-x.t .................... ok
t/anchored.t ................. ok
t/asp-net-ext.t .............. ok
t/bad-ackrc-opt.t ............ ok
t/basic.t .................... ok
t/command-line-files.t ....... ok
t/config-backwards-compat.t .. ok
t/config-finder.t ............ ok
t/config-loader.t ............ ok
t/context.t .................. ok
t/default-filter.t ........... ok
t/exit-code.t ................ ok
t/ext-filter.t ............... ok
t/file-permission.t .......... ok
t/filetypes.t ................ ok
t/filter.t ................... ok
t/firstlinematch-filter.t .... ok
t/highlighting.t ............. ok
t/illegal-regex.t ............ ok
t/incomplete-last-line.t ..... ok
t/inverted-file-filter.t ..... ok
t/is-filter.t ................ ok
t/lib/00-coverage.t .......... ok
t/lib/Ack.t .................. ok
t/lib/Basic.t ................ ok
t/lib/Collection.t ........... ok
t/lib/ConfigDefault.t ........ ok
t/lib/ConfigFinder.t ......... ok
t/lib/ConfigLoader.t ......... ok
t/lib/Default.t .............. ok
t/lib/Extension.t ............ ok
t/lib/ExtensionGroup.t ....... ok
t/lib/Filter.t ............... ok
t/lib/FirstLineMatch.t ....... ok
Insecure dependency in require while running with -T switch at /Users/ether/perl5/perlbrew/perls/19.9/lib/5.19.9/base.pm line 101.
        ...propagated at /Users/ether/perl5/perlbrew/perls/19.9/lib/5.19.9/base.pm line 110.
BEGIN failed--compilation aborted at /Users/ether/.cpanm/work/1393210028.14770/ack-2.12/blib/lib/App/Ack/Filter/Inverse.pm line 5.
Compilation failed in require at t/lib/Inverse.t line 8.
BEGIN failed--compilation aborted at t/lib/Inverse.t line 8.
# Looks like your test exited with 255 before it could output anything.
t/lib/Inverse.t ..............
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/1 subtests
t/lib/Is.t ................... ok
Insecure dependency in require while running with -T switch at /Users/ether/perl5/perlbrew/perls/19.9/lib/5.19.9/base.pm line 101.
        ...propagated at /Users/ether/perl5/perlbrew/perls/19.9/lib/5.19.9/base.pm line 110.
BEGIN failed--compilation aborted at /Users/ether/.cpanm/work/1393210028.14770/ack-2.12/blib/lib/App/Ack/Filter/IsGroup.pm line 5.
Compilation failed in require at t/lib/IsGroup.t line 8.
BEGIN failed--compilation aborted at t/lib/IsGroup.t line 8.
# Looks like your test exited with 255 before it could output anything.
t/lib/IsGroup.t ..............
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/1 subtests
t/lib/Match.t ................ ok
t/lib/Resource.t ............. ok
t/lib/Resources.t ............ ok
t/longopts.t ................. ok
t/match-filter.t ............. ok
t/mutex-options.t ............ ok
t/noackrc.t .................. ok
t/noenv.t .................... ok
t/process-substitution.t ..... ok
t/r-lang-ext.t ............... ok
t/resource-iterator.t ........ ok
t/zero.t ..................... ok

Test Summary Report
-------------------
t/lib/Inverse.t            (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 1 tests but ran 0.
t/lib/IsGroup.t            (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 1 tests but ran 0.
Files=86, Tests=908, 66 wallclock secs ( 0.66 usr  0.27 sys + 55.88 cusr  9.67 csys = 66.48 CPU)
Result: FAIL
Failed 2/86 test programs. 0/908 subtests failed.
make: *** [test_classic] Error 255
-> FAIL Installing App::Ack failed. See /Users/ether/.cpanm/work/1393210028.14770/build.log for details. Retry with --force to force install it.

@karenetheridge Is this still happening in 2.16?

It looks like this got fixed somewhere between 2.12 and 2.14. thanks!


Add nrf52 team as nrf52810-hal owner

CC @hannobraun, could you please add the nrf-rs/nrf52 team as an owner for the nrf52810 crate? Right now you are the only owner.
Edit: On crates.io. You can do this by running the following command from within the crate locally:
cargo owner --add github:nrf-rs:nrf52

Added the team as owner. Sorry for the oversight.


Specify explicit PostgreSQL version in roles

In roles that install the postgresql-client package, specify the package name for the specific PostgreSQL version.  We use the apt.postgresql.org repository, which gives you version 9.5 if you specify the apt metapackage "postgresql-client".  We need version 9.4.
It would be nice to specify the pg_version constant in only one place, but there's no convenient place to do that outside of vars/main.yml in each relevant role.

@markbreedlove do we need to create a task to uninstall the current version? If 9.5 was previously installed this doesn't seem to removed it and I assumed it would continue to be used if both postgres-client-9.4 and postgres-client-9.5 are installed.

I'll check to see what should be done about version 9.1, which we used to install, but we shouldn't have to uninstall version 9.5. The only reason 9.5 was on our own servers was because I was experimenting with it. I don't think I had automation set to install it, so it was just my own problem.

Okay, it was showing up in my local VMs and it didn't seem to be cause any issues. I didn't check the production or staging postgres envs.
I think this should be 👍 if there isn't a problem w/other versions

In that case, if you had it in your local VMs, then I may be forgetting something. I'll check the automation commit history to see if I had it installing in the past.

I've made an oversight, and will close this PR.
It is OK for the postgresql-client to be at version 9.5, according to the pg_wrapper script, which /usr/bin/psql symlinks to: https://alioth.debian.org/scm/loggerhead/pkg-postgresql/postgresql-common/trunk/revision/1216
Please ignore my confusion about uninstalling 9.1 or 9.5. The presence of the client package is unrelated to my experimentation in development with the 9.5 server package.


Custom boolean deserialization

Hello,
I am facing the deserialization of an Edifact document into a POCO object:
The edifact messages I have to deserialize include some boolean values defined in a format that cannot directly be parsed using the boolean.TryParse method. This fields can for example include yes, no or y, n, or even its equivalent in other languages.
Currently I solved the problem creating a custom struct with a Parse method (like in your DMPeriod example) where I put my custom parsing logic.
I don't quite like this solution as I would rather have boolean fields in my model, that are directly deserialized from the edifact document.
A possible solution would be to be somehow be able to define some special converters like you can do in Json.Net. Is this supported by Edi.Net in any way? Or do you have a better suggestion on how to solve this problem?
I'm facing a similar problem with DateTime fields, as my DateTime values can come in several formats for the same field, so I cannot use the standard Format parameter of the EdiValue attribute.
Thank you in advance.

Off of the top of my head I can think of two additional ways

first a second property (not mapped) like the following.

        [EdiValue("9(1)", Path = "DTM/0/1")]
        public string BooleanText
        {
              get { return Boolean ? "yes" : "no"; }
              set { Boolean = value == "yes"; }
        }

        public bool Boolean { get; set; }

Create an enum with Yes and No or y n as possible values. This actually my be better that option 1
Consider custom type converters as an attribute. The ConvertUtils support it already because it is ported from JsonNet but I would have to check it out because I might not be using it :-) . This is something that will have to wait for a future release.

The first option would work but I don't quite like having an extra property for each of the boolean fields in my model.
In the second point, you mean also having the extra field but of Type enum instead of string, am I right?
The custom type converters would be a much more interesting and flexible option, could you provide me with some more information on how would that fit into the current library implementation? I would be happy to contribute with a PR if you agree.


[Chore]: Get rid of integration tests for the /v3/spaces endpoints

Background
In order to simplify our testing strategy, we want to get rid of envtest-based integration tests for our handlers.
Action to take

Make sure that all paths tested by api/apis/integration/apply_manifest_test.go are covered by our unit tests in api/apis/space_manifest_handler_test.go and api/actions/apply_manifest_test.go.
Remove api/apis/integration/apply_manifest_test.go.

Impact

Make our unit tests comprehensive
Reduce overlap in our tests and thus cost of maintenance

@danail-branekov I think this one is obsolete as the respective file already got removed by you within https://github.com/cloudfoundry/korifi/pull/1612

Thanks for the heads up, closing


field-by-field metadata help

As a metadata specialist,
I would like to be able to get reminders of metadata policies and procedures for the field I am working on,
so I can supply the correct metadata without consulting a lot of external documents.

@lmballinger can you be more specific about what is intended by "reminders of metadata policies and procedures"? Tooltips? Field validation? Links to documentation? Auto-suggest?


Plans to support MQTT 5?

Are there any plans to support the latest specification version 5?

Yes
I'm working on it, in my spare time.
Andrea
On Tue, Jul 23, 2019 at 8:57 AM mpe85<EMAIL_ADDRESS>wrote:

Are there any plans to support the latest specification version 5?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/moquette-io/moquette/issues/490?email_source=notifications&email_token=AAH5RULSU5MYI3ASVS4FETTQA2TWFA5CNFSM4IGAUTOKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HA2ZNLQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAH5RULZOSLBDZAXBJOW673QA2TWFANCNFSM4IGAUTOA
.

Thats great to hear :-)
Thanks for the quick answer.

Your're welcome,
but the implementation will take time;-)
Andrea
On Tue, Jul 23, 2019 at 9:06 AM mpe85<EMAIL_ADDRESS>wrote:

Thats great to hear :-)
Thanks for the quick answer.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/moquette-io/moquette/issues/490?email_source=notifications&email_token=AAH5RUIY2SGOD3RP6TA2XALQA2UWTA5CNFSM4IGAUTOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2SELWI#issuecomment-514082265,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAH5RUK5SNWNBPUWJOMKXLTQA2UWTANCNFSM4IGAUTOA
.

Hello Andsel, is it supporting mqtt v5 ?

Hi  Muhammad
not at the moment, it's still work in progress.
Andrea
On Fri, Sep 20, 2019 at 1:48 PM Muhammad Mattiullah <
<EMAIL_ADDRESS>wrote:

Hello Andsel, is it supporting mqtt v5 ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/moquette-io/moquette/issues/490?email_source=notifications&email_token=AAH5RUKESDF2GDSBPBPJWF3QKS2BZA5CNFSM4IGAUTOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7GOCYI#issuecomment-533520737,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAH5RUKZIRJYE5KAAFJKX23QKS2BZANCNFSM4IGAUTOA
.

Thanks for the quick response.
Regards

Any update on this? looking for MQTT 5 asap.

@keshavck not yet

Any other workaround? like any adapters to mqtt 3 to mqtt 5?

Any other workaround?

Nothing I'm aware off, simply use MQTT 3.1.1  client to connect to Moquette

like any adapters to mqtt 3 to mqtt 5?

There could be something, but never tried. It's out of the project's scope

I close this because created #695 to shape the work to be done to support MQTT v5


Connected lists

Is there a way to drag items from one list to another?

Not currently. I may look into implementing a DropTarget higher order component, but that's a bit out of scope at the moment. If that's the kind of functionality you're looking for, you should perhaps try react-dnd

@clauderic I was thinking about functionality similar to https://github.com/RubaXa/Sortable
It allows to have connected lists. React-dnd is not the best option.

@slmgc One way I wonder if this would work is if you fake the two separate lists as one list with a divider but I imagine that would work only for very limited cases.. Sortable library does look cool!

This library seems great! We use react dnd largely for firing actions when dragging between and over lists. For example, imagine dragging a school activity up and down to sort within the activity's list, or further down to drop into a different activity group, or across the screen to drop onto a group of students to assign them that activity. But a few of our lists would really benefit from react-virtualized and, from a quick glance, integrating dnd with virtualized seems like it might get ugly. I know this case is sort of what react-dnd is designed for, but I wonder how much of it can be handled with a lighter weight drop target HOC for react-sortable-hoc.

@slmgc @nperichSYKES I'm curious where did you guys end up here? Did you end up with a solution for connected lists using this library or another?

@oyeanuj I used https://github.com/RubaXa/Sortable. My implementation with connected lists is about 100 LoC.

@slmgc Thanks! Possible to share a gist of that implementation to get a sense of how it works?

@oyeanuj I'm currently working on another project, but I'll try to find my implementation

So close, but without this feature, so far. Great job all around though, thanks!

This would be a great feature.  Currently our app requires this and is using this module at present.  Any update on this?  Great work so far!

I have a basic working version that uses two vertical lists. It has one additional class to handle the swap logic and zero code changes to the current react-sortable-hoc classes.

@jdbence That looks smooth, I am very curious about your approach. I have a somewhat working version as well which requires using two different collections and then returns the new collection as well as index at the drop place.
Do you have a branch/fork where I can look at your implementation? And/or a PR coming up for this?

@oyeanuj  It will come as a PR in the next week or so. This implementation uses a callback returning old and new list information (index & list) of the dragged item. Events are handled on move and on drop.

You can checkout the PR #138  I haven't tested on touch devices.

For those waiting on this, you should also check out react-beautiful-dnd. They seem pretty close to implementing this feature

This just landed in react-beautiful-dnd

I put together some code from a few users that I started working on, and adding some other features:
https://github.com/reactual/react-multi-sortable-hoc-demo

Any news?


Failed mainnet txs: EntryPointSelector not found in contract

Extracted logs from #1244
13:11:24.720 16/06/2023 +03:00	INFO	sync/sync.go:176	Failed executing	{"txnHash": "0xbb1b8d23b44e104094504381b0a05dd91b71050ef7082e9d0f4c1a60d31d52", "err": "ValidateTransactionError(VirtualMachineExecutionErrorWithTrace { trace: \"Error in the called contract (0x04fa183fcec3b11d949a2a06f2006c639543f7106ea638177393a3d8699a4e8a):\\nError at pc=0:12:\\nGot an exception while executing a hint: Custom Hint Error: Entry point EntryPointSelector(StarkFelt(\\\"0x0162da33a4585851fe8d3af3c2a9c60b557814e221e0d4f30ff0b2189d9c7775\\\")) not found in contract.\\nCairo traceback (most recent call last):\\nUnknown location (pc=0:161)\\nUnknown location (pc=0:147)\\n\", source: CairoRunError(VmException(VmException { pc: 12, inst_location: None, inner_exc: Hint((0, CustomHint(\"Entry point EntryPointSelector(StarkFelt(\\\"0x0162da33a4585851fe8d3af3c2a9c60b557814e221e0d4f30ff0b2189d9c7775\\\")) not found in contract.\"))), error_attr_value: None, traceback: Some(\"Cairo traceback (most recent call last):\\nUnknown location (pc=0:161)\\nUnknown location (pc=0:147)\\n\") })) })"}
13:33:26.587 16/06/2023 +03:00	INFO	sync/sync.go:176	Failed executing	{"txnHash": "0x4fe685c7263eabf8dbe7e5214e6b8cae56a2b83d7981deb82e44da93dd1e970", "err": "ValidateTransactionError(VirtualMachineExecutionErrorWithTrace { trace: \"Error in the called contract (0x069f0c7a4cea2b2ce650c46511f40f6772039a440234d22bae28847224072307):\\nError at pc=0:12:\\nGot an exception while executing a hint: Custom Hint Error: Entry point EntryPointSelector(StarkFelt(\\\"0x0162da33a4585851fe8d3af3c2a9c60b557814e221e0d4f30ff0b2189d9c7775\\\")) not found in contract.\\nCairo traceback (most recent call last):\\nUnknown location (pc=0:161)\\nUnknown location (pc=0:147)\\n\", source: CairoRunError(VmException(VmException { pc: 12, inst_location: None, inner_exc: Hint((0, CustomHint(\"Entry point EntryPointSelector(StarkFelt(\\\"0x0162da33a4585851fe8d3af3c2a9c60b557814e221e0d4f30ff0b2189d9c7775\\\")) not found in contract.\"))), error_attr_value: None, traceback: Some(\"Cairo traceback (most recent call last):\\nUnknown location (pc=0:161)\\nUnknown location (pc=0:147)\\n\") })) })"}

The important part:
Custom Hint Error: Entry point EntryPointSelector(StarkFelt("<num>")) not found in contract.
With <num> == 0x0162da33a4585851fe8d3af3c2a9c60b557814e221e0d4f30ff0b2189d9c7775 in both cases. It happens in contracts 0x069f0c7a4cea2b2ce650c46511f40f6772039a440234d22bae28847224072307 and 0x04fa183fcec3b11d949a2a06f2006c639543f7106ea638177393a3d8699a4e8a.

This error do not correspond to a cairo-rs error


ansibleserver: 操作宿主机时默认使用用户root

这个 PR 实现什么功能/修复什么问题:
ansibleserver: 操作宿主机时默认使用用户root
是否需要 backport 到之前的 release 分支:

release/2.10.0

/area region
/cc @swordqiu @Zexi

Codecov Report

Merging #2089 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #2089      +/-   ##
=========================================
+ Coverage    7.16%   7.18%   +0.02%
=========================================
  Files         445     445
  Lines       69418   69418
=========================================
+ Hits         4971    4985      +14
+ Misses      64033   64021      -12
+ Partials      414     412       -2

Flag
Coverage Δ

#aFlag
7.18% <ø> (+0.02%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/util/rbacutils/rbac.go
74.3% <0%> (+4.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be65337...e813eb5. Read the comment docs.

/lgtm

/approve


Change the variant of the move node buttons

Suggest that the variant of the cell movement buttons not be "contained" and should be same as < ScaleButton /> and other buttons to match the same UI. They needless take away visual focus from other important controls.
Also, as per Material guidelines, since these are not the main actions on the taskbar they should not be "contained" anyway.

Suggest that the variant of the cell movement buttons not be "contained" and should be same as < ScaleButton /> and other buttons to match the same UI. They needless take away visual focus from other important controls.
Also, as per Material guidelines, since these are not the main actions on the taskbar they should not be "contained" anyway.

i agree with you, they take away too much visual focus as they are not that important.

Any chance this can make it way into the next release?

:tada: This issue has been resolved in version 4.10.0 :tada:
The release is available on:

v4.10.0
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.10.0-beta.3 :tada:
The release is available on:

v4.10.0-beta.3
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.11.0-beta.1 :tada:
The release is available on:

v4.11.0-beta.1
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.11.0 :tada:
The release is available on:

v4.11.0
GitHub release

Your semantic-release bot :package::rocket:


Why does all_padding test produce a synthesis error?

when there are no mpt updates, if the padding row assigments (assignments where global offset > 0) and 0 row assignments (assignments where global offset == 0) don't have an overlapping column, i think that the halo2 parallel layouter causes the regions to overlap, which produces a synthesis error? Is this working as intened?

this is by design.


not create the useless degree table in table catalog

the useless internal degree table is generated and store in the table catalog. They will never be used and no data in that. But it an be found by show internal tables.
dev=> create table t1(v1 int);
CREATE_TABLE
dev=> create table t2(v2 int);
CREATE_TABLE
dev=> create materialized view mv as select * from t1 join t2 on v1 = v2;
CREATE_MATERIALIZED_VIEW
dev=> insert into t1 values (1), (2);
INSERT 0 2
dev=> insert into t2 values (1), (2);
INSERT 0 2
dev=> show internal tables;
                   Name
------------------------------------------
 __internal_mv_5_hashjoinright_1006
 __internal_mv_5_hashjoindegreeright_1007
 __internal_mv_5_hashjoinleft_1004
 __internal_mv_5_hashjoindegreeleft_1005
(4 rows)
dev=> select 't2.v2' from __internal_mv_5_hashjoindegreeright_1007;
 ?column?
----------
(0 rows)

Sounds reasonable, but I don't feel like there's much to gain. Should the frontend understand all possible optimization the executor may do, and always keep it up-to-date? 🤔


Move NodeJS apps (RTL, BTC-RPC-Explorer) under an unpriviliged user from admin

This is to improve security by stopping the wealth of dependencies from having sudo access.

merged into v1.5 - still needed testing before release

Its working - closing issue.


asterisk: Bump all packages

Motivation for this change
Security update: https://issues.asterisk.org/jira/browse/ASTERISK-29057
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Backported in 875bcac79d4447ac8f3c5f041cce8520cafb79ed.
I tested the backport by building .#asterisk .#asterisk-lts .#asterisk-stable .#asterisk_13 .#asterisk_16 .#asterisk_17.
@dasJ could you please include version numbers into the commit message? You could split it into several commits or do something like asterisk: 13.37.1 -> 13.38.0, 16.14.1 -> 16.15.0, .... That makes maintaining backports much easier, compared to finding the right commit in a list of asterisk: Bump all packages.

Backported in 875bcac79d4447ac8f3c5f041cce8520cafb79ed.
I tested the backport by building .#asterisk .#asterisk-lts .#asterisk-stable .#asterisk_13 .#asterisk_16 .#asterisk_17.
@dasJ could you please include version numbers into the commit message? You could split it into several commits or do something like asterisk: 13.37.1 -> 13.38.0, 16.14.1 -> 16.15.0, .... That makes maintaining backports much easier, compared to finding the right commit in a list of asterisk: Bump all packages.


Fix the mapping of the prison name in the AssignedLivingUnit

@brownbearsoftware could you re-approve this please (I failed to update the integration tests first time round!)