Icon not showing when <=10% battery

Pretty self explanatory.

Logs

👾 Battery CLI logs:
05/07/24-10:53:54 - 🔌🪫 Disabling battery charging
05/07/24-10:53:54 - 💡 Setting magsafe color to green
05/07/24-13:31:20 - Charge below 80
05/07/24-13:31:20 - 🔌🔋 Enabling battery charging
05/07/24-13:31:20 - 🔼🪫 Disabling battery discharging
05/07/24-13:31:21 - 💡 Setting magsafe color to orange
05/09/24-20:19:35 - Not triggering discharge as it is not requested
05/09/24-20:19:35 - Charging to and maintaining at 80% from 14%
05/09/24-20:19:35 - Charge below 80
05/09/24-20:19:35 - 🔌🔋 Enabling battery charging
05/09/24-20:19:35 - 🔼🪫 Disabling battery discharging
05/09/24-20:19:35 - 💡 Setting magsafe color to orange
05/09/24-22:46:58 - Not triggering discharge as it is not requested
05/09/24-22:46:58 - Charging to and maintaining at 80% from 26%
05/09/24-22:46:58 - Charge below 80
05/09/24-22:46:58 - 🔌🔋 Enabling battery charging
05/09/24-22:46:58 - 🔼🪫 Disabling battery discharging
05/09/24-22:46:58 - 💡 Setting magsafe color to orange
05/10/24-20:55:54 - Not triggering discharge as it is not requested
05/10/24-20:55:54 - Charging to and maintaining at 80% from 15%
05/10/24-20:55:54 - Charge below 80
05/10/24-20:55:54 - 🔌🔋 Enabling battery charging
05/10/24-20:55:54 - 🔼🪫 Disabling battery discharging
05/10/24-20:55:54 - 💡 Setting magsafe color to orange
05/10/24-21:39:56 - Charge above 80
05/10/24-21:39:56 - 🔌🪫 Disabling battery charging
05/10/24-21:39:56 - 💡 Setting magsafe color to green
05/12/24-18:46:03 - Not triggering discharge as it is not requested
05/12/24-18:46:03 - Charging to and maintaining at 80% from 14%
05/12/24-18:46:03 - Charge below 80
05/12/24-18:46:03 - 🔌🔋 Enabling battery charging
05/12/24-18:46:03 - 🔼🪫 Disabling battery discharging
05/12/24-18:46:03 - 💡 Setting magsafe color to orange
05/12/24-19:31:05 - Charge above 80
05/12/24-19:31:05 - 🔌🪫 Disabling battery charging
05/12/24-19:31:05 - 💡 Setting magsafe color to green
05/15/24-15:00:33 - Not triggering discharge as it is not requested
05/15/24-15:00:33 - Charging to and maintaining at 80% from 16%
05/15/24-15:00:33 - Charge below 80
05/15/24-15:00:33 - 🔌🔋 Enabling battery charging
05/15/24-15:00:33 - 🔼🪫 Disabling battery discharging
05/15/24-15:00:33 - 💡 Setting magsafe color to orange
05/15/24-15:46:35 - Charge above 80
05/15/24-15:46:35 - 🔌🪫 Disabling battery charging
05/15/24-15:46:35 - 💡 Setting magsafe color to green
05/17/24-12:09:28 - Not triggering discharge as it is not requested
05/17/24-12:09:28 - Charging to and maintaining at 80% from 19%
05/17/24-12:09:28 - Charge below 80
05/17/24-12:09:28 - 🔌🔋 Enabling battery charging
05/17/24-12:09:28 - 🔼🪫 Disabling battery discharging
05/17/24-12:09:28 - 💡 Setting magsafe color to orange
05/17/24-12:54:30 - Charge above 80
05/17/24-12:54:30 - 🔌🪫 Disabling battery charging
05/17/24-12:54:30 - 💡 Setting magsafe color to green
05/17/24-14:39:43 - Charge below 80
05/17/24-14:39:43 - 🔌🔋 Enabling battery charging
05/17/24-14:39:43 - 🔼🪫 Disabling battery discharging
05/17/24-14:39:43 - 💡 Setting magsafe color to orange
05/22/24-12:28:08 - Not triggering discharge as it is not requested
05/22/24-12:28:08 - Charging to and maintaining at 80% from 20%
05/22/24-12:28:08 - Charge below 80
05/22/24-12:28:08 - 🔌🔋 Enabling battery charging
05/22/24-12:28:08 - 🔼🪫 Disabling battery discharging
05/22/24-12:28:08 - 💡 Setting magsafe color to orange
05/23/24-18:07:31 - Not triggering discharge as it is not requested
05/23/24-18:07:31 - Charging to and maintaining at 80% from 15%
05/23/24-18:07:31 - Charge below 80
05/23/24-18:07:31 - 🔌🔋 Enabling battery charging
05/23/24-18:07:32 - 🔼🪫 Disabling battery discharging
05/23/24-18:07:32 - 💡 Setting magsafe color to orange
05/23/24-18:55:34 - Charge above 80
05/23/24-18:55:34 - 🔌🪫 Disabling battery charging
05/23/24-18:55:34 - 💡 Setting magsafe color to green
05/26/24-00:45:30 - Not triggering discharge as it is not requested
05/26/24-00:45:30 - Charging to and maintaining at 80% from 13%
05/26/24-00:45:30 - Charge below 80
05/26/24-00:45:30 - 🔌🔋 Enabling battery charging
05/26/24-00:45:30 - 🔼🪫 Disabling battery discharging
05/26/24-00:45:30 - 💡 Setting magsafe color to orange
05/26/24-00:58:58 - Not triggering discharge as it is not requested
05/26/24-00:58:58 - Charging to and maintaining at 80% from 34%
05/26/24-19:35:28 - Not triggering discharge as it is not requested
05/26/24-19:35:28 - Charging to and maintaining at 80% from 15%
05/26/24-19:35:28 - Charge below 80
05/26/24-19:35:28 - 🔌🔋 Enabling battery charging
05/26/24-19:35:28 - 🔼🪫 Disabling battery discharging
05/26/24-19:35:28 - 💡 Setting magsafe color to orange
05/26/24-20:20:30 - Charge above 80
05/26/24-20:20:30 - 🔌🪫 Disabling battery charging
05/26/24-20:20:30 - 💡 Setting magsafe color to green
05/27/24-05:32:53 - Charge below 80
05/27/24-05:32:53 - 🔌🔋 Enabling battery charging
05/27/24-05:32:53 - 🔼🪫 Disabling battery discharging
05/27/24-05:32:53 - 💡 Setting magsafe color to orange
05/28/24-21:47:57 - Not triggering discharge as it is not requested
05/28/24-21:47:57 - Charging to and maintaining at 80% from Early%
05/28/24-21:47:57 - Charge below 80
05/28/24-21:47:57 - 🔌🔋 Enabling battery charging
05/28/24-21:47:57 - 🔼🪫 Disabling battery discharging
05/28/24-21:47:57 - 💡 Setting magsafe color to orange
🖥  Battery GUI logs:
Refreshing tray icon...
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status_csv
Battery status:
{"percentage":"12","remaining":"unknown","charging":true,"discharging":false,"maintain_percentage":"80","battery_state":"12% (unknown remaining)","daemon_state":"smc charging enabled"}
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status
Limiter status message:
05/28/24-21:50:04 - Battery at 12% ((no remaining), smc charging enabled
05/28/24-21:50:04 - Your battery is currently being maintained at 80%
Display percentage 10 based on 12
Found image: /Applications/battery.app/Contents/Resources/battery-active-10-Template.png
Resetting interface timer speed
Refreshing interface update timer
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status_csv
Get active logo for 12
Force discharge setting: undefined undefined
Generate app menu percentage: 12 (discharge disallowed, limited on)
Battery status:
{"percentage":"12","remaining":"unknown","charging":true,"discharging":false,"maintain_percentage":"80","battery_state":"12% (unknown remaining)","daemon_state":"smc charging enabled"}
Setting interface refresh speed to 0.5 minutes
Refreshing tray icon...
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status_csv
Battery status:
{"percentage":"12","remaining":"unknown","charging":true,"discharging":false,"maintain_percentage":"80","battery_state":"12% (unknown remaining)","daemon_state":"smc charging enabled"}
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status
Limiter status message:
05/28/24-21:50:34 - Battery at 12% ((no remaining), smc charging enabled
05/28/24-21:50:34 - Your battery is currently being maintained at 80%
Get active logo for 12
Generate app menu percentage: 12 (discharge disallowed, limited on)
Refreshing interface update timer
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status_csv
Found image: /Applications/battery.app/Contents/Resources/battery-active-10-Template.png
Force discharge setting: undefined undefined
Resetting interface timer speed
Display percentage 10 based on 12
Battery status:
{"percentage":"12","remaining":"unknown","charging":true,"discharging":false,"maintain_percentage":"80","battery_state":"12% (unknown remaining)","daemon_state":"smc charging enabled"}
Setting interface refresh speed to 0.5 minutes
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status_csv
Refreshing tray icon...
Battery status:
{"percentage":"14","remaining":"1:43","charging":true,"discharging":false,"maintain_percentage":"80","battery_state":"14% (1:43 remaining)","daemon_state":"smc charging enabled"}
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status
Limiter status message:
05/28/24-21:51:04 - Battery at 14% (1:43 remaining), smc charging enabled
05/28/24-21:51:04 - Your battery is currently being maintained at 80%
Display percentage 10 based on 14
Found image: /Applications/battery.app/Contents/Resources/battery-active-10-Template.png
Resetting interface timer speed
Refreshing interface update timer
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status_csv
Get active logo for 14
Force discharge setting: undefined undefined
Generate app menu percentage: 14 (discharge disallowed, limited on)
Battery status:
{"percentage":"14","remaining":"1:43","charging":true,"discharging":false,"maintain_percentage":"80","battery_state":"14% (1:43 remaining)","daemon_state":"smc charging enabled"}
Setting interface refresh speed to 0.5 minutes
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status_csv
Refreshing tray icon...
Battery status:
{"percentage":"14","remaining":"1:43","charging":true,"discharging":false,"maintain_percentage":"80","battery_state":"14% (1:43 remaining)","daemon_state":"smc charging enabled"}
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status
Limiter status message:
05/28/24-21:51:34 - Battery at 14% (1:43 remaining), smc charging enabled
05/28/24-21:51:34 - Your battery is currently being maintained at 80%
Get active logo for 14
Found image: /Applications/battery.app/Contents/Resources/battery-active-10-Template.png
Resetting interface timer speed
Refreshing interface update timer
Force discharge setting: undefined undefined
Display percentage 10 based on 14
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status_csv
Generate app menu percentage: 14 (discharge disallowed, limited on)
Battery status:
{"percentage":"14","remaining":"1:43","charging":true,"discharging":false,"maintain_percentage":"80","battery_state":"14% (1:43 remaining)","daemon_state":"smc charging enabled"}
Setting interface refresh speed to 0.5 minutes
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status_csv
Refreshing tray icon...
Battery status:
{"percentage":"16","remaining":"1:41","charging":true,"discharging":false,"maintain_percentage":"80","battery_state":"16% (1:41 remaining)","daemon_state":"smc charging enabled"}
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status
Limiter status message:
05/28/24-21:52:05 - Battery at 16% (1:41 remaining), smc charging enabled
05/28/24-21:52:05 - Your battery is currently being maintained at 80%
Found image: /Applications/battery.app/Contents/Resources/battery-active-15-Template.png
Resetting interface timer speed
Generate app menu percentage: 16 (discharge disallowed, limited on)
Force discharge setting: undefined undefined
Get active logo for 16
Refreshing interface update timer
Display percentage 15 based on 16
Executing PATH=/bin:/usr/bin:/usr/local/bin:/usr/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/opt/homebrew battery status_csv
Battery status:
{"percentage":"16","remaining":"1:41","charging":true,"discharging":false,"maintain_percentage":"80","battery_state":"16% (1:41 remaining)","daemon_state":"smc charging enabled"}
Setting interface refresh speed to 0.5 minutes
📁 Config folder details:
total 392896
drwxr-xr-x@  6 jakjakob  staff   192B May 28 21:47 .
drwxr-x---+ 50 jakjakob  staff   1.6K May 28 21:52 ..
-rwxr-xr-x@  1 jakjakob  staff   227K May 28 21:52 battery.log
-rw-r--r--   1 jakjakob  staff     6B May 28 21:47 battery.pid
-rw-r--r--@  1 jakjakob  staff   177M May 28 21:52 gui.log
-rw-r--r--@  1 jakjakob  staff     3B May 28 21:47 maintain.percentage
⚙  Battery data:
05/28/24-21:52:05 - Battery at 16% (1:41 remaining), smc charging enabled
05/28/24-21:52:05 - Your battery is currently being maintained at 80%
Battery CLI utility v1.1.6

Update: the cause seems not to be valid, as rn at under 10% it shows up. Maybe only at 10% (it happened also)? But when charging, it shows it…


Task: make a request with the Metriq API, via the client

Like we spoke about in the meeting today, while logged into Metriq, go to the "API Token" item under the "Account menu." Generate (and save securely) your API token. Use this as the argument to create a MetriqClient() class instance in this script:
https://github.com/unitaryfund/metriq-client/blob/development/examples/metriq_hello.py
Make sure that you can successfully connect to the production environment API, with that script. Both assignees, either together or separately, please make sure you can make a successful authenticated request, that way. (You'll get some kind of single-line response message string.)

Commenting for assignment

commenting for assignment


[WIP] Expand multiplication methods

Currently implements karatusba and schoolbook based on num-bigint-dig.

Karatsuba was added in #649


Question: generate using only openpose

in vid2vid if, the source video is on white background (as much of dance videos) resulting image is overburn (no any antiburn tricks works) , is it possible (making sense?) to ignore all video image and just send it to openpose preprocessor and render based just on detected poses, or poses and prev frame of rendered, but not original at all ?  Shorter question - can we ignore original video gamma ?

so we need a checkbox like "use only controlnet" ? I lame in python, but may be can try to implement it,

@zba thanks for being as attentive to our requests as you have been and are, I've seen so many popular extensions fall by the wayside and it's awesome what you're doing.
Worlds above any of the other _to_video extensions projects out there!

Now I decided to use this extension, and it seems to me that it is really important to add a checkbox like "use only controlnet", because the tile is not always suitable for the request/prompt


Use examples object from open-api spec

Generating responses from api-spec Example-Objects would be a great feature that fits well with the projects philosophy of being contract driven. This project demonstrates the feature microcks whereby request examples are also mapped to request responses.
I would imagine the order of matching requests could be:

static mapping under data directory
example objects in api-spec
default to randomly generated responses

Thanks for reaching out to us @bobjana.
We do support examples in specs.
Could you please elaborate a bit on what do you exactly expect mean by 'generating responses from example objects' ?
Do you expect the responses to be generated while running contract tests or while using the stub?

Hello guys, sorry to bring back this issue from the dead but we ran into a similar usecase, that would be cool if the requests & responses examples from the OpenAPI spec could be used as stubs !
I think Specmatic ignores the responses examples currently:

When Testing, we only match on the ResponsePattern but the content doesn't matter, if i have a response example with a concrete value, Specmatic checks if the response matches the Pattern but if it's not the same exact value, the test will not fail.

When Stubbing, i don't think stubs are being created from the examples at all currently

So yeah, being able to just fire up a stub from the OpenAPI examples (both requests & response) would be very valuable because, examples baked-in the openAPI are basically provider approved mocks !)

@aeoncl Thanks for bumping this up. We will get back to you on this shortly.


Loading CSV fails

∂
Summary of Bug

I'm using the MC2 client to upload this CSV file:
"marketplace","customer_id","review_id","product_id","product_parent","product_title","product_category","star_rating","helpful_votes","total_votes","vine","verified_purchase","review_headline","review_body","review_date"
"US","12322955","R3AU7UWXDP6KF3","1567921213","475969704","Unbroken Circles: The Campground of Martha's Vineyard (An Imago Mundi Book)","Books","5","0","0","N","N","The Campground of Martha's Vineyard","L chose this book because it was featured on a trip to Martha's Vineyard and I love the photograph in it.","2005-10-13"

Schema:
marketplace:string,customer_id:string,review_id:string,product_id:string,product_parent:string,product_title:string,star_rating:string,helpful_votes:string,total_votes:integer,vine:string,verified_purchase:string,review_headline:string,review_body:string,review_date:string

And got this error:
root@b4ed88eecd9b:/mc2/client# mc2 upload
terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
Aborted (core dumped)

Could you point me to the CSV loading code or help me figure out what's wrong? Alternatively, is there a different format I can upload my data in? (e.g. parquet?)
Version

master
Steps to Reproduce

Sorry, the module I was referring to is in https://github.com/mc2-project/mc2/blob/master/src/io.cpp. Will open an issue there.


Add the solvers for the equMPC formulation

This includes the ADMM and the FISTA solvers.

The ADMM-based solver was added in f49a797bef01746b78999cf0137d7582af096e61.

The ADMM-bases solver was not correctly coded. It is now fixed and working as of 2f1279d6013b5bda60f495ab1719a7f13762bbe1.

The FISTA-based solver has been added in f9b129c92713224eb7b36f22f0631472acaa998f, thus solving this issue.


How to specify a logger from the cli?

System Info
Copy-and-paste the text below in your GitHub issue

- `Accelerate` version: 0.16.0
- Platform: Linux-5.19.0-31-generic-x86_64-with-glibc2.36
- Python version: 3.9.13
- Numpy version: 1.24.2
- PyTorch version (GPU?): 1.13.1+cu117 (True)
- `Accelerate` default config:
        - compute_environment: LOCAL_MACHINE
        - distributed_type: NO
        - mixed_precision: fp16
        - use_cpu: False
        - dynamo_backend: NO
        - num_processes: 1
        - machine_rank: 0
        - num_machines: 1
        - gpu_ids: 0
        - rdzv_backend: static
        - same_network: True
        - main_training_function: main
        - deepspeed_config: {}
        - fsdp_config: {}
        - megatron_lm_config: {}
        - downcast_bf16: no

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[X] My own task or dataset (give details below)

Reproduction
I tried to use --log_with from the cli but It's not a valid comand
Expected behavior
I would like to know if is possible to add a logger from the cli - Thanks

That's specific to the script, you need to specify that in the Accelerator as the docs show: https://huggingface.co/docs/accelerate/usage_guides/tracking

Got it, I was doing it this way before but I was looking if there was a way from the cli - thanks


Array "push" method with a wrong type of an argument is not caught at the compile stage and exhibits failures at runtime

Test program:
a = [1]
a.push("foobar")
p a

Ruby output:
[1, "foobar"]

Crystal output:
[1]

A proper behaviour would be probably just a compilation error. This problem is particularly non-obvious and difficult to debug when different integer types are mixed (for example, Int64 and Int32).

Actualy the compiled program segfaults if built without optimizations:
Program received signal SIGSEGV, Segmentation fault.
0x0000000000403144 in *Array(Int32)@Array(T)#push<Array(Int32), String>:{String} ()
(gdb) bt
#0  0x0000000000403144 in *Array(Int32)@Array(T)#push<Array(Int32), String>:{String} ()
#1  0x000000000040316f in *Array(Int32)@Array(T)#push<Array(Int32), String>:{String} ()
#2  0x000000000040316f in *Array(Int32)@Array(T)#push<Array(Int32), String>:{String} ()
#3  0x000000000040316f in *Array(Int32)@Array(T)#push<Array(Int32), String>:{String} ()
#4  0x000000000040316f in *Array(Int32)@Array(T)#push<Array(Int32), String>:{String} ()
#5  0x000000000040316f in *Array(Int32)@Array(T)#push<Array(Int32), String>:{String} ()
#6  0x000000000040316f in *Array(Int32)@Array(T)#push<Array(Int32), String>:{String} ()
...

The "silently does nothing" symptoms are only reproducible with the --release build.

This is an argument in favor of issue #291. Array#push(*values) which is the source of the problem could be rewritten to raise ArgumentError unless all values is_a?(T) but a compile time error would be better.

Two more "innocent" looking examples, involving Int32 vs. Int64 mismatch:
a = [1, 2, 3]
a.push(4294967296)
p a

a = [1, 2, 3]
a += [4294967296]
p a

The second one does not directly use "push" and dies with a bit different symptoms.

@Exilor Thanks for your comment. Turns out that this Array#push(*values) problem seems to be a relatively simple one. In order to prevent it from recursively matching itself, looks like it is possible to just use the "<<" operator because it acts as an extra barrier, which is enforcing the type T constraint before using the "push" method (the variant with a single argument). The compiler seems to happyly detecting the problem at the compile time now and I have pushed this fix here: https://github.com/ssvb/crystal/commit/750940a79c2a77fa7f63677237de99bb515a3ec2
However I can't seem to figure out how the spec testing is done. The added testcase in that commit does not work right and I don't know why.
And I also wonder about the performance implications. Shouldn't the "a.push(1, 2, 3)" be preferably expanded to "a.push(1) ; a.push(2) ; a.push(3)" without emitting the actual loop code overhead? And in fact, the check for increasing the buffer size could be potentially done only once instead of repeatedly doing it again and again in a single-value push method variant?

Indeed, the issue seems to be that it recursively matches itself and so loops forever. I think it's time to reopen #291 :smile:. At that time splats were relatively new and we didn't want to add more features, but receiving a splat to repeat the same operation over a sequence of elements (like is the case of Array#push, File#join, etc.) is very common.
The solution using >> is good. Another alternative is to do push(elem as T), but that's uglier, longer, and the error message is also uglier.
@ssvb About your performance concerns: looping over a tuple is not like looping over a regular array. Tuple#each uses macros to basically do yield self[0]; yield self[1]; ...; so it unrolls the loop. And because the block is not captured, there's no method call and the unrolling ends up being in the caller. Then LLVM is pretty good at optimizing things. For example, you can try this:
fun foo : Int32
  {1, 2, 3, 4, 5}.sum
end

Compile (with HEAD) it and pass --release --emit llvm-ir. It will generate a .ll file. In it you will find this:
; Function Attrs: nounwind readnone
define i32 @foo() #4 {
alloca:
  ret i32 15
}

:-)
However, it's true that it would be better to resize the array only once, like it's done in Array#concat, and  then append to the buffer without bounds checks. Performance opportunities like this one are in many places in the standard library. Pull requests are very welcome :-)
Oh, almost forgot: you can't test that something doesn't compile because... well, it won't compile ;-). (you can test that from outside, like here, but that's for general language behaviour, not libraries or std). But maybe there should be a way. For example D has a compiles trait.

I did the self << value fix, but we'll probably also implement #291 so this is less likely to happen

@asterite Thanks for pushing the fix to the repository. There was one more testcase discussed here, which I have now submitted separately as #568
Thanks for the great explanations about the Crystal/LLVM internals. I'll try to look at the performance of the basic Array operations a little bit later. Right now I'm more focused on just getting the things work correctly for me :-) And I'm trying to debug at least one more suspected reliability problem at the moment.


Leap wallet should support add chain

Currently cosmos-kit supports adding custom chains with some of the wallets such as Keplr and Cosmostation. The Leap wallet however is missing this functionality.
The Leap docs show this feature is supported. Can you add it?

cc @baryon2


app-import failing while retrieving server tags

What version of Ctrl-Q are you using?
3.15.0
What version of Node.js are you using? Not applicable if you use the standalone version of Ctrl-Q.
No response
What command did you use to start Ctrl-Q?
see screenshot as the secure information is blurred
What operating system are you using?
MS Windows Server 2019 Std
What CPU architecture are you using?
x64
What Qlik Sense versions are you using?
May 2023 patch 8 (14.129.15)
Describe the Bug
It happens with both JWT and cert authentication:

Expected Behavior
Apps are being imported
To Reproduce
No response

Any update on this @mountaindude?

Have not had a chance to look into this in detail yet.
Looks like you might have a "https" too much though..
The getaddrinfo error indicate that you are using https://<IP_ADDRESS>/foo/bar when you should just be using <IP_ADDRESS>/foo/bar.
Or whatever IP/path you are using.
That's just a very quick guess though.

The Ctrl-Q site has examples on what the --host option should look like.
Could it be that you included "https://" there...?

I have https:// in it yes. That must be it. I will tesr and come back to you. Thanks for responding.
Kind regards,
Youri Torchalski
Business Intelligence Consultant Qlik
Sent from a mobile device

Van: Göran Sander @.>
Verzonden: Tuesday, January 9, 2024 10:44:35 AM
Aan: ptarmiganlabs/ctrl-q @.>
CC: Youri Torchalski @.>; Author @.>
Onderwerp: Re: [ptarmiganlabs/ctrl-q] app-import failing while retrieving server tags (Issue #382)
The Ctrl-Q site has exampleshttps://ctrl-q.ptarmiganlabs.com/docs/command/import/app/#import-apps-from-qvf-files on what the --host option should look like.
Could it be that you included "https://" there...?
—
Reply to this email directly, view it on GitHubhttps://github.com/ptarmiganlabs/ctrl-q/issues/382#issuecomment-1882732177, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALBCDCQQ64KIJ53QUFDI2RLYNUGQHAVCNFSM6AAAAABBHK5WLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBSG4ZTEMJXG4.
You are receiving this because you authored the thread.Message ID: @.***>


full rewrite with everything???

i didnt tested the actions.
it comes with:

full rewrite of the skill-icons
it works
tho stuff needs to happen in actions
actions adds icons as json to code so code can do stuff, you may need to edit that if it doesnt work
and you will need to add vercel token, you can check out the actions for that

@hawl1 got:
The `vercel.json` schema validation failed with the following message: should NOT have additional property `includeFiles`

What could possibly be wrong ?

What could possibly be wrong ?

the vercel bot, i made it to deploy to vercel using github actions, so better remove that

What could possibly be wrong ?

the vercel bot, i made it to deploy to vercel using github actions, so better remove that

how to do that ?

What could possibly be wrong ?

the vercel bot, i made it to deploy to vercel using github actions, so better remove that

how to do that ?

i dunno
https://docs.github.com/en/apps/maintaining-github-apps/deleting-a-github-app
i hope this helps

yeah done that, that should work, now just going to add the token, how to get it ?


feat: add user setting for home board

Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

[x] Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
[x] Pull request targets dev branch
[x] Commits follow the conventional commits guideline
[x] No shorthand variable names are used (eg. x, y, i or any abbrevation)

Yes that's also on my list of things that need to be done 👍🏼


Add Defitrack support for Balancer V2 [Ethereum Mainnet]

Cfr Balancer on Polygon
Subgraph to pull data from:
https://thegraph.com/hosted-service/subgraph/messari/balancer-v2-ethereum
General graph data should be added as:
defitrack-protocols -> balancer -> BalancerEthereumService
Pooling Market Support
all pooling markets should become available.
User Pooling Support
It should be possible to query for user balances in balancer v2 pools.

@TheMoneyLisa sorry for the delay on this. It's because the balancer v2 subgraph failed during indexing and I've been waiting to see if it is fixed, but it's still down upto :(
So I don't know, I guess I'll just wait for messari to fix it


Improve "Modin in the Cloud" support ☁

We have introduced support for "Modin in the Cloud" for automatically spawning a cloud cluster and running a workload in it seamlessly.
The implementation covered only basic codepaths, though, so we need to improve that and handle as much as possible.
Current idea is to first fix as many failing tests as possible in "cloud simulation" approach so we can enable them in the CI.

@vnlitvinov has this issue been resolved?

Not relevant due to https://github.com/modin-project/modin/pull/6408


I forked Dash, but I can't open the wallet because of this message "Invalid spork address specified"

Hi, man! How exactly can I disable spork address at init.cpp from the source code?
I forked dash, but I can't open the wallet!

Hi, can you explain more what you're trying to do? We haven't been supporting forks due to limited resources, but might be able to point you in the right direction.
You can't really disable the spork address, but you can generate your own spork key from any ECDSA private key pair. Just make sure you have the private key so you can sign sporks, and replace the spork address w/your own address in chainparams.cpp.

how to sign the spork ?

duplicate of https://github.com/dashpay/dash/issues/3455, plus no response. Closing


Added additional information about refresh tokens to the readme

Added how to obtain a refresh token and how to obtain a new refresh token along with code samples.
Relates to thephpleague/oauth2-client#370.

Please squash these 3 commits into one.

Done, sorry about that.

Also please update your commit message to follow these rules: http://chris.beams.io/posts/git-commit/#seven-rules

Better?

@tplaner It looks like imperative subject is still not being used.

Verb added: If applied, this commit will Provide more information about refresh tokens

@tpavlek :) awesome thank you.

Also thanks to @tplaner who was the only one who did anything here =P

@tplaner oops... autocomplete fail. :eyeglasses:


Public documentation for running a Scroll node

Description
guide on how to run a Scroll node
other changes

modified the Aside component so that it can display no title

As mentioned in conversation, I'd love to see an intro to this clarifying who the audience is, since this is a "guide" and not just a technical reference. Maybe mention that many developers will use the public RPC and then advance to managed infrastructure by RPC providers in the ecosystem. Also to make clear that this is a "follower node" that can participate in the public mempool of transactions, but does not participate in consensus or block building.
Lastly, can we have subheadings in troubleshooting that labels each error? It kind of runs together as it displays now.


Decrease time spent waiting for compilation requests

Have you considered asking the community support in terms of mirroring the playground?
At the moment https://play.rust-lang.org/ takes about ~1.5 secs to compile and run a snippet. Could sharing the load across different VMs make it snappier?

The pool approach makes sense. I'll give it a try

After some experimentation, a couple of questions:

are we fine in preventing users from writing on the filesystem?
if not, is there a way to make sys::fs map to an in-memory fs implementation?

The problem with using shared docker containers is that whatever file a snippet creates stays in the container and it's possibly accessible by other users. With the current one-snippet <-> one-container approach, saving files is not a problem.
One possible convoluted solution is to run cargo build in a container and then move/copy the executable into another container which is started with docker --read-only: this way at build time cargo is happily using precompiled crates, and at run time we are sure snippets won't leave any files around because the fs won't be writable.
If instead we do want to allow filesystem write access and we do care about not having user generated files around, then the shared container approach is a no-go.
I've tried investigating various approaches (apparmor, firejail and chroot) but they all require sysadmin knowledge which I don't have.
Unless we can replace the underlying fs implementation of rust with an in-memory one. Judging from https://github.com/rust-lang/rust/blob/master/src/libstd/sys/mod.rs#L25 the answer is no, but I'm new to rust


feat: add arm64 support

This PR adds arm64 images to dockerhub
https://github.com/hibiken/asynqmon/issues/292

One note here: the second commit removes the GOOS=linux GOARCH=amd64 as otherwise this won't work.

I put it on draft as this needs to be tested in this repo.

similar to https://github.com/hibiken/asynqmon/pull/269 + fixed ENV in Dockerfile

@hibiken are you able to test this somehow?

any update?


Question about the releasing time

Hello, @dennis-park-TRI !
Thanks for your excellent work DD3D, which shows great results in benchmark. I am wondering when will you open-source your code.

Thanks for your interest, @gujiaqivadin. We're planning to release the code within 1-2 weeks.

@dennis-park-TRI , waitiing to see your excellent work soon.

hi looking forward to your master piece!!!


Abbreviated Entities

There are several abbreviated entities in ADAPT today.
Irrigation is often abbreviated Irr.
Unit of Measure is often represented as UOM
There is also Obs.
In working toward a standard, I believe we need to minimize abbreviations.    It is easy to spell out Irrigation and Unit of Measure, and I intend to do so.
Obs is its own problem.   It is  renamed from "OM" defined in the PAIL project.   I suspect this means an individual Observation/Measurement.    Since the ObservationMeasurement object hierarchy descends from Observations, ObsDataSets, ObsCollections, to "Obses," it is easy to get lost in understand what these all mean, let alone how to use them.    Since the top Observations entity may be superfluous (see #37) a straightforward and understandable approach may be to rename "Obs" to "Observation."    Thus an ObservationDataset contains ObservationCollections themselves containing Observations.

We agreed today to eliminate abbeviations.
Irr -> Irrigation
RotCtr -> Rotation Center
UOM  -> Unit of Measure
Obs awaits renaming.


How to keep navigation header on top?

I have navigation header for showing back button and title. I just want to keep this on top and not get replaced by collapsed header or the tabs.

Hi @ydhnwb, do you mean that you don't want the collapsed header or the tabs view scroll over on top of the <Header/>?

Yes. I want header to keep on top, and the tab will hanging below the header when it scrolled

Is this what you attempt to achieve?

yes, exactly like that

Here is my example code:
const Header = ({title}) => {
  return (
    <View
      style={{
        backgroundColor: 'white',
        height: 65,
        flexDirection: 'row',
        alignItems: 'center',
        justifyContent: 'center',
      }}>
      <Text style={{fontSize: 20}}>{title}</Text>
    </View>
  );
};

const App = () => {
  return (
    <SafeAreaView style={{flex: 1}}>
      <Header title="Detail Material" />
      <CollapsibleTabView />
    </SafeAreaView>
  );
};

For: CollapsibleTabView, I simply copy my collapibleTabView.js and modify the style like this:
  return (
    <View style={{flex: 1, overflow: 'hidden'}}>
      {renderTabView()}
      {renderHeader()}
    </View>
  );

By adding overflow: 'hidden' to prevent the header from renderHeader() scroll over on top of the navigation bar.

Thank you very much. I'll try to implement that


请问如何关闭RootFragment以上的所有Fragment

Issues Guideline
Following information can help us to resolve the issue faster.

Library version
Support-v4 version
Logs
Screenshots

In addition, we do not accept issues unrelated to Fragmentation.

popTo(RootFragment.class, false)


Mode range, enableTime when selecting the date the dialog was closed.

I'm going to get a choice of date and time in the range mode.
I expect that when choosing the second date, I can set the right time for it.
And the dialog was closed by a click outside of it or by my call ".close ();".
But after selecting the second date, the dialog immediately closes without letting you choose the time.
It is necessary to open the dialog again, then the time changes on the previously indicated second date.
Can I somehow prevent unnecessary closing of the dialogue?

Reproduction Link
https://jsfiddle.net/aj6k3f1v/34/
Your Environment

flatpickr version used: v2.6.1
Browser name and version: chrome  58.0.3029.96 (64-bit)
OS and version: win8.1

Resolved by 396098259cf5c1e4ee8c0ed31c0b9ad6152178b3


datatables in kivymd 2.0.1 dev0

Hi
from kivymd.uix.datatables import MDDataTable
is not a viable in kivymd rev, 2.0.1 dev0
OS: windows 10
kivyMD : 2.0.1 dev0 (latest)

The MDDataTable widget will soon be available in another package - https://github.com/kivymd-extensions

@HeaTTheatR Any news regarding the datatable extension?


How to "... mark the incoming navigation as required to always create an instance"?

At https://docs.microsoft.com/en-us/ef/core/what-is-new/ef-core-6.0/breaking-changes#old-behavior it reads:

System.InvalidOperationException: Entity type 'ContactInfo' is an optional dependent using table sharing and containing other dependents without any required non shared property to identify whether the entity exists. If all nullable properties contain a null value in database then an object instance won't be created in the query causing nested dependent's values to be lost. Add a required property to create instances with null values for other properties or mark the incoming navigation as required to always create an instance.

Can't you show an example of how to achieve "mark the incoming navigation as required to always create an instance", please?
For instance this does not work, because the IsRequired() method does not exist:
            builder.OwnsOne(p => p.Value, ot =>
            {
                ot.Property(d => d.Street);
                ot.Property(p => p.Location).;
                ot.Property(p => p.PostalCode);
                ot.Property(p => p.City);
                ot.Property(p => p.Country);
            }).IsRequired();

I have the same question. Is there a way to mark the navigation property as required?

@jp2masa @ajcvickers  In fact I have figured out how to do it, i.e. like:
builder.OwnsOne(p => p.Value, ot => { });

builder.Navigation(p => p.Value).IsRequired();

So to me it seems like specifying OwnsOne and IsRequired is nearly completely unrelated. I would find it more reasonable, if it would be specified as I wrote in my initial post. I would also find it reasonable, if there would have been a reference in the documentation on OwnsOne to the other segment in the documentation where this is described, or perhaps the example could just include the usage of IsRequired().

It works, thanks!


closes #165

running handling added to empty string to prevent error being raised mid recv

Coverage decreased (-0.04%) to 93.309% when pulling 4ed97bba819340d2de960be3ef3210b49767e324 on bugfix/165-stop-socket-error into 53c58d309f3bf1c2164ece067eb343af8295ddf8 on release/1.10.0.


Feat(RingTheory/Flat): add FaithfullyFlat file with def and basic results

Add definition of faithfully flat ring maps and show basic properties.
Co-authored-by: Florent Schaffhauser (github: matematiflo)
This contribution was created as part of the AIM workshop "Formalizing algebraic geometry" in
June 2024.

There is the following alternative definition of faithfully flat ring map and there should probably be a discussion about which one should become the mathlib definition:
@[mk_iff] class FaithfullyFlat' : Prop where
  flat : Module.Flat R M := by infer_instance
   submodule_ne_top :  ∀ ⦃m : Ideal R⦄ (_ : Ideal.IsMaximal m), m • (⊤ : Submodule R M) ≠ ⊤

This would avoid universe issues.

There is the following alternative definition of faithfully flat ring map and there should probably be a discussion about which one should become the mathlib definition:
variable (R : Type u) (M : Type v) [CommRing R] [AddCommGroup M] [Module R M]

@[mk_iff] class FaithfullyFlat' : Prop where
  flat : Module.Flat R M := by infer_instance
   submodule_ne_top :  ∀ ⦃m : Ideal R⦄ (_ : Ideal.IsMaximal m), m • (⊤ : Submodule R M) ≠ ⊤

This would avoid universe issues.

I think this second version is better. I understand that it is probably not easy to show the equivalence, but putting in mathlib a definition that we know we are going to change is a recipe to make people suffering (someone will start using your definition, and the refactor will be more and more painful).
Can you start adding the basic API to show equivalence? (Or anything else you need!). Thanks!

I think this second version is better. I understand that it is probably not easy to show the equivalence, but putting in mathlib a definition that we know we are going to change is a recipe to make people suffering (someone will start using your definition, and the refactor will be more and more painful).
Can you start adding the basic API to show equivalence? (Or anything else you need!). Thanks!

I'll label this PR as work in progress for now until we sort this out. Thanks for your input.

I just want some very quick and general comments about if these changes are in the right direction. If so, I will split this PR

I just want some very quick and general comments about if these changes are in the right direction. If so, I will split this PR

@jjaassoonn the general direction looks good to me.

Can you please fix the error?

Done, sorry was having late lunch

Thanks :tada:
bors merge


Exception: Failed to find lsass.exe

Cmd with administrator privileges:
C:\Users\Usuario\Downloads\pypykatz-master>pypykatz.exe live lsa
Exception while dumping LSA credentials from memory.
Traceback (most recent call last):
File "C:\Users\Usuario\AppData\Local\Programs\Python\Python37\lib\site-packages\pypykatz-0.0.7-py3.7.egg\pypykatz_main_.py", line 74, in main
mimi = pypykatz.go_live()
File "C:\Users\Usuario\AppData\Local\Programs\Python\Python37\lib\site-packages\pypykatz-0.0.7-py3.7.egg\pypykatz\pypykatz.py", line 44, in go_live
reader = LiveReader()
File "C:\Users\Usuario\AppData\Local\Programs\Python\Python37\lib\site-packages\pypykatz-0.0.7-py3.7.egg\pypykatz\commons\readers\local\live_reader.py", line 308, in init
self.setup()
File "C:\Users\Usuario\AppData\Local\Programs\Python\Python37\lib\site-packages\pypykatz-0.0.7-py3.7.egg\pypykatz\commons\readers\local\live_reader.py", line 344, in setup
pid = get_lsass_pid()
File "C:\Users\Usuario\AppData\Local\Programs\Python\Python37\lib\site-packages\pypykatz-0.0.7-py3.7.egg\pypykatz\commons\readers\local\common\live_reader_ctypes.py", line 78, in get_lsass_pid
raise Exception('Failed to find lsass.exe')
Exception: Failed to find lsass.exe
==== Parsing errors:
live

Send a bit more details if possible.
Like... what Windows version is that? Buildnumber? Are there any processes running that might interfere (eg. endpoint security, AV etc)?

Windows 10 Home 64 bits
NO AV
C:\Users\Usuario>systeminfo
Nome do host:                              DESKTOP-MFB3E88
Nome do sistema operacional:               Microsoft Windows 10 Home Single Language
Versão do sistema operacional:             10.0.17763 N/A compilação 17763

Closing this, as I can't reproduce it.
Double-checked the code and it was finding the lsass.exe 100% of the time.


processes doesn't pass through exit codes

It doesn't seem like heroku run passes back the exit code:
% heroku run "jflsda"
Running jfdlksa attached to terminal... up, run.34
sh: jfdlksa: not found
% echo $?
0

Is there any way this could be added?

We are having the same issue! +1

Updated the title to be a bit more generic (because rake and other things have this issue too, not just run).  We are aware of this but there isn't a simple way for us to add this at the moment.  We definitely are keeping this in mind as we work on things though, so hopefully we can add it in the not too distant future.  Thanks!

+1 — This is holding us back from migrating a few apps to Heroku

+1 Same issue!

+1 would be super helpful

Thanks for the feedback everybody.  There are some internal things that will need to happen to enable this, so we are continuing discussions to figure out how to best offer it.  I will do my best to get it into the client once it is ready though.  Thanks!

+1

@dickeyxxx any updates on this? Is there a reason incorporating the approach in https://github.com/glenngillen/heroku-exit-status isn't desirable?

are you having good luck with it @JacobEvelyn? I could look into adding it, it's a risky change simply because I don't have a great idea how it might possibly mess up people's flows, but I'm down to try it. I would love to solve this bug.

How about at least adding it as an opt-in command line parameter to heroku run (and then flipping it to the default in the next major bump)

how is that different than testing by installing the plugin?

@dickeyxxx my thinking being that if reticence to make a breaking-change is holding this up then putting it behind a command line flag solves for that. it would be nice if this was a supported part of the toolbelt instead of having to install a plugin.

@niallsmart you've got the right idea. The issue here is that discoverability in a CLI is tough, so not that many people would notice the flag. Also, the complex setups where people are potentially using run in  weird ways which may break their workflow are probably using it in scripts. The plugin is fine for testing the functionality works in a normal case, I'm worried about potential corner cases that I haven't yet considered.
In any case, this is worth pursuing and I think that corner cases will be few if any. I also think this will fix enough problems that we could work through whatever those corner cases are. I'm considering doing this next week, but if issues crop up I may have to revert.

I'm also of the opinion that the status code should just be the status code that was returned by the process, I don't think a flag is a good long-term solution.

+1

good news (finally)! the new CLI will handle this problem, and I have a PR in to start testing it: https://github.com/heroku/heroku/pull/1519
Right now it will work behind a flag, but I intend to make that temporary if possible. There is a bit of work left to be done in the v4 module that works with this: https://github.com/heroku/heroku-run
Namely handling things like stdin and piping, but I hope to merge it soon.

this is out!

Awesome. :clap:

@dickeyxxx the --exit-code option does not appear when running heroku help run. this makes it very hard to discover it.

@stof thanks for pointing that out
https://github.com/heroku/heroku/pull/1546

:+1:
Thank you, thank you, thank you for this!


Design multi-version model generation from Cadl

Requirements:

As a prerequisite, we need a multi-version client in order to handle models in version-aware fashion (i.e. we need to know what service version the client is targeting, and what client version the app code is using).
Support the following model changes:

Add optional property to input model
Add optional property to output model
Add required property to output model
Property changes from required to optional
Value added to extensible enum
Value added to input fixed enum
Widen input integer
Polymorphic type additions
Input type becomes round-trip type
Output type becomes round-trip type

Pending clarity on the agreed-on definitions of stateful vs. resilient vs. multi-API. @mikekistler, do you know if we closed on these?
Per @m-nash:

When we talk about multi-version we should be specific if we are talking about service version, resource version OR model version

There have been no comments in the OneNote page where I put the definitions, but I suppose we should confirm agreement on these at the next DPG planning meeting.

In model serialization code, we should pass in the api version.  This is a challenge if we need to pass it into an interface, need to solve this problem.  See https://github.com/Azure/autorest.csharp/issues/2371#issuecomment-1190900199

Take into account for polymorphic models: https://github.com/microsoft/api-guidelines/issues/332

Originally stated:
This is different from resilient model generation described in:

https://github.com/Azure/autorest.csharp/issues/2354
https://github.com/Azure/autorest.csharp/issues/2356

@chunyu3, please help to check the history of this item, this is the effort that we need to complete before GA.

One client library will contain/support operations and models belongs to multiple service version.
What's the behavior of client versioning:
1. Version-aware
2. Resilience
3. Multi-API
Scope:
1. Operation
2. Model/model property
#Client versioning in cadl
@versioned(Versions)
@service({title: "Anomaly Detector"})
@useAuth(ApiKeyAuth<ApiKeyLocation.header, "Ocp-Apim-Subscription-Key">)
@server(
  "{Endpoint}/",
  "mulitple version service.",
  {
    @doc("Supported Services endpoints.")
    Endpoint: string
  }
)
@doc("CADL project to test api versions.")
namespace TestService;
enum Versions {
  v1_0: "v1.0",
  v1_1: "v1.1",
  v1_2: "v1.2"
}

@added(Versions.v1_0)
model Foo {
  name: string;
  @added(Versions.v1_2)
  addedOptionalInV12?: string;
}

op opv10(): void

@addded(Versions.v1_1)
op opv11(): void

@deleted(Versions.v1_1)
op opvdeleted(): void

#updated operation
@deleted(Versions.v1_1)
op opToupdate(): void

@added(Versionsv1_1)
op opToupdate(@path id: string): void

Or
op opToupdated(@added(Versions.v1_1 @path id: string): void

Generate SDK
approach: version-aware, add ServiceVersion parameter in serialize and deserialize (ToRequestContent, FromResponse)
Add optional property to input/output model
Add this property to the model as optional
In ToRequestContent, FromResponse to serialize/deserialize according to the api-version
namespace TestService.Models
{
    public partial class Foo
    {
        public Foo(string name)
        {
            Name = name;
        }
        public Foo(string name, string addedOptionalInV12)
        {
            Name = name;
            AddedOptionalInV12 = addedOptionalInV12;
        }
        public string Name {get;}
        public string AddedOptionalInV12 {get; set;}
    }
}

//serialize and deserialize
namespace TestService.Models
{
    public partial class Foo: IUtf8JsonSerializable
    {
        void IUtf8JsonSerializable.Write(Utf8JsonWriter writer)
        {
            writer.WriteStartObject();
            writer.WritePropertyName("name"u8);
            writer.WriteStringValue(Name);
            if (AddedOptionalInV12 != null) {
                writer.WritePropertyName("addedOptionalInV12"u8);
                writer.WriteStringValue(AddedOptionalInV12);
            }
            writer.WriteEndObject();
        }
        internal static Foo DeserializeFoo(JsonElement element, ServiceVersion version)
        {
            string name = default;
            string addedOptionalInV12 = null;
            foreach (var property in element.EnumerateObject())
            {
                if (property.NameEquals("name"u8))
                {
                    name = property.Value.GetString();
                    continue;
                }
                if (property.NameEquals("addedOptionalInV12"u8))
                {
                    if (version >= ServiceVersion.V1_2) {
				addedOptionalInV12 = property.Value.GetString();
			  }
                    continue;
                }
            }
            return new Foo(name, addedOptionalInV12);
        }
        internal override RequestContent ToRequestContent(ServiceVersion version)
        {
            if (AddedOptionalInV12 != null && version < ServiceVersion.V1_2) throw new Exception($"unexpected property {property.Name} in api version {version}");
            var content = new Utf8JsonRequestContent();
            content.JsonWriter.WriteObjectValue(this);
            return content;
        }
        internal static Foo FromResponse(Response response, ServiceVersion version)
        {
            using var document = JsonDocument.Parse(response.Content);
            DeserializeFoo(document.RootElement, version);
        }
    }
}


CI with GoReleaser

Pull Request Test Coverage Report for Build 570025263

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.142%

Totals

Change from base Build 569943392:
0.0%

Covered Lines:
406

Relevant Lines:
513

💛  - Coveralls


! in select is compiled to NOT in SELECT?

What happened?
When using ! for excluding a column, if forgetting to add {} it is translated to NOT.
PRQL input
prql target:sql.duckdb

from tracks
select !milliseconds

SQL output
SELECT
  NOT milliseconds
FROM
  tracks

-- Generated by PRQL compiler version:0.9.5 (https://prql-lang.org)

Expected SQL output
SELECT
  * EXCLUDE (milliseconds)
FROM
  tracks

MVCE confirmation

[X] Minimal example
[X] New issue

Anything else?
No response

! does mean NOT! Maybe we should document this better... It is listed in https://prql-lang.org/book/reference/syntax/operators.html, but I don't think we ever actually give its definition...

I agree, this is quite unexpected. We could add a special case for this in our semantics, or we could require select and derive to always have {}.
(in any case, this is not a compiler bug)

My question here is that the results differ with or without {}. I feel this is a bug because in other places the presence or absence of {} has not affected the result

Yes that is a good point. Arguably that was a risk when we chose to allow ! to mean both NOT and "exclude".
One thing we maybe could do — though I haven't thought it enough to recommend it — is disallow select foo * 2 — i.e. any unnamed expression.
So then select !foo would be invalid, while select x=!foo would be valid. And select x={!foo} still means NOT, while select {!foo} and select !foo` both mean "exclude"[^1].
[^1]: or select !foo could be invalid, but at least isn't ambiguous
But that also feels like a big change, plausibly to make up for a small mistake.
Another option would be to choose a different symbol for "exclude", but I'm not sure there are good ones... (^? ~??)

One thing we maybe could do — though I haven't thought it enough to recommend it — is disallow select foo * 2 — i.e. any unnamed expression.

No, I really dislike this, since it is a special rule.

Another option would be to choose a different symbol for "exclude", but I'm not sure there are good ones..

True.

What about requiring {} for select?

No, I really dislike this, since it is a special rule.

Yes fair

What about requiring {} for select?

I do think it's nice to just have select foo. But I won't cling too tightly!
And even if we made that change — then isn't there still ambiguity / special-casing?
select {!foo} could still be interpreted as either NOT or "excludes", no?
IIRC, we thought this was OK because we could use the tuple to discriminate between them. Or am I misremembering?

That was exactly the reasoning I believe:

negation of tuples is exclusion,
negation of non-tuples is boolean negation

Yes, you're right (I edited above).
In that case, it does seem like select !foo is legibly NOT, since it's not negating a tuple.
If folks feel strongly about forcing tuples, then I won't cling on. Though we would still be left with lots of places we can't pass tuples (filter / group ), so I'm currently holding that it doesn't overall make the language more consistent...

Yeah, I don't think this is ambiguous, so I don't think we should require {} in select.
@eitsupi if you agree, we can close this issue.

I added docs at #3820


Cquery takes a long time to start up for already-indexed project

After initially indexing my project (which understandably takes a long time), if I close and reopen my project, cquery still takes a long time to start up and become usable. Not quite as long as the initial indexing (which for the particular project I have in mind takes ~30 mins), but still quite long, on the order of ~5 minutes.
My expectation would be that, if the project is already indexed, cquery is "ready to go" within a few seconds of opening the editor, since all it should need to do is read the already-built index from disk.

I've got a similar issue with our code base. With the "msgpack" ( with helps a lot btw. ! ;) ), the cache is about 5 Gb and the querydb around 8 Gb. When I open a file in that project, it takes up to 1 hour to reindex everything (we have a entire e.g. Qt5 Source in the background + lots of headers / templates etc. ). From my point of view the option to save that Query would be a big performance factor. Especially on multiple branches one checkout basically causes an entire reloading of cquery.
My workaround at the moment is to run YouCompleteMe ( I'm on Neovim ) and cquery in parallel. Since YCM starts up very fast and gives auto-completion relatively quickly, while it lacks most other feature at cquery provides, it atleast provides me with a bare bones environment to work with (until cquery is here).
If the query could be dumped to the cache dir, and reloaded it would maybe faster on start up? As it's now I don't know another way as to use YCM and cquery at the same time.

Do you mean to save Query* (defined in query.h) on the disk, along with already saved Index* (defined in indexer.h)?

As far I read, the Query* basically caches the saved Index*', hence when the Client closes it's session all data is lost. Maybe if the server is kept open until the Query* is flushed to the cache directory for a faster startup on the next Client-Session for that project. A change (which would trigger a re-indexing? ) could be suspended until the previous session is loaded up. Maybe it could depend on the project size, for a smaller project the reloading is fast. But for a production size code, that reloading just takes to long. I also thought of keeping the session alive, just to keep the data alive.

But loading all of the files from cache should be pretty fast. Maybe we're not doing a good job prioritizing restoring the cache over reindexing files?
Index* files are what are stored on disk. Query* is in-memory only. As you edit a project, the indexer emits Index* instances which are written to disk and applied to the Query* instance. So, we always go Index* -> Query*, never Query* -> Index*.

Okay, but that 'restarting' takes the above mentioned time. What can I do to prioritize the restoring of the cache? I didn't meant to pass Query* stuff to the Index*. The Index* could may be update the Query* once it's restored from the disk. If the Query* doesn't pass stuff to the Index*, that could be an idea.

What changes are made to Query* if a definition is moved from a.cc to b.cc? The order of to_add to_remove matters then. I suggest adding a Generation gen; to Query* (https://github.com/cquery-project/cquery/issues/403)
@MagB93 There is some introduction https://github.com/cquery-project/cquery/wiki/Design . And the internal structure is in the two files indexer.h and query.h.
I'm thinking how to improve them.

So if I start my session with a indexed project, cquery basically has to load the corresponding file and the corresponding headers. Hence when there are about 300+ headers the loading time takes quite some time. This of course depends on the opened file. So is there another plan to improve the startup time?

@khng300


Injecting event manager to allow listeners to trigger correctly

Allows Connection (and therefore Database/Collection) to access and trigger configured events.

This looks reasonable but I strongly recommend you submits this upstream as well.

@Bilge - thanks do you need me to squash these commits?
As and when you are happy I will PR on the upstream too :)


Update php-autoload-override version

This PR updates the version for the php-autoload-override library.

Coverage remained the same at 100.0% when pulling 4255a85cb7ffc8b7d20c30b698b5d0d151af7a6e on adriansuter:patch-override into 0e3d0951d54d67b0aa5587d9c8237a706b77f34f on slimphp:master.


DS-3245: CSV linebreaks not supported by Bulkedit -  DSpace 6

Port of #1757 to dspace-6_x branch.
Fixes https://jira.duraspace.org/browse/DS-3245

A late +1 apart from my comment above.


The Home page is not according to the app demo

Hello, I ran the program successfully , but when I post the local address http://<IP_ADDRESS>:8080/ for example, p/CwdV203ocVB/, the address is like this http://<IP_ADDRESS>:8080/p/CwdV203ocVB/ but after It takes a few moments to redirect to the same post on Instagram and there is no save option so I can download it. What is the problem?

The home page is not according to the app demo, where we can edit the post address and...

Thanks @almi05 for answering, I will close this issue


Validation Errors for Forms

Trying to consistificationize how we handle form errors.
Also includes some changes to Flash Messages.

After a skim through the changes, it looks alright to me. :+1:


Added Condition to check drag & drop works only on scan page

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/25661
PROPOSAL: https://github.com/Expensify/App/issues/25661#issuecomment-1687745062
Tests

Go to the money request page
Select Distance tab
Drag file to this tab
Verify that user can't drag & drop a file on the distance page

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Go to the money request page
Select Distance tab
Drag file to this tab
Verify that user can't drag & drop a file on the distance page

[x] Veri
[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/47522946/b62d1efd-8985-40f4-804b-272e637b3921

Mobile Web - Chrome

Mobile Web - Safari

Desktop
https://github.com/Expensify/App/assets/47522946/b62d1efd-8985-40f4-804b-272e637b3921

iOS

Android

@dhairyasenjaliya Looks you didn't link the correct issue at first. @fedirjh Mind completing the checklist please?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.3.59-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.3.60-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.3.60-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Improvements required in anouncements page.

the upcoming events do not have proper alignment .
On resizing the content goes out and this has to be fixed
excessive space at the left side.

the buttons do not have format design throughout the page.

@smaranjitghose i want to work on this.

As per instructions in the slack channel, comment the bugs you want to fix in the particular issues of the pages instead of raising them separately


Handle pipeline with no commands

For completeness sake, also handle pipeline/2 with no commands.
This makes piping (|>) keys from one function into a pipeline command easier.

As @whatyouhide said, all Redix calls are meant to be actual server calls, otherwise in case if Redis server is down pipeline(conn, []) will happily continue to return {:ok, []}.

Hey @behe, thanks a lot for the contribution which lead to a few bugs less, even if we didn't go with what you proposed :heart_decoration: Closing this!


use GITHUB_TOKEN to avoid github quota limit

What does this PR do?
use GITHUB_TOKEN to avoid github quota limit
This PR depend on https://github.com/helm/helm/pull/12358
Which scenarios this will impact?
Motivation
Additional Notes

@nplanel merging as this blocks other PRs pipelines, thank you so much !

/merge

Closing as this is now fixed by https://github.com/DataDog/test-infra-definitions/pull/355


is_state_attr template problem with non-existing attributes

Home Assistant release (hass --version):
0.42.4 and 0.43.0.dev0
Python release (python3 --version):
Python 3.5.3
Component/platform:
homeassistant automation
Description of problem:
Can not start homeassistant with the following automation.
I tested this in the /dev-template tab and it just returns the right answere (true/false):
{{ is_state_attr('media_player.apple_tv', 'media_content_type', 'movie') }}

Furthermore there was no error when I run the Configuration Validation!
Expected:
Homeassistant should be able to parse the automation.
Problem-relevant configuration.yaml entries and steps to reproduce:
automation:
  - alias: movie_begins
    trigger:
      platform: state
      entity_id: media_player.apple_tv
      to: 'playing'
      for:
        minutes: 2
        seconds: 0
    condition:
      condition: and
      conditions:
        - condition: sun
          after: sunset
        - condition: template
          value_template: '{{ is_state_attr('media_player.apple_tv', 'media_content_type', 'movie') }}'
    action:
      - service: script.movie

Traceback (if applicable):
17-04-21 21:05:20 ERROR (Thread-1) [homeassistant.util.yaml] while parsing a block mapping
  in "/config/includes/automation/appletv.yaml", line 14, column 9
expected <block end>, but found '<scalar>'
  in "/config/includes/automation/appletv.yaml", line 15, column 44
17-04-21 21:05:20 ERROR (MainThread) [homeassistant.bootstrap] Error loading /config/configuration.yaml: while parsing a block mapping
  in "/config/includes/automation/appletv.yaml", line 14, column 9
expected <block end>, but found '<scalar>'
  in "/config/includes/automation/appletv.yaml", line 15, column 44

Additional info:

When HA starts there is no states.media_player.apple_tv.attributes.media_content_type, which seems to be the problem. This is a workaround for the problem:
automation:
  - alias: movie_begins
    trigger:
      platform: state
      entity_id: media_player.apple_tv
      to: 'playing'
      for:
        minutes: 2
        seconds: 0
    condition:
      condition: and
      conditions:
        - condition: sun
          after: sunset
        - condition: template
          value_template: >
            {% if states.media_player.apple_tv.attributes.media_content_type %}
              {{ is_state_attr('media_player.apple_tv', 'media_content_type', 'movie') }}
            {% else %}
              {{ false }}
            {% endif %}
    action:
      - service: script.movie

But there should be a more meaningful error, right!?

Do you have #7138 included in your 0.43.0.dev0?

Homeassistant runs in the docker container homeassistant/home-assistant:dev so it should be included, right?

Eh, I don't know. Try this one: {{ is_state_attr('x','y','z') }} in /dev-template. If it says False, you have the fix. If it says None, you don't.

It says False so this is not the problem ...

I didn't look close enough. It sounded similar to that bug, but you just rewrote the config to avoid the real problem of wrongly nested quotes.
Try this instead:
   value_template: "{{ is_state_attr('media_player.apple_tv', 'media_content_type', 'movie') }}"

Oh, now I see the error. I was just using single quotes, which leads to the parsing error. Your answere works correctly.
Thanks for your help! 👌


Be smart about {}

Currently you accept any character into the {} string. So if we have code:
foreach (var key in collection)
{
    //bla bla
}

If will destroy that block. At least make sure that there are no tabs/spaces/newlines in the block. You shouldn't have to escape the curly braces if the formatter can't use the block.

Is there a property build in that will allow you to change the placeholder characters or do I have to modify the library?

I guess it's somewhere in https://github.com/scottrippey/SmartFormat.NET/tree/master/src/SmartFormat/Core/Parsing .
@scottrippey, can you confirm?

I honestly thought it was built in to change the symbols, but after taking a look at Parser.cs, I can see that it's hard coded. Perhaps this could be a feature request.

Should I create a feature request for this?

Yeah, create it as a feature request, on a separate thread.


Consider using FallFlyingLib?

Would please you consider using FallFlyingLib to solve the compatibility issues with other mods which use FallFlyingLib?
FallFlyingLib is a library I made and maintain which makes the elytra compatibility between all mods easier, whilst adding a comprehensive pipeline for most mods to tinker with.
If you want an example implementation: https://github.com/CafeteriaGuild/FallFlyingLib/blob/master/src/main/java/net/adriantodt/fallflyinglib/impl/support/VanillaSupport.java

I've looked at your library.  Our elytras functionality does not overlap with your library. I see no point in applying it at the moment.
If you mean FFL Trinkets, thats not needed too. Ours elytras combine armor and elytra functionality and do not assume placement in a separate slot.


Error: readFile - filesystem not available for browser environment

I use angular , i have an error

This is my code:
html:
<img id="myImg" src="assets/img/tom-cruise.jpg" />
and file ts:
  const input: any = document.getElementById('myImg')
    await faceapi.nets.ssdMobilenetv1.loadFromDisk('assets/models')
    console.log('a', input);
    // const detections = await faceapi.detectAllFaces(input);
    const detections1 = await faceapi.detectAllFaces(input, new faceapi.SsdMobilenetv1Options())
    const detections2 = await faceapi.detectAllFaces(input, new faceapi.TinyFaceDetectorOptions())

I don't understand why the project can't find env, help me, thank you

The issue is common. If you are using Webpack, you can follow this instruction


Feat: add console footer

What does this PR do?
Adds a footer to the console
Test Plan
Manual
Related PRs and Issues
N/A
Have you read the Contributing Guidelines on issues?
Yes

it looks kinda weird on this screen, can you check with the design team?

 it looks kinda weird on this screen, can you check with the design team?

Fixed the spacing issue, but design requested aditional changes. GOing to convert this into draft because it may require changes in pink.

We should add u-cross-center to align the icons and the text :+1:

We should probably add u-cross-center to align the icons and the text 👍

Which browser is this happening on? I tested on Firefox and Chrome, and it's aligned 🤔


[BUG]

Describe the bug
Run freertos under windows.Create a task, only vTaskDelay (pdMS_TO_TICKS(1000)) is performed in the task; delay, and then call the FreeRTOS xTaskGetTickCount() function and the windows GetTickCount() function respectively to print, the final result is 1000 milliseconds apart
Target

Development board: Windows device emulator
Instruction Set Architecture: x64
IDE and version: vs2019
Toolchain and version: default

Host

Host OS:Windows
Version: Windows10

To Reproduce

Use project:WIN32-MSVC-Static-Allocation-Only
demo code:

static void test1_thread(void *arg)
{
    while(1)
    {
        vTaskDelay(pdMS_TO_TICKS(1000));

        printf("--> test1 %8d %d\r\n", xTaskGetTickCount(), GetTickCount());
    }
}

Expected behavior
When the code was actually executed in the end, the printing result was 1000 milliseconds apart
Screenshots

Hello thank you for reaching out, with ticks there are expected to be equivalent to a (millisecond)[https://github.com/FreeRTOS/FreeRTOS/blob/6f7f9fd9ed56fbb34d5314af21f17cfa571133a7/FreeRTOS/Demo/WIN32-MSVC/FreeRTOSConfig.h#L47]. And in the current context they it appears that the task is delayed by 1000 milliseconds. Can you please elaborate on your expected behaviours.

My configTICK_RATE_HZ macro defines 1000. My problem is that the number of ticks obtained by xTaskGetTickCount() is inconsistent with the number of ticks obtained by the Windows system API interface GetTickCount()

Hello thank you for reaching out, with ticks there are expected to be equivalent to a millisecond. And in the current context they it appears that the task is delayed by 1000 milliseconds. Can you please elaborate on your expected behaviors.

My configTICK_RATE_HZ macro defines 1000. My problem is that the number of ticks obtained by xTaskGetTickCount() is inconsistent with the number of ticks obtained by the Windows system API interface GetTickCount()

The interval displayed by xTaskGetTickCount() is 1000 milliseconds.However, the tick display interval obtained by the Windows system API GetTickCount() is 2000 milliseconds

Hello @adg7660,
The tick interrupt simulated on windows port  is based on sleep(), which is not guaranteed to be realtime. The windows port simulates realtime behavior by slowing down time and pretends every 'X' ms = 1 ms. The windows port is good place to develop code which can be later moved and tested on real hardware, but the port can't behave as RTOS.

Windows port simulates FreeRTOS tasks using Windows threads. The RTOS port layer just suspends and resumes these threads and the actual scheduling of threads is done by Windows. It is because of this inherent dependency on the Windows scheduler that this port cannot be timing accurate. As @amazonKamath explained, Windows port is meant to speed up the development and not necessarily for timing accuracy. I am closing this - feel free to re-open if you need anything else.
Thanks.


Speed up Get_IsColonist_Polymorphed

Uses note from jecstools source code to point out that GetComp() is slower than a for loop checking for is CompPolymorph. Speed tests show a difference of average .8 ms to .3 ms on 4 times speed with dubs performance analyzer

Change Get_IsColonist_Polymorphed to a postfix. Check faction first as there are often more non-faction pawns than faction pawns (animals are the exception). Should still be better performance due to GetComp changes

Accepted


Option to set headers for services?

@nmaquet Is there a way to set headers for a service in the services list?

@nkoppisettyintu There's currently no way to set the headers from the config file.
It is however possible to do it from a plugin. You could have a plugin similar to this:
type MyPlugin struct {
	bramble.BasePlugin
}

func (p *MyPlugin) ApplyMiddlewarePublicMux(h http.Handler) http.Handler {
	return http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
		ctx := r.Context()
		ctx = bramble.AddOutgoingRequestsHeaderToContext(ctx, "My-Custom-Header", "some value")
		h.ServeHTTP(rw, r.WithContext(ctx))
	})
}

See here https://movio.github.io/bramble/#/write-plugin for more info on how to write a plugin.
I'd be interested to know what's your use case for that if you don't mind sharing it?
If it's a common pattern we might consider adding it as a built-in plugin.

Hi @Ackar,
Bramble is trying to connect to my service to introspect the schema but my service is rejecting bramble request as it is expecting some authorization headers. This is happening even before a client request to bramble. It fails in update() method of introspection.go of bramble.
I am getting this error - "error":"the schema is missing a Query type","level":"error","msg":"unable to update service".

Thanks for explaining your use case @nkoppisettyintu.
Unless you have a common authentication for all of your services, I think the plugin approach I recommended probably wouldn't work here as it would always use the same value for every service.
We would need to change the plugin interface to add a new hook on requests to services.
Just for some background, our usage of Bramble (and the way we designed it) makes it so that Bramble is handling authentication and subsequent requests to services are unauthenticated. That way we have a central point where authentication and authorization can be handled.
This is why there is currently no built-in way to authenticate with services.


⚠ Processors has degraded performance

In 6871c3b, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 48 ms

Resolved: Processors performance has improved in 8412506.


Strip @tool away from pre-processed sources.

Since you simplify Engine.is_editor_hint() calls, you can also get rid of @tool.

It is already configurable, but we can make this the default behavior.
https://github.com/dalexeev/gdscript-preprocessor/blob/abe1993e2d8db9a3c6a67c1678366491adcbe4f6/addons/gdscript_preprocessor/export_plugin.gd#L28


Missing SharePoint 2019 support indication

Missing SharePoint 2019 support indication

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52f7582c-c2a6-87bb-d236-2066e727c90c
Version Independent ID: 1cbc7ee7-2518-137a-f6d6-d1d62a1a1bc3
Content: What can Azure Backup Server back up
Content Source: articles/backup/backup-mabs-protection-matrix.md
Service: backup
GitHub Login: @markgalioto
Microsoft Alias: markgal

@paololec it doesn't seem to be supported officially yet since I couldn't find any official release notes regarding this support.
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


How does this solve the issues that mawie81/electron-oauth2 had?

Another oauth2 library for handling the oauth flow for Electron was https://github.com/mawie81/electron-oauth2
It was archived by the author as it wasn't safe for use in production because it stored the secret key client side - meaning that anyone could uncompress the .asar in production & grab it.
I do see the examples include a secret property in the info passed to the oauth2 function so I'm unsure if I'm just missing something or this library faces the same issue as the ones linked.
@aguynamedben is this something you could possibly chime in on? Considering your research when looking at mawie81/electron-oauth2

hello @AlexCatch thanks for writing.
There is a difference, this library just takes care of the process of authorization with oauth and how events work in electron. Secret management is responsibility of the final application.
The idea of the library is that you can pass either the main window or a different electron window from your application. This library does not even have electron as a dependency (it relies on the events of the window passed).
I might can give better ideas for security as part of documentation if you think is valuable.

I think the issue is that it almost encourages storing the private token in the bundle, this is a huge security concern as it takes all of 10 minutes to get the secret key.
The only safe option is explicitly allowing only the implicit grant flow or simply providing the code for the developer to send off to their own server for exchange to an access & refresh token.

What we ended up doing is this:

User needs to login to your site
When the user wants to OAuth, they do it through your site. OAuth tokens/secrets for upstream services are stored server-side on your server.
When OAuth is complete, the access/refresh tokens can be passed back to your app using the methods described in https://tools.ietf.org/html/rfc8252 or https://developers.google.com/identity/protocols/OAuth2InstalledApp (i.e. using <IP_ADDRESS>, Option 2 in the Google documentation)

This keeps your sensitive keys/secrets protected on your server side, but allows the user to OAuth with them and pass the access/refresh tokens back to your Electron app.

I think your main concern is Storage of key and secret of your app key and token, not user ones. Correct?
I will reiterate myself on that being part of the responsability of the electron application not the llibrary used for oauth, meaning is out of the concerns I have in my implementation of the library.
If you have a backend your option is fully valid. But there are apps with no backends using for example social login. As explained there are other options if the app does not have this backend.
The idea for node-keytar should be during installation provide already the keys of your app to the system. Rellying then in the OS and not on your code to store the keys (removing your concern on stored passwords on the code).
Again I will say I think this is something where each app needs to do their own threat modeling, and see wich is the best solution. Like allways there is no one size fits all.

(closed because it does not reffer to an issue on the library, is a technical discussion)

during installation provide already the keys of your app to the system

How does this work on your app? Do you package the key/secret in you app's asar? The problem here isn't "where are key/secret stored?", it's "is anybody in the world able to access my app's OAuth key/secret and subsequently pretend to be my app?"

At minimum I think the safest thing to do for the Electron community is to put some notes in the README around key and secret and point out the risk of packaging an app's OAuth key/secret in the asar. You're right, security is always specific to the app/code being written, but there's no reason to not document it. The current README will leave less security-inclined developers to package their key/secret.
Did you read RFC 8252 as I recommended? That's the current best practice for Electron+OAuth as far as I know.


#678 - Fixed FFPMEG file name in installation script

Forced PowerShell to use TLS 1.2 to resolve Python download issues due to PowerShell defaulting to TLS 1.0

.Net itself only support up to 1.2 (https://msdn.microsoft.com/en-us/library/system.net.securityprotocoltype(v=vs.110).aspx) and it looks like 1.3 is still in draft status (https://tools.ietf.org/html/draft-ietf-tls-tls13-28) so I don't know when support for that will be available.


Some metrics don't work on CPU using float16

🐛 Bug
It looks like some metrics such as Precision-Recall curve don't work on CPUs when using float16, perhaps due to a missing feature in pytorch?
Please reproduce using the BoringModel
https://colab.research.google.com/drive/1xDv043rRi5WBshP4m5aoxTt2ChlfxjIk?usp=sharing
Expected behavior
the metrics should work in half precision on CPUs as well.
Environment

CUDA:

GPU:

Tesla T4

available:         True
version:           10.1

Packages:

numpy:             1.19.4
pyTorch_debug:     True
pyTorch_version:   1.7.0+cu101
pytorch-lightning: 1.1.2
tqdm:              4.41.1

System:

OS:                Linux
architecture:

64bit

processor:         x86_64
python:            3.6.9
version:           PyTorchLightning/pytorch-lightning#1 SMP Thu Jul 23 08:00:38 PDT 2020

looks like this was fixed in https://github.com/pytorch/pytorch/commit/5d93e2b8180a495b6e78467ac470758134aac983


[MAISTRA-551] Run sidecars with dynamically-determined user IDs

Squashed commit, incorporates changes from:
* MAISTRA-551 Run sidecar with a dynamically-determined runAsUser ID
* MAISTRA-611 Partial injection of just the annotation and runAsUser id
* MAISTRA-668 Fix expected output of webhook injection
The sidecar injector now sets the securityContext.runAsUser field
  regardless if it is specified in the sidecar template or not. This is
  to allow the sidecar template to not include the field, which is
  required to ensure that istioctl kube-inject outputs manifests that
  pass the SCC admission controller (if the runAsUser is specified, the
  SCC controller will reject the pod, as the uid won't be in the proper
  range). The sidecar injector then injects the correct runAsUser id even
  if it isn't specified in the template.
Update to run make gen on istioctl as well so that that picks up the Proxy UID changes as well
Co-authored-by: Marko Lukša<EMAIL_ADDRESS>

/test integration


[SUGGESTION] Teleport to a random structure

Is your feature request related to a problem? Please describe.
Was looking for a convenient way for my gf to look at places of interest in heavy modpacked worlds and found RandomTP and #5 in particular
Describe the solution you'd like
The most dumb version in my mind is just to take player to coordinates of structure randomly chosen from a list using something like /structrtp
Describe alternatives you've considered
none
Additional context
none

This is indeed a interesting suggestion. I will mark it as accepted and take a deeper look into it.


Migrate to GetMetricData api calls and reduce listMetricsRequests

I've recently pulled down the latest changes that have been added and with the same configuration as I had before I'm now getting throttled:
panic: Throttling: Rate exceeded
        status code: 400, request id: cad3e71a-687a-4406-ac9a-e5b9021bd347

goroutine 351 [running]:
main.getMetricsList(0xc000870210, 0x1, 0x1, 0xc0002bb090, 0xc000234b40, 0x17, 0xc0001f5fc0, 0x1, 0x1, 0x0, ...)
        /opt/aws_cloudwatch.go:260 +0x191
main.scrapeDiscoveryJob.func2(0xc0002bb000, 0xc0004dd4c0, 0xc0001725a0, 0xc3c200, 0xc0002c0020, 0xc0002e0100, 0xc000664800, 0x13, 0x20, 0xc000332320, ...)
        /opt/abstract.go:150 +0xd4
created by main.scrapeDiscoveryJob
        /opt/abstract.go:146 +0x451

This wasn't as issue before commit: 1b81d6720f9a7f09871211ea6f6bb22bcde1b5ac
Changes since then: https://github.com/ivx/yet-another-cloudwatch-exporter/compare/1b81d6720f9a7f09871211ea6f6bb22bcde1b5ac...master

I've kind of reach the point at which I think using GetMetricData is going to really be the only way I'll be able to get this exporter to work for me given the number of metrics and number of instances I'm querying against.
Are there any plans to use GetMetricData for bulk API calls?

How many metrics do you have?

We've had to scale back what we were gathering from CW significantly (even after getting our API call quota increased by AWS).
As of right now our environment for yace looks like this:

RDS we are scraping 45 instance from CW for ~46 CW Metrics
ALB we are scraping 28 instances from CW for ~10 CW Metrics -- Plus the associated Target Groups
ELB we are scraping 14 instance from CW for ~6 CW Metrics

Even with the API quota increased by AWS we regularly see throttling happen which then leaves gaps in the time series.
We'd like to add NLB's, Lambdas, and a few others but at the moment we can't as a result of the throttling. Bulk collection of metrics using GetMetricData would significantly reduce the number of API calls we are making which would allow us to scale properly.

It actually seems like there are two places I'm being throttled at.
One being the GetMetricStatistics and the other at ListMetricsRequest which has a maximum of 25 transactions per second.

Thanks for the insights. Will dig this down on Friday. Will try to add so many metrics in our collector till i get the problem as well.

How often do you scrape? - Did you try out to set this to like 1m (i know a lot of people scrape every 15 seconds) @bheight-Zymergen

I think a move to GetMetricData would make totally sense but this would be a major refactoring of the whole project as things must be done completely different to do it nicely. Afraid of the development time currently. Will timebox this for two hours at the weekend and see how far i am able to get.

Docs:

https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_GetMetricData.html

Started my work but not much time today to get it running.
https://github.com/ivx/yet-another-cloudwatch-exporter/pull/101
Having another big project currently. Moving into a new flat next week. So could be a little bit boring here the next days. But it is on my roadmap. Read a lot over the api and i think it will be a hard cut to the way the exporter currently works but it it is worth it. Especially in terms of costs. I think our company will add a lot more metrics to prometheus if it is cheaper in the future. So maybe i can do some work there as well. Currently doing a lot in my free time.
Greetings, Thomas

How often do you scrape? - Did you try out to set this to like 1m (i know a lot of people scrape every 15 seconds) @bheight-Zymergen

Sorry for the delayed response I was on vacation in an area with no coverage.
Our scrape job for metrics is every 60 seconds.

https://github.com/ivx/yet-another-cloudwatch-exporter/pull/118
Looks like someone got around to this before I finished up mine.


758 assign lead

Implements #758

@AntBush this one is completed and ready to go. Though as I mentioned the use of relay fragments could be improved.


M3-5196: React Query for Volumes - Volumes Landing

Description 📝

The goal with part 1 is to get the Volumes Landing and all associated actions such as attach, delete, etc working

How to test 🧪

Test only Volumes Landing features at http://localhost:3000/volumes

Check all actions/mutations possible in the Volumes Landing Action Menus
Check that Landing table updates accordingly following actions such as attach, delete, clone, etc...

@jdamore-linode Can you check e2es on this?


Delete .DS_Store

life will be so much better without DS Store
dont worry about merging this until we pass 50 commits, its a special number and cannot be wasted on this!

—
Reply to this email directly, view it on GitHub
https://github.com/RetiredLake9230/CanadaMath/pull/1#issuecomment-1455014000,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AY754IQ47WIBLOORXNTPSJLW2Q62FANCNFSM6AAAAAAVQAGZ4E
.
You are receiving this because you were assigned.Message ID:
@.***>


Angular2 (>=rc7) dependency warning: "Critical dependency: the request of a dependency is an expression"

Steps to reproduce and a minimal demo of the problem

git fetch --all && git checkout chore/update-angular2-final-release
npm run build
observe webpack warnings

Current behavior

webpack outputs warnings:
WARNING in<EMAIL_ADDRESS>45:15 Critical dependency: the request of a dependency is an expression

WARNING in<EMAIL_ADDRESS>57:15 Critical dependency: the request of a dependency is an expression

Expected/desired behavior

no warnings

Solution
UNTESTED
webpack.config.js
module.exports = {
  plugins: [
      new webpack.ContextReplacementPlugin(
        // The (\\|\/) piece accounts for path separators in *nix and Windows
        /angular(\\|\/)core(\\|\/)(esm(\\|\/)src|src)(\\|\/)linker/,
        root('./src') // location of your src
      )
  ]
}
function root(__path) {
  return path.join(__dirname, __path);
}

Other information & resources

Bug introduced in Angular2 starting with RC7, reported in angular/angular

issues/11580

Issue also reported in AngularClass/angular2-webpack-starter

issues/993
fixed by pull/998

Just tested solution and its working. will add that to PR #95

Fix pushed to #95