add correct favicon.ico

Adding correct .ico file to be displayed as tab logo

You may also need to specify it in the make file of the docs https://github.com/PTsolvers/Chmy.jl/blob/main/docs/make.jl#L12


ENYO-1332: adjusting the content inside button according to the specs

The content inside the button extends beyond the curvature of the
button, which is a deviation from specs.
Padding of the button is increased to make content align with in the
curvature.
Enyo-DCO-1.1-Signed-off-by: Rajyavardhan P<EMAIL_ADDRESS>

Closing PR per Rajyavardhan; no longer needed.


Catch illegal timestamp value

When using this on my Photos database, it threw a ValueError. I wrapped the fromtimestamp() call in a try block so that it would continue with the oldest date allowable.

Thanks!  @scanner reported the same issue.  I'd not previously seen illegal time values in the library.


Artifacts are not scanning. And the system scans the total number of wrong artifacts as well.

This is has been reported. Can you post a screenshot of the top right of your inventory where it says Artifacts xxxx / 2000?

Artifacts 0 / 18

Sorry, I'm late.

No description provided.


vertical bar in _cdf functions to match _lcdf and _lccdf

Summary:
Now the CDFs (non-log scale) use , instead of | but we should make them consistent with the log scale versions.
Current Version:
v2.11.0

Closing this issue as we now have a stanc3 issue for it, which is the proper place for it: https://github.com/stan-dev/stanc3/issues/854


mayastor: Add flag for polling Reactor incoming thread queue

Add has_incoming flag to Reactor to indicate that there are incoming threads to poll. This avoids polling the incoming thread queue too frequently.

This is where my rust knowledge is still not up to scratch yet but I wonder if has_incoming needs to be "volatile" here (or whatever the rust construct is), otherwise it could be optimized into a register since the compiler does not "see it change" in the polling loop?

@tiagolobocastro You're right, Cell is not thread-safe, I switched to using AtomicBool instead

This is where my rust knowledge is still not up to scratch yet but I wonder if has_incoming needs to be "volatile" here (or whatever the rust construct is), otherwise it could be optimized into a register since the compiler does not "see it change" in the polling loop?

@tiagolobocastro You're right, Cell is not thread-safe, I switched to using AtomicBool instead.
volatile is not sufficient as it only prevents compiler optimization, but doesn't provide shared memory between threads, which means that poll_times() could read has_incoming as false even though it has been set to true in schedule(). volatile in Rust is only useful for accessing memory that can be modified outside the application (eg. memory-mapped I/O registers), is it useless for multithreading.

In this case the code is actually run by the same thread... but it's called through the spdk_thread_create "in C" and so the rust compiler might not have "visibility" over this which is why I suggested the volatile.
I did not raise this issue but as I understand it, what we're trying to avoid here is the cost of polling the atomic incoming queue and thus why we're trying to avoid atomics here so we just need the compiler to check the actual memory everytime (changed by the same thread) and not "cache" the flag in a register.

The original patch -- i.e. without the atomic bool was indeed correct. I would be interested in the numbers pre/post-patch.
We can obtain this with ”casperf -b 512 -q 64 ’malloc:///disk0?size_mb=100’” I think that even with debug build it would already show an improvement

@tiagolobocastro @gila thanks, I now understand that poll_times() and schedule() are called from the same thread. I've dropped the AtomicBool change.
In other words, your original code was what we want I think, just need to check that the code generated is correct 👍

Sorry I'm kinda new to Rust, how can I see the generated code?
The original patch -- i.e. without the atomic bool was indeed correct. I would be interested in the numbers pre/post-patch.

We can obtain this with ”casperf -b 512 -q 64 ’malloc:///disk0?size_mb=100’” I think that even with debug build it would already show an improvement

Unfortunately I am unable to fully compile and run the project, it fails with "version GLIBC_2.32' not found" (with nix-shell`).

IIRC @blaisedias hit similar glibc issue recently?

We recently bumped nix packages so perhaps there is some overlap. Could you exit (all of them!) nix-shell and run the garbage collector and re-enter the shell?

We recently bumped nix packages so perhaps there is some overlap. Could you exit (all of them!) nix-shell and run the garbage collector and re-enter the shell?

Thanks, that worked.
However, when I run ./casperf -b 512 -q 64 'malloc:///disk0?size_mb=100', it fails with:
EAL: No available hugepages reported in hugepages-2048kB
After running echo 512 | sudo tee  /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages, casperf fails with:
EAL: 512 hugepages of size 2097152 reserved, but no mounted hugetlbfs found for that size
I then tried running:
mkdir -p /mnt/huge
sudo mount -t hugetlbfs nodev /mnt/huge

and it now fails with:
EAL: Couldn't get fd on hugepage file
I'm not sure if this has to do with me running on WSL.

I tried the Docker approach as well, but running cargo/rustc throws SegmentationFault

I'm closing this PR as it hasn't been active for quite some time already. If the author wishes to continue in this effort, feel free to re-open. thanks


Added neovim compatibility

for issue #20

What are the consequences of #20 for you? I'm using neovim and haven't seen issues:
🤔 ~/.v/p/vim-snipe
[i]: vim --version
NVIM v0.2.2-5-ge98bcf0
Build type: Release
LuaJIT 2.0.5
Compilation: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -O2 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -I/Users/travis/build/neovim/bot-ci/build/neovim/build/config -I/Users/travis/build/neovim/bot-ci/build/neovim/src -I/Users/travis/build/neovim/bot-ci/build/neovim/.deps/usr/include -I/Users/travis/build/neovim/bot-ci/build/neovim/.deps/usr/include -I/Users/travis/build/neovim/bot-ci/build/neovim/.deps/usr/include -I/Users/travis/build/neovim/bot-ci/build/neovim/.deps/usr/include -I/Users/travis/build/neovim/bot-ci/build/neovim/.deps/usr/include -I/usr/local/opt/gettext/include -I/usr/include -I/Users/travis/build/neovim/bot-ci/build/neovim/build/src/nvim/auto -I/Users/travis/build/neovim/bot-ci/build/neovim/build/include
Compiled by<EMAIL_ADDRESS>
Features: +acl +iconv -jemalloc +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/share/nvim"

Run :checkhealth for more info

So I looked a bit further into it, and apparently the neovim in the ubuntu repositories is just super outdated (should have expected that). Current version works perfectly and I should just upgrade my copy.


Encryption

Is your feature request related to a problem? Please describe.
Can you please add encryption like your hive package, it will be super userful.

#292


Capture email address, address etc

Hi,
We're looking for something like cla assistant to manage CLAs for our projects.
I took a look and it only seems to captire github username. I'm not sure this is really enough information in order to identify a signer as anyone can just create a github account.
Is there any way of exposing, at the least email address too? It would also be great if the user could input extra fields such as address when signing the CLA.

Hi,
can you take a look on the issue #64
You can use "custom fields" for requesting users to enter their e-mail-address and others.

Thanks. Is there any documentation / guide that explains how to setup these extra fields?

yes, our README.md 😄
check the "Request more information from the CLA signer" section
If something is still unclear feel free to raise your questions here

Thanks. I have created a gist here:
https://gist.github.com/purplefox/9e9ce33631d631ac3b7af6ff8cc730c1
But I get an error when trying to sign the CLA:
====
There is no CLA to sign for Tesco/mewbase
(Unexpected string in JSON at position 103)
Seems like something wrong with the JSON, but not sure what. Any ideas?

yes, there is a comma missing after first "githubKey": "name"

Thanks I corrected that and now get:
(Unexpected token < in JSON at position 250)

So.. I replaced the JSON with the exact same one from your README and it works, then I tried removing the "category" field as we don't want it, and get the same error again.
So it seems that a field called "category" is mandatory. Is there any way around this as we don't want to give users this choice?

hmm... it works for me also without category
here is the gist, i forked from yours:
https://gist.github.com/KharitonOff/3cc2554f1b5da6659911022642909ec2
and the linked repo:
https://cla-assistant.io/kharitonoff/cla1

I assume everything is working fine for you now...

Still can't get it to work without category.... but I can live with that
for now.
On Tue, Nov 15, 2016 at 8:37 AM, Anton<EMAIL_ADDRESS>wrote:

Closed #178 https://github.com/cla-assistant/cla-assistant/issues/178.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cla-assistant/cla-assistant/issues/178#event-859044325,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAq10g1kEuM0MZ0Az4xWbdAT30KyTe6vks5q-W9lgaJpZM4Kv1XV
.


Removes key prop on inner components of Textfield

This will fix #197 (cc @aaugustin)
The key prop on the input was the cause of the issue. Because the key changed, React was removing the element, and adding a new one. But because the whole textfield was never removed from the DOM, the function componentWillUnmount on the MDLComponent was never called.
This codepen shows the fix in action: http://codepen.io/anon/pen/EPRLww

Thanks a lot for working on this!
I tried running a version with this change in my development environment to check that it fixes my original issue. Unfortunately I failed, due to my lack of knowledge of npm.
My latest attempt was:
cd node_modules
rm -r react-mdl
git clone https://github.com/tleunen/react-mdl.git
cd react-mdl
git checkout 1c926e9a5835349fc318667070b697704b019cb7
npm install
npm run compile

At this point, my app fails with:

Error: addComponentAsRefTo(...): Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component's render method, or you have multiple copies of React loaded (details: https://fb.me/react-refs-must-have-owner).

This must be because node_modules and node_modules/react-mdl/node_modules each have their copy of React.

Based on what I found on stackoverflow, it seems to be related to multiple React versions, as you suggest. It might be because the version you're getting uses React 0.14.7, and you're using something else. If you're using Webpack, you can try to add this plugin to remove duplication.
If it doesn't work, one other hack could be to compile the file, copy it somewhere, reinstall the default npm version, and put back the saved compiled Textfield.js ;)
Note that instead of getting the commit, you can also use the branch name issue-197

Indeed, I could run the new code by compiling react-mdl and replacing the node_modules/react-mdl/lib by the compiled output.
This patch clearly goes in the right direction.
Truth be said, I could still break your latest codepen as follows:

open http://codepen.io/anon/pen/EPRLww
click in first field
type "foo"
click on toggle
click on second field
type "bar"
click on toggle
click on first field
select all text and remove it
click on toggle

At this point, the "bar" text is superimposed on the "second" label.
Admittedly, it's an edge case. I'm not sure how much effort it is reasonable to put into fixing it!

@aaugustin This is because findDOMNode was not defined in the code of the pen.
I fixed it by adding var findDOMNode = ReactDOM.findDOMNode; and I can't reproduce your issue ;)
http://codepen.io/anon/pen/EPrywo

I guess we're good, then. Thanks a lot for your investigations on this issue!

np, thanks! :)


Depending on precision, inconsistent float behavior across STDOUT, debugger, and memory in GDScript.

Godot version:
Godot 3.2.1 Windows (non-Mono)
OS/device including version:
Windows 10 (x64)
Intel Core i5-8600K
Issue description:
BLUF: Floating point number handling is inconsistent with precision greater than three 9s and less than eight 9s.
When using floating point numbers (in GDScript) close to a whole number, the behavior of the rounding that may occur is different across different components of the software at different precisions. For example:
A float with a value of 0.999 is accurate in stdout, debugger, and memory. (OK)
A float with a value of 0.999999 is accurate in stdout. Rounded up in debugger and memory. (BAD)
A float with a value of 0.9999999 is rounded in stdout and debugger. Accurate in memory. (BAD)
A float with a value of 0.99999999 is rounded in stdout, debugger, and memory. (OK)
I found this issue by storing integers in instances of Vector2(float, float). I expected to be able to cast the coordinates with int() when required. At one point I was dropping slightly below 1 because I performed a 180 degree vector rotation. Everything was showing a correct transition from -1 to 1, but when I cast the 1 with int(1), I would get 0.
I've added some screen captures of each of the different precisions to show the different states of Godot/GDscript, its stdout, its debugger. Memory access is limited in GDScript (without Native), so I deduce the memory state by indirectly invoking whatever hash algorithm is used to de-reference Dictionary entries. Blue highlighted area indicate expected behavior and orange highlighted areas indicated unexpected behavior.

Steps to reproduce:
See the minimal project.
Minimal reproduction project:
You can see the behavior in the following project. Add breakpoint to line 11 of the script attached to top Node of Node.tscn.
MisleadingRound.zip

This is a duplicate of #288, see also #17971 and #27665.


Landscape view

Create landscape view for the android app.
Closes #20
:ballot_box_with_check: Definition of Done checklist

[ ] Meaningful title and valuable description in pull request
[ ] Code change tested manually if not covered by automated tests
[x] Pull request linked to one or more issues/stories
[ ] Acceptance criteria of the linked stories satisfied
[ ] Code change comprehended by those who approved it
[ ] State of target branch maintained or improved after the code change

The changes seem to work, but why was onPause() removed?

onPause() method was actually lose the mqtt connection when you rotate the emulator in android application to landscape.

All good to go then


Passing cors "*" to rest api doesn't work

If you pass "*" cors doesn't allow every origin.
Solution:
Figure out how to support multiple origin splitted by "," as well as regex.

I’d like to take a crack at this, is it still open?

yes, ill assign you

@jahosh Let us know if you found any roadblocks on this issue.

is this still open?

is this still open?

Most likely, could you verify locally to check if still an issue?

Ok

we use fastify?

Yeah, most/all of the code is currently here: https://github.com/ChainSafe/lodestar/tree/master/packages/lodestar/src/api/rest

cors setup is already there: (if opts.cors is set to be an array of urls/regex that would also work)

without passing anything, its already building options of *

also tested the http headers returning *:

I guess issue is no more relvant and can be closed

Thanks!


404 Not found on some pages

🛑 IMPORTANT: You can get your feedback addressed faster if you use the comment section for the article in which you encountered a problem.
Link to article:
http://msdn.microsoft.com/en-us/library/windowsazure/dn451351.aspx
Problem:
What's wrong with the article?
Windows Azure Desktop Hosting - Reference Architecture and Deployment Guides.  404 not found

@ickacn When I click the above link. It works now, and the page said: "This information has been moved to the Windows Server library on TechNet. You can find the information at https://technet.microsoft.com/library/mt404690(WS.11).aspx"


slot type not really just a documentation

Hi,
In 2020-12-11-cl-tut-10b-classes1.md, you state "The type option is another hint to programmers...".
What the CLHS  says:

The :type slot option specifies that the contents of the slot will always be of the specified data type. [...] The consequences of attempting to store in a slot a value that does not satisfy the type of the slot are undefined.

So be warned, this is not a hint to programmers, it is a promise to the compiler, and if you break that promise, anything can happen.
That being said, for example sbcl manual says

Types declared using the :type slot option in defclass are asserted if and only if the class was defined in safe code and the slot access location is in safe code as well. This laxness does not pose any internal consistency issues, as the CLOS slot types are not available for the type inferencer, nor do CLOS slot types provide any efficiency benefits.

so what you observed is what you really get in sbcl outside of safe code:

(locally (declare (optimize (safety 3)))
(defclass foo () ((a :initarg :a :type integer)))
(make-instance 'foo :a 'a))

throws appropriate type error.

Thanks for letting me know, I'll have a play (so I understand it better) and write up a correction 👍

@zellerin Are you satisfied with the presentation of the corrections you have offered?

I do not know who is your audience and so whether it is not too much detail for them compared to the rest of the text, but I have no objections - these are your pages :)

It's more from a credit perspective, but if you're fine with it I may tweak the tone or something a little, but generally keep the content, thanks again!

No credit required :)


Scenario failure - pfs6_simple_path_rewards.yaml - 16.08.2019

Description
No feedback in monitoring channel
DevOpsBot @DevOpsBot Bot 04:53
Starting run for scenario pfs6_simple_path_rewards
Logs
Error: Invalid value for "[SCENARIO_FILE]": Could not open file: /raiden-upstream/raiden/tests/scenarios/pfs6_simple_path_rewards.yaml: No such file or directory

Fixed by @ulope

The prepare step breaks on the issue with the dev requirements we had yesterday and therefore doesn’t rebuild the docker image which means the file is missing in there


Add to the 120 credits on repeated courses

Summary
Resolve #141.
Implemented according to my proposal during the meeting:

Lifting the total credits requirement out of the generated requirement json and special case it on frontend
As a result, it will not become part of requirement graph as desired.
In addition, the requirement json dropped from 2.5M to 800k!

Test Plan
Repeated courses now correctly count towards 120 credits:

AAP: no college req as expected.

A&S: correctly counted

Business school: correctly counted

CALS: correctly counted

Engineering: no such requirement as expected

Human ecology: correctly counted

ILR: correctly counted

Thank you so much Sam! I requested some smaller changes but everything looks mostly good. To note: I'm not sure if we can say that #141 would be completely resolved by this PR though, because the issue discusses how if the user repeats a course, the min total number of academic credits would increase by the number of credits of that course. Though the credits of repeated courses are taken into account for the total academic credits, the number still remains at 120.

@tcho6319  I'm not sure if I understand the question. Is there an counterexample that shows this PR doesn't solve everything in that issue.

Thank you so much Sam! I requested some smaller changes but everything looks mostly good. To note: I'm not sure if we can say that #141 would be completely resolved by this PR though, because the issue discusses how if the user repeats a course, the min total number of academic credits would increase by the number of credits of that course. Though the credits of repeated courses are taken into account for the total academic credits, the number still remains at 120.

@tcho6319 I'm not sure if I understand the question. Is there an counterexample that shows this PR doesn't solve everything in that issue.

For example, since I have CS 1110 twice in my schedule, that would mean that I repeated the course. Based on the policy re: repeated courses, the total number of academic credits that I would need to graduate should increase from 120 to 124 because CS 1110 is 4 credits. In the screenshot, we see that the minimum number of credits remains 120.

Also, this is more related to the second point about 10xx level courses, but the required number of credits I need to graduate is 121 total academic credits because I took ENGRG 1094 (a supplemental class for lin alg), which is 1 credit.

It turns out that handling the increase isn't hard, so I just included it there.


setMaxDate does not prevent max date picked when changing year

In v1.51
The method setMaxDate greys out dates after the date specified and prevents the user from selecting these dates by clicking on the greyed out date number. However if the user sets to a day/month in a previous year and then advances the year by clicking year and selecting the next year, the unelectable date will be highlighted and user is allowed to click OK to accept this.

Good catch.
I already fixed some edge cases in the original code when I updated this a while ago, but this one is new.
Just a quick question: what would you expect to happen when you select a higher year in the year picker?
Do I discard your date selection and set it to the maxDate?
Or do I not render the next year when it would push the currently selected date beyond the maxDate? (That would lead to situations where 2015 would render if you currently have 01-Oct selected, but not if you have 02-Oct selected and the maxDate is 01-Oct-2015)

Indeed! The options seem to be

Disable year picker if current date + 1 year is > max date
Allow year picker for current date year + 1 but set date to max date if current date + year > max date
Allow year picker for current date year + 1, set date to current date + 1 year but disable OK button.

None of them seems ideal to me however. A compromise might be to do 2 but animate setting the date backwards to max date from current date + 1 year to emphasise that it is beyond max date. So process could be

Select year picker
Pick next year
Date is set to current date + 1 year, shown briefly to user
Animate scrolling back to max date if max date < current date + 1 year

What do you think?

I'll probably go for 2.
Animating this is a nice idea, but I have no idea how hard that would be to do.
Thanks for the input!

Thanks, is this available on Maven-central yet?

Not yet.
I'll try to publish the latest version today or tomorrow.


Can you release the config file of Conv4 in miniImageNet and CIFAR_FS?

I want to reproduce you result,  and I believe different configurations have big impact on the final result. So can you release the config file of Conv4 in miniImageNet and CIFAR_FS? Thank you very much.

Hi,
We are organizing the config files you asked. It should be released soon.
For config file of convnet + mini-imagenet + 5way-5shot, please refer to issue #1
Best,
DPGN team


Fix invalid file permissions for running sstable related commands

I had trouble to execute all tools except run_sstable2json(). So I moved the permission checking code from there into a new method find_cmd() which is called by all other run* methods for retrieving the path to the command with fixed permissions.

Thanks for the PR, and this looks good, but can you close this and open a new PR targeted towards the develop branch? It's big enough that I'd like it to have some time getting tested before it goes into master.


HoTT with impredicative universe

@awodey asked if we can have a HoTT mode with an impredicative universe.
I recall that the HoTT mode and the standard mode are two instantiations of the Lean kernel, and that we can already instantiate it in a third setting - without proof irrelevance in Type.{0}, but with impredicativity. If so, how do you do this?

to be more specific — an impredicative universe that is not proof irrelevant (and perhaps containing some non-trivial types, like nat).
SA

On Mar 31, 2015, at 6:32 PM, Floris van Doorn<EMAIL_ADDRESS>wrote:
@awodey https://github.com/awodey asked if we can have a HoTT mode with an impredicative universe.
I recall that the HoTT mode and the standard mode are two instantiations of the Lean kernel, and that we can already instantiate it in a third setting - without proof irrelevance in Type.{0}, but with impredicativity. If so, how do you do this?
—
Reply to this email directly or view it on GitHub https://github.com/leanprover/lean/issues/523.

I added the branch https://github.com/leanprover/lean/tree/imp_hott
Type.{0} is impredicative and proof relevant.
Here is a small example
variable a : Type₀

inductive nat₀ : Type₀ :=
| zero : nat₀
| succ : nat₀ → nat₀

check ∀ A : Type, nat₀
-- Prints Type₀

Disclaimer: I had to disable the following automatically generated constructions for inductive datatypes: no_confusion and brec_on.
I had to comment some theorems from the HoTT library.
Moreover, since no_confusion and brec_on are not available, we cannot use recursive equations.
This is why I put this experiment in a separate branch.

That was fast!
Thanks - that will be interesting!
Steve
Sent from my iPhone

On Mar 31, 2015, at 7:51 PM, Leonardo de Moura<EMAIL_ADDRESS>wrote:
I added the branch https://github.com/leanprover/lean/tree/imp_hott
Type.{0} is impredicative and proof relevant.
Here is a small example
variable a : Type₀
inductive nat₀ : Type₀ :=
| zero : nat₀
| succ : nat₀ → nat₀
check ∀ A : Type, nat₀
-- Prints Type₀
Disclaimer: I had to disable the following automatically generated constructions for inductive datatypes: no_confusion and brec_on.
I had to comment some theorems from the HoTT library.
Moreover, since no_confusion and brec_on are not available, we cannot use recursive equations.
This is why I put this experiment in a separate branch.
—
Reply to this email directly or view it on GitHub.

I'm closing this issue since we have the branch https://github.com/leanprover/lean/tree/imp_hott.
Remark: to make this feature official, we would also have to support two versions of the HoTT library.

I’m not sure what would be involved in supporting two versions of the HoTT library, but I’m glad this is available for experimentation.
Perhaps it doesn’t really have to be “official”, whatever that involves?
Steve

On Apr 18, 2015, at 7:05 PM, Leonardo de Moura<EMAIL_ADDRESS>wrote:
I'm closing this issue since we have the branch https://github.com/leanprover/lean/tree/imp_hott https://github.com/leanprover/lean/tree/imp_hott.
Remark: to make this feature official, we would also have to support two versions of the HoTT library.
—
Reply to this email directly or view it on GitHub https://github.com/leanprover/lean/issues/523#issuecomment-94188090.


fix: Possible crash with EXC_BAD_ACCESS KERN_INVALID_ADDRESS at 0x1166800a0

Description
I got the following exception, reported by Sentry. I can't vouch for the bug since it was raised in debug (so maybe it's something that happened because of hot reload or something like that). But I file it anyway in case you have ideas.

Actually, now that I'm looking at the "breadcrumbs" (basically log history), it seems that this might have happened when I closed the app and the app tried to play a sound (the click sound of the "EXIT" button) while the app was being shut down.
Not sure if this is addressable, so feel free to close this
Steps To Reproduce

Try to create a condition where the app is exit()ing while a SoLoud::on_notification is called.

Oh WOW! What makes me think is the first line of your screenshot: "Crashed in non-app", which is odd I think.
My thought is that a hot reload does this:

the SoLoud.init() method is called just after a hot reload
since the init() method sees the player is already initialized, it will deinit() it
meanwhile the state changes and the SoLoud::on_notification didn't realize yet a new address of the newly initialized player

Or maybe after a hot reload the Flutter main isolated is terminated and re-executed, but the audio thread is not yet. So the state changes and the old audio thread fires the callback that doesn't exist anymore.
I would leave this issue open for a while to see also if that state notification can be useful in the future because now it's not.
Thanks for your finding.

I tried to use Sentry and I didn't see what you got. At least on Linux and Android.
Thinking about this, I created the branch state_changed that hopefully could fix this.
@filiph can you please try to use that branch to see if the error persists?

The thing is, I don't think I can reliably reproduce the issue. I didn't even notice it until seeing it much later in Sentry. I'm pretty sure the app closed just fine from the perspective of the user.
Feel free to close this for now. At the very least, it's good to have it here for SEO so that people searching for "EXC_BAD_ACCESS soloud" will get here.


Remove cask download strategies.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Remove cask download strategies and their corresponding specs.

If only every diff could be like this. 😄


Link changelog and license

Coverage remained the same at 87.963% when pulling 1fe756ea1b5690f3cf6fb7faaa1bae0638a045f3 on techtonik:patch-5 into 965a1f8bcdf640bbedb60c7d84a461df1cb0e1e1 on WoLpH:develop.

It may also worth to reorder changelog.

True, it's too bad that github doesn't support the full array of rst features otherwise an include would have been nicer. I'll play around with it :)

It supports markdown linking, but that would break the docs. =)


Openssl in coreutils makes *sum programs much faster (RFC)

sha256sum, md5sum,. run much faster. Factor 2x to 4x.
You can evaluate that by comparing the cpu time of your 'time sha256sum bigfile' and 'time openssl sha256 bigfile'.
What do you think? I use these a lot, and I guess that git-annex users too.

@GrahamcOfBorg eval

Ok. I'll merge it when these automatic tests finish.

Why was this merged to master instead of staging?

@dtzWill @mic92 my fault - I didn't think about staging and noone complained on the ->master PR so then I went on.
Why did you say that "openssl is not allowed in stdenv"?

coreutils is part of stdenv. To build stdenv there is a pre-build bootstrap tarball. To use openssl in stdenv it also needs to be part of the boostraping, I think.

https://hydra.nixos.org/build/78481294/nixlog/1/tail

would a stdenv.isLinux be enough? I don't know what's that Darwin condition.


Don't force users to write text in changeset comments

It wouldn't make them write a Good change-set comment, but any string.
You couldn't make them more meaningful if users do not agree with
http://wiki.openstreetmap.org/wiki/Good_changeset_comments
for every of their edit
Yes comments are strongly advised #2923 #2938 but not mandatory for every of your edit. Change-sets without comments will displayed as "uncommented" at osm.org.

Previously

It would be nice to suggest editors to provide a few words about what they were thinking they were doing. - May 2013 #1488

Maybe, if the user clicks on save without entering a comment, we could have a popup to nag him/her a bit more? - September 2014 #2370

I propose that the upload dialogue tells the user that changeset messages are useful and should not be omitted before prompting the user to go back and add one or continue without. - Feb 2014 #2118

There are ~20 issue comments on this topic. This is an opinionated area but the majority opinion is decided in favor of requiring comments, so closing here. Unfortunately we can't make everyone happy with respect to features like this one.

In my opinion, this issue makes sence. If you force users to comment while they don't have anything to say, then they will write some useless words just to get rid of this "stupid rule".

Yep, about 3 people have agreed with this viewpoint about 9 have rallied for the opposite viewpoint. I respect your opinion, but it's in the minority and if we implemented your desire, we'd get another round of complaints from the other camp. Alas, in cases like this, a majority is our best signal.

If you force users to comment while they don't have anything to say, then they will write some useless words just to get rid of this "stupid rule".

You're right that some users will always write something useless just to quickly advance past the dialog box.  We know and accept that.
However one of the main design goals of iD is to guide new OpenStreetMap contributors towards good habits.  So for this reason, we'll always prioritize the needs of a user who has never edited a map before over those of a user who simply wants to shave a few seconds off their editing time.

some users will always write something useless just to quickly advance
Well, I feel ashamed, because I am one of those users, to tell the truth

@bhousel, @tmcw fair close, okay let's not continue discussion No21, not worth it. But i wanted to show there opposite site of this (ein zweischneidiges Schwert)
http://www.openstreetmap.org/user/Anto110/history "правки", "правки", ...
https://www.openstreetmap.org/changeset/41433054 - alexkmbk "но при добавлении простого объекта, вроде родника или дороги, описывать это кажется лишним. " (when you add something trivial, like a spring, comments are superfluous)


[wip] splash:call_later

Current coverage is 84.63%

Merging #301 into master will increase coverage by +29.28% as of 8dad5e2

@@            master    #301   diff @@
======================================
  Files           38      38
  Stmts         4157    4184     +27
  Branches       537     541      +4
  Methods          0       0
======================================
+ Hit           2301    3541   +1240
+ Partial        160     146     -14
+ Missed        1696     497   -1199

Review entire Coverage Diff as of 8dad5e2

Powered by Codecov. Updated on successful CI builds.


Dynamic error messages for custom validations (Feature)

Hi guys,
I have read the forum and asked on Gitter, but I can not see how to dynamically change a custom validation's error message.
For UX reasons I want to have a text field that allows the user to just add a 'compound' date in the format MMM YYYY and I want to validate this. I want to validate the length of the month and year, make sure the month exists, that the year is within 60 years of now etc etc and would like to not have to make multiple repetitive validations with small changes. Sample code below(excuse simplicity):
Vue.validator('mmmyyyy', {
        message : 'Format should be MMM YYYY e.g. Feb 2006',
        check   : function(val)
        {
            if ( !val ) return false;
            var parts = val.replace(/\s\s+/g, ' ').trim().split(' ');

            // Only 2 parts
            if ( parts.length != 2 ) {
                 this.message = '2 parts are required MMM & YYYY';
                 return false;
            }
            var month = parts[0];
            var year  = parts[1];

            // MMM
            if ( month.length != 3 ) {
                this.message = 'Month should be short e.g. Feb not February';
                return false;
            }

           Etc ... (excluded for brevity)
        }

    });

I tried to convert the message property into a function, but was still unable to set the message.  I think this may be a useful feature for more complex validations.
i hope I didn;t miss and example somewhere.
Thanks in advance for your time.

Thank you for your feed backing!!
In v3, I'll try to consider your feedback. 😉
I think that the above complex custom validation code can avoid the splited custom validations.
the below code:
The below example code:
<input type="text" v-validate:field1="{
  required: true,
  custom1: { rule: ... },
  custom2: { rule: ... },
  ...
}">

new Vue({
  validators: {
    custom1: {
      message: 'validation error1',
      check: function (val) {
        // something simple validation
      }
    },
    custom2: {
      message: 'validation error2',
      check: function (val) {
        // something simple validation
      }
    },
    ...
  }
})

@kazupon Many thanks for the feedback, and that is just what I have done :)
Thanks for a fantastic tool .. excellent work!


fix customize form failing for nonadmin

📝 Description

Add a brief description

🎥 Demo

Please add a video or an image of the behavior/changes

/lgtm


Add multiarch support

Hi @tolkonepiu,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!


Add Feedback ID on mobile

Feedback button on mobile menu needs ID to be added: NAV_FDB
(ask the parent, not the child)

Should be resolved by #1232


Fix for 367 US PQ/ZR

I stopped at the fixed interface when I wrote to the toolbox (hint: the unit is not ready, the software update is not ready. Please wait a moment. It may take 10 minutes).
I try to press and hold the power key to restart, but it will still get stuck in this interface!
Please tell me how to restore the unit.
Thank you!
It's my fault that I'm a novice.

For the nav unit, can I restore it through the SD card?


Added the tensorflow pip package

https://pypi.python.org/pypi/tensorflow/0.12.1.
Google's framework for neural networks. This only provides the python interface; the C++ API is trickier to get.

Updated.


hack.chat is encrypted?

Hello: I just want to know if hack.chat software is encrypted? I don't see it via FAQ or README. Let me know.

its using wss so afaik it should be encrypted

Ok, thanks.

Yes, the lock in your address bar (in the absense of a warning sign) shows that the connection, including all messages sent/received, are over a secure connection until they reach the hack.chat server and are parsed.

I should mention though that the hack.chat software hosted from this git repo does not have encryption by default. You have to configure your web server (Nginx in the case of https://hack.chat/) to serve static files and route a Websocket connection over HTTPS/WSS


withId and withName

Vanilla Identifiers support using strings to make actual identifier so I believe having jut Identifier be accepted is not the best
https://github.com/QuiltMC/quilt-kotlin-libraries/blob/2a4f49bb896c2e5716a11e315b6cc379428aab78/wrapper/minecraft/src/main/kotlin/org/quiltmc/qkl/wrapper/minecraft/registry/RegistryDsl.kt#L56
so withName is confusing as for me personally it reffers to a TranslatedText or LiteralText name
https://github.com/QuiltMC/quilt-kotlin-libraries/blob/2a4f49bb896c2e5716a11e315b6cc379428aab78/wrapper/minecraft/src/main/kotlin/org/quiltmc/qkl/wrapper/minecraft/registry/RegistryDsl.kt#L68
So a proper withId would be as such
public infix fun T.withId(id: Identifier) {
    Registry.register(registry, id, this)
}

public infix fun T.withId(id: String) {
    Registry.register(registry, if(":" in id || modid == null){
        Identifier(id)
    } else {
        Identifier(modid, id)
    }, this)
}

Mean to take on this job.

also noticed discrepancy with actual behaviour at https://github.com/QuiltMC/quilt-kotlin-libraries/blob/2a4f49bb896c2e5716a11e315b6cc379428aab78/wrapper/minecraft/src/main/kotlin/org/quiltmc/qkl/wrapper/minecraft/registry/RegistryDsl.kt#L63
which should be
     * If no `modid` is present, it uses `"minecraft:name"` format.


Scripts in protos

We have a few places where scripts are allowed to be stored in Data messages, especially for automation and ML preprocessing. For both readability and security, what would you think about replacing these Data messages with string url fields pointing to e.g. colab/jupyter notebooks---or even a blog post about how to build a model with these data?
This would sidestep the security issues of including executable code as part of the record, as well as allow for folks to easily update their scripts without needing to change the records in the database. I think it nicely decouples the data from the downstream applications in ways that are not possible with Data messages.

Additionally, this will ease the review burden by avoiding having to check that the code works, or really even worrying about that aspect of downstream usage---it would improve readability and more clearly emphasize the data itself during review.

Some thoughts:

I agree that it will be easier to review submissions if we don't have to look at this code. Plus, readability is an important consideration since big multi-line strings will look sloppy in the pbtxt format.

We will potentially lose some permanence (if that's the right word) by having scripts only exist through url pointers. How do we know that someone won't delete their public GitHub repo, gist, or Colab notebook where the example was kept? I recognize that we also have this limitation for our other string url fields.

Is it a security issue to have executable code if we never automatically execute it?

I think it's possible for these scripts to become dated over time. For example, suppose we had an example of someone building a ML model with Theano. Would we want to eventually overwrite that script with a Tensorflow or Pytorch equivalent? What if Pandas falls out of fashion after we've defined a convention of preparing pandas dataframes?

The current use of a map does mean we have to define naming conventions, which I don't like.

I think we will want to allow multiple URLs or pointers to examples of the data usage. We might want to allow a string description.

What do you think about creating another message?
message Dataset {
  string name = 1;
  string description = 2;
  repeated Reaction reactions = 3;
  repeated DatasetExample examples = 4;
  string dataset_id = 5;
}

message DatasetExample {
  string description = 1;
  string url = 2;
  RecordEvent example_created = 4;
}

Optionally, we could add a Person or RecordEvent field to the DatasetExample as a way of rewarding people who create/contribute examples that way. I assume we'll want to solicit contributions of examples and should give proper attribution. That would (should) involve moving RecordEvents out to be a top-level message, rather than part of ReactionProvenance.

Some thoughts:

I agree that it will be easier to review submissions if we don't have to look at this code. Plus, readability is an important consideration since big multi-line strings will look sloppy in the pbtxt format.

+1

We will potentially lose some permanence (if that's the right word) by having scripts only exist through url pointers. How do we know that someone won't delete their public GitHub repo, gist, or Colab notebook where the example was kept? I recognize that we also have this limitation for our other string url fields.

Yes, broken links could be an issue here But I think the benefits of being able to update e.g. colab notebook examples outweigh the risk. We could also check for broken links periodically and prune them from the repo.

Is it a security issue to have executable code if we never automatically execute it?

I'm less concerned about the security issues of trying to execute the code (since we'd do that in a VM) than I am about the risks posed to downstream users by hosting potentially malicious code. URLs feel safer all around.

I think it's possible for these scripts to become dated over time. For example, suppose we had an example of someone building a ML model with Theano. Would we want to eventually overwrite that script with a Tensorflow or Pytorch equivalent? What if Pandas falls out of fashion after we've defined a convention of preparing pandas dataframes?

Agreed; another +1 for the URL in this case since it could be updated without needing to update the record in the database.

The current use of a map does mean we have to define naming conventions, which I don't like.

+1

I think we will want to allow multiple URLs or pointers to examples of the data usage. We might want to allow a string description.

What do you think about creating another message?
message Dataset {
  string name = 1;
  string description = 2;
  repeated Reaction reactions = 3;
  repeated DatasetExample examples = 4;
  string dataset_id = 5;
}

message DatasetExample {
  string description = 1;
  string url = 2;
  RecordEvent example_created = 4;
}

I think this is a fantastic idea.

Optionally, we could add a Person or RecordEvent field to the DatasetExample as a way of rewarding people who create/contribute examples that way. I assume we'll want to solicit contributions of examples and should give proper attribution. That would (should) involve moving RecordEvents out to be a top-level message, rather than part of ReactionProvenance.

Yes, that sounds like a good way to give attribution (and also so people know who to contact if something breaks).


Add blind transfer to webphone

Coverage decreased (-0.06%) to 40.244% when pulling 98a262fd578b7cf8a685f6cb6ad2637270233239 on ele828:blind-transfer into 3c517dffafd78725963d42741be5db4ea652bf17 on ringcentral:master.

Coverage decreased (-0.06%) to 40.244% when pulling 175b8df0fbbcb409c5518a28029d6ca009c4bde7 on ele828:blind-transfer into 3c517dffafd78725963d42741be5db4ea652bf17 on ringcentral:master.


MSID: 96755 Version: 3 DOI: 10.1101/2<IP_ADDRESS>0977

MSID: 96755
Version: 3
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>0977
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=96755
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>0977

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/96755v3
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>0977
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/96755/v3/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Need to fix equal contribution footnote


LinuxRemote Desktop is only using 6 cores on an NV12s_v3 when asking a small viz instance

Version
1.0.36
Expected Behavior
All cores assigned to the remote desktop instance when using a small GPU node
Actual Behavior
On a slurm cluster, when running a Linux Remote Desktop instance on an NV12s_v3, only 6 cores are allocated to the job while being exclusive on the node.
Steps to Reproduce the Problem
On an azhop SLURM environment
request to launch a Linux Remote Desktop
Only 6 cores are assigned, probably due to the fact that the NV12s_v3 is an hyperthreaded VM

This is now fixed by #1752 which set slurm.use_pcpu = false


Firefox show NS_ERROR_CORRUPTED_CONTENT for some CSS/JS assets

In Firefox there is an issue with serving some JS files, which come over NS_ERROR_CORRUPTED_CONTENT.

https://github.com/mglaman/wasm-drupal/commit/d6fe4849e1920fab0b55acccaa57ae340719d95b may have fixed this. The export-ignore had the vendor JS assets. I don't know why it would work in Chrome.

That certainly fixed the problem in Firefox for me. Those errors are gone from the console, and the administration Toolbar works as expected.
I get these warnings in the console, after a few seconds. But the fonts are loaded (Metropolis, and Lora) and work great, so the font warnings are probably a minor thing. The *.js.map files I don't know about though ... :
The resource at “https://wasm-drupal.mglaman.dev/cgi/drupal/core/themes/olivero/fonts/metropolis/Metropolis-Regular.woff2” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly. 1

The resource at “https://wasm-drupal.mglaman.dev/cgi/drupal/core/themes/olivero/fonts/metropolis/Metropolis-SemiBold.woff2” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly. 1

The resource at “https://wasm-drupal.mglaman.dev/cgi/drupal/core/themes/olivero/fonts/metropolis/Metropolis-Bold.woff2” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly. 1

The resource at “https://wasm-drupal.mglaman.dev/cgi/drupal/core/themes/olivero/fonts/lora/lora-v14-latin-regular.woff2” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly. 1

Source map error: Error: JSON.parse: unexpected character at line 1 column 1 of the JSON data
Resource URL: https://wasm-drupal.mglaman.dev/cgi/drupal/core/assets/vendor/once/once.min.js?v=1.0.1
Source Map URL: once.min.js.map

Source map error: Error: JSON.parse: unexpected character at line 1 column 1 of the JSON data
Resource URL: https://wasm-drupal.mglaman.dev/cgi/drupal/core/assets/vendor/backbone/backbone-min.js?v=1.6.0
Source Map URL: backbone-min.js.map

Source map error: Error: JSON.parse: unexpected character at line 1 column 1 of the JSON data
Resource URL: https://wasm-drupal.mglaman.dev/cgi/drupal/core/assets/vendor/tabbable/index.umd.min.js?v=6.2.0
Source Map URL: index.umd.min.js.map

I get logged out after a minute or so, but that is already reported in #7.
So I think this issue can be set to Fixed, since the serious NS_ERROR_CORRUPTED_CONTENT error is now taken care of.

Thank you for confirming!


CI: gate "upload-db-dump" for tag

This step should not run upon tag creation.

e2etest failure can be ignored. Fixed in https://github.com/stackrox/scanner/pull/982


Event sequence debugging

I have come across a tricky situation that is difficult to debug as it only occurs under race conditions so hard to reproduce.
I would like to record all events in sequents with timing so I can recreate the issue with simulated events.
The example I have is that the StartGo flag is shown when a race start and after it stops it seems like a blue flag is shown, this is highly unlikely and probably an error in the light controller so I would like to see all the events the next day to identify which events came around the time the light controller stopped working.

The app store the last 10.000 events in memory. I am thinking that we could make a "Save events" menu option, that stores the events as a file (each line is a json-string), which would make it easy for you to modify in hand.
And then add another "Inject events from file" menu item, that replays the events from file.
To get the timings, I am thinking that all events should be timestamped. Then we can re-create the delays as they were. The timestamp doesn't need to be date/time, but could be a "slipstream uptime" value.. So like milliseconds since launch. So when replaying we would just need to sleep as much as the deltas between events.

The app store the last 10.000 events in memory. I am thinking that we could make a "Save events" menu option, that stores the events as a file (each line is a json-string), which would make it easy for you to modify in hand.
And then add another "Inject events from file" menu item, that replays the events from file.
To get the timings, I am thinking that all events should be timestamped. Then we can re-create the delays as they were. The timestamp doesn't need to be date/time, but could be a "slipstream uptime" value.. So like milliseconds since launch. So when replaying we would just need to sleep as much as the deltas between events.

Implemented as of https://github.com/dennis/slipstream/pull/41

Implemented as of https://github.com/dennis/slipstream/pull/41


Added support for tagging in single select fields

This feature is not immediately reading for pulling. Could someone with greater understanding of django-select2 review it and make suggestions. I have not written any tests, but I am using the code in a project.

Could be added in version 5. Please create a new PR on new code base.


Stop depending on gRPC on iOS

Because it's way too heavy & increases build times by a lot. (We could profile and get more data, but I'm sure it'll only confirm this thesis).
Alternative: define and handle commands & queries manually. Use something like swhitty/FlyingFox or Building42/Telegraph as HTTP server.

Some context:
We migrated to gRPC in #338. We weren't aware of how heavy this library is on iOS.
This issue essentially proposes reverting that change on iOS. Android is out of scope of this, but worth discussing as well. Having one platform use gRPC, and the other not, sounds bad.

If we stop depending on gRPC on iOS, it'll make little sense to also use it for Android and Dart side. So we'll essentially have to get rid of gRPC altogether.
Idea: could we use package:pigeon for this? It seems like a more lightweight codegen solution. Can pigeon messages be sent across processes, not only through Flutter's platform channels?

Idea: could we use package:pigeon instead of gRPC? It seems like a more lightweight codegen solution. Can pigeon messages be sent with e.g. HTTP, not only through Flutter's platform channels? In other words, can we do toJson/fromJson on pigeon-generated messages?

Not really. It is quite channels specific.
I am not a fan of it, but what about just using OpenAPI? It's the most lightweight. All platforms have support for it. Swift and Kotlin have server generators for it too.

We were thinking about it (@zltnDC even tried it out), but OpenAPI generators for Dart are mediocre and poorly maintained.

OpenAPI generators for Dart are mediocre and poorly maintained.

Were there any specific problems? I would have guess you need quite basic functionality for patrol. We use these generators in a few projects without any bigger issues.

If I remember correctly I tried using a custom configuration but the output didn't compile, some helpers method were missing and there were import problems. Swift also had small inconvenient issue. So, we thought about what we needed and decided to write a custom generation. Some of these points are:

if possible, reduce additional dependencies/technologies
models - easy to generate because we need a small subset
server/client (swift, dart, kotlin) - we can easy implement or change internal implementation: "URLSeession", "dio", "http", "FlyingFox" etc. Swagger generators offer a smaller subset or don't provide the ability to generate routes or any convinient class to hide communications etc. "lightweight" servers "Telegraph", "FlyingFox" are good examples.
we can easily maintain consistency across all platforms
We needed a simple way to add additional methods to contracts if necessary. Grpc uses pattern: property, hasProperty. We use this on the kotlin side and we are considering keeping this pattern for dart contracts (Patrol exports NativeView, Notification, Selector)
I also see some patterns, such as:  _wrapRequest('Name', ()=>...), _runCatching {} etc. We can easily move these things to the generated code and developers won't think about it.

And a few other issues that me and Bartek forgot.

Closing, if there is something else to do regarding this task please create a new one


CRD: Expose more options to the users and let the payload take care of the runtime class creation

In this PR we're exposing a few new attributes to the users:

Debug: Whether to enable debug for the runtime configuretion, which will also properly configure the CRI Engine accordingly
DefaultRuntimeClassName: The runtime class name that will be used as the default one, and will become the kata alias.

Together with these 2 options being exposed, we're leaving the runtime class creation to the runtime payloads, as they know better than the Operator what are the possible podOverhead and, in the future, NFD rules to be used.
Right now this is a draft as it depends on content that's not yet part of the Kata Containers payload, and also work that's been ongoing on the Enclave CC side (thanks @mythi for that!).  Regardless, I'd love to hear feedback from the other operator maintainers, thus I'm looping them here.

/test

/test

/test

/test

/test

/test

/test

/cc @jensfr @bpradipt @stevenhorsman
This is ready to be reviewed and it'll be ready to be merged after https://github.com/kata-containers/kata-containers/pull/7549 gets merged on Kata Contauners.
The s390x test is supposed to fail right now the payload I'm using for testing (which includes the not yet merged kata-containers#7549).
The SEV failure is a well known flaky test, the 3rd one, and the other test of that job are passing.
The other jobs should be passing. :-)

/test

As in the previous run of the CI we had CLH and QEMU TDX tests passing, and there were zero changes related to them, I'm going ahead and merging this one.


[BUG] FlutterFlow web version compiles incorrectly

Describe the bug
When using this in flutterflow it complies with html_editor_mobile.dart instead of the web version.  As it tries to load the html files from the mobile version
sexport 'package:html_editor_enhanced/src/html_editor_unsupported.dart'
if (dart.library.html) 'package:html_editor_enhanced/src/html_editor_web.dart'
if (dart.library.io) 'package:html_editor_enhanced/src/html_editor_mobile.dart';
export 'package:html_editor_enhanced/src/html_editor_controller_unsupported.dart'
if (dart.library.html) 'package:html_editor_enhanced/src/html_editor_controller_web.dart'
if (dart.library.io) 'package:html_editor_enhanced/src/html_editor_controller_mobile.dart';
To Reproduce
Add to flutter flow and try to run the web version of it.  The console log will show it trying to find the summernote.html which only appears in html_editor_widget_mobile.dart.
Expected behavior
It should correctly detect or allow us to manually choose each package.

The use of conditional import is used correctly, from my knowledge.
You can read it here: https://dart.dev/guides/libraries/create-packages#conditionally-importing-and-exporting-library-files
Might be something from FlutterFlow.

Thanks, I can try to follow up with FlutterFlow.  Someone had posted using this plugin wth flutterflow and the example didn't work so I was investigating.

From the documentation:

The conditional import or export checks only whether the library is available for use on the current platform, not whether it’s actually imported or used.

I'm not sure what could be the problem, but if the app was built with web assembly this might cause the app to load the dart.library.io instead of html. This is just speculation though, as of now, I haven't tried this theory yet.
Another thing to point out, that both html_editor_mobile and html_editor_web files have kIsWeb checks.
This mean, even if the library import fail, the kIsWeb should not.


Ways to create movement scripts?

What is the best way to create a movement script? I've never created one and  want to learn. Is modifying the .json file the only way to make one?

Yes, currently the only way to create movement scripts is manually. I had planned to possibly eventually create a UI for editing / creating movement scripts but that is very low priority - I dont think such a thing exists for camera+ either, but if it does you could use that and just import the camera+ movement script.


Measure Test Code Coverage

I thought we are going to see the result as a comment on the PR instead of having to go to a 3rd party website. Is that possible?

@enarha could you help check if Codecov Github app is installed on this repo. It should have the comment like this https://github.com/xinredhat/sprayproxy/pull/1#issuecomment-1717374488

I do not have permissions to check apps on the repo.

/retest

@enarha I don't quite understand why it didn't show up the result data as comments in this PR. Actually the coverage data is uploaded to Codecov https://app.codecov.io/gh/redhat-appstudio/sprayproxy

/lgtm


Question: Queue family selection

the way family indices are handled doesn't seem quite right.
This is my gpu it has two queue families:
Queue[0]: VK_QUEUE_GRAPHICS_BIT VK_QUEUE_COMPUTE_BIT VK_QUEUE_TRANSFER_BIT
Queue[1]: VK_QUEUE_COMPUTE_BIT VK_QUEUE_TRANSFER_BIT

how would the selection process work? would queue 0 be available for graphics and compute and queue 1 be for copy?
void DeviceVK::FillFamilyIndices(bool useEnabledFamilyIndices, const uint32_t* enabledFamilyIndices, uint32_t familyIndexNum)
{
    uint32_t familyNum = 0;
    m_VK.GetPhysicalDeviceQueueFamilyProperties(m_PhysicalDevices.front(), &familyNum, nullptr);

    Vector<VkQueueFamilyProperties> familyProps(familyNum, GetStdAllocator());
    m_VK.GetPhysicalDeviceQueueFamilyProperties(m_PhysicalDevices.front(), &familyNum, familyProps.data());

    memset(m_FamilyIndices.data(), INVALID_FAMILY_INDEX, m_FamilyIndices.size() * sizeof(uint32_t));

    for (uint32_t i = 0; i < familyProps.size(); i++)
    {
        const VkQueueFlags mask = familyProps[i].queueFlags;
        const bool graphics = mask & VK_QUEUE_GRAPHICS_BIT;
        const bool compute = mask & VK_QUEUE_COMPUTE_BIT;
        const bool copy = mask & VK_QUEUE_TRANSFER_BIT;

        if (useEnabledFamilyIndices)
        {
            bool isFamilyEnabled = false;
            for (uint32_t j = 0; j < familyIndexNum && !isFamilyEnabled; j++)
                isFamilyEnabled = enabledFamilyIndices[j] == i;

            if (!isFamilyEnabled)
                continue;
        }

        if (graphics)
            m_FamilyIndices[(uint32_t)CommandQueueType::GRAPHICS] = i;
        else if (compute)
            m_FamilyIndices[(uint32_t)CommandQueueType::COMPUTE] = i;
        else if (copy)
            m_FamilyIndices[(uint32_t)CommandQueueType::COPY] = i;
    }
}

what is the intention for how a queue is selected for a family?

It will, because it will first put index 0 in the graphics family because it has the graphics bit, and then it will put index 1 in the compute family because of the compute bit.

I was looking through a couple devices: https://vulkan.gpuinfo.org/listdevices.php
this looks seems to hold true.

graphics is always going to the first queue?
Yes, it does.

compute and maybe a dedicated transfer queue
Same behaviour for them too.

Thanks @vertver for explaining it out \O/


Fix footer github logo image resized

footer github logo img bug -> fixed

@Semicile17

Give appropriate PR title
Please make sure to include a screenshot of the changes.


HDDS-11584. Document ozone debug ldb command

What changes were proposed in this pull request?
Many filtering options were introduced recently for ozone debug ldb command. The usage of these commands and it's options is documented so that users can find it easy to  understand the format of using the commands.
Many samples of the various options are included.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11584
How was this patch tested?
Checked using hugo serve:
Tools page:

Debug page:

@ChenSammi I have used translate app to add a Chinese version of the document. Could you please help me with verifying if the translation is done correctly?

@sadanand48 thanks for the review, I have addressed all the comments and made the changes needed.

@ChenSammi thanks for the review! I have updated the PR with the suggested changes. Could you please take a look again?

@ChenSammi thanks for the review! I have updated the PR with the suggested changes. Could you please take a look again?

Thanks @Tejaskriya.  I have left all the comments.

Thanks for the review @ChenSammi ! I have addressed all the comments and made the changes. Could you please approve the workflows?


It appears that lib.es6.d.ts is not used when specifying ES6 as a project type

As a result, I get an error whenever I try to for-of over an array.

Repro:
let arr = [1, 2, 3];
for (let v of arr) {
}

@DanielRosenwasser That actually works for ES3, ES5, and ES6.
This is a better example:
for (var i of 'string') { }

I'm not sure how that's better. My settings are to use ES6, and we have an error message that communicates that we're not using the ES6 library. That's the bug I'm reporting.

Oh, I see, you mean just to confirm whether it's isolated to using an alternate library. Is it?

The example you posted works in ES3, so it won't report the error even when we don't use the ES6 library.

Fixed for VS 2015 RTM


[AST] Consolidate Obj-C types on ASTContext

This PR moves the getNSObjectType and getObjCSelectorType methods from TypeChecker onto ASTContext. In addition, it moves the FOR_KNOWN_FOUNDATION_TYPES macro into a separate KnownObjCTypes.def file to define each of the Obj-C type decls we want to have access to.
Lastly, in the spirit of https://github.com/apple/swift/pull/27195, it defines variants of the getXXXDecl accessors that return the types.

@swift-ci please smoke test


python 3.10 breaks pkgcheck

3.x began installing Python 3.10.0 which is throwing pmaint errors
There are two forks with comparable workarounds, installing 3.9 instead of 3.x

osirisinferi
nabbi

Sync gentoo repo
  /opt/hostedtoolcache/Python/3.10.0/x64/bin/pmaint sync gentoo
  *** syncing gentoo
  Traceback (most recent call last):
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/urllib/request.py", line 1348, in do_open
      h.request(req.get_method(), req.selector, req.data, headers,
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/http/client.py", line 1276, in request
      self._send_request(method, url, body, headers, encode_chunked)
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/http/client.py", line 1322, in _send_request
      self.endheaders(body, encode_chunked=encode_chunked)
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/http/client.py", line 1271, in endheaders
      self._send_output(message_body, encode_chunked=encode_chunked)
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/http/client.py", line 1031, in _send_output
      self.send(msg)
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/http/client.py", line 969, in send
      self.connect()
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/http/client.py", line 1448, in connect
      self.sock = self._context.wrap_socket(self.sock,
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/ssl.py", line 512, in wrap_socket
      return self.sslsocket_class._create(
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/ssl.py", line 1061, in _create
      self._sslobj = self._context._wrap_socket(
  ssl.SSLError: Cannot create a client socket with a PROTOCOL_TLS_SERVER context (_ssl.c:801)

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/pkgcore/sync/http.py", line 53, in _sync
      resp = urllib.request.urlopen(req, context=context)
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/urllib/request.py", line 216, in urlopen
      return opener.open(url, data, timeout)
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/urllib/request.py", line 519, in open
      response = self._open(req, data)
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/urllib/request.py", line 536, in _open
      result = self._call_chain(self.handle_open, protocol, protocol +
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/urllib/request.py", line 496, in _call_chain
      result = func(*args)
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/urllib/request.py", line 1391, in https_open
      return self.do_open(http.client.HTTPSConnection, req,
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/urllib/request.py", line 1351, in do_open
      raise URLError(err)
  urllib.error.URLError: <urlopen error Cannot create a client socket with a PROTOCOL_TLS_SERVER context (_ssl.c:801)>

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/opt/hostedtoolcache/Python/3.10.0/x64/bin/pmaint", line 4, in <module>
      scripts.run(basename(__file__))
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/pkgcore/scripts/__init__.py", line 32, in run
      sys.exit(tool())
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/snakeoil/cli/tool.py", line 79, in __call__
      ret = self.main()
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/snakeoil/cli/tool.py", line 185, in main
      self.handle_exec_exception(e)
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/snakeoil/cli/tool.py", line 170, in main
      exitstatus = func(self.options, self.out, self.err)
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/pkgcore/scripts/pmaint.py", line 71, in sync_main
      ret = repo.operations.sync(
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/pkgcore/operations/__init__.py", line 69, in _recast_exception_decorator
      return functor(*args, **kwds)
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/pkgcore/operations/repo.py", line 146, in _cmd_api_sync
      ret = syncer.sync(**kwargs)
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/pkgcore/sync/base.py", line 131, in sync
      return self._sync(verbosity, 1, **kwds)
    File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/pkgcore/sync/http.py", line 55, in _sync
      if e.getcode() == 304: # Not Modified
  AttributeError: 'URLError' object has no attribute 'getcode'
Error: The process '/opt/hostedtoolcache/Python/3.10.0/x64/bin/pmaint' failed with exit code 1

We were having the same issue in ::guru and ::sci:
https://github.com/gentoo/sci/runs/4087197115?check_suite_focus=true
However, as of today the error has changed to:
       File "/tmp/tmpqi322ju5_in_process.py", line 363, in <module>
          main()
        File "/tmp/tmpqi322ju5_in_process.py", line 345, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/tmp/tmpqi322ju5_in_process.py", line 130, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/tmp/pip-build-env-brn6mc8m/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 162, in get_requires_for_build_wheel
          return self._get_build_requires(
        File "/tmp/pip-build-env-brn6mc8m/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 143, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-brn6mc8m/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 158, in run_setup
          exec(compile(code, __file__, 'exec'), locals())
        File "setup.py", line 14, in <module>
          setup(**dict(
        File "/tmp/pip-build-env-brn6mc8m/overlay/lib/python3.10/site-packages/setuptools/__init__.py", line 159, in setup
          return distutils.core.setup(**attrs)
        File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/distutils/core.py", line 148, in setup
          dist.run_commands()
        File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/distutils/dist.py", line 966, in run_commands
          self.run_command(cmd)
        File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/distutils/dist.py", line 985, in run_command
          cmd_obj.run()
        File "/tmp/pip-build-env-brn6mc8m/overlay/lib/python3.10/site-packages/setuptools/command/egg_info.py", line 299, in run
          self.find_sources()
        File "/tmp/pip-build-env-brn6mc8m/overlay/lib/python3.10/site-packages/setuptools/command/egg_info.py", line 306, in find_sources
          mm.run()
        File "/tmp/pip-build-env-brn6mc8m/overlay/lib/python3.10/site-packages/setuptools/command/egg_info.py", line 541, in run
          self.add_defaults()
        File "/tmp/pip-build-env-brn6mc8m/overlay/lib/python3.10/site-packages/setuptools/command/egg_info.py", line 578, in add_defaults
          sdist.add_defaults(self)
        File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/distutils/command/sdist.py", line 226, in add_defaults
          self._add_defaults_python()
        File "/tmp/pip-build-env-brn6mc8m/overlay/lib/python3.10/site-packages/setuptools/command/sdist.py", line 113, in _add_defaults_python
          self._add_data_files(self._safe_data_files(build_py))
        File "/tmp/pip-build-env-brn6mc8m/overlay/lib/python3.10/site-packages/setuptools/command/egg_info.py", line 621, in _safe_data_files
          return build_py.get_data_files_without_manifest()
        File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/distutils/cmd.py", line 103, in __getattr__
          raise AttributeError(attr)
      AttributeError: get_data_files_without_manifest

https://github.com/gentoo/sci/runs/4103754568?check_suite_focus=true

Fixed by https://github.com/pkgcore/pkgcore/commit/276f3a7686aaa46844903e2387798d36d786a179.

Looks like it is fixed, but if it reappears, let's create a new issue 😄


Tasks

There didn't seem to be any PR open for the tasks branch - easier to understand all the changes in conjunction w/ https://github.com/huggingface/moon-landing/pull/1651 @osanseviero @beurkinger @merveenoyan

Will this be merged in huggingface_hub? For transformers we recently switched to using a dataset on the hub to host images, as otherwise it significantly weights down repositories.
If this PR is to be merged, it would weigh down the repo by at least a couple MBs. Would it be possible to host them on a hub dataset, like we do here for example?

@LysandreJik @Pierrci
Regarding hosting hugginface_hub task assets on a Hugging Face dataset:

I don't think "weighting down" the repositories is an issue right now - we're talking about some pictures and audio files. People can probably clone the whole thing on their smartphone connection  in a couple of seconds. And for subsequent push/pull, only relevant files are updated anyway.
If possible I personally prefer having the assets where they're supposed to be used, rather than in another place. Simply makes things easier to manage.
One of the goal of putting tasks in hugginface_hub is that people can easily edit the tasks, but if the assets become hosted in another place they don’t have access to, doesn't it beat the whole purpose ?
Hosting assets on datasets feels like we're abusing our own dataset system (which is supposed to be used to host ML stuff). Why not use a service/place that is actually dedicated to this ?

Just on this specific point:

Hosting assets on datasets feels like we're abusing our own dataset system (which is supposed to be used to host ML stuff).

not really, this is still content related to ML, i don't think it is a complete abuse of our system. And the open source team has been doing it for a while

Hey @beurkinger, thanks for your comment. I agree with you that what I offer is not necessarily ideal regarding this exact PR: what I want to optimize for is external contributions. Cloning a repository which weighs ~17MB is fine (current size of hfh), but if PRs like this one pile up it wouldn't be surprising to see its size 10x over the coming months.
Unfortunately, as I'm sure you're aware, once an asset has been added to the repository, and unless we rewrite the history (which we should never do for public-facing repositories), it will be part of its history forever. I think having some of the burden on us in terms of maintenance is not an issue if it makes external contributions simpler.

One of the goal of putting tasks in hugginface_hub is that people can easily edit the tasks, but if the assets become hosted in another place they don’t have access to, doesn't it beat the whole purpose ?

I agree with you so feel free to keep it here if you're expecting external contributors to edit these tasks. My point still stands for other/future assets.

Unfortunately, as I'm sure you're aware, once an asset has been added to the repository, and unless we rewrite the history (which we should never do for public-facing repositories), it will be part of its history forever

I was going to suggest rewriting the history, but if this is not an option then you're making a good point on the long term.
Apart from not having the assets available on the repo, the main thing I'm wary about is using datasets for that purpose, because it's definitely not the usage this system was built for, and I feel this idea is kind of a "if all you have is a hammer, everything looks like a nail" situation ;)
I'm definitely not an expert on the subject, but could we not use Git LFS to make the assets part of the repo without increasing its size, if things get out of control ?

if you're expecting external contributors to edit these tasks

This is an interesting point - are we sure we do @osanseviero (not a loaded question, just making sure) ?
I'd be curious to have your opinion on the matter @Pierrci @pngwn

@LysandreJik yes, I was thinking that since these assets have already been put on the repo, it's too late for them anyway :D

not until the branch is merged, no

@julien-c @beurkinger I've put assets here earlier to make your life easier, if you want to do it

@julien-c @merveenoyan changing the assets location means rewriting some code, updating both repos, and review again. We would like to publish the new pages in the next hour, but that would set us back for no major gain IMHO. I'll let you decide if it's worth it.

@julien-c @beurkinger can we just release like this and change the path to assets later?

We can. Downside is that the files will stay in the fit history. I think that removing them from the history in time would not be such a big deal, even if the repo is public, as it's only used by moon-landing AFAIK, and these are not crucial files. Then again I'm not incredibly familiar with the do and don'ts the open-source community.

@beurkinger this repo is not only used by moon-landing multiple other projects depend on it


Unit tests

I am not familiar with golang, so I wrote some tests in python.
http://kcwu.csie.org/~kcwu/tmp/drive_test.py.txt
If you like to put it in repo, I can send a PR.

Oh wow, this is cool. Thank you @kcwu! See to keep things uniform, I would encourage you to get this in Golang, by the time you can write these in Python translating them, plus learning Go will be cool ;) I would like to see your code contributions credited in the repo, so we could work through the translation to Go together. Please let me know what you think.

You know what, to get it in and have the tests running first, please go ahead and create the PR and then the translation will proceed later.

Do you know any existing go testing framework suitable for command line tool? Most tutorial are talking unit test but I want end-to-end test.
Btw, you can try to run those tests , it found several issues in current code.

http://pivotallabs.com/agouti/ I have not used it personally but looked it up.
You could write the testing code to invoke subprocess and commands just like you did with the Python code.
I always just write tests using golang's testing package.
By the way on first try, the first test is not correct. drive list SHOULD NEVER erase any content in your drive. list just lists the current working directory relative to the root.

Never mind my previous comments, I hadn't realized that I needed a fresh drive

@kcwu these are some of the coolest tests I've seen a long time. Thank you very much, I like this. Please get that PR in :+1:

Addressed by https://github.com/odeke-em/drive/pull/113. A translation and addition of tests will be expected as the project builds on.


New PR for previous PR #7530, add note about using Git instead of TFVC

Have deleted the wrongly named file and re-added the note. Thanks everyone.

Hi @lukos, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@lukos : Thanks for your contribution to the Azure documentation! The author, @dariagrigoriu, has been notified to review your proposed change.

@lukos - Thanks for your contribution to the Azure docs. On November 16th, we announced the availability of our Azure technical documentation in a new location on docs.microsoft.com. You can read about it on our team blog. This change means the article source lives in a new GitHub repository. Because there are some changes in the source markdown as a result of the move, we can’t pull your contribution over to the new repo without creating a ton of merge conflicts. We invite you to resubmit the change (if you are willing) to the new version of the article at https://docs.microsoft.com/en-us/azure/app-service-web/app-service-continuous-deployment. Thanks for your understanding.


useStylesScoped$ not working with interpolated strings

Qwik Version
v0.11.0
Operating System (or Browser)
macOS (Brave, Chrome)
Node Version (if applicable)
16.13.0
Which component is affected?
Qwik Optimizer (rust)
Expected Behaviour
The program should compile correctly when using interpolated strings
Actual Behaviour
The program throws an error
 [vite] Internal server error: Qrl($) scope is not a function, but it's capturing local identifiers: elevation

Additional Information
Some context for debugging: I created a simple component like this
export const Button = component$() => {

    const theme = useContext(ThemeContext);

    const radius = 4;
    cons title = 'test';

    useStylesScoped$(`
    .button {
      corner-radius: ${radius}px;
    }
    `);

    return <>
        <button
            class={mergeClasses('button', classes)}
            style={buttonStyle}
            preventdefault:click
        >
            {title}
        </button>
    </>;
});

However, this one works
export const Button = component$() => {

    const theme = useContext(ThemeContext);
    cons title = 'test';

    useStylesScoped$(`
    .button {
      corner-radius: 4px;
    }
    `);

    return <>
        <button
            class={mergeClasses('button', classes)}
            style={buttonStyle}
            preventdefault:click
        >
            {title}
        </button>
    </>;
});

So it must have to do with the fact that the radius variable is interpolated

Duplicate of #1728 and generally a duplicate of #1563

Dynamic useStylesScope$() is very tricky and not its intended use case... i will leave this issue open, in the meantime we need to extend the docs to better explain this API

In #1563 I explain how to achieve dynamic styles, but I think that between build-time support like Vanilla-Extract and CSS Variables support, there's very little reason to have dynamic styles (except for DX and supporting old styling systems).

I'll close this issue on favor of #1728 and #1563. Thanks for creating this one @ValiDraganescu 🙏


Call to undefined method Symfony\Component\HttpFoundation\Response::header()

When Mollie is calling the WebhookController it's causing an error like below
Call to undefined method Symfony\Component\HttpFoundation\Response::header() in /vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:167
When swapping Symfony\Component\HttpFoundation\Response for Illuminate\Http\Response in the controller files i'm not getting the error anymore.

Hello @jeroenrosendaal,
Could you please let me know which version of Laravel and laravel-cashier-mollie you are currently using? Also, could you specify when exactly the error occurs, for example, during the first payment or some other time? Thank you.

Hi @Naoray
I'm using:

Laravel 8
laravel-cashier-mollie v2

The error occurs when mollie returns to the application and is hitting one of the controllers (AfterCareWebhookController, FirstPaymentWebhookController, WebhookController)

Hello @jeroenrosendaal,
Would you be able to provide me with the exact version of laravel-cashier-mollie that you are using, please? I have been unable to reproduce the error so far. Thank you.

Hi @Naoray
The exact version is v2.6.1

@jeroenrosendaal what’s your mollie/laravel-mollie version?

@Naoray mollie/laravel-mollie v2.16.0

Hi @jeroenrosendaal ,
We're unable to reproduce the error here with these package versions.
Can you verify that the cors middleware is disabled on the webhook route, and see whether any other middleware could be causing the problem? I.e. no auth checks should be applied to these requests.

Hi @sandervanhooft
I checked my middleware and there was indeed a middleware that was causing this problem.
Thanks for pointing it out.

No problem, glad you solved it. Enjoy!


Add majorVersion and minorVersion properties

Looks good. I might want to change the naming later to major_version and minor version. Maybe we should also store the version already as a tuple.


Specify the need for passwordless gWMS certs

The last commit look ok, too?

In instances where we have one recommended method for doing something (automated proxy renewal service), it behooves us to avoid using words like can or may. Admins have root, they can do anything, we need to tell them what they should do.

@brianhlin Fair enough then go ahead and merge


Update molo api

@miltontony @saeedmb8 Please review.
The purpose of this PR is to get the API stuff working (tests passing) with Molo v5 - not to deal with the comments left by Milton on the original API PR. I'd like to deal with those issue directly on the api_work branch or on another branch, in an effort to keep the PRs manageable.

The last 6 commits are the relevant ones to the API.

👍


Add Test case for create BitmapDecoder with async file stream.

Fixes Issue https://github.com/dotnet/wpf/pull/4966
Master PR https://github.com/dotnet/wpf/pull/4966
Description

Test Name : DRT Create BitmapDecoder with async file stream.

Customer Impact

Regression
No
Testing
Built and ran tests with x64.
Risk
None

@dipeshmsft are there something preventing tests to be added by community?

/azp run


feat: prefix virtual templates with uib/

Change all virtual paths with built in templates to be prefixed by uib/

BREAKING CHANGE: All virtual templates in UI Bootstrap now are prefixed
with uib/ - if one is overriding the templates via $templateCache path
or manually building the templates from the UI Bootstrap repository, one
needs to change the string used in the $templateCache representation
to have the new prefix
This implements #1205.

:+1: