HDFS-16084. Fix getJNIEnv crash due to incorrect state set to tls var

Description of PR
the jni state tls object is set before passing all the checks, resulting an invalid state in the tls and been hit later on with invalid object which already destroyed.
How was this patch tested?
set the tls object lastly when passing all checks. A sample binary is added to expose this issue and verify the fix.
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
7m 27s

Docker failed to build run-specific yetus/hadoop:tp-16675}.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6969

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/1/console

versions
git=2.34.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

saw the docker CI failed, am I doing something wrong?

saw the docker CI failed, am I doing something wrong?

I found that yasm download address changed. See https://github.com/apache/hadoop/pull/6973 for more information.

saw the docker CI failed, am I doing something wrong?

I found that yasm download address changed. See #6973 for more information.

guess I should wait for your PR merged and then rebase mine?

saw the docker CI failed, am I doing something wrong?

I found that yasm download address changed. See #6973 for more information.

guess I should wait for your PR merged and then rebase mine?

I merge the #6973.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
19m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 55s

trunk passed

+1 :green_heart:
compile
2m  4s

trunk passed

+1 :green_heart:
mvnsite
0m 21s

trunk passed

+1 :green_heart:
shadedclient
56m  0s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 10s

the patch passed

+1 :green_heart:
compile
1m 57s

the patch passed

+1 :green_heart:
cc
1m 57s

the patch passed

+1 :green_heart:
golang
1m 57s

the patch passed

+1 :green_heart:
javac
1m 57s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 3 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1 :x:
blanks
0m  0s
/blanks-tabs.txt
The patch 2 line(s) with tabs.

+1 :green_heart:
mvnsite
0m 12s

the patch passed

+1 :green_heart:
shadedclient
19m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
5m 34s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

105m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6969

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang

uname
Linux a63e87ac4a88 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f6dc302e7cbc91f055bdc396bea71db2c3dd7be2

Default Java
Red Hat, Inc.-1.8.0_412-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/2/testReport/

Max. process+thread count
552 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/2/console

versions
git=2.9.5 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 50s

trunk passed

+1 :green_heart:
compile
2m  1s

trunk passed

+1 :green_heart:
mvnsite
0m 22s

trunk passed

+1 :green_heart:
shadedclient
55m 54s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 11s

the patch passed

+1 :green_heart:
compile
2m  1s

the patch passed

+1 :green_heart:
cc
2m  1s

the patch passed

+1 :green_heart:
golang
2m  1s

the patch passed

+1 :green_heart:
javac
2m  1s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
mvnsite
0m 12s

the patch passed

+1 :green_heart:
shadedclient
19m 43s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
5m 36s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

85m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6969

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang

uname
Linux 540ebb8ab1a7 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e330ff4234b71af44376a60d36ccdae87222ab7b

Default Java
Red Hat, Inc.-1.8.0_412-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/3/testReport/

Max. process+thread count
673 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/3/console

versions
git=2.9.5 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 57s

trunk passed

+1 :green_heart:
compile
2m  2s

trunk passed

+1 :green_heart:
mvnsite
0m 18s

trunk passed

+1 :green_heart:
shadedclient
55m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 12s

the patch passed

+1 :green_heart:
compile
1m 58s

the patch passed

+1 :green_heart:
cc
1m 58s

the patch passed

+1 :green_heart:
golang
1m 58s

the patch passed

+1 :green_heart:
javac
1m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 13s

the patch passed

+1 :green_heart:
shadedclient
19m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
5m 28s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

85m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6969

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang

uname
Linux f18c479d6a09 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e7383ebf24d9d8137b2519a15b5006631f7e21a2

Default Java
Red Hat, Inc.-1.8.0_412-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/4/testReport/

Max. process+thread count
727 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/4/console

versions
git=2.9.5 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 19s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 26s

trunk passed

+1 :green_heart:
compile
2m  3s

trunk passed

+1 :green_heart:
mvnsite
0m 22s

trunk passed

+1 :green_heart:
shadedclient
56m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 12s

the patch passed

+1 :green_heart:
compile
1m 56s

the patch passed

-1 :x:
cc
1m 56s
/results-compile-cc-hadoop-hdfs-project_hadoop-hdfs-native-client.txt
hadoop-hdfs-project_hadoop-hdfs-native-client generated 4 new + 8 unchanged - 0 fixed = 12 total (was 8)

+1 :green_heart:
golang
1m 56s

the patch passed

+1 :green_heart:
javac
1m 56s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 15s

the patch passed

+1 :green_heart:
shadedclient
19m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
5m 31s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 27s

The patch does not generate ASF License warnings.

86m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6969

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang

uname
Linux ff053e1aa8d4 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a031775f4404dc2ef92c7c75f0faa21817600543

Default Java
Red Hat, Inc.-1.8.0_412-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/5/testReport/

Max. process+thread count
552 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/5/console

versions
git=2.9.5 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 19s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
35m 24s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
2m  3s

trunk passed

+1 :green_heart:
mvnsite
0m 21s

trunk passed

+1 :green_heart:
shadedclient
57m  6s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 12s

the patch passed

+1 :green_heart:
compile
1m 58s

the patch passed

+1 :green_heart:
cc
1m 58s

the patch passed

+1 :green_heart:
golang
1m 58s

the patch passed

+1 :green_heart:
javac
1m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 15s

the patch passed

+1 :green_heart:
shadedclient
19m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
5m 28s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

86m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6969

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang

uname
Linux 1603251d2477 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b99bd3e12a4c9e7a1f39ff616db5b684a1300c6e

Default Java
Red Hat, Inc.-1.8.0_412-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/6/testReport/

Max. process+thread count
552 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/6/console

versions
git=2.9.5 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 18s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 37s

trunk passed

+1 :green_heart:
compile
2m  4s

trunk passed

+1 :green_heart:
mvnsite
0m 19s

trunk passed

+1 :green_heart:
shadedclient
55m 28s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 12s

the patch passed

+1 :green_heart:
compile
1m 58s

the patch passed

+1 :green_heart:
cc
1m 58s

the patch passed

+1 :green_heart:
golang
1m 58s

the patch passed

+1 :green_heart:
javac
1m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 12s

the patch passed

+1 :green_heart:
shadedclient
19m 41s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
5m 36s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 27s

The patch does not generate ASF License warnings.

85m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6969

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang

uname
Linux cc46c6caff0a 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cdc9ccb6033eac2e08abae8b8ba7bfaf5af94003

Default Java
Red Hat, Inc.-1.8.0_412-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/testReport/

Max. process+thread count
557 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/console

versions
git=2.9.5 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
17m 36s

trunk passed

+1 :green_heart:
compile
2m 13s

trunk passed

+1 :green_heart:
mvnsite
0m 31s

trunk passed

+1 :green_heart:
shadedclient
39m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 17s

the patch passed

+1 :green_heart:
compile
2m  3s

the patch passed

+1 :green_heart:
cc
2m  3s

the patch passed

+1 :green_heart:
golang
2m  3s

the patch passed

+1 :green_heart:
javac
2m  3s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 19s

the patch passed

+1 :green_heart:
shadedclient
18m 46s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
5m 57s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

80m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6969

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang

uname
Linux d9cddb0931da 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cdc9ccb6033eac2e08abae8b8ba7bfaf5af94003

Default Java
Red Hat, Inc.-1.8.0_312-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/testReport/

Max. process+thread count
552 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/console

versions
git=2.27.0 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
17m 14s

trunk passed

+1 :green_heart:
compile
2m 17s

trunk passed

+1 :green_heart:
mvnsite
0m 32s

trunk passed

+1 :green_heart:
shadedclient
39m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 16s

the patch passed

+1 :green_heart:
compile
2m  3s

the patch passed

+1 :green_heart:
cc
2m  3s

the patch passed

+1 :green_heart:
golang
2m  3s

the patch passed

+1 :green_heart:
javac
2m  3s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 19s

the patch passed

+1 :green_heart:
shadedclient
18m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
5m 55s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

70m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6969

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang

uname
Linux 33756636e45c 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cdc9ccb6033eac2e08abae8b8ba7bfaf5af94003

Default Java
Red Hat, Inc.-1.8.0_312-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/testReport/

Max. process+thread count
550 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/console

versions
git=2.27.0 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
6m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
18m 19s

trunk passed

+1 :green_heart:
compile
2m  7s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
2m  7s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
mvnsite
0m 20s

trunk passed

+1 :green_heart:
shadedclient
43m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 11s

the patch passed

+1 :green_heart:
compile
2m  2s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
cc
2m  2s

the patch passed

+1 :green_heart:
golang
2m  2s

the patch passed

+1 :green_heart:
javac
2m  2s

the patch passed

+1 :green_heart:
compile
2m  2s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
cc
2m  2s

the patch passed

+1 :green_heart:
golang
2m  2s

the patch passed

+1 :green_heart:
javac
2m  2s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 12s

the patch passed

+1 :green_heart:
shadedclient
20m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
5m 52s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 24s

The patch does not generate ASF License warnings.

82m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6969

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang

uname
Linux 73c732c2f04b 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cdc9ccb6033eac2e08abae8b8ba7bfaf5af94003

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/testReport/

Max. process+thread count
552 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6969/7/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Finally, the ci check passed
@zhengchenyu @tomscut whom else shall be invited to review this pull request?

Committed to trunk. Thanks @kevincai for your contributions!
BTW, what's your JIRA account? When I want to assign https://issues.apache.org/jira/browse/HDFS-16084 to you but I am not sure if the reporter and you is the same one. Thanks!

Committed to trunk. Thanks @kevincai for your contributions!
BTW, what's your JIRA account? When I want to assign https://issues.apache.org/jira/browse/HDFS-16084 to you but I am not sure if the reporter and you is the same one. Thanks!

I didn't apply one.

@Hexiaoqiao you want to get into hadoop branch 3.4, so target 3.4.2?

@steveloughran No plan to backport to other active branches if no more requirement.

so target 3.4.2?

Not see any place marked 3.4.2, would you mind to confirm? Thanks.

Committed to trunk. Thanks @kevincai for your contributions!
BTW, what's your JIRA account? When I want to assign https://issues.apache.org/jira/browse/HDFS-16084 to you but I am not sure if the reporter and you is the same one. Thanks!

I didn't apply one.

What about apply one at JIRA side? @kevincai

Committed to trunk. Thanks @kevincai for your contributions!
BTW, what's your JIRA account? When I want to assign https://issues.apache.org/jira/browse/HDFS-16084 to you but I am not sure if the reporter and you is the same one. Thanks!

I didn't apply one.

What about apply one at JIRA side? @kevincai

Got the jira account created, please assign to me as kevin.cai

Not see any place marked 3.4.2, would you mind to confirm? Thanks.

branch-3.4 is going to be where 3.4.2 is going to be forked from -if you do a PR for that branch it'll be out on the relevant release

Hi @steveloughran , have cherrypick to branch-3.4, Please double check.

@Hexiaoqiao looks good. you want to try for branch-3.4.1. too?

@kevincai , @Hexiaoqiao , @steveloughran this PR is causing the Windows CI to fail. Please see - https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/647/artifact/out/patch-mvninstall-root.txt
Here's the error -
[exec] "C:\hadoop\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\ALL_BUILD.vcxproj" (default target) (1) ->
[exec] "C:\hadoop\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\main\native\libhdfspp\tests\get_jni_test.vcxproj" (default target) (40) ->
[exec] (ClCompile target) ->
[exec]   C:\hadoop\hadoop-hdfs-project\hadoop-hdfs-native-client\src\main\native\libhdfspp\tests\libhdfs_getjni_test.cc(24,73): error C2491: 'JNI_GetDefaultJavaVMInitArgs': definition of dllimport function not allowed [C:\hadoop\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\main\native\libhdfspp\tests\get_jni_test.vcxproj]
[exec]   C:\hadoop\hadoop-hdfs-project\hadoop-hdfs-native-client\src\main\native\libhdfspp\tests\libhdfs_getjni_test.cc(29,79): error C2491: 'JNI_CreateJavaVM': definition of dllimport function not allowed [C:\hadoop\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\main\native\libhdfspp\tests\get_jni_test.vcxproj]

Could you please fix this or revert this PR?

@kevincai , @Hexiaoqiao , @steveloughran I've attempted a fix for this in #7096. Let's see if it works.

Started the Windows CI run for the fix - https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/652/.


[Bug]: UX: jupyter notebook server creation - may be confusing when user press ESC btn

Is there an existing issue for this?

[X] I have searched the existing issues

Deploy type
Downstream version (eg. RHODS 1.29)
Version
1.32RC6
Current Behavior
When creating the Jupyter notebook server from the Jupyter spawner (Applications -> Enabled -> Jupyter)  there is a modal window showed to user with the progress bar. Once the server is ready and running the user can choose from two buttons in the Web UI - open in new tab and open in current tab. Although, in case that user has the Jupyter tab already opened from previous session, or simply just because user wants, it can also intuitively click the escape button on the keyboard. In such case the modal window disappears and no running jupyter server is actually available for the user at this point.
It's required to click on one of the buttons mentioned above so that the Web UI is updated to the state where it shows the jupyter notebook server is running.
Expected Behavior
Jupyter server should be prepared and running even after pressing the ESC button as the modal window text mentioned. Or there should be some info that if this modal window is closed without choosing one of the options below, the running instance will be killed.
The UI view in the background of the modal window should be updated accordingly too in case that ESC button is pressed and modal window is closed.
Steps To Reproduce

Go to RHODS -> applications -> enabled -> launch Jupyter application
Choose any of the images and click on Start server button, see jupyter-notebook-start-1.png
Wait till the server is created, see jupyter-notebook-start-2.png
Instead of clicking on any of the available buttons, simply press ESC on your keyboard
You can see that you're back on your jupyter-notebook-start-1.png screen and no server is running instead of seeing the expected jupyter-notebook-start-3.png screen with some Jupyter notebook server running and available

Workaround (if any)
No response
What browsers are you seeing the problem on?
Chrome
Anything else
Checked only in Chrome not in any other browser.
This issue was created per discussion from this Jira https://issues.redhat.com/browse/RHODS-11648.

@kywalker-rh @andrewballantyne The Jupyter tile has a weird flow, we should look at this.

Tracking in jira now - reopened original issue.  https://issues.redhat.com/browse/RHOAIENG-2447


Homepage controller porting

Ported the HomeController from the old versione, with tests and old Twig template.

Please squash your commit and rebase with last version of PUGX:release/v3.0.0!
Thanks!

sorry but I close in favor of this: https://github.com/PUGX/badge-poser/pull/219


Handle Mesos redirects

I think this PR is done. I've opened #10 to track further work, but that can wait a bit.


Incorrect linker flag (-lftdi) used because ldconfig not in path

https://github.com/waywardgeek/infnoise/blob/fc0d99f58fff60b5cb7dca583f4bbcc60e1f63a2/software/Makefile#L14
Building on a Debian 9.4 amd64 system (up-to-date as of 3 day ago), with the official debian libftdi-dev package installed, which is at version 0.20-4. The infnoise software Makefile chose the wrong linker flag, apparently. Here's the output of make:
/bin/sh: 1: ldconfig: not found
cc -Wall -Wextra -Werror -std=c99 -O3 -I Keccak -I /usr/include/libftdi1 -DGIT_VERSION=\"Fourth-OshPark-Prototype-250-gfc0d99f\" -DGIT_COMMIT=\"fc0d99f58fff60b5cb7dca583f4bbcc60e1f63a2\" -DGIT_DATE=\"2018-04-10T06:52:23+02:00\" -DBUILD_DATE=\"2018-04-21T01:09:01-04:00\" -o infnoise infnoise.c healthcheck.c writeentropy.c daemon.c Keccak/KeccakF-1600-reference.c -lftdi1 -lm -lrt
/usr/bin/ld: cannot find -lftdi1
collect2: error: ld returned 1 exit status
Makefile:24: recipe for target 'infnoise' failed
make: *** [infnoise] Error 1

On Debian systems, ldconfig is found in /sbin, which is not in my unprivileged user's path. So the invocation of ldconfig failed, the FOUND variable was left empty, and thus the FTDI variable was set to -lftdi1 rather than -lftdi.
I changed the invocation of ldconfig to /sbin/ldconfig and the compilation was successful.
I notice that libftdi-config is installed in /usr/bin. When I run it as libftdi-config --libs, it prints -L/usr/lib/x86_64-linux-gnu -lftdi -lusb. That may be a more robust way to find the linker arguments.
Thank you!

Thanks for the suggestion with libftdi-config.
As it comes with libftdi-dev its a good option.


One question about the the boundary attentive module

Hi~
Does the input feature and start/end scores is pretrained in advance?

And I also concern that if my start and end scores are predicted very correctly, then the center feature after multiplication could go to zero. can it still very effective for proposal generation?

No, input features and start/end scores are directly trained on target datasets.
Actually, start and end scores cannot be predicted very correctly. For more details, you can refer to Appendices E.

Oh~, Thank you for your replying!
so... the input features training process and the encode/decode process are trained separately?

Yes


Add back links to Accessibility, Cookies, Privacy policy, Terms of use and Complaints

Context
Adding back links to the pages in Changes proposed in this pull request. In order to add dynamic back links to these pages, they needed to be converted to html.erb files first.
Changes proposed in this pull request

Convert the following markdown pages into HTML pages:

Make a complaint or give feedback

Accessibility

Cookies

Privacy policy

Terms of use

Add back links to these pages

These changes also apply to provendor (except terms of use and Privacy policy)

Guidance to review

This change means we will have two seperate privacy notices. Provendor uses the ContentHelper to generate breadcrumbs on this page (as they have two privacy policies). This is also in the same place that the back links would be. Any thoughts are welcome!

Look for typos, duplicated content etc

Link to Trello card
https://trello.com/c/WUyAMccc/4428-design-guidance-pages-dont-have-links-back-to-application-task-list

Thanks @avinhurry! I think this looks great.

I'm not sure this is particularly necessary? Because these static pages are linked to from every page (in the footer), the back link could take you anywhere, which feels a bit weird.
Relying the referer header also means you can get stuck in loops, where if you, say visit the terms of use page after the privacy policy page, and then keep pressing the back links, you end up alternating between the two pages. Also if you click on the page in the footer that you're already on, so that it reloads again, the back link ends up linking to the page you're already on. Finally if you land on one of the static pages from an external link, there's a back link to the main candidate sign in page – which is probably ok, but maybe a bit confusing as it isn't really taking you back to where you were previously?
That said, maybe this is all fine, and at least helps users who might read the terms of use from the sign up flow (which I imagine is very few people, but still..).

I didn't think about this issue until I visited these pages and then didn't know how to go back to the task list.
If you're on a website on a desktop computer you don't always think to use your back button on your browser, because it's quite far away from the action.

@EmmaFrith I like the idea of a "Back to application" link, as that tells you where you're going, and doesn't rely on you having been there immediately before (eg would still take you to application if you click on Terms of use and then Privacy policy).
Perhaps we could hardcode this link for all signed-in users, and for signed-out users either have no link or "Home" or "Back to create an account or sign in"?

that sounds good to me @frankieroberto, if there's a better way to solve the problem, do it!

@EmmaFrith I like the idea of a "Back to application" link, as that tells you where you're going, and doesn't rely on you having been there immediately before (eg would still take you to application if you click on Terms of use and then Privacy policy).
Perhaps we could hardcode this link for all signed-in users, and for signed-out users either have no link or "Home" or "Back to create an account or sign in"?

What would home be @frankieroberto? Assume root_path
Bare in mind that some of these pages will affect provendor too, so the solution needs to work with them too. Or we have seperate pages for all of these, which i'm not sure about because it means we have to keep both pages up to date.
The current solution works for both teams.


Add new GitHub org blog post

This adds a blog post around the new GitHub organization.
Signed-off-by: Jonas Rosland<EMAIL_ADDRESS>

Codecov Report

Merging #928 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #928   +/-   ##
=======================================
  Coverage   47.59%   47.59%
=======================================
  Files          76       76
  Lines        5175     5175
=======================================
  Hits         2463     2463
  Misses       2562     2562
  Partials      150      150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3290552...9d61dbf. Read the comment docs.

Thanks @jonasrosland !


Deploy APK Action

Where should the apk be deployed to? Github release?

Yes @Mastersam07

i will try this issue and make PR

Ok @lordvins226, assigned to you

I would have a workflow file ready. It generates a new version number, then builds and tests the build, and then makes a GitHub release with the newest version number and the built apk as an artifact.
I could create a pull request with the workflow file :)

Make your PR

@ecrax perfect! go ahead create a PR

@himanshusharma89 I have added a PR referencing this issue

Isn't this issue ready to close?

Yeah @ecrax, closing it. I thought you mentioned this issue in the PR (as Fixes #13) to automatically delete this issue.


add MCP server badge

This PR adds a badge for the mcp-search-linkup server listing in Glama MCP server directory.

Glama performs regular codebase and documentation scans to:

Confirm that the MCP server is working as expected
Confirm that there are no obvious security issues with dependencies of the server
Extract server characteristics such as tools, resources, prompts, and required parameters.

This badge helps your users to quickly asses that the MCP server is safe, server capabilities, and instructions for installing the server.

Thanks! are you on the MCP Discord?
Let me know your Discord username and I will give you a special flair that's only for MCP server authors.

Thanks! Yes, my Discord username is glm_x


Component removal

Now that we have a lot of the components extracted to their own packages/repos, I'm removing the extracted components from this repo in favor of the composer installed ones.
I've modified the test suites in the phpunit.xml file to use the test files from the composer installed components so that we still have a single place to run all tests, which might make testing against new versions of PHP easier (help us identify components that have issues with the new php version, so we can make necessary changes in the separate repo).
Updated README to reflect these changes.

I did test locally that the whitelist change caused the vendor files to show up in the report, but I think since they're not actually part of the repo, they won't show in codecov's report at all, which is fine.


scripts for local develop environment and document

Background
Karmada provide scripts used to start a minimize environment, more details you can refer:

local-up-karmada.sh
local-down-karmada.sh

The minimize environment includes one control-plane, and three kubeneters clusters consist of two cluster of pull mode and one cluster for push mode. For those who want to contribute the dashboard for karmada, we need to provide an out-of-the-box environment for open-source contributors.
Requirements

Share the same technology stack with karmada, which means we can use docker、kind、kubectl and some glue scripts like bash, but not golang because there is no need to compile karmada project
Support the popular os like macos、window， linux may be in low priority 🤔
Support multi arches, including amd64 and arm64


New version: Gruntwork.Terragrunt version 0.67.10

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-09-19 23:49:19.131 [FAIL] Installer failed security check. Url: https://github.com/gruntwork-io/terragrunt/releases/download/v0.67.10/terragrunt_windows_386.exe Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 896.)

@wingetbot run


Revise README for translation errors

This PR consists of minor grammatical revisions to the README (and fixes to a few of the examples).

thanks.


Fix misspelled icon paths

Corrects the paths for decrease/increase header in light mode.
Fixes #2

Thanks. Will be included in next version


feat(sort-imports): #138: Adds matcher option

Resolves #138 .
Description
This PR adds the following to sort-imports:

A matcher: 'minimatch' | 'regex' option (by default minimatch) that dictates what matcher is used for pattern matching for both the internalPattern and customGroups options.

[ ] Add tests.

[ ] Update documentation.

Can potentially be extended to other rules later.
What is the purpose of this pull request?

[x] New Feature

It seems we cannot use regex in ESLint config, config should be serializable.

Hi @azat-io !
Technically yes, you need to make sure that all your options are serializable, so you can not pass functions or complex objects in your config (in reality, passing your functions as string and eval them could probably work).
However, you can pass RegExp as strings fine: if we take the example of the issue to match any element like
import { i18n } from "../../../Basics/Language";
import { i18n } from "../../../../../Basics/Language";

a regular expression matching those is (?:\.\.\/)+Basics\/Language. You can them stringify it to pass it in the JSON config like so:
customGroups: {
    value: {
        myCustomGroup: '(?:\\.\\.\\/)+Basics\\/Language',
        },
    },

and use the RegExp constructor: return new RegExp(pattern).test(nodeName).
While flags (i, u, g, etc) are not directly handled by this method, I don't think this is too much of a problem in reality for our use cases.
What do you think?

@hugop95 Okay, it looks like good idea 👍

Perhaps we should add this option to all rules, is there an option to set customGroups?

@azat-io Sure!

It looks awesome, thank you!


ReplicationAcceptance test failing with IAM key

When running IAM-enabled tests, testRemoteLastSequenceValueAfterPushReplication intermittently fails.  It may be a latency issue since we test with CouchDB on sync002 for non-IAM and testy025/clientlibs-test for IAM.

ReplicationAcceptance
  testRemoteLastSequenceValueAfterPushReplication, ((localLastSequence) != nil) failed
  /Users/cloudantsync/jenkins-ios/workspace/enable-and-jenkins-test-IAM-Y2WEQZR5QS7CHU7CMGCWAILHKF2FH4XE2WEKCDVCPIUHD6R67HPQ/CDTDatastoreReplicationAcceptanceTests/ReplicationAcceptance.m:1747

    XCTAssertNotNil(localLastSequence);
    XCTAssertNotNil(jsonResponse[@"source_last_seq"]);

  testRemoteLastSequenceValueAfterPushReplication, ((localLastSequence[@"source_last_seq"]) equal to (jsonResponse[@"source_last_seq"])) failed: ("(null)") is not equal to ("3005") - local: (null), remote response {
  /Users/cloudantsync/jenkins-ios/workspace/enable-and-jenkins-test-IAM-Y2WEQZR5QS7CHU7CMGCWAILHKF2FH4XE2WEKCDVCPIUHD6R67HPQ/CDTDatastoreReplicationAcceptanceTests/ReplicationAcceptance.m:1750

    XCTAssertEqualObjects(localLastSequence[@"source_last_seq"], jsonResponse[@"source_last_seq"],
                          @"local: %@, remote response %@", localLastSequence, jsonResponse);
}

Executed 45 tests, with 2 failures (0 unexpected) in 6280.861 (6280.884) seconds

Closing, this is a dupe of #395


Mouse cursor is pointer when it shouldn't be (for time picker)

I'm Submitting a ...

[x] Bug report
[ ] Feature request
[ ] Support request

Steps to Reproduce
Go to the time picker and move the mouse off of a clickable element.
Expected Results
The mouse cursor should change to the default.
Actual Results
The mouse cursor stays as "pointer".
Minimal Reproduction of the Problem
Any existing demo exhibits this behavior in any browser.

Nice catch, thanks! I'll make sure it's fixed in the next version.

Fixed in #511.

Fix available in v2.13.0.


Add support for gz-compressed initramfs files

Currently booster generates zstd-compressed initramfs files. zstd compression is supported by Linux kernel since 5.9 version. But the older kernels (like Arch linux linux-lts) needs gz compressed files.
Add support for gz compression. Add a configuration option for used compression.

The default compression is still zstd. To use gzip compression one need to set it to /etc/booster.yaml config file.
I was looking for a more automatic way to configure compression at generation time, something like "if kernel was compiled with CONFIG_RD_ZSTD then use zstd initramfs, otherwise check for CONFIG_RD_GZIP". But I do not see how one can read kernel configuration from on-disk binary like /boot/vmlinuz-linux.

cc @libcg

I just built booster-git and regenerated the initramfs image for linux-lts using gzip/none. I'm not seeing any errors but it's hanging during boot just before "Welcome to Arch Linux" is displayed. When I add i915 in the modules, I can see modesetting is happening which indicates modules get loaded at least. 5.10 kernel boots fine.

I just built booster-git and regenerated the initramfs image for linux-lts using gzip/none. I'm not seeing any errors but it's hanging during boot just before "Welcome to Arch Linux" is displayed. When I add i915 in the modules, I can see modesetting is happening which indicates modules get loaded at least. 5.10 kernel boots fine.

@libcg the most likely reason you have this issue is a missed module needed to detect the root block device.
Could you please share output of lsmod when running your 5.4 kernel?

@libcg the most likely reason you have this issue is a missed module needed to detect the root block device.
Could you please share output of lsmod when running your 5.4 kernel?

I don't have access to my computer right now, but I'm using btrfs on my root partition. Might be related.

I don't have access to my computer right now, but I'm using btrfs on my root partition. Might be related.

Btrfs detection should work at 5.4 (and it seems works for you at 5.10).
Another way to debug the problem is to add booster.debug=1 and record the serial console output (easier to do with a phone camera).

Btrfs detection should work at 5.4 (and it seems works for you at 5.10).
Another way to debug the problem is to add booster.debug=1 and record the serial console output (easier to do with a phone camera).

lsmod.txt
booster.debug=1 output:

lsmod.txt
booster.debug=1 output:

Thank you @libcg for the information.
Checking your lsmod I see you have several modules that are currently not added to booster images by default: ahci and sg. Try adding the modules to your config one-by-one and see if it helps you to boot to LTS kernel. And then let me know what driver is missing - it should be part of default module set.
PS you can inspect the content of the generated booster image using lsinitcpio /boot/booster-linux-lts.img.

Thank you @libcg for the information.
Checking your lsmod I see you have several modules that are currently not added to booster images by default: ahci and sg. Try adding the modules to your config one-by-one and see if it helps you to boot to LTS kernel. And then let me know what driver is missing - it should be part of default module set.
PS you can inspect the content of the generated booster image using lsinitcpio /boot/booster-linux-lts.img.

@anatol it works fine after adding ahci to the list of modules. Makes sense since I'm using a SATA drive.

@anatol it works fine after adding ahci to the list of modules. Makes sense since I'm using a SATA drive.

@libcg thank you for your feedback. I added 'ahci' to the default modules list and with the recent commit you don't need to keep it in your config file.
Your issue should be resolved now. Please let me know if you still have any additional issues.

@libcg thank you for your feedback. I added 'ahci' to the default modules list and with the recent commit you don't need to keep it in your config file.
Your issue should be resolved now. Please let me know if you still have any additional issues.


feat: provide an interface for DatabaseUrl

+SemVer: minor

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (52a0716) 74.42% compared to head (b2c8434) 74.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   74.42%   74.42%
=======================================
  Files         221      221
  Lines        2772     2772
  Branches      464      464
=======================================
  Hits         2063     2063
  Misses        592      592
  Partials      117      117

Files
Coverage Δ

DubUrl.Core/DatabaseUrl.cs
60.00% <ø> (ø)

DubUrl.Core/DatabaseUrlFactory.cs
42.85% <ø> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Rename "A-Z Index" to "A-Z of classified goods"

Renamed in:

Menu
No results page
A-Z page title

 [TARIFF16] Rename: A-Z


Feature request - envisalink arm "night"

Sorry if this is not the place for feature requests..
The envisalink component currently provides "arm_home" and "arm_away", but do not have an "arm_night".
Most honeywell and DSC systems have a setting called INSTANT, which disables the entry delay (eg., full alarm goes off upon immediately opening any door / window).
Would this be something we can implement in the "arm_night" mode?  It's a very helpful security feature. My python skills are not excellent ... thank you for the consideration.

This is for bugs only. Feature and enhancement requests should go in our community forum: https://community.home-assistant.io/c/feature-requests


Allow for binaries to be installed via go install

Since this is golang tooling, I'd like to be able to use native go tooling to install the binary:
 ~ $ go install github.com/gruntwork-io/terratest@latest
go install: github.com/gruntwork-io/terratest@latest: module github.com/gruntwork-io/terratest@latest found
 (v0.40.6), but does not contain package github.com/gruntwork-io/terratest

The path needs to point to where the main code is for the command, which is in cmd/terratest_log_parser. So in this case, you can install the log parser with:
go install github.com/gruntwork-io/terratest/cmd/terratest_log_parser@latest

Similarly, to install pick-instance-type, you can run:
go install github.com/gruntwork-io/terratest/cmd/pick-instance-type@latest

Ah, nice. I'll close this out.

~ $ go install github.com/gruntwork-io/terratest/cmd/terratest_log_parser@latest
go: downloading github.com/gruntwork-io/go-commons v0.8.0
go: downloading github.com/urfave/cli v1.22.2
go: downloading github.com/sirupsen/logrus v1.8.1
go: downloading github.com/go-errors/errors v1.0.2-0.20180813162953-d98b870cc4e0
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/russross/blackfriday/v2 v2.1.0

that worked beautifully, and clearly the problem is a lack of experience with go-lang - any chance you folks might document these two install commands somewhere for other go-lang newbies encountering this?

Sure! I'll open a PR with the documentation update shortly.

PR with docs update: https://github.com/gruntwork-io/terratest/pull/1098

How to install terratest_log_parser for Github actions step during run time.How can i see those 3 files created during test run
I have below in my yaml file
  - name: Run Assertion Tests
    run: |
      cd test
      go install github.com/gruntwork-io/terratest/cmd/terratest_log_parser@latest
      go install github.com/gruntwork-io/terratest/cmd/pick-instance-type@latest
      go test -v ./... -timeout 30m | tee test_output.log
      terratest_log_parser -testlog test_output.log -outputdir test_output


[bug] talosctl commands fail with "error reading server preface: remote error: tls: bad certificate"

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
All talosctl commands fail with:
error fetching time: rpc error: code = Unavailable desc = last connection error: connection error: desc = "error reading server preface: remote error: tls: bad certificate"

This is the last one that I ran:
talosctl-1.5.3 time -n h12-london
error fetching time: rpc error: code = Unavailable desc = last connection error: connection error: desc = "error reading server preface: remote error: tls: bad certificate"

Expected Behavior
I would expect talosctl v1.5.3 to be able to communicate with this node running Talos OS v1.5.3.
Steps To Reproduce
macOS 12.6.9 Intel running talosctl v1.5.3:
talosctl-1.5.3 version
Client:
	Tag:         v1.5.3
	SHA:         cb21c671
	Built:
	Go version:  go1.20.8
	OS/Arch:     darwin/amd64

What browsers are you seeing the problem on?
No response
Anything else?
No response

Probably using wrong talosconfig (not from Omni).

This looks the right $TALOSCONFIG to me:

I was only showing the first 5 lines, the rest is exactly as downloaded from Omni.
Each cluster has a unique name, it gets a new name when it's re-created.
I deleted all of ~/Library/Application Support/talos, and still getting the same error.
How can I debug this further?

I will take a look at the server side logs, do you have a cluster name to help me to find it?

I restarted your instance, please let me know if it clears the error, but we'll still be looking for an actual error

That worked!

While a bunch of things are not showing as they should on the dashboard, at least omnictl is now working as expected.
Thank you!


Which file to edit?

In the section [Out-of-process hosting model|https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/aspnet-core-module?view=aspnetcore-3.0#out-of-process-hosting-model], you mention to edit some XML, specifically
<PropertyGroup>
  <AspNetCoreHostingModel>OutOfProcess</AspNetCoreHostingModel>
</PropertyGroup>

I assume, this goes to the csproj file. However, there is no note on where to do this. This problem occurs on several occasions through the document.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe69b3a9-896f-e189-0c2c-f87ff735df9c
Version Independent ID: 97c8549b-66ad-0a23-1971-784fb923042a
Content: ASP.NET Core Module
Content Source: aspnetcore/host-and-deploy/aspnet-core-module.md
Product: aspnet-core
Technology: aspnetcore-hostdeploy
GitHub Login: @guardrex
Microsoft Alias: riande

Yes, that's correct ... the project file.
I'll run through it today and make sure that's clear. Thanks for commenting.

Not every instance shown that's in XML goes in the project file. Some of those are for web.config and there's one I see for a publish profile.
I'll get them carefully called out sometime today.

Thanks for the quick fix!


fix: revert handle bom in text and json

Reverts node-fetch/node-fetch#1739
it was breaking older NodeJS versions

@LinusU


[Bug] bevfusion image feature not working

Prerequisite

[X] I have searched Issues and Discussions but cannot get the expected help.
[X] I have read the FAQ documentation but cannot get the expected help.
[X] The bug has not been fixed in the latest version (dev-1.x) or latest version (dev-1.0).

Task
I'm using the official example scripts/configs for the officially supported tasks/models/datasets.
Branch
main branch https://github.com/open-mmlab/mmdetection3d
Environment
bevfusion
Reproduces the problem - code sample
mmdet3d code
Reproduces the problem - command or script
normal run
Reproduces the problem - error message
as follows
Additional information
I tested lidar+CAM_FRONT, lidar+CAM_BACK, and the detection results were exactly the same. Then I set the input image to pure black, and the detection results were still normal.
But when the lidar input is set to an empty point cloud, the detection result is a bunch of chaotic BBoxes and the scores are all less than 0.1

lidar+black_image

empty lidar + all rgb image

Prerequisite

[x]  I have searched Issues and Discussions but cannot get the expected help.
[x]  I have read the FAQ documentation but cannot get the expected help.
[x]  The bug has not been fixed in the latest version (dev-1.x) or latest version (dev-1.0).

Task
I'm using the official example scripts/configs for the officially supported tasks/models/datasets.
Branch
main branch https://github.com/open-mmlab/mmdetection3d
Environment
bevfusion
Reproduces the problem - code sample
mmdet3d code
Reproduces the problem - command or script
normal run
Reproduces the problem - error message
as follows
Additional information
I tested lidar+CAM_FRONT, lidar+CAM_BACK, and the detection results were exactly the same. Then I set the input image to pure black, and the detection results were still normal. But when the lidar input is set to an empty point cloud, the detection result is a bunch of chaotic BBoxes and the scores are all less than 0.1

lidar+black_image

empty lidar + all rgb image

If you find something about it and share what you get, I'll appreciate it !


Only clean depsolver bundle when clean target is run

Using the new CLEAN_HOOK, the Makefile now only cleans out the bundle
when told to. This should avoid re-installing the bundle on local
invocations of make.
Also, remove the extra call to eunit in the travis target.

cc @chef/lob

:+1:


WIP ARROW-3822: [C++] add test for chunked string column, unchunked int column

Assert that TableBatchReader returns record batches which cover the whole table, even if one column is chunked and the other is not

@bkietz I reviewed my initial report. I think this test needs to check that all of the data is iterated through when reading from a Parquet file where the result is chunked. I don't think there is actually a bug in the implementation, though, at least not at the moment

moving this out of the 0.13 milestone for now since does not need to block


feat(dashboard): add model based query support

Overview
Add support for model based queries on dashboard widgets. Add a new resource explorer tab to add model based queries to widgets
Legal
This project is available under the Apache 2.0 License.

72 file changes CR is quite hard to read, would prefer if features can be broken down and CR are raised for those smaller chunks, Approving given on a high level its looks good and also @tracy-french has approved! I am not sure if this feature is gated , if exhaustive testing is still pending , I would suggest to gate this.

Yes, it is gated behind a feature flag already.


copy stream directly rather than buffer as a utf-8 string

Hi Per,
This change copies a returned InputStream directly to output rather than read it in to memory first.  The InputStream might be large (making buffering a problem) and might not be valid UTF-8 (e.g. could be arbitrary data returned as application/octet-stream).

:+1:

+1

:+1:


[Style] Improve the footer UI

Description
Spacing is required betwen about section and footer part ..
It would look better if Contact Us is in the middle, quick links on the left and the description on the right...
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a KWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@Rakesh9100  Please assign this issue to mee.

I don't think we need this change, please work on other good issues @Archi-shaw


are there I2C pins for this board?

43+44 as attached to the quIIC connector
The [qwiic ](https://www.sparkfun.com/qwiic) connector, also referred to as stemma QT or JST-SH 1.25mm, will give you easiest use of i2c, but the pins are broken out too.
You can always check the schematics for such things, but also the pinout diagram for other lilygo boards is more informative, so fair question

mmicky, please close. It looks like OP bailed on his question, or it was answered by tyeth

Ok I see it now, thanks for the advice.  might want to add the standard SDA and SCL markings to the pin diagram.  I didnt know CLK_OUT and CLK_OUT2 would indicate I2C.  Thanks!

To be fair the pinout diagram is missing some of the more useful extra pin function labels, like I2C, which is why the question was asked. Maybe it can be updated to be better, more like the T-Sim7000G which at least highlights i2c

ESP32 32 can map any peripheral to any gpio (except USB). I will close this question.

I disagree, although the mux supports remapping, not every pin to every function. Make life easier for people and include helpful info, it's not about what can be done, but what pins are the default for example if Wire.begin was called (and you have an IIC/I2C/qwiic connector for the purpose so it's defined although remappable).
It's new users you're helping, veterans will waste their time in datasheets and framework sourcecode or already know about remuxing.


Error in mohsin/txt/humans

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'information' in 'order clause' (SQL: select mohsin_txt_humans.* from mohsin_txt_humans order by information asc limit 20 offset 0)

This issue was resolved on the last commit. Please update your plugin and check if it persists. If it does kindly make a comment below describing the order of steps required to reproduce this issue and if possible screenshots

This issue is the same as issue #1 and it has indeed be resolved couple of hours ago. I've made a commit now to improve how the information field is shown in the column list and also added seeding data to agents table with a version bump in the plugin.
Please update the plugin in your backend and do let me know if the issue (or any other issue) persists. I'm closing this issue now. Thanks for your insights. Feel free to leave a review or suggestions in the plugin page if you like the plugin. Enjoy!

It's still crashing when clicking information or directives to sort them.

I'm seeing the same thing. Sorting appears to totally break things. I'm no expert in Laravel/October, but in glancing through the documentation I don't see anything wrong with the setup. So it seems like a larger bug, unless there's separate relationship setup for the sorting functions somewhere.

To specify, the initial view looks fine, but as soon as you sort, things break - and it's trying to load the information column without joining the two tables. Unfortunately, this sort is cached in the browser, so this breaks viewing the page altogether if you reload the view.

I couldn't recreate the issue in my end. Ultimately @drtzack removed the column entirely in his October install by removing
information:
    label: Information

in this file
Removing this doesn't break the plugin's original functionality. You won't be able to see the information column in the Humans view controller, that's it!
If you do find the crux of the problem feel free to make a PR and i'll add that after testing if it's a valid solution. I used the October scaffolding commands to generate the controller so the issue must probably be in RC of OctoberCMS rather than the plugin itself. Thanks for using Txt

I'm tending to agree - this seems like a bug in October or maybe Laravel - possibly with today's code update.
As long as you don't try to sort the columns, there's no problem. If you clear your browser cache and refrain from trying to sort the columns, it's alright. No need to remove the column, which nice to have...

That's the only reason i haven't removed it. I am considering removing the sorting alone until October is more stable. That way the plugin will not break and will be stable.

I am closing this issue. Kindly comment back if you still face this issue. I have not received any new reports on such an issue and believe that it has been patched in recent October updates. If you face this issue still, kindly comment with as much information as possible so that I can help you to resolve it.


Semi-transparent background of native ad view ios

https://github.com/bdlukaa/native_admob_flutter/blob/61a8d3c58c3470bdfc87b8acc1d7b586cac9aa32/ios/Classes/Native/NativeAdView.swift#L28
Why background color of NativeAdView isn't fully transparent? Could i change to transparent?

Native Ads on iOS isn't fully supported, as stated on the documentation. Please see #58

#66 released fix


Missing init param descriptions in documentation

I added descriptions of initialisation options to the docs yesterday. Filled most of them in but I'm afraid I couldn't complete some of them. @waveform80 could you take a look and fill in the gaps where I've left ??? (and maybe check the sensor ones I've attempted to write).
Sorry/thanks

This one's fully addressed in PR #101 as all the initializers are now documented from source code (and in each case I've gone through and ensured there are param descriptors for everything in the __init__)

This one's also good to go.


kubectl errors when process is sent to background

Description
When the sbctl process is sent to background process, it outputs a error when running kubectl
2022/04/04 15:45:58 called getAPIV1ClusterResources
2022/04/04 15:45:58 failed to decode file, will try addind list GVK couldn't get version/kind; json parse error: json: cannot unmarshal array into Go value of type struct { APIVersion string "json:\"apiVersion,omitempty\""; Kind string "json:\"kind,omitempty\"" }
2022/04/04 15:45:58 200 GET /api/v1/nodes?limit=500

Reproduction Steps

Send sbctl process to background using &.

sbctl serve --support-bundle-location=supportbundle.tar.gz &

Run any kubectl command.

kubectl get no

Expected Behavior
sbctl should generally handle when being used as a background process.
Customer Impact
The impact is two fold.

We have to have two terminals open or have a tmux/screen session open to get this to work without errors.
The error message is too verbose and we are planning to use this in Kubecon EU, so would like to clean these up.

Workaround
Open a Tmux session and start the sbctl in there to avoid being sent to background.
Environment
sbctl 0.0.4
Additional Information
There is also a typo on this line https://github.com/replicatedhq/sbctl/blob/main/pkg/sbctl/compatibility.go#L28

@aj-jester does https://github.com/replicatedhq/sbctl/pull/44 address the need for this?

Oh yah! Awesome! Thanks so much 🙏🏽

Hey @divolgin for some reason when I use sbctl shell it still gives these messages
aj@aj-cre-debug:/home/aj$ kubectl get po
2022/04/26 17:31:22 called getAPIV1NamespaceResources
2022/04/26 17:31:22 failed to decode file, will try addind list GVK couldn't get version/kind; json parse error: json: cannot unmarshal array into Go value of type struct { APIVersion string "json:\"apiVersion,omitempty\""; Kind string "json:\"kind,omitempty\"" }
2022/04/26 17:31:22 200 GET /api/v1/namespaces/default/pods?limit=500


Replace React.PropTypes with the new standalone PropTypes

This should prevent the warningAccessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead., when using react-chartist with React v15.3 and above.

Thanks @robinsoncol just merged and published to v0.13.0


Feature Request: IP address in :l listing

User requested that the IP address appears in the agent listing in addition to the hostname

Not at this time.


Optimize creation of update streams with dependencyTime column

Solves #198

SF3,000 got through the first batch of comments. It uses 500GB of RAM, so SF10,000 will likely need more daily Comment/Post batches instead of weekly ones. I'll turn this into a separate issue (along with the auto-detect thing) and merge this to allow the implementations repo to use this from main.


Explanation for contents of harmonic analysis output files

This is the small block explaning the contents of the files output by harpy that was missing in the omc3 Worfklow page (now renamed Analysis).
If someone knows what the remaining columns mean (FREQ1_3 etc) please contribute!

If someone knows what the remaining columns mean (FREQ1_3 etc) please contribute!

Based on the tune for the BPM, the frequency (& amplitude) of higher order lines is calculated (e.g sextupole lines) using m Qx + nQy .
So for your example, this then translates to m=1, n=-3 (underscores count as minus). For this case abs(m)+abs(n)=4, which should be a decapolar line. See e.g. https://cds.cern.ch/record/333077/files/p93.pdf for more information


PR proposal: Better CPU limits by default

I had a situation where cadvisor used 100% CPU on my machine (along another process (out of docker)). At this moment I realizes that there were no CPU limit on this stack.
PR Proposal
in our docker-compose.yml, we should include default CPU limits like this:

  cadvisor:
    image: google/cadvisor
    (...)
    deploy:
    (...)
      resources:
        limits:
          cpus: '0.20'
          memory: 128M
        reservations:
          cpus: '0.20'
          memory: 64M

Let me know if it makes sense.
Cheers!

@stefanprodan the PR is still waiting for you :-p
Cheers!

Continuing here https://github.com/stefanprodan/swarmprom/pull/92#issuecomment-467459685


README sample code modifies read-only property

The README includes a code snippet on how to configure Bugsnag:
config.notifyURL = [NSURL URLWithString:@"https://bugsnag.example.com/"];

This is not possible because notifyURL is a read-only property.

Never mind, I'm using an old version of Bugsnag.


Add Ballerina code detection support to GitHub

In GitHub repos, we can see what are the languages used. Ballerina code detection support can be added to the GitHub as well. This can be done using the Linguist library. We need to add the Ballerina code detection support to the GitHub after the GA.

This is now supported in github. Hence closing the issue.


Circular import issue when using constants from napari.components in napari.layers

🐛 Bug
When I tried to replace the cursor style strings in napari/layers/labels/_labels_mouse_bindings.py with the corresponding enum members to improve readability of the code (https://github.com/napari/napari/pull/5842/commits/10c748ceafe4cae424014907960e8da466561d92, #5842 ), I faced a circular import issue when building the docs:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/opt/hostedtoolcache/Python/3.9.[16](https://github.com/napari/napari/actions/runs/5012373806/jobs/8984257710#step:8:17)/x64/lib/python3.9/site-packages/napari/layers/__init__.py", line 11, in <module>
    from napari.layers.labels import Labels
  File "/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/napari/layers/labels/__init__.py", line 1, in <module>
    from napari.layers.labels import _labels_key_bindings
  File "/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/napari/layers/labels/_labels_key_bindings.py", line 5, in <module>
    from napari.layers.labels.labels import Labels
  File "/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/napari/layers/labels/labels.py", line [22](https://github.com/napari/napari/actions/runs/5012373806/jobs/8984257710#step:8:23), in <module>
    from napari.layers.labels._labels_mouse_bindings import (
  File "/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/napari/layers/labels/_labels_mouse_bindings.py", line 1, in <module>
    from napari.components._viewer_constants import CursorStyle
  File "/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/napari/components/__init__.py", line [24](https://github.com/napari/napari/actions/runs/5012373806/jobs/8984257710#step:8:25), in <module>
    from napari.components import _viewer_key_bindings  # isort:skip
  File "/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/napari/components/_viewer_key_bindings.py", line 5, in <module>
    from napari.components.viewer_model import ViewerModel
  File "/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/napari/components/viewer_model.py", line 46, in <module>
    from napari.layers import (
ImportError: cannot import name 'Labels' from partially initialized module 'napari.layers' (most likely due to a circular import) (/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/napari/layers/__init__.py)
Error: Process completed with exit code 1.

One of the solutions is using delayed import. In the napari/components/_viewer_key_bindings.py the ViewerModel is used in one function. So import may be moved to the body of this function and under if TYPE_CHECKIN clause.
The general solution will be to rewrite action registration, but it requires many working hours.

I'll also mention https://github.com/napari/napari/issues/5289 as one general way to identify other lurking circular imports.

One of the solutions is using delayed import. In the napari/components/_viewer_key_bindings.py the ViewerModel is used in one function. So import may be moved to the body of this function and under if TYPE_CHECKIN clause.

It doesn't work, I've just tried that in https://github.com/napari/napari/pull/5842/commits/38107e8208676e24a578e1fd96575b4168d37ac7, it is still getting circular import error. It is used in a decorator, so it is called during a function instantiation, it cannot be delayed.
The actual problem is not with this decorator. It comes from napari/components/__init__.py, which is called when you try to import anything from napari.components. Even if you solve the problem with the actions registration, the circular import will still present, because napari/components/__init__.py imports ViewerModel directly after _viewer_key_bindings, which in turn imports napari.layers and so on.

I think the root of the issue with circular imports in napari is that constants like in _viewer_constants.py sit deeply inside modules and when you try get access to them they import a lot of unnecessary things through __init__.py in the root of modules. The same thing applies to napari/layers/labels/_labels_constants.py and so on.
Constants should not be dependent on anything and should be accessible without the need to import entire modules.


Time zones in timestamp columns break in MySQL 5 Strict Mode

If MySQL 5.0 is in strict mode, the ' T' in the datetime format, 'Y-m-d H:i:s T' causes MySQL to throw a critical error and the insert/update is aborted.
I haven't tested this but I am assuming it is a problem in Column.php and Model.php as well as Connection.php.

A solution found in the forums uses ActiveRecord\Connection::$datetime_format = 'Y-m-d H:i:s';.


[docs] Add the 'chart for Material-UI' reference

@Krijovnick Can we add a small notice about the non-MIT license like? Just so people know upfront? :)


hubs should stop programs if not connected

probably send a message to PC and when no response stop program
this helps when things go wrong

is implemented, but need to test irl with new io_hub firmware

seems to work in practice as well


Allow detection of taps on TabBar

See #24224
I have added a callback to the TabBar that is called if not null. This would fix all 3 of these examples.

This will need a test.

Generally speaking I'd like to keep callbacks such that not setting one and setting one to a no-op callback (as in () { }) do the same thing (i.e. adding a no-op callback shouldn't change behaviour). It can be a bit unintuitive if adding something that does nothing does something. :-)
Not really sure what the best way to do that here would be, though...
cc @HansMuller

I have opened an issue so there can be proper discussion (should have done this before) #24224. A potential solution would be to handle this in the _handleTap function, first let the TabBar handle the tap, and then invoke a callback to the user if non null.

@HansMuller Thanks for the review, I believe these have now been resolved.


Fix scoped associations with empty loaded records

Summary
This PR addresses a few bugs found while working in our Rails application. They impact associations with a scope, like so:
class Coupon < ActiveRecord::Base
  has_many :coupon_redemptions, -> { where(expired: false) }
end

These bugs are caused by assuming that the list of in-memory targets have not been persisted to the database when the list of persisted records is empty.
Specifically, these are the 3 issues addressed:

assert_empty with .to_a at the end.

coupon = Coupon.create!
coupon_redemption = coupon.coupon_redemptions.create!
coupon_redemption.update!(expired: true)
assert_empty coupon.coupon_redemptions.to_a

This test used to fail because CollectionAssociation#merge_target_lists would return the in-memory records if no persisted records came back from the database. After this commit the test will pass because merge_target_lists will filter out any persisted records from the in-memory list.

assert_empty without .to_a at the end.

coupon = Coupon.create!
coupon_redemption = coupon.coupon_redemptions.create!
coupon_redemption.update!(expired: true)
assert_empty coupon.coupon_redemptions

This test used to fail because CollectionAssociation#empty? did not account for persisted records in memory before checking for emptiness. This commit adds that scenario.

Calling .size before assert_empty

coupon = Coupon.create!
coupon_redemption = coupon.coupon_redemptions.create!
coupon_redemption.update!(expired: true)
assert_equal 0, coupon.coupon_redemptions.size
assert_empty coupon.coupon_redemptions

This test used to fail through a more complex path. When asserting coupon.coupon_redemptions.size the target gets marked as loaded as part of HasManyAssociation#count_records. This is an issue as the target value is not empty when we expect it to be. The comment in the method above validates that.
After this commit, the test will pass because we set the target to an empty array if target has no new records.

Reproduction script with a failing test for each individual issue
# frozen_string_literal: true

require "bundler/inline"

gemfile(true) do
  source "https://rubygems.org"

  git_source(:github) { |repo| "https://github.com/#{repo}.git" }

  gem "rails", github: "rails/rails", branch: "main"
  gem "sqlite3"
end

require "active_record"
require "minitest/autorun"
require "logger"

ActiveRecord::Base.establish_connection(adapter: "sqlite3", database: ":memory:")

ActiveRecord::Schema.define do
  create_table :coupons, force: true do |t|
  end

  create_table :coupon_redemptions, force: true do |t|
    t.integer :coupon_id
    t.boolean :expired, default: false
  end
end

class Coupon < ActiveRecord::Base
  has_many :coupon_redemptions, -> { where(expired: false) }
end

class CouponRedemption < ActiveRecord::Base
  belongs_to :coupon
end

class BugTest < Minitest::Test
  def test_loading_associations
    coupon = Coupon.create!
    coupon_redemption = coupon.coupon_redemptions.create!
    coupon_redemption.update!(expired: true)

    assert_empty coupon.coupon_redemptions.to_a
  end

  def test_associations_not_loaded
    coupon = Coupon.create!
    coupon_redemption = coupon.coupon_redemptions.create!
    coupon_redemption.update!(expired: true)

    assert_empty coupon.coupon_redemptions
  end

  def test_associations_size
    coupon = Coupon.create!
    coupon_redemption = coupon.coupon_redemptions.create!
    coupon_redemption.update!(expired: true)

    assert_equal 0, coupon.coupon_redemptions.size
    assert_empty coupon.coupon_redemptions
  end
end

Other Information
Removing this guard clause should not affect performance since persisted is empty, so the map! won't do anything.
def merge_target_lists(persisted, memory)
  return persisted if memory.empty?
- return memory if persisted.empty?

  persisted.map! do |record|
    # ...
  end
end

Actual PR is here https://github.com/rails/rails/pull/45019


Crash while rendering ModelSelect2 widget in 3.3.0rc5

I am using Django 1.8.
What am I doing:
from dal import autocomplete

class MyForm(forms.Form):
    some_field = forms.ModelChoiceField(
        queryset=SomeModel.objects.all(),
        widget=autocomplete.ModelSelect2(url='some_url')
    )

Stacktrace:
...
File "/usr/lib/python2.7/site-packages/django/forms/forms.py" in __str__
  537.         return self.as_widget()
File "/usr/lib/python2.7/site-packages/django/forms/forms.py" in as_widget
  593.         return force_text(widget.render(name, self.value(), attrs=attrs))
File "/usr/lib/python2.7/site-packages/dal/widgets.py" in render
  150.         widget = super(WidgetMixin, self).render(name, value, attrs, renderer)
File "/usr/lib/python2.7/site-packages/django/forms/widgets.py" in render
  513.         options = self.render_options(choices, [value])
File "/usr/lib/python2.7/site-packages/dal/widgets.py" in render_options
  124.         html = super(WidgetMixin, self).render_options(*args)
File "/usr/lib/python2.7/site-packages/django/forms/widgets.py" in render_options
  539.         for option_value, option_label in chain(self.choices, choices):

Exception Type: TypeError at ...
Exception Value: 'NoneType' object is not iterable

Conclusion:

Issue is Django version related.
This doesn't happen in DAL version 3.2.10.
dal.widgets.WidgetMixin.render calls super() with invalid arguments.

See inspection below.
Inspection:
>>> from dal_select2.widgets import ModelSelect2
>>> pprint(ModelSelect2.__mro__)
(<class 'dal_select2.widgets.ModelSelect2'>,
 <class 'dal.widgets.QuerySetSelectMixin'>,
 <class 'dal.widgets.WidgetMixin'>,
 <class 'dal_select2.widgets.Select2WidgetMixin'>,
 <class 'django.forms.widgets.Select'>,
 <class 'django.forms.widgets.Widget'>,
 <type 'object'>)

# dal.widgets.WidgetMixin
class WidgetMixin(object):
    ...
    def render(self, name, value, attrs=None, renderer=None):
        """Call Django render together with `render_forward_conf`."""
        # ----> 4th argument is render <----
        widget = super(WidgetMixin, self).render(name, value, attrs, renderer)
        try:
            field_id = attrs['id']
        except (KeyError, TypeError):
            field_id = name
        conf = self.render_forward_conf(field_id)
        return mark_safe(widget + conf)

# django.forms.widgets.Select
class Select(Widget):
    ...
    # ----> 4th argument is choices <----
    def render(self, name, value, attrs=None, choices=()):
        if value is None:
            value = ''
        final_attrs = self.build_attrs(attrs, name=name)
        output = [format_html('<select{}>', flatatt(final_attrs))]
        options = self.render_options(choices, [value])
        if options:
            output.append(options)
        output.append('</select>')
        return mark_safe('\n'.join(output))

Signature of django.forms.widgets.Select.render(), the inclusion of the 'rederer' parameter, has changed since Django 1.11.

Would love to review a patch for this ;)

Fair enough :-)
I'll provide one within the next few days, when I found some time for it.

@jpic
I believe you have already fixed this issue in commit:
https://github.com/yourlabs/django-autocomplete-light/commit/823247eb4a0e1b97ae9bd54e1e7eef05cc8ea868
I just upgraded from 3.3.0rc5 to master branch, and it works okay.
This issue can be closed.

Sorry, I thought my fix was in the release that you reported still broken :/
Released master on 3.3.0-rc6
Thanks for your support


make it a dual module that can be imported into Browser (or Deno scripts) via CDN

title of issue says it all, using the body only to collect info on how to do it.
https://2ality.com/2019/10/hybrid-npm-packages.html seems to have the clearest explanation, but the core point is:

to be compatible with older versions of Node, we need to ship CommonJs and ESM versions of the JavaScript sources in the same package
it doesn't give any hints on how to build such packages, especially in our case of a project that does not use rollup or a transpiler. npm publish just publishes the source

This example project actually seems nice: https://github.com/dandv/local-iso-dt

edit your code as ES module and use babel to create a CommonJs version for backward compatibility
package both as described by duality above
if you write a new package, make it ESM only, because new projects can directly use that
is it so that TypeScript compiler or other tool in its ecosystem allows a CommonJs module to be imported via ES syntax? then maybe many users do that already and we can just switch to only support that – but I guess for any project with a lot of users, it would just break updateability for some people

other info for context, but doesn't seem to have the simplest information:

https://blog.logrocket.com/es-modules-in-node-js-12-from-experimental-to-release/
https://stackoverflow.com/questions/29738381/how-to-publish-a-module-written-in-es6-to-npm
https://github.com/nodejs/modules/blob/master/doc/unflagging-announcement.md (has a dead link to a "Dual CommonJS/ES Module Packages" section of the next doc)
https://nodejs.org/api/esm.html
especially: https://nodejs.org/api/esm.html#esm_compatibility_with_commonjs_only_versions_of_node_js

Last time when I thought about it, here is what I came up with.
When I write a new library, I am most likely to write it in TypeScript. Let's say that i write it in src. It has to be transpiled for Node anyway, so it can be transpiled twice just as well - once for ESM and once for CommonJS, e.g. into esm and cjs directories and reference those in package.json as module and main. Deno could use the src directly but there is one catch - file extensions in imports. For Deno they are mandatory, for tsc they are forbidden. I'm not sure if we can configure the tsc to support the extensions in imports (last time I checked there was an opposition to that idea because that would require rewriting of the path strings during transpilation but maybe it has changed).
Another thing is of course different Node and Deno APIs and for that there are some limited compatibility layers like https://deno.land/std/node/ and see also denoland/deno#2644 but there is nothing that is complete yet.
What I would do is I would write wrappers for those functions that I need to use. It's common that I don't use an entire Node or Deno API but just a limited number of things, for which I could write wrappers and use different implementations for those for the Node transpilation and for Deno.
When I actually thought about it, my idea was to do something like this:

write in src for Deno with .ts extensions in imports
use wrappers for everything that touches the Deno namespace or imports external modules (std or third party) and put them in src/compat or something (yeah, naming things..)
write the same compatible wrappers for Node and put them in node/compat (outside of src)
build step is:

copy src to node-src
remove node-src/compat
copy node/compat to node-src/compat
remove file extensions from all imports in node-src
run typescript transpiler on node-src with a target of dist/esm
run typescript transpiler on node-src with a target of dist/commonjs

This is actually a little changed from my original idea, because it was back in the days when I couldn't make VS Code work with code with extensions in imports, so the original idea was to write imports for Node and then process it adding extensions for Deno, but now since Code works fine I think that it's nice that one target can be left as is with no processing.
Also I didn't think about two targets for Node but just about the CommonJS. Now I probably would go for two, or maybe even for just ESM.
Another things is maybe thinking about a better name for src like maybe deno or something. In deno.land/x we cannot give a prefix for the code so it will be visible in imports as: import { x } from "https://deno.land/x/src/mod.ts";
Well, actually, there could be a mod.ts in the top level directory with just export * from "./deno.mod.ts"; so it can be outside.
This would be my approach if I was to do it today.  I am not so much concerned about ESM/CommonJS hybrid but about Deno/Node hybrid project.
It's good that you reminded me about it, because I have to put some thought into it and put it to practice. I know that there is probably not the direction that you were probably thinking.
Now, this particular project is a single file with no imports so it's much easier than it would be if that was not the case.
Let's see what other idea you collect here, since you asked for that on denolife/Lobby on gitter.

By the way, admittedly not the most elegant solution but I was able to use your module unchanged in Deno:
const r = await fetch('https://raw.github.com/matey-jack/node-http-link-header/master/lib/link.js');
const link = eval(`(m=>((module=>{${await r.text()}})(m),m.exports))({})`);

let l = link.parse( '<example.com>; rel="example"; title="Example Website"' );

console.log(l);

See:
$ deno run --allow-net l.ts
Link { refs: [ { uri: "example.com", rel: "example", title: "Example Website" } ] }

You need --allow-net like for dynamic imports. Not pretty but it works.
I need to make library that does this kind of import, maybe it would be useful to someone for tests.

@rsp I would say fetch + eval wrapper function is no worse than require in Node, since both basically eval the code with a function wrapper that provides module and more variables

@kevinkassimo I agree.
I remember when I accidentally discovered that wrapper by making a typo in the first line of the file and saw something like this:
$ node8 x.js
/Users/rsp/deno/test/hybrid/x.js:1
(function (exports, require, module, __filename, __dirname) { )
                                                              ^
SyntaxError: Unexpected token )

And I was like: What? I didn't write that!
It's funny that I had to use an older node because the current one hides this:
$ node x.js
/Users/rsp/deno/test/hybrid/x.js:1
)
^
SyntaxError: Unexpected token ')'

So today people may never discover it by chance :)
I did some archeology and it's very interesting to see how the wrapper changed over the years. I wrote about it on Stack Overflow but before you see it, here's a 100 points question:
The wrapper provides exports, require, module, __filename, __dirname. When the wrapper used to provide only one parameter - which one was it?
See it in my answer to: Why we need to pass module.exports as a parameter since we are already passing module as a parameter? The order of adding (and removing!) parameters was quite surprising to me.

Thanks for all those insights!
For the moment I'll go the easy way and use this fork as the ES6 export and the upstream project for NPM. This way I can experiment making a Deno-based build and test pipeline.
Keep this issue open, since merging back with upstream seems useful long-term.

@matey-jack also take a look at https://www.pika.dev/


Add workspace context switching

Fixes

https://issues.redhat.com/browse/HAC-2748
https://issues.redhat.com/browse/HAC-3079
Description

This PR is built on top of Saud's workspace switcher component https://github.com/openshift/hac-dev/pull/394 and contains following changes.

[x]  Modified all the routes to include workspace context in urls, now we can share the workspace urls to other users.
[x] Created a workspace context provider to fetch all the workspaces
[x] Added workspace switcher in application list page as well

Note:
Selection of workspace is based on the below order

A workspace URL is shared to you and if you have access to that workspace, then it will be selected.
Local storage (last used workspace)
First workspace from api response ( will be changed to your Home workspace, once we get type: home prop in the API response)

Type of change

[x] Feature

Screen shots / Gifs for design review

Application list page:

video:
https://user-images.githubusercontent.com/9964343/218151808-4944dd2e-5f8c-4761-98a2-4f13588812aa.mov
Unit tests
  useActiveWorkspace
    ✓ should return default values (56 ms)
    ✓ should set workspaces from the api results  (6 ms)
    ✓ should return default values if the workspace API errors out  (3 ms)
    ✓ should should select the workspace from url (10 ms)
    ✓ should should fallback to localstorage if the workspace from url is not available in the list (8 ms)
    ✓ should should honor the workspace from localstorage (4 ms)
    ✓ should should not navigate to the selected workspace route if the user is in non workspace pages (5 ms)
    ✓ should navigate to the selected workspace route (53 ms)

  useActiveNamespace
    ✓ should return default values when the api is still fetching (31 ms)
    ✓ should return namespace information from the api results (4 ms)
    ✓ should honor the namespace from localstorage   (8 ms)
    ✓ should fallback to first namespace from api response when namespace in localstorage is not available in the list (3 ms)
    ✓ should return default values if the namespace API errors out  (25 ms)

How to test or reproduce?

Browser conformance:

[x] Chrome
[x] Firefox
[x] Safari
[ ] Edge

cc: @rohitkrai03 @christianvogt @rottencandy

Do we need to change this link as well? Clicking this tab gives 404 https://github.com/openshift/hac-dev/blob/6b40bc63b4c8daab02cc9c3df4536f51076b8428/src/components/IntegrationTest/IntegrationTestDetailsView.tsx#L98

Something going on with the app switcher now:

Something going on with the app switcher now:

This is likely happening due to menu heights not being reset on tab switch, fixed it in #394

/lgtm

/retest

/hold
We need to merge the dependent https://github.com/openshift/hac-dev/pull/394 first. Also, we can wait for this one to go after MVP release date.

/retest

Should these pages have the workspace in the breadcrumbs?

Should these pages have the workspace in the breadcrumbs?

Yes, I think all the pages that have breadcrumbs should include workspace context as well. @karthikjeeyar Maybe we can create a common breadcrumb utility that includes this base breadcrumb and then different pages can add there own breadcrumb pieces.

@jeff-phillips-18 @rohitkrai03 I have added breadcrumbs in all the details pages as well.

/retest

lgtm

/retest

/hold cancel

Hey, @rohitkrai03 I wanted to start discussing the workspace switcher from the hac-core/sdk side. We have https://github.com/openshift/dynamic-plugin-sdk/pull/202 open to finish out the feature request if you'd like to give that a look and make sure that we're covering all the features you would need whenever we swap to the SDK hook. I want to avoid breaking any of your implementations.


Update Medical

I don't think this is all of it, but I can't think of or find any other adjustments we've made that haven't been ported here already.

actually not ready, need to add all this to the filelist!!! will do it for human overrides too while I'm here since they tie into medical

wait nvm it's already in there