testing: T.Context usability concerns

https://groups.google.com/d/topic/golang-dev/rS6psxIf17Q/discussion
Decide on whether to keep/change/remove the API before the 1.8 release.

Issue #18182 was another person asking for this last night.
Their motivation: https://github.com/golang/go/issues/18182#issuecomment-264961911

#16221 is the proposal that added T.Context

Copying here the point made in golang-dev, for clarity:
Such a flagging mechanism that by definition will only be useful when things will continue running in the background past the test completion does feel like a wart to me. We should be discouraging people from doing that in the first place, because arbitrary background logic delayed for arbitrary periods of time while other things are being tested is a common source of testing pain, breaking in curious and hard to reproduce ways.
As people pointed out, it's not a mere case of putting logic locally. The context, by definition, will only trigger code to start aborting after it's too late. An aborting yet running goroutine can do whatever it wants in order to attempt to stop cleanly.
In my own testing, services generally have a Stop method because of that. Internally, they leverage a tomb to flag the stopping and block until everything is done cleaning themselves up. Stop also usually returns an error, so one can also check that the stop was itself clean.

Summary of my thoughts.
We should either:

Add both (a mechanism to signal for termination AND a mechanism to wait for all to be terminated)
Not add anything new add all

I understand most uses of Context don't care about waiting for termination, but I believe it is important enough in a significant number of testing purposes.
Some arguments against the status quo (i.e., only adding Context):

The same argument for adding Context for convenience can also be made for adding some wait mechanism. Adding Context saves 2 lines of code. Adding some mechanism for waiting saves another 2 lines. It's a slippery slope. Where do we stop?
Adding Context alone makes it such that you cannot easily add a wait mechanism since there is no way to insert a post-cancelation wait. That is, the testing framework will only call cancel when the Test function returns, but using your own WaitGroup.Wait will prevent the Test function from even returning.
You could resolve the above issue by just not using T.Context and roll with your own Context and WaitGroup, but now you have to deal with remembering whether you should be using your own ctx variable that you pass around or T.Context.
We already have a problem with many tests calling T's method when the Test function returns. The lack of a built-in waiting mechanism encourages people to do this incorrectly. Imagine the following:select {
...
case <-t.Context().Done():
    if err := something.Close(); err != nil {
        t.Errorf("unexpected Close error: %v", err) // This is problematic!
    }
}

If we go with adding a wait mechanism, I don't feel strongly whether it's by exposing a WaitGroup, or by adding a Go method as @bcmills suggested in #16221, or something else.

There is one benefit of adding Context that does not apply to a mechanism for waiting: it is otherwise difficult to construct a Context which is canceled when the test has failed but the test function is still running (e.g. when t.Failed() transitions to true).
So a minimal fix might be a Context which is canceled only on failure (and which otherwise explicitly leaks goroutines), or perhaps a Context which is canceled on failure and explicitly panics if its methods are called after the test function has returned.  That would address the "finding out when the test has failed" case but leave the "cleaning up the test" boilerplate in user code (where it is today).

I think canceling the Context upon first failure is inconsistent with how tests work. When t.Error is called, it is normal to continue moving on and perform other tests. If the first t.Error caused the context to be canceled, then that would affect the results of following tests within the same Test function. I'm okay with cancelation occuring when t.Fatal is called, but that is included in the current behavior.
The fact that people have differing expectations of when T.Context gets canceled is an argument against adding it. At least with rolling with your own context, the expectations are clear. So far there have been at least 3 expressed ways people expect it gets canceled:

(current behavior) Only when the Test ends
Only when the Test fails
Only when the Test times out (however that is defined)

When t.Error is called, it is normal to continue moving on and perform other tests.

Good point.  Still, especially given the ability to create subtests I think there are a number of situations in which "cancel on first failure" really is what you want.  But perhaps that argues for something more like errgroup, combining "cancel on first failure", "ignore subsequent errors", and "wait for cleanup" into a single API.

Another data point. There are use-cases where we want to add graceful timeout to tests. The current implementation of t.Context provides no way for the user to manually cancel the context other than returning from the Test function.

If you want a timeout, you can make a derived context from t.Context(). Again, this isn't supposed to be the end-all Context for all imaginable use cases. It's supposed to be a convenience thing.
And having a context available would've helped a CL I reviewed yesterday (https://go-review.googlesource.com/c/33972/1/http2/transport_test.go) if the context were available. But it was a few lines of code without t.Context, so we survived.
But obvious you dislike it, so feel free to send a CL removing it and the documentation from go1.8.html.
Perfect is the enemy of good.

I'm submitting a CL to revert this change. There are a fair number of people who have reservations about  this.
The main argument for adding t.Context seems to be for convenience (saving ~2 lines) and for consistency with the rest of standard library (which is moving towards adding Context where it makes sense). However, the benefit of convenience and consistency is offset by increased risk of users calling t.Error after the Test has returned. Overall, I don't believe a 2-line convenience is worth the real risk of improper t.Error usage (which is already a fairly common problem in tests).
To be fair, I originally voted in favor of this change in #16221, but changed my position on this after trying to use it on several unit tests.
I am personally still in support adding t.Context in conjunction with a wait mechanism as this will counter the current detriment of adding t.Context only. However, I don't believe that we should rush on more API design and we can revisit this for Go 1.9.

One possibility might be to add:
// Go starts a new goroutine running f. The passed context is canceled
// when the test completes. The next test will not be run until
// f returns - the test will fail if f takes too long to return after
// the test has completed.
func (t *T) Go(f func(context.Context))
That way the test can at least wait for the goroutine to finish
before ending the test.

If the idea of T.Context() is ever revisited, I'd suggest considering also including the test name with WithValue.  This would mean that if you're using a logging mechanism other than T.Log with parallel tests (and test -v), you'd have an easy way of labeling logs with the test name.


Firefox 62 Video problems

I have used all  branches for webRTC including the latest beta and mater branch on Firefox 62.0.3 and its not working. it is working fine on chrome but not on Firefox. Even no errors are appearing in the console.
Please need a fix for this issue soon.
Can anybody tell me what to do.
Pardon for my grammar,

This version works for me:
https://easyrtc.sylaps.net/demos/demo_audio_video_simple.html
For the messages, in my solution I get:

For old version: navigator.getUserMedia has been replaced by navigator.mediaDevices.getUserMedia
For new version:
a) onaddstream is deprecated! Use peerConnection.ontrack instead.
b) RTCPeerConnection.getLocalStreams/getRemoteStreams are deprecated. Use RTCPeerConnection.getSenders/getReceivers instead.

And my solution does not work in FF, both ways :-(. Need to fix.

I will investigate, keep you posted

@syedMSohaib what do you mean by video problems ? The video is black or you are not able to get local video, or the remote stream is not received ?

@hthetiot Hey buddy so sorry for late response.
Well i am not able to get local video stream on firefox to firefox. but in case of chrome to firefox i do get a black video stream. Didn't know why it showed different behaviour
And One more request can you update the demo on the website. i guess its bit outdated wrt to the collaboration you guys are doing.

You have TURN/STUN issue most likely.
I will update easyrtc.sylaps.com to master soon.
You should try to check your TURN and STUN server and avoid to have to much of them cause firefox does not like it.

Can you provide firefox and chrome version used please @syedMSohaib

Sir Actually i am testing it as local and i guess i don't need stun and turn  at my localhost
btw the chrome version i am using is 69 and firefox is 62 both are latest updates.

Thx @syedMSohaid I will test and let you know.

Still cannot reproduce on last test pass on master

see #415 for beta for adapter 6.4.0 and #433 for PR with latest adapter 7.2.1.
see beta or 6.4.0 test result vs master
#422 (comment)


update the etw/amsi patch sig

defender consistently flags it now using behavior/suspiscious amsi stream

Donut already contains a modular system for bypasses, including multiple bypass examples. In bypass.c you can see that there are multiple bypasses each surrounded by an ifdef. Which one is compiled into the shellcode is determined by compiler flags. In the makefiles Bypass A is the default. You can change that to Bypass B or another one. And add your own as well. That allows users to replace signatured code on their own in an easy, modular fashion.

which one would you use for the AMSI bypass C or D?

Learn to crypt, everything is already there. If you can use the tool, it therefore means that you can be a part of the project. Use it wisely, if you find a way to patch AMSI share it with the community with a pr. Good Luck.

which one would you use for the AMSI bypass C or D?

Learn to crypt, everything is already there. If you can use the tool, it therefore means that you can be a part of the project. Use it wisely, if you find a way to patch AMSI share it with the community via a pr. Good Luck.


There is one CSRF vulnerabilities that can create new pages or update the website settings

1.There is a CSRF vulnerability that can create new pages
poc:
<html>
  <!-- CSRF PoC - generated by Burp Suite Professional -->
  <body>
  <script>history.pushState('', '', '/')</script>
    <form action="http://<IP_ADDRESS>/ign/index.php/admin/pages/add_page" method="POST" enctype="multipart/form-data">
      <input type="hidden" name="name" value="cesiceshi" />
      <input type="submit" value="Submit request" />
    </form>
  </body>
</html>

Added CSRF precautions


Add types support like in koa

should add type support like Koa. It's simple example with correct typings

[+] jest-koa-mocks Minor: add better typings

Hi, Vladislav!  Thank you for your contribution.  Could you take a look at fixing the CI failure in this branch, please?  It looks like it's related to the types that you're altering:
lerna ERR! $ tsc --p tsconfig.build.json
lerna ERR! src/create-mock-context/create-mock-context.ts(19,15): error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
lerna ERR! src/create-mock-context/index.ts(1,8): error TS1192: Module '"/home/travis/build/Shopify/quilt/packages/jest-koa-mocks/src/create-mock-context/create-mock-context"' has no default export.
lerna ERR! info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

If you could sign the CLA, too, that you be really helpful 👍

@vsumner - I'm on vacation for a bit.  Since you're already poking at this package, could you shepherd this through, please? 😸

If you could sign the CLA, too, that you be really helpful 👍
Yet

I using Koa mock context in my tests. And it's my example
import * as httpMocks from 'node-mocks-http'
import * as Koa from 'koa'

export interface MockContext<RequestBody = undefined> extends Koa.Context {
  request: Koa.Context['request'] & {
    body?: RequestBody
  }
}

export const koaMockContext = <
  State = Koa.DefaultState,
  Context = MockContext,
  RequestBody = undefined
>(
  requestBody?: RequestBody
) => {
  const req = httpMocks.createRequest()
  const res = httpMocks.createResponse()
  const app = new Koa<State, Context>()
  const context = app.createContext(req, res) as MockContext<RequestBody> & Koa.ParameterizedContext<State, Context>
  res.statusCode = 404
  context.request.body = requestBody
  return context
}


Update pledge form text for DCAF instance

Thanks for creating an issue! Please fill out this form so we can be sure to have all the information we need, and to minimize back and forth.

What are we trying to do?
To remove the gendered language in the pledge form generated by DARIA, i.e. "people in low-income situations" instead of "women."
To have all pledge signatures be "DCAF Board President" as a default

What feature or behavior is this required for?

Pledge generation!

How could we solve this issue? (Not knowing is okay!)
Update the thing please!

Anything else?
Thank you so much for all you do.

OBE


Introduce append (adder?) node

Goal: make local-memory functionality stateless.

[ ] Introduce append or adder node
[ ] Refactor out local-memory.

Idea came from @seefeldb  in #48


refactor: icon to icons for favestar component

SUMMARY
This pr migrates the old icon component to icons
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before

after

TESTING INSTRUCTIONS
Go to any of the listivews and homepage to view favestar icon
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up


improve shape robustness in likelihoods

Preamble
GPflow likelihoods could do with a stronger contract re what input shapes are expected and what shapes are returned. In particular, we should obey something akin to tfp’s event-shape/batch-shape/sample-shape. Our proposal will mean that very little will change for most users, except that some shapes will be asserted. Advanced users will benefit from more shape checks and better defined return shapes for methods attached to likelihoods.
Main proposal:
Likelihood needs to define:

Self.num_y_dims: what is the last dimension of Y supposed to be?
Self.num_latent_dims: what is the last dimension of F, F_mean and F_var expected to be?
We’ll check that the dimensions of tensors passed in match up.
Return shapes for all methods will be the broadcast-shape of the tensors passed in, with the last dimension removed.
Example: lik.variational_expectations(F_mu, F_var, Y) might take tensors of dimensions [..., 2], [..., 2], [..., 2] and return a tensor of shape [...]

Standard likelihoods
Most likelihoods in GPflow are univariate, and treat columns of Y and F as independent variables. For these we propose that num_y_dims and num_latent_dims are None, and that we shape check F and Y on-the-fly for matching last-column dimensions. Note that the return shape contract will change as per that above: this should be easily handled in vgp/svgp/sgpmc.
Fancy likelihoods
Likelihoods that depart from the univariate standard include:
SwitchedLikelihood [we’ll check that num_latent_dims = num_y_dims -1]
MultiClass/Softmax [num_y_dims = 1, num_latent_dims = (e.g. 10 for mnist)]
HeteroskedasticGaussian e.g. see GPflow notebook [num_y_dims = 1, num_latent_dims = 2]

@thevincentadam did you have some improved docstrings for the likelihood class that would go well with this PR?

Could you make _log_prob, _conditional_mean & _conditional_variance abstract methods please ?
There is one missing _scalar_density that needs renaming to _scalar_log_density to make the switchedlikelihood test pass.

@awav  it s in your mastery hands to press that green merge button

* The deprecation warning also should specify when this function will be deleted (version, date): https://github.com/GPflow/GPflow/pull/1334/files#diff-2e7823ffd6e5faf03de7ec092c48f32bR232

do we know? I have no clue. please let me know

* My browser and the terminal cannot render this symbol: https://github.com/GPflow/GPflow/pull/1334/files#diff-2e7823ffd6e5faf03de7ec092c48f32bR739, I see it as [a₀, a₁, ... aₖ₋₁]. There are some places with the same square in docstrings.

Is there a guideline on fonts for unicode rendering of the docstrings?

Major:
I have a slight concern about the output shape checking. Although I understand the reasoning about checking shapes, and I think it is a great addition. Typically, extensive tests ensure function correctness with a scenario like the f(x) returns expected results, success or failure, for a variety of inputs. The output shape check seems tautologic in cases when we have a chain of functions with such input/output asserts. I hardly can remember an example of a code where such policy is applied - only input asserts. The output check also might create an illusion that the function does the right thing, whereas error might occur anyway and that would mean we don't have enough tests.

Do you suggest removing output checks? who decides?
Markovflow, with the push of engineers now has many output shape checks.
it looks cumbersome but you get used to it ... and hopefully it saves time in the future.

DeprecationWarning: I agree, it would be good to make clear by when it will disappear. For the predict_density removal, I would say GPflow 2.1.
Output checks: I would be strongly in favour of keeping them.
Unicode: @awav what system/browser are you using? We are using unicode sub/superscripts across the code so I don't think it makes sense to try a fix in this PR - I would merge it as is.

* The deprecation warning also should specify when this function will be deleted (version, date): https://github.com/GPflow/GPflow/pull/1334/files#diff-2e7823ffd6e5faf03de7ec092c48f32bR232

do we know? I have no clue. please let me know

I would suggest 2 months and version 2.2. I don't think that we don't need

* My browser and the terminal cannot render this symbol: https://github.com/GPflow/GPflow/pull/1334/files#diff-2e7823ffd6e5faf03de7ec092c48f32bR739, I see it as [a₀, a₁, ... aₖ₋₁]. There are some places with the same square in docstrings.

Is there a guideline on fonts for unicode rendering of the docstrings?

Not really, it should work out of the box. I wonder what is wrong with my setup...

Major:
I have a slight concern about the output shape checking. Although I understand the reasoning about checking shapes, and I think it is a great addition. Typically, extensive tests ensure function correctness with a scenario like the f(x) returns expected results, success or failure, for a variety of inputs. The output shape check seems tautologic in cases when we have a chain of functions with such input/output asserts. I hardly can remember an example of a code where such policy is applied - only input asserts. The output check also might create an illusion that the function does the right thing, whereas error might occur anyway and that would mean we don't have enough tests.

Do you suggest removing output checks? who decides?
Markovflow, with the push of engineers, now has many output shape checks.
it looks cumbersome but you get used to it ... and hopefully it saves time in the future.

I wouldn't do output checks. As I said before they create an appearance that the function is protected from shape bugs and it is far from true. Tests are much more important to reveal bugs in a function and must be on top of the list. However, that is a collaborative call.
@thevincentadam ^^^

New round of changes after suggestions from @st-- (the ones that were not about undoing the previous ones)
I have kept the output shape check as I don't feel I fall for the illusion of security reported by @awav
If someone  sides with @awav  on that particular issue, speak now or remain silent ... till after this is merged

@st--  ready to hit the green button?


CS fixes

(Continuation of #48)
I added https://styleci.io/ config and the bridge for php-cs-fixer. I would suggest adding this repo to style-ci and future PR's can be checked for style issues automatically. Style issues can be fixed in accordance with this projects style guide simply by running php-cs-fixer fix . in the repo root directory.
If you would like to change the style requirements for this project, let me know (https://styleci.readme.io/docs/presets and https://styleci.readme.io/docs/fixers).
I also removed composer.lock as it was causing issues with travis. It isn't recommended to have this in library repos.

@kbond wow! I didn't know about  https://styleci.io/, thanks.
what could be the issues having the composer.lock file in the library repo? I feel much safer having it, especially because it's a a lib about securing things.
With the composer.lock, other than having a specific version locked, you also have the specific dependency commit which can assure you that  even if the version is removed you still know where to point to. wdyt?

The composer.lock is ignored unless you are working with the root project - development or testing only. See https://getcomposer.org/doc/02-libraries.md#lock-file for more information. Basically, it is ignored for everyone using this library.
Also see: https://travis-ci.org/namshi/jose/jobs/94175923 - the build failed because dependencies couldn't be resolved. This is because the lock file prevented installing valid deps.

@kbond thanks for the explanation, I didn't know the composer.lock wasn't take into account if it's inside another project but I still think it's fine for the project itself: correct me if I'm wrong but from the link you posted, thanks to the composer.lock we now know that in order to install styleci.io we have to drop support for PHP 5.4, right?
Dropping support for PHP 5.4 could be fine, but still I can see the benefit of having the composer.lock file so now we know that.
Am I missing something, what do you think?

For end applications, is very important for composer.lock to be commited. It ensures your deps are identical for all developers and environments.
The styleci library is compatible with 5.4 and even 5.3 I think. The library requires the Symfony Console component at either 2.0+ or 3.0+. Symfony 2.0 requires PHP 5.3+ but Symfony 3.0 requires 5.5+. The problem with he failed build is the lock file. When it was generated last (by me in my development env) I was using php 5.5 so it was locked as 5.5+. The travis PHP env 5.5, 5.6, 7.0 worked fine because it used Symfony 3.0 but when it tried to resolve the deps for the PHP 5.4 env it failed because Symfony was locked at 3.0 which requires PHP 5.5. When I removed the lock file, it resolved fine to Symfony 2.x as expected.
I hope I am making sense. Let me know if you would like me to explain further.

@kbond yes, it makes sense :)
And it's exactly my point: I would keep the composer.lock and act accordingly updating the minimum PHP version.
wdyt?
If you do that, could you also please squash the commits? thanks a lot!

You want me to make the requirement for this lib 5.5+?

I just want to clarify - the styleci.co service just requires the .styleci file (this isn't even required, really). When style errors are found, the service gives you the option to open PR's to fix them. Additionally, new PRs are automatically checked for errors.
I added the sllh/php-cs-fixer-styleci-bridge dev dep and the .phpcs file as a helper for developers to run php-cs-fixer before they create a PR to quickly fix their style issues.
If you really want to keep the composer.lock file, there are three options:

Increase the PHP requirement to 5.5+ (I strongly advise against this as all users running PHP 5.4 would lose the ability to use this library simply because we added a dev requirement...)
Remove the sllh/php-cs-fixer-styleci-bridge dep and .phpcs file.
Change travis to use composer update instead of composer install (this will allow you to keep the composer.lock file and PHP 5.4)

Option 3 is probably the best of both worlds but I really don't understand your argument for keeping the composer.lock. No major libraries have it committed because of the exact issue I had in this PR. The lock file would be updated in virtually every PR opened on said library!
https://github.com/symfony/symfony
https://github.com/laravel/framework
https://github.com/thephpleague/flysystem
https://github.com/ircmaxell/password_compat
https://github.com/guzzle/guzzle

PHP 5.4 is not supported anymore: http://php.net/supported-versions.php
and we could bump the jose version to mark to fact that we support PHP >= 5.5
My argument was about the fact that it happened in the past we had issues with semantic versioning because some dependencies were breaking the lib/project, that's why I'm a bit scared of removing the composer.lock . @odino wdyt?

Changing the min requirement to 5.5 because 5.4 isn't supported I don't agree with but I can understand. I just didn't want you to change it because a dev dependency wouldn't resolve...

@kbond thank you for your time and sorry for the delay in replying to you. I thought about that and I think it's fine to remove the composer.lock, if we need to "lock" a version for an external dependency we will specify the version in the composer.json (as we do for phpseclib).
Could you please squash the commits into one? thanks

Re-based and squashed.

After merge, if you want to use styleci - you should enable it for this repo. All future PRs will be checked for style issues. They have a badge for the readme also.

thanks!


Search casing problem on TR characters

Hello,
I can explain the problem with an example:
When there is an option named "İzmir" that contains "İ" (the uppercase "i" in TR lang) , if I wrote "i" for search, it doesn't match. Also the same result for inverse of example.

This is a feature and not a bug.
https://select2.org/i18n#transliteration-support-diacritics
You should be able to disable it by creating your own custom matcher function which does not strip out the diacritics.

I'm marking this as a documentation ticket because we could benefit from making it more clear how to disable this behavior and maybe make it easier to override how Select2 strips diacritics.

First of all, thanks for your attention.
I get overed the problem myself. The code is below for anyone who needs.
`function modelMatcher(params, data) {
var c, child, matches, match, original, term;
data.parentText = data.parentText || "";
        // Always return the object if there is nothing to compare
        if ($.trim(params.term) === '') {
            return data;
        }

        // Do a recursive check for options with children
        if (data.children && data.children.length > 0) {
            // Clone the data object if there are children
            // This is required as we modify the object to remove any non-matches
            match = $.extend(true, {}, data);

            // Check each child of the option
            for (c = data.children.length - 1; c >= 0; c--) {
                child = data.children[c];
                child.parentText = data.parentText + " " + data.text;

                matches = modelMatcher(params, child);

                // If there wasn't a match, remove the object in the array
                if (matches == null) {
                    match.children.splice(c, 1);
                }
            }

            // If any children matched, return the new object
            if (match.children.length > 0) {
                return match;
            }

            // If there were no matching children, check just the plain object
            return modelMatcher(params, match);
        }

        // If the typed-in term matches the text of this term, or the text from any
        // parent term, then it's a match.
        original = (data.parentText + ' ' + data.text).replace("İ", "i").toUpperCase();
        term = params.term.replace("İ", "i").toUpperCase();

        // Check if the text contains the term
        if (original.indexOf(term) > -1) {
            return data;
        }

        // If it doesn't contain the term, don't return anything
        return null;
    }`

Just add matcher: modelMatcher option to your select2 with the function above.

When there is an option named "İzmir" that contains "İ" (the uppercase "i" in TR lang) , if I wrote "i" for search, it doesn't match.

I cannot reproduce this. If I have an option named "İzmir" and if I search for "izmir" then it does match:


Allow specifying update frequency and S3 URI

This PR contains the following changes:

Allow specifying how frequently to update the keys from S3 using a cron time specifier.
Allow specifying the S3 location as an URI instead of a bucket name. This permits storing keys in a folder inside the bucket.
Keys that are removed from the bucket will be removed from the host too. This is mostly what one would want, but it can be argued whether this should be configurable and default off.
Expose the ID of the security group the bastion host is launched in.

It is meant to be backwards compatible, though some of the old parameters (specifically s3_bucket_name and enable_hourly_cron_updates) could be deprecated and eventually removed.
As part of this the sync script was simplified with mostly trivial changes. It uses aws s3 sync for synchronizing the keys, instead of doing this by hand. Maybe there was a reason for the more complicated implementation?

Very good @bnordbo ! LGTM


[terra-date-time-picker] Fix to clear out invalid date value on clicking time input

Summary
Fix to clear out invalid date value on clicking time input. Changes made in date-picker to set date value to null if value is invalid, instead of retaining previous value.

Closes #1217
Deployment Link

https://terra-framework-deployed-pr-#.herokuapp.com/
Testing
Updated wdio snapshots for terra-date-picker and date-time-picker.

Additional Details

Thank you for contributing to Terra.
@cerner/terra

Date is clearing out only when date is an excluded date OR when date is out of range OR when invalid date passed as initial date value. but not clearing the date when invalid date is being typed.

Date is clearing out only when date is an excluded date OR when date is out of range OR when invalid date passed as initial date value. but not clearing the date when invalid date is being typed.

After Splitting the date picker it wont allow wrong values to be entered for date so this should not be an issue

Date is clearing out only when date is an excluded date OR when date is out of range OR when invalid date passed as initial date value. but not clearing the date when invalid date is being typed.

@supreethmr The term invalid is sometimes used loosely. For the sake of this conversation, I'll use the following terms.

complete - A full date value that conforms to the date format.
invalid - A full complete date but it is either excluded or out of range.
malformed - A date value that is not complete or does not conform to the format. (e.g. 293-32-34)

The clearing logic applies only for complete default date that is invalid (excluded or out-of-range). It does not get cleared after the initial render. However, it is cleared as soon as you attempt to interact with the component (i.e. receives focus or opening the picker). If the default value is malformed, it is ignored and does not get display in the input.

Functional review complete. No issues identified.


Add init node profile

What this PR does / why we need it

Add initNodeProfiles for AWS Management Cluster
Step 1
Retrieve all nodeTypes by calling API getAwsNodeTypes (/api/provider/aws/nodetypes) from AwsService.tsx
Step 2
Call setDefaultNodeNodeType from AwsDefaults.service.tsx to determine the default Node Type.

Determination Strategy:

Compare the default node type value in AWS_DEFAULT_INSTANCE_TYPES in aws.defaults.tsx with the retrieved node type list from Step 1
If the default value exits in node type list, then return the default value
If the default value does not exist, return the middle element of the node type list.

For example:

The default value is

const AWS_DEFAULT_INSTANCE_TYPES: KeyOfStringToString = {
    [AWS_NODE_PROFILE_NAMES.SINGLE_NODE]: 't3a.large',
    [AWS_NODE_PROFILE_NAMES.HIGH_AVAILABILITY]: 't3a.large',
    [AWS_NODE_PROFILE_NAMES.PRODUCTION_READY]: 'm6a.xlarge',
};

Retrieved node type list is

[
    "t3.small",
    "t3.medium",
    "t3.large",
    "t3.xlarge",
    "m5.large",
    "m5.xlarge",
    "m5a.2xlarge",
    "m5a.4xlarge",
    "c6gn.small",
    "c6gn.medium",
    "c6gn.large",
    "r4.8xlarge",
    "i3.xlarge",
    "t3.small",
    "t3.medium",
    "t3.large",
    "t3.xlarge",
    "m5.large",
    "m5.xlarge",
    "m5a.2xlarge",
    "m5a.4xlarge",
    "r4.8xlarge",
    "i3.xlarge",
    "t4g.small",
    "t4g.medium",
    "t4g.large"
]

For SINGLE_NODE, the default node type is t3a.large which is not in the node type list. So we set the node type for SINGLE_NODE as t3.small. (t3.small is in the middle position of the node type list)

Step 3
Create an object storing those three  node profile - default node type value pair; Store this object to AWS [STORE_SECTION_AWS_RESOURCES]
Step 4
When user chooses different node profile, the corresponding default node type will be set in the final payload
Which issue(s) this PR fixes

Fixes: #
Describe testing done for PR

E2E Test
Default Node Type

Retrieved Node Type List

UI

Payload

Special notes for your reviewer

it seems that the list has duplicated data.


Not working in Typescript

Hi there! 👋 Hopefully you are fine!
I've found an error when trying to use this library with my React TS App. I can contribute building it, if you want.
Cheers! 🚀

Hi @AleTid5,
Sure feel free to oben a PR


Add e2e testing to test run recipes

WIP

@scortier Let's move the e2e tests to the root test folder only. test/e2e

@ravisuhag right now test folder is used for test utilities, should we somehow restructure it?
the perks of having e2e to be it's own package is we can isolate the test easier.

@ravisuhag right now test folder is used for test utilities, should we somehow restructure it?
the perks of having e2e to be it's own package is we can isolate the test easier.

It will be still isolated package inside test. test/e2e

we could do that as far as isolation goes.
but how would you define test package/folder now?
doing so will make test package to be

a test utilities package required/depended by other packages
a folder containing meteor tests (e2e, etc)

or if you want e2e to be inside test folder, maybe we can have it like this:
├── test
│   ├── utils
│   │   ├── dockertest.go
│   │   ├── logger.go
│   ├── mocks
│   │   ├── plugin.go
│   ├── e2e
│   │   ├── **/*_test.go

wdyt?

we could do that as far as isolation goes.
but how would you define test package/folder now? doing so will make test package to be

a test utilities package required/depended by other packages
a folder containing meteor tests (e2e, etc)

or if you want e2e to be inside test folder, maybe we can have it like this:
├── test
│   ├── utils
│   │   ├── dockertest.go
│   │   ├── logger.go
│   ├── mocks
│   │   ├── plugin.go
│   ├── e2e
│   │   ├── **/*_test.go

wdyt?

@scortier Yes, we can go with this proposed approach.


add libpam.so.0 and libpam_misc.so.0 to exclude list

Pam libraries are system specific, when using bundled PAM libs from e.g. fedora on Debian you can get an error such as Authentication failed: Module is unkown. Using system PAM libraries works completely fine, also If the system doesn't have PAM libraries I do not think PAM works at all, so there should not be any reason to bundle them.

What happens if an application requires libpam.so.0 and it is not on the system?

What happens if an application requires libpam.so.0 and it is not on the system?

well if it is a direct linkage it will fail, so I'm not sure I understand your question. I argue that bundled libpam will always be useless as that won't make PAM on the client Linux suddenly work. Each Distro will probably have a completely different PAM setup, the only thing it will share will be the modules and I'm certain they will be shared only with name and 'API', not the implementation.
So if you are trying to use AppImage that requires PAM on a system that doesn't have PAM, you are probably doing something wrong.

I don't care about PAM working, as long as the application will run. But if a system lacks libraries that the application links to, then the application will fail to run. And that's what we want to avoid.

but with your argument excludelist has to be empty, because what if user links to libX11.so.6 for example?


Fix typos

Fix typos:

Use Π instead of ∀ for statement of Chinese Remainder Theorem
Weistrass -> Weierstrass

Not sure if people would prefer this in two separate PRs.
For the first change, see: https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/Mathematics.20in.20Lean.2C.20CRT.20-.20Notation.20confusion
For the second, the German name is technically "Weierstraß", but "Weierstrass" is acceptable in English - and also it's consistent with the spelling elsewhere in the codebase.

Thanks for your contribution to mathlib!
Did you mean to mark this PR as ready for review? If so, please apply the awaiting-review label (in the future; I just marked this one). (The contribution guidelines contain this trick and a few more.)

Whoops, two people approved this at the same time :-) I guess we agree this change is good.

Thanks!
bors merge


esbuild 0.16.7 needs another release of this plugin

Its me again :)
0.16.6 still worked. Seems the API changed again.

Btw, I saw the last issue of this kind mentioned here: https://github.com/evanw/esbuild/issues/2544
Interesting, I am starting to pin Esbuilds version now (which I normally try to avoid).

@gunters63 I agree with the author of esbuild. I'm ok with that.

@davipon:  Thank you for the update.
Your plugin is very helpful for an embedded application I develop (graphql-helix, envelop, fastify, prisma).
I couldn't have switched so easily from express to fastify without it :)

@gunters63 Appreciate your kind words! It made my day.
Interestingly, I once saw Matteo (author of pino and fastify) talk about bundling and logging in production, and he doesn't recommend doing so. (Sorry, I couldn't find the source.)
This library enables both 😅, but it did solve use cases like deploying a tiny app as a serverless/ edge function, which is hard if you don't bundle. Besides, pino does have an outstanding performance with less overhead. It works perfectly in production, at least in my experience.

@davipon : Our application runs on a arm-based industrial controller from a SD card. No way we want to install a node_modules folder there 😄


http: pathless CONNECT

Removing the synthetic path added to CONNECT requests theoretically completing Envoy CONNECT support.
Additional Description:
This has the side-effect of changing Envoy's default response to CONNECT requests from 403 (upgrade forbidden) to 404 (route not found) because without the path header, CONNECT request fail to match traditional route rules.
Risk Level: Medium (high for early CONNECT users, low otherwise)
Testing: Altered tests
Docs Changes: will un-hide in a follow-up
Release Notes: added
Runtime guard: envoy.reloadable_features.stop_faking_paths
Part of #1451 and #1630

Hey @mattklein123 would like your thoughts on the behavioral change.
I was going to special case, and change the HCM "send upgrade rejected" response to happen if an upgrade failed (route match, no opgrade configured) or for CONNECT requests which had no route match, to preserve the existing behavior.  I feel like 403 on connect is more clear than 404, and behavioral changes and runtime guards, yadda yadda.
I had second thoughts, because if we add more logic to the extensible connect matcher, it gets complicated to tell if the 404 is a connect rejection, or if a fancy extended connect matcher failed to match.  Basically keeping the old behavior doesn't seem very future proof.
Wanted to get your take on which way to go, and I'll either runtime guard and add release notes and such, or special-case to preserve existing behavior, revert the test changes, and we'll have to remember to be careful if anyone extends the connect matcher.

Also I don't remember where we left off with our comfort with Pathless connect.  I think the plan was to improve fuzzing and I think @asraa has done that so I think we're OK, but if you want more guards in place before this lands LMK

LGTM but needs a format fix.
/wait

/azp run envoy-presubmit

/azp run envoy-presubmit

/retest


IllegalStateException: IrPropertyPublicSymbolImpl error in latest release - 1.6.0-beta01

Describe the bug
Building the iOS app via a Release build configuration fails after updating to the latest 1.6.0-beta01 version.
Affected platforms

iOS

Versions

Kotlin version*: 1.9.22
Compose Multiplatform version*: 1.6.0-beta01
OS version(s)* (required for Desktop and iOS issues): iOS 16
OS architecture (x86 or arm64): arm64

To Reproduce
A KMM project with the latest compose beta - 1.6.0-beta01. (I tried with a project built with Compose Multiplatform Wizard)
Build iOS project via the Release Configuration (not debug)
The following error is seen during build -
java.lang.IllegalStateException: IrPropertyPublicSymbolImpl for androidx.collection.internal/EMPTY_INTS|6945326639149902205[0] is already bound: PROPERTY name:EMPTY_INTS visibility:internal modality:FINAL [val]

It seems like the following has been introduced in the latest release that is conflicting with a property of same name in androidx.collection. (might be wrong about the exact cause)
package androidx.compose.ui.text.caches

/**
 * Copied from ContainerHelpers.binarySearch until collection2 can be linked
 */
@kotlin.jvm.JvmField
internal val EMPTY_INTS = IntArray(0)

Looking into it a little bit more and comparing 1.5.11 to 1.6.0-beta01, the above mentioned code from the androidx.compose.ui.text.caches package doesn't seem to be new. It does exist in 1.5.11.
Instead, it looks like androidx.collection was added as a dependency in 1.6.0-beta01.
Here are references to EMPTY_INTS in version 1.5.11 -

And here are references to EMPTY_INTS in version 1.6.0-beta01 -

Sorry for the limited info, I haven't been able to dig too deep into this.

What libraries did you choose when configuring the porject in the wizard (here https://terrakok.github.io/Compose-Multiplatform-Wizard/)?
Could you please share the project you generated where the issue can be reproduced?

What libraries did you choose when configuring the porject in the wizard (here https://terrakok.github.io/Compose-Multiplatform-Wizard/)? Could you please share the project you generated where the issue can be reproduced?

I've pushed the sample project that was exhibiting the issue to Github - https://github.com/rdsarna/Multiplatform-App-Issue-Example

My project is experiencing this in v1.6.0-beta02 also.

right, the proper fix didn't make to 1.6.0-beta2.
The possible temporary workaround could be to not use androidx.annotation:annotation and androidx.collection, but use
org.jetbrains.compose.annotation-internal:annotation and org.jetbrains.compose.collection-internal:collection instead.
It could be that you don't use it directly, but it's a transitive dependency. Then gradle dependencies substitution should help.
The proper fix is in progress.

@eymar any fixes done latest release 1.6.2?

@eymar any fixes done latest release 1.6.2?

Should work in 1.6.0

@eymar  it showing  even updating to v1.6.2
Compilation failed: IrPropertyPublicSymbolImpl for androidx.collection.internal/EMPTY_INTS|{}EMPTY_INTS[0] is already bound: PROPERTY name:EMPTY_INTS visibility:internal modality:FINAL [val]

 * Source files:
 * Compiler version: 1.9.22
 * Output kind: FRAMEWORK

@sureshmaidaragi1919 There's no Compose Multiplatform 1.6.2, there is only 1.6.0

Sorry my bad, I used 1.6.0 for KMM.
Btw thank you, I found the root cause is because of another dependency Koin using older version of compose, So I need to either downgrade or should wait for koin to update, here is the full discussion

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


az aks get-credentials fails with error AADSTS70043 - The refresh token has expired or is invalid due to sign-in frequency checks by conditional access

Describe the bug
Command Name
az aks get-credentials
Errors:
AADSTS70043: The refresh token has expired or is invalid due to sign-in frequency checks by conditional access. The token was issued on 2020-12-07T12:15:47.8520000Z and the maximum allowed lifetime for this request is 172800.
Trace ID: 9958a6aa-3e9b-4470-9df7-7d0603262301
Correlation ID: c215e3d3-39fa-42e5-855c-4d93e362d308
Timestamp: 2020-12-09 13:10:42Z

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

az aks get-credentials --resource-group {} --name {}

Expected Behavior
I expect that I get valid credentials. If not working, due to some expired token, I expect that I am asked to relogin and fetch a valid token. If not, at least some information what to do to resolve the error.
Environment Summary
Linux-5.9.11-100.fc32.x86_64-x86_64-with-glibc2.2.5
Python 3.8.6
Installer: RPM

azure-cli 2.16.0

Extensions:
azure-devops 0.18.0

Additional Context

aks

i have the same error but executing this command:
az resource delete --ids exampleResourceID

@BenjaminHerbert were you able to fix it? I'm facing the same issue!

@BenjaminHerbert were you able to fix it? I'm facing the same issue!

I'm seeing this with az account get-access-token as well.
adal.adal_error.AdalError: Get Token request returned http error: 400 and server response: {"error":"interaction_required","error_description":"AADSTS70043: The refresh token has expired or is invalid due to sign-in frequency checks by conditional access. The token was issued on 2021-01-21T18:58:33.5955295Z and the maximum allowed lifetime for this request is 43200.\r\nTrace ID: 663734d6-d237-4d25-a2e9-5c0db0e79600\r\nCorrelation ID: d2aee7e8-ca4d-4448-a3c1-a97b2fcbc2ff\r\nTimestamp: 2021-01-23 00:02:57Z","error_codes":[70043],"timestamp":"2021-01-23 00:02:57Z","trace_id":"663734d6-d237-4d25-a2e9-5c0db0e79600","correlation_id":"d2aee7e8-ca4d-4448-a3c1-a97b2fcbc2ff","suberror":"token_expired"}

This shouldn't throw an exception. It should fail gracefully.
azsdke2e
azsdke2e2

I'm seeing this with az account get-access-token as well.
adal.adal_error.AdalError: Get Token request returned http error: 400 and server response: {"error":"interaction_required","error_description":"AADSTS70043: The refresh token has expired or is invalid due to sign-in frequency checks by conditional access. The token was issued on 2021-01-21T18:58:33.5955295Z and the maximum allowed lifetime for this request is 43200.\r\nTrace ID: 663734d6-d237-4d25-a2e9-5c0db0e79600\r\nCorrelation ID: d2aee7e8-ca4d-4448-a3c1-a97b2fcbc2ff\r\nTimestamp: 2021-01-23 00:02:57Z","error_codes":[70043],"timestamp":"2021-01-23 00:02:57Z","trace_id":"663734d6-d237-4d25-a2e9-5c0db0e79600","correlation_id":"d2aee7e8-ca4d-4448-a3c1-a97b2fcbc2ff","suberror":"token_expired"}

This shouldn't throw an exception. It should fail gracefully.
azsdke2e
azsdke2e2

Rerun az login and CLI should get a new refresh token and fix the error. @jiasli @houk-ms to follow up on better error handling for this case.

Rerun az login and CLI should get a new refresh token and fix the error. @jiasli @houk-ms to follow up on better error handling for this case.

Yeah, az login fixes it, just shouldn't be a code exception, more like an error would be great.

Yeah, az login fixes it, just shouldn't be a code exception, more like an error would be great.

I received this error while pulling heavy-weight docker to my registry, what should I do? any inputs highly appreciated.
AADSTS70043: The refresh token has expired or is invalid due to sign-in frequency checks by conditional access. The token was issued on 2021-02-24T05:50:44.4338824Z and the maximum allowed lifetime for this request is 43200

az login doesn't fix it for me

@debugdana, running az login should retrieve a new refresh token from AAD. Could you clear the browser cache and run it again? We did observe some rare cases where the browser still somehow uses the old cache.

Regarding error
AADSTS70043: The refresh token has expired or is invalid due to sign-in frequency checks by conditional access.
The token was issued on 2021-02-23T05:06:57.0691981Z and the maximum allowed lifetime for this request is 3600.
Trace ID: ab764987-048b-4745-bc32-ba7d16840b00
Correlation ID: a2d45c9f-41de-4e18-8bf5-8368975c7561
Timestamp: 2021-02-24 06:54:48Z
To re-authenticate, please run `az login`. If the problem persists, please contact your tenant administrator.

It is thrown because your tenant administrator has configured Refresh Token Max Inactive Time.
If you are a tenant administrator, you may change it via configuring Sign-in frequency control in Azure Portal.
We have created PR #17072 to show a better recommendation message after encountering this error.

There is a folder with name .azure in my local system, I deleted it and tried again...it fixed the problem..

@shalin231, ~/.azure is where Azure CLI's configuration and token cache is stored. Running az login again will also refresh the token cache and achieve the same effect of directly deleting it.

fyi I had the same issue when running e.g. kc get services
E0322 17:45:49.947710   13076 azure.go:154] Failed to acquire a token: unexpected error when refreshing token: refreshing token: adal: Refresh request failed. Status Code = '400'. Response body:{"error":"interaction_required","error_description":"AADSTS70043: The refresh token has expired or is invalid due to sign-in frequency checks by conditional access. The token was issued on 2021-03-19T13:32:04.3618936Z and the maximum allowed lifetime for this request is 43200.\r\nTrace ID: 0d6edd7e-dc33-46aa-a299-06fc10673401\r\nCorrelation ID: bca2694e-c9b1-4b9c-a8a5-54bc4c3815c0\r\nTimestamp: 2021-03-22 16:45:49Z","error_codes":[70043],"timestamp":"2021-03-22 16:45:49Z","trace_id":"0d6edd7e-dc33-46aa-a299-06fc10673401","coE0322 17:45:50.829281   13076 azure.go:154] Failed to acquire a token: unexpected error when refreshing token: refreshing token: adal: Refresh request failed. Status Code = '400'.
az login nor clearing browse cache did not help me. I had to use kubelogin.exe convert-kubeconfig to fix it (https://github.com/Azure/kubelogin).

@shalin231, ~/.azure is where Azure CLI's configuration and token cache is stored. Running az login again will also refresh the token cache and achieve the same effect of directly deleting it.

I had some old login files with my personal account stored in the .azure directory.
Logging out and then logging in with a service principal didn't seem to overwrite everything.
Removing the .azure directory and logging in with the service principal resolved the issue.

I had the same issue (AADSTS70043 expired refresh token) with the Azure Account extension for VS Code. Neither using az login, nor deleting .azure or the browser cache fixs it for me.
Any ideas would be appreciated.

I met the same issue but az login can't resolve it, az login --scope https://graph.microsoft.com//.default works for me, and if you're using WSL, you probably need to manually copy the URL to web browser to login.


After a successful password change the screen remains unchanged

Describe the bug
When a user changes their password with successful notification, the screen remains unchanged
To Reproduce
Steps to reproduce the behaviour:

Go to 'Mauro'
Click on the dropdown menu list on the user profile menu
Select
Enter the old password into the “Old password” field
Enter new password
Select  CTA
Successful notification is displayed at the bottom and the screen remains unchanged
Expected behaviour
The screen is expected to navigate away from the “Change password”

Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Passed Retest


Fix post task lookup in TaskEnhancements#after

Since the change to lazily bind the post task in TaskEnhancements#after,
invocation of the post task is no longer done within the context of the
namespace within which after hooks are defined. This results in runtime
errors when after hooks are defined within a namespace and the post task
name provided as an argument does not include the full namespace.
For example, with the following code, tasks :bar and :baz will be
created within the foo namespace, but invoking foo:bar will cause
RuntimeError, "Don't know how to build task 'baz'" (note: no namespace)
namespace :foo do
  task :bar do
    ...
  end
  after :bar, :baz do
    ...
  end
end

Fixed by providing the scope of the after when looking up the post task.

+1 for tests, please check contribution guidelines and credit yourself int he changelog, or confirm you don't want to be credited and I'll merge it.

Sorry bout that, have updated changelog :-)


feat(deployment): Research PG on Kubernetes

https://github.com/cloudnative-pg/cloudnative-pg
https://github.com/zalando/postgres-operator

We should investigate if it is possible to run pgvecrto.rs and pg on kubernetes with the help of these operators.

For CloudNativePG, you can also take a look at this repo: https://github.com/bo0tzz/cnpgvecto.rs

For CloudNativePG, you can also take a look at this repo: https://github.com/bo0tzz/cnpgvecto.rs

Wow, Big thanks! cc @xieydd

For CloudNativePG, you can also take a look at this repo: https://github.com/bo0tzz/cnpgvecto.rs

Do you need to deploy the extension on Kubernetes? I used to think immich users mainly deploy the server on cloud VMs or the NAS.

We have a decent number of Kubernetes users. They tend to be power users who deploy a bunch of self-hosted services and share the same Postgres operator for all them.
I honestly don't know if I can say there's a "main" way people deploy Immich at this point 😅 I've seen everything from elaborate clusters with Xeons or Threadrippers, NAS deployments (Unraid, TrueNAS, etc.), gaming PCs, Raspberry Pis and even someone who deployed on an OpenWRT router. We just do our best to make it work for everyone.

Thanks for your explanation!

CNPG works well.
Here are some TODOs:

Test logical replication on K8s
Add documentation to https://github.com/tensorchord/pgvecto.rs-docs

@xieydd We could please the k8s-related doc in https://github.com/tensorchord/pgvecto.rs-docs/tree/main/src/admin

@xieydd We could please the k8s-related doc in https://github.com/tensorchord/pgvecto.rs-docs/tree/main/src/admin我们可以请 https://github.com/tensorchord/pgvecto.rs-docs/tree/main/src/admin 中的 k8s 相关文档

ok, I will add the documents to the repository this week.

CNPG works well. CNPG 运作良好。
Here are some TODOs:以下是一些待办事项：

Test logical replication on K8s在 K8s 上测试逻辑复制
Add documentation to https://github.com/tensorchord/pgvecto.rs-docs将文档添加到 https://github.com/tensorchord/pgvecto.rs-docs

I have tested logical replication on pgvector and pgvecto.rs.
pgvector's logical replication is fine. However, pgvecto.rs currently does not seem to support logical replication and streaming replication. Both of these rely on WAL and logical decoding.
It may still need to implement Custom WAL Resource Managers as mentioned here.

CNPG works well.
Here are some TODOs:

Test logical replication on K8s
Add documentation to https://github.com/tensorchord/pgvecto.rs-docs

I have tested logical replication on pgvector and pgvecto.rs.
pgvector's logical replication is fine. However, pgvecto.rs currently does not seem to support logical replication and streaming replication. Both of these rely on WAL and logical decoding.
It may still need to implement Custom WAL Resource Managers as mentioned here.

cc @VoVAllen

FDW, logical replication


feat: add tips of the day for new sessions

This adds some tips to the CLI when it first shows up for a new session.
As @alecthomas says: "nobody is reading a readme anymore"

I've got a solution for your conventional commits woes! https://github.com/alecthomas/gptcc
And an example of using it.

closing this - as I think we can have a better interactive first time tutorial approach


Added member-list w/ names+pics

Looks good to me; it may be a good idea to use an ant design component later because they may have more features (for example https://ant.design/components/image/ have a zoom in feature)


Add Global Scoreboard

Context
Users should be able to see the global top 10 scores when the game ends
Current Behavior/Workaround
Only showing current user's top score via local storage
Things to consider
Store in a flat file or database?
Any issues with concurrency if using a flat file?
Will need to provide a way to add three-letter username to associate with score
Will need placeholders for the top 10 scores to start

@shawnamays do you have any suggestions for what should go in the scoreboard or other enhancements related to it?

Implementation finished

Using a MongoDB database for the high scores
Serverless functions for GET/POST to api/highscores
The name for each highscore is a three letter capitalized name
The database only maintains the top 10 scores

Hey John!
Not sure how this email bypassed me but I’m really excited to see the new
features! I’ll check it out tonight after I get off work!
On Mon, Jun 19, 2023 at 10:04 AM John Solly @.***>
wrote:

Closed #161 https://github.com/jsolly/GeoAsteroids/issues/161 as
completed via #171 https://github.com/jsolly/GeoAsteroids/pull/171.
—
Reply to this email directly, view it on GitHub
https://github.com/jsolly/GeoAsteroids/issues/161#event-9568889996, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AWVXK4GICQZSJWTIQ7NAYLDXMBL5LANCNFSM6AAAAAAYCPCTSE
.
You are receiving this because you were mentioned.Message ID:
@.***>


BL1415 support

Hi there, great project!,
Wondering if there is support for the BL1415? I think the PCB for this battery is a bit smaller, but they work on the same charger as the BL18** batteries.
So I cannot imagine it being totally different from the BL18xx batteries.
I also think that the BL1415 has the same board as the BL1430, BL1440, BL1445, BL1460.

I've placed new cell's in mine, and since that it won't charge anymore... :(

Hey, thanks! This board looks similar to LIPW5003 which is based on MC908 microcontroller. I have very limited experience with these  since i dont have access to very many. I have some idea on how to unlock them, please email me<EMAIL_ADDRESS>and we can investigate further.

This looks to be an older model (I have the BL1460B protection board)

I have the Same Battery with PCB here but only get "no response". Do you have a fix for that, @mnh-jansson ?

It seems that these batteries need an extra GND connection to pin 1 connector of the Makita connector (or just use GND on pin 1 instead of terminal GND). These are not supported, and i don't think i will provide the solution for them as the hardware is quite bad and unlocking them can cause harm because the BMS cannot control individual cell voltages.
In these cases i would almost suggest a good quality BMS replacement, however i don't have alot of good experience with the aftermarket replacements so i cannot give any recommendations there.

Be careful with connecting MC908JK3E based BMS to arduino board. Those BMS use enable pin (pin number 6) as power supply. Arduino output can be too weak to supply it, I have burned one of my arduino output when tried to read battery message. Also GND pin is pin number 1 of yellow connector.


N18: A/B Street

Part of #455

Could you please avoid including the coordination issue's number to the commit message in the future? It creates some unnecessary noise in the issue because of how GitHub's UI works:

Could you please avoid including the coordination issue's number to the commit message in the future?

Yep, sorry about that! Blindly followed the example from recent commits.

Merged, thanks for the PR!


Links don't work

Links don't work for example
https://docs.microsoft.com/en-us/aspnet/core/group1-dest/tutorials/razor-pages-vsc/?view=aspnetcore-2.1
https://docs.microsoft.com/en-us/aspnet/core/group1-dest/mvc/overview?view=aspnetcore-2.1

Same problem, but until it is fixed, you can still access the link by removing "group1-dest" in the url.
So https://docs.microsoft.com/en-us/aspnet/core/tutorials/razor-pages-vsc/?view=aspnetcore-2.1 and https://docs.microsoft.com/en-us/aspnet/core/mvc/overview?view=aspnetcore-2.1 will work

@Kyappy  thanks

Thanks for reporting. We have an internal issue tracking this and it should be fixed very soon. We're sorry for the trouble. I'll close this since we're tracking the work internally.


Add ability to read variables from call stack

In native debuggers like MSVC, you can select a call stack entry and view variable values from that scope.  There doesn't appear to be anything like this in Duktape, and an Eval request isn't a solution since the locals of an activation further down the stack aren't in scope.
It would be great if the Duktape debugger had this ability too.

Also mentioned in future work: https://github.com/svaarala/duktape/blob/master/doc/debugger.rst#possible-new-commands-or-command-improvements

Wow, it's even the first item on the list!  No idea how I missed that...

It's fine to have overlap though. I've just tried to keep long laundry lists of known future work in the relevant docs because having all that as separate Github issues would be unwieldy. (On the other hand, having a tracking Github issue for 10-20 individual improvements would probably be OK, and Github has that convenient checkbox feature as well.)

As far as concrete implementation, it would be enough to walk the callstack and do a direct eval in the context of the correct activation, yes?  After the 1.3 release I want to look into implementing this.

Hm, it occurs to me that modifying the relevant debug commands to allow this will break protocol compatibility as it requires an additional argument (the callstack index).

Eval wouldn't be correct but there's an internal call to "GETVAR" starting from a certain activation.
Adding a new argument would just cause an older version to ignore the argument and do whatever it did before: https://github.com/svaarala/duktape/blob/master/doc/debugger.rst#extending-the-protocol-and-version-compatibility
This allows some graceful extensions, and works well in some cases (and not so well in others).

I imagine doing a direct eval under a previous activation might cause some havoc if it has any side effects, given that objects in JS are passed by reference.  I wouldn't blame you at all if there's no built-in primitive to support such shenanigans. :)

Well it's possible to do an Eval sure in a different callstack entry (in most cases) - but it's different from the topic of this issue (reading variable values).
The only problem with doing an arbitrary Eval might be that some functions are optimized with the assumption that there won't be a direct eval call in that function (the compiler can figure this out during compilation). Some assumptions might then be violated when Eval runs, not sure what would break in practice.

Yeah, I was just musing mainly because I use Eval to get JX-encoded values of objects in my debugger's variable viewer.  Sorry for drifting off-topic. :)

I just meant there are actually two separate debugger improvements: one to add a callstack level to variable reads and another for Eval. Both are possible and slightly different (Eval can establish new variables, for example :-).

@svaarala
I'm investigating how to implement callstack level for GetLocals.  Keep an eye out for pull requests. :)

Regarding this:

The only problem with doing an arbitrary Eval might be that some functions are optimized with the assumption that there won't be a direct eval call in that function (the compiler can figure this out during compilation). Some assumptions might then be violated when Eval runs, not sure what would break in practice.

It occurred to me that this applies even in master, when paused in a function which was compiled with such an assumption.  So I don't see that as a blocker for implementing callstack level for Eval. :)

@fatcerberus That's true. There shouldn't be too many issues like that in the current master because debugger support prevents ditching _Varmap for example.

I'll close this now that #412 has been merged.


Update backup-restore-environments.md

Added: What steps are needed after a restore to ensure flows are working as expected?

Taking to live via working branch.


Image placeholders load incorrectly when returning from other screen

Inside Scroll Layout, if a list of elements with images is visible, and the screen is changed, and returned back, images that previously held a placeholder now have a an image of other element from the list. This issue happens f. e. when image fails to load and a placeholder is displayed.
Steps to Reproduce

Create view with placeholder image inside
Embedd created view inside scrolling layout
Push another view on top of the one with scroll
Return back to previous view

Logs
There is no log output related to issue
   info • Unused import: 'package:flutter_platform_widgets/flutter_platform_widgets.dart' •
          lib/ui/home/Home.dart:3:8 • unused_import

1 issue found. (ran in 12.7s)

[✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.14.2 18C54, locale pl-PL)
    • Flutter version 1.0.0 at /usr/local/Cellar/flutter/1.0.0
    • Framework revision 5391447fae (7 weeks ago), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/igor/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/igor/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[!] IntelliJ IDEA Ultimate Edition (version 2018.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.io/intellij-setup/#installing-the-plugins

[!] VS Code (version 1.30.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[!] Connected device
    ! No devices available

Hi @ikurek,
Can you please confirm if you still experience this issue on latest Flutter Stable version ?
Thanks.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


What's the workflow for curating the entries in the collection?

While exploring @jhpoelen's test deposits at https://sandbox.zenodo.org/records/56163 ,

I noticed that the URL
https://linker.bio/cut:hash://md5/6266556325eb929125a3376ffcc982dd!/b21871-24327
that is listed there under "Related works/ is derived from" has the entry

            "filename": "Aellen and Brosset - 1968 - ChiroptÃ¨res du sud du Congo (Brazzaville).pdf",

i.e. the non-ASCII character è in Chiroptères is scrambled in a way that may cause trouble downstream. This made me wonder what the expected curation workflows are for information like this that could be handled in the Zotero group or at any later step.

For this specific example, it may be that the automated workflow caused the character doi.
the original as shown in Zotero -
Chiroptères du sud du Congo (Brazzaville)

on closer inspection, the observed funny characters appears to be a browser rendering issue.
This claim is supported by results of
curl 'https://linker.bio/cut:hash://md5/6266556325eb929125a3376ffcc982dd!/b21871-24327'\
 > zotero-record.json

with attached
zotero-record.json
being:
{
        "key": "YPKCPU9J",
        "version": 11477,
        "library": {
            "type": "group",
            "id": 5435545,
            "name": "Bat Literature Project",
            "links": {
                "alternate": {
                    "href": "https://www.zotero.org/groups/bat_literature_project",
                    "type": "text/html"
                }
            }
        },
        "links": {
            "self": {
                "href": "https://api.zotero.org/groups/5435545/items/YPKCPU9J",
                "type": "application/json"
            },
            "alternate": {
                "href": "https://www.zotero.org/groups/bat_literature_project/items/YPKCPU9J",
                "type": "text/html"
            },
            "up": {
                "href": "https://api.zotero.org/groups/5435545/items/RIPP6IX2",
                "type": "application/json"
            },
            "enclosure": {
                "type": "application/pdf",
                "href": "https://api.zotero.org/groups/5435545/items/YPKCPU9J/file/view",
                "title": "Aellen and Brosset - 1968 - Chiroptères du sud du Congo (Brazzaville).pdf",
                "length": 15895641
            }
        },
        "meta": {
            "createdByUser": {
                "id": 13229919,
                "username": "acsherman",
                "name": "",
                "links": {
                    "alternate": {
                        "href": "https://www.zotero.org/acsherman",
                        "type": "text/html"
                    }
                }
            },
            "numChildren": 0
        },
        "data": {
            "key": "YPKCPU9J",
            "version": 11477,
            "parentItem": "RIPP6IX2",
            "itemType": "attachment",
            "linkMode": "imported_file",
            "title": "Aellen and Brosset - 1968 - Chiroptères du sud du Congo (Brazzaville).pdf",
            "accessDate": "",
            "url": "",
            "note": "",
            "contentType": "application/pdf",
            "charset": "",
            "filename": "Aellen and Brosset - 1968 - Chiroptères du sud du Congo (Brazzaville).pdf",
            "md5": "067e9a9c946e10df2a474ab32f4a506d",
            "mtime":<PHONE_NUMBER>458,
            "tags": [],
            "relations": {},
            "dateAdded": "2024-05-03T18:02:28Z",
            "dateModified": "2024-05-03T18:02:30Z"
        }
    }

Note that the special character in Aellen and Brosset - 1968 - Chiroptères du sud du Congo (Brazzaville).pdf is being rendered as expected.
But this leaves the original question - who is in charge of curation of the Bat Lit Corpus and associated curatorial workflows.
I'd elect @ajacsherman and Cullen for the position. They are familiar with Bat Literature and have extensive background in bat research.

Hey Jorrit, if the pdfs that I add to Zotero populate the parent metadata automatically, I skim it and then move on. If I need to enter the parent group metadata manually, I will add the title, date, authors, and periodical information only. I have not been monitoring browser rendering issues, transcription errors, OCR errors, DOI links, etc. If this cannot be automated and needs to be added to my workflow, I suggest we come up with a way to batch report the issues at predictable time intervals for review. We will also need to outline how we will resolve these issues independently. Did our friends from Taxadros have methods for this?

Did our friends from Taxadros have methods for this?

I shared my review notes with him similar to how I am sharing them with you, then he addressed them in the next version. He has curated TaxoDros for decades and this is part of his process.

I suggest we come up with a way to batch report the issues at predictable time intervals for review.

I much like your idea to outline a review process. What do you propose?

How did he handle rendering issues, transcription errors, etc.? Manually? Was he merging shared libraries like we are?

He managed his literature records in his own system and published the files as described in https://taxodros.github.io .
You'd have to ask him how he handles his curatorial process. I provided the review notes, and he curated the corpus and made a new version available when he was ready to do so.

I suggest we come up with a way to batch report the issues at predictable time intervals for review.
I much like your idea to outline a review process. What do you propose?
How do you identify errors on your end? I can produce a bibliography periodically and manually check for errors, but it seemed like you identified that one browser rendering issue that was not evident on the front end of Zotero. Are you able to address any of these errors during your indexing process if they are not clearly evident on my end (especially stable identifiers and other easily coded pathways)? Pardon my lack of knowledge, but is there a way to compare the metadata from the citation to the pdf corpus (similar to how Zotero extracts metadata to populate the parent group)? If so, we can automatically produce an error report with each batch of uploads.

https://taxodros.github.io/ does not document how they treated errors, insufficient metadata, or literature links.

https://taxodros.github.io/ does not document how they treated errors, insufficient metadata, or literature links.

I agree that Gerhard Bächli did not spell out his methods for curating his data. He provided the data as documented on https://taxodros.github.io . I exchanged numerous emails with @myrmoteras and Gerhard Bächli as well as opening issues https://github.com/TaxoDros/TaxoDros.github.io/issues to document and address review notes. Many of these notes are planned to be addressed in the upcoming July release.

Jorrit, are you extracting metadata from Zotero directly or from an exported bibliography? If the latter, can we address some of the transcription errors before indexing? When you export your library, Zotero produces a csv of the publications included in that library. Can we find and replace known transcription errors at this step?

Jorrit, are you extracting metadata from Zotero directly or from an exported bibliography?

I extract data directly from Zotero using their API.

If the latter, can we address some of the transcription errors before indexing?
When you export your library, Zotero produces a csv of the publications included in that library. Can we find and replace known transcription errors at this step?

In my mind, I version and translate the Zotero data such that Zenodo understands it. If the some data corrections happen in the translation process, the provenance of the information becomes murky - how would someone be able to re-use the corpus if the original data contains errors, but they cannot be seen in some derived form (e.g., indexing in Zenodo).
Thanks for the questions, and curious to hear your thoughts. Perhaps something to discuss tomorrow.

there is a lot of detail that was manually (incompletely) cleaned from the original google sheet datasheet "reference_extract" before using Zotero. That sheet also retained the origin of the document in the corpus (e.g., pulled from citations or a specific person's library).

@arw36 thanks for sharing your notes on the available metadata for some papers. To help move this along, would it be an idea to create a separate issue for this that includes some specific examples for publications that are currently in batlit and can be enriched with available metadata.
Curious to hear your thoughts.

seemed relevant to the curation workflow. Feel free to move.

@arw36 for sure! I followed the steps outlined in "feedback workflow" https://batlit.org/#feedback-workflow .

The new figure in the methods sections seems relevant to this issue - perhaps adding in a layer or color that clarifies private vs. public would aid in understanding the process more.


Investigate kong as new gateway application

Can we move from annon to kong?
Which features we need from kong?
How we can implement caching with kong vs. with annon?

Yes, i think we can. Mithril plugin required to:

validate token (already done)
resolve scopes (not done)

There is enterprise plugin for proxy caching and free plugin for cache into redis: https://github.com/wshirey/kong-plugin-response-cache . I think its possible to change plugin to use a different storage, if its needed of course.

Need to test for correct response if some entity is not found (Ecto.NoResultsError raised) - should be 404 status code


Improve the text at the top of the home page

Received the latest home page text from the product team

@microsoft-github-policy-service agree [company="{bivanovivanov}"]


How api gateway realizes real-time perception of offline services

Expected Behavior / New Feature
"ServiceDiscoveryProvider": { "Type": "Eureka" }
I have two same services, one of which needs to be updated, How api gateway realizes real-time perception of offline services?
Steps to Reproduce the Problem

Ocelot can understand that downstream service is offline on DNS level or it will wait for Timeout time and HttpRequest will fail with timeout error.
See more: Server error responses


clues: Split hot-cold locations into separate enums

Unrelated to this PR, but I'm curious: Why is the test in MasterHotColdLocationTest named beginnerHotColdLocationAreaTest instead of masterHotColdLocationAreaTest?

Copy+paste mistake from the fever dream that was writing HotColdSolver in the first place. I'll fix that momentarily


Newer for the annotation tool

@antingshen Could you give me a brief introduction (step by step) about how to using this tool to annotate video such as upload video, create links etc. .  I am not very clear for the readme file. Thank you very much.

Please try the readme file and let me know what's unclear. The gist is:

upload videos wherever you want
create video objects in beaverdam/db
annotate

@antingshen Thank you very much for your reply. For the video upload means i just put the video in the annotator/static/videos file or I need some command to run, could you give me some description? And also how to create video objects in beaverdam/db? Thanks.

BeaverDam's database does not store videos. Upload your video to whichever service you want to use to serve videos. If you want BeaverDam to serve your videos, put them in the static folder, (likely /static, see Django Static Files) and use your static link as the url (likely /static/folder/your_video.mp4)

I am new to this tool as well. I find the instructions a bit confusing. All I want to do is a list of sequential images ( Not using mechanical turk)

Do I have to convert it to mp4. Is there an option to use the list of images?
I put the videos in the  the static folder.
Then what? Could you please provide a step by step instruction? That will be really helpful.


Fix Typos in API YAML Files

Description:
Fix the typos that are in the API YAML Files.

Update
Typos have been fixed via the following PRs

https://github.com/wso2/apk/pull/864
https://github.com/wso2/apk/pull/823


exact package name is not always first result

Example: https://yarnpkg.com/en/packages?q=react-native&p=1

This is even more visible for vue-i18n which appears on the 5th results page.
https://github.com/vuejs/vue-cli/issues/1897

This is actually already fixed since the new query rules. Reason it wasn’t working for a bit was because of loss of settings


Add an Example for Trigger.Repetition Property

Please add an example for Trigger.Repetition Property.
I want to set up two scheduled tasks:

Set a task to run at 11 pm every night
Set the task to run per day 30 minutes after the first scheduled task is set to run.
Repeat this task every 30 minutes for 2 hours.

Please give an example to show how this repetition can be set up

// Instantiate a daily trigger that runs every day
var dt = new DailyTrigger(1);
// Starting today at 11pm
dt.StartBoundary = DateTime.Today.AddHours(23);
// Set the repetition to run every 30 mins for 2 hrs without a forced stop at the 2 hr mark
dt.SetRepetition(TimeSpan.FromMinutes(30), TimeSpan.FromHours(2), false);
// Create task with trigger
TaskService.Instance.AddTask("MyTask", dt, new ExecAction("yourexehere.exe"));


[Wallet Instance Attestation] Add mdoc_cbor in vp_formats_supported

          [Wallet Instance Attestation] Add mdoc_cbor in vp_formats_supported

in the wallet instance attestation non-normative example
https://github.com/italia/eidas-it-wallet-docs/pull/14/files#diff-f44e126e298004564899b4b86fc1f5e074b5ca6a96e9f546b7a1ed8987e61735R396
Originally posted by @peppelinux in https://github.com/italia/eidas-it-wallet-docs/pull/14#discussion_r1240968804

bad addressed


[Bug]: Plugin unavailable after 1.13.0 update

Describe the bug
Hey,
Suddenly, after installing the update (1.13.0) of Spaced Repetition on my MacBook (M1, Sonoma 14.7), I neither have access to Spaced Repetition in Obsidians preferences, nor to the application as a whole.
To Reproduce
See Screenshot
Expected behavior
Well i guess it would be lovely to have this beautiful application up and running again.
Screenshots

OS of your device
Sonoma 14.7
Obsidian version
1.6.7
Plugin version
1.13.0
Installer version
No response
Additional context
No response
Config file
No response

Same issue here, I'm also experiencing problems with Spaced Repetition after updating to version 1.13.0 on Windows 11. The plugin doesn't show up in Obsidian's preferences, and I can't access the application either.

Same here. The plugin is no longer usable. It fails loading:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'contains')
    at upgradeSettings (plugin:obsidian-spaced-repetition:11543:69)
    at _SRPlugin.loadPluginData (plugin:obsidian-spaced-repetition:26650:60)
    at async _SRPlugin.onload (plugin:obsidian-spaced-repetition:26358:5)

The way around is to manually delete the previous configuration. Then it loads with default configurations. I did not test it thouroughly but I assume it will work.

Hi all, I've just made a new release that should do the upgrade properly. Please give it a try.

There are no instructions. I guess one can figure it out by trial and error. Is 123 a delimiter? Or represented just an example for a content?

I'll link to the documentation in the next release. For now, here are the docs -> https://www.stephenmwangi.com/obsidian-spaced-repetition/flashcards/cloze-cards/#cloze-types. The "Cloze Types" & "Custom Cloze Patterns" should explain how to create custom patterns.

==[123;;]answer[;;hint]==

For instance, this pattern replaces picks up ==highlights== but you can add Anki-like sequencing. For instance ==1;;this== and ==1;;this== creates a single card (similar to Anki's {{c1:this}} and {{c1::this}} creates a single card):

You  can also add hints to your clozes, so for instance ==this;;hint== will be rendered as:


3601 hubspot backend changes

@matallo here's what I have so far. In a quick test locally everything seemed to be fine, including a 200 OK response from remote server.
If you're ok with it then I'm gonna merge this into your branch.

looks absolutely good to me (frontend tests are failing, but nothing related to the changes)

Frontend tests were OK :+1: (details)


TargetLib

Aim
I would like to add targetlib library
Details
Targetlib is a Library for generating network ranges, random ips and randomizing iplists.
Do I want to work on this:

[x]  Yes
[ ] No

Sure go ahead.. @infiniteoverflow


Updated useful_links.md

I don't think so much commits are really necessary.

Yes I agree with @PSanni.
@chintansoni202  It should be pushed in a single commit!


Fix tap({dest: ...})

Whenever I tried to use tap to write to a file I got error messages about callback being null.

Just noticed this is a duplicate of MR #210 (but with a different solution), to fix issue 224


Fixing Twilio extension assembly name

Hi @fabiocav, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Fabio Cavalcante). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@fabiocav : Thanks for your contribution to the Azure documentation! The author, @christopheranderson, has been notified to review your proposed change.

@fabiocav Thanks!! #sign-off
@christopheranderson I signed off on this.


Base Quest Anniversary NFT mint

What changed? Why?
Nav headings, connect wallet functionality, new mint page. All to support this NFT launch.

Notes to reviewers
How has it been tested?
Extensively via manual testing and bug bash
Does this PR add a new token to the bridge?
Are you adding an entry to assets.ts?

[x] No, this PR does not add a new token to the bridge
[ ] Yes, and I've confirmed this token doesn't use a bridge override
[ ] Yes, and I've confirmed this token is an OptimismMintableERC20

If you are adding a token to the bridge, please include evidence of both confirmations above for your reviewers.

Review Error for dneilroth @ 2024-04-25 21:37:24 UTC
User must have write permissions to review


[D4CRIS-279] Failure switch locale in the statistics page

When change the locale in the statistics page the system lost parameter in the query string:
Example:
https://dspace-glam.4science.it/cris/stats/rp.html?id=ba23322e-ceb6-48da-b81a-01333df9e900
when change locale the url shown is https://dspace-glam.4science.it/cris/stats/rp.html?locale=ar

Resolved in 543dfee30d2d2100e7584d6a88627e285a6f5fd0


CAMEL-14319: upgrade couchbase java client to 3.0.5

refactor component to work with newer client
remove options that were removed in newer clients
add possibility to specify collection and scope for newer couchbase

Looks like you started on this work before the 3.4.0 release and therefore its 3.4.0-SNAPSHOT and not updated to latest junit 5 migration etc.
So do you mind rebasing of master so this is applied on top and therefore up to date.

Thanks for the comments. Yeah it's true I started before 3.4.0 release. I'm already working on refactoring tests to use junit5..

We need to have a look to the karaf feature too


Update to work with Scarlet & Violet (SVI) cards

Also fixes it for Youtube as they had changed their DOM again

Changes are 95% just some automatic formatting changes


add description flag and function to set description

Signed-off-by: DiptoChakrabarty<EMAIL_ADDRESS>What this PR does / why we need it:
adds a flag to set a plugin description and underlying function logic to set description
Which issue(s) this PR fixes

Fixes #1647

Special notes for your reviewer:
Release note:
release-note

Hi and thanks for the PR, however I'm skeptical of the approach.

there are other fields that could be edited on the plugin, so why only a command to edit the description?
the PR description says its adding a flag but the PR actually adds another command specifically to modify the description field
the sonobuoy plugin list command shows where there file is located; if you want to edit it you can open the file and tweak anything you'd like about the plugin, that is the approach I would recommend for editing installed plugins

Let me know what you think about my comments above and we can decide a direction on this.

Seeing that you linked back to the pre-existing issue I see that this is just a misunderstanding of solution.
On the command gen plugin a flag should be able to edit the description just like all the other plugin building flags.
This is the file and approach you should take: https://github.com/vmware-tanzu/sonobuoy/blob/main/cmd/sonobuoy/app/gen_plugin_def.go#L107-L109

This fails with a panic since d is already used as a shorthand for the debug mode. Just remove the shorthand value for this. If you think description is too verbose you can change it to desc, I'm fine either way.
$ sonobuoy gen plugin -h
panic: unable to redefine 'd' shorthand in "plugin" flagset: it's already used for "description" flag

goroutine 1 [running]:
github.com/spf13/pflag.(*FlagSet).AddFlag(0xc000128c00, 0xc000292320)
...
...


Finalize user activation feature

Just some last tweaks and improvements before merging it in master. All credits go to @mark-todd and @eddsalkield.

I think I'm quite happy with the code now 😄 I'll start to write the documentation!

I think I'm quite happy with the code now 😄 I'll start to write the documentation!


Smartswitch fix for fast-sample

Description
This update handles coinbase only returning 300 datarows at a time when using smartwitch and fast-sample with a larger date range.
This update fixes coinbase and binance fast-sample using smartswitch
Fixes # (364)
Type of change
Please make your selection.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This change requires a new dependency
[ ] Code Maintainability / comments
[x] Code Refactoring / future-proofing

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added pytest unit tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Missed file updated resolving


V2V - Force insecure connection to OpenStack for wrapper

When migrating virtual machines to RHV, we force insecure connection to RHV-M. This PR implements the same for OpenStack, so that we stay consistent.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1651689

@miq-bot add-label transformation, enhancement, hammer/yes, blocker

@jameswnl @agrare could you please review ?

that's what we have for RHV

Doesn't mean that was right when we did that either haha

that's what we have for RHV

Doesn't mean that was right when we did that either haha

Sure, but this is a small change. Implementing real SSL support would imply more time and we're short on time for GA.

We have a documentation to setup SSL on the conversion host, even for self-signed CA, so I think we can close this one and work on changes for both RHV and OpenStack in another PR.


Add integrity hashes

Hi, thanks for you work !
I am wondering if there is any plan (or way) to implement integrity hashes into script / links ?
Could make it work with this repo maybe : https://github.com/ElMassimo/vite-plugin-manifest-sri
Thanks.

hi @Samy-Belarbi, I was thinking of looking into it this feature this week but I see that you forked the repo maybe you wanted to take care of it ?

Hey @lhapaipai, i will give it a try at the end of the week but i'm not sure to manage to achieve this with my current skills.
So please do not change your plan of looking into it.

hi @Samy-Belarbi, I've implemented the feature in both branches feature/sri.
can you please give me your opinion?
on the other hand for my own knowledge i thought this attribute was important with cdn, is it also for resources that come from the same domain as the one that returns the source html file ? can you explain to me ?

Hey !
You are right, it's mostly used when you get your assets from a CDN, the browser doesn't load files if they are not matching their integrity hashes, so you are sure you are loading the correct files.
As far as i know, i don't think that's pretty useful if your files come from your own production website because if someone malicious can manipulate your files from it, it would be too late i guess ? Anyway, that can be one more security, but an overkill one.
Amazing work, i can't wait to try it. Merci !

Thanks @Samy-Belarbi,
I will therefore check that the configuration of vite and the bundle are compatible with a cdn and I will then publish the update !
I will be inspired by webpack again : https://symfony.com/doc/current/frontend/encore/cdn.html

fixed with #52


Also show local IP addresses

Currently local IP addresses are filtered and not shown in the Network Analysis tab. Do make them show as targeted samples may contain hardcoded IP addresses to other boxes in the same private network.

We should however filter out those that are involved for Cuckoo operations. I feel that otherwise it's mostly gonna cause lots of confusion. @jekil thoughts?

Cuckoo operations shouldn't be captured at all due to bpf filtering of host <-> guest in the sniffer auxiliary module. I think what Jurriaan is getting as is the dropping of packets if it's a local network which is done in the network processing module:
https://github.com/cuckoobox/cuckoo/blob/master/modules/processing/network.py#L179
Why not make it configurable? :)

There's still a lot that bpf filter isn't filtering out.  That kind of stuff I also considered as "Cuckoo operations".

While that may be true, there is no UDP traffic parsers that we particularly care about. I deleted that line for a custom inetsim rig and that generated some 'bloat' stuff. So really the only thing you have to do is ignore some of the tcp/udp dissection in the tcp/udp panes. But honestly, that is probably the least useful information overall when quickly looking at an analysis -- IMO.

@KillerInstinct jus to be clear, what do you refer to with the least useful information overall here?

The TCP/UDP tabs. They are generally unuseful for quickly looking at an analysis and really only provide supporting information to other networking data.

Agreed, now would be a good time to port those to http/https/etc protocols and remove the streams from the tcp/udp tabs for all streams that are represented in another tab.


working with real  MiniON outputs (multiple fasqfiles)

Dear Qalign developer - This software takes as input a fasta file to generate and convert it to its quantized version.  When I am sequencing one gene or a region of the gene (amplicons) with nanopore technology,  I get several fastq files for the same sample ID.   Should I concatenate the files, convert this to fasta format and provide this last one as input to the 'qalign/main.py' script?
Thank you!
~DD

Yes, that should work as long as the input to Qalign is in fasta format.