Add support for webhook ca bundle

Hi, this PR adds support to set caBundle for webhooks explicitly. This is useful for following reasons:

It is needed when pilot is configured with a well known certificate
It improves istio gitops installation because pilot don't need to patch webhook caBundle and failurePolicy which conflicts with git config.
Probably makes installing webhooks easier during remote istio installation?

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@thedebugger: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test release-notes

unit-tests-arm64_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test release-notes

unit-tests-arm64_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test unit-tests-arm64

gencheck_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test release-notes

unit-tests-arm64_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test unit-tests-arm64

gencheck_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test gencheck

unit-tests_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test unit-tests-arm64

gencheck_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test gencheck

unit-tests_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test unit-tests

release-notes_istio
dfbe1f923425f708236e7f014231903a2169580c
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test gencheck

unit-tests_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test unit-tests

release-notes_istio
dfbe1f923425f708236e7f014231903a2169580c
link
true
/test release-notes

unit-tests-arm64_istio
dfbe1f923425f708236e7f014231903a2169580c
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
cedbb78bdb895f415fbe1c490269fe21afb7bd00
link
true
/test unit-tests

release-notes_istio
dfbe1f923425f708236e7f014231903a2169580c
link
true
/test release-notes

unit-tests-arm64_istio
dfbe1f923425f708236e7f014231903a2169580c
link
true
/test unit-tests-arm64

gencheck_istio
dfbe1f923425f708236e7f014231903a2169580c
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
dfbe1f923425f708236e7f014231903a2169580c
link
true
/test release-notes

unit-tests-arm64_istio
dfbe1f923425f708236e7f014231903a2169580c
link
true
/test unit-tests-arm64

gencheck_istio
dfbe1f923425f708236e7f014231903a2169580c
link
true
/test gencheck

unit-tests_istio
dfbe1f923425f708236e7f014231903a2169580c
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/retest

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
dfbe1f923425f708236e7f014231903a2169580c
link
true
/test gencheck

unit-tests_istio
dfbe1f923425f708236e7f014231903a2169580c
link
true
/test unit-tests

unit-tests-arm64_istio
8cf78eac6c758078edd88b04ae19e8f988654ebb
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
dfbe1f923425f708236e7f014231903a2169580c
link
true
/test unit-tests

unit-tests-arm64_istio
8cf78eac6c758078edd88b04ae19e8f988654ebb
link
true
/test unit-tests-arm64

gencheck_istio
8cf78eac6c758078edd88b04ae19e8f988654ebb
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8cf78eac6c758078edd88b04ae19e8f988654ebb
link
true
/test unit-tests-arm64

gencheck_istio
8cf78eac6c758078edd88b04ae19e8f988654ebb
link
true
/test gencheck

unit-tests_istio
8cf78eac6c758078edd88b04ae19e8f988654ebb
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8cf78eac6c758078edd88b04ae19e8f988654ebb
link
true
/test unit-tests-arm64

unit-tests_istio
8cf78eac6c758078edd88b04ae19e8f988654ebb
link
true
/test unit-tests

gencheck_istio
5909e4f3ff9560a44e832d15422cc72b4d11a8b6
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@thedebugger: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
882a580213ab021b0c5e55bdb8e22daa7c8b2c0b
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thedebugger: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-basic-arm64

integ-ambient_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-ambient

unit-tests-arm64_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test unit-tests-arm64

analyze-tests_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test analyze-tests

integ-distroless_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-distroless

integ-cni_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-cni

gencheck_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test gencheck

integ-ds_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-basic-arm64

integ-ambient_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-ambient

unit-tests-arm64_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test unit-tests-arm64

analyze-tests_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test analyze-tests

integ-distroless_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-distroless

integ-cni_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-cni

gencheck_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test gencheck

integ-ds_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-ds

integ-helm_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-helm

integ-pilot-istiodremote_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-pilot-istiodremote

integ-operator-controller_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-operator-controller

integ-pilot-istiodremote-mc_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-basic-arm64

integ-ambient_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-ambient

unit-tests-arm64_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test unit-tests-arm64

analyze-tests_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test analyze-tests

integ-distroless_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-distroless

integ-cni_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-cni

gencheck_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test gencheck

integ-ds_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-ds

integ-helm_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-helm

integ-pilot-istiodremote_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-pilot-istiodremote

integ-operator-controller_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-operator-controller

integ-pilot-istiodremote-mc_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-pilot-istiodremote-mc

integ-security-istiodremote_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-security-istiodremote

integ-pilot-multicluster_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-pilot-multicluster

integ-pilot_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-basic-arm64

integ-ambient_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-ambient

unit-tests-arm64_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test unit-tests-arm64

analyze-tests_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test analyze-tests

integ-distroless_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-distroless

integ-cni_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-cni

gencheck_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test gencheck

integ-ds_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-ds

integ-helm_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-helm

integ-pilot-istiodremote_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-pilot-istiodremote

integ-operator-controller_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-operator-controller

integ-pilot-istiodremote-mc_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-pilot-istiodremote-mc

integ-security-istiodremote_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-security-istiodremote

integ-pilot-multicluster_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-pilot-multicluster

integ-pilot_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-pilot

integ-ipv6_istio
663f281246f9bbbf6d1fe4acd3a4e51bd0ea71ec
link
true
/test integ-ipv6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn i removed the bashc changes. any other tests you want me to run before I merge this PR?

/cc @jaellio

/retest tide

@thedebugger: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test analyze-tests
/test bookinfo-build
/test gencheck
/test integ-ambient
/test integ-basic-arm64
/test integ-cni
/test integ-distroless
/test integ-ds
/test integ-helm
/test integ-ipv6
/test integ-operator-controller
/test integ-pilot
/test integ-pilot-istiodremote
/test integ-pilot-istiodremote-mc
/test integ-pilot-multicluster
/test integ-security
/test integ-security-istiodremote
/test integ-security-multicluster
/test integ-telemetry
/test integ-telemetry-discovery
/test integ-telemetry-istiodremote
/test integ-telemetry-mc
/test lint
/test release-notes
/test release-test
/test unit-tests
/test unit-tests-arm64

The following commands are available to trigger optional jobs:

/test benchmark
/test experimental-tracing
/test integ-ambient-calico
/test integ-assertion

Use /test all to run the following jobs that were automatically triggered:

analyze-tests_istio
gencheck_istio
integ-ambient_istio
integ-basic-arm64_istio
integ-cni_istio
integ-distroless_istio
integ-ds_istio
integ-helm_istio
integ-ipv6_istio
integ-operator-controller_istio
integ-pilot-istiodremote-mc_istio
integ-pilot-istiodremote_istio
integ-pilot-multicluster_istio
integ-pilot_istio
integ-security-istiodremote_istio
integ-security-multicluster_istio
integ-security_istio
integ-telemetry-discovery_istio
integ-telemetry-istiodremote_istio
integ-telemetry-mc_istio
integ-telemetry_istio
lint_istio
release-notes_istio
release-test_istio
unit-tests-arm64_istio
unit-tests_istio

In response to this:

/retest tide

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thedebugger: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
a3835bbde4709453329e0983b5a172111d272c61
link
unknown
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry_istio

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
a3835bbde4709453329e0983b5a172111d272c61
link
unknown
/test integ-telemetry

integ-telemetry-istiodremote_istio
a3835bbde4709453329e0983b5a172111d272c61
link
unknown
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thedebugger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
a3835bbde4709453329e0983b5a172111d272c61
link
unknown
/test integ-telemetry-istiodremote

integ-security-multicluster_istio
a3835bbde4709453329e0983b5a172111d272c61
link
unknown
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster_istio integ-security-multicluster_istio

/test integ-security-multicluster_istio

/test integ-telemetry-istiodremote_istio

🎉

🎉


Zoomit 6.11 ,when draw by finger or pen , it have a texture error

I use surface laptop win11, when I draw by finger or surface pen  ,a texture error occur

I have the same problem.  Fresh install on a fresh Windows 11, fully up to date.  Latest Nvidia drivers
Dell precision 5770.
i9-12900H iGPU drives laptop panel
RTX A3000 dGPU drives external dual 4K monitors via Thunderbolt 4
Laptop panel is a 4K Touch fully functional but I usually keep the lid closed and only use the External displays.
Problem happens on all screens.
My black square is not centered on the Pen tip.  It is aligned to the top left corner of the black square.
Thank you all for the help and support.

https://user-images.githubusercontent.com/32348862/218925960-20a13079-52d4-475c-873b-631e8d5d6a2e.MOV

Thanks, will build a fix for these!

Hello team, any updates on this?
Thank you.

UPDATE: UPDATE: Version 7.0 does not fix this on Widows 11 on a Dell Precision 5770 with RTX A3000 GPU. Still showing black square around cursor.


Y-axis static labels

Y-axis labels are generating automatically. Can we give input for y-axis lables?

Yes, it becomes very odd when showing something that can only be integers. Like 3.34534 individuals in my bar chart. :)

Yes, it becomes very odd when showing something that can only be integers. Like 3.34534 individuals in my bar chart. :)

So how do you add the labels?

Possible duplicate of #122?

Y-axis labels are generating automatically. Can we give input for y-axis lables?

how to make sticy y-axis on line chart


Undefined method "Sync" for

Not sure when this started, but I’m seeing this error when using the gem:
♠ cloudflare-dns-update
 0.22s    error: Cloudflare::DNS::Update::Command [pid=86231] [2020-11-28 18:22:15 -0500]
               |   NoMethodError: undefined method `Sync' for #<Cloudflare::DNS::Update::Command::Top:0x00007fe2ce8b06b0>
               |   Did you mean?  Async
               |   → /usr/local/var/rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/cloudflare-dns-update-3.0.1/lib/cloudflare/dns/update/command.rb:170 in `call'
               |     /usr/local/var/rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/samovar-2.1.4/lib/samovar/command.rb:36 in `call'
               |     /usr/local/var/rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/cloudflare-dns-update-3.0.1/lib/cloudflare/dns/update/command.rb:34 in `call'
               |     /usr/local/var/rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/cloudflare-dns-update-3.0.1/bin/cloudflare-dns-update:26 in `<top (required)>'
               |     /usr/local/var/rbenv/versions/2.7.0/bin/cloudflare-dns-update:23 in `load'
               |     /usr/local/var/rbenv/versions/2.7.0/bin/cloudflare-dns-update:23 in `<main>'

I’m a bit rusty with my Ruby, so I’m not really sure where it’s expected the Sync method to come from.

I will check... can you tell the version of async you are using?

🕙 13:25:17 jeffbyrnes in Jeff’s iMac in ~ took 2s
♠ gem list async

*** LOCAL GEMS ***

async (1.24.2, 1.24.1)

Can you please update to the latest version of async. kernel/sync was needed to be required explicitly before but it's now required by default.

That worked!
🕙 11:18:59 jeffbyrnes in Jeff’s iMac in ~
♠ gem install async
Fetching console-1.10.1.gem
Fetching fiber-local-1.0.0.gem
Fetching async-1.27.0.gem
Successfully installed fiber-local-1.0.0
Successfully installed console-1.10.1
Successfully installed async-1.27.0
Parsing documentation for fiber-local-1.0.0
Installing ri documentation for fiber-local-1.0.0
Parsing documentation for console-1.10.1
Installing ri documentation for console-1.10.1
Parsing documentation for async-1.27.0
Installing ri documentation for async-1.27.0
Done installing documentation for fiber-local, console, async after 0 seconds
3 gems installed

🕙 11:19:05 jeffbyrnes in Jeff’s iMac in ~
♠ cloudflare-dns-update --configuration ~/dev/home.A.yml
This configuration does not contain authorization token, we require some details.


REQ: A live stream of Paul using aider so we can shoulder surf and observe workflow and best practices

Issue
Paul, I wanted to ask if you would consider the idea of doing a live stream of some of your update work on aider.  Nothing that needs to be scripted, just something stream of consciousness as you select and resolve issues or add enhancements using aider.
It could be really helpful to see and hear how you decide on what files to include or remove from the chat, when you clear the chat, how you build your prompts and how you iterate through bugs.  I always find it fascinating to "shoulder surf" with experts and invariably pick up things the presenter intended and also catch some "wait a second, how/why did he just do that?" things that are beneficial as well.
For example, understanding your thinking on when the right time to clear the chat history is when iterating through a multi-faceted update or enhancement workflow would be really useful.
Version and model info
Aider v0.56.0
Main model: claude-3-5-sonnet-20240620 with diff edit format, prompt cache, infinite output
Weak model: claude-3-haiku-20240307
Git repo: .git with 6 files
Repo-map: using 1024 tokens, files refresh
VSCode terminal detected, pretty output has been disabled.

Thanks for your interest in aider. Not sure I'm set up to live stream my coding though.
I'm going to close this issue for now, but feel free to add a comment here and I will re-open. Or feel free to file a new issue any time.


Improve readability of .travis.yml

Coverage remained the same at 85.089% when pulling dde790fb803fccbffa272cb7a289d5e4902072a3 on travis/indent into 6779dd2438c84a5ecdef5978bd88ef25b03096ac on master.

But I don't like the extra spaces at the start of list items. This doesn't match the style I've seen in most YAML files.

Hm, I thought adding indentation is the convention: here, here. If there is the strict convention there, I would like to follow it!

@jslee02 is correct that most YAML linters and the documentation suggests that indenting before the - in lists is the convention.
However, annoyingly, .travis.yml autogeneration (i.e. running something like travis setup releases from their CLI) seems to follow the convention that these items are not indented.  I think this is why many .travis.yml files end up following this convention.  Both are readable by most parsers.

Actually, it looks like even the YAML spec is ambiguous about this, as it has non-indented examples as well.
http://www.yaml.org/spec/1.2/spec.html#id2802802
http://www.yaml.org/spec/1.2/spec.html#id2772312


Devel branch update: New models and examples

Two three-section BOP models with HTGR boundary condition are added:

@novova enhanced three-section BOP with OFWH models making dP across LPT is controlled.

Package order is slightly changed.

Technically the dP control is not at all the purpose of the model, purpose and effect is a controlled extraction. The constant dp control is just a part of method to achieve it.


Work around Unity's async cancellation

Under certain circumstances, task cancellation in Unity will happen later in the same frame, instead of synchronously.
Due to this, state strings during errors often get updated only after the error has been propagated, causing them to be waiting ([.]) instead of canceled ([-]). This also caused the tests for Unity to have to be slightly different from .NET tests.
To work around this, we can await Task.Yield() before propagating errors.
It caused some breaking changes in RunAsLoop, which can no longer be synchronous, so I'm starting a v5 branch now, as there are other breaking changes I'd also like to make.

The missing code coverage is on closing curly braces, and looks like some weirdness caused by an added await inside a catch. Couldn't figure out anything that could be done about it, so ignoring it now. 100% coverage would be nice, but this doesn't seem worth working around.


Can't seem to remove damageable items

Removing a damageable item seems to result in no action on the server; the client estimates the action and gives you a ghost item, but the server doesn't remove the item or correct the client's estimate.

Cannot reproduce in an environment containing only Correlated.


File configuration for non-student users

Why this feature?
This feature is designed for non-student users. The goal is to have the best configuration experience for mdCreator.
Feature Description
When launching the program after the update, the program will ask you if you're a student or not.
If you are a student, the program will write the result as it writes now.
If you're not, the program will write the file without concerning any organization.
If you work for an organization and you want to mention it, you'll be able to.
When will it be up?
This feature will be updated in the next mdCreator release.

Issue Update
Due to my time working on other projects, this feature will be updated later.

Issue Update
A first version has been locally deployed for testing.

Issue Update
Local tests are not concluant. Issue will be closed for the moment.
Feature will be re-opened (for sure) but not now.

Issue update
After several progress in the mdCreator dev, we're coming to an end with this issue.
mdCreator now uses a mdCreatorrc file just like a .ini file. mdCreator.json has also be updated to increase the possibility to add several templated configurations.
{
  "student": {
    "header": {
      "range": 1,
      "title": null,
      "description": " is a new project."
    },
    "disclaimer": {
      "range": 2,
      "title": "Before continuing...",
      "description": "This project is an EPITECH Project. If you are an EPITECH student, move out the way! Nothing to see here... The groups don't want to be involved to your -42.\nIf you're not, no worries! You're welcome here!"
    },
    "prerequisites": {
      "range": 3,
      "title": "Prerequisites"
    },
    "program": {
      "range": 3,
      "title": "Building program",
      "description": "Tell here how to compile / use / test your program."
    },
    "style": {
      "range": 3,
      "title": "Coding Style"
    },
    "authors": {
      "range": 2,
      "title": "Authors",
      "description": "* **Arthur Adam** - [0Nom4D](https://github.com/0Nom4D)"
    },
    "gifs": {
      "nbGifs": 5
    }
  },
  "pro": {
    "header": {
      "range": 1,
      "title": null,
      "description": " is a new project."
    },
    "gifs": {
      "nbGifs": 5
    }
  }
}

You have to fill and edit the 'pro' configuration if you're planning to use it as a non student user.
Every informations that will persist through time will be supported by this rc file.

Issue closed
Functionality has been implemented. Next step is to implement unit testing / functional tests to test the functionality of each part of code.
Merging ns-config to dev will be done when Wikis will be updated.


Attributes and data-loading

In loading states docs there is a statement:
Often, you'll want to show (or hide) an element while a component is re-rendering or an action is processing.

But for me it doesn't work as expected.
I have a pagination component which is used in a live component. There are two buttons: prev and next.
If I am on page 1, then the I add the disabled attribute on it in the twig, and same with last page.
When I initially load the page, that attribute get's removed.
So the docs should indicate that it will run also on initial load?
My use case is that I want to disable buttons when I've clicked on them, to indicate that request is already processing.
But there is also a problem, that the attribute will be always removed because of:
case 'addAttribute':
            return isLoading ? 'addAttribute' : 'removeAttribute';

I can think only a workaround to add data-loading only if the button must not be disabled..
Or do you think that this use case would be more common so we could add some way to do this easier?

just as a first suggestion, could you avoid adding the data-loading in Twig when the button is disabled? If I understand things correctly, if (for example) page=1, then you will add a disabled attribute to the "page 1" link. In that case, the data-loading doesn't make any sense on that link, right? It is disabled and should always be disabled - no loading behavior is needed on that button. Then, once the user clicks to page 2, the template would re-render and you could then add the data-loading.
WDYT? I'm not saying we shouldn't do some sort of code fix, but I'm not sure yet :). The reason we run the "loading has stopped" logic on initial load is so that if you have a data-loading="show" on an element, we can hide that element immediately after initial load. We certainly could make this smarter so that ONLY this rule runs on "initial load", and all other data-loading mechanisms do NOT run on initial load. PR welcome for that if it makes sense ;)


Ambiguous "begin" overload

When following the CoreInk Quick Start tutorial I got the following error:
/Users/andrew/Documents/Arduino/libraries/M5-CoreInk/src/M5CoreInk.cpp: In member function 'int M5CoreInk::begin(bool, bool, bool)':
/Users/andrew/Documents/Arduino/libraries/M5-CoreInk/src/M5CoreInk.cpp:23:33: error: call of overloaded 'begin(int, int, int)' is ambiguous
         Wire.begin(32, 33, 10000);
                                 ^
In file included from /Users/andrew/Documents/Arduino/libraries/M5-CoreInk/src/utility/BM8563.h:4,
                 from /Users/andrew/Documents/Arduino/libraries/M5-CoreInk/src/M5CoreInk.h:8,
                 from /Users/andrew/Documents/Arduino/libraries/M5-CoreInk/src/M5CoreInk.cpp:1:
/Users/andrew/Library/Arduino15/packages/m5stack/hardware/esp32/2.0.1/libraries/Wire/src/Wire.h:79:10: note: candidate: 'bool TwoWire::begin(int, int, uint32_t)'
     bool begin(int sda=-1, int scl=-1, uint32_t frequency=0); // returns true, if successful init of i2c bus
          ^~~~~
/Users/andrew/Library/Arduino15/packages/m5stack/hardware/esp32/2.0.1/libraries/Wire/src/Wire.h:80:10: note: candidate: 'bool TwoWire::begin(uint8_t, int, int, uint32_t)'
     bool begin(uint8_t slaveAddr, int sda=-1, int scl=-1, uint32_t frequency=0);
          ^~~~~
exit status 1
Error compiling for board M5Stack-CoreInk.

My fix was to change line 23 in M5CoreInk.cpp from...
Wire.begin(32, 33, 10000);

to...
Wire.begin(32, 33, (uint32_t) 10000);

That eliminated the ambiguity and the code compiled as expected. Is this a common issue or something unique to my setup? Is it worth my making a branch? I am using the following setup:
OS: macOS Catalina
Arduino: 1.8.19
M5Stack CoreInk: 0.0.2
ESP32 libraries: 2.0.1

Hello @andreburto
thank you for your proposed fix. I've seen the issue in other projects and I think it is related to the 2.0.x version of the ESP32 libraries.
Thanks
Felix


[#1391] [Bug] Direct memory may leak in exceptional scenarios in shuffle server.

What changes were proposed in this pull request?
Release the direct memory in the finally block to prevent memory leaks.
Why are the changes needed?
For #1391
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running server successfully.

PTAL @zuston @jerqi

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (386f795) 53.21% compared to head (e4b6d3a) 53.47%.

Files
Patch %
Lines

...niffle/server/netty/ShuffleServerNettyHandler.java
0.00%
3 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1392      +/-   ##
============================================
+ Coverage     53.21%   53.47%   +0.25%
+ Complexity     2719     2190     -529
============================================
  Files           419      342      -77
  Lines         23989    15416    -8573
  Branches       2050     1428     -622
============================================
- Hits          12766     8243    -4523
+ Misses        10433     6708    -3725
+ Partials        790      465     -325

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Usage with ionic 2 ?

Hej,
is your lib usable with Ionic 2 ?
if yes, which is the process to include it ?
thanks

I have not tried it with Ionic, but I expect it would work. It uses only standard Cordova plugins File and FileDownload
You should be able to download the distribution and add it to your "www" folder, then follow the examples. No other installation (`cordova' commands) should be necessary.

thanks @gregallensworth ,
i am trying,
i had imported js files within index.html of ionic app, and then in my component
import  'leaflet';
import  'leaflet-tilelayer-cordova';

and it seems to work, L variable is available.
I have now to detect cordova and adapt my code to work with my app.
thanks again.

the only alert that i have is
Property 'tileLayerCordova' does not exist on type 'typeof L'.
I have installed types for leaflet, but not for your script.. Are they existing ?

Finally i resolved the problem with passing L variable to a local typsecript variable
L : any;
....
this.L = L;

now it seems to work.


[Proposal] Let kubectl-plugin import KubeRay types from ray-operator

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Currently kubectl-plugin uses dynamic client to get ray resources. We can try to import KubeRay types from ray-operator.
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Use association.go to associate CRs and the K8s resources owned by these CRs.


If a user specifies --entrypoint it should clear the cmd field

This matches the way that docker build and buildah bud works.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

https://github.com/projectatomic/buildah/issues/600

@pixdrift PTAL

LGTM

This is failing in the same spot that my #596 is.  I think they're inter-related.  I'm going to merge this into my sanbox and see if by chance the combo fixes straightens out the tests.  I think it just might.

Nice one 👍 😀

@rh-atomic-bot r=pixdrift


Need default value to function?

It is observed in https://github.com/Moelf/FHist.jl/pull/83 that you need default value for the keyword argument for this package to work, is this intended?

Hm, yes, I didn’t think this would be a potential use case so it’s not set up right now. But I guess it could be integrated by, in the macro, assigning the default value abstract type, and then checking if it has been set or not within the function body.

Fixed by #7. Could you take a look when you get a chance? Thanks!

@Moelf Looks like the no-defaults branch is working. I'm guessing I'll wait for @MilesCranmer to merge it into master and then update my own pull request on Moelf/FHist.jl#83?


GCM does not work with marshmallow's battery optimizations

When using battery saver, GCM does not work.
As soon as I tell Android not to optimize microG Services Core, GCM works again.

Rom: Omnirom
Android: 6.0.1
Thanks

Battery optimization has to be disabled for mircoG services to work properly. This is the same for the original Google Play Services. See @mar-v-in 's post in #31

I was not sure it was documented, but it is: https://github.com/microg/android_packages_apps_GmsCore/wiki/Installation
Closing. Thanks.


Slatepack input Dialogs, error reporting

Slatepack input dialog parsing message goes into notification. There can be too many messages because parsing happens on every update.
We need to suppress those error messages from going into notification.

High priority because it is easy to fix.

Fix in the branch. Will update ticket status after the merge

Verified, hence closing this ticket.


Fix incorrect value returned by HTTPClient.get_response_body_length on Web (reverted)

Fix #77642

Thanks!

The change was effectively reverted by https://github.com/godotengine/godot/pull/79846. It looks like we can't reliably compute the size of the body on the web platform due to browser limitations. So the value of -1 is correct in this case.


Exact features set to be used for testing

Describe the problem you are trying to solve
The software needs to be recompiled several times to test with every set of features to be tested with.
Moreover, there is no automated way to make cargo to test a package with several different sets of features.
Describe the solution you'd like
Please add to target section of Cargo.toml new key exact-features that will cause this target to be compiled with this exact set of features, independently of what features are specified in the command line:
exact-features = ["use_assembler", "no_api_v2"]

This would allow to use such a target together with test = true to test it fully automatically.
Notes
Also, the suggested feature is useful for software requiring especially good reliability to complicate user to change features (but the reason I suggest it is for testing).

Thanks for the suggestion!  I'm not sure I fully understand what is being requested here, but I believe this is suggesting that cargo targets could have certain features enabled by default.  If so, I believe this is covered by RFC 3020.  Regardless, a major change like this should probably go through the RFC process.


Can I auto-generate the API documentation?

There's a feature in Fastify, which lets you use swagger to auto-generate the documentation.
Can I do the same in tiny-http as well?

tinyhttp is similar to express
so (almost) anything for express will work for tinyhttp
https://github.com/scottie1984/swagger-ui-express

thanks for the quick reply!
Okay, I'll try integrating this once.

I've also tried with openapi-validator-middleware, probably should work with it as well


Scaffolding failed to edit Startup class

I get an error when trying to scaffold the movie model. I'm using the .Net Core 3.0 preview with Visual Studio 2019 and get this error:
"There was an error running the selected code generator: Scaffolding failed to edit Startup class to register the new context using Dependency Injection. Make sure there is a Startup class and a ConfigureServices method and configuration property in it."
I checked and the Startup.cs file has a ConfigureServices method and a Configure property.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6719f08e-3bd7-dc1a-71df-f2ef9fbca9d8
Version Independent ID: 7096fdb3-612e-9e00-bd0b-8ea4886a09ce
Content: Add a model to a Razor Pages app in ASP.NET Core
Content Source: aspnetcore/tutorials/razor-pages/model.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

I added a Configuration property to the Startup class in Startup.cs.
public IConfiguration Configuration { get; }
That takes care of the above mentioned error but gives me a new one when trying to add a scaffolding item.
"There was an error running the selected code generator:
There was an error creating a DbContext :C\users\ \startup.cs(6.18): error CS0234: The type or namespace name 'Components' doesn ot exist in the namespace 'MyApp' (are you missing an assembly reference?)
C:<mypath>\Startup.cs(51.28): error CS0246: The type or namespace name 'App' could not be found (are you missing a using directive or an assembly reference?)"
At row 6 in my Startup.cs is using Streampeak.Components; and row 51 is the very last, empty line of the file.

It seems like everything is working as expected now.
For some reason I got the wrong version of the .NET Core 3.0 SDK.
In any case, I uninstalled the one I had, deleted the project I just created, installed SDK 3.0.100-preview4-011223. Now everything works.
I noticed that my Startup.cs was missing the following code inside the Startup class. Maybe it can help someone with similar problems.
`		public Startup(IConfiguration configuration)
{
Configuration = configuration;
}
	public IConfiguration Configuration { get; }`

This issue can now be closed. ^^

Lets see if I can get the proper formatting of the code. There should really be an option to edit your comments here..
	public Startup(IConfiguration configuration)
	{
		Configuration = configuration;
	}
	public IConfiguration Configuration { get; }


protorpc rewrites all 40x errors to 400

Raising an exception such as endpoints.api_exceptions.NotFoundException ought to result in an error with http status code 404, but protorpc detects it as a subclass of protorpc.remote.ApplicationError and sends 400 instead.

https://github.com/google/protorpc/blob/95849c9a3e414b9ba2d3da91fd850156348fe558/protorpc/wsgi/service.py#L151

https://github.com/google/protorpc/blob/95849c9a3e414b9ba2d3da91fd850156348fe558/protorpc/wsgi/service.py#L184

is anyone going to fix this?  makes it quite hard to debug problems before it even hits our code

ProtoRPC is not actively maintained, and was never intended to be used for this use case anyway, but I will fix it if I can figure out a way.


deadlocks with pymongo possible

Deadlock can happen because the global "db" variable is used to connect to the DB via the api.wsgi entrypoint before uwsgi forks the process.
I initially looked into this because of this message in the uwsgi log:
uwsgi_1          | 2016-03-03 15:38:05      scitran.api                config.py   121:DEBU Refreshing configuration from database
uwsgi_1          | /usr/local/lib/python2.7/dist-packages/pymongo/topology.py:74: UserWarning: MongoClient opened before fork. Create MongoClient with connect=False, or create client after forking. See PyMongo's documentation for details: http://api.mongodb.org/python/current/faq.html#using-pymongo-with-multiprocessing>
uwsgi_1          |   "MongoClient opened before fork. Create MongoClient "

@rentzso and @gsfr
Besides avoiding the config.get_item() call in this case, can a unit test be created to expose similar regressions in the future? Maybe api.app_factory() could be moved to its own file to reduce the surface area of global includes?
Deadlock Background here:
http://api.mongodb.org/python/current/faq.html#using-pymongo-with-multiprocessing
Offending line:
https://github.com/scitran/core/blob/master/api/handlers/searchhandler.py#L10
Stack trace:
uwsgi_1          | Traceback (most recent call last):
uwsgi_1          |   File "bin/api.wsgi", line 3, in
uwsgi_1          |     from api import api
uwsgi_1          |   File "./api/api.py", line 19, in
uwsgi_1          |     from handlers import searchhandler
uwsgi_1          |   File "./api/handlers/searchhandler.py", line 10, in
uwsgi_1          |     es_client = elasticsearch.Elasticsearch([config.get_item('persistent', 'elasticsearch_host')])
uwsgi_1          |   File "./api/config.py", line 139, in get_item

Nice find. I suspect that #172 would be solved by solving this issue.

It looks like an issue related to the API "global" behavior, so integration testing should be the right way of testing it.
@ryansanford could you attach the full uwsgi logs? I don't understand if the Stack Trace is before or after the warning
@gsfr what are the reasons to persist the config?

@rentzso
To capture the stack trace, I introduced an exception into config.get_item(). I tried to just print the stack trace, but as you can see from the uwsgi output, I forgot to import traceback, which in the end, got me what I wanted, the stack trace from the api.wsgi entrypoint.
config.api change to force exception:
def get_item(outer, inner):
    try:
        raise Exception()
    except Exception as error:
        log.debug(traceback.format_exc())
    return get_config()[outer][inner]

uwsgi output:
uwsgi_1          | [uWSGI] getting INI configuration from config/uwsgi-config.ini
uwsgi_1          | *** Starting uWSGI 2.0.11 (64bit) on [Thu Mar  3 17:40:07 2016] ***
uwsgi_1          | compiled with version: 4.8.4 on 03 March 2016 13:08:15
uwsgi_1          | os: Linux-3.13.0-32-generic #57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 2014
uwsgi_1          | nodename: a95e17acb465
uwsgi_1          | machine: x86_64
uwsgi_1          | clock source: unix
uwsgi_1          | detected number of CPU cores: 2
uwsgi_1          | current working directory: /var/scitran
uwsgi_1          | detected binary path: /usr/local/bin/uwsgi
uwsgi_1          | !!! no internal routing support, rebuild with pcre support !!!
uwsgi_1          | chdir() to code/api
uwsgi_1          | your processes number limit is 524288
uwsgi_1          | your memory page size is 4096 bytes
uwsgi_1          | detected max file descriptor number: 524288
uwsgi_1          | lock engine: pthread robust mutexes
uwsgi_1          | thunder lock: disabled (you can enable it with --thunder-lock)
uwsgi_1          | uwsgi socket 0 bound to TCP6 address [::]:9000 fd 3
uwsgi_1          | Python version: 2.7.6 (default, Jun 22 2015, 18:01:27)  [GCC 4.8.2]
uwsgi_1          | Python main interpreter initialized at 0x2403db0
uwsgi_1          | python threads support enabled
uwsgi_1          | your server socket listen backlog is limited to 100 connections
uwsgi_1          | your mercy for graceful operations on workers is 60 seconds
uwsgi_1          | mapped 415360 bytes (405 KB) for 8 cores
uwsgi_1          | *** Operational MODE: preforking+threaded ***
uwsgi_1          | added code/data to pythonpath.
uwsgi_1          | 2016-03-03 17:40:08      scitran.api                config.py    85:DEBU Database(MongoClient(host=['scitran-mongo:27017'], document_class=dict, tz_aware=False, connect=False, replicaset='elasticflywheel', connecttimeoutms='300000', j=True, serverselectiontimeoutms='300000'), u'scitran')
uwsgi_1          | Traceback (most recent call last):
uwsgi_1          |   File "bin/api.wsgi", line 3, in <module>
uwsgi_1          |     from api import api
uwsgi_1          |   File "./api/api.py", line 19, in <module>
uwsgi_1          |     from handlers import searchhandler
uwsgi_1          |   File "./api/handlers/searchhandler.py", line 10, in <module>
uwsgi_1          |     es_client = elasticsearch.Elasticsearch([config.get_item('persistent', 'elasticsearch_host')])
uwsgi_1          |   File "./api/config.py", line 139, in get_item
uwsgi_1          |     log.debug(traceback.format_exc())
uwsgi_1          | NameError: global name 'traceback' is not defined


Improve CAA record handling

This PR aims to address two issues I ran into attempting to create CAA records with the Provider. Feel free to use it as idea fodder rather than merging it directly. (See especially the 2nd bullet under "What I Changed" below.)
What I wanted to fix

It seems that the issuing domain for CAA issue and issuewild records is wrapped in quotes by your back-end. For example, 0 issue amazon.com becomes 0 issue "amazon.com". (My conclusion that this happens is based creating the records in TF and then inspecting the records in the Namecheap web console.). However, because the provider allows the record without quotes, and stores it like that in TF state, such records forever shows a difference when planned, saying the record was removed outside of Terraform and needs to be created.
CAA iodef records should permit a mailto: address, but the provider (or more accurately, the vendored go-namecheap-sdk library) checks that the record against a regex that only permits proto:// style addresses with two trailing slashes. There are no trailing slashes with the mailto: protocol.

What I changed
This PR contains what seemed like minimal changes needed to address these issues.

I renamed fixCAAIodefAddressValue() to fixCAAAddressValue() and apply it to all CAA records, not just iodef types. This ensures the domain is always quoted, to match what your back-end actually creates.
I modified the regex used in iodef URL protocol matches to make the // after the : optional. I realize this should really not be changed in a vendored copy of the go-namecheap-sdk, but I figured this was a simple way to show the change in context. Honestly, this regex (and the check in general) could stand to be made smarter. From what I can tell, only http://, https:// and mailto: are expected in an iodef CAA record, so the regex could be something like https?://|mailto:. And if you're going to check the protocol at all, you might want to check the whole URI for validity. For example, the currently logic doesn't care what protocol name, you put in front of the slashes or check that the rest of the URL is valid.
I fixed a small spelling error / typo. hasSuffixQuite() -> hasSuffixQuote()
I also tossed in a change you should feel free to ignore if it isn't valid or reasonable: the default ttl for records being 1799s seconds, or 29 minutes, 59 seconds. That just seemed strange, since even your web console offers standard values like 5, 10, 30 and 60 minutes. But you may have good reasons for using that value here. :man_shrugging:

Did I test this?
Yes. I modified the tests so my change to fixCAAIodefAddressValue() so go test will pass. I also added new test cases for the expanded use.
Additionally, I tested the provider locally and verified the following:

CAA issue and issuewild records that lack quotes around the domain now show no differences when you plan after apply. Note that Terraform thinks that records with and without quotes are different records, so changing them back and forth to quoted or not in HCL will cause plan differences between changes. However, entries are now consistent with your back-end behavior whether they have quotes in the HCL or not.
I was able to create a CAA iodef records with a mailto: URI. where previously this would fail on apply.

The forced pushes were to add sign-off (for DCO) and then to fix the email on my commit to match the key I signed it with. :stuck_out_tongue:

@alexvlasov Can this please be merged?


Ignore some failing build-init tests

https://github.com/gradle/gradle-private/issues/3420

@bot-gradle test RFR

OK, I've already triggered ReadyForRelease build for you.


Peer review source code

The benchmarks might be showing wrong results and need to be peer reviewed.
Area worth paying special attention to: The V8 JavaScript engine might be optimizing the some functions so the benchmark isn't actually running the expected code.

Hi, author of uuid-random here.
Do you have any more info on how V8 does this? In my experience, "accessing" system entropy seems like the largest performance bottleneck, which hints to why caching gives such a massive speed boost.
I recently noticed my benchmarks quintupled in ops/sec between node v10 and node v12. I would love to know what changed and why that happened.
I did not see a comparable speedup in, e.g., id128.


Graceful dat.json title update

https://github.com/dat-land/dat-desktop/pull/458#discussion_r194382667
Not sure if we should ignore completely the title update if the dat.json file doesn't exist.

standard: Use JavaScript Standard Style (https://standardjs.com)   /Users/travis/build/dat-land/dat-desktop/app/actions/index.js:270:27: 'blob' is not defined.

ping @martinheidegger I've updated the PR

Hello @soyuka - Sorry for the delay, was stuck in other things.


enable-admin-api is not possible

What did you do?
I tried to delete some stale data from Prometheus like
curl -XPOST https://prometheus.internal.loveos.io/api/v1/admin/tsdb/clean_tombstones
but for that I have to enable admin-api first, which is not possible at the moment
What did you expect to see?
some positive http response
What did you see instead? Under which circumstances?
{"status":"error","errorType":"unavailable","error":"Admin APIs disabled"}
Environment

Kubernetes version information:

Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.3", GitCommit:"d2835416544f298c919e2ead3be3d0864b52323b", GitTreeState:"clean", BuildDate:"2018-02-09T21:51:06Z", GoVersion:"go1.9.4", Compiler:"gc", Platform:"darwin/amd64"} Server Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.6", GitCommit:"6260bb08c46c31eea6cb538b34a9ceb3e406689c", GitTreeState:"clean", BuildDate:"2017-12-21T06:23:29Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:
kops

Manifests:

insert manifests relevant to the issue

Prometheus Operator Logs:

insert Prometheus Operator logs relevant to the issue here

We should figure out what to do here, and maybe even clean tombstones automatically with the sidecar. @fabxc what is your take on this?

People may want to be able cleaning up some data manually, as described here https://prometheus.io/docs/prometheus/latest/querying/api/#delete-series
Could you just introduce optional parameter for enabling "TSDB Admin APIs"?  If it is not enabled by default it should not be security concern, right? I could make and test a patch.
`pkg/prometheus/statefulset.go
@@ -385,6 +385,10 @@ func makeStatefulSetSpec(p monitoringv1.Prometheus, c *Config, ruleConfigMaps []
promArgs = append(promArgs, "-web.external-url="+p.Spec.ExternalURL)
}

  if p.Spec.EnableAdminApi == "true" {

          promArgs = append(promArgs, "-web.enable-admin-api")

  }

  webRoutePrefix := "/"
  if p.Spec.RoutePrefix != "" {
          webRoutePrefix = p.Spec.RoutePrefix`

Ideally I'd like to have things like cleaning tombstones directly worked into the Prometheus Operator, so people don't have to think about those operational aspects themselves, for that however these APIs would always need to be enabled.

For that we could simply add a cronjob to Prometheus Operator manifests.

Something like that would most likely need to be implemented into the sidecar.

Is not it better then sidecar ?
contrib/kube-prometheus/manifests/prometheus/prometheus-k8s-cronjobs.yaml
@@ -0,0 +1,17 @@
+apiVersion: batch/v1beta1
+kind: CronJob
+metadata:
+  name: prometheus-k8s
+  namespace: monitoring
+spec:
+  schedule: "0 0 * * *"
+  jobTemplate:
+    spec:
+      template:
+        spec:
+          containers:
+          - name: prometheus-k8s-cronjob
+            image: busybox
+            args:
+            - "curl -XPOST http://prometheus-k8s:9090/api/v1/admin/tsdb/clean_tombstones"
+          restartPolicy: OnFailure

To be on the same page, do you mean "prometheus-config-reloader" as a side car?

Yes. The name is at this point slightly misleading, but that would be a good place to have things like that.

@wleese that makes sense. The problem I want to avoid is enabling users to create public Prometheus servers with unauthenticated/unauthorized admin APIs.

@brancz I'm sure this is a problem for users of the api on the public Prometheus server. On your part, there is a default value that turns off the API. Is not it?
I now needed to delete several metrics. Unfortunately, this is not possible at the moment. I would like to still be able to configure Prometheus as the developers intended, and not to rest on your vision of the configuration situation. The operator is not a firewall. Everyone should think for themselves what and when he includes those or other options.

We can add it as an experimental field, what we’re trying to do here is make a user to the right thing, not necessarily restrict it in total.
We’re all part of the upstream team and even implemented those APIs, we are well aware of their existance and dangers.

Well, I understand. I agree that many can simply copy the configs without thinking about their essence. What about checking for the basic authentication annotations for ingress? Or as on my ingress, the presence of annotations nginx.ingress.kubernetes.io/auth-satisfy: any,
  nginx.ingress.kubernetes.io/whitelist-source-range: .....
This will minimize the likelihood of launching an API on a publicly accessible server

There are too many possibilities how people could protect their Prometheus server, we should just add the field and put a warning in the documentation, that it should always be protected.

@mmerrill3 this work is not currently underway. Contributions are always welcome :)

I got the similar case here. My dev and uat k8s cluster nodes mainly built via AWS spot fleet. They come and go everyday, which create lots of kubelet endpoints which could be safely removed since those internal ip addresses will never come back.
If this feature has no plan to implement, at least please provide some document on how we could sort of hack into TSDB to clean up metrics we no longer need. Secure TSDB access should be easier than code change.

I don't believe this ended up being implemented, but as the conversation went, we're open for contributions regarding this, under the condition that it is marked with its dangers :slightly_smiling_face: .

Even though v.0.28.0
says this is included as per changelog.
having:
{
    "dependencies": [
        {
            "name": "kube-prometheus",
            "source": {
                "git": {
                    "remote": "https://github.com/coreos/prometheus-operator",
                    "subdir": "contrib/kube-prometheus/jsonnet/kube-prometheus"
                }
            },
            "version": "v0.28.0"
        }
    ]
}

and doing jb install
Doesn't show this change on addons/kube-prometheus/vendor/kube-prometheus/prometheus/prometheus.libsonnet
which looks as below:
        spec: {
          replicas: $._config.prometheus.replicas,
          version: $._config.versions.prometheus,
          baseImage: $._config.imageRepos.prometheus,
          serviceAccountName: 'prometheus-' + $._config.prometheus.name,
          serviceMonitorSelector: {},
          serviceMonitorNamespaceSelector: {},
          nodeSelector: { 'beta.kubernetes.io/os': 'linux' },
          ruleSelector: selector.withMatchLabels({
            role: 'alert-rules',
            prometheus: $._config.prometheus.name,
          }),
         ...


any documentation on how to use this?

any documentation on how to use this?

+1 on this. I'd like to use it and since I can't 'go' I don't really understand how these plugin works

+1 on this. be nice if there was a binary... can anyone provide one for linux? CentOS 7... and docs for setting up the provider... id imagine .... server, username, password. if someone can provide me a binary build i can probably get through the provider config from reading the source

i believe a tf file would be whats pasted below, edit for your needs.....  i tried but im getting
terraform plan
Error configuring: 1 error(s) occurred:

Incompatible API version with plugin. Plugin version: 1, Ours: 2

xen.tf___________
provider "xenserver" {
url = "http://xxxxxxx.xxx"
username = "xxxxx"
password = "xxxxxxxx"
}
resource "xenserver_vm" "myvm" {
name_label = "My VM"
base_template_name = "centos-7"
xenstore_data {
hostname = "myvm.example.com"
ip = "XXX.XXX.XXX.XXX"
}
}

@svkamp, I had the same issue.  I'm using the @meltwater fork of this and I had to update the terraform dependency to the latest version to get this to build correctly.  I have a fork of it as well that has the dependency bump committed to it.

@angrycub time for a PR I would say. 😄

All, in my last commits, I added docs similar to the official provider. Unfortunately, it is not known which toolchain is used to generate the docs similar to the official providers. It seems I'm not the only one needing this:
https://github.com/hashicorp/terraform/issues/16749
If I find out, I'll generate the docs and publish them automatically.

Very nice work of yours !
However there is still a big lack of documentation.

@debovema very well aware of it. My focus however is on a better test setup so more people can easier contribute to this provider. See #16 for more info.

OK I understand. I will try to participate to #16 then.

@debovema @babatundebusari are the docs on the website good enough these days to get you bootstrapped?
https://terra-farm.github.io/provider-xenserver/index.html


Скласти інтро

Скласти інтро (вступ), де в 2-4 реченнях описати, що замовник робить, що подобається робити, що хочеться робити краще, що важливо робити, тощо.

I am a very sweet and kind punk who is happy to help friends or acquaintances. I am constantly developing and studying new technologies. I wish to learn to code beautifully and quickly, I think it will help my career well

I am a very sweet and kind punk who is happy to help friends or acquaintances. I am constantly developing and studying new technologies. I wish to learn to code beautifully and quickly, I think it will help my career well


Request Flatpak package

Would be nice to have universal Linux package which could installed without hassle. More info on official site and Flathub. I'll try to help with initial build and submitting package on Flathub soon. If you interesting in maintain it let me know.

project seems to be abandoned

Yep, but app is still works fine and available on Flathub. JFYI.

Please, consider supporting Flatpak and publishing VirusTotal uploader on Flathub.


Document.append does not handle utf-8 encoding

Saw this error via Document.append():
======================================================================
ERROR: test_AAA (test.test_roundtrip.TestRoundTripSBOL2) [pICSL50014.xml] (filename='pICSL50014.xml')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/SBOL/sbol/test/test_roundtrip.py", line 82, in test_AAA
    self.run_round_trip(f)
  File "/SBOL/sbol/test/test_roundtrip.py", line 45, in run_round_trip
    split_path[0] + split_path[1]))
  File "/SBOL/sbol/document.py", line 330, in read
    self.append(filename)
  File "/SBOL/sbol/document.py", line 381, in append
    self.graph.parse(f, format="application/rdf+xml")
  File "/usr/local/lib/python3.6/dist-packages/rdflib/graph.py", line 1043, in parse
    parser.parse(source, self, **args)
  File "/usr/local/lib/python3.6/dist-packages/rdflib/plugins/parsers/rdfxml.py", line 578, in parse
    self._parser.parse(source)
  File "/usr/lib/python3.6/xml/sax/expatreader.py", line 111, in parse
    xmlreader.IncrementalParser.parse(self, source)
  File "/usr/lib/python3.6/xml/sax/xmlreader.py", line 123, in parse
    buffer = file.read(self._bufsize)
  File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in position 8027: ordinal not in range(128)

The file sbol/test/SBOLTestSuite/SBOL2/pICSL50014.xml has non-ascii characters (see lines 136 and 137). This file passes SBOL validation.
Two alternatives seem to work:

First, we can open the file in binary mode (with open(filename, 'rb')) -- this is what RDFLib does (see parser.py)
We can stop opening the file altogether and just pass the filename on to RDFLib. This approach seems the safest.

Both approaches pass the tests in test_roundtrip.py.

Here's the change I think we can make for approach two above:
diff --git a/sbol/document.py b/sbol/document.py
index 4eb9bf5..6191954 100644
--- a/sbol/document.py
+++ b/sbol/document.py
@@ -372,18 +372,17 @@ class Document(Identified):
         :return: None
         """
         self.logger.debug("Appending data from file: " + filename)
-        with open(filename, 'r') as f:
-            if not self.graph:
-                self.graph = rdflib.Graph()
-            # Save any changes we've made to the graph.
-            self.update_graph()
-            # Use rdflib to automatically merge the graphs together
-            self.graph.parse(f, format="application/rdf+xml")
-            # Clean up our internal data structures.
-            # (There's probably a more efficient way to merge.)
-            self.clear(clear_graph=False)
-            # Base our internal representation on the new graph.
-            self.parse_all()
+        if not self.graph:
+            self.graph = rdflib.Graph()
+        # Save any changes we've made to the graph.
+        self.update_graph()
+        # Use rdflib to automatically merge the graphs together
+        self.graph.parse(filename, format="application/rdf+xml")
+        # Clean up our internal data structures.
+        # (There's probably a more efficient way to merge.)
+        self.clear(clear_graph=False)
+        # Base our internal representation on the new graph.
+        self.parse_all()

     def parse_all(self):
         # Parse namespaces

This issue only happens when the environment variable LANG is unset, as it is in a docker environment. When LANG=en_US.utf8, the UTF8 document is read properly.
Since the recommended fix works in both environments, it is probably desirable. It wouldn't be surprising to see the SBOL module used in a docker environment.

SBOL is definitely used in Docker environments, but this can probably be
pushed back to 1.0 if you want.
Thanks,
-Jake
(sent from my phone)
On Thu, Nov 14, 2019, 2:08 PM Tom Mitchell<EMAIL_ADDRESS>wrote:

This issue only happens when the environment variable LANG is unset, as it
is in a docker environment. When LANG=en_US.utf8, the UTF8 document is read
properly.
Since the recommended fix works in both environments, it is probably
desirable. It wouldn't be surprising to see the SBOL module used in a
docker environment.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/llotneb/SBOL/issues/17?email_source=notifications&email_token=ACRONO6HV3ZGOXPHPKPV6CTQTWV2DA5CNFSM4JMI5OEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEDD6SQ#issuecomment-554057546,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACRONO47U5AXIYDOTZV5N3LQTWV2DANCNFSM4JMI5OEA
.


Target profile page rewrite: Create Google Analytics tracking code and determine which events should be tracked

Initial tracking code and document with event details can be found on the OT Core Platform Team Google Drive
Details on which events to be captured will be updated once prototype of proof-of-concept is ready for review.


fix: ts comparison

This fixes the following typescript warnings that pop up when you change the values of username and webApiKey from their defaults.
This comparison appears to be unintentional because the types '""' and '"myUsername"' have no overlap.

This comparison appears to be unintentional because the types '""' and '"myWebApiKey"' have no overlap.

Thanks for the PR!
I'm not convinced we should move forward with this change.
The conditional on line 28, which is likely what's throwing the warning, will never fire as a result of this.


Enable Organizational Account System

Enables creation of "sub-user" accounts
Enables monitoring of all sub-user accounts
Enables billing rate proxying to sub-user accounts

See https://github.com/RTradeLtd/database/pull/46 for work being done


Communicate with TTGO over WIFI.

After stable release of v2 we need to work on wireless communication between these modules, as in future we might place these module in separate place so, we should not be dependent on there physical connectivity as they are currently communicating via serial port. Make them able to communicated wirelessly via WIFI.

Completed in #151


remove opacity for tab button

I find iOS doesn't have opacity effect on tabs, therefore change alpha to 1.
How about using TouchableNativeFeedback for android?

Looks good addition, could you make it configurable (as option)?


Migrated project to TypeScript

This is a developer preview of migrating the project to the TypeScript.
TypeScript declarations are generated based on this branch: typescripted.
New declarations are published to the types branch.

Most of the work is finished at this point. All vanilla files are migrated to TypeScript, including the test files. Everything looks pretty decent, but I will suggest more thorough examination and testing, just to make sure.


Hot reloading selector used in connect() does not work

For example, when using export default connect(mainMenuSelector)(MainMenu) and changing the returned object in mainMenuSelector, these changes do not propagate to the React component after hot reloading.
However, when using export default connect(appState => appState)(MainMenu) and calling the mainMenuSelector from within render() with this.props.appState, it does work after hot reloading. What explains the difference here? I'm using the new way of hot reloading with https://github.com/gaearon/react-transform-boilerplate

Please see https://github.com/rackt/react-redux/issues/115.

This is fixed in React Hot Loader 3.
It is built with lessons learned from both React Hot Loader and React Transform.
It’s still in alpha but I encourage you to check it out!

Awesome, I will check it out! Thanks for all your hard work, I really appreciate it.


Encrypted password not decrypting to start the application

Hi,
When I run gradle encryptProperties --password=tmp in the project folder, it encrypted properly which is in application.yml from the command line after the encryption the application does not start.
Can you help me out what I'm missing.
Attached the code sample.zip

@ximtech, do you have time to check this.

Hi! For decryption in runtime you need to add dependency in build.gradle
implementation "com.github.ulisesbocchio:jasypt-spring-boot-starter:3.0.5"

Thanks @ximtech for the update. Is there any online tool to encrypt/decrypt.

When plugin parse configuration file it also takes provided yasupt config if it present. So you can change encrypt/decrypt parameters directly in application yaml/properties. Please check the example in doc:  link

Thank you.


feat: add forum/media channel create methods

Pull Request Type

[x] Feature addition
[ ] Bugfix
[x] Documentation update
[ ] Code refactor
[ ] Tests improvement
[ ] CI/CD pipeline enhancement
[ ] Other: [Replace with a description]

Description

Adds helper methods for Discord's resource datatypes regarding to creating forum and media channels.
Changes

See contents
Related Issues

#1487

Test Scenarios

Python Compatibility

[ ] I've ensured my code works on Python 3.10.x
[ ] I've ensured my code works on Python 3.11.x

Checklist

[ ] I've run the pre-commit code linter over all edited files
[ ] I've tested my changes on supported Python versions
[ ] I've added tests for my code, if applicable
[ ] I've updated / added  documentation, where applicable

Codecov Report
Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 46.15%. Comparing base (b41c47e) to head (03106fa).

Files
Patch %
Lines

interactions/models/discord/channel.py
50.00%
2 Missing :warning:

interactions/models/discord/guild.py
50.00%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #1629   +/-   ##
=========================================
  Coverage     46.15%   46.15%
=========================================
  Files           147      147
  Lines         15618    15626    +8
=========================================
+ Hits           7208     7212    +4
- Misses         8410     8414    +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


EBeam_YunTing.gds

the design is missing opt_in labels for testing.

@Yunting-Hsia
We are now past the deadline.
Our next submission will be in February 2025.
The repository will be set up soon: https://github.com/SiEPIC/openEBL-2025-02
You may fix your design and submit next time.
thank you
Lukas


Revise pattern to use 'variation instead of 'mutation'

For the disease series by gene pattern, we create terms that are labeled:  [disease] caused by mutation in [gene]
We propose to change the primary label to:
[disease] caused by variation in [gene]
per @courtneythaxton's advice on https://github.com/monarch-initiative/mondo/issues/3123#issuecomment-893839567
@ahamosh please let us know if there are any objections to using 'variation' in the primary label in place of 'mutation'.
Action items:

[ ] revise pattern to use variation in primary label and add 'disease caused by mutation in gene' as an exact synonym
[ ] search and replace throughout the mondo-edit.obo file to replace usage of mutation with variation for terms that use this pattern.

Do you want just variation or do you want pathogenic variant(s), or pathogenic variation?  I have no problem with removing the word mutation, but it is much easier to search for and find the word mutation than variant or variation.

Hmm, you ask a good question @ahamosh. My first instinct would be to suggest just variation, however I understand that use of "variation" would indicate possibly more than one variant that is causative, or pathogenic for the related disease. My only worry with saying pathogenic variant, is whether all of these variants have been evaluated per ACMg guidelines. There will be instances like Sickle Cell Anemia that are well established, however there could be newer gene-disease relationships that show a single variant in multiple (like 5 or less) un-related individuals, but may not have enough alternative data to support a pathogenic classification.

On the Mondo call, we decided to use variant instead of pathologic variant.


AMReX MLMG bottom solve change causes PeleLMeX EB_PipeFlow test to fail

After https://github.com/AMReX-Codes/amrex/pull/3991 (stemming from https://github.com/Exawind/amr-wind/issues/886) the PeleLMeX EB_PipeFlow test is failing on the nodal projection on the first timestep: https://github.com/baperry2/PeleLMeX/actions/runs/9784946279/job/27016932023.
Despite the CI failing on this test, I've tried with a few different machines and compilers and haven't been able to reproduce the failure locally. However, turning up verbosity for the nodal projection when running locally, I see that since the change the case takes more iterations for the nodal projection to converge (10 vs 8) and there are more frequent bottom solve failures.
@marchdf @WeiqunZhang @asalmgren @jrood-nrel it looks like you all worked the issue in amr-wind. Any idea what might be happening here in LMeX?

With amrex 36f111b2c (old):
 ====================   NEW TIME STEP   ====================
 Est. time step - Conv: 1.208751229e-05, divu: 1e+200
 STEP [0] - Time: 0, dt 1.208751229e-05
   - Advance()::MACProjection()  --> Time: 0.114974
Nodal Projection:
 >> Before projection:
  * On lev 0 max(abs(rhs)) =<PHONE_NUMBER>

MLMG: # of AMR levels: 1
      # of MG levels on the coarsest AMR level: 3
MLMG: Initial rhs               =<PHONE_NUMBER>
MLMG: Initial residual (resid0) =<PHONE_NUMBER>
MLMG: Bottom solve failed.
MLMG: Iteration   1 Fine resid/bnorm = 0.00144668188
MLMG: Iteration   2 Fine resid/bnorm = 4.887726517e-05
MLMG: Iteration   3 Fine resid/bnorm = 2.942642069e-06
MLMG: Iteration   4 Fine resid/bnorm = 1.881492075e-07
MLMG: Iteration   5 Fine resid/bnorm = 1.168997847e-08
MLMG: Iteration   6 Fine resid/bnorm = 7.832919149e-10
MLMG: Iteration   7 Fine resid/bnorm = 5.112867833e-11
MLMG: Iteration   8 Fine resid/bnorm = 3.276700523e-12
MLMG: Final Iter. 8 resid, resid/bnorm = 2.422098078e-09, 3.276700523e-12
MLMG: Timers: Solve = 0.223404125 Iter = 0.200380083 Bottom = 0.014959123
 >> After projection:
  * On lev 0 max(abs(rhs)) =<PHONE_NUMBER>

   - Advance()::VelocityAdvance  --> Time: 0.469178
 >> PeleLMeX::Advance() --> Time: 0.588156

With amrex 0e3e39b5e  (new):
====================   NEW TIME STEP   ====================
 Est. time step - Conv: 1.208751229e-05, divu: 1e+200
 STEP [0] - Time: 0, dt 1.208751229e-05
   - Advance()::MACProjection()  --> Time: 0.116781
Nodal Projection:
 >> Before projection:
  * On lev 0 max(abs(rhs)) =<PHONE_NUMBER>

MLMG: # of AMR levels: 1
      # of MG levels on the coarsest AMR level: 3
MLMG: Initial rhs               =<PHONE_NUMBER>
MLMG: Initial residual (resid0) =<PHONE_NUMBER>
MLMG: Bottom solve failed.
MLMG: Iteration   1 Fine resid/bnorm = 0.001387041191
MLMG: Bottom solve failed.
MLMG: Iteration   2 Fine resid/bnorm = 0.004341203704
MLMG: Bottom solve failed.
MLMG: Iteration   3 Fine resid/bnorm = 9.172997472e-05
MLMG: Bottom solve failed.
MLMG: Iteration   4 Fine resid/bnorm = 0.0001001601963
MLMG: Bottom solve failed.
MLMG: Iteration   5 Fine resid/bnorm = 2.247555741e-06
MLMG: Bottom solve failed.
MLMG: Iteration   6 Fine resid/bnorm = 1.879934597e-07
MLMG: Bottom solve failed.
MLMG: Iteration   7 Fine resid/bnorm = 6.093181729e-09
MLMG: Bottom solve failed.
MLMG: Iteration   8 Fine resid/bnorm = 3.940754528e-10
MLMG: Bottom solve failed.
MLMG: Iteration   9 Fine resid/bnorm = 2.055977701e-11
MLMG: Bottom solve failed.
MLMG: Iteration  10 Fine resid/bnorm = 1.157841855e-12
MLMG: Final Iter. 10 resid, resid/bnorm = 8.558629361e-10, 1.157841855e-12
MLMG: Timers: Solve = 0.316350708 Iter = 0.292605167 Bottom = 0.057702499
 >> After projection:
  * On lev 0 max(abs(rhs)) =<PHONE_NUMBER>

   - Advance()::VelocityAdvance  --> Time: 0.567521
 >> PeleLMeX::Advance() --> Time: 0.688364

Could you try https://github.com/AMReX-Codes/amrex/pull/4020?

I was able to reproduce the failure with the CI test. And the amrex pr fixes it.

It looks like this does fix the test that was failing, but I opened a draft PR #397 to make sure all tests pass


Ignore big diffs

I believe this to be the root cause of #189 ! Large diffs were taking down the app. I noticed one in particular that was 4mb large - that was causing issues. Upon some digging, that diff turned out to be the addition of one huge file called vendor.js - we really don't need to be scanning files like that, or minified files in general.
~As a temporary measure, I've made it check the length of the diff against a max size of 1,000,000 characters.~
~It'd be great to do a timeout on the request itself, so if the payload is gigantic it'll just timeout. This above method still tries to download the whole payload which could be too large. I'm not sure if that's a built-in thing - @gr2m :wave: any ideas?~
I got some wonderful guidance from GitHub's API team who suggested a HEAD request to get the content-length! This works great, and avoids having to download the big diff.

This has been working really well so far. 24 hours with zero errors, and metrics that are waaaay better than in #189:

There have been ~250 "Diff is too large" logs in the last 24 hours. It's really hard to gauge whether or not those are all "really really bad and would cause downtime" or "would cause significant performance problems but not downtime" - so I'm going to merge this and continue to monitor. 🎉


got some problem using exec

Node version:4.4.3
ShellJS version (the most recent version/Github branch you see the bug on):^0.7.0
Operating system:ubuntu14.04
Example ShellJS command to reproduce the error:

exec('cd /var/log').code == 0, but can cwd not changed

exec('ls /var/log/nginx/{hello.,}example.com_access.log') // show no such file or dictory but     ls('/var/log/nginx/{hello.,}example.com_access.log') can list all
exec('ls /var/log/nginx/*.example.com_access.log') can list all too

Hi,
We actually don't support exec('cd'), because exec spawns a subprocess, and there's no way for a subprocess to change the parent's working directory. But cd does work.
I'm going to close this, but feel free to reopen if I've misunderstood.

The reason ls does not work is because exec spawns ash shell, not a bash shell. Use the {shell: "path/to/bash"} option to get full bash expansion.
I'll clarify this in the docs.
In general, if we offer a shelljs function for a specific command, we recommend using that instead of exec.

@ariporad @nfischer Thanks for your reply!
{shell: "path/to/bash"} helped me


Enable error handlers back

While discussing with a colleague, he made me notice that the current setup of the bundle doesn't report everything. Due to the disabled error handler, all trigger_error are ignored if they do not raise an exception; so deprecations or notices cannot be collected like this. This was also reported as with #318 by @ruudk.
With this PR I'm adding new, improved E2E tests to try and get back the handles, so we can collect all errors, without the old issue of duplicated events (see #156 as an example).
Please, test this out because I'm not 100% sure that my E2E tests are reproducing the real behavior correctly.

My fear is that by having two error handlers they could conflict or the errors could be handled twice or handled differently from what would happen without Sentry. What about investigating whether it's possible to attach to the Symfony error handler instead?

The new end to end tests should keep us safe in regards of double reporting, and in fact I've spotted just one case, fatals, and I've safely ignored them.
As for attach points, there are only two and those are not sufficient: a PSR-3 logger and the possibility to attach an exception handler, nothing more.

Why it's the PSR-3 logger not sufficient?

Because it's very limited in information, only level & message; no stack trace, for example.

To me it looks like the exception is passed in the context 🤔 Did you look at how Monolog logs errors in a Symfony application?

Monolog handler is a completely separate option in this bundle: #247

Sure, what I meant was to look at how Monolog was integrated in Symfony out-of-the-box (e.g. when it logs to var/logs/*) to understand if they use a custom error handler or not

Monolog is PSR-3 compliant, so that interface is surely used as a junction. I can't do that without losing information, as I said.
Also, it seems that Symfony simply injects the logger service wherever is needed:

https://github.com/symfony/http-kernel/blob/a3b12e2925bc9f042b92e1ead400aab9ad408c76/EventListener/ErrorListener.php#L39
https://github.com/symfony/http-kernel/blob/a3b12e2925bc9f042b92e1ead400aab9ad408c76/EventListener/RouterListener.php#L72
https://github.com/symfony/http-kernel/blob/a3b12e2925bc9f042b92e1ead400aab9ad408c76/EventListener/DebugHandlersListener.php#L54

I can't do that without losing information, as I said

We discussed this privately, but I'm gonna leave here some notes for future reference: as far as I remember from our conversation, you have at disposal everything you need from the Monolog context (the exception is always present under the context.exception field, and if it isn't present then the client will use the backtrace instead. Also, what I was talking about was to create a little PSR-3 implementation to attach to the Symfony ErrorHandler component. The issue however is that there can be only one logger at once registered with the handler, so we cannot go on with this proposal.
Said this, I see a big issue with this change, if I'm not missing something: it looks to me that now all integrations are enabled by default regardless of whether Monolog is used, so either you have to update the README to explain that you manually need to disable the (FatalError|Error|Exception)ListenerIntegration integrations or you need to  handle this case while configuring the DI container

Said this, I see a big issue with this change, if I'm not missing something: it looks to me that now all integrations are enabled by default regardless of whether Monolog is used, so either you have to update the README to explain that you manually need to disable the (FatalError|Error|Exception)ListenerIntegration integrations or you need to handle this case while configuring the DI container

Nope, that's not the case. The monolog-sentry integration is NOT enabled by default, as before; and there's already an option to shut off the listeners, useful if you enable the Monolog integration.

I know that the Monolog integration is enabled by default, but as soon as I enable it then those integrations should be disabled without having to do it manually, do you agree? The listener will also be disabled, but this does not prevent the error handler from being registered as soon as one of those integrations run, so it's better if they don't even get set up

So you would bind the enabling of the default integrations to the register_error_listener option? That seems feasibile... I'll dig into it.

So you would bind the enabling of the default integrations to the register_error_listener option

Yes, also because not doing this means breaking the compatibility with the current applications that have Monolog enabled: they will suddendly start having one new error handler registered, which could cause issues in the long run

@ste93cry can I get an approval here? I would like to merge this and use it as a fallback after I implement integrating with Monolog as the first choice as you and Nicolas suggested.

Due to #337 + 02e6902, master is now 4.x. Fixing conflicts and merging now.


Enable CDAT-migrated E3SM Diags

Issue resolution

Closes #346. Replaces #598

Select one: This pull request is...

[ ] a bug fix: increment the patch version
[x] a small improvement: increment the minor version
[ ] an incompatible (non-backwards compatible) API change: increment the major version

1. Does this do what we want it to do?
Objectives:

Enable zppy to call the CDAT-migrated E3SM Diags

Required:

[ ] Product Management: I have confirmed with the stakeholders that the objectives above are correct and complete.
[ ] Testing: I have added or modified at least one "min-case" configuration file to test this change. Every objective above is represented in at least one cfg.
[ ] Testing: I have considered likely and/or severe edge cases and have included them in testing.

If applicable:

[ ] Testing: this pull request introduces an important feature or bug fix that we must test often. I have updated the weekly-test configuration files, not just a "min-case" one.
[ ] Testing: this pull request adds at least one new possible parameter to the cfg. I have tested using this parameter with and without any other parameter that may interact with it.

2. Are the implementation details accurate & efficient?
Required:

[ ] Logic: I have visually inspected the entire pull request myself.
[ ] Logic: I have left GitHub comments highlighting important pieces of code logic. I have had these code blocks reviewed by at least one other team member.

If applicable:

[ ] Dependencies: This pull request introduces a new dependency. I have discussed this requirement with at least one other team member. The dependency is noted in zppy/conda, not just an import statement.

3. Is this well documented?
Required:

[ ] Documentation: by looking at the docs, a new user could easily understand the functionality introduced by this pull request.

4. Is this code clean?
Required:

[ ] Readability: The code is as simple as possible and well-commented, such that a new team member could understand what's happening.
[ ] Pre-commit checks: All the pre-commits checks have passed.

If applicable:

[ ] Software architecture: I have discussed relevant trade-offs in design decisions with at least one other team member. It is unlikely that this pull request will increase tech debt.

To do:

[ ] (currently running) test just e3sm diags on all available sets: zppy -c tests/integration/generated/test_min_case_e3sm_diags_comprehensive_v3_chrysalis.cfg
[ ] Run the full weekly test suite
[ ] Merge this PR

Currently running full weekly test suite (doing this pre-merge because the CDAT migration was a large change, so there's a higher chance of breaking main).
$ python tests/integration/utils.py
CFG FILES HAVE BEEN GENERATED FROM TEMPLATES WITH THESE SETTINGS:
UNIQUE_ID=test-346-20241210
unified_testing=False
diags_environment_commands=source /gpfs/fs1/home/ac.forsyth2/miniforge3/etc/profile.d/conda.sh; conda activate e3sm_diags_main_20241209
global_time_series_environment_commands=source /gpfs/fs1/home/ac.forsyth2/miniforge3/etc/profile.d/conda.sh; conda activate zi_dev_weekly_20241122
e3sm_to_cmip_environment_commands=
environment_commands=
Reminder: `e3sm_to_cmip_environment_commands=''` => the environment of the `ts` task will be used

zppy -c tests/integration/generated/test_weekly_comprehensive_v3_chrysalis.cfg
zppy -c tests/integration/generated/test_weekly_comprehensive_v2_chrysalis.cfg
zppy -c tests/integration/generated/test_weekly_bundles_chrysalis.cfg # Runs 1st part of bundles cfg

Continuing testing from previous comment
Continuing testing gives:
zppy -c tests/integration/generated/test_weekly_bundles_chrysalis.cfg # Runs 2nd part of bundles cfg

cd /lcrc/group/e3sm/ac.forsyth2/zppy_weekly_comprehensive_v3_output/test-346-20241210/v3.LR.historical_0051/post/scripts/
grep -v "OK" *status

cd /lcrc/group/e3sm/ac.forsyth2/zppy_weekly_comprehensive_v2_output/test-346-20241210/v2.LR.historical_0201/post/scripts
grep -v "OK" *status

cd /lcrc/group/e3sm/ac.forsyth2/zppy_weekly_bundles_output/test-346-20241210/v3.LR.historical_0051/post/scripts
grep -v "OK" *status

# Run integration tests
cd ~/ez/zppy
pytest tests/integration/test_*.py

That gives:
======================================================================= short test summary info ========================================================================
FAILED tests/integration/test_bash_generation.py::test_bash_generation - assert 256 == 0
FAILED tests/integration/test_weekly.py::test_comprehensive_v2_images - AssertionError
FAILED tests/integration/test_weekly.py::test_comprehensive_v3_images - AssertionError
FAILED tests/integration/test_weekly.py::test_bundles_images - AssertionError
============================================================== 4 failed, 10 passed in 1505.03s (0:25:05) ===============================================================

Bash generation test
The FAILED tests/integration/test_bash_generation.py::test_bash_generation - assert 256 == 0 line is benign. The changes are specifically because the e3sm_diags.bash template gets updated in this PR; i.e., these diffs are expected.
Image check failures
There's a large number of image check diffs in subdirectories of:

https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.forsyth2/zppy_weekly_comprehensive_v3_www/test-346-20241210/v3.LR.historical_0051/image_check_failures_comprehensive_v3
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.forsyth2/zppy_weekly_comprehensive_v2_www/test-346-20241210/v2.LR.historical_0201/image_check_failures_comprehensive_v2/
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.forsyth2/zppy_weekly_bundles_www/test-346-20241210/v3.LR.historical_0051/image_check_failures_bundles/

But as far as I can tell, the errors are mostly benign. Example errors:

Many involve actual having "RMSE" and "CORR" further to the left than in expected.
Slight differences in text shape/size -- e.g., actual and expected
Slight differences in contours like actual and expected
Differences in lat/lon labels -- actual and expected

Some errors seem more concerning:

Completely different stats and colors: actual and expected

Conclusions
@chengzhuzhang @tomvothecoder What's the best path forward here? None of the grep -v "OK" *status checks showed errors. That said, there are simply too many diffs in the image check tests to manually check them all. Most of the errors seem benign and likely arise from variations in matplotlib, but I found at least one instance of a more concerning change (noted above).
Do we accept these diffs, merge this PR, and update the expected images? Or do these need to be investigated more thoroughly?

@chengzhuzhang @tomvothecoder What's the best path forward here? None of the grep -v "OK" *status checks showed errors. That said, there are simply too many diffs in the image check tests to manually check them all. Most of the errors seem benign and likely arise from variations in matplotlib, but I found at least one instance of a more concerning change (noted above).
Do we accept these diffs, merge this PR, and update the expected images? Or do these need to be investigated more thoroughly?

I think we should expect that most of the differences will be benign. The underlying results from the dev branch won't exactly match the CDAT codebase, which can produce diffs.

Completely different stats and colors: actual and expected

However, any formatting differences (e.g., labels for axes) or major differences like the one you mentioned above should be investigated. I will open a separate GitHub issue in e3sm_diags to investigate the diffs and address the ones that should be fixed.
Afterwards, we can update the expected results and you can re-run the zppy test again.

Thanks @tomvothecoder!

zppy & post-CDAT-migration e3sm_diags to-do list, for the 1/15 Unified release-candidate deadline:

[ ] Merge https://github.com/E3SM-Project/e3sm_diags/pull/907 (looks like that just needs regression testing now)
[ ] Address the issue of file paths (latest comment on that: https://github.com/E3SM-Project/e3sm_diags/pull/866#issuecomment-2560074539)
[ ] Rebase (address conflicts) & run the Weekly tests
[ ] Merge this PR

@tomvothecoder @chengzhuzhang  ^FYI for timeline planning


Add atomic max/minTufoProp setters.

Also a small change to incTufoProp to stop throwing NoSuchTufo and default to zero. I considered checking the prop def for a defval, but decided to keep it simple for now. Same goes for the copy pasta boilerplate atomic set code.

thoughts on making this behavior enabled via some flag? raising the NoSuchTufo exception can be used during development to indicate there's been a programming error.

I'd be okay with making the defval prop def mandatory for the new behavior and throwing an exception if it is not defined.

thats a cool idea, i like that.

A property being an int "min" or "max" recorder should probably be a function of the type system as well, otherwise the trouble with ingesting outside data sources still exists.  Not that we wouldn't have an API like this one, just that you'd probably want the data model to know intrinsically how to take the min/max val between an inbound property and one that already exists.
This concept ( including min/max times ) has been a long-standing issue when trying to "deconflict" multiple properties originating from multiple sources in nuc.  I'll review this today and possibly implement the rest of the data model awareness. :)

👍