Snapping and scalling and colors

Now you can scale Plot to calculate square roots of better numbers like 42 and 69. And I am snapping x to integer. And just as a toy, you can change colors of grid and markers(i changed color for grid a little bit, because input doesnt support alpha).
And sorry for bad code if there is some, literally first time coding in TS.

@farkon00 personally, I don't find scaling and color customization that useful, sorry. It only clutters the page.
Snapping is something we need, but needs to have finer resolution. Snapping to integers is too restrictive imo.

@farkon00 personally, I don't find scaling and color customization that useful, sorry. It only clutters the page.
Snapping is something we need, but it needs to have finer resolution. Snapping to integers is too restrictive imo.

How much resolution do you want? And what about may be making control of snapping, like somewhere at the bottom of the page may be?


Support for Left Scrolling an Element

Does velocity have support for scrolling an element in the horizontal direction if the content inside is overflowing ?
I have the following fiddle http://jsfiddle.net/65xCP/87/.
$.animate seems to work but $.velocity doesn't.

Read the docs, you need to operate on the element you want to scroll to: http://jsfiddle.net/65xCP/88/


feat: delete items

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

1.0.0
GitHub release

Your semantic-release bot :package::rocket:


Hadoop2

Hi,
First of all thank you for this project, we have used it in production with some modifications.
I have added partitioned write capability, for example date and country fields can be used as partition keys to better divide the data resulting in paths like '/foo/2015_01_01/us'.
I also modified some parts enabling different rotation behavior.
In addition, because of our use cases and our Hadoop version (Hadoop 1.0.3), I have added local write and compression options although it does not align well with messaging guarantees which Storm is providing. User can choose between local and HDFS writes.
I have created 2 branches and Hadoop2 branch can be useful for other people. I will be glad, if you can look into code and give some feedback.
I have put an example in README.md.
Thanks,
İsa

Any chance that this code will be merged into the master any time soon?

Bump, is there any chance of this making it into the main repo? I am interested in the partitioning features to build out my HDFS structure based on information coming in from tuples

@isaolmez If you still want this in storm-hdfs, you should probably make a PR at https://github.com/apache/storm instead. The storm-hdfs code is in /external/storm-hdfs.

@srdo I guess you are right. I will look into that soon. Thanks.


Moving the top bar menu to the bottom of the screen

is it possible to move the top bar menu to the bottom of the screen?

+1


chore(deps): bump https://github.com/gazal-k/jenkins-x-image to --help

Update gazal-k/jenkins-x-image to --help
Command run was jx step create pr chart --name jenkinsxio/jenkinsx --version --help --repo https://github.com/jenkins-x/jenkins-x-platform.git

oops. this was just me trying to update the https://github.com/gazal-k/jenkins-x-image


URL Validation Fix - Works also with absolute URLs incl. port number

Fixes issue when absolute URL is being provided and contains port number.

Thanks!


Print all source errors for alternate format {:#}

Would it be possible to print all the source errors for the alternate format {:#}, like e.g. anyhow::Error and anyhow::Context do?
When logging errors, we want to include the full stack of errors, which means when logging anyhow errors, we use either alternate or debug format, and when using thiserror errors, we use display because we've manually included the source error in the display string. This means the author of each error log statement needs to be aware of this and remember what type of error is being logged. It also leads to the source error of thiserror being logged twice if it is e.g. wrapped in an anyhow::Context.
Thank you, these libraries are very nice.

For your use case would it be possible to convert all errors uniformly to anyhow::Error right before logging them? If you have some error! macro through which the logging happens, have it do anyhow!($err) on the error expression. If it's a function, have it take an Into<anyhow::Error> trait bound.
This sort of rendering is supposed to be done by a central error reporting type, not by individual Display impls of all your errors, or else you tend to get duplication of messages (as you observed).

Ooh, thanks for the error/reporting error distinction. It sounds like we will be able to do the anyhow conversion.


chore(action): update from Node16 to Node20

:rotating_light: Node16 will reach end of life in the Actions runner on the 15th of October 2024 :rotating_light:
Following our change to default customers to use Node20, Node16 will reach end of life in the Actions runner on the 15th of October 2024.
From the 15th of October, we will no longer include Node16 in the Actions runner and customers will no longer be able to use Node16 Actions or operating systems that do not support Node20.
This PR updates the default runtime to node20, rather then node16.
This is supported on all Actions Runners v2.308.0 or later.
Reference: https://github.blog/changelog/2024-09-25-end-of-life-for-actions-node16/

closes #119


Show changes field at the top in compare page

On longer articles you have to scroll all the way down to see the authors description of his changes. It would be easier to review, if this field is displayed at the top.

In Backlog (https://docs.google.com/document/d/1rSkFo2JtsSwHHsbosQcgAN4EzeePXLnqi_eCFpUM3u4/edit#) verschoben


CORS Error on login

When trying to access my openbalena instance I get the following two errors in console:
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://xxxx/connections. (Reason: CORS request did not succeed).
2
Uncaught (in promise) Error: Network Error

Do you have self signed https?

Yes. I'm using the basic open-balena install

You must debug it somehow yourself unfortunately, if you have more problems - contact me on e-mail or via discord Razikus#5125


[RRIO] [Cache] Stub CacheRead transform

This PR addresses #28907 via stubbing the class CacheRead<RequestT, ResponseT> extends PTransform<PCollection<RequestT>, Result<RequestT, ResponseT>>

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

assign set of reviewers


Unable to access child elements [Question]

In my project I have used ListView object as the ItemTemplate. I want to be able to access the ListView, so that I can grammatically control scroll of this ListView, however the LogicalChildren is empty and ChildAdded or ChildRemoved events are not being called either.
I want to be able to do something like CarouselViewControl.CurrentChild.Children[0].ScrollToTop()
Here CurrentChild[0] will be the current ListView being shown.
I want use this feature to allow user to scroll back to the top when user has scrolled down the ListView.
Here is the structure of the CarouselView I am using,
<CarouselViewControl ItemSource="{Binding Something}">
    <CarouselViewControl.ItemTemplate>
        <DataTemplate>
            <Grid>
                <ListView ItemSource="{Binding Collection}">
                </ListView>
            </Grid>
        </DataTemplate>
    </CarouselViewControl.ItemTemplate>
</CarouselViewControl>

@bart-256 hi, try this plugin instead https://github.com/AndreiMisiukevich/CardView

@vikram-ma there's not Children implementation on CarouselView and it is not possible as XF Views are converted to native views before they are added to the platform specific control the CarouselView is build on top.
But, this is possible if you access directly to the ItemsSource:
((ListView)carousel.ItemsSource[0]).ScrollToTop();


Move changes of conf files out of original files

Move changes of conf files out of original files to prevent custom changes going away after a patch/upgrade which defaults the conf-files.
Page: https://github.com/teusink/Home-Security-by-Pi/blob/master/2-Configuration.md

Pages with conf files being edited:
https://github.com/teusink/Home-Security-by-Pi/blob/master/2-Configuration.md
https://github.com/teusink/Home-Security-by-Pi/blob/master/3-Hardening.md
https://github.com/teusink/Home-Security-by-Pi/blob/master/4-Maintenance.md

Changed this:

For better privacy, add the line below to prevent DNS-look-ups going upstream with: sudo nano /etc/dnsmasq.d/01-pihole.conf.
For better privacy, add the line below to prevent DNS-look-ups going upstream with: sudo nano /etc/dnsmasq.d/02-lan.conf.


Improve or look into a better testing solution for functions that use the GitHub or GitLab REST API's

Right now they set up a mock http server to handle those requests however it isn't very flexible and doesn't account for edge cases since the tests are either it works or it doesn't.  An example of that is here

#194


VS crashes when python interpreter version is not in PythonLanguageVersion enum

This came from a watson crash.
An InvalidOperationException is thrown when comparing the version of a python interpreter on disk to an enum of all the python versions we support. The reported version of "4.5.5" is definitely not in the enum, so we get:

Python\Product\Common\Parsing\PythonLanguageVersion.cs -> throws InvalidOperationException
Python\Product\VSInterpreters\Interpreter\AstPythonInterpreterFactory.cs -> catches the above exception and throws an ArgumentException, which is unhandled and crashes VS

A more graceful way to fix this would be:
If ToLanguageVersion() throws an exception:

Replace the ArgumentException with a Debug.Assert so we still see the problem when debugging
Set LanguageVersion to LanguageVersion.None, and handle that case from the caller.

For example, in the code that is enumerating all the environments to display them, just ignore the ones where version = PythonVersion.None, because those are bad.
Maybe print something to the VS output window so the user understands why their environment is missing?

To repro this, I installed python 3.11 beta from python .org. Then I commented out V311 from the PythonLanguageVersion enum and verified that ToLanguageVersion() returned PythonLanguageVersion.None, which is what we would expect if the version is not supported. This breakpoint gets hit when the installed environments are being enumerated (which is used to populate the environments window).
Then I added python 3.11 as an existing environment and activated it. I saw the environment in the project just fine. I got a warning in the debugger output about breakpoints might not hit, but they did. Profiling didn't work, but the error is "graceful"

So I think this fix is viable. VS no longer crashes, I'm able to add 3.11 as an existing environment, as well as a virtual environment and debug with both.
I still don't know why the version was being reported as 4.5.5 in the watson crash, but I believe our code can handle this edge case now.


Failed to execute lua script during install on 2.4.5_p1

Apologies if this was mentioned or addressed before.
On 2.4.5-RELEASE-p1 (amd64) built on Tue Jun 02 17:51:17 EDT 2020 FreeBSD 11.3-STABLE
Install goes on OK, however, the following message appears a few times:
Failed to execute lua script: [string "args = {}..."]:11: attempt to call a nil value (field 'stat')
Here is the output up to UniFi.unix.zip extraction and install.
<EMAIL_ADDRESS>fetch -o - https://git.io/j7Jy | sh -s
-                                                     7573  B  116 MBps    00s
sh: mongod: not found
Adding fdesc filesystem to /etc/fstab... done.
Adding procfs filesystem to /etc/fstab... done.
Mounting new filesystems... done.
Removing packages discontinued...
 done.
Installing required packages...
packagesite.txz                                       5986 kB 8478 kBps    00s
x packagesite.yaml.sig
x packagesite.yaml.pub
x packagesite.yaml
Fetching png-1.6.37.txz: 100%  288 KiB 295.1kB/s    00:01
Installing png-1.6.37...
Extracting png-1.6.37: 100%
Fetching freetype2-2.10.4.txz: 100%    1 MiB   1.4MB/s    00:01
Installing freetype2-2.10.4...
Extracting freetype2-2.10.4: 100%
=====
Message from freetype2-2.10.4:

--
The 2.7.x series now uses the new subpixel hinting mode (V40 port's option) as
the default, emulating a modern version of ClearType. This change inevitably
leads to different rendering results, and you might change port's options to
adapt it to your taste (or use the new "FREETYPE_PROPERTIES" environment
variable).

The environment variable "FREETYPE_PROPERTIES" can be used to control the
driver properties. Example:

FREETYPE_PROPERTIES=truetype:interpreter-version=35 \
	cff:no-stem-darkening=1 \
	autofitter:warping=1

This allows to select, say, the subpixel hinting mode at runtime for a given
application.

If LONG_PCF_NAMES port's option was enabled, the PCF family names may include
the foundry and information whether they contain wide characters. For example,
"Sony Fixed" or "Misc Fixed Wide", instead of "Fixed". This can be disabled at
run time with using pcf:no-long-family-names property, if needed. Example:

FREETYPE_PROPERTIES=pcf:no-long-family-names=1

How to recreate fontconfig cache with using such environment variable,
if needed:
# env FREETYPE_PROPERTIES=pcf:no-long-family-names=1 fc-cache -fsv

The controllable properties are listed in the section "Controlling FreeType
Modules" in the reference's table of contents
(/usr/local/share/doc/freetype2/reference/site/index.html, if documentation was installed).
Fetching fontconfig-2.13.92_2,1.txz: 100%  383 KiB 391.7kB/s    00:01
Installing fontconfig-2.13.92_2,1...
Extracting fontconfig-2.13.92_2,1: 100%
Running fc-cache to build fontconfig cache...

Extracting alsa-lib-1.1.2_2: 100%
pkg: Failed to execute lua script: [string "args = {}..."]:11: attempt to call a nil value (field 'stat')
pkg: lua script failed
=====
Message from alsa-lib-1.1.2_2:

--
===>   NOTICE:

The alsa-lib port currently does not have a maintainer. As a result, it is
more likely to have unresolved issues, not be up-to-date, or even be removed in
the future. To volunteer to maintain this port, please create an issue at:

https://bugs.freebsd.org/bugzilla

More information about port maintainership is available at:

https://www.freebsd.org/doc/en/articles/contributing/ports-contributing.html#maintain-port
Fetching python37-3.7.9_1.txz: 100%   16 MiB  16.8MB/s    00:01
Installing python37-3.7.9_1...
package python37 is already installed, forced install
Extracting python37-3.7.9_1: 100%
=====
Message from python37-3.7.9_1:

--
Note that some standard Python modules are provided as separate ports
as they require additional dependencies. They are available as:

py37-gdbm       databases/py-gdbm@py37
py37-sqlite3    databases/py-sqlite3@py37
py37-tkinter    x11-toolkits/py-tkinter@py37
Fetching libfontenc-1.1.4.txz: 100%   20 KiB  20.7kB/s    00:01
Installing libfontenc-1.1.4...
Extracting libfontenc-1.1.4: 100%
Fetching mkfontscale-1.2.1.txz: 100%   21 KiB  21.2kB/s    00:01
Installing mkfontscale-1.2.1...
Extracting mkfontscale-1.2.1: 100%
Fetching dejavu-2.37_1.txz: 100%    2 MiB   2.5MB/s    00:01
Installing dejavu-2.37_1...
Extracting dejavu-2.37_1: 100%
=====
Message from dejavu-2.37_1:

--
Make sure that the freetype module is loaded.  If it is not, add the following
line to the "Modules" section of your X Windows configuration file:

	Load "freetype"

Add the following line to the "Files" section of X Windows configuration file:

	FontPath "/usr/local/share/fonts/dejavu/"

Note: your X Windows configuration file is typically /etc/X11/XF86Config
if you are using XFree86, and /etc/X11/xorg.conf if you are using X.Org.
Fetching giflib-5.2.1.txz: 100%  233 KiB 238.3kB/s    00:01
Installing giflib-5.2.1...
Extracting giflib-5.2.1: 100%
Fetching xorgproto-2020.1.txz: 100%  217 KiB 222.5kB/s    00:01
Installing xorgproto-2020.1...
Extracting xorgproto-2020.1: 100%
Fetching libXdmcp-1.1.3.txz: 100%   14 KiB  14.6kB/s    00:01
Installing libXdmcp-1.1.3...
Extracting libXdmcp-1.1.3: 100%
Fetching libpthread-stubs-0.4.txz: 100%    2 KiB   2.0kB/s    00:01
Installing libpthread-stubs-0.4...
Extracting libpthread-stubs-0.4: 100%
Fetching libXau-1.0.9.txz: 100%   11 KiB  11.5kB/s    00:01
Installing libXau-1.0.9...
Extracting libXau-1.0.9: 100%
Fetching libxcb-1.14_1.txz: 100%    1 MiB   1.1MB/s    00:01
Installing libxcb-1.14_1...
Extracting libxcb-1.14_1: 100%
Fetching libICE-1.0.10,1.txz: 100%   93 KiB  94.8kB/s    00:01
Installing libICE-1.0.10,1...
Extracting libICE-1.0.10,1: 100%
Fetching libSM-1.2.3,1.txz: 100%   23 KiB  23.9kB/s    00:01
Installing libSM-1.2.3,1...
Extracting libSM-1.2.3,1: 100%
Fetching libX11-1.6.12,1.txz: 100%    2 MiB   1.7MB/s    00:01
Installing libX11-1.6.12,1...
Extracting libX11-1.6.12,1: 100%
Fetching libXfixes-5.0.3_2.txz: 100%   15 KiB  15.4kB/s    00:01
Installing libXfixes-5.0.3_2...
Extracting libXfixes-5.0.3_2: 100%
Fetching libXext-1.3.4,1.txz: 100%   95 KiB  97.6kB/s    00:01
Installing libXext-1.3.4,1...
Extracting libXext-1.3.4,1: 100%
Fetching libXi-1.7.10,1.txz: 100%  122 KiB 124.8kB/s    00:01
Installing libXi-1.7.10,1...
Extracting libXi-1.7.10,1: 100%
Fetching libXt-1.2.0,1.txz: 100%  449 KiB 460.2kB/s    00:01
Installing libXt-1.2.0,1...
Extracting libXt-1.2.0,1: 100%
Fetching libXtst-1.2.3_2.txz: 100%   20 KiB  20.4kB/s    00:01
Installing libXtst-1.2.3_2...
Extracting libXtst-1.2.3_2: 100%
Fetching libXrender-0.9.10_2.txz: 100%   30 KiB  30.3kB/s    00:01
Installing libXrender-0.9.10_2...
Extracting libXrender-0.9.10_2: 100%
Fetching libinotify-20180201_2.txz: 100%   26 KiB  26.5kB/s    00:01
Installing libinotify-20180201_2...
Extracting libinotify-20180201_2: 100%
=====
Message from libinotify-20180201_2:

--
Libinotify functionality on FreeBSD is missing support for

  - detecting a file being moved into or out of a directory within the
    same filesystem
  - certain modifications to a symbolic link (rather than the
    file it points to.)

in addition to the known limitations on all platforms using kqueue(2)
where various open and close notifications are unimplemented.

This means the following regression tests will fail:

Directory notifications:
   IN_MOVED_FROM
   IN_MOVED_TO

Open/close notifications:
   IN_OPEN
   IN_CLOSE_NOWRITE
   IN_CLOSE_WRITE

Symbolic Link notifications:
   IN_DONT_FOLLOW
   IN_ATTRIB
   IN_MOVE_SELF
   IN_DELETE_SELF

Kernel patches to address the missing directory and symbolic link
notifications are available from:

https://github.com/libinotify-kqueue/libinotify-kqueue/tree/master/patches

You might want to consider increasing the kern.maxfiles tunable if you plan
to use this library for applications that need to monitor activity of a lot
of files.
Fetching javavmwrapper-2.7.6.txz: 100%   17 KiB  17.1kB/s    00:01
Installing javavmwrapper-2.7.6...
Extracting javavmwrapper-2.7.6: 100%
pkg: Failed to execute lua script: [string "args = {}..."]:11: attempt to call a nil value (field 'stat')
pkg: lua script failed
Fetching java-zoneinfo-2020.d.txz: 100%   72 KiB  73.9kB/s    00:01
Installing java-zoneinfo-2020.d...
Extracting java-zoneinfo-2020.d: 100%
Fetching openjdk8-8.275.01.1.txz: 100%   81 MiB  28.2MB/s    00:03
Installing openjdk8-8.275.01.1...
Extracting openjdk8-8.275.01.1: 100%
=====
Message from openjdk8-8.275.01.1:

--
This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and
procfs(5) mounted on /proc.

If you have not done it yet, please do the following:

	mount -t fdescfs fdesc /dev/fd
	mount -t procfs proc /proc

To make it permanent, you need the following lines in /etc/fstab:

	fdesc	/dev/fd		fdescfs		rw	0	0
	proc	/proc		procfs		rw	0	0
Updating database digests format: 100%
No packages matched for pattern 'snappyjava'

Checking integrity... done (0 conflicting)
1 packages requested for removal: 0 locked, 1 missing
Fetching snappyjava-<IP_ADDRESS>.txz: 100%    2 MiB   1.9MB/s    00:01
Installing snappyjava-<IP_ADDRESS>...
Extracting snappyjava-<IP_ADDRESS>: 100%
Fetching snappy-1.1.8.txz: 100%   22 KiB  22.8kB/s    00:01
Installing snappy-1.1.8...
Extracting snappy-1.1.8: 100%
Fetching cyrus-sasl-2.1.27_1.txz: 100%  963 KiB 986.5kB/s    00:01
Installing cyrus-sasl-2.1.27_1...
*** Added group `cyrus' (id 60)
*** Added user `cyrus' (id 60)
Extracting cyrus-sasl-2.1.27_1: 100%
=====
Message from cyrus-sasl-2.1.27_1:

--
You can use sasldb2 for authentication, to add users use:

	saslpasswd2 -c username

If you want to enable SMTP AUTH with the system Sendmail, read
Sendmail.README

NOTE: This port has been compiled with a default pwcheck_method of
      auxprop.  If you want to authenticate your user by /etc/passwd,
      PAM or LDAP, install ports/security/cyrus-sasl2-saslauthd and
      set sasl_pwcheck_method to saslauthd after installing the
      Cyrus-IMAPd 2.X port.  You should also check the
      /usr/local/lib/sasl2/*.conf files for the correct
      pwcheck_method.
      If you want to use GSSAPI mechanism, install
      ports/security/cyrus-sasl2-gssapi.
      If you want to use SRP mechanism, install
      ports/security/cyrus-sasl2-srp.
      If you want to use LDAP auxprop plugin, install
      ports/security/cyrus-sasl2-ldapdb.
Fetching icu-68.2,1.txz: 100%   10 MiB  10.8MB/s    00:01
Installing icu-68.2,1...
package icu is already installed, forced install
Extracting icu-68.2,1: 100%
Fetching boost-libs-1.72.0_3.txz: 100%   13 MiB  13.1MB/s    00:01
Installing boost-libs-1.72.0_3...
Extracting boost-libs-1.72.0_3: 100%
=====
Message from boost-libs-1.72.0_3:

--
You have built the Boost library with thread support.

Don't forget to add -pthread to your linker options when
linking your code.
Fetching mongodb36-3.6.21.txz: 100%   37 MiB  19.5MB/s    00:02
Installing mongodb36-3.6.21...
===> Creating groups.
Creating group 'mongodb' with gid '922'.
===> Creating users
Creating user 'mongodb' with uid '922'.
===> Creating homedir(s)
Extracting mongodb36-3.6.21: 100%
pkg: Failed to execute lua script: [string "args = {}..."]:11: attempt to call a nil value (field 'stat')
pkg: lua script failed
Fetching unzip-6.0_8.txz: 100%  135 KiB 138.2kB/s    00:01
Installing unzip-6.0_8...
Extracting unzip-6.0_8: 100%
Fetching pcre-8.44.txz: 100%    1 MiB   1.3MB/s    00:01
Installing pcre-8.44...
package pcre is already installed, forced install
Extracting pcre-8.44: 100%
 done.
UniFi.unix.zip                                         130 MB 7023 kBps    19s
 done.
Installing UniFi controller in /usr/local...Archive:  UniFi.unix.zip

Was this on a fresh install? If I recall correctly, on a fresh install with no mongodb database, you are likely to get that error, but it should not effect the controller installing or running. I added a mongodb database repair to all installs, as sometimes mongodb likes to corrupt itself. Is your controller up and running?

Was this on a fresh install? If I recall correctly, on a fresh install with no mongodb database, you are likely to get that error, but it should not effect the controller installing or running. I added a mongodb database repair to all installs, as sometimes mongodb likes to corrupt itself. Is your controller up and running?

That's right, it is on a fresh install and the controller is up and running just fine. However, it's not just mongodb. The message appears for some pkgs (alsa, jvmwrapper etc.) as well. So, it seemed right to raise it as an issue.
Thank you.

That's right, it is on a fresh install and the controller is up and running just fine. However, it's not just mongodb. The message appears for some pkgs (alsa, jvmwrapper etc.) as well. So, it seemed right to raise it as an issue.
Thank you.

That's right, it is on a fresh install and the controller is up and running just fine. However, it's not just mongodb. The message appears for some pkgs (alsa, jvmwrapper etc.) as well. So, it seemed right to raise it as an issue.
Thank you.

Tell you what, let me review a change to the PKG script. Since this does not cause the script to fail, the fix for the error message may come later.

That's right, it is on a fresh install and the controller is up and running just fine. However, it's not just mongodb. The message appears for some pkgs (alsa, jvmwrapper etc.) as well. So, it seemed right to raise it as an issue.
Thank you.

Tell you what, let me review a change to the PKG script. Since this does not cause the script to fail, the fix for the error message may come later.

@bkaskar is there anything specific about your installation, like maybe file system? I cannot replicate this issue on any of my virtual machines. I want to try to see what might be causing this issue, but I am afraid I cannot replicate it. @tong2x did you have this issue at all?

@bkaskar is there anything specific about your installation, like maybe file system? I cannot replicate this issue on any of my virtual machines. I want to try to see what might be causing this issue, but I am afraid I cannot replicate it. @tong2x did you have this issue at all?

Stale issue closing for now.

@gnkidwell very sorry for not responding on time. I was absent for a very long time due to personal reasons.


Private message not working

Feature: Private Messaging
Priority: Medium
Scenario: Sending a private message does not work
Given: A user is logged in as "UserA"
When: The user attempts to send a private message to "UserB"
Then: The system should successfully send the message
And: "UserB" should receive the message
Actual: The private message feature is currently not functioning as intended
Impact: Failure to send messages may lead to user frustration and reduced engagement with the app.

Made changes in app/models.py by updating the class Message and User. Imported a model that was missing. Issue resolved


Move ReleaseCard to a component

Support for release groups with same name as alt and best.

before/after pics? like what's the goal?

Allows for the same group to be alt and best


Update README.rst and .travis.yml with supported versions and related

https://app.travis-ci.com/github/jiridanek/cli-proton-python/builds/262347712


Work with lua have strange display.

Why there is /^local  /^function and $/

懒得去掉，直接把pattern显示出来了:)

BTW, 你的luacheck插件，很赞


Product Variations

We're running into some cases where we have multiple variations of a product (ie, Physical Book vs Ebook).
Right now Netlify Commerce assumes that a product has a detail page with a script tag like this:
<script id="netlify-commerce-product" type="application/json">
{"title": "A Book", "prices":[{"amount":"39.00","currency":"USD"}], "sku":"my-book", "type":"Book"}
</script>

We should start optionally supporting multiple product variations on the same detail page. This would look like:
<script class="netlify-commerce-product" type="application/json">
{"title": "A Book", "prices":[{"amount":"39.00","currency":"USD"}], "sku":"my-book-physical", "type":"Book"}
</script>

<script class="netlify-commerce-product" type="application/json">
{"title": "A Book", "prices":[{"amount":"15.00","currency":"USD"}], "sku":"my-book-ebook", "type":"Ebook"}
</script>

For each line item, Netlify Commerce should look for all instances of ".netlify-commerce-product". If there's only 1 product definition, use that one, if there's more than one, require a "sku" in the order params for the line item to identify the right variation.

@biilmann But "Physical Book" is actually a different product than an "Ebook", right? A variation would be a "Physical book", with let's say a different cover color.
What about something like?

Inspiration:
https://help.shopify.com/api/reference/product
https://help.shopify.com/api/reference/product_variant

@biilmann I think this code already achieves that, can you confirm? https://github.com/netlify/gocommerce/blob/48bcceae4483f7557080478da04232bf47dde695/api/order.go#L754-L764


.Net: [ConversationSummaryPlugin][OpenAI] Track Your Token Usage and Costs using OpenAI in ConversationSummaryPlugin

Discussed in https://github.com/microsoft/semantic-kernel/discussions/4921

Originally posted by maivanchuong95 February  8, 2024
Hi everyone,
I have used OpenAI to create Summarization, Actions, and Topics of a paragraph I entered using Semantic Kenel, but currently, I do not know how to calculate the usage cost and how to count the number of tokens for each use. I hope everyone can help me find a solution. Below is my code in .NET, thanks.
My code in base: https://github.com/microsoft/semantic-kernel/blob/main/dotnet/samples/KernelSyntaxExamples/Example13_ConversationSummaryPlugin.cs
My code: `public async Task SummaryPlugin(string context)
{
Console.WriteLine($"Receive user summary plugin request");
Kernel kernel = InitializeKernel();

KernelPlugin conversationSummaryPlugin = kernel.ImportPluginFromType<ConversationSummaryPlugin>();

FunctionResult summary = await kernel.InvokeAsync(
    conversationSummaryPlugin["SummarizeConversation"], new() { ["input"] = context });
var responseMessage = summary.GetValue<string>();

Console.WriteLine($"Response system message: {responseMessage}");

return responseMessage?? String.Empty;

}
public async Task ActionPlugin(string context)
{
Console.WriteLine($"Receive user action plugin request");
Kernel kernel = InitializeKernel();

KernelPlugin conversationSummary = kernel.ImportPluginFromType<ConversationSummaryPlugin>();

FunctionResult summary = await kernel.InvokeAsync(
    conversationSummary["GetConversationActionItems"], new() { ["input"] = context });
var responseMessage = summary.GetValue<string>();

Console.WriteLine($"Response system message: {responseMessage}");

return responseMessage?? String.Empty;

}
public async Task TopicPlugin(string context)
{
Console.WriteLine($"Receive user toplic plugin request");
Kernel kernel = InitializeKernel();

KernelPlugin conversationSummary = kernel.ImportPluginFromType<ConversationSummaryPlugin>();

FunctionResult summary = await kernel.InvokeAsync(
    conversationSummary["GetConversationTopics"], new() { ["input"] = context });
var responseMessage = summary.GetValue<string>();

Console.WriteLine($"Response system message: {responseMessage}");

return responseMessage;

}`

I do not know how to calculate the usage cost and how to count the number of tokens for each use.

@maivanchuong95 Since you are using OpenAI connector to invoke your functions, you should be able to get token information from result metadata:
https://github.com/microsoft/semantic-kernel/blob/2138724dcfcde5bbdaeb7be583699b711b737197/dotnet/samples/KernelSyntaxExamples/Example43_GetModelResult.cs#L30-L34
Please let me know if this solution will cover your case, thanks!

@maivanchuong95 I'm going to close this issue. Please let me know in case of any further questions.


Add Flags SPI

Motivation:
As described in https://github.com/line/armeria/issues/4093,
We'd like to provide a way to programmatically configure Flags via SPI.
Modifications:

Add new interface FlagsProvider SPI interface to let user specify flags programmatically with priority.
Move default values from Flags to a new class DefaultFlagsProvider which have the lowest priority.
Move JVM option values provider logic from Flags to a new class SystemPropertyFlagsProvider which have the highest priority.
Redesign Flags logic to get flags values in below order.

SystemPropertyFlagsProvider -> [sorted by priority] Custom1FlagsProvider -> Custom2FlagsProvider ... -> DefaultFlagsProvider
if (JVM is provided && It pass on validation) {
    -> use supplied JVM option
}
-> use default value

to
foreach (SystemPropertyFlagsProvider + SPI interface Providers) {
  if (flag is provided && It passes on validation) {
      -> use the value
}
-> use default value from DefaultFlagsProvider

Result:

Closes #4093
You can now supply Flags value using FlagsProvider.

public final class CustomFlagsProvider implements FlagsProvider {

    @Override
    public int priority() {
        return 100;
    }

    @Override
    public int numCommonBlockingTaskThreads() {
        return 100;
    }
    ...
}

What if we have a priority field in FlagsProvider

+1 I love the suggestion. To be honest, I had thought of a similar idea. 😄

I like the suggestion. I'll implement as suggested. Thanks 🙏

@klurpicolo Would you mind checking out the build failures? If you find it difficult to resolve, feel free to ask us.

@jrhee17 Thanks! I'll address lint issue and @ikhoon 's comment.
@ikhoon No, I'll try to fix it. If I can't I'll comeback for help. Thank you for offering. 🙏

Sorry for the conflict. We added a new boolean flag called reportMaskedRoutes in #4086.

Thanks a lot for quick follow-up! Did a little bit more clean-up. I'll merge this in as soon as build passes.

Thanks all reviewers 🙏


home-assistant: 2021.6.5 -> 2021.6.6

Motivation for this change
https://github.com/home-assistant/core/releases/tag/2021.6.6
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 127738 at 12e016b5 run on aarch64-linux 1

1 package failed to build:

home-assistant

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 127738 run on x86_64-linux 1

1 package built:

home-assistant


Sub_menu on devices not working

Hello,
I have a sub_menu in my navigation that works fine on my computer. But on my mobile device, when i click the sub menu (e.x Home->Users-> edit/new etc) it show it for few milliseconds  and then disappears.
thanks you.

@john871 - did you manage to fix this?

I Closed my ticket because i saw there already 2 open for the exact bug.

https://github.com/puikinsh/gentelella/issues/490


Blank new 0.49.1 project have two flow errors "Error suppressing comment. Unused suppression"

Is this a bug report?
Yes !
Have you read the Contributing Guidelines?
Yes !
Environment
Environment:
  OS:  macOS Sierra 10.12.6
  Node:  8.0.0
  Yarn:  1.0.0
  npm:  4.6.1
  Watchman:  4.7.0
  Flow: 0.53.1
  Xcode:  Xcode 8.0 Build version 8E2002
  Android Studio:  2.3 AI-162.4069837

Packages: (wanted => installed)
  react: 16.0.0-beta.5 => 16.0.0-beta.5
  react-native: ^0.49.1 => 0.49.1

Steps to Reproduce

Create a new project
Run Flow
Boom. 2 errors !

Flow errors (click on spolier to open)
➜  test cd repro
➜  repro flow
Launching Flow server for /Users/tychotatitscheff/Code/test/repro
Spawned flow server (pid=84230)
Logs will go to /private/tmp/flow/zSUserszStychotatitscheffzSCodezStestzSrepro.log
Error: node_modules/react-native/Libraries/Lists/ListView/ListViewDataSource.js:21
       v----------------------------------------------------------------------------
 21:   /* $FlowFixMe(>=0.53.0 site=react_native_fb) This comment suppresses an error
 22:    * found when Flow v0.53 was deployed. To see the error delete this comment
 23:    * and run Flow. */
        -----------------^ Error suppressing comment. Unused suppression

Error: node_modules/react-native/Libraries/Lists/ListView/ListViewDataSource.js:25
       v----------------------------------------------------------------------------
 25:   /* $FlowFixMe(>=0.53.0 site=react_native_fb) This comment suppresses an error
 26:    * found when Flow v0.53 was deployed. To see the error delete this comment
 27:    * and run Flow. */
        -----------------^ Error suppressing comment. Unused suppression

Found 2 errors

Expected Behavior
React Native blank project are Flowtype error free
Actual Behavior
2 flow errors
➜  test cd repro
➜  repro flow
Launching Flow server for /Users/tychotatitscheff/Code/test/repro
Spawned flow server (pid=84230)
Logs will go to /private/tmp/flow/zSUserszStychotatitscheffzSCodezStestzSrepro.log
Error: node_modules/react-native/Libraries/Lists/ListView/ListViewDataSource.js:21
       v----------------------------------------------------------------------------
 21:   /* $FlowFixMe(>=0.53.0 site=react_native_fb) This comment suppresses an error
 22:    * found when Flow v0.53 was deployed. To see the error delete this comment
 23:    * and run Flow. */
        -----------------^ Error suppressing comment. Unused suppression

Error: node_modules/react-native/Libraries/Lists/ListView/ListViewDataSource.js:25
       v----------------------------------------------------------------------------
 25:   /* $FlowFixMe(>=0.53.0 site=react_native_fb) This comment suppresses an error
 26:    * found when Flow v0.53 was deployed. To see the error delete this comment
 27:    * and run Flow. */
        -----------------^ Error suppressing comment. Unused suppression

Found 2 errors

Reproducible Demo
Any new project are reproduction.
So:
react-native init repro
cd repro
flow

reproduces the problem
How to fix

Cherry-pick 11963d824d42cf94caed7212e55e0452e5a537ea to 0.49 branch
Release 0.49.2

Closing in favour of #16225


Feature: Discord Webhook Alert Handler

Required for all non-trivial PRs

[x] Rebased/mergable
[x] Tests pass
[x] CHANGELOG.md updated
[x] Sign CLA (if not already signed)

Added a Discord Channel Webhook alert handler.
TODO

[x] Add service/discord/discordtest
[x] Write documentation and contribute to https://github.com/influxdata/docs.influxdata.com
[x] Comment code in pipeline/alert.go

Screenshot of test notification in Discord client

Ha, sorry, thought I'd caught all of those, pushing now!

I'm also happy to add the required stuff to Chronograf, I'd just need a pointer to what needs updating!

@mattnotmitt is this ready for another review?

@desa very nearly, there's an issue I'm experiencing with the timestamp boolean - I posted about it in the kapacitor channel in the influxdata community slack.

@mattnotmitt can you link me to the issue?

I've pinged you in the thread but here's the text:
I've been having some trouble with using a boolean in the HandlerConfig for
a custom alert handler. If you look at my pr
https://github.com/influxdata/kapacitor/pull/2287/files, the Timestamp is a
boolean field configurable in both in the kapacitor.conf file and when
the handler is called inline. Oddly, the value in the kapacitor.conf file
is ignored always, and the only way i can decide whether the timestamp
shows or not is if it is set in the tickscript. Could someone with
knowledge of the arcane internals of the kapacitor config loading give me a
hand? I'm sure i could figure it out myself but I'd appreciate some
guidance.
On Fri, 27 Mar 2020, 16:37 Michael Desa<EMAIL_ADDRESS>wrote:

@mattnotmitt https://github.com/mattnotmitt can you link me to the
issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/influxdata/kapacitor/pull/2287#issuecomment-605099518,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQBM7RHIKQNPAKULAIH3RDRJTI4BANCNFSM4KSLJKJQ
.

@desa Ready for review whenever you're available.

@mattnotmitt were you able to take a look at my suggestion in slack?

Yeah I looked and replied. There's no discernable difference between it
being set to false and it just not being set. Decided to just take away the
handler config and keep it in the conf file.
On Mon, 30 Mar 2020, 16:23 Michael Desa<EMAIL_ADDRESS>wrote:

@mattnotmitt https://github.com/mattnotmitt were you able to take a
look at my suggestion in slack?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/influxdata/kapacitor/pull/2287#issuecomment-606066639,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQBM7TSSUUBBD2GI4UTL6TRKC2QPANCNFSM4KSLJKJQ
.

Typically people use pointers to differentiate between the two. I think that should work.

I don't really know how to implement that (my go skills aren't that great)
and the timestamp is so tiny that I find it unlikely that someone would
need to hide it. If you need this to merge I might be able to do it in a
few months but I need to knuckle down on some other work now, sorry.
On Mon, 30 Mar 2020, 17:11 Michael Desa<EMAIL_ADDRESS>wrote:

Typically people use pointers to differentiate between the two. I think
that should work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/influxdata/kapacitor/pull/2287#issuecomment-606094210,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQBM7RFCJWK6ME3CDIPCSLRKDACDANCNFSM4KSLJKJQ
.

@mattnotmitt just reaching out with regards to

I'm also happy to add the required stuff to Chronograf, I'd just need a pointer to what needs updating!

Is this something that you'd still be interested in doing? I'd be happy to offer an outline of the steps involved.

@mattnotmitt just reaching out with regards to

...
Is this something that you'd still be interested in doing? I'd be happy to offer an outline of the steps involved.

Hi @desa, yeah I'd still be happy to work on that!

@mattnotmitt Awesome. For 2.0 of InfluxDB, you're going to want to take a look at the code in https://github.com/influxdata/flux/blob/8a6ee0356c0837db0ace34cb7a2578be600874d3/stdlib/pagerduty/pagerduty.flux, https://github.com/influxdata/influxdb/tree/master/notification/endpoint, and  https://github.com/influxdata/influxdb/tree/master/notification/rule. This part of the 2.0 codebase is a bit rough with a fair amount of repeated logic.
For 1.x Chronograf, you'll want to start looking in https://github.com/influxdata/chronograf/blob/2dadcaf8dcb6a6733e027e1d9205f3688b81b62d/ui/src/types/kapacitor.ts and https://github.com/influxdata/chronograf/blob/9d8a49ba0ef8131cdce22d73718859f55f434db2/ui/src/kapacitor/components/handlers/index.js.


Install libc6-compat on Alpine variant

Logstash's file input performs some stat operations that require
libcrypt.so.1 to be installed.
Fix docker-library/logstash#81

Does this only affect version 5?  If it doesn't hurt the other versions we should just drop it in the Dockerfile-alpine.template so that it can get applied to all of them with update.sh (otherwise this will get reset once update.sh is run by the bot).

@yosifkit I wasn't aware of the bot workflow, thanks for pointing it out.
Branch updated with a change to the template - it sure won't hurt to have libc6-compat installed on all versions as it only includes compat symlinks .


Fixing compile error on Unreal 5.1 Preview

@tustanivsky FYI

The issues mentioned above were addressed in #150, closing it now


[stable/vsphere-cpi] Fix failing installation when mapping values are specified

Is this a new chart
NO
What this PR does / why we need it:
Fixes a bug that causes an installation error
Which issue this PR fixes
When the Helm chart is deployed while specifying mapping values such as daemonset.tolerations or daemonset.annotations the installation fails with errors like this:

Error: YAML parse error on keepalived-ingress-vip/templates/deployment.yaml: error converting YAML to JSON: yaml: line 42: mapping values are not allowed in this context

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test

/approve
/lgtm


MM-2998 Add telemetry for product notices

Summary

Add  track event when user clicks on action button of notice

Ticket Link
https://mattermost.atlassian.net/browse/MM-29998
Related Pull Requests
https://github.com/mattermost/mattermost-redux/pull/1277

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
   dc6d2d127..3fa214d6c  MM-28843-feature-flag-system-console -> upstream/MM-28843-feature-flag-system-console
   844bbb964..6333dcaa8  master       -> upstream/master
   382d108b5..99e70ba4c  release-5.29 -> upstream/release-5.29
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-webapp-#6934-upstream-release-5.29-1603899593
Switched to a new branch 'automated-cherry-pick-of-mattermost-webapp-#6934-upstream-release-5.29-1603899593'
Branch 'automated-cherry-pick-of-mattermost-webapp-#6934-upstream-release-5.29-1603899593' set up to track remote branch 'release-5.29' from 'upstream'.

+++ About to attempt cherry pick of PR #6934 with merge commit 6333dcaa8eddd92d9fee0942f17dad359841761c.

error: could not apply 6333dcaa8... MM-2998 Add telemetry for product notices (#6934)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

+++ Conflicts detected:

UU package-lock.json
UU package.json
Aborting.

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.

@esethna @sudheerDev I added the "Docs/Needed" label as I wasn't sure if this needs docs for https://docs.mattermost.com/administration/telemetry.html. Please take a look.

@sudheerDev can you help submit a PR as needed?

@sudheerDev can you help submit a PR as needed?

@amyblais @esethna Will do


Python: Uses Python standard logging

Motivation and Context
This replaces passing Logger instances as arguments around with the preferred Python way of having each module define a module-wide logger instance at the top of the module. Fixes #3711
Description
Removes any log argument and argument documentation. Replaces usage of those log arguments with the module-wide logger instance.
Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

Thank you for your work on this, @juliomenendez. Let me know if you need any support with this.

Thank you @moonbox3! If you could help review the PR that would be a great help. Sorry is a rather big one :)
@eavanvalkenburg I made those changes, feel free to review it again.
Thanks!

Added one note on the null logger and I didn't see a util that sets the logger format and level once that I mentioned in my previous review!

Yes, missed that. Just added it on my last commit with a very simple sample. Let me know if you think it should have something else @eavanvalkenburg


Fixed tests in test_benchmark_global.py

*Added more data points for test_benchmark_CV_global_modeling()
*Created a date intersection between df1 and df2 in test_benchmark_manualCV_global_modeling()

for all tests:

increase nrows or remove unnecessary df3
set nrows manually where needed for setup consistency
rename cont


Mapper: Initial mappings (FASTQ -> BAM)

In the Mapper module, support taking FASTQ input and converting to BAM output.
@chris-owen, @dauss75, this is one of the issues we discussed.

Segun and I produced this pipe using BWA mem and Samtools to produce a bam file that is sorted with duplicates removed.
bwa mem <reference_genome_fasta> <left_reads.fastq> <right_reads.fastq> | samtools view -Shu - | samtools sort - - | samtools rmdup -S - <PE_Mapped_DupRm.bam>

snakemake is installed and currently putting some stuff in a test script to work with bwa and freebayes

@chris-owen this looks really good, the only thing is I realized samtools rmdup will remove already marked duplicate reads. At least as far as I can tell. This means you need to mark duplicates first. The most common tool for this is picard's MarkDuplicates. However more recently I've seen samblaster as a better option as it is piping friendlier which picard is not.
Samblaster recommends doing something like:
bwa mem <idxbase> samp.r1.fq samp.r2.fq | samblaster | samtools view -Sb - > samp.out.bam
You should be able to integrate this into the command above pretty easily.

Oh, and depending on the caller you might not need to remove duplicates just mark them. Callers these days are smart enough to ignore duplicate reads that has been marked as such.

Segun and I just met with Carlos and he confirmed the pipe commands above are sufficient.


Ollie: Blacklist thedudehimself

Ollie requests the blacklist of the username thedudehimself. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

thedudehimself has been seen in 2 true positives, 0 false positives, and 0 NAAs.

thedudehimself has been seen in 2 true positives, 0 false positives, and 0 NAAs.

Rejected by cigien in Charcoal HQ. Reason: 'not currently eligible for being blacklisted'

Rejected by cigien in Charcoal HQ. Reason: 'not currently eligible for being blacklisted'


feat: add tests.

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA


fix funcorder linter

What changed?
There is a bug in the linter that is causing the reordering incomplete

Why?

How did you test it?
Manually verified all files

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 01829300-52da-4749-ae63-b60e16d3b875

0 of 210 (0.0%)  changed or added relevant lines in 3 files are covered.
124 unchanged lines in 20 files lost coverage.
Overall coverage decreased (-0.07%) to 57.67%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

client/frontend/client.go
0
38
0.0%

client/frontend/metricClient.go
0
82
0.0%

client/frontend/errorInjectionClient.go
0
90
0.0%

Files with Coverage Reduction
New Missed Lines
%

client/frontend/metricClient.go
1
1.21%

client/frontend/client.go
2
2.64%

client/history/client.go
2
38.1%

client/history/metricClient.go
2
45.3%

service/history/execution/mutable_state_util.go
2
36.14%

service/history/handler.go
2
47.76%

service/history/task/transfer_active_task_executor.go
2
71.7%

service/matching/matcher.go
2
91.46%

service/history/task/fetcher.go
3
91.79%

common/persistence/serialization/parser.go
4
62.41%

Totals

Change from base Build 018290f4-97f3-4be7-a410-f18eb7dbf1b7:
-0.07%

Covered Lines:
83964

Relevant Lines:
145595

💛  - Coveralls


Calculation and loading embedding model in metrics.

OCTIS version: 1.11.0

Description
Hi, there's a couple of issues I want to discuss, mainly foucing on class WECoherencePairwise, WECoherenceCentroid, and metrics using embedding.
If these issues are reasonable, I am happy to create a PR for these issues. Thanks! :)
1.  Calculation:
In score function, the L1 normalization for word embedding and Centroid (t) seems to be unnecessary because it use cosine similarity later on, the score will be identical without the normalization.
(See L122 and L196 in https://github.com/MIND-Lab/OCTIS/blob/master/octis/evaluation_metrics/coherence_metrics.py)
2.1 Default word embedding model:
Take WECoherenceCentroid for example, it load word2vec-google-news-300 as default model weight. Since the file size is big (1662 MB), it cost lots of time to download the model weight, which may not be a good thing for a default behavior. Also, some research (see Table 2 in [1]) shows that GloVe (glove-wiki-gigaword-50, 65 MB) may perform better than Word2Vec.
So, I think it may be a good idea to switch default model to glove-wiki-gigaword-50, or other word2vec model with smaller model size.
([1] Ding, Ran, Ramesh Nallapati, and Bing Xiang. "Coherence-aware neural topic modeling." arXiv preprint arXiv:1809.02687 (2018).)
2.2 parameter name and function input:
Also, it seems reasonable to be able to calculate WECoherence with different embedding model. Currently you can use word2vec_path to pass any w2v format model (e.g., glove-wiki-gigaword-50 provided by gensim), but the parameter name is really confusing. So if we want to support models other than word2vec, we should change the parameter name word2vec_path to more general one.
2.3 KeyedVectors as function input:
Currently, if you want to use several embedding related metrics (e.g., use WECoherencePairwise and WECoherenceCentroid at the same time), every metric instance will create it's own embedding model, which is unnecessary. To avoid this, we can take KeyedVectors as input directly.
2.4 support dict-like embedding object.
When calculate the metrics, we only need embedding for few words in topics. So there's no need to load the whole embedding model. In this case, we can use dict-like object to store embeddings we need.
In octis, the KeyedVectors only use in operation to check embedding exist, and use __getitem__ to get the embedding. So, we can simply convert dict like object to KeyedVectors, and make KeyedVectors related functions compatible with embeddings in dictionary format as input. Also, we only need to change code in __init__, without changing complex code like WordEmbeddingsInvertedRBOCentroid.scre.
Based on 2.1, 2.2, 2.3, 2.4 we can change WECoherenceCentroid.__init__ to following, and all metrics that use embedding can load model by function _load_keyedvectors.
from typing import Dict, Union
from numpy import ndarray
from gensim.models import KeyedVectors

class WECoherenceCentroid(AbstractMetric):
    def __init__(self, topk=10, model: Union[Dict[str,ndarray],KeyedVectors, None]=None, model_name: Optional[str]=None):
        '''
        If model is provided, use model first. If model is None, use model_name or default_model_name.
        '''
        if model is None and model_name is None:
            model_name = 'some_default_model_name'
        self._wv = _load_keyedvectors(model, model_name)

def _load_keyedvectors(model, model_name):
    if model is not None:
        if isinstance(model, KeyedVectors):
            pass
        elif isinstance(model, dict):
            model = _convert_dict_to_keyedvectors(dic)
        else:
            raise ValueError()
    else model_name is not None:
        model = api.load(model_name)
    else:
        raise ValueError()
    return model

def _convert_dict_to_keyedvectors(dic):
    vector_size = dic.values()
    arr = next(iter(dic.values()))
    assert len(arr.shape) == 1
    vector_size = arr.shape[0]
    kv = KeyedVectors(vector_size)
    kv.key_to_index = {k:idx for idx, k in enumerate(dic.keys())}
    kv.vectors = np.stack(list(dic.values()))
    return kv

I already forked and created 2 branch to fix this.

https://github.com/hyades910739/OCTIS/tree/issue89_remove_unnecessary_normalization_in_coherence_metrics
This one remove the unnecessary normalization code.
https://github.com/hyades910739/OCTIS/tree/issue89_change_embedding_model_loading_logic_in_metrics
This one create a MixIn to handle embedding model loading.


Display messages if JS or WebAssembly are not enabled.

Resolves #23
Added HTML code to check if user's browser supports JavaScript and also added JS logic to alert the user if the browser does not
support WebAssembly

Since you said that this is your first contribution to solve an issue, here some feedback:

You can put Resolves #<issue-number>. in the PR description (where <issue-number> is the number of the GitHub issue you are solving) to make GitHub automatically link the PR to the issue (and merging the PR will automatically close the issue).

Your commit implemented new features and also did some minor reformatting that was unrelated to the issue. Normally you want to separate formatting changes and function changes into separate commits so that they can be easily reviewed independently of each other (and also have descriptive commit messages attached). Here this doesn't really matter since the diff is so small but you may still want to try to separate these changes as a learning exercise.
Regarding your formatting changes I don't really think the formatting changes in the HTML file improve anything. Regarding the JS file ... ideally this project would have some autoformatting set up that was checked in the CI ... currently we don't have that here.

The commit message could be a bit more descriptive ... we don't just check if these are used but also alert the user ... so maybe Display messages if JS or WebAssembly are not enabled.

First of all, I'm grateful you took your time to give me some feedback, so thanks for that :)
As for the issues you're pointing to, thanks again for the suggestion to include the issue number in the PR description, I didn't know that github worked like this!
Now I actually have a couple of questions to understand if there was a huge misunderstanding from my side regarding the issue but I need to give you context of what I've done.
Basically I added the no script in the HTML file as it appears only when your browser does not use JavaScript, and I thought this was the first task because indeed when disabling javascript in my browser's settings the message pops up. So question number one, if this is not the solution then what's the actual task?
Then regarding the formatting changes, could you explain in detail what you mean? If I understand correctly I should have first created the function logic and then commit it, and only then call it by also changing the original code?
Last question, I thought that the task about warning the user that the website uses the WebAssembly API should consist only in warning the user with an alert, and again what I've tested on my browser (specifically done this on Firefox though) was disabling the javascript options .wasm files and then the alert pops up immediately when the website is opened.
If this was not the solution and you mentioned an autoformatting setup using the CI, could you give me an example of what you meant?
Sorry if I'm asking too much but as you see I'm trying my best to learn and I'd be grateful if you again provided me more constructive criticism, which I'm grateful for :)
Have a nice day!

thanks again for the suggestion to include the issue number in the PR description

You can edit the PR description by clicking on the three horizontal dots.

I need to give you context of what I've done

You don't need to ... I can see exactly what you have done by viewing the diff of your PR (e.g. by clicking on the "Files changed" tab on this PR). And yes you managed to solve the issue :) You did what was described :)

Then regarding the formatting changes, could you explain in detail what you mean?

 You will see changes like the following:

These are what I mean by formatting changes. It can very well be that you did not do them intentionally and your editor automatically formatted the file.

you mentioned an autoformatting setup using the CI

Sorry I didn't want to confuse you.  By autoformatting i meant it would be nice if we set up something like Prettier. GitHub has a CI feature that would let us check that the files are correctly autoformatted ... but this is as I said out of the scope of the issue ... don't worry about it :)
I hope that cleared things up ... have a nice day as well :)
Note that reworking a PR so that the commits contain precisely the changes you want requires some know how of the git command-line interface which can be a bit overwhelming at first but I do recommend learning it in the long run. E.g. you could run git reset HEAD~ to undo the last commit while keeping your changes and then selectively stage the changes you want to commit (e.g. everything except the formatting changes) with git add -p ... and then commit with git commit. Git is very powerful if you start having PRs with multiple commits it's also worth it to learn git rebase -i, but for such a simple PR you don't need it. Once you have changed your commits as you want them you can force push them to the GitHub PR with git push -f.

Thank you again for answering!
There's definitely a lot of stuff I need to learn, but if my PR solved the issue then I'll just edit the description on this one and mention the issue number, but I surely need to apply soon enough what you suggested me to do with Git as I'm still having trouble understanding how everything works, even though I watched some videos and already worked on some projects but I can already see the difference between working by myself and contributing even for a small issue on a small project.
Regarding the formatting changes you're correct I did not change anything intentionally except for adding the noscript, I use prettier on my editor and I'm so used to how Prettier does everything automatically that I didn't even notice the changes!
Thanks for the precious advice, this first contribution brought me much value :)

Hey @Alessandro-Battiato! I've left some comments inline, but I didn't realize that @not-my-profile had already reviewed the PR. Sorry for the duplication! In any case, it can be helpful to use those inline comments as separate threads, to allow the various suggestions to be discussed individually without a lot of quoting back and forth :)

Ok, I've pushed a new commit (6ca22d5) with a proposal for an alternative to the <noscript> approach to tell the user that JavaScript is needed to run the site.
Instead of inserting a paragraph at the top of the page and leaving the controls (textarea, button) available for interaction but unable to produce any effect, I decided to disable those elements, and activate them via JavaScript. Furthermore, the user message is provided as a placeholder in the textarea, which is where they would go to if they wanted to use the conversion functionality.
These changes ensure that the layout is kept the same on both states, improve the probablility that the user will notice the "JavaScript needed" message (since it is right in the place where they'd normally try to interact with the site), and overall make the site work more intuitively. @Alessandro-Battiato and @not-my-profile, please check this behavior and let me know what you think!
The one downside I have noticed is that Firefox seems to be caching the disabled/enabled state, so disabling JS and performing a simple reload will have those elements enabled, but incapable of functioning. A hard refresh (Ctr+Shift+R) is required to actually load the page anew. This fortunately doesn't happen in Brave (a Chromium-based browser), and this situation should be rare in the first place, so I suppose it's not a big deal. But if anyone has ideas on how to bypass the browser's caching of element states, let me know!

Ok, I've pushed a new commit (6ca22d5) with a proposal for an alternative to the <noscript> approach to tell the user that JavaScript is needed to run the site.
Instead of inserting a paragraph at the top of the page and leaving the controls (textarea, button) available for interaction but unable to produce any effect, I decided to disable those elements, and activate them via JavaScript. Furthermore, the user message is provided as a placeholder in the textarea, which is where they would go to if they wanted to use the conversion functionality.
These changes ensure that the layout is kept the same on both states, improve the probablility that the user will notice the "JavaScript needed" message (since it is right in the place where they'd normally try to interact with the site), and overall make the site work more intuitively. @Alessandro-Battiato and @not-my-profile, please check this behavior and let me know what you think!
The one downside I have noticed is that Firefox seems to be caching the disabled/enabled state, so disabling JS and performing a simple reload will have those elements enabled, but incapable of functioning. A hard refresh (Ctr+Shift+R) is required to actually load the page anew. This fortunately doesn't happen in Brave (a Chromium-based browser), and this situation should be rare in the first place, so I suppose it's not a big deal. But if anyone has ideas on how to bypass the browser's caching of element states, let me know!

I've tried the new functionalities on my machine, still using Firefox though so the elements are in fact enabled and not functioning, but still from a user perspective I am "forced" even before trying to type anything to read the placeholder which warns me that JavaScript is needed in order for the website to work properly, thus giving immediately the user the answer to the question " why won't it work".
But the placeholder option could probably have in my opinion a downside as compared to the noscript options, which happens in an extremely rare scenario where the user is plain ignoring every warning and every detail of the page and only writing inside the textarea without even reading the placeholder.
Considering though this is indeed a rare behaviour, I like this option as well, but regarding the firefox problem I'm sorry to say that I have no idea how to solve that :(

But the placeholder option could probably have in my opinion a downside as compared to the noscript options, which happens in an extremely rare scenario where the user is plain ignoring every warning and every detail of the page and only writing inside the textarea without even reading the placeholder, making the latter disappear and having "no clue" as to what could be the cause of the problem that has broken the website.

That's a great point, I hadn't considered it! However, it shouldn't be an issue because besides adding the placeholder, the textarea is also made disabled by default, so the user should not be able to type into it. I just tested this in Brave, and even if the textarea has content, upon reloading the page with JS off, the textarea content is replaced with the placeholder (and the textarea is, as expected, disabled, so no new content can be added to make the placeholder go away).
IMO the fact that this issue can happen in Firefox is a bug in Firefox that we should consider working around; but we shouldn't distort the base implementation just to accomodate one browser that behaves awkwardly. Let's wait for @not-my-profile's thoughts, and if none of us comes up with a workaround, I suggest we open an issue to track this problem and leave its resolution for a future PR.

Friendly ping to @not-my-profile :)

I cannot reproduce the Firefox bug you describe with Firefox 112.0.2.
Anyway I don't think adding this message in an input placeholder is a good idea because of accessibility reasons ... screen readers may not read placeholder text. So I think it's better to go with the <noscript> tag as I initially suggested.

Fair enough. I would still suggest the <noscript> message to be placed within the opening paragraph (bolded, perhaps, to call attention to it), and the rest of the changes (disabled form elements, placeholder text) could still be present as additional hints. Let me push a new commit with these changes.

Update: I re-added the <noscript>, with the content wrapped in a <mark> element to make it stand out. I actually went back on the placeholder to declutter the interface and avoid duplication of the warning.
I still left the activation of the form and apparition of the instructional placeholder to happen via script, so that they don't provide mixed messages to the user who has JS disabled.
Here's what it looks like without JS:

...and with JS:

Hmm. I see your point, but IMO with the bold and the <mark> syntax, there's enough semantic and visual signaling of this notice's importance, so I'll keep the current approach that's less disruptive in layout terms.

Ok, I've rebased the branch to split the changes into three atomic commits, and force-pushed it to update the PR. One of them is the code formatting, slightly adjusted to remove the line re-wrapping in index.xhtml (since the current wrapping was chosen deliberately), and to add a new '→" change in script.js. These differences can be seen here.
As for the JS and WebAssebly support checks, nothing changed in the combined diff compared to the previous version of the PR before the force-push, but the various commits were combined and re-split into two commits, one for each tech being checked. Your authorship of the commits was preserved, @Alessandro-Battiato :)
Merging now — thanks both for the contribution and review!


Adding region to README

It might be worth adding comment into readme that it needs AWS_REGION
e.g.
export AWS_REGION=eu-west-1

Yes, in fact like many AWS dependencies, this won't work without explicitly setting the region.


GSet for loop

Using a for loop on a Gset to iterate over records causes problems, i think the iterator is not rewinded because a second iteration start at the end of the preceding:
for(...){
...element 1
...element 2
}

adding a 3rd element
for(...){
...element 3 //! instead of restarting to one!
}

It's an HashSet not preserving insert order, then the 3rd element can be returned first and causes my bug.


Error building roi_align_v2 on windows

The error log is as follows. I am happy to provide more info if needed. Thank you!
mmdet/ops/roi_align/src/roi_align_kernel_v2.cu(290): error: no instance of function template "at::cuda::ATenCeilDiv" matches the argument list
                argument types are: (long long, long)

mmdet/ops/roi_align/src/roi_align_kernel_v2.cu(290): error: no instance of overloaded function "std::min" matches the argument list
                argument types are: (<error-type>, long)

mmdet/ops/roi_align/src/roi_align_kernel_v2.cu(330): error: no instance of function template "at::cuda::ATenCeilDiv" matches the argument list
                argument types are: (int64_t, long)

mmdet/ops/roi_align/src/roi_align_kernel_v2.cu(330): error: no instance of overloaded function "std::min" matches the argument list
                argument types are: (<error-type>, long)

4 errors detected in the compilation of "C:/Users/li/AppData/Local/Temp/tmpxft_00002ba8_00000000-10_roi_align_kernel_v2.cpp1.ii".
    roi_align_kernel_v2.cu

C:\Users\li\.conda\envs\mmdet\lib\site-packages\torch\utils\cpp_extension.py:209: UserWarning: Error checking compiler version for cl: 'utf-8' codec can't decode byte 0xd3 in position 0: invalid continuation byte
      warnings.warn('Error checking compiler version for {}: {}'.format(compiler, error))
error: command 'C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v10.1\\bin\\nvcc.exe' failed with exit status 1

I've found that modifying two lines in mmdet/ops/roi_align/src/roi_align_kernel_v2.cu works on Windows, but I'm not sure whether it would be the same on Linux or macOS.
Just change
dim3 grid(std::min(at::cuda::ATenCeilDiv(output_size, 512L), 4096L));

in line 290 to
dim3 grid(std::min(at::cuda::ATenCeilDiv(static_cast<int64_t>(output_size), static_cast<int64_t>(512)), static_cast<int64_t>(4096)));

and change
dim3 grid(std::min(at::cuda::ATenCeilDiv(static_cast<int64_t>(output_size), static_cast<int64_t>(512)), static_cast<int64_t>(4096)));

in line 330 to
dim3 grid(std::min(at::cuda::ATenCeilDiv(static_cast<int64_t>(grad.numel()), static_cast<int64_t>(512)), static_cast<int64_t>(4096)));

I've found that modifying two lines in mmdet/ops/roi_align/src/roi_align_kernel_v2.cu works on Windows, but I'm not sure whether it would be the same on Linux or macOS.
Just change
dim3 grid(std::min(at::cuda::ATenCeilDiv(output_size, 512L), 4096L));

in line 290 to
dim3 grid(std::min(at::cuda::ATenCeilDiv(static_cast<int64_t>(output_size), static_cast<int64_t>(512)), static_cast<int64_t>(4096)));

and change
dim3 grid(std::min(at::cuda::ATenCeilDiv(static_cast<int64_t>(output_size), static_cast<int64_t>(512)), static_cast<int64_t>(4096)));

in line 330 to
dim3 grid(std::min(at::cuda::ATenCeilDiv(static_cast<int64_t>(grad.numel()), static_cast<int64_t>(512)), static_cast<int64_t>(4096)));

Thanks for reporting the compatibility issue. It would be much appreciated if you would like to create a PR to fix it.

Thanks for reporting the compatibility issue. It would be much appreciated if you would like to create a PR to fix it.

Done in #2263 :)


Update run_access_request to include data uses and data category metadata

Description
The upcoming DSR export package is going to use each connectors data uses and data categories to help organize the data subjects data with the package. Currently, access requests don't add this data to the access package. Access Requests need to be updated to include in data in the package.
access_results_post_processing is the function that will updated to include the additional metadata.
Things to consider
The access package needs to use the metadata that was in the datasets at the time of graph generation. They cannot be looked up at runtime. This is because the execution will likely not match the current datasets exactly. This is because access requests are long running jobs. DSR's already cache the graph to fix this drift issue.
Make sure that all of the required package metadata is included at graph creation time. If it's not already included in the cached graph then add it.

moving to done


Backport OAK-9587 - Add an attribute to enforce a strict index tag check

This PR includes:

Backport of of https://github.com/apache/jackrabbit-oak/pull/378
Updated documentation

I think it makes sense to close this PR here and instead work on https://github.com/apache/jackrabbit-oak/pull/496 which contains the changes of this PR, plus some more.


Add bias argument to LPLN

What does this PR do?
Add bias argument to LPLN and forward to LayerNorm parent class

only relevant in torch.__version__ >= 2.1; should we check that?


copyright in the language configuration does not apply

What happened?
Even if copyright is set, it is not applied and the default value is applied. At least as of Hugo v0.110.0, this works as expected.
Theme version
v2.6.0
Hugo version
v0.112.3+extended
What browsers are you seeing the problem on?
Firefox
Relevant Hugo log output
No response

Thanks for the report. This is a result of changes in Hugo v0.112.0 and will be fixed in the next theme release.


[HOLD for payment 2022-11-07] [$250] BUG: Dev Console error when edit message  reported by @aimane-chnaif

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login with any account
Go to any chat
Long tap any message
Tap "Edit comment"

Expected Result:
No console errors
Actual Result:
Console error Warning: Failed prop type: The prop isComposerFullSize is marked as required in Composer, but its value is undefined.
Workaround:
unknown
Platform:

Where is this issue occurring?

iOS
Android

Version Number: 1.2.18-2
Reproducible in staging?: Need reproduction
Reproducible in production?: Need reproduction
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/197043807-6ea961fb-4b3c-47e1-98fa-68f5d79a17d4.mov
Expensify/Expensify Issue URL:
Issue reported by: @aimane-chnaif
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666283934468759
View all open jobs on GitHub

@lschurr  new BZ chore SO is here, we want to ensure BZ stays assigned to all issues so we can get to BugZero,

Triaging this today.

Tagging Eng since this is a dev issue that I can't reproduce.

Am indeed seeing this on dev. Since its only a warning, though, I think we can ignore it for now as it's not user facing, so I'll close this. However, ccing @neil-marcellini since it looks like it's related to this PR - https://github.com/Expensify/App/pull/9031 - in case there's a reason you can see to update, or it's a super quick fix?

We are compensating for bug reports we fix for console errors but... I hadn't thought of examples where they're only on dev.  Addressed internally https://expensify.slack.com/archives/C02NK2DQWUX/p1666661515587739?thread_ts=1663583691.520459&cid=C02NK2DQWUX

Yes @aimane-chnaif has the solution. I think we could also make it optional and default to false.

We should keep this open and fix it even though it's just a prop type warning.

Job posted:
https://www.upwork.com/ab/applicants/1584959643548332032/job-details
https://www.upwork.com/jobs/~01a688c0ae4629126f

Yep, that second proposal sounds great to me as well! I'll assign and lets go ahead with a PR.

@lschurr this is reviewed and approved. Do we need to do anything else on this issue/Upwork/etc. other than merge? This is my first one!

Also my first one - I asked here for clarification on next steps.

also @aimane-chnaif just wanted to share this info below in case you weren't aware how things work re: upwork, etc.!
I know there's a lot of information in our contributing guidelines, so some points to take note of:

Once your PR is merged, you can be hired for another issue. Once you've completed a few issues, we may start hiring you for more than one issue at a time.
Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that this doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically we would revert this PR and give you another chance to create a similar PR without causing a regression. (I don't imagine this will happen with this PR, but it's something to be aware of)
Once your PR is deployed to production, we start a 7-day timer. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job.

So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo!

@aimane-chnaif awesome! Sounds great.

Hi @aimane-chnaif - Could you please apply for the job in Upwork so that we can hire you? https://www.upwork.com/jobs/~01a688c0ae4629126f

Hi @eVoloshchak - could you apply to the job in Upwork so that I can pay you for C+?

Hey @aimane-chnaif - Could you accept the offer in Upwork and I'll get that paid!

All set. This has been fixed and paid!


What are the entire packages and dependencies for running the code? Is someone run the code in local conda environment successfully?

Hi!:smiley::smiley:I want to run your code in conda environment and I generate the environment.yaml from base conda environment in the docker container. But when I conda env create -f environment.yaml, there are always many errors like the packages are conflicting😥. It makes me so crazy:tired_face:. So I wonder if you can do me a favor about how to run the code in conda environment locally? Thank you very much!!!

Hi!😃😃I want to run your code in conda environment and I generate the environment.yaml from base conda environment in the docker container. But when I conda env create -f environment.yaml, there are always many errors like the packages are conflicting😥. It makes me so crazy😫. So I wonder if you can do me a favor about how to run the code in conda environment locally? Thank you very much!!!

hello, have you solved the problem? I want to run the project in conda envs too. Can you share a conda env?


Add a link to the contracts page in the grace period contracts warning message

Description
The warning message for contracts in grace period doesn't redirect the user to the contracts page unlike the message for contracts on offline nodes. so it should have a link for the contracts page for the sake of consistency.

Verified on Devnet.
A link was added directing to my contract page.

Verified:

Devnet
ec2ed3d


[Bug]: Fakeapi database is reset, due to which a test on cypress is failing [AddWidgetTableAndBind_spec]

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Fakeapi database has been reset, due to which a test on cypress is failing [AddWidgetTableAndBind_spec]
Steps To Reproduce
Fakeapi database has been reset, due to which a test on cypress is failing [AddWidgetTableAndBind_spec]
Github run
Cypress dashboard
Public Sample App
No response
Environment
Release
Severity
High (Blocker to building or releasing)
Issue video log
No response
Version
Cloud

As per this thread, issue was due to some other ui change which was fixed. Hence closing out this issue.


Election consistency check preventing election from succeeding.

On a small cluster of 4 machines using 1.0RC1, the election seems to find a leader but that leader prints messages indicating it doesn't consider the result consistent.
Apr 18 11:01:06 traap01 marathon[55349]: [2016-04-18 11:01:06,142] INFO Waiting for consistent leadership state. Are we leader?: false, leader: Some(traap01:8080) (mesosphere.marathon
.api.LeaderProxyFilter$:qtp114105\
Apr 18 11:01:06 traap01 marathon[55349]: [2016-04-18 11:01:06,398] INFO Waiting for consistent leadership state. Are we leader?: false, leader: Some(traap01:8080) (mesosphere.marathon
.api.LeaderProxyFilter$:qtp114105\
Apr 18 11:01:06 traap01 marathon[55349]: [2016-04-18 11:01:06,653] INFO Waiting for consistent leadership state. Are we leader?: false, leader: Some(traap01:8080) (mesosphere.marathon

The above message is very confusing as the leader is the machine where the check is failing and it prints its own name as the leader.
I don't see any reason why marathon would be confused by the hostname (the hostname returns the same name that marathon is using for the election and it resolves to the IP address used to communicate with the rest of the cluster.)

See https://github.com/mesosphere/marathon/pull/3777

@sttts can you look into this one?

I have just managed to rebuild Marathon from Git. Should I try with that version instead?

@papog the message you are seeing (usually) means that the leadership election is not yet finished. Because Marathon usually proxies requests to the current leader, it will hold back any API requests until the leadership looks "consistent" in order to avoid forwarding in an unstable leadership state.
Can you confirm that this message appears only for 2 or 3 seconds maximum?

I am not managing to get any leader election to succeed. My impression is that after a number of attempts where the election is not consistent the election is stuck (everybody thinks traap01 is the leader but traap01 thinks the result is inconsistent).
When I check with the web browser I see an error message:
HTTP ERROR: 503
Problem accessing /. Reason:
Could not determine the current leader

I am going to try again with the --hostname option.

@papog can you post a Marathon log of that node as a gist?

I bounced everything, checked Mesos at port 5051 and it looks healthy.
Marathon is still refusing to serve the web page (which is not convenient, it would be nicer to have a page with the latest info on the election that is failing).
I added a log as a gist:
[https://gist.github.com/papog/b6307408e10ea6dfb78f39658abfc0b1.js]

I’ve also seen something very similar to this just recently.  We have a Mesos cluster with 3 masters running Chronos and Marathon.  (Mesos 0.28.0, Marathon 0.15.3) There was a network outage lasting about an hour and afterward Mesos and Chronos had recovered but Marathon wasn’t showing up as a framework in Mesos any longer.  Trying to load the Marathon UI on any of the nodes resulted in that same 503 error with same messages in the logs showing one of the nodes as the leader but that node didn’t consider itself the leader.    I noticed that in Zookeeper under /marathon/leader there were 4 entries instead of just 3.  The one node that didn’t recognize itself as the leader was duplicated there.

This wasn’t a production system so just to see what would happen I deleted both entries for the duplicate node and Marathon recovered. It showed up in Mesos again and still had the tasks that it had been running before the issue.  I haven’t been able to figure out from the logs how it ended up with that duplicate node there in the first place.

I see the expected number of members on my machine (using zkCli.sh, I wonder what tool you got the screenshot from):
[zk: localhost:2181(CONNECTED) 2] ls /marathon/leader
[member_0000000064, member_0000000065, member_0000000066, member_0000000067]
I grepped in the logs and I find all 4 member items in the expected logs (i.e. each on one of the 4 machines).

The screenshot is from netflix/exhibitor, which we're using to manage our Zookeeper.

This sounds like #2751

Actually, this made me look back at the exception I had overlooked and it looks like some configuration issue related to Mesos (I am betting on the shared library).
I expect @gkleiman's fix for #2751 would have been helpful as the unusable marathon instances would simply have stopped.

Closing this, as it apparently was a configuration issue. Please re-open if you think there's something else we can do to help you.

It works now. I was using a mesos library that had been compiled without Java support and was not aware of that.
This was causing a failure when the marathon instance was becoming leader (which is a bit late for a configuration issue) and marathon kept running in spite of this fatal error.
#2751 would most likely have made it really clear that the exception was fatal and thus I believe the issue is completely addressed.


[Rancher2] Deploy RKE cluster using flatcar linux OS

Request Summary:
To deploy an RKE cluster (downnstream/HA cluster) using flatcar-linux-stable-2605.6.0 OS instances, the cluster.yml should be configured like
# rancher-cluster.yml
# cluster 1
nodes:
  - address:
    internal_address:
    user: core
    role: [etcd, controlplane, worker]
    ssh_key_path:

network:
  plugin: calico
  options:
    calico_flex_volume_plugin_dir: /opt/kubernetes/kubelet-plugins/volume/exec/nodeagent~uds
    flannel_backend_type: vxlan

services:
  kube-controller:
    extra_args:
      flex-volume-plugin-dir: /opt/kubernetes/kubelet-plugins/volume/exec/

# rancher-cluster.yml
# cluster 2
nodes:
  - address:
    internal_address:
    user: core
    role: [etcd, controlplane, worker]
    ssh_key_path:

network:
  plugin: canal
  options:
    canal_flex_volume_plugin_dir: /opt/kubernetes/kubelet-plugins/volume/exec/nodeagent~uds
    flannel_backend_type: vxlan

services:
  kube-controller:
    extra_args:
      flex-volume-plugin-dir: /opt/kubernetes/kubelet-plugins/volume/exec/

Without this in the cluster.yml, the cluster fails to come up. Related issue - https://github.com/rancher/rancher/issues/29841

Closing because https://github.com/rancher/docs/pull/2898 was merged


Merge with justinrainbow/json-schema

I just found this on packagist. I have contributed to justinrainbow/json-schema in the past because we needed it for composer.
I want to propose merging the two projects.
I'm not against competition, but if we can agree and join forces it's a huge win imo. Especially for projects that are as similar as these. If you could bring your expertise into the json-schema project, that would be huge imo.
It would also show the PHP community standing together, just saying.
Think about it. :)
Poke @justinrainbow @digitalkaoz
PS: Please do not take offense in this, I have great respect for you creating a json schema validator in the first place!

Hey there! Sorry for the necrobump, but I'm here to discuss a similar thing. It seems like this one has been abandoned, and I say that mainly because your support is at draft 3 and JSON Schema is up to draft 7. Now, I know a lot of tooling is not up to date with draft 7, but draft 4 is the cutoff for us as we redo the JSON Schema implementations page.
There's no shame in marking packages as abandoned, I've done it a bunch of times! Just yesterday I wrote this on my most popular and entirely unmaintained package.

Could you head over to packagist and mark it as abandoned, and leave similar notes on your GitHub profile/readme?

Directing over to @justinrainbow would be icing on the cake.

Actually my mistake, I'd recommend pointing folks to https://github.com/opis/json-schema as it has draft 6 & 7 support.


install nfs-provisioner with standard name

Describe the bug
nfs-provisioner is currently deployed with generate-name
we should instead deploy with:
helm install nfs-omnia stable/nfs-client-provisioner --set nfs.server=' . . .

@all-contributors please add @j0hnL for bug


Example DATA not working

I have tried to use the sample data and it doesn't seem to work? Perhaps I am doing something wrong but I seem not to be able to get any collinearity.

@Dearbhaile  You are not doing anything wrong. Example data does not work. Interestingly, the data format of the example files are not matching with the data format suggested.

Hi, I want to ask, do you by any chance have some example data, that match the format suggested? I'm struggling with this now, since in the description of the input data there doesn't seem to be a link between protein names in the blast file and the chromosome names in gff/bed file. And with data formated according to the example, the program also doesn't work...


Add Changelog File

Consider having a checked in changelog file that can provide historical context for various releases.
Sample to consider following is here: https://github.com/dotnet/SqlClient/blob/main/CHANGELOG.md

Do we really need this? There's a lot of repos that don't use this (https://github.com/Azure/azure-webjobs-sdk and our own repos for example...) and generally I think we should just be using the releases section for putting release notes.

This was an ask by KVH, since he really likes how sqlclient does this. Happy to chat some more about alternatives.


chore(main): release utils 1.15.1

:robot: I have created a release beep boop
1.15.1 (2023-02-17)
Bug Fixes

labeling when the dep graph has cycles (cb89eb1)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/sandworm-hq/sandworm-utils/releases/tag/utils-v1.15.1 :sunflower:


Add yxh-y's file

created a branch, created a file and made a commit, and opened a pull request

hello?


Added implementation of the default toggleable trait

Adds an implementation of the software toggleable trait from embedded-hal to the pins from the gpio module.

I believe that I have tested it on a Nucleo-F042K6 board. Though I can do a 100% check tomorrow to make sure that i'd definitely got the version using toggle to flash (I'd subbed toggle into the blinker example while getting things setup, so it hadn't actually made a functional difference).

I've modified the blinky_delay examples and the compiler got rid of the division emulation needed for the delay which is rather weird, shrinking the code from 624B to 274B. I'd be very happy if that was the case but it sounds to be too good to be true.

That is rather worrying. I'll do a double check on my side tomorrow and see how things are behaving.

I'm travelling and don't have a STM32F042 handy. If you don't get to it first (and please also confirm the size with/without toggle() via tools/capture_example_bloat.sh to eliminate the possibility of another SNAFU) I'll check at home this weekend.

Ok, I've tested it on my nucleo board and using toggle definitely still functions appropriately and i've confirmed that its actually hitting hardware by reflashing a few times with different delays and observing appropriate changes in flash rates. I've attached the bloat reports for with and without the changes.
harkonenbade-master.txt
upstream.txt

Ty!


Setup Review

I followed the setup process, skipping the OpenAI & Stripe setup. Love the process. I hit a couple of bumps, some of which were mine, and others were fixed already.

The git (ssh) clone failed, so I redid with https. SSH might requires auth even for public repos? I've never used it before, so I've not yet run into this.
Nit: The propelauth example project name is invalid (pwf-dev cannot contain -) (same in step 9) already fixed!
The setup page marks step 6 as complete before I even do anything (noticed past step 3)
Doesn't explain the flow of creating a posthog project. It could probably use a nod to follow the on-screen instructions, and which type of app to create (I assumed web)
For step 9, you need to do propelauth before the supabase migration also looks to be fixed!

The setup page marks step 6 as complete before I even do anything (noticed past step 3)

yeah, that one is tricky one :) we can't really check that from that page since it's just a setting you change on propel website. We were thinking of adding some kind manual "mark as done" for that one


python37Packages.sqlite-utils: 3.1 -> 3.1.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.sqlite-utils is: "Python CLI utility and library for manipulating SQLite databases"
meta.homepage for python37Packages.sqlite-utils is: "https://github.com/simonw/sqlite-utils"
meta.changelog for python37Packages.sqlite-utils is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.1.1 with grep in /nix/store/3f7cad7pk4qfqh0ppfyxl91w6a15l1c8-python3.7-sqlite-utils-3.1.1

directory tree listing: https://gist.github.com/5e4cd39911157c2a3e1890ae9d277507

du listing: https://gist.github.com/603ad059a26e80c51feddf6187ea8657

Rebuild report (if merged into master) (click to expand)

16 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python37Packages.sqlite-utils
python38Packages.sqlite-utils
python39Packages.sqlite-utils
sqlite-utils

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3f7cad7pk4qfqh0ppfyxl91w6a15l1c8-python3.7-sqlite-utils-3.1.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.sqlite-utils https://github.com/r-ryantm/nixpkgs/archive/2b3746fa708c96899c528cc3d3edacba977fad73.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3f7cad7pk4qfqh0ppfyxl91w6a15l1c8-python3.7-sqlite-utils-3.1.1
ls -la /nix/store/3f7cad7pk4qfqh0ppfyxl91w6a15l1c8-python3.7-sqlite-utils-3.1.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

python37Packages.sqlite-utils
sqlite-utils (python38Packages.sqlite-utils)
python39Packages.sqlite-utils

Maintainer pings
cc @meatcar for testing.

Result of nixpkgs-review pr 108199 run on x86_64-darwin 1

3 packages built:

python37Packages.sqlite-utils
sqlite-utils (python38Packages.sqlite-utils)
python39Packages.sqlite-utils

Result of nixpkgs-review pr 108199 run on x86_64-darwin 1

3 packages built:

python37Packages.sqlite-utils
sqlite-utils (python38Packages.sqlite-utils)
python39Packages.sqlite-utils


thoughts on assert.uuid() addition?

not sure if you want to open the door

can be closed - fixed in commit mentioned above


2850: POI filter button shines through language selection overlay

Short description
POI filter button above the  language selection overlay.
Proposed changes

Changed the z-index for OverlayContainer from 1 to 0 Located at MapView component.

Side effects

None
Resolved issues

Fixes: #2850

@bahaaTuffaha Though in this case, please still remove the z-index and test it once more before merging 🙂