Optimize InvertDraw

https://github.com/BinaryKits/BinaryKits.Zpl/pull/64
@tinohager Do you know why we need to use color space RGBA8888, when ZPL is always black?
Anyway this reduce the time to 2s. (From 9~12s)

We can make it even faster by using pointer, if unsafe is allowed during compilation?
https://docs.microsoft.com/en-us/xamarin/xamarin-forms/user-interface/graphics/skiasharp/bitmaps/pixel-bits#random-access-of-pixels

I think your current solution fits. The only disadvantage from my point of view is that it will be more difficult to determine the position in the image. One consideration was to consider only the changed area, which would work well with a rectangle or a font.

Turns out the getter is slow. Now around 650ms


Clearer information about DNS required

There are no "clear" explanation of the reason why local DNS server is recommended. As a result, I still see many compagnies setting up their DNS in one Physical location instead of having it in local network egress location. It is important to mention how the Microsoft 365 front doors use multicast so depending on where the user query is emitted, the result will be different. Not having a local DNS set up will mean that the traffic will not be optimized, as it will travel through the internet for longer than it needs too, creating possible extra latency or delay. (if possible, using a graphic showing the way the traffic will travel in an optimized setup compared to one with a centralized DNS).
As this problem is coming up in so many compagnies, it impacts the user experience that many users are having which then make them more prone to use other applications like zoom. Unfortunately, once they have moved to another app, it is hard to make them change their mind about the product (remember windows Vista?)
I am happy to help work on the updated article if required, but from my experience, a lot of the requests for updates usually get rejected before reaching out to the correct people, which then do not encourage people like me to actually write feedbacks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 37aa6426-21fd-53b4-d22c-4c136abdf78d
Version Independent ID: dbc918f9-6677-9003-4884-7a824ee07224
Content: Microsoft 365 network connectivity test tool - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/office-365-network-mac-perf-onboarding-tool.md
Service: microsoft-365-enterprise
GitHub Login: @kelleyvice-msft
Microsoft Alias: kvice

@kelleyvice-msft Please help us in resolving this issue. Thanks


[backport] Fix crash when event has missing publisher and no event data (#22353)

What does this PR do?

backport https://github.com/DataDog/datadog-agent/pull/22353
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


--rerun-tasks doest not get forwarded to the server

I'm trying to use the --rerun-tasks gradle parameter to force a re-run of all my tests and thus skip the caches. This parameter does not seem to be forwarded to the remote execution of gradlew.

Hey, I've checked this param on the latest mirakle version and Gradle 7.2 and it works.
Could add this line to any build.gradle of your project and check the console output.
println("Is rerun tasks = " + gradle.startParameter.isRerunTasks())

if it prints true it means the parameter has been forwarded to remote machine.


LL-3860 Wording changes, lots of wording changes

Million wording changes, one by one, manually baked from an ancient text from July.
Type
Wording
Context
https://ledgerhq.atlassian.net/browse/LL-3860
Parts of the app affected / Test plan

By the way we are mixing uk and us english with things like catalogue and synchronizing
To me it should be either catalog and synchronizing, or catalogue and synchronising, but not this mixed hybrid
cc @cthepot-ledger @dasilvarosa


Move legacy code to the legacy repo

Please comment with the code that you think should not be in the main source tree.
This is not supposed to be an exhaustive list.

No legacy repo anymore.


Todo: test using a Box and then downcasting it into a Vec

test using a Box and then downcasting it into a Vec, and creating implementations of functions, that don't require generics(ej: remove, pop, etc..) in their arguments without generics.

looking for a solution to use remove and pop implementations without generics.


[fix][broker] Fix class name typo PrecisPublishLimiter to "Precise"

Motivation
To fix a typo on a class name. Class name is not a good place for a typo.
Modifications

Changed class name from PrecisPublishLimiter to PrecisePublishLimiter, ending with "e"
Renamed relevent local declarations like wise, from precisPublishLimiter to precisePublishLimiter

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/JooHyukKim/pulsar/pull/3

This bothered me too. Thank you.


Update cilium DaemonSet name and label to align with upstream

This small change aligns the DaemonSet name and label to match a deployment made with the official CLI. This enables the use of the status command, connectivity tests, etc. that expect the DaemonSet to have a specific name.

Pretty reasonable


Add React Native support

Specify a separate entry point for React Native that export React Native's fetch() polyfill. Would that be a more acceptable fix for #63?

:+1:
Lets see se he will think in the react-native users as well :)

Should probably also support this as a fallback to self.

I believe they're planning to fix this in react native itself

@matthew-andrews Could you provide a link to an issue in RN mentioning that? My understanding is that the efficiency of the packager at runtime makes this difficult/impossible.

Thanks @jou !

Thanks for this

👍

👍

What happened to this? I don't see a fix on the RN side (0.32.x) and this is still a present bug.

Hey @matthew-andrews could you please merge it, no matter that that is RN issue ... they aren't going  fix it in near future
Small example: https://github.com/facebook/react-native/pull/9942
They just **** up their community, so please don't do the same things, it just save time and brain for all your users.
Thank you in advance

Hi @matthew-andrews, I agree with this comment. It would be awesome to merge it

Could you please merge it, no matter that that is RN issue ... they aren't going fix it in near future
Small example: facebook/react-native#9942
They just **** up their community, so please don't do the same things, it just save time and brain for all your users.
Thank you in advance

Just merge it pls.

I really do not think they will be fixing this in React Native any time soon. Can this just be merged? I am still having this issue

This project had last commit 10 months ago, so basically it's dead project without any active persons here and a lot of PR and issues. Don't waste your time and just switch to any similar project that contains one line fix for react-native, like:
https://github.com/lucasfeliciano/fetch-everywhere / https://www.npmjs.com/package/fetch-everywhere
And has an active maintainer.

Another good option is fetch-ponyfill. I added the Node support to it last year. It's actively maintained, and has been around for a few years. It doesn't have the React Native one-liner yet but I imagine @qubyte would be down to include it.
It's a ponyfill which means it's safer / more contained. It loads like a well-behaved CommonJS module, without side effects. It doesn't set or replace window.fetch.

For those who are interested I forked this project and merged in this PR here: https://github.com/Knotis/portable-fetch. With some minor changes I got this working in my company's react-native app.
Install with NPM via:
npm install portable-fetch

@matthew-andrews please merge this

Please merge... I have switched to @sethdenner 's fork in the meantime. Thank you Seth!!

For all those seeking for an isomorphic-fetch with React Native compatibility, see cross-fetch. graphql-request and VulcanJS are already using it.

@sethdenner how do I use portable-fetch in my project. I am using react-navigator which in turn uses isomorhic-fetch?

This PR is old enough to speak in full sentences now and still shows up when I check on the statuses of my pull requests at work…
Since the project I needed this for originally has been out of my hands a long time ago and it won't be likely to get any action, I'm closing this.


Change constructor for MockHelixAccountServiceFactory by default to use MockHelixPropertyStore

Previously there is only one constructor that takes the fourth parameter
to allow caller to specify if should use mock helixpropertystore.  However,
this will be hard to pulg in the MockHelixAccountServiceFactory to any
integration test that uses a mock property store. This PR introduces
this possibility.
Test: clean build

Codecov Report

Merging #751 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #751      +/-   ##
============================================
- Coverage     65.73%   65.69%   -0.04%
+ Complexity     3888     3881       -7
============================================
  Files           336      336
  Lines         25766    25766
  Branches       3224     3224
============================================
- Hits          16938    16928      -10
- Misses         7924     7931       +7
- Partials        904      907       +3

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/com.github.ambry.store/HardDeleter.java
79.67% <0%> (-2.26%)
40% <0%> (-2%)

.../src/main/java/com.github.ambry.store/Journal.java
89.65% <0%> (-1.73%)
19% <0%> (-1%)

...ava/com.github.ambry.store/BlobStoreCompactor.java
92.55% <0%> (-1.13%)
117% <0%> (-3%)

...m.github.ambry.clustermap/HelixClusterManager.java
93.59% <0%> (-0.72%)
32% <0%> (-1%)

...in/java/com.github.ambry.network/SocketServer.java
82.78% <0%> (-0.41%)
13% <0%> (ø)

...ain/java/com.github.ambry.router/PutOperation.java
89.95% <0%> (-0.23%)
69% <0%> (-1%)

...github.ambry.rest/AsyncRequestResponseHandler.java
90.81% <0%> (+2.29%)
23% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d9a559...e50bba6. Read the comment docs.


Unable to externally enhance library (export createPatternBuilder helper)

Allow accessing this functionality to create new personalized patterns that don't necessarily need to be in this library.
Use case: proto-patterns hasn't passed the "patternity" test but it is very useful and the developer wants to implement it within the library to allow the other features like wrapping, dynamic inheritance, etc...
By exporting the createPatternBuilder within the patterns library, we can easily allow to externally enhance this library.

I added "vMAJOR" label because I believe this functionality requires a major version upgrade as it is a big feature even if it is backward compatible.


Work around for Issue: #204085

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.96.0 (Universal)
OS Version: macOS Sequoia 15.2

Steps to Reproduce:

Run "Shell Command: Install 'code' command in PATH"
Try to use 'code' in your Terminal (I tested in Terminal, Warp, and iTerm2) and it throws the error found in Issue #204085

An example of the error for those that don't want to follow the link:
[1217/023927.336091:ERROR:codesign_util.cc(109)] SecCodeCheckValidity: Error Domain=NSOSStatusErrorDomain Code=-67062 "(null)" (-67062)

Anyway... I found I guess what you'd call a workaround to this 'old' bug since it's labelled Backlog and no idea when an official fix will happen.
In VSCode, open the Command Palette and remove 'code'
Shell Command: Uninstall 'code' command from PATH
Now, since it appears that most users with the issue from that thread are on ZSH (like me) edit your ~/.zshrc file (or whatever 'dotfiles' you have your aliases in) and add the line:
alias code="open -a 'Visual Studio Code'"

Restart your Terminal application... now code <filename> and code <folder> both work again properly without the Domain error above.
Sorry Devs, I wasn't sure how to report this for users but wanted to share since the issue seems common enough that a bunch of people should benefit from this.

Thanks for adding the workaround, I will be closing this issue as the underlying problem is tracked on https://github.com/microsoft/vscode/issues/204085 and this is a workaround suggestion more than an issue


Refactor procedure timeout

Refs: https://github.com/metarhia/impress/pull/1936
Refs: https://github.com/metarhia/impress/pull/1958

[x] tests and linter show no problems (npm t)
[ ] tests are added/updated for bug fixes and new features
[x] code is properly formatted (npm run fmt)
[ ] description of changes is added in CHANGELOG.md
[ ] update .d.ts typings

Landed in https://github.com/metarhia/impress/commit/df4c4c40b3d7fa71cd9edfa84dba6ac18e9afc21


Fixed Windows Caching

Whoa it's a Pull Request!
Fixes https://github.com/ivanvotti/ember-svg-jar/issues/24. This is a non-borky alternative approach to  #1, basically.
The gist is that Windows doesn't like colons in the filename, and this package uses the value of optionsHash() (a JSON string) to generate a cache key. async-disk-cache will happily try and use this key as a temp folder name, which leads to a fun ENOENT bomb-out on Windows. Doh!
In particular, this makes testing Ember addons that utilize ember-svg-jar troublesome on Windows (e.g. https://github.com/tim-evans/ember-file-upload/issues/36).
This PR simply runs optionsHash() through SHA-1 when computing the cache key, which magically solves everything. Wheee!
Why SHA-1?
It was convenient, and we needn't worry about being uber-cryptographically-secure here. Feel free to suggest a different hash algo choice if picky.
Why not Base64/URL encoding?
I didn't want to hit Windows' infamous MAX_PATH limitation (can't have paths longer than 260 characters on Windows 8.x and earlier), and a very long optionsHash() may potentially lead to that if we just encode it, so I took the hash function route.
Did writing this PR text take longer than actually coding the fix?
Yarp. 🌵

Thank you. I'll check it out soon.

@XaserAcheron The original broccoli-persistent-filter uses md5-hex in cacheKeyProcessString like this:
Filter.prototype.cacheKeyProcessString = function(string, relativePath) {
  return md5Hex(string + 0x00 + relativePath);
};

We could just rely on that behaviour and write something like this:
SVGOFilter.prototype.cacheKeyProcessString = function(string, relativePath) {
  return Filter.prototype.cacheKeyProcessString.call(this, string + this.optionsHash(), relativePath);
};

This way we don't need to add sha1 to the project. What do you think?

I don't hate that idea. It relies on the base library a bit, but it's not unreasonable to trust that it won't spontaneously become Windows-incompatible or anything. I'll give the PR an update soonish.
[wow, double negatives]

@XaserAcheron @ivanvotti Any resolution on this? We have devs coming on board that prefer to code on Windows, and this issue has blocked them.

I hit this issue. Can we get this merged? :)

Welp. That increases its importance a bit. :P
I've got a bit of bandwidth, so I can make the suggested change super-quick and ensure it still works, that way everyone's happy and unblocked.

All right, updated. In the true spirit of this PR, it took much longer to set up my dev environment again than to actually make the fix. ;)
Pinging @ivanvotti for re-review. Dunno why I didn't think of doing it this way in the first place, really.

It will be done today. Sorry guys for the delay, I just didn't expect that so many folks are using Windows these days for web development. I'm definitely going to buy one (probably Windows 7) to adjust my public libs.
@XaserAcheron, @wycats are you particularly interested in broccoli-svg-optimizer fixed or ember-svg-jar? If it's the last one, I'll publish a new release with the fix today.

For what it's worth, I simply ran into this while ember test-ing an addon that included ember-svg-jar, so my own use case is pretty trivial. Seems you're already looking into full Windows support for ember-svg-jar anyhow, so that part's covered.
Thanks for remembering we goofy Windows folk! ;)


Feat: Adding space between contact form and navbar

Describe the feature
Currently the contact page looks congested because of lack of space between navbar and contact form
Also I would like to replace the current illustration with the same color of the website theme
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSoC'24 contributor
[X] I want to work on this issue

hey @Amruta7203 In my side it is well!


Uninstall graalvm is not successful, fails to find installed version

Expected behavior
As a end user, I want to uninstall graalvm using the uninstall graalvm command.
Actual behavior
graalvm is still present and fully functional after running uninstall graalvm.

Steps to reproduce (windows)

install graalvm
uninstall graalvm

My assumption is that uninstall is implemented in a generic way and just removes software/«tool».
Since we have and exceptional situation for GraalVM that installs to software/extra/graalvm this does not work.
Current code:
https://github.com/devonfw/IDEasy/blob/b870e36e93d32c51ba0e5f1f429456a2791b09a8/cli/src/main/java/com/devonfw/tools/ide/commandlet/UninstallCommandlet.java#L43-L53
As always the proper solution is delegation to the according tool and have that default implementation in ToolCommandlet. Then GraalVm commandlet can override this method as needed.

See InstallCommandlet that properly delegates to the tool:
https://github.com/devonfw/IDEasy/blob/b870e36e93d32c51ba0e5f1f429456a2791b09a8/cli/src/main/java/com/devonfw/tools/ide/commandlet/InstallCommandlet.java#L49


Fix Nightly Python3 error in graph_io_test.py

Change: 125988941

@tensorflow-jenkins test this please.


Custom dataset

Can i use this on smaller custom datasets? If yes what sort of changes do you advice i should consider before trying it ?
Thanks in advance.

You can change the lines in the preprocess,py file to the names of the data you are training for. Use "Date" for the date entries, and the prediction value column as "Close". You have to clean-up the date to get good accuracy, like use percentage change instead of absolute values.
    # subset data
    train_df = train_df[['day',<ENTER CUSTOM VARIABLE NAMES HERE>]]
    test_df = test_df[['day',<ENTER CUSTOM VARIABLE NAMES HERE>]]


Maintenance Update

If null is passed as ILoggerFactory, the ILogger<T> is created via the NullLoggerFactory.
The IIOService has been renamed to the more accurate  IIOHelperService
Adds native InternalsVisibleTo support. The attribute is no longer necessary.
Adds full support for coverage calculation.

I just ran the default formatter/inspection fixup for C# included with Rider with the latest ruleset. It's it's own commit, so I can just drop it - I don't really care either way, I was just tired of Rider nagging about things.

Also weren't you the one who suggested this braces style? 😛

Did I?  ;)


Installation issue

Probably due to user error, so I apologize if I sound dumb, but I can't seem to proceed to the actual installation because Windows insists the certificates are unverified.

I've installed the certificate provided with the current release, but it hasn't made a difference. I'm wondering if there's another step I've missed.
Thank you.

Hello, did you try put the cert to Trusted Root Certification Authorities?


⚠ ClamAV has degraded performance

In aafa539, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 555 ms

Resolved: ClamAV performance has improved in b16e2f9.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1061

Questions ?
Please refer to the Backport tool documentation


【npm_and_yarn】PR not created silently when PeerDependency unmet, need infomation.

Hi, I want Dependabot provide more information when peerDpendency unmet in npm_and_yarn.
In my project, I noticed update PR for typescript  is not created otherwise there is a new version.
I tried dry-run for typescript but, there are no useful information and I don't know why PR is not created.
ruby ./bin/dry-run.rb npm_and_yarn moneyforward/mf_attendance --dep typescript
=> dumping fetched dependency files: ./dry-run/moneyforward/mf_attendance/
=> parsing dependency files
=> updating 1 dependencies: typescript

=== typescript (3.9.10)
 => checking for updates 1/1
 => latest available version is 4.6.2
 => latest allowed version is 3.9.10

 => requirements to unlock: update_not_possible # I don't know why🥺
 => requirements update strategy: bump_versions
    (no update possible 🙅♀)

Minimum reproduce repository here
To inspect peerDependency problem, I need to add debug log to npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/version_resolver.rb like this commit
ruby ./bin/dry-run.rb npm_and_yarn moneyforward/mf_attendance --dep typescript
...
【❌typescript : 4.0.2】doesn't meet peerDependency >=3.4 <4.0 by ts-jest
【✅typescript : 3.9.10】 meet peerDependency >=3.4 <4.0 by ts-jest

From this log, I noticed ts-jest's peerDependency limit typescript under <4.0.

Moreover,
【❌ ts-jest:26.0.0】 project dependency to jest:^25.5.4 in package.json doesn't meet ts-jest peerDependencies >= 26, < 27
【✅ ts-jest:25.5.0】 project dependency to jest:^25.5.4 in package.json  meet ts-jest peerDependencies >= 25, < 26
...

From this log, I noticed a mismatch project's dependency to<EMAIL_ADDRESS>and  ts-jest's PeerDependency>= 26, < 27 prevents version up of jest.

At last, I've resolve the problem by updating jest and ts-jest manually.
I think

Many projects have this problem, but it is left unnoticed.
It's very hard to debug this problem.

So I want Dependabot provide useful peerDependency information of no update possible.
Thanks,

@kazuooooo Thanks for providing us such beautiful detail! We are looking into this issue of unmet peer dependencies. I am trying to ensure I understood your problem precisely. I toyed with describing this problem in figma too 😄

Does the diagram above look somewhere accurate to the behavior you described ?
Could you confirm that none of those dependencies were updated?
Since I don't see any open PRs in that test repo , Would you share the security alert this was for ? Or even better open that PR again on the test repo :)

Thanks for your help and for opening this issue !

Closing due to lack of user response...

It looks like this might be reproducible here: https://github.com/dsp-testing/dependabot-unmet-peer-dependency/issues/3


Executable takes db path and peer addresses

My English is probably poor. I apologize it.

This is just a tiny change but first step to make executable richer.

Add args module for bin directory
Executable takes -<key> <value> style argument
User can specify peer address connecting to by -p option.
User can specify db path by -db option.

Thanks a lot.


Small bugfixes

We noticed some problems with the graphite sink producing uncaught exceptions if the graphite backend is not available. This bugfixes solved these problems for us.
We use the graphite sink with attemps=1 (no retry).

Thanks!


Memory leaks when we use Thruway as a synchronous client many times in one console command

We are using Thruway as an asynchronous as well a synchronous client. In case of using a synchronous client we are facing a problem when memory leaks all the time. The following code is not from real project and does nothing useful (just open and close connection) but it can show the essence of the problem.
<?php
require_once('../../vendor/autoload.php');

use Thruway\ClientSession;
use Thruway\Connection;

while(1){
    usleep(10000);
    $connection = new Connection(["realm" => 'realm1', "url" => 'ws://<IP_ADDRESS>:8080/']);
    $connection->on('open', function (ClientSession $session) use ($connection) {
            $connection->close();
        }
    );
    $connection->open();

}

$connection = null; and unset($connection) don't help.
We are not using event and ev php extension, just default built-in php library. We are using php 7.2 inside of Ubuntu virtual mashine using Vagrant.
The problem above seems pretty similar to one for Ratchet described in https://github.com/ratchetphp/Ratchet/issues/662. I have tried it in hope it can help as Ratchet is under the hood of Thruway, but the proposed solution did not work.

Just tried to install event.so and run the script above. Memory leaks even faster.


Add backstage configuration file

See Slack Announcement
Ping @Tim J on Slack if any questions

Deletion may also need double checked 👀


migration: update cometbft tx size for t78 migration

Describe your changes
We've already updated the CometBFT config template, but running nodes on the current testnet will still be using the prior value, generated at time of join. Let's update the value as part of pd migrate, logging a warning if we fail to do so.
Issue ticket number and link
Refs #4594, #4582.
Checklist before requesting a review

[x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

relevant to consensus-breaking logic and how it's handled via migrations

Encountered some errors while testing this. In short, the TendermintConfig struct is stricter about type validation than CometBFT is. For example, seed_mode = "false" is accepted by CometBFT, but the struct demands seed_mode = false. Worse, an indexer node will fail, due to the psql indexer not being supported by tendermint-rs (#3188). Let's log warnings in those instances, rather than allowing the error to percolate up to bailing out on the top-level pd migrate action. If that still proves problematic, we can fall back to asking node operators to make the change manually.

I'm happy with these changes: the cometbft munging will bail out before overwriting if it cannot interpret the on-disk cometbft file, logging a warning. That works well enough with the variety of munged configs I tested against.

This is ready for review again. After migration, the cometbft config's mempool block should look like:
[mempool]
recheck = true
broadcast = true
wal_dir = ""
size = 5000
max_txs_bytes = 10485760
cache_size = 10000
keep-invalid-txs-in-cache = false
max_tx_bytes = 30720
max_batch_bytes = 0

I made sure to test with a customized config that set persistent_peers, and those changes were preserved post-migration.


Standardize on UTC date/time stamps in logs.

Current the NodeJS based components log using with UTC based timestamps (2018-11-19T14:32:58.102Z), the Java based components use a timezone based on server local time (2018-11-19 14:37:21).
Problem diagnosis would be easier in all timestamps used UTC.  Switch the Java based components to datestamp in the same format to the same precision.

@k-wall yes, I've raised a new issue, shoul not be hard to fix this: https://issues.apache.org/jira/browse/DISPATCH-1187

@lulf Serivce-broker still use old pattern


Submit codecov data with flags

Description
Try using codecov flags for different tests.

Codecov Report

Merging #361 (986f2f7) into main (f509ea2) will decrease coverage by 26.39%.
Report is 132 commits behind head on main.
The diff coverage is 29.24%.

@@             Coverage Diff             @@
##             main     #361       +/-   ##
===========================================
- Coverage   89.85%   63.47%   -26.39%
===========================================
  Files         195      207       +12
  Lines       29267    28484      -783
  Branches     6722     4996     -1726
===========================================
- Hits        26299    18081     -8218
- Misses       1945     9711     +7766
+ Partials     1023      692      -331

Flag
Coverage Δ

Core
63.47% <29.24%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

api/admin/announcement_list_validator.py
0.00% <0.00%> (-100.00%)
:arrow_down:

api/admin/controller/__init__.py
4.61% <ø> (-82.77%)
:arrow_down:

api/admin/controller/admin_search.py
0.00% <0.00%> (ø)

api/admin/controller/analytics_services.py
0.00% <0.00%> (-92.78%)
:arrow_down:

api/admin/controller/announcement_service.py
0.00% <0.00%> (-96.78%)
:arrow_down:

api/admin/controller/catalog_services.py
0.00% <0.00%> (-89.37%)
:arrow_down:

api/admin/controller/collection_self_tests.py
0.00% <0.00%> (-94.45%)
:arrow_down:

api/admin/controller/collection_settings.py
0.00% <0.00%> (-91.12%)
:arrow_down:

api/admin/controller/dashboard.py
0.00% <0.00%> (ø)

...troller/discovery_service_library_registrations.py
0.00% <0.00%> (-95.78%)
:arrow_down:

... and 87 more

... and 73 files with indirect coverage changes


Updating Child Collections with Soft Deletes

Is your feature request related to a problem? Please describe.
I am building a new solution with soft deletes across all of my entities, and the filter criteria works great for reads, but I'm having difficulties doing updates of nested objects--specifically where orphan removal will attempt to delete the items that are no longer present.
// globally add the filter at startup
this.em.addFilter('active', { deleted: false });

// all entities have roughly this structure
@Entity({ abstract: true })
abstract class BaseEntity {
  @PrimaryKey({ type: 'uuid' })
  id = v4();

  @Property()
  deleted = false;
}

Describe the solution you'd like
I'd like a way of changing the behavior of deletes in the unit of work so that i can rewrite deletes into updates that set the deleted field
-- FROM
delete <entity> where id=<xyz>
-- TO
update <entity> set deleted = true where id=<xyz>

This would allow me to simplify my code so that any children collections were automatically handled without writing custom code on a per collection basis:
async update(id: string, newData: EntityData<ParentObject>) {
  const parent = await this.parentRepository.findOneOrFail(id, ["children"]); // or just have eagerly loaded children
  this.parentRepository.assign(parent, newData); // any children that were no longer present would get marked with child.deleted = true instead of having the record deleted.

  await this.parentRepository.persistAndFlush(parent);
}

Describe alternatives you've considered
Currently I am handling this by not eagerly loading any child collections.  Then, I separately fetch and manually iterate through the children and run the correct updates/inserts based on status.
I looked at creating a custom repository that implemented this behavior, but I think that the delete behavior is handled higher up in the UnitOfWork stack and not currently accessible

I think this should be already possible via flush events - inside onFlush you can lookup remove changesets and change them to update.
http://mikro-orm.io/docs/lifecycle-hooks/#using-onflush-event
Something like the following lines (not tested):
@Subscriber()
export class SoftDeleteSubscriber implements EventSubscriber {

  async onFlush(args: FlushEventArgs): Promise<void> {
    const changeSets = args.uow.getChangeSets();
    const toRemove = changeSets.filter(cs => cs.type === ChangeSetType.REMOVE);

    toRemove.forEach({
      cs.entity.deleted = true;
      args.uow.computeChangeSet(baz);
      args.uow.recomputeSingleChangeSet(cs.entity);
    }
  }

}

const bar = new FooBar();
bar.name = 'bar';
await em.persistAndFlush(bar);

Interesting, I'll check that out and report back, thanks @B4nan!

It looks like I also have to set cs.payload = { deleted: true } or else the generated sql goes a bit crazy--I'm going to keep on testing this, but it looks like it works great with orphanRemoval set to true on child collections.  I tried to add some type safety to only do this if the object has a deleted prop/field as well, but hopefully this is a reusable solution for others!
import {
  ChangeSetType,
  EventSubscriber,
  FlushEventArgs,
  Subscriber,
} from '@mikro-orm/core';

const DeletedPropName = 'deleted';

@Subscriber()
export class SoftDeleteSubscriber implements EventSubscriber {
  async onFlush(args: FlushEventArgs): Promise<void> {
    const changeSets = args.uow.getChangeSets();
    const toRemove = changeSets.filter(
      (cs) => cs.type === ChangeSetType.DELETE,
    );

    toRemove.forEach((cs) => {
      //rewrite deletes for objects that have a deleted prop to soft deletes
      if (DeletedPropName in cs.entity) {
        cs.type = ChangeSetType.UPDATE;
        cs.entity[DeletedPropName] = true;
        cs.payload = { [DeletedPropName]: true };
        args.uow.recomputeSingleChangeSet(cs.entity);
      }
    });
  }
}

I guess this could be a nice article or a recipe in the docs :]
Can we close this or do you see more problems down this path?

The last issue I'm seeing is maybe a misunderstanding on my part--should updates be supported by this pattern?  I'm seeing inserts and deletes as expected, but if I update the contents of one of the existing items (by passing an id that matches an already created item), I am not seeing updates.   I saw https://github.com/mikro-orm/mikro-orm/blob/master/packages/core/src/entity/EntityAssigner.ts#L158 and assumed if I passed merge: true into the options, that it ought to update the data, but it looks like I potentially still have to manually assign for updates to take place...this is probably unrelated to the soft deletes, but running across it right now (can create a separate issue if you think this is a bug).
// what I'd like to do
async update(id: string, newData: EntityData<ParentObject>) {
  const parent = await this.parentRepository.findOneOrFail(id, ["children"]);
  this.parentRepository.assign(parent, newData);

  await this.parentRepository.persistAndFlush(parent);
}

// what I'm doing currently
async update(id: string, newData: EntityData<ParentObject>) {
  const parent = await this.parentRepository.findOneOrFail(id, ["children"]);
  this.parentRepository.assign(parent, newData);

  // handle child updates
  newData.children.forEach(childData => {
    const child = parent.children.getItems().find(item => item.id === childData.id);
    if (child) {
       this.childRepository.assign(child, childData); // could also be wrap(child).assign(childData)
     }
  });

  await this.parentRepository.persistAndFlush(parent);
}

assign is not working recursively, there are multiple issues about that (most recent discussion is here). also merge: true means objects will be treatet as managed entities = merged to the EM. merged entity will never produce any query, as its state was snapshotted during the merge.

Cool, then I think this is good to go.  Thank you for the help with the SoftDelete subscription

v5 break this, need add originalEntity prop to avoid error
import {
  ChangeSetType,
  EventSubscriber,
  FlushEventArgs,
  Subscriber,
} from '@mikro-orm/core';

const DeletedPropName = 'deleted';

@Subscriber()
export class SoftDeleteSubscriber implements EventSubscriber {
  async onFlush(args: FlushEventArgs): Promise<void> {
    const changeSets = args.uow.getChangeSets();
    const toRemove = changeSets.filter(
      (cs) => cs.type === ChangeSetType.DELETE && DeletedPropName in cs.entity,
    );

    toRemove.forEach((cs) => {
      //rewrite deletes for objects that have a deleted prop to soft deletes
      cs.type = ChangeSetType.UPDATE;
      cs.entity[DeletedPropName] = true;
      cs.payload = { [DeletedPropName]: true };
      cs.originalEntity = cs.entity; // this line
      args.uow.recomputeSingleChangeSet(cs.entity);
    });
  }
}

I've wrapped these into a package mikro-orm-soft-delete.
You can enable soft-delete simply by applying a decorator to your entity definitions:
@SoftDeletable(() => User, "deletedAt", () => new Date())
@Entity()
export class User extends BaseEntity<User, "id"> {
  @PrimaryKey()
  id: number;

  @Property({ nullable: true })
  deletedAt?: Date;
}


Add missing bone name return information

A simple PR that improves the documentation for Skeleton3D::find_bone() that explains what will be returned when a bone name wasn't found. This is consistent with MeshInstance3D::find_blend_shape_by_name()

Thanks!


Update commandline sbt publishLocal

With the newest version of SBT, the commandline sbt publish-local should be changed to sbt publishLocal.

+1 for just sbt publishLocal, SBT added the camelCase version and had both for a long time, I wonder if FIRRTL even builds with whatever version of SBT it was before camelCase was added.

Thanks @Jeremygu ! I agree with @edwardcwang and @jackkoenig , its fine to just change 'publish-local' to 'publicLocal'. If you can fix up the PR, we will merge it.


update dependencies and format to 0.9.1

I was going through the dependencies for halogen and found this hadn't been updated. No build errors when I run this on my machine, and it spits out numbers smoothly when running the test.

Should just be "infix" and not "infixr", I think.

Thanks! Don't worry about the build failure, looks like it wasn't set up.


Approach to Deploy an App to Servers Hosted in Azure

The following page uses the "IIS Web App Deployment Using WinRM" task:
https://www.visualstudio.com/en-us/docs/release/examples/other-servers/net-to-vm
However, it states:
"To deploy an app to servers hosted in Azure, see Deploy ASP.NET apps to Azure virtual machines."
https://www.visualstudio.com/en-us/docs/release/examples/azure/net-to-azure-vm
That is, use the Run Powershell Task instead to deploy.
Is there a particular reason why the "IIS Web App Deployment Using WinRM" Task shouldn't be used in the "deploy an app to servers hosted in Azure" scenario?

"IIS Web App Deployment Using WinRM" can be used to deploy a web site on any vm
( local network vm or azure vms) / physical machines.
If you want to any generic deployment other than web site deployment, you can write your own powershell deployment script and use the Powershell On Target Machine task against all machines.

Thanks, it may be worth updating the web page to make it clear that "IIS Web App Deployment Using WinRM" can equally be used for the "deploy an app to servers hosted in Azure" scenario

Thanks for confirmation. We have updated readme that is common for all WinRM tasks under notes section https://github.com/Microsoft/vsts-rm-extensions/blob/master/Extensions/IISWebAppDeploy/Src/README.md


updated to new msgq_poll

msgq_poll can work as expected after https://github.com/commaai/cereal/pull/366

don't know why the test_rotation failed.I'm pretty sure it's not the cereal's problem.

don't know why the test_rotation failed.I'm pretty sure it's not the cereal's problem.


Output is triggered after every poll cycle

Hi,
I don't think it's a good idea that the status is constantly triggered at the output, at least there should be the possibility to turn this off and set a time interwall.
I have to filter this constant output trigger in a cumbersome way!

I will add a flag for that

Ok, but otherwise it's a great node, thanks for the work!

perhaps I have not expressed myself correctly,
if I manually query a status, this should still work, the other two flags should then be a time interval, on the other hand this should also be able to be switched off completely without preventing the manual status query, thx

understood... however you should set the polling interval to 0 in your use case as you are only triggering it yourself, or?

richtig, ok, setze es auf 0 ;) danke schon mal

Version 4.1.0 should fix this

Thx,it work!!!


[core] Support aggregation system table

Purpose
Support Aggregation system table.

Tests

API and Format

Documentation

@JingsongLi  PTAL,thanks.

@JingsongLi PTAL,thanks.


Update AbstractBaseShader to Foundry VTT 0.7.9

Which class should be updated?
AbstractBaseShader
For which version should the class be updated?
Foundry VTT 0.7.9

taking this

Fixed by #276


Merge bitcoin#9963: util: Properly handle errors during log message formatting

Decided to break this off the main set since it should have been in like pr2 and I missed it. I could cherry-pick this into pr10 if wanted
b651270 util: Throw tinyformat::format_error on formatting error (Wladimir J. van der Laan)
3b092bd util: Properly handle errors during log message formatting (Wladimir J. van der Laan)
Tree-SHA512: 85e3b7afec2255fc88034187f1abd6060e9421de17ed4e3d918416f393429a99cc2c974b362099aaaff6970549df47664bea4c857c4e46acc0789663201dc541

llmq/quorums.cpp:215:21: note: in expansion of macro 'LogPrint'
                     LogPrint("llmq", debugMsg);

https://travis-ci.org/dashpay/dash/jobs/531315434#L2159


DCOS-44017: rename Version to Mesos Version

Rename Version to Mesos Version in master tab.
Closes DCOS-44017.
Testing

Go to Nodes > Master tab
You should see "Mesos Version" in the Leader grid

Trade-offs
None

:tada: This PR is included in version 2.36.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Unable to save to folder in nas

Affected part
Connection (login/fetching)
Extension version
3.16.1
DSM version
DSM 7.2.1-69057 Update 5
Browser version
128.0.6613.138 (Official Build) (arm64)
Description
I am unable to save to folder on nas when I try to right click add to synology diskstation. It says failed to load folder. This was after I upgraded from DSM 7.0.3 to 7.2.1
I have tried to use the competing plugin "NAS download manager" and it was able to do pass the file to synology diskstation to download with no problems.
Steps to Reproduce the Issue
Right click on link to file you want to download and just click add to Add to Synology Diskstation.
Screenshots or Mock up

Failure Logs
No response
Store snapshots
No response

If you can log in but not load folders,  it usually means it's a permission issue on the NAS side.
I'm running 7.2.1-69057 Update 5 also on my side without trouble.
Did your logged users or permissions change by any chance ?
Note that download station (allow downloads) and file station (folder read/write) are two separate permissions and require two separate services to be installed on the NAS


hid schedule from AppBar

schedule page endpoint still up but users will not see it as it is no longer in navbar.
Fixes #439

Made scheduleAvailable depend on constant.js

@jakobreinwald do we want to hide the schedule from the nav bar? I thought we keep it in the nav bar and just have the ComingSoon component rendered on page.


Error in examples/solve_with_bp.jl

With latest master I get the following. I suspect the re-working of file IO has broken this example, but I'm also not sure what the intent of the latter part of this file.
If I comment out https://github.com/jeremyomer/KidneyExchange.jl/blob/e8fd74820acdbccf3f07348dce7bc183bf02f9e3/examples/solve_with_bp.jl#L43 and any of the lines at or following https://github.com/jeremyomer/KidneyExchange.jl/blob/e8fd74820acdbccf3f07348dce7bc183bf02f9e3/examples/solve_with_bp.jl#L50 the file seems to run again.
Error message:
% ~/opt/julia-1.10.1/bin/julia examples/solve_with_bp.jl
ERROR: LoadError: MethodError: no method matching read_wmd_file(::String)

Closest candidates are:
  read_wmd_file(::Any, ::Any)
   @ KidneyExchange ~/.julia/packages/KidneyExchange/07zMq/src/instance/matching_instance.jl:205

Stacktrace:
 [1] top-level scope
   @ ~/src/git/KidneyExchange.jl/examples/solve_with_bp.jl:43
in expression starting at /home/wpette/src/git/KidneyExchange.jl/examples/solve_with_bp.jl:43

Hi William, I had some explanation by the original authors of the package. They told me that the preflib file format changed during the developpement of the package and they did not want to upgrade it because their results in the paper were made with the old format. I tried to manage this new preflib format and keep the old behaviour for people who want to reproduce the paper simulations. That's why I created this example.
If you run julia with MD files in the working directory, it works. I fixed the path to these files in #24

$ julia --project examples/solve_with_bp.jl
  3.159530 seconds (3.00 M allocations: 196.175 MiB, 7.54% gc time, 99.63% compilation time: 4% of which was recompilation)
  0.005093 seconds (10.55 k allocations: 443.266 KiB)


upload headshot

Docs Build status updates of commit da07260:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

advocates/media/profiles/gomolemo-mohapi.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Alias not supported on update method

As a user, I would like to be able to build an update statement with a join.
An example SQL query:
UPDATE table AS t
INNER JOIN another_table AS at ON t.id = at.tableID
SET t.isActive = 1
WHERE at.isActive = 1

ideally should be built using
$query = new Query();
$query->update('table', 't')
->innerJoin('another_table', 'at', 't.id=at.tableID')
->set('t.isActive=:isActive')->setVar('isActive', 1)
->andWhere('at.isActive', 1)

In addition, It would be great if we can bind values directly like this
->set('t.isActive', 1)

instead of this
->set('t.isActive=:isActive')->setVar('isActive', 1)

The bug is fixed in the new version: 1.2.2
Thanks :)

The bug is fixed in the new version: 1.2.2
Thanks :)


Strengthen ARCbox security posture leveraging my IP address to avoid open Internet exposure

Is your feature request related to a new Jumpstart scenario you would like to contribute?
That's great! Use our Jumpstart Scenario Write-up Guidelines
https://azurearcjumpstart.io/scenario_guidelines
Is your feature request related to a problem? Please describe.
Azure ARCBox deployment is triggering alerts from my Security Operation Center due to open port to the Internet.
Describe the solution you'd like
Leverage My IP address parameter provided during ARCBox provision to restrict network security rules and avoid open Internet access during default installation (at least for SQL and PostreSQL - port 5432 and 1433)
Describe alternatives you've considered
Doing it manually but it is prone to error and I suspect my SOC team will be fed up as there will be more colleague who will experiment with ARCBox
Additional context
Add any other context or screenshots about the feature request here.

Thank you @cbezenco, makes sense.
@dkirby-ms @mdrakiburrahman we need to implement this for ArcBox and the Azure-based data scenarios for now. After that, we should assess the impact on app services scenarios.


Changing font color of "FEEDING PAWS" page in dark mode

Changing the font color of the "FEEDING PAWS" page in dark mode to increase the visibility of the text.

Cool!

Are you a LGMSOC participant?!

Are you a LGMSOC participant?!

Yes sir, I am!

@drishika2002 , please submit a PR by tomorrow

@drishika2002 , please submit a PR by tomorrow

Done sir! Please tell if something has to be changed.


Session days for Las Vegas Grand Prix are incorrect

Describe the bug
When calculating the day for the various sessions of the Las Vegas Grand Prix to EU times, all days are shown as one too early (i.e. it says Thursday instead of Friday, etc.).
Secondary issue: There is no track map being displayed for the LV circuit.
Expected behavior
Session times showing the correct day.

The API does that. Can't do anything about ut sorry


createTransaction() will fail if the payment amount is a string

Childchain.createTransaction() allows you to pass payment.amount as a string or a number, but it will fail in the Watcher
if it's a string.
E.g. this fails
{
  owner: '0x0',
  payments: [ { owner: '0x0', currency: '0x0', amount: '300000'} ],
  fee: { currency: '0x0' }
}

but this succeeds
{
  owner: '0x0',
  payments: [ { owner: '0x0', currency: '0x0', amount: 300000} ],
  fee: { currency: '0x0' }
}

The solution is to either

Only accept number (or BigNumber) as types for payment.amount
Keep accepting String, but convert it to number before calling the watcher api

leaning towards option 1. also since passing an unsafe integer doesn't give the most descriptive error message when integer validation fails.
should also test this behavior on childchain.sendTransaction as thats the other one that accepts the payments object.
we may also want to only accept BN across our entire api to reduce confusion of these multiple types, ie the rootchain module and transaction helpers

I'm supportive of 1, it's easier to document.
However, if we do decide to stick with 2, perhaps something like property based testing could protect us from issues like this one across our APIs in the future?

Hello people :). I am having issues when i pass "amount" when is less than 0.1 :/.


HLS intersection: a workable version with sort method

Table intersection has two methods:

Hash  --> Change the hash_used array from 512b width to 256b width for timing.
Sort  -->  a workable sort-merge method which has three levels: (a) uses local BRAM to do bubble sort in parrallel in a small scale (b) then do merge-sort in DDR memory (c) do intersection from two sorted table.

To save resource and fix timing, the two methods are not implemented at same time. Need to assign action_intersect_hls.H line 22 USE_HASH or USE_SORT as a switch.

Also picked up the memcopy performance enhancement and address64 bug #320.
Now the memcopy AXI burst length increased to 32.

Picked up the same header file from software/examples/action_intersect.h

Hi for the IMG checking fails, I see some
CRITICAL WARNING: [Common 17-741] No write access right to the local Tcl store at '/afs/bb/u/fpga/.Xilinx/Vivado/2016.4/XilinxTclStore'. XilinxTclStore is reverted to the installation area. If you want to use local Tcl Store, please change the access right and relaunch Vivado.
ERROR: [Common 17-1257] Failed to create directory '/afs/bb/proj/fpga/xilinx/Vivado/2016.4/tclapp'.
	[CREATE_IPs..........] start
ERROR: [Common 17-69] Command failed: ERROR: [Common 17-39] 'tclapp::load_apps' failed due to earlier errors.
make: *** [create_environment] Error 1

Who will check them?


Fix the code so that it follows standard.js

http://standardjs.com/

#niklasmh was this done last meeting?

Yes, I think I converted all the JS we are going to work on later.


Add query execution plan extensibility APIs

Here are the new extensibility APIs defined in this PR.  I'll add additional APIs to control query options in another commit.
export interface QueryInfoListener {
	providerId: string;

	onExecutionStart(fileUri: string): void;

	onExecutionComplete(fileUri: string): void;

	onExecutionPlanAvailable(fileUri: string, executionPlan: string): void;
}

export namespace queryeditor {
	export function registerQueryInfoListener(listener: QueryInfoListener): void;

	export function createQueryTab(fileUri: string, tab: window.modelviewdialog.DialogTab): void;
}

Here's an example custom query tab from the sample in the PR.

I'm going to use this PR for the query execution plan extensibility work.  This PR isn't ready for merge, but I wanted to publish to get feedback on the general event listener approach.

Here is another possible API for this functionality.
// existing DMP interfaces
// Notes: currently there are execution options to turn on estimated and actual query plans.
// This is fine for immediate requirements, but we'll probably want to make this more generic
// to support additional options.
export interface ExecutionPlanOptions {
	displayEstimatedQueryPlan?: boolean;
	displayActualQueryPlan?: boolean;
}

export interface QueryProvider {
	runQuery(ownerUri: string, selection: ISelectionData, runOptions?: ExecutionPlanOptions): Thenable<void>;
}

// new extensibility interfaces
export interface QueryDocument {
	providerId: string;

	fileUri: string;

	// tab content is build using the modelview UI builder APIs
	// probably should rename DialogTab class since it is useful outside dialogs
	createQueryTab(tab: window.modelviewdialog.DialogTab): void;
}

export interface QueryInfoListener {
	// instead of having start, stop, planavailable, batchavailable, etc. methods
	// have a single method with a type parameter.
	// another alternative is to have seperate methods for common actions: start, stop, etc.
	// and then have generic method for misc. events
	onQueryEvent(type: string, editor: QueryDocument);
}

// query editor extensibility namespace
export namespace queryeditor {

	// existing method
	export function runQuery(fileUri: string): void;

	// new methods
	export function runQuery(fileUri: string, options: Map<string, string>): void;

	export function registerQueryInfoListener(listener: QueryInfoListener): void;
}

Is there a reason we couldn't use vscode menu contribution points for the toolbar?

@anthonydresser Kevin mentioned that too during our review meeting, and I still need to follow-up.  I think the basic reason would be along the lines of a toolbar not being a menu, so it may not make sense to overload the one to be treated as the other (for example, menus can have submenus, which doesn't make sense for toolbars, and perhaps other differences).
Do you know if VS Code is using menu contributions to represent buttons anywhere else?

The editor buttons are via menu contributions

I think its editor/title

@anthonydresser @kevcunnane if this is what VS Code is doing elsewhere then it probably makes sense to stay consistent.  I'll take a look and update the notes above.  The toolbar support will come in through a separate PR, so there will be another chance to review those details.

So - I took a look at your PR and actually think long term toolbar might make sense. Primary reason is menus only work for buttons. We need to extend long term to support drop downs and other non-button features (even sticky / toggle buttons). That might be better done via a new contribution point. Apologies for flip flopping on this one!

Let's take this with the current scope of changes and then do the query options and toolbars separately as discussed above.  If I missed any comments please leave them on the next PR.


added new script for turtle tests

adds new DSL groovy scripts for drools and optaplanner turtle tests
adds new script to seed job

Jenkins retest this please

Jenkins retest this please


Release underlying resources when JS instance is GC'ed on Android try 2

Summary
Reland https://github.com/facebook/react-native/pull/24767
The commit had to be reverted because it caused a crash when using remote debugging in chrome. This is normal since jsi is not available in that environment. The crash was caused by jsContext.get() being 0, then being dereferenced later in c++. We can simply skip initializing the blob collector in this case.
This also includes the fix from #25720 to fix a crash when using hermes.
Changelog
[Android] [Fixed] - Release underlying resources when JS instance is GC'ed on Android
Test Plan
Test using RN tester with jsc and hermes
Test remote debugging

cc @makovkastar

@makovkastar Any change you can have a look at this again?

Hi Janic, I've been busy lately with some Fabric work and didn't have time to look into it. I will try to check it this evening, but no promises.

Will this be backported to 0.60? This was a huge issue on our app and has caused a lot of lost engineering resources for us..
This merges with relatively little merge conflicts on 0.60-stable, see https://github.com/mcuelenaere/react-native/tree/backport/android-blob-gc-0.60

Any idea how soon can we get this? We have been waiting for this one for a long time. Will be great if someone can look at the broken tests so this can go in?

This PR was accepted and now there are some internal tests being run before merging this. I will try to get this merged today.

Thanks @makovkastar and @janicduplessis for resolving this. Looking forward to having this in the upcoming release. Any idea when that might be?

@talha-ahmed I'll try to get it cherry-picked in the next 0.60.x release

To people who are interested in this, we are keeping track of these changes at https://github.com/getdelta/react-native/tree/0.60-patched (prebuilt Android binaries are available at https://github.com/getdelta/react-native/tree/0.60-patched-prebuilt)

This didn't get picked in 0.60.6. Can this please be released soon?


Added URL instance property for CLIRequest class

In the Services.php file, the URL instance is passed to CLIRequest constructor but it not in use in the CLIRequest class. Consequently calling $this->request->url in the controller throws an exception when you access the app from command line $ php index.php [controller]. This is in the Services.php file under system config
/**
	 * The CLI Request class provides for ways to interact with
	 * a command line request.
	 *
	 * @param \Config\App $config
	 * @param bool        $getShared
	 *
	 * @return \CodeIgniter\HTTP\CLIRequest
	 */
	public static function clirequest(\Config\App $config = null, $getShared = true)
	{
		if ($getShared)
		{
			return self::getSharedInstance('clirequest', $config);
		}

		if (! is_object($config))
		{
			$config = new \Config\App();
		}

		return new \CodeIgniter\HTTP\CLIRequest(
			$config, new \CodeIgniter\HTTP\URI()
		);
	}

I also discovered that $uri->getSegments() returns empty array.  I assume because the request was from command line.  I fixed this in the CLIRequest constructor but it is not in this pull request. Since it was written that one change per request in the guidelines.
/**
	 * Constructor
	 *
	 * @param App $config
         * @param URI $uri
	 */
	public function __construct(App $config, $uri = null)
	{
		parent::__construct($config);

		// Don't terminate the script when the cli's tty goes away
		ignore_user_abort(true);

                $this->uri = $uri;
		$this->parseCommand();

                //set url path based command on parsed argument, this sets the segments
                $this->uri->setURI($this->getPath());
	}

While that might fix an error - it won't get you correct information from the URI instance. CLI requests don't have the same concepts as an HTTP request that has gone through a server and has additional information that the URL can be built through. That's why there's not support for the URI object.
I'll remove the URI instance being passed in so there's no confusion. It appears to be an artifact left over from earlier days.


Proxy release 2024-02-29

Proxy release 2024-02-29
Please merge this Pull Request using 'Create a merge commit' button

Reviewed for 03-01-2024 changelog


Support multiple input files

Supporting *.proto as input instead of only single files will make this tool much easier to use.

It should already support that as far as it supports multiple .proto as arguments and it's usually the shell that expands the wildcard syntax rather than individual applications.

On windows, cmd, it does not allow this (while protoc does)

No flag for this feature, always on.
Let me know how it works


Remove ccache

All modification operations are async; there's no way of knowing a put/delete took. Garbage.

lgtm

lgtm

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@47cb8a0). Click here to learn what that means.

@@            Coverage Diff            @@
##             master    #7304   +/-   ##
=========================================
  Coverage          ?   64.93%
=========================================
  Files             ?      230
  Lines             ?    20728
  Branches          ?        0
=========================================
  Hits              ?    13460
  Misses            ?     6273
  Partials          ?      995

Impacted Files
Coverage Δ

proxy/grpcproxy/metrics.go
100% <100%> (ø)

proxy/grpcproxy/kv.go
25.78% <20%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47cb8a0...1fe2a9b. Read the comment docs.

failures unrelated, merging


use stable windows installer URL

What does this PR do?

Change the Windows Installer URL used by E2E tests to the public stable URL. The mstesting URL currently used is periodically purged of older agent versions.
Motivation

https://datadoghq.atlassian.net/browse/WINA-708
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Remove facebook plugin (deprecated 5.0) completely

1. Why is this change necessary?
As in migration 630 a deprecated plugin can be safely removed.
2. What does this change do, exactly?
Copies migration 630 and replace Google with Facebook. It deletes an s_core_plugin entry that has been deprecated since 5.0.
That could've been done almost 4 years ago with migration 630 (deprecated since April 2015).
3. Describe each step to reproduce the issue or behaviour.

Look for not installed plugins in backend plugin manager
Look for not installed plugins via SQL as it is easier to copy into a script
Be confused why you get one more result in SQL than in plugin manager
:male_detective:

4. Please link to the relevant issues (if any).
Finally I can link an issue.
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-24863
Please use this issue to track the state of your pull request.

Thanks for your Contribution! :blue_heart:
Please test next time your Migration before submitting, there was an typo :see_no_evil:

Woops. Didn't see it, just copied things over from an other migration. On the other hand: why didn't the automation catch this? :D


Editor Crash when Draging in a .wad file to the same folder that you are importing a .map file.

Description:
When Importing a .map file and a .wad file to the same folder it will cause an editor crash.
How to reproduce:
Drag in a .wad file to a folder then drag in a .map file to the same folder that you dragged the .wad file to. It should cause an editor crash.
Expected result:
No Crash and the .Map file should be imported.

I got some additional info for you to fix the issue. :)
QUnreal_Testbed_2.log

Unhandled` Exception: EXCEPTION_ACCESS_VIOLATION reading address 0x00007ffccc229278

VCRUNTIME140
UnrealEditor_Core!FString::ToUpper() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Private\Containers\String.cpp.inl:518]
UnrealEditor_QUnreal!UQuakeMapAsset::LoadMapFromFile() [D:\UE5_Projects\5_4\CompilePls\Plugins\QUnreal\Source\Qunreal\Private\QuakeMapAsset.cpp:81]
UnrealEditor_QUnrealED!UQuakeMapAssetFactory::Reimport() [D:\UE5_Projects\5_4\CompilePls\Plugins\QUnreal\Source\QUnrealED\Private\QuakeMapAssetFactory.cpp:101]
UnrealEditor_UnrealEd!FReimportManager::ReimportAsync() [D:\build\++UE5\Sync\Engine\Source\Editor\UnrealEd\Private\Editor.cpp:493]
UnrealEditor_UnrealEd!FReimportManager::Reimport() [D:\build\++UE5\Sync\Engine\Source\Editor\UnrealEd\Private\Editor.cpp:282]
UnrealEditor_UnrealEd!FImportFilesByPath::Run() [D:\build\++UE5\Sync\Engine\Source\Editor\UnrealEd\Private\Subsystems\ImportSubsystem.cpp:88]
UnrealEditor_UnrealEd!UImportSubsystem::HandleNextTick() [D:\build\++UE5\Sync\Engine\Source\Editor\UnrealEd\Private\Subsystems\ImportSubsystem.cpp:174]
UnrealEditor_UnrealEd!V::TBaseUObjectMethodDelegateInstance::Execute() [D:\build\++UE5\Sync\Engine\Source\Runtime\Core\Public\Delegates\DelegateInstancesImpl.h:650]
UnrealEditor_Engine!FTimerUnifiedDelegate::Execute() [D:\build\++UE5\Sync\Engine\Source\Runtime\Engine\Public\TimerManager.h:50]
UnrealEditor_Engine!FTimerManager::Tick() [D:\build\++UE5\Sync\Engine\Source\Runtime\Engine\Private\TimerManager.cpp:940]
UnrealEditor_UnrealEd!UEditorEngine::Tick() [D:\build\++UE5\Sync\Engine\Source\Editor\UnrealEd\Private\EditorEngine.cpp:1624]
UnrealEditor_UnrealEd!UUnrealEdEngine::Tick() [D:\build\++UE5\Sync\Engine\Source\Editor\UnrealEd\Private\UnrealEdEngine.cpp:550]
UnrealEditor!FEngineLoop::Tick() [D:\build\++UE5\Sync\Engine\Source\Runtime\Launch\Private\LaunchEngineLoop.cpp:5921]
UnrealEditor!GuardedMain() [D:\build\++UE5\Sync\Engine\Source\Runtime\Launch\Private\Launch.cpp:180]
UnrealEditor!GuardedMainWrapper() [D:\build\++UE5\Sync\Engine\Source\Runtime\Launch\Private\Windows\LaunchWindows.cpp:118]
UnrealEditor!LaunchWindowsStartup() [D:\build\++UE5\Sync\Engine\Source\Runtime\Launch\Private\Windows\LaunchWindows.cpp:258]
UnrealEditor!WinMain() [D:\build\++UE5\Sync\Engine\Source\Runtime\Launch\Private\Windows\LaunchWindows.cpp:298]
UnrealEditor!__scrt_common_main_seh() [D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288]
kernel32
ntdll

should be resolved by the most recent commit. could you please confirm that it works now @HeadClot ? :-)
thx for reporting this.

This has been resolved :)


Uniffi android controller

Credits to @gmulhearn for simplifying the android code by adding a controller. :rocket:
Merge after #970

Codecov Report

Merging #984 (339f7ec) into main (9b7ce90) will decrease coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 339f7ec differs from pull request most recent head f890b30. Consider uploading reports for the commit f890b30 to get more accurate results

@@            Coverage Diff             @@
##             main     #984      +/-   ##
==========================================
- Coverage   28.89%   28.88%   -0.01%
==========================================
  Files         419      419
  Lines       25981    25981
  Branches     5228     5232       +4
==========================================
- Hits         7506     7504       -2
  Misses      16271    16271
- Partials     2204     2206       +2

Flag
Coverage Δ

unittests-aries-vcx
28.88% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

Nice, let me know once this has been rebased and ready to review 👌. Also, please make sure that the CI lint checks are satisfied


Clarity on ledger state queries

Hello there. I am trying to wrap my head around some of the "new" queries that are now available through the state query protocol. New queries aren't as documented as the old ones, so it's a bit hard to figure the exact intent and to know whether they are meant to stay or were perhaps temporary endpoints.
If this question belongs to input-output-hk/cardano-ledger, please bring the right people in 🙏
I am mostly intrigued by the following:

GetRewardInfoPools: seems to be returning pieces used for the reward calculation of pools in the ongoing epoch e. In particular, the stake, I assume, refers to the stake that was marked at the beginning of epoch e - 2, used for leader schedule in e - 1 and thus producing rewards in e. Same for the pool parameters.

GetPoolState: seems to contain maps of the current state of the system w.r.t to pools, deposits & al.

GetStakeDelegDeposits: seems redundant with GetPoolState as the latter already contains a map of all deposits indexed by pool id. What's the rationale for having these two queries?

GetPoolDistr & GetStakeSnapshots: these two seem somewhat redundant with one another. The GetStakeSnapshots is pretty well documented so there isn't much ambiguity. GetPoolDistr however says that it contains (relative) stake for a "given epoch". To what stake snapshot are we referring here? Mark, set or go? Would both queries remain as part of the protocol, or is there any intend already to deprecate one of the two?

GetStakeDistribution: sounds like a diminished version of GetPoolDistr, since the latter allows for an extra filter (set of pool ids) to, I imagine, restrict the result to those only.

Thanks!

@lehins @newhoggy @HeinrichApfelmus the git blame indicates that you introduced/last-updated the queries that Matthias mentioned above. Would you be able to answer some of his questions?

@lehins @newhoggy @HeinrichApfelmus Anyone???

I did not personally write any of those queries, but I could go through them and document them. However we are extremely busy right now, so this is a bit lower down the priority list.
So, give us some time we'll clarify them.


chore(deps): Upgrade typescript to 4.7.4

Description
Almost the entire PR is handling errors from try...catch statements which are now type unknown but we often assume them to be type Error. I wrote a small helper function, ensureError to handle these cases.
4.7.X is the minimum version we need for typechain https://github.com/dethcrypto/TypeChain/tree/master/packages/target-ethers-v6
Test plan
Updated all unit tests

@jophish This is all necessary because previously catch(error) was type any and now it defaults to unknown as of typescript 4.4. more on that here
I was inspired by this article for the ensureError solution. We would at minimum have to do something like if(err instanceof Error) everytime we access err.message but then what do we do in the else case? I thought it cleaner to add a helper like this.
we do in at least one place throw non-Error types on purpose


[ RFC ] New Task Workflow

Project Description

This project will allow the tasks of Real Dev Squad to be handled in an efficient way. Each task can be in one state such as completed, blocked, etc. This project will allow us to have a new set of states that a task can be in and a few things will be automated such as if a member could not complete a task within the given period of time, the task will be unassigned from the member and it will be available for other members to be picked up.
The current status that a task can be in:- active | assigned | unAssigned | blocked | completed | High Priority | pending
changes:- active → IN_PROGRESS, unAssigned → AVAILABLE
This feature allows the task status to be in- AVAILABLE | ASSIGNED | IN_PROGRESS | BLOCKED | SMOKE_TESTING | COMPLETED | NEEDS_REVIEW | IN_REVIEW | APPROVED | MERGED | SANITY_CHECK | REGRESSION_CHECK | RELEASED | VERIFIED
Reference 👇🏻
https://app.creately.com/diagram/heYDw2DIsqh/view
Tasks

website-backend

Make the task’s status to accept any of these values
AVAILABLE | ASSIGNED | IN_PROGRESS | BLOCKED | SMOKE_TESING | COMPLETED | NEEDS_REVIEW | IN_REVIEW | APPROVED | MERGED | SANITY_CHECK | REGRESSION_CHECK | RELEASED | VERIFIED
(Right now it can accept any value)

create an endpoint that fires a function that loops through all tasks whose status is ASSIGNED | IN_PROGRESS and if endsOn < currentTime SET task’s status  back to AVAILABLE, assignee field to be cleared and log the member and task details (For future use)

migration script to make active → IN_PROGRESS, unAssigned → AVAILABLE(Does not need any changes on status except availability panel)

website-status

On the availability panel render only tasks that are available not unAssigned(handle it before migration such that both AVAILABLE and unAssigned works)

When the task is assigned to a member from the availability panel make the status of the task as ASSIGNED  and startedOn should be computed and endsOn should be 14 days by default

website-dashboard

Remove startedOn input field from the form, and  endsOn input field will be hidden by default

default status field  should be AVAILABLE

when the status field is selected as assigned show assignee field and make it compulsory and show endsOn date and default endsOn date is 14 days

When a new task is created startedOn will be computed if the task is assigned else ignored

website-members

Makes use of the task’s status(Active) on members profile Active tasks section need to make it work either (Active || IN_PROGRESS)

Should we make AVAILABLE as UNASSIGNED  ?

Subtasks

Make tasks values accept a set of particular values. AVAILABLE | ASSIGNED | IN_PROGRESS | BLOCKED | SMOKE_TESTING | COMPLETED | NEEDS_REVIEW | IN_REVIEW | APPROVED | MERGED | SANITY_CHECK | REGRESSION_CHECK | RELEASED | VERIFIED
Create a UI filter on the frontend to filter Idle members based on their roles (MEMBER | USER)
Add Functionality to change the status of any task. For example:- changing the task back to AVAILABLE or Extending the ETA of any task
Store every event of the task . Events like assigned, extended, etc.
Create a button for every task on UI to see the previous tasks.

Note- although there are going to be minimal to no conflicts in terms of completing these tasks unordered, but the best optimal way would be to go in the ordered as mentioned.


By-proxy generation, element list proxy improvement, xpath utility functions, findBy* utility functions, DOM relational functions

XPath generation from element
Javascript based. Generates absolute xpath from root of document to target element.

open("http://jkorpela.fi/www/testel.html");
WebElement example1 = driver().findElement(By.className("hyphenate"));
String xpath = xpathOf(example1);
System.out.println("xpath = " + xpath); // xpath = /HTML/BODY[1]/P[20]

Dynamic proxy generation based on existing elements
Using By-decoration and above XPath generation, this enables to create proxy elements based on naked-ones.
open("http://jkorpela.fi/www/testel.html");
WebElement example2 = driver().findElement(By.className("hyphenate"));
WebElement proxy = proxyOf(example2);
navigateRefresh();

System.out.println("textIn(proxy) = " + textIn(proxy));
// textIn(proxy) = Until recently the great majority of
// naturalists believed that species were immutable productions,
// and had been separately created. This view has been ably maintained by many authors.

Initial DOM relationship functions
Simple functions like parent, children, siblings etc.
open("http://jkorpela.fi/www/testel.html");
WebElement example3 = driver().findElement(By.className("hyphenate"));
WebElement parent = parentOf(example3);
WebElement grandParent = parentOf(parent);

System.out.println("isParentOf(parent, example1) = "
    + isParentOf(parent, example3)); // true
System.out.println("isParentOf(grandParent, parent) = "
    + isParentOf(grandParent, parent)); // true
System.out.println("isParentOf(grandParent, example1) = "
    + isParentOf(grandParent, example3)); // false
System.out.println("isDescendandOf(grandParent, example1) = "
    + isDescendantOf(grandParent, example3)); // true

Page root and Page Object support
Some basic HTML root-oriented functions. May be useful in code like do { textIn(elem); elem = parentOf(elem); } while(!isPageObject(elem)); or something.
open("http://jkorpela.fi/www/testel.html");
WebElement example4 = driver().findElement(By.tagName("html"));
System.out.println("isDocumentRoot(example4) = " + isDocumentRoot(example4)); // true

if(isPageObjectDefined()) {
    System.out.println("Page Object is defined!");
    WebElement pageObject = parentOf(example4);
    System.out.println("isParentOf(pageObject, example4) = "
            + isParentOf(pageObject, example4)); // true
    try {
        System.out.println("textIn(pageObject) = " + textIn(pageObject)); // exception
    } catch(Exception ex) {
        System.out.println("You can't call functions on Page Object!\n"
                + "Use it only in referential context.");
    }
}

Relative XPath support
This could maybe be useful in WebComponents. Keeping reference to one element, we can find any other element that didn't change position relatively to one we keep.
WebElement example5 = driver().findElement(By.xpath("/html/body/ul[2]/li[22]/sup[6]/sup"));
WebElement another = driver().findElement(By.xpath("/html/body/address[1]/a[2]"));

System.out.println("from example5 to another = " + relativeXPath(example5, another));
    // from example5 to another = ./../../../../ADDRESS[1]/A[2]
System.out.println("from another to example5 = " + relativeXPath(another, example5));
    // from another to example5 = ./../../UL[2]/LI[22]/SUP[6]/SUP[1]

XPath validation
Simple and quick xpath validation using XPathExpression
String example6 = "/html/$$$";
String another = "/html/i/dont/exist/but/am/valid";
System.out.println("isValidXPath(example6) = " + isValidXPath(example6)); // false
System.out.println("isValidXPath(another) = " + isValidXPath(another)); // true

Proxy lists now contain proxy elements
Core change. DefaultFieldDecorator for naked elements created proxy elements, and for naked element lists created proxy lists of naked elements. This change alternates second one, making it create proxy list of proxy elements.
@FindBy(xpath = "html/*")
List<WebElement> elements;

public void run() {
    open("http://jkorpela.fi/www/testel.html");
    WebElement example7 = elements.get(1);

    navigateRefresh(); // before would invalidate example7
    System.out.println("textIn(example7) = " + textIn(example7)); // works ok, before would throw

}

Proxy-returning findBy* functions
I thought i could write simple function findElement("..."), which would test if argument is valid XPath or Css Selector and perform search, but it appeared to be really hard. Many XPaths are considered valid Css Selectors and vice versa, so some higher logic would be needed here. As alternative, I added multiple functions that return By-decorated proxies, and make it easier to write simple dynamic searches, changing driver.findElements(By.xpath("/html/body/div[3]/a") to findByXPath("html/body/div[3]/a"), making it shorter and safer.
WebElement example8 = findByXPath("/html/body/address[1]/a[2]");
WebElement another = findByCssSelector("body > address:nth-child(18) > a:nth-child(2)");

navigateRefresh();

//still ok :)
System.out.println("example8.equals(another) = " + example8.equals(another));

I was not sure which of these functions should be in Bot and which in BotUtils, so I placed them all in BotUtils for time being.

Wow, first great work and sorry for the delay here.
Second I'm not totally 100% sure about everything in this commit and I will not have time to look into this right now, so if I merge this do you feel like maintaining it with me? I'll add you to the organisation.
About the Bot and the BotUtils class the thoughts are that the Bot contains methods that are meant to be used by the end user and the BotUtils contains methods used internally by the Bot. E.g. getDecoratedElement maybe belongs to the BotUtils while findByXPath is more ment for the end user of the framework so therefore it should belong in the Bot.
Also maybe this should be documented in the README as well.

Thanks for explaining. I'm sure there is room for improvement and I would gladly help maintaining. When I have some time I'll update the README.

Great I'll try to merge this then and release it in the weekend

I just noticed that i accidentally added new commits unrelated to this pull request, so I rebase'd them away.  Sorry for late noticing.


feat: editable playground environment

Fixes FER-3328
Short description of the changes made

Allows environments to be edited in api reference and api playground; updates snippets and resolution for use in other methods.
Introduces PLAYGROUND_ENVIRONMENT_ATOM, which allows for the storage of an environment URL that persists across loads.
Basic validation on input url (make sure it is well formatted for parsing downstream logic).

What was the motivation & context behind this PR?

Customer asks

How has this PR been tested?
https://github.com/user-attachments/assets/c2a7ec9a-35d1-4cee-b9b8-6e9a42962d32

@RohinBhargava nice! but there's a couple ux bugs from your video:

why did double clicking app.sg.workato.com switch to www.workato.com?
it was a bit odd that double clicking the environment ended up causing the basepath to be editable as well. i think the button should encapsulate the basepath so it's clear that both are editable
the font size should be the same between the rendered environment (inside the button) and the text input.


General sip Settings : Local Networks

Hello,
Can anyone provide me with the information of how should i configure my local networks and external address?
I am using bridge network
Thank you

Did you have some problem with automatic configuration?


Adds flushing after each buffer write in case of text/event-stream

Adds flushing after each buffer write in RestClientProxyExchange in case of text/event-stream to fix issue #3410

not working


Result Set Viewer: Filter icons overlap column's name

System information:

DBeaver version 21.2.3

Describe the problem you're observing:
If column name is longer than column width it will merge with icon

verified


Adding Envoy Gateway project example and reference

Adding Envoy Gateway project, tested example and reference to https://gateway.envoyproxy.io/

Thanks! Could you please sign your commits in order to fix DCO ?
See https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md


Typing speed game

Closes #417
Description:

Build a smooth typing speed tester game using Vanilla JavaScript. Learn to build better logics and implement JS in real life project.

Resource URL:

Tutorial, source code, demo

Tutorial - https://youtu.be/E_tZH9R_zi8?si=9sSTElTnNMM-aLW_
Source code - https://github.com/ThisIsSahaj/Js-Games/tree/main/TypingSpeed
Working Demo - https://thisissahaj.github.io/Js-Games/TypingSpeed/index.html

Checklist:
Before submitting your pull request, ensure that you have completed the following tasks:

[X] I have carefully reviewed and adhered to the contributing guidelines before creating this pull request.
[X] I followed the prescribed PR title template.

Please add it under this section. Please take a look the sections to get an idea on how the resource should look like. Please click the resource.
You should only modified the readme.md of web development category, you should not add anything, add only the URL and description

I have done exactly how you are asking it to do. I have added it under the Projects Beginner section


Regression in spitting out wrong jr targets

commit 298ccf7372c491ec7c0c119f2aba2faf9b7edc2c has caused a regression regardling how jr targets are calculated in non-tiny mode.
Building a disassembled pokemon crystal, for example, causes these errors:
$ make
rgbasm  -o game.o game.asm
rgblink -n game.sym -m game.map -o game.gbc game.o
error: game.asm(97) -> bank_04c.asm(14288): jr target out of reach (expected -129 < -16328 < 128)
error: game.asm(96) -> bank_04b.asm(14181): jr target out of reach (expected -129 < -16260 < 128)
error: game.asm(148) -> bank_07f.asm(16332): jr target out of reach (expected -129 < -16317 < 128)
error: game.asm(109) -> bank_058.asm(14228): jr target out of reach (expected -129 < -16257 < 128)
error: game.asm(103) -> bank_052.asm(14406): jr target out of reach (expected -129 < -16272 < 128)
Linking failed with 5 errors
make: *** [Makefile:13: game.gbc] Error 1

Thanks for reporting!


Homebridge crashes

Hi Joe
When launching homebridge it is getting so far then crashing with the below error, any help would be greatly appreciated
Error:
[5/5/2018, 11:36:18 AM] [DysonPlatform] Finished launching. Start to create accessory from config
[5/5/2018, 11:36:18 AM] [DysonPlatform] Dyson email/pass not found, v2 devices may not work
[5/5/2018, 11:36:18 AM] [DysonPlatform] Dyson Fan IP:<IP_ADDRESS> Serial Number:DYSON-NC8-UK-HDA0361A-469
[5/5/2018, 11:36:18 AM] [DysonPlatform] Air Quality Sensitivity (Default is 1): 1
[5/5/2018, 11:36:18 AM] [DysonPlatform] Device serial number format valids
[5/5/2018, 11:36:18 AM] [DysonPlatform] Device not cached. Create a new one
[5/5/2018, 11:36:18 AM] [DysonPlatform] Init Sensor for Dyson Fan
[5/5/2018, 11:36:18 AM] [DysonPlatform] Init Fan State for Dyson Fan
[5/5/2018, 11:36:18 AM] [DysonPlatform] Night mode button is added
/usr/local/lib/node_modules/homebridge-dyson-link/DysonLinkAccessory.js:128
.on("get", this.device.getFilterChange.bind(this.device));
^
TypeError: Cannot read property 'on' of undefined
at DysonLinkAccessory.initFanState (/usr/local/lib/node_modules/homebridge-dyson-link/DysonLinkAccessory.js:128:13)
at new DysonLinkAccessory (/usr/local/lib/node_modules/homebridge-dyson-link/DysonLinkAccessory.js:29:14)
at config.accessories.forEach (/usr/local/lib/node_modules/homebridge-dyson-link/index.js:85:37)
at Array.forEach (native)
at getDevicesFromAccount (/usr/local/lib/node_modules/homebridge-dyson-link/index.js:50:49)
at DysonPlatform.getDevicesFromAccount (/usr/local/lib/node_modules/homebridge-dyson-link/index.js:118:13)
at API.DysonPlatform.api.on (/usr/local/lib/node_modules/homebridge-dyson-link/index.js:49:26)
at emitNone (events.js:86:13)
at API.emit (events.js:185:7)
at Server.run (/usr/local/lib/node_modules/homebridge/lib/server.js:93:13)
at module.exports (/usr/local/lib/node_modules/homebridge/lib/cli.js:40:10)
at Object. (/usr/local/lib/node_modules/homebridge/bin/homebridge:17:22)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)

that function call was from the homebridge API.
can you try to update your homebridge to latest version to see if that works?

Had to reinstall macOS , will try again now

All working great, thank you so much for this plugin its great

Good to know, thanks!


Catch ValueError regardless of py version.

A small adhoc change.
It turns out on travis sometimes we run rita.py on py2, where JSONDecodeError doesn't exist.
Example failed job: https://travis-ci.org/althea-mesh/althea_rs/jobs/413146414

@drozdziak1 As discussed I removed if VERBOSE branch and it will report invalid responses unconditionally. Updated with some more changes because because I realized I'll be reporting Popen object instead of actual stdout output.


add vdeamov profile

When pull request, you can create a branch to pull request.(no more annoying commits)
step1 ( normally push)
git add .
git commit -m "message"
git push

step2 (pick your commit to branch)
git log  # find your commit
git checkout -b patch1 upstream/master # add branch and  link to upstream
git cherry-pick d689c083ac889b1cd09b03857502bb7508ce2cb8 # this is commit-id you find in log
git push origin patch1 # push, then pull request with this branch

Happy Coding

I think you should change the author to yourself

my bad I pull another request

@VDeamoV You do not need to close a Pull Request if there's any problem.
You can keep committing to your local branch, then the PR will get updated.

I will try to reopen it, and fix the commit by just pull request ( It is fun

Great! We now get another member profile page for AMC, cheers!

@VDeamoV Did you remember that I had said you will get a 404 error?
Now you get it!

@huan Get it, it seems url and author name both should be lower case? I will fix it after back to school. sign~

Yes, they must be exactly the same!


[FLINK-11703][table-planner-blink] Introduce TableEnvironments and support registerDataStream and sqlQuery

What is the purpose of the change
In order to support plan tests, we need the ability to register a DataStream (or TableSource) and perform sql query on it.
This issue is aiming to introduce a basic and simple TableEnvironment which only support registerDataStream and sqlQuery.
In the context of FLINK-11067 and FLINK-11068 (convert TableEnvironments and Tables to interfaces), the introduced TableEnvironment in table-planner-blink is a temporary solution and will be refactored/moved to a BlinkPlanner, once FLINK-11067, FLINK-11068 is done.
Brief change log
There are 2 commits:

first commit: copy files from flink-table-planner.
They are no big changes to blink, so I copied them to reduce review effort. Including FlinkCalciteSqlValidator, FlinkPlannerImpl, FlinkRelBuilder, FlinkRelOptClusterFactory, RelTable, TimeIndicatorTypeInfo.
second commit: Introduce TableEnvironments.

The TableEnvironment is slim which only support registerDataStream and sqlQuery and remove all the other methods. Will add some other methods if needed (e.g. registerFunctions, registerTableSource, writeToSink, etc...)
Add an empty Table class, no transformation methods in it. This is only a placeholder to support end-to-end tests for Blink planner.
Didn't introduce Expression classes as it is too big. We use Symbol to replace Expression for Scala and use str.split(",").map(_.trim) to replace ExpressionParser for Java. So that only support plain field names currently, alias and time attribute are not supported.

Verifying this change
Add a TableEnvironmentTest to verify registerDataStream and sqlQuery.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@twalthr Would be great if you can take a quick look at the TableEnvironments and Table introduced to table-planner-blink.

Commits squashed and re-titled.

The failed python test is not related to this PR.
Merging...


[BUG] Crashes while spectating a live game only

Program crashes only when spectating live, ongoing game. When spectating a replay it ran fine. Logs show an error while loading a certain live event. Here are they
Log-2023-04-19-02-13.log
Crash-2023-04-19-02-14.log

And as a new LOL patch rolled out, it loads and immediately crashes again :(
Crash-2023-04-19-16-37.log

LeagueBroadcast intentionally stops immediately in case it detects a live game running.
Quote from the README:
"League Broadcast uses Memory Reading to get information that the Riot API does not expose. Riot's policy in the past has been to allow passive memory reading, which is exactly what this program does, but this may change at any time. Use League Broadcast at your own risk. Anti Cheat does not ban for programs used during spectate, but it does however run while in a live game. Having League Broadcast open during a live (non-spectate) game may lead to account bans incase checks to stop it from running fail for some reason."

It worked in the past, at least for me with no issues. I consulted a riot representative in my country and they told me this as well but so far, riot does not ban this so why does it intentionally crash?

I consulted a riot representative in my country in case riot would have problem with that and they have no problems with it. And in the past it worked. For us as a LOL championship creator this was crucial to be able to stream games with custom dynamic overlays while spectating them. And also the game that is being spectated is already 3 minutes delayed for our observer (tournament lobby), it does not make sense in my opinion to not allow it to run while spectating already delayed game.

Nvm, now I understand what you mean.
I just tested spectating a tournament draft custom game with the not yet available new offsets and it works (at least for me).
So please wait for the offsets for the current patch to get added (that depends on when @floh22 finds the time to do it) and try after that.
Also make sure you have the newest release (https://github.com/floh22/LeagueBroadcast/releases/tag/v1.7.1).

Sorry if i expressed myself incorrectly in the first issue. My bad and thank you so much for working on this <3

The new offsets are now available. Please try again and report back if something still doesnt work :)

Yep it works now, thank you

The new offsets are now available. Please try again and report back if something still doesnt work :)

I think there was a Hotfix yesterday. My spectate games are crashing (while replays are working just fine).
Crash-2023-04-24-09-31.log

The new offsets are now available. Please try again and report back if something still doesnt work :)

I think there was a League Hotfix yesterday which messed up some of the Offsets. My spectate games are crashing (while replays are working just fine). Crash-2023-04-24-09-31.log

I tried the spectate and the program is working fine for me. What offsets are you on? Just in case I have these set
offsets.txt
or try downloading LB again and run the clean version of it

@Hexasiel The current offsets are correct. I think you encountered some other bug from what I can guess from your crash log