fix find substring issue

Codecov Report

Merging #192 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #192   +/-   ##
=========================================
  Coverage     47.71%   47.71%
- Complexity      526      527    +1
=========================================
  Files           130      130
  Lines          2456     2456
  Branches        282      282
=========================================
  Hits           1172     1172
  Misses         1176     1176
  Partials        108      108

Impacted Files
Coverage Δ
Complexity Δ

...seedu/address/logic/commands/AddModuleCommand.java
85.71% <ø> (ø)
8.00 <0.00> (ø)

...in/java/seedu/address/commons/util/StringUtil.java
94.73% <100.00%> (ø)
8.00 <1.00> (+1.00)

...in/java/seedu/address/logic/parser/ParserUtil.java
55.07% <100.00%> (ø)
15.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5bc99d...194df06. Read the comment docs.


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20220403204248531 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20220403204248531 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.006%) to 42.4%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/book/bookTreeView.ts
2
38.21%

Totals

Change from base Build<PHONE_NUMBER>:
0.006%

Covered Lines:
27561

Relevant Lines:
60777

💛  - Coveralls


npm install fails on version 2.0.1

Latest version fails to install using npm install command.
shell output:
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN<EMAIL_ADDRESS>No license field.

npm ERR! code ENOENT
npm ERR! syscall chmod
npm ERR! path C:\Users\xxxxx\source\repos\qbo-token-refresh-function\node_modules\intuit-oauth\bin\coveralls.js
npm ERR! errno -4058
npm ERR! enoent ENOENT: no such file or directory, chmod 'C:\Users\xxxxx\source\repos\qbo-token-refresh-function\node_modules\intuit-oauth\bin\coveralls.js'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

npm ERR!      C:\Users\xxxxx\AppData\Roaming\npm-cache\_logs\2020-01-03T13_47_49_964Z-debug.log

@BukeMan : Kindly use the version 2.0.0 meanwhile. I am fixing the issue right now.
Thanks.

@BukeMan : Its fixed with the new release 2.0.2
Thanks for bringing it to our attention.


StockMarketComponent async tests time out

Just opened a PR (#301) not related to StockMarketComponent and the Travis CI build failed with these messages:
Chromium 62.0.3202 (Ubuntu 0.0.0): Executed 70 of 70 (9 FAILED) (1 min 3.033 secs / 0 secs)
TOTAL: 9 FAILED, 61 SUCCESS
1) should be created
     StockMarketComponent given component booted
     Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.--Pendng async tasks are: [type: macroTask, source: XMLHttpRequest.send, args: {target:[object XMLHttpRequest],url:https://cors-anywhere.herokuapp.com/https://api.iextrading.com/1.0/stock//quote,isPeriodic:false,delay:null,args:[object Arguments],aborted:false,__creationTrace__:[object Object],[object Object]}]
2) should trigger dispatch with correct input
     StockMarketComponent given component booted and input changed
     Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.--Pendng async tasks are: [type: macroTask, source: XMLHttpRequest.send, args: {target:[object XMLHttpRequest],url:https://cors-anywhere.herokuapp.com/https://api.iextrading.com/1.0/stock//quote,isPeriodic:false,delay:null,args:[object Arguments],aborted:false,__creationTrace__:[object Object],[object Object]}]
3) should show spinner
     StockMarketComponent given component booted and stocks are loading
     Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.--Pendng async tasks are: [type: macroTask, source: XMLHttpRequest.send, args: {target:[object XMLHttpRequest],url:https://cors-anywhere.herokuapp.com/https://api.iextrading.com/1.0/stock//quote,isPeriodic:false,delay:null,args:[object Arguments],aborted:false,__creationTrace__:[object Object],[object Object]}]
4) should not show spinner
     StockMarketComponent given component booted and stocks are not loading
     Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.--Pendng async tasks are: [type: macroTask, source: XMLHttpRequest.send, args: {target:[object XMLHttpRequest],url:https://cors-anywhere.herokuapp.com/https://api.iextrading.com/1.0/stock//quote,isPeriodic:false,delay:null,args:[object Arguments],aborted:false,__creationTrace__:[object Object],[object Object]}]
5) should show error
     StockMarketComponent given component booted and the error happened on stock retrieval
     Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.--Pendng async tasks are: [type: macroTask, source: XMLHttpRequest.send, args: {target:[object XMLHttpRequest],url:https://cors-anywhere.herokuapp.com/https://api.iextrading.com/1.0/stock//quote,isPeriodic:false,delay:null,args:[object Arguments],aborted:false,__creationTrace__:[object Object],[object Object]}]
6) should display the relevant caret item
     StockMarketComponent given component booted and stock details are loaded
     Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.--Pendng async tasks are: [type: macroTask, source: XMLHttpRequest.send, args: {target:[object XMLHttpRequest],url:https://cors-anywhere.herokuapp.com/https://api.iextrading.com/1.0/stock//quote,isPeriodic:false,delay:null,args:[object Arguments],aborted:false,__creationTrace__:[object Object],[object Object]}]
7) should display correct stock name, price, currency
     StockMarketComponent given component booted and stock details are loaded
     Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.--Pendng async tasks are: [type: macroTask, source: XMLHttpRequest.send, args: {target:[object XMLHttpRequest],url:https://cors-anywhere.herokuapp.com/https://api.iextrading.com/1.0/stock//quote,isPeriodic:false,delay:null,args:[object Arguments],aborted:false,__creationTrace__:[object Object],[object Object]}]
8) should display correct exchange
     StockMarketComponent given component booted and stock details are loaded
     Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.--Pendng async tasks are: [type: macroTask, source: XMLHttpRequest.send, args: {target:[object XMLHttpRequest],url:https://cors-anywhere.herokuapp.com/https://api.iextrading.com/1.0/stock//quote,isPeriodic:false,delay:null,args:[object Arguments],aborted:false,__creationTrace__:[object Object],[object Object]}]
9) should display correct change
     StockMarketComponent given component booted and stock details are loaded
     Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.--Pendng async tasks are: [type: macroTask, source: XMLHttpRequest.send, args: {target:[object XMLHttpRequest],url:https://cors-anywhere.herokuapp.com/https://api.iextrading.com/1.0/stock//quote,isPeriodic:false,delay:null,args:[object Arguments],aborted:false,__creationTrace__:[object Object],[object Object]}]

I also saw the same thing on my development computer, but only 6 of the StockMarketComponent tests failed.
Found this info on SO.

@alexkonovalov any suggestions?

@timdeschryver  - I see the Travis build has now passed.  It also works on my local system.  We could either increase (double?) the async call timeout to be safe as suggested in the SO article or we can close this?

I would rather mock out the service in order to not call the API when we're running our unit tests.

@timdeschryver I agree.  Mocking the service would be the best solution.

I'm closing this issue and will create a new one.

Hi folks @hhubik @timdeschryver !
This sometimes happen because Travis CI free tier probably uses shared resources for many free build so maybe in a peak times build becomes too slow and times out.


[TC-547] Fix regression issues caused by TC-187

Fix regression issues caused by TC-187:

revert: replace xml_id with ds_ as riak key for ssl certificate
revert: decode base64 for ssl csr, crt, key in restful api

Add missing code for update ssl keystore when hostname changes

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/84/

@rawlinp This PR reverted the regression issues introduced by TC-187. And also resolved your comments in PR#360. Please help to review.

fatal: ambiguous argument 'TC-547': unknown revision or path not in the working tree.
This is a issue in build server, not my code, right?

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/124/

@zhilhuan Yes that was a build server issue that should be resolved now.
This PR looks good; it reverts the breaking changes introduced by the change from xmlId to id in the keysto store ssl keys in riak.

Looks good to me. Thanks for fixing this!
Note that we'll have to figure out if we want to regenerate the actual certs too (rather than just the hostname in the riak record), but we'll tackle that in a new PR once we've discussed what needs to be done about that.

@rawlinp Thanks for your comments! Yes, that's need aother discussion, because the certs may be pasted by operator instead of generated by ops.


simplify logic to look up canonical URL for DOI

The current logic sometimes fails to handle properly valid canonical URLs.
Also, we want to store the handle_url, i.e. the first URL redirect. This URL is stored in the handle server.

Disabled detailed logic to get correct canonical URL as there were too many false negatives.


Cannot read property 'add' of null

I have managed to disable/destroy the carousel under the conditions that I need and it works perfectly. However I still see the following in the console:
Uncaught TypeError: Cannot read property 'add' of null
What is causing that and how can I remove it?
Current URL: http://www.alessandrosantese.com/aldemair-productions/

Hey @WebTerminator search the repo for "unslick"

Check This , Call multiple times it will not break http://jsfiddle.net/fmo50w7n/372/

@naveenrk Thanks so much!

Thanks, man!

Another approach to make this work is use unslick

Check This , Call multiple times it will not break http://jsfiddle.net/fmo50w7n/372/

This is not working because it uses jQuery edge
Change it to jQuery 3.3.1 to make it work.

https://stackoverflow.com/questions/35884752/error-in-slick-js-uncaught-typeerror-cannot-read-property-add-of-null


Document that the spechiness field is useless for music

The docs for speechiness state that

Values below 0.33 most likely represent music and other non-speech-like tracks.

The speechiness of Bohemian Rhapsody - 2011 Mix is 0.0536. That of Penny, a track with no vocals whatsoever, is 0.0478. That makes the field useless for separating tracks with vocals from tracks without (useful for example in creating "focus" playlists).

Will do in<EMAIL_ADDRESS>cf: https://github.com/wittydeveloper/spotify-graphql/issues/79

Will do in<EMAIL_ADDRESS>cf: https://github.com/wittydeveloper/spotify-graphql/issues/79


language

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
i sould like to be able to change language
Describe the solution you'd like
Hi. im just wondering if it would be possible to set the language ?
Describe alternatives you've considered
.
Additional context
.

Hi @mortalone, it should speak any of the supported languages when you provide text in that language. Make sure you configured it to use a multilingual model v1 or v2 (see readme for example) and for best results, use a voice built on the selected model.
If you're using it as your Assist's voice, you'll need to change your HA language to get Assist to speak in that language.


Besically It is a frontend site with demo donation button for Street Dog Charity Donation site,,,,,,,

    Besically It is a frontend site with demo donation button for Street Dog Charity Donation site,,,,,,,

Originally posted by @ritam077 in https://github.com/jay-2000/Open-source-hacktoberfest/issues/38#issuecomment-1272356300

    Besically It is a frontend site with demo donation button for Street Dog Charity Donation site,,,,,,,

Originally posted by @ritam077 in #38 (comment)

now go ahead @ritam077

Done


Update Contracts from FheOS

Updated contracts from FheOS push to master

closing since the changes here where already contained in another merged PR here

closing since the changes here where already contained in https://github.com/FhenixProtocol/fhenix-contracts/pull/73 merged PR here


Convert task errors to runtime

Codecov Report
Base: 72.04% // Head: 64.87% // Decreases project coverage by -7.18% :warning:

Coverage data is based on head (35e9c84) compared to base (05bc713).
Patch coverage: 33.33% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
- Coverage   72.04%   64.87%   -7.18%
==========================================
  Files          18       18
  Lines        6643     6357     -286
==========================================
- Hits         4786     4124     -662
- Misses       1857     2233     +376

Impacted Files
Coverage Δ

src/compiler.jl
65.69% <33.33%> (-7.15%)
:arrow_down:

src/compiler/orcv2.jl
0.00% <0.00%> (-61.91%)
:arrow_down:

src/compiler/interpreter.jl
17.33% <0.00%> (-39.81%)
:arrow_down:

src/compiler/utils.jl
58.57% <0.00%> (-37.32%)
:arrow_down:

src/logic.jl
75.00% <0.00%> (-5.00%)
:arrow_down:

src/compiler/pmap.jl
75.27% <0.00%> (-2.27%)
:arrow_down:

src/compiler/validation.jl
59.74% <0.00%> (-2.13%)
:arrow_down:

src/pmap.jl
83.33% <0.00%> (-1.29%)
:arrow_down:

src/typeanalysis.jl
90.00% <0.00%> (-0.91%)
:arrow_down:

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Create AWS account for GHU

There needs to be an AWS account owned by GHU, because I have no business hosting the site personally

Then we can use IAM to get everyone in the group admin access


$100 document how to use external machine to record screen/audio

related
https://github.com/mediar-ai/screenpipe/discussions/339
definition of done:

in docs.screenpi.pe it's written how to record screen/audio from a linux cloud server / thing with a local macos/linux/windows (usually through some SSH hack)

/bounty 100

yes
new page
should be very easy for the user like a few lines of CLI or a button click
(optional) and maybe if it's possible to record multiple machine on a single server that'd be cool

@louis030195
i tried to run screenpipe backend in ubuntu vps, while using ffmpeg and x11grab to stream local machine's screen and audio to remote server, but the problem is when running screenpipe executable in remote server it is searching for display & windows to capture screenshots, since there isn't any display or windows the program gets crashed. i even tried to use virtual display (Xvfb) and a dummy windows manager (openbox) but couldn't get work :(
2024-10-26T13:23:23.167802Z  INFO screenpipe_server::server: Server starting on <IP_ADDRESS>:3030
2024-10-26T13:23:23.252200Z ERROR screenpipe_vision::capture_screenshot_by_window: XCap error occurred: _NET_CLIENT_LIST not supported
2024-10-26T13:23:23.754712Z ERROR screenpipe_vision::capture_screenshot_by_window: XCap error occurred: _NET_CLIENT_LIST not supported
2024-10-26T13:23:24.806143Z ERROR screenpipe_vision::capture_screenshot_by_window: XCap error occurred: _NET_CLIENT_LIST not supported
2024-10-26T13:23:24.813235Z ERROR screenpipe_vision::capture_screenshot_by_window: All 3 attempts failed. Last error: XCap error: _NET_CLIENT_LIST not supported
2024-10-26T13:23:24.815384Z  WARN screenpipe_vision::utils: Failed to capture window images: XCap error: _NET_CLIENT_LIST not supported. Continuing with empty result.
2024-10-26T13:23:24.900041Z  INFO screenpipe_server::video: Starting FFmpeg process for file: /root/.screenpipe/data/monitor_78_2024-10-26_13-23-24.mp4
Killed

also in this discussion (when xcap's version 0.0.10) he is using reverse port forwarding to forward port 4713 on the remote host to port 4713 on the local machine. i tried it, still it isn't working
ssh -R 4713:localhost:4713 -X remote-user@remote-host bash -c "PULSE_SERVER=localhost /opt/screen-pipe/target/release/screenpipe"


Filter resources without list

Currently resources without list are listed on the menu, filtering by resource.hasList fixes that, as done on react-admin:
https://github.com/marmelab/react-admin/blob/7f6426e07916d32b5c9015c82540ac439b4a9e28/packages/ra-ui-materialui/src/layout/Menu.tsx#L77

@gstvg - please check the review comments by @harshit-budhraja

@harshit-budhraja  - can you please work on this ?

@harshit-budhraja - can you please work on this ?

Sure @sivaavkd. Picking this up for release under milestone 1.0.3.


Build on Rust stable

I'm looking to use this library in my project, but would like to stay on stable Rust. This PR does the following:

removes ![feature(slice_group_by)]
adds the stable_group_by module which contains the implementation, pretty much just copy/pasted from std (though it's a free function for simplicity's sake)
adds a nix flake for easier building on NixOS (non nix users can ignore this), and direnv. Happy to remove this if you'd rather keep it out
uses the new rust-toolchain.toml format

Let me know if there's any changes you'd like to see. I'd love to be able to build this on stable, and my current system (abusing cargo patches) is becoming unwieldy.
I've run cargo test locally and everything passes.
Thanks :grin:

done


New version: Unity.Unity.2022 version 2022.3.54f1

Created by 🥟 Dumplings in workflow run #10047.

Log
Updated: 2022.3.53f1 → 2022.3.54f1
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

@wingetbot run

@wingetbot run

This package installs and launches normally in a Windows 10 VM.


Error with _stack.removeList() in internals.dart

I'm using your package to show partial HTML content (no , , etc.) from an unreliable source so that the content may be malformed sometimes (I have no control over the content, it may be a plain string sometimes). I think for a reason related to that, the library throws the following exception: "RangeError (index): Invalid value: Valid value range is empty: -1".
I've tracked the error to the following line in /lib/src/internals.dart: var top = _stack.removeLast();
I don't know the justification for removing the last element from that list. I haven't studied the code deeply enough. I wonder whether a simple validation could do any damage.
Thanks

Sorry, It's been quite long since I went through the code. Also, most part of this package is written by the original author.
Although, I think your use case seems to be a little out of the scope of this package. It would be nice If you are able to send a PR.

Hello. I'm sorry for the delay. Finally, I simply forked the repo to prevent access to the last item if the list is empty. I think this is enough for my use case, but I'll consider submitting a PR if I decide to dig deep on it.


Make the project name and due date dep-emphasized (smaller, gray) to distinguish from task name

Is your feature request related to a problem? Please describe.
Currently the task name, project name, and due date are all the same font color and size. Therefore, the only thing separating the task name from the other two pieces of info are the indentation. This makes it difficult to quickly browse the task list in Obsidian to see what tasks I have.
Describe the solution you'd like
Make the font color of the project name and due date faded (e.g., gray), and perhaps smaller as well. Kind of like the font styling of the task description (see screenshot). I believe an older version of the plugin had this, but then in the newer version changed?

Hey @ahafri, there's actually a redesign that's landed in master and will be available with the next public release. As a sneak peak, this is what that looks like with the default theme:

The metadata elements are both smaller and use slightly more muted text, is this what you were thinking of?

YES! This is brilliant. Looking forward to it. I'll close the feature request.


If there are multiple instances of g.V(), format all of them consistently

It turns out that this was only partially fixed.
It does not solve the following case:
g.V().has(
        'parent', within(
          g.V().has('name', 'Work').
          id().
          toSet())).
      values('hours').
      sum()

It should yield
g.V().has(
        'parent', within(
          g.V().has('name', 'Work').
                id().
                toSet())).
      values('hours').
      sum()


Fix - Convert total_amount to GBP all the time

WHAT

Convert total_amount to GBP when listing transactions (as total_amount is displayed if net_amount is not available) not just when corporate_card_surcharge is available.

superseded by https://github.com/alphagov/pay-selfservice/pull/2930


Expose barStyle for NavigatorIOS and TabBarIOS

Exposes barStyle property. Code already existed in RCTConvert, so that’s why there’s no conversion code here.

Nice! Can you add this to the examples?

I think we’ve usually just showed a single example with a navigation or tab bar using custom text and background colours. It can’t really be used at the same time as custom background colours, so I can either add separate examples for this, or just post screenshots.

I think separate examples make sense if they cannot be demonstrated together. Ideally you could just toggle the barStyle dynamically, but I know that isn't always supported.

Looks good, thanks! I expanded the comments a bit.
@facebook-github-bot shipit

Failed with a Flow error, can you fix it please?
Libraries/Components/TabBarIOS/TabBarIOS.ios.js line 78 col 30-37: property `barStyle`
Property not found in
Libraries/Components/TabBarIOS/TabBarIOS.ios.js line 78 col 19-28: object type

Just done for TabBarIOS—it seems like there aren’t types for NavigatorIOS.

Re-triggering tests. We can't land until this is green.

Again re-triggering tests ;-)

It was failing on flow. I've just remerged master in. Hopefully this time!

Should be good now!

Travis failing on objc-ios, the errors are incomprehensible to me so I am kicking it. https://travis-ci.org/facebook/react-native/builds/199915022

For the failing bar style, there seems to be an existing comment,
// TabBarExample on tvOS passes locally but not on Travis

I'm not sure why the web socket test is failing. I didn't touch that.

@lacker We're all good now by the looks of things!

@lacker Anything I can do my end?

As far as I can tell, the import failure is unrelated to the code here. We're having issues importing some of the GitHub PRs this week. I'll import this as soon as they're resolved.

This needs to be rebased before it can merge

Merged in latest master.

@hramos

Ping @ericvicenti who is oncall this week.

@ericvicenti @hramos Is there anything I can do to help? I can rebase if you want: would you want that on a new branch?

@hramos @ericvicenti I've updated this to use the new RNTester project, and fixed a flow error. Verified it's still working.
CircleCI seems to be failing on building for Android (looks like some libraries are missing). I've not changed any Android files. Is there anything I need to do?

@shergin Good catches. I've updated the PR.

After looking at the internal state of this pull request, it seems like we won't be accepting this change. @shergin feel free to re-open if you think otherwise.

Is there anything I can do to help this?

Okay, let's try one more time!


input-ouput model mapping changes (For the built-in types in java those are not available in android)

Te main work here is to identify how basic java model mapper can be overriden for android, then do necessary mapping (e.g. java.time not in android, mapper needs to be updated/added.)

Change PR


chore(gnss_launch): added autoware_ prefix to gnss_poser

Description
Following the movement of adding autoware_ prefix to package names, this PR adds autoware prefix to gnss_poser.
Related links
Since this PR strongly relates to sensor launching systems, this PR must be merged together with the following PRs.

https://github.com/autowarefoundation/autoware.universe/pull/8323
https://github.com/RobotecAI/awsim_sensor_kit_launch/pull/17/
https://github.com/tier4/aip_launcher/pull/277
https://github.com/autowarefoundation/awsim_labs_sensor_kit_launch/pull/4

How was this PR tested?
Confirmed that gnss_poser launches and works as normal in the rosbag replay simulation.
Notes for reviewers
Since this PR strongly relates to sensor launching systems, this PR must be merged together with the following PRs.

https://github.com/autowarefoundation/autoware.universe/pull/8323
https://github.com/RobotecAI/awsim_sensor_kit_launch/pull/17/
https://github.com/tier4/aip_launcher/pull/277
https://github.com/autowarefoundation/awsim_labs_sensor_kit_launch/pull/4

Interface changes
None.

Effects on system behavior
None.

@knzo25 @drwnz @technolojin
Sorry for interrupting, I chose you as reviewers because you seemed to be involved in sample_sensor_kit recently.
Could someone please review this PR :pray:


Mixed dtype support in chainerx.linear

Part of  #6436
~Depends on #6510.~

Jenkins, test this please.

Jenkins CI test (for commit aa3cfc300eeb4b95a1b7ba624b4e459f890cb6b0, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

LGTM.


plot colors are too random

https://pub.beakernotebook.com/publications/c1cd9972-6e3b-11e6-9dbf-cfab34647425
the first 10 or so colors are chosen from a fixed list and look good.
but after that, they are chosen randomly and they look bad.
worse, each time the page is loaded, they are chosen differently.
we need a better algorithm that spaces out the colors, and is not random.

for 10-20 colors use "d3 category20" https://github.com/d3/d3-scale/blob/master/README.md#schemeCategory20
colors after 20 should be pseudo-random.

something like:
something like:
hue = 137.5 * n
saturation = 0.5 + cos(n)/2
value = 0.75 + cos(1.414*n)/4
137.5 is the golden angle


emulation:  yaml configuration and some cleanups

The microphysics emulation uses environment variables for configuration, which is unusual compared to our typical yaml-based workflow.

use yaml instead of env vars

I bundled this with some quality of life improvements to emulation package, by improving the directory structure and deleting a bunch of code.
Suggest reviewing as separate commits.

the yaml based config has been merged in another pr.


fix: global layers

This PR:

fixes #1490
Simplify code
Now global layers are also displayed in the quick overview and preview next

It breaks my usage of having a single instance of global layers. One of the point of global layers was to live out of slides lifecycle. I think maybe we should still keep the original behavior for playback but only duplicates in print mode (I use the --per-slide flag to workaround it in export, btw).

As mentioned in https://sli.dev/custom/global-layers#example, the global layers are used as something like footers. For footers they don't need to be singleton, but should be displayed with each slide. Should we add SlideTop and SlideBottom for footers, while preserving the current usage of global layers? If there are the SlideTop and SlideBottom components, I think the global layers are intended to be used as something like a navigator or so, which should not be printed.


Automated PR: Standardising Files

This PR will standardise the files we have with out agreed spec in sous-chefs/repo-management.
This repo has been identified by topic(s) of terraform

Needs files updates in the upstream so this setting is kept.

Right, I forgot about that... I'll get to that if you haven't already.

https://github.com/sous-chefs/repo-management/pull/60


Spelling

Overview
Describe the changes present in the pull request
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/newrelic-ruby-agent/commit/3c48f73ad7a3012e7847957bd7683829e1fecacc#commitcomment-85517301
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/newrelic-ruby-agent/commit/1186c6107a167f2464117cc4ecce9ef54e08ede3
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.
Submitter Checklist:

[ ] Include a link to the related GitHub issue, if applicable
[ ] Include a security review link, if applicable

Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist

[ ] Perform code review
[ ] Add performance label
[ ] Perform appropriate level of performance testing
[ ] Confirm all checks passed
[ ] Add version label prior to acceptance

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Oh, I should perhaps note that https://github.com/newrelic/newrelic-ruby-agent/blob/dev/.github/workflows/label_community_cards.yml is hostile to forks w/ locked down configurations.
It should have explicit permissions: for the things it uses. I may make a PR for it, or not, but likely not anytime soon.

I try to remember to participate. I'll have to sign up. Thanks for the reminder. Signed up!
I do these year-round because they exercise my tool and I like to help.

@jsoref, when you have the time, we'd love to have your action added to our workflows. Thanks for introducing us to it and correcting our spelling. 😄


Security Enhancement

This piece of code will increase the security of the overall system
# secure code

But this is no nocode!

I am quite new to nocode, but that looks like very well documented nocode to me.


Documentation: setDepth vs setZ

Version

Phaser Version: v3.20.1

Operating system: (not relevant - Win10)

Browser: (not relevant - Chrome)

Description

It should be made clear in the documentation for Base Object (and all derived classes like image) that (in a 2D environment) setting the Z value does not affect the rendering depth (which objects are drawn over the top of others). For example, (property) z, setZ, setPosition should say "Note that the z coordinate does not control the render order of 2D game objects. Use setDepth to control which objects render on top of others.."
Example Test Code

Additional Information

Cheers, I've clarified this in the commit above (15ac5e7). The improved docs will be part of 3.22.0.


Marketplace should also increase luxuries by 50%

As it already does correctly with taxes.
Removing 1 resource (L=Original, R=CivONE):

Removing 2:

Removing 3:

Thanks, I will implement this.


Induction meeting for Laura, Sarah, and Hamed

Checklist for Leo

[x] Send invitation to the group Slack chat room
[ ] Add to the lab GitHub organization.

Before your meeting

[ ] Join the Slack chat room (click the link in the invitation and create an account). Setup Slack on your computer/tablet/phone or use the website version: compgeolab.slack.com
[ ] Create an account on GitHub. Make it something professional (this will be associated with
your future publications from the lab!)
[ ] Leave a comment here with your GitHub username

During the meeting
Go over key information about:

[ ] The lab manual, expectations, and practices
[ ] The lab GitHub organization where all our research projects live
[ ] The lab website and how you can add yourself to it

After your meeting

[ ] Go over the lab manual again on your own (ask on Slack if you have any questions).
[ ] Read the Code of Conduct carefully.
[ ] Study the Software Carpentry lessons on Version Control with Git, Python, and the Unix Shell. They will be crucial for your project. Go over Git and the Unix Shell first.
[ ] Edit your page on the website (if you want). See the website contributing guide for instructions.
[ ] Explore the GitHub organization to see what the group is working on.
[ ] Go and start making something brilliant!

Hi, my username for GitHub is SAskevold.

hi

Hi my username is Lnicho

Laura

@SAskevold this should trigger a notification

I think you've all done this already and I just forgot to close the issue. Closing now 👍🏽


feat: add opsgenie priority template based on severity label

P1 in my opinion is reserved for actual outage, in our case if cloudflare fails the external domain health check though I'm open to updating this default.

Hi! 👋 Thanks for opening this PR. As mentioned here, I think the same applies to priority label:

Alertmanager doesn't have severity, and Prometheus users are not required to set use a severity label, so I'm not sure if this is something that will be accepted. Is it not possible to template the severity for Opsgenie using the existing templating infrastructure?

Why not use a custom template to set the priority field in Opsgenie for your use case?

@grobinson-grafana we did just that!


Context.run_udf: explicitly check for empty UDF list

With out it, we get an error from the innards of the UDFRunner
Contributor Checklist:

[x] I have added or updated my entry in the creators.json file
[N/A] I have added a changelog entry for my contribution
[x] I have added/updated documentation for all user-facing changes
[x] I have added/updated test cases
[N/A] I have included the rebuilt production build of the client (only if changes were made to the GUI)

Reviewer Checklist:

[ ] /azp run libertem.libertem-data passed
[ ] No import of GPL code from MIT code

/azp run libertem.libertem-data


enzyme 3.7.0 and react 15.6 - fails with error "Cannot find module 'react-test-renderer/shallow' from 'ReactFifteenAdapter.js'"

To Reproduce

Create project with react 15
Install latest enzyme and adapter for react 15:
npm i --save-dev enzyme enzyme-adapter-react-15
Run jest tests
See error:
Cannot find module 'react-test-renderer/shallow' from 'ReactFifteenAdapter.js'

Solution:
install react-test-renderer 15
npm i --save-dev<EMAIL_ADDRESS>

Solution:
install react-test-renderer 15
npm i --save-dev<EMAIL_ADDRESS>
Thanks for this solution sir.It work perfectly for me.Do you also work on data visualisation.


Added Rock Paper Scissors Lizard Spock

PR Description 📜
"Rock, Paper, Scissors, Lizard, Spock" is an expanded version of the classic hand game "Rock Paper Scissors, popularized by the TV show "The Big Bang Theory." In this game, two players simultaneously choose one of the five options: Rock, Paper, Scissors, Lizard, or Spock.
Point down the features

Rock crushes Scissors and crushes Lizard.
Paper covers Rock and disproves Spock.
Scissors cut Paper and decapitate Lizard.
Lizard eats Paper and is poisoned by Spock.
Spock smashes Scissors and vaporizes Rock.

Fixes #2556

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @tayyab-ilyas ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

hey @gurjeetsinghvirdee ! can you check this out? also please don't forget to assign the Gssoc'23 label. Thanks!

Thank you  @tayyab-ilyas , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Frontend to easily explore the data

The data is a bit of a beast to handle in raw json format.
It would be really handy to have a frontend to easily narrow things down and filter and consume the data.
This issue is a scratchpad for fleshing out the idea into something that can be coded up.

See https://github.com/iancoleman/cia_world_factbook_api/commit/ac3279685158337ed6aac7338b02a03b78e3c1e7


Add RailsAdmin for CRUD UI over database.

Satisfies requirement to have a UI to initially create user and permissions data for early application integration and testing.
Can be replaced with a custom UI later as more detailed user management stories are implemented.

:+1:


About the GPU memory

How much GPU memory do you use when training the dense gcn?
I am using the GTX2080TI  whose memory is 11G. But it always raises an error: RuntimeError: CUDA out of memory.

At the same time, I run another code on GPU0. I find set CUDA_VISIBLE_DEVICES=1 doesn't work when running 'train_gcn_dense', and I still run this code on GPU0. I must set the  '--gpu' manually in the args.

I remember it should work with one GPU like 1080Ti.
"--gpu" resets "CUDA_VISIBLE_DEVICES", therefore you need to use "--gpu" to choose the GPU. You can check the code for details.

Much appreciation for your reply.
Another code has occupied a large amount of memory on 2080ti. And I failed to select the GPU with the command 'CUDA_VISIBLE_DEVICES=1 python xxx.py'. I find your code 'set_gpu' will set CUDA_VISIBLE_DEVICES again. So it's better to just use "--gpu" in your original code.

Yes. Happy to hear you solved the issue.


Workflow task fails with new Sandbox (initial build required)

I added project properties, as shown, in gradle.properties:
app_id=******
sandbox_id=******
build_version=0.0.0-0-SNAPSHOT

Then, I added the dependencies to my classpath:
buildscript {
  dependencies {
    classpath 'com.veracode.vosp.api.wrappers:vosp-api-wrappers-java:<IP_ADDRESS>'
    classpath 'gradle.plugin.com.calgaryscientific.gradle:veracodePlugin:0.4.0'
  }
}

(Side note: Is it better to use Maven Central rather than manually downloading the Veracode jar?)
Then, I applied the plugin:
apply plugin: 'com.calgaryscientific.gradle.veracode'

Finally, I tried to execute the Sandbox Workflow task:
macdaddy123:phatproject nsaunders$ ./gradlew veracodeSandboxWorkflow
:veracodeSandboxWorkflow FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':veracodeSandboxWorkflow'.
> ERROR: Could not find a build for application=****** and sandbox=******
  See /Users/nsaunders/Projects/hg/projects/41st/phatproject/build/veracode/buildinfo-******-******-latest.xml for details!

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 9.764 secs
macdaddy123:phatproject nsaunders$

buildinfo---latest.xml:
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<error>Could not find a build for application=****** and sandbox=******</error>

What  am I missing here?
It seems to me that a workflow task should take care of all of the details of creating/updating/deleting a build as needed, uploading artifacts, and triggering a scan. Is this assumption incorrect?
Your help and insight would be greatly appreciated. Thanks in advance!

Published https://github.com/calgaryscientific/veracode-gradle-plugin/releases/tag/v0.5.0 which addresses this issue.


Add validation action to validate JWT

Can I work on this? thanks

There is already a PR for jwt. Feel free to review it. If you want to work on your own action you can implement a btc action to validate Bitcoin addresses.


[DOC]: Replace the list of technologies used in README.md with their logos

Changes Suggested

Replace the list of technologies used in README.md with their official logos

Change the text

This software uses the following open source packages:

to

Technologies used in this project are:

Or you can use your line that is more appropriate at this point.

Hey @IIvexII Can you assign this to me

Hey @gogoiakash2311 I have assigned it to you. You can work on it now.

Okay

@gogoiakash2311  Have you started working on it? If you need help, do let me know.

@IIvexII While setting up the project locally, After running "npm start" it's showing:
There is an error while connecting to database.

@IIvexII While setting up the project locally, After running "npm start" it's showing: There is an error while connecting to database.

Bro, there is no need to setup the project at all. Because you are just working on docs. Just work on the required changes. Don't worry about the codebase.

Okay


Done button title customization

I would like the Done button to read "Search" instead of "Done". The Apple standard set would be nice, although I'm sure people would also love the ability to set custom strings as well, since I know many people already want to customize that button on Apple's own keyboard.
This would also allow for safer localization than the current, potentially dubious mechanism of accessing the com.apple.UIKit bundle's localization table.

@ZevEisenberg Hi! You can use my fork :)
#11

Hey everyone! I was away on vacation and did not have the chance to think about this :) I'll get to work on this shortly.

Update: MMNumberKeyboard 0.1.5 is available with support for customizing the Return key.
Refer to the documentation included in MMNumberKeyboard.h to use the new -returnKeyTitle and -returnKeyButtonStyle properties.
Thank you everyone!

@matmartinez thanks! it's that I wanted :+1:


Update README.md with YourStop

Add YourStop to Web Apps list

Thanks @harringtonp, looks good!

Thanks Sean, that's my first  gihub pull request done


driver compilation error

How much version do you use vmware?

How much version do you use vmware?

I removed the metadata and it worked.


Allow any bytes (including non-UTF8 ones) in List Objects response XML

This PR addresses #974 (RCS-289)
By some reasons, List Object response XML can not be valid.

AWS S3 response is XML 1.0 and XML 1.0 allow only #x9, #xA and
#xD for characters < #x1F. Then, PUT Object with path like %01
in URL-encoded form can not be included in valid XML 1.0.
AWS S3 does allow such bytes [1].
AWS S3 responds to List Objects by representing %01 to
numeric-character-reference-like-but-just-invalid byte in XML,  [2].
s3cmd and aws cli both fails to parse response including .

This policy that this PR chooses:

If all keys are UTF-8 encoded byte sequences and all characters in
them are valid XML 1.0 characters, then List Object responds contents
which is valid XML 1.0.
Otherwise, it responds with some byte sequences which is not valid XML
1.0 but as =reasonable for humans= as possible in order to deliver
information about keys in buckets.

The actual logic is very simple. Just return bytes as it has been
uploaded except xml escaping <, > and & [3]. (For reviewers,
the main commit in this PR is b28fec7ee6e32c9bba6145270ec28327a23ee908,
others are just refactoring.)
For example, assuming uploaded key was %01, then list results
includes binary like <<"<Key>", 16#01, "</Key>">> (in Erlang
notation).  Users can manipulate such response by grep, sed, or
anything if XML library fails [4]. What one should do are only:

Extract bytes between <Key> and </Key> (not ambiguous because
< is escaped)
Unescape &* references

[1] Example by s3curl to AWS S3
% s3curl.pl --id shino --put rebar.config -- -s -v \
    http://shino.shun.test-us.s3.amazonaws.com/'%01'
> PUT /%01 HTTP/1.1
> User-Agent: curl/7.35.0
> Host: shino.shun.test-us.s3.amazonaws.com
> Accept: */*
> x-amz-date: Tue, 29 Sep 2015 03:02:00 GMT
> Authorization: AWS AKIAJBO7GX36NI32XDRA:gahZlOqOkkrkbGXL34ZyKgT5ZnQ=
> Content-Length: 2852
> Expect: 100-continue
>
< HTTP/1.1 100 Continue
< HTTP/1.1 200 OK
< x-amz-id-2: Ou1uOp+ZJDAwMqGDTnHa82F58sqCO9EWqzffke7/ga2lMEfnpwUQMhHDXCcX5QcQ
< x-amz-request-id: A69F3BE469CC0328
< Date: Tue, 29 Sep 2015 03:02:02 GMT
< ETag: "c90a5c0f80f9b5e2980deee859291373"
< Content-Length: 0
< Server: AmazonS3
<

Sidenote: %00 is NOT allowd.
% s3curl.pl --id shino --put rebar.config -- -s -v \
     http://shino.shun.test-us.s3.amazonaws.com/'%00'
> PUT /%00 HTTP/1.1
> User-Agent: curl/7.35.0
> Host: shino.shun.test-us.s3.amazonaws.com
> Accept: */*
> x-amz-date: Tue, 29 Sep 2015 03:02:06 GMT
> Authorization: AWS AKIAJBO7GX36NI32XDRA:0Oa7g2tTC5VvyRbZEQjnmP9pxbs=
> Content-Length: 2852
> Expect: 100-continue
>
< HTTP/1.1 400 Invalid URI
< Content-Length: 0
< Date: Tue, 29 Sep 2015 03:02:07 GMT
< Connection: close
< Server: AmazonS3
<

Seems like AWS S3 validation is based on XML 1.1 character range for
PUT request {shrug}.
[2] Extracted from XML response: <Contents><Key>abcdef</Key>[snip...].
[3] Numeric reference like (but not valid) representation, e.g.  is
not used.  It's because 1. it is not still valid in XML 1.0 because
it is outside of character set and 2. if one treat it as XML 1.1 then
the byte 0x01 (or <<1>> in Erlang) is valid as is.
[4] s3curl does nice job for such lower level manipulation. AWS CLI also
nice because it output response body to stderr if it fails to parse
it as XML. s3cmd can produce such output by -d debug switch.

@borshop merge

Memo: sample one liner for AWS CLI to see possibly unprintable characters included in Key elements
.aws s3api list-objects --bucket test  2>&1 | sed -e 's/</\n</g' | grep '<Key>' | sed -e 's/<Key>//g' | od -t x1c


MSVS throws an error on project initialization

Hi,
I opened qtum source code in MSVS 2019 and I got the following error:
Severity	Code	Description	Project	File	Line	Suppression State
Error		CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
C:/qtum/qtum/src/cpp-ethereum/libdevcore/LEVELDB_INCLUDE_DIR
   used as include directory in directory C:/qtum/qtum/src/cpp-ethereum/libdevcore
LEVELDB_LIBRARY (ADVANCED)
    linked by target "devcore" in directory C:/qtum/qtum/src/cpp-ethereum/libdevcore
LEVELDB_LIBRARY_DEBUG
    linked by target "devcore" in directory C:/qtum/qtum/src/cpp-ethereum/libdevcore

Does anyone know how to resolve the problem?
Thanks!

Building with VS is not the best idea, please refer to Windows build docs:
https://github.com/qtumproject/qtum/blob/master/doc/build-windows.md


Use Inquiline 0.3.x

This is needed for nestproject/NestTestSuite#7.

I think the version of Swift used in CI build is too old and should be upgraded

@takebayashi Can you rebase this PR on-top of master, that should hopefully fix the failure.

@kylef thanks. It has been fixed.

Thanks @takebayashi


Add information about the use of FoliaLib in README.md

This time with verified commits 👀

pfft, self promotion... shameful

lmao, jk

It is self-promo, but it's also free for you to use =P


generate*.py: raise ValueError if GT is multiline, fix #162

*.gt.txt should contain a single line of transcribed text.

@wrznr @Shreeshrii @stweil Can this be merged?

See also PR #185.


BAD BAD BAD ... -- bisweb dislikes something about something in a nii.gz "file"

https://bioimagesuiteweb.github.io/webapp/viewer.html?image=https://datasets.datalad.org/.git/tmp/blah.nii.gz on a copy of the file served from elsewhere works -- so it is not about content but either about failing to deduce extension (is content-disposition considered?) or something else since all the following do not work

https://bioimagesuiteweb.github.io/webapp/viewer.html?image=https://dandiarchive.s3.amazonaws.com/blobs/472/10e/47210e31-7e86-4a9d-bcad-413825c4250a  (direct link to the blob on S3 -- no extension),
https://bioimagesuiteweb.github.io/webapp/viewer.html?image=https%3A//dandiarchive.s3.amazonaws.com/blobs/472/10e/47210e31-7e86-4a9d-bcad-413825c4250a%3Fresponse-content-disposition%3Dattachment%253B%2520filename%253D%2522average_template_50.nii.gz%2522%26X-Amz-Algorithm%3DAWS4-HMAC-SHA256%26X-Amz-Credential%3DAKIAUBRWC5GAEKH3223E%252F20210817%252Fus-east-2%252Fs3%252Faws4_request%26X-Amz-Date%3D20210817T230946Z%26X-Amz-Expires%3D3600%26X-Amz-SignedHeaders%3Dhost%26X-Amz-Signature%3D92b112581193205dc7fded65a0b9168daf202132c07f3190e83a72840e5b5840 - url encoded, signed URL with content-disposition provided (probably would expire soon)
https://bioimagesuiteweb.github.io/webapp/viewer.html?image=https://api.dandiarchive.org/api/assets/5ab0247b-659a-4593-b251-b338676de725/download/ -- uses original url which mints the presigned URL used above.

Ideally -- all of them should work ;) but console says

W.r.t. https://bioimagesuiteweb.github.io/webapp/viewer.html?image=https://dandiarchive.s3.amazonaws.com/blobs/472/10e/47210e31-7e86-4a9d-bcad-413825c4250a (direct link to the blob on S3 -- no extension),
BIS looks for a .gz extension to decide if to uncompress or not. If it does not find it, then it assumes that it is uncompressed and fails. I guess I can add a flag that if it fails uncompressed to then try to uncompress the file.

isn't there some JS equivalent of https://man7.org/linux/man-pages/man3/magic_getflags.3.html even if only for a few needed here "fingerprints" (well -- single one for -- gz).   google lead me to https://github.com/mscdex/mmmagic .
You could also, in case of exception like this, just try to assume that it is compressed and try to uncompress without sensing -- what evil could happen?

Try using the alphaapp -- I pushed a fix there.
https://bioimagesuiteweb.github.io/alphaapp/viewer.html

FWIW: https://bioimagesuiteweb.github.io/alphaapp/viewer.html?image=https://dandiarchive.s3.amazonaws.com/blobs/472/10e/47210e31-7e86-4a9d-bcad-413825c4250a works for me ... and even https://bioimagesuiteweb.github.io/alphaapp/viewer.html?image=https://api.dandiarchive.org/api/assets/5ab0247b-659a-4593-b251-b338676de725/download/ works -- woohoo!!

how fast alphaapp grows into app?  If it fails force gunzip and try again.
W.r.t. alphapp, usually we go alphaapp --> unstableapp --> webapp.
alphaapp is a playground
Once you test it and you are happy, I will move to unstableapp which despite the name stays like that for a while.
New "webapp" probably November/December.
Xenios

I think I am happier than before.  is it ok to just link out to "unstableapp" until the winter comes?  would allow for more testing etc ;)

Done. It might take a few minutes before github updates the pages.
Xenios

It is there, force the page to reload if you need to
https://bioimagesuiteweb.github.io/unstableapp/viewer.html
(You can tell if it is updated by the date in the bottom right corner on the status bar)

I meant, if it would be ok to link out to it from dandiarchive.org ;-) relevant draft pr: https://github.com/dandi/dandiarchive/pull/849


Task/native selectors

lgtm. I don't see anything in the code that would hold us back from releasing this in the dev version.


Meltano leaks secure settings to the frontend.

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1047
Originally created by @mbergeron on 2019-09-25 17:30:55

Before we dogfood Meltano and create a public instance we need to make sure there are no sensible information that can be leaked.
For instance, the configuration option should not show the value of environment variables or password kinds.

View 4 previous comments from the original issue on GitLab


Publish to GitHub Pages

Make the built site available on GitHub pages so anyone can see it without having to build the site locally.

https://bit-docs.github.io/website/


Typo for source.sourceType

Feel free to fix this outside this PR - just thought this was an interesting way to show you the typo

thank you!


fix: reduce char constraints on values

Proposed changes
Reduce char constraints on property values
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[x ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[ ] I have read the CONTRIBUTING doc
[ ] I have signed the CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

already done in https://github.com/stellio-hub/stellio-context-broker/pull/941 (tests also have to be ported)


fix: make prepare report keys json serializable

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Question on how I can learn

Hi,
I'm a software dev who uses Scala at work. I would like to learn more about AI and deep learning and was amazed by your work here. I was hoping you could give me pointers on how I could learn this specific field of AI better to hopefully make useful software for animators and artists one day.
How much theory should I go and learn? I learned programming by lots of self projects. I enjoy reading research papers. Would you recommend going through with them and experimenting?
Much thanks!

您的邮件已收到！谢谢！


fix: serialize chain id

wrap uint around buffer object

You should change the base branch from dev to release (and rebase your local changes with that), that's because on dev is outdated (and that's causing CI to complain).
But otherwise, looks fine. kinda surprised to see that it was necessary to have this extra cast

replaced with the PR https://github.com/ava-labs/ledger-avalanche/pull/101


[PUB-7] Unsupported platform architecture. Available only on amd64 and arm64 currently.

On an M1 Mac.
Following instructions at

ghuntley@ghuntleys-MacBook-Pro-2 ~ % curl -fsSL https://get.namespace.so/cloud/install.sh | sh
Executing Namespace Cloud's installation script...
Detected darwin as the host operating system
Unsupported platform architecture. Available only on amd64 and arm64 currently.
ghuntley@ghuntleys-MacBook-Pro-2 ~ % uname -a
Darwin ghuntleys-MacBook-Pro-2.local 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar  6 21:00:41 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T8103 arm64
ghuntley@ghuntleys-MacBook-Pro-2 ~ %

Will reboot and report back.
PUB-7

After upgrading to latest OSX:
ghuntley@ghuntleys-MacBook-Pro-2 ~ % curl -fsSL https://get.namespace.so/cloud/install.sh | sh
Executing Namespace Cloud's installation script...
Detected darwin as the host operating system
Unsupported platform architecture. Available only on amd64 and arm64 currently.
ghuntley@ghuntleys-MacBook-Pro-2 ~ % uname -a
Darwin ghuntleys-MacBook-Pro-2.local 22.5.0 Darwin Kernel Version 22.5.0: Mon Apr 24 20:53:44 PDT 2023; root:xnu-8796.121.2~5/RELEASE_ARM64_T8103 arm64
ghuntley@ghuntleys-MacBook-Pro-2 ~ %

Many thanks @ghuntley for reporting this bug! I pushed a fix and it should be live now.
Feel free to reopen the bug in case you still see this issue.


Update husky hooks

Got a warning for git commit
husky - DEPRECATED

Please remove the following two lines from .husky/pre-commit:

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

They WILL FAIL in v10.0.0

I haven't looked into what exactly needs changed or what they're doing in v10 but we should prep for it before the update lands if possible

@lukemckinstry it's not an error, just a warning. If you're not in the CLI your git client may be hiding it. Also please make sure you're using the latest version of husky, not sure if that matters but I assume it does.
From main:
git checkout -b testing-husky
touch test.js
git add .
git commit -m 'testing'
# see error

# to cleanup
git checkout main
git branch -D testing-husky


check that we can build genericly

As per https://github.com/SacBase/Stdlib/pull/28#pullrequestreview-285130621, this MR adds the missing check and cleans up the build system a bit.

Looks good to me.  Two minor points though:

CHECK_SAC2C_SUPPORT_GENERIC_FLAG can be generalised to check any sac2c flag.  All you need to do is to add an argument to the macro.
It seems that travis is failing because of a wrong path to sac2c package.  If you'll point it to weekly, it should be able to find the right one.

If you want to put (2) into a separate MR, I am fine with that, but as the change is so trivial, maybe you can just add the change here.

I've done both things, travis ci is working again.

I'd say that flag name autogeneration seem to be a bad idea.  Flags can contain all kinds of nonsense like :, . spaces, etc.  These symbols cannot be used as a part of cmake's identifiers.  You'd have to substitute for each such case... Instead, you can pass the name of the variable to be set as an extra argument.  See config.cmake in sac2c repo.
As for the travis, it is great that it works, but it is now fixed to a very specific sac2c version.  Maybe you can make a package alias, e.g. latest-weekly-basic-ub16 pointing to the latest weekly package.  Otherwise, we would always have to update the sac version in travis-config manually.
Sorry for being so picky.  If this MR is a showstopper, or you want to lift any of the task in a new MR, I am OK to merge it as is.

No worries, fair point regarding the variable name... I didn't consider that a user might want to check something like --foo bar,baz, to make a suitable variable name from this would be difficult.


USHIFT-3177: Avoid updating default router ips if status is the same

Updates to the network in the host trigger a possible update. This also triggers a log about an update that may be unnecessary (both the log and the update).
By comparing the current status and the new one we can avoid an API call and also log properly.

Which issue(s) this PR addresses:

Closes #

/lgtm

/test microshift-metal-tests


CHEBI:59437 please check

Hi,
CHEBI:59437, N(4)-{N-acetyl-beta-D-glucosaminyl-(1->2)-alpha-D-mannosyl-(1->3)-[N-acetyl-beta-D-glucosaminyl-(1->2)-alpha-D-mannosyl-(1->6)]-[beta-D-xylosyl-(1->2)]-beta-D-mannosyl-(1->4)-N-acetyl-beta-D-glucosaminyl-(1->4)-N-acetyl-beta-D-glucosaminyl}-L-asparagine zwitterion
Please check the entry. All others fields are checked.
Cheers,
Kristian

Now done.


Ensure all HTTP request are HTTPS-based.

Enhancement Proposal
Modify the code to ensure all HTTP request are secured with HTTPS.

@yhaliaw I think this is no longer necessary, can you confirm and close the issue, please?


Add the SMOD word in the target submodule file name.

Edited the file esma_add_fortran_submodules.cmake to add the SMOD word in the target submodule file name. Now the submodule file name (file.F90) will be renamed (for compilation purpose only) moduleName_SMOD_file.F90 instead of moduleName_file.F90.

@JulesKouatchou I changed the base and pushed a change to the CHANGELOG. Have you tested this and does it work with MAPL3?

@mathomp4 Yes, this works with MAPLv3.

@mathomp4 Yes, this works with MAPLv3.

Okay. I'll make a couple releases (still need a v3 and v4).

I'm waiting on the CI in #394 to make sure it is happy. Once so, releases will be coming.


Bug: z.void() schema output

I've just upgraded from v3.18 to v3.20 and noticed that the schema returned from z.void() is now {} instead of undefined. I've looked through the changelog and not seen this mentioned (therefore assume it's a bug?).
Reproduction: https://stackblitz.com/edit/typescript-6vgab1?devToolsHeight=33&file=index.ts
Thanks 🙌

Hey @jlalmes, thanks for the issue report. The PR above should fix your issue, but I'm hesitant to merge it due to it being a breaking change; while it's true that 3.18 returned undefined, 3.19 did not, and the main return type has never reflected the possibility of returning undefined.
These unresolvable types have always been a bit of a thorn in my side with this package and I've never been able to come up with a unified one-size-fits-all solution. I don't think this is it either and will be closing the PR for now, but I'm keeping the issue open to promote discussion.


[Feature-Request] TridentBackendConfig for ontap-sap to support mounting the secrets via volume and service account for AWS FSx NetApp ONTAP integrates with AWS Secrets Manager

Describe the solution you'd like
Hi, I am using Trident Operator on EKS to spin up AWS FSx NetApp ONTAP filesystem volume. In configuring the backend, i find out that using the TridentBackendConfig with ontap-san storageDriverName, I have to specify the secrets manually in the Kubernetes Secrets. However, the FSx NetApp ONTAP Filesystem credentials (Filesystem password and SVM password are stored in AWS Secrets Manager). The official AWS Secrets Store CSI supports mounting the secrets as volumes, and the service account. As specifying in the secrets itself does not seem to be a very secure way in the AWS ecosystem.
Here is the existing Yaml i configured to use my Trident backend
apiVersion: trident.netapp.io/v1
kind: TridentBackendConfig
metadata:
  name: backend-fsx-ontap-san
spec:
  version: 1
  backendName: fsx-ontap-san
  storageDriverName: ontap-san
  managementLIF: svm-XXXXXX.fsx.us-east-1.amazonaws.com
  dataLIF: <IP_ADDRESS>
  svm: svm1
  credentials:
    name: backend-fsx-ontap-san-secret
---
apiVersion: v1
kind: Secret
metadata:
  name: backend-fsx-ontap-san-secret
type: Opaque
stringData:
  username: vsadmin
  password: password

Describe alternatives you've considered
In order to leverage AWS Secrets Manager, AWS Secrets Store CSI and service account support is required for TridentBackendConfig. Wondering whether it can add the support for getting secrets via volumes and support service account ?
This is an example of Kubernetes deployment using the Secrets Store CSI:
kind: Service
apiVersion: v1
metadata:
  name: nginx-deployment
  labels:
    app: nginx
spec:
  selector:
    app: nginx
  ports:
    - protocol: TCP
      port: 80
      targetPort: 80
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: nginx-deployment
  labels:
    app: nginx
spec:
  replicas: 2
  selector:
    matchLabels:
      app: nginx
  template:
    metadata:
      labels:
        app: nginx
    spec:
      serviceAccountName: nginx-deployment-sa
      volumes:
      - name: secrets-store-inline
        csi:
          driver: secrets-store.csi.k8s.io
          readOnly: true
          volumeAttributes:
            secretProviderClass: "nginx-deployment-aws-secrets"
      containers:
      - name: nginx-deployment
        image: nginx
        ports:
        - containerPort: 80
        volumeMounts:
        - name: secrets-store-inline
          mountPath: "/mnt/secrets-store"
          readOnly: true

Additional context
Add any other context or screenshots about the feature request here.

I agree with @haofeif trident need to support fetchin othe kinds of secrets such as secrets-store.csi.k8s.io, which will enable the usage of many different secrete providers such as AWS secret manager, azure key vault, hashicorp vault, google secret manger etc....
//Andreas

@haofeif
We took the decision to use external-secrets.io until support for Secrets Store is available for Trident. Not but better than manual tasks.
//Andreas

Trident 24.02 adds FSxN personality to the ONTAP drivers, including support for workload identity for AWS credentials and Secrets Manager support for the FSxN SVM credentials.  It also fixes the incompatibility between Trident and FSxN volume backups.


Jasmine: Add .and for spies, pending, DEFAULT_TIMEOUT_INTERVAL

This exposes a bit more of Jasmine.
Unfortunately I haven't been able to run tests locally (Windows). Following the instructions in the README is kind of a non-starter because it immediately complains about an ENOENT related to the first definition. There's also a CONTRIBUTING.md in the definitions that throws a wrench in the works, which I had to locally delete to confirm structure.
I got a lot farther running run_def_tests.cmd but I hit a lot of errors, especially ENOENT: no such file or directory, scandir 'C:\gitrepos\flow-typed\cli\.flow-bins-cache'.
If anyone can lend advice, I'd much appreciate it, since I'd also like to submit some fixups for lodash/fp at some point.

 Fixing the CONTRIBUTING.md issue should be as easy as updating to the latest patch of flow-typed. As for the other issue, try creating the cache manually. There is an up-and-coming PR to allow you to set a custom cache-dir location, but that won't be available for a while.

The latest version of flow-typed on npm supports extra file types. Try removing it globally and npm install -g<EMAIL_ADDRESS>

I'm not sure what you mean. Why would I try to confirm the file structure (validate-defs) from a global install of flow-typed?

Most commands will check the file structure, including install (for some reason...). The latest version of flow-typed allows for more file types, and loosens the restrictions. Just upgrading should fix the issue you're facing.


[Android] Keyboard remains visible when app goes to background

When setting the focus programmatically using textInput.set('focused', true), the keyboard remains open when the app goes to background.
When the widget is focused interactively, this is not the case.

Fixed in Android platform.


Add other data types

Add types like float and byte.

This was added in ini-Reader 2.0. I can't remember if it was tested on RIO tho.


Infinite loop if input is string.empty in SamplingScoreGenerator

https://github.com/Microsoft/ApplicationInsights-dotnet/blob/c06a87bfb6ac4d28129f6e3da7c6c0f7e02d623c/src/ServerTelemetryChannel/Managed/Shared/Implementation/SamplingScoreGenerator.cs#L39-L47
I propose changing the null check to if (string.IsNullOrEmpty(input)).

We'd appreciate if you can send a PR. Thanks for reporting


Fix Windows process job handle leak

this fixes https://github.com/sensu/sensu/issues/1057

Thanks! Released as 0.5.8.


Station M&C Integration

At some point this needs to happen for scheduled power beam recordings.

07d934e and 34732f8 work on this from the monitoring side, c8cb0d5 from the control side.  They aren't complete but it is something and it should be "relatively easy" to adapt these to the etcd framework.

Hrm, is operations.OperationsQueue thread safe?

ddc7c5b switches the operations queue over to a deque.

cf5b6a1 has some questions that need to be answered with regards to an overall system status.

This seems to be in pretty good shape now with the mcs.py module and the new documentation.


Thumb: Implement pc-relative load

Signed-off-by: Federico Guerinoni<EMAIL_ADDRESS>

Codecov Report
Base: 46.88% // Head: 49.57% // Increases project coverage by +2.69% :tada:

Coverage data is based on head (ffdf16c) compared to base (627193c).
Patch coverage: 61.36% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   46.88%   49.57%   +2.69%
==========================================
  Files          30       31       +1
  Lines        1717     1761      +44
==========================================
+ Hits          805      873      +68
+ Misses        912      888      -24

Impacted Files
Coverage Δ

emu/src/cpu/alu_instruction.rs
86.36% <ø> (ø)

emu/src/cpu/condition.rs
16.66% <ø> (ø)

emu/src/cpu/cpu_modes.rs
75.00% <ø> (ø)

emu/src/cpu/instruction.rs
67.05% <ø> (ø)

emu/src/cpu/psr.rs
75.00% <ø> (ø)

emu/src/cpu/registers.rs
83.33% <ø> (ø)

emu/src/cpu/single_data_transfer.rs
92.30% <ø> (ø)

emu/src/gba.rs
0.00% <ø> (ø)

emu/src/cpu/move_compare_add_sub.rs
46.66% <46.66%> (ø)

emu/src/cpu/opcode.rs
83.33% <75.00%> (ø)

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add an example to insert data from JSON string?

Hi @kirillDanshin
Sorry, this ticket is a bit vague, what is it that you are trying to do again ?
This looks like more of a Golang question rather than GoRethink question.
Correct me if I'm wrong, but you want to marshal a json string into a struct and insert this into rethinkdb ?
Cheers.

hi @thomasmodeneis
I want to skip JSON unmarshaling

Hi @kirillDanshin
How do you mean skip JSON un marshalling ?
In order for you to get the object and be able to use it with the golang you will be required to transform it into a object, something like this:
var rows []interface{}
err := res.All(&rows)
if err != nil {
    // error
}

How otherwise are you planning to do this ?
Cheers.

hi @thomasmodeneis
I mean that I have a JSON string that I read from HTTP POST request. I want to store that JSON as a rethinkdb document without unmarshaling it to a struct/map/anything else.

In that case, you need to use another programming language.
Maybe https://github.com/neumino/rethinkdbdash is better for your needs.

hmm.
I believe I just need to find the way to do it and publish it on github.


[Feature] Slow sources benchmark and timeout

As I adding more sources to cmp the cmp is getting slower.
Is it possible poll the source in parallel and timeout the slow one? Also would be good to show some statistics on the source performance.  I have no clue which source is slow and should be turned off. (tablenine is an obvious one)

Benchmark is possible to implement.
But parallel request is impossible in current neovim.

@ray-x I'm experiencing the same, but your issue gave me an idea. Since according to @hrsh7th parallel requests are not possible, then what about lazy loading the completion elements?
For example: cmp-spell gives spell suggestions using vim's spellsuggest, which ends up giving a vast amount of completion items and hence slows down nvim (mostly when typing). @hrsh7th would it be possible to only "pull", for instance, the first 5 completion items from x source, and then when nvim-cmp's popup/floating window is scrolled load another five and so on and so forth?

I have no clue which source is slow and should be turned off

In my case cmp-spell and cmp-path.

I don't think spellsuggest returns a lot of items. How to reproduce such behavior?

Path source is depends on disk speed.

Basically what @Shougo said. To reproduce the spellsuggest behaviour, well, add the cmp-spell source and just type fast or keep pressing backspace in a markdown file, you should be able to see some "lag".

If spellsuggest itself is slow, there's nothing we can do because spellsuggest API is vim native and only allows synchronous call, right?
The path source is using Luv API so it work as parallel (partially).

The slow is not the same meaning as lag.

Path source is depends on disk speed.

This means slow. Because cmp-path uses Luv API so it wont cause the lag.

This can be the reason to the lag.

Some suggestions:

When enforce timeout, set the priority for sources based on sources array index when timeout is used.  e.g.

sources = {
      {name = 'nvim_lsp'}, {name = 'buffer'},  {name = 'look'},
    }

That will let cmp get items from lsp first and then buf and then look.
When timeout,  drop the result if low priority sources do not finish.
Alternatively use the priority field.

disable/enable sources for filetype type. Instead of using autocmd on FileType suggested in README.md use this:

e.g.
sources = {
      {name = 'nvim_lsp'}, {name = 'buffer'}, {name = 'nvim_lua', ft='lua'},{name = 'look', ft={'markup','html'}},
    }

this will only enable nvim_lua for lua, and look for markdown and html file types.
This setup will be more consistent with other setups for sources, e.g. keywork_length setup.

The same issue.
I found that nvim-cmp is a little bit slower than nvim-compe

I can't figure out it. How slow it?

I found that nvim-cmp is a little bit slower than nvim-compe

Isn't that relative to the amount of sources/which sources you are using?

I found that nvim-cmp is a little bit slower than nvim-compe

Isn't that relative to the amount of sources/which sources you are using?

https://github.com/hungrybirder/dotfiles/blob/using_nvim_cmp_but_it_is_slower/nvim/lua/module/nvim-cmp.lua
  sources = {
    { name = 'nvim_lsp'},
    { name = 'path'},
    { name = 'nvim_lua'},
    { name = 'vsnip'},
    { name = 'calc'},
    { name = 'emoji'},
    { name = 'tags'},
  },

But I use the same sources in nvim-compe and it's really fast.

Can you upload the examples?

I have a feeling the difference is caused by throttle_time = 80 setup.

I have a feeling the difference is caused by throttle_time = 80 setup.

Is there a way to setup throttle_time in nvim-cmp?

I've improved the performance. Could you test with latest?
And throttle_time was removed. Currently, I'd specified 50ms as a hardcoded value.

I suspect the following codes:
https://github.com/hrsh7th/cmp-buffer/blob/5dde5430757696be4169ad409210cf5088554ed6/lua/cmp_buffer/buffer.lua#L43
https://github.com/hrsh7th/cmp-buffer/blob/5dde5430757696be4169ad409210cf5088554ed6/lua/cmp_buffer/init.lua#L59
need to be double-checked.
From what I see. If the buffer source is in processing state, the callback will be updated after 50ms(hardocded). 100ms timer and 200ms timer has some impact on the overall performance.

I've improved the performance. Could you test with latest?
And throttle_time was removed. Currently, I'd specified 50ms as a hardcoded value.

I use commit b6b15d5f6e46643462b5e62269e7babdab17331c.
It works well.
Now I switch nvim-compe to nvim-cmp.
😄

@hungrybirder since you just migrated from compe, I'd recommend ya my cmp + luasnip + friendly snippets + autopairs setup and my cmp config ;)

@hungrybirder since you just migrated from compe, I'd recommend you my cmp + luasnip + friendly snippets + autopairs setup and my cmp config :)

I'm using cmp + autopairs + (cmp-vsnip+vsnip+friendly-snippets).
I'll check luasnip later and learn your config.
Thank you.

Is it possible to cache all the completion from sub-packages from the start? E.g. I'm writing Python with TensorFlow package, and after I entered tf.keras. I need to wait for about 1~2s for the completion menu to show up.

It seems LSP slowness.
pylsp use jedi and it is slow.
You can use pyright lsp instead.

@Shougo: It seems that pyright will cause high-cpu usage so I change to use pylsp. Anyway, I will try out pyright again.

Is it possible to cache all the completion items from sub-packages from the start?

I think pyright implements this feature, and it uses CPU usage.
So it is trade off.

[...]
You can use pyright lsp instead.

@Shougo: I just confirmed that pyright is indeed (much) faster. Thanks for your help!

[...] Also would be good to show some statistics on the source performance [...]
(scroll to top)

While this might be off-topic, but it would be cool if these statistics can be shown on the status line, or even be combined with plugin like nvim_notify.


Auto 'zoom' on mobile.

Have added a meta tag that 'should' zoom the view in automatically on a non-desktop device. Can view on the experimental site.

Yes, demo site is zoomed, very usable. On BB10 browser.

Merged into main.


Upgrade browserify to latest

Hi there, awesome job with this wrapper. Can you please upgrade browserify to latest? Thanks.
There seems to be a bug that my whole absolute path to script is exposed to the output which contains folder names, OS specific and usernames. This is not ideal because I want to keep it generic.
I think it's related to https://github.com/substack/node-browserify/issues/675

Coverage remained the same at 87.18% when pulling 2ad39cbae6f75be5d29f4cc8b425467e83d6fcfe on van-nguyen:master into 76f934e4efaf399fa470989d979361d8bf41e70d on ForbesLindesay:master.

Upgrading browserify would be great!

An update to 9.x would be great!

Done


chore(perf): switch transaction fee of public context to u64

Please read contributing guidelines and remove this line.

Benchmark results
Metrics with a significant change:

protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 664 (-52%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
5,749
1,569 (+1%)
715 (-1%)
752 (-1%)
768 (-2%)

proof_construction_time_sha256_30_ms
11,472
3,096
1,384
1,436
1,465 (-1%)

proof_construction_time_sha256_100_ms
44,160
11,757 (-1%)
5,442 (-1%)
5,592 (+2%)
5,725

proof_construction_time_poseidon_hash_ms
78.0
34.0
34.0
58.0 (+2%)
88.0 (-1%)

proof_construction_time_poseidon_hash_30_ms
1,528
422
205
224
265

proof_construction_time_poseidon_hash_100_ms
5,681 (+1%)
1,517
677
728 (-1%)
753 (+1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
4,356
7,876
14,884

l1_rollup_calldata_gas
50,220
92,946
177,940

l1_rollup_execution_gas
843,039
1,576,661
3,361,711

l2_block_processing_time_in_ms
254
437
803 (-1%)

l2_block_building_time_in_ms
11,501 (+1%)
22,481 (+1%)
45,432 (+2%)

l2_block_rollup_simulation_time_in_ms
11,500 (+1%)
22,481 (+1%)
45,432 (+2%)

l2_block_public_tx_process_time_in_ms
9,821 (+1%)
20,767 (+1%)
43,664 (+2%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
2,918
3,746

node_database_size_in_bytes
12,652,624
16,744,528

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit
simulation_time_in_ms
witness_generation_time_in_ms
input_size_in_bytes
output_size_in_bytes
proving_time_in_ms

private-kernel-init
91.6 (-6%)
400 (+3%)
21,474
44,898
N/A

private-kernel-inner
177 (+1%)
706 (+2%)
72,411
45,020
N/A

private-kernel-reset-tiny
310
718 (+1%)
65,240
44,886
N/A

private-kernel-tail
167 (-1%)
136 (-1%)
50,608
52,921
N/A

base-parity
5.57
N/A
160
96.0
N/A

root-parity
35.3 (+1%)
N/A
73,948
96.0
N/A

base-rollup
2,860 (+9%)
N/A
189,168
664
N/A

block-root-rollup
41.5 (+1%)
N/A
58,205
2,448
N/A

public-kernel-setup
85.4 (+1%)
N/A
105,085
71,222
N/A

public-kernel-app-logic
97.4
N/A
104,897
71,222
N/A

public-kernel-tail
866 (+1%)
N/A
390,582
16,414
N/A

private-kernel-reset-small
309
N/A
66,341
45,629
N/A

private-kernel-tail-to-public
:warning: 664 (-52%)
615 (+3%)
455,400
1,825
N/A

public-kernel-teardown
84.0 (+1%)
N/A
105,349
71,222
N/A

merge-rollup
20.4 (+2%)
N/A
38,174
664
N/A

undefined
N/A
N/A
N/A
N/A
82,924 (+1%)

Stats on running time collected for app circuits

Function
input_size_in_bytes
output_size_in_bytes
witness_generation_time_in_ms

ContractClassRegisterer:register
1,344
11,731
340 (-2%)

ContractInstanceDeployer:deploy
1,408
11,731
18.3 (-2%)

MultiCallEntrypoint:entrypoint
1,920
11,731
402 (-2%)

FeeJuice:deploy
1,376
11,731
384 (-3%)

SchnorrAccount:constructor
1,312
11,731
73.3 (-5%)

SchnorrAccount:entrypoint
2,336
11,731
386

FeeJuice:claim
1,344
11,731
36.7 (-7%)

Token:privately_mint_private_note
1,280
11,731
104 (+4%)

FPC:fee_entrypoint_public
1,344
11,731
26.2

Token:transfer
1,312
11,731
230 (-5%)

Benchmarking:create_note
1,344
11,731
87.2 (+2%)

SchnorrAccount:verify_private_authwit
1,280
11,731
27.4 (-13%)

Token:unshield
1,376
11,731
520 (-4%)

FPC:fee_entrypoint_private
1,376
11,731
693 (-2%)

AVM Simulation
Time to simulate various public functions in the AVM.

Function
time_ms
bytecode_size_in_bytes

FeeJuice:_increase_public_balance
52.8 (+3%)
8,174

FeeJuice:set_portal
12.1 (-20%)
4,055

Token:constructor
80.0 (-3%)
29,082

FPC:constructor
54.0 (-4%)
18,940

FeeJuice:check_balance
38.5 (-2%)
5,978

Token:mint_public
52.8 (+1%)
12,704

Token:assert_minter_and_mint
493 (+2%)
8,467

AuthRegistry:set_authorized
48.2 (+28%)
4,194

FPC:prepare_fee
247 (+10%)
6,747

Token:transfer_public
26.0 (-10%)
39,863

FPC:pay_refund
58.8 (+10%)
8,500 (-10%)

Benchmarking:increment_balance
1,240 (+2%)
7,263

Token:_increase_public_balance
42.0 (-1%)
8,686

FPC:pay_refund_with_shielded_rebate
56.3 (-10%)
8,983 (-9%)

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.148 (-9%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
2.14 (-2%)
3.90 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.112 (-1%)
0.111 (+2%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
11.2
17.6 (+1%)
30.6 (-1%)
58.6 (-2%)
112 (-1%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.107
0.103 (+1%)
0.0997 (-1%)
0.101 (-2%)
0.100 (-1%)

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
14.6
25.4 (-1%)
43.3
82.3
161 (-1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
108
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.113 (+2%)
0.103
0.105
0.102 (-1%)
0.103 (-1%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
16.4 (+1%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
132 (+1%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.106
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
64,838
668,997

Transaction size based on fee payment method
| Metric |  |
| - |  |


Missing dependencies

Expected behavior
Dependencies declared for unit tests are also usable for integration tests. For instance:

testImplementation("org.wiremock:wiremock:3.7.0")

Actual behavior
Dependencies are not furher shared and need to be redeclared if required for integration tests:

testImplementation("org.wiremock:wiremock:3.7.0")
integrationTestImplementation("org.wiremock:wiremock:3.7.0")

Is this a desired behavior or a bug? With com.hivemq.extension 2.x everything works as expected.

Hi @justeff
yes, this is intended behavior.
This was one of the changes in the 3.x major version: https://github.com/hivemq/hivemq-extension-gradle-plugin/releases/tag/v3.0.0

Remove integration test dependencies on main source set and test dependencies

Reason for this change:

Following conventions: Gradle itself does not add dependencies to test suites other than unit tests:

By convention, only the built-in test suite will automatically have a dependency on the production code of the project.

(https://docs.gradle.org/current/userguide/jvm_test_suite_plugin.html#jvm_test_suite_plugin)

Only white box tests such as unit tests should have access to the main source code

You can still configure the dependencies between the test suites on your own if it is really required, but I would recommend  to avoid that


feat: display more context on binary exit

closes #110
Two changes:

change pid from pid file to the real pid
display pid and start args on exit

It now looks like

notice: when you exit the gtctl, the cluster (include log file) will also be deleted. so for those users who want the logs remain, consider add a RetainLogs option for bare-metal mode. I'm working on this right now.

Just run into this problem lol


Project Design [Front-End]

User Story
As a developer, I want to be able to understand how the application should look and be interacted with across different platforms.
Description

Create the front-end design of the application.

Update

Added basic design for the landing page to Figma.
Still need to build out both the appearance of the application itself on both desktop and mobile platforms.

Completed basic design overview. Available now on Figma.


add onPressIn and onPressOut props on text page

The Text page of the documentation doesn't explain that the components embarks also the onPressIn and onPressOut props.
Related to the issue #3563

sure, will do that :) Thank you for the quick review!


Hot Exit via Unity Launcher

Issue Type: Bug
When multiple editors are open, each with unsaved files, choosing File->Exit (Ctrl-Q) will do a 'hot exit'. Launching VS Code again will restore all editors along with all the unsaved files. However, when right-clicking the Unity launcher icon for VS Code and choosing Quit, each of the editors prompts to save its unsaved files.
Expected:
An overall exit/quit, whether via the File menu or the Unity launcher, should behave consistently and perform the 'hot exit'.
Actual:
The behavior of the exit varies depending on how it was invoked.
VS Code version: Code 1.21.1 (79b44aa704ce542d8ca4a3cc44cfca566e7720f1, 2018-03-14T14:46:30.761Z)
OS version: Linux x64 4.4.0-116-generic

System Info

Item
Value

CPUs
AMD Athlon(tm) 64 X2 Dual Core Processor 5000+ (2 x 2600)

Load (avg)
2, 2, 1

Memory (System)
5.83GB (0.17GB free)

Process Argv
/usr/share/code/code --unity-launch

Screen Reader
no

VM
0%

Extensions: none
Reproduces without extensions

I'm not sure we can do anything about this, I think Unity is probably telling each window to close as opposed to telling all windows to close (which I guess it can't communicate). I assume this could also be reproduced in Windows but not macOS as quitting the application (all windows) is an OS-level concept.

@bpasero I say we should close this off as not fixed unless you think it's a good idea to put some delay before we send the save files dialog to check how many windows are being closed.

Fair enough, thanks for the quick response and insight into the problem. TBH, I didn't even realize there was a behavioral difference between right-click->Quit and File->Exit. I did a search to see if the issue had been reported for closing multiple editors as opposed to just one and I found #101, which indicated that hot-exit worked for multiple editors too. Now that I know File->Exit works, I'll probably just use that instead.

@bpasero I agree :+1:


fix: expressionUsesOnlyAllowedLabelsForMetricRegexp logic

Signed-off-by: Martin Chodur<EMAIL_ADDRESS>This should hopefully fix all the corner cases that were there :crossed_fingers:

@david-vavra FYI as you implemented the first iteration


High memory growth over time

Have you checked the roadmap on the website, and existing issues, before opening a dupllcate issue?
Yes
Describe the bug
There seems to be a memory leak / unconstrained growth. The process seems to gain ~a couple hundred MB of used memory every day.
To Reproduce
Steps to reproduce the behavior:

Run the app
Index ~150k entries over 3 days
App takes >1GB of memory

Expected behavior
App takes close to the initial size, or has a configuration option that sets the high bound for caches.
General (please complete the following information):

Bitmagnet version: 0.0.7
OS and version: nixos

I'm happy to provide more info if there's a good way to get some more detailed numbers out of the app.

Thanks. There's currently a complete rewrite of the DHT crawler happening - the present implementation is rather spaghettified and also non compliant with DHT standards (see the other issue on this). So there's probably not much point trying to track this down right now but let's see where we are when that's done...

Hi @viraptor , I believe this is fixed in the linked PR which will be merged shortly. For me memory usage is remaining below ~200MB with the default configuration.

357MB with ~600k entries indexed, but seems to be holding steady. I'll report back if things change.
On another positive note, the CPU usage is WAY lower now.

grateful for the fixes!

Thanks for confirming @viraptor - I wonder what causes the memory difference - different hardware perhaps; I don't think total indexed entries should affect memory usage. If it's holding steady then that's the main thing...
I'm also curious what throughput people are getting from the crawler as I get dramatically different results on similar hardware (though universally better than the previous version).
So for example:
select count(*),
       extract(year from created_at) as year,
       extract(month from created_at) as month,
       extract(day from created_at) as day,
       extract(hour from created_at) as hour
from torrents
group by year, month, day, hour
order by year desc, month desc, day desc, hour desc
limit 100

This tells me I'm crawling 5-7k per hour on my M2 Mac Mini but more like 30k per hour on my M2 MacBook Air which is a bit weird. One of the next steps will be to add some telemetry to the different pipeline stages of the crawler so I can understand better where the bottlenecks are.
BTW I have set up a Discord that you're welcome to join, I'll put it on the website in due course but it's here: https://discord.gg/WecPrUFr (cc @Giggitybyte )

In terms of BW, ~2-4Mibps down.
 count | year | month | day | hour
-------+------+-------+-----+------
  5349 | 2023 |    11 |   8 |   10
 11594 | 2023 |    11 |   8 |    9
  9079 | 2023 |    11 |   8 |    8
 12309 | 2023 |    11 |   8 |    7
  4052 | 2023 |    11 |   8 |    6
  9241 | 2023 |    11 |   8 |    5
  8892 | 2023 |    11 |   8 |    4
 14505 | 2023 |    11 |   8 |    3
 11609 | 2023 |    11 |   8 |    2
 13393 | 2023 |    11 |   8 |    1
 11591 | 2023 |    11 |   8 |    0

So averaging 10k or so per hour on a 2013-era underpowered intel.

This tells me I'm crawling 5-7k per hour on my M2 Mac Mini but more like 30k per hour on my M2 MacBook Air which is a bit weird. One of the next steps will be to add some telemetry to the different pipeline stages of the crawler so I can understand better where the bottlenecks are.

I'll make an issue once I've understood the problem well enough to actually describe it, but with the new version my crawling rate craters after a couple hours due to what appears to be some sort of network-related problem (as in it gets in a state where TCP latency shoots up drastically). So based on very little my guess would be that your Mac Mini and your MacBook Air might be on the network layer.

my crawling rate craters after a couple hours due to what appears to be some sort of network-related problem (as in it gets in a state where TCP latency shoots up drastically)

Thanks @leofidus , let me know your findings - I've not seen this happen myself. Weird that it only happens with the new version, especially as the old version had a TCP connection leak bug (https://github.com/bitmagnet-io/bitmagnet/issues/42)

Looks like my issue was related to a piece of network gear not being able to keep up. I've set DHT_CRAWLER_SCALING_FACTOR=1 and now have a stable connection, with about 10k torrents/hour, at about 4Mbps down, 2 Mbps up (though the down rate is really fluctuation between 1.5Mbps and 13Mbps at a relatively stable 500-800 pps, according to iptraf-ng). Memory usage is about 130MB for the bitmagnet docker container.

Thanks @leofidus , that's interesting - I might have set the default for that a bit too high then.
So (in case you hadn't seen) we have all these buffered channels and semaphores in the crawler pipeline: https://github.com/bitmagnet-io/bitmagnet/blob/main/internal/dhtcrawler/crawler.go#L56
The optimal values for these might depend on any number of factors, I thought it would be too much to expose these all as configurable, hence the scaling factor. I haven't done a lot of experimenting with these or been able to compare results with a wide variety of hardware/network conditions....

If you expose the runtime metrics in some way like https://github.com/mmcshane/salp or https://prometheus.io/docs/guides/go-application/ I'm happy to report how things are working in a couple environments.

Hi @viraptor , there's some basic info available on the bitmagnet:3333/status endpoint.
There is also a Gops agent running in the app: https://github.com/google/gops If you mount a local directory to /tmp in the container you can do things like docker exec bitmagnet gops pprof-heap 1 or docker exec bitmagnet gops pprof-cpu 1 and look at the output file with go tool pprof; I think this can also link to things like Prometheus but I'm not too experienced with this...
I'm intending to add some better telemetry solution but need to look at the options, I was thinking possibly https://opentelemetry.io/docs/instrumentation/go/

opentelemetry sounds great too 👍


Algeria marriage abroad

https://govuk.zendesk.com/agent/tickets/2223115
I've updated the 3 user in the UK, opposite sex outcomes to tell users to exchange their CNI at the embassy.
This doesn't affect the logic.

superseded by https://github.com/alphagov/smart-answers/pull/3203


[Suggestion] Boss indicators for Raids

Making small indicators for vanguards or for each bosses. Like for vanguards, a indicator that shows each
vanguard HP or the difference in percentages.  For shamans, you can have a little indicator for whenever he spits out acid and this can be the exact same concept for other bosses if needed.

I think @Kamielvf is working on adding more features to the existing raids plugin, such as the vanguard indicator you're asking for

This is provided in the Cox Timers & Additions hub plugin, and possibly others? This is somewhat less important now that the vanilla boss hp widget shows a range for the health they must stay within.


upgrade flatbuffers from 2.1.2 to 23.5.26 to address security issue

What is changed and how it works?

Issue Number: Ref #15621
What's Changed:

The security issue is https://github.com/google/flatbuffers/issues/6627.
Upgrade flatbuffers from 2.1.2 to 23.5.26 to address it.

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

No code

Release note
None

/test

/merge

/cherry-pick release-6.5


Refactor client factories to avoid forcing references

References are ok, but sometimes they don't make sense for some particular factories.

Closed by #50