Remove the global output buffer; compile on render_in

What are you trying to accomplish?
A few months ago, I added an experimental feature called the global output buffer. We were attempting to build a forms framework at GitHub, and since it's a known issue that form helpers don't work very well with components, I was trying to work up a solution that would unblock the forms work. Unfortunately the final global output buffer solution monkeypatches actionview to an unsettling degree. It also turned out we didn't need it for the forms work after all. Finally, it appears it doesn't work with edge rails anymore. So let's get rid of it!
Because the global output buffer degraded performance a bit, I also worked up a patch to counteract it. Unfortunately the patch has led to a number of subtle bugs in development environments, so let's remove it too.

It also turned out we didn't need it for the forms work after all.

@camertron If you're able to elaborate on this, I'd be interested in knowing a bit more!

@Spone good question! I was able to get around the form helper issues by creating what I've been calling "view_component lite" inside the primer/rails_forms repo, which is where our new forms framework lives (for now). VC lite is really just a barebones VC implementation that doesn't inherit from ActionView::Base. The important bit is in the ActsAsComponent module. It works by delegating everything to the view context, including the output buffer. I tried a similar approach in view_component but unfortunately the delegation adds quite a bit of overhead. Forms generally represent a fairly small area of the page so the performance hit was acceptable, but not reasonable for all view components at large.

@camertron Understand the desire to remove nasty hacks etc, but just wondering if there is or will be any 'official' solution to the forms problem now? Was relying on the global output buffer to fix my form rendering woes! Could the solution in rails_forms be made into something that can be added more generally to other apps that dont use rails_forms? thanks for any suggestions!

Not for everyone looking primer/rails_form has been archived. The work has been merged with primer/view_components. You can find the latest code at https://github.com/primer/view_components/pull/1238

Woops @stevegeek, I totally missed your comment in August, sorry about that!

Understand the desire to remove nasty hacks etc, but just wondering if there is or will be any 'official' solution to the forms problem now?

A semi-recent change to action view has removed the need to reassign @output_buffer when capturing, which was one of the big problems the global output buffer was designed to solve. Unfortunately our action view compatibility tests still fail on Rails main, so the Rails change isn't enough. I'm planning on having a deeper look tomorrow.

Could the solution in rails_forms be made into something that can be added more generally to other apps that don't use rails_forms?

Maybe? We could certainly extract the ActsAsComponent module into its own gem. We have tests in primer/view_components that demonstrate view components can be rendered inside ActsAsComponent templates. Theoretically you could write a component which includes ActsAsComponent (instead of inheriting from ViewComponent::Base) and call form helpers + render other view components in the template. I think that would work?
Honestly the long-term fix is probably to stop inheriting from ActionView::Base, but that's going to take a Herculean amount of effort.

@camertron thanks for the reply! Ok understood. I will wait and see how it all evolves and look at ActsAsComponent. For now thanks for taking the time to elaborate on the situation!

@stevegeek things move fast in the VC world! @BlakeWilliams has this PR up for review right now which is another take on fixing our buffer issues. It's very likely going to get merged this week I'd say.

@camertron amazing news!


Unable to open the app

Hi, on Windows 11 now. About two weeks ago I started being unable to open the Bluebubbles app. I've tried restarting, updating, reinstalling and trying the version from the windows store. I still can't get the application to open. Any tips?

I'm not sure how to go about debugging since idk where the logs go - please let me know what info you need. It is such an amazing app and I need to get back to using it ASAP :D

See #2629


fix: use setBaseAndExtent instead of removeAllRanges

Details

Use selection.setBaseAndExtent instead of selection.removeAllRanges(); selection.addRange(range) to avoid the keyboard on Android chrome to hide
Related Issues

$ https://github.com/Expensify/App/issues/41137
PROPOSAL: https://github.com/Expensify/App/issues/41137#issuecomment-2121656214
Manual Tests

Use Android chrome and go to the main page https://<IP_ADDRESS>:8082
Tap on a report
Paste any text repeatedly and note the page
Expected: The keyboard should remain open and visible after the paste. Also, the caret position must be maintained.
Linked PRs

https://github.com/Expensify/App/pull/42622

@dominictb Thanks for the PR! We'll review it soon


Bug: form_open with no URL supplied

PHP Version
8.1
CodeIgniter4 Version
4.5.0
CodeIgniter4 Installation Method
Manual (zip or tar.gz)
Which operating systems have you tested for this bug?
Linux
Which server did you use?
apache
Database
MySQL
What happened?
When using the helper form_open() with no URL, an error is thrown:
str_contains(): Argument #1 ($haystack) must be of type string, CodeIgniter\HTTP\SiteURI given
Steps to Reproduce
echo form_open();

Expected Output
I expect the current_url(false) (a string) to be used as a URL.
form_helper, line 34
$action = current_url(true);
returns a CodeIgniter\HTTP\SiteURI
Anything else?
No response

This bug has already been fixed. See number #8736
duplicate #8729

I expect the current_url(false) (a string) to be used as a URL.

It is not true. current_url(false) and (string) current_url(true) are different.


Convert src/middleware to TS

Is your feature request related to a problem? Please describe.
Convert src/middleware to TS
Describe the solution you'd like
Convert src/middleware to TS
Avoid making logic changes to these files. Some of these files will need new types and interfaces, add them wherever necessary.
Prettier will format these files which is okay.
Describe alternatives you've considered
N/A
Additional context
N/A

I would like to fix this issue

@adex-codez go for it!

Thank you

All this is very new to me  am i to fork or clone the repo

feel free to ask clarifying questions here or in your PR~

am i to fork or clone the repo to work on the issue

do you want the developer date to be in a timestamp format

when i run yarn dev it gives me this error
$ mongod --port 27017 --dbpath ./db --quiet &>/dev/null
The syntax of the command is incorrect.

@adex-codez these are great questions/comments 😄

you can refer to our Contribution guide to learn more about our contribution process - if it doesn't answer your questions, lmk so i can update it!
you don't need to worry about changing the logic within the code - rather you can just focus on converting the files from JS to TS and then create any new types/interfaces to ensure that our TS checks can pass
The syntax of this command isn't necessarily incorrect 😅 it might not play nice with non-MacOS OS - can you lmk what OS you're using?

Also make sure that you have MongoDB installed on your system along with Java!

Hi @ijemmao,
I could not find the best place to ask this ( I could not log into the slack channel ).

I have followed the README and contributing guide, but I am still having trouble running this project locally.

From the Firebase Configuration Guide:

When editing the .firebaserc file, I am supposed to replace the project name igbo-api-bb22d with my new Firebase project name.
Do I do it for both default and staging like so?

"projects": {
    "default": "chidexebere-igbo-api",
    "staging": "chidexebere-igbo-api"
  }

Also, when editing the src/service/firebase.ts file , do I replace with my FIREBASE_CONFIG object for both STAGING_FIREBASE_CONFIG and PRODUCTION_FIREBASE_CONFIG.

I do not understand how this works for this project:
When I make a PR my .firebaserc and src/service/firebase.ts files will change because of the Firebase Configuration Guide.

Will this be reverted to the igbo-api-bb22d config before my PR is merged?

Does this mean that I have to always change the .firebaserc and src/service/firebase.ts files whenever I make a pull from upstream?

@chidexebere hey! try to fill out the volunteer form again so you can join the Slack channel - it will be much easier to address these questions.
But I can answer your question!
For the first two bullets, yes. You updated the .firebaserc and firebase.ts files correctly.
We have a .gitignore line for our firebaserc file (but not yet for firebase.ts) so that way you can make as many changes as you want in those files without them getting committed into git.
This means for local dev, you'll always need to have your firebaserc and firebase.ts updated with your personal project details.
So essentially the steps are:

Update the firebaserc and firebase.ts files
Make whatever local dev changes you wanna make
When committing file, don't include firebaserc and firebase.ts

@chidexebere https://nkowaokwu.com/volunteer
That's one way to think about treating the firebase files. VSCode let's you select specific files that you want to commit so you could just select the files that you want to commit for your PR.
The error screenshot you sent doesn't show the full logs so I might not be able to figure out this bug. We can talk more on slack once you join .

@ijemmao , I am already on Slack, we can move this there

so i have come again when i run yarn build it gives me this error cp: cannot create directory './dist/dictionaries/ig-en': No such file or directory  and also anytime i make a commit all the src/middleware files gets deleted

are you on windows @adex-codez ? that could be the reason why the script to create that directory isn't working

so what how i my going to resolve the issue

this is a bug that needs to be fixed within this repo - so I recommend creating a new ticket describing your blocker - from there a contributor, who's working with Windows, can create a solution to help unblock you from this work

I am so sorry i have not given feedback on the project because throughout these past weeks I have been busy and some of the problems i encountered during setting up the project locally, so I have unassigned myself sorry for the long wait.


If 'path' Doesn't Match It Results in a Cache Miss

If you have the following config:
name: Example
on:
  workflow_dispatch:
  push:
    branches:
      - main
jobs:
  some-job:
    name: Some Job
    runs-on: ubuntu-latest
    steps:
      - name: Setup some cache
        id: some-cache
        uses: actions/cache@v2
        with:
          key: some-key
          path: |
            **/this/path
            **/that/path

      # Do stuff that populates the paths in the cache

  some-second-job:
    name: Some Second Job
    runs-on: ubuntu-latest
    needs: [some-job]
    steps:
      # Results in a cache MISS
      - name: Get some cache
        id: some-cache
        uses: actions/cache@v2
        with:
          key: some-key
          path: |
            **/this/path

  some-third-job:
    name: Some Third Job
    runs-on: ubuntu-latest
    needs: [some-job]
    steps:
      # Results in a cache HIT
      - name: Get some cache
        id: some-cache
        uses: actions/cache@v2
        with:
          key: some-key
          path: |
            **/this/path
            **/that/path

On some-second-job you will receive a cache miss because the specified paths don't match; however, on some-third-job you will get a cache hit since the paths do match. Nowhere in the documentation does it specify that the scoping of the cache is also depending on the path list matching.
It would be good if either:

The docs would be updated to include the path arguments needing to match to get cache hits
The action is updated to allow you to specify one or more of the paths provided to restore. For example, if you cached the paths **/this/path and **/that/path that you would be able to, in a later job, only restore **/this/path from the cache if it's the only cached path that specific job needed.

@StephenMP thank you sir, you've saved me hours of miserable frustration. I've tried to figure out why my cache was not getting found.
I would suggest to update the action to log more detailed reasoning behind cache misses to indicate this specific case, because it's very easy to make this mistake.

Since this hasn't been addressed... it needs to stay alive.

@rfay @StephenMP Have added details in readme for versions of cache. https://github.com/actions/cache/pull/804
This should resolve this issue. If it doesn't resolve your doubt, you can re-open this issue. Thanks


Update prevalence + generate CSV data too

CSV data will be used by the spreadsheet.

Going to go ahead and merge this so we can get the prevalence update, since the CSV generation isn't used by anything yet. @blanchardjeremy let me know if it doesn't meet your needs and I can tweak.

Sounds great.  I'll play with it next week sometime!
On Wed, Oct 21, 2020 at 12:37 AM Joshua Oreman<EMAIL_ADDRESS>wrote:

Going to go ahead and merge this so we can get the prevalence update,
since the CSV generation isn't used by anything yet. @blanchardjeremy
https://github.com/blanchardjeremy let me know if it doesn't meet your
needs and I can tweak.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microcovid/microcovid/pull/349#issuecomment-713373646,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAH4IU3VMS5A4KDFCCBHQDSL2FTJANCNFSM4SXYEVWQ
.

--

Jeremy Blanchard
(503) 515-6321
Pronouns: he / him / his


Typo in the role created message

Steps
Go to TAAS Admin >> Roles
Create a new role
Check the message

Verified Role creation message in Prod.


fix: input -> data

LGTM, ready to merge when the tests pass. Thanks

I fixed it. But, I am worried that if I modify it like this, input will not be supported.

I don't think this will cause problems - data field should be forward-compatible. I've verified it with latest reth, go-ethereum, and erigon nodes.


Migration of the portal is in progress - stuck

I was attempting to add Google Cloud Storage as a backup location. I went to the integration, Third-Party services and added Google Cloud. I entered my JSON credentials, the last thing i remember, it was asking me to enter the name of the bucket. So, I entered that. Now i see with a screen saying:  "Migration of the portal is in progress" its been stuck like that for 3 days. There is no data in the bucket. I can't go to anywhere else on the site.
How do i get out of this? Is there a MySQL value i can set? or a configuration file i can change? We can't access the entire system.

Hello aibarra11.
Unfortunately, I don’t have proven ready-to-go solution for your situation. If you have prepared whole server backup, probably it’s better to rollback.
For technical difficulty issues, where a prompt reliable solution is required, it’s better to contact ONLYOFFICE techsupport team via https://onlyofficesupport.zendesk.com/


ziglang-edge: Add ziglang edge

Moved from lukesampson/scoop-extras#3276

Waiting for lukesampson/scoop#3613

Why not use "regex": "zig-([\\da-f.+]+).tar.xz"?
No need to seperate 0.5.0 and +105ef560b

Why not use "regex": "zig-([\\da-f.+]+).tar.xz"?
No need to seperate 0.5.0 and +105ef560b

I thought it would be better to distinguish between version and commits. In that case I will make changes

Now we should wait for https://github.com/lukesampson/scoop/pull/3613

If you replace the + sign with a scoop friendly -, you could immediately make this ziglang-edge work. Then you could change it back to + when the lukesampson/scoop#3613 is done.
For example: lukesampson/scoop-extras#3489

Replaced by #273.


Send teamNotify on showcase and tars changes

Send notifications on changes to teams so the frontend can update appropriately cc @buoyad

Does this need a server change? I assume we also want a notification when someone else changes this setting.

@zapu you want to review this if you are making server changes for it?

I think @joshblum is doing serverside as well, but I can review nonetheless

LGTM, one comment about tests


Release Google.Api.CommonProtos version 2.12.0

Changes since 2.11.0:

The package contains the original protos, in contents/protos. Build targets in the package set the GoogleApiCommonProtos_ProtosPath msbuild property, and if IncludeGoogleApiCommonProtos is set to the value true in the project, the Protobuf_StandardImportsPath property is updated to include it before the Protobuf_BeforeCompile target is executed. (This should make the package easier to work with from Grpc.Tools.)

Created release for Google.Api.CommonProtos-2.12.0

Will look into this tomorrow.

This is the same as always with releases from Gax. The release triggered twice, one succeeded that other failed.
Here's the updated package: https://www.nuget.org/packages/Google.Api.CommonProtos

Ah, phew :)


Infer non-nullability from C# ref types

This one changes too much ... so we will split it. We will make a minimal non-null detection for 10 and a more fundamental update for 11.


Choose approach to the keyId used for signing DWeb Message

Currently the keyId is hard-coded in #createSignedMessage:
https://github.com/TBD54566975/web5-js/blob/a12165abd23a27468fabc252a2a08d4a579ed996/src/web5.js#L80-L85
The ION DID create() method optionally allows specifying a key but if web5.did.create('ion') is called the default is dwn:
https://github.com/TBD54566975/web5-js/blob/a12165abd23a27468fabc252a2a08d4a579ed996/src/did/methods/ion.js#L6-L14
Note: It was key-1 previously but whether its key-1 or dwn or anything else, it is hard-coded in one method and a default in the other.  The values need to match or the DWeb messages will error during processing.
Considerations:

We haven't introduced a key store to Web5 JS and or at least made it possible for a developer to provide their own.  The key store work has a number of open questions we need to work through, and that will require refactoring all of the methods that touch keys.  We could opt to address then.
Since the key store work is still pending, we have been relying on the keyId specified when the ION DID is created to match the keyId in the createSignedMessage() method.  If there's a mismatch, any calls that require message signing fail.  To really make an improvement here what we ought to do is select from one of:

Make the keyId used for signing messages configurable on a per DID basis WITHOUT requiring it to be passed in on every call to a web5.dwn.records.*, web5.dwn.protocols.*, etc. call.
Make the keyId a "well known" that could be a Symbol which is used consistently in both places.  This would mean that an existing DID could not be imported unless it conforms to this approach.  There may be some consideration for doing this even though its restrictive based on how encryption works in dwn-sdk-js.

Resolved by #43 and project refactor.


Fixed Broken Link

fixes #57

Squash and merge would be great!

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.098%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4092

Relevant Lines:
5922

💛  - Coveralls


Test For New Plugin - Formating change only [NO MERGE REQUIRED]

Just seeing if the latest GHPRB plugin is doing correct things now.

Well that's an improvement :D

#rebuild

Yay!


Remove redundant Qs and incorrect QA combinations.

"What versions of Azure DevOps work with Excel?" is asked three times. Can I use Excel on my Mac is asked once and answered twice!

@chrisgchambers : Thanks for your contribution! The author(s) have been notified to review your proposed change.


[6.0] Throw an exception when attribute/relation isn't exist/set

First of all, thanks for a great framework! :)
This request brings some  less error-prone code to Eloquent HasAttributes trait.
Currently If there is neither relation nor an attribute with given name (e.g. $this->something_weird) it just silently returns null value. This can bring a lot of bugs, actually I faced this issue my own.
If you can see the algorithm it tries to detect if it's an attribute/method. And if it's not it says Ok, this is relation, but this may be just a typo or something like that.
I understand the usability of such setters, for example you can store some temporary state (actually for this case the getter will work fine even after this change), but I can't see any benefit of returning null without any warnings/exceptions.
Plus, this behaviour is similar to what PHP does, e.g.
class A
{
}

$a = new A();
$a->b; //PHP Notice:  Undefined property: A::$b in php shell code on line 1

I haven't patched all the tests, just wanted to show the idea, if it's okay and reasonable for you as well, I'l do the job.

Please see #29089.

Would have to be opt-in behavior.


Fix mas build

Codecov Report

Merging #214 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   58.63%   58.43%   -0.21%
==========================================
  Files          20       20
  Lines        1494     1494
==========================================
- Hits          876      873       -3
- Misses        618      621       +3

Impacted Files
Coverage Δ

...eleton/modules/autoupdate/assetBundleDownloader.js
89.9% <0%> (-2.76%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4f21b...cf9799b. Read the comment docs.


Flutter Beta: If I click on TextField and press back button keyboard not getting close on MIUI and Asus phones.

If I click on TextField and press back button keyboard not getting close on MIUI and Asus phones.
Steps:

Create new project.
Add TextField.
Run app on beta channel.
Click on TextField.
Press back button.
6 Keyboard not getting closed.

Hi @ganeshshirole
Can you please provide your flutter doctor -v your flutter run --verbose running those devices with the code and a complete reproducible minimal code sample
Thank you

See https://github.com/flutter/flutter/issues/66036

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Keras 3 incompatibility set Embedding layer weights

import numpy as np
from keras.layers import Embedding

# load already trained embedding matrix
embedding_matrix = np.random.rand(10, 10)

layer = Embedding(
    input_dim=embedding_matrix.shape[0],
    output_dim=embedding_matrix.shape[1],
    trainable=False,
    # set weights, working with Keras 2 but not 3
    weights=[embedding_matrix],
)

I'm trying to migrate to Keras 3.0 and I'm having issues with the Embedding layer. I need to set the embedding weights but I get this error:
ValueError: Unrecognized keyword arguments passed to Embedding: {'weights': [array([[...

Hi @jc-louis ,
In keras2 can you confirm whether layer.get_weights() retrieves weight set in embedding layer like you mentioned above?

Yes, but it only works after compiling the model (before that layer.get_weights() returns [])
# keras v2 code
from keras.models import Model
from keras.layers import Input
import numpy as np
from keras.layers import Embedding

embedding_matrix = np.random.rand(4, 1)

layer = Embedding(
    input_dim=embedding_matrix.shape[0],
    output_dim=embedding_matrix.shape[1],
    weights=[embedding_matrix],
    trainable=False,
)

input_layer = Input(shape=(1,))
embedded = layer(input_layer)
model = Model(inputs=input_layer, outputs=embedded)
model.compile()

assert np.allclose(embedding_matrix, layer.get_weights()[0])
assert np.allclose(embedding_matrix, model.layers[1].get_weights()[0])

Hi @jc-louis ,
Gone through Keras2 and confirm that weights is an accepted kwarg for Layer class as per code below.
https://github.com/keras-team/keras/blob/601488fd4c1468ae7872e132e0f1c9843df54182/keras/engine/base_layer.py#L329-L335
In keras3, kwargs passed being checked  and raising exception from below code.
https://github.com/keras-team/keras/blob/e6e62405fa1b4444102601636d871610d91e5783/keras/layers/layer.py#L264
I am not sure whether this is intended change or not.
But there is a way to achieve this behaviour in Keras3 using layer.set_weights method after compiling the model.
Please refer to modified code in attached gist to achieve your requirement.
Hope it helps. Thanks!

The weights= layer constructor argument was dropped in Keras 3. I've decided to add it back in the specific case of the Embedding layer, because unlike other layers it gets built in the constructor (so we don't have to store the weights value temporarily while waiting to build) and we had a few public code examples showing Embedding(..., weights=...).
So this is now fixed at HEAD.
Also, you can just do:
layer = Embedding(
    input_dim=embedding_matrix.shape[0],
    output_dim=embedding_matrix.shape[1],
    trainable=False,
)
layer.embedding_matrix()


Move mob spawning code to Main.gd

Suggestion from Lars:
I would suggest moving almost every function from the enemy script to the main script. For example picking the start location for a mob is something the game does, not something the mob does themselves. After all in order to pick a random start position you need to acquire the bounds of the viewport rectangle, and that's the area of the main scene.

Completed


--locale cmd line argument not working (Windows)

Testing #12519
From the command line, code-insiders --locale zh-TW doesn't bring up the correct locale (always English)

Setting to September for regression analysis.

Works for me on Mac.

Works for me under Windows.
@mousetraps there is one limitation with this. If a vscode instance is already running you can't change the local for a second instance. So the switch is ignored. Reason being that the menu bar is owned by the main process and that is only started once.

@dbaeumer yep, you're right! it's working now. I thought I had closed all the windows, but it turns out there were some lingering processes.


Theme: Dashboard real-time stats for CPU and HDD temperatures

Hi, it would be nice if the cpu and hdd temps data would be added to the real time stats.
Thanks
Abász

I will add this in the future.
Thanks for the idea.

Ref.: #5 https://github.com/qooob/authentic-theme/issues/896


Does the new OneDrive API only works for OneDrive? Or it's able to use for generic OAuth

Reposting for @huangcd

The new OneDrive API will not support scenarios like mail or calendar as it is just focused on giving you access to your files in the cloud.
To your second question about OAuth, the implementation of OAuth that ships with the OneDrive API SDKs will work with all Microsoft Account/Azure Active Directory accounts.  As to this implementation being portable for other OAuth services, I don't believe that is a goal.  When we have more details when those SDKs are available and you can try them out for yourself.
To get more information on the OneDrive APIs, make sure you watch https://github.com/OneDrive/onedrive-api-docs

Thank you for the explanation


Get all chats and Get all contacts - The method is not implemented by the engine

Hi,
I ran by using NOWEB engine. I just discovered that when I tried to use these endpoints, it returned "The method is not implemented by the engine". In the documentation, I couldn't find what type of engine compatible for these endpoints.
Could you please advise wether is it possible to run this on NOWEB engine or not. Honestly, I preferred to use NOWEB rather than WEBJS.
Additional info, I purchased WAHA Plus on July 2023 and no update afterthat.
Thanks.

Hi! we're working on remote storage for NOWEB so we can save chats\contacts there. After that we'll add those methods too! https://github.com/devlikeapro/whatsapp-http-api/issues/41

Additional info, I purchased WAHA Plus on July 2023 and no update afterthat.

Here's a new version https://boosty.to/wa-http-api/posts/04d125c2-2c44-4b48-927d-2eda71e40119?share=post_link

Hi! we're working on remote storage for NOWEB so we can save chats\contacts there. After that we'll add those methods too!

Oh so currently cannot use endpoint chats/contacts for NOWEB engine? Need to use WEBJS engine, right?

hey @muhdazrain , I am planning to move from Webjs to the NoWeb version because of chromium memory leakage issues. I just wanted to know if get all /contacts and get all /groups api works on noweb or not?

@khushboo-scogo reason I'm using NOWEB is because similar like you. However, recently I want to try to fetch contacts and also chats but it returned "The method is not implemented by the engine". Based on @allburov replied, I think have issue with storage which works in progress.
As for now, I don't have any idea for the solution

@allburov  Is there any solution to this ? or any work around
May be if NoWeb is not ready now , do you think the 3rd engine Venom has this covered ? and could be used in place of NoWeb ?
@allburov  from maturity point of view is Venom a good choice ? compared to NoWeb

@muhdazrain hi!

Is there any solution to this ? or any work around

The workaround would be to expose chat.updates and other internal engine's events, so you can listen all of them and save it in your database.
First time when you authenticate session with QR it'll send your tone of chats\contacts and after that will send events about all updates there.
Let me know if you're interested in it, we could expose those events, so you can enable it by adding engine.{engine.event.name}  in webhook's events.

from maturity point of view is Venom a good choice ? compared to NoWeb

First of all, Venom (as webjs) uses chrome to communicate with whatsapp, so from performance CPU\Memory consumption it's the same as webjs.
But Venom was much slower, we even stopped update that engine in WAHA... Like first QR appeared only after a minute...
Let me know if you'd love to test venom, I'll update it!
btw, I don't remember whether or not it supports those endpoints anyway... We'll document it in documentation in swagger https://github.com/devlikeapro/whatsapp-http-api/issues/207

@allburov  Thanks for the update.
Good to know that Venon (as well) uses chrome to communicate. So its a no-go.
Like @muhdazrain  we are also interested in getting NoWeb to work with chat, contacts, groups APIs working in NoWeb.
How should be approach this ? we are happy to be the beta tester for this , if you can push some fixes to NoWeb to support chat, contacts, groups APIs.
Thanks again @allburov  for our prompt support on this

Start a brand new session  - meaning call POST /api/sessions/logout before and POST /api/sessions/start with payload
{
  "name": "default",
  "config": {
    "noweb": {
      "enabled": {
        "store": true,
        "fullSync": false
      }
    }
  }
}

After that you'll have access those endpoints on NOWEB engine

GET /api/contacts/all
GET /api/{session}/chats
GET /api/{session}/chats/{chatId}/messages

https://waha.devlike.pro/docs/overview/changelog/#20246
You asked it, we did it - contacts, chats, and messages endpoints are now available in NOWEB engine!
Please make sure to Enable NOWEB Store before using these endpoints.

Build: 2024.6.3
Engine: NOWEB


How to restructure events?

Examples don't seem to make sense. The one provided with the breaking changes is:
umami.trackEvent('button-click', { userId: 123, buttonName: 'Newsletter signup' });

Doing it this way on the current version only let you know the number of 'button-click' events, and not that it's about the newsletter.
I have no idea if/when/how the new event_data implementation will even work or be displayed in the interface, which doesn't help, but do I really have to go in blind and wait until an old feature is re-implemented? 😕

That example is probably too generic, you're right. You wouldn't group all button-click's together like that, but instead use different names, login-button-click or signup-button-click.

I just wanted to know this too because I don't know if event_data is even showed or something

@danestves not currently, but will be in the next release

I would truly appreciate if you could confirm the following scenarios so that I don't have to rework it again in the future:
Example 1, collecting events from users going through affiliate links. I'd like to see the total number of outbound traffic for all affiliates but I'm mostly interested in being able to see which ones are the most popular. The affiliate name or link would be added to the event_data?
Example 2, collecting events from user interactions with an unlimited number of uniquely identified elements. I'd like to see the total number of those specific interactions, but also which IDs are the most interacted with. The ID here would be included in event_data?
Thank you 🙏

@jfbeats The event_data is whatever you make of it. You collect the information that is important to you. So if a user clicks the Add to Cart button, you can record the product ID as { product_id: 153464 }. Then you should be able to query to get a breakdown like:

product_id
count

153464
20

128760
12

546354
8


Check that there are no source file changes before building

If dependencies are changed (in package.json) without updating the yarn.lock
file, or if any other part of the build process starts producing unignored
files, the CI build will fail, so that the problem can be corrected before the
PR is merged.
See #575

Hrm maybe to debug the build failure we can output the status of git status before this line? also to aid in debuggability

I updated with a script that will run git status and output a message.
See https://travis-ci.org/pcottle/learnGitBranching/jobs/526793367 and https://travis-ci.org/pcottle/learnGitBranching/jobs/526793368 for example output.

There we go! Awesome :D

Thanks so much for making our CI pipeline better! really cool to catch these things with travis


Move base sass styles into cartridge sass

The base styles make more sense in this module rather than in the base module. The current issue is that if you didn't install cartridge-sass you would still have sass

See #160


Add support for using prior Pino instance

If you have previously created an instance of Pino, prior to initializing your Hapi instance, it should be possible to use that instance of Pino within the plugin. This PR adds such support.

@jsumners awesome - @geek is this idiomatic approach/naming for hapi?

LGTM

LGTM


KAFKA-7386: streams-scala should not cache serdes

Currently, scala.Serdes.String, for example, invokes Serdes.String() once and caches the result.
However, the implementation of the String serde has a non-empty configure method that is variant in whether it's used as a key or value serde. So we won't get correct execution if we create one serde and use it for both keys and values.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Mutablility...
All good to me.

@joan38 , Yeah, sort of... What's actually going on is more like dependency injection. The class is being configured after creation and then cached.
But, yes, this can be (and has been) a source of bugs.

Ok, @guozhangwang , I think this is good to go.

LGTM!

Cherry-picked to 2.0 as well.

Thanks @guozhangwang

This definitely mutability and makes the implicit usage quite suspect. Unfortunate. :(


Black screen

Hello,
I was working on a bot of my own and have run in to your project by accident while googling
Do you not encounter the problem of a black screen after a few minutes/5 screenshots? I have tested your method with OBS and its the same for me, the screen is black

it is precisely because of the black screen that we use OBS, so that we can capture the pixels
=D

did you manage to run the BOT?

I have not played the game since 2011, so I only heard about battle eye and don't know much about it but blocking screenshots seems like a quite common practice from what I have googled
I did not turn on the bot, since the screen from OBS goes all black after a few minutes, so I get exactly the same effect as when taking regular screenshots either to the disc or to the memory. I have tried changing the graphic engine settings, it made no difference for the screenshot, I have not yet tried it with OBS but I doubt it will change anything
Do you have any clues why OBS works for others and not for me?


Add audio demo

Codecov Report

Merging #303 (812a3fb) into main (4ee7f36) will decrease coverage by 0.29%.
The diff coverage is 46.96%.

@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   67.45%   67.17%   -0.29%
==========================================
  Files         206      209       +3
  Lines       11676    11770      +94
  Branches     1747     1709      -38
==========================================
+ Hits         7876     7906      +30
- Misses       3384     3451      +67
+ Partials      416      413       -3

Flag
Coverage Δ

unittests
67.17% <46.96%> (-0.29%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

meerkat/columns/abstract.py
80.91% <ø> (ø)

meerkat/dataframe.py
75.57% <ø> (ø)

meerkat/cells/audio.py
36.73% <36.73%> (ø)

meerkat/columns/deferred/file.py
65.08% <42.85%> (-0.70%)
:arrow_down:

meerkat/interactive/formatter/audio.py
49.15% <49.15%> (ø)

meerkat/tools/utils.py
57.43% <58.33%> (+2.22%)
:arrow_up:

...ctive/app/src/lib/component/core/audio/__init__.py
100.00% <100.00%> (ø)

meerkat/interactive/formatter/__init__.py
100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[KED-1473] pandas.CSVDataSet doesn't support encoding parameter

Description
I'm unable to load a non-utf-8-encoded file.
I know it doesn't work because of https://github.com/quantumblacklabs/kedro/blob/f03226e29b8a018a0f6edab6d3f1a0d37c1b1812/kedro/extras/datasets/pandas/csv_dataset.py#L154-L155. For it to work, encoding would have to be passed to open. However, some file systems don't support an encoding parameter... (e.g. gcsfs, I think).
Steps to Reproduce
Try loading https://github.com/beoutbreakprepared/nCoV2019/blob/433628fb828f3b3b3bff7d13195af357fe42e31d/ncov_outside_hubei.csv as a CSVDataSet.
Expected Result
I can load a cp1252-encoded file directly with pandas:
pd.read_csv("data/01_raw/nCoV2019/ncov_outside_hubei/20200304/ncov_outside_hubei.csv", encoding="cp1252")

Actual Result
I'm unable to load a cp1252-encoded file using Kedro:
DataSetError: Failed while loading data from data set CSVDataSet(filepath=data/01_raw/nCoV2019/ncov_outside_hubei/20200304/ncov_outside_hubei.csv, load_args={'encoding': cp1252, 'low_memory': False}, protocol=file, save_args={'index': False}).
'utf-8' codec can't decode byte 0xa0 in position 162456: invalid start byte

Your Environment
Include as many relevant details about the environment in which you experienced the bug:

Kedro version used (pip show kedro or kedro -V): 0.15.8
Python version used (python -V): 3.7.6
Operating system and version: macOS Mojave Version 10.14.6

I have the same error here while trying to read from S3 if my csv file is not encoded in utf-8! Any workarounds?

I have the same error here while trying to read from S3 if my csv file is not encoded in utf-8! Any workarounds?

Hi @millengustavo and @deepyaman, thanks for raising this. We're aware of this (and the other related issues from not being able to pass args to the fsspec open call) and it's on our backlog to fix soon!
For now, the only workaround I can think of is creating a custom dataset from the dataset you want to use and overriding the load and save methods to pass the relevant stuff into the fsspec open call 😄

Thanks for the quick reply @mzjp2
I modified /kedro/extras/datasets/pandas/csv_dataset.py _load function by passing encoding with my specific case to the open context.
def _load(self) -> pd.DataFrame:
        load_path = get_filepath_str(self._get_load_path(), self._protocol)

        with self._fs.open(load_path, encoding="latin_1", mode="r") as fs_file:
            return pd.read_csv(fs_file, **self._load_args)

Since most of my files have the same encoding it worked, despite not being ideal.

Thanks for the quick reply @mzjp2
I modified /kedro/extras/datasets/pandas/csv_dataset.py _load function by passing encoding with my specific case to the open context.
def _load(self) -> pd.DataFrame:
        load_path = get_filepath_str(self._get_load_path(), self._protocol)

        with self._fs.open(load_path, encoding="latin_1", mode="r") as fs_file:
            return pd.read_csv(fs_file, **self._load_args)

Since most of my files have the same encoding it worked, despite not being ideal.

Alternatively, you can do something like
def _load(self) -> pd.DataFrame:
        load_path = get_filepath_str(self._get_load_path(), self._protocol)

        with self._fs.open(load_path, **fs_open_kwargs) as fs_file:
            return pd.read_csv(fs_file, **self._load_args)

in a similar vein to the way we do load_args or save_args then pass the relevant parameters inside your catalog.yml entry. :)
Or, if you only care about encoding, then you can make encoding one of your __init__ args and pass just encoding=self._encoding to the self._fs.open call. Hope that makes sense!

Hi everyone, this should be fixed by this commit and made available in the next release: https://github.com/quantumblacklabs/kedro/commit/8329f452b96bda4ca3a3cd2b30f71f261e6a8af8
I'll go ahead and close this issue for now, feel free to come back if it's still causing you problems.

I am still facing the issue:
'utf-8' codec can't decode byte'
while i specified
load_args:
encoding: 'latin_1'

@bensdm According https://stackoverflow.com/a/30470630/3858528 the value of encoding should be latin1, not latin_1. Hope this helps :)

nop it doesnt change anything, i already tried but same issue:
Failed while loading data from data set CSVDataSet(filepath= ..., load_args={'encoding': latin1, 'sep': ;}, protocol=file, save_args={'index': False}). 'utf-8' codec can't decode byte 0xe9 in position 222: invalid continuation byte

@bensdm Are you able to read your data using regular Pandas (not using Kedro CSVDataSet) ?

Yes with both latin1 and latin_1

should i open a new issue?

Hi @bensdm , apologies for the delay. Could you try adding the following config to your catalog entry?
fs_args:
    open_args_load:
        mode: "rb"

We use fsspec underneath and it needs to open the file in binary mode. Try passing encoding to open_args_load or load_args as well, and that should work.

thanks, working as expected !

However it is not working when working with partitioned datase:
DataSetError:  __init__() got an unexpected keyword argument 'fs_args'. DataSet 'absences_raw' must only contain arguments valid for the constructor of kedro.io.partitioned_data_set.PartitionedDataSet.


CSwitcher is not handled by Mgrsolve, DBSolve, without a warning

I tried running the model under cases/9-c-switcher. I modified it to export also for MgrSolve. The exported SBML model (as run at http://core.fun.bio.keio.ac.jp/SBMLWebApp/) produces results that seem to take the switcher into account:

However, the results in MgrSolve appear to ignore the switcher:

The same result for DBSolve:

However, there was no indication that CSwitcher is unsupported in either MgrSolve or DBSolve, here's the full output from the compilation:
Running compilation with declaration file "C:\Users\modrak_m\Documents\small\heta-review\heta-compiler-master\cases\9-c-switcher\platform.json"...
[info] Builder initialized in directory "C:\Users\modrak_m\Documents\small\heta-review\heta-compiler-master\cases\9-c-switcher".
[info] Platform id: "cs"
[info] Compilation of module "src/index.heta" of type "heta"...
[info] Reading module of type "heta" from file "C:\Users\modrak_m\Documents\small\heta-review\heta-compiler-master\cases\9-c-switcher\src\index.heta"...
[info] Setting references in elements, total length 51
[info] Checking for circular references in Records.
[warn] Units checking skipped. To turn it on set "unitsCheck: true" in declaration.
[info] Checking unit's terms.
[info] Start exporting to files, total: 7.
[info] Exporting to "C:\Users\modrak_m\Documents\small\heta-review\heta-compiler-master\cases\9-c-switcher\dist\sbml.xml" of format "SBML"...
[info] Exporting to "C:\Users\modrak_m\Documents\small\heta-review\heta-compiler-master\cases\9-c-switcher\dist\model" of format "SLV"...
[info] Exporting to "C:\Users\modrak_m\Documents\small\heta-review\heta-compiler-master\cases\9-c-switcher\dist\model" of format "DBSolve"...
[info] Exporting to "C:\Users\modrak_m\Documents\small\heta-review\heta-compiler-master\cases\9-c-switcher\dist\julia" of format "Julia"...
[info] Exporting to "C:\Users\modrak_m\Documents\small\heta-review\heta-compiler-master\cases\9-c-switcher\dist\matlab" of format "Matlab"...
[info] Exporting to "C:\Users\modrak_m\Documents\small\heta-review\heta-compiler-master\cases\9-c-switcher\dist\simbio" of format "Simbio"...
[warn] Cannot check units consistency for "r1" because no units found for "k1"
[warn] Cannot check units consistency for "r1" because no units found for "x1"
[warn] Cannot check units consistency for "r1" because no units found for "comp1"
[info] Exporting to "C:\Users\modrak_m\Documents\small\heta-review\heta-compiler-master\cases\9-c-switcher\dist\mrgsolve" of format "Mrgsolve"...
Compilation OK!

You are right, this is a bug. Heta-compiler must throw an error.
I've already pushed the commit to the master branch to fix it.
Currently, neither mrgsolve nor DBSovle supports conditional events at all.
There is no clear mechanism to implement such events into the formats.
It would be interesting to ask the mrgsolve developers what they think of implementing it.

Great, looks like it works now. Looking at https://hetalang.github.io/#/heta-compiler/export-formats?id=features-support wouldn't a somewhat more general solution to the issue make sense? E.g. currently, the @Dose class is not handled by any export, but it appears no export checks whether the model includes it  and will thus likewise not produce an error.
Maybe it would make sense for each export to expose supported classes (via a new method) and then there could be a shared piece of code that checks that all classes used by the model are supported by the export? The biggest advantage would be that if you add a new class to the Heta standard, all exports you didn't touch would throw an error when this class is used, which seems like a sensible safe behavior.
But again this is a minor thing and I don't intend to pressure you into adopting my proposal.

It's an interesting idea. I guess I add this feature in a future version.
Another problem is that some of the export formats don't support specific properties.

Support of TimeSwitcher, CSwitcher and DSwitcher has been implemented in the master branch.


Fix a bug in ShapeTestUtil

Description
boxPolygon and trianglePolygon only uses minX and minY value of give XY Rectangle which results in a polygon with points in single place. With this changes, both methods generate correct polygons.

Nice find! I wonder if we could put a test in place that would have reliably detected this issue.

This is a code for test actually. If we are writing a test using this method, we will detect the issue and that is how I found it.

I should have been clearer. I'm assuming the existing tests that call nextPolygon() are passing before and after the fix, which warrants some suspicion. Could we devise a test that would use these utility methods and fail without this fix? It sounds like you were already writing a test that would serve this purpose. Let me know if I've got it wrong.

I should have been clearer. I'm assuming the existing tests that call nextPolygon() are passing before and after the fix, which warrants some suspicion. Could we devise a test that would use these utility methods and fail without this fix? It sounds like you were already writing a test that would serve this purpose. Let me know if I've got it wrong.

Got your point. Actually, I am using this utility methods in other dependency repos, OpenSearch. There, the test fails without this fix. Let me see if I can add a test using this utility method in lucene.

Thanks @heemin32 for taking the effort to bring the fix down to Lucene, from OpenSearch test failures.  A dedicated Lucene unit test would be great.  Maybe @nknize could help evaluate the change?

The test could call the modified methods with a random box and assert that all vertices of the given polygon are different. We can reuse hasIdenticalVertices from #12757.

There are existing tests which should fails. https://github.com/apache/lucene/blob/main/lucene/core/src/test/org/apache/lucene/document/TestShapeDocValues.java#L67
However because we are catching exception and try until we get the correct polygon, it never fails.
https://github.com/apache/lucene/blob/main/lucene/core/src/test/org/apache/lucene/document/BaseXYShapeTestCase.java#L228-L235
I cannot remove the try-catch statement as of now because there are bug in surpriseMePolygon() and createRegularPolygon() which fails to create a valid polygon because of type casting from double to float. One of attempt to fix it is in https://github.com/apache/lucene/pull/12757.
I would like to wait until the other issues are resolved and remove the try-catch statement rather than writing a unit test for just the test utility code.

We would still have a few more issues to solve after #12757, which are documented in #12596, but overall I agree that it makes sense to merge this as is.

There are existing tests which should fails. https://github.com/apache/lucene/blob/main/lucene/core/src/test/org/apache/lucene/document/TestShapeDocValues.java#L67
However because we are catching exception and try until we get the correct polygon, it never fails.

That try-catch is intentional. The evil, esoteric / invalid test geometry generation is also intentional so we can maximize our test coverage across the tessellator and Shape indexing.  This is why we have Tessellator logic to filter colinear and coplanar points so we can best effort index shapes that may not be well formed or may not have been pre-validated or cleaned. While we expect well formed data, that's not the real world. Users (especially geo users) often throw dirty data at the API. And to pre-validate geometries is an expensive operation. Not all users want to pay that price. This is why we left much of that diligence out of Lucene and in the hands of the integrating API. For example, see Elasticsearch ignore_malformed parameter. For the explicit shape doc value bounding box test referenced, we expect a valid polygon bounding box for test purposes, but (as just pointed out) that reused polygon generator could create a malformed one and an invalid bounding box. Rather than write a new polygon generator I opted to reuse the existing one and just retry until a valid polygon is created.  What you could do is just write a new polygon generator that always creates a valid well-formed polygon. I'd be concerned, though, about new contributors always using that to create perfect data, which is not real world.

That try-catch is intentional.

However, the implementation between latlon and xy are different then. https://github.com/apache/lucene/blob/7b8aece125aabff2823626d5b939abf4747f63a7/lucene/core/src/test/org/apache/lucene/document/TestShapeDocValues.java#L77-L95
For latlon, it does not have try-catch statement wrapping GeoTestUtil.nextPolygon(). I believe GeoTestUtil.nextPolygon() returns valid polygon always but ShapeTestUtil.nextPolygon() does not.

... I believe GeoTestUtil.nextPolygon() returns valid polygon always but ShapeTestUtil.nextPolygon() does not.

A quick glance looks like the difference is from LUCENE-9192 where ShapeTestUtil#nextPolygon will only consider executing the try-catch path on Nightly runs.

We need to call ShapeTestUtil.nextPolygon(); directly from testXYPolygonCentroid().

Doing that could create a polygon that can't be tessellated.

Doing that could create a polygon that can't be tessellated.

But testLatLonPolygonCentroid() does call GeoTestUtils.nextPolygon() directly and tessellation works fine.
https://github.com/apache/lucene/blob/7b8aece125aabff2823626d5b939abf4747f63a7/lucene/core/src/test/org/apache/lucene/document/TestShapeDocValues.java#L77-L86

Any update?

Maybe we can merge this fix as-is and continue the conversation about where test polygon generation should produce valid polygons in #12596. It's not clear to me now if there is anything to fix in #12596, but I think we agree that the fix in this PR should go ahead.
@heemin32 - do you want to write a CHANGES entry for Lucene 9.10?

Maybe we can merge this fix as-is and continue the conversation about where test polygon generation should produce valid polygons in #12596. I

+1.  Progress not perfection!

Added CHANGELOG entry

Thank you for persevering @heemin32!


YAML config isn't being read properly

Hello, first off thanks for this plugin!
I noticed when trying to configure a YML projectStructurerc file that it isn't being loaded. Looking at the code, I think the problem is here:
https://github.com/Igorkowalski94/eslint-plugin-project-structure/blob/main/src/validators/validateFileStructure/helpers/readConfigFile.ts#L12-L22
The YAML loader is falling through to the JSON loader on success rather than returning.
It should instead probably be something like:
    let config = null;

    try {
        return load(readFileSync(configPath, "utf8"));
    } catch (error) {
    }

    return JSON.parse(readFileSync(configPath, "utf-8"));

Fixed in version 1.4.0. Thank you for using my plugin and reporting a bug ;*


Configurable Device Discovery

Hello, I haven't had a chance to use this yet, but I can see that the part where device discovery checks the last quartet won't entirely work for me. Is it possible to set that as the default, but also allow for configurable scan-range?

Different network segments can be set here, and this also applies to Sentry.
Is this the feature you need?

This is great, I think so, yeah!


Allow compiling without SSL

This PR adds the ability to compile without SSL. rabbitmq-c already has that ability, but until now compiling it without SSL lead to errors because amqpcpp always expected it to be compiled with SSL.
Since we now use the same cmake variable as in rabbitmq-c both libraries are always compiled in the same way.
An exception is raised in case the user requests a SSL connection from a library that is compiled without SSL support.

Note that there will be a conflict with #98 but I will be happy to resolve it once either of the PRs is merged.


Website Guide: Adding Flutter to an iOS app within a UITableView

Publish a website guide that explains how to use Flutter within a UITableView on iOS.
Like other integrations, integrating with a UITableView primarily comes down to utilizing a FlutterViewController.  The added wrinkle in this use-case is that the FlutterViewController needs to be embedded with a UITableViewCell.
Please ensure that this guide is written against the newest version of the iOS embedding.

I'm not sure we should be pursuing this unless we can do it in a way that won't use up a lot of memory.
For instance, the only way I can think of to make this work today would involve using up about 50mb of RAM per row of table view for a very small, trivial to write widget in iOS.  I would rather see us encouraging people to write the UITableView in Cocoa and then having each row be able to launch a new FlutterViewController using one or more FlutterEngine instances.

Some ways to improve that picture might be:

Make Flutter use less memory
Make FlutterEngine be able to draw to multiple UIViews at once (?)

I'm open to any improvements on the Flutter usage of memory. Some teams may source cards in a feed from different groups and they may want to do something like this.  It's not a high priority, but I think this is either a situation where we can guide people to a solution, or people will try to create their own and be unhappy about how difficult it is.

Not sure if this was fixed but the only resources I found in the website is:
https://flutter.dev/docs/get-started/flutter-for/ios-devs#what-is-the-equivalent-of-uitableview-or-uicollectionview-in-flutter


Reset music.ctxType if loading wasn't succesful

Fixes some crashes, e.g. calling StopMusicStream after trying to load Music from a non-existant .mp3 file

@veins1 thanks for the review!


Content is still up to date

Will have to update screenshots after new portal deployment

Hi @AndrewHoh, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@mimig1

#sign-off @rmca14 Please accept.


Lack of precision? Could be user error.

Hi,
I'm trying to read inputs off a PCF8591 and display the results on an OLED.
If I use your library, then it works, but it's rather woolly and only goes between 0 and 192.
However, if I command it directly, eg:
Wire.beginTransmission(PCF8591); // wake up PCF8591
Wire.write(0x04); // control byte - read ADC0 then auto-increment
Wire.endTransmission(); // end tranmission
Wire.requestFrom(PCF8591, 5);
value0=Wire.read();
etc

Then I get a confident full scale deflection on the same circuit, but if I try to start the OLED, then the ADC stops working.

Sorry for the late reply, apparently I missed some issues in the passed. (I'm checking all my libs for missed issues, so can take a few days)

@Hairyloon
Is this issue still valid?

If this still is a problem, please reopen the issue.

Sorry, I had an accident with the project and it caught fire... I didn't notice you'd responded, but the problem kind of went away.
The project is still on the todo list though, so I may come back to you in due course.

caught fire

Hope there were no substantial losses.

so I may come back to you in due course.

Feel free to open an issue if the problem is library related.
Otherwise better discuss the problem on the Arduino forum as there more people are available to help you out.

Hope there were no substantial losses.
Just the two chips. :)


After installing toolbox MIBStd2 (V432-1) still can not get in "green engineering mode"

Hello
I sucessfuly installed update Mibstd2_Online_approval (V432-1) but I still can not get in green engineering mode.
Actual version MST2_EU_VW_P0480T (0480), Update MIBStd2_Online_Approval (V432-1)
Catalog device number 3Q0035864C
Navi version H29.319.120_STD2Nav_Eu
I also tryed to replace cpu folder in the root of the SD card with cpu folder from \toolbox\gem folder but still have the same problem.
Please help
Thank you

https://github.com/olli991/mib-std2-pq-zr-toolbox/blob/master/README.md

Hello
I have read the readme file but I still don't know where is probleme? Wrong
version or? I was using mibhelper by software version and I made
successfully updated but can not get in green engineering mode. Can you
give me advice? Where am I mistaking?
Thank you
sub, 21. sij 2023. 23:14 lprot @.***> je napisao:

https://github.com/olli991/mib-std2-pq-zr-toolbox/blob/master/README.md
—
Reply to this email directly, view it on GitHub
https://github.com/olli991/mib-std2-pq-zr-toolbox/issues/212#issuecomment-1399342955,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUW6AQ6NKXS2CBTLL4IRKQTWTRNUDANCNFSM6AAAAAAUCSLM5Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

Toolbox don't enable green menu, toolbox was correctly installed in your first attempt ( no need to replace cpu folder) no to use toolbox you need to enable green menu using obdeleven, vcds, ... Or device that can enable toolbox

Ok so I definitely need some obd2 device like obdeleven....thank you
sub, 21. sij 2023. 23:30 Medmimoza @.***> je napisao:

Toolbox don't enable green menu, toolbox was correctly installed in your
first attempt ( no need to replace cpu folder) no to use toolbox you need
to enable green menu using obdeleven, vcds, ... Or device that can enable
toolbox
—
Reply to this email directly, view it on GitHub
https://github.com/olli991/mib-std2-pq-zr-toolbox/issues/212#issuecomment-1399345151,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUW6AQ2HAKYGLE3S25B7WBTWTRPR7ANCNFSM6AAAAAAUCSLM5Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

If you don't have device, but you want to enable appconnect or voice or both still possible, if this what you want tell me

Yes I want to enable appconnect and I have problem with Navi maps update,
device don't recognise sd card (not vw original not alternative sd) and I
saw that through green engineering mode I can remove cid check for SD card.
Thank you
sub, 21. sij 2023. 23:34 Medmimoza @.***> je napisao:

If you don't have device, but you want to enable appconnect or voice or
both still possible, if this what you want tell me
—
Reply to this email directly, view it on GitHub
https://github.com/olli991/mib-std2-pq-zr-toolbox/issues/212#issuecomment-1399345679,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUW6AQ6T3MDMOXGVB2X66N3WTRP55ANCNFSM6AAAAAAUCSLM5Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

Uodate like you did with toolbox using content of this link, this will enable appconnect and patch cid too, all sdcard wil work,
https://mega.nz/file/Z8JSiBYJ#ZKj2kSbG--j8G2SUpVwmw4GKthHRe2nOoGrqM9HUpGU

Update with this, like you did with toolbox, this will enable appconnect and patch cid, all sdcard will work
https://mega.nz/file/opo3EYhA#-32Xl3C0g7iECdpsuOsW2Mt3i2CptPDp0o4T-PqOOTE

Great
I just unpack cpu folder and metainfo2.txt directly to root of sd card for
update?
sub, 21. sij 2023. 23:39 Medmimoza @.***> je napisao:

Uodate like you did with toolbox using content of this link, this will
enable appconnect and patch cid too, all sdcard wil work,
https://mega.nz/file/Z8JSiBYJ#ZKj2kSbG--j8G2SUpVwmw4GKthHRe2nOoGrqM9HUpGU
—
Reply to this email directly, view it on GitHub
https://github.com/olli991/mib-std2-pq-zr-toolbox/issues/212#issuecomment-1399346506,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUW6AQ537ITYYNLVAJ35AVLWTRQRLANCNFSM6AAAAAAUCSLM5Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yep

great!!!  Appconect is working now, thank you very much!
Navi still does not work, I tried to install new maps through vw discover
care app on laptop but at the end I had some error.
Do I need to install maps through discover care app or I can just unpack
them on the root directory on alternative SD card?
Thank you for help
sub, 21. sij 2023. u 23:39 Medmimoza @.***> napisao je:

Uodate like you did with toolbox using content of this link, this will
enable appconnect and patch cid too, all sdcard wil work,
https://mega.nz/file/Z8JSiBYJ#ZKj2kSbG--j8G2SUpVwmw4GKthHRe2nOoGrqM9HUpGU
—
Reply to this email directly, view it on GitHub
https://github.com/olli991/mib-std2-pq-zr-toolbox/issues/212#issuecomment-1399346506,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUW6AQ537ITYYNLVAJ35AVLWTRQRLANCNFSM6AAAAAAUCSLM5Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

Use map from vw website, use the one for discover media, then copy map folder into root

Ok I will try to so and I will try tommorow in the car again.
Thank you very much for help👍
ned, 22. sij 2023. 00:14 Medmimoza @.***> je napisao:

Use map from vw website, use the one for discover media, then copy map
folder into root
—
Reply to this email directly, view it on GitHub
https://github.com/olli991/mib-std2-pq-zr-toolbox/issues/212#issuecomment-1399351586,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUW6AQYGBJKAWJWWB7SAOFDWTRUWHANCNFSM6AAAAAAUCSLM5Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hello
Navi is also working with no-VW sd card! Great !
I have just one problem still, the appconnect is working just with usb
cable, I do pair mobile phone with discover device and I have find develop
menu in Android app and I have turn on wireless option but still
nothing...it's working just with usb cable. Do you have solution for this
problem ?
ned, 22. sij 2023. 00:17 Tomislav Tot @.***> je napisao:

Ok I will try to so and I will try tommorow in the car again.
Thank you very much for help👍
ned, 22. sij 2023. 00:14 Medmimoza @.***> je napisao:

Use map from vw website, use the one for discover media, then copy map
folder into root
—
Reply to this email directly, view it on GitHub
https://github.com/olli991/mib-std2-pq-zr-toolbox/issues/212#issuecomment-1399351586,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUW6AQYGBJKAWJWWB7SAOFDWTRUWHANCNFSM6AAAAAAUCSLM5Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

Congrats, all is donne with your unit, wireless is not suported,

@Teom0002 , is it navi unit with 2 sdcard slot?

Hello
How can we download all police speed cameras on maps on Navi?
čet, 16. ožu 2023. 22:56 Medmimoza @.***> je napisao:

@Teom0002 https://github.com/Teom0002 , is it navi unit with 2 sdcard
slot?
—
Reply to this email directly, view it on GitHub
https://github.com/olli991/mib-std2-pq-zr-toolbox/issues/212#issuecomment-1472800774,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUW6AQ57ILEYRHA4QEJZQL3W4OEBNANCNFSM6AAAAAAUCSLM5Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

Update with this, like you did with toolbox, this will enable appconnect and patch cid, all sdcard will work https://mega.nz/file/opo3EYhA#-32Xl3C0g7iECdpsuOsW2Mt3i2CptPDp0o4T-PqOOTE

Hi, same here - no OBD and only need to patch cid of SD card-  could you please make the file availbale again or provide any info where to find? Many thanks!


Tensorflow and Torch implementations

We need to add Tensorflow and Torch implementations of various models.
P.S. As suggested by Sebastian Ruder in his tweet.
I will be working on this, but first-time contributors are welcome to contribute too!

In which model I have to add can you explain please

@aditya1359 all models are equally welcome :)
We are looking for more awesome implementations, which can range from production grade code to those meant for teaching/learning.

Thanks for the information sir
On Tue, 25 Sep 2018, 09:24 Nirant<EMAIL_ADDRESS>wrote:

@aditya1359 https://github.com/aditya1359 all models are equally
welcome :)
We are looking for more awesome implementations, which can range from
production grade code to those meant for teaching/learning.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/keon/awesome-nlp/issues/127#issuecomment-424199105,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbF1UanV23TOgci8jA80eTcK7oOexCRgks5ueajvgaJpZM4TN3GG
.

Added one implementation: see #147. This implementation is purely practical (to load already trained vectors in an optimized way for the GPU in TensorFlow). The code is also written as a tutorial.

So we can submit any model?
For eg) Dogs and cats image classifier in Pytorch maybe?

Err. No. Solutions to NLP Challenges.
On Sun 2 Dec, 2018, 07:30 Rajat Kumar Gupta<EMAIL_ADDRESS>wrote:

So we can submit any model?
For eg) Dogs and cats image classifier in Pytorch maybe?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/keon/awesome-nlp/issues/127#issuecomment-443474201,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADGaPUr-DCqi1k_v8b-OgLxCaxXIRI9gks5u0zQqgaJpZM4TN3GG
.

A large fraction of NLP papers and their implementations (both PyTorch and Tensorflow) are already covered in NLP-Progress.
Closing this issue, in favour of future contributions to that repository.
This does not mean that implementations are not important for Awesome-NLP. We will simply focus on more robust and tested ideas and code, instead of just academic implementations


Invalid alternative root path forming in IrodsAPI.get_path()

Another yak shaving session initiated, this time while fixing #1888. In IrodsAPI.get_path(), if IRODS_ROOT_PATH is set we form an invalid path. The path is returned as /zone/projects/$IRODS_ROOT_PATH/etc instead of /zone/$IRODS_ROOT_PATH/projects/etc.
Obviously, current tests fail to detect this, so I'll need to update them as well.

Fixed.


Network graph shouldn't rebuild when power is low

Issue description:
Server lag, "Can't keep up! ..."
There is no crash log, but here's a sampler output for it. I had, in between those, up to 28 second behind on the server, and another with 14 seconds. It seems it spent quite a lot of time in com.raoulvdberge.refinedstorage.apiimpl.util.ItemStackList.add(), which seems unnatural for the few invocations (5784 invocations, 57532ms spent).
lag.zip
Another thing i noticed was my system blinking on and off, even though I am feeding it with enough energy (Flux Networks point on the controller, no limit on it).
It worked fine on the same setup on beta4, and nothing was changed (in the world) between updates. Lots of other mods updated in the AllTheMods pack though.
Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: <IP_ADDRESS>6
Refined Storage: refinedstorage-1.2-beta5.jar

Does this issue occur on a server? [yes/no]
Yes

I don't know where you get the ItemStackList number from, but looking at your NPS file, the lag is caused because the network graph is rebuilding constantly because you are running out of energy:

Hrm, let me see what is causing that. I am pretty sure my system is fed enough energy, but perhaps there is something inconsistent here with the way that the flux networks work. I'm going to replace the flux point, depower the system completely, and see if it resolves the issue.

Ok, this issue can be closed - the issue is because of Flux Networks and how they transmit power.

The graph shouldn't get rebuilt when power is low though, this is an optimization I can still do.

Ah gotcha :) It can be reproduced if you attach a Flux Networks point to the controller, and set the flux networks controller mode to "even distribution". You might need to have a fairly large system with a bit of energy pull to see this...

Another perf fix is to not send block updates too fast when the system is toggling on and off constantly. It needs a cooldown.

<HenryLoenwind> https://github.com/SleepyTrousers/EnderIO/blob/1.10/src/main/java/crazypants/enderio/machine/AbstractMachineEntity.java#L255-L266
<raoulvdberge> aha thx
<HenryLoenwind> in our case "active" is on the te, not the blockstate. if you need to set a different blockstate server-side, you need to do more adapting
<raoulvdberge> no i'm having something similair
<HenryLoenwind> but the logic should be the same
<raoulvdberge> https://github.com/raoulvdberge/refinedstorage/blob/mc1.11/src/main/java/com/raoulvdberge/refinedstorage/apiimpl/network/node/NetworkNode.java#L94-L101
<HenryLoenwind> btw, thsi delays switching off the "active" rendering by 20 ticks and switching it on by 4
<HenryLoenwind> so short state changes don't force a re-render
<HenryLoenwind> another thing I'd add is that the controller waits for its buffer to be >50% after it runs out of power before it reactivates
<raoulvdberge> so your logic is: - if it's going into inactive mode, only update after 20 ticks. - if its going into active mode, only update after 4 ticks.
<HenryLoenwind> yes, and if the state changes back in that time, reset the timer
<raoulvdberge> cool thx
<raoulvdberge> ideally block updates wouldn't be a fps log....
<raoulvdberge> * hog
<HenryLoenwind> I have different values because that fits a machine that usually is off
<HenryLoenwind> you may want to reverse them, your network is usually on
<HenryLoenwind> yeah, chunk rendering is still too heavy on the fps. even with models
<raoulvdberge> dumping this conversation on github so i remember for tonight
<HenryLoenwind> and offloading it to a second thread


Holistic style design

A holistic design is desired for the project which would provide contributors with guidance in implementing features, which includes but is not limited to:

Which features to emphasize, which features to de-emphasize, and which features to exclude entirely.
Stylistic purpose at each zoom level (or cluster of zoom levels)
Color assignments

It is desired that a holistic design be inspired by American aesthetics.

Do you mean something like a digital map with open source style or some kind of traditional paper map? One has to be careful about the copyright issues.

I mean that our map should look and feel familiar to Americans.  So, we would want design features that are common across a wide variety of North American makes (for example, highway shields, text labels alongside roads rather than squeezed in the fill).  We would want to emphasize and de-emphasize features that Americans would expect to see in a map at a certain zoom.  So, we should not copy a particular map, but we should consider which design features tend to appear across a wide variety of them.

Gotcha.
Maybe we could post here more links to printed or online maps that we could use to get a sense of what a typical US map look like.
Also... related to #25. We should decide what the general purpose of the map would be. There are different types of maps that serve particular purpose, which then dictates how and which features are shown. There is a difference between a road map for car traveling, hiking map, public transport map, city plan,...
Because the highway shields are so prominent in this project, I assume you want to more gear it towards a road map for people that are in their cars looking for a business or a place to go..

We should decide what the general purpose of the map would be. There are different types of maps that serve particular purpose, which then dictates how and which features are shown. There is a difference between a road map for car traveling, hiking map, public transport map, city plan

Agreed, however, we're not as tied to a singular purpose in the way that a paper map is, because paper maps are stuck at a single zoom level.  Rather than say "this map is for purpose X", I'd rather say "these features are emphasized and these features are de-emphasized", and also consider what makes sense based on zoom level.
Here are some initial thoughts that I had on map purpose:
"If you were travelling to an unfamiliar place, what would you want to see on a map?"
Thus, I think it is extremely important that a map strikes the right balance of showing useful information while minimizing clutter, and providing "breadcrumbs" to indicate where more information is available by zooming in.
The real challenges will be in the middle zooms, i.e. in the raster 12-16 (vector 11-15) range.  That's where styles like openstreetmap-carto have the biggest issue with too-high information density overwhelming the map.  We should think really carefully about what information do we want to convey at each zoom while still leaving "breadcrumbs" to tell map users that there's more information available by zooming in.
Also, as a general philosophy, and consistent with making an "American-style" map, we should de-emphasize/simplify/unify tagging schemes that doesn't fit the US very well.
Given the American reliance on the car, and the fact that road networks are the most important form of transportation in the US, roads, highway shields, and route networks are definitely something I think we should emphasize.  However, roads are not in competition with hiking areas - both should co-exist since they're in different places.  I would like to be able to emphasize long-distance hiking trails, such as the Appalachian Trail, Long Trail, North South Trail, New England Trail, Pacific Crest Trail, and so forth.  Those exist in places where there aren't highways and are interesting American features.
I think we want to not render OSM land cover at the mid-zooms, because the coverage is so poor in the US, for example:

If we're not rendering or de-emphasizing land cover, it may make sense to simplify or even unify the rendering style for parks, nature reserves, and protected areas, as the distinction between them is quite blurry in the US.
At the highest (closest) zoom levels, we should try to render basically everything, because nothing will be in competition with each other.  If you're close enough that it makes sense to show a fire hydrant or a manhole cover, there's no reason not to render it.
I would also like to see us do external integrations, especially with wikidata.  For example, I would 100% be in favor of showing corporate logos on stores at close zoom, by pulling them out of brand:wikidata tags and doing a lookup into wikidata.

I started a draft here: https://wiki.openstreetmap.org/wiki/United_States/Map_style/Holistic_design


[BUG] Confirmation by pressing Space on confirm screens

Describe the bug
Some usability from old ui can be implemented here as well. When ever we have a confirmation screen we need to click with the mouse, instead as per the old ui we can press Space to toggle the confirmation of expunge etc..
To Reproduce
Steps to reproduce the behavior:
Expunge a volume
Delete a VM
and more...
Screenshots
If applicable, add screenshots to help explain your problem.

This might require changing several custom forms to set autofocus. Makes sense to do it as a part of 1.1

We've one PR merge in #784 that fixes for auto-generated forms, for rest of the forms we can aim wrt 1.1


Thanks for the list

I say thanks to the authors for listing alMost all the apps and categories in to different groups.
I like to add more points here

whenever users installs new or existing updating applications from the Microsoft store. those apps are  installed into  Windowsapps folder.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ce0131fb-6b3a-5905-1738-253cf37e3b2d
Version Independent ID: cab448be-54ae-539e-22ba-3d202a468d4f
Content: Windows 10 - Apps
Content Source: windows/application-management/apps-in-windows-10.md
Product: w10
Technology: windows
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

@officedocsbot assign @e0i

Thank you for your feedback.

@officedocsbot close


Wrap Exceptions thrown from ctor/fromString/converters

This allow users to throw on their type construction and still get
a nice error message, which includes file/line and the field path.

Codecov Report

Merging #15 (6c7854f) into v1.x.x (359f942) will increase coverage by 2.43%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##           v1.x.x      #15      +/-   ##
==========================================
+ Coverage   73.87%   76.31%   +2.43%
==========================================
  Files           4        4
  Lines         245      266      +21
==========================================
+ Hits          181      203      +22
+ Misses         64       63       -1

Flag
Coverage Δ

unittests
76.31% <95.00%> (+2.43%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

source/agora/config/Config.d
71.42% <93.75%> (+2.33%)
:arrow_up:

source/agora/config/Exceptions.d
88.00% <100.00%> (+3.49%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359f942...6c7854f. Read the comment docs.

Fixed typo


Update blogs.json

I am writing on behalf of Appcircle. I added appcircle as company blog.

I'll close this for now but please feel free to re-open it when you get an RSS feed.


Add support for subscripts on fields

Closes #172

Actually depends on https://github.com/ForNeVeR/Cesium/pull/339/files#diff-795a89396bbd359c6b3d3638bc0af0bebde18640020b8e59925ffe7875404b21R45-R46 from #339

#339 is merged, could you please rebase?


Default client password

I had to manually set the password of<EMAIL_ADDRESS>to password in order to be able to enter the client area.

Are you hosting locally? I can't manage to get CORS to behave and let me into the portal. Wondering how you tested to get to login successfully (albeit having to change the hard-coded values in the LoginForm.vue component (that part is easy refactor for production use case) I just want to see the portal and haven't been able to get in.

Hi @jbool24! Yes, I am hosting locally and experienced no problems with CORS. Often it appears as a CORS error if the backend is simply not reached. Have you checked that directus is running and available under the address that you put in your .env file?

@jofmi yes confirming I am actually hitting the backend. All non-auth'd public pages are working. It's only on the /portal section I'm getting issues. In the browser console I can see the pre-flight requests and subsequent real POST request for the login failing with a CORS error. I used the default docker-compose inside '.directus' dir of this repo. I'm sure it's something easy I'm overlooking.
You don't have a proxy (on nuxt.config) setup for the front-end dev server, do you? You just hit 'http://localhost:{PORT}' on the front end app, right? Because I also tried setting up a local lookup with dnsmasq to make example.test resolve to localhost so that I could add 'http://example.test:3000' to the CORS_ORIGIN whitelist. That didn't make things work either.

Very strange! Yes, I just hit localhost:3000.

@jofmi yes confirming I am actually hitting the backend. All non-auth'd public pages are working. It's only on the /portal section I'm getting issues. In the browser console I can see the pre-flight requests and subsequent real POST request for the login failing with a CORS error. I used the default docker-compose inside '.directus' dir of this repo. I'm sure it's something easy I'm overlooking.
You don't have a proxy (on nuxt.config) setup for the front-end dev server, do you? You just hit 'http://localhost:{PORT}' on the front end app, right? Because I also tried setting up a local lookup with dnsmasq to make example.test resolve to localhost so that I could add 'http://example.test:3000' to the CORS_ORIGIN whitelist. That didn't make things work either.

same problem here!

added
CORS_ENABLED: true
to docker-compose.yml and now it's working @jbool24

@franforlizzi I had this ENV setting from the beginning. But it looks like it had more to do with docker volumes and caching I had in the DB. I did a fresh install of the whole stack and it worked correctly.

So I've just added soft launched AgencyOS into my staging Directus instance and during testing most things seem to work ok. I've started customizing the "Blocks", pages, etc. But when I get back to the /portal related pages/functionality I'm getting the CORS issues again. The front-end is being worked on locally (obviously) and the backend is deployed in parity with what Production will look like (right now I'm using heroku).
The backend is located at a public domain such as: https://cms.example.com
I also have these ENV set on the Directus instance: in heroku:
CORS_ENABLED=true
CORS_ORIGIN=/^https:\/\/www.example.com$/,/^http:\/\/example.test:[0-9]{1,5}$/

Then on the nuxt app side, the production subdomain of the nuxt app will be @ www in PROD and then I also added a white-list entry in Directus for the testing local (as above) url which is resolved to <IP_ADDRESS> using dnsmasq locally on my machine.
When the portal page calls out to /login route directly for the login flow with Directus we get a CORS origin error.
@bryantgillespie a few questions:

Do you think this is just me and a user error; did I miss something?
Is that section of code trying to talk directly to Directus from the client?
If so, should the web client use its nuxt server routes for login flow, leaving all that logic in the nuxt side so that all that is same-origin?


[stable/nginx-ingress] fix service selector

Which issue this PR fixes

fixes #21508

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @tahara

/assign @taharah

/lgtm
/ok-to-test

/retest


Error loading WASM backend

Hello, let's continue here.
I have this error message when loading the demo on localhost.

The only thing I did was clone the repo, update demo/index.html to uncomment the 3 lines for wasm/webgpu and then npm run dev. Then I select WASM and then I start the camera if breaks hard.

Have a nice day.

this is a memory access out-of-bounds during wasm startup - really weird.
i can reproduct if i switch to wasm backend before startup, but if i start run with webgl and then switch to wasm, no issues.
i'll dig more.

There seems to be a binary bug causing memory access error if Tensorflow WASM backend is deployed as ESM instead of old-school module and I use ESM exclusively in my library.
As a workaround, enable SIMD in your browser - that enables parallel instructions (that is recommended for WASM anyhow as it allows WASM to use more modern CPU instruction set)
Chrome:

Navigate to chrome://flags
WebAssembly SIMD support set to Enabled

Edge:

Navigate to chrome://flags
WebAssembly SIMD support set to Enabled

Firefox:

Navigate to about:config
javascript.options.wasm_simd set to True

I'll keep this issue open and discuss it with TFJS devs.

Sadly, I cannot support SIMD because I am building on Android for Capacitor and I run my app in a locked down platform. There is no way for me to set the flags to enable it.
But my app currently works this way with TFJS' blazeface in WASM mode. Isn't there a way to mix both ESM and non ESM ? Otherwise I will try to extract your model for the back camera to use it standalone.

i'm looking for a way to embed tfjs-backend-wasm without bad sideeffects.
currently i'm running into issues that tfjs-backend-wasm is simply not built the same way as the rest of tfjs, so embedding it directly is pretty messy.
give me a day.

Thank you for your awesome work !

ok, here it is:

new version of human with tfjs-backend-wasm bundled is published, do not load any scripts from index.html anymore
both wasm with and without simd work

but...

without simd, wasm has serious concurrency issues, so trick is to start with a single model enabled only
(e.g. only 'face detect') and once it is initialized, you can enable additional models one by one
with simd, no such issues

of course, simd is so much more faster than non-simd, so more complex models such as hand and body are barely usable without simd anyhow.
i've added a wiki article: https://github.com/vladmandic/human/wiki/Backends

@vladmandic WASM gives 3-4 fps at maximum (hand only, maxHands = 1, landmark = false) with SIMD, can this be improved

@vladmandic all my tests show me that with every Android device I tested, WASM is by far the fastest, even without SIMD. On my phone on your demo with few models I can get 10 fps on WASM and 3 fps with WebGL. Can you reproduce these results ? Maybe it's an error on ny part.

@simon-lanf
Depends on a hardware (on both mobile and desktop):

WASM executes on CPU in a native compiled code
SIMD means that code can use newer extended CPU instructions
for parallel processing and thus it's much faster
WebGL executes on GPU using GL calls which are processed by browser
So a lot depends on browser's implementation of WebGL as well
E.g, Chome is about 2x faster than Firefox at the moment but uses far more memory

And both WASM and WebGL have very specific weak points:

WASM does not have hardware-accelerated image buffer handling
So simply preparing image for processing is expensive
That's why you get big gains when you reduce input resolution
WebGL needs to compile the GL code and transfer data to GPU
So there is an overhead before processing actually start
This is especially visible at startup (so-called "warmup")

So if your CPU is faster than your GPU, WASM is faster. But if you have a good dedicated GPU chip (on desktop or mobile), WebGL will by faster.
Perf tests:

On my mobile Samsung S20Ultra with all models enabled, WebGL executes with 6+FPS and WASM with barely 2FPS
On my notebook with Intel i7 and nVidia 1650Ti, WebGL executes with 20+ FPS, WASM with barely 4FPS and WASM with SIMD with ~8FPS
But if I reduce input resolution to 720p, WASM with SIMD jumps to 15FPS and continues to climb with even lower resolutions

@djthegr8 I'll see what I can do, but biggest gains to WASM are by reducing resolution - it helps a lot!

@djthegr8 @simon-lanf
fyi, i've created an issue at tfjs to provide improved image data loading for wasm backend
currently it's only implemented for webgl and difference is drastic: webgl: <1ms vs wasm: >20ms
https://github.com/tensorflow/tfjs/issues/4218
also, regarding wasm (non-simd) memory issues, it is also being tracked at tfjs level
https://github.com/tensorflow/tfjs/issues/4208
since all the original questions have been addressed, i'm closing this issue


add user

Additional comment:
@conda-forge-admin, please add user @username

@conda-forge-admin, please add user @suzannejin


Switch to import_granularity: item

Putting each import statement on a dedicated line makes it a lot less
likely to create merge conflicts when items are removed / added because
Git resolves conflicts on a line-by-line basis.

bors r+

I'm happy with it as long as we can revert it back after the conflict-prone stuff gets in.  :)


Improve routes

We can have less code by using standard resourceful routes instead of manually setting ones. We also should make use of link_to defined_path instead of manually writting <a href="/define/<%= thing.id %>"> for instance.

Resolvido 🕺


which version of App Service Environment is this doc referring to?

[Enter feedback here]
This doc provides steps for publicly exposing the KUDU URL using a custom domain suffix, which is not yet available for ASEv3, so is this doc specific to ASEv2? If yes, it should be explicitly stated this is for an ASEv2
Specifically the section "A valid public certificate"
"The SAN that allowing to connect to App Service kudu service. It's an optional setting, if you don't want to publish the App Service kudu service to the internet." in the examples it shows the KUDU site using a custom domain suffix.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e30dfd76-2a83-bd21-2153-85e32894014e
Version Independent ID: 9dca62e8-0aef-10eb-b2d3-2ab12087f90a
Content: Integrate with Application Gateway - Azure App Service Environment
Content Source: articles/app-service/environment/integrate-with-application-gateway.md
Service: app-service
GitHub Login: @madsd
Microsoft Alias: madsd

@meepstei
Thanks for your feedback! We will investigate and update as appropriate.

Hi @meepstei, it should work for both ASEv2 and ASEv3. AppGw will use the internal domain name (appserviceenvironment.net) and can therefore also reach the scm site. Though you will not be able to use SSO on either, and you should log in with basic auth using /basicauthviaproxy in the url.
Direct scm custom domain for ASEv3 is currently rolling out - we expect it to be available globally by the end of the year.


Add Shadcn combobox

Works towards #889.

Changes the type of ComboBoxProps<T>.onChange to (value: T) => void since shadcn's Command doesn't give any extra event information and the users of ComboBox never used this information.
Adds ComposableTextField which is similar to TextField but can be used inside other shadcn components via asChild.

TextField and ComboBox both use ComposableTextField.

TODO
ComboBoxProps.width doesn't seem to affect the ComboBox and ComboBox.isClearable hasn't been implemented
Note
The first commit contains the original shadcn components installed with npx shadcn-ui@latest add  ..

This change is

lib/platform-bible-react/src/components/combo-box.component.tsx line 100 at r1 (raw file):
Previously, jolierabideau wrote…
I see! That is a good idea. But I think we want to match the Shadcn implementation of Combobox. Using CommandList will get us closer to that with the search bar part of the drop down instead of as the main element. This element is a little different because we are not just switching a wrapper from MUI to Shadcn like the others. You can build this Combobox just like the one in the docs.

If we're not just trying to copy MUI, I'm less sure about how to use the title and hasError properties

@dewert99

If we're not just trying to copy MUI, I'm less sure about how to use the title and hasError properties

Sorry for the late reply on this. When we created these wrappers we based the props on the MUI components so some of them are pretty specific and we don't need to re-implement them. Shadcn doesn't have a Combobox component that we can install and use, they show you an example of how to build a Combobox with two of their other components, so we really just need to copy their implementation and test it. Once you start to build it following the Shadcn example, you will probably notice things that people will want to customize that could become props. Off the top of my head I see: options (frameworks in example), variant, className, placeholder, isOpen, handleOpen, etc.
There has been some on-going discussion on the team about how we should implement Shadcn, and if we need wrappers, you may have seen some of those conversations in Discord. The ultimate decision is that we are not moving forward with wrappers. So the Combobox is an excellent component for you to work on because Shadcn doesn't provide one, and we will need it. After that would be IconButton, because Shadcn doesn't provide an easy to copy one of those. The rest of the components listed at the top of issue #889, we do not need you to convert (I will edit the issue to reflect this).


clean up InternalTokens.translatePosition

The amount of special cases in this method is amazing. I spent several hours on it and haven't quite found a way to make it non-ugly. We should probably rethink this abstraction.

Fixed in f2bc77178e71b5b929bf95e1229cb6c93dd7670e.


What's the difference between tensorflow and numpy in terms of solving ODEs?

Tensorflow is strongly optimized for working with GPU (mainly using CUDA)

Interesting! Regarding solving ODEs/PDE3, the cost roughly scales with the number of discretization nodes in space and time, and the cost of a single time step and a single cell. Traditionally, the cost is reduced by distributing the computation of different nodes to different processors. Regarding the tensorflow, I guess the benefit is to reduce the cost of the integration in single time step and single node. One advantage is that the tensorflow provide the Jacobian matrix via the auto-differentiation, but I  can not imagine how can the GPU help the computation?

Not sure about the way in which tensorflow/cuda implement specific matrix operations.
But the script run much much faster on GPU (GTX1080) compare to CPU(i7) so...

Interesting!