Having difficulty walking to XXXX

Expected Behavior
When walking to next Pokestop the bot should spin the stop
Actual Behavior
Stop does not spin, message in log shows "Having difficulty walking to XXXX", bot continues to walk buddy and incubate eggs
Your FULL config.json (remove your username, password, gmapkey and any other private info)
{
"websocket_server": false,
"heartbeat_threshold": 10,
"enable_social": true,
"check_niantic_api": true,
"solve_captcha": false,
"live_config_update": {
"enabled": false,
"tasks_only": false
},
"tasks": [
{
"type": "TelegramTask",
"config": {
"enabled": false,
"master": null,
"password": null,
"// old syntax, still supported: alert_catch": [
"all"
],
"// new syntax:": {},
"alert_catch": {
"all": {
"operator": "and",
"cp": 1300,
"iv": 0.95
},
"Snorlax": {
"operator": "or",
"cp": 900,
"iv": 0.9
}
}
}
},
{
"type": "DiscordTask",
"config": {
"enabled": false,
"master": null,
"// old syntax, still supported: alert_catch": [
"all"
],
"// new syntax:": {},
"alert_catch": {
"all": {
"operator": "and",
"cp": 1300,
"iv": 0.95
},
"Snorlax": {
"operator": "or",
"cp": 900,
"iv": 0.9
}
}
}
},
{
"//NOTE: This task MUST be placed on the top of task list": {},
"type": "RandomAlivePause",
"config": {
"enabled": false,
"min_duration": "00:00:10",
"max_duration": "00:10:00",
"min_interval": "00:05:00",
"max_interval": "01:30:00"
}
},
{
"type": "HandleSoftBan"
},
{
"type": "RandomPause",
"config": {
"enabled": false,
"min_duration": "00:00:10",
"max_duration": "00:10:00",
"min_interval": "00:10:00",
"max_interval": "02:00:00"
}
},
{
"type": "CompleteTutorial",
"config": {
"enabled": false,
"// set a name": "",
"nickname": "",
"// 0 = No Team, 1 = Blue, 2 = Red, 3 = Yellow": "",
"team": 2
}
},
{
"type": "CollectLevelUpReward",
"config": {
"collect_reward": true,
"level_limit": -1
}
},
{
"type": "BuddyPokemon",
"config": {
"enabled": true,
"buddy_list": "dratini, larvitar, chansey, heracross, snorlax, lapras, rhyhorn",
"best_in_family": true,
"// candy_limit = 0 means no limit, so it will never change current buddy": {},
"candy_limit": 25,
"candy_limit_absolute": 0,
"// force_first_change = true will always change buddy at start removing current one": {},
"force_first_change": false,
"buddy_change_wait_min": 3,
"buddy_change_wait_max": 5,
"min_interval": 120
}
},
{
"type": "IncubateEggs",
"config": {
"enabled": true,
"infinite_longer_eggs_first": false,
"breakable_longer_eggs_first": true,
"min_interval": 120,
"infinite": [2,5],
"breakable": [10]
}
},
{
"type": "UpdateLiveStats",
"config": {
"enabled": true,
"min_interval": 139,
"stats": ["uptime", "km_walked", "xp_earned", "xp_per_hour", "stardust_earned", "level_completion", "highest_cp_pokemon", "most_perfect_pokemon"],
"terminal_log": true,
"terminal_title": true
}
},
{
"type": "UpdateLiveInventory",
"config": {
"enabled": true,
"min_interval": 205,
"show_all_multiple_lines": false,
"items": ["pokemon_bag", "space_info", "pokeballs", "greatballs", "ultraballs", "razzberries", "luckyegg", "incense"]
}
},
{
"type": "UpdateHashStats",
"config": {
"enabled": true,
"min_interval": 60,
"stats" : ["period", "remaining", "maximum", "expiration"]
}
},
{
"type": "ShowBestPokemon",
"config": {
"enabled": true,
"min_interval": 300,
"amount": 10,
"order_by": "cp",
"info_to_show": ["cp", "ivcp", "dps", "hp"]
}
},
{
"type": "TransferPokemon",
"config": {
"enabled": true,
"min_free_slot": 200,
"transfer_wait_min": 3,
"transfer_wait_max": 5
}
},
{
"type": "NicknamePokemon",
"config": {
"enabled": true,
"nickname_above_iv": 0.8,
"nickname_template": "{iv_pct}_{iv_ads}",
"nickname_wait_min": 3,
"nickname_wait_max": 5
}
},
{
"type": "EvolvePokemon",
"config": {
"enabled": true,
"evolve_list": "all",
"donot_evolve_list": "Magikarp, Chansey, Rhyhorn, Dragonair, Dratini, Larvitar, Pupitar",
      "first_evolve_by": "iv",
      "evolve_above_cp": 0,
      "evolve_above_iv": 0.9,
      "logic": "and",
      "min_evolve_speed": 25,
      "max_evolve_speed": 30,
      "use_lucky_egg": false
    }
  },
  {
    "type": "UseIncense",
    "config": {
      "use_incense": true,
      "use_order": [
        "ordinary",
        "spicy",
        "cool",
        "floral"
      ]
    }
  },
  {
    "type": "RecycleItems",
    "config": {
      "enabled": true,
      "min_empty_space": 15,
      "max_balls_keep": 150,
      "max_potions_keep": 75,
      "max_berries_keep": 50,
      "max_revives_keep": 25,
      "item_filter": {
        "Pokeball":       { "keep" : 100 },
        "Potion":         { "keep" : 10 },
        "Super Potion":   { "keep" : 20 },
        "Hyper Potion":   { "keep" : 30 },
        "Revive":         { "keep" : 25 },
        "Razz Berry":     { "keep" : 50 }
      },
      "recycle_wait_min": 3,
      "recycle_wait_max": 5,
      "recycle_force": true,
      "recycle_force_min": "00:01:00",
      "recycle_force_max": "00:05:00"
    }
  },
   {
        "type": "CatchLimiter",
        "config": {
            "enabled": true,
            "min_balls": 20,
            "duration": 15
        }
    },
     {
    "type": "CatchPokemon",
    "config": {
      "enabled": true,
      "catch_visible_pokemon": true,
      "catch_lured_pokemon": true,
      "min_ultraball_to_keep": 5,
      "berry_threshold": 0.35,
      "use_pinap_on_vip": true,
      "vip_berry_threshold": 0.9,
      "treat_unseen_as_vip": true,
      "daily_catch_limit": 800,
      "vanish_settings": {
        "consecutive_vanish_limit": 10,
        "rest_duration_min": "02:00:00",
        "rest_duration_max": "04:00:00"
      },
      "catch_throw_parameters": {
        "excellent_rate": 0.1,
        "great_rate": 0.5,
        "nice_rate": 0.3,
        "normal_rate": 0.1,
        "spin_success_rate" : 0.6,
        "hit_rate": 0.75
      },
      "catch_simulation": {
        "flee_count": 3,
        "flee_duration": 2,
        "catch_wait_min": 3,
        "catch_wait_max": 6,
        "berry_wait_min": 3,
        "berry_wait_max": 5,
        "changeball_wait_min": 3,
        "changeball_wait_max": 5,
        "newtodex_wait_min": 20,
        "newtodex_wait_max": 30
      }
    }
  },
  {
    "type": "SpinFort",
    "config": {
      "enabled": true,
      "spin_wait_min": 3,
      "spin_wait_max": 5,
      "daily_spin_limit": 1900
    }
  },
  { "type": "UpdateWebInventory",
    "config": {
      "enabled": true
    }
  },
  {
        "type": "PokemonHunter",
        "config": {
            "enabled": false,
            "max_distance": 1500,
            "hunt_all": false,
            "hunt_vip": true,
            "hunt_pokedex": true,
            "lock_on_target": false
        }
    },
  {
    "type": "MoveToFort",
    "config": {
      "enabled": true,
      "lure_attraction": true,
      "lure_max_distance": 2000,
      "walker": "StepWalker",
      "log_interval": 5
    }
  },
  {
    "type": "FollowSpiral",
    "config": {
      "enabled": true,
      "diameter": 4,
      "step_size": 70
    }
  }
],
"map_object_cache_time": 5,
"forts": {
  "avoid_circles": true,
  "max_circle_size": 50,
  "cache_recent_forts": true
},
"pokemon_bag": {
  "// if 'show_at_start' is true, it will log all the pokemons in the bag (not eggs) at bot start": {},
  "show_at_start": true,
  "// if 'show_count' is true, it will show the amount of each pokemon (minimum 1)": {},
  "show_count": false,
  "// if 'show_candies' is true, it will show the amount of candies for each pokemon": {},
  "show_candies": true,
  "// 'pokemon_info' parameter define which info to show for each pokemon": {},
  "// the available options are": {},
  "// ['cp', 'iv_ads', 'iv_pct', 'ivcp', 'ncp', 'level', 'hp', 'moveset', 'dps']": {},
  "pokemon_info": ["cp", "iv_pct"]
},
"walk_max": 4.16,
"walk_min": 2.16,
"alt_min": 500,
"alt_max": 1000,
"sleep_schedule": {
  "enabled": true,
  "enable_reminder": false,
  "reminder_interval": 600,
  "entries": [
     {
      "enabled": true,
      "time": "00:30",
      "duration": "2:30",
      "time_random_offset": "00:30",
      "duration_random_offset": "00:30",
      "wake_up_at_location": ""
    },
    {
      "enabled": true,
      "time": "05:00",
      "duration": "4:00",
      "time_random_offset": "00:30",
      "duration_random_offset": "00:30",
      "wake_up_at_location": ""
    },
    {
      "enabled": true,
      "time": "11:30",
      "duration": "3:00",
      "time_random_offset": "00:30",
      "duration_random_offset": "00:30",
      "wake_up_at_location": ""
    },
    {
      "enabled": true,
      "time": "16:30",
      "duration": "3:30",
      "time_random_offset": "00:30",
      "duration_random_offset": "00:30",
      "wake_up_at_location": ""
    },
    {
      "enabled": true,
      "time": "21:00",
      "duration": "1:30",
      "time_random_offset": "01:00",
      "duration_random_offset": "00:30",
      "wake_up_at_location": ""
    }
  ]
},
"gps_default_altitude": 8.0,
"replicate_gps_xy_noise": false,
"replicate_gps_z_noise": false,
"gps_xy_noise_range": 0.000125,
"gps_z_noise_range": 12.5,
"debug": false,
"test": false,
"walker_limit_output": false,
"health_record": true,
"location_cache": false,
"distance_unit": "km",
"reconnecting_timeout": 15,
"logging": {
  "color": true,
  "show_datetime": true,
  "show_process_name": true,
  "show_log_level": true,
  "show_thread_name": false
},
"catch": {
  "any": {"candy_threshold" : 500 ,"catch_above_cp": 0, "catch_above_iv": 0.85, "logic": "and"},
  "// Example of always catching Rattata:": {},

  "Mareep": { "always_catch" : true },
  "Flaaffy": { "always_catch" : true },

  "Tauros": { "always_catch" : true },
  "Kangaskhan": { "always_catch" : true },
  "Heracross": { "always_catch" : true },
  "Corsola": { "always_catch" : true },
  "Farfetch'd": { "always_catch" : true },

  "Togetic": { "always_catch" : true },
  "Hitmontop": { "always_catch" : true },
  "Unown": { "always_catch" : true },
  "Arcanine": { "always_catch" : true },
  "Growlithe": { "always_catch" : true },
  "Dragonite": { "always_catch" : true },
  "Dragonair": { "always_catch" : true },
  "Dratini": { "always_catch" : true },
  "Wartorle": { "always_catch" : true },
  "Blastoise": { "always_catch" : true },
  "Pikachu": { "always_catch" : true },
  "Raichu": { "always_catch" : true },
  "Ivysaur": { "always_catch" : true },
  "Venusaur": { "always_catch" : true },
  "Charmeleon": { "always_catch" : true },
  "Charizard": { "always_catch" : true },
  "Lapras": { "always_catch" : true },
  "Exeggcute": { "always_catch" : true },
  "Rhyhorn": { "always_catch" : true },
  "Rhydon": { "always_catch" : true },
  "Exeggutor": { "always_catch" : true },
  "Chansey": { "always_catch" : true },
  "Magikarp": { "always_catch" : true },
  "Gyarados": { "always_catch" : true },
  "Aerodactyl": { "always_catch" : true },
  "Mew": { "always_catch" : true },
  "Ditto": { "always_catch" : true },
  "Mewtwo": { "always_catch" : true },
  "Snorlax": { "always_catch" : true },
  "Porygon": { "always_catch" : true },
  "Machoke": { "always_catch" : true },
  "Machamp": { "always_catch" : true },
  "Tyranitar": { "always_catch" : true },
  "Blissey": { "always_catch" : true },
  "Scizor": { "always_catch" : true },
  "Farfetch'd": { "always_catch" : true },
  "Espeon": { "always_catch" : true },
  "Ursaring": { "always_catch" : true },
  "Feraligatr": { "always_catch" : true },
  "Typhlosion": { "always_catch" : true },
  "Ampharos": { "always_catch" : true },
  "Porygon2": { "always_catch" : true },
  "Unown" : { "always_catch" : true }
},

"release": {

  "any": {"keep_best_iv": 2, "keep_best_cp": 1},

  "// any": {"release_below_cp": 0, "release_below_iv": 0.9, "logic": "or"},

  "Arcanine": { "never_release" : true },
  "Dragonite": { "never_release" : true },
  "Lapras": { "never_release" : true },
  "Muk": { "never_release" : true },
  "Exeggutor": { "never_release" : true },
  "Chansey": { "never_release" : true },
  "Gyarados": { "never_release" : true },
  "Aerodactyl": { "never_release" : true },
  "Farfetch'd": { "never_release" : true },
  "Mew": { "never_release" : true },
  "Mewtwo": { "never_release" : true },
  "Snorlax": { "never_release" : true },
  "Machamp": {"never_release": true},
  "Articuno": {"never_release": true},
  "Zapdos": {"never_release": true},
  "Moltres": {"never_release": true},
  "Tyranitar": {"never_release": true},
  "Blissey": {"never_release": true},
  "Unown": {"never_release": true}

},
"vips" : {
    "Any pokemon put here directly force to use Berry & Best Ball to capture, to secure the capture rate": {},
    "any": {"catch_above_cp": 1500, "catch_above_iv": 0.9, "logic": "or" },
    "Lapras": {},
    "Moltres": {},
    "Zapdos": {},
    "Articuno": {},

    "// S-Tier pokemons (if pokemon can be evolved into tier, list the representative)": {},
    "Mewtwo": {},
    "Dragonite": {},
    "Dragonair": {},
    "Dratini": {},
    "Snorlax": {},
    "// Mew evolves to Mewtwo": {},
    "Mew": {},
    "Arcanine": {},
    "Vaporeon": {},
    "Gyarados": {},
    "Chansey": {},
    "Flareon": {},
    "Larvitar": {},
    "Pupitar": {},
    "Tyranitar": {},
    "Blissey": {},
    "Heracross": {},
    "Scizor": {},
    "Espeon": {},
    "Feraligatr": {},
    "Typhlosion": {},
    "Ampharos": {},
    "Porygon2": {},
    "Togetic": {},
    "Unown": {},

    "Mareep": {},
    "Flaaffy": {}

},
"websocket": {
	"start_embedded_server": true,
	"server_url": "<IP_ADDRESS>:4001"
}

}
Other Information
OS: Ubuntu
Branch: Master
Git Commit: de8de509
Python Version: Python 2.7.12
Any other relevant files/configs (eg: path files)

i never ever see that message in bot

Sometimes the bot gets stuck on its way to a Pokestop as reported in #6065 this message is an attempt to fix those problems and was introduced in #6092
is the bot not moving at all, or does it just skip the stop?

The bot seems to be moving, buddy still walked, eggs still incubated, but skips the stops and moves to the next

I have the same problem that it just "freezes" into moving to a pokestop after some time. MoveToFort just gets stuck.

@camnomis that's the intended behaviour 😄
@goedzo do you still have that problem a lot while using the latest dev?

@davidakachaos that good to know, however what causes the behaviour? Do we know what causes the Pokestop's to not spin

This isn't caused by not spinning the Pokestop, it's a problem somewhere in the walker that makes it confused about moving to the Pokestop in question. Polyline sometimes has the problem a stop isn't reachable from the road (according to Google Maps)
I admit, this is just a bandage and doesn't solve the real problem. I don't know why the Walkers sometimes have problems moving toward a stop. And most other times it seems to work fine, that is why I created this solution; skip the stop for 5 minutes and move on.

Yep. Had it yesterday evening on two accounts.

I'm getting the same error and on top of that sometimes it starts towards a pokestop or a gym and then starts towards another and never goes to either.

I swapped in an older version of move_to_fort.py and I no longer experience the issue! Not sure which commit this is from but here's the move_to_fort.py i'm using that's working fine. I am 100% sure that it is unmodified from when originally cloned. https://pastebin.com/xDKrydS5

Are you all in dense area with lots of pokestops?

here is my config, i dont have any issue:
https://pastebin.com/cVPx2UGw

@MerlionRock in my play area there are about 20 stops and 5 gyms. In my instance, only 2 stops can be reached simultaneously, all others require walking of ~10-15 meters. I have noted that at times my bot will actually pursue a fort that is further away than the one it was previously walking to.

This looks like the issue. It's running in circles. Ps. This is the new web-ui on moble.

Having difficulty walking to Laddermen Memorial. Changing walker.
First time on me when u change StepWalker to PolylineWalker

@Jcolomar it's okay. Polyline Walker follows path, but some gyms and pokestop won't have path leading to them, so changing Walker is appropriate

It seems that I have this:
    {
        "type": "MoveToFort",
        "config": {
            "enabled": true,
            "lure_attraction": true,
            "lure_max_distance": 2000,
            "walker": "PolylineWalker",
            "log_interval": 60
        }
    },

So maybe that is why it cannog make it,. Howevel polyline is the safest, because it follows real roads. So what to do here? I would like to keep it.

I'm also having this problem, on different systems (ubuntu and raspbian), and on all my accounts. I normally bot in my hometown, but I also used it when I was on holidays at the holiday resort, about four weeks ago, when I first stumbled into this (back then there was no "Having difficulty walking to XXXX", but the bot was not getting to the pokestop). It is happening with both StepWalker and PolylineWalker. I got the bot to not be stuck forever by adding Campfort to the config file, so after some time the bot enters into Campfort mode and moves away, but this makes the bot quite ineffective. The bot seems not to move when stuck, except for the simulated GPS noise. The hunter is having the same problem, it gets stuck for some time without being able to approach it's target, but it appears to get able to move again after a few minutes.
config.json.txt

I'm wondering... Will setting the noise to off help us?
    "replicate_gps_xy_noise": false,
    "replicate_gps_z_noise": true,
    "gps_xy_noise_range": 1.01E-4,
    "gps_z_noise_range": 7.5,

So, disable the replicate_gps_xy_noise thingie, does that help anyone else? It seems to reduce the number of times this happens to me (not sure why)

i go this values if wanna check on ur setup:
"replicate_gps_xy_noise": false,
"replicate_gps_z_noise": false,
"gps_xy_noise_range": 0.000010,
"gps_z_noise_range": 0.5,

Please check if the recent fix does the trick

Hi
As far as I can see, the bot is still sometimes changing it's destination pokestop one after the other sometimes complainig about having difficulties getting there. As I have Pokehunter and Campfort in the config, the bot is not often doing movetofort, and therefore I'm not seening this issue very often.
  Günter
On Thu Jul 27 2017 17:19:20 GMT+0300 (EEST), ChiefM3<EMAIL_ADDRESS>wrote:
Please check if the recent fix does the trick
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

This function
self.bot.get_forts(order_by_distance=True)
seams to return empty list  for many of its attemps for me.

i removed line
forts = filter(lambda x: 'closed' not in fort, forts)
from pokemongo_bot/init.py line 1646 No idea what it does but everything works better now


Processing frames in random order

When I run the image processing pass, the script seems to pull random frames from the frame directory instead of processing them sequentially:
Frame 158 of 1866
Frame Time: 1s
Estimated Total Time Remaining: 1708s (0:28:28)

Processing: myvideo/image-000659.png
0 0 inception_3b/output (360, 540, 3)
0 1 inception_3b/output (360, 540, 3)
...
3 9 inception_3b/output (360, 540, 3)

Saving Image As: myvideo/frames/frame_000159.png
this gives me an unwatchable mess when I try to re-stitch the frames.

I'm having this happen to me on ubuntu as well, this is not happening on the version of this I have working on windows, which has been there for some time.
I thought it was somehow possible to be my file format at first, but changing it did not fix the issue.
I'm using "python dreamer.py --input ddin --output ddout"

I too am having this issue with the frames coming out in a random order, does anyone know python and can figure out whats going wrong in the code?

@tkoham After some time i found a fixed version of this, i cant seem to find the bookmark (It was on github) so heres the fixed dreamer.py (just take out the .txt obvs)
dreamer.py.txt

Finally got around to checking that. Thanks ChocolateRain! Worked like a charm!

thanks!

Thanks! can't believe I missed that


Change formatitng

Format last cmdlet to display as PowerShell
Make small style/grammar change

@CarolynRowe PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Added TeeWriter.

Coverage increased (+0.04%) to 88.398% when pulling b15b92e74ea4f2077887efb5453011fd6ca82587 on robtimus:TeeWriter into a315d695e9da1d9fb68c20cc1987ef92447f370c on apache:master.

I will take a look over the weekend, I have an idea for a different implementation.


config file for database connection

Write a configuration file to connect to the database so we don't need to hardcode database authentications

In addition, make a function to open and (silently) close the database connection.

The following functions, which should be used for connecting to, downloading from, and disconnecting from the database have been added to 'util.R`:
db_open() : creates a database connection to the popler database. Instead of src_postgres(), this now uses a popler-specific function called popler_connector(), which was required to actually open and close db connections without printing messages to the user.
db_close(conn): silently closes a connection created by db_open()
query_get(conn, query): takes a connection created by db_open() and a string query; queries the database and returns a dataframe.
popler_connector(dbname, host, port, user, password, silent=T): this is a slightly modified version of dplyr::src_postgres. It's been modified so that database connections can be silently closed without messaging the user.
popler_disconnector(conn, name, silent=T): this is a slightly modified version of dplyr:::db_disconnector. It's been modified so that database connections can be silently closed without messaging the user.
I still haven't written a configuration file, so that still needs to be done, but I think we can put it in ./R/systdata.rds and it should work smoothly... it's on the to-do list!


Pipsi like deployment option

Hey there!
First off, I am a huge fan of poetry and can't wait to see how this project changes Python packaging. I would like to start taking advantage of the pyproject.tml style of packaging, but I need to be able to deploy my packages on a remote mount, for which I have been using pipsi for that.
It would be awesome for poetry install to support installing a package in a local virtual environment and providing a bin that has symlinks to the installed entry point script.

Maybe poetry install <pkg> --global?

Maybe the functionality exposed by the current install command could be left to develop and install could work like Cargo's install and pipsi


Custom element v-model : rename type to v-model-type

What problem does this feature solve?
v-model is now usable on web component :) see https://github.com/vuejs/vue-next/issues/1699 and this commit : https://github.com/vuejs/vue-next/commit/71c3c6e2a03095ddd4c2a1e15957afd3ec8d4120
However I have a suggestion concerning the type attribute on v-model on a custom element.
I think it could be safer to force the "type" and name the prop v-model-type instead of type. type looks to dangerous to me for naming collision. I was also thinking of  but I do not think that it respects the design of the modifier, it is more an "adder" in this case.
What do you think : rename type to v-model-type and make it mandatory for custom element with a proper error message ? I can make a PR if you approve the idea :).
What does the proposed API look like?

<my-custom-elt v-model="model" v-model-type="text" />

I don't really think this is necessary. If you have a custom input element that is expected to work with v-model and have something like type="radio" or type="checkbox" on it, it would be really weird for it to not indicate that "this element behaves like a native radio/checkbox".
Adding yet another built-in directive for this highly unlikely case seems overly cautious to me.


Revert "feat(CL): gamm refactor, switch to swaprouter for pool creation & swaps (merge to main 4) (#3504)"

Closes: #XXX
What is the purpose of the change
Reverting to better isolate state breaks, query breaks and upgrade handler changes.
This will be merged with a better strategy

This is direct:
git revert afcf5d711c632ead78b8c038b897f3e2b31051be

Commit: https://github.com/osmosis-labs/osmosis/commit/afcf5d711c632ead78b8c038b897f3e2b31051be
Main history: https://github.com/osmosis-labs/osmosis/commits/main
with no extra changes made

I confirmed that the file diff between this revert and the actual PR itself is from the x/gamm/types/query.pb.go and x/gamm/types/tx.pb.go


Add mising producer for Full variant of DependentContextTest.

Fixes #343

FYI, I'll do a quick RC 6 release since this is otherwise going to fail for all integrators trying to pass the TCK.


Refactored mapped condition filter; added fhir expression + condition lookup filters

This PR introduces a new design pattern for filters in ReportStream and adds legacy conditionFilter support to the recently added mappedConditionFilter (which has been refactored to use the new design pattern). This adds two new types of filter: FHIRExpressionConditionFilter and ConditionLookupConditionFilter.
Test Steps:

Run full test suite
Manually test a legacy condition filter
Manually test a mapped condition filter
Manually test a combination of 2 & 3

Changes

Refactor abstract ConditionFilter and related implementations
Update FHIRRouter to utilize new filter design pattern properly
Added FHIRExpressionConditionFilter and ConditionLookupConditionFilter

Checklist
Testing

[x] Tested locally?
[x] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[x] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests? One still needs fixed and a couple more added

Linked Issues

Fixes #12705
Fixes #12706

To Be Done
Before Merge / Review

Add comments
Manual test steps
Address 1 minor TODO
Fix 1 broken test
Finish adding test coverage for new ConditionFilter pattern
Add test coverage for ConditionLookupConditionFilter and FHIRExpressionConditionFilter

Tech Debt

Refactor rest of filters (create ticket)

Deployment Strategy

Code: Add temporary no-op on mappedConditionFilter

DEPLOY Prime can now handle the new mappedConditionFilter but is not using them

Config: Duplicate production conditionFilters as mappedConditionFilters
Code: Remove legacy conditionFilter code and temporary no-op

DEPLOY Prime is now using only the new condition filters but with the mapped moniker

Config: Configure production conditionFilter as duplicates of mappedConditionFilter
Code: Adjust implementation to use conditionFilter instead of mappedConditionFilter

DEPLOY Prime is now using the new condition filters without the mapped moniker

Config: Remove mappedConditionFilter from production config
Code: Remove mappedConditionFilter from codebase

passed all tests locally

I saw migration of existing settings on deployed ENVs w.r.t this filter changes being planned

Intro of abstract and open classes on condition filter look neat and could help potential future impl of condition filtering of different flavors

Nothing to add w.r.t coding style as Micheal already covered that.

I'll ping you (and @mkalish) once tests changes and code comments are up.

Super neat stuff, I really like the direction where this is heading. Have some comments, let me know if you want to chat about any of them
* Missing a lot of documentation; I'm liking the changes but I think KDoc would be really helpful

Heard and addressing.

* I think a lot of places the default params can get dropped

👍

* I'm not sure bundling in the removing of observations into the "filter" behavior makes sense (and realistically is a problem that exists before this change).  The code uses the filter to mean two different things

In a previous version of this I had two abstract methods: evaluate (for qualifying receivers) and filter (for filtering the bundle). I'm not against splitting them, but implementation ends up being the same algorithm just returning different data (and noop for the filter).

Run all these filters and let me know if any of them passed
Run all these filters and let me know what observations failed which filters

  * Filter the list of the receivers for a topic; for the condition case that means a receiver is filtered if none of the condition filters evaluate to true
  * For an individual receiver, the bundle is then filtered such that the a observation is only included if any of the condition filters evaluate to true
    I think these distinctions need to be better surfaced; for example the idea of a "not" condition filter might be difficult to configure correctly to work for both of the cases

Could a wrapper class or a an added class member (val not: Boolean = false) achieve this effectively?

* I'd like to see a lot more unit tests around all the new condition code

Wrapping up, thanks for reviewing what's up :).


Remove eslint from dependencies

Expected Behaviour
eslint is development tool, should be only on devDependencies
Actual Behaviour
eslint is added as dependency, This conflicts with eslint in our project.
Frappé Charts version: 1.0.0

Fixed #137


TreeDataProvider: allow programmatically changing the selection

The default explorer view highlights the current file when the active editor changes. It would be nice to be able to match this behavior with custom tree views.
Related: https://github.com/patrys/vscode-code-outline/issues/12

@patrys I see the general need of programmatically changing the selection, but not sure if I understand your usecase you related to the explorer view. Can you please elaborate what kind of custom view you have and the requirement for programmatic selection?

My extension displays a tree outline of the source code in the currently active editor. Ideally moving your cursor would select the appropriate code part (class, method etc.) in the sidebar.

I would also like to have this ability in GitLens too. Searching for a commit or to jump from a quick pick to the custom view

I think this might be a duplicate of #28338 that I did not initially find.

Thanks for finding the duplicate :)


Updates to fix SurfaceMagnetism orientation

Overview
This change fixes a faulty orientation setting in SurfaceMagnetism as well as provides clearer naming & documentation.
Fixes:

The Blended mode for OrientationMode in SurfaceMagnetism is supposed to blend rotation input calculated via the Tracked Transform and the normal at the surface hit point. The code was actually only blending between the current model rotation and the tracked transform rotation. And thus, the OrientationBlend property had no impact what so ever.

Furthermore, the original OrientationMode Vertical in documentation is supposed to face the tracked transform (i.e user etc) but actually faced along the surface normal.

To simplify implementation, the property KeepOrientationVertical was added to give user's more control for their chosen OrientationMode (see related bug #4800 )

OrientationMode keeps original values but renamed to be more accurate.

Updated SurfaceMagnetismInspector to hide OrientationBlend if not in Blended Mode and to hide both that and KeepOrientationVertical if OrientionMode is None

All related tooltip/summaries are updated to be both clearer & accurate

Solver documentation page has been updated accordingly

Added public properties to Solver for LerpTime etc

Updated SolverTests to set *LerpTime to 0.0 so we can make test run much faster

Changes

Fixes: #4800

Verification
All tests pass
SolverExample scene works as expected

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):
git fetch origin pull/{PR_ID}/head:name_of_local_branch
git checkout name_of_local_branch

/azp run

/azp run stabilization_pr


docs: document process for updating pom.xml versions

I intend on making the same change to oauth and api, but figured I'd just send out one CL for now in order to codereview phrasing in only one place (I will use this as a template for the other repos).

It might also be worthwhile to add a RELEASING.md similar to google-cloud-java, google-auth-library-java

I'd really like that, but I don't think we can, since it is 99% internal work.
That said, I am building a RELEASING.md internally.


[bug] building tauri app with cache fails with failed to read plugin permissions: failed to read file: The system cannot find the file specified. (os error 2) on windows

Describe the bug
building tauri app with cache fails with failed to read plugin permissions: failed to read file: The system cannot find the file specified. (os error 2) on windows.
This is because tauri uses : in permission file path, which will not be copied or archived in normal way.
Reproduction

create tauri v2 app
npm run tauri build
archive target folder and restore
npm run tauri build again

Expected behavior
it works
Full tauri info output
[✔] Environment
    - OS: Windows 10.0.22631 X64
    ✔ WebView2: 126.0.2592.113
    ✔ MSVC: Visual Studio Community 2022
    ✔ rustc: 1.80.0 (051478957 2024-07-21)
    ✔ cargo: 1.80.0 (376290515 2024-07-16)
    ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 20.15.0
    - pnpm: 9.4.0
    - npm: 10.7.0

[-] Packages
    - tauri [RUST]: 2.0.0-rc.0
    - tauri-build [RUST]: 2.0.0-rc.0
    - wry [RUST]: 0.41.0
    - tao [RUST]: 0.28.1
    - tauri-cli [RUST]: 1.5.14
    - @tauri-apps/api [NPM]: 2.0.0-rc.0
    - @tauri-apps/cli [NPM]: 2.0.0-rc.0

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: out
    - devUrl: http://localhost:3030/
    - framework: React (Next.js)
    - bundler: Webpack

Stack trace
No response
Additional context
Same issue as #9477 but with tauri-core:webview-permission-files

Experienced this same thing after copying a Tauri project - quick fix was to delete target/.


Fix crash assigning script to a Resource

We were dereferencing the wrong identifier, which could be NULL.
Fixes #19289, supersedes and closes #20985.

Nothing to cherry-pick, the bug was introduced after 3.0.x.


[FEATURE] Central place to configure array list visibilities, themes for the config gui

the feature template looks more like a bug template lol
anyways, instead of chosing which modules are visible in arraylist inside every module's config with visible and hidden stuff
make a new module for arraylist (sepratate arraylist from HUD) and add settings and options for which modules are shows like in the Notfication module, also make PB arraylist not conflict with normal arraylist
Another suggestion is to add a Theme to Config-GUI so ppl can get other's overall renders and hud without changing their entire config or copying visual settings 1 by 1
+config theme load ZaneCC as a command for example

Another thing that came into my mind, make it so when u bind a module to "0" it resets its bind

You know you can reset a bind with the Delete key?

The delete key doesnt delete bind it just binds modules to it

You know you can reset a bind with the Delete key?

The delete key doesnt delete bind it just binds modules to it

keyboard issue

Zane2b2t
Zane 2b2T

lolllll

I still need the theme thing :sob:
switching texturepacks and then having my config not matching the color of the pack is triggering


Better handling of multiple installed language packs

Current behavior:

Install several language packs.
Have an update install itself automatically.
Start VSCode.
See one toast for every installed language.

Desired behavior:
4. If multiple language packs are installed, show a toast with a button that brings up the language selection quick pick.
Alternatively, see no toasts, because I'd installed the language packs long ago and would have changed the language if I'd wanted to - but likely they were updated together with the application and so behaved as though they were being installed for the first time.

/duplicate https://github.com/microsoft/vscode/issues/139151
merging with that one since they're fixed in the same part of the code


Beyond TAML: Custom scanning + serialization handlers?

Referencing this conversation, I would like to discuss ways in which the asset system can be made more flexible. The project I'm working on references an external model library with >10K individual components, which contain their own metadata, and in some cases embed each-other as sub-components.
I would love to be able to use the existing asset system to scan, query, and manage this model library, but it currently expects that all assets are serialized and deserialized as TAML. Being able to mark certain directories to be scanned using a custom serialization/deserialization interface would be incredibly helpful.
Additionally, from reading the documentation + code, it appears as though everything ends up going into the global StringTable, and I'm fairly concerned about the performance impact of that many entries, the majority of which will never actually be loaded for a given game instance (but which the AssetManager is still responsible for tracking).
Given that some work is already planned for the asset system for 4.0, and I have to think other people could put this flexibility to creative use, I thought I should discuss possible improvements here to see if there was a consensus around how it should be implemented.

When managing all your various components in the model library, would you utilize the models separately, or are they grouped together, etc?
Mostly just trying to figure how we'd best manage the assets like that. The asset system is useful because it has the module and asset databases to track everything, so utilizing an asset is as easy as having the right type, and assigning it to the field(like shapeName) via moduleName:assetName skipping out all the hardcoded pathing stuff.
If there were to be a custom serialization path, it'd still need to at least populate into the module/asset databases for utilization in the system. That said, I hadn't tried 10k+ assets yet. I could write up a script to generate random assets in a tester module and see at what point, if any, the system begins to choke. Given that it's largely just simple quieries and accessing string fields, I really don't think the overhead is enough to cripple the system(especially because it's all done in the engine-side, the script stuff is just to browse the assets and stuff).
So I'd say the first step is the above script to try and see if there's a breaking point where the system bogs down, and then we can go from there figuring if we need an optimized-for-large solution of asset management.

Okay, so to be a little bit more concrete, I'm working with LDRAW models.
The model library is organized with a standard hierarchy (Primitives, Subparts, Parts, Submodels, Models), and models at the higher levels in the hierarchy are composed of lower-level models, so the load-by-name functionality is pretty useful. Primitives and Subparts map pretty well to the existing "Internal" asset functionality, in that it's pretty rare that end-users would want to work with them directly. Each model also specifies a name, and optionally, categories and keywords, which map pretty well to the existing categories and tags.
Additionally, there's support for adding unofficial parts, essentially by having multiple search paths, so on my end, I'm going to treat "models installed on the client" and "models available from the server" as different things, but use a Merkle tree to treat the server parts as a delta on the existing client library.
Besides this, there are a handful of standalone files that specify things like the material palette for the whole library, and defining which parts should be part of the character editor.
The big challenges from my perspective are having custom serialization/deserialization (The current TAML class would probably need to be made to conform to some interface, or use nasty compile-time SFINAE tricks), and figuring out how to forward asset lookups in the server module to assets available in the client module, preferably without loading everything in memory twice.
I agree that benchmarking the database performance on larger asset libraries before making any preemptive optimizations is a good idea.

Update: it looks like the main entry points that need to be preserved across uses in the asset manager are parse, read, and write.  read is templated, and presumably custom (de)serialization handlers would have the freedom to only provide specializations for asset classes they supported (though this will definitely require some SFINAE nastiness, since you can't have virtual templates). write should be pretty straightforward to move into a parent interface, but parse would require us to also generalize TamlVisitor, which sounds like a bag of cats, or wrap the uses in a higher-level interface.
Thoughts?

Probably not a bad approach.
The TAML stuff was definitely designed towards supporting different serialization formats(it supports XML, JSON and a Binary format out of the gate, after all), so doing up a new custom one wouldn't be a stretch.
As you said though, the thing that'd need the most poking would be the Visitor stuff. I need to touch on it some anyways because some of the functionality you're supposed to have access to(ability to poll your assets to update references easily, etc) are kinda weird or obfuscated, which needs correcting. So if we can plot a good generalized wrap for it, it'd be a good time for it.

So here's a thought: we could just require that all (de)serialization formats produce an AST that can be walked by the existing TAML Visitor classes, and then just read/write would need to be mucked with.

Actually, I've been stewing on this for the last couple hours, and I think I have a coherent proposal.

(As with my previous comment) all persistence plugins be implemented in the same way as the existing XML/JSON/Binary options.
Have a script mechanism to choose the correct plugin for a given file (right now it appears that a single mFormatMode is used by all I/O for a given a Taml instance, and only one Taml object is associated with a given AssetManger instance.
Extend the scoping mechanism used by modules (and the current overrideExistingObjects flag), to support a more nuanced scoping mechanism with support for nested scopes, and four distinct nesting modes. The default should be simply to complain about duplicate names, the second should be name shadowing, the third closures (i.e. names are captured from outside scope and can be reassigned in both contexts), and the last should be a lazy copy-on-write init-from mode, where some subset of name bindings are linked from the old scope but subsequent overrides of a name will only update references to it in the new scope (but not the old). I have concrete use-cases in mind for each of the 4, which I can go over if you're interested.
Allow files to define composite assets, which can either splice multiple assets into the containing scope, or define a child scope and a root asset that links into that child scope.

I've started a branch in my own repo with some of the infrastructure to support this: https://github.com/elfprince13/Torque3D/commit/b35713e5b6c920a46b685281aa5579e12dba648c
Any feedback before I continue moving forward? This is going to require modifying AssetId's slightly so that they contain explicit scope metadata instead of simply a module name.

The highlights you had seem to be pretty good sounding from the basic writeup there.
How are you thinking the 'explicit scope metadata' will be formatted for the AssetID if it's not going to just be the ModuleName:AssetName?

For serialization purposes we should be able to maintain backwards
compatibility with any existing asset definition files, but internally the
type storing asset ids will need to have a pointer to the defining scope.
Explicit scopes should be able to be serialized and deserialized as normal,
and anonymous/nested scopes will be handled by the plugins that read and
write files that need them. This could probably be used to make TAML
slightly more concise and expressive down the road, but doesn't need to
have immediate implications.
On Mon, Mar 13, 2017 at 3:07 AM Areloch<EMAIL_ADDRESS>wrote:

The highlights you had seem to be pretty good sounding from the basic
writeup there.
How are you thinking the 'explicit scope metadata' will be formatted for
the AssetID if it's not going to just be the ModuleName:AssetName?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GarageGames/Torque3D/issues/1960#issuecomment-286029977,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACk_KX1Df-BR1Dk3-jO_iPOdYb4gAzHrks5rlOshgaJpZM4MS9Wq
.

--
~Thomas


fix(ili9341): fix invert kwarg

Prior to this commit, the ili9341 class __init__ method would raise
a KeyError exception if invert==True. The issue was that the
following conditional did not add the required "data" key/value pair
to the init_cmds list item:
if invert:
    self.init_cmds.append({'cmd': 0x21})

In this commit, add the required "data" key/value pair to the
init_cmds list item when invert==True.

@cfobel - instead of adding an empty array, how about testing data  key existence, like we do with delay, when sending the initialization commands?
https://github.com/littlevgl/lv_binding_micropython/blob/3821abcacd7cd4e9a2586341d194f72be432c3c1/driver/esp32/ili9341.py#L290-L296

@amirgon , thanks for the suggestion. I've added a commit to apply your suggested changes.

Merged. Thanks you!


Removed sample packing

Main Changes Made

Buffer as List of Pages:

The buffer is now a list where each element is a list of token IDs from a single page.

Batch Size Always 1:

The __iter__ and __next__ methods now yield one page at a time, wrapped in a tensor with an added dimension to simulate batch size 1.

Padding:

If a page doesn't have enough tokens to fill sequence_length, it is padded with the tokenizer's pad token.

Detailed Explanation

Initialization:

In the __init__ method, the buffer is initialized as an empty list, and _fetch_data_to_buffer is called to pre-fetch data if num_pages is specified.

Data Fetching Methods:

_fetch_data_to_buffer, fetch_data_for_pages, and _fetch_data_for_page are modified to store tokenized data from each page as a separate list within the buffer.

Iteration:

The __iter__ and __next__ methods now yield a single page worth of data at a time, ensuring each page is padded to the required sequence_length if necessary.

Usage Example
tokenizer = AutoTokenizer.from_pretrained("gpt2")
# Display the padding and EOS token IDs
pad_token_id = tokenizer.eos_token_id  # GPT-2 does not have a padding token, use EOS token
eos_token_id = tokenizer.eos_token_id

print(f"PAD token ID: {pad_token_id}")
print(f"EOS token ID: {eos_token_id}")

sequence_length = 500000
num_pages = 2

# Print other parameters
print(f"Sequence length: {sequence_length}")
print(f"Number of pages: {num_pages}")

dataset_loader = SubsetFineWebEdu2Loader(
    sequence_length=sequence_length, num_pages=num_pages, tokenizer=tokenizer
)

for i, batch in enumerate(dataset_loader):
    print(f"Batch {i + 1}:")
    print(batch)

closing after creating #146


Progress Bar

Docs:
https://shoelace.style/components/progress-bar
Source:
https://github.com/shoelace-style/shoelace/tree/next/src/components/progress-bar
Description
Standard progress bar with determinate and indeterminate states.
There is an option to show a text version of the value.
Height is customizable
Properties
Properties that are numbers will have to be overrides. FIgma doesn't have Number component properties...yet.
Value - Number
Indeterminate - Boolean
Height - Number
Show Text Label - Boolean (This is not available for indeterminate)

Might need an additional text property to show the value.?? You can, technically, put any text in the bar you want.

Dependencies
None

Had to do Indeterminate/Determinate as a Variant.


🚀 Feature: Enable greater filtering on nodes in EntityRelationsGraph

🔖 Feature description
Provide the ability to specify a custom filter on nodes when displaying an entity graph.
🎤 Context
Currently, EntityCatalogGraph provides the ability to filter nodes based upon kind and relationship. Often times, greater flexibility is needed by being able to filter on arbitrary attributes of an entity. For example, it is often desirable to display Components based upon their type.
✌ Possible Implementation
One possible implementation is to add a filter function as a property to EntityCatalogGraph that controls whether a node is rendered. While this does not prevent entities from being loaded from the server, it's seems like a fine trade-off to do any coarse filtering using kind/relation and any fine-grained filtering using the filter function.
As an alternative, applications can supply a custom renderNode function and perhaps return <div /> for nodes that it does not wish to render, however this would require forking DefaultRenderNode. (I have not yet tried this approach.) Another alternative is to fork EntityCatalogGraph entirely.
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

yes, it makes sense. Let's discuss this in a PR!

I have a similar requirement where we like to only show nodes/entities of a certain spec.type.

@vinzscam @dweber019 Thank you! As you can see linked here, I've opened a PR with the most simple implementation I can think of. Thank you for your kind consideration and I look forward to any critique of the PR.


Unable to retrieve child resources.

Details:
{
"name": "FetchError",
"message": "request to https://stgreltmineu001.blob.core.windows.net/?comp=list&include=metadata failed, reason: unable to get local issuer certificate",
"stack": "FetchError: request to https://stgreltmineu001.blob.core.windows.net/?comp=list&include=metadata failed, reason: unable to get local issuer certificate\n    at ClientRequest. (C:\Users\cc\AppData\Local\Programs\Microsoft Azure Storage Explorer\resources\app\node_modules\node-fetch\lib\index.js:1491:11)\n    at ClientRequest.emit (node:events:390:28)\n    at TLSSocket.socketErrorListener (node:_http_client:447:9)\n    at TLSSocket.emit (node:events:390:28)\n    at emitErrorNT (node:internal/streams/destroy:157:8)\n    at emitErrorCloseNT (node:internal/streams/destroy:122:3)\n    at processTicksAndRejections (node:internal/process/task_queues:83:21)",
"type": "system",
"errno": "UNABLE_TO_GET_ISSUER_CERT_LOCALLY",
"code": "UNABLE_TO_GET_ISSUER_CERT_LOCALLY"
}

@chetana-cloud can you try using system proxy setting? You can read more about it here: https://docs.microsoft.com/en-us/azure/storage/common/storage-explorer-network#use-system-proxy-preview

Closing due to lack of response. If you're still running into this problem we recommend opening an Azure support ticket via the Azure Portal. Alternatively you can open a new issue here.


Israeli phonenumber validating wrong

Hello,
I am trying to validate an Israeli input number, but the validation returns a wrong result:

+9725287 is not a valid Israeli number.
How could this be fixed please?
Omer

Actually, "5287" is a valid number. It's just that the phone number library can't distinguish between the number with and without the "".

Hello,
I am sorry, but I didn't understand your answer. "5287" is not a valid phone number in Israel.

Sorry, github markdown ate my stars. "[star]5287" is a valid number, and the library can't distinguish this from "5287" without the "[star]".

Ok I understand now, thank you!


Plugin hangs when used with UglifyJS plugin

I'm not sure how to make a minimal repro for this... but when I upgraded from extract-text-webpack-plugin 0.3.1 to 0.3.2, my webpack build started hanging at 69% 477/478 build modules.  When I downgrade this plugin back to 0.3.1, or turn off the UglifyJS plugin, it works again.
Any ideas?  Happy to collect additional information if you tell me how.
I'm using this plugin for CSS, all default options.  If it helps, my full plugin list is:

IgnorePlugin(...) (for a broken library)
NormalModuleReplacementPlugin(...) (for another broken library)
new ExtractTextPlugin("[name].css") (this is actually extracted into a variable and referenced in the css loader)
OccurenceOrderPlugin()
DedupePlugin()
AggresiveMergingPlugin()
CommonsChunkPlugin('common', 'common.js, null, 2)
UglifyJsPlugin()

Thanks!

I'm seeing this on webpack 1.10.1 and extract-text-webpack-plugin 0.8.2.


"Live" icon is gone in 0.2.24 when using clappr-level-selector

<script src="https://cdn.jsdelivr.net/clappr/0.2.24/clappr.min.js"></script>
<script src="https://cdn.jsdelivr.net/clappr.level-selector/0.1.3/level-selector.min.js"></script>

With these versions The live icon to the right of the play/pause button is gone when I activate clappr-level-selector.
I need to back to Clappr 0.2.23  and level selector 0.1.1 to have a working setup.

what playback are you using? (mp4, hls, rtmp ...)

Live HLS, google chrome browser in linux.
Same in Firefox in linux.

@cowai can you provide a test stream url?
Live indicator works with Clappr 0.2.24 + level-selector 0.1.3 in Google Chrome 47.0.2526.80 (64-bit), fedora 23

It works for me (with both rtmp and hls) using the latest versions of clappr (0.2.28) and level-selector (0.1.6).

@gfronza Could you provide with a working example?
0.2.28 and 0.1.6 doesn't work at all for me. I mean clappr doesn't load because of errors.
In the console in chrome:
Uncaught TypeError: Cannot read property '_listenId' of undefined
Uncaught TypeError: Cannot read property 'settings' of null
Test link: https://rawgit.com/cowai/48bf5cd022e05ccb0d99/raw/9f6b36ce30cf8784d091e358c6defe7704d1707d/clappr-levelselector-error.html

@leandromoreira @me-vlad
Here is an actual test where the original problem is preset (no live icon with dvr)
http://rawgit.com/cowai/8c9833bd92fdbcdf5a19/raw/38568e44abf75c55945afe5874784255d9d0400d/clappr-live-icon-with-dvr-and-levelselector-error.html

@cowai the dist files were not updated in the last release of level-selector. It was working for me because  I had compiled a version for debugging.
@leandromoreira I'll open an issue on https://github.com/clappr/clappr-level-selector-plugin

@cowai there's a new version of level-selector plugin with the updated dist files. Can you try again please?

http://rawgit.com/cowai/b14e3825604c6e612120/raw/2ce3d9d64f0b03116531b618865c65e701cbce23/clappr-live-icon-with-dvr-and-levelselector-test.html
Now it works a little better. There seem to be a race condition problem. I now get the live icon when I go back in the dvr buffer, but not at initial load.

@cowai I see, we should definitely track this issue in  clappr-level-selector-plugin. Can you open a new issue there? I'll start looking into it now though. If that's ok with you, this issue here at clappr/clappr can be closed.
In Firefox 43.0.1 (for OS X) I wasn't able to play your video. Actually the video starts playing, but after a few seconds it goes all black. This problem with the loading bar on top of the video was already addressed in the release 0.2.27 of Clappr. Are you sure you have the latest version? Anyway, you can report this in a separate issue.

@gfronza Sorry for late response. My firefox has not yet auto-updated to 43 yet (on OS X), but in in 42 the stream works perfectly.
This issue can be closed yes. Thank you and merry christmas.


MS Teams: Get-TeamGuestSettings powershell version 5.1.17858

Hi All,
I want to check with powershell if a specific team has allow external user turned on. How do i check this in powershell? If i use Get-Team I only see this info DisplayName/ Visibility / Archived/ MailNickName/ Description but no allow external users only on tenant level, but i want it on team level.
I hope to hear soon

@officedocsbot assign @yogkumgit

Hello @LindaSchaar How are you?
You have to leverage the use of another cmdlet and another module, as teams in Microsoft Teams are essentially Office 365 Groups.
For example Get-UnifiedGroup | Where-Object {$_.AllowAddGuests -eq $true}
Other than that, I don't recognize further issues with the documentation. I hope the information helps you.

Hello @get-itips ,
Thank you for the help. Yes i am fine. I will try this command.
Linda


Unhandled Exception in org.elasticsearch.spark.rdd.EsRDDWriter.write, and rdd wouldn't stop.

What kind an issue is this?
Bug report.
Issue description
I deployed a kafka to Spark-Streaming then ElasticSearch system.The system has continued to receive data from kafka, and the data stream is a uniform.
In this system during normal operation , I restarted all the ElasticSearch nodes.And then found the indexing process delay in growth , by querying the data in the ElasticSearch.
In Yarn batch management interface can see the task appeared exception, but the batch is still processing state , and this state continues for several days. And under normal circumstances, it should be completed within a few seconds.
These tasks really throw an exception , but it does not seem to stop and release resources in my view , which is not appropriate approach.
I would like to confirm whether this is a bug, and is there a solution to stop these abnormal tasks and release resources?
Sample Configuration / Code
My Code:
import org.elasticsearch.spark._

stream.foreachRDD( rdd=>
      {
        val ep = esPath + getIndexName("") + "/meta"
        rdd.saveToEs(ep)
      }
)

Exception Messages:

Job aborted due to stage failure: Task 2 in stage 123.0 failed 4 times, most recent failure: Lost task 2.3 in stage 123.0 (TID 12345, hostname): org.elasticsearch.hadoop.rest.EsHadoopInvalidRequest: [GET] on [] failed; server[xxx.xxx.xxx.xxx:9200] returned [503|Service Unavailable:]
at org.elasticsearch.hadoop.rest.RestClient.checkResponse(RestClient.java:467)
at org.elasticsearch.hadoop.rest.RestClient.execute(RestClient.java:425)
at org.elasticsearch.hadoop.rest.RestClient.execute(RestClient.java:403)
at org.elasticsearch.hadoop.rest.RestClient.execute(RestClient.java:407)
at org.elasticsearch.hadoop.rest.RestClient.get(RestClient.java:114)
at org.elasticsearch.hadoop.rest.RestClient.esVersion(RestClient.java:553)
at org.elasticsearch.hadoop.rest.InitializationUtils.discoverEsVersion(InitializationUtils.java:177)
at org.elasticsearch.hadoop.rest.RestService.createWriter(RestService.java:379)
at org.elasticsearch.spark.rdd.EsRDDWriter.write(EsRDDWriter.scala:40)
at org.elasticsearch.spark.rdd.EsSpark$$anonfun$saveToEs$1.apply(EsSpark.scala:67)
at org.elasticsearch.spark.rdd.EsSpark$$anonfun$saveToEs$1.apply(EsSpark.scala:67)
```

and other:

Job aborted due to stage failure: Task 0 in stage 33.0 failed 4 times, most recent failure: Lost task 0.3 in stage 33.0 (TID 4171, hostname): org.elasticsearch.hadoop.rest.EsHadoopNoNodesLeftException: Connection error (check network and/or proxy settings)- all nodes failed; tried [[xxx.xxx.xx.xx:9200]]
at org.elasticsearch.hadoop.rest.NetworkClient.execute(NetworkClient.java:142)
at org.elasticsearch.hadoop.rest.RestClient.execute(RestClient.java:423)
at org.elasticsearch.hadoop.rest.RestClient.execute(RestClient.java:403)
at org.elasticsearch.hadoop.rest.RestClient.execute(RestClient.java:407)
at org.elasticsearch.hadoop.rest.RestClient.get(RestClient.java:114)
at org.elasticsearch.hadoop.rest.RestClient.esVersion(RestClient.java:553)
at org.elasticsearch.hadoop.rest.InitializationUtils.discoverEsVersion(InitializationUtils.java:177)
at org.elasticsearch.hadoop.rest.RestService.createWriter(RestService.java:379)
at org.elasticsearch.spark.rdd.EsRDDWriter.write(EsRDDWriter.scala:40)
at org.elasticsearch.spark.rdd.EsSpark$$anonfun$saveToEs$1.apply(EsSpark.scala:67)
at org.elasticsearch.spark.rdd.EsSpark$$anonfun$saveToEs$1.apply(EsSpark.scala:67)
...

and so on.
#suspected bug location

elasticsearch-hadoop-master\spark\core\main\scala\org\elasticsearch\spark\rdd\EsRDDWriter.scala

line 41:
val writer = RestService.createWriter(settings, taskContext.partitionId, -1, log)
Is there no try-catch for handling exceptions?
Version Info
Java        :  1.8.0_51
Hadoop/Spark:  spark-streaming-xxx_2.10-1.3.0
ES-Hadoop   :  elasticsearch-spark_2.10-2.2.0
ES          :  elasticsearch-1.7.1

Errors that can be handled are caught, those that cannot are bubbling up.
In your case it looks the issue is the usage of Spark Streaming - that is, for every micro-batch you end up trying to save the RDD which spawns a job.
However it looks like ES is falling behind and not being responsive any more and thus every call to it ends up timing out or with a 503, even for basic things such as discovering the version.
Since your stream keeps on going:
stream.foreachRDD( rdd=>
      {
        val ep = esPath + getIndexName("") + "/meta"
        rdd.saveToEs(ep)
      }

each rdd.saveToEs keeps throwing exceptions yet keeps on running.

These tasks really throw an exception , but it does not seem to stop and release resources in my view , which is not appropriate approach.

What resources in ES-Hadoop are you referring to? ES-Hadoop cannot even initialize - in fact it hasn't even allocated any resources...

One thing to add, the DStream support could be improved since each rdd call ends up creating a full blown job which is expensive (as mentioned here).
Since Spark 2.0 should be released soon, I'm aiming for that to revise the streaming support.

Since there hasn't been any update on this issue, I'm closing it down. If the issue still persists, please open a new one (and potentially link this as well).
Cheers


Mac wallet fails to open properly

When attempting to install the wallet on macbook pro, the wallet fails to open.   After multiple tries, it does.

me too

Can you solve this please?

Same for me

V<IP_ADDRESS> and V<IP_ADDRESS> not working

I get the feeling they aren't gonna fix this. Two months and counting, and not even an official response?

Many thanks for your help Condominium ghost team !

Hi, anyone have resolved this one?

we just update for mac wallet


Fixing steps per degree

Reviewed and documented microsteps management in Mount and related classes.

Some rationalization of driver configuration & calculation code in Mount.
Identified issue with switching of microstep configuration between slew/track/guide that results in incorrect position() readings. Forced single microstep values for all three drivers to ensure correct behavior, but at possible loss of fine guiding accuracy.
Intention is to resolve this through refactoring into HAL such that an acccurate position () value can be maintained despite dynamic microstep switching.
Added validation of all known system configurations and required pin assignments into Configuration_adv.hpp
Possible breaking change for local configurations: Renamed DRIVER_TYPE_GENERIC to DRIVER_TYPE_A4988_GENERIC

My github workflow needs some work :disappointed:. I have added a new PR that correctly merges the "fixing-steps-per-degree" and "new-epromstore" into develop without conflicts. You may want to decline this one.


Please don't use _ to prefix private methods

In NativeUtils.java some private methods are prefixed with _. While prefixes in general are a matter of personal taste I do think it's important for Couchbase to be consistent. This pattern isn't used anywhere else. So please don't introduce it now unless you want to introduce it everywhere. Otherwise you confuse poor innocent devs like me. :)

This issue is fixed as part of moving to use couchbase-lite-java-sqlcipher instead of couchbase-lite-native.


Bump version to 0.4.0 and update README

Summary of Changes

Bumps version to 0.4.0, as two new features have been added (skuid watch and the ability to deploy/retrieve Component Packs).
Removes outdated, inaccurate warning about use of Skuid CLI on Windows
Adds docs on using the skuid watch command
Updates reference on what metadata types are supported by the CLI

Just want to say thank you for the docs!! 🙏 ⭐

@itmightbecody Thank YOU for adding the Metadata Objects reference -- super helpful. All I had to do was link to them :)


Full-screen NFT content view

Show focused-view minter NFTs full-screen w/ blacked out surroundings:
e.g. niftygateway.com

Consolidating under #226


Tets: Check FLA_LOOP_LBS to set block size

Signed-off-by: Joel Granados<EMAIL_ADDRESS>To test you simple prepend FLA_LOOP_LBS=block_size_size to your regular meson compile -C BUILD_DIR run-tests and it will change the size of the loops that we are testing

This is only valid for the non-python tests as the python ones define their own bs size within the tests.


implement glue code for query and queryRecord using pouchdb-find

Usage:
MyModel.query({selector: { name: "Mario" }, sort: ["name"]})
MyModel.query({selector: {debut: {$gte: 1990}})
MyModel.query({selector: { series: "Mario" }, sort: [{series: "desc"}, {debut: "desc"}]})
MyModel.queryRecord({selector: { name: "Mario" }})

@BernardTolosajr and @nolanlawson, can I get an update on the status of this PR please. I'm doing a tidy-up pass through our PRs.

I'm not really maintaining ember-pouch anymore because of a lack of time. As for pouchdb-find compatibility with relational-pouch/ember-pouch I'd say I'm very skeptical that it could work well although this PR looks to me like about the best possible way to do it.
My only major feedback is that I had kind of hoped pouchdb-find functionality could be rolled into relational-pouch rather than ember-pouch, but as I said I basically have zero time for this project anymore, so my opinion probably matters very little at this point. 😅

@BernardTolosajr I think that @nolanlawson raises a good point here. This functionality probably belongs in relational-pouch. Are you at all interested in adding it there? @nolanlawson are there many users of relational-pouch outside ember-pouch? @broerse what do you think about adding this functionality into ember-pouch?

@aexmachina Sure, ill check it.

@BernardTolosajr @aexmachina I think because ember-pouch is the "interface" for ember-data this functionality needs to be in this module.  If pouchdb-find is merged into relational-pouch or something ember-pouch still needs to facilitate this. So perhaps lets merge this.

@nolanlawson are there many users of relational-pouch outside ember-pouch?

@aexmachina npm says 325 downloads in the past month for relational-pouch vs 866 for ember-pouch (not even sure how that's possible? maybe transitive deps aren't counted?) but yeah, corresponds roughly to my feeling, which is that ember-pouch is about 3x more popular than relational-pouch.
In any case, my goal with relational-pouch was to isolate the "pouch-y" stuff into that repo, and the "ember-y" stuff into this repo. In my mind, pouchdb-find falls squarely in the "pouch-y" part, hence my comment.
OTOH maybe it makes sense to have ember-pouch just directly depend on relational-pouch and pouchdb-find. I'm fine with that too, if folks feel that it solves a real problem and isn't an unwieldy maintenance burden.

@BernardTolosajr I like to merge this. Can you fix the conflicts?

@broerse fixed conflicts.

@BernardTolosajr 👍  I really like what you did but can we change selector to filter to be closer to the JSON::API Spec and make it easier for people to change adapters as they need?

@BernardTolosajr I also think changing selector to filter is better.

@fsmanuel Thanks! yup filter is better. @broerse :+1:

@BernardTolosajr @aexmachina Good catch. Fix this in a new PR. Add test?

@broerse :thumbsup: ill submit a new PR.

@aexmachina @broerse  upon initial testing for missing id found out that pouchdb auto-generate the _id if its not provided.

@aexmachina @BernardTolosajr Nice! I wil release 4.0.0 then. Thanks!

@BernardTolosajr okay cool, but I still think that the mapper should be updated. Also, upgrading to v4.0.0 breaks the app because bower_components/pouchdb-find/dist/pouchdb.find.js is not installed. Maybe we should include upgrade instructions to the changelog?

@aexmachina no it was some typo junk.  v4.0.1  fixes this

I'm running v4.0.1 and ember serve fails unless I add pouchdb-find to bower.json.

@aexmachina but you did not run ember install ember-pouch ;-)

@broerse okay, that is the right way to upgrade an ember addon isn't it :)


[M2] Add 'Link Bank Account' in Settings and setup pre-flow

Designs here: https://www.figma.com/file/DAcpLsmPdeHT9Gt4eXhtWe/Finclusive-(US)?node-id=681%3A12616

This work is actually already defined in https://app.zenhub.com/workspaces/acquisition-squad-sprint-board-6010683afabec1001a090887/issues/valora-inc/wallet/1372 and https://app.zenhub.com/workspaces/acquisition-squad-sprint-board-6010683afabec1001a090887/issues/valora-inc/wallet/1373


Image does not exist

While trying to run examples/docker-compose.yml I got this error message:
Pulling ot-sample-app (mxiamxia/aws-otel-collector-java-sample-app:0.4.0)...
ERROR: pull access denied for mxiamxia/aws-otel-collector-java-sample-app, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

duplicate issue in the collector repo.

duplicate issue in the collector repo.


⚠ Bofrost.be has degraded performance

In ac6603e, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 901 ms

Resolved: Bofrost.be performance has improved in 1ad26ec after 6 minutes.


proposal: doc: add "exp" build tag convention

What did you see today?
During the discussion of #34409, it became clear that stronger conventions around signalling instability should be used when writing Go. Currently there are many ways to signal to users that a given symbol is unstable.
// Experimental: ...
package analysis // import "golang.org/x/tools/go/analysis"

type SuggestedFix struct {
        // ... all fields elided ...
}
    A SuggestedFix is a code change associated with a Diagnostic that a user can
    choose to apply to their code. Usually the SuggestedFix is meant to fix the
    issue flagged by the diagnostic. TextEdits for a SuggestedFix should not
    overlap. TextEdits for a SuggestedFix should not contain edits for other
    packages. Experimental: This API is experimental and may change in the
    future.

EXPERIMENTAL
package js // import "syscall/js"

Package js gives access to the WebAssembly host environment when using the
js/wasm architecture. Its API is based on JavaScript semantics.

This package is EXPERIMENTAL. Its current scope is only to allow tests to
run, but not yet to provide a comprehensive API for users. It is exempt from
the Go compatibility promise.

ExperimentalFoo
On 2019-11-13T18:49:13Z Russ Cox <@rsc> wrote:

[P]ut the name into the defined symbols, like "mypkg.UnstableFoo", like we did for types like testing.InternalBenchmark (before internal directories).

What would you like to see?
Experimental symbols should be gated by the exp build flag: e.g.
// +build exp,js,wasm

// Package js ...
package js

Using build flags requires users opt in to such instability symbols. It gives a transparent forward compatible upgrade path: simply remove the build tag and users continuing to provid it will still consume the symbol. It allows authors to release features without cluttering their external api, since these experimental symbols will simply not show up. Finally, it is pure convention, so it does not require any changes to the language, and exp is not a magical build tag to the toolchain. This flag is also granular and can be used for a whole package, or just some symbols.
What did not work?
Scope
This proposal is specific to alpha, beta, pre-release, or experimental features that are not intended for general consumption. It does not work well with other use cases described in #34409, custom compatibility and internal interfaces.
Prior art
None of the current approaches clearly signal to users that the symbols are experimental, and as noted in #34409 Experimental prefixes are cumbersome and do not have a clean graduation path to stability.

Closing as duplicate of #34409, since both have the same goal and we should have one mechanism, not two.

@rsc Can we then retitle #34409, since the current title says it's only about a comment convention.


-list-tags does not produce expected output

Describe the Issue
ansible-playbook site.yml –list-tags produces an error
Expected Behavior
According to the getting started page this should list all available tags
Actual Behavior
➜  RHEL8-CIS git:(devel) ✗ ansible-playbook site.yml –list-tags [DEPRECATION WARNING]: COMMAND_WARNINGS option, the command warnings feature is being removed. This feature will be removed from ansible-core in version 2.14. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg. ERROR! the playbook: –list-tags could not be found
Control(s) Affected
What controls are being affected by the issue
Environment (please complete the following information):

Ansible Version: ansible [core 2.11.3]
Host Python Version: Python 3.9.7

Additional Notes
Anything additional goes here
Possible Solution
Enter a suggested fix here

Hi @adds68
Thank you for taking the time to feedback on this repository. Apologies it has taken so longer to respond to your queries than normal.

Looking at the issue with listing tags.

I can see in the command that you have run it is complaining about not finding a playbook called --list-tags. By moving around the order of list-tags and the site.yml this does produce output and I am able to see the following (below).
I am hoping that helps with your issue if not, could you provide more information on what is missing, I haven't gone through every tag but if there is something you expect please let us know so we can rectify any issue.
Best regards
uk-bolly
( I have left warning for clarity)
ansible-playbook --list-tags site.yml
[DEPRECATION WARNING]: COMMAND_WARNINGS option, the command warnings feature is being removed. This feature will be removed from ansible-core in version 2.14. Deprecation
warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
[WARNING]: No inventory was parsed, only implicit localhost is available
[WARNING]: provided hosts list is empty, only localhost is available.


[CW-22233] feat(kas): support different script type

Checklist:

README.md includes:

[ ] The details of signing data and transaction data, this includes parameters.
[ ] Official docs or white paper.
[ ] Website or api can query assets and broadcast transaction.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Task linked: CW-22233 調整 sdk scriptPublicKey、address、getArgument 相關邏輯


Total epoch rewards positive, but total money less?

Anybody come across these kinds of results?

This run starts with a 10,000 balance, which is default. The total rewards is positive, suggesting it's profiting, but the total money is less than the initial 10,000. Why might that be?
Looking at the logic for both, I can't figure out why that's happening. When we "buy" a stock:
                if action == 1 and starting_money >= self.trend[t] and t < (len(self.trend) - self.half_window):
                    inventory.append(self.trend[t])
                    starting_money -= self.trend[t]

...and when we "sell" a stock:
                elif action == 2 and len(inventory):
                    bought_price = inventory.pop(0)
                    total_profit += self.trend[t] - bought_price
                    starting_money += self.trend[t]

So the total profit is just the trade's profit, which can either be positive or negative, and it just gets added to the recurrent total profit. The starting money gets subtracted from on the buy, and added to on the sell, so they SHOULD match, but they don't?
When the total money after the epoch is greater than 10,000, the total reward matches, i.e. if the final total money is 10,230, the total reward will say 230, but that's not true if the total money is less than 10,000.
You can look at any of the agent codes, it's all the same, but I'm looking specifically at 4.policy-gradient-agent.ipynb for this example. Maybe it's something blatantly obvious, but I sure don't see it.

How about now?


When you say "chuck line target1 between target2" a single empty line sticks around.

All lines between target1 and target2 should be removed.
In my gif example below “ace” is }.

Heyo, taking a look at this one. @RonWalker22 — thanks for submitting the bug. The .gif is super helpful. It looks like Cursorless is pulling in the correct context here. The selection for the target within the Delete.run command has multiple lines(in my example, I'm trying to delete two lines).
targets.at(0).selection.selection.start
{_line: 7, _character: 0}
targets.at(0).selection.selection.end
{_line: 8, _character: 0}

I thought that it had something to do with the line below having no characters, but the gif below shows that that even with text, deleting 2 lines preserves the one where the cursor is currently.

I need to think about what a good next step would be. This seems to be a delete specific problem, ie. if I were to lines between, I'd want to select only those lines and not any newline characters. However, if I were to want to delete, I think the fix is likely to extend the select to the line below.
I'm looking through the VSCode API to see if we should be using a special API for delete vs. update.

The problem in essence with this is that the delete/chuck command depends on leading and trailing delimiter ranges. These ranges contains the new lines, commas and so on that needs to be removed together with the target. The problem with the between modifier is that it completely discards both the start and end targets and we are now left with just a raw range in between that has no understanding of the new line delimiter that should be discarded.

@AndreasArvidsson — thanks a bunch for the context. I'm looking through the code and I think the piece you're referencing is here in the compound_targets.py file?
Specifically these lines:
def is_anchor_included(range_connective: str):
    return range_connective not in ["rangeExclusive", "rangeExcludingStart"]

def is_active_included(range_connective: str):
    return range_connective not in ["rangeExclusive", "rangeExcludingEnd"]

Here's a few questions:

I think what I hear you saying as well is that the type of action should perhaps have some influence on how we handle a selection?
What do you think a prudent "first stab" at this might be?

That's the talon side of it but the issue is in the vscode extension.

Definitely the selection you want to remove is not the same that you want to for example copy or select. We already do this in different ways in the extension
I think this one will solve itself when we have the new object oriented targets so I would not touch this one for now at all


error raised during websocket heartbeat after bot run over 10 hours

error raised during websocket heartbeat
Traceback (most recent call last):
File "khl\receiver.py", line 59, in heartbeat
File "aiohttp\client_ws.py", line 165, in send_json
File "aiohttp\client_ws.py", line 151, in send_str
File "aiohttp\http_websocket.py", line 690, in send
File "aiohttp\http_websocket.py", line 601, in _send_frame
ConnectionResetError: Cannot write to closing transport

the websocket connection is broken
khl websocket is not high availability ensured, try webhook?


Update adding-assets.md

Update docs on adding assets to cover non-Webpack/runtime assets. Related to https://github.com/electron-react-boilerplate/electron-react-boilerplate/issues/2526
Closes #132

@TODO make sure it's working in packaged bundle


Minor fixes

run all TT tests ordered (the tests per profile were already sorted, but now also the profiles are processed in sorted manner) (fixes #68)
add debug to Test::quattor::command_history_ok to help investigate #67

@jrha i took the liberty to add this to 15.12. It does not add features, nor fixes any bugs, but is a big help for debugging failing tests

LGTM


Use Destructuring Assignment to Assign Variables from Nested Objects

Describe your problem and - if possible - how to reproduce it
Strict requirement for the solution, requiring only max: maxOfTomorrow.
This became more of an issue when the previous lesson was equally if not more confusing to understand.
Side issue: The console messages are confusing. There are two parts:

When there is a syntax error or the likes, Run Tests doesn't work. First reaction was to refresh page and see if things work. So I think a message that there is a syntax error would be helpful.
Error message like nested destructuring was used was confusing to understand. My first thought was, is this an error or not when it first appear on the console, because I usually pass in one go. Second thought was, should nested destructuring be used of not. I think better wording should be used like using 'not' to indicate what not to do.

, especially when the previous lesson was equally if not more confusing.
Add a Link to the page with the problem

const LOCAL_FORECAST = {
  today: { min: 72, max: 83 },
  tomorrow: { min: 73.3, max: 84.6 }
};

function getMaxOfTmrw(forecast) {
  "use strict";
  // change code below this line
  const {tomorrow: {min, max:maxOfTomorrow}} = forecast; // change this line
  // change code above this line
  return maxOfTomorrow;
}

console.log(getMaxOfTmrw(LOCAL_FORECAST)); // should be 84.6

nested destructuring was used
Tell us about your browser and operating system
User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36.
Link to the challenge:
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects
If possible, add a screenshot here

It works this way.
`const LOCAL_FORECAST = {
today: { min: 72, max: 83 },
tomorrow: { min: 73.3, max: 84.6 }
};
function getMaxOfTmrw(forecast) {
"use strict";
// change code below this line
const { tomorrow : {max : maxOfTomorrow}} = forecast; // change this line
// change code above this line
return maxOfTomorrow;
}
console.log(getMaxOfTmrw(LOCAL_FORECAST)); // should be 84.6`

Being worked on in #34257


Implemented Genre GET action

Implemented Genre as enum in Book DAO, JPA, Repo, Service and control…ler, able to successfully execute GET request.

Looks good!