[gtk] Build error

Host Environment

OS: [Linux Ubuntu 20.04]
Compiler: gcc 9.3.0 "cc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0"

To Reproduce
./vcpkg install gtk:x64-linux
Failure logs
Run-time dependency xrandr found: NO (tried pkgconfig and cmake)
../src/a0ae733b32-18e1e2c397.clean/meson.build:494:2: ERROR: Dependency "xrandr" not found, tried pkgconfig and cmake
Call Stack (most recent call first):
scripts/cmake/vcpkg_configure_meson.cmake:491 (vcpkg_execute_required_process)
ports/gtk/portfile.cmake:40 (vcpkg_configure_meson)
scripts/ports.cmake:142 (include)
Additional context
Installs fine on Windows. GTK is needed for installing OpenCV4 on Linux.

Can you confirm your vcpkg is latest?
The feature x11-backend is disabled now.

Yes vcpkg is latest

Can you please provide the logs in VCPKG_ROOT\buildtrees\gtk\x86-windows-dbg\meson-logs?
Thanks.

Thank you for helping me solve this issue. I've attached meson-logs and 2 other log files that vcpkg suggested looking at.
meson-log.txt
config-x64-linux-dbg-out.log
get-cmake-vars-x64-linux-dbg-err.log

I believe I have a very similar issue with the latest vcpkg version (cloned 1 hour ago). I receive the following error during build:
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
    Command failed: "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/Common7/IDE/CommMicrosoft/CMake/Ninja/ninja.exe" install -v
    Working Directory: C:/Users/a/Projects/archimedes-ui/vcpkg/buildtrees/gtk/x86-windows-dbg
    Error code: 1
    See logs for more information:
      C:\Users\a\Projects\archimedes-ui\vcpkg\buildtrees\gtk\package-x86-windows-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_install_meson.cmake:53 (vcpkg_execute_required_process)
  ports/gtk/portfile.cmake:73 (vcpkg_install_meson)
...
  package: gtk[core]:x86-windows -> 4.4.0#1
    vcpkg-tool version: 2021-12-09-724cea8b33cbf06c645f5095fa29773697da9761
    vcpkg-scripts version: bba8794b8 2022-01-14 (3 days ago)

I have attached my log files as well:
vcpkg\buildtrees\gtk\x86-windows-dbg\meson-logs
meson-log.txt
vcpkg\buildtrees\gtk
package-x86-windows-dbg-err.log

Build Options: -Dwayland-backend=false -Dx11-backend=true -Dbroadway-backend=false -Dwin32-backend=false -Dmacos-backend=false -Ddemos=false -Dbuild-examples=false -Dbuild-tests=false -Dinstall-tests=false -Dgtk_doc=false -Dman-pages=false -Dintrospection=disabled -Dmedia-ffmpeg=disabled -Dmedia-gstreamer=disabled -Dprint-cups=disabled -Dvulkan=disabled -Dcloudproviders=disabled -Dsysprof=disabled -Dtracker=disabled -Dcolord=disabled -Ddebug=true '-Dcmake_prefix_path=['"'"'/media/kevin/barracuda/Code/libraries/vcpkg/installed/x64-linux/debug'"'"','"'"'/media/kevin/barracuda/Code/libraries/vcpkg/installed/x64-linux'"'"']' -Dprefix=/media/kevin/barracuda/Code/libraries/vcpkg/packages/gtk_x64-linux/debug -Dincludedir=../include -Dlibdir=lib -Dbackend=ninja -Dbuildtype=plain -Ddefault_library=static -Dwrap_mode=nodownload '--native-file /media/kevin/barracuda/Code/libraries/vcpkg/buildtrees/gtk/meson-native-x64-linux.log' '--native-file /media/kevin/barracuda/Code/libraries/vcpkg/buildtrees/gtk/meson-native-x64-linux-debug.log'

That's weird.
Can you please provide your current vcpkg version and the install output?

vcpkg version:
kevin@raptor:~$ vcpkg --version
Vcpkg package management program version 2021-12-09-724cea8b33cbf06c645f5095fa29773697da9761

vcpkg install output:
kevin@raptor:~$ vcpkg install gtk:x64-linux
Computing installation plan...
The following packages will be built and installed:
    gtk[core]:x64-linux -> 4.4.0#1
Detecting compiler hash for triplet x64-linux...
Restored 0 packages from /home/kevin/.cache/vcpkg/archives in 115.2 us. Use --debug to see more details.
Starting package 1/1: gtk:x64-linux
Building package gtk[core]:x64-linux...
-- Using cached GNOME-gtk-f1f197e3b94a55d5cbfaae2498f991a0ae733b32.tar.gz.
-- Cleaning sources at /media/kevin/barracuda/Code/libraries/vcpkg/buildtrees/gtk/src/a0ae733b32-18e1e2c397.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /media/kevin/barracuda/Code/libraries/vcpkg/downloads/GNOME-gtk-f1f197e3b94a55d5cbfaae2498f991a0ae733b32.tar.gz
-- Applying patch 0001-build.patch
-- Applying patch 0002-windows-build.patch
-- Applying patch 0003-vs2022-rc.patch
-- Applying patch 0004-macos-build.patch
-- Using source at /media/kevin/barracuda/Code/libraries/vcpkg/buildtrees/gtk/src/a0ae733b32-18e1e2c397.clean
-- Getting CMake variables for x64-linux-dbg
-- Getting CMake variables for x64-linux-rel
-- Configuring x64-linux-dbg
-- Configuring x64-linux-dbg done
-- Configuring x64-linux-rel
-- Configuring x64-linux-rel done
-- Package x64-linux-dbg
-- Package x64-linux-rel
-- Running post install script: x64-linux-rel
-- Post install x64-linux-rel done
-- Running post install script: x64-linux-dbg
-- Post install x64-linux-dbg done
-- Fixing pkgconfig file: /media/kevin/barracuda/Code/libraries/vcpkg/packages/gtk_x64-linux/lib/pkgconfig/gtk4-unix-print.pc
-- Fixing pkgconfig file: /media/kevin/barracuda/Code/libraries/vcpkg/packages/gtk_x64-linux/lib/pkgconfig/gtk4-x11.pc
-- Fixing pkgconfig file: /media/kevin/barracuda/Code/libraries/vcpkg/packages/gtk_x64-linux/lib/pkgconfig/gtk4.pc
-- Fixing pkgconfig file: /media/kevin/barracuda/Code/libraries/vcpkg/packages/gtk_x64-linux/debug/lib/pkgconfig/gtk4-unix-print.pc
-- Fixing pkgconfig file: /media/kevin/barracuda/Code/libraries/vcpkg/packages/gtk_x64-linux/debug/lib/pkgconfig/gtk4-x11.pc
-- Fixing pkgconfig file: /media/kevin/barracuda/Code/libraries/vcpkg/packages/gtk_x64-linux/debug/lib/pkgconfig/gtk4.pc
-- Installing: /media/kevin/barracuda/Code/libraries/vcpkg/packages/gtk_x64-linux/share/gtk/copyright
-- Performing post-build validation
-- Performing post-build validation done
Stored binary cache: /home/kevin/.cache/vcpkg/archives/a8/a84ef1d273a0a71839565b7756c9edcaaee01824cd534da3482e89381c6f5e2f.zip
Installing package gtk[core]:x64-linux...
Elapsed time for package gtk:x64-linux: 1.19 min

Ahh...
https://github.com/microsoft/vcpkg/blob/7e7dad5fe20cdc085731343e0e197a7ae655555b/ports/gtk/portfile.cmake#L27

It worked. GTK successfully installed as well as OpenCV both on Linux. Thank you so much for your help.

I am getting the exact same error when trying to install gtk via vcpkg on Ubuntu 20.04 LTS, yet installing libx11-dev, libxkbcommon-x11-dev and libx11-xcb-dev via apt as JackBoosY suggested didn't solve the problem for me.

@Ilmu011 Can you please provide the failure logs?

@JackBoosY
When executing the command:
ilmu011@ilmu011-VirtualBox:~/Desktop/vcpkg$ ./vcpkg install gtk
Computing installation plan...
The following packages will be built and installed:
    gtk[core]:x64-linux -> 4.6.0
Detecting compiler hash for triplet x64-linux...
Restored 0 packages from /home/ilmu011/.cache/vcpkg/archives in 16.51 ms. Use --debug to see more details.
Starting package 1/1: gtk:x64-linux
Building package gtk[core]:x64-linux...
-- Using cached GNOME-gtk-70cb61fb7104c76a15bc6494a10e6ff1d470f6d8.tar.gz.
-- Cleaning sources at /home/ilmu011/Desktop/vcpkg/buildtrees/gtk/src/f1d470f6d8-76021d222d.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/ilmu011/Desktop/vcpkg/downloads/GNOME-gtk-70cb61fb7104c76a15bc6494a10e6ff1d470f6d8.tar.gz
-- Applying patch 0001-build.patch
-- Applying patch 0002-windows-build.patch
-- Applying patch 0004-macos-build.patch
-- Using source at /home/ilmu011/Desktop/vcpkg/buildtrees/gtk/src/f1d470f6d8-76021d222d.clean
-- Getting CMake variables for x64-linux-dbg
-- Getting CMake variables for x64-linux-rel
-- Configuring x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:128 (message):
    Command failed: /usr/bin/python3 /home/ilmu011/Desktop/vcpkg/installed/x64-linux/tools/meson/meson.py -Dwayland-backend=false -Dx11-backend=true -Dbroadway-backend=false -Dwin32-backend=false -Dmacos-backend=false -Ddemos=false -Dbuild-examples=false -Dbuild-tests=false -Dinstall-tests=false -Dgtk_doc=false -Dman-pages=false -Dintrospection=disabled -Dmedia-ffmpeg=disabled -Dmedia-gstreamer=disabled -Dprint-cups=disabled -Dvulkan=disabled -Dcloudproviders=disabled -Dsysprof=disabled -Dtracker=disabled -Dcolord=disabled --buildtype plain --backend ninja --wrap-mode nodownload --native /home/ilmu011/Desktop/vcpkg/buildtrees/gtk/meson-native-x64-linux.log --default-library static --libdir lib --native /home/ilmu011/Desktop/vcpkg/buildtrees/gtk/meson-native-x64-linux-debug.log -Ddebug=true --prefix /home/ilmu011/Desktop/vcpkg/packages/gtk_x64-linux/debug --includedir ../include -Dcmake_prefix_path=['/home/ilmu011/Desktop/vcpkg/installed/x64-linux/debug','/home/ilmu011/Desktop/vcpkg/installed/x64-linux'] /home/ilmu011/Desktop/vcpkg/buildtrees/gtk/src/f1d470f6d8-76021d222d.clean
    Working Directory: /home/ilmu011/Desktop/vcpkg/buildtrees/gtk/x64-linux-dbg
    Error code: 1
    See logs for more information:
      /home/ilmu011/Desktop/vcpkg/buildtrees/gtk/config-x64-linux-dbg-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_meson.cmake:492 (vcpkg_execute_required_process)
  ports/gtk/portfile.cmake:39 (vcpkg_configure_meson)
  scripts/ports.cmake:145 (include)

Error: Building package gtk:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `git pull` and `./vcpkg update`.
Then check for known issues at:
  https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+gtk
You can submit a new issue at:
  https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[gtk]+Build+error
including:
  package: gtk[core]:x64-linux -> 4.6.0
    vcpkg-tool version: 2022-03-09-1affd32f93b299d5a907816c328ca3ededb73a7e
    vcpkg-scripts version: af2287382 2022-03-11 (2 days ago)

Additionally, attach any relevant sections from the log files above.

Content of config-x64-linux-dbg-out.log:
WARNING: Recommend using either -Dbuildtype or -Doptimization + -Ddebug. Using both is redundant since they override each other. See: https://mesonbuild.com/Builtin-options.html#build-type-options
The Meson build system
Version: 0.60.2
Source dir: /home/ilmu011/Desktop/vcpkg/buildtrees/gtk/src/f1d470f6d8-76021d222d.clean
Build dir: /home/ilmu011/Desktop/vcpkg/buildtrees/gtk/x64-linux-dbg
Build type: native build
Project name: gtk
Project version: 4.6.0
C compiler for the host machine: /usr/bin/cc (gcc 9.4.0 "cc (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0")
C linker for the host machine: /usr/bin/cc ld.bfd 2.34
Host machine cpu family: x86_64
Host machine cpu: x86_64
Has header "crt/externs.h" : NO
Has header "dev/evdev/input.h" : NO
Has header "dlfcn.h" : YES
Has header "ftw.h" : YES
Has header "inttypes.h" : YES
Has header "linux/input.h" : YES
Has header "linux/memfd.h" : YES
Has header "locale.h" : YES
Has header "memory.h" : YES
Has header "stdint.h" : YES
Has header "stdlib.h" : YES
Has header "strings.h" : YES
Has header "string.h" : YES
Has header "sys/mman.h" : YES
Has header "sys/param.h" : YES
Has header "sys/stat.h" : YES
Has header "sys/sysinfo.h" : YES
Has header "sys/systeminfo.h" : NO
Has header "sys/time.h" : YES
Has header "sys/types.h" : YES
Has header "unistd.h" : YES
Has header "gio/gdesktopappinfo.h" : NO
Library m found: YES
Checking for function "dcgettext" with dependency -lm: YES
Checking for function "getpagesize" with dependency -lm: YES
Checking for function "getresuid" with dependency -lm: YES
Checking for function "lstat" with dependency -lm: YES
Checking for function "memfd_create" with dependency -lm: YES
Checking for function "mmap" with dependency -lm: YES
Checking for function "posix_fallocate" with dependency -lm: YES
Checking for function "_lock_file" with dependency -lm: NO
Checking for function "flockfile" with dependency -lm: YES
Checking for function "mkstemp" with dependency -lm: YES
Checking for function "mallinfo2" with dependency -lm: NO
Checking for function "sincos" with dependency -lm: YES
Checking for function "sincosf" with dependency -lm: YES
Checking if "sigsetjmp" : links: YES
Checking if "__uint128_t available" : compiles: YES
Checking for function "mlock" : YES
Checking for function "madvise" : YES
Compiler for C supports arguments -fno-strict-aliasing: YES
Compiler for C supports arguments -Wno-c++11-extensions: NO
Compiler for C supports arguments -Wno-missing-include-dirs: YES
Compiler for C supports arguments -Wno-typedef-redefinition: NO
Compiler for C supports arguments -Wduplicated-branches: YES
Compiler for C supports arguments -Wduplicated-cond: YES
Compiler for C supports arguments -Wformat=2: YES
Compiler for C supports arguments -Wformat-nonliteral: YES
Compiler for C supports arguments -Wformat-security: YES
Compiler for C supports arguments -Wignored-qualifiers: YES
Compiler for C supports arguments -Wimplicit-function-declaration: YES
Compiler for C supports arguments -Wlogical-op: YES
Compiler for C supports arguments -Wmisleading-indentation: YES
Compiler for C supports arguments -Wmissing-format-attribute: YES
Compiler for C supports arguments -Wmissing-include-dirs: YES
Compiler for C supports arguments -Wmissing-noreturn: YES
Compiler for C supports arguments -Wnested-externs: YES
Compiler for C supports arguments -Wold-style-definition: YES
Compiler for C supports arguments -Wpointer-arith: YES
Compiler for C supports arguments -Wshadow: YES
Compiler for C supports arguments -Wstrict-prototypes: YES
Compiler for C supports arguments -Wswitch-default: YES
Compiler for C supports arguments -Wswitch-enum: YES
Compiler for C supports arguments -Wundef: YES
Compiler for C supports arguments -Wuninitialized: YES
Compiler for C supports arguments -Wunused: YES
Compiler for C supports arguments -Waddress: YES
Compiler for C supports arguments -Warray-bounds: YES
Compiler for C supports arguments -Wempty-body: YES
Compiler for C supports arguments -Wimplicit: YES
Compiler for C supports arguments -Wimplicit-fallthrough: YES
Compiler for C supports arguments -Winit-self: YES
Compiler for C supports arguments -Wint-to-pointer-cast: YES
Compiler for C supports arguments -Wmain: YES
Compiler for C supports arguments -Wmissing-braces: YES
Compiler for C supports arguments -Wmissing-declarations: YES
Compiler for C supports arguments -Wmissing-prototypes: YES
Compiler for C supports arguments -Wnonnull: YES
Compiler for C supports arguments -Wpointer-to-int-cast: YES
Compiler for C supports arguments -Wredundant-decls: YES
Compiler for C supports arguments -Wreturn-type: YES
Compiler for C supports arguments -Wsequence-point: YES
Compiler for C supports arguments -Wtrigraphs: YES
Compiler for C supports arguments -Wvla: YES
Compiler for C supports arguments -Wwrite-strings: YES
Compiler for C supports arguments -Wcast-align: YES
Compiler for C supports arguments -Wnull-dereference: YES
Compiler for C supports link arguments -Wl,-Bsymbolic: YES
Compiler for C supports link arguments -Wl,-z,relro: YES
Compiler for C supports link arguments -Wl,-z,now: YES
Found pkg-config: /bin/pkg-config (0.29.1)
Run-time dependency glib-2.0 found: YES 2.70.1
Run-time dependency gobject-2.0 found: YES 2.70.1
Run-time dependency gio-unix-2.0 found: YES 2.70.1
Run-time dependency gmodule-2.0 found: YES 2.70.1
Run-time dependency cairo found: YES 1.17.4
Run-time dependency cairo-gobject found: YES 1.17.4
Run-time dependency pango found: YES 1.50.3
Run-time dependency fribidi found: YES 1.0.11
Run-time dependency pangoft2 found: YES 1.50.3
Run-time dependency pangocairo found: YES 1.50.3
Run-time dependency gdk-pixbuf-2.0 found: YES 2.42.2
Run-time dependency libpng found: YES 1.6.37
Run-time dependency libtiff-4 found: YES 4.3.0
Run-time dependency libjpeg found: YES 2.1.3
Run-time dependency epoxy found: YES 1.5.9
Run-time dependency harfbuzz found: YES 3.2.0
Run-time dependency xkbcommon found: YES 0.10.0
Run-time dependency graphene-gobject-1.0 found: YES 1.10.2
Run-time dependency iso-codes found: YES 4.4
Found CMake: /home/ilmu011/Desktop/vcpkg/downloads/tools/cmake-3.22.2-linux/cmake-3.22.2-linux-x86_64/bin/cmake (3.22.2)
Run-time dependency gi-docgen found: NO (tried pkgconfig and cmake)
Looking for a fallback subproject for the dependency gi-docgen
Automatic wrap-based subproject downloading is disabled
Subproject  gi-docgen is buildable: NO (disabling)
Dependency gi-docgen from subproject gi-docgen found: NO (subproject failed to configure)
Run-time dependency gobject-introspection-1.0 found: NO (tried pkgconfig and cmake)
Dependency tracker-sparql-3.0 skipped: feature tracker disabled
Dependency colord skipped: feature colord disabled
Run-time dependency cairo-xlib found: YES 1.17.4
Run-time dependency cairo-script-interpreter found: NO (tried pkgconfig and cmake)
Library cairo-script-interpreter found: YES
Run-time dependency xrandr found: NO (tried pkgconfig and cmake)

../src/f1d470f6d8-76021d222d.clean/meson.build:530:2: ERROR: Dependency "xrandr" not found, tried pkgconfig and cmake

A full log can be found at /home/ilmu011/Desktop/vcpkg/buildtrees/gtk/x64-linux-dbg/meson-logs/meson-log.txt

@Ilmu011 See https://github.com/microsoft/vcpkg/issues/22338#issuecomment-1008775706 if it can resolve your issue.

@JackBoosY After installing those libraries, the installation was succesful. Thanks.


_AVOID_ESFMT_BUG_WITH_COMMENTS;

Why is this getting amended inside every function?
/Stephen.

I'm sorry @maitriyogin it is most than probably an awful bug for the awful hacks I had to do. Can you provide an example of the code that is producing this bug? this for certain should never happen.

Hey there, same issue.
Here is an example (react-native):
import React, { StatusBar, View } from 'react-native'
import Router from './router'
import { Provider } from 'react-redux'
import Colors from './theme/colors'
import configureStore from './store/configureStore'
const store = configureStore()

export default class Tony extends React.Component {
  render () {
    return (
      <View style={{ flex: 1 }}>
        <StatusBar barStyle='light-content' backgroundColor={Colors.PURPLE_MAIN_DARK} />
        <Provider store={store}>
          <Router />
        </Provider>
      </View>
    )
  }
}

Results:
import React, { StatusBar, View } from 'react-native'
import Router from './router'
import { Provider } from 'react-redux'
import Colors from './theme/colors'
import configureStore from './store/configureStore'
const store = configureStore()

export default class Tony extends React.Component {
  render() {
    return (
      <View style={{ flex: 1 }}>
        <StatusBar barStyle='light-content' backgroundColor={Colors.PURPLE_MAIN_DARK} />
        <Provider store={store}>
          <Router />
        </Provider>
      </View>
    )

    ___AVOID_ESFMT_BUG_WITH_COMMENTS__
  }
}

That's weird I just ran this against the latest version of esformatter-jsx but I can't reproduce it. Can you provide your esformatter configuration?

I have the same issue here's my config.
{
  "root": true,
  "plugins": [
    "esformatter-asi",
    "esformatter-jsx",
    "esformatter-limit-linebreaks",
    "esformatter-quotes",
    "esformatter-quote-props",
    "esformatter-remove-trailing-commas"
  ],
  "LimitLineBreaks": 2,
  "quotes": {
    "type": "single"
  },
  "whiteSpace": {
    "after": {
      "FunctionName": 1,
      "FunctionReservedWord": 1,
      "MethodDefinitionName": 1
    }
  }
}

hi @trajano can you please share a snippet of the code that cause the issue? Also, is that the full config?

To fix it is just one character change.  I'll point it out

Key thing to note, I'm using esformatter-asi so that will remove the ; that are not needed.  @maitriyogin and @mmazzarolo  I am presuming you are doing the same.

@trajano that might make sense. I will add your suggestion to the regex that should fix the issue.

Pls make a release soon :+1:

Incorrectly marked the wrong issue as closed... but this is already closed and published as<EMAIL_ADDRESS>Thanks for the help @trajano

Just confirmed on https://github.com/trajano/meteor-boilerplate/tree/react I think you can close this.

nice @trajano. Thanks for your help.

NP, too bad we can't get esformatter to format it the way standard-react wants.  I had to do two rules but it's fine
"react/jsx-curly-spacing": [2, "always"],
"react/jsx-indent": 0


Authority controll - Suggest option is not working on JSPUI

Code to fix the following issue:
https://jira.duraspace.org/browse/DS-4254
Fixes #7594

Issue here:
https://jira.duraspace.org/browse/DS-4254

I resolved the merge conflict.

@tdonohue I think that the "merge conflict" was because another merged PR has already resolved the issue.
This merged PR ( #2918) has the same modification to add simple quotes to the collection parameter:
https://github.com/DSpace/DSpace/pull/2918/commits/423af4ca981a9c3fd850fd1609f7ed9dfbe0f000#diff-758a4253c8a9b9756e56c80a541358b456d780f7f3ba65a02eb37362d918c983R192
I haven't tested it but I think that the issue should be already resolved in current dspace-6_x branch.

@toniprieto : Thanks for the follow-up. Yes, it appears your analysis is correct & I also see those fixes already applied to dspace-6.x here:  https://github.com/DSpace/DSpace/blob/dspace-6_x/dspace-jspui/src/main/webapp/submit/edit-metadata.jsp#L192-L193
Therefore, I'm closing this PR as already fixed.  Thanks!


fixed bug in RequireScope

the RequireScope method was returning null if ObtainCurrentScope returns a value which is very strange

Looks like some tests are failing. Could you also consider adding a test case for this so we can see the problem?

OK sure I'll try soon

I found the failed Test.
[Test]
public void Requiring_scope_within_parent_scope_uses_parent_scope()
{
   Container.Register(Component.For<A>().LifeStyle.Scoped());
   using (Container.BeginScope())
   {
	var a = Container.Resolve<A>();
	using (var scope = Container.RequireScope())
	{
	   var aa = Container.Resolve<A>();
	   Assert.AreSame(a, aa);
	   Assert.IsNull(scope);
	}
   }
}

So for me, it doesn't make sense to return null scope if you found the parent scope.
I assumed it should return the parent scope or create new one, in this case, we should check that the scope is not null instead of checking that it should be null Assert.IsNull(scope);

So for me, it doesn't make sense to return null scope if you found the parent scope.
I assumed it should return the parent scope or create new one, in this case, we should check that the scope is not null instead of checking that it should be null Assert.IsNull(scope);

The problem with returning the parent scope is that you use it in a using block, which will then dispose the parent scope prematurely.
We at least need to add some XML comments to those methods to make this clear.

The problem with returning the parent scope is that you use it in a using block, which will then dispose the parent scope prematurely.

Yes, you're right. Sorry, this goal wasn't clear for me at the first look.

We at least need to add some XML comments to those methods to make this clear.

It would be great.
Thank you for the speed correction

Yes, you're right. Sorry, this goal wasn't clear for me at the first look.

No problem. The other thing to note is that these methods return IDisposable not ILifetimeScope explicitly so they don't get used to fetch the scope. I've added some XML docs in #354.

Just approved the PR.


HLF deployment on azure aks cluster

I have tried to deploy the HLF on azure AKS, but i can see there aws dependencies. the scripts has been provided only for aws.
can any one help me to implement the same on azure AKS cluster.
Appreciate for the prompt response.
Thanks,
Amit

Tips about adding cloud_provider for private k8s posted here: https://github.com/hyperledger/bevel/issues/1001#issuecomment-1125908098

Hi @amitkd-github, which scripts are you referring to?

Closing this issue as it is stale.


Dockerfile update

@abetlen i think it would be nice to publish docker images on docker hub too

@Smartappli thank you for the contribution, I've removed the docker login for now because I feel that ghcr is sufficient but may reconsider in the future.


Support grouping of dependencies updates

Hi,
it would be useful to have the option to automatically enable some basic grouping for dependency updates from the start, since dependabot can become quite noisy.
A barebone configuration with grouping enabled could be the one using the default production/development groups:
---
version: 2
updates:
  - package-ecosystem: 'npm'
    directory: '/'
    schedule:
        interval: 'weekly'
    groups:
        production-dependencies:
            dependency-type: 'production'
        development-dependencies:
            dependency-type: 'development'

Thanks for accepting this! When can you cut a new release?

I'll be working on that today!


Use new kernel picker in CI

Codecov Report

Merging #12307 (63f5b3c) into main (6d6fc38) will increase coverage by 0%.
The diff coverage is 42%.

@@          Coverage Diff           @@
##            main   #12307   +/-   ##
======================================
  Coverage     69%      69%
======================================
  Files        501      501
  Lines      31909    31917    +8
  Branches    4999     5005    +6
======================================
+ Hits       22237    22287   +50
+ Misses      7790     7736   -54
- Partials    1882     1894   +12

Impacted Files
Coverage Δ

src/notebooks/controllers/controllerLoader.ts
83% <ø> (-5%)
:arrow_down:

...tebooks/controllers/kernelSource/kernelSelector.ts
67% <0%> (-1%)
:arrow_down:

src/notebooks/controllers/types.ts
100% <ø> (ø)

...ers/commands/serverConnectionControllerCommands.ts
31% <22%> (-2%)
:arrow_down:

src/notebooks/debugger/debuggingManagerBase.ts
64% <33%> (-2%)
:arrow_down:

...ollers/commands/installPythonControllerCommands.ts
58% <42%> (-1%)
:arrow_down:

.../notebooks/controllers/controllerDefaultService.ts
60% <60%> (-2%)
:arrow_down:

...otebooks/controllers/controllerPreferredService.ts
77% <60%> (+5%)
:arrow_up:

src/standalone/api/kernelApi.ts
71% <100%> (-1%)
:arrow_down:

src/notebooks/controllers/remoteSwitcher.ts
55% <0%> (-34%)
:arrow_down:

... and 28 more


User service review

[ ]   General Comment
 Review status: 0 of 8 files reviewed at latest revision, 2 unresolved discussions.

MessengerOnFileForLinux/user_service/src/RegisterUser.cpp, line 21 at r1 (raw file):

            return true;
    }
    return false;

TESTOWY KOMENTRARZ @nmarcin
MessengerOnFileForLinux/user_service/src/RegisterUser.hpp, line 4 at r1 (raw file):

#include <string>
#include "User.hpp"

KOLEJNY TESTOWY KOMENTARZ @nmarcin
Comments from Reviewable

This change is

This pull request is now managed with CodeReviewHub. Refresh.

Review status: 0 of 8 files reviewed at latest revision, 2 unresolved discussions.

MessengerOnFileForLinux/user_service/src/RegisterUser.cpp, line 21 at r1 (raw file):

            return true;
    }
    return false;

TESTOWY KOMENTRARZ @nmarcin

MessengerOnFileForLinux/user_service/src/RegisterUser.hpp, line 4 at r1 (raw file):

#include <string>
#include "User.hpp"

KOLEJNY TESTOWY KOMENTARZ @nmarcin

Comments from Reviewable

Review status: 0 of 8 files reviewed at latest revision, 2 unresolved discussions.

MessengerOnFileForLinux/user_service/src/RegisterUser.cpp, line 21 at r1 (raw file):
Previously, marcinwozniak0 wrote…
TESTOWY KOMENTRARZ @nmarcin

Done.

Comments from Reviewable

Review status: 0 of 8 files reviewed at latest revision, 2 unresolved discussions.

MessengerOnFileForLinux/user_service/src/RegisterUser.hpp, line 4 at r1 (raw file):
Previously, marcinwozniak0 wrote…
KOLEJNY TESTOWY KOMENTARZ @nmarcin

Done.

Comments from Reviewable


Segfault when trying to compile incorrect capabilities

trait T
    fun some() =>
        "Do nothing"

class TClass is T
    let _l: String
    new create(l: String) =>
         _l = consume l
    fun some() =>
        "Do nothing"

actor Act
    let _c: T iso
    new create(c: T iso) =>
        _c = consume c

actor Main
    new create() =>
        let c: T iso = TClass.create(l)
        let a: Act   = Act.create(c)

Adding a ^ to let c: T iso = ... causes a ponyc crash.

Please post the code that you are reporting. It's not completely clear what changes are required to replicate the issue.

Hi Sean,
I'm somewhat flabbergasted. The posted code in the original comment crashes ponyc when adding a ^ to let c: T iso = ... at line 19. The code that crashes would read let c: T iso^ = ....
Hoping I'm not the crazy one!
Best,
Kyle

Kyle can you please post the complete code that crashes rather than a description of changes to code that is required to cause the situation?

Hi Sean,
It might sound crazy, but I actually did post the entire code that reproduces the issue in the first post. Any chance you can place the code in a test.pony file and try the edit I suggested?

No it doesn't…
actor Main
    new create() =>
        let c: T iso = TClass.create(l)
        let a: Act   = Act.create(c)

[red@apophenia:~/dd]$ ponyc
Building builtin -> /nix/store/nnvr2l04kdk62n633g74p0vdwf9bbrmy-ponyc-0.54.0/lib/pony/0.54.0/packages/builtin
Building . -> /home/red/dd
Error:
/home/red/dd/main.pony:19:38: can't find declaration of 'l'
        let c: T iso = TClass.create(l)

I also noticed that your constructor for Main isn't correct either:
actor Main
    new create() =>  // Should be new create(env: Env) =>

Policing the code isn't helpful. Just run it.
(base) kylefurlong@Kyles-Mac-mini quanta % cat ~/crash.pony
trait T
fun some() =>
"Do nothing"
class TClass is T
let _l: String
new create(l: String) =>
_l = consume l
fun some() =>
"Do nothing"
actor Act
let _c: T iso
new create(c: T iso) =>
_c = consume c
actor Main
new create() =>
let c: T iso^ = TClass.create("")
let a: Act   = Act.create(c)
(base) kylefurlong@Kyles-Mac-mini quanta % ponyc ~
Building builtin -> /Users/kylefurlong/.local/share/ponyup/ponyc-release-0.53.0-arm64-darwin/packages/builtin
Building /Users/kylefurlong -> /Users/kylefurlong
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
zsh: segmentation fault  ponyc ~

It's not policing code when what you originally provided (after edit) is this:
let c: T iso^ = TClass.create(l)

Which gives me:
[nix-shell:~/dd]$ ponyc
Building builtin -> /nix/store/nnvr2l04kdk62n633g74p0vdwf9bbrmy-ponyc-0.54.0/lib/pony/0.54.0/packages/builtin
Building . -> /home/red/dd
Error:
/home/red/dd/main.pony:19:47: can't find declaration of 'l'
                let c: T iso^ = TClass.create(l)

Wheres in your last comment which actually illustrates the bug you have:
let c: T iso^ = TClass.create("")

So no, your original report, even after your requested edit did not replicate the compiler error.
However, your last comment (in which you actually provided the information we explicitly asked for - thank you) - did provide a version I could replicate the issue with.
So how about we take a step back from the inflammatory language and start again?

Ah, I see the mistake. I apologize for the unforgiving attitude and unkind words. I should have read your first response more carefully and I could have then corrected the original.

@redvers can you post the complete code for this bug?

@redvers ping. see above.

I stumbled on this while searching for clues on a similar (but unfortunately not identical) error.
Here's the repro code and backtrace:
trait T
  fun some() =>
    "Do nothing"

class TClass is T
  let _l: String
  new create(l: String) =>
     _l = consume l
  fun some() =>
      "Do nothing"

actor Act
  let _c: T iso
  new create(c: T iso) =>
    _c = consume c

actor Main
  new create(env: Env) =>
    let c: T iso^ = TClass.create("")
    let a: Act = Act.create(consume c)

Fails with
# ponyc
Building builtin -> /usr/local/lib/pony/0.58.1-fe3895eb/packages/builtin
Building . -> /root/proj/scratch/pony/21-segfault
/root/proj/ponyc/src/libponyc/ast/ast.c:577: ast_id: Assertion `ast != NULL` failed.

Backtrace:
  ponyc(ponyint_assert_fail+0x9c) [0x89e49c]
  ponyc(ast_id+0x3b) [0x794a5b]
  ponyc(cap_fetch+0x15) [0x82c845]
  ponyc(expr_assign+0x244) [0x885714]
  ponyc(pass_expr+0x143) [0x7f6b53]
  ponyc(ast_visit+0x2aa) [0x7f78aa]
  ponyc(ast_visit+0x1e6) [0x7f77e6]
  ponyc(ast_visit+0x1e6) [0x7f77e6]
  ponyc(ast_visit+0x1e6) [0x7f77e6]
  ponyc(ast_visit+0x1e6) [0x7f77e6]
  ponyc(ast_visit+0x1e6) [0x7f77e6]
  ponyc(ast_visit+0x1e6) [0x7f77e6]
  ponyc(ast_visit+0x1e6) [0x7f77e6]
  ponyc() [0x7f83e6]
  ponyc() [0x7f7d75]
  ponyc(ast_passes_program+0x22) [0x7f7982]
  ponyc(program_load+0xbf) [0x81acef]
  ponyc() [0x793cf9]
  ponyc(main+0x270) [0x793b90]
  /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3) [0x7f9cfc771083]
  ponyc(_start+0x2e) [0x79385e]
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Aborted

Using version 0.58.1-fe3895eb from the most recent release tag, running on Ubuntu 20.04 on Intel.

A more minimal repro:
actor Main
  new create() =>
    let c: String iso^ = String

There's two things wrong with the code:

:one: The String constructor returns ref, not iso - you'd need to wrap it in a recover to get an iso
:two: iso^ is not a valid ref cap for a local variable (which the compiler rightly tells if you if you fix the above issue by wrapping in a recover block)

So for either of these problems in isolation, the compiler will give you error messages correctly. It's only the combination of the two that gives the assertion failure encountered in this ticket.

@jemc Just a note, let c: String iso = String is fine due to Gordon's work https://github.com/ponylang/ponyc/pull/4124


Hierarchical state nodes - translate and validate a state value

In addition holding a hierarchical state value as in #1,  a method is required to resolve state values in support of the xstate techniques of referencing state nodes
(see https://xstate.js.org/docs/guides/ids.html#identifying-state-nodes ).
This issue will cover that requirement and allow a state value to be resolved from:

a full value default state ID eg #machineID.StateID1.StateID2....StateIDn
a relative target (relative to parent using '.' notation
a sibling state by name in the same substate.
a custom id identified by '#' and assigned to a state in its id: property

during development this requirment was enhanced to provide a function to validate if a state reference is indeed a state specified in the machine config.

the following code provides a means to resolve a state reference as above into a full state id value.
/** fsmPlus - returns a full state ID (or null if error)
  * creates ID from arg stateRef in cases of stateRef being
  *  - custom ID or full def id
  *  - relative state
  *  - a named sibling state
  *  - first level named state (fsm backward compatabile)
  * arg value is the current state from which the reference is made
  * arg machine ID is for the current machine
*/
function makeStateID(stateRef, value, machineID) {
  if (stateRef == null || stateRef == '') /* arg error*/   return null;
  if (stateRef.substr(0, 1) === '#') /* custom ID */   return stateRef;
  if (stateRef.substr(0, 1) === '.') /* relative state */  return value + stateRef;
  if (value === stateRef) /* first level name */ return '#' + machineID + '.' + stateRef;
  pos = (value.lastIndexOf('.')); /* sibling state */
  if (pos === -1) return null;
  else return value.substr(0, pos + 1) + stateRef;
}


Ignore JMH in reproducibility tests

Uses .bazelignore to ignore the JMH paths during the reproducibility test.
This solution was quick and easy. Alternatively, you could perhaps filter targets by tags (and add tags on the jmh targets).

Something seems to be wrong there

It's totally not working, yet ;)

we should diagnose what is going on there, but at least we don't depend on jmh in other targets, so I think it shouldn't really be a problem.

seems that #791 handled this.


Typescript Support?

Just wrote a Typescript package for that purpose @VladislavSmolyanoy! Check it out if types are a priority :)
https://github.com/domeccleston/cosim

Awesome, thanks

One word of caution regarding the linked alternative package is that, based on its current implementation, it is likely to have numerical stability issues.

Interesting, what kind of issues @kgryte?

TypeScript annotations have been added per #3. Closing.


Control Flow Performance Improvements

Summary
While we have a working case expression, and hence working control flow, it is quite a bit slower than we'd like. This task exists to track improvements to the performance of the case expression.
Specification

Improve the performance of the case expression to be in the same ballpark as Java's if.

Acceptance Criteria & Test Cases

The case expression performs better.
It has a set of benchmarks that ensure that we're not going to regress our performance here.

Done in #45. Tail recursive code for summing a million element cons-list (using a case Cons => ... ; _ => ... structure, meaning one constructor comparison per match) takes approx. 6ms to finish on my machine, compared to Java's 4ms.


Can we please have SimpleYearView aswell ?

@Override
public int getMaxYear()
{
return 2015;
}
this set more than 2015 will be ok


[SUPPORT]  Write audit publish

dremio.com/subsurface/write-audit-publish-pattern-via-apache-iceberg/

I feel this is more like a snapshot switch and publishing procedure. Do you mean Hudi cannot support this？

I feel this is more like a snapshot switch and publishing procedure. Do you mean Hudi cannot support this？

After the data snapshot is generated, it is not visible to users, and the generated data can be queried only after the data quality test is passed.
Not sure if hudi supports this feature?

try set 'as.of.instant' to time travel?

try set 'as.of.instant' to time travel?

hudi commited

try set 'as.of.instant' to time travel?

After hudi is committed, it can be directly queried as the latest snapshot. In the data quality inspection scenario, if the data quality inspection SQL is not executed, it is not expected that the latest snapshot will be queried. Published snapshots are visible only after the data quality check is passed.

alter table table SET SERDEPROPERTIES ('as.of.instant'='2022xxxxxxxx');
If you set this in the Hive table, Spark will do time travel automatically, WDYT?

Interesting!
If I understand correctly, @fengjian428 's suggestion is to go back to a previous snapshot if the latest one is corrupt. Hudi already supports time travel. However, @melin 's suggestion is to not even publish the snapshot if it is found to be corrupt.
Shouldn't savepoint/restore along with a staging area be sufficient to support this feature? It's about how to control the visibility of a snapshot. Hudi metadata can be first written to a staging area before being published. Audit tool runs ETL and validations with the staging metadata. If all is well, then the staging metadata changes are applied to production.
@melin Hudi has all the necessary abstractions to support this feature. Can you please explain your use case and functional requirements in more detail? Are you also proposing abstractions for an audit tool? I think this could be useful to other users as well and worthy of RFC.

For the data written by spark sql, avoid quality problems (for example, a field has an invalid value, or the data volume fluctuates greatly compared to the previous cycle), and configure some data quality rules. spark sql writes the data, and then executes the quality rules. If the rule detection passes, the 'call procedure command' publishes the written data and can be queried. If there is a problem with the data quality, the 'call procedure command' deletes the generated data.

Interesting! If I understand correctly, @fengjian428 's suggestion is to go back to a previous snapshot if the latest one is corrupt. Hudi already supports time travel. However, @melin 's suggestion is to not even publish the snapshot if it is found to be corrupt.

yeah, it is like implementing the same function in different ways

Shouldn't savepoint/restore along with a staging area be sufficient to support this feature? It's about how to control the visibility of a snapshot. Hudi metadata can be first written to a staging area before being published. Audit tool runs ETL and validations with the staging metadata. If all is well, then the staging metadata changes are applied to production.

I think so,  Like I said in the last monthly sync call, I've implemented Snapshot view in our company based on the savepoint feature, although it is for a different scenario @melin FYI https://docs.google.com/presentation/d/1xypcr9onk0ogpj1lrPFQ3ERiXQpTw9NZGW4nok5i80I/edit#slide=id.g13ec3137431_2_195.

@melin Hudi has all the necessary abstractions to support this feature. Can you please explain your use case and functional requirements in more detail? Are you also proposing abstractions for an audit tool? I think this could be useful to other users as well and worthy of RFC. cc @prasannarajaperumal @vinothchandar @nsivabalan @xushiyan

I can be a co-author for this RFC if you want to create one.   basically, we need to point the Hudi table to a specific savepoint， but I think we need to do some enhancement on mor's savepoint， since the savepoint seems only tags the base file for now

if I am not wrong, hudi already had data quality validator that you can run before completing a commit. If the validation fails, the commit will abort. Would that work for your case?
https://hudi.apache.org/releases/release-0.9.0#writer-side-improvements
Check for "pre commit validator framework" in the above link.

@nsivabalan is correct, we needed a write-audit-publish pattern for building our lakehouse for derived datasets at Uber, as part of the effort, the Uber Hudi team developed pre-commit validation support for Hudi.

if I am not wrong, hudi already has data quality validator that you can run before completing a commit. If the validation fails, the commit will abort. Would that work for your case? https://hudi.apache.org/releases/release-0.9.0#writer-side-improvements Check for "pre commit validator framework" in the above link.

this is correct. If there is a need for a full-fledged data quality tool, feel free to raise an RFC discussion on the dev email list. Closing this as the write-audit-publish pattern can be fulfilled with the existing precommit validator feature.


Météo-france sensor : 1 hour rain forecast

Description:
Météo France provides a convenient rain forecast that is pretty accurate.
This sensor gives the time to next rain forecasted.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
home-assistant/home-assistant.io#6938
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: meteo_france
    location_id: 75101
    name: Paris 1er

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

We should also consider to make it a weather platform. Usually the rain forecast is only one element of a meteorological sensor.

@fabaff : I agree, but there is no API for the other weather datas.
I can easily scrape them, but is it an allowed practice to rely on scrapping for a weather component ?
I know this is only my point of view, but weather datas from other sources already in hass are already quite reliable.
This 1hr raining forecast, on the contrary, is rather unique and fits perfectly the need to know if I should close an opened windows for exemple.
Regarding all other comments, thanks for the advices. I will update my code.

Sorry I screwed up this PR. I'm closing it and submitting a new one for the same platform


Provide support for upgrading settings.

Signed-off-by: dblock<EMAIL_ADDRESS>Description
OpenSearch provides a mechanism for upgrading node settings through upgraders. When an upgrader finds a legacy setting instead of a new one, it replaces it with the new setting and removes the old setting from runtime. I attempted to repurpose those to provide a simple way for plugin authors to rename settings from, for example, opendistro.jobscheduler.retry_count to opensearch.jobscheduler.retry_count.
Reading the code it looks like settings are upgraded during all the right times when nodes are started, but I am not sure, so please tell me if I am on the wrong path here.
See https://github.com/opensearch-project/job-scheduler/pull/19 for how this is used in the job-scheduler plugin.
Other Ideas
I considered something completely magical that s/opendistro/opensearch/g in Settings, but that feels too magical and will inevitably lead to bugs.
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

How do we add docs to this feature? (my inner question, how do we let users know this is how you can use it?)

I added JavaDoc to GenericSettingUpgrader.

start gradle check

@nknize Please help review. While it's not that much work, if you have any suggestions of how we help plugin owners do even less than the diff in https://github.com/opensearch-project/job-scheduler/pull/19/files, I'd love to hear those!

Thanks @dblock ... haven't gone through the code yet but does it work for non dynamic settings too that don't have a settings update consumer

Thanks @dblock ... haven't gone through the code yet but does it work for non dynamic settings too that don't have a settings update consumer

I would say no. This means that for every setting we want to upgrade we'd have to add a dynamic consumer, which may be difficult or easy depending on the case. Do you think this is a big deal?

While I don't think it's a big deal, I do think it's hacky given that dynamic update consumers listen to changes throughout the runtime, not just boot up time which makes it a little non intuitive, also given that it has been forever used along with dynamic settings exclusively.
It'd be great if settings that plugins register, get considered for auto upgrade without needing an explicit plugin subscribed event, at node boot strap. We can check what node boot strap event we could possibly listen onto..

While I don't think it's a big deal, I do think it's hacky given that dynamic update consumers listen to changes throughout the runtime, not just boot up time which makes it a little non intuitive, also given that it has been forever used along with dynamic settings exclusively.
It'd be great if settings that plugins register, get considered for auto upgrade without needing an explicit plugin subscribed event, at node boot strap. We can check what node boot strap event we could possibly listen onto..

I see what you mean now, but I think I didn't explain it well enough.
Consider setting OLD that is declared in a plugin and has its value set. When the node joins a cluster, the value of OLD is read and used in the plugin code.
Next version of plugin. Now we want to upgrade OLD into NEW. We implement an upgrader for OLD, which turns it into NEW. Our new code reads the value of NEW only, and uses that. When a node joins a cluster, OLD is read, then NEW is read but is not set, and its default value is used. So now we are using the default value of NEW, which is not what we want, cause we want the upgrade! After this initial load upgraders run, they remove OLD and upgrade it into NEW, the value of NEW changes, and because we have a listener we get to use this value, and all is well.
If we don't listen, the other option is to something like "if NEW is not set, try OLD, otherwise use default value of NEW". I'll take a look at it, but maybe it's better to support changing settings at runtime? Do you have an example where it would be a bad idea?

Have you looked at this part which probably is done at node boot strap. I was wondering if plugin upgrade registered settings gets picked up here and "if NEW is not set, try OLD, otherwise use default value of NEW"
https://github.com/opensearch-project/OpenSearch/blob/0ba0e7cc26060f964fcbf6ee45bae53b3a9941d0/server/src/main/java/org/opensearch/gateway/GatewayMetaState.java#L228-L238

@Bukhtawar Sort of.
After a bit more code reading I realized that there's actually a fallback mechanism for settings. If a setting isn't set, it can fallback to another one. Working example in https://github.com/opensearch-project/job-scheduler/pull/20 in which I renamed opendistro settings to legacy settings, marked them as deprecated, and fall back to them from opensearch settings. This does work.
Interestingly it's the same load order as with upgraders. On start the settings are defaulted, then when the node joins a cluster the node settings are loaded and used.

If you put settings in opensearch.yml, then you get fallback right away. Thus https://github.com/opensearch-project/job-scheduler/pull/20 will never see the "wrong" setting, but https://github.com/opensearch-project/job-scheduler/pull/19 would.
If you set cluster settings, the node will get them when it joins the cluster. Thus https://github.com/opensearch-project/job-scheduler/pull/20 and https://github.com/opensearch-project/job-scheduler/pull/19 have the same effect.

I think I'd prefer to merge #665 than this one, will close for now.


Add name and github link to contributors.md

This file has been removed in earlier PRs and you can add your name here https://github.com/HacktoberfestinAba/HacktoberfestinAba.github.io/blob/master/CONTRIBUTING.md
You can git pull the repo to sync the updates and send in a new PR


New data: "GDP total, yearly growth" and "GDP per capita, yearly growth" doesn't have measurement unit

%? B$? M$?

According to metadata it's percent:
https://docs.google.com/spreadsheets/u/1/d/1LklNUuBgFLNcGyG63kqjyze7N8_fDlNLAWZG4YKwJXc/pub#
https://docs.google.com/spreadsheets/u/1/d/1tAnT0EeP67_DoOJCXb3Wd0hqjVMe0KWHPwUH22-BNmQ/pub#
(tab about)
So I added it to graph_settings table

GDP total yearly growth  percent of total GDP
GDP/capita yearly growth percent of GDP

I confirm, it's so clear we don't need Mattias to help us on this.
i further shortened the units:
GDP total yearly growth	% of total GDP
GDP/capita yearly growth	% of GDP/capita


distributed runner

📑 I have found these related issues/pull requests
Multiple runners
distributed runner
I didn't search any issure about it.
🏷 Feature Request Type
API / automation options
🔖 Feature description
The runner and dashboard are deployed together, allowing monitoring of only a single physical location. Is it possible to support distributed runner deployment?
✔ Solution
Separate the runner and dashboard. The runner can be deployed freely and configured with a reporting path. The dashboard can register and manage the runners. Execution result data is stored and displayed on the dashboard. Runners can be deployed in multiple regions, enabling the dashboard to achieve monitoring across multiple regions and network environments.
❓ Alternatives
No response
📝 Additional Context
No response

Duplicate of #84 as far as I can tell
=> Closing as a duplicate


Refactor for v3

Refactor the module for companion v3
-> try to resolve #12

@josephdadams do you want to review the changes?
Or can I just merge the branch with all the changes?
I tested the module and everything should work as before. Because I had to start from scratch and renamed a lot of stuff, I’m not sure what will happen when there is an existing v2 configuration…

I tested the module and everything should work as before. Because I had to start from scratch and renamed a lot of stuff, I’m not sure what will happen when there is an existing v2 configuration…

Yeah, it looks like every action has been renamed, so existing users will have all their actions break when they update companion to the version that includes this.
It would be a good idea to write an upgradescript to translate existing configs across. Something like https://github.com/bitfocus/companion-module-bmd-atem/blob/master/src/upgrades.ts#L131-L149, but perhaps with some updating of the options too

Refactor the module for companion v3
-> try to resolve #12

Do you have some news for this bug fix for V3.0 ?

I believe we are waiting on the PR author to add the upgrade scripts so that this doesn’t break the config for the hundreds of users

I tested the module and everything should work as before. Because I had to start from scratch and renamed a lot of stuff, I’m not sure what will happen when there is an existing v2 configuration…

Yeah, it looks like every action has been renamed, so existing users will have all their actions break when they update companion to the version that includes this. For reference, there are at least a few hundred users of this module
It would be a good idea to write an upgradescript to translate existing configs across. Something like https://github.com/bitfocus/companion-module-bmd-atem/blob/master/src/upgrades.ts#L131-L149, but perhaps with some updating of the options too

@Julusian
I looked at https://github.com/bitfocus/companion-module-base/wiki/Upgrade-scripts and tried to figure out an upgrade script, but I did not really come far... I found no possibility the debug the script properly.
Because I refactored + cleaned up the actions  completely, I would propose to just accept the broken actions for users that come from the old version of this module. I'm working on feedbacks and presets, so there is in actual benefit in manually restoring the button.
What do you think?

Resolve #10
and
Resolve #16 (duplicate for #12)

From my side, I'm ready to merge this branch. As mentioned, this will break configs from previous versions, but I completely overhauled the module...

Hi are there any updates? Thanks a lot for the effort.


docs: Add a decorator to remove unused tags

We discussed this in https://github.com/Redocly/redocly-cli/issues/953 so here is a proposed solution.
The issue also suggests adding features to identify tags that are used but not declared at the top level - which would make this a bit less single-responsibility, but I do have all the data I'd need in context, maybe I could just add an output line listing any undeclared tags? Opinions welcome!

I learned both some new javascript functionality and a cool thing about the visitor pattern, and this version is so much better. Thank you @tatomyr , please take another look!


Delimited lists

Proposed implementation of #66. Interface:
args = {'values': fields.DelimitedList(fields.Int())}
args = {'values': fields.DelimitedList(fields.Int(), delimiter='|')}
...

Updated.

Just one more suggested change.

Updated--although for the record, I prefer the original parameter name :hamburger:

I do think dump_string is slightly better, but I think consistency > correctness in this case.
Anyway, thanks for this!


Update scalafmt-core to 3.6.1

Updates org.scalameta:scalafmt-core from 3.6.0 to 3.6.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:n:3

Codecov Report

Merging #2282 (592074c) into main (08e1b8c) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2282   +/-   ##
=======================================
  Coverage   78.39%   78.40%
=======================================
  Files         433      433
  Lines       14663    14663
  Branches     2000     2000
=======================================
+ Hits        11495    11496    +1
+ Misses       3168     3167    -1

Impacted Files
Coverage Δ

...cala/at/forsyte/apalache/io/lir/PrettyWriter.scala
89.35% <0.00%> (ø)

...he/io/annotations/parser/CommentPreprocessor.scala
96.70% <0.00%> (-1.10%)
:arrow_down:

.../forsyte/apalache/tla/pp/ConstSimplifierBase.scala
97.70% <0.00%> (+1.14%)
:arrow_up:

...a/at/forsyte/apalache/tla/lir/TlaLevelFinder.scala
95.83% <0.00%> (+2.08%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


dynamic barWidth

Hi,
Is there a way to use function in barWidth. like barWidth: function(params){}

Could you describe the scenario where function barWidth is required?
Currently maybe media query can be used to reach the similar effect.


fix: tfsconfig-cmd links

Not sure if these links changed without a redirect since they don't appear be part of the vsts-docs repo currently

@nschonni : Thanks for your contribution! The author, @gewarren, has been notified to review your proposed change.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ide/codeindex-command.md
:white_check_mark:Succeeded

docs/ide/find-code-changes-and-other-history-with-codelens.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


SSH

Immediate termination of ssh session when correct password "alpine" is entered.

this seems to only happen on the first run.


Release 1.15.0

Release checklist:

[x] Create a new Release Issue

[x] Replace 1.14.0 with the former release, and 1.15.0 with THIS

[x] Update the Roadmap calling out shipped features
[x] Create and update a Milestone for the release

[x] Assign this task
[x] Assign all the shipped roadmap Issues
[x] Assign the relevant recently closed Isssues

Code changes:

[x] Create a release branch 'release-x.y.z': git checkout -b release-1.15.0
[x] Create a temporary tag git tag v1.15.0 && git push opensource --tags
[x] Create a New Draft GitHub Release, and generate the automated changelog (for new contributors)
[x] Update the release version in package.json, and npm i
[x] Update the in-app News version number
[ ] Update in-app News src/apps/news/news.data.tsx
[x] Update in-app Cover graphics
[ ] Update the README.md with the new release
[ ] Copy the highlights to the docs/changelog.md

Release:

[ ] merge onto main git checkout main && git merge --no-ff release-1.15.0
[ ] re-tag git tag -f v1.15.0 && git push opensource --tags -f
[ ] verify deployment on Vercel
[ ] verify container on GitHub Packages
[ ] update the GitHub release
[ ] push as stable git push opensource main:main-stable

Announce:

[ ] Discord announcement
[ ] Twitter announcement

Links

Milestone: https://github.com/enricoros/big-AGI/milestone/X
GitHub release: https://github.com/enricoros/big-AGI/releases/tag/v1.15.0
Former release task: #...

Artifacts Generation
You help me generate the following collateral for the new release of my opensource application called big-AGI. The new release is 1.15.0.
To familiarize yourself with the application, the following are the Website and the GitHub README.md.

paste the URL: https://big-agi.com
drag & drop: README.md

I am announcing a new version, 1.15.0.
For reference, the following was the collateral for 1.14.0 (Discord announcement, GitHub Release, in-app-news file news.data.tsx).

paste the former: discord announcement,
GitHub release,
news.data.tsx,
changelog.md

The following are the new developments for 1.15.0:

- ...
- git log --pretty=format:"%h %an %B" v1.14.0..v1.15.0 | clip

paste the link to the milestone (closed) and each individual issue (content will be downloaded)
paste the output of the git log command

news.data.tsx
I need the following from you:

1. a table summarizing all the new features in 1.15.0 with the following columns: 4 words description (exactly what it is), short description, usefulness (what it does for the user), significance, link to the issue number (not the commit)), which will be used for the artifacts later
2. then double-check the git log to see if there are any features of significance that are not in the table
3. then score each feature in terms of importance for users (1-10), relative impact of the feature (1-10, where 10 applies to the broadest user base), and novelty and uniqueness (1-10, where 10 is truly unique and novel from what exists already)
4. then improve the table, in decreasing order of importance for features, fixing any detail that's missing, in particular check if there are commits of significance from a user or developer point of view, which are not contained in the table
5. then I want you then to update the news.data.tsx for the new release

release name
please brainstorm 10 different names for this release. see the former names here: https://big-agi.com/blog

You can follow with 'What do you think of Modelmorphic?' or other selected name
cover images
Great, now I need to generate images for this. Before I used the following prompts (2 releases before).

// An image of a capybara sculpted entirely from black cotton candy, set against a minimalist backdrop with splashes of bright, contrasting sparkles. The capybara is using a computer with split screen made of origami, split keyboard and is wearing origami sunglasses with very different split reflections. Split halves are very contrasting. Close up photography, bokeh, white background.
import coverV113 from '../../../public/images/covers/release-cover-v1.13.0.png';
// An image of a capybara sculpted entirely from black cotton candy, set against a minimalist backdrop with splashes of bright, contrasting sparkles. The capybara is calling on a 3D origami old-school pink telephone and the camera is zooming on the telephone. Close up photography, bokeh, white background.
import coverV112 from '../../../public/images/covers/release-cover-v1.12.0.png';

What can I do now as far as images? Give me 4 prompt ideas with the same style as looks as the former, but different scene or action

Readme (and Changelog)
I need you to update the README.md and the with the new release.
Attaching the in-app news, with my language for you to improve on, but keep the tone.

GitHub release
Please create the 1.15.0 Release Notes for GitHub, following the format of the 1.14.0 GitHub release notes attached before.
Use a truthful and honest tone, understanding that people's time and attention span is short.
Today is 2024-XXXX-YYYY.

Now paste-attachment the former release notes (or 1.5.0 which was accurate and great), including the new contributors and
some stats (# of commits, etc.), and roll it for the new release.
Discord announcement
Can you generate my 1.15.0 big-AGI discord announcement from the GitHub Release announcement?
Please keep the formatting and stye of the discord announcement for 1.14.0, but with the new messaging above.

Absolute beast of a release:

221 files changed, 7734 insertions(+), 2475 deletions(-)

Discord
@everyone :sparkles: big-AGI 1.15.0 - Beam Launched
:partyblob~1: Unleash the power of multi-models AI chats. :partyblob~1:
"Beam" is a groundbreaking new chat modality in big-AGI that empowers users to find better answers by leveraging the collective intelligence of multiple models. It's a game-changer for brainstorming, decision-making, and creativity.
This is an exclusive technique for you, big-AGI users! With 400+ commits and 10,000+ lines of code changed, big-AGI 1.15 is the most impactful release to date. <-- We're looking for more devs: the roadmap is huge and has reasoning systems, templates, agents, perfect local model support, desktop client, etc.

Beam: New multi-model AI chat modality --> https://big-agi.com/blog/beam-multi-model-ai-reasoning
Managed Deployments Auto-Configuration: simplify your deployment setup: set the keys on the backend and the frontend will auto-configure and load all the available models - works well with local models too, such as LocalAI :heart_hands:
Message Starring :star:: star important messages, and in the future you'll be able to attach and filter chats (we're still tuning the UI experience, but you can start starring)
Persona Enhancements: Improved the Default persona
UI and Model Fixes: ironed out issues with Gemini models and SVGs and polished the UI and icons

For the Devs:

Updated the 12 LLM vendors to support imperative models discovery (instead of reactive) - this will enable soon unified discovery of any model type

:rocket: Experience the future of AI chats with Beam - available on https://get.big-agi.com, etc. etc. :rocket:
And what's below? Is it the ride of the valkyries? no it's big-AGI BEAM!


doc: Cleanup VM onboarding since this is not fully implemented in v0.8

Please remove documents referencing VM onboarding since this is not fully implemented (or at all) in v0.8.
We will resurrect these documents from the git repo when we are ready for VMs.

Is it necessary to clean this up since it says WIP
https://github.com/openservicemesh/osm/blob/main/docs/content/docs/tasks_usage/onboard_vm.md#onboarding-vms-to-the-service-mesh
I'm okay either way since the change could easily be reverted via github. Just not sure what the timelines is for this

Is it necessary to clean this up since it says WIP
https://github.com/openservicemesh/osm/blob/main/docs/content/docs/tasks_usage/onboard_vm.md#onboarding-vms-to-the-service-mesh
I'm okay either way since the change could easily be reverted via github. Just not sure what the timelines is for this

I propose we remove it because it appears in a prominent place in our main docs site. This makes it look like we fully support VMs. This is no longer the case.  We deliberately removed code handling VMs a few months ago. Once SMI has the notion of non-Kubernetes payload we can come back and resurrect VM payloads code and documentation. (These removal commits should be easy to find and revert.)


Create or replace

When updating an existing live or draft content item, the entity should be completely replaced by the new data, including blanking any fields which are not supplied.
Adds a create_or_replace method, intended to be called within a transaction, that queries for an existing item by content id and locale, locks it, and completely replaces it by merging the supplied data with
the column defaults for that class, updating the version number. This method is used in the put_draft_content_with_links and put_content_with_links commands.
In addition, this attempts to retry a command if it resulted in a unique constraint violation. These are being caused by a request being retried before the original insert has been committed, retrying the transaction should ensure that the second request sees the original insert.

:+1: for intent
:+1: like the Replacable mixin and use of shared examples to test it
some issues on the retry implementation


[CSL-1962] Implement endpoint in order to check the validity of addresses

Summary:

Added verifyAddress function as /addresses/x/validity route based on prior check plus AddressSpec.
Works the same as wallet old code except also checks the length. Length should probably come from a global constant but couldn't find one.
Ignores errors in decodeAddress since I assume we only care whether the address is valid or not.
A couple of comment lines were added just for visual differentiation between Address / Account, can remove if necessary. I imagine these types will be refactored to their own modules eventually.

@et4te This is utterly my fault for not making this clear with everybody, but would you be up for rebasing this on alfredo/wallet-new? Essentially, currently the protocol is for V1 code to live in the feature-branch called alfredo/wallet-new, from which we all branch to do new work and PRs. In a nutshell, the workflow is:

git checkout alfredo/wallet-new
git checkout -b et4te/cslXXX-small-description
Open PR using as target branch alfredo/wallet-new
We merge the PR
We periodically merge alfredo/wallet-new into master, trying to stick to the git flow pattern.

Sorry for the confusion!

Hey Alfredo, I rebased onto alfredo/wallet-new however now it includes all of those changes hmm...

Hey Alfredo, I rebased onto alfredo/wallet-new however now it includes all of those changes hmm...

try opening a new branch from alfredo/wallet-new and cherry-picking your commits there

@et4te Yes, that's the crucial bit, you need to fork from alfredo/wallet-new to not have such humongous diff. A nice way to achieve that is to do what @akegalj was suggesting :)


Remove Apple Silicon workarounds from plugin lint test

ARM Macs are now supported, as well as the arm64 iOS simulator.  Remove workarounds from #77028
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Test run:
https://ci.chromium.org/p/flutter/builders/try/Mac plugin_lint_mac/17996?


Adafruit Git hub

https://learn.adafruit.com/crack-the-code/overview
I'm getting a build error trying to use the sample code for BLE , apparently it needs to be updated to swift 4. Any chance there is a swift 4 version so I can continue learning how to create an iphone app for my Bluetooth Arduino devices>

no ETA! you can use Swift 3 for now

Ok, but then not sure what I need to do different to get it to compile with latest Xcode , seems like the build would give me a warning not just stop.  I followed your instructions became a registered developer, (great instructional as I would never have figured it on my own) paid $100 and hoped to use your example to get me started. But given it won't build I am at a loss. Any help you could provide me would be greatly appreciated.

@ladyada

hiya, we have no other code examples - this is the only code right now and it is Swift 3 at this time. we have no ETA on a Swift 4 version. Apple likes to do this to their developers for some reason :(

Ok, thanks again....😎
Jim Odom
Mobile:<PHONE_NUMBER>

On Nov 18, 2017, at 6:17 PM, ladyada<EMAIL_ADDRESS>wrote:
hiya, we have no other code examples - this is the only code right now and it is Swift 3 at this time. we have no ETA on a Swift 4 version. Apple likes to do this to their developers for some reason :(
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Notice D - mADX : Activity <IP_ADDRESS> Provide PATH with link to the source code

Not required as a ticket


improve visual contrast/ animation of speech microphone

cc @bpasero

Just fyi, I attempted to model how other related UIs looks like, mainly Bing Copilot Chat:

I think one challenge is that our buttons are generally smaller so the effect is smaller.
The implementation is here:
https://github.com/microsoft/vscode/blob/5460e21847948d5432a24d5a8ba5d6ceaca804bf/src/vs/workbench/contrib/chat/electron-sandbox/actions/voiceChatActions.ts#L680-L724

We have a bit of leeway on the icon canvas to make this look visually bigger. I can have a look at that.

Cool thanks!

Larger mic-* icons in https://github.com/microsoft/vscode-codicons/pull/225


Example - Supports zoom-in in the detail page image

This is a example update.

macOS/iOS
Pinch (Touch Pad two finger gesture) to zoom-in

tvOS
Play/Pause button to zoom-in

watchOS
Digital Crown to zoom-in

Two related Radar during this Example. Good SwiftUI :)
FB7450873: SwiftUI on watchOS: Bug - Using List to navigation to a detail View with focusable and digitalCrownRotation, even the detail view is poped, List view does not get focused back
FB7450851: SwiftUI on tvOS: Bug - Using onPlayPauseCommand with a focused UIViewRepresentable does not get any callback


SIGSEV When extensions is enabled with SourceGuardian

Describe your environment
Container built via a Dockerfile
`FROM php:8.0.30-alpine
ADD https://github.com/mlocati/docker-php-extension-installer/releases/latest/download/install-php-extensions /usr/local/bin/
RUN apk add --no-cache strace && chmod +x /usr/local/bin/install-php-extensions &&
install-php-extensions sourceguardian
<EMAIL_ADDRESS>grpc
mbstring
zlib
protobuf
ADD test.php /app/test.php
`
Steps to reproduce

Encode a test.php(content as simple as possible e.g. <?php echo 'test';) file via sourceguardian (https://www.sourceguardian.com/online-php-encoder.html choose PHP8+)
Place the encoded php content as test.php next to the Dockerfile
Build the Dockerfile with: docker build -f Dockerfile -t otel-debug-local .
Run the container with docker run --rm -it --entrypoint /bin/sh otel-debug-local
Call the php file with php /app/test.php

What is the expected behavior?
An output which says test
What is the actual behavior?
An error which says Segmentation fault
Additional context
The SourceGuardian extension does not come as a debug variant so i could not use gdb or a php debug variant.
Currently i only could provide an strace run see attached strace.txt
strace.txt

Managed to get a minimal gdb
0  0x00007f5681a02028 in ?? ()
1  0x000055ef3da4f37d in _zend_observe_fcall_begin (execute_data=0x7f5681a13dd0) at /usr/src/php-8.0.30/Zend/zend_observer.c:163
2  0x000055ef3da4f3fe in zend_observer_fcall_begin (execute_data=0x7f5681a13dd0) at /usr/src/php-8.0.30/Zend/zend_observer.c:176
3  0x000055ef3d9f02a5 in zend_execute (op_array=0x7f5681a8b100, return_value=0x7f5681a13d60) at /usr/src/php-8.0.30/Zend/zend_vm_execute.h:59522
4  0x00007f5681cab243 in ?? () from /usr/local/lib/php/extensions/no-debug-non-zts-20200930/sourceguardian.so
5  0x000055ef3d9d68e7 in ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER () at /usr/src/php-8.0.30/Zend/zend_vm_execute.h:1295
6  execute_ex (ex=0x7f5681a13020) at /usr/src/php-8.0.30/Zend/zend_vm_execute.h:55163
7  0x000055ef3d9f02b5 in zend_execute (op_array=0x7f5681a8b000, return_value=0x0) at /usr/src/php-8.0.30/Zend/zend_vm_execute.h:59523
8  0x000055ef3d89b3f8 in zend_execute_scripts (type=8, retval=0x0, file_count=3) at /usr/src/php-8.0.30/Zend/zend.c:1694
9  0x000055ef3d7e0c0c in php_execute_script (primary_file=0x7fffaebdadf0) at /usr/src/php-8.0.30/main/main.c:2546
10 0x000055ef3da50efd in do_cli (argc=6, argv=0x55ef3f1061a0) at /usr/src/php-8.0.30/sapi/cli/php_cli.c:949
11 0x000055ef3da520a9 in main (argc=6, argv=0x55ef3f1061a0) at /usr/src/php-8.0.30/sapi/cli/php_cli.c:1337

What is your opinion should i create a issue @ the php-src repo ?

I wouldn't do that just yet. zend_observer calls opentelemetry functions which are registered on startup, so it's very likely that it's code in the opentelemetry extension which is causing the segfault.
It's quite annoying that you can't run their extension against a debug build of PHP - I was able to replicate your issue, but not get any useful traces. Perhaps if you were to reach out to the sourceguardian vendor they might be able to help run it with debug symbols?

Thank you @brettmc i reached out to sourceguardian about it.
I try to keep this thread in sync once i receive a feeback. I also got a different segfault with a simple demo extension for zend_observer calls (https://github.com/SammyK/observer)
0x000055a8e93d914b in zend_vm_calc_used_stack (func=0x2, num_args=0) at /usr/src/php-8.0.30/Zend/zend_execute.h:224 224             if (EXPECTED(ZEND_USER_CODE(func->type))) {

I try to keep this thread in sync once i receive a feeback. I also got a different segfault with a simple demo extension for zend_observer calls (https://github.com/SammyK/observer)

Good thinking! It's a pretty simple PoC, so maybe that points to SourceGuardian not being compatible with the observer API? It's pretty new to PHP and probably not very widely used yet.

@brettmc This is also what i think.
At the moment i only got the feedback that SourceGuardian encoded files should be used on production system(Which indeed does not help in debuging it and I am still in contact with SourceGuardian).
What i reached is the following at the moment:
I stripped down the otel_observer.c function so that the begin ,end and init function are only executing the following:
static zend_observer_fcall_handlers
observer_fcall_init(zend_execute_data *execute_data) {
zend_observer_fcall_handlers handlers = {NULL, NULL};
handlers.begin = observer_begin_handler;
return handlers;
}
static void observer_begin_handler(zend_execute_data *execute_data) {
php_printf("[BEGIN %s()]\n","observer_begin_handler");
}
static void observer_end_handler(zend_execute_data *execute_data,
zval *retval) {
php_printf("[END %s()]\n","observer_end_handler");
}
Same as the POC but with the difference that i get an output before the segfault:
[BEGIN observer_begin_handler()] which points me to a php-src thing.
But still the same segfault.
1 0x000055ef3da4f37d in _zend_observe_fcall_begin (execute_data=0x7f5681a13dd0) at /usr/src/php-8.0.30/Zend/zend_observer.c:163
2 0x000055ef3da4f3fe in zend_observer_fcall_begin (execute_data=0x7f5681a13dd0) at /usr/src/php-8.0.30/Zend/zend_observer.c:176

@brettmc
I have received the following response from the support team at Sourceguardian.

I doubt this will work because using of any tracing tools and other extensions which deeply integrate with PHP and affect how bytecode is processed, will not work since this affects SourceGuardian from loading and executing the encoded bytecode.

So i think there should be some type of remark in this project like it was for blackfire #80.
Another interesting thing to note is that there is a statement regarding the Sourceguardian Extension on the Blackfire Support website, which states the following:

PHP is likely to crash when the following PHP extensions are installed together with Blackfire:
XHProf
Pinba
Suhosin
Sourceguardian
Ioncube

Creating a conflict with SourceGuardian is straight-forward, it turns out. I couldn't work out why I couldn't see the zend extensions from C code, but https://www.phpinternalsbook.com/php7/extensions_design/zend_extensions.html#zend-extensions-lifetime-hooks says that modules are all loaded before zend_extensions are (SourceGuardian is a zend_extension).
Since we do our checking in MINIT(), that's too early to be able to see zend extensions. I tried moving the checks into RINIT() but that breaks almost all of our tests (but the conflict checking worked, so that's something).
So, it looks like for conflicts with zend extensions, the best we can do is to document it.
Also, I tried running with xhprof and ionCube enabled (which were the easiest for me to install), and it didn't obviously break.


Reflection PropertyInfo.SetValue(obj, value) does not work on boxed value-type structs

When in my application, for a generic PropertyGrid implementation, attempting to:
a. Box a value-type structure into an Object
b. Then change one of the properties through reflection
c. Then Unbox it back into the value-type.
This should work, and does work in a C# Windows Console Application compiled with Visual Studio 2017.
In Bridge .NET it seems the change is not properly set inside PropertyInfo.SetValue in a silent failure. Perhaps lost in due to some internal boxing/unboxing mechanisms inside PropertyInfo.SetValue(), even though already boxed correctly from the outside.
Steps To Reproduce
https://deck.net/010f582b7cf0fa70c3fb3abf0722ea67
public class Program
{
    // Author: Christian Lundheim
    // ISSUE: Reflection inconsistency with C# compiler on Windows

    // Change to 'class' and it will work as expected
    public struct Size
    {
        public int Width {get;set;}
        public int Height {get;set;}
    }

    public static void Main()
    {
        // Init value typed data-structure
        Size Test = new Size {Width = 10, Height = 20};

        // Box the value-type and change it through Reflection
        Object Boxed = Test;
        Boxed.GetType().GetProperty("Height").SetValue(Boxed, 1234);

        // Unbox it back
        Test = (Size)Boxed;

        // Does output:   Width=10, Height=20
        // Should output: Width=10, Height=1234
        // (correct output observed on C# Windows Console Application)
        Console.WriteLine($"Width={Test.Width}, Height={Test.Height}");
    }
}

Expected Result
Width=10, Height=1234

Actual Result
Width=10, Height=20

By the way, there is a temporary work-around for this problem:
a. Cast the Object to a 'dynamic' type
b. Call PropertyInfo.SetValue on the dynamic value
c. Cast it back to Object, or the value-type struct


Missing hyper param column

I'm trying tp train the system after manually download the dataset(automatic download keep failing).
I have ran dataprep with no issue, but training is not working.
And I cannot find any file related to these meta data.
Thanks for your help
below is the error msg:
python training_system1.py --gpu 1 --seed 1
training_system1.py:57: DtypeWarning: Columns (40,54,59) have mixed types.Specify dtype option on import or set low_memory=False.
self.prepare_data()
Traceback (most recent call last):
File "training_system1.py", line 282, in
main(hparams)
File "training_system1.py", line 250, in main
model = DCASETALNetClassifier(hparams)
File "training_system1.py", line 58, in init
num_meta = len(self.dataset[0]['metadata'])
File "/storage/dcase2020/prepare_data/sonycust.py", line 340, in getitem
metadata = np.array(self.annotation_df[self.metadata_labels].iloc[index])
File "/usr/local/lib/python3.6/dist-packages/pandas/core/frame.py", line 2806, in getitem
indexer = self.loc._get_listlike_indexer(key, axis=1, raise_missing=True)[1]
File "/usr/local/lib/python3.6/dist-packages/pandas/core/indexing.py", line 1553, in _get_listlike_indexer
keyarr, indexer, o._get_axis_number(axis), raise_missing=raise_missing
File "/usr/local/lib/python3.6/dist-packages/pandas/core/indexing.py", line 1640, in _validate_read_indexer
raise KeyError(f"None of [{key}] are in the [{axis_name}]")
KeyError: "None of [Index(['latitude', 'longitude', 'week', 'day', 'hour'], dtype='object')] are in the [columns]"

Hi,
First, thank you for your interest in our work.
It seems you have the wrong annotation.csv, I corrected some files (sonycust.py and config.py) and added more indications on the Readme so it should be easier for you to download and prepare the dataset.
By running python data_prep.py --download --mel once more, everything should be working now.
Let me know if you still have an error.

It works. Thank you.
Un related question, is there a way to train the system in multiple session?
Say 50 epoch learning, and save, the restart from the 51st epoch.

Sure, with Pytorch Lightning it should be easy.
You have to tweak the Trainer object, here is some code to guide you in the right direction.
Train for 50 epoch :
model=TheModel()
trainer = pl.Trainer(max_epochs=50)
trainer.fit(model)

Then you can restart training :
trainer.max_epochs = 100
trainer.fit(model)

For the save/load part, you have to use the ModelCheckpoint callback and load_from_checkpoint(path_to_the_weights).


Clear Cache Error

Hi,
clearing the content Stache cache manually runs into an error:
ErrorException
Trying to get property 'origin' of non-object
/admin/utilities/cache/cache/stache
Illuminate\Foundation\Bootstrap\HandleExceptions::handleError
vendor/statamic/eloquent-driver/src/Entries/Entry.php:72

Please provide the entire stack trace.

Hi,
cannot reproduce the error anymore :/ i will reopen the issue with the stack trace if the error occurs again.


Delete swagger-ui

Deleting swagger-ui and setting up a redirect to Reference section.
Closes #1924
Fixes #2220
Signed-off-by: Ahmet Alp Balkan<EMAIL_ADDRESS>

This change is

I forgot we actually deleted it already. @chenopis can you close the issues?

reopening because https://kubernetes.io/kubernetes/third_party/swagger-ui/ still renders the Swagger UI and not the notice added by Andrew last week. Jekyll error console is empty, so perhaps just a bug.


Disable use of __NR_io_getevents when not defined

Architectures like riscv32 do not define this syscall, therefore return
ENOSYS on such architectures
Signed-off-by: Khem Raj<EMAIL_ADDRESS>

The proposed change would make the code compile. But in watch_handle_eventfd() we'll read() some number (<= 32) of struct io_event back from the kernel and then as the patch is written we will check ev[i].obj->aio_fildes on 38 of those.
So most likely you meant to return -ENOSYS, in which case diag-router will never consume any incoming data - making the tool useless.
So what is the actual status of io_getevents() on riscv, does async io work on riscv and if so what's the process for figuring out how many ev structs we got back from the read?

ah yes I meant -ENOSYS will upload a v2 soon

this patch looks legit. however that means this software is not expected to work on riscv as it is. so @kraj , perhaps we could mark it as incompatible in meta-qcom?

I think it should be still applied, it ensures that it can compile and will show errors on unimplemented syscall. Perhaps io_urig could be used to mitigate this difference may be.

yes, i think we should merge this patch. as i said above, it's a good patch ;)

you can also consider using libaio if you want to abstract above such details instead of syscalls. Just an idea


hardware problem

Hi, thank you very much for your contribution to this project. I have a question to ask: what does your project hardware look like. What is the graphics card memory for the training project? thanks

I alse have the same question,im trying to use 4070ti to finish this job

Thanks for your interest in our projects. I used NVIDIA TITAN RTX for training and inference, which has 24G memory

Thanks for your interest in our projects. I used NVIDIA TITAN RTX for training and inference, which has 24G memory

I also use 24G memoey gpu, but RuntimeError: CUDA out of memory. Tried to allocate 2.00 MiB (GPU 1; 23.69 GiB total capacity; 21.11 GiB already allocated; 2.00 MiB free; 21.66 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF
(3dgcn) sylva@birl:/data/zclin/hl/3dg
bs :1

I also use 24G memoey gpu, but RuntimeError: CUDA out of memory. Tried to allocate 2.00 MiB (GPU 1; 23.69 GiB total capacity; 21.11 GiB already allocated; 2.00 MiB free; 21.66 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation. See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF (3dgcn) sylva@birl:/data/zclin/hl/3dg bs :1
I've solved the problem，by adding "with torch.no_grad():" on test()

Thanks for your interest in our projects. I used NVIDIA TITAN RTX for training and inference, which has 24G memory

I also use 24G memoey gpu, but RuntimeError: CUDA out of memory. Tried to allocate 2.00 MiB (GPU 1; 23.69 GiB total capacity; 21.11 GiB already allocated; 2.00 MiB free; 21.66 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation. See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF (3dgcn) sylva@birl:/data/zclin/hl/3dg bs :1

I've solved the problem，by adding "with torch.no_grad():" on test()，Thanks for your works！

Thanks for your interest in our projects. I used NVIDIA TITAN RTX for training and inference, which has 24G memory

Hi, thank you for your great work. I found the phenomenon of increasing the Gpu memory during the training stage, but I don't know which link caused it, does this happen when you're running?

Thanks for your interest in our projects. I used NVIDIA TITAN RTX for training and inference, which has 24G memory

Hi, thank you for your great work. I found the phenomenon of increasing the Gpu memory during the training stage, but I don't know which link caused it, does this happen when you're running?

I spent a lot of time trying to solve this problem, and finally found that it was caused by lines 107-109, and l commented it out and there was no longer a problem with memory increments.

Thanks for your interest in our projects. I used NVIDIA TITAN RTX for training and inference, which has 24G memory

Hi, thank you for your great work. I found the phenomenon of increasing the Gpu memory during the training stage, but I don't know which link caused it, does this happen when you're running?

I spent a lot of time trying to solve this problem, and finally found that it was caused by lines 107-109, and l commented it out and there was no longer a problem with memory increments.

Hi, I had the same problem. Could you please provide details of the solution. Thanks for your reply.

Thanks for your interest in our projects. I used NVIDIA TITAN RTX for training and inference, which has 24G memory

Hi, thank you for your great work. I found the phenomenon of increasing the Gpu memory during the training stage, but I don't know which link caused it, does this happen when you're running?

I spent a lot of time trying to solve this problem, and finally found that it was caused by lines 107-109, and l commented it out and there was no longer a problem with memory increments.

Hi, I had the same problem. Could you please provide details of the solution. Thanks for your reply.

my solution is , in ” segmentation/manager.py “，Put lines 107-109 into the following if statement, because “out[mask == 0] = torch.min(out)” takes up a lot of GPU memory if not placed this way

Thanks for your interest in our projects. I used NVIDIA TITAN RTX for training and inference, which has 24G memory

Hi, thank you for your great work. I found the phenomenon of increasing the Gpu memory during the training stage, but I don't know which link caused it, does this happen when you're running?

I spent a lot of time trying to solve this problem, and finally found that it was caused by lines 107-109, and l commented it out and there was no longer a problem with memory increments.

Hi, I had the same problem. Could you please provide details of the solution. Thanks for your reply.

my solution is , in ” segmentation/manager.py “，Put lines 107-109 into the following if statement, because “out[mask == 0] = torch.min(out)” takes up a lot of GPU memory if not placed this way

Your help is greatly appreciated.

Thanks for your interest in our projects. I used NVIDIA TITAN RTX for training and inference, which has 24G memory

Hi, thank you for your great work. I found the phenomenon of increasing the Gpu memory during the training stage, but I don't know which link caused it, does this happen when you're running?

I spent a lot of time trying to solve this problem, and finally found that it was caused by lines 107-109, and l commented it out and there was no longer a problem with memory increments.

Hi, I had the same problem. Could you please provide details of the solution. Thanks for your reply.

my solution is , in ” segmentation/manager.py “，Put lines 107-109 into the following if statement, because “out[mask == 0] = torch.min(out)” takes up a lot of GPU memory if not placed this way

Your help is greatly appreciated.

I modified the code according  to the solution  and solved the problem of gradually increasing GPU memory. However, after training for a period of time, the GPU memory suddenly increased and exploded. I wonder  that whether you met this issue and how to fix it.


[WIP-CARBONDATA-382]Like Filter Query Optimization for Dictionary Columns

Like Filter Query Optimization for Dictionary Columns
a) Added pushdown mechanism for the Like filters like startsWith,endsWith and contains so that the respective filters will be processed in Carbon layer itself.
b) This mechanism can provide significant gain in the performance of Like filter queries applied in the dictionary since block and blocklet level pruning will be done in the carbon layer before applying the filters in dictionary columns.
c) Since three new expressions has been added in carbon layer the carbon will be applying the expression only once for startsWith/endsWith/contains filter query, this will make the dictionary lookup also once for applying the Like expression.

Please find the PR build status
http://<IP_ADDRESS>:8080/job/ApacheCarbonManualPRBuilder/576/

Build completed, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/

Build finished.
Build completed, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/

Build Success with Spark 1.6.2, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/1080/

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/1271/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/640/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3102/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4336/


Deal with multi-document yaml files

The Sock shop uses k8s definition files with multiple resources in them. Fluxy messes this up by replacing wrong bits of things.
Solution sketch: break files up by ---, and treat each piece separately, then reassemble at the end.

A user just hit this, with their service and deployment in the same file, btw.

I'd say a lot of users hit this. I hit this from the moment I tried using flux, because initially I'd set up up deployments and services in the same files for convenience.

Fixed by #976.


Update test case

I may be able to use gcov coverage, or auto test script

It's OK to check gcov coverage.


cabal: fix source-repository

I didn't make this a release because it just changes how the project looks in Hackage.

(boo!, fyi, I can still see these; please remove me)

@tommyjcarpenter!!!


Choose which model to consider

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the SQLModel documentation, with the integrated search.
[X] I already searched in Google "How to X in SQLModel" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to SQLModel but to Pydantic.
[X] I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
from typing import Optional

from sqlmodel import Field, SQLModel, create_engine

class Hero(SQLModel, table=True):
    id: Optional[int] = Field(default=None, primary_key=True)
    name: str
    secret_name: str
    age: Optional[int] = None

sqlite_file_name = "database.db"
sqlite_url = f"sqlite:///{sqlite_file_name}"

engine = create_engine(sqlite_url, echo=True)

SQLModel.metadata.create(engine, {Hero})

Description
Instead of using SQLModel.metadata.create_all(engine), it would be good to selectively add models.
Wanted Solution
Why is it useful?
create_all is great for initial setup, but it poses some problems:

Errors when models aren't imported: one can easily forget to import the model, since at no time is it used in this method.  One has to remember that these classes are only interpreted as models if they have been imported.  This leads to errors (as is pointed out in the documentation).  Order matters and that's not implicit.
Difficulty in setting up a conditional set: when one has a plugin system, for instance, allowing to replace some models with others, it can be tricky to explain to SQLModel it should use some models but not others.  The choice is never really explicit.

Suggestion
It might be good to add a create method besides the create_all method.  This method would require the engine and a set of models (as classes).  This way, choosing which model to include in the engine would be straightforward enough.

Does create_all has to go?

I don't think so.  It sure is handy.  But as pointed out, it has its pitfalls too.  Whether one uses the create_all or create method is obviously a personal preference.  I personally like the idea of explicitly forwarding the classes to add, if anything, it makes it explicit what models to consider in the engine and makes forgetting to import them impossible.
Thank you for this tool!
Wanted Code
SQLModel.metadata.create(engine, {Hero})

Alternatives
Obviously, both the method name and the parameter (a set) could be adjusted, but the principle would be the same.
Operating System
Windows
Operating System Details
No response
SQLModel Version
0.0.6
Python Version
3.8.10
Additional Context
No response

@vincent-lg you can still use SQLAlchemy API with SQLModel.
So you could do
`
SQLModel.metadata.tables["hero"].create(engine)
or
Hero.table.create(engine)
`


KAFKA-4375: Reset thread interrupted state in a few places where Inte…

…rruptedException is caught in a thread Kafka didn't start.
See https://issues.apache.org/jira/browse/KAFKA-4375

@hachikuji could you take a look at this when you have time? It's a very similar issue to the other PR at https://github.com/apache/kafka/pull/2110.

LGTM. Thanks for the patch!


Zootopia server lastping takes from Manechat

https://images-1.discordapp.net/.eJwNxVEOgyAMANC7cADKACl4G4IEzZQSWuPHsrtv7-d91D1PtapdZPAKsB1caG6ahWZuVTeidtY8DtaFLsgiuexX7cJgjY0LehNeMWFChwGsdRiNjx7D_7S4AHd_d3q6Hr2p7w8KMCL4.zUD4od8WMGSsZic6XsKnTQcbOS8.png
Reported by Chipmunk

"FYI Midnight Aegis I enabled database chat logging for the Zootopia server after ensuring there will be no leakage between the two." - Cloud Hop, 2016

UPDATE: it works both ways. Confirmed.

To elaborate, lastping will retrieve pings from both Zootopia and Manechat, regardless of what server a user is on when they use the lastping command.

Lastping is now completely isolated