User cannot delete volumes if it's vmgroup gets deleted

Steps:

Create a vmgroup and add a vm to it
Create a volume from the vmgroups's vm
Remove the vm
Delete the vmgroup
Try deleting the volume, operation fails

Volumes should get deleted irrespective of vmgroup being present or not.

Test steps and their output are as follows:

Create a vmgroup and add a vm to it

[root@sc-rdops-vm05-dhcp-129-159:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py vmgroup create --name vmgroup1 --default-datastore=_VM_DS --vm-list=ubuntu-VM2.2
vmgroup 'vmgroup1' is created. Do not forget to run 'vmgroup vm add' to add vm to vmgroup.
[root@sc-rdops-vm05-dhcp-129-159:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py vmgroup ls
Uuid                                  Name      Description                Default_datastore  VM_list
------------------------------------  --------  -------------------------  -----------------  ------------
11111111-1111-1111-1111-111111111111  _DEFAULT  This is a default vmgroup  _VM_DS
41bb861a-7181-4505-bacb-eda799b6c782  vmgroup1                             _VM_DS             ubuntu-VM2.2

Create a volume from the vmgroups's vm

root@sc-rdops-vm02-dhcp-52-237:~# docker volume create -d vsphere:latest --name TestVol1
TestVol1
root@sc-rdops-vm02-dhcp-52-237:~# docker volume ls
DRIVER              VOLUME NAME
vsphere:latest      TestVol1@sharedVmfs-0

[root@sc-rdops-vm05-dhcp-129-159:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py volume ls
Volume    Datastore     VMGroup   Capacity  Used  Filesystem  Policy  Disk Format  Attached-to  Access      Attach-as               Created By    Created Date
--------  ------------  --------  --------  ----  ----------  ------  -----------  -----------  ----------  ----------------------  ------------  ------------------------
TestVol1  sharedVmfs-0  vmgroup1  100MB     13MB  ext4        N/A     thin         detached     read-write  independent_persistent  ubuntu-VM2.2  Fri Jun 23 01:45:22 2017

Remove the vm

[root@sc-rdops-vm05-dhcp-129-159:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py vmgroup vm rm --name vmgroup1 --vm-list=ubuntu-VM2.2
vmgroup vm rm succeeded
[root@sc-rdops-vm05-dhcp-129-159:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py vmgroup ls
Uuid                                  Name      Description                Default_datastore  VM_list
------------------------------------  --------  -------------------------  -----------------  -------
11111111-1111-1111-1111-111111111111  _DEFAULT  This is a default vmgroup  _VM_DS
41bb861a-7181-4505-bacb-eda799b6c782  vmgroup1                             _VM_DS

Delete the vmgroup

[root@sc-rdops-vm05-dhcp-129-159:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py vmgroup rm --name vmgroup1
vmgroup rm succeeded

Verified volume is still there and then tried deleting the volume - failed.

[root@sc-rdops-vm05-dhcp-129-159:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py volume ls
Volume    Datastore     VMGroup  Capacity  Used  Filesystem  Policy  Disk Format  Attached-to  Access      Attach-as               Created By    Created Date
--------  ------------  -------  --------  ----  ----------  ------  -----------  -----------  ----------  ----------------------  ------------  ------------------------
TestVol1  sharedVmfs-0  N/A      100MB     13MB  ext4        N/A     thin         detached     read-write  independent_persistent  ubuntu-VM2.2  Fri Jun 23 01:45:22 2017

root@sc-rdops-vm02-dhcp-52-237:~# docker volume rm TestVol1@sharedVmfs-0
Error response from daemon: get TestVol1@sharedVmfs-0: no such volume
root@sc-rdops-vm02-dhcp-52-237:~# docker volume rm TestVol1@sharedVmfs-0
Error response from daemon: get TestVol1@sharedVmfs-0: no such volume    <<<<<<<<<<<<<<<
root@sc-rdops-vm02-dhcp-52-237:~#

Suggest a vmgroup can't be removed unless

the volumes in the vmgroup are removed, the use case for vmgroups is to segregate users  and support multi-tenancy. Its incorrect to loose user data by allowing the vmgroup to be removed and then not be able to delete that data.
Optionally let the datastores be moved to another vmgroup specified by the user, so the volumes are still accessible. Moving to _DEFAULT doesn't seem correct as it makes user specific data available to all

Should we allow user to remove a vmgroup if volumes in this vmgroup still exist?  Is there any specific user case that need this?  @msterin

We have been discussing this (or similar) issues quite a few times. "Can an admin delete a group if there are object within this group". We should think about use patterns. We need to (1) make it convenient (2) prevent obvious mistakes. It is usually solved with a failure with the following message "This vmgroup still have volumes in it. Please use --force to force deletion. vmgroup and volumes will be deleted" or something like that.
I think "block deletion of vmgroup until all is cleaned up properly" is also a reasonable approach but then we need to give user (in failure message) and easy way to do it.

At any rate, this is NOT A BUG. We should not allow volume deletion from VM not authorized.
So, the solution would be "add VM to the vmgrfoup and then delete the volume" or simply add "volume delete"  command to Admin CLI

@ashahi1, can you check the updates on the this issue and decide if this is something that can be documented vs. needing a code change to prevent vmgroup deletion.

Setting mustfix as the issue is resulting in an inconsistency where volumes can't be deleted by the user (leaks storage) because of wrong user actions in being able to delete the vmgroup without removing the volumes.  Document or code, lets resolve this.

@govint I had a discussion with Sam and we felt that user should not be allowed to delete the vmgroup if their are volumes in it. So it looks like we may have to make some code changes.
//cc @shaominchen


Please several clippy pedantic issues

warning: consider adding a `;` to the last statement for consistent formatting
 --> src/build.rs:6:5
  |
6 |     find_libarchive()
  |     ^^^^^^^^^^^^^^^^^ help: add a `;` here: `find_libarchive();`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

warning: this argument is passed by value, but not consumed in the function body
   --> src/lib.rs:397:41
    |
397 | fn run_with_archive<F, R, T>(ownership: Ownership, mut reader: R, f: F) -> Result<T>
    |                                         ^^^^^^^^^ help: consider taking a reference instead: `&Ownership`
    |
help: consider marking this type as `Copy`
   --> src/lib.rs:75:1
    |
75  | pub enum Ownership {
    | ^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value

warning: item name ends with its containing module's name
  --> src/iterator.rs:47:1
   |
47 | / pub struct ArchiveIterator<R: Read + Seek> {
48 | |     archive_entry: *mut ffi::archive_entry,
49 | |     archive_reader: *mut ffi::archive,
50 | |
...  |
58 | |     _utf8_guard: UTF8LocaleGuard,
59 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions

warning: unnecessary boolean `not` operation
  --> src/ffi/locale.rs:42:24
   |
42 |               let save = if !utf8_locale.is_null() {
   |  ________________________^
43 | |                 unsafe { libc::uselocale(utf8_locale) }
44 | |             } else {
45 | |                 std::ptr::null_mut()
46 | |             };
   | |_____________^
   |
   = help: remove the `!` and swap the blocks of the `if`/`else`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else

warning: borrow as raw pointer
   --> src/lib.rs:459:21
    |
459 |                     (&mut pipe as *mut SeekableReaderPipe) as *mut c_void,
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::addr_of_mut!(pipe)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_as_ptr

warning: borrow as raw pointer
   --> src/lib.rs:516:21
    |
516 |                     (&mut pipe as *mut ReaderPipe) as *mut c_void,
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::addr_of_mut!(pipe)`

warning: explicit `deref_mut` method call
   --> src/iterator.rs:171:26
    |
171 |                         (pipe.deref_mut() as *mut HeapReadSeekerPipe<R>) as *mut c_void,
    |                          ^^^^^^^^^^^^^^^^ help: try this: `&mut *pipe`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_deref_methods

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 3 (66.67%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+1.4%) to 85.5%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/lib.rs
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/ffi/locale.rs
1
94.12%

Totals

Change from base Build<PHONE_NUMBER>:
1.4%

Covered Lines:
342

Relevant Lines:
400

💛  - Coveralls


Update cargo manifest to exclude non rust files

Cargo has been tracking several non rust files and  leads to a poor developer experience. This updates the manifest to exclude these files. Refer issue #85.
Also the package version has been bumped to 2.0.0.

shall we also add /target ?

No, its already managed by cargo.


fix(KFLUXBUGS-96): make the secret forms more clear

Migration of KFLUXBUGS-96 to the new repo.
Assure during the migration we move our latest changes.

All local tests passed

I would keep the commit msg same as in hac-dev repo, will be easier to understand when reading the history.

I would keep the commit msg same as in hac-dev repo, will be easier to understand when reading the history.

Commit message changed to the original

/lgtm

/test all

/lgtm

/ok-to-test

/retest

/retest

/retest


devenv: generate and ship manpages

Usage:
cargo xtask generate-manpages --out-dir OPTIONAL_PATH

We should also make a PR to nixpkgs to generate manpages as part of the next release


[RFR] Updating content for CAA test

Hi @enginehouse, i've started the work on this, and got about half way through it, but have run out of time today. Can you check in with @wotton111 on Monday/Tuesday to go through the remaining bits?
Thanks!

Hello @Koded - @wotton111 has checked it over and is satisfied - just going to tag this repo and get your eyes on it if that is ok?

@Koded - please merge this one first : )


Grand Terrace High School

Hello! As a student at Grand Terrace High School, I am currently taking a AP computer science course that's currently exploring Java programming. I would greatly appreciate it if I could use this service for creating Java code without having to pay for school.

On behalf of my school and the entire district, we would GREATly appreciate if you allowed us to be on the list!

@NotBlackrus lib/domains/cjusd/Grand: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@NotBlackrus Please let us know what is your email address template. Is it<EMAIL_ADDRESS>I appreciate it very much if you reply this comment or change the filename in your request to the one conforming the repository rules. Thank you!

@NotBlackrus I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!

@NotBlackrus I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!

oh! oh! and I had just saw this, I am so so sorry! The answer to that question was simply just @my.cjusd.net


Incompatible dense layer error in keras

My input is an series of videos, 8500 in number. Each video is fed to LSTM as a series of 50 frames, each frame having 960 pixels.
So the input dim is 8500,50,960
There are 487 possible output classes possible, so the output dimension is 8500,487.
But when I run the following code, I am getting these errors in keras.
Any help is greatly appreciated. Thanks!
(8500, 50, 960)
(8500, 487)
Creating model..
Adding first layer..
Adding second layer..
Adding output layer..
Traceback (most recent call last):
File "/Users/temp/PycharmProjects/detect_sport_video/build_model.py", line 68, in
model.add(Dense(487, activation='softmax'))
File "/Users/temp/anaconda/lib/python2.7/site-packages/Keras-1.0.3-py2.7.egg/keras/models.py", line 146, in add
output_tensor = layer(self.outputs[0])
File "/Users/temp/anaconda/lib/python2.7/site-packages/Keras-1.0.3-py2.7.egg/keras/engine/topology.py", line 441, in call
self.assert_input_compatibility(x)
File "/Users/temp/anaconda/lib/python2.7/site-packages/Keras-1.0.3-py2.7.egg/keras/engine/topology.py", line 382, in assert_input_compatibility
str(K.ndim(x)))
Exception: Input 0 is incompatible with layer dense_1: expected ndim=2, found ndim=3
from keras.models import Sequential
from keras.layers import LSTM, Dense
import numpy as np
from PIL import Image
import os

def atoi(video):
    return int(video) if video.isdigit() else video

def natural_keys(video):
    return [ atoi(c) for c in os.path.splitext(video) ]

input_data =np.zeros((8500,50,960))

video_index = 0
data = 'train'
video_list = sorted(os.listdir('/Users/temp/PycharmProjects/detect_sport_video/' + data + '_frame_resize1/'))
video_list.sort(key=natural_keys)

for video in video_list:
    if video != '.DS_Store':
        frame_index = 0
        frame_list = sorted(os.listdir('/Users/temp/PycharmProjects/detect_sport_video/' + data + '_frame_resize1/' + video + '/'))
        frame_list.sort(key=natural_keys)
        for frame in frame_list:
            image = np.asarray(Image.open('/Users/temp/PycharmProjects/detect_sport_video/' + data + '_frame_resize1/' + video + '/' + frame))
            image = image.reshape(image.shape[0] * image.shape[1],3)
            image = (image[:,0] + image[:,1] + image[:,2]) / 3
            image = image.reshape(len(image),1)
            image = image[:960]
            image = image.T
            input_data[video_index][frame_index] = image
            frame_index += 1
        video_index += 1

print input_data.shape

cnt = 1
output_classes = []
with open('/Users/temp/PycharmProjects/detect_sport_video/sports-1m-dataset/' + data + '_correct_links.txt') as input_file:
 while cnt <= 8500:
        output_classes.append(int(input_file.readline().split()[2]))
        cnt += 1
output_data =np.zeros((8500,487))
output_index = 0
while(output_index < 8500):
    output_data[output_index,output_classes[output_index]] = 1
    output_index += 1

print output_data.shape

print("Creating model..")
model = Sequential()
print("Adding first layer..")
model.add(LSTM(100, return_sequences=True,
               input_shape=(50, 960)))

print("Adding second layer..")
model.add(LSTM(100, return_sequences=True))

print("Adding output layer..")
model.add(Dense(487, activation='softmax'))

print "Compiling model.."
model.compile(loss='categorical_crossentropy',
              optimizer='RMSprop',
              metrics=['accuracy'])

print "Fitting model.."
model.fit(input_data,output_data,
          batch_size=50, nb_epoch=100)

Also, If I try to print model.output_shape after adding every LSTM layer, the output I get is (None, 50, 200) but it should have been (None,200). Thats where the problem is. But I dont know why am getting (None,50,200). Any ideas?

It's because of return_sequences=True. If your final output is not supposed to be sequential, you have to have return_sequences=False in the last LSTM layer before feeding it into Dense. At least that's how I understand what you're trying to do.


How many and what kind of gpus needed to run the example?

For every script or project in the example directory, could you please tell us how many and what kind of gpus needed to run the experiments? Thanks a lot.

Depends a lot on the type of model you want to train. For most examples you can use a small model (e.g. GPT-2) and a single small GPU (e.g. T4).

Depends a lot on the type of model you want to train. For most examples you can use a small model (e.g. GPT-2) and a single small GPU (e.g. T4).

Can I finetune 3b model on T4?

Yes, if you use PEFT that should work!


"Preference" not respected when bot hears message that matches two handlers

It seems that the "preference" argument as described here does not work as documented:
https://github.com/WebexCommunity/webex-node-bot-framework#framework
The documentation says:

Specifies preference of phrase action when overlapping phrases are matched. On multiple matches with same preference, all matched actions are excuted. On multiple matches with difference preference values, only the lower preferenced matched action(s) are executed.

However, when implemented like this:
framework.hears('help', (bot: any, trigger: any) => {
    bot.say(framework.showHelp());
  }, 'help - shows information about commands I understand', 1);

  framework.hears(/.*/gim, (bot: any, trigger: any) => {
    bot.say('I didn\'t quite understand that.');
  }, null, 2);

Sending the message "help" results in it responding with "I didn't quite understand that" instead of returning the help message.

Apparently, this is more of a documentation issue. It isn't clear from the docs that if you don't want a help message but you do want a preference, you should just omit the help (rather than set to null as I did above). So the correct way to do this would be:
framework.hears('help', (bot: any, trigger: any) => {
    bot.say(framework.showHelp());
  }, 'help - shows information about commands I understand', 1);

  framework.hears(/.*/gim, (bot: any, trigger: any) => {
    bot.say('I didn\'t quite understand that.');
  }, 2);

@RobM-ADP, thanks very much for the feedback.   I'll take a look at the docs to see if this can be made clearer as I merge the changes in your recent PR.


mmark: 2.2.30 -> 2.2.31

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/mmarkdown/mmark/releases.
meta.description for mmark is: A powerful markdown processor in Go geared towards the IETF
meta.homepage for mmark is: https://github.com/mmarkdown/mmark
Updates performed

Golang update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.2.31 with grep in /nix/store/0v7sbxhjc7c0p5gh1vblkfyn0swyv1vd-mmark-2.2.31
found 2.2.31 in filename of file in /nix/store/0v7sbxhjc7c0p5gh1vblkfyn0swyv1vd-mmark-2.2.31

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
mmark

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0v7sbxhjc7c0p5gh1vblkfyn0swyv1vd-mmark-2.2.31 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mmark https://github.com/r-ryantm/nixpkgs/archive/2ea402c369ca7dc3c7c97863daa3d831a4151c44.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0v7sbxhjc7c0p5gh1vblkfyn0swyv1vd-mmark-2.2.31
ls -la /nix/store/0v7sbxhjc7c0p5gh1vblkfyn0swyv1vd-mmark-2.2.31/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

mmark

Maintainer pings
cc @yrashk for testing.

Result of nixpkgs-review pr 215830 run on aarch64-darwin 1

1 package built:

mmark


[Feature Request] disable key lookup

Hi,
in my app I only want to use keys. So I do not want to look up keys given a mail address. If the key (give as string) does not work I would like an exception to be raised.
I think to implement this one would need to warp this line in a options check and raise some error, if the key couldn't be imported. It might well be that there are other things that have to be changed for this.

In the line you reference, k is the fingerprint(s) from the imported key-material you provided. If that lookup results in an empty set, GpgmeHelper#17 raises an exception.
To me that looks like just what you want —  right?

Nope. If I call GPGME::Key.import(k).imports.map(&:fpr) with an invalid key (pub-key as string) I get an empty Array. Then
https://github.com/jkraemer/mail-gpg/blob/cbe381f9d982ce92bee960a5b4dc423be2addcee/lib/mail/gpg/gpgme_helper.rb#L126
Will look up the recipient as fallback.

As far as I understand, the code of GpgmeHelper doesn't work as you described, because
[] || 'something'
=> []

But the code actually does behave similar to your description (and not like I described), because
GPGME::Key.find() returns all known keys if given an empty array:
GPGME::Key.find(:public, [], :encrypt)
=> [#<GPGME::Key pub ...]

So apparently a new option is required to stop the code-flow if no (usable) key could be imported from the given material.
It would also make the code's behaviour less surprising, in my eyes. So I second this request.

Sorry I'm actually a Pythonist and thought
[] || 'something'
=> 'something'

But anyway. Just as you said I just noticed that (only on some systems) mail-gpg encrypts a mail with all pub-keys in the key ring if given an invalid key (#31)

Does that commit above (which is also part of just released v0.3.2) solve your problem or would you still require an explicit option?

I think that might not have been enough yet to really raise an error in case of no keys. please try it out with master to include the compact call I just added.

Ok, sorry for taking so long to give you feedback. When given an invalid key Mail::Gpg::GpgmeHelper.keys_for_data([mail_address], {mail_address => brokenkey}) will lookup the mail address in the key chain and return only that key. That's an improvement over returning all keys in the key chain but as said, I'd expect an error to be raised here.
Note: The result will be an empty array when the mail address is not stored in the key chain.

Still no error but the just-released version 0.4 should not use any keys you did not specify in the :keys option.
Regarding the option to raise an error, just to make sure I get this right: you want an error to be raised whenever there is a recipient for whom no valid key was present in the :keys argument, correct?

That would be one option (like force_key_import: true or so). The other way (which I thought of in the first place) is to raise the error, when there is a key for a recipient specified for in :keys but it cannot be imported.
Like so:
mail to: [mail_a, mail_b], gpg: {encrypt: true, keys: {mail_a => valid_key}} would use that valid_key for mail_a and look up the key for mail_b.
However, mail to: [mail_a, mail_b], gpg: {encrypt: true, keys: {mail_a => invalid_key}, validate_key: true} (I just made up that option and it's name) would still import the key for mail_b but raise an exception as soon as it tries to import the invalid_key and fails in doing so. I even think, that this behavior should be the default. Silently using fallbacks when the parameters are invalid isn't good programming style I guess. So probably there should be an option keychain_fallback or so which makes gem behave like it does now.


[Azure.Core] Provide common configuration store for process-wide configuration values

Some settings are 'global' in the sense that it makes sense to share the same value for all instances of all clients:
[ ] Log level for the 'azure' root logger
[ ] Proxy settings
[ ] Telemetry enabled/disabled
[ ] Tracing enabled/disabled
azure-core should provide entry points for getting/setting these shared configuration values. Default values (values not explicitly specified) can be specified using environment variables.
See https://github.com/Azure/azure-sdk/pull/328 for more details.

@johanste What re:

The Azure SDK can be configured by a variety of sources, some of which are necessarily language-dependent

System settings
Environment variables
Global configuration store (code)
Runtime parameters

What does it mean for a library (in Python, at least) to be configured by runtime parameters? I would expect those only to enter in to play at the application level, and that a the application would be responsible for preferring runtime args (because only the app knows what those flags are and how to get them) in favor of a Settings object.
That is, I'd normally only expect a Settings object to be responsible for mediating 1-3 and that an application would be responsible for mediating between Settings and 4

merged


[9.x] Prompt to create MySQL db when migrating

This PR is the MySQL counterpart to https://github.com/laravel/framework/pull/43867

# No prompt, just attempts to create the file.
# If it fails the exception is shown.

php artisan migrate --force

# No prompt and the exception is shown.
# This is the same as the current behaviour.

php artisan migrate --force

@timacdonald what happens when the user does not have permissions to create additional databases?

If any failure occurs the original exception message would be shown.

when i was moving from rails to learn laravel I was missing this suggestion ... thanks so much for adding it ❤

It's finally come true, I love that, thanks laravels


Revert "Introduce deadlines for sync RPC stubs"

This reverts commit 70112cb226119c7bb73f8ce0c25252d099cdd840.

alluxio-bot, merge this please

@ZacBlanco @ZhuTopher FYI. I reverted this as I believe keep-alive configuration could help better. Testing that approach in parallel.

@ZacBlanco @ZhuTopher I wanted to follow up with why I reverted this change. Just FYI...
The reason that I introduced deadlines in the first place was that RPC connections to leading master were getting hung when the leader is switched. So those RPCs were not returning back to callers even though there's no RPC server on the target anymore. This was happening randomly, and was happening more frequently in containerized environments.
Attaching deadlines to stubs means that the stub will wait for configured time before it receives a response, or timeout otherwise. Even though this was solution to hung connections on old masters, this was not desired considering some calls take long time, and some calls will take longer than expected when target master is under heavy load. Overall, deadline means a deadline and it's so preventive for adaptability under load. So I reverted it.
As I mentioned, I wanted to try keep-alive settings and I did. See https://github.com/grpc/grpc/blob/master/doc/keepalive.md
By enabling keep-alive for RPC clients, I was able to get the same outcome with this PR without putting a hard bound on timing requirements of RPCs. Just putting below property was sufficient to avoid hung connections.
alluxio.user.network.rpc.keepalive.time=30sec (It's set to INT.MAX by default which means no keep-alive pings are employed.)


datetime in nanos

(@PSeitz I unassigned thsi ticket, as you have work on your plate right now and someone else might be able to take over it earlier. If you hvae time to tackle that you can reassign it to you)


Document that map dimensions are in tiles

And not, for example, in pixels.

Looks helpful, thanks!


Return key is ignored a couple of times before being accepted.

VSCode Version: 1.5.3
OS Version: Windows 10 (insider preview build 14939)

Steps to Reproduce:

open C document
switch away from VSCode, wait a few seconds
switch back to VSCode
press return/enter key and no new line is started, keep pressing until new line appears, then works normally until switching away again.

Duplicate https://github.com/Microsoft/vscode/issues/12929


Additional tag features: Design review

What will this achieve?
Improved interaction and visuals

How will success be measured?
Design review

Additional information

This component should be available as "Additional tag features" under "Canary" or "Released" rather than "Internal"
The tooltip should appear on hover
Should the focus immediately go to the "View all tags" link? It looks a bit jarring. And it may not make sense to do so on hover. If the user is navigating with keyboard, similarly I would expect the focus to remain on the element they are on, which is the tag with "+12" and let them tab into the tooltip link when/if they want to.
The modal design doesn't match what is seen on the website (and probably a good thing...) Worth a check in with the designer, Courtney Banning, to ensure alignment between the component and published guideline.
In the storybook modal, the elements should span 100% of the width, not 80%, which is the guideline only for text within a modal. Components should span full width.

https://pages.github.ibm.com/cdai-design/pal/components/additional-tag-features/#behavior

So just to sum up:

It is the design in question
AdditionalTagFeatures is a rubbish name hence TagSet
This was what was implemented https://ibm.invisionapp.com/share/ANO0H9RHEGK#/screens/319719111
I forgot about the epic, hence internal
Note in the epic the reasons for the current interactions. T
The issues I raised discussed by design here https://github.ibm.com/CloudIntegrationDesign/DesignSystemAdoptionGuild/issues/92 but not reported back to the epic.

I still maintain that

The tooltip like popup if ugly and relies on Tags being text only. They are only by convention.
The modal, when viewing all, looks worse if not showing as tags or having a filter. It also assumes tags are text.

With regards to the design review

AdditionalTagFeatures manages to be verbose without providing any useful information as to what the component is. This is why TagSet was used, we could use TagGroup, TagList.
Hover is a poor interaction that does not work well for interactive elements such as this one. Carbon defines the clickable interactive tooltip for this scenario. Hover does not transfer focus to the item being hovered over and keyboard interactions will not transfer into the tooltip.
See 2. Plus, this is possible but not Carbon for an interactive tootlip.
Already discussed see epic, invision and issue.
Can you clarify, not sure I understand the point you are making.

@courtney-banning has given her approval of the implementation with PR #774
Note: Courtney has asked for the above github handle to be used.


CLI command alignment

Investigate what changes (if necessary) are needed for remaining commands given how we are clearing the way in other areas.  For instance, we are removing the Flux binary.

gitops check will no longer check the Flux version.

Pesto was onboard with removing auth credential on CLI add/delete cluster commands.


Replace Python exec statements where possible

I discovered that there is a number of exec(str) statements that import from other modules. I discovered that import_module from importlib is a safer alternative, e.g.
Class = getattr(import_module("package.module"), "ClassName")

Closed by #28


Sidebar colors

Provide a description of the new feature
The current version of Bloom theme doesn't exactly change the sidebar colors and keeps the standar color scheme rules(?), which means the sidebar buttons have a background that follows the "main" color scheme and not leaving the whole sidebar color solid like the old "Fluent" theme...
So i expect the sidebar doesn't have the "main"  color on his buttons backrounds and follows the "sidebar" color, just like the old "Fluent" theme.
Current --> What i expect:

Specifications:
Spotify v<IP_ADDRESS>7
Spicetify v2.29.1
Additional Information
No response

will be changed only in fluent-dark and fluent-light color schemes
screenshots are old and wip

will be changed only in fluent-dark and fluent-light color schemes
screenshots are old and wip

I see... So there's gonna be new color schemes like fluent-dark and fluent-light?
So, those screenshots are a WIP from a future "Bloom" update or something? Also... That "Mica" effect is just a wallpaper inside spotify app? Or did you used a version of Spotify where is compatible with MicaForEveryone? I ask because i'm curious those buttons of minimize, maximize and close buttons aren't black as normally is... Like this one:

@AndresF2016 yes! we were developing a way to simulate the mica feeling for our users! it didn't go quite well, as you know spotify is a chromium-based web-app. using this type of simulations might cause increases in recourse usage from our users' pcs.
We lost between the decision whether to make it beautiful or to protect the principle called Calm and Cleen! so like always, we had to surrender in front of fluent2 principles


How can I add a default where clause in the stream?

I wanted to add a where clause whenever a stream is made, but I do not know if this is possible. If so, how can I do it? The aim would be to change in the speedment base code.
For example, if I do this stream:
LineitemManager lineitem = app.getOrThrow (LineitemManager.class);
         DoubleSummaryStatistics intsum = lineitem
                 .stream ()
                 .filter (Lineitem.L_SHIPDATE.greaterOrEqual (sqlDate)); (....)

He should return the result of:
LineitemManager lineitem = app.getOrThrow (LineitemManager.class);
         DoubleSummaryStatistics intsum = lineitem
                 .stream ()
                 .filter (Lineitem.L_SHIPDATE.greaterOrEqual (sqlDate))
                 .filter (Lineitem.L_DISCOUNT.lessThan (1.2)); (...)

You could always add a custom method in LineitemManager that does this. For example:
   Stream<LineItem> myStream() {
        return stream().filter(Lineitem.L_DISCOUNT.lessThan (1.2));
   }

You can also write your own "MyLineitemManager extends LineitemManager" that overrides stream() and applies an extra filter. This class is then injected in the ApplicationBuilder and will replace the generated one.

Thank you :)


Add Elastic Fabric Adapter (EFA) metric collection to awscontainerinsightreceiver.

Add Elastic Fabric Adapter (EFA) metric collection to awscontainerinsightreceiver.
The new component scrapes hardware counters from /sys/class/infiniband on disk.  The layout of that directory is:
/sys/class/infiniband/<device name>
└── ports
    └── 1
        └── hw_counters
            ├── rdma_read_bytes
            ├── rdma_write_bytes
            ├── rdma_write_recv_bytes
            ├── rx_bytes
            ├── rx_drops
            └── tx_bytes

These are cumulative counters and so they are converted to deltas before sending down the pipeline.
We sum up data from all ports.
The device data is joined with data from the kubelet podresources API which tells us which container a given device is
assigned to.
The metrics are reported at container, pod, and node levels.
This commit also refactors some metric decoration code from cadvisor to a common localnode decorator, intended to be
used by any awscontainerinsightreceiver component that gathers metrics from the local node (as oppoosed to e.g. the k8s
control plane scraper).  This is because we want to share the logic of populating PodName, Kubernetes labels, etc.
I also renamed RawContainerInsightsMetric to CIMetricImpl for brevity.
See also accompanying cloudwatch-agent PR: https://github.com/aws/amazon-cloudwatch-agent/pull/1098

For latest revision, I squashed all my commits together and rebased on aws-cwa-dev.
This got rid of the history... if you want to see the previous state of my PR, you can view the tree at: https://github.com/straussb/opentelemetry-collector-contrib/tree/db5503cb45f8e78b169da51c95bc4489f55db3ff
And compare to current state at: https://github.com/straussb/opentelemetry-collector-contrib/compare/db5503cb45f8e78b169da51c95bc4489f55db3ff..efa
The files that had rebase conflicts were:

internal/aws/containerinsight/const.go
receiver/awscontainerinsightreceiver/internal/prometheusscraper/decoratorconsumer/decorator.go
receiver/awscontainerinsightreceiver/internal/stores/utils.go
receiver/awscontainerinsightreceiver/internal/stores/utils_test.go
receiver/awscontainerinsightreceiver/receiver.go

So review those a bit more carefully.
Since last review, I also added a bit more logic in efaSysfs.go and podresourcesclient.go to check permissions/ownership of /sys/class/infiniband and the kubelet podresources socket, for security.


Integrate consumer group from ui-components

Signed-off-by: hemahg<EMAIL_ADDRESS>What this PR does
Integrate consumer group from ui-components
Which issue(s) this PR fixes
https://issues.redhat.com/browse/MGDSTRM-9445
Depends on https://github.com/redhat-developer/app-services-ui-components/pull/597

closing the PR in favor of https://github.com/redhat-developer/rhosak-ui/pull/69


create a template for new docs

See convo in #485

@michelleN, can we close this now that we have a makefile target added to simplify this from #485

Closing this based on @kate-goldenring 's comment.  @michelleN feel free to reopen if appropriate.


Can't ignore ".venv/"

Just discovered this tool, looks very cool! Thanks for developing it!
I'm running ptw . and I want to ignore any changes in my virtualenv (installed at .venv/ in the project root).
I've tried

`ptw . --ignore_patterns ".venv/"
`ptw . --ignore_patterns ".venv/*"
`ptw . --ignore_patterns ".venv*"

but none of them work.
I think I have identified the issue. In watcher.py in _is_event_watched there is call to match_any_paths.
In match_any_paths, case_sensitive is an optional keyword, but it defaults to True. I'm on a Windows machine, so all my paths are being converted to a PurePosixPath.

@KPLauritzen,
Thank you for reporting this and opening the PR!
I currently do not have a Windows machine to test proposed changes. I will find time a bit later to test it and get back.

@KPLauritzen I am not sure case sensitivity is the root cause: If your venv dir is called .venv (lower case) then it should match on Windows if searched for .venv\* (lower case)
Have you tried prefixing your path with .\?
ptw reports changed paths and for me these do start with .\ on Windows (e,g,: .\.venv\.... Prefixing solved the problem in my case.

I am closing this issue for now, because introducing case insensitive approach can lead to other problems as was mentioned in the PR
@KPLauritzen Feel free to reopen if you will find more information about your case


fix: upgrade page for audit logs with correct data

Description
This PR fixes:

content that was repeated
has new images
removes comments
brings text to messages file

Post fix

@vasanth-appsmith the images are still not up to date. Could you please share the latest images here?

Here are the updated Upgrade Hooks for the Audit Logs

Content is changed to match with PR - Notion Doc.
Changed the image for each of the carousels.

Figma
@IAmAnubhavSaini  The graphics are attached here.
Updated.zip

/ok-to-test

/ok-to-test sha=ea3283f

/ok-to-test sha=ea3282f

/perf-test ref=rhito/feat-create-run-meta-before-test-starts-compare-lt-st-for-prev-runs


OSD-7065: Don't rebuild/repush an existing image

To support by-digest pulls of this repository's image, we must never rebuild an existing image. Explanation for this weirdness noted within.
OSD-7065

/lgtm


CORE-12911 Use only class bundle name for evolved classes

Ultimately Corda 5 should use Corda-CPK-Cordapp-Name from the CPK metadata to identify a class type as being the same as another version of that class. See CORE-13259. This will be written in the evolvable tag. This change goes part way to supporting that in the evolvable tag.
Right now CorDapp developers cannot set this metadata, the gradle plugin always sets it to bundle symbolic name, so offering full support for Corda-CPK-Cordapp-Name is not yet possible. For Corda 5.0 we only use the class's bundle symbolic name to find sandboxes. Future versions of the platform will still write the class's bundle name and therefore be compatible with platforms running on 5.0.
We also write bundle symbolic name as Corda-CPK-Cordapp-Name in 5.0 meaning future versions of the platform reading that back will get a sensible answer - this is the same as the proposed default in future versions in fact.

I've logged some usage of the SandboxGroupImpl whilst executing transactions, I can see the evolvable tag being used, for example
Sandbox getClass
className: com.r3.corda.testing.packagingverification.contract.SimpleState
EvolvableTag
bundleName: net.corda.packaging-verification-contract-v1
Sandbox getClass
className: com.r3.corda.testing.packagingverification.contract.TransferCommand
EvolvableTag
bundleName: net.corda.packaging-verification-contract-v1

and also static tags in use (presumably something like Kryo deserialization during flow resume?)
Sandbox getClass
className: com.r3.corda.testing.packagingverification.TransferStatesFlow
StaticTag
bundleName: net.corda.packaging-verification-app-v1

So it all appears to work. I can't 100% confirm the sandboxes are matched by Corda-CPK-Cordapp-Name for evolvable tags rather than bundle symbolic name because they are always identical in 5.0.


[BugFix] Fix Model Load in Android

This PR fixed the model loading error because of argument mismatch. The bug was due to the KVCache config not being passed to the reload function in Android.
This should fix issues #1785 and #1741.

@Kartik14
Sorry, but a new error is occurring...
Please check the error below.
I re-downloaded and started the repository via 'git clone --recursive https://github.com/mlc-ai/mlc-llm/' .
Similarly, this error only occurs in the chat in Llama2.

MLCChat failed

Stack trace:
org.apache.tvm.Base$TVMError: TVMError: Function vm.builtin.paged_attention_kv_cache_attention_with_fused_qkv(0: relax.vm.PagedAttentionKVCache, 1: int64_t, 2: double, 3: runtime.NDArray, 4: runtime.NDArray) -> void expects 5 arguments, but 4 were provided.
Stack trace:
  File "/mnt/d/mlc-llm/3rdparty/tvm/include/tvm/runtime/packed_func.h", line 1908

at org.apache.tvm.Base.checkCall(Base.java:173)
at org.apache.tvm.Function.invoke(Function.java:130)
at ai.mlc.mlcllm.ChatModule.prefill(ChatModule.java:63)
at ai.mlc.mlcchat.AppViewModel$ChatState$requestGenerate$1$1.invoke(AppViewModel.kt:667)
at ai.mlc.mlcchat.AppViewModel$ChatState$requestGenerate$1$1.invoke(AppViewModel.kt:667)
at ai.mlc.mlcchat.AppViewModel$ChatState.callBackend(AppViewModel.kt:548)
at ai.mlc.mlcchat.AppViewModel$ChatState.requestGenerate$lambda$4(AppViewModel.kt:667)
at ai.mlc.mlcchat.AppViewModel$ChatState.$r8$lambda$lluIrcsPALEW5nCb2tohZYadhTY(Unknown Source:0)
at ai.mlc.mlcchat.AppViewModel$ChatState$$ExternalSyntheticLambda3.run(Unknown Source:6)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:487)
at java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
at java.lang.Thread.run(Thread.java:1012)

Error message:
TVMError: Function vm.builtin.paged_attention_kv_cache_attention_with_fused_qkv(0: relax.vm.PagedAttentionKVCache, 1: int64_t, 2: double, 3: runtime.NDArray, 4: runtime.NDArray) -> void expects 5 arguments, but 4 were provided.
Stack trace:
  File "/mnt/d/mlc-llm/3rdparty/tvm/include/tvm/runtime/packed_func.h", line 1908

I think PR #1784 migh be related to this. Looks like the attention score scaling parameters is not being passed to paged_attention_kv_cache_attention_with_fused_qkv. I will check in more detail.


Fix a crash in the mandatory inliner related to optimization remarks

Even if a function's type has a self parameter, it may be specialized and the function argument is actually not there anymore.
rdar://103065348

@swift-ci smoke test


Mentions

@MatthewOakley please go over the changes rq'd

Hi @ilianac , please try and merge with master and then you're free to merge into master.


Integrate LANGUAGE.json with React app (unify what languages are available)

LANGUAGES.json is a new file containing a JSON object listing all available languages. This will be the point of contact for language information for both the static content, and the React app (when building).

Completed. The React app, when compiling, uses the LANGUAGES.json file to work out what languages are available.


Ability to set scopes?

Instead of having a preset scope value would it not be better to set it using a variable so in future if there are any changes to scope values we can just update that variable and continue using the api.
P.S.
The scopes have already been updated and the current one set in the api does not work for new apps.
Here is the page with the new scopes.

Great point. I'll get a change pushed out today to support this. Be on the lookout for a PR so I can get your feedback.

@Mwesome See PR https://github.com/alex-phillips/clouddrive-php/pull/4


Error running  setup_env.sh Channel unknown, 3.3.1.

Hello,
Yesterday i installed setup_flutter_workspace.py  within parallels Ubuntu  on my mac 12.6 and all went fine - very nice
Today I tried running setup_env.sh  which complained building flutter  with Channel unknown, 3.3.1.
and when running qemu_run a new window launches then immediately closes.
Today flutter bumped stable from 3.3.1 to 3.3.2 and i patched accordingly  as ped working fine
I don't really want to mess about on my end, so was wondering can you bump meta-flutter to 3.3.2
please advise
best regards
parallels > . ./setup_env.sh
SCRIPT_PATH=/home/parallels/Documents/GitHub/meta-flutter/tools

Setting FLUTTER_WORKSPACE to:
/home/parallels/Documents/GitHub/meta-flutter/tools

Building flutter tool...
[!] Flutter (Channel unknown, 3.3.1, on Ubuntu 20.04.5 LTS 5.15.0-46-generic, locale en_US.UTF-8)
! Flutter version 3.3.1 on channel unknown at /home/parallels/Documents/GitHub/meta-flutter/tools/flutter
! Upstream repository unknown
• Framework revision 4f9d92fbbd (9 days ago), 2022-09-06 17:54:53 -0700
• Engine revision 3efdf03e73
• Dart version 2.18.0
• DevTools version 2.15.0

I can bump meta-flutter.  Keep in mind AGL Needlefish is locked to 3.3.1.  Referencing something being on a channel such as stable represents a rolling tip of tree.  Having a rolling commit for a release is not desirable.

Also the channel error is normal. It's just saying you're not on the latest (tip off tree) for that channel.

https://github.com/meta-flutter/meta-flutter/pull/192

Rolling tip not desirable I can appreciate that, I should have  emphases my real issue is that qemu_run would launch a new window then immediately close it, I just assumed issue was flutter release related, but now I'm not so sure, perhaps its qemu related. I will try again today and advise regards

You can set the bash debug flag in setup_env.sh and examine the output.
Are you running from a container?  It may require custom tailored qemu flags.  I've not tried that.

Working thank you i had 2 issues

Multiple flutter installs
The original snap flutter install was conflicting  with new meta-flutter/tools/flutter install once i separated those setup_flutter_workspace.py ran correctly

invalid kvm args  launching qemu-system-x86_64
whilst debugging setup_env I realised i hadn't yet enabled kvm on my mac  so removed kvm  options
"-enable-kvm -cpu kvm64"  and qemu-system-x86_64 started fine.
I'll look at enabling Intel® VT) if necessary

Once up i could navigate to meta-flutter/tools/app and launch gallery, flutter_homescreen, flutter_animated_background ( failed missing lib/main.dart), flutter_secure_storage (failed missing some things) and ped
Couple of points/ questions ?
a) Qemu is grabbing and lockng my mouse any idea how to stop that ?
b) How do i run using profile mode so as i can check Flutter DevTools as debug mode is kill it ?
c) Why only 5 apps where are the rest from /recipes-graphics/flutter-apps - i'd like to play around with all of them?
d) how often do i need to re-run  setup_flutter_workspace and rebuild flutter-auto ?
e) When launching PED it is spinning  on "Detecting Locations" which is a bit of a worry, but it's also giving  different feedback depending upon which run option i use Toyota or AGL. As follows Toyota throws an exception whilst AGL does not, and running on Ubuntu desktop-linux  just works fine, obviously i'm not asking you to debug this for me,  but I do need your help what can i enable within qemu system logging for Toyota and AGL to display more information on what's going on.

Launching  ped using AGL
[2]: AGL x86_64 QEMU Image (AGL-qemu)
display bunch of stuff .../... then
[INFO:engine.cc(94)] (0) flutter: [2022-09-18 09:26:58.795786]: DEBUG: LocationDataSource : Checking Location Service Enabled
[INFO:engine.cc(94)] (0) flutter: [2022-09-18 09:26:58.820782]: DEBUG: LocationDataSource : Location Service is Enabled ? true
[INFO:engine.cc(94)] (0) flutter: [2022-09-18 09:27:02.195128]: DEBUG: SplashScreen : Backend is not under maintenance.
then just sits here until i kill it
launch ped using Ubuntu linux-desktop (it just works)
display bunch of stuff .../... then
[2022-09-18 18:56:25.241]: DEBUG: LocationDataSource : Checking Location Service Enabled
[2022-09-18 18:56:25.243]: DEBUG: LocationDataSource : Location Service is Enabled ? true
[2022-09-18 18:56:25.380]: DEBUG: SplashScreen : Backend is not under maintenance.
[2022-09-18 18:56:33.621]: DEBUG: LocationDataSource : Location found as : Latitude: -33.865913, Longitude:<PHONE_NUMBER>
[2022-09-18 18:56:33.621]: DEBUG: LocationDataSource : Overriding the actual location with static one, as the Browser / Linux does not allow mocking the location
[2022-09-18 18:56:33.622]: DEBUG: SplashScreen : latitude : -33.865107, longitude : 151.205282
thank you very much for writing this, it's really quite amazing,
I see it as a 1/2 point resolve most if not everything before your app hits AGL proper
please advise best regards
Bern

1. Multiple flutter installs
   The original snap flutter install was conflicting  with new meta-flutter/tools/flutter install once i separated those setup_flutter_workspace.py ran correctly

There are cases of conflict:

Running script from terminal in VS Code which has Flutter tools enabled.  The Flutter tools has a file watcher running, and post repo clone will attempt to runs hooks using a mis-matched SDK version.  The workaround here is to close any IDE with Flutter tools, and run setup_flutter_workspace.py from a fresh terminal window.
Multiple instances of flutter in the path.  The script will attempt to remove one instance from PATH if it can be resolved.  The new workspace SDK path is prefixed during runtime of script.  Running source ./setup_env.sh is the expected method for normal use.  In general you should limit the number of folders in your system path regardless.

If you are moving to using a Flutter Workspace, there is no reason to have the flutter snap installed.  The workspace construct replaces the need for other instances of the Flutter SDK.  So your best bet is to remove it.

2. invalid kvm args  launching qemu-system-x86_64
   whilst debugging setup_env I realised i hadn't yet enabled kvm on my mac  so removed kvm  options
   "-enable-kvm -cpu kvm64"  and qemu-system-x86_64 started fine.
   I'll look at enabling Intel® VT) if necessary

I would only recommend running a container with HW Hypervisor support.  While it may work with only software, there are performance penalties.

Once up i could navigate to meta-flutter/tools/app and launch gallery, flutter_homescreen, flutter_animated_background ( failed missing lib/main.dart), flutter_secure_storage (failed missing some things) and ped

The example projects are not in the root of some of the projects.  The launch.json generated for VS Code have the correct pubspec path.  Switch to debugger view and select the drop down for desired target, then select the play icon.

a) Qemu is grabbing and lockng my mouse any idea how to stop that ?

Ctrl+Alt+G should release the mouse grab.

b) How do i run using profile mode so as i can check Flutter DevTools as debug mode is kill it ?

Steps for running profile mode are here:
https://gerrit.automotivelinux.org/gerrit/gitweb?p=AGL/meta-agl-devel.git;a=blob;f=meta-agl-flutter/README.md;h=86b4f75b71fb070963ae2bbda52a1a3500003e87;hb=HEAD

c) Why only 5 apps where are the rest from /recipes-graphics/flutter-apps - i'd like to play around with all of them?

At the time the AGL flutter apps had not yet landed, and for some reason they ended in another layer.  Unclear why Scott did that.  Feel free to create your own workspace config JSON and add as needed.

d) how often do i need to re-run setup_flutter_workspace and rebuild flutter-auto ?

Anytime you need/want to jump Flutter SDK versions, or pickup latest flutter-auto or AGL-QEMU image.  e.g. A few days ago I moved the meta-flutter AGL QEMU images to AGL master.  So official images with the addition of kuksa support.

e) When launching PED it is spinning on "Detecting Locations" which is a bit of a worry, but it's also giving different feedback depending upon which run option i use Toyota or AGL. As follows Toyota throws an exception whilst AGL does not, and running on Ubuntu desktop-linux just works fine, obviously i'm not asking you to debug this for me, but I do need your help what can i enable within qemu system logging for Toyota and AGL to display more information on what's going on.

If you are running a debugging QEMU image you get all the output.  Running a release image the debug spew is limited.

Could it just be that I need location services enabled in qemu ?

So if you see it work, two things:

Geoclue is included in the OS image
You're running a debug build.

When you don't see it work on a debug image it's missing Geoclue from the OS image.
When you don't see it work on a release image, it's because you aren't building for the Flutter 1P Linux embedding, which is what the plugin you linked to is intended for. I.e., it's the intended result. The fact that it "works" in debug is a bug tracked at https://github.com/flutter/flutter/issues/103660
So the underlying issue is that you're using a Flutter 1P Linux plugin.  The longer term solution here is to implement cross compiling in the Flutter SDK for Flutter Desktop.  At which point the AOT will have the correct registration code.

launching ped using Toyota [1]: Toyota flutter-auto (desktop-auto) 1 display bunch of stuff .../... then [INFO:engine.cc(94)] (0) flutter: [2022-09-18 19:09:35.435717]: DEBUG: LocationDataSource : Checking Location Service Enabled then throws unhandled Exception ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: FileSystemException: Cannot open file, path = '/home/parallels/Documents/GitHub/meta-flutter/tools/.config/flutter/dconf/user' (OS Error: No such file or directory, errno = 2)

Yep, I suspect geoclue requires some additional config beyond the base recipe.  If that was present you will still be presented with it not working on AOT image.

launch ped using Ubuntu linux-desktop (it just works) display bunch of stuff .../... then [2022-09-18 18:56:25.241]: DEBUG: LocationDataSource : Checking Location Service Enabled [2022-09-18 18:56:25.243]: DEBUG: LocationDataSource : Location Service is Enabled ? true [2022-09-18 18:56:25.380]: DEBUG: SplashScreen : Backend is not under maintenance. [2022-09-18 18:56:33.621]: DEBUG: LocationDataSource : Location found as : Latitude: -33.865913, Longitude:<PHONE_NUMBER> [2022-09-18 18:56:33.621]: DEBUG: LocationDataSource : Overriding the actual location with static one, as the Browser / Linux does not allow mocking the location [2022-09-18 18:56:33.622]: DEBUG: SplashScreen : latitude : -33.865107, longitude : 151.205282

linux-desktop is what Flutter 1P "Linux" plugins are made for.  The naming is mis-leading.  They use the term "Linux" very loose.  It would not run on Android (Linux), or with a Custom Embedder (Linux).  It's just a logical name used in pubspec.yaml to select the Linux GTK platform (desktop).
Normally in a vehicle there is an API exposed to query the location.  Geoclue is just a "good-enough" stand-in for AGL.

thank you very much for writing this, it's really quite amazing, I see it as a 1/2 point resolve most if not everything before your app hits AGL proper

You're welcome.


trouble with CodegenVisualizer example

Entitlements file seems to be missing (I added one)
Then getting
Generated/codegen-visualizer/codegen-visualizer.swift:36:24: error: initializer cannot be declared public because its parameter uses an internal type
    public convenience init(_ generated_code_holder: GeneratedCodeHolder) {
                       ^                             ~~~~~~~~~~~~~~~~~~~
/Users/holliday/swift-bridge/examples/codegen-visualizer/CodegenVisualizer/CodegenVisualizer/ContentView.swift:119:7: note: type declared here
class GeneratedCodeHolder: ObservableObject {

Xcode 13.3.1 (13E500a)
Does .github/workflows/test.yaml  test that example projects build with Xcode? I didn't see any lines of xcodebuild in there.

Ah. Sorry about that.
Good idea thank you.
Fixed! https://github.com/chinedufn/swift-bridge/pull/89


In user profile, allow filtering by course

Hey @yammesicka! I would like to work on this issue. Can you assign me and point me where to start with?

Sure! Have you installed the system on your machine?

Yes, I have set up the system on my machine!

Sure! Have you installed the system on your machine?

That's correct :)


Remove deprecated golang 1.6

This fixes #114
Also added golang 1.11 because it is the latest release, if that is an issue, i'll drop the commit

Thanks!


Unnecessary escaping of IRIs?

Description
Ontop seems to convert parentheses to unicode symbols even though it is not necessary.
Steps to Reproduce

Use a database with IRIs containing parentheses, such as http://dbpedia.org/resource/Java_(programming_language)
Run ontop
The output now contains  http://dbpedia.org/resource/Java_(programming_language)

Expected behavior:
According to the Turtle specification:
<' ([^#x00-#x20<>"{}|^`\] | UCHAR)* '>' /* #x00=NULL #01-#x1F=control codes #x20=space */

So every character that is not a control character or one of <>|^` should be allowed, for example parentheses.
Actual behavior:
IRIs with parentheses seem to get converted to unicode references.
Reproduces how often:
Every time.
Versions
Ontop 4.1

Hi Konrad,
Are you using an IRI template? If so, yes, parentheses should be percent-encoded as they are not part of the iunreserved production according to the R2RML standard (see https://www.w3.org/TR/r2rml/#from-template). The Ontop mapping language is aligned with this standard.
However, if the IRI is directly stored in the database and mapped as a column (not a template), no IRI-safe encoding should be applied.
IRI-safe encoding is an important mechanism for making IRI templates decomposable and applying many optimizations.
Best,
Benjamin

Oh then it is working as intended, I am using a template. I didn't know that the allowed characters of the R2RML standard differ from those of the Turtle specification. I will use columns then, thanks!

For anyone else with a similar problem, here is our solution as an example:
Escaped Parentheses
<#SwpHasProgrammingLanguageMap>
    rr:logicalTable [ rr:tableName "swp_has_programminglanguage" ];
    rr:subjectMap [
        rr:template "http://hitontology.eu/ontology/{swp_suffix}";
        rr:class hito:SoftwareProduct;
    ];
    rr:predicateObjectMap [
        rr:predicate hito:programmingLanguage;
        rr:objectMap [ rr:template "http://dbpedia.org/resource/{plang_suffix}"; rr:termType rr:IRI ];
    ].

Unescaped Parentheses
<#SwpHasProgrammingLanguageMap>
    rr:logicalTable [rr:sqlQuery """
        SELECT
        CONCAT('http://hitontology.eu/ontology/',swp_suffix) AS swp,
        CONCAT('http://dbpedia.org/resource/',plang_suffix) AS plang
        FROM swp_has_programminglanguage
    """];
    rr:subjectMap [
        rr:column "swp";
        rr:class hito:SoftwareProduct;
    ];
    rr:predicateObjectMap [
        rr:predicate hito:programmingLanguage;
        rr:objectMap [ rr:column "plang"; rr:termType rr:IRI ];
    ].


Change up the UI!

The current UI is not the best :P
Make the UI look prettier with a better color scheme and button styles!

can I work on this ?

yes Varuni! Go ahead!

Hey, can I work on this issue?

Hey, can I work on this issue?

@Typeaway14

Ill be assigning @KaashviR now!

Can i be assigned to this? Jova here.

Go ahead @Strange! (not able to tag you :/)


type-only import, exports

Closes #649.

@dsherret Can you check if this syntax is correct? I searched test case from babel but I failed to found one.

bors r+


Issue #246 - Add language selection dropdown menu

Checklist:

[x] Test your work and double check you didn't break anything

Description:

Move the react-intl logic and settings into redux
Add dropdown to footer
Make a way to mount and unmount the whole app so it fully re-renders after user selects a new langauge
Consolidate all localization util functions into a single util file

@micahalcorn - per our discord chat, this PR now stores user's selected lang in local storage, and if user changes it via the footer dropdown menu, the page refreshes.


rp: add dormant-wake functionality for Input

this temporarily takes ownership of pins, mostly because we want to clean up the dormant-wake bits after a wakeup and because doing anything else with the input while we're waiting for a wakeup isn't possible at all. doing it like this lets us not impose any cost on those who don't use dormant wakes.
the error type for dormant-wake setup is dependent on the static type of the pin being used. this allows us to support dormant-wake for AnyPin and still allowing eg unwrap-infallibe in cases where pin types are statically known.

This only sets the flags on the GPIO, there's no API for going dormant. Will you PR that later?
Why is dormant wake on QSPI disallowed? checking the datasheet the QSPI bank does have the dormant_wake_inte register too.
The typelevel contraption to change the error type based on the bank is somewhat complicated. I propose one of the following:

Always return an error, it just won't happen for IO bank pins.
Require a trait DormantWakePin, implement it for only IO bank pins. This disallows AnyPin though.

Error should not be (), it should be something like DormantWakeNotSupported
Why not allowing just setting the dormant wake flags, without taking ownership of the pin? and clear them when dropping the Input. This'd allow configuring them once at program startup, while still using the pin for other stuff, without having to create/drop the DormantWake struct every time.


[BUG] Scope.dart Incorrect Cloning of The Scope User

Platform:

[x]  Dart
[ ]  Flutter Android or iOS
[ ]  Flutter Web

IDE:

[ ]  VSCode
[ ]  IntelliJ/AS
[ ]  XCode
[x]  Other, which one? (Android Studio)

split-debug-info and obfuscate (Flutter Android or iOS) or CanvasKit (Flutter Web):

[ ]  Enabled
[x]  Disabled

Platform installed with:

[x] pub.dev
[ ] GitHub

Output of the command flutter doctor -v below:
[✓] Flutter (Channel stable, 3.3.2, on macOS 12.6 21G115 darwin-x64, locale en-US)
    • Flutter version 3.3.2 on channel stable at /Users/andyweng/Desktop/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e3c29ec00c (6 days ago), 2022-09-14 08:46:55 -0500
    • Engine revision a4ff2c53d8
    • Dart version 2.18.1
    • DevTools version 2.15.0

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/andyweng/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13F100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)

[✓] VS Code (version 1.59.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.6 21G115 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 105.0.5195.125

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

The version of the SDK (See pubspec.lock):
6.9.1

I have the following issue:
Currently there is an issue with the Scope.clone function in scope.dart where the user is not copied correctly for the clone. I believe was introduced in this PR where _setUserSync(user); was added instead of clone._setUserSync(user);. This causes the scope user to be empty when the captureException is called with the withScope parameter.
Steps to reproduce:
-Set the Sentry User at init.
-Call Sentry.captureException method with the withScope function specified and add a random tag in ScopeCallback.
-Observe that the user is not set for that exception on Sentry.
Actual result:

There is no Sentry user for that exception.

Expected result:

The Sentry user for that exception should be the user you set in step 1.

@andyweng0424 thanks for reporting, we will take a look at it.


Error Building Android, CLang, MacOS, NDK 20: Final linker can't find crtbegin_so.o or crtend_so.o

Hello,
I've worked through many things to make it almost all the way through a build of OpenBLAS for armeabi-v7a and arm64-v8a with the above listed platform and NDK, but am unable to overcome the what appears to be the last linker problem.
Here's the error I'm seeing:
 "/Users/doug.smith/Library/Android/sdk/ndk/20.1.5948944/toolchains/llvm/prebuilt/darwin-x86_64/bin/aarch64-linux-android-ld" --sysroot=/Users/doug.smith/Library/Android/sdk/ndk/20.1.5948944/toolchains/llvm/prebuilt/darwin-x86_64/sysroot -EL --fix-cortex-a53-843419 -z now -z relro --hash-style=both --enable-new-dtags --eh-frame-hdr -m aarch64linux -shared -o ../libopenblas_armv8p-r0.3.9.so crtbegin_so.o -L/Users/doug.smith/Library/Android/sdk/ndk/20.1.5948944/toolchains/aarch64-linux-android-4.9/prebuilt/darwin-x86_64/lib/gcc/aarch64-linux-android/4.9.x -L/Users/doug.smith/Library/Android/sdk/ndk/20.1.5948944/toolchains/llvm/prebuilt/darwin-x86_64/lib64/clang/8.0.7/lib/linux/aarch64 -L/Users/doug.smith/Library/Android/sdk/ndk/20.1.5948944/toolchains/llvm/prebuilt/darwin-x86_64/bin/../lib/gcc/aarch64-linux-android/4.9.x -L/Users/doug.smith/Library/Android/sdk/ndk/20.1.5948944/toolchains/llvm/prebuilt/darwin-x86_64/bin/../lib/gcc/aarch64-linux-android/4.9.x/../../../../aarch64-linux-android/lib/../lib64 -L/Users/doug.smith/Library/Android/sdk/ndk/20.1.5948944/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/lib/aarch64-linux-android -L/Users/doug.smith/Library/Android/sdk/ndk/20.1.5948944/toolchains/llvm/prebuilt/darwin-x86_64/bin/../lib/gcc/aarch64-linux-android/4.9.x/../../../../aarch64-linux-android/lib -L/Users/doug.smith/Library/Android/sdk/ndk/20.1.5948944/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/lib -lm --whole-archive ../libopenblas_armv8p-r0.3.9.a --no-whole-archive -soname libopenblas.so -lm -lm -lm -lgcc -ldl -lc -lgcc -ldl crtend_so.o
/Users/doug.smith/Library/Android/sdk/ndk/20.1.5948944/toolchains/llvm/prebuilt/darwin-x86_64/bin/aarch64-linux-android-ld: cannot find crtbegin_so.o: No such file or directory
/Users/doug.smith/Library/Android/sdk/ndk/20.1.5948944/toolchains/llvm/prebuilt/darwin-x86_64/bin/aarch64-linux-android-ld: cannot find crtend_so.o: No such file or directory
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [../libopenblas_armv8p-r0.3.9.so] Error 1
make: *** [shared] Error 2

Here's the shell script I'm using:
#!/bin/bash

# Starting from: https://github.com/xianyi/OpenBLAS/wiki/How-to-build-OpenBLAS-for-Android#building-with-android-ndk-using-clang-compiler

echo "Starting OpenBLAS Build for Android"
echo

# OpenBLAS must be cloned under this name and checked out at the right version - see README.md
cd OpenBLAS || exit $?

NDK_BUNDLE_DIR=$1

echo "START building arm64-v8a #####################################################:"

abi=arm64-v8a

# Set the PATH to contain paths to clang and aarch64-linux-android-* utilities
export PATH=${NDK_BUNDLE_DIR}/toolchains/aarch64-linux-android-4.9/prebuilt/darwin-x86_64/aarch64-linux-android/bin:${NDK_BUNDLE_DIR}/toolchains/llvm/prebuilt/darwin-x86_64/bin:$PATH

echo "PATH=${PATH}"
echo

echo "which clang: "
which clang
echo

echo "which ld: "
which ld
echo

# Set LDFLAGS so that the linker finds what it needs

# Recommended path in OpenBLAS Wiki
# export LDFLAGS="-L${NDK_BUNDLE_DIR}/toolchains/aarch64-linux-android-4.9/prebuilt/darwin-x86_64/lib/gcc/aarch64-linux-android/4.9.x -lm "

# Path where files are actually located in NDK 20 (neither this nor the above work)
export LDFLAGS="-L${NDK_BUNDLE_DIR}/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/lib/aarch64-linux-android/23 -L${NDK_BUNDLE_DIR}/platforms/android-23/arch-arm64/usr/lib -lm "

CLANG_FLAGS="-v -target aarch64-linux-android -marm -mfpu=vfp -mfloat-abi=softfp --sysroot=${NDK_BUNDLE_DIR}/toolchains/llvm/prebuilt/darwin-x86_64/sysroot "

AR="${NDK_BUNDLE_DIR}/toolchains/aarch64-linux-android-4.9/prebuilt/darwin-x86_64/bin/aarch64-linux-android-ar"

command="make TARGET=ARMV8 ONLY_CBLAS=1 CC='clang ${CLANG_FLAGS}' AR=${AR} HOSTCC=gcc -j4"

echo "make clean"
echo
make clean || exit $?

echo $command
echo
eval $command || exit $?

I appreciate any help you can offer!

You have to export NDK_BUNDLE_DIR so that NDK finds its own C runtime.

@brada4 Thank you for your fast response.
I tried export NDK_BUNDLE_DIR=$1, but I see the same error.
I think the NDK is finding its own runtime successfully given the output of the which statements:
which clang:
/Users/doug.smith/Library/Android/sdk/ndk/20.1.5948944/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang

which ar:
/Users/doug.smith/Library/Android/sdk/ndk/20.1.5948944/toolchains/aarch64-linux-android-4.9/prebuilt/darwin-x86_64/aarch64-linux-android/bin/ar

which ld:
/Users/doug.smith/Library/Android/sdk/ndk/20.1.5948944/toolchains/aarch64-linux-android-4.9/prebuilt/darwin-x86_64/aarch64-linux-android/bin/ld

Could you check where in your NDK installation path the crtbegin_so.o is located ? Perhaps that would provide a hint to what is missing

@martin-frbg: There is a crtbegin_so.o file located underneath both of the directories listed in LDFLAGS above. (I put them both in, have tried one or the other, it still says it can't find it.) Specifically (targeting API 23):
{NDK_BUNDLE_DIR}/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/lib/aarch64-linux-android/23
{NDK_BUNDLE_DIR}/platforms/android-23/arch-arm64/usr/lib

https://github.com/xianyi/OpenBLAS/issues/2005#issuecomment-500704732 looks related though not on darwin

@martin-frbg: Thank you for pointing me to #2005, that was related and very helpful! I was able to make it work starting from there.
Here's what worked (NDK r20b, targeting API 23 instead of 21 as in the #2005). The difference between #2005 and mine (besides mine being Darwin) is that clang was not located under $TOOLCHAIN. I also added other CLANG args we wanted from our previous usage of OpenBLAS.
armeabi-v7a:
#!/bin/bash

export NDK=$1
export TOOLCHAIN=$NDK/toolchains/arm-linux-androideabi-4.9/prebuilt/darwin-x86_64
export CLANG=$NDK/toolchains/llvm/prebuilt/darwin-x86_64/bin/armv7a-linux-androideabi23-clang
export AR=$TOOLCHAIN/bin/arm-linux-androideabi-ar
export SOURCE_DIR=OpenBLAS
export INSTALL_DIR=../android-openblas/armeabi-v7a

rm -rf $INSTALL_DIR
cd $SOURCE_DIR || exit $?

make clean || exit $?

make \
    TARGET=ARMV7 \
    ONLY_CBLAS=1 \
    CC="$CLANG -g -marm -mfpu=vfp -mfloat-abi=softfp " \
    AR=$AR \
    HOSTCC=gcc \
    ARM_SOFTFP_ABI=1 \
    -j4 \
    || exit $?

make PREFIX=$INSTALL_DIR install || exit $?

arm64-v8a:
#!/bin/bash

export NDK=$1
export TOOLCHAIN=$NDK/toolchains/aarch64-linux-android-4.9/prebuilt/darwin-x86_64
export CLANG=$NDK/toolchains/llvm/prebuilt/darwin-x86_64/bin/aarch64-linux-android23-clang
export AR=$TOOLCHAIN/bin/aarch64-linux-android-ar
export SOURCE_DIR=OpenBLAS
export INSTALL_DIR=../android-openblas/arm64-v8a

rm -rf $INSTALL_DIR
cd $SOURCE_DIR || exit $?

make clean || exit $?

make \
    TARGET=CORTEXA57 \
    ONLY_CBLAS=1 \
    CC="$CLANG -g -marm -mfpu=vfp -mfloat-abi=softfp " \
    AR=$AR \
    HOSTCC=gcc \
    -j4 \
    || exit $?

make PREFIX=$INSTALL_DIR install || exit $?

It might help another user if you updated your Wiki. Particularly, this is what I was trying to make work and couldn't ever get it to work: https://github.com/xianyi/OpenBLAS/wiki/How-to-build-OpenBLAS-for-Android#building-with-android-ndk-using-clang-compiler.

Unfortunately that wiki page becomes outdated every now and then (and probably confused/confusing in between) as I currently do not have the environments to test Android builds myself. I usually try to update it with information gleaned from tickets such as this but I must have forgotten to do this with  GavinAndre's contribution, only dimly remembering that we had a related ticket somewhere. Btw you have write access to the wiki as well.


logrotate support needed

/var/log/elasticsearch/${cluster.name}*.log needs to be rotated via logrotate.

I know this issue is long closed, but just ran into this three years later.
Due to a flurry of errors being logged, one of the servers in our cluster had generated several gigabytes of logs, nearly filling the disk.  Now, 3 months later, the disk actually did run out of space, resulting in a failure of the node.  Fortunately, the cluster survived, and the node recovered after freeing up space.
My question is, where should I take this up?  Who maintains the dpkg packages?  The default behaviour should be that log files get rotated.  A package which doesn't do that is basically broken.

Sorry about the rotation issues, @laurikari. Like electrical mentioned, the module does have logging.yml management in it now, although rotation in the sense of a file for logrotate.d isn't.
The upstream elasticsearch repo is the place to discuss packaging (look under the :Packaging label for related issues). Based upon what I've read to get some context, the log4j version shipped with ES can't rotate/delete old log files. If you want to push for some logrotate files to be shipped with dev/rpm packages, that'd be a place to file issues.
If the need is intense enough, we could probably start handling rotation files by dropping a config into logrotate.d, though I'm not familiar with how the log file timestamps may change between versions of ES.

Thanks @tylerjl!  I'll take this upstream.


Fix handler return value

Hi, Please check this.
I think should return value to 'handled' or 'not-handled' in handleReturn  .
refs:

https://github.com/draft-js-plugins/draft-js-plugins/pull/499#issuecomment-255530058
https://github.com/draft-js-plugins/draft-js-plugins/blob/master/draft-js-plugins-editor/src/Editor/index.js#L144
https://github.com/facebook/draft-js/blob/b4afd3c6aa5dd7203362beff3d1b020738a69cf6/docs/APIReference-Editor.md#cancelable-handlers-optional
https://github.com/facebook/draft-js/commit/b4afd3c6aa5dd7203362beff3d1b020738a69cf6

Maybe this issue https://github.com/icelab/draft-js-block-breakout-plugin/issues/3

Thanks, @sugarshin! Looks good, I’ll merge and release.

Released as 1.0.0.


feat(order-summary): add simple order summary component

Order Summary
Adds the Order Summary component, still need to add the category functionality / tests, but wanted to get it up so people can get some eyes on it!
To Do

[x] Add category functionality
[x] Tests

Couple of linting errors in the tests

@hellobrian linting errors have been fixed, added descriptions

👍 ✅

Bluemix toolchain: Delivery Pipeline deployed carbon-components-react to Bluemix Design System, including commit e2baa84386a78fd40e2ff3836b12dd4a62e1b92c


Brings CrowRNG method names into compliance with code standards

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#1863
What are the significant changes in functionality due to this change request?
Changes CrowRNG method names to camel case to bring them into compliance with RAVEN code standards.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Job Test qsubs sawtooth on 970f201 : invalidated by @wangcj05

@wangcj05 I've made the requested changes discussed in the other PR. I've also added minor changes to some of the tests to use the randomUtils utility functions instead of the RNG engine directly to make that interface method more consistent throughout.

Job Test Ubuntu 18 PIP on ae87f8c : invalidated by @joshua-cogliati-inl
restarted civet

Job Test Ubuntu 18 PIP on ae87f8c : invalidated by @joshua-cogliati-inl
restarted civet

checklist passed.

@j-bryan Thanks for your contribution. I have merged your PR. Great Job!


/fleet/unit excessive read requests to Etcd

We're running an Etcd 2.1-alpha1, with 5 core cluster and the rest of nodes (hundreds) in Etcd proxy configuration.
As per graphs in https://github.com/coreos/etcd/pull/3001 we're seeing a storm of recursive GETs coming from local host fleet, on each of the nodes in the cluster. We're running about 1200 units on the cluster.
We've captured a TCP dump (available on request) that shows that Fleet has made ~6000 HTTP get requests in about 120s. We're not running any fleetctl commands on the host, so I assume this is the local fleetd.

Most of these are GET requests to individual /v2/keys/_coreos.com/fleet/unit/<unit_id> in consistent, recursive mode.
Is there some reason that prohibits fleet from doing one big recursive request on /v2/keys/_coreos.com/fleet/unit/oing an individual request per unit instead of a recursive one across all? Can you point us at the code that does that?

So the only place that calls /unit/<unit_id> in recursive mode seems to be
registry/job.go:257
func (r *EtcdRegistry) getUnitFromObjectNode(node *etcd.Node) (*job.Unit, error)
which is only called in
registry/job.go:151
func (r *EtcdRegistry) dirToUnit(dir *etcd.Node) (*job.Unit, error)
this is called in two places:
registry/job.go:133
func (r *EtcdRegistry) Unit(name string) (*job.Unit, error)
(which I assume is called for a single unit fetch)
or in
registry/job.go:90
func (r *EtcdRegistry) Units() ([]job.Unit, error)
which does match the symptoms we see in the tcp dump (see highlighted /job sorted request)

Currently, the design is thta all agent get all unit files periodically from etcd. If there are many units in etcd and agent is many, the unit HTTP get request will be huge.
I think need implement a cache mechanism in agent side. Only if the unit change, the agent get the latest status from etcd, otherwise, will not send unit file HTTP get request to etcd.
@bcwaldon @jonboulle @crawford, what do you think ? If need, I can help to implement it to enhance the performance of etcd server.

https://github.com/coreos/fleet/pull/1260
It does a single recursive for all units read on registry.Units() call, instead of making one for Unit.

Fixed by #1376. Thanks for the patch!


merge package template from Kronos-Tools/npm-package-template

package.json

chore(devDependencies): update<EMAIL_ADDRESS>from template
chore(devDependencies): add<EMAIL_ADDRESS>from template
chore(devDependencies): add<EMAIL_ADDRESS>from template
docs(package): remove keyword null

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #70   +/-   ##
======================================
  Coverage    92.3%   92.3%
======================================
  Files           1       1
  Lines          26      26
======================================
  Hits           24      24
  Misses          2       2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c9e87...0d1f997. Read the comment docs.


Migrate queries to RPC

Currently, we use a base observable store that utilizes the LCD/rest endpoint of each chain (mostly Osmosis).
We should migrate our queries to use RPC instead, using this Keplr base store.
This may improve UX performance and stability, as I've heard that they're more performant than LCD.

Closing since it's an idea in ClickUp. Can reopen if pursued.