How can I align a TextFormField on AppBar in vertical center?

Problem
The TextFormField on AppBar is a little higher than the back button on AppBar, and having space on left and right. As the following screenshot shows.

I want to align vertical center and removing the left and right space, to simulate a search bar.
Code
class TumblrSearchInputScreen extends StatefulWidget {
  final String initialTag;
  final void Function(String) search;

  TumblrSearchInputScreen({
    Key key,
    this.initialTag,
    @required this.search,
  }) : super(key: key);

  @override
  _TumblrSearchInputScreenState createState() =>
      _TumblrSearchInputScreenState();
}

class _TumblrSearchInputScreenState extends State<TumblrSearchInputScreen> {
  static final _bodyKey = GlobalKey<_BodyState>();

  final _formKey = GlobalKey<FormState>();
  TextEditingController _textController;
  String tag = '';

  @override
  void initState() {
    super.initState();

    _textController = TextEditingController(text: widget.initialTag);
  }

  void _submit() {
    if (_formKey.currentState.validate()) {
      _formKey.currentState.save();
      widget.search(tag);
      Navigator.of(context).pop();
    }
  }

  String _validateTag(String tag) {
    if (tag.isEmpty) {
      return '请输入关键字';
    }
    return '';
  }

  @override
  Widget build(BuildContext context) {
    return StoreConnector<AppState, _ViewModel>(
      converter: (store) => _ViewModel(
            tags: store.state.tumblr.tags,
          ),
      builder: (context, vm) => Scaffold(
            appBar: AppBar(
              // automaticallyImplyLeading: false,
              title: Form(
                key: _formKey,
                child: TextFormField(
                  decoration: InputDecoration(
                    border: InputBorder.none,
                    // prefixIcon: IconButton(
                    //   onPressed: () => Navigator.of(context).pop(),
                    //   icon: Icon(Icons.arrow_back, color: TblTheme.whiteLight),
                    // ),
                    hintText: '请输入关键字',
                    hintStyle: TextStyle(color: TblTheme.whiteNormal),
                    suffixIcon: GestureDetector(
                      onTap: Feedback.wrapForTap(
                        _textController.clear,
                        context,
                      ),
                      child: Icon(Icons.clear, color: TblTheme.whiteLight),
                    ),
                  ),
                  validator: _validateTag,
                  onSaved: (value) => tag = value.trim(),
                  onFieldSubmitted: (value) => _submit(),
                  autofocus: true,
                  maxLength: 20,
                  controller: _textController,
                  style: TextStyle(
                    color: TblTheme.whiteNormal,
                    fontSize: TblTheme.fontSizeLarge,
                  ),
                ),
              ),
            ),
            body: _Body(
              key: _bodyKey,
              vm: vm,
              search: widget.search,
            ),
          ),
    );
  }
}

You can center the textfield giving a padding to your InputDecoration:
InputDecoration(
                border: InputBorder.none,
                contentPadding: EdgeInsets.symmetric(vertical: 15.0),
                ...

And you can't remove the left/right padding because you are using the title property from AppBar and it has it owns layout/calculations, you could check the source code.
What you can do is remove the suffixIcon from your TextFormField and add it as an actions for the AppBar:
appBar: AppBar(
        // automaticallyImplyLeading: false,
        actions: <Widget>[
          GestureDetector(
                  onTap: Feedback.wrapForTap(
                    _textController.clear,
                    context,
                  ),
                  child: Padding(
                     padding: const EdgeInsets.all(8.0),
                      child: Icon(Icons.clear, color: Colors.white),
                   ),
                )
        ],

How-to questions are better asked on StackOverflow.

It's worked!

It works but it's not flexible.
If the appbar height changes, the input won't be properly aligned.
I tried for hours to do this seemingly simple thing - just place TextField as AppBar title and center it vertically and failed...
I tried all possible combinations of Rows Columns Expands Flexibles etc... and none of this worked.
I really don't like this solution with hardcoded padding.
Is there better solution with Flex or the Flutter is just so awkward that it makes it impossible?

Also I have set a custom font size in the TextField so the padding is not 15.0 anymore... its not even a whole number and I have to guess it. Very ugly practice :/

@JohnnyDevX Did you find a solution for alignment with custom height appbar?

The preferred size is given then the app bar title not aligned in the vertical center


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/79 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target.git

Docs Build status updates of commit ede1d5e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-09-25-07-35-26 has been deleted or has been force pushed: fatal: Couldn't find remote ref Archive_master_2019-09-25-07-35-26

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Unable to add products

I'm unable to add products via the UX.  Without the Product Types / Modules, I should be able to add products just with the following:

Name
Description
Icon
Active (Set Active or Not)
Setup Price
Hourly Price
Monthly Price
Product Type (with nothing in the system it would be "None")

This may be a UX issue, if so, please create a ticket over there and reference this one.

The button is disabled for me when I try to do this. I might be doing something wrong I'm honestly not sure.

I have added a ticket in the UX repo as well for this.

@stackus fixed the button issue. I'm now working on the route issue.

https://github.com/projectjellyfish/ux/pull/277
https://github.com/projectjellyfish/api/pull/338


Odd rendering issue (possibly due to css settings?)

Hey, love this project and the components you guys built. I've been looking at a loooot of flowchart-type libraries, and this is definitely the most promising one I've come accross. I am running into a weird issue with a very basic application of the  component. While components are being dragged, the edges connecting the nodes "jump" around (see screen capture below). I also noticed that if I drag the node offscreen, it has a tendency to jump a great distance and then it's hard to drag it back onscreen as it jumps around by large amounts when I move it. I suspect this may be due to interference between my css styling for the larger project (which uses flexbox) and styling needed for the FlowChart components, but I must confess I'm not that great with css styling, and I am unable to figure this one out. Since this may be a bug of some sort, I wanted to report it and see what you guys thought. If this is on me, my apologies for the erroneous bug report, but I'd definitely appreciate a hand.
Here's the behavior I'm seeing:

Here's my react code for my main component that is being rendered by  ReactDOM.render()  (it's a very simple project that I'm using to try to get the rendering and formatting right before wiring up the data):

import * as React from 'react';
import { cloneDeep, mapValues } from 'lodash';
import { FlowChart, actions } from '@mrblenny/react-flow-chart';

import DetailPanel from './DetailPanel/DetailPanel';
import AddNewButton from './AddNew/AddNewButton';
import ReactFlowchartWrapper from './Wrappers/ReactFlowchartWrapper';

const scripts = [
    {
        id: 1,
        human_name: 'Test Script 1',
        type: 'RUN_ON_JOB',
        supported_file_types: '',
        description:
            'This is a script that does nothing. Absolutely nothing.',
    },
    {
        id: 2,
        human_name: 'Test Script 2',
        type: 'RUN_ON_JOB_DOCS_PARALLEL',
        supported_file_types: '[".pdf",".doc",".docx"]',
        description:
            "This does even more nothing than script #1 and does it well.",
    },
    {
        id: 3,
        human_name: 'Test Script 3',
        type: 'RUN_ON_JOB_DOCS_PARALLEL',
        supported_file_types: '[".pdf",".doc",".docx"]',
        description:
            "So much nothing. You can't handle this much nothing.",
    },
];

const chart = {
    offset: {
        x: 0,
        y: 0,
    },
    scale: 1,
    nodes: {
        node1: {
            id: 'node1',
            type: 'output-only',
            position: {
                x: 300,
                y: 100,
            },
            ports: {
                port1: {
                    id: 'port1',
                    type: 'output',
                    properties: {
                        value: 'yes',
                    },
                },
                port2: {
                    id: 'port2',
                    type: 'output',
                    properties: {
                        value: 'no',
                    },
                },
            },
        },
        node2: {
            id: 'node2',
            type: 'input-output',
            position: {
                x: 300,
                y: 300,
            },
            ports: {
                port1: {
                    id: 'port1',
                    type: 'input',
                },
                port2: {
                    id: 'port2',
                    type: 'output',
                },
            },
        },
    },
    links: {
        link1: {
            id: 'link1',
            from: {
                nodeId: 'node1',
                portId: 'port2',
            },
            to: {
                nodeId: 'node2',
                portId: 'port1',
            },
        },
    },
    selected: {},
    hovered: {},
};

class Graph extends React.Component {
    constructor(props) {
        super(props);
        this.state = cloneDeep(chart);
    }

    render() {
        const stateActions = mapValues(actions, (func) => (...args) =>
            this.setState(func(...args))
        );

        const chart = this.state;

        return (

                    <button>Add Node</button>
                    <button>Delete Node</button>
                    <input className='total-nodes' type='number' />

                    <DetailPanel selectedNode={1} />
                    <AddNewButton scripts={scripts} />
                    <ReactFlowchartWrapper>
                        <FlowChart
                            chart={this.state}
                            callbacks={stateActions}
                        />
                    </ReactFlowchartWrapper>

        );
    }
}
export default Graph;

The ReactFlowchartWrapper component is identical to the  component used in the demo stories:
import * as React from 'react';
import styled, { createGlobalStyle } from 'styled-components';

const GlobalStyle = createGlobalStyle`
  body {
    margin: 0px;
    max-width: 100vw;
    max-height: 100vh;
    overflow: hidden;
    box-sizing: border-box;
    font-family: sans-serif;
  }
  *, :after, :before {
    box-sizing: inherit;
  }
`;

const PageContent = styled.div`
    display: flex;
    flex-direction: row;
    flex: 0;
    max-width: 100vw;
    max-height: 100vh;
`;

export const ReactFlowchartWrapper = ({ children }) => (
    <PageContent>
        {children}
        <GlobalStyle />
    </PageContent>
);
export default ReactFlowchartWrapper;

And here's my stylesheet:
html,
body {
    font-family: sans-serif;
    font-size: 12px;
    margin: 0px;
    margin: 0px;
    max-width: 100vw;
    max-height: 100vh;
    overflow: hidden;
    box-sizing: border-box;
    font-family: sans-serif;
}

.wrapper {
    width: 100%;
    height: 100%;
    position: relative;
    top: 0;
    left: 0;
    display: flex;
    flex-direction: column;
}

.graph-window {
    position: relative;
    height: 100%;
    top: 0;
    left: 0;
    flex: 1;
}

.graph-header {
    border-bottom: 1px solid black;
    position: relative;
    width: 100%;
    height: 50px;
    background-color: #fff;
    padding: 10px;
    flex: 1;
}

.canvas {
    height: 100vh;
}

Your assistance would be appreciated!

Have an update here. I was wrapping my app in <React.StrictMode>. Once I removed that, the react flowchart components work as expected... Is this expected behavior?

@JSv4 I have the same problem which I solves by removing <React.StrictNode> too.

Just here to say that I had this issue too & solved by removing <React.StrictNode> as suggested above. Any one found a way to fix this WITHOUT removing the strict mode?

@rashidul-hasan, I have not. I've been slammed trying to finish another project but may try to figure this out if I have the time after my next project release is ready.


City hall level tracking

A few other scanner support identifying the City Hall level of a governor.
I think this is done by going to the Governor Search and then getting the CH level from the city picture.
Requires CH16.
New domain registration mode counts all CH25 for matchmaking, hence this is becoming more of an issue for kingdoms.

I know python but little about OCR and ADB, not sure how much i can contribute to this feature.

I am currently busy with other stuff, but another way could be to do a city hall scan (via the city hall ranking - not implemented) once in a while and combine those results with the normal scan based on the governor ID.
I suggest that because I think opening the search for every governor can be very slow, and also, implementing said city hall level scan is rather easy; it's just a modification of one of the existing scanners (probably the seed scanner that is currently unreleased, only in dev)

Think the issue with that is the CH ranking has all the dead accounts and even rank1000 is some random CH25. It's not viable imo.


Add session and statement state for all query types

Description

create session and statement for all the queryType.

Issues Resolved
https://github.com/opensearch-project/sql/issues/2401
Check List

[x] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kaituo two questions.
1. should we add a new StatementState `cancelling` and Spark job update it as `cancelled`?

2. what is the required configuration of REPL job, we have following configurations now, do we need more?

   * config.put(FLINT_JOB_REQUEST_INDEX, DATASOURCE_TO_REQUEST_INDEX.apply(datasourceName));
   * config.put(FLINT_JOB_SESSION_ID, sessionId);

Can you just update it as cancelled? If you cancel before repl pick the statement up or after repl finishes the statement, repl doesn't need to do anything else. If you cancel after repl picks it up and before repl finishes, repl may change your state, which I think is fine.

I also need these two:
val dataSource = conf.get("spark.flint.datasource.name", "unknown")
val wait = conf.get("spark.flint.job.type", "continue")


Fix for issue #1438

This will fix bug #1438

Can you explain the change?

@stephenmcd See once I have updated commit details.

Fixed in a0a205e3121835a4f423eac7dc4d581eb6f0df5d


Remove apk update in Dockerfile

With --no-cache on apk add, there is no need to do apk update
What type of change does this PR introduce?

[x] Refactor

Does this PR introduce breaking changes?

[ ] Yes
[x] No

Description:
Sorry that I didn't open an issue first as this seems very trivial. If an issue is required, please let me know and I'll open it, thanks!

 🔧 [1.0.0-beta.2] No need apk update as there is --no-cache on the apk add command

Hello @PeterDaveHello,
Thanks for contributing! It looks good to me :+1:


Update 2d_shooting.md

add default value for "Bullet" variable
"export" variable allow user to change value tough the Godot "scene editor".
But this tutorial don't talk about this subject, and some people was asking question in comment about this subject.
I propose this pull request to define a default value for the "Bullet scene"

I don't like having a default value that is specific to a project, as this is intended to be used in any project.


Add back "normal" output

It looks like when this was forked, https://github.com/cloudflare/goflow/pull/73 was dropped from the formatting controls.
The "normal" format is useful for simplified parsing with things like mtail which doesn't really handle json well.
It's also useful to be able to drop unused fields from the output by filtering which fields are included.

Hi @SuperQ,
What is the issue with mtail? Is it the order of fields/comma of JSON?
Filtering the fields using a list should be doable.

mtail doesn't have an explicit json parsing mode. So you end up having to do a lot of extra work to parse the fields.
Maybe adding the "which fields to log" is a separate feature request.

I'm doing some work in a branch.
This should allow field selection first.

Thanks.
I'm also willing to help with this work, I just prefer to file issues first. :)
Let me know if there's other issues I can work on. For example, goreleaser might be a good tool to ad to the build pipeline.

Could you confirm that the following would work for mtail (or need :)
Type=SFLOW_5 TimeReceived=1623135901 SequenceNum=156625 SamplingRate=100 SamplerAddress=<IP_ADDRESS> TimeFlowStart=1623135901 TimeFlowEnd=1623135901 Bytes=102 Packets=1 SrcAddr=<IP_ADDRESS> DstAddr=<IP_ADDRESS> Etype=2048 Proto=1 SrcPort=0 DstPort=0 InIf=2 OutIf=1073741823 SrcMac=ab:cd:ef:00:01:02 DstMac=ab:cd:ef:00:01:02 SrcVlan=0 DstVlan=0 VlanId=0 IngressVrfID=0 EgressVrfID=0 IPTos=32 ForwardingStatus=0 IPTTL=57 TCPFlags=0 IcmpType=0 IcmpCode=0 IPv6FlowLabel=0 FragmentId=46622 FragmentOffset=0 BiFlowDirection=0 SrcAS=0 DstAS=0 NextHop= NextHopAS=0 SrcNet=0 DstNet=0 EtypeName=IPv4 ProtoName=ICMP IcmpName=EchoReply

For Goreleaser, maybe? I meant to add ARM builds but I would like to avoid dependencies (Makefile + GitHub Actions seem sufficient)

@lspgn Yes, that format should work just fine.
I was looking over the branch, one thing I noticed in FormatMessageReflectCustom() is that it's not using %q to escape quotes in strings for json format.

@SuperQ could you have a look at #14?


RAM filling up during sampling

I have experienced that in some cases rejection sampling leads to filling up RAM in some cases leading everything to crash. I am not yet fully sure what it is about, but @janfb seems to have a better idea here ;) I quote from PR #192 :
"The RAM filling up in sampling with leakage was not because of the problem set up, but because of the missing .detach(). In addition to fixing this memory bug we should make sure the leakage sampling loop has an anker, like it used to have with the patience, but with something else."

yes, I thought the fixing commit was on master already, but it is not. it is here:
354e473edb039dea232bff272ac59649cb53becc

Linked the PR to this issue and will fix it there :)

When doing so, please take into account this:

Yes!

Okey I am actually confused as to why we need this. In https://github.com/mackelab/sbi/blob/8d6e55ba1317f3e26a996879a420e9e4c854dcfc/sbi/inference/posteriors/sbi_posterior.py#L264
we actually set torch.no_grad(), shouldn't this do the job?

yes, good point. see also https://stackoverflow.com/questions/56816241/difference-between-detach-and-with-torch-nograd-in-pytorch


CLI is showing http: proxy error: context canceled when client is closing the connection

Describe the bug
The CLI is showing this error when the client is closing the connection (e.g. reload in chrome or cancelling a download):
3:48PM ??? http: proxy error: context canceled

To Reproduce
Steps to reproduce the behavior:

Host a large file via python -m SimpleHTTPServer 8080
Download it via e.g. Chrome
Cancel the download
See error

Expected behavior
The CLI should not show errors for such normal cases. Also the ??? might be confusing for the user.
Screenshots
N/A
Environment

OS: macOS
Browser: Chrome
Version:

$ loophole --version
loophole version 1.0.0-beta.7 (95033a34197863fe1074bf148758b30d16477fb6)

Additional context
N/A

This log is commit from http proxy which we are using there, so I can either disable logs from it completely or keep them all :/


Tower up

🎮 Game Request
The player has to click to pause the moving blocks to create a tower. The blocks need to be aligned properly to score points.
Point down the features
When the player reaches 1000 points it's a win. If the blocks are not aligned properly game ends. A scoreboard keeps track of the points scored.
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @PVSSukeerthi! 🙂
It seems like you are not following proper guidelines !! 👀
Read documentation properly !!🙏
If you have any queries reach out to us on Discord🕹 .

Hey @PVSSukeerthi !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @PVSSukeerthi ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

/assign


Offset's topic has not yet been created.

Versions
Please specify real version numbers or git SHAs, not just "Latest" since that changes fairly regularly.

Sarama
Kafka
Go

v1.25.0
2.4.x
1.14

Problem Description
I have a kafka cluster with three brokers. I keep receiving "Offset's topic has not yet been created." when trying to consume.

The offsets.topic.replication.factor = 1

Boils down to GROUP_COORDINATOR_NOT_AVAILABLE


filebeat master-filebeat connection error?

Hi,
1.) is it possible that master-filebeat is also called somewhat different somewhere else? I fixed the previous cAdvisor and node-exporter with correcting the prometheus.yml targets. But I still geht the following errors in kibana from filebeat:
dockerd[859]: time="2017-04-27T16:57:01.987083772+02:00" level=error msg="Failed to log msg "14:57:01.983 [[main]<gelf] INFO  logstash.inputs.gelf - Starting gelf listener {:address=>\"<IP_ADDRESS>:12201\"}" for logger gelf: gelf: cannot send GELF message: write udp <IP_ADDRESS>:44176-><IP_ADDRESS>:12201: write: connection refused"
2.) the dashboard in Kibana also does not work, if it is supposed to look like in your screenshot.

) and are there also supposed to be annotations in the grafana interface? I do not see that either.

Hey @pir1981,
I just realized that I didn't pin the monitoring images, which could be responsible for the Grafana annotations and Prometheus issues. As for Filebeat it is pinned to 1, which probably is nonsense by now, as latest is up at 5.3 (https://hub.docker.com/r/prima/filebeat/).
So yeah, it might very well be, that running the setup.sh these days will lead to a mix of cutting-edge and outdated component images being pulled that don't necessarily work too well together.
Unfortunately I don't have the time to fix this at the moment, but I'll ope an issue for this, maybe someone else wants to tackle this.
Cheers
Will


virtualedit=all and gr operator

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini.operators
Description
with virtualedit=all, the behaviour of replacing the last word with register is wrong
Neovim version
0.10.1
Steps to reproduce

prepare file:

vanilla emacs

set virtualedit=all

press yiwwgriw

Expected behavior
the text becomes
vanilla vanilla
Actual behavior
the text becomes
vanilla  vanilla
(there are 2 spaces)

Thanks for the issue!
Can reproduce this. I vaguely remember that I tried to support all 'virtualedit' values (as there are tests for virtualedit=block and block mode) but maybe opted out to not support some edge cases as it would require some non-trivial code. I'll take a look.

This now should be fixed on latest main. Plus there now tests for all 'virtualedit' values in most common issue-inducing scenarios.
Thanks again for finding it!


Add libc++ & libc++abi for all Ubuntu images

Tool information

Tool name: libc++ and libc++abi
Tool license: MIT license
Add or update? Add
Desired version: Latest
Approximate size: ~7Mb
If this is an add request:

Brief description of tool: LLVM C++ Standard Library and "low level support" library.
URL for tool's homepage: https://libcxx.llvm.org/index.html
Provide a basic test case to validate the tool's functionality:

echo "#include <cstdlib>" > test.cpp && clang++ -stdlib=libc++ test.cpp -c

Area for Triage:
C/C++
Question, Bug, or Feature?:
Feature
Virtual environments affected

[ ] macOS 10.15
[ ] Ubuntu 16.04 LTS
[X] Ubuntu 18.04 LTS
[X] Ubuntu 20.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Can this tool be installed during the build?
Not that I could figure out: installing LLVM via HomeBrew did not include the headers. It may be possible to compile it from source.
Tool installation time in runtime
<1 min (using apt)
Are you willing to submit a PR?
Yes

Changes are merged. New image with these libraries will be deployed next week


subprocess.CalledProcessError: Command '['bids-validator', '/data', '-c', '/tmp/tmp3_xycsud.json']' died with <Signals.SIGABRT: 6>.

What happened?
I tried to preprocess the FMRI dataset and got the following error.
What command did you use?
fmriprep-docker '/media/menglab/Work2/hy/face_imagery/block_design/BIDS' '/media/menglab/Work2/hy/face_imagery/block_design/BIDS/derivatives/fMRIprep' -w '/media/menglab/Work2/hy/face_imagery/block_design/fMRIprep_working_directory' --fs-license-file '/home/menglab/freesurfer/license.txt' --participant-label 1 2 --ignore slicetiming --output-spaces anat MNI152NLin2009cAsym --skull-strip-t1w force

What version of fMRIPrep are you running?
23.2.2
How are you running fMRIPrep?
Docker
Is your data BIDS valid?
Yes
Are you reusing any previously computed results?
No
Please copy and paste any relevant log output.
RUNNING: docker run --rm -e DOCKER_VERSION_8395080871=20.10.7 -it -v /home/menglab/freesurfer/license.txt:/opt/freesurfer/license.txt:ro -v /media/menglab/Work2/hy/face_imagery/block_design/BIDS:/data:ro -v /media/menglab/Work2/hy/face_imagery/block_design/BIDS/derivatives/fMRIprep:/out -v /media/menglab/Work2/hy/face_imagery/block_design/fMRIprep_working_directory:/scratch nipreps/fmriprep:23.2.2 /data /out participant --participant-label 1 2 --ignore slicetiming --skull-strip-t1w force -w /scratch --output-spaces anat MNI152NLin2009cAsym
node[9]: ../../src/node_platform.cc:68:std::unique_ptr<long unsigned int> node::WorkerThreadsTaskRunner::DelayedTaskScheduler::Start(): Assertion `(0) == (uv_thread_create(t.get(), start_thread, this))' failed.
 1: 0x7fe9ec255d69 node::Abort() [/opt/conda/envs/fmriprep/bin/../lib/libnode.so.108]
 2: 0x7fe9ec255dfb  [/opt/conda/envs/fmriprep/bin/../lib/libnode.so.108]
 3: 0x7fe9ec2cd2dd node::WorkerThreadsTaskRunner::WorkerThreadsTaskRunner(int) [/opt/conda/envs/fmriprep/bin/../lib/libnode.so.108]
 4: 0x7fe9ec2cd3e7 node::NodePlatform::NodePlatform(int, v8::TracingController*, v8::PageAllocator*) [/opt/conda/envs/fmriprep/bin/../lib/libnode.so.108]
 5: 0x7fe9ec211fd7  [/opt/conda/envs/fmriprep/bin/../lib/libnode.so.108]
 6: 0x7fe9ec214104 node::InitializeOncePerProcess(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, node::ProcessFlags::Flags) [/opt/conda/envs/fmriprep/bin/../lib/libnode.so.108]
 7: 0x7fe9ec2148d3 node::Start(int, char**) [/opt/conda/envs/fmriprep/bin/../lib/libnode.so.108]
 8: 0x7fe9eb7cad90  [/usr/lib/x86_64-linux-gnu/libc.so.6]
 9: 0x7fe9eb7cae40 __libc_start_main [/usr/lib/x86_64-linux-gnu/libc.so.6]
10: 0x55f8a87f807f  [node]
Traceback (most recent call last):
  File "/opt/conda/envs/fmriprep/bin/fmriprep", line 8, in <module>
    sys.exit(main())
  File "/opt/conda/envs/fmriprep/lib/python3.10/site-packages/fmriprep/cli/run.py", line 40, in main
    parse_args()
  File "/opt/conda/envs/fmriprep/lib/python3.10/site-packages/fmriprep/cli/parser.py", line 828, in parse_args
    validate_input_dir(config.environment.exec_env, opts.bids_dir, opts.participant_label)
  File "/opt/conda/envs/fmriprep/lib/python3.10/site-packages/fmriprep/utils/bids.py", line 237, in validate_input_dir
    subprocess.check_call(['bids-validator', str(bids_dir), '-c', temp.name])
  File "/opt/conda/envs/fmriprep/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['bids-validator', '/data', '-c', '/tmp/tmpslslstgg.json']' died with <Signals.SIGABRT: 6>.
fMRIPrep: Please report errors to https://github.com/nipreps/fmriprep/issues

Additional information / screenshots
No response

Looks like you are hitting https://github.com/nodejs/node/issues/43064 - skimming through that thread, updating Docker could help

Hello,
I encountered the same issue. Could you please share how you resolved it? Thank you!

Mary


coding guidelines: comply with MISRA C:2012 Rule 14.4

MISRA C:2012 Rule 14.4 (The controlling expression of an if statement
and the controlling expression of an iteration-statement shall have
essentially Boolean type.)
Use do { ... } while (false)' instead of do { ... } while (0)'.
Use comparisons with zero instead of implicitly testing integers.
Use comparisons with NULL instead of implicitly testing pointers.
Use comparisons with NUL instead of implicitly testing plain chars.
Use bool' instead of int' to represent Boolean values.
Use `for (;;)' to express infinite loops.
Signed-off-by: Abramo Bagnara<EMAIL_ADDRESS>

@Abramo-Bagnara Is this still a work in progress? Otherwise I think your commit message and PR message is misleading, as this only tackles do { ... } while ( ) loops, but the rule applies to all control and iteration statements (i.e. all for loops and if statements).
Are you planning on adding the fixes for those in this PR? Otherwise I suggest renaming your PR.
Are you planning on enabling the check in CI as well?

@Abramo-Bagnara there are a few issues to look at: https://github.com/zephyrproject-rtos/zephyr/runs/4235167227

@Abramo-Bagnara Is this still a work in progress? Otherwise I think your commit message and PR message is misleading, as this only tackles do { ... } while ( ) loops, but the rule applies to all control and iteration statements (i.e. all for loops and if statements).
Are you planning on adding the fixes for those in this PR? Otherwise I suggest renaming your PR.

Hi. As per instructions, we are working on the compliance of two particular builds of zephyr. In doing so, when this is feasible, we try not to introduce inconsistencies within the project. This is why do-while-0 loops were changed globally.

Are you planning on enabling the check in CI as well?

Do you mean the check for compliance wrt the coding guidelines (a subset of MISRA C:2012)?

@Abramo-Bagnara Is this still a work in progress? Otherwise I think your commit message and PR message is misleading, as this only tackles do { ... } while ( ) loops, but the rule applies to all control and iteration statements (i.e. all for loops and if statements).
Are you planning on adding the fixes for those in this PR? Otherwise I suggest renaming your PR.

Hi. As per instructions, we are working on the compliance of two particular builds of zephyr. In doing so, when this is feasible, we try not to introduce inconsistencies within the project. This is why do-while-0 loops were changed globally.

Not sure what instructions you are referring to, but if this only changes part of MISRA 14.4, then that should be clear from the commit and PR messages.

Are you planning on enabling the check in CI as well?

Do you mean the check for compliance wrt the coding guidelines (a subset of MISRA C:2012)?

I mean adding a check in the CI system to avoid that future PRs will add code that is not compliant with the change you are doing here.

@Abramo-Bagnara Is this still a work in progress? Otherwise I think your commit message and PR message is misleading, as this only tackles do { ... } while ( ) loops, but the rule applies to all control and iteration statements (i.e. all for loops and if statements).
Are you planning on adding the fixes for those in this PR? Otherwise I suggest renaming your PR.

Hi. As per instructions, we are working on the compliance of two particular builds of zephyr. In doing so, when this is feasible, we try not to introduce inconsistencies within the project. This is why do-while-0 loops were changed globally.

Not sure what instructions you are referring to

I work on behalf of an organization that provided me with instructions.

but if this only changes part of MISRA 14.4, then that should be clear from the commit and PR messages.

Ok: do you want me to add the prefix "partially" to each commit and PR? In this particular case it would become "coding guidelines: partially comply with MISRA C:2012 Rule 14.4".

Are you planning on enabling the check in CI as well?

Do you mean the check for compliance wrt the coding guidelines (a subset of MISRA C:2012)?

I mean adding a check in the CI system to avoid that future PRs will add code that is not compliant with the change you are doing here.

This would be a great idea, but it is not something I can decide upon.

@Thalley

Do you mean the check for compliance wrt the coding guidelines (a subset of MISRA C:2012)?

This is still work in progress, note that this change is going into a branch right now. When we forward port those changes to main, we will have a check eventually.

@Abramo-Bagnara there are a few issues to look at: https://github.com/zephyrproject-rtos/zephyr/runs/4235167227

Yes, qsort.c did not include <stdbool.h>: will fix it now.

I am going to approve for shell part, however, I have just a question for the community regarding do {...} while (false).
In C false is defined as 0, so please let me know what is the difference? I am guessing that MISRA requires this, however, I am curious as to the reasoning behind it?

Under a MISRA perspective do/while condition is one of the constructs that expects an effectively Boolean value, while 0 is an integer. The fact that false expands to 0 is an internal detail of the implementation that does not change the effectively Boolean nature of false.

am curious as to the reasoning behind it?

AFAIK this rule is in the interests of clarity, and makes clear the distinction between integers and logical values.

am curious as to the reasoning behind it?

AFAIK this rule is in the interests of clarity, and makes clear the distinction between integers and logical values.

Also for convention sake; while false == 0, and true == 1, if (2) and if (true) are the same, but true != 2. So it would be weird if we only enforced boolean values for true values, and not for negative as well.

@Abramo-Bagnara  you need to fix the commit messages

Now it should be ok.

Now it should be ok.
@Abramo-Bagnara  Please make sure fetch the branch and rebase on top of it. We will be merging backports and fixes and their are CI improvements going into this branch. This way we will not run CI with older scripts in the branch. Thanks. I did this now for this PR.


Suggestion: Multi-paragraph Path Description (margin)

When you have a path description (in markdown) with multiple paragraphs it will render it as:

first paragraph

second paragraph

(which is perfect!)
But this will add the second paragraph with a top margin of 24px. As by:
.m-markdown-small p:not(:first-child), .m-markdown p:not(:first-child) {
    margin-block-start: 24px;
}

I think this is a bit much as this makes the box its it in much bigger. And most often does not look that great (as it is also cut of after some amount of characters)

Just removing the margin there or making it much smaller looks nice in my opinion.
No margin:

Margin 5px:

well it takes care of very specific issue where you have just two paragraphs, but wont work with 3 paragraphs,
It will also create issue with the markdown else where, such as in field-description, request/response descriptions where people expect to have difference between newline and new-paragraph .
IMO, if you want to put contents in two line then use two lines in the markdown not two paragraphs
first line  <-- use 2 spaces after last word for new line
second line

I dont think our UX team would agree to change paragraph(
) styles to new line(
) style, they both will carry their distinct look

I'm not suggesting to change this in all cases there just in this location.
I agree that there should be a difference between
 and
 but in this case I thing 24px is a bit excessive.
I would like to change this in my own view. But the shadow dom does not allow me change things from outside the shadom dom. And forking and compiling my own instance is a bit much for such a small change.

okay

Still wanted to thank you for reconsidering this. Looks good! :heart:


Clarify language re: function arguments

Summary of changes
Configured indicates that the function code's itself would be configured, not that it is used by an external party. Switch verb to "used" to be clearer as to how the function is being used.
Pull Request Checklist

[ ] Changes have tests
[ ] News fragment added in [changelog.d/].
(See [documentation][PR docs] for details)

Thank you very much @moshekaplan


Lookup pins before read_pin

This will create sensor_values even if NamedPin
is not used

Coverage decreased (-0.3%) to 30.87% when pulling 0e5699d75f410cff33785e7ef97aee7cf32ad1b4 on sensors into 291f54f9e17f04ce05fe6f8b87da621a395b63a2 on next.


[feature required] pouch info  cmd return more result

Ⅰ. pouch info  cmd return more result
pouch info cmd return more result ,such as daemon port ,listen address and so on
Ⅱ.

@ZouRui89 Can you help to finish this feature,  thanks a lot.


docs: rewrite all controls type to use constructor API

after digging through tests, I found the kitchen sink test which showed how to use controls with the new constructor API and figured id port over the legacy controls API to the new constructor API.

Thanks for the contribution. We need much more help on the docs so future PRs vey much welcome

Thanks @ParamagicDev ! Here is an issue with a checklist of help the project needs with documentation: https://github.com/jonspalmer/view_component_storybook/issues/54


Not working - Permission error

Tried to run this on windows ubuntu and got an error.


[Docenhancement][Nextsteps][1837823]

Next steps and See also updated. Please verify.

Docs Build status updates of commit 3d64e62:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/prerequisites.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 452e4c9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-blazor.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-app-bot.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-app-react.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-app-spfx.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-message-extension.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/prerequisites.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f819440:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-blazor.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-app-bot.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-app-react.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-app-spfx.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-message-extension.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/prerequisites.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Typo / Grammar fix

Fixed a typo in the contributing.md and a grammar issue in the generator-open-wc section.
Added and categorized the generators

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

can you change chore(generator-open-wc): fix grammar issue to fix(generator-open-wc): grammar issue
as this will be released to be visible on npmjs.

uh also there are more generators
maybe better split it?
primary entry points:

open-wc:vanilla
open-wc:lint
open-wc:testing
open-wc:testing-upgrade
open-wc:publish-storybook

optional entry points:

open-wc:testing-wallaby

sub generators:

open-wc:vanilla-bare
open-wc:lint-eslint
open-wc:lint-prettier
open-wc:lint-commitlint
open-wc:testing-bare
open-wc:testing-karma
open-wc:testing-karma-bs
open-wc:tools-circleci

If you click on Details by Deploy preview ready!
you can see https://deploy-preview-105--nervous-stonebraker-1f429b.netlify.com/
I think it looks fine 🤗


More flexible similarity distance handling

I found that default similarity threshold in compression.py (0.38?) does not always work great. With some embedding models i had to lower it and there is no way to do it other than editing code.
Does it make sense to move this to the config?
Also when there are no hits within set similarity threshold, is it possible to print the nearest distance found (when verbose is on)?

Hey @barsuna done here: https://github.com/assafelovic/gpt-researcher/commit/7be4efd4ccfd146201ae336b8ea25854463d0e7e
Thanks for the feedback! Regarding verbose, would be over engineering in my opinion, but you can always debug and modify the code if needed. Thanks!


chore(main): release 3.0.0

:robot: I have created a release beep boop
3.0.0 (2022-12-21)
⚠ BREAKING CHANGES

changed signature of HealthModule to use forRoot, changed MetricsModule to use forRoot to conform to other modules.

Features

added health module builder (2aa1413)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/flowcore-io/library-flowcore-microservice-ts/releases/tag/v3.0.0 :sunflower:


ownership, sig-buildsystem: add reviewers, add OWNERS files

What this PR does
Before this PR:
The special files and folders for build system components, i.e. automation/ were lacking OWNERS, so that most PRs changing these were assigned to the global reviewers group.
After this PR:
Some more reviewers to the sig-buildsystem, also some OWNERS files are placed and the group of reviewers is extended. This makes reviews of PRs that change build system components to be assigned to the build system folks.

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
We surely have not hit everything in this first run, but follow up PRs can refine this matter.
The following alternatives were considered:
Links to places where the discussion took place:  To be added
Special notes for your reviewer

Not sure whether we want to have additional reviewers and approvers?
https://github.com/kubevirt/project-infra/pull/3236 adds labels that will then get applied automatically

/cc @brianmcarey @enp0s3 @xpivarc

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

Extend OWNERS for sig-buildsystem

/cc @fabiand FYI

/verify-owners

:stop_sign: please refrain from manual retesting.
:warning: this PR is being held to stop automatic retesting. Quarantine PR https://github.com/kubevirt/kubevirt/pull/11244 is given priority.
/hold

/test pull-kubevirt-generate

/test pull-kubevirt-e2e-k8s-1.29-sig-storage

/unhold

/lgtm
What is missing here?

@fabiand not sure - seems tide is stuck somehow :shrug:

Seems like prow is retesting #11109 (7e4fe04) by RamLavi
#11202 (828a7d2) by AlonaKaplan on a batch.
https://prow.ci.kubevirt.io/?repo=kubevirt%2Fkubevirt&type=batch


Pseudopotential routines

Move pseudopotential routines to src/atom/pp

I'm so surprised by this easiest solution. Thank you for implementing, @uemoto1 san.


Inform user of quickstart stop commands

The "Local - No Docker" quickstart explains how there are two commands for starting up your controller startZitiController and router startExpressEdgeRouter but doesn't mention that there are also simple commands already sourced that will stop the processes. Those would be stopZitiController and stopAllEdgeRouters
It would be nice to add a section explaining that these commands are already provided by the express install, no need to find and kill the processes manually.

Resolved by https://github.com/openziti/ziti-doc/pull/325


Fix logging on py3 Twisted > 16

fixes #749, fixes #765
We should probably move to the new Twisted logging API, but this fixes it for now.

Codecov Report

Merging #774 into master will increase coverage by 0.9%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #774     +/-   ##
=========================================
+ Coverage   49.24%   50.15%   +0.9%
=========================================
  Files          36       36
  Lines        3306     3306
  Branches      471      471
=========================================
+ Hits         1628     1658     +30
+ Misses       1578     1542     -36
- Partials      100      106      +6

Impacted Files
Coverage Δ

lib/carbon/log.py
59.84% <ø> (+22.72%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace672d...9b37fd6. Read the comment docs.

Looks good, thanks!


net/http: http/2 throughput is very slow compared to http/1.1

What version of Go are you using (go version)?
1.7

$ go version
go version go1.17 linux/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
Linux, Windows, etc
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/user/.cache/go-build"
GOENV="/home/user/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/user/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/user/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.17"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/user/dev/http2issue/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build38525640=/tmp/go-build -gno-record-gcc-switches"

What did you do?
test http/2 vs http1.1 transfert speed with client and server from standard lib
see a complete POC here: https://github.com/nspeed-app/http2issue
The issue is general, loopback (localhost) or over the wire.
What did you expect to see?
same speed order than http1.1
What did you see instead?
http/2 is at least x5 slower or worst

You're comparing encrypted HTTP/2 with unencrypted HTTP. You need to compare HTTP/2 with HTTPS to compare like with like.

hi, the POC is using H2C to avoid encryption.
I also compared encrypted versions with the product we're developing and we have the same issue.

hi, the POC is using H2C to avoid encryption.

Apologies, I missed this in the original issue and didn't see the followup.
I have not had time to look at this further, adding to my queue. (But no promises on timing.)

Wouldn‘t the first step be to run this against a non-go server/client to localize it on either side if possible?

Robert Engels has a CL related to this https://go-review.googlesource.com/c/net/+/362834

Copying my comment from https://groups.google.com/d/msgid/golang-nuts/89926c2f-ec73-43ad-be49-a8bc76a18345n%40googlegroups.com
Http2 is a multiplexed protocol with independent streams. The Go implementation uses a common reader thread/routine to read all of the connection content, and then demuxes the streams and passes the data via pipes to the stream readers. This multithreaded nature requires the use of locks to coordinate. By managing the window size, the connection reader should never block writing to a steam buffer - but a stream reader may stall waiting for data to arrive - get descheduled - only to be quickly rescheduled when reader places more data in the buffer - which is inefficient.
Out of the box on my machine, http1 is about 37 Gbps, and http2 is about 7 Gbps on my system.
Some things that jump out:

The chunk size is too small. Using 1MB pushed http1 from 37 Gbs to 50 Gbps, and http2 to 8 Gbps.

The default buffer in io.Copy() is too small. Use io.CopyBuffer() with a larger buffer - I changed to 4MB. This pushed http1 to 55 Gbs, and http2 to 8.2. Not a big difference but needed for later.

The http2 receiver frame size of 16k is way too small. There is overhead on every frame - the most costly is updating the window.

I made some local mods to the net library, increasing the frame size to 256k, and the http2 performance went from 8Gbps to 38Gbps.

I haven’t tracked it down yet, but I don’t think the window size update code is not working as intended - it seems to be sending window updates (which are expensive due to locks) far too frequently. I think this is the area that could use the most improvement - using some heuristics there is the possibility to detect the sender rate, and adjust the refresh rate (using high/low water marks).

The implementation might need improvements using lock-free structures, atomic counters, and busy-waits in order to achieve maximum performance.

So 38Gbps for http2 vs 55 Gbps for http1. Better but still not great. Still, with some minor changes, the net package could allow setting of a large frame size on a per stream basis - which would enable much higher throughput. The gRPC library allows this.

My CL goes a long way to addressing the issue.
Still, some additional testing has shown that the calls to update the window from the client (the downloader) don't seem to be optimal for large transfers - even with the 10x frame size. The window update calls cause contention on the locks.

Changing trasport.go:2418 from
if v < transportDefaultStreamFlow-transportDefaultStreamMinRefresh {
to
if v < transportDefaultStreamFlow/2 {
results in a nearly 50% increase in throughput using the default frame size of 16k.

I don't know if you are referring to this buffer in one of your comments, but using the profiler it shows a lot of contention on the bufWriterPool
https://github.com/golang/go/blob/0e1d553b4d98b71799b86b0ba9bc338de29b7dfe/src/net/http/h2_bundle.go#L3465-L3468
Increasing the value there to the maxFrameSize value, and using the shared code in the description, you can go from 6Gbps to 12.6 Gbps

As I pointed out above, increasing the frame size can achieve 38 Gbps. The issue is that constant is used for all connections. The 'max frame size' can connection dependent.
More importantly, that constant does not exist in golang.org/x/net/http - which is the basis of the future version.

As I pointed out above, increasing the frame size can achieve 38 Gbps. The issue is that constant is used for all connections. The 'max frame size' is connection dependent.

yeah, I've should explained myself better, sorry, in addition to increase the frame size that require manual configuration, it is an user decision to maximize throughput, I just wanted to add that maybe we can improve the default throughput with that change, since it is clear that the author left open that parameter to debate and it is a 2x win (at a cost of increasing memory cost of course, but this is inside a sync.Pool that may alleviate this problem a bit)

More importantly, that constant does not exist in golang.org/x/net/http - which is the basis of the future version.

it does, just with a different name :smile:
https://github.com/golang/net/blob/0fccb6fa2b5ce302a9da5afc2513d351bd175889/http2/http2.go#L256-L259
IIUIC the http2 code in golang/go is a bundle created from the x/net/http2

Thanks for the excellent analysis!
Ideally, we shouldn't require the user to twiddle configuration parameters to get good performance. However, making the maximum client-initiated frame size user-configurable seems like a reasonable first step.

any update to this ? is someone at Google even working on this or is there no point waiting ?

There has been a CL submitted - it is stuck in review.

There has been a CL submitted - it is stuck in review.

some update: according to https://groups.google.com/g/golang-dev/c/qzNbs3phVuI/m/fcFcCCsaBQAJ
Your CL awaits a response from you.

The scope get going beyond what was necessary to address the issue. The last comment isn’t a question or change request - it simply an idea.

I am more than willing to make additional changes but I need specifics.

Sorry you felt that the review scope was expanding. For what it's worth, I thought my last comment on that CL was actionable: The Transport.MaxReadFrameSize setting needs to be consistent with Server.MaxReadFrameSize:

The default value when Transport.MaxReadFrameSize is 0 should be 1MiB, for consistency with Server.MaxReadFrameSize.
The doc comment for Transport.MaxReadFrameSize should match that of Server.MaxReadFrameSize.
An out-of-spec value for Transport.MaxReadFrameSize (outside [16KiB, 16MiB]) should be treated as the default, again for consistency with Server.MaxReadFrameSize.
The client should always send the SETTINGS_MAX_FRAME_SIZE option.

Apologies for not being clearer.
For general reference, Gerrit has a feature called the "attention set", which is the set of people who will see a CL in their dashboards. Reviewers with their name in bold are in the attention set. If you'd like a response from a reviewer make sure that they're in the attention set, because otherwise it's pretty invisible. The author making comments on a CL should add all the reviewers into the attention set.
In addition, if you think that a reviewer's comments are insufficiently actionable, out of scope, or just not worth doing, it's always okay to tell us that.
One thing I mistakenly didn't note in the review of https://go.dev/cl/362834 is that since this is expanding the API surface of golang.org/x/net/http2, it should have a proposal. I just filed #54850 with a proposal.
@robaho, if you would like to update your CL, I'm happy to continue reviewing it. Otherwise, I'll take over adding the Transport.MaxReadFrameSize setting after #54850 is approved.

Sorry, after signing in I saw that a couple of comments I had drafted remained in the draft state and were never sent.

For my info, when would https://go.dev/cl/362834 be available in a Go release? Is it eligible for 1.19.x or only 1.20?

per minor release policy this should only be in for 1.20

I've been watching this issue as a user of Caddy.
I'm seeing from the proposal https://github.com/golang/go/issues/54850 and the merged changes that changes are only being made to the HTTP/2 transport (i.e. client).
Apparently there already exists a MaxReadFrameSize option in the HTTP/2 server, but we're using the http.Server auto-configure right now; I don't see any way to set MaxReadFrameSize via http.Server, unless I'm missing something obvious.
Is the plan to adjust the automatic behaviour so that it's tuned better by default for the server as well? If not, how are we meant to tune this knob? I'd rather not have to stop using http.Server's auto-configure so that we can fix this performance issue.

You can pass in the http.Server to modify MaxReadFrameSize:
	http2.ConfigureServer(<your http.Server obj>, &http2.Server{
		MaxReadFrameSize:             256000, // 256K read frame, https://github.com/golang/go/issues/47840
	})

Fixing it on the server won’t help. A properly written server uses the value provided by the client or the default - which is 16k.
Changing the server side typically either 1) is telling the client how big a buffer it will receive or 2) restricting the size received from the client.
The connections are bidirectional with independent values for client and server.

According to https://github.com/golang/go/issues/47840#issuecomment-905611127 they were seeing performance problems with Caddy without an HTTP/2 client (e.g. Caddy's reverse_proxy, which can use an HTTP/2 transport, either H2C or HTTPS). So I'm not sure I understand. How would we fix the performance issue in Caddy, then?

I don’t know what Caddy is, but often http2 will be used behind the scenes automatically.

Caddy is a general purpose HTTP server written in Go. Configurable by users via a config file. Supports HTTP 1/2/3.
Yes, we do get HTTP/2 support automatically from Go stdlib. But you can see from https://github.com/nspeed-app/http2issue#caddy that they had performance issues with HTTP/2.

Many http2 clients have this issue - not just Go. But I’m not sure I understand your comment.

In https://github.com/nspeed-app/http2issue#caddy, they used curl as the client, with Caddy as the HTTP/2 server (i.e. Go stdlib implementation). Do you think curl is causing a bottleneck, then?
I don't have a deep enough understanding of HTTP/2 internals to know where the problem lies. I'm just trying to grasp if there's anything we (Caddy maintainers) should do to mitigate any performance issues for our users.

Yes. You need to provide similar options to the curl command to increase the buffer size.

libcurl uses nghttp2 for http2 support. I submitted similar changes to nghttp2 here

The other related nghttp2 issue is https://github.com/nghttp2/nghttp2/issues/1647 which doesn't appear the author wants to fix as suggested.

Have also the same issue, in my case HTTP/2 is always half of speed with HTTP/1.1 (server exposing DICOMWeb APis).
Tried all the settings like MaxReadFrameSize = 16MB or MaxConcurrentStreams = 250, still no improvements.
Using go version 1.20.2.

I ran some http1 vs http2 benchmarks and found that http2 throughput suffers the larger the files are.
Changing the tcp congestion control algo to "bbr" helped a lot (https://blog.cloudflare.com/http-2-prioritization-with-nginx/).
ttfb and bandwidth improved by 10x...
fwiw, I ran some node.js benchmarks and http2 also performs worse than http1.
I'll just wait for http3 🤷

as mentioned prior, you need to ensure both sides of the connection are fixed.

probably but since we opened this issue, the Go team made some changes to http/2 performance:
We made a small program here: https://github.com/kgersen/h3ctx  to benchmark the 3 versions of HTTP.
Here are some result for http/1.1 vs http/2 vs http/3 :
HTTP/1.1             13.8 Gbps
HTTP/2               5.2 Gbps
HTTP/3 with GSO:     4.7 Gbps
HTTP/3 without GSO:  1.6 Gbps

It's a test on the loopback interface with tls 1.3 (so it's a cpu bound test but the same perf ratios are observed between multigigabit machines).
Without HTTP/2 explicit settings, HTTP/1.1 is >2x faster.
With Go 1.7 it was x5
Now with Go 1.21.1  when using explicit HTTP/2 settings (MaxReadFrameSize) we can double HTTP/2 performance:
Here are some sample results from our app made with Go and using such explicit settings for HTTP/2:
batch #0:
 Id| Read speed| Write speed| Time| Bytes read| Bytes written|command
 #1|  16.4 Gbps|       0 bps| 8.00|    16.4 GB|           0 B|get -http1.1 https://[::1]:40129/20g (IPv6 - 0.122 ms - HTTP/1.1 - TLS 1.3)

batch #1:
 Id| Read speed| Write speed| Time| Bytes read| Bytes written|command
 #3|  10.4 Gbps|       0 bps| 8.00|    10.4 GB|           0 B|get -http2 https://[::1]:45075/20g (IPv6 - 0.99 ms - HTTP/2.0 - TLS 1.3)

so 16 Gbps for HTTP/1.1 vs 10 Gbps HTTP/2
Over the Internet, the congestion protocol can also change the result if there is congestion and packet loss, even more if you're competing with other machines using bbr without using bbr yourself but this impact should be the same for both version of HTTP.
Our preliminary measures with HTTP/3 (quic-go) are that not good (there is no MaxReadFrameSize setting to boost performance like with HTTP/2). The Go team own HTTP/3 implementation is still been developed so no results yet.
tl;dr: keep using HTTP/1.1 if bandwidth performance is an issue (pushing big data over high speed networks.

I came here by trying to understand this issue from GitLab, where multiple people are noticing very slow uploads when using kaniko for Docker push. So it seems to me there are still some issues with speed?

As I showed above it is possible to have http/2 match the performance of http/1 with the changes I detailed.
The changes are aligned with the http/2 specification.

A properly written server uses the value provided by the client or the default - which is 16k.

@robaho Does the x/net/http2 server implementation do this? And if not would this mean that regardless of the fact that https://go.dev/cl/362834 is now merged on the client side,  the x/net/http2 server will not actually use the value provided by the x/net/http2 client?

Fixing it on the server won’t help. A properly written server uses the value provided by the client or the default - which is 16k.

@robaho For my understanding, does the current http2 server implementation in go honour the value when provided by the client (up to a maximum)? Or would that be the next step after https://go.dev/cl/362834 was merged?

As I said earlier - there is a setting for both directions. Slow uploads imply a too small frame size on the server. Slow downloads imply a too small frame size on the client.
It has been a while since I looked at this so your mileage may vary.

HTTP/2 Client also its so slow
config:
	jar, _ := cookiejar.New(&cookiejar.Options{PublicSuffixList: publicsuffix.List})
	// Create a custom transport with TLS 1.3 configuration
	transport := &http.Transport{
		TLSClientConfig: &tls.Config{
			MinVersion: tls.VersionTLS13,
			MaxVersion: tls.VersionTLS13,
			CurvePreferences: []tls.CurveID{
				tls.X25519,
			},
			// Set Session Ticket TLS if the server sending Ticket
			ClientSessionCache: tls.NewLRUClientSessionCache(0),
		},
		ForceAttemptHTTP2: true,
	}
	// Enable HTTP/2 for the transport
	if err := http2.ConfigureTransport(transport); err != nil {
		// Handle error, e.g., log or return it
		log.Print(err)
	}

Caller:
		Client: &http.Client{
			Timeout:   15 * time.Second,
			Jar:       jar,
			Transport: transport,
		},

I have the same experience. On localhost:

echo server h2c + h2load, 500k req/s
echo server h2c + go http2 client: only about 70k req/s
echo server http1 + go http client about 40k req/s
echo server http1 + go fasthttp http1 client 75k req/s

:S.
So it seems hosting http2 on go is no problem, but the http2 client available seems incredibly inefficient.


Workspace files are being saved one folder above

This happens in Insiders v1.41.0

VSCode Version: 1.40.1
OS Version: macOS 10.15.1

Steps to Reproduce:

Open a folder
File -> Save Workspace As...
Choose the folder
Notice that the .code-workspace file is not saved inside the folder you chose, but one folder above.

Does this issue occur when all extensions are disabled? Yes

I think this is expected macOS behavior and that all macOS apps behave that way.
Can you attach a short gif which shows this behavior? Also can you check some native mac app does this differently?

Hey @isidorn, not at all. macOS works the same in this respect: you open the folder you want to save your file to. If this were the intended behavior you could never save a file to a folder that contained no child folders :)

Thanks for the video, this clarifys things.
This is not the native dialog, but the custom file picker. Forwarding to @alexr00 and she can continue the investigation

I can reproduce the issue on Windows. The video was very helpful, thanks!

Looks like it only happens when you don't provide a name...

You're very welcome @alexr00! Thanks for the fix 👌


[FEATURE REQUEST] Ability to Define Node-Sensor Limits/Requests

It would be beneficial to monitoring our clusters to have CPU and Memory Request and Limits set on these pods so they are limited into how much resources they can take up per node.
Right now with nothing defined they can consume as much as they want, which is bad when trying to manage the cluster resources.

are you asking for Falcon-Container (sidecar) ? or Falcon-sensor as DaemonSet ?
For Falcon-Container you can do it actually : https://github.com/CrowdStrike/falcon-operator/blob/main/config/samples/falcon_v1alpha1_falconcontainer-all-options.yaml#L43-L49
For falcon-sensor as DaemonSet it's risky because Kubernetes could kill the pod if resources are too low. This sensor was designed to consume few resources.

This was for the Flacon-sensor as a DaemonSet
I can see you point about k8s killing it, if it runs out of resources.
Just a though I had, but we can close this.


Integrate OAK-4847 from trunk

With this issue there's no need for the HasNativeBuilder.

Great, this means that we don't have any API leakage from the MultiplexingNodeStore.
Thanks!


accepted_statuscodes: expected a sequence

Hello,
I'm running into an issue when setting up expected HTTP statuses:
WARN [autokuma::sync] Encountered error during sync: Error while trying to parse labels: invalid type: string "301", expected a sequence
WARN [kuma_client::util] Error while parsing jackett: invalid type: string "301", expected a sequence!

Here is my config docker-compose service labels:
      - "kuma.my-stack.group.name=My Stack"
      - "kuma.{{container_name}}.http.name={{container_name}}"
      - "kuma.{{container_name}}.http.parent_name=my-stack"
      - "kuma.{{container_name}}.http.url=https://{{container_name}}.xxx.tld"
      - "kuma.{{container_name}}.http.accepted_statuscodes=301"

Is it an issue or am I doing it wrong?

This should work:
      - "kuma.my-stack.group.name=My Stack"
      - "kuma.{{container_name}}.http.name={{container_name}}"
      - "kuma.{{container_name}}.http.parent_name=my-stack"
      - "kuma.{{container_name}}.http.url=https://{{container_name}}.xxx.tld"
      - "kuma.{{container_name}}.http.accepted_statuscodes=["301"]'

Still the same:
WARN [kuma_client::util] Error while parsing jackett: invalid type: string "[\"301\"]", expected a sequence!
WARN [autokuma::sync] Encountered error during sync: Error while trying to parse labels: invalid type: string "[\"301\"]", expected a sequence

Sorry if I'm not familiar with Rust to give you more information :/

Parsing should be fixed now

Running into a similar issue, trying to use status codes in a snippet:
{{ id }}-ping-monitor.ping.accepted_statuscodes: {{ args.status_codes }}

'{"status_codes": ["200-299","401","403"]}'

But seems it's parsing those as integers:
Encountered error during sync: Error while trying to parse labels: invalid type: integer `200`, expected a string at line 1 column 4


fix: add missing gmtime_r check

909069ea8237b7261e21c47607fc89a16610a8f9 introduced optional gmtime_r support but did implement the function's availability check.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e3f5398) 64.78% compared to head (f138254) 69.66%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
+ Coverage   64.78%   69.66%   +4.87%
==========================================
  Files          19       19
  Lines        3334     4378    +1044
  Branches     1128     1761     +633
==========================================
+ Hits         2160     3050     +890
- Misses        741      852     +111
- Partials      433      476      +43

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cognito

Codecov Report

Merging #14 (7fab965) into main (5910fa5) will increase coverage by 1.80%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   75.39%   77.20%   +1.80%
==========================================
  Files           9       10       +1
  Lines         126      136      +10
  Branches       31       32       +1
==========================================
+ Hits           95      105      +10
  Misses         31       31

Impacted Files
Coverage Δ

src/cognito.ts
100.00% <100.00%> (ø)

src/inspect.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5910fa5...7fab965. Read the comment docs.


SSH key management for users in UI

A user should be able to manage their SSH keys via the Lagoon UI

This is in Lagoon 1.3.0 https://github.com/amazeeio/lagoon/pull/1552


add: HSLU simple MEP results

Not really sure, how to add this... hope this works :)

hope this works :)

No.
### HSLU simple MEP results

_A browser add-on that extends the page 'Meine Anmeldungen' on the HSLU MyCampus website._

[eddex/hslu-simple-mep-results](https://github.com/eddex/hslu-simple-mep-results)

Features:
- A simple table with all your modules, credits and grades
- An overview of how many modules of each type have been done / are still needed.
- An overview of your grades including grade distribution and average.
- A chart to visualize your credit progress.


Add jupyter notebook bash kernel

added line to the requirements file.

How do we handle Windows users? Should we leave a note in the README telling them to comment out the bash-kernel dependency? Or have instructions for WSL?

I think Windows users can use a bash kernel in Jupyter? https://gist.github.com/osamashiraz/a18647716b9d3d62fad8a39f37fe39f8

How do we handle Windows users? Should we leave a note in the README telling them to comment out the bash-kernel dependency? Or have instructions for WSL?

I think Windows users can use a bash kernel in Jupyter? https://gist.github.com/osamashiraz/a18647716b9d3d62fad8a39f37fe39f8
Or could they just select the bash kernel from inside the Jupyter notebook if it is included in the requirements?

So maybe just add (and try) this instructions

I can help get wsl working on your computer, I used to use it a lot. Then we can test it and get the steps we need to add to the README

issue #13  address testing volume-data-converter scripts and windows users.


Add native build info to export.html

Your email explaining how to generate native builds was incredibly helpful so I thought others might benefit from it! ^__________________^

Thanks!

Oof, I goofed up on the url for amulet! Can you fix it? Line 54. Just gotta add in http://

Fixed!
On Mon, Oct 2, 2017 at 4:12 PM, Nick<EMAIL_ADDRESS>wrote:

Oof, I goofed up on the url for amulet! Can you fix it? Line 54. Just
gotta add in http://
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ianmaclarty/vertex-meadow/pull/14#issuecomment-333442361,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADDfy1rAj1mJTPz3n-nP8BMiuxQDa2Juks5soHC1gaJpZM4PqLdC
.


[ISSUE #2275]Fix register error by nacos

// Describe your PR here; eg. Fixes #2275

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #2305 (e37243a) into master (29cb757) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2305      +/-   ##
============================================
- Coverage     58.37%   58.14%   -0.23%
+ Complexity     3966     3958       -8
============================================
  Files           627      627
  Lines         18059    18056       -3
  Branches       1710     1708       -2
============================================
- Hits          10542    10499      -43
- Misses         6658     6696      +38
- Partials        859      861       +2

Impacted Files
Coverage Δ

...che/shenyu/sync/data/http/HttpSyncDataService.java
63.10% <0.00%> (-18.45%)
:arrow_down:

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
82.35% <0.00%> (-11.77%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
54.73% <0.00%> (-8.43%)
:arrow_down:

...he/shenyu/plugin/grpc/client/ShenyuGrpcClient.java
8.69% <0.00%> (-4.35%)
:arrow_down:

...henyu/admin/service/impl/UpstreamCheckService.java
23.57% <0.00%> (-4.07%)
:arrow_down:

...che/shenyu/admin/model/vo/SelectorConditionVO.java
96.07% <0.00%> (-1.97%)
:arrow_down:

...henyu/plugin/httpclient/NettyHttpClientPlugin.java
54.54% <0.00%> (-1.82%)
:arrow_down:

...rg/apache/shenyu/plugin/hystrix/HystrixPlugin.java
74.07% <0.00%> (-0.93%)
:arrow_down:

.../plugin/grpc/loadbalance/AbstractLoadBalancer.java
69.56% <0.00%> (-0.33%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29cb757...e37243a. Read the comment docs.


subject with labels

Your samples suppose some simple relations with literals
In my data, I have some classes with links (by predicate) and each object has his own label
For simplified example:
theme22 hasSubject subject12
subject12 hasTopic topic35
topic35 rdfs:label "Fribourg"@fr
subject12 hasRole role75
role75 rdfs:topic "study"
theme22 rdfs:label "Study of the map of Fribourg"
The only predicate which address literals is rdfs:label
I'm searching how to define matchers and templates to display a theme and can't find how to

Please be noted that this version of Uduvudu is not anymore maintained. Please use https://github.com/uduvudu/uduvudu for an updated version!
There you find also some basic info about the use of the matchers: https://github.com/uduvudu/uduvudu/blob/master/doc/matcher.md
HTH

If any other questions arise ... please open a ticket over there.


Google Breakpad integration

!WARNING! This is work in progress. Please, don't merge!
In order to better handle runtime crashes we need to integrate Google Breakpad.

NOTE: After pushing all the necessary commits, I'll share docs and usage example in comments section of this PR (and later I'll add those to README.md).

UPDATE: Latest CI build for Linux and macOS look OK. Investigating Android and Windows issues...

UPDATE: Breakpad issues for Anroid CI build are fixed.
Windows is still in progress...

UPDATE: Windows builds are finally green too 🙂
I'll add a few more commits and some docs/examples tomorrow.

@exploshot @nnian @Xecute0101 @who-biz
Please, make a simple test:

Clone changes from this branch;
Modify src/ConnectivityTool/ConnectivityTool.cpp main function:

// Before
Qwertycoin::Breakpad::ExceptionHandler exceptionHandler;

// After
Qwertycoin::Breakpad::ExceptionHandler exceptionHandler;
Qwertycoin::Breakpad::ExceptionHandler::dummyCrash();
return 0;

Compile and run connectivity_tool, it shoud crash with a similar message:

Minidump path: Going to crash...
ERROR: Process crashed! Minidump created.
Minidump dir: /tmp, id: 6393218B-DE63-4478-A73B-53804A2B11A4

Then in /tmp dir (on Linux and macOS) or C:\Windows\Temp (on Windows) you should find a file with a name like 6393218B-DE63-4478-A73B-53804A2B11A4.dmp.

NOTE: This is a simple test that will confirm that breakpad exception handler works as expected.
NOTE2: In further updates I'll post information on how to read those generated *.dmp files.

@exploshot @nnian @Xecute0101 @who-biz
Please, make a simple test:
1. Compile and run connectivity_tool, it shoud crash with a similar message:
Minidump path: Going to crash...
ERROR: Process crashed! Minidump created.
Minidump dir: /tmp, id: 6393218B-DE63-4478-A73B-53804A2B11A4

1. Then in `/tmp` dir (on Linux and macOS) or `C:\Windows\Temp` (on Windows) you should find a file with a name like `6393218B-DE63-4478-A73B-53804A2B11A4.dmp`.

Yep it works!

@nnian great! And thanks for the update!
PS: Tomorrow I'll post a short doc on how to read those .dmp files 🙂

Is it done?

@nnian oops, sorry, I forgot to revert one line that is unrelated to this PR. I'll do it in a moment. And then, once you see green CI build, you can merge it 🙂

@nnian Travis CI failure can be ignored. It failed due to Travis CI build time limitations. I think this "error" can be ignored.

@nnian @exploshot @who-biz @Xecute0101 I think that we can merge this PR unless you have any extra comments 🙂


test(cli): add tests for display_deptry_version

Extracted from https://github.com/fpgmaas/deptry/pull/861.

Windows PyPy 3.10 do not seem to randomly fail anymore since https://github.com/fpgmaas/deptry/pull/921, but they now take a really long time to run. Will try to debug this...


SS9 : Topic Collection

Collect topics for the next meetup
Date: July 27th 2024
Announcements

Suggested Topics and Developments
Bitcoin

Mining

Lightning

Ecash

Other Bitcoin Tech

Regulatory

Extras

Upcoming Events

Other: Security - regreSSHion vulnerability and how it affects funds in your bitcoin/lightning node

Bitcoin: 0xB10C weird bitcoin transaction

Lightning: Phoenix shipd Bolt 12

Instantly top-up under-funded lightning channels with ecash.
https://njump.me/nevent1qqsdws9tytu94h6rgkzm2ssca6q3t33ms9cd3mfmmv6p0yez0snzj5gpz4mhxue69uhhyetvv9ujuerpd46hxtnfduhsygzsm98u9kzcp35zkpc62shck8335gqtq5yt4w26xwl0pp2a72qavvpsgqqqqqqs24h8vx

Ecash: cashu binary-encoded tokens

Bitcoin: [10 (now fixed) vulnerabilities announced(https://bitcoinops.org/en/newsletters/2024/07/05/)

Lightning: Phoenix supports BIP-353 addresses

Guide: How to Use Boltz Client's Autoswap to Automate Your Lightning Liquidity Management

Other: DLCs implemented on Cashu

I will add some mining topics today


VS-2019 and VS-2022 splash screens are vulgar (too big)

Describe the feature you are requesting
Me and my colleguaes find that the size of the splash screen in VS-2019 and VS-2022 is way too big. Here is 1920x1080 Windows 1.25x scaling instances from 2019 and 2022:

Compare to 2017:

Reasons for requesting this feature
The splash screens take almost entire screen. This looks vulgar.
Describe alternatives you've considered

Reduce the size of the splash screen to VS-2017 dimentions.
Allow to explicitly disable splash screen in VS settings (not /nosplash)

Thanks for your feedback, we are PTVS-specific team so this is really beyond what we can do.😊So I would recommend submitting a feedback here: https://learn.microsoft.com/en-us/visualstudio/ide/suggest-a-feature?view=vs-2022
Thanks!!


Making the  torchlive-cli init command independent of locally installed Python version

Summary
TorchVision v0.11.1 needs the version 21.3.1 from PIP. Previously to this PR, the version of PIP depended on the version of Python that was installed locally:

See that it uses Python3, which was installed by the user. If the Python version installed locally cannot upgrade PIP to the version 21.3.1, then dependencies like TorchVision won't be installed and the command npx torchlive-cli init MyProject will result in an error (in the following case, Python3 has the version 3.7.12):

I am pretty sure this will make the installation process much easier as the user will avoid having problems related to the Python version and will not have to worry about doing any extra step (installing an specific version of Python, creating an alias for Python3 to point to the recently installed Python, ...).
The use of the flag --no-cache-dir is due to ARM. I had some .whl files downloaded locally that were not available for ARM. However, at the time of installing any dependency, PIP used that wheel and I run into some errors. Maybe there will be people using Apple Silicon in my position, so I find it useful to keep it in order to make the Python installation completely independent of the existing local files.
This solution also implements a function called makeModules used just to modulate the code. This function will be shared both by MacOS and Linux. However, we use a different package manager to install Python, so they cannot be joined.
The linux implementation was not checked since PyTorchLive is initially only focused on MacOS.
In conclusion, with this approach it no longer matters which version of Python is installed locally.
Changelog
[TEMPLATE] [TEMPLATE CREATION] - Making the torchlive-cli init command independent of locally installed Python version
Test Plan
First of all, if you're using an ARM CPU, you have to replace the make_models.js file with the one in the following pull request: RuntimeError related to quantization solved for ARM architecture. If you're using a x86 CPU it's not necessary that you perform this step.
In both cases, we're going to use the same command (feel free to change the name of the project and replace the path /Users/aaron/Documents/github/ by your absolute path to the current working directory where you are using the command):
$ npx react-native init LiveM1Test --template file://Users/aaron/Documents/github/live/react-native-template-pytorch-live/

Before
In this case, python3 -V outputs the version 3.7.12. This is the result of running the command specified before:

After
In this case, python3 -V still outputs the version 3.7.12. However, the script.js file uses its own version on the virtual environment. This is the result of running the command specified before:

@raedle Thank you so much for the detailed feedback, it has been very helpful to understand what are the problems and how to solve them!
I'll publish a pull request solving these bugs as soon as I can.

Thanks @aaronespasa for the PR! The torchlive-cli was deprecated and removed from the PlayTorch repo (i.e., it is no longer maintained). It is recommended to follow the React Native Environment Setup instructions on their website to get started with React Native development and PlayTorch


swapAdapter not overridden

The swapAdapter function is not overridden, so if you try to call it, it will replace it will replace RecyclerViewPagerAdapter instead of the contained Adapter

https://github.com/lsjwzh/RecyclerViewPager/commit/29631fa2c3a1d495464a5b3b532e434df6cab3c3

Thanks for your feedback.


Ability to delete from recommendation table

Description
Ability to delete from recommendation table
Fixes #162
Type of change

New feature (non-breaking change which adds functionality)
Documentation update

Testing steps
N/A
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report

Merging #166 (4975017) into master (9247aeb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   17.84%   17.84%
=======================================
  Files           3        3
  Lines         454      454
=======================================
  Hits           81       81
  Misses        362      362
  Partials       11       11

Impacted Files
Coverage Δ

storage.go
19.38% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9247aeb...4975017. Read the comment docs.


⚠ Bofrost.lu has degraded performance

In 18db07e, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1539 ms

Resolved: Bofrost.lu performance has improved in e8d322e after 13 minutes.


Update schema to include the relationships between documents

[ ] Include nested documents in relationships in schema definition will be used by nested query in Hasura Graphql Engine
[x] Include reference documents in relationships in schema definition will be used by nested query in Hasura Graphql Engine
[x] Update schema generation to include an allowlist of collections

Converted the tasks in a issue because it is blocked by Hasura


[BUG] The stream is fake

🐛 Bug Report

Lib version: 4.3.0
Steps To Reproduce

const ExcelJS = require('exceljs')

let workbook1 = new ExcelJS.stream.xlsx.WorkbookWriter({
    filename: './speedTest.xlsx'
});
let sheet = workbook1.addWorksheet('My Sheet');
let sheet2 = workbook1.addWorksheet('My Sheet2');

console.log('begin')
console.time('write to excel time')
const rowData = ['Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1Test 1', 1]

for (let i = 0; i < 500000; i++) {
    sheet.addRow(rowData).commit();
    sheet2.addRow(rowData).commit();
}
sheet.commit();
sheet2.commit();

workbook1.commit()
console.timeEnd('write to excel time')

amazing, cost 300M

The expected behaviour:
I think if a real stream, must only need a little memory.

I am also facing similar issue. @JianmingXia were you able to find some way to make it work?

Have the same issue

I solve this problem in this fork: https://www.npmjs.com/package/@zlooun/exceljs


⚠ Bofrost.be has degraded performance

In 01217c0, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 890 ms

Resolved: Bofrost.be performance has improved in 0387b40.


ptxas application ptx input, line 9; fatal   : Unsupported .version 7.3; current version is '7.2'

hello,I was testing test.py and then there are some bug ,I can't deal with them ,I want to be helped.
For more information about alternatives visit: ('https://numba.pydata.org/numba-doc/latest/cuda/overview.html', '#cudatoolkit-lookup')
warnings.warn(errors.NumbaWarning(msg))
Traceback (most recent call last):
File "/home/han/anaconda3/envs/OpenPCDet/lib/python3.7/site-packages/numba/cuda/cudadrv/driver.py", line 2161, in add_ptx
ptxbuf, len(ptx), namebuf, 0, None, None)
File "/home/han/anaconda3/envs/OpenPCDet/lib/python3.7/site-packages/numba/cuda/cudadrv/driver.py", line 300, in safe_cuda_api_call
self._check_error(fname, retcode)
File "/home/han/anaconda3/envs/OpenPCDet/lib/python3.7/site-packages/numba/cuda/cudadrv/driver.py", line 335, in _check_error
raise CudaAPIError(retcode, msg)
numba.cuda.cudadrv.driver.CudaAPIError: [222] Call to cuLinkAddData results in UNKNOWN_CUDA_ERROR
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "test.py", line 199, in
main()
File "test.py", line 195, in main
eval_single_ckpt(model, test_loader, args, eval_output_dir, logger, epoch_id, dist_test=dist_test)
File "test.py", line 63, in eval_single_ckpt
result_dir=eval_output_dir, save_to_file=args.save_to_file
File "/home/han/EDisk/OpenPCDet/tools/eval_utils/eval_utils.py", line 113, in eval_one_epoch
output_path=final_output_dir
File "/home/han/OpenPCDet/pcdet/datasets/kitti/kitti_dataset.py", line 361, in evaluation
from .kitti_object_eval_python import eval as kitti_eval
File "/home/han/OpenPCDet/pcdet/datasets/kitti/kitti_object_eval_python/eval.py", line 6, in
from .rotate_iou import rotate_iou_gpu_eval
File "/home/han/OpenPCDet/pcdet/datasets/kitti/kitti_object_eval_python/rotate_iou.py", line 263, in
def rotate_iou_kernel_eval(N, K, dev_boxes, dev_query_boxes, dev_iou, criterion=-1):
File "/home/han/anaconda3/envs/OpenPCDet/lib/python3.7/site-packages/numba/cuda/decorators.py", line 95, in kernel_jit
return Dispatcher(func, [func_or_sig], targetoptions=targetoptions)
File "/home/han/anaconda3/envs/OpenPCDet/lib/python3.7/site-packages/numba/cuda/compiler.py", line 899, in init
self.compile(sigs[0])
File "/home/han/anaconda3/envs/OpenPCDet/lib/python3.7/site-packages/numba/cuda/compiler.py", line 1102, in compile
kernel.bind()
File "/home/han/anaconda3/envs/OpenPCDet/lib/python3.7/site-packages/numba/cuda/compiler.py", line 590, in bind
self._func.get()
File "/home/han/anaconda3/envs/OpenPCDet/lib/python3.7/site-packages/numba/cuda/compiler.py", line 441, in get
linker.add_ptx(ptx)
File "/home/han/anaconda3/envs/OpenPCDet/lib/python3.7/site-packages/numba/cuda/cudadrv/driver.py", line 2163, in add_ptx
raise LinkerError("%s\n%s" % (e, self.error_log))
numba.cuda.cudadrv.driver.LinkerError: [222] Call to cuLinkAddData results in UNKNOWN_CUDA_ERROR
ptxas application ptx input, line 9; fatal   : Unsupported .version 7.3; current version is '7.2'

我也遇到了同样的问题

同样的问题

Same question

邮件我已收到。辛苦了。

This issue occurs when the toolkit version is newer than the CUDA version supported by the driver, because Minor Version Compatibility is not yet supported by Numba. I have a Numba PR to add support for it: https://github.com/numba/numba/pull/8180
In the meantime, you can also work around the issue by installing the cubinlinker and ptxcompiler packages:
conda install rapidsai::cubinlinker conda-forge::ptxcompiler

and using the Numba patch before running any Numba CUDA functionality:
from cublinlinker.patch import patch_numba_linker_if_needed
patch_numba_linker_if_needed()


Add connection params to config for ClientBuilder

The Elasticsearch ClientBuilder can take connection params, which can not be set at this point.
This pull request makes it possible to integrate token based auth.

Please create new branch from master for PR. (see CONTRIBUTING.md)


Fizes JSON array envelope parsing, adds unit tests

This fixes the issue with string array not being parsed as valid JSON and adds unit tests based on what's tested in end to end tests to catch early

@mchmarny Could you please open an issue for this and tag it for 0.9.0 project.

Fixes #390

I am not sure this can fix the issue...
data in CE payload is message-xxx as a plain text.. it is not array.. let me debug it more...
https://github.com/dapr/dapr/blob/159c16945d4e9da1e63bb134ceaa902866972a11/tests/e2e/pubsub/pubsub_test.go#L76

The test that was failing before was this (abbreviated)
Error Trace: pubsub_test.go:149
275 pubsub_test.go:200
276 Error: Not equal:
277 expected: []string{"message-100", "message-101", "message-102"}
278 actual : []string{"\"message-100\"", "\"message-101\"", "\"message-102\""}

The unit tests included with this PR test for this scenario and the PR passes.
Are you seeing this error in end to end test AFTER this PR was applied?


removed deprecated gulp-util

This tool's use of the recently deprecated gulp-util package is causing warnings to be thrown on install. For more info see https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
Thanks!

Not sure why the https test is failing here...


Fix / AccessControl Hook

Summary | Résumé
Optimizes the useAccessControl hook to use the existing session stored by next-auth in the <SessionProvider> context.  A force session update is available for circumstances where it is critical that the client be synced with the server.  This is more of a 'break glass in case of emergency' type function and should be used sparingly.
Fixes components that were calling the useAccessControl hook that were initializing refreshAbility on every component mount.
Adds more comments to the code to help ensure a better understanding of the function.
Test instructions | Instructions pour tester la modification

Should be completely invisible in terms of site changes.
Click around, submit some forms, and change user privileges.

Pull Request Checklist
Please complete the following items in the checklist before you request a review:

[x] Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
[ ] The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
[ ] If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
[x] Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
[x] Does your code have adequate comprehensible comments? Do new functions have docstrings?
[ ] Have you modified the change log and updated any relevant documentation?
[x] Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
[ ] If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

Seeing this error:

@timarney  you'll need to run yarn install to update your packages.  update is only available in the latest version of next-auth