feat: rewrite generation as a Homebrew command based on the API

This recreates the CI command as a Homebrew command that's based on the cask API that users also use. This means that it'll be slightly slower to update than it is now, but also more stable.
TODO:

[x] Let the command make commits
[x] Allow the command to cleanup files that no longer exist
[x] Add disabled/deprecated status

@MikeMcQuaid made the style check continue on error since the generated formulae don't all conform to the style check. Missing tests and unaligned array keys are the big factors there.
Otherwise it's ready to go for another review.

made the style check continue on error since the generated formulae don't all conform to the style check.

Remove the style check rather than wasting time running it and then ignoring the result.
Also, please open an issue for this to be fixed, we shouldn't be generating invalid formulae in an official tap.

Also, please open an issue for this to be fixed, we shouldn't be generating invalid formulae in an official tap.

Some can be corrected, some my code fixes, but some are simply because casks don't have as strict a ruleset as formula do.
I'll make an issue with a summary of the issues after this PR.

Style issue is created. If anyone has an idea how to write tests for these formula we can fix that part already.

If anyone has an idea how to write tests for these formula we can fix that part already.

I think either:

use rubocop:disable rules
make it in brew style or global RuboCop rules that they aren't required here
something like test do \n true \n end

2238 files inspected, 347 offenses detected, 6 offenses autocorrectable

after these last changes.

@MikeMcQuaid I can't merge here so if you're okay with it, go ahead!


Feature Request : Option to quickly share data

Is your feature request related to a problem? Please describe.
There is no way to copy/share data.
Describe the solution you'd like
There should be an option to quickly copy/share data.
Additional context
User secret data like login password, bank card pin,etc should not be copied.

will be implemented in view data screen as part of #98


Responsive layout for single story (story detail) page

Currently, it doesn't look fantastic on a desktop browser. Design is in Figma (thanks Curtis!):
https://www.figma.com/file/hwuWoqcVWWWrukev8pl9rn/My-Covid-Story?node-id=42%3A0

I'll do this one next.

Closed out by https://github.com/my-covid-story/www/pull/108


how to integrate qdrant vector store with langchainjs as retriever

https://python.langchain.com/en/latest/modules/indexes/vectorstores/examples/qdrant.html
it appears that its here in the python version but has not made it to js yet

Fixed with #1396.


 UI connector task
    #2 operator() /home/zaqwes/work/coordinator-tasks/projects/cc-desk/extern/actors_and_workers/actor_ui.cc:49 (exe+0x00000003e6f5)

    #3 std::function<void ()>::operator()() const /usr/include/c++/4.8/functional:2464 (exe+0x000000040106)

    // Thread creation - in constructor
    #4 operator() /home/zaqwes/work/coordinator-tasks/projects/cc-desk/extern/actors_and_workers/actor_ui.cc:56 (exe+0x000000040bcf)

    #5 std::this_thread::__sleep_for(std::chrono::duration<long, std::ratio<1l, 1l> >, std::chrono::duration<long, std::ratio<1l,<PHONE_NUMBER>l> >) ??:0 (libstdc++.so.6+0x0000000b1bef)

SUMMARY: ThreadSanitizer: thread leak ??:0 pthread_create
==================
ThreadSanitizer: reported 3 warnings

Only if UI was connected

Looks like false positive raise


Operator CRD is missing metadata for pod templates

My installation makes use of pod template annotations to enable things like monitoring, for example:
apiVersion: clickhouse.altinity.com/v1
kind: ClickHouseInstallation
metadata:
  name: test
  namespace: chop
spec:
  templates:
    podTemplates:
    - name: foo
      metadata:
        baz: qux

In practice the operator uses the metadata when creating the stateful sets and it works perfectly.
We recently changed our deployment to use Kubernetes Server-Side Apply which is validating against the CRD and now the installations fail.  It looks like it was mistakenly left out and this trivial change resolves it:
--- clickhouse-operator-install-crd.yaml.orig	2021-08-13 10:26:30.000000000 -0400
+++ clickhouse-operator-install-crd.yaml	2021-08-13 10:35:33.000000000 -0400
@@ -765,6 +765,9 @@
                               type: integer
                               minimum: 0
                               maximum: 65535
+                      metadata:
+                        type: object
+                        nullable: true
                       spec:
                         # TODO specify PodSpec
                         type: object
@@ -1600,6 +1603,9 @@
                               type: integer
                               minimum: 0
                               maximum: 65535
+                      metadata:
+                        type: object
+                        nullable: true
                       spec:
                         # TODO specify PodSpec
                         type: object

@Slach , please look

@ericisco which clickhouse-operator do you use?
@alex-zaitsev
I tried following manifest
apiVersion: clickhouse.altinity.com/v1
kind: ClickHouseInstallation
metadata:
  name: issue-756
  namespace: test
spec:
  defaults:
    templates:
       podTemplate: foo
  templates:
    podTemplates:
    - name: foo
      metadata:
        labels:
          baz: qux
      spec:
        containers:
          - name: clickhouse
            image: yandex/clickhouse-server:21.8

in 0.15.1 and 0.16.0
all works as expected
labels is present on created Pod

@ericisco is issue still relevant for you?
if yes, could you share your ClickHouseInstallation manifest?

Hi,
I was testing this using version 0.15.0.
Did you apply that manifest using SSA?
Transferring the metadata to the pods works as far as the operator is concerned, the issue is that when trying to apply the ClickHouseInstallation manifest via a Kubernetes Server-Side Apply it fails validation and won't apply at all because the CRD does not include the metadata field (see diff in original description).
The problem surfaced for me when attempting to use a Terraform kubernetes_manifest which requires SSA.  I would expect other (non-Terraform) SSA methods to have the same problem but, admittedly, I did not try any other approaches.
Hope that clarifies the issue...

One workaround for this is to set force-conflict to true.
--force-conflicts=false: If true, server-side apply will force the changes against conflicts
But in my humble opinion this is not safe to do as it defected to purpose of server side validation.

@ericisco , could you test it with new 0.16.1 version? We have fixed a few minor manifest issues.


Separate perfit metrics for back-compat merge queue and PR push

We're now running back-compat vs one version on PR push and three versions in the merge queue. We should add an additional perfit metric to track these runs separately, otherwise reusing the single metric will appear noisy.
@dpc if you have bandwidth to generate the perfit id I'll put up a PR to conditionally use the correct perfit metric.

@bradleystachurski 90S3yoXDQ-SXB0UbXG4qHQ


WEb SDK - mapping analytics data - broken link and not clear example

Hi team.
I am referencing the "Context data" section of the reported page.

The section features a snipped of JSON with a sample context data structure. Although it is not clear the relationship between such a JSON structure and the alloy methods. Should the context data JSON be included in the XDM argument of the alloy method? Should that be the first argument directly?
The "Product" link is broken:

Thank you for your support.
Alberto
Issue in ./help/edge/data-collection/adobe-analytics/manually-mapping-variables.md

This same issue was reported in GitHub Issue #84 - we are working to resolve.
Tracking internally: https://jira.corp.adobe.com/browse/PLAT-98615

The link has been updated and is now linking as expected: https://experienceleague.adobe.com/docs/experience-platform/edge/data-collection/adobe-analytics/manually-mapping-variables.html?lang=en
The "Context data" JSON is still under review and being tracked internally here: https://jira.corp.adobe.com/browse/PLAT-98615

Hi @alberto-decaro, thanks for calling this out. Regarding your first point this snippet is just there to show you what the context data will look like when its flattened. We just wanted to include this example as a reference and so you have an idea of what it will look like in your processing rule. This snippet doesn't need to be included anywhere. If you just map your data using XDM you should see it in processing rules.


Reorganize pom

This pr improves the structure of pom.xml by:

adjusting it to follow Maven conventions (build section at the bottom)
segregates Maven dependencies into 4 categories (to aid future work):

Core dependencies
Non-public Cloudera Hive & Impala connector dependencies
Public Cloudera Hive & Impala connector dependencies
Testing dependencies

extracts liquibase-core version to a parameter
fixes a typo in the artifact name: imapala -> impala
applies small fixes to .gitignore

:+1:  Could you please squash commits to one?

@eselyavka done


Update main.rs - add breakline

Just adding this commit in order to
create a dummy PR and test that a
github dispatch workflow works with the
sui operations repo.
Description
⚠ Not supposed to be merged

FYI @after-ephemera
Successfully triggered sui-operations build-binaries workflow on push and pull request creation:
https://github.com/MystenLabs/sui-operations/actions/runs/9250989737
https://github.com/MystenLabs/sui-operations/actions/runs/9250995593
They still failed though because there is an issue on the binary generations, but this is on the sui-operations part.
This workflow should be considered tested and working 👍

@after-ephemera if you agree that the above is correct, feel free to close this request.


Trying to add a class method with the same name as an already existing instance side method overwrites and moves the existing method

569, 573
If I have an instance method open

That I saved, and then start editing a new method, also called open. At the moment that I try to switch it from instance side to class side

the existing method gets overwritten with the current contents of the new method, and it gets moved to class side

Update: With the current system, the overwrite doesn't happen, but the coder gets out of sync and shows the class method both places.

It works now.


h3 config examples

Risk Level: n/a
Testing: examples config test, manual testing
Docs Changes: n/a
Release Notes: n/a
Part of #12923
Co-authored-by: Michael Payne<EMAIL_ADDRESS>

Hey Dan,
one weird thing, if I run bazel-bin/source/exe/envoy-static --config-path configs/envoyproxy_io_proxy_http3_downstream.template.yaml --concurrency 1
It works (/git/curl$ ./src/curl  -vv --http3 https://<IP_ADDRESS>:10000 gets results)
If I run bazel-bin/source/exe/envoy-static --config-path configs/envoyproxy_io_proxy_http3_downstream.template.yaml
I get consistent failures : https://pastebin.com/eU4DeqPd
Is this due to something wrong with my example config, or like @moderation posited is there something going wrong with QUIC with concurrency > 1 ?
Basically if you can't tell me what I did wrong I'll file a tracking issue and you can repro once this lands :-)

Actually I'm going to file a tracking issue either way - either we have a bug with concurrency or we have a bug with config validation (given it lets me run but doesn't work)

Cross reference - https://github.com/envoyproxy/envoy/issues/15845

Ah, I do have to fix config examples to not choke on H3 configs though.
/wait

Hey Dan,
one weird thing, if I run bazel-bin/source/exe/envoy-static --config-path configs/envoyproxy_io_proxy_http3_downstream.template.yaml --concurrency 1
It works (/git/curl$ ./src/curl  -vv --http3 https://<IP_ADDRESS>:10000 gets results)
If I run bazel-bin/source/exe/envoy-static --config-path configs/envoyproxy_io_proxy_http3_downstream.template.yaml
I get consistent failures : https://pastebin.com/eU4DeqPd
Is this due to something wrong with my example config, or like @moderation posited is there something going wrong with QUIC with concurrency > 1 ?
Basically if you can't tell me what I did wrong I'll file a tracking issue and you can repro once this lands :-)

It not obvious to me what's going wrong here. The config looks reasonable. I'll try it out locally.

@alyssawilk Is there an example h3 config for a quic listener that handles multiple certificates? Because quic listener does not support tls inspector filter so I'm not sure idiomatic way of routing multiple domains with one quic listener. For tcp listener, I would use tls inspector filter and filter chain matches on the sni to route requests to different http connection managers.

@alyssawilk Is there an example h3 config for a quic listener that handles multiple certificates? Because quic listener does not support tls inspector filter so I'm not sure idiomatic way of routing multiple domains with one quic listener. For tcp listener, I would use tls inspector filter and filter chain matches on the sni to route requests to different http connection managers.

You can config multiple filter chains with different cert chains in transport socket. And you can config how filter chains are matched on connection properties.

@danzh2010 It seems for QUIC that you cannot do filter chain match on server_name because TLS inspector listener filter is not supported for QUIC. So it seems only option is to use one HttpConnectionManager for all QUIC connections and put all cert chains in one transport socket for QUIC

@danzh2010 Ah so I tested with QUIC filter chain using server name and it seems that we don't need TLS inspector for server_name filter name match to work?


Use Node 16 for CI

With CI running on Node 16 and NPM 7, we will be able to use workspaces! I have a script to demo after this is in to publish compass-icons and compass-components as subpackages in the monorepo
Related Pull Requests
https://github.com/mattermost/mattermost-server/pull/17677
Release Note
NONE

@hmhealey, when I checkout this branch and do an npm install, I get a number of unexpected changes to package.json and package-lock.json, e.g.:
 {
-  "name": "mattermost-webapp",
-  "version": "0.0.1",
+  "name": "@mattermost/webapp",
+  "version": "5.36.0-0",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
-      "version": "0.0.1",
+      "name": "@mattermost/webapp",
+      "version": "5.36.0-0",
       "dependencies": {

I'm running:
> node --version
v16.2.0

Any thoughts?

Perhaps I checked in my package-lock off the wrong branch. I'll try recreating it.


refactor(planning_debug_tools): delete default values

Description
Removed default values defined in declare_parameter function.
planning_debug_tools_delete_param.webm

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3 Could you check this PR? Thanks in advance :pray:


AMBARI-25336 : Perf improvement with Collections usages over iterations

What changes were proposed in this pull request?
Perf improvement with bulk operations using Collections APIs over iterations
How was this patch tested?
The patch was tested with unit tests

retest this please

Please review @jonathan-hurley

Auto build trigger per PR is experiencing some issues?

Backport PR to branch-2.7: https://github.com/apache/ambari/pull/3049

ambari-server tests result:
[INFO] Results:
[INFO]
[WARNING] Tests run: 5320, Failures: 0, Errors: 0, Skipped: 72
[INFO]

@jonathan-hurley Thanks for your review. Could you please help me merge this(trunk) and backport(branch-2.7) #3049 PRs?
Ran test cases manually on local, everything looks good, also resolved checkstyle issue


Add bias metrics configuration modal

Closes #1274
Description

Added a modal that allows you to configure the bias metrics. However, this won't work until https://github.com/trustyai-explainability/trustyai-explainability/pull/186 is merged.

Added Duplicate and Delete for modal metric configuration rows

Added popover on the tab when there is no bias metric configured

How Has This Been Tested?

Go to model -> go to bias tab -> click configure button on the page title -> get into the configuration page -> try to create (not working for now) and delete the configuration
Test Impact

TBD
Request review criteria:

[x] The commits have meaningful messages (squashes happen on merge by the bot).
[x] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work
[ ] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

Testing is all good - I raised a question about the language on the error message on slack. Doing a code review now.

lgtm

/lgtm


Error when saving string with a % sign in

If there is a % in a string eg: 2% full 255% to go then the UnpSaveDocument.xsp errors with a javascript error and the doc cannot be saved.

Seems it occurs when the % sign is in the middle of a sentence. At the end seems ok

Tested by @RichSharpe


Creature Sheet name not saved in some cases

Changing the name of a creature does not reliably get saved

I have also found that since 0.9.2, the "Token Name" do not seem to be saved correctly.

Thanks, that'll be fixed next update.


Application Gateway with SKU tier Standard_v2 can only use PrivateIPAddress with IpAllocationMethod as Static

The az network application-gateway create from the Static IP address for container group - Azure Container Instances article fails with error:
Deployment failed. Correlation ID: 2bc188cd-84d4-4685-b91b-0239e48d6bad. {
  "error": {
    "code": "ApplicationGatewayFrontendIpPrivateIpAddressInvalidAllocationType",
    "message": "FrontendIpConfiguration /subscriptions/d41b0183-5d5e-42ed-8ef6-07d09b95fdff/resourceGroups/myResourceGroup/providers/Microsoft.Network/applicationGateways/myAppGateway/frontendIPConfigurations/appGatewayPrivateFrontendIP of Application Gateway with SKU tier Standard_v2 can only use PrivateIPAddress with IpAllocationMethod as Static.",
    "details": []
  }
}

See the complete commands and the complete output below.
Commands
This is my container-instances-application-gateway.ps1 sample which simply contains exact copy of the commands from the Static IP address for container group - Azure Container Instances article:
az group create --name myResourceGroup --location eastus

# Create virtual network
az network vnet create `
  --name myVNet `
  --resource-group myResourceGroup `
  --location eastus `
  --address-prefix <IP_ADDRESS>/16 `
  --subnet-name myAGSubnet `
  --subnet-prefix <IP_ADDRESS>/24

az network vnet subnet create `
  --name myACISubnet `
  --resource-group myResourceGroup `
  --vnet-name myVNet   `
  --address-prefix <IP_ADDRESS>/24

az network public-ip create `
  --resource-group myResourceGroup `
  --name myAGPublicIPAddress `
  --allocation-method Static `
  --sku Standard

# Create container group
az container create `
  --name appcontainer `
  --resource-group myResourceGroup `
  --image mcr.microsoft.com/azuredocs/aci-helloworld `
  --vnet myVNet `
  --subnet myACISubnet

az container show `
  --name appcontainer --resource-group myResourceGroup `
  --query ipAddress.ip --output tsv

$ACI_IP=$(az container show `
  --name appcontainer `
  --resource-group myResourceGroup `
  --query ipAddress.ip --output tsv)

# Create application gateway
az network application-gateway create `
  --name myAppGateway `
  --location eastus `
  --resource-group myResourceGroup `
  --capacity 2 `
  --sku Standard_v2 `
  --http-settings-protocol http `
  --public-ip-address myAGPublicIPAddress `
  --vnet-name myVNet `
  --subnet myAGSubnet `
  --servers "$ACI_IP"

# Test public IP address
az network public-ip show `
  --resource-group myresourcegroup `
  --name myAGPublicIPAddress `
  --query [ipAddress] `
  --output tsv

Output
PS1> .\container-instances-application-gateway.ps1
{
  "id": "/subscriptions/d41b0183-5d5e-42ed-8ef6-07d09b95fdff/resourceGroups/myResourceGroup",
  "location": "eastus",
  "managedBy": null,
  "name": "myResourceGroup",
  "properties": {
    "provisioningState": "Succeeded"
  },
  "tags": null,
  "type": "Microsoft.Resources/resourceGroups"
}
{
  "newVNet": {
    "addressSpace": {
      "addressPrefixes": [
        "<IP_ADDRESS>/16"
      ]
    },
    "bgpCommunities": null,
    "ddosProtectionPlan": null,
    "dhcpOptions": {
      "dnsServers": []
    },
    "enableDdosProtection": false,
    "enableVmProtection": false,
    "etag": "W/\"b3d88118-27c7-4f22-9e34-e88e307b781f\"",
    "id": "/subscriptions/d41b0183-5d5e-42ed-8ef6-07d09b95fdff/resourceGroups/myResourceGroup/providers/Microsoft.Network/virtualNetworks/myVNet",
    "ipAllocations": null,
    "location": "eastus",
    "name": "myVNet",
    "provisioningState": "Succeeded",
    "resourceGroup": "myResourceGroup",
    "resourceGuid": "27672307-b6b3-4016-9dda-f50b656329dd",
    "subnets": [
      {
        "addressPrefix": "<IP_ADDRESS>/24",
        "addressPrefixes": null,
        "delegations": [],
        "etag": "W/\"b3d88118-27c7-4f22-9e34-e88e307b781f\"",
        "id": "/subscriptions/d41b0183-5d5e-42ed-8ef6-07d09b95fdff/resourceGroups/myResourceGroup/providers/Microsoft.Network/virtualNetworks/myVNet/subnets/myAGSubnet",
        "ipAllocations": null,
        "ipConfigurationProfiles": null,
        "ipConfigurations": null,
        "name": "myAGSubnet",
        "natGateway": null,
        "networkSecurityGroup": null,
        "privateEndpointNetworkPolicies": "Enabled",
        "privateEndpoints": null,
        "privateLinkServiceNetworkPolicies": "Enabled",
        "provisioningState": "Succeeded",
        "purpose": null,
        "resourceGroup": "myResourceGroup",
        "resourceNavigationLinks": null,
        "routeTable": null,
        "serviceAssociationLinks": null,
        "serviceEndpointPolicies": null,
        "serviceEndpoints": null,
        "type": "Microsoft.Network/virtualNetworks/subnets"
      }
    ],
    "tags": {},
    "type": "Microsoft.Network/virtualNetworks",
    "virtualNetworkPeerings": []
  }
}
{
  "addressPrefix": "<IP_ADDRESS>/24",
  "addressPrefixes": null,
  "delegations": [],
  "etag": "W/\"6f976651-6a84-4001-a573-e97749f61f7c\"",
  "id": "/subscriptions/d41b0183-5d5e-42ed-8ef6-07d09b95fdff/resourceGroups/myResourceGroup/providers/Microsoft.Network/virtualNetworks/myVNet/subnets/myACISubnet",
  "ipAllocations": null,
  "ipConfigurationProfiles": null,
  "ipConfigurations": null,
  "name": "myACISubnet",
  "natGateway": null,
  "networkSecurityGroup": null,
  "privateEndpointNetworkPolicies": "Enabled",
  "privateEndpoints": null,
  "privateLinkServiceNetworkPolicies": "Enabled",
  "provisioningState": "Succeeded",
  "purpose": null,
  "resourceGroup": "myResourceGroup",
  "resourceNavigationLinks": null,
  "routeTable": null,
  "serviceAssociationLinks": null,
  "serviceEndpointPolicies": null,
  "serviceEndpoints": null,
  "type": "Microsoft.Network/virtualNetworks/subnets"
}
[Coming breaking change] In the coming release, the default behavior will be changed as follows when sku is Standard and zone is not provided: For zonal regions, you will get a zone-redundant IP indicated by zones:["1","2","3"]; For non-zonal regions, you will get a non zone-redundant IP indicated by zones:[].
{
  "publicIp": {
    "ddosSettings": null,
    "dnsSettings": null,
    "etag": "W/\"8b476e57-92e6-4e53-8c15-63c39b7ff72f\"",
    "id": "/subscriptions/d41b0183-5d5e-42ed-8ef6-07d09b95fdff/resourceGroups/myResourceGroup/providers/Microsoft.Network/publicIPAddresses/myAGPublicIPAddress",
    "idleTimeoutInMinutes": 4,
    "ipAddress": "<IP_ADDRESS>",
    "ipConfiguration": null,
    "ipTags": [],
    "location": "eastus",
    "name": "myAGPublicIPAddress",
    "provisioningState": "Succeeded",
    "publicIpAddressVersion": "IPv4",
    "publicIpAllocationMethod": "Static",
    "publicIpPrefix": null,
    "resourceGroup": "myResourceGroup",
    "resourceGuid": "5e4b9c98-65de-46b8-ba18-55853dda60dc",
    "sku": {
      "name": "Standard"
    },
    "tags": null,
    "type": "Microsoft.Network/publicIPAddresses",
    "zones": null
  }
}
{
  "containers": [
    {
      "command": null,
      "environmentVariables": [],
      "image": "mcr.microsoft.com/azuredocs/aci-helloworld",
      "instanceView": {
        "currentState": {
          "detailStatus": "",
          "exitCode": null,
          "finishTime": null,
          "startTime": "2020-10-22T16:36:21+00:00",
          "state": "Running"
        },
        "events": [
          {
            "count": 1,
            "firstTimestamp": "2020-10-22T16:36:17+00:00",
            "lastTimestamp": "2020-10-22T16:36:17+00:00",
            "message": "pulling image \"mcr.microsoft.com/azuredocs/aci-helloworld\"",
            "name": "Pulling",
            "type": "Normal"
          },
          {
            "count": 1,
            "firstTimestamp": "2020-10-22T16:36:20+00:00",
            "lastTimestamp": "2020-10-22T16:36:20+00:00",
            "message": "Successfully pulled image \"mcr.microsoft.com/azuredocs/aci-helloworld\"",
            "name": "Pulled",
            "type": "Normal"
          },
          {
            "count": 1,
            "firstTimestamp": "2020-10-22T16:36:21+00:00",
            "lastTimestamp": "2020-10-22T16:36:21+00:00",
            "message": "Created container",
            "name": "Created",
            "type": "Normal"
          },
          {
            "count": 1,
            "firstTimestamp": "2020-10-22T16:36:21+00:00",
            "lastTimestamp": "2020-10-22T16:36:21+00:00",
            "message": "Started container",
            "name": "Started",
            "type": "Normal"
          }
        ],
        "previousState": null,
        "restartCount": 0
      },
      "livenessProbe": null,
      "name": "appcontainer",
      "ports": [
        {
          "port": 80,
          "protocol": "TCP"
        }
      ],
      "readinessProbe": null,
      "resources": {
        "limits": null,
        "requests": {
          "cpu": 1.0,
          "gpu": null,
          "memoryInGb": 1.5
        }
      },
      "volumeMounts": null
    }
  ],
  "diagnostics": null,
  "dnsConfig": null,
  "id": "/subscriptions/d41b0183-5d5e-42ed-8ef6-07d09b95fdff/resourceGroups/myResourceGroup/providers/Microsoft.ContainerInstance/containerGroups/appcontainer",
  "identity": null,
  "imageRegistryCredentials": null,
  "instanceView": {
    "events": [
      {
        "count": 1,
        "firstTimestamp": "2020-10-22T16:35:10+00:00",
        "lastTimestamp": "2020-10-22T16:35:10+00:00",
        "message": "Prepare network succeeded.",
        "name": "PrepareNetwork",
        "type": "Normal"
      },
      {
        "count": 1,
        "firstTimestamp": "2020-10-22T16:35:46+00:00",
        "lastTimestamp": "2020-10-22T16:35:46+00:00",
        "message": "Join network succeeded.",
        "name": "JoinNetwork",
        "type": "Normal"
      },
      {
        "count": 1,
        "firstTimestamp": "2020-10-22T16:35:46+00:00",
        "lastTimestamp": "2020-10-22T16:35:46+00:00",
        "message": "Join network succeeded.",
        "name": "JoinNetwork",
        "type": "Normal"
      },
      {
        "count": 1,
        "firstTimestamp": "2020-10-22T16:35:46+00:00",
        "lastTimestamp": "2020-10-22T16:35:46+00:00",
        "message": "Delegate subnet succeeded.",
        "name": "DelegateSubnet",
        "type": "Normal"
      },
      {
        "count": 1,
        "firstTimestamp": "2020-10-22T16:35:47+00:00",
        "lastTimestamp": "2020-10-22T16:35:47+00:00",
        "message": "Provision network interface succeeded.",
        "name": "ProvisionNetworkInterface",
        "type": "Normal"
      }
    ],
    "state": "Running"
  },
  "ipAddress": {
    "dnsNameLabel": null,
    "fqdn": null,
    "ip": "<IP_ADDRESS>",
    "ports": [
      {
        "port": 80,
        "protocol": "TCP"
      }
    ],
    "type": "Private"
  },
  "location": "eastus",
  "name": "appcontainer",
  "networkProfile": {
    "id": "/subscriptions/d41b0183-5d5e-42ed-8ef6-07d09b95fdff/resourceGroups/myResourceGroup/providers/Microsoft.Network/networkProfiles/aci-network-profile-myVNet-myACISubnet",
    "resourceGroup": "myResourceGroup"
  },
  "osType": "Linux",
  "provisioningState": "Succeeded",
  "resourceGroup": "myResourceGroup",
  "restartPolicy": "Always",
  "tags": {},
  "type": "Microsoft.ContainerInstance/containerGroups",
  "volumes": null
}
<IP_ADDRESS>
Deployment failed. Correlation ID: 2bc188cd-84d4-4685-b91b-0239e48d6bad. {
  "error": {
    "code": "ApplicationGatewayFrontendIpPrivateIpAddressInvalidAllocationType",
    "message": "FrontendIpConfiguration /subscriptions/d41b0183-5d5e-42ed-8ef6-07d09b95fdff/resourceGroups/myResourceGroup/providers/Microsoft.Network/applicationGateways/myAppGateway/frontendIPConfigurations/appGatewayPrivateFrontendIP of Application Gateway with SKU tier Standard_v2 can only use PrivateIPAddress with IpAllocationMethod as Static.",
    "details": []
  }
}
<IP_ADDRESS>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d2bdf092-53a6-70a6-5d68-21a7450bb6d8
Version Independent ID: a64c4a6a-10c0-7163-9f2f-54e54b33274e
Content: Static IP address for container group - Azure Container Instances
Content Source: articles/container-instances/container-instances-application-gateway.md
Service: container-instances
GitHub Login: @macolso
Microsoft Alias: macolso

Thanks for the question! We are taking a look into this and will get back to you soon.

@mloskot Can you please check this and add your comments.

@VikasPullagura-MSFT Check what? There's been no comment with any suggestion, workaround or solution.

@mloskot Apologies for the confusion. My intent was to tag Product Team/Doc Author for checking and adding comments on your feedback.
I am adding new comment on the issue with correct contact.

@macols
Can you please check and add your comments on this Feedback.

Ran into the exact same issue going through the following page:
https://docs.microsoft.com/en-us/learn/modules/load-balance-web-traffic-with-application-gateway/5-exercise-create-configure-application-gateway
aliaksei@Azure:~$ az network application-gateway create \
> --resource-group $RG \
> --name vehicleAppGateway \
> --sku WAF_v2 \
> --capacity 2 \
> --vnet-name vehicleAppVnet \
> --subnet appGatewaySubnet \
> --public-ip-address appGatewayPublicIp \
> --http-settings-protocol Http \
> --http-settings-port 8080 \
> --frontend-port 8080
Deployment failed. Correlation ID: 5ab58a31-157b-4ffa-b746-3845b76babeb. {
  "error": {
    "code": "ApplicationGatewayFrontendIpPrivateIpAddressInvalidAllocationType",
    "message": "FrontendIpConfiguration /subscriptions/fca08cca-c191-4289-86ee-a7fd05759796/resourceGroups/TrainingRG/providers/Microsoft.Network/applicationGateways/vehicleAppGateway/frontendIPConfigurations/appGatewayPrivateFrontendIP of Application Gateway with SKU tier WAF_v2 can only use PrivateIPAddress with IpAllocationMethod as Static.",
    "details": []
  }
}

The release notes of the latest Azure CLI 2.15.0 at https://docs.microsoft.com/en-gb/cli/azure/release-notes-azure-cli#network say:

Fix bug that can't create a Standard_v2 application-gateway without a private static IP address

Is this related to this issue?

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. Though the scope of our feedback channel here on GitHub covers specific documentation fixes, we can help redirect you to the right support channel to get an answer to your question: [reference to alternative product/service or community endpoint]. Because this issue does not relate to documentation, we are closing this issue. #please-close


UserBook lost Connection

davinci UserBook always display "edp963.github.io 拒绝了我们的连接请求。",Please help!

You can access the markdown file in folder /docs/_docs/zh/ directly.

thank you


Any Chance to get a "sort" option?

When i "select all" on multiple files i get a random sorting in the output.
File03.txt
File01.txt
File02.txt
etc.
Is there any chance to get a hashcheck option to sort files?
File01.txt
File02.txt
File03.txt
The only chance to prevent this, is selecting all files manually in an inverted order.
Then the output is correct.
Thx and a happy new year. :)

That's a long-standing Windows bug. It's not exclusive to HashCheck. The last item selected ends up being in the first place, unless the program specifically re-sorts the list.
Your request is justified ;-)
Martin


add preprocess: split dataset by meta

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


AoT lambda error with skipCodeGeneration: true

Bug Report or Feature Request (mark with an x)

[x] bug report

Versions.
ng --version
@angular/cli: local (v1.0.0, branch: master) (e)
node: 7.7.3
os: linux x64
@angular/animations: 4.0.1
@angular/common: 4.0.1
@angular/compiler: 4.0.1
@angular/core: 4.0.1
@angular/forms: 4.0.1
@angular/http: 4.0.1
@angular/material: 2.0.0-beta.3
@angular/platform-browser: 4.0.1
@angular/platform-browser-dynamic: 4.0.1
@angular/router: 4.0.1
@angular/cli: 1.0.0
@angular/compiler-cli: 4.0.1

OS:
Ubuntu 17.04 zesty

Repro steps.
I'd like to use lambdas before Angular bootstraps. Under AoT (the default in angular-cli), this errors with the following, as currently expected:
ERROR in Error encountered resolving symbol values statically. Function calls are not supported. Consider replacing the function or lambda with a reference to an exported function

At this point, I'd also used ng eject, so as to enable support for Pug. At this point I looked for a way to disable AoT to work around the error, then found that ejection should disable AoT by default. Oddly enough, even with the default AotPlugin's "skipCodeGeneration": true, I'm still getting the above error on npm start.

@tycho01 can you post the code that is causing this error

Something to note as well is that a static analysis pass is performed regardless of the use of AOT to provide support for lazy loading.

@clydin Thanks, that's somewhat enlightening here. I knew the error comes from the StaticReflector class, though I haven't really found static analysis calls in that AotPlugin myself. At this point I'd wonder if there'd be any alternative to this. I never used lazy routing before myself. Might it be possible to sacrifice that functionality in order to skip the static pass and trade it in for lambdas again?
I'll try to make a minimum repro.

Minimum repro: this suffices to have it throw the error after ejecting (no AoT). Interestingly, on the minimum repro npm start does successfully appear to run the server despite this error getting thrown (this hadn't appeared the case in my further edited version, though there were no other errors there, so presumably this had been what blocked it there.).

Minimum repro: this suffices to have it throw the error after ejecting (no AoT).
Interestingly, on the minimum repro npm start does successfully appear to run the server despite this error getting thrown.
This hadn't appeared the case in my further edited version, though there were no other errors there, so presumably this had been what blocked it there.

There's no way to disable the static analysis that detect lazy routes, no. If you need a simpler setup that doesn't do that sort of stuff, I think you'd be better off with one of the TS-only webpack plugins instead. Should be a bit faster too.

Thanks @filipesilva. I tried angular2-template-loader mentioned here, which helps work around the issue.
I would consider the decision to sacrifice lambdas in favor of lazy routes an opinionated one, and would have appreciated if both were supported / acknowledged in the docs.
Then again, it does appear the Angular team intends to add lambda support in AoT (thread), so I suppose long-term this should be a moot concern anyway...


⚠ Bofrost.es has degraded performance

In fa4feb0, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1261 ms

Resolved: Bofrost.es performance has improved in ab592bb after 6 minutes.


ERROR after trying to flash EZSP

gateway ZNDMWG03LM
ERROR after trying to flash EZSP custom or original - no matter
Tried to do it on 1.5.5_0006, 1.5.6_0001.
xiaomi_gateway3-8b7e04a3f25a2b9a54e8fcc4c0c7cd1c-Xiaomi Multimode Gateway-39aa1397bf235ed29864ad26cbda8ed7 (1).json
home-assistant_xiaomi_gateway3_2024-02-18T15-40-24.782Z.log
Home Assistant Core 2024.2.2
Home Assistant Operating System 12.0.rc1

I don't see anything wrong with it. Try restart gateway and Hass and try again.
Also try to collect integration debug logs for this process.

home-assistant_xiaomi_gateway3_2024-02-19T01-50-35.611Z.log
original
home-assistant_xiaomi_gateway3_2024-02-19T01-53-08.906Z.log
custom

I think something changed in the ZHA integration. This library used for detecting firmware version.
Your original and custom firmwares flashed OK. But code for detecting fw version doesn't works

Sooo... Can I you fix it? Or we need to wait for HA developers?

Good luck man!

Luck doesn't have much to do with it. Just time. Free time

Probably fixed https://github.com/AlexxIT/XiaomiGateway3/releases/tag/v4.0.0

Yep, thanks!


Started adding logger standardization and exception handling

Bumped the version
Added new logger functionality to customize and control the logs based on the environment
Started adding exception handling to make the code robust. Tested with check_and_convert_date function.

@aseemanand if this is looking good, I will finish adding this to all the functions this weekend to close out the logging and exception handling standards.


[762] Update working pattern to allow for more than one

Trello card URL:
https://trello.com/c/4owuXmAO/762-update-working-pattern-options-so-there-is-more-flexibility-around-types-of-role-reflecting-the-needs-of-jobseekers-schools
Changes in this PR:

Add a working_patterns array column for array enums
Rake task to migrate all vacancies to use new enums
Update hiring staff UI to reflect new column and allow multiple selections
Update ElasticSearch mappings
Fixes to some specs

Screenshots of UI changes:
Before

After

Next steps:

[x] Terraform deployment required?

@pezholio I opened this PR in favour of the other one as the paradigm has changed. There's a similar amount of changes however there's far less complication.
I also added another spec for hiring staff publishing jobs with multiple working patterns.

 Update 'working pattern' options so there is more flexibility around types of role reflecting the needs of jobseekers/schools

I've added a commit that "humanizes" the working patterns in the right way and rebased.
I hate to leave a project with PRs unmerged but I hope I've left it in an ok state for the team.

After deploy and running the rake task, we need to remove the old working_pattern (singular) field.

Replaced by #920.


updated administartors list

As advised, I added myself and Alain to the list.

This was agreed at the Solid Team meeting

I came late at the meeting sorry I had a builder that came in.
Should Marrelle Bailey not be removed ? To be in line with github

@bourgeoa I asked the same in the meeting. Justin will check with Marrelle if she wants to stay as admin.
And gitHub teams actually contains her: https://github.com/orgs/solid/teams
If any action is needed there will be another PR.


Check that GitHub contributions are associated with a Carpentries GH organisation

Fixes #2470. Depends on #2492.
This just checks for "github.com/ORG" in the URL text, for all of our organisations as listed in the Carpentries Handbook: https://docs.carpentries.org/topic_folders/communications/tools/github_organisations.html.
In future we might look at storing a machine-readable list of organisations centrally and pulling the list from that, but for now @maneesha and I agreed to hardcode this list.
Screenshot:

Also snuck in a change to the wording of the community meeting involvement at the request of @karenword. This doesn't affect any tests


make sync period configurable per App CR

allow to configure sync period via spec.syncPeriod: <duration+unit>.

added in 11b01432f9fbf7b9a824495826e8132bd158e2cc

included in https://github.com/k14s/kapp-controller/releases/tag/v0.9.0


fix: allow relative fetch to endpoint outside app from within handle

fixes #9183
also consolidates usage of state.initiator across the server, only setting it in one place now where it's correct, prior to calling the internal fetch function. this means it now compares by url string, not matched route
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[x] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Ah, ok, I finally understand why this uses request.url — if it's happening in a handle hook there's no matched route.
We could try matching against the route and the pathname, but it still wouldn't handle a case where /a fetches /b and /b fetches /a. Might be simpler to just track the request 'depth', same as we track the length of redirect chains

Another idea would be to track the urls that are fetched and bail if we encounter a url we already saw. But that maybe also needs to account for headers and the body (who knows...), so yeah, it's probably better to just track the depth. 10 sounds sensible, it's the same as in the client


Searching for vuln reporting info outside of GH's security.md

For the Security Policy field, some projects that use GitHub do have a documented security policy, but are not using the GitHub Security Policy feature, so scraping just for GH's Security Policy via security.md would inaccurately show a false in this field.
I think this is most commonly seen with projects that were established before the Security Policy feature, or for projects mirror to GitHub.

...wrong repo. Closing and moved to https://github.com/ossf/scorecard/issues/39


KAFKA-8953: Rename UsePreviousTimeOnInvalidTimestamp to UsePartitionTimeOnInvalidTimestamp

Added deprecate annotation in UsePreviousTimeOnInvalidTimestamp and created a new class UsePartitionTimeOnInvalidTimestamp. Also replaced usage of UsePreviousTimeOnInvalidTimestam with new class name, don't know if this was necessary but can be reverted back if necessary
Also renamed the test class of UsePreviousTimeOnInvalidTimestamp with new class name
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Retest this, please.

Hi @mjsax please do review the changes and do let me know if there are any additional changes required.

Hi @mjsax thank you for the review. I have made changes as per your suggestions. Please do let me know if further changes are necessary.

Retest this, please.

Retest this, please.

Retest this, please.

Hi @mjsax I have addressed your comments and made the changes. Build is also passing now. Please let me know if additional changes are needed.

Thanks for the KIP and the PR @ravowlga123! Merged to trunk.


[ctk] Add new port

Describe the pull request

What does your PR fix?
Draft PR for adding CTK to vcpkg. This package has quite a few quirks, and I could use the eyes of someone more experienced with vcpkg to help resolve some of these. More details to follow in next comment.

Which triplets are supported/not supported? Have you updated the CI baseline?
Windows and Linux should be supported - still working on the port.

Does your PR follow the maintainer guide?

I am still working on this PR

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

The x64-windows build succeeded. But this is a problem:
CMake Warning at ports/qt5-base/portfile.cmake:27 (message):
  qt5-base is currently not setup to support feature 'mysqlplugin' on
  platforms other than windows.  Feel free to open up a PR to fix it!

I wonder if there is really a hard dependency on the mysqlplugin, or if it is just using independent Qt SQL API. If there is no hard dependency, the port shouldn't request mysqlplugin - it is up to the user to install the desired Qt features.

Sorry about that! Didn't realize that qt5-base contained Qt::Sql. Just pushed that change.

This builds fine, but unfortunately it seems like vcpkg_cmake_config_fixup isn't doing a thorough job/is breaking things. If I make a dummy project with the following (main.cpp is just a standard helloworld):
cmake_minimum_required(VERSION 2.8.6)
project(Example1)
find_package(CTK REQUIRED)
include(${CTK_USE_FILE})
add_executable(example1 main.cpp)
target_link_libraries(example1 ${CTK_LIBRARIES})

I get an error with the find_package() call:
CMake Error at C:/vcpkg/installed/x64-windows/share/ctk/CTKConfig.cmake:19 (message):
  File or directory  C:/vcpkg/installed/x64-windows/lib/ctk-0.1/CMake/UseCTK.cmake
  referenced by variable CTK_USE_FILE does not exist !

it seems like vcpkg_cmake_config_fixup isn't doing a thorough job/is breaking things.

Well, CMake config can be almost everything. vcpkg_cmake_config_fixup is for the standard config generated by CMake - which doesn't have any "use" files or similar. You may need to add additonal fixup commands. (In the worst case, it cannot be used at all.)

Pinging @raahilsha-z  for response. Is work still being done for this PR?

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.


Appstudio update test-component-pac-gfjn

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-gfjn-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
18 seconds
clone-repository

✅ Succeeded
31 seconds
build-container

✅ Succeeded
13 seconds
inspect-image

✅ Succeeded
2 minutes
deprecated-base-image-check

✅ Succeeded
39 seconds
clamav-scan

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
10 seconds
sbom-json-check

✅ Succeeded
13 seconds
optional-label-check

✅ Succeeded
13 seconds
label-check

✅ Succeeded
5 seconds
show-sbom

✅ Succeeded
8 seconds
show-summary


feat: load multiple ivf-pq sorted files and commit index into dataset

Follow up of PRs #2566, #2657 and #2670
The whole pipeline can help users transform, shuffle, and load IVF-PQ indices in separate, standalone steps (can be useful when building indices for large datasets)
First, the user runs transform_vectors() separately on selected fragments
Then, they run shuffle_transformed_vectors() on each transformed result
Finally, they load all the shuffled vectors and commit the index into the dataset using load_shuffled_vectors()

Codecov Report
Attention: Patch coverage is 39.31624% with 71 lines in your changes missing coverage. Please review.

Project coverage is 79.41%. Comparing base (9c292ac) to head (2fb896a).
Report is 4 commits behind head on main.

Files
Patch %
Lines

rust/lance/src/index.rs
12.19%
36 Missing :warning:

rust/lance/src/index/vector/ivf.rs
0.00%
21 Missing :warning:

rust/lance-index/src/vector/ivf/shuffler.rs
73.07%
11 Missing and 3 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2681      +/-   ##
==========================================
- Coverage   79.43%   79.41%   -0.02%
==========================================
  Files         227      227
  Lines       66894    66997     +103
  Branches    66894    66997     +103
==========================================
+ Hits        53136    53205      +69
- Misses      10628    10681      +53
+ Partials     3130     3111      -19

Flag
Coverage Δ

unittests
79.41% <39.31%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Same Job submitted twice

@dos65
Hi,
When I send an API request to mist server from Mist UI, it submits the same job twice (with same ID) to the spark cluster. I can see this from the spark cluster UI. Although the result is returned from the first job execution result.
Below is the screenshot attached:

Please check this..!!
Thanks

Thanks for reporting!
Fixed in #203


get rid of running 'containerd config default' with sudo

'containerd config default' doesn't require root privileges, so it doesn't make sense to run it with sudo

/assign @sig-docs-en-owners

/assign @sig-docs-en-owners

/cc @sig-docs-en-reviews @sig-docs-ko-reviews @sig-docs-zh-reviews

/cc @sig-docs-en-reviews @sig-docs-ko-reviews @sig-docs-zh-reviews

@bart0sh Thank you for the contribution !
I am one of sig-docs-ko-owners. The fix for Korean document looks good to me. But I'd like to give lgtm to this PR after English(upstream) reviewer complete a review for English doc.

@bart0sh Thank you for the contribution !
I am one of sig-docs-ko-owners. The fix for Korean document looks good to me. But I'd like to give lgtm to this PR after English(upstream) reviewer complete a review for English doc.

@seokho-son I happen to be the upstream reviewer :) However, I'm not sure I can lgtm my own PRs. Will try.

@seokho-son I happen to be the upstream reviewer :) However, I'm not sure I can lgtm my own PRs. Will try.

/lgtm

/lgtm

it didn't work out

it didn't work out

Hi @bart0sh thank you for your contribution.  A single PR should update content across multiple languages.  Can you split this PR into multiple PRs where you separate content for each language?  Thanks!
/assign

Hi @bart0sh thank you for your contribution.  A single PR should update content across multiple languages.  Can you split this PR into multiple PRs where you separate content for each language?  Thanks!
/assign

@bradtopol Thank you for the review. I've updated the PR as you've suggested, please review again.

@bradtopol Thank you for the review. I've updated the PR as you've suggested, please review again.

/cc @kubernetes/sig-docs-en-owners

/cc @kubernetes/sig-docs-en-owners

/approve

/approve


overload method can't be inherited completely

Input code

// src/Circle.js
import Geometry from './Geometry'
/**
 * @class
 * @extends Geometry
 */
class Circle extends Geometry {

}

// src/Geometry.js
/**
 * @typedef Position
 * @property {number} x
 * @property {number} y
 */

/**
 * @class
 */
class Geometry {
  /**
   * @param {Geometry} geo
   * @return {number}
   *//**
   * @param {Position} postion
   * @return {number}
   */
  calcDistence(geo) {
    return 100
  }
}

export default Geometry

JSDoc configuration

{
  "plugins": [],
  "opts": {
    "encoding": "utf8",
    "destination": "./out",
    "recurse": true
  },
  "source": {
    "include": [
      "src"
    ]
  },
  "recurseDepth": 10,
  "sourceType": "module",
  "tags": {
    "allowUnknownTags": true,
    "dictionaries": ["jsdoc","closure"]
  }
}

JSDoc debug output

DEBUG: JSDoc 3.6.3 (Sun, 14 Jul 2019 17:01:26 GMT)
DEBUG: Environment info: {"env":{"conf":{"plugins":[],"recurseDepth":10,"source":{"includePattern":".+\\.js(doc|x)?$","excludePattern":"","include":["src"]},"sourceType":"module","tags":{"allowUnknownTags":true,"dictionaries":["jsdoc","closure"]},"templates":{"monospaceLinks":false,"cleverLinks":false},"opts":{"encoding":"utf8","destination":"./out","recurse":true}},"opts":{"_":[],"configure":"config.json","debug":true,"encoding":"utf8","destination":"./out","recurse":true}}}
DEBUG: Parsing source files: ["/Users/zero/projects/jsdoc-test/src/Circle.js","/Users/zero/projects/jsdoc-test/src/Geometry.js"]
Parsing /Users/zero/projects/jsdoc-test/src/Circle.js ...
Parsing /Users/zero/projects/jsdoc-test/src/Geometry.js ...
DEBUG: Finished parsing source files.
DEBUG: Adding inherited symbols, mixins, and interface implementations...
DEBUG: Adding borrowed doclets...
DEBUG: Post-processing complete.
Generating output files...
Finished running in 0.62 seconds.

Expected behavior

Class Circle should have a method calcDistence(geo: Geometry) and and an overload method calcDistence(geo: Position).But it only has one.
Current behavior

Class<Geometry>

Class<Circle>

Your environment

Software
Version

JSDoc
v3.6.3

Node.js
v8.16.1

npm
v6.4.1

Operating system
macOS v10.14.6

I resolve this problem by using "plugins/overloadHelper"


FIX: Reader not parsing Symbol correctly

Added breaking test case: a2 results in a symbol with name a.

Also known as: Regexes are hard 😆


[med] Color: Many Pages: Only color is used to distinguish links on the page

Action Performed:

Using Chrome, open https://staging.new.expensify.com/
Tab to focus the "privacy policy", "terms of service" or "licenses" links.
Notice if the links have any other visual cues besides color to be distinguished from surrounding text.

Expected Result:
Color should not be the only way to differentiate the link from the surrounding text. There should be additional cues, such as a border, bold or italic text, along with the color differentiation. A contrast ratio of 3.00:1 should be provided between the link text and adjacent text to meet the requirement.
Actual Result:
Only color is used to distinguish links from normal text. The blue links (#0185FF) against dark grey surrounding text (#7D8B8F) have a color contrast ratio of 1.02:1.
HTML:
terms of service...privacy policy...licenses
Other occurrences:

Terms of service -> Only color is used to distinguish links from surrounding text.
Privacy policy -> Only color is used to distinguish links from surrounding text.
Licenses -> Only color is used to distinguish links from surrounding text.
About -> Only color is used to distinguish "Terms of service" and "Privacy policy" links from surrounding text.
Set password -> Only color is used to distinguish links from surrounding text.

Workaround:
No workaround
Area issue was found in:
Landing page, Terms of service page, Privacy policy page, Licenses page, About overlay, Set password page
Failed WCAG checkpoints
1.4.1
User impact:
The low-vision and color-blind users might not be able to distinguish the links from surrounding text.
Suggested resolution:
Provide some additional decoration for the link (e.g. bold or larger font or a permanent underline), so that link can be easily differentiated from surrounding text. The 3.00:1 color contrast ratio between the link text and adjacent text can be achieved by using the darker blue color for the link text. An example of color to use is #003D75, which will give a color contrast ratio of 3.09:1 against the current color of surrounding text (#7D8B8F).
https://www.w3.org/WAI/WCAG21/Understanding/use-of-color.html
https://www.w3.org/WAI/WCAG21/Techniques/general/G183
Platform:
Where is this issue occurring?

Web

Version Number:
**Reproducible in staging?:**Yes

Reproducible in production?:
Notes/Photos/Videos: Any additional supporting documentation
Issue reported by:
View all open jobs on GitHub

So the terms of service page is hosted on UseDot and it's technically not part of the NewDot app. @stitesExpensify @kadiealexander do you still think it's worth addressing these issues, or should we punt and focus on the app itself?


Adds OkHttp integration

Adds OkHttp integration. Allows multiple headers with the same name. Backfills default client tests.
closes #134

NetflixOSS » feign » feign-pull-requests #19 SUCCESS
This pull request looks good

NetflixOSS » feign » feign-pull-requests #20 SUCCESS
This pull request looks good

Thanks! this helps a lot!


Istio outbound connection not working properly on EKS IPV6-only clusters

Checks

[X] I have searched the existing issues.
[X] This issue is NOT security related. (Please disclose responsibly)
[X] This issue is NOT specific to the CLI. (Please open a CLI issue)

deployKF Version
0.1.5
Kubernetes Distribution
EKS
Kubernetes Version
Client Version: v1.28.2
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.29.4-eks-036c24b

Description
While trying to deploy deployKF to an EKS IPv6-only cluster, the Dex container fails to start when attempting to make an outbound connection (specifically to fetch the Google Auth OIDC configuration at https://accounts.google.com/.well-known/openid-configuration):
Relevant Logs
failed to initialize server: server: Failed to open connector google-auth: failed to open connector: failed to create connector google-auth: failed to get provider: Get "https://accounts.google.com/.well-known/openid-configuration": read tcp [<Pod IPv6>]:44268->[2607:f8b0:400e:c0c::54]:443: read: connection reset by peer

### deployKF Values (Optional)

```yaml
deploykf_auth:
  dex:
    connectors:
      - type: google
        id: google-auth
        name: SSO
        config:
          clientID: <id>.apps.googleusercontent.com
          clientSecret: <secret>
          redirectURI: https://kubeflow.example.com/dex/callback

@jdraymon just to confirm, was this the only failure?
E.g. did deployKF work properly until you tried to configure the Google auth connector, or were there other issues as well?
PS: I can see at least a few Istio configs which might need to be set for IPv6-only clusters (along with upgrading the Istio version to 1.20+, rather than using the default 1.17 that comes with deployKF).
The main one is ISTIO_ENABLE_IPV4_OUTBOUND_LISTENER_FOR_IPV6_CLUSTERS added in Istio 1.19.4.


Allow more history to be stored?

I tried out other copy-paste apps, like Copy clip 2(only trial). They seemed to support unlimited history by storing it in sql files, and also used less memory. I'm not sure if that kind of approach will be possible but I would love to have more items stored in history.

Duplicate of #310


Settings, Custom Bypass don't save

Body
I'm using the Mullvad Browser. Basically a mix of Firefox and TOR if I understand correctly.
The issue seems to be persistent and isn't solved by different methods of installation, etc.
The crowd bypass button doesn't want to check, as the check simply disappears after a refresh.
Same goes for anything in the Custom Bypass Field, and the second delays for the default options.
Version
0.2237
What browsers are you seeing the problem on?
Other
What OS are you seeing the problem on?
Windows
Anything else?
The fields that I have talked about:
Take me to destinations after second(s).
Crowd Bypass
Open crowd-sourced destinations in a new tab after second(s).
Close tab containing the crowd-sourced destination after second(s) of visiting it.
Custom Bypasses

We don't support custom bypasses anymore since the MV3 version is out.


Fix linting

This PR fixes linting and switches to use the typescript rules for no-unused-vars.
Example of code that won't pass without switching to ts no-unused-vars.
import {Field, Record, Table} from "@airtable/blocks/models";

function Task(props: { table: Table, record: Record, doneField: Field }) {
    return (

           . . .

    )
}

Hi! Thank you for taking the time to open this PR. This is the first PR contributed by the community to any of our open source blocks!
Right now our tooling and release process makes it difficult to merge in PRs from the community. I attempted to merge this in, but it ended up squashing your commit when I released a new version: https://github.com/Airtable/blocks-hello-world-typescript/commit/631bf34b6e800d49aa446345f4eaebdfd7747d38
So this fix is now released on master, but unfortunately it didn't properly attribute you in the commits. I apologize for that, we're looking into fixing this for future PRs.


add to NPM

cant hurt - simple, focused modules such as this are often highly depended on

I was going to do it, then I noticed "anchor-scroll" is already used by another lib (and I'd hate publishing it on npm on a different name). Closing for now, unless many people request it.


Consolidate and rationalize SQL execution

Do these need to be shared between Update and Migrations?
Should ExecuteCommand use them?

Notes from #2758:

Cleanup in Query DefaultQuerySqlGenerator, renames based on new RelationalCommandBuilder
Look at removing RelationalSqlExecutor and moving IRelationalConnection into SqlStatementExecutor constructor dependencies
Use DI for ParameterNameGeneratorFactory in Query

completed and passed through API review


Trigger changeQuery event when user inputs something into the search field

Description
This closes #944 by triggering a changeQuery event as soon as the user inputs something into the search field.
Types of changes

[ ] Chore (tooling change or documentation change)
[ ] Refactor (non-breaking change which maintains existing functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

This looks like a great addition, but right now it won't function as intended. A changeQuery event will be fired every time a key is pressed, even if it doesn't actually change the query (i.e. arrow keys, delete/backspace keys when the query box is empty, etc.). I think you want to hook into the input event instead. We aren't doing that already, so you'll need to add an _onInput method to Choices.
Please also rebase on the latest version of the master branch.


Can't change chat colors with plugins loaded

SetSenderColor sets the color for the current gwca instance, the next GetSenderColor calls the original function, which the plugin has hooked and replaces with its own ChatSenderColor[chan], which is still the old color

This is a problem caused by a third party dll hooking into the same gw functions, not with toolbox. Fix it at the plugin level.

The only way to fix it is to unhook GetSenderColor in the plugins, or to send a UI message that lets plugins change their ChatSenderColors when toolbox changes theirs. Agree that it's not a toolbox bug, but a gwca one.


Marks merge commits in commit lists not working

Since the GitHub redesign, the Marks merge commits in commit lists is not working anymore. 😭

Will be fixed #3269


More Questions - RAMP, PyRossGeo, Contact Tracing and FlameGPU.

Q3. Its been nearly 4 weeks since my Q1 and Q2 in:
https://github.com/FLAMEGPU/FLAMEGPU2_dev/issues/307
Could somebody please confirm when or whether there will be a response or a request for clarification?
BTW SYCL 2020 v1 provisional is now out.
Q4 Are the python bindings and jupyter example for OCCA of any relevance?
https://github.com/libocca/occa.py
https://notebooks.gesis.org/binder/jupyter/user/libocca-occa.py-oq3qbhzd/notebooks/notebooks/Tutorial.ipynb
https://libocca.org/#/history
Q5 publications list here includes some missing from public site:
https://flamegpu.github.io/publications/

Could this be updated to include last few years and made easily accessible? (Does not include some very useful papers from 2017-18 and hopefully others even later).

Some links from main publicly available list are broken and should be fixed:
http://www.flamegpu.com/publications

Q6. If I am pointed to a markdown version of publications list to update I could add a few items I have come across though I imagine it would be better to generate direct from a bib file that somebody should have.
Q7. Could somebody please checkout the potential relevance of FLAME GPU to PyRossGeo?
https://github.com/lukastk/PyRossGeo#documentation
See also the (java!) Scottish Covid Response contact tracing model mentioned by RAMP and consider relevance of ABMs on  GPUs to Individual based contact tracing of clusters and outbreaks integrated with microsiulation based PyRossGeo:
https://github.com/ScottishCovidResponse/Contact-Tracing-Model/blob/develop/docs/Build Documentation.docx
The PyRoss and PyRossGeo docs are a lot easier to understand than the original Imperial College model and it is well known how compartmentalized SBML style chemical reaction models can be translated to more granular ABMs with actual behavioural variation for better insight into emergent phenomana arising from the heteogeneities in compartments that are NOT well mixed than can be obtained from tau leaping with the Gillespie algorithm.

I gather there has been no RAMP response to expression of interest from FLAME GPU?

https://epcced.github.io/ramp/

Item 10 h) of their previous updates (linked from above) makes it clear there are lots of offers from software developers to help projects but not enough actual epidemiological modelers to cope. The inevitable focus on immediate firefighting  means nobody is looking at likely needs for future software platform development that could only be useful later (but which will be needed before a vaccine is available).

After reviewing a fair bit of the necessary reading including the recommended seminars at Isaac Newton Institute I am convinced the point I made in my first contact here in March has been fully confirmed:

https://github.com/FLAMEGPU/FLAMEGPU2_dev/issues/222

ie they will need more granular models for which FLAME GPU is likely to be highly relevant, especially in connection with contact tracing and localised restrictions (eg Leicester). They have explicitly confirmed my claim that the Imperial College model would need to be replicated and identified PyRoss as the project most relevant to that. The existing modeling teams will be preoccupied with their existing models and obtaining actual data rather than considering how to integrate the various models. Some aspects like hospital logistics, aerosol dynamics and disease progression are orthogonal to each other and can just supply input parameters to transmission and contact tracing or take outputs from them. But transmission and contact tracing models need to be closely integrated for real-time quarantine and social distancing decisions and that clearly points towards ABMs on GPUs. Its a lot more difficult than half a million cars on a road network but looks to me just as clearly well suited to FLAME GPU.

PyRoss Geo is where the difficulty of achieving the necessary granularity without GPUs and the potential relevance of FLAME GPU should become obvious.

Hi @dentarthur I have responded to and closed #317. In response to your other questions;
Q3: We are every busy with development and have a current development road map which we are following. We are not anticipating changing the underlying languages or approach and will not consider doing so until we reach a stable release. It would only delay development.
Q4: I am personally working on pyflamegpu. It is under development in the swig branch but not ready for release at this stage. It is preferred to wrap our library rather than develop from scratch in python to target GPUs using the approaches you suggest.
Q5: The website is out of date. We have a prototype new site which we will deploy with the first release of FLAME GPU 2. New papers will be published on the architecture when we are ready.
Q6: Our new site will be github driven so you will be able to issue a pull request to add publications. For now you could add an issue to https://github.com/FLAMEGPU/flamegpu.github.io/issues which is an old port of our current site which will be used as a starting point for the new one.
Q7: I am aware of RAMP and the Scottish covid response. We need to focus on core development of FLAME GPU 2 for this tool to be useful in epidemiology. Once we reach a release state we plan on releasing epidemiology examples as a starting point to engage in useful discussion with epidemiology modellers.

Thanks for clear response.


Broken links on page

In the "Roles and tasks at-a-glance" section, the links for intranet lifecycle and building blocks are broken.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aade0ae3-162e-c946-bb76-58d8aab252af
Version Independent ID: f22dc636-f039-8be8-e524-ce146739a1d7
Content: Intelligent intranet roles and tasks - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/intranet-roles-tasks.md
Service: sharepoint-online
GitHub Login: @MattEEvans
Microsoft Alias: matteva

Hello @Curtica thanks for your feedback!, fixing.


fix missing requests dependency

added requests module to requirements.txt

What is the purpose of this pull request?: add missing requests module
What issue does this pull request address?: Fixes #57
Notes for reviewers to consider:
Specific reviewers for pull request:
@gardlt @theyer

@drewwalters96 good catch. LGTM


Add Course Level Filtering, Restyle Advanced Search

Summary

Add Course Level filtering functionality. It's housed in the Advanced Search Options because it doesn't change the URL.
I've also taken the liberty of moving the Online Classes label to top instead of the default (right), which fits more cleanly.

It's pretty blurry in this GIF, but upon selecting Upper Division Only, returned results are only those between 100 and 199 :D

Advanced Search Styling Changes:
Before:

After:

I'm a really big fan of the new look with it's left-sided alignment and consistent gap. My main gripe is that MUI doesn't support row-only gap, so the gaps vertically can be a tad much. You can see it happening in the after image to the Room element, which looks a little orphaned. Worthy tradeoff in my opinion
Test Plan

Make sure it works

Issues
Closes #627, the successful sibling to #628

I haven't looked at the code yet, but I have some suggestions for the UI.
Some renaming for concision and taking up less space, especially on a mobile screen:

"Course Level" -> "Level"
"Any Course Division" -> "Any"
"Lower Division Only" -> "Lower Division"
"Upper Division Only" -> "Upper Division"
These shouldn't affect the comprehensibility of the feature because the removed words can be easily implied from context

The advanced search menu now looks pretty disorganized. It's especially hard to parse on mobile. I'd say that they should be more vertically organized or at least grouped more intentionally. You'll notice that it is the latter in the current version on mobile, especially.
The filter doesn't apply to the fuzzy search. I realized that this is consistent with the other fields, so this should be changed (or declared a feature) in a separate PR.

I agree with you about the concision, but I do want to push back on Course Level -> Level and Any Course Division -> Any.

I think Course Level -> Level sacrifices too much readability for being concise. Compared to its next-door neighbors like Online Classes Only and Class Full Option, I think it's probably the least offensive of the three.

Side note, but Online Classes Only could probably be renamed to Online Only... It's also somewhat out of place as a switch element amongst a few of Selects, but I don't have any ideas currently about making it feel more cohesive.

This is more of a nitpick, but Any is just so much shorter than its counterparts and just makes it feel... unbalanced? This is probably a little over-subjective, but I think it's worth bringing up.

In the meanwhile, I'll fiddle around with some divs and see if we can clean this up :)

I'm pretty happy with how it's been cleaned up by getting rid of space-around in favor of a left-side oriented wrapping using gap. LMK how it looks :D @MinhxNguyen7


Add support for custom logo

Purpose
Add support in Privacy Center for for using a custom logo based on the logo_path specified in the config.json file.
Changes

Pulls the logo image path from the config.json file in index.tsx.
Adds a test to verify the correct image url is used.

Checklist

[ ] Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram)
[x] Good unit test/integration test coverage
[ ] This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
[ ] The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket
Fixes #346

Sorry, didn't see this one got assigned to someone until after I opened the PR. Feel free to close this one in favor of another if something was already in the works.

Thanks @sanders41 for the contribution!


[Student View] Fix bug where scrollbar doesn't follow down keys on Autosuggest

@walrys suggested to use scrollTop() and manually code in the logic ourselves. Let's see if this works :)

May be able to use Adrian's react-dropdown component instead

FIXED by commit 2eb31c6
Replaced AutoSuggest with VirtualizedReact to handle large datasets (>7000 modules) asynchronously from server


Fix celebration date of saintPedroCalungsodMartyr in philippines.ts

According to the Wiki, saintPedroCalungsodMartyr is celebrated on 2 April. If, however, it falls on Sunday of Lent or within Holy Week, it should be moved to the preceding Saturday.

I tried to acomplish this. I have borrowed the code from england.ts (for allSaints) and looked at the documentation of dayjs. @emagnier, could you check if this is correct? Thanks.
The only thing I am not sure is if season will contain the season of that particular date. I don’t think so, but I could not come up with better way.
    {
      key: 'saintPedroCalungsodMartyr',
      type: TypesEnum.MEMORIAL,
      date: ((y: number): dayjs.Dayjs => {
        const date = dayjs.utc(`${y}-4-2`);
        if (date.day() === 0) && (season == lent) {
          return dayjs.utc(`${y}-4-1`);
        } else if (season == holyWeek) {
          const daysNum = date.day() + 1;
          return date.substract(daysNum, 'day');
        } else {
          return date;
        }
      })(year),
      data: {
        meta: {
          liturgicalColor: LITURGICAL_COLORS.RED,
          titles: [TITLES.MARTYR],
        },
      },
    },


It'll be more convenient to enable share directory while browsing files.

After FLEX 3.0, it's great that share single file is enabled while under FLEXFileBrowser.
For our case, it would be more convenient if it's able to share a directory.

For share directory, it's needed to use UIDocumentInteractionController instead of UIActivityViewController.

Unrelated to the PR: you should always try to submit a single or a few clean commits when making a PR.  Looks a lot cleaner, right? Rebase is pretty powerful!

Anyway, I don't think we want to always present the document browser thing. We just want that for directories, right? Could you update your code to conditionally use the document thing instead of the share sheet, based on whether or not the item is a directory?

Thanks for your review.
for the files, when we use activityviewcontroller, while the file is raw(without extension, or can’t be recognized), the airdrop action will send the full path instead of the content of file. And use documentinteraction will cover those condtions.

Ahhh, I see. I think instead we need a specific activity which would present the document thingy. That's what I've seen other apps do. I personally still want access to the standard share sheet most of the time, but I agree we need both.
What do you think? I'm open to other ideas.
—
Tanner Bennett
On Jun 13, 2019, 10:52 AM -0500, Euan Chan<EMAIL_ADDRESS>wrote:

Thanks for your review.
for the files, when we use activityviewcontroller, while the file is raw(without extension, or can’t be recognized), the airdrop action will send the full path instead of the content of file. And use documentinteraction will cover those condtions.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Cause it’s late night here, I think I need to try a demo with more detail tomorrow, I’ll give more information after that.

I have fixed it so that the share sheet shares the actual file and not the file path. Gonna close this. Thanks for your contribution!
I will also be adding a way to long press to copy the file path in a future commit, as well as some images in the app's folder for anyone to test the share sheet with. Since they're in the app's folder, I'm thinking about adding a "Browse app bundle" option to the main menu so you can actually get there. For now, I'm going to add a way to browse a bundle's files, so you can just go to the Main Bundle and tap Explore bundle directory


allow to update delegate every time attachViewDelegate called.

this PR is related to this issue https://github.com/meedan/react-native-share-menu/issues/135.

I tested this and it seems to work!

Me too. Please merge. However I would prefer to delete the line instead of commenting it out.

It is working!

Please merge this PR

Maybe if it can help someone. Here are some details...
The lib is composed of

A derivation of UIViewController, an apple primitive to present things. This is an instance.
A single static object to expose functions to react/java (which point to a single ViewController)

The lib takes one of the following wrong assumption:

Only 1 UIViewController exist at a given moment (not clear given the complexity of view system)
The system will always call viewDidDisappear (most likely the bug when switching app)

The ok-but-not-great fix is to comment or remove the guard as proposed. It clean the left over UIViewController instance in the static object. Ideally someone with experience with the lib would evaluate and fix it by finding the others path of cleanup (when switching app for example).
In time being patch-package can be your friend, it is simple to use:
https://dev.to/zhnedyalkow/the-easiest-way-to-patch-your-npm-package-4ece

Maybe if it can help someone. Here are some details...
The lib is composed of

A derivation of UIViewController, an apple primitive to present things. This is an instance.
A single static object to expose functions to react/java (which point to a single ViewController)

The lib takes one of the following wrong assumption:

Only 1 UIViewController exist at a given moment (not clear given the complexity of view system)
The system will always call viewDidDisappear (most likely the bug when switching app)

The ok-but-not-great fix is to comment or remove the guard as proposed. It clean the left over UIViewController instance in the static object. Ideally someone with experience with the lib would evaluate and fix it by finding the others path of cleanup (when switching app for example).
In time being patch-package can be your friend, it is simple to use:
https://dev.to/zhnedyalkow/the-easiest-way-to-patch-your-npm-package-4ece


[question] How to get whole response from :on-success?

Hello :)
Just one question from me - how to get the whole response in :on-success? It looks like the result is response body only.

For anyone that encounters a similar problem, the answer is to use a correctly configured ring-response-format, like this:
:response-format (ajax/ring-response-format {:format (ajax/json-response-format)})

This isn't super clear but it does the job right.


Why fork?

Why is cachepot a fork? Isn't security a core concern for sccache too? Or is this fork mostly about the ability to develop independently without the sccache maintainers' approval?

There was a time when Mozilla layoffs conincided with a a cache PR review dormancy and general radio silence. There is an ongoing conversation regarding direction and alignment between the projects.
I think the threat model needs to be clearly defined for cachepotl, but that's a bit out of scope for this PR.


Docker image?

Hello,
Any plans of containerizing this application yet? I am trying to do it myself but it appears that some dependencies wouldn`t work in production environment (and crash in development as well)
Thanks!

Thanks for your message! What kind of application/benefit do you see for running the tool inside a docker container versus running it on your local machine?

Not sure whether it`s a personal preference but I just prefer to keep everything separated while well interconnected. And, ghostfolio has the option to go for a selfhosted docker container and it would pair up pretty well!
In any case, thanks a lot guys for your work!

Da: Dick Wolff @.>
Inviato: mercoledì 31 gennaio 2024 18:38
A: dickwolff/Export-To-Ghostfolio @.>
Cc: semiBE @.>; Author @.>
Oggetto: Re: [dickwolff/Export-To-Ghostfolio] Docker image? (Issue #25)
Thanks for your message! What kind of application/benefit do you see for running the tool inside a docker container versus running it on your local machine?
—
Reply to this email directly, view it on GitHubhttps://github.com/dickwolff/Export-To-Ghostfolio/issues/25#issuecomment-1919590866, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB3GOCJAJSGOVLHEJEO54DTYRJ6PRAVCNFSM6AAAAABCTO6BIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJZGU4TAOBWGY.
You are receiving this because you authored the thread.

I could do a poc with a file watcher that maps to a local folder on your disk where you could put your export and then the tool would import it, process and then output somewhere.
I will try to put something together when I have some time and will tag you whenever so you can test it!

I have created a first version of the tool that should support DEGIRO and Trading 212 conversions.
You can run it like docker run -d -v /C/users/dickw/docker_in:/var/input -v /C/users/dickw/docker_out:/var/output dickwolff/export-to-ghostfolio
The containerized version of the tool will look to /var/input within the container (which you can specify with a volume mount) for input files, and likewise to var/output for the folder where the result file will be put.
The Docker image will continue to look for new files and when a file is given it will try to detect which converter is needed to parse and then run the same script as when you run npm run start xxx locally.
Can you check wether this is what you were expecting @semiBE , that way I know I'm on the right path and can then continue on improving the solution afterwards.
Thanks!

Hey @dickwolff thanks for reacting so quickly!
The PoC I think is pretty good I think! In case you don't want to have it running all the time you can just spin it to process the available files and stop it afterwards!
I have spun it up once and tried to copy one degiro csv file in the input folder but it looks like there's nothing appearing in the log somehow. I have integrated the env variables in my docker composer (not the INPUT_FILE of course) that you can see here below
version: '3.3' services:   ExportToGhostfolio:     image: dickwolff/export-to-ghostfolio     container_name: ExportToGhostfolio     volumes:       - /srv/dev-...../ExportToGhostfolio/input:/var/input       - /srv/dev-...../ExportToGhostfolio/output:/var/output     restart: unless-stopped

Maybe making it watch files should be a flag you give when starting the container. Will look into that when I have time.
Will then also look at the issue you mention. I did some code merging today (merged a unit test pr early because i had some code changes in there for better error handling which could benefit this branch). I haven't run the container since, so maybe an error slipped through.

@semiBE I seem to have changed the folder names from "/var/input" to "/var/e2g-input" and likewise for output. It makes sense your files aren't processed then ;-)
Try again with the like of: docker run -d -v /C/users/dickw/docker_in:/var/e2g-input -v /C/users/dickw/docker_out:/var/e2g-output dickwolff/export-to-ghostfolio

Accidental closing by mentioning in PR #27
I have merged the first version of the tool. Any additional feedback would be welcome and I can add that in another PR.

Hi!
So I have tested this new version and indeed that it recognizes a new file which nevertheless fails the conversion (log below). Note that my degiro csv file is in French if that makes any difference and I don't see a field called "comment" either. The csv is directly downloaded from the website and passed on to the e2g.
2024-02-02T18:42:17.682298425Z [i] Found Account.csv!
2024-02-02T18:42:17.686476537Z [i] Determined the file type to be of kind 'degiro'.
2024-02-02T18:42:17.686651631Z [i] Processing file using DeGiro converter
2024-02-02T18:42:17.686663435Z [i] NOTE: There is a new version available of the DeGiro converter
2024-02-02T18:42:17.686683270Z [i] The new converter has multiple record parsing improvements and also supports platform fees.
2024-02-02T18:42:17.686690394Z [i] The new converter is currently in beta and we're looking for your feedback!
2024-02-02T18:42:17.686700312Z [i] You can run the beta converter with the command 'npm run start degiro-v2'.
2024-02-02T18:42:17.700139943Z [i] Read CSV file. Start processing..
2024-02-02T18:42:20.150193827Z /app/src/converters/degiroConverter.ts:156
2024-02-02T18:42:20.150217504Z             if (result.activities[result.activities.length - 1].comment === "txfees") {
2024-02-02T18:42:20.150222672Z                                                                 ^
2024-02-02T18:42:20.151421098Z TypeError: Cannot read properties of undefined (reading 'comment')
2024-02-02T18:42:20.151449943Z     at DeGiroConverter.<anonymous> (/app/src/converters/degiroConverter.ts:156:65)
2024-02-02T18:42:20.151457067Z     at Generator.next (<anonymous>)
2024-02-02T18:42:20.151463213Z     at fulfilled (/app/src/converters/degiroConverter.ts:5:58)
2024-02-02T18:42:20.151467473Z     at processTicksAndRejections (node:internal/process/task_queues:95:5)

There is a chance there is some language specific stuff in your export. Can you maybe send me a (partial) export example so I can take a look?

Indeed it could be. There you go:
Date,Heure,Date de,Produit,Code ISIN,Description,FX,Mouvements,,Solde,,ID Ordre
03-01-2024,19:47,03-01-2024,,,"Virement depuis votre Compte Espèces à la flatexDEGIRO Bank: 1 0,84 EUR",,,,EUR,0.21,
03-01-2024,19:47,03-01-2024,FLATEX EURO BANKACCOUNT,NLFLATEXACNT,Degiro Cash Sweep Transfer,,EUR,1.84,EUR,1.05,
03-01-2024,14:26,03-01-2024,ISHARES MSCI WOR A,IE00B4L5Y983,Taxe sur les Opérations Boursières belge (TOB),,EUR,-0.10,EUR,6.21,1dgsag-ddgsc-4dsgd-9mh6-5aaaaaaa

Thanks. I will add those to the DEGIRO converters.
Do you perhaps also have a buy/sell (+tx fee) and dividend (+tax) records? So I can check whether those will work or if they also require a code change.

Hey, I have the same issue as mention aboved.
Mine is portuguese.
Data,Hora,Data Valor,Produto,ISIN,Descrição,T.,Mudança,,Saldo,,ID da Ordem 05-02-2024,22:52,05-02-2024,,,"Levantamentos da sua Conta Caixa na flatexDEGIRO Bank AG: 2,5 EUR",,,,EUR,15.68, 05-02-2024,22:52,05-02-2024,FLATEX EURO BANKACCOUNT,NLFLATEXACNT,Degiro Cash Sweep Transfer,,EUR,2.50,EUR,18.18, 05-02-2024,07:17,31-01-2024,,,Custo de Conectividade DEGIRO 2024 (Euronext Amsterdam - EAM),,EUR,-2.50,EUR,15.68,
clone the repo and tried it locally after trying the docker version and both failed

The issues are being caused by "Compra 6 ISHARES MSCI WOR A@49,785 EUR (IE00B4L5Y983)"

@rodriguestiago0

Degiro-v2 is throwing this error

I made some changes earlier that puts the contents of the CSV as the parameter of the process function of the converter, instead of the file path. I made those changes everywhere but the DEGIRO V2 converter. I have fixed this and the tool now runs.

The example above works. But the example below doesn't.

I found an issue with the look-ahead mechanism that sometimes had empty records. That made the tool crash (without an obvious error). I added a check to prevent this. The tool now produces a valid result.

I have also added a new environment variable FORCE_DEGIRO_V2 which you can set to true. When you provide a DEGIRO file, the converter will use the V2 converter instead of the normal one.

@semiBE I have added French language specifics to DEGIRO V2 converter, which is now also published via Docker (as are the Portugese ones @rodriguestiago0). Can you try if the converter now works for you?

@dickwolff  thank you for the feedback.
Account.csv
Can you check this file? is falling.

@dickwolff thank you.
Tried with v2 and it's no writing the output. And v1 fails with the same error
Account.csv

I'm sorry to hear that. I will look into this weekend and get back to you.

IT WORKS!
The problem in my case was that some lines in the csv were not correctly parsed and it was giving some error at specific but those lines didn`t correspond to operations but rather to some cash management so I could just delete them. Now it parses them perfectly :) All the operations are in ghostfolio! Love it!
PS: I might spend some time in the next couple of months to develop a code to import etoro operations but I will only be able to do to in python, would you be interested in including it into this tool?
Thanks a lot @dickwolff!

Great to hear it works now! I can also add those cash management records to the ignore list and then you dont have to remove them yourself next time. But that is up to you.
Regarding eToro, if you can provide me with an example csv with all transactions types it has (buy, sell, dividend, fees if applicable), I think I can add a converter in a couple of hours 😅

Well, these lines gave issues:
05-02-2024,07:17,31-01-2024,,,Frais de connexion aux places boursières 2024 (Euronext Amsterdam - EAM),,EUR,-2.50,EUR,1211.21,
05-02-2024,07:17,31-01-2024,,,Frais de connexion aux places boursières 2024 (Xetra - XET),,EUR,-2.50,EUR,1213.71,
30-06-2023,08:00,29-06-2023,,,Operation de change - Crédit,,EUR,21.70,EUR,6.20,
15-02-2023,16:07,15-02-2023,,,Versement de fonds,,EUR,0.05,EUR,1.50,

For eToro there`s no csv only xlsx because it has multiple tabs but only one is the interesting one. Here the content of a converted xlsx to csv:
Date,Type,Details,Amount,Units,Realized Equity Change,Realized Equity,Balance,Position ID,Asset type,NWA
01/01/2024 05:50:54,Interest Payment,,0.08,-,0.08,"4,581.91",0.00,-,,0.00
02/01/2024 00:10:33,Dividend,NKE/USD,0.17,-,0.17,"4,581.91",99.60,2272508626,Stocks,0.00
02/01/2024 00:10:33,Dividend,NKE/USD,0.16,-,0.16,"4,581.91",99.60,2446419144,Stocks,0.00
03/01/2024 00:04:03,Dividend,LRCX/USD,0.51,-,0.51,"4,581.91",100.11,1434892477,Stocks,0.00
03/01/2024 13:09:09,Withdraw Fee,-,0.00,-,0.00,"4,581.91",100.11,-,,0.00
03/01/2024 13:09:09,Withdrawal Conversion Fee,-,-1.36,-,0.00,"4,581.91",0.00,-,,0.00
03/01/2024 13:09:09,Withdraw Request,-,-100.11,-,-100.11,"4,581.91",0.00,-,,0.00
07/01/2024 13:21:57,Dividend,NXPI/USD,0.28,-,0.28,"4,581.91",0.00,1446737312,Stocks,0.00
07/01/2024 13:21:57,Dividend,NXPI/USD,0.04,-,0.04,"4,581.91",0.00,1453559680,Stocks,0.00
09/01/2024 15:30:40,Position closed,OLED/USD,18.43,0.102626,7.37,"4,581.91",0.00,2355395242,Stocks,0.00
09/01/2024 15:36:54,Position closed,AMAT/USD,0.38,0.002556,0.04,"4,581.91",0.00,2596568830,Stocks,0.00
09/01/2024 15:37:16,Open Position,AMD/USD,49.88,0.337209,0.00,"4,581.91",0.00,2596572937,Stocks,0.00
09/01/2024 15:37:25,Open Position,SLAB/USD,27.37,0.219575,0.00,"4,581.91",0.00,2596576844,Stocks,0.00
09/01/2024 15:40:09,Open Position,SWKS/USD,93.62,0.888488,0.00,"4,581.91",0.00,2596634782,Stocks,0.00
10/01/2024 00:11:24,Dividend,DIS/USD,0.14,-,0.14,"4,581.91",0.00,1003296596,Stocks,0.00
10/01/2024 00:11:24,Dividend,DIS/USD,0.29,-,0.29,"4,581.91",0.00,1068527084,Stocks,0.00
16/01/2024 00:17:08,Dividend,HST/USD,0.07,-,0.07,"4,581.91",0.80,2565075017,Stocks,0.00
16/01/2024 20:08:09,Position closed,AMD/USD,61.27,0.388423,38.57,"4,581.91",0.80,2602058508,Stocks,0.00
17/01/2024 00:04:27,Dividend,KER/EUR,0.03,-,0.03,"4,581.91",0.80,697085768,Stocks,0.00
17/01/2024 00:04:28,Dividend,KER/EUR,0.01,-,0.01,"4,581.91",0.80,831716072,Stocks,0.00
17/01/2024 00:04:28,Dividend,KER/EUR,0.01,-,0.01,"4,581.91",0.80,1074146904,Stocks,0.00

Anything which can come out of this will be great, thanks in advance!

Quick question, I don't see a currency in the CSV. What is de default currency that Etoro uses? And are investments converted to that currency? (For example there is a KER/EUR and DIS/USD; different currencies).

The default currency is USD and for each transaction you have that it's processed in its own currency and you guessed correctly it's after that backslash.
That was fast! I'll provide you with the instructions on how to export the account statements from eToro so that you can add them to the Readme. Thanks again!

I have added débit to the skip list.

Tried with v2 and it's no writing the output. And v1 fails with the same error

@rodriguestiago0 I have run the tool locally with the file you provided and added some more language specific rules to the DEGIRO v2 converter. The tool now runs succesfully. It is also available as part of the 0.4.0-beta container on Docker hub.

Thank you for fix
On Fri, 9 Feb 2024 at 08:48, Dick Wolff @.***> wrote:

Tried with v2 and it's no writing the output. And v1 fails with the same
error
@rodriguestiago0 https://github.com/rodriguestiago0 I have run the tool
locally with the file you provided and added some more language specific
rules to the DEGIRO v2 converter. The tool now runs succesfully. It is also
available as part of the 0.4.0-beta container on Docker hub.
—
Reply to this email directly, view it on GitHub
https://github.com/dickwolff/Export-To-Ghostfolio/issues/25#issuecomment-1935538238,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVNAC6Q2K4UBBE7GTYF4KTYSXPF7AVCNFSM6AAAAABCTO6BIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZVGUZTQMRTHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Closing this with fixes from #28 .
Should there be any other issue, please open a new issue.


about datetime parsing issue

There is a potential error in the code below when the month is 12:
https://github.com/baeseongsu/ehrxqa/blob/724bff13a9a2e430ecd54f32e3ef3789bb7fcdb3/experiment/NeuralSQL/executor/sqlglot/executor/env.py#L238-L242
Especially, this part can evoke an error:
day = min(arg.day, (datetime.datetime(year, month + 1, 1) - datetime.timedelta(days=1)).day)

The corrected version should be:
if month == 12:
    last_day = (datetime.datetime(year + 1, 1, 1) - datetime.timedelta(days=1)).day
else:
    last_day = (datetime.datetime(year, month + 1, 1) - datetime.timedelta(days=1)).day
    day = min(arg.day, last_day)

Note that the previous (customized) datetime function for the sqlglot package, which was used in the arXiv (v2) paper:

def datetime_fn(arg, fmt=None):
    """
    Custom implementation of datetime function.
    """
    if isinstance(arg, str):
        arg = datetime.datetime.fromisoformat(arg)

    if fmt is None:
        return arg

    if fmt == "start of month":
        return datetime.datetime(arg.year, arg.month, 1)
    elif fmt == "start of year":
        return datetime.datetime(arg.year, 1, 1)
    elif fmt == "start of day":
        return datetime.datetime(arg.year, arg.month, arg.day)
    else:
        number, unit = fmt.split(" ")
        if unit == "day":
            return arg + datetime.timedelta(days=int(number))
        elif unit == "month":
            return arg + datetime.timedelta(days=int(number) * 30)
        elif unit == "year":
            return arg + datetime.timedelta(days=int(number) * 365)
        else:
            raise NotImplementedError(f"Unsupported unit '{unit}'.")

Note that in SQLite3, the strftime function has different format specifiers, including %J and %j, which differ only in capitalization. The %J specifier is used to return the Julian day number as a floating-point value. For example, strftime('%J', '2024-08-27') might return something like 2461076.5, representing the Julian day number for that date.
On the other hand, %j returns the day of the year as a three-digit number, ranging from 001 to 366 (taking leap years into account). Therefore, to accurately compute the time gap between two different dates, you should use the uppercase format specifier %J.


SPARKC-93:  Remove use of Thrift describe_ring.

Remove describe_ring call and replace it with native Java Driver support for fetching token ranges with corresponding replica sets from the Cluster metadata. Removed CassandraNode class, because now an endpoint is represented by only one address, taken from the Java driver Host object.  This is the first step towards removing thrift dependency from the connector code.

Sgtm +1


Improve snarkVM usability, expands on DPC and ledger usability

Motivation
A modest set of changes to improve snarkVM ergonomics, expands on DPC and Ledger usability.

Ledger with genesis block returns to block height of 0 (same as master branch)
Adds snarkVM-level member access (e.g. snarkvm::dpc::testnet1::*)
Unifies the parameter generation programs between networks
Makes Parameters::program_srs(rng) a lazy static load
Simplifies snarkvm-integration library

The changes look reasonable. I was also thinking about having a snarkvm crate that imports the rest. And I am glad that we have it now. It simplifies what snarkos needs to import. And if one wants to debug, just apply a patch over the snarkvm crate.

@weikengchen you can see an example of snarkOS updated to use just snarkvm here: https://github.com/AleoHQ/snarkOS/pull/978/files