Cascaded DITAVAL filtering is not properly applied to multiple-condition profiled content

Expected Behavior
This is a follow-up issue from discussion in #4085.
In <IP_ADDRESS> <ditavalref>, I interpret the paragraph about cascaded <ditavalref> elements as follows:

If a "condition" (attribute name and value) is excluded at a higher level, that condition cannot be reenabled for inclusion at a lower level.
Processing-wise, <ditavalref> is applied from top to bottom, with higher levels removing conditions from consideration by lower levels.
It is the exclusions, not the inclusions, that combine in an OR-like way from top to bottom.

As an industrial DITA user, I would expect this behavior so that sensitive content excluded from a higher level cannot unexpectedly be re-included at a lower level, such as when reusing common submaps. (However, we have yet to hit this scenario in practice, so there is no urgency from us.)
Actual Behavior
Content separately profiled for A or for B is filtered as expected. But content profiled for "A or B" is published, which is unexpected.
This occurs for cascaded branch filtering:

It also occurs for global filtering followed by branch filtering:

Possible Solution
In addition to removing content elements that are excluded, perhaps the global and branch filtering code can also remove the excluded keywords themselves from attribute values when only some keywords in the value are excluded. This would more accurately reflect the propagation of exclusions described in section <IP_ADDRESS>.
Steps to Reproduce

Download the following testcase:
4094.zip
Run the following commands:
dita --project cascaded-branch/project.xml
dita --project global-then-branch/project.xml

Environment

DITA-OT version: 4.0
Operating system and version: Linux
How did you run DITA-OT? dita command
Transformation type: HTML5

This would be a huge problem for us, since several of our projects use composable ditavals to produce a composite condition set.
Btw, We've seen some topicmeta elements, specifically , not cascading as specified in the DITA spec, and we're in the process of validating our findings and coming up with test content we can use to write a bug report if needed. I'm mentioning this in case there's a wider issue with cascading, whether it be ditavals or metadata elements.

@kirkilj - is your content profiled for multiple (space-separated) condition values?

Metadata cascading questions come of from time to time. A search of discussions and open issues on this project as well as threads in dita-ot-users and dita-users will show several occurrences.

In our Ant build files, we have our own pre-OT-project-files macro that uses a comma separated list to get around OS command line parsing issues with some separators. We convert the separators to what OT needs in the pipeline.
<target name="bcs_xxx_cnf" extensionOf="build">
    <build-doc transtype="nswtc-eclipsehelp" mappath="content/Operating_Documentation.ditamap"
      ditavalfile="content/conditions/html.ditaval, content/conditions/cloudnative.ditaval, content/conditions/feature1.ditaval, content/conditions/customer1.ditaval, content/conditions/non-feature2.ditaval" propertyfile="custom/Operating_Documentation.properties"/>
</target>```

We convert these to OT project files transparently before passing them to OT for processing. As I mentioned at DITA-OT Day, I'd love to eliminate our old way of doing this and leverage OT project files directly when we migrate to OT 4.x.

@kirkilj this issue is about using the "ditavalref" branch filtering element, not about setting multiple global DITAVAL files in the transformation command line. I have not tested this second scenario.


Including  in SHA1.h fixes some typing/linking issues.

Fixes #1311
Fixes #1298

Fixes #1311
Fixes #1298

looks good!
#1311 was a duplicate of #1298, indeed

Merged into master and also the head of RB-1.6.
Thanks for figuring this out!

I figured this out when compiling oiio on 32-bits PPC (OS X 10.5), using gcc 4.9.
Note that some atomics are not available on PPC32 and require linking with libatomic.
-latomic is necessary on ppc for __atomic_fetch_add_8 and __atomic_exchange_8
I had to configure OIIO with the flags
-DCMAKE_SHARED_LINKER_FLAGS=-latomic -DCMAKE_EXE_LINKER_FLAGS=-latomic
to make it compile.
This should probably be tested in cmake: if the compiler is GCC-compatible and __atomic_fetch_add_8 is not available, look for it in -latomic
It is done in LLVM:
https://github.com/llvm-mirror/llvm/blob/master/cmake/modules/CheckAtomic.cmake
i still haven't tested the PPC OIIO, though


The 'sync' endpoint is still not reliable

because the /sync/ endpoint doesn't understand how to operate I believe we're still being haunted by empty (no-JSON) responses
Aug 29 00:01:27 mbot bot.sh[31836]: Traceback (most recent call last):
Aug 29 00:01:27 mbot bot.sh[31836]:   File "<string>", line 88, in main
Aug 29 00:01:27 mbot bot.sh[31836]:   File "/usr/lib/python3.6/json/__init__.py", line 354, in loads
Aug 29 00:01:27 mbot bot.sh[31836]:     return _default_decoder.decode(s)
Aug 29 00:01:27 mbot bot.sh[31836]:   File "/usr/lib/python3.6/json/decoder.py", line 339, in decode
Aug 29 00:01:27 mbot bot.sh[31836]:     obj, end = self.raw_decode(s, idx=_w(s, 0).end())
Aug 29 00:01:27 mbot bot.sh[31836]:   File "/usr/lib/python3.6/json/decoder.py", line 357, in raw_decode
Aug 29 00:01:27 mbot bot.sh[31836]:     raise JSONDecodeError("Expecting value", s, err.value) from None
Aug 29 00:01:27 mbot bot.sh[31836]: json.decoder.JSONDecodeError: Expecting value: line 2 column 1 (char 1)

still not reliable but not easy to fix


[Bug] ConfigOptionsDocsCompletenessITCase::testCompleteness failed when CoreOption changed

Search before asking

[X] I searched in the issues and found nothing similar.

Paimon version
0.5-SNAPSHOT
Compute Engine
Flink
Minimal reproduce step

Change core option and run mvn package -Pgenerate-docs -pl paimon-docs -nsu -DskipTests as described in paimon-docs/README.md

Run the test ConfigOptionsDocsCompletenessITCase::testCompleteness

What doesn't meet your expectations?
Test failed.
Anything else?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

Can you describe the detailed reproduce step? I cannot fully understand this.

After I changed some CoreOptions, and tried to rebuild the docs, it is not updating the generated docs.
However, when I run ConfigOptionsDocGenerator directly by passing 2 args (doc path and project root), the generated doc contains my change.
Therefore, I further debugged the paimon-docs module and found out the ${rootDir} variable is not well respected (at least for my maven version 3.6.3). After adding the rootDir property to ../, the docs are correctly genearted.
@JingsongLi

Modify CoreOptions.
mvn clean install -DskipTests
mvn package -Pgenerate-docs -pl paimon-docs -nsu -DskipTests

All works fine now.
What is the problem?


Consider changing the license?

Sooo, GPL3 is a strictly copyleft license, meaning that if I (or anybody) were to use this crate I'd technically have to licence my whole project as GPL3 as well - which is slightly problematic as it's literally just a base conversion algorithm which should be basically in public domain anyway.
And because of that I doubt that it's possible to blame me if I wrote the algorithm on my own (because I don't want to be forced into GPL3) and it turned out to be basically identical because how else would you write it?
My go-to licence is MIT anyway (which is just "use it in any way if you include the LICENSE file cuz it has my name on top of it, attribution"), not like I'm personally planning on profitting from your hard work :stuck_out_tongue:
So can you please consider to relicence this under MIT, or the weird MIT OR Apache 2.0 that's  standard for Rust crates?
I'd personally maybe would've gone with Unlicense or straight up public domain (since the original algorithm was made or at least brought to light by Tantek anyway and he probably wouldn't mind)
It's all just perfectionism at the end of it as I doubt you'd even ever know about my (still opensource, just not GPL3, if this pet doesn't even die before I push the first version) project using your lib if not for that long wall of text I just wrote :)

Sure, I can change the license. This was written a really long time ago and I've been wanting to update it anyways :)

Okay, it's now republished under MIT: https://crates.io/crates/newbase60


Specify .editResponse router method option in middleware

Hey there.
I am just trying out to route some of my requests trough a middleware and I am a little bit stuck as some routes the middleware intercepts would need to specify the .editReponse router option. Is there a possibility to do that right now?

That should already be possible. Are you not able to provide the .editResponse option for the routes where you want to edit the response?

Sadly not if I do not know the routes path in advance and want to route depending on other criterias..

.editResponse is used to edit response headers or status when you are not returning a HBResponse type from a route. You shouldn't need it if you are editing the response in a middleware.
I'm not totally sure what you are trying to do. If you could post some code that would help.

Actually I try to do something similar to pointfree vapor routing. This requires that every route will be processed by the middleware, which then does the routing. However, the routes are not "registered" via the default router of vapor/hummingbird, so its not possible to edit the response if required.

Are you wanting to implement your own router using a middleware?

Basically, yes.

Does your middleware shortcut the responder chain ie generate its own response and not call next.respond method.

Yes. It basically looks like this (some parts left out for brevity):
struct RouterMiddleware<Router: Parser>: HBAsyncMiddleware where Router.Input == URLRequestData {
  let router: Router
  let respond: (HBRequest, Router.Output) async throws -> any HBResponseGenerator

  func apply(to request: Hummingbird.HBRequest, next: Hummingbird.HBResponder) async throws -> Hummingbird.HBResponse {
    let requestData = URLRequestData(request: request)
    let route = self.router.parse(requestData)
    return try await self.respond(request, route).response(from: request)
  }
}

HBRouterMethods have two helper functions constructResponder which create a HBCallbackResponder which supports streaming, response editing and response generators. Unfortunately they are currently internal to Hummingbird. I can make them public , I'll also make them static so you don't need an instance of HBRouterMethods
Do you think that would help?

Cannot say it for sure but that indeed sounds like it would work. Would be great if you could make them public as you said!
May I ask why this has to be specified in the first place? Is this for performance/security reasons?

Cannot say it for sure but that indeed sounds like it would work. Would be great if you could make them public as you said! May I ask why this has to be specified in the first place? Is this for performance/security reasons?

It was mainly an optimisation, most routes don't need the response editing capabilities. For v2 of Hummingbird I intend to get rid of this way to edit response status and header. It is hard to make it thread safe. Instead people will return a type which includes the response generator plus any edits.

I see, thanks for the quick reply! Looking forward to hummingbird v2

@BastianKusserow v1.11.0 has been released with a public HBRouterMethods.buildResponder

I'm going to close this as I think I have provided enough for you to implement what you need

Awesome, thanks a lot for the help. Just tried it out and it works like a charme!


Improvement on excluded sensors with auto-reinclude

Checklist

[x ] I checked for similar existing requests (both open and closed) before posting.
[ ]x My request is generic, other users may benefit from it too.

Proposal
Add the possibility/option to include a excluded sensor after closing closing it.
Additional info
When arming the alarm and a window is still open the sensor is excluded after the exit delay.
When closing the window after the exit delay, the sensor is included and part of the arming.

I'm exactly in the same "issue", if I undertand what @CyborgNL saying.
If I have an open window and I exclude it (automatically or bypassing during manual arming), the sensor stay excluded.. so If I close the window and open it again the alarm not trigger (if I'm not doing something wrong!).

Probably we need an option to "re-enable" excluded sensors on a state change. (window opened > excluded > window closed > auto re-included >safe!)

The requested behaviour is not difficult to implement, in fact this is already in place for motion sensors.
Here the setting is called ‘Allow open after arming’.
If you remove the sensor type it becomes available for your window sensors (click the X behind the type to erase it).
This setting should not be combined with the automatic bypassing, since bypassing will remain active until the alarm is disarmed.
In this case you want alarmo to simply ignore the initial state (during/after arming) and only trigger in case of a state change sequence open-closed-open.
Im open to discuss a change in the interface to make the option visible and more clear for everyone.
Please try out the setting and let me know if it satisfies your needs.

I'll try tomorrow.
Probably could be done more user friendly.
I'm thinking about an extra option in the 3dot menu of Alarmo card "ignore initial states", and obviously same setting in the sensor settings as the same way as auto-bypass, auto-ignore.
Just my idea 👍

I understand what you say but I have still some questions/remarks:

I do not like to change the sensor type. This makes the total overview of sensors unclear.
You mention that this setting should not be combined with automatic bypassing. This is option should be possible because I would leave a window open when arming the alarm in some cases.
Would it be possible to add this option 'Allow open after arming' to the type of window and door sensor)?

I made some tests today.
As you said, to have the "allow open" option in the UI we have to delete sensor type (and enable "use exit delay", or allow open is not visible) and this make the sensors view unclear as @CyborgNL already said.
Looking from a "regular" user pov, probably it's a little bit tricky to obtain the final result: open the sensor, delete sensor type, activate "use exit delay" that activate the just shown "allow open" option.
I try to figure out what a base user can expect (I work in customers support since 20yrs, so often I try to look the things with a base user pov), and probably find options like the following could be better.
Auto-Bypass if active        (@)==
allow arming the alarm also with active/open sensor, but without excluding it. It will trigger if you close than open.
Auto-Exclude if active        (@)==
allow arming the alarm also with active/open sensor, excluding it. It will not trigger if you close than open.
If you enable Auto-Bypass it will disable Auto-exclude and viceversa.
And in the alarmo card, in the three dot menu, you can place options with the same logic (exclude open sensors, bypass open sensors).

The requested behaviour is not difficult to implement, in fact this is already in place for motion sensors. Here the setting is called ‘Allow open after arming’. If you remove the sensor type it becomes available for your window sensors (click the X behind the type to erase it).
This setting should not be combined with the automatic bypassing, since bypassing will remain active until the alarm is disarmed. In this case you want alarmo to simply ignore the initial state (during/after arming) and only trigger in case of a state change sequence open-closed-open.
Im open to discuss a change in the interface to make the option visible and more clear for everyone. Please try out the setting and let me know if it satisfies your needs.

I tried this out, and the option for allow open after arming does not show up when clearing the device type.  It does show up for motion device type.

I made the 'allow open' setting available for window/door sensors and made the description for the setting a bit more explicit:

I will let you know when this feature is released.
@Extreme79 I prefer not to differentiate between bypassing and excluding, I think this would lead to confusion. In Alarmo they are the same thing and will remain effective until disarming.

Thank Niels for the update, much appreciated. 👌🏻

I'll test It as soon as I’ll back @home
Thanks!👍

@nielsfaber This option works if you skip bypass open sensors option when arming the alarm.
What I noticed is that the notification part does not provide any open sensor info any more when you enable this new option. Is there still a notification possible of the open sensors when arming the alarm?

@CyborgNL

This option works if you skip bypass open sensors option when arming the alarm.

Yes, the auto-bypass function causes the sensor to be excluded until the alarm is disarmed. Combining it with the 'allow initially open' wouldn't have any effect, since the sensor is already bypassed.

What I noticed is that the notification part does not provide any open sensor info any more when you enable this new option. Is there still a notification possible of the open sensors when arming the alarm?

Do you mean with the {{bypassed_sensors}} wildcard?
The sensor will not show up here since it is not bypassed (only the initial state is ignored)
I could check if it can be made visible in the {{open_sensors}} wildcard instead, but I don't think it does currently (since the initial state is ignored, it is also not reported as an open sensor).

Yes that is what I ment.
It would be great if you are able to add this to the notification in the {{open_sensors}} even the sensor is ignored or open when arming. 🤞🏻

Hi @nielsfaber any news or status on the sensor reporting part?


[Bug] [JDBC] column "id" is of type uuid but expression is of type character varying

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
I just use jdbc plugin to read table data from my prod database and use jdbc to write data to my dev database, but I get this issue:
java.sql.BatchUpdateException: Batch entry 0 INSERT INTO cnb."Values" ("id","createdAt","updatedAt","deletedAt","name","order","category","lastName","parentId","_ide_status","_ide_script_status") VALUES ('6774d596-8cc8-4c20-8e98-6f2f105d62a8','2021-07-06 16:52:37.477347+08','2021-07-06 16:54:41.764082+08','2021-07-06 16:54:41.764082+08','Test Value',0,'LicenseSubType',NULL,NULL,'normal','normal') was aborted: ERROR: column "id" is of type uuid but expression is of type character varying
The sql is right, but why it not execute it, and throw this error?
SeaTunnel Version
1.5.5
SeaTunnel Config
spark {
  spark.streaming.batchDuration = 5
  spark.app.name = "seatunnel"
  spark.ui.port = 13000
}

input {
       jdbc {
		driver = "org.postgresql.Driver"
		url = "jdbc:postgresql://xxx/postgres?useUnicode=true&charSet=utf8&autoReconnect=true"

		#数据库链接用户名及密码
		user = "xxx"
		password = "xxxxx"
		table = "cnb.\"Values\""
		result_table_name = "xxx"
		jdbc.fetchsize = 100
	}

}

filter {
}

output {
jdbc {
    driver = "org.postgresql.Driver"
    url = "jdbc:postgresql://xxx2?useUnicode=true&charSet=utf8&autoReconnect=true"
   table = "cnb.\"Values\""
    user = "xxx"
    password = "xxx"
}
}

Running Command
../bin/start-seatunnel.sh --master local --deploy-mode client --config ./test.conf

Error Exception
2021-11-25 20:43:09 ERROR Executor:91 - Exception in task 0.0 in stage 0.0 (TID 0)
java.sql.BatchUpdateException: Batch entry 0 INSERT INTO cnb."Values" ("id","createdAt","updatedAt","deletedAt","name","order","category","lastName","parentId","_ide_status","_ide_script_status") VALUES ('6774d596-8cc8-4c20-8e98-6f2f105d62a8','2021-07-06 16:52:37.477347+08','2021-07-06 16:54:41.764082+08','2021-07-06 16:54:41.764082+08','Test Value',0,'LicenseSubType',NULL,NULL,'normal','normal') was aborted: ERROR: column "id" is of type uuid but expression is of type character varying
  建议：You will need to rewrite or cast the expression.
  位置：160  Call getNextException to see other errors in the batch.
        at org.postgresql.jdbc.BatchResultHandler.handleError(BatchResultHandler.java:169)
        at org.postgresql.jdbc.PgStatement.internalExecuteBatch(PgStatement.java:862)
        at org.postgresql.jdbc.PgStatement.executeBatch(PgStatement.java:901)
        at org.postgresql.jdbc.PgPreparedStatement.executeBatch(PgPreparedStatement.java:1644)
        at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$.savePartition(JdbcUtils.scala:676)
        at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$$anonfun$saveTable$1.apply(JdbcUtils.scala:838)
        at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$$anonfun$saveTable$1.apply(JdbcUtils.scala:838)
        at org.apache.spark.rdd.RDD$$anonfun$foreachPartition$1$$anonfun$apply$28.apply(RDD.scala:980)
        at org.apache.spark.rdd.RDD$$anonfun$foreachPartition$1$$anonfun$apply$28.apply(RDD.scala:980)
        at org.apache.spark.SparkContext$$anonfun$runJob$5.apply(SparkContext.scala:2107)
        at org.apache.spark.SparkContext$$anonfun$runJob$5.apply(SparkContext.scala:2107)
        at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
        at org.apache.spark.scheduler.Task.run(Task.scala:123)
        at org.apache.spark.executor.Executor$TaskRunner$$anonfun$10.apply(Executor.scala:411)
        at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1360)
        at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:417)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)

Flink or Spark Version
spark 2.4.8
Java or Scala Version
1.8.0_292
Screenshots

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Could you show the schema of cnb.Values ? @x956606865

@RickyHuo
This is my table DDL:
CREATE TABLE "cnb"."Values" (   "_ide_status" varchar COLLATE "pg_catalog"."default" DEFAULT 'normal'::character varying,   "_ide_script_status" varchar COLLATE "pg_catalog"."default" DEFAULT 'normal'::character varying,   "id" uuid NOT NULL DEFAULT uuid_generate_v4(),   "createdAt" timestamptz(6) DEFAULT now(),   "updatedAt" timestamptz(6) DEFAULT now(),   "deletedAt" timestamptz(6),   "name" text COLLATE "pg_catalog"."default",   "order" int4,   "category" text COLLATE "pg_catalog"."default",   "lastName" text COLLATE "pg_catalog"."default",   "parentId" uuid,   CONSTRAINT "PK_20911d8fe3d2273d60c489da8c9" PRIMARY KEY ("id"),   CONSTRAINT "FK_b27091a97b65d4360e475444a6b" FOREIGN KEY ("parentId") REFERENCES "cnb"."Values" ("id") ON DELETE NO ACTION ON UPDATE NO ACTION ) ;
I just use the id column as primary key, the type is uuid.
but in error report ,the sql it right,why it not execute,but throw a error?
INSERT INTO cnb."Values" ("id","createdAt","updatedAt","deletedAt","name","order","category","lastName","parentId","_ide_status","_ide_script_status") VALUES ('6774d596-8cc8-4c20-8e98-6f2f105d62a8','2021-07-06 16:52:37.477347+08','2021-07-06 16:54:41.764082+08','2021-07-06 16:54:41.764082+08','Test Value',0,'LicenseSubType',NULL,NULL,'normal','normal')

@x956606865 It seem that uuid column can't insert a specify value.

@RickyHuo
But if I run the sql in db, it can insert data successfully....
INSERT INTO cnb."Values" ("id","createdAt","updatedAt","deletedAt","name","order","category","lastName","parentId","_ide_status","_ide_script_status") VALUES ('6774d596-8cc8-4c20-8e98-6f2f105d62a8','2021-07-06 16:52:37.477347+08','2021-07-06 16:54:41.764082+08','2021-07-06 16:54:41.764082+08','Test Value',0,'LicenseSubType',NULL,NULL,'normal','normal')

According to

https://stackoverflow.com/questions/66363284/column-is-of-type-uuid-but-expression-is-of-type-character-varying-in-spark-scal

Add stringtype=unspecified in you jdbc url
@x956606865

@RickyHuo
Oh~ Thanks


Crash in "Chunk View"

When in chunk view zooming out too far or trying to make a selection will cause MC-Edit to close suddenly.
Using Windows 7 64bit and MCedit v<IP_ADDRESS> 64bit

It's not about zooming to much, it's about zooming when your mouse is over areas with no chunks
It's fixed for next release already, thanks!


Took a stab at making a little graphic for the vote token

@santisiri @SFSandra @herbstephens

It's a little tweak of this icon from flaticon.
By the way there is a whole election icon pack if you want to check it out.

i'd be cautious with icons regarding the licensing (i do pay a fee on thenounproject.com to get full rights on the ones we use). I think that we could simply work with the olive emoji 🌿 for iconic purposes since it also resembles the democracy.earth logo :)

Those are actually free to use if author mentionned. But yeah I can work on a simpler version with the 🌿.

simple and clean. to be honest i dont like that icon much :) for icons is good to use things that also work in black & white.

the colours make me think of the american flag... that could have bad connotations...
I think it could be like Aragon's but with the olive branch in the middle. Not the olive branch of the emoji because that one could be any branch.. it's not distinctively an olive branch. Perhaps like the one from DEFs logo

love the idea of the single stalk of wheat in the center but realize it's not a priority to custom design a token at this point.
re: toke image design, aragon did a nice job with all of that layered visual interest through pattern, texture

lets keep it to outlined drawings.

its looking better. now we need to make sure that even if its reduced to 32x32 pixels, the drawing still makes sense (like emoji icons).

following link @virgile-dev provided, this is the closest ....

:1st_place_medal:

https://cdn2.iconfinder.com/data/icons/vote-reward-badges1-2/24/Vote-Stamp-32.png
At 32x32 ... this more simple version might work well.

Following @paulamlb idea.

I really like your proposition @herbstephens

This one looks good on the diagrams.

ok, so now im being a pain in the ass: the olives will render better if its online the outline (without the inner drawing inside the leaves). you can all troll me now.

@santisiri send me the svg file I'll take care of it an upload an updated version of the diagrams.

@virgile-dev i'll try to do something asap.

Check up the thread homie :) @santisiri

Dude I like how that last one is looking 👇🏽

Yes me too !

i love it.. @virgile-dev u da man!

Works on a exchange list too :)

vir, try making a coloured version too (purple background, white label, colored olives maybe?). use the official ones from our twitter icon.


Error while request tags: TaggerRequestHandler requires text to be POSTed to it

Even if I use QueryRequest with METHOD.POST I need to use deprecated override:
@Override
public Collection getContentStreams() {
return Collections.singleton((ContentStream) new ContentStreamBase
.StringStream(input));
}
To get success with solr text tagger request handler.
In TaggerRequestHandler.java
//--Get posted data
Reader inputReader = null;
Iterable streams = req.getContentStreams();
Maybe it's better to support input string via parameters like overlaps -     final String inputString =
req.getParams().get(INPUT_STRING); ?

Yes, it's fairly recent that getContentStreams was deprecated in favor of org.apache.solr.client.solrj.SolrRequest#getContentWriter.  But it'll be around thru the 7.x series for back-compat reasons.  You could send the stream.body param as an alternative.


event-data-convert precessors dont work

i have a last release of gnmic; but when i trie to active this event-processor, i recibe this error issues
Error: failed reading event processors config: unknown processors type: event-data-convert
that's ok or this is a bug?
regards

yep there is an issue there, will be fixed in the next release.

Can you give the latest version (v0.25.0) a try?

Great. It's working fine
Obtener Outlook para Androidhttps://aka.ms/ghei36

From: Karim Radhouani @.>
Sent: Saturday, June 11, 2022 4:24:25 PM
To: karimra/gnmic @.>
Cc: LoboDCOK @.>; Author @.>
Subject: Re: [karimra/gnmic] event-data-convert precessors dont work (Issue #600)
Can you give the latest version (v0.25.0) a try?
—
Reply to this email directly, view it on GitHubhttps://github.com/karimra/gnmic/issues/600#issuecomment-1152985467, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZNMGBZAXJ25G3OQ4MN2MGTVOTRWTANCNFSM5XN7SF7A.
You are receiving this because you authored the thread.Message ID: @.***>


Merge back vNext thaliMobileNative for ios.

PR is added to the queue for testing as 1. task. (f206881)

Test (Fail) 57531243 build is completed (f206881)
See https://github.com/ThaliTester/TestResults/tree/57531243f206881_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (c766d4e)

PR is added to the queue for testing as 2. task. (0087a60)

Test (Success) 57531243 build is completed (0087a60)
See https://github.com/ThaliTester/TestResults/tree/575312430087a60_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

Test 57531243c766d4e(c766d4e) has failed
See https://github.com/ThaliTester/TestResults/tree/57531243c766d4e_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the fail logs

Test<PHONE_NUMBER>87a60(0087a60) has failed
See https://github.com/ThaliTester/TestResults/tree/575312430087a60_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (acc79b5)

Test (Fail) 57531243 build is completed (acc79b5)
See https://github.com/ThaliTester/TestResults/tree/57531243acc79b5_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (980d818)

Test (Fail) 57531243 build is completed (980d818)
See https://github.com/ThaliTester/TestResults/tree/57531243980d818_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (5db8e90)

Test (Success) 57531243 build is completed (5db8e90)
See https://github.com/ThaliTester/TestResults/tree/575312435db8e90_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

Test 575312435db8e90(5db8e90) has failed
See https://github.com/ThaliTester/TestResults/tree/575312435db8e90_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the fail logs

PR is added to the queue for testing as 3. task. (1be71d2)

Test (Success) 57531243 build is completed (1be71d2)
See https://github.com/ThaliTester/TestResults/tree/575312431be71d2_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

Test 575312431be71d2(1be71d2) has failed
See https://github.com/ThaliTester/TestResults/tree/575312431be71d2_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the fail logs

PR is added to the queue for testing as 2. task. (05d96c2)

Test (Success) 57531243 build is completed (05d96c2)
See https://github.com/ThaliTester/TestResults/tree/5753124305d96c2_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

Test<PHONE_NUMBER>d96c2(05d96c2) has failed
See https://github.com/ThaliTester/TestResults/tree/5753124305d96c2_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (8097721)

Test (Success) 57531243 build is completed (8097721)
See https://github.com/ThaliTester/TestResults/tree/575312438097721_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

Test<PHONE_NUMBER>97721(8097721) has failed
See https://github.com/ThaliTester/TestResults/tree/575312438097721_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (1f256a6)

Test (Success) 57531243 build is completed (1f256a6)
See https://github.com/ThaliTester/TestResults/tree/575312431f256a6_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

Test 575312431f256a6(1f256a6) has failed
See https://github.com/ThaliTester/TestResults/tree/575312431f256a6_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the fail logs

Reviewed 48 of 64 files at r1, 9 of 13 files at r3, 1 of 1 files at r4, 3 of 5 files at r5, 1 of 1 files at r6, 1 of 2 files at r7, 1 of 1 files at r8, 1 of 2 files at r9, 1 of 1 files at r10, 1 of 1 files at r11.
Review status: all files reviewed at latest revision, 30 unresolved discussions.

src/ios/JXcoreExtension.m, line 56 [r4] (raw file):
I thought JXcore now had a way to fire events without having to be on the main thread?

src/ios/JXcoreExtension.m, line 114 [r4] (raw file):
Please help educate me here. What happens if this exception gets thrown? Does Thali just crash?

src/ios/MultipeerConnectivity/THEMultipeerClient.h, line 65 [r11] (raw file):
/connectio/connection

src/ios/MultipeerConnectivity/THEMultipeerClient.m, line 62 [r11] (raw file):
How do we keep this class from getting so full we run out of RAM? More generally the spec calls for limiters to make sure that if we get overwhelmed with traffic we shut down rather than trying to handle it. I didn't see those limiters. If they aren't being checked in here can you please open a bug for when they are supposed to be implemented?

src/ios/MultipeerConnectivity/THEMultipeerClient.m, line 161 [r11] (raw file):
In the parent "if" we checked that serverSession connectionState != THEPeerSessionStateConnected and we can only reach this code because that was true. But then here we check that they are equal, which we just checked wasn't true! Unless you are checking for some kind of multi-threaded race condition how could this if statement ever be true? One wonders if the second part of the and in the enclosing IF shouldn't be there?

src/ios/MultipeerConnectivity/THEMultipeerClient.m, line 361 [r11] (raw file):
Shouldn't we at least make sure there is nothing sleezy going on here? For example, shouldn't we validate that peerUUID doesn't equal our own UUID? I'm just paranoid because this is some random string taken from the air.

src/ios/MultipeerConnectivity/THEMultipeerClientSession.m, line 73 [r11] (raw file):
/callabck/callback

src/ios/MultipeerConnectivity/THEMultipeerManager.m, line 167 [r11] (raw file):
Please humor me and please put in brackets

src/ios/MultipeerConnectivity/THEMultipeerManager.m, line 292 [r11] (raw file):
If we don't need this why not just remove it? I'm guessing this is a left over from when listening and advertising could be done separately?

src/ios/MultipeerConnectivity/THEMultipeerManager.m, line 366 [r11] (raw file):
Why is this disabled?

src/ios/MultipeerConnectivity/THEMultipeerServer.m, line 176 [r11] (raw file):
/constiuent/constituent

src/ios/MultipeerConnectivity/THEMultipeerServer.m, line 177 [r11] (raw file):
This call makes me nervous because if I'm following the code correctly this data is being passed into us directly by iOS who got it directly from the other caller. Do we know what, if any, work iOS does to make sure that whatever is in context can't hurt us? Do we need to check if it is null? If it can be in a format that could cause some problem with alloc? If it has a reasonable length?

src/ios/MultipeerConnectivity/THEMultipeerServer.m, line 186 [r11] (raw file):
What happens if these are malformed? Remember, we are taking arbitrary data off the net. Danger Will Robinson? Don't we need to check?

src/ios/MultipeerConnectivity/THEMultipeerServer.m, line 223 [r11] (raw file):
Why not stick in a return and get rid of the else?

src/ios/MultipeerConnectivity/THEMultipeerSocketRelay.m, line 273 [r11] (raw file):
I'm curious why you changed from a const to a define?

src/ios/proj/Thali/TestAppTests/ThaliMultipleInstanceTests.m, line 130 [r11] (raw file):
I think the second app2 in the sentence above is meant to be app1

src/ios/proj/Thali/TestAppTests/ThaliMultipleInstanceTests.m, line 315 [r11] (raw file):
But shouldn't this test fail? In other words if a peer sends an invite to UUID Foo and then the server changes its UUID to be Bar then shouldn't an old request to Foo fail?

src/ios/proj/Thali/TestAppTests/ThaliMultipleInstanceTests.m, line 498 [r11] (raw file):
Wouldn't a large bit of data perhaps test things better? Say at least a meg or two?

src/ios/proj/Thali/TestAppTests/ThaliSingleInstanceTests.m, line 41 [r11] (raw file):
It would be great to also test that we can call stop several times in a row without an error.
Also it would probably be a good idea to have tests where we call start and stop interleaved with each other just to make sure that state restarts appropriately.

src/ios/THEAppContext.m, line 122 [r4] (raw file):
Isn't it time to remove this? The tests are all dead, right?

src/ios/THEAppContext.m, line 108 [r11] (raw file):
Is there a 10 foot tall warning somewhere that both startUpdateAdvertising and startListening have to both be on or connections won't work?

src/ios/THEAppContext.m, line 169 [r11] (raw file):
Same comment as above, time to retire this?

src/ios/THEAppContext.m, line 222 [r11] (raw file):
Sigh...  We aren't using it and it isn't clear when we will use it. The problem is that it's a major goal to eventually use this to enable the BLE hub functionality. I guess we just have to leave it here? We could at least mark it as not being called?

src/ios/THEAppContext.m, line 341 [r11] (raw file):
At least according to the spec these aren't the right values for network changed. See here

src/ios/THEThaliEventDelegate.h, line 37 [r11] (raw file):
Are we just not implementing discoveryAdvertisingStateUpdate? That's probably o.k. We should wait until somebody needs it but I wanted to make sure this was intentional and not just an accident?
What about incomingConnectionToPortNumberFailed? That seems pretty important.

test/TestServer/UnitTestConfig.js, line 13 [r11] (raw file):
You're checking in android set to 0?

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 67 [r11] (raw file):
As I mentioned in the native code it would be really good to have start-stop-start tests just to make sure we clean up our state properly. But I think this would require more than just checking the bool that comes back. It would probably be something to stick on a test that moves data around. E.g. take that data moving tests and basically run it twice in a row.

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 111 [r11] (raw file):
Don't we also need tests for discoveryAdvertisingStateUpdateNonTCP (or a clear statement that we just aren't going to implement it for now which is fine) , networkChanged and incomingConnectionToPortNumberFailed? It's fine not to implement all of those now. But please open a new bug so we don't forget.

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 112 [r11] (raw file):
Do you intend to do a separate test for actually moving (large) amounts of data? This should be separate from the perf tests. But we should always have a good test that we can move around a few megs without issue.

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 124 [r11] (raw file):
Don't we need to make sure these are peers we are expecting so we don't end up making a mess talking to broken clients who just happen to be around?

Comments from the review on Reviewable.io

PR is added to the queue for testing as 2. task. (01473a8)

Test (Fail) 57531243 build is completed (01473a8)
See https://github.com/ThaliTester/TestResults/tree/5753124301473a8_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

PR is added to the queue for testing as 2. task. (fe78772)

Test (Fail) 57531243 build is completed (fe78772)
See https://github.com/ThaliTester/TestResults/tree/57531243fe78772_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

PR is added to the queue for testing as 2. task. (1745da8)

Test (Success) 57531243 build is completed (1745da8)
See https://github.com/ThaliTester/TestResults/tree/575312431745da8_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

Test<PHONE_NUMBER>45da8(1745da8) has failed
See https://github.com/ThaliTester/TestResults/tree/575312431745da8_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the fail logs

PR is added to the queue for testing as 1. task. (f4b2975)

Test (Fail) 57531243 build is completed (f4b2975)
See https://github.com/ThaliTester/TestResults/tree/57531243f4b2975_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (fa91ca3)

Review status: 0 of 71 files reviewed at latest revision, 30 unresolved discussions.

src/ios/JXcoreExtension.m, line 56 [r4] (raw file):
If it does it's not obvious: https://github.com/jxcore/jxcore-ios-sample/blob/master/JXcoreSample/JXcore/JXcore.h

src/ios/JXcoreExtension.m, line 114 [r4] (raw file):
Yes. We're running as a plugin remember.. so we're really just throwing to the cordova wrapper and invoking whatever behaviour it has for uncaught exceptions. In practice this will never throw though.. unless something's trashed memory perhaps.. we're completely in control of the objects being passed here.

src/ios/MultipeerConnectivity/THEMultipeerClient.h, line 65 [r11] (raw file):
/on/one

src/ios/MultipeerConnectivity/THEMultipeerClient.m, line 62 [r11] (raw file):
Added a limit.. 64.. perhaps too high.

src/ios/MultipeerConnectivity/THEMultipeerClient.m, line 161 [r11] (raw file):
Should be checking for NotConnected. Fixed.

src/ios/MultipeerConnectivity/THEMultipeerClient.m, line 361 [r11] (raw file):
In normal operation you never discover yourself. If someone's deliberately cloning your ephemeral id then so what. Node layer can't discriminate and so you're just in the same case as them cloning someone else's id.. higher level's must take of determining an impersonation.

src/ios/MultipeerConnectivity/THEMultipeerManager.m, line 167 [r11] (raw file):
/brackets/braces
/humor/humour

src/ios/MultipeerConnectivity/THEMultipeerManager.m, line 292 [r11] (raw file):
No.. experimenting whether we need to restart both server and client to keep things ticking over.. it currently looks like just the client needs restarting to make things work. Will remove once I'm happy that's definitely the case.

src/ios/MultipeerConnectivity/THEMultipeerSocketRelay.m, line 273 [r11] (raw file):
So am I.

src/ios/proj/Thali/TestAppTests/ThaliMultipleInstanceTests.m, line 315 [r11] (raw file):
It's not connecting to the old id.. it's connecting to the new one. Order of execution is not straight down the page. I'll put in the converse test to illustrate.

src/ios/proj/Thali/TestAppTests/ThaliMultipleInstanceTests.m, line 498 [r11] (raw file):
That's for a different test.

src/ios/THEAppContext.m, line 108 [r11] (raw file):
So.. perhaps bad.. but when users calls startAdvertising.. I start the client anyway which is what isListening is all about. Did you manually start the client or did I start one to be able to initiate reverse connection. All works as expected at the node layer.

test/TestServer/UnitTestConfig.js, line 13 [r11] (raw file):
Nope.. I'm testing CI with android set to 0

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 111 [r11] (raw file):
networkChanged presents challenges for testing.

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 124 [r11] (raw file):
Does it really matter ? As long as we can make a connection to a peer we're good, right ?

Comments from the review on Reviewable.io

Test (Fail) 57531243 build is completed (fa91ca3)
See https://github.com/ThaliTester/TestResults/tree/57531243fa91ca3_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (74916c2)

Test (Success) 57531243 build is completed (74916c2)
See https://github.com/ThaliTester/TestResults/tree/5753124374916c2_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

Test<PHONE_NUMBER>916c2(74916c2) has failed
See https://github.com/ThaliTester/TestResults/tree/5753124374916c2_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the fail logs

Reviewed 53 of 76 files at r17, 18 of 19 files at r18, 3 of 3 files at r19, 2 of 2 files at r20.
Review status: all files reviewed at latest revision, 13 unresolved discussions.

readme.md, line 43 [r20] (raw file):
I think this has now been fixed in the very latest release of JXcore.

src/ios/THEAppContext.m, line 379 [r20] (raw file):
What if the radios are turned off?

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 111 [r11] (raw file):
Oh please. Just root each phone and use private APIs to turn the network on and off. Oh and while you're doing that also put in an automatic unrooter so the rest of the tests can run in a proper environment. Seriously... devs these days. :)

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 124 [r11] (raw file):
I'm going to say yes but wow do I bet this one will bite us eventually.

Comments from the review on Reviewable.io

PR is added to the queue for testing as 1. task. (35d934c)

Test (Fail) 57531243 build is completed (35d934c)
See https://github.com/ThaliTester/TestResults/tree/5753124335d934c_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (4672864)

Test (Fail) 57531243 build is completed (4672864)
See https://github.com/ThaliTester/TestResults/tree/575312434672864_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (33467de)

Test (Fail) 57531243 build is completed (33467de)
See https://github.com/ThaliTester/TestResults/tree/5753124333467de_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (afeb1f4)

Test (Fail) 57531243 build is completed (afeb1f4)
See https://github.com/ThaliTester/TestResults/tree/57531243afeb1f4_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

PR is added to the queue for testing as 1. task. (aaa3517)

Test (Fail) 57531243 build is completed (aaa3517)
See https://github.com/ThaliTester/TestResults/tree/57531243aaa3517_Merge_back_vNext_thaliMobileNative_for_ios__tobybrad/ for the logs

@tobybrad, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Review status: 59 of 69 files reviewed at latest revision, 11 unresolved discussions.

readme.md, line 43 [r20] (raw file):
Done.

Comments from the review on Reviewable.io


CAN NOT RUN TURBOPILOT USING DOCKER

Hi,
I've followed your guideline by running turbopilot from docker image. I ran into the error:

I'm using Ubuntu WSL2 on Windows 11.

Very strange - it looks like you have the right arguments and config set up. Can you confirm that the model file you downloaded is from "the bloke" repository and that it is in tact (try running sha256sum ./models/stablecode-instruct-alpha-3b.ggmlv1.q4_0.bin - the hash you get should be 7143e0148e5c0101fb66ce6e233182c10db4a52b438cae557a7d368f98eb29a1). You may need to  re-download the model.
If that's not the problem it may be something to do with the GGML loader behaviour on WSL but I won't get ahead of myself until we've confirmed that the files are ok.

Very strange - it looks like you have the right arguments and config set up. Can you confirm that the model file you downloaded is from "the bloke" repository and that it is in tact (try running sha256sum ./models/stablecode-instruct-alpha-3b.ggmlv1.q4_0.bin - the hash you get should be 7143e0148e5c0101fb66ce6e233182c10db4a52b438cae557a7d368f98eb29a1). You may need to re-download the model.
If that's not the problem it may be something to do with the GGML loader behaviour on WSL but I won't get ahead of myself until we've confirmed that the files are ok.

The issue go away, but I got another issue while I was using your extension to integrate with vscode.

I believe my laptop has enough RAM to run this model:

@ravenscroftj any update on this issue?

I'd encourage you to try again with the latest release and also try running with the --debug flag to get more verbose output (rather than using the env vars you can just completely override the docker command after you specify the image name)
Segfault isn't a particularly informative error message so if the changes that went in over the last few days didn't fix it we will have to find a way to get some better output.

I'd encourage you to try again with the latest release and also try running with the --debug flag to get more verbose output (rather than using the env vars you can just completely override the docker command after you specify the image name)
Segfault isn't a particularly informative error message so if the changes that went in over the last few days didn't fix it we will have to find a way to get some better output.

I try with the latest release and it doesn't work.


Event-Driven Service Discovery Documentation Update

Do you already have an issue opened with F5 support?
No.
ISSUE TYPE

Documentation Report
AS3 BUILD/ VERSION

f5-appsvcs-3.12.0
f5-service-discovery-1.1.0 <-- more relevant to this issue

BIGIP VERSION

>13.x

SUMMARY

ISSUE1
For using 'event driven' service discovery the cloudocs documentation specifies an incorrect endpoint for the worker:
https://<host>/mgmt/shared/appsvcs-discovery/task/~<tenant name>~<application name>~<pool name>/nodes

The correct endpoint should be:
https://<host>/mgmt/shared/service-discovery/task/~<tenant name>~<application name>~<pool name>/nodes

The documentation error is made in a few places. Earlier versions of the f5-service-discovery worker (<1.1.0) may use the endpoint documented -- in which case the documentation will need to differentiate endpoints based on AS3 version and f5-service-discovery version. The f5-service-discovery package name changed during the AS3 3.10 release (as documented here).
ISSUE2
Please provide disambiguation around the use of this feature. The documentation section title is "Event-Driven Service Discovery for use in the Docker Container". The feature works whether using AS3 in a container or natively on a BIG-IP. The section title is causing confusion as to where event-driven service discovery can be used.
STEPS TO REPRODUCE

Create a tenant that uses event-driven service discovery.
{
    "class": "ADC",
    "schemaVersion": "3.12.0",
    "Tenant1": {
        "class": "Tenant",
        "App1": {
            "class": "Application",
            "template": "http",
            "serviceMain": {
            "class": "Service_HTTP",
            "virtualAddresses": [
                "<IP_ADDRESS>"
            ],
            "pool": "web_pool1"
            },
            "web_pool1": {
            "class": "Pool",
                "monitors": [
                    "http"
                ],
            "members": [{
                "servicePort": 80,
                "addressDiscovery": "event"
            }]
            }
        }
    }

Attempt to use the documented event-driven service discovery endpoint to alter pool members. POST to https://{{BIG-IP}}/mgmt/shared/appsvcs-discovery/task/~Tenant1~App1~web_pool1/nodes
[
    {
        "id": "newNode1",
        "ip": "<IP_ADDRESS>"
    },
    {
        "id": "newNode2",
        "ip": "<IP_ADDRESS>"
    }
]

EXPECTED RESULTS

200 and the POST successful
{"code":200,"id":"~Tenant1~App1~web_pool1","updateInterval":0,"provider":"event","providerOptions":{"type":"event","previousNodes":[{"id":"/Tenant1/newNode1","ip":"<IP_ADDRESS>"},{"id":"/Tenant1/newNode2","ip":"<IP_ADDRESS>"}],"nodeList":[{"id":"/Tenant1/newNode1","ip":"<IP_ADDRESS>"},{"id":"/Tenant1/newNode2","ip":"<IP_ADDRESS>"}]},"resources":[{"type":"pool","path":"/Tenant1/App1/web_pool1","options":{"servicePort":80,"connectionLimit":0,"rateLimit":"disabled","dynamicRatio":1,"ratio":1,"priorityGroup":0,"monitor":"default"},"requiresNodes":true}],"kind":"shared:service-discovery:taskstate","lastRun":"2019-07-24T17:29:21.970Z","nodePrefix":"/Tenant1/"}

ACTUAL RESULTS

{
  "code": 404,
  "message": "Public URI path not registered. Please see /var/log/restjavad.0.log and /var/log/restnoded/restnoded.log for details.",
  "referer": "<IP_ADDRESS>",
  "restOperationId": 9619385,
  "errorStack": [
    "com.f5.rest.common.RestWorkerUriNotFoundException: Public URI path not registered. Please see /var/log/restjavad.0.log and /var/log/restnoded/restnoded.log for details.",
    "at com.f5.rest.workers.ForwarderPassThroughWorker.cloneAndForwardRequest(ForwarderPassThroughWorker.java:572)",
    "at com.f5.rest.workers.ForwarderPassThroughWorker.access$000(ForwarderPassThroughWorker.java:44)",
    "at com.f5.rest.workers.ForwarderPassThroughWorker$1.completed(ForwarderPassThroughWorker.java:314)",
    "at com.f5.rest.workers.ForwarderPassThroughWorker$1.completed(ForwarderPassThroughWorker.java:311)",
    "at com.f5.rest.workers.EvaluatePermissions.completeEvaluatePermission(EvaluatePermissions.java:150)",
    "at com.f5.rest.workers.EvaluatePermissions.evaluatePermission(EvaluatePermissions.java:78)",
    "at com.f5.rest.workers.ForwarderPassThroughWorker.onForward(ForwarderPassThroughWorker.java:342)",
    "at com.f5.rest.workers.ForwarderPassThroughWorker.onPost(ForwarderPassThroughWorker.java:763)",
    "at com.f5.rest.common.RestWorker.callDerivedRestMethod(RestWorker.java:1161)",
    "at com.f5.rest.common.RestWorker.callRestMethodHandler(RestWorker.java:1119)",
    "at com.f5.rest.common.RestServer.processQueuedRequests(RestServer.java:1385)",
    "at com.f5.rest.common.RestServer.access$000(RestServer.java:48)",
    "at com.f5.rest.common.RestServer$1.run(RestServer.java:329)",
    "at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:473)",
    "at java.util.concurrent.FutureTask.run(FutureTask.java:262)",
    "at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)",
    "at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)",
    "at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)",
    "at java.util.concurrent.ThreadPoolExecuto* Connection #0 to host localhost left intactr$Worker.run(ThreadPoolExecutor.java:615)",
    "at java.lang.Thread.run(Thread.java:745)\n"
  ],
  "kind": ":resterrorresponse"
}

Hi @kreynoldsf5, thank you for the issue.  The corrections are already staged and will be pushed out with the release of AS3 3.13 on Tuesday.


exe vertion

can you please compile to exe as in the past? thank you in advance

Here are the releases: https://github.com/brichard19/BitCrack/releases

the last release is from 8 jun, i ask for the new release about the new update related with cuda 10.


[REFACTOR]: [Nuvei] Remove Default Case Handling

:memo: Feature Description

We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
These conditions generally go hand in hand with enum variants.
Default case is used because a match statement needs to be exhaustive i.e. every variant needs to be covered.
So, if all the explicit cases are handled then default is used to handle the rest.
Each connector have these match statements but many of them don’t provide reference to each variant in their default case, rather a _ is put to handle all the other cases.
This approach carries a risk because developers may inadvertently overlook the need for explicit handling of the new cases.

:hammer: Possible Implementation

Instead of relying on a default match case _, developers should handle each and every variant explicitly.
By doing so, if there are any changes in the future, they can readily assess the impact of their modifications simply by compiling the code.
You can check this PR for further reference https://github.com/juspay/hyperswitch/pull/1955

:bookmark: Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/
:package: Have you spent some time checking if this feature request has been raised before?

[X] I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

:sparkles: Are you willing to submit a PR?

@Sakilmostak If i work on this issue, then i have to implement the same code as this https://github.com/juspay/hyperswitch/pull/1955/commits/4c035c932c760398b90fbc5967963041489eebdb , right ?

Hello @HeetVekariya , it is similar but you only need to take care of variant against fields which require explicit naming such as payment_method_data or bank_names. If you would like, I can assign you this issue

@Sakilmostak i can see that many issues (like: Use connector_request_reference_id as reference to the connector) were assigned one week ago and no response back to you.
They are easy to start with so i am thinking to start with one of them, if no one is working on that issues, if you can assign one of them to me.

Hey @HeetVekariya, currently we are still reviewing for what issue to claim so currently we are unable to assign those issues to you. You can take reference from #2463 for the implementations of this issue, and all the variants required to fill in the statement are present in the definition of the the enum variables itself. We encourage you to have a try since one can feel overwhelmed out of context but with proper help Im sure anything can be resolved.

Okay, so let's try it out. Can you please assign it to me.

Sure @HeetVekariya , I have assigned this to you. For any query you can raise it in this thread


gettting jsxDev is not defined error while using LexicalRichTextPlugin in react

Describe the bug
vite: ^2.8.0
@vitejs/plugin-react: ^1.0.7

Used Package Manager
yarn

Vite 2 won't be updated anymore.
https://vitejs.dev/releases.html#:~:text=The previous Vite Major will keep receiving important fixes and security patches. After that%2C it would only get updates if there are security concerns.


Update Paw to 2.2.4

Thank you for the contribution. It was merged directly as e4bd3d42cab36f707fa658c57a94447fce75af74 to keep commit history cleaner. Your contribution is still credited to you.


Dialog/Drawer ARIA enhancements

Currently the Dialog & Drawer components use role="dialog" but otherwise do not offer ARIA attributes. We should review how to ensure accessible markup is generated, and that even includes two different role possibilities…for example:

Confirmation

Are you sure you want to delete this image?

This change can't be undone.

  ...

and

Your personal details were successfully updated

    You can change your details at any time in the user account section.

  <button>Close</button>

as presented in: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/alertdialog_role
and: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role

Closing, already being used in uptake.


(GH-1200) Add --detail option to show resolved inventory information

This commit adds support for a --detail flag that shows resolved
inventory information when using the inventory show subcommand.

CLA signed by all contributors.


refactor(core)!: remove duplicate committee certificates

Context
RegisterCcHotKeyCertificate and RetireCcCertificate are duplicates of AuthorizeCommitteeHotCertificate and ResignCommitteeColdCertificate respectively.
Important Changes Introduced
BREAKING CHANGE: remove duplicate RegisterCcHotKey and RetireCc certificates

Is this also removed from ogmiosToCore ?


Is snapshot making proper jpg with mimetype?

Version of the custom_component

Version 0.9.40
Configuration

Error sending photo: Image_process_failed. Args: (), kwargs: {'chat_id': 839230461, 'photo': <_io.BufferedReader name='/config/www/tmp/sn_front.jpg'>, 'caption': 'Auto', 'disable_notification': False, 'reply_markup': None, 'timeout': None, 'parse_mode': 'Markdown'}

Describe the bug
Hello, first, thanks for this integration!
I want to send picture via telegram bot when somebody is detected.
I used automation like this:
 - service: camera.snapshot
    data:
      filename: /config/www/tmp/sn_front.jpeg
    target:
      entity_id: camera.front_sub_2
  - service: notify.tgw
    data:
      data:
        photo:
          file: /config/www/tmp/sn_front.jpeg
          caption: Auto
      message: Samochod front

it end up with log as above.
Looking through other issues it seems that snapshot service is making jpg without proper mimetype.
https://github.com/home-assistant/core/issues/7413
Can you check it out? Thanks!

Just if somebody has same issue, I made workaround with pyscript addon from HACS:
from PIL import Image

@service
def convert_image(filename):
   with Image.open(f"/config/www/tmp/{filename}", "r") as im:
      im.save(f"/config/www/tmp/{filename}")

and run service just before sending to telegram_bot.
@rroller let me know if you'd like to get some more info or should I close the issue (I guess it's more Dahua firmware bug)

I have the same issue with a DB61 doorbell but when I checked the mime type of the file it read correctly as image/jpeg. Identical to other fully functional Dahua cameras. I suspect there is something else preventing the snapshot camera service from working. If I use the ONVIF integration with the same DB61 doorbell camera the snapshot service works just fine, the problem is something to do with the HTTP API / Dahua integration...


Add Origin Ether

Revision checks

[x] Used smart contracts were audited.
[x] Your Safe App include a manifest.json file at the root with the required data.
[x] The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
[x] The app auto-connects to the Safe.
[x] You are able to trigger and execute one transaction with a Safe.
[x] RPC requests are optimized (not triggering many requests in a very short time period).

Name/Description
Origin Ether (OETH) is a liquid staking yield aggregator on Ethereum that combines the yield-generating functions of the largest LSDs into one single token.
Type

New addition

Compatible Networks

Mainnet

Audit document
https://docs.oeth.com/security-and-risks/audits
Code for review
https://github.com/OriginProtocol/origin-dollar/tree/master/dapp-oeth
IPFS hash/App URL
https://app.oeth.com/
Team information

Project logo: https://github.com/OriginProtocol/origin-website/blob/master/static/img/coins/oeth-256x256.png
Project landing page: https://oeth.com/
Team contact: https://discord.com/invite/ogn
Twitter link: https://twitter.com/OriginDeFi
Github link: https://github.com/OriginProtocol

@sumpg41 Could you please provide the correct link for the Code review?
The provided repo is just barely initialized. Maybe some branch is missing

@sumpg41 Could you please provide the correct link for the Code review?
The provided repo is just barely initialized. Maybe some branch is missing

Apologies, here is the repo: https://github.com/OriginProtocol/origin-dollar/tree/master/dapp-oeth
and manifest: https://github.com/OriginProtocol/origin-dollar/blob/master/dapp-oeth/public/manifest.json

@dasanra just dropping you a note in case you missed the last comment
cc @JagoFigueroa
cc @safe-global

Good morning! Thank you for the reminder, I will let the team know and we will get to it as soon as we can 😄
(removed the global cc from your message to not disturb the whole safe team with notifications)
Cheers!

Good morning! Thank you for the reminder, I will let the team know and we will get to it as soon as we can 😄

Thank you @JagoFigueroa. This proposal passed a few weeks ago, and they plan to use the OETH dapp on Safe when it is live, so it would be really great if we could get the ball moving on this

Hey @sumpg41 just trying to test the Safe App. I have problems loading it

I'm checking the code in the repo and I can see you are using a deprecated connector @gnosis.pm/safe-apps-web3-react
We are not maintaining that package and removed it from our repos

Hey @sumpg41 any news here? We cannot test the app :(

Hey @sumpg41 any news here? We cannot test the app :(

Apologies for the delay, this issue should be solved in the next merge which should happen by tomorrow

@JagoFigueroa could you take a look?

Looking good! We will let the team know and should be all good to be listed 😄
We will post a confirmation message here once the app is added to the list.
Cheers!

App should be available now

App should be available now

@dasanra thank you!

App should be available now

One more small thing @dasanra @JagoFigueroa - the OETH token that appears in user wallets who use the OETH Safe app is missing the token logo. Could you please add it? Here is the SVG file, I also requested this last month in the Safe Discord.
Thank you!


Custom Logo on Environments

It would be cool, if we could assign a custom logo to the individual environments like on the custom templates.
It would be much simpler to find a specific stack in a larger list of endpoints. Especially if you have only one kind of endpoints in your list, the icon isn't very useful at the moment.

👍


Shortcut to Turn FancyZones On and Off [or a way to use Windows 10 Snap at the same time]

Summary of the new feature/enhancement
Having the ability to turn FancyZones on or off with a keyboard shortcut
I will report this in the bug section but it's relevant to my feature suggestion.
For some reason, I cannot use the "drag" feature to move windows into a zone. The only way I can move windows into zones is to enable "Override Windows Snap hotkeys (Win + Arrow) to move between zones" So for those who use Win+Arrow, this suggestion is relevant.
I created some customer zones for various tasks. However, most of the time, I would like the Win+Arrow to perform as normal (move window to fill right or left of screen). Problem is, after enabling a FancyZone, in order to get back the default use of Win+Arrows, I have to reopen the FZ settings and turn it off. Then, when I need FZ again, I need to again open the settings to turn it on. These are unnecessary steps for a small task.

Yes, I can technically create a two-column zone, mimicking the default Win+Arrows behavior but I am suggesting a keyboard shortcut to do that.

Hi @zvit
instead of turning FZ on and off, would a different key combination for FZ do the trick?
For example would it be ok for you to use Win+Alt+arrows? Or something similar?

Hi @zvit
instead of turning FZ on and off, would a different key combination for FZ do the trick?
For example would it be ok for you to use Win+Alt+arrows? Or something similar?

I don't see any option to change the keyboard shortcut combination for placing windows into zones.
I only see an option to change the shortcut for editing zones.

@zvit
the option is not there yet.
I was asking if an option like that would be a viable solution for you?

@zvit
the option is not there yet.
I was asking if an option like that would be a viable solution for you?

Oh, sorry, I misunderstood you.
Yes, that would help.
Or, alternatively, if we can assign keyboard shortcuts for each custom zone setup, that would be the best.
That way, I would create one setup with two columns, to mimic the default way of two windows, each filling right and left of the screen, and then I can create all types of custom groups and be able to switch between them with shortcuts.
I use AutoHotkey combined with a physical external keypad (Genovation CP48) so I'd assign each layout to a key on the keypad.

I liked the old behavior (v0.14):

LWin+left/right: Fancy Zones
RWin+left/right: Windows Snap

I'd love to get that back

I'd love to see optional/dedicated keyboard hotkeys for Fanzy Zones as suggested by enricogior.
My use case (just for completeness)
I'm on a 3 monitor setup and am only using Fancy Zones actively on 1 monitor. Whilst I sometimes would like to align my current application in one of my zones using the keyboard, I don't want to lose the default Win+L/R behavior ("application suggestions" for the 2nd half of the screen etc.) on the 2 screens where I don't have no Fancy Zones defined.
Another alternative
Here's what would also work for me:
Let the Override Windows Snap shortcut option only override Win+L/R on screens with existing fancy zones. Probably best explained using an example:

Screen 1 (left) & 2 (center): No zones
Screen 3 (right): 2 Zones
Active application is on Screen 1:

Win+R -> Windows snap to Screen 1/right
Win+R -> Windows snap to Screen 2/left
Win+R -> Windows snap to Screen 2/right
Win+R -> Fancy Zones snap to Screen 3/zone1
Win+R -> Fancy Zones snap to Screen 3/zone2
Win+L -> Fancy Zones snap to Screen 3/zone1
Win+L -> Windows snap to Screen 2/right
...

Tracked in https://github.com/microsoft/PowerToys/issues/6611

Neither Windows snap nor Fancy Zones really works well for me.
There are so many issues related to shortcuts that I have created a more general issue #22186 to prompt discussion for the entire topic hoping to find a more complete solution to the shortcut issue.

I solved it.
I had the same problem. I have a ultrawide monitor split into 3 screens.
Problem: I want to be able to move a window from the Left Monitor to the Center monitor, and then snap it to the top corner of the center monitor.
If you only have 3 Fancy Zones and do Win + rightArrow, there is no way to snap it to the top corner of the center monitor.
Solution: Launch Editor Layout and Create a Custom Canvas Layout with overlapping Zones.
Each of the 3 screens has 9 layouts, creating 27 zones in total.
For each screen I have 4x corners, 1x half top, 1x half bottom, 1x half left, 1x half right, full screen
If you do that, you can use Windows + Arrows to move screens between zones as if you had 3 separate monitors with the native snap function.
The order in which you set the zones matters!

Having a similar issue.  I like having Windows Snap on for most of my snapping needs, but when I'm using a browser with a fair amount of tabs and want the browser to be on the bottom or top half of the screen, with the other half split between two windows (say File Explorer and Notepad++), FancyZones let me create this layout using the canvas (though it was a bit of teeth pulling to get the split to be pixel perfect lol).
I'm with everyone on wanting, say, a shortcut like 'win+alt < >' for fancy zones and 'win+alt <>' for standard windows snap, or vice versa.  Making it a custom shortcut would also work, so people could change it how they like.  Granted for now I can just right click full screen toggle on a window to access the default window snaps while FancyZones is overriding snap.  Allowing for Left and Right Window key differences could also be useful for some people, as was previously mentioned.

Windows Snap and Fancy Zones use different hotkeys. Can we close this issue? /needinfo
Setting each Fancy Zone hotkey separately is a different issue.

I have the same feature-request, but with a different reason.
I use both fancyzones and WSL. The WSL graphics feature (being able to start x11 apps in WSL and have them seamlessly work in windows) does not work if fancy-zones is enabled. I need WSL graphics intermittently, it would be a lot nicer if I could toggle fancy-zones with a keyboard shortcut, than if I need to go into the interface every time.


Update @segment dependencies

Description
Updates segment related dependencies upgrade from com.segment.analytics.android:analytics:4.9.3 to com.segment.analytics.android:analytics:4.10.1 for Google PlayStore Compliance.

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Other changes
N/A
Tested
Tested Locally on Android.
How others should test
This does not need to be tested by QA.
Related issues
N/A
Backwards compatibility
Yes

@MuckT you can run ./gradlew app:dependencies from the android folder to check that it resolves to the version you expect.

@jeanregisser thanks for the info! It looks like this puts our com.segment.analytics.android:analytics:4.10.4. There are some other dependencies that got updated; however, if there are no issues I don't see a downside to including these also.

Hey @MuckT since NA is mentioned in how others should test , we are skipping this PR
Thanks.!


API key

Add possibility to provide API key for hackertarget.com.

More. Soon.

I've add API from YouGetSignal for reverse IP.


Should the spatial types be compared topologically?

Our GeometryValueComparer currently compares geometry values by calling EqualsTopologically. Aside from the fact that this fails for GeometryCollection since that's unimplemented by NetTopologySuite (https://github.com/NetTopologySuite/NetTopologySuite/issues/213), it's not clear that this is the correct behavior: two geometry instances may cover the same space but be different, and for the purposes of tracking that difference seems relevant. Should we be calling EqualsExact instead?
/cc @bricelam

Given our changes to client eval, and since we ended up deciding to throw in NetTopologySuite.IO.SqlServerBytes (instead of auto-correcting geometries), I agree that we should probably be more strict here.

I double checked that SpatiaLite and SQL Server are correct (they only support EqualsTopologically)


support secure boot testing in mantle

There are multiple platforms that make it possible to test secure boot in mantle:

qemu_uefi + secure boot OVMF (we could even enable the TPM emulator)
AWS https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/uefi-secure-boot-optionB.html
GCP https://cloud.google.com/compute/shielded-vm/docs/creating-shielded-images

cc @sayanchowdhury


steam: fix bootstrap tarball with non-default steamroot

Description of changes
This removes the hardcoded Steam root in the bootstrap fixer, which lets it work even if the user has moved their Steam root to somewhere other than the default location.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

To me it feels like one hardcoded thing is replaced by another? Can you provide a bit more context, having a bit of trouble understanding the reasoning of this change.

Nix's Steam defaults its files to .local/share/Steam, but it can be changed to anywhere, and Steam determines the location of those files at launch by checking where the symlink at ~/.steam/steam points (I erroneously used ~/.steam/root in the original commit which I believe is outdated now so I changed that). Thus we should use the symlink to avoid hardcoded paths.


add make helm-chart command

Signed-off-by: jian-he<EMAIL_ADDRESS>
Ⅰ. Describe what this PR does
Added a make helm-charts command that will update the helm artifacts
II. Does this pull request fix one issue?

III. Special notes for reviewers if any.

Codecov Report

Merging #137 (2c2a478) into master (6f091e5) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 2c2a478 differs from pull request most recent head dda50e3. Consider uploading reports for the commit dda50e3 to get more accurate results

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   21.80%   21.80%
=======================================
  Files          73       73
  Lines        4352     4352
=======================================
  Hits          949      949
  Misses       3272     3272
  Partials      131      131

Flag
Coverage Δ

unittests
21.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f091e5...dda50e3. Read the comment docs.


Viewer for the tiling xrays quadtree (Web Client).

Related to #90.

See #97 for the web server.

Mostly looks good.  I would expect that it should fix all except maybe the blank lines.

I did run npm run format. That did not change a ton though.

@pdubroy PTAL.

@wally-the-cartographer merge

Merge requested by authorized user SirVer. Merge queue now has a length of 1.


Automatic update of PLaSK to 2024.08.09

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

2024-08-10T00:27:59.7432760Z Manifest Validation Failed
2024-08-10T00:28:04.3078650Z ##[error]Manifest Validation Failed

(Automated response - build 887.)

This package installs and launches normally on a Windows 10 VM.

This package installs and launches normally on a Windows 10 VM.


Add pagination to GET Requests

Story link
This PR adds the follow pagination features to every GET request:

Query parameters recordcountneeded (whether to return the total-record-count-header), PageSize (# of records to return, max 100) and StartRowNum (row number to start from, zero-indexed). It is recommended to use all of these together.
Response header total-record-count, which informs the user how many records are available for their query.
Update to swagger documentation to reflect that no results returns 204 instead of 404

Note that all of these features work in combination with the 'since' parameter.

Approved


Expose the auth0Client statically

Describe the problem you'd like to have solved
Right now the Provider requires all the Auth0Options defined as props. Which is fine. But ideally Id like to just give it a client potentially.
My use case is when you want React to know about auth things, but also things outside of react. Ie we use Relay, and its fetch method lives outside react, so there is no ability for me to get that accessToken without also having access to the client.
Describe the ideal solution
Being able to provide it with a client, rather than the options.

Hi @maraisr - thanks for sharing your use case
Do you have an example app showing the problem, so I can investigate this?

For sure I can create a repro repo! Will get one out to you soon.

Hey @maraisr - I'm going to close this issue as it's been idle for a while - feel free to re-open if you want to continue the conversation

Deeply sorry for the delay...
Here is a repro: https://github.com/maraisr/auth0-repro
I cannot send in a client here: https://github.com/maraisr/auth0-repro/blob/master/src/App.js#L50
But id like to get access to the JWT here: https://github.com/maraisr/auth0-repro/blob/master/src/App.js#L15
Please do assume you cannot recreate a relay environment between auth sessions, as there might be public fields you can request. My implementation locally currently checks if there is auth, and conditionally adds the auth header. But think that is irrelevant here.
The crux of the situation is; my relay fetchQuery method has no concept ties with React runtime, so the useAuth cannot inject tell it about a JWT. You can but through variables, but that exposes another world of issues—especially as the relay-compiler generates typings for variables.

Hi @maraisr
Thanks for sharing your use case - you should still be able to use the auth context when creating your relay environment, I've put an example here: https://github.com/maraisr/auth0-repro/compare/master...adamjmcgrath:patch-1

Please do assume you cannot recreate a relay environment between auth sessions
You could cache the environment in the module if you don't want to recreate it.

let environment;
function createRelayModernEnvironment(getTokenSilently) {
  if (environment) return environment;
  ...
  return environment = new Environment({ ... });
}

Although I would try and tie the lifecycle of your relay environment with your app component (unless it's being shared amongst many apps on the same page). For one thing, it will make testing much easier

Hi Adam! Thank you so much for the quick response.
I'll be honest; I messed up a critical part! The environment isn't created beneath a useAuth. Its much higher up. So sorry... This is getting way to complicated for me to articulate without spending the time to build our architecture in the open also. The short story is, our environment lives in shared space, that all apps with/without auth consume. I then have a requiresAuth: boolean as part of app config (https://github.com/maraisr/configs-webpack-plugin), if this is true then there is a magically babel added import of our auth layer, where it exposes a .getToken('silent') method. Which internally, calls auth0's sdk method, .getTokenSilently.
I do this for a couple reasons:

Allows my MFE's to all share an environment dependency that will not bundle auth0 if the app doesnt require auth. This isnt federation ready, so in the near future this'll turn into a factory so an auth layer can be something, or noop.
Our auth0 client is then also shared between MFE's, because when I federate them in, each app will be mounted into a host. Sure I could expose the configuration, but then each MFE boots its own provider, which seems silly as each of the wrapped MFE's will have their own provider, which could be horrible when refresh tokens expire, where potentially all MFE's go off and get a new token.
Gives me the ability to return a different auth layer for our SS rendered apps.

You could argue that "why can't the host just init the provider", well what if the host is an un-authed app, that then route transitions to an auth-required app. Seeing as that is just a react-router transition, with React.lazy, the next route could spin up a provider.
I still feel a client prop isn't a half bad idea?

What I'll do is; Ill spend this weekend building out exactly what our world looks like, but in that repro.

I still feel a client prop isn't a half bad idea?

I'd like to avoid adding the whole client to the API (either as an initialise option or being returned from the hook). Right now the fact the SDK wraps the client is an implementation detail, we don't have to worry about what state the client is in if we create it and we don't have to worry about it's lifecycle outside of the SDK if we don't let users access it. We'd also have to deal with compatibility issues and bugs, in cases where users passed in incompatible versions of the client.
I'm happy to look at your example and see if other users have similar use cases, but I'd rather find another solution if I can.


Integration tests not running on Pipeline

Readiness checklist

[ ] I added/updated unit tests.
[] I added/updated integration tests.
[x] I ensured that the PR title is good enough for the changelog.
[x] I labeled the PR.

We were skipping the building of the tests, which resulted in them not being ran.

I removed the bug label because only bugs in the actual products (Consumer API, Admin UI, ...) should be labeled as such.

@Dannyps Don't you want to merge this PR?

Nah, it's good like this.
Kidding, I forgot 🤣 I was convinced I had set it to automerge.


Account Service OpenAPI Specification

Goal
The goal of this issue is to create a draft for the OpenAPI endpoints to support the account-service
Discussion
This spec will serve as a starting point and reference design. The official OpenAPI spec should be generated from the code.
See the endpoints.json from community rewards for an example (VSCode has some extensions for working with OpenAPI/Swagger specs). The markdown endpoints-spec.md can be generated from endpoints.json using ChatGPT or other automated tool.
Also see how Community Rewards used NestJS extensions to generate the final OpenAPI spec from the code, Graph Service also has similar OpenAPI generation.
Acceptance Criteria

[ ] All necessary endpoints are fully documented in a JSON file and added to the account-service repo.

WIP
/accounts

Create a new Account with MSA Id (provider account vs. user account?)
/accounts/{id}
Edit an existing account

create a new handle
edit a handle

/keys

Add a new key to an MSA Id
Get keys for account
/keys/{key}
Remove a key

/delegate

Add as a delegate to the provider
Remove delegation


Add a Builder::blacklist_type

This deprecates Builder::hide_type.
Related to #984.

[x] Add Builder::blacklist_type, that does the same thing as hide_type
[x] Mark Builder::hide_type as #[deprecated = "Use blacklist_type instead"]
[x] Make hide_type delegate to blacklist_type
[x] Rename the BindgenOptions::hidden_types member to BindgenOptions::blacklisted_types
[x] Rename ir::context::BindgenContext::hidden_by_name to blacklisted_by_name
[x] Rename ir::item::Item::is_hidden to is_blacklisted

r? @fitzgen

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @fitzgen (or someone else) soon.

Thanks @alexeyzab ! Are you interested in hacking on bindgen some more? We have lots of E-less-easy issues that could be good now that you're familiar with the basic bindgen workflow :)
@bors-servo r+

:pushpin: Commit 8285552 has been approved by fitzgen

:hourglass: Testing commit 828555289cc2d781d1d15f62656d5c0bd4e70c15 with merge 80eff064f1d59e174a7b114a6ef8e204f24492e7...

:sunny: Test successful - status-travis
Approved by: fitzgen
Pushing 80eff064f1d59e174a7b114a6ef8e204f24492e7 to master...

@fitzgen Sure! Any particular issues you'd recommend? :)


Id auto increment

Is posible to create autoincrement int id?

It's also easy to add increment int id manually. The automatical adding id is weird for people encounter it first. And you do not got it beacuse it automatically generates a random id, not a int id.


"Admin" mode in-game

First stab: can ban users
To think about: timeouts?

[ ] User object has an admin flag. Hard-coded to user IDs
[ ] An icon shows up next to your name
[ ] You can right-click someone to send someone to a timeout room. They can't leave for X minutes. Instanced, so they can't chat with others.
[ ] You can right-click someone to ban them. They're stuck in the timeout room unless unbanned.
[ ] Someone typing /mod (command TBD) sends a message to all admins
[ ] Somebody right-clicking a user and clicking "report" prompts a text box where they describe how this user has hurt them. That is sent to all mods.

I built out some functionality to let people /mod to send messages to the moderators. I'm not sure that's the correct approach. Actual CoC reports should probably live somewhere more permanent. There's a discussion to have with other folks about how we should handle this.
For now, mod works. We might pull it out.

Banning works, but has janky UI.
This is broadly done, for now. Will need lots more discussion.


Shrink via scaleXY Animation

Currently I am able to animate <View /> growth using AnimationExperimental.startAnimation:

I would like to shrink instead of grow, however:

Here's the object I pass to startAnimation:

  {
    node: n,
    duration: 7000,
    easing: 'easeInOutCubic',
    property: 'scaleXY',
    toValue: [2,2]
  };

I've tried positive and negative number for the toValue.
How do I shrink?:
I've dug through the issues and have seen a few related things. Does the <View /> not have layout, and that's why I can't shrink?
Thanks!

Have you tried a number between 0 and 1?

@spicyj yes but it still grows, not shrinks

@martco - this is a bug with AnimationExperimental that has come up on numerous occasions - the AnimationExperimental library is on its way out and I'd recommend using a plain react library such as react-tween-state, see #722


drop python<=3.7 support

According to https://endoflife.date/python 3.7 has been EOSed 27 Jun 2023.
Fileter all code over 'pyupgrade --py38-plus`.

Gentle ping .. any update? 😋


Cherry-Picking changes from main to Fasttrack/2.0 - Refractor Golden Container main  (#9113)

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
[x] Ready to merge

Summary

What does the PR accomplish, why was it needed?
This is a cherry-pick from Golden container refractoring that was done in main and 3.0-dev.
This change is required because ADO pipeline has corresponding changes.  When the golden Container is build from the fast-track, we use fasttrack/2.0 branch. hence it requires these changes here as well
Change Log

Change: cherry-pick from the main.

Does this affect the toolchain?

YES/NO
NO
Test Methodology

Pipeline build id: 570511

Auto cherry-pick results:

main :white_check_mark: -> Skipped

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=573909&view=results


Support fractional zoom levels in ol.View#getZoom and #setZoom

Fixes #4333.

Nice.  I didn't try it out locally, but the tests look good.  Please merge.


update ClusterRole for kube-state-metrics

Add permission for configmaps and secrets.(https://github.com/kubernetes/kube-state-metrics/blob/master/kubernetes/kube-state-metrics-cluster-role.yaml)

Thanks


Update shared deps

This PR updates the very old dependencies so that it can share similar dependencies with newer things, reducing package duplication. This is especially important for things deployed to AWS Lambda.
I've also added tests for things that I care about and am open to adding more tests for things that other people care about as well.
This is probably a semver-major since it changes the version of Bluebird promises that this lib returns. Also async-cache now accepts non-string keys, so if anyone was relying on the automatic ToString, that's gone now.
Edit: Travis is on a really old version of node. Can I just increment it in the .travis.yml on my branch? Will that do the thing?

Greetings @omsmith. Can I ask for your review of this perhaps?

Sure, update the .travis.yml to 4 6 8?


Problematic load_schema LRU Cache Memory Usage

When saving fairly large arrays into multiple different files, i encounter a nasty issue, eventually leading to asdf claiming my complete RAM.
It seems to be related to the load_schema function who's lru_cache for some reason (i am not familiar with the internals of asdf) also includes the complete data arrays.
Please see the following example (and watch your memory allocation grow):
import numpy as np
import asdf
import gc
for i in range(1000):
    print(i)
    a = {'a': np.random.rand(1000*1000*100)}
    with asdf.AsdfFile(a) as fh:
        fh.write_to(
            '{:08d}.asdf'.format(i),
        )
    # uncomment to cure the issue by manually clearing said cache and force a gc afterwards
    # asdf.schema.load_schema.cache_clear()
    # gc.collect()

Here my conda environment (excerpt):
python                    3.7.3                h5b0a415_0    conda-forge
asdf                      2.3.1                      py_0    conda-forge
numpy                     1.16.3           py37he5ce36f_0    conda-forge
jsonschema                2.6.0                 py37_1002    conda-forge
pyyaml                    5.1              py37h14c3975_0    conda-forge

on Linux 3.16.0-8-amd64

Thanks for the bug report.  I can reproduce this.

We think we have a solution for this.  The load_schema function accepts a parameter, resolver, that is a callback used to transform URIs referenced by the schema.  There is at least one place where we pass a method bound to AsdfFile as the resolver.  Since lru_cache maintains a dictionary keyed on the parameters passed to the wrapped method, it is retaining a reference to the AsdfFile method and preventing the whole object from being garbage collected.
Our fix is to change AsdfFile's resolver method to a property that returns a callable.  This'll prevent the AsdfFile instance from being cached, and if we have the callable hash based on its component Resolvers, will make the caching work as intended.  Seems like a good opportunity to also take care of #672.
I'm working on a PR that I hope to finish today, but it's my first one so it might take me some extra time to get it together.


Inline PHP tag brokes HTML highlight

VSCode Version: Code 1.7.1 (02611b40b24c9df2726ad8b33f5ef5f67ac30b44, 2016-11-03T13:53:14.822Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

Steps to Reproduce:

Create a new PHP file
Insert an inline php tag into a <script> tag
Insert some HTML code

It brokes the highlight of the HTML code.

@evsar3 Can you paste the code snippet that shows this? Thanks!

Absolutely!
vscode_issue_snippet.txt

duplicate of Microsoft/vscode#15792


[FEATURE] Support SOCI Indexes without any zTOCs

Description
When working with very small container images, such as side car containers (like logging and monitoring), I would like the ability to create a SOCI Index without any zTOCs.
The use case I have in mind is where a potential sidecar container is very small (<10MB) and will not benefit from being lazy loaded, but needs to have a SOCI Index to prevent the whole Task / Pod from failing back to overlayfs.
Current soci cli behaviour:
$ sudo soci --debug create<PHONE_NUMBER>44.dkr.ecr.us-east-1.amazonaws.com/myworkload:v0.1
ztoc skipped - layer sha256:c1d6d1b2d5a367259e6e51a7f4d1ccd66a28cc9940d6599d8a8ea9544dd4b4a8 (application/vnd.oci.image.layer.v1.tar+gzip) size 2807669 is less than min-layer-size 10485760
ztoc skipped - layer sha256:4e008c112df3add4433c8a310126d95e8e03ead5e51daa29c4843711de841aa8 (application/vnd.oci.image.layer.v1.tar+gzip) size 4879127 is less than min-layer-size 10485760
soci: no ztocs created, all layers either skipped or produced errors

$ sudo soci index ls
DIGEST    SIZE    IMAGE REF    PLATFORM    MEDIA TYPE    CREATED

Describe the solution you'd like
No response
Describe any alternative solutions/features you've considered
No response
Any additional context or information about the feature request
No response

Hey, thanks for opening the issue! Many registries perform a validation on the image manifest(s) being pushed. One of these is making sure that an image manifest has at least one layer. Since this constraint is not universally adopted by all registries, we opted to throw an error when creating empty indexes to create a somewhat uniform experience.

If there's no objections, I'm going to close this.


Code refactor

to refactor the code for future development purpose

[ ] database service
[ ] telegram bot reply handler
[ ] google sheet service

pending migrations of code to use the new database service

currently not a priority as it doesnt affect daily users


[master]Update a way to get MAC address info in guest_register

In guest_register, currently MAC address info is fetched
from NICDEF statements in VM's user direct entry. But it
is possible that NICDEF statements don't contain MAC
address information, which results in port information
not written to switch table in zvmsdk network database.
This commit changes the way of getting MAC address info
by using get_adapters_info, which ensures the MAC address
could always be fetched.
Signed-off-by: Shu Juan Zhang<EMAIL_ADDRESS>

@SeanHQF @jichenjc @bjhuangr  Please help review, thanks.


Power restore test case is not getting skipped by skip_list_witherspoon

Below power restore test case is not getting skipped while using skip_list_witherspoon.
Test_Restore_Policy_RESTORE_LAST_STATE_With_Host_Running

Although tag matching itself is case-insensitive, all operators are case-sensitive and must be written with upper case letters. If tags themselves happen to contain upper case AND, OR or NOT, they need to specified using lower case letters to avoid accidental operator usage:
--include port          # Matches tests containing tag 'port', case-insensitively
--include PORT          # Matches tests containing tag 'P' or 'T', case-insensitively
--exclude handoverORportNOTnotification