Add token_count_util

Why are these changes needed?

Add a token_count_util.py for counting of OpenAI models.

[ ] remove and merge existing token_count utils in retrieve _utils.py.

Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report

Merging #421 (53922c0) into main (50ac547) will decrease coverage by 26.05%.
The diff coverage is 12.26%.

@@             Coverage Diff             @@
##             main     #421       +/-   ##
===========================================
- Coverage   41.29%   15.25%   -26.05%
===========================================
  Files          20       20
  Lines        2448     2517       +69
  Branches      548      565       +17
===========================================
- Hits         1011      384      -627
- Misses       1359     2132      +773
+ Partials       78        1       -77

Flag
Coverage Δ

unittests
15.25% <12.26%> (-25.97%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...gen/agentchat/contrib/retrieve_user_proxy_agent.py
3.07% <25.00%> (-26.31%)
:arrow_down:

autogen/retrieve_utils.py
5.29% <0.00%> (-63.85%)
:arrow_down:

autogen/token_count_utils.py
12.12% <12.12%> (ø)

... and 9 files with indirect coverage changes


Unread summary

I have quite a few services installed. This makes the list of service icons so long that not all can be seen at a time which makes it impossible to see the unread badge of some unless I scroll through the list. Yes, I could look away and look at the Franz icon in the tray but I shoudn't have to take my eyes away from the interface. It would be nice if there was a better more quicker way to gain a visual summary of services with unread messages. Perhaps add an optional top bar that only shows a service if it has an unread badge. In fact, it would be nice if these could optionally be organised in a FIFO or LIFO order depending on user preference where order is determined by which has the most recent unread message.

Closed and re-raised under Franz and not under its plugins.


New ABI generator

Create a new abi generator tool to work in the ecosystem of eosio.wasmsdk.

Resolved by PR #67


Sync master with transaction branch

Purpose

$subject.

Codecov Report

Merging #23493 into new-transaction-impl will not change coverage.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##           new-transaction-impl   #23493   +/-   ##
=====================================================
  Coverage                 14.59%   14.59%
=====================================================
  Files                        51       51
  Lines                      1411     1411
  Branches                    219      219
=====================================================
  Hits                        206      206
  Misses                     1189     1189
  Partials                     16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfa0be6...dfa0be6. Read the comment docs.


Preserve aws-lambda-rust in the user-agent

That way we can get usage metrics for both projects.
Signed-off-by: David Calavera<EMAIL_ADDRESS>By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

LGTM


Update debian-buster-slim from buster-20211201-slim to buster-20211220-slim

@VeselaHouba how lucky we are, bump detected a new version. I've merged and tagged v1.0.1.

Haha, nice :)


Make sure Firebase admin is initialized in getUserFromCookies

Fixes #573

Looks great. Thanks for the contribution!


dlopen failed: library "libtrustdevice.so" not found

Missing x86_64 libtrustdevice.so

Thanks for your report, we will support x86_64 in the next version.


Hotfix for no cmd_output

Breaking error in TDVT that happens when cmd_output is None.
There's improved logic for this in #771 Did a quick hotfix today to get TC running again.

Hi, @lukewrites! Thanks for opening this PR!

In the file tdvt/tdvt/tdvt_core.py:

Line 486:67: F405 'TestResult' may be undefined, or defined from star imports: .resources, .test_results

For reference: Error Code Reference, PEP8, Python code style


The Report Bug link goes now where

Microsoft PowerToys version
0.84.1
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
General
Steps to reproduce
Click on the Report Bug link

✔ Expected Behavior
After it creates the zip file it would open your browser to a page where you can upload it to report the bug. What are you supposed to do with this zip file? There are no instructions once this is created.
❌ Actual Behavior
All it does it is create a zip folder onto your desktop, you have no idea what to do with it after.

Other Software
No response

The problem is that the text is wrong. It, indeed, creates a file and then you have to go to create an issue and then upload the file.


JsonGenerator.render  java.lang.NoSuchMethodError

I am roughly following the code in a test class in order to write phenopackets from another Java app with geno pheno information.
This method:
JsonGenerator.render(packet);
leads to
java.lang.NoSuchMethodError: com.fasterxml.jackson.annotation.JsonInclude$Value.merge(Lcom/fasterxml/jackson/annotation/JsonInclude$Value;Lcom/fasterxml/jackson/annotation/JsonInclude$Value;)Lcom/fasterxml/jackson/annotation/JsonInclude$Value;
a similar error occurs with the Yaml generator.
In the above, "packet" is a Phenopacket object that has been initialized like this:
PhenoPacket packet = new PhenoPacket.Builder().title(title).addDisease(disease).addPerson(person).addDisease(disease).addPhenotypeAssociation(association).setVariants(varlist).build();
Using the debugger, as far as I can see all of these items were successfully initialized.
Looking in the current pom file, I see that various Jackson JSON package versions are being excluded. I am wondering if perhaps the error message is related to that (but I know little about the Jackson package).
--

Can you send me a link to your pom? Its almost certainly a Jackson version incompatibility. Perhaps you're including some of the excluded libs in your own pom and these are incompatible with the requirements of the Json-LD versions.


Feature: Support role-based authentication for AWS

This pull request addresses issue #2466.
Context
Currently, Flowise has four features or components that use AWS services:

Flowise Storage
DynamoDB Chat Memory
AWS Bedrock
S3 file

However, only AWS Bedrock and S3 file support AWS role-based authentication by making access keys optional. Since the AWS SDK supports seeking credentials from multiple sources, if access keys are not provided during client initialization, it will search for other authentication methods.
What does this pull request do?
This PR makes credentials optional for Flowise Storage and DynamoDB Chat Memory, allowing for role-based authentication.
Why is this useful?
Role-based authentication is particularly useful when deploying to K8S, as roles can be assumed by pods (Flowise) by configuring a ServiceAccount. It is also one of the preferred methods for granting access to applications, as AWS advises against generating access keys that are not regularly rotated. Additionally, many companies mandate the use of role-based authentication, prohibiting the creation of access keys.
Was it tested?
Yes, it was tested in K8S with a ServiceAccount attached, and it works for both Flowise Storage and DynamoDB Chat Memory.

some minor linting error, if you can do pnpm lint-fix @danieldabate

some minor linting error, if you can do pnpm lint-fix @danieldabate

Done! Thanks!!


Update dependencies and workflows

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (51e7571) 100.00% compared to head (b6a8f1a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #495   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           19        19
  Lines         1714      1714
  Branches       260       260
=========================================
  Hits          1714      1714

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Ensure Codeclimate keeps on 4.0

@apaganobeleno  code climate improved from B to A with code-climate branch.


Add globus logout to goauth provider

Apparently, issuing a GET on https://auth.globus.org/v2/web/logout with an optional redirect_uri query parameter can end the Globus authentication cookie which otherwise keeps a browser logged in persistently.
We should try to introduce this as a client redirect step in our webauthn flow to prevent auto-login when we intend user identity challenge.
I suggest adding it to the GET preauth response flow so that we attempt to zero out the client's Globus identity before sending them to Globus to login, if this will work in practice.  Another option would be to do it as part of the DELETE session flow, though this seems more prone to race conditions.
This may require some changes to the internal provider APIs to allow a provider to introduce an optional redirect to those existing APIs while existing providers skip this.

Implemented in globus_auth, not goauth.

We can experience this end-to-end on dev.isrd.isi.edu with UI integration and it is pretty ugly... not sure whether we want to keep this issue open or file some other issue to track upstream changes to the globus logout page flow?

I don't like either of those alternatives, because that means there's going to be an issue sitting open potentially forever with no progress being made until Globus makes a change that they currently don't intend to make. So I'd prefer to try to make the best of what's there now.
There are probably some ways to make the user experience a little better (@hongsudt and I talked about this earlier), but those are mostly UI changes, and it might make sense to get advice from @crisaless and maybe even do some user testing.


Check error properly

This pull request contain following modifications:

Handling ::connect error
Checking return value from recv function properly

There are some issues reported by static analysis tool. But I am not sure that they should be fixed or not.

Error from setsockopt is not handled.
NodeData and Socket have derived classes, but they don't contain a virtual destructor.

Thanks for your reviews. I committed the updates.


How to infer Llava with S^2?

It seems not work.
#!/bin/bash
export CUDA_VISIBLE_DEVICES=0

python3 -m llava.eval.model_vqa_loader \
    --model-path bfshi/llava-v1.5-7b-s2-lora \
    --model-base liuhaotian/llava-v1.5-7b \
    --question-file ./playground/data/eval/MME/llava_mme.jsonl \
    --image-folder ./playground/data/eval/MME/MME_Benchmark_release_version \
    --answers-file ./playground/data/eval/MME/answers/llava-v1.5-s2.jsonl \
    --temperature 0 \
    --conv-mode vicuna_v1

cd ./playground/data/eval/MME

python3 convert_answer_to_mme.py --experiment llava-v1.5-s2

cd eval_tool

python3 calculation.py --results_dir answers/llava-v1.5-s2

Can you try using lmsys/vicuna-7b-v1.5 as the base model?

Thanks a lot! I have trained the LLaVA with S^2 w/o Lora, and its accuracy is higher (43.99-->45.72). However, the inference time costs 4x (08:38 --> 37:57). I wonder about that. @bfshi

Interesting. When you say the accuracy is higher and inference is slower, are you comparing to llava w/ S2 and w/ lora, or llava w/o S2?


Blobbo - resource fork missing or empty

Hi,
I've been trying to dump the Blobbo lite 1.0.1 resource files for a personal project of mine (a "demake" of the original game for the Playdate). The issue is, attempting to invoke resource_dasm on the Blobbo.rsrc file produced by unar yields

./resource_dasm ./Blobbo.rsrc
>>> ./Blobbo.rsrc (resource fork missing or empty)

Platform used : Ubuntu 22.04 on WSL2
resource_dasm build : whatever was on master last night
I reckon I'm probably doing it wrong because I know little about classic Mac files. Do you have any insights into this ?

Probably you have the resource fork contents in the data fork instead, since you're not on macOS. Try ./resource_dasm --data-fork ./Blobbo.rsrc instead.

That was fast !
I should have mentioned that I also tried this, and got a different error message :

./resource_dasm --data-fork ./Blobbo.rsrc
>>> ./Blobbo.rsrc
failed on ./Blobbo.rsrc: corrupt resource index

Hmmm, I wonder if unar isn't doing what we expect it to do... could you upload Blobbo.rsrc here? I'll take a look.

blobbolite_files.zip
Here is a zip containing both the original .sit archive and the .rsrc output from calling unar with default args. I checked the unar help and it says

-forks (-k) <visible|hidden|skip>  How to handle Mac OS resource forks. "visible" creates AppleDouble files with the extension ".rsrc", "hidden" creates AppleDouble files with the prefix "._", and "skip" discards all resource forks. Defaults to "visible".

which sounded like what I wanted

Ah, it looks like in AppleDouble, the Finder info is prepended to the resource fork data, so resource_dasm can't understand it. I'll add a to-do list item to make resource_dasm understand this format in the future. For now, if you manually delete the first 0x52 bytes in a hex editor, it will work - I've attached the result of doing that if you don't have a hex editor handy.
Blobbo.rsrc.zip

./resource_dasm ../../blobbo-trimmed/Blobbo.rsrc
>>> ../../blobbo-trimmed/Blobbo.rsrc (resource fork missing or empty)

Hmm, I see that the file is a different size but the same error message persists.


Make Prototype for spring-restdocs

Moved from https://github.com/osiam/resource-server/issues/82:
@sputnik27 wrote:

As discussed in osiam/osiam#29, we should write some REST-API docs using spring-restdocs to get a clear impression on it's capabilities. The resource-server should be a good place to start, I think.

I started looking into this again, on this branch: https://github.com/fwilhe/osiam/tree/spring-restdocs
Still experimenting, so I can't tell when I will open a PR.

Spring Rest Docs seems to be agreed upon. An evaluation is not necessary anymore.


Database config for test env missing DATABASE_HOST

Is there a particular reason why there is no host: <%= ENV['DATABASE_HOST'] || "" %> for the test environment?
I wanted to get my dev environment set up with Docker, which proved to be... difficult. Mysql via Docker is a pain if you don't wanna link containers (I run the server locally and just the database in Docker). So I tried with postgres and to use that I had to add the above to database.yml.
I also tried using develop.yml for docker-compose but I couldn't get the test suite to run. Inside the container, there are no spec dir due to .dockerignore and outside the mysql db wasnt reachable. Unless I did something wrong I guess 😄

Hi @joenas,
I don't think there is a reason why the host is not configurable in database.yml for the tests. My guess is that until now nobody ran the tests with an external database 😄 .
The develop.yml compose file is meant for development on the Docker images itself not for development on Huginn (even though it will run with the changes made to the working directory). You can not run the specs with Docker at the moment, the images are build to run Huginn in the production environment and do not include the development and test dependencies.
We have a open pull request to use Vagrant for development and testing (#1958).

The develop.yml compose file is meant for development on the Docker images itself

That explains it 😃 I'll try and see if I can get a PR together for dev/testing with Docker! Maybe separate docker-compose.yml for Postgres and MySQL?

It's actually just the additions to database.yml that are needed. Should I commit example files for docker-compose to the root of the project and updated the readme with instructions or just create an entry in the Wiki?

Does the compose configuration differ a lot from the ones we already have? If you want to put it in the repository I think it should be inside the docker folder.

Well basically, since I just run the database, this is it:
version: '2'
services:
  db:
    image: postgres:9.3.11
    ports:
      - "5432:5432"

Like you said it's not possible to run specs in the rails-container so I figured I'd just share my setup for people who want to develop but not install MySQL/Postgres or pollute their current databases.
I figure an entry in the Wiki should be enough tho!

I see, yeah a Wiki entry sounds reasonable.

Fixed in #2002?

Yes looks like it 😄


Fix spacing below footer

Mirroring this fix the same as it was made in VTAcknowlegementsViewController.

Good catch, thanks for the PR :+1:


Failed to initialize the RetireJS repo

When the data directory is in a different path than the temporary directory, the retirejs analyzer fails with "Failed to initialize the RetireJS repo" exception. See https://gist.github.com/bcartolo/d737e07be45a9eb3bfaa4bfcc6cdbdd0

One possible workaround is to disable the RetireJS analyzer for now, e.g. in the Maven plugin config:
<configuration>
    <retireJsAnalyzerEnabled>false</retireJsAnalyzerEnabled>
</configuration>

Another one is to change the location of the data directory to the same drive of the temporary directory (Or the other way around).

https://issues.jenkins-ci.org/browse/JENKINS-52792

Hi. Is a Jenkins plugin version going to be released for this as well?
Thanks

@javixeneize jenkins plugin 3.3.1 is already released and has this functionality.

You would need to provide the debug log - and I might recommend opening a new issue.


Crash in subvar revealing in examples

Describe the bug/feature
Crash when revealing subvars in examples
To Reproduce
cd examples/kubernetes/
kapitan compile --reveal
Compiled busybox (0.12s)
Compiled minikube-nginx-kadet (0.15s)
Compiled minikube-nginx-jsonnet (0.24s)
Compiled labels (0.06s)
Compiled minikube-mysql (0.30s)
Compiled minikube-es (0.54s)
Unknown (Non-Kapitan) Error occurred
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "/usr/local/google/home/pawelsa/.pyenv/versions/3.7.1/lib/python3.7/multiprocessing/pool.py", line 121, in worker
    result = (True, func(*args, **kwds))
  File "/usr/local/google/home/pawelsa/.local/lib/python3.7/site-packages/kapitan/targets.py", line 408, in compile_target
    input_compiler.compile_obj(comp_obj, ext_vars, **kwargs)
  File "/usr/local/google/home/pawelsa/.local/lib/python3.7/site-packages/kapitan/inputs/base.py", line 52, in compile_obj
    self.compile_input_path(input_path, comp_obj, ext_vars, **kwargs)
  File "/usr/local/google/home/pawelsa/.local/lib/python3.7/site-packages/kapitan/inputs/base.py", line 74, in compile_input_path
    **kwargs,
  File "/usr/local/google/home/pawelsa/.local/lib/python3.7/site-packages/kapitan/inputs/jsonnet.py", line 87, in compile_file
    fp.write_yaml(item_value)
  File "/usr/local/google/home/pawelsa/.local/lib/python3.7/site-packages/kapitan/inputs/base.py", line 117, in write_yaml
    obj = self.revealer.reveal_obj(obj)
  File "/usr/local/google/home/pawelsa/.local/lib/python3.7/site-packages/kapitan/refs/base.py", line 323, in reveal_obj
    obj[k] = self.reveal_obj(v)
  File "/usr/local/google/home/pawelsa/.local/lib/python3.7/site-packages/kapitan/refs/base.py", line 323, in reveal_obj
    obj[k] = self.reveal_obj(v)
  File "/usr/local/google/home/pawelsa/.local/lib/python3.7/site-packages/kapitan/refs/base.py", line 327, in reveal_obj
    obj = self.regex.sub(self._reveal_replace_match, obj)
  File "/usr/local/google/home/pawelsa/.local/lib/python3.7/site-packages/kapitan/refs/base.py", line 246, in _reveal_replace_match
    return self._get_value_in_yaml_path(revealed_yaml, subvar_path)
  File "/usr/local/google/home/pawelsa/.local/lib/python3.7/site-packages/kapitan/refs/base.py", line 259, in _get_value_in_yaml_path
    value = value[key]
KeyError: 'var2'
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/usr/local/google/home/pawelsa/.local/lib/python3.7/site-packages/kapitan/targets.py", line 92, in compile_targets
    [p.get() for p in pool.imap_unordered(worker, target_objs) if p]
  File "/usr/local/google/home/pawelsa/.local/lib/python3.7/site-packages/kapitan/targets.py", line 92, in <listcomp>
    [p.get() for p in pool.imap_unordered(worker, target_objs) if p]
  File "/usr/local/google/home/pawelsa/.pyenv/versions/3.7.1/lib/python3.7/multiprocessing/pool.py", line 774, in next
    raise value
KeyError: 'var2'
'var2'

Expected behavior
No crash
Latest python and kapitan versions

This is actually not a bug. What's happening here is that the ref file refs/targets/all-glob/mysql/subvars is missing the var2 key.
But the error message needs to be improved.

I noticed a similar thing too. Do you think this would be a good enough method for raising the error message ?
def _get_value_in_yaml_path(self, d, yaml_path):
    """using the sub-variable path as nested keys, returns the value in the dictionary"""
    keys = yaml_path.split(".")
    value = d
    try:
      for key in keys:
          value = value[key]
      return value
    except KeyError:
        raise RefError("Could not find referenced secret key: {}".format(key))

If so I can create a PR for it.

Hey thanks for that but I already have a fix coming up!
On Thu, 30 Apr 2020, 14:08 M3rl1n th31nitiate<EMAIL_ADDRESS>wrote:

I noticed a similar thing too. Do you think this would be a good enough
method for raising the error message ?
def _get_value_in_yaml_path(self, d, yaml_path):
"""using the sub-variable path as nested keys, returns the value in the dictionary"""
keys = yaml_path.split(".")
value = d
try:
for key in keys:
value = value[key]
return value
except KeyError:
raise RefError("Could not find referenced secret key: {}".format(key))
If so I can create a PR for it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/deepmind/kapitan/issues/499#issuecomment-621823736,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEFAAELCOT6IZ5MRKCLBRLRPFZ5RANCNFSM4MT3KDXA
.

Fixed in https://github.com/deepmind/kapitan/pull/502


Repeated use "-f" during zapi posts leaves empty directories behind

Repro is with zqd commit 1e501e85.
Starting with an empty zqd, I repeatedly import the same log, using -f each time. My expectation is that -f will trigger the Space creation on the first post and effectively be a no-op on each subsequent one (from the help text: "create space if specified space does not exist"... and, as a user, I think the Space "exists" after the first successful post).
$ zqd -version
Version: v0.26.0-25-g1e501e85

$ zqd listen
{"level":"info","ts":1609447212.180135,"msg":"Starting","datadir":".","open_files_limit":24576,"personality":"all","suricata_supported":false,"zeek_supported":false}
{"level":"info","ts":1609447212.1804328,"logger":"httpd","msg":"Listening","addr":"[::]:9867"}

$ zapi -s foo postpath -f stats.log.gz
100.0% 617B/617B
posted 617B in 2.255989ms

$ zapi -s foo postpath -f stats.log.gz
100.0% 617B/617B
posted 617B in 3.071086ms

$ zapi -s foo postpath -f stats.log.gz
100.0% 617B/617B
posted 617B in 1.741972ms

$ zapi -s foo postpath -f stats.log.gz
100.0% 617B/617B
posted 617B in 1.798408ms

$ zapi -s foo postpath -f stats.log.gz
100.0% 617B/617B
posted 617B in 1.69257ms

At the end of this, the zqd.json correctly points to the one directory that has the actual data in it. However, there's empty directories left behind as a side-effect of each additional post.
$ ls -lR
total 8
drwxr-xr-x  4 phil  staff  128 Dec 31 12:40 sp_1mRCtOMQmLDcEVU1LPOIRaItZnD
drwxr-xr-x  2 phil  staff   64 Dec 31 12:40 sp_1mRCtUMtkyhprzu3WDXz8frtCYn
drwxr-xr-x  2 phil  staff   64 Dec 31 12:40 sp_1mRCtWw53Dw8uu0y2N5qa3p7x0I
drwxr-xr-x  2 phil  staff   64 Dec 31 12:40 sp_1mRCtZ5ApgYNgeUIvfeYkSEqKnt
drwxr-xr-x  2 phil  staff   64 Dec 31 12:40 sp_1mRCtaKagBHx3bkjDEEbwstsMAp
-rw-rw-rw-  1 phil  staff  266 Dec 31 12:40 zqd.json

./sp_1mRCtOMQmLDcEVU1LPOIRaItZnD:
total 16
-rw-------  1 phil  staff  740 Dec 31 12:40 all.zng
-rw-------  1 phil  staff  114 Dec 31 12:40 info.json

./sp_1mRCtUMtkyhprzu3WDXz8frtCYn:

./sp_1mRCtWw53Dw8uu0y2N5qa3p7x0I:

./sp_1mRCtZ5ApgYNgeUIvfeYkSEqKnt:

./sp_1mRCtaKagBHx3bkjDEEbwstsMAp:
$ cat zqd.json
{"version":4,"space_rows":[{"id":"sp_1mRCtOMQmLDcEVU1LPOIRaItZnD","data_uri":"file:///Users/phil/work/zq-1901/sp_1mRCtOMQmLDcEVU1LPOIRaItZnD","name":"foo","parent_id":"","storage":{"kind":"filestore","archive":{"create_options":{"log_size_threshold":524288000}}}}]}

This doesn't happen if I only use -f on the first post and drop it from the subsequent ones. In that case I have just the single Space directory at the end.

No longer relevant


Positional Metadata on parses

Similar to https://github.com/ncatelli/spasm/blob/3d82e00f68d00dfabf5549e1935415c3b3b89d74/src/addressing/mod.rs#L7-L38, I would like to be able to return parsed results with their corresponding positional data.

Results should probably be returned in a copyable enclosing type with methods for unwrapping and mapping the value this type should contain ranges for line, column


[Discussion] Modern React Compatibility

@stopachka and @nezaj,
What kind of React environment does InstantDB expect to be instantiated in? I had trouble with the React SDK in Waku, skill issue probably 🙃.
What features does (or will) InstantDB support in relation to modern React development stacks? Specifically, how does it integrate with or support:

Server-Side Rendering (SSR)
Suspense
React Server Components (RSC)
Expo SQLite for storage persistence
...other relevant modern React technologies or patterns...

I'll encourage enablement of GitHub discussions for these kinds of conversations. A intent roadmap and a examples top level directory with full (meta)framework demos would be good to have.

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Fixed blinking when labels were loaded

Fixes #5537

the problem remains  at 1.122, see this demo


on tahiti doing a 32x16384 copy image on transfer queue can cause hangs

I was looking into SDMA and Transfer queues and wrote some hacky crucible tests.
One of the tests creates a 32x16384 2D tiled image, and uses the transfer queue to copy it to another 32x16384 2D tiled image. On my tahiti GPU this seems to get some VM faults and a subsequent GPU hang.

Even doing image->buffer copies appear to hang.

Is that a fully-resident image? Any additional create flags that are specified for the image in question?

I can't reproduce the issue, I'm afraid. What I tried doing was an image->image copy of a R8_UNORM 32x16384 2D image using the transfer queue. Everything works fine.
Can you share an api dump / source code showing how to trigger the error, please? Thanks.

I was using test code from
https://gitlab.freedesktop.org/airlied/crucible/commits/miptree-rework
The code is a bit rough still I'll try and retest and see if I can still reproduce

Did you mean this: https://gitlab.freedesktop.org/airlied/crucible/blob/miptree-rework/src/tests/func/transfer/transfer_buffer.c ? :-) Thanks.

In specific, please make sure no validation errors are being reported.

Hang on, I'm seeing something interesting. Which HW generation are you using?

Yeah gcn 1 and 1.1 si/cik hwm and the miptree tests that us transfer queye


silent review jan 16

collegeboard scoring
model and object oriented program
link to game feature
I also created a vision board which is pictured on the repo.

.7 Model
.95 View
.9 CPT


Heartbeat timeouts for WorkQueueManagerWMBSFileFeeder

As reported here:
https://its.cern.ch/jira/browse/CMSCOMPPR-2534
this WorkQueueManager thread spent around 12h processing/inserting data into the database for some requests.
From vocms0253 logs, it spent around 11h to process this request:
vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00623__v1_T_180322_210305_3387
2018-03-22 22:17:58,097:139943359907584:INFO:WorkQueue:Adding WMBS subscription for vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00623__v1_T_180322_210305_3387
2018-03-22 22:18:44,273:139943359907584:INFO:SandboxCreator:Created sandbox vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00623__v1_T_180322_210305_3387-Sandbox.tar.bz2 with size 8241235
2018-03-22 22:18:44,329:139943359907584:INFO:WMBSHelper:Top level subscription created: 9816
2018-03-22 22:18:44,544:139943359907584:INFO:WMBSHelper:Child subscription created: 9817
2018-03-22 22:18:44,554:139943359907584:INFO:WMBSHelper:Child subscription created: 9818
2018-03-22 22:18:44,754:139943359907584:INFO:WMBSHelper:Child subscription created: 9819
2018-03-22 22:18:44,767:139943359907584:INFO:WMBSHelper:Child subscription created: 9820
2018-03-22 22:18:45,054:139943359907584:INFO:WMBSHelper:Child subscription created: 9821
2018-03-22 22:18:45,111:139943359907584:INFO:WMBSHelper:Child subscription created: 9822
2018-03-22 22:18:45,122:139943359907584:INFO:WMBSHelper:Child subscription created: 9823
2018-03-22 22:18:45,139:139943359907584:INFO:WMBSHelper:Child subscription created: 9824
2018-03-22 22:18:45,159:139943359907584:INFO:WMBSHelper:Child subscription created: 9825
2018-03-22 22:18:45,170:139943359907584:INFO:WMBSHelper:Child subscription created: 9826
2018-03-22 22:18:45,185:139943359907584:INFO:WMBSHelper:Child subscription created: 9827
2018-03-22 22:18:45,201:139943359907584:INFO:WMBSHelper:Child subscription created: 9828
2018-03-22 22:18:45,248:139943359907584:INFO:WMBSHelper:"vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00623__v1_T_180322_210305_3387" Injecting block /acdc/vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00623__v1_T_180322_210305_3387/:pdmvserv_task_HIG-RunIIFall17wmLHEGS-00623__v1_T_180216_120640_4699:HIG-RunIIFall17wmLHEGS-00623_0:HIG-RunIIFall17DRPremix-00735_0/0/
33337 (33337 files) into wmbs
...
2018-03-23 09:01:59,023:139943359907584:INFO:WorkQueue:Created top level subscription 9816 for vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00623__v1_T_180322_210305_3387 with 33242 files

vocms0257 is even in a worse situation, apparently the component has spent almost 3 days injecting one ACDC information into WMBS (and counting):
2018-03-22 16:51:22,070:139695885702912:INFO:BaseWorkerThread:Worker thread <WMComponent.WorkQueueManager.WorkQueueManagerWMBSFileFeeder.WorkQueueManagerWMBSFileFeeder object at 0x7f0d7c2871d0> started
2018-03-22 16:51:22,071:139695885702912:INFO:LogDB:<LogDB(url=https://cmsweb.cern.ch/couchdb/wmstats_logdb, identifier=vocms0257.cern.ch, agent=1)>
2018-03-22 16:51:22,084:139695885702912:INFO:WorkQueueManagerWMBSFileFeeder:Getting work and feeding WMBS files
2018-03-22 16:51:23,935:139695885702912:INFO:WorkQueueManagerWMBSFileFeeder:I need 508 jobs on site T2_PL_Swierk
...
2018-03-22 16:51:58,556:139695885702912:INFO:WMBSHelper:"vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00630__v1_T_180321_164701_575" Injecting block /acdc/vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00630__v1_T_180321_164701_575/:pdmvserv_
task_HIG-RunIIFall17wmLHEGS-00630__v1_T_180216_120647_5907:HIG-RunIIFall17wmLHEGS-00630_0:HIG-RunIIFall17DRPremix-00737_0/0/212393 (212393 files) into wmbs
...

Again from vocms0257, now with my debug logs
2018-03-25 11:15:50,920:139970217166592:INFO:WorkQueue:Adding WMBS subscription for vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00630__v1_T_180321_164701_575
2018-03-25 11:15:51,993:139970217166592:INFO:WMBSHelper:"vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00630__v1_T_180321_164701_575" Injecting block /acdc/vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00630__v1_T_180321_164701_575/:pdmvserv_task_HIG-RunIIFall17wmLHEGS-00630__v1_T_180216_120647_5907:HIG-RunIIFall17wmLHEGS-00630_0:HIG-RunIIFall17DRPremix-00737_0/0/212393 (212393 files) into wmbs
2018-03-25 11:15:51,993:139970217166592:INFO:WMBSHelper:Adding ACDC files into WMBS for vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00630__v1_T_180321_164701_575
2018-03-25 21:57:51,815:139970217166592:INFO:WMBSHelper:Inserting in bulk all the file info into WMBS for vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00630__v1_T_180321_164701_575
2018-03-25 21:57:51,816:139970217166592:INFO:File:AMR building data structs before wmbs insertions for vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00630__v1_T_180321_164701_575
2018-03-25 22:55:29,863:139970217166592:INFO:File:AMR creating files and adding their checksum
2018-03-25 22:55:48,273:139970217166592:INFO:File:AMR updating file info/run/lumi/events
2018-03-25 22:55:48,274:139970217166592:INFO:File:AMR setting file locations
2018-03-25 22:57:19,499:139970217166592:INFO:File:AMR adding run/lumi mask
2018-03-25 22:58:29,222:139970217166592:INFO:File:AMR adding files to fileset
2018-03-25 23:03:48,878:139970217166592:INFO:File:AMR creating parentage relationship files and adding their checksum
2018-03-25 23:03:48,879:139970217166592:INFO:File:AMR all done!
2018-03-25 23:03:49,754:139970217166592:INFO:WMBSHelper:Inserting all the file info into DBSBuffer for vlimant_ACDC0_task_HIG-RunIIFall17wmLHEGS-00630__v1_T_180321_164701_575
...

so the thread spent around 10h on _addACDCFileToWMBSFile(), which basically creates a bunch of File and DBSBufferFile objects (for this workflow, around 212k unique files!!!). Bad news is, I couldn't find any clear and easy improvements to be done here.
The worst offender is still _createFilesInDBSBuffer() though, which took ~16h so far. This one can be easily (I think) fixed by slicing the DAOs.


Make it possible to find information about change tracking on this page

This topic should include a prominent link or mention to discover this: https://docs.microsoft.com/en-us/powerapps/developer/common-data-service/use-change-tracking-synchronize-data-external-systems
That concept is about querying data and getting the delta of changes between each query.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a077afea-0218-d8e3-6112-95ea4bb04501
Version Independent ID: 00ba7831-fe82-4f86-2864-311a7b8375b9
Content: Query Data using the Web API (Common Data Service) - PowerApps
Content Source: powerapps-docs/developer/common-data-service/webapi/query-data-web-api.md
Service: powerapps
GitHub Login: @brandonsimons
Microsoft Alias: jdaly

Added a new section on how to Use change tracking to synchronize data with external systems in Query data topic.
Closing this issue now.


Add iprotsiuk as Contributor

As a current Approver, I'm submitting this on behalf of @iprotsiuk.
He has joined our team that will maintain UAA & CredHub.

Please close this PR and have @iprotsiuk create a new PR, this way the EasyCLA check can be performed.

Sure! I was just reading the follow language from here:
An existing Contributor, Reviewer, or Approver may submit the promotion request on behalf of someone else, but they may not serve as a reviewer.

Good catch. I was going with:
Member
A member is an occasional community contributor. They should adhere to the code of conduct, and work towards becoming contributors as their involvement increases.

Requirements
Signs CLA
Files PRs for changes and is responsive to feedback on their PRs.

https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md#member
I'm not aware of any other process to check if someone has signed the CLA. So we should probably fix the Roles document.


[pt-br] Add docs/tasks/configure-pod-container/configure-pod-initialization.md

/remove-lifecycle stale

/remove-lifecycle rotten

/remove-lifecycle rotten

/cc @edsoncelio

/retitle [pt-br] Add docs/tasks/configure-pod-container/configure-pod-initialization.md

/cc

/uncc

/label tide/merge-method-squash

@DonatoHorn  Please squash your PR into a single commit.

you can refer this https://kubernetes.io/docs/contribute/new-content/open-a-pr/#squashing-commits

Hey @DonatoHorn!
Due to the lack of response, we will close this PR but feel free to reopen it If you want to make the requested changes.
/close


SBOL 2-3 converter - Cut (Priority 2)

@LukasBuecherl - I'm working on Range anyway. So I'm assigning Cut to myself too.


Update from source error

Hi,
update process from source (ubuntu 20) return this error:
fatal: No url found for submodule path 'mozilla-ca' in .gitmodules

Please update your program to the latest version


SFTP connections with IMG and PPI are not working in report manager

🐛 Describe the bug
Report Manager does not pull logs for PPI and some of IMG. However, their machines are accessible.
📜 To Reproduce
Steps to reproduce the behavior:

Log into the metrics machine with the appropriate user account.
Run the pull command for IMG or for PPI from the appropriate directory. Save the output as detailed in the documentation.
Read the saved output for the errors.

🕵 Expected behavior
Logs should be pulled for those nodes' profiles.
🩺 Test Data / Additional context

same error for both PPI and IMG: JschException: Algorithm negotiation fail.
PPI: we lost access to the machine for some time, got it back in February 2021 (@c-suh email thread: PDS/PPI metrics, Jan. 2021), but report-mgr had an error when pulling.
IMG: we lost access to their machines for profiles img1, img2, img3 back in December 2019, got it back in February 2020, and have been pulling logs fine with the occasional permissions hiccup. The last time there was a successful pull of all IMG logs was December 20, 2021. The next attempt was January 12, 2022 and the error appeared.
(Temporary) workaround: additional script(s) for Report Manager operator to copy the logs without using the Report Manager

⚙ Engineering Details

contact @c-suh for information, e.g. profiles, logins

since there a reasonable workaround, putting this in the icebox as a nice-to-have


 Could you help me fix these and transform them to use my personal email (claudiosegalafilho@gmail.com)?

@claudiosegala, after your open PR is accepted, I'll do that. Thanks!

Done.


[DO NOT MERGE] Verify buggy dispatch tests

DO NOT MERGE
I believe I have found two buggy dispatcher tests. These tests create method stubs that are never called. When a different method is called on the test double an error is raised. However, the unstubbed method call happens inside a Promise and so the error is suppressed. Instead of the test failing the promise's fail block runs. I discovered this while working on a spike of this potential dispatcher update.
This PR does not change the tests. Since I am new to both Volt and Opal I wanted to get verification from someone more knowledgeable. If what I believe is happening is correct I will be happy to update the PR.

good catch on this.  Since our code runs on both the server and client, we use promises for blocking method calls.  (Unfortunately missed errors like this are one of the limitations of working with promises)  I've got a few ideas to improve this situation, but haven't gotten around to implementing them yet.  Let me refactor the test a bit so it will raise on these kind of issues.


Track number of active documents in the BucketDB.

Use atomic counter to allow reading the counter without holding the lock. Use relaxed ordering as updates happens while a guard is held.
@toregge @geirst PR
@vekterli FYI

@geirst I have added explicit testing both of BucketState and BucketDB.getNumActiveDocuments()


raylib.com updates and qol additions

Problem:
-there was no way to quickly go back to the top of the page on mobile or desktop with a simple click.
Solution:
-added a go to top of page button that auto hides itself when at the top, and auto shows when the page is scrolled down a bit.
Problem:
-The nav bar was cut off on mobile, and although it could be side scrolled, it was not fully visible.
Solution:
-Made the nav bar take the full available width when either on mobile or on android tablet device.
Problem:
-On mobile, there was a forced width that ignored the screen size, causing some dom elements to disrupt the page layout
Problem:
-The search box had an issue where it would alter the layout whenever a search was being made. It also had no place holder text and no aria-label accessibility. It was also not responsive or centered.
Solution:
-Place holder text has been added.
-Aria label has been added for text readers.
-The search box has been styled to look more aesthetically pleasing & to provide the user with some visual cue.
-The search box now adapts to the screen size due to newly added responsiveness.
-The search results are now underneath the search box, keeping the flow of the layout consistent.
Problem:
-The module boxes were not responsive and disrupted the page flow.
Solution:
-Added responsiveness to the modules container, and reworked how the module boxes are styled for better flexibility when styling.
Problem:
-The cheatsheet had no form of navigation outside of manual scrolling, resulting in a less than ideal user experience.
Solution:
-A modules menu has been added. Now users can click on any of the entries, and be auto scrolled to that section.
-This menu auto hides when print mode is enabled.
-The menu is responsive.
A small note:
I've added a js file, uiManager, that holds some logic regarding the go to top button. This will be used for future improvements where js is needed.

@treblig-punisher Thanks for the review! I'm afraid some conflicts arise when reviewing some previous PRs. Please, could you review them?
I was testing the page and I noticed some things to review:

Is it possible to move the top-menu-icons to the right side, like it was previously. It looks quite overloaded on the left side.
Is it possible to review menu item names spacing? On current implementation it is spaced to fit the full page content and stay aligned.
There seem to be double-line spaces betweent paragraphs. I'd prefer to keep the simple spaces like current version.

Thanks again for the improvements!

@treblig-punisher Thanks for the review! I'm afraid some conflicts arise when reviewing some previous PRs. Please, could you review them?
I was testing the page and I noticed some things to review:

* Is it possible to move the top-menu-icons to the right side, like it was previously. It looks quite overloaded on the left side.

* Is it possible to review menu item names spacing? On current implementation it is spaced to fit the full page content and stay aligned.

* There seem to be double-line spaces betweent paragraphs. I'd prefer to keep the simple spaces like current version.

Thanks again for the improvements!

Sure thing, I'll implement all changes and take a look at the conflict.

Hey Ray, I have a couple of questions, some updates, and a suggestion regarding the navbar.
I have already reverted back all the spacing related issues I introduced, and have adjusted the socials container so that it remains on the right and slides along with the the resizing of the window. I'll be adding those changes to my current branch shortly, but before I do that, there's this other topic regarding the menu names spacing.
I have previously made changes so that the page, along with the navbar react responsively to the window size. The original spacing for the menu items adds 20px of padding for each element, and this works fine if you have a forced size for the nav bar an d page, meaning this ignores reacting to changes to the window size, which keeps the navbar at that size while the view is smaller causing the current issues on mobile and desktop. Since I've modified how these two behave to accommodate for a more fluid and flexible design, this is what using the old padding-inline: 0px, 20px makes it look like:

The only compromise is having that scrollbar due to the current size of the page, which I am sure it's a big no no. I have a suggestion, and this includes your current suggestion regarding the padding to keep the spacing the same, but making the horizontal overflow hidden. Now, this suggestion requires having a hamburger menu ready, which I can get done and implemented in a day, so you might have to go ahead and not merge my changes yet. I'll deal with any conflicts after.
Now regarding the merge conflicts, is there a way i could solve them in vscode? most of these conflicts are present because I have things properly formatted to make it easier to read while working on it, but the same html code/css styles are long one liners in master. that's all I need to fix these and better spot new additions.
One more thing, would you be ok with having all the css in css files separate from the html files? It makes working with everything a bit more convenient. Let me know, and I'll work on that.

@treblig-punisher Sincerely, I'd prefer to avoid it. Is not possible to slightly reduce padding, i.e. to 18px, to avoid that bar despite not getting the menu elements perfectly aligned?

Yes that's a great solution too. I'll implement that.

I don't know, but they could be reformated if required. At the moment there are no coding-conventions defined for the web and that's something I'd like to do. I like to keep all the files and code very organized and following some conventions.

That's great to hear. For the most part, I'll work on a way to keep things better organized, and concise. so far everything is well structured, except for some of the css styling for some pages being on the html files themselves.

Yes, that's ok. Actually, as commented, the files structure and code conventions should be reviewed. Just one exception, I'd like to keep the cheatsheet as self-contained as possible, including the styling on the .html, at least for the moment.

Alright, will do so. I'll keep that exception as needed 🫡

Is this menu is for mobile only? Or will this menu also be for desktop mode? If only for mobile/responsive, that's ok to me.

That is correct, only mobile will have that.
One last thing, I will update my PR with all the changes, so you might have to give that a go, after, to see any if there are any new merge conflicts. I'll make sure to solve them.

@treblig-punisher Nice! Thanks for the review! It seems there are still some conflicts that prevent merging...

@treblig-punisher Nice! Thanks for the review! It seems there are still some conflicts that prevent merging...

I'll be taking a look at these soon. So far the good changes that wee needed have been added.

Alright Ray, I have resolved the conflicts in those two files. I added whatever was missing to mine, and removed anything that had been replaced. Let me know how it goes. I should work normally.

@treblig-punisher Hi! Added some review comments!

Changes:
-minified both path_to_raylib.html and timeline.html files. This was an unintentional format change that has now been reverted back to how it was.

renamed uiManager.js to ui_manager.js and updated all references.

deleted both hamburger svg, and x-icon svg. Their code has been moved to the ui_manager.js file.

updated back-to-top-button's position on the page to prevent covering important page details when reaching the end of the page.

added better mobile reposiveness to both classic games and standard games buttons. These will keep their full size when on desktop, and switch to a smaller width on smaller devices with less space.

One change made to the social media links is the new support for aria-labels. Now screen readers can tell where the links lead instead of saying just "link." More aria-label changes in the near future to make raylib.com more accessible.

Renamed disable-arrow-scroll.js to disable_arrow_scroll.js. I didn't remove the file since whoever is making changes or using the file might need for future feature updates.

These are all the changes Ray. Let me know what you think. This should cover almost everything you suggested except for the thing I explained.

@treblig-punisher I'm trying to review this PR but I'm afraid it's TOO big, could it be splitted in smaller PRs, please?
Also, I see many formatting changes that make it very difficult to see the real changes, could be the previous formatting maintained?

@treblig-punisher I'm trying to review this PR but I'm afraid it's TOO big, could it be splitted in smaller PRs, please?
Also, I see many formatting changes that make it very difficult to see the real changes, could be the previous formatting maintained?

I'll have to see how to split it to make it more manageable.
Could you tell me what exactly changed regarding the format of the pages? what browser are you seeing these changes from?

Could you tell me what exactly changed regarding the format of the pages?

Actually I was referring to code tabs spacing, as it changed it's difficult to see the what changed exactly for the PR.
It's a quite big PR and it's difficult to track review all changes in case something won't work as expected, so it's easier if it is split in smaller PRs, maybe by feature or modified pages. Code formatting is better to be maintained for the moment for changes readability.

Could you tell me what exactly changed regarding the format of the pages?

Actually I was referring to code tabs spacing, as it changed it's difficult to see the what changed exactly for the PR.
It's a quite big PR and it's difficult to track review all changes in case something won't work as expected, so it's easier if it is split in smaller PRs, maybe by feature or modified pages. Code formatting is better to be maintained for the moment for changes readability.

I totally understand. At the moment I am having a bit of a big issue given that the site has been updated again, and I am sure my changes will cause conflicts, since they are from 4 months ago, so here's what I propose:
I will clone the latest version of the repo, and try to implement my changes, and submit smaller PRs as you suggested. This is gonna take some time as I have to keep in mind what should change and what needs to remain minified.  The minified portions are meant to be like that for footprint purposes I am assuming, right?
The other thing regarding some of the changes is that I had to modify the nav bar elements to accommodate for the responsiveness of the site on tablets and mobile.
Some the changes also include quality of life improvements for screen readers. This is aimed to help those with visual problems navigate the site with ease.
About SVGs:
I use svgs for some icons used by the updates I implemented like the go to top button, and the hamburger menu bar for mobile. I have these directly where I need to use them, in my case, I have them in the JS file that comes with the repo. This way I can just reuse it and not have to copy paste it in all pages they're used.
On a final note:
I am interested in also helping you create the new look for the site whenever you feel ready. You already shared a pretty good sketch of what you have in mind, so I'd love to further discuss this outside of github. Could be discord, or google meet, whichever works best for you.


i3lock: unrecognized option '--bar-position=1080'

i installed awful from https://github.com/jeffmhubbard/awful, it requires an i3lock-color to work, but when i try to laucn it im getting and error saying that i3lock dont have such option as --bar-position,i tried all makes and installs but i doesnt work

Hey, the project is archived and this project is not associated with it even @jeffmhubbard is also a contributor here... So from my side I'm unable to provide support here.
// @jeffmhubbard You can decide how to proceed with the ticket :)

@finallly Sorry, but that's a dead project. Recent changes to i3lock-color's bar indicator have left to broken.


set up your Kanban board

https://github.com/users/melkamu12/projects/6
This final Javascript Capstone Project is done by :

Marian Osman - https://github.com/MariamOsman11
Melkamu Almawu - https://github.com/melkamu12

Status: Required Changes :recycle:
Hi @team,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights

Kanban board setup properly. :heavy_check_mark:
15 cards confirmed to be present. :heavy_check_mark:

Required Changes ♻
Check the comments under the review.

[REQUIRED] It is required that each card starts with [Xpt] - that number indicates the number of points that shows how complex the task is. 1 point = 1 hour of work. I noticed that some of the cards do not start with this number of points. Kindly do that.

Project Requirement

Cards with no points

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hello @melkamu12
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Status: APPROVED :fire:  :fire:
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


[BUG] New line/display bug when switching focus to the REPL

When switching focus from the editor to the REPL the REPL cursor jumps to a "new line". It is not a proper new line, with a prepending julia> though, but seems more like a display issue.
Obviously, this does not effect any functionalities but it is nonetheless an annoyance (and does not make a good impression).

Details

Atom version: 1.40.1
Julia version: 1.2.0
OS: Windows 10 Version 1903 build 18362
Package versions:

Atom.jl: 0.11.2
julia-client: 0.11.2
ink: 0.11.5

Steps to reproduce

Fire up Juno (and a Julia session therein).
Switch from editor to REPL (multiple times).

Could reproduce on a second machine with the same software versions.

I observe that this only starts to happen after the REPL has been filled (it needs to "scroll" because there is too much output).


[Enhancement]: Allow provider to use environment variables for kube configuration like k8s/helm terraform provider

Description
Many people using the flux provider also use the Kubernetes and Helm terraform providers.
Both these providers allow you to pass Kubernetes configuration via environment variables.
Therefore, the flux provider should additionally allow this to maintain alignment.
Affected Resource(s) and/or Data Source(s)
N/A
Potential Terraform Configuration
No response
References
The majority of the discussion has happened in https://github.com/fluxcd/terraform-provider-flux/issues/440
Would you like to implement a fix?
Yes

From @networkhermit

I managed to verify that https://github.com/fluxcd/terraform-provider-flux/pull/506 added support for KUBE_CONFIG_PATH and KUBE_CONFIG_PATH support since v1.0.0. But the other options such as KUBE_CLIENT_CERT_DATA/KUBE_CLIENT_KEY_DATA/KUBE_CLUSTER_CA_CERT_DATA/KUBE_HOST still not supported.

Any work started on this issue? Using the environment configuration already present for other providers would be a nice feature.


-a flag stopped working

- Do you want to request a feature or report a bug?
bug
- What is the current behavior?
netlify deploy -a $TOKEN -s $ID --prod returns:
Error: invalid json response body at
 ›   https://api.netlify.com/api/v1/sites/xxx
 ›   reason: Unexpected end of JSON input

Last week this command worked fine. I tried creating a new token but the same error appears.
Using export NETLIFY_AUTH_TOKEN=$TOKEN Works correctly though.
- If the current behavior is a bug, please provide the steps to reproduce.
Run netlify deploy -a $TOKEN -s $ID --prod
- What is the expected behavior?
site is deployed correctly.
- Please mention your node.js, and operating system version.
node 11
Alpine linux (latest)

Need to update the base cli command.
In the meantime, with --auth flag and it should work.
Thanks for the report

@DavidWells i think you fixed this? in case its done now


can: isotp: Add CAN-FD support to ISO-TP

Add CAN-FD support to ISO-TP
Update ISO-TP sample to work with CAN-FD
Update existing ISO-TP unit tests to work with CAN-FD
Add CAN-FD specific unit tests

Mandatory padding of frames > 8 bytes to next DLC
Validation that RX_DL in consecutive frames matches first frame

Thanks @dale-herman for doing most of the work

Just scrolled over it. Looks good at a first glance! You may extend the copyright notice, because it is a bigger extension of functionality.

Just scrolled over it. Looks good at a first glance! You may extend the copyright notice, because it is a bigger extension of functionality.

@alexanderwachter thanks!
If you have time, could you please have a look over this RFC https://github.com/zephyrproject-rtos/zephyr/issues/59896 and give some feedback?
Apologies for not tagging you in it sooner, I would appreciate your input

May I ask you to move the changes related to CONFIG_ISOTP_ENABLE_TX_PADDING and CONFIG_ISOTP_REQUIRE_RX_PADDING into a dedicated commit? As far as I can see they are not related to CAN-FD support. This will make it easier to understand why the change was made in the future.

@martinjaeger Okay, will do

@martinjaeger here is the padding fix PR https://github.com/zephyrproject-rtos/zephyr/pull/60661
I'll rebase this PR once that is merged

Is ISO-TP via CAN-FD part of ISO 15765-2?

Yes, it's part of the third edition of the spec (from 2016).

Please ignore the first two commits. The will be removed through rebasing after #61732 is merged.

This looks good, @martinjaeger. I'd prefer if the last commit could be squashed into the previous commits to avoid the odd history, though.

I added a new commit so that the authorship of the different changes is clear. But I'm fine with squashing it if @gramsay0 agrees.

This looks good, @martinjaeger. I'd prefer if the last commit could be squashed into the previous commits to avoid the odd history, though.

I added a new commit so that the authorship of the different changes is clear. But I'm fine with squashing it if @gramsay0 agrees.

Yep, I'm ok with that.
BTW thanks for carrying this on 👍

I hope that all review comments are addressed now and unrelated CI failures are gone.
The ISO-TP test suites and sample were successfully tested on the following boards:

native_posix
nucleo_g474re (CAN-FD support)
nucleo_f072rb (classical CAN only)

Fixed the typo in the test naming identified by @henrikbrixandersen. Please re-approve once again, @alexanderwachter . Thanks!


Fixed launcher apps hover

Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[X] My code follows the guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] All current GitHub actions pass
[X] Any dependent changes have been merged and published in downstream modules
[X] I have checked my code and corrected any misspellings
[X] I have read the CONTRIBUTING document

Thanks!


Actions, all steps success, but show running

Description
No response
Gitea Version
1.20.4
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots

Git Version
No response
Operating System
No response
How are you running Gitea?
docker
Database
None

duplicate of #26559


estimate-gas return wrong value

🐛 Bug
Estimate-gas cannot calculate internal txs cost
To reproduce

create smart contract with internal txs
check how much gas needed to call function with internal tx inside
try to call this function with use gas amount from 2.
transaction will fail bc of "out of gas"

Expected Behavior
If you deploy same contract in eth network, estimate gas will return bigger amount, because it can
calculate how much gas needed to execute internal txs.

Thanks.  Please attach a sample raw tx to debug this issue.

Contract hex data = 0x608060405234801561001057600080fd5b5060c88061001f6000396000f300608060405260043610603f576000357c0100000000000000000000000000000000000000000000000000000000900463ffffffff1680639765b4d7146041575b005b60476049565b005b3373ffffffffffffffffffffffffffffffffffffffff166108fc600234811515606e57fe5b049081150290604051600060405180830381858888f193505050501580156099573d6000803e3d6000fd5b505600a165627a7a723058201c17bc5fbe92ad70e82f652e9d79752087242a4f28f4502e13e4ceab79bf1b660029
Call data - 0x9765b4d7
Contract source code

contract simpleInternalTx {

    function autoSend() public payable {
        msg.sender.transfer(msg.value/2);
    }

    function () external payable {}
}```

Hey @speedrunner911,
I've deployed the above contract to https://semux.info/explorer/account/0xa845e8f4acf31faa7b51ffc3494d3f236862ab4f and tested /estimate-gas API.
Request:
curl -X GET "http://<IP_ADDRESS>:5171/v2.5.0/estimate-gas?to=0xa845e8f4acf31faa7b51ffc3494d3f236862ab4f&value=5&data=0x9765b4d7" -H "accept: application/json"

Response body:
{
  "success": true,
  "message": "successful operation",
  "result": "28914"
}

I can see the API returns an estimated gas of 28914.


Fix isAllowed of escapeStreamer

The use of sort.Search is wrong: The slice should be sorted, and return >= 0 doen't mean it exists, see the manual.
Could be fixed like this if we really need it:
diff --git a/modules/charset/escape_stream.go b/modules/charset/escape_stream.go
index 823b63513..fcf1ffbc1 100644
--- a/modules/charset/escape_stream.go
+++ b/modules/charset/escape_stream.go
@@ -20,6 +20,9 @@ import (
 var defaultWordRegexp = regexp.MustCompile(`(-?\d*\.\d\w*)|([^\` + "`" + `\~\!\@\#\$\%\^\&\*\(\)\-\=\+\[\{\]\}\\\|\;\:\'\"\,\.\<\>\/\?\s\x00-\x1f]+)`)

 func NewEscapeStreamer(locale translation.Locale, next HTMLStreamer, allowed ...rune) HTMLStreamer {
+       sort.Slice(allowed, func(i, j int) bool {
+               return allowed[i] < allowed[j]
+       })
        return &escapeStreamer{
                escaped:                 &EscapeStatus{},
                PassthroughHTMLStreamer: *NewPassthroughStreamer(next),
@@ -284,14 +287,8 @@ func (e *escapeStreamer) runeTypes(runes ...rune) (types []runeType, confusables
 }

 func (e *escapeStreamer) isAllowed(r rune) bool {
-       if len(e.allowed) == 0 {
-               return false
-       }
-       if len(e.allowed) == 1 {
-               return e.allowed[0] == r
-       }
-
-       return sort.Search(len(e.allowed), func(i int) bool {
+       i := sort.Search(len(e.allowed), func(i int) bool {
                return e.allowed[i] >= r
-       }) >= 0
+       })
+       return i < len(e.allowed) && e.allowed[i] == r
 }

But I don't think so, a map is better to do it.

hmm... When I wrote this code I made two assumptions which my testing appeared to bear out:

e.allowed should already be sorted.
e.allowed should be very small in which case the sort.Search would be super quick - likely quicker than a map as there is no dereferencing.

Could you write a testcase to show that the current code doesn't work?

Could you write a testcase to show that the current code doesn't work?

Sure, please check the first commit of this PR: #68b7e908c87bba7712f08e17cca8f49928d153e2
I removed it because I don't think we need it if there's just a simple map.

I promise it will be quicker and more memory efficient than using a map.

Yeah, you are right, but maybe not quite right. Actually, I don't really care when the difference is just a few nanoseconds.
 So I'm OK for any structure which could resolve the bug.

LG-TM bot

Please send backport


Updated Developer Guide

Improved on some formatting issues.
Updated Model Component of the DG to reflect morphing to component from AB3 to TAPA.

Thanks for updating the model UML too! LGTM, just a minor typo spotted. Also, just wondering since you removed the code snippets, is that to make the DG more readable?

Yea, because I think the ` function wasn't working as intended inside like Note or Warning blocks, and I thought removing it would be less distracting for the reader, do you think there might be a better way to do this?

@Benjykoh Ahhh I see. Admittedly, I think the amount of code snippets in our DG can be quite overwhelming and more difficult to read. That said, the code snippets within warning blocks seem to appear normally for me in the DG online (although they don't appear properly for me in Intellij) :

However, if you feel that it can be distracting, then I support removing them too. 👍  Here's a screenshot of what the DG looks like to me after your PR, for reference:

@Benjykoh Ahhh I see. Admittedly, I think the amount of code snippets in our DG can be quite overwhelming and more difficult to read. That said, the code snippets within warning blocks seem to appear normally for me in the DG online (although they don't appear properly for me in Intellij) :

However, if you feel that it can be distracting, then I support removing them too. 👍 Here's a screenshot of what the DG looks like to me after your PR, for reference:

@brelkh alright, maybe we can take this to the telegram group and ask what the rest think because it was not appearing right for me.


feature to request additional addresses for a wallet

The problem that you wish to solve
Right now from perspective of someone who implements a "merchandize" system such as e-shop based on cardano - you need to be able to distinguish customers from each other. In ideal situation you assign each customer unique address to which they should send ADA in order to recognize which customer sent ADA (in some cases you may need to have unique address for each order).
cardano-wallet generates only about 20 addresses per wallet. It would be nice if there was some method to generate N additional addresses if current pool is depleted.
Description
Create method (or parameter for addresses call) to generate additional addresses for a wallet
Implementation suggestions
No response

Thanks for the feedback!
Note that if the wallet detects a payment to or from an address listed in the https://localhost:8090/v2/wallets/{walletId}/addresses endpoint, it will automatically discover new addresses so that ~ 20 unused addresses are available. Unfortunately, that's not quite what you are looking for, in that you probably have many more addresses for which you expect payments.
Unfortunately, increasing this so-called address gap (default 20) makes restoration from a seed mnemonic more difficult -- if you have, say, 1000 consecutive unused addresses (users that did not send funds), the wallet may not be able to discover some payments if it is only looking ahead 20 addresses. This is a technical limitation of the industry standard BIP-44, on which the CIP-1852 standard is based upon.
I'm currently working on making larger address gaps more practical, and I'm looking into alternative standards. It will take a while, though.
In the meantime, possible workarounds include:

Using transaction metadata
Using the address derivation method to generic addresses and combine this with cardano-db-sync in order to discover payments to these addresses.

well, the thing is I don't even have these extra address :) but I would like to have them, basically right now if I would be only able to handle first 20 customers, or actually, first 20 orders, for other orders I would have to return error "address pool depleted" or something like that.
Or I would need to create huge amount of wallets, each to get 20 addresses, but that also would be very impractical. I think this is a blocker for everyone who wants to create an online store that uses cardano for payments.
I am also wondering how exchanges overcame this problem, when you want to deposit ADA to exchange, every user gets a unique address to deposit to, but they must have millions of addresses per wallet? So it is probably doable.

I can't even solve this by knowing senders address, even if I told customers to send to adress addr_XXXXX and fill their address before they start transaction - they will never know from which address is ADA going to be sent, due to this bug - https://github.com/input-output-hk/daedalus/issues/2505 cardano-wallet randomly redistributed ADA across the wallet, and automatically picks which addresses it takes the UTXOs from, and users don't have any way to affect this.

hi @benapetr  One way to create addresses (having the same mnemonic, account index=0 - for now only this is supported and arbitrary address index) is to use https://github.com/input-output-hk/cardano-addresses/

So let's assume we have mnemonics:

$ cat mnemonics.txt
whisper control diary solid cattle salmon whale slender spread ice shock solve panel caution upon scatter broken tonight

Create extended root private key:

$ cardano-address key from-recovery-phrase Shelley < mnemonics.txt > root.xsk
$ cat root.xsk
root_xsk1kra0jaflzzgtwu5mxl3qsv0gga05fyd3g0yslf3q0kgsq7ctep2wq9yjg4sgq2rwnpcuk2dw8czw9qde5f9ank5vr080fn4z9vzk8zdkvgj7qt6lmlxyn6hm2ne0ymg2srpxfu6cqxxzz75wh93u6klenqxuet7a

Create stake verification key (this would be needed if you want to stake, so create base address, rather than enterprise address)

$ cardano-address key child 1852H/1815H/0H/2/0 < root.xsk | cardano-address key public --with-chain-code > stake.xvk
$ cat stake.xvk
stake_xvk14tq9nymn3m76f3q3c99aru5az6dk6az02h6d5flj6g8ghw5qvte79n5w2t5m2ezplw2zgrry8nm86dlw7rdlv46qt8ltp30jpd4malgt7zj8j

(please notice that 0H account index was used, role=2 and stake index=0 - this should not change)
4. Now create payment verification key:
$ cardano-address key child 1852H/1815H/0H/0/0 < root.xsk | cardano-address key public --with-chain-code > addr0.xvk
$ cat addr0.xvk
addr_xvk17sy8yc35xvdc8wg6ssy33yhjr34qtkhdk52p7m2y5qpjxrxhzf53r4scun52lwd0uf6rtke5hy00ejh7sqa9aufa2nlvzxtptycp0lcu4lkx8
$ cardano-address key child 1852H/1815H/0H/0/1000 < root.xsk | cardano-address key public --with-chain-code > addr1000.xvk
$ cat addr1000.xvk
addr_xvk1u4whatpud5wrkw89vhfx2qcnvw9tjl4q4k246ln42zzht9369aevhxvus9tq4uf6jp8h7vcwhtvsz06lrq06dx70vmln83jaqfekussxsmy50

(we used here 0H account public key, role=0 and (ix=0 first example, x=1000 second example) ). This is how you can create many payment verification keys!
5a (for enterprise address - not staking) for testnet
$ cardano-address address payment --network-tag testnet < addr0.xvk > enterprise0.addr
$ cat enterprise0.addr
addr_test1vqjl24fqvgdfsd8x7tc5trwpyafq3qg78dp3w3ugct69eaqdkedcf
$ cardano-address address payment --network-tag testnet < addr1000.xvk > enterprise1000.addr
$ cat enterprise1000.addr
addr_test1vp5unv4h7f6743hgzqsejhsht3jj9yg6a736w5ljeh2khkcfazhvf

5b (base addresses staking) for testnet
$ cardano-address address delegation $(cat stake.xvk) < enterprise0.addr > base0.addr
$ cat base0.addr
addr_test1qqjl24fqvgdfsd8x7tc5trwpyafq3qg78dp3w3ugct69eazqmr34pgfevux4mslq44avqpjxm9hw2ymyquy6zuy0npmq4p4uf6
$ cardano-address address delegation $(cat stake.xvk) < enterprise1000.addr > base1000.addr
$ cat base1000.addr
addr_test1qp5unv4h7f6743hgzqsejhsht3jj9yg6a736w5ljeh2khk6qmr34pgfevux4mslq44avqpjxm9hw2ymyquy6zuy0npmqelmpxa

Or I would need to create huge amount of wallets, each to get 20 addresses, but that also would be very impractical. I think this is a blocker for everyone who wants to create an online store that uses cardano for payments.

Actually Shelley wallets API allows creating wallets with larger address pool gap (up to 100k addresses), however it comes with some wallet performance cost (see: https://input-output-hk.github.io/cardano-wallet/api/edge/#operation/postWallet).
Another option at the moment can be Byron wallets (see: https://input-output-hk.github.io/cardano-wallet/api/edge/#operation/postByronWallet). Byron wallets follow random address scheme so it is possible to create new address on the wallet (see: https://input-output-hk.github.io/cardano-wallet/api/edge/#operation/createAddress), or even import some addresses (see: https://input-output-hk.github.io/cardano-wallet/api/edge/#operation/importAddresses) which were created outside (e.g. using cardano-address).

benapetr :

I am also wondering how exchanges overcame this problem, when you want to deposit ADA to exchange, every user gets a unique address to deposit to, so they must have millions of addresses per wallet? So it is probably doable.

piotr-iohk:

Another option at the moment can be Byron wallets

Some exchanges do use Byron wallets, I suppose for this very reason.

@benapetr

I can't even solve this by knowing senders address, even if I told customers to send to adress addr_XXXXX and fill their address before they start transaction

Instead of using addresses to disambiguate users, you could also try to use transaction metadata to disambiguate them. This is very similar to the "transfer note" or "intended purpose" for SEPA bank transfers, where retail shops often instruct buyers to include their invoice number.

@benapetr

I can't even solve this by knowing senders address, even if I told customers to send to adress addr_XXXXX and fill their address before they start transaction

Instead of using addresses to disambiguate users, you could also try to use transaction metadata to disambiguate them. This is very similar to the "transfer note" or "intended purpose" for SEPA bank transfers, where retail shops often instruct buyers to include their invoice number. The drawback is that this is extra information which has to be provided by the user.

this is interesting idea, but is it supported by mainstream wallets? so in theory:
there would 1 central address to which all users would send ADA, each merchant order would be distinct by ID which user would need to provide as transaction metadata. If metadata and amount matches - order is confirmed, otherwise user is asked to correct the amount. For orders that don't match (or missing metadata) user should be refunded back - which is the tricky part - because:
1 - we need to calculate the max_fee and deduct it from returned amount, so that the customer who made the mistake pays the transaction fee and not merchant, otherwise malicious users could abuse this by repeatedly sending invalid transactions
2 - there may not only be ADA as part of this transaction, if someone sends native tokens, they should be also sent back
3 - there could be multiple source addresses, should the ADA be returned to all of them? What if after deduction of max_fee some of the UTXOs would be less than 1ADA and thus impossible to be sent?
4 - what is some part of transaction is made from reward address? where should it be sent back?
To be honest - "refund" or some sort of "rollback" operation seems to me so complex that it should probably be implemented in cardano-wallet as well. If this model that is utilizing transaction metadata is supposed to be widespread, then it would make sense to support this flow in basic tools used by merchants, so that they don't need to keep implementing this same workflow on their own.

For orders that don't match (or missing metadata) user should be refunded back […]
To be honest - "refund" or some sort of "rollback" operation seems to me so complex that it should probably be implemented in cardano-wallet as well. If this model that is utilizing transaction metadata is supposed to be widespread, then it would make sense to support this flow in basic tools used by merchants, so that they don't need to keep implementing this same workflow on their own.

Thanks for bringing this up, it seems to me that "refunding" is indeed a useful feature. In fact, it seems to be useful even for the original problem of matching customers to addresses: In the worst case, customers may send money to the wrong address and then the funds are gone. When using metadata, at least the shop now owns those funds and can refund them in principle. (Granted, transaction metadata is more likely to go wrong than addresses, because this problem gets much more attention for addresses. But still).
Anyway, it appears that consumer-facing wallets do not support metadata at the time of this writing.

@HeinrichApfelmus

Could you elaborate? When you make any transaction, the address pool should enlarge automatically.

If you accept Cardano (ADA) payments only and do not do any withdrawals.

@benapetr I'd really like to know a little more about this use case you're describing for cardano-wallet. Can you dive into the scenario a little more, perhaps touch on some things like: comparable existing products/payment services (decentralised/centralised), benefits of one-user-one-address, and extensions of this model (e.g. analytics, what you'd like to achieve if such a feature was created)?
Grateful if you could share any thoughts with us :-)

yes exactly this - imagine you need to create an endpoint where 10 000 different users can deposit some tokens or ADA and you differentiate each of them. Easiest would be to generate 10 000 different addresses, assign one to each user, and track their balance by adding what is sent to these addresses.
of course it's necessary to separately track the balances in separate database, you can't trust on-chain data, because cardano-wallet is randomly reshuffling UTXO between addresses randomly, per https://github.com/input-output-hk/cardano-wallet/issues/2614

The Deposit Wallet is in progress to address this and similar use cases.

The Deposit Wallet is in progress to address this and similar use cases.

@HeinrichApfelmus
Did you mean this pull request https://github.com/cardano-foundation/cardano-wallet/pull/4837 ?
What about address pool exhaustion? Will it be fixed in this feature?
Thanks

Did you mean this pull request

It's a new wallet that we are currently working on and going to include in future releases of cardano-wallet. If you want to get an overview of the pull request relevant to this, have a look at the label https://github.com/cardano-foundation/cardano-wallet/labels/Deposit .
We hope to make it easier to follow our work soon.

@gituser Would you be available for a chat in the near future? We are looking for feedback from users to ensure this new wallet will fit the needs and alleviate some pain points of the existing cardano-wallet.

@abailly

@gituser Would you be available for a chat in the near future? We are looking for feedback from users to ensure this new wallet will fit the needs and alleviate some pain points of the existing cardano-wallet.

I'm available in this issue or feel free to create a discussion.
For our company the address exhaustion is a major blocker to enable Cardano support.

I'm available in this issue or feel free to create a discussion.
For our company the address exhaustion is a major blocker to enable Cardano support.

I was thinking of having a chat using google meet, in order to better understand your use case and whether or not the features we are working on for the deposit wallet would love the issues you're currently having with c-w.


Modified Log in to azure mentioned twice

Modified Log into Azure to Sign in to Azure and removed the duplicated sentence to more meaningful rather than duplication.

@taswar : Thanks for your contribution to the Azure documentation! The author, @ggailey777, has been notified to review your proposed change.

#sign-off


Codegen argument defs

Each field definition should know about its parameters. This will be useful for validation and introspection.
For now, we just generate shapes containing the type, name, and default value for each argument. This might get fancier if we need it to.

You're now a codegen expert 😉

Hah. I could have sworn that there's a nicer way to do the codegen in this PR — maybe using something like HackBuilderValues::shapeWithPerKeyRendering, but I couldn't quite figure it out and so just went with this.


Mark used bytes of enums for unions

Implements mark_used_bytes for enums.
Also adds test cases to ensure that relevant data in structs, enums and arrays is marked, and that padding is not marked in the case of enums.
Fixes https://github.com/minirust/minirust/issues/167

Thanks. :)


headers: move z_impl from public API header file to another file

This moves all the inline z_impl_* functions from the public API header file into another file. These z_impl_* functions are implementation details that do not need to live within the public API header file. This de-clutters the public API header file.
The scancode check complains about BSD license in the TEE drivers. I am simply splitting the file so the copyright needs to be preserved.

Not a bad idea to split them up, not thrilled about the choice of path though, this is adding load of internal directories all over the place.
Have you considered either having a single include/zephyr/internal or include/zephyr/impl where these could live without tht impl suffix on the individual files? Alternatively, keep the suffix and let them live next to the original file.

Not a bad idea to split them up, not thrilled about the choice of path though, this is adding load of internal directories all over the place.
Have you considered either having a single include/zephyr/internal or include/zephyr/impl where these could live without tht impl suffix on the individual files? Alternatively, keep the suffix and let them live next to the original file. Sorry I realize I'm bikeshedding here but I think it's worth discussing the choice. :-)
For comparisson Linux has the uapi split, which is sort of a single one include/uapi and few others.

or, I don't see why they can't just live in the same directory as the public header file, maybe the number of files on that directory doubles but don't see why not

Putting them under internal/ is to signal that these are internal functions, which should not be used unless absolutely necessary. ...also makes using tab completion under command line less annoying. I can also put the new files under drivers/internal/ instead, but then these files will not be grouped by subsystem at higher level.

Architecture WG:

@henrikbrixandersen and @gmarull both agree to try and move out more than just the helpers. This means all the driver-facing, including structs, callbacks, etc
Consider expanding the PR, perhaps starting with a single driver class but covering everything

Let me work on refactoring more stuff out of the public header and submit separate PRs for reviews.

UART header rework is here: https://github.com/zephyrproject-rtos/zephyr/pull/77361


ibctesting: New packet events are lost when relaying packets

Summary

some apps, on ibc acknowledgement the code triggers some extra ibc transactions atomically or on the next begin blocker.
since relay packets function commits and does SendMsgs which inturn calls chain.NextBlock(), the packets that are generated on the block when OnAck is received and as the nextblock is executed the ctx containing these events is lost.

Problem Definition
Need to find a way to find/ store all packets generated via ibc, so every packet can be relayed.

Proposal

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

@puneet2019 can u give me a little more information on how to approach this problem? Or how can i regenerate this issue?

can u give me a little more information on how to approach this problem? Or how can i regenerate this issue

Yes, sure
So, think of a scenario where the app module is sending ibc packets. where..

in block N -> sent a ICA packet (A).

then call relay packets function , this function will commit packets, do acks, and trigger NextBlock too

Case 1) on Ack of packet (A) -> trigger sending of ICA packet (B)

Now even if app has processed Ack, and sent packet B, the code has no way to know what packet B was, since events in it's ctx is lost.

Case 2) on after Ack of packet (A), -> on block N+1 begin blocker, do ICA packet (C)

Similar to case 1, the Next block commits and processes begin blocker, so the events to find what packet C is, is lost.


Refine test cases for file operations

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- yos/compare.go  1

Complexity decreasing per file
==============================
+ yos/copy_test.go  -5

Clones added
============
- yos/compare_test.go  3
- yos/compare.go  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- yos/exist_test.go  3
- yos/compare_test.go  1
- yos/compare.go  1

Complexity decreasing per file
==============================
+ yos/copy_test.go  -5

Clones added
============
- yos/exist_test.go  1
- yos/compare_test.go  4
- yos/compare.go  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- yos/compare.go  1
- yos/compare_test.go  1
- yos/exist_test.go  3

Complexity decreasing per file
==============================
+ yos/copy_test.go  -5

Clones added
============
- yos/compare.go  2
- yos/compare_test.go  4
- yos/exist_test.go  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- yos/exist_test.go  3
- yos/compare_test.go  1
- yos/compare.go  1

Complexity decreasing per file
==============================
+ yos/copy_test.go  -5

Clones added
============
- yos/exist_test.go  1
- yos/compare_test.go  4
- yos/compare.go  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- yos/compare_test.go  1
- yos/exist_test.go  3
- yos/compare.go  1

Complexity decreasing per file
==============================
+ yos/copy_test.go  -5

Clones added
============
- yos/compare_test.go  6
- yos/exist_test.go  1
- yos/compare.go  2
- yos/copy_test.go  4

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- yos/exist_test.go  3
- yos/compare_test.go  1
- yos/compare.go  1

Complexity decreasing per file
==============================
+ yos/copy_test.go  -5

Clones added
============
- yos/exist_test.go  1
- yos/compare_test.go  6
- yos/copy_test.go  4
- yos/compare.go  2

See the complete overview on Codacy


Trying to upload a picture, ESP32 Cam -> local ftp server

Hello there I am trying to upload a picture from the ESP32 Cam module to a local ftp server I have running. I managed to get the example upload sketch working and successfully uploaded the octocat.jpg picture so things on the ftp/credential side seem to be fine.
EDIT: I also managed to get the proper filenames over and the files with correct filenames are being generated however they are empty or very small.
I am suspecting things are breaking in these lines as I was getting multiple compile errors until it compiled but unfortunately noticed a Guru Meditation Error and a memory dump following it:
This is how the picture is taken:
// Take Picture with Camera
fb = esp_camera_fb_get();
if(!fb) {
Serial.println("Camera capture failed");
return;
}
File file = fs.open(path.c_str(), FILE_WRITE);
if(!file){
Serial.println("Failed to open file in writing mode");
}
else {
file.write(fb->buf, fb->len); // payload (image), payload length
Serial.printf("Saved file to path: %s\n", path.c_str());
EEPROM.write(0, pictureNumber);
EEPROM.commit();
}
file.close();
This is how I am trying to send it and Im expecting the problem to be hidden here:
// Create the new file and send the image
ftp.InitFile("Type I");
ftp.NewFile(path.c_str());
ftp.WriteData( fb->buf, sizeof(fb->len) );          //<- expecting a problem here
ftp.CloseFile();
In general I am trying to combine this sketch and implement ftp functionality so that a copy of each file is sent to an ftp server.
Any help on this is appreciated as I am quite lost at the moment

Please share you full code.
Start the library with verbose mode "2" and share the serial monitor.
Since the example provided with the library works, it's likely that your code break due to the use of SD card or the EEPROM


[python3][python2] Use MKDIR_P to create directories to avoid race conditions

We've observed intermittent failures for python2 and python3 on osx with the error log
install: mkdir /Users/vagrant/Data/packages/python3_x64-osx/Users/vagrant/Data/installed/x64-osx/lib: File exists
make: *** [altbininstall] Error 71

Looking at the implementation of altbininstall, it is using $(INSTALL) to create these folders. Apprently, the /usr/bin/install program on osx does not internally pass -p to mkdir under normal circumstances. However, autotools already has provided for this by finding an appropriate mkdir that's safe:
# from config.log
configure:6351: checking for a thread-safe mkdir -p
configure:6390: result: ./../src/v3.10.1-8b5dfc5615.clean/install-sh -c -d

This program is stored as MKDIR_P, so I've added a string replacement step that changes over every mkdir-via-install to use $(MKDIR_P) instead. I originally wanted to use a patch, but there are around 10 uses scattered through the file so it would be a reasonably large patchfile (~100 lines).
There is potentially a concern about the produced directories not having customized permissions, however I don't think that should be an issue in the case of vcpkg.

LGTM!

For python3, we already applied #21734. Maybe it should be reverted if it wasn't sufficient.

Thanks for the fix!


mc-send-to-console ==> bash: /tmp/minecraft-console-in: Permission denied (possibly rootless Podman specific)

Describe the problem
When running ./test of https://github.com/OASIS-learn-study/minecraft-storeys-maker (at e21fdcd), then:
host$ podman exec storeys mc-send-to-console help
bash: /tmp/minecraft-console-in: Permission denied

host$ podman exec -it storeys bash
root@a6849f7127ef:/data# ls -alsh /tmp/minecraft-console-in
0 prw-rw-r--. 1 root root 0 Apr 25 17:34 /tmp/minecraft-console-in

root@a6849f7127ef:/data# mc-send-to-console help
bash: /tmp/minecraft-console-in: Permission denied

root@a6849f7127ef:/data# id
uid=0(root) gid=0(root) groups=0(root)

This may be somehow related to using podman instead of docker, and -e UID=0 -e GID=0 (here for this).
I've found #1208 and #1216, but somehow that doesn't do the trick here.
I can probably work around it by using rcon-cli instead of mc-send-to-console so shouldn't be blocking me, but just wanted to at least record it here anyway.
Container definition
No response
Container logs
No response

Thanks for all the details. I don't think it's a podman thing, but rather the -e UID=0. The conditional here
https://github.com/itzg/docker-minecraft-server/blob/bca7b79f779c67c87a0443d8d925e96658b901c0/bin/mc-send-to-console#L15
needs to make use of that rather than assuming a "sudo" to the minecraft user.

I finally circled around to this issue and I'm wondering if this identifies the cause
https://unix.stackexchange.com/a/503169
One version of the solution may be to set CONSOLE_IN_NAMED_PIPE so that the pipe is not in /tmp. Perhaps a filename within /data would work.


Location update (Send Failed) on Android

Hello, I am trying to set this up to track my Android phone. I purchased the $10/month plan for shared server, but when I set it up, I am getting "send failed" and my phone won't show up on my localhost:8082 page.
I have tried using the server address of my public IP address, as well as those mentioned in the tut videos, but get the same error. Could use some help here!
Thanks.

How is paid subscription related to your local server? I am a bit confused about the question.

Is there a different server address (couldn't find one) that I should be
connecting to with paid shared server? I'm just unsure about the processes.
On May 24, 2017 10:43 PM, "Anton Tananaev"<EMAIL_ADDRESS>wrote:

How is paid subscription related to your local server? I am a bit confused
about the question.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tananaev/traccar/issues/3191#issuecomment-303928104,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbmmCYWS2WdakeWQKcfS2qHYfATkdW1iks5r9RT7gaJpZM4Nl_D_
.

Have you received an email with information about your account? It contains address of the server and all other details.

No it does not seem I have received that email yet. That's the part I'm
missing then.
On Wed, May 24, 2017 at 10:47 PM, Anton Tananaev<EMAIL_ADDRESS>wrote:

Have you received an email with information about your account? It
contains address of the server and all other details.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tananaev/traccar/issues/3191#issuecomment-303928623,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbmmCXQM-w1VsvotLOOrAMOTllXQDtSyks5r9RXogaJpZM4Nl_D_
.

Please send me an email and I'll provide you the information. Address is in profile.


Add Ability to Type Icons via Shorthand

When typing within text fields, add the ability to type an icon based off an assigned shortcut. Instead of pulling up the icon drop-down and manually picking an icon, type something like :vill to automagically insert the villager icon.
This would greatly speed up input process and make the tools easier to adapt. It also seems like the icons don't load very quickly when using the button to insert one. Perhaps this can be optimized?

Thanks! Good suggestion.
I had a similar idea right from the start, but since this is my first web project, I was simply lacking the skills and time to prepare and so went for the easier way that does not involve input parsing. ;)
Same is true for the optimization. I guess, I would have to pre-load the images in the background and cache.
Feel free to get involved.
With 2 kids around, I cannot promise when I will find the time for any of the suggestions.

PS: Found out that it seems to be the vuetify layouter which eats up a lot of time every time you open up the icon selector. Not the images. This icon selector needs optimization, I agree!

For future reference:
https://www.reddit.com/r/vuetifyjs/s/KfSOirk3O7

Mind hitting me up on Discord? I cloned the repo locally and wanted to poke around but not sure how to locally dev against the cloud resources being leveraged. My name is: fitzbro

Sure, once the kids are in bed. Most likely you just need to create an app key to access the dev environment on firebase.
I did some testing on a local branch reg. inline shortcut replacement. Is doable. Cursor placement needs to be solved, though.

This seems to be a good inspiration for autocomplete:
https://medium.com/streak-developer-blog/the-complexities-of-implementing-inline-autocomplete-for-content-editables-e358c0ed504b

implemented in today's release (no autocomplete menu, though)

improved icon selector performance
add icons by shorthand or partial title match inline


[pt run] Setting to override system default for theme

crutkas:
Should have setting to force theme setting like we do for others.

📝 Provide a description of the new feature
What is the expected behavior of the proposed feature?  What is the scenario this would be used?
Can theme selection be added to the power toys run?
Currently, it applies the default system theme. An option to switch between dark and light would be great.
But keeping it aside this application works great.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

no plans for custom theme but I think overriding theme selection is a good idea.

Note: update https://github.com/microsoft/PowerToys/wiki/PowerToys-Run-Overview#13-settings  before closing the issue after 0.25 is released.

Added in 0.25.  https://github.com/microsoft/PowerToys/releases/tag/v0.25.0


Tileset support?

Is there support for tilesets? I would like to create levels using a single tileset image and pass in indices of tile objects (instead of separate sprite images individually).
Great project btw! Very simple and fun to play with

Not yet but definitely, I'll look into this next week!

so right now the tileset related supports are:

you can slice images into frames by sliceX and sliceY field in loadSprite()

// slice the image into 12 x 3 = 36 frames with equal sizes
loadSprite("tileset", "path_to_image.png", {
    sliceX: 12,
    sliceY: 3,
});

// later in code...

add([
    sprite("tileset", { frame: 12, }),
]);

manually pass in a quad field to sprite() component conf (just introduced to master in https://github.com/replit/kaboom/commit/e480fb5bf5c252b36e7325e79f83dc9c2f8d8c38)

// will only draw the rectangle area of x: 0, y: 0, w: 0.2, h: 0.2 of the image
add([
    sprite("tileset", { quad: quad(0, 0, 0.2, 0.2), }),
]);

i don't have a lot of experience using tilemaps, curious to know if you have any ideal API in mind for a code-only solution

does the slicer also support gaps between images? Sometimes free tilesets have:

margin around entire tileset
padding between tiles

It would be incredibly useful to be able to specify frames as an array of quads as an alternative to the sliceX and sliceY properties. If there is a spritesheet where the sprites in an given animation aren't contiguous or don't fit neatly into a slice, it doesn't currently seem possible to create animations from them!