Dead project?

Hello, this looks super useful!  Any chance this will be updated to support the new multi-object world format with material properties conversion?  Honestly I'd be willing to buy that.

Hey guys, apologies for not responding earlier, had not received notification of the issues raised.
I haven't worked on anything related to MagicaVoxel since this project, but after a cursory glance at the new file spec, I see no reason I couldn't update this, once I have time freed up from other projects.
Be sure to watch the repo, hopefully I'll get things moving in the not too distant future.

That’s great! I look forward to it.

Man I've been looking for something like this for ages and now it's not working anymore. :(
That's an amazing job you did on this, I'd be very very VERY interested in this getting updated, I would pay for this addon too.
If this would work in Blender 2.8 with the current magicavoxel it would be a dream but I'd be happy to get it working in Blender 2.79 with the current magicavoxel as well.
I work with magicavoxel a lot and create cyberpunk cityscapes. It's great to get them into Blender but I was always looking for an easy way to get the voxels directly and create physics scenes.
I'd be super happy if you could update this, I hope that's possible.

I just "adapted" the script to work in 2.80 syntax. May I upload it?

@wizardgsz fantastic, I've been slacking on this yet again, I know.
I've been a little caught up on working out how to do it perfectly, to do anything.
Please, do share your adaptation, either as a fork of this repo, or otherwise

Np, this is my second script using Python and Blender... never used them before last week 💃
Here it is my "contrib" in BlenderArtists Community Forums:  Porting addon to 2.8
The archive contains both original 2.74 and 2.80 versions: io_scene_vox.zip
Thanks for your work!


chore(main): release 1.2.0

:robot: I have created a release beep boop
1.2.0 (2024-03-26)
Features

Adding doc-style checks with ruff (2b263e8)
Adding pyright type checking (2b263e8)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/CoreySpohn/lod_unit/releases/tag/v1.2.0 :sunflower:


Add websocket option update on component variable change

if certain ControllerComponentVariables are changed, updates the websocket options (without a reconnect)
removes the reset of connection_attempts on option settings since

unclear, why this is part of setting the connection options (which does not have further side effects)
so far, in libocpp set_connections_options is only called in the context of a websocket init (which implies connection_attempts=0)

I suggest to better make it explicit in the options itself.
One way could be to split up the WebsocketConnectionOptions  into two parts: WebsocketConnectionOptionsNeedsReconnect and WebsocketConnectionOptionsNoReconnect. That way it's clearly indicated directly at the source of the fields what it means when changing them.
Perhaps you have a better idea, though?

I suggest to better make it explicit in the options itself.
One way could be to split up the WebsocketConnectionOptions into two parts: WebsocketConnectionOptionsNeedsReconnect and WebsocketConnectionOptionsNoReconnect. That way it's clearly indicated directly at the source of the fields what it means when changing them.
Perhaps you have a better idea, though?

Hmm yes that is tricky.
I do not quite understand the intention how the Websocket class is to be used. The Websocket class does offer the set_connections_options method, but does not really take care of it. I would actually expect that if I change options that require a re-connect, then the Websocket would take care of this. But this would be purely internal, so the outside classes would not need to care - so also (at least from the outside) not split would be required.
However, we already do care outside (in case the basic auth settings change). And in fact the Websocket does nothing when options are changed....
So if we want to refactor this, I would rather make the websocket API safer instead of putting more knowledge/responsibility outside (and then also kick out this distinction between with/without reconnect). But I am not 100% aware of all implications here and also not sure, this should go into this PR then?

I suggest to better make it explicit in the options itself.
One way could be to split up the WebsocketConnectionOptions into two parts: WebsocketConnectionOptionsNeedsReconnect and WebsocketConnectionOptionsNoReconnect. That way it's clearly indicated directly at the source of the fields what it means when changing them.
Perhaps you have a better idea, though?

Hmm yes that is tricky.
I do not quite understand the intention how the Websocket class is to be used. The Websocket class does offer the set_connections_options method, but does not really take care of it. I would actually expect that if I change options that require a re-connect, then the Websocket would take care of this. But this would be purely internal, so the outside classes would not need to care - so also (at least from the outside) not split would be required. However, we already do care outside (in case the basic auth settings change). And in fact the Websocket does nothing when options are changed....
So if we want to refactor this, I would rather make the websocket API safer instead of putting more knowledge/responsibility outside (and then also kick out this distinction between with/without reconnect). But I am not 100% aware of all implications here and also not sure, this should go into this PR then?

There are quite some implications that need to be considered when changing the internal websocket handling and unfortunately the requirements of v16 and v201 differ a little bit concerning the change of ws options / reconnect / fallback handling. I agree that a general refactor makes sense, but I see this as part of another PR.


Refactor of kast to expose fast-paths

kore-print script which takes Kore -> ANY (if ANY is pretty, it uses fast kprint, otherwise slow kast).
kparse script which takes ANY -> Kore (using Bison parser if it exists, otherwise falls back to kast).
kparse-gen which generates bison parsers. Currently users are responsible for generating these as needed ahead of time.
Exist kast is renamed to kast-util, and then new kast wrapper wraps up logic calling all subscripts.

Create a new issue if we have more concerns. The first 3 items are done.


Package shown in page while not yet active

I've noticed this since quite a while, package are being showned on the page prior from being activated after the upload.
Would be nice to block that so things can be activated + delivered in bulk, mostly for dependent packages.

I've noticed this since quite a while, package are being showned on the page prior from being activated after the upload.
Would be nice to block that so things can be activated + delivered in bulk, mostly for dependent packages.

It is by intention that inactive packages are shown. This was introduced with  #111.
Inactive packages are for manual download only and do not appear in DSM Package Center.

I had no idea of that, thnx.  Still would be great to mark them as inactive on the per app page.

I had no idea of that, thnx. Still would be great to mark them as inactive on the per app page.

Yes this was done by #111. Inactive packages are shown with grey labels and the tooltip telling so, active packages have green labels...

Thnx!


Use ruff for linting

I've had a crack at this. @ColeDCrawford please could you have a look at 17f7960 in particular? I think it's ok, but I might have missed something.
I'm left with these ruff errors, and to fix them I think we need to decide what should be included in __all__
edtf/__init__.py:2:5: F401 `edtf.convert.dt_to_struct_time` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
edtf/__init__.py:3:5: F401 `edtf.convert.jd_to_struct_time` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
edtf/__init__.py:4:5: F401 `edtf.convert.old_specs_to_new_specs_expression` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
edtf/__init__.py:5:5: F401 `edtf.convert.struct_time_to_date` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
edtf/__init__.py:6:5: F401 `edtf.convert.struct_time_to_datetime` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
edtf/__init__.py:7:5: F401 `edtf.convert.struct_time_to_jd` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
edtf/__init__.py:8:5: F401 `edtf.convert.trim_struct_time` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
edtf/__init__.py:10:26: F401 `edtf.natlang.text_to_edtf` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
edtf/__init__.py:11:33: F401 `edtf.parser.grammar.parse_edtf` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
edtf/__init__.py:12:1: F403 `from edtf.parser.parser_classes import *` used; unable to detect undefined names
edtf/fields.py:92:20: S301 `pickle` and modules that wrap it can be unsafe when used to deserialize untrusted data, possible security issue
edtf/natlang/__init__.py:1:17: F401 `.en.text_to_edtf` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
edtf/parser/__init__.py:1:33: F401 `edtf.parser.grammar.parse_edtf` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
edtf/parser/__init__.py:2:1: F403 `from edtf.parser.parser_classes import *` used; unable to detect undefined names
Found 14 errors.

Have a PR to that branch for review: #51

Thank you, I've merged it now.


Fixing the missing redirects

Most of the redirect issues were files that hadn't been deleted. Hopefully this fixes them.
CC: @petele

will push later this morning


update metrics guide for new grafana dashboards

What did you implement:
Simple updates to the metrics markdown docs.
Is this ready for review?: YES
Is it a breaking change?: NO

Thanks for the feedback, will address shortly!

@sebito91 Please also update the link in repo README https://github.com/serverless/event-gateway#reference


Manually roll the engine

This is for b/220976275 (more details in the bug).
Internal tools to do a cherrypick will roll the engine version up to the version specified in this file. This means that even though we want to CP https://github.com/flutter/engine/pull/31641, flutter/engine@5f0271a38988732c48f55c1244717430816391d3 will be rolled instead, which serves no purpose.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@CaseyHillers please take a look (and the comments in the linked bug) :slightly_smiling_face:. Do you also know why the checks are failing here?

Thank you!


cdc: load uninlined value more effectively

What is changed and how it works?
Close #11557.
This PR contains these parts:

Refactor cdc::old_value module.

OldValueReader is removed and methods are extracted into functions to make them easier to use.
Test cases in the module can cover the refactor.

old_value::get_old_value returns Result<Option> instead of Option now.
So that if RocksdB APIs return errors, CDC tasks can detect it instead of returning wrong things to downstreams.
flush_oldvalue_stats won’t be called too frequently on on_multi_batch, which will utilizes too much CPU.
For the current CPU usage without the PR, we can take a look at this profiling.
ScanPolicy::fetch_old_value is removed and the logic to handle TsFilter is moved into seek_for_valid_value.

so that we can avoid to load long value from CF default with some conditions.
This change is covered by test case test_old_value_with_hint_min_ts.

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tidb-ansible:
Need to cherry-pick to the release branch

Check List
Tests

Unit test

Manual test
Here is the test result for the patch:

We can know

hint_min_ts introduced in #11385 utilizes much more CPU (from 140% to 300%)
this patch can fix it, and reduces CDC task initialization time from 7.2min to 6.7min.

Release note
None

/test

/run-integration-cdc-test

/run-integration-cdc-test

/run-integration-cdc-test

@liuzix friendly ping~

/merge

/test


Add support for sending slack commands

This needed an update of the nlopes/slack dependency, so the first commit isn't very interesting.


fsthttp, internal: add get_addr_dest_ip/port hostcalls

Fixes #121

Not sure I like how these hostcalls are exposed, but the hostcalls themselves work.

Can you add a RemoteAddr() method to return a net.Addr instead of exposing host and port as fields on Response?

Agree with other comments that this should be a method to return a friendly standard Go type.

Consider exposing this as a net/netip.AddrPort instead of or in addition to a net.Addr

API fixed. PTAL.


Crash when logging in SSP (COFH core)

Какую версию модпака вы используете? / Which modpack version are you using?
IMPACT <IP_ADDRESS>
Вы играете в одиночке или на сервере? / Are you playing single or on a multiplayer?
single
Опишите ошибку (Если нужно, приложите скриншоты). / Describe the bug (Attach screenshots if needed).
I had just built an industrial pulverizer, and had used it, then logged out.  When I logged back in, I saw the pulverizer briefly with missing textures for 3 blocks (input bus, output bus, controller).  Then the game crashed.
Какие изменения вы предлагаете? / What changes do you suggest?
Fix the crash
The log is here: https://paste.ee/p/QiBQb

[13:08:58] [Server thread/ERROR]: This crash report has been saved to: /home/chezzik/Minecraft/MultiMC-dev/bin/instances/IMPACT-<IP_ADDRESS>/.minecraft/crash-reports/crash-2021-04-14_13.08.57-server.txt

pls give me crash

That portion of the crash report is here: https://paste.ee/p/GH0lo
Sorry, I should have included it initially.

This is a standard minecraft crash with any mods, packet loss between the server and the client


ARROW-2512: [WIP] [Python] Using Pytorch as Python interface for GPU objects

This is currently a work in progress. Pytorch 0.4.0 is required for this to work.
Instructions
First, go to arrow/python/pytorch_example and run python setup.py install, which will install the extension to pytorch. Then build arrow normally with plasma and gpu enabled as below:
cmake -DCMAKE_BUILD_TYPE=$ARROW_BUILD_TYPE \
      -DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
      -DARROW_PYTHON=on \
      -DARROW_PLASMA=on \
      -DARROW_BUILD_TESTS=OFF \
      -DARROW_GPU=ON \
      ..

and build pyarrow with python setup.py build_ext --build-type=$ARROW_BUILD_TYPE        --with-plasma --inplace (this may not be necessary, this is just how I installed pyarrow).
Then in ipython, create a plasma store and a client:
import os
import random
import shutil
import signal
import subprocess
import tempfile
import time

import numpy as np
import pyarrow as pa
import pandas as pd

DEFAULT_PLASMA_STORE_MEMORY = 10 ** 8
USE_VALGRIND = os.getenv("PLASMA_VALGRIND") == "1"

def random_name():
    return str(random.randint(0, 99999999))
def start_plasma_store(plasma_store_memory=DEFAULT_PLASMA_STORE_MEMORY,
                        stdout_file=None, stderr_file=None):
     plasma_store_executable = os.path.join(pa.__path__[0], "plasma_store")
     plasma_store_name = "/tmp/plasma_store{}".format(random_name())
     command = [plasma_store_executable,
               "-s", plasma_store_name,
               "-m", str(plasma_store_memory)]
     pid = subprocess.Popen(command, stdout=stdout_file, stderr=stderr_file)
     time.sleep(0.1)
     return plasma_store_name, pid
import pyarrow.plasma as plasma
        # Start Plasma store.
plasma_store_name, p = start_plasma_store()
client = plasma.connect(plasma_store_name, "", 64)

Now simply create a numpy float32 array, and pass it to client.gpu_example
arr = np.random.rand(20,20).astype('float32')
result = client.gpu_example(arr)

which should return a pytorch tensor.

From a cursory look, I think there are some flaws here:

GPU support in Python shouldn't require PyTorch (last I tried, I think I didn't even manage to install a working PyTorch package -- regardless, it shouldn't be a dependency for this)
in Python, PlasmaBuffer is mostly a relic: it will go when ARROW-2363 is solved

Also, IMHO ARROW-2447 should get implemented before this moves forward, to avoid accumulating technical debt.

@pitrou Thanks for the feedback! You are right, we need to do some refactoring before this gets merged. Also pytorch won't be a dependency of plasma, the plan is to make it to have an example that shows how to load a tensor from plasma GPU memory directly into pytorch.

This PR is more than a year old, I'm closing but feel free to submit a new PR after addressing feedback and rebase issues


Commit to private repo without authorization

Hi, a person can commit to a private repo without having the proper credentials to the account.

Hi
What credentials can be used to access a private repo?

I tried with django super user account to commit to private repo of a normal user. Also is this still under dev ? would love to help u if i can

When I test this exact scenario, the superuser can't access a private repo.
Yes, Djacket is under development and in version 0.1, unfortunately I didn't have time to update it in the last months, and I would very much appreciate your contribution to this project.


overriding certain plugins doesn't work properly

i can't get the flash.nvim plugin to override its config for some reason with the default starter clone
here's something to reproduce it.
my overrides actually DO work if i first set defaults.version = '*' in the lazy spec, and then update all my plugins. but then i get a lot of other issues like slowness in the UI when i restart nvim.. keeping defaults.version = false is the right move but how can i get flash.nvim overrides working without doing that?
disabling flash.nvim works nicely, but i want to use it
local lazypath = vim.fn.stdpath("data") .. "/lazy/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  -- bootstrap lazy.nvim
  -- stylua: ignore
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", "--branch=stable", lazypath })
end
vim.opt.rtp:prepend(vim.env.LAZY or lazypath)

require("lazy").setup({
  spec = {
    -- add LazyVim and import its plugins
    { "LazyVim/LazyVim", import = "lazyvim.plugins" },
    -- import any extras modules here
    -- { import = "lazyvim.plugins.extras.lang.typescript" },
    -- { import = "lazyvim.plugins.extras.lang.json" },
    -- { import = "lazyvim.plugins.extras.ui.mini-animate" },
    -- import/override with your plugins
    { import = "plugins" },
    {
      "folke/flash.nvim",
      event = "VeryLazy",
      ---@type Flash.Config
      opts = {
        char = {
          -- keys = { [";"] = "H", [","] = "L" },
          keys = { "f", "F", "t", "T", [";"] = "L", [","] = "H" },
        },
      },
    },
  },
  defaults = {
    -- By default, only LazyVim plugins will be lazy-loaded. Your custom plugins will load during startup.
    -- If you know what you're doing, you can set this to `true` to have all your custom plugins lazy-loaded by default.
    lazy = false,
    -- It's recommended to leave version=false for now, since a lot the plugin that support versioning,
    -- have outdated releases, which may break your Neovim install.
    version = false, -- always use the latest git commit
    -- version = "*", -- try installing the latest stable version for plugins that support semver
  },
  install = { colorscheme = { "tokyonight", "habamax" } },
  checker = { enabled = true }, -- automatically check for plugin updates
  performance = {
    rtp = {
      -- disable some rtp plugins
      disabled_plugins = {
        "gzip",
        -- "matchit",
        -- "matchparen",
        -- "netrwPlugin",
        "tarPlugin",
        "tohtml",
        "tutor",
        "zipPlugin",
      },
    },
  },
})

I usually override the builtin plugins by adding a lua file in the plugins folder named after the plugin with my overrides like this: https://github.com/briandipalma/iac/blob/main/dotfiles/nvim/lua/plugins/mini-animate.lua
It's always worked for me so far.

would you mind trying this one to see if you can get it to work? i can't get it to work unless i turn on '*' version in lazy.nvim lol

my example will reproduce it and you'll see that , and ; don't get remapped properly :(


GAIL implementation

paper link: https://arxiv.org/abs/1606.03476

tldr;

add summary support function to baselines/common/tf_util.py
add gail implementation which is based on open/baselines/trpo_mpi and open/imitation


monir: 去除国际化误改的移动端组件

Codecov Report

Merging #810 (e816497) into v2.6.x_develop (cdf7147) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           v2.6.x_develop     #810   +/-   ##
===============================================
  Coverage           61.24%   61.24%
===============================================
  Files                 461      461
  Lines               29238    29238
===============================================
  Hits                17906    17906
  Misses              11332    11332

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdf7147...e816497. Read the comment docs.


"Control does not support transparent background colors" exception when launching application

Win10 x64, MemoScope <IP_ADDRESS> (latest release).
System.ArgumentException: Control does not support transparent background colors.
   at System.Windows.Forms.Control.set_BackColor(Color value)
   at System.Windows.Forms.ListView.set_BackColor(Color value)
   at WinFwk.UIModules.UIModuleForm.ApplyColors(Control control, UISettings uiSettings) in C:\projects\memoscope-net\WinFwk\UIModules\UIModuleForm.cs:line 269
   at WinFwk.UIModules.UIModuleForm.ApplyColors(Control control, UISettings uiSettings) in C:\projects\memoscope-net\WinFwk\UIModules\UIModuleForm.cs:line 280
   at WinFwk.UIModules.UIModuleForm.DockModule(UIModule uiModule, DockState dockState, Boolean allowclose) in C:\projects\memoscope-net\WinFwk\UIModules\UIModuleForm.cs:line 150
   at WinFwk.UIModules.UIModuleForm.InitWorkplace(WorkplaceModule workplace, DockState dockState) in C:\projects\memoscope-net\WinFwk\UIModules\UIModuleForm.Designer.cs:line 157
   at MemoScope.MemoScopeForm.MemoScope_Load(Object sender, EventArgs e) in C:\projects\memoscope-net\MemoScope\MemoScopeForm.cs:line 38
   at System.EventHandler.Invoke(Object sender, EventArgs e)
   at System.Windows.Forms.Form.OnLoad(EventArgs e)
   at System.Windows.Forms.Form.OnCreateControl()
   at System.Windows.Forms.Control.CreateControl(Boolean fIgnoreVisible)
   at System.Windows.Forms.Control.CreateControl()
   at System.Windows.Forms.Control.WmShowWindow(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.Form.WmShowWindow(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Furthermore, after this exception, the app looks like this:

Looks like this happens after I run a master build (which writes config data) then run a <IP_ADDRESS> instance, which attempts to load that config file and obviously doesn't support the "new" values.

You're right : there is a bug in release 0.9.9 but fixed in master branch.
I will publish a new release 'RC1' with bug fixes commited since.


[WIP] Contribution Guide

ping me when you want a review

I would take pains in a document like this to point out that kerchunk is not an end-user library, but a power-user tool (end users get the artefacts and may never install kerchunk). Also, that it is far from mature, and it's OK to make major breaking changes.

@martindurant I incorporated your suggestions. Any other thoughts before this is merged?


Provide Docker Image in GitHub Registry

We would like to run this application as a docker container in a kubernetes Cluster and right now we would have to build the image ourselves.
Since GitHub makes it really easy to publish docker images it would be great if this functionality could be added to the pipeline of a release (possibly main branch too).
If you want I can provide a pull request, configuration for making the artifact public would have to be done by the maintainers though...

solved in #125


About the color types

According to the documentation, taking the Border object as an example, it says:

border - Border object.

type - Type of border (line or bg). bg by default.
ch - Character to use if bg type, default is space.
bg, fg - Border foreground and background, must be numbers (-1 for
default).
bold, underline - Border attributes.

And about the colors:

Colors

Colors can be the names of any of the 16 basic terminal colors, along with hex
values (e.g. #ff0000) for 256 color terminals. If 256 or 88 colors is not
supported. Blessed with reduce the color to whatever is available.

I understand that something like:
const border = {
    fg: 0,
    bg: 22
}

Could be similar to:
const border = {
    fg: 'black',
    bg: 'green'
}

But shouldn't it say that fg and bg could also be strings?

Colors can be the names...

@hypersad Exactly, so why does the first quote for the Border object says bg and fg must be numbers?
I'm just curious, because in @types/blessed the same quote is referenced and bg and fg are also defined as numbers.

Could it be outdated? Or, maybe there is some kind of internal converter.

Yep, looks like the colors are mapped and converted on lib/colors.js. Also referenced on #108.
Thanks for the response. I'll open a PR, though not sure if the project is still actively maintained.


Block breaking issue.

I'm having issues when I hold down the button to break blocks this is happening with mouse and controller.
If I hold down the break button the first block breaks but then next ones don't and keep infinity breaking, if I break the first block let go of the breaking button and break the next everything works. This happens only in survival creative works just fine and I'm pretty sure servers also work just fine. I'm using Fedora Silverblue 38 and Controlify if that matters.

If you remove Controlify does the issue stop? If so, please report to them. I'm currently semi-busy so i'll get back to this matter in a bit

I've tried it doesn't work it doesn't seem to happen on the alpha build of fabulously optimized I've compared the mods and all seems ok so I don't know.

Can I send a screen capture to your email or something I would here but 10mb limit

https://wormhole.app/bjrQn#UuAKo38e1c8_hYGz6k6Ajw

I know it's not registering because the controller vibrates whenever I start breaking a block as for isolating the mod I've tried so I decided to disable all the mods and it was still happening I thought it might have been a 1.20 issue so I loaded up a completely stock instance but it wasn't happening

yes

Then i don't know what might be going wrong,

I fixed it I completely removed prism from my .var (flatpak) and install the latest 1.20 SO

good to hear it's resolved!


expose import_module

i wanted to be able to import modules within the binja context remotely for my scripts, so we need to expose this. technically, we can do it through eval, but I think this is neater. since we already allow eval, this does not meaningfully change the attack surface, lol.

sure, i made the change; can this actually work to reload plugins?

sure, i made the change; can this actually work to reload plugins?

yes, but it has caveats

merged, thanks for the PRs @redthing1


Enhancing CosmosTemplate to Support Multi-Tenancy at a DB Level

Description
This PR adds support for multi-tenancy at a DB level via the CosmosFactory. There is a test case added which shows how the user can extend CosmosFactory and override getDatabaseName() in order to dynamically set the DB being used by CosmosTemplate and repositories when making calls. Integration test coverage was added for this new feature.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/check-enforcer override


Passing JSON data url instead of data

Is there any plans to add dataurl instead of data so that d3.json can be called to fetch json at render time.

Hi,
I would like to know how do you pass json data as url. Can you give me an example. Because instead of sending the data in the code, I want to send it as a json file. Is it possible. I really appreciate your help.
Thanks!
Regards,
Sandeep


Startup failed error message

In case of Redis startup failed I get "Can't start redis server. Check logs for details." message.
What logs should be checked? Logs of Redis? Then it would be better to add path to the temporary folder with logs. Error message should be more concrete.
Thanks

Hi,
I know that error pretty well, it's a known problem for which I'm not to sure what the lib should do.
For now, you have the Redis.errors() method which will return you an InputStream containing redis standard output. It does the trick for basic problem, and I hope it will help you.
Concerning the temporary path, the problem comes from the fact that it is deleted when the JVM is terminated. So unless you have a breakpoint somewhere in your code, I'm not too sure about its usefulness.
Feel free to add your though on that, I don't have much time for this library unfortunately but any contribution are welcomed 😃

Okay. Thank you for the response. I will look into it.


Migration to landscape2

Hi! 👋
We've been working on a new version of the landscape generating software, landscape2. Landscape2 relies on the same landscape.yml file as the main data source, so nothing changes regarding adding or updating entries in the landscape.
The CNCF landscape has already been successfully migrated to this new version, and we'd like to start migrating more landscapes 🙂
We are already building the ASWF landscape using landscape2, you can check it out at https://aswf.landscape2.io/. It'd be great if you could give it a try when you have a chance and, whenever you are ready, we can proceed with the migration.
The process is very simple and would involve the following steps:

[ ] Adding/updating some DNS entries [1]
[ ] Stop background automated processes that write to this repository (CNCF bot)
[ ] Unlink this repository from Netlify
[ ] Update README and clean up some files no longer needed in this repository
[ ] Setup the landscape2-validate-action to validate the landscape.yml file on PRs (optional)

We can take care of the last 4 points, you'd only need to update the DNS entries.
Landscape2 supports embedding a view with items in a category/subcategory in another website, but it works slightly different than landscape1. If parts of this landscape are embedded using this mechanism on other websites, we'd appreciate if you could let them know about how it works now.
Please ping me if you have any question 😉
[1] We’d need to know the hostnames you'd like to use to prepare our end to listen on them before switching the DNS (i.e. landscape.aswf.io). Once we are ready we'll provide you with the destination for the DNS entries so that you can update them.

Hey - sure let's flip the switch. Should I do the DNS switch before you make your changes?

Awesome! What hostnames would you like to use? We need to prepare our end to listen on them first :)

I'd keep the same as today - landscape.aswf.io and l.aswf.io - would that
be ok?
On Thu, Jan 25, 2024 at 8:55 AM Sergio Castaño Arteaga <
@.***> wrote:

Awesome! What hostnames would you like to use? We need to prepare our end
to listen on them first :)
—
Reply to this email directly, view it on GitHub
https://github.com/AcademySoftwareFoundation/aswf-landscape/issues/782#issuecomment-1910610065,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACIOIJ2MLZGHTM3L4HMGWTYQKFBXAVCNFSM6AAAAABCJCILQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQGYYTAMBWGU
.
You are receiving this because you were assigned.Message ID:
@.***
com>

Sure 👍
Could you please create the following CNAME entries? We need them to prove that we are allowed to setup a certificate for those subdomains.
_bb002d7316febc484cebe964c9bebf5a.landscape.aswf.io. -> _26cff91aa15257daccd238586863b2c3.mhbtsbpdnt.acm-validations.aws.
_2554178cb8ac7be21d1a8b0d467ba007.l.aswf.io. -> _50d340e0f29bdb49c177628b07886fc2.mhbtsbpdnt.acm-validations.aws.

Once they are ready I'll update the list of hostnames and will share with you the new destination of the existing subdomains.
Thanks!

Sure! I put in an IT request for that now. Will let you know once it's done.
On Thu, Jan 25, 2024 at 12:48 PM Sergio Castaño Arteaga <
@.***> wrote:

Sure 👍
Could you please create the following CNAME entries? We need them to prove
that we are allowed to setup a certificate for those subdomains.
_bb002d7316febc484cebe964c9bebf5a.landscape.aswf.io. -> _26cff91aa15257daccd238586863b2c3.mhbtsbpdnt.acm-validations.aws.
_2554178cb8ac7be21d1a8b0d467ba007.l.aswf.io. -> _50d340e0f29bdb49c177628b07886fc2.mhbtsbpdnt.acm-validations.aws.
Once they are ready I'll update the list of hostnames and will share with
you the new destination of the existing subdomains.
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/AcademySoftwareFoundation/aswf-landscape/issues/782#issuecomment-1910702716,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACIOIMEDL5JZ6F5U53H4EDYQKLH7AVCNFSM6AAAAABCJCILQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQG4YDENZRGY
.
You are receiving this because you were assigned.Message ID:
@.***
com>

DNS entries are complete - let me know next steps. Thanks!

Awesome! Our end is now ready to serve the landscape on landscape.aswf.io.
You can update the DNS record whenever you are ready 🙂
CNAME landscape.aswf.io -> d6o8hzzlhxo5z.cloudfront.net
I understand l.aswf.io is an HTTP redirection to landscape.aswf.io, so that should be OK. We have prepared our end for both hostnames, so if you want to replace the redirection at some point that's fine too.

No worries!
We have something similar, please take a look at https://github.com/cncf/landscape2?tab=readme-ov-file#embeddable-views (https://aswf.landscape2.io/embed-setup) 🙂

Nice! What is the best way to migrate the previous embeds over? I'd like to keep the view consistent from before if possible.

You have a few options to customize the embed view, hopefully that will help you make them look similar 🙂
Regarding the migration: one way would be to update the embeds before migrating the landscape, by using the aswf.landscape2.io hostname that's still on. Then you can switch the DNS records and once it's done you could update the embeds urls to use landscape.aswf.io. This way there would be no down time.

I think it can be already setup to look very similar on the new one, except for the logos and font size. Please take a look at the example below (prepared using the embed-setup view I shared before):
https://aswf.landscape2.io/embed/embed.html?key=aswf-member-company&headers=true&style=clean&size=md&bg-color=%23ffffff&fg-color=%23000000

And the logos and font size is something we could make configurable 🙂

Please note that the url I shared is the embed view configurator. You can adjust a bit the customization options available and once you're ready you can copy the embed code generated (available at the bottom). In this case, I selected the clean style, selected the corresponding members category, all subcategories and adjusted the background and foreground colors. And the result is almost identical to the members example you shared (except for the sizes mentioned).

That is much closer - thanks! But being able to pass in CSS like before ( see https://github.com/cncf/landscapeapp/blob/5d942291539d4cf03c0aa0fab1457561d3a66416/README.md#adding-css-styles-for-an-embedded-landscape ) would be most ideal to get the full look and feel aligned. Could that be accommodated?

BTW the logos size is already configurable 😅 This one should look even closer https://aswf.landscape2.io/embed/embed.html?key=aswf-member-company&headers=true&style=clean&size=xl&bg-color=%23ffffff&fg-color=%23000000 (feel free to play with the configurator to find the best match).
Regarding passing custom CSS, we don't have plans for that at the moment but we'll consider it 🙂

Thanks - I think custom CSS is a huge blocker for us. We will need to pause on further migration until that can be addressed.

Sure, no problem 👍
I'd like to understand better what's the huge blocker at the moment for the case you shared.
The previous landscape provides this embed view:
https://landscape.aswf.io/pages/members
And the new one provides this one (the logos size can be adjusted if needed):
https://aswf.landscape2.io/embed/embed.html?key=aswf-member-company&headers=true&style=clean&size=xl&bg-color=%23ffffff&fg-color=%23565656
I may be missing something but the main difference I see is just the header font (size/family). And we'd be happy to make that configurable (or maybe some other parts that I'm missing at the moment). We've switched other embedded views on the cncf.io and k8s.io sites and it's been fine so far.
Before going down the CSS route, we'd like to understand first a bit better what parts will need customization and how can we make it easier for users to customize them. Asking users to understand what styles they need to tweak -and how- looks more complex, and probably will require individual support on many cases. So our goal was to provide a self-service configurator that allows them to create customized embedded views using a simple UI. We'll consider the CSS definitely, but if there is a way to do it that provides a better experience, we'd like to give it a try as well.
In addition to this, we've also added recently an API that allows consuming the landscape data easily to build custom views, just in case it helps 🙂

Hey @tegioz, I appreciate your thoughts and suggestions on this.
Some examples of where you'd need more that just the configurator are:
https://www.aswf.io/members/ - see how closely the theming aligns with the overall theme
https://landscape.openmainframeproject.org/pages/members?style=body{background-color:white;}.borderless-mode .mosaic .logo{height:100px;}.sh_wrapper span{font-size:40px!important;text-decoration:underline;color:black;}%23embedded-footer{display:none;}.borderless-mode .mosaic-wrap { padding: 10px 20px}div[data-wrapper-id%3Dopen-mainframe-project-member-company-platinum] .items-cont%3Aafter{content%3A" %2B1"%3B}div[data-wrapper-id%3Dlf-energy-member-general] .items-cont%3Aafter{content%3A" %2B3"%3B}div[data-wrapper-id%3Dlf-energy-member-associate] .items-cont%3Aafter{content%3A" %2B3"%3B} - this is a view I used for creating a drop in ready list of members for our overview decks. I'd need to do a bunch of tweaks to make the view otherwise as we want.
The API route could be an alternative, but this does add an extra layer for us to build to replicate the functionality. I could see advantages to that for something like a website ( embeds, while more convenient, are a bit of a cludge and slows the site load ) and maybe even being a layer for caching when the landscape is down, but other views and times we can't make those adjustments then require a more complex solution.
Hopefully this context helps!

I think you'll be able to handle both cases with the configurator. We just need to allow some control over the fonts, alignment and logos spacing. All generic stuff that will be useful to other integrators, so it's not a problem to extend the configurator a bit (up to a reasonable point).
We need to take care of a few things but we'll get back to you as soon as it's ready. The result should be good enough so that it's barely distinguishable 🙂
Going back to the CSS route and looking at the example url you shared:
When something like that is encouraged/documented, the structure of the code becomes part of the contract, like if it was an API. Those styles you defined may be relying on a given html tag, element id, class, etc. Any change to any of those entities could break part or all the work you did. IMHO this seems fragile and would lead to not being able to evolve the embed page as we could be breaking any of -potentially- many integrations. The internal representation of that page is an implementation detail that could change at any time (new framework used, some redesign, etc), so it should not be relied upon.
Please note that allowing injecting styles is easier than what we are doing. But IMHO it's not the right approach, but a potentially problematic and restrictive one. That's why we are a bit hesitant about it.
Let's work together to get you a bit closer to what you want, but always keeping in mind that the final result may not be a pixel-perfect representation of what you would like to see 😇

Hi @tegioz - I'm completely fine with removing the CSS gymnastics if these can be accomplished via the tool. Let's see how close you can get and we can go from there - thanks for all the work here!

Please take a look 🙂
https://aswf.landscape2.io/embed/embed.html?key=aswf-member-company&headers=true&category-header=false&category-in-subcategory=true&item-name=false&title-uppercase=true&title-alignment=center&title-font-family=sans-serif&title-font-size=24&style=clean&size=xl&items-alignment=center&items-spacing=30&bg-color=%23ffffff&fg-color=%23b09a5e
You can fine tune it from the embed configurator if needed.

View looks great - thanks!
But when clicking on a logo, it opens up a whole new page. Could it instead work like before where it would open in the current page?

Awesome!
When you click a logo, it takes you to the full landscape. We did this intentionally to drive traffic into it and let more users know about it. But we'd like to add that back as an option at some point.
Ready to do the switch? 🙂

TBH I don't know at the moment. We still have a few things pending on the landscape, plus quite a few more on the other projects we maintain. And we're working on a new project as well! 😅
I was hoping that the benefits of having the new landscape would outweigh the missing bits, but I'll leave that up to you. Looking forward to seeing the ASWF landscape in v2! 🙂

Got it - yeah, I would at least like to wait till next week as there is some legwork for me to do on the embeds, and we have an event on Thursday, so I don't want to do a cutover until after the event. I think the feature would be nice to have, but probably not a blocker at this point. I appreciate all your help!


Docs

Any plan to create a proper docs page?

what do you need to be documented ?

yes,some more documentation on how to enable undo,redo etc.,

well, guys, you can check the react-sketch2 which i made and many bugs fixes too


Can you provide an MQTT client?

Can you provide an MQTT client?

Planned, will also build a high performance benchmark tool with it.


Fix some UI issues

There are various sections on the homepage where the UI can be improved via CSS styling. Some of these are:

The hero section.
The team section (on hover).
The contact section and more.

I'm working to fix these issues and will create a PR soon.

This issue contains too many fixes and will be closed when i merge in the fixed footer section. Try to make small incremental issues that can be fixed.


Update the code after resolving the bugs

@MAYALURI-ANUSHA
Update the code and merge to main branch integrating all the features

The code has been uploaded


Curve lending: Update stop bot functionality

https://www.notion.so/volumefi/EPIC-07-27-23-Curve-lending-bots-e22990bbc1904f34b0d4eaf5dd77ade0?pvs=4#b2aefa8a6ed1470781804c087350a24b
Blocked by https://github.com/VolumeFi/paloma/issues/908

Design are here: https://www.figma.com/file/ClniQyKFqN1hSpWizV5O4A/Paloma?type=design&node-id=12866-283304&mode=design&t=q8K9dUxC1SRdXwlf-4


Add Nested Metadata access possibilities

In metadata we can have several nested maps, we should come up with some interface for Queries? to get value through several keys e.g. GetValue(Vec)


More details required from the documentation

Category

[ ] Question
[ ] Typo
[x] Additional article idea

I went through the steps in this article: https://docs.microsoft.com/en-us/sharepoint/dev/solution-guidance/introducing-the-pnp-provisioning-engine
It's mentioning that I can run 2 commands, one to get the provisioning template, the other to apply the provisioning template. I created a site, applied a logo, created 3 pages, and linked to these 3 pages from the homepage web parts. When I used the steps in the article, I got a broken site.
After further reading, I found out that I need to use tokens, which is not mentioned in this article and I couldn't find more details somewhere else on how to use these parameters for these commands. Where can I find more in depth information on how to use the provisioning engine. It's too hard to just figure it out by reading this article.

You can find all information about the provisioning framework in the docs (https://docs.microsoft.com/en-us/sharepoint/dev/solution-guidance/pnp-remote-provisioning) & on the project sites>


Handle trailing newlines for broadcast uses

Adds an extra trailing newline for broadcast use groups, exemplified by this diff:

Essentially, this PR handles the situation brought up by @utaal-b in #53. To lead to good output, this required handling a few special cases:

presence of multiple broadcast use items in the same fn
comments between those items
top-level broadcast use items

I've handled each of these cases to produce good output. Additionally, the snapshot test in this is is an expanded version of what @utaal-b proposed in #53.

NOTE: This PR causes an update to the vstd snapshot. This is intentional (due to style change), but will require coordination on https://github.com/verus-lang/verus when the new version of verusfmt is released. This should not block merging this PR, but yeah, from a release standpoint, will need some coordination to prevent CI failures. I'll open a PR there soon (EDIT: https://github.com/verus-lang/verus/pull/1062)

Good question. With this PR as a blueprint, adding such code to other similar things should be fairly straightforward, but I think we should refrain from adding for such situations until we see actual code that would benefit from the additional newlines.

Thank you for working on this. One concern: I don't think rustfmt makes changes to add/remove empty lines in a block (as those tend to be introduced as a way to logically group/separate chunks of code by the developer), I'm a bit uneasy about departing from that general principle.

Ah! I suspected this might be the case but didn't know about the attempts you've already made. Thanks for the write-up on the challenges and trade-off.
This choice makes sense to me, then. Thanks!


Use :: for library separation

https://google.github.io/styleguide/shell.xml#Function_Names suggests to use :: separator for libraries separation, so we can end up with something like:
ct::os::print_logs "some"

instead of
ct_os_print_logs "some"

I wanted just to hear more opinions, not that I'd push on that either. Thanks for the feedback so far, I'd keep this open to see more feedback, but I agree that without a good reason to change it, it's not worth it.

In my point of view, portability of this project isn't so important. But I'm also thinking if the readability of the new format is so better, that it makes sense to rewrite tests for several images...

Imo the readability improves by a bit but I do not think it is worth the change, considering we would need to change all of the images to the new format (or keep both for compatibility I guess)

I agree it's not worth it, closing.


Dummy test PR

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_c8n3qbvypf/clone` failed. (See above for error)
The following problems have been found:
===== ERRORS =====

clone/recipe/meta.yaml:22: patch_unnecessary: patch should not be in build when source/patches is not set
===== Final Report: =====
1 Error and 0 Warnings were found


perhaps add clearCachedData method

In my dbus experiments, I've found https://github.com/adafruit/Adafruit_Python_BluefruitLE . They have a method to clear the cached bluetooth data, and I wonder if folks would find that method useful in noble.
Here's a link to the CoreBluetooth provider (aka binding) https://github.com/adafruit/Adafruit_Python_BluefruitLE/blob/master/Adafruit_BluefruitLE/corebluetooth/provider.py#L300

That functionality it rarely needed and could potential mess up someone's Mac.

I think there may be some need for this, I just got bit by this today and spent a while trying to figure out what's going on.
This is the current behavior of noble 1.3.0 on my mac:

Program a BLE node to advertise "Name1"
Run noble script to list names (below), reports "Name1"
Kill noble script
Re-program device to advertise "Name2"
Run noble script, reports "Name1"
Kill noble script
Run noble script, reports "Name2"

This is consistent, reproducible, and very confusing.
var noble = require('noble');

noble.on('stateChange', function (state) {
	if (state === 'poweredOn') {  noble.startScanning();  }
});

noble.on('discover', function (peripheral) {
	console.log('Found: ' + peripheral.advertisement.localName);
});

when a peripheral state on connected has state == 'error' , i do need to clear the cache else it never ever detects again, can i just do
delete noble._peripherals[uuid] ?


\Omega is not rendered

A super weird bug 🤣: \Omega is not rendered. A minimal working example:
\begin{document}
\begin{tikzpicture}
\draw (0,0) node {$x\omega\Omega\Gamma$};
\end{tikzpicture}
\end{document}

The result is $x\omega\Gamma$, the $\Omega$ is missing 😂

Weird! I'll try to look into this when I have time.

Do you know whether this happens with any other symbols?

I tested common greek letters and math symbols, and found another one: \otimes.
Unlike wrong syntax or unsupported packages like \mathbb, which break the output image, \Omega and \otimes take up some space but are not rendered.

Thanks, that was useful info!
It turns out that \Omega and \otimes were represented by the "soft hyphen" character in unicode, which is invisible. I came up with a hacky workaround where I patch the fonts and move the soft hyphen glyph to a different character.
This is now solved in 0.4.0.


Does ReactHighstock do everything ReactHighchart does? ex Pie chart?

Q: Can we use ReactHighstock for chart types not included in the available plotOptions listed here? http://api.highcharts.com/highstock#plotOptions
According to http://api.highcharts.com/highstock#chart.type ...
The default series type for the chart. Can be any of the chart types listed under plotOptions. Defaults to line.
I have working PIE using ReactHighchart, but same config does not work as prop to ReactHighstock. I see I can have both ReactHighstock and ReactHighchard components active on same page, but I worry this is additional bloat to the codebase (because highcharts code is included in highstock afaik).
Thanks for insights!

Forgot to say, the error I get was cannot set property 'options' of undefined thrown somewhere in the Highstock code.
Somewhere... because it is minified/obfuscated (maybe by the incomprehensible magic of my webpack setup... but probably it was minified already). Is there a way to run with underlying highchart/highstock codebase unminified for debugging? Appreciate any tips still always trying to learn.
Great work so far & thanks much :100:

My understanding is that Highstock is has a superset of abilities of Highcharts, but I'd recommend you confirm it with Highcharts people.
This should help you if that is the case:
https://github.com/kirjs/react-highcharts#passing-highcharts-instance-manually

Feel free to reopen


setFormula() not working

Step to reproduce:

Open http://www.pigno.se/barn/PIGNOSE-Formula/ Basic example

Execute in console
var instance = $('.formula.formula-basic').data('formula');
var formula = instance.getFormula();
instance.setFormula(formula.data);

It seems to do something only when input is focused

Execute in console
setTimeout(function(){ instance.setFormula(formula.data); }, 3000);

Click on formula input and wait

Because setFormula() parses the input json, transforms it to array of strings and each char is inserted separately, we can't use custom items.
Our custom item is and UUID with Title. We save formula json but after page reload it fails to restore.

Before form save
After page reload

Also there is no way to provide a custom render callback for custom items.

I created a formula builder https://github.com/arteniioleg/johan-formula

Any update on this issue?  I would like to know how to populate the editor with a saved formula containing variables.

@doogie2301 Why this plugin doesn't fit your needs?

Thanks @arteniioleg, while that is an interesting plugin, it just isn't very intuitive for the type of users I have.  Plus I need to be able to insert variable placeholders.

@doogie2301

You can add support for placeholders by creating a new element type (I did that in my private project).
It's not intuitive because you have to press Enter after finishing typing a number or operator?

@arteniioleg, I'd rather not clog up this thread with something that isn't relevant to the @KennethanCeyer formula plugin.  we can discuss why I can't use your plugin further on your repository if you like.

Ok. I will delete my previous comments related to the other plugin. And this comment too.

@arteniioleg can you check the latest version?
thus all logic have been improved
const instance = $('.formula.formula-basic').data('$formulize');
const expression = instance.getData();
instance.setData(expression.data);

Using the latest version, for me, it is still not possible to restore custom items using setData().
Operators and number values are restored fine, however.
Is there a way to restore custom items (like in the demo) from a stored json string?


oidc support specify hmac key

so the routes will be able to share the same oauth flow cookie
What type of PR is this?

"feat(oidc): add oidc hmac secret configuration "

What this PR does / why we need it:
Serveral routes may use the same oidc configuration. eg, the micro services route use different path prefix.
However, their oauth flow cookie can not be shared since the hmac verification will fail if each route use random generated hmac secret. hmac validate
bool OAuth2Filter::canSkipOAuth(Http::RequestHeaderMap& headers) const {
  // We can skip OAuth if the supplied HMAC cookie is valid. Apply the OAuth details as headers
  // if we successfully validate the cookie.
  validator_->setParams(headers, config_->tokenSecret());
  if (validator_->isValid()) {
    config_->stats().oauth_success_.inc();
    if (config_->forwardBearerToken() && !validator_->token().empty()) {
      setBearerToken(headers, validator_->token());
    }
    ENVOY_LOG(debug, "skipping oauth flow due to valid hmac cookie");
    return true;
  }
  ENVOY_LOG(debug, "can not skip oauth flow");
  return false;
}

The OIDC configuration should support use same hmac key for verification, the different route will share the same oauth flow cookie.

@yowenter have you tried creating one SecurityPolicy and defining all matches in the same HTTPRoute which the policy can target

@yowenter @arkodg
Ideally, I prefer not exposing HMAC to EG API since it's just an implementation detail of the Envoy OAuth2 filter.
This reminds me of another potential issue: Per-route OIDC probably doesn't work because the scope of token and hmac cookies set by the Envoy OAuth2 filter is at the root path. So if two HTTPRoutes are under the same host, and two SecurityPolicies with different OIDC configurations target these two HTTPRotes, their cookies will overwrite each other. This is because the cookies are scoped to the same domain and path "/".
https://github.com/envoyproxy/envoy/blob/3d67a3f940db59057a6f22db81fae8ecf2bcf5d3/source/extensions/filters/http/oauth2/filter.cc#L41

@yowenter have you tried creating one SecurityPolicy and defining all matches in the same HTTPRoute which the policy can target

@arkodg  good point, I may try later.


This MathJax code is working in the math and physics stack exchange but not working in GitHub. Why?

Issue Summary
The following code is working perfectly fine in the math and physics stack exchange but not working in Github even though it is using the same MathJax. What is the problem here?
$$\boxed{ \begin{aligned} \mathcal{L}=&-\frac{1}{4} B_{\mu \nu} B^{\mu \nu}-\frac{1}{8} t r\left(\mathbf{W}_{\mu \nu} \mathbf{W}^{\mu \nu}\right)-\frac{1}{2} t r\left(\mathbf{G}_{\mu \nu} \mathbf{G}^{\mu \nu}\right) &{\text{(U(1), SU(2) and SU(3) gauge terms)}}\\ &+\left(\bar{\nu}_{L}, \bar{e}_{L}\right) \tilde{\sigma}^{\mu} i D_{\mu}\left(\begin{array}{c} \nu_{L} \\ e_{L} \end{array}\right)+\bar{e}_{R} \sigma^{\mu} i D_{\mu} e_{R}+\bar{\nu}_{R} \sigma^{\mu} i D_{\mu} \nu_{R}+(\text { h.c. }) &{\text{(lepton dynamical term)}}\\ &-\frac{\sqrt{2}}{v}\left[\left(\bar{\nu}_{L}, \bar{e}_{L}\right) \phi M^{e} e_{R}+\bar{e}_{R} \bar{M}^{e} \bar{\phi}\left(\begin{array}{c} \nu_{L} \\ e_{L} \end{array}\right)\right] &{\text{(electron, muon, tauon mass term)}}\\ &-\frac{\sqrt{2}}{v}\left[\left(-\bar{e}_{L}, \bar{\nu}_{L}\right) \phi^{*} M^{\nu} \nu_{R}+\bar{\nu}_{R} \bar{M}^{\nu} \phi^{T}\left(\begin{array}{c} - e_{L} \\ \nu_{L} \end{array}\right)\right] &{\text{(neutrino mass term)}}\\ &+\left(\bar{u}_{L}, \bar{d}_{L}\right) \tilde{\sigma}^{\mu} i D_{\mu}\left(\begin{array}{c} u_{L} \\ d_{L} \end{array}\right)+\bar{u}_{R} \sigma^{\mu} i D_{\mu} u_{R}+\bar{d}_{R} \sigma^{\mu} i D_{\mu} d_{R}+(\text { h.c. })&{\text{(quark dynamical term)}} \\ &-\frac{\sqrt{2}}{v}\left[\left(\bar{u}_{L}, \bar{d}_{L}\right) \phi M^{d} d_{R}+\bar{d}_{R} \bar{M}^{d} \bar{\phi}\left(\begin{array}{c} u_{L} \\ d_{L} \end{array}\right)\right] &\text{(down, strange, bottom mass term)}\\ &-\frac{\sqrt{2}}{v}\left[\left(-\bar{d}_{L}, \bar{u}_{L}\right) \phi^{*} M^{u} u_{R}+\bar{u}_{R} \bar{M}^{u} \phi^{T}\left(\begin{array}{c} -d_{L} \\ u_{L} \end{array}\right)\right] &{\text{(up, charmed, top mass term)}}\\ &+\overline{\left(D_{\mu} \phi\right)} D^{\mu} \phi-m_{h}^{2}\left[\bar{\phi} \phi-v^{2} / 2\right]^{2} / 2 v^{2} &\text{(Higgs dynamical and mass term)} \end{aligned} }$$
Steps to Reproduce:

Type the given code in GitHub markdown and see. Simpler codes work properly for example:

$$\boxed{G_{\mu\nu}+\Lambda g_{\mu\nu}=\dfrac{8\pi G}{c^4}T_{\mu\nu}}$$

Random bystander here. Did you file an item at https://github.com/github/feedback/discussions? Since this is not a MathJax issue per se (e.g., it works on mathjax.org#demo), it seems more appropriate to start there and let the GitHub team figure out if there's actually a MathJax bug - rather than taking time away from the MathJax team to track down GitHub bugs.

@pkra I think it is related to this issue https://github.com/github/markup/issues/1547 . So I am closing here.


adding snow and cluster api upgrade rollout strategy

Issue #, if available:
https://github.com/aws/eks-anywhere/issues/6719
Description of changes:
Adding UpgradeRolloutStrategy knobs for workers and control plane to snow provider.
Updated cluster api apibuilder as well since this should be available for all providers. Other providers use templater, while snow uses apibuilder.
Testing (if applicable):
Updated unit tests.
Documentation added/planned (if applicable):
Planning on adding docs on knobs for other providers following the Tinkerbell upgrade strategy format.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


Introduce client support key/value stores to enable large parameter passing to contracts

Implements support for python clients to build encrypted key/value stores. Among the uses, the key/value store enables large parameters to be passed to contracts.
A number of other small improvements are included such as support for replication parameters in the pdo-shell.

There is a problem with having multiple copies of LMDB open in the same python process. Need to fix.


Ensure the changelog is in UTF-8

The default encoding may not be UTF-8, especially for Windows. The "—" between the date and version in the title may be encoded as non-UTF-8 character when different encoding is used, e.g.  windows-1252.

Thanks for this attention to detail.  I've refactored the code, so these changes don't work any more, but I've remade them in #37.


Update CI setup

TODO

[ ] Rebase to master once #6 is merged
[ ] Run example notebooks in CI (need simulator(s) etc.)

Contributor Checklist:

[ ] I have added or updated my entry in the creators.json file
[ ] I have added a changelog entry for my contribution
[ ] I have added/updated documentation for all user-facing changes
[ ] I have added/updated test cases

Reviewer Checklist:

[ ] /azp run LiberTEM/LiberTEM-live-data passed

/azp run LiberTEM/LiberTEM-live

No pipelines are associated with this pull request.

Why not, though?

Why not, though?

Was still missing a private key, which I've now added.  Adding notebook CI (and re-adding doctest support) can also be done in a separate step.

/azp run LiberTEM.LiberTEM-live-data

/azp run LiberTEM.LiberTEM-live-data

/azp run LiberTEM.LiberTEM-live-data

/azp run LiberTEM.LiberTEM-live-data

/azp run LiberTEM.LiberTEM-live-data

/azp run LiberTEM.LiberTEM-live-data

/azp run LiberTEM.LiberTEM-live-data

nbval spewed this error, just for reference. Never got that before, let's keep this in mind:
2021-06-09T15:34:08.4791825Z 2021-06-09 15:33:18 ERROR Failure starting kernel ":nbval-parent-env"
2021-06-09T15:34:08.4792434Z Traceback (most recent call last):
2021-06-09T15:34:08.4793439Z   File "/azp/agent/_work/1/s/.tox/notebooks/lib/python3.8/site-packages/nbval/kernel.py", line 57, in start_new_kernel
2021-06-09T15:34:08.4794135Z     kc.wait_for_ready(timeout=startup_timeout)
2021-06-09T15:34:08.4795201Z   File "/azp/agent/_work/1/s/.tox/notebooks/lib/python3.8/site-packages/jupyter_client/blocking/client.py", line 111, in wait_for_ready
2021-06-09T15:34:08.4796236Z     raise RuntimeError('Kernel died before replying to kernel_info')
2021-06-09T15:34:08.4796832Z RuntimeError: Kernel died before replying to kernel_info

Retrying the job fixed the problem.

A note on performance: right now, both ptychography40 and libertem are installed from git, so creating the tox environments is still quite slow; I expect this will speed up significantly once these two packages are released.

Also, we may need to adjust some timeouts - many of the tests take exactly 10s in setup, which looks like it runs into some kind of timeout.

This should now be ready to be merged, feel free to go ahead any time!


Specify different KMS key

How can I specify a different KMS key alias to be used instead of the default credstash one?

Figured out I can specify the -k parameter when storing a credential.

Option -k does not exist any more. How could you work around this?

yes it does: https://github.com/fugue/credstash/blob/master/credstash.py#L826


Add CamelHumps support

Like atom it is a good feature to move cursor around parts of a camel cased word with Alt+Right and Alt+Left

:+1:

+1

+1
maybe write plugin?

Someone already did. As for the key bindings, you can always change the default.

The plugin works fine!
However, this is such a default functionality (at least in other IDEs).
Shouldn't it be out of the box?

Sorry for the spam folks but in the interest of searchability (because it took me quite some time to find this via other closed issues), I'll add a few keywords here: subword navigation, word navigation with camelCase, move by word break on capitals, wordSeparators.
And FWIW, I am happily using the extension which works wonders, and allowed me to restore sublime text-like functionality using alt[+shift]+left/right/del/backspace.

I think both full-word navigation and subWord (or camelHumps style) navigation are very useful features. Currently I'm also using this plugin https://marketplace.visualstudio.com/items?itemName=ow.vscode-subword-navigation to enable the sub word navigation.
I'm using these key mapping:
[Shift+] Ctrl + Left/Right for full word selection/navigation (default)
[Shift+] Alt + Left/Right for sub word navigation
But I think it should be added to core instead of using it as a plugin as all the popular editors like: Sublime, Atom, Webstorm etc. support it out of the box.

Ou, I really miss that functionality... I'll use the plugin, but this is the base functionality, it should definitely be the part of the editor. Thanks!

i hope have this feature soon, sorry that i can't help anything just only wait for

+1 This feature lacks in vs code but should be standard for any modern file editor related to coding

Just linking this an issue from this very nice extension that adds the functionality to the editor, to see if anyones know if there are more points in the API to hook into allowing it to work in search / rename / other input type boxes: https://github.com/ow--/vscode-subword-navigation/issues/12

Still not done? :(

I switched from another text editor that I had been using for a long time because Visual Studio Code seems to be better.
But now, I'm starting to miss this functionality :/

There currently seem to be three extensions that provide this functionality:
https://github.com/ow--/vscode-subword-navigation
https://github.com/mlewand/vscode-select-part-of-word
https://github.com/maptz/Maptz.VSCode.Extensions.CamelCaseNavigation
This functionality should really be part of core.
FWIW, as a Mac user, shortcuts I'd expect:

(cmd)←→ = beginning, end of line
(opt/alt)←→ = previous, next word
(ctrl)←→ = previous, next part of word

These are the keybindings the "Subword Navigation" plugin (first one linked above) uses.

+1

This feature has been added by the PR #48023 and will be available in the 1.25 release of VSCode (proof).
@alexandrudima seems to be using the issue #46203 as the source of this addition, just to point it out because there is recent activity here, which seems to not know this has been added (and is even in the Insiders already!).

Yes, thanks to @brentwang23 for the PR!
Here is an example for how you can bind the new commands:
{ "key": "ctrl+right",       "command": "cursorWordPartRight",
                                "when": "textInputFocus" },
{ "key": "ctrl+shift+right", "command": "cursorWordPartRightSelect",
                                "when": "textInputFocus" },
{ "key": "ctrl+left",        "command": "cursorWordPartStartLeft",
                                "when": "textInputFocus" },
{ "key": "ctrl+shift+left",  "command": "cursorWordPartStartLeftSelect",
                                "when": "textInputFocus" },
{ "key": "ctrl+backspace",   "command": "deleteWordPartLeft",
                                "when": "textInputFocus && !editorReadonly" },
{ "key": "ctrl+delete",      "command": "deleteWordPartRight",
                                "when": "textInputFocus && !editorReadonly" },

Here is an example for how you can bind the new commands...

@alexandrudima do we need to add this to our user config or will these be added to the defaults when 1.25 is released? If they won't be added to defaults, why? Thanks!

It does have defaults but they're not ideal on Mac.

Nor are they ideal for Windows. Not really sure why Ctrl + Alt + Del was considered a good default for a shortcut key 😕

The fix released in 1.25.0 is great, but one thing is missing, IMO. ALL_CAPS is not treated as two words ALL and CAPS, and subword navigation visits each capitalized letter.

@mccalltd There are some issues opened for that, such as #53645.

Thanks @V-ed I'll track that issue. 👍

Great progress. It'd be nice if this feature were extended to allow sub-word selection with the mouse too as IntelliJ does.


fzf --query flag in shell scripts has potential code injection case

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[x] Mac OS X
[x] Windows
[x] Etc.

Shell

[x] bash
[x] zsh
[x] fish

Problem / Steps to reproduce
The way that the --query flag is used has a code injection issue.
In different shells, different kinds of input characters can cause part of the --query string to get misinterpreted by the shell as another command.
This was first noticed with cmd.exe + clink and clink-fzf, which contains a Lua script for integrating fzf with Clink.
If the --query argument string is not quoted, then text like & echo hello can result in the echo hello part of the query text getting interpreted as a separate shell command, instead of as a query string.
If the --query argument string is quoted, then text like exe" & echo hello can result in the echo hello part getting interpreted as a separate shell command, instead of as a query string.
If the echo hello in the example is replaced by other more dangerous text, then very unfortunate accidental side effect could occur, just from trying to search in the command history.  For example, in cmd.exe rd /s would recursively removes all directories.
This is fixed for cmd.exe + clink by https://github.com/chrisant996/clink-fzf/commit/541536339373b9c86fd5c8fba727d2ab50c041c2.
Other shells could likely use a similar approach of stripping certain problematic characters (especially quotes) and surrounding the reduced query string in quotes.  The specific set of problematic characters is different for different shells.

Thanks for the heads up.
I don't see this as a problem. If this is a problem, then we're saying that every command-line program that takes an arbitrary string as an argument has the problem. i.e. grep, sed, awk, to name a few.
When a script or a program is invoking a shell command, it is its responsibility to properly escape the arguments. You can find libraries for that purpose in many programming languages. They're usually called shellescape.

https://ruby-doc.org/3.2.1/stdlibs/shellwords/Shellwords.html#method-c-shellescape
https://vimhelp.org/builtin.txt.html#shellescape()
https://pypi.org/project/shellescape/

I don't see this as a problem. If this is a problem, then we're saying that every command-line program that takes an arbitrary string as an argument has the problem. i.e. grep, sed, awk, to name a few.

@junegunn No, this is very different from grep/etc because CTRL-R automatically passes the raw input line to fzf --query without escaping or sanitizing the input line first.
Depending on what the user has typed into the shell input line so far, pressing CTRL-R can unwittingly trigger code injection and mistakenly execute part of the input line.
I meant that CTRL-R's usage of --query can trigger a code injection problem. Sorry for being unclear initially.
The fix for CMD involves stripping ", ^, and % first and then surrounding the input line with quotes. Those are the problem characters with cmd.exe, but different shells will require different sanitization strategies. And because fzf uses fuzzy matching, the sanitized query string is still able to do a good job of filtering.

@junegunn The issue is with how shells scripts invoke --query. For example here. Pressing CTRL-R can accidentally execute part of the input line by mistake.

The code is perfectly fine and safe because the varible reference is quoted. bash and zsh don't have the problem you describe. Maybe quoting is not good enough in cmd.exe, but this repository doesn't provide any cmd.exe script.

I see.  Bash explicitly avoids parsing what's inside the expanded "$variable".  If that's the case for all supported shells, then I agree there shouldn't be a code injection issue.
I don't expect fzf to support cmd.exe.  But for context, cmd.exe expands variables and then parses the resulting command line.  It isn't my intent to debate pros/cons of different shell designs; I only want to help ensure safety in each shell.  The external integration scripts for fzf and cmd.exe handle this safely in a cmd.exe-specific way.
Thanks!

Follow-up for those who are curious about the details how this works
I couldn't find any documentation explaining how quoting a shell variable works.  It seemed strangely complicated and problematic for bash to be able to avoid parsing the expanded variable, and my curiosity was piqued.  And indeed, that's not how it works.
So I tracked it down.
Short version
Bash automatically applies escaping when a variable expansion happens within double quotes such as "$variable".
Cmd does not automatically apply escaping; it must be done manually.
I wasn't able to find anything that actually stated that bash applies escaping when variable expansion happens within double quotes; I had to determine it empirically.  Presumably I just didn't know the right search terms to find it.
Long version
I'm using WSL (Windows subsystem for Linux), so each separate terminal is a separate instance of Linux.  They're unaware of each other, so I couldn't use ps to find how bash passes the command line to fzf.  I tried looking in bash source code for the variable expansion code, but finding the code was turning into a time sink.
So I took an "easy way out" and copied the __fzf_history__ function, made a new key binding, and made it spawn a Windows .exe file into.  Then I was able to use Process Explorer to observe the command line.
How variable quoting works in bash
When bash expands "$variable", it automatically internally escapes double quotes by translating them to \".  It also escapes \ into \\, and presumably it might also escape some other characters as well.
When parsing a command line, within a double quoted run \" is interpreted as an escaped double quote, and is translated back to " in output from the parse.  (And \\ and maybe some other characters.)  The surround double quotes are of course discarded during parsing.
The actual command line passed to the spawned process contains both the outer quotes and the escaped inner quotes, for example "abc\" 123 \"xyz".
How command lines are handled on Windows
This is not meant as a critique of how Windows works, nor why it works that way, it is just an explanation of how it is.  There are historical reasons why, and in the context of the time they were made, most of them actually make sense as pragmatic trade-offs.  (Tracking down all the historical reasons is left as as exercise for the reader.)
Synopsis:

On Windows \ is the path separator, so it can't universally serve as an escape character.  The decision was originally motivated by the need for CP/M compatibility where / is the switch character.
On Windows the program startup code for parsing a command line has special parsing (see here and here and here and here) to handle un-escaped quotes and un-escaped backslash, and within un-escaped quotes it also handles escaped quotes and certain instances of escaped backslash.  This approach has quirks in certain edge cases, and because they only manifest in edge cases, everyone forgets they exist (or doesn't even know they exist).
On Windows un-escaped double quotes in the command line are stripped, just like on *nix.
On Windows programs receive an unparsed command line, and the C runtime (or other language runtime) parses it into an array argv[] of arguments.  The original unparsed command line is also available via GetCommandLine().
On Windows there is also an API CommandLineToArgvW() which can parse a UTF16 command line into UTF16 argv[].  Whether any particular language's startup code uses GetCommandLineToArgvW() or uses custom code or uses the C runtime (if the language itself is implemented in C) is an implementation detail of the language.

Knowing how command line parsing working on Windows, we would expect the following:
fzf --query "abc\" 123 \"xyz" should yield

argv[0] = fzf
argv[1] = --query
argv[2] = abc" 123 "xyz

And generally speaking, it does, if an executable program (a .exe file) is spawned.  But if it spawns a cmd shell script, then cmd will parse the command line differently, and things can get tricky.  That's just part of cmd shell scripting, but the trouble is the caller has to format the command differently depending on whether it will be parsed by a cmd shell script, or by an executable program.
Conclusion
Bash automatically applies escaping when a variable expansion happens within double quotes such as "$variable".
Cmd does not automatically apply escaping; it must be done manually.  On Windows, it should be possible to explicitly invoke fzf.exe rather than fzf (to avoid parsing issues with a fzf.bat that might intercept the command), and to quote the --query string, and within the query string to apply escaping to " (and sometimes to \ according to the 2N rule described in the four "here" links cited earlier).


Setup release tag workflow

Setup workflow such that on release tag push, the release binary will be built and uploaded to the release.

Done


'error': 'not_allowed_token_type' with Events API and Socket Mode

Hello everyone! I'm having this error with my Slack app/bot that's preventing it from functioning at all. The error message itself is the same as (or at least very similar to) all the RTM-related problems (like this and this) that were caused by an API change in December 2019.
However, my bot was created less than four months ago (April 2022), and I set it up using the Events API and Socket Mode. Also, as @srajiang said (and as is mentioned in multiple other places), the Events API is a replacement for the RTM API, and so doesn't use it. Hence, this is not a duplicate of #584. The bot worked great until I discovered this error today, when I tried to start it up again after it hadn't been running for a month or two.
The Slack SDK version
slack-bolt==1.13.0
slack-sdk==3.15.2

Python runtime version
Python 3.8.10

OS info
Ubuntu 20.04.4 LTS

Steps to reproduce:
Here's the code to reproduce the problem (after following the setup steps in the tutorial):
app.py
(there's literally nothing else in the directory except .git/ and .gitignore)
import os

from slack_bolt import App
from slack_bolt.adapter.socket_mode import SocketModeHandler

# The app
app = App(token=os.environ["SLACK_BOT_TOKEN"])

# Start the app
if __name__ == "__main__":
    SocketModeHandler(app, os.environ["SLACK_APP_TOKEN"]).start()

Make a new Slack App with Socket Mode and Event subscriptions on
Change to the app directory and run python3 app.py

Expected result:
As per the tutorial and past experience, the app should output that it's running properly.
Actual result:
This error message shows up instead:
Failed to retrieve WSS URL: The request to the Slack API failed. (url: https://www.slack.com/api/apps.connections.open)
The server responded with: {'ok': False, 'error': 'not_allowed_token_type'}
Traceback (most recent call last):
  File "app.py", line 11, in <module>
    SocketModeHandler(app, os.environ["SLACK_APP_TOKEN"]).start()
  File "/home/user/.local/lib/python3.8/site-packages/slack_bolt/adapter/socket_mode/base_handler.py", line 46, in start
    self.connect()
  File "/home/user/.local/lib/python3.8/site-packages/slack_bolt/adapter/socket_mode/base_handler.py", line 31, in connect
    self.client.connect()
  File "/home/user/.local/lib/python3.8/site-packages/slack_sdk/socket_mode/builtin/client.py", line 165, in connect
    self.wss_uri = self.issue_new_wss_url()
  File "/home/user/.local/lib/python3.8/site-packages/slack_sdk/socket_mode/client.py", line 61, in issue_new_wss_url
    raise e
  File "/home/user/.local/lib/python3.8/site-packages/slack_sdk/socket_mode/client.py", line 48, in issue_new_wss_url
    response = self.web_client.apps_connections_open(app_token=self.app_token)
  File "/home/user/.local/lib/python3.8/site-packages/slack_sdk/web/client.py", line 1502, in apps_connections_open
    return self.api_call("apps.connections.open", http_verb="POST", params=kwargs)
  File "/home/user/.local/lib/python3.8/site-packages/slack_sdk/web/base_client.py", line 145, in api_call
    return self._sync_send(api_url=api_url, req_args=req_args)
  File "/home/user/.local/lib/python3.8/site-packages/slack_sdk/web/base_client.py", line 182, in _sync_send
    return self._urllib_api_call(
  File "/home/user/.local/lib/python3.8/site-packages/slack_sdk/web/base_client.py", line 316, in _urllib_api_call
    return SlackResponse(
  File "/home/user/.local/lib/python3.8/site-packages/slack_sdk/web/slack_response.py", line 205, in validate
    raise e.SlackApiError(message=msg, response=self)
slack_sdk.errors.SlackApiError: The request to the Slack API failed. (url: https://www.slack.com/api/apps.connections.open)
The server responded with: {'ok': False, 'error': 'not_allowed_token_type'}

Any ideas about what's going wrong, and how to fix it? If you need any more information, I will provide it. Thanks for your time!

@SamMatzko - Woot, thanks for converting this over into its own issue, and for the code to repro. At first glance, your setup looks fine:
Can I check that your environment variables are set as:

SLACK_APP_TOKEN: Should start with xapp-
SLACK_BOT_TOKEN: Should start with xoxb-

All good @SamMatzko - Thanks for stopping by, and glad we were able to get to the bottom if it!


As an Admin I only want to see Enterprise Promotion results in the dashboard when application year 15/16 is selected, so I don’t see unnecessary information

[ASSESSOR APPLICATIONS] removed category tab "Enterprise Promotion" from top bar since 2017

Please attach trello card https://trello.com/c/Ol6DZNom/455-as-an-admin-i-only-want-to-see-enterprise-promotion-results-in-the-dashboard-when-application-year-15-16-is-selected-so-i-don-t-


Only use github actions for release actions (Closes #25)

Closes #25.

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          186       186
=========================================
  Hits           186       186

@umesh-timalsina if you're good with this I'm going to merge it.

@rsdefever This should be good to go.


Support configuration of access log format

We currently hard-code the format for access logs; it would be better if we allowed this to be configured. It probably makes the most sense to support Apache's format strings.

Do we have any plan on this ?
May be parsing a param from route down to Finagle that will help  ?

It's not on the short-term roadmap AFAIK. Are there specific formats you want to support?

It would be great to include the time taken to serve the request (like the %{UNIT}T flag in apache's format strings)

@bashofmann good idea! FYI, you can get aggregate statistics of that info through the metrics.json endpoint currently (and raw data in individual traces).


Plots do not show within @info

Plot are not correctly rendered currently inside Pluto logs:

This is caused by the IO hack that is used to keep persistence between multiple plot objects in the same cell

Tried the easy fix but stumbled upon a Pluto issue blocking this feature:
https://github.com/fonsp/Pluto.jl/issues/2092

This was fixed in Pluto with https://github.com/fonsp/Pluto.jl/pull/2607, which is merged but still not released

Closed with #21 and now that Pluto v0.19.28 contains https://github.com/fonsp/Pluto.jl/pull/2607


[New Utility] Rebound

Wish to be merged with the main branch if possible.
We've added rebounding utility to the game. You can take a look of this new utility with Rebounding Sample Tank, with bullets ReboundingBall and the obstacle ReboundingBlock. Some infos are written in README.md.
Thanks EDGE-qy for arts & colors.
#144 and #76 are (partly) accomplished in this PR.

The balls cannot rebound if cracking the original block.

LGTM!

Thanks! I've just fixed the format and need for approving.


Crash when bounding sphere is at the origin

var viewer = new Cesium.Viewer('cesiumContainer');
var radius = 1;
var outlineSphere = viewer.entities.add({
    position: new Cesium.Cartesian3(0.0, 0.0, 0.0),
    ellipsoid : {
        radii : new Cesium.Cartesian3(radius, radius, radius),
        fill : false,
        outline : true,
        outlineColor : Cesium.Color.YELLOW,
        slicePartitions : 10,
        stackPartitions : 10
    }
});

This crashes because while it tries to project the bounding sphere center to 2D for the batch table.
An error occurred while rendering. Rendering has stopped.
TypeError: Cannot read property 'longitude' of undefined
TypeError: Cannot read property 'longitude' of undefined
    at GeographicProjection.project (http://localhost:8080/Source/Core/GeographicProjection.js:69:30)
    at updateBatchTableBoundingSpheres (http://localhost:8080/Source/Scene/Primitive.js:1285:39)
    at Primitive.update (http://localhost:8080/Source/Scene/Primitive.js:1776:13)
    at PrimitiveCollection.update (http://localhost:8080/Source/Scene/PrimitiveCollection.js:365:27)
    at PrimitiveCollection.update (http://localhost:8080/Source/Scene/PrimitiveCollection.js:365:27)
    at PrimitiveCollection.update (http://localhost:8080/Source/Scene/PrimitiveCollection.js:365:27)
    at updateAndRenderPrimitives (http://localhost:8080/Source/Scene/Scene.js:2749:27)
    at executeCommandsInViewport (http://localhost:8080/Source/Scene/Scene.js:2610:13)
    at updateAndExecuteCommands (http://localhost:8080/Source/Scene/Scene.js:2473:13)
    at render (http://localhost:8080/Source/Scene/Scene.js:3009:9)

Also, setting scene3Donly: true does not fix the issue.  Should we be skipping this step if scene3D only?

Unless I'm remembering incorrectly, Cesium has always had issues drawing data at the WGS84 origin because of the discontinuity there.
That being said, we can probably skip some of the work in updateBatchTableBoundingSpheres when in 3d only mode, but I'm not positive you won't immediately hit another issue related to the discontinuity.

The only reason it's a problem is because it's trying to convert (0,0,0) into a cartographic and doesn't know how to do it

Yes, I know that, but there are lots of other areas of the code that would end up trying to do the same calculation, so skipping it here might still cause a conversion failure elsewhere.

Just adding my :+1: to this issue: We're developing an app with Cesium that requires drawing rectangles that may be globally symmetrical, resulting in a center of (0,0,0) to updateBatchTableBoundingSpheres. I created an SSCCE (sscce.org) using the sandcastle app that shows this error from drawing a rectangle. Comment   scene3DOnly: true, line to fix it, but we'd prefer to keep our memory usage low!
https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/index.html#c=bVJNT9wwEP0rVi4EKTjZoooqDauK5VAkKioqcSF7cJzZMKozXtlOIK347zgJuyRNL9b4zed7M60wrEV4BsMuGcEz24DFpuYPAxaeyOG70eQEEpiTiP3NiTErgeD8+o5UlzJnGoh6VBDWwqGmlO2EsiNYCAu3ogPzE+VvMFPXrlHKSgNAV41z87QKtNTlPP5J17CMRNrpK/0yhUi0WA2TfAe1X6Z8+G/I+vFlb9obQodCqe4BLRYKphkD4R9+oCULCwrkWKtEKZyeeR3WoLx0H9jr6decWq97UegXr/rj2epLErGzC/8M1kWyfY8wvrCgSsG9KFGQne/o/uDlO6Pra6i8kjbsm7Kh9mOyjUZjdTA+HYzzbU79HL7PsGkO5Dx7sFyUZTjsGMuU5cFxhDx4l66G/+HHfzpeCGNSa1MiCQc2XTCJxhh/LmC85umU10YrbcKE93ocn4R/Ph2SXkcJgyjIrOsUrMdK37Dea+NYY1TIeeyg3qu+dVw0fmGOS2t7vll8SMpKbD3Hyzz458bzgEklrPWe/kB/4R/PcZ3FPn6WprSnQtVdC0aJrg95Wq1vR5BznsX+u8xyWqtCmEnFNw

Here's the problem code: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Scene/Primitive.js#L1395-L1400
Firstly, we should skip computing the 2D bounding sphere when scene3DOnly: true if possible.  And there has to be some way to project a bounding sphere centered at (0,0,0) to 2D.  Can we pick something like  longitude: 0, latitude: 0, height: -Ellipsoid.WGS84.x as the Cartographic to project?

@hpinkos Thanks for your ongoing research in to this issue!
I don't think you can do much else than picking an arbitrary lon/lat when converting from "the center of the Earth" to lons and lats :man_shrugging:

@hpinkos thanks so much for getting a partial fix merged! :bowing_man: I noticed Cesium is doing monthly-ish releases -- do you think this will make it in the July release? :crossed_fingers: :)

@MattF-NSIDC yes, we release Cesium the first business day of every month.  We're working on putting together the 1.47 release now.  It does include this partial fix and it will be available later today =)

Thanks again for your help -- I'm able to use scene3DOnly true again with 1.47 :)

Great @MattF-NSIDC! Glad that worked for you =)

Forum post with related problem when Viewer.zoomTo() target's bounding sphere is centered at (0, 0, 0).

No longer crashes

Congratulations on closing the issue! I found these Cesium forum links in the comments above:
https://groups.google.com/forum/#!msg/cesium-dev/771Z16fIOJQ/pP3yMfbNAgAJ
If this issue affects any of these threads, please post a comment like the following:

The issue at https://github.com/AnalyticalGraphicsInc/cesium/issues/6365 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.


Import internal wiki pages into the github wiki

In the interest of transparency, import/convert all internal wiki pages regarding ohcount4j to the github wiki: https://github.com/blackducksoftware/ohcount4j/wiki

https://github.com/blackducksoftware/ohcount4j/wiki/Ohcount4J-Open-Source-Management-Plan

Moving the project to archive status. Therefore, closing all issues.


Increased HAProxy server and client timeouts

Increased HAProxy server and client timeouts from 30 seconds to 300 seconds to address issues with HTTP 504 errors on long-running API calls.

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

ok to test


Add note about typescript module augmentation

If the declaration is in a .d.ts file instead then you get the following error:

Module '"valtio"' has no exported member 'proxy'.ts(2305)

Here's a code sandbox that illustrates the issue:
https://codesandbox.io/s/react-typescript-forked-8ijjyy?file=/src/App.tsx

Hi, thanks for the suggestion.
https://codesandbox.io/s/react-typescript-forked-63t5ic?file=/src/decs.ts
I tried renaming to *.ts, but it still shows the type error.
How did you solve the issue?

I didn't do anything special to solve the issue. In my actual project valtio simply moving the declare module "valtio" to a js/types.ts worked fine. I'm not sure why it's not working in codesandbox.

Hmm, okay, so I did some more trials. Looks like what's important is if you import the fine or not.
https://codesandbox.io/s/react-typescript-forked-tmmij0?file=/src/decs.d.ts
See that ☝ , and it works with *.d.ts.

what i see is that, this augmentation should be "augmentation"
when add augmentation code in a .d.ts file, vscode complains that "can not find export proxy from valtio".
I solved this by add such code to app entry index.tsx
// augment
import 'valtio'
declare module 'valtio' {
  function useSnapshot<T extends object>(p: T): T
}

https://www.typescriptlang.org/docs/handbook/module-resolution.html
I think some configs in tsconfig.json would solve the issue too even with d.ts.
Can anyone investigate? Maybe this? https://www.typescriptlang.org/tsconfig#paths

my local environment

I guess vscode is confusing the declare statement is

a "module augmentation" https://www.typescriptlang.org/docs/handbook/declaration-merging.html#module-augmentation
or "ambient modules" https://www.typescriptlang.org/docs/handbook/modules.html#ambient-modules

csb
https://codesandbox.io/s/react-typescript-forked-8y04wn?file=/src/decs.d.ts

i deleted the import type {xx} from './desc.d.ts'
with / without the import 'valtio', no errors occurs

weird.

It looks like TS has issues augmenting re-exported stuff - see https://github.com/microsoft/TypeScript/issues/12607. Would be great if we could get a response from the team 👀

Anyway, @dai-shi do you think it might be better to allow direct access to valtio/react through the exports?
If valtio/react is added to the exports (like valtio/vanilla), then we probably could augment the module definition using
declare module 'valtio/react' {
  export function useSnapshot<T extends object>(p: T): T
}

The other option (that might be easier for everyone at this point) would be to directly export a useLooseSnapshot/useUnsafeSnapshot or something.

It looks like TS has issues augmenting re-exported stuff

So the example in https://github.com/pmndrs/valtio/pull/458#issuecomment-1136503615
isn't working correctly, but overwriting the type?

do you think it might be better to allow direct access to valtio/react through the exports?

Hmm, no, I would like to avoid such a workaround.
My suggestion is not to depend on module augmentation, but do type assertion.
    const snap = useSnapshot(state) as typeof state;

You can define useLooseSnapshot on your end likewise.
const useLooseSnapshot = <T extends object>(state: T) => useSnapshot(state) as T;

So the example in #458 (comment) isn't working correctly, but overwriting the type?

Unfortunately, on my end at least, it's not 😵💫

Hmm, no, I would like to avoid such a workaround. My suggestion is not to depend on module augmentation, but do type assertion.
    const snap = useSnapshot(state) as typeof state;

You can define useLooseSnapshot on your end likewise.
const useLooseSnapshot = <T extends object>(state: T) => useSnapshot(state) as T;

Thanks for the advice! I think I'll go with the local useLooseSnapshot as it might be easier to handle in a team environment and less error-prone.

Overwriting is work for me.

Personal Opinion.
I don't want use a useLooseSnapshot alias.
Because the data is the same, but the constraints are different. The team will produces two practice scenarios.
Team members may get confused or complain about inconsistent spelling.

There are some libraries that recommend users to override the type.
https://next-auth.js.org/getting-started/typescript#extend-default-interface-properties

It's great to see various opinions. I think what works works.
Thanks guys. Closing this as what we have now seems valid.
Please feel free to open a new discussion.

Update 2023, after reading TypeScript-Handbook new modules part
https://www.typescriptlang.org/docs/handbook/modules/reference.html#ambient-modules

Ambient module declarations are easy to confuse with module augmentations since they use identical syntax. This module declaration syntax becomes a module augmentation when the file is a module, meaning it has a top-level import or export statement (or is affected by --moduleDetection force or auto):

as gif shows, any top level export / import make .d.ts become module augmentation.
so if u are using a separate d.ts file + code as readme shows, make sure add a top level export {}

Thanks. If you have a suggestion to update README, please feel free to open a PR.

@magicdawn 's suggestion should be added to the README for sure. Just lost a few hours at this

total-typescript-essentials has a detailed explaination about Module Augmentation vs Module Overriding, recommendating this free book !
https://www.totaltypescript.com/books/total-typescript-essentials/modules-scripts-and-declaration-files#module-augmentation-vs-module-overriding


Fix the findEdge method of the graph

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #80   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          90     90
  Lines        1967   1969    +2
  Branches      347    348    +1
=====================================
+ Hits         1967   1969    +2

Impacted Files
Coverage Δ

src/data-structures/graph/Graph.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89fb0e6...35f7b89. Read the comment docs.

Thanks for another fix, @m-maksyutin ! :)