Results Reproduce

This is an excellent piece of work, but I am unable to reproduce the results presented in the paper. After three days of communication with the author and repeatedly modifying the code, I still cannot achieve the same results. Below, I list the modifications and process I followed. I sincerely suggest that the author recheck the open-source code.
An issue related to the model structure
Below are the logs of the training process using ./scripts/run_cl_forget.sh and the logs released by the author. In the highlighted area, a difference in the model structure can be observed.

After discussing with the author, it was confirmed that lora.MergedLinear should be replaced with nn.Linear.
The complete code modification is as follows: ./vit_pytorch_face/vit_face.py.
class Attention(nn.Module):
    def __init__(self, dim, heads=8, dim_head=64, dropout=0.0, lora_rank=8):
        super().__init__()
        inner_dim = dim_head * heads
        self.heads = heads
        self.scale = dim**-0.5

        print('in Attention class, lora_rank is:{}'.format(lora_rank))
        # self.to_qkv = nn.Linear(dim, inner_dim * 3, bias = False)
        # self.to_qkv = lora.MergedLinear(
        #     in_features=dim, #  latent dim = 512
        #     out_features=inner_dim * 3, # inner_dim == latent_dim
        #     r=lora_rank,
        #     enable_lora=[True, True, True],
        #     bias=False,
        # )
        self.to_qkv = nn.Linear(dim, inner_dim * 3, bias = False)
        self.to_out = nn.Sequential(nn.Linear(inner_dim, dim), nn.Dropout(dropout))

The same issue has been raised by the author here: https://github.com/bjzhb666/GS-LoRA/issues/9#issue-2512792028
Anomalies in the ACC_o Metric
After making the above modifications, I retrained the model but still could not obtain results even remotely similar to those reported in the paper, especially regarding the Acc_o metric, as shown in Table 3 of the main paper. Below is my training log.

After completing the "second forgetting task," test old-1 refers to the model's performance on the test dataset from the "first forgetting task." This result should ideally get smaller, and the paper reports a value of 0. However, I cannot achieve even a comparable result.

After completing the "third forgetting task," test old-2 refers to the model's performance on the test datasets from the "first two forgetting tasks."
Anomalies in the ACC_o Metric 2
Additionally, I noticed that the Test-forget-0 dataset, used during the "first forgetting task," should be the same as the test old-1 dataset during the "second forgetting task." These two metrics should yield equivalent results for the model before learning task 2, which can also be found in the training log provided by the author.

However, in my training log, the values of these two metrics are not the same, and I am very curious as to why this is the case.

We have updated the latest code, please refer to it.


SSOC'23 Fibonacci Sequence upto N [Optimized]

Fibonacci Sequence ( The Series starts from 0,1 and every next number is the sum of previous two number for example 0,1,1. and the series goes on.... 0,1,1,2,3,5,8,13,21,34,......)
The code will take a number as input from user say 'N' and will print Upto 'N' Fibonacci sequence numbers.
Example  :-
Input = 10
Output : - 0,1,1,2,3,5,8,13,21,34
I can code this in ( Python, Java, C++, C )
Please assign me this issue under SSOC'23. @Kumar-laxmi
Screenshot : -

@Kumar-laxmi  sir kindly assign this issue to me, I can code it using recursion as well as using loops  and will provide an optimize solution. Please assign it to me sir

This can be done using dynamic programming to optimize it. Kindly assign me this issue. I can implement this.


[WIP] Adds support for looking through a user's photo library

End goal is this:

Not quite there yet, I mainly wanted a PR so I could review the changes.

Fails

:no_entry_sign:

No CHANGELOG added.

:no_entry_sign:

Missing Test Files:

src/lib/components/consignments/components/__tests__/ImageSelection-tests.tsx

If these files are supposed to not exist, please update your PR body to include "Skip New Tests".

Warnings

:warning:

Please assign someone to merge this PR, and optionally include people who should review.

  Generated by :no_entry_sign: dangerJS

Finallllly

Today this doesn't look pretty, but I want to get it in so I can iterate.

This also adds bundler, and locks the psych gem so that our lockfile is determinate.

PR's still alive, gonna re-assign

The code looks good but since the user photo library view is not accessible, I couldn't test on device yet.
Feel free to merge after resolving the conflicts.


Add documentation on how to do a complete wipe of Composer app data

Is your feature request related to a problem? Please describe.
When we add new logic to Composer that deals with handling older implementations of files we store on disk, there is a chance that the data becomes malformed and then throws an exception when trying to be read in a newer version. This can cause a host of errors that could potentially stop Composer from starting.
Describe the solution you'd like
We should add some form of documentation (can be markdown inside the repository) that explains where Composer stores app data on each platform and how to do a clean wipe of all the data so that a user can try a fresh install of Composer to fix these issues.
Additional context
Please see the following issue #5073 for an example of a problem that could've been resolved with such documentation.

@tonyanziano how about adding a "factory reset" option to electron menus?

@hatpick I think this is a good idea as well. However, we also need docs on how to do this manually, because in the case of #5073 the user wasn't able to start Composer due to malformed files in the app data folder, so they would not be able to reach this "Factory reset" functionality.


[hold] chore: test published packages

This PR is used to test whether published packages works fine, don't need to merge.
preview link: https://deploy-preview-34--tisqleditor-playground.netlify.app/#

Published packages works fine after testing, I also test them in repo https://github.com/baurine/tisqleditor-nextjs , so close this PR.


Create an app landing page template

Can you please describe some more of how you want it to be? I'll see what i can cook up.

Currently we only have blog, article, text-based website and android.com templates...
A free app (this could be a desktop app) landing template would be a good addition . It should have room and pages for a screenshot, features (and details), reviews, links and a download button. The android.com template is what I'm currently using on my website, but it does not have room screenshots and many features.
Check my website, SuicSoft.com/lpm.html - that's the kind of content which needs to be on the new template.

There used to be a “product” template that never went to live because we didn’t polish it. We might reconsider this for v2.

@surma do you mind sharing it? I'm very interested in working on it/collaborating :)

@surma I would like a copy too

Feel free to take a look at da208f5fd5793da06160078cf52c5ecf2ef69b31 :)
If you check out that commit and build the microsite (npm install && gulp serve) you will get to see our very old website as well as find the product template on http://localhost:3000/templates/product/.

I don't have npm installed, will it work if I just open index.html?

@SuicSoft I don’t think it will. Most of the pages are built by gulp.

In the files you shared there is also a 'general' template, did you mean to share it?

Where can I find _variables.scss?

Please use the features of GitHub ;) You can look at the entire file tree of that commit here and press t to search for files.

@TheMightyCraken Have you made anything?

Yep I did
On Dec 12, 2015 11:08 AM, "Suici Doga"<EMAIL_ADDRESS>wrote:

@TheMightyCraken https://github.com/TheMightyCraken Have you made
anything?
—
Reply to this email directly or view it on GitHub
https://github.com/google/material-design-lite/issues/1896#issuecomment-164112591
.

Do you mind sharing? :confused:

@guruganeshm im also interested :)

Any updates?

New templates are very low priority. We will provide updates as we have them. Right now the focus is on finishing through 1.1 and getting on to 2.0. Which there will most likely won't be any new templates since we will be refactoring existing ones.
PRs always welcome if someone wants to jump on doing this before us and sending it upstream.

This isn't free but you should try it:
http://www.materialup.com/posts/mdlp-2-material-design-app-landing-page


fix: myinfo encryptedAndSignedPersona to use enc A256GCM

Problem

In myinfo docs (Developers_FAQ.pdf), noted use of A256GCM

Q15 of https://api.singpass.gov.sg/library/myinfo/developers/FAQ

current product integration with myinfo test api is also using A256GCM and it is working

Solution

Update A128CBC-HS256 to A256GCM

I double-checked the TUO v3.2.6 spec that I have on hand (in case it differs from v4) and it does say A256GCM as well. Looks like it was left like this in #563 for backwards compatibility reasons, but I think there's a case to be made that this is a bugfix as any client strictly enforcing A128CBC-HS256 instead of A256GCM is doing it wrong anyway.

thanks for the review and finding more info on this
the pr title and commit message have been changed to fix


Move CORS options to method in service provider

Hi!
I have a special case when I need to extend Asm89\Stack\CorsService.
Currently it can be done by copying all CORS options creating code to my service provider, but it feels bad.
After that changes it can be done with
$this->app->singleton(CorsService::class, function ($app) {
    return new MyCorsService($this->corsOptions(), $app);
}

Thanks


discord.py attributeerror: 'nonetype' object has no attribute

Hello, could you please provide more details about the issue? Thank you

How do you solve the this problem?

import re
import random
import discord
import lavalink
from discord.ext import commands
import asyncio
import fileRead
url_rx = re.compile(r'https?://(?:www.)?.+')
"""
Robert A. USF Computer Science
A cog to hold all of the functions used to play music for the bot.
"""
class music(commands.Cog):
def init(self, bot):
self.bot = bot
    if not hasattr(bot, 'lavalink'):  # This ensures the client isn't overwritten during cog reloads.
        **bot.lavalink = lavalink.Client(bot.user.id) # this part**
        bot.lavalink.add_node('<IP_ADDRESS>', 2333, 'changeme123', 'na', 'local_music_node')  # PASSWORD HERE MUST MATCH YML
        bot.add_listener(bot.lavalink.voice_update_handler, 'on_socket_response')

Traceback (most recent call last):
File "/Users/kangyoolee/OneDrive/코딩/ssukssugi-test/bot.py", line 14, in
bot.load_extension(f"Cogs.{filename[:-3]}") #4
File "/usr/local/lib/python3.9/site-packages/discord/ext/commands/bot.py", line 678, in load_extension
self._load_from_module_spec(spec, name)
File "/usr/local/lib/python3.9/site-packages/discord/ext/commands/bot.py", line 623, in _load_from_module_spec
raise errors.ExtensionFailed(key, e) from e
discord.ext.commands.errors.ExtensionFailed: Extension 'Cogs.music' raised an error: AttributeError: 'Bot' object has no attribute 'lavalink'

Have you done pip3 install lavalink?

Yes.

I would advise doing a fresh pull, just save your env file and then try again, also I see it is in a OneDrive folder and python may not like that, I would try a regular directory on your PC, if that doesn't work we can work on it more later today, I personally have not run across this error yet.

Is the issue resolved?

Yes
2021년 8월 6일 (금) 오후 11:39, Robert Andion @.***>님이 작성:

Is the issue resolved?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RobertAndion/Discord_Music_Bot/issues/6#issuecomment-894307412,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK6U532DEVACREV3GQDTYW3T3PX3PANCNFSM5BPD2KTQ
.

Perfect glad to hear it


[9.3.x] ISPN-10016 Provide a default Lucene analyzer for file names

add a new analyzer called "filename" in DefaultSearchMappingProvider

https://issues.jboss.org/browse/ISPN-10016

PR removed as there are not going to be any 9.3.x releases


http: panic serving

04/03/2024 05:27 AM	DEBUG	requesting file	{"name": "㕉㺜絷䔶䉰嘲睻朳ᡔ錐䡷携阄蝫套脼豈䎤爡ស炸吟㿨两羵䡫沑胾葃㒭㒟保玐ꂬɿ", "bot": "6808523031", "botNo": 2, "start":<PHONE_NUMBER>, "end":<PHONE_NUMBER>, "fileSize":<PHONE_NUMBER>}
2024/03/04 05:27:06 http: panic serving <IP_ADDRESS>:46866: runtime error: index out of range [2] with length 2
goroutine 669 [running]:
net/http.(*conn).serve.func1()
net/http/server.go:1898 +0xbe
panic({0x192d8c0?, 0xc0003dd1e8?})
runtime/panic.go:770 +0x132
github.com/divyam234/teldrive/pkg/services.rangedParts({0xc0004ccba0?, 0xc000c3f400?, 0xc0006cd008?}, 0xc000036330?, 0xc0004394a0?)
github.com/divyam234/teldrive/pkg/services/common.go:199 +0x2a5
github.com/divyam234/teldrive/pkg/services.(*FileService).GetFileStream(0xc0000101b0, 0xc000c3f400)
github.com/divyam234/teldrive/pkg/services/file.go:527 +0x1534
github.com/divyam234/teldrive/pkg/controller.(*Controller).GetFileStream(...)
github.com/divyam234/teldrive/pkg/controller/file.go:172
github.com/gin-gonic/gin.(*Context).Next(...)
github.com/gin-gonic/gin@v1.9.1/context.go:174
github.com/divyam234/teldrive/cmd.initApp.func1(0xc000c3f400)
github.com/divyam234/teldrive/cmd/run.go:220 +0x1a3
github.com/gin-gonic/gin.(*Context).Next(0xc000c3f400)
github.com/gin-gonic/gin@v1.9.1/context.go:174 +0x2b
github.com/divyam234/teldrive/cmd.initApp.GinzapWithConfig.func4(0xc000c3f400)
github.com/gin-contrib/zap@v0.2.0/zap.go:59 +0xb1
github.com/gin-gonic/gin.(*Context).Next(...)
github.com/gin-gonic/gin@v1.9.1/context.go:174
github.com/gin-gonic/gin.(*Engine).handleHTTPRequest(0xc0003564e0, 0xc000c3f400)
github.com/gin-gonic/gin@v1.9.1/gin.go:620 +0x66e
github.com/gin-gonic/gin.(*Engine).ServeHTTP(0xc0003564e0, {0x264bad8, 0xc000c0cee0}, 0xc000e43680)
github.com/gin-gonic/gin@v1.9.1/gin.go:576 +0x1b2
net/http.serverHandler.ServeHTTP({0xc000036150?}, {0x264bad8?, 0xc000c0cee0?}, 0x6?)
net/http/server.go:3137 +0x8e
net/http.(*conn).serve(0xc0006db5f0, {0x264e6b8, 0xc0006ca480})
net/http/server.go:2039 +0x5e8
created by net/http.(*Server).Serve in goroutine 26
net/http/server.go:3285 +0x4b4

Hello, I have exactly the same problem on my side and I have to restart teldrive to resolve the problem

am still doing some testing. i will report back when i finish

i gave up on this project for the time being because few different issues, some of them including this one. best of the luck, will leave this open just in case @antoinerzad

Hello @aniel300 and @antoinerzad,
I have the same problem... some suggestion to solve this?
Best Regards
Stefano

no solutions as in yet. i it seems to happens after for whatever reason the files get corrupted or something like that. rclone version 1.66 didn't help either and was being problematic so do go back to 1.65 for the time being. am personally running into this issue right now. something to do with "FILE_PART_SIZE_INVALID" i think is similar to this one: https://github.com/divyam234/teldrive/issues/86

@aniel300,
Thanks a lot for your reply, so now we are stuck... I hope someone find a solutio :-D
Best Regards
Stefano

@aniel300 ,
Do you know some alternatives? Now I'm testing tgmount-ng but seems that the project is not mainteined anymore..

@wes1993 i took a look at tgmount-ng and it seems it needs to be set up at the host level which i dont like. as for it being maintained i think u are right. there is another project out there which also doesn't support docker so am stuck with this

@aniel300 , Could you tell me the name of the other project?

teledrive

teledrive

that project is slow as hell, good luck with the ban of your account. You don't know how to use this project anyways

teledrive

that project is slow as hell, good luck with the ban of your account. You don't know how to use this project anyways

my dude am not using that project, and am very thankful to this project. stop putting words in my mouth

@aniel300 I think i have found the problem...
I don't know why but seems that sometimes if I try to open file A the tool open file B but the message ID in the Database is correct...
This can create the problem index out of range because the file size is from File A but the real file is File B.
I'm trying to find a way to read the message ID of the File B...
Best regards

wow this is good news. hopefully a fix or workaround can be found. let me know if u need my help.

I have fixed my problem, i don't know why but the channel_id for some files was wrong..
So i suggest to check the DB with SQL query to see if there is some error in the channel_id:
select * from teldrive.files where channel_id<>YOURCHANNEL/GROUPID;

i dont have nay files now over there. so i guess then the remaining issue would be https://github.com/divyam234/teldrive/issues/86?

I have fixed my problem, i don't know why but the channel_id for some files was wrong.. So i suggest to check the DB with SQL query to see if there is some error in the channel_id:
select * from teldrive.files where channel_id<>YOURCHANNEL/GROUPID;

how can i do do this on my end?


Minor corrections

Minor grammar and formatting fixes.
Includes fixes for:
#800
#649

@skipjack / @simon04 i effed this one up with a very untimely trackpad tap 😬. I have a local copy of this branch with 57ea4a5 removed but daren't git push branch -f without approval if at all. My apologies but let me know what you'd like to do here and I'll take care of it.

@rouzbeh84 no worries, I can clean that up before it gets merged (or we can leave it, a master merge shouldn't hurt anything)

Sounds good to let it ride I guess then. Wasn't sure how y'all like to handle this being a bit newer to the collab role. If there are guidelines outside of 'dont do this' and generally accepted git best practices I'd love to see them 👍

@rouzbeh84 can you review and merge (if all is good) when you have a chance?

Awesome, thanks @rouzbeh84!


OSX Install issues

=> Errors prevented startup:
While checking for<EMAIL_ADDRESS>error: No compatible binary build found for this package. Contact the package author and ask them to publish it for your platform.

current version is 0.0.33, any particular reason for using 0.0.29?


chore: issue & pr templates

Related: https://github.com/getsentry/sentry-kotlin-multiplatform/issues/96
Add issue and pr templates for this repo.
#skip-changelog

@buenaflor btw do you also wanna create CODEOWNERS right away?

@buenaflor btw do you also wanna create CODEOWNERS right away?

Sure, that would be you and manoel, right?

@buenaflor btw do you also wanna create CODEOWNERS right away?

Sure, that would be you and manoel, right?

And you :)


Added integration test to properly test name synonymy forms.

There were several problems.  Basically, just because of lack of live testing of the name CRUDification PR from a few weeks ago.

The form input field ids were not the same as the parameters used in the controller tests, so the controller tests were passing fine, but the forms didn't actually set those parameters.  The new integration test should catch any mismatches like that in the future.  At least in this one tiny corner of the vast ocean of code. :(

Also, the routes were wrong for approve and deprecate -- they were being sent to names controller (or maybe the names/synonymy controller, I forget now), when they should be getting sent to the names/synonymy/approve and names/synonymy/deprecate controllers.  Again, the integration test should help catch such things.

There were also some eager-loading problems uncovered by the integration test.  One thing is interesting.    Instead, if all you want to do is test for the presence of the user, do blah.user_id.present?.
Also, and I don't know if this works universally, but a way to separate concerns when eager-loading may be to change from this:
class Controller
def action
@object = Model.where(blah).includes(comments: :user)
end
end
to
app/views/comments/_comments_for_object.html.erb:
comments = @object.comments.include(:user)
This way the action doesn't necessarily need to know that the comments partial will eventually load the user info.  The comments partial itself can do the eager-loading.  Since nowhere else in the code are the comments' users needed, this works in this case.
I guess we'll see how many things I broke by adding that eager-loading to the comments partial in a second...   For example, I know show_observation does the eager-loading for all the partials right at the top.  Does that mean it now eager-loads the comments' users twice??  Ugh.

Coverage: 93.49% (-0.004%) from 93.495% when pulling ef0d4094410dcfd5661d570e8d4b1f2b930d4dec on fix-deprecate into 2f9348875d9dae1a83e028727f0838b6859ddf1a on main.

@pellaea:

Thanks again for diving into this and for the informative and helpful PR description.
Something like your first point occurs in description by_author/by_editor:
Controller tests are green, but the app behaves badly.; the view params are inconsistent with those in the tests.
Sounds like the added integration tests are sort of testing the controller tests. I've tried to avoid adding integration tests because I'm concerned about test performance. But maybe I need more of them.
I will do some manual tests of this PR. I hope to be done in about 15 minutes (unless interrupted by a family phone call).

This does not work for me.
Example:

Go to http://localhost:3000/names?pattern=fumosorose
Copy the first name (Cordyceps fumosorosea (Wize) Kepler, B. Shrestha & Spatafora)
Go to the second name (Isaria fumosorosea Wize)
Click Deprecate
Paste the copied name into the Preferred Name field
Click Submit
Result: Goes to  Isaria fumosorosea Wize without deprecating it.

Thanks, Joe.  That's bizarre!  I'll look into it.
On Sat, Feb 11, 2023 at 9:49 AM Joseph D. Cohen @.***>
wrote:

This does not work for me.
Example:

Go to http://localhost:3000/names?pattern=fumosorose
Copy the first name (Cordyceps fumosorosea (Wize) Kepler, B.
Shrestha & Spatafora)
Go to the second name (Isaria fumosorosea Wize
http://localhost:3000/names/40345)
Click Deprecate
Paste the copied name into the Preferred Name field
Click Submit
Result: Goes to Isaria fumosorosea Wize
http://localhost:3000/names/40345 without deprecating it.

—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1348#issuecomment-1426789746,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYTNNNOXKSICJPJ4YVOYI3WW6RIPANCNFSM6AAAAAAUYPNJZE
.
You are receiving this because you were mentioned.Message ID:
@.***>

It certainly felt weird.
It's possible that it's an issue for me with VSCode not fetching the branch
properly.
I'll double check that.
On Sat, Feb 11, 2023 at 7:44 AM Jason Hollinger @.***>
wrote:

Thanks, Joe. That's bizarre! I'll look into it.
On Sat, Feb 11, 2023 at 9:49 AM Joseph D. Cohen @.***>
wrote:

This does not work for me.
Example:

Go to http://localhost:3000/names?pattern=fumosorose
Copy the first name (Cordyceps fumosorosea (Wize) Kepler, B.
Shrestha & Spatafora)
Go to the second name (Isaria fumosorosea Wize
http://localhost:3000/names/40345)
Click Deprecate
Paste the copied name into the Preferred Name field
Click Submit
Result: Goes to Isaria fumosorosea Wize
http://localhost:3000/names/40345 without deprecating it.

—
Reply to this email directly, view it on GitHub
<
https://github.com/MushroomObserver/mushroom-observer/pull/1348#issuecomment-1426789746
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAYTNNNOXKSICJPJ4YVOYI3WW6RIPANCNFSM6AAAAAAUYPNJZE
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1348#issuecomment-1426803943,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALDFAEYLB6BNOK7QWWOFLWW6XVLANCNFSM6AAAAAAUYPNJZE
.
You are receiving this because you commented.Message ID:
@.***>

Uh...  It worked fine for me.   :)
On Sat, Feb 11, 2023 at 10:43 AM Jason Hollinger @.***> wrote:

Thanks, Joe.  That's bizarre!  I'll look into it.
On Sat, Feb 11, 2023 at 9:49 AM Joseph D. Cohen @.***>
wrote:

This does not work for me.
Example:

Go to http://localhost:3000/names?pattern=fumosorose
Copy the first name (Cordyceps fumosorosea (Wize) Kepler, B.
Shrestha & Spatafora)
Go to the second name (Isaria fumosorosea Wize
http://localhost:3000/names/40345)
Click Deprecate
Paste the copied name into the Preferred Name field
Click Submit
Result: Goes to Isaria fumosorosea Wize
http://localhost:3000/names/40345 without deprecating it.

—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1348#issuecomment-1426789746,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYTNNNOXKSICJPJ4YVOYI3WW6RIPANCNFSM6AAAAAAUYPNJZE
.
You are receiving this because you were mentioned.Message ID:
@.***>

No. Will try again.
On Sat, Feb 11, 2023 at 7:50 AM Jason Hollinger @.***>
wrote:

Uh... It worked fine for me.  :)
On Sat, Feb 11, 2023 at 10:43 AM Jason Hollinger @.***> wrote:

Thanks, Joe. That's bizarre! I'll look into it.
On Sat, Feb 11, 2023 at 9:49 AM Joseph D. Cohen @.***>
wrote:

This does not work for me.
Example:

Go to http://localhost:3000/names?pattern=fumosorose
Copy the first name (Cordyceps fumosorosea (Wize) Kepler, B.
Shrestha & Spatafora)
Go to the second name (Isaria fumosorosea Wize
http://localhost:3000/names/40345)
Click Deprecate
Paste the copied name into the Preferred Name field
Click Submit
Result: Goes to Isaria fumosorosea Wize
http://localhost:3000/names/40345 without deprecating it.

—
Reply to this email directly, view it on GitHub
<
https://github.com/MushroomObserver/mushroom-observer/pull/1348#issuecomment-1426789746
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAYTNNNOXKSICJPJ4YVOYI3WW6RIPANCNFSM6AAAAAAUYPNJZE

.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1348#issuecomment-1426805225,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALDFA5ZDBP52X7EPN22T3WW6YMBANCNFSM6AAAAAAUYPNJZE
.
You are receiving this because you commented.Message ID:
@.***>

By the way, yes, we need to be writing integration tests to test the views
better.  If Nimmo had the time and wasn't already doing way too much, I
suspect he would have added integration tests for the entire UI as he
worked his way through the CRUD refactor.
I think we've been getting away without integration tests because we
haven't been messing with the views at all.  For years and years.  But
Nimmo's work has really underscored how poorly covered our views are.
(Speaking of... do we have any idea why adding a test would reduce test
coverage in this PR???  I believe I added no new code, yet coveralls is
convinced the code is minutely less covered.)
On Sat, Feb 11, 2023 at 10:49 AM Jason Hollinger @.***> wrote:

Uh...  It worked fine for me.   :)
On Sat, Feb 11, 2023 at 10:43 AM Jason Hollinger @.***>
wrote:

Thanks, Joe.  That's bizarre!  I'll look into it.
On Sat, Feb 11, 2023 at 9:49 AM Joseph D. Cohen @.***>
wrote:

This does not work for me.
Example:

Go to http://localhost:3000/names?pattern=fumosorose
Copy the first name (Cordyceps fumosorosea (Wize) Kepler, B.
Shrestha & Spatafora)
Go to the second name (Isaria fumosorosea Wize
http://localhost:3000/names/40345)
Click Deprecate
Paste the copied name into the Preferred Name field
Click Submit
Result: Goes to Isaria fumosorosea Wize
http://localhost:3000/names/40345 without deprecating it.

—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1348#issuecomment-1426789746,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYTNNNOXKSICJPJ4YVOYI3WW6RIPANCNFSM6AAAAAAUYPNJZE
.
You are receiving this because you were mentioned.Message ID:
@.***>

No. Will try again. On Sat, Feb 11, 2023 at 7:50 AM Jason Hollinger @.> wrote:
…
Uh... It worked fine for me.  :) On Sat, Feb 11, 2023 at 10:43 AM Jason Hollinger @.> wrote: > Thanks, Joe. That's bizarre! I'll look into it. > > On Sat, Feb 11, 2023 at 9:49 AM Joseph D. Cohen @.> > wrote: > >> This does not work for me. >> Example: >> >> - Go to http://localhost:3000/names?pattern=fumosorose >> - Copy the first name (Cordyceps fumosorosea (Wize) Kepler, B. >> Shrestha & Spatafora) >> - Go to the second name (Isaria fumosorosea Wize >> http://localhost:3000/names/40345) >> - Click Deprecate >> - Paste the copied name into the Preferred Name field >> - Click Submit >> Result: Goes to Isaria fumosorosea Wize >> http://localhost:3000/names/40345 without deprecating it. >> >> — >> Reply to this email directly, view it on GitHub >> < #1348 (comment) >, >> or unsubscribe >> < https://github.com/notifications/unsubscribe-auth/AAYTNNNOXKSICJPJ4YVOYI3WW6RIPANCNFSM6AAAAAAUYPNJZE > >> . >> You are receiving this because you were mentioned.Message ID: >> @.> >> > — Reply to this email directly, view it on GitHub <#1348 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALDFA5ZDBP52X7EPN22T3WW6YMBANCNFSM6AAAAAAUYPNJZE . You are receiving this because you commented.Message ID: @.***>

My bad. Sorry for the false alarm. (I had unintentionally created a local branch with the same name instead of checking out your branch.)

Re test coverage:

Coveralls says this is reduced because:

There's a "New Missed Line" in /app/models/name/validation.rb.
See https://coveralls.io/builds/56841410/source?filename=app%2Fmodels%2Fname%2Fvalidation.rb#L83
(The line isn't newly missed. Coveralls treats it as "new" because it's changed. So it's a "new" line that's missed.)
Coverage decreased in /app/controllers/names/synonyms/deprecate_controller.rb.
I suspect that's because you deleted a previously covered line(s).

Here's how to figure this out (assuming an adequate connection to GitHub):

To the right of coverage/coveralls, click Details.

The resulting screen shows New Missed Lines in Diff (assuming there are just a few) and an expandable Tree.
A red down arrow shows decreased coverage.

(You can expand the Tree until you see particular files. Click on the filename to see the file details. Once in a file, typing "n" scrolls to the next uncovered line.)

PS: If you don't have a good GitHub connection I think you can see the same info via Coveralls. https://coveralls.io/
But you must create Coveralls account and (in Coveralls) link your Github account to your Coveralls account.

Oh, thank you so much, Joe.
That makes sense.  We have a validation on Name to make sure the name was
created by a logged in user, or that the user was explicitly set before
saving.  I'm sure we can create a test case that tests that but it's a bit
silly. ...  Well, maybe not.  I'll just do it.
Yes, I deleted two lines that initialized some two-deep params that were no
longer needed.  I will ignore that artificial decrease.
-Jason
On Sat, Feb 11, 2023 at 11:53 AM Joseph D. Cohen @.***>
wrote:

PS: If you don't have a good GitHub connection I think you can see the
same info via Coveralls. https://coveralls.io/
But you must create Coveralls account and (in Coveralls) link your Github
account to your Coveralls account.
—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1348#issuecomment-1426821758,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYTNNLG7LQGFY237QHZ4XTWW67ZDANCNFSM6AAAAAAUYPNJZE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Hyper Fang is missing

I wanted to see how ridiculous Hyper Fang on Gumshoos with Strong Jaw and Adaptability would be, but the calculator doesn't have that move in the system.

#161 Added


Test case missing for next empty

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 81.951%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
168

Relevant Lines:
205

💛  - Coveralls


Publishing on 3.19.20

Docs Build status updates of commit e36fc43:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamicsax2012-technet/create-archive-objects-idmf.md
:white_check_mark:Succeeded
View

dynamicsax2012-technet/create-purge-objects-idmf.md
:white_check_mark:Succeeded
View

dynamicsax2012-technet/define-edit-entry-point-permissions.md
:white_check_mark:Succeeded
View

dynamicsax2012-technet/idmfarchiveobjectexpanded.png
:white_check_mark:Succeeded
View

dynamicsax2012-technet/idmfpurgeobject.png
:white_check_mark:Succeeded
View

dynamicsax2012-technet/idmfpurgeobjectwithinvalidtables.png
:white_check_mark:Succeeded
View

dynamicsax2012-technet/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add hook scripts for first deploy & rollback

This pull request add a hook script to rollback task, this script is called instead restart task if exist. The default is the call to restart.
I have added another hook on first push to call a setup script if exist, this commit responds to issue #11. I'm not with effect of this feature when push is a new branch but not the first push on server.
All this changes doesn't break current API.

Why do you think a rollback script would be useful?
Re: invoking a one-time setup script in the project: I don't think it's worth it. You're going to check in a script in your version control that's only going to be run one time. If you mess something up in this script, you can't get it to run again so you have to do manually. That's why I suggested in the documentation that you better do it manually on your server.

I use the same bundle of deploy script for all my apps and has example: my database config file is created automatically when i prepare the virtualhost, If I can run a setup script, I can create link to this file and run first database migration.
When I run database migration, I save last database version to rollback migration in case of problem. I need to clear my asset too.
This hooks don't change defaults but allows a little more flexibility.


Add new bpf_conformance tests

Switch to latest bpf_conformance docker image.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 95.663%

Totals

Change from base Build<PHONE_NUMBER>:
-0.001%

Covered Lines:
3198

Relevant Lines:
3343

💛  - Coveralls


Album thumbnails are not working

Hi
The album thumbnails are not generated for the created albums but "recent album" shows the thumbnail only for the recent folder
in the log i can see following error
App\Metadata\GitHubFunctions::__construct -- 47 -- file_get_contents(/home/xxx/.git/HEAD): failed to open stream: No such file or directory
any idea why?

Please file this at LycheeOrg/Lychee using the template there.

App\Metadata\GitHubFunctions::__construct -- 47 -- file_get_contents(/home/xxx/.git/HEAD): failed to open stream: No such file or directory

This just means that it is not finding .git/HEAD which is normal if you are using the release channel.


Bug : Report generation failing after run is complete

The report generation is failing due to an error : ZeroDivisionError (see attached screenshot for more details)

Thanks for this, will take a look
Note - your model is generating no output, which can be seen by the "SKIP" status on 0/0 for both evals. This means the report will contain nothing. It may be because the prompts are longer than the amount of text the model will generate, from the look of the message.

appreciate the PR! thank you :)


Enable multi-controller coordination

Description of changes

Created "command specification" files to save metadata about all commands. This can also be used by the ROS driver in the future, so there will be one canonical source for commands. This fixes Issue #4 .
Refactored the entire backend to split up commands to several devices in the background. The user workflow doesn't change at all. This fixes issue #3 .
Redefined the hardware configuration to enable easy extension to multiple devices.
Added realtime data parsing from the datastream sent back from the controller. The parsed data is saved in an intelligent form rather than just dumping the raw text into a file. This will break the data plotting script, but will facilitate an easy replacement.

Motivation and Context
If we have a few control boards, we should be able to combine all the channels together and coordinate them.
Testing
Tested on real hardware, and confirmed commands are correctly split between several pressure controllers.
Testing Environment:

OS: Ubuntu and Mac OSX

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[x] I have tested this code on real hardware.
[ ] I have updated the documentation accordingly.

There's an extra "serial_config.py" file that doesn't get used anymore, and the naming of the "hardware_config.py" file is confusing with the hardware config folder. I suggest you delete both ot these files and replace "hardware_config.py" with "comms_config.py" to clarity.


Exclude external files and sources from typos check

#67 shows we should exclude certain files from typos check. So far the options that were stated there are:

Only adding varcon.txt
Excluding All .txt files in sources/
Excluding sources/ directory as a whole

I think the second option is more useful since we'll likely encounter more original files and tests that benefit from exclusion while typos is still useful to check with files we create.

I would exclude all sources folder.
Because we will have README, README.md, README.txt, LICENSE.OLD…
We don't manage all these files.
So I think we will end by excluding all source folder at some point.
But we can if course start with excluding sources/**.txt

But we can if course start with excluding sources/**.txt

Then, let's do that. At the first sign of trouble, we can easily expand it to exclude everything else in sources/,


Fixing CI by xfail on new svd related failure

Description:

Temporary fix CI with xfail on new svd related failure
replace _svd_helper by _linalg_svd to reenable vmap
removed rsub_rsub_scalar to fix unexpected failure

related https://github.com/pytorch/functorch/issues/428

@vfdev-5 could you rebase this when you get a chance please?

@zou3519 can you detail what you would like to do ? main branch is already in the PR, done by @Chillee , PR is up-to-date vs main.
However, I was expecting that if @Leszano fixed pytorch side and it was merged we can close this PR

@vfdev-5 thanks for the explanation, I didn't realize Horace rebased this already!

From what I can tell:

pytorch nightlies haven't been updated with the fix yet
When it does update with the fix, we only really need to merge one line from this change (the line that changes _svd_helper to _linalg_svd). So we can just open a new PR for that or we can include it as a part of another fix

So TL;DR no action required from us yet

Yes, this line _svd_helper -> _linalg_svd and probably norm_nuc was not fixed

Also look for the appearances of linalg.svd  in the xfails and skips and remove those, as those test pass now (there's 1xfail and 1 skip, at least)

I incorporated the change and xfails while fixing the rest of the functorch CI in https://github.com/pytorch/functorch/pull/452

Thanks! OK, let's close this PR in favor of #452


Python3

python3 start using
futureize -1 -w file.py

Loren -- don't merge this into master  -- let's keep it as a separate branch

go ahead and start a new python3 branch of your own, and I'll make the pull request off
of that branch instead of master


Use semver and git tag ?

Hi first of all thanks for building grace,
I was wondering if you had though about tagging and releasing semver versions of grace ?
Shipping semver releases makes it easy for users of the library to use a specific version and not be affected by accidental breaking changes (this can always be done by using an explicit SHA, but a semver tag is arguably nicer).

Since we don't use semver or tags ourselves promising to maintain those becomes overhead/afterthought so we don't tend to have those on any of our packages. (We vendor everything.)


Add git versioning

Fixes #34

Having problems with the build.  The git versioning is not finding some of the commits in the branch.
I'll look into it again another time.

Re-doing this PR as this is becoming messy.


[FLINK-16234]Use LinkedHashSet for a deterministic iteration order

This PR aims to solve the issue presented here: https://issues.apache.org/jira/browse/FLINK-16234
What is the purpose of the change
The fix is to change the HashSet to LinkedHashSet to make the tests more stable.
Verifying this change
This change is already covered by existing tests, and it can pass them successfully.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers:  don't know
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

If the test assertion is flakey, why not fix the test assertion instead?

Thanks for reporting this issue and trying to fix it @cpugputpu .
I second with @StephanEwen that we should fix the tests instead (testSlotSharingOnAllVerticesInSameSlotSharingGroupByDefaultEnabled and testSlotSharingOnAllVerticesInSameSlotSharingGroupByDefaultDisabled). We should not assume that the topological order of sources is the same as the order that they are added into the StreamGraph.
To fix those problematic tests, one option is to find the wanted vertex via the name rather than via the index.
@cpugputpu do you want to fix it?

Thanks for your valuable comments! I am sorry that my previous fix was not a good one. Now I fix it without changing StreamGraph.java.
@flinkbot run travis


[🐞] QwikKeyboardEvent missing isComposing property

Which component is affected?
Qwik Runtime
Describe the bug
I think this is an issue of missing type definition
Reproduction
https://stackblitz.com/edit/qwik-starter-hmsmh2?file=src%2Froutes%2Findex.tsx
Steps to reproduce
 <textarea
  onKeyDown$={(evt, el) => {
    console.log(evt.isComposing)  // false or true
  }}
/>

System Info
System:
    OS: macOS 13.3.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 5.63 GB / 32.00 GB
    Shell: 3.6.1 - /opt/homebrew/bin/fish
  Binaries:
    Node: 20.1.0 - /opt/homebrew/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.6.4 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 113.0.5672.126
    Safari: 16.4
  npmPackages:
    @builder.io/partytown: ^0.8.0 => 0.8.0
    @builder.io/qwik: ^1.1.4 => 1.1.4
    @builder.io/qwik-auth: ~0.1.0 => 0.1.0
    @builder.io/qwik-city: ^1.1.4 => 1.1.4
    @builder.io/qwik-react: 0.5.0 => 0.5.0
    vite: 4.3.9 => 4.3.9

Additional Information
No response

Wanna prepare a PR? i would love to merge it :)

Sorry, I have not investigated this issue in depth. I know too little about qwik-dom. I am not sure if qwik events can directly use the standard DOM types declared in lib.dom.d.ts like solidjs. I feel it is more like react-dom, Maybe we should use evt.nativeEvent like react?


Add ability to add a nested navigator push to the root navigator's backstack

Use case
If I push a route to a nested Navigator, that action does not get popped when I tap the device back button (Android) or the browser back button (Web). Would be nice to have the ability for those back buttons to pop whatever the last push was on any Navigator in the app.
Proposal
Sample app:
https://github.com/carloshwa/flutter-example/tree/nested_navigator
This is based on the default sample app, but the FAB has been modified:
https://github.com/carloshwa/flutter-example/blob/nested_navigator/myapp/lib/main.dart#L58
to push a route to a nested Navigator to show the updated count:
https://github.com/carloshwa/flutter-example/blob/49cbe8e532233e9492574e4557be71097a707fad/myapp/lib/main.dart#L77-L86
After tapping the FAB, tapping the device back button or browser back button exits the app instead of navigating back to the previous count. Add the ability to have the back button pop the nested navigator's latest route (like Android's FragmentTransaction.addToBackStack() method).

After realizing I couldn't get this functionality, I tried to implement it using addLocalHistoryEntry() but then I ran into #59185. The only way I've been able to achieve this behavior is to push a new route to the root navigator that replaces the entire screen, which replaces shared widgets (like the drawer and other Scaffolds) that I would ideally like to leave untouched while replacing just a specific Scaffold.

The can be configured in the router widget in navigator 2.0.
For now, you can probably use willPopScope

Hi @chunhtai,
Thanks for the suggestion. I tried adding that to my sample app:
https://github.com/carloshwa/flutter-example/blob/nested_navigator/myapp/lib/main.dart#L71-L79
And it mostly achieves what I'm looking for, but it also has the same issue I reported in #59185 with using addLocalHistoryEntry() where in a web browser, the browser's back button does not get enabled when I push to one of the nested navigators, even though my onWillPop function would be able to perform a pop. So it seems I would also need a way to notify the root navigator that there is a stack available, so that it can enable the browser's back button.

Navigator 2.0 now allows this functionality.


Add EDT keypad feature

Having used RT-11, RSX-11M & VMS  KED & EDT for decades, my fingers prefer the keypad editing.

Editing sources in VS Code is not an our issue.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_bbcre1eoah/clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_bbcre1eoah/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_bbcre1eoah/clone/recipe/meta.yaml:28: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_bbcre1eoah/clone/recipe/meta.yaml:28: missing_imports_or_run_test_py: Python packages require imports or a python test file in tests.
WARNING: /tmp/abs_bbcre1eoah/clone/recipe/meta.yaml:34: missing_description: The recipe is missing a description
ERROR: /tmp/abs_bbcre1eoah/clone/recipe/meta.yaml:34: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_bbcre1eoah/clone/recipe/meta.yaml:34: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_bbcre1eoah/clone/recipe/meta.yaml:34: missing_documentation: The recipe is missing a doc_url or doc_source_url
Errors were found


Simple retry loop for issue #38

What are you trying to accomplish?
Issue #38 still seems to be popping up quite a bit. In addition to the backend fixes that @RyanHecht mention are being worked on https://github.com/github/gh-classroom/issues/38#issuecomment-1731563468 This adds a very simple retry loop to the base http package with a max retry of 5.
While this does not fix #38, it does help mitigate what the users see to help smooth out their experience. Hopefully with lowering the default per-page to 15 and this simple loop this error can be less intrusive.
What approach did you choose and why?
Just a simple retry loop with a max of 5 retry's.
What should reviewers focus on?
It would be really nice if the RESTClient.Get call returned an error code so we could explicitly check for a 500. As of right now it is embedded in the error string. I guess we could parse  the error code out of a string and if you think that is a better approach let me know :)
As of right now this simple approach will execute a retry even if the failure was valid as in the case of the user passing in bad data.
I don't know if we want to add in any pauses between retry's to avoid hitting the API too aggressively :) I would assume that github.com could handle the traffic but I don't have any insight to what the backend is doing.
Thanks for all your efforts :)

Thank you for this PR! We are currently working on an internal fix that will hopefully improve the performance of this endpoint and prevent 500s. I'd love to hold off on this PR until those changes are merged.

This seems to be working now without retries https://github.com/github/gh-classroom/issues/38#issuecomment-1741110222


Update xlsx.dart

The sheet xml filename is defined by the r:id attribute not the sheetId. Try to delete and create sheets to view that.

Thank you for reporting this issue.
I went more deeper to fix completely this bug.
Sorry for the delay, I was too busy.


Fixes 4000: Add self-explanation to the model, include the verbal schema description to the flow

Fixes 4000

Improved schema prompt to retrieve slightly better results
Added additionalPrompts config which can accept list of maps with other request messages
we can use it together with apoc.ml.schema to improve the results
added examples with Northwind database: https://neo4j.com/docs/getting-started/appendix/tutorials/guide-import-relational-and-etl/

LGTM


Suggested actions navigation arrows do not disappear as expected

After clicking on the horizontal navigation arrow in the quick answer area, if you don't click anything else and move the cursor away we get this behavior:

The CLICKED arrow doesn't disappear (still visible)
The other arrow disappears (becomes invisible)

For better understanding I am including this screenshot:

And forgot to add that the change in styleSet doesn't affect these arrows
ANOTHER BUG:
Another bug (that is included in version: "botframework-webchat": "^4.2.1-master.0dffd85",) is that the actions have quotes around them (you can notice them on the picture above) , while I am receiving them without quotes from directLine (checked in the json that I received).
BTW: I know that 4.2.1 is not official yet, but 4.2.0 is too broken for my implementation, sry.

If the button is focused, it won't slide away, for accessibility reason. That's why the button is still there.
Maybe we use a non-keyboard gesture to click on it, we should blur the focus. Need to investigate a good and reliable solution to differentiate between keyboard focus and mouse click focus.

Provide better focus indication on this element

@compulim @corinagum @tdurnford
Hello, @tdurnford tagged me on this, I'm not clear from this thread if we have figured out a fix for this or not? @compulim last comment seems to imply we need to research a better solution for Accessibility or do I just need some heavier focus lines to make it more obvious?? @corinagum looks like you "tapped" out on this one?

Yeah, @tdurnford is taking over this one. Right now there is no focus indication on the flippers, so he tagged you I guess to get your input. We discussed the possibility of adding distinction between a keyboard and mouse event, but @cwhitten is satisfied with us having focus indication to improve the UX. This will sufficiently indicate why the button doesn't immediately disappear.

Thanks @corinagum - @compulim do we have any Focus traits in WebChat currently? My MockBot isn't working to verify.

You can look at our sample bots to hunt around for focus indicators. Click the 'Try out MockBot' link on the sample.

Ah thanks that helped. I will pin that link.
looks like we have a couple of different focus options - They all seem a little bit different.
I would recommend we just align to the Fluent Web version that now being used on most everything and is available in Figma - with the CSS and redlines etc. Might make everything easier.
@tdurnford  @corinagum - I will text you a link, but I have attached a screen grab of their buttons.

the design specs above do not factor in the shape of the focus indicator, which is a circle.

Bumping the react-film dependency to the next version and adding the flipperBlurFocusOnClick to the suggested actions and attachment carousel film strip should resolve this issue.

react-film has been updated, now we need release and bump.


Add Falsehoods About Presidential Impeachments

Preliminary checks

[x] I have read the Code of Conduct
[x] I applied all rules from the Contributing guide
[x] I have checked there is not other Issues or Pull Requests covering the same topic to open

Summary
Further generations of programmers handling the history of the U.S. presidents should not believe they can express any kind of impeachment property as a truthy value.

That's a good one! 😁 Should be merged somewhat with the "Falsehoods About Political Appointments" entry in the list. Any reason you closed the PR?

That's a good one! 😁 Should be merged somewhat with the "Falsehoods About Political Appointments" entry in the list. Any reason you closed the PR?

It was somehow mentioned as joke, but since the tweeter posted a tweet where he mentioned the tweet wasn't widely taken as joke and got too many serious answers i got the impression he might take it offensive being taken as a "falsehood" example:
https://twitter.com/mountain_ghosts/status/1349773069859119105
Since i'm not a native speaker and might have gotten something wrong, i decided to close it before adding up to any misunderstandings/bad feelings.
But my first intend was to take the joke up - so i might just have failed on making clear the PR is a joke as well. :)

It was somehow mentioned as joke, but since the tweeter posted a tweet where he mentioned the tweet wasn't widely taken as joke and got too many serious answers i got the impression he might take it offensive being taken as a "falsehood" example:
https://twitter.com/mountain_ghosts/status/1349773069859119105
Since i'm not a native speaker and might have gotten something wrong, i decided to close it before adding up to any misunderstandings/bad feelings.
But my first intend was to take the joke up - so i might just have failed on making clear the PR is a joke as well. :)

Ahah no problem. I did took that tweet as a joke too. And a real case of a falsehood for instance.
But I agree: this might get too controversial and may be too early. You made a great judgment here to close your PR before things spirals out of hand.
 I did took that tweet as a joke too. And a real case of a falsehood for instance.
But I agree: this might get too controversial and may be too early. You made a great judgment here to close your PR before things spirals out of hand.