HashDB Lookup kills IDA on M1 macs

Tested versions:
main branch at 4d73263cffac975e1e47e67eb7fb55bfb85416a2
and release version 1.4.0
IDA Version:
Version 7.6.210427 macOS arm64
Python:
3.9.7
Steps to reproduce:

Load malshare sample (from OALabs YT Video)
https://malshare.com/sample.php?action=detail&hash=132fa71af952927e1961f735e68ae38a3305e7ae8d7197c170d071f74db60d1c

Right click on hash 992892395 in sub_4010D7
Select "HashDB Lookup"

Result: IDA crashes with "Oops! internal error 40217 occurred.

"

same

FYI Hex-rays has a fix for this and will provide you with fixed ida_kernwin for python2 and python3. Just contact<EMAIL_ADDRESS>


[Android] Unable to create >1 FPS video using AndroidSequenceEncoder

I'd like to create boomerang alike video (slideshow back and forth) using AndroidSequenceEncoder. I've managed to create video, but it looks like the FPS param in createSequenceEncoder method does not work. The goal is to achieve 75 ms delay between subsequenced encoded bitmaps but now all I can get is more or less 1 FPS. Am I missing something?
Used code:
AndroidSequenceEncoder ase = null;
String imageFileName = "video.mp4";
File finalVideoFilePath = new File(eventPhotosTempStorageDir, imageFileName);
Integer fps = 14;

try
{
        ase = AndroidSequenceEncoder.createSequenceEncoder(finalVideoFilePath, fps);
        for (int i = 1; i < photos.size(); i++) {
             for (int j = 0; j < fps; j++)
             {
                   ase.encodeImage(bitmaps.get(i));
             }
       }
       ase.finish();
}
catch (Exception e)
{
            e.printStackTrace();
}

If I read your code correctly it seems that you are adding each image 14
times, so you will get 1 frame per second (or 14 bit exact frames per
second).
On Wed, Sep 5, 2018 at 2:58 PM bartoszpalka<EMAIL_ADDRESS>wrote:

I'd like to create boomerang alike video (slideshow back and forth) using
AndroidSequenceEncoder. I've managed to create video, but it looks like the
FPS param in createSequenceEncoder method does not work. The goal is to
achieve 75 ms delay between subsequenced encoded bitmaps but now all I can
get is more or less 1 FPS. Am I missing something?
Used code:
`AndroidSequenceEncoder ase = null;
String imageFileName = "video.mp4";
File finalVideoFilePath = new File(eventPhotosTempStorageDir,
imageFileName);
Integer fps = 14;
try
{
ase = AndroidSequenceEncoder.createSequenceEncoder(finalVideoFilePath,
fps);
for (int i = 1; i < photos.size(); i++) {
for (int j = 0; j < fps; j++)
{
ase.encodeImage(bitmaps.get(i));
}
}
ase.finish();
}
catch (Exception e)
{
e.printStackTrace();
}`
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jcodec/jcodec/issues/355, or mute the thread
https://github.com/notifications/unsubscribe-auth/AEWd_KKvn4-P1gErwzHsz7wxPontcQJgks5uYEj5gaJpZM4Wbw7b
.

Indeed, you are clearly right! I thought that even if I'm declaring desired FPS rate I'd still have to take care of each subsequent frame. Thank you for your help.


optimize: optimize zk registry lookup performance

Ⅰ. Describe what this PR did
optimize: optimize zk registry lookup performance
see detail #3498
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

登记一下pr和作者信息到changes文件夹中2个的1.5.0.md中

Codecov Report

Merging #3795 (40868fe) into develop (107e0bf) will increase coverage by 0.00%.
The diff coverage is 40.00%.

:exclamation: Current head 40868fe differs from pull request most recent head 170c450. Consider uploading reports for the commit 170c450 to get more accurate results

@@            Coverage Diff             @@
##             develop    #3795   +/-   ##
==========================================
  Coverage      40.84%   40.84%
- Complexity      2955     2956    +1
==========================================
  Files            662      662
  Lines          22308    22312    +4
  Branches        2777     2777
==========================================
+ Hits            9111     9114    +3
  Misses         12349    12349
- Partials         848      849    +1

Impacted Files
Coverage Δ

...very/registry/zk/ZookeeperRegisterServiceImpl.java
60.90% <40.00%> (+0.43%)
:arrow_up:


Save and restore windows?

saving windows? Then restoring them?
With local-storage? 🤔

Great. I think this can be closed then.


[vcpkg] Update pull request template

Describe the pull request
Update the template to use Closing kewords, so that the PR could link to the issue automatically.
See https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

/azp run

Cool, looks good to me! :) Thanks @PhoebeHui


Unconfirmed tx considered as a valid payment on the dashboard.

This problem appears after #489

What exactly is the issue with this?


Reduce TTL time

There're something that I can do to reduce the time to load the page?
I have the php application on a server and the node on another

Hi there. That is heavily dependent on your website and how it's loading the page. Feel free to send a URL of your website to us at<EMAIL_ADDRESS>if you'd like us to take a look and see how you might improve the page render time.


Crunch Texture Replace Error.

E/Unity: The texture could not be loaded because it has been encoded with an older version of Crunch. This can happen when loading AssetBundles containing Crunch-compressed textures built with Unity version prior to 2017.3
(Filename:  Line: 32)
E/Unity: Failed to decompress Crunch texture data (size 512x512 format 65 mips 1)
(Filename:  Line: 747)
When I replace image which is "ETC2_RGBA8Crunched" format, it will show that log.
Unity Version 2019.4.28f1.
Thanks for your help.

Check latest build. I'm not entirely sure why this error happens though.


Part 3a of guide missing $nodeName

Part 3a of this guide under section "Enable the Hyper-V Role on your Azure Stack HCI Node" is missing the $nodeName in the script.
(https://github.com/Azure/AzureStackHCI-EvalGuide/blob/main/nested/steps/3a_AzSHCINodesGUI.md#enable-the-hyper-v-role-on-your-azure-stack-hci-node)
As a workaround, I created the variable for each node and ran through the script.

Thank you!  Will be fixed in the coming days as part of a larger rev - thank you!

Hey - this should be fixed in the updated steps - thanks!


[FEATURE] edit the css (hover effect) of the buttons

Description
will be adding some new feature on the buttons
Screenshots
No response
Additional information
No response

@anshulsoni4 currently we are focusing on bug free website


Critical - Websockets are not functioning

@chhsiao90 This is more of a critical issue. Please try https://www.chess.com/play/online with and without the proxy. Play as a guest. Without proxy works fine but without the proxy, the game doesn't start.
One of the web socket requests never receives a response (see request below). This looks like an upgrade to WebSocket request but doesn't get a response back.
Request URL: wss://services.chess.com/pubsub?uid=60effee6-29cc-11eb-a8b6-45984bd698ca&client_type=web&client_version=1.1.0&client_id=Q6QnQaZU

Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.9
Cache-Control: no-cache
Connection: Upgrade
Host: services.chess.com
Origin: https://www.chess.com
Pragma: no-cache
Sec-WebSocket-Extensions: permessage-deflate; client_max_window_bits
Sec-WebSocket-Key: oa5/OszTx/rzQ8y9Y1r/rg==
Sec-WebSocket-Version: 13
Upgrade: websocket
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.77 Safari/537.36

Query String:
uid: 60effee6-29cc-11eb-a8b6-45984bd698ca
client_type: web
client_version: 1.1.0
client_id: Q6QnQaZU

It goes to the forward handler I believe with the following issues:
13:30:25.004 [nioEventLoopGroup-3-8] DEBUG c.g.c.n.h.p.h.Http1BackendHandler - [Client (kubernetes.docker.internal:63798)] <=> [Server (services.chess.com:443)] : handlerAdded 13:30:25.005 [nioEventLoopGroup-3-8] DEBUG c.g.c.n.h.p.tls.TlsBackendHandler - [Client (kubernetes.docker.internal:63798)] <=> [Server (services.chess.com:443)] : handlerRemoved 13:30:25.018 [nioEventLoopGroup-3-8] DEBUG c.g.c.n.h.ForwardFrontendHandler - [Client (kubernetes.docker.internal:63798)] <=> [Server (services.chess.com:443)] : handlerAdded 13:30:25.019 [nioEventLoopGroup-3-8] DEBUG c.g.c.n.h.p.tls.TlsFrontendHandler - [Client (kubernetes.docker.internal:63798)] <=> [Server (services.chess.com:443)] : handlerRemoved 13:30:25.020 [nioEventLoopGroup-3-8] DEBUG c.g.c.n.listener.ForwardEventLogger - 474554202f7075627375623f7569643d6164...... (continues) 13:30:25.026 [nioEventLoopGroup-3-8] DEBUG c.g.c.n.h.ForwardFrontendHandler - [Client (kubernetes.docker.internal:63798)] <=> [Server (services.chess.com:443)] : PooledUnsafeDirectByteBuf(ridx: 0, widx: 1017, cap: 1039)
We need to detect HTTP protocol on the backend
I believe the issue is that ALPN fails on the back end but has a value on the front end I think. Regardless of what the ALPN outcome is on the back-end, I think we should still read a few bytes of data to make sure we are not missing an HTTP protocol vs. just forwarding it to the forwardhandler on ALPN failure.
Should we capture websocket frames?
Either way, I think it would be specifically good to intercept WebSocket requests to detect traffic as chats etc.

Detect connection upgrade and if the the upgrade is websocket
"Upgrade".equalsIgnoreCase(headers.get(HttpHeaderNames.CONNECTION)) &&            "WebSocket".equalsIgnoreCase(headers.get(HttpHeaderNames.UPGRADE)
Add a websocket handler and perform the websocket handshake (front and back end) on agreed upon sub protocol
Handle the WebSocketFrames in the handler including WebSocketFrame, read and intercept websocket text and binary frames and be able to handle those intercepts as well. Perhaps all we need is a onWebSocketSend(WebSocketFrame) and onWebSocketReceive(WebSocketFrame).

Please let me know if that works. This is the only main pending issue on my end at the moment.
Thanks,
Abbas

Supporting websocket should be the roadmap of nitmporxy. I can check and make the forward handler work before the websocket handle implemented.

Were you able to get the forward handler to work on chess.com?

It should work after #65 patch applied. Can you check if it fixed this issue? Then I can have a release.

Worked perfectly. Would appreciate a release when possible! Thank you.

HI @abbasvalliani - v1.3.4 just released!


inetChecksite does not work on Alpine Linux Docker Image

Describe the bug
Within a Nodejs environment on a 22-alpine Docker image, the inetChecksite always returns 404.
I'm trying to check the availability of a different domain on the same server in a different Docker image. Say, from nodejs backend of admin.example.com I am trying to check if example.com is available.
Also when I try to check if http://localhost:3000 is available, I get 404.
I have written a small script myself with the https package that works on Alpine.
import https from "https";

const checkWebsite = async (url: string): Promise<boolean> => {
  return new Promise((resolve) => {
    https
      .get(url, function ({ statusCode }) {
        resolve(
          statusCode === 200 ||
            statusCode === 301 ||
            statusCode === 302 ||
            statusCode === 304
        );
      })
      .on("error", function (e) {
        resolve(false);
      });
  });
};

To Reproduce
Steps to reproduce the behavior:

Host a nodejs app on node/22-alpine image
use inetChecksite

Current Output
{"url":"https://example.com","ok":false,"status":404,"ms":null}

Expected behavior
Correct status and ok: true
Environment (please complete the following information):

systeminformation package version: ^5.23.5
OS: Alpine Linux
Hardware VPS

Hi @timheerwagen, well yes, Alpine Linux does not include curl ... so I will rewrite this function to use nodes http and https ... then it is also more easy as I do not have to distinguish OS versions. Will provide a fix tomorrow.

@timheerwagen Version 5.23.19 just released ... Can you test it on your side?
Happy holidays ...

Thank you for your great work, I will have a look at it in the next few days. Happy holidays.


Additional AssetPath unit tests.

Objective
Additional unit test for AssetPath.

These are good tests! Kind of a nit, but I'd split these up into one assert per test. There's no setup and it makes debugging failures way easier.

Well, I'm just following the pattern for the tests already there - admittedly I wrote most of the tests in this file, but the ones I didn't write also have multiple asserts per tests.
That being said, I understand where you are coming from. I like to write tests that are linear and which "tell a story", meaning that if you read the tests in order it's like reading documentation. The test failure report will tell you the line number, so you'll know which assert it was.

Yeah, I can get behind that. I wouldn't have hassled you about it if you were a new contributor / junior engineer, but I figured it's a good opportunity for a conversation :)
Definitely consistent with the existing tests. My main gripe with it is when you get multiple panics in the same test, and they could be evaluated separately, it slows down your debugging by a cycle or two. No big deal though, this LGTM :)

Test granularity is definitely more art than science!

@alice-i-cecile The more interesting question, I think, is "what else in this file should be tested?".
I generally don't like tests for simple accessors, they are just clutter and don't add value. But anything that has an algorithm, or a non-obvious assumption, is fair game.
For example, it may seem silly to write a test that tests the value of a constant - unless that constant needs to have special properties, like being a prime number. The test guards against future programmers accidentally making the number non-prime.
I'm not sure that there's much value in testing the "Display" impl, since that's mostly used for debugging.


Remove duplicate CSS selector in classic theme

Closes #5100
This pull request includes a

[x] Bug fix
[ ] New feature
[ ] Translation

The following changes were made

Merge .select2-selection--multiple .select2-selection__choice rulesets.

Thanks!

Merged in 4.0.6-rc.1.  Thanks!


JAMES-2601 Implement a LDAP healthCheck

As the title says, added a new health checker to check LDAP server's health and tested it.
Note: checkShouldReturnHealthyIfLdapIsRunning failed when I ran it locally. Apparently, there is an exception thrown by the ldap user repository that says "Unable check user existence from ldap".
I'm sure that the test container has started because I can view it from Docker Desktop, but for some reason, the exception is still thrown.

@HoussemNasri do you agree with the fixes? Can we merge this?

Yes, please go ahead


bedtime messages are spamming the chat

We could make those into action-bar messages that get displayed for players in the relevant world. Thoughts?

Actionbar is what I would recommend, only problem is that vanilla also uses the action bar for bed related stuff.
Care is needed in testing to make sure that it doesn't obliterate the vanilla messages, without adding to it.

I can currently only remember "bed too far away", "monsters nearby" and "too far away" messages. are there any messages while sleeping?

1.17 introduces gamerules surrounding % based player sleep voting.
These messages are communicated via the action bars.

Ahh true! That almost makes the plugin obsolete haha

Do you know if it displayscurrent sleepers/required sleepers or current sleepers/players in world? Haven't got enough people at hand to test it myself.

I'd probably just send an action message when a player enters the bed, overriding the vanilla message.
It would be broadcast to the action bar of all players in the relevant world and display:
<player> is sleeping <n_sleeping>/<n_required>
@ryantheleach Any objections?


[DOC] OAuth2 Scope Endpoint not documented in IS 5.8.0 doc space

OAuth2 scope endpoint is documented for IS 5.7.0 at https://docs.wso2.com/display/IS570/Using+the+OAuth2+Scopes+REST+APIs
It seems to be missing from the IS 5.8.0 doc space.

Was this done intentionally?

This page is available in 5.8.0 here. It has just been renamed.
Asked infra to redirect the old url to the new one to avoid confusion.
https://docs.wso2.com/display/IS580/Using+OAuth2+Scopes+REST+APIs

Thanks for the prompt action @sherenewso2


Update minSdkLevel to 15. Remove all obsolete code and resources. #392

A lot of code and resources could be removed.

@lemonboston please rebase

Yep, this is the best :)


Sync Overview docs

Proposed changes
Sync overview docs
Merge timing
6/26
Related issues (optional)

Content was released in #6805


[BC Idea]: Allocation Accounts on Invoices using Get Receipt Lines and Purchase Receipts

BC Idea Link
https://experience.dynamics.com/ideas/idea/?ideaid=af053a8d-e3b5-ee11-92bd-000d3a0f8799
Description
Hi,
We have a problem with allocation accounts on invoices using "Get Receipt Lines".
Here are the steps to reproduce the problem we are facing.

Create a purchase order witha G/L account. Do not enter an cost accounting account no.
Receive this purchase order
Create a purchase  invoice and get the purchase receipt lines of the order by using "Get Receipt Lines".
Now enter a allocation account no. on the invoice line.

If you release this invoice and try to post it, you get a error that the invoice must be open.
If you leave the inovice open, and try to post it, you get the error that the receipt no. must be blank.
So you can never post an invoice from a purhase receipt.
Can this be fixed, please?
Kind regards.

@nikolakukrika - for your attention

Opened a bug to investigate and potentially fix this issue.
We have implemented a new functionality on the allocation accounts for 23.4. It will be possible to split the line on the purchase invoice, so you can modify each of the lines as you like


Contacts

It would be much preferable if there is a way of contacting developers through one of these platforms:

Discord (recommended)
Email
IRC
Matrix
If you are available @idobarnoam please take a look

+1 for Discord

You can contact me through twitter (@jonsneyers), email me (jon at cloudinary.com), or if you're lucky, find me on gitter (https://gitter.im/FLIF-hub/FLIF).
Note that FUIF will not be updated – we are now combining FUIF with Google's Pik and the result will be called JPEG XL (https://jpeg.org/jpegxl/).

@jonsneyers

Note that FUIF will not be updated – we are now combining FUIF with Google's Pik and the result will be called JPEG XL (https://jpeg.org/jpegxl/).

May you please update the top of the README with that same paragraph?
Updating in both FUIF and FLIF projects would be great.

Done.


Always returns one of the polygon vertices

nyukhalov, thank you for porting this to java. However, I tried performing this and unfortunately, it is only returning one of the input vertices. Is this a complete implementation?

I retested my input,
Instead of creating the polygon rings in the following manner,
protected static LatLng housePoleOfInaccessibility(List<Point> pointList){
    // The input param is a list of Point (com.mapbox.geojson.Point)
    // This Object is different to the Point object (com.mapbox.services.commons.geojson.Point) used in Polylabel
    List<List<Position>> rings = new ArrayList<>();
    List<Position> outer_ring = new ArrayList<>();

    // Creating outer ring
    for (int i=0; i<pointList.size()-1; i++){
        outer_ring.add(Position.fromCoordinates(pointList.get(i).latitude(), pointList.get(i).longitude()));
    }

    // Not concerned about inner ring
    // Polylabel also uses the 0 index (outer ring)
    rings.add(outer_ring);
    ...

I was creating them incorrectly,
protected static LatLng housePoleOfInaccessibility(List<Point> pointList){
      // The input param is a list of Point (com.mapbox.geojson.Point)
    // This Object is different to the Point object (com.mapbox.services.commons.geojson.Point) used in Polylabel
        List<List<Position>> rings = new ArrayList<>();
        // Creating outer ring
        for (int i=0; i<pointList.size()-1; i++){
            rings.add(Collections.singletonList(Position.fromCoordinates(pointList.get(i).latitude(), pointList.get(i).longitude())));
        }

Thanks again. It works like a charm.


feat: support google sheet chart and google doc images on chat

Details
Added support for pasting google sheet chart and google docs images into chat
I couldn't find a way to copy paste google sheet chart in mobile apps
Fixed Issues
Fixes https://github.com/Expensify/Expensify.cash/issues/1037
Tests

Open Expensify cash site on Website/Desktop app
Copy chart from Google Sheets / image from Google Docs
Paste in chat input box
Test if Image View modal open which will show pasted image/chart

Tested On

[X] Web
[ ] Mobile Web
[X] Desktop
[ ] iOS
[ ] Android

Screenshots

N/A

Web
https://user-images.githubusercontent.com/13379067/103633670-28890f80-4f6e-11eb-8118-f881511b466b.mov
Mobile Web
N/A
Desktop
https://user-images.githubusercontent.com/13379067/103633784-4ce4ec00-4f6e-11eb-94ac-1d22dc725819.mov
iOS
N/A
Android
N/A

Closing in favor of https://github.com/Expensify/Expensify.cash/pull/1146

Closing in favor of https://github.com/Expensify/Expensify.cash/pull/1146


TSC Open Meeting, January 31st 2019

NOTE: This meeting is on Thursday at 9am - 10am PT, 5pm-6pm UTC
Zoom Meeting link: https://zoom.us/j/975841675
In order to give some more visibility into the topics we cover in the TSC meetings here is the planned Agenda for the next meeting.  Hopefully this will allow people to plan to attend meetings for topics that they have an interest in.  And for folks who cannot attend they can comment on this issue prior to the meeting.  Feel free to suggest other potential agenda topics.
Proposed Agenda

Topic
Owner
Decision/NextStep

#1764 what's missing?
@ioggstream
Mike to split MutualAuth/scopes for all PR

Open PRs
@OAI/tsc

Triage: Issues marked for Review
@OAI/tsc

Triage: Unanswered issues
@OAI/tsc

Discuss/merge @handrews schema fixes
@webron

/cc @OAI/tsc Please add items as you see fit

Are the meetings recorded?

Are the meetings recorded?

They are. I'll try and get the necessary links and update the most recent issues.

@BelfordZ https://zoom.us/recording/share/OKlOsiieXC4Rgtpa5BRYTeVC3Psg23TPqTh5DiG3kQ-wIumekTziMw


Switch Python SDK harness entrypoint to use python3

Beam's Python SDK harness boot entrypoint may fail when python is not accessible, but python3 is.
fixes: #26958
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Successfully changes is being made by changing python to python3. Beam's python SDK issue #27236 solved

Run Dataflow Python ValidatesContainer

Run Python Dataflow ValidatesContainer

Thanks a lot for your contribution, @Prabin120. We can merge once the testsuite passes.

Actually, after some thinking, I think python is a valid command, and is referenced in official documents: https://docs.python.org/3/using/cmdline.html#command-line.
@Prabin120 I would suggest creating a helper function that identifies the python interpreter dynamically and falls back to to python3 if python is not available. We could run that function once per and reuse the return string in other calls.

we would be able to further use the helper function to make the interpreter configurable via an environment variable.

Thank you sir for pointing ou the pre defined function to check python version. I have made changes according to the function. Please verify.

All the changes is being made successfully.

waiting on author

Hi @Prabin120 , what are next steps on this PR? Do you need any help?

closing in favor of https://github.com/apache/beam/pull/28046


sometimes request have no response

i have use okhttp3 to request network.sometimes when i put a net request and l have set
mOkHttpClient = new OkHttpClient.Builder()                 .connectTimeout(CONNECTION_TIME_OUT, TimeUnit.SECONDS)                 .readTimeout(CONNECTION_TIME_OUT, TimeUnit.SECONDS)                 .writeTimeout(CONNECTION_TIME_OUT, TimeUnit.SECONDS)                 .retryOnConnectionFailure(true)                 .build();
CONNECTION_TIME_OUT is 10.but 15s later i can not get a response. if i still wait, the request still no response.it most like the request is holing up.
because when i close my wifi the requst can be response and the result is timeout exception. whate is wrong whit me?
later l got W/art: Suspending all threads took: 9.234ms . is this cause?

Thanks for your question. This issue tracker is only for bug reports with test cases and feature requests. Please ask usage questions on Stack Overflow.
https://stackoverflow.com/questions/tagged/okhttp


Ollie: Watch ukmalayaleematrimony.com

Ollie requests the watch of the watch_keyword ukmalayaleematrimony\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

ukmalayaleematrimony\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Quit button does nothing on html5 build

Not sure if it can do anything. Here's some info about Godot html5 limitations: https://docs.godotengine.org/en/3.1/getting_started/workflow/export/exporting_for_web.html
If it can't quit, we should send the game to a black screen and turn off audio.

i noticed the same behavior on my space jumper game. i guess its a browser limitation since it cannot quit the browser window for you (permission issue)

solved by pausing the game and showing a credits screen


Fix "Failed to execute 'appendBuffer'" exception

Chrome throws DOMException (Failed to execute 'appendBuffer' on 'SourceBuffer': This SourceBuffer is still processing an 'appendBuffer' or 'remove' operation.) when we try to call appendBuffer while sourceBuffer.updating is true.
Somehow it can be true even when we are in the updateend handler.

Released by v0.1.2


Unable to insert draw.io diagrams in Google Slides with "diagrams.net for Slides" Add-on

Describe the bug
While editing a Google Slide I try to insert one of the draw.io diagrams previously used, with "diagrams.net for Slides" Add-on . Then an error message pops up and the action is not completed. The error message is "We're sorry, a server error occurred while reading from storage. Error code PERMISSION_DENIED". If I try to insert it directly from the "Add-ons" button and after selecting the diagram and the page I wish to insert, this error message pops up:
"1 insert failed:

Leroy Merlin Customer Journey 2nd Draft- Scenario B May 2021.drawio: Request failed for https://convert.diagrams.net returned code 500. Truncated server response:

Up until yesterday I could insert the same page of the same draw.io file with no problem. No access right was changed as to explain the error described above.
To Reproduce
Steps to reproduce the behavior:

Press Google Slides button "Add-ons"
Press "diagrams.net for Slides" button
Press " Insert Diagrams " button
Select draw.io file I need and the page I need
Press "Insert" button

Expected behavior
The diagram from the page selected of the selected file should have been inserted in the slide.

Same issue on Google Docs 😢

Is this still happening now?

Fixed for me!
Thanks!

This looks stable in the logs. If it happens again add a comment or start another issue.

Just wanted to report that I was getting the same error using the add-on in Google Slides. The only difference between my use case and the OP is that I was inserting a diagram for the first time and it was .png instead of .drawio. I experienced the same behavior on 6/23 and 6/28.
I was able to get around it by copy/pasting the diagrams into a new diagram document of type .drawio and was then able to successfully insert them into Google Slides with the add-on.

+1
Embedding myDiagram.dawio from GoogleDrive in myGoogleDoc through addon "diagrams.net for Docs"
Response in modalWindow:
1 insert failed:

myDiagram.dawio: Request failed for https://convert.diagrams.net returned code 500. Truncated server response:

<html xmlns="http://www.w3.org/1999/... (use muteHttpExceptions option to examine full response).
<p>How can I help?

+1
Embedding myDiagram.dawio from GoogleDrive in myGoogleDoc through addon "diagrams.net for Docs"
Response in modalWindow:
1 insert failed:
* myDiagram.dawio: Request failed for https://convert.diagrams.net returned code 500. Truncated server response:

For me, helped recreating myDiagram.draw.io in GoogleDrive.
Now can't embed myDiagram.draw.io in Confluence Server as HTML (before it worked for another myOldDaigram.draw.io:
JSON.parse: end of data while reading object contents at line 1 column 2 of the JSON data
SyntaxError: JSON.parse: end of data while reading object contents at line 1 column 2 of the JSON data     createViewerForElement viewer-static.min.js:57594     processElements viewer-static.min.js:57569     forEach viewer-static.min.js:9201     processElements viewer-static.min.js:57566     onDrawioViewerLoad embed2.js:1     <anonymous> viewer-static.min.js:98895     <anonymous> viewer-static.min.js:98897 viewer-static.min.js:formatted:57572     processElements viewer-static.min.js:57572     forEach viewer-static.min.js:9201     processElements viewer-static.min.js:57566     onDrawioViewerLoad embed2.js:1     <anonymous> viewer-static.min.js:98895     <anonymous> viewer-static.min.js:98897

Insert/Update Error! 1 insert failed:

Final_project.png: Request failed for https://convert.diagrams.net returned code 500. Truncated server response:

Could you attach the diagram that failed please?


Issue while deploying Supervisor namespace in Invoke-DriDeployment

Code of Conduct

[X] I have read and agree to the Code of Conduct.
[X] Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
[X] Do not leave "+1" or other comments that do not add relevant information or questions.
[X] If you are interested in working on this issue or have submitted a pull request, please leave a comment.

VMware Cloud Foundation
5.1
Module Version
<IP_ADDRESS>7
PowerShell Version
7.3.6
PowerCLI Version
<IP_ADDRESS>24340
PowerVCF Version
<IP_ADDRESS>0
Guest Operating System
windows server 2019
Environment Details
No response
Description
Error while Deploying a Supervisor Namespace for Developer Ready Infrastructure for VMware Cloud Foundation
Error or Debug Output
Error at Script Line 9030
Relevant Command: $StatusMsg = Add-Namespace -Server $sddcManagerFqdn -user $jsonInput.sddcManagerUser -pass $jsonInput.sddcManagerPass -domain $jsonInput.tanzuSddcDomainName -Cluster $jsonInput.supervisorClusterName -Namespace $jsonInput.supervisorNamespaceName -StoragePolicy $jsonInput.storagePolicyName -WarningAction SilentlyContinue -ErrorAction SilentlyContinue -WarningVariable WarnMsg -ErrorVariable ErrorMsg
Error Message: Cannot validate argument on parameter 'server'. The argument is null or empty. Provide an argument that is not null or empty, and then try the command again.
Expected Behavior
It should work without any issues
Actual Behavior
In server input -server $jsonInput.sddcManagerFqdn  should be updated instead of -Server $sddcManagerFqdn
Steps to Reproduce
Run Invoke-driDeployment
Log Fragments and Files
No response
Screenshots
No response
References
No response

In server input -server $jsonInput.sddcManagerFqdn  should be updated instead of -Server $sddcManagerFqdn


Customisable Text Color To Support Dark Theme

Added a textColor variable inside the WysiwygComposerView that can be used to set programmatically at each update the color of the text.
By default the textColor variable is equal to label colour which is already dark theme responsive (black for light theme, white for dark theme).
The textColor  can either be customised in the init or using a view modifier in SwiftUI style.
Also fixed a concurrency bug that slowed down the loading of the view.

@langleyd Hey David I think I don't have yet permission to add labels to the PR, could you add it for me?


Add clustering logic to service

Describe your changes
Add clustering logic to the clustering service.
Checklist before requesting a review

[x] The code runs successfully.

(legislation-analysis-py3.11) michaelp@MacBook-Air-18 abortion-legislation-analysis % make cluster-data
python -m legislation_analysis --cluster -d
[nltk_data] Downloading package words to /Users/michaelp/nltk_data...
[nltk_data]   Package words is already up-to-date!
[nltk_data] Downloading package wordnet to
[nltk_data]     /Users/michaelp/nltk_data...
[nltk_data]   Package wordnet is already up-to-date!
/Users/michaelp/Documents/GitHub/abortion-legislation-analysis/.venv/lib/python3.11/site-packages/scipy/cluster/hierarchy.py:326: ClusterWarning: The symmetric non-negative hollow observation matrix looks suspiciously like an uncondensed distance matrix
  return linkage(y, method='complete', metric='euclidean')
/Users/michaelp/Documents/GitHub/abortion-legislation-analysis/.venv/lib/python3.11/site-packages/scipy/cluster/hierarchy.py:326: ClusterWarning: The symmetric non-negative hollow observation matrix looks suspiciously like an uncondensed distance matrix
  return linkage(y, method='complete', metric='euclidean')
/Users/michaelp/Documents/GitHub/abortion-legislation-analysis/.venv/lib/python3.11/site-packages/scipy/cluster/hierarchy.py:796: ClusterWarning: The symmetric non-negative hollow observation matrix looks suspiciously like an uncondensed distance matrix
  return linkage(y, method='ward', metric='euclidean')
/Users/michaelp/Documents/GitHub/abortion-legislation-analysis/.venv/lib/python3.11/site-packages/scipy/cluster/hierarchy.py:796: ClusterWarning: The symmetric non-negative hollow observation matrix looks suspiciously like an uncondensed distance matrix
  return linkage(y, method='ward', metric='euclidean')
(legislation-analysis-py3.11) michaelp@MacBook-Air-18 abortion-legislation-analysis %

The clustering files have been added to the Google drive, but it's likely quicker just to run the make command than to find them.


Switch from original rickfast consul-client library to kiwi project one

Only two changes are needed in the POM:

Change the groupId from com.orbitz.consul to org.kiwiproject
Add a version[^1]

[^1]: We used to control the version in kiwi-bom) since consul-client was an external library. But now that it is part of Kiwi Project, it is not in the BOM anymore and needs to be explicitly specified.

Currently this is blocked by https://github.com/kiwiproject/consul-client/issues/214
There is a temporary workaround, which is to include all the dependencies that consul-client requires, but I'd rather fix the root cause of the problem, and then come back here, though it will require changing the version in #99

https://github.com/kiwiproject/consul-client/issues/214 is now resolved, but I will need to do the 0.6.0 release of consul-client and then update the version in this PR.


chore: fix prow config for timeout

Surfaced in validation tests added via https://github.com/GoogleCloudPlatform/oss-test-infra/pull/1269

/cc @cjwagner

/test all


gherkin-c build fails with missing math lib (missing -lm flag)

Building the gherkin-c lib fails on *nix platforms as the math lib is not added in the build phase.
I'm reporting this error here as the gherkin-c subrepo is a slave.
Yadda, yadda, yadda: I've created a patchfile as a temporary workaround, however, it removes building the two executables (the token parser and the CLI) as they still fail and I never needed them anyway, just the C library.
I'm putting it here so that people who only want a working libgherkin.so (and .h files) for cucumber implementations in other languages (I'm coming from cucumber-ml) can fix their own clone and have a successful build.
As for the project maintainers, do whatever you wish with this.
--- CMakeLists.txt.orig	2018-08-31 19:33:59.135899166 +0200
+++ CMakeLists.txt	2018-08-31 19:41:11.467020875 +0200
@@ -68,29 +68,6 @@
 target_include_directories(gherkin PUBLIC
     "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include;${CMAKE_CURRENT_SOURCE_DIR}/src>")

-add_executable(gherkinexe ${GHERKIN_CLI})
-target_link_libraries(gherkinexe gherkin)
-target_include_directories(gherkinexe PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include ${CMAKE_CURRENT_SOURCE_DIR}/src)
-
-add_executable(gherkin_generate_tokens ${GENERATE_TOKEN})
-target_link_libraries(gherkin_generate_tokens gherkin)
-
-file(GLOB GOOD_FEATURE_FILES
-        ${CMAKE_CURRENT_SOURCE_DIR}/testdata/good/*.feature
-        )
-file(GLOB BAD_FEATURE_FILES
-        ${CMAKE_CURRENT_SOURCE_DIR}/testdata/bad/*.feature
-        )
-add_custom_target(invo DEPENDS invo)
-add_dependencies(invo gherkinexe)
-FOREACH(ENTITY ${GOOD_FEATURE_FILES})
-    add_custom_command(
-            TARGET gherkinexe
-            POST_BUILD
-            COMMAND gherkinexe  ${ENTITY}
-            DEPENDS invo
-    )
-ENDFOREACH()
 ############ Installation section ############
 set(include_install_dir "include")
 set(lib_install_dir "lib/")
@@ -104,6 +81,7 @@

 configure_file("${PROJECT_SOURCE_DIR}/cmake/Config.cmake.in" "${project_config}" @ONLY)

+target_link_libraries(gherkin m)
 # Install target (will install the library to specified CMAKE_INSTALL_PREFIX variable)
 install(
   TARGETS gherkin

(sorry if the previous is not obvious, the CMakeFile.txt to patch is the one in gherkin/c/.


[SPARK-26961][core] Enable parallel classloading capability

What changes were proposed in this pull request?
As per https://docs.oracle.com/javase/8/docs/api/java/lang/ClassLoader.html
Class loaders that support concurrent loading of classes are known as parallel capable class loaders and are required to register themselves at their class initialization time by invoking the ClassLoader.registerAsParallelCapable method. Note that the ClassLoader class is registered as parallel capable by default. However, its subclasses still need to register themselves if they are parallel capable.
i.e we can have finer class loading locks by registering classloaders as parallel capable.  (Refer to deadlock due to macro lock @ https://issues.apache.org/jira/browse/SPARK-26961).
All the classloaders we have are wrapper of URLClassLoader which by itself is parallel capable.
But this cannot be achieved by scala code due to static registration Refer https://github.com/scala/bug/issues/11429
How was this patch tested?
All Existing UT must pass

Ping @srowen @cloud-fan @dongjoon-hyun @vanzin

ok to test

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Test build #103625 has started for PR 24126 at commit 2e090e4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9026/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9028/
Test PASSed.

Test build #103627 has started for PR 24126 at commit 454b36d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9030/
Test PASSed.

Minor: in the PR title the component name is missing [Core].

Test build #103625 has finished for PR 24126 at commit 2e090e4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class NonClosableMutableURLClassLoader extends MutableURLClassLoader

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103625/
Test FAILed.

Test build #103627 has finished for PR 24126 at commit 454b36d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103627/
Test PASSed.

@attilapiros i have updated as per the comments. Please check

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9052/
Test PASSed.

Test build #103652 has started for PR 24126 at commit 35862db.

Test build #103652 has finished for PR 24126 at commit 35862db.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103652/
Test FAILed.

Jenkins retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9075/
Test PASSed.

Test build #103678 has started for PR 24126 at commit b73224c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9084/
Test PASSed.

Test build #103689 has started for PR 24126 at commit bc58445.

Test build #103689 has finished for PR 24126 at commit bc58445.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103689/
Test FAILed.

Test build #103689 has finished for PR 24126 at commit bc58445.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

I am not able to see the failed test here https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/103689/testReport/ can we rebuild this.?

The failure looks unrelated.

Test build #4638 has started for PR 24126 at commit bc58445.

Test build #4638 has finished for PR 24126 at commit bc58445.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

LGTM

BTW I re-read https://docs.oracle.com/javase/7/docs/technotes/guides/lang/cl-mt.html to make sure this change is consistent with how the JDK means this to be used, and it seems fine. The loadClass impls are just delegations.
I can merge this to master and want to back-port to 2.4/2.3; I'm only slightly hesitating to potentially get this in to 2.4 so late if we have another RC, but it's also an important fix.

Test build #4654 has started for PR 24126 at commit bc58445.

Test build #4654 has finished for PR 24126 at commit bc58445.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Jenkins retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9202/
Test PASSed.

Test build #103835 has started for PR 24126 at commit bc58445.

Test build #103835 has finished for PR 24126 at commit bc58445.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103835/
Test PASSed.

@ajithme if you can have a look at the last round of comments here and update, we can merge this for 2.4.1 RC9.

@vanzin i have updated the review comments
@srowen apologies for the delay. Have updated with fixes. Please check

Jenkins retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9227/
Test PASSed.

Test build #103863 has started for PR 24126 at commit 39a2d1e.

Test build #103863 has finished for PR 24126 at commit 39a2d1e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103863/
Test FAILed.

Jenkins restest this please

i doubt these failures are related. Any thoughts.? cc  @srowen

Test build #4657 has started for PR 24126 at commit 39a2d1e.

Test build #4659 has started for PR 24126 at commit 39a2d1e.

Test build #4659 has finished for PR 24126 at commit 39a2d1e.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

retest this please

Test build #103896 has started for PR 24126 at commit 39a2d1e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9259/
Test PASSed.

Test build #103896 has finished for PR 24126 at commit 39a2d1e.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103896/
Test FAILed.

retest this please

Test build #4662 has started for PR 24126 at commit 39a2d1e.

I think the second-to-last test actually passed, and failed because of the R UTF-8 change that was just reverted. I know we want to get this in ASAP for 2.4.1; let me try to trigger one more test and make a call.

Test build #4662 has finished for PR 24126 at commit 39a2d1e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #4665 has started for PR 24126 at commit 39a2d1e.

Test build #4665 has finished for PR 24126 at commit 39a2d1e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

OK, this test failed again, but it's another spurious failure. I'd like to merge this as we want to get this into 2.4.1, and it's holding up the RC. Based on the outcome at https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4659 I think this actually passed; the final step where the final R test checks the CRAN submission is all that failed. Support for that?

Test build #4667 has started for PR 24126 at commit 39a2d1e.

i think it's fine to merge.  R is finicky, and i agree that this seems spurious.

Merged to master/2.4/2.3. We did see a test pass on substantially the same change earlier too.

Test build #4667 has finished for PR 24126 at commit 39a2d1e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.


Build on macOS with Apple silicon (arm64)

what
Support building libModSecurity on macOS with Apple silicon (arm64)
why
Apple has been moving the macOS platform to Apple silicon (arm64) over the last few years (as of June 2023, the entire Mac lineup uses Apple silicon chips).
This PR fixes build configuration issues in pcre & yajl that prevented the library from compiling on newer versions of macOS (which probably apply to the x86_64 version of the OS too).
Additionally, it updates the GitHub quality assurance workflow to run now on macOS 14, which is an Apple silicon (arm64) runner image (see here).

This PR fixes build configuration issues in pcre & yajl that prevented the library from compiling on newer versions of macOS (which probably apply to the x86_64 version of the OS too).

The configure step of the build on macOS 14 with Apple silicon would trigger the following error:
checking for libpcre config script... no
configure: error: pcre library is required
configure: *** pcre library not found.

Having address the pcre issue, the build would still fail with the following error:
Error: transaction.cc:19:10: fatal error: 'yajl/yajl_tree.h' file not found
#include <yajl/yajl_tree.h>
         ^~~~~~~~~~~~~~~~~~
1 error generated.
make[3]: *** [libmodsecurity_la-transaction.lo] Error 1

Additionally, it updates the GitHub quality assurance workflow to run now on macOS 14, which is an Apple silicon (arm64) runner image (see here).

I replaced the macos-12 (x86_64) runner with the macos-14 (arm64) instead of just adding it in order not to multiply the number of configurations to build in the workflow.
NOTE: This doesn't imply dropping support for x86_64 on macOS though, but rather have visibility on the more representative architecture on the platform now.

Thanks again @eduar-hte.

airween@, I'm seeing builds today failing on the new macos-14 runner image.
I found about it while working on another PR and experiencing failures on the mac builds, which I initially thought were related to those changes, but it seems they were unrelated.
It's always the same regression tests:
(   2/  2/   4): test/test-cases/regression/config-secremoterules.json

but the configuration changes (for example macOS (wo ssdeep) or macOS (wo libxml)). However, the same configuration then builds on a follow up build, so it doesn't appear to be specific to one of them.
For example:

but then:

I think I saw you experience this yourself working on the CHANGES PR today, right? (this build) shows the same issue, but a follow up build run successfully.

It's always the same regression tests:
(   2/  2/   4): test/test-cases/regression/config-secremoterules.json

The strangest thing is that if I'm not reading things wrong, the test file only has three tests, and when the builds fail, they show that four were executed.
If you take a look at the CHANGES PR build that failed that I mentioned before, the macOS (wo ssdeep) configuration triggers the error and shows the listing above.
However, in the same build (and I would expect regression test .json file because all are built using the same repository commit) the macOS (wo libxml) configuration, which ran the tests successfully, shows:
(   3/  0/   3): test/test-cases/regression/config-secremoterules.json

Hi @eduar-hte,
yes, this is a very weird behavior and I'm not sure I understand what I see.
It's weird because when you sent the PR, all checks passed successfully. When I merge the PR, tests run again. In this case, the tests on macOS were failed. Then I re-run them again by hand, and all of them finished successfully.
And yes, there is a pending PR where I collect merged PR's for CHANGES, and after each commit the macOS tests were failed too.
It is very annoying that the failed tests are not consistent: every time a different test fails.
@theseion, @fzipi do you have any ideas what happens here?

It's always the same regression tests:
(   2/  2/   4): test/test-cases/regression/config-secremoterules.json

yes, I noticed that.

The strangest thing is that if I'm not reading things wrong, the test file only has three tests, and when the builds fail, they show that four were executed.

yes, you're right.

If you take a look at the CHANGES PR build that failed that I mentioned before, the macOS (wo ssdeep) configuration triggers the error and shows the listing above.

Maybe, I didn't noticed that. But now I looked up few other jobs and found this one:
Here you can see that the macOS (wo geoip) was the success test, and macOS (with pcre2) was the first failed build.
This was a job after merging your PR.

However, in the same build (and I would expect regression test .json file because all are built using the same repository commit) the macOS (wo libxml) configuration, which ran the tests successfully, shows:
(   3/  0/   3): test/test-cases/regression/config-secremoterules.json

Look at this
(   0/  0/   3): test/test-cases/regression/config-secremoterules.json

I think we definitely need to investigate this.
Do you have any macOS-14 environment?

If you take a look at the CHANGES PR build that failed that I mentioned before, the macOS (wo ssdeep) configuration triggers the error and shows the listing above.

Maybe, I didn't noticed that. But now I looked up few other jobs and found this one:
(...)

Yes, my point was that it's clearly related to macOS 14, but not the PR that I was currently working on (which I ended up spending a couple of hours trying to think how my changes could have broken those regression tests).

I think we definitely need to investigate this.

This is strange and started happening just today so I think it's related to a change in environment.
I went back to see all the actions executed in my fork for the macos-apple-silicon branch, and I noticed that all of them that run successfully (other than the in development changes in the branch, of course) were running macOS 14.5 (see here from 4 days ago) and 14..4.1 (see here from 3 months ago (!) when I worked on this).
And as far as I can see, all of the builds that fail are running on macOS 14.6, a GitHub runner image which was released yesterday and is currently being deployed, see here.

Do you have any macOS-14 environment?

Yes, I have a macOS mini that is running macOS 14.5, so I'll try to see if I can update it to macOS 14.6 and see if I can reproduce it there.

And as far as I can see, all of the builds that fail are running on macOS 14.6, a GitHub runner image which was released yesterday and is currently being deployed, see here.

The CHANGES PR build that failed (see here) ran on this new runner image (macOS 14.6):
Current runner version: '2.317.0'
Operating System
  macOS
  14.6
  [2](https://github.com/owasp-modsecurity/ModSecurity/actions/runs/10267749317/job/28409052099#step:1:2)3G80
Runner Image
  Image: macos-14-arm64
  Version: 20240805.[3](https://github.com/owasp-modsecurity/ModSecurity/actions/runs/10267749317/job/28409052099#step:1:3)

while the one that run successfully two hours later (see here) ran on the older one (macOS 14.5):
Current runner version: '2.317.0'
Operating System
  macOS
  14.5
  [2](https://github.com/owasp-modsecurity/ModSecurity/actions/runs/10269616749/job/28416468683#step:1:2)3F79
Runner Image
  Image: macos-1[4](https://github.com/owasp-modsecurity/ModSecurity/actions/runs/10269616749/job/28416468683#step:1:4)-arm64
  Version: 20240[7](https://github.com/owasp-modsecurity/ModSecurity/actions/runs/10269616749/job/28416468683#step:1:8)28.1

I'll try to see if I can update it to macOS 14.6 and see if I can reproduce it there.

I've updated my mac mini and found that the test Include remote rules - failed download (Abort) fails:
Test name: Include remote rules - failed download (Abort).
Reason:
failed!
Expected a parser error.
Expected: Failed to download: HTTP response code said error
Produced: Rules error. File: https://gist.githubusercontent.com/zimmerle/a4c1ec028999f7df71d0cc80f4f271ca/raw/4c74363bf4eae974180f1a82007196e58729dd16/modsecurity-regression-test-secremoterules-bonga.txt. Line: 1. Column: 0.
 - Failed to download: Failure when receiving data from the peer

The test configuration depends on a specific error message from curl/OS (HTTP response code said error), which seems to have changed (Failure when receiving data from the peer).
I'll create a new quick PR to simplify the test configuration and look just for Failed to download, which is the prefix added by the libModSecurity parser when logging the parser error.

I'll create a new quick PR to simplify the test configuration and look just for Failed to download, which is the prefix added by the libModSecurity parser when logging the parser error.

A build with this change running on macOS 16 shows that this change solves the issue, see here.
I had to trigger the build a couple of times because the first two ones were assigned a macOS 14.5 runner image, which would not have proven that the change addressed the issue.


WIP: Always Clean Workspace after build

Wrap all steps in try/finally.
Move CleanWs to finally block.
This ensures CleanWs always runs even if
the build has failed a step.
This also reverts #320 which stopped the
clean from running if the build failed.
Proper archiving should ensure we don't need
to leave workspaces around for test failure
investigation.

Signed-off-by: Adam Brousseau<EMAIL_ADDRESS>

Marking as WIP to give time for discussion.
@llxia @sophia-guo @ShelleyLambert

I agree with your first 2 sentences. I'm not sure I see the value the workspace will provide in the cases where a test has failed hard. The situations I can think of when a hard failure will occur:

Timeout
Build aborted
Machine config issue
Network issue
Unless I'm missing a use case, I don't see the value in keeping or archiving the workspace in any of these. Maybe there's a case where a failed test will actually cause the test harness to fall over?

The issue I'm trying to solve is machines running out of space because test workspaces getting left behind.

I would suggest to have a flag added in finally block, so that we can turn on and off to fit different needs.

Updated with KEEP_WORKSPACE


Add check for print statements

Just found a leftover print statement from #551.
Lets implement a linter to prevent this in the future.

[ ] Closes #xxxx
[ ] Tests added
[ ] Passes pre-commit run --all-files
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst

The hook used here is deprecated. We should use ruff with the following config:
[tool.ruff]
extend-select = ["T201"]

Closing in favor of #650


Improve configuration attributes matching strategy

Please do not merge this PR yet. This is for internal review only.
See gradle/performance#86 for discussion.

Closed in favor of #827


feat: migrate to busy-ipfs

Fixes #1568
Changes:

Upload images to busy-ipfs instead of Cloudinary.

Busy IPFS source code is there at the moment:
https://github.com/Sekhmet/busy-ipfs

This PR should close #1282

works fine for me, tested it on this post - https://busy-master-pr-1654.herokuapp.com/busy/@hellosteem/5smooc-testt


camel catalog controller

We should create a camel catalog controller that generates missing catalogs either by downloading them from an online resource and/or building them locally.

Catalog of camel components?

We should create a camel catalog controller that generates missing catalogs either by downloading them from an online resource and/or building them locally.

Catalog of Camel components?


Filter flaky query from galley dashboard test

In some test runs, the following query seems to lead to failures (example):
sum(rate(galley_runtime_strategy_timer_quiesce_reached_total[1m])) * 60
This PR filters that query out from consideration during the e2e test, with the goal of improved testing stability.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: douglas-reid
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ayj, douglas-reid
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@douglas-reid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow//e2e-simpleTests-minProfile.sh
77cf527329ecca8287259e28b5b17d003e9747e1
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow//e2e-simpleTests-minProfile.sh
77cf527329ecca8287259e28b5b17d003e9747e1
link
/test e2e-simpleTestsMinProfile

prow/e2e-mixer-no_auth-mcp.sh
77cf527329ecca8287259e28b5b17d003e9747e1
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow//e2e-simpleTests-minProfile.sh
77cf527329ecca8287259e28b5b17d003e9747e1
link
/test e2e-simpleTestsMinProfile

prow/e2e-mixer-no_auth-mcp.sh
77cf527329ecca8287259e28b5b17d003e9747e1
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-multicluster-e2e.sh
77cf527329ecca8287259e28b5b17d003e9747e1
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/approve
@douglas-reid
Any plan to restore it and get it fixed properly?

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, douglas-reid, hklai
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [hklai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow//e2e-simpleTests-minProfile.sh
77cf527329ecca8287259e28b5b17d003e9747e1
link
/test e2e-simpleTestsMinProfile

prow/e2e-mixer-no_auth-mcp.sh
77cf527329ecca8287259e28b5b17d003e9747e1
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-multicluster-e2e.sh
77cf527329ecca8287259e28b5b17d003e9747e1
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
77cf527329ecca8287259e28b5b17d003e9747e1
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-dashboard

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow//e2e-simpleTests-minProfile.sh
77cf527329ecca8287259e28b5b17d003e9747e1
link
/test e2e-simpleTestsMinProfile

prow/e2e-mixer-no_auth-mcp.sh
77cf527329ecca8287259e28b5b17d003e9747e1
link
/test e2e-mixer-no_auth-mcp

prow/e2e-dashboard.sh
77cf527329ecca8287259e28b5b17d003e9747e1
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


secret board stop to work

Describe the bug
stop to work

add ob_start(); on top page and it fix it


Some cleanups and bibliography fixes

@womullan I've had a go at cleaning up some things. It still fits in 10 pages.


Fix conflict main-develop

Description
Fix conflict between main and develop to allow merging #2497

Re-running the failing pre-job. See https://github.com/fkirc/skip-duplicate-actions/issues/301#issuecomment-1334988536.


Update insider-risk-management-policies.md

Removed add link option from the document

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/2569

@robmazz Please merge this PR. Thanks

Will update with correct link, thanks for catching this!


Service Temporarily Unavailable: http://flask-restful.readthedocs.io is down

The website doesn't seem to be working any more

Seems to working now. Weird. I tried accessing it with a VPN

Please report any future outages to the ReadTheDocs team. There's nothing I can do about about service interruptions on their site (or bad network configurations with your VPN).


improve support for V2 variant legacy checkpoints

This commit enhances support for V2 variant (epsilon and v-predict) import and conversion to diffusers, by prompting the user to select the proper config file during startup time autoimport as well as in the invokeai installer script. Previously the user was only prompted when doing an !import from the command line or when using the WebUI Model Manager.

@blessedcoolant Thank you!


no FAQ section

See the FAQ section for tips on putting Microsoft 365 Groups and Microsoft Teams on hold.
There isnt an FAQ section...and I would like to know about this topic..

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 115cfe0b-c8b5-193d-19da-a6f9c03fdfc0
Version Independent ID: 4a90cb9e-ce2a-a3f6-4b67-32f45c975323
Content: Manage holds in Advanced eDiscovery - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/managing-holds.md
Service: o365-seccomp
GitHub Login: @markjjo
Microsoft Alias: markjjo

@gnerd Thanks for the heads up. Will remove reference to FAQ (which doesn't exist). Here are a few articles that discussing placing sites and team on hold. The basics will be applicable to hold in Advanced eDiscovery.
https://docs.microsoft.com/en-us/microsoft-365/compliance/create-ediscovery-holds
https://docs.microsoft.com/en-us/microsoftteams/legal-hold


SqlServer Unhandled Exception

I am using Microsoft Visual Studio Community 2022 (64-bit) - Preview Version 17.8.0 Preview 1.0
I have installed the latest .NET8 SDK Version="8.0.0-rc.1.23421.29"
I implemented PersistenceProvider": "SqlServer and the system built the database ok. I logged in and went to Administrator and created 1 blog and submitted ok. However returning to the dashboard an unhandled exception error was encountered. After each restart the same error.
Just to get things working I tracked down the problem to: LinkDotNet.Blog.Domain BlogPost.cs line 28:
public IReadOnlyCollection Tags { get; private set; }
I changed this to:
public IList Tags { get; private set; }
This created a build error in: LinkDotNet.Blog.Web.Controller RssFeedContoller.cs line 98:
        s => new BlogPostRssInfo(s.Id, s.Title, s.ShortDescription, s.UpdatedDate, s.PreviewImageUrl, s.Tags),

I changed this to [add explicit cast]:
        s => new BlogPostRssInfo(s.Id, s.Title, s.ShortDescription, s.UpdatedDate, s.PreviewImageUrl, (IReadOnlyCollection<string>)s.Tags),

Then all worked.

Hey thanks for reporting the issue.
This is a known regression from preview 7 to rc 1: https://github.com/dotnet/efcore/issues/31722
That said, I will most likely revert the last commit with the update until the issue got fixed.

I reverted the last upgrade on master. That should make everything work again.

OK great - awesome project!

OK great - awesome project!

Thanks - if you have other issues/requests let me know.


Got MiioException while fetching the state: No response from the device

Device model / 设备型号
cubee.airrtc.th123e
Component version / 插件版本
0.7.4
HA core version / HA版本
2022.12.8
Integrated mode / 集成方式
Local (本地模式)
The problem / 问题详情
Device is not available or don't connect.
Entity attributes / 实体属性
xiaomi_miot:
  device_customizes:
    cubee.airrtc.th123e:
      miot_local: true
      chunk_properties: 1
      exclude_miot_services: heatold

Home Assistant Logs / 系统日志
2022-12-26 18:48:39.425 ERROR (SyncWorker_9) [miio.miioprotocol] Got error when receiving: timed out
2022-12-26 18:48:39.437 ERROR (MainThread) [custom_components.xiaomi_miot.climate] Санузел(cubee.airrtc.th123e): Got MiioException while fetching the state: No response from the device, mapping: {'thermostat.on': {'siid': 2, 'piid': 1}, 'thermostat.status': {'siid': 2, 'piid': 2}, 'thermostat.mode': {'siid': 2, 'piid': 4}, 'thermostat.target_temperature': {'siid': 2, 'piid': 5}, 'thermostat.temperature': {'siid': 2, 'piid': 7}}, max_properties: 1/5

Try unplugging the device from power.

@al-one  But I already tried that. And in MiHime app all devices is available and controlling.


Cropped image not showing

Expected Behavior
Cropped image should be shown when we click of 'Result' button
Actual Behavior
It is not showing cropped image on click of result button.
Steps to Reproduce the Problem
1.Download zip folder and extract it and run it in xampp.
2.Select image portion to be cropped.
3.Click the result button
Example Link
Please recreate your issue using JSbin, JSFiddle, or Codepen.

Link:
http://syscomprojects.com/aaa/Croppie-2.6.1/

Specifications

Browser:Firefox
Version:

You have missing libraries, so Croppie is throwing an error:

I have included the libraries, still not getting cropped image .
Url:-
http://syscomprojects.com/aaa/Croppie-2.6.1/

Same 404 as before. Check your path (/bower_components/dist) and make sure you've included the libraries.

Yes, now libraries error is not there. I am getting image tag alert but still not getting cropped image .
Check Url:-
http://syscomprojects.com/aaa/Croppie-2.6.1/

Solved it. Thanks for your interest as well as support.


WIP: refactor sockets

Some things don't work yet, but this is more or less ready to review.
@psychon

I don't have much time to look at this in depth, but do I understand correctly that you took Csocket, ripped out some of the internals and replaced them with calls to https://github.com/chriskohlhoff/asio?
What's the goal here? Is this supposed to be faster, more secure, ...?

do I understand correctly that you took Csocket, ripped out some of the internals

That's correct. I copied some functions over as is, but replaced most of it with asio. I chose asio because it's supposed to be included in C++20, at which point we can hopefully drop that library from dependencies and simply bump the compiler requirements.

What's the goal here? Is this supposed to be faster, more secure, ...?

It's less monolithic, so easier to modify. The main feature here are classes base_layer and optional_layer, which are combined in Pipeline. Currently there are only 2 layers (TCP and SSL), but more layers I can foresee:

encoding (for now I copied it from Csocket verbatim, but it would be cleaner as a separate layer)
socks proxy

I got an idea to do this long time ago, when was implementing encoding support in Csocket, but now the primary motivator to finally do it was Happy Eyeballs (#241), because #1571 has certain problems (races) which are not solvable outside of Csocket.

@jimloco could you also take a look? Note that I didn't implement full Csocket API, but parts which map to asio relatively easy and which are used in ZNC.

Status update: I don't like this callback hell, so trying to rewrite this using C++20 coroutines.

Update: this code I've written is terrible, and maintainable even less than existing Csocket.
Let's wait until a networking lands in C++ standard, be it asio or something else, then will look how to do such refactor in a better way.


Fix deprecation warnings in toolchain-nacl.cmake

Note that the first commit is #413
This bumps the CMake version to 3.13 and fixes deprecations warnings
that were raised in toolchain-nacl.cmake as well as deletes some code
paths that were for older CMake versions. Not that 3.13 is what's in
Debian stable and oldstable has backports for 3.16.
CMakeForceCompiler is deprecated so instead we set CMAKE_C/CXX_COMPILER
directly. This causes CMake to not set CMAKE_C/CXX_COMPILER_ID (because
it can't determine it automatically) so the CMakeLists.txt had to
support an empty CMAKE_CXX_COMPILER_ID and a special case for PCH
support on NaCl.
Getting a target's location as done in pnacl_translate is deprecated so
instead we compute the paths to the various targets/nexe/pexe directly
from the build dir and the gamemodule dir.
Fixes #412

Well it does succeed in allowing me to use Python 3 for the CBSE deps and Python 2 for NaCl.
There is no longer a cache variable like PYTHON_EXECUTABLE to control which Python is used (for either cbse or nacl). Is there any way to see or change this? It seems kind of annoying if there's no way to set the Python interpreter if it doesn't find the one you want.

Well it does succeed in allowing me to use Python 3 for the CBSE deps and Python 2 for NaCl.
There is no longer a cache variable like PYTHON_EXECUTABLE to control which Python is used (for either cbse or nacl). Is there any way to see or change this? It seems kind of annoying if there's no way to set the Python interpreter if it doesn't find the one you want.

I tried the following but it doesn't allow overriding the python executable from the cmake call: cmake .. -DPython2_EXECUTABLE=.... CMake should find the Python executable, and has over 3000 lines of code to do so in its builtin modules. Using a virtualenv would also make it detect Python.
But if worse comes to worse and someone need a variable to set Python, then we could add CBSE_PYTHON_EXECUTABLE and NACL_PYTHON_EXECUTABLE variables that you can override. It just seems unlikely to happen so if you don't mind I'll leave this out of this PR.

I tried the following but it doesn't allow overriding the python executable from the cmake call: cmake .. -DPython2_EXECUTABLE=.... CMake should find the Python executable, and has over 3000 lines of code to do so in its builtin modules. Using a virtualenv would also make it detect Python.
But if worse comes to worse and someone need a variable to set Python, then we could add CBSE_PYTHON_EXECUTABLE and NACL_PYTHON_EXECUTABLE variables that you can override. It just seems unlikely to happen so if you don't mind I'll leave this out of this PR.

I'm OK to postpone CBSE_PYTHON_EXECUTABLE and NACL_PYTHON_EXECUTABLE to another PR (if such need surfaces one day).
One question: does implementing CBSE_PYTHON_EXECUTABLE and NACL_PYTHON_EXECUTABLE would help to test various python interpreters? That may create the need.

I'm OK to postpone CBSE_PYTHON_EXECUTABLE and NACL_PYTHON_EXECUTABLE to another PR (if such need surfaces one day).
One question: does implementing CBSE_PYTHON_EXECUTABLE and NACL_PYTHON_EXECUTABLE would help to test various python interpreters? That may create the need.

Do you mean that it would help testing python2 vs python3 for CBSE (NaCl being forced to Python2 anyway)? Yeah that could be a good rational for adding these. I'll look at it tomorrow.

Do you mean that it would help testing python2 vs python3 for CBSE (NaCl being forced to Python2 anyway)? Yeah that could be a good rational for adding these. I'll look at it tomorrow.

Do you mean that it would help testing python2 vs python3 for CBSE?

Yes.
I feel no urge for that but I can see why we may need it at some point.

Do you mean that it would help testing python2 vs python3 for CBSE?

Yes.
I feel no urge for that but I can see why we may need it at some point.

Python2 is dying soon. Hopefully we can deprecate NaCl before then.

Python2 is dying soon. Hopefully we can deprecate NaCl before then.

Too late, Python2 is already unsupported :) but yeah my goal is to move to WASM (I know @slipher is already looking at it)

Too late, Python2 is already unsupported :) but yeah my goal is to move to WASM (I know @slipher is already looking at it)

Can you use a pattern like this?
set(CBSE_PYTHON_PATH "CBSEPYTHO-NOTFOUND" CACHE FILEPATH "decription")
if (NOT CBSE_PYTHON_PATH)
  FindPython()
  set(CBSE_PYTHON_PATH "${Python_Executable}" CACHE FILEPATH "decription" FORCE)
endif()

Can you use a pattern like this?
set(CBSE_PYTHON_PATH "CBSEPYTHO-NOTFOUND" CACHE FILEPATH "decription")
if (NOT CBSE_PYTHON_PATH)
  FindPython()
  set(CBSE_PYTHON_PATH "${Python_Executable}" CACHE FILEPATH "decription" FORCE)
endif()

Yup

Yup

This turns out harder than I thought for the NaCl toolchain because it is used in a different CMake invocation and would need piping of variables around etc. That one always uses Python2 so we don't need to allow configuring the Python executable as much so I left it as is. Does that sound ok?

This turns out harder than I thought for the NaCl toolchain because it is used in a different CMake invocation and would need piping of variables around etc. That one always uses Python2 so we don't need to allow configuring the Python executable as much so I left it as is. Does that sound ok?

This turns out harder than I thought for the NaCl toolchain because it is used in a different CMake invocation and would need piping of variables around etc. That one always uses Python2 so we don't need to allow configuring the Python executable as much so I left it as is. Does that sound ok?

OK makes sense - there is not much need to change the NaCl one since it doesn't have any dependencies.
Should fix the message that says Please install python2 and/or set the PYTHON_EXECUTABLE CMake variable. though.

Done, I'll merge this after CI results are in.

Done, I'll merge this after CI results are in.

I got some merge conflict while attempting to merge master to 0.52.0/sync (which is upcoming version), @Kangz can you merge yourself master to 0.52.0/sync Dæmon branch and then sync the new daemon submodule reference in Unvanquished 0.52.0/sync branch?

I got some merge conflict while attempting to merge master to 0.52.0/sync (which is upcoming version), @Kangz can you merge yourself master to 0.52.0/sync Dæmon branch and then sync the new daemon submodule reference in Unvanquished 0.52.0/sync branch?

Ok I'll take a look

Ok I'll take a look


Support for Adobe XD?

On you website, i have seen the new section FOR DESIGNER - really great, but i am working with Adobe XD and not with Sketch... Please add Support for Adobe XD, an also great tool for UI/UX-Experience
Many Thanks

@ITforHome have you tried to open the evergreen .sketch in Adobe XD?
Adobe XD does have the Sketch file support and "Evergreen Community v4.sketch" opens alright for me, at first sight don't see anything wrong with it.

AFAIK we don't have any immediate plans for Adobe XD files, but we'll take it into consideration for the roadmap with the design team.


prolem in ros for bebop?

when I Install the bebop in ros,I face the problem
Create and initialize the workspace
$ mkdir -p ~/bebop_ws/src && cd ~/bebop_ws
$ catkin init
$ git clone https://github.com/AutonomyLab/bebop_autonomy.git src/bebop_autonomy
Update rosdep database and install dependencies (including parrot_arsdk)
$ rosdep update
$ rosdep install --from-paths src -i
above all are successful
but when I next
Build the workspace
$ catkin build -DCMAKE_BUILD_TYPE=RelWithDebInfo
the problems are appearing
Failed     << bebop_driver:make                [ Exited with code 2 ]
Failed    <<< bebop_driver                     [ 37.9 seconds ]
Abandoned <<< bebop_tools                      [ Unrelated job failed ]
[build] Summary: 2 of 4 packages succeeded.
[build]   Ignored:   1 packages were skipped or are blacklisted.
[build]   Warnings:  None.
[build]   Abandoned: 1 packages were abandoned.
[build]   Failed:    1 packages failed.
[build] Runtime: 43.7 seconds total.
[build] Note: Workspace packages have changed, please re-source setup files to use them.
How to slove this problem?

Hello,
Sorry for the late comment. Please see issue #118, I believe the solution to this should work for the problem you have been having. I will repeat it here, instead of running
catkin build -DCMAKE_BUILD_TYPE=RelWithDebInfo
Run
catkin build
instead. Please let us know if this solves your problem.
Thanks.

Hi there, i get the same issue after running catkin build as well, any suggestions?

What version of ROS are you trying to install this for?

Installing on ROS Kinetic and getting the same error, can you please help. I saw different threads and followed the instructions but cound't get past this error.

Hi there, i get the same issue after running catkin build as well, any suggestions?

me too. running ros kinetic on ubuntu 16.04

Any updates? Getting same error on ROS-Kinetic ubuntu 16.04

Any updates? Getting same error on ROS-Kinetic ubuntu 16.04

I don't remember what I did but I found bebop drone in a Rotors simulator, you can also get try Rotors simulator in another workspace. I'm working with Ardrone by the way.


Don't have support to start parameter when fetching subscriptions

Hello!
Today Iugu API endpoint to fetch all subscriptions has a limitation of 100 items per response. To navigate between the pages, we should use a parameter start to move between the pages/items. But the Iugu::Subscription#fetch doesn't support this. Would be cool to add this.

Is this library still maintained by Iugu?

While it's not supported you can do something like this:
start = 0
limit = 100
total = 1
while start < total
  subscriptions = ::Iugu::Subscription.fetch("?start=#{start}&limit=#{limit}")
  start += limit
  total = subscriptions.total
end


Implement LoggingAsync for GRPC Worker Services

This allow RecvTensor events to show up in StepStats and in turn in Chrome Tracing format.

Can one of the admins verify this patch?

@pbar @mrry @suharshs Could you please take a look at this?

Reassigning this to @prb12, since he knows the ins and outs of the logging path better than I do. A few quick observations though:

Instead of modifying the BaseRendezvousMgr and related classes to capture this information, please use the existing stubs in GrpcWorkerCache:
https://github.com/tensorflow/tensorflow/blob/c0662f1620c2b97abb79b8ae6a8a30f7c7719475/tensorflow/core/distributed_runtime/rpc/grpc_worker_cache.cc#L86-L92

The changes in master_session.cc are potentially controversial, because they could cause a lot of additional logging to be generated when FULL_TRACE is specified. We might need an additional TraceLevel for this case.

Run clang-format -style=Google over the code to take care of style issues (which should trigger a failure in the presubmit).

Thanks @mrry for the feed back:

I changed the implementation to use SessionMgr instead of *RendezvousMgr.
Note that unlike other worker rpcs, LoggingRequest in  LoggingAsync rpc does not have any session handle, therefore all sessions should be touched. Both implementations (previous one, and this one) iterates over all sessions (previously through RendezvousMgr now SessionMgr), then uses GrpcWorkerCache calls in each session.

@pbar: Thoughts on changes in master_session.cc?

@xldrx can you look into the merge conflicts.

Hey @sb2nov,
It seems that Paul is swamped. Could you review this PR?


🖐 How to run dagger inside a container ?

Dagger Cloud run URL
https://dagger.cloud/runs
What happened? What did you expect to happen?
There are multiple examples in the docs about running dagger using multiple CI's, but I want to run dagger in a Kubernetes pod.
I was wondering on how to run dagger inside a container? if possible without requiring access to docker sock, or using a privileged container.
thanks in advance

I would like to see this as well. Especially as to how to run dagger in containerized platforms such as Kubernetes and Openshift

I would like to see an example of it, especially in docker because this
should be part of the developer tools, and if we can have all dev tools in
a repo, dockerized it is easy to keep the same environment in the team,
versions, etc. Not so many devs have a k8s or the likes running locally
however I would like to understand the use case for you guys that have
asked for it.
On Fri, Apr 28, 2023 at 4:04 AM thecooldrop @.***>
wrote:

I would like to see this as well. Especially as to how to run dagger in
containerized platforms such as Kubernetes and Openshift
—
Reply to this email directly, view it on GitHub
https://github.com/dagger/dagger/issues/3140#issuecomment-1527229460,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC2GGVOZFQDDPTUC4MLXFL3XDOBZVANCNFSM6AAAAAAQQ42VSQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Eng. Francisco Castañeda

For me it would be sufficient to see how we can run dagger within a rootless container. Namely a container where I do not have to have access to root. This would then enable me to run the dagger in any containerized environment. Mostly that would mean that I can use dagger in my Jenkins, while using Kubernetes Pods as agent nodes, where I can then have elastically scaling Jenkins server as load increases or decreases, while still retaining the capability to run the pipelines locally.

Hi @thecooldrop , @chopanpma , and @kajogo777 !  We are actively working on this. I highly recommend joining the Dagger Community call on June 1st. @gerhard and @kpenfound will be doing a demo about this topic.
You can register here: https://dagger-io.zoom.us/webinar/register/4416686668409/WN_USQjVBGXT0SWhNMvqYVvCA#/registration

@mircubed signed up! We are looking to modernize our CI from Jenkins to a combination of Argo Workflows + Dagger CI, feels like this may be the feature we are looking for in Dagger.

Hi @mircubed was the community call recorded? I wasn't able to make it due to timezones.

I am also looking for this !
I can add my 2 use cases also
Again using Argo Workflow for CI/CD (i.e Argo suite with ArgoCD Argo Workflows Argo Events ...)
Also would like to have builds local inside k8s i.e something like ...
https://www.talos.dev/v1.4/talos-guides/install/local-platforms/docker/

This might help: 🎬 https://www.youtube.com/watch?v=c93_EsedP1s

See the code: docker run -it --entrypoint nvim registry.dagger.io/equinix-demo-day-2023 .

use dagger in my Jenkins, while using Kubernetes Pods as agent nodes

In principle this should be possible using Sysbox. I failed to install it on GKE, however.

Just a quick note that we now have a few guides on the topics mentioned above:
Dagger on Kubernetes: https://docs.dagger.io/194031/kubernetes
Dagger with Argo Workflows: https://docs.dagger.io/324301/argo-workflows
Dagger with Tekton: https://docs.dagger.io/213240/tekton


correct overview link

https://www.cloudflare.com/overview.html returns "The page you are looking for cannot be found."

Hi Peter,
Great catch!  Appreciate the fix, thanks for your contribution!
Thanks,
John


Public Release r1.3

What type of PR is this?
Add one of the following kinds:

documentation
subproject management

What this PR does / why we need it:
Generation of Public Release r1.3 (patch release for adding documentational info)
API Specs already updated in #183
Updated:

README.md
CHANGELOG.md
APIs readiness checklist file

Which issue(s) this PR fixes:
Fixes #192
Special notes for reviewers:
Taking advantage of the PR Meetings time is updated to be referenced to UTC Time
Changelog input
Public Release r1.3

Additional documentation
N/A

cc @bigludo7, @rartych if you can review next week.
Would like to merge next week if possible in order to begin work around Metarelease Spring 25

@PedroDiez @bigludo7 I created https://github.com/camaraproject/ReleaseManagement/issues/124 as Release Management wasn't involved in this public release (but should had), and therefore some followup activities are open.


feat: page header component

Changed:

[ ] Added Page Header to components page
[ ] Added Carbon Pictograms package for component page

@andreancardona I'd only use - [ ] checkbox markdown in PR descriptions if there are outstanding tasks.


Add logging message for debug/error

This changes adds initial logging messages:debug and error.
Error messages:
fmt.Errorf() is wrapped by logging.Errorf() hence all error message is also put to log file.
Debug messages:
Added logging.Debugf() at the head of almost func, so we could track the code by logging message.

@rkamudhan and @dougbtv ,
Fixing conflicts for rebase/merge commits.

In https://github.com/intel/multus-cni/blob/master/logging/logging.go#L118, it create the file if there is not.
Is that enough?

Just run this PR.. It is working fantastically as expected.. LGTM..


Integrate Set-of-Mark Visual Prompting for GPT-4V

I noticed that you currently seem to apply a grid to the images to assist the vision model:

https://github.com/OthersideAI/self-operating-computer/blob/main/operate/main.py#L462-L527

And mention this in the README:

Current Challenges
Note: The GPT-4v's error rate in estimating XY mouse click locations is currently quite high. This framework aims to track the progress of multimodal models over time, aspiring to achieve human-level performance in computer operation.

I was wondering, have you looked at using Set-of-Mark Prompting Visual Prompting for GPT-4V / similar techniques?
See Also
A bit of a link dump from one of my references:

https://github.com/microsoft/SoM

Set-of-Mark Prompting for LMMs

Set-of-Mark Visual Prompting for GPT-4V

We present Set-of-Mark (SoM) prompting, simply overlaying a number of spatial and speakable marks on the images, to unleash the visual grounding abilities in the strongest LMM -- GPT-4V. Let's using visual prompting for vision!

https://arxiv.org/abs/2310.11441

Set-of-Mark Prompting Unleashes Extraordinary Visual Grounding in GPT-4V

We present Set-of-Mark (SoM), a new visual prompting method, to unleash the visual grounding abilities of large multimodal models (LMMs), such as GPT-4V. As illustrated in Fig. 1 (right), we employ off-the-shelf interactive segmentation models, such as SEEM/SAM, to partition an image into regions at different levels of granularity, and overlay these regions with a set of marks e.g., alphanumerics, masks, boxes. Using the marked image as input, GPT-4V can answer the questions that require visual grounding. We perform a comprehensive empirical study to validate the effectiveness of SoM on a wide range of fine-grained vision and multimodal tasks. For example, our experiments show that GPT-4V with SoM in zero-shot setting outperforms the state-of-the-art fully-finetuned referring expression comprehension and segmentation model on RefCOCOg. Code for SoM prompting is made public at: this https URL.

https://github.com/facebookresearch/segment-anything

Segment Anything

The repository provides code for running inference with the SegmentAnything Model (SAM), links for downloading the trained model checkpoints, and example notebooks that show how to use the model.

The Segment Anything Model (SAM) produces high quality object masks from input prompts such as points or boxes, and it can be used to generate masks for all objects in an image. It has been trained on a dataset of 11 million images and 1.1 billion masks, and has strong zero-shot performance on a variety of segmentation tasks.

https://github.com/UX-Decoder/Semantic-SAM

Official implementation of the paper "Semantic-SAM: Segment and Recognize Anything at Any Granularity"

In this work, we introduce Semantic-SAM, a universal image segmentation model to enable segment and recognize anything at any desired granularity. We have trained on the whole SA-1B dataset and our model can reproduce SAM and beyond it.

Segment everything for one image. We output controllable granularity masks from semantic, instance to part level when using different granularity prompts.

https://github.com/UX-Decoder/Segment-Everything-Everywhere-All-At-Once

SEEM: Segment Everything Everywhere All at Once

[NeurIPS 2023] Official implementation of the paper "Segment Everything Everywhere All at Once"

We introduce SEEM that can Segment Everything Everywhere with Multi-modal prompts all at once. SEEM allows users to easily segment an image using prompts of different types including visual prompts (points, marks, boxes, scribbles and image segments) and language prompts (text and audio), etc. It can also work with any combination of prompts or generalize to custom prompts!

https://github.com/IDEA-Research/GroundingDINO

Official implementation of the paper "Grounding DINO: Marrying DINO with Grounded Pre-Training for Open-Set Object Detection"

https://github.com/IDEA-Research/OpenSeeD

[ICCV 2023] Official implementation of the paper "A Simple Framework for Open-Vocabulary Segmentation and Detection"

https://github.com/IDEA-Research/MaskDINO

[CVPR 2023] Official implementation of the paper "Mask DINO: Towards A Unified Transformer-based Framework for Object Detection and Segmentation"

https://github.com/facebookresearch/VLPart

[ICCV2023] VLPart: Going Denser with Open-Vocabulary Part Segmentation

Object detection has been expanded from a limited number of categories to open vocabulary. Moving forward, a complete intelligent vision system requires understanding more fine-grained object descriptions, object parts. In this work, we propose a detector with the ability to predict both open-vocabulary objects and their part segmentation.

https://github.com/ddupont808/GPT-4V-Act

GPT-4V-Act: Chromium Copilot

AI agent using GPT-4V(ision) capable of using a mouse/keyboard to interact with web UI

GPT-4V-Act serves as an eloquent multimodal AI assistant that harmoniously combines GPT-4V(ision) with a web browser. It's designed to mirror the input and output of a human operator—primarily screen feedback and low-level mouse/keyboard interaction. The objective is to foster a smooth transition between human-computer operations, facilitating the creation of tools that considerably boost the accessibility of any user interface (UI), aid workflow automation, and enable automated UI testing.

GPT-4V-Act leverages both GPT-4V(ision) and Set-of-Mark Prompting, together with a tailored auto-labeler. This auto-labeler assigns a unique numerical ID to each interactable UI element.
By incorporating a task and a screenshot as input, GPT-4V-Act can deduce the subsequent action required to accomplish a task. For mouse/keyboard output, it can refer to the numerical labels for exact pixel coordinates.

https://openai.com/research/gpt-4v-system-card

GPT-4V(ision)

https://github.com/Jiayi-Pan/GPT-V-on-Web

👀🧠 GPT-4 Vision x 💪⌨ Vimium = Autonomous Web Agent

This project leverages GPT4V to create an autonomous / interactive web agent. The action space are discretized by Vimium.

I am trying to implement SoM, since it seems to have the best accuracy.

@Daisuke134 interested to see what you find. I'm going to go learn more about SoM

@0xdevalias read up more on SoM. It looks like a very promising approach, thank you for opening this issue!
https://github.com/microsoft/SoM

read up more on SoM. It looks like a very promising approach, thank you for opening this issue!

No worries :)

So I'm still looking into the projects and this project(https://github.com/Jiayi-Pan/GPT-V-on-Web) uses vimium and GPT4V. I was testing with this a little.

It seems to use keyboards pretty accurately just by prompting things like
"- d: Scrolls down.

u: Scrolls up.
"

Also, the labeling seems to be quite accurate(image of Youtube)

SoM seems to be a pretty accurate but slow, but vimium seems to be pretty fast. I will try implementing vimium first and then compare the accuracy/speed with SoM..

I am implementing SoM now, and seems like the best way is to make another mode like som-mode and make a new prompt for the mode.

@Daisuke134 @0xdevalias Set-of-Mark prompting is now available. Swap in your best.pt from a YOLOv8 model and see how it performs!


HSEARCH-4541 Catch load exception and pass to failure handler

https://hibernate.atlassian.net/browse/HSEARCH-4541
I'm not sure if that's what you expected, but while I was trying to create some reproducer of the problem, here are the changes I've made 😄
The test fails two batches, but the remaining ones are still completed, and in the end, an exception is thrown by indexer.startAndWait();
As for the logging of failed IDs, there's already a trace log in place, so I assume that covers it.

ohh same test names for pojo mapper played a joke with me 😄 I was looking at their ORM counterparts and thinking why it works through IDE but not with maven  build. Applied same changes to pojo tests, should be better now 😃


Can we remove demo folder from the repository?

This folder is also included into the gem package.

Please feel free to PR, either extracting demo from the repo into a new one or just excluding demo files from the gem would suffice.