[BUG] Error while merging from master

Running migrations:
  Applying account.0001_initial... OK
  Applying account.0002_email_max_length... OK
  Applying build.0031_build_reference_int... OK
  Applying build.0032_auto_20211014_0632... OK
  Applying common.0012_notificationentry... OK
  Applying order.0051_auto_20211014_0623... OK
  Applying order.0052_auto_20211014_0631...Traceback (most recent call last):
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/utils.py", line 108, in debug_sql
    yield
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/utils.py", line 98, in execute
    return super().execute(sql, params)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/utils.py", line 66, in execute
    return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/utils.py", line 75, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/sqlite3/base.py", line 423, in execute
    return Database.Cursor.execute(self, query, params)
OverflowError: Python int too large to convert to SQLite INTEGER

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/migrations/executor.py", line 227, in apply_migration
    state = migration.apply(state, schema_editor)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/migrations/migration.py", line 126, in apply
    operation.database_forwards(self.app_label, schema_editor, old_state, project_state)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/migrations/operations/special.py", line 190, in database_forwards
    self.code(from_state.apps, schema_editor)
  File "/home/inventree/InvenTree/order/migrations/0052_auto_20211014_0631.py", line 44, in build_refs
    order.save()
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/models/base.py", line 726, in save
    self.save_base(using=using, force_insert=force_insert,
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/models/base.py", line 763, in save_base
    updated = self._save_table(
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/models/base.py", line 845, in _save_table
    updated = self._do_update(base_qs, using, pk_val, values, update_fields,
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/models/base.py", line 899, in _do_update
    return filtered._update(values) > 0
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/models/query.py", line 802, in _update
    return query.get_compiler(self.db).execute_sql(CURSOR)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/models/sql/compiler.py", line 1559, in execute_sql
    cursor = super().execute_sql(result_type)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/models/sql/compiler.py", line 1175, in execute_sql
    cursor.execute(sql, params)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/utils.py", line 98, in execute
    return super().execute(sql, params)
  File "/usr/lib/python3.8/contextlib.py", line 131, in __exit__
    self.gen.throw(type, value, traceback)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/utils.py", line 113, in debug_sql
    sql = self.db.ops.last_executed_query(self.cursor, sql, params)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/sqlite3/operations.py", line 159, in last_executed_query
    params = self._quote_params_for_last_executed_query(params)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/sqlite3/operations.py", line 148, in _quote_params_for_last_executed_query
    return cursor.execute(sql, params).fetchone()
OverflowError: Python int too large to convert to SQLite INTEGER

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "manage.py", line 22, in <module>
    execute_from_command_line(sys.argv)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/core/management/__init__.py", line 419, in execute_from_command_line
    utility.execute()
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/core/management/__init__.py", line 413, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/core/management/base.py", line 354, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/core/management/base.py", line 398, in execute
    output = self.handle(*args, **options)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/core/management/base.py", line 89, in wrapped
    res = handle_func(*args, **kwargs)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/core/management/commands/migrate.py", line 244, in handle
    post_migrate_state = executor.migrate(
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/migrations/executor.py", line 117, in migrate
    state = self._migrate_all_forwards(state, plan, full_plan, fake=fake, fake_initial=fake_initial)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/migrations/executor.py", line 147, in _migrate_all_forwards
    state = self.apply_migration(state, migration, fake=fake, fake_initial=fake_initial)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/migrations/executor.py", line 230, in apply_migration
    migration_recorded = True
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/sqlite3/schema.py", line 35, in __exit__
    self.connection.check_constraints()
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/sqlite3/base.py", line 329, in check_constraints
    violations = cursor.execute('PRAGMA foreign_key_check').fetchall()
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/utils.py", line 98, in execute
    return super().execute(sql, params)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/utils.py", line 66, in execute
    return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/utils.py", line 75, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/utils.py", line 78, in _execute
    self.db.validate_no_broken_transaction()
  File "/home/inventree/dev/env/lib/python3.8/site-packages/django/db/backends/base/base.py", line 447, in validate_no_broken_transaction
    raise TransactionManagementError(
django.db.transaction.TransactionManagementError: An error occurred in the current transaction. You can't execute queries until the end of the 'atomic' block.
ERROR: 1

I think I should switch SQLite to Postgres


Install on ubuntu 20.04 failed due to missing build folder

@kiswa  - first of all thank you for developing this and kudos for making a useful straight to the point web app.
Describe the bug
I followed instruction on
https://vitux.com/how-to-install-taskboard-kanban-on-debian-10/
https://www.howtoforge.com/how-to-install-and-configure-taskboard-on-ubuntu-1804/
https://computingforgeeks.com/how-to-install-and-configure-taskboard-on-ubuntu-18-04-lts/
https://www.rosehosting.com/blog/how-to-install-taskboard-on-ubuntu-18-04/
I am stuck at the point where composer command
/build/composer.phar self-update
-bash: ./build/composer.phar: No such file or directory
Then I look at install instruction on https://github.com/kiswa/TaskBoard  -  It is vastly different. Please advise what you recommend me to do next. Thank you.
====================================================
Installing TaskBoard is as easy as 1, 2, 3!
Download the latest release since v1.0.0
Extract it to your webserver
Verify the api directory is writable

====================================================
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Please complete the following information:

OS: [e.g. Windows 10]
Browser [e.g. Chrome, Firefox]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Any instructions created elsewhere are no longer accurate since the release of v1.0.0. Please use the instructions in the README to install.


Make sure to end status on cloud commands

When running cloud prepare or cloud cleanup, make sure to end the status so that it gets properly printed back to the user.
Resolves #519
Signed-off-by: Mike Kolesnik<EMAIL_ADDRESS>

Backported as #534 and #535


Unwanted memory usage by QtInteractor.add_point_labels

Problem
I identified unwanted memory usage by QtInterator.add_point_labels, which is causing serious slowness in the interaction:

For reference, QtInterator.add_mesh produces:

Testing
I checked the memory use for the following cases using examples.load_uniform as grid:

plotting grid using add_mesh by Plotter
plotting grid using add_mesh by QtInteractor
plotting grid.cell_centers using add_point_labels by Plotter
plotting grid.cell_centers using add_point_labels by QtInteractor

Sources: sources.zip
Result of Case 1:

Result of Case 2:

Result of Case 3:

Result of Case 4:

Scooby Report
--------------------------------------------------------------------------------
  Date: Wed Feb 17 16:57:11 2021 Hora oficial do Brasil

                OS : Windows
            CPU(s) : 8
           Machine : AMD64
      Architecture : 64bit
               RAM : 15.9 GB
       Environment : Python

  Python 3.8.7 (tags/v3.8.7:6503f05, Dec 21 2020, 17:59:51) [MSC v.1928 64 bit
  (AMD64)]

           pyvista : 0.27.4
         pyvistaqt : 0.3.0
               vtk : 9.0.1
             numpy : 1.19.5
             scipy : 1.6.0
           IPython : 7.19.0
        matplotlib : 3.3.4
            scooby : 0.5.6
--------------------------------------------------------------------------------

Issue is due to the usage of vtkSelectVisibilePoints, which is a memory/cpu hog and is likely not very efficiently implemented (or is hard to implement).  Setting always_visible=True should help with the memory usage.

@akaszynski you're right! There is still memory usage. But now I can interact with the dataset. Thank you!

Hi @akaszynski!
Would you know why this problem occurs with QtInteractor but not with Plotter? What do you think about changing the default value of always_visible to True? Or at least add an allert in the documentation of always_visible about this issue? I don't think I would have solved this problem if you hadn't helped me.


MLB Probable Pitchers

Hello,
I tried my best to read all the documentation and search through the code but could not find a way to only include the probable starting pitcher in lineups. It looks like "Probable Pitcher" is available in the csv from Yahoo and FanDuel, but as hard as I tried, being self taught, I couldn't implement it in my fork. Could this be implemented for these two sites? Thank you!

Name a column Confirmed Starter and add true next to them under that column and use command Confirmed starters

Cheers thanks!

Did everything work out?


What is actual license for JSR 107 API?

Could you please clarify what is the current license for JSR 107 API?
From one side the published artifact and sources uses https://github.com/jsr107/jsr107spec/blob/master/LICENSE.txt, which is custom one.
From another side https://jcp.org/en/jsr/detail?id=107 page mentions CDDL 1.1 and GPLv2 with Classpath Exception.
Source files do not contain an explicit license header.

The spec license is actually wrong. It is appropriate for an early draft but not for final. We will:
a) get Oracle legal to give us the correct wording, similar to your example for a final spec
b) copy that into the LICENSE.txt in the jar
There is a second issue that the spec doc mentions CDDL and Apache. We need to work that into the spec as well.

the TCK also mentions Apache despite other license(s) seemingly apply there;-) See https://github.com/jsr107/jsr107tck/issues/80

I checked https://jcp.org/en/jsr/detail?id=107 page
For the spec it mentions the specification license which is correct. So no issue.
CDDL talk about the RI and TCK. So far we have only released those as Apache 2.

The artifact is called "spec" which is a bit misleading. Similar to JSR 363 it seems the actual Spec is in Google Docs. So https://github.com/jsr107/jsr107spec/blob/master/LICENSE.txt is in a repository it may not fully apply to. At least that's exactly what Eclipse (or OGC) were concerned about in the case of the JSR 363 API. Following another Oracle-lead JSR 375 (https://github.com/javaee-security-spec/spec-api) it mentions the RI/TCK licenses in the LICENSE.* file (whild the actual spec document contains the Spec License) Unless Co-Spec Lead Oracle had an issue, it might make life easier with most OSS communities. At least we now stick to the same policy as pretty much every Oracle lead JSR.

Still very confusing for an open source project trying to determine if the API can even be used...
Is cache-api-1.0.0.jar Apache 2 licensed?

You certainly scratch an itch with that question ;-)


hi jayson, i'm clone your project, but not load tailwind css in running

register img
i'm not found reason?

Please make sure you have npm installed. The project uses it to build the tailwind css files. If this doesn't work, please provide some details in a comment instead of a discord link. thanks!

@jayson-lennon i'm so sorry, i provider more detail about that at later. thanks reply me and i'm learn more rust knowledge from your project, you are so respected for me, thank you again!!!

@jayson-lennon not load tailwind css
discord question link

The link tag for tailwind.css should be <link rel="stylesheet" href="/tailwind.css" />. You also don't need any dependencies in package.json:
{
  "dependencies": {}
}

npm is only used to run the npx command to generate the tailwind.css file. npm is not used for any bundling or project management, so we don't need anything in the package.json.
You can contact me directly via Discord @jayson.lennon (my DMs are open), or paste your question from Discord into this issue thread. It helps to have all the information in one place instead of switching between platforms. (Note: I haven't read any Discord discussion from this issue)

@jayson-lennon ok, thank you, i connect you with discord @jayson.lennon and i'm try change code

i guess tailwind css not load because of dioxus wss failed

It works fine without the hot reload server. I specifically disabled it for this project because I was running into issues with it.


Manually swipe left right not working in ios

Which OS ? IOS
Version    0.55.4
Which versions are you using:

react-native-swiper v?  1.5.13"
react-native v0.?.?

Expected behaviour
swiping left & right should work
Actual behaviour
swiping is poosible only using buttons not by swapping left right
How to reproduce it>
To help us, please fork this component, modify one example in examples folder to reproduce your issue and include link here.
<View style = {{backgroundColor:'black',height:'100%',justifyContent:'center'}}>

<Swiper
removeClippedSubviews={false}
showsButtons={true}
showsPagination={false}
nextButton={<Text style={[Styles.buttonText1,{color:'white'}]}>›}
prevButton={<Text style={[Styles.buttonText1,{color:'white'}]}>‹}
buttonWrapperStyle={{backgroundColor: 'transparent',
flexDirection: 'row', position: 'absolute', top: 0, left: 0, flex: 1, paddingHorizontal: 10, paddingVertical: 0,
justifyContent: 'space-between', alignItems: 'center'}}
index={global.pos}
//loop
  >
     {

    sliderArr.map(item =>

      <View key={item.img} style={{justifyContent:'center',height: 200,backgroundColor:'black' }}>

<Image style={{height:200}}
//resizeMode={'stretch'}
source={item.img }>
<Text style={{color:'white',textAlign:'center',marginTop:20}}>{item.text}

    )
  }

### Steps to reproduce
1.
2.
3.

I have the same error

+1

1

I had the same problem here, changing 'style' to 'containerStyle' solved my problem ! TKS!

I still have the same error when i change the style prop to containerStyle.
I am using Expo. It works on the expo app but not on the standalone app.

Android works ok，but It's not working on ios

@irodeanu Thankyou

react-native-swiper working fine on android but not on ios. On ios previous button is not working and also index number is causing problems. I don't know what's the problem with this package because 1.5 version works fine on ios but not on android and now latest version works fine on android but not on ios.

i don't know how you guys managing this package. Without testing why you uploaded new versions. So many issues with this package. 1.5 works on ios not on android and now latest version works fine on android without any issues but not on ios. This package is not stable.

containerStyle ..its working for me


Add typing.com and update chess.com

Sorry, I made a mistake with git. I'll make a new pull request


QGB monitor confirms attestations

As per the discussion under https://github.com/celestiaorg/celestia-app/pull/720#issuecomment-1250899023, We will need to define an explicit way of monitoring the confirms submissions and have a way to judge validators activity.

Also, the validators are asking  for prometheus monitoring


Ctrl+y busted

Issue Type: Bug
I think autosave is busting my REDO. I often ctrl+z to get to a past state, copy, and ctrl+y to get back. Now it is locking state so I cant redo which is very annoying.
VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:40:02.816Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30384385
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vscop804:30404766
vs360:30404995
vsrem710:30416614
vsccppwtstudy:30421978

@TheREK3R What are the precise steps where Ctrl+Y no longer works?


Provide integrations with Spring Boot Actuator

We should provide integrations with Spring Boot Actuator metrics.
We should also ensure correct ordering of Actuator HttpTraceFilter gh-760
Related gh-673, gh-748

important note, current WebMvcMetricsFilter traces redirects without uri, which makes it hard to understand if there is error rate increasing on Authorize Endpoint (/oauth2/authorize) or Callback Login Endpoint (/login/oauth2/code/...).

Any updates on this topic?

No updates @algarves.
If there is something specific you are looking for it might be best to log the issue with Spring Boot.


Azure automount fstab

Hi there, I have a question that I couldn't find an answer. I actually mounted an azure blob storage account with this command:
goofys -o allow_other --file-mode=0777 --dir-mode=0777 wasb://account@address /azure/storage
What is the correct line that I need to add in the fstab to auto mount this?. I have configured the .azure/config file.
Thanks.

Hello! @kahing can you help me on this? Thanks.

similar fstab as s3 works fine:
<EMAIL_ADDRESS>     /tmp/mnt        fuse    _netdev,allow_other,--file-mode=0666,--dir-mode=0777    0       0


Add capabilities fields for semantic tokens

These fields were documented, but not included in this definition. This prevented them showing up in the code I'm generating from the spec.

Thanks. Forgot about them.


Spankbang - 403 errors -- new behavior, changed as of 20240207

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Canada
Provide a description that is worded well enough to be understood
Until today, videos from Spankbang were downloadable, although only using --legacy-server-connect.  I.e. until today a command like
yt-dlp --fragment-retries 99 --legacy-server-connect https://spankbang.com/2uocm/video/S
worked correctly.
However, as of this morning the behavior has changed, and downloads now generate errors as shown below.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
$ yt-dlp -vU --fragment-retries 99 --legacy-server-connect https://spankbang.com/2uocm/video/S
[debug] Command-line config: ['-vU', '--fragment-retries', '99', '--legacy-server-connect', 'https://spankbang.com/2uocm/video/S']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [f10589e34] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 2022-12-04-git-6c814093d8-essentials_build-www.gyan.dev (setts), ffprobe 2022-12-04-git-6c814093d8-essentials_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.19.1, brotli-1.1.0, certifi-2023.11.17, mutagen-1.47.0, requests-2.31.0, sqlite3-3.35.5, urllib3-2.1.0, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1798 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[SpankBang] Extracting URL: https://spankbang.com/2uocm/video/S
[SpankBang] 2uocm: Downloading webpage
ERROR: [SpankBang] 2uocm: Unable to download webpage: HTTP Error 403: Forbidden (caused by <HTTPError 403: Forbidden>); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "yt_dlp\extractor\common.py", line 718, in extract
  File "yt_dlp\extractor\spankbang.py", line 74, in _real_extract
  File "yt_dlp\extractor\common.py", line 1121, in _download_webpage
  File "yt_dlp\extractor\common.py", line 1072, in download_content
  File "yt_dlp\extractor\common.py", line 906, in _download_webpage_handle
  File "yt_dlp\extractor\common.py", line 863, in _request_webpage

  File "yt_dlp\YoutubeDL.py", line 4082, in urlopen
  File "yt_dlp\networking\common.py", line 114, in send
  File "yt_dlp\networking\_helper.py", line 204, in wrapper
  File "yt_dlp\networking\common.py", line 325, in send
  File "yt_dlp\networking\_requests.py", line 343, in _send
yt_dlp.networking.exceptions.HTTPError: HTTP Error 403: Forbidden

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "yt_dlp\extractor\common.py", line 850, in _request_webpage
  File "yt_dlp\YoutubeDL.py", line 4114, in urlopen
yt_dlp.networking.exceptions._CompatHTTPError: HTTP Error 403: Forbidden

Duplicate of #6545


Bot: Hangman

Probably wouldn't bother with drawing it of course, but a nice string/list manipulation problem.
Medium?

https://github.com/charleso/haskell-in-haste/pull/42


feat: login and logout commands

Hi, this is the new implementation of the login/logout commands for the renovated version of the CLI. A lot of stuff is included in this PR, so bear with me I'm going to try to make the testing as easy as possible since there are different mechanisms to authenticated involved.
How to test this PR

Clone the repo and pull the branch
pnpm install
pnpm run build:stub <-- Important you test it with stub for now

Once build without issues

Use pnpm run dev <command> that you want to test, ex pnpm run dev login --region us

Unit test
There are 9 test files with 43 tests in total including mocks for filesystem, and with a coverage of around > 80% (There are some modules like the session module that I need to increase the percentage)
You can run the tests:
pnpm run test

And coverage
pnpm run coverage

Testing checklist
I'm including the same manual testing checklist I used during TDD
Login
storyblok-cli login

[ ]  login default login (interactive mode)

[ ]  should prompt the user with a option select for the desired login strategy:

[ ]  With email

[ ]  should request user email
[ ]  should request password (should be obscured)
[ ]  should prompt user with available regions to select
[ ]  should prompt the user with an input to paste the otp code if required sent via email / phone

If correct

[ ]  should create a .netrc file on ~/.netrc with the following properties:

[ ]  machineName:

[ ]  api.storyblok.com if region is eu
[ ]  api-us.storyblok.com if region is us
[ ]  [app.storyblokchina.cn](http://app.storyblokchina.cn/) if region is cn
[ ]  [api-ca.storyblok.com](http://api-ca.storyblok.com/) if region is ca
[ ]  [api-ap.storyblok.com](http://api-ap.storyblok.com/) if region is ap

[ ]  login: email  provides by previous step
[ ]  password: token returned by the otp call
[ ]  region: region provided by previous step

[ ]  should prompt a success message Successfully logged in with email + email

[ ]  With Token (SSO)

[ ]  should prompt the user to introduce an obscured token

If correct:

[ ]  should create a .netrc file on ~/.netrc with the following properties:

[ ]  machineName:

[ ]  api.storyblok.com if region is eu
[ ]  api-us.storyblok.com if region is us
[ ]  app.storyblokchina.cn if region is cn
[ ]  api-ca.storyblok.com if region is ca
[ ]  api-ap.storyblok.com if region is ap

[ ]  login: email connected to token
[ ]  password: token
[ ]  region: by default eu unless --region is used

[ ]  It should return a success message Successfully logged in with token

If error

[ ]  Should prompt the user with an error if 401 unauthorized
The token provided YFFZ**************************************************************************************************** is invalid: 401 Unauthorized

[ ]  login with token login --token
If correct:

[ ]  should create a .netrc file on ~/.netrc with the following properties:

[ ]  machineName:

[ ]  api.storyblok.com if region is eu
- [ ]  api-us.storyblok.com if region is us
- [ ]  app.storyblokchina.cn if region is cn
- [ ]  api-ca.storyblok.com if region is ca
- [ ]  api-ap.storyblok.com if region is ap

[ ]  login: email connected to token
[ ]  password: token
[ ]  region: by default eu unless --region is used

[ ]  It should return a success message Successfully logged in with token

If error

[ ]  Should prompt the user with an error if 401 unauthorized

The token provided ${chalk.bold(maskToken(token))} is invalid: ${chalk.bold(`401 ${(error as FetchError).data.error}`)}

	  Please make sure you are using the correct token and try again

[ ]  Should prompt error No response from server, please check if you are correctly connected to internet if connection fails
[ ]  Should prompt the user with a generic Error logging with token if else.

[ ]  login with region login --region

[ ]  Should thrown an error if the region introduced is not in the list

[ ]  should prompt a message if user is already logged in

[ ]  should get credentials without login if (Prompt user is already logged in)

[ ]  Env variables STORYBLOK_LOGIN, STORYBLOK_TOKEN, STORYBLOK_REGION are present
[ ]  Env variables TRAVIS_TORYBLOK_LOGIN, TRAVIS_STORYBLOK_TOKEN, TRAVIS_STORYBLOK_REGION are present

Logout
storyblok-cli logout

[ ]  It should delete entries of .netrc file
[ ]  should prompt the user if is already logout You are already logged out. If you want to login, please use the login command.
[ ]  it should throw an error if case something goes south

Installation process
I have had issues trying to install the project with npm (exited with ERR). I guess this is intended, as the package manager of choice is set as pnpm, but do we really want to make it non installable via npm?
The same goes for pnpm version < 9.9: I couldn't install the project with the pnpm version that I had on my machine previously (v8.x, which was still released in 2024). Is this intended?

@Edo-San  Let's jump into a call to see what's going on, we are going to use pnpm across all the ecosystem for several reasons (I have the complete justification in a session I did recently at Storyblok), but mostly because of pnpm-workspaces and how it ease development of libraries. Just to clarify, users will be able to install the CLI with any: npm, yarn, pnpm, bun, this is only for mantainers and contributors.
Happy to discuss this on the call. Part of the migration to pnpm is that all of you can use it with ease.

Config quirks
As you may have seen from the comments, there are some issues with TS includes and test files. I noticed that we have a tsconfig.node.json file that seems dedicated to tests. Do we need/want to have a different TSconfig for tests only?

This part can be improved big time. Regarding Typescript test files, I would actually remove any ts linting there, since vitest mocks are tricky to get correctly with TS

My VSCode instance is also picking up the .vscode settings, but there is no prettier config set up. I suggest to take care of this by either removing prettier or adding a config for that.
Also, I don't get why I got those TS errors on tests and you did not 🤔 Could it be that the @storyblok/eslint-config package is missing TSLint rules?

Mmmm that .vscode setting shouldn't be there, I removed the prettier in favor of eslint v9 flat config and autofix with @tresjs/eslint-config, I'm gonna remove the .vscode/settings.json

Error handling
I personally found it quite hard to follow the error chain through all the nested tries...catch bloks and all the various calls, but this is just a personal opinion.

An example could be the loginWithToken function. It has its own try/catch and we are throwing errors in the catch so that they can be catched in another try/catch block when that function is called. The same goes for the persistCredentials > addNetrcEntry chain. The latter has its own try/catch block, while the former has not, but when the former is called, it is called inside a try/catch block.

I love you bringed up this, because it's one of the topics I want to discuss. The biggest pain point of the previous CLI is that the error handling was generic for several operations. An example:
The sync command would

Pull the components and stories from one space
Request tag relationships
Solve relations
Push components and stories

If any of these steps failed, the error was the same which was really confusing, because all of them used the same try catch without propagating up the errors.
The approach here is every operation that can fail should propagate up it's own error message which is handled on the top try catch with the handleError (it's purpose is just prompt the error with the correct formatting). So nested try-catch will catch both programming issues as operation errors.
@Edo-San what would be your approach for error handling?  How would it look like?


Build failure smap/win and azure/arm

Hello,
I encountered some issues when trying to build packer-azure go get github.com/Azure/packer-azure/packer/plugin/... today.
github.com/Azure/packer-azure/packer/builder/azure/smapi/win fails withr:
`*azureVmCustomScriptExtension.comm does not implement packer.Communicator (missing DownloadDir method)
github.com/Azure/packer-azure/packer/builder/azure/arm fails with:
	*"github.com/mitchellh/packer/common".StepProvision does not implement "github.com/mitchellh/multistep".Step (wrong type for Cleanup method) 		have Cleanup("github.com/mitchellh/packer/vendor/github.com/mitchellh/multistep".StateBag) 		want Cleanup("github.com/mitchellh/multistep".StateBag)
Build output messages:
root@vagrant-ubuntu-trusty-64:~# go get github.com/Azure/packer-azure/packer/plugin/...
# github.com/Azure/packer-azure/packer/builder/azure/smapi/win
work/src/github.com/Azure/packer-azure/packer/builder/azure/smapi/win/step_set_provision_infrastructure.go:91: cannot convert comm (type *azureVmCustomScriptExtension.comm) to type packer.Communicator:
	*azureVmCustomScriptExtension.comm does not implement packer.Communicator (missing DownloadDir method)
go build github.com/mitchellh/packer/vendor/github.com/ugorji/go/codec: /usr/local/go/pkg/tool/linux_amd64/compile: signal: killed
# github.com/Azure/packer-azure/packer/builder/azure/arm
work/src/github.com/Azure/packer-azure/packer/builder/azure/arm/builder.go:73: cannot use lin.SSHHost (type func("github.com/mitchellh/multistep".StateBag) (string, error)) as type func("github.com/mitchellh/packer/vendor/github.com/mitchellh/multistep".StateBag) (string, error) in field value
work/src/github.com/Azure/packer-azure/packer/builder/azure/arm/builder.go:74: cannot use lin.SSHConfig(b.config.UserName) (type func("github.com/mitchellh/multistep".StateBag) (*"golang.org/x/crypto/ssh".ClientConfig, error)) as type func("github.com/mitchellh/packer/vendor/github.com/mitchellh/multistep".StateBag) (*"github.com/mitchellh/packer/vendor/golang.org/x/crypto/ssh".ClientConfig, error) in field value
work/src/github.com/Azure/packer-azure/packer/builder/azure/arm/builder.go:76: cannot use "github.com/mitchellh/packer/common".StepProvision literal (type *"github.com/mitchellh/packer/common".StepProvision) as type "github.com/mitchellh/multistep".Step in array or slice literal:
	*"github.com/mitchellh/packer/common".StepProvision does not implement "github.com/mitchellh/multistep".Step (wrong type for Cleanup method)
		have Cleanup("github.com/mitchellh/packer/vendor/github.com/mitchellh/multistep".StateBag)
		want Cleanup("github.com/mitchellh/multistep".StateBag)
work/src/github.com/Azure/packer-azure/packer/builder/azure/arm/builder.go:123: cannot use "github.com/mitchellh/packer/common".MultistepDebugFn(ui) (type "github.com/mitchellh/packer/vendor/github.com/mitchellh/multistep".DebugPauseFn) as type "github.com/mitchellh/multistep".DebugPauseFn in field value

System:
go version go1.6 linux/amd64
ubuntu 14.04
If I can provide any more information to help track down this issue, please let me know.
Thanks,
Aaron

Thanks for opening an issue!
Packer recently started vendoring their dependencies, which broke my local build too.  I opened a PR against the packer repo to "fix" it, but my "fix" was wrong.  Chris (@cbednarski) provided the real fix, which is to use godep.  Please see that PR for details.
We are working on merging the two repos, so this will problem will no longer exist.  We'll be ready to merge once the pending ARM issues are addressed.
HTH,
Christopher

I found the same issue... our 'custom script' communicator doesn't yet have the new DownloadDir method that was added in https://github.com/mitchellh/packer/commit/feee19e4ed51e9045e4de6639b4b954f5ac37e58

Thanks Paul, I clearly missed the obvious.

Thanks for the quick response @boumenot @paulmey. I was able to build locally following the linked PR.


Assert triggered in focus traversal: RenderBox was not laid out

Hi,
the following snippet causes an assert during focus traversal that a RenderBox has not been laid out (it doesn't have a size).
Repro steps are: click on "Click me", then press tab.
import 'package:flutter/material.dart';

main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Column(
        children: [
          _EditField(),
          _Panel(),
        ],
      ),
    );
  }
}

class _EditField extends StatefulWidget {
  @override
  State<_EditField> createState() => _EditFieldState();
}

class _EditFieldState extends State<_EditField> {
  final _focusNode = FocusNode(debugLabel: '_EditField');

  @override
  Widget build(BuildContext context) {
    return TextField(
      focusNode: _focusNode,
      decoration: const InputDecoration(
        contentPadding: EdgeInsets.fromLTRB(12, 18, 12, 18),
        filled: true,
        hintText: 'Click me',
      ),
    );
  }
}

class _Panel extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return SizedBox(
      width: 300.0,
      height: 100.0,
      child: Navigator(
        requestFocus: false,
        pages: <MaterialPage<Object>>[
          MaterialPage<Object>(name: 'root', child: Container()),
          const MaterialPage<Object>(name: 'panel', child: Text('Then press tab')),
        ],
        onPopPage: (_, __) => false,
      ),
    );
  }
}

Here is the output from the chrome console:
══╡ EXCEPTION CAUGHT BY SERVICES LIBRARY ╞══════════════════════════════════════════════════════════
js_primitives.dart:30 The following assertion was thrown while processing the key message handler:
js_primitives.dart:30 Assertion failed: google3:///third_party/dart/flutter/lib/src/rendering/box.dart:2009:12
js_primitives.dart:30 hasSize
js_primitives.dart:30 "RenderBox was not laid out: RenderSemanticsAnnotations#6193f NEEDS-LAYOUT NEEDS-PAINT"
js_primitives.dart:30
js_primitives.dart:30 When the exception was thrown, this was the stack:
js_primitives.dart:30 dart:sdk_internal 5653:11                                   throw_
js_primitives.dart:30 dart:sdk_internal 5568:15                                   assertFailed
js_primitives.dart:30 package:flutter/src/rendering/box.dart 2009:12              get size
js_primitives.dart:30 package:flutter/src/rendering/box.dart 2147:44              get semanticBounds
js_primitives.dart:30 package:flutter/src/widgets/focus_manager.dart 796:90       get rect
js_primitives.dart:30 package:flutter/src/widgets/focus_traversal.dart 872:20     new
js_primitives.dart:30 package:flutter/src/widgets/focus_traversal.dart 1115:49    <fn>
js_primitives.dart:30 package:flutter/src/widgets/focus_traversal.dart 1115:75    sortDescendants
js_primitives.dart:30 package:flutter/src/widgets/focus_traversal.dart 333:55     [_sortAllDescendants]
js_primitives.dart:30 package:flutter/src/widgets/focus_traversal.dart 406:41     [_moveFocus]
js_primitives.dart:30 package:flutter/src/widgets/focus_traversal.dart 238:39     next
js_primitives.dart:30 package:flutter/src/widgets/focus_manager.dart 1136:46      nextFocus
js_primitives.dart:30 package:flutter/src/widgets/focus_traversal.dart 1687:5     invoke
js_primitives.dart:30 package:flutter/src/widgets/actions.dart 580:20             invokeAction
js_primitives.dart:30 package:flutter/src/widgets/shortcuts.dart 815:36           handleKeypress
js_primitives.dart:30 package:flutter/src/widgets/shortcuts.dart 999:20           [_handleOnKey]
js_primitives.dart:30 package:flutter/src/widgets/focus_manager.dart 1682:25      [_handleKeyMessage]
js_primitives.dart:30 package:flutter/src/services/hardware_keyboard.dart 897:16  [_dispatchKeyMessage]
js_primitives.dart:30 package:flutter/src/services/hardware_keyboard.dart 962:17  handleRawKeyMessage
js_primitives.dart:30 dart:sdk_internal 42528:34                                  runBody
js_primitives.dart:30 dart:sdk_internal 42560:7                                   _async
js_primitives.dart:30 package:flutter/src/services/hardware_keyboard.dart 923:51  handleRawKeyMessage
js_primitives.dart:30 package:flutter/src/services/platform_channel.dart 214:49   <fn>
js_primitives.dart:30 dart:sdk_internal 42528:34                                  runBody
js_primitives.dart:30 dart:sdk_internal 42560:7                                   _async
js_primitives.dart:30 package:flutter/src/services/platform_channel.dart 213:58   <fn>
js_primitives.dart:30 package:flutter/src/services/binding.dart 393:35            <fn>
js_primitives.dart:30 dart:sdk_internal 42528:34                                  runBody
js_primitives.dart:30 dart:sdk_internal 42560:7                                   _async
js_primitives.dart:30 package:flutter/src/services/binding.dart 390:46            <fn>
js_primitives.dart:30 dart:sdk_internal 228129:7                                  invoke2
js_primitives.dart:30 dart:sdk_internal 141412:15                                 invoke
js_primitives.dart:30 dart:sdk_internal 141489:54                                 push
js_primitives.dart:30 dart:sdk_internal 141587:29                                 push
js_primitives.dart:30 dart:sdk_internal 198205:27                                 invokeOnPlatformMessage
js_primitives.dart:30 dart:sdk_internal 200752:49                                 [_handleHtmlEvent]
js_primitives.dart:30 dart:sdk_internal 200777:29                                 <fn>
js_primitives.dart:30 dart:sdk_internal 5857:16                                   _checkAndCall
js_primitives.dart:30 dart:sdk_internal 5862:17                                   dcall
js_primitives.dart:30 dart:sdk_internal 66501:21                                  ret
js_primitives.dart:30
js_primitives.dart:30 KeyMessage: KeyMessage([KeyDownEvent#a2d91(physicalKey: PhysicalKeyboardKey#7002b(usbHidUsage:
js_primitives.dart:30   "0x0007002b", debugName: "Tab"), logicalKey: LogicalKeyboardKey#b151c(keyId: "0x100000009",
js_primitives.dart:30   keyLabel: "Tab", debugName: "Tab"), character: null, timeStamp: 0:00:04.291300)])
js_primitives.dart:30 ════════════════════════════════════════════════════════════════════════════════════════════════════

Issue is reproducible using the code sample provided above.
Labeling for further investigation from the team.

logs
Launching lib/main.dart on macOS in debug mode...
Updating minimum macOS deployment target to 10.13.
Upgrading project.pbxproj
Upgrading Podfile
Updating project for Xcode compatibility.
Upgrading project.pbxproj
Upgrading Runner.xcscheme
Removing script build phase dependency analysis.
--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:macOS, arch:arm64, id:00008103-000329201AD1001E }
{ platform:macOS, arch:x86_64, id:00008103-000329201AD1001E }

flutter: ══╡ EXCEPTION CAUGHT BY SERVICES LIBRARY ╞══════════════════════════════════════════════════════════
flutter: The following assertion was thrown during method call TextInputClient.performSelectors:
flutter: RenderBox was not laid out: RenderSemanticsAnnotations#7bfdf NEEDS-LAYOUT NEEDS-PAINT
flutter: 'package:flutter/src/rendering/box.dart':
flutter: Failed assertion: line 2009 pos 12: 'hasSize'
flutter:
flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially
flutter: more information in this error message to help you determine and fix the underlying cause.
flutter: In either case, please report this assertion by filing a bug on GitHub:
flutter:   https://github.com/flutter/flutter/issues/new?template=2_bug.md
flutter:
flutter: When the exception was thrown, this was the stack:
flutter: #2      RenderBox.size (package:flutter/src/rendering/box.dart:2009:12)
flutter: #3      RenderBox.semanticBounds (package:flutter/src/rendering/box.dart:2147:44)
flutter: #4      FocusNode.rect (package:flutter/src/widgets/focus_manager.dart:796:91)
flutter: #5      new _ReadingOrderSortData (package:flutter/src/widgets/focus_traversal.dart:872:21)
flutter: #6      ReadingOrderTraversalPolicy.sortDescendants (package:flutter/src/widgets/focus_traversal.dart:1115:49)
flutter: #7      FocusTraversalPolicy._sortAllDescendants (package:flutter/src/widgets/focus_traversal.dart:333:65)
flutter: #8      FocusTraversalPolicy._moveFocus (package:flutter/src/widgets/focus_traversal.dart:406:41)
flutter: #9      FocusTraversalPolicy.next (package:flutter/src/widgets/focus_traversal.dart:238:39)
flutter: #10     FocusNode.nextFocus (package:flutter/src/widgets/focus_manager.dart:1136:56)
flutter: #11     NextFocusAction.invoke (package:flutter/src/widgets/focus_traversal.dart:1687:19)
flutter: #12     ActionDispatcher.invokeAction (package:flutter/src/widgets/actions.dart:580:21)
flutter: #13     Actions.invoke.<anonymous closure> (package:flutter/src/widgets/actions.dart:878:48)
flutter: #14     Actions._visitActionsAncestors (package:flutter/src/widgets/actions.dart:659:18)
flutter: #15     Actions.invoke (package:flutter/src/widgets/actions.dart:872:30)
flutter: #16     EditableTextState.performSelector (package:flutter/src/widgets/editable_text.dart:3706:17)
flutter: #17     ListMixin.forEach (dart:collection/list.dart:86:13)
flutter: #18     TextInput._handleTextInputInvocation (package:flutter/src/services/text_input.dart:1753:19)
flutter: #19     TextInput._loudlyHandleTextInputInvocation (package:flutter/src/services/text_input.dart:1657:20)
flutter: #20     MethodChannel._handleAsMethodCall (package:flutter/src/services/platform_channel.dart:555:55)
flutter: #21     MethodChannel.setMethodCallHandler.<anonymous closure> (package:flutter/src/services/platform_channel.dart:548:34)
flutter: #22     _DefaultBinaryMessenger.setMessageHandler.<anonymous closure> (package:flutter/src/services/binding.dart:392:35)
flutter: #23     _invoke2 (dart:ui/hooks.dart:183:13)
flutter: #24     _ChannelCallbackRecord.invoke (dart:ui/channel_buffers.dart:40:5)
flutter: #25     _Channel.push (dart:ui/channel_buffers.dart:130:31)
flutter: #26     ChannelBuffers.push (dart:ui/channel_buffers.dart:326:17)
flutter: #27     PlatformDispatcher._dispatchPlatformMessage (dart:ui/platform_dispatcher.dart:664:22)
flutter: #28     _dispatchPlatformMessage (dart:ui/hooks.dart:86:31)
flutter: (elided 2 frames from class _AssertionError)
flutter:
flutter: call:
flutter:   MethodCall(TextInputClient.performSelectors, [1, [insertTab:]])
flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════
Application finished.

Exited.

flutter doctor -v
[✓] Flutter (Channel stable, 3.3.6, on macOS 13.0 22A380 darwin-arm, locale en-GB)
    • Flutter version 3.3.6 on channel stable at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6928314d50 (6 days ago), 2022-10-25 16:34:41 -0400
    • Engine revision 3ad69d7be3
    • Dart version 2.18.2
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A309
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9014738/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.72.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.0 22A380 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 107.0.5304.87

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 2 categories.

[!] Flutter (Channel master, 3.5.0-10.0.pre.167, on macOS 13.0 22A380 darwin-arm64, locale en-GB)
    • Flutter version 3.5.0-10.0.pre.167 on channel master at /Users/nexus/dev/sdks/flutters
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 533b3a1e49 (2 hours ago), 2022-10-31 02:18:06 -0400
    • Engine revision 32d2d937ba
    • Dart version 2.19.0 (build 2.19.0-353.0.dev)
    • DevTools version 2.18.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A309
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9014738/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.72.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.0 22A380 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 107.0.5304.87

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 3 categories.

@chunhtai Is this a valid use of Navigator?  Your name came into my head because of go_router, but let me know if you're not the right person for that question.

I see no problem using navigator this way. I can't tell why it crash but we should fix it

Thanks, that's what I needed to know.  I'll take a closer look at this.

@gspencergoog It looks like the cause of this assertion is that inactive Navigator pages are a part of the focus traversal.  So in the repro code (pasted below), the "root" page is not shown, but pressing tab traverses to it.  Since it's not laid out, it triggers the assertion.
Navigator(
  pages: <MaterialPage<Object>>[
    MaterialPage<Object>(name: 'root', child: Container()),
    const MaterialPage<Object>(name: 'panel', child: Text('Then press tab')),
  ],
  ...
),

Does that sound like an accurate assessment to you?  I assume the solution would be to exclude inactive pages somewhere?

@saintmac-google Hi. Did you solve you problem?

oh that's old.
either that has been solved a while ago or I ended up doing it differently


Bot returns [Object object] in response to stats occasionally

Looks as though this block in stats.js is responsible
res.on('data', function (chunk) {
                    request.sendChat(chunk);
                });

@pironic

I recall reporting this to @pironic directly the other day, I think he's working on it.

There is an associated commit which i'm just finalizing in the GSBOT-php-lib repository. I was throwing header error codes incorrectly, but that has been resolved.


Fixing un-used imports sonar violation.

Fixes # .
Did you remember to?

[ ] Add test case(s)
[ ] Update CHANGES.txt

ping @cbeust / @juherr - Can you please help get this merged ?

@krmahadevan could you check the changes with SonarLint (configured with the sonarqube.com instance)?
I think sonar will still complain against some changes ;)

@juherr can you please help guide me how do I that ? ( Pls bear with me if that sounds silly )

@krmahadevan No prob!

Install SonarLint: http://www.sonarlint.org/ (it will highlight some issues)
Attach it to the external configuration (Connected Mode with http://sonarqube.com as  server)

Step 2 may fail if you have not an account, try to create one in that case.

@krmahadevan I've just provided you some rights (administer issues) on testng project on sq.com

@krmahadevan Let me know when you think this is ready to be merged.

@cbeust - I think this is ready for review and merge.
@juherr - Thanks for sharing that information on the sonarlint. I have tried to fix some of the recommendations. I guess this will require multiple iterations so that its easy to focus on the changeset for me and then fix anything if the tests break. So I haven't run through all of the recommendations.

@krmahadevan Can you please address @juherr's two comments? I'll merge after that.
Thanks!

@krmahadevan It looks the build on openjdk7 is always failing with this pull request. I think it is a side effect but could you try to have a look?

@krmahadevan Forget it, it passed this time!

@cbeust the 2 potential issues were not yet fixed ;)

Oops sorry I misread. I'll let @krmahadevan fix them in a separate PR.

@juherr and @cbeust - I will raise a new PR for the potential issues fixes that were called out here.

@cbeust and @juherr - lets say, I spent some time in renaming all variables that start with m_ and removing the prefix. Do you think it can get merged ? I wanted to confirm with you folks before I do that, because it will be a bit of an effort :)


Add option to serialize model using aliases

Is this for a different use case than camelCase conversion? If so what is the use case?

It is similar to camelCase, but for when you don't actually want camelCase conversion, but something else. For example, when you need your field to be named like a reserved keyword (or with a special character). Or you might just want to use a different name for the field in your code than in your api (maybe because your are forced to expose a specific api for legacy reasons, but want to use a better naming in your code).
class MyResponse(BaseModel):
    schema: str = Field(alias="$schema")
    from_: str = Field(alias="from")
    to: str
    better_name: str = Field(alias="badNameThatIHaveToUseForLegacyReasons")

Thanks, I've gone for a config variable approach in a8f71f87842a7116cc58688b92d03060af16cf3d (so as to cover the non-validated response case).


When returning from Stripe while signing up for a new account, the login page is on http and doesn't work

I just created a new NewsBlur account, and bought a subscription with Stripe. When returning back, I got redirected to an http login page which didn't work. I was able to switch it to https and log in, but then it had lost the http://www.newsblur.com/stripe/return redirect, so it didn't associate my stripe transaction with my new account. I finally fixed it by clicking "Upgrade" again, and it immediately linked and enabled premium.
I think there is a redirect to http hidden somewhere. I hope this isn't specific to my machine.
Thanks!

Thanks, this is now fixed!


x/build/cmd/release: collect open source NOTICES into top-level NOTICES file?

We should probably make x/build/cmd/release collecting all the misc LICENSE/NOTICE files from the packages we depend on and concatenate them all together into one top-level NOTICES file next to our LICENSE file in Go's release.
We'd also need to make such NOTICE files for each directory where the notice is currently in the source code at the top.
Look at Debian's packaging of Go to find the list.
/cc @rsc @FiloSottile @ianlancetaylor @andybons @bcmills

Is there a lawyer that approves the Go releases? I think their input would be best for this.

@pciet, yes, we have a lawyer and have talked to them.

@bradfitz Can I work on this issue.
What I understood from above description is, we have to traverse each package/folder from go repository and collect all the LICENSE/NOTICE files and append it into a top level LICENSE/NOTICE file.

I've done some work on this since GopherCon, and I'm probably at least 90% of the way done, but I need some clarification. @bradfitz, just a couple questions:

This issue is on the golang repo, but it sounds like it should actually be against https://github.com/golang/build? Just making sure.

When you say:

We'd also need to make such NOTICE files for each directory where the notice is currently in the source code at the top.

Do you mean that all directories in src need to be recursively walked for source files that match (?i)^\s*copyright, and then this should be extracted?

There are no "NOTICE" files in the golang source tree. LICENSE files only. Just want to make sure I'm not missing anything.

I've currently written it to compact multiple, identical notices using hash.  (i.e., multiple files with the same contents will only be printed once, only they'll have multiple filenames before them.  Is this what you were looking for?


Add authentication to REST API, phase 1

Add BASIC and session authentication to REST API.

Completed.  Closing.


tilde expansion fails on macosx

Quality of life improvement request :)
it would be nice to be able to run...
→ leftovers --filter aleppo-staging -i gcp --dry-run --gcp-service-account-key=~/Downloads/PCF-Toolsmiths-Dev-1-438abb4f0a12.json

Unmarshalling account key for project id: invalid character '~' looking for beginning of value

instead of the fully qualified path...
→ leftovers --filter aleppo-staging -i gcp --dry-run --gcp-service-account-key=/Users/pivotal/Downloads/PCF-Toolsmiths-Dev-1-438abb4f0a12.json

Hey Mark!
Could you try with --gcp-service-account-key ~/Downloads/PCF-Toolsmiths-Dev-1-438abb4f0a12.json without the =?
For some reason, leftovers does expand using filepath.Abs(key) but when the argument is passed in with =, it can't get the correct path.
Not sure if this has somethibg to do with it: https://github.com/golang/go/issues/4140

Actually, going to try this https://github.com/mitchellh/go-homedir


[Extension] Make options page responsive

The current implementation of the options page doesn't work on small screens.

:tada: This issue has been resolved in version 3.29.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


trees_lod2.sps doesn't import/export properly

Blender 4.0.2/Sollumz 2.3.1
In this example I tried to import cs2_lod_02_slod3_children.ydd and models(or sprites) with trees_lod2 shader are just dots in Blender. With no modification on file, they're not visible when export from Blender.

IDK how CW/Game Shaders are handeling it but sollumz imports it correctly. This is the view of ydd in OpenIV just to make sure its not CW fault

It is imported. trees_lod2 mesh is just vertices, so if you go into edit mode you'll see floating vertices


how can i use the se_layer in mmdet/models/utils/se_layer after the backbond like resnet

se_layer is not supported. You should be able to directly use the seresnet in mmcls.


Add aarch64 support

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

license_file entry is missing, but is required.

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin, please re-render

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin, please re-render

I haven't dealt with aarch64 before, so I find it hard to judge whether this is correct. Are you confident enough to say it works? I don't see a CI check for aarch64, for instance, shouldn't that be there?
Perhaps it would be helpful if you could join the maintenance crew for this feedstock. If you feel like this, please add your name to the list in recipe/meta.yaml (preferably in this PR) and I'll merge this. Then later, if something breaks, you can easily fix it yourself.

Hi @egpbos, thanks for the reply, I reproduced the build on my local aarch64 machine and it works effectively,


Issue with logs in completed workflows

I have been noticing an issue with completed workflows. When you click on Logs in completed workflows, it says No logs generated. But I can download and see logs from Artifacts.
For reference: https://app.cnas-re-uog.onepanel.io/crb/workflows/process-inference-hw4hg

onepanelio/core#489 duplicates this.


Ack() should return more informative error messages

I made a mistake in testing pubsub.Ack() and gave it a slice with a bunch of empty strings.
The error message returned for such mistakes is not informative; I didn't realize the mistake until I showed a Google engineer my code sample.
log.Fatal(err) gave me this:
transport.go:90: googleapi: Error 500: Backend Error, backendError
I would expect an error message telling me the input is invalid, and the reason why. Stuff like http status codes should probably not be included in error messages.

How about to check if there are any empty strings before issuing the API call and returns an error?

Just in case, I'm talking about adding that check within pubsub.Ack. If it sounds good, I'll create a CL.

Sure, checking for empty strings in the library is sensible.

On the second thought, I think this should be fixed on the server side. The server should return 400 status code ideally with a helpful error message.
WDYT?

In my mind, both would be ideal.
You'd want the server to give you a sensible error for obvious errors like empty strings... but basic validation still seems sensible on the client as well, to avoid a round-trip to the server for obvious cases.

Thanks, the CL sent:
https://code-review.googlesource.com/#/c/2290/1


#16 [2pt] Details Show Page

When the user clicks an item:

details page with its full description (skip the "Rotate image" button).
In the details page, the user can click the "Reserve" button (in the design you can see the "Configure" button - please replace it with the "Reserve" button).

This issue has been handled in this PR


ImportError of 'crocoddyl_ros' in python program due to incomplete library linking with boost.

After building the ros package and sourcing the setup.bash, I tried to import the 'crocoddyl_ros' package into my python program (e.g. python -c "import crocoddyl; import crocoddyl_ros") . It failed with the error:
ImportError: xxx/catkin_ws/devel/lib/python3/dist-packages/crocoddyl_ros.cpython-38-x86_64-linux-gnu.so: undefined symbol: _ZN5boost6python9converter25rvalue_from_python_stage2EP7_objectRNS1_30rvalue_from_python_stage1_dataERKNS1_12registrationE
I figured it is a linking problem with cmake and spottet that in the 'CMakeLists.txt' the variables 'Boost_INCLUDE_DIRS', 'Boost_LIBRARIES' do not get initialized.
Adding
'find_package(Boost REQUIRED COMPONENTS python38)'
at the top of 'CMakeLists.txt' and rebuilding fixed it for me.

This is weird as we've jobs for ROS1 and ROS2 where we test this. @Sergim96 -- can you check this?

Hi @tkpf I tested this on an Ubuntu 20.04 with ROS Noetic, and I'm not able to replicate this error.
Could you give us more details of your system or provide a Dockerfile with the error so we can inspect it?

Hi together,
Thanks for the fast response.
First of all some information on my system setup: I am on a Ubuntu 22.04 as a VM using Oracle VirtualBox. My host system is a Windows 11 os, which should not make any difference though.
As my preceeding system setup was very dirty, I decided to setup a clean Ubuntu 20.04 VM to try to reproduce the error. I attached the bash history dump to this message (one shortened, the other one of original length also containing duplicated commands or failing commands e.g. due to spelling mistakes). As you can see, from a clean VM Ubuntu 20.04 system, I only installed all the dependencies and then tried to build the crocoddyl_msgs package- nothing more. Unfortunately, still failing.
The error still stayed and was solved through the provided hack above. So also on a clean (VM) system I could replicate the error.
I want to highlight again, that building succeeds but it seems to be a linkage issue when importing into python. Also in the given CMakeLists.txt file line 68/69 we try to link to the boost library, but never try to locate the boost package via 'find_package' before as we are doing with eigen3 and pinocchio. So for me the error seems reasonable. Please correct me if I am wrong and setting variables ${Boost_LIBRARIES} ${Boost_Python_LIBRARY} should normally be done implicitly.
Thanks for your help in advance!
If you need more specific files please reach out again.
[issue_boost_linkage_crocoddyl_msgs.txt](https://github.com/us
full_length.txt
er-attachments/files/17910221/issue_boost_linkage_crocoddyl_msgs.txt)

Hi @tkpf I'm closing this issue as I can't replicate it


ds8k_test_is_active

CSI-1551

CSI-1551

@igorgonibm could you add it to the PR name as well?

c open issues: CSI-1554


V4.0.0 Player defined methods

use
#def set, number
	{result=number}
;set, 1;
{result}```

I need Unit Testing... Imma start working on those to prevent the frequent regressions Hudder is experiencing.

 WHY DID I OVERCOMPLICATE SO MANY PARTS FOR THE SAKE OF IT BEING "Future proof", IT'S NOT, IT'S SHIT.

Imma start working on fixing the Variable System

Why are merge conflicts so hard to solve? I feel like it would take less time and thought solving the Israeli-Arab conflict!

Fixing this Variable system can cause even the most strong willed people to be suicidal.

Aight, I updated the wiki, Imma draft a changelog while it's compilin...


Music blanks, eqMac & Background Music crashes when used with Background Music (system wide per app volume control)

Bug info
Sound on Mac Pro is lost when Background Music is installed
Steps to Reproduce
1. MacOS High Sierra, latest updates as of 10/19/2020
2. Install Spotify. Verify that music plays through internal speaker or headphone jack
3. Install eqMac and launch.
	a. eqMac launches behind Finder
	b. Music is switched from headphone jack to eqMac (as expected).
	c. Music is played at very low volume (unexpected)
		i. Main Mac volume is at 50%
	d. Switch foreground app to eqMac
	e. eqMac button (middle left) switches from black red to green black
	f. Music is played at very low volume, even if eqMac volume was set to higher volume before relaunch
4. Install Bacground Music (https://github.com/kyleneideck/BackgroundMusic)
	a. Music blanks out twice during installation but comes back
	b. Background Music is auto launched by installation (I can see its double off center circle icon on the menu bar). Verify music still plays.
	c. eqMac crashes (not stopped manually, the Ignore, Reopen, blargh dialog is shown).
	d. Clicking on Mac's volume menu icon shows Background Music is selected as Output Device
5. Relaunch eqMac, it launches in the background, menu icon shows, music blanks out
	a. Click on eqMac menu icon, eqMac goes foreground, switch moves from red to green.
	b. Music blanks out. I have to click on eqMac's volume slider left and right to get music going again.
	c. Output Device is now eqMac (NOTE: eqMac overrides Device Output setting which was Background Music before. This is unexpected).
6. Tried to set Output Device back to Background Music (I like it because it lets me set different volumes for different apps).
	a. Music blanks out
	b. Output Device is still eqMac (unexpected)
	c. Background Music has crashed silently (menu icon gone, app is no longer in Activity Monitor Process Name list, so gone gone, really).
7. Click on eqMac menu icon, still no music
	a. Tried clicking on volume slider as before, it behaves
	b. Tried clicking on Output Device, eqMac unresponsive, menu icon is there, beach ball when hovered. Command Tab shows eqMac, but can't switch to app.
8. Activity Monitor shows eqMac and eqMac Web Content not responding. Others are responding
9. Killed eqMac, everything killed.
10. Still no sound
11. Relaunch eqMac, still no sound
12. Click on menu item, eqMac goes foreground but switch is now red, then turns green.
13. Same trick as before clicking on volume slider brings music back.
14. Background Music is still listed as Mac Output Device option. It is not listed in eqMac.
15. Interestingly enough clicking on Reset Playback stutters music then kills it completely. Same trick as before (#13) brings music back.

I know a little about audio/video. Processing them usually follows a flow with filters chained one to the other linearly.
So you have Input Filter (pick a source to use) -> Filter 1 (say passes high frequencies) -> Filter 2 (say increases volume) -> Output Filter (pick a music playback to use)
Here's where it gets interesting:
1. eqMac seem to insert itself as the last filter in the chain. From the eqMac's Output Device list, it really seems to be the last (after Output Filter) as only some select Output Devices are shown. These are gone:
a. Background Music (I use this to set different volumes for different apps).
b. SoundFlower (I use these to record screen captures)
2. When it inserts itself in/out it doesn't do so cleanly, it just drops the music on the floor instead of buffering it before the switch is made, and playing the music from the buffer while the switch is made.
Please make eqMac behave with Background Music. Better if you fix the filter chain behaviour.
It's got bugs but for the most part it works just fine. Except for the bugs with Background Music.
Here is their source code again: https://github.com/kyleneideck/BackgroundMusic
You really don't want me to muck in yours or theirs … https://github.com/bitgapp/eqMac
Expected Behavior
Music plays smoothly.
Apps don't crash (see repro on where crashes occur).
Setup information:

Audio device used for playback: Plain old Headphone 3.5mm jack into an external bookshelf amplified speaker (Bose something something)
Audio transmission interface: 3.5mm jack
macOS Version: High Sierra 10.13.6
eqMac Version: Driver  1.1.1
eqMac UI Version: UI 1.2.2
eqMac App: 0.3.2

Screenshots or Console.app logs
Sorry … didn't think to do this
Additional information
Just make it work with Background Music and announce it when you do (I've no idea where to sign up for notification<EMAIL_ADDRESS>

I would kindly ask the developers to enable that solution.
Both applications are great, but not working together.
With regards
.:. lutz

I am triaging & trying to fix all open issues before release of eqMac v1.0.0. Excuse the wait.
This issue is a tricky one because both apps use practically the same driver and same approach of grabbing system audio. eqMac needs to allow using BackgroundMusic as the Output Device. I will try to play around with it and see what I can do, but no promises. In the future I'm planning to implement a Volume Mixer inside eqMac, but not sure when that's going to happen

I'm doing some cleanup of the issues.
This has probably been fixed long time ago plus eqMac now has its own Volume Mixer.
I encourage people to try v1.7 by download it from the website: https://eqmac.app
Closing for now, any new issues with eqMac should be submitted through the website.
Thank you!


chore(CODEOWNERS): change reach/blocks

Migrate CODEOWNERS from reach/blocks
Created by Sourcegraph batch change alexandr.kravchenko/Reorg-codeowners-change-reach-blocks.

[BOT] Preview available with hash 01b1953493a60c58f505c92d97b03ad9ffd24227 here.


Return ChannelOutboundInvoker for methods that take Promise

Motivation:
We should better return ChannelOutboundInvoker for methods that take Promise to make it more clear how notications for completed operations work.
Modifications:

Change API
Adjust usage for new API

Result:
More clear API

This is based on https://github.com/netty/netty/pull/11575

Seems this would encourage "addListener to promise before calling operation":
// This just looks too pretty
ctx.write(obj, promise.addListener(MY_LISTENER));
// vs
ctx.write(obj, promise);
promise.addListener();

There was other discussion in #11575 like splitting Promise and Future and that seems to be the opposite of the approach taken here.
I'd much rather just add a @returns {@code promise} to the API. That seems about as clear, as we know Netty returns "convenient" objects in much of its API, and in this case it is actually slightly functional as well as it purposefully throws away some type information.

Seems this would encourage "addListener to promise before calling operation":

// This just looks too pretty

ctx.write(obj, promise.addListener(MY_LISTENER));

// vs

ctx.write(obj, promise);

promise.addListener();

There was other discussion in #11575 like splitting Promise and Future and that seems to be the opposite of the approach taken here.
I'd much rather just add a @returns {@code promise} to the API. That seems about as clear, as we know Netty returns "convenient" objects in much of its API, and in this case it is actually slightly functional as well as it purposefully throws away some type information.

This is just a first step and yes I agree we should do something like not allow adding listeners to a Promise . That's also why this is marked as a draft for now as I wanted to do things in small steps so it is easy to follow the progress

This is just a first step

I don't need to see code for all the other steps, but without a rough idea this seems like a step backward. Was this based on a discussion on another PR? I accept that sometimes you have to step backward to go forward on a better path, but what is the other path here?

Alright... After more thinking I think we should just not do this but pull in https://github.com/netty/netty/pull/11346


Make ssl engine supported protocol log messages to trace

Every time there is a ssl engine created, we log out this message. This is too much unnecessary logging.

Codecov Report

Merging #2179 (66ba63f) into master (67da981) will decrease coverage by 58.19%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #2179       +/-   ##
=============================================
- Coverage     73.03%   14.83%   -58.20%
+ Complexity    10214     2285     -7929
=============================================
  Files           737      737
  Lines         56086    56087        +1
  Branches       6905     6907        +2
=============================================
- Hits          40960     8319    -32641
- Misses        12916    47286    +34370
+ Partials       2210      482     -1728

Impacted Files
Coverage Δ

...java/com/github/ambry/commons/NettySslFactory.java
0.00% <0.00%> (-87.28%)
:arrow_down:

...com/github/ambry/commons/NettySslHttp2Factory.java
0.00% <0.00%> (-97.92%)
:arrow_down:

.../src/main/java/com/github/ambry/router/Router.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/com/github/ambry/store/Message.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/named/PutResult.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/quota/QuotaMode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/quota/QuotaName.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/rest/RestMethod.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/com/github/ambry/config/KMSConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/com/github/ambry/config/SSLConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 576 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


remove Set type parameter from ValueConstructor + MemberClassValueConstructor

You can't set value constructors.

Well, this is done. @tombentley if you want to add a gettableApply() to GettableDeclaration, go ahead, but I don't think that's something that is blocking the 1.2 release. I'm closing this issue.


vkGetInstanceProcAddr should not be initialized again

https://github.com/google/filament/blob/2f3aac29da7e833378d75dd89fadcfc4bcb11623/libs/bluevk/src/BlueVK.cpp#L360
vkGetInstanceProcAddr should not be initialized again. It was initialized in function bluevk::initialize() and got NULL after reinitalizing. THEN CRASH!!!

Can you give more details about what platform you're on? I see where we set vkGetInstanceProcAddr twice, but I don't know why this would get set to NULL the second time.

Sorry i'm late.
Detail shows below:
Platform: Mac OS X 12.1
XCode: 13.2.1
VulkanSDK: <IP_ADDRESS>

@prideout any idea on this one?

This looks like a good catch, the fix will be in bluevk-gen.py, I'll TAL.


Every time a new window or tab column is opened,plugin's function falis

Hello,I found a problem.When I open a new window or a new tab column,my zsh has not suggestions on shell.Unless I executed an order: source ~/.zshrc
Why?How can I resolve this problem.I can't find the answer from google and baidu

Same for me. Basically suggestions don't show on the first prompt when first launching the shell or a new tab/window.
An easier way to get it working is to simply hit enter. Suggestions will work for me on the second prompt.
Latest zsh-autosuggestions, macOS, iTerm and my config is in my dotfiles repo.

@lovelyJason this might be helpful for you: https://github.com/zsh-users/zsh-autosuggestions/issues/460#issuecomment-511499844


fixing dict lookup

Some error messages won't print because of an error in rendering the error message, this patch fixes the dict lookup (res.get('msg') instead of res['msg'])

Merged with some additional dict fixes via<PHONE_NUMBER>1b25633b1bab6de73384e8726fcd4d


[SPARK-9303] Decimal should use java.math.Decimal directly instead of using Scala wrapper

This PR is based on #7635 , thanks to @JoshRosen .
Because java.math.BigDecimal already has the same optimization for precision < 18 (use long for unscaledValue), so we don't need to duplicated this in Decimal. Also removed _scale, java.math.BigDecimal already have it.
In order to have unified hashCode, we still use scala.math.BigDecimal.hashCode()
After this patch, we could have end-to-end about 100% performance improvement on test which has sum of multiplication of short and decimal (SUM(short * decimal(5,2)), from 19 seconds to 9.6 seconds).

Merged build triggered.

Merged build started.

Test build #40137 has started for   PR 8018 at commit 8eee859.

Test build #40137 has finished for   PR 8018 at commit 8eee859.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #40139 has started for   PR 8018 at commit 7b70c28.

Test build #40139 has finished for   PR 8018 at commit 7b70c28.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #40147 has started for   PR 8018 at commit c861001.

Test build #40147 has finished for   PR 8018 at commit c861001.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

cc @JoshRosen for review

Merged build triggered.

Merged build started.

Test build #40228 has started for   PR 8018 at commit 56190ef.

Test build #40228 has finished for   PR 8018 at commit 56190ef.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #1414 has started for   PR 8018 at commit 56190ef.

Test build #1414 has finished for   PR 8018 at commit 56190ef.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

After this patch, we could have end-to-end about 100% performance improvement on test which has sum of multiplication of short and decimal (SUM(short * decimal(5,2)), from 19 seconds to 9.6 seconds).

Cool! I wasn't actually expecting this to lead to such a big performance improvement.

Most of the performance improvement came from two parts:

call scala.math.Decimal.apply(MathContext) is heavy, right now we change to java.math.BigDecimal.multiply(b, MathContext)
currently, when cast a numeric into decimal, we turn int/short/byte into double, then cast double into decimal, it's expensive, now we change to call Decimal(i.toLong)

other cleanups are not that necessary to the performance improvement, if they are risky for the release, we can delay that in 1.6.

One naive question, since I'm not as familiar with the old long optimization: it looks like we used to use a long for storing the small values, but it looks like JavaBigDecimal stores them as an int instead. Does this imply that fewer values can now be stored using the compact representation?
I'm probably not the best judge of the riskiness of these changes, since I don't know as much about our decimal internals compared to other reviewers / contributors. Is there someone else that we should loop in for another pair of eyes?

@JoshRosen Good question, the intCompat is actually long. It confusing me in the beginning, so double check that. So it have same range as we, JavaBigDecimal should have done better job than us (handle conversion between each other).
@mateiz Do you have some cycle to review this? If it's risky for the release, I'd like to pull out some optimization as a separate PR.

After these work, I just realized that the _precision is also not necessary in Decimal, because JavaBigDecimal already have precision for the value. Decimal._precision came from DecimalType, it's the maximum precision the JavaBigDecimal could have, only used when we create a Decimal, or change_precision().
Also, HiveTypeCoercion needs some cleanup, lots of unnecessary casting.

Good question, the intCompat is actually long. It confusing me in the beginning, so double check that.

Yep, it's a long.

Created https://github.com/apache/spark/pull/8052

Merged build triggered.

Merged build started.

Test build #40322 has started for   PR 8018 at commit 4c2752e.

I didn't realize that Java's BigDecimal already has a shortcut for things that fit in a Long. That definitely simplifies it. In terms of this change, the biggest thing I'd look for is whether some of the math operations change from the Numeric type associated with this class. Hopefully the Hive tests catch those.

Test build #40322 has finished for   PR 8018 at commit 4c2752e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

This PR may be too late for 1.5 release, I'd like close it now. For 1.6, we may want to use Decimal128 from Hive.


fix items not saved

Thank for the PR, but I had already fixed it on my dev env but I just forgot to push it 😅

@GabrielOlvH I looked into your change and I'm not shure if your code works correctly.
https://github.com/GabrielOlvH/Industrial-Revolution/commit/9867e98bb095796e0a1f9e126da71a624c99885b#diff-219ff525b9e6ab2ee826e1dfb12e9fb0147952ed18a038fe577c49096f01c182R24
You call syncable.markForUpdate() with calls makeDirty on the next tick. If the inventory is modified from outside of your machine (item insert or extract by a neighbor machine for example) then no next tick may be exists if the cunk get unloaded.

This is a very specific edge case which I believe is highly unlikely to happen.
The reason I don't call markDirty directly is because Minecraft's logic is pretty bad and would cause performance issues. Calling markDirty() needs to perform a #getChunk and also update every neighbor block because of comparators. This would not scale well in a large modded worlds with lots of things happening at once


Ambiguous handling of null in the test cases

CQLIT-15
ambiguous handling of null in IndexOf specification
the spec states
"If the list argument is null, the result is null."
however the test effectivly asserts that if either argument is null then the result is null

This issue was moved to cqframework/cql-execution#48


Added Three More Tutorials on Learn Page

Added tutorials for:

coordinate system and shapes, which is ported from https://processing.org/tutorials/drawing/ and updated with interactive examples
interactivity, which is ported from https://processing.org/tutorials/interactivity/ and updated with interactive examples
program flow

For the program flow tutorial, some examples are built using non-editable iframe instead of widget as there is an issue with loading images with p5.widget.
Thank you and please let me know if there's any issues.
Email<EMAIL_ADDRESS>

thanks @xuyixuan1998! one change requested.

@lmccart  Thanks! Those markers are deleted from the files.

@xuyixuan1998 thanks! it says file src/data/examples/en/08_Math/09_arctangent.js was deleted. is this an error?

@lmccart thanks! just added back the sections.

🎉