RedisClusterClient may have memory leak

Bug Report
I happens to a problem that RedisClusterClient may have memory leak when I got a network problem that the client cannot connect to some cluster nodes.
then we got the error:

jmap result：

there are many RedisClusterClient parameter objects with the similar number.
Expected behavior/code
lettuce don't report the error: cannot allocate direct memory
Environment

Lettuce version(s): 5.3.0.RELEASE
Redis version: 4.0.11

Possible Solution
I think when the client cannot connect to cluster nodes, lettuce would rebuild connections, but myabe the old connection wouldn't release normally, so the direct memory would be used up
but I don't know where caused this problem, it takes a long time and after restarting client, it because normal

sorry, I cannot reproduce this problem in test environment
firstly, I think maybe connections would be released slowly, but new connections would be created fast, it would cause direct memory to use up. I restart client 5 hours after network recovery, so it is not the reason.

Since we cannot proceed on this ticket without further information, we're going to close the ticket.
If you would like us to look at this issue, please provide additional information and we will re-open the issue.


chromium: 83.0.4103.106 -> 83.0.4103.116

https://chromereleases.googleblog.com/2020/06/stable-channel-update-for-desktop_22.html
This update includes 2 security fixes.
CVEs: CVE-2020-6509
Testing status

platform
attribute
status
tester

x86_64
chromium

@danielfullmer

x86_64
nixosTests.chromium

@danielfullmer

x86_64
google-chrome

@primeos

aarch64
chromium
✔
@thefloweringash

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Built chromium and nix-build nixos/tests/chromium.nix -A stable on aarch64.

google-chrome still works and I didn't notice any regressions. And thanks for taking care of this update @thefloweringash (I was away yesterday).


Implement proper docking builder support

Docks can be built easily, but when a user modifies them there's no way for us to know for now


reloc: add arch to relocatable package filename

Add architecture name for relocatable packages, to support distributing
both x86_64 version and aarch64 version.
See scylladb/scylla#8675

No need to rename noarch packages, so closing this https://github.com/scylladb/scylla/pull/8709#issuecomment-863520892

Not sure if the embedded python driver for cqlsh is really noarch.


Turn on unit testing with Docker

What was changed
Added unit testing with Docker

I didn't realize we weren't doing this. I think this is really going to help catch a lot of problems sooner... as indicated by the fact that there are quite a bunch of already-broken tests


cursed inscription numbers do not match ordinals.com

when I view the Dimension ordinals, I see two things that are off. The cursed numbers do not match Ordinals.com. For example, if I look at this one, it is -54,314. But in the wallet, it's in the -73,000s range. Also, the inscription ID is incorrect. https://ordinals.com/inscription/5c4cd4e1409ad051ff7768f54d37bee2fd5d27f140fff4ffe458c732214a8d3bi0
The inscription ID ends with i0 not i1

Addressing both points here for additional discussion:

The cursed numbers do not match Ordinals.com

Cursed inscriptions are by definition unstable and unpredictable, see this issue for the original discussion and specifically the phrase
Negative inscription numbers would always be perma-unstable

This is because new cursed inscription types may pop up in the future and indexers which start recognizing those will be forced to readjust the negative numbers to accomodate for old cursed + new cursed inscriptions.
Right now, ordhook recognizes more cursed inscriptions than ordinals.com which makes the Dimension ordinals get different numbers.

The inscription ID ends with i0 not i1

This is also a very similar problem (only with cursed inscriptions). The original definition of an inscription ID that says
Inscription IDs are of the form TXIDiN, where TXID is the transaction ID of the reveal transaction, and N is the index of the inscription in the reveal transaction.

does NOT apply to cursed inscriptions. Why? Cursed inscriptions is all about future proof-ness.
Let’s consider the following transaction 0x0000…0001:

input 0: /
input 1: inscribed with a format recognized by ord v0.7.0, generating 0x0000…0001i0
input 2: /
input 3:  inscribed with a format recognized by ord v0.7.0, generating 0x0000…0001i1

Let's say than in a few months, we’re realizing that there was a bug in the parser, or the author of that transaction was a visionary working on a curse that was not supported back then. We have to recognize input 2 as a cursed inscription, we’re doomed and we will have to mutate the inscription ids, to insert input 2 as the new 0x0000…0001i1. Also, consider the comment here for more context on the challenges of re-inscriptions.
We have brought up this issue for a couple of weeks now with the core ord team and as I mentioned before, a determination is still being made about how to mark inscription IDs for cursed inscriptions. For now, IDs should also be treated as unstable and subject to change.

If there is a "visionary" that finds a new curse and it is only about 5 total inscriptions that are affected by this new curse, I think the visionary should just quit and do something else for a living; the initial cursed inscriptions totalled over 80,000 but this new set of curses added like 5, AND they screwed up the regular numbers as well (the un-cursed) at least those in 0.6.2 no longer match the regular numbers for 0.8.3 ..  the first one I see this happening is
https://ordinals.com/inscription/207322afdcca902cb36aeb674214dc5f80f9593f12c1de57830ad33adae46a0ai0
On version 0.6.2 this was #12649108 .. now it is cursed at #-55791 (negative) .. there are 4 more like this.
They should have just left the protocol as it was, if people's got screwed up, so be it, because having to keep updating code for people that couldn't follow the spec or at least verify how most people were inscribing, is costing everyone time and money.  At the end of the day, the protocol is just all made up non-sense anyway.. just pick some non-sense and stick to it, don't have us make a career out of it.

Addressed in v2.0.0!


Error on footnotes

It seems there is some problem with blank lines on footnotes:
This code from MANUAL.txt:
[^subtitle]: To make `subtitle` work with other LaTeX
    document classes, you can add the following to `header-includes`:

        \providecommand{\subtitle}[1]{%
          \usepackage{titling}
          \posttitle{%
            \par\large#1\end{center}}
        }

Throws an error:
Runaway argument?
\providecommand {\subtitle }[1]{\usepackage {titling} \posttitle {
! Paragraph ended before \FV@BeginScanning was complete.
<to be read again>
                  \par
l.1457 }

But if I remove the first white line:
[^subtitle]: To make `subtitle` work with other LaTeX
    document classes, you can add the following to `header-includes`:
        \providecommand{\subtitle}[1]{%
          \usepackage{titling}
          \posttitle{%
            \par\large#1\end{center}}
        }

All goes well.

@manelio I regularly try to compile the markdown from here when I change code in my template and now it works. I don't know what change fixed this issue, but the following code does compile without error:
# Lorem ipsum dolor sit amet

Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt[^subtitle] ut labore et dolore magna aliquyam erat, sed diam voluptua.

Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt^[At vero eos et accusam et justo duo dolores et ea rebum.] ut labore et dolore magna aliquyam erat, sed diam voluptua.

## Takimata sanctus est

Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.

[^subtitle]: To make `subtitle` work with other LaTeX
    document classes, you can add the following to `header-includes`:

        \providecommand{\subtitle}[1]{%
          \usepackage{titling}
          \posttitle{%
            \par\large#1\end{center}}
        }

/usr/local/bin/pandoc -o footnotes.pdf footnotes.md -V colorlinks=true -V lang=de --from markdown+footnotes --template "eisvogel" --highlight-style kate --listings --pdf-engine=xelatex --number-sections

I hope the issue is fixed for you and can be closed. Sorry that I didn't respond earlier, but I simply had nothing to add to this issue.


Patch operation supoprt, Generate models with nullable properties for patch operations

Use Option<T> in azure-core to generate models that support nullable properties in patch operations.
https://github.com/anuchandy/azure-sdk-for-java/blob/patch-model-example/sdk/metricsadvisor/azure-ai-metricsadvisor/src/main/java/com/azure/ai/metricsadvisor/patch/models/AnomalyDetectionConfigurationPatch.java

Hi @srnagar, as discussed, posting the related gist here (its a bit old but probably useful for this work) https://gist.github.com/anuchandy/ca914f4a8dfaa49ea8e082de7e619c8f

Also a PPT on merge-patch+json and json-patch+json
JsonMergePatch.pptx

All the model that used by the PATCH model would be also a PATCH model.

PS: the method (vanilla or convenience) is not in the scope of the DPG.

still waiting for arch design

Design doc from Srikanta: https://gist.github.com/srnagar/8ffc8d62f97be553bdb4edd775ed12d9

8-16 Meeting minutes:

isFieldUpdated() will be package-private method handled by core.
What is the logic of isFieldUpdated()?
Generated model will have a Map to trace which properties are set, which are not, and the setters will update the map. The map will also be passed to isFieldUpdated() as a parameter. Codegen will generate the map, setters and the logic to update the map.
When a model is shared by PUT and PATCH operation, and one property is required in PUT, but optional in PATCH, how to determine if the property is updated to null or it's because it's optional?
We will put the properties into constructor which in both PUT and PATCH they are required, and let the service validate and throw error in PUT for the case where a property in PUT is required, but in PATCH is optional.

cc @mikekistler

One more question:

How will fromJson initialize the map for isFieldUpdated? I assume that all fields will show as not updated, just as for the constructor.

Hi @mikekistler, we discuss it in our DPG meeting with @srnagar. We can think of below scenarios of using fromJson

it is used when deserialize the response. In this case, constrctor will initialized the map, when the user call setters, the map will get updated.
it is used by customer directly and pass in a json to create a model, then we don't know if a field is mean to set to null or it's optional. But this case is very rare as if the user wants to pass in a json, he/she should use protocol method and does not interact with the models.

loadtesting branch from Srikanta: https://github.com/srnagar/azure-sdk-for-java/tree/loadtesting-patch

patch tsp design: https://github.com/Azure/typespec-azure/issues/3688

Link stream-style-serialization bug fix: https://github.com/Azure/autorest.java/issues/2396

cadl-ranch pr: https://github.com/Azure/cadl-ranch/pull/485


e2e Testing: Unable to create a bot using Conversational Core template

Describe the bug
Unable to create a bot using Conversational Core template.

Version
Composer build used for testing: https://github.com/microsoft/BotFramework-Composer-Nightlies/releases/tag/v1.4.0-nightly.232669.4daad5c

Browser

[X] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[X] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Start Composer
Click 'New' on the page
Select 'Create from Template'
Scroll down to select 'Conversational Core' template.
Click 'Next'
Click 'OK'

Expected behavior
A bot is created based on the conversational core template

Screenshots

Additional context

Verified that this is fixed in new nightly as of:
Version:  1.4.0-nightly.233315.683520a
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0


Does not support android api 26

Does not support android api 26.

fixed it. how to submit a pull request?

Hello, Can you submit your solution please ?

visit :
https://github.com/amitkhare/cordova-music-controls-plugin/blob/master/src/android/MusicControlsNotification.java
Replace all the content in

CORDOVA_PROJECT_ROOT\plugins\cordova-plugin-music-controls\src\android\MusicControlsNotification.java

Then in terminal:
$ cordova platform remove android
$ cordova platform add android
$ cordova run android

It's working well again!
Thank you very much @amitkhare

+1 can we create a merge request out of this ?

looks like the PR #120 has been merged, fixing this issue, now it just needs to be published to npm

Looks like issue resolved.


Fix injecting into CronJobs causing a panic

CronJobs have JobTemplates instead of Templates, causing injecting to fail.
What this PR does / why we need it: Injecting into a CronJob causes a panic
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes https://github.com/istio/issues/issues/106
Special notes for your reviewer: Replication steps are in https://github.com/istio/issues/issues/106
Release note:

Fix kube-injecting CronJobs causing a panic

@TimDumol: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Hi @TimDumol. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@TimDumol Thanks for the PR!
/ok-to-test

Hi @rshriram , rebased on top of master.


Request computation by writing request files.

Results like http://localhost:8000/site/anode09/result/?id=5-7-combined
are now rendering precomputed graphs.
These combinations should be computed on the fly. On way to do this cleanly is this:
when a user calls a url
http://localhost:8000/site/anode09/result/?id=5-7-combined
It is checked whether this result exists. If not, a file is written to the project data folder, containing a request to combine method 5 and 7. This file is read by some kind of request checking deamon, which reads the file, runs an executable and when output is done, removes the request file.
In the mean time the webpage should display something like "Computing, please refresh the page in xx seconds"
Advantage of writing files is that is is architecture independent and versatile.

wontfix


Added serializer blueprint and updated docs

This pr is a squashed version of https://github.com/nolanlawson/ember-pouch/pull/122
It adds a serializer blueprint and updates the docs.

Sorry I haven't had a chance to look at this PR, could someone with more experience with Ember blueprints look at this please?

@mattmarcum I think a serializers/application.js in the blueprints would be a great start. Users should get prompted if there is a conflict. But having it in the README could make it a first step that could lead to confusing bugs if missed.

@fivetanley So you mean this PR would make more sense without the README modification?

We ran into this recently with the ActiveModelAdapter (this reminds me I need to fix it there too). Basically, if you don't define a serializer for a model, it will look for ApplicationSerializer, and then the default serializer for the adapter (in 2.0 this is JSONAPISerializer, 'RESTSerializer` in 1.x). The reason why the README modification was made (I'm guessing) is to account for this behavior. However, if we make having the PouchDB Adapter and Serializer be the default, this would do the right thing for users instead of asking them to correct this. This may be something we rework for Ember Data 3.0, but we can work around it in addons for now.

As somebody who usually skims for the installation step and then starts hacking, I think making the application.js serializer/adapter is the move that sets users up for success.

I was reluctant to make it the default application serialiser/adapter but your point that it would prompt if there’s a conflict is true… so yeah, I also support adding it to the blueprint.

@mattmarcum, thanks for this PR. I think the generator is the right approach - we actually hit this issue ourselves. It looks like we just need to update the README to direct people to use the generator and this can be merged.

@aexmachina Can you make the readme change or close the PR?


Specs

Recommendation from expert

[ ] Dimension of the system
[ ] Cooling of the plants (Fans on the upper part the system)
[ ] Double doors on upper and lower compartments
[ ] Thicker aluminium profiles (30 by 30)
[ ] Black base for the bottom compartment
[ ] Reinforcing of middle layer
[ ] Easily accessible reservoir compartment

Current Issues

[ ] Insufficient water flow for water towers
[ ] Polycarbonate too thick for the top portion
[ ] Aluminum profile too thin
[ ] Not enough clearance for electronics
[ ] Need doors on both sides
[ ] Improper positioning of pump (not fully submerged)
[ ] Insufficient toilet float clearance
[ ] Need double door on both system
[ ] Blue tinted polycarbonate (Blocks UV rays)
[ ] Algae growth on sponge/leca
[ ] Long roots were reaching into the reservoir and choking the pumps (consider laundry bag filter?)
[ ] Larger reservoir
[ ] 1 Big pump (Unified piping system?)
[ ] Stronger castor wheels

Gen 2 Design
Main Dimension
Height: 170.0 cm
Length: 120.0 cm
Width: 80.0 cm
Plant Growth Dimension
Height: 112.4 cm
Length: 120.0 cm
Width: 74.0 cm
Reservoir Dimension
Height: 30.0 cm
Length: 120.0 cm
Width: 74.0 cm
Electronics + Germination Dimension
Height: 20.0 cm
Length: 120.0 cm
Width: 74.0 cm


feat(navbar): icon can be added to navbar with its name and size

Fixes #390.
Changes proposed in this pull request:

Make Font Awesome's outline icons available. Icon component has a new optional prop called outline.
Also add an optional prop size to the Icon component.
Update Navbar's icon and icon dropdown items so that we can add an icon by specifying its name rather than an image source.
Create a new Navbar item called image.
Update Storybook's Icon and Navbar pages with the above new features.

Newly added dependencies with Bundlephobia links:

<EMAIL_ADDRESS>
Please note:

It looks like the outline version of some of the icons on our list are only available for Font Awesome's PRO account. Link to the outline version is here, and lots of icons are greyed out.
Navbar components that are currently in use in the frontend code will require an update.

I don't understand why there are build issue with yarn

@tehKapa Readme update on May 16 had the same fail (components commits). Could it be that machine needs some sort of reset?

I don't understand why there are build issue with yarn

@tehKapa Readme update on May 16 had the same fail (components commits). Could it be that machine needs some sort of reset?

Theoretically they are containers that are created on the go


is there a picture about metallb architecture？

i want a image about metallb architecture

That image is pretty great. I won't be writing more documentation any time soon, so hopefully that was enough for you :)


Inactive Flows cause callout exception

Hi!
I'm getting a list of flows from the org, then fetching the meta for each flow so that I can update them.
If the flows in the readMetadata request are all Active then it works. If one or all in the list are Inactive then an exception is thrown. This is obviously a problem as I can't tell which flow is active or not in the first query retrieving my list of flows (not shown here as that is working).
Result When Active (inactive is underneath, note the metadata fullname changes with a version number in the inactive example):
15:17:43.737 (853960529)|USER_DEBUG|[9325]|DEBUG|readMetadata_element:[apex_schema_type_info=(http://soap.sforce.com/2006/04/metadata, true, false), field_order_type_info=(type_x, fullNames), fullNames=(Sample_loc), fullNames_type_info=(fullNames, http://soap.sforce.com/2006/04/metadata, null, 0, -1, false), type_x=Flow, type_x_type_info=(type, http://soap.sforce.com/2006/04/metadata, null, 1, 1, false)] - {response_x=null} - https://maevan-dev-ed.my.salesforce.com/services/Soap/m/32.0 - Flow
15:17:43.737 (940309286)|USER_DEBUG|[33]|DEBUG|Flows: (Flow:[Metadata.apex_schema_type_info=(http://soap.sforce.com/2006/04/metadata, true, false), Metadata.field_order_type_info=(fullName), Metadata.fullName=null, Metadata.fullName_type_info=(fullName, http://soap.sforce.com/2006/04/metadata, null, 0, 1, false), actionCalls=null, actionCalls_type_info=(actionCalls, http://soap.sforce.com/2006/04/metadata, null, 0, -1, false), apexPluginCalls=null, apexPluginCalls_type_info=(ap.... My Flow Data :) ... )])
Result when Inactive:
15:20:28.505 (805712202)|USER_DEBUG|[9325]|DEBUG|readMetadata_element:[apex_schema_type_info=(http://soap.sforce.com/2006/04/metadata, true, false), field_order_type_info=(type_x, fullNames), fullNames=(Sample_loc-1), fullNames_type_info=(fullNames, http://soap.sforce.com/2006/04/metadata, null, 0, -1, false), type_x=Flow, type_x_type_info=(type, http://soap.sforce.com/2006/04/metadata, null, 1, 1, false)] - {response_x=null} - https://maevan-dev-ed.my.salesforce.com/services/Soap/m/32.0 - Flow
15:20:28.505 (898978816)|EXCEPTION_THROWN|[9326]|System.CalloutException: Web service callout failed: Unable to parse callout response. Apex type not found for element name

I've been working on this one a little more, it seems if I request using the version number (the full name appended by the version number) the callout fails. But if I remove the version, the API will return to me the current active version by default.
Now this is actually OK, I think I can code around this, but is it possible to get an inactive flow or one of a specific version?

Example, with four versions in SF I have these four full names returned from the ListMetadataQuery:
MetadataService.ListMetadataQuery query = new MetadataService.ListMetadataQuery(); 			query.type_x = flowType; 			queries.add(query); 			MetadataService.FileProperties[] fileProperties = metadataConnection.listMetadata(queries, asOfVersion);
Returns:

Sampleflow-1
Sampleflow-2
Sampleflow-3
Sampleflow-4

If I request one of the above (lets assume I guess the active flow correctly) I follow the documentation using the full name to request the flow, ex.
MetadataService.Flow[] f = (MetadataService.Flow[]) metadataConnection.readMetadata('Flow',new String[]{'**Sampleflow-4**'}; ).getRecords();
I will get
15:20:28.505 (898978816)|EXCEPTION_THROWN|[9326]|System.CalloutException: Web service callout failed: Unable to parse callout response. Apex type not found for element name
However if I strip the "-4" from the full name, the system automatically identified the current active flow and returns me the meta data successfully. ex.
MetadataService.Flow[] f = (MetadataService.Flow[]) metadataConnection.readMetadata('Flow',new String[]{'**Sampleflow**'}; ).getRecords();
(note I've put **s around the name strings for emphasis, it's not a syntax error)
I now get my flow data:
Flow:[Metadata.apex_schema_type_info=(http://soap.sforce.com/2006/04/metadata, true, false), Metadata.field_order_type_info=(fullName), Metadata.fullName=null, Metadata.fullName_type_info=(fullName, http://soap.sforce.com/2006/04/metadata, null, 0, 1, false),...
So..

Am I correct that I should query using the true "full name" (If I'm supposed to only use the truncated name, I can strip the -X extension from the full name but this feels to be a hack (well, it is), so what should I use to get the current active version without manipulating the returned values?)
Is it possible to be able to query for a specific version, inactive or not?

When you get "Web service callout failed: Unable to parse callout response. Apex type not found for element name", can you run your code in Developer Console execute annonymous?
Then the debug log will include the actual XML response (as apposed to the debug output your getting, which is hard to see the actual response). It would be useful to see this, then it might be easier to see why the XML to Apex un-marshalling might be mismatching (which is what this error means). So this error might not relate to the full name you used, but more to the content of that specific Flow version. So if you can provide actual XML responses from the API that would help trouble shoot this issue better for sure (tip: copy paste XML from the log and use an site to make the XML pretty to paste in to this issue).
Regarding the strangeness around the Flow names, it seems the docs do not indicate that the version suffix can be removed. So it sounds like you have come across an undocumented feature to get the active one. Anyway as i said above, if you can provide XML output for your original tests in your first comment i think that might help us see things more clearly.

@c4tch please comment further if you are still having issues here.


minor changes for SR300 cameras

After getting enough feedback and giving it some thought I propose to remove SR300 wake-up support from the master branch:

It is working only on properly configured setups (integrated camera + correct BIOS)
It is supported only in FW 3.15.x.x, causing problems to 3.10.x.x users.
Implementing read-only and write-only properties as rs_options is a bad idea. This API was not clear to users. Same goes for some additional F200 and R200 options.

As a side effect this can resolve #231.

It seems that SR300 serial number reader was copy-pasted from old RSSDK code (FW 3.01.x.x), currently SR300 shares serial number formatter with the F200.

This was causing #233.
@mdhorn please review

@dorodnic Looks good. 👍
Understood that the Wake-up options need to be removed for now; we will make the required changes in realsense_camera package as well.


Refactored broker start to allow registration of filter in BrokerAdminApiApplication

BaseBrokerStarter Pinot creates _brokerAdminApplication object and starts it in the BaseBrokerStarter.start method, hence _brokerAdminApplication object is not accessible in derived classes of BaseBrokerStarter to register ContainerRequestFilter.
This PR moves the initialization of _brokerAdminApplication in BaseBrokerStarter.start method, including its upstream dependencies to BaseBrokerStarter.init method. Below is a sample derived class to register a custom filter.
public class MyBrokerStarter extends HelixBrokerStarter {
...
@Override
public void init(PinotConfiguration pinotConfiguration)
throws Exception {
super.init(pinotConfiguration);
_brokerAdminApplication.register(MyBrokerFilter.class);
}
...

Codecov Report

Merging #10904 (96ffe4b) into master (880a074) will increase coverage by 0.00%.
 Consider uploading reports for the commit 91770f3 to get more accurate results

@@            Coverage Diff            @@
##           master   #10904     +/-   ##
=========================================
  Coverage    0.11%    0.11%
=========================================
  Files        2186     2132     -54
  Lines      117232   114988   -2244
  Branches    17695    17460    -235
=========================================
  Hits          137      137
+ Misses     117075   114831   -2244
  Partials       20       20

Flag
Coverage Δ

integration1temurin11
?

integration1temurin17
?

integration1temurin20
?

integration2temurin17
?

integration2temurin20
?

unittests1temurin11
?

unittests1temurin17
?

unittests1temurin20
?

unittests2temurin11
?

unittests2temurin17
0.11% <0.00%> (-0.01%)
:arrow_down:

unittests2temurin20
0.11% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/broker/broker/helix/BaseBrokerStarter.java
0.00% <0.00%> (ø)

... and 61 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

init() should not connect the component to the cluster.
To allow registering extra properties, we can add a method in BaseBrokerStarter() and leave the default implementation empty. The sub-class can override the new method. Something like:
    _brokerAdminApplication =
        new BrokerAdminApiApplication(_routingManager, _brokerRequestHandler, _brokerMetrics, _brokerConf,
            _sqlQueryExecutor, _serverRoutingStatsManager, _accessControlFactory);
    registerExtraComponents(_brokerAdminApplication);
    _brokerAdminApplication.start(_listenerConfigs);

Let me open a new new PR

Created a new PR https://github.com/apache/pinot/pull/10942


tensorflow backend

i am using the following codes:
from imageai.Detection import ObjectDetection
import os
execution_path = os.getcwd()
detector = ObjectDetection()
detector.setModelTypeAsRetinaNet()
detector.setModelPath(os.path.join(execution_path , "resnet50_coco_best_v2.0.1.h5"))
detector.loadModel()
detections = detector.detectObjectsFromImage(input_image=os.path.join(execution_path , "image1.jpg"), output_image_path=os.path.join(execution_path , "imagenew.jpg"))
for eachObject in detections:
print(eachObject["name"] , " :   " , eachObject["percentage_probability"] )
the error I am getting everytime:
Using TensorFlow backend.
Traceback (most recent call last):
File "D:/School Files/Thesis/detection/car_detection.py", line 1, in
from imageai.Detection import ObjectDetection
File "D:\Program Files\python 3.6\lib\site-packages\imageai\Detection_init_.py", line 2, in
from imageai.Detection.keras_retinanet.models.resnet import resnet50_retinanet
File "D:\Program Files\python 3.6\lib\site-packages\imageai\Detection\keras_retinanet\models\resnet.py", line 19, in
import keras
File "D:\Program Files\python 3.6\lib\site-packages\keras_init_.py", line 3, in
from . import utils
File "D:\Program Files\python 3.6\lib\site-packages\keras\utils_init_.py", line 6, in
from . import conv_utils
File "D:\Program Files\python 3.6\lib\site-packages\keras\utils\conv_utils.py", line 9, in
from .. import backend as K
File "D:\Program Files\python 3.6\lib\site-packages\keras\backend_init_.py", line 1, in
from .load_backend import epsilon
File "D:\Program Files\python 3.6\lib\site-packages\keras\backend\load_backend.py", line 89, in
from .tensorflow_backend import *
File "D:\Program Files\python 3.6\lib\site-packages\keras\backend\tensorflow_backend.py", line 5, in
import tensorflow as tf
File "D:\Program Files\python 3.6\lib\site-packages\tensorflow_init_.py", line 28, in
from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-import
File "D:\Program Files\python 3.6\lib\site-packages\tensorflow\python_init_.py", line 52, in
from tensorflow.core.framework.graph_pb2 import *
File "D:\Program Files\python 3.6\lib\site-packages\tensorflow\core\framework\graph_pb2.py", line 7, in
from google.protobuf import descriptor as _descriptor
File "D:\Program Files\python 3.6\lib\site-packages\google\protobuf\descriptor.py", line 47, in
from google.protobuf.pyext import _message
ImportError: DLL load failed: The specified procedure could not be found.
Process finished with exit code 1
how do i Fix this issue? thanks

any news on this? otherwise should be closed cc @OlafenwaMoses

Thanks @rola93


Add is_deprecated and get_non_deprecated() to CRS

This PR adds two methods:

is_deprecated
get_non_deprecated

To replicate the functionality in PROJ C API.

proj_is_deprecated

proj_get_non_deprecated

[x] Closes #1367

[x] Tests added

[x] Fully documented, including history.rst for all changes and api/*.rst for new API

Looks great 👍. Seems like there are unrelated failures. So, should be good to go after the minor changes.


Improve hud accessibility for screen reader users

Signed-off-by: Florian Beijers<EMAIL_ADDRESS>

This PR does a number of things:

the various iframes are now titled, which makes their function and location clearer. This should help in making the tutorial easier to follow.
The roles and labels of some of the components have been overwritten for screen reader users only. This will make identification of the various controls easier. Notably, buttons are actually buttons semantically now where they were divs before, and the labels for the various tools are easier to follow now.

Some of the labels are currently English-only, and these changes do nothing for keyboard-only users just yet, but I'm intending to add some more odds and ends as I think of them.

The formatting in inject.js needs to be fixed: e.g. 571:1 Expected indentation of 2 tabs but found 0.                                  indent.

We can also addressed that, as you prefer.

Thanks for submitting this - we're always very happy to see accessibility improvements.
It should be easy to make the labels I18n, eg change:
<modal :title="title" :show="show" @close="close" aria-label="Select Tools">
to something like
<modal :title="title" :show="show" @close="close" aria-label="$t('message.label_select_tools')">
Then add the following line to src/other/resources/UIMessages/UIMessages.properties:
label_select_tools = Select Tools
This isnt mandatory for this PR as far as I'm concerned but it seems a shame not to do it at this stage as theres only a few instances right now?

Agreed. Will take some time today to fix the linting errors and add the i18n support. Do we have access to $t() within inject.js for the frame titles, as well?

Possibly not :/ You could try and see - if not we'll have to look into that...

@psiinon  doesn't look like it :( getting $t undefined errors when I try. I will leave those entries alone for now, then, can certainly do the other ones, though. Give me half an hour.

@psiinon  if I add the $t() calls in the aria-label attributes of the elements like yousuggessted, it seems they don't get evaluated properly, or not in time. Example:

This results in the label getting set to that hardcoded string , rather than it getting evaluated. I also tried by doing "{{ $t('message.a11y_label_add_tool'}}"wih similar results.
I also see I didn't seem to have gotten to all the linting errors :) checking

@psiinon  I wrote strings for all of those, but like I stated in the comment above the translations don't appear to be taking :) Could you double-check the syntax you gave me for correctness? If it is correct, we might be running into a limitation of the way ARIA properties on elements are calculated by the browser; JS might be coming in too late to influence the way they are rendered.
For completeness, if I set the  "add tools" to "$t('message.a11y_label_add_tools')" insead on the aria-label attribute, the screen reader will literally read out $t('message.a11y_label_add_tools) rather than the retrieved value, and I'm not sure why that is happening. I tried variations with adding and removing a : in front of the aria-label property, as well as using {{}} within the double quotes to try to explicitly interpolate the JS, but it doesn't appear to be having an effect in my tests.

Arg, sorry! I'll have a look at that tomorrow:)

Based on this example: https://vuejsdevelopers.com/2019/05/13/accessibility-validation-aria-vuejs/
I've worked out that putting a : immediatelly before aria-label=$t('message.a11y_label_close') makes it work!
So :aria-label=$t('message.a11y_label_close') :)
OK, so I dont really know why thats needed, but it makes it work for me :D

@psiinon confirmed working, I'll make the requisite changes. I also noticed that panel.html wasn't i18n-enabled, I've fixed that.
I'm also noticing zap v2.1.0 is being used by gradle, need me to bump that up to 2.1.1 while I'm here?

2.11.1? :) please!

Update the changelog as well :)

good catch, i forgot to put those three back. fixed now.

Many thanks!

@thc202 ok with this PR?

Thank you!


Issue with running or2papers.py script

Hi I have been trying to the following command, but having the error below. Any suggestion what could be the reason? Note I tried to install openreview package using both from source and pip, none is solving the problem.
python or2papers.py "user" "pass" "EMNLP/2023/Workshop"
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://api.openreview.net/notes?invitation=EMNLP%2F2023%2FWorkshop%2FPaper.*%2F-%2FDecision&limit=1000&sort=id
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "or2papers.py", line 171, in
main(args.username, args.password, args.venue, args.all, args.pdfs)
File "or2papers.py", line 50, in main
client_acl, invitation=venue + "/Paper.*/-/Decision"
File "/Users/firojalamqcri/Others/BLP/blp-workshop/openreview-py/openreview/tools.py", line 1000, in iterget_notes
return efficient_iterget(client.get_notes, desc='Getting Notes', **params)
File "/Users/firojalamqcri/Others/BLP/blp-workshop/openreview-py/openreview/tools.py", line 781, in init
self.current_batch, total = self.get_function(**self.params)
File "/Users/firojalamqcri/Others/BLP/blp-workshop/openreview-py/openreview/openreview.py", line 1059, in get_notes
response = self.__handle_response(response)
File "/Users/firojalamqcri/Others/BLP/blp-workshop/openreview-py/openreview/openreview.py", line 130, in __handle_response
raise OpenReviewException(error)
openreview.openreview.OpenReviewException: {'name': 'ValidationError', 'message': 'invitation must be a prefix regex. If validation passes, any remaining regex characters will be escaped.', 'status': 400, 'details': {'path': '.invitation', 'reqId': '2023-11-07-2049567'}}
(b

@rswilkens if I'm not mistaken you can help with this bug, or can't you?

Hi @crux82, thanks.
@rswilkens, if you can help on this it would be great. Kind of stuck here.

I'm not sure if this is related, but I am having trouble even getting a handle on the associated workshops' invitations:
>>> client.get_group("EMNLP/2023/Workshop/NLP-OSS").invitation is None
True

Hi @firojalam, have you already tried or2program_committee.py?
For the or2papers.py, you have to provide the venue ID as it is on OpenReview. For example:
python or2papers.py "user" "pass" "EMNLP/2023/Workshop/NLP-OSS"

I will say that it doesn't work for me. Same error as @firojalam reported.

@erip, did you manage to run the or2program_committee.py?

Neither script works.

@erip and @firojalam, please try to replace (lines 45 - 53)
   decision_by_forum = {         d.forum: d         for d in list(             openreview.tools.iterget_notes(                 client_acl, invitation=venue + "/Paper.*/-/Decision"             )         )         if "accept" in d.content["decision"].lower()     }
with
    decision_by_forum = {         d.forum: d         for d in list(             openreview.tools.iterget_notes(                 client_acl, invitation=venue + "/Paper.*" # "/Paper.*/-/Decision"             )         )         if "decision" in d.content and "accept" in d.content["decision"].lower()     }
in the or2papers.py

Hi,
I solved this using a different approach. Used api version2 and needed to modify the code in different places.
Commented line 40-55, and used the following with some additional changes.
submissions = client_acl.get_all_notes(content={'venueid': 'your vanue id'})

The issue is that EMNLP Is running with the v2 API but this client assumes v1 API.

I'm experiencing the same issue with both scripts when trying to run this for EACL 2024 (venue as EACL/2024/Conference).

@mpurver please pull down the branch in this pull request and give it a try: https://github.com/rycolab/aclpub2/pull/165
It incorporates the changes from @rswilkens comment above: https://github.com/rycolab/aclpub2/issues/161#issuecomment-1808244596

@mpurver if it works I will accept the pull request
@@zhzhang thank you!!!

@zhzhang no luck so far - it connects fine but the submissions and decision_by_forum lists are both empty.

I fear that our users do not have visibility of the papers. In any case, we should add some meaningful message in these cases for the users.

@haroldrubio can you please help us?

I've made some changes in the OR scripts in this PR, please take a look and let me know if you run into some issues

#166

@haroldrubio Thank you very much for your support! I can download the papers.
@zhzhang I think we will merge https://github.com/rycolab/aclpub2/pull/166 into the main branch.
Unfortunately, or2program_committee.py does not download anything. Could this be a problem related to my publication chair account on OperReview?
@mpurver can you download the committee?

It should be solved

I need to add something here: the structure in OpenReview can vary between conferences and workshops. For instance, in a Main Conference track, submissions might be further divided into categories like 'Main' and 'Findings'. However, on the ACL website, these tracks are represented as tabs, and the current or2papers.py script cannot handle this differentiation because it only uses the venueid. This will raise the same error.
For example, in the extracted data from the OpenReview library, you might see something like 'venueid':'aclweb.org/ACL/2024/ARR_Commitment' and 'venue': 'ACL 2024 Main'. This makes it difficult to map the tracks directly as they appear on the ACL website, such as 'ACL 2024 Main' under a specific tab like 'Main Conference' or 'Findings'. Therefore, the script needs to be adapted to handle these variations in structure.


Get a error during test discovery, when I clicked Refresh Tests button

Describe the bug

[Error 11:50:28] [Error TypeError] Cannot read properties of undefined (reading 'file')
TypeError: Cannot read properties of undefined (reading 'file')
	at wn (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:17:385)
	at nt.discoverFileTests (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:15:4684)
	at Xt.resolveTestFile (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:17:11904)
	at Xt.testController.resolveHandler [as h] (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:17:8857)
	at n.M (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:23125)
	at n.J (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:22638)
	at n.H (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:22327)
	at n.I (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:22346)
	at n.z (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:21159)
	at n.w (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:20336)
	at H.t.listener (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:22315)
	at Object.add (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:24851)
	at nt.getOrCreateFileTestItem (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:15:3441)
	at nt.discoverAllTestFiles (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:15:2694)
	at nt.watchTestFilesInWorkspace (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:15:4042)
	at Xt.defineTestProfiles (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:17:10483)
	at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
	at async r.$refreshTests (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:154:8490)

Reproduction
https://stackblitz.com/edit/stackblitz-starters-tn8las?file=package.json&view=editor
Output
[INFO 11:54:28 AM] [v0.6.0] Vitest extension is activated because Vitest is installed or there is a Vite/Vitest config file in the workspace.
[INFO 11:54:29 AM] [API] Running Vitest: v1.5.0 (E:/Workspace/test/cmd-test/vitest.config.ts)
[INFO 11:54:29 AM] [API] Vitest process 13272 created
[Error 11:54:29 AM] [Error TypeError] Cannot read properties of undefined (reading 'file')
TypeError: Cannot read properties of undefined (reading 'file')
	at wn (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:17:385)
	at nt.discoverFileTests (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:15:4684)
	at Xt.resolveTestFile (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:17:11904)
	at Xt.testController.resolveHandler [as h] (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:17:8857)
	at n.M (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:23125)
	at n.J (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:22638)
	at n.H (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:22327)
	at n.I (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:22346)
	at n.z (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:21159)
	at n.w (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:20336)
	at H.t.listener (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:22315)
	at Object.add (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:24851)
	at nt.getOrCreateFileTestItem (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:15:3441)
	at nt.discoverAllTestFiles (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:15:2694)
	at nt.watchTestFilesInWorkspace (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:15:4042)
	at Xt.defineTestProfiles (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:17:10483)
	at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
	at async Xt.activate (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:17:12789)
	at async Ic (c:\Users\alone\.vscode\extensions\vitest.explorer-0.6.0\dist\extension.js:17:8373)
	at async a.n (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:142:6237)
	at async a.m (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:142:6200)
	at async a.l (e:\Applications\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:142:5657)

Version
0.6.0
Validations

[X] Check that you are using the latest version of the extension
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[x] The provided reproduction is a minimal reproducible example of the bug.

Hmmm interesting how the source maps don't seem to work?

Hmmm interesting how the source maps don't seem to work?

But I find bug seems to be here: src/testTree.ts#L311
getTestData(testItem) returned a undefined value.
function getAPIFromTestItem(testItem: vscode.TestItem): VitestFolderAPI | null {
  const data = getTestData(testItem)
  // API is stored in test files - if this is a folder, try to find a file inside,
  // otherwise go up until we find a file, this should never be a folder
  if (data instanceof TestFolder)
    return getAPIFromFolder(testItem)

  if (data instanceof TestFile)
    return data.api
  return data.file.api
}

I cannot reproduce it with the link. Do you use other extensions? On your screenshot, this is not how we display tests.

@sheremet-va not sure if you're aware, but in the test explorer, you can still display tests as a list instead of a tree. This is a vscode feature. It's in the "..." menu. Maybe that could explain the screenshot difference.

Does it throw an error in the latest version? if it does, the error should be more descriptive at least.

@sheremet-va Thanks, I saw it. And I know how to reproduce, just change testing view as list and refresh, view as tree is ok.

Fixed in https://github.com/vitest-dev/vscode/commit/7ce92f16db7f0e33e5ec2596bd20e4075a86cc4a


chore: bump version to 1.0.2

Description of changes: bump version after latest PR(s).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Questions for providing value setting API based on Array index

Description:
Before implementing the value setting API based on Array index, I have a question to ask
related https://github.com/yorkie-team/yorkie-js-sdk/issues/191
Our strategy is to set value at the value position of createdAt in the array index.
However, if the above strategy is used in the current code, the following issue bellow
// base array
d1.Update(func(root *proxy.ObjectProxy) error {
	root.SetNewArray("k1").AddInteger(0, 1, 2)
	return nil
})
c1.Sync(ctx)
c2.Sync(ctx)

d1.Update(func(root *proxy.ObjectProxy) error {
	root.GetArray("k1").AddInteger(0, 4)
	assert.Equal(t, `{"k1":[0,4,1,2]}`, root.Marshal())
	return nil
})

d2.Update(func(root *proxy.ObjectProxy) error {
	root.GetArray("k1").SetValue(1, 5)
	assert.Equal(t, `{"k1":[0,5,2]}`, root.Marshal())
	return nil
})

c1.Sync(ctx)
c2.Sync(ctx)
c1.Sync(ctx)
assert.Equal(t, `{"k1":[0,4,5,2]}`, d1.Marshal()) // expected value
assert.Equal(t, `{"k1":[0,5,4,2]}`, d2.Marshal()) // but 😭

[0, 4, 5, 2] are expected values. But the value of d2 is  [ 0, 5, 4, 2 ].
The reason is that InsertIntegerAfter compares the index's next node createdAt and puts it after createdAt that is larger than itself.
https://github.com/yorkie-team/yorkie/blob/main/pkg/document/json/rga_tree_list.go#L306
array [0(t0),1(t1),2(t2)]
d1 case

In d1, add operation is applied first.
d1.InsertIntegerAfter(0, 4)
-> [0(t0),4(t3),1(t1),2(t2)]
setIndex is applied to create the desired value.
d1.setIndex( 1, 5 )
-> [0(t0),4(t3),5(t4),2(t2)]

However
d2 case

In d2, setIndex operation is applied first.
d2.setIndex( 1, 5 )
-> [0(t0),5(t4),2(t2)]

add operation applies, but createdAt of add operation puts t3 after 5.
d2.InsertIntegerAfter(0, 4)
-> [0(t0),5(t4),4(t3),2(t2)]

In the present state, The commutative law does not hold.
Why:

Thanks for the detailed investigation. There seems to be an unexpected commutative property problem between InsertOperation and SetOperation. We should spend a little more time thinking about the algorithm and proceed.

@ppeeou, @mojosoeun
I've been thinking about this issue a bit more.
The cause of the problem described in this issue is that we use a mix of element positioning time and element creation time in the array(Currently, we only update movedAt when an element is moved, so we take the positioning time of the unmoved element from createdAt).
I think that the problem will be solved by expressing the time the element was positioned in movedAt, even if the position of the element is not moved. Even if an element is newly replaced with SetOperation, the positioning time of the element in the array is recorded as the previous time.

oh...🤩  I'll try it as you said

We will consider this feature again in the future.


Fixes #4, adds endpoint validation with example, adds a case to the g…

Description
This PR add endpoint validation which can be used for the endpoints requiring data objects from the frontend.
The PR suggest 1 of 2 methods, either using fluentvalidation or roll our own validation, choosing either will require a small rewrite of things! Don't merge before this has been discussed!
Resolved Issue
Fixes #4
Changes
The changes are as follows:
Create a validation filter that can be used with endpointfilters, this ensures we can intercept the incoming http request. Here i have added the boiler plate for either fluentvalidation or our own validation. The example running on this branch utilizes the fluentvalidation.
Additional changes are changes to the middleware as I discovered that generating an invalid object resulted in a BadHttpRequestException, which just return a 500 internal server error, I changed this to a 400 bad request with a problem details response saying "invalid request object".
We should consider if we are fine with this, as this means that for what ever reason asp would throw this exception will lead to this response, and I dont personally know if there could be other cases where this exact exception could be thrown, if we cant live with this we should go back to return 500.

Changed the endpoint validation to only use FluentValidation, had to add a package System.data.json as the project failed because of a vulnerability in an earlier package.


ui: ILL BorrowingRequest details page

@kprzerwa I am not able to fix the menu in the details pages of Orders and Borrowing Requests with this ref madness, help needed! :)


Youtube Unable to download webpage

[x ] I've verified and I assure that I'm running youtube-dl 2017.01.10
[x ] At least skimmed through README and most notably FAQ and BUGS sections
[ x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
sinusbot@Server:/opt/ts3soundboard$ youtube-dl https://www.youtube.com/watch?v=7Qp5vcuMIlk
[youtube] 7Qp5vcuMIlk: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 429: Too Many Requests (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
sinusbot@Server:/opt/ts3soundboard$ youtube-dl -v https://www.youtube.com/watch?v=7Qp5vcuMIlk
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.youtube.com/watch?v=7Qp5vcuMIlk']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.01.10
[debug] Python version 2.7.9 - Linux-3.14.32-xxxx-grs-ipv6-64-x86_64-with-Debian-8
[debug] exe versions: avconv 11.8-6, avprobe 11.8-6
[debug] Proxy map: {}
[youtube] 7Qp5vcuMIlk: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 429: Too Many Requests (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 406, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2001, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python2.7/urllib2.py", line 437, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 550, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 475, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 409, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 558, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)

Description of your issue, suggested solution and other information
If I try to download every video from Youtube I get this error. I tried using Python3 as they suggest here but it didn't work.

https://github.com/rg3/youtube-dl#http-error-429-too-many-requests-or-402-payment-required
#5138.


Need cherry-pick #253 to release branch

Bug Report
Please answer these questions before submitting your issue. Thanks!

What did you do? If possible, provide a recipe for reproducing the error.
Use tidb-lightning and set tidb-password

kn t1 logs -f lighting-tidb-lightning-qjtfs
flag provided but not defined: -tidb-password
Usage:
  -L string
        log level: info, debug, warn, error, fatal (default "info")
  -V    print version of lightning
  -backend string
        delivery backend ("importer" or "mysql")
  -c string
        (deprecated alias of -config)
  -config string
        tidb-lightning configuration file
  -d string
        Directory of the dump to import
  -importer string
        address (host:port) to connect to tikv-importer
  -log-file string
        log file path
  -pd-urls string
        PD endpoint address
  -server-mode
        start Lightning in server mode, wait for multiple tasks instead of starting immediately
  -status-addr string
        the Lightning server address
  -tidb-host string
        TiDB server host
  -tidb-port int
        TiDB server port (default 4000)
  -tidb-status int
        TiDB server status port (default 10080)
  -tidb-user string
        TiDB user name to connect
Failed to parse command flags:  flag provided but not defined: -tidb-password

What did you expect to see?
Can set tidb-password

What did you see instead?
Failed to parse command flags:  flag provided but not defined: -tidb-password

Versions of the cluster

TiDB-Lightning version (run tidb-lightning -V):
v3.0.8

TiKV-Importer version (run tikv-importer -V)
(paste TiKV-Importer version here)

TiKV version (run tikv-server -V):
(paste TiKV version here)

TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
(paste TiDB cluster version here)

Other interesting information (system version, hardware config, etc):

Operation logs

Please upload tidb-lightning.log for TiDB-Lightning if possible
Please upload tikv-importer.log from TiKV-Importer if possible
Other interesting logs

Configuration of the cluster and the task

tidb-lightning.toml for TiDB-Lightning if possible
tikv-importer.toml for TiKV-Importer if possible
inventory.ini if deployed by Ansible

Screenshot/exported-PDF of Grafana dashboard or metrics' graph in Prometheus for TiDB-Lightning if possible

The release branches have been synchronized and #253 will be included in v3.0.9.


always using placeholder when have success

When i use this:
        self.imageView.hnk_setImageFromURL(url!, placeholder: nil, success: { (UIImage) -> Void in
            println("SUCCESS")
        }) { (NSError) -> Void in
            println("ERROR")
        }

i always get blank image, becouse placeholder, and i get SUCCESS printed.
Any fix for this?
Am i doing something wrong here?

tl;dr
self.image = $0

add this code to your success closure
Just having a quick look through the code, if you use a success handler you are responsible for actually setting the image, if the success closure is omitted the image will be set for you.
I'm guessing this is so that devs have the opportunity for things like image post processing, related animations etc..

"If a success block is provided you will be responsible for setting the image"
use:
self.imgView.hnk_setImageFromURL(url, placeholder: nil, success: { (image) -> Void in
self.imgView.image = image
}, failure: { (error) -> Void in
            })


[Jupyter] Read PPS config from notebook

Tasks

[x] Backend reads config from notebook metadata
[x] Use last_modified_time to verify correct notebook version

[x] Access last_modified_time in frontend
[x] Feed last_modified_time to Pipeline react widget at render time
[x] Rerender Pipeline widget on save to disk.

[x] Bundle relevant frontend data into a PpsContext object.

[x] Remove request body from pps/_create GET call.
[ ] Remove logging statements.

Future Tasks

[ ] Restructure PPS config
[ ] Don't stringify input spec on save

Test cases

Confirmed tripping of last_modified timestamp check by: create a pipeline enabled notebook and saving it, using touch to bump the timestamp on the file, then clicking Create Pipeline in the UI.
Tried creating a pipeline with a deeply nested notebook ./test/something/new/InFolder.ipynb which was created correctly.

Do you have a different linter running here? Noticing a bunch of stylistic changes

Future work: We may want to consider moving the notebook path to inside the request body. While the contents API has the path in the URL, they do a bunch of munging on it to make sure it's valid.


Test routine needs to have Action as the first column

Just like test cases
Also Page and Data columns should be active/inactive just like test cases

As per V's comment page and element editing needs to match the test case editor, i.e. these fields are read-only for helper functions that don't refer to a page element, like "Run Code" in the example below:

Passed:


Run tests on CircleCI

This will make the tests run on circleci.com, which has 4 free containers (essentially free parallel builds) for public projects. Circle will annotate each commit with the test-status, so either green or red.
We should not merge anything into the base branch that is red.
Currently, one test fails (something with apm) so I guess that test failure needs to be fixed before we can merge this. We might just update the expectation of the test to the actual value, since the software is already released. The alternative is to ignore the test for now, until there's time to fix it. I think fixing the underlying reason for the test failure is the best option, but also the most time-consuming so to me, it should not be in scope here.
@dsjoerg

You can see the build history here for my fork - we would set up something similar for the ggtracker remote:
https://circleci.com/gh/nickelsen/sc2reader

OK @nickelsen, just committed d5f5203ee7a94409bd07fd3ecdc4760bf909e308 which marks that failing test as expected-to-fail.

Great! @dsjoerg I think an admin needs to set up the build on circleci.com (it's really simple, just clicking add project, clicking sc2reader in ggtracker and clicking build project). I cannot do that for ggtracker.
PRs from forks will automatically be run, because this is a public project.
Should we make upstream a protected branch, so changes have to pass tests and go through PRs to be merged in? It really improves the information flow so everyone knows what is going in when.

I'm configuring it now

Awesome! Thanks! 😃

Hey @nickelsen where's the documentation on how to make a branch protected?  Can't find it

@nickelsen never mind, found it

@nickelsen I assumed you were still talking about CircleCI but I see now that it's a github thing

@nickelsen CircleCI integration is complete w00t thanks

https://help.github.com/articles/configuring-protected-branches/

Awesome - thank you! 👍  We should do the same for the other projects. I tried setting up circleci for ggpyjobs, but got blocked by S3 credentials - do you know if there's a way to test without that being set up? We could set it up in environment variables, but they will not be loaded for PRs from forks, because of security reasons.

@nickelsen with some minor changes, we can set the tests to get AWS/S3 credentials from environment variables, and there's a way to config CircleCI to have private environment variables.  Then tests can use an AWS/S3 account that I provide for that purpose.
However given our tight-knit small group of contributors I'm inclined to save this for later.

Ok, I understand - let's prioritise fixing the app for now. 😁


Commas before closing brackets do not look consistent

Rubocop has several style cops related to trailing commas. The meaning of trailing commas is often to allow adding new method arguments or structure elements without changing previous ones.
However, having syntax like this I won't be able to add new argument at the end without changing lines with existing arguments.
Should we disable comma before closing brackets?

Expected behavior
Commas right before closing brackets should not be allowed
Actual behavior
some_method(a: "b",
  c: "d",)

is a valid syntax
Steps to reproduce the problem

Use this cop

Style/TrailingCommaInArguments:
  EnforcedStyleForMultiline: consistent_comma

Add code described above
Run rubocop

RuboCop version
$ bin/rubocop -V
1.31.2 (using Parser <IP_ADDRESS>, rubocop-ast 1.18.0, running on ruby 3.1.2 x86_64-darwin21)
  - rubocop-performance 1.11.5
  - rubocop-rails 2.12.4
  - rubocop-rspec 2.4.0

Shopify-rubocop just kicked in with that cop, and I do agree that
call(
  a,
  b,
  ) # is ok, last comma should be enfored

But that
call(a,
       b,) # enforcing that here is weird, and anyway useless because even with a `,` it's still a 2 line diff

call(a,
       b, # diff line 1
       c,) # diff line 2


[Question] Does FMHA in context phase support custom alibi slopes?

Hi TensorRT-LLM teams! Thank you for this amazing project! I wonder whether we can use custom alibi slopes with FMHA kernels in context phase. I find that the linear_bias_slopes variable is only used when mEnableContextFMHA is false.
https://github.com/NVIDIA/TensorRT-LLM/blob/5ddb6bf218ed16a2dcf0058f20c59a247e180fd2/cpp/tensorrt_llm/plugins/gptAttentionCommon/gptAttentionCommon.cpp#L1164
I also find that there is a class named AlibiParams, but seems that there is not alibi slopes related variables in this class.
https://github.com/NVIDIA/TensorRT-LLM/blob/5ddb6bf218ed16a2dcf0058f20c59a247e180fd2/cpp/tensorrt_llm/kernels/contextFusedMultiHeadAttention/fused_multihead_attention_common.h#L46-L82
Can we use custom alibi slopes by this class? Or it's unsupported to use custom alibi slopes for FMHA kernels?

Hi @xTayEx, currently the context FMHA implementation computes the alibi slopes directly instead of loading from memory, so it does not support custom slopes.

Hi @xTayEx, currently the context FMHA implementation computes the alibi slopes directly instead of loading from memory, so it does not support custom slopes.

Thanks!


chore: random beacon bounty

I updated random beacon contract to latest cosmwasm version. Just need to make one more requested revision, and deploy to mainnet.
PR: https://github.com/confio/rand/pull/3

AWESOME. Cool to see this got merged upstream. THANK YOU.


virgo_lua_loader: use only virgo and preload

replace all package.loaders with either the virgo zip loader or the
preload loader. This reduces file opens on Mac OSX from 66 to 10.
TODO: monitoring.zip is opened multiple times

+1


Add pub fn RTree::drain()

[x] I agree to follow the project's code of conduct.
[x] I added an entry to rstar/CHANGELOG.md if knowledge of this change could be valuable to users.

bors r+


SVN Config Disclosure

Add SVN Config Disclosure Vulnerability

@phith0n Hi, I contributed a new vulnerability experiment environment and passed the code format verification. If there are no other problems, please merge it into vulhub.

Hi @b1tkeeper ,
Thanks for your contribution. Actually "SVN config discovery" isn't an issue that belongs to a specific software, so I don't think it is suitable for adding to Vulhub as a vulnerability environment.
For example, SQL injection is a common and critical issue, but Vulhub doesn't have a environment called "SQL injection". Same as SQL injection, Vulhub only accepts the issues that related to a real-world software, not a common issue.
Thanks again for your contribution. I'll keep this PR open for a couple of days, don't hesitate to present your idea here if you have further questions.

Hi @b1tkeeper ,
Thanks for your contribution. Actually "SVN config discovery" isn't an issue that belongs to a specific software, so I don't think it is suitable for adding to Vulhub as a vulnerability environment.
For example, SQL injection is a common and critical issue, but Vulhub doesn't have a environment called "SQL injection". Same as SQL injection, Vulhub only accepts the issues that related to a real-world software, not a common issue.
Another example, the backup archive "backup.zip" is exposed on web directory and anyone can download the source code from http://example.com/backup.zip. It's because of the server manager put the backup archive in the web directory, and not an vulnerability that caused by Nginx or Apache, so it's also not suitable for adding into Vulhub.
Thanks again for your contribution. I'll keep this PR open for a couple of days, don't hesitate to present your idea here if you have further questions.

Fine, Thank you for your prompt reply. ^-^


Rename resp.body to resp.text

For both the WSGI and ASGI interfaces, rename Response.body to Response.text to provide a better contrast to Response.data. Response.body should then be made a deprecated alias.
Don't forget to also grep the docstrings and /docs for references to 'body' and update them accordingly.
NOTE: It may be best to wait to implement this issue until #1573 is merged to avoid conflicts.

@kgriffs i'll try to do it.

@mrpycharm great :+1:
I added blocked-by-release just to reflect upon the relation to merging ASGI branch/the first async alpha release, but you can start working on it in the meanwhile. Just that we'll probably want to merge the mentioned large PR first, and you may have to do a second round of changes if that's OK @mrpycharm .

@vytas7 sure.

@mrpycharm thought just checking if you were still working on this?
And sorry for not removing the label earlier. This is no longer blocked on any issues as #1573 landed some months ago.

Hi @vytas7, apologies for not updating here. I might not be able to complete it because I am caught up in some urgent things these days.

No worries! I'm then leaving the needs contributor label for now, but don't hesitate to let us know if you wish to grab this (or another) issue again!

Sure @vytas7 I'll pick it up again if I get a chance to :)


Adding more questions to the database

🚀 Feature Proposal
Adding more supported questions
Motivation
The extension is quite great! However, the list of supported question is limited. It would be better if it can support more questions.

Why are test cases not parsed from source page when problem is loaded ?

Why are test cases not parsed from source page when problem is loaded ?


marked less than one item ,mitmproxy will broken

Steps to reproduce the problem:

click m toggle flow mark
click M toggle marked flow view
only 1 item had mark,then click m to cancel mark.
click M return back..mitmproxy will broken.

in other words,when marked ** less than one item ** mitmproxy will broken
System information
    Traceback (most recent call last):
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/mitmproxy/console/master.py", line 482, in run
    self.loop.run()
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/urwid/main_loop.py", line 278, in run
    self._run()
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/urwid/main_loop.py", line 376, in _run
    self.event_loop.run()
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/urwid/main_loop.py", line 682, in run
    self._loop()
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/urwid/main_loop.py", line 719, in _loop
    self._watch_files[fd]()
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/urwid/raw_display.py", line 393, in <lambda>
    event_loop, callback, self.get_available_raw_input())
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/urwid/raw_display.py", line 493, in parse_input
    callback(processed, processed_codes)
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/urwid/main_loop.py", line 403, in _update
    self.process_input(keys)
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/urwid/main_loop.py", line 503, in process_input
    k = self._topmost_widget.keypress(self.screen_size, k)
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/mitmproxy/console/window.py", line 86, in keypress
    k = super(self.__class__, self).keypress(size, k)
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/urwid/container.py", line 1128, in keypress
    return self.body.keypress( (maxcol, remaining), key )
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/mitmproxy/console/flowlist.py", line 385, in keypress
    return urwid.ListBox.keypress(self, size, key)
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/urwid/listbox.py", line 987, in keypress
    key = focus_widget.keypress((maxcol,),key)
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/mitmproxy/console/flowlist.py", line 179, in keypress
    self.state.disable_marked_filter()
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/mitmproxy/console/master.py", line 183, in disable_marked_filter
    self.set_focus_flow(nearest_marked)
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/mitmproxy/console/master.py", line 107, in set_focus_flow
    self.set_focus(self.view.index(f))
  File "/usr/local/Cellar/mitmproxy/0.18.2_1/libexec/lib/python2.7/site-packages/mitmproxy/flow/state.py", line 36, in index
    return self._list.index(f)
ValueError: None is not in list

mitmproxy has crashed!
Please lodge a bug report at:
	https://github.com/mitmproxy/mitmproxy
Shutting down...

Thanks for the report!
The good news is that this is fixed on master (at least I can't reproduce it, and the instructions are clear), the bad news is see two other bugs:

It is not indicated that we enter the marked flow view.
Entering the marked flow view without any flows being marked causes the list to go empty. Pressing M again does not show the flows again.


update RBAC for PriorityClass

Signed-off-by: Alex Wang<EMAIL_ADDRESS>
What type of PR is this?
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #131
pr miss watch in this pr #128
Special notes for your reviewer:

/approve


Update DeveloperGuide.adoc

Update name of app
Update repoUrl
Update user profile
Removed undo/redo feature portion of implementation details
Removed old Appendix A
Update user stories

Pull Request Test Coverage Report for Build 24

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.811%

Totals

Change from base Build 23:
0.0%

Covered Lines:
1433

Relevant Lines:
1544

💛  - Coveralls


Fix a wrong command in the bots guide

run.py will only start a bot when it is located in zulip/contrib_bots/lib. In this document, lib was missing, so I fixed the path in the command and also added this as a common mistake in the "common problems" section

Automated message from Dropbox CLA bot
@derAnfaenger, it looks like you've already signed the Dropbox CLA. Thanks!


Text input broken for horizontal fields

Overview of the problem
Oruga version: [0.8.8]
Vuejs version: [3.3.11]
OS/Browser: Debian, Firefox 115 (and Chromium 124)
Description
The <o-input type="text"> is behaving badly when wrapped in <o-field horizontal> - makes the input textbox practically unusable.
You can focus the textbox, but then after pressing one key the focus blurs so you have to click the input again to press another key.
This quirk is new as of 0.8.8, so for now I'm using 0.8.7 which does not have the issue.
Steps to reproduce

Make a text input wrapped in horizontal field:
<o-field label="Stuff" horizontal>
  <o-input v-model="stuff" />
</o-field>

I believe that would show the behavior in any context.  But just in case, here is a complete example:
<!DOCTYPE html>

    <meta http-equiv="content-type" content="text/html; charset=UTF-8" />
    <title>hello world</title>

    <link rel="stylesheet" type="text/css" href="https://unpkg.com/<EMAIL_ADDRESS>

        NB. typing works normally unless field is horizontal

      <o-field>
        <o-checkbox v-model="horizontal">
          horizontal
        </o-checkbox>
      </o-field>

      <o-field label="Stuff (type in here)"
               :horizontal="horizontal">
        <o-input v-model="stuff"
                 expanded />
      </o-field>

      <o-button variant="primary">
        this button does nothing
      </o-button>

Expected behavior
Typing should be allowed as normal, for text input in horizontal field.
Actual behavior
Typing is very problematic as described above.
If I pass :horizontal="false" (or just omit it) to the field, then the input textbox behaves normally.  (But that would break my layout so I use 0.8.7 for now.)
Let me know if I can help further with this.

@lgedgar could you check if the o-field is now working as you would expect on the deployed preview in #915 ?

I'm not sure if this is related, but I've observed an issue with the field component. I've attached screenshots below to illustrate the problem. Although it wasn't a major issue—since I was able to fix it by using the expanded property—it was unexpected.
v0.8.7

v0.8.8

The code consists of OField wrapping OInput component, nothing special. Hopes this will be useful for someone.

@andrzejkupczyk I don't know how it happened,but it's more like it's supposed to be now :)

Apologies for slow reply here, but confirmed that 0.8.9 fixes - thanks!


fix(interaction): 修复多列头多指标场景下隐藏列头错误 close #1721

👀 PR includes

🐛 Bugfix

[x] Solve the issue and close #0

📝 Description

重构隐藏列头逻辑, 提升性能, 改为在 node 节点构建完成后对其进行隐藏判断
将 fieldValue 改为 节点id 比较, 修复多列头多指标同名场景下无法正确隐藏列头

[x] TODO: 单测

🖼 Screenshot

Before
After

🔗 Related issue link

close #1721
🔍 Self-Check before the merge

[ ] Add or update relevant docs.
[ ] Add or update relevant demos.
[ ] Add or update test case.
[ ] Add or update relevant TypeScript definitions.

把 demo 也完善一下？

把 demo 也完善一下？

已经有 demo 了

:tada: This PR is included in version @antv/s2-v1.34.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Using Vite to import the npm package @petercatai/assistant results in an error.

Describe the bug
Using Vite to import the npm package @petercatai/assistant results in an error.

UserController.js:4 Uncaught ReferenceError: process is not defined
at UserController.js:4:17
To Reproduce
The issue can be reproduced as mentioned.
Additional context
Currently, you can add a configuration similar to the one below to work around the issue.
export default defineConfig({
  plugins: [react()],
  define: {
    "process.env.NEXT_PUBLIC_API_DOMAIN": JSON.stringify(
      "https://your-api-domain.com"
    ),
  },
});

#479


Fix Andorra AD-08 holiday

Proposed change

Fix Andorra AD-08 holiday (Escaldes–Engordany Annual Festival falls on July 25-26), add missing test.
Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good: make pre-commit
[x] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
[x] The related documentation has been added/updated (check off the box for free if no updates is required)

Coverage: 99.709% (+0.03%) from 99.681% when pulling fab40e9eac349e15d77212b96366801cf7bde7a6 on KJhellico:fix-andorra into 3f23fbe53a709dd55fd966142d8d61e003707404 on dr-prodigy:beta.


RFE: wti pull --completed/--not-proof-read

I want to be able to pull translations but filter them out based on whether or not they have been proofread.
On my staging server I have a web hook configured, to refresh the app translations as soon as new ones appear. This helps with interactive preview and translation workflow.
On my prod server I'm not pulling translations automatically. Instead I pull the locally in my git repo and then deploy to production. I'd like to pull only confirmed translations, not ones which are still in progress.

@atodorov There are options to change how the files are generated in WebTranslateIt.com’s project settings:

This changes how your language files are generated. But unfortunately due to how WebTranslateIt.com is designed it isn't possible to download files with all translations for staging and at the same time download files with only proofread translations for production.
Another way to do it would be to use the String and Translation APIs to download your segments based on the statuses, but that is significantly slower than just downloading the files from WTI.
Hope this makes sense.

@edouard - thanks for explaining this. It does make sense however is suboptimal. I will take a look at the API sometime soon, but being able to apply these filters directly on the command line will be a huge boost for our project.


Added example images to "Generations"

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi, thank you for your PR but now we are no longer accepting links or other resources (images, etc.) which are not under our control, i.e. which a user or service might remove and is not under our control.
I'm closing this PR for the same reason as above, hope to see more contributions from you! ✈


[Update Request]: Microsoft PowerBI Desktop

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
Microsoft.PowerBI
Package Version
2.122.746.0
Please describe the changes you would like to see
There is a new release available with version: 2.122.746.0
Download Link: https://www.microsoft.com/en-us/download/details.aspx?id=58494

Close with reason: Resolved in #122598;


[WIP][API] Add data type functions

Description
can_cast, finfo, iinfo, type_result

can_cast fall back to official numpy
type_result is removed from fallback.py since we will have our own type promotion rules.
finfo, iinfo will follow the data-api-standard design.

Checklist
Essentials

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

merged into #20725


Connections hanging when using L4LB server with Kubernetes NodePort

Summary: when using in-front Kubernetes L4LB proxy (IPVS-DR or HaProxy), and pointing to Kubernetes Workers Nodeport endpoints all connections are hanging.

Cilium version 1.9.1
Kernel version Linux 5.4.12
Orchestration system version in use Kubernetes v1.19.6

Install and configure L4LB (IPVS using DR) on server outside of Kubernetes cluster
Install Kubernetes Cluster with Cilium
Deploy PodInfo for the test, and use nodeport 32000 service
Check with curl if Nodeport is reachable directly from Kubernetes cluster and trough L4LB (IPVS-DR) server

Cilium Helm command line:
helm -f values.yaml install cilium cilium/cilium --version 1.9.1 --namespace kube-system \
	--set kubeProxyReplacement=strict \
	--set k8sServiceHost=<IP_ADDRESS> \
	--set k8sServicePort=6443 \
	--set devices='{em1,em2,dummy0,dummy1,dummy2,dummy3}' \
	--set loadBalancer.mode=dsr \
	--set tunnel=disabled \
	--set autoDirectNodeRoutes=true

Cillium values.yaml file:
nativeRoutingCIDR: <IP_ADDRESS>/15
ipam:
  mode: "kubernetes"

L4LB (IPVS-DR) and Kubernetes workers have:
em1 - public IP interface, with default route to router
em2 - private IP interface
dummy[0..3] - additional IPs used for Direct Routing
There is no firewall on the servers, and all servers have default gateway set to x.y.z.1 via em1 (default via x.y.z.1 dev em1 proto static metric 100).
All Kubernetes workers have following sysctl setup:
net.ipv4.conf.all.arp_ignore = 1
net.ipv4.conf.all.arp_announce = 2
net.ipv4.conf.all.rp_filter = 0

Cilium status:
KVStore:                Ok   Disabled
Kubernetes:             Ok   1.19 (v1.19.6) [linux/amd64]
Kubernetes APIs:        ["cilium/v2::CiliumClusterwideNetworkPolicy", "cilium/v2::CiliumEndpoint", "cilium/v2::CiliumNetworkPolicy", "cilium/v2::CiliumNode", "core/v1::Namespace", "core/v1::Node", "core/v1::Pods", "core/v1::Service", "discovery/v1beta1::EndpointSlice", "networking.k8s.io/v1::NetworkPolicy"]
KubeProxyReplacement:   Strict   [dummy1, dummy2, dummy3, em1, em2 (Direct Routing), dummy0]
Cilium:                 Ok       OK
Cilium health daemon:   Ok
IPAM:                   IPv4: 36/255 allocated from <IP_ADDRESS>/24,
BandwidthManager:       Disabled
Host Routing:           Legacy
Masquerading:           BPF   [dummy1, dummy2, dummy3, em1, em2, dummy0]   <IP_ADDRESS>/15
Controller Status:      153/153 healthy
Proxy Status:           OK, ip <IP_ADDRESS>, 0 redirects active on ports 10000-20000
Hubble:                 Ok              Current/Max Flows: 4096/4096 (100.00%), Flows/s: 64.07   Metrics: Disabled
Cluster health:         4/4 reachable   (2021-01-09T19:16:55Z)
KubeProxyReplacement Details:
  Status:              Strict
  Protocols:           TCP, UDP
  Devices:             dummy1, dummy2, dummy3, em1, em2 (Direct Routing), dummy0
  Mode:                DSR
  Backend Selection:   Random
  Session Affinity:    Enabled
  XDP Acceleration:    Disabled
  Services:
  - ClusterIP:      Enabled
  - NodePort:       Enabled (Range: 30000-32767)
  - LoadBalancer:   Enabled
  - externalIPs:    Enabled
  - HostPort:       Enabled

Check that Cilium got IP from dummy interface and that it LB properly:
7    x.y.z.235:32000    NodePort       1 => <IP_ADDRESS>:9898
                                          2 => <IP_ADDRESS>:9898
                                          3 => <IP_ADDRESS>:9898
                                          4 => <IP_ADDRESS>:9898
                                          5 => <IP_ADDRESS>:9898
                                          6 => <IP_ADDRESS>:9898
                                          7 => <IP_ADDRESS>:9898
[...]

Check from Kubernetes worker connection to same public IP (on dummy interface):
$ curl x.y.z.235:32000
{
  "hostname": "demo4-7b9d848568-vqz6x",
  "version": "4.0.6",
[...]

Check from outside of the Kubernetes cluster to workers public IP:32000 (on em1 interface):
$ curl x.y.z.51:32000
{
  "hostname": "demo4-7b9d848568-xmmlr",
  "version": "4.0.6",
  "revision": "26a630c0b4b3452833d96c511d93f6f2d2e90a99",
[...]

Check from L4LB server to Kubernetes workers private IP:32000 (on em2 interface):
$ curl <IP_ADDRESS>:32000
{
  "hostname": "demo4-7b9d848568-xmmlr",
  "version": "4.0.6",
  "revision": "26a630c0b4b3452833d96c511d93f6f2d2e90a99",
[...]

L4LB server is configured with LVS-DR to point to one Kubernetes node:
TCP  x.y.47.235:32000 rr
  -> <IP_ADDRESS>:32000          Route   1      0          0

When issuing connection test to x.y.z.235:32000 connection hangs:
$ curl x.y.z.235:32000
[hanging]

$ telnet x.y.z.235 32000
Trying x.y.z.235...

Here is the tcpdump on L4LB fist public (em1) interface, then private (em2) interface:
em1 (public interface):
<IP_ADDRESS>.50420 > x.y.z.235.32000: Flags [S], seq<PHONE_NUMBER>, win 64240, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr 0,nop,wscale 7], length 0

em2 (private interface):
<IP_ADDRESS>.50436 > x.y.z.235.32000: Flags [S], seq 170496865, win 64240, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr 0,nop,wscale 7], length 0
x.y.z.235.32000 > <IP_ADDRESS>.50436: Flags [S.], seq<PHONE_NUMBER>, ack 170496866, win 65535, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr<PHONE_NUMBER>,nop,wscale 12], length 0

at same time tcpdump on Kubernetes worker (<IP_ADDRESS>):
em1 (public interface):
nothing

em2 (private interface):
<IP_ADDRESS>.50470 > x.y.z.235.32000: Flags [S], seq<PHONE_NUMBER>, win 64240, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr 0,nop,wscale 7], length 0
**x.y.z.235.32000 > <IP_ADDRESS>.50470: Flags [S.], seq<PHONE_NUMBER>, ack<PHONE_NUMBER>, win 65535, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr<PHONE_NUMBER>,nop,wscale 12], length 0**

It seems that DSR response from Kubernetes worker is getting lost on em2 (private interface), instead to go via default route which is on em1 (public interface).

The dummy device hack should work only when accessing a service from the host which has those devices. It's not expected to work when accessed from outside.
Re DSR: check whether your underlying network does not drop requests with IPv4 options. From the tcpdump on the worker node I don't see any request to the service endpoint.

The dummy device hack should work only when accessing a service from the host which has those devices. It's not expected to work when accessed from outside.
Re DSR: check whether your underlying network does not drop requests with IPv4 options. From the tcpdump on the worker node I don't see any request to the service endpoint.

Let me describe more and copy paste tcpdump happenin on Kubernetes worker node:
<IP_ADDRESS> - Client IP
x.y.z.235 - IP attached to dummy interface on Kubernetes worker, and anycasted on lo interface at L4LB (LVS-DR)
When initiating connection from Client IP to x.y.z.235:32000 no packets arrives or goes out via Kubernetes workers em1 (public interface).
Request arrives on Kubernetes Worker node (<IP_ADDRESS>.50470 > x.y.z.235.32000) via em2 (private interface), which is okay as LVS is in DR mode.
But response from Kubernetes Worker goes via em2 and thus client never get any response (x.y.z.235.32000 > <IP_ADDRESS>.50470).
If response can go via em1, where is default gateway, it should work.
em1 (public interface):
no requests

em2 (private interface):

<IP_ADDRESS>.50470 > x.y.z.235.32000: Flags [S], seq<PHONE_NUMBER>, win 64240, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr 0,nop,wscale 7], length 0
x.y.z.235.32000 > <IP_ADDRESS>.50470: Flags [S.], seq<PHONE_NUMBER>, ack<PHONE_NUMBER>, win 65535, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr<PHONE_NUMBER>,nop,wscale 12], length 0

My use case is to utilize in front L4LBs with Anycasted public IPs + LVS-DR load balance traffic directly to Kubernetes Nodeport using Cilium and kube-proxy-replacement + eBPF/DSR. Hopefully there is solution as this should be quite common approach for on-premises traffic balancing.

Let me describe more and copy paste tcpdump happenin on Kubernetes worker node:
<IP_ADDRESS> - Client IP
x.y.z.235 - IP attached to dummy interface on Kubernetes worker, and anycasted on lo interface at L4LB (LVS-DR)
When initiating connection from Client IP to x.y.z.235:32000 no packets arrives or goes out via Kubernetes workers em1 (public interface).
Request arrives on Kubernetes Worker node (<IP_ADDRESS>.50470 > x.y.z.235.32000) via em2 (private interface), which is okay as LVS is in DR mode.
But response from Kubernetes Worker goes via em2 and thus client never get any response (x.y.z.235.32000 > <IP_ADDRESS>.50470).
If response can go via em1, where is default gateway, it should work.
em1 (public interface):
no requests

em2 (private interface):

<IP_ADDRESS>.50470 > x.y.z.235.32000: Flags [S], seq<PHONE_NUMBER>, win 64240, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr 0,nop,wscale 7], length 0
x.y.z.235.32000 > <IP_ADDRESS>.50470: Flags [S.], seq<PHONE_NUMBER>, ack<PHONE_NUMBER>, win 65535, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr<PHONE_NUMBER>,nop,wscale 12], length 0

My use case is to utilize in front L4LBs with Anycasted public IPs + LVS-DR load balance traffic directly to Kubernetes Nodeport using Cilium and kube-proxy-replacement + eBPF/DSR. Hopefully there is solution as this should be quite common approach for on-premises traffic balancing.

@linecolumn  @borkmann   hello ， there are on more question about K8sServiceHost . If kuberetes is Ha cluster. not a single master node,
what exactly for K8sServiceHost?   Ha control-palne  address like LB_HOST  or just  one of master Host address.

@linecolumn  @borkmann   hello ， there are on more question about K8sServiceHost . If kuberetes is Ha cluster. not a single master node,
what exactly for K8sServiceHost?   Ha control-palne  address like LB_HOST  or just  one of master Host address.

@oldthreefeng HA control-plane LB address. Next time please ask such questions in a separate GH issue or on Cilium's slack, as it is unrelated to the current issue.


Themes doesnt work when you try to install them

I try to install few themes and none of them work. It get installed successfully but when I try to preview I get errors:  Object reference not set to an instance of an object.

Could you post a full log entry from when this happens?


Use ansible_local for Windows compatibility

Why
Because Windows users have the right to use this awesome project too 😛
Bonus
You won't need to touch the Vagrantfile anymore, every configurable values are now in ansible/vagrant-parameters.yml.dist.
Thanks
Many thanks to @raphael-trzpit for #1, it helped me a lot ❤
Enjoy 😎

This will be tag as v2.0.0


Theme isn't applied when publishing statically

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Apply a custom theme, with a dark base
Run build-storybook
Open storybook-static/index.html in the browser
See that the theme is not applied

Expected behavior
Theme to be maintained
System:

OS: [e.g. iOS, Windows10, MacOS] MacOS 10.14.4 (18E226)
Device: [e.g. iPhoneX, Macbook Pro 2018]  MacBook Pro (15-inch, 2017)
Browser: [e.g. chrome, safari] Firefox 67.0b14 (64-bit)
Framework: [e.g. react, vue, angular] React v16.8.6
Addons: [if relevant]
Version: [e.g. 4.0.0] 5.0.9

Server running:

Static build:

There's some trickiness with how themes are applied in the web UI (cached in localstorage). My guess is that this trickiness broke the static build.
@kevinSuttle what app are those screenshots from?

Firefox. I’ve noticed a lot of sync latency, colors not even being applied, etc.
I wonder if it has to do with this, which I’m doing:

When setting a theme, set a full theme object. The theme is replaced not combined.

However, I’ve seen it work. So, this may be on me. :)

I noticed the `` environment variable could be used at build time, but alas, the theme still is not applied when statically exporting.

@kevinSuttle Is this is still causing you problems?

As of beta 18 (maybe earlier), it is not! Thanks for the reminder!


Failed logins can cause exception loop

This is to partly address https://github.com/fastlane/fastlane/issues/10419

@fastlane-bot I would very much like to see a release with this fix asap, since it is currently preventing us from moving one of our clients onto fastlane.


[Logic] az logic integration-account: Add new command group assembly to support managing assembly

az logic integration-account: Add new command group assembly to support managing assembly
az logic integration-account: Add new command group batch-configuration to support managing batch configuration
az logic integration-account: Add new command group partner to support managing partner
az logic integration-account: Add new command group session to support managing session
az logic integration-account: Add new command list-callback-url to support listing callback url
az logic integration-account workflow: Add new command generate-upgraded-definition to support generating upgraded definition

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[ ] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Logic