i18n: Update translations for Ukrainian and Russian language (uk-UK; ru-Ru)

The translation of the line 89: saveWindowPlacement for 323, also added a translation for  missing_translations, which for some reason didn't save last time.

The @@info and other @ strings should not be translated as they are comments and not used in the app. @@info in particular, is generated by the tool.

The @@info and other @ strings should not be translated as they are comments and not used in the app. @@info in particular, is generated by the tool.

Well, the @@info line, I didn't translate. At the initial stage, when I first translated, I translated the line @:general.error, but then I realized that it was some kind of markup for comments and returned it as it was.


Tools instead funtions

OpenAI API has deprecated functions in favor of tools.
I did not added tool_choice argument described here
this argument can force the model to use a specific function, but I do not If we need it

The examples from Tutorial folder work correctly


sudo npm install -g ionic errors

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

$ sudo npm install -g ionic
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>use uuid module instead
npm WARN deprecated<EMAIL_ADDRESS>use uuid module instead
/usr/local/lib
└── (empty)

npm WARN In<EMAIL_ADDRESS>replacing bundled version of cross-spawn with<EMAIL_ADDRESS>npm WARN In<EMAIL_ADDRESS>replacing bundled version of semver with<EMAIL_ADDRESS>npm WARN In<EMAIL_ADDRESS>replacing bundled version of mime-types with<EMAIL_ADDRESS>npm WARN In<EMAIL_ADDRESS>replacing bundled version of form-data with<EMAIL_ADDRESS>npm WARN In<EMAIL_ADDRESS>replacing bundled version of request with<EMAIL_ADDRESS>npm WARN In<EMAIL_ADDRESS>replacing bundled version of ionic-app-lib with<EMAIL_ADDRESS>npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/Cellar/node/7.1.0/bin/node" "/usr/local/bin/npm" "install" "-g" "ionic"
npm ERR! node v7.1.0
npm ERR! npm  v3.10.9
npm ERR! path /usr/local/lib/node_modules/.staging/ansi-392b32ed
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename

npm ERR! enoent ENOENT: no such file or directory, rename '/usr/local/lib/node_modules/.staging/ansi-392b32ed' -> '/usr/local/lib/node_modules/ionic/node_modules/cordova-lib/node_modules/ansi'
npm ERR! enoent ENOENT: no such file or directory, rename '/usr/local/lib/node_modules/.staging/ansi-392b32ed' -> '/usr/local/lib/node_modules/ionic/node_modules/cordova-lib/node_modules/ansi'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/Jackson/Sites/ratl/npm-debug.log
npm ERR! code 1
lapfeet:ratl Jackson$ ionic
-bash: ionic: command not found

Expected behavior:

clean install
Steps to reproduce:

Related code:
sudo npm install -g ionic

Other information:

Everything was working before trying to update, including ionic. Also, I didn't want to run this as sudo but I kept getting permission denied errors.
I'm finding out that there is no "/usr/local/lib/node_modules/.staging" folder
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
N/A

This resolved with
$  sudo chmod -R 777 /usr/local/lib
$  brew postinstall node

Same error here on windows 10.
npm ERR! enoent ENOENT: no such file or directory, rename 'C:\Users\Sierran\AppData\Roaming\npm\node_modules\.staging\ansi-cf228dbe' -> 'C:\Users\Sierran\AppData\Roaming\npm\node_modules\ionic\node_modules\cordova-lib\node_modules\ansi'
npm ERR! enoent ENOENT: no such file or directory, rename 'C:\Users\Sierran\AppData\Roaming\npm\node_modules\.staging\ansi-cf228dbe' -> 'C:\Users\Sierran\AppData\Roaming\npm\node_modules\ionic\node_modules\cordova-lib\node_modules\ansi'

node -v
v6.9.1

npm -v
3.10.8

@sierran It appears to be a permissions issue. I'm not sure how to redo the permissions for windows 10 but I suggest taking C:\Users\Sierran\AppData\Roaming\npm and making it and all subdirectories writeable by all users.

@jacksonkr i just deleted ionic from %appdata% and reinstall it. Now work perfectly ;)

I updated node and npm. Then I installed cordova (using npm). After that, I used what @jacksonkr suggested:
$  sudo chmod -R 777 /usr/local/lib $  brew postinstall node


(maint) Enable sudo again to allow workaround for java bug

The bug described here: https://github.com/travis-ci/travis-ci/issues/5227
... and its work-around requires sudo, so we need to remove the sudo:false setting
for this to work. This is temporary until the bug is fixed upstream.
Signed-off-by: Ken Barber<EMAIL_ADDRESS>

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/347/
Test PASSed.


Consumybili - No Audio and Subtitles

Source information and language
Consumybili 13.1
Steps to reproduce
Audio and Subtitle are missing
Expected behavior
Should play Video normally with audio and subtitle
Actual behavior
Video is streaming without Audio and subtitle
Aniyomi version
<IP_ADDRESS>
Android version
11
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.13.5.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Use the latest beta if you want audio and subtitles to work correctly

Closed as the extension has been removed.


User Stories: UI

[ ] As a server admin, I want a restful interface for most operations

Views we might need in this application:

sign up page :
display a sign up form

my_stream :
display user's own past posts and user himself is able to delete/manage it

all_stream/homepage:
user is able to see all available posts as well as comment and search them.
Also able to (un)follow(sent friend request) local/remote authors.
User can also send posts on this page.
(type: img_link(access protected), text, markdown, github, twitter etc.)
(privilege: to me, to another author, to friends, to friends of friends, only to friends on my node, public )

firend_request_manage:
user is able to reply friend request sent to him

following stream:
user is able to see all public posts from local/remote authors he followed or friended
able to comment/unfollow them.

my_profile:
user is able to edit his own profile

admin_homepage:
admin is able to add/remove/edit users.
able to see all the users in this node.
able to see all the authors' friends.
able to manage the signup waiting list.
able to auth and connect/disconnect to other nodes. (posts/images)

user_profile:
all registered users are able to see/comment one's public posts on one's homepage.
admins are able to see all of one's posts on one's homepage.

my_friends:
user is able to delete/manage his own friends on this page.


Update library with security vulnerabilities

I ran npm audit fix --force to update the library with security vulnerabilities.
$ npm audit report

# npm audit report

path-parse  <1.0.7
Severity: moderate
Regular Expression Denial of Service in path-parse - https://npmjs.com/advisories/1773
fix available via `npm audit fix`
node_modules/path-parse

ssri  5.2.2 - 6.0.1 || 7.0.0 - 7.1.0 || 8.0.0
Severity: moderate
Regular Expression Denial of Service - https://npmjs.com/advisories/565
fix available via `npm audit fix`
node_modules/ssri
  npm-registry-client  >=8.5.1
  Depends on vulnerable versions of ssri
  node_modules/npm-registry-client

tar  <=4.4.17 || 5.0.0 - 5.0.9 || 6.0.0 - 6.1.8
Severity: high
Arbitrary File Creation/Overwrite due to insufficient absolute path sanitization - https://npmjs.com/advisories/1770
Arbitrary File Creation/Overwrite via insufficient symlink protection due to directory cache poisoning - https://npmjs.com/advisories/1771
Arbitrary File Creation/Overwrite via insufficient symlink protection due to directory cache poisoning using symbolic links - https://npmjs.com/advisories/1779
Arbitrary File Creation/Overwrite via insufficient symlink protection due to directory cache poisoning using symbolic links - https://npmjs.com/advisories/1780
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/@definitelytyped/utils/node_modules/tar
node_modules/node-pre-gyp/node_modules/tar
node_modules/tar
  @definitelytyped/utils  >=0.0.23-next.0
  Depends on vulnerable versions of tar
  node_modules/@definitelytyped/utils
    dtslint  >=3.5.0
    Depends on vulnerable versions of @definitelytyped/utils
    node_modules/dtslint

6 vulnerabilities (3 moderate, 3 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

As a result of downgrading dtslint, the dtslint check now detects a large number of errors, even though we have explicitly written "export".
Error: /pulsar-client-node/index.d.ts:21:18
ERROR: 21:18   strict-export-declare-modifiers  All declarations in this module are exported automatically. Prefer to explicitly write 'export' for clarity. If you have a good reason not to export this declaration, add 'export {}' to the module to shut off automatic exporting. See: https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
ERROR: 36:14   strict-export-declare-modifiers  All declarations in this module are exported automatically. Prefer to explicitly write 'export' for clarity. If you have a good reason not to export this declaration, add 'export {}' to the module to shut off automatic exporting. See: https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
ERROR: 44:18   strict-export-declare-modifiers  All declarations in this module are exported automatically. Prefer to explicitly write 'export' for clarity. If you have a good reason not to export this declaration, add 'export {}' to the module to shut off automatic exporting. See: https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
ERROR: 64:14   strict-export-declare-modifiers  All declarations in this module are exported automatically. Prefer to explicitly write 'export' for clarity. If you have a good reason not to export this declaration, add 'export {}' to the module to shut off automatic exporting. See: https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
ERROR: 73:18   strict-export-declare-modifiers  All declarations in this module are exported automatically. Prefer to explicitly write 'export' for clarity. If you have a good reason not to export this declaration, add 'export {}' to the module to shut off automatic exporting. See: https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
...

This time I want to give priority to passing the build, so skip this check: https://github.com/apache/pulsar-client-node/pull/172/commits/51e00a742a98496610518eed13a10569f41db11d


[Docs] Fix typos in differentiable programming manifesto.

Fix Sequential function builder usage.
Fix grammatical error.
powerful machine learning -> expressive machine learning

Thanks @burmako for the feedback!

@swift-ci Please smoke test and merge


Very Specific test Case for gender

of this cancel-era, we can include in the UG that non-binary should be written as nonbinary in case user cancel our app

Agree.

Add to To-Note section for UG

Merged into #298


Fixed typo on front page

Added missing word:

in these industries, including easily interoperable with other languages and tool chains.

to

in these industries, including being easily interoperable with other languages and tool chains.

Thank you for your contribution!


Remove custom CodeMapper types

Now that the protocol packages have mapper types, this moves to use those instead of having our own definition.

Looks like we got some new analyzers hiding in the gift wrapping :)

Looks like we have some obsolete types that don't have a replacement yet either. Checking with the VS team... I expect this to still fail. I did fix the analyzer warnings though

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9083082&view=results for integration test run


Request for Optional Setting to Not Encrypt exturl (targetUrl) in Exitscript

I am writing to bring attention to an important breaking change that occurred with the release of CDTS v5.0.0. In this version, Exitscript no longer contains an unencrypted targetUrl/exturl as part of the query string to pass the destination link. This change has significantly impacted our application, which serves as a framework used by multiple other web applications.
Our application relies on the exturl/targetUrl to perform several functions. When an external link is clicked, our application performs some session cleanup and then notifies the calling system that an external link has been detected. This gives the application using our system the opportunity to decide what to do with that external link.
However, since URLs are now encrypted on the client side, we no longer have the ability to perform these functions. This has been a significant breaking change for our system.
We understand that this change was made to prevent misuse of the targetUrl in regards to open-redirect attacks. However, our system was not susceptible to this as we do not openly redirect without input from the user.
We kindly request the addition of an optional setting to the Exitscript that would allow us not to encrypt the targetUrl. This would greatly help us in maintaining the functionality of our application and the systems that rely on it.
Thank you for your attention to this matter.

Hello, we don't have control on the way the link is passed. CDTS leverages the WET exitscript (https://wet-boew.github.io/wet-boew/demos/exitscript/exitscript-en.html) and WET encrypts the URLs now. We cannot go back to the previous behaviour of the exitscript.
You can perform functions through a middle (redirected) page and retrieve the URL. Take a look at the examples on our sample page: https://cdts.service.canada.ca/app/cls/WET/gcweb/v5_0_0/cdts/samples/exitscript-redirect-en.html


App returns to root URL on page refresh

Same issue present in my open-ai-image-gen repo. Looks like it has to do with the React Router and indexing of path's. Most solutions I've come across seem extremely verbose and don't seem to address the logic behind why this occurs.  Good opportunity to do some digging on the browser's behavior and also comparing how Nextjs handles this issue.
Thoughts:

Is React Router essentially mimicking a multipage application leading to routes defaulting to their "parent" URL
Can checking token storage locally instead of server side provide a checkpoint to not collapse back to "parent" only to be redirected back to previous location
Is this a use case for useHistory or useLocation?

Currently being remedied by splitting the <Routes> into two different sections based on user value. Not a fix, but alleviates some of the pain during development.

Patch is working to keep user logged in on refresh and holding the current page, but when logging out from a page that does not have the path of '/', the user if held on a blank screen.

Routing has been working as intended, however the remaining issue is the need for a smooth routing experience on initial log in. Upon signing in, if a user has completed the onboarding steps, you'll still catch a fraction of a second glimpse of those screens before ending up on the home page.
All in all the navigation experience just needs to be a bit cleaner.


remove close file due to duplicity once extract already close it

Description
Remove code to close file once extractor already close the file and when we try to close it again it's failing
Fixes # (THEEDGE-1571)
Type of change
What is it?

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[X] I run go fmt ./... to check that my code is properly formatted
[X] I run go vet ./... to check that my code is free of common Go style mistakes

Codecov Report

Merging #563 (6815467) into main (a96e24e) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
+ Coverage   29.26%   29.28%   +0.02%
==========================================
  Files          33       33
  Lines        3513     3510       -3
==========================================
  Hits         1028     1028
+ Misses       2342     2339       -3
  Partials      143      143

Impacted Files
Coverage Δ

pkg/services/repobuilder.go
2.36% <ø> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a96e24e...6815467. Read the comment docs.


MWPW-130835 search osi in OST

Add your
Specific
Features or fixes

Resolves: MWPW-130835
Test URLs:

Before: https://main--milo--adobecom.hlx.page/tools/ost?milolibs=local#?martech=off
After: https://MWPW-130835--milo--adobecom.hlx.page/tools/ost?martech=off

I see there's a unit test error in test/blocks/caas-config/caas-config.test.html. It doesn't sound like these are related, but it might be better to check before merging.

Updating the branch to the latest state fixed the unit test failure, might have been a temporary issue. All green now.
@VKniaz : please remember adding a description to the PR, regardless how trivial the change might be :)


Password is gibberish when opening file last saved by KeeWeb

I use KeeWeb on my computer to handle passwords. However, in the android app, if I open that database, the password is displayed as gibberish. If I open the same database in any other app, it works fine. If I open it elsewhere and save it, then open it via this API, it opens fine.
Database last saved by keeweb attached. Remove the .txt extension (Master password is github)
GithubIssue.kdbx.txt
Keeweb: https://keeweb.info/

Tried with KeeWeb and worked fine. I've used the following process:

Tried to open with OpenKeepass
Opened with KeeWeb, changed password and closed KeeWeb
Tried to open with OpenKeepass again --> worked fine and new password is also visible

Did you follow another another process? What does "password is gibberish" mean?

Sorry, should have been more clear.
The issue is the password field of any entry, not the overall database's password. So I can create an entry called "GitHub account", with username "user" and password "password" in keeweb, but if I try and open it in openkeepass, it shows random ASCII/Unicode characters.

Yes, I know it's about the entries password, but I'm still unable to reproduce the issue. If I create a new entry using keeweb and then opening it in openkeepass it still works fine.

On which system are you using this process, do you have any Android involved into this?
The attached GithubIssue.kdbx does it contain the "gibberish" password?

I'm using Ubuntu 16.04 with keeweb and Android marshmallow on my Galaxy S5.
Yes, that file has the issue.
On Aug 27, 2017 10:44 PM, cternes<EMAIL_ADDRESS>wrote:
Yes, I know it's about the entries password, but I'm still unable to reproduce the issue. If I create a new entry using keeweb and then opening it in openkeepass it still works fine.
On which system are you using this process, do you have any Android involved into this?The attached GithubIssue.kdbx does it contain the "gibberish" password?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Ok, and the issue occurs only on Android, right? Have you written your own app to open the keepass file there?

Yes to both questions.
On Aug 27, 2017 11:21 PM, cternes<EMAIL_ADDRESS>wrote:
Ok, and the issue occurs only on Android, right? Have you written your own app to open the keepass file there?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Mhh, tried with Android emulator and the keepass file from above, works fine for me. I guess you're using the latest version 0.6.1, right?
Any more hints like Android version or something?


feat(#175): Simplify ImprovementDistilledObjects

It is refactoring related to ImprovementDistilledObjects.
That PR isn't directly addresses the #175 issue, but it is part of it.
Actually we have one more puzzle for refactoring of ImprovementDistilledObjects, so we can close this one.
Closes: #175.

History:

feat(#175): simplify targetNew method
feat(#175): simplify xml nodes creatation
feat(#175): simplify xml nodes creatation
feat(#175): remove redundant code
feat(#175): set text content for XmlNode
feat(#175): rename methods
feat(#175): remove the puzzle for 175 issue
feat(#175): fix all qulice suggestions

PR-Codex overview
Detailed summary

Added children() method to XmlNode class to retrieve all child nodes.
Added text() method to XmlNode class to retrieve node text content.
Added withText() method to XmlNode class to set node text content.
Added replaceArguementsValues() method to XmlInstruction class to replace argument values.
Refactored replaceArguments() method in ImprovementDistilledObjects class to handle arguments correctly during inlining optimization.

The following files were skipped due to too many changes: src/main/java/org/eolang/jeo/improvement/ImprovementDistilledObjects.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 3min)


Gather a list of tags that apply for each component

This list of tags will be used to filter docs on the doc site. Think about this from the user behavior flow to help users get a customized set of docs. Will post an example here.

Close because it's resolved. Thanks


Compilation errors with 2.0.0

Hi,
After i upgraded CocoaLumberjack getting errors in following method, i think this class not updated to latest properties where these have to be replaced.

(NSString *)formatLogMessage:(DDLogMessage *)logMessage
{
return [NSString stringWithFormat:@"%@ | %@ | %s @ %i | %@",
[self stringFromDate:(logMessage->timestamp)], [logMessage fileName], logMessage->function, logMessage->lineNumber, logMessage->logMsg];
}

Also getting error on tag property, like it's redeclared

Regarding the tag warnings, I think they are more commonly seen with "older" style Cocoa conventions. There are a couple of solutions, both of which worked for my application. They give the compiler a hint about which method will actually be called on a generic class.  E.g.,
replace
- (IBAction) doSomething: (id) sender
with
- (IBAction) doSomething: (NSPopUpButton*) sender
or
if ([sender respondsToSelector: @selector(tag)])
	{
	NSMenuItem *menuItem=sender;
	[someController doSomething: [menuItem tag]];
	}

See http://stackoverflow.com/a/8818052/3342547 and others for details.
--DDP

Also if you could share a demo project that reproduces the error it would help a lot.

Any updated here?


Builders let anti-nuke ramparts decay after nuke lands

I've seen the way you defend the base,but I have to say,it's not the most efficient because of all the walls,i know they are easier to maintain than ramparts but walls don't allow creeps to be in them,so defenses aren't going to be that effective,meaning you can only use ranged defenders,also enemy creeps can position themselves in front of the ramparts so your creeps can't get out,i suggest making all the walls into ramparts so that allows for more defensive options and overall more travel options when it comes to creep movement.

+1

+1?:)

The problem with ramparts is that they cost energy to maintain. Walls take energy to build up once, but they don't fall down, so they are a sunk cost. If anybody attacks us and our ranged defenders (in the works) combined with towers can't hold them off, we simply can't keep the room. We are better taking the economic hit of losing some rooms due to this minor defensive flaw than taking the economic hit of permanently maintaining ramparts across the empire.

circling back to this, bases now spawn boosted ranged attackers that stay in the base and defend, 3 of these together are able to defeat a trio (2 healers 1 breaker), untested against quads bc we aren’t attacked by quads. cost of a lost base is massive (2 cpu * 3 weeks to replace) but we haven’t lost a base. question is, what is the cost of maintaining ramparts?

~50 ramparts per room, decaying at 300 hits per 100 ticks each. Thats 3000 hits per 1k ticks or 2 intents per 1k ticks for our current builder. multiplied by 50 ramparts, we get 100 intents or 20 cpu per 1k ticks per room. With 14 rooms atm, that translates to 280 cpu per 1k ticks or .28 cpu per tick.

ofc the above calc did not take into account the cpu cost of motion for the builder, as well as energy costs for both the builder and the repair ops. That should all be comparatively little though. I would say 0.28 is certainly not acceptable, especially since it will only rise over the course of our expansion. 0.28 cpu can run a 4 creep military operation with 15 - 20% uptime, which we would probably never achieve (uptime-wise), and would be necessary to remove any enemy that is strong enough to threaten us.

In the spirit of getting something useful out of this issue, I would say that this has highlighted the importance of only maintaining ramparts that are absolutely necessary.
This means that builders will have to be able to ignore ramparts that were created for nuke defense, but are no longer needed.

builders can judge whether a rampart is a 'nuke rampart' vs regular by looking at the structure underneath. If the structure underneath is a core structure (or maybe we'll provide a list of valid structures in settings), the rampart should only be maintained up to the value of the total damage to be dealt by all incoming nukes.

I think the other big part of this is autoplacement of rampart construction sites when a nuke is launched


Delay reconnect attempts if the server returned an error

This should fix high CPU usage issue when API key is invalid
Fixes #46

Thanks @virusman !


Add testnet support for Ledger device

Description
Currently Ledger accounts only encode addresses for the Shimmer mainnet HRP, despite being connected to a testnet. It would be nice to have testnet HRP support on Ledger devices, but that requires also changing the coin_type parameter in the BIP32 path.
It seems that testnet BIP paths typically use 0x1 in the BIP path rather than the actual coin_type as to prevent replay attacks with testnet transactions.
# Shimmer mainnet BIP32 path
2c'/107b'/...

# Shimmer testnet BIP32 path
2c'/1'/...

Motivation
Not technically necessary, but it would be nice to have matching addresses displayed both in Firefly confirmation popups and the Ledger device prompt rather than a testnet address in Firefly and a mainnet address on the device.
Requirements
Write a list of what you want this feature to do.

Deduce from the client options whether the account manager is a dev one or not
Display testnet addresses if "dev" account manager and mainnet addresses if normal account manager

Open questions (optional)
N/a
Are you planning to do it yourself in a pull request?
No.

The bech32 HRP is hardcoded in the ledger app for security reasons, we can't change it without a change in https://github.com/iotaledger/ledger-shimmer-app (which will most likely not happen, but feel free to open an issue there)


Don't abort entire brew cask upgrade if one cask fails

Right now, if you run brew cask upgrade and one of your casks fails (e.g., the depends_on macos stanza), two things happen:

You get the correct message (e.g. Error: Cask cask_name depends on macOS release..., Error: Checksum for Cask 'superduper' does not match, Error: Download failed on Cask cask_name..., etc.)
brew cask upgrade stops

brew cask thus won't ever upgrade any casks coming alphabetically after the failing cask.  While most issues should be fixable, if there is a macOS dependency issue, there's nothing to "fix" outside of updating to the latest macOS: a cask depending on mojave will obstruct high_sierra users, despite homebrew-cask officially supporting the two latest macOS point releases.
One workaround is to manually parse out each cask by piping brew cask outdated through grep -v and then into brew cask upgrade; this should work but is repetitive and obviously not ideal or easily scalable.  Another is to remove the relevant files from the caskroom and stop using brew-cask for the application(s) in question; likewise, this isn't ideal.
Expected behavior would be for installer to raise the error as appropriate but for upgrade to rescue and continue with any remaining casks.  This would match what brew does after #3644 and I believe is essentially what @ilovezfs suggested should be the default behavior in https://github.com/Homebrew/brew/issues/3634#issuecomment-356304225.

No objections from me.

Stale bot, keep this open!

keep it open!

keep it open!

If you are interested in adding this feature, feel free to submit it as a pull request and a maintainer will review it. Even a partial implementation is fine since we can help you work through the rest of it. "Upvoting" an issue doesn't help since no maintainer is currently working on this feature.

I did a bit of digging, but don't have time right now to finish a fix. Adding code pointers to any others who are open to picking this up.

cask upgrade code: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/cask/cmd/upgrade.rb
Interception point: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/cask/cmd/upgrade.rb#L94

General thoughts:

IMO best option would be to collect various errors rather than immediately throwing them up to the caller. This will allow the cask upgrade to finish, and the notify the user of any problems.
Caveats to the above are where casks depend on each other and the dependency is broken, since then it would be ideal to intelligently abort the attempted upgrade only for the child casks.

Hope this helps other fellow hackers.

https://github.com/Homebrew/brew/pull/5983

Wasn't this fixed by #5983 ?

Yes, it was. Good spot @amyspark and thanks again @zachauten!


I want display More list on one page.

Thanks for your plugin ...It's very nice.
Now there is a limit that you can only set up to 15 list in one page.
But I want show more.
Second the btn fold all lists. Only can fold but can't expand...how about add one?

If it is urgent you could unzip the .xpi file and edit it manually for personal use only.
open the file app.js in your favourite editor and look for the option "listsPerPage".
Then you can change the values into something else for example
{         cate: f,         name: "listsPerPage",         type: String,         default: 15,         items: [{value: 15, label: 15}, {value: 20, label: 20}, {value: 30, label: 30},{value: 50, label: 50}],         new: "1.4.0"     }
I am currently testing 50 lists per page and the addon does handle it fine.
you probably have to sign the xpi (that's just a zip file).
you can do this, in case of firefox here.
just be sure to sign this for personal use only and public because of cnwangjie's copyright.
then you should be able to install it.
after that you should be able to select your amount of lists.

If it is urgent you could unzip the .xpi file and edit it manually for personal use only.
open the file app.js in your favourite editor and look for the option "listsPerPage".
Then you can change the values into something else for example
{ cate: f, name: "listsPerPage", type: String, default: 15, items: [{value: 15, label: 15}, {value: 20, label: 20}, {value: 30, label: 30},{value: 50, label: 50}], new: "1.4.0" }
I am currently testing 50 lists per page and the addon does handle it fine.
you probably have to sign the xpi (that's just a zip file).
you can do this, in case of firefox here.
just be sure to sign this for personal use only and public because of cnwangjie's copyright.
then you should be able to install it.
after that you should be able to select your amount of lists.

EDIT: nvm, just saw your fork :)

thank you anyway....:) yes I fork and change the code...and fix some bug.


Missing first seconds of audio when playing two way audio

Forgive me for perhaps being a bit naive here... I'm currently using Tapo C200 cameras, I got 2-way audio working, however when the cameras play the audio sent to them they miss the first second or so of audio. Given that the cameras are only playing 8khz audio, I figure that's simply a result of the camera's hardware limits & not a fault of go2rtc.
Is it possible to set FFmpeg options for only audio streamed to the cameras, so I could add a short 1 second of silence in the audio sent to the cameras? I've read through just about all the documentation & I'm not sure how I could do so, though I'm also the kind of person to miss the obvious solution after reading it several times. I don't want to add any delay in audio or video from the cameras, just the audio streamed to them.

I'll check on my camera. Maybe the 1-second problem can be fixed.

It was a really hard task...

It seems something else that was changed in the update might've broken the ability to play back audio files through Home Assistant... Previously this worked, however in 1.9.3, this seems to have stopped working suddenly. Two-way audio with a video+audio stream over HTTPS still works fine, however I can no longer play audio files to the cameras locally after updating to 1.9.3.
In my HAss configuration.yaml:
media_player:
  - platform: webrtc
    entity_id: media_player.lrtapo
    name: Livingroom Camera
    stream: lrtapo
    audio: pcma
  - platform: webrtc
    entity_id: media_player.kitapo
    name: Kitchen Camera
    stream: kitapo
    audio: pcma

go2rtc configuration:
streams:
  kitchen<EMAIL_ADDRESS>  livingroom<EMAIL_ADDRESS>
Is there something I'm doing wrong, or was something else changed? Searched other issues pretty extensively & read through both README's for WebRTC and go2rtc, not sure what isn't right with how I've configured the virtual media players.

You should now use audio: auto. But I will check old version. It shouldn't break.

I changed audio: pcma to audio: auto on both - it appears as if audio is actually playing on them in Home Assistant's UI, however nothing is actually played from the camera's speaker, in spite of the UI making it appear as if audio is playing on them. Both cameras are running firmware ver 1.3.7.

Finally had a chance to test with the 1.9.4 release. That seemed to fix it so audio: auto in my Home Assistant config works now, haven't tried with audio: pcma set though.
That being said, though it seems the original issue has been mitigated somewhat, it still occurs to some extent. It seems the audio that's cut off at the start is lesser than it used to be, however it still cuts off some audio. It also still sometimes cuts off the tail end, though for most of my uses that's not a noticeable problem - most audio I send to the camera has at least a half-second tail anyway.
A few videos to demonstrate with one of my cameras + the original 13s audio file sent to the camera for ref (a short music loop I made, used as it has no copyright):
https://github.com/AlexxIT/go2rtc/assets/25239471/efa5bfee-431e-431d-9633-48dd4fb396f2
https://github.com/AlexxIT/go2rtc/assets/25239471/0d1ca815-67c9-4af2-87c2-33d4f6f437b9
https://github.com/AlexxIT/go2rtc/assets/25239471/04173ce7-2deb-4ac2-84d0-e8745d7aa714
testsnd.zip


Wildcard ingress routing error

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When applying an Ingress with a namespace-Issuer I get this Error in the logs

time="2023-05-24T12:47:25Z" level=error msg="could not update kong admin" error="posting new config to /config: HTTP status 400 (message: "declarative config is invalid: {services={[4]={routes={{name=\"invalid value 'basic-www.wildcard-ingress.basic-www.*.k8s.domain.com.80': the only accepted ascii characters are alphanumerics or ., -, _, and ~\"}}}}}")" subsystem=dataplane-synchronizer

Issuer
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
  name: letsencrypt-wildcard
  namespace: basic-www
spec:
  acme:
    server: https://acme-v02.api.letsencrypt.org/directory
    email<EMAIL_ADDRESS>    privateKeySecretRef:
      name: letsencrypt-wildcard
    solvers:
    - selector:
        dnsZones:
          - "domain.com"
      dns01:
        route53:
          region: eu-central-1
          accessKeyID: <Key>
          secretAccessKeySecretRef:
            name: prod-route53-credentials-secret
            key: secret-access-key

Ingress
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: wildcard-ingress
  annotations:
    kubernetes.io/ingress.class: kong
    cert-manager.io/issuer: letsencrypt-wildcard
spec:
  tls:
    - hosts:
        - "*.k8s.domain.com"
      secretName: my-tls-secret
  rules:
    - host: "*.k8s.domain.com"
      http:
        paths:
          - pathType: Prefix
            path: "/"
            backend:
              service:
                name: basic-www
                port:
                  number: 80

Expected Behavior
When I apply provided Ingress any subdomain such as

something.k8s.domain.com
whatever.k8s.domain.com
...

Should be routed to the Service with SSL/TLS termination from Kong/KIC
...
   backend:
              service:
                name: basic-www
                port:
                  number: 80

Steps To Reproduce
1. deploy Kong

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- https://raw.githubusercontent.com/Kong/kubernetes-ingress-controller/v2.8.0/deploy/single/all-in-one-dbless.yaml

2. point DNS record `*.k8s.domain.com` to Kong-Proxy External IP
3. Deploy a simple echo-deployment `basic-www`
4. Deploy the `Issuer` & `Ingress` as shown above
5. watch logs `kubectl logs pod/ingress-kong-<hash> -n kong -c ingress-controller -f`
> time="2023-05-24T12:47:25Z" level=error msg="could not update kong admin" error="posting new config to /config: HTTP status 400 (message: \"declarative config is invalid: {services={[4]={routes={{name=\\\"invalid value 'basic-www.wildcard-ingress.basic-www.*.k8s.domain.com.80': the only accepted ascii characters are alphanumerics or ., -, _, and ~\\\"}}}}}\")" subsystem=dataplane-synchronizer

Kong Ingress Controller version
v2.8.0

Kubernetes version
1.24.0

Anything else?
I saw some wildcard related release notes
https://docs.konghq.com/gateway/3.3.x/how-kong-works/routing-traffic/#using-wildcard-hostnames
Not sure if this will fix it?
We can update if this is producing the error!
But ...
Latest KIC is 2.9.3

https://github.com/Kong/kubernetes-ingress-controller/tree/v2.9.3
https://raw.githubusercontent.com/Kong/kubernetes-ingress-controller/v2.6.3/deploy/single/all-in-one-dbless.yaml

... image: kong:3.2 ... direct link

Question:

Is the Error from this Issue to be solved by "the fix" in 3.3.x?
Is it safe to deploy KIC v2.9.3 with 3.3.xinstead of 3.2.x which seems to be the preferred version?
Do we have an Error or miss something?

Thank you guys in advance!

@randmonkey appreciate your feedback, thank you.
Just to make sure, this is how I would patch the default deploy/single/all-in-one-dbless.yaml for KIC 2.8.1 ++, correct?
...
        - env:
          - name: CONTROLLER_KONG_ADMIN_URL
            value: https://<IP_ADDRESS>:8444
          - name: CONTROLLER_KONG_ADMIN_TLS_SKIP_VERIFY
            value: "true"
          - name: CONTROLLER_PUBLISH_SERVICE
            value: kong/kong-proxy
          - name: POD_NAME
            valueFrom:
              fieldRef:
                apiVersion: v1
                fieldPath: metadata.name
          - name: POD_NAMESPACE
            valueFrom:
              fieldRef:
                apiVersion: v1
                fieldPath: metadata.namespace
          - name: CONTROLLER_FEATURE_GATES
            value: CombinedRoutes=false
          image: kong/kubernetes-ingress-controller:2.8.0
          imagePullPolicy: IfNotPresent
          livenessProbe:
            failureThreshold: 3
            httpGet:
              path: /healthz
              port: 10254
              scheme: HTTP
            initialDelaySeconds: 5
            periodSeconds: 10
            successThreshold: 1
            timeoutSeconds: 1
          name: ingress-controller
...

so just on the ingress-controller-container, or on others as well?
Sources:

https://docs.konghq.com/kubernetes-ingress-controller/latest/deployment/install-gateway-apis/#using-alpha-apis

kustomize example:
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- https://raw.githubusercontent.com/Kong/kubernetes-ingress-controller/v2.8.1/deploy/single/all-in-one-dbless.yaml

#FIX: https://github.com/Kong/kubernetes-ingress-controller/issues/4067#issuecomment-1562175250
patches:
- patch: |-
    - op: add
      path: "/spec/template/spec/containers/1/env/-"
      value:
        name: CONTROLLER_FEATURE_GATES
        value: "CombinedRoutes=false"
  target:
    kind: Deployment
    namespace: kong
    name: ingress-kong

@michael-riha You do not need to turn of CombinedRoutes if you are using KIC 2.8.1+ or 2.9+. The bug exists in 2.8.0, and fixed in 2.8.1 and later versions.


Process to validate new domains

I've just been added as a contributor by @leereilly (thanks!) and I'm wondering how you usually proceed to check that a new domain is valid.
I guess you check that there is a website for the school. Do you also check the SMTP server? Do you try to find examples of email addresses? Anything else?
/cc @tmcw @afeld @lyzidiamond

I've been pretty lax about it (visit the domain and see if the web site has the name of the school that they said), but checking for the MX record would probably make sense. Making me think that we should have a little app where:

They type in their school name and email
It sends them an email to verify
Automatically submit a pull request

Maybe pull in the <title> from the page at that domain, if there is one

That'd be really convenient! :+1:
In the meantime, I'm developing a new test to make sure that there's at least one responding MX server associated with the domain (we could use it in Travis to check new domains added in pull requests).

Wonder how easy it is to run tests on only the modified files...not sure if I've seen that done before. Would be useful for link validation in general.

I was thinking of using
git diff `git rev-parse master`..`git rev-parse HEAD`

for pull request and branch builds.
I'm still looking at what would be the best way to do that for builds on the master branch.


fix(scripts): precommit should use same configs as lint

Omiting the config param will correctly resolve to the same config as the normal lint. With the config param it’s resolving somewhere unknown.

📦 Published PR as canary version: Canary Versions

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:rocket: PR was released in<EMAIL_ADDRESS>:rocket:


Release only one of the keys

Hello.
First of all, thank you very much for the fantastic libraries.
I'm trying to make an ESP32-S3 behave as a keyboard+mouse.
Everything works correctly, but I have a question.
I want that when I hold down a button, the keyboard key is also pressed, I achieve that with "sendPress".
If, for example, I hold down the "A" and "S" keys, I release the "S" key and hold down the "A" key. How do I do it?
If I execute "sendRelease", as I understand it stops pressing all the keys.
Sorry for my English from Google Translate!!!
Thank you so much!!!!
Greetings.

Hi,
when 2nd time you send sendPress() with only A OS should interpret it like you released S

So:
If I send "sendPress(A)" and then send "sendPress(B)" it would not add the presses (A and B).
I deactivate "A" and press "B"?

Yes


Offer Gradle sample on how to publish

For a user to quick-start use this org.ajoberstar.grgit plug-in, is it possible to publish a 'Hello-World' sample build.gradle script to show a project push to it's Github repo ? Maybe also a sample for maven ?
thanx for all your hard work - much appreciated !  ;-)

I added a small task to the Grgit Usage wiki page that shows a basic push. As mentioned after the examples, the Grgit API doc includes details on all available operations.
When you say "a sample for Maven", do you mean Maven builds or Maven repositories? I think both are out of scope of this plugin, but if you have more clarification, please let me know.


remove workaround for screen shadow

This depends on #828, see https://github.com/react-community/react-navigation/pull/828#issuecomment-290239321
@ericvicenti

I think this workaround is still needed. If not, please make a new commit on top of master, and please post a GIF of the new behavior so we can verify it looks good

I will update #828 ,then this PR could be merged, so please reopen it, I will show you the difference later


Module not found: Error: Can't resolve 'fs' in...

Hey Marco,
Thanks for this package. It is exactly what I was looking for, the ability to use winston in the browser as well
For some reason, I still have this error in devtools console:
ERROR in ./node_modules/winston/dist/winston/tail-file.js
Module not found: Error: Can't resolve 'fs' in '/workspace/webapp/node_modules/winston/dist/winston'
 @ ./node_modules/winston/dist/winston/tail-file.js 9:9-22
 @ ./node_modules/winston/dist/winston/transports/file.js
 @ ./node_modules/winston/dist/winston/transports/index.js
 @ ./node_modules/winston/dist/winston.js
 @ ./node_modules/offsite-logger/index.js
 @ ./src/stores/userStore.ts
 @ ./src/stores/rootStore.ts
 @ ./src/index.tsx

ERROR in ./node_modules/winston/dist/winston/transports/file.js
Module not found: Error: Can't resolve 'fs' in '/workspace/webapp/node_modules/winston/dist/winston/transports'
 @ ./node_modules/winston/dist/winston/transports/file.js 33:9-22
 @ ./node_modules/winston/dist/winston/transports/index.js
 @ ./node_modules/winston/dist/winston.js
 @ ./node_modules/offsite-logger/index.js
 @ ./src/stores/userStore.ts
 @ ./src/stores/rootStore.ts
 @ ./src/index.tsx

My code is that:
import winston, { configure } from 'winston';
import BrowserConsole from 'winston-transport-browserconsole';
import { OffsiteLoggerOptions } from 'offsite-logger';

export const createOffsiteLoggerForBrowser = ({ service, moniker }: OffsiteLoggerOptions): any => {
  configure(
    new BrowserConsole({
      level: 'info',
    }),
  );

  return winston;
};

and I am bundling with webpack to use in another of our repos
const path = require('path');
const nodeExternals = require('webpack-node-externals');

module.exports = {
  entry: './src/offsite-logger-browser.ts',
  mode: "production",
  module: {
    rules: [
      {
        test: /\.ts?$/,
        use: 'ts-loader',
        exclude: /node_modules/,
      },
    ],
    },
  node: {
    fs: 'empty'
  },
  resolve: {
      extensions: ['.ts', '.js']
  },
  output: {
    filename: 'index.js',
    path: path.resolve(__dirname, 'dist'),
    library: 'offsiteLogger',
    libraryTarget:'commonjs2'
  },
  externals: [nodeExternals()]
};

any idea what I am doing wrong?

Same issue.

Same issue using createLogger with NextJS

ditto


Feature/iden 643 preparation to release v3

Close pr after discussion.

Close pr after discussion.

Close pr after discussion.


Implement uid/uuid conversion for trajectory

Ok, so there is now a wellbore graphql query that is executed before a trajectory graphql query. it gets the wellbore uuid and uses that as the filter in the traj graphql query. The well and wellbore uids are also carried from the query.

There is still an issue with AbstractWellLocation preventing trajectories with a TrajectoryStation Location attribute from deserializing


Updated Readme by adding some more description of app

Thanks for your contribution @smriti548 but currently we are exploring the possibilities we can have with this and come up with some sort of description what this project is about. Since we are in regular discussions regarding features and related things, we could convey above thought in a much clear and correct way. Feel free to contribute to other parts of the project meanwhile. Thanks again :)


Minor Update to Dependencies list in README.rst

snntorch version: 0.5.3
Python version: 3.10.4
Operating System: Windows 10

Description
I think that ffmpeg is missing from the dependencies listed in README.rst.
What I Did
Using conda, I installed the dependencies and then received the following error on the video conversion step of the first tutorial:
RuntimeError: Requested MovieWriter (ffmpeg) not available

This was easily sorted with: conda install -c conda-forge ffmpeg.

Thanks for catching this!
I consider the 'animation saving' / 'compression to mp4' to be something that can interface with snntorch rather than something that is part of snntorch. So it might be best to include it in the tutorial rather than the dependencies.
To keep it consistent with the tutorials, let's install via PyPi rather than conda.
We can add it in the relevant section as a commented code-block: #!pip install ffmpeg.
Feel free to apply the change to the notebook and push directly to the master branch, otherwise I'll try to handle it sometime this week.

Yes, that's a nicer fix than updating the dependency list as it's just a function that's being used in the tutorial. I'll do the change as suggested later today.

I took a look but unfortunately it's looking more complicated.
I cleaned my environment to uninstalled ffmpeg and then re-installed it from within the notebook using !pip install ffmpeg as suggested. It appeared to be successful:
Collecting ffmpeg
  Using cached ffmpeg-1.4-py3-none-any.whl
Installing collected packages: ffmpeg
Successfully installed ffmpeg-1.4

Unfortunately, the animation step still produced the initial error (as if ffmpeg was not installed). Subsequent attempt to re-install (just in case!) gave:
Requirement already satisfied: ffmpeg in c:\users\katyw\anaconda3\envs\snntorch\lib\site-packages (1.4)

I then uncommented the line above the animation step and to set animation.ffmpeg_path to the location of the exe installation:
plt.rcParams['animation.ffmpeg_path'] = 'c:\\users\\katyw\\Anaconda3\\pkgs\\ffmpeg-5.1.0-gpl_h36dc936_101\\Library\\bin\\ffmpeg.exe'

Now the exe was found but its DLLs were not:
ffmpeg.exe - System Error
The code execution cannot proceed because fontconfig-1.dll was not found. Reinstalling the program may fix this problem.

I suspect this is because the pip install does not copy the dlls into the sys.path dll location being used by the conda environment (so the DLLs for the exe can't be found).
Just to check, I re-ran the conda install outside the notebook and it worked fine (without the animation.ffmpeg_path needing to be set) because conda install also copied the dlls to the approprate folder.
I'm really not sure what this best fix here is as I agree that ideally it would be nicer to have this in the app and not a special case for conda. I haven't tried to see whether the pip install works within the notebook in a non-conda environment.  Any thoughts?

I find that the non-conda Google Colab environment doesn't require ffmpeg to be installed, so I think the best approach would be to add the suggestions in markdown.
Perhaps we can change the following note:
"Note: if you are running the notebook locally on your desktop, please uncomment the line below and modify the path to your ffmpeg.exe"
to:
"Note: if you are running the notebook locally, please uncomment the line below and modify the path to your ffmpeg.exe. This may require you to install ffmpeg: e.g., pip install ffmpeg or if in a Conda environment, conda install -c conda-forge ffmpeg"
Would you like to update the notebook & I can update the static webpage on readthedocs?

Sounds good to me! I made a tiny adjustment. Please go ahead with the
following:
"Note: if you are running the notebook locally you may need to install
ffmpeg: e.g., pip install ffmpeg or if in a Conda environment, conda
install -c conda-forge ffmpeg.
If ffmpeg is not found, please uncomment the line below and modify the path
to your ffmpeg.exe."
On Wed, 24 Aug 2022, 4:30 am katywarr, @.***> wrote:

Yes, thank you, that sounds like a good plan.
Would you be ok with slightly different wording because there is no need
to uncomment the line if it is installed correctly with everying on the
sys.path (i.e. it worked fine without uncommenting the line when I
installed it using conda)?
Perhaps this?
"Note: if you are running the notebook locally you may need to install
ffmpeg: e.g., pip install ffmpeg or if in a Conda environment, conda
install -c conda-forge ffmpeg.
If ffmpeg is not found following its installation please uncomment the
line below and modify the path to your ffmpeg.exe."
If you are happy with that, I can update tomorrow.
—
Reply to this email directly, view it on GitHub
https://github.com/jeshraghian/snntorch/issues/128#issuecomment-1224561983,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJTFT4TY5ATGITC62BWBYRLV2UKDRANCNFSM57FGGAJA
.
You are receiving this because you commented.Message ID:
@.***>


Custom build images

Describe the Feature
Amplify allows for custom-build images to be set in their UI, it'd be useful if they can be controlled with terraform like everything else about Amplify

Expected Behavior
https://github.com/cloudposse/terraform-aws-amplify-app/ supports all features of Amplify
Use Case
AWS have already documented why having custom images is important and how it works - https://docs.aws.amazon.com/amplify/latest/userguide/custom-build-image.html
Describe Ideal Solution
A new input for build image settings
  build_image_settings = {
    image   = "public.ecr.aws/docker/library/node:lts"
    timeout = 30
  }

Alternatives Considered
It's possible to set a custom image with an env variable
 _CUSTOM_IMAGE                  = "public.ecr.aws/docker/library/node:lts"

Additional Context
No response

What is the status of this?


Allow config*.py to work on Darwin.

This simply adds the rm and cp for Darwin, in the config*.py scripts.
This works on my 64-bit Mac OS X, and should be fine in general.

Yes, thanks


Swap to time and bump dep

Primarily due to the open security issue in chrono.

Note: chrono and time 0.1.45 is still used by skim as part of the dev deps for the example.


Add an R package for cell type annotation using CellMarker2.0 database

Thanks, @person-c. And welcome to the contributor club!


A11y_Azure Tools Storage Explorer_DiskInfoTable_AI4D: (StorageExplorer/image 'disk image') The Name must not include the same text as the LocalizedControlType.

GitHubTags:
#A11yTCS;#A11ySev2;#A11yWCAG;#DesktopApp;#AI4D;#A11yAuto;#Azure Tools Storage Explorer;#BM-AzureToolsStorageExplorer-Win32-Sep2021;#WCAG 4.2.1;#Benchmark;#Win32
Environment Details:
Application Name: Azure Tools Storage Explorer
Windows Version: Windows 10
Repro Steps:
1.Open Azure Tools Storage Explorer
2.Tab till the "Disks" of the selected subscription and press enter.
3.Click on any existing disk.
4.Navigate to DiskInfoTable under the tool bar.
5. Open AI4D and Verify.
Note:
The same issue is also observed in the below scenario:
Toggle Explorer Pane - Tree View
**Element path:
image 'disk image'
**Issue Details:
The Name must not include the same text as the LocalizedControlType. Section 508 502.3.1
**How To Fix:
Provide a UI Automation Name property for the element that:
· Concisely identifies the element, AND
· Does not include the same text as the element's LocalizedControlType property.
This accessibility issue was found using Accessibility Insights for Windows, a tool that helps debug and find accessibility issues earlier. Get more information and download this tool at https://aka.ms/AccessibilityInsights.
Attachment:

@v-inanda So to be clear the issue is that the localized control type, "image", is also part of the name?

Closing this bug as it is an Electron App .For Electronic apps no need to log AI bugs

Oh ok. That works too!

#Closed


[DataPicker] User can input value out of the range of min|max date in control

Bug:
Datapicker have great support limitation of min/ max values when you select value via mouse in dropdown. In the same time user can input any date in textfield which is out of the range.
What is the expected behavior?

Input value should be limited to values in min / max range

What is the current behavior?

Internal ngModel value updated for value out of the range: 01/10/201.

What are the steps to reproduce?

set min and max  date for datapicker. (min as 01/01/2018, max: 01/12/2018)
select from dropdown some date, like 01/10/2018
put cursor in textinput and delete one symbol from year (01/10/201)

Is there anything else we should know?
We don't have any support here:
https://github.com/angular/material2/blob/master/src/lib/datepicker/datepicker-input.ts#L322:L333

Internal ngModel value updated for value out of the range: 01/10/201.

And is validated like any other form field.
https://stackblitz.com/edit/angular-hagly7?file=app/datepicker-min-max-example.ts

And is validated like any other form field.
https://stackblitz.com/edit/angular-hagly7?file=app/datepicker-min-max-example.ts

Correct. But main point isn't validation. Validation it's another aspect.
In my particular case I have relation in components: like two datapickers (start / end date) and re-create onChange  appropriate text inputs count by months.  In this case I should limit programmatically  input users value into datapicker in some range via min and max property of data pickers.

Internal ngModel value updated for value out of the range: 01/10/201.

And is validated like any other form field.
https://stackblitz.com/edit/angular-hagly7?file=app/datepicker-min-max-example.ts

Form validation works fine. However it is another aspect.
Issue is critical when you have bunch of related controls, and one of them handle changes of datapicker as '@Input'.  For example: handle changes of start and end date and base on diff in month create appropriate  amount of text inputs. In this case not so good to inject into component invalid date.

Our goal when implementing this component is to keep the behavior as close as possible to how Angular handles native fields like type="number". Angular does not prevent users from typing values that are out of the range, it merely marks the value as invalid when they do. Therefore we do the same thing with the datepicker, by design

Our goal when implementing this component is to keep the behavior as close as possible to how Angular handles native fields like type="number". Angular does not prevent users from typing values that are out of the range, it merely marks the value as invalid when they do. Therefore we do the same thing with the datepicker, by design

@mmalerba Following up your example about native type="number". In the same time control prevent input invalid symbols except digits mask.
So, it would be great to take into account min and  max property on user input as well.
I mean add similar if statement in case one of mentioned property provided into component:
https://github.com/angular/material2/blob/master/src/lib/datepicker/datepicker-input.ts#L327

In the same time control prevent input invalid symbols except digits mask.

However, it doesn't prevent entering a value outside the min and max range. It's only validated.
https://stackblitz.com/edit/js-hzya2v?file=index.html


GeoJSON is not properly formatted

GeoJSON returned by the server is invalid and does not pass lint tests on /france/v1/polygon when specifying a geojson serializer.

Line 7: the first and last positions in a LinearRing of coordinates must be the same
Line 75: the first and last positions in a LinearRing of coordinates must be the same
Line 359: the first and last positions in a LinearRing of coordinates must be the same
Line 659: the first and last positions in a LinearRing of coordinates must be the same
Line 1123: the first and last positions in a LinearRing of coordinates must be the same
Line 1351: the first and last positions in a LinearRing of coordinates must be the same
Line 1395: the first and last positions in a LinearRing of coordinates must be the same
Line 6703: the first and last positions in a LinearRing of coordinates must be the same
[...]

Relevant spec from http://geojson.org/geojson-spec.html#polygon:

A LinearRing is closed LineString with 4 or more positions. The first and last positions are equivalent (they represent equivalent points). Though a LinearRing is not explicitly represented as a GeoJSON geometry type, it is referred to in the Polygon geometry type definition.

Is this still happening?

Yes, although with less warnings than before.

Could you please provide a request URL?

curl -X GET -H "Content-Type: application/json" -H "Cache-Control: no-cache" -H "Postman-Token: 6e436dbe-49af-f3de-e793-ec1edd44548b" "https://service.route360.net/france/v1/polygon?cfg={"sources"%3A[{"lat"%3A48.113844%2C"lng"%3A-1.681632%2C"id"%3A""%2C"tm"%3A{"car"%3A{}}}]%2C"elevation"%3Atrue%2C"polygon"%3A{"serializer"%3A"geojson"%2C"values"%3A[1800]}}&key=YOUR_KEY"

Where do you test the geojson?

Well probably here right? http://geojsonlint.com/

Yes but I also try to import it into PostGIS to visualize it with QGIS and it fails because of the incorrect format, I have to "clean it up" before.

Okay, this is very strange. We are performing this repair operation also on our servers. We will look into this error. Thanks for bringing it up.

@kofronpi we just release an improved version of the geojson feature. could you test it again?

@kofronpi I just saw that you provided an example request url. I was able to retrieve this with the new version and loaded in qgis. So I'm closing this for now. In case the error persists, just reopen the issue!
curl -X GET -H "Content-Type: application/json" -H "Cache-Control: no-cache" --compressed -H "Postman-Token: 6e436dbe-49af-f3de-e793-ec1edd44548b" "https://service.route360.net/france/v1/polygon?cfg=%7B%22sources%22%3A%5B%7B%22lat%22%3A48.113844%2C%22lng%22%3A-1.681632%2C%22id%22%3A%22%22%2C%22tm%22%3A%7B%22car%22%3A%7B%7D%7D%7D%5D%2C%22elevation%22%3Atrue%2C%22polygon%22%3A%7B%22serializer%22%3A%22geojson%22%2C%22values%22%3A%5B1800%5D%7D%7D&key=uhWrWpUhyZQy8rPfiC7X" > x.geojson

@gerbsen it seems to work fine for now. I'll tell you if I find any new bugs ! :+1:  Did you guys change the area returned in the payload with this update ?

@kofronpi what exactly do you mean with "change the area"?


sqlite3_blob_open cannot be used in an optimized fashion

In most cases, sqlite3_blob_open is called with the same arguments. On a specific use-case, the amount of memory allocated by sqlite3_blob_open reaches 64MB just by allocating byte arrays for the string parameters this function needs.
A possible workaround for this would be to provide helper methods in raw that take byte[] as parameter instead of string. Would this be plausible to implement via raw -> provider -> implementations?
https://github.com/dotnet/roslyn/issues/23424

Interesting.
I can see how it would be helpful to expose an API that allows the conversion from string to byte[] to be skipped if it is already done.
But even if breaking compatibility were ignored, I doubt we want functions that accept utf8 to be the only API, as most apps will want SQLitePCL.raw to take responsibility for the string->utf8 conversion.
Thinking about this makes me wonder if it would be possible to keep the API the same and just cache the utf8 byte arrays.
I also notice that sqlite3_blob_open is not the only function with this problem.  There are lots of other instances where every call will allocate a byte[] array to convert a string to utf8.

I added an overload for sqlite3_blob_open that I think would address the need here.

SQLitePCL.raw pre-release version 1.1.10-pre20180223200113 has been pushed to nuget.  Testing feedback on the new overload would be appreciated.

One of the problems with the overload is that the users of the API need to provide their own marshalling implementation (Util.ToUtf8 is internal).
Could that API be opened up?

This request (making util.to_utf8 public) initially struck me as odd.  (Why would they want that?  I thought the point was to avoid the allocation?)
But I think I see the point:  You have a string, and it still needs to be converted to utf8, but you only want to do that conversion (and its memory allocations) once.
However, I'm not sure SQLitePCL.raw should be including string->utf8 conversion routines part of its public API,. especially since my util.to_utf8 is just a wrapper around System.Text.Encoding.UTF8 stuff.
So, at the risk of being difficult, my first response here is to say, "I don't think I wanna do that.  You should probably just call UTF8.GetBytes() yourself.  Feel free to copy and paste my implementation if you like it."
But this isn't a hill I would die on.

Yeah, it's not a blocker! This is good enough.

especially since my util.to_utf8 is just a wrapper around System.Text.Encoding.UTF8 stuff.

Ah, I thought it was a special-cased version of utf8 encoding. Then it's all good!

So i looked into adopting this for roslyn as part of the discussion in https://github.com/dotnet/roslyn/issues/23424.  SPecifically, i wanted to move from calling:

to calling

My thought process was that i would just cache the well known utf8z forms of sdb/table/col as those are all constants in my system.  However, it turned out i was unable to do this because these are all ref-structs.  As such, i can't actually store them anywhere as that isn't allowed.
I'm a little at a loss how to proceed here, though i really hope we can come up with a solutoin as it would be nice to avoid all this memory marshalling all over the place! :)

So i looked into adopting this for roslyn as part of the discussion in https://github.com/dotnet/roslyn/issues/23424.  SPecifically, i wanted to move from calling:

to calling

My thought process was that i would just cache the well known utf8z forms of sdb/table/col as those are all constants in my system.  However, it turned out i was unable to do this because these are all ref-structs.  As such, i can't actually store them anywhere as that isn't allowed.
I'm a little at a loss how to proceed here, though i really hope we can come up with a solutoin as it would be nice to avoid all this memory marshalling all over the place! :)

Actually, i may have an approach using unsafe.  But it's pretty hacky and unpleasant :(

Actually, i may have an approach using unsafe.  But it's pretty hacky and unpleasant :(

@ericsink  @Therzok See here for how i addressed thsi: https://github.com/dotnet/roslyn/pull/50841/commits/ce2bf1286308281efc66cdbaacf7f132e4a1719f
I'm not a fan of this solution as it requires 'unsafe'.  However, there were no otehr way i could see to actually create a utf8z on demand without allocing.  Also, i couldn't create and cache utf8z's up front because they are ref-structs.   So this was the best solution i could come up with.

@ericsink  @Therzok See here for how i addressed thsi: https://github.com/dotnet/roslyn/pull/50841/commits/ce2bf1286308281efc66cdbaacf7f132e4a1719f
I'm not a fan of this solution as it requires 'unsafe'.  However, there were no otehr way i could see to actually create a utf8z on demand without allocing.  Also, i couldn't create and cache utf8z's up front because they are ref-structs.   So this was the best solution i could come up with.


Upgrade to Mark's event service

Hi @hboon we can do this together when I get back to SG.
Needs to:

Replace all node calls with event handlers that filter and sum balances
Can query for incoming transaction events (better UX) for both Ether and any random token
Grabs info like Token ids for NFT transfers

Note: We will probably need OpenSea for a while.

Ok. I remember that Weiwu mentioned these services (along with Infura) have to be supported in parallel, so we'll have to cater for that too.


upgrading to the latest

After upgrading to the latest version, the home page is refreshed repeatedly every time it is loaded, which is very slow

Try the new dependencies? I can't reproduce your problem.


sticker wear fix

stickers with a wear value of 1 would not be scraped but instead have a wear value of 0.0000 and the sticker would be unscraped
1 if check fixed it

I cannot reproduce your error and have no problem putting a 100% scraped sticker on a gun.
If you still have that problem, please open an issue and provide a guide to reproduce that problem.
Changing the wear value to 1 when the wear value is zero is also logically incorrect. I decline your request, but am very grateful for your assistance.


fix(element): correct typing of method map()

The elementFinder and index arguments of the mapping function passed to ElementArrayFinder.map() will never be undefined.
Fixes #4548

I signed it!

I'm not sure if this PR is still active, but should each also have its typings changed?


Having issues on a 1.7.1 Server with a 1.8 Data pack.

Cannot collect bits from the server, only dungeon bits, and the viewer doesn't appear to be working either. Been trying to grab the seed from this server for a week now.

Cannot collect bits from the server, only dungeon bits, and the viewer doesn't appear to be working either. Been trying to grab the seed from this server for a week now.

could be using custom generation or anti-xray.


chore(dependabot): limit open UI PRs to 1

Description
dependabot's UI PRs are stale. Some of them are year old. We can decrease limit to 1 or even disable it as we do not use it for UI dependencies.

https://github.com/stackrox/stackrox/pull/12 opened on 2021

Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
N/A

Tomasz, UI team discussed and agree with your initiative.


Publish an artifact, please.

I've been able to use this to create chatbots successfully. Please publish an artifact so I can more easily retrieve this as a dependency :)

I've made a jar release here
I'll look into publishing it as a maven dependency this week, as I've never done so before..

this doesnt contain the hippy classes ;)

I've published a maven build and added install instructions to the README.
Closing this now


Physiology

I know this is a bit late. Noticed an issue with concurrency and wanted to implement a way for PhysiologyValueGenerators to use other generators until there is a sufficient change in input parameters to warrant running the simulation.
SBML model files are placed in src/main/resources/physiology/models and generator configurations are in src/main/resources/physiology/generators.
The basic synthetic ECG model is there, but it is not currently being utilized since there aren't any corresponding VitalSigns for it.
Configurations for running the physiology gradle task are currently in config/simulations. There is also a README file there which gives a brief explanation of the task and its usage.
I spent some time tweaking the input parameters for the cardiac_hemodynamics generator. I based these inputs on a 2015 study providing statistics relating age and BMI to blood pressure (https://www.ncbi.nlm.nih.gov/pmc/articles/PMC4553889/). The general trend of BP increase with age  has been shown to be largely due to increased peripheral resistance and increased arterial stiffness. Therefore I developed equations for these two parameters that give results which are close to the statistics presented in the study. Increased BMI is also associated with an increase in BP, so I accounted for this by making arterial resistance related to the deviation of BMI from the center of the ideal BMI range for adults (21.7). From the couple of tests I've performed, Synthea's results appear to be fairly consistent with empirical results.
I'd also like to account for gender in these equations but ExpressionProcessors don't yet support sending non-numeric parameters into expressions.

Did you look at the checkstyle output? Does it complain about anything other than "missing javadoc comments"?

Sure it complains about a lot of things, but none of them are against files I've changed. Looks like the classes that have checkstyle issues (besides missing javadoc comments) are:

org.mitre.synthea.datastore.Datastore
org.mitre.synthea.engine.Generator
org.mitre.synthea.export.Exporter

Codecov is showing that test coverage of the submitted code is low (only covers 66% of your change). Is there an opportunity to include more unit tests and increase coverage?

Working on this.

It seems like you are including/duplicating some of the SBML YML and XML files in both src/main/resources/physiology and src/test/resources... are you sure you need to duplicate them (you probably shouldn't)? Or are there subtle differences between the files that I'm not seeing?

I duplicated them since I knew these files will probably change in the future (model defaults changes, better input arguments, etc.) and figured we may not want to have to change the tests every time we tweak a parameter. But on second thought, perhaps we do want that. If those configuration files change we do want to make sure our tests ensure that the changed files work appropriately.
I'll remove the duplicates.

@jawalonoski I think I've addressed all of the items you mentioned now and increased the code coverage to about 82%. I also noticed I had duplicated a method for getting attribute and VitalSign values from Person objects so I collapsed them into a single static method on the ExpressionProcessor class (commit e603410).
Let me know if you have any other concerns.

I am playing around with these changes before merging them, and I'm experiencing some java.lang.OutOfMemoryError exceptions when running ./run_synthea -s 0 -p 10000 California.
I'll want to figure out what is going on here before merging that in.
Also, physiology.enabled should default to false.

I am playing around with these changes before merging them, and I'm experiencing some java.lang.OutOfMemoryError exceptions when running ./run_synthea -s 0 -p 10000 California.
I'll want to figure out what is going on here before merging that in.

I profiled the code with and without physiology enabled and determined what the main problem was. I was keeping a static map of SimRunner instances so that multiple PhysiologyValueGenerators which use the same model would also use the same simulator for each Person object. Since that Map was static, those SimRunners would stick around forever, long after the Person had completed their life cycle, which resulted in a memory leak.
I rectified this by using a transient Map of SimRunners on each Person object to keep track of those instead of the static Map on the PhysiologyValueGenerator class (transient so that it won't be serialized with the Person). This means when the Person goes out of scope, it's corresponding SimRunner instances are also garbage collected. The downside to this is it somewhat increases coupling between the Person class and the PhysiologyValueGenerator class. I'm open to other suggestions if you think there's a better way to ensure those objects are cleaned up properly.

Also, physiology.enabled should default to false.

Should be fixed now. That was a mistake on my part.

Memory Profiling Results:
master branch (no physiology simulations):

physiology branch (with physiology enabled):

Memory usage is pretty comparable, though you'll notice there are many more spikes in memory usage on the physiology branch. This is likely due to the temporary simulation data results tables being populated, since they can be quite large.
These were both runs generating a population of 10000. Note that the master run executed in about 9 minutes, while the physiology run executed in a bit over 13 minutes, suggesting a run time cost of roughly 1.5x for enabling physiology with the current generator settings. This can be tweaked pretty effectively by modifying the input parameter variance field in the generator configuration, which causes a trade-off between performance cost and physiological accuracy.

I'm very interested in this feature and can take a look tomorrow.

During profiling, I noticed two heavy CPU hot spots: calculating Haversine distance for locations, and the use of java.lang.Enum.valueOf(String).
The first is out of scope on this pull request. But for the second hot spot, over 18% of the "Self Time (CPU)" time is spent on Enum.valueOf when physiology is enabled.
If you can change ExpressionProcessor to precompute whether or not each param is a VitalSign or an Attribute then you won't have to call VitalSign.fromString for every single call to ExpressionProcessor.getPersonValue(...).
That might considerably speed up the expression processing, and in turn the entire physiology code. Worth a try.

This looks awesome. Just two questions around the physiology.enabled config setting:

It only affects the PhysiologyValueGenerators that produce the values for vital signs, and not the Physiology state in modules, correct? Could the name be a little more specific to reflect that?
What happens if the config setting is disabled, but something else depends on a vital sign that a generator was going to set? Is the idea that we're always going to need a "quick & dirty" version to generate values for that vital sign alongside the more robust but slow model?
(And apologies if these were already discussed; I'm not sure if I'm seeing all the comments on the PR based on the number of emails I had when I got back from vacation a couple weeks ago)

In response to Jay's comment:

If you can change ExpressionProcessor to precompute whether or not each param is a VitalSign or an Attribute then you won't have to call VitalSign.fromString for every single call to ExpressionProcessor.getPersonValue(...).

Instead, perhaps I could just add another parameter to indicate whether the string points to a VitalSign or attribute, since that's known ahead of time in the physiology configurations. I'll try this out and let you know what the performance difference is.
I only took a superficial look at the CPU profile to make sure there weren't any glaring issues so I didn't dig deep enough  to see that the VitalSign.fromString method call could be significantly impacting performance.
In response to Dylan's comment:

This looks awesome. Just two questions around the physiology.enabled config setting:

It only affects the PhysiologyValueGenerators that produce the values for vital signs, and not the Physiology state in modules, correct? Could the name be a little more specific to reflect that?

Yes that's a good point. Though I think there are multiple ways we could go about this. One is to rename the config to reflect that it only affects PhysiologyValueGenerators as you suggest. Another option is we could add an additional required field for Physiology states to provide an alternative state to go to if physiology.enabled = false and have Physiology states avoid the simulation in that case.
Since we have PhysiologyGenerators I don't see the Physiology state being used too much in modules but I could be wrong.

What happens if the config setting is disabled, but something else depends on a vital sign that a generator was going to set? Is the idea that we're always going to need a "quick & dirty" version to generate values for that vital sign alongside the more robust but slow model?

Yes I believe so. At least for now I think the idea is to always have a much faster "quick & dirty" backup generator for each VitalSign since physiology simulations are relatively computationally expensive.

During profiling, I noticed two heavy CPU hot spots: calculating Haversine distance for locations, and the use of java.lang.Enum.valueOf(String).
The first is out of scope on this pull request. But for the second hot spot, over 18% of the "Self Time (CPU)" time is spent on Enum.valueOf when physiology is enabled.
If you can change ExpressionProcessor to precompute whether or not each param is a VitalSign or an Attribute then you won't have to call VitalSign.fromString for every single call to ExpressionProcessor.getPersonValue(...).
That might considerably speed up the expression processing, and in turn the entire physiology code. Worth a try.

I implemented a VitalSign cache for the ExpressionProcessor so that it only ever has to call VitalSign.fromString once for each unique parameter it receives in getPersonValue(). Doing this did indeed have a noticeable impact on performance, reducing total run time on my 10000 patient generation from a bit over 13 minutes to about 12 minutes flat (about 10% faster).

I don't understand why, but apparently a Generator test failed in the CI build:
org.mitre.synthea.engine.GeneratorTest > testGeneratorCreatesPeople FAILED
    java.lang.AssertionError: expected:<3> but was:<2>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:645)
        at org.junit.Assert.assertEquals(Assert.java:631)
        at org.mitre.synthea.engine.GeneratorTest.testGeneratorCreatesPeople(GeneratorTest.java:34)

This looks awesome. Just two questions around the physiology.enabled config setting:

It only affects the PhysiologyValueGenerators that produce the values for vital signs, and not the Physiology state in modules, correct? Could the name be a little more specific to reflect that?

I decided to rename the config setting to physiology.generators.enabled to be more specific. I figure if we want to be able to turn off Physiology state in modules as well that could simply be a separate configuration setting.

Thanks for the contribution! 🎉


Should the ztunnel DaemonSet have priorityClassName: system-node-critical?

Describe the feature request
The HelmChart for deploying ztunnel does not explicity set the priorityClassName, nor does it offer a setting in the template to set the value.  The istio-cni chart explicitly sets the priorityClassName here: https://github.com/istio/istio/blob/61ed8d599a84ff458a334479cd9dddeb61c52ebd/manifests/charts/istio-cni/templates/daemonset.yaml#L62
I would think that the ztunnel DaemonSet should also be classified as system-node-critical
Without this, when you try to deploy or upgrade ztunnel, pods can get stuck in Pending status with a message like '0/8 nodes are available: 1 Insufficient memory. preemption: 0/8 nodes are available: 8 No preemption victims found for incoming pod..'.  Setting the higher priority will ensure that ztunnel runs on all nodes.
Describe alternatives you've considered
I can set this value with a kustomization process on the helm chart, but I think that system-node-critical should be the default or only possibility, like the istio-cni DaemonSet.
Affected product area (please put an X in all that apply)
[X ] Ambient
[ ] Docs
[ ] Dual Stack
[X ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[X ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context
This is a very easy PR to submit, which I can do, but I wanted to see if there was a good reason this should not be the default.

remember this was discussed somewhere before.  @costinm

I did search for this in issues and I couldn't find anything related to the ztunnel chart.  I do see requests for setting this in other charts and it has been added as an option to the gateway chart.

IMO, Ztunnel should be put higher priority than gateway

Agreed - CNI and ztunnel should both be critical.
Unpopular opinion: CNI and ztunnel should also be in the same helm chart ( popular opinion seems to be that
ztunnel should be implemented by the CNI layer directly - but for some reason us having a single helm chart for both
is not ok )

Note I didn't say 'same helm daemon set', as 2 separate containers - which would likely be even less popular - but how a native CNI implementation would likely do it ...

I created a PR for this change (linked above).  I am waiting for our Security Chief to approve our CLA when she gets back from Thanksgiving vacation.

fixed by https://github.com/istio/istio/issues/47867


JPA ID class "TokenEntry.PK" must have a public no-arg constructor

I got the following validation error:
ID class "org.axonframework.eventhandling.tokenstore.jpa.TokenEntry.PK" must have a public no-arg constructor.
Other ID classes do have the public no-arg constructor, e.g.:
org.axonframework.eventsourcing.eventstore.AbstractSnapshotEventEntry.PK
The validation error appears, when i put these lines into my orm.xml, to override schema and name:

Closing this issue, as it has been resolved in commit 1ffda2d.


Can't install trough npm

npm ERR! path /root/OffersBot/node_modules/tiny-shortener/dist/cli.js
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall chmod
npm ERR! enoent ENOENT: no such file or directory, chmod '/root/OffersBot/node_modules/tiny-shortener/dist/cli.js'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR!  Same problem here.

+1. Same here

Same

@MegaITA, @sayanriju, @smitti24 and @bigmarkoberg, fixed. Sorry, it was my bad not configuring the CLI option to work with WEBPACK; it will be published later in a new package.


use C for the external scanner

Mainly for portability & ease of compilation

Ping @kevinushey is this repo dead? No rush but it has been over a month :sweat_smile:

Thanks! Sorry I missed this PR before.

Thank you!


QML-like syntax engine

Can XAML syntax engine be replaced with QML-like syntax engine, or provide a conversion tool. QML syntax is really very concise and beautiful, and now XAML is a bit verbose.
For example: ButtonPage.xaml
<UserControl xmlns="https://github.com/avaloniaui"
             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
             x:Class="ControlCatalog.Pages.ButtonPage">
  <StackPanel Orientation="Vertical" Spacing="4">
    <TextBlock Classes="h1">Button</TextBlock>
    <TextBlock Classes="h2">A button control</TextBlock>
    <StackPanel Orientation="Horizontal"
                Margin="0,16,0,0"
                HorizontalAlignment="Center"
                Spacing="16">
      <StackPanel Orientation="Vertical" Spacing="8" Width="150">
        <Button>Button</Button>
        <Button Foreground="White">Foreground</Button>
        <Button Background="{DynamicResource ThemeAccentBrush}">Background</Button>
        <Button IsEnabled="False">Disabled</Button>
        <Button Content="Re-themed">
          <Button.Styles>
            <Style>
              <Style.Resources>
                <SolidColorBrush x:Key="ThemeBorderMidBrush">Red</SolidColorBrush>
                <SolidColorBrush x:Key="ThemeControlHighBrush">DarkRed</SolidColorBrush>
              </Style.Resources>
            </Style>
          </Button.Styles>
        </Button>
      </StackPanel>
      <StackPanel Orientation="Vertical" Spacing="8" Width="150">
        <Button BorderThickness="0">No Border</Button>
        <Button BorderBrush="{DynamicResource ThemeAccentBrush}">Border Color</Button>
        <Button BorderBrush="{DynamicResource ThemeAccentBrush}" BorderThickness="4">Thick Border</Button>
        <Button BorderBrush="{DynamicResource ThemeAccentBrush}" BorderThickness="4" IsEnabled="False">Disabled</Button>
      </StackPanel>
    </StackPanel>
  </StackPanel>
</UserControl>

QML-like  syntax code:
@UserControl
@Class ControlCatalog.Pages.ButtonPage

StackPanel {
    Orientation:"Vertical"
    Spacing:"4"
    TextBlock{Classes:"h1" Text:"Button"}
    TextBlock{Classes:"h2" Text:"A button control"}
    StackPanel{
        Orientation:"Horizontal"
        Margin:"0,16,0,0"
        HorizontalAlignment:"Center"
        Spacing:"16"
        StackPanel{
            Orientation:"Vertical" Spacing:"8" Width:"150"
            Button{Text: "Button"}
            Button{Foreground:"White" Text:"Foreground"}
            Button{Background:"@ThemeAccentBrush" Text:"Background"}
            Button{IsEnabled:"False" Text:"Disabled"}
            Button{
                Text:"Re-themed"
                Style.Resources {
                    SolidColorBrush {ThemeBorderMidBrush:"Red"}
                    SolidColorBrush {ThemeControlHighBrush:"DarkRed"}
                }
            }
        }
        StackPanel{
            Orientation:"Vertical" Spacing:"8" Width:"150"
            Button {BorderThickness:"0" Text:"No Border"}
            Button {BorderBrush:"@ThemeAccentBrush" Text:"Border Color"}
            Button {BorderBrush:"@ThemeAccentBrush" BorderThickness:"4" Text:"Thick Border"}
            Button {BorderBrush:"@ThemeAccentBrush" BorderThickness:"4" IsEnabled:"False" Text:"Disabled"}
        }
    }
}

Seems like duplicate of https://github.com/AvaloniaUI/Avalonia/issues/2502
By the way, I don't really like multiple markup languages for one framework, and I really like xaml.

Well, I just saw #2502. It's very similar.
The grammar of QML is well refined, just liking poem. QML has several advantages:

Syntax like JSON
Concise binding syntax
Concise attribute syntax
Signal and slot
...

The binding syntax of QML is very concise and I like it very much. In the following short example, When dragging sliderbar's handler, the TextBlock can display sliderbar's value in real time:
SliderBar { Id=“sld” Min=0 Max=100}
TextBlock { Text: sld.Value }

The other two characteristics of QML: property and signal/slot, which can be moved to .CS file and implemented by csharp built-in mechanism instead of interface layer code.
By the way, this qml-like language file maybe has the extension ".csml" (CSharp markup language)

My 2 cents
But i like this Syntax
https://github.com/AvaloniaUI/Avalonia/issues/2502#issuecomment-490406757
Xaml is realy dense, which makes it hard to read.
Remco

Why write gui in different language than c# itself.
Check this: https://github.com/VincentH-Net/CSharpForMarkup
To create uı declarative way in c# , this lib defines static functions for ui controls.
Look at kotlin compose.  UI, backend both kotlin . They are trying to get away from  findbyviewid() garbage.
People are trying to get away from ui lang being different than backend code.
İf you're gonna do this. İ hope it goes like c#for_markup did . Not another xxxML .

Going to close this because as you say it's very similar to #2502. Let's keep discussion there.


Stage 1 data collection failures

In the E2E lab we would intermittently see failures to collect jitter during stage 1. This would cause stage 1 to fail despite reporting successful pings across all connections. We had the lab team investigate machines we saw these types of failures on, but no pattern was found regarding hardware or configuration. The jitter collection bug did not repro consistently, so I added a workaround to warn instead of failing the test so as not to impact E2E testpasses.


new npm keywords

Codecov Report

Merging #248 into master will decrease coverage by 0.3%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   29.04%   28.73%   -0.31%
==========================================
  Files          93       97       +4
  Lines        3674     4026     +352
  Branches        5        5
==========================================
+ Hits         1067     1157      +90
- Misses       2607     2869     +262


JSX/TSX: Proper way to use State types

Consider this example:
class ToggleState {
	open:boolean
}
class AnimationDemo extends React.Component<{}, ToggleState>
{
  state:ToggleState;
  constructor () {
    super()
    this.state = {open : false, fdsa: 'asdf'};
  }
  getInitialState():ToggleState {
    return {open: false};
  }
  handleMouseDown() {
    this.setState({open: !this.state.open, fdsa: 'asdf'});
  }
  render() {
    return (

something

    );
  }
};

There doesn't seem to be any guarding against assigning bad values in the state property or passing them into setState.
Note that if I attempt to return something invalid from getInitialState it fails correctly, however React doesn't respect getInitialState unless the component is created with React.createClass(). (See the example here: https://facebook.github.io/react/blog/2015/01/27/react-v0.13.0-beta-1.html#es6-classes)
So is it possible for me ensure that the state property and setState are guarded correctly?

tagging @RyanCavanaugh

This is just a manifestation of the general problem of surplus properties in object literals (#391). Pull request #3823 (in progress) will cause the fsda properties to error.


"browser.refresh()" causes "Angular could not be found on the page" with Firefox 38.0.5

All tests that invoke browser.refresh() are failing with "Angular could not be found on the page" errors when using the latest Firefox (38.0.5) and<EMAIL_ADDRESS>(with selenium-webdriver@2.45.1).
The same tests work just fine in latest Chrome (43.0.2357.124).
Replacing browser.refresh() with get current URL then load URL solves the problem, so we use this workaround for now:
exports.config = {
    …
    onPrepare: function () {
        browser.refresh = function () {
            var self = this;
            return self.getCurrentUrl()
                .then(function (url) {
                    return self.get(url);
                });
        };
    }
};

Good catch!  https://github.com/angular/protractor/pull/2217 should mitigate this problem, but probably the best thing to do in the long-term is for us to over-write browser.refresh

With the latest version of protractor, browser.refresh() issue looks like it has been resolved and no longer reproducible.


Implement WASH Command Interpreter

Implement a command interpreter for the Web Application SHell, with core functionality exposed through the libwash.js library.  These functions should include basic operations on the VFS (eg. cd, cat, mkdir, rmdir).
Interpreter should accept and process commands interactively or as scripts stored within the VFS.

Basic interpreter working (though not yet as an HxProcess)


Property 'services' does not exist on type 'TurnContext'.

Versions
What package version of the SDK are you using.
"botbuilder": "^4.0.6"
Describe the bug
I am developing custom middleware (using Typescript) and after updating to latest botbuilder packages I am getting error stating that Property 'services' does not exist on type 'TurnContext' when trying to call this line of code:  context.services.set(this.cacheKey,score);
To Reproduce
See above
[bug]

I believe this property has been renamed to turnState.

Yes... as @benbrown  said we renamed DialogContext.services to DialogContext.turnState as its more descriptive of what its used for.