deleteAll(Iterable<? extends T> entities), delete(T entity) & GetOne() does not apply multi tenancy

After some excessive testing, it has been noticed that not all methods correctly apply multi tenancy by default.

deleteAll(Iterable<? extends T> entities)
When you create a new object with a ID of another tenant and call this method with those objects, the data of the other tenant is deleted.
void delete(T entity).
T getOne(ID id); This default behavior is normal but not wanted as it gets the reference of the entity bypassing the filters

Requisites

Write tests accordingly to the changes and to verify that the default closed methodology still stands

What has to be done

Fix the unwanted behavior

For now, it is stated that the hibernate interceptor only works for onSave() & onFlushDirty().
The delete() keeps on failing and not triggering onDelete() in the TenantInterceptor.
A custom override of delete also does not properly trigger the interceptor.
`
@Override
public void delete(@NonNull final T entity) {
final Class entityType = this.entityInformation.getJavaType();
Objects.requireNonNull(entity, "Entity can not be null for Type [" + entityType + "]");
final CriteriaBuilder criteriaBuilder = this.entityManager.getCriteriaBuilder();
final CriteriaDelete<T> cq = criteriaBuilder.createCriteriaDelete(entityType);

cq.where(
    criteriaBuilder.equal(
        cq.from(entityType).get(this.getId()), this.entityInformation.getRequiredId(entity)));
this.entityManager.createQuery(cq).executeUpdate();

}
`
We will have to override this method and use deleteById internally instead.


fix: Keycloak deployments do not respect NodeSelector and Tolerations in the Argo CD CR(#450)

What type of PR is this?

/kind bug

Fixes #450
How to test changes / Special notes to the reviewer:
#450

@saumeya Can you please review and test this PR ?

LGTM @iam-veeramalla , tested and runs correctly!

Do we need to add unit /e2e tests?

Do we need to add unit /e2e tests?

Sure, Added a Unit test.

Does this need to go into v1.3 branch?

It's been cherry-picked to v1.3.
On Tue, Oct 5, 2021 at 1:30 AM jannfis @.***> wrote:

Does this need to go into v1.3 branch?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/argoproj-labs/argocd-operator/pull/452#issuecomment-934079475,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQAJII6ATTUYJMB2D5MLETUFKEODANCNFSM5FEPBKNQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Add support for argument defaults via environment variables

I.e. if argument -verbosity isn't set but environment variable  CAKE_VERBOSITY is set, then we should use the environment variables value.
It should work the same for custom arguments i.e.
build.ps1
$env:CAKE_VERBOSITY='Diagnostic'
$env:CAKE_TARGET='build'
.\Cake.exe build.cake
exit $LASTEXITCODE

build.cake
var target= Argument("target", null) ?? "Run-Tests";`

then the target should be build and the verbosity should be Diagnostic.

Closed due to inactivity.


This is cool!

Some thoughts and reflections from teaching this at EDA:
We used to teach this pathway: React in es6, components with state -> learn jsx -> learn redux -> rip out component state.
A lot of people found this confusing. @mixmix had the idea to flip it around and with my last cohort we did:
Learn hyperscript (could be yo-yo too) -> use hyperscript and morphdom and mutate global state -> learn how to write a reducer function in the style of redux. Use that function to calculate a new state. -> Pass a dispatch function into all your hyperscript components -> swap in redux -> swap in react.

massive improvement IMO


fix line_0 errors

Codecov Report

Merging #400 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #400   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           11        11
  Lines          505       505
=========================================
  Hits           505       505

Impacted Files
Coverage Δ

nbqa/save_source.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8746d2f...9975366. Read the comment docs.


[STU-65] Only one index shows in the control panel

I have two indices configured in scout.php e.g.
return [
    'indices' => [
        \rias\scout\ScoutIndex::create('reviews')
        ->elementType(\craft\elements\Entry::class)
        ->criteria(function (\craft\elements\db\EntryQuery $query) {
            return $query->section('reviews');
        })
        ->transformer(function (\craft\elements\Entry $entry) {

            return [
                'title' => $entry->title,
                …
            ];
        })
    ],
    [
        \rias\scout\ScoutIndex::create('articles')
        ->elementType(\craft\elements\Entry::class)
        ->criteria(function (\craft\elements\db\EntryQuery $query) {
            return $query->section('articles');
        })
        ->transformer(function (\craft\elements\Entry $entry) {

            return [
                'title' => $entry->title,
                …
            ];
        })
    ],
];

but when visiting /utilities/scout-indices I can only see the first one listed. Is that to be expected?
STU-65

Hey @tyssen, that seems like a bug (possibly introduced in #275). Will have a look and try to have a bugfix out over the weekend.

Hey @tyssen, it looks like your second index isn't in the "indices" key, is that just in this example?
Could you also let me know which version of Craft & Scout your are running? I can't reproduce it on my end with the current release (3.3.0).

@janhenckens yep, sorry, I hadn't set that up quite right. Fixed now and I can see both of them in the control panel. Sorry for wasting your time.

No worries!


Is the project still alive? [No trolling meant]

Hi,
Wanted to know if the project is still alive since a lot of issues were opened a few months ago but the last activity was 3 months ago.
Most disturbing actually is the open PR which wasn't even acknowledged over 4 months ago.
The reason I'm asking is because I have this need of syncing OS libraries from a monorepo and MOE sounds really interesting.
We're currently doing it manually and it, obviously, has a lot of drawbacks. I'm also looking at [FBShipIt] (https://github.com/facebook/fbshipit) but the hack angle is less appealing then Java.
If the project is alive I'd be happy to try and contribute if possible.

It's still active, though far less so.  The delays in syncing is in me as
it isn't my primary responsibility.  I'll post some internal changes and
try to address the highest priority GitHub issues.
On Sat, Jun 11, 2016, 02:19 Ittai Zeidman<EMAIL_ADDRESS>wrote:

Hi,
Wanted to know if the project is still alive since a lot of issues were
opened a few months ago but the last activity was 3 months ago.
Most disturbing actually is the open PR which wasn't even acknowledged
over 4 months ago.
The reason I'm asking is because I have this need of syncing OS libraries
from a monorepo and MOE sounds really interesting.
We're currently doing it manually and it, obviously, has a lot of
drawbacks. I'm also looking at FBShipIt
https://github.com/facebook/fbshipit but the hack angle is less
appealing then Java.
If the project is alive I'd be happy to try and contribute if possible.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/MOE/issues/33, or mute the thread
https://github.com/notifications/unsubscribe/AAUN4o5VqeD9ng4xWaL8ItwPM-UKfpjzks5qKn2YgaJpZM4IzgqP
.

I've pushed more changes out, and am in the middle of bringing things back into sync. We restructured the project a LOT, and (ironically) MOE has trouble with fundamental project structure redefinition. :)  But it's almost there.  I hope to release shortly.


Naming convention needs to mention possible conflict with deep inserts/deep updates

Currently, this is apparently a well known issue in the community, but it's undocumented. Either it's a design flaw or intended (both possibilities are equally bad tbh). If this is a bug, please advise where to report this.
The issue is that if you are using Pages as parts, in a relation to an API Page, that relation Name must be named exactly the same at EntitySetName otherwise deep inserts/deep updates does not work.
This is a question that often is asked in the different communitues. It would be helpful to have this documented properly.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9788276f-d5a4-7742-0d2c-75db403698cf
Version Independent ID: 8cc28734-434b-5795-0fc2-2d64e234e5de
Content: API Page Type - Business Central
Content Source: dev-itpro/developer/devenv-api-pagetype.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Thank you for the input. I have marked it as bug. Name and EntitySetName should not be force to be identical. Deep patching is currently not supported.


Remove version: foxglove.studio version 1.83.1

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/foxglove/studio/releases/download/v1.83.1/foxglove-studio-1.83.1-win-arm64.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 720)


Add glamor integration example

What: Add glamor integration example

Why: Closes #69.

How: 😎

Wait up... Something isn't right in this PR... 😞

OK, fixed. IDK what happened back there honestly. 😥


Some unwanted area detected as table

With reference to the image above, those above date is also detected as table, when I hope it's not detected. Is there anyway to refine the table detection model?
By the way, I am using the transformer model released here:
https://huggingface.co/microsoft/table-transformer-detection

My first thought would be: is it possible for you to create a simple post-processing rule to filter these unwanted tables out when they occur?
If you want the model itself to suppress the unwanted tables, you will need to fine-tune the detection model on additional labeled examples where only the tables you want are labeled as tables. If the unwanted tables are all very similar in appearance, you will not need very many examples to teach the model to ignore the unwanted tables.
For any questions about how to fine-tune the Hugging Face model, I recommend posting on Hugging Face specifically.
Best,
Brandon

Thanks. Yay. Your first suggestion coincides with what I thought.
Just wondering what's the difference between transformer pretrained model and your pretrained model in terms of weights?

There is no difference between the two currently. The Hugging Face model was converted directly from the one in this repo. (This could change in the future, though).


Invalid colName

when i change db version on android manifest to new version from 2 to 3 and add new property in my model  and after run app and add new database data and after insert , me select all value and  sugar get null of my new property and log error Invalid colName.
i user 1.5 version
logs:
D/SQL Log: SQLiteQuery: SELECT * FROM TEST
11-01 23:15:53.902 9449-9449/mahdinaseri.ir.myapplication I/Sugar: ALTER TABLE TEST ADD COLUMN KK TEXT
11-01 23:15:53.942 9449-9449/mahdinaseri.ir.myapplication I/Sugar: test saved : 9
11-01 23:15:54.282 9449-9449/mahdinaseri.ir.myapplication D/SQL Log: SQLiteQuery: SELECT * FROM TEST
11-01 23:15:54.292 9449-9449/mahdinaseri.ir.myapplication E/SUGAR: Invalid colName, you should upgrade database
11-01 23:15:54.292 9449-9449/mahdinaseri.ir.myapplication E/SUGAR: Invalid colName, you should upgrade database
11-01 23:15:54.292 9449-9449/mahdinaseri.ir.myapplication E/SUGAR: Invalid colName, you should upgrade database
11-01 23:15:54.292 9449-9449/mahdinaseri.ir.myapplication E/SUGAR: Invalid colName, you should upgrade database
11-01 23:15:54.292 9449-9449/mahdinaseri.ir.myapplication E/SUGAR: Invalid colName, you should upgrade database
11-01 23:15:54.292 9449-9449/mahdinaseri.ir.myapplication E/SUGAR: Invalid colName, you should upgrade database
11-01 23:15:54.292 9449-9449/mahdinaseri.ir.myapplication E/SUGAR: Invalid colName, you should upgrade database
11-01 23:15:54.292 9449-9449/mahdinaseri.ir.myapplication E/SUGAR: Invalid colName, you should upgrade database
11-01 23:15:54.292 9449-9449/mahdinaseri.ir.myapplication E/SUGAR: Invalid colName, you should upgrade database

I saw in the code of ReflectionUtils's class this:

There's a line which it says "//TODO auto upgrade to add new columns", maybe this issue it's about a new funcionality?
We need a solution for that.
The problem is that if you change your DB, for example, you add a new column to an entity and then su make a save()... it will be executed and alter table for the new column and then  a insert to the table...
Next, you make a listAll() and the first time it will be showed and error like "Invalid colName, you should upgrade database", but if you retry, the error won't appear.


"Biled" is listed in the drop-down menu

Description:
The village is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Preconditions:
The website (https://peviitor-ro.github.io/ui.orase/) is up and runing. After every step delete the text you typed from the search bar.

Description:
The cvillageis listed in the drop-down menu alongside its corresponding county and commune, according to the law
Preconditions:
The website (https://peviitor-ro.github.io/ui.orase/) is up and runing. After every step delete the text you typed from the search bar.

Step 1
Write in the search bar "Biled".

Expected results
The location is listed in the drop-down menu as "Sat Banloc, TIMIȘ(Biled) ".


Suggestion: API to change font of text in SQRichTextView

To change the font of text available in TextView

Need to support multi language keyboards, So needed the support for setting the Font.

Hi,
Any update of Changing the Font and Font Family


Changed CountUpdate int to bigint

Found the count example was using both bigint and int, changed to consistently use bigint.

I'm looking at this, but my first order of business is to try and understand the raison d'etre of this repo when the code is also here: https://github.com/apache/incubator-impala/tree/master/be/src/udf_samples. I'll let you know about my progress.

Thanks Jim.  It just dawned on me it may have been on purpose to take integers as input, but then when adding them use bigint, which would make some sense if you expected the total to overflow.  In which case this isn't a bug.
Re this repo: I believe the benefit of a seperate repo was that it did not require pulling all of impala and did not require as many dependencies.  (A long time ago, when I built my first udf, I tried to use that builtin impala example and couldn't get it working as fast as I could this one).

I suggest this repo be eliminated. An impala pull now takes under ten seconds.

My humble opinion would be to agree but only if documentation is updated
and it's possible to build UDFs without also having to install all the
other Impala dependencies.  Can test building from that repo later this
week.
On Tue, Dec 13, 2016 at 1:23 PM, Jim Apple<EMAIL_ADDRESS>wrote:

I suggest this repo be eliminated. An impala pull now takes under ten
seconds.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cloudera/impala-udf-samples/pull/13#issuecomment-266819121,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGSrpDzp1yOYOpVk5DwbvN2dNnsvH8bRks5rHuKqgaJpZM4LFlrb
.

If I understand the conversion correctly, this change wasn't necessary because there was an intent to take integers as input.


CTRL + SHIFT + P not working in Firefox

Hey there
Just learend about Wrighter, love it so far!
The only downside, CTRL + SHIFT + P is the shortcut for opening a private Window in Firefox.
Maybe it could be possible to change or add another shortcut for Firefox-Users?
That would be amazing.
Thanks for your great work and keeping it open-source!

thanks, will be adding a seperate modal to configure shortcuts for actions.

thanks, i am looking forward to it ;-)


Added mailbox settings requests

Requests for getting mailbox settings and setting automatic replies

Thansk @JanVidarElven  for the contribution! I just used this in a demo at SPFest Seattle yesterday!


Update azure-pipelines.yml to include core-stage.yml template

This pull request updates the azure-pipelines.yml file to include the core-stage.yml template. This template is necessary for the Build stage and provides parameters for the Core environment.

pausing until the pipeline is approved.


Merges Master to Live. See commits for details.

Docs Build status updates of commit 0f2bcf3:
:clock10: Full build: the average full build time is 12 min(s) 32 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 0f2bcf3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md
:white_check_mark:Succeeded
View (sharepoint-ps)

skype/skype-ps/skype/Get-CsTeamsComplianceRecordingApplication.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsTeamsComplianceRecordingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Grant-CsTeamsComplianceRecordingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTeamsComplianceRecordingApplication.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTeamsComplianceRecordingPairedApplication.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTeamsComplianceRecordingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsTeamsComplianceRecordingApplication.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsTeamsComplianceRecordingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsComplianceRecordingApplication.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsComplianceRecordingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

teams/teams-ps/teams/Get-CsBatchPolicyAssignmentOperation.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsGroupPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsUserPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-Team.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsBatchPolicyAssignmentOperation.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsGroupPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsGroupPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Set-CsGroupPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 4abe699:
:clock10: Full build: the average full build time is 12 min(s) 32 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 4abe699:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md
:white_check_mark:Succeeded
View (sharepoint-ps)

skype/skype-ps/skype/Get-CsTeamsComplianceRecordingApplication.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsTeamsComplianceRecordingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Grant-CsTeamsComplianceRecordingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTeamsComplianceRecordingApplication.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTeamsComplianceRecordingPairedApplication.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTeamsComplianceRecordingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsTeamsComplianceRecordingApplication.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsTeamsComplianceRecordingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsComplianceRecordingApplication.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsComplianceRecordingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

teams/teams-ps/teams/Get-CsBatchPolicyAssignmentOperation.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsGroupPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-CsUserPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Get-Team.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsBatchPolicyAssignmentOperation.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsGroupPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Remove-CsGroupPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Set-CsGroupPolicyAssignment.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update An Item in Shopcart

As a [role]
I need [function]
So that [benefit]
Details and Assumptions

[document what you know]

Acceptance Criteria
Given [some context]
When [action taken]
Then [outcome observed]

PUT /shopcarts/{shopcart_id}/items/{item_id}


feat(shift_decider): put the gear in park when vehicle reaches the goal

Signed-off-by: lilyildiz<EMAIL_ADDRESS>Description
Closes  #1813
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

I added the autoware_state_  check to the beginning of the onTimer function and tested it with the sample vehicle and map.
https://user-images.githubusercontent.com/70379994/189301643-efbbf3c6-225e-4e99-beb7-c9df73549c62.mp4

LGTM
@yukkysaito @TakaHoribe could you check please

@TakaHoribe @brkay54 Can I merge this?

@lilyildiz Thank you for your nice work. Would you add a flag to enable/disable this feature? This feature is not suitable for some vehicles which, for example, have a long time for the gear transition. Default should be true (use this feature).

@TakaHoribe I defined the new flag in control.launch.py since the node did not have any param files loaded ( 67c32c31d1eec35bf730a12d054de4dcfc1569d6 ). Should I create a new param file for the shift_decider package or is it okay to leave it like this?

@lilyildiz Sorry to be late to request a change.
In the near future, parameters will be managed by yaml file in another repository since autoware.universe is not supposed to be forked to change parameters.
So could you add yaml file in shift_decider and tier4_control_launch packages and remove definition of park_on_goal in control.launch.py?


[CP] Cherry-pick 2.15 changelog updates

commit(s) to merge: 5331d12f3fd79ce61c588379e24c80d775fe3eab, a856655545e80c58262355e4e9c3af3d928cdfbe
merge instructions: clean merge
What is the issue: Several tweaks to CHANGELOG.md were landed in main after the branch-out.
What is the fix: N/A
Why cherrypick:  The risk is very small (just CHANGELOG.md changes) and it makes sense to be consistent across all release branches.
Risk: Very low.
Link to original  issue(s): N/A
/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @devoncarew

sgtm

approved

Merged to beta in 52519ea8eb4780c468c4c2ed00e7c8046ccfed41 (2.15.0-268.18.beta).


[Improvement] In SecureHadoopCatalogOperations.java checkif file is deleted

What would you like to be improved?
In SecureHadoopCatalogOperations.java in method removeFile check that delete actually works
How should we improve?
Check the return value of delete and log an error

Let me take care of it

@yuqi1129 I hope you have a good day today. Please review it.

@yuqi1129 I hope you have a good day today. Please review it.

Please look at your PR and I'm confused about the actual change you made.

@yuqi1129

@yuqi1129 I hope you have a good day today. Please review it.
Please look at the promotion and I'm confused about the actual change.

Existing changes have been made
File = new file (filePath);
if (file.exists()) {
file.delete ();
}
Here
   boolean isDelete = file.delete ();
  Deleted (!) {
    LOG.error ("Failure to delete file: {}", filePath");
  }

It was about adding this code.
However, for code-based consistency, I used Gradle-SpotLess to sort the code according to the rules, so there may be other changes as you checked. Did you understand?

Please take a look at at the code change.

Please take a look at at the code change. All you have done is just format the code.

The commit didn't apply properly
https://github.com/apache/gravitino/pull/4297/files
If you check here, you can see that I fixed the code to suit the issue.
If you look here, I posted PR after fixing the class, and the work I wanted to share and upload went up in one place.
It is correct that the code format has been changed as you saw, because it is a change that occurred because of Gradle-SpotLess.

This issue was resolved by #4297 by the way, perhaps the PR can be closed?

This issue was resolved by #4297 by the way, perhaps the PR can be closed?

sure ! closed please, Have a Good Time !

This issue was resolved in #4297.


[Feature Request] Add Note Name as Alias

Thank you for creating this excellent plugin, I just discovered it!
I would like to request the following:
Show the File Path in the suggestions and Automatically add the File Name as the Alias.
Example: I have several notes with the title "Resources" in my vault as shown here:

Right now, I don't know which Resource file is the correct one because no path is shown. If the File Path is in the suggestions, it will be easier to select the correct one.
Once I make a selection, the file path is shown in Reading View because there is no alias:

Please automatically add the File Name as the alias so that the file path is not shown in Reading View, like this:
[[Programming/Python/Resources|Resources]]

Hi, @helicos6 :)

Right now, I don't know which Resource file is the correct one because no path is shown. If the File Path is in the suggestions, it will be easier to select the correct one.

Please set Full to Description on suggestion.

Please automatically add the File Name as the alias so that the file path is not shown in Reading View, like this:

Please set ON to Suggest with an alias.

Hi @tadashi-aikawa
Thanks for your response.

Please set Full to Description on suggestion.

Yes, this worked.

Please set ON to Suggest with an alias

This works only for notes that have aliases defined using YAML.
If there are no defined aliases, I am not able to get the file name of the note added as the alias.
What is added: [[Programming/Python/Resources]]
My request: [[Programming/Python/Resources|Resources]]

@helicos6

If there are no defined aliases, I am not able to get the file name of the note added as the alias.

I got it. I'll add an option to work as you expected.

@tadashi-aikawa Thank you so much! I'm looking forward to it. 😃

Soon 👍

@helicos6
Released in v8.0.0-beta3 🚀
If you use BRAT, please confirm it. If not, please wait to release it as official, v8.0.0.

@tadashi-aikawa I installed v8.0.0-beta3 and toggled ON Suggest with an Alias, but the alias is not added for me.

@helicos6
Could you tell me the "New link format" setting?

@tadashi-aikawa I had it set to 'Absolute path in vault'.

The Alias works correctly when I set this to 'Shortest path when possible'.
I would prefer 'Absolute path in vault' if possible to make it work with Alias. But if that's too much trouble, no worries. Thanks for adding my request!

@helicos6
Thank you for your reply :)
Unfortunately, I am not going to fulfill your request because the user who set Absolute path in vault to New link format should expect that all internal links are as an absolute path in general.
Best regards.

But it would be possible to add an "Always insert a file name as an alias" option... 🤔

But it would be possible to add an "Always insert a file name as an alias" option... 🤔

Yes, that would be great! 😃

Hi, @helicos6 :)
I have released v8.0.0-beta9; it adds the "An excluded regular expression pattern from the displayed internal link" option. The option may resolve your following issue 🤔

Unfortunately, I am not going to fulfill your request because the user who set Absolute path in vault to New link format should expect that all internal links are as an absolute path in general.

Hi @tadashi-aikawa,
I currently have v8.0.0-beta10 installed but cannot find the "An excluded regular expression pattern from the displayed internal link" option.

Can you please share a screenshot?

@helicos6
Please see https://github.com/tadashi-aikawa/obsidian-various-complements-plugin/discussions/183.

@tadashi-aikawa Okay, I see the option now. I had to disable and enable the plugin.
Setting the regex to .+/ has the following effect:
[[Programming/Python/Resources]] changes to [[Programming/Python/Resources|Resources]] as desired.
However, this means I have to choose between the above or this change:
[[hoge(huga)]] will transform to [[hoge(huga)|hoge]]
The current implementation doesn't allow setting both options simultaneously.
If instead there was a Regex Find/Replace option, then both of the above (as well as far greater flexibility for other options) would be possible, like this:
Find: .+/(.+) (.+)
Replace: $1
Example result:
[[Programming/Python/Resources (Python)]] will transform to [[Programming/Python/Resources (Python)|Resources]]

Thank you for your confirming, @helicos6 :)

If instead there was a Regex Find/Replace option, then both of the above (as well as far greater flexibility for other options) would be possible, like this:

It is so cool! I'll replace the "An excluded regular expression pattern from the displayed internal link" option with your suggestion. (It is a breaking change, but the version is still beta👍 )

This option is for professionals😂 But highly customizable 👍

@helicos6
Released in v8.0.0-beta11 🚀
I hope you will be satisfied 🙏

@tadashi-aikawa It works perfectly now, thank you so much!
Do you have this so I can support you?

@helicos6
Cool!

Do you have this so I can support you?

I didn't have them, but I have created the "Buy me a coffee" button! I would be happy if you used it 😄

@tadashi-aikawa Something is wrong.

@helicos6
Thank you! Unfortunately, my account had been suspended. I sent an e-mail to the support team. Please wait for the follow-up information🙇

@helicos6
Released in v8.0.0 🚀
P.S. I still wait for the response from "Buy me a coffee" team. I'll inform to you after receiving their responses.

@helicos6
Sorry to keep you waiting! But we have some unfortunate news. "Buy me a coffee" team permanently banned my account without explanation or reason😢
As we don't want to spend any more effort on things that have nothing to do with development, we will only take your sentiments. Thank you!!

@tadashi-aikawa So sorry to hear that. Thank you for your efforts with the plug-in.


Use the AmplifyBackendDeployFullAccess policy in e2e tests to mirror the customer's dev environment

Description
Our e2e tests are currently using a different IAM policy than what we tell customers to use while using amplify-backend. We should use the same policy AmplifyBackendDeployFullAccess.
The hotswap test needs to be updated to also make every hotswappable change possible. (Currently only AppSync:Schema is tested)

Done in https://github.com/aws-amplify/amplify-backend/pull/768


Update Profile with Icinga2 Puppet Module rewrite

They just published the new Puppet Module
https://github.com/Icinga/puppet-icinga2
Old Version is available here:
https://github.com/Icinga/puppet-icinga2-legacy

Hooray! 🍾


Add instrumentation

The new Alertmanager is not instrumented yet.
We can collect what metrics we want to expose here.
@brian-brazil

I guess we can have a notification metric to see if notifications are successfully sent.

Basic instrumentation has been added in the meantime.


Add methods from_json and to_json

Matt's proposal for future implementations of methods:

from_json
to_json

For compatibility and integrations with other layers/systems/3rd part solutions.

Implementation in https://github.com/bieli/IoText-data-protocol/pull/28


File browser & selection: items don't appear unselected

When clicking on multiple file name, they end up all being highlighted.

This is a duplicate of #192.


Added optional rendering of code block titles

Hi,
I added something I put together for my notes website. It's an optional feature to render code titles for code blocks. The steps to enable them are:

add enableCodeBlockTitle: true to data/config.yaml
add title=<title> attribute to code block as demonstrated here with other attributes available in hugo.

An afterthought: Perhaps a little extra should be added to the documentation for setting the title via highlight shortcode and markdown code fences.

Everything seems to be in order. The only unresolved comment was the use of variables from the custom.scss file @jackyzha0. I looked into using ExecuteAsTemplate as you suggested (#149), and it did yield some results, but the seems to be some collisions :root, and the dark scope. I think swapping out the style sheets entirely using a script may be the solution there.

Everything seems to be in order. The only unresolved comment was the use of variables from the custom.scss file @jackyzha0. I looked into using ExecuteAsTemplate as you suggested (#149), and it did yield some results, but there seems to be some some collisions between :root and the dark scope. I think swapping out the style sheets entirely using a script may be the solution there.

ftr, separate syntax styling was added successfully.

pushed a few changes to master, do you mind bringing your branch up to date + resolving merge conflicts?

Had a delay there thanks to load shedding and a concern that I might have broken something. I now confirmed that it's not just my branch, but also yours (#154).
This is all ready for you to merge, if everything works well on your side.


igluctl: use Iglu Client to upload schemas to Server

Depends on https://github.com/snowplow/iglu-scala-client/issues/11
We want an Iglu Cleint to be the only one thing that knows how to communicate with Iglu Server, aware of endpoint, dialect, etc

Migrated to https://github.com/snowplow-incubator/igluctl/issues/17


Librouteros capsman fix

Description:
Related issue (if applicable): fixes #10189
Checklist:
If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
[ ] New dependencies are only imported inside functions that use them ([example][ex-import]).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

Hi @nicolaevladescu,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!


JSON sample values format incorrect or unclear

On the https://docs.microsoft.com/en-us/windows/terminal/customize-settings/startup#center-on-launch section, the initialPosition saalues should be corrected from this
"initialPosition": x,y, "centerOnLaunch": true, "launchMode": "default"
to this:
"initialPosition": "x,y", "centerOnLaunch": true, "launchMode": "default"
and also the other sample
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4da2bad9-1b85-abf2-db4a-1d3d5a9a75f7
Version Independent ID: a12dfff0-f5e7-606d-421d-59e01186ff89
Content: Windows Terminal Startup Settings
Content Source: TerminalDocs/customize-settings/startup.md
Product: dev-environment
Technology: windows-terminal
GitHub Login: @cinnamon-msft
Microsoft Alias: cinnamon

Fixed it. Good catch! Thanks @vectorkovacspeter !


Fix flakyness in RemoteStoreRefreshListenerTests

Description
Fix flakyness in RemoteStoreRefreshListenerTests -> testRefreshSuccessOnThirdAttemptAttempt
Related Issues
Resolves #8549
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I will need to rebase after #8547 is merged.

I will need to rebase after #8547 is merged.

https://github.com/opensearch-project/OpenSearch/pull/8547/ is merged. Please rebase.

Re-triggering precommit


Use TransportModeInfo

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#100  👈
#99
#98
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on  Graphite


Rust Version Mismatch Error During anchor build Despite Correct Version Installed

Issue: Rust Version Mismatch Error During anchor build
Description
This is a brand new project I setup using anchor init <project_name>. I encountered an issue when running anchor build in my Solana project. The build process fails with an error message indicating that the required Rust version is not satisfied, even though my system has the correct version installed.
Error Message
When running anchor build, I receive the following error:
error: package `solana-program v1.18.22` cannot be built because it requires rustc 1.75.0 or newer, while the currently active rustc version is 1.68.0-dev
Either upgrade to rustc 1.75.0 or newer, or use
cargo update -p<EMAIL_ADDRESS>--precise ver
where `ver` is the latest version of `solana-program` supporting rustc 1.68.0-dev

Expected Behavior
The build should proceed without errors, utilizing the correct version of Rust that is already installed on my system.
Actual Behavior
The build process fails, incorrectly detecting an older version of Rust (1.68.0-dev) despite having the correct version installed.
Environment Details

Rust Version: rustc 1.80.1 (3f5fd8dd4 2024-08-06)
Cargo Version: cargo 1.80.1 (376290515 2024-07-16)
Anchor Version: anchor-cli 0.30.1
Solana Version: solana-cli 1.17.25 (src:d0ed878d; feat:3580551090, client:SolanaLabs)
Operating System: macOS 14.1.2 (23B92)

Steps to Reproduce

Setup new project using anchor init <project_name> & cd into it.
Run yarn install & anchor build in the Solana project directory.
Observe the version mismatch error.

Attempted Solutions

Verified that the correct Rust version is installed.
Checked for .cargo/config and rust-toolchain files that might force an older version (none found).
Cleaned the project with cargo clean and attempted to rebuild.

Any guidance or assistance in resolving this issue would be greatly appreciated.

Also running into this, however the error message for me is slightly different with a different rustc version indicated:
error: package `solana-program v1.18.22` cannot be built because it requires rustc 1.75.0 or newer, while the currently active rustc version is 1.72.0-dev
Either upgrade to rustc 1.75.0 or newer, or use
cargo update -p<EMAIL_ADDRESS>--precise ver
where `ver` is the latest version of `solana-program` supporting rustc 1.72.0-dev

Rust version is coming from the Solana installation, see https://github.com/solana-labs/solana/issues/31428.
@bonedaddy yeah that work since it overrides your Solana version, but I'd also set Anchor to 0.30.1 because it includes some important fixes.
Duplicate of https://github.com/coral-xyz/anchor/issues/3012.

Thanks @acheroncrypto, this worked for me 🙌
Think the toolchain workaround is a bit hacky and might prevent you from using the latest features. Updating my Solana version, as recommended by @acheroncrypto, fixed my problem solana-install update, maybe you want to check this out as well?


Bluebird-specific extensions missing from native Promises

(This issue tracker is only for bug reports or feature requests, if this is neither, please choose appropriate channel from http://bluebirdjs.com/docs/support.html)
Please answer the questions the best you can:

What version of bluebird is the issue happening on?
3.7.2 (Although this isn't really Bluebird-version specific.)

What platform and version? (For example Node.js 0.12 or Google Chrome 32)
Nodejs v18.15.0 (Although I think these also apply up to and including the 24.xx.yy versions).

Did this issue happen with earlier version of bluebird?
Per the first note under the readme for Bluebird, if there are discrepancies in functionality between Bluebird and native promises, they should be reported to be upstreamed.

Bluebird's Promise.map is noted to already have comparable functionality being upstreamed. I didn't see it in said spec though: https://github.com/tc39/proposal-iterator-helpers
Also Promise.any is still missing per MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise#static_methods . I know it's relatively trivial to convert these into Promise.all calls, but this can be cumbersome when there are significant quantities of such calls, even if differences in exception handling are ignored.

I'm not sure what the issue here in bluebird is, Promise.map already has the native (async) iterator helper (as Readable#map in streams) in Node, Promise.any exists that MDN page is just outdated (please feel free to alter it MDN is a wiki not an authoritative reference) https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/any


auto-idler: cli task run check does not take post-rollout tasks in consideration

our autoidler checks if there are any commands running inside the cli pod. It does that with only showing commands that have a tty attached:
https://github.com/amazeeio/lagoon/blob/3e551c0b8d34bf49abec6ba9ca23b5243ec988dc/services/auto-idler/idle-clis.sh#L78
the idea was that the tasks running from the entrypoints (like the sleep, the cronjob commands, etc) are excluded from the check as they are running without tty and they are running all the time and would prevent the cli from being idled.
this all works, but unfortunately the post-rollout tasks during a lagoon deployment are also running without tty so they are not taken into consideration and it is possible that while a post-rollout task is running the cli auto-idler deletes the pod right away.
Two ideas:

try to force the post-rollout tasks also to be running in a tty (tried already, failed so far)
teach the auto idler somehow that it should not idle while a deployment is running (probably easier)

I've been looking at this recently, and it is possible to check if there are any processes outside of the entrypoints using pgrep -P 0 | tail -n +3 | wc -l | tr -d ' ' instead of ps --no-headers a | wc -l | tr -d ' '.
pgrep -P 0 finds any processes that aren't running off PID1
As oc rsh is used to access the pod as part of this check, it lists that as a process and also lists pid1 (tini), and so tail -n +3 is used to ignore those processes.
This results in any other process counts being returned.
Through testing though, I noticed that some post-rollout tasks are faster than others, and if the auto-idler hits the cli pod as it is between post-rollout tasks it will still idle the pod and cause the build to fail.
I did also test to see if checking if there are any builds in the running state for a given environment using oc -n "$NAMESPACE" get --no-headers=true builds | grep "Running", but if someone is running a task in the cli pod outside of the build, this won't get be picked up and the pod will be idled.
Would it be good to check both and where there is no running builds, and no running processes, then idle the pod?
I've done some testing of doing both checks in the auto-idler and can submit a PR for this if it is worth pursuing.


feat: compatiblity to stdlib v9, update pdk

hi @fraenki
shure :) - i wanted to find some time to maybe improve my work, for that reason i did not open one already.
Please let me know if there is anything more and thank you for the great work!

Merged, thanks!


Not possible to send mail from Roundcube as alias

The error in Roundcube when filling in the To: field is still present in v60.3 (since v60.2).
Application Error (700): Addressbook source (carddav_2) not found!
However, contacts can be found via the existing address books.
It is still possible to send an e-mail if you answer an email.
But if I try to send a new e-mail as alias I got the error:
Verbindungsfehler (Fehler beim Erreichen des Servers)!
Originally posted by @psychofaktory in https://github.com/ddavness/power-mailinabox/issues/82#issuecomment-1283102842

That's a strange one. Been playing around with aliases here and nothing out of the ordinary (you can send new mail as alias as long as you own that alias, otherwise it will naturally spew an error). Asking a few probing questions to see if I can get closer to the root of the issue:

The second error translates roughly to Connection error (failed to reach server)! Did you by any chance set Roundcube to German (just because it'd be weird if there happened to be a German error message in English)?
What's the distribution being used? Different versions of PHP could yield the error;
Have you seen anything strange during the setup process during the Roundcube step? (warnings, errors, setup time being abnormally long/short...)

The aliases were created as before:
As an admin, a new alias was created which then forwards to my mailbox.
In the Roundcube, the alias address was then stored as a new identity in the settings -> Identities.
When I sent a new email, I could then select the new alias as the sender and send it without errors.
Yes, Roundcube was set to German. That's probably why the error message was in German. Whereas the other error message mentioned appeared in English.
This distribution is used:
Operating System: Ubuntu 20.04.5 LTS
Kernel: Linux 5.4.0-131-generic
Architecture: x86-64
The box was installed in December 2021 with Ubuntu 20.04 LTS and Power-Mail-In-A-Box v55.1.
Since then, all available updates have been applied regularly.
During the installation, there were no warnings, errors or other anomalies (apart from the doveconf warnings already mentioned).

Did it stop working since v60.0?

Yes, exactly.

Anything in the logs that could give us any more useful info? (The log files are at the /var/log/roundcubemail/ folder)

Anything in the logs that could give us any more useful info? (The log files are at the /var/log/roundcubemail/ folder)

In the 'errors.log' there are a lot entries like this:
[31-Oct-2022 09:12:27 +0100]: <bo8q1m90> PHP Error: Addressbook source (carddav_2) not found! in /usr/local/lib/roundcubemail/program/include/rcmail.php on line 376 (POST /mail/?_task=mail&_unlock=loading1667203944401&_framed=1&_action=send)

I wonder where the 2 in carddav_2 comes from.
Question - when you go into Contacts on Roundcube webmail, do you see an extra addressbook? Does it happen to error?

do you see an extra addressbook other than these?

No, there are just the default adressbooks:

I can open all entries without getting an error message.

OK. That took me in the right direction!

"Standardadressbuch" was set to "Persönliches Adressboch". I changed it to "ownCloud (Kontakte).
"Empfänger ausgehender E-Mails speichern in" was set to "---". I changed it to "Gesammelte Empfänger".

Now I can sent Mails without an error again!

Ah, so finally we found the problem*
But we haven't found the cause of the problem. How did the update break this?

That's the question.
I didn't changed any settings manualy there since the update.
So something must have changed here with the update


Deduplicate kotlinOptions

Codecov Report

Merging #261 (a1ef6cb) into main (927851d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   74.30%   74.30%
=======================================
  Files          68       68
  Lines        3012     3012
  Branches      471      471
=======================================
  Hits         2238     2238
  Misses        513      513
  Partials      261      261

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Consider parsing models with binrw

Something I've noticed in PRs is that we all keep reimplementing the same read/write logic for models (#83, #84, #85, #114). I'd like to minimise this duplication by using binrw to describe the file format in a declarative fashion, making it trivial to support the multiple formats and to read and write to each of them.
I believe that this should be possible and that there aren't any showstoppers, but I could be wrong about this. @KerfuffleV2 is probably the relevant domain expert on parsing models right now - would appreciate your input!

I wouldn't really agree about the expert part, but I can tell you what I think.
About binrw, I actually already checked it out and commented briefly: https://github.com/rustformers/llama-rs/issues/79#issuecomment-1493303627
It basically wants to be using a file that's seekable, it didn't seem like it had first class support for stuff like memory mapping.
I'd also say I don't really like the derive macro style for parsers. It's great when the format aligns nicely with your structures, but I think it's hard to work with when there's a mismatch.
And if you commit to that sort of thing, you don't necessarily know until later on that there's going to be a problem because (presumably) it worked okay for your first parser or you wouldn't have stuck with it.
In that same thread I linked to, you can see the start of an attempt to port the llama-rs module loading to using nom parsing. I don't really like nom, but it feels like it's the best thing that's available right now. It's pretty flexible, basically lets you do what you need to without many restrictions.
Having to manually thread the parsed input is irritating but there are ways to avoid it a lot of the time and it's not something that'll actually stop you from doing what you want.
I also looked at combine but it uses very complicated types/traits and it seems like it's quite hard to do something like have a parser that can handle multiple types of thing. I actually tried to use that first for my pickle parsing and gave up.
nom is what I ended up using for repugnant-pickle. (It also has pretty good support for dealing with complete input like a mmaped file or streaming.)

It basically wants to be using a file that's seekable, it didn't seem like it had first class support for stuff like memory mapping.

The documentation states that

binrw reads data from any object that implements io::Read + io::Seek, and writes data to any object that implements io::Write + io::Seek. (Unseekable streams are also supported, but require a wrapper.) This means that data can come from memory, network, disk, or any other streaming source. It also means that low-level data operations like buffering and compression are efficient and easy to implement.

which seems fine to me. We'd just memory-map the file, wrap a std::io::Cursor, and let binrw work with the cursor.

I'd also say I don't really like the derive macro style for parsers. It's great when the format aligns nicely with your structures, but I think it's hard to work with when there's a mismatch.
And if you commit to that sort of thing, you don't necessarily know until later on that there's going to be a problem because (presumably) it worked okay for your first parser or you wouldn't have stuck with it.

I've generally had a good experience with them; I find a declarative structure much easier to parse through than parsing code where it's applicable. I think it's a worthwhile experiment to see if we can fit GGML/GGMJ/GGJT into binrw and if that makes the parsing any easier to understand.

Regarding nom etc: yeah that's pretty reasonable. nom is my go-to for parsing binary formats when binrw fails me, and while I agree it has some ergonomic complications (...for want of a monad...) it's fine for this kind of thing.
If binrw falls through, I'd suggest using nom and the abstract metadata structure you suggested in https://github.com/rustformers/llama-rs/pull/114#issuecomment-1500349178 .

which seems fine to me. We'd just memory-map the file, wrap a std::io::Cursor, and let binrw work with the cursor.

Sorry, I wasn't clear. That's what I was talking about when I said it didn't have first class support (not working with it directly, requiring a wrapper). I wasn't saying it couldn't work at all.

(...for want of a monad...)

Tell me about it! https://github.com/KerfuffleV2/mdoexperiments
Also, I wasn't just being modest when I said I wasn't a parsing expert. I honestly haven't done much parsing stuff with binary files and Rust. So maybe my lack of enthusiasm for binrw is just fear of the unknown.
I usually like stuff I can control more directly though.

If binrw falls through, I'd suggest using nom and the abstract metadata structure you suggested

The two things aren't really mutually exclusive. Could use binrw, nom, whatever just to parse specific file format metadata and use that to build the more abstract structure I mentioned. If it contains stuff like the storage entity where a thing is and what range it exists at, then no parsing would be needed to actually suck out the tensors (or grab a memory address as the case may be).

The ggml file format is really simple to parse. Every format has <20 .read_* calls.
Adding a 3rdparty library would make the code harder to understand.

The reason I'd like to investigate a declarative format is that it makes it really simple to see the differences between the formats, and to write code that can read/write them. You can see the data as it's laid out in the file without having to read through all of the parsing code, at least in theory.

I use borsh before. Super clean, just struct, but very specific.
I try binrw but the last time i try i can't handle dynamic field size that was specific by other fields (need to cast it first with fancy fn). // maybe just me and maybe fine for our case.
so i try take a look at nom which can parse each field for but i can't figure out how to chain it to next step yet (like we can do in serde).

finally i tun out of time and end up parse it myself hard coded 😅 shame on me.

@iacore has submitted #114 which provides a non-binrw solution. I'm going to close this until we decide what to do with that PR to ensure that people don't work on this.


Move templates and styles from few core components to theme

I moved template and styles from core Overlay, OfflineBadge, Loader and ThankYouPage to related components in theme. I left only base logic in core.

@Aekal thank  you for taking care of it ;)
One thing - please leave the logic on overlay (it works the same everywhere and overriding it is an edge case) and check if both catalog and default templates are working properly with your changes

I think we should move styles from overlay core to theme, because sometimes we may need to change color etc. I also had to move
  beforeCreate () {
    document.documentElement.classList.add('no-scroll')
  },
  destroyed () {
    document.documentElement.classList.remove('no-scroll')
  }

from core to theme because:

no-scroll class should be theme specific
beforeCreate was causing an error in console when switching to catalog theme.

Everything works fine after these changes on each theme.

@filrak Please take a look at my last changes :)

@aekal it's ok but please update overlay component in Vue-catalog. It relies on core template. Ok?

Great, thanks :)


Suggest to remove property HttpURLConnection_SetBeforeConnect

HttpURLConnection_SetBeforeConnect property (http://bit.ly/1MsSrGw) warns if setFixedLengthStreamingMode(), setChunkedStreamingMode() or setRequestMethod()
are invoked after the URLConnection was made.
But there is no formal documentation in Java API that says that setRequestMethod() should be called before conneciton is made.
Only documentation for setFixedLengthStreamingMode() and setChunkedStreamingMode() exists.
We'd suggest removing this property as we cannot find any supportive evidence from either Java API and actual projects that it could help to review any real faults in programs.

@owolabileg what do you think?


how to upload a file?

use repos.createFile?

I found it. https://github.com/mikedeboer/node-github/blob/master/api/v3.0.0/gitdata.js


JAVA_HOME variable was erased after <eval "$(jenv init -)">

OS: Mac OS 10.13.4 (17E199)
jenv version: 0.4.4
I tested with JDK 1.8&10

eval "$(jenv init -)" before exporting JAVA_HOME

eval "$(jenv init -)"
export JAVA_HOME=`/usr/libexec/java_home -v 1.8`

>$ echo $JAVA_HOME
>$ /Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home

eval "$(jenv init -)" after exporting JAVA_HOME

export JAVA_HOME=`/usr/libexec/java_home -v 1.8`
eval "$(jenv init -)"

>$ echo $JAVA_HOME
>$ <blank> #JAVA_HOME was erased!

Some softwares which need JAVA_HOME don't work such as apache-maven.

That is the right behavior.
You can use specific jenv plug-in for exporting Java home for specific
tools like maven.
Or use the export plug-in to export JAVA_HOME according the JDK use with
jenv
Le jeu. 12 avr. 2018 08:45, chamhaw<EMAIL_ADDRESS>a écrit :

Some softwares which need JAVA_HOME don't work such as apache-maven.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gcuisinier/jenv/issues/197#issuecomment-380696324,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIQhD_D7W9NsVIEFYW_kF4Vo1x3IgvHks5tnvfygaJpZM4TROHc
.

@gcuisinier I'm sorry to read the official website only. It works well now thanks to README.md.

No problem.
I should probably add this on the website explicitly
Le jeu. 12 avr. 2018 11:02, chamhaw<EMAIL_ADDRESS>a écrit :

@gcuisinier https://github.com/gcuisinier I'm sorry to read the
official website only. It works well now thanks to README.md.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gcuisinier/jenv/issues/197#issuecomment-380731290,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIQhNUzFJs-ZP1sOjonZqkn-xRIgoDvks5tnxg7gaJpZM4TROHc
.


Fixed api.md not containing the correct information about href

While playing with https://github.com/ddanier/django-git-lfs I noticed the documentation for the href attribute is a bit off. If you point git-lfs to /objects it will produce /objects/objects. So the correct URL may not contain "objects". This commit fixes this documentation issue.

Ah good catch.  I'd leave the trailing slash off too :)


ValueType for .NET framework 4.6.1

I'm using ScottPlot with .NET Framework 4.6.1.
The method GetMouseCoordinates will return System.ValueTuple which is introduced in .NET framework 4.7 and I can't compile my program now. Is there a workaround available for the method?

https://docs.microsoft.com/en-us/dotnet/api/system.valuetuple?view=net-6.0&viewFallbackFrom=netframework-4.6.1

Hi @softempire,
You can install the System.ValueTuple package from NuGet https://www.nuget.org/packages/System.ValueTuple in your .NET 4.6.1 app and your program should compile as expected.
Good luck!
Scott


The Debug section needs an updated in relation to priority based based batch scheduling

It is no longer possible to isolate a job in its own batch group, with the enablement of priority based based batch scheduling.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cb08fb04-94d5-ef25-8162-a0d79f5ee70a
Version Independent ID: 6d43b4b7-cc2e-49bc-564a-5eb5eacefa84
Content: Debug a copy of the production database - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/database/dbmovement-scenario-debugdiag.md
Service: dynamics-365-cross-app
Product: ****
Technology: ****
GitHub Login: @laneswenka
Microsoft Alias: laswenka

Bug 774087 has been logged to address this issue.

We have already covered how to debug Batch in case of PBS in Priority-based batch scheduling


Basic support for Hot Code Replacement in debugged JVM

This PR adds the possibility to modify and compile code, when an application is run in a debug mode, and to have these changes visible and taken into account by the debugged VM without restarting the application. This feature can be turned on/off (right now it's turned off by default). User can decide whether files containing compilation errors should be skipped. Stack frames affected by changes can be automatically dropped. Sometimes users don't like automatic dropping frames after HCR and they prefer to do that manually (see HCR in IntelliJ). Right now there's added also such a possibility. On the other hand it's a question whether it should be available, if we'll know it can cause problems. Therefore, it may be removed in the future, if the HCR with automatic dropping frames would be much more reliable. There are also added several integration JUnit tests.
Note that HCR is limited by JVM's support for replacing classes. Its goal is to allow to experiment with the code inside methods/blocks rather than to develop the whole application in the interactive mode. Changes of methods' signatures etc. don't work - similarly to other HCR implementations from Eclipse or other IDEs.
The implementation is inspired by the HCR support for Java. Scala debug target, threads etc. don't extend the default Java/JDI model and build their own one. Therefore, they are skipped when processing events by various Java-focused managers.
There's added ScalaHotCodeReplaceManager which implements HCR support using the Scala model. Every ScalaDebugTarget has its instance of manager which is also the listener waiting for events related to changed resources. When we get an event about changed class files, we get byte arrays containing new versions of these files and replace the old ones in VM. After this operation it's needed to rebind frames (optionally also drop the obsolete ones) and to refresh breakpoints.
Each from several added tests contains a fragment where the code is modified and recompiled. To ensure that all events and messages are correctly propagated after the additional incremental build, it was needed to use Thread.sleep with 500 millis. I know it's quite ugly solution but it seems to work well and there are not many such tests.
There are serious reasons why this implementation is called the basic support:

Automatic dropping frames is based on the information which frames are marked as obsolete.

We get this information after performing HCR but it can cause problems. According to the comment from Eclipse's HCR implementation for Java, JVM is faulty when there are frames rendered as obsolete. Therefore, in Java implementation they try to find affected frames and drop them before performing HCR. We should do the same thing because VM sometimes crashes after HCR and some additional operations. This is the serious blocker. Anyway even current implementation can be quite helpful in many situations. Except JUnit tests it was used to debug e.g.some multithreaded application using futures.

There's also another problem. After performing HCR sometimes already existing breakpoints behave strange. I had situations where from time to time I was getting a JDI event for the line breakpoint with the different location than the line specified for this breakpoint (sometimes it was one line before or after the expected one). I was investigating this for a while but didn't figure out what to do with that. Also I wasn't able to reproduce such a behaviour in tests. It's something, what should be checked once again after the addition of the new approach to drop affected frames. In case of problems it's always possible to recreate given frame manually, drop to the above frame and go to the expected breakpoint once again. Note: it's sometimes hard to hit breakpoints in Scala IDE even without HCR (they quite often are nondeterministic from the end-user's point of view of). Hence, it's not so simple to test this. It's not possible to fix everything, which basically is not related to this particular feature, but is also used when debugging.

Dialogs shown when replacing classes is not supported by VM or fails don't contain buttons to terminate or restart debug session. Currently there's only an adequate message.

  THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.
 NO OTHER SOFTWARE CODE OR MATERIALS ARE A CONTRIBUTION.

@dragos @sschaef Could you take a look?

ok to test

add to whitelist

After EE is merged, this contains some merge errors.

I'll rebase it tomorrow.

I assume someone will look at Jenkins (to check what causes slowdowns) or will increase time limits. Lately all PRs were failing because of that.

@dragos already fixed it

retest this please

The build for Luna succeeded (Total time: 29:09.817s) and the build for Kepler has been aborted at its very end (Build timed out after 30 minutes).

retest this pleaase

I just increased the timeout to be 3x the average successful build. If all fails, I'll set an absolute timeout value. It seems the eval expression tests have bumped the build time well above the previous times.

The build didn't start. Let me check whether I can run it by myself.

retest this please

I just reviewed the functionality.
The only ting I have to say about this is:

In the future I'm going to add the semantic dropping frames before HCR (to avoid VM crashes). Right now I'm not sure how to process deltas and how to extract helpful information, but I will investigate this.

Maybe this question gets solved when I look in more detail to the code, but why is it possible right now to replace a nested def (def inside def) but not a private def (def inside class)?

@sschaef Do you mean the body or the whole def (its signature and so on)?
Def inside class works, when you change only the body. At least in my test cases.
If you change also the signature, probably all cases will fail. There's a dialog with an error message shown.

On 04/14/2015 12:31 PM, Michał Pociecha wrote:

@sschaef https://github.com/sschaef Do you mean the body or the
whole def (its signature and so on)?

I meant the signature. I can change the signature as I will as long as
the def is nested.

A few minor comments, otherwise I'm as excited as @sschaef!
One comment regarding spurious errors. These could be related to our thread-unsafe use of the JDI calls. As described in 1002160, which should eventually be fixed and make the debugger way more reliable.

Would you like to have corrections in the separate commit (for easier reviewing) or can I add them to the second commit?

Create a new commit.

@dragos @sschaef That's it. I've already taken into account all your remarks.

Great, LGTM.


How to use coroutines in grpc-python server

I want the request to execute in a coroutine in grpc-python server，what is the usual plan？gevent or others？

As @yashykt mentioned https://github.com/grpc/grpc/issues/21716#issuecomment-597898429, GitHub is not the best place for questions. Please consider post questions on StackOverflow with "grpc" tag.
We are working on gRPC AsyncIO stack, and it is currently experimental. Here is the design proposal. We will update the documentation (https://grpc.github.io/grpc/python/grpc.html) once v1.28.0 is released.
Also, in our experimental folder, there is a init_gevent method to patch gRPC, but we do not recommend to use it. We hope the Python asynchronous libraries can converge to AsyncIO one day.

As @yashykt mentioned #21716 (comment), GitHub is not the best place for questions. Please consider post questions on StackOverflow with "grpc" tag.
We are working on gRPC AsyncIO stack, and it is currently experimental. Here is the design proposal. We will update the documentation (https://grpc.github.io/grpc/python/grpc.html) once v1.28.0 is released.
Also, in our experimental folder, there is a init_gevent method to patch gRPC, but we do not recommend to use it. We hope the Python asynchronous libraries can converge to AsyncIO one day.

@lidizheng I will wait the release, and post questions on StackOverflow next time, thank you!

@lidizheng I will attention the release, and post questions on StackOverflow next time, thank you!


reset submod to dev head

Resets the submodule head and attempts to fix our issues with the submodule
REMS-602

fix worked for me!


New windows install initialized with wrong model

Using the windows install and then running it, you get an error as the default model in the config file is different from the one downloaded by the installer (downloaded: Meta-Llama-3-8B-Instruct-IQ3_XS.gguf, config file: ./models/Meta-Llama-3-8B-Instruct-Q6_K.gguf)
It should be the same to avoid error.

Should be fixed now, thanks for the head's up!


Remove verbose prints from CameraServer on Linux due to being printed every second

Verbose prints were looking like this, with (camera name) is no video capture device being printed once per second (in both the editor and project):
Loading resource: res://polyhaven/gray_rocks_arm_1k.jpg
Using present mode: Enabled
OBS Virtual Camera is no video capture device

OBS Virtual Camera is no video capture device

OBS Virtual Camera is no video capture device

OBS Virtual Camera is no video capture device

We could alternatively find a way to print the message only once per device name, but it would be more involved. I can look into doing this if it'd help significantly with troubleshooting webcam-related issues.

Why not one of the ERR_PRINT_ONCE/WARN_PRINT_ONCE/ERR_PRINT_ONCE_ED macros? I doubt many people have more than one webcam, and at least printing these once may help debugging?

Thanks!


Extract 714 xbrl

Overview
closes #3813
closes #3814
closes #3815
What problem does this address?
We don't currently extract XBRL tables for the FERC 714 data. This code adds the capability to do so.
What did you change?
pudl/extract/ferc714.py

Add _csv suffix to csv-specific extraction functions/variables.
Rename csv-specific encoding dictionary to FERC714_CSV_ENCODING
Add TABLE_NAME_MAP_FERC714 dictionary
Add a function called create_raw_ferc714_xbrl_assets to reference the raw xbrl tables in the FERC 714 SQLite db and call it.
Add a function called raw_ferc714_xbrl__metadata_json to make an asset for the metadata table

pudl/io_managers.py

Upgrade the FercXBRLSQLiteIOManager to accommodate more than just ferc1
Add a ferc714_xbrl_sqlite_io_manager function

pudl/settings.py

Add xbrl_years functino to the Ferc714Settings class to be able to access XBRL years.
Remove comments about not processing the XBRL data.

pudl/metadata/sources.py

Update the FERC714 working partitions.
Remove comments about not processing XBRL data.

Testing
How did you make sure this worked? How can a reviewer verify this?
Load each of the raw assets via and make sure they contain the expected years:
defs.load_asset_value("raw_ferc714_xbrl__table_name")

# To-do list
- [x] Update the [release notes](https://catalystcoop-pudl.readthedocs.io/en/nightly/release_notes.html): reference the PR and related issues.
- [ ] Run `make pytest-coverage` locally to ensure that the merge queue will accept your PR.
- [x] Review the PR yourself and call out any questions or issues you have
- [ ] For minor ETL changes or data additions, once `make pytest-coverage` passes, make sure you have a fresh full PUDL DB downloaded locally, materialize new/changed assets and all their downstream assets and [run relevant data validation tests](https://catalystcoop-pudl.readthedocs.io/en/nightly/dev/testing.html#data-validation) using `pytest` and `--live-dbs`.
- [ ] For bigger ETL or data changes run the full ETL locally and then [run the data validations](https://catalystcoop-pudl.readthedocs.io/en/nightly/dev/testing.html#data-validation) using `make pytest-validate`.
- [ ] Alternatively, run the `build-deploy-pudl` GitHub Action manually.

Unit test failures have something to do with this snipit I changed in io_managers.py:
        ferc_settings = context.resources.dataset_settings.get_datasets()[
            self.db_name.replace("_xbrl", "")
        ]

The pytest test/unit/io_managers_test.py::test_ferc_xbrl_sqlite_io_manager_dedupes function does not like this.
UPDATE:
I fixed this by changing this snipit to:
        ferc_settings = getattr(
            context.resources.dataset_settings, self.db_name.replace("_xbrl", "")
        )

and again to add the new years in the settings yml files.

The reason I didn't do this is because I think it will break the transforms and I didn't want to merge it into main that way.

The reason I didn't do this is because I think it will break the transforms and I didn't want to merge it into main that way.

hm this is a good point... but I think in this context because the only existing transforms are based on the csv extracted tables they will be fine. but still i hadn't put it in context that this was only the extraction so i will renege on this suggestion.

@zaneselvans thank you for that suggestion! I just had to add one more fixture for ferc714_xbrl_extract and it was good to go.

mmm getting a unit test failure seemingly related to timeseries. Is timeseries cleaning part of the extraction or transformation phase @zaneselvans?
        for method in "tubal", "tnn":
            # Impute null values
            imputed0 = s.impute(mask=mask, method=method, rho0=1, maxiter=1)
            imputed = s.impute(mask=mask, method=method, rho0=1, maxiter=10)
            # Deviations between original and imputed values
            fit0 = s.summarize_imputed(imputed0, mask)
            fit = s.summarize_imputed(imputed, mask)
            # Mean MAPE (mean absolute percent error) is converging
>           assert fit["mape"].mean() < fit0["mape"].mean()
E           assert 0.030191300830775987 < 0.024084802339886784
E            +  where 0.030191300830775987 = mean()
E            +    where mean = 0    0.002769\n1    0.001304\n2    0.011850\n3    0.002106\n4    0.008777\n5    0.007833\n6    0.135690\n7    0.001992\n8    0.118109\n9    0.011482\nName: mape, dtype: float64.mean
E            +  and   0.024084802339886784 = mean()
E            +    where mean = 0    0.010499\n1    0.011460\n2    0.010525\n3    0.005897\n4    0.007852\n5    0.015753\n6    0.054820\n7    0.022598\n8    0.045421\n9    0.056023\nName: mape, dtype: float64.mean

test/unit/analysis/timeseries_cleaning_test.py:109: AssertionError

Oh, the timeseries issue is probably a rare stochastic failure -- it happens once in a blue moon, probably having something to do with the seed being used for the random number generator. If you re-run the unit tests I suspect they'll pass just fine.

Oh, the timeseries issue is probably a rare stochastic failure -- it happens once in a blue moon, probably having something to do with the seed being used for the random number generator. If you re-run the unit tests I suspect they'll pass just fine.

That is wild and also strangely comforting. I'm glad I didn't try and preemptively figure this out...haha

I spent a bunch of time at some point hunting down all the RNG initializations and tried to give them fixed seeds in the tests so we always get the same outputs, but I must have missed one somewhere, and it bites us every so often. It just didn't seem like it was worth continuing the hunt because it's so infrequent.

Especially in the unit tests, whenever there's something like this that seems totally out of left field and unrelated to what's being changed my first instinct is just to re-run the tests to see if it's real. Doesn't take much time or effort, and often it works.


XEP-0320: Use of DTLS-SRTP in Jingle Sessions - Missing setup attribute

Description
I’ve been doing some interoperability testing with Conversations and I've noticed that (after enabling DTLS-SRTP in Jitsi) Jitsi doesn’t include a setup attribute in the fingerprint element. That attribute is required.
<fingerprint hash="sha-1" xmlns="urn:xmpp:jingle:apps:dtls:0">6E:A5:07:0C:AE:7A:0C:0A:91:66:93:25:A7:B1:52:DA:3F:D2:7D:65</fingerprint>

Current behavior
Jitsi doesn’t include the setup attribute.
Expected Behavior
Include a setup attribute. Possibly set to actpass (I honestly don’t know enough about DTLS to know what that actually means; But assuming it was actpass kinda worked.
Possible Solution
Include the setup attribute; Otherwise the receive party would have to assume it; which can’t be good.
Steps to reproduce
Open Jitsi; Change encryption to DTLS (from ZRTP); establish audio call with Conversations. Dump XML stream somehow.

the last time I checked you could actually omit the role. That was in 2012 though and interop between jitsi and chrome kinda worked (the jitsi video engine was having issues)


Failed to load resource: net::ERR_CONNECTION_REFUSED

i  cloned the project, then i tried npm start all the projects, i got PORT not recognised so i changed it to set PORT=4001 react-app-rewired start. is it the reason it is refusing connect

In sub-app1/package.json
change scripts:
FROM
"scripts": {
"start": "PORT=4001 react-app-rewired start",
"build": "react-app-rewired build",
"test": "react-app-rewired test",
"eject": "react-app-rewired eject"
},
TO
"scripts": {
"start": "set PORT=4001 && react-scripts start",
"build": "react-app-rewired build",
"test": "react-app-rewired test",
"eject": "react-app-rewired eject"
},
AND
In sub-app1/.env
#REACT_APP_CONTENT_HOST=http://localhost:4001
PORT:4001
NOTE: Follow the same process for sub-app2,give the port numbers accordingly.


Add validation of focus location

Description

Checks the validity of the focus location before showing the genome browser image
Checks the validity of the location url parameter before showing the genome browser image

Examples to try while testing:

Use a chromosome name that doesn't exist for this species
Make the start parameter greater than the end parameter
Omit a colon or a dash in the location

Related JIRA Issue(s)
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-314
Deployment URL(s)
http://validate-url-location.review.ensembl.org

Should this PR prevent non-existent location being saved as previously viewed objects?


PD: Thermocycler profile steps validation

Background
As a user I would like to get guidance on how to fill out a profile form - this is the second of 2 tickets. this includes all fields for the Profile Steps section.
Acceptance Criteria
Ranges
TC Block

The range of accepted temperatures is 4 - 99 degrees Celsius (inclusive)

TC Lid

The range of accepted temperatures is 37 - 110 degrees Celsius (inclusive)

Volume

The range of acceptable volume is 10uL - 100 uL (inclusive)

Duration (seconds)

Max of 60 (inclusive)

Masking

The TC block & lid temperatures should accept values with one decimal point (ie, 89.9). However, these fields do not take other special characters.
The volume field does not accept any decimal points or other special characters
Duration (minutes and seconds) fields do not accept decimal points or other special characters
Cycle fields do not accept decimal points or other special characters
No field (except the profile step name field) take letters

Mandatory
Profile settings

Volume field
Lid temperature
Profile steps
Cycles field
Temperature field
Duration field(s) ((If both are empty, display warning on the second field))
Ending hold
Block temp if active
Lid temp if active

Behavior

Masking and ranges can operate on the form field level
Hitting the 'save' button should blur all pristine mandatory fields to force the user to fill them in
---- If the seconds form field for duration is filled in but the minutes form field is pristine, presume minutes is 0

Design
https://zpl.io/aXvRLOM
This ticket only covers the following field validation:

This issue is closed via several PRs across the team

Shoot, reopening do to lack of masking in minute/second fields


Docs

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Please check if the PR fulfills these requirements

[ ] E2E Tests for the changes have been added  via Cypress
[ ] Meaningful rspec tests have been added
[ ] Docs have been added / updated

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: henrixapp:x: Rasteter, JaninaRasteter, Janina seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@henrixapp I will definitely not review 1,375 files 🙈
This is probably for the initial setup of the docs page, right?
What about getting the minimal example of the docs page working in this PR? (by the way nice job, Docusaurus looks great 👍) Then, we would have the initial setup going and with a short Readme on how to edit and deploy this, we could always extend the docs in the future.

@henrixapp I will definitely not review 1,375 files 🙈

Hmm, I am not sure, why you are tagging me here..., lets check who is the real owner of this branch/folder:
>  git shortlog -sn -- docs
   236  hungrywords
    26  Rasteter, Janina
     7  Fabian Kontor
     6  Henrik Reinstädtler

So I own a measly 6 out of a total of 275 commits in this folder and I am currently only contributing to mampf on a voluntary, open source and unpaid basis.
Yes, I started this branch a year and a three quarters ago, before I left my position at Mampf.
But no, I am not in charge anymore.
I will now leave my thoughts below.

This is probably for the initial setup of the docs page, right?

Well, it used to be. The decision was made to fully migrate the old wiki into the repository (and executed by @hungrywords).
Core Idea was to have three sections for teachers, students and developers in the navbar and use the docusaurus techniques to link them properly. Images (png) are stored in LFS, which allows us to minimize the core size of the git project.

What about getting the minimal example of the docs page working in this PR? (by the way nice job, Docusaurus looks great 👍) Then, we would have the initial setup going and with a short Readme on how to edit and deploy this, we could always extend the docs in the future.

The minimal version is already deployed at https://mampf-hd.github.io/mampf/ and there is an auto publisher already in place as gh-action (in the overview of the files changed like the second  change that's popping up). This gh-action probably needs some modernization. I would recommend not to start new by throwing away all of @hungrywords work and have a minimal example, but it is up to you 😉 .

So I own a measly 6 out of a total of 275 commits in this folder and I am currently only contributing to mampf on a voluntary, open source and unpaid basis.
Yes, I started this branch a year and a three quarters ago, before I left my position at Mampf.
But no, I am not in charge anymore.

Sorry, instead of just looking at the top seeing you as the one who opened this PR, I should have looked closer at the commits ;) And yeah of course, you're not obliged to do anything here anymore, but every contribution is appreciated and I thought that you might have wanted to keep working on the PR if (if you had really worked on most of the commits, which is however not the case as I just found out).

I would recommend not to start new by throwing away all of @hungrywords work and have a minimal example, but it is up to you 😉 .

I thought of the docs page deployed from this PR here as the "minimal example" for the documentation. Should have rather coined it as "first docs setup" as I have just realized how much sites there are already filled in the docs, especially related to the "instructions for editors". So, it's not really a "minimal" example anymore. And no, I will definitely not get rid of @hungrywords work in the documentation.
What's next
There's probably no way around reviewing all 1,375 files here and I will do this in the future, but consecutively in small chunks, e.g. only 100 files a day. So, it will take a while. But I think it's worth merging this PR in the end, so that we can continue to work on the docs in hopefully smaller PRs by then 😅

Thanks a lot for the efforts with the docs! We will close this PR as we are currently focusing on other things like shipping new features. But don't worry, the branch won't be deleted and the respective docs GitHub.io page will stay online. We've also included a note in the wiki.
It's just that with the limited time of people working on MaMpf, we won't be able to keep the docs up-to-date. They are still very useful, e.g. pages like the quiz editor can be sent to people who have difficulties setting up new quizzes. It might also serve as a good link to be sent to adjudicators, should we promote MaMpf in some funding program. And the closed PR can still be opened again in the future.


Add SoundCommand Class & Remove Extensions from Require

Made the sound commands simpler and more generic (They can support mp3 files btw)
Removed the extension from the require calls as it's actually more robust: Example

Why was this closed?

I closed it as it wasn't ready to be merged, there were some issues I had missed

The sound player fix: If a sound file is less than a multiple of 1 second (2.5seconds) the bot closes the connection and leaves the voice channel before the sound is complete, meaning the full audio file is not run.

The sound player fix: If a sound file is less than a multiple of 1 second (2.5seconds) the bot closes the connection and leaves the voice channel before the sound is complete, meaning the full audio file is not run.

A bit of a tip for the future: you can convert an existing PR into a draft to have it remain open but also make it not able to be merged. :)

Closing due to inactivity and the fact that the codebase has switched over to ECMAScript modules.


Various style fixes

This PR resolves various style and performance issues detected by deepsource.

Unused imports
.format where f-string is possible

LGTM, thanks @matmair


resolve.fallback not working with resolve.alias ?

I have the following project structure:
a
a/node_modules/x
a/node_modules/b
a/node_modules/b/node_modules/y
a/node_modules/b/node_modules/c

a is my main project and I want to make changes in my local c project and reflect in a
I used resolve.alias to point c to my local dir.
Some of c dependencies are located in a, and some in b, and when running webpack I'm getting the following errors:
Module not found: Error: Cannot resolve module 'x' in c
Module not found: Error: Cannot resolve module 'y' in c
Using resolveLoader.fallback fixed my babel loader errors, but i'm still having issues with "regular" modules that I require in c.
I tries using resolve.fallback, but it did not fix the errors.
I did find a way to workaround this, by setting specific aliases to every module c was dependant on that was not installed directly under its node_modules (for example: x and y)
Why isn't resolve.fallback working in this case?
This could be related to #784

My mistake, everything works.

Can you explain what you did wrong?


Custom element with custom attribute inside , two-way data bind not working

I'm submitting a bug report

Library Version:
<EMAIL_ADDRESS>

Node Version:
4.4.7

NPM Version:
3.10.3
I've created custom element to wrap  jquery date-range-picker.

custom-element-template:
<template>
    <label for="datePicker">${description}</label>
    <input id="datePicker" type="text" class="form-group"
           date-range-picker="from.two-way: from; to.two-way: to"
           placeholder="Time Frame" />
</template>

the custom-element-VM
import {customAttribute, inject, bindable} from 'aurelia-framework';
import $ from 'jquery';
import 'jquery-ui';
import 'datejs';
import 'plugins/daterangepicker.jQuery';

@customAttribute('date-range-picker')
@inject(Element)
export class DateRangePicker {
  @bindable from
  @bindable to

  constructor(element) {
    this._element = element;
  }

  attached() {

    let settings = {
      presetRanges: [
        { text: 'Today', dateStart: 'today', dateEnd: 'Tomorrow' }
      ],
      onClose: function (startDate, endDate) {
          this.from = startDate;
          this.to = endDate;
      }
    };
    $(this._element).daterangepicker(settings);
  }

  detached() {
    $(this._element).daterangepicker('destroy');
  }
}

@inject(Element)
export class BoDateRangePicker {
  @bindable description
  @bindable showLastSixMonth
  @bindable showLastYear
  @bindable showGetAll
  @bindable rangeMinDate
  @bindable rangeMaxDate
  @bindable rangeLimitInMonths
  @bindable from
  @bindable to
  constructor(element) {
    this._element = element;
  }
}

and from the parent view i call it like that:
 <bo-date-range-picker from.two-way="criteria.FromDate"
                                              to.two-way="criteria.ToDate"
                                              description="Time Frame">
                        </bo-date-range-picker>

the parent VM properties (criteria.FromDate and criteria.ToDate) their value not changed based on the selection in the datepicker..
Any idea?

@eliavmaman please put together a reproduction using https://gist.run/?id=7542e061bc940cde506b
you'll have to use script tags in the index for the non-aurelia stuff like jquery, jquery-ui, etc.
Once we have a repro we can help you debug it.

fixed the problem.
the problem was at
onClose: function (startDate, endDate) {
          this.from = startDate;
          this.to = endDate;
      }

the this keyword is not this in the function.
always remember to use the arrow function sysntex =>
just change to that
onClose:(startDate,endDate)=>{
//this, will be the view model instance
}


Updating README

This Change remove the .zsh on the plugin activate example, cause with the .zsh at the end the plugin won't be activated

Thanks!


App doesn't understand only for diet:vegan and diet:vegetarian

If diet:vegan or diet:vegetarian are set to only, the corresponding buttons are not selected. This is bad, because if a user then clicks on them to activate them, the tag is replaced by yes, losing the existing information. Example: https://www.openstreetmap.org/node/7920795000
There may be a similar problem with takeaway (and maybe delivery), although I couldn't test this yet. only is already supported here, but they can also take a time specification in opening_hours format.
In general, any boolean tag could be affected. I'd suggest to either allow editing an additional free-form value for those tags, or as a quick solution to simply disable the buttons if it contains unsupported values.

I have fixed the field to treat all non-no values as positive, just like the iD editor does. Not ideal, but there's a raw tags editor if needed.

Maybe make a small table with the diet forms on the left and the values selectable, like this:
Diets:
| vegetarian | no | yes | only |
| vegan | no | yes | only |
| halal | no | yes | only |
...
Maybe accessible through a menu, just like opening hours open a dialog.


Separate dart-define from project.pbxproj

Use case
I am developing add2app project.
I pass the value used to dart-define.
In Android, the value defines in gradle.properties. This is simple.
In iOS, the value defines as User-Defined in project.pbxproj. This is a complication.
I want to pass the value more simply. I want to pass the value so that I don't make any changes to project.pbxproj.

Proposal
I want a solution.

@sakebook
Do you have a concrete proposal as how would you like to get it fixed / implemented ? Because just providing I want a solution seems to be very vague. Also, support platforms like StackOverflow or flutter reddit help page could also be a place where you can ask for a solution.

@darshankawar

Do you have a concrete proposal as how would you like to get it fixed / implemented ?

Yes, I have an image.
I am thinking about something like this.
Modify the Run Script generated by podhelper.rb.
Add a static file. This is an assumption that flutter clean will not disappear.
Name the file, for example, flutter_xcode_dart_defines.sh .
source "${SRCROOT}/flutter_xcode_dart_defines.sh"

In iOS, the value defines as User-Defined in project.pbxproj. This is a complication.

Can you please elaborate by giving an example as how is this complex ? Is it based on that you have to deal with multiple files to make changes ?
Is there a way to directly use the shell script you can create, run it locally which will make the changes for you ?

@sakebook
You could set it explicitly either in an xcconfig or in your Xcode project itself:
DART_DEFINE[config=test]=foo
DART_DEFINE[config=production]=test

@darshankawar
I created xcconfig with by configurations.
This is only added to the config file, it seems easy to change even with a shell script.
https://github.com/sakebook/flutter-issue-90581/commit/5676fc7f5f6bad9d504f035bd82dbc63b34d3c57

@darshankawar
Yes. I created 2 xcconfig files.
In a real case, the value handled in the configuration of the release would be secret values.
So, I think to override or modify for Release.xcconfig.
For example, I think a shell script like the following
cat <<EOF >> Config/Release.xcconfig
DART_DEFINES = ENCODED_SECRET_VALUES
EOF

Keeping it open for further insights from team on this proposal.
/cc: @jmagman

Since the goal is just to have the setting outside the complexity of the pbxproj file, the xcconfig solution described above seems like the best solution; anything custom would add a tooling complexity, and likely end up with basically the same format as an xcconfig anyways.
Given that, closing.


deviantART broken image files

The downloader works great most of the time, but once in a while it downloads broken images. The pictures can not be opened with any program and are in some cases just a few bytes big. If I download these images manually they are completely fine.
The files look like this:

I haven't ever encountered this ancient problem, and we're up to RipMe 1.5.5 nowadays, but I'm still on 1.5.2.
Window$ 7 Ultimate SP1 x64, Oracle Java SE 8 Update 144 x64, I've ripped dozens of entire galleries (which still are on the disk) and every so often sync my favs folders, no real problems.

Yeah the dA ripper still has a lot of problems but I think we can probably close this one at this point. I've never seen it.