WIP: Change Electron to use window.open

This is a work in progress for changing the Electron API to use window.open. This is so child windows are created in the same process as their parent, therefore allowing access to each others JavaScript context.
WIP because features string doesn't work yet, meaning tests also fail.

@BenLambertNcl I guess this means that it is looking like a viable option to have ContainerJS adopt a more OpenFin-like model instead?

One thing to be wary of is that the electron behaviour you get from window.open is different when the sandbox is enabled:
https://github.com/electron/electron/blob/master/docs/api/sandbox-option.md
I must admit, I hadn't turned it on in my own investigations!

@ColinEberhardt Yeah I think we can use the OpenFin process model with this change. I think its much nicer this way, as we give the user a choice, rather than forcing them into 1 specific process model. As for the link I hadn't seen that! It seemed to have all of the methods it mentioned in the documentation on the object when I tested it. Will double check though.

@ColinEberhardt From further research, it seems that we might need to give up some functionality using window.open due to the lack of window options that are unsupported when creating a window. The list that I have made of options that do not work with window.open are:

maxWidth
maxHeight
minWidth
minHeight
alwaysOnTop
backgroundColor
center
frame
maximizable
minimizable
resizable
show
skipTaskbar
transparent

Some of these can be set after the window has opened (such as resizable, minimizable etc.) but some like show and frame, only work when passed into the window constructor. It seems like some of these should work though, with references to show here as well as references to max/min width and others here, but none do, even in the electron api demos.
Not sure if it is worth continuing with this? Seems odd that these options are used in the source code and they do not work, could be a bug in Electron?

I must admit, I'm not too surprised - the MDN page for window.open does discourage its usage.
It might be worth parking this.
My preference is that you try to create a consistent process model between containers, but for the initial implementation I'm not too fussed about what that actually is.
Take the easiest path!

Ok I will stick to the "Each window as a separate process" like we were doing initially then. Ill close this PR for now, but we can always reopen it if we see value in using this later.


adding easing function name in list

on this page,
http://doc.babylonjs.com/babylon101/animations
in the list of ease functions, BezierCurveEase is not mentioned yet it appears in an example below.
cheers

Fixed!
thanks for the feedback :)


No file matches path, but path is not what was specified

See the output from this run:

Compare line 4 to line 30 and see that the path is different. Is this a bug, or am I doing something wrong?
The step YAML looks like this:
      # Check to see if the test results file exists so that we can condition the publishing of the test results:
      - name: Check whether or not the test results file exists
        id: test-results-verification
        if: always() # Even if previous steps have failed
        run: |
          if test -f "${{ runner.temp }}/junit.xml"; then
              echo "::set-output name=file-exists::true"
          fi

      # Publish the test results using an action from the marketplace:
      - name: Generate test report
        uses: dorny/test-reporter@v1
        if: ${{ steps.test-results-verification.outputs.file-exists == 'true' && (success() || failure()) }} # Even if some tests failed
        with:
          name: Test results
          path: "${{ runner.temp }}/junit.xml"
          reporter: java-junit

(Note the second step is conditioned on the first step finding the file, and the second step is executing, so we know that the file is on disk where specified).

I ran into a very similar problem.
You might want to check the answer provided here:

You need to specify path as wildcard
https://github.com/dorny/test-reporter/issues/175#issuecomment-1153262496

Specifying the file using the wildcard pattern in the most basic way solved it. I ended up changing the explicit file path to "**/TestResults.xml".
I'm not sure whether this will work four you, but maybe you get some inspiration on how to solve it.


Failed dependency without ResultCode

In live streams found following failed dependency without ResultCode:
"DependencyTypeName": "Http",
"DocumentType": "RemoteDependency",
"Duration": "PT0.382S",
"ResultCode": "",
"Success": false,
Version of Microsoft.ApplicationInsights.DependencyCollector is 2.3.0-beta1. Could you please investigate/track with telemetry for which failed dependencies SDK fails to resolve ResultCode?

Closing old issue. Dep collection is now mostly from diagnosticsource callback.


error: no visible @interface for 'UIView' declares the selector 'stringByEvaluatingJavaScriptFromString:' [self.webView stringByEvaluatingJavaScriptFromString:jsCallBack];

Meteor 1.2 works fine
Meteor 1.3 Update gives error
I have used raix:push plugin in meteor project. It works fine in meteor 1.2 but in meteor 1.3 it gives error when compiling code in xcode. But it works fine in android.
.meteor/local/cordova-build/platforms/ios/meteor1.3/Plugins/com.phonegap.plugins.PushPlugin/PushPlugin.m:274:23: error: no visible @interface for 'UIView' declares the selector 'stringByEvaluatingJavaScriptFromString:'
[self.webView stringByEvaluatingJavaScriptFromString:jsCallBack];

can you give 3.0.3-rc.2 a go? it uses the latest cordova plugin,
the json config should still work - but the cordova plugin requires a setting in mobile-config.js https://github.com/raix/push/tree/fix-device-dependency-deprecate-json-format#config

Thanks @raix! The linked readme says   SENDER_ID: 12341234. Looks like it needs to be a string "12341234".

bumped to 3.0.3-rc.3 - @lorensr have you tested both? (the android config dictionary seems to be using string - but not sure how strict cordova is in handling this)

Oh, no


make sure that basebackup-mode metadata is set for all base backups

Adds the basebackup-mode metadata to all base backup metadata

Adds the basebackup-mode metadata value to all base backup metadata

Resolves: #543
Why this way
It was simple

Thank you for this PR !


Feature/modify layout n routes

This branch contain some changes:

Modify Layout Top Navbar
Modify Routes Dashboard
Add named routes

Now we can call url with name alias
url('name-alias-routes')
or set active url by name
with step

Add params name in controllers/file. Example in controllers/dashboard.js
From header or similar view can use
class=(name === 'name-alias-of-route') ? 'active' : undefined

For more information about named-route you can check at:
https://github.com/alubbe/named-routes

The changes LGTM, only need to resolve the conflict.

Well done. Just one small tweak: Remove CREATE ACCOUNT. No one should be able to self-register

Oh I see another PR that removes CREATE ACCOUNT. Ok can merge. @haydarai @rohmad-st


Loosen the version constraint of ldap3 to avoid dependency conflicts

Hi, ldapdomaindump locked the version constraint of ldap3 as ldap3==2.5.1, which leads to a troubling scenario that its direct downstream project impacket has to lock ldap3==2.5.1.
What makes the situation worse is that the downstream projects ['adidnsdump-1.1.0', 'bloodhound-0.7.0', 'boofuzz-0.1.5']  of impacket are also forced to lock this specific version ldap3==2.5.1 to avoid conflicts.
Could you please loosen the version constraint of ldap3?
Benefit of this is that users using both of impacket and ldap3 can upgrade their third party libraries in a timely manner to reduce technical debts.
Solution
The dependency trees of your project and affected downstream projects are shown as follows.
Taking the version constraints of upstream and downstream projects into comprehensive consideration, you can

Loosen ldap3 to be ldap3>=2.5.1.
Try to add an upper bound for ldap3’ version constraint, according to your compatibility.

@   Please let me know your choice. I can submit a PR to fix this issue.
Thanks for your attention.
Best,
Neolith

Dependency tree-----
ldapdomaindump-0.9.1
| +-dnspython(version range:*)
| +-future(version range:*)
| +-ldap3(version range:==2.5.1)

Direct downstream project:
impacket-0.9.19
| +-flask(version range:>=1.0)
| | +-click(version range:>=5.1)
| | +-itsdangerous(version range:>=0.24)
| | +-jinja2(version range:>=2.10.1)
| | | +-markupsafe(version range:>=0.23)
| | +-werkzeug(version range:>=0.15)
| +-ldap3(version range:==2.5.1)
| +-ldapdomaindump(version range:*)
| | +-dnspython(version range:*)
| | +-future(version range:*)
| | +-ldap3(version range:==2.5.1)
| +-pyasn1(version range:>=0.2.3)
| +-pycryptodomex(version range:*)
| +-pyopenssl(version range:>=0.13.1)
| | +-cryptography(version range:>=2.3)
| | +-six(version range:>=1.5.2)
| +-six(version range:*)

Indirectly affected downstream projects:
adidnsdump-1.1.0
| +-impacket(version range:*)
| | +-flask(version range:>=1.0)
| | | +-click(version range:>=5.1)
| | | +-itsdangerous(version range:>=0.24)
| | | +-jinja2(version range:>=2.10.1)
| | | | +-markupsafe(version range:>=0.23)
| | | +-werkzeug(version range:>=0.15)
| | +-ldap3(version range:==2.5.1)
| | +-ldapdomaindump(version range:*)
| | | +-dnspython(version range:*)
| | | +-future(version range:*)
| | | +-ldap3(version range:==2.5.1)
| | +-pyasn1(version range:>=0.2.3)
| | +-pycryptodomex(version range:*)
| | +-pyopenssl(version range:>=0.13.1)
| | | +-cryptography(version range:>=2.3)
| | | +-six(version range:>=1.5.2)
| | +-six(version range:*)
| +-ldap3(version range:==2.5.1)

bloodhound-0.7.0
| +-dnspython(version range:*)
| +-future(version range:*)
| +-impacket(version range:>=0.9.17)
| | +-flask(version range:>=1.0)
| | | +-click(version range:>=5.1)
| | | +-itsdangerous(version range:>=0.24)
| | | +-jinja2(version range:>=2.10.1)
| | | | +-markupsafe(version range:>=0.23)
| | | +-werkzeug(version range:>=0.15)
| | +-ldap3(version range:==2.5.1)
| | +-ldapdomaindump(version range:*)
| | | +-dnspython(version range:*)
| | | +-future(version range:*)
| | | +-ldap3(version range:==2.5.1)
| | +-pyasn1(version range:>=0.2.3)
| | +-pycryptodomex(version range:*)
| | +-pyopenssl(version range:>=0.13.1)
| | | +-cryptography(version range:>=2.3)
| | | +-six(version range:>=1.5.2)
| | +-six(version range:*)
| +-ldap3(version range:==2.5.1)
| +-pyasn1(version range:>=0.4)

boofuzz-0.1.5
| +-attrs(version range:*)
| +-backports-shutil-get-terminal-size(version range:*)
| +-click(version range:*)
| +-colorama(version range:*)
| +-flask(version range:<2,>=1.0)
| | +-click(version range:>=5.1)
| | +-itsdangerous(version range:>=0.24)
| | +-jinja2(version range:>=2.10.1)
| | | +-markupsafe(version range:>=0.23)
| | +-werkzeug(version range:>=0.15)
| +-future(version range:*)
| +-impacket(version range:*)
| | +-flask(version range:>=1.0)
| | | +-click(version range:>=5.1)
| | | +-itsdangerous(version range:>=0.24)
| | | +-jinja2(version range:>=2.10.1)
| | | | +-markupsafe(version range:>=0.23)
| | | +-werkzeug(version range:>=0.15)
| | +-ldap3(version range:==2.5.1)
| | +-ldapdomaindump(version range:*)
| | | +-dnspython(version range:*)
| | | +-future(version range:*)
| | | +-ldap3(version range:==2.5.1)
| | +-pyasn1(version range:>=0.2.3)
| | +-pycryptodomex(version range:*)
| | +-pyopenssl(version range:>=0.13.1)
| | | +-cryptography(version range:>=2.3)
| | | +-six(version range:>=1.5.2)
| | +-six(version range:*)
| +-ldap3(version range:==2.5.1)
| +-psutil(version range:*)
| +-pydot(version range:*)
| | +-pyparsing(version range:>=2.1.4)
| +-pyserial(version range:*)
| +-six(version range:*)
| +-tornado(version range:<5,>=4.0)

Hi, I'm aware of this issue, but still waiting for a release of ldap3 that is compatible with ldapdomaindump, see #19
Once that is out I can loosen the requirement

@dirkjanm Thank you for your feedback.
I just noticed a similar issue #19.
Waiting or your new release.
BR,
Neolith


[Dropdown] Cannot use inline dropdown in a  element

See: http://jsfiddle.net/6murnr7n/26/

its not about the dropdown . the space is for the p tag not dropdown .
you should style the p tag with display: inline or inline-block to get them together .
good luck .

What space are you talking about?
And from my expectation, a  and a  should behave the same in this case (block display). My temporary fix is using a  with 's style.
See: http://jsfiddle.net/6murnr7n/32/

of course the p tag should behave like that . but in your case you can just style the p tag.
or wrap your box with div instead of p . its much easier and more elegant
check this out : http://jsfiddle.net/kfbsgsmy/5/
good luck .

 tags don't support block level elements

The P element represents a paragraph. It cannot contain block-level elements (including P itself).
http://www.w3.org/TR/html401/struct/text.html#h-9.3.1

If you really wanted to use
 just convert everything to span
http://jsfiddle.net/gk1od8w5/

  Show me posts trending

    today

      Today
      This Week
      This Month

    and do something

 tags don't support block level elements.

Thanks, it's the answer I wanted.


Transaction lock when trying to delete a table that doesn't exist.

A transaction lock occurs when trying to delete a table that doesn't exist.
To reproduce, simple "Create" a table in the "Up" method and "Delete" a fake table and the real table in the "Down" method.
Considering this hangs the database and pretty much locks is, I'd consider this pretty high.

Not reproducable !
Gives following error
DROP TABLE [dbo].[Unexisting]
The error was Cannot drop the table 'dbo.Unexisting', because it does not exist or you do not have permission.
Please advise


🐛 VS Code extension can't run in vscode dev container

Environment information
We use devcontainer for development, and want to replace eslint with biome.

What happened?

Try to install biome extension
Display error message: The 'biomejs.biome' extension is not available in Visual Studio Code for Alpine Linux 64 bit.

Expected result
It works in dev container.
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

Hey @zfben,
Thanks for opening this issue.
Since v2.0.0, we no longer build platform-specific distributions of the extension, so you should be able to load the extension inside the container.
However, to be able to run Biome on Alpine, you'll most likely have to wait for Biome 1.4 (shipping early next week), which will introduce Alpine-compatible binaries.
I'll close the issue for now, but feel free to create a new one if you're still encountering this issue in the future.

I suppose this is an enhancement that now we can land now, since we're able to ship a binary for Alpine.


sap_general_preconfigure: use tags instead of role parameters for limiting the role scope

We can use apply: to promote tags to tasks in dynamically included files, like in https://github.com/sap-linuxlab/community.sap_install/blob/fa606d9e2ec484fbc35cbb99dfc4a83f109666fd/roles/sap_swpm/tasks/pre_install.yml#L33
Advantages:

Get rid of many parameters
Introduce the ability to skip one or more steps of SAP notes without having to specify the remaining steps

Solved in PR https://github.com/sap-linuxlab/community.sap_install/pull/653.


Spin off domed as a separate repository

The domed package for manipulating DOM objects is totally generic, and not specific to SoSSim. In the long run, it should be spun off as its own project/repository, and eventually be published in PyPI. Once in PyPI, it can just be imported to SoSSim like any other Python package. However, as long as domed is still changing frequently, it is more practical to keep it here, to be able to test the changes without the detour to PyPI.

An alternative approach is to spin it off now, but keep a copy of the files here. Then, the development/testing can be done in this project, by changes can be published for access by other projects.
Before publishing, some documentation on domed is needed, to go into that repo. Probably also some small example would be good to publish there. For publishing to PyPI, the flit package seems very practical.

The repo has been created but not yet populated.
To choose between the PyPI version and the local version, a flag could be provided to build.py indicating which version to use. This will then affect if domed is put into packages or into files in the pyconfig.toml file.

domed now exists as a separate repo, and is published on PyPI. A new flag to build.py makes it possible choose whether to use the local copy (default) or the published one.


app_message mismatch  error when stress test is performed

Hi Team,
I performed stress test with my device as Requester and i2c simulator as SPDM Responder.
SPDM emulator(https://github.com/DMTF/spdm-emu/tree/main) runs on i2c simulator.
With that test, I run into following issue.

Application message is given to libspdm for encryption
msg code 0x80 not found!!!  libspdm_send_spdm_request[ffffffff] msg <unknown>(0x80), size (0x4): 0000: 01 80 00 02  smbus: >TX> 0F 42 13 01 09 08 C8 06 FF FF FF FF BD 05 34 00 11 D4 BA 97 ED 27 40 D0 1D 4D 91 4B 67 D3 5E 5E 3A ED 08 70 A8 13 B5 F8 4A 1D 92 98 17 50 77 07 DF DB 8D 88 9D 94 A1 7E 85 C8 4B A8 19 71 2B E1 38 EB 69 7F D2
We dont wait for response meanwhile another application request is given to libspdm for encryption
msg code 0x80 not found!!!  libspdm_send_spdm_request[ffffffff] msg <unknown>(0x80), size (0x4): 0000: 01 80 00 02  smbus: >TX> 0F 30 13 01 09 08 C9 06 FF FF FF FF BE 05 22 00 2E 43 F9 2C 99 85 A9 E4 BE C8 10 AE B1 1E 09 72 04 0C 29 9D 40 10 B6 FC 4E FD 2B 7D 4E 20 70 F2 30 85 8D
At this point we get a series of response from SPDM Emulator for previous requests sent.
smbus: <RX< 12 0F 45 00 01 08 09 80 06 FF FF FF FF BD 05 38 00 D9 88 80 6A 99 87 EA 7C AB 92 46 F9 55 DC 0B 8A DE 57 E8 48 19 2E 69 26 5E 30 4D 1B 90 17 21 43 2D 40 D5 B7 BE AA 54 BF 6D 73 C2 D1 1E 51 EF F6 8C F4 3B 3D F2 DB F2 02 smbus: <RX< 12 0F 06 00 01 08 09 50 B4 BB   smbus: <RX< 12 0F 2D 00 01 08 09 C1 06 FF FF FF FF BE 05 1F 00 92 A2 FF C1 D3 D8 2F 06 00 FB A4 44 75 D0 2F 95 AF 0D D2 59 01 59 26 33 B7 0F A0 A3 5B A2 34 93  libspdm_decode_secured_message - 0x80010005  libspdm_receive_spdm_response[ffffffff] app_message mismatch
From this point for all the response messages app_message mismatch error continues. However, the SPDM Emulator continues to take the request and provide the encrypted response.

Questions:

As discussed earlier in other issue (https://github.com/DMTF/libspdm/issues/2544) we don't have compulsion for synchronous request/response yet why we see app_message mismatch error?
Once any response decryption fails should requester be starting session again ? or will it be able to continue to operate using same session ? We dont have any documentation on this provided.

Thanks,
Prithvi A Pai

Can you please add your inputs ? @steven-bellock

0x80010005 / LIBSPDM_STATUS_INVALID_MSG_FIELD is probably coming from https://github.com/DMTF/libspdm/blob/f6558cc7da31ccc882a3bf6a2b4a53f6b8551b45/library/spdm_secured_message_lib/libspdm_secmes_encode_decode.c#L489-L494
Are you using MCTP and possibly sending messages out-of-order? Note that, currently, libspdm_decode_secured_message does not support out-of-order decryption. Ie, the internal sequence number is incremented by 1 and if the encrypting endpoint does not use the same sequence number in the message then that is flagged as an error.

or will it be able to continue to operate using same session ?

According to the SPDM specification

The application phase ends when the HEARTBEAT requirements fail, or with an END_SESSION message, or with an ERROR message of ErrorCode=DecryptError.

So if a Responder sends  DecryptError then the session is terminated. However if the Requester fails to decrypt the Responder's message then it's up to the Requester whether it considers the session terminated or not.

@steven-bellock  Thanks for your reply.
Yes, I am using MCTP and sending messages in async way. However, even if message is sent sequentially and we don't get the response for one of the message as a Requester what is the way to handle it ?
What are the options available for Requester in this case ? As you mentioned one method is to terminate and restart new session.

0x80010005 / LIBSPDM_STATUS_INVALID_MSG_FIELD is probably coming from
https://github.com/DMTF/libspdm/blob/f6558cc7da31ccc882a3bf6a2b4a53f6b8551b45/library/spdm_secured_message_lib/libspdm_secmes_encode_decode.c#L489-L494
Are you using MCTP and possibly sending messages out-of-order? Note that, currently, libspdm_decode_secured_message does not support out-of-order decryption. Ie, the internal sequence number is incremented by 1 and if the encrypting endpoint does not use the same sequence number in the message then that is flagged as an error.

or will it be able to continue to operate using same session ?

According to the SPDM specification

The application phase ends when the HEARTBEAT requirements fail, or with an END_SESSION message, or with an ERROR message of ErrorCode=DecryptError.

So if a Responder sends DecryptError then the session is terminated. However if the Requester fails to decrypt the Responder's message then it's up to the Requester whether it considers the session terminated or not.

@steven-bellock  is this limitation of the library ?
Spec does not mention NOT supporting out of order decryption.

Is there any plan to support out of order decryption ? We may run into packet drop/delay in response for a particular packet while receiving the next packets. In real environment this is bound to happen. Re-establishing session each time would be a costly operation.

Is there any plan to support out of order decryption ?

Maybe? I see an issue filed so it's on the books. If it is supported then it would probably be disabled by default and then libspdm would allow the Integrator to enable it and specify the size of the window in which sequence numbers can be out-of-order. In addition there would probably be an option on whether libspdm would tolerate completely unsent sequence numbers.

Closing the issue as we have issue created.
Thanks a lot @steven-bellock for your timely response and suggestions


Updated Common Components Dependency

Issue #: /bcgov/entity#4085
Description of changes:

Updated Common Components Dependency.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Looks good. Please add the current release to the ticket. Thx.

done, thanks!


improve performance

Improve performance of finding unique classes.

Any metrics?

No metrics. But I could feel the tests got significantly faster, because .find() finishes once it found a unique element instead of .filter() which tests the whole list of selectors for uniqueness even if it found one instance.

@vwochnik ok, I have to test this though, and measure it. Not sure when I will find time for this. Probably during next 2 weeks.

Or if any of the other contributors have time to test/measure this, will be great.

Why do you need to measure a change from .filter() to .find()? It's always faster because once it found a result, it skips the rest. If you have dozens of classes on the <html> element for instance, it will be much faster. For others, it will not give any boost.

@vwochnik yep, I agree, codewise the diff its obvious, but still I would like to test before just merging it.

Ok. The branch with the new combinations algorithm contains a test which can be used for this kind of thing because it has a few classes.

npm test on master: 8 tests complete (142 ms)
npm test on patch-3: 8 tests complete (131 ms)
Not representative though.

I have ported the test suite to performance.js and here are some more representative values:
The current master branch with all other changes merged in:
ID x 810 ops/sec ±4.75% (71 runs sampled)
Class x 818 ops/sec ±2.40% (74 runs sampled)
Classes x 543 ops/sec ±2.56% (74 runs sampled)
Classes x 198 ops/sec ±3.35% (68 runs sampled)
Tag x 463 ops/sec ±3.43% (70 runs sampled)
Tag x 452 ops/sec ±3.04% (74 runs sampled)
Tag x 333 ops/sec ±3.15% (71 runs sampled)
Attributes x 1,048 ops/sec ±2.70% (73 runs sampled)
Fastest is Attributes

This patch-3 branch:
ID x 893 ops/sec ±4.65% (75 runs sampled)
Class x 903 ops/sec ±2.37% (78 runs sampled)
Classes x 588 ops/sec ±2.36% (79 runs sampled)
Classes x 217 ops/sec ±3.47% (73 runs sampled)
Tag x 518 ops/sec ±2.36% (76 runs sampled)
Tag x 491 ops/sec ±2.60% (79 runs sampled)
Tag x 366 ops/sec ±3.02% (75 runs sampled)
Attributes x 1,153 ops/sec ±2.96% (78 runs sampled)
Fastest is Attributes

@vwochnik thx.

Thank you very much! Can you please publish a new version?

@vwochnik sure, I was waiting the CI to finish.

done.


Posterior initialization with image prior

Normally the default position is for the initial posterior value for a parameter to be taken from the prior, unless the model defines a different method for choosing this.
However in the case of an image prior, the voxelwise value is not used for the initial posterior - instead the existing default prior is used, as if there was no image prior.
It would seem better for the voxelwise value to be used both for the prior and the initial posterior.

Fixed in Git, for next release


improve POC diagram

VF3 -> VF5 (L2) on VLAN10
VF4->VF5 (L3) routing between VLAN22 and VLAN20
Remote -> VF5 (L3 VXLAN)

done, see https://github.com/opiproject/opi-evpn-bridge/blob/main/README.md


HADOOP-17125. Using snappy-java in SnappyCodec

See https://issues.apache.org/jira/browse/HADOOP-17125 for details.
Offline discussed with @dbtsai and submitted this based on #2201.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
33m  4s
trunk passed

+1 :green_heart:
compile
25m 59s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
21m 36s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
3m 14s
trunk passed

+1 :green_heart:
mvnsite
2m 10s
trunk passed

+1 :green_heart:
shadedclient
23m 22s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 14s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m  9s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 16s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 38s
branch/hadoop-project no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  6s
the patch passed

-1 :x:
compile
1m  6s
root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javac
1m  6s
root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
compile
1m  0s
root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-1 :x:
javac
1m  0s
root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-0 :warning:
checkstyle
2m 20s
root: The patch generated 1 new + 151 unchanged - 5 fixed = 152 total (was 156)

+1 :green_heart:
mvnsite
1m 24s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m 20s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 35s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
findbugs
0m 19s
hadoop-project has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 18s
hadoop-project in the patch passed.

-1 :x:
unit
0m 42s
hadoop-common in the patch failed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

146m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2297

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 205df60c0f1e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9960c01a25c

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

compile
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/1/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javac
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/1/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

compile
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/1/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

javac
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/1/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/1/artifact/out/diff-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/1/testReport/

Max. process+thread count
402 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 36s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 46s
trunk passed

+1 :green_heart:
compile
19m 28s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
17m  8s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
3m 41s
trunk passed

+1 :green_heart:
mvnsite
2m  1s
trunk passed

+1 :green_heart:
shadedclient
20m 48s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 14s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 10s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 15s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 37s
branch/hadoop-project no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  4s
the patch passed

-1 :x:
compile
1m  4s
root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
cc
1m  4s
root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
golang
1m  4s
root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javac
1m  4s
root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
compile
0m 56s
root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-1 :x:
cc
0m 56s
root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-1 :x:
golang
0m 56s
root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-1 :x:
javac
0m 56s
root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.

-0 :warning:
checkstyle
2m 21s
root: The patch generated 1 new + 151 unchanged - 5 fixed = 152 total (was 156)

+1 :green_heart:
mvnsite
1m 24s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
13m 48s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 36s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
findbugs
0m 19s
hadoop-project has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 18s
hadoop-project in the patch passed.

-1 :x:
unit
0m 40s
hadoop-common in the patch failed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

125m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2297

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle cc golang

uname
Linux 6a174de3a925 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9960c01a25c

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

compile
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/2/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/2/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

golang
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/2/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javac
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/2/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

compile
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/2/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/2/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

golang
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/2/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

javac
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/2/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/2/artifact/out/diff-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/2/testReport/

Max. process+thread count
413 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m  4s
trunk passed

+1 :green_heart:
compile
21m 25s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
19m 19s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
3m  2s
trunk passed

+1 :green_heart:
mvnsite
2m  7s
trunk passed

+1 :green_heart:
shadedclient
21m  6s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 13s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m  7s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 12s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 38s
branch/hadoop-project no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  2s
the patch passed

+1 :green_heart:
compile
18m 38s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
cc
18m 38s
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 36 new + 127 unchanged - 36 fixed = 163 total (was 163)

+1 :green_heart:
golang
18m 38s
the patch passed

+1 :green_heart:
javac
18m 38s
the patch passed

+1 :green_heart:
compile
16m 51s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
cc
16m 51s
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 29 new + 134 unchanged - 29 fixed = 163 total (was 163)

+1 :green_heart:
golang
16m 51s
the patch passed

+1 :green_heart:
javac
16m 51s
the patch passed

-0 :warning:
checkstyle
2m 41s
root: The patch generated 1 new + 151 unchanged - 5 fixed = 152 total (was 156)

+1 :green_heart:
mvnsite
2m  1s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m 25s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 12s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m  9s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
findbugs
0m 32s
hadoop-project has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 32s
hadoop-project in the patch passed.

-1 :x:
unit
9m 32s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 55s
The patch does not generate ASF License warnings.

177m 51s

Reason
Tests

Failed junit tests
hadoop.io.compress.snappy.TestSnappyCompressorDecompressor

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2297

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml cc findbugs checkstyle golang

uname
Linux c9432386914d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9960c01a25c

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/3/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/3/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/3/artifact/out/diff-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/3/testReport/

Max. process+thread count
3059 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

The only test failure in
TestSnappyCompressorDecompressor.testSnappyDirectBlockCompression

, I guess it's because in SnappyDirectBlockCompression, the compressedByteBuffer is in read mode already, so we don't need to change it to read mode in the decompressBytesDirect().

@dbtsai Yeah, let me look at it today. Hope to pass all tests soon.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
28m 15s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 47s
trunk passed

+1 :green_heart:
compile
20m 32s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
19m 46s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
3m 26s
trunk passed

+1 :green_heart:
mvnsite
2m  7s
trunk passed

+1 :green_heart:
shadedclient
24m 59s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  6s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 19s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 37s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 35s
branch/hadoop-project no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 12s
the patch passed

+1 :green_heart:
compile
25m 24s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
cc
25m 24s
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 20 new + 143 unchanged - 20 fixed = 163 total (was 163)

+1 :green_heart:
golang
25m 24s
the patch passed

+1 :green_heart:
javac
25m 24s
the patch passed

+1 :green_heart:
compile
21m 26s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
cc
21m 26s
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 29 new + 134 unchanged - 29 fixed = 163 total (was 163)

+1 :green_heart:
golang
21m 26s
the patch passed

+1 :green_heart:
javac
21m 26s
the patch passed

-0 :warning:
checkstyle
3m 15s
root: The patch generated 1 new + 151 unchanged - 5 fixed = 152 total (was 156)

+1 :green_heart:
mvnsite
2m  4s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
18m  0s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  5s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 10s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
findbugs
0m 29s
hadoop-project has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 28s
hadoop-project in the patch passed.

+1 :green_heart:
unit
11m  6s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 53s
The patch does not generate ASF License warnings.

226m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2297

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml cc findbugs checkstyle golang

uname
Linux a09e92f3faf2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 958cab804ef

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/4/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/4/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/4/artifact/out/diff-checkstyle-root.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/4/testReport/

Max. process+thread count
2544 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@sunchao I think all tests are passed. But there are two -1, do you know what it means?

@sunchao I think all tests are passed. But there are two -1, do you know what it means?

@viirya looks like the gcc compilation or check style failed - you can check test results for cc

@sunchao Thanks. I saw a check style failure:
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/snappy/TestSnappyCompressorDecompressor.java:355:    int[] size = { 4 * 1024, 64 * 1024, 128 * 1024, 1024 * 1024 };:18: '{' is followed by whitespace. [NoWhitespaceAfter]

But I don't change its style in the diff.

And I think for checkstyle, it is just a -0? For two cc links, I don't see any errors:

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/4/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/4/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

Yes. I also don't see any error in the log files. I think we can check Yetus repo to see how it decides whether it is a -1 or -0.
cc @jojochuang @aajisaka @steveloughran do you have any idea what caused the CI failure here?

BTW I think we no longer need the -Drequire.snappy flag and REQUIRE_SNAPPY anymore with this right?

BTW I think we no longer need the -Drequire.snappy flag and REQUIRE_SNAPPY anymore with this right?

Yes, I plan to remove them once we get rid of -1.

Checked the cc warnings and the related code. They are code long time ago, e.g., 2014, and not touched here. Many of the cc warnings are warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]. I guess it is either due to that we didn't check such warnings when the code was committed, or compilation tools upgrade? I think it is not caused by this change. Because we removed some .c and .h files, so the CI build triggered related building.
So I am not sure which one is good, fixing these compilation warnings, or ignoring them?

So I am not sure which one is good, fixing these compilation warnings, or ignoring them?

Yeah. Looks to me we can just ignore these for now and proceed to other things in this PR.

Looks like CI failed to fetch and install yetus? @sunchao do you know how we can re-trigger CI build and testing?

Just re-triggered the job let's see what happens

It seems still failed to fetch and install yetus, and not just this PR, other PRs also encountered it...

@sunchao Who we should let them know about the CI issue?

@viirya interesting ... I think you can send an email to the Hadoop dev list<EMAIL_ADDRESS>you may need to subscribe first).

OK, seems the CI is working now.

I have run a benchmark and compatibility test locally. I use SnappyCodec to write and read a ~200MB SequenceFile. Before and after this change, the performance is nearly the same.
For compatibility test, I write SequenceFile using two SnappyCodec and read it back using each other. The file can be read without problem. And the file size is also the same.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m  9s
trunk passed

+1 :green_heart:
compile
19m 26s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
16m 58s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
2m 44s
trunk passed

+1 :green_heart:
mvnsite
2m 44s
trunk passed

+1 :green_heart:
shadedclient
20m 27s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 38s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 34s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
0m 29s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 34s
branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 29s
branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 24s
the patch passed

+1 :green_heart:
compile
20m 15s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
cc
20m 15s
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 36 new + 127 unchanged - 36 fixed = 163 total (was 163)

+1 :green_heart:
golang
20m 15s
the patch passed

+1 :green_heart:
javac
20m 15s
the patch passed

+1 :green_heart:
compile
19m 48s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
cc
19m 48s
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 36 new + 127 unchanged - 36 fixed = 163 total (was 163)

+1 :green_heart:
golang
19m 48s
the patch passed

+1 :green_heart:
javac
19m 48s
the patch passed

-0 :warning:
checkstyle
3m  3s
root: The patch generated 1 new + 151 unchanged - 5 fixed = 152 total (was 156)

+1 :green_heart:
mvnsite
2m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
16m 27s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 27s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 33s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
findbugs
0m 27s
hadoop-project has no data from findbugs

+0 :ok:
findbugs
0m 24s
hadoop-project-dist has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 24s
hadoop-project in the patch passed.

+1 :green_heart:
unit
0m 26s
hadoop-project-dist in the patch passed.

+1 :green_heart:
unit
10m 18s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 53s
The patch does not generate ASF License warnings.

182m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2297

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml cc findbugs checkstyle golang

uname
Linux 0f5a7ed97d95 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5c5b2ed7c7f

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/8/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/8/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/8/artifact/out/diff-checkstyle-root.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/8/testReport/

Max. process+thread count
1589 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/8/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

cc @steveloughran and @jojochuang for review.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
39m 42s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 29s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
35m 48s
trunk passed

+1 :green_heart:
compile
29m 25s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
24m 38s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
3m 51s
trunk passed

+1 :green_heart:
mvnsite
3m  2s
trunk passed

+1 :green_heart:
shadedclient
26m 19s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 44s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 53s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
0m 30s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 36s
branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 30s
branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
1m  6s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 43s
the patch passed

+1 :green_heart:
compile
28m 55s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
cc
28m 55s
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 14 new + 149 unchanged - 14 fixed = 163 total (was 163)

+1 :green_heart:
golang
28m 55s
the patch passed

+1 :green_heart:
javac
28m 55s
the patch passed

+1 :green_heart:
compile
24m 49s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
cc
24m 49s
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 21 new + 142 unchanged - 21 fixed = 163 total (was 163)

+1 :green_heart:
golang
24m 49s
the patch passed

+1 :green_heart:
javac
24m 49s
the patch passed

-0 :warning:
checkstyle
3m 42s
root: The patch generated 6 new + 151 unchanged - 5 fixed = 157 total (was 156)

+1 :green_heart:
mvnsite
3m  5s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
17m 48s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 48s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 52s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
findbugs
0m 33s
hadoop-project has no data from findbugs

+0 :ok:
findbugs
0m 33s
hadoop-project-dist has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 31s
hadoop-project in the patch passed.

+1 :green_heart:
unit
0m 31s
hadoop-project-dist in the patch passed.

+1 :green_heart:
unit
12m 25s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  2s
The patch does not generate ASF License warnings.

278m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2297

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml cc findbugs checkstyle golang

uname
Linux 525d734eef6a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5c5b2ed7c7f

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/9/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/9/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/9/artifact/out/diff-checkstyle-root.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/9/testReport/

Max. process+thread count
3263 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/9/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

cc @jlowe and @liuml07 who recently worked on compression codecs for more feedback.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
29m 58s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m 10s
trunk passed

+1 :green_heart:
compile
21m 26s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
18m 44s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
2m 54s
trunk passed

+1 :green_heart:
mvnsite
2m 27s
trunk passed

+1 :green_heart:
shadedclient
19m 56s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 38s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 32s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
0m 38s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 36s
branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 37s
branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 16s
the patch passed

+1 :green_heart:
compile
20m 49s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
cc
20m 49s
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 17 new + 146 unchanged - 17 fixed = 163 total (was 163)

+1 :green_heart:
golang
20m 49s
the patch passed

+1 :green_heart:
javac
20m 49s
the patch passed

+1 :green_heart:
compile
18m 31s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
cc
18m 31s
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 11 new + 152 unchanged - 11 fixed = 163 total (was 163)

+1 :green_heart:
golang
18m 31s
the patch passed

+1 :green_heart:
javac
18m 31s
the patch passed

-0 :warning:
checkstyle
2m 49s
root: The patch generated 6 new + 151 unchanged - 5 fixed = 157 total (was 156)

+1 :green_heart:
mvnsite
2m 32s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m  3s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 38s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 42s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
findbugs
0m 34s
hadoop-project has no data from findbugs

+0 :ok:
findbugs
0m 35s
hadoop-project-dist has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 33s
hadoop-project in the patch passed.

+1 :green_heart:
unit
0m 34s
hadoop-project-dist in the patch passed.

+1 :green_heart:
unit
9m 49s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 50s
The patch does not generate ASF License warnings.

213m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2297

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml cc findbugs checkstyle golang

uname
Linux a3c4311f767f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ce861836918

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/10/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/10/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/10/artifact/out/diff-checkstyle-root.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/10/testReport/

Max. process+thread count
3258 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/10/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
29m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m  3s
trunk passed

+1 :green_heart:
compile
21m 43s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
18m 24s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
2m 50s
trunk passed

+1 :green_heart:
mvnsite
2m 41s
trunk passed

+1 :green_heart:
shadedclient
20m 17s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 40s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 37s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
0m 29s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 40s
branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 29s
branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 17s
the patch passed

+1 :green_heart:
compile
20m 57s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
cc
20m 57s
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 18 new + 145 unchanged - 18 fixed = 163 total (was 163)

+1 :green_heart:
golang
20m 57s
the patch passed

+1 :green_heart:
javac
20m 57s
the patch passed

+1 :green_heart:
compile
18m 29s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
cc
18m 29s
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 40 new + 123 unchanged - 40 fixed = 163 total (was 163)

+1 :green_heart:
golang
18m 29s
the patch passed

+1 :green_heart:
javac
18m 29s
the patch passed

-0 :warning:
checkstyle
2m 54s
root: The patch generated 6 new + 151 unchanged - 5 fixed = 157 total (was 156)

+1 :green_heart:
mvnsite
2m 39s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m  9s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 37s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 39s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
findbugs
0m 29s
hadoop-project has no data from findbugs

+0 :ok:
findbugs
0m 34s
hadoop-project-dist has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 30s
hadoop-project in the patch passed.

+1 :green_heart:
unit
0m 30s
hadoop-project-dist in the patch passed.

-1 :x:
unit
10m 18s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 57s
The patch does not generate ASF License warnings.

214m 44s

Reason
Tests

Failed junit tests
hadoop.ha.TestZKFailoverController

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2297

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml cc findbugs checkstyle golang

uname
Linux 297b24487146 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ce861836918

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/11/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/11/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/11/artifact/out/diff-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/11/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/11/testReport/

Max. process+thread count
1459 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/11/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 58s
trunk passed

+1 :green_heart:
compile
19m 24s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
16m 49s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
2m 44s
trunk passed

+1 :green_heart:
mvnsite
2m 41s
trunk passed

+1 :green_heart:
shadedclient
20m 10s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 49s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 41s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
0m 35s
Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 37s
branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 35s
branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
1m  1s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 21s
the patch passed

+1 :green_heart:
compile
19m 33s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
cc
19m 33s
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 38 new + 125 unchanged - 38 fixed = 163 total (was 163)

+1 :green_heart:
golang
19m 33s
the patch passed

+1 :green_heart:
javac
19m 33s
the patch passed

+1 :green_heart:
compile
16m 48s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
cc
16m 48s
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 43 new + 120 unchanged - 43 fixed = 163 total (was 163)

+1 :green_heart:
golang
16m 48s
the patch passed

+1 :green_heart:
javac
16m 48s
the patch passed

-0 :warning:
checkstyle
2m 48s
root: The patch generated 6 new + 151 unchanged - 5 fixed = 157 total (was 156)

+1 :green_heart:
mvnsite
2m 40s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m  6s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 49s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 39s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
findbugs
0m 36s
hadoop-project has no data from findbugs

+0 :ok:
findbugs
0m 35s
hadoop-project-dist has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 34s
hadoop-project in the patch passed.

+1 :green_heart:
unit
0m 35s
hadoop-project-dist in the patch passed.

+1 :green_heart:
unit
9m 24s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 53s
The patch does not generate ASF License warnings.

177m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2297

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml cc findbugs checkstyle golang

uname
Linux a5f6c2c9d4c1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / eacbe07b565

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/12/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

cc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/12/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/12/artifact/out/diff-checkstyle-root.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/12/testReport/

Max. process+thread count
1844 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/12/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Regarding the change of mvn dependency.
For Apache Hadoop Common, the diff is:
Before:
[INFO] +- org.apache.avro:avro:jar:1.7.7:compile
[INFO] |  +- com.thoughtworks.paranamer:paranamer:jar:2.3:compile
[INFO] |  \- org.xerial.snappy:snappy-java:jar:1.0.5:compile

After:
[INFO] +- org.apache.avro:avro:jar:1.7.7:compile
[INFO] |  \- com.thoughtworks.paranamer:paranamer:jar:2.3:compile
...
[INFO] \- org.xerial.snappy:snappy-java:jar:<IP_ADDRESS>:provided

For other modules, the change is the same.
Like Apache Hadoop NFS:
Before:
[INFO] |  +- org.apache.avro:avro:jar:1.7.7:provided
[INFO] |  |  +- com.thoughtworks.paranamer:paranamer:jar:2.3:provided
[INFO] |  |  \- org.xerial.snappy:snappy-java:jar:1.0.5:provided

After:
[INFO] |  +- org.apache.avro:avro:jar:1.7.7:provided
[INFO] |  |  +- com.thoughtworks.paranamer:paranamer:jar:2.3:provided
[INFO] |  |  \- org.xerial.snappy:snappy-java:jar:<IP_ADDRESS>:provided

Or like Apache Hadoop KMS:
Before:
[INFO] |  +- org.apache.avro:avro:jar:1.7.7:compile
[INFO] |  |  +- com.thoughtworks.paranamer:paranamer:jar:2.3:compile
[INFO] |  |  \- org.xerial.snappy:snappy-java:jar:1.0.5:compile

After:
[INFO] |  +- org.apache.avro:avro:jar:1.7.7:compile
[INFO] |  |  +- com.thoughtworks.paranamer:paranamer:jar:2.3:compile
[INFO] |  |  \- org.xerial.snappy:snappy-java:jar:<IP_ADDRESS>:compile

@steveloughran we addressed your comments. Please take a look again when you have time. Thanks!

cc @iwasakims @aajisaka who involved with codec in Hadoop.

So actually snappy was already a dependency of hadoop-common? Interesting

@steveloughran if snappy native was a dependency for hbase-common, do you think that argues snappy-java could be (having it as 'provided' undoes the main benefit of using snappy-java jar instead of the native snappy libs). Thanks Steve.

@saintstack @steveloughran Thanks for the reviews. I think I addressed the latest comments.

@saintstack @steveloughran Is this change looking good for you now? Based on this change, we will work on the compression module per https://github.com/apache/hadoop/pull/2159#issuecomment-698212693 suggests. Thanks.

(nit nit) we may need to update NativeLibraries guide as well since NativeLibraryChecker no longer checks snappy.

Thanks @sunchao for review. Addressed your comments.

@steveloughran if snappy native was a dependency for hbase-common, do you think that argues snappy-java could be (having it as 'provided' undoes the main benefit of using snappy-java jar instead of the native snappy libs). Thanks Steve.

Any luck on opinion on above @steveloughran ? Thanks boss.

Having checked up on those dependencies myself, yes, we are already shipping snappy-java 1.0.5 as a dependency of hadoop-common, by way of avro. Which makes a strong case for keeping the snappy codec in hadoop-common, declaring the snappy dependency as a compile time dependency, with the version we choose. This ensures hbase &c pick it up, and, because it is there: we aren't creating any more complications for people downstream than they get today.
@saintstack happy with that?
In which case, we actually go to the earlier patches, which just switch the codec to using the native one, and the pom changes to import it. Plus a release note 'you don't need native snappy no more'.
We could stay with the current code, which is resilient to someone removing the JAR.
Good: resilient
bad: doesn't work so well if things (hadoop-client?) shade the snappy jar references.
I don't know what to do there. Given the code is written, I'd go for "merge it as is and see what happens", but the "go back to the minimal binding" could well have lower maintenance costs down the line

bad: doesn't work so well if things (hadoop-client?) shade the snappy jar references.

Since this dependency is new, as long we make sure it is not shaded in the client modules (e.g., hadoop-client-api) it should be fine. I checked there and don't see it is shaded right now.

happy with that?

Thanks @steveloughran If I understand you correctly, because you figured we actually already include snappy-java and that snappy is already a hadoop-common dependency, then making it so snappy-java is 'compile' rather than 'provided' is ok by you.
If so, yeah, I think this better. Operators don't have to make sure of native snappy everywhere since snappy-java provides it.
(Looks like @viirya has gone ahead and made snappy-java compile scope...)

@sunchao Thanks for review. I addressed your comments. Please let me know if you have more comments.

ok, yetus is running, it's just reporting isn't quite there...if you follow the link you see the results. Test failures in hdfs: unrelated. ASF licence warning: unrelated.
Checkstyles are, sadly, related.
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java:491:    }:5: '}' at column 5 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally). [RightCurly]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java:492:    else if (compressor.getClass().isAssignableFrom(SnappyCompressor.class)): 'if' construct must use '{}'s. [NeedBraces]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/snappy/TestSnappyCompressorDecompressor.java:356:    int[] size = { 4 * 1024, 64 * 1024, 128 * 1024, 1024 * 1024 };:18: '{' is followed by whitespace. [NoWhitespaceAfter]

Hmm, for CompressDecompressTester.java, it seems to me that it is from original code?
    else if (compressor.getClass().isAssignableFrom(ZlibCompressor.class)) {
      return ZlibFactory.isNativeZlibLoaded(new Configuration());
-    }
-    else if (compressor.getClass().isAssignableFrom(SnappyCompressor.class)
-            && isNativeSnappyLoadable())
+    }
+    else if (compressor.getClass().isAssignableFrom(SnappyCompressor.class))

Anyway, I can fix it here if you think it is ok.

The style issue was fixed in the last run. The CI failed because of unit tests and ASF license (I don't really see the file jobTokenPassword). Seems neither is related to this PR.

Fixed another and last style issue. Checked with mvn checkstyle:check locally.

If making a new PR, the '   compile' is redundant given its maven default?
The license failure is:
Lines that start with ????? in the ASF License  report indicate files that do not have an Apache license header:
 !????? /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2297/src/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/jobTokenPassword

No harm fixing it as part of this patch... add the 'jobTokenPassword' from below in ./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml
       <plugin>
         <groupId>org.apache.rat</groupId>
         <artifactId>apache-rat-plugin</artifactId>
         <configuration>
           <excludes>
             <exclude>src/test/java/org/apache/hadoop/cli/data60bytes</exclude>
             <exclude>src/test/resources/job_1329348432655_0001-10.jhist</exclude>
             <exlude>**/jobTokenPassword</exclude>
           </excludes>
         </configuration>
       </plugin>

Otherwise patch is looking good to me.

The native compile complaints seem unrelated...

Thanks @steveloughran and @saintstack. Updated the diff based on your suggestions.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
5m 36s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m  2s

trunk passed

+1 :green_heart:
compile
19m 49s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
17m  5s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
2m 56s

trunk passed

+1 :green_heart:
mvnsite
20m 56s

trunk passed

+1 :green_heart:
shadedclient
14m 21s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
6m 29s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
7m  8s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
0m 45s

Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 25s

branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 23s

branch/hadoop-project-dist no findbugs output file (findbugsXml.xml)

-0 :warning:
patch
1m  7s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 35s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
21m 15s

the patch passed

+1 :green_heart:
compile
19m 18s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

-1 :x:
cc
19m 18s
/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 40 new + 123 unchanged - 40 fixed = 163 total (was 163)

+1 :green_heart:
golang
19m 18s

the patch passed

+1 :green_heart:
javac
19m 18s

the patch passed

+1 :green_heart:
compile
17m  9s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

-1 :x:
cc
17m  9s
/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 36 new + 127 unchanged - 36 fixed = 163 total (was 163)

+1 :green_heart:
golang
17m  9s

the patch passed

+1 :green_heart:
javac
17m  9s

the patch passed

+1 :green_heart:
checkstyle
2m 50s

root: The patch generated 0 new + 140 unchanged - 3 fixed = 140 total (was 143)

+1 :green_heart:
mvnsite
17m 36s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

There were no new shellcheck issues.

+1 :green_heart:
shelldocs
0m 18s

There were no new shelldocs issues.

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  5s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m 11s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
6m 25s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
7m  9s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
findbugs
0m 23s

hadoop-project has no data from findbugs

+0 :ok:
findbugs
0m 24s

hadoop-project-dist has no data from findbugs

_ Other Tests _

-1 :x:
unit
587m 25s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 51s

The patch does not generate ASF License warnings.

891m 20s

Reason
Tests

Failed junit tests
hadoop.yarn.applications.distributedshell.TestDistributedShell

hadoop.crypto.key.kms.server.TestKMS

hadoop.hdfs.TestFileChecksumCompositeCrc

hadoop.hdfs.server.balancer.TestBalancer

hadoop.hdfs.server.namenode.TestFileTruncate

hadoop.hdfs.TestDFSShell

hadoop.hdfs.TestFileChecksum

hadoop.tools.TestDistCpSystem

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/22/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2297

Optional Tests
dupname asflicense shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xml cc findbugs checkstyle golang

uname
Linux 928304952c17 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6ece6407e18

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/22/testReport/

Max. process+thread count
4090 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-project-dist hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/22/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

No harm fixing it as part of this patch... add the 'jobTokenPassword' from below in ./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/pom.xml

I think it's actually some test runner bug, really it should be cleaned up.

Ok, I'm happy too
+1, merging to trunk and branch-3.3

Thanks for pushing this through @steveloughran  +1 on master and branch-3.3.

Thanks @steveloughran @saintstack @sunchao @dbtsai

Thanks all for helping and pushing this through! This will simplify how people deploy snappy native lib greatly.

JIRA on apache is offline & updated -we need to remember to update that, including something in the release notes

Ok, got it. I will update release notes once it is back.

Looks like the JIRA is back now? https://issues.apache.org/jira/browse/HADOOP-17125

JIRA closed, added a release note.

Thanks @steveloughran - could you assign the JIRA to @viirya ?

@viirya    ...what's your JIRA username?

@steveloughran Username is viirya too. Thanks.

@viirya assigned JIRA to you. you are also free to assign any other Hadoop JIRAs to yourself...

@steveloughran Thank you! I tried to assign this ticket, but seems cannot do it.

you needed to be listed in the project settings as someone with the right permissions. its done now


Use same eventloop for AMQP subscription and worker

Should be closed if we close https://github.com/DiamondLightSource/blueapi/issues/104


proposal: maps: add function to check existence of a key

Proposal Details
A lot of code uses pattern like this:
if _, ok := somemap[somekey]; ok {
    ...
}

just to check if key exists in a map.
And, with *Func functions from strings, slices, etc packages it makes code look unnecessary ugly.
For example, to filter out elements of a slice that exist in a map you need to do this:
type Buzz struct {
    ID string
}

var fizzies map[string]int
var buzzies []Buzz

...

buzzies = slices.DeleteFunc(buzzies, func (buzz Buzz) bool {
    _, ok := fizzies[buzz.ID]
    return ok
})

Instead of, let's say, this:
buzzies = slices.DeleteFunc(buzzies, func (buzz Buzz) bool {
    return maps.Contains(fizzies, buzz.ID)
})

That might be subjective, but one-line return statement looks less clunky.
I deliberately used this example because simple one, with var buzzies []string might raise unnecessary questions like "why not add something like HasKeyFunc(map[K]V) func(K) bool" which will make this example look like this:
buzzies = slices.DeleteFunc(buzzies, maps.HasKeyFunc(fizzies))

Which looks pretty, but doesn't make other cases any more readable than first example.
Bike-shedding section
I don't care about naming, but already implied maps.Contains because it's common across std.
One might argue that semantics of e.g. slices.Contains differ from maps.Contains because slices.Contains uses slice values instead of indices.
But there is an opposite argument of delete(map, key) that follows this pattern for maps while slices.Delete uses indices instead of values.

I have also written plenty of examples like this. I've also fielded questions from folks new to Go about what it means when they encountered it for the first time, since it's not very easy to search for what this weird bunch of punctuation means.
I like the idea of giving this common operation a name, even if it's not saving that many lines of code. (I tend to care much more about code being easy to understand for unfamiliar readers than about number of lines of code, in any event.)
If I might join the bikeshedding discussion: since Contains could potentially mean either "has matching key" or "has matching value", I'd suggest maps.HasKey as a clearer alternative of similar length:
buzzies = slices.DeleteFunc(buzzies, func (buzz Buzz) bool {
    return maps.HasKey(fizzies, buzz.ID)
})

To me that makes the meaning pretty clear without having to consult the documentation, and isn't onerously long.
Although I would be considerably more skeptical about it, if we do decide to also have a function for testing whether any of the elements have a matching value, analogous to slices.Contains, it could be called maps.HasValue to continue the pattern.

One use-case I encountered is with switch statements.
Example
switch {
case _, ok := myMap["k1"]; ok: //this code is invalid
//...
case _, ok := myMap["k2"]; ok:
//...
}

the ifs version:
if _, ok := myMap["k1"]; ok {
//...
}

if _, ok := myMap["k2"]; ok {
//...
}

with HasKey it can look like this:
switch {
case maps.HasKey(myMap, "k1"):
//...
case maps.HasKey(myMap, "k2"):
//...
}

In fact, I already implemented a similar function for my personal use.

@mrg0lden You can try nstd.HasEntry.


default parameter

http://en.gravatar.com/site/implement/images/
The library appears to be missing an option to specify the &default=.

This is the worst library response in the history of mankind, but I just now saw it :(  For future lookers, it's just named "backup" instead of default.  Not sure why I did that in hindsight


add proxy config from env variables

Issues
Closes #178.
Solution
Similarly to Grafana, we're honoring the proxy configuration set in the juju model config.
Additional changes: charmcraft fetch-lib :)

This was added as part of #195. Closing.


[enhancement] Add preset creator name and "Likes"

It would be interesting to include the creator's name on the preset view screen, and it would also be nice to be able to give "Likes" to the presets and also be able to sort the presets by number of likes/creation date/etc.

The creator's name is the next feature I'll be including.
The likes is in the roadmap, but is not my priority because there is not so many presets yet to be useful.

The following PR adds creator's name and profile page.
https://github.com/geovannimp/cube-baby-presets/pull/8


Update fr.strings

litlle update, a missing letter.

Will release this later with more fixes/features.


How do I create a repeat notification by selected number of months, days, and times?

for example: I need to repeat one notification every three days, three hours, three months, three years?

You can use the cron expression to do it. But for now it only works on Android devices. For iOS we are still fighting with Apple to make it work.

Woo, Try up WorkManager


Add Fidelity instructions to README

Any chance you could add something pretty to the README, @ShadoFlameX? :pray: I'm not familiar with Fidelity's UI myself


Feature Request: Support non-author github repo navigation

Nice work here! 🎉 -- Apologies in advance if you don't want feature requests as issues, feel free to close. :)
Ideally, I can use this to automatically clone github repos where I am not the author if full path is given. Hope that makes sense, thanks!
Desired behavior:
goto ajhenry/goto it should clone this github project into a new directory ${dev-home}/ajhenry/goto.
Actual behavior:
➜  ~ goto ajhenry/goto
No paths found for ajhenry/goto
No repos found for ajhenry/goto
✔ /Users/mericsson/dev/ajhenry/goto doesn't exist, do you want to create it? … no / yes

Hey thanks for the feature request! This was actually a functionality I already needed and have been using for a few days to see if the flow made sense.
There were a few ways I was thinking about having to deal with repos that aren't "yours" or part of any orgs that you're not in.
If I enter something like ajhenry/goto this is way I'm handling it now:

First searches locally, if the directory exists, go to it
Next search github, if there is a repo with that exact repo path, clone and go to it
If there isn't one, provide the search results
If there are no search results, then it asks for you to create the directory

Nice! Sgtm! :shipit:


Add 'dim' layerrule with floating value

Description
Would be especially cool for a blurred, transparent waybar.

what?

E.g
layerrule = dim 0.8, bar
And my bar is 80% dimmed

I getchu now, but fail to see the point? just style your bar in its css

Gtk 3 bad, blur no worky if there's a bar colour.


feat: Improve view navigation

With lots of views the navigation can be quite confusing. This PR sorts views in the dropdown and puts the default-view (if existent) at the top of the dropdown menu. This closes #130.

Maybe bootstrap-select is the solution for the search functionality: https://developer.snapappointments.com/bootstrap-select


Explore how we can mask/block all text on the page for PII

Maybe if we set the maskTextClass=* and it'll just work.
Could be an SDK plugin that observes/traverses all nodes and does replacement from text to *

Closed by #205


[SPARK-37909] Replace global F403 exclude with file-specific rules

What changes were proposed in this pull request?

This PR rolls back global exclude on F403 introduced in SPARK-37909.
Instead, we can use file-specific on major offenders (test files).
Why are the changes needed?

Based on CI behavior and local test runs, it seems like it takes precedence over F401 and silences unused import errors.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Existing tests.

cc @HyukjinKwon @itholic

Merged to master.


Added support to enable/disable received header parsing errors

There is logging of error when received header parsing returns more than 1 match and its most of the time not correct regex and end up in error. Added a flag in functions to suppress that logging. By default it will be true and will keep working as it is but it will give an option to users if they want to turn it off as it happened in our case, we dont want to parse it but its creating unnecessary noise in our error logging.

This code conflicts with new refactoring.


GitHub issue and PR templates

Dynamoose is officially adding GitHub issue and pull request templates!! 🎉🎉
This will help the entire project be more clear and effective. I would love feedback about these templates, as they will continue to evolve and change overtime given changes in the project.
Please comment your thoughts, feedback, questions, and anything else below. 😃

Pull Request Test Coverage Report for Build 591

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.106%

Totals

Change from base Build 586:
0.0%

Covered Lines:
1847

Relevant Lines:
2124

💛  - Coveralls


Highlight the selected Weather Scout

Add a border or background to the selected Weather Scout.

Fixed with 7bf4f5f1dceb733966af8a77f72a2a53d0390e39