Update use-key-vault-references-dotnet-core.md

Add a little more details for using client secret.

@zhenlan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@zhenlan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

cc @avanigupta for review

Hi @AlexandraKemperMS - Could you review the proposed update to your article and type #sign-off if it's good to merge?
Thanks.

@ktoliver: I'm sorry - only the author of this article, @AlexandraKemperMS, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@AlexandraKemperMS, you can only sign off in the main PR conversation, not in review comments.

#sign-off

Thanks, all.

Per the internal cloud style guide, for Azure Key Vault, use "lowercase when referring to a generic item: key vault". That is, "your key vault," "a key vault," etc.


support dashboard v2

Hi,
we've released v2 our dashboard. The only change are the updated requirements: we now require Laravel v8 and Livewire v2.
Could you please tag a new release of your tile?
In most cases these are the things you need to do:

update the requirement in the composer.json of your tile to "spatie/laravel-dashboard": "^2.0"
tag a new release. Personally, I would opt for a major release, so you can still do bug fixes on the v1 of your tile.

Thanks!

Thanks for the report. 🙂
Solved by https://github.com/Astrotomic/laravel-dashboard-citybikes-tile/releases/tag/1.1.0 🎉🚀


program CI tests for RPOD Event Sequences

[ ] ES1
[ ] ES2
[ ] ES3
[ ] ES4
[ ] ES5

To limit workload, we'll just be verifying the event sequence control scripts by running them in-game.


Add declaration files for TypeScript support

My TypeScript project needed to use getContext feature so I write a declaration for it inside @types folder and indicate this in package.json.
Without it, we always will get an error (Could not find a declaration file for this module) when importing reverso-api in a TypeScript file.
Reference: DefinitelyTyped

File
Purpose

index.d.ts
This contains the typings for the package.

reverso-api-tests.ts
This contains sample code which tests the typings. This code does not run, but it is type-checked.

tsconfig.json
This allows you to run tsc within the package.

tslint.json
Enables linting.

.eslintrc.json
(Rarely) Needed only to disable lint rules written for eslint.

are you guys here?

Would also be nice to have this types. 🫡


Use Different Emojis for Historical

jack, rose, alexis, luna and baby reactions will all get historical. In historical could specify the emoji that got the message there.

#14


refactor: Move common functions to catchup-number file

Good optimizations, @SirusCodes! Thank you!
There are some changes and I'll let you know those through reviews.

LGTM! Let's hope the workflows run. I'll be checking that after merging.

Prefect!!


New polling request created on every new wf execution

we are experiencing a behaviour in our decider (and activity) worker where a new pollForDecisionTask connection is created (identified from aws client logging) every time a new workflow instance is created.
When the worker is first deployed we see log like the following every 60 seconds (default long polling period)
[AWS swf 200 60.289s 0 retries] pollForDecisionTask({ domain: 'dev',
  taskList: { name: '...' },
  identity: '...',
  maximumPageSize: 100,
  reverseOrder: false })

after we start a new workflow execution, and the decider go through its logic and activities then we start seeing another log for pollForDecisionTask.
Is that the expected behaviour ? or is there some kind of clean up we need to do when the execution is suppose to be terminated ?
we have been fighting this issue for a while now, as the time goes the response time for task.response.respondCompleted become very very slow  (5 mins +).

seem like this might have fixed that problem, doing some more testing now.
https://github.com/neyric/aws-swf/pull/49


lvgl: kconfig: Remove menu and use a 'menuconfig' symbol

The 'Graphical user interface' menu currently contains just the
'LittlevGL Support' symbol and its indented children.
To remove one menu level, remove the 'Graphical user interface' menu,
rename the symbol to 'LittlevGL GUI library' (consistent with e.g.
'Logging' and 'Bluetooth'), and turn it into a 'menuconfig' symbol.

Screenshots before:

Screenshots after:

What is the reasoning behind this?
If we would like to support more than one GUI implementation (eg. move CFB to GUI library from display) are we going to clutter the top level menu?

@vanwinkeljan
It avoids giving the impression that there's more than one option (with just one being visible), and while there's just one option, it makes the menu structure cleaner. Having a menu with just a single thing in it feels confusing to me. Would probably wait until there's at least three.
Bit subjective, but to me it's kinda like having a "Bluetooth stack" menu just in case there's more than one Bluetooth implementation later. Better to reorganize things later when it's needed, since it's so simple to do.


Adjust User password reset message flow diagram

Set User password reset message flow diagram image to be 225x300 in markdown. Currently the image is defaulting to width:100% making the link to the larger image pointless and taking up too much space on the documentation page.

Never mind, markdown does not support setting image width height in links.


BUG: Fix possible loss of data on type conversion

Fix possible loss of data on type conversion, typically from a (possibly
64-bit) size_t to a 32-bit integer type, as suggested by various
occurrences of VS2017 warning C4244 and C4267 (when these warnings are
not disabled):

video\core\include\itkRingBuffer.hxx(193): warning C4244: 'initializing': conversion from 'itk::RingBufferitk::DataObject::OffsetValueType' to 'unsigned int'

Filtering\BiasCorrection\src\itkCompositeValleyFunction.cxx(26): warning C4267: 'initializing': conversion from 'size_t' to 'unsigned int'

Numerics\Polynomials\src\itkMultivariateLegendrePolynomial.cxx(151): warning C4267: 'argument': conversion from 'size_t' to 'int'

Core\Common\src\itkArrayOutputSpecialization.cxx(29): warning C4267: 'initializing': conversion from 'size_t' to 'unsigned int'

core\common\include\itkNumericTraitsArrayPixel.h(126): warning C4267: 'return': conversion from 'size_t' to 'unsigned int'

numerics\statistics\include\itkMeasurementVectorTraits.h(308): warning C4267: 'return': conversion from 'size_t' to 'itk::Statistics::MeasurementVectorTraits::MeasurementVectorLength'

IO\MeshBase\include\itkMeshIOBase.h(386): warning C4244: 'return': conversion from 'const itk::MeshIOBase::SizeValueType' to 'unsigned int'

After this commit, there are still 225 other C4267 warnings, and 2390 other C4244 warnings about "possible loss of data" in ITK. Some of them are about conversion from 64-bit integer to 32-bit integer, others are about floating point conversions. But they are too many for me to solve them all in one commit. Could this pull request already be merged, as an initial step?

others are about floating point conversions.

I recall the implicit conversion from double to float being warned was a bit annoyance for a while long ago, that may have been part of the motivation for this suppression.


cmd/go: -trimpath not trimming some C source file paths

What version of Go are you using (go version)?

go version go1.20.1 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
GO111MODULE=""
GOARCH="amd64"
GOBIN="/home/Go/go-current/go/bin"
GOCACHE="/home/.cache/go-build"
GOENV="/home/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/Go/go-current/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/Go/go-current/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/Go/go-current"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/Go/go-current/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.20.1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build632438867=/tmp/go-build -gno-record-gcc-switches"

What did you do?
I was trying the "new" -trimpath feature and found that some system path information was inserted into the executable binary.
Most paths were trimmed successfully but some paths to C source files were not trimmed.
The problem can be seen when building this project: https://github.com/inkyblackness/imgui-go-examples
In the cmd/example_sdl_opengl3 directory

> go build -tags 'sdl' -trimpath .
> strings example_sdl_opengl3 | grep home

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
I'm not sure this is really a bug but I can't see these strings in the DWARF data (when dumped with readelf) nor do they exist as literal strings in the source.
What did you expect to see?
All system paths used during the build and included in the binary, to be trimmed.
What did you see instead?
Some system paths included in the binary have not been trimmed.

Details of GCC toolchain
gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/10/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa:hsa
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Debian 10.2.1-6' --with-bugurl=file:///usr/share/doc/gcc-10/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++,m2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-10 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --enable-default-pie --with-system-zlib --enable-libphobos-checking=release --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/gcc-10-Km9U7s/gcc-10-10.2.1/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-10-Km9U7s/gcc-10-10.2.1/debian/tmp-gcn/usr,hsa --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu --with-build-config=bootstrap-lto-lean --enable-link-mutex
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 10.2.1 20210110 (Debian 10.2.1-6)

I'm able to reproduce this using gcc 12.2.0.
$ go get github.com/inkyblackness/imgui-go-examples/cmd/example_sdl_opengl3

$ go build -tags 'sdl' -trimpath github.com/inkyblackness/imgui-go-examples/cmd/example_sdl_opengl3
# github.com/inkyblackness/imgui-go/v4
In file included from wrapper.cpp:7:
<EMAIL_ADDRESS>In function ‘void ImFontAtlasBuildPackCustomRects(ImFontAtlas*, void*)’:
.gopath/pkg/mod/github.com/inkyblackness/imgui-go/v4@v4.7.0/imgui/imgui_draw.cpp:2623:11: warning: ‘void* memset(void*, int, size_t)’ specified size between<PHONE_NUMBER>1562067968 and<PHONE_NUMBER>3709551615 exceeds maximum object size<PHONE_NUMBER>854775807 [-Wstringop-overflow=]
 2623 |     memset(pack_rects.Data, 0, (size_t)pack_rects.size_in_bytes());
      |     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

$ strings example_sdl_opengl3 | grep $(go env GOMODCACHE)
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Note that we already use -fdebug-prefix-map.  For GCC -ffile-prefix-map implies -fdebug-prefix-map.  I'm not clear on where these strings are appearing if it's not the debug info.

Using objdump -s we found that the strings that end up in the object file correspond to uses of the IM_ASSERT macro in the C and C++ codebase.
There are several different definitions of the IM_ASSERT macro in the codebase, but our hypothesis is that they're ending up evaluating the __FILE__ macro to produce the strings that end up in the code, possibly here:
https://github.com/inkyblackness/imgui-go/blob/bed7fdfcba8248960e3d8a6aa251bc8665340d9d/wrapper/ConfigOverride.h#L11
From https://reproducible-builds.org/docs/build-path/, it looks like -fdebug-prefix-map fixes the references in the DWARF debug data but not the __FILE__ macros, and that switching to -ffile-prefix-map (or adding -fmacro-prefix-map) would fix those as well.

Oh, I see, the strings are coming from calls to assert in the C++ code.  That could be fixed by using -fmacro-prefix-map, which, like -fdebug-prefix-map, is implied by -ffile-prefix-map.  Probably changing all the -fdebug-prefix-map options to -ffile-prefix-map would fix this.
The -ffile-prefix-map option was added in GCC 8 (2018).  The -fmacro-prefix-map option was added then as well.  -fdebug-prefix-map is older, added in GCC 4.3 (2008).  So I guess we should only switch from -fdebug-prefix-map to -ffile-prefix-map if the latter is supported.
(Probably you already knew all that.)

Sorry, crossed paths.  You did know all that.

This was fixed by https://go-review.git.corp.google.com/c/go/+/478455.


Add console with colors and tab completion

Fixes SpongePowered/Sponge#201 for SpongeVanilla. While this could be basically also used for Sponge, we've currently no way to edit the log4j2 configuration directly there and injecting everything at runtime would be very hacky code (and a lot of work as log4j2 is optimized for configuration in the configuration file and not at runtime).
This adds (tab) command completion support as well as colors to the Minecraft console. The command line will also stick at the bottom now instead of being overwritten by new log lines.
This should mostly work, however it could need some testing especially on Windows. Depending on the environment there may be still problems there, and I've only tested on Linux (where everything is working fine).

I can vouch for this working on OS X. However the colors do not work within the actual GUI itself.

@jamierocks The GUI is nothing you need to worry about ;)
https://github.com/SpongePowered/Sponge/commit/903a70b4c35d5a4828d8b8366cd6ccf8be468c5e

@Minecrell Merge this soon?

tab completion and colors seem to work on windows from cmd. IntelliJ is another matter.

@ryantheleach Colors should be also supported in IntelliJ IDEA, command completion is not due to limitations in the inbuilt IntelliJ IDEA console


[Feature Request] Add a config option not displaying in both status bar and title bar on Obsidian v1.0

Thanks for building this awesome plugin and hope it would be better compatible with the latest Obsidian.

This can be configured using the Style Settings plugin: under Quick Explorer, choose "Hide Quick Explorer".

Thanks, I didn't notice that in README.
Maybe adding this info here would be helpful to remind users of this feature.

This setting isn't working for me anymore on v1.0.3. It only works when the plugin first loads. If Obsidian is quit and reopened, the style setting option disappears and the quick explorer appears in both places again.

Deactivate both style settings and quick explorer, then reactivate them, and see if that works.  If not, switch the order of activation.  (The idea here is that Style Settings is apparently not noticing QE's style settings for some reason, so changing the activation order should make it work better at startup.  Probably QE needs to be activated first so SS will detect it.)

Sorry I should've tried turning both style settings and quick explorer off. That has seemingly fixed it and persisted through a few app restarts so far.
Regarding your other point, I don't see a documented way to change plugging activation order at glance in Obsidian?

There isn't one, but the ordering follows the order you turn them on in.  Turning a plugin off, then on again will move it to the end of the list.


Mac_ios cubic_bezier_perf_ios_sksl_warmup__timeline_summary failing with use after free crash

Shard name: Mac_ios cubic_bezier_perf_ios_sksl_warmup__timeline_summary
LUCI build: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios cubic_bezier_perf_ios_sksl_warmup__timeline_summary/1252/overview
Log output:

[cubic_bezier_perf_ios_sksl_warmup__timeline_summary] [STDOUT] run stdout: [+20125 ms] Runner(866,0x16c0df000) malloc: Incorrect checksum for freed object 0x1060ae800: probably modified after being freed.
[cubic_bezier_perf_ios_sksl_warmup__timeline_summary] [STDOUT] run stdout: [        ] Corrupt value: 0x1438d42137
[cubic_bezier_perf_ios_sksl_warmup__timeline_summary] [STDOUT] run stdout: [        ] Runner(866,0x16c0df000) malloc: *** set a breakpoint in malloc_error_break to debug
[cubic_bezier_perf_ios_sksl_warmup__timeline_summary] [STDOUT] run stdout: [  +60 ms] Process 866 stopped
[cubic_bezier_perf_ios_sksl_warmup__timeline_summary] [STDOUT] run stdout: [        ] * thread #10, name = 'io.flutter.1.ui', stop reason = signal SIGABRT
[cubic_bezier_perf_ios_sksl_warmup__timeline_summary] [STDOUT] run stdout: [        ]     frame #0: 0x00000001cb83584c libsystem_kernel.dylib`__pthread_kill + 8
[cubic_bezier_perf_ios_sksl_warmup__timeline_summary] [STDOUT] run stdout: [        ] libsystem_kernel.dylib`__pthread_kill:
[cubic_bezier_perf_ios_sksl_warmup__timeline_summary] [STDOUT] run stdout: [        ] ->  0x1cb83584c <+8>:  b.lo   0x1cb835868               ; <+36>
[cubic_bezier_perf_ios_sksl_warmup__timeline_summary] [STDOUT] run stdout: [        ]     0x1cb835850 <+12>: stp    x29, x30, [sp, #-0x10]!
[cubic_bezier_perf_ios_sksl_warmup__timeline_summary] [STDOUT] run stdout: [        ]     0x1cb835854 <+16>: mov    x29, sp
[cubic_bezier_perf_ios_sksl_warmup__timeline_summary] [STDOUT] run stdout: [        ]     0x1cb835858 <+20>: bl     0x1cb812f5c               ; cerror_nocancel

First happened on https://github.com/flutter/flutter/commit/c8a315298b21e54fb6a22d5a0e2907da45d829c3 (so far the test has not run on any newer commits)

This passed two commits later (https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios cubic_bezier_perf_ios_sksl_warmup__timeline_summary/1253/overview), so it looks like a flake.

lowering priority as it has only happened once.

Closing as obsolete.


feat(webui): kvm sample webui

Codecov Report

Merging #266 (155c1f8) into master (804bc53) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 155c1f8 differs from pull request most recent head df2be45. Consider uploading reports for the commit df2be45 to get more accurate results

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   62.40%   62.40%
=======================================
  Files          58       58
  Lines        2865     2865
  Branches      599      599
=======================================
  Hits         1788     1788
  Misses        942      942
  Partials      135      135

Impacted Files
Coverage Δ

src/core/Utilities/KeyboardHelper.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804bc53...df2be45. Read the comment docs.

new repo (open-amt-cloud-toolkit/ui-toolkit-angular) replaces the need for this PR


String literals should not be duplicated

This pull request is focused on resolving occurrences of Sonar rule
squid:1192  String literals should not be duplicated
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:1192
Please let me know if you have any questions.
Zeeshan Asghar

i


added adbkey

This file is generated by the android SDK when making a a build through godot, but it's not actually part of the project

@ariromano any links to StackOverflow discussions or other documentation about this change?

Closing this out due to inactivity.
@ariromano if you're still interested in submitting this contribution, please open a fresh pull request and address the outstanding questions from this review.


Add vertical space between buttons when pushed onto another line

At the moment if a list of buttons is pushed onto another line the buttons crash into each other as shown here:

It would be nice if some vertical space was added like so:

As a simple suggestion, perhaps wrapping the buttons in a <div class="btn-grid"> and use the following CSS:
.btn-grid
{
    margin: -2px 0;
}

.btn-grid > .btn
{
    margin: 2px 0;
}

An example fiddle is here: https://jsfiddle.net/90y4hvmv/

Hi @MichaelRushton!
You appear to have posted a live example (https://fiddle.jshell.net/90y4hvmv/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 50, column 5: W007: Found one or more <button>s missing a type attribute.
line 51, column 5: W007: Found one or more <button>s missing a type attribute.
line 52, column 5: W007: Found one or more <button>s missing a type attribute.
line 53, column 5: W007: Found one or more <button>s missing a type attribute.
line 54, column 5: W007: Found one or more <button>s missing a type attribute.
line 55, column 5: W007: Found one or more <button>s missing a type attribute.
line 61, column 9: W007: Found one or more <button>s missing a type attribute.
line 62, column 9: W007: Found one or more <button>s missing a type attribute.
line 63, column 9: W007: Found one or more <button>s missing a type attribute.
line 64, column 9: W007: Found one or more <button>s missing a type attribute.
line 65, column 9: W007: Found one or more <button>s missing a type attribute.
line 66, column 9: W007: Found one or more <button>s missing a type attribute.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Updated fiddle: https://jsfiddle.net/90y4hvmv/1/

I don't think this is something we need to solve—seems like a rather specific set of styles depending on the content and context. Thanks though.


Completion is broken in snapshot 148

A bug was introduced in Vim 8.1.0035 that makes completion unusable when the preview window is used. See this thread on vim-dev for more detail. The bug has been fixed in 8.1.0042. I don't know your policy about releases containing serious bugs but I would suggest to remove snapshot 148 and publish a new release including patch 8.1.0042.

This seems to be fixed in snapshot 149.

Yes, it is. I'll close the issue (even though I think snapshot 148 should still be removed).


Reimplement trips detector using MotionEventHandler

I hope it is final changes related to motion detection. Your decision about way of motion detection was more than wise. We can apply it to Trips and Stops detection.
Old monstrous, unreadable function was transformed in two linear and much more clear (I hope so)
Key difference from previous algorithm:

removed greedyParking parameter, it is not needed because MotionEventHandler is "greedy both" - only continuous trips or stops can switch the state.
DeviceState is initialized by first position in report, therefore initial trips or stops also detected (even if it is shorter than needed)
To switch the state we need at least two positions, therefore we are assuming that previous position before gap and next after the gap is stopped position. It does not influence on the result, just notice.
To not rewrite MotionEventHandler I just replace KEY_MOTION attribute in retrieved from DB positions.

Two functions look similar but inverse, I think combining them in one is not good, function become monstrous again, also we will avoid unchecked type casting.

Combined methods in one with help of generics.
Made MotionEventHandler accept external newMotion
Split gap detection on variables

You are right, combined the logic, sorry that take your time.
Also unwrapped check for gap, I think it became less clear than previous version.

Yes, I think we should probably revert the check back to previous version. Sorry about that.
Everything else looks good now.

Thanks. I've merged it.


Letter r as a vowel

I propose we make the letter r a vowel. Consequently we would also have the rhotic dipthongs:
ar  er  ir  or  ur
ra  re  ri  ro  ru

This might seem like an unacceptable sacrifice of r as a more useful constant, being restricted in the same way that u and i are restricted in their use as constants, but I think there are ways to free the language of all these restrictions (e.g. #5 and #7). If we can do that, then it makes sense to allow r to also be a vowel.

It'd probably be worth having a table of the consonants and vowels somewhere, as I'm not sure how much of a difference changing a consonant to a vowel would make.
This proposal also clashes significantly with the proposal on the wiki to use rafsi as the fundamental roots.

This proposal also clashes significantly with the proposal on the wiki to use rafsi as the fundamental roots.

Wow. You've been reading that stuff!? Keep in mind that's all very exploratory at this point. Nothing solid.


add games - chess, domino, mahjong, cards and emoji symbols

This PR adds the following:

Games

Chess
Mahjong
Domino
Playing Cards

Emoji symbol

@Dayjo any additional changes you'd want to any of these additional sets before merging & releasing?

Nope looks great! 👍  Let me know when ready to publish

@Dayjo no other incoming changes from our end, so good to publish when you are

Great, are you guys able to set up the tags and releases? I can do npm publish whenever you need

I've added a minor fix for a prop name in 0195483 to be consistent with the rest of the package.

@Dayjo should be good to do npm publish now that https://github.com/Dayjo/react-character-map/releases/tag/v0.4.9 is out.  This might be something we can automate via repo settings here in GitHub, so let me know if you'd like me to look into automating that for us... thanks!

Absolutely 👍


Avoid 'BUFFER_OVERRUN' error for unsupported revert reason. Resolves #165

On some reverts reason can not be decoded. Thus let's avoid raising BUFFER_OVERRUN which is not informative.

Hi, @artob and @0x3bfc could you please take a look and approve? This would help to debug issues immensely!


Modbus RTU over TCP

Hi! Are you planning to add modbus RTU over TCP feature? For example, instead of using Modbus TCP packet, deploy Modbus RTU over TCP packet. It's very comfortable thing for getting info via virtual COM port (emulating Modbus RTU device using TCP connection).

Though it's an interesting idea, I'm still not sure it will fit into the mbusd concepts of multiplexed access to the RTU network. Need to look into this more thoroughly.

I have an initial implementation of this here. If this would be useful to anyone else I will create a pull request, but I will do some more testing first

@dasrue -- if I'm reading correctly, your implementation is still a ModbusTCP server (slave), but you added an option to make a ModbusRTU "encapsulated in TCP packets" client (master) connection to a remote device instead of accessing the remote device over a serial (TTY) connection?
I.e.:  [client-device] ---ModbusTCP(502)---> [mbusd] ---ModbusRTU-encapsulated-in-TCP-packets---> [remote device]?
If so, that's a pretty cool option.  I'd encourage submitting as a PR.


Update golangci-lint version to v1.51.0

What type of PR is this?

/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:

Does this PR have test?

Special notes for your reviewer:
Does this PR introduce a user-facing change?

Update golangci-lint to version 1.51.0.

/assign @saschagrunert

I am not sure if this is the only place where needs to be updated.

@ccojocar thanks! dependencies.yaml has to be updated for this as well.

Codecov Report

Merging #1453 (2beb309) into main (37bf104) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 2beb309 differs from pull request most recent head 80543f3. Consider uploading reports for the commit 80543f3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1453   +/-   ##
=======================================
  Coverage   44.02%   44.02%
=======================================
  Files          50       50
  Lines        5667     5667
=======================================
  Hits         2495     2495
  Misses       3052     3052
  Partials      120      120

@saschagrunert I updated also in dependencies.yaml. It seems that locally passed. Let's see the build.

/retest

/lgtm


Make FastCGI except - match prefix rather than exact file

Following this issue in Caddy.community https://caddy.community/t/excluding-folder-from-fastcgi/3833/2
with a fastcgi block except will only match an exact file
The request if for the following to work
fastcgi / /run/php/php7.0-fpm.sock php {
    except /wp-content/uploads/
}

anything that starts with /wp-content/uploads/ would be excluded.

This'll probably be handled by #1948 if/when we can get that done.

This should be a non-issue in Caddy 2 since middlewares will not have to do their own request matching.


E421: Color name or number not recognized: ctermbg=-1

environment

vim: VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Oct 19 2016 22:43:08)
vim-airline: fbd791e - (HEAD -> master, origin/master, origin/HEAD) Merge pull request #1424 from tweekmonster/powerline (4 days ago)
OS: macOS Sierra 10.12.3
Have you reproduced with a minimal vimrc: no
What is your airline configuration: default
if you are using terminal:
terminal: iterm2
$TERM variable: screen-256color
color configuration (:set t_Co?): t_Co=256
if you are using Neovim:
does it happen in Vim: ???

actual behavior
running ctrl-p or nerdtree throws the following errors:

_
Error detected while processing function airline#check_mode[45]..airline#highlighter#highlight[40]..57_exec_separator[13]..airline#highlighter#exec:
line   20:
E421: Color name or number not recognized: ctermbg=-1

@chrisbra I'm on a later version which had the fix for #1415 but I still get the error and it only started happening recently.
expected behavior
airline should not throw any errors when ctrl-p or nerdtree is opened.

Yeah,I meet the same problem.

duplicate of #1429 see #1415 for what information i need to debug this

what is the output of :hi Normal

It's:
:hi Normal
Normal         xxx ctermfg=245

And what does that return: :echo synIDattr(synIDtrans(hlID('Normal')), 'bg', 'cterm')

@chrisbra
: echo synIDattr(synIDtrans(hlID('Normal')), 'bg', 'cterm')
return -1 for me.

It returns -1, however, today after I've reinstalled the plugin to get the output of the above command, I'm no longer getting the error message.

yeah, i fixed it earlier today.


Update the Github Workflow for uploading conda packages

The anaconda upload token is stored as a secret on github.

I think it will be better to create a new separate workflow for publishing conda packages. In the conda package workflow, the build should not use ENABLE_TEST unless it is building a dev package for developers not a normal package for users. This will make the built code faster because it can use compiler optimizations which are not available in test mode and smaller because it does not contain the debug information.
The packaging workflow (for conda, pypi, debian, docker, etc) should not contain the code coverage steps because (1) the code is usually not built with test enabled. (2) there is no need to upload a new coverage report for the same python test cases unless there are special test cases for the the package process itself.
The packaging workflow may not run with each pull request or merge on the dev branch, but they can run periodically every week for example or only when merging with the master branch.

I think it will be better to create a new separate workflow for publishing conda packages. In the conda package workflow, the build should not use ENABLE_TEST unless it is building a dev package for developers not a normal package for users. This will make the built code faster because it can use compiler optimizations which are not available in test mode and smaller because it does not contain the debug information.

The packaging workflow (for conda, pypi, debian, docker, etc) should not contain the code coverage steps because (1) the code is usually not built with test enabled. (2) there is no need to upload a new coverage report for the same python test cases unless there are special test cases for the the package process itself.
The packaging workflow may not run with each pull request or merge on the dev branch, but they can run periodically every week for example or only when merging with the master branch.

Currently,

CPP test is done by native-macos and native-ubuntu for every PR, for which ENABLE_TEST is on.
Python test is done by conda for every PR, for which ENABLE_TEST is off.
conda package uploading is disabled on apache/singa because we cannot set the secret key for the uploading token.

I am fine to disable code coverage for 2 and 3, i.e., conda.yaml.
How should we disable it?

conda package uploading is disabled on apache/singa because we cannot set the secret key for the uploading token

Why we cannot set the secret key? Can we ask INFRA to add the key as discussed in #790?


Add assertion for multiple documentations of the same explicit path.

In extractDocumentationWithPathScanning multiple documentations with the same path are found. The the method seems to pick the last of the listed, not caring about multiple options. I suggest inserting a check for this, and not failing silently
See #883 for bug discovery

The failing test is a test, that has previously overitten its predecessor in the right order. I do not know what to do with it.

The failing test is a test, that has previously overitten its predecessor in the right order. I do not know what to do with it.

When I added my first OpenAPI feature, I created a standalone test: TestOpenApiExample (I was a bit frustrated with the OpenAPI tests since they are all coupled).
Could you move the failing test to a standalone test like this?

sounds good to me

did not work, id adapted the test.

Looks good, thanks!


fix resource not found error message

There are some outdated error messages for when a resource is not found. It references add_resource and add_non_send_resource which were renamed to insert_resource and insert_non_send_resource.

bors retry


html_check

What does the program do ?
This bash script checks whether in an html file all the tags are correctly opened as well as closed. You can call it html _tags_syntax_parser.
In what programming language it is written?
Written in bash.

Thank you for participating  in hacktoberfest ❣ if you liked working on this repo you can share it with friends and star this project for helping others


flutter build ipa does not create ipa file

[newbie here] I am following the documentation https://docs.flutter.dev/deployment/ios for deploying my app on apple store. The command flutter build ipa runs OK but does not create an ipa file:

Running "flutter pub get" in *****...                        3.2s
Archiving *****...
Automatically signing iOS for device deployment using specified development team in Xcode project: *****
Running pod install...                                             12.8s
Running Xcode build...
└─Compiling, linking and signing...                        13.5s
Xcode archive done.                                         247.4s
Built *****/build/ios/archive/Runner.xcarchive.
💪 Building with sound null safety 💪

I tried to run flutter clean before build ipa but it didn't work. Any suggestions? Thank you!

Flutter doctor -v
[✓] Flutter (Channel stable, 2.10.2, on macOS 12.3.1 21E258 darwin-arm, locale en-US)
    • Flutter version 2.10.2 at /Users/concordiahs/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 097d3313d8 (3 months ago), 2022-02-18 19:33:08 -0600
    • Engine revision a83ed0e5e3
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/concordiahs/Library/Android/sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

Hi @whateverfast, I tested this with a dummy project on flutter 3, and successfully generated the IPA file.
I also tested on flutter 2.10.1 and the ipa wasn't generated.
Seeing as this works as expected on flutter 3 but not flutter 2.10, this issue has been fixed.
Kindly upgrade to flutter 3.
Closing as this has been fixed in recent versions.
If you run into this issue after upgrading to flutter 3, kindly leave a comment below and I will reopen this.
Thank you

log
flutter build ipa
Archiving com.pings.txtt...
Automatically signing iOS for device deployment using specified development team in Xcode project: X8NNQ9CYL2
Running pod install...                                             622ms
Running Xcode build...
 └─Compiling, linking and signing...                        10.6s
Xcode archive done.                                         38.2s
Built /Users/nexus/projects/nevercode/txtt/build/ios/archive/Runner.xcarchive.

💪 Building with sound null safety 💪

Building App Store IPA...                                          68.1s
Built IPA to /Users/nexus/projects/nevercode/txtt/build/ios/ipa.
To upload to the App Store either:
    1. Drag and drop the "build/ios/ipa/*.ipa" bundle into the Apple Transport macOS app https://apps.apple.com/us/app/transporter/id1450874784
    2. Run "xcrun altool --upload-app --type ios -f build/ios/ipa/*.ipa --apiKey your_api_key --apiIssuer your_issuer_id".
       See "man altool" for details about how to authenticate with the App Store Connect API key.

flutter doctor -v
[✓] Flutter (Channel stable, 3.0.0, on macOS 12.3.1 21E258 darwin-arm, locale en-GB)
    • Flutter version 3.0.0 at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ee4e09cce0 (8 days ago), 2022-05-09 16:45:18 -0700
    • Engine revision d1b9a6938a
    • Dart version 2.17.0
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-32, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

[✓] VS Code (version 1.67.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.40.0

[✓] Connected device (4 available)
    • Nexus (mobile)     • 00008020-001875E83A38002E            • ios            • iOS 15.4.1 19E258
    • iPhone 13 (mobile) • DBB48503-41CE-4969-9043-3261726E438A • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-4 (simulator)
    • macOS (desktop)    • macos                                • darwin-arm64   • macOS 12.3.1 21E258 darwin-arm
    • Chrome (web)       • chrome                               • web-javascript • Google Chrome 101.0.4951.64

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!


testnet, rewards differ between ledger and db-sync

OS
Your OS: Ubuntu 20.04
[db-sync-node:Info:6] [2021-09-28 15:40:53.89 UTC] Schema migration files validated
[db-sync-node:Info:6] [2021-09-28 15:40:53.89 UTC] Running database migrations
[db-sync-node:Info:6] [2021-09-28 15:40:56.54 UTC] Using byron genesis file from: "/home/ubuntu/cardano/testnet/testnet-byron-genesis.json"
[db-sync-node:Info:6] [2021-09-28 15:40:56.54 UTC] Using shelley genesis file from: "/home/ubuntu/cardano/testnet/testnet-shelley-genesis.json"
[db-sync-node:Info:6] [2021-09-28 15:40:56.54 UTC] Using alonzo genesis file from: "/home/ubuntu/cardano/testnet/testnet-alonzo-genesis.json"
[db-sync-node:Info:6] [2021-09-28 15:40:56.61 UTC] NetworkMagic:<PHONE_NUMBER>
[db-sync-node:Info:6] [2021-09-28 15:40:56.64 UTC] Initial genesis distribution present and correct
[db-sync-node:Info:6] [2021-09-28 15:40:56.64 UTC] Total genesis supply of Ada:<PHONE_NUMBER>9.999903
[db-sync-node:Info:6] [2021-09-28 15:40:56.64 UTC] Inserting Shelley Genesis distribution
[db-sync-node:Info:6] [2021-09-28 15:40:56.64 UTC] localInitiatorNetworkApplication: connecting to node via "/home/ubuntu/cardano/testnet/db/node.socket"
[db-sync-node.Subscription:Notice:65] [2021-09-28 15:40:56.64 UTC] Identity Starting Subscription Worker, valency 1
[db-sync-node.Subscription:Notice:66] [2021-09-28 15:40:56.64 UTC] Identity Connection Attempt Start, destination LocalAddress "/home/ubuntu/cardano/testnet/db/node.socket"
[db-sync-node.Subscription:Notice:66] [2021-09-28 15:40:56.64 UTC] Identity Connection Attempt End, destination LocalAddress "/home/ubuntu/cardano/testnet/db/node.socket" outcome: ConnectSuccessLast
[db-sync-node.Handshake:Info:66] [2021-09-28 15:40:56.64 UTC] WithMuxBearer (ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "/home/ubuntu/cardano/testnet/db/node.socket"}) Send (ClientAgency TokPropose,MsgProposeVersions (fromList [(NodeToClientV_1,TInt<PHONE_NUMBER>),(NodeToClientV_2,TInt<PHONE_NUMBER>),(NodeToClientV_3,TInt<PHONE_NUMBER>),(NodeToClientV_4,TInt<PHONE_NUMBER>),(NodeToClientV_5,TInt<PHONE_NUMBER>),(NodeToClientV_6,TInt<PHONE_NUMBER>),(NodeToClientV_7,TInt<PHONE_NUMBER>),(NodeToClientV_8,TInt<PHONE_NUMBER>),(NodeToClientV_9,TInt<PHONE_NUMBER>)]))
[db-sync-node.Handshake:Info:66] [2021-09-28 15:40:56.64 UTC] WithMuxBearer (ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "/home/ubuntu/cardano/testnet/db/node.socket"}) Recv (ServerAgency TokConfirm,MsgAcceptVersion NodeToClientV_9 (TInt<PHONE_NUMBER>))
[db-sync-node.Mux:Info:66] [2021-09-28 15:40:56.64 UTC] Bearer on ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "/home/ubuntu/cardano/testnet/db/node.socket"} event: Handshake Client end, duration 0.000456294s
[db-sync-node.Mux:Info:67] [2021-09-28 15:40:56.64 UTC] Bearer on ConnectionId {localAddress = LocalAddress "", remoteAddress = LocalAddress "/home/ubuntu/cardano/testnet/db/node.socket"} event: State: Mature
[db-sync-node:Info:70] [2021-09-28 15:40:56.64 UTC] Starting chainSyncClient
[db-sync-node:Info:70] [2021-09-28 15:40:56.66 UTC] Cardano.Db tip is at slot 6782373, block 1851160
[db-sync-node:Info:75] [2021-09-28 15:40:56.66 UTC] Running DB thread
[db-sync-node:Info:75] [2021-09-28 15:40:56.67 UTC] Rolling back to slot 6782373, hash 41241024b08ec38913fda0269d9f195f6df104efda1c4f327855241463d2e415
[db-sync-node.Subscription:Notice:65] [2021-09-28 15:40:56.67 UTC] Identity Required subscriptions started
[db-sync-node:Info:75] [2021-09-28 15:40:56.67 UTC] No blocks need to be deleted
[db-sync-node:Info:75] [2021-09-28 15:40:57.32 UTC] Found snapshot file for slot 6782373, hash 41241024b08ec38913fda0269d9f195f6df104efda1c4f327855241463d2e415
[db-sync-node:Info:78] [2021-09-28 15:40:57.40 UTC] getHistoryInterpreter: acquired
[db-sync-node:Info:87] [2021-09-28 15:40:57.40 UTC] Running Offline fetch thread
[db-sync-node:Info:75] [2021-09-28 15:40:57.40 UTC] thisIsAnUglyHack: Main thead
[db-sync-node:Info:75] [2021-09-28 15:40:57.40 UTC] File ../../cardano-src/cardano-db-sync/ledger-state/testnet/6782373-41241024b0-85.lstate exists
[db-sync-node:Info:75] [2021-09-28 15:40:57.40 UTC] Starting at epoch 86
[db-sync-node:Info:75] [2021-09-28 15:40:57.40 UTC] Handling 256 stakes for epoch 86 slot 6782400, hash 3fdfbd1bed0358d16778ae4d0bd5e46212cff3d1a9a155a1fb8574fbb7f10497
[db-sync-node:Warning:75] [2021-09-28 15:40:57.55 UTC] validateEpochRewards: rewards earned in epoch 84 expected total of<PHONE_NUMBER>7 ADA but got<PHONE_NUMBER>7 ADA
dbMap length: 27
ledgerMap length: 27
diffMap length: 3
e03412de65e523666ef5df0a7c3db510b99b0553b67f324f0ba215af82 (118244, 1): [(RwdMember,DbLovelace 118244)], Coin 100118244
e07821cc41d016e17e2f6e37a8c1ba8a3caaaf52d44b80a557b4cc4d98 (128667, 1): [(RwdMember,DbLovelace 128667)], Coin 100128667
e09cd7cd070bbcc65f75b460a3f4462e3445f11a7f2f1a49825a10f88d (128667, 1): [(RwdMember,DbLovelace 128667)], Coin 100128667
Rewards differ between ledger and db-sync.
Please report at https://github.com/input-output-hk/cardano-db-sync/issues.
ubuntu@ip-172-31-86-6:~/cardano/testnet$ cardano-db-sync --version
cardano-db-sync 11.0.0 - linux-x86_64 - ghc-8.10
git revision e2d5cf8068c030ed3c8006ce008b4100fbaad581
ubuntu@ip-172-31-86-6:~/cardano/testnet$ cardano-node --version
cardano-node 1.30.0 - linux-x86_64 - ghc-8.10
git rev ed7fdbf65f40f8e194850b87dd8c631fe26154e6

Duplicate of #805.


Allow configuring if/when the test view opens automatically on test run

Like debug, we should open by default when a test is run. Requested by the Java team.
cc @jdneo

Verifier:

Check that the test view shows by default, like debug does
Check that the other options of testing.openTesting work as expected


TestMode not working with login and test email

✅ Prerequisites

[x] Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
[x] Are you running the latest SDK version?
[x] Are you reporting to the correct repository (magic-sdk)?

🐛 Description
When testMode is enabled, the login doesn't work and creates an error on the service (backend?). The login fails:
      error_code: 'RESOURCE_NOT_FOUND',
      message: 'Given issuer resource not found.',

Set up according to tutorial:
https://magic.link/posts/magic-link-nextjs
Followed all directions from the documentation:
https://magic.link/docs/auth/introduction/test-mode
🧩 Steps to Reproduce

Enable test mode:

      const magic = new Magic(process.env.NEXT_PUBLIC_MAGIC_PUBLISHABLE_KEY, {
        testMode: true,
      });

Use magic link test password:
<EMAIL_ADDRESS>
Submit form.
🤔 Expected behavior
Logs the user in
😮 Actual behavior
Stack trace:
MagicAdminSDKError: Magic Admin SDK Error: [SERVICE_ERROR] A service error occurred while communicating with the Magic API. Check the `data` key of this error object to see nested errors with additional context.
    at new MagicAdminSDKError (/Users/hope/workspace/kulaa-nextjs-contentful/node_modules/.pnpm/@magic-sdk+admin@1.8.0/node_modules/@magic-sdk/admin/dist/cjs/core/sdk-exceptions.js:22:28)
    at Object.createServiceError (/Users/hope/workspace/kulaa-nextjs-contentful/node_modules/.pnpm/@magic-sdk+admin@1.8.0/node_modules/@magic-sdk/admin/dist/cjs/core/sdk-exceptions.js:62:12)
    at /Users/hope/workspace/kulaa-nextjs-contentful/node_modules/.pnpm/@magic-sdk+admin@1.8.0/node_modules/@magic-sdk/admin/dist/cjs/utils/rest.js:85:48
    at step (/Users/hope/workspace/kulaa-nextjs-contentful/node_modules/.pnpm/@magic-sdk+admin@1.8.0/node_modules/@magic-sdk/admin/dist/cjs/utils/rest.js:33:23)
    at Object.next (/Users/hope/workspace/kulaa-nextjs-contentful/node_modules/.pnpm/@magic-sdk+admin@1.8.0/node_modules/@magic-sdk/admin/dist/cjs/utils/rest.js:14:53)
    at fulfilled (/Users/hope/workspace/kulaa-nextjs-contentful/node_modules/.pnpm/@magic-sdk+admin@1.8.0/node_modules/@magic-sdk/admin/dist/cjs/utils/rest.js:5:58)
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  code: 'SERVICE_ERROR',
  data: [
    {
      data: {},
      error_code: 'RESOURCE_NOT_FOUND',
      message: 'Given issuer resource not found.',
      status: 'failed'
    }
  ]
}

💻 Code Sample
🌎 Environment

Software
Version(s)

magic-sdk
"^11.0.0"

Browser
Chrome Version 108.0.5359.124 (Build officiel) (arm64)

pnpm
7.18.2

Operating System
macOS 12.5.1

Hi @drewdrewthis, testMode is only supported on our client-side SDK. The resolved didToken from the loginWithMagicLink method isn't supported in our server-side SDK. We'll aim to make this more clear in the documentation and will take steps to make this more obvious.

@ayv8er thanks for the response. I believe I am using the client-side SDK 'magic-sdk' --- it's running in the browser.
This should work, should it not?
import { Magic } from "magic-sdk";
...
const magic = new Magic(process.env.NEXT_PUBLIC_MAGIC_PUBLISHABLE_KEY, {
  testMode: true,
});

const didToken = await magic.auth.loginWithMagicLink({
  email<EMAIL_ADDRESS>});


Add document_collection schema

Details:

Body is optional for collections
First public at is required like other editioned content
A document collection must have an ordered list of groups

Each group must have a title and an ordered list of documents, the group may have some body copy

Collections can be political
Collections can be withdrawn
Include tags – these are not really used except for emails, see #292 for why they weren't removed from other formats

Links:

Add documents GUID list, make this a required field
Whitehall marks "policy areas" as being required in the editor, but content schemas say this is "largely deprecated", so it has been intentionally left out. (Policy areas are included by base links)
Add topical events
Lead organisations are also required, we've changed the pattern for organisations to "organisations" in links and emphasised organisations in details – there isn't a pattern yet for which bits must be required
to match current behaviour.

Include example based on:
https://www.gov.uk/government/collections/national-driving-and-riding-standards
https://trello.com/c/PMeMQb5E/410-11-document-collection-migration-mvp-content-schema-examples-and-front-end-work

Government frontend WIP to render this format:
https://github.com/alphagov/government-frontend/compare/mvp-document-collections

Closing while adding more examples.

Test failures are unrelated.


[feature request] Tabular view

Hi 👋
We have 21 repos added to Dependabot and I feel they would be better presented in table form.
Things I would like to do:

sort by language
sort by last checked
sort by weekly, daily
turn on/off extra columns like the ones that are hidden behind "Edit button", for example "Only security patches"
maybe filter/search some of the entries

Thanks for considering it.

Closing this as the Dependabot.com dashboard will be sunset in favor of experiences built into GitHub.


Error: Invalid loss, terminating training

I have been attempting to fine-tune the model GN_W1.3_S1_ArcFace_epoch46.h5 on my custom dataset. I followed the steps to download, extract, and convert the faces_emore dataset as instructed, and then I added 30 new people with 5000 images to the dataset. Therefore, the dataset is essentially the same as the original one.
I set the batch size to 200 and used GN_W1.3_S1_ArcFace_epoch46.h5 as the starting point model. Initially, the accuracy starts from zero that is strange, because when we use a pretrained model on the same dataset, we would expect the accuracy to start form a sensible value (at least over 0.9), and I guess something is wrong at this stage.
Strangely enough, the accuracy starts to grow after some iterations and everything seemed to be progressing well during the first epoch, with the accuracy steadily increasing over time and reaching 0.8.
However, when the first epoch completed and the second epoch began, I encountered the following error message: Error: Invalid loss, terminating training.
What could be the cause of this error?

I have been attempting to fine-tune the model GN_W1.3_S1_ArcFace_epoch46.h5 on my custom dataset. I followed the steps to download, extract, and convert the faces_emore dataset as instructed, and then I added 30 new people with 5000 images to the dataset. Therefore, the dataset is essentially the same as the original one.
I set the batch size to 200 and used GN_W1.3_S1_ArcFace_epoch46.h5 as the starting point model. Initially, the accuracy starts from zero that is strange, because when we use a pretrained model on the same dataset, we would expect the accuracy to start form a sensible value (at least over 0.9), and I guess something is wrong at this stage.
Strangely enough, the accuracy starts to grow after some iterations and everything seemed to be progressing well during the first epoch, with the accuracy steadily increasing over time and reaching 0.8.
However, when the first epoch completed and the second epoch began, I encountered the following error message: Error: Invalid loss, terminating training.
What could be the cause of this error?

Hi,
This termination event is triggered from the script "myCallbacks.py" at line 30.
To address this issue, I suggest exploring alternative optimization strategies, such as utilizing AdamW or SGDW instead of L2 regularizer. Additionally, adjusting the learning rate to a smaller value and employing a scheduler with parameters such as {"loss": losses.ArcfaceLoss(scale=16), "epoch": 1, "optimizer": optimizer} as the first scheduler may offer potential solutions.


getStyleTags() seems to work fine with renderToNodeStream when using prepass

I'm building an application using loadable-components and server side rendering. The server render is making use renderToNodeStream to stream the response to the client.
According to the docs here, you cannot use getStyleTags() when streaming the response.
However, i notice when using prepass (react-ssr-prepass) to fetch my data i'm then able to use the chunk extractor to get my styletags via .getStyleTags() and append them onto the end of the head.
Simplified example. This appears to function correctly:
const streamRequest = async (req, res) => {

    const serverModule = new ChunkExtractor({
        statsFile: path.resolve('stats-server.json')
    }).requireEntrypoint();

    res.write(`<!doctype html><html><head>`);

    const clientExtractor = new ChunkExtractor({
        statsFile: path.resolve('stats-client.json'),
    });

    const urqlClient = getClient(true);

    const jsx = serverModule.render(
        urqlClient
    );

    const chunks = clientExtractor.collectChunks(jsx);

    // fetch data
    await prepass(chunks);

    res.write(`${clientExtractor.getStyleTags()}</head><body><div id="root">`);

    // stream
    const nodeStream = renderToNodeStream(chunks);

    nodeStream.pipe(res, {end: false});
    nodeStream.on("end", () => {
        res.write(
            `</div>
             	<!-- populate data etc here -->
                ${clientExtractor.getScriptTags()}
            </body>
            </html>`
        );
        res.end();
    });
};

So my question becomes, is this valid and are there any issues with doing this? it seems to work just fine.
I appreciate this is linked to react-ssr-prepass too, but thought it make more sense here.

Yes, with prepass you should be more or less safe to include styles in the head.
However, with prepass there is not much sense to use renderToNodeStream - it's an optimisation technique and prepass already consumed any time you can "optimize" that way.

Yes, with prepass you should be more or less safe to include styles in the head.
However, with prepass there is not much sense to use renderToNodeStream - it's an optimisation technique and prepass already consumed any time you can "optimize" that way.

Thank you for clarifying, that was roughly my understanding. There is still the benefit in terms of lowering the TTFB, by at least sending something straight away (head with meta info etc).

Yep. And all other optimisation must be picked based on how fast or slow prepass is.


Pyright

Fixes a few things and adds a config for pyright. There are more errors caused by old client that are not worth fixing

Codecov Report
Attention: 269 lines in your changes are missing coverage. Please review.

Comparison is base (a26557b) 89.38% compared to head (6c50196) 89.28%.
Report is 273 commits behind head on beta/v4.0.

Files
Patch %
Lines

integration/test_collection_openai.py
33.33%
38 Missing :warning:

weaviate/collections/batch/base.py
83.52%
28 Missing :warning:

weaviate/collections/data.py
77.46%
16 Missing :warning:

weaviate/collections/filters.py
72.41%
16 Missing :warning:

integration/test_collection_rerank.py
26.31%
14 Missing :warning:

weaviate/collections/batch/batch_wrapper.py
78.18%
12 Missing :warning:

weaviate/collections/batch/grpc_batch_objects.py
86.07%
11 Missing :warning:

weaviate/collections/config.py
66.66%
10 Missing :warning:

weaviate/client.py
84.48%
9 Missing :warning:

weaviate/collections/grpc/query.py
60.86%
9 Missing :warning:

... and 31 more

Additional details and impacted files
@@              Coverage Diff              @@
##           beta/v4.0     #754      +/-   ##
=============================================
- Coverage      89.38%   89.28%   -0.11%
=============================================
  Files            154      171      +17
  Lines          16747    17959    +1212
=============================================
+ Hits           14970    16034    +1064
- Misses          1777     1925     +148

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Ju 734/feat add docker ecs config

This needs to be redirected to merge into the migration parent branch


python12Packages.pytest-regressions: remove unused disabledTestPathss

This was added in #271586 (@mweinelt), but never used due to the spelling mistake of a double s.
python312Packages.pytest-regressions  builds fine, though.
Things done

Built on platform(s)

[x] x86_64-linux

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

It does now!

Can you create a new PR targeting staging instead?


[IA-3906] Add keys to divs in analysisNameValidator message

I don't see why this is required since the two divs are wrapped in a Fragment, but adding keys here avoids this warning from yarn test. Run yarn test AnalysisDuplicator with and without keys to see the difference.
 console.error
    Warning: Each child in a list should have a unique "key" prop. See https://reactjs.org/link/warning-keys for more information.
        at div
        at div
        at fn (./terra-ui/src/components/TooltipTrigger.js:94:27)
        at fn (./terra-ui/src/components/common/Clickable.js:10:6)
        at fn (./terra-ui/src/components/common/buttons.js:20:33)
        at div
        at div
        at div
        at construct (./terra-ui/.yarn/__virtual__/react-modal-virtual-c7ef39855c/0/cache/react-modal-npm-3.14.3-22dde5a95f-025605ad33.zip/node_modules/react-modal/lib/components/ModalPortal.js:70:5)
        at construct (./terra-ui/.yarn/__virtual__/react-modal-virtual-c7ef39855c/0/cache/react-modal-npm-3.14.3-22dde5a95f-025605ad33.zip/node_modules/react-modal/lib/components/Modal.js:73:5)
        at fn (./terra-ui/.yarn/cache/jest-mock-npm-27.5.1-22d1da854d-f5b5904bb1.zip/node_modules/jest-mock/build/index.js:107:19)
        at fn (./terra-ui/src/pages/workspaces/workspace/analysis/modals/AnalysisDuplicator.ts:40:38)

I think a key is necessary when you are using the map function, which the tooltip trigger does. It is trying to set keys in that code… I'm trying to figure out what is going wrong there.

I think the issue is that Utils.summarizeErrors uses the map function, which means that things inside it need to have keys. Since the error being rendered here is a Fragment that contains 2 divs, that causes the issue. I don't believe that Utils.summarizeErrors was meant to take something besides strings.
So this change is probably fine, the element being returned from the validation could be changed to be more inline with what summarizeErrors expects.

I think the issue is that Utils.summarizeErrors uses the map function, which means that things inside it need to have keys.

Yeah, but Utils.summarizeErrors sets on a key on the elements of the returned array.
https://github.com/DataBiosphere/terra-ui/blob/24bceb0c1f6ed8e0010d76ffd2f98a8e915f3504/src/libs/utils.js#L228-L230

I don't believe that Utils.summarizeErrors was meant to take something besides strings.
So this change is probably fine, the element being returned from the validation could be changed to be more inline with what summarizeErrors expects.

Agreed. I think I'll try that.

There seems to be something else going on here. The key warning would make sense to me if there was no Fragment and message was set to an array of divs.
Rendering this elsewhere doesn't cause a warning about keys.
[
  div({ key: 'a-key' }, [
    h(Fragment, [
      div(['Name can\'t contain these characters:']),
      div({ style: { margin: '0.5rem 1rem' } }, ['@ # $ % * + = ? , [ ] : ; / \\ ']),
    ])
  ])
]

Still don't understand why the warning is being shown, but I'm going to leave this as is to avoid formatting changes caused by changing message to a string.


create a SourceLinkHelper for FAKE

That wraps SourceLink.exe like paket.exe is wrapped with:
https://github.com/fsharp/FAKE/blob/master/src/app/FakeLib/PaketHelper.fs

Same thing as #123 regarding CAKE support. I'm expecting this should be easy to do if there is demand and it is needed beyond the dotnet + msbuild tooling.


⚠ Tukarcoid has degraded performance

In deebece, Tukarcoid (https://tukar.co.id) experienced degraded performance:

HTTP code: 200
Response time: 2614 ms

Resolved: Tukarcoid performance has improved in c177a9e after 30 minutes.


Processor tests

This PR implements tests for the processor methods, intends to clean up the processor code somewhat, and fix bugs detected on the way

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

277 of 292 (94.86%)  changed or added relevant lines in 6 files are covered.
55 unchanged lines in 4 files lost coverage.
Overall coverage increased (+7.2%) to 81.154%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sed/calibrator/momentum.py
20
24
83.33%

sed/calibrator/energy.py
24
35
68.57%

Files with Coverage Reduction
New Missed Lines
%

sed/binning/numba_bin.py
3
87.74%

sed/calibrator/energy.py
3
84.44%

sed/loader/utils.py
7
51.85%

sed/loader/flash/loader.py
42
57.48%

Totals

Change from base Build<PHONE_NUMBER>:
7.2%

Covered Lines:
3501

Relevant Lines:
4314

💛  - Coveralls

Closes #140, closes #141, closes #153


Add import-key subcommand

It should be possible to import keys trough Parsec-tool with an import-key command as that functionality exists in Parsec. This should support at least Mbed-crypto. It shoud take the key or key pair we want to import as an input and at least EccKeyPair should be supported.

Hi @miroheikkonenabb, thanks for the request. We're happy to get this integrated into the tool and we'd be grateful if you contribute it - we can offer guidance for navigating the code and feedback on the PR.
In terms of interface design, we'll need to settle a few questions before comitting to an implementation:

What types of keys do we need to support? You mention EccKeyPair, so no RSA keys for now, but are there specific elliptic curve families that you need supported, e.g., SECP-R1? (this might be irrelevant, depending on how we select or default the attributes for the key we're importing, or if we pick them up from a file, see below)
What format should the keys be in? Is PEM sufficiently comprehensive in what it contains? This MbedTLS article seems to imply that, for RSA keys at least, there are multiple encodings. For ECC keys, though, I assume PKCS#8 will apply.
How should the parameters for the keys be passed to the tool? Will they be included in the encoding used within the PEM file, for example? The subjectPublicKeyInfo and ECPrivateKey definitions seem to include everything we'd need, but this depends on what you expect to be available.
Should the interface be tailored to resemble creating keys? At the moment we have create-rsa-key and create-ecc-key, but that was for ease of defaulting arguments, so if the key attributes are available some other way then a simple import-key might work reasonably well

HI!
We are not using RSA so it's enough for us to get import-ecc-key subcommand which has support for SECP256-R1 EccKeyPair.
As a parameter PEM private key with PKCS#8 encryption would be used. Export-public-key and create-csr create PEM so I'm guessing it should have all the necessary information.
As a suggestion: there could be flags the same way that create-key commands have: "--for-crypt" and "--for-signing"

I think that ECC keys are universally used for signing, so we could probably default to that and not need a switch. (RSA keys default to encryption, and support "--for-signing" to override the default. The create-ecc-key function always creates a signing key, and I think import-ecc-key should probably do the same.
PEM PKCS#8 as input makes sense, although we might want to think ahead to how the CLI commands should process multiple input types. At the moment, export-public-key produces PEM PKCS#8, but that's because we see that as being the most useful default, and the tool tries to always do the most useful thing with minimal typing. We could add switches later to override and output different formats, if there is a need for that. So we want to make sure that any new import commands have some kind of protocol associated with them so that we can be more flexible on file formats in the future, possibly accepting DER for instance. I would suggest that we just assume PEM PKCS#8 for now. Future evolution can either be done by adding a switch parameter or by auto-detecting the format if that's feasible and reliable.
@miroheikkonenabb would you be interested in contributing this as a PR? We would love to work on this with you collaboratively, and we can provide as much guidance and help as needed. We are actively seeking to grow the Parsec community and have PRs coming in from a diverse set of participants and organisations. This helps with the health of a project from a CNCF growth standpoint as well.


Appstudio update test-component-pac-ftpq

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-ftpq-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
22 seconds
init

✅ Succeeded
24 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
40 seconds
deprecated-base-image-check

✅ Succeeded
36 seconds
inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
34 seconds
sbom-json-check

✅ Succeeded
13 seconds
label-check

✅ Succeeded
7 seconds
show-sbom

✅ Succeeded
7 seconds
show-summary

Pipelines as Code CI/test-component-pac-ftpq-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
init

✅ Succeeded
20 seconds
clone-repository

✅ Succeeded
25 seconds
build-container

✅ Succeeded
15 seconds
deprecated-base-image-check

✅ Succeeded
14 seconds
clair-scan

✅ Succeeded
18 seconds
inspect-image

✅ Succeeded
51 seconds
clamav-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
7 seconds
label-check

✅ Succeeded
8 seconds
show-sbom

✅ Succeeded
8 seconds
show-summary


How to handle multi-mod bundles?

Some mods (e.g Project Hoshikuzu) will bundle multiple mods in an archive. How should this be handled?
Current Behavior: fail to install
Potential future behaviors:

Continue to not support this feature
Allow selecting which folder(s) to install

could install all of them without asking and list both to have the same mod id for easy to update

also related to mods with a different file structure:

could import every folder that has a config.toml inside to prevent problems


Logsink destination is 'storage', not 'bucket'

https://github.com/GoogleCloudPlatform/deploymentmanager-samples/blob/9e38d8d75489c7660a0d6a424988d86809db66bf/community/cloud-foundation/templates/logsink/examples/project_logsink_bucket_destination.yaml#L34
"Bucket" is not an accepted destination. It has to be "storage"

PR#336
https://github.com/GoogleCloudPlatform/deploymentmanager-samples/pull/336

Fixed


Overwrite Extraction with Original Folder Structure

:+1::tada: First off, thanks for taking the time to contribute! :tada::+1:
Please fill out the following checklist:

[x] Added tests for any bug fixes that changed existing code
[x] Added tests for any new behavior
[x] All unit tests are passing (please make sure all tests are passing for your branch/PR at https://ci.appveyor.com/project/activescott/lessmsi/history )

If you need any help at all, feel free to submit the PR and @-mention activescott and I'll be happy to assist!
Hello @activescott.
I took care of this ticket.
I implemented a logic for detecting and deleting any duplicate files after a file extraction.
I added some tests to cover this feature from different points of view, such as regular extraction, extraction with a defined path and an extraction with specific files.
The newly added tests use a new MSI file I added called “AppleMobileDeviceSupport64.msi”.
I know this file contains duplicate files, thus making it a prefect match for testing this new overwrite extraction.
I’d greatly appreciate if you could review my pull request.
Thank you.

also, please update the branch (you can use the github ui to update it and then pull it again locally from your own branch).

@mega5800 Let me know if you have concerns or if there is some way I can help you get this merged. I would like the simplification done, but I can do it if it is too much of a burden for you right now. I appreciate your contributions and I do not want to cause you trouble!

Hello @activescott.
I am currently away and will work on your comments next week.
Happy new year!


Quick Filter not CONCATing multiple columns in QuickFilter

I am using the Meetings sample code but I am not able to get the QuickFilter dropdown to show both the first and last names. It is only showing the last name; however, the grid column is showing the same column with both concatenated properly.
Any ideas?
*Row.cs
        // This is what is displayed on the column and quick filter
        [DisplayName("Reporter1")]
        [Expression("CONCAT(jReporterOrgPerson.[FirstName], ' ', jReporterOrgPerson.[LastName])")]
        [Expression("(jReporterOrgPerson.FirstName || ' ' || jReporterOrgPerson.LastName)", Dialect = "Sqlite")]
        public String ReporterFullName
        {
            get { return Fields.ReporterFullName[this]; }
            set { Fields.ReporterFullName[this] = value; }
        }

        [LookupEditor(typeof(OrgPersonRow), InplaceAdd = true)] //, InplaceAddPermission = CorePermissionKeys.Locations.Management)]
        [DisplayName("Reporter2"), ForeignKey("[core].[OrgPerson]", "OrgPersonId"), LeftJoin("jReporterOrgPerson"), TextualField("ReporterFullName")]
        public Int32? ReporterOrgPersonId
        {
            get { return Fields.ReporterOrgPersonId[this]; }
            set { Fields.ReporterOrgPersonId[this] = value; }
        }

*Column.cs
        [Width(150), QuickFilter]
        public String ReporterFullName { get; set; }

Note the same is true for the Attendees dropdown and the attendees list. Also organizer.

in personRow
        StringField INameRow.NameField
        {
            get { return Fields.ReporterFullName; }
        }

or create lookup
namespace Serene.Northwind.Lookups
{
    using Serenity.ComponentModel;
    using Serenity.Data;
    using Serenity.Web;

    [LookupScript]
    public class CustomerCountryLookup : RowLookupScript<Entities.CustomerRow>
    {
        public CustomerCountryLookup()
        {
            IdField = "PersonId"
            TextField = "FirstName+' '+LastName";
        }

        protected override void PrepareQuery(SqlQuery query)
        {
        }
        protected override void ApplyOrder(SqlQuery query)
        {
        }
    }
}

https://github.com/volkanceylan/Serene/blob/master/Serene/Serene.Web/Modules/Northwind/Customer/CustomerCountryLookup.cs

@Zahar661 Wow, I stared at that code so many times and missed that! You rock, thank you very much. IT was the NameField as you mentioned.


Once in edit mode, control stays there forever until I click "SET"

I think it should go back to display mode if entire control looses focus (like, when I click another tab or control or anything).

Unfortunately, out of focus detection triggers when up/down buttons are clicked so I can't use that event. As a workaround, canceling edit mode when property name is clicked for now.


ButtonGroupInput attempts to spread FormField props onto underlying DOM element.

A ButtonGroupInput inside a FormField will attempt to pass along certain FormField to its underlying DOM element, causing a nasty react bug:

Observed with setting commitOnChange on the FormField, but I suspect it may occur with other FormField props.
(Edit: You may think "Just don't set commitOnChange: true on a ButtonGroupInput FormField, it doesn't make sense" and you would be right - in this case, it was being set via formFieldDefaults. But regardless of how it gets set, we are advertising commitOnChange as a FormField prop through TypeScript. Even if it has no effect for this particular HoistInput, devs should be able to set it on any FormField without throwing)

@TomTirapani can this be closed or are there remaining issues?  Please go ahead and close out if we're all good, thanks.

This is resolved - closing


Remove babel

ATL now transpiles directly to ES5
Also Added a fix for the coverage task

@winkerVSbecks Missing from this is the removal of the angular loader which is using babel-loader. I'm not sure that it is even useful anymore TBH


An attempt to fix finalization lag by loading missing justifications

Signed-off-by: Igor Egorov<EMAIL_ADDRESS>

Referenced issues
#1260

Description of the Change

Benefits

Possible Drawbacks

Usage Examples or Tests

Alternate Designs

Changes are already in master


Tango not working on Pixel 2 XL

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
When testing the A-Frame AR.js + Tango example found here: https://rawgit.com/jeromeetienne/AR.js/master/aframe/examples/tango-demo.html
using Pixel 2 XL which is supposedly Tango supported but nothing happens, I get the camera display but tapping on the scene does not spawn any box on any surface. To be fair I have not found any information on if the pixel 2 XL supported Tango or not, but it did work with ARCore applications and there was no available information saying it did not support Tango.
If the current behavior is a bug, please provide the steps to reproduce.
Go to https://rawgit.com/jeromeetienne/AR.js/master/aframe/examples/tango-demo.html
Create a simple demo with the provided code in that link
Test it on a Tango enabled device.
What is the expected behavior?
Tapping on a surface should spawn a box in the scene, on the surface.
If this is a feature request, what is motivation or use case for changing the behavior?
This is not a feature request
Please mention other relevant information such as the browser version, Operating System and Device Name
I'm using the latest Chrome browser on Android, current chrome version is 68.0.3440.85 on Android 8.1.0 - Pixel 2 XL phone.

Extra information, I had trackingMethod set to 'best' - when I set it to 'tango' I get a page with an image and the text "Remix" on top left.

This PR has been closed due to inactivity. Please open a new, updated issue if the problem or the question is still relevant.


Translation issue

I've installed the module on my prestashop <IP_ADDRESS> italian site but I can see the sitemap only in english as in the attached photo. How can I solve?

Thank you for your report! This issue is fixed here: https://github.com/PrestaShop/gsitemap/pull/53


Anilist Redirect URI

Hey @gneiru can u  help me with the sample of the redirect uri that is used in this project.
cause i tried some redirect url but they are not working for me. i have mentioned the URIs i used.
https://xanirohi.vercel.app/api/auth/callback/AniListProvider
https://xanirohi.vercel.app/callback
these both dosent work for me
is there any other format for this project.

Hey @gneiru can u  help me with the sample of the redirect uri that is used in this project.
cause i tried some redirect url but they are not working for me. i have mentioned the URIs i used.
https://xanirohi.vercel.app/api/auth/callback/AniListProvider
https://xanirohi.vercel.app/callback
these both dosent work for me
is there any other format for this project.

Try https://xanirohi.vercel.app/api/auth/callback/anilist

i used that one and now it shows like this

logs_result (2).json
the logs of the error from vercel it says something about relation not found.

I think you havent setup your auth db tables

Try running pnpm db:push

Try running pnpm db:push locally

what about vercel case i dont have to running locally it directly deployed to vercel


Tuck the language toolbar into sub menus so smaller screens can access

On inkscape.org we have many languages active at the same time. The menu for language is very long and often can not fit on a screen 900px high. This patch tucks away each of the functions into it's own sub-menu with the break appearing if any of the menus will be there.

@doctormo nice! Could you rebase on latest develop to let a few test fixes in?

I've merged but not sure about githubs process, do I make a new merge request?

@doctormo nope, this is fine. Due to the changed menu layout, a test fails, though. Could you check here https://travis-ci.org/divio/django-cms/jobs/106064604#L3651 ?

(this will fix https://github.com/divio/django-cms/issues/3742 )

Updated with a fixed test and a new test. It wasn't clear how to write a test for the copy plugin menu.

@doctormo what's unclear about the test for copy plugins menu?
You can:

create english and german titles
add a text plugin to the english page
generate a request in germa
assert the correct menu items exist

(also, check the leftover import to make code check happy)

@yakky the tests are very very wet. That is to say, they aren't DRY. Developing assert base classes can reduce the line count in tests and increase maintainability of testing code by multiple factors saving developer time.
I'm going to let you fix the code. I'm not pleased with django-cms developers at the moment and I just don't have the patience for fiddling with code standards when the rest of the code isn't held to the same quality control.

Wet tests are much valued in django CMS test base, as give a much wider path coverage. But it's ok.
I can take care myself of getting this into shape

@mkoistinen @FinalAngel @vxsx @czpython what do you think of this PR? TL;DR: Changing "add translation", "delete translation", "copy plugins" into submenus with a list of languages.
Looks nice to me

I'm all :+1: on it

Thanks @yakky +1

Thanks @doctormo for the suggestion


CNV-15501: Update create VM from volume pages

📝 Description
This PR is related to the feature: https://issues.redhat.com/browse/CNV-15501
Update the pages according to the design changes, fix various issues, such as:

use 'Advanced settings' instead of 'Advanced'
change title of the dialog window containing list of bootable volumes from 'Bootable volumes' to 'Volumes to boot from'
change title of the button to create a VM from 'Quick create VirtualMachine' to 'Create VirtualMachine', as there's not gonna be any customization, so 'quick' creation doesn't make sense
change 'Gi' units to more readable 'GiB'
display the bootable volumes names as black texts in the list (and in the dialog displaying list of all the volumes), as there's not gonna be any redirection to the details page, when creating a VM from a volume

🎥 Demo
Before:
'Advanced' what?

Older 'Bootable volumes' dialog window (with the blue text color for the volumes' names):

'Quick create VirtualMachine' (while there's not gonna be any VM customization, in these pages):

'Gi' + no any space between the value and the unit:

The blue text color for the names in the list (when clicking, it leads to nowhere):

After:
It's clear what this expandable section is about:

'Volumes to boot from' dialog window (with nice, black and clearly unclickable volumes' names):

Simply 'Create VirtualMachine':

'GiB' + a space between the value and the unit, for better readability:

The black text color for the names in the list, so the user does not expect to go to some details pages, when clicking:

@metalice @upalatucci @vojtechszocs please review

/retest

/lgtm

/retest


Some annotations in legacy GO are not appearing

e.g.
PomBase	SPCC825.04c	naa40		GO:0051604	GO_REF:0000051	NAS		P	histone N-acetyltransferase Naa40 (predicted)		protein	taxon:4896	20170727	PomBase
PomBase	SPCC16C4.12	naa20		GO:0051604	GO_REF:0000051	NAS		P	NatB N-acetyltransferase complex catalytic subunit Naa20 (predicted)	nat3	protein	taxon:4896	20170727	PomBase
I have not seen any errorrs about this. in the logs. I might have stuffed up the file formatting...

I also can't get the colouring to work in VSC

Sorry, I don't understand.  What is the error?

Sorry that should say that the annotations are not appearing.

hang on, I need to check something...

Ignore, it is a parent aleady. I thought it wasn't


Piping to NodeJS  Web inspector console format in Puppeteer

I'm using puppeteer to evaluate some scripts and capture its console output to NodeJS environment. The package I'm using to run in Puppeteer uses the debug module.
The problem is the output in Nodejs comes in the web inspector format (%c) and hence not colorized. Is there a way to tell debug to output in NodeJS format when run in puppeteer (browser)?

It's tricky - there's an issue about it where I implement a hack to do this, but it relies upon Node internals and thus might not work as expected.
See https://github.com/visionmedia/debug/issues/483#issuecomment-324493212.
Going to close as a duplicate.


Added functionality for sending images bidirectionally

hey @RAMYA-CP , the code doesn't seem to work with images. I believe this approach would work for sending files rather than images.
Here are some screenshots for your reference:
It gives a success message , but the sender gets disconnected form the server.

This is the image sent:

This is the image received:

Hey Sakshi, I am not sure why is happening it works in windows for both jpg and png files though
CLIENT

SERVER

Hey Sakshi, I am not sure why this is happening it works in windows for both jpg and png files though
CLIENT

SERVER

I see, is the entire image received ?

Hey I have changed the file chunk size to 512 hope this works, please do let me know!

Hey I have changed the file chunk size to 512 hope this works, please do let me know!

Yup it works now!


1.21.4 Support

I'm making a new server and this is pretty much my ideal compromise of travel in the world. Hoping it updates so I can add it.

sure, gimme 20 mins

done, lemme know if you find any issue

oh wow i didnt expect a response this quickly. I got it loaded up on a server and all the posts have built just fine but I'm getting problems trying to name and teleport to them.
I was able to name a single post, but trying to name any more just seems to do nothing at all. Trying to teleport to the one I named outputs "An unexpected error occurred trying to execute that command" in red to the chat with "Cannot invoke "java.util.Set.contains(Object)" because "$$2" is null" showing up on hover. After I named the first post but couldnt name any more I restarted the server to see if it would help at all but I still couldnt name any more.

in this screenshot I tried /namepost, then /nearestpost, /namepost, /visit, /postlist, and then clicking on the listed post to teleport to it.
Nothing seems to be showing up in the server logs about anything telepost as I run these commands.

give me a few days to test it nicely


[Bug] Cannot GET /index.worker.6101d90edc184c0c8a67.worker.js

Describe the Bug
Browser prompts for errors to occur
GET http://localhost:3000/index.worker.6101d90edc184c0c8a67.worker.js 404 (Not Found)   localhost/:28
Steps to Reproduce
1.Download v1.41.0 source code
2.yarn install
3. yarn run example tutorial
The current behavior

The expected behavior
No errors generated
OS
windows 10
Node version
18.12.1
Browser
Version 114.0.5735.199 (Official Build) (64-bit)

can't reproduce it

I have the same problem   I Use it in vue3

Please search the issues for vue related problems and their solutions


Data collection

@elysabethc5 - two questions on the data collection.

Are we able to have a log in to the survey monkey to view the data and see how everything is being collected, or is this access restricted by RSPH?

How are they given a Unique ID number? Also, with the current form it says they can enter NA if they don't know. However, if they do this I can't see how you can link them to any previous surveys they have filled in. Do you have any idea on this? Are you currently able to collect all the survey responses that each participant has filled in?

i am more than happy for us to use a different platform , anything which makes the data better and more effective is good with me.
if we could it would be great to give the particpants ID . RSPH says that they havent found a way for the particpnats to remember the ID , so wondered if a way to link with email or region. without the ID we cant relate the pre questionnaire results with the post questionanire results for individuals . does that make sense

sorry im still getting the hang of this. and without some identification we cant know what sessions particpnats have done . remember there might be a time laspse between the particpant doing session 1 /2 /3 and we would need to track theat as well as linking up with the pre sessions questionnaire that would only be done once at the beginning of the process.
this is why the system at the moment is not fit for purpose and is why many of the trainers arent using it .

Thanks so much, this is really interesting. I've noticed they don't ask the participant to enter their email address in the survey. Is there a reason we don't do this? We could get them to enter their email address (making it clear that this wouldn't be shared with the trainers and would be privately stored as you currently do when requesting the ID), which they are likely to remember and then we can use this to track the participants, which can then be done automatically without ever sharing their email address with the trainers.

Thanks @elysabethc5 . Yeah I feel like the only way of being able to identify the participant is by getting them to enter some form of identification like an email. We could maybe separate out the process, so they first enter their email to confirm they were a participant of that session, and then it takes them to a second screen that will be the response form. This does the same job as currently but maybe will keep identification and feedback separate in the minds of the participants?

im happy to to go with that , for the people trained we can make it clear that the email is the way to identify them but seperated from the feedback ie their feedback becomes anonymous
of course for the trianers we need to be able to trace the feedback back to them to monitor their performance


misnamed-import warning for import A from '.'

Bug Report

TSLint version: 5.4.2
TypeScript version: 2.3.4
Running TSLint via: (pick one) CLI and VSCode

TypeScript code being linted
// the file is in: Logger folder, and '.' refers to index.ts file
import Logger, {
  LogItem,
} from '.';

error: Logger/logger.utils.ts
severity: 'Error'
message: 'Misnamed import. Import should be named '.' but found 'Logger' (import-name)'
at: '2,1'
source: 'tslint'
I think I've just stumbled on some edge case...
how about using directory name for import-name checking for this?

That's the import-name rule of https://github.com/microsoft/tslint-microsoft-contrib.
You should probably open the issue there

@ajafff oh sorry closing!


model_copy extra="forbid" not applied correctly

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
from pydantic import BaseModel

class Person(BaseModel):
    name: str
    age: int
    model_config = dict(frozen=True, extra="forbid")

# expected to fail but doesn't
p1 = Person(name="John", age=20)
p2 = p1.model_copy(update={"DoesNotExist": "should_fail"})

# fails as expected
p3_settings = dict(p1)
p3_settings.update({"DoesNotExist": "should_fail"})
p3 = Person(**p3_settings)

Example Code
No response
Python, Pydantic & OS Version
pydantic version: 2.3.0
pydantic-core version: 2.6.3
pydantic-core build: profile=release pgo=true
install path: /home/j/mambaforge/lib/python3.11/site-packages/pydantic
python version: 3.11.4 | packaged by conda-forge | (main, Jun 10 2023, 18:08:17) [GCC 12.2.0]
                     platform: Linux-6.1.51-1-MANJARO-x86_64-with-glibc2.38
     optional deps. installed: ['typing-extensions']

Hi @joamatab,
Thanks for your question! Our documentation on the model_copy() function has a note about this kind of behavior regarding the update parameter:

Values to change/add in the new model. Note: the data is not validated before creating the new model. You should trust this data.

So, I think based on our current documentation, the behavior you've displayed is correct. Let me know what you think!

I see, i was expecting that the data would be validated,
how about adding a flag for validating the data?

Hi @joamatab I hope you are doing well.
I think given the model_copy with update is intended to be "trusted data", and doing validation on it would add some overhead that could otherwise be dropped, it probably doesn't make sense for us to change the behavior of this function. (I am open to being convinced otherwise.)
However, you can implement a very similar function with just a bit of additional overhead that I think achieves what you want:
from typing import Any
from typing_extensions import Self

from pydantic import BaseModel

class MyModel(BaseModel):
    def model_copy_untrusted_update(self, *, update: dict[str, Any] | None = None, deep: bool = False) -> Self:
        copied = self.__deepcopy__() if deep else self.__copy__()
        extra_behavior = self.model_config.get('extra', 'ignore')
        if update:
            for k, v in update.items():
                if k in self.model_fields:
                    copied.__dict__[k] = v
                elif extra_behavior == 'allow':
                    if copied.__pydantic_extra__ is None:
                        copied.__pydantic_extra__ = {}
                    copied.__pydantic_extra__[k] = v
                elif extra_behavior == 'forbid':
                    raise ValueError(f'Extra field not permitted: {k}')
            copied.__dict__.update(update)
            copied.__pydantic_fields_set__.update(update.keys())
        return copied

(It would probably work to just override model_copy with this, I just gave it a new name for clarity.)
Note that this also has the improved behavior that if you pass unrecognized attributes in an update to a model with extra='ignore', it will behave correctly (whereas if you do that with the existing model_copy function, you'll probably get misbehavior when doing model_dump or anything else that accesses the __dict__; again, the update should be a "trusted" value, though we could probably better-document this requirement, especially that it only contain field values when using models with extra='ignore').
Let us know if this suggestion doesn't work for your use case or you prefer a different solution.

Note also that this suggestion will not actually perform validation of the values provided as part of the update. If you want that, I think the best route would be to either use your approach of dumping and revalidating, or using the validate_assignment config setting. It's mostly hard to do that because pydantic-core validates the model as a whole, rather than individual fields.
That said, we've had other requests recently related to validating individual fields of a model, so it's possible we could come up with an improved API for this that handles multiple use cases.

Thank you David
i ended up using a simpler version
def copy(self, **kwargs):
        for kwarg in kwargs:
            if kwarg not in dict(self):
                raise ValueError(f"{kwarg!r} not in Model")
        return self.model_copy(update=kwargs)


Bishop Heber College India mail domain Added

@allwinsr I am sorry, the request does not contain a new file representing a school email domain, I have to close it. Please ensure that you are familiar with the repository rules located at the bottom of the repository homepage and submit a new correct request.


Throw a UserError when MissingTokenException is detected

This error should not contribute to our internal failure count.
Merge / deployment checklist

[x] Confirm this change is backwards compatible with existing workflows.
[x] Confirm the readme has been updated if necessary.
[ ] Confirm the changelog has been updated if necessary.

Not sure if we need a changelog for this.

@edoardopirovano I am closing this PR since these errors were not actually from users. I don't think we're going to need this at all. I just wanted to make sure you are of the same opinion.

@edoardopirovano I am closing this PR since these errors were not actually from users. I don't think we're going to need this at all. I just wanted to make sure you are of the same opinion.

Yes, agreed we can close this.


Download invoice blob:

Welcome.
I have a problem downloading a PDF on a mobile device.
My code:
easyinvoice.createInvoice(data, function (result) {
  easyinvoice.download("invoice.pdf", result.pdf);
});

It generates the PDF correctly, but it is not possible to download it on the iPhone device (Safari and Firefox) because I get the format "blob:".
How can I correct this?

Hello, what you are receiving is a base64 encoded string. You should decode this string and then you can use it however you like.


example no longer working

I only checked this for quadrilateral as it's the only one I use, but probably needs adjustment in other examples as well:
val = quadpy.quadrilateral.integrate(
    lambda x: numpy.exp(x[0]),
    quadpy.quadrilateral.rectangle_points([0.0, 1.0], [-0.3, 0.6]),
    quadpy.quadrilateral.Stroud(6)
    )

in the readme does no longer work as the indices refer to the indices in Stoud's publication (such as 'C2 7-3'). Furthermore an explanation of index ordering would be nice, as this changed from the old versions of this package.
Like in: "Rectangle points are now given in [x0,x1][y0,y1] order" (If I assume correctly)
In old versions it was [[x0,y0][x1,y1][x2,y2][x3,y3]]; this might be confusing. At least for me it was.

Thanks for the report! I'll check it out later.
The point specification has changed indeed; it's now an array of shape (2, 2, whatever), where arr[0][0] is the "lower left" corner, arr[1][1] the "upper right". Same with hexahedra, or n-cubes by the way. (Adding n-cubes had me realize that no order of corner points is as natural as this.)
Anyhow,
quadpy.quadrilateral.rectangle_points

is for anyone who really only wants to integrate over a cube with sides aligned to the axes. It lets you specify the "limits" and gives you the (2, 2, whatever) array.
This went undocumented as I didn't know anyone what actually using it.

Alright, I coughed up a little more documentation for this:
https://github.com/nschloe/quadpy/tree/stroud-ball#quadrilateral
Will be part of the next release.
If you feel this isn't sufficient, feel free to reopen this issue.

Thank you for your work on this, on the package as a whole and your fast response! Indeed people are using your work.