feat: move ring buffer to use array instead of vec

In this commit the vec backing the buffer is swapped for an array. Criterion benchmarks were added to compare the perf to make sure it has not made it worse. The vec implementation has been removed after the benchmarks done locally

what was the delta in performance?

Just looking at the mean, it was 40ms difference. This is artificial load (we may not read from the sys tables that frequently), but mainly indicates there's some gains. Think it'd be more interesting to see allocations, but I haven't managed to get through it yet (need a wrapper around jemallocator or some crate that does it).
syseventstore_writes_reads_t6/array/0
time:   [3.4803 ms 54.879 ms 144.46 ms]
syseventstore_writes_reads_t6/vec/0
time:   [40.278 ms 94.199 ms 160.97 ms]


Imports reference broken

Hi,
I updated from (i think) .5 to .7 and imports > reference stopped working
        less: {
            prod: {
                options: {
                    paths: styleLocation,
                    imports: {
                        reference: ["mixins.less", "variables.less", "images.less"]
                    },
                    syncImport: true
                },
                files: [{
                    expand: true,
                    cwd: styleLocation,
                    src: ["**/*.less", "!container.less", "!variables.less", "!mixins.less", "!**/external/*.less"],
                    dest: styleLocation + "/temp",
                    ext: ".css"
                }]
            }
        },

I have changed imports > less to imports > reference. But it wont compile because it can't find mixins in mixins.less.
Any ideas? Any way I can get more information on what is happening?

I ran into this issue today and I'm a bit surprised that it has been fixed already for almost a year in the 0.8 branch but is still broken in the version that npm installs. Would be nice to get it working from there too.


test1111

I tried this code:
sdd3333

I expected to see this happen: explanation
Instead, this happened: explanation
Meta

rustc --version --verbose:
<version>

Backtrace

<backtrace>

@rustbot label +bug

Error: Label bug can only be set by Rust team members;we were unable to check if you are a team member.
Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@rustbot label +bug

Error: Label bug can only be set by Rust team members
Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@rustbot label +bug

@rustbot


no error help for this error

CS7036 is being thrown by the compiler and you have no help for this-Why error if no help available?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bbb051ee-f020-66ba-c601-4a08ad32ef61
Version Independent ID: 58a19505-ac46-c5c8-12cc-fe87b6aa18a7
Content: Sorry, we don't have specifics on this C# error
Content Source: docs/csharp/misc/sorry-we-don-t-have-specifics-on-this-csharp-error.md
Product: dotnet-csharp
Technology: csharp-diagnostics
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

duplicate of #27438


Small readme updates

There were a couple code examples that had incorrect syntax. Also updated the line length in the readme to break out our ruler setting in emacs.

Hey @HeroicEric! Thanks for the PR. I merged your changes in with mine because it seems we had the same exact idea today :)


virt-manager: add tests

Currently full tests errors as:
Error: --disk /var,device=floppy,snapshot=no,perms=rw: Size must be specified for non existent volume 'var'

Logs: https://termbin.com/qlbjf
Creating /var using mkdir errors:
> mkdir: cannot create directory ‘/var’: Permission denied

On Matrix:
superherointj: How can I have /var folder when building a package?
symphorien: you can't by design
IIUC: you can't. What is your use case. If you build without sandboxing you will see the host /var.
symphorien: usually the builder passes --prefix=$out to ./configure so that the build system writes to $out/var instead
symphorien: you may use libredirect to fake that /var exists

As I failed to use libredirect, I'm proposing partial tests until a (better) solution is found.
Partial Tests
After ignoring [ "tests/test_cli.py" "tests/test_disk.py" ] new errors appeared:
PermissionError: [Errno 13] Permission denied: '/homeless-shelter'

Logs: https://termbin.com/esgv
After ignoring [  "tests/test_urldetect.py" "tests/test_checkprops.py" ] it passes.

You could try setting HOME=. for the /homeless-shelter test failures.


Bug/regexfailure

This PR adds some client side validation of Regex qualifying queries, gives some user notification when those occur, and handles any failed server side error catch(if there still are any) in a more graceful way.  The current version misses a few corner cases that would require a full page reload to recover from.

@Tom2277 sorry for the delay. let  me merge others too and then test them all together!


DTO docs

The program makes use of DTO objects for parsed programs, predicates and WP context objects, but generally lacks documentation on those.

Closed by PR #16


Spotted this didn't work on contact form so we had to make further mo…

Spotted this didn't work on contact form so we had to make further mods to check the routes slightly differently.
Feel free to merge it if you think its right, works for our purposes.

Hey,
Thanks for the contribution, one thing to note here, a contact form can be, and often is, placed on other pages, usually CMS pages. By locking the display logic down like you've done, people who like to add their contact form to the sidebar or into the content area of their site would be unable to do so.
It looks like I'll need to revert it back to how it was before, where you can override the isAllowed method like so:
    <reference name="content">
      <block type="core/template" name="contactForm" template="contacts/form.phtml">
        <action method="setFormAction"><value>/contacts/index/post</value></action>
        <block type="studioforty9_recaptcha/explicit" name="studioforty9.recaptcha.explicit" template="studioforty9/recaptcha/explicit.phtml">
          <action method="setAllow"><value>true</value></action>
        </block>
      </block>
    </reference>

I'll add the code later today and push but since your PR failed the unit tests, I'll probably close this and re-implement locally.
Thanks,
Eoghan


[AIRFLOW-3276] Cloud SQL: database insert / patch / delete

Add CloudSqlInstanceDatabaseInsertOperator, CloudSqlInstanceDatabasePatchOperator and CloudSqlInstanceDatabaseDeleteOperator.
Each operator includes:

core logic
input params validation
unit tests
presence in the example DAG
docstrings
How-to and Integration documentation

@TrevorEdwards I've addressed all of your comments. As usual, a very good CR, thanks ;)
In most cases I've altered the code according to your suggestions, however in a few cases I just left a comment here.
Would be great if you could take a look when you have a moment :)

I'm closing this PR and will open a new one to the apache/incubator-airflow repo.


1 min delay in showing steps in UI (exposed via Ingress)

Checklist:

[ ] I've included the version.
[ ] I've included reproduction steps.
[ ] I've included the workflow YAML.
[ ] I've included the logs.

What happened:
Ran a sample workflow (whalesay) through the UI, which has been exposed through an ingress. Initially, the UI shows this:

Then, almost exactly 1 minute later (on the 5 runs I have timed, it has always been at 59.x seconds), the step details show up:

If the UI is accessed through via port-forwarding (i.e. kubectl -n argo port-forward deployment/argo-server 2746:2746), then there is no delay in the step details showing in the UI.
What you expected to happen:
The UI to behave consistently, whether exposed via ingress or port-forwarding.
How to reproduce it (as minimally and precisely as possible):

Create a 1.15.12 Kubernetes cluster
Create argo namespace
Install argo into argo namespace and patch rolebindings:

NAMESPACE=argo
kubectl apply -n $NAMESPACE -f https://raw.githubusercontent.com/argoproj/argo/stable/manifests/namespace-install.yaml
kubectl patch configmap -n $NAMESPACE workflow-controller-configmap -p '{"data": {"containerRuntimeExecutor": "pns"}}'
kubectl patch rolebindings -n $NAMESPACE argo-binding -p '{"subjects": [{"name": "default", "kind": "ServiceAccount", "namespace": "'$NAMESPACE'"}, {"name": "argo", "kind": "ServiceAccount", "namespace": "'$NAMESPACE'"}]}'
kubectl patch rolebindings -n $NAMESPACE argo-server-binding -p '{"subjects": [{"name": "default", "kind": "ServiceAccount", "namespace": "'$NAMESPACE'"}, {"name": "argo-server", "kind": "ServiceAccount", "namespace": "'$NAMESPACE'"}]}'

Create an ingress:

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: argo-ingress
  namespace: argo
spec:
  rules:
  - host: <HOST>
    http:
      paths:
      - backend:
          serviceName: argo-server
          servicePort: 2746
        path: /
  tls:
  - hosts:
    - <HOST>
    secretName: <SECRET>

Access <HOST>, click "Submit New Workflow" button, and click "Submit" to run whalesay job
Wait for steps to show.

Anything else we need to know?:
Environment:

Argo version:

argo: v2.8.1
  BuildDate: 2020-05-28T23:39:46Z
  GitCommit: 0fff4b21c21c5ff5adbb5ff62c68e67edd95d6b8
  GitTreeState: clean
  GitTag: v2.8.1
  GoVersion: go1.13.4
  Compiler: gc
  Platform: linux/amd64

Kubernetes version :

clientVersion:
  buildDate: "2020-05-06T05:17:59Z"
  compiler: gc
  gitCommit: e2a822d9f3c2fdb5c9bfbe64313cf9f657f0a725
  gitTreeState: clean
  gitVersion: v1.15.12
  goVersion: go1.12.17
  major: "1"
  minor: "15"
  platform: linux/amd64
serverVersion:
  buildDate: "2020-05-08T15:08:35Z"
  compiler: gc
  gitCommit: ab8a13f032bccd858fa0232d64fcdd05671f57e6
  gitTreeState: clean
  gitVersion: v1.15.12+IKS
  goVersion: go1.12.17
  major: "1"
  minor: "15"
  platform: linux/amd64

Message from the maintainers:
If you are impacted by this bug please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

This is a UI issue, so probably a network issue. We'd need to see the network tab to understand more.
However, I'm sure we've had people experience the issue in the past due to Nginx configuration. Maybe check that?

Thanks, will take a look at the config and reopen this if necessary.


High CPU utilization and infinite loop when forever monitor is used

Forever monitor and interval based commit log crawling is putting too much load on the CPU and often leads to an infinite loop

Replacement of forever-monitor with chokidar based FS watcher will resolve the issue


Please add specific links for activity settings and semantic labels

activity settings link need to be change to https://learn.microsoft.com/en-us/graph/connecting-external-content-manage-connections#activity-settings
semantic labels link need to be change to https://learn.microsoft.com/en-us/graph/connecting-external-content-manage-schema#semantic-labels

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8b37cfa9-4237-d223-a374-08ff581c5681
Version Independent ID: 8b37cfa9-4237-d223-a374-08ff581c5681
Content: How to Extend Microsoft 365 Copilot - Teams
Content Source: msteams-platform/copilot/how-to-extend-copilot.md
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: ginobuzz

@surbhigupta12 - Could you please help here to update the below two links in this document.

activity settings link need to be change to https://learn.microsoft.com/en-us/graph/connecting-external-content-manage-connections#activity-settings
semantic labels link need to be change to https://learn.microsoft.com/en-us/graph/connecting-external-content-manage-schema#semantic-labels


Update dependencies 20190822

failure unrelated ? needs server fix ?

failure unrelated ? needs server fix ?

yes - unrelated - working on the analysis already - sdk or server - cannot yet tell


chore: fix shipjs action

fix https://github.com/algolia/shipjs/issues/931

@jeetiss can you please rebase so I can merge this?


Vectorized python version

There seems to be increasing interest in a vectorized Python version that efficiently computes estimates based on rolling/expanding windows (https://github.com/eguidotti/bidask/pull/8 and https://github.com/eguidotti/bidask/issues/9).
A vectorized rolling implementation is available in R, which should provide a good starting point for a similar implementation in Python. See https://github.com/eguidotti/bidask/blob/main/r/R/edge.R
Any help is greatly appreciated!

I'll implement this in a PR today. Any special requests? I propose making the rolling vectorized python function a separate function from the current python function that is based on the pseudocode. Do you want a test, or anything else of note?

I'm almost done, the only issue is that in edge.py there is:
    if pt == 0 or po == 0 or pc == 0:
        return np.nan

Whereas the R code doesn't have any similar escape. I'm not sure yet of the best solution for the vectorized code to implement this sort of escape. It results in more NaNs for the rolling.apply-based method compared to the vectorized method when the rolling window size is <= 2. In those cases, the vectorized method gives spread estimates on the order of <1e-8. All other values are equal to numerical precision for any greater window size.
I will keep trying to match that escape condition in edge.py. Will share progress tonight.

The vectorized version is up and running! Release 2.1.0 on PyPI.
Thank you so much @joseortiz3; your work and feedback has been tremendously helpful! 🙏


Does nixos-anywhere require a single-use flake during installation?

I've been looking for a way to pre-plan the installation of NixOS on two of my servers with as little downtime as possible, and just discovered nixos-anywhere which looks promising.
One thing that confuses me though, the instructions talk about creating a flake for the target installation, which largely looks like a regular NixOS configuration, but includes disko partitioning info. Which makes me assume that this flake is only to be used once, to get NixOS installed, and then never again for fear of re-partitioning the drive over and over.
Is this correct? Do I need to create a minimal configuration flake to use with nixos-anywhere that is separate from the actual flake configuration I intend to use on the target server? Or is the intent to use a final configuration during installation, and the partition info is somehow only used once?

No, you can have everything in a single flake.
Disko configuration should be included for installation only, it won't be used afterwards - expect if you explicitly generate partitioning scripts from it.

No, you can have everything in a single flake.

Thanks, good to know!

Disko configuration should be included for installation only, it won't be used afterwards - expect if you explicitly generate partitioning scripts from it.

Can you explain what you mean by "included for installation only"? Does nixos-rebuild ignore it, and it's only used by the nixos-anywhere script? Or do you mean I need to edit that section out after installation?

Does nixos-rebuild ignore it, and it's only used by the nixos-anywhere script?

Yes, with --flake, nixos-anywhere uses  nixosConfigurations.your-hostname.config.system.build.diskoScript by default. You can also pass a custom script via "-s".
No need to edit it out


Provide JSDoc documentation for all common components

This is clearly a huge improvement, so given that it's all in comments and the downside risks on my concerns are low, I'm going to go ahead and merge all these changes in the interest of keeping you unblocked for further work in this direction.
For the reasons mentioned above, I'm pretty sure I'd like to cut out the brackets-for-optional convention and just let optional/not-optional be one of the things the reader learns by looking at the types. That can be a followup commit to sweep through and convert the existing comments. (If I were getting to this at an hour when you're still working, I might ask you to do that before I merge, but I'm not and it's not worth the added night of latency.)
I'm waffling on the question of whether to describe routine things like onPress or color when they have the obvious meaning. I'd be interested in more thoughts/reasoning on that. A sort of middle option might be to just mention such a prop so it shows up in the list:
 * @prop onPress

but not say anything except where there's something interesting to say. Whatever we end up with there, if it's different from these commits we can pretty easily do a sweep later.
I'll leave this PR open (rather than close it as "merged") because it seems like a helpful thread for at least a bit more discussion -- as well as for adding more great commits like these!

Collecting some style-guide advice for comparison, Google's says:

Method, parameter, and return descriptions (but not types) may be omitted if they are obvious from the rest of the method’s JSDoc or from its signature.

Flutter's says:

If someone could have written the same documentation without knowing anything about the class other than its name, then it’s useless.
Avoid checking in such documentation, because it is no better than no documentation but will prevent us from noticing that the identifier is not actually documented.

and then follows with a very nice list of prompts to think about to think of useful information to write down. (In general, one of the things that has most impressed me in poking a bit at Flutter is their extremely high-quality developer documentation.)
And a Mozilla style guide refers to a JavaDoc guide, which has this on the subject:

The best API names are "self-documenting", meaning they tell you basically what the API does. If the doc comment merely repeats the API name in sentence form, it is not providing more information.

I think a fair synthesis of what all of those say on this subject, and a rule I'm pretty happy with, is:

If you're documenting a component, include all its properties as @prop entries.
Don't force yourself to write a text description for every property; only write where you have something interesting to say.
Repeating what the name says, or something you could have written without knowing anything other than the name of the component and of the prop, is boring; better to just leave that one blank.

How's that sound?

You are right, maybe we don't want to describe all props after all. I think it is OK to provide a one-liner for the obvious ones. I felt a bit weird describing onPress events, though quite often there are details about obvious events that might be useful. I think leaving it with no description sometimes is clearly the sane option.
It seems the JSDoc preview is not configurable, but maybe they will accept a PRs if we come up with better formatting. I think the relevant file is this one:
https://github.com/Microsoft/vscode/blob/master/extensions/typescript-language-features/src/utils/previewer.ts
About the optional params - even with the apparent mismatch, they are actually more correct than Flow will let you believe. Props refers more towards what the component expects to receive than to what is given to the component as <Component someProp={valueHere} />. The discrepancy comes from the defaultProps we are giving to the component. Since we are providing defaults for most Avatar props they are truly optional. They are not typed as someProp?: type because they are guaranteed to have some default value, so they are not optional in that sense to the internal component code.
I think I agree 100% with the last comment it belongs do the documentation 👍

(I did in fact merge these back several weeks ago when I made the previous comments, as c6b2aa482 and ancestors. Not sure why I left this "open" instead of "merged"; maybe I thought you'd send further changes here? Anyway, new PRs seem like a better way to do that, so let's close this one.)

About the optional params [...] The discrepancy comes from the defaultProps we are giving to the component. Since we are providing defaults for most Avatar props they are truly optional. They are not typed as someProp?: type because they are guaranteed to have some default value, so they are not optional in that sense to the internal component code.

Oh hmm, I see.
Well, I'm still concerned about having a lot of boring information that we maintain ourselves without automated checking -- that's generally a recipe for stuff becoming wrong. But glad to see why this isn't yet an example. :-)


Messages should contain identifier

What problem does your feature solve?
This came out of a discussion with @leighmcculloch. We want to make message generation extremely uniform, so every argument to a contract function should appear in the message. Currently, we are entirely excluding the Signature type (which includes more than just a signature) from the message.
What would you like to see?
It's not possible to include the signature itself (because you can't produce the signature without the message), so we should convert the Signature to an Identifier and include that Identifier in the message.
What alternatives are there?
It would also be reasonable to include a () in the message.

Merged in #84.


Feature Request: Change to SAL profile pic

A follow-up on #7. (Yes, I can be stubborn sometimes.)

Ping @eteq


improve onedrive concurrency

The key fix is the concurrency.  Instead of base on the Processor Count, it is set to 6 concurrent downloading threads (same approach as dropbox but slight different value).
The remaining fix is making the status more diagnosable.

:shipit:


Closing window with unsaved changes results in no other window being created for new buffers

Related to #610
Version: <IP_ADDRESS>
Date: 8/31/2019, 5:18:41 AM
Commit: 237e14b

Start onivim2
Observe there's a new untitled buffer open
Enter insert mode
Type "test"
Observe window close button change to a modified buffer indicator
Press the modified buffer indicator
Window closes and you're presented with an empty pane
Try opening any other buffer using file explorer or command
Observe new buffers being opened as indicated by the status line, but no actual window appears until restart. It feels like you can modify those buffers without any visual feedback.

Nice catch @avimmer ! Definitely a bug - we end up in a broken state where buffers aren't being opened.

This can still happen with the Welcome pane too. Steps now:

Start onivim2
Use :e some_new_file.txt to get a new file.
Close the Welcome tab.
Make some changes in the new file.
Click the modified circle to close the new file.
Bad state now entered.

I believe an empty window should be a valid state in general, because we probably need a checkbox on the welcome screen to be able to turn it off, like in VSCode. In fact, now that I test VSCode, their empty window has something sort of like the current onivim2 welcome tab:

So obviously we need a bit more work there, but it is probably not too hard. I may investigate some of this.


Create custom hooks to retrieve documents using react-query

Is your feature request related to a problem? Please describe.
We need to cache documents retrieved from the incidents and vet_concerns collections.
Describe the solution you'd like
Create 2 custom hooks called useIncident and useVetConcern.
The hooks should contain a query function that retrieves the documents from the collection and a mutation function that updates the documents.

Hey @NicholasChoong, it seems like this issue might be linked to another pull request? Can it be closed?

Issue completed through other merged pull requests


DROOLS-1073 Option to bypass start task operation in REST/JMS

(cherry picked from commit 0c42014cf9b159fad2f9543749fc91044655977c)

jenkins retest this

build failure not related to the change but just in case, let's rerun the test

oh no, it failed again ... I tested it locally and it works fine there

+1 the failed test is a false alarm

merged into 6.4.x thanks @ibek


Add file-based support to Galley MCP server

cc @ayj

not stale.

Could I run Galley without k8s dependency (i.e. on a VM and with no kube-api configured) serving Istio config from file system once this issue is resolved?

Yes for Galley, specifically. But bear in mind that the primary driving scenario is testing at this point. As such, the current format is going to be based on Kubernetes resource format.
As for downstream components, they may still retain some API Server dependency.

Pilot can already run with files only (and has for a while - see ads tests)
Costin
On Tue, Sep 18, 2018, 12:44 Ozben Evren<EMAIL_ADDRESS>wrote:

Yes for Galley, specifically. But bear in mind that the primary driving
scenario is testing at this point. As such, the current format is going to
be based on Kubernetes resource format.
As for downstream components, they may still retain some API Server
dependency.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/6479#issuecomment-422524595, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6jL44ZOuUDm-hrUjZiUeKHWsUW5Oks5ucU0CgaJpZM4Uyex-
.

Implemented: https://github.com/istio/istio/pull/8831


Kubernetes version wrong on Windows nodes

Windows binary versions report the wrong version. These agents are v1.6.6
$ k get nodes
NAME                    STATUS    AGE       VERSION
40278acs9000            Ready     3h        v1.6.4-beta.0.147+2b3fc68910b4dd
40278acs9001            Ready     3h        v1.6.4-beta.0.147+2b3fc68910b4dd
k8s-master-40278883-0   Ready     3h        v1.6.6

@seanknox how do we know know the agents really are built from 1.6.6 code?

That's the good word from @JackQuincy and @JiangtianLi

@seanknox New zip uploaded. We can close this issue now.

Awesome, thanks. We should add a test to confirm that API versions match on nodes and master, something needed for both Linux and Windows. Can you roll out a Windows cluster and post a screenshot showing versions and we'll close this one?

screenshot attached (sorry for the delay since there was some issue in CDN to propagate till now).

Great, thanks @JiangtianLi!


Istio never loads a traffic graph

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
Enable Istio at the cluster and workspace level,
Result:
When you click on Istio it just hands on a loading icon and never displays anything.

Based on our slack conversation I think something else is going on. This is working for me. I'm not entirely sure what is happening but should not get any HTTP 503 errors when access the endpoints.
Version: v2.3.0-alpha5 single-node rancher on DigitalOcean host will open firewall
I tested but didn't identify any issues.
When enable Istio all workloads are up and good:

(I enabled with default settings)
Before doing anything, visit Istio page should see "Not enough data for graph"

All the UI links are accessible

Created auto-injection namespace

Imported the following YAML into this namespace:
https://raw.githubusercontent.com/rancher/rancher/80bdad0ebb8bcd3d2fd9d55dc45c1851443bcf30/tests/validation/tests/v3_api/resource/istio_files/bookinfo.yaml
https://raw.githubusercontent.com/rancher/rancher/80bdad0ebb8bcd3d2fd9d55dc45c1851443bcf30/tests/validation/tests/v3_api/resource/istio_files/bookinfo-gateway.yaml
Appears to be working and functional:

@supermiguel If you are still facing issues with v2.3.0-rc5, please let us know.

Please let us know in a comment if you can still reproduce the issue, and we'll reopen it

I can reproduce this with Kubernetes Version: v1.15.4 and 0.1.1 with Istio 1.3.3


Missing OUI data

Is it possible to update the OUI DB ?
For example this OUI is not found in the filter database, 2c:0e:3d. But looking at a few online lookup sites I can find this information on it.

Samsung on https://aruljohn.com/mac/2C0E3D
Nothing on https://www.macvendorlookup.com/
Samsung on http://standards-oui.ieee.org/oui.txt (this is an awesome source of oui information btw)
Samsung on https://www.wireshark.org/tools/oui-lookup.html

https://regauth.standards.ieee.org/standards-ra-web/pub/view.html#registries this is also a nice source


refactor: 7711 removal of SNS package

📲 What
Removing code smells/warnings and minor tidyup
Remove separate AWS SNS package
✅ Acceptance criteria Checklist

[ ] Code peer reviewed?
[ ] Documentation has been updated to reflect the changes?
[ ] Passing all automated tests, including a successful deployment?
[ ] Passing any exploratory testing?
[ ] Rebased/merged with latest changes from development and re-tested?
[ ] Meeting the Coding Standards?

Does the template need updating to include or exclude the test files based on the input?

/azp run


Move copyto to chainer.backend

Convention on naming modules is discussed by @niboshi and @beam2d.

Jenkins CI test (for commit 1f52be806f97c52bef50014febeff98c1f1ff0b6, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins failure is irrelevant.

LGTM


Consider usage of collapsible in html run docs

Using the collapsible can make the docs easier to handle. It can be especially useful for env variables.

This can help especially with environmental variables as often there maybe hundreds of “not important” ones

Totally agree that it would help to have this :)


python312Packages.velbus-aio: 2024.4.1 -> 2024.5.1

Changelog: https://github.com/Cereal2nd/velbus-aio/releases/tag/2024.5.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 314527 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.velbus
python311Packages.velbus-aio
python311Packages.velbus-aio.dist
python312Packages.velbus-aio
python312Packages.velbus-aio.dist


chore: README badges

Closes: #1423
RENDERED

@ValarDragon or @daniel-farina, is there an SVG or PNG that I can use in the header to display the logo?

@alexanderbez Is this what you're looking for?


Prototype URL isn't loading for most folks

The prototype URL is throwing a blank screen for most folks. Console shows a redux error:
"Uncaught TypeError: t is undefined" redux

Traced this to an issue with devtools - as long as you have react & redux devtools extensions, everything looks fine, so you wouldn't notice stuff is broken. Found this issue on the redux devtools extension: https://github.com/zalmoxisus/redux-devtools-extension/issues/320
Applied the fix in https://github.com/zalmoxisus/redux-devtools-extension/issues/320#issuecomment-447914219 and tested it locally - looks good. Deployed to cloud.gov and seems that this fixed things, asking for someone else to verify.

Heather confirmed it's working for her now - except, looks like I broke devtools. Onward.

https://github.com/CDCgov/prime-data-input-client/pull/3 waiting on PR approval to close


Upgrading to Couchrest 2.0.1 and simplifying connection multithreading

Upgrading to the latest Couchrest gem which has simplified connection handling. The aim with this PR is to limit expose to possible multi-threading issues when instantiating and setting database objects, and also make better usage of persistent connection handling provided by the underlying HTTPClient gem.

@amuino in theory two threads could hit that section of code at the same time when the connection details have not been cached. So yes, using update is not a good idea. I'll change it to merge so that in this scenario, nothing is getting replaced.


Upgrade netty to 4.1.5 with exclusion for google-cloud

The version of netty pulled in by pubsub has a memory leak.

https://ghe.spotify.net/build/tc-to-audit/pull/14
https://groups.google.com/forum/#!topic/grpc-io/4wHa_fxaT-Q
https://github.com/GoogleCloudPlatform/google-cloud-java/issues/1433

Current coverage is 51.39% (diff: 100%)

Merging #1049 into master will increase coverage by <.01%

@@             master      #1049   diff @@
==========================================
  Files           275        275
  Lines         13081      13081
  Methods           0          0
  Messages          0          0
  Branches       1694       1694
==========================================
+ Hits           6722       6723     +1
  Misses         5856       5856
+ Partials        503        502     -1

Powered by Codecov. Last update 7cf7c05...b16272d


add release procedures to developer documentation

This adds a document outlining the release procedures for PyWavelets.  This would have been useful to me as a first time release manager, so I made some notes that could hopefully help others in the future.

Very nice. I only had a few minor comments.

okay.
I had also forgotten to mention creating the release on GitHub, so I added that too.

Yep, just a glitch. This looks good now, merging. Thanks @grlee77!

Yep, just a glitch. This looks good now, merging. Thanks @grlee77!

This is great. Thanks @grlee77.


Custom Links Don't Work

If you enter any character into the Custom URL input, the "Shorten Me" button will not work until you clear the Custom URL input.

#22 Fixes this


Align about page to charter

Aligning the about page to our https://github.com/maplibre/maplibre/blob/main/CHARTER.md

Thanks @birkskyum!


Align p kNN parameter behavior with sklearn

p kNN parameter should be assigned to default value of 2 even if metric value is set to one which doesn't mean p=2 (for example, l1 or manhattan).
Required to produce same output from 'get_params' method as stock sklearn.

/intelci: run

/intelci: run


does not cover stubbing redux connect methods

In my architecture,  containers connect components to redux store and connect props.
i expose those connect functions as components which i would like to stub, however when using your method i get errors stating the store isn't recognized etc.
something like this:
import {connect} from 'react-redux';
import NinjaTurtle from 'ninja_turtle';
import {mayBeStubbed} from 'react-stubber';
function mapStateToProps(state) {
  return {

  };
}

function mapDispatchToProps(dispatch) {
  return {

    };
}
function mergeProps(stateProps, dispatchProps, ownProps){
   return {
   };
}
export default mayBeStubbed (connect(
  mapStateToProps,
  mapDispatchToProps,
 mergeProps
)(NinjaTurtle));

found solution:
to mock the redux store, enabling my previous example add a decorator before story as such
 import Provider from 'storybook_provider'; ... .addDecorator(story => <Provider story={story()}/>)


Standard Load balancer TCP Reset enabled along with service fabric cluster nodes

I have two services (as Web API) running in 5 Node Service fabric cluster, say ServA and ServB.
The ServA Calls the ServB API. Since both are in same Service fabric Cluster we are using DNS name service and by using Internal Load Balancer.
In ServB API, we have endpoints where it will take more than 30 minutes of Time but less than 60 minutes. Since these services are behind load balancer and there is Idle time out of 30 minutes on Load Balancer. We shifted to use Standard Type load balancer, which will give the option to TCP Reset on 30 minutes of Idle time out. Increased idle timeout to 30 Minutes and Enabled TCP Reset in load balancing rule along with Session persistence "ClientIP" feature.
From the Application Insights that we have configured, I can confirm that the ServB/ServBUrl responding after 30 minutes, but I am unable hold/catch the response in the ServA.
hence added the Code in following way in ServA;
Reference: Standard Load Balancer [ https://docs.microsoft.com/en-us/azure/load-balancer/load-balancer-tcp-reset ]
// The Servicepoint code has been added after changing to Standard load balancer
// Refernce: https://docs.microsoft.com/en-us/azure/load-balancer/load-balancer-tcp-idle-timeout#tcp-idle-timeout
// https://docs.microsoft.com/en-us/dotnet/api/system.net.servicepoint.settcpkeepalive?redirectedfrom=MSDN&view=netcore-3.1#System_Net_ServicePoint_SetTcpKeepAlive_System_Boolean_System_Int32_System_Int32_

// servBUrl is a DNS named url, ex: https://servdnsname.domain.net/servicealias/api/<RequestRoute>
var servicePoint = ServicePointManager.FindServicePoint(new Uri(servBUrl));

servicePoint.ConnectionLeaseTimeout = 60 * 60 * 1000;
servicePoint.MaxIdleTime = 60 * 60 * 1000;
servicePoint.SetTcpKeepAlive(true, 60 * 60 * 1000, 1000);

HttpRequestMessage request = new HttpRequestMessage(httpVerb, servBUrl);
HttpResponseMessage httpResponse = await HttpClientInstance.SendAsync(request);

Additional Info:

I am using the single HttpClient Object to make the Calls and assigning the HttpClient timeout with InfiniteTimeSpan

HttpClientInstance.Timeout = System.Threading.Timeout.InfiniteTimeSpan;

My LoadBalancer uses single load balancing rule with port 443, and my ServB also runs on 443 port.

I know running a REST API more than 30 minutes is weird, but it is unavoidable.

So, below are my questions/clarifications,

Is my ServicePoint code really handling the TCP Reset, when my Load Balancer sending TCP reset?

From the Network monitor tool identified that, the TCP reset signal is reached but still unable to complete my Http Call when servB responds. Why?

How can I make my ServA http call to wait till the ServB responds back, with this internal load balancer configuration.

Configuration Information:
Services Type: both are stateless,
.net core version: v2.2.0
System.Net.Http: v4.3.4

@dario-ms Can you please help triage this?

I don't know how httpClient internally works, but the error condition for missed keep alive packets is going to be detected on current active operations (like a read or a write). In the case of HttpClient that is not doing anything but trying to send at the end (after 30min in your case), if the socket is faulted, that write will fail. But... from the sample you copied here, you are setting the keep alive to be 60min, so you are not going to get a failure in less than 60min (the socket is going to wait 60min to start sending the first keepalive packet).  If what you want is to keep the LB connection alive, then you should set the keepalive interval to something that is less than that and then keep the interval small as well (so, say, start on 5min and keep sending every min), that provided that the HttpClient sets that option correctly (you can validate it easily setting the keepalive to very low values and validating via wireshark or tcpdump that the keepalive packets are sent).


Using FirebaseFirestoreSwift for easy Codable Support

How Do I use the FirebaseFirestoreSwift pod with this precompiled version?

A solution for this might depend on https://github.com/firebase/firebase-ios-sdk/issues/7819

With Firebase 9.0.0, FirebaseFirestoreSwift is now included in the zip distribution


Finetuned model

Hello, Thank you for the great work.
I am wondering if you have trained model to run inference on. I want to test model for property prediction on test dataset.
I tried training but its super slow to train on my local machine!

Thanks for your comment. We do have finetuned the model and tested it on test datasets. Usually, it takes several hours for small datasets or one or two days for large ones to finetune the model with 5-fold cross-validation if you have RTX 3090 or better GPUs.

Thank you for the quick reply. Is it possible for you to upload the finetuned model here ?

I'm sorry that we do not include finetuned model checkpoints in the repository because they would take up more than 10 GB for all the downstream tasks we experimented with in this work. To reproduce the results, we strongly suggest that you start with the pretrained model and play with any dataset you're interested in.
With regard to your questions:

We finetuned the model independently for each dataset. However, I think it's worth trying to simultaneously make multiple property predictions for polymers. You can refer to the works on multi-task regression.
I believe so. The pretrained model should serve as a foundation model so that it can be finetuned to learn domain-specific knowledge.


Error when uploading to MySQL using Laravel?

I get the following error when I try to save it in my database:
SQLSTATE[22007]: Invalid datetime format: 1366 Incorrect string value: '\xF0\x9F\x98\x87\xF0\x9F...' for column challenges.challenges.descriptionat row 1 (SQL: insert intochallenges (hashtag, title, description, challenge_id, image_name, category_id, duration, link, user_id, updated_at, created_at) values (emojitest, Emoji Test, This is an emjoit test 😇😇, 5edaaeb0a0c24, challenge-55edaaeb0a0c481591389872.png, 2, 0, ?, 5ec443a71e40b, 2020-06-05 20:44:32, 2020-06-05 20:44:32))

try to make your Collation as utf8mb4_unicode_ic for description field or for whole database. i also work in laravel and this been working fine

Thank you! It works now :)
On Monday, June 8, 2020, 12:56:33 PM GMT+2, NishantTadvi<EMAIL_ADDRESS>wrote:
try to make your Collation as utf8mb4_unicode_ic for description field or for whole database. i also work in laravel and this been working fine
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Copyright to 2024 [skip ci]

As the title.
Follow up of https://github.com/NVIDIA/spark-rapids/pull/10323
Signed-off-by: Tim Liu<EMAIL_ADDRESS>

build

build


How to get the base color from the tone palette.

In some cases we have an existing design and we want to adapt the theme to the material guides. It is easy to identify the primary color of the design, but how can I get the base color used to create the tone palette, since the primary color for example is the base color with tone value of 40. Is it possible to get the base color from the tone palette?
Thank you very much.

Hello - a follow up question to the generated tonal palette. Is there a way to have it also be exported as variables? i.e. primary10, blue10?


[1384] Fix preview link and test presence

Context
Follow up to https://github.com/DFE-Digital/manage-courses-frontend/pull/233
Changes proposed in this pull request

Fix URL of course preview
Add spec to check when it should and shouldn't be shown

Guidance to review
A course /description page

 Preview course link


User not redirected after deleting a project

When a project is deleted from Imbi, the user should be redirected somewhere (e.g., the projects page). Instead, the user remains on /ui/projects/{project_id}/settings with the entire page grayed out:

This was addressed somewhere along the way. I verified that deleting a project redirects to either the previous page or the project search page.


Deploy and run WMAgent with Docker container

Impact of the new feature
WMAgent
Is your feature request related to a problem? Please describe.
Once we have all the WMAgent dependencies sorted out, we should start looking into running WMAgent from a Docker image, making the process of updating our baseline code easier by just stopping the container and pulling a new one.
Describe the solution you'd like
With WMAgent package in PyPi, and a WMAgent docker image uploaded to Gitlab registry, we should complete the cycle such that we are able to run WMAgent using a Docker image, completing the deprecation and dependency on RPM packages.
This is a meta-issue for commissioning a Docker-based WMAgent environment for central production. It depends on the following sub-tasks:

[x]  Automated packaging and upload of WMCore services to Pypi #11276
[ ]  Create base docker image for WMAgent based on Red Hat flavor #11565
[ ]  Build a WMAgent docker image #8797
[ ]  Create script to deploy WMAgent docker image #11564
[ ]  Missing /etc/ && /bin/ && /src/ toplevel areas in the pypi packages #11583
[ ]  WMAgent: install/run MariaDB from Dockerhub #11313
[ ]  Evaluate performance of MariaDB in host vs container mode #11566
[ ]  WMAgent: install/run CouchDB from Dockerhub #11312
[ ]  Evaluate performance of CouchDB in host vs container mode #11567
[ ]  Update Jenkins WMCore baseline and PR-test to run based on WMAgent/CouchDB/MariaDB containers #11568
[ ]  R&D: Investigate integration HTCondor + WMAgent in a container setting #11570

Describe alternatives you've considered
None
Additional context
Related to:

Make CA certificates available in our WMAgent test container #10225
Unable to start agent in Docker container #9675

Dependent on:
https://github.com/dmwm/WMCore/issues/11312
and
https://github.com/dmwm/WMCore/issues/11313

@amaltaro , I think we are missing the part of deployment on a specific infrastructure. For example, if we'll deploy WMA using docker compose, then we'll need specific manifest file(s), etc. On top of that we should make a decision which orchestration to use. For details between different solution I suggest to google it, e.g. here is nice comparison. Therefore, I would suggest to create a dedicated issue related to that.

@todor-ivanov thank you for updating this meta issue with the new tickets resulted from:
https://github.com/dmwm/CMSKubernetes/pull/1410

As we discussed yesterday during the WMCore meeting, based on my previous experience with this containerization effort, I can point which are the most crucial and with highest priority issues to be resolved in order for WMCore Team to deliver this new functionality in the shortest possible timeline. I'll also add my high level/view feedback on the rest of the issues, but this will need to be confirmed during the dedicated effort on resolving them.
The 3 most important issues with absolutely no alternative for a workaround solution are:

https://github.com/dmwm/WMCore/issues/11720  -  All of the database functionalities which are needed here  are already well tested and working in the context of MariaDB, but we must add the needed Oracle alternatives to the manage script. One possible obstacle could be, the creation of an initial database schema dump and recording it during the deployment procedures for later validation and/or recovery. But this I believe is solvable.

https://github.com/dmwm/WMCore/issues/11313 - This is a must as  well, but we already have some markers and basic construction on how  should this docker image look like here: https://github.com/dmwm/CMSKubernetes/pull/1412 . The default configurations from my.cnf here and the MariaDB server startup script are confirmed to be working on a direct deployment at the host. I also remember having the MariaDB container built and tested locally, but without the relevant manage and run.sh scripts for automating its startup.

https://github.com/dmwm/WMCore/issues/11312 - This is also unavoidable, but again we already have a 99% completed PR resolving the issue: https://github.com/dmwm/CMSKubernetes/pull/1409 The container, built based on this PR, is well tested locally and working, but it is not uploaded to CERN registry.

Here follows the set of issues with feedback, which can be resolved with lower than maximum priority (as I said earlier, what ever I state here needs to be confirmed with a dedicated investigation/checks on the topic):

https://github.com/dmwm/WMCore/issues/11721 - This is good to have in the context of code organization, but things are working at  the moment, even with creation of the init table during deployment.

https://github.com/dmwm/WMCore/issues/11722 - This is again good to have in order to avoid manual work for adding those resources upon agent deployment, but if we  decide, for the time being, we can live with some extra commands which need to be executed at the agent before we start it, and we can resolve this issue with a medium priority as well.

https://github.com/dmwm/WMCore/issues/11566 - So far, I have not observed any signs of affecting the agent's performance somehow if MariaDB is run inside a container vs. directly at the host. Of course I did not have the chance to do a high scale load test, but I am confident, we will have no scalability issues in that regard.

https://github.com/dmwm/WMCore/issues/11312  - Same as above.

https://github.com/dmwm/WMCore/issues/11635 - The short answer to this  issue is: Yes ,for the time being, we need to use the --network=host option for the WMAgent container at runtime, and NO it is not needed at container build time. At least until we decide to completely move to a fully distributed solution and deploying WMAgents in kuberenetes clusters. But from what I see, there is a long way until we  reach that point.

https://github.com/dmwm/WMCore/issues/11568 - This is indeed a must for us to have a stable CI/CD process, but this for sure will come last. And how difficult would that effort be, given the resolution of all other issues, I'd let @amaltaro or @vkuznet  take a l look and share their opinion.

FYI @klannon @amaltaro

Thank you for sharing these insights, Todor.
I will soon start moving a few of these items under the Q1 quarter then, following your suggestion of: #11720, #11313, #11312. In addition, I inclined to say that the CI/Jenkins pipeline (issue #11568) should be updated accordingly and before we actually implement this new model in production, otherwise I fear it will be easier to insert issues into production.
We also need to pay closer attention to the Tier0 agent model and make sure that whenever central production is ready to migrate to the latest OS, that Tier0 agent can come along as well. For that, I created this new (meta-)issue: https://github.com/dmwm/WMCore/issues/11890

https://github.com/dmwm/WMCore/issues/11635 - The short answer to this issue is: Yes ,for the time being, we need to use the --network=host option for the WMAgent container at runtime, and NO it is not needed at container build time. At least until we decide to completely move to a fully distributed solution and deploy WMAgents in kuberenetes clusters. But from what I see, there is a long way until we reach to that point.

This is an important information and we better update the GH issue itself with this. Can you please update it?

hi @amaltaro

I inclined to say that the CI/Jenkins pipeline (issue https://github.com/dmwm/WMCore/issues/11568) should be updated accordingly and before we actually implement this new model in production, otherwise I fear it will be easier to insert issues into production.

Well then, it makes it 4 of them to get in as high priority. I am still positive about the outcome.

As discussed in the WMCore meeting, all the relevant and projected developments have been completed (now with the jenkins migration to Alma9 image as well). What is left are enhancements that came up during the required development.
While those are still valid and to be eventually considered, we decided to close this meta issue out. Thanks everyone!


Templatize via Cookiecutter for enhanced audience utility

This PR addresses #4 by moving to a Cookiecutter implementation for this repository. The benefit of this change entails making this template more accessible through Cookiecutter commands and more efficient through common text replacements which would otherwise need to be performed manually.
Note: After this is merged I plan to remove the Github template status (which will no longer be as helpful or accurate to the intent).
A demonstration of the audience experience after a merge can be found from the following command:
python -m cookiecutter https://github.com/d33bs/gc-cloud-storage-bucket.git --checkout templatize-via-cookiecutter

Thanks in advance for any thoughts and comments you may have!
Closes #4

Thank you @falquaddoomi ! I've added a terraform.tfvars file as you suggested and along with other updates.

Thank you @falquaddoomi and @vincerubinetti for your reviews! Merging this in now.


Enable JS reading with require(...)

src option must be resolved correctly for relative and absolute pathes when loading with require(...).
Fix this in Reader.readJs(src).

Can be resolved with resolving it with path module:
Reader.prototype.readJs = function (src) {
    var resolvedPath = path.resolve('', src);
    return Promise.resolve(require(resolvedPath));
};


[SPARK-28287][SQL][PYTHON][TESTS] Convert and port 'count.sql' into UDF test base

What changes were proposed in this pull request?
This PR adds some tests converted from 'count.sql' to test UDFs
Diff comparing to 'udaf.sql'

diff --git a/sql/core/src/test/resources/sql-tests/results/udaf.sql.out b/sql/core/src/test/resources/sql-tests/results/udf/udf-udaf.sql.out
index f4455bb717..6679c316dd 100644
--- a/sql/core/src/test/resources/sql-tests/results/udaf.sql.out
+++ b/sql/core/src/test/resources/sql-tests/results/udf/udf-udaf.sql.out
@@ -21,15 +21,15 @@ struct<>

 -- !query 2
-SELECT default.myDoubleAvg(int_col1) as my_avg from t1
+SELECT default.myDoubleAvg(int_col1), default.myDoubleAvg(udf(int_col1)) as my_avg from t1
 -- !query 2 schema
-struct<my_avg:double>
+struct<mydoubleavg(CAST(int_col1 AS DOUBLE)):double,my_avg:double>
 -- !query 2 output
-102.5
+102.5  102.5

 -- !query 3
-SELECT default.myDoubleAvg(int_col1, 3) as my_avg from t1
+SELECT default.myDoubleAvg(int_col1, 3), default.myDoubleAvg(udf(int_col1), udf(3)) as my_avg from t1
 -- !query 3 schema
 struct<>
 -- !query 3 output
@@ -46,7 +46,7 @@ struct<>

 -- !query 5
-SELECT default.udaf1(int_col1) as udaf1 from t1
+SELECT default.udaf1(udf(int_col1)) as udaf1 from t1
 -- !query 5 schema
 struct<>
 -- !query 5 output

How was this patch tested?
Tested as guided in SPARK-27921.

Test build #107528 has started for PR 25113 at commit 1980c72.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12654/
Test PASSed.

Test build #107528 has finished for PR 25113 at commit 1980c72.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107528/
Test PASSed.

Test build #107540 has started for PR 25113 at commit e399373.

@vinodkc,
 -- !query 2
-SELECT default.myDoubleAvg(int_col1) as my_avg from t1
+SELECT default.myDoubleAvg(int_col1), default.myDoubleAvg(udf(int_col1)) as my_avg from t1
 -- !query 2 schema
-struct<my_avg:double>
+struct<mydoubleavg(CAST(int_col1 AS DOUBLE)):double,my_avg:double>
 -- !query 2 output
-102.5
+102.5  102.5

This one looks a bit weird comparing to the original file.

Fixed the review comment, thanks

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12665/
Test PASSed.

Test build #107540 has finished for PR 25113 at commit e399373.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107540/
Test PASSed.

@vinodkc, https://github.com/apache/spark/pull/25130 is merged. Can you rebase and update?

retest this please

Test build #107815 has started for PR 25113 at commit e399373.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12936/
Test PASSed.

Looks good to me otherwise.

Test build #107815 has finished for PR 25113 at commit e399373.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107815/
Test FAILed.

Test build #107831 has started for PR 25113 at commit 4fd6170.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12946/
Test PASSed.

Closing this PR due to code synching will raise a new PR

Test build #107831 has finished for PR 25113 at commit 4fd6170.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107831/
Test PASSed.

Test build #107833 has finished for PR 25113 at commit bc9b0d2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107833/
Test PASSed.


account/platform stats return empty values with error

2 issues:

Inconsistently getting errors,
Volume shows for 1 month and all time, but not for 24 hour and 1 week.

below is an example of the error that sometimes occurs
{"id":312,"jsonrpc":"2.0","method":"getAccountTimeRangedStats","params":{"account":"0xbd355a7e5a7adb23b51f54027e624bfe0e238df6","universe":"0x3d777ea1541a7dec004972b283d53af3633b7531","startTime":1548857527,"endTime":1549462327}}

...
getter error:  Error: startTime/endTime error
    at /Users/bthaile/gitrepos/augur-node.git/src/server/getters/get-account-time-ranged-stats.ts:81:11
    at Generator.next (<anonymous>)
    at fulfilled (/Users/bthaile/gitrepos/augur-node.git/src/server/getters/get-account-time-ranged-stats.ts:4:58)

Fixed volume and sorted out endTime values.


Can't read values from property file

Framework version: 1.1
Implementations: Spring Boot

Scenario
Once app is starting I want to have possibility to read values from properties file ie. application.yml. I have defined app as below:
@SpringBootApplication
@ComponentScan({"foo.bar"})
public class Application extends SpringBootServletInitializer {
    @Value("${foo.clientId}")
    private String clientId;
}

Once app is up and running clientId should be populated with values provided in the file.
I have configured handler as provided in Readme file:
public class StreamLambdaHandler implements RequestStreamHandler {

    private static SpringBootLambdaContainerHandler<AwsProxyRequest, AwsProxyResponse> handler;

    static {
        try {
            handler = SpringBootLambdaContainerHandler.getAwsProxyHandler(Application.class);
        } catch (ContainerInitializationException e) {
            // if we fail here. We re-throw the exception to force another cold start
            e.printStackTrace();
            throw new RuntimeException("Could not initialize Spring Boot application", e);
        }
    }

    @Override
    public void handleRequest(InputStream inputStream, OutputStream outputStream, Context context)
            throws IOException {
        handler.proxyStream(inputStream, outputStream, context);

        // just in case it wasn't closed by the mapper
        outputStream.close();
    }
}

Expected behavior
Filed clientId populated with value from properties file
Actual behavior
Exception during lambda start process:
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'application': Injection of autowired dependencies failed; nested exception is java.lang.IllegalArgumentException: Could not resolve placeholder 'foo.clientId' in value "${foo.clientId}"
Steps to reproduce
Create app as above, create properties file, put placeholders, deploy on AWS and run.
Full log output

Hey @mpostupalski, can you make sure that the yml file is included in the shaded jar? Let me know if it's there and I'll investigate further.

I’m pretty sure that this file is located in the jar, @SAPessi . I can retrieve values using env.getProperty(“foo.clientId”) syntax. So somehow file is parsed.

I found similar issue described under the link: https://stackoverflow.com/questions/36081908/using-spring-boot-cloud-with-amazon-aws-lambda-does-not-inject-values

Seems plausible.  To avoid this in the future, I'll migrate the archetypes and samples to use the assembly plugin

An example with Gradle is also welcome ;-)

Ok, I found a workaround. The problem is mainly with application.yml file. With application.properties it works, but you have to provide path to the file with PropertySource annotation as follow:
@SpringBootApplication
@ComponentScan({"foo.bar"})
@PropertySource("classpath:application.properties")
public class Application extends SpringBootServletInitializer {
...
}

However it doesn't work perfectly as I tried turn off a banner (spring.main.banner-mode=off) but it still appears in the CloudWatch logs.

Does it read the yaml file is you specify it in the @PropertySource annotation?

Unfortunately this annotation does not work with yaml files.

Resolving this as a duplicate of #133. Support for both assembly and gradle will go out in version 1.3 shortly


[QUESTION] How to use fastapi with Django ORM ?

Description
I'm using Django ORM + Mysql with fastapi
all works fine
but at some point when application have no requests for some period of time I'm getting

2006 mysql server gone away

Most likely Django does some connection checks or closing somehere in the request flow..
(I tried to play with CONN_MAX_AGE and close_old_connections in middleware - no luck)
any idea how to do it with fastapi ?

Try use asynchronous alternatives of Django ORM. For example, try it: https://github.com/tortoise/tortoise-orm

@prostomarkeloff thank you
but there is a requirement to re-use a lot of Django code.

I definitely think getting fastapi to work with the Django ORM is a reasonable goal, and I've heard of multiple people doing this.

I think there was a similar issue that came up recently related to using asyncpg directly. If you want to prevent connection staleness issues, the easiest way is probably to do a "pre-ping" where you try to run an extremely cheap query (typically "select 1") using the ORM inside a middleware at the beginning of every request (or at least every request that makes use of the ORM). If it fails, you would then get a new  connection (presumably the ORM would handle this for you; you would just handle the exception in the middleware).
Note: despite the additional overhead, when I first saw this I was surprised to learn this is not considered a bad practice; it is discussed for sqlalchemy here: https://docs.sqlalchemy.org/en/13/core/pooling.html#dealing-with-disconnects (under the "pessimistic" handling section).
I am not familiar enough with django to be able to advise how to accomplish this, but I think it should be possible.

I suspect there is also a way to get the Django ORM to gracefully handle connection issues in an optimistic way, but again, I don't know enough about the Django ORM to advise.

Thanks for the discussion here!
@vitalik , does @dmontagu 's answer solve your problem? Did you solve it in any other way?

@tiangolo
Unfortunately - no
the goal is that connection should be checked / pinged before using ORM and closed if not responding
BUT the problem is that Django persist connection object to mysql inside threading.local
on the other hand starlette/fastapi run each operation in threadpool executor
meaning that middleware can run in one thread, but actual operation with ORM calls in other thread
which makes it impossible to check connection on some high level like middleware :(

@vitalik For what it's worth, you should be able to perform middleware-like operations inside the threadpool thread via a custom route handler: https://fastapi.tiangolo.com/advanced/custom-request-and-route/#custom-apiroute-class-in-a-router
Though admittedly this is less ergonomic than one would hope for.
Another approach might be to use the middleware to put a Django connection into a contextvar, which is passed into the threadpool executor's call. But I suspect that threadlocals are likely to cause problems if used in a concurrent context like this.
Hopefully as Django becomes more ASGI compatible they refactor into using contextvars rather than thread locals anyway. I'm not sure if there has been any discussion on this topic from the django devs but that might be a good topic to search for for ideas about how to work around this.

I use this decorator to close stale connections, don't know if it helps in the async world.
def ensure_fresh_db_connection(f):
    @wraps(f)
    def wrapper(*args, **kwargs):
        django.db.close_old_connections()
        result = f(*args, **kwargs)
        return result
    return wrapper

I'm not currently using Django, but some people have been doing experiments mixing Django and FastAPI, e.g. https://www.stavros.io/posts/fastapi-with-django/
Maybe that can help you with your use case.

This can help somebody https://www.stavros.io/posts/fastapi-with-django/

        django.db.close_old_connections()

I was getting  django.db.utils.InterfaceError: connection already closed errors when using django ORM from inside fastAPI views (using postgres as a db). I can confirm running this in the views solved  the issue for me !

For anyone trying to do this, https://gist.github.com/bryanhelmig/6fb091f23c1a4b7462dddce51cfaa1ca outlines an example asgi.py which makes close_old_connections more convenient via middlewares. It also showcases a fun difference between how run_in_threadpool() and sync_to_async() behaves, which duplicates connections (boo!) but at least the dead connections get cleaned up in both instances.

Hi @bryanhelmig
Wow great work!
I tried to go that rabbit hole, but at some point said "screw it" and made django ninja instead :D


Angular2 typescript client IE 11 issue : Symbol is undefined at e.prototype._mergeClaims

Hi,
I use oidc-client 1.2.2 in an Angular2 application.
The code works well on Chrome but on IE 11 I receive this error when calling this.userManager.signinRedirectCallback():
"ReferenceError: « Symbol » is undefined
at e.prototype._mergeClaims (http://localhost:51540/dist/vendor.js?v=6pO0oWkadKK50hFBpfYy7bByeLBtMr0x1c4CY9wDqY4:1376:21912)

It'd be a polyfill issue but I don't know how to fix it, can you help ?
I tried to import babel-polyfill in my bootstrap but in this case I receive a ZoneAwareError

Ok, got it, sorry for the inconveniance.
I added 'babel-polyfill' in my wepack entry and import 'babel-polyfill'; before import 'zone.js'; in my boot code and it works


Ambiguous wording

Hello, I have one question about this part.

Does "The status should change from Pending to Start/End date." means that the wording "Start/End date" will be displayed in the "Status" column, or does it means that an actual start/end date (like "5/30/2019 - 6/30/2024") will be displayed?
Thanks!
François

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 97154f08-4e08-e3b9-bd7f-b399aeb763ef
Version Independent ID: 56c611c8-ce10-caa0-f48c-41237c5a8151
Content: Azure EA portal administration - Microsoft Cost Management
Content Source: articles/cost-management-billing/manage/ea-portal-administration.md
Service: cost-management-billing
Sub-service: enterprise
GitHub Login: @bandersmsft
Microsoft Alias: banders

@FRFR-LO
Thanks for your feedback! We will investigate and update as appropriate.

@bandersmsft FYI

@frfr-lo Hi there. I've updated the article for clarity and resolve this issue.
Here's the text update I made to the article:

The status changes from Pending to Active. When Active, dates shown under the Start/End Date column are the start and end dates of the agreement.

#please-close

@bandersmsft Thanks! Have a nice day.


mingw: make get_msvcr() a noop + add a CI job testing MSVC Python with GCC

See the commits for details.
Fixes #204

(I initially made the test suite test against multiple compiler types, but that turned out to complicate things a lot, so I abandoned that approach: https://github.com/msys2-contrib/distutils/commit/fa7e35b063318d6909825ba678aedeb672a17219)

Amended as c9781aef9.

Thanks! And thanks for the improvements.


[Feature Request] Return real strings instead of byte array as the response content

Current Behavior

Automatically decode UTF8’s
Desired Behavior

Screenshots / Mockups

Alternatives

Implemented


pip Installing CLI on windows fails

When attempting pip install azure-cli on windows globally, the following error occurs:
-mgmt-iothubprovisioningservices, azure-mgmt-servicefabric, azure-mgmt-cosmosdb, azure-cli
WARNING: Failed to write executable - trying to use .deleteme logic
ERROR: Could not install packages due to an EnvironmentError: [WinError 2] The system cannot find the file specified: 'c:\python38\Scripts\pyjwt.exe' -> 'c:\python38\Scripts\pyjwt.exe.deleteme'
Python version:
PS C:\Users\stevens\projects\dotnetsdk\azure-proto-sdk> python
Python 3.8.6 (tags/v3.8.6:db45529, Sep 23 2020, 15:52:53) [MSC v.1927 64

hi @fengzhou-msft could you pls help to have a look? thanks


Cache needs to be inside a directory

In the most recent release, you’re setting:
local storage_file="$HOME/Library/Caches/com.runningwithcrayons.Alfred/Workflow Data/com.yohasebe.fzf-alfred-workflow"

And using it as a file. That is incorrect. The workflow’s cache folder should always be retrieved by using the environment variable (${alfred_workflow_cache}) and any files created inside it. You can mkdir -p "${alfred_workflow_cache}" to ensure it exists beforehand. Please do not create top level files in ~/Library/Caches/com.runningwithcrayons.Alfred/Workflow Data. That is a place to store folders identifying their origin workflow.

Thank you for bringing this to my attention!
I've updated the script to ensure that it properly utilizes the alfred_workflow_cache environment variable for saving a separate file to check if it is the first call of the workflow after the macOS startup.

Fast turnaround! Thank you.


Publish extension for Firefox via GitHub Actions

Blocked on https://github.com/mozilla/web-ext/issues/804
See also: https://github.com/fregante/web-ext-submit

You can set it up by copying this workflow as well https://github.com/sindresorhus/refined-github/blob/main/.github/workflows/release.yml


karpenter provisioning of nodes very aggressive sometimes

Description
Observed Behavior:
When a deployment is scaled to add more pods, karpenter provisions nodes for provisionable pods. Noticed that karpenter over-provisions nodes.
INFO    controller.provisioning Found 16 provisionable pod(s)
INFO    controller.provisioning Computed 16 new node(s) will fit 16 pod(s)
INFO    controller.provisioning Launching node with 1 pods requesting {"cpu":"285m","memory":"740Mi","pods":"7"} from types m5.large
.... 16 times
FYI, an m5.large can hold as many as 15-20 of the above application pods (in addition to 5-6 daemonset pods like node, proxy, csi controller, etc). Have seen this on existing nodes.
Now, I have a large number of nodes most of them running 1-3 of the application pods
This is far more expensive than expected.
What is causing karpenter to provision nodes so aggressively? Does it not try to aggregate resource needs of the pending pods?
Happy to provide additional info.
Expected Behavior:
Expecting 1-2 nodes provisioned for the 16 provisionable pods, instead of 16 nodes
Reproduction Steps (Please include YAML):
Versions:

Chart Version:
Kubernetes Version (kubectl version): 1.25 (on AWS EKS)

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Can you provide your Provisioner, AWSNodeTemplate, and Logs?

Attaching provisioner and awsnodetemplate. I already provided the appropriate karpenter controller log snippet... What else do you need?
provisioner.txt
awsnodetemplate.txt

Do you have any pod or node affinity for the pods? Would you be able to share the deployment spec?

Also have you considered using consolation? If karpenter over-provisions nodes, consolidation will terminate the excise nodes, which could be a potential work around for the time being

The deployment spec does have a topology spread constraint, to try and spread across AZs, and across nodes. Perhaps, this is the cause for over-provisioning nodes? Here's the part of the spec:
  topologySpreadConstraints:
    - maxSkew: 1
      topologyKey: topology.kubernetes.io/zone
      whenUnsatisfiable: ScheduleAnyway
      labelSelector:
        matchLabels:
          app: {{.Values.metadata.name}}-v{{$.Values.metadata.version}}
    - maxSkew: 1
      topologyKey: kubernetes.io/hostname
      whenUnsatisfiable: ScheduleAnyway
      labelSelector:
        matchLabels:
          app: {{.Values.metadata.name}}-v{{$.Values.metadata.version}}

I don't have consolidation specified, I tried to use it once and I got an error when I added the consolidation attribute to the Provisioner spec, based on documentation:
spec:
consolidation:
enabled: true
When I applied the spec, I got this:
strict decoding error: unknown field "spec.consolidation"
Please advise. If topology spread constraint is the issue, I can remove it and I'd like to add consolidation, but I don't have proper documentation on how to.... Please let me know how to add consolidation
One question regarding consolidation: I don't want karpenter to de-provision nodes that it did not provision. Is that the behavior as designed?

Based off the topology spread it would seem that karpenter would spread the pods as much as it can to fulfill the spread. Consolidation then should adjust the number of nodes to get the cluster to a reasonable state.
Here is some guidance on using consolidation: https://karpenter.sh/docs/concepts/provisioners/#specconsolidation. You can find example use-cases. Also, Karpenter will only de-provision nodes it has provisioned. That is the behavior consolidation was implemented.

I'll remove the topology spread constraint and let you know if that leads to a change in karpenter behavior.
Regarding consolidation, I tried what's in the documentation... but it failed. I sent you the error message.
spec:   consolidation:     enabled: true
does not work. I get the error
strict decoding error: unknown field "spec.consolidation"

apiVersion: karpenter.sh/v1alpha5
kind: Provisioner
metadata:
name: default
spec:
consolidation:
enabled: true
ttlSecondsAfterEmpty: 60
providerRef:
name: default
requirements:
- key: karpenter.sh/capacity-type
operator: In
values: ["on-demand"]
- key: kubernetes.io/arch
operator: In
values: ["amd64"]
- key: node.kubernetes.io/instance-type
operator: In
values: ["m5.large"]

apiVersion: karpenter.sh/v1alpha5
kind: Provisioner
metadata:
  name: default
spec:
  consolidation:
    enabled: true
  ttlSecondsAfterEmpty: 60
  providerRef:
    name: default
  requirements:
    - key: karpenter.sh/capacity-type
      operator: In
      values: ["on-demand"]
    - key: kubernetes.io/arch
      operator: In
      values: ["amd64"]
    - key: node.kubernetes.io/instance-type
      operator: In
      values: ["m5.large"]

The above doesn't work.
When applied, I get
strict decoding error: unknown field "spec.consolidation"

You would need to remove ttlSecondsAfterEmpty. Consolidation will remove nodes that are empty automatically.

I removed ttlSecondsAfterEmpty and I'm still getting the same error
strict decoding error: unknown field "spec.consolidation"

What is version of karpenter are you using?

We are using an old version of karpenter. Will upgrade to 0.29.2 (the latest stable) and update here on whether that fixes the issues

@tejarora make sure to update CRDs too


Pluralize translations

Hello,
I notices that tin the fnando/i18n-js doc there is an easy way to pluralize the words by doing
Car: {
   counting:{
     one: 'Car',
     other: 'Cars'
}}

and call it with i18n.t('Car', {count: 10}} which should here return Cars
When I define my translations like that I have an error saying that my key, value translation schema is wrong, and that I can't define an object of translations.
So I'm probably not defining my translations schema as I should, and I can't find any example with a JSON formatted translation file. Any idea ?
Here are screen shot of the error/warning

@ansmonjol your json is wrong. Try it something like this instead:
"Car": {    "counting":{      "one": "Car",      "other": "Cars" }}

I'll try thanks !
I close the issue for now and will reopen if something went wrong ;)

For future explorers:
You have to use the the variable name 'count' for it to be pluralized, otherwise you will get a RSOD similar to the above.

Hi @ansmonjol
Can you help me getting pluralization to work?
I have a localization file that looks something like this:
.init({
        fallbackLng: 'en',
        lng: "en",
        resources: {
            en: {
                common: {
                    frequency: {
                        interval: {
                            one: "Every day",
                            other: "Every {{count}}. day",
                            zero: "Never",
                        },
                    },
                },
            },
        },
    })

And I use it like this in my component:
let intervalString = i18n.t("frequency.interval", {count: myCount})
I tried the other solutions mentioned here, but I can't get it to work :(

@nabati Thank you, sir. Saved my day!

@nabati Was looking for this everywhere. Thanks!
Should we consider adding to documentation?


[Draft/1.19.2] Multiloader Migration

I have converted this PR to Draft for you to prevent confusion with it.
I'll be implementing your rewrites into MerchantPug/Origins-Addon-Multiloader-Template itself, as I feel you'd be okay with me doing so. Otherwise I'll let you just work on this whenever you're available, no pressure.

Additionally, I'll be handling TooManyOrigins myself, its rework is staged for a rewrite soon too. Just thought I'd mention this as the two mods are very closely related.

I will review this PR once it is considered ready. No matter how long it is, I don't even mind if 1.19.3 releases before this.

@LimonBlaze Am I okay to merge this and work on it myself?

Merged so I can continue work on this.


Animated GIF proxying issues

Can't proxy animated images, it loads only first frame and animation isn't working.
What I'm doing wrong?

Unfortunately, this library uses GD which doesn't support animated GIFs.

So sad!
This solution works perfectly for me except gifs.


Download URL for DASH videos (example formats: 136 & 137) is regularly not working

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.10.05.

[x] I've verified and I assure that I'm running youtube-dl 2018.10.05

Before submitting an issue make sure you have:

[x] At least skimmed through the [README][FAQ][BUGS]
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Question

Description of your issue, suggested solution and other information
I have searched for a solution for several hours (literally), but couldn't find one.  Also, I am sorry for my bad writing, I am not native English and heavily struggled with the wording of my problem.
My Goal:
I am trying to get the Download URLs for new YouTube Videos (Videos that just got uploaded) as fast as possible and in good quality (720p+). I don't really care about the audio for now. Therefore, the best formats for me are: 22 (mp4 720p muxed video), 136 (mp4 720p DASH video) and 137 (mp4 1080p DASH video).
The DASH (video only) formats are usually available before the muxed (video & audio) formats. That's why I highly prefer the formats 136 and 137 over the format 22. webm formats seem to be the slowest, so I ignore them completely.
My Problem:
The DASH formats are sometimes downloadable and sometimes not. I have no clue why I sometimes can't get a working Download URL for these formats.
An Example:
youtube-dl -f 136 --get-url https://www.youtube.com/watch?v=Lhw5xo67tdE
The above line gives me the following Download URL, which is not working:
https://r2---sn-4g5ednsz.googlevideo.com/videoplayback/id/2e1c39c68ebbb5d1/itag/136/source/yt_otf/requiressl/yes/ms/au,onr/mn/sn-4g5ednsz,sn-2gb7sn7s/mm/31,26/initcwndbps/1640000/gcr/de/pl/33/mv/m/ei/-Lm4W8iRN4as7gOjha7IDw/ratebypass/yes/mime/video%2Fmp4/otfp/1/otf/1/lmt/1538804333825591/fvip/2/mt/1538832759/disable_polymer/true/ip/2a02:908:4c8:a5a0:cdd1:be80:64d9:db5e/ipbits/0/expire/1538854489/sparams/ip,ipbits,expire,id,itag,source,requiressl,ms,mn,mm,initcwndbps,gcr,pl,mv,ei,ratebypass,mime,otfp,otf,lmt/signature/8BF5C062893295ECA0A89A13B0584D529A160A31.243F2A495E473FA2D5E912FAAB0998951EE4A58C/key/dg_yt0/
youtube-dl -f 137 --get-url https://www.youtube.com/watch?v=Lhw5xo67tdE
The above line gives me the following Download URL, which is working:
https://r2---sn-4g5ednsz.googlevideo.com/videoplayback/id/2e1c39c68ebbb5d1/itag/137/source/youtube/requiressl/yes/mm/31,26/pl/33/mn/sn-4g5ednsz,sn-2gb7sn7s/mv/m/ms/au,onr/gcr/de/ei/crq4W_WbDoqWgQeYt7vAAQ/initcwndbps/1587500/ratebypass/yes/mime/video%2Fmp4/otfp/1/gir/yes/clen/5840808617/lmt/1538804333825591/dur/11666.534/mt/1538832839/fvip/2/disable_polymer/true/ip/2a02:908:4c8:a5a0:cdd1:be80:64d9:db5e/ipbits/0/expire/1538854610/sparams/ip,ipbits,expire,id,itag,source,requiressl,mm,pl,mn,mv,ms,gcr,ei,initcwndbps,ratebypass,mime,otfp,gir,clen,lmt,dur/signature/4E362C28980E748D161154525DE4927A45146BF7.21D45E9F562BEBF115EC6DC8900D05CF726E5126/key/dg_yt0/
My Question:
Am I doing it wrong? Some Download Links work and some don't. I am unsure if the problem lies with me or the way YouTube stores the Download Links for DASH-video-formats.
Is there a workaround which will let me grab working Download URLs for the formats 136 and 137 more consistently?

This is not a download URL but base URL to MPD manifest of true segmented DASH.

as said before, sorry for my wording.
Why does one URL work in my browser (the URL I get from the format 137) and the other not (the URL I get from the format 136)? What can I do to get both of them to work?

Ask youtube why. Again: there are no direct download URLs for these formats because these formats are only available as segmented DASH.


fix SvgCssUri fallback

Summary
When using the SvgCssUri component, specifying fallback does not render the fallback component in the case of an error.
I looked through the source code and believe this is because SvgCssUri is rendering a SvgCss
https://github.com/software-mansion/react-native-svg/blob/22f47333fbe134b0c697b9c0190a09d6927f2cea/src/css.tsx#L712
which renders a SvgAst
https://github.com/software-mansion/react-native-svg/blob/22f47333fbe134b0c697b9c0190a09d6927f2cea/src/css.tsx#L696
which does not use the fallback prop
https://github.com/software-mansion/react-native-svg/blob/22f47333fbe134b0c697b9c0190a09d6927f2cea/src/xml.tsx#L96
This fix copies over the error handling code from SvgUri so SvgCssUri can render a fallback on error. I tested the change in my project and this works like it does for SvgUri
Test Plan
I tested this in my own project and I would have tested in this repo but not exactly sure how to run the tests in TestsExample. I went into that directory and ran yarn test but the setup seems to be broken.
Compatibility

OS
Implemented

iOS
✅

Android
✅

Checklist

[x] I have tested this on a device and a simulator
[ ] I added documentation in README.md
[ ] I updated the typed files (typescript)
[ ] I added a test for the API in the __tests__ folder

@myou11 can you resolve the conflicts? We recently changed the repo structure so you'll have to move the code.

@WoLewicki np, fixed now!


Automate RTD deployment?

Discussed (briefly) in this PR
https://github.com/payu-org/payu/pull/287
Add automatic RTD deployment? Probably easiest to do in the CircleCI workflow, as that already has an action for tagged commits for building a conda package.

Fixed in https://github.com/payu-org/payu/pull/408


Areon Network Testnet

Chain Name
Areon Network Testnet
Chain ID
462
RPC URL
https://testnet-rpc.areon.network
Block Explorer URL
https://areonscan.com
Deployment Funds
Yes

I won’t be able to deploy for another 1-2 weeks, so I’d recommend using the presigned transaction described in the README: https://github.com/mds1/multicall#new-deployments

Done, thanks!


Export API: Sink.Get API

As a user of the Workload Manager, I would like an API to get details of a sink so that the process can be automated by scripts and other applications.
Acceptance Criteria

A RESTful API to get details of a sink

Closing due to redesign


Godot attempting to load BPTC textures on Android

Godot version
Godot 4.0 Stable
System information
Windows 11, Vulkan Mobile, NVidia RTX 3070 TI - targeting Quest 2
Issue description
When running the Godot-XR-Tools demo project natively on the Quest, the main scene fails to load because the resource loader tries to load the BPTC version of the texture, even though the ASTC version was bundled into the APK.
Unable to open file: res://.godot/imported/SkyOnlyHDRI023_2K-TONEMAPPED.jpg-bcb5464e5ed42ee2463b71652f907f38.bptc.ctex.
Steps to reproduce
Build the latest godot-xr-tools demo project (https://github.com/GodotVR/godot-xr-tools) targeting the Quest.
The project has both S3TC/BPTC and ETC2/ASTC texture compression formats enabled.
The .import files mention both the S3TC/BPTC and ETC2/ASTC formats; however when exporting for Quest 2 (an Android target) Godot automatically enables the astc and etc2 features and bundles only the ASTC and ETC2 textures into the APK.
At startup the resource importer reads the .import files, sees S3TC/BPTC as the first enabled texture, sees that S3TC/BPTC is supported on the platform, and picks that format - totally ignoring what was actually bundled into the installer.
Minimal reproduction project
Build the latest godot-xr-tools demo project (https://github.com/GodotVR/godot-xr-tools) targeting the Quest.

This seems related to a similar issue in July 2022 (https://github.com/godotengine/godot/pull/62909), and in that case a "lazy" fix was applied which just lied about the supported capabilities of the operating system to trick the resource loader into only loading the desired formats.

A few of us discussed this on Roacketchat and we think we know what the issue is and how to resolve it.
The Issue
At export time the exporter is removing the BPTC and S3TC files as it should. But it is not removing the reference to the S3TC and BPTC files from the import metadata. At load time, the engine checks the graphics driver to see if the format is supported, if it is, it will try to load it.
Since there is a mismatch between what we export and what the GPU supports it ends up trying to load a non-existent resource.
Accordingly, there are two parts to the problem:

Export formats are too rigid for mobile (i.e. we force ETC2/ASTC at export time even though some Android devices support S3TC/BPTC)
The import metadata isn't correctly being amended at export time (i.e. the references to BPTC/S3TC files are left behind)

In 3.x we solved this problem by forcibly disabling reporting S3TC from the OpenGL driver side (I don't know why we didn't run into issues with BPTC).
The solution
First we need to change the exporter settings. On PC we have checkboxes for BPTC, S3TC, ETC, and ASTC. They need to be changed to only have 2 checkboxes S3TC/BPTC and ETC2/ASTC. We need to add these checkboxes for Android and remove the hardcoded options for ETC2 and ASTC.
Second, we need to figure out why the import metadata maintains reference to BPTC at export time and change it to respect the export checkboxes added above.

First we need to change the exporter settings. On PC we have checkboxes for BPTC, S3TC, ETC, and ASTC. They need to be changed to only have 2 checkboxes S3TC/BPTC and ETC2/ASTC. We need to add these checkboxes for Android and remove the hardcoded options for ETC2 and ASTC.

For the record, according to @reduz it sounds like we should instead remove all configuration options for PC, and just stick to:

S3TC/BPTC for PC (ETC2/ASTC would be a superior option, but is not supported by most PC GPUs so it's not usable in practice)
ETC2/ASTC for mobile (apparently superior in quality to S3TC/BPTC, so there's no reason to use the latter)

We still have the "lazy" fix code present for S3TC in the gles3 driver, and this could be expanded to cover BPTC:
https://github.com/godotengine/godot/blob/dac2d8fb4214d3394bfb33b28f35f6d1e61518a8/drivers/gles3/storage/config.cpp#L80-L87
It looks like we have the equivalent code on the Vulkan side for S3TC and could be expanded to cover BPTC:
https://github.com/godotengine/godot/blob/dac2d8fb4214d3394bfb33b28f35f6d1e61518a8/servers/rendering/renderer_rd/storage_rd/utilities.cpp#L272-L283

I think I have a solution for this. Will post a PR soon. Reduz was right. The code that exports the .import files was just copying them over as-is thought regard to the file types that were being trimmed at export time. The solution is to edit the exported copy of the .import file to only include the texture types that are being exported.


Controls: Foldable & dual-screen support

Migrate the dual-screen docs from Xamarin.Forms to .NET MAUI, including any relevant updates.
https://github.com/dotnet/maui/pull/6514

Associated WorkItem - 32668

This was completed last year.


layers/meta-balena: Update to v2.81.1

Update meta-balena from 2.80.8 to 2.81.1
This will be the base for the ESR release.
Changelog-entry: Update meta-balena from v2.80.8 to v2.81.1
Signed-off-by: Alex Gonzalez<EMAIL_ADDRESS>

@resin-jenkins test this please

The raspberrypi3-64 test seems stuck, and the raspberrypi2 rig device has a hardware failure. Force merging as the RPI, RPI3 and RPI4 passed.


Extending automatic Workflows CSS discovery with caching (extends #8201)

Fixes #7873 and #8008 .
Replaces PR #8009 where the source repository doesn't exist anymore.
Extends PR #8201 with caching

@sebastienros caching added to the ResourceManifest in Orchard.Workflows as discussed during the previous community meeting.


Support a way to set both the user message and the internal message to the same thing when creating a new error

Example: in a web app's controller, you want to raise an error with a user message.  The internal error message should be same.  Today, you need to make two calls with the same message argument to achieve this.  Would be nice to express "use this message for the internal message and the user message".
There are a few approaches:

A set of methods which set both the internal and user message
A function which fetches the user message first, and falls back on the internal message if no user message is set
A function which fetches the internal error, and falls back on the user message if not set

I'm leaning towards three.  Two seems wrong because the whole purpose of the "user message" property is for frameworks to ensure that error messages presented to end users have been explicitly approved for end user consumption.

Done.  I made merry error's Error() func return the user message iff the error message is empty.  So if you create an error like this:
err := merry.New("").UserMessage("Wrong")

...then err.Error() will equal "Wrong"
And since merry.New("")... is a little ugly, I added new methods for constructing errors this way:
merry.UserError("Boom!")
merry.UserErrorf("Boom! %v", "Crash!")


feat: Add possibility to discover archived projects with catalog-backend-module-gitlab

Hey, I just made a Pull Request!
Based on issue I created earlier: https://github.com/backstage/backstage/issues/27184
In this PR I added another option to catalog-backend-module-gitlab config called includeArchivedRepos (with default false value).
If that parameter is set to true in app-config.yaml, then the discovery phase includes archived projects.
Example usage in app-config.yaml:
catalog:
  ...
  providers:
    gitlab:
      projects:
        host: gitlab.xxx.com
        branch: main
        group: projects
        includeArchivedRepos: true
        schedule:
          frequency: { hours: 12 }
          timeout: { minutes: 20 }

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Just a minor thing in the changeset which should hopefully make CI green. It did not pass for some reason

@jhaals CI passed 🎉 but I think I don't have an access to write, thus merge the PR


[Google Maps Plugin] myLocationButton enable/disable

Currently if you use MyLocation feature from Google Maps plugin it will also show MyLocationButton. Would be great if that button were optional.

cc @cyanglaz

Changing the position would be nice aswell!

@iskakaushik

Yes it would be great to change the position of the button and to style it as well.

It would be great to make identical design and position for location button on android and ios

@iskakaushik Is there any update on making the design and position for location button on both platforms identical?


Filter invalid contigs rather than throw an error, drop AF and PL.

Closes https://github.com/broadinstitute/seqr-loading-pipelines/issues/607

Is it possible to put the AF portion back? Was there a reason for this change? We spoof the AF field to filter artifacts as internal controls, and loading really large VCFs hasn't been easy for us cloud-wise. This had been our solution until now.

These changes provide stability and reliability when loading data with potentially inaccurate or malformed annotations. We will not be reverting this behavior, as reverting changes that make the pipeline broadly stable is not something we are willing to do.
I am not entirely sure why spoofing the AF field feels like a reasonable way to handle artifacts - if you have
variants you would never want returned from search you should prefilter your VCF not to include them in loading. If you want variants to come bback in search but have the option to filter them out, I would recommend adding flags to the "filters" list


Adding default tokens to ActionIcon

Checklist
(Check off all the items before submitting)

[x] Build process is done without errors. All tests pass in the /lib directory.
[x] Self-reviewed the code before submitting.
[x] Meets accessibility standards.
[x] Added/updated documentation to /website as needed.
[x] Added/updated tests as needed.

Purpose
Some default styles were added in case there are no tokens available.
This will allow the component to be used in isolation.

Verify that the tabIndex is being correctly set and ensure that keyboard interaction is working as expected.
The keyboard interaction is not needed to be tested, since it is the HTML behavior.


Running Danger on Bitrise fails with module compiled with Swift 5.7.1 cannot be imported by the Swift 5.6.1 compiler

Hi,
Since Jan 31, I have started to get an error when running Danger on Bitrise on a Monterey VM, with Xcode 13..
Specifically, I receive the following error:
+ brew install danger/tap/danger-swift
Warning: danger/tap/danger-swift 3.15.0 is already installed and up-to-date.
To reinstall 3.15.0, run:
  brew reinstall danger-swift
+ danger-swift ci --verbose
/var/folders/9l/1ysg9vq51p37q0lgksxhdb9r0000gn/T/danger/46D9AB1B-2AD1-4BCE-A81D-C76FB0670DFF/_tmp_dangerfile.swift:1:8: error: module compiled with Swift 5.7.1 cannot be imported by the Swift 5.6.1 compiler: /usr/local/lib/danger/Danger.swiftmodule
import Danger
       ^

According to the documentation, the latest version requires Swift 5.5, and the VM comes with Xcode 13, i.e. Swift 5.6.
Did something change recently that's not documented?
Thanks for any input.

Closing this as it was a fault on Bitrise side 😊


Csharpier removes empty lines in ignored blocks of code

Reproduction code:
public class ClassName
{
    public void LongUglyMethod()
    {
    	// csharpier-ignore-start
        LongUglyMethodName(context, magic[1],
            "very-long-string-one",
            "very-long-string-two",
            "very-long-string-three"
        );

        LongUglyMethodName(context, magic[2],
            "very-long-string-one",
            "very-long-string-two",
            "very-long-string-three"
        );
        // csharpier-ignore-end

        // csharpier-ignore
        LongUglyMethodName(context, magic[1],
            "very-long-string-one",
            "very-long-string-two",
            "very-long-string-three"
        );

        // csharpier-ignore
        LongUglyMethodName(context, magic[2],
            "very-long-string-one",
            "very-long-string-two",
            "very-long-string-three"
        );
    }
}

Expected:
no changes
Actual:

What's funny, is that the only white line that is not covered by ignore IS preserved,

It was even worse in a case like this....
public class KeepLines1
{
    // csharpier-ignore-start
    private string    first;

    private string    second;
    // csharpier-ignore-end
}

// became

public class KeepLines1
{
    // csharpier-ignore-start
    private string    first;private string    second;
    // csharpier-ignore-end
}

It should behave as expected with the next release. Thanks for the report!


Update README.md

updated the rails call to include bin

after review from RJ and MS decided changes not needed or needs an overall review and update.