Single-occurrence inlining mk IV

Finally, we've got rid of all the issues it turned up, and it now
appears to work fine.
I also added a little bit of type inlining on the basis of similar
heuristics to terms: trivial types or single-occurrence types.
This does make things a bit slower, the Marlowe validator goes from
taking 1.7s to 3.4s. This isn't due to the type inlining, I tried
turning that off, it's just that we're inlining more stuff generally
now. We could still make the inliner faster (or be cleverer with
renaming), but it's not a catastrophic increase (and much lower than it
was before when we were unconditionally inlining all the types!).

Pre-submit checklist:

Branch

[x] Tests are provided (if possible)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages
[x] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

I may try to profile the branch to get the flamegraph if needed.

I may try to profile the branch to get the flamegraph if needed.

My guess is that we're just doing much more inlining, and the expensive bit of inlining is renaming :D

I may try to profile the branch to get the flamegraph if needed.

My guess is that we're just doing much more inlining, and the expensive bit of inlining is renaming :D

There are two options:

implement the actual rapier from the paper,
do everything under a source of uniques (probably the one from GHC is slightly faster).

Frankly, as the Inliner is giving me slight PTSD, I would probably go with the latter and stick everything in an IO monad.

do everything under a source of uniques (probably the one from GHC is slightly faster).

We have that: it's exactly MonadQuote! The question is just whether renaming every binder as we go down the program is faster or slower than renaming terms before we put them into the program.

do everything under a source of uniques (probably the one from GHC is slightly faster).

We have that: it's exactly MonadQuote! The question is just whether renaming every binder as we go down the program is faster or slower than renaming terms before we put them into the program.

Our MonadQuote is a StateT over a counter. I previosly used its abstract interface, which was recently fixed by @ak3n in #3850.
From what I know, GHC has two kinds of uniques:

Data.Unique from base, which is roughly the same as ours, but uses IO instead of StateT, and
GHC.Types.Unique.Supply, which is a splittable unique supply using lazy trees (the apporach mentioned in the paper).

I was wondering if the latter would be faster, as the unique supply can be splitted.

I think that using IO vars may really help. As far as I remember it improved Idris's performance a lot. Found the link https://www.type-driven.org.uk/edwinb/why-is-idris-2-so-much-faster-than-idris-1.html

Could use a STRef as a non-IO version. Anyway, we can try this separately!


fix(docs): fix alert snapshot tests

It's not about loading, but about the config.

The stories are now fixed, but I think waiting for the post-icon in snapshot tests is still necessary.

It works on the snapshot. But there is a weird flash switching between icons on the two last elements of each color group.


Training time?

Thanks for your solid work. How long does it take to train the Base and Large model on V100 or 2080Ti?

For the Base model:
--V100: ~40h
--2080Ti: ~3d20h
For the Large model:
--V100: ~3d+
We didn't train MixFormer-L on 2080Ti since it requires large gpu memory.

Thanks a lot.

May I ask the training time metioned above is under lmdb data format or not?

Not the lmdb data format.

I am training the base_large model on a GPU with 12 GB of RAM memory. As soon as I increase the batch size to more than 1 I am getting "CUDA out of memory issue". I am wondering how much memory did you have on your V100 GPU, 32 GB? Anyway it is strange since I was expecting to settle a batch size of 4 or so. Thank you!!


According to Eq.2 in the paper, the output of Gridding is divided by the number of points in the neighborhood.

Is there a way in the code to return wi?
because the values of vertices are not divided by N(vi).
(The value returned after gridding seems to be the values of vertices instead of wi)

Replied in #36.


fix(shipper): increased detection for AusPost delivery emails

Proposed change
A lot of the email subjects (all in my case) from AusPost include the stores name in the middle of the subject, preventing the current search term from working.
"Your delivery is coming today" will only work if the store name isn't present.
In all the cases from my experience the subject will be in one of these 3 formats:
"Your delivery from Kmart is being prepared"
"Your delivery from Love Honey is on its way"
"Your delivery from Walter White is coming today"
I have tested this change in my live Home Assistant install and it correctly finds my current deliveries.

Type of change

[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests
[ ] Documentation update
[ ] Adds a new shipper
[x] Update existing shipper

Additional information
This change also finds AusPost deliveries that have just been assigned a tracking number and aren't necessarily out for delivery yet.
It will find deliveries at every stage. Tracking assigned, In-Transit (between depots) and Delivering today.

Thank you, but it looks like this was already corrected in the latest betas.


How to customize SublimePicker

Hello)
Please, help me)))

I want to change the text color\text size\label margin or padding for the label: year.
I want to change the text color\text size\label margin or padding for the label: day of the week\day\month.
I want to change the text color of the cancel button (eg: CANCEL button - steel color. OK button - green color).

I want to leave one label a year, when choosing a date range.
I want to add a dash between the values of the selected dates.

@markRott
I override the styles. I replaced layout, with the same names as in the library, and set GONE visibility to reset button.
Also in date_picker_header.xml, the ll_header_date_range_cont container added a dash between the TextView.


Order of chapters wrong when received through sync

Steps to reproduce
Precondition: Device A: Has new chapters not on Device B

Device A synchronizes
Device B synchronizes
View entry with new chapters received through sync (not standard update)

Expected behavior
Chapters are in correct order.
Actual behavior
They get mixed in with the latest chapter usually ending up at the next one.
Crash logs
No response
TachiyomiSY version
r574
Android version
Android 15 (OxygenOS 15.0)
Device
OnePlus Pad 2
Other details
Edit: I'm using SyncYomi self-hosted (forgot to also note this down, but I also had this issue on Google Drive before migrating)
Paste from the settings:
App version: 1.11.0 (standard, 26cfb4811, 71, 2024-11-08T03:25:38Z)
Preview build: 574
Android version: 15 (SDK 35; build OPD2403_<IP_ADDRESS>(EX01))
Device brand: OnePlus
Device manufacturer: OnePlus
Device name: OP5DAAL1 (OPD2403EEA)
Device model: OPD2403
WebView: Android System WebView 131.0.6778.39
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 1.11.0.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

I see 7f37989 will fix this, but that commit seems to only affect the Google Drive-Version(?), I'm currently using the SyncYomi-provider (should have mentioned this in the issue honestly; will make an edit). Will this also fix the issue there?
For more context: I originally had sync running with Google Drive (bug also occured here) but switched to SyncYomi for better performance.

I see 7f37989 will fix this, but that commit seems to only affect the Google Drive-Version(?), I'm currently using the SyncYomi-provider (should have mentioned this in the issue honestly; will make an edit). Will this also fix the issue there?
For more context: I originally had sync running with Google Drive (bug also occured here) but switched to SyncYomi for better performance.

No that commit has nothing to do with this. It just so happen that the original commit message link to an issue on Mihon then got cherry pick on TachiyomiSY, and accidently has same issue number with this.

Ah ok, sorry then! That confused me. I read the message saying that is solves and closes this issue and got confused.


Can not get the real path but a sandbox cache path

Description of the bug
我的文件存在 Download 文件夹，路径如下：
storage/emulated/0/Download/MyFolder/myjson.json

但是这个插件读取到的路径却是在应用的  Application.persistentDataPath 路径下的 cache 文件夹下，路径如下
/storage/emulated/0/Android/data/com.<app id>/cache/cover.png

请问这是预期和合理的吗？
如果不是预期的，怎么获得真实的路径呢？
我看了 Readme，但是不知道你描述的问题是不是我这个问题。
Platform specs
Please provide the following info if this is a Unity 3D repository.

Unity version: e.g. 2021.3.1f1
Platform: Android
Device: Oppo K10 5G
How did you download the plugin: GitHub repo not from release tab

Hi, that's the same limitation that's described in FAQ, unfortunately:

How can I fetch the path of the saved file or the original path of the picked file?

You can't. The abstraction layers used on each platform deliberately don't return raw file paths.

谢谢！


Number of columns to display in swipe mode is miscalculated

Hello,
I've hit an issue where if you have long numbers or words the number of columns tablesaw believes it can show is miscalculated resulting in it thinking it can show too many and therefore resulting in the content overlapping:

I've created a JsFiddle to illustrate: https://jsfiddle.net/v9of0aq4/2/
The only JS is tablesaw.js and tablesaw.init.js. The only CSS is tablesaw.css. The HTML is just a simple table.
This only seems to be an issue once you "swiped", i.e. when it's applied "table-layout: fixed;" to the table at which point cell content width goes out the window.

same issue, no idea how to fix it ?

Why not to use text-overflow: ellipsis; or word-wrap to avoid long numbers/words. No?

Thanks for the response CCvinc, that's not a workable option for us at the moment. Truncating long numbers makes them somewhat meaningless and wrapping them makes it 2 different numbers.
In the above screen shot it would be ideal if Tablesaw only showed 3 columns.

I did create a local test case with a few new changes in the past week or so and couldn’t reproduce with your markup. There were some calculation changes that went in, so hopefully something improved here.
@Dan-Ashdown-FFT Can you retest with the new dist files?

Thanks @zachleat, I've updated the JS Fiddle to use the latest JS and CSS from the master branch but it has the same issue I'm afraid: https://jsfiddle.net/v9of0aq4/4/

Hmmmmmm, I still don’t see the issue on your jsfiddle. Do you have any additional info on your local environment? Browser/OS?
Is it possible to record a little screencast of what you’re doing?

I only occurs when you swipe:

Woo! There it is. Thanks, investigating.

Thanks for sticking with me on this one.
Tablesaw actually used table-layout: fixed to preserve the widths of the persistent columns while swiping (those using data-tablesaw-priority="persist). But in this case, it didn’t need table-layout: fixed at all because there were no persistent columns. Look for this fix in (the properly released) beta4.


Add zone support for Daikin Airbase

Home Assistant release with the issue:

Last working Home Assistant release (if known):
Hass 0.90 does not have support. Conversation here:
https://community.home-assistant.io/t/support-for-daikin-airbase-units/102622/26
I spoke to Fredrike on discord and I tested his code that is in dev against my unit. All works well. We are looking at adding zone support as per this post https://whrl.pl/RfiF8K.
Operating environment (Hass.io/Docker/Windows/etc.):
hassbian, etc
Component/platform:
https://www.home-assistant.io/components/daikin/
Description of problem:
Add zone support, as per the whirlpool thread I have confirmed that the commands work.
$ curl "http://<IP_ADDRESS>/skyfi/aircon/get_zone_setting"
ret=OK,zone_name=%4d%61%73%74%65%72%3b%4b%69%74%63%68%65%6e%3b%48%61%75%6e%74%65%64%3b%4f%66%66%69%63%65%3b%47%75%65%73%74%3b%4c%6f%75%6e%67%65%3b%4e%75%72%73%65%72%79%3b%20%20%20%20%20%20%20%5a%6f%6e%65%38%2c,zone_onoff=0%3b0%3b0%3b0%3b0%3b1%3b1%3b0

Now setting the zone is a little tricky,
curl 'http://<IP_ADDRESS>/skyfi/aircon/set_zone_setting?|pw=&zone_name=%4d%61%73%74%65%72%3b%4b%69%74%63%68%65%6e%3b%48%61%75%6e%74%65%64%3b%4f%66%66%69%63%65%3b%47%75%65%73%74%3b%4c%6f%75%6e%67%65%3b%4e%75%72%73%65%72%79%3b%20%20%20%20%20%20%20%5a%6f%6e%65%38%2c&zone_onoff=%31%3b%30%3b%30%3b%30%3b%30%3b%31%3b%31%3b%30'

Here is a break down of hte payload
"zone_name=&zone_onoff=<url encoded list of zones 0 or 1>"
I did try without encoding, encoding everything but this combination seems to be the only one that works.

@fredrike

The idea is to implement each zone as a separate switch.

I'll start working on this once #22382 have been merged.

We are not asking to create an issue in order to create a pull request.
No need to create this next time.


Compatibility with jRuby

I'm not sure why when I require resque-status in my sinatra app I get this error:
when running COUNT=2 VERBOSE=true QUEUE=* rake resque:workers --trace for example;
JRuby limited openssl loaded. http://jruby.org/openssl
gem install jruby-openssl for full support.
MongoDB logging. Please note that logging negatively impacts performance and should be disabled for high-performance production apps.
 They recommended trying a more recent version. It looks like you're using rvm which has the latest version, JRuby 1.6.5 available for installation.  I primarily recommend this because 1.6.5 has many bug fixes in it.

Ok, so i did a bit of digging and I think I figured this out.  resque-status has a dependency on uuid.  uuid has a dep on macaddr, which has a dep on systemu.   systemu contains a jruby specific block that uses the jruby import statement.  The jruby import clashes with the rake import.  I think the jruby community advocates moving to the java_import statement instead to deal with issues like this but the import is still left in for backward compatibility.
Anyway.  I made the mod to a fork of systemu in my github account and started using that for a project that I have that uses resque-status and I can now run tests under jruby without the typical cant convert Class to String explosion going on.   I have a pull req into the owner of systemu so hopefully it will make it in there sometime in the future.

Since this seems to be a downstream problem with JRuby/Systemu/uuid closing this ticket.


Setup google/gts linter.

Types of changes

[x] Enhancement (project structure, spelling, grammar, formatting)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

A description of the changes proposed in the Pull Request

Setup google/gts, fixpack libs.
Applied linter to whole project.
Added pull request template.
Mentioned engine in package.json file.

Thanks @narekhovhannisyan looks good to me. Is the plan to run the linter against a PR and report if it doesn't match, or should we just have a good practice of running the linter before checkin?

Since remembering and linting code locally is depending on programmer, it's better to check it in CI/CD for being sure that everything is ok on merge.

#77


ionic3.x  build apk is not running

I useing ionic3.x
use "ionic build android"  command , Obtain apk is not running
error:

I tryed set loadUrlTimeoutValue  ， but not success

@xswolf add in config.xml the line:
<platform name="android">
        <preference name="loadUrlTimeoutValue" value="700000" />
</platform>

Hello! Thank you for opening an issue with us!
This is not an issue with the Ionic Framework. It might be an issue that is better logged over in the https://github.com/ionic-team/ionic-app-scripts repo. If you log one there, please be sure to fill out the issue template.
This may also be best handled via community support. It is likely that someone else has run into this issue before. In that case, I urge that you ask this question on our forum or on our slack channel.
Thank you for using Ionic


Consider impact of container injection on flex/grid styles

If the parent container sets flex / grid styles, inserting another element between the parent and rehydrated component may cause issues.
May be an edge case. Possible solution may be to allow for custom containers.

we no longer wrap components in a new element. Is this still an issue @chrisvxd ?


Request to expand DSC Log Resource to allow ship logs

The DSC Log Resource is a powerful tool in providing rich feedback from within the configuration process.  However, this may not scale very well since the logs could potentially be spread across multiple DSC Servers or even LCM.  I am familiar with gathering logs from Windows Event Log using NXLOG however we would have to install and configure such a tool using DSC before it would be of any use...
If you can support hooking into this log pipeline and direct this data elsewhere that would be great, but it is not clear in the documentation.  Perhaps there is a way to leverage the 'DependsOn' property to pass configuration to Log Resource.  Here is a fake example:
Log LogglyExample
{
    Message = "This message will be piped out to a configurable Loggly Resource for processing."
    DependsOn = "[ResourceType]myLoggly"
}

The end goal would be to send DSC logs from the LCM's and Push/Pull servers into a centralized log aggregation system like ELK Stack or Loggly which can easily consume logs in JSON format and have powerful dashboarding tools.
That just might save us all a little time...

image from an article

@mikehumphrey There is a DSC reporting feature that you can use to monitor changes on multiple nodes. Currently DSC reports any SET operations carried out by LCM on all the nodes. see the WMF 5 release note (http://blogs.msdn.com/b/powershell/archive/2015/08/31/windows-management-framework-5-0-production-preview-is-now-available.aspx) and associated notes. To see if this feature meets your need.

After looking into the WMF 5.0 Production Preview with the new DSC Reporting feature I have arrived at the following observations after a few hours of monkey hand flapping on my keyboard so I may be way off here...
Configuring the LCM is very straight forward and the sample below demonstrates sending the message stream every 30 minutes to a host running DSC Serveries. Each message with include a timestamp and the ConfigurationID which in this case would be the LCM GUID.
Settings
    {
        ConfigurationID                = "$guid"
        RefreshFrequencyMins           = 30
        RefreshMode                    = "PUSH"
        ConfigurationModeFrequencyMins = 15
        AllowModuleOverwrite           = $true
    }

Then the ReportServerWeb config shown below demonstrates that there is little or no ability to control the output format or severity of the messages.
ReportServerWeb ReportManager
    {
        ServerUrL                = "http://localhost:8080/PSDSCPullServer/PSDSCPullserver.svc"
        AllowUnsecureConnection  = $true
    }

The biggest challenge with this workflow would be attempting to automate the processing of querying the host running the ReportServerWeb, normalize and transform these messages into a standardized format and then forwarding it onto your log aggregation framework.  This may require message caching  or load balancing depending on the system size and needs.
My Opinion:  It would be a huge step forward and makes a ton of sense to at least support shipping these to the Azure Event Hub which can be used as a message bus and forwarder for any log aggregation system.

@mikehumphrey today both Log resource and LCM logs locally, which would mean the best approach would be to use a tool that can be configured to know how to aggregate the logs from the DSC nodes.
If the Log resource would benefit from adding "log shipping" functionality, then I suggest adding a new resource to either the resource module PSDscResources or xComputerManagement (soon to be ComputerManagementDsc), not sure which one is the better one.
@mgreenegit improved log management for the LCM, is that something that can be taken in consideration going forward?


More information about which branch and commit a Release came from

Describe the solution you'd like
On the "Distribution / Releases / Individual Relase info page" it would be very handy to see exactly from which branch and commit the release was build and distributed from.
At the moment the Release info only shows an MD5 checksum.
I know that technically you can do a release by uploading a binary, but our workflow is to always do a release by clicking the Distribute button after a branch was built.
Describe alternatives you've considered
N/A
Additional context
N/A

Thanks for the feedback. Can you share exactly what you would like to see in the details?

@botatoes When I view a release by visiting install.appcenter.ms I can see the branch the build came from as well as the git commit hash along with the git commit message.
However as an administrator on the desktop browser (ie. appcenter.ms) when I view releases, none of the information is shown to me, only some MD5 checksum (which I guess is the md5 of the binary).
So for example, lets say I build 5 times from the same branch, but different commits.
As an Admin I have no way to verify which of the builds I want to keep around for a bit or to distribute them even further.

Got it! Thanks for that :)
I'll keep note of this and share the feedback with our design team. We are currently working on merging the two portals for a better tester experience. I believe we should be able to add this in as well.


Reskin

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@frannkenstein you can add clsx library here as well, will help us to maintain class names


[PLC] [Test] Explicit errors in 'TypeEvalCheck' tests

@reactormonk stumbled upon a UX bug where hedgehog won't print an exception that comes from the CEK machine. I spent a couple of hours and was unable to understand why (it seems to print exceptions coming from the CK machine just well), so I just made errors explicit.

I'll merge this, because it's minor and blocking me. Do feel free to leave comments, though, I'll address them separately.


Bump dcos-ui package for 1.8.8

High level description including:

Fixes scrollbar bug in Universe page
Minor fixes on Jobs create form

Issues
DCOS-11781
DCOS-1688
DCOS-11482
DCOS-11887
DCOS-9310
DCOS-11599
...
Checklist

[ ] Included a test which will fail if code is reverted but test is not
[ ] Followed relevant code rules Rules for Packages and Systemd

If this is a component/package update, include

[x] Change Log from last: link
[x] Test Results: link
[ ] Code Coverage:

Please rebase now that the CI is green again.
Also, I can't understand how https://mesosphere.atlassian.net/browse/DCOS-1688 has anything to do with this PR. Maybe you linked the wrong JIRA?

@rcorral Could you also get a couple of reviews on this SHA bump, verifying e.g. that the changelog includes all the right/expected 1.8.x changes and nothing unexpected?

@adam-mesos unsure how that JIRA snuck in. Thanks for pointing it out. I've removed it from the list.


README.md mentions Azure in multiple places

Hey Niklas,
Just to make everything consistent, you might want to do a string replace for Azure in the README.md ;)

Thought I had already done that 😆


Let people change their email address

@AlbertoCasasOrtiz people currently need to ask us to change their email address, could we allow them to change that through their profile? Thanks.

Sure, I think that is a good idea.
Is this a priority I should work during the current spring, or is it something we could add to the next one?

Let's add to next sprint, thanks.


LookupTable implementation

I was trying to implement the LookupTable. However the output does not match that from the original torch model. I used the nn.Embedding module and copied the weight tensor from the torch LookupTable. What could be wrong here?
Additional condition in lua_recursive_model
elif name == 'LookupTable':
            n1 = Lambda(lambda x: x.view(1,-1) if 1==len(x.size()) else x )
            n2 = nn.Embedding(m.weight.size(0),m.weight.size(1))
            n2.weight.data.copy_(m.weight)
            n = nn.Sequential(n1,n2)
            add_submodule(seq,n)

Additional condition in lua_recursive_source
elif name == 'LookupTable':
            s1 = 'Lambda(lambda x: x.view(1,-1) if 1==len(x.size()) else x )'
            s2 = 'nn.Embedding({},{})'.format(m.weight.size(0),m.weight.size(1))
            s += ['nn.Sequential({},{}),#LookupTable'.format(s1,s2)]

Have you  solved that? I have the problem of LookupTable when transfer the lua/torch code to pytorch code. @YZHANGFPE


Option to disable PLV8

If used against a Postgres installation where PLV8 can not be installed, any patches generated for migrating the db include the mt_transform_patch_doc function which requires the PLV8 language.
The function is preceeded with a comment (in the patch file) like so...
-- proposal.mt_transform_patch_doc Diff

CREATE OR REPLACE FUNCTION proposal.mt_transform_patch_doc(doc JSONB, patch JSONB) RETURNS JSONB AS $$

  var module = {export: {}};

  'use strict';

function findDeep(doc, parts){
    var element = doc;

---

Also it's not entirely obvious what parts of Marten will not work without PLV8 support (without consulting the docs looking for mentions).
Would it be possible to have an option to completely disable PLV8 usage which would omit any PLV8 functions from being included in migration patches and also disable any features dependent on PLV8?

I'm curious what environment you're using that cannot have PLV8 installed. I'm happy to help with that where I can.

@JerrySievert Azure's new Postgresql support is the obvious outlier, but I know that's supposed to be supported later.

Tasking:

[ ] StoreOptions.PLV8Enabled
[ ] IFeatureSchema.RequiresPLV8
[ ] Filter out PLV8 dependent features in the DDL generation when PLV8 is disabled
[ ] Throw an exception if the user tries to use a feature that requires PLV8 when it is disabled

The infrastructure where I currently work is all self hosted, so it's
purely a decision by our own infrastructure team who do not wish to
enable/support it...
That said, I'm about to leave for a company that uses azure so may need to
use it their next...
On Tue, 30 May 2017, 16:27 Jeremy D. Miller<EMAIL_ADDRESS>wrote:

@JerrySievert https://github.com/jerrysievert Azure's new Postgresql
support is the obvious outlier, but I know that's supposed to be supported
later.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JasperFx/marten/issues/706#issuecomment-304914988,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGRg2Z6Vrcn_OqKyMedqFQD81NF9m5Iks5r_DVMgaJpZM4MibcF
.


Bump atoms

Please check if the PR fulfills these requirements

[x] I made sure that my code builds (VisualStudio & cake script: build.ps1)
[x] I merged the master into this branch before pushing
[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

closes #107
What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications
Other information

obsolete


Fixes #39: http-collector non-blocking collect

http.collector.Collect was blocking, thus interfering with application
performance when zipkin is slow, not responding or down. The collect
function could take up to c.client.Timeout.
This fix makes the Collect function asynchronous, sending all the
spans in the batch, and remove them from the batch once succeeds.
Add some tests to verify the batching and timouting issues.

@posener can you please add a retry limit to the logic. currently it will infinitely retry to send spans.
I also see this as a temporary solution as I would like to add some more advanced rate limiting and span drop off logic (similar to Finagle's RetryBudget https://github.com/twitter/finagle/blob/develop/finagle-core/src/main/scala/com/twitter/finagle/service/RetryBudget.scala)

@basvanbeek , what do you mean limiting the retry?
Isn't it good that it will infinitely try to send spans?
It is a collector, once the upstream service is up, it should send the spans, no?
As far as I understand, in the previous implementation it also try to send forever.
Thanks for the feedback,
Eyal

Not really. I see tracing as a best effort and not a guaranteed service. Hence infinite retry and storing on hold is not what I'm looking for. Most tracing data becomes irrelevant when time moves on anyway.
i will take another look when I have more time (hopefully next week)

With some fixes and refactoring I'm ok with this change for now. It is still not what I envision but it is good enough of an improvement to merge.
I have done the fixes and refactoring on top of this PR in PR #44


Add task debug info in job detail page [webportal]

Coverage remained the same at 34.684% when pulling 7f204d6b1b0092318a5cb0a8522cc33ecc872e85 on mintao/webportal-debuginfo into 2950a8d1b4c123e361e552e00501991f9dc2778e on master.

    minWidth: 300,

Why not set all minWidth = 0, to save col space?

Refers to: src/webportal/src/app/job/job-view/fabric/job-detail/components/task-role-container-list.jsx:650 in 7f204d6. [](commit_id = 7f204d6b1b0092318a5cb0a8522cc33ecc872e85, deletion_comment = False)

    minWidth: 300,

Why not set all minWidth = 0, to save col space?
Refers to: src/webportal/src/app/job/job-view/fabric/job-detail/components/task-role-container-list.jsx:650 in 7f204d6. [](commit_id = 7f204d6, deletion_comment = False)

minWidth = 0 works like auto and will take more space than expected

    minWidth: 300,

Why not set all minWidth = 0, to save col space?
Refers to: src/webportal/src/app/job/job-view/fabric/job-detail/components/task-role-container-list.jsx:650 in 7f204d6. [](commit_id = 7f204d6, deletion_comment = False)

minWidth = 0 works like auto and will take more space than expected

How about minWidth = 1?

How about minWidth = 1?

minWidth=1 will make the original column too tight that user could not see the title clearly.

could you rename "Debug Info" to something else? For example, "Diagnosis Information"?

Move Debug Info  button to job level?

updated：


Write a Kotlin program to convert hours to weeks

Description
Write a Kotlin program to convert hours to weeks
1 week = 7 days = 168 hours
Input  : 840
Output : 5

How to contribute

Save the solution in ConvertHoursToWeeks.kt file
Add ConvertHoursToWeeks.kt file in convert-hours-to-weeks folder

!assign


fix shap import error on matplotlib with missing backend

fix shap import error on matplotlib with missing backend
to test locally on a non-macos machine (setting to missing macos backend will then force matplotlib to throw error on import):
(sh) PS C:\shap> python

import matplotlib
matplotlib.use('MacOSX')
import shap

Good catch thanks!


[WIP] Bump to kube 1.20.0 beta.2

/cc @soltysh

Could https://github.com/openshift/api/commits/prebase-1.20.0-beta.2 could be sync'ed with latest master? We're working on PRs for cluster-kube-controller-manager-operator and cluster-kube-scheduler-operator where we need https://github.com/openshift/api/commit/f45c59655f12fe36eecb517a7631aca06341ce8b
master branch of these 2 modules has already switched to 1.20.0-beta.2 and points at prebase-1.20.0-beta.2

@cfergeau this PR isn't connected to prebase-1.20.0-beta.2 branch but feel free to reach out on slack to @soltysh who created the branch


cargo-build-sbf: Use metadata.solana.tools-version in Cargo.toml

Problem
It's possible to specify the version of the platform-tools version using
the --tools-version, but most people aren't aware of the different
versions of the compiler, or that they can use the flag.
Summary of changes
Allow cargo-build-sbf to read from the metadata section of a package
or workspace Cargo.toml. The concept is similar to
rust-toolchain.toml, where cargo finds the right version of Rust. For
cargo-build-sbf, it can read:
[package.metadata.solana]
tools-version = "v1.43"

Or
[workspace.metadata.solana]
tools-version = "v1.43"

To go with this change, since I often forget leading "v" in the version
string, the version parsing now allows for omitting the leading "v", so
you can specify --tools-version 1.43.
As follow-up work, I would like to make cargo build-sbf --version show
the appropriate version based on the Cargo.toml / --tools-version arg,
same as cargo does.
cc @lorisleiva and @febo

The PR looks good. Should we have a test for this new behavior?

The PR looks good. Should we have a test for this new behavior?

Sure! I added a test for the package version and the workspace version, let me know how it looks.


how to use Dax with dynamo db in android

how can I utilize Dax performance with dynamodb in android any sample code in android is helpful

THank you @Pd51 for reporting to us. Can you elaborate on the question with more details?

i want to use dax for my application for micro seconds latency but i didn't find any samples on how to use dax in android like gradle library or any sample code any sample code in android on how to use dax with dynamodb in android is helpful thanks your for reply.

No, you cannot use DAX from android.  Your DAX cluster is only accessible to EC2 instances running in a VPC.  Realistically the only way you can get microsecond latency on android is if you are working with a local datastore, anything over the network you are looking at milliseconds.


Support list formats (lines, JSON). Closes #48.

Closes #48.

The tests seem to be failing on Travis CI, but they are passing for me locally, and seem not to be due to any of my changes in this PR, as far as I can tell.

By the way, this can be accessed via:

https://www.gitignore.io/api/list?format=lines
https://www.gitignore.io/api/list?format=json

Or in the CLI e.g.:

gi list?format=json
gi list?format=lines


QUESTION: Is local process with Kubernetes complimentary to Dev Spaces or a replacement?

I am sure this information must exist somewhere, but I am unable to find any specific guidance. Is the new Local Process with Kubernetes feature designed to complement Azure Dev Spaces (e.g. both should be used together) or is it designed as the next generation replacement for Azure Dev Spaces?
There seems to be little material describing which of the two options should be used, although I see in the Azure Portal that the Local Process with Kubernetes Feature is the default offering now.

Hi @clawrenceks
LPK is a simpler solution to many of the development scenarios that Dev Spaces currently fulfils.  We're working hard on new features for LPK, and hopefully for many it will be suitable, easier tooling for their iterative development needs.
Once we've gathered more feedback form customers about LPK and released some of the features we're working on, we'll be in a good place to add to the documentation about which tooling is better for different scenarios.

@Gordonby Not sure if this is the correct venue, but until LPK supports Linux, is it possible to re-enable AZDS Connect menu options in the VSCode extension?
We're using AZDS within Linux dev containers, and the lack of ability in VSCode to pin extension versions means we're SOL for support at the moment.

Hi @Cpcrook, i think @greenie-msft has been emailing you about this point.
Can you let me know the disto/version of linux you're using?

Hi @Gordonby -- our dev containers are running on a Docker image based on the dotnetcore 3.1 sdk image here which is Debian 10.  We add Azure CLI to that, and run an automatic task on folder open to login to AKS, install kubectl, setup dev spaces.
We were relying on the "clone" service redirection story previously.  I think we have a workaround for now (as long as the CLI continues to support the functionality in the older extension version).  We've reverted back to the Azure Dev Spaces extension version 2.0.220200514 using the workaround pertaining to broken extension downgrades noted here.  Seems to work for now with:
`
azds --version
Azure Dev Spaces CLI
1.0.20200707.1
API v3.2
`
Just a bit inconvenient as the extension downgrade dance has to be done any time a dev container is rebuilt.

@clawrenceks according to the latest doc update, it is no longer possible to use Local Process together with Dev Spaces:

You can't use Local Process with Kubernetes on a cluster with Azure Dev Spaces enabled. If you would like to use Local Process with Kubernetes on a cluster with Azure Dev Spaces enabled, you must disable Azure Dev Spaces before connecting to your cluster.

@Gordonby is there any plans to re-enable Local Process debugging for AZDS-enabled clusters? We are migrating to AKS / Dev Spaces from per-developer local docker installations, and shared base space + Local Process debugging is a primary usecase for us.

Hi @PashaPash,
At the moment, there is no plan to re-enable LPK routing on a Dev Spaces enabled AKS cluster.
Can you provide additional details as to why Local Process with Kubernetes and the isolation mode that comes with it does not fulfill your development requirements? Similarly to Dev Spaces routing, the isolation mode in LPK allows developers to work in a shared environment.

@greenie-msft we have 30+ services project, the plan was to

host latest (master) version of all services in shared space
allow QA to upload PR-based service builds to their child spaces (so they will test on all masters + one service PR, similar to Github Actions case from the documentation)
allow developers to work on same shared space + LPK for the service they need to develop / debug locally

Without LPK routing on AKS we have to keep to separate clusters for QA (with Dev Spaces) and for Dev (LPK).
Not a blocker, but adds some overhead - we have to keep shared space up to date on both clusters, and we also have to pay for two clusters.

Hi @PashaPash,
Thank you for the additional details.
I should clarify my earlier comment - I'm referring to our new routing capability when I say "isolation mode" in LPK. Here is a doc explaining this capability: https://aka.ms/lpk-isolation
Does this help meet your requirements?
Please let me know if you have any other questions.

Hi @greenie-msft,
"isolation mode" in LPK does not cover base usecase for QA. QA does not have local version, their deployments should be fully hosted on aks.

QA needs fully hosted environment with ability to override a single deployment via CD (exactly as described at https://docs.microsoft.com/en-us/azure/dev-spaces/how-to/github-actions). They don't have local processes, don't have local dev tools installed, no source code checked out locally. They need an ability to override a single aks deployment and host an overridden service / pod on aks. That is exactly what DevSpaces allows to do, and LPK does not.
Dev needs the same hosted environment, but with ability to isolate and route a single service traffic to their own PC. LPK does that, but DevSpaces does not allow that anymore.

Cluster should be either in LPK mode (no hosted overriden containers, not suitable for QA), or in DevSpaces mode (no local debugging, not suitable for Dev).
I understand that local process debugging in DevSpace was a preview, so up to your team to drop it without notice. Just curious what was the reason to drop a really developers-oriented feature out of DevSpaces.

@PashaPash the use case you described sounds like what review apps are designed to accomplish -- they defer and route traffic from unchanged services to the parent space, but route traffic to a modified service to the updated deployment, allowing testing to proceed against the changed service(s) while still allowing those to interact with any unmodified services on which they depend.
You'd have CI/CD pipelines setup to deploy a review app to a new Kubernetes namespace (say, specific to a PR).  Traffic to services not modified as part of that PR would go to the parent namespace.

@Cpcrook yes, quite close to review apps. But we also need traffic flow back from the parent namespace to some modified service, depending on initial request url. DevSpaces seems to be a closest match.

Is review apps also available via github actions? (dev spaces supports this
QA/review functionality using github)
On Thu, Aug 6, 2020, 18:55 Pavel Pochobut<EMAIL_ADDRESS>wrote:

@Cpcrook https://github.com/Cpcrook yes, quite close to review apps.
But we also need traffic flow back from the parent namespace to some
modified service, depending on initial request url. DevSpaces seems to be a
closest match.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Azure/dev-spaces/issues/366#issuecomment-670050464,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADTBRJ3BIYRCE7WN5RK4VF3R7LN67ANCNFSM4OKXMXEQ
.

Hi @PashaPash,
Thank you for further clarifying your requirements.
The isolation mode in LPK takes advantage of our new routing capability. It is currently limited to the LPK experience, but we will soon support enabling routing independently. This will allow you to use routing for additional scenarios outside of the LPK workflow (e.g. GitHub Actions PR Flow).  We also plan to publish an improved PR Flow which will use our new routing implementation.
The combination of what I've described above will allow you to achieve the same value as our traditional Routing/PR Flow experiences. QA will be able to test code changes in the cluster outside of the developer experience.
I'll keep this thread live and provide an update as soon as we release and document these scenarios.
If you have any further questions, please feel free to reach out via email:
<EMAIL_ADDRESS>Thank you,
Nick


Which branch should we use for 8.x and PFSense 2.7.2?

I'm still successfully running 7.5.187 on PFSense 2.7.2 and would like to start helping w/ the testing around an 8.x variant. Which branch should we be using to help with this endeavor?
https://github.com/unofficial-unifi/unifi-pfsense/tree/tong2x-patch-5?

unable to install on 2.7.2
fetch -o - https://git.io/j7Jy | sh -s

                                                7663  B   10 MBps    00s

sh: mongod: not found
Mounting new filesystems... done.
Removing discontinued packages...
Usage: pkg lock [-lqy] [-a|[-Cgix] ]
pkg lock --has-locked-packages
pkg unlock [-lqy] [-a|[-Cgix] ]
For more information see 'pkg help lock'.
Usage: pkg delete [-DfnqRy] [-Cgix]  ...
pkg delete [-Dnqy] -a
For more information see 'pkg help delete'.
done.
Installing required packages...
packagesite.pkg                                       7316 kB 5575 kBps    02s
x packagesite.yaml.sig
x packagesite.yaml.pub
x packagesite.yaml
Package png-1.6.43 already installed.
Package brotli-1.1.0,1 already installed.
Package freetype2-2.13.2 already installed.
Package fontconfig-2.15.0_3,1 already installed.
Package alsa-lib-1.2.12 already installed.
Package mpdecimal-4.0.0 already installed.
Fetching : 100%    3 KiB   0.0kB/s    00:01
pkg: Impossible to get the value from Last-Modified HTTP header
pkg: archive_read_open_filename(/tmp/.XXXXX): Unrecognized archive format
Failed to install the following 1 package(s): https://pkg.freebsd.org/FreeBSD:14:amd64/latest/

most changes I am doing is just updating the firmware no major changes in code
hence it is not merge with master until reviewed


v1.0.1 Release

update release notes
cut v1.0.1
bump to v1.0.2-dev

LGTM but tests are angry, I think flake.

Changes LGTM, tests are angry

/lgtm


調預設語言

#70  #88

Coverage decreased (-44.8%) to 51.741% when pulling 9097fe8f49583febdef9b6476df388f11c32acd8 on 調預設語言 into f12e6c30ee8360a4cb10a12c591c8d47aaa77549 on master.

Coverage increased (+0.006%) to 96.519% when pulling 3b93a2dd1b64fa06263d0e1ef77fc23742c2fd88 on 調預設語言 into f12e6c30ee8360a4cb10a12c591c8d47aaa77549 on master.


iOS Navigation problem

Hello!
I'm testing the wip-2.0 version of bootstrap and first of all i have to say "thank you" for this awesome work. After we launched a bootstrap version, our website had an huge increment of views.
Unfortunally there still be a problem with the navbar. When an user zoom the page from an iOs 5 device, the topbar zoom and cover our page content. i don't know if you have understand, but hovewer it's not a small problem cause my website become very hard to surf.
I use really sample code, the one in "container-app" demo.
I alredy asked something similar months ago and Mark Otto told me that issue will be fixed in 2.0 version.
Maybe was alredy fixed, but i din't found a way to get it works normally.
Thanks
Matteo

Hi Matteo, if you haven't already done this, I'd suggest you try creating a minimal working example to make sure it is not just a site or implementation-specific issue. Failing this, please post a screenshot or link demonstrating this issue.

Hi. I took two screenshots.
In this one the page is normal ( no zoom ):
http://i40.tinypic.com/24618q9.jpg
But here, when i zoom, the menu is not zomming like the content and may cover the header.
http://i43.tinypic.com/1y3j4o.jpg
Consider that i used the twitter "container" example, in my project i have even more bar items.
You can test yourself zoomming from an iOs 5 device.
Thank you.
Matteo

Shouldn't be an issue anymore—we have a brand new responsive nav in place. If you still have problems, please open a new issue.
Thanks!


CUDA out of memory : Max memory and CPU running

Hi,
I want to run your code on my computer however it seems that I don't have enought VRAM on my GPU (running python reconstruct.py lord --pcl_type depth_pcl --exp_name fit_depth_pcl --seq_name 00134_longlong_twist_trial2_21).
How much ram is required to run the demo?
How to run the demo on my CPU?
Using --g "-1" doesn't seem to do anything (probably because torch is already initied at line os.environ['CUDA_VISIBLE_DEVICES'] = args.g)
I tried :

prefixing with CUDA_VISIBLE_DEVICES=-1 : CUDA_VISIBLE_DEVICES=-1 python reconstruct.py lord --pcl_type depth_pcl --exp_name fit_depth_pcl --seq_name 00134_longlong_twist_trial2_21
adding map_location=torch.device('cpu') inside  load_dict = torch.load( L32
commenting L89 os.environ['CUDA_VISIBLE_DEVICES'] = args.g
but it leads to

  File "/home/remmel/workspace/LoRD/lib/reconstructor.py", line 197, in optimize_latent_code
    self.c_m = torch.randn(self.n_parts, self.latent_size).type(torch.cuda.FloatTensor) * self.init_std
RuntimeError: No CUDA GPUs are available

Hi @remmel ,
Thanks for your interest in our work!
I tested the demo code on a single NVIDIA 2080Ti card with 11GB GPU memory. You can modify the value of self.num_optim_samples in L43 of reconstructor.py (it affects the number of points used in each optimization step) to reduce the memory cost.
You also can remove .type(torch.cuda.FloatTensor) (L197-198) for code initialization to run the demo on CPU. But this will lead to very slow running speed (40s per step).

Thanks, I'm able to go on


Vmware 4.0.0 publish

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@zhoxing-ms please review. This is the final PR for the vmware 4.0.0 release. Thank you for the help!

Vmware

It looks like it was not published to the index.json yet. #4136


typo in Class description of Log.java

Most of the methods in this class server only to map a method call in Log to its equivalent in LogNode.
IMO, server should actually be serve.

This sample has been deprecated/archived (check README for more information on newer samples related to this technology).
As recommended by GitHub, we are closing all issues and pull requests.


Add support for configuring workers

This chart currently installs a Prefect Agent. We need a way to configure it to instead start as a worker:
prefect worker start --pool {work_pool_name} --type kubernetes

Resolved by https://github.com/PrefectHQ/prefect-helm/pull/133 and #134


isAppInstalledAndroid() Always Returns False

Hello There,
Thanks for putting together this package.
I am having some issues using isAppInstalledAndroid() and isAppInstalled(); for some reason they both return false to me for any app that I look up. I've tried instagram and gmail (which I know 100% is installed on devices and emulators) and they both continuously return false for me.
Is there something I am doing wrong or missing?
I have installed the package, run react-native link react-native-check-app-installed, and used the following sample code:
AppInstalledChecker.isAppInstalledAndroid("com.instagram.android").then(
  isInstalled => {
    // isInstalled is true if the app is installed or false if not
    console.log("isInstalled " + isInstalled);
    }
);

Could you please let me know if I am not using the package properly?
Thanks

This was due to my own ignorance, please ignore....
was a late night.


Show Bootstrap Modal as "link"

Any possibility to show a bootstrap modal (containing data protection) as link for "more information"?

Hi you'd have to build this yourself, as we don't have this ability built in.


Add test for suggested @era values to schematron

Suggested values include ce and bce.

Tested. Looks good. Closing.


Fix broken parse_links unit tests

PR #2236 broke three unit tests by changing the expected type of the parse_links method. Previously it took a BeautifulSoup object but after that change expected a raw string or a RichText object. This PR fixes the unit tests in v1.tests.test_links to use that new behavior.
Changes

Fixes to v1.tests.test_links in how parse_links is called.

Testing

Run tox to verify that all unit tests pass.

Review

@kurtw @richaagarwal @Scotchester

Checklist

[X] Changes are limited to a single goal (no scope creep)
[X] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[X] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

Tests pass :+1:


How to prepare triple or negative doc for doc ranking problem?

A triple in doc ranking problem are (query, positive_doc, negative_doc)
If I already have query-positive_doc pairs data, how do I prepare the negative doc data?
Random is the baseline policy.
With human in loop, I can use BM25 for the candidate docs and then label each of them.
I prefer do it without human.
Thank you very much.

Random is the usual case though it will produce weak negative docs. If you already have the positive docs, you can use existing models to retrieve the docs not in the positive set as the negative doc.


Not working in Chrome.

Fails to load the component (to be embedded) due to Cross-Origin policy.

If the url violates cors then it won’t load the component. That would be working as designed

I was trying to load a file stored locally i.e trying to embed child.html into parent.html on parent load. Something similar to "components" in Angular.
The component embedding worked fine in firefox but failed in chrome due to CORS.

Check the last paragraph of the readme file. This is a known issue with local files and chrome.

I'm having a similar issue and I checked the readme but I'm not sure how to "add --allow-file-access-from-files to your Chrome runtime". Is the "Chrome runtime" referring to some local chrome file I need to modify? Is it an API call to chrome? And if it is an API call, how do I do that? I tried to google for some answers but I think I've just gotten more confused.


update mapping for azure-mgmt-edgegateway

Docs Build status updates of commit 0e33612:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch azure-mgmt-edgegateway has been deleted or has been force pushed: fatal: Couldn't find remote ref azure-mgmt-edgegateway

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Backward invocation inside ref.listen when updating provider ref is listening to

Describe the bug
When we listen for state.valueA and update state.valueB inside the listener we have a backward invocation:
flutter: Listen for 1 2022-10-10 14:32:16.491797
flutter: Listen for 2 2022-10-10 14:32:16.494572
flutter: Listen for 3 2022-10-10 14:32:16.494869
flutter: Listen for 4 2022-10-10 14:32:16.495141
flutter: Listen for 5 2022-10-10 14:32:16.495383
flutter: Listen for 5 2022-10-10 14:32:16.495852
flutter: Listen for 4 2022-10-10 14:32:16.496019
flutter: Listen for 3 2022-10-10 14:32:16.496196
flutter: Listen for 2 2022-10-10 14:32:16.496375
flutter: Listen for 1 2022-10-10 14:32:16.496551

Expected invocation:
flutter: Listen for 1 2022-10-10 14:32:57.941396
flutter: Listen for 1 2022-10-10 14:32:57.944069
flutter: Listen for 2 2022-10-10 14:32:57.944260
flutter: Listen for 2 2022-10-10 14:32:57.944516
flutter: Listen for 3 2022-10-10 14:32:57.944711
flutter: Listen for 3 2022-10-10 14:32:57.944885
flutter: Listen for 4 2022-10-10 14:32:57.945098
flutter: Listen for 4 2022-10-10 14:32:57.945297
flutter: Listen for 5 2022-10-10 14:32:57.945482
flutter: Listen for 5 2022-10-10 14:32:57.945666

To Reproduce
hooks_riverpod: 2.0.2
freezed: 2.1.0+1
import 'package:flutter/material.dart';
import 'package:freezed_annotation/freezed_annotation.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart';

part 'main.freezed.dart';

void main() {
  runApp(const ProviderScope(child: MyApp()));
}

class MyApp extends ConsumerWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context, WidgetRef ref) {
    return MaterialApp(
      home: Scaffold(
        body: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            Row(
              mainAxisAlignment: MainAxisAlignment.center,
              children: const [
                AnimatedText(index: 1),
                AnimatedText(index: 2),
                AnimatedText(index: 3),
                AnimatedText(index: 4),
                AnimatedText(index: 5),
              ],
            ),
            TextButton(
              child: const Text('Start'),
              onPressed: () {
                ref.read(textNotipod.notifier).plus();
              },
            ),
          ],
        ),
      ),
    );
  }
}

class AnimatedText extends ConsumerWidget {
  const AnimatedText({
    required this.index,
    super.key,
  });

  final int index;

  @override
  Widget build(BuildContext context, WidgetRef ref) {
    ref.listen(textNotipod.select((s) => s.plus), (prev, curr) {
      print('Listen for $index ${DateTime.now()}');

      ref.read(textNotipod.notifier).minus();

      print('Listen for $index ${DateTime.now()}');
    });

    return Text(
      index.toString(),
    );
  }
}

@freezed
class TextState with _$TextState {
  const factory TextState({
    required int minus,
    required int plus,
  }) = _TextState;
}

class TextNotifier extends StateNotifier<TextState> {
  TextNotifier() : super(const TextState(plus: 0, minus: 0));

  void plus() => state = state.copyWith(plus: state.plus + 1);
  void minus() => state = state.copyWith(minus: state.minus - 1);
}

final textNotipod = StateNotifierProvider<TextNotifier, TextState>(
  (ref) {
    return TextNotifier();
  },
);

That seems expected. Listeners are invoked synchronously on change.
Why should it print what you asked?

Why it shouldn't? You said yourself that they are synchronous, print is synchronous, and the update to the state is synchronous as well. From my understanding, the whole listener block should be completed before going to the next one.
We are subscribed for valueA, update valueB. Why the update of the state freezes the whole listener block execution?
If we change: void minus() => state = state.copyWith(minus: state.minus - 1);  to void minus() {} it will work as expected. Or let's imagine another situation, if we, for example, will update textNotipod2 inside  textNotipod listener instead of textNotipod it will work as expected as well (1,1,2,2..).
Am I missing something?

What you are missing is that the state = something call actually executes more code than just assigning that variable. It notifies any listeners which causes your listener to execute. (Basically a recursive function call).

From my understanding, the whole listener block should be completed before going to the next one.

You're notifying listeners within a listener. You did the equivalent of:
    ref.listen(textNotipod.select((s) => s.plus), (prev, curr) {
      print('Listen for $index ${DateTime.now()}');

      for (final listener in listeners) {
        listener(curr, curr - 1);
      }

      print('Listen for $index ${DateTime.now()}');
    });

So the current output is logical.

This is recursion in your example, in my example, there is no recursion, I have 5 widgets, and each one of them has 1 listener,
and I have 1 trigger:
 onPressed: () {
    ref.read(textNotipod.notifier).plus();
  },

plus() will trigger 1 call in each of 5 widgets, 5 calls total.
minus() inside a listener shouldn't do anything to the listener itself since the listener is listening for plus using select, the only thing it will do is update the minus in the state, which again won't do a thing since we are not listening for minus in this case.
So, I'm not notifying anyone by updating the state. I just update the state of the notifier, the provider will register the update and the listener will ignore this update since the listener is listening for a different field.

My bad, you're right, I got confused.
I'll look into it
An immediate theory I have is that it's an issue with select. I guess that when calling minus(), this flushes the listeners, and select has a new chance to trigger its listeners. So selectors that have yet to notify their listeners (because another index is still pending) have another chance to notify their listeners.
That's a funky edge-case.

But I don't think it was intended to be able to notify listeners within a listener.
I'm pretty sure I made the conscious decision to disable that
It's possible that a regression enabled this scenario.
I'll need to double check.

Thanks for your time and the example btw. These are pretty rare. I should've run it sooner

I don't think anything can be done here.
I don't think it's really a problem either. I would discourage modifying providers within listeners.
Pretty sure this wasn't allowed before but got enabled when I did performance optimization for listener notification.
So I'd lean toward "won't fix"

Seems to me that it can be a side effect of the bigger problem that we don't know about yet, usually it is always like that.
My problem can be fixed by allocating a separate provider. If we reference my example, then I need to create a separate provider for minus, and in the end, I will have 2 notifiers and providers. And in case I will want to use minus in the TextNotifer I just need to access it with StateNotifierProviderRef like ref.read(minusPod).
This means that the problem here is not about modifying providers inside the listener in general, this problem is about modifying specifically the provider I'm listening to which is a pretty common scenario after you introduced listenSelf, but I guess listenSelf is different in this case since this happens inside the body of provider, but still worth to check it out just in case.
Mentally as a riverpod user, having something like listenSelf passively saying to me that it's ok to do things like that. It's more a tip for current docs, maybe to emphasize this issue, like "hey, this is a little bit different".
When you are saying "I would discourage modifying providers within listeners" do you mean any provider or do you mean only the provider we are listening to? In any case, if we lean toward "won't fix" we need to have an Exception thrown when we try to update the provider inside the listener, either for all providers or just the one we listen to, it will depend on your answer. I would just throw for the one we listen to since there is no problem with updating other providers.
Without Exception, it's only a matter of time before another issue will be created. And by the way, this bug can be hard to spot in the app. And it can break your logic, when you need to do something sequentially, like animation in several different widgets that are invoked by the listener in a specific order.

Modifying any provider within any listener (including things like onDispose) is discouraged.
We could throw, yes. But that would be silently breaking some apps, and probably wouldn't catch all cases.

Can we mark it 3.0 then, and when 3.0 comes this will be added?


⚠ Bofrost.be has degraded performance

In aac3342, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1361 ms

Resolved: Bofrost.be performance has improved in d7571d9 after 6 minutes.


APK available?

Is the APK-file available anywhere?

I hope I can find the time today to create the APK and add it to the repo.

The apk is available under
https://github.com/jonasjuffinger/TimeLapse/blob/master/app/TimeLapse-release-0.3.apk
Have fun!


Duplicate Enum non selectable on load

The attached screenshot shows that once you have two enums in different types it becomes unavailable. As orgStatus is declared in the outer object - the inner object (organization) that contains the same enum is no longer available.

The following Jar was loaded in the UI (renamed to zip for upload) version 2.2.1
searchNniName-model.zip

Can you upload ADM file?

This would need to wait for #579

Duplicate of #255


Nominate 0xFelix for sig-compute approver

What this PR does
Nominating @0xFelix for SIG compute approver
Felix has been contributing to Kubevirt for more than 2 years, he is a very active member of the community contributing both with code and reviews.
He contributed  100+ PRs https://github.com/kubevirt/kubevirt/pulls?q=is%3Amerged+is%3Apr+author%3A0xFelix, his main contributions were in core KubeVirt, instance types and virtctl, he also helped the project making big strides in having more reliable and maintainable tests.
He reviewed ~ 350 PRs https://github.com/kubevirt/kubevirt/pulls?q=is%3Apr+commenter%3A0xFelix+is%3Aclosed+-author%3A0xFelix.
I think @0xFelix deserves to be a sig-compute approvers given the number and the importance of his contributions, also this will help the project grow as Felix does a great job in reviewing a lot of PRs and by having him as an approver will enable us to review and merge code faster.

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

@0xFelix Thank you for volunteering!
/approve
/hold

@0xFelix has been a constant source of detailed reviews for the majority of my time on the project and his initiative around improving some of the more awkward parts of the codebase (yeah I'm looking at you virtctl) is to be commended.
While I'm not a top level sig-compute approver I wholeheartedly agree with this change.
/lgtm

/lgtm

Thank you @0xFelix and good luck!
/lgtm

Good Luck!
/lgtm

/lgtm

/unhold
I've rebased it and I also think we can unhold.

/lgtm


jspm / systemjs is failing to load package.

By returning the factory method it makes systemjs modules happy :)

This works in development mode, but creating a self extracting bundle still fails to load. :(


884 disallow assigning dna complements when there are unpaired deletionsinsertions

Description
Prevents assigning DNA complements when there is an unpaired insertion or deletion.
Related Issue
#884
Motivation and Context
The error given before this fix was confusing. This more directly indicates the problem.

Accidently merging to main instead of dev, closing


variable_names_changes

As a result of the updated surface runoff schemes (PR #112), certain surface runoff terminologies, such as direct_runoff, required revision. This PR adjusted several variable names to more suitable names. No changes to the functionality of the model.
Additions

Updated some variables names

Removals

Removed a few comments that were not needed

Changes

changed direct_runoff_parameters_structure to infiltraton_excess_parameters_structure
changed surface_partitioning_scheme to surface_water_partitioning_scheme
changed flux_output_direct_runoff to flux_infiltration_excess
changed surface_runoff to direct_runoff
changed direct_output_runoff_m to infiltration_excess_m
changed BMI name: DIRECT_RUNOFF to INFILTRATION_EXCESS
changed BMI name: SURFACE_RUNOFF to DIRECT_RUNOFF

Testing

Results with and without changes are identical

Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[x] Passes all existing automated tests
[x] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[x] Reviewers requested with the Reviewers tool :arrow_right:

Changes in BMI variable names are presumably going to require corresponding changes in Realization Config files, to map them appropriately between coupled models. This presumably affects both the documentation and examples @stcui007 is developing, and the config generation in DMOD that I think @aaraney maintains.

I'm curious about the change of surface_runoff (a very common term in
hydrology) to direct_runoff (one I haven't heard before). Can you comment
on the issue with 'surface_runoff'?
On Wed, May 1, 2024 at 12:49 PM Phil Miller - NOAA @.***>
wrote:

Changes in BMI variable names are presumably going to require
corresponding changes in Realization Config files, to map them
appropriately between coupled models. This presumably affects both the
documentation and examples @stcui007 https://github.com/stcui007 is
developing, and the config generation in DMOD that I think @aaraney
https://github.com/aaraney maintains.
—
Reply to this email directly, view it on GitHub
https://github.com/NOAA-OWP/cfe/pull/116#issuecomment-2088915329, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIKAROGFDOWLGUCD3WT3GDZAE2NHAVCNFSM6AAAAABHCIARRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYHEYTKMZSHE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Changes in BMI variable names are presumably going to require corresponding changes in Realization Config files, to map them appropriately between coupled models. This presumably affects both the documentation and examples @stcui007 is developing, and the config generation in DMOD that I think @aaraney maintains.

@PhilMiller that's a good point, however, the BMI variable names change is to the output variables (here), so hopefully it will not impact realization files and also coupling between models.
From the outputs perspective, prior to April 18th, those who were outputting 'GIUH_RUNOFF' will need to output DIRECT_RUNOFF and DIRECT_RUNOFF needs to be INFILTRATION_EXCESS. The name SURFACE_RUNOFF was introduced in the last PR, which is reverted here to DIRECT_RUNOFF. I will add this to the PR description for clarification.

@PhilMiller that's a good point, all models taking DIRECT_RUNOFF from CFE as an input should continue to do so, and I don't think INFILTRATION_EXCESS is ever used by other models, so hopefully it will not impact realization files and also coupling between models. Please let me know if I am missing something here

I think the main concern, @ajkhattak is changing surface_partitioning_scheme to surface_water_partitioning_scheme in cfe's configuration file. This is not a backwards compatible change, so any existing cfe "init config" files would no longer work. Is there a need to change the init config variable name?

@PhilMiller that's a good point, all models taking DIRECT_RUNOFF from CFE as an input should continue to do so, and I don't think INFILTRATION_EXCESS is ever used by other models, so hopefully it will not impact realization files and also coupling between models. Please let me know if I am missing something here

I think the main concern, @ajkhattak is changing surface_partitioning_scheme to surface_water_partitioning_scheme in cfe's configuration file. This is not a backwards compatible change, so any existing cfe "init config" files would no longer work (@stcui007's point). Is there a need to change the init config variable name?

@aaraney surface_water_partitioning_scheme is a more descriptive and appropriate name because these schemes does partition surface water (precipitation or snowmelt water) into infiltration and runoff. That said, we can keep the old name surface_partitioning_name for a while, which will be deprecated in the future. does it make sense?

@aaraney @stcui007, according to @fred-ogden the revised CFE (including all these changes) is cfe3.0 and is conceptually more "equivalent" to the existing NWM. The cfe3.0 requires new inputs from the config file N_nash_surface, K_nash_surface, and nash_storage_surface, thus anyone running cfe3.0 will need to regenerate their config files irrespective of the other changes (surface_water_partitioning_scheme or surface_partitioning_scheme) 😊

@aaraney surface_water_partitioning_scheme is a more descriptive and appropriate name because these schemes does partition surface water (precipitation or snowmelt water) into infiltration and runoff. That said, we can keep the old name surface_partitioning_name for a while, which will be deprecated in the future. does it make sense?

I didn't speculate, but I figured that was the case! I think a deprecation path is best if we need to change the name, although I wish we could just avoid it all together. I suggest that we make it possible to use surface_partitioning_name but output a warning if it is present. Ideally we would provide a way to upgrade existing configs to the "new" naming convention as well. Perhaps we could create a gh issue that showcases how to upgrade using something like sed or awk and we output a link to the gh issue in the warning. This was there is room for conversation and others to link back to this breaking change. @PhilMiller, do you have other thoughts?

We can definitely find a way to keep your existing files (configs and realization files) useable. I agree with you probably deprecation is the best way forward here

I'm curious about the change of surface_runoff (a very common term in hydrology) to direct_runoff (one I haven't heard before). Can you comment on the issue with 'surface_runoff'?
…
On Wed, May 1, 2024 at 12:49 PM Phil Miller - NOAA @.> wrote: Changes in BMI variable names are presumably going to require corresponding changes in Realization Config files, to map them appropriately between coupled models. This presumably affects both the documentation and examples @stcui007 https://github.com/stcui007 is developing, and the config generation in DMOD that I think @aaraney https://github.com/aaraney maintains. — Reply to this email directly, view it on GitHub <#116 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIKAROGFDOWLGUCD3WT3GDZAE2NHAVCNFSM6AAAAABHCIARRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYHEYTKMZSHE . You are receiving this because you are subscribed to this thread.Message ID: @.>

@andywood historically CFE never used the term SURFACE_RUNOFF which I introduced in the PR #112, and trying to revert it here to its old name DIRECT_RUNOFF, and I agree it is very commonly used term. However, according to the revised CFE schematic that Fred put together, the term DIRECT_RUNOFF refers to the portion of the surface water that goes directly into the streams in a timestep. When we route infiltration excess water through GIUH or Nash Cascade, generally speaking, not all of it makes it to the channel within a single timestep, so whatever drain in that timestep is the direct_runoff and the rest is the surface water (which will drain the next timestep; all or portion of it).
Based on my understanding, the term surface runoff generally refers to the overland flow, but note I am not a hydrologist 😊. I can setup a short call to discuss it offline a bit more

@aaraney @stcui007, according to @fred-ogden the revised CFE (including all these changes) is cfe3.0 and is conceptually more "equivalent" to the existing NWM. The cfe3.0 requires new inputs from the config file N_nash_surface, K_nash_surface, and nash_storage_surface, thus anyone running cfe3.0 will need to regenerate their config files irrespective of the other changes (surface_water_partitioning_scheme or surface_partitioning_scheme) 😊

If those new configuration variables are required in the input file, then I think I'd be more inclined not to go through a deprecation process for the surface(_water)_partitioning_scheme variable. Rather, its presence can be taken as a signal of an 'old' config file, and we can error saying "CFE 3.0 requires config file updates. See #issue for details".

@AJKhattak, thanks for the explanation!
On Thu, May 2, 2024 at 8:32 AM AJKhattak-NOAA @.***>
wrote:

I'm curious about the change of surface_runoff (a very common term in
hydrology) to direct_runoff (one I haven't heard before). Can you comment
on the issue with 'surface_runoff'?
… <#m_-470798467006399107_>
On Wed, May 1, 2024 at 12:49 PM Phil Miller - NOAA @.> wrote: Changes
in BMI variable names are presumably going to require corresponding changes
in Realization Config files, to map them appropriately between coupled
models. This presumably affects both the documentation and examples
@stcui007 https://github.com/stcui007 https://github.com/stcui007
https://github.com/stcui007 is developing, and the config generation in
DMOD that I think @aaraney https://github.com/aaraney
https://github.com/aaraney https://github.com/aaraney maintains. — Reply
to this email directly, view it on GitHub <#116 (comment)
https://github.com/NOAA-OWP/cfe/pull/116#issuecomment-2088915329>, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIKAROGFDOWLGUCD3WT3GDZAE2NHAVCNFSM6AAAAABHCIARRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYHEYTKMZSHE
https://github.com/notifications/unsubscribe-auth/ABIKAROGFDOWLGUCD3WT3GDZAE2NHAVCNFSM6AAAAABHCIARRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYHEYTKMZSHE
. You are receiving this because you are subscribed to this thread.Message
ID: @.>
@andywood https://github.com/andywood historically CFE never used the
term SURFACE_RUNOFF which I introduced in the PR #112
https://github.com/NOAA-OWP/cfe/pull/112, and trying to revert it here
to its old name DIRECT_RUNOFF, and I agree it is very commonly used term.
However, according to the revised CFE schematic that Fred put together, the
term DIRECT_RUNOFF refers to the portion of the surface water that goes
directly into the streams in a timestep. When we route infiltration excess
water through GIUH or Nash Cascade, generally speaking, not all of it makes
it to the channel within a single timestep, so whatever drain in that
timestep is the direct_runoff and the rest is the surface water (which will
drain the next timestep; all or portion of it).
Based on my understanding, the term surface runoff generally refers to
the overland flow, but note I am not a hydrologist 😊. I can setup a
short call to discuss it offline a bit more
—
Reply to this email directly, view it on GitHub
https://github.com/NOAA-OWP/cfe/pull/116#issuecomment-2090643309, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIKARKK5WIEOAMOC4CCQP3ZAJFBRAVCNFSM6AAAAABHCIARRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJQGY2DGMZQHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Just to make it easy to distinguish CFE 2.x from CFE 3.0, lets make sure to tag the commit at HEAD just prior to merging this. @ajkhattak and I chatted about doing this in a side channel, just leaving a todo here.

@aaraney to be more specific, we will tag this commit 0be829df6777c42b62993e396dfcb485adf28aae as cfe2.0 as even the previous commit has changes related to cfe3.0

@ajkhattak - I was planning on making list of places where this CFE PR would effect other formulations as well as ngen (e.g. realization.json with the BMI name changes.) Would this be helpful? -thanks!

For history sake, it looks like these changes were introduced in #120.


Update README with how to require the code

Update the Installation section in the README with a note on what name / path to use when requiring the gem.
Types of Changes

Documentation

Contribution

[x] I agree to the Developer's Certificate of Origin 1.1.

Thanks!


There should be a way for a leaf node to tell if it's SpatialNavigationRoot element has focus

Is your feature request related to a problem? Please describe.
When using Multiple SpatialNavigationRoot elements, there are multiple isFocused leaf nodes making a leaf node display itself as focused difficult.
Describe the solution you'd like
I understand that each SpatialNavigationRoot does actually have a focused item local to itself, but the naming is confusing. There should be a way for a leaf of a SpatialNavigationRoot to see if it's parent SpatialNavigationRoot has focus
Describe alternatives you've considered
We currently have separate SpatialNavigationRoot items for the menu, the content, and flyouts. We currently are using a menuContext to see if the menu SpatialNavigationRoot has focus or not. There should be a way for a button to tell if it's parent SpatialNavigationRoot has focus without importing a context from the menu.

Hey!
That's an interesting point. We have a similar need, so we implemented a little context ourselves. I was wondering if it should be included in the lib itself.
What would you expect as an API? 😁

Since there are already isActive and isFocused props being passed from a SpatialNavigationNode maybe a isRootFocused could be added along?

Would isRootActive be as clear? The root is not really focused (in LRUD we talk about focused for leaf nodes only if I'm correct 😁)

Hey @jonp-iversoft ! I just opened a PR to solve your issue.
I'm leaving for holidays, and I didn't want to leave you hanging.
If you want to try it out without a new release: you can clone the repo, build the lib using cd packages/lib && yarn build, copy the dist result in yourproject/node_modules/react-tv-space-navigation, and use patch-package react-tv-space-navigation to generate a patch out of it 😁
(well that's how I do it)
I tried it out a little bit, it seems to work fine 🙌
I'll try it more when I'll come back and publish it then.

Published in 3.6.0 😊

You're the 🐐


Update github_commit table to use GraphQL API

Is your feature request related to a problem? Please describe.
I'd like to use the GraphQL API when querying the table
Describe the solution you'd like
Update the table to use the GraphQL API
Describe alternatives you've considered
n/a
Additional context
For any fields that have paging, consider implementing that field as another table to avoid excess API calls (as per https://steampipe.io/docs/develop/plugin-release-checklist#data-ingestion).
New columns

short_sha
author
committer
additions
deletions
changed_files
committed_via_web
commit_url
signature
status
tarball_url
zipball_url
tree_url
can_subscribe
subscription

Renamed columns

author_date => authored_date
committer_date => committed_date

Removed columns

verified - information can now be found in the signature column JSON.
comments_url
commit
files
html_url
parents
stats - now individual columns

Columns with data changes

url now has contents of previous fields html_url instead of rest api endpoint

https://github.com/turbot/steampipe-plugin-github/pull/263/commits/95f5bf4e738de5a1340c3c3bc39bf7ae84d80373


MAPREDUCE-7285. Junit class missing from hadoop-mapreduce-client-jobclient-*-tests jar.

The fix worked on my local.
[centos@centos7 hadoop-3.4.0-SNAPSHOT]$ bin/hadoop jar share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-*-tests.jar sleep -mt 1 -rt 1 -m 1 -r 1
2020-07-15 11:12:13,657 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
2020-07-15 11:12:14,670 INFO client.DefaultNoHARMFailoverProxyProvider: Connecting to ResourceManager at /<IP_ADDRESS>:8032
2020-07-15 11:12:15,259 INFO mapreduce.JobResourceUploader: Disabling Erasure Coding for path: /tmp/hadoop-yarn/staging/centos/.staging/job_1594777964233_0002
2020-07-15 11:12:16,806 INFO mapreduce.JobSubmitter: number of splits:1
2020-07-15 11:12:17,456 INFO mapreduce.JobSubmitter: Submitting tokens for job: job_1594777964233_0002
2020-07-15 11:12:17,456 INFO mapreduce.JobSubmitter: Executing with tokens: []
2020-07-15 11:12:17,713 INFO conf.Configuration: resource-types.xml not found
2020-07-15 11:12:17,713 INFO resource.ResourceUtils: Unable to find 'resource-types.xml'.
2020-07-15 11:12:17,790 INFO impl.YarnClientImpl: Submitted application application_1594777964233_0002
2020-07-15 11:12:17,832 INFO mapreduce.Job: The url to track the job: http://localhost:8088/proxy/application_1594777964233_0002/
2020-07-15 11:12:17,833 INFO mapreduce.Job: Running job: job_1594777964233_0002
2020-07-15 11:12:26,114 INFO mapreduce.Job: Job job_1594777964233_0002 running in uber mode : false
2020-07-15 11:12:26,115 INFO mapreduce.Job:  map 0% reduce 0%
2020-07-15 11:12:32,220 INFO mapreduce.Job:  map 100% reduce 0%
2020-07-15 11:12:37,281 INFO mapreduce.Job:  map 100% reduce 100%
2020-07-15 11:12:38,326 INFO mapreduce.Job: Job job_1594777964233_0002 completed successfully
...

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
21m 31s
trunk passed

+1 :green_heart:
compile
0m 33s
trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
compile
0m 29s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 24s
trunk passed

+1 :green_heart:
mvnsite
0m 31s
trunk passed

+1 :green_heart:
shadedclient
16m 31s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 21s
hadoop-mapreduce-client-jobclient in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 20s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
0m 42s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 39s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04

+1 :green_heart:
javac
0m 27s
the patch passed

+1 :green_heart:
compile
0m 23s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
0m 23s
the patch passed

+1 :green_heart:
checkstyle
0m 18s
the patch passed

+1 :green_heart:
mvnsite
0m 25s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 16s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 19s
hadoop-mapreduce-client-jobclient in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.

+1 :green_heart:
javadoc
0m 17s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
findbugs
0m 45s
the patch passed

_ Other Tests _

-1 :x:
unit
125m 12s
hadoop-mapreduce-client-jobclient in the patch passed.

-1 :x:
asflicense
0m 37s
The patch generated 1 ASF License warnings.

188m 52s

Reason
Tests

Failed junit tests
hadoop.mapreduce.lib.input.TestCombineFileInputFormat

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2139/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2139

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux d1451cfbc80a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 317fe4584a5

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2139/1/artifact/out/branch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-2139/1/artifact/out/patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2139/1/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2139/1/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-2139/1/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1178 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2139/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

+1, JUnit 3 dependency must be removed.
hadoop.mapreduce.lib.input.TestCombineFileInputFormat is fixed by #2136

Thanks, @aajisaka. I merged this.


jigasi support

Hello community,
Does anyone know if jigasi is supported with this Kubernetes helm deployment?  I see it is supported with a docker installation at https://jitsi.github.io/handbook/docs/devops-guide/devops-guide-docker/ however, no mentioning of it here.
Thanks!

Hello @palmtown!
IIRC Jigasi is a SIP gateway, which makes it tricky to set up properly, let alone reliably use it in k8s environment. Because of this (and perceived lack of people insterested in connecting Jitsi Meet with telephony networks) we haven't really considered adding support for it in this chart, which is aimed to be as "plug-n-play" as possible.

Hello @spijet ,
Thanks for the update.  Much appreciated!


Added robots.txt parser example

By popular demand (#153) , I added an example to show how to integrate simplecrawler with robots-parser, a module that can parse robots.txt files and query URL's against the rules in them.

I'll add some documentation to the README as well before merging this.

Cool. Looks good at first glance! :)

@cgiffard you think this is ready for merging?

Go for it! We now just need to make sure that this new method is documented. You hit the button. :)

Gak, got confused between this PR and the other one. Ignore my comment about documentation. ;)

Haha got me a bit confused at first!


plt.show() puts image in following prompt

Copy-paste the following code into an IPython repl:
from mpl_toolkits.mplot3d import Axes3D
import matplotlib.pyplot as plt
import numpy as np
fig = plt.figure()
ax = fig.add_subplot(111, projection='3d')
for c, z in zip(['r', 'g', 'b', 'y'], [30, 20, 10, 0]):
    xs = np.arange(20)
    ys = np.random.rand(20)
    # You can provide either a single color or an array. To demonstrate this,
    # the first bar of each set will be colored cyan.
    cs = [c] * len(xs)
    cs[0] = 'c'
    ax.bar(xs, ys, zs=z, zdir='y', color=cs, alpha=0.8)

ax.set_xlabel('X')
ax.set_ylabel('Y')
ax.set_zlabel('Z')
plt.show()

The image appears after the In [2]: prompt (where 2 is actually the number after the previous prompt).
If you omit the plt.show(), it appears in the correct location.

Thought we had a dup of this somewhere but can't find it now.


add basic e2e smoke test re: #137

What this PR does:
npm pack creates the same tarball that npm publish would, and stores the tarball locally, which makes it easy to test the published tarball.
Which issue(s) this PR fixes:
Fixes #137
Checklist

[ ] Changes manually tested
[ ] Automated Tests added/updated
[ ] Documentation added/updated
[ ] CLA Signed: DataStax CLA

Thanks for this PR @vkarpov15!  LGTM
Can we also add this new step (i.e. e2e) in ci-tests.yaml to publish.yaml before the publish step?

@kathirsvn I made "publish" depend on "e2e" using GitHub dependent jobs, so Publish won't run until "e2e" succeeds. What do you think of this approach?


Keyboard Shortcuts in Text Boxes

Would be great to have Ctrl+Arrows jump words, and Shift+Arrows select text.

Just noticed Home + End buttons are also not working


Patterns (C# Reference): List patterns broken sentence

The section on list patterns ends with a weird sentence:

You any other pattern to match characteristics about individual elements.

I guess the intended sentence would be

You can use any other pattern to match characteristics about individual elements.

It's probably also a good idea to show what this looks like near this line, such as
record is [_, "DEPOSIT", _, string amount and not ""] => decimal.Parse(amount)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9112c305-f1cd-1aa5-4557-2c7d757e6ca0
Version Independent ID: 312e9c81-ee2a-1d84-64d7-bcaa71d7eab8
Content: Patterns - C# reference
Content Source: docs/csharp/language-reference/operators/patterns.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for catching this and raising the suggestion @rubenprins
I've assigned myself and added it to this month's sprint.


Optional serde implementation

Feature gated using the serde feature.
Currently supports primitive values; requires work to handle all the complex types like sequences, structs, enums, tuples etc.

Not sure if this interests you @mathias234 but I think it would be really useful to be able to implement Serialize and Deserialize when designing file formats.

Hmm, I am not quite sure I see the benefits of this, over just using serde. Are you thinking about mixing manual writing/reading with automatic serialization/deserialization?
I originally wrote this because I wanted to write file formats that did not match the in memory structure. Although I can possibly see the benefit of being able to mix it.

At the moment I am doing the encoding / decoding ad-hoc using these traits (which we could probably fold into this crate):
use crate::Result;
use binary_rw::{BinaryReader, BinaryWriter};

/// Trait for encoding to binary.
pub trait Encode {
    /// Encode self into the binary writer.
    fn encode(&self, writer: &mut BinaryWriter) -> Result<()>;
}

/// Trait for decoding from binary.
pub trait Decode {
    /// Decode from the binary reader into self.
    fn decode(&mut self, reader: &mut BinaryReader) -> Result<()>;
}

But I am following the structure of the data in memory so it feels like quite a bit of work updating the encoding / decoding routines whenever I need to change the data structure(s).
An ideal solution would be to mix serde with overrides using those traits, as you mention, but I am not sure if this is possible or how we might achieve it.
If you don't think this is something to explore in the context of this crate it would be quite straightforward for me to put this in another crate, serde-binary maybe?

So these latest commits add more or less full support for serde, if I have missed some types I will fix later.
This also includes support for the reading and writing the char type so if we move this to another crate then I can cherry pick those changes to BinaryReader and BinaryWriter.
I played with downcast a little and I don't think it will work as downcasting to a trait requires boxing and the 'static lifetime; so I think it is realistically an either or situation.

@tmpfs I think what you suggest here works moving the serde parts to its own crate, as I feel it's not quite in the scope of what this crate is. I am fine with adding the Encode and Decode traits and the char type :slightly_smiling_face:

Cool, I have moved the code here: https://github.com/tmpfs/serde-binary.
I think I know how we can get the best of both worlds actually. Because the Serializer and Deserializer wrap the BinaryWriter and BinaryReader I can create new traits that expose the Serializer and Deserializer (lets call them Encodable and Decodable not to conlict with the lower-level Encode and Decode traits) then implementations can either use the Serializer / Deserializer or the wrapped BinaryWriter and BinaryReader. Provided the encoding and decoding are symmetrical it should work fine.


CVE-2023-6345 was reported to the Avalonia application

Describe the bug
CVE-2023-6345 with critical severity was reported to the Avalonia application.
To Reproduce
Steps to reproduce the behavior:
Use the scan tool to check the vulnerabilities of the Avalonia application, CVE-2023-6345 was reported.
Expected behavior
From the description of CVE-2023-6345, this should be an issue of the skia. Can someone please tell whether the application built-upon Avalonia is impacted by that vulnerability? Is there any workaround to mitigate the possible dangers? Thanks.

Is it known, from which Skia version this vulnerability can be reproduced? Asking because Avalonia uses a very old Skia version - 88.

Thanks for your quick reply @maxkatz6. From the https://www.helpnetsecurity.com/2023/11/29/cve-2023-6345/, looks like Google doesn't want to reveal too many details about the issue.
Glad to know Skia 88 is used by the Avalonia. I have seen quite a few of vulnerabilities reported to Skia these years. I don't know how many of them impact Skia 88. But, this make me nervous about the security.

Unless this is an issue directly within Skia and Avalonia is using that part with some user facing API this should not affect Avalonia

It's better to ask in SkiaSharp repo if version 88 is affected

Last big vulnerability issue was about compiling shaders at runtime. Chrome isn't doing that anymore. Hard to tell what exploid this is really about. There is no information about the exploit.

https://www.linkedin.com/pulse/critical-zero-day-vulnerability-chrome-cve-2023-6345-ilangovan-xxgac

It's better to ask in SkiaSharp repo if version 88 is affected

https://github.com/mono/SkiaSharp/issues/2716 was reported to SkiaSharp. Thanks for your suggestion.


Error sincro

Good afternoon I have a problem to synchronize the wallet, I can not pass 98% and it stays nailed there. Can anyone suggest a solution?
I can not mine.

This issue should be resolved as of v1.3.1. Please download the latest release (now v1.3.2) and reopen if it still occurs.