Full Screen Mode, button display will be incomplete

Type: Bug
To enter full screen mode, click the green button and Cmd+Ctrl+f. After entering full screen via the green button, when the mouse moves to the top of the screen, the button display will be incomplete.
https://user-images.githubusercontent.com/20641704/188099578-25cad8a1-25c1-4e70-b6c0-e145b2e72c62.mov
VS Code version: Code 1.71.0 (784b0177c56c607789f9638da7b6bf3230d47a8c, 2022-09-01T07:25:38.437Z)
OS version: Darwin x64 19.6.0
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 1, 1

Memory (System)
16.00GB (5.17GB free)

Process Argv
--crash-reporter-id 40d5101c-7919-4e07-ba49-c06bd16fbba1

Screen Reader
no

VM
0%

Extensions (8)

Extension
Author (truncated)
Version

gitlens
eam
12.2.1

go
gol
0.35.2

remote-ssh
ms-
0.84.0

remote-ssh-edit
ms-
0.80.0

cpptools
ms-
1.12.4

rust-analyzer
rus
0.3.1186

vim
vsc
1.23.2

vscode-todo-highlight
way
1.0.5

(2 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411cf:30557515
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
pylanb8912:30545647
vsclangdc:30486549
c4g48928:30535728
hb751961:30553087
dsvsc012cf:30540253
azure-dev_surveyonecf:30548226
2144e591:30553903

I am quite certain this is not something VSCode is doing wrong but some issue with either Electron or the configuration on the users OS. I am not aware of a way for VSCode to make it possible that macOS is not able to draw the full title when you go up with the mouse.
Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

I am quite certain this is not something VSCode is doing wrong but some issue with either Electron or the configuration on the users OS. I am not aware of a way for VSCode to make it possible that macOS is not able to draw the full title when you go up with the mouse.
Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

I tried vscode-insiders, same results. Here are the screenshots.

Did you install a 3rd party software that could modify window management on macOS?

No. I don't have any third party window management software installed.

Does it reproduce with other Electron apps such as https://github.com/electron/fiddle/releases ?

Does it reproduce with other Electron apps such as https://github.com/electron/fiddle/releases ?

I just installed the software and the above problem did not occur.

Can you try to run code --disable-extensions --user-data-dir <directory> where <directory> is an empty folder? This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.

Same results. Is it possible that it's a system problem? My system is version 10.15. I asked my friend, his system is version 11.0 onwards. Didn't see the problem.

I have the same problem. My computer is a macbook Pro 13-inch with MacOS 10.15.7. How to fix it?

Does setting window.experimental.windowControlsOverlay.enabled to false fix the issue?

I'm unable to repro this issue on Big Sur.
Did this issue start with 1.71?

I'm unable to repro this issue on Big Sur.
Did this issue start with 1.71?
Yes. I asked my friend whose system is bigsur and did not have this problem.

I've seen this problem in previous versions as well.

https://github.com/microsoft/vscode/issues/157440#event-7142410266

Because I think the issue has to do with Electron but I don't have Catalina installed, I'm wondering what was the last stable version of VS Code that was working for you? Below, I have linked to three macOS Universal builds with their Electron versions attached. I'm expecting the issue to be between 1.67.2 and 1.69.2, but I'm not sure yet.
1.67.2 universal (Electron 17)
1.69.2 universal (Electron 18)
If even 1.67.2 has the full screen mode issue, here's a link to 1.65.2 to try:
1.65.2 universal (Electron 13)
Can you please try the versions and tell me which ones have the full screen mode issue?

Version: 1.67.2 (Universal)
Commit: c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5
Date: 2022-05-17T18:20:57.384Z
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0

ok

Version: 1.69.2 (Universal)
Commit: 3b889b090b5ad5793f524b5d1d39fda662b96a2a
Date: 2022-07-18T16:12:57.074Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0

ok

Version: 1.65.2 (Universal)
Commit: c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1
Date: 2022-03-10T14:33:49.188Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 19.6.0

ok

It could be from https://github.com/microsoft/vscode/pull/155906/files#diff-8df60a43bae936033d4187a89baf39cc9f4e427ce9ef6dee62918665dd2c9bb5R1085.
But, based on https://github.com/microsoft/vscode/issues/157440, it seems a similar bug was in 1.70.0.
I noticed that VS Code only started calling setTrafficLightPosition starting in 1.70.0.

Thanks for narrowing down the issue, macOS >= 11 have increased titlebar height compared to earlier versions you can see the context on it at https://github.com/microsoft/vscode/issues/106528#issuecomment-710686883 . This is not a regression in the setTrafficLightPositions API but rather we should adjust the offset provided in https://github.com/microsoft/vscode/pull/155906 to account for the different titlebar heights depending on the OS version similar to https://github.com/microsoft/vscode/blob/c7c1717456e4543aa49c0f9678f686e84dd0dd5d/src/vs/workbench/electron-sandbox/parts/titlebar/titlebarPart.ts#L33-L40

I created a custom Insiders build that corresponds to the commit https://github.com/microsoft/vscode/commit/85061ccca43e1b5274dc7a6a655800369deaa4a6.
Can you try that build and:

Open the Log (Main) output window and paste the output? There should be some logs specifically about the traffic light position.
Tell me whether the fix works? I tried to reset the traffic light position in some cases.

Also, something I noted about Big Sur is that while it is in full screen mode, it is not affected by setTrafficLightPosition.

I think it has worked properly.
[2022-09-14 09:14:25.774] [main] [info] update#setState idle
[2022-09-14 09:14:26.821] [main] [info] options.height is 22
[2022-09-14 09:14:26.822] [main] [info] Setting traffic light y value to 3.5
[2022-09-14 09:14:27.163] [main] [info] UtilityProcess<1>: Creating new...
[2022-09-14 09:14:27.169] [main] [info] UtilityProcess<1>: received spawn event.
[2022-09-14 09:14:29.084] [main] [info] options.height is 0
[2022-09-14 09:14:29.084] [main] [info] Setting traffic light y value to 4
[2022-09-14 09:14:33.569] [main] [info] options.height is 22
[2022-09-14 09:14:33.569] [main] [info] Setting traffic light y value to 3.5
[2022-09-14 09:14:34.402] [main] [info] options.height is 0
[2022-09-14 09:14:34.402] [main] [info] Setting traffic light y value to 4
[2022-09-14 09:14:55.638] [main] [info] update#setState checking for updates
[2022-09-14 09:14:56.439] [main] [error] UpdateService error: Cannot update while running on a read-only volume. The application is on a read-only volume. Please move the application and try again. If you're on macOS Sierra or later, you'll need to move the application out of the Downloads directory. See https://github.com/Squirrel/Squirrel.Mac/issues/182 for more information.
[2022-09-14 09:14:56.439] [main] [info] update#setState idle
[2022-09-14 09:18:00.702] [main] [info] options.height is 22
[2022-09-14 09:18:00.703] [main] [info] Setting traffic light y value to 3.5
[2022-09-14 09:18:02.122] [main] [info] options.height is 0
[2022-09-14 09:18:02.122] [main] [info] Setting traffic light y value to 4
[2022-09-14 09:18:06.736] [main] [info] options.height is 22
[2022-09-14 09:18:06.736] [main] [info] Setting traffic light y value to 3.5
[2022-09-14 09:18:09.040] [main] [info] options.height is 0
[2022-09-14 09:18:09.040] [main] [info] Setting traffic light y value to 4
[2022-09-14 09:18:19.235] [main] [info] options.height is 22
[2022-09-14 09:18:19.235] [main] [info] Setting traffic light y value to 3.5
[2022-09-14 09:18:22.086] [main] [info] options.height is 0
[2022-09-14 09:18:22.086] [main] [info] Setting traffic light y value to 4

Discussing the above fix with @rzhao271 , we think this issue requires further investigation on the Electron side. Current investigation shows that height value is 0 when application goes fullscreen for all OS versions and that is because in fullscreen the titlebar is drawn by the OS and not Electron. But what is interesting, is that setTrafficLightPosition api does not cause the buttons to redraw in macOS >= 11 which potential hides this issue in VSCode.
Electron decides to redraw the buttons whenever setTrafficLightPosition is called depending on whether a view is hosting the buttons, we think this might not be the case when application enters fullscreen in macOS >= 11 leading to a no-op call in these versions, refs https://github.com/electron/electron/blob/38a7da692aaae01dae97e96b7a5eb648765efe33/shell/browser/ui/cocoa/window_buttons_proxy.mm#L222-L229. We will confirm if that is the case and if so, align the behavior of older versions to be the same which will help remove the workaround in VSCode.


hotspot_custom is broken with jdk8

hotspot_custom is broken with jdk8 due to change of   JVM_NATIVE_OPTIONS in the playlist to -nativepath:"$(TESTIMAGE_PATH)/hotspot/jtreg/native" in https://github.com/adoptium/aqa-tests/pull/5370.  This change meant to use TARGET=disabled.hotspot_custom to run openj9 custom serviceability jvmti test https://github.com/adoptium/aqa-tests/issues/5357 , which works by disabled.* target instead of hotspot_custom directly. I would prefer to separate a custom target to standardize the use of custom target.  https://github.com/adoptium/aqa-tests/issues/5357#issuecomment-2197503446 https://github.com/adoptium/aqa-tests/issues/5357#issuecomment-2197510570
https://ci.adoptium.net/view/Test_grinder/job/Grinder/10733/
11:08:52  TESTING:
11:08:52  Error: The -nativepath path does not exist: /hotspot/jtreg/native
11:08:52  Usage:

@LongyuZhang @llxia

Will separate the custom test for hotspot and j9 then.


"useContextSelector requires special context" warning is never printed

This code is intended to print a warning if you use createContext from react rather than use-context-selector. I made this mistake and the warning was not printed. This happens because typeof process is expected to be 'undefined' when running in the browser. Going to submit a PR for this.
https://github.com/dai-shi/use-context-selector/blob/06a2c827bb19654c44952f098ba8e1fc4807e645/src/index.ts#L159-L163

Good point. So, you use some bundlers (vite?) that injects process.env.NODE_ENV but not process, right?

Yes, that is correct. I am using Webpack which replaces process.env.NODE_ENV but does not actually define a process object.

I have been thinking about this, also in another project, but the current way is fairly safe. I wish there were a standard way in the source code that works for CJS, ESM, browser and Deno. Until we know same good way, let's leave it.
For now, please configure your webpack to define process as {} in development mode.
Closing.


The draft MicroProfile Trademark Guidelines doc format

The draft MicroProfile Trademark Guidelines is a Microsoft Word doc, can that one be converted to a google doc please?
https://docs.google.com/document/d/1dturdVLQvx-UV6TbD9wr0pgFReBXhDH0/edit?pli=1
I and I expect that others do not have access to Microsoft Office and using G Suite to edit and comment on a Microsoft Office document is not always reliable.

Sure Paul.
I will ask the contributor who lead the work to do the conversion.

Thanks so much!

I will ask the contributor who lead the work to do the conversion.

Even though it is a .docx type on the file, everything with posting comments and/or editting seems to work just fine.  If we want to change the type on it, then all current references will need to be updated.  Unless there is a direct issue with this .docx format, I would suggest that we just leave it as-is until it becomes ready to be cast into stone.
@paulbuck are you okay with this approach?  Or, have you experienced problems with this .docx format?
Thanks!

Hi Kevin,
I think I was having a bad day yesterday w/ the G Suite + MS Office .docx
experience. Appears to be better today, so let's leave it as-is for
the reasons you mentioned.
Thanks ... Paul
On Thu, Jun 24, 2021 at 2:23 PM Kevin Sutter @.***>
wrote:

I will ask the contributor who lead the work to do the conversion.
Even though it is a .docx type on the file, everything with posting
comments and/or editting seems to work just fine. If we want to change the
type on it, then all current references will need to be updated. Unless
there is a direct issue with this .docx format, I would suggest that we
just leave it as-is until it becomes ready to be cast into stone.
@paulbuck https://github.com/paulbuck are you okay with this approach?
Or, have you experienced problems with this .docx format?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microprofile/microprofile-wg/issues/93#issuecomment-867858851,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ3NJHP3Z7P73X6CONZ6QKDTUNZ3HANCNFSM47GIPG5Q
.

@paulbuck,
[microprofile-wg] [BALLOT] Replace MicroProfile Compatibility Logo with.pdf
Given the vote passing, what do we need to do to complete the Guidelines?
There is nothing missing from the side of MP.
Thanks for the follow up,


Makes dyn compositional

This PR & its sister PR in Bolson create a new key in the record that's sent to objects called dyn. dyn is empty unless something winds up in a dynamic element via:

being created in one; or
zapped through a portal to one

This is different than scope in that scope trickles down from a dynamic child to all of its descendants until it hits a new dynamic child. They serve these purposes:

scope, which has existed in the API since day 1, is used to free up resources of a dynamic child. When we delete a child that was created dynamically, everything inside of its scope is deleted as well. The deletion algorithm should pick up new scopes as it burrows down into the element tree, so if a new scope is started a few levels down (ie if a dyn holds a dyn), all things in the new scope get deleted too. Without scope, the internal state would just grow and grow.
dyn is used to show that something belongs to a dynamic bolson element. Using this information, projects that need it (deku) can implement grouping algorithms based on it. If something is not the direct child of a dynamic element, it shouldn't get a dyn.

The PR currently works for the limited case of creating/deleting elements and still needs to be updated for:

Portals.
Prioritization (aka sendToPos).

Additionally, there's a lot of code in Internal.js that deals with scope & dyn that's quite fragile, it'd be good to document more of it and perhaps even move most of it to the PS layer so there's more type safety in the internal API. That'd make it easier to hack at without fear of breaking stuff.

I'm not thrilled about adding spurious elements into the DOM. It could mess up CSS selectors, for example. I don't see an easy alternative though.

I'll let this simmer for a while before merging, perhaps a better solution will emerge.
If dyn were guaranteed to be empty, we could work with the bottom-most and top-most elements, but as it could be empty, the only implementation I could think of so far was this.
The PR also isn't ready because it won't work with nested dyn yet. Eventually, before merging, we'll need an example with many-levels-deep dyn to verify that it works even in complex setups.


Grid lines don't appear if transition duration set to 0

This seems to be a bug and was hard to track down, so I thought I'd report it in case others run into this.
To repro, go to http://c3js.org/samples/grid_x_lines.html and add
    transition: {
        duration: 0,
    },

The x lines will disappear. An easy workaround is to set the duration to 1, but this seems to be unexpected behavior.

Just found that out too, so, +1 for me... :-)

Regions don't appear also.

Thanks for reporting. Is this still happening in 0.4.10-rc4? I cannot see this issue and it seems fixed already in this version.

0.4.10 has been released, so let me close at the moment. Thanks.


How best to document the setup, dev, and build process?

if I write too much I end up writing a typescript textbook. I would really like to avoid that. but sometimes there are little shitty issues when setting up and building a react+ typescript app. should I just have a separate BUILDING.md?

oh man... i dont even know anything about that.. i just do whatever stackoverflow tells me to do

I also started some research on that topic, since we are currently having a complex webpack 3 setup. So for "migration" to webpack 4 we might need to/have the chance to to it properly from scratch.
It is hard to find resources on that topic.
Maybe we can collect some resources and facts  that are up to date in this issue first.
I'd be happy to contribute to a PR that concludes that information.

absolutely. to be honest i start from CRA-TS or CRAP-TS so i dont have much
to say there but would love to take a PR with some basic instructions to
get discussions started. dont feel the need to write a whole book on it :p
On Sun, Jun 24, 2018 at 4:55 AM Christian Bewernitz <
<EMAIL_ADDRESS>wrote:

I also started some research on that topic, since we are currently having
a complex webpack 3 setup. So for "migration" to webpack 4 we might need
to/have the chance to to it properly from scratch.
It is hard to find resources on that topic.
Maybe we can collect some resources and facts that are up to date in this
issue first.
I'd be happy to contribute to a PR that concludes that information.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sw-yx/react-typescript-cheatsheet/issues/3#issuecomment-399740509,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AiT1gmxJhlj3Co3_bHqTrc789v8HgHOdks5t_1QSgaJpZM4UX0VG
.


release-1.17, fix latest version to deprecated version

Modify latest parameter to the deprecated version.

Related to #25548.

/hold

Page preview:
https://deploy-preview-25558--k8s-v1-17.netlify.app/docs/reference/generated/kubernetes-api/v1.17/

I can keep all latest-version updates in this PR or let each localization make the fixes.
/cc @kubernetes/sig-docs-zh-reviews @kubernetes/sig-docs-ko-reviews @kubernetes/sig-docs-pl-reviews
Note: I did not replace the latest-version in the contribute pages.

/hold cancel

/approve


Update smartevse.go

We have the following options, see also https://github.com/edge-tech-eu/SmartEVSE/blob/main/ModBusRegisters.pdf ,
Modbuss address 0204:
0x01: 1 or 3 phase
0x08: use lock with relay to disconnect
0x10: automatic cp disconnect (ev40 or relais, handled by charger module
0x20: use ev40 for cp disconnect
Modbus addres 0208: Time (in ms) to disconnect CP (handled by charger module depending on use lock or EV40)
I think the above is trivial for you to add. We have a patch from before the pull request and that is difficult for me to merge. And I don't understand how to add the features above to the charger template ("decorate").
I have added the latest file one of our customers is using, but he would like to revert to the stable release

@premultiply could you kindly take a look? This behavior was present in the original PR, but you've removed it. Even if we think the controller should do that itself- what if it doesn't?

There is nothing to do here.
Looks like the firmware 2.10.7 has everything you need now to let the EVSE do the right thing completly on its own and without any external relais.
If it is not supported yet you only have to update the firmware and may have to enable the features on the charger.
I do not know if it is enabled by default. Hopefully should be.

@premultiply, isn't the WakeUp ("Resurrector interface") a general feature of EVCC? If so, then it should be added then?! Plus the user must be able to select the cphwonlock in case the user has the hardware relais to open and close the CP connection. In case the CP disconnect feature must be used (so either via EV40 or the relais on the CP connection) the user must be able to activate or deactivate it (" 0x10: automatic cp disconnect (ev40 or relais, handled by charger module)"). So the user must be able to define it during setup ("cpwakeauto"). We want this feature selectable to avoid problems with EVs that don't need the "wake up".

No it is just a helper for chargers which can not wake-up vehicles on their own but we have found some tricks to do it. Very rare.
This is not the case here as the EVSE has a automatic wake-up feature implemented.
If it is not yet it should be enabled always.
No need to have it disabled.

We want this feature selectable to avoid problems with EVs that don't need the "wake up".

There are no (never) problems even if a car resists to wake-up. The procedure will stop if the care wakes up. Most cars even wake up on their own but there is no danger to wake up them using the EV40 method or even interupting the CP line.

@premultiply : still the user must be able to select which method, either via CP relais or EV40. How can the user set it?

Are you the firmware author of the EVSE?
Simple thing: Remove all the wake-up configuration from the firmware and let it always do exactly what EV40 describes in detail. There is no need for any configuration.
Otherwise it looks that a user needs some kind of Modbus tool to setup the EVSE to make sure that it is set to automatic EV40 wake-up including the correct timing.
Charger firmware setup is no task for evcc.

hi @premultiply , thanks for following it up again. And yes, we are the developers of the firmware. In the past we encountered some cars that "fell asleeep" when we reduced the charging current to 0A for a longer time, typically used in delayed charging scenarios. Good examples of it are Porsche Taycan, Audi eTron and Peugeot e208. Users had to open/close or unplug their cars to let the charging start again. Do you know if those brands awake again when EV40 is applied?

 You cannot fix this without a software update for the car.
For example, some versions of VW vehicles stop charging after 10 interruptions. The developers thought this was a good idea. You need to go to the car and unlock it so it can continue charging.
Other brands keep having the same wake-up problems with every new model they bring to market. Don't try to understand car software developers.
There is basically no difference in behavior between -12 V (“EV40”) or disconnecting the CP line using a relay. The relay method may even work slightly worse as it creates an indefinable voltage level.
Vehicles that generally do not wake up reliably cannot be woken up using either method.
My recommendation is: Remove all this CP disconnecting stuff from the firmware and let the EVSE always run the "EV40"-method exactly as specified. It does not need any configuration.

@premultiply , thanks for the extensive answer. As we just implemented the EV40-wakup I am unsure if it works for the cars we need if for. By accident a user already tested the relais approach for a Volkswagen e-Golf and for that case the relais interup worked. From your respons I understand that you don't want to offer the option to enable/disable EV40-wakeup? Same for the relais?

As this is basic EVSE configuration and implementation this is no task for evcc.

What can we do here to finish this PR? @swallage I assume you are retesting EV40 with the problematic vehicles?

Hi @andig , indeed, we are testing the EV40. As we don't own theses problematic vehicles we have to rely on feedback from other. Will get back on this soon.


Allow starting a container without using the default process type

Allow starting a container without using the default process type. This enables us to test images with multiple process types, process types that take arguments as well as starting a container with a custom command.
To make the custom command feature useful, the current logs of the container are now accessible via the ContainerContext so you can match against it in tests.
Updated execd example to no longer use a bogus sleep 3600 default process as a workaround.
Changelog additions:

Allow starting a container without using the default process type. Removed PrepareContainerContext::start, added PrepareContainerContext::start_with_default_process, PrepareContainerContext::start_with_default_process_args, PrepareContainerContext::start_with_process, PrepareContainerContext::start_with_process_args, PrepareContainerContext::start_with_shell_command (#366)
Add ContainerContext::logs and ContainerContext::logs_follow to access the logs of the container. Useful when used in conjunction with the new PrepareContainerContext::start_with_shell_command method to get the shell command output. (#366)
Replaced container_context::ContainerExecResult with log::LogOutput which is now shared with ContainerContext::logs and ContainerContext::logs_follow. (#366)

Closes GUS-W-10539911
Closes #309

FWIW this was a meh upgrade experience. I got this error:
error[E0599]: no method named `start` found for mutable reference `&mut PrepareContainerContext<'_>` in the current scope
  --> tests/integration_test.rs:23:18
   |
23 |                 .start(|container| {
   |                  ^^^^^ method not found in `&mut PrepareContainerContext<'_>`

And so I check the readme which shows this code:
// In $CRATE_ROOT/tests/integration_test.rs
use libcnb_test::{IntegrationTest, BuildpackReference, assert_contains};

#[test]
fn test() {
    IntegrationTest::new("heroku/buildpacks:20", "test-fixtures/app")
        .buildpacks(vec![
            BuildpackReference::Other(String::from("heroku/openjdk")),
            BuildpackReference::Crate,
        ])
        .run_test(|context| {
            assert_contains!(context.pack_stdout, "---> Maven Buildpack");
            assert_contains!(context.pack_stdout, "---> Installing Maven");
            assert_contains!(context.pack_stdout, "---> Running mvn package");

            context.prepare_container().expose_port(12345).start(|container| {
                assert_eq!(
                    call_test_fixture_service(
                        container.address_for_port(12345).unwrap(),
                        "Hagbard Celine"
                    )
                    .unwrap(),
                    "enileC drabgaH"
                );
            });
        });
}

fn call_test_fixture_service(addr: std::net::SocketAddr, payload: &str) -> Result<String, ()> {
   unimplemented!()
}

So it looks like start method does exist, but there is some other problem.
I spelunk to find the context.rs file and see this change as the most recent history. Then kinda intuit from the commit name and the all the start_ methods that I should use start_with_default_process instead.
My thoughts:

Readme needs to be tested as this is invalid code that will not compile
Just because we're statically typed doesn't mean interface changes won't be intuitive. I'm wanting some kind of a "this is deprecated, use this instead" experience which I would expect from even a language like Ruby. Granted there you have to manually do it, and not everyone does. Maybe there are some better UX patterns or macros or crates or something that exist for when we rename something (not just methods, structs and implementations as well).

Overall it's not a HUGE deal. Just wanted to give stream-of-concious and in-the-moment feedback as I think it's valuable. Whether we choose to act on it or not.

@schneems Thank you for the feedback!
Agree the libcnb-test README should be fixed - the code examples in repo root README are already tested in CI - this one is supposed to be too, but maybe the [test] annotation is interfering with that? I've filed #403.
These breaking changes were mentioned in the changelog (and the changelog gets inlined into Dependabot PRs for example, though you won't have such a PR since the Ruby Rust changes are not merged). However I agree this requires someone reading the changelog, so best if there is a more automatic solution.
Rust offers the ability to show such a warning, which we could use for future breaking changes:
https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute
That all said, it's worth bearing in mind that much of libcnb (particularly libcnb-test) is still at the very early pre-v1.0.0 stage (our team's buildpacks are the early adopters/guinea pigs for them), so we expect there to be more breaking changes/rough edges now, than there will be in the future. The changelog is there to try and make this slightly less confusing, so I would recommend reading it in the future :-)

That all said, it's worth bearing in mind that much of libcnb (particularly libcnb-test) is still at the very early pre-v1.0.0 stage (our team's buildpacks are the early adopters/guinea pigs for them), so we expect there to be more breaking changes/rough edges now, than there will be in the future. The changelog is there to try and make this slightly less confusing, so I would recommend reading it in the future :-)

I think there's two components for me 1) is a pure technical "can we do this" and the other is the implementation side. You've answered the "can we do this" thank you.
I think the second component is more of a cultural "should we do this". I certainly understand the cost/time tradeoff. I personally fall into habits where I "play" much like I "practice". I.e. I tend to do things always or never. If I don't make a habit of going through deprecation cycles then when it's really critical to do so I'll likely forget. I believe you have more self control as well as awareness and also are good at reviewing PRs. I need more black and white policies as well as automated tooling.
I do want to push back on the "it's just us" narrative. While that's true for now, the longer we act that way, the more hostile the codebase will be to adoption by others (self fulfilling prophecy). Also even "just us" is a hefty cost/time tradeoff. I spent maybe 60 min (perhaps rounding up) investigating this. If we multiply by number of team mebers then taking an extra hour to reduce multiplicative time spent might not always come out to be the best investment but it's an investment and does have payback.
The other thing of value I gain from choosing to use deprecation cycles is that it informs the implementation and also forces us to think about "after this PR is merged how will we deprecate or remove this code if it's no longer needed". In the same way I believe in shipping tests with code as it's written as the tests will inform the API. Not so dissimilar to making plans to deprecate and remove a stack before it's even released.
Coming from Ruby the main thing's I'm hoping to gain from Rust are improved maintainability and part of that is library/ecosystem deprecations.
I don't think we disagree in a large number of these areas I am somewhat typing to get my thoughts out and clear on the subject. I'm curious in talking more about the path forward for some of this stuff regarding when a good time to flip the switch from "not now" to "now" might be. Alternatively, maybe we could make me the "deprecation czar" (or something) and I can do some of the legwork of trying to figure out the deprecation/upgrade path on breaking changes.


systemnode output

Hello,
i'm running the the wallet locally and generated a key
now that i send the crown to my wallet and type "systemnode outputs"
It doesn't show anything, although the CRW is in my wallet.
Not sure how i have gone wrong here.

did you send EXACTLY 500 crw? did you wait for 15 confirmations?
On Mon, Dec 18, 2017 at 7:56 PM, GasGeverij<EMAIL_ADDRESS>wrote:

Hello,
i'm running the the wallet locally and generated a key
now that i send the crown to my wallet and type "systemnode outputs"
It doesn't show anything, although the CRW is in my wallet.
Not sure how i have gone wrong here.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Crowndev/crowncoin/issues/81, or mute the thread
https://github.com/notifications/unsubscribe-auth/AB0r3yRtqu2aCIlflqynPrk7QlAbYDFzks5tBrVGgaJpZM4RF6zt
.

--
Mvh
Fabian Olesen

If it moves, compile it.

no i send a litlle more because of fee stuff :P
Do i need to redo the process and change the genkey in the vps conf ?

no need to change the genkey, just redo the transaction with EXACTLY 500
then wait for 15 confirmations and your good :)
On Mon, Dec 18, 2017 at 8:37 PM, GasGeverij<EMAIL_ADDRESS>wrote:

no i send a litlle more because of fee stuff :P
Do i need to redo the process and change the genkey in the vps conf ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Crowndev/crowncoin/issues/81#issuecomment-352535215,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB0r38ZNMZ-e18D-56PHFyjh4AZI8XeMks5tBr7pgaJpZM4RF6zt
.

--
Mvh
Fabian Olesen

If it moves, compile it.

Thanks, I can use two wallets from my local machine right ?

This is annoying how do i send the entire balance


Having multiple tabs open with different URLs at the same time

Should this be happening?
I think I navigate one browser tab and the other navigates as well on its own.

Just in case it's not clear from the description, it is still happening with the recent release 0.17.1102.  Here's a short demo of the problem:
https://github.com/user-attachments/assets/773be039-c5e0-4aef-9f0c-3e10b90e74a1


Sim setup won't recognize a dictionary

When you set up parameters with a dictionary and then pass them to a Sim, they aren't being recognized.   The following code seems like it should assign a sim with 1,000 to the location Kenya, but when you print the location of the sim that's set up, it is None and so defaults back to Senegal.
base_pars = dict(location='kenya', n_agents=1000, verbose=0)
sim = fp.Sim(base_pars)

that is a bit confusing! the reason is that location is not a parameter but a separate argument to the sim, i.e.
base_pars = dict(n_agents=n_agents, verbose=1)
sim = fp.Sim(base_pars, location='kenya')

alternatively, since the sim can take keyword arguments, you could also do
base_pars = dict(location='kenya', n_agents=n_agents, verbose=1)
sim = fp.Sim(**base_pars)

which is exactly equivalent to doing
sim = fp.Sim(location='kenya', n_agents=n_agents, verbose=1)

i'm not sure what the best solution is here...it is a 'gotcha' that the location can't be passed as a parameter as you noted. but what the location argument does is create a parameter dict, so it would kind of be a chicken-and-egg situation if it's a parameter itself...

@cliffckerr Thanks for the clarification and looking through.  It makes sense that that pars are one parameter and the location is a second, separate parameter, so that's how I'll think about it.


PDF-Export fails

While obsidian-banners is enabled with default settings, obsidian fails to export the selected file to pdf.
Restart or Reinstall didnt help. Disabling obsidian-banners fixed the issue.
Error in console:

Same issue here

Ah, I found a problem. Just a sort of bad check for the "printing" view, I should be able to get a hotfix out real quick. Merci for the catch

Release is out and this should be fixed now!

Lovely! Really been enjoying the plug-in!


Persistent volume

Related to #1462

Please target the traffic controller for this, rather than the ABn chart.
You can using dynamic provisioning to allocate persistent volume. You don't deal with PV directly. You only deal with PVC and supply the storage class name. For instance, see: https://docs.openshift.com/container-platform/3.11/install_config/storage_examples/storage_classes_dynamic_provisioning.html

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
 name: iter8-pvc
spec:
 accessModes: # list value you can set
  - ReadWriteOnce # only one pod has access to this
 resources:
   requests:
     storage: 10Gi # value you can set
 storageClassName: default # most cloud vendors have a default storage class defined # value you can set


Relationship between SAR version and more public version confirmation

My organisation is planning to manage the deployment of this application via Terraform.
I have noted a slight discrepancy between public versioning and the semantic versioning within the serverless application repository.
The public releases seem to be 11.1, 11.0, 10.1, 10.0 etc as highlighted here and in the commit messages within this repository.
However the serverless application repository lists the semantic versions as
[
  "1.0.1",
  "1.0.2",
  "10.0.0",
  "10.0.1",
  "11.0.0",
  "11.0.1",
  "12.0.0",
  "2.0.0",
  "2.0.1",
  "9.0.0",
  "9.0.1"
]

I am assuming 11.1 matches the 11.0.1 SAR version?
Also I would like to suggest that this repository starts using semantic version release tagging just so it is easy to see what the changes are etc.

Yes that is correct. 11.1 matches the 11.0.1 SAR version.


Polishing the design of the project view

What's done:

fixed the layout of the ProjectView

@akuleshov7 I can't see the window with standard test suites selection after your latests PR,
may be you could also fixed it here?

Could you also please provide the screenshot of how it looks like now?
Major changes I already saw online, but we also talked about movements of save, cancel buttons, etc

attached

Did you try to make save/cancel buttons colorized (green, red)? Will it be more ugly, that's why you use default color?

exactly


⚠ Samsung has degraded performance

In 25e17c6, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2392 ms

Resolved: Samsung performance has improved in 4022f5c.


tcsetpgrp failure on freebsd

https://builds.sr.ht/~ach/job/66694
unrecoverable internal error: tcsetpgrp: Operation not permitted (errno=1)./test/cases/0008-builtins failed, exit-code=256

My feeling is that the calls to tcsetpgrp in fg-job must be failing because the job has terminated and then been pruned/waited for by (prune-complete-jobs).


added null check before initialising LatLng after receiving location …

…permission
Nearby crash fix
Fixes #1735 [Nearby crash when LatLng is null]
Description (required)
After receiving location permission from user, while fetching last known location, we used to initialise LatLng from last known location which could be fetched from either GPS_PROVIDER or NETWORK_PROVIDER. There was a null check on the one fetched from GPS_PROVIDER but not on the one fetched from NETWORK_PROVIDER.
Fixes #1735 [Nearby crash when LatLng is null]
Added a null check on the last known location fetched from NETWORK_PROVIDER
Tests performed (required)
Tested on {27  & emulator google pixel}, with {build variant, betaDebug}.
Screenshots showing what changed (optional)
NA

Codecov Report

Merging #1791 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1791      +/-   ##
=========================================
- Coverage    3.56%   3.56%   -0.01%
=========================================
  Files         186     186
  Lines        9329    9331       +2
  Branches      811     812       +1
=========================================
  Hits          333     333
- Misses       8974    8976       +2
  Partials       22      22

Impacted Files
Coverage Δ

...e/nrw/commons/location/LocationServiceManager.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a83da...faaaae0. Read the comment docs.


Add Travis-CI simulation using Docker

This patch adds support for simulating a Travis build using Docker.  It's useful for debugging why a test may be failing.  It's not a 100% simulation — I think tightvncserver brings in a window manager, so we don't use metacity as we are in the Travis build — but it works well enough.

Awesome! :fireworks:

Cool!

Travis published their converter for .travis.yml → build.sh.

FYI
http://security.stackexchange.com/questions/88790/is-it-safe-to-trust-a-docker-container
The short answer is no, we can't trust a container.


fix: error IAM role attachement when applying the module the first ti…

Description
fix #591
Ensure policies attachment are done with module managed resources in case the role is managed via terraform objects. This to avoid attachments are created before the role is created. Depends on does not support dynamics, sot not an option.
Migrations required
NO
Verification

[x] default example

@kayman-mk Tried to fix the issue, but the docker machine is not booting yet. I have not more time to dig in, will have a look later. Or feel free to dig in as well

@kayman-mk would you the option to rebase this PR

Merge conflicts solved.
I changed some more policies and tested the change. First apply succeeded. 👍

@kayman-mk accepted your suggestion, PR is good to go. Please can you review the PR?

@kayman-mk can you review the PR, should be ready to merge


[Suggestion] Allow decimal crf values

Hi, I was wondering if it would be possible to allow to introduce decimal crf values, for example when running sample-encode to check a specific crf value (--crf 19.5). Similar to how we can now introduce target vmaf in crf-search with decimal values (--min-vmaf 93.5).
There are 2 main reasons why this could be of interest.
First is that some encoders, such as svt-av1, seem more granular in their vmaf/crf progression, but some others, like x265, may have quite big jumps in vmaf values and predicted sizes with only 1 point difference in crf.
It is quite common in x264 and x265 to have files encoded with decimal crf values, and even an 0,5 crf difference may result in an encoded file size 10-15% smaller/bigger.
Handbrake and other encoders allow decimal crf values, so many of my current encodes do not have integer crf values, and I'm trying to establish equivalences between the new encoders, new encoding methods and my current files thanks to ab-av1, so being able to use decimal values would be helpful.
Secondly, for some files this way of treating crf as an integer could make ab-av1 have more difficulties searching the crf for a given target vmaf, having to test more crf values, thus taking longer to finish. Besides, sometimes the recommended final crf results in a vmaf value further from target than usual, because crf -1 would result in an vmaf value just a bit lower than the minimum required.
ab-av1 crf-search -e libx265 --enc x265-params=psy-rd=0.00 --pix-format yuv420p10le --min-vmaf 93 --vmaf
pool=harmonic_mean --vmaf n_threads=16 -i '.\testfile2.mp4' --preset 5

crf 32 VMAF 78.46 (7%)
crf 21 VMAF 96.99 (28%)
crf 23 VMAF 95.20 (22%)
crf 24 VMAF 94.07 (19%)
crf 25 VMAF 92.79 (17%)
crf 24 VMAF 94.07 predicted video stream size 243.46 MiB (19%) taking 15 minutes

So in this example targeting vmaf 93 or 94 would result in the same recommended crf 24. For min-vmaf 93 a crf value of 24,5 would have been better, and leave crf 24 to achieve vmaf 94.
Allowing decimal crf values could improve the internal logic of ab-av1 and offer more accurate vmaf results and higher encoding size savings.
Another example:
ab-av1 crf-search -e libx265 --enc x265-params=psy-rd=0.00 --enc x265-params=lookahead-slices=5 --pix-format yuv420p10le
--min-vmaf 92 --vmaf pool=harmonic_mean --vmaf n_threads=16 -i '.\test3.mp4' --preset 5

crf 32 VMAF 72.08 (7%)
crf 21 VMAF 93.96 (28%)
crf 22 VMAF 92.81 (24%)
crf 23 VMAF 91.48 (21)
crf 22 VMAF 92.81 predicted video stream size 318.87 MiB (24%) taking 13 minutes

That's 1,33 vmaf score difference just from crf 22 to 23, quite a bit.
What do you think of the idea? would it be possible?

Yep it's possible, perhaps starting with a single decimal place and using similar logic.
The main drawback is that svt-av1 only support integer crf so this work won't provide any value there.

Sounds good.
svt-av1 does not need decimal values anyway, they seem to have designed it to be usable across a greater range of crf with less impact in quality/vmaf.
In my testing, even 2-3 points difference in crf results only in about +-0,2 to 0,3 vmaf score difference in av1, but x265 and x264 are a complete different story, as shown above, they would benefit from decimal values.

The current crf search is really designed for svt-av1. But it could be generalized to allow configurable min, max and precision. That sounds worth a try though it will probably make the code more complex.

Trying to keep it as simple as possible initially, could it be possibe to allow decimal crf values in sample-encode just for x265 and 264? there is no crf-search involved in there, right? so it could be not as complicated to allow that?
It has just to encode using that given crf value and give a resulting vmaf score, as it does right now, but allowing to introduce a decimal crf value, right?
Could we start with this and then leave the more complex changes in crf-search for later?

#87 implements this. Needs some more testing.


Resolve missing Key.GetHashCode override

https://app.clickup.com/t/1qzu02x

@rowandh @quantumagi there is no way this would affect anything in the smart contract CLR?

@fassadlr , by fixing something, maybe, although I highly doubt it. Will let @rowandh make a call on this.

@quantumagi LOL I'm just super wary of any changes to the SC packages :P

@fassadlr , let me put this another way: The GetHashCode method has a fairly arbitrary implementation and it should be possible to change its results without affecting any other code - unless the code indirectly (or directly) using the method assumes a particular implementation. The SC code follows good programming practices so I doubt there would be issues. Maybe @rowandh can confirm.

If the order of items in a dictionary somehow makes its way into what's being written to chain then it will cause problems. I don't think that's possible in this case as the entropy of the internals of the patricia tree shouldn't affect contract execution, so I think this is fine.

Thanks @rowandh. Gustav we will need to look at what references this project as we will need to make sure that update NUgets for it.


Some items get stuck in construction forever

When I click on items rapidly, sometimes they get stuck in production forever. For example, it says I've had 1 grandma in interview for the last 10 minutes. I can no longer make grandmas. I suspect that if a request fails, we never reset the state to allow trying again.

https://github.com/marigold-dev/decookies/issues/46

Ah, my bad. Closing in favor of #46


What is txic?

Can you provide the source code or algorithm of txic?
Thanks

The txic is a golang program based on the unthermo library. txic retrived the XiC data for each fetures in input.
I can give you the golang sources of txic, but I m not going to put it on this repository.
if you write me an email I will send it to you.

Thanks for your reply. Your explanation is clear enough. I think the source code is not necessary if it is just a data reading module.
Thanks


On my OpenEx

The green verification change to yellow tick today. Am not happy what is the problem.in openex app oex point Satoshi

I have major problem in my OEX. My mobile device name Samsung A13. When i go to oex hub and click in OEX then it will be blank page.
What should i do right now?


Can't get $select, $sort, or $in to work via html request

Steps to reproduce

[x] Tell us what broke. The more detailed the better.

I have created a basic feathers controller using this feathers-prisma adapter and have tried to use various query parameters with no success. I have tried various queries:
$select
The official feathers.js documentation says this should work, but:
trying: http://<IP_ADDRESS>:5057/spaces?$select[]=organization_id,$select[]=space_id
gives error: "Invalid query parameter $select[]"

Looking through the code, it looks like the "[]" is not seen, so removing that gets us farther, but still have an error:
trying: http://<IP_ADDRESS>:5057/spaces?$select=organization_id,$select=space_id
gives error: "$select.forEach is not a function"

The query $select value didn't get converted to an array... Am I missing something?
$sort
$sort via the official feathers documentation:
trying: http://<IP_ADDRESS>:5057/spaces?$limit=2&$sort[created_at]=-1
gives error: "Invalid query parameter $sort[created_at]"

$in
trying: <IP_ADDRESS>:5057/spaces?organization_id[$in][]=60230961c459f31c3883c1f0&organization_id[$in][]=60230961c459f31c3883c1df
gives the error: Invalid `this.Model.findMany() ...

trying: <IP_ADDRESS>:5057/spaces?organization_id[$in]=60230961c459f31c3883c1f0&organization_id[$in]=60230961c459f31c3883c1df
gives the error: Invalid `this.Model.findMany() ...

[x] If you can, please create a simple example that reproduces the issue and link to a gist, jsbin, repo, etc.

spaces.class.ts
import { PrismaService, PrismaServiceOptions } from 'feathers-prisma';
import { Application } from '../../declarations';

interface Options extends PrismaServiceOptions {}

export class Spaces extends PrismaService {
  //eslint-disable-next-line @typescript-eslint/no-unused-vars
  constructor(options: Options, app: Application) {
    super(options, app.get('prisma'));
  }
}

spaces.service.ts
mport { ServiceAddons } from '@feathersjs/feathers';
import { Application } from '../../declarations';
import { Spaces } from './spaces.class';
import hooks from './spaces.hooks';

// Add this service to the service type index
declare module '../../declarations' {
  interface ServiceTypes {
    'spaces': Spaces & ServiceAddons<any>;
  }
}

export default function (app: Application): void {
  const options = {
    model: 'spaces',
    client: app.get('prisma'),
    paginate: app.get('paginate')
  };

  // Initialize our service with any options it requires
  app.use('/spaces', new Spaces(options, app));

  // Get our initialized service so that we can register hooks
  const service = app.service('spaces');

  service.hooks(hooks);
}

prisma model
model spaces {
  space_id          Int       @id @default(autoincrement())
  name              String?   @db.VarChar
  created_at        DateTime? @db.Timestamptz(6)
  description       String?
  organization_id   String?   @db.VarChar
  primary_color     String?   @db.VarChar
  secondary_color   String?   @db.VarChar

  @@index([organization_id], map: "spaces_link_organization_id_index")
}

Expected behavior
$select
Should select return only the organization_id and space_id's for the records.
$sort
Should sort by created_at descending
$in
Should return the records with the ids in the given array of ids.
Actual behavior
Errors:
Invalid query parameter, $select.forEach is not a function, or Invalid this.Model.findMany() ...`
System configuration
Tell us about the applicable parts of your setup.
This is a bare bones feather setup with no hooks. Using feathersjs-serverless.
Module versions (especially the part that's not working):
"dependencies": {
    "@feathersjs/configuration": "^4.5.15",
    "@feathersjs/errors": "^4.5.15",
    "@feathersjs/express": "^4.5.15",
    "@feathersjs/feathers": "^4.5.15",
    "@feathersjs/primus": "^4.5.15",
    "@feathersjs/socketio": "^4.5.15",
    "@feathersjs/transport-commons": "^4.5.15",
    "@prisma/client": "^3.15.2",
    "aws-serverless-express": "^3.4.0",
    "body-parser": "^1.20.1",
    "class-transformer": "^0.5.1",
    "class-validator": "^0.13.2",
    "compression": "^1.7.4",
    "cors": "^2.8.5",
    "ejs": "^3.1.8",
    "express": "^4.18.2",
    "feathersjs-serverless": "^0.3.1",
    "feathers-prisma": "^0.6.0",
    "helmet": "^5.1.1",
    "install": "^0.13.0",
    "reflect-metadata": "^0.1.13",
    "rimraf": "^3.0.2",
    "rxjs": "^7.5.7",
    "serve-favicon": "^2.5.0",
    "serverless-express": "^2.0.12",
    "serverless-http": "^3.1.0",
    "winston": "^3.8.2",
    "ws": "^8.11.0"
  },

NodeJS version:
v16.18.0
Operating System:
OS/X M1
Browser Version:
Firefox, Chrome, Safari
React Native Version:
N/A
Module Loader:
N/A

I started it up without "feathersjs-serverless" and it seems to behave correctly. There might be some nastiness around parsing query parameters when that module is in between the adapter, feathers and the request coming in.


not starting after update to core-2021.11.3

Today after updating the core of home assistant to core-2021.11.3 the toyota integration does not start anymore.
This occurs even after restarting the server, rebooting the host or reinstalling the integration.
Following errors are logged:
Logger: homeassistant.config_entries
Source: custom_components/toyota/init.py:62
Integration: Toyota Connected Services (documentation, issues)
First occurred: 14:33:03 (1 occurrences)
Last logged: 14:33:03
Error setting up entry<EMAIL_ADDRESS>for toyota
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 304, in async_setup
result = await component.async_setup_entry(hass, self)  # type: ignore
File "/config/custom_components/toyota/init.py", line 62, in async_setup_entry
client = MyT(
File "/usr/local/lib/python3.9/site-packages/mytoyota/client.py", line 55, in init
raise ToyotaLocaleNotValid(
mytoyota.exceptions.ToyotaLocaleNotValid: Please provide a valid locale string! Valid format is: en-gb.
Kind regards
Kapa

Duplicate of #75
Follow #75 for updates 😊


feat(HMS-1897): add export to csv btn to instances table

This adds an export to csv button to the instances table

vs

I took the design from Patternfly guidelines:
https://www.patternfly.org/2023.02/components/table/design-guidelines
The button and pagination are under the Toolbar component
We can use a kebab dropdown instead of a button action, but I don't think we have another action to add.

I am not expert, but I think that something more minimal like a download button would suffice

Great job trying to find the answers in PF guidelines, but this was a tricky one.
I talked to the design team about this as I wasn't sure if my solution was correct.
We ended up voting for this:
The button is located under the table - it follows an empty state pattern (actions are at the bottom) and also an eye pattern (content leading all the way down).  If you want we can talk about the button being secondary, but I don't think we want to make it that prominent.
Also, be aware that an icon is different.

Thanks @MariSvirik,
My concern is when there are multiple instances to scroll in order to see the button at the bottom, but as you mention, there's a pagination for ease.
updated:

/retest

/retest

/retest

/retest

/retest

/retest

Thank you @amirfefer ! :tada:


fix: open staff link in new tab

closes https://github.com/mix-it/mixit/issues/96

If this is merged, we now lack the same behavior on sponsors external links, as said here: https://github.com/mix-it/mixit/issues/96#issuecomment-280689167

Ok I will do it there as well.


Add support for Azure Goverment storage

Description
This pull request introduces a configurable Azure Storage Endpoint Suffix in the Druid Azure-Extensions.
Release note
Added support for Azure Government storage in Druid Azure-Extensions. This enhancement allows the Azure-Extensions to be compatible with different Azure storage types by updating the endpoint suffix from a hardcoded value to a configurable one.

Key changed/added classes in this PR

AzureAccountConfig
AzureUtils
AzureDataSegmentPuller
AzureStorageDruidModule

This PR has:

[x]  been self-reviewed.
[x] added documentation for new or modified features or behaviors.
[x] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[x] been tested in a test Druid cluster.

thank you for your contribution @nozjkoitop


Update Web API templates to use new Web API conventions

We are adding some new Web API specific conventions that we will need the Web API project and time templates to react to.
We are adding [ApiController] attribute as the way to opt-in to new API specific conventions and behaviors that are tuned around best practices for APIs.
This will include:

Automatically responding with a 400 when validation errors occur (using https://tools.ietf.org/html/rfc7807)
Infer smarter defaults for action parameters ([FromBody] for complex types, [FromRoute] when possible, otherwise [FromQuery])
Web API controllers should derive from ControllerBase (see https://github.com/aspnet/templating/issues/82)

Added this to the list above:

Web API controllers should derive from ControllerBase (see https://github.com/aspnet/templating/issues/82)


AppLensV2 : Account for multiple stamps for a hostname in UI

Corresponding UI change for https://github.com/ShekharGupta1988/AppLensV2/issues/142

@hforeste - this is taken care of right with your recent PR?
If thats the case, Feel free to close this


Design a good logo

Is your feature request related to a problem? Please describe.
Design a good logo for the app
Describe the solution you'd like
Design a good logo for the app
Describe alternatives you've considered
Design a good logo for the app
Additional context
No response

@ashavijit i would like to work on this

@wasimreja assigned.


Allow setting of container scale with ENV variable

:rocket: deployment of nhsuk/register-with-a-gp-beta-web succeeded (http://register-with-a-gp-beta-web-pr-227.dev.beta.nhschoices.net)


Update indigenous place names after they have been updated in geospatial-vector-veracity repo

This ticket may be superseded by work (TBD) to move the community list from an included asset into one that we fetch from the API.  If so, this will be done implicitly by that work and this ticket can be closed.

Hey I think we can close this one!


In query route  error

Bug Report
Which version of ShardingSphere did you use?
4.0.0.M1
Which project did you use? Sharding-JDBC or Sharding-Proxy?
sharding-proxy
Expected behavior
sql：
 select * from customer t where party_id in(8001,8002,8003,8004);

config：
customer:
  actualDataNodes: ds_0.customer_000${0..1},ds_1.customer_000${2..3}
  databaseStrategy:
    inline:
      shardingColumn: party_id
      algorithmExpression: ds_${(party_id % 4).intdiv(2)}
  tableStrategy:
    inline:
      shardingColumn: party_id
      algorithmExpression: customer_${"000" + (party_id % 4)}

route result error:
 ds_0 ::: select * from customer_0000 t where party_id in(8001,8002,8003,8004);
 ds_0 ::: select * from customer_0001 t where party_id in(8001,8002,8003,8004);
 ds_0 ::: select * from customer_0002 t where party_id in(8001,8002,8003,8004);
 ds_0 ::: select * from customer_0003 t where party_id in(8001,8002,8003,8004);
 ds_1 ::: select * from customer_0000 t where party_id in(8001,8002,8003,8004);
 ds_1 ::: select * from customer_0001 t where party_id in(8001,8002,8003,8004);
 ds_1 ::: select * from customer_0002 t where party_id in(8001,8002,8003,8004);
 ds_1 ::: select * from customer_0003 t where party_id in(8001,8002,8003,8004);

The correct routing result should be as follows：
 ds_0 ::: select * from customer_0000 t where party_id in(8001,8002,8003,8004);
 ds_0 ::: select * from customer_0001 t where party_id in(8001,8002,8003,8004);
 ds_1 ::: select * from customer_0002 t where party_id in(8001,8002,8003,8004);
 ds_1 ::: select * from customer_0003 t where party_id in(8001,8002,8003,8004);

@guowdxp it compute availableTargetDatabases using sharding condition, then use each availableTargetDatabases and sharding condition value compute actual table, it cause  datasource Cartesian with actual  table, when database sharding column is the same as table sharding column ,it execute  more actual sql, but the result is correct.  StandardRoutingEngine#routeDataSources method return a Map<String,List>, key is datasource name, value is this datasource RouteValues
, doSharding(availableTargetDatabases, databaseShardingValues) , split databaseShardingValues ，each databaseShardingValues with one element，StandardRoutingEngine#routeTables(final TableRule tableRule, final String routedDataSource, final List tableShardingValues, Map<String,List> datasourceRouteValues) ,when  database sharding column is the same as table sharding column,  use datasourceRouteValues compute actual tables

We need to consider about some new design to enhance route results

maybe we can provide a user defined filter to get the corrected  combination result.

or we can use actualDataNodes to filter the Cartesian result

duplicate with #2193


Test travis conf

Test that travis can deploy to 'edge' channel of Snapcraft store.

oops, meant to test fork and not request pull to real master.


Crawl prerendered pages without regex hackery

This is an alternative to #2923. It prevents the sort of bugs that can arise when you're extracting attributes with regex...
<img data-something=" src=" crossorigin src="dog>cat.png"> crazy link </img>

...without the overhead of fully parsing the HTML. parse5 is great, but it's much too large to add on a whim, and does far more than we need. This implementation takes a tiny fraction of the size (it adds less than 100LOC) and is roughly 3x faster (I'm sure someone suitably motivated could make it faster still), which is important in this context.
Fixes #2645 and #2742.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[x] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@Rich-Harris in packages/kit/src/core/adapt/prerender/fixtures/large-page/input.html can we also add some <source> and <img> tags with the attributes in different places to ensure that #2742 never happens again (will protect us from regressions if we ever decide to move to parse5 or something else later)


DEP: deprecate stats.betai and stats.chisqprob

closes gh-641: closes gh-642

@rgommers, @josef-pkt, @ev-br I couldn't find much usage of stats.betai outside of scipy forks so I included it to be deprecated.
Regarding stats.chisqprob and its documentation, I reviewed special.chdtrc and it seems to cover everything in it, with differences in phrasing perhaps but I didn't see anything that stroke me as missing.
The mailing list has been notified of the possible deprecation. Let's see what they have to say.

It would help users if the deprecation message points to the functions which should be used instead.
Also, the docstrings are not updated mentioning the deprecation and giving more informations on the reasons, how the function calls can be replaced and when the function will be removed definitely.

@sebix I did forget to add it to the release notes, thanks for pointing it out. I added the message to the functions to use instead.
It should be a regular deprecation cycle, so I estimate they might be deleted somewhere around 0.19; I will mention this on the mailing list thread.

Mailing list message: http://article.gmane.org/gmane.comp.python.scientific.devel/19851. >1 week with no objections, so after comments are addressed I think that this can be merged.

please review

Merged, thanks @aeklant


[1.21.1] whitelist command fails 90% of the tme when NoChatReport mod is present

Modloader
NeoForge
Minecraft Version
1.21.1
Modloader Version
neoforge 21.1.66
No Chat Reports Version
2.8.0
Modpack Info
ATM10
The latest.log File
No response
Bug Description
Hello
When NoChatReports is present I have to run the same  "whitelist add mcname" command multiple times sometimes, 5 to 6 times until eventually it works. When it doesn't it tells me the player name does not exist.
Thanks in advance,
Jin
Steps to Reproduce
Assuming it's reproducible by itself and not just in ATM10

Run server files which include nochatreport mod
try to run whitelist commands in console, some of them will succeed, some of them won't.

Other Information
No response

I've encountered this issue as well on Fabric for 1.20.1.  I can't say for certain if No Chat Reports is the cause of the problem (I never made the connection, and this is a live server, so I'm limited in my ability to test it on my end), but I seem to recall the issue started occurring around the time I added this mod to our server.


GUI Doesn't Play Nicely with matplotlib on OS X

When a plugin calls show on a matplotlib graph, Binary Ninja reopens any child windows (context menus, open file dialogs, etc) that have previously been clicked on, as described on Slack on Oct 9 '18.
The following plugin is sufficient to reproduce the issue on OS X. I haven't tried it on other platforms. Note that this must be run from the plugins folder, as pasting it into the script console causes Binary Ninja to crash.
from binaryninja.plugin import PluginCommand
import matplotlib.pyplot as plt

def do_the_thing(*args):
    plt.plot(1,1)
    plt.show()

PluginCommand.register_for_function("Bug out the GUI", "What it says", do_the_thing)

So this is just a really bad implementation in matplotlib and not really something we can or will fix. Specifically:
https://github.com/matplotlib/matplotlib/blob/5e20d9baaed6f997a6ab73ea25add24177a82117/src/_macosx.m#L2358
Their macosx backend specifically enumerates all windows and shows them. They'll never play nice working embedded with that code.


Added a PHP category to free-podcasts-screencasts-en.md

Added a PHP category and two podcasts (corrected alphabetically) to free-podcasts-screencasts-en.md.

Apologies! Done. Thank you!

Thank you!


[BUG] Missing information on Game Page

Describe the bug
When we open the game from the download page link the page opens with missing information
Steps to Reproduce

Open downloads tab
2.Click on the title link to go to the game page
3.Get redirected to the page with missing information

Expected behavior
Open regular game page
Screenshots

Operating System
Win11
Hydra Version
v1.2.0
Additional Information
Upon the first attempt to download the game my defender got triggered, so some file for the launcher might be missing, if that's the case i'm closing the issue, but is a little bug I noticed while monitoring my downloads.

read the #317


[Obsolete] look for terms that are tagged ‘obsoletion candidate’

Fixing these will help address #834
Adding Shahim, as I am not sure if I know how to filter all the terms that are tagged 'obsoletion candidate'

@matentzn said he would help generate this list (thank you!) Once we have the list, I'll post it here for folks to review.

@nicolevasilevsky I think @cmungall  pretty extensive reports already cover this:
https://github.com/monarch-initiative/mondo/blob/master/reports/obsoletion-candidates.tsv
Isnt this what you are looking for?

this is great, thank you @matentzn!

I sorted this list by label:
https://github.com/monarch-initiative/mondo/blob/master/reports/obsoletion-candidates-sorted.tsv

Google spreadsheet here

@matentzn could you please regenerate this list? Looks like many terms have already been obsoleted. Thank you!

This is how to do this:
sh run.sh report-query-obsoletion-candidates

Can you add a section to the editors doc how to generate reports?
How to generate reports
Reports are generally created like this:
sh run.sh make report-query-%

For example, the following command...
sh run.sh make report-query-obsoletion-candidates

will run this:
robot --catalog catalog-v001.xml query --use-graphs true -i mondo-edit.obo -f tsv --query ../sparql/reports/obsoletion-candidates.sparql reports/report-obsoletion-candidates.tsv

Which will generate a TSV report here: reports/report-obsoletion-candidates.tsv.
The only requirement for a report is, that a suitable SPARQL query can be found in ../sparql/reports/, for example, ../sparql/reports/obsoletion-candidates.sparql.
If you want to create your very own report, you can

tweak an existing command, for example using Ubergraph (https://api.triplydb.com/s/YfJCi9mrR)
Save the query as a .sparql query in ../sparql/reports/, for example, ../sparql/reports/my-query.sparql.
Run sh run.sh make report-query-my-query to generate the report as above.

Note that the above does not cover automated upload to Google docs (if you want to learn that, put it on a QC meeting agenda).

thank you, will do!

Updated spreadsheet is here

reviewed the list and created separate tickets for this


External Angular 2 stylesheets and templates cause 404 errors in browser

Despite this brunch is closed https://github.com/systemjs/builder/issues/611
the issue is not solved.
buildStatic not working properly with external css/html
Few details:
My app is under ./source/app
and external html file (for example) is
/source/app/something/something.component.html
buildStatic WITHOUT 'encodeNames: false' lead to 404 error,
loading html external file from root like '/something.component.html'
buildStatic WITH 'encodeNames: false' it also lead to 404 but in a different way:
it tries to load '/source/app/something/something.component.html
everything is working fine when I use SystemJs (without systemjs builder). But is it suitable only for dev.
Is it the only way to solve it - inline html/css files? Or move to webpack?
P.S. Relative paths are important for aot compilation so ... any ideas?
Thank you

+1
Having the same issue here. Have you found the solution in the mean time?

@dicbrus Found a solution. Don't use buildStatic() which creates self-executing bundle.
use bundle() instead. And keep the same

@jzaric
I suppose it work because of loading all hundreds of non-bundled scripts, can you check it: how much scripts it loads?

I suppose it work because of loading all hundreds of non-bundled scripts, can you check it: how much scripts it loads?

It does not make individual requests because the bundle populates the loader cache.

@aluanhaddad
I tried as @jzaric advised, and systems js tries to load all files one by one: main.js, app.module.js ... and so on
can you show systemjs.config.js? Maybe you places there some changes?

It looks like you have the incorrect order.
Include the configuration script before the bundle.

@aluanhaddad
no, it doesn't help, app tried to load all its files one by one...

Since bundles are deployable, you likely have other problems in your configuration.

I'm loading bundle before configuration script as posted earlier.
It loads 43 files altogether for the whole app. No compiled .js files or anything from /node_modules is loaded separately.
Config file follows...
/**
 * System configuration for Angular samples
 * Adjust as necessary for your application needs.
 */
(function (global) {
    System.config({
        defaultJSExtensions: true,
        paths: {
            // paths serve as alias
            'npm:': 'node_modules/'
        },
        // map tells the System loader where to look for things
        map: {
            // our app is within the app folder
            app: './',
            // angular bundles
            '@angular/core': <EMAIL_ADDRESS>            '@angular/common': <EMAIL_ADDRESS>            '@angular/compiler': <EMAIL_ADDRESS>            '@angular/platform-browser': <EMAIL_ADDRESS>            '@angular/platform-browser-dynamic': <EMAIL_ADDRESS>            '@angular/http': <EMAIL_ADDRESS>            '@angular/router': <EMAIL_ADDRESS>            '@angular/router/upgrade': <EMAIL_ADDRESS>            '@angular/forms': <EMAIL_ADDRESS>            '@angular/upgrade': <EMAIL_ADDRESS>            '@angular/upgrade/static': <EMAIL_ADDRESS>            // other libraries
            'rxjs': 'npm:rxjs',
            'angular-in-memory-web-api': 'npm:angular-in-memory-web-api/bundles/in-memory-web-api.umd.js',
            // bootstrap
            'moment': 'npm:moment/moment.js',
            'ng2-bootstrap/ng2-bootstrap': 'npm:/ng2-bootstrap/bundles/ng2-bootstrap.umd.js',
            // lodash
            'lodash': 'npm:lodash/lodash.js',
            'ng2-validation': 'npm:ng2-validation/dist/index.js',
            // text-mask
            'angular2-text-mask': 'npm:angular2-text-mask/dist/angular2TextMask.js',
            'text-mask-core': 'npm:text-mask-core',
            'text-mask-addons': 'npm:text-mask-addons'
        },
        // packages tells the System loader how to load when no filename and/or no extension
        packages: {
            app: {
                main: './main.js',
                defaultExtension: 'js'
            },
            rxjs: {
                defaultExtension: 'js'
            }
        }
    });
})(this);

Gulp bundle task
gulp.task('bundle', function () {
    var b = new builder(distDir, 'systemjs.config.js');
    return b
        .bundle(distDir + '/main.js', distDir + '/bundle.js', { minify: true, sourceMaps: true })
        .then(function () {
            console.log('Build complete');
        })
        .catch(function (err) {
            console.log('Build error');
            console.log(err);
        });
});

Though it might be important to note that the bundle itself is 1.1mb I guess there is a way to optimize it but didn't have much time to work on it.

That size is pretty spot-on for an angular bundle that includes all of the UMD dependencies and all of rxjs together with a small application.

@aluanhaddad Tnx for the info. Good to know.

@jzaric
I still don't understand:  after bundling does your application load file main.js (and other app files) as it shown in systemjs.config.js?
Or it loads only bundle.js file?
thank you

@dicbrus No. See the image bellow. These are all js files that get loaded. Only what I included in html file itself. Also, bundle is relatively small when gzipped.

@jzaric thank you. I don't succeed to get such behavior but try to understand what I'm missing.

@dicbrus perhaps we might get to the bottom of this more quickly given your config, systemjs version, and builder version


Homepage redesign.

This PR follows up #205 redesigns the homepage using the Figma design.
Laptop Screenshot

Mobile Screenshot

@flickz can you check the tests?

Codecov Report

Merging #206 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #206   +/-   ##
=======================================
  Coverage   50.22%   50.22%
=======================================
  Files          14       14
  Lines         227      227
  Branches       41       41
=======================================
  Hits          114      114
  Misses         91       91
  Partials       22       22

Impacted Files
Coverage Δ

src/components/Upload.js
48.27% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b96a96...5a4296a. Read the comment docs.

the logo in the top bar looks the wrong size and misaligned

The actual size on the design is 211.76 x 48, I used the 200 x 45, I wasn't sure it would make obvious difference in look, I'll change that now.

the icons in the footer are looking too big

The current size is similar to the design, 48 x 47.89 which looks like below:

Maybe I can reduce it to 30 x30 which would look like this:

What do you think?

@flickz If I look at Figma, this is what I see.
https://www.figma.com/file/oNb9TlYCPcKABl4brBACDI/BYS.COM-XX1-%2F-Lab?node-id=0%3A1

Compared to the current version.

Why are we not seeing the same thing?

Oh I just realized I did not export the actual icons used in the figma design, I used the existing icons in the img/.

Better?

@flickz in the screenshot you shared, the icons are not aligned

Okay, 🙂  I think something is definitely wrong with my eyes at this point regarding alignments.

The top bar is still not fixed. It still looks like my screenshot at  https://github.com/opencollective/backyourstack/pull/206#issuecomment-530823464 can you check?

Be aware, I updated the copy on this branch.

@znarf Can you check it now?

It's really different from design. Why is that?

Not surely exactly why because I tried to set the width and height to values from the figma design or maybe I should leave both out and let it be naturally as exported.
Doing that now, looks like below, does it look better?

It seems so. But it's better that you check by yourself that it matches the design. And double check on automated deployments that it looks good.

I also I think the extension shows a significant difference, I've been using svg exported file but this is png feels better I think.

I think it's a mistake to move out of SVG, this is our best shot for high definition devices and fallback flawlessly.

I think this feels better now
https://backyourstack-wqmxluescv.now.sh

@flickz the height is bigger than the design

The actual height on figma is 80px, I've set it to that now.

the logo is not the same as design, look at the details in it
the logo is 1px too high to the top
also the height is 1px too much, look at the border on the bottom

the logo is not the same as design, look at the details in it

I'm aware of the details from the logo and I think I've pointed out this might I've got something to do with the exported file format. Look at these 3 logos
Screenshot from figma directly

Screenshot of the logo as exported svg file

Screenshot of the logo as exported png file

Of course the png looks more accurate but blurry. The svg looks sharp but isn't accurate especially the symbol on the logo. Took away some cool background details in the logo.
This was also the initial issue I had with the homepage background image, remember when you initially pointed out the background image looked weird and ugly on good screens, it was because of the svg format, I had to do a little trick of reducing the background opacity to make it look better.
I've gone through figma documentation and I think their exported svg file has some features not supported. According to them, for svg,

We do not export Background Blurs.

Which I think is the thing going on with the logos not matching. Here is their doc link
https://help.figma.com/article/206-export-settings
@znarf I'm really sorry this is taking longer than expected especially having to correct simple details I missed. I can't imagine how frustrating that must have been for you. I feel really bad at this point missing these little details but it has been helpful for me so far ahead of other design works to come.
For the remaining 2 things on you listed, the logo top pixel and the top bar height, I've fixed it. Reduced both by 1px;

@flickz thank you for the explanations. Let's keep it as svg and ask the design team if they can export a high fidelity version for us.
@cuiki @raulgrafico can you help us exporting the BackYourStack logo so that it looks like in Figma? Because right now it seems it's missing some background blurs. See: https://github.com/opencollective/backyourstack/blob/design/homepage/src/static/img/backyourstack-logo.svg


Creature ID's, can we stop referring to them as Double?

Some places in the code, we refer to creature IDs as Double (for instance, in MeleeAttack->targetID and TypeTileInfo->dblID), and some places, we refer to creature IDs as Long, aka Int64 ( for instance, ReadRedSquare ) , but in fact, it's neither of those, a creature ID, as defined by the client and the tibia protocol,  is an Int32... in some places, we have to do CLng(doubleID)  and other places, Cdbl(LongID) because of this.. could we just drop that nonsense and agree on a single data type for creature IDs? (my vote would go to Int32)

also in Memory_ReadLong , judging by the name, you'd think it would read a Long, aka Int64, from memory, but it reads an Int32 from the client, and convert it to Int64, and return that..

It might not be the optimal solution if you only think in saving a bunch of bytes in memory, but I prefer to handle creature IDs as double to avoid some weird problems with vb6 in the limit cases of the long type. If you see it being handled as something different in some points that it is usually because I am required to send it as long for some low level windows apis. You better not make changes there as you have very high chances of breaking something. It is very dangerous. Always do a lot of tests in critical changes like this, else I will get a flood of complains from users. For now I have peace there and I really prefer to don't fix what is not broken.

fair enough. also damn, i've been reading the wrong documentation; turns out, Long is Int32 in VB6, while it's Int64 in VB7+, my bad

yes, that is right:
VB6 long is 4 bytes signed (-2147483648 to<PHONE_NUMBER>)
However Tibia IDs is C++ 4 bytes unsigned (0 to<PHONE_NUMBER>)
So you get problems with big ids unless you store them in a double because I am afraid there is no unsigned 4 bytes type in VB6.


Support e masking

Rust tests are OK, let's check the CI now. It seems there are traces of the waf->contentfilter migration in Python files, so let's hope all goes well.

Thank you!


Gltf with CESIUM_primitive_outline extension render error

Sandcastle example:
test example
Browser:
Microsoft Edge v102.0.1245.39
Operating System:
win11

Cesium3DTileset showOutline: false

Cesium3DTileset showOutline: true

tileset with glb model:
data.zip

Hi @chenxx08,
Thanks for reporting this bug! We're working on adding support for the CESIUM_primitive_outline extension to ModelExperimental in #10338, so hopefully we can fix this in one go. We'll keep you updated.

Just to give an update on this, I'm currently working on CESIUM_primitive_outline in ModelExperimental this week. I can reproduce the problem in ModelExperimental now, so later this week I'll look into what's going wrong with the index generation.

Update:

My past comment was incorrect, I had forgotten to set the enableModelExperimental flag in my local Sandcastle :sweat_smile:. The good news is it renders correctly! Local Sandcastle (requires the model-experimental-outline branch from #10506 for now)

I also discovered the source of this bug. In the code for handling outlines for the old Model (ModelOutlineLoader), a comment mentioned making an assumption that each buffer view only contains a single range of vertices. The new implementation in #10506 does not make this assumption and thus renders correctly.

@chenxx08 If you want to use the current Model implementation, try moving the second primitives' attributes to their own buffer view in the glTF, that might fix the problem. However, by the August release we plan to remove Model and rename ModelExperimental -> Model (see #10346). The fix in #10506 will be included.

Hi @chenxx08,
We just merged #10506 into main, so this bug shouldn't appear while using outlines in ModelExperimental. Let us know if any other rendering errors come up!


optimize encoder and adjust some config

What problem does this PR solve?
optimize the encoder preformance
What is changed and how it works?

Apply https://github.com/pingcap/tidb/pull/18102 this optimization to make chunk encoder run faster.
adjust some config's default value to reduce the memory usage:

set default range-concurrency to 16. 16 is big enough to take full use of a 10Gb(1.25GB) bandwidth network. So it will fit the physical environment in most case.
set default send-kv-pairs to 32768. This can reduce lightning peak memory usage from 19G to 10G without performance loss.
remove the misleading comment for sorted-kv-dir.
Decrease the batch-size from default<PHONE_NUMBER>00(100G) to 10G in my benchmark can make about 6% performance increase

Benchmark result:
Import 14k warehouse (1007G) data with 1 lightning in our idc machines. With following config:
[lightning]
index-concurrency = 4
table-concurrency = 4

[checkpoint]
enable = false

[tikv-importer]
backend = "local"
range-concurrency = 16
send-kv-pairs = 32768

[mydumper]
batch-size =<PHONE_NUMBER>0

with current master branch it takes 2h27min. With this pr it takes 2h6min.
Import 14k warehouse tpcc data with importer backend takes 2h9min.
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects
Related changes

/run-all-tests

/run-all-tests


Adjust Opacity on Log Streaming BgColor

Fixed #27
Adjust opacity on the log streaming component's background.

/brig run

Thanks @DhairyaBahl!


Implement example of limits and quota

I thought the limit and quotas would be a good best practice. We can make it high but I'm leaning to putting in something so that it's just not unbounded.
Moving from https://github.com/openshift-s2i/s2i-aspnet/issues/13

What is the standard with other RH examples?

Memory limit example: https://github.com/openshift/rails-ex/blob/master/openshift/templates/rails-postgresql.json#L460
This example does not persist data across container restarts, so quota (as in disk-space quota) does not make sense, IMHO.

I've just noticed that if created via the template a memory limit is in place:
https://github.com/redhat-developer/s2i-dotnetcore-ex/blob/master/templates/aspnet-s2i-template.json#L203
Not sure what else there is to do. I'm closing this for now. Feel free to reopen if you think there is still something missing.


WIP: use less memory by downloading to sparse file

pget has a problem that it needs to download everything into memory along each of the different parallel connections before finally saving everything to disk.  This has two consequences:

pget needs to consume at least as much memory as the size of the downloaded file
pget cannot begin writing to disk until all the bytes have been downloaded from source

I had a thought that we could precreate a sparse file of the correct length by using the os.Truncate(size) call.  Then each goroutine can write to different offsets within the same file, in parallel.
I tested this locally on macOS and I was able to download a 308MB file with pget's memory usage only reaching 26MB.
This commit is a WIP because I've commented out the untar stuff to keep the proof of concept simple.  We should restore (or deprecate?) that functionality before merging this.  We should also do more extensive performance testing.

very cute use of truncate

Another thing we might want to do here before it gets merged is write to a .partial file and only rename to the final dest filename once we've downloaded all the bytes, to avoid leaving a half-downloaded sparse file in the wrong place if pget gets interrupted.

I've reimplemented extract-tar and done the .partial thing. Ready for review.

Also, related but not blocking, we should implement testing :)


Simplify applications through action context separation

In the previous RM version, resources could interfere with each other and security measures were taken to protect against exploits by gossiping nodes and solves, i.e., ResourceRelationship message and signing.
Most likely, these measures can now be removed and much simpler pattern matching can be used.
Task https://github.com/anoma/anoma-app-lib/issues/38 must be finished beforehand.

Although the apps were refactored, the authorization mechanisms couldn't be simplified as much as intended.


How to setup a docker swarm cluster with AWS ubuntu machine

I am getting the bellow error. while creating and running container in swarm cluster.
  Creating network "ubuntu_default" with the default driver
        ERROR: 500 Internal Server Error: failed to parse pool request
    for address space "GlobalDefault" pool "" subpool "":
    cannot find address space GlobalDefault
    (most likely the backing datastore is not configured)

The steps I followed.

Created a One VPC and added a security group with allowing all the port numbers.

Created a 3 ubuntu machine in AWS (manager, slave1,slave2)

First started the Consul node with the below command
docker run --restart=unless-stopped -d -p 8500:8500 -h consul1 progrium/consul -server -bootstrap

Then started a swarm manger on the same machine
docker run --restart=unless-stopped -d -p 3375:2375 swarm manage consul://<IP_ADDRESS>:8500

Then added the 2 slaves to it
docker -H=tcp://slave1ip:2375 --restart=unless-stopped run -d swarm join --advertise=slave1ip:2375 consul://<IP_ADDRESS>:8500
docker -H=tcp://slave2ip:2375 --restart=unless-stopped run -d swarm join --advertise=slave2ip:2375 consul://<IP_ADDRESS>:8500

Added consul store in swarm manger machine
DOCKER_OPTS="--cluster-store=consul://<IP_ADDRESS>:8500 --cluster-advertise=eth0:2375 -H tcp://<IP_ADDRESS>:2375 -H unix:///var/run/docker.sock"

docker info

Containers: 8
 Running: 2
 Paused: 0
 Stopped: 6
Images: 4
Server Version: swarm/1.1.3
Role: primary
Strategy: spread
Filters: health, port, dependency, affinity, constraint
Nodes: 2
 ip-172-31-19-203: slave1ip:2375
  └ Status: Healthy
  └ Containers: 4
  └ Reserved CPUs: 0 / 1
  └ Reserved Memory: 0 B / 1.018 GiB
  └ Labels: executiondriver=native-0.2, kernelversion=3.13.0-74-generic, operatingsystem=Ubuntu 14.04.4 LTS, storagedriver=aufs
  └ Error: (none)
  └ UpdatedAt: 2016-03-29T11:32:39Z
 ip-172-31-42-220: slave2ip:2375
  └ Status: Healthy
  └ Containers: 4
  └ Reserved CPUs: 0 / 1
  └ Reserved Memory: 0 B / 1.018 GiB
  └ Labels: executiondriver=native-0.2, kernelversion=3.13.0-74-generic, operatingsystem=Ubuntu 14.04.4 LTS, storagedriver=aufs
  └ Error: (none)
  └ UpdatedAt: 2016-03-29T11:32:21Z
Plugins:
 Volume:
 Network:
Kernel Version: 3.13.0-74-generic
Operating System: linux
Architecture: amd64
CPUs: 2
Total Memory: 2.035 GiB
Name: 257d542e5b26

export DOCKER_HOST=tcp://<IP_ADDRESS>:3375

docker run hello-world

it was excuting perfectly. and I can see the containers creating slaves with spread strategy
Now I just try to create
docker-compose.yml
version: "2"
services:
       web:
            image: busybox

docker-compose up

this says the following error.
 Creating network "ubuntu_default" with the default driver
    ERROR: 500 Internal Server Error: failed to parse pool request
for address space "GlobalDefault" pool "" subpool "":
cannot find address space GlobalDefault
(most likely the backing datastore is not configured)

It giving the same error for

docker network create -d overlay myapp

so the problem is , this is not creating overlay network , with my current configuration.
How to resolve this error?

To enable overlay network, you need to set cluster-store and cluster-advertise on all the Docker daemons that want to participate the overlay networking. Make sure you open corresponding network ports for VXLAN. See https://docs.docker.com/engine/userguide/networking/dockernetworks/ .
To create an overlay network, you configure options on the daemon on each Docker Engine for use with overlay network. There are three options to set:

Option	Description
--cluster-store=PROVIDER://URL   Describes the location of the KV service.
--cluster-advertise=HOST_IP|HOST_IFACE:PORT  The IP address or interface of the HOST used for clustering.
--cluster-store-opt=KEY-VALUE OPTIONS   Options such as TLS certificate or tuning discovery Timers

@vimalprakashts I have followed you steps to create a small swarm cluster. But for step5, even though there is docker created and running on slave host, the master can not get info about them.
The only slave added successfully into the swarm cluster is the docker host which have swarm master running on.
And the log for the container running on slave docker host output the following msg, do you have any idea about the error for my scenario?
time="2016-03-30T09:35:44Z" level=info msg="Initializing discovery without TLS"
time="2016-03-30T09:35:44Z" level=info msg="Registering on the discovery service every 1m0s..." addr="<host_ip>:2375" discovery="consul://<consul_ip>:8500/ui"
time="2016-03-30T09:38:14Z" level=error msg="cannot set or renew session for ttl, unable to operate on sessions"
time="2016-03-30T09:39:14Z" level=info msg="Registering on the discovery service every 1m0s..." addr="<host_ip>:2375" discovery="consul://<consul_ip>:8500/ui"

When running Docker in cloud platform, some network ports need to open.
Docker port (your choice, 2375, 2376, etc)
Discovery: 8500 for Consul
Overlay network: tcp 7946, udp 4789, 7946.
SSH: 22

The port scan from slave node shows 8500, 22 are opened on the master node. And use tcpdump show that the slave node doesn't send out any request to master node at all. Really strange.
nmap
Starting Nmap 6.40 ( http://nmap.org ) at 2016-03-30 21:44 EDT
Nmap scan report for master (master IP)
Host is up (0.00012s latency).
Not shown: 996 closed ports
PORT     STATE SERVICE
22/tcp   open  ssh
111/tcp  open  rpcbind
4000/tcp open  remoteanything
8500/tcp open  fmtp
MAC Address: 02:42:A8:F7:2C:6A (Unknown)
Nmap done: 1 IP address (1 host up) scanned in 1.74 seconds

My guess is correct that after I assign 10.0.0.x IP for the slave docker container, it can register to the swarm master. But the problem is there will be another IP needed beside the docker host, which means how many slave docker host there, 2 times IP address are needed within the same subnet.
Another problem is that the swarm master only know there is a new slave docker host, but the docker host information is empty.

@zet809 Ubuntu has default docker configuration file at /etc/default/docker. Can you show the process info of your docker daemon like this?
ubuntu@manager:~$ ps -ef | grep -i "docker daemon"
root       666     1  0 Mar14 ?        00:50:56 /usr/bin/docker daemon -H xxx:2377 -H unix:///var/run/docker.sock --cluster-store=consul://yyy:8500/swarm --cluster-advertise=xxx:2377

@dongluochen Thanks very much for you responding. I have found the reason in my environment that I have configure bridge manually for the nic that docker host need to use to contact outside.
The current question is, is it possible to assign IP address for the containers running in the swarm cluster and then I can ping it outside of the swarm cluster? It seems the overlay network only works inside the cluster.

is it possible to assign IP address for the containers running in the swarm cluster and then I can ping it outside of the swarm cluster?

@zet809 It's possible but you have to manage the IP assignment and routing. Docker allows you to create a subnet with public IP --net, and it allows you to specify an IP for a container --ip. But you'll have to handle routing.
If you just want your container accessible from outside, you can use port mapping -p to map host port to your container port, or use host network where container uses the host's network --net=host. They have different implication, choose accordingly.


Migrate/Duplicate the Chain Indexing from the Graph to Envio

Envio shared with us the fast indexing capabilities that they offer at a recent Townhall.  Maybe we explore migrating to Envio for chain indexing or having a duplicate chain indexing option for the Graph, because it isn't always reliable.  Unfortunately, most of dAcademy currently depends on the Graph working.
Current Quest Chains subgraph
Loading Dynamic Contracts in Envio

dAcademy - Envio repo

Also see #38


feat: Added @method_def_constant

fix(@parse_kwargs): Don't error on unexpected keys nor non key=value expressions

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

77 of 89 (86.52%)  changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+6.2%) to 85.618%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/parse_kwargs/parse_kwargs_macro.jl
24
26
92.31%

src/macro_util.jl
40
50
80.0%

Files with Coverage Reduction
New Missed Lines
%

src/parsing/expr_types/base.jl
1
88.89%

Totals

Change from base Build<PHONE_NUMBER>:
6.2%

Covered Lines:
1018

Relevant Lines:
1189

💛  - Coveralls


C++ Function {}  becomes gray with Neoformat clang-format

C++ Function {}  becomes gray with Neoformat clang-format

change some {} position:

use Neoformat cmd:

nvim: 0.6
rainbow:lastest
myconfig:
rainbow = {
    enable = true,
    extended_mode = true, -- Highlight also non-parentheses delimiters, boolean or table: lang -> boolean
    max_file_lines = 1000 -- Do not enable for files with more than 1000 lines, int
},
-- packer
editor['p00f/nvim-ts-rainbow'] = {
    opt = true,
    after = 'nvim-treesitter',
    event = 'BufRead'
}

How should I fix this?

Does this still happen? I can't reproduce this

thanks replay.
I used efm to replace neoformat. so it's not happen now. I think it's some error for old version neoforamt, maybe i can close this issus.