const object inside of loop when --transform-object-keys true

When using --transform-object-keys true in some cases const object is created outside of loop that used inside of each loop iteration (but this kind of loop optimization is not valid and obvious if you want create multiple new objects with same params inside of loop). This is a bug or feature?
Expected Behavior
Create a new object with same params inside of loop for each loop iteration
Current Behavior
One object is used inside of loop and as reasult all array params point to same object in memory
Steps to Reproduce

Input file (./out/test.js):

!function() {
    let o = [];
    for (let e = 0; e < 10; e++)
        o.push({o: 0 });
    o[0].o = 1;
    console.log(o[0] === o[1]);  // this should be false
}();

Obfuscate only with "--transform-object-keys true" and turn off default params to get easy readable results:

javascript-obfuscator ./out/test.js --output ./out/test_.js --transform-object-keys true --string-array false --compact false --simplify false --string-array-index-shift false --identifier-names-generator mangled --string-array-rotate false --string-array-shuffle false --string-array-wrappers-chained-calls false

Got output file (./out/test_.js):

!(function () {
    let b = [];
    const c = {};
    c['o'] = 0x0;
    for (let d = 0x0; d < 0xa; d++)
        b['push'](c);
    b[0x0]['o'] = 0x1;
    console['log'](b[0x0] === b[0x1]); // this is true not false due to same object
}());

Your Environment

Obfuscator version used:

4.0.2_2023-02-13T06:57:01.273Z

Node version used:

v18.17.0
Temporary solution
Rewrite object creation as follows Object.create({...}) in case of new object should be created per each iteration

There is also same side effect of using --transform-object-keys true when there is sequence separated by ',' - in this case object created before this sequence and got wrong data:
Input file:
!function() {
    let t = {
        t: 0,
        f: function(t) {
            this.t = t.a;
        },
        s: function(t) {
            this.t = t.d + 1;
        },
        e: function(t) {
            let i = this;
            void 0 !== t && (this.f({
                a: t
            }), this.s({
                d: i.t
            }));
        }
    };
    t.e(1), console.log(t.t); // output should be 2
}();

Output file:
!(function () {
    let a = {
        't': 0x0,
        'f': function (b) {
            this['t'] = b['a'];
        },
        's': function (b) {
            this['t'] = b['d'] + 0x1;
        },
        'e': function (b) {
            let c = this;
            const d = {};
            d['d'] = c['t']; // it is formed before execution of f() and got old data as result
            void 0x0 !== b && (this['f']({ 'a': b }), this['s'](d));
        }
    };
    a['e'](0x1), console['log'](a['t']); // output is 1 instead of 2 due to d formed before execution of f()
}());

same issue with default parameters:
(function(){
    const arr = [];
    function f(obj = { x: 1 }) {
      arr.push(obj);
    }
    f();
    f();
    console.assert(arr[0] !== arr[1]); // ok
})();

output:
(function () {
    const b = [];
    const c = {};
    c['x'] = 0x1;
    function d(e = c) {
        b['push'](e);
    }
    d();
    d();
    console['assert'](b[0x0] !== b[0x1]); // fails
}());

and while loops (no parenthesis):
while (++i < 5) arr.push({ x: 1});

You could use js-confuser.com, it seems fine with that.


Mutator set for is_open_tracking and is_click_tracking

The issue is in sendportal_campaigns table we have 2 columns is_open_tracking and is_click_tracking , it have value stored as 0, 1 but the expected value by function is true/false
https://github.com/mettle/sendportal/issues/313

@JonoB please review


GetPoseActionData error

When I try to start our (Unity) builds for Steam our logs are spammed with messages like these:
_[SteamVR] GetPoseActionData error (/actions/default/in/Pose): InvalidHandle Handle:<PHONE_NUMBER>741651024. Input source: LeftHand
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug.bindings.h Line: 45)
[SteamVR] GetPoseActionData error (/actions/default/in/Pose): InvalidHandle Handle:<PHONE_NUMBER>741651024. Input source: RightHand_
Input works as it should in the editor and when I build for Viveport we don't have any issues with input either.
There seems to have been a lot of issues like this in the past (#203 or #110) but they're supposedly should be fixed now.
Any help would be much appreciated.

@aenima2 Did you found a fix for that? I have the same issue.

I honestly can't remember sadly and I have no way of testing it either because I'm no longer working with VR. Sorry, hope it sorts itself out.


Prev and next button not hiding anymore when number of item is <= to the number of slides displayed

I have a carousel that display all items on desktop but only one in mobile, it used to hide the prev/next button but it doesn't anymore

@corentin-gautier Hi,
Now carousel won't control buttons instead it will give options to control. Please use template reference and check whether it is isFirst, isLast or isHovered.
Thanks

@sheikalthaf I can't hide if isFirst or isLast if i'm using loop: true.
The solution I've found is to check how many pointNumbers there is (less than 2 means we can't slide) that way I still have nav buttons for looping.

@corentin-gautier Sorry for this but other users want to control the carousel buttons with opacity, etc..
Thats y it is removed

@sheikalthaf yeah sure, just add it to the readme then because other people are going to ask how to do this

related to #92


Make use_training_labels positional required

Arch board suggestion in https://github.com/Azure/azure-sdk-for-python/issues/11283
Rationale for making it positional is that I feel there is an obvious logical ordering between url and the use_training_label params. Also, "required" keyword-onlys are weird

es, there is an order between URL and use_training_label. But if we ever have another required parameter, then it is unlikely that there is a logical order. But then again, that would also be a breaking change unless the new parameter was optional.

I think we can safely assume there won't be breaking changes after GA - atleast i know we will try to avoid - so another required param after GA seems highly unlikely.

/azp run pythob - formrecognizer - ci

/check-enforcer evaluate


PERFORMANCE WARNING!!! After migrated from cannon.js to cannon-es-debugger.

Cannon.js' CannonDebugRenderer.js require user to write cannonDebugRenderer.update().
But cannon-es-debugger.js has autoUpdate parameter and default set to true, so will use inner requestAnimationFrame to call update().
After migrated from cannon.js to cannon-es-debugger, be careful to set autoUpdate to false, or delete the old cannonDebugRenderer.update() in own code.

It's not a performance problem having multiple requestAnimationFrame, but it may result in wireframes being one frame behind the body.
Do you think we should set autoUpdate to false by default?

It's not a performance problem having multiple requestAnimationFrame, but it may result in wireframes being one frame behind the body.

Hello Marco Fugaro, I found it's really a performance problem.
Please open these two pages and wait some time ( on my pc, roughly when stats go to left ), can see the first link's fps start droping.
https://raw.githack.com/gonnavis/annihilate/8b3facdc855e83cc6e0b1a7ebd05c9b7d38fa878/index.html
https://raw.githack.com/gonnavis/annihilate/dc8a584067cf8f456426f9b9fab80fc8100245d6/index.html

The only change between these two commit is added autoUpdate: false.

Do you think we should set autoUpdate to false by default?

At first, I want to make pr or suggest a solution, but eventually I think I have not best solution now. May the best is not add autoUpdate feature at first?

May the best is not add autoUpdate feature at first?

Yes I agree, we'll make calling the .update() function mandatory.

Hello Marco Fugaro, I found it's really a performance problem.

Your performance problem comes from BOTH calling .update() and the auto-update thing, but yeah it is confusing for users.

Yes, I migrated from cannon.js, so left the cannonDebugRenderer.update() unremoved.

Since version 1.0.0, the behaviour is the same as the original debugger


[REEF-489] Add concept of application attempt to driver startup

This addressed the issue by

Adds a getter to resubmissionAttempts for DriverRestarted and IDriverRestarted.
Modify the DriverRestart example to check for only restarted once.

JIRA:
REEF-489

@beysims Please have a look at the bridge portion. Currently testing on HDInsight.

Tests pass on HDInsight.

I will review it.

Seems like there's a merge conflict. I'll fix and update.

@markusweimer, @jwang98052 Fixed merge. Please continue your review, and I'll fix the changes in one shot after your pings. Thanks!

I was just notified of @beysims 's change. Since this PR involves changing some bridge code, I'll make sure it passes on HDInsight first. Thanks!

@markusweimer @jwang98052 Reopened as #501.


Extra spacing on top of library

Not sure if intended or not

Would like to see this fixed too, if possible.

I fixed this by manually making the change from https://github.com/AJ1701/metro-for-steam/commit/9300ad80e0da4ad57ff179ed1e5959da7c2f32a7


Fix va_list 'ap' was not closed properly

va_list 'ap' was opened but not closed by va_end().

Thanks!


ERD PK/FK Mapping between Datasets in the Relationship view

Problem
One of the primary pain points for Analysts and Data Scientists during data discovery is to understand the column-level relationship between datasets so they can make accurate associations within - and across - data domains.
The existing "Relationship" functionality is helpful to understand what dataset-level interdependencies exist, but not informative as to which columns are driving that dependency.
Proposed Solution
Expand the "Relationship" tab to include column-level associations; these could be extracted from foreign key constraints assigned in the db, inferred from the logic that builds the dataset, or manually associated via the DataHub UI.
Describe alternatives you've considered
3rd party ERD tools outside of DataHub.

Thanks for the suggestion. We have recently approved the Field Level Lineage RFC and have demoed an internal POC visualization (see https://github.com/linkedin/datahub/blob/master/docs/townhall-history.md#08282020 for recording).
The goal is to productionize and open source the function in the near future.

Any update on this Dataset Relationship or ERD?
Some ideas lending from SchemaSpy where they limit the relationships on 1 level up/down or 2 level. http://schemaspy.org/sample/tables/Customer.html

We are now managing feature requests through our new portal to improve visibility & prioritize work into our public roadmap. If this request is still relevant, please create a new issue so we can gauge current interest from the Community & prioritize work accordingly.
We'll close out this issue in the meantime. Feel free to reach out to me on DataHub Slack with any questions!


[Feature Request] Observe distance with reference model when training.

Required prerequisites

[X] I have searched the Issue Tracker and Discussions that this hasn't already been reported. (+1 or comment there if it has.)
[X] Consider asking first in a Discussion.

Motivation

The implementation of reinforcement learning (RL) algorithms we have used following the instruct GPT. The aim is to satisfy the following objective:
$$
\mathrm{objective}(\phi) = E_{(x,y)} \sim D_{\pi_{\phi}^{RL}} \left[ r_{\theta}(x,y) - \beta \log (\pi_{\phi}^{RL}(y | x)) / \pi_{\phi}^{SFT} (y | x) \right] + \gamma E_{x \sim D_{pretrain}}\left[ \log (\pi_{\phi}^{RL}(x)) \right]
$$
Here, the term $\log (\pi_{\phi}^{RL}(y | x)) / \pi_{\phi}^{SFT} (y | x)$ is introduced to keep the Actor model close to the reference model. This is important as it allows for the stabilization of the learning process. Monitoring the distance between the Actor model and the reference model can assist users in fine-tuning the hyperparameters.
Solution
we can upload the distance between the actor and the reference model in rl_step. The distance can be formulaed as $\log (\pi_{\phi}^{RL}(y | x)) / \pi_{\phi}^{SFT} (y | x)$.
Alternatives
No response
Additional context
No response
Checklist

[X] I have provided all relevant and necessary information above.
[X] I have chosen a suitable title for this issue.

implemented in pr #87

The effect is as shown in the figure


JRTB-2: Add stub telegram-bot for the project.

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

JRTB-2: Add stub telegram-bot for the project. #15


Some components cannot be used until React Component is mounted

When adding a raycaster and cursor component (to represent an <a-cursor>) to an entity, the element gets created before mounted to the DOM, causing the raycaster component's this.el.sceneEl to be undefined (as it has yet to be mounted), throwing an error and causing the scene to fail to render. A work around is to wait until the component is mounted to DOM and then adding more components, but this took some time to figure out. Similar to assumptions in #50 of when things are mounted and initialized, I wonder if there's a general way of handling this for all components.
import React, { Component, PropTypes } from 'react';
import { Entity } from 'aframe-react';

class CameraComponent extends Component {
  constructor() {
    super();
    this.state = {
      mounted: false,
    };
  }

  componentDidMount() {
    this.setState({ mounted: true });
  }

  render() {
    const mountedProps = {};

    if (this.state.mounted) {
      mountedProps.cursor = 'maxDistance: 100; fuse: true; fuseTimeout: 1000'
    };

    return (
      <Entity id='camera-container' {...this.props}>
        <Entity camera>
          <Entity
            {...mountedProps}
            raycaster='objects: .action'
            geometry='primitive: plane'>
          </Entity>
        </Entity>
      </Entity>
    );
  }
};

export default CameraComponent;

That's weird since A-Frame won't try to execute the components until the entity is mounted.

This is also after the a-scene's loading event is fired, if it helps

OK thanks, got a lot of maintenance lined up for aframe-react :)

Looks like an aframe issue, filed aframevr/aframe#2225

v4.0.x should solve since .setAttribute()s are called on the ref, which is after mount. Will add unit tests though.

Added unit test for wrapped entity. https://github.com/ngokevin/aframe-react/commit/44bee27c36c5d20762a2b6f3d068927a0ea14df8
Didn't see any errors in the log. Should work now since everything is initialized only once after the ref is attained. In other words, after mount.


Check ByteBuffer.hasArray before Accessing ByteBuffer.array

Description
Check ByteBuffer.hasArray() before attempting to access ByteBuffer.array(), without the check an exception may be thrown if the ByteBuffer is read-only or a DirectByteBuffer. Additionally, changed usage of new Binary(byte[]) to Binary.create(ByteBuffer) as it'll handle cases where the ByteBuffer is read-only or a DirectByteBuffer and cases where a heap-based ByteBuffer hasn't written the entire backing array.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check for com.azure:azure-messaging-eventhubs
API changes are not detected in this pull request for com.azure:azure-messaging-eventhubs

API change check for com.azure:azure-messaging-servicebus
API changes are not detected in this pull request for com.azure:azure-messaging-servicebus

API change check for com.azure:azure-messaging-eventgrid
API changes are not detected in this pull request for com.azure:azure-messaging-eventgrid

API change check for com.azure:azure-core-amqp
API changes are not detected in this pull request for com.azure:azure-core-amqp


Update for Svelte 5

Svelte 5 now has a RC, so I'm curious if there are any chances of this being updated to support Svelte 5?
I'm thinking a minimal update would only require updating peer dependencies.
This would at least get rid of the warning when installing packages:
npm WARN Could not resolve dependency:
npm WARN peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN node_modules/svelte-virtual-scroll-list
npm WARN   dev<EMAIL_ADDRESS>from the root project
npm WARN
npm WARN Conflicting peer dependency<EMAIL_ADDRESS>npm WARN node_modules/svelte
npm WARN   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN   node_modules/svelte-virtual-scroll-list
npm WARN     dev<EMAIL_ADDRESS>from the root project

However, to be compatible with Svelte 5 configured to Runes mode project-wide, more involved changes would be required.
Are there any plans/thoughts on this matter?

I would like to know the same. Whether this project is abandoned or not. Its one of the few that I found to work decently well with dynamic sized data.

Hello
Unfortunately I'm no longer frontend dev and I don't have time to maintain this lib.
But MR welcome

I tried just changing the Item.svelte to svelte 5 and scrolling through the list would randomly jump for me. If anyone else wants to look over it:
<svelte:options runes={true} />

<script lang="ts">
    import { onDestroy, onMount } from "svelte";

    const {
        resize,
        horizontal = false,
        uniqueKey,
        type = "item",
    }: {
        resize: (arg0: { id: any; size: number; type: any }) => void;
        horizontal: boolean;
        uniqueKey: any;
        type: string;
    } = $props();

    let resizeObserver: ResizeObserver | null;
    let itemDiv: HTMLElement;
    let previousSize: number;

    const shapeKey = horizontal ? "offsetWidth" : "offsetHeight";

    onMount(() => {
        if (typeof ResizeObserver !== "undefined") {
            resizeObserver = new ResizeObserver(dispatchSizeChange);
            resizeObserver.observe(itemDiv);
        }
    });

    $effect(dispatchSizeChange);

    onDestroy(() => {
        if (resizeObserver) {
            resizeObserver.disconnect();
            resizeObserver = null;
        }
    });

    function dispatchSizeChange() {
        const size = itemDiv ? itemDiv[shapeKey] : 0;
        if (size === previousSize) return;
        previousSize = size;
        resize({ id: uniqueKey, size, type });
    }
</script>

<div bind:this={itemDiv} class="virtual-scroll-item">
    <slot />
</div>


Separate namespaces for constants and uifs

Before

Uif: c{n}
Constant: a{n}
Variable: a{n}

After

Uifs: c{n}
Constant: c{n}
Variable a{n}

Looks good, but the idea was to unify uifs and constants. If you see, both uifs and constants are encoded the same way in fixpoint, so it makes sense to keep them together. I think we can remove UifDef and pass everything in the same vector to Task.

Done.

Resolved #323


Website (Button to be added for stores )

[ ] @Jddesigner0003 we need to keep icons here for play store and App Store

@Jddesigner0003 Currently we have like this

@Deveshshankar  Please check both icon attached you can use SVG or PNG whatever you like

Completed


Reboot if the kernel panics

Currently if the kernel panics, it is up to the device kernel
configuration if it timesout and reboots on a kernel panic.
Also, the watchdog if present does not reboot a device that is in
a panic state as the kernel watchdog driver keeps touching it.
Enforce a reboot on kernel panic from meta-resin.

Contributor checklist

[x] Changes have been tested
[x] Change-type present on at least one commit
[x] Signed-off-by is present
[x] The PR complies with the Open Embedded Commit Patch Message Guidelines

Reviewer Guidelines

When submitting a review, please pick:

'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

I guess there isn't much point to 10 seconds and it can be 1 second..

Will this be in the next release?


Top bar color

Please use a different color because currently it looks like the application bar.

is blue fine?

resetbutton is now darker


[Minor] Update spark-sql-InternalRow.adoc

Added scala prompt to all, consistency.

I haven't added the scala> markers as that was meant to be copied and pasted directly without using :paste mode. That's why they are without the output of their execution and also why only a few expressions are with the outputs.
Please close the pull request.


Feature/improve coverage score

Change log (since  #56)

Modified workflows to headlessly run tests that may require pygame to be initialized.
Added new unittests and rewrote some; coverage score is now 80%.
Amalgamated TODO items inside source files into a markdown file.
Added game screenshots.

Looks great. Thanks a lot for working on it!


OutOfMemoryException - RetrieveEntityChanges : Execute (RetrieveEntityChanges) request to Dataverse

I am trying to execute "RetrieveEntityChanges" request for an entity (ex: Incident) and which has many columns and every time I fetch max 5K rows.
All of a sudden, I get below error. When I try for other entity which has about 9 million rows, it works fine.
Where as Incident is just about 500K rows, it fails intermittently with the below error. Any fix for this?
It happens mostly for entities where we have large data to fetch.
OutOfMemoryException - RetrieveEntityChanges : Execute (RetrieveEntityChanges) request to Dataverse from IOrganizationService |=> Exception of type 'System.OutOfMemoryException' was thrown.
Source: System.Private.ServiceModel
Method: AllocateByteArray
DateUTC: 1/27/2023
TimeUTC: 5:04:45 PM
Error: Exception of type 'System.OutOfMemoryException' was thrown.
HelpLink Url: Not Provided
Stack Trace: at System.Runtime.Fx.AllocateByteArray(Int32 size)
at System.Runtime.InternalBufferManager.PooledBufferManager.TakeBuffer(Int32 bufferSize)
at System.ServiceModel.Channels.BufferManager.WrappingBufferManager.TakeBuffer(Int32 bufferSize)
at System.ServiceModel.Channels.MessageEncoder.BufferMessageStreamAsync(Stream stream, BufferManager bufferManager, Int32 maxBufferSize, CancellationToken cancellationToken)
at System.ServiceModel.Channels.MessageEncoder.ReadMessageAsync(Stream stream, BufferManager bufferManager, Int32 maxBufferSize, String contentType, CancellationToken cancellationToken)
at System.ServiceModel.Channels.HttpResponseMessageHelper.ReadChunkedBufferedMessageAsync(Task1 inputStreamTask, TimeoutHelper timeoutHelper)    at System.ServiceModel.Channels.HttpResponseMessageHelper.ParseIncomingResponse(TimeoutHelper timeoutHelper)    at System.ServiceModel.Channels.HttpChannelFactory1.HttpClientRequestChannel.HttpClientChannelAsyncRequest.ReceiveReplyAsync(TimeoutHelper timeoutHelper)
at System.ServiceModel.Channels.RequestChannel.RequestAsync(Message message, TimeSpan timeout)
at System.ServiceModel.Channels.RequestChannel.RequestAsyncInternal(Message message, TimeSpan timeout)
at System.Runtime.TaskHelpers.WaitForCompletionNoSpin[TResult](Task1 task)    at System.ServiceModel.Channels.RequestChannel.Request(Message message, TimeSpan timeout)    at System.ServiceModel.Dispatcher.RequestChannelBinder.Request(Message message, TimeSpan timeout)    at System.ServiceModel.Channels.ServiceChannel.Call(String action, Boolean oneway, ProxyOperationRuntime operation, Object[] ins, Object[] outs, TimeSpan timeout)    at System.ServiceModel.Channels.ServiceChannelProxy.InvokeService(MethodCall methodCall, ProxyOperationRuntime operation)    at System.ServiceModel.Channels.ServiceChannelProxy.Invoke(MethodInfo targetMethod, Object[] args)    at generatedProxy_1.Execute(OrganizationRequest )    at Microsoft.PowerPlatform.Dataverse.Client.Connector.OrganizationWebProxyClientAsync.<>c__DisplayClass52_0.<ExecuteCore>b__0()    at Microsoft.PowerPlatform.Dataverse.Client.Connector.WebProxyClientAsync1.ExecuteAction[TResult](Func`1 action)
at Microsoft.PowerPlatform.Dataverse.Client.Connector.OrganizationWebProxyClientAsync.ExecuteCore(OrganizationRequest request)
at Microsoft.PowerPlatform.Dataverse.Client.Connector.OrganizationWebProxyClientAsync.Execute(OrganizationRequest request)
at Microsoft.PowerPlatform.Dataverse.Client.ServiceClient.Command_Execute(OrganizationRequest req, String errorStringCheck, Boolean bypassPluginExecution)

The error is coming from the host process running out of memory to provide to the payload translator ( the API interface reading the wire )
I would suggest you reduce your batch size to a smaller population to reduce the memory requirements on the transfer.
Or, you can provide more memory to the overall process.

Thanks Matt for the clarification.


ci: Add github-action-benchmark

Adds github-action-benchmark to continuously store benchmarks in GitHub pages as well as run benchmarks for PRs.
Fixes #53

Codecov Report

Merging #54 (423736f) into main (c37e103) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           99        99
=========================================
  Hits            99        99


Check INFURA_API_KEY value at startup

Changes

Adds INFURA_API_KEY to the sample .env file.
Adds INFURA_API_KEY to docker-compose.yml file.
Adds INFURA_API_KEY to the startup environment validator.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 92.694%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
7216

Relevant Lines:
7481

💛  - Coveralls


[wip][ci] Rebase commits before running CI

Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

this doesn't work at this level, closing (will be perma-broken if there is a change that removes something from the Jenkinsfile but not the repo since Jenkins always takes the Jenkinsfile from the target branch)


Access files parts (name, base64 content)

Hi I add a file field to my form with "format": "data-url" and it's return file form me like this:
 "image": "data:image/png;name=13.png;base64,iVBORw0KGgoAAAANSUhEUgAAAvoAAAA6CAIAAABOCmofAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3.....

I need to get filename and file base64 content separately is it possible?
for example I need get 13.png and iVBORw0KGgoAAAANSUhEUgAAAvoAAAA6CAIAAABOCmofAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3..... in above data.

Parsing data-url syntax is outside the scope of rjsf.


Update Macaulay2 symbols for version 1.23

We add several new symbols to the Macaulay2 lexer that were introduced in version 1.23.

Merged, thanks!


Should update container image to use Azure specific image

Currently using the generic cli-tools image which contains CLI tools for all platforms. New container images are now available that are platform specific. Should update to use the Azure specific one which would improve image download times.

Blocked by issue with Azure image https://github.com/cloud-native-toolkit/image-cli-tools-azure/issues/7


Show a loader in interactive mode

When scanning a big directory in interactive mode dua just blackscreens until it ends loading, I will like to have some feedback, showing the same as in the non-interactive mode is enough.

Please be sure to use this version at least as it fixes the bug mentioned here.


Uodate DG to contain rating

Codecov Report

Merging #313 (2cb97f6) into master (704afaa) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #313      +/-   ##
============================================
- Coverage     63.04%   62.98%   -0.06%
+ Complexity      500      499       -1
============================================
  Files            88       88
  Lines          1710     1710
  Branches        194      194
============================================
- Hits           1078     1077       -1
- Misses          551      552       +1
  Partials         81       81

Impacted Files
Coverage Δ

...edu/trackermon/logic/parser/SortCommandParser.java
77.63% <0.00%> (-1.32%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704afaa...2cb97f6. Read the comment docs.


[Feature request] Load environment variables from .env files

The support for requiredEnv is really handy but it would be even more so if environment variables found in .env files was included.
Docker compose has fairly advanced support for .env files. But less could do it. Simply including variables found in .env would be a good start. Please see the below link for more information.
https://docs.docker.com/compose/environment-variables/

just a suggestion, for in the meantime, there is direnv + this alias gets .env files loaded at the time the helmfile command is run
alias di='echo dotenv > .envrc && touch .env && direnv allow'

@vsimon - Thanks for your suggestion
Minor note, isn't the touch command of the alias redundant?
direnv seems like a great project but it does seem like a minor hassel to use "plain" .env files. Not only would you have to make a symlink. Eg. ln -s .env .envrc but every environment variable needs to be prefixed with export which differs from the way it's done with other applications.
Furthermore, having support for this method of loading environment variables would not require direnv to be installed in a pipeline. And down the road I'd like to see this implemented supporting different environments.

https://github.com/direnv/direnv/issues/674

Yes it deals with .envrc files and the need to export every variable in the .envrc file was the reason why I mentioned the bootstrapping alias (done once per folder). The dotenv function is a built-in direnv function that automatically sources an .env file in the same folder (an .env file without the export prefixes).

@vsimon - I see! I read dotenv as direnv. I understand the alias now. Thanks :-)


DS-2344 Response date of the xoai header was not converted to ZULU time before formatting

Fixed Bug in DateUtils.java where Zulu time zone was not set.
https://jira.duraspace.org/browse/DS-2344

To reproduce the error the server where DSpace is installed has to be in a time zone different from UTC (for example the first one on this site: https://wiki.duraspace.org/display/DSPACE/OaiInstallations).
So if you follow the link of this repository you can see that the response date is note in UTC/Zulu but it says so (because it looks like this: 2015-01-13T05:26:27Z).
The expected behaviour is the returned date to be the current Zulu time.

+1 tested, cherry-picked


Fix invalid local attribution in type test reverse index.

Fix invalid local attribution in type test reverse index.
whoKnows is the knowledge of local not fnd->first.
I'm not entirely sure how to craft a test file to exercise this bug.
Motivation

This is incorrect logic.
Test plan

See included automated tests.

@jvilk-stripe if you can't write a test for this how did you know it was a bug?

replaceTruthy/replaceFalsy require you to pass in the local whose knowledge you are updating.
auto &whoKnows = getKnowledge(local);

...so I should be passing in local. I wrote this code just yesterday.
The bug will manifest if:

A path uses a bang to propagate knowledge to a variable.
That variable's knowledge is required (isNeeded).
That variable's knowledge should be cleared (clearKnowledge).
Then that variable's knowledge is later queried in relation to something in fnd->second.knowledge.falsy() / fnd->second.knowledge.truthy() that wasn't added through some other means.


Copy of API V2.0.1 - Response page dashboard

Key user needs

[ ] Display API status
[ ] Display number of form responses that have reported a problem
[ ] Resolve the number of problems once the submission is confirmed

Closed as dupicate


add ruby 3.1 to 3.3 ruby support

Work toward https://github.com/halorrr/lunchmoney-ruby/issues/114

A lot of the code takes advantage of hash value omission so a lot of redundant code would need to be added to support ruby 3.0. Ruby 3.0 is nearing end of life support though according to the timeline, so I'm just going to leave it out for now.


Python Refactoring Move to file/to new file

I do not find any extension to move a function, a class or a selected text to a file/a new file, it should be a common instruction that I made every day in other ides. Did I miss a plugin or this function in python is not implemented?
The common use is for move into a specific file (for example extract this into function and after move function into existing file utils.py) or move to a new file (for example you create a class and you want to extract to a new file).

dupe of https://github.com/microsoft/pylance-release/discussions/2659


use latest stable node for travis tests

Interesting, no legacy node checks now?

@Flet I think that can be left up to the author. Stable seems like a good default to me. Do you think it's worth adding another option for the author to decide which nodes to target?

Maybe default to latest and LTS?

Tweet from seldo a few days ago:
Major(ish) node versions, requests in last 7 days:
0.12  779 MM
0.10  732 MM
4   222 MM
2   22 MM
3   19 MM
1   6 MM

Definitely a wide range. With that said, I don't think we want to be covering 6 versions for every travis test by default, right? It would make sense to test for 0.10, 0.12, and 4, but I feel like that's already a lot too. @Flet @bcomnes suggestions welcome.

I think a small set of sensible defaults works for me, and ideologically, I believe people should be targeting at least stable.
Until module-init has a re-init function for updating boilerplate, I would probably just let people manually add in older versions, its literally one line in a yaml file.

Just looking at numbers:
4.x (stable) would cover 12.47% of current node clients
4.x + 0.12 would cover 56.24% of current node clients
4.x + 0.12 + 0.10 would cover 97.36% of current node clients
What's great about travis is its fairly async and does not really cost more to cover additional engines (other than time to run). For public packages, covering 4.x + 0.12 + 0.10 seems the most prudent to me .
A lot of people seemed to hold back from upgrading to 0.12, so 0.10 still has quite a big audience...
hah, @bcomnes commented above just popped in.

Thanks for the feedback! My spidey sense is telling me there's one vote for just stable and one vote for stable, 0.12, and 0.10. Is that right?

Another option would be to detect what version of node the user is running and just default to that.

(That's easily doable with process.version)

ping @flet @bcomnes ^ :wave:

whats the downside of testing many versions? Just speed?

Speed and relevance to new projects. I'm also inclined not to throw in the kitchen sink unless there's a good reason to.

In an ideal world, all programs that depend on a package would be using the latest stable version of node. For various reasons, some programs/users are still running on older versions of node. This could be due to neglect or due to other logistical reasons.
The numbers above show that users are split across the last three versions of node (with most users either one or two versions behind stable currently).
If I'm building a new package, I want to ensure most users will not run into issues when depending on it. I want to test in environments that cover a good portion of what actual user's are using. Right now stableonly covers about 12% of users. If the cost of also covering additional users is a couple more minutes of travis time, I'm OK with that.
At the very least, I'd be happy to have stable and stable - 1 as default targets.
I wish travis had a way of specifying stable -1 though, as it would avoid the need to manually bump things every node release... :cry:

Okay you've made some good points. I'll go ahead and put 0.12 back in.


Improve graph table's pagination in narrow paragraphs

Description
In narrow paragraphs the table pagination gets partially hidden (see the image).

Investigate if it's possible to make the pagination show less page numbers, i.e. 1, 2, ..., 40.

According to the documentation: https://datatables.net/reference/feature/paging.buttons
The amount of buttons can be set up to a custom odd number.
However:

Please note that DataTables pagination control is responsive. It will automatically remove number buttons until the control fits onto a single line, as required by the page's layout.

This quote from documentation does not seem to be valid in our case.
Additionally, any attempt to set the amount via "layout" or "paging" property in the initial DT configs failed, for both new and 2.0.0-2.0.3 naming conventions (the access to this configuration was different in early versions of DT, but we are using new versions anyway).
What worked:
As mentioned in the comments of page: https://datatables.net/reference/option/pagingType
The post-init configuration line worked just fine. The further configuration can be done by setting constant "pagerAmount" in datatable wrapper.
Additionally, the buttons "First", "Next", "Previous" and "Last" can be removed all or partially, if needed.

Current decision:
Change text on "First", "Next", "Previous" and "Last"  buttons into "<<", "<", ">" and ">>"


remove unnecessary parens

Fix unnecessary parens before they get flagged by an incoming linter.
See try-failure: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8790348913643501601/+/u/analyze_flutter_flutter/stdout
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

test-exempt: code refactor with no semantic change


How can I determine how many sales of item X were made on a date?

Hi, I'm having trouble finding the APIs that allow me to answer this question: How many of item X did we sell on 2018-08-01.
Can you help point me in the right direction?

Hi @otang!
In order to review itemizations, you will need to use order_id's (by calling CreateOrder), and attaching it to a Charge request. After that, if you need to retrieve item sales from a particular date, you can call ListTransactions with begin_time and end_time, and the Transaction objects will include a order_id field, which you can then pass to the BatchRetrieveOrders endpoint to view the items sold in the order.
Also, if you are using Square POS to take payments instead of our APIs, then there will not be an order_id, and you will need to use V1's ListPayments instead which will show the POS itemizations.
Please let me know if you have any further questions about this!
References:
https://docs.connect.squareup.com/cookbook/orders-and-transactions
https://docs.connect.squareup.com/api/connect/v1#navsection-payments


Don't exit if preventDefault used in will-quit event

Fixes https://github.com/getsentry/sentry-electron/issues/450

Ah yes, we force the session handling to be the last will-quit handler but we're not checking if any of the other stop the exit.
Thanks for the PR!

Sure thing...I didn't check in our quit handler either before forcing it to quit when we finished our work. I mean...who does that? 😄


Correctly extract PR identifier for CircleCI builds

Not super clear on why Cobertura isn't picking up results of ServiceInfoFactoryTest, but it seems to only hit the Travis branch even when running locally.

Thanks for the contribution.
The change itself makes sense. Thanks.
The coverage reporter has been broken since the plugin switched to 2.0 ecosystem. ( I've been looking for alternatives but I haven't found one yet.)

any thoughts when you might release this?

Sorry for being late.
I've published this as v2.6.1 to maven and bintray!


METRON-1441: Create complementary Solr schemas for the main sensors

Contributor Comments
We have ES templates for bro, snort, yaf, and error, we need corresponding solr schemas for these collections.
Right now this is tested via the SchemaTranslatorTest, which spins up the current version of Solr loads the schemas and writes sample data and ensures they come back properly.
Note: This is an intermediate move to getting full solr support.  These schemas will be refined more, likely.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

I know that commit history looks pretty awful, but it's because I branched off of @merrimanr 's SolrDao PR initially.  Now that PR is in the branch, so the comparison should be more sensible.


GraphQL/UnusedArgument false positive on optional arguments.

class Mutations::DoTheThng < Mutations::BaseMutation
  argument :foo,  String,    required: true
  argument :bar,  String,    required: true
  argument :baz, Boolean, required: false

  def resolve(foo:, bar:, baz: false)
    # ...
  end
end

Code such as the above produces the error:
GraphQL/UnusedArgument: Argument remember_me: should be listed in the resolve signature.

Using the auto-correct feature leads to the resolve method being changed to:
  def resolve(foo:, bar:, baz: false, baz:)

Good catch! Russians are on holiday until the end of the week, so I'm not sure I'll be able to ship earlier, but PRs are welcome 🙂

Unfortunately, this is a bit beyond my ken, or I would have submitted one.  My apologies.

I have a PR to address this - https://github.com/DmitryTsepelev/rubocop-graphql/pull/66


[dotOp] [rocMLIR] Make test_dot.py work

This PR fixes

the bugs in convert_layout #blocked -> #lds and #mfma -> #blocked.
the logic to choose mPerWave and nPerWave

A unit test test_dot.py is added, which is a modified version of the test_dot test in test_core_amd.py.

epilogue is set to "none"
M, N, K is carefully chosen so that the test does not run out of shared memory resource
atol is set to 1e-4 for float16 dtype

M, N, K is carefully chosen so that the test does not run out of shared memory resource

One simple question. How are we going to handle it if  M, N, K cause running out of shared memory resource?

From a gemm perspective, we need to break down the MxN, MxK, and NxK blocks into smaller blocks so that one block uses less shared memory.
In the case of test_dot, only one block is launched in the grid. So if it is using more shared memory than the limit, there is nothing we can do.

From a gemm perspective, we need to break down the MxN, MxK, and NxK blocks into smaller blocks so that one block uses less shared memory. In the case of test_dot, only one block is launched in the grid. So if it is using more shared memory than the limit, there is nothing we can do.

Thanks for the clarification. The dot implementation here is only for one block. GEMM implementation is responsible for dividing input matrices to small pieces that can fit on the shared memory before calling the dot here.


[HUDI-7930] Update Flink 1.19 to support Array and Map of Rows

Change Logs
Added support for Array of Rows and Maps with Row values in Flink 1.19. Only supports nesting 1 level deep. The Row cannot contain another Array or Map.
The changes were copied from Flink 1.18.x applied in [HUDI-7930] Flink Support for Array of Row and Map of Row value
Impact
No change to the public API.
Risk level (write none, low medium or high below)
Low provided the unit tests.
Documentation Update
As far as I could tell, this was not in the documentation. But it would be nice to note somewhere that as of this change, Arrays and Map values support basic types and Rows, but does not support additional Arrays or Maps within the Row.
Contributor's checklist

[x] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Close because it is already fixed in: https://github.com/apache/hudi/pull/11966


fix Disable BRPC 1.4 contention profiler to avoid deadlock

BRPC contention profiler hooks pthread mutex, which may deadlock when used with Jemalloc.
This PR remove pthread mutex hook and disable BRPC contention profiler.

similar issue: https://github.com/apache/brpc/issues/2726
reference fix: https://github.com/apache/brpc/pull/2727

run buildall

run buildall

bRPC 1.4 does not contain the code of apache/brpc#2692, so there is no issue of apache/brpc#2726. The real issue should be apache/brpc#859, which has been resolved in apache/brpc#2684.
In addition, bRPC 1.11 supports disabling pthread mutex hook using NO_PTHREAD_MUTEX_HOOK macro.

bRPC 1.4 does not contain the code of apache/brpc#2692, so there is no issue of apache/brpc#2726. The real issue should be apache/brpc#859, which has been resolved in apache/brpc#2684.
In addition, bRPC 1.11 supports disabling pthread mutex hook using NO_PTHREAD_MUTEX_HOOK macro.

Thanks for your suggestion! this PR simply disables pthread mutex hook and contention profiler.
Next, I will consider pick https://github.com/apache/brpc/pull/2684, or upgrading bRPC version (I tried several times, so sad)


Bluetooth: host: Improve error reporting on gatt subscribe

Return EALREADY when the subscription already exists but it is a different entry. This indicates to the application to not wait on subscribe callback. This is needed because the callback is called from the ccc_write which does not happen when another subscription exists

Since this is a change in public API behavior, shouldn't it be documented in the release notes or migration guide as well?

If the change is accepted, I can document it.

Since this is a change in public API behavior, shouldn't it be documented in the release notes or migration guide as well?

If the change is accepted, I can document it.

It seems reasonable to me. The migration guid would likely be the right place for it.

Alternative: Invoke the callback, emulating a successful response.

Discussed in the Bluetooth WG. Consensus seems (for now) to be toward the "safe approach" i.e. just do another write over the air, as proposed by @Thalley here: https://github.com/zephyrproject-rtos/zephyr/pull/82107#discussion_r1861953147

Changes look good to me, although I'm unaware if we have any tests that tests this?

The subscription is indirectly tested in many bsims (specially the ones that involve audio)
So, the current behavior should not have changed if those tests are satisfied.

We must consider the case when the application subscribes to indications and then to notifications. I don't know what the original intention behind the API is for this case, but from just reading the code, I see the behavior has changed.
Before this change, it results in indications. After this change, it results in notifications.

Good catch! If I propagate the value, it should be good right?
Application subscribes to indications and then to notifications.
Before this change, it results in indications.
After it would result in indications and notifications.

The server may reject a request to set both the Notification and Indication bits for the same characteristic.

In nearly all GATT requests the server may reject the request for any reason, so this is a weird thing to write here. A GATT server may even reject a read request to the device name if it chooses.
In any case, if a GATT client user in Zephyr chooses to set both bits, then that's up to that user.
I think I'm missing the detail that you are discussing. Isn't the subscription value something that the client writes to the server, and then it is up to the server to decide what to do here? Are we, as the client, assuming some behavior?

I posted the quote from the spec because I think @Yagoor is asking whether he should update the code to set both bits when we have two subscriptions from the application, where one subscription is asking for notifications and the other is asking for indications. I think this is a subtly difficult question to answer. But we can put that discussion aside for now.
To maintain the previous behavior w.r.t. the value of the CCC, the value must be "indications" when the application subscribes to indications and notifications separately, and it must be "indications and notifications" if the application is requesting that in any single subscription.
In other words, we must bring back the loop removed by this PR, but instead of computing has_subscription, we compute ccc_value = MAX(all subscriptions, including the new one).

In other words, we must bring back the loop removed by this PR, but instead of computing has_subscription, we compute ccc_value = MAX(all subscriptions, including the new one).

Ah, I understand it now.
So if application A has subscribed to indications and then application B later subscribes to notifications, then we (in current version) overwrite application A's value.
Not sure what your meant by MAX here, but shouldn't it be the union of all subscriptions?
So if A subscribes to indications and B later subscribes to notifications, then we send BT_GATT_CCC_NOTIFY | BT_GATT_CCC_INDICATE?

Not sure what your meant by MAX here

I mean the maximum given the ordering (notify & indicate) > indicate > notify > 0. It just happens that the CCC values for those are 3, 2, 1, 0, respectively, so the numerical maximum will give the same result. This is a little hidden and counts as smart-programming, I would not be against something more explicit.

shouldn't it be the union of all subscriptions?
So if A subscribes to indications and B later subscribes to notifications, then we send BT_GATT_CCC_NOTIFY | BT_GATT_CCC_INDICATE?

The old code does >=.
https://github.com/zephyrproject-rtos/zephyr/blob/2f583a8369ef5b67c4438c40d17721d31db952a0/subsys/bluetooth/host/gatt.c#L5471
If we want to retain the old behavior, we must take the maximum. In your example, we send BT_GATT_CCC_INDICATE.
If someone wants to change the behavior, please say so, and please state your reasoning. I'm just assuming we want to keep old behavior until we intentionally decide to change it.

If someone wants to change the behavior, please say so, and please state your reasoning. I'm just assuming we want to keep old behavior until we intentionally decide to change it.

Semantically I want to change it. It does not make sense to treat indications as a superset of notifications. If I subscribe to notifications and then my callback gives me the indication value, then I assume there's a bug.
Practically I don't think this will ever be an issue to be honest. Characteristics that have both indication and notifications are corner cases, and Zephyr applications where we want to subscribe to both, but individually, is equally much a corner case, so this ends up being a corner case squared :D

Should I rollback to the simple change in which we just send the write even if another subscription exists?

No I think the current solution is better.
if existing ccc == 0 (none) and params->value is 0 => Send 0
if existing ccc == 0 (none) and params->value is 1 => Send 1
if existing ccc == 0 (none) and params->value is 2 => Send 2
if existing ccc == 0 (none) and params->value is 3 => Send 3
if existing ccc == 1 (none) and params->value is 0 => Send 1
if existing ccc == 1 (none) and params->value is 1 => Send 1
if existing ccc == 1 (none) and params->value is 2 => Send 3
if existing ccc == 1 (none) and params->value is 3 => Send 3
if existing ccc == 2 (none) and params->value is 0 => Send 2
if existing ccc == 2 (none) and params->value is 1 => Send 3
if existing ccc == 2 (none) and params->value is 2 => Send 2
if existing ccc == 2 (none) and params->value is 3 => Send 3
if existing ccc == 3 (none) and params->value is 0 => Send 3
if existing ccc == 3 (none) and params->value is 1 => Send 3
if existing ccc == 3 (none) and params->value is 2 => Send 3
if existing ccc == 3 (none) and params->value is 3 => Send 3

It should however be documented that if a different user/application has already subscribed to the same handle, then the callback will contain the "sum" (or max or whatever) of all the users/applications. From a GATT client application standpoint, it shouldn't matter (unless perhaps for a few GATT services) whether a notification or indication was received.


ZP:4640: Zeoflow Spark 3

Closing this PR the same changes have been taken up in https://github.com/zeotap/zeoflow/pull/14.


Need help tracking down source of NFS mount bug blocking Rook CI

Describe the bug
I need some help trying to determine why NFS mounts began failing in Rook CI on October 27th. From what I have looked at so far, this doesn't correspond to any changes in Rook or Ceph-CSI. I'm hoping someone here might have a better idea of where to look. @Rakshith-R or @nixpanic perhaps?
Environment details

Image/version of Ceph CSI driver : quay.io/cephcsi/cephcsi:v3.9.0
Helm chart version : N/A
Kernel version : Linux fv-az619-734 5.15.0-1050-azure #57~20.04.1-Ubuntu SMP Wed Oct 4 17:09:16 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Mounter used for mounting PVC (for cephFS its fuse or kernel. for rbd its
krbd or rbd-nbd) : NFS
Kubernetes cluster version :Client Version: v1.28.3
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.0

Ceph cluster version : v18.2.0

Steps to reproduce
Steps to reproduce the behavior:
This is failing in all of Rook's CI runs starting October 27th.
E.g., https://github.com/rook/rook/actions/runs/6786937018/job/18495134986
Actual results
The best indication of what is going wrong is the No such file or directory error given by CSI when mounting to the test pod, described below.
runner@fv-az619-734:~/work/rook/rook$ k describe pod/csinfs-demo-pod
Name:             csinfs-demo-pod
Namespace:        default
Priority:         0
Service Account:  default
Node:             fv-az619-734/<IP_ADDRESS>
Start Time:       Wed, 08 Nov 2023 18:32:00 +0000
Labels:           <none>
Annotations:      <none>
Status:           Pending
IP:
IPs:              <none>
Containers:
  web-server:
    Container ID:
    Image:          nginx
    Image ID:
    Port:           <none>
    Host Port:      <none>
    State:          Waiting
      Reason:       ContainerCreating
    Ready:          False
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /var/lib/www/html from mypvc (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-swdlh (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  mypvc:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  nfs-pvc
    ReadOnly:   false
  kube-api-access-swdlh:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   BestEffort
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type     Reason                  Age                   From                     Message
  ----     ------                  ----                  ----                     -------
  Normal   Scheduled               6m23s                 default-scheduler        Successfully assigned default/csinfs-demo-pod to fv-az619-734
  Normal   SuccessfulAttachVolume  6m23s                 attachdetach-controller  AttachVolume.Attach succeeded for volume "pvc-26696fa1-6369-4245-8ca3-1fc41269c7bb"
  Warning  FailedMount             2m10s (x9 over 6m4s)  kubelet                  MountVolume.SetUp failed for volume "pvc-26696fa1-6369-4245-8ca3-1fc41269c7bb" : rpc error: code = Internal desc = nfs: failed to mount "rook-ceph-nfs-my-nfs-a:/0001-0009-rook-ceph-0000000000000001-03ec9b2d-0fd5-4689-a5cd-c8f0daf3bdf9" to "/var/lib/kubelet/pods/cc20b8a6-aca7-4709-a270-cc43b87f39d7/volumes/kubernetes.io~csi/pvc-26696fa1-6369-4245-8ca3-1fc41269c7bb/mount" : an error (exit status 32) occurred while running nsenter args: [--net=/var/lib/kubelet/plugins/rook-ceph.nfs.csi.ceph.com/rook-ceph.net.ns -- mount -t nfs rook-ceph-nfs-my-nfs-a:/0001-0009-rook-ceph-0000000000000001-03ec9b2d-0fd5-4689-a5cd-c8f0daf3bdf9 /var/lib/kubelet/pods/cc20b8a6-aca7-4709-a270-cc43b87f39d7/volumes/kubernetes.io~csi/pvc-26696fa1-6369-4245-8ca3-1fc41269c7bb/mount -o nolock] stderr: "mount.nfs: mounting rook-ceph-nfs-my-nfs-a:/0001-0009-rook-ceph-0000000000000001-03ec9b2d-0fd5-4689-a5cd-c8f0daf3bdf9 failed, reason given by server: No such file or directory\n"

Describe what happened
Expected behavior
Users should be able to mount NFS volumes in their pods.
Logs
NFS Provisioner logs:
I1108 18:29:53.628203       1 main.go:93] Version : v1.8.0
I1108 18:30:00.213913       1 common.go:111] Probing CSI driver for readiness
I1108 18:30:00.240073       1 leaderelection.go:245] attempting to acquire leader lease rook-ceph/external-resizer-rook-ceph-nfs-csi-ceph-com...
I1108 18:30:00.251760       1 leaderelection.go:255] successfully acquired lease rook-ceph/external-resizer-rook-ceph-nfs-csi-ceph-com
I1108 18:30:00.253703       1 controller.go:255] Starting external resizer rook-ceph.nfs.csi.ceph.com
I1108 18:29:54.284671       1 csi-provisioner.go:154] Version: v3.5.0
I1108 18:29:54.284790       1 csi-provisioner.go:177] Building kube configs for running in cluster...
I1108 18:30:00.148600       1 common.go:111] Probing CSI driver for readiness
I1108 18:30:00.200650       1 csi-provisioner.go:302] CSI driver does not support PUBLISH_UNPUBLISH_VOLUME, not watching VolumeAttachments
I1108 18:30:00.201564       1 leaderelection.go:245] attempting to acquire leader lease rook-ceph/rook-ceph-nfs-csi-ceph-com...

I1108 18:30:00.422803       1 controller.go:860] Started provisioner controller rook-ceph.nfs.csi.ceph.com_csi-nfsplugin-provisioner-d546db784-44m2n_3a20f039-19ec-49ff-ade6-2fc1275e781a!
I1108 18:31:59.417433       1 controller.go:1359] provision "default/nfs-pvc" class "rook-nfs": started
I1108 18:31:59.419248       1 event.go:298] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"default", Name:"nfs-pvc", UID:"26696fa1-6369-4245-8ca3-1fc41269c7bb", APIVersion:"v1", ResourceVersion:"3022", FieldPath:""}): type: 'Normal' reason: 'Provisioning' External provisioner is provisioning volume for claim "default/nfs-pvc"
I1108 18:31:59.677176       1 controller.go:1442] provision "default/nfs-pvc" class "rook-nfs": volume "pvc-26696fa1-6369-4245-8ca3-1fc41269c7bb" provisioned
I1108 18:31:59.677204       1 controller.go:1455] provision "default/nfs-pvc" class "rook-nfs": succeeded
I1108 18:31:59.764973       1 event.go:298] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"default", Name:"nfs-pvc", UID:"26696fa1-6369-4245-8ca3-1fc41269c7bb", APIVersion:"v1", ResourceVersion:"3022", FieldPath:""}): type: 'Normal' reason: 'ProvisioningSucceeded' Successfully provisioned volume pvc-26696fa1-6369-4245-8ca3-1fc41269c7bb

NFS driver logs:
$ kr logs csi-rbdplugin-fbbck --all-containers
I1108 18:31:13.837902  171895 main.go:167] Version: v2.8.0
I1108 18:31:13.837999  171895 main.go:168] Running node-driver-registrar in mode=registration
I1108 18:31:17.707175  171895 node_register.go:53] Starting Registration Server at: /registration/rook-ceph.rbd.csi.ceph.com-reg.sock
I1108 18:31:17.707369  171895 node_register.go:62] Registration Server started at: /registration/rook-ceph.rbd.csi.ceph.com-reg.sock
I1108 18:31:17.707612  171895 node_register.go:92] Skipping HTTP server because endpoint is set to: ""
I1108 18:31:17.917672  171895 main.go:102] Received GetInfo call: &InfoRequest{}
I1108 18:31:17.918083  171895 main.go:109] "Kubelet registration probe created" path="/var/lib/kubelet/plugins/rook-ceph.rbd.csi.ceph.com/registration"
I1108 18:31:17.982437  171895 main.go:121] Received NotifyRegistrationStatus call: &RegistrationStatus{PluginRegistered:true,Error:,}

Dmesg logs: https://gist.github.com/BlaineEXE/df404fb8d79fef06258a07c780abb382
I looked at the location on the CI host to see if there is a host problem, and there may be, but the behavior is strange to me. I can sudo ls the host mount location and see the dir that is supposed to exist, but sudo ls of that dir gives No such file or directory
runner@fv-az619-734:~/work/rook/rook$ sudo ls /var/lib/kubelet/pods/cc20b8a6-aca7-4709-a270-cc43b87f39d7/volumes/kubernetes.io~csi
pvc-26696fa1-6369-4245-8ca3-1fc41269c7bb
runner@fv-az619-734:~/work/rook/rook$ sudo ls /var/lib/kubelet/pods/cc20b8a6-aca7-4709-a270-cc43b87f39d7/volumes/kubernetes.io~csi/pvc-26696fa1-6369-4245-8ca3-1fc41269c7bb
ls: cannot access '/var/lib/kubelet/pods/cc20b8a6-aca7-4709-a270-cc43b87f39d7/volumes/kubernetes.io~csi/pvc-26696fa1-6369-4245-8ca3-1fc41269c7bb': No such file or directory

I tried listing again afterwards, with more list options, and it appears to be gone, like it is being created and deleted by something seemingly at random:
runner@fv-az619-734:~/work/rook/rook$ sudo ls -alFh /var/lib/kubelet/pods/cc20b8a6-aca7-4709-a270-cc43b87f39d7/volumes/kubernetes.io~csi/
# NO OUTPUT!

I think something changed in ceph image.
Just changing nfs-ganesha image lead to a successful mount.
https://github.com/rook/rook/issues/13151#issuecomment-1798215739

I was told that the Ganesha 5.7 version present in the most recent v18 images fixes that issue. I will investigate further.

Closing this as solved, and I'll figure out how to get this fixed in ceph-container. Thanks, Rakshith!


Make Tags and Tag Types addressable by unique id

Previously they were only accessible by location and data. This is pretty inconvenient for when you want to keep references to them. They should have some sort of unique id (guid) by which you can reference them.

Done in 2.4.2892-dev


While stepping back and fourth with screen reader scroll stops working

Testing #177674
I got stuck in a mode where the scroll vanished and could not scroll anymore.

To reproduce run a command with large output, then scroll to the top, tab out and tab back in a few times.

/duplicate https://github.com/microsoft/vscode/issues/177862


PressableButtonHoloLens2Toggle_32x96_Dwell does not change off-color

Describe the bug
The Toggle-Button does not change color as set when toggled. (The function ButtonExecute in ToggleDwellPressableButton.cs is never executed.)
To reproduce
Steps to reproduce the behavior:

Add a PressableButtonHoloLens2Toggle_32x96_Dwell to your scene
Change dwellOffColor to e.g. red
Go to play mode and toggle the button
See that color doesn't get changed (well it does, but not to the color set, e.g. red)

Expected behavior
Color gets changed
Screenshots

Your setup (please complete the following information)

Unity Version 2020.3.37f1
MRTK Version 2.8.3

Target platform (please complete the following information)

HoloLens 2

Additional context
These code in ToggleDwellPressableButton.cs is never executed:
        /// <inheritdoc/>
        public override void ButtonExecute()
        {
            Debug.Log($"ButtonExecute {isDwellEnabled}"); // DEBUG test, to see it is never executed
            isDwellEnabled = !isDwellEnabled;
            dwellStatus.text = isDwellEnabled ? "On" : "Off";

            // swap the button background and dwell visuals overlay color
            buttonBackground.material.color = isDwellEnabled ? this.dwellOnColor : this.dwellOffColor;
            dwellVisualImage.material.color = isDwellEnabled ? this.dwellOffColor : this.dwellOnColor;
        }

in addition: the field bool isDwellEnabled is logically rather a isToggled  or not?

Seems related to #11367
@marlenaklein-msft  can you check if this is reproducible in MRTK3

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


Problems creating user prior to entrypoint

I'm trying to build a container based on this one that requires creating a user and copying some files into it's home directory.
The image builds fine, and when I run the container I can log in to it, but I am then just presented with a black screen, rather than the desktop. If
My setup pulls the ubuntu user setup as defined in the docker-entrypoint.sh file into a separate file (add-user.sh), copied and run from my Dockerfile. A modified docker-entrypoint.sh file, with the ubuntu user creation step commented out is also copied into the container. If I don't run my add-user.sh step, and just copy over the original (uncommented) docker-entrypoint.sh file, everything works fine.
It's like the user creation step has to run as part of the entrypoint?

When an user is added in the Dockerfile it's hard coded in the image. When its done in the entrypoint the user is added when the system is running. Or just add a user when its running and then log in. docker-compose exec terminalserver adduser myuser

A similar issue occurs when I run docker-compose exec terminalserver adduser myuser. If I try to log in with that new credential, I just see a black screen, not the desktop.

 So what is your source ?

IIRC, I simply commented out the user creation statements in the docker-entrypoint.sh and used them in the Dockerfile and rebuilt the container. Checking old screenshots, when I tried to run it and connect to it I either got a black screen or a sequence like this:

then click the button and get:

There is a reason why it is in the entrypoint !

I thought as much, but I don't understand Linux and/or Docker enough to know why... I'm just trying to use it to get something done!

Yes and you can ask me all 👍 or ask google ;)

Right, so: what do I need to do in order to be able to create a user in the base image rather than creating it as part of the entrypoint routine.
Or if I can't why not? :-)


Remove Task.Wait() and Task.Result as that can lead to deadlocks

This was amongst others in TenantService. While I was reviewing that code I saw that a lot is happening there in the constructor, which should be regarded as a code smell.
What's being done there apparently, is obtaining the tenant string from the current user or the querystring or the header and fetching the tenantdto from the database (or from the cache if it exists there). This seems like a lot of work to be doing in a constructor of a service.
At first glance this seems to be code that could be moved to a filter maybe? Although that probably doesn't take care of the HangFire case... In any case I think this code should be at least in a method and not in the constructor. Only question then is... where to call that method?

I didn't find a better place to put this code rather than the constructor.

I agree with you @fretje
within the limitations is freeing the dependencies of httpcontext and the hangfire case. the injection of this data should be scoped so that it can be set in a single place during initialization, either in the middleware for standard requests, and within the context activation flow (hangfire case)


In customize-ads doc, include visual

Ido's request:
We should show a visual of successful blend/contrast ad styles.

We've removed this section


Update 04-Bintray-For-Plugins.md

This is all I know! :)

Hi @mslinn,
Thank you for your contribution! We really value the time you've taken to put this together.
We see that you have signed the Typesafe Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:
http://www.typesafe.com/contribute/cla

LGTM - @eed3si9n It looks like the failure are from Latex + the japanese/chinese charset installation.   Ideas on how to fix travis?

AFAIK Travis is broken until https://github.com/travis-ci/apt-source-whitelist/issues/55 is solved

@jsuereth I think Travis CI was going to add latex PPA on the whitelist, when they do we can use the container-based infrastructure + caching. See also travis-ci/apt-package-whitelist#744.


Fixes #164 | Check if port index fits in bounds

Changes Unknown when pulling 25f46ce585c7bfe322a27eb39091d2185ad600a5 on bugfix/#164/check_ports_bounds into ** on master**.

This happens when you deployed service and then update it with different number of ports but you stopped deployment or you deployment has not finished yet.
Below are the steps to reproduce it:

PUT /v2/apps

[{
  "id": "bug/164",
  "cmd": "python -m SimpleHTTPServer $PORT0",
  "cpus": 0.1,
  "mem": 32,
  "disk": 0,
  "instances": 1,
  "healthChecks": [
    {
      "gracePeriodSeconds": 3,
      "intervalSeconds": 60,
      "timeoutSeconds": 20,
      "maxConsecutiveFailures": 3,
      "portIndex": 0,
      "path": "/",
      "protocol": "HTTP",
      "ignoreHttp1xx": false
    }
  ],
  "labels": {
    "consul": "name"
  },
  "portDefinitions": [
    {
      "protocol": "tcp"
    }
  ]
}]

PUT /v2/apps

[{
  "id": "bug/164",
  "cmd": "fail",
  "cpus": 0.1,
  "mem": 32,
  "disk": 0,
  "instances": 1,
  "healthChecks": [
    {
      "gracePeriodSeconds": 3,
      "intervalSeconds": 60,
      "timeoutSeconds": 20,
      "maxConsecutiveFailures": 3,
      "portIndex": 0,
      "path": "/",
      "protocol": "HTTP",
      "ignoreHttp1xx": false
    }
  ],
  "labels": {
    "consul": "name"
  },
  "portDefinitions": [
    {
      "protocol": "tcp"
    },
    {
      "protocol": "tcp"
    }
  ]
}]

GET /v2/apps/bug/164?embed=app.tasks

{
  "app":{
    "id":"/bug/164",
    "ports":[
      10005,
      10006
    ],
    "portDefinitions":[
      {
        "port":10005,
        "protocol":"tcp"
      },
      {
        "port":10006,
        "protocol":"tcp"
      }
    ],
    "tasks":[
      {
        "state":"TASK_RUNNING",
        "ports":[
          31018
        ],
        "id":"bug_164.adaf2c2c-e88d-11e6-ae5c-a44e31765720",
        "appId":"/bug/164"
      }
    ]
  }
}

Can service be processed anyway, despite the inconsistency between app definition and running task Totally 'ignoring' such cases may not be the best idea.

I concur. If port counts differs between task and app we can check version and if it differs to we can skip registration of whole task. This approach could work but does not prevent situation when port definitions totally changed but port counts stays the same.

Coverage increased (+0.01%) to 90.903% when pulling 6647e8e005632a0c1c4649f313f3946195e71f59 on bugfix/#164/check_ports_bounds into 73e66724bbeabd537b90490fd3d7aae5e363416d on master.


Use asynch invocations for create/update/delete operations

Today all of our calls are synchronous - that is, we make a call and sit and wait on the work to happen before returning.  For some calls, that's unavoidable; if someone asked to see the details for a particular portfolio, we do in fact have to wait on all of those details (like the details for each stock owned) to return from the downstream microservices before returning the result back to the client.  As an aside, there are things we can do, like using a CQRS pattern, to speed up queries, so that the GET calls return faster.  But putting that aside for now, there's no reason we need to wait on the other calls that request some work happen in the system, such as creating a new portfolio, or deleting one, or updating one (like to buy or sell stock).
Those could be made using the asynch REST call pattern (as my co-author explains in chapter 4 of our book: https://www.amazon.com/Practical-Cloud-Native-Java-Development-MicroProfile/dp/1801078807, or at this blog: https://openliberty.io/blog/2019/01/24/async-rest-jaxrs-microprofile.html).  The only caveat is that if the client immediately attempts to view stuff - like if it shows all portfolios in the system immediately after creating a new one - the list might not show the newly created one (it would be a race condition as to whether it was in place in time to show up in the quickly issued query).  Same with buying stock; if we make that asynch, but the client immediately shows details of the given portfolio, the newly bought stock might not show up.  We could potentially code in a sleep for 100 milliseconds or whatever, or other approaches to not make it be the query is happening the very next millisecond after the create/update/delete.

Note that issue #5 tracks making the get all query faster via pagination, for the case of lots of portfolios in the system.  That essentially makes all pages other than the first handled asynchronously (that is, in separately issued REST calls - not waiting on a million to return if you only want to see the first 20).


Display Carbon Tax Exemption ID when Operation is Approved

Description:
This captures the final piece of the carbon tax exemption workflow: when an Operation's carbon tax exemption status is Approved, what happens next?
Number format proposed by business: yy-xxxx (two digit year followed by consecutive numbering). E.g. 24-0001
If the submission in rejected, show rejection page; no Exemption ID is generated.
Wireframe: https://www.figma.com/file/LsDmLDCdnJqI8UahyqvOD8/OBPS-App-Designs?type=design&node-id=340%3A383&mode=design&t=5ZQBmcc61TmYu2p1-1
Acceptance Criteria:
Given I am a CAS internal staff member
When I approve an Operation's application
Then a carbon tax exemption certificate number should be generated, stored in the database, and displayed on screen
Given I am an IO user with admin or reporter role for a certain Operation
When my Operation has been approved for carbon tax exemption
Then I can view my operation's exemption number
Development Checklist:

[ ] each approved Operation's exemption ID number should be unique - we'll need to test this thoroughly. (Andrea's opinion: ideally, exemption ID number generated by database rather than Python backend. This will ensure uniqueness and sequential ordering without race conditions. Will also greatly simplify testing because we can trust Postgres's logic much more than our own custom logic.)
[ ] Checklist item
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

This could be estimated while we wait to hear back about the exact numbering convention, but it cannot be worked on until we have that number.

Number format proposed by business are: yy-xxxx (two digit year followed by consecutive numbering). E.g. 24-0001.
Dev's, please let me know if you see any issues with this format.

The page can be built with draft text as currently shown in wireframes and may need to be updated later.

Design just needs a few updates and then the wireframe link will be added to this ticket.

Hey team! Please add your planning poker estimate with Zenhub @andrea-williams @BCerki @dleard @JoshLarouche @marcellmueller @Sepehr-Sobhani @shon-button

@andrea-williams I believe that assigning a unique property to the data field would ensure its uniqueness. Therefore, I strongly recommend using the built-in functionalities of Django instead of relying on raw SQL queries. This way, we can maintain a cleaner workflow during development and testing.

thanks @Sepehr-Sobhani - I've updated the Development Checklist in this ticket to incorporate your suggestion

@hannavovk noted that the name will change - we will create a separate TINY card to address that once the name is approved.

The ID name has now been finalized: "Exemption ID" is now "BC OBPS Regulated Operation ID" (or BORO ID).
If it makes sense to change the name as part of this ticket, feel free to do that. Otherwise we can make that a separate task.
Note that other text on this page is yet to be finalized.
cc @Sepehr-Sobhani @andrea-williams @dleard

I have created this task ticket: https://app.zenhub.com/workspaces/team-moose-sprint-board-60d216175a2689000ec774d0/issues/gh/bcgov/cas-registration/427
Please feel free to refine it.
@dleard Have I included all the required data fields?

perhaps a status column for valid/revoked? Other than that this looks good, we could also ask Jairo if there's any other metadata about the exemption ID that CAS thinks would be helpful

Will be addressed by ticket: #427


Create survey

Motivation and Context
We want to be able to add surveys to RM.
What has changed
Created the full stack of Response Operations: UI & API.
How to test?
Build using make build then start it using docker dev make up then navigate to http://localhost:7777
Links
Trello: https://trello.com/c/0aP9EBOU
Screenshots (if appropriate):

 ROps UI - first feature - create survey - PART ONE (13)


the /tmp directory

The auth service writes lots to a /tmp directory.

Why?
Why is this not documented
This directory will grow and grow as the service runs consuming disk space making it difficult to track down since it's inside the container.

Currently we have to volume mount /authlogs:/tmp when running the process so we can prune these log files.
Using any cli flags when starting the process doesn't limit the creation of these log files:
auth_server.5fe4bb4505db.unknownuser.log.INFO.20180727-181500.1

This is a function of the glog library that is used in the server: https://github.com/golang/glog
According to the source code you should be able to use the -logtostderr=true -alsologtostderr=false flags to only log to sderr instead of files.
Note: You don't technically need to set the -alsologtostderr flag since the default is false but I put it here for explicitness.

ALSO, why is this file a binary file? When i attempt to less the file i get the following:
"auth_server.5fe4bb4505db.unknownuser.log.INFO.20180727-181500.1" may be a binary file. See it anyway?

Though cating the file seems to work just fine. Attemping to parse these logs using logstash/filebeat fails because I end up with a wall of /u0000 and I think there's something going on with the way either docker_auth is writing the log files and or the way glog is being used.
I'm not a go dev unfortunately so knowing where or how or why by looking at the code is not in my wheelhouse.

closing, thanks for the response. sorry for the noise


IB 1-minute streaming data

Dear shlomikushchi
Do you have a plan to develop IB 1-minute streaming data  bundle?
You know, alpaca has already developed pylivetrader that support alpaca data and order execution.  It looks like re-invent wheels at zipline-trader.
ib data bundle is really urgent requirements.
Thanks for your great job.

Hi,
IB data is really slow for minute data. I will add it in the future but some things have higher priority
pylivetrader is great but it doesn't have a backtester. with zipline-trader is you could backtest and research too

Hi shlomikushchi,  Thanks for providing the clarifications.
ib_insync is a great wrapper. It would save a lot of time.

ib_insync is great. still ib limits are hard to work with.
working with a small dataset is fine. try to get minute data for 1000s of stocks daily - impossible


Ability to choose which view the datepicker opens to?

Pretty slick plugin-- great work (and the source code looks good too)!
I'm specifically using this for a birthday date picker, so the year is the starting point. Right now, users have to click the title bar from the day view, then again from the month view, then scroll through decades to find their birth year, then drill back down to the exact date. It would be handy to be able to skip the first half and show the the year view first.
FWIW, I'd be willing to submit a pull request for this, but I don't wanna start that unless there's some prospect of the changes being merged in, since I also don't want to spawn and support my own fork.
Thoughts?

I'd be open to reviewing a PR for this.

Sweet, I'll submit it soon!


(Loosely) document return types

What I currently miss in the documentation, especially in the "From numpy to xtensor" cheat-sheet is some loose indication of the return types, or at least how to use them.
One could think of a link to an example on some crucial points.

I think the point is to mostly use auto.


Update readme to reference contributor license agreement

Atlassian has an internal process for managing its open source projects. This PR adds the CLA to gostatsd.
@kisielk, I'm a developer working with @ash2k (though I've mainly been lurking until now). Would you be willing to accept this agreement to cover your past contributions to gostatsd?
Please note that signing this agreement doesn't change your ownership of any code you wrote or how you are credited in the project documentation, it just grants some protections our lawyers tell us we need to manage this kind of project. It can be done entirely online at https://na2.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=3f94fbdc-2fbe-46ac-b14c-5d152700ae5d

Fine by me.

Thanks @kisielk, that's great.

@aelse I signed the agreement

@kisielk Thanks for doing that, it makes things easy for me. And thanks for your work on this project :)
@ash2k Please merge in.


Compilation Error while compiling Thrust Library with CUB-HIP as sub module.

The below compilation errors are thrown from CUB-HIP while exercising Thrust API in HIP/ROCm path. CUB-HIP is a sub-module in Thrust.
While traversing through the folder the compiler searches for a file present one level before the actual one.
../thrust/system/cuda/detail/cub/device/dispatch/dispatch_select_if.cuh:46:10: fatal error: '../../hip_helpers/forwarder.hpp' file not found
#include "../../hip_helpers/forwarder.hpp"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../thrust/system/cuda/detail/cub/device/dispatch/dispatch_reduce_by_key.cuh:46:10: fatal error: '../../hip_helpers/forwarder.hpp' file not found
#include "../../hip_helpers/forwarder.hpp"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../thrust/system/cuda/detail/cub/device/dispatch/dispatch_rle.cuh:47:10: fatal error: '../../hip_helpers/forwarder.hpp' file not found
#include "../../hip_helpers/forwarder.hpp"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Steps to reproduce:
$ git clone https://github.com/ROCmSoftwarePlatform/Thrust.git
$ cd Thrust
$ export HIP_PLATFORM=hcc (For HCC Platform )
$ cd examples
$ cp histogram.cu histogram.cpp
$ /opt/rocm/bin/hipcc histogram.cpp -I../ -o histogram.cpp.out
Solution: The below solution  can be incorporated.
In file ../thrust/system/cuda/detail/cub/device/dispatch/dispatch_select_if.cuh
Line no:46
-   #include "../../hip_helpers/forwarder.hpp"
+  #include "../../../hip_helpers/forwarder.hpp"
The above solution can be implemented in the other two files mentioned above.

Could you create a pull request for this please?  Thanks!

@scchan
pull request has been submitted for regression issues on HIP/CUDA.
#7

I'm seeing
In file included from /usr/local/include/thrust/system/cuda/detail/cub/device/device_histogram.cuh:41:
/usr/local/include/thrust/system/cuda/detail/cub/device/dispatch/dispatch_histogram.cuh:47:10: fatal error: '../../../hip_helpers/forwarder.hpp' file not found
#include "../../../hip_helpers/forwarder.hpp"

when building the ROCm fork of Pytorch.


switch to expires_at

I thought this was required but I am not so sure.
For Google the expires_at for me tends to be 21 days in milliseconds. I think it might refer to when the refreshtoken expires?
Multiplying it by 1000 is definitely not the answer.


Feature Request:  expand rolls based on other attributes.

Is it possible to make an attack roll based on another Attribute? Would be useful for ruses or beats.
[S:Saber(B:IQ)]
Is working, but ...
[M:Saber(B:IQ)]
is not.

Doable, but painful.    How often do you do something like this?  And why?

Ok, I understand.
Well, when it comes to using it for attacks, it boils down to ruses and beats used for feinting.
We really can use OTF´s for that!
.
.
On the other hand, when it comes to Using Skills With Other Attributes in general, it is a whole different topic.
It would be fantastic to have an easy and quick way to change the Attribut the Skill roll is based on.
Like right clicking on the Skill Level "button" and selecting in the context menu the Attribute to base the roll on.
Or, lift-click in the RSL (relative skill level) column of the skill and than select in a pop-up menu the attribut to base the roll on.
We use it every game session.
It is, at least for my group, an integral part of how skills work. We change the governing attribute all the time depending on the circumstances the skill is used for. (B172) gives a few examples.
On the SJ-forum there is a whole thread about it:
http://forums.sjgames.com/showthread.php?t=136940
Wherein Kromm sums it up:

I float an extremely high proportion of skill rolls because my internal thought processes go something like this: "What training would be useful here? Okay, now what natural quality would be important?" If the answers end up being "cooking" and "persistence," then you'll be rolling vs. Will-based Cooking to deal with eye-watering onions, even if you aren't cooking per se and even though Cooking isn't Will-based. Sometimes you'll get to slash foes (not parry or feint, but at least attack) with DX-based Cooking, and that will help your noncombatant chef with DX 10, IQ 13, and Cooking at IQ+3 survive (because DX+3 beats a Knife default of DX-4). Sometimes you'll end up challenged by the DX-based flair move needed to impress the dignitaries (because DX+3 isn't as good as IQ+3 for you). It all comes out in the wash over the course of hundreds of hours of roleplaying. It doesn't make sense to think in terms of whether this practice "penalizes" someone, unless you're a rigid thinker who needs known quantities to have fun – in which case my games won't be fun, because I routinely float skills, make secret rolls, assess hidden modifiers, say "Roll dice" without explaining why, etc. in the service of suspense, mystery, or the reality that some things are unknowable.


[Request] Format the already exported chat as txt

I have the decrypted chat as txt (I already exported it from More -> Export Chat).
Is it possible to allow to have this result:

by input that plain text?

You mean reading the export txt file and produce a HTML page like what this exporter does?

Yes

Sure. I will look into it.

Sure. I will look into it.

I wish it is .txt too. Anyway, is it possible you pack the python script become executable (.exe)? it will be more convenient

Agree, let's move the discussion of making executable to #29.

I implemented the feature in 0897dc2. Feel free to try it in the dev branch and report any issues.

Released in 0.9.5.


is_categorical is deprecated in Pandas 1.1, use is_categorical_dtype instead

Apparently is_categorical is deprecated in pandas 1.1, as you probably already know:
https://github.com/pandas-dev/pandas/pull/33385
Here are the instances I can find:
https://github.com/theislab/anndata/blob/master/anndata/_core/anndata.py#L1094
https://github.com/theislab/anndata/blob/master/anndata/_core/anndata.py#L1192
https://github.com/theislab/anndata/blob/master/anndata/tests/test_readwrite.py#L8
Here is how highly_variable_genes look like, a bit annoying:

Good to know! I've been on pandas<1.1 since it breaks our tests. It might be a bit difficult to make a PR for fixing this until pandas 1.1.1 is released (tracking issue: https://github.com/pandas-dev/pandas/issues/35489).


Test  for the net builder functions

Details in the test file.

@eladsal great job writing this test! I guess we have a little more work to do, to figure out why the results are different when the network is saved and not saved.

Also you should look at the Travis log.  Your test isn't building clean there.

@michaeltryby I see these warnings and I should look into that. Strings in C always make me sweat :(

Anyone care to help fix the warnings in the travis-ci build before we merge?
warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]

I think if YOU do a cast like so,
error = EN_getnodeindex(ph, (const char *)"2", &Nindex);

it should fix it.

Will try, thank YOU.

@michaeltryby now it fails. Probably did it wrong :(

The compilers did not like that.

This is strange.  After the commit the build failed. After I reverted the commit travis-ci fails the test.

@eladsal my mistake we should cast to (char *) not (const char *).
Visual Studio compilers don't seem to care. This works on MinGW gcc so should work on Travis.

Thanks @michaeltryby, the builds are fine, no warnings and tests are passing. Ready to merge...

@eladsal I went ahead and fixed the compiler warnings. Is it okay with you if I push a commit to your fork?

@michaeltryby I already pushed the fix :)

Rather then cast the filenames we should declare them as const. Also there is a warning coming from line 89 in the test. Loss of precision in declaration. It can be fixed like so.
float P[12] = { 1.0f, 1.2f, 1.4f, 1.6f, 1.4f, 1.2f, 1.0f, 0.8f, 0.6f, 0.4f, 0.6f, 0.8f };

@michaeltryby be my guest and push your fix. Thanks!

Good to merge!


Package is dependent on an outdated copy of tsconfig-paths

While noted in #2649 that there is a path to resolving the CVE warnings around json5 currently, there's still the issue that this package is dependent on an outdated version of tsconfig-paths (^3.14.1) when major release newer version exists (^4.1.2) which both fixes and extends some issues the package had with parsing the tsconfig.json and also bumps their dependency on json5 up to 2.2.2, bringing it in line with other libraries that depend on json5.
Unless there's a strong conflict that prevents this package from upgrading, I'd request for the health of node_modules folders everywhere if this package could move to the next major release.

There is a strong conflict, which is discussed at length in #2447.
Note that it's not inherently "unhealthy" or bad to be on "not the latest major version line".

I mean that mostly in that we have to keep both the @1 and @2 copies of json5 in our dependency trees, managing each of their respective CVEs and updates. Thanks for the point to 2447.

Sure, but since the vast majority of CVEs in the JS ecosystem are false positives due to the CVE system's lack of code path nuance, it's a nightmare regardless.


Adding GANAuxiliaryLoss

Add a new namedtuple to contain the auxiliary loss settings.
Add a named argument to GANEstimator constructor,
so that GANEstimator can make use of auxiliary losses.

Use work e-mail on one of the commit, re-signed cla from work account.

The ability to use special TF-GAN behavior with GANEstimator will be added when tensorflow_gan is released as its own repo. I'm just waiting for internal approval. @martinwicke

Any estimate on a time frame? I was also going to make a pull request to better control what is returned from GANEstimator.predict, should I hold off on that as well?

The code has been ready to be pushed for over a month, but we're waiting on an internal process. Sorry I can't be more specific on timeframe. @martinwicke for more detail.
Perhaps in the meantime you could make local code changes for whatever you're working on, and you can switch to the new version when it becomes available (it's a bit cleaner, too). Once that's available, I would really appreciate a PR giving finer control over the generator output. Sound reasonable?

Can one of the admins verify this patch?

The tf.contrib submodule will not be part of tensorflow after the 2.0 release.
It looks like the tensorflow_gan repo is up.
So please remake this PR on that repo.
Thanks.


DRAFT: Add hypermodel weights to hypermodel cores

This PR searches a chain directory for a model_log_weights.json file when creating a hypermodel core. It stores these weights in the HypermodelCore.
Additional functionality might include weighted noise flower plots or nmodel histograms.
I am attempting to make a PR in enterprise extensions, which will automatically save hm weights to the chain directory.

@Hazboun6
i have tested this and it should be ready to merge