Support getting methods using metaclasses

If a metaclass has a __getattr__ method, __dict__ won’t cut it.

The test suite fails, plus you have not added any tests of your own. Fix those problems and I will review this.

Hmm, seems like I can’t:
Both static methods and normal methods return types.FunctionType instances on getattr (class methods return types.MethodType objects aka bound methods.)
We could use object.getattribute(outer, method_name), but that one probably just uses __dict__ internally…

@flying-sheep  I've rebased on main, can you please fix the CI, thanks!

You didn’t!

I did but then further changes were made to main that made it out of date.

Interesting that such a trivial change can have conflicts at all. I just remade it.

@flying-sheep can you please force push back 9ace51eade7dda1e9b98b6266b4316bf6cc4b7be, I by mistake overwritten this branch. Thanks :pray:

On a deeper look, I'm actually not sure how this can happen. The method must already be manifested because otherwise it would not be passed in. I'm closing until we can come up with a case that replicates it :thinking:


Package after the path is an absolute path, resource files can't find it

Is this a bug report?
(write your answer here)

Can you also reproduce the problem with npm 4.x?

(Write your answer here.)
Which terms did you search for in User Guide?

(Write your answer here if relevant.)
Environment

node -v:
npm -v:
yarn --version (if you use Yarn):
npm ls react-scripts (if you haven’t ejected):

Then, specify:

Operating system:
Browser and version (if relevant):

Steps to Reproduce

(Write your steps here:)

Expected Behavior

(Write what you thought would happen.)
Actual Behavior

(Write what happened. Please add screenshots!)
Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

Sorry, but there is not enough information in this bug report to help.
Please fill out the template and open a new issue with reproduction steps (or a more detailed explanation of your problem and what you want to achieve).


How can I copy a file generated during pod startup to another pod in helm?

We have a requirement where we have to copy a file which is generated during container startup to another container running in different pod.
As of now, we are using kubectl cp to copy the file from the source pod to local first and then from local to the destination pod.
What are the ways to achieve this in helm?
Helm Version:"v3.0.0-beta.5"

Helm does not provide a features targeted at this.
The Kubernetes community wants things done in a declarative way. You tell the API what you want and it makes it work. kubectl may be dropping the cp command, too.
A method you could use for this is to setup a shared storage location. The file is copied in there by one pod and copied out by another pod.

Thanks Matt for the answer.
And sorry for the delay in closing the issue.


feat: lower permissions req to Contributor

We used to require Editor or above to allow someone to use Presentation Tool when previewUrl.previewMode.enable was used, as it creates documents in your dataset with secrets, and used to have a sanity-preview-url-secret.** document _id prefix.
The sanity-preview-url-secret. prefix ensures the documents can't be queried without being Viewer or above. But the downside is that Contributor roles can only create drafts. prefixes.
By moving to drafts. Contributor can now use Presentation Tool 🥳
Enterprise customers can with custom roles setup access for Viewer roles as well. We always supported this, but didn't document how to set it up. I've updated the README with a step-by-step for how to use it.
Viewers and below also now see a toast message when they can't create preview secrets:

Instead of a crash like we had before.
Applications that don't make use of previewUrl.previewMode.enable works just fine with Viewer and above on all price plans.
BEGIN_COMMIT_OVERRIDE
feat: lower minimum role from Editor to Contributor for creating Preview URL Secrets necessary to start Draft Mode
END_COMMIT_OVERRIDE

This is great and in-line with policy. Thanks you for the attention to detail on this.


Uri downloadUrl = taskSnapshot.getDownloadUrl(); not working

getDownloadUrl() does not seem to exist anymore. Looking at the firebase-documentation it looks like this method is called on the reference now not taskSnapShot.  I have tried the following but the image is not uploaded:
StorageReference taskSnapshotStorage = taskSnapshot.getStorage();
                       Uri downloadUrl = taskSnapshotStorage.getDownloadUrl().getResult();

Try using this
Task<Uri> task = taskSnapshot.getMetadata().getReference().getDownloadUrl();
task.addOnSuccessListener(new OnSuccessListener<Uri>() {
       @Override
        public void onSuccess(Uri uri) {
              String photoLink = uri.toString();
        }
});

This things works.... tnxs alot... i worked for me after trying so many solutions

I faced the same problem but I got the answer
Just add .getStorage()  infront of .getDownloadurl
to be like this below
.getStorage().getDownloadUrl

LEAVE EVERYTHING IN THAT LINE DONT ALTER JUST ADD .getStorage()

I hope that! I really want to work from home and to make money.
Anyone an got idea, please replay me!

I have a problem, I am getting the storage location instead of the download URL. From my Firebase storage. How can I fix this?
I tried the code below.
Task task = taskSnapshot.getMetadata().getReference().getDownloadUrl();
task.addOnSuccessListener(new OnSuccessListener() {
@Override
public void onSuccess(Uri uri) {
String photoLink = uri.toString();
}
});

Worked really well for me. Thanks


Panics are logged as a crashes

With the recent changes to the crash log, it seems panics are also considered as crashes and logged as such. This behaviour is wrong. Panics should not be considered as crashes.
For example, now all the unit tests with panics print logs similar to the following:
ballerina-new-parser-test-suite > jballerina-test > org.ballerinalang.test.bala.functions.DependentlyTypedFunctionsBalaTest > testRuntimeCastError STANDARD_ERROR
    [2021-06-15 11:15:22,003] SEVERE {b7a.log.crash} - error: {ballerina}TypeCastError {"message":"incompatible types: 'map' cannot be cast to 'map<anydata>'"}
        at testorg.foo.dependently_typed.1_0_0:query(interop_funcs.bal:43)
           dependently_typed_functions_bir_test:testRuntimeCastError(dependently_typed_functions_bir_test.bal:68)
    io.ballerina.runtime.internal.util.exceptions.BLangRuntimeException: error: {ballerina}TypeCastError {"message":"incompatible types: 'map' cannot be cast to 'map<anydata>'"}
        at testorg.foo.dependently_typed.1_0_0:query(interop_funcs.bal:43)
           dependently_typed_functions_bir_test:testRuntimeCastError(dependently_typed_functions_bir_test.bal:68)
        at org.ballerinalang.test.BRunUtil.lambda$invoke$2(BRunUtil.java:435)
        at io.ballerina.runtime.internal.scheduling.SchedulerItem.execute(Scheduler.java:597)
        at io.ballerina.runtime.internal.scheduling.Scheduler.run(Scheduler.java:327)
        at io.ballerina.runtime.internal.scheduling.Scheduler.runSafely(Scheduler.java:295)
        at java.base/java.lang.Thread.run(Thread.java:834)

In the cli we catch and handle RuntimePanicException: https://github.com/ballerina-platform/ballerina-lang/blob/5804ecbf1f34c56c7c60c1d1573134349de09f0e/cli/ballerina-cli/src/main/java/io/ballerina/cli/launcher/Main.java#L72-L73
AFAIU, this should be thrown as a RuntimePanicException from the runtime if it should not crash.
@warunalakshitha thoughts please.

IMO this should be handle by runtime. @riyafa

@pubudu91 Is this in the master branch? When I run the following code with this PR: https://github.com/ballerina-platform/ballerina-lang/pull/31098 I get only an error log:
public function main() {
    panic error("Returning an error");
}

Error log:
error: Returning an error

Can you please provide a sample code where crash log is printed for panic?

@pubudu91 can you please provide a code to reproduce this issue?

@pubudu91 can you please provide a code to reproduce this issue?

Sorry, missed this. This only seem to be occurring in tests. Didn't see this when using the jbal tools distribution

Is this issue still valid? If so can you please provide example test cases to test this?

Yes, it's still valid. Just checked in latest master. Run the tests in jballerina-unit-test module. You should see logs such as the ones mentioned above getting printed for test cases which have used panics.

Notice this when running jballerina-unit-tests and send a quick fix with https://github.com/ballerina-platform/ballerina-lang/pull/31437


chore(tests): improve GHA pytest-cov performance

Thanks for submitting a PR! Please check the boxes below:

[ ] I have run pre-commit to check linting
[ ] I have filled in the "Changes" section below?
[ ] I have filled in the "How did you test this code" section below?
[ ] I have used a Conventional Commit title for this Pull Request

Changes
Please describe.
How did you test this code?

Please describe.

Codecov Report
Patch and project coverage have no change.

Comparison is base (9389e4e) 95.44% compared to head (d4a94b7) 95.44%.

:exclamation: Current head d4a94b7 differs from pull request most recent head 2933391. Consider uploading reports for the commit 2933391 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2575   +/-   ##
=======================================
  Coverage   95.44%   95.44%
=======================================
  Files         975      975
  Lines       27221    27221
=======================================
  Hits        25981    25981
  Misses       1240     1240

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


StompClientConnection closeHandler is called twice

It looks like the handler is attached to the tcp socket close event and the ponger timeout.  This can cause the socket to reconnect twice if, for example, you have configured a closeHandler to automatically reconnect on close.
Thanks

Can you provide a short reproducer ?

I haven't got a self contained example but have a look at the constructor of StompClientConnectionImpl.
public StompClientConnectionImpl(Vertx vertx, NetSocket socket, StompClient client,
                                   Handler<AsyncResult<StompClientConnection>> resultHandler) {
    this.socket = socket;
    this.client = client;
    this.resultHandler = resultHandler;
    this.context = vertx.getOrCreateContext();

    FrameParser parser = new FrameParser();
    parser.handler(this);
    socket.handler(buffer -> {
      lastServerActivity = System.nanoTime();
      parser.handle(buffer);
    })
        .closeHandler(v -> close());

  }

and ...

          log.error("Disconnecting client " + client + " - no server activity detected in the last " + deltaInMs + " ms.");
          client.vertx().cancelTimer(ponger);
          disconnect();

If the ponger times out, it will call disconnect(), which calls the closeHandler, which closes off the socket, calling the closeHandler again.

See PR #21


named image transform restricting bounded resize on PSD files

We are using the named transform servlet for our images... we have a large transform set at 1500px wide. However it is being restricted to 1280px (seems to be an AEM default) instead of respecting the servlet dimensions. Any thoughts on how to fix? http://assets.microncpg.com/content/dam/crucial/dram-products/server/ecc-sodimm/images/product/crucial-ddr3-ecc-sodimm-kit4-image.psd.transform/large/image.png
here is our config:

<jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" jcr:primaryType="sling:OsgiConfig" name="large" transforms="[bounded-resize:width=1500]" />
Strange thing is that it works as expected on a smaller size at 1000px:
http://assets.microncpg.com/content/dam/crucial/dram-products/server/ecc-sodimm/images/product/crucial-ddr3-ecc-sodimm-kit4-image.psd.transform/medium/image.png
Seems to be a restriction on transforms on PSD files as it works if we target a larger rendition with a transform:
http://aemauthor.microncpg.com:4502/content/dam/crucial/dram-products/server/ecc-sodimm/images/product/crucial-ddr3-ecc-sodimm-kit4-image.psd/_jcr_content/renditions/cq5dam.resized.2000.2000.png.transform/large/image.png

By default, when you access a DAM asset directly as in your first URL, the first rendition matching the regex cq5dam\.web\.(.*) is used. This can be configured through the prop.asset-rendition-picker-regex configuration property of the Named Transform Image Servlet.
so it seems like in this case you want to configure it to use the pattern cq5dam\.resized\.2000\.2000
Perhaps this option needs to be better documented.

cool, thanks @justinedelson so where is that configuration property on the servlet?

It is in OSGi ConfigAdmin

sweet, thanks

@justinedelson how would I set this asset-rendition-picker-regex up in an xml file so it will be stored in source control?
Thanks!

@zschill it depends a bit on the your project structure, but in general, you would create the XML file in /src/main/content/jcr_root/apps/yourproject/config and name it com.adobe.acs.commons.images.impl.NamedTransformImageServlet.xml.

Thanks, would I only need to add the settings that need to be overridden in the xml file?  Also what would the actual syntax be for the setting?  I can't seem to find documentation that lays it out very well.

Have you read through https://docs.adobe.com/docs/en/aem/6-2/deploy/configuring/configuring-osgi.html and https://sling.apache.org/documentation/bundles/jcr-installer-provider.html ?

I think what I had been looking at was outdated.  I'll look through these, thanks!


Allow function level runtime override

Added support function level runtime override :
service: my-service
provider:
  name: kubeless
  runtime: nodejs8
functions:
  myFunction1:
    handler: nodejs10handler.handle
    runtime: nodejs10
  myFunction2:
    handler: nodejs8handler.handle

Analog of the function runtime override in the AWS provider:
https://serverless.com/framework/docs/providers/aws/guide/functions#configuration

Thank you for the patch @janthoe! Would you mind bumping the version in the package.json so this get automatically released?

@andresmgot done!
Thanks for the quick review 🙇


Installation: make local fails trying to find Nginix

I am trying to set up a development environment on docker. Make demo works fine, but we would like to try different modules and themes as well. When I run make local I get the following.
isle-dc[development]> sudo make local
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3432  100  3432    0     0  10929      0 --:--:-- --:--:-- --:--:-- 10929
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1708  100  1708    0     0   8172      0 --:--:-- --:--:-- --:--:--  8133
docker-compose pull
Pulling activemq   ... done
Pulling alpaca     ... done
Pulling blazegraph ... done
Pulling cantaloupe ... done
Pulling fcrepo     ... done
Pulling fits       ... done
Pulling crayfits   ... done
Pulling homarus    ... done
Pulling houdini    ... done
Pulling hypercube  ... done
Pulling mariadb    ... done
Pulling matomo     ... done
Pulling milliner   ... done
Pulling recast     ... done
Pulling solr       ... done
Pulling traefik    ... done
Pulling drupal     ... done
Pulling watchtower ... done
Unable to find image 'islandora/nginx:latest' locally
docker: Error response from daemon: manifest for islandora/nginx:latest not found: manifest unknown: manifest unknown.
See 'docker run --help'.
make: *** [local] Error 125

As a hail mary I also tried sudo make local with the same results.

Have the same error make local should use the tagged release of nginx from islandora.

The make local command has been replaced by documentation.
$ make local
make local has been removed. To create a demo site, please follow the instructions at https://islandora.github.io/documentation/installation/docker-local/


Drop downs and popup menus have opposite material bugs

You can't interact with an item on a popup menus before it has finished animating in.
You can interact with an item in a drop down menu, but doing so will draw ink splashes in the air before the material has painted there.
We should come up with a rationalisation that solves both these problems cleanly.

Both dropdown and popup menu issues are not reproducing on the latest master
Dropdown Issue
When tapping before the material is created doesn't draw ink splash

Ink Splash occurs after the material is created

code sample
// Flutter code sample for DropdownButton

// This sample shows a `DropdownButton` with a large arrow icon,
// purple text style, and bold purple underline, whose value is one of "One",
// "Two", "Free", or "Four".
//
// ![](https://flutter.github.io/assets-for-api-docs/assets/material/dropdown_button.png)

import 'package:flutter/material.dart';
import 'package:flutter/scheduler.dart';

void main() {
  timeDilation = 20;
  runApp(MyApp());
}

/// This Widget is the main application widget.
class MyApp extends StatelessWidget {
  static const String _title = 'Flutter Code Sample';

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: _title,
      home: Scaffold(
        appBar: AppBar(title: const Text(_title)),
        body: Center(
          child: MyStatefulWidget(),
        ),
      ),
    );
  }
}

class MyStatefulWidget extends StatefulWidget {
  MyStatefulWidget({Key key}) : super(key: key);

  @override
  _MyStatefulWidgetState createState() => _MyStatefulWidgetState();
}

class _MyStatefulWidgetState extends State<MyStatefulWidget> {
  String dropdownValue = 'One';

  @override
  Widget build(BuildContext context) {
    return DropdownButton<String>(
      value: dropdownValue,
      icon: Icon(Icons.arrow_downward),
      iconSize: 24,
      elevation: 16,
      style: TextStyle(color: Colors.deepPurple),
      underline: Container(
        height: 2,
        color: Colors.deepPurpleAccent,
      ),
      onChanged: (String newValue) {
        setState(() {
          dropdownValue = newValue;
        });
      },
      items: <String>['One', 'Two', 'Free', 'Four']
          .map<DropdownMenuItem<String>>((String value) {
        return DropdownMenuItem<String>(
          value: value,
          child: Text(value),
        );
      }).toList(),
    );
  }
}

Popup menu Issue
We can interact and pop popup item before it finishes animation

code sample
import 'package:flutter/material.dart';
import 'package:flutter/scheduler.dart';

void main() {
  timeDilation = 20;
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatefulWidget {
  @override
  _HomeState createState() => _HomeState();
}

class _HomeState extends State<Home> {
  String _selection;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: PopupMenuButton<WhyFarther>(
          onSelected: (WhyFarther result) {
            setState(() {
              // _selection = result;
            });
          },
          itemBuilder: (BuildContext context) => <PopupMenuEntry<WhyFarther>>[
            const PopupMenuItem<WhyFarther>(
              value: WhyFarther.harder,
              child: Text('Working a lot harder'),
            ),
            const PopupMenuItem<WhyFarther>(
              value: WhyFarther.smarter,
              child: Text('Being a lot smarter'),
            ),
            const PopupMenuItem<WhyFarther>(
              value: WhyFarther.selfStarter,
              child: Text('Being a self-starter'),
            ),
            const PopupMenuItem<WhyFarther>(
              value: WhyFarther.tradingCharter,
              child: Text('Placed in charge of trading charter'),
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

enum WhyFarther { harder, smarter, selfStarter, tradingCharter }

flutter doctor -v
[✓] Flutter (Channel master, 1.22.0-10.0.pre.82, on Mac OS X 10.15.6 19G2021,
    locale en-GB)
    • Flutter version 1.22.0-10.0.pre.82 at
      /Users/tahatesser/Code/flutter_master
    • Framework revision 9248fda410 (11 hours ago), 2020-09-03 16:08:01 -0700
    • Engine revision 3f05b521b9
    • Dart version 2.10.0 (build 2.10.0-86.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.7)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.7, Build version 11E801a
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 48.1.2
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.48.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.14.0

[✓] Connected device (4 available)
    • iPhone 11 (mobile) • EDB19945-0B9F-4A6E-BAA1-425E68E3B6D6 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-13-7 (simulator)
    • macOS (desktop)    • macos                                • darwin-x64
      • Mac OS X 10.15.6 19G2021
    • Web Server (web)   • web-server                           • web-javascript
      • Flutter Tools
    • Chrome (web)       • chrome                               • web-javascript
      • Google Chrome 85.0.4183.83

• No issues found!

@Hixie
Can we close this issue?


import graphlab error

I have installed graphlab using pip install graphlab
anaconda & miniconda are also installed in my ubuntu 16.10
How to fix this error?

https://github.com/utkarshrai/TweetAnalysis/blob/master/graphlab/Setting_Up_graphlab_on_Linux.md
I just uploaded some screenshots.


delete yurtctl-lock and yurt-tunnel-nodes when revert the whole cluster

What type of PR is this?
/kind bug
What this PR does / why we need it:
Delete the yurt-tunnel-nodes configmap and yurtctl-lock when revert the whole openyurt cluster back to k8s cluster.
Which issue(s) this PR fixes:

Fixes #531
Special notes for your reviewer:

I'll add the test log in the following comment.

First we check the configmap, then revert the cluster and check whether both configmaps are deleted or not.
Here's the log.
ys3@ys-desktop:~/Github/openyurt$ kubectl get cm -A
NAMESPACE            NAME                                 DATA   AGE
default              kube-root-ca.crt                     1      26m
kube-node-lease      kube-root-ca.crt                     1      26m
kube-public          cluster-info                         2      26m
kube-public          kube-root-ca.crt                     1      26m
kube-system          coredns                              1      26m
kube-system          extension-apiserver-authentication   6      27m
kube-system          kube-proxy                           2      26m
kube-system          kube-root-ca.crt                     1      26m
kube-system          kubeadm-config                       2      26m
kube-system          kubelet-config-1.20                  1      26m
kube-system          yurt-hub-cfg                         1      3m
kube-system          yurt-tunnel-nodes                    1      2m39s
kube-system          yurt-tunnel-server-cfg               4      3m
kube-system          yurtctl-lock                         0      3m51s
local-path-storage   kube-root-ca.crt                     1      26m
local-path-storage   local-path-config                    1      26m
ys3@ys-desktop:~/Github/openyurt$ ./_output/local/bin/linux/amd64/yurtctl revert --yurtctl-servant-image=openyurt/yurtctl-servant:v0.5.0-amd64-555716d
I1030 15:05:47.613824 1264334 revert.go:165] yurt controller manager is removed
I1030 15:05:47.640730 1264334 revert.go:175] serviceaccount for yurt controller manager is removed
I1030 15:05:47.655199 1264334 revert.go:185] clusterrole for yurt controller manager is removed
I1030 15:05:47.715017 1264334 revert.go:195] clusterrolebinding for yurt controller manager is removed
I1030 15:06:39.439657 1264334 util.go:494] servant job(yurtctl-enable-node-controller-openyurt-e2e-test-control-plane) has succeeded
I1030 15:06:39.439821 1264334 revert.go:220] complete enabling node-controller
I1030 15:06:59.497155 1264334 util.go:494] servant job(yurtctl-servant-revert-openyurt-e2e-test-worker) has succeeded
I1030 15:06:59.497283 1264334 revert.go:233] complete removing yurt-hub and resetting kubelet service on edge nodes
I1030 15:07:19.545228 1264334 util.go:494] servant job(yurtctl-servant-revert-openyurt-e2e-test-control-plane) has succeeded
I1030 15:07:19.545369 1264334 revert.go:241] complete removing yurt-hub and resetting kubelet service on cloud nodes
I1030 15:07:19.713284 1264334 revert.go:249] delete yurthub clusterrole and clusterrolebinding
ys3@ys-desktop:~/Github/openyurt$ kubectl get cm -A
NAMESPACE            NAME                                 DATA   AGE
default              kube-root-ca.crt                     1      30m
kube-node-lease      kube-root-ca.crt                     1      30m
kube-public          cluster-info                         2      30m
kube-public          kube-root-ca.crt                     1      30m
kube-system          coredns                              1      30m
kube-system          extension-apiserver-authentication   6      30m
kube-system          kube-proxy                           2      30m
kube-system          kube-root-ca.crt                     1      30m
kube-system          kubeadm-config                       2      30m
kube-system          kubelet-config-1.20                  1      30m
local-path-storage   kube-root-ca.crt                     1      30m
local-path-storage   local-path-config                    1      30m

We can find that both yurtctl-lock and yurt-tunnel-nodes have been deleted.

/lgtm
/approve


make -j24 failed

When building osiris using the script, I after a short ammount of time i get this error. Not sure what it means. I went into the build-log or whatever it's called, and mentioned something about fseeko.c and freehead.c (I USE LINUX DEBIAN)

Show the error message.

This was a issue I solved, will close it. Although I have a other issue with compiling it. Will open another issue


[HOLD for payment 2023-09-12] [$500] When Distance Request Tab is tapped, all waypoints are lost

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to a workspace chat
"+" button next to text composer -> Request money -> Distance request
"Start" -> type and choose an address (this creates one waypoint)
Click "Distance request" tab again

Expected Result:
The start waypoint should remain the same
Actual Result:
The start waypoint is cleared
Workaround:
N/A
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: v1.3.62-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @b4s36t4
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693685299726929
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b0d78086aa76dc15
Upwork Job ID:<PHONE_NUMBER>541106176
Last Price Increase: 2023-09-02

What alternative solutions did you explore? (Optional)
We can also remove this altogether if the purpose of this bug report is that we should not reset the request when any tab is clicked.

We still want to reset the money request information because we are sharing the data for a draft money request. If we don't clear the data when a different tab/request type is selected, draft data from the previous type might be included in the new money request.

so maybe we can also prevent the execution of whole function code if isFocused is true.

I agree let's try this approach 💯

@allroundexperts looking forward for your PR 😄

Missed this 🙂🥲

@trjExpensify @allroundexperts is a C+ and they made the PR
@situchan is also a C+ and they reviewed the PR

Cool, assigning @situchan on the issue as well for tracking.

I have reported this issue. @hayata-suenaga

@b4s36t4 yep you did

Thanks so much Hayata. 🙌

👋 Can we get the checklist filled out please?

Confirming those payments due as follows, correct?

$50 to @b4s36t4 for the bug report
$1000 to @allroundexperts for the fix + #urgency bonus
$1000 to @situchan for the C+ review + #urgency bonus

No regression. Same tab press action was not prevented during first implementation of tab navigator.
Regression Test Proposal

Open FAB > Request money
Click Distance tab
Enter start and finish address
Click again Distance tab
Verify that entered addresses are not cleared

Cool, thanks! I don't think we need to check for this one on every regression run, so I'm going to hold off on that test.
Offers sent on this job.

@trjExpensify I get paid through the App.

Ah of course, I forgot you did. I can retract your offer no worries.

Shouldn't it be 750 instead?

Ah yes, it's 50% bonus. That's cool. I sent offers for the bounty price of $500 and then I add the bonus once accepted anyway. Modified the above though!

Cool, let's close it out!


omit properties of a Constraint or Intersect?

I often use Interesect or Constraint Records, which I want to modify on a different Place:
const myRuntype = Record({
    A: Number,
    B: Number,
}).withConstraint((r) => {
    return r.A > r.B || `A has to be bigger than B`;
});

const myOtherRuntype = myRuntype.omit("A");

I totally understand, that the constraint check will be unclear, if I remove a property involved in the check (I guess that is why the two types lose the omit or pick. Nevertheless I want "myOtherRuntype" to have a structure based on "myRuntype" so that typescript will not complain when I extend it afterwards. Is there a way of doing this?
I mostly want to set optional properties to required (For this I atm interesct with a record which has the corresponding property as required):
const myRuntype = Record({
    A: Number.optional(),
    B: Number,
}).withConstraint((r) => {
    return r.A > r.B || `A has to be bigger than B`;
});

const myOtherRuntype = myRuntype.And(Record({ A: Number }));

But for the opposite case, so either removing or setting a property optional I am a bit lost.
I tried to find this question in the issues but it is difficult to formulate. I am sure there was an issue before.

There's no straightforward way to do it like that. Constraint (and also Intersect) runtype only knows about its underlying runtype (intersectees for Intersect), so if you want to manipulate the underlying one, you have to unwrap first and then rewrap it by a constraint function again, e.g.
const myRuntype = Record({
    A: Number,
    B: Number,
}).withConstraint((r) => {
    return r.A > r.B || `A has to be bigger than B`;
});

const myOtherRuntype = myRuntype.underlying.omit("A").withConstraint((r) => {
    if (myRuntype.underlying.pick("A").guard(r)) {
        return r.A > r.B || `A has to be bigger than B`;
    } else {
        return `A has to be present and a number`;
    }
});

But I don't see the motivation of this, as the above myRuntype and myOtherRuntype are essentially the same.
Optionalizing a property can be done by:
myRuntype.underlying.omit('A').extend({ A: myRuntype.underlying.fields["A"].optional() })

Setting optional properties to be required is, if we have:
const myRuntype = Record({
    A: Number.optional(),
    B: Number,
}).withConstraint((r) => {
    if (myRuntype.underlying.pick("A").guard(r)) {
        return r.A > r.B || `A has to be bigger than B`;
    } else {
        return `A has to be present and a number`;
    }
});

then:
myRuntype.underlying.extend({ A: myRuntype.underlying.fields["A"].underlying })

Hello and thank you for the response! This is exactly what I am looking for. I achvied to miss the underlying property somehow...
Mostly I use it for definitons. If Package A defines a really generic one I want to specialize the definitions in a depending package.
In your first example it is not really the same since I am then able to have a configuration without the "A"s (so it is smaller and less repetitive) and fill up the "A"s incode to later delegate it. But if I need more configuration (like a "C") then it is added automatically.
Thank you very much!


Crash in Debug lib.

Hi,
I have a crash when I linked the lib which build following.

$ git clone https://github.com/preshing/junction.git
$ git clone https://github.com/preshing/turf.git
$ cd junction
$ cmake -DCMAKE_INSTALL_PREFIX=~/junction-install -DJUNCTION_WITH_SAMPLES=OFF ..
$ cmake --build . --target install --config Debug

And the test file is 'MapScalabilityTests'.
Here is the callstack.

The 'TURF_WITH_ASSERTS ' macro should be defined?
This action quick fixed my problem.


Port the TensorFlow e2e tests to use the new compiler2 api.

Also adds some flags to iree-tf-import to save temps, making things line up just like they were.
Tested with simple_arithmetic_test.py and mobile_bert_squad_test.py by running each of them individually after a ninja build.

Merged separately


Update bitscanforward-bitscanforward64.md

_BitScanForward64 was incorrectly marked as available on ARM, but it's only defined in intrin0.h for X64 and ARM64.
Fixes #1538.

@kusma : Thanks for your contribution! The author(s) have been notified to review your proposed change.


phpunit test failure: tests\classes\utilities\ReflectionTest::testTypeReturnsTypeOfReflectedClass

The following test fails inconsistently:
tests\classes\utilities\ReflectionTest::testTypeReturnsTypeOfReflectedClass

phpunit output:
PHPUnit 9.5.26 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.2
Configuration: /home/darling/dev/php/roady/php.xml
Random Seed:<PHONE_NUMBER>

..............................................F................  63 / 107 ( 58%)
............................................                    107 / 107 (100%)

Time: 00:05.105, Memory: 6.00 MB

There was 1 failure:

1) tests\classes\utilities\ReflectionTest::testTypeReturnsTypeOfReflectedClass
The roady\classes\utilities\Reflection implementation's type() method must return the type of the reflected class.
Failed asserting that roady\classes\strings\ClassString Object &00000000000001450000000000000000 (
    'string' => 'roady\classes\strings\UnknownClass'
) matches expected 'roady\interfaces\strings\ClassString'.

/home/darling/dev/php/roady/tests/interfaces/utilities/ReflectionTestTrait.php:281

FAILURES!
Tests: 107, Assertions: 4107, Failures: 1.

Look into an fix this asap.

Resolved in c796d38b2e0ff0a4607d59bee63711c7575a597a

Resolved in c796d38b2e0ff0a4607d59bee63711c7575a597a


Improve TestSRTPDrainLeak

TestSRTPDrainLeak asserts that we notify the user
of SRTP/SRTCP packets that can't be handled. Before
we tested by sending 5 packets, and looking for a log
message. If these 5 packets were lost the test would fail.
Now we send packets in a loop until they are seen.
Resolves #823
Description
Reference issue
Fixes #...

Codecov Report

Merging #833 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
- Coverage   76.83%   76.76%   -0.08%
==========================================
  Files          60       60
  Lines        4257     4257
==========================================
- Hits         3271     3268       -3
- Misses        713      716       +3
  Partials      273      273

Impacted Files
Coverage Δ

sctptransport.go
74.37% <0%> (-1.25%)
:arrow_down:

peerconnection.go
73.04% <0%> (-0.28%)
:arrow_down:

dtlstransport.go
76.7% <0%> (+1.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf66a69...8f9fc41. Read the comment docs.


web3torrent: handle dropped wires

Fix: https://github.com/statechannels/monorepo/issues/1215
Added a fix to fall back to channel cache to calculate the download size.
Also put in a fix to handle a random crash when the channel cache is not available.
WIP: When leechers cancels the download, wire is dropped but the channel is still running.

@geoknee CI fails with a weird error. and I couldn't rerun the jobs.


xService: cannot be used for Computer Browser Service if it is not installed

Problem description
I want to make sure the service "Computer Browser" is not installed on my devices.
Unfortunately there seems to be a Problem combined with the way Get-Service works (-Name also seems to look for DisplayName, if there is no hit) and the fact that Microsoft has this great combination of Services:

#
Name
DisplayName
Description

1
Browser
Computer Browser
This is a "normal" service, that you can see in Services.msc

2
Bowser
Browser
Apparently this is the "Browser Support Driver"

As a result, Get-Service, which is called in line 52 of DSC_xServiceResource.psm1 returns the Bowser Service, rather than the Browser, which I am looking for. Regardless of Browser only being the DisplayName and not Name.
Next, it tries to execute "Get-ServiceCimInstance -ServiceName $Name", which will be empty, as this won't work for Bowser Service.
This then leads to the String-Conversion failing, as there is no return value from and thus no StartMode
($startupType = ConvertTo-StartupTypeString -StartMode $serviceCimInstance.StartMode)
Verbose logs
PowerShell DSC resource DSC_xServiceResource  failed to execute Test-TargetResource functionality with error message: The property 'StartMode' cannot be found on this object. Verify that the property exists.
    + CategoryInfo          : InvalidOperation: (:) [], CimException
    + FullyQualifiedErrorId : ProviderOperationExecutionFailure
    + PSComputerName        : DESKTOP-55FBL3B

DSC configuration
instance of DSC_xServiceResource as $DSC_xServiceResource1ref
{
Name = "Browser";
 Ensure = "Absent";
 ModuleName = "xPSDesiredStateConfiguration";
 ResourceID = "[xService]Browser";

 ModuleVersion = "9.1.0";

 ConfigurationName = "ServiceConfig";

};
instance of OMI_ConfigurationDocument
                    {
                        Version="2.0.0";
                        MinimumCompatibleVersion = "1.0.0";
                        CompatibleVersionAdditionalProperties= {"Omi_BaseResource:ConfigurationName"};

                    };

Suggested solution
Imo, Get-Service should not fall back to DisplayName, but I don't think that will ever happen.
So, maybe a check if (get-service -name browser).Name (in this case Bowser) equals the input-value when checking the Service (in this case "Browser")
Operating system the target node is running
OsName               : Microsoft Windows 10 Pro
OsOperatingSystemSKU : 48
OsArchitecture       : 64-bit
WindowsVersion       : 2009
WindowsBuildLabEx    : 19041.1.amd64fre.vb_release.191206-1406
OsLanguage           : en-US
OsMuiLanguages       : {en-US}

PowerShell version and build the target node is running
Name                           Value
----                           -----
PSVersion                      5.1.19041.2364
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.2364
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

xPSDesiredStateConfiguration version
Name                         Version Path
----                         ------- ----
xPSDesiredStateConfiguration 9.1.0   C:\Program Files\WindowsPowerShell\Modules\xPSDesiredStateConfiguration\9.1.0\xPSDesiredStateConfiguration.psd1

So, maybe a check if (get-service -name browser).Name (in this case Bowser) equals the input-value when checking the Service (in this case "Browser")

Good suggestion but I think this could possibly be a breaking change if this Get-Service bug actually make it work in another case. 🤔  So suggest adding the Exclude parameter instead.


Can dbatools be installed on Server 2008 Standard?

I want to move SQL logins from SQL installed on a Server 2008 Standard box.  I want to install dbatools, but the prerequisites include WMF 5.1 and I can't find any way to install that on a 2008 server.
Can dbatools be install on Server 2008 Standard?

Thank you for your question! Nice timing, I just finished writing about this for dbatools in a month of lunches 👍
Surprisingly, no. It does not work in 2008, but does work with 2008 R2. Here's a complete list for those interested.

Don't forget that dbatools can be installed on one machine and then manage other servers, like SQL Server Management Studio. For me, I have a centralized management server and do everything from there.

Are there instructions on how this can be done?

It is the same syntax for local or remote. Get-Help Copy-DbaLogin -Examples should help.

Thanks for the prompt replies!  I'll take a quick look and see how things go.

Unfortunately I'm still somewhat confused about some of the syntax.  Please pardon my ignorance on this subject, I've been tasked with migrating this server as it is failing, and our dB admin left last month...and although I am an experienced server admin I am NOT a SQL admin. Ouch!
Here's my scenario:  sql01.domain.com is the old server, and newsql01.domain.com is the new.  The problem is, the HELP I ran doesn't say what to do prior to running the copy command.
Syntax says:
Copy-DbaLogin -Source sql01 -Destination newsql01 -Login User1 -Force
How does dbatools connect to the dB on the old server (sql01)?  Do I connect to the old server dB in the Mgt Studio on the new server first?  I tried running it as is above (with correct names) and it failed.
Thanks in advance for any assistance!

Hey @RT1960 you want to find your way over to the dbatools slack over on sql server community?
It uses the powershell session (your windows login) by default, if you check the help
Get-Help Copy-DbaLogin -Full
Then you can see all the extra flags and examples.

https://dbatools.io/slack/

You can find the docs for that command online at docs.dbatools.io/#Copy-DbaLogin
You will want to use the credential parameters noted in the help if the login running the command cannot connect to both instances.

If you are getting errors you can post them here as well.

I actually joined Slack, and when I clicked to submit an issue on dbatools it brought me here.  Oh well...:)
I attached to the old dB on the new server, and ran the copy command.  It did bring the user over, but the user mappings did not quite match.  But I'm thinking I need to move the databases first so that the user mappings are maintained, which I have not done yet.  Is this correct?

Yes, the copy commands have a precedence as they do not handle dependencies.
You can actually look at Start-DbaMigration to get an idea but in your case the databases need to come before the logins. Once you have the databases copied over you can simply run the copy command for the logins again and use -Force and it will just drop/create the logins on your destination server.

Hello all,
Well, the move was uneventful, at least it appeared to be.  Once copied over, I compared the users on the old server the users on the new, and they had the same user mappings to the databases, and the properties all appeared to be identical.  Unfortunately when we switched over we started receiving errors from one of the most critical logins related to our website.
It’s hard to describe, but it from what I was seeing the account did not feel like it was associated with the new server. It was still trying to pull/update settings from the old server (even though we named the new server the same name and used the same IP), and it couldn't find the server it was attempting to contact. When I tried to change settings on the account on the new server, it would error out and say that it could not find the user; even though I was selecting the properties of the user on the new server. Basically, the account didn’t act like it was part of the new server.  I eventually took down the new server and put the old one back into production for now.
So something didn't copy over when I moved the users, somehow.

If you'd like to do the login move yourself, you can use the classic Microsoft way, but I imagine you'll continue to have the same problem. What you describe does not jive with what I understand about SQL Server logins but anything is possible.
https://support.microsoft.com/en-us/help/918992/how-to-transfer-logins-and-passwords-between-instances-of-sql-server


Print Left View of a Binary Tree

🚀 Feature
(A clear and concise description of what the feature is.)
Have you read the Contributing Guidelines on Pull Requests?
Yes
Problem
Given a Binary Tree, print left view of it. Left view of a Binary Tree is set of nodes visible when tree is visited from left side.
Input :
1
/   \
2     3
/ \     \
4   5     6
Output : 1 2 4
I would like to work on this issue under gssoc in c++ .

/assign


Azure native test failure

OpenJDK 11u-dev
Graal 20.1
Quarkus master branch
Apache Quarkus quarkus-master branch

Caused by: java.security.InvalidKeyException: No installed provider supports this key: javax.crypto.spec.SecretKeySpec
	at javax.crypto.Mac.chooseProvider(Mac.java:392)
	at javax.crypto.Mac.init(Mac.java:435)
	at com.microsoft.azure.storage.StorageCredentialsAccountAndKey.getHmac256(StorageCredentialsAccountAndKey.java:190)
	at com.microsoft.azure.storage.core.StorageCredentialsHelper.computeHmac256(StorageCredentialsHelper.java:76)
	at com.microsoft.azure.storage.core.StorageCredentialsHelper.signBlobQueueAndFileRequest(StorageCredentialsHelper.java:133)
	at com.microsoft.azure.storage.core.StorageRequest.signBlobQueueAndFileRequest(StorageRequest.java:310)
	at com.microsoft.azure.storage.queue.CloudQueue$7.signRequest(CloudQueue.java:907)
	at com.microsoft.azure.storage.queue.CloudQueue$7.signRequest(CloudQueue.java:889)
	at com.microsoft.azure.storage.core.ExecutionEngine.setupStorageRequest(ExecutionEngine.java:341)
	... 50 more
Caused by: java.security.NoSuchAlgorithmException: class configured for Mac (provider: SunJCE) cannot be found.
	at java.security.Provider$Service.getImplClass(Provider.java:1857)
	at java.security.Provider$Service.newInstance(Provider.java:1818)
	at javax.crypto.Mac.chooseProvider(Mac.java:365)
	... 58 more
Caused by: java.lang.ClassNotFoundException: com.sun.crypto.provider.HmacCore$HmacSHA256
	at com.oracle.svm.core.hub.ClassForNameSupport.forName(ClassForNameSupport.java:60)
	at java.lang.Class.forName(DynamicHub.java:1194)
	at java.security.Provider$Service.getImplClass(Provider.java:1842)

Longer output.¯

Can someone assign this to me?

Thx @jamesnetherton.
I've tried to add the following to camel-quarkus/integration-tests/azure/src/main/resources/application.properties, but didn't work:
quarkus.security.security-providers=SunJCE

However, if I run the test with -Dquarkus.native.additional-build-args=--enable-all-security-services it works.

I've seen this test pass about 1/2 months ago, so something recent change must have caused this. Looking.

BTW the integration test used to be suppressed because it required access to Azure. I recently tweaked things to use Azurite for testing, so maybe that's why you did not see such issues in the past.

Ah I see, that would explain. I think Quarkus security config is missing but not only is the docu inconsistent, none of the properties work. Both quarkus.security.users.security-providers and quarkus.security.security-providers throw warnings:
16:53:01,100 WARN  [io.qua.config] Unrecognized configuration key "quarkus.security.users.security-providers" was provided; it will be ignored

15:37:55,313 WARN  [io.qua.config] Unrecognized configuration key "quarkus.security.security-providers" was provided; it will be ignored

Created https://github.com/quarkusio/quarkus/issues/9664 to track the issue on Quarkus' side with security configuration.

Fixed the test, needed extra config and adding security extension. I'll send a PR tomorrow.

PR with fix.

[PR https://github.com/apache/camel-quarkus/issues/1269] with better fix.

Fixed via https://github.com/apache/camel-quarkus/pull/1294 8c4d478bd5d7618f415dca63326850bdb0ea57c1


retry(0) behavior changed in RxJS 7 and it is inconsitent with expectations (and documentation)

Bug Report
Current Behavior
Calling retry(0) will produce EMPTY obervable, so upstream will never be subscribed to.
retry(0) => 0 upstream subscriptions.
retry(1) => 1 upstream subscription and up to 1 resubscription.
retry(2) => 1 upstream subscription and up to 2 resubscriptions.
This breaks the scenario when retries can be turned on and off with a parameter.
Expected behavior
Calling retry(0) will produce an operator that subscribes to upstream only once.
retry(0) => 1 upstream subscription.
retry(1) => 1 upstream subscription and up to 1 resubscription.
retry(2) => 1 upstream subscription and up to 2 resubscriptions.
With previos behavior retry(param) where param=0 just turns retries off.
Reproduction
import { of } from "rxjs";
import { map, retry } from "rxjs/operators";

const source = of("World").pipe(
  map(x => `Hello ${x}!`),
  retry(0)
);

source.subscribe(console.log);

Ver 6.6.7: https://rxjs-fdhbub.stackblitz.io
You will see "Hello World" in the console once.
Ver 7.0.0: https://rxjs-xeymgx.stackblitz.io
The console will be empty.
Possible Solution
retry(0) should work as in 6.6.7, as it aligns with expectations that there always will be one upstream subscription.

Yep, I also think that this is a bug, because the following test currently fails:
  it('should not alter the source when the number of retries is smaller than 1', () => {
    const source = cold('--1-2-3-#');
    const subs =       ['^       !'];

    const expected =    '--1-2-3-#';
    const unsub =       '         !';

    const result = source.pipe(retry(0));

    expectObservable(result, unsub).toBe(expected);
    expectSubscriptions(source.subscriptions).toBe(subs);
  })

It's an easy fix. I'm pretty sure that the PR that I've opened fixes the issue.


Update to TS 3.8 (and bump any older deps too)

3.7 -> 3.8 required no breaking changes
new tsconfig compiler option values
#266 required a bit of tweaking

The white gap isn't showing up in builds - so I'm accepting this


Lag when minimize and maximize VS Code

VSCode Version: 1.40.0
OS Version: windows 10\ windows 8.1

Steps to Reproduce:

Open VS Code in Fullscreen
Minimize VS Code window
Maximize VS Code window
You'll see lag - empty window for few seconds

Does this issue occur when all extensions are disabled?: Yes

/duplicate of #84343
Please provide more details if you are sure that this is not a duplicate.


Negotiator prevents googlebot from indexing the page

When in production, I noticed that Googlebot constantly reported a 5xx error when trying to check the page for indexing. I used a URL-checking tool for this. Interestingly, I noticed that the reason for this is that the negotiator library produces an incorrect list of languages, and passes it to the intl-localematcher, which in turn throws an error described here https://github.com/formatjs/formatjs/discussions/2440. The temporary fix I introduced was to fix the value of languages to just an empty list. However, negotiator itself hasn't been updated in several years already, so I think it should be replaced with smth else.

Can you provide a detailed temporary fix? @colonder

@colonder thank you for sharing this and your workaround.  I will keep this open until we can figure a better solution.


added a laws of ux link

pretty good explanation

[ x] I have read freeCodeCamp's contribution guidelines.
[x ] My pull request has a descriptive title (not a vague title like Update index.md)
[ x] My pull request targets the master branch of freeCodeCamp.
[ x] None of my changes are plagiarized from another source without proper attribution.
[ x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace then xxxx below with the issue number.
Closes #XXXXX

We are marking this PR invalid for Hactoberfest as it does not follow the recommended guidelines below:

Quality Standards
In line with Hacktoberfest value #2 (Quantity is fun, Quality is key), we have provided examples of the quality standards we encourage. This applies mainly to beginners.

PRs that are automated e.g. scripted opening PRs to remove white space / optimize images.
PRs that are disruptive e.g. taking someone else's branch/commits and making a PR.
PRs that are regarded by a project maintainer as a hindrance vs. helping.
Something that's clearly an attempt to simply +1 your PR count for October.

Learn more at https://hacktoberfest.digitalocean.com/details
This is taken directly from https://www.interaction-design.org/literature/topics/fitts-law


ENH: Add Hausman specification test

This adds the Hausman specification test, commonly used to choose between a fixed effects model and a random effects model. The function includes the options include_constant, sigmamore, and sigmaless - which mirrors Stata.
I haven't updated the documentation, but will be happy to do so if you want.
The function calculating an alternative covariance can perhaps be removed and replaced with adding a parameter to the covariance estimation.
I realize there is already a wu_hausman method for testing exogeneity in IV models, but I could not find a way to re-use it. Maybe the mathematics could be extracted into a shared function. Also I guess I should make the naming consistent.
Finally, I have written tests, but they do not look at the actual numerical results. Do you generally generate these using Stata and then test against them?

Should this be a method attached to a RandomEffectsResults class?  This would likely simplify the calculations and logic. It also makes sure that we aren't trying to compare invalid models (e.g. a  2-way FE model with a RE model).

That's a good idea, I've moved it to a method.
I'm trying to generate test data using Stata, but the generated .do-file uses a stats command that I cannot find. Could you point me in the right direction?

I will keep a big eye on this issue. Hausman tests for FE and RE deserves a add!

I have now added tests against pre-calculated values from Stata. Let me know if anything needs to be changed/added!


Husky Marketing Planner integration

Integration for Husky Marketing Planner

Hello, @ygwain. First of all, thanks for contributing. :) We appreciate it.
Could you please rebase your branch on top of master so we can merge the PR?

Hello,
Can't you squash it while pulling?

Thanks!


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1928

Questions ?
Please refer to the Backport tool documentation


Improve troubleshooting UX for V2 plugins

Extracted from #30024:

It seems really difficult to debug a v2 plugin - no docker logs or anything like that.

There is, unless I missed it, no way in the UI for the user/sysadmin to see whether the process is crashing and restarting, no way to look inside the container, no way to do anything beyond install it and list its name via the docker command.
You can drop down to containerd to find the ID, exec inside it and so forth, but this is somewhat ugly and undocumented.

/cc @cpuguy83 @anusha-ragunathan @tiborvass @vieux

Agreed. Might be nice to take advantage of runc's ability to "exec" a non-running container.
But even then it can be pretty painful if there's no tooling in the plugin image.
Most of mine are just static binaries, so instead of entering the mount ns I have to mess around in /proc.
We probably need to look at the use case here and provide something that a user might be expected to run vs a plugin developer.

Added debug docs. Reopen if there's more that you are looking for.


About GT data range

Hi~ I find that the maximum value of GT HDR data is often greater than 1. Why not normalize them?

@hahahaprince In a sense, the Tanh_L1 loss is designed for normalization.

Hi, do you normalize the GT HDR data before using the Tanh_L1 loss?


Any info on when is the next release planned for?

The last release was from September of 2018, and I've been running off of the master git branch for many months now. It would be nice to have a release cut with all the bugfixes since a year ago.

Most importantly are the pinned dependencies to other gems (coffee-rails and rails comes to mind), so please release a version.
Are there any things that are blocking a release currently? Can the community help out in some way?

Current milestone needs some more work, so I just pushed the latest master as 2.0.0.beta.
gem 'rails_admin', '~> 2.0.0.beta'


Add new suggestion URL and template.

r @ehamp @nnarang7

Looks good to me!

r @ehamp @nnarang7 again please


SVG cannot be rendered on IE 11

Issue Details

Version used: 1.0.0

Describe whats happening: SVG images cannot be rendered on IE 11. PNG ang JPEG images are rendered.

OS & Browser version: Windows 10, IE 11.285.17133.0

Example: https://liveweave.com/RHMnHW
On IE only the bitmap image is shown.

The sample using canvas directly works on IE on my machine. The createjs still doesn't.
My IE is now version 11.407.17134.0

Thanks, I can do some more testing.

I think I solved this. It is an issue with EaselJS, but I am not sure what we can do.
To summarize

EaselJS's containers (ie, the Stage) will only draw children that are visible
Bitmaps use a few checks to see if images/bitmaps are visible. If it has a cache, a width, a context, or a valid readyState, then it will draw
SVGs in IE11 get none of these. They receive a width/height upon being added to the DOM

This is why they will work with raw canvas, but not in EaselJS. We can determine when an image is loaded, but since EaselJS thinks it has no content, it will not try to draw it.
We will look at adding a workaround. Maybe just checking that the source is an SVG path is enough.
Definitely an interesting edge case.


Does julius wait to get all audio data before processing?

I'm testing sending audio via adinnet and from my tests so far it seems julius waits for all the data to arrive before processing it.
I put 5 seconds of silence in the audio between phrases hoping julius would process each phrase as they arrive. But it seems first it gets all the audio then splits the phrases and process them.
Can someone confirm this?

Replying to myself, no, julius processes VAD and will handle a speech segment after silence is detected.
I was mislead in my tests because my implementation of my adinnet client app was flawed but partially worked.
See https://github.com/julius-speech/julius/issues/30#issuecomment-856461359)

You need to split the audio stream to segments shorter than 20 sec, or Julius will cut it at 20 sec.
It is very serious problem when Julius slit a word apart becuse WER will be very high.
So, you have to detect non speech data (breath, silence) to split the stream to segments.
You can use the Julius GMM detector to classify the audio frame as speech or non-speech.


Add CodeCov

What type of PR is this?
Please check the category that applies:

[x] Feature
[ ] Bug Fix
[ ] Refactor
[ ] Documentation Update

Description
Please provide a brief summary of your changes and the problem they solve.
Related Issues
If applicable, please link any related issues. Use "Closes" keyword to automatically close the issue on PR merge.
Closes #<issue_number>
Testing

[ ] I have included or updated unit tests for my changes.
[ ] I would like some help writing tests.
[ ] These changes do not require tests.

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Find renamed icons

Package

[X] lucide
[ ] lucide-angular
[ ] lucide-flutter
[ ] lucide-preact
[X] lucide-react
[ ] lucide-react-native
[ ] lucide-solid
[ ] lucide-svelte
[ ] lucide-vue
[ ] lucide-vue-next
[ ] Figma plugin
[ ] source/main
[ ] other/not relevant

Version
@latest
Can you reproduce this in the latest version?

[ ] Yes
[ ] No

Browser

[ ] Chrome/Chromium
[ ] Firefox
[ ] Safari
[ ] Edge
[ ] iOS Safari
[ ] Opera
[ ] Other/not relevant

Operating system

[ ] Windows
[ ] Linux
[X] macOS
[ ] ChromeOS
[ ] iOS
[ ] Android
[ ] Other/not relevant

Description
Love this project! I noticed that occasionally icons are renamed. What's the best way to get an overview of renamed icons when upgrading the package?
Steps to reproduce
NPM install
Checklist

[X] I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)

@schonert: We always add backwards compatible aliases, you normally don't have to worry about this as long as your package is up to date. The most common issue with renames is that people use outdated packages and can't fathom why the names aren't consistent with lucide.dev, which, of course, uses the latest names.
As of #1960 (to be released in v0.380.0) these backwards compatible aliases will also occasionally have a deprecation notice, any renames that ought to be addressed will then be marked for you.


Not working with Vue 3 & TypeScript

Before you start, please make sure to:

[X] Read the doc
[X] Have tried the latest version
[X] Search to see if your issue already exists
[x] Look for / ask questions on Stack Overflow
[X] Reproduce the bug in incognito/private mode to avoid interference from browser extensions

Link to minimal reproduction
None
Steps to reproduce

Install JSON Editor Vue in a Vue 3 & TypeScript app:npm i json-editor-vue vanilla-jsoneditor

Try importing it as so:<script setup lang="ts">
	import JsonEditorVue from  'json-editor-vue';
</script>

What is expected?
I expected this to work:
<template>
	<JsonEditorVue v-model="modelValue" />
</template>

<script setup lang="ts">
	import { ref } from 'vue';
	import JsonEditorVue from 'json-editor-vue';

	interface Props {
		modelValue: any;
	}

	const props = defineProps<Props>();

	const modelValue = ref(props.modelValue);
</script>

What is actually happening?
Instead I got this error:
Could not find a declaration file for module 'json-editor-vue'. '/workspace/node_modules/json-editor-vue/dist/json-editor-vue.umd.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/json-editor-vue` if it exists or add a new declaration (.d.ts) file containing `declare module 'json-editor-vue';`ts(7016)

System Info
System:
    OS: Linux 5.15 Alpine Linux
    CPU: (4) x64 12th Gen Intel(R) Core(TM) i5-12400
    Memory: 1.73 GB / 5.80 GB
    Container: Yes
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.20.1 - /usr/bin/node
    npm: 7.24.2 - /workspace/node_modules/.bin/npm
  npmPackages:
    @fortawesome/fontawesome-free: ^6.4.0 => 6.4.0
    @fortawesome/fontawesome-svg-core: ^6.4.0 => 6.4.0
    @fortawesome/free-brands-svg-icons: ^6.4.0 => 6.4.0
    @fortawesome/free-regular-svg-icons: ^6.4.0 => 6.4.0
    @fortawesome/free-solid-svg-icons: ^6.4.0 => 6.4.2
    @fortawesome/vue-fontawesome: ^3.0.3 => 3.0.3
    @fullcalendar/core: ^6.1.8 => 6.1.8
    @fullcalendar/daygrid: ^6.1.8 => 6.1.8
    @fullcalendar/interaction: ^6.1.8 => 6.1.8
    @fullcalendar/vue3: ^6.1.8 => 6.1.8
    @h-hg/docsify-image-caption: ^0.1.2 => 0.1.2
    @jamescoyle/vue-icon: ^0.1.2 => 0.1.2
    @markbattistella/docsify-sidebarfooter: ^4.0.0 => 4.0.0
    @mdi/font: ^7.0.96 => 7.2.96
    @mdi/js: ^7.2.96 => 7.2.96
    @rodrigogs/mysql-events: ^0.6.0 => 0.6.0
    @shopify/draggable: ^1.0.0-beta.12 => 1.0.0-beta.12
    @ttskch/select2-bootstrap4-theme: ^1.5.2 => 1.5.2
    @types/leaflet.fullscreen: ^1.6.1 => 1.6.1
    @types/lodash: ^4.14.197 => 4.14.197
    @vitejs/plugin-vue: ^4.2.3 => 4.2.3
    @vue-leaflet/vue-leaflet: ^0.9.0 => 0.9.0
    @vue/test-utils: ^2.4.0 => 2.4.0
    @vueuse/core: ^10.1.0 => 10.1.2
    accounting-js: ^1.1.1 => 1.1.1
    animate.css: ^4.1.1 => 4.1.1
    apexcharts: ^3.35.3 => 3.41.0
    autobahn-browser: ^20.9.2 => 20.9.2
    axios: ^0.21.1 => 0.19.2
    bootbox: ^5.5.2 => 5.5.3
    bootstrap: ^4.6.2 => 4.6.2
    bootstrap-fileinput: ^5.1.5 => 5.5.2
    bootstrap-slider: ^11.0.2 => 11.0.2
    bootstrap4-datetimepicker: ^5.2.3 => 5.2.3
    clipboard: ^2.0.6 => 2.0.11
    cross-env: ^7.0 => 7.0.3
    cssmin: ^0.4.3 => 0.4.3
    currency.js: ^2.0.4 => 2.0.4
    cz-conventional-changelog: ^3.3.0 => 3.3.0
    datatables.net-bs4: ^1.10.23 => 1.13.4
    datatables.net-buttons-bs4: ^1.6.5 => 1.7.1
    datatables.net-colreorder-bs4: ^1.5.3 => 1.6.2
    datatables.net-fixedcolumns-bs4: ^3.3.2 => 3.3.3
    datatables.net-fixedheader-bs4: ^3.1.8 => 3.3.2
    datatables.net-responsive-bs4: ^2.2.7 => 2.4.1
    datatables.net-rowgroup-bs4: ^1.1.2 => 1.3.1
    datatables.net-rowreorder-bs4: ^1.2.7 => 1.3.3
    daterangepicker: ^3.1.0 => 3.1.0
    dayjs: ^1.8.36 => 1.11.8
    docsify: ^4.13.0 => 4.13.0
    docsify-copy-code: ^2.1.1 => 2.1.1
    docsify-drawio: ^1.0.6 => 1.0.7
    docsify-plugin-flexible-alerts: ^1.1.1 => 1.1.1
    docsify-updated: ^1.0.5 => 1.0.5
    domurl: ^2.3.4 => 2.3.4
    easytimer.js: ^4.3.4 => 4.5.4
    echarts: ^5.1.2 => 5.4.2
    emails-input: ^1.0.0 => 1.0.0
    excellentexport: ^3.9.6 => 3.9.6
    express: ^4.17.1 => 4.18.2
    faker: ^5.5.3 => 5.5.3
    fullcalendar: ^5.9.0 => 5.11.5
    gasparesganga-jquery-loading-overlay: ^2.1.7 => 2.1.7
    glyphicons-only-bootstrap: ^1.0.1 => 1.0.1
    heatmap.js: ^2.0.5 => 2.0.5
    html-to-image: ^1.9.0 => 1.11.11
    html2canvas: ^1.4.1 => 1.4.1
    jquery: ^3.6.0 => 3.7.0
    jquery-confirm: ^3.3.4 => 3.3.4
    jquery-sortablejs: ^1.0.1 => 1.0.1
    jquery.json-viewer: ^1.4.0 => 1.5.0
    jquery.redirect: ^1.1.4 => 1.2.0
    jsbarcode: ^3.11.5 => 3.11.5
    jsdom: ^22.1.0 => 22.1.0
    json-editor-vue: ^0.10.15 => 0.10.15
    jspdf: ^2.5.1 => 2.5.1
    jspdf-autotable: ^3.5.31 => 3.5.31
    jszip: ^3.6.0 => 3.10.1
    laravel-mix: ^6.0.49 => 6.0.49
    laravel-mix-eslint: ^0.2.0 => 0.2.0
    latest-version: ^5.1.0 => 5.1.0
    leaflet: ^1.9.3 => 1.9.4
    leaflet-extra-markers: ^1.2.1 => 1.2.2
    leaflet-heatmap: ^1.0.0 => 1.0.0
    leaflet-layervisibility: * => 0.1.0post1
    leaflet-rotatedmarker: ^0.2.0 => 0.2.0
    leaflet.fullscreen: ^2.4.0 => 2.4.0
    leaflet.heat: ^0.2.0 => 0.2.0
    leaflet.marker.slideto: ^0.2.0 => 0.2.0
    lodash: ^4.17.19 => 4.17.21
    lodash-es: ^4.17.21 => 4.17.21
    mburger-css: ^1.3.3 => 1.3.3
    mmenu-js: ^8.5.24 => 8.5.24
    moment: ^2.29.4 => 2.29.4
    moment-with-locales-es6: ^1.0.1 => 1.0.1
    nodemon: ^2.0.12 => 2.0.22
    noty: ^3.2.0-beta-deprecated => 3.2.0-beta-deprecated
    npm: ^7.11.1 => 7.24.2
    pdfmake: ^0.1.71 => 0.1.72
    pm2: ^5.1.2 => 5.3.0
    prettier: ^3.0.3 => 3.0.3
    primeflex: ^3.3.0 => 3.3.1
    primeicons: ^6.0.1 => 6.0.1
    primevue: ^3.27.0 => 3.29.2
    prismjs: ^1.29.0 => 1.29.0
    pusher-js: ^7.0.3 => 7.6.0
    redom: ^3.27.1 => 3.29.1
    resolve-url-loader: ^2.3.1 => 2.3.2
    sass: ^1.20.1 => 1.63.2
    sass-loader: ^8.0.0 => 8.0.2
    screenfull: ^5.1.0 => 5.2.0
    select2: ^4.0.13 => 4.0.13
    select2-bootstrap4-theme: ^1.0.0 => 1.0.0
    smartwizard: ^5.1.1 => v5.1.1
    socket.io: ^4.2.0 => 4.6.2
    socket.io-client: ^4.2.0 => 2.4.0
    sortablejs: ^1.13.0 => 1.15.0
    sql-events-listener: ^1.0.0 => 1.0.0
    tf-vue-leaflet-heatmap: ^1.0.0 => 1.0.0
    ts-loader: ^9.4.4 => 9.4.4
    tui-calendar: ^1.13.0 => 1.15.3
    tui-dom: ^3.0.0 => 3.0.0
    typescript: ^5.2.2 => 5.2.2
    uglify-js: ^3.13.4 => 3.17.4
    uglify-js-es6: ^2.8.9 => 2.8.9
    url-template: ^3.1.0 => 3.1.0
    vanilla-jsoneditor: ^0.18.3 => 0.18.3
    viewerjs: ^1.9.2 => 1.11.3
    vitest: ^0.33.0 => 0.33.0
    vue: ^3.2.47 => 3.3.4
    vue-axios: ^3.5.2 => 3.5.2
    vue-cli: ^2.9.6 => 2.9.6
    vue-loader: ^16.8.3 => 16.8.3
    vue-sse: ^2.5.2 => 2.5.2
    vue2-leaflet-hotline: ^1.0.1 => 1.0.1
    vue3-apexcharts: ^1.4.1 => 1.4.1
    vuetify: ^3.2.4 => 3.3.3

Package Manager
npm
Any additional comments?
I managed to make it work by adding the following code in the shims-vue.d.ts file in the root folder of my app:
declare module 'json-editor-vue' {
	import { Component } from 'json-editor-vue/dist/src/Component';
	export default Component;
}

Am I missing something? Shouldn't it have worked without having to do all that?

It works now, thank you!

It doesn't still work for me with Typescript and Vitepress.
I get Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in C:\code\sx.design.portal\node_modules\vanilla-jsoneditor\package.json when trying to build

@husayt Doesn't seem to be the same problem. Please open a new issue with a valid minimal reproduction.

@cloydlau after spending whole day trying to solve it I have switched to vue3-ts-jsoneditor. It doesn't have this problem. Thanks

@husayt It actually doesn't prove anything, you had error using json-editor-vue is probablly due to your own code or the way you're using it. That's why a reproduction is required, you would understand this if you have read https://antfu.me/posts/why-reproductions-are-required which was written by Vue & Vite core team member. I replied to your message you leaved under this unrelated issue for your own convenience within an hour, yet you'd rather spend a whole day trying than opening a new one. Even if there's a real problem with json-editor-vue, there's no way to find out.

@cloydlau i appreciate why reproduction is needed, and I didn't blame you to get so defensive.
it is just after spending more than allocated time on this I ran out of time and had no physical opportunity to provide you with reproduction.
i tried opening a new issue, but one can't do it  unless he answers all the questions and provide repro, which I couldn't do.
But at least I wanted to leave some information about the problem I experienced so that others would know.

@husayt This issue of svelte-jsoneditor which I opened 17 days ago is a confirmed bug and remains unsolved for now. The vue3-ts-jsoneditor you're using right now based on svelte-jsoneditor too. I mean, open source software is served "as-is", me or author of svelte-jsoneditor don't get paid to do this. If you think opening an issue or providing a reproduction is costing your time, we too. The fact is that more than half issues of json-editor-vue or I believe, most open source software, are turned out to be invalid, I've spent time investigating them and even helped a few with correcting their own codes. Sending PRs or at least providing valid efficient trackable issues is reciprocal. So please forgive my defensiveness.

@cloydlau I just checked my issue against v0.11.0 and, happy to say, that it is fixed in that version.
Thanks for this


Remove dotnet format check from PR template

proposing that we make this change since

.NET formatting is verified by the PR build, and
there are now several different languages used in the repo.

I would probably keep check for following coding conventions. We can make it more general, so it will refer to C#/Python/Java.

I've been thinking we should update this to acknowledge x-language too...
Some notes: "dotnet format" only runs on release builds, which not everybody does.
Dotnet has a "build.sh"/"build.cmd" (Windows) script available that builds, checks format, runs UTs and integration tests...
Maybe we should have similar scripts for python, samples. Or, even better, the script could detect what files are changed and run the appropriate language builds/formatters/linters/tests before submitting a PR... (just an idea, beyond the scope of the PR).

I would probably keep check for following coding conventions. We can make it more general, so it will refer to C#/Python/Java.

@dmytrostruk that's the thing, we're already checking for coding conventions by default in the PR build.
to give some context, we recently enabled ESLint in the Copilot Chat build (#1710) and following that I want to integrate Prettier soon as well. it feels a bit cumbersome to continue to update the list of languages in the description as we add more in the repo.

I've been thinking we should update this to acknowledge x-language too... Some notes: "dotnet format" only runs on release builds, which not everybody does. Dotnet has a "build.sh"/"build.cmd" (Windows) script available that builds, checks format, runs UTs and integration tests...
Maybe we should have similar scripts for python, samples. Or, even better, the script could detect what files are changed and run the appropriate language builds/formatters/linters/tests before submitting a PR... (just an idea, beyond the scope of the PR).

@shawncal python and java currently have Github workflows (python-lint.yml and java-format.yml) that verify the formatting for PRs and imo it seems redundant to mention these in the PR description since they will run regardless.
there is also already a workflow for running dotnet format:

maybe we can scrap this workflow too? since we are already running release builds for PRs?

there is also already a workflow for running dotnet format

As far as I know, it is running only a check, whether the code is formatted, but it's not formatting code automatically, so currently you need to do that manually. When developers submit PRs, they should check whether this build step is successful. If no, then they need to run that script locally to apply formatting changes and commit it.
Of course, this can be automated, for example by adding pre-commit hooks.
But it's not only about formatting, but naming convention and other things, so for these things we should use analyzers for automation. But it's not in place yet, that's why this step is present in PR description template :)
So quick resolution would be to mention that in PR description for all languages and for long term - add automation.

I've been thinking we should update this to acknowledge x-language too... Some notes: "dotnet format" only runs on release builds, which not everybody does. Dotnet has a "build.sh"/"build.cmd" (Windows) script available that builds, checks format, runs UTs and integration tests...
Maybe we should have similar scripts for python, samples. Or, even better, the script could detect what files are changed and run the appropriate language builds/formatters/linters/tests before submitting a PR... (just an idea, beyond the scope of the PR).

@shawncal python and java currently have Github workflows (python-lint.yml and java-format.yml) that verify the formatting for PRs and imo it seems redundant to mention these in the PR description since they will run regardless. there is also already a workflow for running dotnet format:
maybe we can scrap this workflow too? since we are already running release builds for PRs?

The 'Release' builds that we run in GitHub Actions exclude the dotnet format check. It takes a long time to run, and since there are several build flavors, there's no need to run format check on all of them, and surface the same warning n times. The 'dotnet format' GH action is also much more selective about which projects it checks, based on the files changed in the PR. Most times, it only needs to check one or two, instead of the whole solution.
A couple other notes and ideas....
Dmytro's right: the format checks on the builds are just checks and, unlike running dotnet format on your machine, they do not automatically fix anything. Instead, they just fail the build. Precommit hooks are a good idea, but require additional setup on each clone -- we can check in the precommit hooks config files, but it would still require all developers to install the tool and initialize the clone on their machine, so it's not a whole lot more effective than "please run a Release build".
Our Java peers have implemented a neat toy for PRs... if java formatting check fails, you can type a certain command into the PR discussion, which kicks off a format job. ("slash spotless"... I won't spell it out here since that'll actually trigger the job). That format, if successful, will submit a PR to the PR branch itself with the fixes.
https://github.com/microsoft/semantic-kernel/blob/main/.github/workflows/java-format.yml
I had a similar setup for "forward slash" dotnet format, but removed it as it was using a 3P action that was no longer compatible with the latest dotnet format command. I do plan to follow the Java example and implement this manually for dotnet and python.
RECOMMENDATIONS
@dehoward Here's what I think we should do...
THIS PR:

Update the CONTRIBUTING.md file with the instructions we'd like people to run before pushing a PR, including how to run the formatting and tests in each language. (You can start with just dotnet step of "run build.cmd/build.sh" in this PR, but leave room and ask others to add the java/python/ts steps in separate PRs.).
Remove the dotnet-specific line in the template, as you've already done. In the line above, add a bit about formatting. Something like:

The PR follows [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the (pre-submission formatting script)[[link to CONTRIBUTING section with instructions]] raises no warnings.

FUTURE PRs:

When dotnet format, python lint, node eslint or java's spotless checks fail in the PR, we have the style check Action script automatically post a PR comment instructing the developer how to fix it. That can include the "/format" commands and the instructions for doing so manually.

@shawncal, @dmytrostruk thanks for the great level of detail. I've updated the PR with Shawn's recommended changes and added a "Development scripts" section in CONTRIBUTING.md. lmk if we want to tweak the wording.
for python I just pointed to a section in the existing python/DEV_SETUP.md, maybe java/dotnet should have this file as well? just a thought.
also, @shawncal do we want to create item(s) to track the work for setting up the /format command?


initial work for cargo doc for markdown

The beginnings of https://github.com/rust-lang/cargo/issues/739
This handles the building of a doc directory, but not cargo test yet.
Does this look like it's on the right track?

r? @huonw
(rust_highfive has picked a reviewer for you, use r? to override)

/cc @chriskrycho

:+1:
One of the things I was thinking about with this was including the --markdown-css bit. Maybe pull it in from Cargo.toml? (Honestly, that was the biggest thing that was blocking me going on it, because I just didn't even know where to start on that.)

Looks like it's mostly along the right lines to me, thanks @steveklabnik! Some thoughts:

This may want to recurse deeply to probe copy the entire filesystem structure
Executing rustdoc will want to be tweaked, but you can see examples when running doctests for cargo test
Tests :)
It may be worth putting this in the backend to get parallelized
We'll probably want configuration keys for the project to do things like:

Change the root folder
Disable this functionality entirely
etc

Great! I wanted to hear from you before I did more work, that all seems reasonable.

This may want to recurse deeply to probe copy the entire filesystem structure

Should I use the walkdir crate for this? I forget what Cargo's policies on including external crates is.

It may be worth putting this in the backend to get parallelized

I don't know enough about Cargo's architecture to know what this would look like, any pointers?

Nah I'd just recurse manually, it should be a pretty simple recursive traversal.
For now I guess we can avoid parallelization, would be good to at least get the framework and tests written first. To land this, however, I think we may need that (and I can help)

(and I can help)

That would be rad, if you have the time, since you know Cargo way better than me.

Sure, let's get the main bulk of stuff set up first (e.g. get the interface and all the tests working), and then after that we can do all that.
Another reason I just thought of for using the parallelization backend is that it also tracks dirtiness by default (e.g. doesn't re-run rustdoc unless it needs to), which is likely desirable.

Hm, I thought removing the unwraps would help here. Need to dig deeper.

Closing due to inactivity, but feel free to reopen if this is filled out!


Support composite commands

/kind user-story
User Story
As a stack creator, I want to define composite commands to chain multiple commands together when running in odo.
Acceptance Criteria

[ ] It should follow the corresponding settings specified in the devfile 2.0 specification: https://github.com/devfile/kubernetes-api/issues/18
[ ] It should support running composite command for all command groups that odo supports, e.g. build, run, etc.
[ ] If parallel flag is set to true, the commands should be executed sequentially based on the order specified in the composite command; otherwise, the command will be executed in parallel.

Links

Related issue: https://github.com/devfile/kubernetes-api/issues/18

/kind user-story
/area devfile
/area devfilev2

Sample Devfile 2.0 with composite commands:
schemaVersion: 2.0.0
metadata:
  name: openLiberty
  version: 1.0.0
  description: Java application stack using Open Liberty runtime
projects:
  - name: user-app
    git:
      location: 'https://github.com/odo-devfiles/openliberty-ex.git'
      branch: master
components:
  - chePlugin:
      id: redhat/java/latest
      memoryLimit: 1512Mi
  - container:
      name: appsodyrun
      image: 'ajymau/java-openliberty-dev:latest'
      memoryLimit: 1024Mi
      mountSources: true
      endpoints:
        - name: 9080/tcp
          configuration:
            discoverable: false
            public: true
            protocol: tcp
            scheme: http
          targetPort: 9080
      env:
        - name: MODE2
          value: TEST2
        - name: myprop2
          value: myval2
commands:
  - exec:
      id: build
      component: appsodyrun
      commandLine: mvn -DhotTests=true -DappsDirectory=apps -Dmaven.repo.local=/mvn/repository liberty:dev
      workingDir: /projects/user-app
      attributes:
        restart: "false"
      group:
        kind: run
        isDefault: true
   - exec:
       id: run
       commandLine: "./run.sh"
       component: tooling
       group:
          kind: run
   - composite:
       id: buildAndRun
       label: Build and Run
       commands:
         - build
         - run
       parallel: false
       group:
          kind: run

Based on the second point, it sounds like this PR depends on support for command groups in devfiles (https://github.com/openshift/odo/issues/2938)

Some questions on composite commands that I couldn't find answers for in the schema:

Can a composite command reference other composite commands?
When parallel: true, does odo need to wait for all of the commands to finish executing?
If yes to 2, do we wait indefinitely or should there be a timeout?

Yes, from spec perspective, there is nothing prevent someone to reference a composite command to another composite command
yes
Similar to push command today, there is no timeout for command execution.

@kadel Based on our discussion on the odo contributor's call on Tuesday about composite run commands, @elsony and I chatted and we decided to scope this story down to just suppoorting composite build/init/test commands, rather than partially supporting non-long running composite commands.
We'll open up a separate story for suppoorting composite run commands (both long running and non-long running)


[BUG] GSE Managed Macro Breaking /castsequence lines at reset=combat/target

[BUG] GSE Managed Macro Breaking /castsequence lines at reset=combat/target
Original In-game Macro:
/targetenemy [noharm,nocombat]
/startattack [nocombat]
/castsequence [nochanneling,nocombat] reset=combat/target Azure Strike, null
/cast [harm,nochanneling,combat] Azure Strike

GSE Managed Macro [See Attached Image]
/targetenemy [noharm,nocombat]/startattack [nocombat]/castsequence [nochanneling,nocombat]  reset=combat/target 362969, null/cast [harm,nochanneling,combat] 362969

GSE Manage Breaks the Macro at
reset=combat/target

and Creates
/targetenemy [noharm,nocombat]
/startattack [nocombat]
/castsequence [nochanneling,nocombat] reset=combat
/target Azure Strike, null
/cast [harm,nochanneling,combat] Azure Strike

instead of recompiling the original Ingame macro
/targetenemy [noharm,nocombat]
/startattack [nocombat]
/castsequence [nochanneling,nocombat] reset=combat/target Azure Strike, null
/cast [harm,nochanneling,combat] Azure Strike

🔵 Screenshots:

🔵 Expected behavior:
To Recomplie to the original ingame macro
🔵 GSE Version:
3.2.07.a Patreon

This is an everythwere thing not just managed macros.

I have a fix but i cant fix the visual /target going purple.  It sees that /target is a valid macro command.


Failure report prints decimal, double and integer in indistinguishable notation

test.xsl (does nothing explicitly)
<?xml version="1.0" encoding="UTF-8"?>
<xsl:stylesheet version="2.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform" />

test.xspec (a series of x:expect that always fails)
<?xml version="1.0" encoding="UTF-8"?>
<x:description stylesheet="test.xsl" xmlns:x="http://www.jenitennison.com/xslt/xspec">
	<x:scenario label="Scenario for testing numeric type report">
		<x:context />
		<x:expect label="xs:decimal" select="xs:decimal(1)" />
		<x:expect label="xs:double" select="xs:double(1)" />
		<x:expect label="xs:integer" select="xs:integer(1)" />
	</x:scenario>
</x:description>

The test fails as expected and the failure reports are generated.
So far so good.
But all the three failure reports look like this:

Result
Expected Result

()
1

xs:decimal and xs:double are rendered in the same way as xs:integer.
Tested on the latest master clone.

Probably test:report-atomic-value() is trying to emit numeric literals, in an incomplete way.
Per the spec,

The value of a numeric literal containing no "." and no e or E character is an atomic value of type xs:integer. The value of a numeric literal containing "." but no e or E character is an atomic value of type xs:decimal. The value of a numeric literal containing an e or E character is an atomic value of type xs:double.

Labeling as bug, because it doesn't respect the spec without stating a specific reason.


Issues Connecting to DEX

During testing DEX, I had problems connecting the wallet, it periodically failed (some network issues):

also, the pop-up opens not in the web wallet, but on the Dex page:
https://user-images.githubusercontent.com/69896204/171997383-7a6dbd85-c019-44dd-9ceb-94f47403cd25.mov
When testing, I experienced constant problems with sh wallet:

That is mostly the DEX issue, should be fixed on their side.

After connecting the wallet to the dex, it works on the main network, although the wallet uses the testnet:
https://dex.prd.aepps.com/swap
The errors described above are reproduced.
Then the network itself switches to the test one and the dex works fine.
Then I didn’t use dex for a while and it spontaneously returned to the main network and connection errors began to reproduce again.

Still reproducible on dev branch https://github.com/aeternity/superhero-wallet/commit/e7028cdb3de7f8bce30922404ec58699f144d4a2: After connecting the wallet to the dex, it works on the main network, although the wallet uses the testnet

This issue should be fixed on the DEX side. Wallet sends current networkId in the callback URL.


Anchor links on the docs don't take the header bar into consideration

Example: http://googlecloudplatform.github.io/gcloud-ruby/docs/v0.1.0/index.html#label-Quick+Start
Note in the screenshot that the anchor is covered up by the header bar -- looks like we need some extra offset.....

This is fixed. Here is an example anchor that is no longer be hidden by the navigation bar.


"Assign IDs" change causing false positive with pytorch-lightning?

This morning pip-audit (https://github.com/trailofbits/pip-audit -- uses Python Packaging Advisory Database) has started reporting pytorch-lightning version 1.6.2 as vulnerable to GHSA-r5qj-cvf9-p85h (Code Injection, critical severity) even though the advisory itself (https://github.com/advisories/GHSA-r5qj-cvf9-p85h) says the vulnerability only affects versions <= 1.5.10.
$> pip freeze | grep pytorch-lightning
pytorch-lightning==1.6.2

$> pip-audit
Found 1 known vulnerability in 1 package
Name              Version ID                  Fix Versions
----------------- ------- ------------------- ------------
pytorch-lightning 1.6.2   GHSA-r5qj-cvf9-p85h

The issue seems to have started today, after this change: https://github.com/pypa/advisory-database/commit/f571c787901d26f5630035eba65e9b6b9c7b30f1#diff-d458faf0f7e3ad7c2ac023f3d01f6c51794703b57a12a14abbdfd6c51cd94645L1
Is this an issue with the change introduced to the advisory database or is there something that either pip-audit or pytorch-lightning need to do to correct the mismatch?

Seems possibly related to https://github.com/google/osv/issues/430

Note that the issue is also present when querying api.osv.dev directly:
$> curl -X POST -d \
          '{"version": "1.6.2", "package": {"name": "pytorch-lightning", "ecosystem": "PyPI"}}' \
          "https://api.osv.dev/v1/query"
{"vulns":[{"id":"GHSA-r5qj-cvf9-p85h","summary":"Code Injection in PyTorch Lightning","details":"PyTorch Lightning version 1.5.10 and prior is vulnerable to code injection. There is currently a [patch](https://github.com/pytorchlightning/pytorch-lightning/commit/8b7a12c52e52a06408e9231647839ddb4665e8ae) available, anticipated to be part of the `1.6.0` release.","aliases":["CVE-2022-0845"],"modified":"2022-05-18T04:18:38.825182Z","published":"2022-03-06T00:00:16Z","database_specific":{"github_reviewed":true,"severity":"CRITICAL","cwe_ids":["CWE-94"]},"references":[{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2022-0845"},{"type":"WEB","url":"https://github.com/PyTorchLightning/pytorch-lightning/pull/12212"},{"type":"WEB","url":"https://github.com/pytorchlightning/pytorch-lightning/commit/8b7a12c52e52a06408e9231647839ddb4665e8ae"},{"type":"WEB","url":"https://huntr.dev/bounties/a795bf93-c91e-4c79-aae8-f7d8bda92e2a"},{"type":"PACKAGE","url":"https://github.com/pytorchlightning/pytorch-lightning/"}],"affected":[{"package":{"name":"pytorch-lightning","ecosystem":"PyPI","purl":"pkg:pypi/pytorch-lightning"},"ranges":[{"type":"ECOSYSTEM","events":[{"introduced":"0"}]}],"versions":["0.0.2","0.10.0","0.2","0.2.2","0.2.3","0.2.4","<IP_ADDRESS>","0.2.5","<IP_ADDRESS>","<IP_ADDRESS>","0.2.6","0.3","0.3.1","0.3.2","0.3.3","0.3.4","<IP_ADDRESS>","0.3.5","0.3.6","<IP_ADDRESS>","<IP_ADDRESS>","<IP_ADDRESS>","<IP_ADDRESS>","<IP_ADDRESS>","<IP_ADDRESS>","<IP_ADDRESS>","<IP_ADDRESS>","0.4.0","0.4.1","0.4.2","0.4.3","0.4.4","0.4.5","0.4.6","0.4.7","0.4.8","0.4.9","0.5.0","0.5.1","<IP_ADDRESS>","<IP_ADDRESS>","0.5.2","<IP_ADDRESS>","0.5.3","<IP_ADDRESS>","<IP_ADDRESS>","<IP_ADDRESS>","0.6.0","0.7.1","0.7.3","0.7.5","0.7.6","0.8.1","0.8.3","0.8.4","0.8.5","0.9.0","1.0.0","1.0.1","1.0.2","1.0.3","1.0.4","1.0.5","1.0.6","1.0.7","1.0.8","1.1.0","1.1.1","1.1.2","1.1.3","1.1.4","1.1.5","1.1.6","1.1.7","1.1.8","1.2.0","1.2.0rc0","1.2.0rc1","1.2.0rc2","1.2.1","1.2.10","1.2.2","1.2.3","1.2.4","1.2.5","1.2.6","1.2.7","1.2.8","1.2.9","1.3.0","1.3.0rc1","1.3.0rc2","1.3.0rc3","1.3.1","1.3.2","1.3.3","1.3.4","1.3.5","1.3.6","1.3.7","1.3.7.post0","1.3.8","1.4.0","1.4.0rc0","1.4.0rc1","1.4.0rc2","1.4.1","1.4.2","1.4.3","1.4.4","1.4.5","1.4.6","1.4.7","1.4.8","1.4.9","1.5.0","1.5.0rc0","1.5.0rc1","1.5.1","1.5.10","1.5.2","1.5.3","1.5.4","1.5.5","1.5.6","1.5.7","1.5.8","1.5.9","1.6.0","1.6.0rc0","1.6.0rc1","1.6.1","1.6.2","1.6.3"],"database_specific":{"last_known_affected_version_range":"\u003c= 1.5.10","source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/03/GHSA-r5qj-cvf9-p85h/GHSA-r5qj-cvf9-p85h.json"}}],"schema_version":"1.2.0","severity":[{"type":"CVSS_V3","score":"CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H"}]}]}

The way GitHub encodes this vulnerability states it's not fixed: https://github.com/advisories/GHSA-r5qj-cvf9-p85h (see "patched version" being listed as "none").
I submitted https://github.com/github/advisory-database/pull/300 to fix this.

Looks like https://github.com/github/advisory-database/pull/300 has been merged and the "patched version" is now listed as 1.6.0 (https://github.com/advisories/GHSA-r5qj-cvf9-p85h).
Nevertheless, api.osv.dev is still reporting the vulnerability...
$> curl -X POST -d \
          '{"version": "1.6.2", "package": {"name": "pytorch-lightning", "ecosystem": "PyPI"}}' \
          "https://api.osv.dev/v1/query"
{"vulns":[{"id":"GHSA-r5qj-cvf9-p85h","summary":"Code Injection in PyTorch Lightning","details":"PyTorch Lightning version 1.5.10 and prior is vulnerable to code injection. There is currently a [patch](https://github.com/pytorchlightning/pytorch-lightning/commit/8b7a12c52e52a06408e9231647839ddb4665e8ae) available, anticipated to be part of the `1.6.0` release.","aliases":["CVE-2022-0845"],"modified":"2022-05-18T04:18:38.825182Z","published":"2022-03-06T00:00:16Z","database_specific":{"severity":"CRITICAL","github_reviewed":true,"cwe_ids":["CWE-94"]},"references":[{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2022-0845"},{"type":"WEB","url":"https://github.com/PyTorchLightning/pytorch-lightning/pull/12212"},{"type":"WEB","url":"https://github.com/pytorchlightning/pytorch-lightning/commit/8b7a12c52e52a06408e9231647839ddb4665e8ae"},{"type":"WEB","url":"https://huntr.dev/bounties/a795bf93-c91e-4c79-aae8-f7d8bda92e2a"},{"type":"PACKAGE","url":"https://github.com/pytorchlightning/pytorch-lightning/"}],"affected":[{"package":{"name":"pytorch-lightning","ecosystem":"PyPI","purl":"pkg:pypi/pytorch-lightning"},"ranges":[{"type":"ECOSYSTEM","events":[{"introduced":"0"}]}],"versions":["0.0.2","0.10.0","0.2","0.2.2","0.2.3","0.2.4","<IP_ADDRESS>","0.2.5","<IP_ADDRESS>","<IP_ADDRESS>","0.2.6","0.3","0.3.1","0.3.2","0.3.3","0.3.4","<IP_ADDRESS>","0.3.5","0.3.6","<IP_ADDRESS>","<IP_ADDRESS>","<IP_ADDRESS>","<IP_ADDRESS>","<IP_ADDRESS>","<IP_ADDRESS>","<IP_ADDRESS>","<IP_ADDRESS>","0.4.0","0.4.1","0.4.2","0.4.3","0.4.4","0.4.5","0.4.6","0.4.7","0.4.8","0.4.9","0.5.0","0.5.1","<IP_ADDRESS>","<IP_ADDRESS>","0.5.2","<IP_ADDRESS>","0.5.3","<IP_ADDRESS>","<IP_ADDRESS>","<IP_ADDRESS>","0.6.0","0.7.1","0.7.3","0.7.5","0.7.6","0.8.1","0.8.3","0.8.4","0.8.5","0.9.0","1.0.0","1.0.1","1.0.2","1.0.3","1.0.4","1.0.5","1.0.6","1.0.7","1.0.8","1.1.0","1.1.1","1.1.2","1.1.3","1.1.4","1.1.5","1.1.6","1.1.7","1.1.8","1.2.0","1.2.0rc0","1.2.0rc1","1.2.0rc2","1.2.1","1.2.10","1.2.2","1.2.3","1.2.4","1.2.5","1.2.6","1.2.7","1.2.8","1.2.9","1.3.0","1.3.0rc1","1.3.0rc2","1.3.0rc3","1.3.1","1.3.2","1.3.3","1.3.4","1.3.5","1.3.6","1.3.7","1.3.7.post0","1.3.8","1.4.0","1.4.0rc0","1.4.0rc1","1.4.0rc2","1.4.1","1.4.2","1.4.3","1.4.4","1.4.5","1.4.6","1.4.7","1.4.8","1.4.9","1.5.0","1.5.0rc0","1.5.0rc1","1.5.1","1.5.10","1.5.2","1.5.3","1.5.4","1.5.5","1.5.6","1.5.7","1.5.8","1.5.9","1.6.0","1.6.0rc0","1.6.0rc1","1.6.1","1.6.2","1.6.3"],"database_specific":{"last_known_affected_version_range":"\u003c= 1.5.10","source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/03/GHSA-r5qj-cvf9-p85h/GHSA-r5qj-cvf9-p85h.json"}}],"schema_version":"1.2.0","severity":[{"type":"CVSS_V3","score":"CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H"}]}]}

Is there something that the package maintainer needs to fix, or is this just an inaccuracy in the advisory database?

@ardell looks like there was a bit of propagation delay. the API returns the correct result now.
I'll look into if we can reduce this latency.

(Tracked in https://github.com/google/osv/issues/440)

Looks like in this case, this is because the actual change wasn't merged into the main branch directly. There's some other pipeline here doing the updates.
My PR really only landed in https://github.com/github/advisory-database/commits/266a99624dfbfc1897409adb72286bb56e1f1986/advisories/github-reviewed/2022/03/GHSA-r5qj-cvf9-p85h/GHSA-r5qj-cvf9-p85h.json, several hours after https://github.com/github/advisory-database/pull/300 was merged.
OSV.dev picked this up within 15 minutes.

I can confirm, it's working for me now as well. Thanks so much for all your help @oliverchang !