fix(plugin): handle empty response in sync-sequences plugin command

Fix the kubectl-cnpg subscription sync-sequences execution when the source or the destination database has no sequence.
Previously, the command was failing with the following error:
Error: while getting sequences status from the source database: while decoding JSON output: unexpected end of JSON input
Closes #4345

/ok-to-merge


Support nil instead of structs (especially under volumes)

Another special deserialization case

There are probably some other cases were this would be useful, but they're hard to identify. So we can fix those when people report them.


include message count in pipeline full err message

What does this PR do?

Add additional logging related to event platform forward channels
update dbquery-intake to match other pipelines (tech debt cleanup)

Motivation
We have seen a recent spate of issues that point to this error message, and we'd like more info.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

@EmmaOnThursday while we are in here can we update this endpoint dbquery-intake. to match dbm-metrics-intake. like the other endpoints?
The samples endpoint doesn't need to be different, and they resolve to the same thing so just a nice cleanup thing to do. If you remember from building out US5, creating a DNS record for this endpoint was an annoying extra step we had to take to make samples ingestion work

@EmmaOnThursday while we are in here can we update this endpoint dbquery-intake. to match dbm-metrics-intake. like the other endpoints?
The samples endpoint doesn't need to be different, and they resolve to the same thing so just a nice cleanup thing to do. If you remember from building out US5, creating a DNS record for this endpoint was an annoying extra step we had to take to make samples ingestion work

Sorry, I don't really remember. What about the endpoints should match better - the hostnameEndpointPrefix?

yeah they can all safely be this now:
hostnameEndpointPrefix: "dbm-metrics-intake.",

for dbm related tracks

Are we planning to add any better metrics around the HTTP status codes that we are getting back from our own APIs? Right now we log the number of the errors for samples, activity & metrics, but this isn't super helpful bc it doesn't tell us much about what the issue is. For example, I am thinking adding more information about what we do (or don't) get back would be helpful for spotting networking issues?

Are we planning to add any better metrics around the HTTP status codes that we are getting back from our own APIs? Right now we log the number of the errors for samples, activity & metrics, but this isn't super helpful bc it doesn't tell us much about what the issue is. For example, I am thinking adding more information about what we do (or don't) get back would be helpful for spotting networking issues?

I'll work on this separately, but it's not really relevant to this change, which is just adding more info around the channel errors specifically.

Are we planning to add any better metrics around the HTTP status codes that we are getting back from our own APIs? Right now we log the number of the errors for samples, activity & metrics, but this isn't super helpful bc it doesn't tell us much about what the issue is. For example, I am thinking adding more information about what we do (or don't) get back would be helpful for spotting networking issues?

I'll work on this separately, but it's not really relevant to this change, which is just adding more info around the channel errors specifically.

sure, just a suggestion. It just seemed like we wouldn't get enough information out of just this change? I'm not sure what the customer logs looked like who turned this on so just guessing


[AMBARI-25147] [Log Search UI] Update the development readme

What changes were proposed in this pull request?
Updating the development docs for the UI.
How was this patch tested?
N/A
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/136/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/137/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/138/
Test PASSed.


Why there is a Flutter Dependency in Directus Dart Package for shared_preferences?

The shared_preferences package is presently used by the Directus Dart package. But having a Flutter dependency in a Dart app seems uncommon. This bug seeks to explain the justification for using the Flutter dependency and investigate possible alternatives or modifications.
Could you please provide an explanation & example for the inclusion of the Flutter dependency in the Directus Dart package It would also be beneficial to investigate alternate strategies or improvements to eliminate the Flutter dependency while still enabling the shared_preferences capability in the Dart project.

If directus package is developed for improving DX for Flutter Developers, IMO We should add the example as a Flutter Project
Can we add the Flutter Example in directus package?
What's your thought on this? @apstanisic

Sure. PRs are welcome

@apstanisic  I have created a separate issue to track the addition of the Flutter example. #72


Fix date file format

A bug was introduce in https://github.com/vitmalina/w2ui/commit/ac2e968e7fc40733c95ee2dc978e2d3bb2e1cf66
Eg: I have :
date = "04/03/2020"; // Mar 4 2020
datefomat = "dd/mm/yyyy";

w2utils.idDate use new Date(val) and decode the date as a short dates with "MM/DD/YYYY" format (see https://www.w3schools.com/js/js_date_formats.asp) and decode the date as Apr 3 2020 insted of Mar 4 2020

Thank you for your contribution. However, w2utils.isDate is covered by unit tests. Can you please add unit test for your particular case, you can find it here qa/index.html. In my branch currently 3 assertions fail, I am not sure why. Can you see if you can fix it in a way that current test pass and that your new condition is another passing assessment.

Hi @vitmalina
With my patch all tests pass :

I will add my particular case in the unit tests.

I added a test to the PR.
Now all tests pass.

Awesome. Thank you for your contribution


[discussion]can make JobFuture subclass of concurrent.futures.Future?

Just an idea for discussion.
concurrent.futures.Future is more compatible with other framework. Especially it can be converted to asyncio future directly by asyncio.wrap_future that make it easy to support async operations.

It would be a great improvement if it could be compatible with other frameworks. Do you have any ideas on how to achieve that?

I am trying to use concurrent Future directly instead of JobFuture, I will report if success.


Add instructions for removing a failed replica

File: datacenter/dtr/2.2/guides/admin/backups-and-disaster-recovery.md, CC @joaofnfernandes
There are no instructions for how to remove a failed replica.  Here is an example
docker run -it --rm docker/dtr:2.2.4 remove --replica-id fdc4ee12bb84 --existing-replica-id ed46a108546c --ucp-insecure-tls

Where --replica-id is a failed replica and --existing-replica-id is a healthy replica.

DTR now has the destroy command, so things should be a bit more obvious now. Let me know if this is still an issue.

The destroy command isn't for removing a failed replica though.  I'd like to see it documented how you would handle the loss of a single replica of DTR to restore it back to a fault tolerant state.  The docs only talk about a full restore from scratch when that is not necessary for a loss of a single replica: https://docs.docker.com/datacenter/dtr/2.3/guides/admin/backups-and-disaster-recovery/

Let me reopen this issue and change the title to reflect that.

https://github.com/docker/docker.github.io/issues/3684 was a duplicate of this; forgot I already had the same issue already open but for both UCP and DTR.


🐛 Inconsistent Modal Display for "See External Data" on Different Screen Sizes

Area
Other
Domain
dev-sanchogov.tools
Which wallet were you using?
No response
Context
When navigating to a governance action with incorrectly formatted data, clicking "See External Data" triggers a modal popup. On a desktop-sized screen, the modal displays a warning with the title "Be careful":

However, resizing the screen to a mobile view changes the modal to display a different title: "External Link Safety":

Steps to reproduce

Navigate to any governance action page with data formatted incorrectly.
Click on "See External Data".
Observe the modal with the title "Be careful".
Resize the screen to a mobile view.
Notice the modal title changes to "External Link Safety".

https://www.loom.com/share/d453cc5c386e4ffeb51093a60e310200?sid=21155d0e-7596-4c6b-8fca-906ac659a8f7
Actual behavior
Two different modals are displayed for the same action depending on the screen size.
Expected behavior
The same modal should be displayed regardless of screen size for the same action.
Question

Is this the intended behavior, or was it overlooked for smaller screens?

Great catch @kneerose


wasmer: 4.3.4 -> 4.3.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/wasmer/versions.
meta.description for wasmer is: Universal WebAssembly Runtime
meta.homepage for wasmer is: https://wasmer.io/
Updates performed

Rust version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.3.5 with grep in /nix/store/c37s1qazarf4lnz7x7c0fjmsnac3sf0a-wasmer-4.3.5
found 4.3.5 in filename of file in /nix/store/c37s1qazarf4lnz7x7c0fjmsnac3sf0a-wasmer-4.3.5

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

wasmer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/c37s1qazarf4lnz7x7c0fjmsnac3sf0a-wasmer-4.3.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A wasmer https://github.com/r-ryantm/nixpkgs/archive/cca88a1f5d0a3a9a688ad2648a688c3b75605675.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/cca88a1f5d0a3a9a688ad2648a688c3b75605675#wasmer

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/c37s1qazarf4lnz7x7c0fjmsnac3sf0a-wasmer-4.3.5
ls -la /nix/store/c37s1qazarf4lnz7x7c0fjmsnac3sf0a-wasmer-4.3.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

wasmer

Maintainer pings
cc @Br1ght0ne @SCOTT-HAMILTON @NickCao for testing.

Result of nixpkgs-review pr 329614 run on x86_64-linux 1

1 package built:

wasmer


AttributeError

When trying to attach multiple media to a post, users receive the following error
'Album' object does not have 'as_media_group' attribute

Fixed!


Using Crossplane in  GitOps

https://kccncosschn21.sched.com/event/pcdv/yun-sakaki-27dya-daepcrossplane-tafu-qi-zhi-beyond-infraservice-provision-the-crossplane-essentials-and-adoption-guang-ya-liu-ying-mo-ibm
超越基础架构/服务提供：Crossplane 本质与采用 | Beyond Infra/Service Provision: The Crossplane Essentials and Adoption - Guang Ya Liu & Ying Mo, IBM
Thursday December 9, 2021 14:05 - 14:40 CST
Open Source Summit 演讲厅
作为 Kubernetes 的开源附加组件，Crossplane 允许人们组装来自多个供应商的基础架构，人们可将其作为一个高级别的抽象概念来利用，而无需编写代码。在过去的几年时间里，Crossplane 迅速发展成为一个非常活跃的社区。人们经常讨论的 Crossplane 最常见的用例是在公共云上提供基础架构和服务。但如你了解了 Crossplane 的本质，你会发现它可以做得更多。在本会话中，发言者将首先通过深入探讨 Crossplane 内部的一些关键因素，分享一些关于 Crossplane 本质的想法，然后会通过现场演示探索一些有趣的使用场景，并根据实际案例研究，详细介绍如何使用 Crossplane，例如功能编排、特定领域的可组合特性、带 Crossplane 的 GitOps 等。这些分享均来自发言者的亲身经验，以及通过与社区紧密合作就 Crossplane 采用得到的持续观察。
Crossplane as an open source Kubernetes add-on allows people to assemble infrastructure from multiple vendors and exposes as a higher level abstraction to consume without writing code. It has evolved rapidly with a very active community during the last couple of years. The most common use case of Crossplane that people often discuss is to provision infrastructure and services on public clouds. However, if you learn the essentials of Crossplane, you will see it can do more. In this session, the speakers will firstly share some thoughts on the nature of Crossplane by deep diving some key factors reflected inside Crossplane, then explore a few interesting usage scenarios with live demo zoomed in on how it can be used based on real case study, e.g. capabilities orchestration, domain-specific composable traits, GitOps with Crossplane, etc. These sharing all come from the speakers' first hand experience and continuous observation on Crossplane adoption by working closely with the community.

https://github.com/morningspace/capabilities-shim-gitops/blob/main/docs/using-crossplane-in-gitops-2.md


Improve Logs from Updating Conditions

The UpdateConditions function has an error only when an unknown agent has been found. Thus, there is no need to return and check it from reconcile, since it is not an error from trying to update it.
FAR can simply log an informative error when it was called when unknown ConditionsChangeReason.
Moreover, the lastTrinsitionTime print is more human friendly

/test 4.14-openshift-e2e
/test 4.15-openshift-e2e

/test 4.14-openshift-e2e
/test 4.15-openshift-e2e

/lgtm

/retest

/retest

I wonder if all the error messages after UpdateStatus failures could be put inside UpdateStatus function itself.

They can but this way we log an error in the function and Reconcile

I wonder if all the error messages after UpdateStatus failures could be put inside UpdateStatus function itself.

They can but this way we log an error in the function and Reconcile

Sorry, I meant inside utils.UpdateConditions.
IIUC the additional information this new logs provide is the CR's name, which is already accessible inside utils.UpdateConditions, so we could simply update the error logs that are inside utils.UpdateConditions

SGTM

/retest


Correct handling of DPI related information

Continue discussion from https://github.com/unrust/uni-app/pull/3

@IvoWingelaar, @jice-nospam  Indeed,  I would prefer to discuss all these changes in issue page first and make it easy to track.
On the other hand, Here is my two cents about DPI related issues:

Mouse coordinates and Window sizes should be returned and stored as Logical* values. These are DPI, and DPI-change insensitive.
If using for example glViewport, you simply multiply these values with a hidpi factor.

I think it is okay in general, but how to handle multiple-monitor situation ? Of course currently unrust did not handle it, but for Native values we do not require to handle it (except UI).
Or, How about we embed the DPI information in all these Logical values (e.g. a tuple / struct (x,y, w,h,dpi), or an enum which provide the information and conversion ) ?

When drawing things that need to be pixel-perfect, either disable the DPI flag I proposed, or divide the coordinates/locations by the hidpi factor.

This one is a little bit tricky. I would recommend us to provide a logical to native conversion utility, or as above mentioned, use an Enum to represent all DPI related information.

think it is okay in general, but how to handle multiple-monitor situation ?

I'm not quite sure what you mean with this, but if we drag a window from one screen (with DPI 1.0 for example) to another screen (with DPI 1.5), these values do not change. That's the entire reason why we want to use the glutin::dpi::Logical* values. The only thing that needs to happen to correctly handle this in the draw loop is to use glViewport with glutin::dpi::PhysicalSize.

Or, How about we embed the DPI information in all these Logical values

Is copying the two glutin structs not an option? We can't reexport them from glutin because we don't compile that crate on wasm platforms (can you reexport a single module from a crate?). But they have a sensible design and all necessary conversion functions. We might even place a link in the uni-app docs to the explanation in the glutin::dpi module.

This one is a little bit tricky.

All solutions we can implement are going to be hacks. Intercepting a DPI-change event and force resizing the window to the correct resolution will "flicker" the size for a single frame. It might actually be better to convince the winit contributors of this use-case and ask them to implement a force_dpi flag on their end.

It appears a similar discussion is already happening here. We should probably just wait for this to settle.

It appears a similar discussion is already happening here. We should probably just wait for this to settle.

Indeed, It is a great read. let's wait and see if it is settled.
On the other hand, I feel sorry as I am still feel confused about this issue, because it is related to too many stuffs, i.e, multiple screen, multiple platform (inconsistent behavior) etc.
And i don't have a use-case either (i don't have a high-dpi monitor for windows testing), so if you have any idea, please let me know.

I'm not quite sure what you mean with this, but if we drag a window from one screen (with DPI 1.0 for example) to another screen (with DPI 1.5), these values do not change.

Just peeking in, apparently winit should produce a HiDpiFactorChanged event in that case.  What it does when a window overlaps two screens is something I haven't investigated, I admit, but that's a quite literal edge case...

@icefoxen Thanks. And just want to ask a related question, how ggez will handle something like force_dpi flag feature (People want to use  PhysicalSize instead of LogicalSize) ? I can see some games (e.g roguelike games) with need pixel perfect information.

@icefoxen I assume it does nothing until you're fully inside the new monitor. You need exactly one physical size for glViewport to work correctly, for example.
It's a shame that I currently do not have a setup with which I can check this :frowning_face:.

@edwin0cheng ggez's DPI discussion is happening here, it's nooooot 100% settled yet how it will work out.  I intend to have a force_dpi feature of some kind but not sure yet whether we can make it work easily and acceptably in winit, or whether it will need to be implemented in ggez.


🧼🧽 Clean up CSS

unnecessary code removed (details)
standardize colors (all in lowercase hex)
set a fixed width and height of the round buttons. (no CSS)
timestamp section has been fixed
before:

.timestamp {
    text-align: right;
    margin-top: 0.5;
    margin-bottom: 0;

after:
.timestamp {
   text-align: right;
   margin-top: .5em;
   margin-bottom: 0;
 }

The unit was missing from margin-top.

Thanks for starting on this maintenance task!
I like the unifying of cases and great with the explicit height and width of the buttons.
I am not sure about removing units when the value is zero, nor removing the zero when the value is between 0 and 1. Both those reduce legibility in my opinion.
I don't understand what you mean with "unnecessary code removed (details)", could you explain that further?

I like it and I think it makes it more consistent.

Super minor note from my end, but that's it.

I don't understand what you mean with "unnecessary code removed (details)", could you explain that further?

The unnecessary code is this:

I am not sure about removing units when the value is zero, nor removing the zero when the value is between 0 and 1.

Even with my limited knowledge of CSS, I can still read it.
The main user of the CSS is of course the browser (humans are a bonus)😉.


Better to move phpunit/phpunit into require-dev

May I ask why?
require-dev:

Lists packages required for developing this package, or running tests, etc.

For php-mock-phpunit PHPUnit is more than that. It's a hard dependency.
Where do you see the benefit in having it in require-dev?

Yes, it actually makes no diffrences. For every normal packages, they have phpunit in require-dev,  so why move it into require? (Notice that there is no diffrences in use.)
There is another scene: Suppose that I already have phpunit installed as cli-tools, then the require for phpunit/phpunit is redundant. If had it removed, I can require php-mock-phpunit, then composer install weil run more quickly then before and unittest can still be performed.

Yes, it actually makes no diffrences.

It does. If one for what ever reason would not specify phpunit as dependency php-mock-phpunit would appear broken. More over php-mock-phpunit is not compatible with every phpunit version. If someone has let's say a dependency to phpunit-3 and wants to require php-mock-phpunit, composer will clearly say what's wrong. This will not happen if phpunit is a require-dev dependency of php-mock-phpunit.

Suppose that I already have phpunit installed as cli-tools

It's not a good practice to suppose such things. If you want to manage your dependencies your self, don't use composer.

Yes, it actually makes no diffrences.

I mean, if I always require-dev php-mock-phpunit, (maybe this is a good practice,) it makes no diffrences whether php-mock-phpunit require or require-dev phpunit/phpunit. When I run composer install --dev, both of them will be installed, when composer install --no-dev, none of them will be installed.


Add decode method for raw decoding

Export public method to decode into the raw HRP and the data bytes.

One quick piece of feedback: do you think it's worth allocating a String to return the HRP and case it to lowercase instead of returning the original HRP? We kinda already do that with the hrp_bytes that is used for the checksum validation.

It's probably easier for potential users of this function if it always outputs a lowercase HRP. It could return a Cow<'a, str> for that purpose. But maybe we want to generally rethink the ownership of Bech32 as I wrote in #30? In that case the function could return a minimally owning bech32 struct.

Superseded by https://github.com/rust-bitcoin/rust-bech32/pull/34. Let's move discussion there.

Included in #35


Dark Mode subscription modal

It should be dark if user is using dark mode refer to design

Check this also

Resolved.

Verified this issue on keeper app v 1.1.7(259)


Modern PHP logo

https://www.php.net/images/logos/php-logo.svg
https://www.php.net/download-logos.php

Added in 5c37ced5af141246a5ebbfca4875a2e4f379ab5f
Thanks


Merge to master

This change is

Reviewed 109 of 112 files at r1, 2 of 2 files at r2, 3 of 3 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 26 of 27 files at r4, 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

byuSuite/Apps/Calendars/model/CalendarCategory.m, line 13 at r5 (raw file):

#import "NSString+HTML.h"

#define I_CAL_FEED_BASE_URL @"webcal://calendar-test.byu.edu/iCal/export/"

Needs prod

Comments from Reviewable

Reviewed 1 of 1 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r7.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Modules for Network and Interfaces

Current state:
No option to list network interfaces, IP, Link Status, Link Speed and Mac Address.
Wanted state:

Module Network listing connected networks.
Module Interface to list network interfaces, link speed, link status, mac address and IP Address.

Why the change is sensible:
Better idea of networking connectivity on host.

Added a new module to show mac address

Thanks @CarterLi appreciate it. Testing now.

Would it be possible to also grab the IP addresses for each interface? I understand that there is LocalIP and PublicIP. But there is no function to list all IP's unless I missed something.

Implemented in my local branch, but I don't plan to back port it to dev branch.


Functionality for content authoring: Branching

SoW 901 - MS04

OCC deliverable currently in UAT

5/5 still waiting to be tested.  NHSD-test Mauro instance needs to have the Jodit plug-in before UAT can take place.

This task is already picked in #198.

Already burned in 2021 but not closed.


add: sieve_of_eratosthenes.py

Title : This PR adds the code for the implementation of Sieve Of Eratosthenes.
Issue no : #133
Description
This PR adds a new directory Math and a file sieve_of_eratosthenes.py.
The folder Math will contain all the code implementations regarding mathematical equations and methods.
Checklist

[*] I have read and agree to abide by the Code of Conduct
[*] I have read and followed the Contributing Guidelines

Great job!
Thank you for contributing. Do give this repository a star if you feel like ✨


wrong link

for
SW1, SW2 | RESET/BOOT push button | C115357
the link is wrong
i think this is the right link
https://lcsc.com/product-detail/Tactile-Switches_ALPS-Electric-SKRKAEE020_C115357.html

Yes, absolutely. Fixed by #2


Warnings on Ubuntu 22.04.2 - gcc

Hi,
FYI. As discussed on reddit:
$ ./build.sh -c gcc -b release
-- The C compiler identification is GNU 11.4.0
-- The CXX compiler identification is GNU 11.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- {fmt} version: 11.0.2
-- Build type: release
--
--
-- Project configure summary:
--
--   CMake build type .................: RELEASE
--   Install prefix ...................: /usr/local
--   Build shared library .............: OFF
--   Build static library .............: ON
--
-- Project 'expected_lite', package 'expected-lite' version: '0.6.3'
-- RESTINIO_VERSION:   0.7.2
-- RESTINIO_SOVERSION: 0.7
-- RESTINIO_VERSION: 0.7.2
-- restinio target will use asio_INCLUDE_DIRS include dirs: ../asio/include
-- restinio target will depend on 'llhttp::llhttp' target
-- restinio target will depend on 'fmt::fmt' target
-- restinio target will depend on 'nonstd::expected-lite' target
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- HIBP Tests are disabled. Set HIBP_TEST to ON to run tests.
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    INSTALL_GTEST

-- Build files have been written to: /home/joe/__git/oschonrock-hibp/build/gcc/release
[18/43] Building CXX object CMakeFiles/diffutils.dir/src/diffutils.cpp.o
In file included from /home/joe/__git/oschonrock-hibp/include/hibp.hpp:3,
                 from /home/joe/__git/oschonrock-hibp/src/diffutils.cpp:2:
/home/joe/__git/oschonrock-hibp/include/arrcmp.hpp:117:86: warning: ignoring attributes in template argument ‘(arrcmp::impl::sse && (N >= sizeof (__m128i)))’ [-Wignored-attributes]
  117 |                        std::conditional_t<sse && N >= sizeof(__m128i), __m128i, std::uint64_t>>>;
      |                                                                                ^~~~~~~~
/home/joe/__git/oschonrock-hibp/include/arrcmp.hpp:117:86: warning: ignoring attributes on template argument ‘__m128i’ [-Wignored-attributes]
/home/joe/__git/oschonrock-hibp/include/arrcmp.hpp:117:94: warning: ignoring attributes in template argument ‘(arrcmp::impl::avx2 && (N >= sizeof (__m256i)))’ [-Wignored-attributes]
  117 |                        std::conditional_t<sse && N >= sizeof(__m128i), __m128i, std::uint64_t>>>;
      |                                                                                ^~
/home/joe/__git/oschonrock-hibp/include/arrcmp.hpp:117:94: warning: ignoring attributes on template argument ‘__m256i’ [-Wignored-attributes]
/home/joe/__git/oschonrock-hibp/include/arrcmp.hpp:117:96: warning: ignoring attributes in template argument ‘(arrcmp::impl::avx512 && (N >= sizeof (__m512i)))’ [-Wignored-attributes]
  117 |                        std::conditional_t<sse && N >= sizeof(__m128i), __m128i, std::uint64_t>>>;
      |                                                                                ^
/home/joe/__git/oschonrock-hibp/include/arrcmp.hpp:117:96: warning: ignoring attributes on template argument ‘__m512i’ [-Wignored-attributes]
/home/joe/__git/oschonrock-hibp/include/arrcmp.hpp: In function ‘constexpr uint64_t arrcmp::impl::vector_cmp(const std::byte*, const std::byte*)’:
/home/joe/__git/oschonrock-hibp/include/arrcmp.hpp:161:22: warning: ignoring attributes on template argument ‘__m128i’ [-Wignored-attributes]
  161 |   if constexpr (std::same_as<T, __m128i>) {
      |                      ^~~~~~~~~~~~~~~~~~~
/home/joe/__git/oschonrock-hibp/include/arrcmp.hpp:168:29: warning: ignoring attributes on template argument ‘__m256i’ [-Wignored-attributes]
  168 |   } else if constexpr (std::same_as<T, __m256i>) {
      |                             ^~~~~~~~~~~~~~~~~~~
/home/joe/__git/oschonrock-hibp/include/arrcmp.hpp:176:29: warning: ignoring attributes on template argument ‘__m512i’ [-Wignored-attributes]
  176 |   } else if constexpr (std::same_as<T, __m512i>) {
      |                             ^~~~~~~~~~~~~~~~~~~
[43/43] Linking CXX executable hibp-server

Thanks for that... Actually a tricky one.
the "attribute the code is ignoring" is about it being a 128bit (or 256 or 512) type, and about it being 16 or 32 or 64 byte aligned.
Alignment
there are GCC (and clang) specific types eg __m128i_u which we could use to say "we are not guaranteeing it is 16 byte aligned, but it 's fine, because we are using the unaligned loads further down (eg _mm_loadu_si128)
But those types still have "an attribute" saying "align(1)"
emmintrinh.h
typedef double __m128d_u __attribute__((__vector_size__(16), __aligned__(1)));

and anyway they also have an attribute to tell us that they are 16/32/64 bytes big, and we are apparently "ignoring that too".
So I would say that this is a bogus GCC warning, and the code is certainly fine, and I am not sure how to silence the warning without reporting a bug on gcc  (may do that).
clang and MVSC should be happy enough.
Thanks for reporting it, I will leave this open.

Actually...
there already is a long standing (since 2020) "unresolved and suspended" bug on gcc for this issue:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97222
Not much point fighting that.....going to close this now.


Machine Learning widget isn't horizontally scrollable

Steps to Reproduce:

Open server dashboard and navigate to Machine learning widget.

close as duplicate #13981


REAL_IP_HEADER config does not work

Describe the bug
REAL_IP_HEADER config does not work or at least setting it does not change the value of request.ip
Code snippet
Code adapted from the Hello World example of the documentation
from sanic import Sanic
from sanic.response import json

app = Sanic("hello_example")

@app.route("/")
async def test(request):
    return json(
        {
            "Header": request.headers.get("X-Real-IP", "Not found"),
            "Request IP": request.ip,
        }
    )

if __name__ == "__main__":
    app.config["REAL_IP_HEADER"] = "X-Real-IP"
    app.run(host="<IP_ADDRESS>", port=8000)

Expected behavior
With these request
http "http://localhost:8000" "X-Real-IP:<IP_ADDRESS>"
I would like request.ip to be <IP_ADDRESS>
Environment (please complete the following information):

Python is 3.8.3
Sanic is 19.12.2

according to the logic in current source, request.ip is set from the immediate ip from the request and not from the proxy forward headers. you can find the x-real-ip value in request.forwarded.get('for')

Looking at the source, I've also find the X-Real-IP value in request.forward_addr
But if request.ip is always the immediate IP, I don't see the point of the REAL_IP_HEADER config.
My main issue is that I would like the real IP address to be in the access.log, and it's currently request.ip that is being used

I think you meant the request.remote_addr property. As far as my knowledge goes, reverse proxies like nginx replace the requests source ip value with its own and instead put the original ip in the X-Real-Ip header. This way the webserver can differentiate between two requests, one which it received directly and one which it received through the reverse proxy on the basis of the presence of the X-Real-Ip header.
Now to your problem, if you want to change the value in the access logs and don't mind a little monkey patching, you can modify the log_response method in server.py before you initialize your app. In that method various fields from the request are picked and put in an extra dict which is then passed to the access_logger. You would need to change the access log formatter as well, if you add the real ip to a key other than host.

You can also use a request middleware
@app.middleware('request')
async def print_real_ip(request):
    your_logger.info(f'X-Real-Ip: {request.remote_addr}')
    # ... or perhaps you want to change the request.ip value altogether, though I would suggest against this
    request._socket = (request.forwarded.get('for'), request.forwarded.get('port'))

Thanks for the ideas. I guess I can find a «monkey-patch» way
But still, if I need to override methods, the REAL_IP_HEADER has no value. It's the reason why I opened this as an issue in the first place: I can always get the real IP through 'request.headers' but I think the whole idea of having a global config like REAL_IP_HEADER is to make it seamless.
And moreover, as I guess a majority of users are using Sanic behind a reverse proxy, I don't get why it would be so complicated to have the requester IP address in the access.log (which is one of the basic information)

As I see it, the header value should only be trusted by the application developer if its origin is known i.e. they know that they have placed a reverse proxy in between which is providing that value. Since there is no other way to verify its authenticity the header value can very easily be altered (for example by a man in the middle). For all other cases apart from a trusted reverse proxy, the header should be ignored, which is why it is necessary for the webserver to differentiate the forwarded ip and the actual ip it received from the TCP/IP packets source address field.

The remote address is found in request.remote_addr because request.ip is always the peer address directly connecting to Sanic.
I'd recommend switching to the standard Forwarded header by following the Nginx deployment docs where X-headers are not used: https://sanic.readthedocs.io/en/latest/sanic/nginx.html
If you wish to keep using the traditional X-prefixed headers, remember to set the proxy count as well:
app.config.PROXIES_COUNT = 1
app.config.REAL_IP_HEADER = "X-Real-IP"

This is documented in https://sanic.readthedocs.io/en/latest/sanic/config.html#traditional-proxy-headers

Feel free to continue the conversation if needed.


Suport non-standard mime from Deno.jupyter.display

Describe the bug
When encountering objects with non-standard mime, the returned data structure from lsp does not appear to be a standard jupyter, and the non-standard mime data is collapsed into the other field.
To Reproduce

first step

set breakpoint at session.ts:210

second step

test.nb.ts
await Deno.jupyter.display(
    {
        "x-application/github-issues": JSON.stringify({a:1}),
        "x-application/github-issues2": JSON.stringify({a:1}),
    },
    {raw:true}
)

third step

check data at breakpoint, Non-standard mime data is collapsed into the other field, and there's only one, lost x-application/github-issues2 .

Expected behavior
should cover this situation.
I don't understand if this is the standard way of jupter, or the unique way of deno's lsp, and don't understand why it returns so?

@janckerchen Thanks for the report.
That code is kernel controller's business. Is not an lsp issue. Just released a new version. Can you take a look?

fixed. However, the x-application/github-issues renderer internally handles the conversion of strings to json objects, so you can just branch else.

I need to change launch.json after every pull to use F5 debug

@janckerchen ready now https://github.com/redking00/vscode-nbts/commit/f427a6c47ca1032c91b05cfc9327a1fce71cbd96?

fixed, great job


Add diagnostic slides to data module

Describe the solution you'd like
I'd like to have diagnostic slides available in the data module (in particular with pen markers).

Addressed in #61


How to make button in dictDefaultMessage trigger file selector

I customized the default text that is shown before any files are added. I've added a button in the text that I would like the user to actually click on which will then trigger the file selector and they can select the file they want to upload.
Based off of the documentation, I thought I would be able to do this by setting the clickable option of the dropzone to the id of the button I want the user to click. However, this is not working as expected. Even when clickable = "#btn-upload" the whole dropzone, including the button, do nothing when clicked. Obviously I don't want the dropzone to do anything when clicked but I do want the button to open the file selector.
Here are some snippets of the code:
<vue-dropzone
    :id="element.Id + '-video-uploader'"
    :options="videoDropzoneOptions"
    ref="vueDropzone">
</vue-dropzone>

export default {
    components: {
        "vue-dropzone": vue2Dropzone
    },
    props: ["element"],
    data() {
        return {
            videoDropzoneOptions: {
                url: '/UrlToUpload',
                dictDefaultMessage: "
Drag & Drop,
<button id='btn-upload' class='btn btn-primary'>Upload</button>
or link to a video
",
                hiddenInputContainer: "#video-uploader-hidden-input-" + this.element.Id,
                clickable: false
            }
        }
    },
    mounted() {
        this.$refs.vueDropzone.dropzone.options.clickable = "#btn-upload";
    }
});

Am I missing something? I feel like this should work but it's not.

Can I get any help on this issue?

Hey @TheAustinG ,
I half started writing a response the other day and got distracted sorry. Theoretically what you've done should work according to the description on the dropzone docs

If true, the dropzone element itself will be clickable, if false nothing will be clickable. You can also pass an HTML element, a CSS selector (for multiple elements) or an array of those. In that case, all of those elements will trigger an upload when clicked.

Although I'm wondering if you're supposed to pass in selectors that are rendered elsewhere on the DOM, eg a div outside the dropzone and not one that you've passed within the dictDefaultMessage.
Can you try and trigger the clickable with another DOM selector?

Hi @rowanwins,
No worries on the late reply! It seems that you are correct, if I put the element outside of the dropzone then it works as expected. Not the most ideal situation but I can definitely make it work!
Thanks again for your help!

s

Hi @rowanwins,
No worries on the late reply! It seems that you are correct, if I put the element outside of the dropzone then it works as expected. Not the most ideal situation but I can definitely make it work!
Thanks again for your help!

can you please send me the updated code which is working as i am stuck with the same problem
thanks


Import typed artifacts for AirseekerRegistry contract

Blocked by https://github.com/api3dao/dapi-management/issues/25

No longer blocked


WASM Reflection.MethodBase is missing

It would seem that the mscorlib that ships with mono's wasm support is missing the older reflection types.

Could not resolve type with token 0100000a from typeref (expected class 'System.Reflection.MethodBase' in assembly 'Csla, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=93be5fdc093e4c30')

[Error] Error: System.TypeInitializationException: The type initializer for 'Ooui.Wasm.Test.Person' threw an exception. ---> System.TypeLoadException: Could not resolve type with token 0100000a from typeref (expected class 'System.Reflection.MethodBase' in assembly 'Csla, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=93be5fdc093e4c30')
   --- End of inner exception stack trace ---
  at Ooui.Wasm.Test.Program.GetButtonElement () <0x772238 + 0x00014> in <42312de6b379496da5205cd71073e56e>:0
  at Ooui.Wasm.Test.Program.Main () <0x1996a40 + 0x00002> in <42312de6b379496da5205cd71073e56e>:0
	runApp (ooui.js:441)
	init (ooui.js:423)
	init (ooui.js:381)
	bclLoadingDone (ooui.js:363)
	(anonymous function) (ooui.js:356)
	promiseReactionJob

I am encountering this issue when using CSLA .NET. The latest pre-release in NuGet supports Xamarin Forms via netstandard 2.0, and so it seems like it should work.
I followed the steps in this blog post to get a webassembly XF project working in VS, hosted via python in WSL (though the host shouldn't matter).
Then I added a reference to the CSLA .NET pre-release via NuGet (the CSLA-Core.NS package).
Then I added a Person.cs class to the project that uses CSLA:
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Text;
using Csla;

namespace MyFormsApp
{
    [Serializable]
    public class Person : BusinessBase<Person>
    {
      public static readonly PropertyInfo<string> NameProperty = RegisterProperty<string>(c => c.Name);
      public string Name
      {
        get { return GetProperty(NameProperty); }
        set { SetProperty(NameProperty, value); }
      }

      protected override void DataPortal_Create()
      {
        using (BypassPropertyChecks)
        {
          Name = "Teresa";
        }
      }
    }
  }

In Program.cs I try to create an instance of this type:
  var obj = new Person();

At this point the code won't build properly.
1>C:\Users\rocky\.nuget\packages\ooui.wasm\0.8.186\build\netstandard2.0\Ooui.Wasm.targets(17,3): error : Error processing method: 'System.Void MyFormsApp.Person::.cctor()' in assembly: 'MyFormsApp.dll'
1>Done building project "MyFormsApp.csproj" -- FAILED.

I was able to expose the actual error:
[Error] Error: System.TypeInitializationException: The type initializer for 'Ooui.Wasm.Test.Person' threw an exception. ---> System.TypeLoadException: Could not resolve type with token 0100000a from typeref (expected class 'System.Reflection.MethodBase' in assembly 'Csla, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=93be5fdc093e4c30')
   --- End of inner exception stack trace ---
  at Ooui.Wasm.Test.Program.GetButtonElement () <0x772238 + 0x00014> in <42312de6b379496da5205cd71073e56e>:0
  at Ooui.Wasm.Test.Program.Main () <0x1996a40 + 0x00002> in <42312de6b379496da5205cd71073e56e>:0
	runApp (ooui.js:441)
	init (ooui.js:423)
	init (ooui.js:381)
	bclLoadingDone (ooui.js:363)
	(anonymous function) (ooui.js:356)
	promiseReactionJob

Not sure why that type is missing. Still investigating...

I think I know what's going on. The mono wasm I'm using is built against the old Silverlight profile which uses TypeInfo instead of Type - that is it's a .NET Standard 1.X profile.

Could the old Silverlight profile also be the source of the issues seen in #98 where HttpClient and async/await in general trigger errors due to the Task<T> type being missing?
1>C:\Users\...\.nuget\packages\ooui.wasm\0.9.206\build\netstandard2.0\Ooui.Wasm.targets(17,3): warning : Failed to resolve type System.Threading.Tasks.Task`1
1>C:\Users\...\.nuget\packages\ooui.wasm\0.9.206\build\netstandard2.0\Ooui.Wasm.targets(17,3): warning : Failed to resolve method System.Threading.Tasks.Task System.Threading.Tasks.Task`1<System.Net.Http.HttpResponseMessage>::ContinueWith(System.Action`1<System.Threading.Tasks.Task`1<!0>>)

@DanielRRegner That was my original theory, but it's in doubt as the assemblies do seem to contain the types.
I was told to try these logging levels:
setenv MONO_LOG_MASK=type
MONO_LOG_LEVEL=debug
MONO_LOG_MASK=asm

Any movement on this issue?

I think about it all the time? :-) Sorry for the delays, I need a day to study what the linker is doing with those assemblies. The mono people are pretty sure the problem is on my end. I’ll try to look into it this weekend.

Thank you Frank, I appreciate it! I suspect it is on your end, as I've been able to get CSLA working in Blazor with a few tweaks (relative to System.Linq.Expressions and HttpClient limitations).

Could it be the case where although the types are present, they are being referenced from the wrong assembly?
For example, with the System.Activator type, displaying typeof(Activator).FullName works, and in the IL, I see that the type is being referenced from System.Runtime.dll, which has a TypeForwardedToAttribute back to mscorlib.dll.
But when using types that fail to resolve such as System.Reflection.MethodBase or System.Threading.Tasks.Task, those are also being referenced from System.Runtime.dll without any matching  TypeForwardedToAttribute back to mscorlib.dll where they really reside.

@DanielRRegner Yes I believe mono is missing some forwarders. I have worked around it in the linker and filed a bug over at mono.

I have worked around this in https://github.com/praeclarum/Ooui/commit/0877dfb7df7960af3872d03c2aef0717ac0e78be
The CSLA example now works.


Add mean encoder implementation to KBinsDiscretizer

Reference Issues/PRs
issue reference: #7
parent PR: #1
What does this implement/fix? Explain your changes.
find the mean value in each bin after KBinsDiscretizer allocates each entry to a specific bin.


Added parameter to disable forced floating, #436

Hey there, as already discussed in #277 I would find it useful to disable the default behaviour which is forcing a floating banner on mobile devices. By default the current behaviour is preserved but it's now at least possible to adjust it via parameter.

PR to dev as requested @relicmelex, original PR #436 as a back reference. Also changed forceFloat parameter name to mobileForceFloat.

@thexmanxyz Thank you. This is going into Dev and will be tagged when we make a release. It may not find it's way into the official docs right away though. I will link though to try and keep up to date
#568

@relicmelex You are welcome. Alright! I'm not expecting that this goes right away into the docs. Thanks for merge!


Traefik setting Accept-Encoding: gzip on requests (Traefik may also be broken with chunked responses)

Setup:

traefik beta794 prebuilt amd64
nginx HTTP backend configured with file

For some reason, it looks like traefik is adding Accept-Encoding: gzip to the requests, which causes nginx to send back a chunked gzip response, which results in a 0 length 0 content-length response to the client. If I disable gzip on nginx, everything seems to work fine.
I've verified with packet caps that my client isn't setting the Accept-Encoding header, and that nginx is responding properly to the request.

Maybe due to https://github.com/containous/oxy/commit/183212964e13e7b8afe01a08b193d04300554a68. I need to investigate on this.

I suspect that this is due to a regression that occurred in v1.0.0-beta.754 #398.
Could you test using v1.0.0-beta.744 instead? I cannot reproduce this issue on my laptop.


MA - opportunity statement for opportunity #2

work with George to finalize the text

On hold until we have a viable second opportunity


Implement remote driver

Implementation of drivers/remote using the plugins.Client to do RPCs with the remote process.
Developed in conjunction with the prototypical https://github.com/squaremo/weave/tree/plugin_ipam, and using adaptations in https://github.com/squaremo/docker/tree/network_extensions to try it out (that fork has this branch vendored-in).
TODO

[x] Tests
[x] go lint, be it forever cursed
[x] Depends on #159 for now; I'll rebase on master when that's merged.
[x] Update to #152 view of drivers

Thanks @squaremo for the quick turn around.
In addition to #159, you must also be aware of #152 which changes some of the Driver APIs.
Also, golint is failing ;-)

In addition to #159, you must also be aware of #152 which changes some of the Driver APIs.

Yes; I don't know quite what to make of #152, to be honest. It seems to introduce complication for the sake of complication. In any case, it will make this work much more involved, which is a shame.

@squaremo Can you pls rebase ?

@squaremo now that https://github.com/docker/docker/pull/13222, #159 & #152 are merged, can you please edit the PR description ?
Also ping @shettyg @mapuri @tomdee @rajatchopra @mrunalp who has shown interest in this work.
With #168 , we have an independent tool (dnet) which can be used in complete isolation to test the networking functionality (including the remote driver) end-to-end. We can continue to use this tool even after integration with Docker is also complete.

Reworked to account for #152, and rebased.

Is there a expectation for libnetwork to work on Windows? If so, why are we using unix domain sockets? Why not a local TCP and use REST APIs?

@shettyg The transport is up to the plugin system, which I think does support TCP (but maybe it's disabled because security?). The remote drivers just use whatever the plugin system gives them.
Why not ReST? Again, this is down to the plugin system, which is oriented around RPC. But it's not inappropriate here, since the operations are a mix of create/delete and other performatives (Join/Leave).

@shettyg the plugins system does support TCP. Please take a look @ https://github.com/docker/libnetwork/blob/master/libnetwork_test.go#L1201
I tend to agree on the RPC as well. Plugins are extensions and would prefer a RPC as well.

@mrjana, how's the last commit?

@squaremo Looks good.

Rebased and squished and signed.

@squaremo Please fix all the error strings to start with lower case and other than that this is LGTM

Please fix all the error strings to start with lower case

Sorted.

:+1: LGTM

LGTM

@squaremo Thanks for handling the comments.
LGTM


[SPARK-24685][BUILD][FOLLOWUP] Fix the nonexist profile name in release script

What changes were proposed in this pull request?
without-hadoop profile doesn't exist in Maven, instead the name should be hadoop-provided, this is a regression introduced by SPARK-24685. So here fix it.
How was this patch tested?
Local test.

@cloud-fan @vanzin , please help to review, thanks!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3136/
Test PASSed.

Test build #96107 has started for PR 22434 at commit 18a9135.

LGTM

Test build #96107 has finished for PR 22434 at commit 18a9135.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96107/
Test PASSed.


Add variable grafana_ingress_host to expose Grafana

Fixes: https://github.com/kinvolk/lokomotive/issues/456

TestAWSIngress: aws_test.go:49: got an HTTP error: Get "https://httpbin.ci1590498787-sj.test.lokomotive-k8s.net/get": dial tcp <IP_ADDRESS>:443: connect: connection refused
    TestAWSIngress: aws_test.go:67: could not get a successful HTTP response in time

So it was decided in a meeting that we create block for grafana like this:
component "prometheus-operator" {
...
  grafana {
    admin_password = ""

    ingress {
      host = ""

      # In future
      ingress_class = ""
      certmanager_cluster_issuer = ""
    }
  }
}

Overall LGTM, but I don't understand, why do we remove Grafana admin password. @surajssd please add some explanation to it, so we can discuss it.

Grafana admin password should not be a compulsory option. If not provided the chart automatically creates one for you, just like Rook Ceph.

Grafana admin password should not be a compulsory option. If not provided the chart automatically creates one for you, just like Rook Ceph.

Hm, okay. I think we should have a bit more documentation how to obtain this password then, so it is not so cryptic to the users.

Hm, okay. I think we should have a bit more documentation how to obtain this password then, so it is not so cryptic to the users.

That I plan to handle as a part of https://github.com/kinvolk/lokomotive/pull/480

I wonder if it makes sense to allow exposing grafana and allow having an insecure default password so easily. So if a user does
  grafana {
    ingress {
      host                       = "grafana.mydomain.net"
      class                      = "contour"
      certmanager_cluster_issuer = "letsencrypt-production"
    }
  }

and this exposes grafana with admin:admin password, this is surprising and insecure. Should we do something about it?

I wonder if it makes sense to allow exposing grafana and allow having an insecure default password so easily.

@iaguis there is a default password but it is not admin. The password if not specified is generated by helm automatically and stored in a secret, as mentioned in the docs.

@iaguis there is a default password but it is not admin. The password if not specified is generated by helm automatically and stored in a secret, as mentioned in the docs.

Ah, all good then :+1:

How about something like this?
diff --git a/pkg/components/prometheus-operator/component.go b/pkg/components/prometheus-operator/component.go
index b3791da3..137b997f 100644
--- a/pkg/components/prometheus-operator/component.go
+++ b/pkg/components/prometheus-operator/component.go
@@ -123,7 +123,6 @@ func newComponent() *component {
                                "tier":    "control-plane",
                        },
                },
-               Grafana: &Grafana{},
        }
 }

diff --git a/pkg/components/prometheus-operator/component_test.go b/pkg/components/prometheus-operator/component_test.go
index 8e2608fb..b0b6cd39 100644
--- a/pkg/components/prometheus-operator/component_test.go
+++ b/pkg/components/prometheus-operator/component_test.go
@@ -26,18 +26,25 @@ func TestEmptyConfig(t *testing.T) {
        c := newComponent()
        emptyConfig := hcl.EmptyBody()
        evalContext := hcl.EvalContext{}
-       diagnostics := c.LoadConfig(&emptyConfig, &evalContext)

-       if diagnostics.HasErrors() {
+       if d := c.LoadConfig(&emptyConfig, &evalContext); d.HasErrors() {
                t.Fatalf("Empty config should not return errors")
        }
+
+       m, err := c.RenderManifests()
+       if err != nil {
+               t.Fatalf("Rendering manifests with valid config should succeed, got: %s", err)
+       }
+       if len(m) <= 0 {
+               t.Fatalf("Rendered manifests shouldn't be empty")
+       }
 }

 func TestRenderManifest(t *testing.T) {
        configHCL := `
 component "prometheus-operator" {
   grafana {
-       admin_password = "foobar"
+    admin_password = "foobar"
   }
   namespace = "monitoring"
 }
diff --git a/pkg/components/prometheus-operator/template.go b/pkg/components/prometheus-operator/template.go
index 3a96fe0f..7089874c 100644
--- a/pkg/components/prometheus-operator/template.go
+++ b/pkg/components/prometheus-operator/template.go
@@ -48,7 +48,6 @@ alertmanager:
               storage: "{{.AlertManagerStorageSize}}"

 grafana:
-  adminPassword: {{.Grafana.AdminPassword}}
   plugins: "grafana-piechart-panel"
   testFramework:
     enabled: false
@@ -57,6 +56,8 @@ grafana:
       searchNamespace: ALL
   rbac:
     pspUseAppArmor: false
+  {{- if .Grafana}}
+  adminPassword: {{.Grafana.AdminPassword}}
   {{ if .Grafana.Ingress }}
   ingress:
     enabled: true
@@ -71,6 +72,7 @@ grafana:
       - {{ .Grafana.Ingress.Host }}
       secretName: {{ .Grafana.Ingress.Host }}-tls
   {{ end }}
+  {{- end}}

 kubeEtcd:
   enabled: {{.Monitor.Etcd}}

@invidian PTAL, added table driven tests. Also taken care of the test that fails.

LGTM. One last thing which can be done independently of this patch, I guess we should test if exposing ingress works as expected via e2e test?

Testing on packet can be tricky because:

Someone has to expose the EIP on Route53.
How do we use unique EIP per CI run? And make corresponding entries?

The testing can be done on any platform. But should be done at at least one.


[NEW BONUS GUIDE]  Amboss.space heartbeat pings without Thunderhub

What
Easy to use script to send heartbeat pings to the amboss.space monitoring service
Why
After that recent announcement from amboss.space, people started questioning the need for Thunderhub. If TH is not available, the only remaining option is a "manual" ping to be sent to the amboss monitoring service.
How
Simple bash script executed on predefined intervals via cronjob.
Scope

[ ] significant change to core configuration
[x] independent bonus guide
[ ] simple bug fix

Fixes # (link issue)
Test & maintenance
Following the instructions, check if the status in the amboss health dashboard is being updated. One should disable the Thunderhub pings if they are activated from there.
Animated GIF (optional)
n/a

If not enable channel balance sending info in ThunderHub, ThunderHub does not send this info to Amboss by default. We shouldn't worry about this, this works the same as health checks and backups options, so I think is not a privacy risk to the RaspiBolt nodes
Don't trust, verify: https://github.com/apotdevin/thunderhub/blob/master/src/client/src/views/amboss/Balances.tsx#L26-L30

Can confirm what you say. Checked with my installation of 0.13.16.
On the other hand, though, I found reporting via the script way more reliable than TH. Used this script for the recent weeks and the false-positives in the reporting fell by 90% at least. From ~10x10min reported outages per day in the past (while my nod is actually routing) I fell to 1-2 a week.

This is not necessary. If you do not enable the sending of channel balance information in ThunderHub, ThunderHub does not send this information to Amboss by default. We shouldn't worry about this, it works the same as the health check and backup options, so I think it's not a privacy risk for the RaspiBolt nodes if we don't enable it.
https://github.com/apotdevin/thunderhub/blob/master/src/client/src/views/boss/Balances.tsx#L26-L30
Maybe we could add a notice in the Thunderhub extras section: https://raspibolt.org/guide/bonus/lightning/thunderhub.html#extras

Ok, the "why" become a bit misleading, but the point of this at the end is still to provide the ability to use the hatcheck status without TH.

Can confirm what you say. Checked with my installation of 0.13.16. On the other hand, though, I found reporting via the script way more reliable than TH. Used this script for the recent weeks and the false-positives in the reporting fell by 90% at least. From ~10x10min reported outages per day in the past (while my nod is actually routing) I fell to 1-2 a week.

I agree with you, I usually get a lot of false-positives with Thunderhub -> Amboss health check method.
I'll try to leave you a review. First I think I can see, is it necessary to create a unique user for this use? In other similar guides, this step was not included
refs: https://raspibolt.org/guide/lightning/channel-backup.html
https://raspibolt.org/guide/bonus/lightning/lntop.html

I consider it more cleaner approach. If we set up a user, it is way easier to uninstall by only deleting the user. We basically set the files and the cron in the user, so therefore no leftovers after the “uninstallation”.

I think the Thunderhub -> Amboss method issue may be due to issues with Tor, as we have this line configured for the Thunderhub config:
TOR_PROXY_SERVER=socks://<IP_ADDRESS>:9050
It usually fails me at the time I've had problems with Tor.
BTW: Is Tor used in this guide for the communication of our node with Amboss?

Ok, the "why" become a bit misleading, but the point of this at the end is still to provide the ability to use the hatcheck status without TH.

Good point.. as I don't use ThunderHub, I was not even aware that there was such a thing as a Amboss monitoring service.. this is definitely a useful bonus guide 💯

ACK


[Bug]: EEXIST: file already exist

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Something went wrong: Error: EEXIST: file already exists, mkdir 'c:\Users\mulya\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vscode-vibrancy-runtime-v6'
Expected Behavior
No response
Steps To Reproduce
No response
Environment
- OS:Windows 11
- VSCode:1.73.1
- Extension: 1.1.9

Anything else?

this happens when i reload vibrancy. Do you know how to solve this?

Hi. Haven't seen this error before, Vibrancy is supposed to delete the existing runtime folder before copying the newest version upon running the reload action, but in your case the folder wasn't deleted for some reason. Perhaps it's a permission issue, though it should've generated a different error if that's the case.
Could you please try going to c:\Users\mulya\AppData\Local\Programs\Microsoft VS Code\resources\app\out and deleting the vscode-vibrancy-runtime-v6 folder manually, then trying the Reload Vibrancy action again?

I'm seeing this error as well. I tried deleting the folder manually and reloading results in the same error.

Hi. Haven't seen this error before, Vibrancy is supposed to delete the existing runtime folder before copying the newest version upon running the reload action, but in your case the folder wasn't deleted for some reason. Perhaps it's a permission issue, though it should've generated a different error if that's the case.
Could you please try going to c:\Users\mulya\AppData\Local\Programs\Microsoft VS Code\resources\app\out and deleting the vscode-vibrancy-runtime-v6 folder manually, then trying the Reload Vibrancy action again?

Thank you illixion. It worked

你好。以前没有看到此错误，Vibrancy 应该在运行重新加载操作时复制最新版本之前删除现有的运行时文件夹，但在您的情况下，由于某种原因该文件夹未被删除。也许这是一个权限问题，尽管如果是这种情况，它应该会产生不同的错误。
您能否尝试手动删除文件夹，然后再次尝试重新加载活力操作？c:\Users\mulya\AppData\Local\Programs\Microsoft VS Code\resources\app\out``vscode-vibrancy-runtime-v6

This is a bug of the new version. This bug will reappear every time the configuration is modified. My Environment is the same as the publisher of this issue.

Hi. Haven't seen this error before, Vibrancy is supposed to delete the existing runtime folder before copying the newest version upon running the reload action, but in your case the folder wasn't deleted for some reason. Perhaps it's a permission issue, though it should've generated a different error if that's the case.
Could you please try going to c:\Users\mulya\AppData\Local\Programs\Microsoft VS Code\resources\app\out and deleting the vscode-vibrancy-runtime-v6 folder manually, then trying the Reload Vibrancy action again?

This is a bug of the new version. This bug will reappear every time the configuration is modified. My Environment is the same as the publisher of this issue.

Took a bit longer than expected, but I just pushed a fix in v1.1.12 that should resolve this, let me know if you still encounter any issues.


Visual Studio 2013 Build Errors

Hey jpd002,
Unsure if you are even still working on this server, but I am following your instructions to install the server and am encountering a number of build errors when i attempt to do so in Visual Studio 2013.
Is there something that i need to do prior to building the solution that could have been missed? All projects load without issue when opening the solution, but attempting to build is where the issues arise.

What's the error you're getting?

Theres a lot of them. heres a few off the error log. for some reason GitHub wont let me upload an xlsx file.
Error	1	error C2061: syntax error : identifier 'int64'	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	20	1	Framework
Error	2	error C2146: syntax error : missing ';' before identifier 'Tell'	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	21	1	Framework
Error	3	error C2433: 'Framework::CStream::uint64' : 'virtual' not permitted on data declarations	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	21	1	Framework
Error	4	error C4430: missing type specifier - int assumed. Note: C++ does not support default-int	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	21	1	Framework
Warning	5	warning C4183: 'Tell': missing return type; assumed to be a member function returning 'int'	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	21	1	Framework
Error	6	error C2146: syntax error : missing ';' before identifier 'Read'	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	22	1	Framework
Error	7	error C2433: 'Framework::CStream::uint64' : 'virtual' not permitted on data declarations	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	22	1	Framework
Error	8	error C4430: missing type specifier - int assumed. Note: C++ does not support default-int	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	22	1	Framework
Error	9	error C2061: syntax error : identifier 'uint64'	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	22	1	Framework
Warning	10	warning C4183: 'Read': missing return type; assumed to be a member function returning 'int'	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	22	1	Framework
Error	11	error C2146: syntax error : missing ';' before identifier 'Write'	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	23	1	Framework
Error	12	error C2433: 'Framework::CStream::uint64' : 'virtual' not permitted on data declarations	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	23	1	Framework
Error	13	error C4430: missing type specifier - int assumed. Note: C++ does not support default-int	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	23	1	Framework
Error	14	error C2061: syntax error : identifier 'uint64'	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	23	1	Framework
Warning	15	warning C4183: 'Write': missing return type; assumed to be a member function returning 'int'	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	23	1	Framework
Error	16	error C2146: syntax error : missing ';' before identifier 'GetLength'	c:\users\chris\downloads\server\seventh umbral\framework\include\stream.h	26	1	Framework

I've made some changes to the projects to make it a bit simpler to setup the build environment. All you should need is to make sure your projects are organized in that matter:
C:\Projects

Dependencies
Framework
Palleon
SeventhUmbral

You will also need some external libraries to get everything to compile:

MySQL connector (https://dev.mysql.com/downloads/connector/c/)
TDEmu (http://www.korosoft.net/projects/tdemu/)

I've tried compiling myself and everything should work using the HEAD of each repository. From the errors you're getting, seems like Types.h isn't included properly. uint64 and int64 are defined in there. Don't hesitate to ask if you've got more questions.

Thanks for the help.
I will give this a shot when I have a moment. I think i may be missing TDEmu, thanks again, I will let you know how i fare.

If at all possible could we set up a webex session at some point to just have you take a look at my current set up to see if it is something minor that is causing my headaches?
I have the MySQL connector installed and i believe to have TDEmu as well.
I made sure Types.h was set to include. Build errors still occur, possibly if you can see it personally you may just be able to slap me in the face and see what i did wrong.
Let me know, thanks!

Hi @Caladius , have you managed to create the server? Can you tell me they are the steps to do to build because we can not say that explicitly tutorial is written on the site. Thank you to you for your future response .

@AlexandreCA If you give me information about the build errors you're getting, I can guide you to potential solutions.
@Caladius Sorry, I'm quite busy, I'm not really available for a web conference session. Are you getting the same build errors?

@jpd002 If I understand well because it is not long since I discovered your site. I have Visual Studio compiles with all the tools you offer ? I use Visual Studio 2015 for another project. A problem with this version ?

@AlexandreCA Your directory names don't seem to match what I've described in my post above. Except for the "Projects" folder, every folder needs to be named the same way (ie.: "Dependencies", "Framework", "Palleon" and "SeventhUmbral"). This is needed because the path names inside the projects refer to those names.

Ok! I 'm as in the example above but the problem remains the same . Here is a copy of the error
C:\Projects\Framework\build_win32\FrameworkMySql.vcxproj

@jpd002 Ok! I 'm as in the example above but the problem remains the same . I found her : https://github.com/jpd002/Play-Dependencies
But despite this, its not solves my problem . Here is a copy of the error
C:\Projects\Framework\build_win32\FrameworkMySql.vcxproj : error : Unable to read the project file "FrameworkMySql.vcxproj".
C:\Projects\Framework\build_win32\GeneralSettingsMySql.props(5,5): The imported project "C:\Projects\Framework\build_win32\ExternalDependenciesMySql.userprops" was not found. Confirm that the path in the declaration is correct, and that the file exists on disk.
Just Palleon is OK!
As long as I do not understand how to meet its dependencies , I can not compile the server.

Oh yeah, I forgot about a few steps:
The Framework\build_win32\ExternalDependenciesMySql.userprops.template file has to be copied and renamed to ExternalDependenciesMySql.userprops.
Then edit the ExternalDependenciesMySql.userprops file and set the value of the MYSQL_PATH variable (initially set to path_to\mysqlclient-5.6) to the path of your MySQL Connector installation path (ex.: on my side it's set to D:\Components\mysql-connector-c-6.1.1-win32).

@jpd002 Ok its works but not 100% . It gives me an error for ExternalDependenciesOpenAl.userprops.template file I renamed ExternalDependenciesOpenAl.userprops . The VS is able to read it but it gives me an error
Error C1083 Unable to open include file : ' al.h ' : No such file or directory FrameworkOpenAl c: \ projects \ framework \ include \ openal \ openaldef.h 5

The OpenAL error can be ignored since it's not used by the SeventhUmbral solution.
For the mysql.h error, there's also an ExternalDependencies.userprops file in the SeventhUmbral\build_win32 that needs to be modified to refer to the path where you installed the MySQL connector.

@jpd002 I had already discovered her but the problem remains the same

Humm, you could try quoting your path since there are spaces in it. Not sure MSBuild is smart enough to deal with this automatically.

@jpd002 Spaces relatives to MySQL Connector C 6.1?
Maybe that like her , it is better? C:\ProgramFiles\MySQL\MySQLConnectorC6.1

@jpd002 Quick Question: i have eliminated much of build errors now. the only one remaining is the "zlib-1.2.8 (load failed)" issue. when trying to reload the project i receive an error:
The project file
'H:Download\Server\Dependencies\build_win32\zlib-1.2.8.vcxproj'
has been moved, renamed or is not on your computer.
i redownloaded and checked the master files and could not find any instance of that file. I have zlib-1.2.8 in my dependencies folder but theres no vcxproj file included either.

Humm, the file should be there: https://github.com/jpd002/Play-Dependencies/tree/master/build_win32. Maybe your branch is still out of date?

It may have been possible. redownloading the files from the link you provided resolved that. the last error i am facing is:
LNK1104 - cannot open file 'libbost_filesystem-vc140-mt-gd-1_60.lib
upon searching the NuGet Packages folder that was created upon my build attempts i noticed version 1.59 was downloaded. I downloaded Boost 1.60 to attempt to resolve but it does not contain the libboost file needed. (hopefully this is the last piece of help ill need. I am so close to the end)
Thank you for your patience and extreme knowledge input with this rather lengthy issue.

That's actually my bad. I've updated the project files to download the proper NuGet packages.

Thanks for the update, that resolved the boost issues but opened some other errors. I included them below in a screenshot.

@jpd002 Upon some deeper investigation with a friend of mine we are unsure of what result the "operator" is trying to receive. (we think it may be receiving a response that it does not like)
@jpd002 and @AlexandreCA
Below is where we traced the issue to, do either of you know what this means?:

Thanks!

Hey,
Closing this out. I figured out what triggered the issue. Thanks again, the server now runs perfectly!  Great job with it so far.

Awesome, glad you got it to work! Even though I haven't done any change to the server in a while, I'm still open to PRs and suggestions.

Thats my plan! Once I get in there and figure out what I'm doing I want to be able to submit updates to help you out as well.


Activate GitHub Pages on managed-identity-wallet

It would be great if you could active GitHub Pages in the managed-identity-wallet repository. We would like to use the pages as Helm Chart repository, as it is already done in other Tractus-X projects. The target branch would be gh-pages.

Hi @DominikPinsel! Changes are done, please confirm it's working. Committers in your team can also make changes to your eclipse-tractusx repositories using Otterdog like in this pull request: https://github.com/eclipse-tractusx/.eclipsefdn/pull/41

@DominikPinsel  FYI pages are enabled and will close this issue.


New version: LibCEED v0.3.0

Registering package: LibCEED
Repository: https://github.com/CEED/libCEED
Created by: @jedbrown
Version: v0.3.0
Commit: 1e73a9ca8d7981fa1085fefebe51a2438a0776fd
Reviewed by: @jedbrown
Reference: https://github.com/CEED/libCEED/commit/1e73a9ca8d7981fa1085fefebe51a2438a0776fd#commitcomment-131664773
Description: CEED Library: Code for Efficient Extensible Discretizations

Thanks @giordano. Can this PR be updated to use the new bounds or must it be closed and a new one created?

Register again keeping the same version number and this PR will be automatically updated
[noblock]


crowdsec.service: Found dependency on dnsmasq.service/start

Hi,
I have a conflict with crowdsec-firewall-bouncer and dnsmasq.service ordering cycle.
When i comment the before on systemd unit all work again
systemd[1]: crowdsec.service: Found ordering cycle on nss-lookup.target/start
systemd[1]: crowdsec.service: Found dependency on dnsmasq.service/start
$/etc/systemd/system/crowdsec-firewall-bouncer.service
[Unit]
Description=The firewall bouncer for CrowdSec
After=syslog.target network.target remote-fs.target nss-lookup.target crowdsec.service
#Before=netfilter-persistent.service

duplicate https://github.com/crowdsecurity/cs-firewall-bouncer/issues/212


[PT Run] Websearch: Error shows default browser and description can be improved

Description of the new feature / enhancement
The error message shows "default browser" every time. This should be changed to the browser name if known.
The plugin description should say that it searches in the default browser with the default engine (and not in PT Run).

The was fixed in in 0.53.  Head over to https://aka.ms/installpowertoys to try it out


New Rails 8 applications generate duplicate CI files

Relates to #1213
We create files that end in .yaml, and Rails created files that end in .yml
https://github.com/thoughtbot/suspenders/blob/bad1d016796223729d713d06261dd722c5dae56f/lib/generators/suspenders/ci_generator.rb#L17-L18

I think we can rely on the dependabot.yml file generated by Rails, but need to replace the ci.yml file generated by Rails.

Oh yeah, weird. I thought I always used the longer form, but I seem to use the three letter variant.
I also prefer to use either main.yml or tests.yml instead of ci.yml for the name. My thinking here is that "CI" is meaningless in this context, all the files are "CI" as we've come to understand that term.
Then I'll have different files so that we break out the feedback you get on the GitHub statuses view:

tests
linting
bundle audit
etc

We could call --skip-ci when running rails new to make it simpler for use to maintain these files.

I also prefer to use either main.yml or tests.yml instead of ci.yml for the name. My thinking here is that "CI" is meaningless in this context, all the files are "CI" as we've come to understand that term.
Then I'll have different files so that we break out the feedback you get on the GitHub statuses view:

It looks like having one file will still break out each task into its own status. Below is a screenshot from a personal project that is using the stock CI file from Rails.

Yeah, I'd expect it break things out like that. Much of my intention from breaking out the files is to not have horribly long YAML files which are tricky to understand.


add sender attributes

ticket 3526
added SenderType enum class
This PR modifies the Sender Class by adding a SenderType enumeration.  The SenderType provides additional data about the type of sender who is sending the data.
Pull reviewers stats
Stats for the last 30 days:

User
Total reviews
Median time to review
Total comments

MauriceReeves-usds
56
1h 25m
27

carlosfelix2
25
13h 59m
64

jimduff-usds
19
15h 48m
19

cwinters-usds
19
3h 47m
8

TomNUSDS
16
1h 26m
46

ahay-agile6
14
3h 2m
7

whytheplatypus
13
1h 59m
29

oslynn
12
1h 3m
5

jbiskie
9
52m
0

kevinhaube
7
1h 25m
0

jorg3lopez
7
1h 21m
5

brick-green-agile6
6
16h 35m
2

JosiahSiegel
5
17m
2

meckila
5
2h 38m
9

rhood23699
5
47m
0

bgantick
4
2h 23m
3

sethdarragile6
4
1h 23m
0

TurkeyFried
2
21h 48m
1

RickHawesUSDS
2
2h 45m
0

jeremy-page
2
8m
0

acoushawk
1
16h 10m
0

clediggins-usds
1
17h 4m
1

snesm
1
16m
0

this PR is one of many for #3526 - the last PR 4700 should finalize what this and other PRs attempted.  Closing this PR


[Release] Bumped datadog_checks_base version to 25.6.0

What does this PR do?
Release the base check
Motivation
support case
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

closing due to the signatures being out of date


Update team

@conda-forge-admin, please update team

@conda-forge-admin, please update team

@conda-forge-admin, please update team

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I updated the team with maintainers from master.


How to increase output resolution?

How to increase the resolution of the output images?

@MateSteinforth : The size of the output image is fixed to be the size of the input size to the CNNs (e.g. 227x227 for AlexNet, or 224x224 for GoogLeNet).
You could try either of the following:

Train new networks that can handle larger image sizes
Create a large canvas and optimize fixed chunks of 227x227 (e.g. like Google's DeepDream)


[opencv4] Building package opencv4:x64-windows failed

Host Environment

OS: [Windows.10]
Compiler: revision

To Reproduce
Steps to reproduce the behavior:
.\vcpkg install darknet[full]:x64-windows
Failure logs
-- Using cached G:/vcpkg/downloads/opencv-cache/xfeatures2d/boostdesc/0ae0675534aa318d9668f2a179c2a052-boostdesc_lbgm.i
-- Using cached G:/vcpkg/downloads/opencv-cache/xfeatures2d/vgg/e8d0dcd54d1bcfdc29203d011a797179-vgg_generated_48.i
-- Using cached G:/vcpkg/downloads/opencv-cache/xfeatures2d/vgg/7126a5d9a8884ebca5aea5d63d677225-vgg_generated_64.i
-- Using cached G:/vcpkg/downloads/opencv-cache/xfeatures2d/vgg/7cd47228edec52b6d82f46511af325c5-vgg_generated_80.i
-- Using cached G:/vcpkg/downloads/opencv-cache/xfeatures2d/vgg/151805e03568c9f490a5e3a872777b75-vgg_generated_120.i
-- Using cached G:/vcpkg/downloads/opencv-cache/data/7505c44ca4eb54b4ab1e4777cb96ac05-face_landmark_model.dat
-- Configuring x64-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
Command failed: ninja -v
Working Directory: G:/vcpkg/buildtrees/opencv4/x64-windows-rel/vcpkg-parallel-configure
Error code: 1
See logs for more information:
G:\vcpkg\buildtrees\opencv4\config-x64-windows-out.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_configure_cmake.cmake:300 (vcpkg_execute_required_process)
ports/opencv4/portfile.cmake:282 (vcpkg_configure_cmake)
scripts/ports.cmake:79 (include)
Error: Building package opencv4:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: opencv4:x64-windows
Vcpkg version: 2020.06.15-nohash
Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.

cc @cenit

Please provide failure log G:\vcpkg\buildtrees\opencv4\config-x64-windows-out.log.

config-x64-windows-out.log

CMake Error at modules/videoio/cmake/init.cmake:12 (set_target_properties):
  Property INTERFACE_LINK_LIBRARIES may not contain link-type keyword
  "optimized".  The INTERFACE_LINK_LIBRARIES property may contain
  configuration-sensitive generator-expressions which may be used to specify
  per-configuration rules.

It looks like ffmpeg module is outputting libraries with the optimized/debug keywords, while they are expected with the generator expression syntax?
Maybe a recent PR modified it?
I will look into it...
@chrisgame1002 please also do a git pull to update your vcpkg. Since from the logs CUDA 10.0 is detected and allowed, it means that your vcpkg is not up to date (minimum required now is 10.1)

I can confirm that FFMPEG has been broken in a recent PR (my usual rant about port damaging might be applied also here).
Since ffmpeg feature is optional in opencv, CI didn't catch it when it happened.
If you try to build opencv[ffmpeg] you will experience it @JackBoosY
I am opening a PR with a suggested fix.

@cenit I already git pull to update my vcpkg,but also have same problem

Same problem.

@cenit , Hi again..
I downgraded CUDA to 10.2 and python to 3.7
It failed with
**Command failed: ninja -v**

-- Configuring x64-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
    Command failed: ninja -v
    Working Directory: D:/Development_work/vcpkg/buildtrees/opencv4/x64-windows-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      D:\Development_work\vcpkg\buildtrees\opencv4\config-x64-windows-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_cmake.cmake:300 (vcpkg_execute_required_process)
  ports/opencv4/portfile.cmake:282 (vcpkg_configure_cmake)
  scripts/ports.cmake:79 (include)

Error: Building package opencv4:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: opencv4:x64-windows
  Vcpkg version: 2020.06.15-nohash

Complete logs here:
config-x64-windows-out.log
I thgt downgrading CUDA (as suggested by you here ) would solve build issues .
Many thanks for your great stuff..

When I add feature ffmpeg:
Building package opencv4[contrib,core,cuda,dnn,eigen,ffmpeg,jasper,jpeg,openexr,opengl,openmp,png,sfm,tiff,webp]:x64-windows...
It also fails at
-- Configuring x64-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
Command failed: ninja -v
Working Directory: D:/vcpkg/buildtrees/opencv4/x64-windows-rel/vcpkg-parallel-configure
Error code: 1
See logs for more information:
D:\vcpkg\buildtrees\opencv4\config-x64-windows-out.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_configure_cmake.cmake:300 (vcpkg_execute_required_process)
ports/opencv4/portfile.cmake:282 (vcpkg_configure_cmake)
scripts/ports.cmake:79 (include)
The log file
config-x64-windows-out.log

^ as you can see above in the linked PR ([ffmpeg] fix cmake module #13004), I have already submitted a fix for this FFMPEG problem you are encountering.
Unfortunately a broken PR has been accepted and it broke opencv/darknet/many other ports using ffmpeg downstream...

You can already use my PR to shortcut the solution, otherwise wait for its merge. Nowadays my PR are extremely slow to get merged (I have many pending, some urgent like the one related to OpenCV+VTK9 but still waiting). I hope this one is faster...

You can already use my PR to shortcut the solution, otherwise wait for its merge. Nowadays my PR are extremely slow to get merged (I have many pending, some urgent like the one related to OpenCV+VTK9 but still waiting). I hope this one is faster...

And tried building everything from scratch in a clean enviornment.
The windows build process for darknet using vcpkg mentioned here
I ran:
PS Code\>              git clone https://github.com/microsoft/vcpkg
PS Code\>              cd vcpkg
PS Code\vcpkg>         $env:VCPKG_ROOT=$PWD
PS Code\vcpkg>         .\bootstrap-vcpkg.bat

And then changed the 2 files in my environment.
https://github.com/microsoft/vcpkg/pull/13004/files#diff-d4dc1c0937a15714e65d2309b7100c71
and
https://github.com/microsoft/vcpkg/pull/13004/files#diff-c426d2ca016b755cc8653fdb422a1b5d
Then ran .\vcpkg install darknet[full]:x64-windows again, Still fails with this same error.
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
    Command failed: ninja -v
    Working Directory: D:/Development_work/vcpkg/buildtrees/opencv4/x64-windows-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      D:\Development_work\vcpkg\buildtrees\opencv4\config-x64-windows-out.log

Can you upload the log? The PR should fix the ffmpeg error, I want to better understand what’s the problem now

Can you upload the log? The PR should fix the ffmpeg error, I want to better understand what’s the problem now

config-x64-windows-out.log
I can see some cmake errors.. so here are those logs as well
CMakeOutput.log
CMakeError.log

It looks like the patchset from #13004 was not correctly applied?

It looks like the patchset from #13004 was not correctly applied?

There were only 2 files changed in ffmpeg right ?
I think I did it correctly..But you may be right... I did try again a clean build with carefully changing the ffmpeg fix.. and this time surprisingly it failed with a different error...
-- Downloading https://raw.githubusercontent.com/opencv/opencv_3rdparty/8afa57abc8229d611c4937165d20e2a2d9fc5a12/face_landmark_model.dat...
-- Configuring x64-windows
-- Building x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:141 (message):
    Command failed: "C:/Program Files/CMake/bin/cmake.exe" --build . --config Debug --target install -- -v
    Working Directory: D:/Development_work/vcpkg/buildtrees/opencv4/x64-windows-dbg
    See logs for more information:
      D:\Development_work\vcpkg\buildtrees\opencv4\install-x64-windows-dbg-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_cmake.cmake:91 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_cmake.cmake:24 (vcpkg_build_cmake)
  ports/opencv4/portfile.cmake:371 (vcpkg_install_cmake)
  scripts/ports.cmake:79 (include)

Error: Building package opencv4:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: opencv4:x64-windows
  Vcpkg version: 2020.06.15-nohash

install-x64-windows-dbg-out.log
FAILED: modules/dnn/CMakeFiles/opencv_dnn.dir/src/layers/convolution_layer.cpp.obj
....
D:\Development_work\vcpkg\buildtrees\opencv4\src\4.3.0-0c6047baf6.clean\modules\dnn\src\cuda4dnn\csl\cudnn/transpose_convolution.hpp(38):
error C2065: 'CUDNN_CONVOLUTION_BWD_DATA_PREFER_FASTEST': undeclared identifier

D:\Development_work\vcpkg\buildtrees\opencv4\src\4.3.0-0c6047baf6.clean\modules\dnn\src\cuda4dnn\csl\cudnn/transpose_convolution.hpp(38): error C2065: 'CUDNN_CONVOLUTION_BWD_DATA_PREFER_FASTEST': undeclared identifier

D:\Development_work\vcpkg\buildtrees\opencv4\src\4.3.0-0c6047baf6.clean\modules\dnn\src\cuda4dnn\csl\cudnn/transpose_convolution.hpp(38): error C2065: 'CUDNN_CONVOLUTION_BWD_DATA_PREFER_FASTEST': undeclared identifier

any help?

#13004 works fine. 👍 👍

#13004 works fine. 👍 👍

Yes, but then I get a different error I mentioned above?

I do not encounter this, for latest version of vcpkg with #13004 PR. I added these features to build :
opencv4[contrib,core,cuda,dnn,eigen,ffmpeg,jasper,jpeg,nonfree,openexr,opengl,openmp,png,sfm,tiff,webp]
Did you use the very clear environment?
Building package opencv[contrib,core,cuda,dnn,eigen,ffmpeg,jasper,jpeg,nonfree,openexr,opengl,openmp,png,sfm,tiff,webp]:x64-windows... Could not locate cached archive: C:\Users\Administrator.DESKTOP-05T32PK\AppData\Local\vcpkg/archives\30\3034572fe5bdee26fd2ba258c14bdccdb6770e9d.zip -- Performing post-build validation -- Performing post-build validation done Stored binary cache: C:\Users\Administrator.DESKTOP-05T32PK\AppData\Local\vcpkg/archives\30\3034572fe5bdee26fd2ba258c14bdccdb6770e9d.zip Building package opencv[contrib,core,cuda,dnn,eigen,ffmpeg,jasper,jpeg,nonfree,openexr,opengl,openmp,png,sfm,tiff,webp]:x64-windows... done Installing package opencv[contrib,core,cuda,dnn,eigen,ffmpeg,jasper,jpeg,nonfree,openexr,opengl,openmp,png,sfm,tiff,webp]:x64-windows... Installing package opencv[contrib,core,cuda,dnn,eigen,ffmpeg,jasper,jpeg,nonfree,openexr,opengl,openmp,png,sfm,tiff,webp]:x64-windows... done Elapsed time for package opencv:x64-windows: 4.498 s

I do not encounter this, for latest version of vcpkg with #13004 PR. I added these features to build :
opencv4[contrib,core,cuda,dnn,eigen,ffmpeg,jasper,jpeg,nonfree,openexr,opengl,openmp,png,sfm,tiff,webp]
Did you use the very clear environment?
Building package opencv[contrib,core,cuda,dnn,eigen,ffmpeg,jasper,jpeg,nonfree,openexr,opengl,openmp,png,sfm,tiff,webp]:x64-windows... Could not locate cached archive: C:\Users\Administrator.DESKTOP-05T32PK\AppData\Local\vcpkg/archives\30\3034572fe5bdee26fd2ba258c14bdccdb6770e9d.zip -- Performing post-build validation -- Performing post-build validation done Stored binary cache: C:\Users\Administrator.DESKTOP-05T32PK\AppData\Local\vcpkg/archives\30\3034572fe5bdee26fd2ba258c14bdccdb6770e9d.zip Building package opencv[contrib,core,cuda,dnn,eigen,ffmpeg,jasper,jpeg,nonfree,openexr,opengl,openmp,png,sfm,tiff,webp]:x64-windows... done Installing package opencv[contrib,core,cuda,dnn,eigen,ffmpeg,jasper,jpeg,nonfree,openexr,opengl,openmp,png,sfm,tiff,webp]:x64-windows... Installing package opencv[contrib,core,cuda,dnn,eigen,ffmpeg,jasper,jpeg,nonfree,openexr,opengl,openmp,png,sfm,tiff,webp]:x64-windows... done Elapsed time for package opencv:x64-windows: 4.498 s

Yes I did on clean install...
Thanks for looking into this.
Did you or can you try this?
.\vcpkg install darknet[full]:x64-windows
does this work?

It works on my computer. I fear that some confusion happened during your cuda11 downgrade

It works on my computer. I fear that some confusion happened during your cuda11 downgrade

Oh that's sad...
I am not sure what to try now.. I am losing sleep over this.. I got to get this working :)
In other option, I had built opencv with cmake and visual studio. everything buit fine.. But still cv2 module is not found when I try to import.  I set PATH etc, but still its giving me grief.


app.py is missing

App.py is missing, can't do anything

Its been moved to demos folder and renamed musicgen_app.py

for anyone else having same issue
here up to date tutorial > https://github.com/facebookresearch/audiocraft/issues/183
their written instructions are incomplete

app.py missing.  above instructions ,  musicgen_app.py, not working!
someone made updated instructions that are unclear and is asking patreon money for 1-click installer
this is disappointing!

app.py missing. above instructions , musicgen_app.py, not working!
someone made updated instructions that are unclear and is asking patreon money for 1-click installer
this is disappointing!

nope you didnt even check my post

The solution is very simple. Just copy demos/musicgen_app.py back to the Audiocraft directory and lunch it. This will resolve any issue preventing you from starting the app.

App.py is missing, can't do anything

The solution is very simple. Just copy demos/musicgen_app.py back to the Audiocraft directory and lunch it. This will resolve any issue preventing you from starting the app.

App.py is missing, can't do anything

The solution is very simple. Just copy demos/musicgen_app.py back to the Audiocraft directory and lunch it. This will resolve any issue preventing you from starting the app.

This is the solution. Worked for me.

app.py missing. above instructions , musicgen_app.py, not working!
someone made updated instructions that are unclear and is asking patreon money for 1-click installer
this is disappointing!

here is the missing file let me know if you need help this thing was dumb to setup https://github.com/Cipherbunker/audiocraft/blob/main/app.py

app.py missing. above instructions , musicgen_app.py, not working!
someone made updated instructions that are unclear and is asking patreon money for 1-click installer
this is disappointing!

here is the missing file let me know if you need help this thing was dumb to setup https://github.com/Cipherbunker/audiocraft/blob/main/app.py

If you just rename the musicgen_app.py file that is in demos to app.py and put it in the main Audiocraft directory, you're done. It works. You don't need to download someone else's app.py. ALSO, Cipherbunker's file isn't even remotely the same file. So I would advise NOT downloading it.


Upgrade to Babel 7 and use @babel/preset-env to reduce bundle size

Steps to reproduce
I was looking at the shipped lib/index.js build of this package, and it has functions like this baked in:
function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr2 = Array(arr.length); i < arr.length; i++) { arr2[i] = arr[i]; } return arr2; } else { return Array.from(arr); } }

With @babel/runtime, you'd get something like this:
var _toConsumableArray2 = _interopRequireDefault(require("@babel/runtime/helpers/toConsumableArray"));

The advantage here is, when you bundle, you only get one copy of the toConsumableArray function in all of your code (instead of each library providing the implementation).
This wouldn't be a breaking change. You'd just add @babel/runtime to dependencies.

How much smaller is the resulying bundle?

Hey @eddyystop I looked into this further. Turns out (depending on how you configure Babel), you'll get various bundle size results. For example, if you upgrade to Babel 7 and transpile with loose mode enabled, you'll get a slightly smaller bundle. If you don't enable loose mode, it will actually increase the bundle size.
I didn't compare compressed (gzip) bundle sizes. Practically speaking, I probably should have since most people are serving their JS bundles with compression enabled.
If you're OK with loose mode enabled (implications of doing so are outlined here), we can reduce bundle size. In my opinion, the concerns in the article about the downsizes are overstated since you're not trying to ship fully compliant ES6 spec code. The point of babel'ing is to ship fully compliant ES5 spec code.

The loose mode caveats don't seem applicable to this repo.