Negative amount of leechers

Hey guys,
On some of the torrents on my tracker I see a negative amount of leechers. This seems to happen on torrents where one or more clients already have the files when adding a torrent, means:
(amount of seeders) = (amount of leechers) * -1

As soon as a new leecher joins the pool, the amount of leechers goes up, but is still not correct then (at least on those torrents with negative leecher count).
My torrent object looks like so in the moment:
'55600bbcb00fd923dee589655f74900f5abxxxx': { peers: [Object], complete: 2, incomplete: -2 },
 fe0a979f104964e69e8bbc8bcff5bde120d2xxxx: { peers: [Object], complete: 2, incomplete: -1 },
 d3939d09f0a259c5be1cd31cd06499901ca2xxxx: { peers: [Object], complete: 1, incomplete: 0 },

The first torrent has two seeders and no leecher in reality. The Second torrent has two seeders and one leecher. The third torrent seems to be all right, one seeder, no negative leecher and no leecher at all.
Any ideas on this?

It would help if you restarted the tracker from scratch, but this time run it with the environment variable DEBUG=bittorrent-tracker and share the output.
Example: DEBUG=bittorrent-tracker node my-tracker.js
Thanks!

I believe I've fixed this issue in v3.4.4. If you still encounter this issue, please leave a comment or open a new issue.

Attempted a different fix for "Error: value is out of bounds" that should be a more permanent fix. Let me know if you see that error again.
Released as 3.6.3.


Is it discontinued?

I find this component really handy, but I got some issues with it and I'd like to ask to his owner, the problem is that it seems like it is discontinued. Am I right?

Same question here, but I think we have our answer 😞


Merge documentation pages/sections for running locally/offline/without Internet

Validations

[X] I believe this is a way to improve. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that requests the same enhancement

Problem
https://docs.continue.dev/walkthroughs/running-continue-without-internet
and
https://docs.continue.dev/setup/examples#i-need-to-be-entirely-local--offline
Address the same problem. The second link only talks about VSCode though.
Solution
There should be one page or section about running offline, and it should address both JetBrains IDEs and VSCode.
The easiest fix might be to fold the first page into the "I need to be entirely local" section of the second page.

Totally agree, just made the change here and here


systemed keeps crashing

Hi there ...
I tried to make the py-kms server with systemed on ubuntu and checked everything on the internet and git but, it keeps CRASHING.
1 out of 5 times I checked the service status, it's crashed.
Here is the log on system status.
`Oct 26 06:35:44 kms systemd[1]: Started py3-kms.
root@kms:/kms# sudo systemctl status py3-kms.service
● py3-kms.service - py3-kms
Loaded: loaded (/etc/systemd/system/py3-kms.service; static)
Active: activating (auto-restart) (Result: exit-code) since Wed 2022-10-26 06:42:22 UTC; 483ms ago
Process: 3742 ExecStart=/usr/bin/python3 /kms/pykms_Server.py <IP_ADDRESS> 1688 -V DEBUG -F /kms/pykms_logserver.log (code=exited, status=1/FAILURE)
Main PID: 3742 (code=exited, status=1/FAILURE)
CPU: 134ms
root@kms:/kms# sudo systemctl status py3-kms.service
● py3-kms.service - py3-kms
Loaded: loaded (/etc/systemd/system/py3-kms.service; static)
Active: active (running) since Wed 2022-10-26 06:42:23 UTC; 34ms ago
Main PID: 3747 (python3)
Tasks: 1 (limit: 2200)
Memory: 5.3M
CPU: 33ms
CGroup: /system.slice/py3-kms.service
└─3747 /usr/bin/python3 /kms/pykms_Server.py <IP_ADDRESS> 1688 -V DEBUG -F /kms/pykms_logserver.log
Oct 26 06:42:23 kms systemd[1]: Started py3-kms.
root@kms:/kms# sudo systemctl status py3-kms.service
● py3-kms.service - py3-kms
Loaded: loaded (/etc/systemd/system/py3-kms.service; static)
Active: activating (auto-restart) (Result: exit-code) since Wed 2022-10-26 06:42:23 UTC; 475ms ago
Process: 3747 ExecStart=/usr/bin/python3 /kms/pykms_Server.py <IP_ADDRESS> 1688 -V DEBUG -F /kms/pykms_logserver.log (code=exited, status=1/FAILURE)
Main PID: 3747 (code=exited, status=1/FAILURE)
CPU: 135ms`
Is it a BUG or am I missing something? All permissions are 777 to be sure and everything is been checked 10 times due to the Manual.

BTW the log file permission is also 777 but it's completely empty.

Etrigan also, didn't work ...
Traceback (most recent call last):
  File "/kms/pykms_Server.py", line 27, in <module>
    from Etrigan import Etrigan, Etrigan_parser, Etrigan_check, Etrigan_job
  File "/kms/Etrigan.py", line 12, in <module>
    from collections import Sequence
ImportError: cannot import name 'Sequence' from 'collections' (/usr/lib/python3.10/collections/__init__.py)

See #144 , I think we had fixed that / you may need an older Python version for this repo...


New build & deploy pipeline using Github Actions

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1c96b6c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage          ?   72.50%
=========================================
  Files             ?        6
  Lines             ?       40
  Branches          ?        0
=========================================
  Hits              ?       29
  Misses            ?       11
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c96b6c...8aa0e62. Read the comment docs.


feat: highlight the world address in chat

What changes does this PR make and why should it be merged:
This PR highlights the world address in chat when you Open to LAN.

Code changes have been tested in-game


Commenting: refactoring

See commit log for details. Main changes are:

Moved initComments to run after the form is rendered
Moved field level annotations to the FieldPanel/FieldBlock level rather than on widgets

@kaedroho I'm a bit confused why we're changing to a callback approach here, which seems to be causing a few problems in the later commits. Why not just initialise the commentapp as before and add the form element reliant parts to the existing dom loaded callback?

My aim there was to reduce the amount of magic going on and things happening on module load. But yeah, this does make the draftail initialisation a little awkward (I didn't know how deeply draftail is coupled with the internals of comment app until now!).
I'm thinking of changing my approach with this, instead of initialising the comment app in edit.html, instead move it to being initialised in the entrypoint, but use a javascript hook class to remove the magic initialisation. I think we should avoid having two separate APis for this, so maybe we should make initComments return an API for the initialised comments system, and make that be the thing that is accessed from window.comments?

My aim there was to reduce the amount of magic going on and things happening on module load. But yeah, this does make the draftail initialisation a little awkward (I didn't know how deeply draftail is coupled with the internals of comment app until now!).
I'm thinking of changing my approach with this, instead of initialising the comment app in edit.html, instead move it to being initialised in the entry point again, but use a javascript hook class so it's more like a component. I think we should avoid exposing two separate APis for it, so maybe we should make initComments return the public API for the initialised comments system, and make that be the thing that is accessed from window.comments?
So comments.js would be something like:
import initComments from 'CommentApp';

(() => {
    const element = document.querySelector('.js-comments-app');
    if (element) {
        window.comments = initComments(element);
    }
})();

I'd also move all the logic for handling the comments toggles into comments.js, like above
What do you think?

Yeah, this is something I grappled with before, and why I split the commentApp init into the initial (redux store etc only, that anything else like Draftail/widgets could then use without relying on callbacks) and rendering/loading initial data phases.
I'm not completely sure I get the component approach here - surely this would still need the callbacks for widgets to work?
I think the idea of simplifying the API is good, but tbh there's not much that's not already on commentApp, so we could just reduce down to that...
Let's talk about this in standup tomorrow!

Superseded by https://github.com/wagtail/wagtail/pull/7005


Backend enhancements for transformation plan request to better support UI

Small enhancements to transformation plan request

Treat ServiceTemplateTransformationPlanRequest as backend only so that it does not show on the service requests screen
Set the request's description the same as plan's name. The migration UI shows the request by description. The description can link to the plan.

@bzwei Looks good.

Gaprindashvili backport details:
$ git log -1
commit dc902b6565e3e64a2b34c72150275c5f059b3b47
Author: Greg McCullough<EMAIL_ADDRESS>Date:   Mon Mar 5 10:28:15 2018 -0500

    Merge pull request #17071 from bzwei/v2v_request_desc

    Backend enhancements for transformation plan request to better support UI
    (cherry picked from commit b253433b46c24bcc6056eafb24610ed78e55989b)


Could not restore the project Error: Request failed with status code 500. "TypeError: Label() got an unexpected keyword argument 'type'\n".

My actions before raising this issue

[X] Read/searched the docs
[X] Searched past issues

Could not restore the project
Error: Request failed with status code 500. "TypeError: Label() got an unexpected keyword argument 'type'\n".
Getting this error when trying to restore a project from backup.

Please, fill the issue template, providing the version you are using and the version backup has been done.

i have the same error, i have created a backup on CVAT server on premise, and i try to restore file into cvat.app
version on premise installation
Server version: 2.1
Core version: 5.0.1
Canvas version: 2.13.2
UI version: 1.37.0
Version  on cloud CVAT.app
Server version: 2.4.3
Core version: 9.0.1
Canvas version: 2.16.3
UI version: 1.50.8

@DaniNexplore Sorry, it is not clear what version the backup was done and where you try to restore it.

Hi
i have generated the backup in
Server version: 2.1
Core version: 5.0.1
Canvas version: 2.13.2
UI version: 1.37.0
and i am trying to restore on:
Server version: 2.4.3
Core version: 9.0.1
Canvas version: 2.16.3
UI version: 1.50.8


EVEREST-738 psmdb restore statuses fix

PSMDB restore status fix
Problem:
EVEREST-738
Short explanation of the problem.
PSMDB restored db cluster stuck in the "restoration" status.
Cause:
If the PITR is disabled, the latest status of an psmdb-restore object will be requested. It's waiting for oplogs, but since the pitr is disabled they never appear.
Solution:
This is a straightforward fix which considers the requested status differently depending if the pitr is enabled. The problem is under discussion with the cloud team, perhaps it can be improved from the psmdb operator's side in the later releases
CHECKLIST
Jira

[ ] Is the Jira ticket created and referenced properly?

Tests

[ ] Is an Integration test/test case added for the new feature/change?
[ ] Are unit tests added where appropriate?

Closing it since it only fixes the symptoms but not the main issue


Allow range of linked-hash-map versions

The newer versions provide an IntoIterator implementation which I need. This is not a breaking change because yaml-rust will continue to work with the old versions of linked-hash-map.

Ping @chyh1990. Could you also publish a release of this? Thanks!

Ping @chyh1990 again

sorry for the delay.
You will see it in the next release :-)


Adds hint for auto-registration with nested namespaces

Auto-registration already supports nesting namespaces, and those are accepted by ROM::AutoRegistration if specified properly with "::" in the namespace string.
This proposal is for documenting this use case.

Thanks!


Passing params to connect is deprecated. Instead pass :params to the Socket constructor

I'm using Guardian to authenticate my channels and I'm using it on socket.connect.
But I saw that the javascript console shows a message that passing parameters in connect is deprecated.
If I try to use :params in the socket constructor the out-of-box Guardian.Phoenix.Socket do not work.
Is there something I'm missing here or is it need a change in guardian to support passing parameters in Socket constructors?

@douglascorrea there may have been a chance to Phoenix Sockets that warrants a Guardian change, do you have a project we could look at that demonstrates this error?

@doomspork sorry about late answer I will setup a project to reproduce and ping you here.

@douglascorrea any updates or can I close this ticket?

Hi @doomspork sorry, I really forgot this. Please go ahead and close it, as soon I get time to create a project to reproduce it I ping this issue and we re-open it if necessary.


NaNs in the end of time series after OutliersTransform

🐛 Bug Report
In case, where the dataset contains outliers in the end of some time series(not all), they are replaced with NaNs by the OutliersTransform and time series stop being ending in the same timestamp. This cause raising errors in the subsequent transforms.
Expected behavior
Perform subsequent transforms without raising errors
How To Reproduce
Code
import pandas as pd
from etna.datasets.tsdataset import TSDataset
from etna.transforms import DensityOutliersTransform, TimeSeriesImputerTransform

classic_df = pd.read_csv("examples/data/example_dataset.csv")
df = TSDataset.to_dataset(classic_df)
ts = TSDataset(df, freq="D")

params = {"window_size":18,
          "distance_coef":1,
          "n_neighbors":4}
outliers_remover = DensityOutliersTransform(in_column="target",**params)
outliers_imputer = TimeSeriesImputerTransform(in_column="target",strategy="running_mean",window=30)
ts.fit_transform([outliers_remover])
ts.fit_transform([outliers_imputer])

Environment
No response
Additional context
No response
Checklist

[X] Bug appears at the latest library version
[X] Bug description added
[X] Steps to reproduce added
[X] Expected behavior added

This is expected behaviour -- we call self._check_endings() at the beginning of fit_transform.
Outliers remover may make some timeseries shorter, that's why next call of fit_transform will rise Exception.
As a workaround you could deepcopy ts and call ts1.fit_transform([outliers_remover]), ts2.fit_transform([outliers_remover, outliers_imputer]) via independent tsdatasets.


"Colorizing" the right IR imager stream with color camera (d415 unity)

Hey,
I've got not so usual problem,
In unity i've managed to get left and rightmost image streams : right IR and color,
in attempt to use it with stereo camera setup (XR) as a stereo ar background, and I want to colorize the ir output using colour reference. Currently im thinking about custom shader that would stylize and mix both streams to simulate disparity, but maybe there is a way to do it using existing methods.

Hi @TheBricktop
The problem makes sense, sorry for delay in response. There is unfortunately no built-in way to map one texture stream to another texture stream without one of them being depth. So probably using shader with extrinsics and extrinsics passed as uniforms. The following code may be useful as reference - gl/pointcloud-gl.cpp:24-103

@TheBricktop Any other questions with the reply from dorodnic? Looking forward to your update. Thanks!

There's probably a way to do this using opencvHomography abeit it could be cpu taxing.

@TheBricktop Thanks for the update! Did you get it through now?

@TheBricktop  Any other questions? Thanks!

@TheBricktop Will close this if no other questions. Thanks!


Added support for dependencies used in ES6 computed object properties

Hey @mehdishojaei, I was using amdextract as part of grunt-amdcheck and noticed that I was getting some false positives for unused dependencies when I used the dependency in an ES6 computed object property. In my use case, we have an AppConstants dependency that holds a bunch of common strings, which can be used to create a computed object property name like this:
var obj = {
    [AppConstants.CONST]: 'sample value'
}

This would result in grunt-amdcheck claiming that the AppConstants dependency was not being used. It seems like the issue was that when processing the computed property, the traverse function would do this:
first iteration...
-------
key --> 0
child --> Property {
  type: 'Property',
  key: Identifier { type: 'Identifier', name: 'AppConstants', range: [ 73, 85 ] },
  computed: true,
  value:
   Literal {
     type: 'Literal',
     value: 'sample value',
     raw: '\'sample value\'',
     range: [ 88, 102 ] },
  kind: 'init',
  method: false,
  shorthand: false,
  range: [ 72, 102 ] }

second iteration...
-------
child --> Property {
  type: 'Property',
  key: '0',
  computed: true,
  value:
   Literal {
     type: 'Literal',
     value: 'sample value',
     raw: '\'sample value\'',
     range: [ 88, 102 ] },
  kind: 'init',
  method: false,
  shorthand: false,
  range: [ 72, 102 ] }

So we lose the original identifier information Identifier { type: 'Identifier', name: 'AppConstants', range: [ 73, 85 ] }, and the key gets overwritten with '0'.

Thanks for your contribution. Actually, the project is not updated for ES6 so far.


Add sockets to the repl

Do you want to request a feature or report a bug?
feature
The repl is really good and I use it all the time. One thing I have been doing is starting a Docker Container which runs the tests and then I have just been checking the logs to see that everything is still running fine.
One problem is I can not join the repl. But adding sockets to the repl is pretty easy
e.g.
const replPort = 1234
const net = require('net')
net.createServer(function (socket) {
    var r = repl.start({
      prompt: '> ',
      input: socket,
      output: socket,
      terminal: true,
      useGlobal: false
    })

    r.on('exit', function () {
      socket.end()
    })

    r.context.socket = socket
    r.context.nmos = nmos
  }).listen(replPort)

and then joining this would be easy as well
const net = require('net')

module.exports = (replPort) => {
  let socket = net.connect(replPort)

  process.stdin.pipe(socket)
  socket.pipe(process.stdout)

  socket.on('connect', function () {
    process.stdin.resume()
    process.stdin.setRawMode(true)
  })

  socket.on('close', function done () {
    console.log('Disconnected from jest')
    process.stdin.setRawMode(false)
    process.stdin.pause()
    socket.removeListener('close', done)
    process.exit(0)
  })

  process.stdin.on('end', function () {
    console.log('Disconnected from jest')
    socket.destroy()
    process.exit(0)
  })

  process.stdin.on('data', function (b) {
    if (b.length === 1 && b[0] === 4) {
      process.stdin.emit('end')
    }
  })
}

then you should be able to connect with something like
npm run jest -- --connect

Which would then let you connect to the repl which is running somewhere else and interact with it. In my case I can start jest in a Docker Container and then run the above command whenever I want to run some tests or see what the current status is without having to ssh into the Container.
I can do this on a PR if you like but would like to know if there is any reason not to do this before pursuing the work

I don't think this needs to be in Jest, does it? Can you create your own wrapper using Jest's JS API that you build a socket around it to see what that would look like? If this is something super useful to many, we can think about integrating this into the Jest repo.

are there any docs on the jest-cli? I could not find any when I was looking in this repo. I could look into making a wrapper myself but last time I looked at jest-cli I had to do a lot of hacking to make it work (that was pre repl about a year ago when I wanted a watch)

There isn't any documentation. I also recommend you to look at jest-editor-support which uses the watch mode for editor integration and may already do what you need. I'll close this issue out but happy to continue the discussion and reopen if necessary.


Run git add . after processing

Description
After processing files, we now run git add . to stage all changes. By running git add . after processing, we ensure
that we stage all files that have been created, modified or deleted during the processing.
Changes

Add a step to run git add . after processing.

Blocked by #3.


[FEATURE REQUEST] Atom symbol tree view dock integration

This is a feature request for symbol tree view dock integration in Atom.

@dnyaneshgate Hi, maybe you can try this newer plugin which used docker.
https://atom.io/packages/structure-view


Upgrade script

Hello sir @Leeon123 i sugest to upgrade your script using this lib https://github.com/galmi/grucaptcha or https://github.com/Wyvern-Balls/Cloudflare-Bypass-Script  for bypass iuam and hcaptcha, also your script can't send attack to url using https:// can u solve i?

I'll check it out, and use port 443 can enable ssh connection so you can attack https://.


Fixed and issue comparing lists of dicts

Need to add some unit tests before merging.

Thanks!
Would it be possible to have a missing/present differences down to the list item and not the full list?

@XioNoX I have fixed this issue. I have also added several tests that serve as example to see how this works. Check the use of get_route_to.

Would it be possible to have a missing/present differences down to the list item and not the full list?

Problem is that we are comparing lists of dicts where there is no unique "key" I can use to determine that they are the same object and, thus, show the diff. For example:
https://github.com/napalm-automation/napalm-base/pull/181/files#diff-8a0539f4f2d874e6f8149c720c55a1fdR2
Should I compare the route in the validate.yml against the first or the second route? If you have any idea on how to do this in a generic way, let me know.

@XioNoX I have fixed this issue. I have also added several tests that serve as example to see how this works. Check the use of get_route_to.

Would it be possible to have a missing/present differences down to the list item and not the full list?

Problem is that we are comparing lists of dicts where there is no unique "key" I can use to determine that they are the same object and, thus, show the diff. For example:
https://github.com/napalm-automation/napalm-base/pull/181/files#diff-8a0539f4f2d874e6f8149c720c55a1fdR2
Should I compare the route in the validate.yml against the first or the second route? If you have any idea on how to do this in a generic way, let me know.

@dbarrosop Indeed, I looked at it and can't think of an easy solution.


[WIP] Variants

Many build systems have multiple operations which can be performed on a single target. For example, in addition to building, one might be able to clean, install, test, or profile it. It would be inconvenient to specify these as different targets: build providers would often have to duplicate a lot of state to do so, and the user would have to e.g. switch targets to run their tests.
This PR therefore adds support for variants, a flexible, opt-in way for build providers to specify alternative operations for a given target.
Each target can contain a variants field, which holds an object containing properties which override whatever is set in the base target. It looks something like this:
{
  name: 'All',
  exec: 'stack',
  args: [ 'build' ],
  variants: {
    test: { args: [ 'test' ] }
  }
}

A specific variant is selected by the build source; if the source starts with trigger-, the remainder is the variant. You can see slightly more detail in my PR against my build-stack build provider.
I’d further like to change the UI slightly to indicate which variants a given target supports, as well as to indicate the action being taken in the status bar (e.g. “testing target-name” instead of just “target-name”).
For the moment I’ve added a build:trigger-test variant to demonstrate this, but I would like to get feedback on the approach before I go too much further. I would like to add support (i.e. well-known commands and keymaps) for test, profile, and clean variants, and possibly benchmark as well.

clean
profile
[ ] Add the current action to the status bar.
[ ] Indicate available variants in the target switcher.
[x] Avoid shadowing.
[ ] Test that:

[ ] Triggering an unavailable variant throws.
[ ] The triggered variant is copied into the target.

I like the idea. But I would like to propose a variant of the implementation (pun!).
I do not think hard-coding variants (such as test or profile) is a good idea. There will be a million different suggestions of what a "build variant" is from the community and it would spiral out of control.
I would like to see a more generic approach. What if the variants rather inherited all but the specified options and created a new build target all together. For instance
{
  "cmd": "buildtool",
  "cwd": "/long/complicated/path",
  "errorMatch": [ "[fancy-regex-stuff]", "[multiple times]" ],
  "variants": {
    "test": { args: [ "test" ] },
    "compile": { args: [ "-c" ] },
    "run": { args: [ "run" ] },
  }
}

Implementation wise it would be as easy as looping all the variants and doing Object.assign({}, root, variant).
This could easily be used not only by build providers, but also people writing their custom build files.
What do you think?

@noseglid: While that is admirably simple, it would reduce this to syntactic sugar for defining targets. I can abstract that duplication away in my build provider by writing a function. What my build provider can’t do is give the user a uniform way to build/test/profile/benchmark the active target regardless of what project I’m looking at or what build system it uses.
From my perspective, that’s the important bit of what this PR accomplishes, and likewise it’s the important bit of of what build gives me as an end user. So I’d really like to find a way to make this work naturally with build.
That said, I definitely agree that everyone will have their own actions which they want to provide. Maybe, in addition to a few common defaults (test and profile, perhaps, or even just test), we could look at which variants the build providers are actually providing and listen for those.
That way, end users don’t need to configure anything at all (unless they’re using custom build files, in which case it’s a simple addition to what they’re doing already). If a user wants a shortcut for an uncommon build variant, they can add one to their keymap like always; and build can bless “common-enough” variants by adding default keymaps, if so desired.
In fact, we wouldn’t have to hard-code any variants at all then; I’d be more than happy to add shortcuts to my own keymap, and suggest that build-stack’s users do the same.

@noseglid: I’ve updated the PR to implement the adjustment to the proposal made above :point_up: It’s working quite well, and you can even find the variants in the command palette.

I'd want to review and test this, but don't wanna do so until the daily builds are working. Are you looking into that?

I'd want to review and test this, but don't wanna do so until the daily builds are working. Are you looking into that?

My bad, I was waiting for response to my revised proposal :grin: I’ll resolve the CI failures.

@noseglid: This should pass the tests now.

Cool! I'll have a look at it shortly. Currently on a trip!

Enjoy your trip! :blush:

I visioned variants to be registered as normal commands. That way, atomCommandName can be used to optionally register a command name. It would have the same effect as what you're doing now, with the added benefit that the variants will be visible in the available targets list view.
I know above is diverging a bit from what you originally intended with this PR (a uniform way to run various tasks - such as test and profile - associated with a target). I just don't think that should be in the scope of this plugin, which is why I am trying to find a middle way with something I do think is within the scope of this plugin and can help you solve your challenge :smile:
Any reason why you're not allowing variants to be used through the custom build file implementation?
There must also be some documentation and specs with this.

I visioned variants to be registered as normal commands. That way, atomCommandName can be used to optionally register a command name. It would have the same effect as what you're doing now, with the added benefit that the variants will be visible in the available targets list view.

As I said before, that’s in direct conflict with what I’m trying to achieve. I very much do not want to have multiple targets for different actions, one target per action—if I did, I could do that right now without variants, by just making more targets in my build provider. Rather, I want multiple actions per defined target, in much the same way that e.g. an Xcode target can be built, cleaned, run, archived, profiled, tested, etc.

I know above is diverging a bit from what you originally intended with this PR (a uniform way to run various tasks - such as test and profile - associated with a target). I just don't think that should be in the scope of this plugin, which is why I am trying to find a middle way with something I do think is within the scope of this plugin and can help you solve your challenge :smile:

If you don’t consider multiple actions per target to be in scope, that’s obviously your decision, and I’ll respect that. But in that case, I don’t think this PR offers anything new or valuable—build providers can already make new targets conveniently by the use of a “template” function, without requiring build to add any special support. So I’m going to close this PR.
Again, I respect your decision to limit builds scope to a single action per target. But as an end user, I’m quite disappointed. This complicates my workflow quite a bit, and limits the value I get from build at all.
Nevertheless, thank you for reviewing!

I am very sorry about all the effort you put down that didn't lead to anything.
I just want to be clear - I don't think it's a bad idea. Just not in scope.
Thanks again for your time.

@noseglid: Thanks for circling back, I appreciate it. These things happen :blush:


New Function Get-DbaDbObjectTrigger & Improve Find-DbaTrigger

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[x] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[x] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
new function Get-DbaDbObjectTrigger that search for triggers on object level. This means Tables and Views
Also improved the Find-DbaTrigger to include triggers on views.
Motivation: https://twitter.com/TheRockstarDBA/status/1129059763373912065?s=01
Approach

Commands to test
Get-DbaDbObjectTrigger
Find-DbaTrigger
Screenshots

Learning

@potatoqualitee @wsmelton @sqllensman
Seems it is stuck on appveyor/branch.
Regarding the failed ones there, I haven't change anything.
What should I do? Will you force the merge?

mmm you will need to recreate your branches, it's super messed up - 1283 files modified. Please copy your changed files to a diff directory, get latest prerelease, rebranch then try again. Going to close, please feel free to reopen this PR if you can fix it, otherwise, I will wait for the updated PR.

There is only 3 changes for the PR.

my last commit must have worked but not showed up, thanks for rechecking 💯  will merge when tests pass

The branch failure is n/a as the PR test was successful. Since it is reopened it will have to run both again.

thanks so much for the new function! 🙇  gonna do a mass function comparison towards the end and add all new commands at once to psd1/psm1

boooom 💣


Small correction in the HCSR04 README regarding JMP X--

Hi there,
The README currently reads

The jmp x-- test decrements x and if this does not result in a 0 in x, it jumps to testing for the stop criterion (here the Echo pin going low).

However, according to the documentation, the test is done before decrementing the X register.

JMP X-- and JMP Y-- always decrement scratch register X or Y, respectively. The decrement is not conditional on the current value of the scratch register. The branch is conditioned on the initial value of the register, i.e. before the decrement took place: if the register is initially nonzero, the branch is taken.

Regards,
Dan

You're right. I have changed the sentence. Thanks!


Classes in bundle 'app' do not match with execution data.

Whatever task I try to run, I get this message:
[ant:jacocoReport] Classes in bundle 'app' do not match with execution data. For report generation the same class files must be used as at runtime.
[ant:jacocoReport] Execution data for class package/class/here does not match.

I only have unit tests, so I disabled androidTests. The report is generated, but the coverage is all 0%. I'm in Gradle 7.3.3, AGP 7.1.3, and plugin 1.5.3. My project is a mix of java and kotlin. (src/main/java and src/main/kotlin)

Check if you have any other plugin instrumenting your classes.
We had the same issue and the reason was Firebase Performance plugin instrumenting classes which breaks Jacoco instrumentation.
The fix was quite simple - disable Firebase Performance instrumentation for debug builds:
android {
  // ...
  buildTypes {
    debug {
      // ...
      FirebasePerformance {
        instrumentationEnabled false
    }
  }
}

We also hava a similar issue in another module but I suspect it's caused by All-open plugin.

@mihmilicio Sorry for this late response, like @0neel mentioned this can be caused by other plugins also changing class code (instrumenting classes). JaCoCo must be the last to instrument otherwise the classes don't match with execution data. It is hard to figure out without knowing more what is currently happening, but I suggest to look into the suggestions given by @0neel because that is usually the solution.

For now I closed this issue, if you need more assistance and feel like it has to do something with this plugin, feel free to re-open.


add node selector to admission-controllers

see https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/admission/podnodeselector/admission.go#L40
https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/admission/podnodeselector/admission.go#L67

This change is

/cc @aveshagarwal

ping @derekwaynecarr @aveshagarwal @chenopis

@xilabao I will review it soon.

@derekwaynecarr Can you give your approval based on the changes you requested? We can still wait for @aveshagarwal to review.

@aveshagarwal Can you take a look when you get a chance? Thx

@chenopis yeah sure, sorry for delay.

@aveshagarwal No worries. Thx!

I reviewed, and changes  LGTM

@chenopis


Add 5 PInvoke native tests under Desktop

When git indicate the file is binary but isn't, this is usually because the text encoding is off. You can fix this by re-saving the file using notepad.exe and setting the encoding to UTF8 or ASCII.


@effect/cli options that handles Schema

What is the problem this feature would solve?
If you add a options constructor for schema's you leverage the power of schema's, to encode a string options into anything schema supports:
Simple example:
import { Command, HelpDoc, Options, ValidationError } from "@effect/cli"
import { NodeContext, NodeRuntime } from "@effect/platform-node"
import { Schema } from "@effect/schema"
import { Console, Effect, pipe } from "effect"

export const validateWithSchema = <A, I>(schema: Schema.Schema<A, I>) =>
  Options.mapEffect((x: A) =>
    pipe(
      Schema.encode(schema)(x),
      Effect.mapError((e) => ValidationError.invalidValue(HelpDoc.p(e.message)))
    )
  )

const schemaOption = Options.integer("option1").pipe(validateWithSchema(Schema.Int.pipe(Schema.clamp(1, 10))))

const run = Command.make("example", { schemaOption }, (opts) => Console.log(opts)).pipe(
  Command.run({
    name: "Test",
    version: "1.0.0"
  })
)

const main = Effect.suspend(() => run(globalThis.process.argv))

main.pipe(
  Effect.provide(NodeContext.layer),
  Effect.tapErrorCause(Effect.logError),
  NodeRuntime.runMain
)

What is the feature you are proposing to solve the problem?
You get the build in functions that schema supports.
I know this would can create a coupling between @effect/cli and @effect/schema, but isn't @effect/schema becoming a de-facto standard package (like effect itself) for all other packages?
What alternatives have you considered?
Creating my own set of option validators...

There is Options.withSchema: https://effect-ts.github.io/effect/cli/Options.ts.html#withschema
What was your suggestion?

Ah, yes! Thank you. It was also due to my misinterpretation of clamp why i couldn't get an error when a number outside the range was not throwing an error. I need Schema.between ...
Sorry about that!
Thank you!


The named parameter 'finishMode' isn't defined

After upgrading the version to audio_waveforms 1.2.0 I got this error:
The named parameter 'finishMode' isn't defined
For this part of the code:
 onPressed: () async {
                  controller.playerState.isPlaying
                      ? await controller.pausePlayer()
                      : await controller.startPlayer(
                          finishMode: FinishMode.pause,
                        );
                },

@karimi1064 From 1.2.0, you can set the finish mode from separate function like this,
controller.setFinishMode(finishMode: FinishMode.stop);

@karimi1064 From 1.2.0, you can set the finish mode from separate function like this,
controller.setFinishMode(finishMode: FinishMode.stop);

Thanks @ujas-m-simformsolutions .

When I use it as separate function my player does not work at all
      await audioCtrl.setFinishMode(finishMode: FinishMode.pause);
      await audioCtrl.startPlayer();


[cleanup] remove final return Promise.resolve()

:tada: This issue has been resolved in version 1.0.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fixes paths for SSL setup.

Fixes error from logrotate when fail2ban is disabled (failure
when reloading the service).
BTW - /tmp/docker-mailserver/spamassassin/rules.cf is a valid path for spamassassin rules? Because I don't have a supposed path layout for all the use case :)

No, it should be in config/. I'm open to suggestion :-)

accounts are now looked at the following position: /tmp/docker-mailserver/postfix-accounts.cf
So if I understand, spamassassin should be looked at: /tmp/docker-mailserver/spamassassin-rules.cf
If this is correct I've to change my PR, so please do not merge this one. I'll push another PR.


Unhandled NPE during METS file validation

This is likely caused by a missing File locator and should be reported as such through an IngestException.
2012-02-17 13:40:31,967 ERROR [ajp-bio-8009-exec-39] edu.unc.lib.dl.service.impl.SubmitServiceImpl - unexpected exception
java.lang.NullPointerException
at edu.unc.lib.dl.ingest.sip.METSPackageFileValidator.validateFiles(METSPackageFileValidator.java:89)
at edu.unc.lib.dl.ingest.sip.METSPackageSIPProcessor.createAIP(METSPackageSIPProcessor.java:145)
at edu.unc.lib.dl.services.DigitalObjectManagerImpl.addToIngestQueue(DigitalObjectManagerImpl.java:139)
at edu.unc.lib.dl.service.impl.SubmitServiceImpl.metsSubmit(SubmitServiceImpl.java:90)
at edu.unc.lib.dl.ws.MetsSubmitEndpoint.metsSubmit(MetsSubmitEndpoint.java:40)
The UI does not report this error and in fact will report success. This is probably b/c a runtime exception is not caught.

Fixed NPE. Also added a check for this to schematron and made schematron error messages appear in the UI.


Provide facility for accepting user input through Source Control (GUI) tab

Once there is a need to provide user input (interaction, for example Client-Side Git Hooks) via a git operation (git command), the stdin can be provided by the embedded terminal that vscode offers whereas this is not possible by using the SCM. Can the source control management panel pops-up a communication box and accept users' input? Thanks.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


[Storage][Doc] Document exceptions/errors from a function

(copied from #5788)

Add more description in the JS Docs explaining the cases where a function might fail/result in an error.

Example - creating a container. Write about exceptions that the function might throw which can be caught by the users with try-catch
Descriptions for errors for each and every function - For example, uploading a blob to a non-existing container

Then there would be too much to document and hard to maintain as the service evolves.
Probably simply need to link to the API reference doc.


AttributeError: 'Annotation' object has no attribute 'for_json'

Tested versions

Library
Version

Python
3.12.2

Pyannote.audio
3.1.1

Pyannote.core
5.0.0

speechbox
0.2.1

System information
macOS 14.1 (23B2073) - M3 Max
Issue description
Code
from transformers import pipeline
from pyannote.audio import Pipeline
from speechbox import ASRDiarizationPipeline as ASRDP

diarization_pipeline = Pipeline.from_pretrained("pyannote/speaker-diarization-3.1", use_auth_token=os.environ["HUGGINGFACE_TOKEN"])
asr_pipeline = pipeline("automatic-speech-recognition", model="openai/whisper-large-v3")
pipe = ASRDP(asr_pipeline=asr_pipeline, diarization_pipeline=diarization_pipeline)
output = pipe("audio.mp3")

Error
[/opt/homebrew/lib/python3.12/site-packages/tqdm/auto.py:21](https://file+.vscode-resource.vscode-cdn.net/opt/homebrew/lib/python3.12/site-packages/tqdm/auto.py:21): TqdmWarning: IProgress not found. Please update jupyter and ipywidgets. See https://ipywidgets.readthedocs.io/en/stable/user_install.html
  from .autonotebook import tqdm as notebook_tqdm
[/opt/homebrew/lib/python3.12/site-packages/pyannote/audio/core/io.py:43](https://file+.vscode-resource.vscode-cdn.net/opt/homebrew/lib/python3.12/site-packages/pyannote/audio/core/io.py:43): UserWarning: torchaudio._backend.set_audio_backend has been deprecated. With dispatcher enabled, this function is no-op. You can remove the function call.
  torchaudio.set_audio_backend("soundfile")
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[8], [line 2](vscode-notebook-cell:?execution_count=8&line=2)
      [1](vscode-notebook-cell:?execution_count=8&line=1) with ProgressHook() as hook:
----> [2](vscode-notebook-cell:?execution_count=8&line=2)     output = pipe("audio.mp3", hook=hook)

File [/opt/homebrew/lib/python3.12/site-packages/speechbox/diarize.py:90](https://file+.vscode-resource.vscode-cdn.net/opt/homebrew/lib/python3.12/site-packages/speechbox/diarize.py:90), in ASRDiarizationPipeline.__call__(self, inputs, group_by_speaker, **kwargs)
     [83](https://file+.vscode-resource.vscode-cdn.net/opt/homebrew/lib/python3.12/site-packages/speechbox/diarize.py:83) inputs, diarizer_inputs = self.preprocess(inputs)
     [85](https://file+.vscode-resource.vscode-cdn.net/opt/homebrew/lib/python3.12/site-packages/speechbox/diarize.py:85) diarization = self.diarization_pipeline(
     [86](https://file+.vscode-resource.vscode-cdn.net/opt/homebrew/lib/python3.12/site-packages/speechbox/diarize.py:86)     {"waveform": diarizer_inputs, "sample_rate": self.sampling_rate},
     [87](https://file+.vscode-resource.vscode-cdn.net/opt/homebrew/lib/python3.12/site-packages/speechbox/diarize.py:87)     **kwargs,
     [88](https://file+.vscode-resource.vscode-cdn.net/opt/homebrew/lib/python3.12/site-packages/speechbox/diarize.py:88) )
---> [90](https://file+.vscode-resource.vscode-cdn.net/opt/homebrew/lib/python3.12/site-packages/speechbox/diarize.py:90) segments = diarization.for_json()["content"]
     [92](https://file+.vscode-resource.vscode-cdn.net/opt/homebrew/lib/python3.12/site-packages/speechbox/diarize.py:92) # diarizer output may contain consecutive segments from the same speaker (e.g. {(0 -> 1, speaker_1), (1 -> 1.5, speaker_1), ...})
     [93](https://file+.vscode-resource.vscode-cdn.net/opt/homebrew/lib/python3.12/site-packages/speechbox/diarize.py:93) # we combine these segments to give overall timestamps for each speaker's turn (e.g. {(0 -> 1.5, speaker_1), ...})
     [94](https://file+.vscode-resource.vscode-cdn.net/opt/homebrew/lib/python3.12/site-packages/speechbox/diarize.py:94) new_segments = []

AttributeError: 'Annotation' object has no attribute 'for_json'

This was tried on Jupyter Notebook on local device as well as on Google Collab. The error remains the same.
Minimal reproduction example (MRE)
AttributeError: 'Annotation' object has no attribute 'for_json'

See my comment here: https://github.com/huggingface/speechbox/pull/26
@patrickvonplaten

When will this issue be solved? @patrickvonplaten @jsrozner

Looks like the developers for this project are dead. And updates will be only done after the funeral of the developers. 😂

Use this
pip install git+https://github.com/huggingface/speechbox.git
(run pip uninstall speechbox first if you already have it installed)
You might be able to create a pull req for a new release so that pip install speechbox does work

Solved.


Fix initial audio engine unlock state

Changes the audio engine's initial unlock value to false so it is correct if the browser prevents audio before a user interaction.
Reported on forum: https://forum.babylonjs.com/t/remove-unmute-button/27577/30

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Note that most of the changes in this PR are for moving the audio test helpers and mocks out of sound.test.ts and into their own separate modules so they can be reused in the new audioEngine.test.ts module.

Snapshot stored with reference name:
refs/pull/14177/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14177/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14177/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14177/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14177/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14177/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14177/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14177/merge#BCU1XR#0


Removing old code signing reference

Removing old code signing reference

[ ] You've read the Contributor Guide and Code of Conduct.
[ ] You've included unit or integration tests for your change, where applicable.
[ ] You've included inline docs for your change, where applicable.
[ ] If any gains or losses in performance are possible, you've included benchmarks for your changes. More info
[ ] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)
Description
{Detail}
Fixes #{bug number} (in this specific format)

Build: https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1330552&view=results


Update Client.php for V2

Since v1 is no longer supported by LinkedIn, I suppose the updates from here could be put in the client itself.

@Jeroen-G In the meantime, you can use setApiRoot


Floating action button on top of Listview

Hi!
I would like to have a Floating Action Button on top of my Listview which then adds extra items to an existing list:
class HomePageBody extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return new Expanded(
      child: new Container(
        color: Color.fromRGBO(53, 73, 94, 0.9),
        child: new CustomScrollView(
          scrollDirection: Axis.vertical,
          slivers: <Widget>[
            new SliverPadding(
              padding: const EdgeInsets.symmetric(vertical: 0.0),
              sliver: new SliverFixedExtentList(
                itemExtent: 152.0,
                delegate: new SliverChildBuilderDelegate(
                      (context, index) => new PlanetRow(planets[index]),
                  childCount: planets.length,
                ),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

I cannot seem to figure out how to do so because every time I try, some error shows up. I followed the exact instructions from here. The container contains the planet cards which I did not include in the code above since it is not necessary to do so I think. Any help would be greatly appreciated!

Hi @Jackodb
This platform is not met for assistance on personal code.
Please see https://flutter.dev/community for resources for asking questions like this,
you may also get some help if you post it on Stack Overflow.
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you


False GCP ressource ID matching

Description
Some GCP resources, stated as "supported", yet produce a drift, because their IDs are matched in a false way.
Environment

OS: Ubuntu 20.04
driftctl version: 0.35.0
terraform version: 1.2.4
terraform providers versions: Google 4.27.0

How to reproduce

Create resource google_compute_address via Terraform
Run driftctl against state file from previous step
Get drift with following details:

Found missing resources:
From tfstate:///tmp/mystate.tfstate
- myproject/europe-west1/myaddress(google_compute_address.myaddress)
Address: <IP_ADDRESS>, Name: myaddress
- myrule (google_compute_firewall.myrule)
- myforwardingrule (google_compute_forwarding_rule.myforwardingrule)
- mynetwork (google_compute_network.mynetwork)
- europe-west1/mysubnet (google_compute_subnetwork.mysubnet)
Name: mysubnet
- myzone (google_dns_managed_zone.myzone)
Found resources not covered by IaC:
google_compute_address:
- projects/myproject/regions/europe-west1/addresses/myaddress
Address: <IP_ADDRESS>, Name: myaddress
google_compute_firewall:
- projects/myproject/global/firewalls/myrule
google_compute_forwarding_rule:
- projects/myproject/regions/europe-west1/forwardingRules/myforwardingrule
google_compute_network:
- projects/myproject/global/networks/mynetwork
google_compute_subnetwork:
- projects/myproject/regions/europe-west1/subnetworks/mysubnet
Name: mysubnet
google_dns_managed_zone:
- projects/myproject/managedZones/myzone

hey @nie-kita2, sorry for the delay. I tried to reproduce your bug but I couldn't.
Do you by any chance have a minimal terraform file that I could try ? I created a simple compute address and one associated with a network, I even tried creating them with an older provider and updating it but never got any id mismatch like you encountered.


feat: add dms wsdl and mtom config

Description
Upgrade DMS WSDL
Reference
Issue: https://app.zenhub.com/workspaces/digiwf-621f70bf50ea1100120b7e93/issues/it-at-m/digiwf-project/423
Checklist

[ ] Acceptance criteria are met
[x] Pipeline has been run successfully
[x] JUnit tests have been run successfully
[x] Changelog is adjusted
[ ] Documentations are completed
[x] Frontend is tested
[ ] Created sub-branches are deleted
[ ] Boards are updated ( Digitalisierung , Support , Zenhub )
[ ] feature process is created or extended
[ ] git-ops is customized
[ ] Openshift environments are prepared (Secrets, etc.)

Did a lokal smoke test with the feature process "Vorgang anlegen" -> worked

@dominikhorn93 You forgot to adjust the request in the dms-eai. The FunctionalPing has its own client.


settings: Make the label for disabled checkboxes less faded.

This PR updates the CSS to makes the label for disabled checkbox less faded such that it
is faded enough to figure out that the setting is disabled but the text is also visible clearly.
Follow up to #30594.

Screenshots and screen captures:

Light mode
Dark mode

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

The screenshots look good to me; I haven't tested.

Merged, thanks @sahil839!


Fix handling of 'Required' fields for Newtonsoft

The existing azure-functions-openapi-extension is misalligned with Newtonsoft on which Required enumeration values are actually required and will generate a document incorrectly.
This change fixes the documentation as well as handling of the properties for generating OpenAPI documentation when using Newtonsoft JSON annotations
Fixes: https://github.com/Azure/azure-functions-openapi-extension/issues/336, https://github.com/Azure/azure-functions-openapi-extension/issues/402

@microsoft-github-policy-service agree

@justinyoo is there anything else necessary to get this change merged?

@William-Froelich I'm still trying to understand whether my interpretation of those properties AllowNull and DisallowNull is correct or not.
From the Newtonsoft.Json point of view, your change makes sense, but the OpenAPI document perspective, I'm still thinking my interpretation is more appropriate. required means the property MUST have value (null is not a value).

Sure. I'll add the tests as soon as i get some time this week.

@justinyoo , I didn't see any tests for TypeVisitor.cs in the codebase. What test class is being used to cover that class?

@justinyoo , I didn't see any tests for TypeVisitor.cs in the codebase. What test class is being used to cover that class?

Oh, never mind. It's already tested on both ObjectTypeVisitor and RecursiveObjectTypeVisitor.


Make decoration of $timeout optional

Looks like commit https://github.com/angular/protractor/commit/6c10378b9a4e7cae9ba491a63ae11f942c833100 has protractor decorating $timeout.. however this breaks all of my tests if I also am decorating $timeout in my application.

@juliemr @hankduan thoughts?

@hankduan we should probably offer an option to turn this off. Leave it on by default, it will just work for most projects and make debugging much better.

@infinityfarm Can you paste the error you see?

See https://github.com/angular/protractor/pull/2624

thanks @hankduan, @juliemr!

@infinityfarm Can you do me a favor and patch the PR and see if it works for you? Also, can you paste the error you see. I want to update the FAQ so people know to use this flag.

@hankduan The error I got was:
TypeError: $timeout.opt is not a function

where
$timeout.opt

is an extra method that I decorated $timeout with, and am using throughout my application.
I can confirm that the issue is solved by your PR https://github.com/hankduan/protractor/commit/c27a32e042841289bfeff30de1ef8aef9cea42fc, and adding
, untrackOutstandingTimeouts: true

to my protractor config.

Thanks @infinityfarm. Added a comment about this in the FAQ in the PR.

Will be released with next version!

@hankduan  just a thought:
May something like trackServices: [ '$http', '$timeout' ] be more useful?
And in case of @infinityfarm he will just say trackServices: [ '$http' ]


No HTML5 notification are displayed

Home Assistant release (hass --version):
0.28.2
Python release (python3 --version):
Python 3.5.2
Component/platform:
notify/html5
Description of problem:
When I try to send an example notify by developer tools, nothing happens.
This means that the notification is send correctly, but it don't arrive
Expected:
A notification appear on Desktop and smartphone.
Problem-relevant configuration.yaml entries and steps to reproduce:
notify:
  - platform: html5
    name: HTML5
    gcm_api_key: '...'
    gcm_sender_id: '...'

Register browser by the toggle button "Push Notifications"
Developer tools
Domani: notify / Service: html5 / Service Data: { "title": "Test", "message": "test message" }

Log:
INFO:homeassistant.components.http:Serving /manifest.json to <IP_ADDRESS> (auth: False)
INFO:homeassistant.components.http:Serving /api/notify.html5 to <IP_ADDRESS> (auth: True)
INFO:homeassistant.components.http:Serving /api/notify.html5 to <IP_ADDRESS> (auth: True)
INFO:homeassistant.components.http:Serving /api/services/notify/html5 to <IP_ADDRESS> (auth: True)
INFO:homeassistant.core:Bus:Handling <Event call_service[L]: service=html5, domain=notify, service_call_id=140582631847584-1, service_data=title=Test, message=test message>
INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1): android.googleapis.com
INFO:homeassistant.core:Bus:Handling <Event service_executed[L]: service_call_id=140582631847584-1>

Additional info:
Inside html5_push_registrations.conf there are the two device (desktop and smartphone) registered.
Thanks!

Just to verify

[ ] You are using Chrome and/or Firefox on any desktop platform, ChromeOS or Android.
[ ] Your Home Assistant instance is exposed to the world.
[ ] You have configured SSL for your Home Assistant. It doesn’t need to be configured in Home Assistant though, i.e. you can be running nginx in front of Home Assistant and this will still work.

*Yes: chromium on desktop and Chrome beta on android
*Yes: Behind Apache virtuale host with a ddns
*Yes: ssl is configurare on Apache.
Anyeay, outside my home (internet) I use an url like:
https://hass.domain.com

Is there some way to understand where is the issue?
Google console side, hass side or client?

I had exactly the same problem.  I could not find the sender id anywhere, it's nowhere to be found in the dev console (it is not the your-project-XXXXX, either the whole string nor the XXXXX part).  I signed up with the new service (firebase), as GCM seems to be gone.   I plugged that api key and sender ID into hass, and it worked fine.

mhhh...I don't figure out what you have done.
Anyway, I take it clicking on top-right triple dots / project setting / Project number.
I think this is the right value....

waooo...you have right, using FCM all works like a charm. Thanks


Add SkyWalking configuration samples

Please provide a description of this PR:
This PR adds a sample configuration for Apache SkyWalking, and I will add the corresponding integration documentation in istio.io that will use this sample configuration.

Hi @kezhenxu94. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@kezhenxu94 do you have a plan to add doc in istio.io? if so, would you please open an issue to track all those things?

I've opened this https://github.com/istio/istio.io/issues/11681


Transform functions with Algolia firestore extenstion

I am trying to utilise the transform functions option within Algolia. I have tried the following to no avail and I keep getting errors such as “unexpected token < in json”.
Basically, my posts collection has a userId field which I am trying to transform before sending to algolia. The transformed function should grab the userId field and output data from the users collection.
Below you can see the transform function I am testing out + errors.
I tried using the reference here: https://github.com/algolia/firestore-algolia-search. Is there a better example for how to use transformFunctions in algolia ?
{"severity":"ERROR","message":"Error when performing Algolia index FetchError: invalid json response body at https://accounts.google.com/ServiceLogin?passive=true&continue=https://uc.appengine.google.com/_ah/conflogin%3Fstate%3D~AJKiYcFxxGMUMqCfFkvubLonYRaXN50w_Kw_5BO6hlCr9LlWPxIaPm01U1D5BFEJR2W5JR-Q8ongrJkEq0TKW5n2ihpQV2fsjUTIDVdnrzDWqXPPEx6C20M3Z_QT4XokgmlYmS-QMqceAyKYJuVu3YrbfKddijM1rIc-rvF8z8WPfBqr4zjFjlu1tPjDHrsyl58Ic8grr-onj-vSrdsfM3id89TcPaADCP18cFoHU1zKHz6Kk3SY2SrUhsAi6gNM6OQrkgwtT83R reason: Unexpected token < in JSON at position 1\n    at /Users/xxxxx/.npm/_npx/0ca4ecfa9810ae5b/node_modules/node-fetch/lib/index.js:273:32\n    at processTicksAndRejections (internal/process/task_queues.js:93:5)\n    at async Object.exports.default (/Users/ddddd/.npm/_npx/0ca4ecfa9810ae5b/node_modules/firestore-algolia-search/lib/transform.js:29:26)\n    at async Object.extract [as default] (/Users/xxxx/.npm/_npx/0ca4ecfa9810ae5b/node_modules/firestore-algolia-search/lib/extract.js:42:21)\n    at async processQuery (/Users/xxx/.npm/_npx/0ca4ecfa9810ae5b/node_modules/firestore-algolia-search/lib/import/index.js:54:29) {\n  type: 'invalid-json'\n}"}
export const transformPosts = functions.region("us-central1").https.onCall(async (payload) => {
  const { userId: userIds } = payload
  const userId = await localFirestore.collection("users").doc(userIds).get()
  return { userId }
})

it seems that the post request is being redirected to a Google login page which returns html but the request is expecting json

@i14h okay do you know the right approach to creating a transform function that will work with algolia search ?

@dejiemiabata Try creating a function that allows unauthenticated invocations.

@smomin still not working

I am looking into it.  I will let you know my findings.

@smomin I noticed I had the PROJECT_ID was pointing to the wrong project. Sorry for the confusion here.


This library doesn't support *_by_lua_block

It would probably be helpful to see a stack trace that supports your statement.


Octokit::UnprocessableEntity in Communication::Website::Deuxfleurs::SetupJob@mice

Error in Osuny
Octokit::UnprocessableEntity in Communication::Website::Deuxfleurs::SetupJob@mice
POST https://api.github.com/repos/osunyorg/template/generate: 422 - Could not clone: Name already exists on this account
Error summary:
Could not clone: Name already exists on this account // See: https://docs.github.com/rest/repos/repos#create-a-repository-using-a-template
View on Bugsnag
Stacktrace
app/services/git/providers/github.rb:52 - init_from_template
app/services/git/repository.rb:54 - init_from_template
app/models/communication/website/with_deuxfleurs.rb:68 - deuxfleurs_create_github_repository
app/models/communication/website/with_deuxfleurs.rb:26 - deuxfleurs_setup_safely
app/jobs/communication/website/deuxfleurs/setup_job.rb:5 - execute
app/jobs/communication/website/base_job.rb:29 - perform

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been reopened in Bugsnag
Octokit::UnprocessableEntity in Communication::Website::Deuxfleurs::SetupJob@mice


AMBARI-26038: Fix WidgetResourceProviderTest failure

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.

@arshadmohammad  thanks for working on this. Any chance to give how it's broken..? and looks CI is failing, would want to take a look.?

@JiaLiangC would you like to merge this PR for 2.7.9 release.

@arshadmohammad thanks for working on this. Any chance to give how it's broken..? and looks CI is failing, would want to take a look.?

I'll run the tests locally to verify, and if there are no issues, I'll merge it in.

before this patch, test failed

after apply this patch, test successed

thanks @arshadmohammad


Move test_macros.h to test_macros_internal.h to reduce memory usage

Since test_macros.h is included in every test header, the compiler is forced to skip a lot of text when it reaches lock guard for the second time. In this PR, I moved the entire body to test_macros_internal.h. Because of this, when it comes to lock guard, only one include is skipped.
This basically reduces the memory usage and speeds up the compilation time a bit.
The command I used to compile tests:
time g++ -o tests/test_main.linuxbsd.template_debug.x86_64.o -c -std=gnu++17 -fno-exceptions -pipe -O2 -Wall -Wshadow -Wno-misleading-indentation -isystem thirdparty/glad -DDEBUG_ENABLED -DNDEBUG -DNO_EDITOR_SPLASH -DSOWRAP_ENABLED -DTOUCH_ENABLED -DFONTCONFIG_ENABLED -DALSA_ENABLED -DALSAMIDI_ENABLED -DPULSEAUDIO_ENABLED -D_REENTRANT -DDBUS_ENABLED -DSPEECHD_ENABLED -DXKB_ENABLED -DJOYDEV_ENABLED -DUDEV_ENABLED -DLINUXBSD_ENABLED -DUNIX_ENABLED -D_FILE_OFFSET_BITS=64 -DX11_ENABLED -DVULKAN_ENABLED -DRD_ENABLED -DGLES3_ENABLED -DCRASH_HANDLER_ENABLED -DMINIZIP_ENABLED -DBROTLI_ENABLED -DTHREADS_ENABLED -DCLIPPER2_ENABLED -DZSTD_STATIC_LINKING_ONLY -DUSE_VOLK -DVK_USE_PLATFORM_XLIB_KHR -DGLAD_ENABLED -DEGL_ENABLED -DDOCTEST_CONFIG_NO_EXCEPTIONS_BUT_WITH_ALL_ASSERTS -Ithirdparty/freetype/include -Ithirdparty/libpng -Ithirdparty/volk -Ithirdparty/vulkan -Ithirdparty/vulkan/include -Ithirdparty/zstd -Ithirdparty/zlib -Ithirdparty/clipper2/include -Ithirdparty/brotli/include -Ithirdparty/linuxbsd_headers -Iplatform/linuxbsd -I. tests/test_main.cpp

Peak memory usage:
Before: 3.1 GB
After: 2.48 GB
Compile time
Before:
real    1m20,729s
user    1m20,682s
sys     0m0,979s

After:
real    1m19,449s
user    1m19,353s
sys     0m1,033s

Why did you mass close your PRs?

@Zireael07 I've looked through my PRs and closed those that don't add any functionality or improve performance, or there are other PRs that did what I did and look better than mine.
For example, this PR is unnecessary, because I cannot reproduce the problem that this PR should solve on the version of gcc-12+ or clang.


added docker compose stack and github action

In which github, running as docker containers, starts action workflows as docker containers which download docker containers and run stuff in them. We need to go deeper. And I need to regain my sanity.

 docker-compose setup for dev environment


httpd24 on Yosemite Mac OS ( 10.10.3) occurs segmentation fault

I installed httpd24 by following command.
> brew install httpd24
I checked the version by following command and I think installation is correct
/usr/local/bin/apachectl -v Server version: Apache/2.4.12 (Unix) Server built:   May  1 2015 14:25:51
However, when I attempt to start httpd, I got following error.
/usr/local/bin/apachectl start /usr/local/bin/apachectl: line 79: 46371 Segmentation fault: 11  $HTTPD -k $ARGV
Does anyone have any idea that fix above error?

Is it still an issue with the latest version (brew upgrade httpd24)?

Also getting this, does any one have a solution?

@chrisdeeming are you using a fresh install ?

I got it sorted.
The only thing I did was remove all of the LoadModule directives for mod PHP. I was running multiple PHP versions and it may well be the fact that I had a mix of different SO files defined for the different versions.
So, I removed them all, replaced them with:
# Brew PHP LoadModule for `sphp` switcher LoadModule php5_module /usr/local/lib/libphp5.so #LoadModule php7_module /usr/local/lib/libphp7.so
And installed the PHP switcher:
chmod +x /usr/local/bin/sphp```

@chrisdeeming : Same Problem here, I try tu use the exact same PHP Switcher.

This formula was migrated to Homebrew/homebrew-core in https://github.com/Homebrew/homebrew-core/pull/17726. This tap is now deprecated.


Fixed collision with php8 'match' keyword

php version changes were also required, hence closing this.


Add option to have same randomization for all users and sessions

Checklist

[x] tests added
[x] commits conform to the Commit message format
[x] documentation updated

Squash commit message
Add option to have same randomization for all users and sessions. This can be used for tests where a high cache hit rate is desired.

Looks good!
Noticed that I accidently changed ` to ' when it comes to the instance flag... Please change it back, if possible.

ok fixed, docs re-generated now also.


[Bug Report] invalid asin result

Describe the bug
A clear and concise description of what the bug is.
The asin function returns an invalid value.
To Reproduce
Steps to reproduce the behavior:

Copy and past below code

# SPDX-FileCopyrightText: © 2023 Tenstorrent Inc.

# SPDX-License-Identifier: Apache-2.0

import torch
import pytest
import tt_lib
from tests.tt_eager.python_api_testing.unit_testing.backward_ops.utility_funcs import data_gen_pt_tt, compare_results

import ttnn
from tests.tt_eager.python_api_testing.sweep_tests import pytorch_ops

def data_gen_pt_tt(input_shapes, device, required_grad=False, val=1):
    pt_tensor = (torch.ones(input_shapes, requires_grad=required_grad) * val).bfloat16()
    tt_tensor = (
        tt_lib.tensor.Tensor(pt_tensor, tt_lib.tensor.DataType.BFLOAT16).to(tt_lib.tensor.Layout.TILE).to(device)
    )
    return pt_tensor, tt_tensor

@pytest.mark.parametrize(
    "input_shapes",
    (
        (torch.Size([1, 1, 32, 32])),
    ),
)
def test1(input_shapes, device):
    val = 90
    in_data, input_tensor = data_gen_pt_tt(input_shapes, device, True, val=val)

    print("input_tensor", input_tensor)

    golden_tensor = pytorch_ops.asin(in_data)
    tt_output_tensor_on_device = tt_lib.tensor.asin(input_tensor)

    print("tt_output_tensor_on_device", tt_output_tensor_on_device)
    print("golden_tensor", golden_tensor)

Run with pytest

input_tensor ttnn.Tensor([[[[90.00000, 90.00000,  ..., 90.00000, 90.00000],
               [90.00000, 90.00000,  ..., 90.00000, 90.00000],
               ...,
               [90.00000, 90.00000,  ..., 90.00000, 90.00000],
               [90.00000, 90.00000,  ..., 90.00000, 90.00000]]]], shape=Shape([1, 1, 32, 32]), dtype=DataType::BFLOAT16, layout=Layout::TILE)
tt_output_tensor_on_device ttnn.Tensor([[[[70039981404865953792.00000,<PHONE_NUMBER>4865953792.00000,  ...,<PHONE_NUMBER>4865953792.00000,<PHONE_NUMBER>4865953792.00000],
               [70039981404865953792.00000,<PHONE_NUMBER>4865953792.00000,  ...,<PHONE_NUMBER>4865953792.00000,<PHONE_NUMBER>4865953792.00000],
               ...,
               [70039981404865953792.00000,<PHONE_NUMBER>4865953792.00000,  ...,<PHONE_NUMBER>4865953792.00000,<PHONE_NUMBER>4865953792.00000],
               [70039981404865953792.00000,<PHONE_NUMBER>4865953792.00000,  ...,<PHONE_NUMBER>4865953792.00000,<PHONE_NUMBER>4865953792.00000]]]], shape=Shape([1, 1, 32, 32]), dtype=DataType::BFLOAT16, layout=Layout::TILE)
golden_tensor tensor([[[[nan, nan, nan,  ..., nan, nan, nan],
          [nan, nan, nan,  ..., nan, nan, nan],
          [nan, nan, nan,  ..., nan, nan, nan],
          ...,
          [nan, nan, nan,  ..., nan, nan, nan],
          [nan, nan, nan,  ..., nan, nan, nan],
          [nan, nan, nan,  ..., nan, nan, nan]]]], dtype=torch.bfloat16,
       grad_fn=<AsinBackward0>)

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Please complete the following environment information:

OS: [e.g. Ubuntu 20.04]
Version of software (eg. commit 2e5b96fae39079e7d120accec7b5f81c34f3924f)
Device: wormhole_b0

Additional context
Add any other context about the problem here.

@hschoi4448 Can you label whether the bugs belong forward or backward?
It will help us to categorise it.

@hschoi4448 Can you label whether the bugs belong forward or backward? It will help us to categorise it.

Got it. However, I can't find the 'forward' label.

@jliangTT Can we create a label name "forward" and use it? Also, It would be helpful for us if we know whether P0/P1.

let's make bug report from @hschoi4448 by default p1. And we can spend tuesday morning to look at the overall work priority and load-balance.

@hschoi4448 Can you add the labels for other issues created by you? (use the same labels added in this issue and assign it to @umadevimcw ). Thanks in advance !

@hschoi4448 @razorback3 https://github.com/tenstorrent/tt-metal/issues/8944, https://github.com/tenstorrent/tt-metal/issues/8945#issuecomment-2146247945, Please look at this comments for this issue

Need to update the test files with the supported range and test it after migration

@hschoi4448 Fix for this issue available in this PR (due to hardware limitations nan/inf are replaced with the numbers)
https://github.com/tenstorrent/tt-metal/pull/11243
Kindly review it.

Hi @hschoi4448
Merged https://github.com/tenstorrent/tt-metal/pull/11243, Can we close this issue?

Test file passes, Closing Issue


Fastlane init is creating only 2 folders "screenshots" and "metadata" no other files are created

New Issue Checklist

[ ] Updated fastlane to the latest version
[ ] I have read the Contribution Guidelines

Issue Description
Complete output when running fastlane, including the stack trace and command used

You can use: --capture_output as the last commandline argument to get that collected for you

[INSERT OUTPUT HERE]
Environment
Please run fastlane env and copy the output below. This will help us help you :+1:
If you used --capture_output option please remove this block - as it is already included there.
[INSERT OUTPUT HERE]

[18:06:10]: Writing to 'fastlane/metadata/en-US/description.txt'
[18:06:10]: Writing to 'fastlane/metadata/en-US/keywords.txt'
[18:06:10]: Writing to 'fastlane/metadata/en-US/release_notes.txt'
[18:06:10]: Ran into error while trying to connect to iTunes Connect / Dev Portal: undefined method []' for nil:NilClass [18:06:10]: Falling back to manual onboarding [18:06:10]: undefined method []' for nil:NilClass
[18:06:10]: An error occurred during the setup process. Falling back to manual setup!
[18:06:10]: App Identifier (com.krausefx.app): com.pholio
[18:10:25]: Created new file './fastlane/Appfile'. Edit it to manage your preferred app metadata information.
[18:10:25]: Do you want to setup 'deliver', which is used to upload app screenshots, app metadata and app updates to the App Store? This requires the app to be in the App
Store already (y/n)
y
[18:10:27]: Loading up 'deliver', this might take a few seconds
[18:10:27]: Login to iTunes Connect<EMAIL_ADDRESS>[18:10:34]: Login successful
+-----------------------+------------------------+
|             deliver 2.27.0 Summary             |
+-----------------------+------------------------+
| screenshots_path      | ./fastlane/screenshots |
| metadata_path         | ./fastlane/metadata    |
| username              |<EMAIL_ADDRESS>    |
| app_identifier        | com.pholio             |
| edit_live             | false                  |
| platform              | ios                    |
| skip_binary_upload    | false                  |
| skip_screenshots      | false                  |
| skip_metadata         | false                  |
| force                 | false                  |
| submit_for_review     | false                  |
| automatic_release     | false                  |
| dev_portal_team_id    | A7ZYC2V3HN             |
| overwrite_screenshots | false                  |
+-----------------------+------------------------+
[18:10:37]: Writing to 'fastlane/metadata/en-US/description.txt'
[18:10:37]: Writing to 'fastlane/metadata/en-US/keywords.txt'
[18:10:37]: Writing to 'fastlane/metadata/en-US/release_notes.txt'
[18:10:37]: Error occurred with the setup program! Reverting changes now!
[18:10:37]: Moving './fastlane/screenshots' to 'screenshots'
[18:10:37]: Moving './fastlane/metadata' to 'metadata'
[18:10:37]: Deleting the 'fastlane' folder
✅ fastlane environment ✅
Stack

Key
Value

OS
10.11.6

Ruby
2.2.4

Bundler?
false

Git
git version 2.10.1 (Apple Git-78)

Installation Source
~/.fastlane/bin/bundle/bin/fastlane

Host
Mac OS X 10.11.6 (15G31)

Ruby Lib Dir
~/.fastlane/bin/bundle/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
false

Is homebrew
true

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.2

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.27.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

slack-notifier
1.5.1

CFPropertyList
2.3.5

claide
1.0.1

colored2
3.1.2

nanaimo
0.2.3

xcodeproj
1.4.4

rouge
1.11.1

xcpretty
0.2.4

terminal-notifier
1.7.1

unicode-display_width
1.1.3

terminal-table
1.7.3

plist
3.2.0

public_suffix
2.0.5

addressable
2.5.0

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.5.0

babosa
1.0.2

colored
1.2

highline
1.7.8

commander-fastlane
4.4.4

excon
0.54.0

faraday
0.11.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20161129

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.0.1

gh_inspector
1.0.3

uber
0.0.15

representable
2.3.0

retriable
2.1.0

mime-types-data
3.2016.0521

mime-types
3.1

hurley
0.2

little-plugger
1.1.4

multi_json
1.12.1

logging
2.1.0

jwt
1.5.6

memoist
0.15.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
2.8.3

google-api-client
0.9.26

json
1.8.1

mini_magick
4.5.1

multi_xml
0.6.0

rubyzip
1.2.0

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.2.0

bundler
1.14.3

faraday_middleware
<IP_ADDRESS>

generated on: 2017-04-20


Incorrect type for selects

Describe the bug
A type error occurs when using the select function in selects.
To Reproduce
Steps to reproduce the behavior:

Create a select form element
Create a form using this library
Try to use the select function for this select
See the type error

Expected behavior
There should be no type error when using the select function.
Screenshots
None.
Environment (please complete the following information):

OS: [e.g. iOS]: Arch Linux
Browser [e.g. chrome, safari]: Chromium 117
Package Version [e.g. 22]: 2.0.1
Node Version [e.g. 18.2.1]: 20.0.0
Package Manager & Version [e.g. NPM 8.4.7]: 10.2.1

Additional context
None.

This issue has nothing to do with selects, but rather the way selects are handled in Material UI. The event typing does not come from React but is a custom event from Material UI itself, making typing the event correctly useless from the perspective of this library because it will always be different.
The only solution is to call the set function in a Material UI's select as onChange={(event) => set("field", event.target.value)}.


Add Code Coverage

This patch adds code coverage to the Open Price Feed system. The coverage will help us make sure we properly cover all cases. I am not currently sure how well this system will work with our immutables, but we'll see. Additionally, this may require extra resources from CircleCI since coverage is significantly more intense (we effectively trace all transactions).

Codecov Report

:exclamation: No coverage uploaded for pull request base (jflatow/uniswap-oracle@66cfc1d). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             jflatow/uniswap-oracle     #118   +/-   ##
=========================================================
  Coverage                          ?   91.59%
=========================================================
  Files                             ?        8
  Lines                             ?      583
  Branches                          ?      148
=========================================================
  Hits                              ?      534
  Misses                            ?       49
  Partials                          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66cfc1d...ad3b538. Read the comment docs.

Looks like you rebased and grabbed 2/3 of the commits on uniswap-polish, is that intended? If we are going to merge both we probably just want your last commit

Also FYI, the majority of the real changes occurred here: https://github.com/compound-finance/0x-monorepo/commit/ebceeab03b86468e0cb2b3919482c43413fd88a4


Locally, user address is not InetSocketAddress

java.lang.ClassCastException: io.netty.channel.local.LocalAddress cannot be cast to java.net.InetSocketAddress
	at net.minecraft.network.NetworkManager.getAddress(NetworkManager.java:50)
	at net.minecraft.network.NetHandlerPlayServer.getAddress(NetHandlerPlayServer.java:92)
	at com.laytonsmith.abstraction.sponge.entities.SpongeMCPlayer.getAddress(SpongeMCPlayer.java:92)
	at com.laytonsmith.core.functions.PlayerManagement$pinfo.exec(PlayerManagement.java:907)
	at com.laytonsmith.core.Script.eval(Script.java:352)
	at com.laytonsmith.core.Script.seval(Script.java:239)
	at com.laytonsmith.core.functions.DataHandling$eval.execs(DataHandling.java:3746)

Occurred when calling
player.getConnection().getAddress();

with the Forge version of Sponge running on the client in a single-player world.

Mind doing a version dump of Forge and Sponge?

Sponge was 1.8-1446-2.1DEV-490
Forge was <IP_ADDRESS>0

Netty doesn't use an actual socket to communicate if the channel is a local channel. It would be possible to simply return <IP_ADDRESS>, except for the fact that there is no port.

Was about to report this myself, really annoying. Need that port! D:
Still does it in the newest version of Sponge (sponge-1.8-1487-2.1DEV-525), and with the game 'Opened to LAN'.


Update/comment

[ ] UI Implement
[ ] Connect thumbup/thumbdown api
[x] Connect courseDetail, course comments api

#12


Update Get-HealthCheckFilesItemsFromLocation.ps1

A single xml report from a ExchangeDCCoreRatio broke the html report for me
This could be achieved with another $endname for the ExchangeDC-file like _{0}.txt so that --.xml does not match anymore
Issue:
A single xml report from a ExchangeDCCoreRatio run broke the html report for me
But that really could also be happened with a misnamed xml file, really
Reason:
Exempt the ExchangeDCCoreRatio xml files explicitely from being selected. We dont have any guess what other files are in there. But at least the files generated from our very own healthchecker should be taken care of.
Fix:
Short description of the fix
Narrowed down the selection of files,, probably doable otherwise if you guys have other preferences for exclusions.
Validation:
I manually tracked down what broke the creation and it came down to having 3 files for my 2 exchange boxes here. Excluded the ExchangeDCCoreRatio-File and everything was good again.
ExactErrorMessage
Cannot bind argument to parameter 'AnalyzeHtmlServerValues' because it is null.
... -AnalyzedHtmlServerValues $importData.HtmlServerValues

Build is failing due to:
RuleName                  Severity ScriptName                                Line Message
--------                  -------- ----------                                ---- -------
PSUseConsistentWhitespace Warning  Get-HealthCheckFilesItemsFromLocation.ps1 7    Use space before closing brace.

Please fix and then run .build\CodeFormatter.ps1 locally to confirm. Also, running CodeFormatter -Save might fix this for you. It can fix some problems automatically.

Formatting fixed


Fixes #2341:Hiding 4 fields in Edit mode

Fixes #2341:Hide the 4 fields below Nutri-Score in edit mode (they are not editable yet)

thanks for the PR @khaledosama007 :-)
I'll get someone to review it soon.
Can you have a look at https://github.com/openfoodfacts/openfoodfacts-androidapp/issues/2403 ?

thanks and congratulations on your 1st PR @khaledosama007 :-)
I'll get someone to review it soon.
Can you have a look at #2403 ?

ofcourse :)

thanks @Karljoones for the review.
Thanks @khaledosama007 :-)


chore: remove cross-fetch

All modern browsers have fetch and for the backend nodejs LTS has fetch. This removed 300kb+ from the package.
For the minority that still need this they can import the polyfill before this package for the same effect.

A quick fix for the failing browser test would be to add this back as a devDependancy and import it at the top of the test file.

@schehata curious what's holding up the CI. 🤔
Is there a reason the integration tests aren't completing?


Inconsistent archiving/removing of posts and connections

Archiving or removing something is both cumbersome and inconsistent.
Posts can be archived and reopened later. It's not possible to completely remove a post. To do so, it's necessary to expand the post, open the post detail view, open the context menu and select "Archive Post" - this involves at least 4 clicks and a view change.
Connections can only be declined or removed and can't be reopened. To do so, different actions are required depending on the type of connections. Some have a button in the footer that needs to be clicked (also see #1806 and #1807), some have a context menu with "Remove Connection", some have both, some have a context menu but no "Remove Connection" button.
At the very least, it should be able to close all connection types via the context menu.

I think one thing we definitely can do right now/soon is unify how connections are closed. Is the inconsistency you're referring to about suggestions (which have the "good match/bad match" buttons at the bottom instead of a context menu)?
Should we add a context menu for consistency's sake?

The inconsistencies here are that

conversations are closed in different ways, depending on their state (bad match for suggested conversations, context menu for existing conversations)
while closed needs can be reactivated, closed conversations are permanently gone.

The second point will probably be nontrivial to change, but the first point might be "fixed" by adding a context menu for suggested conversations?

Bumping because of inactivity


Support single server session

It would be great to be able to pass an already connected net.PacketConn to quic and create a single server session without the listener overhead.
This is already possible with go's TLS package.
Client:
	conn = tls.Client(innerConn, config)
	err = (conn.(*tls.Conn)).Handshake()

Server:
	conn = tls.Server(innerConn, config)
	err = (conn.(*tls.Conn)).Handshake()

We recently moved in the opposite direction by implementing the multiplexer and the packetHandlerMap, and using those for clients as well as servers.


🚀  request to update filter (wikipedia.org)

what does FutaFilter do currently?
$removeparam=/Campaign/i
(https://github.com/FutaGuard/FutaFilter/blob/master/removeparam.txt#L109)
supposed to be
Modified so that Wikipedia's show/hide button can work correctly.
reason
For example, on this page, the "hide" button is not working (not clickable).
Once I disable the FutaFilter removeparam list, then the button works (clickable) again.
Screenshots of expected and actual result

added to allow list
https://github.com/FutaGuard/FutaFilter/commit/b9ea61fca9ddbe0a8b1a242207f240fc968b4576


Updates client to deal with server payload

This should fix #3
Turns out the client was never updated to reflect the changes in Hypernova's new format where the batch results are in a results key rather than at the top-level.
This PR fixes that and updates our internal mock server to mimic Hypernova's response.
@ljharb

LGTM


DICOM module cannot be fully translated to French

These appear in English instead of French with Slicer-5.3.0-2023-04-01:

[ ] Module help text
[x] Reload & test section
[ ] "not started"
[ ] Patients:, Studies: , Series: filter row
[ ] Patient, Study, Series table column headings (Patient name, Patient ID, ..; Study date, ...)

"Reload and test" section is only for developers - it will remain in English.
Everything else should be translatable in Slicer Preview Releases downloaded on 2023-04-12 at 12pm EST or later.

done


Ability to change Group Name

Hi,
cannot see any explanation about how to change the group name. I've lot of Group 1,2,3, etc. that i'd like to rename but couldn't find a way so far

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e6669843-8752-7777-31e8-1d1e4ec96648
Version Independent ID: b7be0303-1882-621e-a630-32895aafa84d
Content: Use grouping in Power BI Desktop - Power BI
Content Source: powerbi-docs/desktop-grouping-visuals.md
Service: powerbi
Sub-service: powerbi-desktop
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Great question, @aguinaldo92! If you double-click the group name in the selection pane, it becomes editable and you can change the name. I'm adding to the author for review to consider adding that detail.

Hi @aguinaldo92 - I've added how to rename a group to that article. Good suggestion!


Does Lce Compute engine V0.3.1 has optimized BConv2D layer for x86_64 architecture?

I compile Lce Compute Engine V0.3.1 on Ubuntu 18.04.4 on a x86 computer? I use a two layer network to compare the model size(.tflite file size) and the speed between BNN and full precision network ? The speed  for BNN is slightly slower, and the model file size is bigger than the full precision network. The network I use is a two Conv2D layers  network. I just want to compare the speed and model size improvements intuitively.

Hi @dddf-fly, thanks for trying out LCE. Currently we have optimized code for 64-bit ARM processors (Aarch64). If you use LCE on x86 it will produce correct results but it will not be as fast.
The size of the .tflite file with a BConv2D layer should be a lot smaller than with a normal Conv2D layer, this is independent of the platform, so it sounds like something went wrong there. Could you open the .tflite file with netron and check if the BNN version was properly converted? The binary convolution should show up as a LceBconv2d layer.

I upload the two .tflite files. The file whose filename is  "my_model_f.tflite" represent the full precision network . The file whose filename is  "my_model_b.tflite" represent the binary weighted neural network . I use "larq.models.summary(model)" to use the network , the "memory (KB)" column  for the binary weighted network is smaller than the full precision network. But the file size(.tflite) for binary weighted neural network is bigger than that for full precision network.
my_model_.zip

Thanks for uploading the models. The reason that your model did not get smaller, is that in LCE's binary convolutions, the number of input-channels are first padded with 0's up to multiples of 32. So if you have 60 input channels, then it will add 4 zeroes and it will be stored as 64 channels.
In your case, you had 1 channel everywhere in the model, so that got stored as 32 channels, increasing the size dramatically.
I would recommend to always use at least 32 channels in binary convolutions. This is not only for storage but also for speed, because a binary convolution with 1 channel will run just as fast as a convolution with 32 channels, in LCE.

Thank you very much for your quick reply. It helped me a lot.


Access-Control-Allow-Origin header in env var, make API calls works too

It's easier to define Access-Control-Allow-Origin header directly in environnement variables on Cloudflare.
The proxy is also working for API calls

Wonderful PR, thank you!


ADD check to force finalizer deletion

Signed-off-by: acmenezes<EMAIL_ADDRESS>Description of PR
Added some logic to check on the existence of finalizers while performing operand cleanups and prevent CR from getting stuck and therefore blocking namespaces from getting deleted.
Fixes #341
Changes (required)

adding check to force finalizer and therefore CR deletion
and then double check its deletion

Checklist (required)

[x] I have reviewed and followed the contribution guidelines
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation if needed
[x] I have checked that my changes pass all tests

/lgtm

/approve


Fix memory spike during demo

This PR handle 2 things:

Address memory spike using demo.py. Now, doing inference on a 1024x2048 images takes 5G memory.

Address cuda OOM error using eval.py on a single GPU. Already test the code and get the same accuracy as before.

But the maximum GPU memory usage is 12.5G, still higher than most GPU cards's limit (like 1080 ti and titan). Need to investigate further to reduce the memory usage under 11GB.

Looks good!


Clarification of the Request-timeout for App GW v1 and v2

From this page we see that the Application Gateway v1 and v2 deliver an HTTP 502 error message for the clients when the request timeout exceeds the interval configured in the HTTP settings' Request time-out.
However, on this other document https://learn.microsoft.com/en-us/azure/application-gateway/http-response-codes#504--gateway-timeout it mentions that the Application Gateway v2 send a HTTP 504 when the time-out valued exceeds the configured.
Can you please clarify both documents and adjust what is needed?
Thank you

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 66c070b6-1c47-4c7f-b928-317a8c8b452f
Version Independent ID: 903191b7-6a01-1381-bf34-7353c2a8ece6
Content: Troubleshoot Bad Gateway errors - Azure Application Gateway
Content Source: articles/application-gateway/application-gateway-troubleshooting-502.md
Service: application-gateway
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

@Nott6170
502 Bad Gateway occurs when the backend pool is unhealthy. This is with respect to the health probe configuration. If the backend is unhealthy, no requests will be forwarded to them to begin with and App gateway would give a 502 error.
504 Request time out is when the backend pool is healthy, but still did not send a response within the specified time-out value which is configured in the Backend Setting. This is for an individual request-response.
Let me know if you require more details on this.

@Nott6170 since there are no active discussion on this thread, we shall archive it. Please tag me should you require further information.

Hi @KapilAnanth-MSFT can you confirm if this is the same behavior in App GW v1?
This is in regard to the document explicitly stating App GW v2 will return 504 Request time out when the backend pool is healthy, but it still did not send a response within the specified time-out value which is configured in the Backend Setting.


[GitHub Wiki] Code Example at NASM docs contain misleading comments

In the code example for the NASM documentation, the comments suggest that register esi corresponds to the first argument passed to the C function and edi the second but in reality the opposite is true.  I've confirmed this when playing with the "Multiply" Kata in NASM and the "Understanding Calling Conventions" section of this NASM tutorial also confirms this.

Resolved

Thanks! I'll fix the example kata as well.


allow templates and macros to include blanks in path

This small change will allow you to use template files containing blanks.

Thanks!


Random.hx redesign

Some stuff in this class is a bit flaky. Improve the pseudorandom generator, try some useful test cases, and look at cool libraries like chance.js for inspiration: http://chancejs.com/#weighted

Might use this little snippet for an example somewhere:
var randomresult:Array<String> = [];
var headsodds:Int = 90;
var tailsodds:Int = 10;
for (i in 0 ... 10000){
  randomresult.push(Random.weighted(["heads", "tails"], [headsodds, tailsodds]));
}

var heads:Int = 0;
var tails:Int = 0;
for (i in 0 ... 10000){
  if (randomresult[i] == "heads") heads++;
  if (randomresult[i] == "tails") tails++;
}

trace("Tossing a coin 10,000 times:");
trace("Odds set to " + headsodds + "/" + tailsodds);
trace("Heads: " + heads);
trace("Tails: " + tails);


Support for warnings and general reporting for Swagger validation

The primary usecase is to warn about URLs which were invoked but not part of the spec.  Some other things we could include would be to add the model in either another tab in the report or inline in steps for example.

Will swagger tab contain description and path params as well?
What is the primary use case?

@tsiq-karold any ideas on this one?

I think the use case I had in mind was for reporting when a particular <method, path> is not found in the spec.  We don't fail on that, just spit out a warning to the console but it would be nice to have it included in the report also.