ci: add pre-commit to lint for general file style

Signed-off-by: Jose Nino<EMAIL_ADDRESS>Description: this PR introduces pre-commit in order to lint for general file style. All of our linters are language specific. This linter adds common style, e.g newline at the end of files.
Risk Level: low
Testing: ran locally and added CI job.
Docs Changes: added docs in STYLE.md
Fixes #111

Output from CI:
##[section]Starting: Running pre-commit
==============================================================================
Task         : Command line
Description  : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
Version      : 2.151.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
==============================================================================
Generating script.
Script contents:
pre-commit run --all-files
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /Users/vsts/agent/2.153.2/work/_temp/1a88a8db-0b09-4848-8d48-f8847ea9d614.sh
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check docstring is first.................................................Passed
Check that executables have shebangs.....................................Passed
Check for merge conflicts................................................Passed
Check Yaml...............................................................Passed
Detect Private Key.......................................................Passed
Mixed line ending........................................................Passed
##[section]Finishing: Running pre-commit


fix: 🐛 Add missing validations in controllerTransfer proc

Description
controllerTransfer procedure used to throw the following error when trying to transfer the Asset to a self Portfolio -
asset.SenderSameAsReceiver:  Transfers to self are not allowed

This PR add the missing validation -> checks if the originPortfolio DID is same as the signingIdentity DID, it throws ErrorCode.UnmetPrerequisite with apt message
JIRA Link
DA-304
Checklist

[ ] Updated the Readme.md (if required) ?

:tada: This PR is included in version 14.0.0-beta.4 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 15.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 15.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


github action for js google style lint

To lint changes in the blockly-samples/plugins directory, you have to run npm run lint:fix. Note that linting cannot be currently done in the blockly-samples/examples directory.

To lint changes in the blockly-samples/plugins directory, you have to run npm run lint:fix. Note that linting cannot be currently done in the blockly-samples/examples directory.


External staking rewards

WIP in progress but wanted to get some feed back if possible cc @verminator23

Just an initial pass. I'll take another more detailed look soon. Unsure about the logic around multiple fund messages being executed. Could well be correct.
Previously the idea was to have two staking rewards contracts. This seems to handle both cw20 tokens and native tokens. Should we close open PRs for those other contracts?

Two contract is right, but different reason. One contract is for external rewards, ie rewards that are not the same as the staking token, and one contract is for auto compounding rewards that are the same token.

@ben2x4, let's clean up the unused variable linting errors and merge. :rocket:


Bluetooth: controller: ensure deferred PDU populations complete on time

Is your enhancement proposal related to a problem? Please describe.
Currently, PDU fields needing scheduling calculations inquired from ticker are deferred from prepare callback with the belief that these calculations complete and store valid values into PDUs by the start tick. There is no check at start tick for validity of the populated PDUs.
Describe the solution you'd like
Add a mechanism to detect at LLL event start the validity of PDU fields that where deferred for population.
Describe alternatives you've considered
None for now.
Additional context
Refer to https://github.com/zephyrproject-rtos/zephyr/pull/22237/files#r427153510

Fixed in https://github.com/zephyrproject-rtos/zephyr/pull/31477


[5.0] Add reset method to migrator to fix infinite loop.

This adds a reset method to the Migrator class in order to fix #8262 and move some migration logic out of the console command. Everything else still functions as before, but it is now possible to call migrate:reset with the --pretend option without it going into an infinite loop.
The tests associated with the console command were altered accordingly and new test were added for the reset method. Moving the logic into a new method also removed the reliance on a while(true) loop which wasn't easily testable.

I'm aware of the issues, working on it now...

Should be good to go now.


Support DDLX: CDS metadata extension

#1046

Hi,
Should the DDLX be serialized after the CDS or are the objects independent?

It seems that the objects are independent. At least I did get any errors during my tests.

looks good to me, thanks, merging


Why do we need to convert Keras model to tf-estimator in TF-2.0

I want to upgrade my custom estimator model from tf1 to tf2, and I follow this link to upgrade
They recommend the use tf.keras.estimator.model_to_estimator
TensorFlow-2.0 official doc

We recommend that you define your model using Keras, then use the tf.keras.estimator.model_to_estimator utility to turn your model into an estimator. The code below shows how to use this utility when creating and training an estimator.

In TF-1.x, in order to scale model to training on multiple workers, we convert Keras to tf-estimator.
But in TF-2.x, Keras already support distributed training well, so my question is

Why do we need to convert Keras to estimator in TF-2.0, dose any benefits?
Can we use low-level TF API (like tf.function()) to build custom estimator model ?

I can't find any example to build estimator model in TF-2.0 and without Keras.

Why do we need to convert Keras to estimator in TF-2.0, dose any benefits?

If you use infrastructure or other tooling that relies on Estimators, you can still build a Keras model and use model_to_estimator to convert the Keras model to an Estimator for use with downstream systems.

Can we use low-level TF API (like tf.function()) to build custom estimator model ?
As you can see here, Calling methods of Estimator will work while eager execution is enabled. However, the model_fn and input_fn is not executed eagerly, Estimator will switch to graph mode before calling all user-provided functions (incl. hooks), so their code has to be compatible with graph mode execution.
So using tf.function() here doesn't make sense.

Please correct me if you think I  have misinterpreted your question. Thanks!

@gowthamkpr Thanks for the reply.
Instead of use Keras, I want to build a custom estimator model that build by low-level TF API.

You can follow the following tutorial to write your custom estimator model.
If you have more questions please post them in stackoverflow as there is a bigger community to respond. Thanks!


fix: ignore normal lines

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@f90738c). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage        ?   36.90%
=======================================
  Files           ?        3
  Lines           ?       84
  Branches        ?        7
=======================================
  Hits            ?       31
  Misses          ?       53
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f90738c...d5b3865. Read the comment docs.


Fill Out README

Add a short description and include the instructions for this mini-project from UTA in the repo README.

Done!


Outdated Tutorial

Icons aren't in the same location
Missing a step 6
Needs more descriptions (ex. input = sensory, output = motor, interconnect = custom)

Suggestion: ability to click on the entire line to open the mappings box, instead of just clicking on the small box

Tutorials have been removed from brain visualizer and moved to FEAGI playground


allow debug toolbar path base to be configured

Allows path_prefix to be passed to the application.

unittests are failed :(

Coverage decreased (-0.08%) to 85.627% when pulling b8550877e86244485b72cb64fad829edcaa4d992 on sseg:path_prefix into ce53c61fe76a87cb99e6376241e506401fa489c5 on aio-libs:master.


Issue 16 37 Added DynamoDB and Karma Tracker

Addresses https://github.com/Splyth/slack_bot/issues/37 and https://github.com/Splyth/slack_bot/issues/16

Overhauled Praise and Shame commands
Added dynamodb connections
Added Basic Karma Tracker

@slokomisu @Zylox @Mill1893 @jedibob5 @2501 Please review

If it isn't too much extra work, it would be worth adding another command to be able to ask Lisa for how much karma you have.

I could add a my karma command. easily enough.
Do we also a want a karma stats command? Which would show who as the most karma kinda like how Moji shows it's list?

Added the my karma command

Not gonna add karma stats at the moment

@slokomisu @Mill1893 @Zylox mind giving this some 👀

@slokomisu done

I think something's off with my reviewer permissions? I approved these but it still only says 2 approvals instead of 3


400 Error when logging in from AzureAd with OIDC

Describe the bug
This might be related (or not) to issue #2955. We have configured OIDC auth from AzureAD for use with the gitops dashboard, and are receiving the following error on the pod when logging in with OIDC:
2023-06-12T14:29:22.930Z	ERROR	gitops.auth-server	auth/server.go:452	Failed to get cookie from request	{"error": "http: named cookie not present"}
2023-06-12T14:29:22.931Z	INFO	gitops	middleware/middleware.go:61	request error	{"uri": "/oauth2/userinfo", "status": 400}]

Environment

Weave-Gitops Version
v0.25.0

Flux Version

helm-controller: v0.34.1
image-automation-controller: rc-faf265e7
image-reflector-controller: v0.28.0
kustomize-controller: v1.0.0-rc.4
notification-controller: v1.0.0-rc.4
source-controller: v1.0.0-rc.5

Kubernetes version:

Server Version: version.Info{Major:"1", Minor:"27+", GitVersion:"v1.27.1-eks-2f008fe", GitCommit:"abfec7d7e55d56346a5259c9379dea9f56ba2926", GitTreeState:"clean", BuildDate:"2023-04-14T20:40:28Z", GoVersion:"go1.20.3", Compiler:"gc", Platform:"linux/amd64"}

To Reproduce
Steps to reproduce the behavior:

Setup OIDC app in AzureAD with correct scopes and claims which weave-dashboard is expecting
set up kubernetes secret named oidc-auth and populate with OIDC connection details which match what are configured on the OIDC app in AzureAD
Enable OIDC auth in the helm release
Login via OIDC

Expected behavior
Logs in with OIDC and sucessfully impersonate the weave-gitops-admin-cluster-role to see resources
Actual Behavior
No resouerces are shown in the UI and the pod logs the error in the above description
Additional Context (screenshots, logs, etc)
I also tried setting the .impersonationResourceNames to include the exact user I was logging in with but that lead to a different error:
2023-06-12T13:29:02.562Z	ERROR	gitops	clustersmngr/factory.go:566	failed filtering namespaces	{"cluster": "Default", "user"<EMAIL_ADDRESS>"error": "user namespace access: groups \"NewRelic_Admin\" is forbidden: User \"system:serviceaccount:weave-gitops:weave-gitops-service-account\" cannot impersonate resource \"groups\" in API group \"\" at the cluster scope"}

This error kept happening for every group that the user is a member of (ideally we do not want to have to create bindings in kubernetes fvor all groups because AD group memberships can change frequently and you don't want to have to keep updating the dashboard manifests every time).

Do you know how many groups you would expect to see?
It might be that the cookie we're setting is too large.

For my user I think it is about 8 groups (I'm not an AD admin at my org so I can't check directly). But for some other users it could be up to 20 groups I suppose (just guessing based on my own).

Are you authenticating your kubectl clients to Kubernetes successfully?
I can see this:
2023-06-12T14:29:22.930Z	ERROR	gitops.auth-server	auth/server.go:452	Failed to get cookie from request	{"error": "http: named cookie not present"}
Which strongly suggests that the browser is dropping the cookie for some reason, I have seen this when it was "too large" for the browser, i.e. around 4096bytes, but based on "8 groups" this feels unlikely.

Are you authenticating your kubectl clients to Kubernetes successfully?
I can see this:
2023-06-12T14:29:22.930Z	ERROR	gitops.auth-server	auth/server.go:452	Failed to get cookie from request	{"error": "http: named cookie not present"}
Which strongly suggests that the browser is dropping the cookie for some reason, I have seen this when it was "too large" for the browser, i.e. around 4096bytes, but based on "8 groups" this feels unlikely.

So, based on the error I added in the context section, I believe the authentication is happening successfully somewhere, because when I specify the .impersonationResourceNames in the helm chart values, I then get the error which talks about namespace access and it is reading one of the groups which my user is a member of (NewRelic_Admin). So I do think the authentication succeeds as far as being able to see the groups passed from AD at least when resource names are specified. But then as you can see from the slack conversation above, that error seems to be difficult to troubleshoot also .

I've pushed a change to log out the sizes of the tokens as we're setting them.
.impersonationResourceNames configures the RBAC to restrict the groups that the service account the pod runs as, can impersonate, with no restrictions, it should be fine.
There seem to be two possible issues, and my sense is that the first Failed to get cookie from request is the real cause of the problem.

Cool! Helm controller should pick up the latest image tag from the oci repository and deploy it automatically right? Or do I need to specify a specific image tag on my help release now for testing?

Sorry, it'll need to get reviewed and then merged and released.
Might want to track https://github.com/weaveworks/weave-gitops/pull/3785

@bigkevmcd i notice that the PR got merged yesterday but my pod is still running
2023-06-13T14:31:26.502Z	INFO	gitops	cmd/cmd.go:135	Version	{"version": "v0.25.0", "git-commit": "a03af4a9", "branch": "HEAD", "buildtime": "2023-06-07_20:15:00"}

even after deleting and recreating the pod. The helm repo looks like it didnt pick up a change yet
Spec:
  Interval:  1h0m0s
  Provider:  generic
  Timeout:   60s
  Type:      oci
  URL:       oci://ghcr.io/weaveworks/charts
Status:
  Conditions:
    Last Transition Time:  2023-05-11T06:57:41Z
    Message:               Helm repository is ready
    Observed Generation:   1
    Reason:                Succeeded
    Status:                True
    Type:                  Ready
  Observed Generation:     1
Events:                    <none>]

am I waiting for something else to happen first?

Sorry, it'll need to get reviewed and then merged and released.

We haven't yet "released" the change, it's merged but not yet released, you can however build an image from the source if you want to.
We are organising a release which would include this fix.

The logging went out in yesterday's release https://github.com/weaveworks/weave-gitops/releases/tag/v0.26.0
If it turns out to be the size of the cookie, then we can prioritise a fix, if not, I'm not entirely sure what's going on, except for trying replicate it.

The logging went out in yesterday's release https://github.com/weaveworks/weave-gitops/releases/tag/v0.26.0
If it turns out to be the size of the cookie, then we can prioritise a fix, if not, I'm not entirely sure what's going on, except for trying replicate it.

oh sweet! sorry i didnt notice the release, i only checked yesterday morning but maybe it hadnt happened yet. let me deploy the latest version and get back to you

The logging went out in yesterday's release https://github.com/weaveworks/weave-gitops/releases/tag/v0.26.0
If it turns out to be the size of the cookie, then we can prioritise a fix, if not, I'm not entirely sure what's going on, except for trying replicate it.

So it did! i actually didnt notice the new version on the bottom of my UI. So currently it's running on version 0.26.0. So my understanding is that it should now be logging the size of the cookie somewhere for me to check, is that correct?

OK so it actually looks like things are working as expected? The missing cookie error seems to have dissapeared however i still dont see any data in the dashboard when i log in with OIDC:
2023-06-22T15:21:08.270Z	DEBUG	gitops.auth-server	auth/jwt.go:77	attempt to read token from auth header
2023-06-22T15:21:08.270Z	DEBUG	gitops.auth-server	auth/jwt.go:54	parsing cookie JWT token	{"claimsConfig": {"Username":"email","Groups":"groups"}}
2023-06-22T15:21:08.271Z	DEBUG	gitops.auth-server	auth/jwt.go:107	parsed JWT token	{"expires": "2023-06-22T16:20:59.000Z"}
2023-06-22T15:21:08.271Z	DEBUG	gitops.auth-server	auth/jwt.go:162	Found principal	{"user"<EMAIL_ADDRESS>"groups": [], "tokenLength": 0, "method": "*auth.JWTCookiePrincipalGetter"}
2023-06-22T15:21:08.271Z	DEBUG	gitops	middleware/middleware.go:57	request success	{"uri": "/v1/objects", "status": 200}
2023-06-22T15:21:08.271Z	DEBUG	gitops.auth-server	auth/jwt.go:77	attempt to read token from auth header
2023-06-22T15:21:08.271Z	DEBUG	gitops.auth-server	auth/jwt.go:54	parsing cookie JWT token	{"claimsConfig": {"Username":"email","Groups":"groups"}}
2023-06-22T15:21:08.272Z	DEBUG	gitops.auth-server	auth/jwt.go:107	parsed JWT token	{"expires": "2023-06-22T16:20:59.000Z"}
2023-06-22T15:21:08.272Z	DEBUG	gitops.auth-server	auth/jwt.go:162	Found principal	{"user"<EMAIL_ADDRESS>"groups": [], "tokenLength": 0, "method": "*auth.JWTCookiePrincipalGetter"}
2023-06-22T15:21:08.272Z	DEBUG	gitops	middleware/middleware.go:57	request success	{"uri": "/v1/objects", "status": 200}

Only thing that confuses me is the token length says 0?

You should be seeing setting ID token cookie and setting access token cookie
https://github.com/weaveworks/weave-gitops/pull/3785/files
The thinking there is that we log out as we send it, and if the browser drops it, we'll be able to tell?
Those are parsing it, perhaps earlier in the logs when you're authing that will be logged?

Yep, just found it. And also, i found some other errors which seemed to go away magically.. originally it seemed like it was looking for the wrong provider and then all of a sudden it kicked into gear and worked...

Logs
```
2023-06-22T15:20:58.508Z	DEBUG	gitops	middleware/middleware.go:57	request success	{"uri": "/v1/featureflags?", "status": 200}
2023-06-22T15:20:58.509Z	ERROR	gitops.auth-server	auth/server.go:482	failed to parse user ID token	{"error": "oidc: id token issued by a different provider, expected "https://login.microsoftonline.com/7aed272c-2c29-4bb0-832b-eec7122ac2df/v2.0\" got """}
2023-06-22T15:20:58.509Z	INFO	gitops	middleware/middleware.go:61	request error	{"uri": "/oauth2/userinfo", "status": 401}
2023-06-22T15:20:58.600Z	ERROR	gitops.auth-server	auth/server.go:482	failed to parse user ID token	{"error": "oidc: id token issued by a different provider, expected "https://login.microsoftonline.com/7aed272c-2c29-4bb0-832b-eec7122ac2df/v2.0\" got """}
2023-06-22T15:20:58.600Z	INFO	gitops	middleware/middleware.go:61	request error	{"uri": "/oauth2/userinfo", "status": 401}
2023-06-22T15:20:59.506Z	DEBUG	gitops	middleware/middleware.go:57	request success	{"uri": "/oauth2?return_url=https%3A%2F%2Fweave-gitops.eng-dev.dare.global", "status": 303}
2023-06-22T15:20:59.972Z	DEBUG	gitops.auth-server	auth/server.go:369	setting ID token cookie	{"size": 1247}
2023-06-22T15:20:59.972Z	DEBUG	gitops.auth-server	auth/server.go:371	setting access token cookie	{"size": 2151}
2023-06-22T15:20:59.972Z	DEBUG	gitops.auth-server	auth/server.go:376	setting refresh token cookie	{"size": 0}
2023-06-22T15:20:59.972Z	DEBUG	gitops	middleware/middleware.go:57	request success	{"uri": "/oauth2/callback?code=0.", "status": 303}
2023-06-22T15:21:00.010Z	DEBUG	gitops	middleware/middleware.go:57	request success	{"uri": "/", "status": 200}
2023-06-22T15:21:00.240Z	DEBUG	gitops	middleware/middleware.go:57	request success	{"uri": "/v1/featureflags?", "status": 200}
2023-06-22T15:21:00.242Z	DEBUG	gitops	middleware/middleware.go:57	request success	{"uri": "/oauth2/userinfo", "status": 200}
2023-06-22T15:21:00.283Z	DEBUG	gitops.auth-server	auth/jwt.go:77	attempt to read token from auth header
2023-06-22T15:21:00.283Z	DEBUG	gitops	middleware/middleware.go:57	request success	{"uri": "/oauth2/userinfo", "status": 200}
2023-06-22T15:21:00.283Z	DEBUG	gitops.auth-server	auth/jwt.go:54	parsing cookie JWT token	{"claimsConfig": {"Username":"email","Groups":"groups"}}
2023-06-22T15:21:00.284Z	DEBUG	gitops.auth-server	auth/jwt.go:107	parsed JWT token	{"expires": "2023-06-22T16:20:59.000Z"}
2023-06-22T15:21:00.284Z	DEBUG	gitops.auth-server	auth/jwt.go:162	Found principal	{"user"<EMAIL_ADDRESS>"groups": [], "tokenLength": 0, "method": "*auth.JWTCookiePrincipalGetter"}
2023-06-22T15:21:00.291Z	DEBUG	gitops.auth-server	auth/jwt.go:77	attempt to read token from auth header
2023-06-22T15:21:00.291Z	DEBUG	gitops.auth-server	auth/jwt.go:54	parsing cookie JWT token	{"claimsConfig": {"Username":"email","Groups":"groups"}}
2023-06-22T15:21:00.291Z	DEBUG	gitops.auth-server	auth/jwt.go:77	attempt to read token from auth header
2023-06-22T15:21:00.291Z	DEBUG	gitops.auth-server	auth/jwt.go:54	parsing cookie JWT token	{"claimsConfig": {"Username":"email","Groups":"groups"}}
2023-06-22T15:21:00.292Z	DEBUG	gitops.auth-server	auth/jwt.go:107	parsed JWT token	{"expires": "2023-06-22T16:20:59.000Z"}
2023-06-22T15:21:00.292Z	DEBUG	gitops.auth-server	auth/jwt.go:162	Found principal	{"user"<EMAIL_ADDRESS>"groups": [], "tokenLength": 0, "method": "*auth.JWTCookiePrincipalGetter"}
2023-06-22T15:21:00.292Z	DEBUG	gitops.auth-server	auth/jwt.go:107	parsed JWT token	{"expires": "2023-06-22T16:20:59.000Z"}
2023-06-22T15:21:00.292Z	DEBUG	gitops.auth-server	auth/jwt.go:162	Found principal	{"user"<EMAIL_ADDRESS>"groups": [], "tokenLength": 0, "method": "*auth.JWTCookiePrincipalGetter"}
</details>

I wonder if these log entries are one of the issues here https://github.com/coreos/go-oidc/issues/344
2023-06-22T15:20:58.509Z ERROR gitops.auth-server auth/server.go:482 failed to parse user ID token {"error": "oidc: id token issued by a different provider, expected "[https://login.microsoftonline.com/7aed272c-2c29-4bb0-832b-eec7122ac2df/v2.0\](https://login.microsoftonline.com/7aed272c-2c29-4bb0-832b-eec7122ac2df/v2.0%5C)" got """}
2023-06-22T15:20:58.509Z INFO gitops middleware/middleware.go:61 request error {"uri": "/oauth2/userinfo", "status": 401}
2023-06-22T15:20:58.600Z ERROR gitops.auth-server auth/server.go:482 failed to parse user ID token {"error": "oidc: id token issued by a different provider, expected "[https://login.microsoftonline.com/7aed272c-2c29-4bb0-832b-eec7122ac2df/v2.0\](https://login.microsoftonline.com/7aed272c-2c29-4bb0-832b-eec7122ac2df/v2.0%5C)" got """}

Gives us something to go on, at least we can rule out the size of the token!

Ok cool, so i'll leave this with you guys for now then? I guess it really is a possibility that AzureAD just isnt supported right now. In the mean-time we will figure out an alternative auth method to front the dashboard with. Is it possible to disable all auth? So you don't even see the login screen? So that we can put our own auth method in front of the URL instead?

Another one having the same issue with Azure.
2023-07-03T10:32:30.756Z	DEBUG	gitops.auth-server	auth/server.go:369	setting ID token cookie	{"size": 7252}
2023-07-03T10:32:30.756Z	DEBUG	gitops.auth-server	auth/server.go:371	setting access token cookie	{"size": 2342}
2023-07-03T10:32:30.756Z	DEBUG	gitops.auth-server	auth/server.go:376	setting refresh token cookie	{"size": 957}

@angelbarrera92 thanks, that looks like the cookie is too big, it likely includes all the groups that you're a member of.
We need to shift to a session-store based approach for storing cookies, which is non-trivial, but it would mean that we'd issue shorter cookies, and store the details in-browser, it's not currently scheduled, but this is an indication that we need to bump it up the priority list.

Hi @bigkevmcd
I can confirm we are having the same issue and the cookie is definitely too big.  From the devtools in MS Edge:
Malformed response cookie:
 This attempt to set a cookie via a set-cookie header was blocked because the cookie was too large. The combined size of the name and value must be less than or equal to 4096 characters

logs from our deployment:
2023-07-05T19:51:11.030Z        INFO    gitops  cmd/cmd.go:135  Version {"version": "v0.26.0", "git-commit": "e97d8ae4", "branch": "HEAD", "buildtime": "2023-06-21_14:11:02"}
2023-07-05T19:51:12.689Z        DEBUG   gitops  auth/init.go:17 Registering authentication methods      {"methods": ["oidc"]}
2023-07-05T19:51:12.695Z        DEBUG   gitops  auth/init.go:49 OIDC config     {REDACTED}
2023-07-05T19:51:12.832Z        INFO    gitops  cmd/cmd.go:186  Registering auth routes
2023-07-05T19:51:12.859Z        INFO    gitops  cmd/cmd.go:223  Using cached clients    {"enabled": false}
2023-07-05T19:51:12.859Z        INFO    gitops  clustersmngr/factory.go:223     Use user client for namespaces  {"enabled": false}
2023-07-05T19:51:12.861Z        INFO    gitops  cmd/cmd.go:284  Starting server {"address": "<IP_ADDRESS>:9001"}
2023-07-05T19:51:12.861Z        INFO    gitops  cmd/cmd.go:341  TLS connections disabled
2023-07-05T19:51:12.934Z        INFO    gitops  clustersmngr/factory.go:398     Clearing namespace caches
2023-07-05T19:51:13.185Z        DEBUG   gitops  middleware/middleware.go:57     request success {"uri": "/", "status": 200}
2023-07-05T19:51:20.404Z        DEBUG   gitops  middleware/middleware.go:57     request success {"uri": "/", "status": 200}
2023-07-05T19:52:00.905Z        ERROR   gitops.auth-server      auth/server.go:456      failed to get ID Token cookie from request      {"error": "http: named cookie not present"}
2023-07-05T19:52:00.905Z        INFO    gitops  middleware/middleware.go:61     request error   {"uri": "/oauth2/userinfo", "status": 400}
2023-07-05T19:52:00.913Z        DEBUG   gitops  middleware/middleware.go:57     request success {"uri": "/v1/featureflags?", "status": 200}
2023-07-05T19:52:01.066Z        ERROR   gitops.auth-server      auth/server.go:456      failed to get ID Token cookie from request      {"error": "http: named cookie not present"}
2023-07-05T19:52:01.066Z        INFO    gitops  middleware/middleware.go:61     request error   {"uri": "/oauth2/userinfo", "status": 400}
2023-07-05T19:52:05.241Z        DEBUG   gitops  middleware/middleware.go:57     request success {"uri": "/oauth2?return_url=http%3A%2F%2Flocalhost%3A9001", "status": 303}
2023-07-05T19:52:06.312Z        DEBUG   gitops.auth-server      auth/server.go:369      setting ID token cookie {"size": 4710}
2023-07-05T19:52:06.313Z        DEBUG   gitops.auth-server      auth/server.go:371      setting access token cookie     {"size": 2272}
2023-07-05T19:52:06.313Z        DEBUG   gitops.auth-server      auth/server.go:376      setting refresh token cookie    {"size": 1124}
2023-07-05T19:52:06.313Z        DEBUG   gitops  middleware/middleware.go:57     request success {"uri": "/oauth2/callback?code=0.REDACTED, "status": 303}
2023-07-05T19:52:06.357Z        DEBUG   gitops  middleware/middleware.go:57     request success {"uri": "/", "status": 200}
2023-07-05T19:52:07.469Z        DEBUG   gitops  middleware/middleware.go:57     request success {"uri": "/v1/featureflags?", "status": 200}
2023-07-05T19:52:07.470Z        ERROR   gitops.auth-server      auth/server.go:456      failed to get ID Token cookie from request      {"error": "http: named cookie not present"}
2023-07-05T19:52:07.470Z        INFO    gitops  middleware/middleware.go:61     request error   {"uri": "/oauth2/userinfo", "status": 400}
2023-07-05T19:52:07.655Z        ERROR   gitops.auth-server      auth/server.go:456      failed to get ID Token cookie from request      {"error": "http: named cookie not present"}
2023-07-05T19:52:07.655Z        INFO    gitops  middleware/middleware.go:61     request error   {"uri": "/oauth2/userinfo", "status": 400}
2023-07-05T19:52:10.403Z        DEBUG   gitops  middleware/middleware.go:57     request success {"uri": "/", "status": 200}

We didn't see this on "version": "v0.22.0". Not sure if something changed with the app or the token was just smaller at that stage.
Using Azure AD with these extra secret configs:
  --from-literal=customScopes='openid,offline_access,email'
  --from-literal=claimGroups=roles

Hi @adamshawvipps ahh...ok, I can't think of anything that would've changed in between v0.22.0 other than we added debug logging to try and find out if this was the issue.
We'll discuss it internally, and see what we can do to prioritise a solution to this.

@bigkevmcd thanks for looking into it
I just tried a few more versions. I had to go back to v0.17.0 to get a successful login so we were probably just lucky with the token size previously

We are seeing the exact same issue (size between 5k and 10k)

We have a fix that's being tested just now before release that will hopefully get this solved.

@oarset @angelbarrera92 @m477r1x We have released a change that should solve this.
https://github.com/weaveworks/weave-gitops/releases/tag/v0.31.0
Please feel free to reopen this issue if you are still experiencing the problem.
We are looking to add support for external session storage, so if this is something that you want support for, please feel free to open an issue.

Quick test, it works :) I'll keep you posted!
Thanks for the quick response!


Upgrading to 2.2.0, enabling LDAP support will cause circular dependencies error

[x] I have checked the discussions
[x] I have searched the issues of this repository and believe that this is not a duplicate.
[x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Upgrading to portal 2.2.0.
Enable LDAP support.
Set spring.main.allow-circular-references=true

Expected behavior
Application should start normally.
Additional Details & Logs
Error Logs
OpenJDK 64-Bit Server VM warning: UseCMSCompactAtFullCollection is deprecated and will likely be removed in a future release.
OpenJDK 64-Bit Server VM warning: CMSFullGCsBeforeCompaction is deprecated and will likely be removed in a future release.
_                _ _
/ \   _ __   ___ | | | ___
/ _ \ | '_ \ / _ | | |/ _
/ ___ | |) | () | | | () |
//   _\ ./ _/|||___/
|_|
:: Spring Boot ::  (v2.7.11)
2023-12-18 15:22:42.874  INFO 1 --- [           main] c.c.f.apollo.portal.PortalApplication    : Starting PortalApplication v2.2.0 using Java 1.8.0_342 on apollo-portal-7cdb5f5f76-9jw5p with PID 1 (/apollo-portal/apollo-portal-2.2.0.jar started by root in /apollo-portal)
2023-12-18 15:22:42.877  INFO 1 --- [           main] c.c.f.apollo.portal.PortalApplication    : The following 3 profiles are active: "github", "mysql", "ldap"
2023-12-18 15:22:44.473  INFO 1 --- [           main] .s.d.r.c.RepositoryConfigurationDelegate : Multiple Spring Data modules found, entering strict repository configuration mode
2023-12-18 15:22:44.476  INFO 1 --- [           main] .s.d.r.c.RepositoryConfigurationDelegate : Bootstrapping Spring Data JPA repositories in DEFAULT mode.
2023-12-18 15:22:44.636  INFO 1 --- [           main] .s.d.r.c.RepositoryConfigurationDelegate : Finished Spring Data repository scanning in 148 ms. Found 16 JPA repository interfaces.
2023-12-18 15:22:45.066  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'httpMessageConverterConfiguration' of type [com.ctrip.framework.apollo.common.controller.HttpMessageConverterConfiguration$$EnhancerBySpringCGLIB$$3244aed] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.344  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'messageConverters' of type [com.ctrip.framework.apollo.common.controller.HttpMessageConverterConfiguration$1] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.378  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean '(inner bean)#5ed731d0' of type [org.springframework.beans.factory.config.PropertiesFactoryBean] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.379  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean '(inner bean)#5ed731d0' of type [java.util.Properties] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.379  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean '(inner bean)#62fe6067' of type [org.springframework.data.repository.core.support.PropertiesBasedNamedQueries] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.381  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean '(inner bean)#33e01298' of type [org.springframework.data.repository.core.support.RepositoryFragmentsFactoryBean] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.382  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean '(inner bean)#33e01298' of type [org.springframework.data.repository.core.support.RepositoryComposition$RepositoryFragments] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.384  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.boot.autoconfigure.sql.init.DataSourceInitializationConfiguration' of type [org.springframework.boot.autoconfigure.sql.init.DataSourceInitializationConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.385  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.boot.autoconfigure.jdbc.DataSourceConfiguration$Hikari' of type [org.springframework.boot.autoconfigure.jdbc.DataSourceConfiguration$Hikari] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.406  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'spring.datasource-org.springframework.boot.autoconfigure.jdbc.DataSourceProperties' of type [org.springframework.boot.autoconfigure.jdbc.DataSourceProperties] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.435  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'dataSource' of type [com.zaxxer.hikari.HikariDataSource] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.439  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'spring.sql.init-org.springframework.boot.autoconfigure.sql.init.SqlInitializationProperties' of type [org.springframework.boot.autoconfigure.sql.init.SqlInitializationProperties] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.443  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'dataSourceScriptDatabaseInitializer' of type [org.springframework.boot.autoconfigure.sql.init.SqlDataSourceScriptDatabaseInitializer] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.452  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'spring.jpa-org.springframework.boot.autoconfigure.orm.jpa.JpaProperties' of type [org.springframework.boot.autoconfigure.orm.jpa.JpaProperties] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.457  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'spring.jpa.hibernate-org.springframework.boot.autoconfigure.orm.jpa.HibernateProperties' of type [org.springframework.boot.autoconfigure.orm.jpa.HibernateProperties] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.460  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.boot.autoconfigure.jdbc.metadata.DataSourcePoolMetadataProvidersConfiguration$HikariPoolDataSourceMetadataProviderConfiguration' of type [org.springframework.boot.autoconfigure.jdbc.metadata.DataSourcePoolMetadataProvidersConfiguration$HikariPoolDataSourceMetadataProviderConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.461  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'hikariPoolDataSourceMetadataProvider' of type [org.springframework.boot.autoconfigure.jdbc.metadata.DataSourcePoolMetadataProvidersConfiguration$HikariPoolDataSourceMetadataProviderConfiguration$$Lambda$465/1705665942] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.467  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.boot.autoconfigure.orm.jpa.HibernateJpaConfiguration' of type [org.springframework.boot.autoconfigure.orm.jpa.HibernateJpaConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.546  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'jpaVendorAdapter' of type [org.springframework.orm.jpa.vendor.HibernateJpaVendorAdapter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.550  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'entityManagerFactoryBuilder' of type [org.springframework.boot.orm.jpa.EntityManagerFactoryBuilder] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:45.565  INFO 1 --- [           main] com.zaxxer.hikari.HikariDataSource       : HikariPool-1 - Starting...
2023-12-18 15:22:45.814  INFO 1 --- [           main] com.zaxxer.hikari.HikariDataSource       : HikariPool-1 - Start completed.
2023-12-18 15:22:45.907  INFO 1 --- [           main] o.hibernate.jpa.internal.util.LogHelper  : HHH000204: Processing PersistenceUnitInfo [name: default]
2023-12-18 15:22:45.992  INFO 1 --- [           main] org.hibernate.Version                    : HHH000412: Hibernate ORM core version 5.6.15.Final
2023-12-18 15:22:46.312  INFO 1 --- [           main] o.hibernate.annotations.common.Version   : HCANN000001: Hibernate Commons Annotations {5.1.2.Final}
2023-12-18 15:22:46.490  INFO 1 --- [           main] org.hibernate.dialect.Dialect            : HHH000400: Using dialect: org.hibernate.dialect.MySQL8Dialect
2023-12-18 15:22:46.616  WARN 1 --- [           main] org.hibernate.cfg.AnnotationBinder       : HHH000503: A class should not be annotated with both @Inheritance and @MappedSuperclass. @Inheritance will be ignored for: com.ctrip.framework.apollo.common.entity.BaseEntity.
2023-12-18 15:22:46.718  WARN 1 --- [           main] org.hibernate.cfg.AnnotationBinder       : HHH000503: A class should not be annotated with both @Inheritance and @MappedSuperclass. @Inheritance will be ignored for: com.ctrip.framework.apollo.audit.entity.BaseEntity.
2023-12-18 15:22:47.797  INFO 1 --- [           main] o.h.e.t.j.p.i.JtaPlatformInitiator       : HHH000490: Using JtaPlatform implementation: [org.hibernate.engine.transaction.jta.platform.internal.NoJtaPlatform]
2023-12-18 15:22:47.811  INFO 1 --- [           main] j.LocalContainerEntityManagerFactoryBean : Initialized JPA EntityManagerFactory for persistence unit 'default'
2023-12-18 15:22:47.815  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'entityManagerFactory' of type [org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:47.816  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'entityManagerFactory' of type [com.sun.proxy.$Proxy133] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:47.841  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean '(inner bean)#4763c727' of type [com.sun.proxy.$Proxy134] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:47.861  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'jpaMappingContext' of type [org.springframework.data.jpa.repository.config.JpaMetamodelMappingContextFactoryBean] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:47.861  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'jpaMappingContext' of type [org.springframework.data.jpa.mapping.JpaMetamodelMappingContext] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:48.176  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'serverConfigRepository' of type [org.springframework.data.jpa.repository.support.JpaRepositoryFactoryBean] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:48.177  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'serverConfigRepository' of type [com.sun.proxy.$Proxy137] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:48.182  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'portalDBPropertySource' of type [com.ctrip.framework.apollo.portal.service.PortalDBPropertySource] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:48.214  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.boot.autoconfigure.transaction.TransactionAutoConfiguration' of type [org.springframework.boot.autoconfigure.transaction.TransactionAutoConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:48.221  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'spring.transaction-org.springframework.boot.autoconfigure.transaction.TransactionProperties' of type [org.springframework.boot.autoconfigure.transaction.TransactionProperties] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:48.222  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'platformTransactionManagerCustomizers' of type [org.springframework.boot.autoconfigure.transaction.TransactionManagerCustomizers] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:48.230  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'transactionManager' of type [org.springframework.orm.jpa.JpaTransactionManager] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:48.432  INFO 1 --- [           main] c.c.f.a.p.s.PortalDBPropertySource       : Load config from DB : apollo.portal.envs = dev
2023-12-18 15:22:48.432  INFO 1 --- [           main] c.c.f.a.p.s.PortalDBPropertySource       : Load config from DB : organizations = [{"orgId":"TEST1","orgName":"样例部门1"},{"orgId":"TEST2","orgName":"样例部门2"}]. Old value = null
2023-12-18 15:22:48.432  INFO 1 --- [           main] c.c.f.a.p.s.PortalDBPropertySource       : Load config from DB : superAdmin = apollo. Old value = null
2023-12-18 15:22:48.432  INFO 1 --- [           main] c.c.f.a.p.s.PortalDBPropertySource       : Load config from DB : api.readTimeout = 10000. Old value = null
2023-12-18 15:22:48.432  INFO 1 --- [           main] c.c.f.a.p.s.PortalDBPropertySource       : Load config from DB : consumer.token.salt = someSalt. Old value = null
2023-12-18 15:22:48.432  INFO 1 --- [           main] c.c.f.a.p.s.PortalDBPropertySource       : Load config from DB : admin.createPrivateNamespace.switch = true. Old value = null
2023-12-18 15:22:48.432  INFO 1 --- [           main] c.c.f.a.p.s.PortalDBPropertySource       : Load config from DB : configView.memberOnly.envs = dev. Old value = null
2023-12-18 15:22:48.432  INFO 1 --- [           main] c.c.f.a.p.s.PortalDBPropertySource       : Load config from DB : apollo.portal.meta.servers = {}. Old value = null
2023-12-18 15:22:48.434  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'portalConfig' of type [com.ctrip.framework.apollo.portal.component.config.PortalConfig] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:48.440  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'apollo.audit.log-com.ctrip.framework.apollo.audit.ApolloAuditProperties' of type [com.ctrip.framework.apollo.audit.ApolloAuditProperties] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:48.440  INFO 1 --- [           main] c.c.f.a.a.c.ApolloAuditAutoConfiguration : ApolloAuditAutoConfigure initializing...
2023-12-18 15:22:48.441  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'com.ctrip.framework.apollo.audit.configuration.ApolloAuditAutoConfiguration' of type [com.ctrip.framework.apollo.audit.configuration.ApolloAuditAutoConfiguration$$EnhancerBySpringCGLIB$$61ec165] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:48.454  INFO 1 --- [           main] trationDelegate$BeanPostProcessorChecker : Bean 'spring.ldap-com.ctrip.framework.apollo.portal.spi.configuration.LdapProperties' of type [com.ctrip.framework.apollo.portal.spi.configuration.LdapProperties] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2023-12-18 15:22:48.455  WARN 1 --- [           main] ConfigServletWebServerApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'methodValidationPostProcessor' defined in class path resource [org/springframework/boot/autoconfigure/validation/ValidationAutoConfiguration.class]: Unsatisfied dependency expressed through method 'methodValidationPostProcessor' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'restTemplateFactory' defined in URL [jar:file:/apollo-portal/apollo-portal-2.2.0.jar!/BOOT-INF/classes!/com/ctrip/framework/apollo/portal/component/RestTemplateFactory.class]: Unsatisfied dependency expressed through constructor parameter 2; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'apolloAuditHttpInterceptor' defined in class path resource [com/ctrip/framework/apollo/audit/configuration/ApolloAuditAutoConfiguration.class]: Unsatisfied dependency expressed through method 'apolloAuditHttpInterceptor' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'apolloAuditTraceContext' defined in class path resource [com/ctrip/framework/apollo/audit/configuration/ApolloAuditAutoConfiguration.class]: Unsatisfied dependency expressed through method 'apolloAuditTraceContext' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'apolloAuditOperatorPortalSupplier' defined in URL [jar:file:/apollo-portal/apollo-portal-2.2.0.jar!/BOOT-INF/classes!/com/ctrip/framework/apollo/portal/audit/ApolloAuditOperatorPortalSupplier.class]: Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'authConfiguration.SpringSecurityLDAPAuthAutoConfiguration' defined in URL [jar:file:/apollo-portal/apollo-portal-2.2.0.jar!/BOOT-INF/classes!/com/ctrip/framework/apollo/portal/spi/configuration/AuthConfiguration$SpringSecurityLDAPAuthAutoConfiguration.class]: Unsatisfied dependency expressed through constructor parameter 2; nested exception is org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'authConfiguration.SpringSecurityLDAPAuthAutoConfiguration': Requested bean is currently in creation: Is there an unresolvable circular reference?
2023-12-18 15:22:48.456  INFO 1 --- [           main] j.LocalContainerEntityManagerFactoryBean : Closing JPA EntityManagerFactory for persistence unit 'default'
2023-12-18 15:22:48.457  INFO 1 --- [           main] com.zaxxer.hikari.HikariDataSource       : HikariPool-1 - Shutdown initiated...
2023-12-18 15:22:48.469  INFO 1 --- [           main] com.zaxxer.hikari.HikariDataSource       : HikariPool-1 - Shutdown completed.
2023-12-18 15:22:48.486  INFO 1 --- [           main] ConditionEvaluationReportLoggingListener :
Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
2023-12-18 15:22:48.529 ERROR 1 --- [           main] o.s.b.d.LoggingFailureAnalysisReporter   :

APPLICATION FAILED TO START

Description:
The dependencies of some of the beans in the application context form a cycle:
methodValidationPostProcessor defined in class path resource [org/springframework/boot/autoconfigure/validation/ValidationAutoConfiguration.class]
↓
restTemplateFactory defined in URL [jar:file:/apollo-portal/apollo-portal-2.2.0.jar!/BOOT-INF/classes!/com/ctrip/framework/apollo/portal/component/RestTemplateFactory.class]
↓
apolloAuditHttpInterceptor defined in class path resource [com/ctrip/framework/apollo/audit/configuration/ApolloAuditAutoConfiguration.class]
↓
apolloAuditTraceContext defined in class path resource [com/ctrip/framework/apollo/audit/configuration/ApolloAuditAutoConfiguration.class]
↓
apolloAuditOperatorPortalSupplier defined in URL [jar:file:/apollo-portal/apollo-portal-2.2.0.jar!/BOOT-INF/classes!/com/ctrip/framework/apollo/portal/audit/ApolloAuditOperatorPortalSupplier.class]
┌─────┐
|  authConfiguration.SpringSecurityLDAPAuthAutoConfiguration defined in URL [jar:file:/apollo-portal/apollo-portal-2.2.0.jar!/BOOT-INF/classes!/com/ctrip/framework/apollo/portal/spi/configuration/AuthConfiguration$SpringSecurityLDAPAuthAutoConfiguration.class]
└─────┘
Action:
Despite circular references being allowed, the dependency cycle between beans could not be broken. Update your application to remove the dependency cycle.

Looks like an issue related with the apollo audit log feature, would you please config the apollo.audit.log.enabled to false in config/application.properties and try again?

config the apollo.audit.log.enabled to false in config/application.properties and try again?

@nobodyiam  I tried this and it couldn't start normally
***************************
APPLICATION FAILED TO START
***************************

Description:

The dependencies of some of the beans in the application context form a cycle:

   openApiAuthenticationFilter defined in class path resource [com/ctrip/framework/apollo/portal/spi/configuration/AuthFilterConfiguration.class]
      ↓
   consumerAuthUtil defined in file [/Users/weizhile/Developer/apollo/apollo-portal/target/classes/com/ctrip/framework/apollo/openapi/util/ConsumerAuthUtil.class]
      ↓
   consumerService defined in file [/Users/weizhile/Developer/apollo/apollo-portal/target/classes/com/ctrip/framework/apollo/openapi/service/ConsumerService.class]
┌─────┐
|  authConfiguration.SpringSecurityLDAPAuthAutoConfiguration defined in file [/Users/weizhile/Developer/apollo/apollo-portal/target/classes/com/ctrip/framework/apollo/portal/spi/configuration/AuthConfiguration$SpringSecurityLDAPAuthAutoConfiguration.class]
└─────┘

I will focus on this bug

@nobodyiam I think maybe I found the bug of this issue!
There is a circular reference in LDAPAutoConfiguration itself since refactor(apollo-biz): Use constructor injection instead of field injection (#4826) and the bean referred is LdapTemplate
since 2023.4.4 LdapTemplate was add to constructor

while itself was injected by this configuration!

So I make those changes

then the circular reference has gone!!
But I don't have ldap test properties to verify that my changes are correct. 🤕

@BlackBear2003 Thank you for the prompt response! Previously, I had an LDAP test environment, but it was lost during the recent OS upgrade. I'm working on restoring it. In the meantime, if you're available, could you also attempt to establish an LDAP environment for testing? The last time, I successfully set it up following the guidelines in #1794.

@BlackBear2003 Thank you for the prompt response! Previously, I had an LDAP test environment, but it was lost during the recent OS upgrade. I'm working on restoring it. In the meantime, if you're available, could you also attempt to establish an LDAP environment for testing? The last time, I successfully set it up following the guidelines in #1794.

I'd like to.😃

@BlackBear2003 Thank you for the prompt response! Previously, I had an LDAP test environment, but it was lost during the recent OS upgrade. I'm working on restoring it. In the meantime, if you're available, could you also attempt to establish an LDAP environment for testing? The last time, I successfully set it up following the guidelines in #1794.

See https://github.com/apolloconfig/apollo/discussions/5056

@TomXiaoYZ Fixed by #5055.

docker pull apolloconfig/apollo-portal:2.2.0
this images has upgraded?

It's not released yet.

Is there any solution to this problem? I went back to 2.1.0. Was this issue not repackaged?

apollo.audit.log.enabled

它还没有发布。

大概什么时候发布呀 我配置ldap的时候也遇到了这种问题  2.2.0

apollo.audit.log.enabled

它还没有发布。

大概什么时候发布呀 我配置ldap的时候也遇到了这种问题 2.2.0

如果急着使用的话，可以按着这个pr来自己修一下，改动很小很小。
https://github.com/apolloconfig/apollo/pull/5055/files

Apollo version 2.3.0 has been made available. You can view the details of this release via this link.


Django 3.2 upgrade initial CI run

Fixes: #1277

We don't have a ton of test coverage for the Constance integration - could you do some manual testing to at least make sure that /admin/constance/config/ loads correctly and you can set values there that persist?

Just tested by setting HIDE_RESTRICTED_UI=True. Logged out and back in as a restricted user and verified UI was restricted. Then logged out and back in as superuser and set HIDE_RESTRICTED_UI=False and logged out and back in as a restricted user and verified UI was not restricted.


Arm64 Builds and warnings clean-up

Enable builds for 64-ARM in ROS build Farm.
Clean up many compiler warnings

Hopefully the last required changes to enable all platforms for ROS.
Requires updates to the existing release tags: v0.9.2 and stable; or a new release tag.


First version of scrollable discrete color legends

This PR adds stateless color legends (with and without search) for discrete colors.
It should probably be wrapped into the bigger legend component later.
Following legends support custom colors/titles and onItemClick handlers.

This PR partially resolves #32 .

@bulyonov how about an example of how a legend can be used beside a line chart?


[terraform-ibm-modules/mock-module] Release Pipeline failed 2024-11-30-10:30

For details see: https://github.com/terraform-ibm-modules/mock-module/actions/runs/12095679042

mock module dev work - ignore


@orta -> auction results warning rotates on ipad

i also made the line-wrapping for the label automatic, rather than hard coded because the text was fixed at iphone-width on ipad.
fixes https://github.com/artsy/eigen/issues/131

was a green on last run, good work.

This was missing a CHANGELOG, I added on here, please review it.


remove optimiseForBitmaps because it's usually a bad idea

I spoke to @ppiotrow and we agree that the optimise for bitmaps option was a bad idea, and would require changes to the container implementations to do the right thing all the time, so this PR removes it.

Coverage increased (+0.005%) to 91.686% when pulling 146dd780975ccec7f191968c02575baf35643343 on richardstartin:remove-optimise-for-bitmaps into 91c85472cbdcbf45138f89da0666f9200e8ccad2 on RoaringBitmap:master.

Travis seems to be quite creaky these days.

Restarting travis job....

We are now good.


 I am getting artifacts (yellow lines) and extremely slow update rate even at 40 SPI bus clock divisor. Is it possible for soldering to be the problem? I am using 1.3inch 240x240 waveshare display . Here is the video (ignore sound in the background) https://youtu.be/J9P2_QtsPtc

Using SPI bus clock divisor 40 is really slow indeed. Do the artifacts persists on faster clock speeds, or does the display crash altogether?
Not sure about the artifacts and the connection to soldering. It is a bit hard to say from the video, but if the artifact pixels always appear on individual one pixel tall lines, then it is definitely not a SPI bus soldering issue, as any signal issue on the SPI bus would not be able to "know" when one line ends and another starts. I would assume if there is a soldering connectivity issue, I'd expect the whole display to just not work, or show complete garbage for a sec and then crash.
If the artifacts always persist on the same scanline, then I would be suspicious of the display unit's ribbon connection from the controller to the display panel itself, since those have parallel traces and one bad trace can make a deterministically same kind of artifact.
It is also worth checking with Waveshare's own display driver to rule out a software issue.

Okay, thanks. I will try to check the display.

So, the ribbon cable seems fine. I uploaded another video detailing what's wrong

The occasional lagging is most certainly due to low spi bus speed (sometimes the update will need to do a larger sub rectangle fill that takes much more bandwidth). If the bus does not hold up on faster settings, then you may be out of luck on that display :/

Well, that's the problem. It was working absolutely fine just a week ago on 20 SPI divisor. The ribbon cable seems fine so idk what's actually the problem.

And it's not just lagging. I don't think that the screen is supposed to refresh so that you can see the refresh going left to roght

Closing out old issues.


fix condor_submit_dag test

It needed some environment variables passed; not sure how they were getting through before, but they aren't lately (alma9 container? condor update?) .  Anyhow, I think the test works again now.

LGTM, but one question.  Do we know that this fixes the test?

So I thought I answered this; yes this does fix it.


Added getattribute converter

Motivation
torch.complex module uses __getattribute__. See the example.
complex_tensor = torch.complex(torch.randn(4, 4, 4), torch.randn(4, 4, 4))
# The `torch.Tensor.__getattribute__` is used here.
complex_tensor.imag

Implementation Directory
I made a new file 'nobuco/node_converters/tensor_getattr.py'. To understand the reason, please read the implementation below.
@converter(torch.Tensor.__getattribute__, channel_ordering_strategy=ChannelOrderingStrategy.FORCE_PYTORCH_ORDER)
def converter_getattr(self: Tensor, name: str, *, out: Optional[Tensor] = None):
    def func(self, name: str, *, out: Optional[Tensor] = None):
        if name == "real":
            return tf.math.real(self)
        elif name == "imag":
            return tf.math.imag(self)
        else:
            raise AttributeError(f"'Tensor' object has no attribute '{name}'")
    return func

There are probably more attributes to convert, and they(torch) will add more. For the additional conversions, we don't need to add new functions, but update the 'if loop'. It would be reasonable to create the dedicated file because of the uniqueness.
Implementation Notebook
Please check the colab Notebook.

Revisit the revised colab Notebook to test the implementation.


QAFTestStep not logged to test-results (custom TestNG framework).

QAF Version
Latest release - 3.2.0
We have existing maven solution with large amount of selenium tests written in java with testNG. Now we would like to import execution results into QMetry for Jira.
We decided to integrate QAF package into our existing solution, to get results in qas format, with failure screenshots and steps included.
As a starter, I followed the example in your repository: https://github.com/qmetry/qtm4j-automation-sample-projects/blob/master/QAF/pom.xml a
I managed to set our driver instance to qaf, so currently we have got test results with screenshots. But now I still have an issue with it:
I started marking our steps (we call them pageActions) with @QAFTestStep annotations, to see them as checkpoints in the generated test result jsons. I have also added resources/application.properties with the parameter step.provider.pkg=pageActions (pageActions is a full name of our package with steps. I have added related plugins and dependencies for aspectj and qaf into our pom.xml . I can see that aspects has been generated (AjcClosure classes generated in  target directory after the build). But unfortunately steps are not getting added to test result jsons. Could you please suggest where could be the problem or how to achieve what we want?
Steps To Reproduce
1.  Add QAF dependencies to maven project
2. Extend BaseTest from WebDriverTestCase and initialize browser at TestBaseProvider in beforeMethod:

        TestBaseProvider.instance().get()
                .setDriver("chrome", new QAFExtendedWebDriver(DriverManager.getDriver()));

4. Add @QAFTestStep annotation to desired test steps
5. Run the maven command mvn clean test

Expected behavior
Method marked with @QAFTestStep annotation gets added as checkpoint to test-results/ ... .json file
Actual behavior
Only errors and assertions are present in  test-results/ ... .json file
Is the issue reproducible on runner?

[ ] QAS
[x] Maven
[ ] Gradle
[ ] Ant
[ ] Eclipse

Test case sample
I prepared a temp repository with sample maven project with our dependencies, where the issue can be reproduced:
https://github.com/mialeska/tmp-ui-tests/tree/test-results
Please find generated test results in the test-results branch.

Refer pom file from sample maven project.

@cjayswal yes I used it for the reference, but add some customizations for project specific:

we are working with IntelliJ IDEA, not eclipse
we already have some libraries that have aspectJ and some other dependencies
Could you please point out what in particular you do see as wrong with my pom file?

Maven aspectj-maven-plugin is not specific to eclipse. If you don't want to use aspectj-maven-plugin refer configuration used in plugin.

@cjayswal I am using the aspectj-maven-plugin. But my configuration is a little different, as with yours config Lombok dependency is not working.
Lombok requires aspectJ to be configured in the maven-surefire-plugin's argline:
      <argLine>
            -javaagent:"${settings.localRepository}/org/aspectj/aspectjweaver/${aspectj.version}/aspectjweaver-${aspectj.version}.jar"
      </argLine>

With your configuration added, I see the following error:
[WARNING] You aren't using a compiler supported by lombok, so lombok will not work and has been disabled.
Your processor is: org.aspectj.org.eclipse.jdt.internal.compiler.apt.dispatch.BatchProcessingEnvImpl
Lombok supports: OpenJDK javac, ECJ
<unknown source file>:<no line information>
[WARNING] advice defined in com.qmetry.qaf.automation.step.JavaStepReporter has not been applied [Xlint:adviceDidNotMatch]
C:\Users\a2.meleshko.m2\repository\com\qmetry\qaf\3.2.0\qaf-3.2.0.jar!com\qmetry\qaf\automation\step\JavaStepReporter.class:0
Below is my configuration for plugins section:
       <plugins>
            <plugin>
                <groupId>org.codehaus.mojo</groupId>
                <artifactId>aspectj-maven-plugin</artifactId>
                <version>1.14.0</version>
                <executions>
                    <execution>
                        <id>default-compile</id>
                        <phase>process-classes</phase>
                        <goals>
                            <goal>compile</goal>
                        </goals>
                        <configuration>
                            <weaveDirectories>
                                <weaveDirectory>${project.build.directory}/classes</weaveDirectory>
                            </weaveDirectories>
                        </configuration>
                    </execution>
                    <execution>
                        <id>default-testCompile</id>
                        <phase>process-test-classes</phase>
                        <goals>
                            <goal>test-compile</goal>
                        </goals>
                        <configuration>
                            <weaveDirectories>
                                <weaveDirectory>${project.build.directory}/test-classes</weaveDirectory>
                            </weaveDirectories>
                        </configuration>
                    </execution>
                </executions>
                <configuration>
                    <source>1.8</source>
                    <target>1.8</target>
                    <showWeaveInfo>true</showWeaveInfo>
                    <verbose>true</verbose>
                    <complianceLevel>1.8</complianceLevel>
                    <aspectLibraries>
                        <aspectLibrary>
                            <groupId>com.qmetry</groupId>
                            <artifactId>qaf</artifactId>
                        </aspectLibrary>
                    </aspectLibraries>
                    <sources/>
                    <excludes>
                        <exclude>**/*.java</exclude>
                    </excludes>
                    <forceAjcCompile>true</forceAjcCompile>
                </configuration>
                <dependencies>
                    <dependency>
                        <groupId>org.aspectj</groupId>
                        <artifactId>aspectjtools</artifactId>
                        <version>${aspectj.version}</version>
                    </dependency>
                </dependencies>
            </plugin>
        </plugins>


operationsThatMustHaveValidationException does not account for event streaming members.

When an operation's input includes an event streaming member, the builder for the operation input or output can raise a ConstraintViolation if build_enforcing_all_constraints is called and the event streaming member field has not been set.
The From implementation that converts ConstraintViolation to RequestRejection references ValidationException. However, if the user has not added ValidationException to the errors list, a build-time error is not generated to prompt the user to include ValidationException.
The operationsThatMustHaveValidationException method should raise an error in this case.
Here is a sample model:
service ConstrainedService {
    operations: [EventStreamsOperation]
}

structure EventStreamsOperationInputOutput {
    @httpPayload
    events: Event,
}

@http(uri: "/event-streams-operation", method: "POST")
operation EventStreamsOperation {
    input: EventStreamsOperationInputOutput,
    output: EventStreamsOperationInputOutput,
}

@streaming
union Event {
    regularMessage: EventStreamRegularMessage,
    errorMessage: EventStreamErrorMessage,
}

structure EventStreamRegularMessage {
    messageContent: String
}

@error("server")
structure EventStreamErrorMessage {
    messageContent: String
}

In the operation input builder, build_enforcing_all_constraints returns a ConstraintViolation if constraints are not met:
        fn build_enforcing_all_constraints(
            self,
        ) -> Result<crate::input::EventStreamsOperationInput, ConstraintViolation> {
            Ok(
                crate::input::EventStreamsOperationInput {
                    events: self
                        .events
                        .ok_or(ConstraintViolation::MissingEvents)?,
                },
            )
        }

The From implementation for converting ConstraintViolation to RequestRejection uses crate::error::ValidationException:
    impl ::std::convert::From<ConstraintViolation>
        for ::aws_smithy_http_server::protocol::rpc_v2_cbor::rejection::RequestRejection
    {
        fn from(constraint_violation: ConstraintViolation) -> Self {
            let first_validation_exception_field =
                constraint_violation.as_validation_exception_field("".to_owned());
            let validation_exception = crate::error::ValidationException {

The generated Rust code errors out with:
error[E0412]: cannot find type `ValidationExceptionField` in module `crate::model`
  --> src/input.rs:78:28
   |
78 |         ) -> crate::model::ValidationExceptionField {
   |                            ^^^^^^^^^^^^^^^^^^^^^^^^ not found in `crate::model`

You must always have ValidationException in an event streaming operation because the event (the member on the input structure that targets a Smithy union/ Rust enum) is always required.


chore (Ring.Prod): move order instances on product rings

We shouldn't import the whole order hierarchy when we want ring instances on products.

!bench

I feel like you're slowly unpicking a gigantic knot here.
bors merge


Unreachable code ApplicationController Explorer

Based on: https://github.com/ManageIQ/manageiq/commit/0e296826

@martinpovolny Please review

@brandondunne : thx
We plan to attack all the tree_ remnants in app_controller/{explorer, tree_support} with @himdel once @bmclaughlin finishes his #3841.
Once this is done, we plan to do changes to TreeBuilder* so that it can be tested w/o controllers (especially decouple any unnecessary interactions with session) and hopefully cleanly split the building of the logical trees from the tree representation so that upcoming replacement of the Fancytree code with some bootstrap stuff will be a piece of cake ;-)


Powershell Gallery - Bia.Countries 1.0

Hi,
the actual package on PSGallery is it up to date ?

I don't think so.
@KeeperB5 manages the powershell part of the project.

Thanks

Sorry it took me a while to answer to this. I don't actively follow Bia.Countries project so changes to the project may go unnoticed. I'll look into updating the PowerShell module at PSGallery.


Add an EditorConfig file

Add an EditorConfig (.editorconfig) file to this repo.
Motivation:
EditorConfig helps maintain consistent coding styles for multiple developers working on the same project across various editors and IDEs. It will be helpful to add one of these files to swift-testing so that all contributors use the whitespace conventions described in our style guide automatically when using a supported IDE/editor.
Note that Xcode 16 Beta has added support for EditorConfig files — see 20796230 in the release notes.
Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci please test

@swift-ci please test Linux

@swift-ci please test

@swift-ci please test


Recent master broke roles

We tried recent master commit (8d81c3049aa9632dd6f73e6f3b51a3d0512bfef1) and we got 401 back from queries via sql_lab. /roles/list returne 500 with stack trace below
Expected results
/roles/list to load and sql_lab query not returning 401
Actual results
500 and 401
Screenshots
/roles/list trace:
500 - Internal Server Error
Stacktrace
         Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2292, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1815, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1718, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
    raise value
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/local/lib/python3.6/site-packages/flask_appbuilder/security/decorators.py", line 123, in wraps
    return f(self, *args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/flask_appbuilder/views.py", line 531, in list
    self.list_template, title=self.list_title, widgets=widgets
  File "/usr/local/lib/python3.6/site-packages/flask_appbuilder/baseviews.py", line 228, in render_template
    template, **dict(list(kwargs.items()) + list(self.extra_args.items()))
  File "/usr/local/lib/python3.6/site-packages/flask/templating.py", line 135, in render_template
    context, ctx.app)
  File "/usr/local/lib/python3.6/site-packages/flask/templating.py", line 117, in _render
    rv = template.render(context)
  File "/usr/local/lib/python3.6/site-packages/jinja2/asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/usr/local/lib/python3.6/site-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.6/site-packages/jinja2/_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "/usr/local/lib/python3.6/site-packages/apache_superset-0.999.0.dev0-py3.6.egg/superset/templates/appbuilder/general/model/list.html", line 20, in top-level template code
    {% import 'appbuilder/general/lib.html' as lib %}
  File "/usr/local/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/base.html", line 1, in top-level template code
    {% extends base_template %}
  File "/usr/local/lib/python3.6/site-packages/apache_superset-0.999.0.dev0-py3.6.egg/superset/templates/superset/base.html", line 19, in top-level template code
    {% extends "appbuilder/baselayout.html" %}
  File "/usr/local/lib/python3.6/site-packages/apache_superset-0.999.0.dev0-py3.6.egg/superset/templates/appbuilder/baselayout.html", line 20, in top-level template code
    {% import 'appbuilder/baselib.html' as baselib %}
  File "/usr/local/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/init.html", line 46, in top-level template code
    {% block body %}
  File "/usr/local/lib/python3.6/site-packages/apache_superset-0.999.0.dev0-py3.6.egg/superset/templates/appbuilder/baselayout.html", line 39, in block "body"
    {% block content %}
  File "/usr/local/lib/python3.6/site-packages/apache_superset-0.999.0.dev0-py3.6.egg/superset/templates/appbuilder/general/model/list.html", line 30, in block "content"
    {% block list_list scoped %}
  File "/usr/local/lib/python3.6/site-packages/apache_superset-0.999.0.dev0-py3.6.egg/superset/templates/appbuilder/general/model/list.html", line 31, in block "list_list"
    {{ widgets.get('list')()|safe }}
  File "/usr/local/lib/python3.6/site-packages/flask_appbuilder/widgets.py", line 37, in __call__
    return template.render(args)
  File "/usr/local/lib/python3.6/site-packages/jinja2/asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/usr/local/lib/python3.6/site-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.6/site-packages/jinja2/_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "/usr/local/lib/python3.6/site-packages/apache_superset-0.999.0.dev0-py3.6.egg/superset/templates/superset/fab_overrides/list_role.html", line 19, in top-level template code
    {% extends 'appbuilder/general/widgets/roles/list.html' %}
  File "/usr/local/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/general/widgets/roles/list.html", line 2, in top-level template code
    {% extends 'appbuilder/general/widgets/base_list.html' %}
  File "/usr/local/lib/python3.6/site-packages/apache_superset-0.999.0.dev0-py3.6.egg/superset/templates/appbuilder/general/widgets/base_list.html", line 43, in top-level template code
    {% block begin_loop_values %}
  File "/usr/local/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/general/widgets/roles/list.html", line 47, in block "begin_loop_values"
    {% set is_builtin_role = appbuilder.sm.builtin_roles.get(item['name']) %}
  File "/usr/local/lib/python3.6/site-packages/jinja2/environment.py", line 430, in getattr
    return getattr(obj, attribute)
jinja2.exceptions.UndefinedError: 'superset.security.SupersetSecurityManager object' has no attribute 'builtin_roles'

How to reproduce the bug

Go to Security
Click on List Roles

Environment
(please complete the following information):

superset version: 8d81c3049aa9632dd6f73e6f3b51a3d0512bfef1
python version: 3.6.8
node.js version: v10.16.0
npm version: 6.9.0

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Did you pip install -r requirements.txt? FAB (Flask-Appbuilder) has been bumped there and it looks like you're on the old FAB.

I did.  FAB (Flask-Appbuilder) has been
bumped there and it looks like you're on the old FAB.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-superset/issues/7844?email_source=notifications&email_token=AAUC7PTKUAYZYVNTAQBXAADP625RZA5CNFSM4IACSVD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZVQNCY#issuecomment-510330507,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUC7PXR5SJPJIP4X73W6NDP625RZANCNFSM4IACSVDQ
.

--
With best regards,
Chinh Nguyen

Mmmmh, looks like something is out of sync in your environment.
On my side:
In [1]: from superset import security_manager
In [2]: security_manager.builtin_roles
Out[2]: {}

It's affected here (notice this code is on the 2.1.6 tag specifically):
https://github.com/dpgaspar/Flask-AppBuilder/blob/release/2.1.6/flask_appbuilder/security/manager.py#L315

Yes, builtin roles came with 2.1.0.
@chinhngt please create a fresh venv and retry. If it still happens, post all your commands and output from venv creation to launching superset.

Oh, I figured out the issue. Indeed this was something on my end (we have some custom patches for the FAB!)
Thanks @mistercrunch  and @dpgaspar for all the help :)


Interpreter

Here is a rough sketch of tasks for implementing the interpreter. We can continue tracking tasks and progress for it on this issue.

[ ] eval_s: Implement evaluation/simulation of one step of a component's structure (i.e. one enable statement)

[ ] Needs to evaluate the inputs and outputs of primitive components- may require refactoring of primitive library. It may be nice to have a standard library of components defined in Rust instead of hard-coding standard library names. EDIT: I added a function eval_lib that can be implemented to simulate library components. This can be done by hard-coding standard library names for now, and then we can switch to a nicer library definition as we progress.
[ ] Need to have an extra data structure for storing register and memory state during evaluation.
[ ] Implement a topological sort graph traversal that works on cyclic graphs. Structure graphs can be cyclic due to sequential components like registers, but Petgraph's Topo sort raises an error on cyclic graphs. It also only seems to support traversal starting from a single node, but we probably want to start traversals with all input nodes on the stack.
It will need to be able to store the state of all subcomponents as well.

[ ] eval_c: Implement evaluation of a component's control- should be similar to standard big-step semantics. Evaluating an enable should call eval_s to simulate the structure.

Notes on assumptions that I have made so far:

The output ports of the component will take the output values from the last enable statement that runs in the control
There should be no cycles in the structure graph except when using sequential primitives such as registers.
Component input values are available to the component during all logical time steps.

I will keep this list updated as I go, and please let me know if there are points I should clarify.

Short update: I believe all of the graph infrastructure is in place for simulating signals on a StructureGraph. Next I want to add features to main for visualizing the structure graph and making sure that these helpers are doing the right thing. Goal for the week is to be able to simulate and visualize single logical time steps to ensure the functions are working correctly.
Here are some notes on next few tasks:

[ ] Generating state structure from a component (pretty straightforward)
[ ] Adding interpreter options to cmdline for testing
[ ] Interactive functions for stepping single timesteps
[ ] Visualizing Structure graphs with dot as we implement the rest of the eval_s and eval_c structures. Should play around with petgraph::dot visualization options.
[ ] Implement evaluation for primitives.


143 generalization fix

Fixed #143

@nordlander FYI, the CI test times out. It is stuck on ./105-type-inference-order. This is reproducible locally - it just looks like it hangs forever.

Yup, although it's actually intermittent when I test it locally. Found the error in the, which is independent of the fix (the test code just happens to be sensitive to the rts bug). I'll fix that in another branch, disabling the test meanwhile.


It does not open HTTP links (nothing happen)

Aknowledgements

[X] I have checked that there's no other issue describing the same or
similar problem that I currently have, regardless if it has been
closed or open.

[X] I can confirm that this is not an issue with the Discord website,
but it is a problem specific to the WebCord itself. I have tested
if this bug occurs on Chromium/Chrome or any other Chromium-based
browser that uses unpatched/upstream Chromium engine.

[ ] I have tried running the build from the master branch and it does
not have any fixes implemented according to my issue.

[ ] My issue describes one of the unstable and/or not fully implemented
features.

[ ] I have found a workaround to mitigate or temporarily fix this issue
in affected releases (please write it in Additional context section
below).

Operating System / Platform
🐧 Linux
Operating system architecture
x64 (64-bit Intel/AMD)
Electron version
v19.0.10
Application version
v3.6.0
Bug description
http:// links do not open, no reaction. They work in real and bad official discord client.
Workaround, copy link address and paste it in a browser.
Additional context
I think the description is obvious.

This may be the problem
https://github.com/SpacingBat3/WebCord/blob/d8d88a9a7e08138329212096539aa85c2c3f0751/sources/code/common/global.ts#L77

This is actually an expected behavior – WebCord does not open any unsecure links. In WebCord, everything is enforced to HTTPS and anything that uses unsecure protocol is simply blocked.

That being said, images, videos, scripts etc. from http: should also be blocked.

The question is: is there ANY reason why to keep HTTP links as supported? It feels like it is a bad idea and probably is from the security point of view. In the modern world HTTPS confirms that specific domain is legitimate (DNS can't lie to us) and prevents from attacks that uses protocol downgrade to escape cerficate verification. And sure, browser nowadays does some job to prevent this but WebCord actually does not know which app opens specific URL, so it is unsure whenever your browser cares about the security or not.
This is why I want to keep it as it is.

Yes, there is some reason to keep HTTP. Some small sites do not use https. Here an exemple link:
http://christophe.bray.free.fr/informatique/falcon/Atari Falcon 030 versus Amiga 1200.pdf
There should at least be an option to allow it. I don't want to build it just to for that, but I may need to if this is only WebCord/sources/code/common/global.ts and you don't understand user need to choice instead of enforcing blindly.

Yes, there is some reason to keep HTTP. Some small sites do not use https. Here an exemple link: http://christophe.bray.free.fr/informatique/falcon/Atari Falcon 030 versus Amiga 1200.pdf There should at least be an option to allow it. I don't want to build it just to for that, but I may need to if this is only WebCord/sources/code/common/global.ts and you don't understand user need to choice instead of enforcing blindly.

I think I can actually make those links clickable while preserving everything safe. I think WebCord should ensure if it is you who clicked this link by showing up a dialog window. I'll enforce this for HTTP sites  – there will be no option to disable it, but HTTPS sites will be still opened with the current policy (only show dialog if user allows for doing that and origin is different from the current instance link's origin).
You should also know that Electron is also responsible for blocking HTTP, as it doesn't trust unsecure content on secure sites (i.e. HTTP stuff does not load on HTTPS). I'm not going to change this for the security reasons.

If support for HTTP links isn't going to be added, there should at least be an indicator telling the user so. I at first thought the inability to access such links was a bug because of there not being one.


Add Drawing Instructions

https://hackclub.slack.com/archives/C04GCH8A91D/p1707183245832409

Thanks for adding this @BrightTheBackpack


Add Liquidity Mining support for Isolated pools

LM farms can be created currently only for the Omnipool subpools via a feature specific implementation @  https://github.com/galacticcouncil/HydraDX-node/tree/master/pallets/omnipool-liquidity-mining
Task is to analyse which other pools would be suitable for farms and create either a generic LM connector or extend the current implementation with Isolated (XYK) pool support.
Goal is to be able to create LM farms on top of Isolated pools.

closed in #798


Add color and space to the QR component

Is your feature request related to a problem? Please describe.
QR component doesn't have access to values stored in our theme. Meaning it can't easily access theme colors and spacing.
Describe the solution you'd like
Make the properties of color and space available to the QR component.
Describe alternatives you've considered
passing in hex values via component options.

@MikeLockz for this I'd like to wrap the QRCode from qrcode.react in a Box component. Then individually map the styled-system props to the correct qrcode.react props.

color => fgColor
backgroundColor => bgColor
as => renderAs

Then ...rest the remaining space props and spread onto the Box. If this seems like a reasonable approach to you I'll get a PR in for it.

@sublimatedpotato - sounds like a great approach and would be approved. Thanks for clarifying ahead of time!

Great thanks @MikeLockz I do have this pretty much ready, but I'm going to wait to submit any more PR requests than the one I just did.
I posted a question on that, but I believe I'm running into some deeper issues with my fork. I have merged the latest master and development and have even pulled direct from upstream and forced onto my local. Even when I do that I'm getting failed snapshot tests in Pill and Card (with and without theme).
Have tried deleting yarn.lock and node_modules then reinstalling, but that didn't seem to help. Let me know if you have any immediate thoughts. Don't want to infect upstream with something I messed up!


Timestamp field: access by FieldRef

Could you please add in the Timestamp section, that the timestamp field can also be accessed by a FieldRef alone, without the need to create another field?
Please see https://twitter.com/KarolakNatalie/status/1267739086447665153 for more details.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e34c994f-9471-dfed-05be-e4893f63fd79
Version Independent ID: cf609474-4520-ded4-fae2-fd4dd8235d07
Content: Table Object - Business Central
Content Source: dev-itpro/developer/devenv-table-object.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Hi, we will add this information with the next refresh, thanks.


RuntimeError: CUDA error: out of memory

I have the problem:
RuntimeError: CUDA error: out of memory
although I have change the batch_size to 1

Do you know what stage of the computation is running out of memory?  I.e., is it at the beginning, when it is collecting quantile data?
If you specify fewer layers to dissect, it will take less memory.  Also, if you take care to dissect layers which have smaller representations (e.g., lower resolution), it will take less memory - and often these smaller representation layers are the interesting ones also.

Feel free to contact me with more details if the tips above don't work for you.


Error on Colab

🐛 Describe the bug
Opened the demo on colab and 'pip install  --upgrade embedchain' throws the following error: ERROR: Cannot uninstall 'blinker'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.

Same error - ERROR: Cannot uninstall 'blinker'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.

+1 Same Error...

Hey, can you please run the following
!pip3 install --ignore-installed embedchain

Please check https://github.com/embedchain/embedchain/issues/506 for context.

Closing this issue since no comments since 2 weeks.
Please feel free to re-open if the issue still exists.


Feature/ouster

Status
DEVELOPMENT
Description
Added support for Ouster OS1 3D LiDAR. This includes, a new option on the sensing tab (including configuration options) and the actual lidar driver as a submodule at ros/src/sensing/drivers/lidar/packages/ouster
#1752
Related PRs
List related PRs against other branches:
None
Todos

[X] Tests
[X] Documentation

Steps to Test or Reproduce
(Note: You need an Ouster OS1 LiDAR to test the following)

Clone the feature/ouster branch:
git clone https://github.com/CPFL/Autoware.git --recurse-submodules -b "feature/ouster" autoware-ouster

Build Autoware as usual

Start the runtime manager

(optional) On Setup tab, set velodyne as localizer and the /base_link to localizer tf.

Follow the instructions on ros/src/sensing/drivers/lidar/packages/ouster/readme.md regarding OS1 address configuration (you may need to install dnsmasq and configure it accordingly). Confirm the OS1 LiDAR has an IP address by running ping <OS1-IP-ADDRESS>

On Sensing tab, click on the Ouster OS1 [config] link, and type the LiDAR address and your computer address (in the same network interface), make sure Velodyne compatible mode is checked. Then click OK. Here is an example:

Click the launch check button of Ouster OS1.

On RVIZ, set the fixed frame as velodyne, and add the /points_raw PointCloud2 topic, confirm you are receiving data. Here is an example:

Unfortunately adding this to our codebase instead of submitting any improvements upstream will just cause us more maintenance work on our side. I'll open a ticket to get it removed and push for more integration with upstream.


Oauth support

Proposed Changes
Adding support for oauth client authentication. See Tailscale docs
Probably wanna squash this merge, it has commits from my original PR  #352

I did the first round from memory, thanks for clarifying the extras. Tried my best to cleanup the commit history, but I still think you would want to squash it

hey @frenck, do you have any other feedback or revisions you'd like me to make? Is it still too large?


Highcharts is mildly problematic

Highcharts is theoretically possible to add to the package manager but the most recent "compatible" version is not compatible with the ancient version currently installed. Need to upgrade or remove

There appears to be only one asset called from the highcharts library (font-awesome.css) and it isn't even used AFAICS. See also #486 and commit c667299


Docs not getting generated for rails 5.0.0

rake swagger:docs rake aborted! NoMethodError: undefined method source' for "GET":String
/home/ram/.rvm/gems/ruby-2.3.0/gems/swagger-docs-0.1.8/lib/swagger/docs/generator.rb:147:in get_route_path_apis' /home/ram/.rvm/gems/ruby-2.3.0/gems/swagger-docs-0.1.8/lib/swagger/docs/generator.rb:128:in block in process_path'
/home/ram/.rvm/gems/ruby-2.3.0/gems/swagger-docs-0.1.8/lib/swagger/docs/generator.rb:127:in each' /home/ram/.rvm/gems/ruby-2.3.0/gems/swagger-docs-0.1.8/lib/swagger/docs/generator.rb:127:in process_path'
/home/ram/.rvm/gems/ruby-2.3.0/gems/swagger-docs-0.1.8/lib/swagger/docs/generator.rb:62:in block in generate_doc' /home/ram/.rvm/gems/ruby-2.3.0/gems/swagger-docs-0.1.8/lib/swagger/docs/generator.rb:61:in each'
/home/ram/.rvm/gems/ruby-2.3.0/gems/swagger-docs-0.1.8/lib/swagger/docs/generator.rb:61:in generate_doc' /home/ram/.rvm/gems/ruby-2.3.0/gems/swagger-docs-0.1.8/lib/swagger/docs/generator.rb:49:in block in generate_docs'
/home/ram/.rvm/gems/ruby-2.3.0/gems/swagger-docs-0.1.8/lib/swagger/docs/generator.rb:46:in each' /home/ram/.rvm/gems/ruby-2.3.0/gems/swagger-docs-0.1.8/lib/swagger/docs/generator.rb:46:in generate_docs'
/home/ram/.rvm/gems/ruby-2.3.0/gems/swagger-docs-0.1.8/lib/swagger/docs/generator.rb:20:in write_docs' /home/ram/.rvm/gems/ruby-2.3.0/gems/swagger-docs-0.1.8/lib/tasks/swagger.rake:5:in block (2 levels) in <top (required)>'
/home/ram/.rvm/gems/ruby-2.3.0/gems/rake-11.2.2/exe/rake:27:in <top (required)>' Tasks: TOP => swagger:docs (See full trace by running task with --trace)
I have routes something like this.
Rails.application.routes.draw do
For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
namespace :api do
namespace :v1 do
resources :users
end
end
end
I generated controller using
rails g controller api/v1/users
Please help me I'm stuck

I am getting this issue also :(

+1

try this branch
gem 'swagger-docs',github: 'anhtrantuan/swagger-docs'
Support rails5 and fixed this problem

Many thanks, fix this pb for me ;-)


Removed colors.ts file

Fixes  #158

PTAL @MichalPorag

Please use the get the colors from the colors.scss file instead of adding hard-coded values.

Can you please let me know the location of this particular file so that I can import it. That would be of great help

@soham4abc We need this issue to be fixed quickly so I'm moving it to somebody from the community. thank you for your time.


How to add png image file?

First I generate barcode. Then I need add this barcode to pdf. How to do that? I use "github.com/boombuler/barcode" for generate barcode.
myCode, _ := code128.EncodeWithoutChecksum("sdsdsd39478234234")
myCode, _ = barcode.Scale(myCode, 1500, 500)
file, _ := os.Create("barcode.png")
defer file.Close()
png.Encode(file, myCode)

Had exactly same question with boombuler/barcode.
Fortunately theres already a contrib for barcodes - even with same lib.
Check here:
https://godoc.org/github.com/jung-kurt/gofpdf/contrib/barcode
Or some examples in tests:
https://github.com/jung-kurt/gofpdf/blob/master/contrib/barcode/barcode_test.go


Repo is huge

You've put all your videos in source control, so now I have to download >100MB to clone your repo. I guess there's nothing to do about it now, although you could at least get the tarball size down.

This has been resolved.