Release changed integrations for agent 7.48

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Job failures:

PR labels failure: AITOOLS-243
Windows failures (disk, DNS, .NET CLR, Exchange Server, IIS, PDH, TCP, Windows Performance Counters, Windows Service): Suspecting regression due to 74188
postgres: DBM-2734

Flakey tests:

gunicorn: AI-3290
SAP HANA: AI-3291
temporal: AI-3292
IBM ACE: AI-3293
IBM MQ on Linux: AI-3294
calico
postgres: DBM-2734, DBM-2732


Support for multiple folders for Modules like Orchard 1

This feature ease the work with github submodules pointing to thirdparty or our own repositories providing extra modules for orchard.

We have something way better :)


OpenJDK8U-jdk_x64_mac_hotspot_8u422b05.pkg is not signed

Please provide a brief summary of the bug
Could not install JDK 8 from Adoptium.
Did you test with the latest update version?

[X] Yes

Please provide steps to reproduce where possible
No response
Expected Results
.pkg installer opens successfully.

No response
Did it work before?
No response
Did you test with other Java versions?
No response
Relevant log output
Package "OpenJDK8U-jdk_x64_mac_hotspot_8u422b05.pkg":
   Status: no signature

@gdams for initial triage

I can confirm that I also get this issue

Looking at https://ci.adoptium.net/job/build-scripts/job/release/job/sign_verification/1482/console is seems to suggest that the PKG was signed correctly when built
Signed correctly: ./OpenJDK8U-jdk_x64_mac_hotspot_8u422b05.pkg
Notarized correctly: ./OpenJDK8U-jdk_x64_mac_hotspot_8u422b05.pkg
Package "OpenJDK8U-jre_x64_mac_hotspot_8u422b05.pkg":
   Status: signed by a developer certificate issued by Apple for distribution
   Notarization: trusted by the Apple notary service
   Signed with a trusted timestamp on: 2024-07-24 22:06:20 +0000
   Certificate Chain:
    1. Developer ID Installer: Eclipse Foundation, Inc. (JCDTMS22B4)
       Expires: 2024-08-26 17:22:33 +0000
       SHA256 Fingerprint:
           FD A7 11 E1 1F 78 34 D1 98 51 CC 38 35 6A 03 9F A1 35 3A 60 63 3F
           F9 0F 1C 27 E2 29 E1 0A 26 7B
       ------------------------------------------------------------------------
    2. Developer ID Certification Authority
       Expires: 2027-02-01 22:12:15 +0000
       SHA256 Fingerprint:
           7A FC 9D 01 A6 2F 03 A2 DE 96 37 93 6D 4A FE 68 09 0D 2D E1 8D 03
           F2 9C 88 CF B0 B1 BA 63 58 7F
       ------------------------------------------------------------------------
    3. Apple Root CA
       Expires: 2035-02-09 21:40:36 +0000
       SHA256 Fingerprint:
           B0 B1 73 0E CB C7 FF 45 05 14 2C 49 F1 29 5E 6E DA 6B CA ED 7E 2C
           68 C5 BE 91 B5 A1 10 01 F0 24

Looks like https://ci.adoptium.net/job/build-scripts/job/jobs/job/release/job/jobs/job/jdk8u/job/jdk8u-release-mac-x64-temurin/28/console had a failed installer sign job though, I suspect the wrong artefact was published

This has since been resolved and a new pkg released


FAILURE: Build failed with an exception.

What went wrong:
Could not resolve all files for configuration ':call-chain:zipkin-clients:zipkin-client:compileClasspath'.

Could not resolve org.springframework.cloud:spring-cloud-starter-zipkin:1.2.5.RELEASE.
Required by:
project :call-chain:zipkin-clients:zipkin-client
Could not resolve org.springframework.cloud:spring-cloud-starter-zipkin:1.2.5.RELEASE.
Could not parse POM https://jcenter.bintray.com/org/springframework/cloud/spring-cloud-starter-zipkin/1.2.5.RELEASE/spring-cloud-starter-zipkin-1.2.5.RELEASE.pom
Could not resolve org.springframework.cloud:spring-cloud-sleuth:1.2.5.RELEASE.
Could not resolve org.springframework.cloud:spring-cloud-sleuth:1.2.5.RELEASE.
Could not parse POM https://jcenter.bintray.com/org/springframework/cloud/spring-cloud-sleuth/1.2.5.RELEASE/spring-cloud-sleuth-1.2.5.RELEASE.pom
Unable to resolve version for dependency 'org.hamcrest:hamcrest-core:jar'
Could not resolve org.springframework.cloud:spring-cloud-sleuth:1.2.5.RELEASE.
Could not parse POM https://repo.maven.apache.org/maven2/org/springframework/cloud/spring-cloud-sleuth/1.2.5.RELEASE/spring-cloud-sleuth-1.2.5.RELEASE.pom
Unable to resolve version for dependency 'org.hamcrest:hamcrest-core:jar'
Could not resolve org.springframework.cloud:spring-cloud-starter-zipkin:1.2.5.RELEASE.
Could not parse POM https://repo.maven.apache.org/maven2/org/springframework/cloud/spring-cloud-starter-zipkin/1.2.5.RELEASE/spring-cloud-starter-zipkin-1.2.5.RELEASE.pom
Could not resolve org.springframework.cloud:spring-cloud-sleuth:1.2.5.RELEASE.
Could not resolve org.springframework.cloud:spring-cloud-sleuth:1.2.5.RELEASE.
Could not parse POM https://jcenter.bintray.com/org/springframework/cloud/spring-cloud-sleuth/1.2.5.RELEASE/spring-cloud-sleuth-1.2.5.RELEASE.pom
Unable to resolve version for dependency 'org.hamcrest:hamcrest-core:jar'
Could not resolve org.springframework.cloud:spring-cloud-sleuth:1.2.5.RELEASE.
Could not parse POM https://repo.maven.apache.org/maven2/org/springframework/cloud/spring-cloud-sleuth/1.2.5.RELEASE/spring-cloud-sleuth-1.2.5.RELEASE.pom
Unable to resolve version for dependency 'org.hamcrest:hamcrest-core:jar'

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 17m 9s
71 actionable tasks: 45 executed, 26 up-to-date

Use gradle dockerBuild instead.

#3


1441 market filters

Coverage decreased (-0.02%) to 74.176% when pulling 9b0c9f021b4feb49d9d012844e859e74f3ecbccc on 1441-market-filters into dbf02310b71ad9f904923b6ca0c042d04f175af6 on master.

Coverage decreased (-0.02%) to 74.176% when pulling 9b0c9f021b4feb49d9d012844e859e74f3ecbccc on 1441-market-filters into dbf02310b71ad9f904923b6ca0c042d04f175af6 on master.

Coverage decreased (-0.02%) to 74.176% when pulling fd381481398d40e3dd1e489983c7b572f382690c on 1441-market-filters into dbf02310b71ad9f904923b6ca0c042d04f175af6 on master.


Add basic service infrastructure

Dockerfile, docker compose, config, root endpoint, etc.
Mostly cribbed from the collections service

trivy failed 2x, giving up


chore: move bsearch to a .h file with header guard

Moves bsearch to a .h file with a header guard, instead of directly including the .c file.
This is generally considered a good practice, and fixes an issue with the build of tree-sitter-perl during the installation of tree-sitter-language-pack.

Thanks! I'll take any other best practices prs for the c stuff, if you happened to have peeked at the code


Support TablePlus application located in setapp directory

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem?
TablePlus is not only available via download from the vendor website but is  also part of the SetApp subscription model. In that case, the application is installed in a different directory and thus  the ddev tableplus command doesn't work.
Describe your solution
It's easily possible to check for the alternative directory and thus support both application paths:
Default path is /Applications/TablePlus.app
SetApp path is /Applications/Setapp/TablePlus.app
Describe alternatives
No response
Additional context
No response

This was fixed in https://github.com/ddev/ddev/pull/5816


Add inductive no confusion

Adds the add_ginductive hook for producing nested/mutual inductive types, as well as regular inductive types with all the fancy features you normally get from the inductive command (by contrast to add_inductive which only gives you a really basic inductive with no lemmas that doesn't work with the equation compiler or induction tactic).

wrong repo...


Back button doesn't work on some device

onKeyDown and onBackPressed are not called at all.
Has to override finish method, without calling super's implementation.

Resolves in PR #64


Binding image source to file path

The image control doesn't show the image. How can I bind it to a file path?
<Image Source="{Binding Image}" />
public string Image { get; set; } // => /home/karl/Desktop/imagetest.jpeg

I think you have to use a custom converter like this one: https://github.com/VitalElement/AvalonStudio.Shell/blob/master/src/AvalonStudio.Shell.Extensibility/Converters/BitmapValueConverter.cs.
Related: #853.

Thanks, that worked!


Add heart plugin configuration for test.

Add heart plugin configuration for test.

/hold

/lgtm

@Summer-Field Is this change for GitOps testing? Please remove for test in the title

@Summer-Field Is this change for GitOps testing? Please remove for test in the title

@Jeffwan OK.

/unhold


Interpretation of Local Moran's I

I'm having trouble wrapping my head around the LISA results. I've created a point pattern which is very localized. Large parts of the network are not covered by any points. However, LL arcs only appear here and there - not nearly as contiguously as I would expect. The same (but maybe not as noticeable) seems to apply to HH arcs.
Why do the results look like this? If there is some statistical reason for this, I'd appreciate any pointers to related reading material.
Here's the full notebook to reproduce this effect:
https://github.com/anitagraser/spaghetti/blob/ab16652b78c5bc576a9c3377563510dfc152cf21/notebooks/debug-counts-on-split-arcs.ipynb

@anitagraser Thanks for this report and the notebook. It does seem to be that this build down to the issue you noticed in #526 and there may be something funky going on in Network.split_arcs. Once #526 gets worked out, we can revisit this.

@jGaboardi thank you! As far as I can tell, split_arcs is not used (at least not called directly by the user) in this case.

As far as I can tell, split_arcs is not used (at least not called directly by the user) in this case.

Indeed, you are correct. I will give this my fullest attention as soon as I can. (PySAL is not my day job... unfortunately... 😆). In the mean time, would you be able to share the clustered point pattern you created for the debug notebook?

would you be able to share the clustered point pattern you created for the debug notebook?

Sure, I've added it to my fork: https://github.com/anitagraser/spaghetti/tree/master/notebooks/data

Anita, you were correct the issue with arc splitting (#526 --> #535) has nothing to do the result you are seeing here. In fact, after further review the LISA plots do appear to be a valid result. Perhaps @slumnitz can chime in here for a better explanation of the LISA plotting and interpretation (also see Exploratory Analysis of Spatial Data: Visualizing Spatial Autocorrelation with splot and esda). As another example, see this gist. Here there are two large synthetic clusters, but I also increased the permutations (see cell 9).
I also plan to add more to the network spatial autocorrelation notebook when I get a chance.

Thanks James! Indeed, it would be interesting to discuss the consequences this has for the interpretation of LISA results for point patterns. If a count of zero points per edge is too close to the expected value to be reliably classified as a cold spot, then it is surprising to see LL edges scattered all over. Any hints would be highly appreciated. (cc @slumnitz)

This also relates to the following new discussion: https://github.com/pysal/spaghetti/discussions/547

Hello @jGaboardi and @anitagraser, sorry for the long silence, I am happy to give this a look but need a couple days to get into the problem. A couple questions to better understand what is going on here: @anitagraser can you point me to the notebook where you do this analysis? I'd like to understand your data and you way of building weights better first. Also which output would you be expecting?

Since this is more of a discussion than an actual bug, I vote we move this to the Discussions board. Any objections @anitagraser @slumnitz?

@jGaboardi and @anitagraser, I am not sure yet if this is a bug or not. splot.esda.lisa_cluster has only ever been tested on polygons, not lines. I'd be actually curious to see the Moran_scatterplot that goes with the indicated plot. I's like to know if the LL street paths have a different value to the ns street parts. If they do not have different values, there might be a bug in splot assigning bins/ labels/ colours when the gdf does not contain polygons. If there are different values, we should investigate why they are different, i.e. assigning points to lines, Calculating weights etc. But intriguing :)

Ah, this is very interesting! I will leave this as an issue for now then. Thanks for looking into this @slumnitz!

To add, but this might not be an issue here: I am not sure if this might be related, but so far 'splot.esda.lisa_cluster' is only tested if the weights, Morans etc have been calculated from that same gdf that is used for plotting. So if weights/ moran are calculated for points and then plotted with lines the assignment will likely not match.

@slumnitz thank you for your insights! The plots above are taken from the following notebook: https://github.com/anitagraser/spaghetti/blob/master/notebooks/debug-counts-on-split-arcs.ipynb

@slumnitz have you had a chance to look at the example above to determine if it's a bug or expected behavior?

@anitagraser I closed this too early! Sorry!


Fix: Rewrite types definitions

List all componens name and status if already converted to ts
https://hackmd.io/y33nfwoTSAiPIm4Efo9kUQ
Aproxx 250 components, all done first phase!

[x] Phase 1 - fix autogenerated - make params optionals
[x] Remove apiExtractor
[x] Configure to send types to distr folder.

The others phase can be done in nexts PRs
~- [ ] Phase 2 - look each component source code and export better types~
~Waiting for https://github.com/1Hive/gardens-ui/pull/796~
How test?

Run yarn build
Copy the ./dist/types/index.d.ts to your gardens-ui project. (eg<EMAIL_ADDRESS>Run yarn build the gardens-ui project
Celebrate!

I wonder if we could prevent having a super big diff. But I guess not many alternatives.

It's possible split it to each component, the first version using autogenerated made that so its possible.
In case will need split each typed and merge in one in the end.


ONNX Inferencing Error

Hello,
Thank you for this great project to properly convert SparseInst to Onnx/TensorRT.
I started training through your updated implementation using a customized version of configs/sparse_inst_r50_giam_aug.yaml and 10 classes
I converted to onnx successfully
python3 convert_onnx.py --config-file configs/sparse_inst_r50_giam_aug.yaml --output on2/myonnx2.onnx --image assets/figures/t1.jpg --opts MODEL.WEIGHTS output/checkpoints/model_0001999.pth

Then when trying to inference using
python3 eval_tensorrt_onnx.py  -c 0.2 --width_resized 640 --height_resized 640 --input assets/figures/* --use_onnx --onnx_engine on2/myonnx2.onnx --output_onnx on2/ --save_image

I'm receiving the below error!
onnxruntime.capi.onnxruntime_pybind11_state.Fail: [ONNXRuntimeError] : 1 : FAIL : Load model from on2/myonnx2.onnx failed:Type
Error: Type parameter (T) of Optype (Add) bound to different types (tensor(float) and tensor(double) in node (Add_398).

Dear @mohamadmansourX, thank you for saying that 😉
Would you mind sharing your ONNX file  with me? Such that I can check it out on netron with the verbose output.
On my ONNX, the last Add node I have a the Add_319 which is link to the "rescoring_mask" definition in the sparseinst.py, called line 229. If it is the case, you should be able to change line 21 wich define mask_pred_ as a float that could possibily be coneverted to double.
Let's see to where your Add_398  comes from ...

Hello, thank you for your reply.
Yeah as you mentioned, after debugging with netron, the issue is in this line:
https://github.com/leandro-svg/SparseInst_TensorRT/blob/1bbff3c2b69ccaaf8053220e4725ab0620a84fed/sparseinst/sparseinst.py#L22
Adding the terms mask_pred_.sum([1, 2]) and 1e-6 is causing that issue.
Tried changing 1e-6 to torch.tensor(1e-6).float() but for some reason it's still being interpreted as a tensor(double)!

Done!!
I solved by converting the array to double then float rather than 1e-6. Not sure why 1e-6 was mapped to double no matter what I do.
My solution:
@torch.jit.script
def rescoring_mask(scores, mask_pred, masks):
    mask_pred_ = mask_pred.float()
    factrr = mask_pred_.sum([1, 2]).double()
    factrr = factrr + 1e-6
    return scores * ((masks * mask_pred_).sum([1, 2]) / factrr.float())


Contribute upstream: span stacktrace

[x] suggest contribution in the SIG meeting/discussion: https://github.com/open-telemetry/opentelemetry-java-instrumentation/discussions/10973
if no, then nothing changes and we can close this issue for now.
if yes, then next steps are likely:

[x] create PR (in java-contrib repo) to contribute upstream, which might also require to also contribute our custom way to modify the spans https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1255
[ ] replace the current implementation with the upstream version once it has been released released in contrib 1.35.0 (release notes).

Additional challenges:

[x] we need to exclude the inferred spans, but inferred spans are specific to our distro for now (can we use a transient, not exported, span attribute on inferred spans to avoid this ?) --> Solved by adding an extra heuristic to filter which spans should have the attribute or not.

While the feature is now part of the 1.35.0 contrib release, it hasn't been published.
I've opened https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1297 to fix that, which hopefully will help us unblock this once the 1.36.0 release is available.

Currently blocked as the contrib 1.36.0 hasn't been released yet.


Path is now transformable.

Hi @awebneck ,
I've made paths, sub paths and directions able to be transformed now.
For example
# for path
path = Parser.parse %Q{C211.003,239.997,253.003,197.997,304.003,197.997}
path.scale( 0.5, -0.5 )
path.translate( 0, 100 )
path.to_command
#=> "C105.5015-19.9985 126.5015 1.0015 152.0015 1.0015"

More examples can be found in spec/transformable_spec.rb .
Some directions are considered "not fully transformable".  e.g. HorizontalTo directions are not directly rotatable. An error will be raised if they are being rotated or skewed.
So two methods , to_transformable_commands! and fully_transformable? are added to paths and sub_paths, to help them get transformed.
However, this is transparent to users. Users only need to call transform , scale or other methods. Savage turns paths fully transformable before applying transforms.
Could you take a review at this?

@qhwa @awebneck is this project dead?

@mrmeszaros pretty much, yeah - haven't updated the lib in ages, don't have any plans to do in the future.

@awebneck I have no experience in doing releases to rubygems.org - so if you could add some starting momentum (eg a README.md on the build/release process), I would gladly take the responsibility of maintaining the project.


Test coverage

sender.spec.ts doesn't work. I am not getting any errors so I am not sure how to fix it. I need some help with it.

Add "resolveJsonModule": true to the compilerOotions of the tsconfig.json of the sender package.
Not sure why the .json files are being picked by NX when we run the tests, this should make sender.spec.ts work.


tensorflow-gpu causes ImportError: cannot import name np_utils

I wanted to switch from theano to tensorflow. Using the default tensorflow module (CPU only) worked flawlessly, but rather slow. So I tried to install/use the GPU version instead:
1. Complete removal of modules:
$sudo pip2 uninstall tensorflow
$sudo pip2 uninstall tensorflow-gpu

2. Installation of tensorflow-gpu
$sudo pip2 install tensorflow-gpu

Now already importing keras is failing with the following error message:
Traceback (most recent call last):
  File "example.py", line 69, in fit
    from keras.models import Sequential, load_model, save_model
  File "/usr/local/lib/python2.7/dist-packages/keras/__init__.py", line 3, in <module>
    from . import utils
  File "/usr/local/lib/python2.7/dist-packages/keras/utils/__init__.py", line 2, in <module>
    from . import np_utils
ImportError: cannot import name np_utils

The same issue using Google Colab


minio storage config mismatch for local project icons

zebrunner: 1.1
reporting: 1.10
Project icons are uploaded but can't be displayed due to the mismatch in the rewrite rule for reporting/configuration/zebrunner-proxy/nginx.conf
old value:
`
location ~ ^/(artifacts|assets|common|users)/ {
limit_except GET {
deny all;
}
      proxy_set_header User-Agent "custom_secret_value";
      rewrite ^/(.*)$ /zebrunner/$1 break;
      proxy_buffering off;
      proxy_pass http://minio:9000;
    }

`
New rewrite is:
rewrite ^/(.*)$ /zebrunner/zafira/$1 break;

fixed: https://github.com/zebrunner/reporting/commit/d2f565ac16f63e29c1eabb9708c7492ac7459518
it should fix corrupted screenshots for web tests. But it might corrupt use-case when AWS S3 integration is needed.
So during the verification we have to setup and test both configs with minio storage and aws s3!
testing might be done using zebrunner/zebrunner (branch: develop).
Acceptance scenario: correctly displayed thumbnails and big screenshots.

Verified on dev.


Secor v0.28 is released

It's been a year since v0.27 is released.  In v0.28, we upgrade the default build profile to kafka-2.0 and include various bug fixes.
Please take a look at https://github.com/pinterest/secor/blob/master/RELEASE.md to see the list of bug fixes.

@HenryCaiHaiying  Thanks for releasing v0.28 , just now i tried to build jars using the codebase of v0.28 tag release but getting this
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.pinterest.secor.uploader.UploaderTest
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.107 s <<< FAILURE! - in com.pinterest.secor.uploader.UploaderTest
[ERROR] initializationError(com.pinterest.secor.uploader.UploaderTest)  Time elapsed: 0.005 s  <<< ERROR!
java.lang.IllegalAccessError: class jdk.internal.reflect.ConstructorAccessorImpl loaded by org.powermock.core.classloader.MockClassLoader @34cd072c cannot access jdk/internal/reflect superclass jdk.internal.reflect.MagicAccessorImpl

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 s <<< FAILURE! - in com.pinterest.secor.io.FileReaderWriterFactoryTest
[ERROR] initializationError(com.pinterest.secor.io.FileReaderWriterFactoryTest)  Time elapsed: 0 s  <<< ERROR!
java.lang.IllegalAccessError: class jdk.internal.reflect.ConstructorAccessorImpl loaded by org.powermock.core.classloader.MockClassLoader @5c448ef cannot access jdk/internal/reflect superclass jdk.internal.reflect.MagicAccessorImpl

[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s - in com.pinterest.secor.common.ZookeeperConnectorTest
[INFO] Running com.pinterest.secor.common.FileRegistryTest
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.002 s <<< FAILURE! - in com.pinterest.secor.common.FileRegistryTest
[ERROR] initializationError(com.pinterest.secor.common.FileRegistryTest)  Time elapsed: 0.001 s  <<< ERROR!
java.lang.IllegalAccessError: class jdk.internal.reflect.ConstructorAccessorImpl loaded by org.powermock.core.classloader.MockClassLoader @6b64429e cannot access jdk/internal/reflect superclass jdk.internal.reflect.MagicAccessorImpl

[INFO] Running com.pinterest.secor.monitoring.OstrichMetricCollectorTest
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.001 s <<< FAILURE! - in com.pinterest.secor.monitoring.OstrichMetricCollectorTest
[ERROR] initializationError(com.pinterest.secor.monitoring.OstrichMetricCollectorTest)  Time elapsed: 0 s  <<< ERROR!
java.lang.IllegalAccessError: class jdk.internal.reflect.ConstructorAccessorImpl loaded by org.powermock.core.classloader.MockClassLoader @64544ee4 cannot access jdk/internal/reflect superclass jdk.internal.reflect.MagicAccessorImpl

[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   FileRegistryTest.initializationError » IllegalAccess class jdk.internal.reflec...
[ERROR]   FileReaderWriterFactoryTest.initializationError » IllegalAccess class jdk.inte...
[ERROR]   OstrichMetricCollectorTest.initializationError » IllegalAccess class jdk.inter...
[ERROR]   UploaderTest.initializationError » IllegalAccess class jdk.internal.reflect.Co...
[INFO]
[ERROR] Tests run: 102, Failures: 0, Errors: 4, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  15.176 s
[INFO] Finished at: 2020-06-20T01:27:37+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project secor: There are test failures.
[ERROR]
[ERROR] Please refer to /Users/karasing/git/secor/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
datacenter:~/git/secor$

i am on macOS, with the following versions, if that helps
datacenter:~/git/secor$ mvn -v
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /Users/karasing/temp/apache-maven-3.6.3
Java version: 14.0.1, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/openjdk-14.0.1.jdk/Contents/Home
Default locale: en_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.15.5", arch: "x86_64", family: "mac"
datacenter:~/git/secor$

I am not sure if I am missing something (it could very likely be, as i am new to java and trying to build the jars). Alternately if you have 0.28, jars that you can release or a Dockerfile that i can use.
Any support would be greatly appreciated

Are you just doing 'mvn clean package"?  I have an Linux env, I didn't see problems.

I synced the code to head (not on v0.28 tag)

@ksingh7 looks like you problem might be related to your java version (14), looks like this issue with MockClassLoader starts with java 9: https://stackoverflow.com/questions/50456726/mockclassloader-cannot-access-jdk-internal-reflect-superclass-jdk-internal-refle

@HenryCaiHaiying  So i tried this
git checkout master
git pull origin master
mvn clean package

but this time as well it failed with exact same error

Here are the java and mvn versions i have

datacenter:~/git/secor$ java --version
openjdk 14.0.1 2020-04-14
OpenJDK Runtime Environment (build 14.0.1+7)
OpenJDK 64-Bit Server VM (build 14.0.1+7, mixed mode, sharing)
datacenter:~/git/secor$
datacenter:~/git/secor$ mvn -v
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /Users/karasing/temp/apache-maven-3.6.3
Java version: 14.0.1, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/openjdk-14.0.1.jdk/Contents/Home
Default locale: en_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.15.5", arch: "x86_64", family: "mac"
datacenter:~/git/secor$

What is your java/mvn version on your Linux workstation, may be i can give it a try on a Linux box. Any other suggestion you may have for me ?

@HenryCaiHaiying  and as per this comment can you please guide me on what test base files i need to add the mentioned annotation ?

So there are a lot of test files, where i need to add
@RunWith(PowerMockRunner.class)
@PowerMockIgnore({"javax.management.", "com.sun.org.apache.xerces.", "javax.xml.", "org.xml.", "org.w3c.dom.",
"com.sun.org.apache.xalan.", "javax.activation.*"})
public class PowerMockitoBaseRunner {
}

Is there a base class, where i can change it once and inherited on all test files ?

java8 definitely works, I am also trying the suggestions from that stack overflow with a java11 build.

After trying this comment

pom.xml

Test file

@HenryCaiHaiying  i have tried a lot with no success, thank a TON for your help so far.
I will go and take some rest, will try again tomorrow.  If you have any tips for me let me know

@HenryCaiHaiying  confirming that build works on java8 (Linux) , flawlessly

Yes, java8 works.  I am still working on java11, fixed a few unit tests but still have a few more to go.

This PR should be able to resolve unit test failures in JDK 11: https://github.com/pinterest/secor/pull/1400

@HenryCaiHaiying   you are awesome, i will give it a try.


gymn1576.txt

GYMN1576

@k070477 I am sorry, the website of this school says:
"Ассоциация школ на большой академической, Москва
Сайт закрыт на техническое обслуживание."
Is there any working official website which we can check to ensure that the domain is owned by the school?

@k070477 Pull request merged. Thank you!


[Store] Error when viewing more options of API Product

Steps to reproduce:

Deploy sample API Product
View it in Store
Click on more - Blank page is rendered with following error:
ERROR - APIMappingUtil Unrecognized state : null

closing since duplicate of https://github.com/wso2/product-apim/issues/5989


Use Function Names as Clues Parsing Lambda's

Make sure we use the fact we are after a Where or Select when parsing multiple lambda's on a line
Improve the error message when we can't tell the difference between mtuple lambda's.

Codecov Report

Merging #116 (a37763f) into master (ace1464) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   96.77%   96.77%
=======================================
  Files          15       15
  Lines        1272     1272
=======================================
  Hits         1231     1231
  Misses         41       41

Flag
Coverage Δ

unittests
96.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

func_adl/util_ast.py
92.18% <ø> (ø)

func_adl/object_stream.py
98.93% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


run with Docker

For Docker fans or anyone want to run it inside a docker, which is a powerful tool for shipping your project, you can visit my git repository.
 No need to install tensorflow, pycharm, ect.

Very nice, great job!

Cool, you might want to use named volumes in the compose file. I will take a look later.

This is a dev container, how about a production container for running trained model?

page not found

Hi @yun-long , can you update these link, please?, it 404 now.


Random 501 errors when refreshing token

Starting on Wednesday June 8th, we are getting randomly 501 errors when trying to refresh tokens:
{"error": {"code": 501, "status": "UNIMPLEMENTED", "message": "Operation is not implemented, or supported, or enabled."}}

Here is the code that generates this error:
$client = new \Google_Client();
$client->setApplicationName(config('google.APP_NAME'));
$client->setClientId(config('google.CLIENT_ID'));
$client->setClientSecret(config('google.CLIENT_SECRET'));
$client->setAccessType('offline');

$client->setAccessToken(TOKEN);

if ($client->isAccessTokenExpired()) {
      \Log::debug("access_token expired");
      $refresh_token = $client->getRefreshToken();
      $new_access = $client->fetchAccessTokenWithRefreshToken($refresh_token);

     // $new_access sometimes returns this error {"error": {"code": 501, "status": "UNIMPLEMENTED", "message": "Operation is not implemented, or supported, or enabled."}}
}

When we manually connect again the Google account (which generates and stores a new refresh token), the accounts refreshes correctly, and then after a few refresh fails again with a 501 error

Are you using Google Ads? If so, it could be related to this thread:

With regards to your concern, it may be related to the release of our latest version v11, which was indeed released yesterday along with the deprecation of the previous release, v10.

For further information about releases, deprecation and sunsets schedule, you can have a look here.

It sounds like they released a new version of Ads, and so your error could potentially be coming from the Ads API rather than the token refreshing. It also sounds like the issue should already be resolved. Can you confirm if it's still happening?

We are not using the Google Ads API (this issue happens when we refresh the token, which is API independant I guess?), but it might be the same issue impacting Google's infra?
The issue is still happening randomly, during the night we again had accounts that could not refresh, with this 501 error

This is not an error message I've seen in the past, or am familiar with. This repo supports the client libraries only, and this appears to be a backend issue (the 5xx error is an error caused by the server), there's not anything we can do. I know that's not a satisfying answer, so I'll keep digging. In the meantime, if you have a paid support plan with Google Cloud, you can open a support ticket.


Default credentials used for any host

When I got a config like this:
{
  "artifactory": [
    {
      "url": "https://a.net/artifactory/",
      "apiKey": "AKCp5Z[...]exqhkf",
      "serverId": "a.net",
      "isDefault": true
    }
  ],
  "Version": "1"
}

and I do this on the CLI:
$ jfrog rt s my-repo/my-tool* --url=https://b.net/artifactory

the CLI is accessing b.net using the credentials for a.net from the config file.
I consider this a security risk.

@Alexander-Haas,
Thanks for reporting this issue.
Version 1.14.0 has been released and includes a fix for this.
We'll appreciate you feedback for that.

Thank you for your swift action.
I tested it and found it resolved.


Ngspice: fixed ngspice-41_64.7z hash

current hash value is wrong this pr fixed hash check

/verify


A solve for issue #832

Hello @asweigart , I found a way to implement the feature you requested and close #832 .
I noticed every function that can be called by the user is decorated with @_genericPyAutoGUIChecks, so I thought I'd add the flag PYAUTOGUI_DEBUG_MODE, which, when set to True, makes a window appear whenever one of those functions is called. The execution of the code is halted until the user presses the chosen PYAUTOGUI_DEBUG_CHAR on the keyboard.
This way the user can check if everything is happening as expected without altering the execution.
Please tell me if it's ok or if it needs any changes.
Davide

Hello @codespearhead and thank you, is it ok like this? I already saw this PR linked in issue #832 page though.


auto-import always import from "@material-ui/core" instead of "@material-ui/core/SomeComponent"

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

When starting to write "MenuIte..." in my IDE (vscode) I want auto-import to suggest "@material-ui/core/MenuItem"
Current Behavior 😯

The auto-import does:
import { MenuItem } from '@material-ui/core';

The consequence is that unless there is a bundlesize check on CI, there is a chance to load all material-ui without even noticing it.
Steps to Reproduce 🕹

I use the vscode native auto-import.
Context 🔦

I guess this is not due to a wrong personal configuration but due to material-ui type definitions?
Your Environment 🌎

Tech
Version

Material-UI
v4.3.0

I'm sorry, I took the latest version in the releases because I installed material-ui yesterday I realized right now that you released version 4.3 a few hours ago with improvement about imports so this issue is probably obsolete.

@nicgirault 1. I would encourage the suggested import. 2. I'm not aware of any leverage Material-UI has on the behavior of Visual Code auto-import feature.


Multiple sessions

Hi,
My goal is to have multiple inappwebview sessions in my app so that they each have their own state and do not share anything. I tried using UniqueKeys to distinguish between web views but it seems the cookies on the first web view are being used by the second web view. Any guidance on how to fix this?

I made some research to check if it is possible to do this in Android, but it seems not possible. The problem is not related to any Flutter API, such as UniqueKeys. Probably it is related to how Android manage cookies for all the WebViews.

I am trying iOS not Android.
On Tue, Jun 2, 2020 at 6:30 AM Lorenzo Pichilli<EMAIL_ADDRESS>wrote:

I made some research to check if it is possible to do this in Android, but
it seems not possible. The problem is not related to any Flutter API, such
as UniqueKeys. Probably it is related to how Android manage cookies for
all the WebViews.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pichillilorenzo/flutter_inappwebview/issues/371#issuecomment-637447574,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGH6KGHZUTY6ECC72UDFICLRUTIFJANCNFSM4NQOY44Q
.

I can do this with multiple WKWebView instances in Swift so I am wondering if it was possible with this plugin

Ok, I found a bug in my code for the iOS platform. I was setting some WKWebView configurations too late. This will be fixed in the next release!
It seems that to have multiple sessions on iOS, I need to use configuration.websiteDataStore = WKWebsiteDataStore.nonPersistent() for each WKWebView you want to have without sharing cookies.
This is done through the incognito: true option.
Now incognito option is broken on iOS, but I'm going to fix it right now.

Awesome thank you!
On Tue, Jun 2, 2020 at 7:40 PM Lorenzo Pichilli<EMAIL_ADDRESS>wrote:

Ok, I found a bug in my code for the iOS platform. I was setting some
WKWebView configurations too late. This will be fixed in the next release!
It seems that to have multiple sessions on iOS, I need to use configuration.websiteDataStore
= WKWebsiteDataStore.nonPersistent() for each WKWebView you want to have
without sharing cookies.
This is done through the incognito: true option.
Now incognito option is broken on iOS, but I'm going to fix it right now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pichillilorenzo/flutter_inappwebview/issues/371#issuecomment-637863152,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGH6KGGF2QXL34X27DO5A33RUWEVJANCNFSM4NQOY44Q
.

New version 3.3.0+3 released!

I am facing the same problem dealt with @owenkealey here.
The cookies are not stored only when there is an incognito version is present, which I believe would mean that maybe that feature is causing the problem.
I have tried the same code sample provided by @pichillilorenzo in this page. The same Gmail example provided, does not always persist the data all the time.
You can even try using other OAuth enabled sites such as Medium.com or similar.
@pichillilorenzo Could you please look into this?

@pichillilorenzo @owenkealey
I experimented around a bit, and found that while in incognito mode, the cookies for example are wiped clean to default state, the cookies are not filled with the default values once the incognito mode is turned off.
What could be the reason for this?

I made some research to check if it is possible to do this in Android, but it seems not possible. The problem is not related to any Flutter API, such as UniqueKeys. Probably it is related to how Android manage cookies for all the WebViews.

Hi , is it still not possible to have multiple inappwebview sessions without sharing state or anything ?
I'm making a dapp wherein i have to connect with the same web3 site on two different webviews but with different wallets .... can u help me with that?


Recipes with multiple CSS files only show one

Recipes that import multiple CSS files only show one of them. For example, https://cookbook.vaadin.com/dynamic-combobox-item-background-color.

Actually, not a bug. But a case of missing sourceFiles entry in the recipe.


Status Message Frequency

The controller status message posts when the run/stop switch is moved, and upon powerup.  Is there a way to get that status message re-posted to MQTT more frequently?
When a new MQTT client connects, it has no way to know the status until the status changes.

I have updated the service and converted it to cyclic publish, rather than only on change of state event.  I have built this into a Docker container as well.  See the project here: https://hub.docker.com/r/jessejamescox/pfc-kbus-api
note: the API has changed.

Any chance of getting those changes rolled into this repository? Reason being I'm using a PFC-100 which cannot run docker unless the system is on SD card, which isn't a great solution.
Thank you!


Sentence check

Pull Request Test Coverage Report for Build 31

12 of 12 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.8%) to 95.885%

Totals

Change from base Build 29:
1.8%

Covered Lines:
233

Relevant Lines:
243

💛  - Coveralls

Pull Request Test Coverage Report for Build 31

12 of 12 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.8%) to 95.885%

Totals

Change from base Build 29:
1.8%

Covered Lines:
233

Relevant Lines:
243

💛  - Coveralls


feat(dotcom-shell): added a story featuring horizontal-toc

Description
I've added a story under Dotcom-shell that features the horizontal top and leadspace.
Related issue
#5696

Not sure if this is ready for review yet, but here's what I noticed:

Quite a big space between lead space and ToC. Should be 0 gap there

When clicking on ToC, section scrolls too far and disappears a bit under the ToC. Should scroll less so all of the section's header is visible, and 32px from ToC

L0 should unstick & scroll away when ToC becomes sticky.

Not sure if this is ready for review yet, but here's what I noticed:

Quite a big space between lead space and ToC. Should be 0 gap there

When clicking on ToC, section scrolls too far and disappears a bit under the ToC. Should scroll less so all of the section's header is visible, and 32px from ToC
L0 should unstick & scroll away when ToC becomes sticky.

Hey Shixie, currently this story is being created to test how both headspace and horizontal toc are working together, so these points should be addressed in separate prs

Hey Shixie, currently this story is being created to test how both headspace and horizontal toc are working together, so these points should be addressed in separate prs

I'm all for iterative approaches, but I'm wondering if we should wait to merge the story in for the public to see until some of these major bugs are fixed?

Do you recommend a separate PR because the bug is happening outside this Dotcom shell component? Is it happening in ToC? We just filed a lot bugs in ToC and I don't remember seeing this. If this bug only surfaces in Dotcom shell and no where else, I think we should still fix in the same PR, just to make sure new things are not shipped broken since the start.

Is it related to this story? https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/5569

I gotcha, okay then let's quickly get to the ToC and lead space issue fixes. Are these fixes within the scope of this PR?

Body content should be sitting on the grid, currently 16px too far to the right

Remove knob for Platform. We do not allow this option to our users. Even Cloud has a specific design that's not this. When we get to clean up the Dotcom shell story, we will look into removing it all around.

Rename sub-story to "With ToC horizontal"

Knob selected menu item should be a dropdown with existing options in L0, not a text-input

Knobs should not allow tabs. Add the knobs in "FooterComposite" into the same tab and remove tabs. In general avoiding tabs help with discoverability.

So in summary, the Dotcom shell - story should look like this:
Dotcom shell
|--- With ToC horizontal

Knobs in the story are:

Name
Type
Default value

Show profile in masthead
Checkbox
Checked

Show search in masthead
Checkbox
Checked

Search placeholder
Text input
Search all of IBM

Selected menu item
Dropdown
Services & Consulting

User authentication
Dropdown
unauthenticated

Thanks!

Hi Raph, this is great. The only thing missed is this! Sorry to be nitpick. If this is not possible, we can also address later along with platform.

[ ] Knob selected menu item should be a dropdown with existing options in L0, not a text-input
image

Hey @RaphaelAmadeu just checking on this, this PR is a couple of weeks old now so wanted to see if we can get this moved in? Also looks to be some ci-check failures if you can take a look!

Hey @RaphaelAmadeu , can you look to see why the web components ci-check is failing?

@RaphaelAmadeu the language only stories seemed to have been affected by this, they are loading the locale modal button and not the language only selector. can you check?

Hey @RaphaelAmadeu ! Just checking on status of this, thanks!


Fix sexp matcher bug

This PR does the following to the specs concerning deployment conditions

Fix match_sexp matcher. The intention of this matcher is to return success if the result returned by sexp_find is not empty, but we were only testing if it was a truthy value. Since [] is, this matcher always succeeded.
Fix incorrect specs. The issue above resulted in many specs that were giving incorrect results; specs had fallen out of sync with the code, but they were not manifest in previous builds.
Tweak the sexp_find helper. The change makes its recursive nature more readily apparent.

Huge props to @joshcheek, who paired with me and worked out some confusing parts of the code.

@BanzaiMan @joshcheek amazing, this thing never worked?
Your PR looks good to me.
LGTM!
❤


[Bug] Topic copy past bug

What did I do
Something you have done.
I connect to the broker, pastint  the topic string that include "EJ65mmcIl4IPlKJ4E" into the pyload topic (bottom right corner)
What happened
Get an error.
when I copy it back I got "EJ65mmcll4IPIKJ4E". It looks same but 8th and 13th letter are exchanged.
Expected
What is the expected result.
It should not change what I pasted.
Environment

OS: OS version, e.g. macOS Monterey 12.4
MQTTX version, e.g. v1.9.2

More detail
The most  important thing is that I copy that string from CLion 2022.3.2 or VScode  Version: 1.78.2
More detail include log information or screenshot

Thank you for bringing this to our attention. This issue is a character encoding or display problem, possibly caused by the software (CLion, VScode, or MQTTX) or a system-level issue.
To help us better diagnose the problem, please try copying and pasting the string from different applications to see if the issue persists. Also, could you provide the Binary, Hex, or Base64 string representation before and after the copy-paste operation?
This information will help us understand whether this issue is specific to MQTTX. If so, we'll do our best to locate and fix it. Please provide as much detail as possible, including reproduction steps and your environment information.
Thanks!

Here are the hex :
EJ65mmcIl4IPlKJ4E :
45 4A 36 35 6D 6D 63 49 6C 34 49 50 6C 4B 4A 34 45
EJ65mmcll4IPIKJ4E:
45 4A 36 35 6D 6D 63 6C 6C 34 49 50 49 4B 4A 34 45
I've update the latest version of MQTTX, I cannot reshow this.
The problem exit at that time. However it is disappear.


[nrf noup] workflows: Update the commit tags action

nrf-squash! [nrf noup] ci: NCS-specific CI tweaks
Adapt to the changes in:
https://github.com/nrfconnect/action-commit-tags/pull/4

@nrfconnect/ncs-code-owners can I get reviews?
I will switch the revision from pull/4/head to main after this is approved and ready to merge.


Only working sometimes / somewhat

I have the app installed and set to run at startup, authorized it, turned it on, and put it above Visualizer on the Chroma Apps segment of the Synapse app... but it only works sometimes. When I don't have the Discord app focused it turns green when I get a message, for instance, but if I get a message when I'm in Discord it doesn't work. Is it supposed to do that? Also nothing happens when I join or leave a voice channel. And it won't let me customize what the animations are, even when I uncheck "Connect to Discord Events," everything stays greyed out.
Thanks!

One thing I added to the documentation is I realized your Discord status has to be online to get the message events.


Implement shape support for BottomSheet

In order to provide further customizability, the BottomSheet component should have an API to specify a custom ShapeBorder in a similar way to Dialog and Card.

CC @dnfield

Appears to be the same issue as https://github.com/flutter/flutter/issues/26854


Various Fixes for Podman/ Docker

From the latest have updated to fix the following, mainly for podman but tested with both docker and podman on xwayland, x11, wayland in both KDE (Manjaro) and Gnome (Fedora).

podman/ docker now detected in entrypoint and script split to start correctly.
properly supports xwayland using xAuthority
fixed permissions when setting up new zwift user volume for podman
added ability to specify user and group id in podman
can locally build and run in podman using bin/test-build.sh (also works for docker)
fixed entrypoint for docker initial build when using same userid as host
fixed passing of arguments from test-build.sh and zwift scripts

Wayland i tried to fix, it starts wine notepad however zwift complains about screen size and doesn't work correctly.

@hobeone do you have any inputs on this?

Only other input is Thank You for doing all of this!

Your bash skills are a notch above mine 👍
lgtm,. however one question.

I have been coding for over 35 years, I actually was trying not to change too much :)
I am more than happy to help with Podman integration and Wayland as this is what I use for my other developments.

Fixed the comments above, I have updated bin/test_build.sh to trap for errors and clean up after (annoying if you have to manually delete the container on failure).
I didn't update the bin/build.sh but the test one should work for both Podman and Docker, if you are happy I will move it into build.sh and update the readme.
I am just running docker tests now.

Ok docker is working but when I try using a different ZWIFT_UID/GID I get an error later when starting, this might just be because I am not using it right as not sure why it would be used.
The entrypoint is setting all the permissions correctly and setting up the right mapping.  Can you seee if that part works?

What error are you seeing?

What error are you seeing?

Looks like an error from the runfromprocess-rs binary. @quietvoid

The process PID is probably invalid.

This is only when I put ZWIFT_UID and ZWIFT_GID different to my local id of 1000.  Without setting those it works fine.

ok got it, because I mount /run/user/??? directly it is not setting the ownership correctly. Problem is /run/user//?? is neede for wayland, need to re-adjust.

Have changed it back a bit, so basically to use Wayland or XWayland we need to map /run/user/xxxx, however doing this means you can not change ownership of /run/user/xxxx to the UID/ GID provided in ZWIFT_UID and GID.
So in short at the moment if you use ZWIFT_UID / GID you have to use X11, but wayland works for default.
Will look into this more but fixed to Podman/ Docker works with defefault in Wayland and X11 but adding ZWIFT_UID/GID requires using X11

Found a couple of minor issues with podman savng documents and sound since fixing the ZWIFT_UID issue.

Nice, is it all done now or are there any remaining issues?

Just testing and one more I notice the update script should e reversed, "UPDATE" should be checked after install is checked.

Fixed Tested with ZWIFT_UID and docker (podman fails for some weird reson but nearly works)
Fix Audio on Docker
Build now supports docker and podman
Fixed Podman permissions
Tested everything I can

Weirdly Podman now supports using ZWIFT_UID under X11 not sure how that happened.

I this all good now anything else you notice?

What is the reasoning behind the different names? i.e why when podman you have localhost/zwift instead of netbrain/zwift? relic from testing?

What is the reasoning behind the different names? i.e why when podman you have localhost/zwift instead of netbrain/zwift? relic from testing?

Think you missed my answer or it's not commenting properly from my phone.
Podman always prefixes with localhost automatically unless you build against a real domain. So wasn't really a choice to use localhost for podman local build.

Thanks for your contribution, The community appreciates it!

Just got around to test this myself now, seems to work well. :clap:  Have released this as a new image built from scratch. So for the next upcoming releases we'll see if the updating routine works aswell.

Just got around to test this myself now, seems to work well. 👏 Have released this as a new image built from scratch. So for the next upcoming releases we'll see if the updating routine works aswell.

Perfect glad I can help i am more than willing to help in the future I use this a few times a week and it was one of the last things I used windows for, really appreciate the effort you have all putin to make this work so happy I can assist.

Happy to hear! 🤗


Streams 306

loosens criteria for ThroughputQueueSingleThreadTest
adopts Uninterruptibles.sleepUninterruptibly in
ThroughputQueueMulitThreadTest and BroadcastMonitorThread
(also includes STREAMS-305)

tests still failing


fix: Adjust cross-train to use id as key-value instead of path in config

Description
use file names without any path or extension in config.
need to wait for the @microsoft/bf-lu nightly build

Task Item
refs https://github.com/microsoft/botframework-cli/pull/1030
#minor

Screenshots

Please don't merge this PR

Close this PR, fixed in #4549


Adding support for BigQuery

I have been checking out Narwhals, I am impressed by what it can do and I’d like to use it more with my regular work.
Is there any plan to support BigQuery?
Either via SQL or via its BigQuery Dataframes API which has a Pandas-like API. More details below:
https://cloud.google.com/bigquery/docs/reference/bigquery-dataframes
i can imagine writing code once with Narwhals (Polars) syntax then running it on BigQuery for big data and Polars for small to medium data.

thanks @lucazanna for the request!
for the moment, I think sql/substrait are out-of-scope, because I want to enable dataframe operations such as
df.select('a', nw.col('b').sort())

on which sql frontends like Ibis raise. There was a request for substrait here https://github.com/MarcoGorelli/narwhals/issues/53 but I'm not sure about it any more
I think Ibis already support bigquery though (https://ibis-project.org/backends/bigquery), so that might be a better solution for what you're trying to do?
This is the kind of use-case I had in mind for Narwhals: https://github.com/FBruzzesi/timebasedcv/pull/38/files - realistically I don't think I'll be able to make it feature-complete enough to useful for serious analytics work (which I think is more what Ibis's goal is?)
cc @lostmygithubaccount for comments, in case I've misrepresented things on the Ibis side

you could achieve something like this in Ibis (and SQL in general):
df.select('a', nw.col('b').sort())

but it involves adding a row_number, splitting into two tables, and then rejoining after sorting the b table -- it's a bit convoluted:

[ins] In [1]: import ibis

[ins] In [2]: import polars as pl

[ins] In [3]: ibis.options.interactive = True

[ins] In [4]: data = {"a": [0, 1, 2, 3, 4], "b": [2, 1, 3, 0, 4]}

[ins] In [5]: t = ibis.memtable(data)

[ins] In [6]: df = t.to_polars()

[ins] In [7]: t
Out[7]:
┏━━━━━━━┳━━━━━━━┓
┃ a     ┃ b     ┃
┡━━━━━━━╇━━━━━━━┩
│ int64 │ int64 │
├───────┼───────┤
│     0 │     2 │
│     1 │     1 │
│     2 │     3 │
│     3 │     0 │
│     4 │     4 │
└───────┴───────┘

[ins] In [8]: df
Out[8]:
shape: (5, 2)
┌─────┬─────┐
│ a   ┆ b   │
│ --- ┆ --- │
│ i64 ┆ i64 │
╞═════╪═════╡
│ 0   ┆ 2   │
│ 1   ┆ 1   │
│ 2   ┆ 3   │
│ 3   ┆ 0   │
│ 4   ┆ 4   │
└─────┴─────┘

[ins] In [9]: df.select("a", pl.col("b").sort())
Out[9]:
shape: (5, 2)
┌─────┬─────┐
│ a   ┆ b   │
│ --- ┆ --- │
│ i64 ┆ i64 │
╞═════╪═════╡
│ 0   ┆ 0   │
│ 1   ┆ 1   │
│ 2   ┆ 2   │
│ 3   ┆ 3   │
│ 4   ┆ 4   │
└─────┴─────┘

[ins] In [10]: t = t.mutate(row_number=ibis.row_number()).relocate("row_number")

[ins] In [11]: t
Out[11]:
┏━━━━━━━━━━━━┳━━━━━━━┳━━━━━━━┓
┃ row_number ┃ a     ┃ b     ┃
┡━━━━━━━━━━━━╇━━━━━━━╇━━━━━━━┩
│ int64      │ int64 │ int64 │
├────────────┼───────┼───────┤
│          0 │     0 │     2 │
│          1 │     1 │     1 │
│          2 │     2 │     3 │
│          3 │     3 │     0 │
│          4 │     4 │     4 │
└────────────┴───────┴───────┘

[ins] In [12]: a = t.select("row_number", "a")

[ins] In [13]: b = t.select("row_number", "b")

[ins] In [14]: a
Out[14]:
┏━━━━━━━━━━━━┳━━━━━━━┓
┃ row_number ┃ a     ┃
┡━━━━━━━━━━━━╇━━━━━━━┩
│ int64      │ int64 │
├────────────┼───────┤
│          0 │     0 │
│          1 │     1 │
│          2 │     2 │
│          3 │     3 │
│          4 │     4 │
└────────────┴───────┘

[ins] In [15]: b
Out[15]:
┏━━━━━━━━━━━━┳━━━━━━━┓
┃ row_number ┃ b     ┃
┡━━━━━━━━━━━━╇━━━━━━━┩
│ int64      │ int64 │
├────────────┼───────┤
│          0 │     2 │
│          1 │     1 │
│          2 │     3 │
│          3 │     0 │
│          4 │     4 │
└────────────┴───────┘

[ins] In [16]: b = b.order_by(ibis._["b"]).mutate(row_number=ibis.row_number())

[ins] In [17]: c = a.join(b, a["row_number"] == b["row_number"])

[ins] In [18]: c
Out[18]:
┏━━━━━━━━━━━━┳━━━━━━━┳━━━━━━━┓
┃ row_number ┃ a     ┃ b     ┃
┡━━━━━━━━━━━━╇━━━━━━━╇━━━━━━━┩
│ int64      │ int64 │ int64 │
├────────────┼───────┼───────┤
│          0 │     0 │     0 │
│          1 │     1 │     1 │
│          2 │     2 │     2 │
│          3 │     3 │     3 │
│          4 │     4 │     4 │
└────────────┴───────┴───────┘

[ins] In [19]: t = c.drop("row_number")

[ins] In [20]: t
Out[20]:
┏━━━━━━━┳━━━━━━━┓
┃ a     ┃ b     ┃
┡━━━━━━━╇━━━━━━━┩
│ int64 │ int64 │
├───────┼───────┤
│     0 │     0 │
│     1 │     1 │
│     2 │     2 │
│     3 │     3 │
│     4 │     4 │
└───────┴───────┘

[ins] In [21]: ibis.to_sql(t)

WITH "t1" AS (
  SELECT
    "t0"."a",
    "t0"."b",
    ROW_NUMBER() OVER (ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) - CAST(1 AS TINYINT) AS "row_number"
  FROM "ibis_pandas_memtable_ahfbrvvgdbg2lhntwfxyeld5uu" AS "t0"
)
SELECT
  "t8"."a",
  "t8"."b"
FROM (
  SELECT
    "t4"."row_number",
    "t4"."a",
    "t7"."b"
  FROM (
    SELECT
      "t2"."row_number",
      "t2"."a"
    FROM "t1" AS "t2"
  ) AS "t4"
  INNER JOIN (
    SELECT
      ROW_NUMBER() OVER (ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) - CAST(1 AS TINYINT) AS "row_number",
      "t5"."b"
    FROM (
      SELECT
        "t2"."row_number",
        "t2"."b"
      FROM "t1" AS "t2"
      ORDER BY
        "t2"."b" ASC
    ) AS "t5"
  ) AS "t7"
    ON "t4"."row_number" = "t7"."row_number"
) AS "t8"

Either via SQL or via its BigQuery Dataframes API which has a Pandas-like API. More details below:
https://cloud.google.com/bigquery/docs/reference/bigquery-dataframes

BigQuery dataframes is built on top of Ibis and to achieve the pandas-like semantics does something like this -- adding an outer ORDER BY clause on indices they maintain. pandas API -> Ibis expressions + extra handling for pandas semantics -> BigQuery SQL

closing then as out-of-scope, will leave this to other projects, thanks for reponses!


Remove the ability for a mentee to select a specific mentor

Bug Report
What is the current behavior?
When signing up for a mentor via the site, mentees are able to pick from a list of every single email tagged as a mentor.
What is the expected behavior?
We do not want to make our mentor's emails public. This is bad juju for privacy reasons.

@hollomancer I'm not so sure I understand the expected behavior. do we want the email addresses of the mentors hidden?

@tal87 I That is correct. Users should be able to choose a mentor if they have a preference, but the mentor's email addresses should not be exposed to the public.  We need to respect our mentors' privacy.

@jjhampton I understand.
How does choosing a mentor work? When I click on one of the mentors I get a popup with the same details that are on the table.
Also, I was thinking of adding some margin so the table won't take the whole width of the page. What do you think?

I could go for the margin change, but let's put it in a separate PR.

I think we need user profile editing by new (non-verified) users and mentors. We need to define a user permissions schema, if there isn't one already. I have no idea where to find it. The backend has so many folders, many named the same things.

@tal87 re: 'How does choosing a mentor work'? Currently, when submitting a Mentor Service Request via the form at https://operationcode.org/mentor-request, a mentee can select a mentor by name from the dropdown select (which currently shows mentor emails). This is optional - mentees may not know who the mentors are.  They can also reach out for help directly in the Slack channel to any mentor.  I think we could simply show mentor names (or Slack usernames) for now, to protect privacy.
The mentor table at https://operationcode.org/mentors that also exposes emails appears to have been created in response to issue #79 .
At a minimum, we can keep the current UI, but remove emails from being displayed in both places.

@jjhampton Got it. Thanks!

Eventually, we can also add some enhancements to the table at https://operationcode.org/mentors - looks like that's still the MVP version.  There's some potential there to make it more useful for members to use and help match mentors/mentees.


ensure_fully_multiline format more than needed

I've found that method_argument_space with ensure_fully_multiline as true (as is set in PSR-2) is messing with other code not related.

PHP versions: 7.0 & 7.1 (other not checked)
PHP CS Fixer 2.4.0 Silver Gingerbread by Fabien Potencier and Dariusz Ruminski

php-cs-fixer fix --using-cache=no --rules='{"method_argument_space": {"ensure_fully_multiline": true}}' example.php
<?php
exit(call_user_func(function () {
    echo "a", "b",
        "c", "\n";
    return 0;
}));

Result (why is this considering that the function must be in a new line?):
<?php
exit(call_user_func(
    function () {
    echo "a",
    "b",
        "c",
    "\n";
    return 0;
}
));

Expected (repair only the echo line, don't touch anything else):
<?php
exit(call_user_func(function () {
    echo "a",
    "b",
        "c",
    "\n";
    return 0;
}));

Another exampĺe. In this case it is expected that method_argument_space don't change anything.
In the first case, the inner echo line with 3 arguments are in 3 different lines, the method_argument_space does not change anything on this line but it does in call_user_func moving function to a new line.
In the second case, the inner echo with 3 arguments all in 1 line, the method_argument_space does not change anything, not even in call_user_func as in the previous case.
<?php
call_user_func(function ($arguments) {
    echo "a",
        (X) ? 'T' : 'F',
        "\n";
}, $argv);

call_user_func(function ($arguments) {
    echo "a", (X) ? 'T' : 'F', "\n";
}, $argv);

--- Original
+++ New
@@ @@
 <?php

-call_user_func(function ($arguments) {
+call_user_func(
+    function ($arguments) {
     echo "a",
         (X) ? 'T' : 'F',
         "\n";
-}, $argv);
+},
+    $argv
+);

nice catch
could you send a fix @eclipxe13 ?

So to sum up the bug: if an argument to a function is a function with a multiline "function" call in it, the outer function is detected as needing to become multiline?

sorry @keradus, I have no idea how to fix it, I will take a look tomorrow but I can't promise anything

I'm looking into it right now.

The bug occurs only when the inner function requires a multiline fix.

Oh wait no it's not exactly that, it works fine when it is a broken function call

Oh wait no it's not exactly that, it works fine when it is a broken function call. It really is about echo...

@eclipxe13 I don't think echo should be fixed at all BTW. The spec is about methods and function, which echo is not.

@greg0ire, your deduction is fine according to the last example. I would add that if the outer function need to become multiline then forces inner echo multi parameter calls to become multiline. See the following example:
<?php
call_user_func(function ($arguments) {
    echo "a", "foo", "\n";
},
$argv);

Result (mess with echo):
<?php
call_user_func(function ($arguments) {
    echo "a",
    "foo",
    "\n";
},
$argv
);

Expected (don't touch the echo):
<?php
call_user_func(
    function ($arguments) {
    echo "a", "foo", "\n";
},
$argv
);

Diff:
--- Original
+++ New
@@ @@
 <?php
-call_user_func(function ($arguments) {
-    echo "a", "foo", "\n";
+call_user_func(
+    function ($arguments) {
+    echo "a",
+    "foo",
+    "\n";
 },
-$argv);
+$argv
+);

BTW, if you change the echo to a parenthesis call like myecho("a", "foo", "\n"); or a single argument echo "a" . "foo" . "\n" then it does what is expected.
May the problem be in how echo with more than 1 parameter is interpreted?
--- Original
+++ New
@@ @@
 <?php
-call_user_func(function ($arguments) {
+call_user_func(
+    function ($arguments) {
     echo "a" . "foo" . "\n";
 },
-$argv);
+$argv
+);

Here is a fix for the first bug: https://github.com/greg0ire/PHP-CS-Fixer/commit/6392ef2e6b493605b0e585f55b525aff264596be

I had test previous examples changing the echo A, B, C to myecho(A, B, C) and it behaves as expected. So is valid to point out that the problem is echo multi parameter related.
| I don't think echo should be fixed at all BTW. The spec is about methods and functions, which echo is not.
php docs about echo: echo is not actually a function (it is a language construct), so you are not required to use parentheses with it ... . Additionally, if you want to pass more than one parameter to echo, the parameters must not be enclosed within parentheses.
PSR-2 spec is about: "4.4 Method Arguments" and "4.5 Method and Function Calls"
I don't know how this project deals with multi parameter echo. It is very common to treat it like a function call.

I don't know how this project deals with multi parameter echo. It is very common to treat it like a function call.

Yeah maybe but I did not sign up for this :P I'll just fix the bug for now.

In addition to the laziness argument (or excuse), some people might disagree with you on whether this needs to be fixed or not. Let's not fix that if they don't want use to. If you want to introduce this one day, make sure to make it optional.

I think is valid to discard echo calls. I have seen code like:
echo _("Title"), "\n",
    "foo: ", _("Foo explanation"), "\n",
    "bar: ", _("Bar explanation"), "\n",
    _("Other line of information"), "\n";

And your fixer change it to:
echo _("Title"),
    "\n",
    "foo: ",
    _("Foo explanation"),
    "\n",
    "bar: ",
    _("Bar explanation"),
    "\n",
    _("Other line of information"),
    "\n";

In the end, there are no explicitly rule to change this since "echo is not a function".

Thanks for this! It helped me with a [$a, $b, $c] = explode(); call being put on multiple lines when in the body of a closure used as an argument.
Could you please release a patch version with this? Thank you!


Fix running on Xcode 14.1

Remove Warning: Format string is not a string literal (potentially insecure)

@numandev1 Please merge as NSLog(stringfyData) cause issue since the Xcode 14.1 update.


Precedence issue 190

Description

Motivation and Context

This change addresses issue #190
How Has This Been Tested?

This has been tested against the example submitted in the issue and make test.
make test returned errors because Quantum Experience is currently down for maintenance. The number of errors was the same as performing the tests in the master branch. I do not include new tests.
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Thanks @adjs this looks great. I think we can merge soon.

Thanks, @adjs - neat fix!


Golangci lint

This pull request changes the static analysis to use golangci-lint which is 5x faster than using the tools separately and adds a lot more checks and fewer false positives.
I have fixed all the existing problems as  separate commit: I had to fix a lot of missing error handling so please pay close attention to that commit
This partially fixes #149 but more investigation is needed to investigate why module downloading has slowed considerably

One acceptance test is broken :( It loks like expect is doing something funky with stderr.  I'll fix


Add browser icon to version badges

Shields recently added support for simple-icons for using various icons on badges.
Before

After

Alternate: Just add icon to badge without modifying the labels

On OSX for comparison:

It doesn't look too bad, but it no longer looks like an actionable item. Badges are usually "see and forget", not the main CTA

How about the alternate version with just the browser icons without any labels and keeping the existing text ?
I'll update the PR if that looks okay.

The icon spacing is off 😃

Badge labels are kept as empty space like current behavior. Leaving it blank would fallback to default labels (mozilla add-on/chrome web store) . Specifying browser/store names was too long, May be abbreviated form of store names like  AMO and CWS as badge labels ?

I don’t think any of this adds anything


Taking Rules seriously

There are lots of changes here. Most notable:

introduce native Rule struct that localizes the isactive information → no need to keep track of i, j and what not
iteration over rules of rws is storage agnostic now. returned rules are active at the time of iteration
knuthbendix2 uses (a much simplified) kbWork by default now
new Rules are created (and oriented) only when a pair turns out to be critical. This saved allocations MASSIVELY.
rewrite_from_left!(v,u,rws) semantic was changed: we no longer append to v, we write over its storage.
Introduce ProgressMeter gimmick ;)

Minor changes:

isprefix and issuffix don't take additional argument k (aka length). passing @view w[1:k] is more readable and as fast as the old version
added basic balancerule! (used only at rws creation at the moment)
RWS_Example_6_4 and 6_5 were fixed and existing @test_broken removed. However #46 is still present.
RewritingSystem constructor now makes sure that rules are properly oriented upon creation.

fixes:

getirreduciblesubsystem was fixed by introducing subwords iterator
simplifyrule! failed when common prefix and common suffix overlap
bunch of other small stuff

Codecov Report

Merging #51 (4f99bf2) into master (cff5504) will increase coverage by 0.45%.
The diff coverage is 90.97%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   90.53%   90.99%   +0.45%
==========================================
  Files          10       13       +3
  Lines         560      977     +417
==========================================
+ Hits          507      889     +382
- Misses         53       88      +35

Flag
Coverage Δ

unittests
90.99% <90.97%> (+0.45%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/words.jl
100.00% <ø> (ø)

src/rules.jl
68.57% <68.57%> (ø)

src/rewriting.jl
78.33% <82.07%> (-8.34%)
:arrow_down:

src/automata.jl
85.36% <88.18%> (+2.26%)
:arrow_up:

src/orderings.jl
90.24% <91.17%> (+8.42%)
:arrow_up:

src/kbs.jl
93.26% <93.26%> (ø)

src/parsing.jl
98.01% <98.01%> (ø)

src/abstract_words.jl
96.61% <100.00%> (+3.27%)
:arrow_up:

src/alphabets.jl
98.90% <100.00%> (+22.71%)
:arrow_up:

src/bufferwords.jl
100.00% <100.00%> (+1.04%)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9fc768...4f99bf2. Read the comment docs.

I will think about unifying different implementations since for now the whole main loop looks like this:
function knuthbendix(rws::RewritingSystem; kwargs...)
    # initialize rws here, e.g. creating kbWork, stack, etc
    objs = ...

    for ri in rules(rws)
        # check early breaking conditions here
        for rj in rules(rws)
            isactive(ri) || break
            forceconfluence!(rws, ri, rj, objs... )
            isactive(rj) || break
            ri == rj && break
            forceconfluence!(rws, rj, ri, objs... )
        end
        remove_inactive!(rws, objs... )
    end
    return rws
end


Update translations.php

Just a small typo

Would it be possible to translate the new strings at the end of the file as well?

Yes, I have it in plan. But this was just hotfix I noticed at lunch.
Dne 17. 8. 2015 17:53 napsal uživatel "Mathias Kresin" <
<EMAIL_ADDRESS>
Would it be possible to translate the new strings at the end of the file
as well?
—
Reply to this email directly or view it on GitHub
https://github.com/miniflux/miniflux/pull/400#issuecomment-131871231.

Done. Everything translated.

Thanks


[terra-clinical-item-view] Add prop to override default display styling

Summary

What was changed:
Created a prop 'overrideDefaultStyling' that defaults to false. When it is set to true the styling for emphasis is skipped and the current styling of the display is kept.
Why it was changed:
Adding this prop so that consumers have the option to keep their current styling if necessary. Some display styling is used to convey information such as 'strikethrough' or 'attention'.
Testing

This change was tested using:

[x] WDIO
[x] Jest
[x] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[ ] No tests are needed

Reviews
In addition to engineering reviews, this PR needs:

[ ] UX review
[ ] Accessibility review
[ ] Functional review

Additional Details

This PR resolves:
UXPLATFORM-9432

Thank you for contributing to Terra.
@cerner/terra

Site for PR: https://engineering.cerner.com/terra-clinical/pull/899

@RayGunY - Can we test with JAWS to ensure this works fine?

@RayGunY - Can we test with JAWS to ensure this works fine?

@vinaybhargavar sure thing:
https://github.com/cerner/terra-clinical/assets/40574651/21eb987d-1f8a-45df-8c6b-7090017b6793

@sdadn @sycombs this should still be good to review whenever you have time
Talked to Scott and he should be taking a look at some point today


[Event Request] codeunit "Calculate Normal Depreciation" - OnBeforeNumberofDayCalculateNumberofDays

Please modify event OnBeforeNumberofDayCalculateNumberofDays in procedure CalculateDeprAmount in codeunit "Calculate Normal Depreciation"
The reason is that we need to set UntilDate to FADepreciationBook."Depreciation Ending Date" of that is earlier. There is currently no way to overwrite UntilDate.
Original event:
    [IntegrationEvent(false, false)]
    local procedure OnBeforeNumberofDayCalculateNumberofDays(
        FixedAsset: Record "Fixed Asset";
        DeprBook: Record "Depreciation Book";
        var NumberofDays: Integer;
        FirstDeprDate: date;
        UntilDate: Date;
        Year365Days: Boolean;
        var IsHandled: Boolean)
    begin
    end;

Modified event:
    [IntegrationEvent(false, false)]
    local procedure OnBeforeNumberofDayCalculateNumberofDays(
        FixedAsset: Record "Fixed Asset";
        DeprBook: Record "Depreciation Book";
        FADepreciationBook: Record "FA Depreciation Book"; // <-- NEW PARAMETER
        var NumberofDays: Integer;
        FirstDeprDate: date;
        var UntilDate: Date;  // <-- ADDED var
        Year365Days: Boolean;
        var IsHandled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Vue 2.0.1: Single letter key aliases in key modifiers don't work.

Vue.js version
2.0.1
Reproduction Link
https://jsfiddle.net/wowg5tta/
Steps to reproduce
Type 'v' in the first textbox.
What is Expected?
It is expected to see an alert.
What is actually happening?
No alert is shown.
More info
If you type 'v' in the second textbox which uses keycode 86 instead of the key alias it works as expected.

valid keyCode aliases:
  esc: 27,
  tab: 9,
  enter: 13,
  space: 32,
  up: 38,
  left: 37,
  right: 39,
  down: 40,
  'delete': [8, 46]

https://github.com/vuejs/vue/blob/master/src/compiler/codegen/events.js#L5-L16

If you want to support custom keys, define them as global keyCodes.

The example I've posted on jsfiddle is taken from the Vue 2 guide.
So, key aliases should be either removed from the guide or added in the keyCode object.
http://vuejs.org/guide/events.html#Key-Modifiers

Oh, indeed. We may need to amend our doc. Ping @chrisvfritz.

By the way, I think the usage sample for http://vuejs.org/api/#keyCodes could be better, as esc: 27 support is built-in and not any "custom." Will submit a PR to the repo.

The same applies for Vue.config.keyCodes.f1 = 112 in the guide too.
I will submit a PR there.

What's wrong with f1? It works just according to the docs https://jsfiddle.net/phanan/wowg5tta/1/

Yes, it works. But if single letter key aliases come back, it won't.

For custom, I have in mind something like Vue.config.keyCodes.submitKey = 112.
Isn't that the case?

What do you mean by single letter key aliases coming back? The feature has been removed from 2.0 I believe. What we need to do is amend the doc to reflect this change.
For your other question, please see the keyCodes API link above for documentation. If you need more help, I'd suggest using the forum instead.

I mean that if they are not deprecated and it's just a bug, they could come back.
If you say this feature is removed then they won't. :)
It is weird though since I can't find the deprecation on the Vue 2 Changes. Maybe it's just missing.


Any ability to switch pages?

Hi, guys!
So the problem I came across recently is that there is a situation when I need to switch context back to the previous page, but I don't have any idea how can I do it if that is possible at all.
So basically, I am using pdfkit to generate a table of contents, which has structure showed on the screenshot.
To reach this structure I am using two text() methods one for chapter name and one for number, and I am calculating position of each text manually:
document.text(chapter.name, currentPosition.x, currentPosition.y, {align: 'left', width: 400});
document.y = currentPosition.y;
document.text(chapter.page, 510, currentPosition.y, {align: 'right', width: 70});
document.y = currentPosition.y;
document.moveDown();
document.moveDown();
currentPosition.y = document.y;

I am using document.y = currentPosition.y in order not to move document.y after each call to the text method.
But the problem is that whenever I reach the end of current page next chapter name gets printed on the next page, but chapter's page number is printed on the next page leaving one page blank.
it seems like whenever pdfkit moves pointer to next page there is no way to go back to previous page, that's why my code does not work.
Would appreciate any help, thanks!

http://pdfkit.org/docs/getting_started.html

PDFKit normally flushes pages to the output file immediately when a new page is created, making it impossible to jump back and add content to previous pages. This is normally not an issue, but in some circumstances it can be useful to add content to pages after the whole document, or a part of the document, has been created already. Examples include adding page numbers, or filling in other parts of information you don't have until the rest of the document has been created.

PDFKit has a bufferPages option in versions v0.7.0 and later that allows you to control when pages are flushed to the output file yourself rather than letting PDFKit handle that for you. To use it, just pass bufferPages: true as an option to the PDFDocument constructor. Then, you can call doc.switchToPage(pageNumber) to switch to a previous page (page numbers start at 0).

When you're ready to flush the buffered pages to the output file, call flushPages. This method is automatically called by doc.end(), so if you just want to buffer all pages in the document, you never need to call it. Finally, there is a bufferedPageRange method, which returns the range of pages that are currently buffered. Here is a small example that shows how you might add page numbers to a document.

@vovkvlad I'm trying to create a Table of Contents. Any chance you are willing to help? You seem to have figured out a way...

@kseniya292 whoa... Actually, I did figure out how to overcome this problem, but it was a long time ago, and I have changed my job since then, thus I can not reach out to the codebase to have a look =(
I must have posted the solution here, but unfortunately, haven't done this.
From what I can remember, I was moving in 2 directions:

playing with moveDown and moveUp methods
another thing is to merge title and page in one string on the data level so that we can call text method ones per table of contents line.

Hope it will help you somehow

@kseniya292 were you able to figure this out :)

@neilamin were you able to figure this out ?

@kseniya292 were you able to figure this out about table of content?


AST DRP

When asking for completions, code is usually broken.
This throws PostCSS into a tizzy.
We currently check if the current line is illegal, and ignore this line in parsing.
This is fragile, and does not solve cases where the error is not on the typed line.
Better algorithm suggestion is to identify the problem spots and expand deleted scopes around them until we have valid code.

Closing, as this does not appear to be required.


Fixing issues with returning a Flux in reactive spring.

Description
Issues were introduced with annotated queries and returning Flux from Reactive Spring. Updating the ReactiveCosmosTemplate to have the same behavior as CosmosTempalte.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

/azp run java - cosmos - tests

Hi All , is this fix released to PROD ? we want to start using the latest cosmos version

Hi All, can someone confirm if the fix is live ?

@abhitwr  - yes, this was released in 3.33.0.


The m4a audio is too slow starting the playback

Ionic version: 2.2.1
We have problems with an audio reader hybrid application, using fairly large audio m4a files. In short, it takes far too long to start the playback (when using online audio resources).
To illustrate the issue, we've created a smaller prototype https://github.com/Alexgulyy/test-ionic-audio-app/tree/master/src/pages/home
When we build the app with Ionic 2.2.1 using WebView, it starts playback in ~3.5s. The network activity looks like this:
GET /tmp/1916firstchapterscollection_09_various_64kb.m4a?app=webview HTTP/1.1<PHONE_NUMBER>5
GET /tmp/1916firstchapterscollection_09_various_64kb.m4a?app=webview HTTP/1.1   206 326657
GET /tmp/1916firstchapterscollection_09_various_64kb.m4a?app=webview HTTP/1.1<PHONE_NUMBER>0
When we build the app with Ionic 2.2.1 with Crosswalk-webview plugin 2.2.0, it starts playback in 18s at best, but sometimes the delay is even more substantial - up to 45s. It seems the main reason is the difference in the network activity:
GET /tmp/1916firstchapterscollection_09_various_64kb.m4a?app=crosswalk HTTP/1.1 206 2
GET /tmp/1916firstchapterscollection_09_various_64kb.m4a?app=crosswalk HTTP/1.1<PHONE_NUMBER>5
GET /tmp/1916firstchapterscollection_09_various_64kb.m4a?app=crosswalk HTTP/1.1 206 577690
GET /tmp/1916firstchapterscollection_09_various_64kb.m4a?app=crosswalk HTTP/1.1<PHONE_NUMBER>5
GET /tmp/1916firstchapterscollection_09_various_64kb.m4a?app=crosswalk HTTP/1.1 206 577690
GET /tmp/1916firstchapterscollection_09_various_64kb.m4a?app=crosswalk HTTP/1.1<PHONE_NUMBER>5
GET /tmp/1916firstchapterscollection_09_various_64kb.m4a?app=crosswalk HTTP/1.1 206 577690
GET /tmp/1916firstchapterscollection_09_various_64kb.m4a?app=crosswalk HTTP/1.1<PHONE_NUMBER>5
GET /tmp/1916firstchapterscollection_09_various_64kb.m4a?app=crosswalk HTTP/1.1 206 577690
 GET /tmp/1916firstchapterscollection_09_various_64kb.m4a?app=crosswalk HTTP/1.1<PHONE_NUMBER>
... when only the first request is served with the 'normal' user-agent, all the subsequent ones are served with stagefright/1.2 (Linux;Android 5.0.1).
Why's the difference, and how can we avoid this?

This is not an issue related to the ionic framework.
Also, there is an issue template for a reason, do not delete it.
Closing.


How to have two more chart on the same layer?

I've seen some chart libraries support multiple charts overlapping together. Can I do that with this library? Thanks!

It's not really possible out of the box. It shouldn't be too hard, the idea would be to find the right scale and then display each chart with this scale in the same view.


Are there any plans to support MediaPipe version 0.10.18?

Description
Are there any plans to support MediaPipe version 0.10.18?
Thank you for reply.

I regularly update the version of MediaPipe the plugin depends on. However, whether or not newly added features are ported depends on the situation.


[BUG] dragToDismiss is ignored

Hi,
Many thanks for this great package :)
I found an issue (or so I think): the dragToDismiss parameter is not been considered. I believe it should be changed in the bellow function:
    /// This is the builder for the sheet content
    func sheet() -> some View {

        // if needed, dispatch autohide and cancel previous one
        if let autohideIn = autohideIn {
            dispatchWorkHolder.work?.cancel()

            // Weak reference to avoid the work item capturing the struct,
            // which would create a retain cycle with the work holder itself.
            dispatchWorkHolder.work = DispatchWorkItem(block: { [weak isPresentedRef] in
                isPresentedRef?.value.wrappedValue = false
                dismissCallback()
            })
            if isPresented, let work = dispatchWorkHolder.work {
                DispatchQueue.main.asyncAfter(deadline: .now() + autohideIn, execute: work)
            }
        }

        let sheet = ZStack {
            Group {
                VStack {
                    VStack {
                        self.view()
                            .addTapIfNotTV(if: closeOnTap) {
                                self.dispatchWorkHolder.work?.cancel()
                                self.isPresented = false
                                self.dismissCallback()
                            }
                            .background(
                                GeometryReader { proxy -> AnyView in
                                    let rect = proxy.frame(in: .global)
                                    // This avoids an infinite layout loop
                                    if rect.integral != self.sheetContentRect.integral {
                                        DispatchQueue.main.async {
                                            self.sheetContentRect = rect
                                        }
                                    }
                                    return AnyView(EmptyView())
                                }
                            )
                    }
                }
                .frame(width: screenSize.width)
                .offset(x: 0, y: currentOffset)
                .animation(animation)
            }
        }

        // It should return the view if dragToDismiss is false
        if (!dargToDismiss) { return sheet }

        #if !os(tvOS)
        let drag = DragGesture()
            .updating($dragState) { drag, state, _ in
                state = .dragging(translation: drag.translation)
            }
            .onEnded(onDragEnded)

        return sheet
            .offset(y: dragOffset())
            .simultaneousGesture(drag)
        #else
        return sheet
        #endif
    }

Many thanks in advance.

I should add that I'm finding this issue because in one scenario, I would like the toast to be dismissed when the subview has finished processing.

Hey @gpfister, thank you for you kind words) I must admit though I don't yet understand the issue you are having. It does return the view if dragToDismiss is false - it says
return sheet
            .applyIf(dragToDismiss) { ...

'return sheet' part stays even if 'applyIf' doesn't actually add anything to it. Could it be that your issue is caused by anything other than this? Would you please share a little example of your problem? Sorry if I didn't get what you were trying to say. Have a wonderful day!

I apologise, I'll do a bit more debug to check in my app where this is coming from.


Disable UBSAN on macOS

Building indexstore-db with ubsan enabled with an Xcode 15.1 SDK causes C++ exception to not be catchable with try {} catch {} blocks and indexstore-db relies on exception catching, possibly related to  https://stackoverflow.com/questions/51673343/clang-with-libc-exceptions.
Disable UBSAN for now and re-enable it when CI nodes has been updated to Xcode 16.

@swift-ci Please test


Generate data for CLI tests

This PR makes it clear how input data and ground truth files were created for the CLI tests.
There are a few bash scripts and a meaningful readme. For now this process is still not portable because raptor_data_simulation has to be built from source.

scripts to generate input data and ground truth files
using (23,19) and (19,19)-minimisers, was 20-mers
reduce size of reference data
sample reads with more than one length

Codecov Report

Merging #54 (c06ebad) into master (bb8dd12) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #54   +/-   ##
=======================================
  Coverage   83.57%   83.57%
=======================================
  Files          24       24
  Lines         615      615
=======================================
  Hits          514      514
  Misses        101      101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb8dd12...c06ebad. Read the comment docs.