Add hooks dynamically on Formlyfieldconfig

Hi, I want to add hooks dynamically. Other configs are loaded from API as json. Here I need to add onInit hook dynamically and call other API on select changes.

to adjust the fields on load, check my reply in a similar question https://github.com/ngx-formly/ngx-formly/issues/1102#issuecomment-411491538

thanks


/signin route should have configurable body params when using PasswordAuth strategy

Right now, you must pass { username, password } as the body to the /signin POST endpoint.
Even if you set the identityField in your PasswordAuth strategy to something like email, the endpoint will still require username.
It would be great to have the endpoint adapt to whatever the auth strategy has set.

This should also effect the fields shown on the AdminUI's login screen.


Add CPU pin scheduler

This adds a new scheduler that takes a HashMap that indicates to which CPU each block should be pinned.

Background: To do some benchmarking, I wanted to have a scheduler in which I could specify manually in which CPU each block should run, similarly to using set_processor_affinity() in GNU Radio (this is one of the things I want to compare with in my benchmarks). I have implemented this as a variant of the FlowScheduler that takes a HashMap defining in which worker each block should go. The reason why I've implemented this custom scheduler in the futuresdr crate is because it doesn't seem possible to implement schedulers in an external crate (for instance, topology.blocks is private). So now that I have this written, I was wondering if it made sense to contribute this upstream. My initial benchmarks show that this custom scheduler is worse than the regular smol scheduler with no CPU pinning. So this custom scheduler doesn't have much practical use. It can be useful for benchmark/comparison and also in case someone wants to investigate why it performs worse, since the kind of flowgraphs I'm benchmarking should be able to benefit from manual CPU pinning.
I've marked the PR as draft because I'm asking for comment about whether it makes sense to merge this to upstream.

Great. I'm marking this PR as ready for review. Happy to make any changes to make this more useful for your use cases or for a wider context.
I agree that this is much different from what GNU Radio 3.10 does, but it is the closest I can get to a fair comparison given that GNU Radio 3.10's scheduler is inflexible (I guess I could also benchmark the FutureSDR thread-per-block scheduler to have a closer comparison; maybe I'll try).
The kind of flowgraph I'm benchmarking is something like
Null Source -> Math block -> Math block -> ... -> Math block -> Benchmark Sink

Here Null Source is really a "zero-cost" null source (It doesn't memset the output buffer to zero. It just "pretends" that it produces samples, but doesn't ever write to the buffer), Math block is a very optimized implementation of y[n] = a * x[n] + b (with everything f32), and Benchmark Sink just counts samples and measures elapsed time every once in a while.
I'm doing several variations of this flowgraph, but one important example is pinning each Math block to a different CPU, and making the Null Source and Benchmark Sink share the CPU with the Math block they're directly connected to. In this case there is basically a single block per CPU (Null Source and Benchmark Sink are supposed to be almost zero-cost). So in principle there should be little difference in FutureSDR between thread-per-block with each thread pinned to the corresponding CPU, and this CPU pin scheduler (the difference is whether Null Source and the downstream Math block share a thread or not, and likewise for Benchmark Sink).
In GNU Radio 3.10 I'm finding that there is a lot of overhead in calling these blocks. Null Source and Benchmark Sink are far from being zero-cost, and use almost the same CPU as each Math block.
I'm also doing a comparison with GNU Radio 4.0. There I can have a custom scheduler that does more or less the same as this CPU pin scheduler.
At some point I'll be publishing code and results for all these benchmarks.


Routing problem: 1+ rules with same route

What steps will reproduce the problem?
config:
'urlManager' => [
            'enablePrettyUrl' => true,
            'showScriptName' => false,
            'rules' => [
              '/<lang>/news/<page>' => 'front/default/news',
              '/<lang>/новости/<page>' => 'front/default/news',
            ],
        ],

beforeAction:
Yii::$app->language = Yii::$app->request->get('lang')

Case 1:
current url : /en/news/1

echo Url::current(['page' => 2, 'lang' => Yii::$app->language]);

Case 2:
current url : /ru/новости/1

echo Url::current(['page' => 2, 'lang' => Yii::$app->language]);

What is the expected result?

Case 1: /en/news/2
Case 2: /ru/новости/2

What do you get instead?

Case 1: /en/новости/2
Case 2: /ru/новости/2

Additional info

Q
A

Yii version
2.0.13 - dev

PHP version
7.1.*

Operating system
Ubuntu 16.04.3

same result without <lang>
Is this bug, or I'm doing something wrong?

I think you've got your rules wrong. Should be:
'/<lang:en>/news/<page>' => 'front/default/news',
'/<lang:ru>/новости/<page>' => 'front/default/news',

same with this ruleset
'/news/<page>' => 'front/default/news',
 '/новости/<page>' => 'front/default/news',

in yiisoft/yii2/helpers/BaseUrl.php

    public static function current(array $params = [], $scheme = false)
    {
        $currentParams = Yii::$app->getRequest()->getQueryParams();
        $currentParams[0] = '/' . Yii::$app->controller->getRoute();
        $route = ArrayHelper::merge($currentParams, $params);
        return static::toRoute($route, $scheme);
    }

Yii::$app->controller->getRoute() always returns 'front/default/news'
and Url::toRoute() takes the latest rule from ruleset.
So for 2 cases above it takes '/новости/<page>' this one

UrlManager not able to determine which pattern to use. And takes the last one from list ordered by cacheKey i guess.
What if we use UrlRule::$name with route?

something like this:
public function createUrl($manager, $route, $params)
{
//...
// match the route part first
        if ($route !== $this->route) {
            if ($this->_routeRule !== null && preg_match($this->_routeRule, $route, $matches) || $route == $this->name && $this->name != $this->pattern) {
                //...
            } else {
                //...
            }
        }
}

Your example is incorrect. Since first rule will match front/default/news route it will always be used for creating URL. The only weird thing is that you get /ru/новости/2 instead of /ru/news/2

@rob006 Yeah, I know, that it will use front/default/news for both cases. That's why I'm suggesting add ability differentiation rules with same route using name property (if it's specified in route definition) like in example above.

@gevorgmansuryan This does not make much sense. Rules should have unique set of route and default params. You should use syntax propsed by @samdark (https://github.com/yiisoft/yii2/issues/14977#issuecomment-336808693) to differentiate URLs for different languages or this:
'rules' => [
    [
        'pattern' => '/новости/<page>',
        'route' => 'front/default/news',
        'defaults' => [
            'page' => 1,
            'lang' => 'ru',
        ],
    ],
    [
        'pattern' => '/news/<page>',
        'route' => 'front/default/news',
        'defaults' => [
            'page' => 1,
            'lang' => 'en',
        ],
    ],
]

Url::to(['front/default/news', 'page' => 2, 'lang' => 'en']); // /news/2
Url::to(['front/default/news', 'page' => 2, 'lang' => 'ru']);  // /новости/2

if you want to hide language prefix from URLs.

@rob006 https://github.com/yiisoft/yii2/issues/14977#issuecomment-336812584 is a real case. I think we should introduce an ability to alias a rule so it's used for creating URLs directly w/o searching for it in a rules array.

I agree with @rob006 because we should keep rules configuration as clean as possibile. Introducing aliases in rules some developers could use aliases improperly, just to avoid to write complete requirements for that route.

@yiisoft/core-developers thoughts?

@rob006 in https://github.com/yiisoft/yii2/issues/14977#issuecomment-337350272
it may work for Url::to with specified lang, what about Url::current ?
For example I'm using yii\data\Pagination and it uses Url::current for creating page urls.

Agreed with @rob006

@gevorgmansuryan It will work fine with Url::current(). You don't need to pass current language to Url::current() if it is already in current URL.
http://www.yiiframework.com/doc-2.0/guide-helper-url.html#creating-urls


If we run API explorer to offboard a machine it returns code 200 for success. But the document says its 201 for success. I have checked in lab and the result is same as 200. Customers are getting confused as the article says "If the script runs successfully it will give 201 but the actual success result is 200" can we get this document updated?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 05007b38-2a58-d34a-6afb-838e2ddd380e
Version Independent ID: d0e699b6-abe7-e8f6-a093-ecec52559dec
Content: Offboard machine API
Content Source: microsoft-365/security/defender-endpoint/offboard-machine-api.md
Product: m365-security
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@PremMS-MDE . If possible will you share screenshot of success status code

@mjcaparas  Why i couldn't able to view the documentation article page, when i click that page , i received the error, you don't have access to this page.

@PremMS-MDE Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/8612
Once the author approves, the changes will be live.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @PremMS-MDE Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Don't erode webpack error message details

To work around a react-dev-utils compatibility problem, errors and warnings had context stripped before being formatted.
This led to issues in internal Backstage where a build failure's cause was ambiguous and hard to diagnose.
Since this workaround was needed for react-dev-utils v5 (which was released over a year ago, nice! [1]), I think that it can be removed.
[1] https://github.com/facebook/create-react-app/releases/tag/v5.0.0

Hmm, upon closer inspection, this doesn't resolve the missing context information encountered in this Backstage internal comment


Decouple UI interactions from engine package

This issue will act as an epic to track the work going into splitting up to the current tight coupling of the engine code with the UI interaction.
More concretely, this means refactoring the current implementation to not be using the PureComponent elements from react.
The following PureComponents are being used right now as the bridge between the engine and the UI. Since this is not a small change, to prevent major divergence from master, the path of action is to keep the build and tests passing at all times while incrementally refactoring each of the following components separately (note that the order of presentation isn't necessarily the order in which the items will be checked off; the order will be decided by whatever is easiest to refactor moving forward as this is a spike). It will likely be the case that each component will be tackled in a separate, stacked PR to make reviews easier.
The relevant PR for each protocol will be tagged to it in the following list:

[ ] defunding
[ ] concluding
[ ] funding
[ ] dispute/challenger
[ ] dispute/challenger/components/wait-for-response-or-timeout
[ ] dispute/responder
[ ] dispute/responder/components/wait-for-approval
[ ] funding-strategy-negotiation/player-a
[ ] funding-strategy-negotiation/player-b
[ ] ledger-funding
[ ] ledger-defunding
[ ] virtual-defunding
[ ] close-ledger-channel
[ ] withdrawing
[ ] new-ledger-channel
[ ] existing-ledger-funding
[ ] consensus-update
[ ] advance-channel
[ ] withdrawing/components/wait-for-approval
[ ] ledger-top-up
[ ] new-ledger-channel/components/funding-step
[ ] advance-channel/components/advancing-channel
[ ] direct-funding
[ ] direct-funding/components/funding-step
[ ] src/containers/engine

What's the status on this issue?

On pause

Refers to the old wallet


Rates and Transit Times API

Hi guys. So I forked your repo and thought I would contribute by adding support for the rates API.
I've tried to stay within the same code structure as you are using for the Ship API, and was hoping to get a draft PR open this week.
However I've noticed an odd issue that I cannot reconcile with the documentation, hopefully you can help me to understand.
I'm following this documentation https://developer.fedex.com/api/en-us/catalog/rate/v1/docs.html and it works fine when I send specific parameters. For example, if I dont send rateRequestType (not required according to the docs) as part of the requestedShipment, it fails. If I send serviceType or shipDateStamp (both optional) as part of the requestedShipment, it fails.
Am I following out of date documentation? The error code is always "REQUEST.MISMATCH".
Seems that it will accept ONLY required parameters WITH rateRequestType. Any deviation from that causes a failure.
Thank you!

Do you have a technical contact at FedEx? I'd suggest asking them for advice.
If you don't have one I can try reaching out to the person who helped us a year ago. I'd want a copy of request/response if you could provide that.

@greggles I believe its because the Rates API is virtualized so I have to end exactly whats contained in the JSON API Collection. Any deviation causes a failure.

@greggles I'm pretty confident now that its due to the virtualized response. I've taken examples from the JSON Collection and they all work and do not have additional alerts regarding information having been changed. (Just the one which states "This is a Virtual Response.").
Thank you for your offer to reach out to your contact though, very much appreciated!

@danielmcguinness They did it strangely with this virtualization. Recently I had to change tests because the virtualized sandbox started returning strange things.
The old sandbox for that had stability problems. Tracking API tests once passed and once ended with a 500 error on the Fedex side xD

@code2prog Agreed, I saw the same when testing locally. The behaviour is documented here


[WIP][SPARK-37474][R][DOCS] Migrate SparkR docs to pkgdown

What changes were proposed in this pull request?

This PR proposes migration of R API docs to pkgdown.
Result (not synced automatically) could look like this
https://zero323.gitlab.io/sparkr-docs-experiments/
with optional integration with docsearch
Why are the changes needed?

TODO
Does this PR introduce any user-facing change?

TODO
How was this patch tested?

TODO

Test build #145676 has started for PR 34728 at commit 871f96a.

Test build #145676 has finished for PR 34728 at commit 871f96a.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145676/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50146/

Test build #145677 has started for PR 34728 at commit 148f56c.

Test build #145677 has finished for PR 34728 at commit 148f56c.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145677/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50147/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50146/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50146/

Test build #145678 has started for PR 34728 at commit 07652f3.

Test build #145678 has finished for PR 34728 at commit 07652f3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50147/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50148/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50147/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145678/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50148/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50148/

Test build #145679 has started for PR 34728 at commit dc5e3b9.

Test build #145679 has finished for PR 34728 at commit dc5e3b9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50149/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145679/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50149/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50149/

Test build #145681 has started for PR 34728 at commit b9391a8.

The demo looks good. cc @falaki @felixcheung @shivaram FYI

Test build #145681 has finished for PR 34728 at commit b9391a8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50151/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145681/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50151/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50151/

Test build #145682 has started for PR 34728 at commit b964c5a.

Test build #145682 has finished for PR 34728 at commit b964c5a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50152/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145682/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50152/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50152/

Test build #145683 has started for PR 34728 at commit 8655c78.

Test build #145683 has finished for PR 34728 at commit 8655c78.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50153/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145683/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50153/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50153/

Test build #145684 has started for PR 34728 at commit a31050f.

Test build #145684 has finished for PR 34728 at commit a31050f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50154/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145684/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50154/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50154/

Test build #145722 has started for PR 34728 at commit a792a02.

Test build #145722 has finished for PR 34728 at commit a792a02.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145722/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50190/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50190/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50192/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50190/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50192/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50192/

Test build #145912 has started for PR 34728 at commit 9d3786f.

Test build #145912 has finished for PR 34728 at commit 9d3786f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50388/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145912/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50388/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50388/

Test build #145931 has started for PR 34728 at commit 02e47e0.

Test build #145931 has finished for PR 34728 at commit 02e47e0.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145931/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50407/

Test build #145932 has started for PR 34728 at commit 97aeab7.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50407/

Test build #145932 has finished for PR 34728 at commit 97aeab7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50408/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145932/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50407/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50408/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50408/

Test build #145952 has started for PR 34728 at commit d4f346f.

Test build #145952 has finished for PR 34728 at commit d4f346f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145952/

Test build #145955 has started for PR 34728 at commit a18cc0c.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50426/

Test build #145955 has finished for PR 34728 at commit a18cc0c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145955/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50426/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50429/

Looks pretty good .. but the packaging stuff it would be great to have sign-offs from @felixcheung @shivaram @mengxr or @falaki.

Test build #145990 has started for PR 34728 at commit 358cc5c.

Test build #145990 has finished for PR 34728 at commit 358cc5c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50466/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145990/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50466/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50466/

Test build #145991 has started for PR 34728 at commit 6e01b24.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50467/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50467/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50467/

Test build #145991 has finished for PR 34728 at commit 6e01b24.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145991/

Merged to master


add section in README about limitations

We should add a section to the README about the limitations of this project.
Similar to:

https://github.com/clj-kondo/clj-kondo?tab=readme-ov-file#macros

We should mention that this tool is intended for "code at rest" more than "code in flight". ie: final product vs editing experience

There may some valid ns forms that this tool does not support (like Issue #38).


Switch to Pyrra for rhobs metrics SLOs

This PR deprecates the slo-libsonnet library usage for rhobs metrics rules, and switches over to Pyrra.
This adds a go file responsible for generating the Prometheus rule files which contain SLO alerts.
To note, we don't deploy Pyrra, but use its functionality via mimic. It is roughly the same as the pyrra CLI, but customized to fit some of our needs.
TODO:

Update tests for the rules (or rm completely)
Update SLOs to include logging SLOs

So quick update,
* Added the logs availability SLOs for MST!

  * cc: @periklis would you want the availability target for this to be the same as metrics, i.e 99% over 28d?

You get set the level to realistically arbitrarily because we don't have the required on-call structure across the two geos. For the start we can leave this to 95% and triage with the log storage team where we stand today.

  * Also, I noticed there are currently no latency SLOs for logging endpoints. Should they be included?

IIRC the metrics latency SLOs are based on synthetic client metrics (I believe the tool is called avalance). We don't have such a tool support for logs yet. Any suggestions welcome (e.g. using up for this task)?

* Removed the `observatorium-api-(production|stage).prometheusrules.yaml` SLO alert rules, as they were exact duplicates of the API error budget ones.

* Full deprecated slo-libsonnet

You get set the level to realistically arbitrarily because we don't have the required on-call structure across the two geos. For the start we can leave this to 95% and triage with the log storage team where we stand today.

Ack! Will update to 95.

IIRC the metrics latency SLOs are based on synthetic client metrics (I believe the tool is called avalance). We don't have such a tool support for logs yet. Any suggestions welcome (e.g. using up for this task)?

The query latency is based on the up job, yes, which queries metrics written by avalanche to rhobs tenant. The query latencies for metrics rely on # of samples queried in a single request, so 10s for 1M samples, 30s for 10M and so on.
For write path latency we use all data, i.e, actual tenant data + avalanche combined. 🙂

Just stumbled upon this. Wooohooo :tada:
Let me know upstream or on CNCF Slack if you ever encounter something you want to discuss.

Thanks for amazing project! 💪🏻

@metalmatze From the top of head (disclaimer: have not skimmed through thr pyrra repo issues), something like pyrra serve -f . for local testing would be awesome :heart: Thanks for this amazing piece!


[enhancement] Compound slug

Add an option in the plugin config where you could add fields to put togheter for a slug.
Maybe an array with fieldnames. The order of they are in the array should be how the compund slug is made.

That sounds like a useful feature although what would be the expected behaviour when one of the fields is not defined?
Current possible options

If any of the fields are missing a value dont apply slugification, this is the current behaviour for the reference field.
We skip any fields that are not defined and use the remaining for the slugification.
Leave it up to the user with a setting. default would be to skip slugification.

I believe 3 is probably the best option as it provides the ability for the user to decide on which behaviour they prefer.

I agree that 3 is the best.

This features has been added in #22 , and will be included in the next release.

👍

That sounds like a useful feature.
What would be the expected behaviour when one or more of the fields are not defined?
Current possible options

If any of the fields are missing a value dont apply slugification, this is the current behaviour for the reference field.
We skip any fields that are not defined and use the remaining for the slugification.
Leave it up to the user with a setting. default would be to skip slugification.

I believe 3 is probably the best option as it provides the ability for the user to decide on which behaviour they prefer.

how can i skip slugification.

If all fields are missing or some are and skip is not true then it should already do this.
I will need to investigate this further.


Fix Invalid cyclic error for type T [T]

Purpose

Fix Invalid cyclic error for type T [T]

Fixes #38269
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

This PR will wait untill the changes done in https://github.com/ballerina-platform/ballerina-lang/pull/37773.

This PR will wait untill the changes (#36538) done in #37773.

Hence mark this as a draft


Changed sea ice area units from m^2 to m2 to respect CF conventions

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #487

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion (minor / major / patch) has been called on this branch
[ ] Tags have been pushed (git push --tags)

What kind of change does this PR introduce?
Change in output metadata.

Does this PR introduce a breaking change?
Yes, if you expected units to be in Pint format, but this was a bug.

Other information:

Pull Request Test Coverage Report for Build 2025

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 77.139%

Totals

Change from base Build 2023:
0.0%

Covered Lines:
2696

Relevant Lines:
3495

💛  - Coveralls


Cannot use urlhelper on subdirectory with blast/urlHelper

Hello,
I have followed the cookbook guide relative to use zend expressive on subdirectory. And the default homepage action works fine. I'm using the expressive skeleton.
Unfortunately I'm unable to make this work as i receive the following error:
 Catchable fatal error: Argument 1 passed to Zend\Expressive\Helper\UrlHelperMiddleware::__construct() must be an instance of Zend\Expressive\Helper\UrlHelper, none given, called in /home/ubuntu/workspace/vendor/zendframework/zend-expressive/src/MarshalMiddlewareTrait.php on line 124 and defined in /home/ubuntu/workspace/vendor/zendframework/zend-expressive-helpers/src/UrlHelperMiddleware.php on line 27
This is my dependencies config file:
<?php
use Zend\Expressive\Application;
use Zend\Expressive\Container\ApplicationFactory;
use Zend\Expressive\Helper;

return [
    // Provides application-wide services.
    // We recommend using fully-qualified class names whenever possible as
    // service names.
    'dependencies' => [
        // Use 'invokables' for constructor-less services, or services that do
        // not require arguments to the constructor. Map a service name to the
        // class name.
        'invokables' => [
            // Fully\Qualified\InterfaceName::class => Fully\Qualified\ClassName::class,
            Helper\ServerUrlHelper::class => Helper\ServerUrlHelper::class,
            Blast\BaseUrl\BasePathHelper::class => Blast\BaseUrl\BasePathHelper::class,
        ],
        // Use 'factories' for services provided by callbacks/factory classes.
        'factories' => [
            Application::class => ApplicationFactory::class,
            Doctrine\DBAL\DriverManager::class     => App\Catalog\Factory\DoctrineDbalConnectionFactory::class,
            Blast\BaseUrl\UrlHelper::class       => Blast\BaseUrl\UrlHelperFactory::class,
            App\Catalog\Config\ConfigDbMiddleware::class => App\Catalog\Factory\ConfigDbMiddlewareFactory::class,
            bitExpert\Http\Middleware\Psr7\Prophiler\ProphilerMiddleware::class => App\Catalog\Factory\ProphilerFactory::class,
            App\Catalog\Http\UserAgentMiddleware::class => App\Catalog\Factory\UserAgentMiddlewareFactory::class,
            App\Catalog\Log\LogMiddleware::class         => App\Catalog\Factory\LogMiddlewareFactory::class,
            App\Catalog\Http\SessionMiddleware::class => App\Catalog\Factory\SessionMiddlewareFactory::class,
            App\Catalog\Http\SessionHandlerMiddleware::class => App\Catalog\Factory\SessionHandlerFactory::class,
            Aura\Session\Session::class         => App\Catalog\Factory\AuraSessionFactory::class,
            Doctrine\ORM\EntityManager::class  => App\Catalog\Factory\DoctrineFactory::class,
            Doctrine\Common\Cache\Cache::class => App\Catalog\Factory\DoctrineFileCacheFactory::class,
            App\Catalog\i18n\LanguageMiddleware::class => App\Catalog\Factory\LanguageMiddlewareFactory::class,
            App\Catalog\Mail\MailMiddleware::class => App\Catalog\Factory\MailMiddlewareFactory::class,
        ],
        'aliases' => [
            // alias default UrlHelper with Blast\BaseUrl alternative
            Helper\UrlHelper::class => Blast\BaseUrl\UrlHelper::class,
        ],
    ],
];

And this the middleware pipeline

<?php
use Zend\Expressive\Container\ApplicationFactory;
use Zend\Expressive\Helper;
use Zend\Expressive\App;

return [
    'dependencies' => [
        'invokables' => [
            /* ... */
        ],
        'factories' => [
            Helper\ServerUrlMiddleware::class => Helper\ServerUrlMiddlewareFactory::class,
        //    Helper\UrlHelperMiddleware::class => Helper\UrlHelperMiddlewareFactory::class,
            Helper\UrlHelper::class => Helper\UrlHelperFactory::class,
            Blast\BaseUrl\BaseUrlMiddleware::class => Blast\BaseUrl\BaseUrlMiddlewareFactory::class,
        ],
    ],
    // This can be used to seed pre- and/or post-routing middleware
    'middleware_pipeline' => [
        // An array of middleware to register. Each item is of the following
        // specification:
        //
        // [
        //  Required:
        //     'middleware' => 'Name or array of names of middleware services and/or callables',
        //  Optional:
        //     'path'     => '/path/to/match', // string; literal path prefix to match
        //                                     // middleware will not execute
        //                                     // if path does not match!
        //     'error'    => true, // boolean; true for error middleware
        //     'priority' => 1, // int; higher values == register early;
        //                      // lower/negative == register last;
        //                      // default is 1, if none is provided.
        // ],
        //
        // While the ApplicationFactory ignores the keys associated with
        // specifications, they can be used to allow merging related values
        // defined in multiple configuration files/locations. This file defines
        // some conventional keys for middleware to execute early, routing
        // middleware, and error middleware.
        'always' => [
            'middleware' => [
                // Add more middleware here that you want to execute on
                // every request:
                // - bootstrapping
                // - pre-conditions
                // - modifications to outgoing responses
                Helper\ServerUrlMiddleware::class,
                Blast\BaseUrl\BaseUrlMiddleware::class,
                bitExpert\Http\Middleware\Psr7\Prophiler\ProphilerMiddleware::class,
                \App\Catalog\Config\ConfigDbMiddleware::class,
                \App\Catalog\Http\SessionHandlerMiddleware::class,
                \App\Catalog\Http\UserAgentMiddleware::class,
                \App\Catalog\Http\SessionMiddleware::class,
            ],
            'priority' => 10000,
        ],

        'routing' => [
            'middleware' => [
                ApplicationFactory::ROUTING_MIDDLEWARE,
                // Add more middleware here that needs to introspect the routing
                // results; this might include:
                // - route-based authentication
                // - route-based validation
                // - etc.
                Helper\UrlHelperMiddleware::class,
                \App\Catalog\i18n\LanguageMiddleware::class,
                ApplicationFactory::DISPATCH_MIDDLEWARE,
            ],
            'priority' => 1,
        ],

        'error' => [
            'middleware' => [
                \App\Catalog\Log\LogMiddleware::class,
            ],
            'error'    => true,
            'priority' => -10000,
        ],
    ],
];

You will need to raise an issue with the author of blast-base-url; you can file issues with that project here: https://github.com/mtymek/blast-base-url/issues

Thank you

actually: just remove the line Helper\UrlHelperMiddleware::class, from within the "routing" middleware.

Thank you i did but unfortunately this does not work. The only config that actually seems to work is to readd to the factory the line "Helper\UrlHelper::class => Helper\UrlHelperFactory::class" in the factories config. But with this i cannot call the Blast\BaseUrl methods. Seems that the aliases configs does not work.

@acidvertigo I'm working on Blast\BaseUrl to make it compatible with latest RC of Expressive, after that I will update the cookbook and post an update here.

oh ok, thank you for your work, my website is on a shared hosting and I'm forced to use expressive on subdirectory. Blast\BaseUrl is very usefull.


Map does not center on second route.

Map does not recenter after second navigation.
sebm-google-map(#epicMap='', [latitude]="lat", [longitude]="lng", [styles]="styles", [zoom]="zoom")
map-ref
sebm-google-map-marker([latitude]="lat", [longitude]="lng")
I use this.map.triggerResize() to force it to rerender in OnAfterViewInit. I have also tride subscribing to the changeBounds event without success.
Any ideas?

Please provide a Plunker where I can see this. Otherwise it's really hard to help you

I also facing the similar issue, when I tried to set the lat & long of map to center it. But some how it's not working.
Please refer the http://plnkr.co/edit/rHXObQapqLuniW8kfC54?p=preview URL.
I have created the one function as SetCenter, 1st time it's working fine but after do any navigation from map it's not working and map is not center with given values.
Any Ideas on this issue ?

@anish751 , @johanssonfredrik  did you ever find a solution? I have the same problem

@anish751 , @johanssonfredrik did you find the solution? I have the same problem.

I am also facing the same problem. Did anyone find the solution?

+1


@graphql-codegen/client-preset-swc-plugin looks for incorrect name for document types

Which packages are impacted by your issue?
@graphql-codegen/client-preset-swc-plugin
Describe the bug
Looks like the @graphql-codegen/client-preset-swc-plugin isn't looking for the correct type name when it the query/mutation name starts with a lowercase.
In the example, the generated document variable is capitalized as GetUserDocument, whereas the swc plugin is looking for the original name. Changing the query to a capital works fine.
"getUserDocument" is not exported by "graphql/graphql.ts", imported by "src/App.tsx".
file: /project/sandbox/src/App.tsx:2:9
1: import { jsx as _jsx } from "react/jsx-runtime";
2: import { getUserDocument } from "../graphql/graphql";
            ^
3: const EXAMPLE_QUERY = getUserDocument;
4: function test(doc) {
error during build:
RollupError: "getUserDocument" is not exported by "graphql/graphql.ts", imported by "src/App.tsx".
    at error (file:///project/sandbox/node_modules/rollup/dist/es/shared/node-entry.js:2105:30)
    at Module.error (file:///project/sandbox/node_modules/rollup/dist/es/shared/node-entry.js:13174:16)
    at Module.traceVariable (file:///project/sandbox/node_modules/rollup/dist/es/shared/node-entry.js:13559:29)
    at ModuleScope.findVariable (file:///project/sandbox/node_modules/rollup/dist/es/shared/node-entry.js:12061:39)
    at Identifier.bind (file:///project/sandbox/node_modules/rollup/dist/es/shared/node-entry.js:7933:40)
    at VariableDeclarator.bind (file:///project/sandbox/node_modules/rollup/dist/es/shared/node-entry.js:5726:23)
    at VariableDeclaration.bind (file:///project/sandbox/node_modules/rollup/dist/es/shared/node-entry.js:5722:28)
    at Program.bind (file:///project/sandbox/node_modules/rollup/dist/es/shared/node-entry.js:5722:28)
    at Module.bindReferences (file:///project/sandbox/node_modules/rollup/dist/es/shared/node-entry.js:13170:18)
    at Graph.sortModules (file:///project/sandbox/node_modules/rollup/dist/es/shared/node-entry.js:24505:20)

Your Example Website or App
https://codesandbox.io/p/sandbox/nervous-jepsen-mw8exq
Steps to Reproduce the Bug or Issue
In the example, run the npm run start command
Error:
query getUser {
  user(id: 1) {
    id
  }
}

Works:
- query getUser {
+ query GetUser {
    user(id: 1) {
      id
    }
  }

Expected behavior
I would expect that I can use a query starting with a lowercase letter.

Looks like this was resolved in #9060

Tagging @JesseVelden, sorry if you get multiple notifications

I just released<EMAIL_ADDRESS>let me know if that fixes this issue

@saihaj that has done it! And thanks @JesseVelden for your work. Much appreciated!


Add an "optional" ParseDefinitionEntry

This functionality allows a query on a log with values that are not always compulsory.
Entry Data

isOptional
defaultValue

If an entry is marked "optional" the following happens:

When parsing string, "isStringCompliant" ignores this entry.
When StdLogEntry.setValuesFromMap does not find a value for the "optional" entry, it skips the value and sets it to the "default value" , when set, otherwise nothing is stored.

Does not seem necessary as there is no difference from leaving it out.


All styles are reported as unused in exported default function.

Thanks for the nice eslint plugin 😊
While testing I saw it at the moment reports all styles as unused in exported default functions.
Example
Using styles in exported default function does report all as unused
export default function Something

Using styles in exported function does work as expected
export function Something

@joarkosberg just to make sure we're on the same page, can you please add a simple code snipper of both cases?

@RodSarhan Sorry for a bit late reply, but it works with latest version, thanks!
Here is simple code snippet if still needed.
With default export
import React from 'react';
import { View } from 'react-native';
import { createStyleSheet, useStyles } from 'react-native-unistyles';

export default function Test() {
    const { styles } = useStyles(styleSheet);

    return <View style={styles.modal}></View>;
}

const styleSheet = createStyleSheet(() => ({
    modal: {
        margin: 0,
    },
}));

Without default export
import React from 'react';
import { View } from 'react-native';
import { createStyleSheet, useStyles } from 'react-native-unistyles';

export function Test() {
    const { styles } = useStyles(styleSheet);

    return <View style={styles.modal}></View>;
}

const styleSheet = createStyleSheet(() => ({
    modal: {
        margin: 0,
    },
}));

No worries i just wanted to confirm, thanks for reporting


Enhanced the UI of login and signup pages

Resolved issue #243
Added interactive images which move while hover with cursor.
Edited both the forms to match the theme of the app.
add gssoc-ext, hactoberfest-accepted and level (1/2/3 -- based on what you think is the difficulty of this task) labels
Preview:
https://github.com/user-attachments/assets/fd36a132-35ec-4065-a6a4-e3d97f1fd7c2

Great Job @prasoonk1204 .


Added filter to show free and paid events

Fixes Issue
Closes #2901

Changes proposed

1)Added filter to show all free and paid events.
2)Modified documentation to suggest adding the startingFrom field in events

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

UI:-

Modified events for testing purpose:-

Note to reviewers

Looks good, I think the field should be more descriptive, something like ...
price: {
   startingFrom: 0
}

Thanks @eddiejaoude, I will make changes soon.

Thanks for making the changes 👍  During testing, I got this error on the user profile page...

Also please update main into this branch to reduce any future conflicts

Can you check now? I'm sorry; I completely missed adding free and paid categories in the user event tab.

no problem, these things happen to everyone
These changes are going to have challenges with another PR https://github.com/EddieHubCommunity/LinkFree/pull/3125
I think the extra filter is a good idea, but not sure how to display it so it doesn't take up too much space on the page 🤔

Can you check now? I'm sorry; I completely missed adding free and paid categories in the user event tab.

no problem, these things happen to everyone
These changes are going to have challenges with another PR #3125
I think the extra filter is a good idea, but not sure how to display it, so it doesn't take up too much space on the page 🤔

I guess we can modify @Aadarsh805  design to include the following and previous icons. We can have a design like pagination.

@eddiejaoude and @shyam0705, I noticed this has stalled, can we pick it back up? I saw the comment about the filters but we could break that part out into a separate issue. wdyt?

@amandamartin-dev  sorry, I was busy due to some personal reasons last week. will pick this back. I am thinking about creating a separate issue to display filters as we add more filters in future.


Change Sinkable to Addressable

re: #583
/assign @evankanderson

Looks good just one change s/a Addressable/an Addressable/
I couldn't comment on the review.

/lgtm

I can't figure out what the actual change is. It shows a binary file with 0 diffs? 🤔

weird - the second commit has a readable diff - but the first not :thinking:

I think on eventing repo the README.md was binary type as well - a couple of weeks ago

Yeah, Im not sure what happened here. I did this edit through the GUI (clicked the pencil icon). You can view the rendered file (with the change) if you click "View" within the "Changed Files" tab. Let me know if this 'binary' thing will cause issues and Ill fork and then open another PR?

It doesn't show up in curl or vi, but when I look at the commit diff I see a stray ^M character that may be confusing github's binary detection:
diff --git a/README.md b/README.md
index 8a525abf..fa65c4c9 100644
--- a/README.md
+++ b/README.md
@@ -4,7 +4,7 @@
 [![Go Report Card](https://goreportcard.com/badge/knative/eventing-sources)](https://goreportcard.com/report/knative/eventing-sources)

 Knative Eventing Sources builds on Kubernetes and Knative to provide useful
-generic strategies for developing a source to deliver messaging events to a
+generic strategies for developing a source to deliver messaging events to an^M
 [Addressable](https://github.com/knative/eventing/tree/master/docs/spec/interfaces.md#addressable)
 target.

@RichieEscarez What you did should not cause this, and I'm not sure why it happened this time. Are you on Windows?

Didn't work I'm afraid:
diff --git a/README.md b/README.md
index fa65c4c9..9272db94 100644
--- a/README.md
+++ b/README.md
@@ -4,8 +4,8 @@
 [![Go Report Card](https://goreportcard.com/badge/knative/eventing-sources)](https://goreportcard.com/report/knative/eventing-sources)

 Knative Eventing Sources builds on Kubernetes and Knative to provide useful
-generic strategies for developing a source to deliver messaging events to an
-[Addressable](https://github.com/knative/eventing/tree/master/docs/spec/interfaces.md#addressable)
+generic strategies for developing a source to deliver messaging events to^M
+an [Addressable](https://github.com/knative/eventing/tree/master/docs/spec/interfaces.md#addressable)^M
 target.

 The Knative Eventing Sources project provides source implementations that:

Ill delete the old commits and try again

@RichieEscarez What you did should not cause this, and I'm not sure why it happened this time. Are you on Windows?

I dont remember but Im guessing I did a copy/paste (unknowingly adding that character)?

There's something weird about this file in general. Here's eventing's README.md:
$ cat -v README.md | head -n 1
# Knative Eventing

Here's the eventing-sources README.md from master:
$ cat -v README.md | head -n1
M-^?M-~#^@ ^@K^@n^@a^@t^@i^@v^@e^@ ^@E^@v^@e^@n^@t^@i^@n^@g^@ ^@S^@o^@u^@r^@c^@e^@s^@^M^@

And the one from this branch:
$ cat -v README.md | head -n1
M-oM-;M-?# Knative Eventing Sources^M

Further research: The ^@ represents the null byte, which suggests to me this may be UTF-16 encoding but mangled in some way that confuses github.

And it goes all the way back to the initial commit: https://github.com/knative/eventing-sources/commit/bf62005eee8899365707bad7e86fbb299f0b4809#diff-04c6e90faac2675aa89e2176d2eec7d8
@dewitt were you experimenting with character encodings on October 18th? :smiley:

#112 converts README.md to UTF-8. Once that's merged, create a new PR, following the same procedure as before, and we'll see if the same issue comes up.

oops, i was doing the same in the background (saved the file as UTF-8)


Missing setNativeProps

Related to https://github.com/styled-components/styled-components/issues/245#issuecomment-349116868

b122597a89eb9e9619e15358eea276d3b97e0d28 allows all props supported by react-native Text.


INSP tokens added

Added INS Promo (INSP) tokens: https://ins.world/#insp_airdrop

Please provide a support email. Instructions can be found here: https://myetherwallet.github.io/knowledge-base/tokens/token-creators-add-your-token-to-myetherwallet.html

Added

Thanks!
On Thu, Nov 9, 2017 at 12:53 PM, Taylor Monahan<EMAIL_ADDRESS>wrote:

Merged #1236 https://github.com/kvhnuke/etherwallet/pull/1236.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kvhnuke/etherwallet/pull/1236#event-1333799880, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AD_vsropTTebt0GOrmyxQqEiPIYzigEqks5s0ue1gaJpZM4QWt04
.

--
Best regards,
Dmitry Khovratovich


readded all of the new files

I did it manas, I added your files again and changed my files

good job thank you for reading the comments


[HOLD for payment 2024-10-30] Copilot - Nothing happens when clicking on the grayed out user when magic code is incorrect

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.52-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers<EMAIL_ADDRESS>https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to Account settings > Security.
Click Add copilot.
Select a user > Next.
Select an access level > Next.
Click Add copilot.
Enter wrong magic code.
Click outside the RHP twice to dismiss it.
Click on the grayed out user under Copilot: Delegated access section.

Expected Result:
Clicking on the grayed out user will open up magic code RHP (production behavior).
Actual Result:
Nothing happens when clicking on the grayed out user when magic code is incorrect.
Workaround:
Unknown
Platforms:

[x] Android: Standalone
[x] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/0432636e-2667-4974-98eb-7b30d99ec25b

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @sakluger

testing reverting this locally as i'm suspicious of it https://github.com/Expensify/App/pull/49445

yep testing locally I'm fairly certain https://github.com/Expensify/App/pull/49445 is the problem
cc @mountiny @getusha @hungvu193

We might add a fix for this in this PR

It's a pass
https://github.com/user-attachments/assets/4464f26d-28dc-4049-b88c-15d531676f21

Reopening for @bondydaa and @sakluger to finish the checklist

i think we followed those steps properly, i don't think we need a regression test or rather we already have one since this was caught during testing so i think we're good here?


Solid Player->Actor Collisions not working in Platformer scene

Describe the bug
Actors do not stop the player in platformer type scenes
To Reproduce
Make a platformer scene with an actor.
Expected behavior
The actor collides and stops the player.
Platform (please complete the following information):

OS: Win 7
App version 3.0.2

Additional context
From what I found in the issues it seems actor collisions are broken / not implemented for most scene types apart from top-down...

I think you should rename and rewrite this a little bit because reading your description I understand that what you want is solid actor collision. Actor-Player collisions work, but they don’t stop the player. This is something I would like to be an option.
We could use it to create walls and moving floors

@maxoakland - true, true, changed it a bit. This is exactly what I need - doors that stop the player until opened...

Hi there, this was flagged in 22, will this ever be fixed or is there a way for me to inject my own code to make this work?
I am currently building a game where the player breaks his way through blocks which need to be actors.
Please help.

This has been added (solid actors in platform mode) in the Platformer+ plugin – https://gbstudiocentral.com/spotlight/platformer-plus/


More information needed

How do I "install/reference" 'PackageA' directly?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 448640a2-cc95-ee40-f4c1-abed6eaf00db
Version Independent ID: d3dde0f2-9aac-f6d9-3887-37efef551e01
Content: NuGet Error NU1107
Content Source: docs/reference/errors-and-warnings/NU1107.md
Product: nuget
GitHub Login: @zhili1208
Microsoft Alias: lzhi

Hi Joel.

Right-click on your project in Solution Explorer and select Manage NuGet Packages for Solution...
Select Installed and click on each package to see the installed version and latest version
Select Updates --> running the updates should correct the issue for you

That's what worked for me.
Good luck,
Al

Adding links


node: do not set unsafe-perm with npm 9 and newer

The unsafe-perm config option has been dropped in npm 9, trying to set it ends with an error and therefore fails the build. With this patch the build script parses the major version from npm --version and only sets unsafe-perm on npm 8 and older.

lgtm


SOLR-8362: proposal for polyField docValues support for TextField

See: SOLR-8362
Cotinuation of: https://github.com/apache/lucene-solr/pull/1691
This PR introduces docValues support for TextField, supporting

sort use case (including configurable post-analysis sort -- a drop-in replacement for SortableTextField, but with more flexibility)
facet/significant-terms use case
useDocValuesAsStored/valueSource/function/streamingExpression use case (configurable to support arbitrarily large size limits)

The rationale behind this PR is essentially the same as laid out in this comment. The main difference in this PR (as opposed to https://github.com/apache/lucene-solr/pull/1691 described in that comment) is that this PR abandons the hope for Lucene-native support for post-analysis docValues (see LUCENE-10023) and instead generates post-analysis docValues by "pre-analyzing" (at the cost of duplicate effort) in TextField.createFields(...).
Lots of relevant context can also be found at: SOLR-11917.

note: precommit will fail due to nocommits, but existing and new tests all should pass.

For anyone curious about this PR at a high level, the refguide additions might be a good place to start:
https://github.com/apache/solr/pull/321/files#diff-c3bd51eeb7d80321dcfd4b8ee946a4c5f17fc22b563fb57dd727baae7461ed46


Fresh install tweaks

As promised on discord, here a few things I came across when I used your repo as a starting point for setting up my NUC cluster from scratch on a Mac.

Looks like there's some merge conflicts, I corrected some things eariler today. Also I updated my darwin taskfile to check for deps instead of installing them.

Wow, I am impressed by the speed you are having in this repo 🙇
Sorry about the merge conflict. Looks like you have rearchitectured the taskfile in a way that it now checks for the required binaries instead of straight out installing them. The actuall installation is not part of your repo anymore, right?
Yesterday, I had my lessons learned about git-crypt when I tried to switch it out for my own keys. I ended up doing my modifications from scratch again...
It is probably easiest if I then open an issue on your repo instead of a merge request.
Going through your setup, I am learning a lot. Good stuff! 🙏

The actuall installation is not part of your repo anymore, right?

This is correct, I'd rather have it check attempt to install binaries.
Glad you're liking the repo, I fixed up most of the issues you had here so going to close this issue.


Add support for category in Add-IntuneWin32App

I'm currently in the process of creating standard templates for common applications to run on new Intune tenants, and have found that we can't define the app category when creating the application this way - requiring us to go and set this later from the portal.
As such, this may lead to wildly different looking setups across tenants, depending on the person running the script or setting up the application - or may even lead to everything lumped into a single default category.

Looks like this is already planned?
https://github.com/MSEndpointMgr/IntuneWin32App/projects/3#card-68400524


'Settings' object has no attribute 'SELECT2_THEME'

Describe the bug
django-select2 uses django-appconf, which has a problem sometimes appearing when using tests with @override_settings() that causes some tests not to be able to see the settings.
The fix is outlined here: consists of making sure that in Select2AppConfig.ready(), we import the conf module.
Exception & Traceback
Traceback (most recent call last):
  File "/home/joachim/other-src/select2_issue/bugshowcase/tests/tests.py", line 14, in test_2
    assert settings.SELECT2_THEME
  File "/home/joachim/.envs/select2_issue/lib/python3.10/site-packages/django/conf/__init__.py", line 83, in __getattr__
    val = getattr(self._wrapped, name)
AttributeError: 'Settings' object has no attribute 'SELECT2_THEME'

Code Snippet
https://github.com/ewjoachim/django_select2_showcase_203
To Reproduce
Steps to reproduce the behavior:

Clone https://github.com/ewjoachim/django_select2_showcase_203.git
Create a venv and activate it
pip install -r requirements.txt
python manage.py test bugshowcase/tests

The 1st test is written so that the 1st time django_select2's configuration is loaded is during a @override_settings context. Because of this, when the 1st test ends, the settings disappear. The 2nd test shows this by trying to read the settings.
The bug is especially annoying as is depends on test order, import order, and many other factors.
Adding an import to django_select2.conf within any AppConfig.ready() solves it.
Expected behavior
no error

note: a workaround for users waiting for this to be merged is to import select2.conf within any of their own AppConfig.ready() method.

Hi @ewjoachim,
Thank you for reaching out. I appreciate the effort you put into the bug report. I'd wish everyone would be so meticulous reporting bugs. That being said, I don't think I fully get the use case here: You are trying to override a setting, that isn't set in your project, right?
In that case, I feel the error is desirable. Our default values shouldn't have any side effects into your project. I am not a big fan of how django-appconf is implemented to begin with and have dropped it in multiple packages, but not this one.
Maybe I am missing something important thought. I'd be wonderful if you could further elaborate your use case.
Best!
Joe

You are trying to override a setting, that isn't set in your project, right?

I think you're missing the point. The problem is not what I override (and it it may convince you, I encourage you to change the override to a setting that's set in the project, such as USE_I18N). The problem is that appconf initializes Select2's configuration when the override is active, and at the end of the tests when the override is disabled, it also removes the settings that appconf put. For example, the setting I use, SELECT2_THEME, supposedly has a default value.
Select2 itself requires this setting to be set e.g. here, and does not expect this setting to not exist. Either we define SELECT2_THEME in our own settings and we get whatever value we want, or we don't and appconf takes care of setting SELECT2_THEME = "default" so that the app works. The problem is that whatever appconf does, it does it the first time it's imported and if this imports happens to be during an override_settings context or decorator, then at the end of the context/decorator, the app is bound to crash, because it will expect SELECT2_THEME to be set and it isn't.

I've changed details on the reproduction repo. The tests now are:

I've changed details on the reproduction repo. The tests now are:
class TestShowcase(TestCase):
    @override_settings(USE_I18N=False)
    @patch("bugshowcase.select2.get_widget", autospec=True)
    def test_1(self, s2):
        self.assertEqual(1 + 1, 2)

    def test_2(self):
        from bugshowcase.select2 import get_widget

        widget = get_widget()
        self.assertNotEqual(widget.render(name="foo", value="bar"), "")

The code under test is:
def get_widget():
    return forms.Select2Widget()

If you launch test 1 or 2 alone, they work. If you launch the 2 tests in the same process, test 2 fails because widget.render ultimately tries to access settings.SELECT2_DEFAULT which is not defined because of test 1
And just in case I need to spell it out, no the right fix is not to replace all settings.SELECT2_* with getattr(settings, "SELECT2_*", some_default). The right fix is to load your settings as soon as possible in django's AppConf.ready() to ensure important stuff doesn't rely on import time.


I cannot add new event  on safari on IPAD ??

The touch click to create a new event or view the event  doesnot happen on the Safari on Iphone/Ipad
and mozilla in mobile devices.
However it works fine on Chrome .
Is there anything i can do to fix this ??
Thanks,

@itokallad
Hi, I'll take a look, thanks for the feedback.

Same issue here, any update?


Renamed project to WebIndex and added license headers

Also, added RAT plugin to check for headers in the future.

To test these changes, I ran the init.sh and webapp.sh scripts successfully.  ITs also pass.


feat(predicted_path_checker): check predicted trajectory to avoid collisions planning can not handle

Description

Discussion: https://github.com/autowarefoundation/autoware/discussions/2859
Issue: https://github.com/autowarefoundation/autoware.universe/issues/2252
In current implementation of Autoware, control module is not responsible for collision checking, except
obstacle_collision_checker package (It can stop the vehicle just for emergency situations.). Planning module is making
stop planning and collision checking using the reference trajectory.
However, vehicles actual path would be apart from reference trajectory in some cases such as starting driving with high
lateral error and at sharp turns.
In this scenarios, planning may not handle the collision in some part of the path because it does collision checking just
on reference trajectory. I think this is a critical safety issue, because vehicle will be open to collision in some cases.
Because vehicle’s actual path is strictly depend on the controller, we decided to add new package (predicted_path_checker) to check obstacle collision on predicted path and stop the vehicle if the collision was not handled by the planning module.

This node will make the vehicle stop if the current situation is emergency (if there is an obstacle in brake distance.) or collision can not be handled by planning module.
Flow Chart:

Before this PR merged, following PRs should be merged before:
https://github.com/autowarefoundation/autoware.universe/pull/3437
https://github.com/autowarefoundation/autoware.universe/pull/3435
https://github.com/tier4/tier4_autoware_msgs/pull/82
Proposed Solutions:
Please feel free to share your ideas on discussion.
Related links

Tests performed

Checked the vehicle state if there is an obstacle in front of the vehicle by using planning_simulator. It worked as I wanted.
Notes for reviewers

While testing the package, you should also checkout these PRs:
https://github.com/autowarefoundation/autoware.universe/pull/3790
https://github.com/autowarefoundation/autoware_launch/pull/367
https://github.com/tier4/tier4_autoware_msgs/pull/88
To test the package, it is enough to run the launch file inside of the package.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Because this node search obstacles similar like in obstacle_stop_planner. It can cause issue talked here: https://github.com/autowarefoundation/autoware.universe/issues/2213
Before the merge I implement same approach to this node in this PR:  https://github.com/autowarefoundation/autoware.universe/pull/2296

cc @TakaHoribe
Because the pause interface is actively used by default_ad_api package, when predicted_path_checker try to make vehicle stop, default_ad_api removes pause request continuously. To avoid this conflict, I want to propose that we can split the pause requests into two: "NOMINAL", "URGENT".

Pause interface would be run in following rules:

Different pause request types can not removes each others pause requests.
Urgent pause request is more prior to nominal pause requests.

I tried this implementation and worked well.
There are some changes for pause_interface:

Changes in pause_interface -> https://github.com/brkay54/autoware.universe/tree/refactor-pause-interface
Changes in tier4_control_msgs -> https://github.com/brkay54/tier4_autoware_msgs/tree/refactor-pause-interface-msgs

Because of changes in pause_interface, some changes are needed in default_ad_api:

Changes in default_ad_api -> https://github.com/brkay54/autoware.universe/tree/refactor-default-ad-api

If we use pause_interface and if we want to avoid conflict (not a rarely conflict, default_ad_api is trying to remove pause request of predicted_path_checker all time), I needed to make some changes in pause_interface. What do you think about this approach?

@TakaHoribe sorry to bother you, we need to decide how make the vehicle stop. I shared my proposal above, please check 🙏🏼 .

We had another call to discuss this. In conclusion:

Instead of adding new Pause state, we will add request_source field in SetPause.srv
Pause Interface node (vehicle_command_gate) will keep the record of requested source and only release pause whenever all the source requests pause: false

Hello, sorry for the delay. I designed node with using point cloud for collision checking. However I needed to make some changes in design. Currently, I changed design for using predicted objects, this week I will update the PR for this.

@TakaHoribe @mehmetdogru
Hello, it is ready for review. While testing the package, you should also checkout these PRs:
https://github.com/autowarefoundation/autoware.universe/pull/3790
https://github.com/autowarefoundation/autoware_launch/pull/367
https://github.com/tier4/tier4_autoware_msgs/pull/88
To test the package, it is enough to run the launch file inside of the package.

@brkay54 I added a label of run-build-and-test-differential to run CI.

@brkay54 Can we merge this PR?

Sorry for the late response, I am planning to work on this, Just i need to fix a small bug. After that, I am gonna merge it in this week.

So sorry for the delay.
@mehmetdogru If it is okay for you, can we merge it?


Feature: Add support to read/save web articles(audio)

Feature: Add support to read/save web articles(audio)
article_web_scraper.py -
What have you Changed

Added article_web_scraper.py, that reads web pages having a <article> tag within it.
Example that saves article to mp3 file:from audiobook.main import AudioBook
audiobook = AudioBook(speed="normal")

audiobook.save_web_article("https://www.theguardian.com/global-development/2022/oct/14/who-dismay-key-oral-cholera-vaccine-shanchol-discontinued-amid-unprecedented-global-outbreaks")

Example that read article from websitefrom audiobook.main import AudioBook
audiobook = AudioBook(speed="normal")

audiobook.read_web_article("https://www.theguardian.com/global-development/2022/oct/14/who-dismay-key-oral-cholera-vaccine-shanchol-discontinued-amid-unprecedented-global-outbreaks")

Fixed tests/

Issue no.(18) -
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me.
[x] One Change in one Pull Request
[x] My file is in proper folder
[x] I am following clean code and Documentation and my code is well linted with flake8.
[x] I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.
Join Us on Discord:- https://discord.gg/JfbK3bS

Thanks for making your PR. I would like to suggest a few things.

Web Articles can be big sometimes. There should be pagination something. you can get an idea about it from the txt_to_json function.
with create_json_book we are converting the input format into the common JSON book format. So you can convert your web articles in the same common format.

Thanks for making your contributions.
you can join us on telegram for more updates about Hacktoberfest.
Join Hacktoberfest Community Channels/Server.

Raise an Issue to join the organization(self invite)

Telegram

Discord

Happy hacktoberfest


Refactor - close #13 close #14

SSE events and slash-create events initialized in similar manner as discordjs events
code restructured according to new event structure
component interaction handled via slash-create
ephemeral confirmation message sent to user after vote

What error are you talking about?

Not sure what you mean, what WIP commit and what error are you talking about @Joelone ?
This WIP commit and other lint error
5f0fc967c38fe2c87d43abf0a081e6a56967db36


First pass containerization.md

solves #18
I figure we should create a container image definition as well?

Looks great too! Created a PR where I changed a few things around (only stylistic changes). Question: Should there be an "and" here: This file can be version controlled and (?) the build process can be automated, allowing an organization to focus on other priorities while the automated processes take care of the build.

This PR was updated in #45.
closing #41

Reopening to merge.
closes #18


Update Audit Logging documentation for 1.10

Sorry for the late PR
This is a docs PR for the Advanced Audit Logging feature. Items to address in this update are listed in the umbrella issue for this release.
/cc @tallclair @sttts @ericchiang @CaoShuFeng

/milestone v1.10

Per request of @Bradamant3 putting a temporary hold on anything going into 1.10 until her big patch merges

/hold cancel

In this case it's probably better to avoid "you" not because the style guide says so (the style guide actually recommends "you" over "we", for example), but because load isn't a thing that makes sense to apply personal ownership to. I'd take @ericchiang's suggestion.

Can someone from the docs team comment on the use of "you" and "your"? Instead of:
Parameters should be set to accommodate your load on the apiserver.
I generally prefer:
Parameters should be set to accommodate expected apiserver load.
Though I see "you" and "your" used throughout the docs, so it doesn't seem like we have a hard rule.

@crassirostris can you get the requested changes in today? We need to get docs PRs for 1.10 merged. Thanks! (or give an ETA if today's impossible?)

@Bradamant3 can I apply the files on Monday?

@crassirostris we can make that work. Thanks for the update!

@Bradamant3 thanks a lot! First thing Monday morning then

Also addressed some out of place "you"s

@Bradamant3 Could you please review this PR?

@crassirostris sorry caught two more things. Thank you!

@Bradamant3 Done, thanks so much for your thorough review!

/approve
/lgtm
(because tech reviewer forgot the slash on the /lgtm)


Consider a way to set "nice" value for task

When a user submit a large number of bulk requests, I want those tasks to have less priority than one-off tasks submitted via process page manually by user. I believe one way to do this to allow task to have "nice" value and rule handler to set it to higher value when it submit tasks.
I think there are other ways to accomplish similar effect, but we should brain storm this.

I've added "nice" to the task model and updated task handler to handle non-nice tasks. User can set nice to any positive number. (I've also updated warehouse rule handler to set it for stage/process tasks).
It seems to be working nicely /pun, but nice tasks also needs to contend with next_date not set early enough to grab the resource when it becomes available. I might need additional logic to let non-nice tasks grab the resource as soon as it becomes available? Or maybe the logic of nice alone is optimal?


Very long delay for registering a new user with SuperLogin/Couchdb

[ also posted on StackOverflow: http://stackoverflow.com/questions/40876553/very-long-delay-for-registering-a-new-user-with-superlogin-couchdb ]
I am facing a 30-second delay when registering a new user through SuperLogin in a CouchDB database. Sometimes it's even longer, causing a timeout error in the server.
However, everything runs on the same local machine, Fauxton is usually pretty fast, as well as the data synchronization I am doing between this CouchDB database and a PouchDB app.
Would you have any idea about how to fix this? Or at least how to get more logs about what is happening?
Below is:

the Node/SuperLogin server output showing the 30secs+ delay between the OPTIONS and the POST (OPTIONS is due to CORS, but I have the same 30secs+ delay when the POST query comes from postman, so CORS should not be the cause)

the Server.js source code

the client code.

Many thanks!

server output

>node server.js
Memory Adapter loaded
App listening on 3000
::1 - - [29/Nov/2016:21:44:42 +0000] "OPTIONS /auth/register HTTP/1.1" 204 - "http://localhost:8100/" "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.87 Safari/537.36"
::1 - - [29/Nov/2016:21:45:19 +0000] "POST /auth/register HTTP/1.1" 201 27 "http://localhost:8100/" "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.87 Safari/537.36"

server source code (run through node server.js)

var express = require('express');
var http = require('http');
var bodyParser = require('body-parser');
var logger = require('morgan');
var cors = require('cors');
var SuperLogin = require('superlogin');

var app = express();
app.set('port', process.env.PORT || 3000);
app.use(logger('combined', { immmediate: true}));
app.use(bodyParser.json());
app.use(bodyParser.urlencoded({ extended: false }));
app.use(cors());

app.use(function(req, res, next) {
   res.header("Access-Control-Allow-Origin", "*");
   res.header('Access-Control-Allow-Methods', 'DELETE, PUT');
   res.header("Access-Control-Allow-Headers", "Origin, X-Requested-With, Content-Type, Accept");
   next();
});

var config = {
  dbServer: {
    protocol: 'http://',
    host: 'localhost:5984',
    user: 'admin',
    password: 'bigsecret',
    userDB: 'sl-users',
    couchAuthDB: '_users'
  },

  mailer: {
    fromEmail<EMAIL_ADDRESS>    options: {
      service: 'Gmail',
        auth: {
          user<EMAIL_ADDRESS>          pass: 'mypwd'
        }
    }
  },
  userDBs: {
    defaultDBs: {
      private: ['supertest']
    }
  },
}

// Initialize SuperLogin
var superlogin = new SuperLogin(config);

// Mount SuperLogin's routes to our app
app.use('/auth', superlogin.router);

http.createServer(app).listen(app.get('port'));
console.log("App listening on " + app.get('port'));

client code

var headers = $http.defaults.headers.post;
var user = {
    "name": 'John',
    "username": 'John',
    "email"<EMAIL_ADDRESS>    "password": 'passwd',
    "confirmPassword": 'passwd'
};
var req = {
  method: 'POST',
  headers: headers,
  url: "http://localhost:3000/auth/register",
  data: user
};
return $http(req)
  .then(function(res) {
    console.log("success");
  }, function(err) {
    console.log("error");
  });

Finally after tracing the code, it looks like the 30 seconds are almots fully taken in CouchDB, when creating a new database for the newly registered user.
I now have to figure out why it takes so long to CouchDB to create a new DB.


Post count is wrong after routed to "Published" or "Draft" and pager is used

This is because post count is done based on returned count of posts for respective state "Published" / "Draft".

Fixed by https://github.com/ymita/Lifelog/commit/5bfaa1e413a2edac951d8355b06ad38472e7ea7f.


Implement Reconnect() for dropped connections

This does require storing the password in the Client struct however
it's a small tradeoff for being able to reconnect the client object
without having to create an entirely new instance

Thanks for the PR, I guess this means you're using this as a library, as the tool itself shouldn't need to reconnect. I hadn't thought of that use-case at the time.
LGTM!


Add a wLog syslog appender

Updated to last changes on wLog

except for the definition remark +1

@akallabeth I have treated your ramark

Same remark as @akallabeth I think we shouldn't have config.h in an exposed header.
Otherwise it looks good. Nice work!
+1

Ok so no more config.h include in public headers.


Rethrow slingshot exceptions on client

If an RPCExecutionException is caught and it is a slingshot exception, that exception should just be re-thrown to match any original try/catch.
It is also worth considering if there is a way to lookup a Java exception class to be instantiated and rethrown but this seems far more danger fraught.

hey @haus , if you have the permission to do so can you unassign me from this?

@vilmibm by your command

@haus you're really going to let him off that easy?

i think so

🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏


Orderly kernel module version upgrade

Issue summary
Kernel module version upgrade must allow user to control the order of the pods(nodes) upgrade, and the timing of the upgrade of a specific pod (node).
Current upgrade process
Current upgrade process is as following:

User updates Module CR with the new image-container
KMM updates ModuleLoader DaemonSet with the new configuration
k8s ReplicaSets controller initiates a rolling upgrade of the DaemonSet, which means that the pods of the DaemonSet will get destroyed and recreated one by one, in the order defined by the controller.

Current flow causes the following difficulty:

User needs to terminate workload on a node prior to the ModuleLoader pod being destroyed (otherwise modprobe -r will fail)
User does not want to delete all the workloads on all the nodes ( downtime), but do it one by one
Since we don't know  the order of ModuleLoader rolling upgrade, user cannot  schedule the workload per node downtime correctly

Proposed Solution

Add a "Module Version" field to Module CRD. This field will be set by the user and updated whenever the ModuleLoader image is updated. Its value will be used as another input for NodeSelector field of the ModuleLoader
When the Module CR is updated with new "ModuleVersion" and the new "Image" fields, it will not update the existing ModuleLoader,  but will create a new ModuleLoader, with the new image and the new module version as part of NodeSelector
Garbage collector will need to be updated to collect ModuleLoader with existing kernels but irrelevant module versions

Upgrade Flow example

User create a Module CR with image, module version and selector fields
User labels the appropriate nodes with 2 labels: "module version": module version and node selector field from CR
ModuleLoader is created with node selector field set to Selector field and Module version field and starts running on the labeled nodes
User updates the Module CR with new image and new module version
KMMO creates a new ModuleLoader with node selector field set to CR's Selector field and new Module Version. At this stage new ModuleLoader is not running on any nodes, since they do not contain new module version label
User picks one node and does the following:
1. Remove workload on the node
2. Remove module version label on the node
3. Add new module version label on the node
4. Restore workload on the node

/assign @yevgeny-shnaidman

As mentioned above, one of the main challenges of supporting seamless kernel module upgrade is if a workload is using the kernel module. In that case, the command modprobe -r to unload the kernel module will fail. As a result, there needs to be a way to remove all workloads that are using that particular module so that we can unload the module successfully.
Potential Solution
One way to potentially address this gap is to look at the device plugin resource exported from device plugin associated with that particular kernel module. We can find all workloads on a node that are using the resource and only drain those workloads. If we can find such an API that can drain workloads on a node for a particular resource, then KMM can simply call that API prior to unloading the kernel module. One such API that may fit the usage case is kubectl drain, however more investigation is needed to confirm whether the current API can accomplish what we need.

Device plguin exports some specific resource to cluster, to use any of these resources in cluster, the pod has to claim the resources in the yaml to create the Pod, so it might be possible to just drain the pods claiming any resources that are related with the driver module we want to upgrade. After that it is safe to rmmod the kernel module and then insmode the new modules to upgrade the drivers. We can start from "kubetctl drain" command and figure out whether we can add the resource claiming as a parameter to drain the pods.

@hershpa @uMartinXu KMM responsibility is to deal only with kernel modules and device plugins. It does deal with any workloads that are running after kernel modules are loaded. It is up to other customer's operator to managed the workload. So, it seems to me that those operators, and not KMM, should also decide when and how the workload should be removed from the node. In addition, allowing KMM to actually drain nodes is very problematic: KMM is not a core operator, it does not know what workloads are running on the nodes. Draining the nodes will remove ALL workloads from the nodes, including those that have no dependencies on the KMM.  In most of the cases, upgrading kernel module does not require removal of all the workloads from a node.


Give user the power to select the mode of compilation

maybe while compiling it shows the user a prompt to compile locally or via api. If user wants to compile lo locally add a handler that goes ahead and downloads the necessary package for the language and then compiles locally.

Good idea, but this project is not aimed to what you are looking, it does the compilation online only.