[FEATURE] option to sort by numeric value?

If you have files named:

1
9
10

then the resulting Array of filename will be sorted as:

1
10
9

This is because the sort is based on ASCII character value (I think), and the first character of "10" is "1", which is less than "9".
It would be neat if there was an option to sort based on numeric value, taking into account the actual value of all leading digits together.

omg, and why this should be in the core? lol. In any way you get the result so you can do it what you want. Just pass nosort to disable internal sorting.

Yeah, I think it'd be ok to add a feature to let you pass in a JavaScript sort function (of the kind passed to Array.sort), but the default built in sorting will remain as it currently is.

v9 no longer sorts by anything, so it's up to you to sort the results however you see fit.


Anchor to "Can Microsoft 365 Business Premium customers use Microsoft Defender for Endpoint?" is incorrect

[Enter feedback here]
The anchor link to "Can Microsoft 365 Business Premium customers use Microsoft Defender for Endpoint?" subsection points to "Where can I learn more about the opportunities and benefits in becoming a Microsoft Partner?" instead of the correct section.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 07ad1d58-d970-7e3c-91b7-84639d307ed8
Version Independent ID: 1cb6b2df-6565-e248-ee83-6154c49a0056
Content: Microsoft 365 Business Premium frequently asked questions
Content Source: microsoft-365/business/support/microsoft-365-business-faqs.yml
Product: microsoft-365-business
GitHub Login: @efrene
Microsoft Alias: efrene

@lof747 Thank you for your feedback. The URL https://partner.microsoft.com/en-US/membership/cloud-solution-provider/find-a-provider points to a page to Find an indirect provider.
The next topic has a link  https://partner.microsoft.com/membership/cloud-solution-provider which points to  Where can I learn more about the opportunities and benefits in becoming a Microsoft Partner
Both the URL's are accurate.
@yogkumgit There are no changes required in this document.
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @lof747 Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Add license and rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


explorer: detect program rebase

The goal here would be to detect and handle a program rebase that happens after the plugin has performed its analysis. Following a rebase the plugin should update accordingly so the addresses for rule/feature matches are accurate (re-run capa analysis is probably most straightforward solution).
Quick solution may be hooking RebaseProgram IDA UI event (see <ida_install>\cfg\idagui.cfg).

from an initial scan, i dont see an IDA callback for the "rebase program" event. but, might be able to use ida_idp.IDB_Hooks.segm_start_changed?

oh, i see what you're suggesting: to use idaapi.UI_Hooks and register a RebaseProgram event handler


Forced URL scheme for multilanguage and multiversion

Hello,
Reading the code, I understand that you assume the page is published, using the version and language configuration, following the scheme :

https://<html_baseurl>/<language>/<version>/<page>.html

https://github.com/jdillard/sphinx-sitemap/blob/02bbe94613ca1164a0f73865659d240fadb3f808/sphinx_sitemap/__init__.py#L103-L104
Is there a reason to force this construction? For instance, on our website, we use the construction:

https://<base>/<version>/<language>/<page>/html

What would be the way to make it work for our scheme?
Thanks

This assumption probably comes from Read the Docs, since this project was created after a discussion there https://github.com/readthedocs/readthedocs.org/issues/557#issuecomment-377420985

Thanks for the reply.
@jdillard Would you accept a patch for a configurable url? For instance something like:
scheme = app.config.i18n_url_scheme or "/{lang}/{version}/{link}"
url = site_url + scheme.format(lang=app.builder.config.language, version=version, link=link)

Correct, I had made it opinionated based on RTD's scheme just to get something out. Although, it looks like I forgot to make an issue to remind myself to circle back and fix it, nice catch and nice fix!
PR's gladly accepted! I just did a quick test and that looks like that solution will work, it just may need some finagling to get everything aligned again. If you want to submit a first draft I can help clean it up if it needs any.

I merged your changes in and then realized it forced a multilanguage and multiversion scheme as a default and didn't like that so changed the behavior to only include language and version if they exist and auto appended a trailing slash to each. You can still re-arrange them, you just don't need slashes anymore. I also changed the new config value name to sitemap_url_scheme since language is optional now.
That is all documented in the README now if you would like to test the master branch before I cut a new version.

Great, thanks for the addition and for the adaptation !

Thanks for the contribution, this was a great step forward! I went ahead and released it as version 2.0.0 since it has the possibility to be a breaking change for lower versions.
I already tested it with some unique schemes I have in other projects and the configuration is much cleaner now.


[1.11] Add more data to diagnostics bundle

High-level description
Added:

timestamp for dmesg
distro version
timedatectl
systemd unit status
pods endpoint

Backport: https://github.com/dcos/dcos/pull/3148
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-4127

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label Ready For Review

@branden @klueska @philipnrmn @gpaul Can you take a look and override flaky test?

@mesosphere-mergebot override-status teamcity/dcos/test/aws/cloudformation/simple https://jira.mesosphere.com/browse/DCOS-19619

@mesosphere-mergebot merge-it


[FEATURE]Add support for encoding H168n v3.1

i sucessfully decode the config.bin and enabled telnet but the router wont accept the config.bin matched  key is  GrWM3Hz&LTvz&f^9 i only able to decode with --try-all-known-keys

for those who have zte h168n v3.1 i able to use the customized  config file by this command:
python3 examples/decode.py  input.bin output.xml --key 'GrWM3Hz&LTvz&f^9'
python3 examples/encode.py --signature 'ZXHN H168N V3.1' input.xml output.bin --key 'GrWM3Hz&LTvz&f^9'


morphedByMany and composite primary key not working

Hi,
I have a issue with polymorphic many-to-many relationship using a composite primary key.
It's related to https://vuex-orm.github.io/vuex-orm/guide/model/relationships.html#defining-the-inverse-of-the-relationship-2
But, it's like the posts entity has a composite primary key.
Basically it returns a list of items, but they are all undefined.
My pivot table is like this (just not called taggable):
export class CollectionnableEntity extends Model {
    static entity = 'app-collectionnable';

    static primaryKey = [
        'collection_id',
        'collectionnable_id',
        'collectionnable_type'
    ];

    static fields() {
        return {
            collection_id: this.attr(null),
            collectionnable_id: this.attr(null),
            collectionnable_type: this.attr(null)
        };
    }
}

It could be nice to be able to specify the separator (static string) between fields for composite primary keys. This would probably ease splitting things for pivot tables, or use a different separator (like double underscore __) for joining keys in pivot tables.

@merlosy Hi! Thank you for the report! Hm... I haven't tested with 3 campsite key in fact... I should write test case on this.

It could be nice to be able to specify the separator (static string) between fields for composite primary keys. This would probably ease splitting things for pivot tables, or use a different separator (like double underscore __) for joining keys in pivot tables.

Yeah, current composite key handling is not ideal. We had another idea on storing array as an string like '[1, 1, 2]' and extract them when we need to use it. We should continue discuss on how to handle I think.

@merlosy Hi! It has been a while, but do you have any reproducible code on this one?

Closing the issue due to inactivity. Please feel free to reopen it if there is anything! 🤝

why was this closed?

@kiaking Can we reopen, it would be good to fix this bug I can have a look

@Tofandel you can create an issue in the next repo since this repo will no longer receive updates as per the README.

Maybe we can get a backward fix for 0.36 as well when fixed on next as well as this is a bug?

@Tofandel In that case your best option would be to fork the repo and patch the lib with a fix for your own use. Remedial work such as this is far too extensive for a version that is no longer maintained and has a successor in progress. Sorry!


Temporarily disabling a broken pyfontaine code snippet…

…that deals with the get_orthographies method. It seems that this code is using a deprecated API method implementation. We gotta figure out what is the new way of implementing this, so that we can bring the feature back.

Please file an issue for this


Automated Package Upgrade

:tada: This PR is included in version 27.1.23 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[SILGen] Emit block after unreachable when emitting if/switch expressions

When emitting the underlying switch statement for a switch expression, we emit an unreachable if the subject is uninhabited. Statement emission code can handle this, but expression emission expects an RValue to handed back. To remedy this, emit an unreachable block that we can emit the rest of the expression emission code into. The SILOptimizer will then drop this unreachable block.
Resolves #66490

@swift-ci please test

@swift-ci please test Windows


ODS-Component - App Bar Bottom

Supporting component
https://m2.material.io/components/app-bars-bottom/android#bottom-app-bar

This component is considered as non essential from the design perspective. We should deprioritize and take it out until a request is made on the subject.


Extend MaterialSpec for arbitrary properties

Is your feature request related to a problem? Please describe.
Currently, MaterialSpec can be used define the refractive index for materials. Would be nice if it could be extended to support other  attributes, such as, loss tangents.
Describe the solution you'd like
Extend MaterialSpec to support arbitrary properties such that a LayerStacks alongside a group of MaterialSpecs (maybe a new MaterialStack?) would give all possible layer and material properties. This would be useful for simulation workflows.

I had started something similar a while back, but a different (purely optical) solution was one instead. Feel free to get inspiration
https://github.com/simbilod/gdsfactory/tree/material_database/gdsfactory/database/materials


Added stations, enhance the search bar, added loading animation at station page, added zone and address of the stations.

Pull Request Template for GSoC 2024
Related Issue
#196
Description of Changes

[X] Added the station list available in india.
[X] Data coming from backend using api.
[x] Improved search feature.
[x] Added loading animation on station page.
[x] Added dataset of the station along with their address, zone and code for further feature.
🥇 Plesase assign level3 as the work i have done!.

Type of Pull Request

[ ] Bug Fix
[x] New Feature
[ ] Performance Improvement
[ ] Documentation Update
[x] Code Refactoring
[ ] Security Enhancement
[x] Other (Specify): Added station list.

Screenshots / Demo

[x] I have reviewed my code before submission.
[x] I have read and followed the project's Contribution Guidelines.
[x] I have tested the code thoroughly.
[x] I have attached related issue numbers, screenshots, or videos (if applicable).
[x] I have added comments to my code where necessary for clarity.
[x] I have checked the existing code base and my changes do not introduce any breaking changes.
[x] My PR addresses only one issue; I have created separate PRs for other issues.
[x] I have ensured that the PR does not include unrelated files.
[x] I am mindful of the project's coding standards and best practices.

Additional Information
[Include any additional context or relevant information that may help in reviewing this PR.]
Contribution Guidelines Reminder
Thank you for contributing to our project! Please ensure you follow the guidelines below:
Contribution Levels

Task Categories:

Advanced Tasks: Complex tasks like building new features, significant refactoring, or critical bug fixes. Labeled as Hard.

Acknowledging Effort:

Exceptional contributions will be recognized with a higher contribution level if substantial effort and innovation are demonstrated.

Review Process

PRs will be reviewed by the maintainers, and feedback will be provided. Contributors should address feedback promptly and resubmit the PR if necessary.

Contributors are encouraged to participate in the review process of other PRs for community growth.

We appreciate your time and effort in improving this project and look forward to your valuable contributions!

@Vaibhav-Samdani please share a video of changes

@dhairyagothi as the size of video is greater than the limit of the github, I have uploaded on drive. Here is the link :
https://drive.google.com/file/d/1YlLYsvOkeIh1SPQR9mwHLAvG6cGCl5hq/view?usp=sharing

@Vaibhav-Samdani access

@dhairyagothi access granted!

that's really great @Vaibhav-Samdani
can you please add api files in frontend folder ??? so that it can be access in deployment

Can you explain me what do you mean by api files in frontend?

can we fix this @Vaibhav-Samdani

@dhairyagothi added the stations to frontend so that it will run without backend. check it now!

thank you so much @Vaibhav-Samdani loved the preloader


More documentation

What it is
Main features
Some screenshots to understand better what it is

It would help new people get involved in the project!

Just use KlovitClient as this is outdated.


Media Like not working!

Hello community,
I have used this lib for Instagram post. but why does can not like for and media post?  I'm calling below method for perform Like on any media.
Method name: "InstagramLikeRequest"
Error Title: "Action Blocked"
Error Message: "This action was blocked. Please try again later. We restrict certain content and actions to protect our community. Tell us if you think we made a mistake."
Feedback Url: "repute/report_problem/instagram_like_add/"
Anyone help me for this features. Thank you.

It seems like a restriction for Instagram, given it has been detected as spam true.


Support for additional factors in token

The CSRF token generated is only dependent on time by default, i.e., without additional work, generated tokens are valid for all users in multi user sites.
However, tokens should be unique per user session as stated in https://cheatsheetseries.owasp.org/cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.html#synchronizer-token-pattern
A workaround would be to use different secret_keys per user (e.g., append the user id to the site wide secret), but this seems clumsy (and should probably get documented). @aekasitt
https://github.com/aekasitt/fastapi-csrf-protect/blob/81bbece1dc214de0b0a7395fc21b53433c196214/fastapi_csrf_protect/core.py#L39-L41

I'll look into this.

The assertion is that the CSRF Token generated is dependent on time by default; But I'm not sure that is observed by the code snippet given above. The serializer (itsdangerous's URLSafeTimedSerializer) is only dependent on time by default, but then the token is generated by a secondary process of hashing sha1(urandom(64)).hexdigest() which I think qualifies as session dependent unless it can be credibly observed as timestamp dependent where two sessions generated at the exact same timestamp (a rarity but not an impossibility) can cause a collision with the same CSRF Token

The following attack is trivial since the CSRF token isn't really checked against anything (but time validity):

(malicious) user A gets a (valid) CSRF token from our site
user A makes user B send a POST using user A's CSRF token
profit
https://github.com/aekasitt/fastapi-csrf-protect/blob/3682f9d82b24d66e059e379d9a67904416099096/fastapi_csrf_protect/core.py#L112-L118

The lib should either send a random value (no signing necessary) and actually store this in a session, and check the submit data/header against that value (in OWASP this is the "Synchronizer Token Pattern"), or it should set a random value in a cookie, and check whether the cookie value and the submit data/header info matches (the OWASP "Double Submit Cookie" approach).
fastapi-jwt-auth uses the Double Submit Cookie approach - if fastapi-csrf-protect wants to do the same, it's missing the actual value check. In fastapi-jwt-auth, that's the following code.
https://github.com/IndominusByte/fastapi-jwt-auth/blob/a6c06193319da0e4976c7472966f3a2891e0d50c/fastapi_jwt_auth/auth_jwt.py#L516-L521
Note all the JWT/HMAC/encrypting things are not strictly necessary for CSRF. The Double Submit Cookie approach doesn't rely on encryption/HMAC but on the fact that an attacker cannot control or know the CSRF token value stored in the cookie but has to supply that value in headers/form data.

This would defeat the purpose of the library. You're looking for a Session solution.
The scope of Cross-Site Reference Protection has been met with current implementation.

Unique per user session.
Secret (Can be stored in Cookies for enhanced Secrecy)
Unpredictable (large random value generated by a secure method).

The library doesn't have any concept of a user session; it doesn't actually store the token in a (server-side) session but only in a cookie; and the CSRF token (value) stored in that cookie is never checked against the token (value) that gets submitted via headers or form data. The only thing that's checked is basically well-formedness of the token (HMAC, max_age) which is not enough.
@aekasitt Did you read https://github.com/IndominusByte/fastapi-jwt-auth/blob/a6c06193319da0e4976c7472966f3a2891e0d50c/fastapi_jwt_auth/auth_jwt.py#L516-L521 ?
if not hmac.compare_digest(csrf_token,decoded_token['csrf']):
                    raise CSRFError(status_code=401,message="CSRF double submit tokens do not match")

The key point there is that csrf_token comes from request headers/form data, and decoded_token is obtained from the CSRF cookie.
This check is missing completely in fastapi-csrf-protect.

I agree with you that fastapi-jwt-auth's csrf token is more sophisticated since it depends on a session id (client-side and stored in cookies, but session id nonetheless)
I am telling you that it goes beyond the scope of this simple library.
It is in fact preferable if session integrity is preferred to use alternative library such as the one you mentioned.
To prevent the attack you mentioned, with Scammer A building a real-time cloned page with stolen CSRF token for User B;
What is being attacked there is session integrity, which this library never claimed to protect against.
Such attack can be prevented using SameSite cookie, shortening Max-Age and storing CSRF Token in Cookies for enhanced secrecy.

The attacker doesn't need to "steal" any CSRF token. He can just use a token that our site gave to him, and use that token in a POST request he makes user B submit.
That is no session integrity attack, there's no session involved.
Perhaps there's a misunderstanding that a "session" is?
E.g., I was wondering in this code snippet
https://github.com/aekasitt/fastapi-csrf-protect/blob/3682f9d82b24d66e059e379d9a67904416099096/fastapi_csrf_protect/core.py#L32-L41
it says "multiple calls to this function will generate the same token" which clearl is not the case.
In any case, as it is, this library doesn't provide protection against CSRF, at least not in the sense OWASP etc. use those terms.
In Cross Site Request Forgery protection, the point is checking form data/header info against a CSRF (server side) session token or CSRF cookie value, which this library doesn't do.

You have a misunderstanding of the OWASP requirements, and I used the word "session" because of it was used in the document.

It satisfies the OWASP requirements as I previously explained.

Unique per user session. (randomly generated using urandom(64))
Secret (Can be stored in Cookies for enhanced Secrecy)
Unpredictable (large random value generated by a secure method). (already satisfied)

The cached comment I can remove. Not sure how that got there. Thanks!

Please refer to the Defense in Depth Techniques section of the attached OWASP document
Does your attack vector make sense with SameSite Cookie Attribute properly configured?

Of course the token has to be unique per user session and it has to be validated against the user session (on POST). Every other CSRF library does this. Look at the code I mentioned, and just for fun, https://github.com/wtforms/flask-wtf/blob/72419060c0ce71c002098e304121f7b61c7ec985/src/flask_wtf/csrf.py#L118-L119 is the corresponding code in flask-wtf.
Sorry, but as it is, fastapi-csrf-protect is completely broken.

Yeah please help with SameSite :) I've been confused as to why you raised this issue and not that.

Token generation satisfies OWASP requirements.
Session integrity preservation is outside of Cross-Site Reference Forgery Protection.
Code breaking side-problem found, SameSite not yet implemented in version 0.2.0.
Closed.

validate_csrf_in_cookies() only looks at the cookie. It doesn't check against form data/headers. Any attacker doesn't need to guess any token at all and can just make the victim POST any form data, it'll check out.
https://github.com/aekasitt/fastapi-csrf-protect/blob/3682f9d82b24d66e059e379d9a67904416099096/fastapi_csrf_protect/core.py#L120-L126


fix lerna version

fix the lerna version so the build continues

looks like docker needs a restart on that circleci vm  ?

@guzzijones we've seen similar problems in other projects relying on docker registry and so far the only thing that had any effect is to try and restart the job some time later. Two weeks should be plenty enough for any kind of networking issues to resolve. There's plenty of other suggestions on the internet to try logging out of docker and logging back in, but they sound awfully like just trying all the options under the sun.
Do you want to try and restart this job again to see if anything has changed?

Thanks @enykeev and good to see you! 👍
I just pushed a dummy commit to @guzzijones fork to rebuild it (CircleCI seems to not allow GH-based login anymore) and it failed in a later step: https://app.circleci.com/pipelines/github/StackStorm/st2web/3867/workflows/b15c3ceb-1ca1-4d6c-9fd7-8b678b2584d8/jobs/6170?invite=true#step-119-1823_20
Looks like lerna should be pinned in more places:
https://github.com/StackStorm/st2web/blob/73e75f6632471595c42081e912372ad456caaffc/Makefile#L15
@guzzijones can you update it, or perhaps @enykeev want to try in a brand new PR? We'll need more involved dependency updates anyway.

@armab I'll try to have a look on the weekend and see if if I can figure out what's wrong. That is if your efforts will not succeed. I will however need you to add me to maintainers so I can rerun CI runs at will.

@enykeev I had to push some dummy commits to @guzzijones fork as CircleCI re-build and access rights are terribly broken (I got 404s and 50Xs myself even for the CircleCI builds in the org https://github.com/StackStorm/st2web/assets/1533818/25fc89c0-cb53-4d46-bb50-c7055caf92ad). If you could work on your fork, - the builds could be restarted OK.
The real work, - we'll need an overall renovation, audit and updating the dependencies + nodejs and whatnot for st2web (example, see: https://github.com/StackStorm/st2web/pulls/app%2Fdependabot) and st2chatops (more severe). I'll ask for temporary access rights from the TSC for this work if we'll hit a roadblock.
@enykeev Could you please join us in Slack (#tsc channel in https://stackstorm.com/#community)?


New version: Youku.Youku version <IP_ADDRESS>1

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.4 schema?

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/115258&drop=dogfoodAlpha

@wingetbot run


clean up old files

Scope
What is changing with this PR?
Deleting old unused files
Why?
They are no longer needed
Why are we doing this?
To not have clutter
Todos
N/A
If any, what are the follow-up tasks required other than merging this PR? Have they been arranged?

[ ]

Found one more ref in some really old file. Deleted that as well.

Well then, that terrible file was for an outdated test, I will correct that.

eventually i will stop dropping the ball on this

Lost some code coverage on the config test, will have to revisit that when working on the config parser to remove remaining old config syntax


[SPARK-29837][SLQ] PostgreSQL dialect: cast to boolean

What changes were proposed in this pull request?

Make SparkSQL's cast to boolean behavior be consistent with PostgreSQL when
spark.sql.dialect is configured as PostgreSQL.
Why are the changes needed?

SparkSQL and PostgreSQL have a lot different cast behavior between types by default. We should make SparkSQL's cast behavior be consistent with PostgreSQL when spark.sql.dialect is configured as PostgreSQL.
Does this PR introduce any user-facing change?

Yes. If user switches to PostgreSQL dialect now, they will

get an exception if they input a invalid string, e.g "erut", while they get null before;

get an exception if they input TimestampType, DateType, LongType, ShortType, ByteType, DecimalType, DoubleType, FloatType values,  while they get true or false result before.

And here're evidences for those unsupported types from PostgreSQL:
timestamp:
postgres=# select cast(cast('2019-11-11' as timestamp) as boolean);
ERROR:  cannot cast type timestamp without time zone to boolean

date:
postgres=# select cast(cast('2019-11-11' as date) as boolean);
ERROR:  cannot cast type date to boolean

bigint:
postgres=# select cast(cast('20191111' as bigint) as boolean);
ERROR:  cannot cast type bigint to boolean

smallint:
postgres=# select cast(cast(2019 as smallint) as boolean);
ERROR:  cannot cast type smallint to boolean

bytea:
postgres=# select cast(cast('2019' as bytea) as boolean);
ERROR:  cannot cast type bytea to boolean

decimal:
postgres=# select cast(cast('2019' as decimal) as boolean);
ERROR:  cannot cast type numeric to boolean

float:
postgres=# select cast(cast('2019' as float) as boolean);
ERROR:  cannot cast type double precision to boolean

How was this patch tested?

Added and tested manually.

Test build #113579 has started for PR 26463 at commit 75d51ba.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18465/
Test PASSed.

Test build #113579 has finished for PR 26463 at commit 75d51ba.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113579/
Test FAILed.

Test build #113591 has started for PR 26463 at commit 2ab1847.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18478/
Test PASSed.

cc @cloud-fan

cc @gengliangwang

Test build #113591 has finished for PR 26463 at commit 2ab1847.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113591/
Test PASSed.

Test build #113606 has started for PR 26463 at commit 6ad100c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18492/
Test PASSed.

Test build #113606 has finished for PR 26463 at commit 6ad100c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113606/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18501/
Test PASSed.

Test build #113616 has started for PR 26463 at commit 0b9a78d.

Test build #113616 has finished for PR 26463 at commit 0b9a78d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113616/
Test FAILed.

Test build #113632 has started for PR 26463 at commit b7c6baf.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18515/
Test PASSed.

Test build #113632 has finished for PR 26463 at commit b7c6baf.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Filed the flaky test: ImageFileFormatTest.test_read_images

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18559/
Test PASSed.

Test build #113677 has started for PR 26463 at commit 68c7a13.

Test build #113677 has finished for PR 26463 at commit 68c7a13.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113677/
Test FAILed.

Jenkins, retest this please.

Test build #113685 has started for PR 26463 at commit 68c7a13.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18570/
Test PASSed.

Test build #113685 has finished for PR 26463 at commit 68c7a13.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113685/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18588/
Test PASSed.

Test build #113710 has started for PR 26463 at commit 999ec61.

Test build #113712 has started for PR 26463 at commit a178b79.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18592/
Test PASSed.

Test build #113710 has finished for PR 26463 at commit 999ec61.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113710/
Test PASSed.

Test build #113712 has finished for PR 26463 at commit a178b79.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113712/
Test PASSed.

thanks, merging to master!

Thanks a lot ! @cloud-fan


Implement fire_event function

Great. I'll look on it.
But its better to create separate example for the native events playground.

Do you mean that I should add examples for fire event as a separate file?

Exactly.

Ok, I'll add as soon as I get an answer to http://sciter.com/forums/topic/fire-event-and-data/. Since I don't understand why fired event can be caught by handler which is attached to main window only.

Going to look this weekend. Sorry for delay :)

Did it myself today.


feat: update goks to v0.6.1

Update goks to v0.6.1.

alright, fixed the test issue and the go.dev caching problem. this is ready to review.


[runit integration] give a bit of time to start runsv

Currently, we run sv start immediately after linking the service.
The runsv process may not be up at the moment, as a result of which
openrc will mark the service as stopped, even though it may be brought up
by runit at the next scan.
This is documented in the gentoo wiki:
https://wiki.gentoo.org/wiki/Runit#OpenRC.27s_runit_integration_feature
This PR adds a timeout so that correct process state can be reported.
Before:
# rc-service netdata-runit start
 * Starting netdata-runit ...
fail: /run/openrc/sv/netdata: runsv not running
 * Failed to start netdata-runit                                          [ !! ]
 * ERROR: netdata-runit failed to start

After:
 rc-service netdata-runit start
 * Starting netdata-runit ...
fail: /run/openrc/sv/netdata: runsv not running
ok: run: /run/openrc/sv/netdata: (pid 15725) 1s                           [ ok ]

I would make the wait time a variable which can be configured.
Also, do we need the loop/sleep algorithm at all if we set the wait time on sv start?

@williamh
Sleep loop is needed, as runit's directory scan can take upto 5 seconds to bring runsv up, after which the service is started (wait time is for the service). Thats why the loop counter of 6.
Thanks.

One more question.
Can we kick the scanner so it brings runsv up right away instead of just doing a sleep loop? I'm asking all of these questions because  I would rather find a way to make things come up faster than add a sleep loop to every runit service.

Afaik @williamh  it could also be avoided by putting some sleep in the runit run scripts.
But hang on, I'll ping our runit guy.
@konimex

It won't work since runit marks the service as started as soon as the sleep command is run.
Also, the loop and sv -w 6 start is a bit useless IMO since sv start is basically the same as sv -w 7 up or sv -w 7 start.
Anyway, I'll take a look at the bug, sv start shouldn't return anything other than 0 if the service has been symlinked and started.

@williamh
I appreciate your concern. Here is how it play out in practice. Following script is used for checking:
success=0; failure=0
for i in {1..10}; do if rc-service netdata-runit start; then success=$((success + 1)); else failure=$((failure + 1)); fi; sleep 1s; rc-service netdata-runit stop; sleep 1s; done
echo "success: $success";echo "failure: $failure"

With patch (edited to echo slept time):
 * Starting netdata-runit ...
slept: 1
slept: 2
slept: 3                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...
slept: 1                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...
slept: 1                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...
slept: 1                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
success: 10
failure: 0

Without patch:
 * Starting netdata-runit ...
fail: /run/openrc/sv/netdata: runsv not running
 * Failed to start netdata-runit                                                                                [ !! ]
 * ERROR: netdata-runit failed to start
 * WARNING: netdata-runit is already stopped
 * Starting netdata-runit ...
ok: run: /run/openrc/sv/netdata: (pid 19332) 1s                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...
ok: run: /run/openrc/sv/netdata: (pid 19667) 1s                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...
ok: run: /run/openrc/sv/netdata: (pid 19981) 1s                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...
ok: run: /run/openrc/sv/netdata: (pid 20295) 1s                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...
fail: /run/openrc/sv/netdata: runsv not running
 * Failed to start netdata-runit                                                                                [ !! ]
 * ERROR: netdata-runit failed to start
 * WARNING: netdata-runit is already stopped
 * Starting netdata-runit ...
ok: run: /run/openrc/sv/netdata: (pid 20615) 1s                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...
ok: run: /run/openrc/sv/netdata: (pid 20953) 0s                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
 * Starting netdata-runit ...
fail: /run/openrc/sv/netdata: runsv not running
 * Failed to start netdata-runit                                                                                [ !! ]
 * ERROR: netdata-runit failed to start
 * WARNING: netdata-runit is already stopped
 * Starting netdata-runit ...
ok: run: /run/openrc/sv/netdata: (pid 21272) 1s                                                                                [ ok ]
 * Stopping netdata-runit ...                                                                                [ ok ]
success: 7
failure: 3

In theory, I agree that running sv start ${service} should start runsv, wait 7 seconds for the service to be up, and then report status and exit.
In practice, it seems not to function this way. Maybe we create a race condition by first linking the service, not waiting for it to come up, and running sv start ${service} ?
To be sure will need to look at the source as @konimex suggests. In practice the patch works well enough in my opinion. Adding the sleep allows OpenRC to report the correct status, the service takes the same time to be up regardless.

In practice, it seems not to function this way.

IIRC, it's because runit has detected that there's no error in the daemon (i.e. something that would block the daemon from running properly so runit has to restart it until timeout (by default 7 sec, or 6 sec since you specified -w 6)), it just returns 0.
So I'd say it's an intended behavior.

Can we get this merged? Fixes the incorrect service status and does not lead to long sleep loop in most cases. Check https://github.com/OpenRC/openrc/pull/253#issuecomment-436886189 for demo.

Hi all,
Have used a different approach. Instead of adding upto 6 second delay,  we dont report false failed.
Status can be checked via rc-status.
https://github.com/OpenRC/openrc/pull/322


fix(db): parse pooler connection string more safely

What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.09%) to 58.595%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
6064

Relevant Lines:
10349

💛  - Coveralls


fix(NetworkTransformReliable): Fix stutter and recovery

cleaned up here: https://github.com/MirrorNetworking/Mirror/pull/3410


Videos keep playing after closing tab

Apparently videos are not stopped, when a tab is closed. This can be either because the webview is not released, or because the plugin is not told to stop.
When starting the video, then closing the tab, the video keeps running. Probably related to #1112

Do you mean that you encountered this problem with the branch of #1112 and with the Flash plugin installed ?

No, the branch has the issues that I mentioned in the review. It is the current Vienna master branch version. I am not sure whether it is a flash or html5 video.

Seems to be some custom player according to the website, but I have no idea on what technology it is based. When I do the same as above in Safari, the video stops when closing the tab.

I remember that Apple used to have a separate process for decoding the video, until they added support for hardware decoding. It might be that the legacy WebView still uses this, possibly on older hardware.

I was not able to reproduce the problem, so I can not really help here.

For additional information, I use flash player "NPAPI-Plug-In-Version <IP_ADDRESS>", Mac OS 10.13.4, and as I said the current main-branch version of Vienna.

Possibly solved with #1121, let´s see

See comment in #1121

solved by #1125


document translation

I just started to contribute open-source project by translation.
It seems the 4.x API document(ko) remains untranslated.
If you agree with, I can translate into Korean.

Hi @BaroqueCoding, thanks for the offer.   LoopBack 4 is still very much under development, and the docs are not ready for translation yet.   I wouldn't suggest starting on translation until after v4 GA, which will be some time next year (likely late Q1 or Q2, I suspect, but still TBD).
If you're interested, you could help translating v3 docs to ko, because there is a lot not yet translated.  For general instructions to contribute translations, please see http://loopback.io/doc/en/contrib/translation.html.

Hi @BaroqueCoding Thanks for the offer.
We haven't translated the API documentation into any languages.  The rest of the doc is translated, but not the API doc.
If you want to help update the Korean translation of other parts of the docs, that would be great.
Just compare the date of the ko page to the corresponding en page, and if the en page has been modified more recently, the translation needs updating.  Compare the changes in the en page to see specifically what needs to be updated in the translation.


Bazel build issue

ERROR: Config value 'opt' is not defined in any .rc file
comes out.

@yama-can,
In order to expedite the trouble-shooting process, could you please provide the following information OS Platform, TensorFlow version, Installed using virtualenv? pip? conda?, Bazel version, GCC/Compiler version, CUDA/cuDNN version.
Also there is a similar issue already assigned to the developer which is still in progress and requesting to follow the same for the updates.
https://github.com/tensorflow/tensorflow/issues/58453
Thank you!

@yama-can, since you have used --config=opt, I think you are running it on CPU/windows. you need to run configure.py (located at https://github.com/tensorflow/tensorflow/blob/master/configure.py) before you can the build command(bazel build --config=opt //tensorflow/tools/pip_package:build_pip_package)

Thank you!!
I have successfully built tensorflow.

@yama-can ,
@mraunak given the right answer.
Whenever we choose --config=optoption in bazel build command, we must run ./configure.py and this is mandatory for this option. During ./configure.py there will be default option for this based on the platform we are using. Please refer the below line from /configure.py where default is chosen already based on the platform.
For windows:
Please specify optimization flags to use during compilation when bazel option "--config=opt" is specified [Default is /arch:AVX]:
For Linux:
Please specify optimization flags to use during compilation when bazel option "--config=opt" is specified [Default is -Wno-sign-compare]:
If you would have run the ./configure.py then it might be resolved already for you. Please feel free to close the issue if resolved already. Thanks!


[BEAM-96] Add composed combine functions builders in CombineFns

compose() or composeKeyed() are used to start composition
with() is used to add an input-transformation, a combine fn and an output TupleTag
A non-CombineFn builder is used to ensure that every composition includes at least one item
Duplicate output tags are not allowed in the same composition

R: @bjchambers

updated and pushed


Mod Support (Project Red)

Add support for project red lamps, making them emit their color.

1.7.10 version is out of date, the rework is written from scratch, so I close this bug.


Exception fingerprinting for Spark

This pull request is for exception fingerprinting of Spark jobs . Jobs which get analyzed by Dr Elephant and are failed , will go for exception fingerprinting to know whether the exception is because of AutoTuning or User code.

This pull request is specifically for Spark Exception fingerprinting and its integration with Dr Elephant. Note this pull request is for the first version .

Design doc for detail explanation is
https://docs.google.com/document/d/1jRCJOs0Fm-4sCUYfmFGoEEw0dYNANaSjPC6q9bT5j2s/edit?ts=5c46b8a1#heading=h.9w7131bfjrao
Testing

Unit test cases are written to do the unit testing
End to End testing is done on local machines (taking jobs from one of the LinkedIn cluster)

@mkumar1984 @varunsaxena please spend some time in reviewing this pull request

@mkumar1984 @varunsaxena please review it . As we are adopting the job , this pull request should get merge , for better working of Auto Tuning .

LGTM.

@mkumar1984 Have resolved the conflicts and changed the base to linkedin:tuning_20190221 , please merge it .

As discussed offline, we need to handle the case where Dr.Elephant goes down for a period after which some of the apps may not be available in RM. And upon restart, apps are backfilled by Dr.Elephant by reading job history files for MR and SHS for Spark. In this case we need to get the AM container logs link as well.
Right now we get it only from RM.


Fix for: CreateItem & UpdateItem Firing

'Max call stack size exceede' using node-ews library.

Coverage decreased (-0.09%) to 92.316% when pulling 412ae80690199de70aa952b297b81fa8609871ab on omerson:master into e9e798cdea726de4878e43cade8d36e74fd1b3dc on vpulim:master.

Coverage decreased (-0.09%) to 92.316% when pulling 6f41af7a73bdc213171ebdeba26576e16ac58d8e on omerson:master into e9e798cdea726de4878e43cade8d36e74fd1b3dc on vpulim:master.

Coverage decreased (-0.09%) to 92.316% when pulling d15909d869dd2416072bdd9c9b1cdf6ca36d72bd on omerson:master into e9e798cdea726de4878e43cade8d36e74fd1b3dc on vpulim:master.

Coverage decreased (-0.09%) to 92.316% when pulling d15909d869dd2416072bdd9c9b1cdf6ca36d72bd on omerson:master into e9e798cdea726de4878e43cade8d36e74fd1b3dc on vpulim:master.

Coverage decreased (-0.05%) to 92.361% when pulling c2cd47375bc272ab4a67abe6b7a292b3f8823d66 on omerson:master into e9e798cdea726de4878e43cade8d36e74fd1b3dc on vpulim:master.

Please, don't just revert the changes to the package name in package.json but the whole changes made to the package.json file.

package.json reverted

Coverage decreased (-0.05%) to 92.361% when pulling 364a15dcc80fd21ae2455a31b3fcb3c3b852f458 on omerson:master into e9e798cdea726de4878e43cade8d36e74fd1b3dc on vpulim:master.

There are 8 failing tests shown over at Travis CI - it would be awesome if you could fix them so that we can merge your PR :+1:

+1

Coverage increased (+0.1%) to 92.558% when pulling dff589a4b10848bfd7ae31686155af9453c680c0 on omerson:master into e9e798cdea726de4878e43cade8d36e74fd1b3dc on vpulim:master.

Coverage increased (+0.1%) to 92.558% when pulling dff589a4b10848bfd7ae31686155af9453c680c0 on omerson:master into e9e798cdea726de4878e43cade8d36e74fd1b3dc on vpulim:master.

Were meant to be made on the soap repo @omerson ?

Coverage decreased (-0.1%) to 92.558% when pulling 258ad3c0824b38749ffb3abdffccae78b6bfa849 on omerson:master into 57c64f573a6e5f4ecdf46982a765231a1ca74672 on vpulim:master.

Coverage decreased (-0.1%) to 92.558% when pulling c9ad5d32251ca0d041c6066c039b0e097ab92076 on omerson:master into 57c64f573a6e5f4ecdf46982a765231a1ca74672 on vpulim:master.

Coverage decreased (-0.1%) to 92.558% when pulling e9d3afc296ccd9f1e8aeeec229f134494e31d2cd on omerson:master into 57c64f573a6e5f4ecdf46982a765231a1ca74672 on vpulim:master.

Coverage decreased (-0.1%) to 92.558% when pulling d6687838338bff3210e90cdcdb3964ad887f85ab on omerson:master into 57c64f573a6e5f4ecdf46982a765231a1ca74672 on vpulim:master.

Coverage decreased (-0.1%) to 92.558% when pulling d6687838338bff3210e90cdcdb3964ad887f85ab on omerson:master into 57c64f573a6e5f4ecdf46982a765231a1ca74672 on vpulim:master.

Coverage decreased (-49.7%) to 43.029% when pulling c8d7f989303ca86a6672263c8293a2f5a41fbcf2 on omerson:master into 57c64f573a6e5f4ecdf46982a765231a1ca74672 on vpulim:master.

Coverage decreased (-0.1%) to 92.558% when pulling a47df8c4eb3ac2e33677de3f70ddb381fbea8409 on omerson:master into 57c64f573a6e5f4ecdf46982a765231a1ca74672 on vpulim:master.

Thanks for your patience and frequent updates @omerson - we appreciate it a lot :+1:
LGTM - but I'd need you to provide at least 1 test for your addition so that we can assure your fix isn't going to be overwritten accidentially in future PRs.
Also, I'd love to hear @jsdevel 's opinon :smiley_cat:

Thanks @herom please advise on writing test, since I am new to github collaboration. Could you please provide some reading or example.

The best test examples are found in our request-response-samples section where you can provide a small sample of your wsdl and expected parsed json results - please look through these examples as they are the best source for reproducible test results :+1:

Yes this fixes my problem too. Please can you accept this  sooner to production version.

This happens for other WSDL files as well it seems: I'm getting it for the Salesforce Marketing Cloud wsdl: https://webservice.exacttarget.com/etframework.wsdl

Yes this fixes my problem too. Please can you accept this sooner to production version.

As @herom mentioned earlier we need some request/response samples added to the test suite.  Merging a PR in haste to fix an issue is counterproductive if the code hasn't been tested and causes other unwanted issues, or if it breaks with future changes and we're unaware because there were no tests to verify the fix.

Just for future-reference: we also have a CONTRIBUTING.md file where we set a few "rules & standards", also for Submitting a Pull Request.
The reason why we ask for this is best summarized in @jsdevel's post above

Merging a PR in haste to fix an issue is counterproductive if the code hasn't been tested and causes other unwanted issues, or if it breaks with future changes and we're unaware because there were no tests to verify the fix.

Perhaps it's a good idea to bring this 1 sentence into the first chapter of our README.md so that more people are aware of our "PR policy"?

closing due to inactivity


[stable/openvpn] Kubernetes 1.16 compatibility

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Update api versions (deprecated -> actual) to support k8s 1.16
ref: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

/approve
/lgtm

Thanks for the contribution!


Adding format and edit files breaks imports in TS projects using node module resolution

After this commit, I'm unable to figure out how to get webpack to play nicely with this library.
Adding the dependency and doing nothing else, I get Uncaught Error: Cannot find module ".". If I suppress the require function using imports-loader, everything used to work, but now I get an error because require is no longer a function.
This may be an issue with my understanding of how Webpack/TS handle different module resolution strategies being used concurrently, but I'm now somewhat stuck.

@TedDriggs Let me know if all works for you...

That worked perfectly; thank you!


training issue

Hi,
I start the training with run_stage1.sh.   One error message comes up when saving the training model at step 3000.
Any suggestions?
Thanks,
--Ruida
tensor(0., device='cuda:1', grad_fn=)
^M  1%|          | 2998/298104 [2:14:08<221:28:49,  2.70s/it]tensor(0.0031, device='cuda:1', grad_fn=)
tensor(0., device='cuda:0', grad_fn=)
^M  1%|          | 2999/298104 [2:14:11<222:10:07,  2.71s/it]tensor(0.0236, device='cuda:0', grad_fn=)
tensor(0.0002, device='cuda:1', grad_fn=)
^M  1%|          | 3000/298104 [2:14:14<222:58:27,  2.72s/it]^M                                                           ^M{'loss': 12.1835, 'learning_rate': 6.7084078711985685e-06, 'epoch': 0.02}
^M  1%|          | 3000/298104 [2:14:14<222:58:27,  2.72s/it][INFO|trainer.py:2807] 2024-01-29 13:30:51,045 >> Saving model checkpoint to ./output/stage1/checkpoint-3000
[INFO|configuration_utils.py:458] 2024-01-29 13:30:51,047 >> Configuration saved in ./output/stage1/checkpoint-3000/config.json
[INFO|configuration_utils.py:375] 2024-01-29 13:30:51,048 >> Configuration saved in ./output/stage1/checkpoint-3000/generation_config.json
[INFO|modeling_utils.py:1859] 2024-01-29 13:31:01,586 >> The model is bigger than the maximum size per checkpoint (10GB) and is going to be split in 3 checkpoint shards. You can find where each parameters has been saved in the index located at ./output/stage1/checkpoint-3000/pytorch_model.bin.index.json.
[INFO|tokenization_utils_base.py:2210] 2024-01-29 13:31:01,586 >> tokenizer config file saved in ./output/stage1/checkpoint-3000/tokenizer_config.json
[INFO|tokenization_utils_base.py:2217] 2024-01-29 13:31:01,631 >> Special tokens file saved in ./output/stage1/checkpoint-3000/special_tokens_map.json
[INFO|tokenization_utils_base.py:2267] 2024-01-29 13:31:01,632 >> added tokens file saved in ./output/stage1/checkpoint-3000/added_tokens.json
Figure saved: ./output/stage1/trainer_state.png
Traceback (most recent call last):
File "/data/me/NExT-Chat/mllm/pipeline/finetune.py", line 141, in
main()
File "/data/me/NExT-Chat/mllm/pipeline/finetune.py", line 62, in main
train_result = trainer.train()
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/transformers/trainer.py", line 1539, in train
return inner_training_loop(
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/transformers/trainer.py", line 1901, in _inner_training_loop
self._maybe_log_save_evaluate(tr_loss, model, trial, epoch, ignore_keys_for_eval)
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/transformers/trainer.py", line 2237, in _maybe_log_save_evaluate
self._save_checkpoint(model, trial, metrics=metrics)
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/transformers/trainer.py", line 2306, in _save_checkpoint
save_fsdp_optimizer(
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/accelerate/utils/fsdp_utils.py", line 138, in save_fsdp_optimizer
optim_state = FSDP.optim_state_dict(model, optimizer)
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/torch/distributed/fsdp/fully_sharded_data_parallel.py", line 1818, in optim_state_dict
return FullyShardedDataParallel._optim_state_dict_impl(
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/torch/distributed/fsdp/fully_sharded_data_parallel.py", line 1246, in _optim_state_dict_impl
return _optim_state_dict(
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/torch/distributed/fsdp/_optim_utils.py", line 1447, in _optim_state_dict
fsdp_osd["param_groups"] = _unflatten_param_groups(
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/torch/distributed/fsdp/_optim_utils.py", line 1238, in _unflatten_param_groups
nested_unflat_param_names = [
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/torch/distributed/fsdp/_optim_utils.py", line 1239, in
param_to_fqns[param] for param in param_group_params
KeyError: Parameter containing:
tensor([[ 1.2517e-06, -1.7881e-06, -4.3511e-06,  ...,  8.9407e-07,
-6.5565e-06,  8.9407e-07],
[ 2.6588e-03, -4.0588e-03,  2.1038e-03,  ..., -9.7656e-03,
3.4580e-03, -4.0665e-03],
[ 1.0414e-02,  8.3237e-03, -5.6038e-03,  ...,  2.6588e-03,
-1.3170e-03, -3.6335e-03],
...,
[ 7.1006e-04,  6.8368e-04, -4.5054e-04,  ..., -4.3397e-04,
-9.7029e-05, -4.8664e-04],
[ 7.1006e-04,  6.8368e-04, -4.5054e-04,  ..., -4.3397e-04,
-9.7029e-05, -4.8664e-04],
[ 7.1006e-04,  6.8368e-04, -4.5054e-04,  ..., -4.3397e-04,
-9.7029e-05, -4.8664e-04]], device='cuda:0', requires_grad=True)
^M  1%|          | 3000/298104 [2:14:43<220:51:57,  2.69s/it]
[2024-01-29 13:31:15,414] torch.distributed.elastic.multiprocessing.api: [WARNING] Sending process 2211037 closing signal SIGTERM
[2024-01-29 13:31:15,528] torch.distributed.elastic.multiprocessing.api: [ERROR] failed (exitcode: 1) local_rank: 0 (pid: 2211036) of binary: /gpfs/gsfs12/users/me/conda/envs/next_chat_dist/bin/python
Traceback (most recent call last):
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/bin/accelerate", line 8, in
sys.exit(main())
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/accelerate/commands/accelerate_cli.py", line 47, in main
args.func(args)
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/accelerate/commands/launch.py", line 1014, in launch_command
multi_gpu_launcher(args)
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/accelerate/commands/launch.py", line 672, in multi_gpu_launcher
distrib_run.run(args)
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/torch/distributed/run.py", line 797, in run
elastic_launch(
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 134, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/gpfs/gsfs12/users/me/conda/envs/next_chat_dist/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 264, in launch_agent
raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
/data/me/NExT-Chat/mllm/pipeline/finetune.py FAILED
Failures:
<NO_OTHER_FAILURES>
Root Cause (first observed failure):
[0]:
time      : 2024-01-29_13:31:15
host      : cn1113.hpc
rank      : 0 (local_rank: 0)
exitcode  : 1 (pid: 2211036)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html

I guess it is torch version's problem. I use "2.1.1+cu118" in my code. You can take a try for torch==2.1.1
Later, I will add a deepspeed training, which does not have the problem.

I switch to pytorch 2.11 + cu11.8.   The same error message.

I add the deepspeed training, where the weights will not be saved via fsdp. Maybe it will help. The instruction is here.

Thanks for the update.  I switch to the latest code release.
In nextchat_deepspeed.py,  I change the per_device_train_batch_size from 8 to 2.  I run two A100 cards and get the running out of memory exception.   What's your card training scenario?  Thanks.

Sorry.  I run your deepspeed update with 4  a100 cards.   It starts running.  Thanks for the updates.


Bump seroval to 0.7.0

This is just a patch.
seroval 0.5.0 had some broken serialization-related stuff but mainly on Typed arrays. seroval has also added support for 8 new types. There are no breaking changes though.

Thanks


Mark false positive GHSA-5jx5-hqx5-2vrj ollama

https://github.com/wolfi-dev/os/pull/20366

https://github.com/wolfi-dev/os/pull/20341
This could be the reason for failing validation
Do we need to rename all the advisory or create a new one and let the old ones as it is.

@cpanato we need you here to merge this PR, 🙏🏻

we need to fix the ci issue first


Add option to ignore previous config files

If default_config_files is set to:
["/etc/conf/app_config.ini",
 "/etc/conf/conf-enabled/*.ini",
 "~/.my_app_config.ini",
 "./app_config.txt"]

It would be nice to be able to tell which one was used.
Something like:
get_used_config_path()
Or let parse_args return the used config path if found

The format_values() method reports where an arg came from.
The ignore behavior is not something that many people would want AFAIK.


Add Frigg CI

This PR adds a .frigg.yml config file to run onlineweb4 tests.
The current build is failing, becuase the project contains pep8 and isort issues.
All you need to do to integrate with Frigg is to do the following:

Add Github Webhook

Go to your project repository on Github
Click Settings
Click Webhooks & Services
Click Add Webhook

Add http://ci.frigg.io/webhooks/github/ as the Payload URL

Set Content Type to application/json
Click on Send me everything
Click Update webhook

Then you can visit https://ci.frigg.io to see build status, Frigg will also report on all PRs.
@lizter

See https://frigg.io/docs/ for more docs

You may also take a look at: https://ci.frigg.io/frecar/onlineweb4/34/ to see how this will work.

Looks cool! We'll take a look at it at our next meeting.

Sweet, and by the way; If you want more speed, you can easily set up your own dedicated workers :) Frigg aims to be a collaboration where organizations configure workers for their own and for others to use :)

Thanks a lot for the PR. We're looking forward to testing this more! :)

Cool, please let me know if you run into any problems! :)


Docs: Submit buttons spacing

According to the pages in the DSM, Submit buttons should be 30px away from the last input.

This PR will need an explanation in the migration guide.


Config rename_response_column to clickhouse connection

I am trying this query
with
	x as (select 1 as a, 2 as id),
	y as (select 1 as a, 3 as id)
select
	y.a,
	y.id
from
	x
	join y using (a)

And the result is
y.a|y.id|
---+----+
 1|   3|

Is there any way/config to remove automatically the alias y. in the final response (without using y.a  as a)?
In DBeaver, I can config rename_response_column=REMOVE_PREFIX in database connection.
but when I tried config in clickhouse's profile:
    ch:
      type: clickhouse
      name: ch
      schema: ch
      host: "{{ env_var('DBT_ENV_CH_HOST') }}"
      port: "{{ env_var('DBT_ENV_CH_PORT', '8123') | int }}"
      user: "{{ env_var('DBT_ENV_SECRET_CH_USER') }}"
      password: "{{ env_var('DBT_ENV_SECRET_CH_PASSWORD') }}"
      secure: False
      custom_settings:
        rename_response_column: REMOVE_PREFIX

There is an error:
10:35:36  Encountered an error:
Database Error
  Setting rename_response_column is unknown or readonly

How can I config this setting properly?

seem the new setting is not handled by clickhouse-connect, I just create ticket for enhancement in https://github.com/ClickHouse/clickhouse-connect/issues/228

Just a heads up, this is also not supported by the clickhouse-driver project (which dbt-clickhouse uses for native connections) or any other ClickHouse client that I'm aware of other than the Java/JDBC driver.


Use for loop instead of str.replace

Currently _hex2array uses String.replace(/(..)/) to build an array out of a hex string. Even though convenient this is way much slower than a normal for loop with String.substr(). In my tests, the current solution is more than 80% slower than the proposed one, see the jsperf test case here.

Great, thanks!


Overriding WebSocket Implementation

Hi Gals/Guys,
My company is using sip.js in a cordova softphone project. We have had a lot of success with our custom MediaHandler which uses a modified version of phonertc that includes a native websocket implementation.
Moving on, the reason for the native websocket implementation is because in order to receive calls on iOS while the app is in background mode we needed to set the socket interface for VoIP usage.
The problem we are having is that we would like to test our websocket implementation against sip.js to make sure everything is working but we can't seem to find a straightforward way to override the default websocket implementation without forking the project.
I would like to know if this is possible? If not would the sip.js team provide a patch we can use? Do I just bite the bullet and fork the project?
Best,
Thomas Quintana
P.S. Thank very much for all the hard work!

Hi Thomas,
In 0.6.4, you should be able to simply override window.WebSocket before creating the SIP.js UA.  Since 0.6.4, there have been some improvements that allow you to manually specify dependencies such as WebSockets and Promises.  Most of those changes were done with Node.js in mind, but I would guess they would apply to mobile and cordova as well.  @joseph-onsip, do you know if it is possible to override the default WebSocket implementation using environment?

Woah! Awesome response time! I apologize we are using 0.6.3.

Hi guys, I guess we should have specified that we are currently on 0.6.3 because our MediaHandler for phonertc doesn't use your Promises stuff yet. Any way to do this with 0.6.3?

You can probably still override window.WebSocket at any time before creating the UA.  We aren't caching that internally or anything, so when the UA is created and attempts to connect, it will use whatever implementation it sees globally.
This is all based on how it works in a browser.  It's possible that cordova and iOS causes that behavior to change.  Let me know if that doesn't work, and we can try to investigate further.

(note that the commits mentioned below aren't yet in a tagged release)

we are currently on 0.6.3 because our MediaHandler for phonertc doesn't use your Promises stuff yet

Once I realized that the Promise stuff could break custom mediaHandlerFactory implementations, I fixed it in https://github.com/onsip/SIP.js/commit/f3e5cfa40bb99df33bfc830987263b36794db9d8

@joseph-onsip, do you know if it is possible to override the default WebSocket implementation using environment?

It sure is (as of https://github.com/onsip/SIP.js/commit/63d205ceea4976f8af91a6f50608a3e71339ea00)! See https://github.com/onsip/SIP.js/pull/108 for information on how to provide a custom environment.

Thank you guys very much for the prompt responses. I am currently trying the recommendations and I will update once tested.

Hey Guys,
@wakamoleguy overriding window.WebSocket did the trick in Cordova.
Cheers,
Tom

Awesome! Background calls on iOS here we come!

Hi Guys,
We've finally updated our plugin to use promises, but it looks like we need to be overriding the global WebSocket differently now. How should we override the Websocket in 0.7.1?

I guess I should really be asking, how do we override WebSocket after SIP.js has already been instantiated? Overriding window.WebSocket in our dialer was working in SIP.js 0.6.4, however on 0.7.1, that no longer works.

+1

OK Guys. Well... Was a different problem. Sincere apologies for the bother!

OK. I was wrong yet again. Its definitely not override the websocket like before. I'm going to open a new issue to track this.


Automatically fix the clippy lints

Here a first batch of fixes, it is just cargo clippy --fix, let me know what you think.
If you like the idea I can complete the work by fixing the lints clippy cannot automatically fix.

It's great, please go ahead with your work.


ENH: Add firefly browser screenshots to the HTML version

Since we only do static HTML rendering at the moment, there is no real demonstration there of how a firefly window would look like.
Maybe we should break the rule of including binary output data, and include a couple of screenshots in those notebooks?

While brainstorming on this, @jaladh-singhal also mentioned that gifs may be nice, too.
Anyway, I add this to the rainy day ideas as it would be nice, but not at all critical to have.


Disable new Firefox JSON Viewer

Starting in Firefox 53, raw JSON responses are now displayed in a JSON viewer widget by default.  This is convenient for development, but breaks automated tests which have historically expected JSON to be displayed in the browser as raw text (like many of the tests in edx-platform).  I'm hard pressed to see this viewer being useful in automated tests, so this change disables it by default for new Firefox sessions.

@edx/testeng This is ready for review.


2to3-2.7 -w *.py

Fixes #2 by running 2to3 over all the Python files I could find. I haven't extensively tested, but it did stop the errors I was having.

Also now fixes #1 by resetting file pointer following the example in earlier parts of the existing code.

Thanks for diagnosing the problem and making the PR!
Running 2to3 fixed the Python3 problems in cli.py, but it made a bunch of unnecessary changes in kinjector.py so I kept the original version. I uploaded the files to the fix branch. Give it a try. If it still fixes your problems, then I'll move it to master and release version 0.0.6.

The fix branch successfully handles the Python 3 syntax errors, but my attempt to fix the other bug with https://github.com/xesscorp/kinjector/pull/3/commits/6ad35b76cdccd50c49ad14d9385a7040a896fa83 is not working. You could merge the whole thing back to master because it's not a regression, but you might want to hold off while I have a look why it's still broken. Looking now.

Ugh, I have a fix but don't understand why it works. Replace yaml.load() with yaml.safe_load() and it successfully raises an exception. Otherwise the loader happily passes through the KiCad PCB file contents as if they were valid YAML.
It's up to you whether to take that suggestion. It does fix it.

I tried your fix with using safe_load(), but it didn't seem to work for me.
Then I tried passing a KiCad board file to an online YAML linter, and it was accepted as valid YAML! So getting an exception from the yaml.load() function may not be the way to go. I found that when a board file is passed to yaml.load(), it returns a string object containing the contents of the entire file. So I modified the code to only accept the file as YAML if yaml.load() returns a dict() object. That seems to work (for me).
You can give it a try if you like. It's in the fix branch.

Looking for an empty result was going to be my next approach, but I wanted to try to preserve as much of the original code flow as possible. Oh well!
Just tested locally, and it properly fails to fail. Note that I haven't verified whether YAML is parsed or written, since my own workflow uses JSON. So if you can verify that the YAML path hasn't broken, then we should be good to go. Thanks for sticking with this issue and getting it resolved!

I verified the YAML path was working in my environment. I've released version 0.0.6 on Github and PyPi.

Thanks for sticking with this issue and getting it resolved!

No problem. Thanks for using Kinjector.


Not all DUB output is interesting to read

Output today
Building logger 0.3.3 configuration "library", build type debug.
Running dmd...
Building colorize 1.0.5 configuration "library", build type debug.
Running dmd...
Building gfm:logger 2.3.15 configuration "library", build type debug.
Running dmd...
Building derelict-util 2.0.0 configuration "library", build type debug.
Running dmd...
Building derelict-sdl2 1.9.2 configuration "library", build type debug.
Running dmd...
Building gfm:sdl2 2.3.15 configuration "library", build type debug.
Running dmd...
Building gfm:math 2.3.15 configuration "library", build type debug.
Running dmd...
Building derelict-gl3 1.0.12 configuration "library", build type debug.
Running dmd...
Building gfm:opengl 2.3.15 configuration "library", build type debug.
Running dmd...
Building simpleshader2 ~master configuration "application", build type debug.
Compiling using dmd...
simpleshader.d(193,5): Error: found '}' when expecting ';' following statement
simpleshader.d(196,5): Error: found '{' when expecting ';' following statement
FAIL .dub\build\application-debug-windows-x86-dmd_2068-FC44C28BB4F2F54AFF252D359
5300845\ simpleshader2 executable
Error executing command build:
dmd failed with exit code 1.

What I'd rather like
Building logger 0.3.3 configuration "library", debug build.
Building colorize 1.0.5 configuration "library", debug build.
Building gfm:logger 2.3.15 configuration "library", debug build.
Building derelict-util 2.0.0 configuration "library", debug build.
Building derelict-sdl2 1.9.2 configuration "library", debug build.
Building gfm:sdl2 2.3.15 configuration "library",debug build.
Building gfm:math 2.3.15 configuration "library", debug build.
Building derelict-gl3 1.0.12 configuration "library", debug build.
Building gfm:opengl 2.3.15 configuration "library", debug build.
Building simpleshader2 ~master configuration "application", build type debug.
simpleshader.d(193,5): Error: found '}' when expecting ';' following statement
simpleshader.d(196,5): Error: found '{' when expecting ';' following statement
dmd failed with exit code 1.

I've removed Running dmd... because it's redundant, I know I build with DMD because I type the DUB command. It would be allright if said only once and ideally none. If I want to know what DUB really does, I will be interested in the whole command line and -v is there.
FAIL .dub\build\application-debug-windows-x86-dmd_2068-FC44C28BB4F2F54AFF252D359 5300845\ simpleshader2 executable doesn't tell me anything useful, I already have red error messages from DMD
Error executing command build I don't really care what command failed, I already see it has failed.

Do you agree with the principles? I could make a PR.

Yes, sounds fine!

Closing this now.


MongoDB dependancy

We are big users of ChatScript.
ChatScript is great but a nodejs based bot stack would be easier to scale.
ChatScript uses files to store conversations which (we think) is very convenient and easier (for us) to host than MongoDB.
Is the dependancy between SuperScript and MongoDB very strong? Would it be easy or super hard to use files instead of MongoDB?
Would it be a good or a bad idea independantly of the difficulty of doing it?

MongoDB is for Production usage to persistence data, if you have many instances, the application would read or write simultaneously, the filesystem is not a good option.
MongoDB has great advantages for SuperScript.
Robomongo come up with a GUI Tool for Mongodb management.
https://robomongo.org/

I agree that a hard dependency on a specific database is not perfect. Even though using mongodb is definitely better if you want to scale, which you mention as a reason for moving from CS to SS. In fact, one of the best ways to scale CS is to move from file-based to Mongo.
I'd imagine the best course of action would be to write a pull request with a load of tests and request for it to be merged; but I don't know if enough people would find this an issue for the maintainers to do the work themselves, if that makes sense?


20 implementation benchmarks

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.61%. Comparing base (744042a) to head (7db7b4e).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #28   +/-   ##
=======================================
  Coverage   97.61%   97.61%
=======================================
  Files          13       13
  Lines        1340     1341    +1
=======================================
+ Hits         1308     1309    +1
  Misses         32       32

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Distance and Direction - Ellipse: Can no longer create ellipses by keying in coordinates/axis length

Widget
Direction and Direction
Version of widget
06 Feb 2017
Bug or Enhancement
When I key in the Center Point coordinate, axis major and minor, and the angle an ellipse is not created. I've made sure to hit return after I enter each parameter.

Repo Steps or Enhancement details

@elinz
Sorry copy/paste error, should be fixed now, please verify

@adgiles Verified fixed. Closing issue.


Correctly get code points > U+FFFF using Array.from(str)

This fixes issue #4. Note that use of allowUnassigned was needed for the test to pass, as the Emoji characters currently seem to be in the unsupported range set.

You are right. Thanks for the PR!


Is this library suitable for WPF applications?

I really liked the potential and the easiness of using animations this library provides, however, I see the sample app is made with WinForms. Therefore, I wonder if it supports WPF as well?

I did not try it yet, but I see no problem. These transitions are basically just helper classes setting properties in a times way, with intelligent value interpolation.
As I'm writing I think that there could be a thing that could go bad with WPF: the handling of the SynchronzationContext. So I'd encourage you to just try it. Please let me know what you found.

I just checked: There is a dependency to System.Windows.Forms (net48 or netcoreapp3.1, depending on your runtime). But it is just to check if an object is disposed yet (System.Windows.Forms.Control has two properties for this: Disposing and IsDisposed). This check will just do nothing for other object types or other platforms like WPF.
If you don't mind this reference, yes - it is suitable for WPF.


Bedrock Issues

Hello,
I am contacting you guys because the bedrock inventory glitch (When trying to move items from slot to slot it glitches out and doesn't work making it impossible to craft)is still present.
This time it only affects players who play on Pockest Edition (PE). Could these issues please be fixed?
Thanks,

Are these the same issues as described in #160 ?
Does it occur only for custom items? Or vanilla items as well?
And is it solved for non-PE bedrock players?

Yes, it is the same issues. It occurs for all items, custom or not, and only affects PE players

I will try to dig up my PE account (hoping it's still valid) when I have some more time.

Thanks you so much for fixing this

I hope these are fixed in KCI 13, but I don't have pocket edition, so...


bump to v0.4.12

This will be my (@ksaur) last release as maintainer for Hummingbird, as I am moving on to a different company and job role. It has been a fantastic 5 years as maintainer for Hummingbird! Thanks to @interesaaat and @mshr-h for all of the collaborations over the years!

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.52%. Comparing base (c5186d8) to head (e73f4a7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #799   +/-   ##
=======================================
  Coverage   87.52%   87.52%
=======================================
  Files          76       76
  Lines        4625     4625
  Branches      741      741
=======================================
  Hits         4048     4048
  Misses        375      375
  Partials      202      202

Flag
Coverage Δ

unittests
87.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add anchor to all interactions by default

Reported by AlexanderPico (http://developers.pathvisio.org/ticket/1823)
A common beginner mistake is to not add anchors to interactions. Connecting the ends of interactions to nodes is very intuitive with the existing anchors. But when you drag an end over an interaction, you see nothing. If we had one anchor on each interaction by default, then this would solve most situations and teach users that interactions can have anchors too.

We'll discuss this as well for the new interaction panel #73 .


Add annotation aws-load-balancer-security-groups

This annotation was added in Kubernetes PR 62774. Implemented here

/assign @simplytunde

This doesn't look like a 1.16 feature, please clarify.

@tengqm It looks like a delayed update for an earlier PR. The relevant k/k PR merged on 1 Oct 2018, which corresponds to 1.13. Is that correct, @jorge-gasca?

@zacharysarah @tengqm Yes, this functionality was added in 1.13. It is still present in 1.16, but remains undocumented.

@jorge-gasca Thanks for the quick reply.
/lgtm
/approve


Support Apple Events and introduce CLI tool to interface with it

We initially built a whole automation backend based off of a Swift<->JSON<->Unix Sockets protocol. However, last minute before release, we decided to scrap the whole thing and instead use OSA because it is more "Mac friendly" and is also better integrated with Apple scripting.
The initial set of commands allow limited querying of VM information (mostly just the items you would see in the GUI) as well as basic start/stop/suspend operations as well as a way to get the serial port address. Future commands and capabilities can be added as needed and should be relatively straightforward.
Closes #4331

"we"


Newlines at end of source files

How do you think about to add newlines at the end of a few source files?

A cleanup pass was done to bring the code into compliance with our style guidelines. This included adding newlines at the end of source files.
See cacb1aaca3c3fea464f852177abeb82e1bbe41fb for more information.

Thanks for your source code improvement.


ci: add minimum GitHub token permissions for workflows

Description
This PR adds minimum token permissions for the GITHUB_TOKEN in GitHub Actions workflows using https://github.com/step-security/secure-workflows.
GitHub Actions workflows have a GITHUB_TOKEN with write access to multiple scopes.
Here is an example of the permissions in one of the workflows:
https://github.com/libgdx/libgdx/runs/8200695914?check_suite_focus=true#step:1:19
After this change, the scopes will be reduced to the minimum needed for the following workflows:

build-publish.yml
gradle-wrapper-validation.yml

The following workflows already have the least privileged token permission set:

build-pullrequest.yml
fix-formatting.yml

Motivation and Context

This is a security best practice, so if the GITHUB_TOKEN is compromised due to a vulnerability or compromised Action, the damage will be reduced.
GitHub recommends defining minimum GITHUB_TOKEN permissions.
https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token
The Open Source Security Foundation (OpenSSF) Scorecards also treats not setting token permissions as a high-risk issue. This change will help increase the Scorecard score for this repository.

Signed-off-by: Ashish Kurmi<EMAIL_ADDRESS>

@Tom-Ski / @Frosty-J / @PokeMMO : could you please review this PR?

I don't have big boy status here, so my approval wouldn't do much. Any changes to codeowner-protected stuff goes by slowly in this repository. I don't know if this could break anything - my philosophy would be to try it and find out.

Thanks @Frosty-J for your response! Based on my analysis, this shouldn't break anything.

Thanks @MobiDevelop for approving the PR. Is there anything else I need to do before the PR is merged?


bump mongo dep to avoid retracted version

Summary
cosign depends on mongo via github.com/go-openapi/strfmt
mongo has retracted v0.10.0 due to a possible data corruption bug (that I don't believe affects cosign in any way at all), which means folks that go get ./... from the cosign repo, or any dependent of cosign, see this scary sounding warning:
go: warning<EMAIL_ADDRESS>retracted by module author: Contains a possible data corruption bug in RewrapManyDataKey when using libmongocrypt versions less than 1.5.2.
go: to switch to the latest unretracted version, run:
	go get go.mongodb.org/mongo-driver@latest

This bumps our dep on mongo-driver using:
go get -u github.com/go-openapi/strfmt@latest

...so the warning goes away.
see also https://github.com/ko-build/ko/issues/832
Release Note
NONE
Documentation

Codecov Report

Merging #2295 (a40b983) into main (727e3e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2295   +/-   ##
=======================================
  Coverage   28.81%   28.81%
=======================================
  Files         131      131
  Lines        7941     7941
=======================================
  Hits         2288     2288
  Misses       5340     5340
  Partials      313      313

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imjasonh ping :)


Dimensioncollapse

Adds dimension collapse algo and improves tests.

FYI,  the "-march" option doesn't exist with the PPC version of GCC. That's why I removed it when building for that platform.

@saudet you're welcome to add it back. I reverted to the last known good version of cmake that built ;/

Ok, but it doesn't build on some machines because of IF(${CMAKE_SYSTEM_PROCESSOR} MATCHES "ppc64*")?

Maybe? It wasn't generating binaries.


File option pretty slow

Testing the new version with an 1280x720 video and yolov3-tiny. Getting just 6-7 FPS with my jetson nano (just running odc, nothing else). Is there an option to stream the file with gstreamer / doing downscaling for analysis?
Thanks in advance!

Hi,
Not normal, you should get 16 FPS with jetson nano.
The file input resolution doesn't matter, it is then downscaled by YOLO at 416x416.
Could you tell me this:

Are you using the docker container ?
Which version of Jetpack are you using, because with the latest 4.4 developer preview and cuDNN 8.0 there is a bug and you loose 10 FPS : https://forums.developer.nvidia.com/t/darknet-slower-using-jetpack-4-4-cudnn-8-0-0-cuda-10-2-than-jetpack-4-3-cudnn-7-6-3-cuda-10-0/121579

Thanks, I didn't know about the 4.4 bug. Let me try to go back to 4.3 and see if it's fixed.

Yes it should fix it, I had the same bug a week ago.
I was wondering if you were running OpenDataCam with the docker container ? Because maybe it only effects the installs without docker

I compiled it without docker, and I'm running it since a few month already with yolov3 (ca 3-4 fps, which was fine for my purpose) but changing to the tiny model didn't result as expected.

Okay ! I think if you run the docker container with Jetpack 4.4 it should work as the docker image has the correct version of cuDNN.. I was curious as I didn't test myself before flashing back to 4.3. Anyways, let me know and feel free to close the issue if it is fixed.
Also if you have a nice use case you are using OpenDataCam for and you are willing to share, we are looking to feature some usage of it for v3.0.0 release.

I'm using odc to monitor CCTV cameras. Have it running on a Google Cloud VM and on the Jetson Nano. I'll try to get it working fine with Jetpack 4.4.

Didn't have success with Jetpack 4.4. It's 10 FPS slower than with Jetpack 4.3. Hope NVIDIA will fix this.
What about the Deepstream SDK? The confidence problem should be solved in the most recent version. Is it possible to run ODC on Deepstream 5.0? I know about https://github.com/opendatacam/opendatacam-deepstream but can't get it working.

Didn't have success with Jetpack 4.4. It's 10 FPS slower than with Jetpack 4.3. Hope NVIDIA will fix this.

Yes, but they successfully reproduced it and are looking into it: https://forums.developer.nvidia.com/t/darknet-slower-using-jetpack-4-4-cudnn-8-0-0-cuda-10-2-than-jetpack-4-3-cudnn-7-6-3-cuda-10-0/121579/8  .. So they will fix it at some point ;-)
BTW, did you try to run OpenDataCam as a docker container while on Jetpack 4.4 ? Because this should work as the docker container is pulling the Jetpack 4.3 dependencies

What about the Deepstream SDK? The confidence problem should be solved in the most recent version. Is it possible to run ODC on Deepstream 5.0? I know about https://github.com/opendatacam/opendatacam-deepstream but can't get it working.

We didn't investigate Deepstream 5.0 as is is just releasing now.. not sure if even the documentation is out yet... but we keep deepstream in our radar and you can follow progress here: https://github.com/opendatacam/opendatacam/issues/112 .. And also contribute ;-)


HASTAC user registration broken

When trying to register hctester90 as a new HASTAC and HC user I receive an internal error on clicking the email verification link. This is replicable and happens in every browser.

This issue is fixed.


Singel object extraction

Feature request
Currently, the extraction chain only supports the extraction of an Array of object.
For example
from typing import Optional

from langchain.chains import create_extraction_chain_pydantic
from langchain.pydantic_v1 import BaseModel

# Pydantic data class
class Properties(BaseModel):
    person_name: str
    person_height: int
    person_hair_color: str
    dog_breed: Optional[str]
    dog_name: Optional[str]

# Extraction
chain = create_extraction_chain_pydantic(pydantic_schema=Properties, llm=llm)

# Run
inp = """Alex is 5 feet tall. Claudia is 1 feet taller Alex and jumps higher than him. Claudia is a brunette and Alex is blonde."""

chain.run(inp)
# Results in
#
#  [Properties(person_name='Alex', person_height=5, person_hair_color='blonde', dog_breed=None, dog_name=None),
#  Properties(person_name='Claudia', person_height=6, person_hair_color='brunette', dog_breed=None, dog_name=None)]
#

There is currently no option available to just get one Properties object.
It would be nice if you could define at the beginning if you are interested in one object or an array of objects
For example
chain = create_extraction_chain_pydantic(pydantic_schema=List[Properties], llm=llm) -> Array of Properties
chain = create_extraction_chain_pydantic(pydantic_schema=Properties] llm=llm) -> Just one Propertie

Motivation
It would just make life easier when you knew that you were only dealing with one object.
It might also improve the response and prevent wrong or incomplete responses.
Your contribution
I would create and submit a PR that contains this feature.

We've updated the extraction use case docs now: https://python.langchain.com/docs/use_cases/extraction


Added Segment Tree

A segment tree is a data structure used to store information about array segments and answer segment queries efficiently. There are two main operations performed on a segment tree: range(i, j): gives the sum of the array elements starting at index i and ending at index j.

Please star this repository to show your support, in the meantime I am reviewing your code.

Yeah sure I have starred the  repository waiting for your review


Regarding Pointer Locks

Hi, thanks for the library. Indeed a great educational tool.
My knowledge of C++ is limited and Im only starting to learn about threads (Through this repo as well). My question is,

Is there an example  in which multithreading is used for training the NN?
What would be the consequences if I were to remove anything to do threading and instead use normal raw/smart pointers?

Thanks

Hi,
If you want to use the repo without threads you need to perform a topological sort of the computational graph and then solve each node in order, right now it uses conditional variables to wait for the input of each node to become available, locking ptrs prevent race condition for the data referenced by them when using threading


Document model_params and add examples to output_header_fields and output_variables

Document model_params and add examples to output_header_fields and output_variables in https://github.com/NOAA-OWP/ngen/blob/master/doc/BMI_MODELS.md
Current behavior
Items 2 and 3 above are documented but an example would be helpful. No examples found in code. Item 1 is not documented and needs to be added (see PR #368 and Bmi_C_Formulation_Test.cpp line 210).
Expected behavior
An example should be provided for output_variables and output_header_fields at least similar to the one given for variables_names_map. Preferably, adding these to some multi-bmi realization file as an example would be helpful if it doesn't break any tests (it probably wouldn't). The scenario to be demonstrated is how to obtain multiple output variables from a combination of modules in a multi-BMI formulation.
Also, documentation should stipulate that output_variables and output_header_fields should (must?) be specified at the top level of a formulation rather than the module-level configs in a multi-BMI config.
Similarly, model_params must be specified on the module config instead of the top-level formulation config, and this should be specified.
Consider adding an applicability table similar to the one under the Required Parameters section for the optional parameters--though this would specify where they were allowed rather than where they were required.
Steps to replicate behavior (include URLs)

Screenshots

Adding mention of #588 to this, since the undocumented thing has changed since this issue was created.


Added function to find lr using a generator as input

Added find_generator to search the LR when the input is provided by a generator.

Thank you, @acere


Fullscreen not working on Android (4.2.2) stock browser

When I tap the fullscreen button nothing happens.
The HTML5 fullscreen demo at http://www.jwplayer.com/html5/fullscreen/ works because webkitEnterFullscreen() works so it should be possible right?

+1 on Chrome for Android and Chrome Destkop up-to-date

Ooops, seems that the new version of Chrome broke the fullscreen API.
This is a blocking issue for me, I will fix this in 1.0.0.

My tests about this issue:
Chrome for Mac OS X 10.9.5 - OK
Chrome for Ubuntu - KO
Chrome for Android 4.3 - KO
Firefox for Mac OS X 10.9.5 - KO
iPad Mini iOS 8.1.2 - OK

Fixed in 1.0.0