 Ternary operators

Currently, go doesn't support ternary operators. As far as I know, the main argument against it is "People will misuse it, so it will be harder to read code". I don't think this will happen, here's why:
Most developers write their code with the default code conventions. Sometimes they change small things like the tab size or a newline before a {, but overall, it's the same. So who is misusing them? New developers do so. People who started developing are doing many crazy things in their code, but their is one thing most new developers don't do, especially if it's their first language: They don't contribute much to the community, until they are good enough. And if they are, they'll know code conventions.
Take a look at java. How often have you seen java code which is unreadable, because people use ternary operators? I'm developing java since years and I never had this problem when reading code on github, stackoverflow or somewhere else.
I think, ternary operators would make code smaller, while it's still good to read. Here are some examples how they could look like and why they are useful.
Example one
Without:
var test string
testMap, err := getMap()

if err != nil {
    test = testMap["test"]
} else {
    test = "..."
}

With them (parenthesis are optional, but this looks better with them):
testMap, err := getMap()
test := (err == nil ? testMap["test"] : "...")

They could also be made without a "else". Such a feature was also requested here. Example:
testMap, err := getMap()
test := (err == nil ? testMap["test"])

Example two
Without:
func abs(a int) int {
if a >= 0 {
    return a
}

return -a
}

With:
func abs(a int) int {
    return a >= 0 ? a : -a
}```

Tell me what you think about it in the answers. 👍

This was rejected previously https://github.com/golang/go/issues/20774

@adamdecaf Half of my request is about this argument, so why not trying it again?^^

The argument has been had many times over.

"Code will be shorter" is not a convincing argument – we do not care about turning 4 lines into 1. The current way reads just fine.

Part of Go's design is to be easy to learn for newcomers, so "only newcomers abuse ternary operators" is not an argument in your favour, even if it were true – which it isn't. The cleverer someone thinks they are, the more complex their use of ternary operators will be. This is very evident in the C and C++ communities.

I am going to close this issue as the decision has been made a long time ago and no new arguments have been presented.

@dominikh
"Code will be shorter" was maybe the wrong way to call it. I think in all examples I made "Code will be less complex" would match better.
So, why did this happen in the C(++), but not in the Java community? Also most ternary abuse could be prevented by limiting them to one line.
I think it's a very bad argument to forbid something, because it could be misused. Or would you ssay: "Let's forbid knifes, because they can be misused"? You shouldn't think about those few people who are missing using it, think about people who'll use it correctly to make code better.

Duplicate of #20774 (for github tracking).
Maybe it's worth having an entry in the https://golang.org/doc/faq as to why this is not supported. Even if I agree that sometimes a single line ternary, with a single ternary in it, I choose consistency over it.

Go developers should really care more about the "developing" part, instead of the "reading others code" part. :/

@sinnlosername we really "should" refrain from using the word "should" here.  This is not a forum for telling people how to think or work.
Ternary operators are syntactic sugar that obfuscates code.  They are not needed.  It's that simple.

I think go developers should really care more about the "developing" part, instead of the "reading others code" part. :/

@sinnlosername, when "programming in the large" (large code bases with large teams over long periods of time), code is read WAY more often than it's written, so we optimize for readability, not writability.


⚠ Turnos 24x7 has degraded performance

In c2f12e8, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 3958 ms

Resolved: Turnos 24x7 performance has improved in 2e569c5.


Fix: Unwanted bouncing when opening or closing the on-screen keyboard on ScrollableSheet

Related issues (optional)
Fixes #245.
Summary (check all that apply)

[x] Modified / added code
[x] Modified / added tests
[ ] Modified / added examples
[ ] Modified / added others (pubspec.yaml, workflows, etc...)
[ ] Updated README
[ ] Contains breaking changes

[ ] Created / updated migration guide

[ ] Incremented version number

[ ] Updated CHANGELOG

I just updated to 0.10.0 and this issue is still there and very pronounced


unify DelayUs and DelayMs to DelayUs for v1.0

Implements a unified DelayUs using u32 only for v1.0 of embedded-hal to prevent confusion.
Keeps Delay open for future, better abstractions.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eldruin (or someone else) soon.
Please see the contribution instructions for more information.

Context:
We discussed this in today's WG meeting and removing DelayMs in favor of DelayUs seemed like an acceptable compromise. The goal being coming up with an unified Delay trait once we figure out constraints for its type Time: ???.
@therealprof also agreed to this.
Do you have any objections @ryankurte ?

damnit almindor you beat me (my fault for not looking first :facepalm: )
here's the summary I wrote:

Quick summary of discussions in #177 and in today's REWG meeting:

We need a hardawre-agnostic, efficient way of representing time durations for use in the e-h traits, but that's probably far away.
The current DelayMs/DelayUs traits are not the answer, they require duplicating impls for each unit and each integer size.
There's issues where HALs don't implement all DelayMs/DelayUs combinations, causing some drivers to not work with them.
However, "blocking delay" is an incredibly important and widely used trait, releasing 1.0 without it is not an option.

The compromise found to unblock 1.0 while mitigating the issues is:

remove DelayMs
change DelayUs to use u32 instead of generic width integers.

Why:

Fixes the pain of HALs not implementing all combinations.
For the most common use cases (blinks, waiting for chips to initialize...) microsecond precision is enough.
u32 allows for a max delay of ~1.2h. Such blocking delays should be extremely rare, as the core can do absolutely nothing else during it (unless it uses interrupts, but then you're probably already doing interrupt-based timers).
The runtime cost of forcing using 32bit is negligible, most HALs are already doing 32bit math on the duration to convert it to clock ticks.

The name Delay is reserved for the future trait that will use the new shiny Duration representation, hence DelayUs is kept even though there's only one trait.
When the final Delay trait is released, we may (or may not if we still think it's handy) deprecate DelayUs.

I'm somewhat against the situation where we have only DelayUs trait because it gives wrong feeling of having a precise enough microsecond delay. While we have no guarantees on upper bound of actual delay for a given requested delay, it's a good idea to avoid situations when a delay implementation works type-system-wise, but doesn't work in runtime.

I'm somewhat against the situation where we have only DelayUs trait because it gives wrong feeling of having a precise enough microsecond delay. While we have no guarantees on upper bound of actual delay for a given requested delay, it's a good idea to avoid situations when a delay implementation works type-system-wise, but doesn't work in runtime.

The main problem with two traits is that if a HAL doesn't implement one of them it blocks Drivers that use the other one from being used. The idea here is to avoid such cul-de-sacs.
A proper solution is to introduce a new Time type and figure out all the nuances of delays and then introduce Delay as a trait that uses it, but that won't happen before v1.0 is out.

Perhaps the docs should specify "delays for at least X us, but may delay for longer, if for example the implementation doesn't have enough precision"?
Delaying for shorter could break drivers that need to wait for at least X us for some chip to do some operation, delaying for longer usually doesn't.
This would require HALs to round up instead of down if there's not enough precision, and warn driver authors to not rely on it for extremely precise timing.

Perhaps the docs should specify "delays for at least X us, but may delay for longer, if for example the implementation doesn't have enough precision"?
Delaying for shorter could break drivers that need to wait for at least X us for some chip to do some operation, delaying for longer usually doesn't.
This would require HALs to round up instead of down if there's not enough precision, and warn driver authors to not rely on it for extremely precise timing.

I like this approach, @Disasm what do you think?

Yes, this is one of the solutions. I still don't understand why it's better than the "best effort" solution when the provided delay tries to work with a good precision. We can't guarantee this precision of course, but type system provides a way to define it at least on some level by defining two separate traits, and this PR removes the difference between old DelayMs and DelayUs. Imagine that we have a Pin trait instead of all the other pin traits which sometimes doesn't work as expected. Driver wants to use it as output, but if user configured it as input, it will not work. Same here: if the user took a bad delay source, it will not work in a situations when you need a microsecond delay. If you need to toggle GPIO fast enough, but with a tiny delay, you would use delay_us for this, but if this delay gives you 2+ms delay each time, you will not get what you expect.

Yes, this is one of the solutions. I still don't understand why it's better than the "best effort" solution when the provided delay tries to work with a good precision. We can't guarantee this precision of course, but type system provides a way to define it at least on some level by defining two separate traits, and this PR removes the difference between old DelayMs and DelayUs. Imagine that we have a Pin trait instead of all the other pin traits which sometimes doesn't work as expected. Driver wants to use it as output, but if user configured it as input, it will not work. Same here: if the user took a bad delay source, it will not work in a situations when you need a microsecond delay. If you need to toggle GPIO fast enough, but with a tiny delay, you would use delay_us for this, but if this delay gives you 2+ms delay each time, you will not get what you expect.

The problem is that if the HAL decides to implement only one for whatever reason, it locks out many drivers that might expect the other. This happened on the e310x-hal which we then implemented with precision that only goes down to ~30us anyhow, so the two trait system didn't really prevent precision issues.
I don't think we can prevent precision issues/force proper precision on implementors until we have a better type around the delays defined.

Well, that's how traits work. If your implementation has some functionality, it implements a trait, otherwise it doesn't. If the delay from e310x-hal doesn't implement DelayUs, it's only because it's a bad delay and we need a better delay instead of making a fake DelayUs implementation for the bad one.

Many places where you need a delay are fine with "delay for at least X" and don't break if the delay is longer than requested. Stuff like "after deasserting RST wait for at least 500us before sending commands". I'd argue this is the majority of DelayMs/DelayUs uses today.
For use cases that do break when the impl delays for longer, DelayMs/DelayUs isn't a good choice anyway. The code can be preempted and arbitrarily delayed anyway by interrupts, it should be interrupt-driven, not blocking.
The advantage of documenting that DelayUs does "delay for at least X" is that it solves the compatibility problem: all HALs will be capable of implementing it, so drivers using it will work everywhere. The disadvantage is the "precision delay" use case is left unsolved, but we can address that with the "fancy" Duration trait we'll add in the future.

Do you have any objections @ryankurte ?

this all seems pretty reasonable to me. we do need a basic delay function like this for constructing drivers (and i suspect this is the majority of existing uses), i certainly wouldn't want it removed without an equivalent replacement.

Many places where you need a delay are fine with "delay for at least X" and don't break if the delay is longer than requested.

at least with linux users, subject to the whims of the scheduler, this is already the case. documenting it as "delay for at least X" sounds great. this trait is never going to do a great job for bit-bashing, that said, if you need more accuracy you can switch to a delay implementation able to provide it, we're just not guaranteeing it at the abstract HAL level.

Extended comments to include at minimum for requirements on pausing.

would it make sense to also return the value actually used? E.g. turn it into Result<u32, Self::Error> so that in case the implementation needed to block longer the user can know the approximation of how much?

My first thought is that measuring that accurately could add a lot of complexity to HAL impls, and I don't think many use cases would benefit from finding out (i.e. they'd probably just ignore the number, as usually there's nothing to be done about it if the delay was longer than expected after it's already happened). Maybe it would be a neat feature to add to a future Delay trait as an option?

Some last-minute bikeshedding :sweat_smile:
If the trait has methods delay_ms, delay_us perhaps DelayUs is not the best name?
Delay would make more sense, but we want to keep that for the trait using the future "Duration" abstraction. Maybe SimpleDelay, BasicDelay?

If the trait has methods delay_ms, delay_us perhaps DelayUs is not the best name?

Even though it sounds a bit weird, but DelayUs is the precision and delay_ms / delay_us is the actual delay duration, so I think we should keep these names and probably make it more clear in the documentation?

The 'precision' of the impl can be whatever, there'll probably be impls using a 32khz low-frequency clock or whatever.
It was just a random thought anyway, wanted to share to see what other people think. I'm OK with DelayUs too.

The 'precision' of the impl can be whatever, there'll probably be impls using a 32khz low-frequency clock or whatever.
It was just a random thought anyway, wanted to share to see what other people think. I'm OK with DelayUs too.

It's DelayUs to keep same name as before, for familiarity and because we decided Delay is reserved for the "proper" abstraction. I could name it something else but then it'd be even more confusing IMO.


Enhancement Request: AzureCandidateHarvester?

It looks like Azure has the necessary API endpoints for grabbing NAT details: https://docs.microsoft.com/en-us/azure/virtual-machines/windows/instance-metadata-service#the-following-network-categories-are-available-through-the-instance-api
Would it be possible to add something like: https://github.com/jitsi/ice4j/blob/master/src/main/java/org/ice4j/ice/harvest/AwsCandidateHarvester.java for Azure?

If someone could provide some contribution info or suggest how to get started with this I'd be glad to look in to it and maybe open a PR.

Note that you can acheive the same result with StunMappingCandidateHarvester

Thanks!


bug: Delete unused flag coming from imgpkg

Pull request

What this PR does / why we need it
Hide azure-container-registry-config, that comes from imgpkg library and it's not used in apps plugin
Which issue(s) this PR fixes

Fixes #171
Describe testing done for PR

Built in local cluster to check flag is not printed in help message.

Additional information or special notes for your reviewer

Signed-off-by: Wendy Arango<EMAIL_ADDRESS>Co-authored-by: Shash Reddy<EMAIL_ADDRESS>

Flag is not in help text under Global Flags anymore


Port is already occupied when connecting to ElasticSearch

I want to monitor jvm health of Elasticsearch 6x with the help of jolokia java jvm agent 1.5.0. For taking all metrics from Jolokia I use Metricbeat-6.2.3 and then will put all of them to Elasticsearch. Everything is installed on Centos system.
according to this instruction https://jolokia.org/reference/html/agents.html#jvm-agent I do such command:
su -c "java -jar /tmp/jolokia-jvm-1.5.0-agent.jar --verbose --debug --port=10000 toggle org.elasticsearch.bootstrap.Elasticsearch" -s /bin/bash elasticsearch
and get such notification
Couldn't start agent for process matching "org.elasticsearch.bootstrap.Elasticsearch" (PID: 5166)
Possible reason could be that port '10000' is already occupied.
Please check the standard output of the target process for a detailed error message.
And there is no effect when I change a port - still the same problem.
When I try to connect to Tomcat everythings works fine and I get successful response on http://<IP_ADDRESS>:8778/jolokia/
What can be the problem of connection to Elastic?

One which UID is your elasticsearch process running ? You need to attach Jolokia with the very same UID. root is not good enough.
Actually, it would be much better to configure elasticsearch to start with the jolokia agent from the very beginning, by modifying the startup scripts.


bump ffi-yajl dep

same change as chef and ohai, same rationale for not bumping the
lower bound to 2.0

@danielsdeleo same change here.
@chef/client-core  @chef/client-engineers as well.

:shipit: :+1:


[BUG] Command send-from does not exist

Not working
silicoin wallet send-from -s
Command send-from does not exist

Try "sit wallet send-from" instead of "silicoin wallet send-from"
For me, it seems to work.


HTTP 400 Bad Request, {"captcha_key": ["captcha-required"]}

I don't know if in the past two days this has come up or something but I got this message trying to run it today,
error creating Discord session, Unable to fetch discord authentication token. HTTP 400 Bad Request, {"captcha_key": ["captcha-required"]}
I'm not sure if discord has required a captcha in the past or if this is new.

never mind, issue is resolved by first logging into the discord account, the issue must have come up because I am on a new network.

Oh dude, i have the same trouble :(

Oh dude, i have the same trouble :(

Use the token method
Join the unofficial support server for help
https://discord.gg/d8MYEC6


Fix OnyxButton alignment

The HTML button behaves differently than the OnyxButton:

 has display: inline-block
 has display: flex

We could align it by using inline-flex.
Open Questions/To-dos

[ ] Was it intentional to not make it inline?

Why?
The HTML button behaves differently than the OnyxButton.
Acceptance criteria

The button is inline aligned.

Definition of Done

[ ] examples updated in alpha-test-app
[ ] updated version + documentation is deployed
[ ] Set task to In Approval

Approval

add link to deployed storybook
add link to deployed docs
[ ] approved by designer @jannick-ux
[ ] approved by dev add dev tag

Implementation details

use inline-flex

Maybe noteworthy:
https://stackoverflow.com/questions/27418104/whats-the-difference-between-displayinline-flex-and-displayflex


Stop pinning pythreejs

Currently we pin pythreejs to 2.3.0 to get the tests working.

PR that pinned the version https://github.com/microsoft/vscode-jupyter/pull/11182

Fixed https://github.com/microsoft/vscode-jupyter/pull/11192


Add Virginia's Community Colleges

@thomasb9511 I am sorry, the domain vccs.edu is blacklisted because the school allows to register an email address there even if you are not a student of the school. If you are the student of this school, please apply with official document (OFFICIAL DOCUMENT tab at https://www.jetbrains.com/shop/eform/students).


Fix for Saving Flex Pages on Windows

This fixes an issue with Flex Pages on Windows where dirname returns backslashes and prevents the page from being saved.

I made a better fix in https://github.com/getgrav/grav/commit/608457bd010e6df853451f7ecf48da72bb2868b8, thank you for pointing me out the weird behaviour of dirname() method.


Set up CI/CD?

This is going to take some research. Some tests may need to be changed as well (or at least the "chain" of things that are run - nasm and gcc specifically.)

This is never going to happen.


make wrong

ERROR: OTP release R17 or later is required, you have: R16B02-basho5
ERROR: compile failed while processing /emqtt_benchmark-0.2/deps/goldrush: rebar_abort
make: *** [compile] Error 1
how to do with this reason

Please Upgraded version of Erlang!


LSC Prototype: Content type / colorization in interactive window

In InteractiveWindowProvider, this is currently commented out:
replWindow.SetLanguage(GuidList.guidPythonLanguageServiceGuid, contentType);

Not sure what we'll have to pass for the guid.

Got this working again today.


Repair CBMC proof patches, MakefileCommon.json to build CBMC proofs.

This patch modifies the CBMC build process so that the CBMC proofs mostly build.
But proofs still fail and will need to be debugged.  In particular, function signatures have changed, so the function abstraction done for prvCheckOptions (CheckOptions, CheckOptionsInner, CheckOptionsOuter) and prvParseDNSReply (ParseDNSReply, SkipNameField, ReadNameField) will need to be reworked. Roughly 3 other proofs continue to fail for reasons not yet debugged.
I'm submitting this patch just so others can benefit from the repaired patch files.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing in favor of https://github.com/htibosch/amazon-freertos/pull/9


DBZ-2514 Update release & documentation for Cassandra

https://issues.redhat.com/browse/DBZ-2514

[x] Release pipeline
[x] Documentation
[ ] Debezium BOM version references

@jpechane I need a bit of guidance on whether we intend to explicitly list Cassandra 4 in the BOM or do we intend to just continue to reference only Cassandra 3 there for now?

@Naros, all the versions should be managed in the BOM. I.e. let's do the same for 3.x what we do for 4.x. An exception may be needed if there's conflicts between transitive dependencies of the two.

Added sibling PR https://github.com/debezium/debezium-connector-cassandra/pull/50

@gunnarmorling Since the BOM would reference the same dependency with only version differences, this creates a coordinate conflict in the BOM.  For now, I'm leaving those as the oldest which would be based on version.cassandra3 for now unless either you or @jpechane have a suggestion to handle this differently.


This would make a great blog post!

As we near publication of our two "quick guides" we need to craft a blog to be published via an OSSF blog for the following gdocs:
One page guide for developing secure software - https://docs.google.com/document/d/16jUqTEFG-wscZUGR-NGa_3a81GF3YILtH9XgOSkLCTM/edit#
Concise Guide for evaluating OSS - https://docs.google.com/document/d/19015o63pA-sZPBN5-R7I7Cg8ICPxo6fXH8vOI1RgBYM/edit#

@SecurityCRob I can start a draft of blog post and then send it out later on a Google Docs link to mailing list if you'd like.

Please!!
Cheers,
CRob
Director of Security Communications
Intel Product Assurance and Security
From: Randall @.>
Sent: Wednesday, August 17, 2022 11:14 AM
To: ossf/wg-best-practices-os-developers @.>
Cc: Robinson, Christopher @.>; Mention @.>
Subject: Re: [ossf/wg-best-practices-os-developers] This would make a great blog post! (Issue #71)
@SecurityCRobhttps://github.com/SecurityCRob I can start a draft of blog post and then send it out later on a Google Docs link to mailing list if you'd like.
—
Reply to this email directly, view it on GitHubhttps://github.com/ossf/wg-best-practices-os-developers/issues/71#issuecomment-1218145713, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQRFDLBZ25MWAGXCKTK6IRDVZT6TFANCNFSM56WCEEJQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

FYI, they are now the "concise" guides (due to a title rename).
More importantly, the Google docs versions are now obsolete. We've now converted them to markdown on GitHub, so we can carefully control future changes. Google docs is great for quick group edits, but we're now past that point.
The final-draft markdown versions are here:

"Concise Guide for Developing More Secure Software"
"Concise Guide for Evaluating Open Source Software"

This was completed: https://openssf.org/blog/2022/09/13/introducing-new-concise-guides-for-developing-more-secure-software-and-evaluating-open-source-software/


Link to bios mod not working

Hey Steven,
Thank you for the guide. I am planning to install hackintosh in my system using your guide.
But the link for the bios file doesn't seem to be working. And I couldn't find another one when I googled it. Could you re-upload it.
Thanks,

U can patch the AppleIntelBDWFrameBuffer with clover. FYI

@bishwos Sorry, I didn't see this issue until just now! I've been meaning to revisit this guide, especially the parts related to the BIOS mod. I'll take a look and see if I can find the necessary files you will need to patch your own firmware image (as the raw dump contains MAC addresses and your Windows key).
@polarlights That option does exist, and it's certainly worth a try, but I tried several variations of Clover patches and none worked for me.

@stevenmirabito  Yeah, it didn't work for me when I installed the 10.12. But after I installed it, it worked. I don't know why. Maybe I have some typo errors.  I used to replace the content of the framer, repair the permissions.
However I replaced the default the wireless card with the bcm94352z by modifying the BIOS mod, It works well. But the bluetooth doesn't work well, although it works great in 10.11.

@stevenmirabito I have the raw bin dump for the BIOS but I cannot find the offset or areas that do need patching to unlock the advanced menu. Do you have those details or are you planning to add them (considering this issue is about 4 years old)?

@stevenmirabito @bhagatparwinder if either of you have an umodded bios, that would already help. (my nvram got messed up when installing) I have the FL1 file from the lenovo update but it's smaller but seemingly not compressed so according to some online comments, I would have to copy the good parts over my backup of the bios backup to end up with a flashable file.

Update: fixed it by flashing a full bios region from an almost identical machine.


Fix Maps

For https://github.com/theodi/shared/issues/593
I've also done some mini tweaks to the styling to make the pages look a bit better, I don't think they've been touched during the redesign

Oh, shit, the lat long changed. Was that the big thing? Doh.

That was one of the things. Openspace also only had the bare domain listed as a referrer, so I dunno how this ever worked :/


Async finding import bug

Bug description
Hi!
Some reports are imported with an error if the parser parses the dates from the report. This issue occurs only if async finding import is enabled (DD_ASYNC_FINDING_IMPORT=true) and the report parser supports date parsing.  I have tested with nuclei and detect_secret reports.
Error message in UI:
An exception error occurred during the report import:['“2021-05-19T10:40:18Z” value has an invalid date format. It must be in YYYY-MM-DD format.']: (dojo.finding:pk=2308) field_value was '2021-05-19T10:40:18Z'

Exceptions in logs:
defectdojo-uwsgi-1         | [31/Jul/2023 14:38:30] ERROR [dojo.engagement.views:703] ['“2021-05-19T10:40:18Z” value has an invalid date format. It must be in YYYY-MM-DD format.']: (dojo.finding:pk=2304) field_value was '2021-05-19T10:40:18Z'
defectdojo-uwsgi-1         | Traceback (most recent call last):
defectdojo-uwsgi-1         |   File "/usr/local/lib/python3.11/site-packages/django/core/serializers/python.py", line 167, in Deserializer
defectdojo-uwsgi-1         |     data[field.name] = field.to_python(field_value)
defectdojo-uwsgi-1         |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
defectdojo-uwsgi-1         |   File "/usr/local/lib/python3.11/site-packages/django/db/models/fields/__init__.py", line 1399, in to_python
defectdojo-uwsgi-1         |     raise exceptions.ValidationError(
defectdojo-uwsgi-1         | django.core.exceptions.ValidationError: ['“2021-05-19T10:40:18Z” value has an invalid date format. It must be in YYYY-MM-DD format.']
defectdojo-uwsgi-1         |
defectdojo-uwsgi-1         | During handling of the above exception, another exception occurred:
defectdojo-uwsgi-1         |
defectdojo-uwsgi-1         | Traceback (most recent call last):
defectdojo-uwsgi-1         |   File "/app/dojo/engagement/views.py", line 687, in import_scan_results
defectdojo-uwsgi-1         |     test, finding_count, closed_finding_count, _ = importer.import_scan(scan, scan_type, engagement, user, environment, active=active, verified=verified, tags=tags,
defectdojo-uwsgi-1         |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
defectdojo-uwsgi-1         |   File "/app/dojo/importers/importer/importer.py", line 333, in import_scan
defectdojo-uwsgi-1         |     new_findings += [next(serializers.deserialize("json", finding)).object for finding in serial_new_findings]
defectdojo-uwsgi-1         |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
defectdojo-uwsgi-1         |   File "/app/dojo/importers/importer/importer.py", line 333, in <listcomp>
defectdojo-uwsgi-1         |     new_findings += [next(serializers.deserialize("json", finding)).object for finding in serial_new_findings]
defectdojo-uwsgi-1         |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
defectdojo-uwsgi-1         |   File "/usr/local/lib/python3.11/site-packages/tagulous/serializers/base.py", line 51, in wrapper
defectdojo-uwsgi-1         |     for obj in obj_generator:
defectdojo-uwsgi-1         |   File "/usr/local/lib/python3.11/site-packages/django/core/serializers/json.py", line 70, in Deserializer
defectdojo-uwsgi-1         |     yield from PythonDeserializer(objects, **options)
defectdojo-uwsgi-1         |   File "/usr/local/lib/python3.11/site-packages/django/core/serializers/python.py", line 169, in Deserializer
defectdojo-uwsgi-1         |     raise base.DeserializationError.WithData(
defectdojo-uwsgi-1         | django.core.serializers.base.DeserializationError: ['“2021-05-19T10:40:18Z” value has an invalid date format. It must be in YYYY-MM-DD format.']: (dojo.finding:pk=2304) field_value was '2021-05-19T10:40:18Z'

However, in the end the report is imported.
If DD_ASYNC_FINDING_IMPORT is 'false' no error occurs.
Steps to reproduce
Steps to reproduce the behavior:

Set DD_ASYNC_FINDING_IMPORT to 'true'
Start up dojo
Try to import detect_secrets or nuclei report, for example https://github.com/DefectDojo/django-DefectDojo/blob/master/unittests/scans/detect_secrets/many_findings.json
See error

Expected behavior
Successful import without errors.
Deployment method (select with an X)

[X] Docker Compose
[ ] Kubernetes
[ ] GoDojo

Environment information

Operating System: Ubuntu 20.04
DefectDojo version v. 2.24.3

I could be wrong here but I'm pretty sure the async finding import was an experimental feature and should really only be used if you're having performance issues that cannot be addressed by any other means - consider turning it on as a hail mary.
If you're running on insufficient resources turning on that feature won't really make a difference.
Are you getting the same or similar errors when async is off?

Yes, I know that asynchronous imports are experimental. But I've been using this feature for over a year and had no problems before. However, this feature helps us solve problems with importing reports with a large number of findings. I don't know how we can import such reports in another way.
As I wrote this problem occurs only if asynchronous import is used. I found this exception source here, but I'm not familiar enough with django and dojo to offer a fix.


Can't try/catch pa.connect()

pa.connect() cannot be caught in a try/catch in case a pulseaudio server is not online

I have no clue what you mean by that. Clearly, any JavaScript function can be enclosed in a try-catch statement.

I'm trying to make a while loop and retry connecting to a pulseaudio server until it's online. Putting pa.connect() in a try block always crashes the whole app which is pretty unusual.
Does it work for you?

What does "crashes the whole app which is pretty unusual" mean?

I'm using a node image in docker

Please open new issues for specific problems in the pulseaudio.js library. I cannot help with generic JavaScript issues.


Navbar , contact and testimonital

@tushargupta1504  I seen your design very carefully and noticed very irregular designing , the navbar transition , the testimonial is not looking very much user friendly and as well as the contact form should be in the mid with proper margin and padding ,
Please assign these issues to me i will make sure to make your landing page look good as much as possible

hii @tushargupta1504  i believe i can do this task efficiently as i have a strong hold over css styling. could you please assign me this task under GSSoC24 extd and hactoberfest24.


Fix recipe headers to state it's Apache licensed, as per LICENSE.

sorry, heinsight, it's better to standardise the Limited to Ltd to match the inviqa.com website. I've heard companies shouldn't be inconsistent between them, tho all of one or the other is ok


[Whisper] Load customized MLX model & Quantization

Hi @awni 👋,
This PR introduces a feature to load customized MLX whisper models and integrates a conversion script for transforming the PyTorch checkpoint of OpenAI format into MLX. I believe this will be helpful for the community to easily convert and load other whisper models fine-tuned for low-resource languages in MLX.
Additionally, I've incorporated quantization into both the model conversion and loading processes.
It's working on my side, but might need additional review for modifications, doc, or testing. Thanks in advance!

Wow that's all awesome!! Thanks for adding! Will review soon!

Thanks for the review! Unfortunately, I didn't see any speed improvement from tests run on my M1 Mac. In fact, it's a bit slower. The benefit comes from memory usage. I'm not entirely sure what happened here, but I'm looking into it.
Feature time 0.037

Model: MODELS/LARGE
Model forward time 1.197
Decode time 2.569
Everything time 3.634

--------------------------------------------------

Feature time 0.036

Model: MODELS/LARGE_QUANTIZED_8BITS
Model forward time 1.506
Decode time 2.965
Everything time 4.285

--------------------------------------------------

Feature time 0.036

Model: MODELS/LARGE_QUANTIZED_4BITS
Model forward time 1.536
Decode time 2.913
Everything time 4.262

@awni just finished and updated the test and benchmark to align with the change. thanks for the review!


Remove dependency on RLEv1 and v2 from IntDecoder and IntEncoder

IntDecoder will be moved to dwio::common, but its member functions createRle and createDirect need to reference RLEv1 and RLEv2. This PR moves the decoder creation from IntDecoder to the new DecoderUtil.h to prepare for the upcoming moves. In addition, the encoder creation from IntEncoder was moved out to EncoderUtil.h to keep the encoder creation in the same manner..

@HuamengJiang will you be able to review this PR? It'll be very appreciated!

Updated the include ordering as proposed in https://github.com/facebookincubator/velox/issues/1918

Hi, Ying:
Due to recently committed changes, this pull request need to be rebased. I could have fixed everything internallybut we will not be able to export it to github and get that validated using cmake.  The changes caused by rebasing are not big, but it is also not trivial enough for me to assume it won't cause problem when validated using cmake in github.
Could you please rebase it and then I will import and land it?
Thank you very much!

@yingsu00
Forgot to add "@" in my last message.
Thanks!

This PR was included in PR #1865


bib: add experimental cross arch image building

[This is based on https://github.com/osbuild/bootc-image-builder/pull/138 and only the last two commits are relevant]
This draft PR outlines how we could do cross architecture image building.
The usage would be:
sudo podman run ... \
  --type qcow2 \
  --target-arch amd64 \
     quay.io/centos-bootc/fedora-bootc:eln

and this is predicated on the idea that the target container is available for both host and target architecture. When that is the case the container for the host architecture is used as a buildroot, the container for the target architecture is the target tree. Note that some stages chroot into the target tree so qemu-user is essential for this to work so that target achitecture code can be run transparently (because only very small amounts of code need to run emulated this is pretty fast still).

One thing to consider here instead of invoking qemu ourselves is to just podman run --arch amd64 bootc-image-builder instead.
Experimenting with things around this I ran into https://github.com/containers/podman/issues/15300 I think.

because only very small amounts of code need to run emulated this is pretty fast still

Is that true?  Either way we're going to be executing the target OS code right?  I think it's basically just that we're overall I/O bound in general.

One thing to consider here instead of invoking qemu ourselves is to just podman run --arch amd64 bootc-image-builder instead.
Experimenting with things around this I ran into containers/podman#15300 I think.

Thank you for the pointer and idea - I don't mind taking this route and will happily experiment with it. The reason I picked the approach in this PR is that most of the work that osbuild is doing happen in the buildroot. So making this native arch seemed expedient. However I think your point below is very valid, overall even during that stage osbuild is really not doing much (in a container world at least) so it maybe well be not worth the complexity and we can go all in on (slow) emulation for the buildroot work too.

because only very small amounts of code need to run emulated this is pretty fast still

Is that true? Either way we're going to be executing the target OS code right? I think it's basically just that we're overall I/O bound in general.

What I perceive is that this approach cross builds an bootc fedora image from amd64 for aarch64 in under a minute - this is why I wrote this comment. But as I wrote above I did not actually test how long it takes to have the buildroot running in emulation or even to just use podman --arch. It may well be that this is still very much good enough because of the i/o bound nature of the workload. I will play with this in the next few days and report back. My main point with this PR was to socialize the idea and get feedback and that I certainly archived :) Thank you!

I think this is wrong, it is going to be way too slow.  We should run bootc-image-builder in the native arch and then pass into it the --arch flag.

Everything runs really slowly in emulation mode, if we can run the commands in native and just pull and convert in alternative arch, the performance will be much better.

I think this is wrong, it is going to be way too slow. We should run bootc-image-builder in the native arch and then pass into it the --arch flag.

When I ran this for testing it was suprisingly fast because the buildroot which does the bulk of the work runs as native code. Only the very few pieces that need to chroot into the build tree during the build run in emulation.

I believe I was mistaken, when I read
sudo podman run ... \
  --type qcow2 \
  --target-arch amd64 \
     quay.io/centos-bootc/fedora-bootc:eln

My brain interpeted the --target-arch as the --arch option in Podman, meaning the BIB would be running in emulation.  The --target-arch going to BIB is exactly what I want.
https://www.youtube.com/watch?v=OjYoNL4g5Vg

This is exactly what we need.

I would like to get this merged to add the feature and then we can continue to work on some of the stuff Colin asked for.

This is ready now, it builds on top of https://github.com/osbuild/bootc-image-builder/pull/148 and does a "x86"->"arm" cross build with boot test. The boot test takes around 30s on my system, the test a total runtime of 5min.
Once things looks good in here and this is merged I will work on the "arm"->"x86" tests. I know it's an important use-case but I find it a bit painful to test on mac as I need to do this remote only.

The integration test fails right now with:
subprocess.CalledProcessError: Command '['chroot', '/run/osbuild/tree', 'useradd', '--groups', 'wheel', '--password', '$6$U379toL5x8.UFL8m$/wFhWBOSctUT0bCEXPw.vdiNf.vb1NYKU7ZK712bW9G3s/vZtgWkrPc9XMvegStvCzBRGkwqzoEg4/WwsGOA90', 'test']' returned non-zero exit status 126.

which means that the binfmt-misc handler needs to be registered from inside the container (we cannot rely on having this on the host OS). Hopefully just a SMOP.

Just curious, are we going to switch to use bootc install for bib by default or just as an option? does this cross arch build also works after switch over to bootc install?

Just curious, are we going to switch to use bootc install for bib by default or just as an option? does this cross arch build also works after switch over to bootc install?

The plan is to move to bootc install, there is already work in osbuild/images happening for this.

 WARNING: target-arch is experimental and needs an installed 'qemu-user' package
DONE
Building manifest-qcow2.json
source/org.osbuild.skopeo (org.osbuild.skopeo): Getting image source signatures
...
build:          04aded43b0432e5852df5ebf323bc54d73be4570745a47b6116f52a4ef46e269
ostree-deployment:      67e7f9dfb2805e1df572e33c4e36e8954532f0f8175586e73cf8abee2d0a3bf4
image:          c4ef94328cca66b6c15ff1d5c98ecad1b15b395270294c9f80a3f03ea97e4d66
qcow2:          946f9df64eb7daf87a07d28d355fcc08237f3dce134ae31cfc9fef6d0aa45848
Build complete!
 WARNING: target-arch is experimental and needs an installed 'qemu-user' package
DONE
Building manifest-qcow2.json
source/org.osbuild.skopeo (org.osbuild.skopeo): Getting image source signatures
...
build:          b09fb0efe1f39f826c46fcb8e9c1f7de13d0a0308de5d664404873c72127ce3f
ostree-deployment:      b14ddbb55e64bc2961d65ee8505246824bba3ac36d12320d0360ee77caa89973
image:          5cb0df803aa1d50d031b1d148fd3696de3f6c582290edb729bcba512f9d6dcb3
qcow2:          510c0be6224910b3636577aefcc4819cd55cbeb5eb4ba3e9e8476255c69bad31
Build complete!
Results saved in
/output
sudo podman run --rm -it --privileged --pull=newer --security-opt  --volume    0.01s user 0.02s system 0% cpu 4:10.20 total

This is awesome.

Hm, this one is running out of diskspace again :/

The main piece of this PR got merged via https://github.com/osbuild/bootc-image-builder/pull/179 and is available now. The testing got split into https://github.com/osbuild/bootc-image-builder/pull/181 mostly to avoid too much spam for this PR as I had to force push a bunch of times to figure the right GH runner setup with enough diskspace out. That seems to be fortunately solved now too. Once 181 is merged I will close this one as it's empty. Thanks everyone for your great insights and help getting this ready. I really appreciate that!


Enabling power support for apache/cxf

Description: To Enable ppc64le support for apache/cxf.
Test Result:
ubuntu@powervm17-1:~$ mvn -version
Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: /opt/apache-maven-3.9.6
Java version: 17.0.10, vendor: Eclipse Adoptium, runtime: /usr/lib/jvm/jdk-17.0.10+7
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.15.0-122-generic", arch: "ppc64le", family: "unix"
ubuntu@powervm17-1:~$ java -version
openjdk version "17.0.10" 2024-01-16
OpenJDK Runtime Environment Temurin-17.0.10+7 (build 17.0.10+7)
OpenJDK 64-Bit Server VM Temurin-17.0.10+7 (build 17.0.10+7, mixed mode, sharing)

CXF_build_success_logs.txt

Is this another case of the certificate needing to be updated?
The test case is to ensure the wss40 cert is valid.

Duplicate of https://github.com/apache/cxf/pull/1787 ?

I pulled fixes-4.0.x branch, and ran a build on my POWER9 host with Adoptium 17 - the build was successful with all tests passing. Checking main branch now.

Main branch also completed a full build with tests successfully.

Closing this PR as the issue is already resolved in this Jira ticket


SPK should not assume a service is a directory based in the repo

As a: developer
I want: to work with SPK in a manner that does not assume a service is a directory under the repository root.  Most commands - "service create", "create-build-pipeline", etc make the assumption that the service is in a directory under the repo root.
Describe the solution you'd like:. Documentation and command line should be clear about how to avoid this assumption.

@jmspring the main metadata file that spk service/project commands write to is bedrock.yaml which lives at the root. Are you saying the actual source code should be able to live at any directory below the root?
If so I think we can leverage the bedrock.yaml to store (or anchor) that information. Perhaps after one calls spk project init at the root, they can call spk service create with a subdirectory path. This information will be added to the bedrock.yaml. Would that work?

Yes, leave bedrock.yaml in the root and the remaining files in a spk specific directory.

@jmspring we have this existing epic story that will allow specification of the path to service. Would that suffice?
cc @mtarng

The work covered in https://github.com/microsoft/bedrock/issues/943 should handle this case.

Closing as duplicate of https://github.com/microsoft/bedrock/issues/943


add architecture

Description
What is the purpose of the change?
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Brief of your solution
Please describe your solution to solve the issue or feature request.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Codecov Report

Merging #32 (652cee0) into main (0459ebe) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 652cee0 differs from pull request most recent head cdbc43c. Consider uploading reports for the commit cdbc43c to get more accurate results

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   44.39%   44.39%
=======================================
  Files           8        8
  Lines         428      428
=======================================
  Hits          190      190
  Misses        204      204
  Partials       34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0459ebe...cdbc43c. Read the comment docs.


preferredStatusBarStyle

Hi there,
After some tests I realized that preferredStatusBarStyle and similar where not set from the currently displayed side, it would be nice to forward them and ask the system for a status bar update when opening/closing a side.
Would you like a PR?
Thanks again,
Stan

Hello @dvkch!
First, thank you very much for using this project :)
Thank you for letting us know about this issue.
It would be nice if you PR your wonderful work.
Thanks again,
Kawoou


Update cassandra-driver-core to 3.8.0

Updates com.datastax.cassandra:cassandra-driver-core from 3.7.2 to 3.8.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.datastax.cassandra", artifactId = "cassandra-driver-core" } ]

labels: semver-minor

Superseded by #2103.


Use NPM+Browserify/Webpack and remove Bower?

(Topic was: "Move Bower modules out from /public/")
It's a slight security issue.
Now Bower libs end up to /public/lib/**/* and thus are open to public from the server.
I'd like to be in full control what my server is publishing. This way we might accidentally publish malicious JS at the same domain, so we aren't protected from XSS attacks via this.
Related to #1078

@simison What's your proposed fix while still using bower?

I don't have anything I can suggest as a best practise, but I guess it boils down into:

symlinking (very error prone)
bundling needed files into one js also at development (already done at production)
keeping them under public only for dev and cleaning the folder out for prod
using npm main-bower-files

...or another way is to push non-Bower way such as NPM+Browserify, but that's another discussion.

a lot of frameworks make grunt build create a really production-ready snapshot of the project, such as uglyfing, minifying, etc, but most importantly it creates a dist/ directory such as:
dist/
dist/public
dist/server
package.json

which makes this dist/ directory deployable: you can just copy that to a remote server, run npm install for the modules, and start the server.
what do you think?

@simison if that sounds like a good idea, how about taking this for a PR?

@lirantal @simison :+1:

I use wiredep in one of my projects and love it.
https://github.com/taptapship/wiredep
Automatically reads the bower file and inserts into the layout page.  So you would just have to move the bower directory and put 2 pieces of code onto the layout.html page.

@lirantal @codydaig @simison I think this would be pretty easy.  Move the Bower directory out of public, wiredep(), move the files to pubilc/lib, use gulp-inject to layout.html.  I wouldn't want to do this for grunt as well so when is the official move to Gulp?  Doing this would bring breaking changes to using grunt as we would be removing all of the bower packages out of the assets files as well.

@trainerbill I just submitted a PR for the removal of grunt to start discussion around what all needs to be done to officially remove grunt. I think the plan is to complete the migration before 0.5.0.
I'm indifferent on how we go about this. @simison Are you interested in submitting the PR as discussed earlier?

@trainerbill @simison would you guys like to push further on the wiredep/dist directory build for production environments?

I think it would be good for ng1, but worthless if you are going to move to ng2 anytime soon.

I've been looking into this today after I run into some hassle again because of Bower. I really feel like getting finally rid of Bower completely and using something more modern such as Browserify.

Use only one package management
Things don't break so easily when requiring outdated versions
Safer, no more exposing all the lib files publicly

Just it seems that it would need quite a bit restructuring angular modules/directives/etc around require() syntax.
Anyone got experience working with Browserify+Angular? Great examples?

@simison I'm wondering if it's better to work on webpack instead because that seems to be the de-facto for frontend packing these days. I'm concerned we'll just pick browserify which isn't that 2016 and need to refactor all the work again.

Oh yea totally, I'm not that invested to Browserify-idea. :-) I'll check out Webpack, thanks for pointing that out. Hard to keep up with all these tools!

Javascript Fatigue :)

I like this a lot: http://angular-tips.com/blog/2015/06/using-angular-1-dot-x-with-es6-and-webpack/
@lirantal This should probably not be for 0.5.0 milestone...

Indeed.

@simison I've been playing around with angular-cli, building a very simple app with it. I think it can make a good resource for our next mean.js revamp with angular2.
 The big question for me is ES6 or typescript? Most angular docs are in Typescript but not plain Javascript.

@codydaig Typescript without a doubt. All the generators are geared towards TS.

@codydaig @lirantal What's your overall feeling on the likelihood that mean.js will move to Angular 2 in the next 12 months?
I suspect there are many developers new to Angular who will likely only consider Angular 2 solutions.
For me personally, I'm really struggling with whether I should divide my focus between 1 and 2, or just focus on 2.
I'm competent with 1.x, but 2 is simpler and arguably better in all respects (except for the initial webpack or SystemJS initial setup, which can be super scary for beginners).
Just considering the capability of angular-cli and support for observables with rx.js, 2.x has surely got to be the way forward in the long term. What are your thoughts?

Sorry, just saw https://github.com/meanjs/mean/issues/1666
Pls disregard last comment.

I think this will come naturally with more fresh ES6/Angular2 codebase.


HOV-87 | moves list item inside List folder

Description
Moves List Item

moves list item inside List folder
Motivation and Context

Improving Directory structure of the code
How Has This Been Tested?

Tested by building locally
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the code style of this project.

@Raalzz the sonar cloud bugs are not relavant to changes in this PR and highlight code from Modal,Alert etc. Will pick up in next PR. Please merge this one as this is not adding any new bugs


No such method exception

Observed behavior
I got an java.lang.NoSuchMethodError: 'void io.nats.client.impl.MessageQueue.(boolean)'
When I upgraded "jnats" to 2.19.0 and tried to create JetStream definition.
Expected behavior
It should work
Server and client version
latest
Host environment
No response
Steps to reproduce
Just upgrade "jnats" to 2.19.0 or any 2.17.4+

It also does not persist messages to JetStream but does not give an error.

@borag
This is due the fact that jNATS 2.17.4 introduced a breaking API Change on MessageQueue with introduction
a REQUEST_CLEANUP_INTERVAL
e.g.
super(true, Options.DEFAULT_REQUEST_CLEANUP_INTERVAL);
This API change can be hidden, but IMHO could potentially introduce behaviour change.

It's actually not a breaking change since JNats MessageQueue is not public. The next release will address this.


PCKPacker class example code

It would be beneficial to add this simple piece of code to eliminate possible headaches that could occur from trying to use AddFile's method in an incorrect way without passing "res://".

See my above comment proposing some changes. Commits should eventually be squashed into one, see PR workflow.

Oh god, something went terribly wrong on my end after rebasing

The final state looks good, but it looks like the rebase did not go as planned as there are 5 commits. I pushed a squashed commit directly as fa45fdb5f5d8435b49303ef36b33241f278b33de.
Thanks for your contribution!


Misleading and wrong error message

The last line of the following code is invalid nonsense:
"dictparam" : {"B" : 2},
"listparam" : ["A", "B"],
${IAMNOTEXISTING.${dictparam}}['${listparam}'] : 3

The error message is:
Error: 'Overwrite the element '${IAMNOTEXISTING.${dictparam}}['${listparam}']' failed! Due to the datatype of '${dictparam}' is '<class 'dict'>'. Only simple data types are allowed to be substituted inside.'!
I can imagine that it's very hard to give guidance in case of such code. Because: How to detect nonsense? There must be any initial piece of (invalid) code that causes the JsonPreprocessor to throw an error. And in this example it's the data type dict, that is not allowed at a certain position. But could also be the listparam, that is not allowed inside square brackets. This is a detail. I like to provide details. But how relevant is this detail if the entire expression is nonsense?
In my opinion the wording in this error message (Overwrite the element ... failed! ...) is misleading. Which element cannot be overwritten? And is it really detectable that there is something valid existing, that cannot be overwritten? I would say: No! Therefore the error message is too specific in this case.
I would prefer a more common version like
Expression "..." cannot be evaluated because of the usage of a not supported data type. The data type of ... is .... Only simple ...
More informations we should not expect from the JsonPreprocessor.
Finally I put the expression in quotes:
"${IAMNOTEXISTING.${dictparam}}['${listparam}']" : 3
Now the error is:
Error: 'Invalid syntax! One or more than one opened or closed curly bracket is missing in expression '${IAMNOTEXISTING.${dictparam}}['${listparam}']'.
           Please check the configuration file of the executed test!'!

This astonishes me. Because there is no bracket mismatch.
Also in this case my expectation would be the error message discussed above:
Expression "..." cannot be evaluated ...

Retest successful (error message improved). Issue can be closed.

integrated in RobotFramework AIO 0.11.0


Favicon Fetcher

Is your feature request related to a problem? Please describe.
Getting favicons is a drag
Describe the solution you'd like
A simple extension to fetch favicon
Describe alternatives you've considered
None
Additional context
GSSoC'24
What problem is this feature trying to solve?
How do we know when the feature is complete?

Please assign this issue to me @Sulagna-Dutta-Roy


move CONTRIBUTING out of .github dir

CONTIRBUTING.md needs to be easy to find -- I knew it was there somewhere, and I couldn't find it. I only found it by finding the issue where is was discussed, then the link to the PR, then looking at the PR.
.github is a hidden dir on many systems, not a good place to put a file yu want folks to find up front!
Note that gitHub suggests:
To help your project contributors do good work, you can add a file with contribution guidelines to your project repository's root, docs, or .github folder. When someone opens a pull request or creates an issue, they will see a link to that file
So I can see how it got there, but it can be in root too, where it is far more likely to be found.

I think I was following old guidelines by putting it in .github. I'm glad you made this suggestion. I support this PR.

Good idea, Chris. I also support this.
Thanks, David

Given that this is a non-controversial change and does not apply to the specification, I'd say we should merge given we have two people in support. Any dissent?

Not me, obviously:-)

That's good for me, too.


Features: (Markdown) Content at Homepage, Contact Form and Markup Highlight

Hi,
I've been working on bunch of new features and without any doubt decided to push it to upstream repo.
Most probably it's too many changes for a single PR, hope you don't mind and some of this can be merged to the main branch.
Changelog:

The Home page by default did not let the authors to put any other content than the list from mainSections = ["something"]

it's no longer the case, also added some comments in the code so people can figure it out how to deal with it

Added a Contact page - it's a simple form using formspree.io - was doing my best to keep it simple yet tidy and matching dark/light modes

missing i18n

Added Markup/Highlight styles matching dark/light modes (this can be checked with exampleSite/content/post/markdown-syntax.md) -- the thing is I didn't want to do too much so I followed what hugo docs told me and with some help of a handy script I did my best to keep it simple at the same time
Last but not least - since I'm not the biggest fan of the Verdana font I did some research and finally copied some stuff from a well-known Bootstrap framework - put it into the exampleSite/assets/css/custom.css so you can give it a try and check wether you like the result

@karolkania Thanks for all your arduous work. I've tried all of them and they were all working as expected. In particular, I like the contact form and the static homepage!
I will still need to make some adjustment to the readme and then we should be able to merge this PR.
The only thing I am not yet a hundred percent sure about is the font topic. You are definitely mentioning a valid point, but I'll have to give it a second thought. Perhaps, this would be the chance to change to an accessible font such as Atkinson Hyperlegible Font.


Use Issue.FixVersions to determine the fix version instead of the date/time of a commit

GitTools.IssueTrackers supports FixVersions to specify in what version an issue is fixed. This way it should automatically be possible to correctly generate the release notes.

This needs to be a strategy, using milestones should not be required for GitHub

What do you mean by that? When I specify JIRA, it has milestones / fixversions, but we can still combine stuff. For example, I am testing this on Catel, and 3.8.1 should have only 1 fix (hotfix release), still it has this:
3.8.1 (2013-12-12T18:36:22+01:00)
[CTL-264] Reset FileServiceBase.ValidateNames default value to true
[CTL-261] Replace all instances of RegisterDebugListener with AddDebugListener
[CTL-260] Remove ExposeAttribute unit tests because marked as error in 3.9
[CTL-259] Rename defines in Windows Phone 8 projects from WP8 to WP80
[CTL-204] Catel.IoC.IServiceLocator should contains some methord to remove registered type

So we should either:

Accept issues from the issue tracker (we assume that the issue tracker is always right)
Add additional mentioned issues inside commits that are inside a tag AND are closed (might be a partial commit)

I should be able to run this tool against a github repository which is not using milestones or mentioning issue numbers in commits

Then this will happen:

No issues found (because no milestones)
Issues are mentioned in commits, so these are gathered

Works perfect, right?

I used GitReleaseNotes to generate https://github.com/ParticularLabs/GitVersion/releases/tag/3.0.0-Beta3
We don't use milestones or mention commits and the tool works fine. We cannot remove that functionality

Then the title might have mislead you a bit. It will always be a combination of 2:

Use issue tracker (in case people forget to mention an issue)
Use commits (which is a fallback in case 1 is not available)

https://github.com/ParticularLabs/GitVersion/releases/tag/3.0.0-Beta3 includes pull requests and issues, it is not using commits?

It finds the issues because they are being mentioned inside the commit titles, so using commits, right?

Nope, many of those issues do not mention issues. It works by getting all closed issues between the timestamp of the last git tag and the current git tag or now

Here is the logic I think we need for generating a complete release notes (all releases):

Gather all release versions, this is from tags and the issue tracker (completed releases/milestones). Versions from the tracker should win over tags
Get issues closed between closing the previous version and closing the current version
Get issues tagged with fix version/in milestone
Combine 2 & 3 removing duplicates

On all branches or a specific branch where the tags are used?

GitReleaseNotes gets run against a branch, so all tags on that branch

AND are assigned to a milestone OR have no milestone at all. Otherwise it might be an issue we fixed on develop while we were fixing the hotfix (that's what happening on my test data right now).

So I think we should combine 2 and 3.

That restriction makes sense where querying closed issues during a time period. Just exclude issues which have a milestone assigned.
I don't mind getting incorrect data, I manually edit/combine/remove issues anyways after I generate. The tool just does the hard work of collating the data for me

We are looking to automatically generated stuff very dynamically (if test a updates from unstable 34 - unstable 36, we want to include that so they know exactly what has happened since last time). I will try to implement it so everyone is happy.

I will close this issue, we can discuss further at #86.


"Attach Blaze Source Jars" links sources with wrong path

Our project uses Maven artifacts via Bazel to reference other libraries. The jar-files of those libraries are downloaded to a subdirectory of the Bazel cache directory. The same holds for the source files.
When I navigate to a class of such a library, "Attach Blaze Source Jars" shows up. After triggering it, it simply vanishes and the standard IntelliJ Options "Download..." and "Choose Sources..." are displayed. The source code isn't displayed, though.
After these steps, there seems to be an additional entry for the sources which is shown when going to "Project Settings > Libraries > specific library".  However, the path points to a non-existent source jar. Instead of referencing the subdirectory of the Bazel cache directory, the path consists of the directory containing the code of the project followed by the correct subdirectory structure.

This is fixed for the next IJwB release (v1.13+). For the fix to take effect, you'll need to either wait for another bazel release, or build it from head.

Thank you for fixing this issue. It works for me with IJwB 2<IP_ADDRESS> and Bazel 0.4.4.

How can this be fixed when #42 which sounds the same is open.
Is this working?

I played with this a bit and I see that jars from maven central and sonatype are automatically searched and downloaded.
Is this the difference between this ticket and #42?

This bug isn't about automatically downloading source jars. It's just about correctly attaching already downloaded source jars to the project libraries.
AFAIK, Bazel won't yet automatically download source jars for maven_jar targets -- but if you force it to (e.g. via your own custom rule type), the IntelliJ plugin now handles it properly.


Search for select or chips

Example from Angular Material: http://codepen.io/anon/pen/oBPomg or Autocomplete component https://material.angularjs.org/latest/demo/autocomplete

This is already tracked here #196


Error retrieving Operating System info on Windows

Library calls the following command with subprocess to retieve Operating System info:
'systeminfo | findstr /B /C:"OS Name"'

This is not correct because systeminfo on Windows dependes on OS language. For example, I use Windows OS in spanish and never will find the string OS Name because in spanish shows Nombre del sistema operativo instead of OS Name.

I propose at least returning platform and version provided by python built-in libraries:
import platform

print(platform.system())
print(platform.release())

I propose at least returning platform and version provided by python built-in libraries:
import platform

print(platform.system())
print(platform.release())

Merged +1:


Update regex for email address

Update regex for email address to be aligned email format in RFC 5322
Pull Request Checklist

[x] Pull request is based on the develop branch
[x] Pull request contains a changelog file in ./changelog.d. See https://github.com/matrix-org/matrix-ios-sdk/blob/develop/CONTRIBUTING.md#changelog
[x] Pull request includes a sign off

Signed-off-by: yostyle<EMAIL_ADDRESS>

@pixlwave Hello Doug.
Can you have a look at this PR. We need it on Tchap.


Website down?

I'm getting the following for https://svelte-native.technology/

Hey @halfnelson, looks like it's offline again.


Is there pow() accepting BigInt in exponent?

Is there pow() accepting BigInt in exponent?

Yes. use this:
use num::traits::Pow;
let r = Pow::pow( a, b );

I found the answer. Thanks.


Add USD/BTC of coins worth fetched via tor.

Seeing inside the wallet how much your coins are worth would be great.

While doing so also add all relevant fiat currencies as option to replace USD with.


Update docs for reordering role appointments

Description
During a reshuffle, a minister can gain two positions of state, known as RoleAppointments in Whitehall. One of these is perceived to be a more senior role than the other. However, Collections will just render these by ascending order of ActiveRecord IDs as default.
We've built a UI into Whitehall so we don't have to manually hit the db via Rails console.
This updates the docs with instructions of how to access the UI.
Trello card
https://trello.com/c/Tpq1mo6W/4-allow-ministers-roles-to-be-reordered-in-the-ui-probably-quite-a-large-task

thanks for the review. Have fixed those issues. Sorry that was careless on my end!


Unable to use In Visual Studio, .NET Core targets can be used by default. Add this property to the sqlproj:  True

SqlPackage or DacFx Version:
.NET Framework (Windows-only) or .NET Core:
Environment (local platform and source/target platforms):

Steps to Reproduce:
Convert a VS .sqplproj to SDK build.
Follow this from the readme (adding it to the first "PropertyGroup"
In Visual Studio, .NET Core targets can be used by default. Add this property to the sqlproj:

<NetCoreBuild>True</NetCoreBuild>

Excpected: project builds
Actual:
Severity	Code	Description	Project	File	Line	Suppression State
Error		Your project file doesn't list 'win' as a "RuntimeIdentifier". You should add 'win' to the "RuntimeIdentifiers" property in your project file and then re-run NuGet restore.	Database	C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\NuGet\17.0\Microsoft.NuGet.targets	198

Superseeded


Constructing a Key<?> object

How do we construct the Key object by just using an ObjectID? Cannot find anywhere. Neither Key has any public static method , or a Key object. I want to store some fields as key but instead I store them as ObjectId, which kinda defeats the purpose.

Please post this question and a code sample to the mailing list and we can talk it through.  The issue tracker isn't the best place for discussions like this.


Data exports (CSV) naming convention inconsistent

See attached CSV exports for all three at the same point in time.
20210902 All Regions.csv
20210901 Western Australia (SWIS).csv
20210902 OpenNEM.csv

QQ @nc9 was this resolved?


Webpack encore compatibility issue.

Hi
I've tried to run the plugin along with my webpack-encore configuration. But unfortunately i'm gettimg this error message:
Syntax Error: ModuleNotFoundError: Module not found: Error: Can't resolve '~/Users/..../frontend/assets/node_modules/iconfont-webpack-plugin/placeholder.svg' in '/Users/..../frontend/assets/src/common'
I've checked the path and the file is there however it's empty.
My webpack-encore config looks like this:
[...]
    .enablePostCssLoader((options) => {
        options.postcssOptions = (loader) => {
            return {
                plugins: [
                    new IconfontWebpackPlugin({
                        resolve: loader.resolve,
                        fontNamePrefix: 'custom-',
                        enforcedSvgHeight: 1000,
                    })
                ]
            }
        }
        return options;
    })

icons.scss:
.icon-ranking:before {
  font-icon: url('icons/ranking.svg');
}

.icon-rating:before {
  font-icon: url('icons/rating.svg');
}

and package.json deDependencies section
  "devDependencies": {
    "@symfony/webpack-encore": "^0.33.0",
    "autoprefixer": "^9.0.0",
    "css-loader": "^5.0.1",
    "iconfont-webpack-plugin": "^5.0.0",
    "postcss": "^8.2.4",
    "sass": "^1.32.0",
    "sass-loader": "^10.1.0"
  },

TIA for any advice

The ~ is wrong maybe a outdated css-loader option?

I get the same type of error when upgrading from postcss-loader version 3.x to 4.x (also on 5.x).
Sadly the newer version of Webpack Encore (1.x) requires postcss-loader ^4.0.0 || ^5.0.0.


Make sure agent is stopped before every test

A bunch of tests start, or try to start, the agent with different configs. These can conflict with each other and not start the agent when it is supposed to. A common error I see in the appsignal.log is this:
[2023-05-24T11:25:59 (agent) #43777][Debug] Booting appsignal-agent
[2023-05-24T11:25:59 (agent) #43778][Debug] Starting appsignal-agent in daemonized mode
[2023-05-24T11:25:59 (agent) #43778][Debug] Exiting agent, we did not become owner of the lock
[2023-05-24T11:25:59 (agent) #43778][Debug] is_currently_owner: Our pid is Some(43778), pid on disk is Some(43423)

Remove the AppSignal working directory before every test. This quickly shuts down the agent and fixes the OpenTelemetry connection error for port 8099 (the agent).
I also tried to make it work with psutil like so, but it still printed the error sometimes.
# conftest.py
import psutil

AGENT_PROCESS_NAME = "appsignal-agent"

@pytest.fixture(scope="function", autouse=True)
def stop_agent():
    for proc in psutil.process_iter():
        if proc.name() == AGENT_PROCESS_NAME:
            proc.terminate()

    yield

[skip changeset]

I recall getting this:
[2023-05-24T11:25:59 (agent) #43778][Debug] Exiting agent, we did not become owner of the lock

while running the Flask test-setup when not rebuilding the container, just resetting it. Maybe we can do a similar check when starting the agent outside of the test environment?

This log line should be fine. It's the newly started agent telling us another one is already running and it's exiting.
If anything has changed in the config, it should exit the running agent. If nothing has changed the agent should exit and let the running agent stay running. I don't want it to exit the running agent all the time.
This PR fixes it for the test suite where we're testing some scenarios of starting the agent properly, so no other agent should be running.


Some questions about image alignment

Hi Chaminda, I have some questions about the dataset you use, that is, what is the accuracy of these data set images?

@DoongLi Thanks for the question. The datasets used in this repo are aligned (using some pre-processing algorithm) but I have not explored the accuracy of the alignment. Based on my observations, they alignment is done pretty well, but do not have any quantitative numbers. I even haven't seen alignment accuracy in the original dataset papers.

Thank you for your reply! I am very interested in this question, I will read other papers.

By the way, have you tested your algorithm on Stree View DataSets?I want to apply Change Decetion to the robot.

@DoongLi Your question is worth exploring more. No, I did not try our method on Street View Dataset.

Ok，thx

Hi @DoongLi ,
I think image alignment is important if apply this algorithm on real world scene.
Do you find other method considering image alignment in model or preprocess ?

Hi @chilin0525 In effect, we are creating a dataset with very accurate image alignment.

Hi @chilin0525 In effect, we are creating a dataset with very accurate image alignment.

Ok, thank you. 👍

@chilin0525  I will open about at the end of this year, I will inform you, and we can communicate again.

Thanks for the great work @wgcban. I wonder if you can lead to any preprocessing algorithm to make it rotation invariant, or to use image alignment.

@hamzagorgulu  I think it very hard to achieve this.

@hamzagorgulu I think it very hard to achieve this.

Actually opencv supports this. Image based feature alignment script helped me to align the input image by giving a reference image.

You can try this, but actually singe H matrix can't fine warping two images which have a big viewpoint difference.

https://github.com/IMRL/UMAD  Our dataset video have been public. @wgcban @chilin0525 @hamzagorgulu

Great work! Thanks for updating here... will take a look later...

Also, do you have a link to the paper?

Sorry, my tutor said the paper would not be made public until it was received.

Pls post the link here when it is online.

ok

@DoongLi Hi，which labeling tool are you using ?

@chilin0525 This, https://github.com/CVHub520/X-AnyLabeling


bug fix   the way to get the stream doesn't work

https://github.com/PawanOsman/ChatGPT.Net/issues/25#issue-1661750593

Thank you


[tesseract] fix unrecognized command line option -mfpu=neon on aarch64

Fixes #32264

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

This was submitted upstream as https://github.com/tesseract-ocr/tesseract/commit/d7c071197e771263e923b731af05302a7e68efbd , thank you


docker: clamp empy to version 3

API and syntax changes in 4 make CI problematic

Have you consodered empy==3. We still want to bring in bugfixes automatically.

Tried that as my first thing.  Gave me errors, so I moved on.


Update order of finals night report

Current order:

Tournament runner up
Tournament winner
Man of the match
Division 2 Most 180s
Division 1 Most 180s
Division 2 Highest checkout
Division 1 Highest checkout
Pairs runner up*
Pairs winner*
Singles semi-finalists x 4*
Singles runner up x 2*
Singles winner*
Division 2 runner up
Division 2 winner
Division 1 runner up
Division 1 winner


SET with XX creates an object even though it does not yet exist

To reproduce:
SET test obj XX point 5 5
Then:
SCAN test match obj
The object shows up even though XX should prevent creation.

Thanks for reporting this bug. I pushed a fix to the master branch.


Does this work with non-focused window?

My initial testing shows that the popup only shows up with the focused window, when there are many splits on screen.
I does not find any info about this explicitly, so does this currently support mousing hovering on non-focused window?
Thanks for the plugin.

I tested again with a clean session and it works on all windows now. Thank you.


Fifo messages aren't deduped

Anaconda-IPython
sys.version[:5] == '2.7.6'
boto3.__version__ == '1.5.17'
moto.__version__ == (u'1.2.0',)
Reproduce
import boto3
from moto import mock_sqs

@mock_sqs
def dedupe_fifo():
    sqs = boto3.resource('sqs', region_name='us-west-2')
    queue = sqs.create_queue(
        QueueName='my-queue.fifo',
        Attributes={
            'FifoQueue': 'true',
        },
    )

    for _ in range(5):
        queue.send_message(
            MessageBody="test",
            MessageDeduplicationId="1",
            MessageGroupId="2",
        )
    assert queue.attributes['ApproximateNumberOfMessages'] == 1

Expected Behavior
For the assert to pass, as messages have been deduped. Note that my code sample should work whether Content-based deduplication is enabled or not, since the MessageBody is identical
Experienced Behavior
No de-duping occurs, so I get an AssertionError, assert 5 == 1, where 5 is length of my for-loop

Possibly related, when I retrieve messages from a mocked FIFO queue, the MessageGroupId is not present.

Thanks for opening. Marking this as a feature request.

Also encountered this so just wanted to +1

@bblommers let me take a look at this

nvm, looks like it's already been tackled https://github.com/getmoto/moto/blob/master/moto/sqs/models.py#L533

@rafcio19 I'd have to verify this against AWS, but from my understanding of the docs and our implementation, two scenarios are not yet implemented in Moto:

with ContentBasedDeduplication can be set to False (like in the example above) - we should still deduplicate. (The if-statement you linked is only active if ContentBasedDeduplication is set to True)
the deduplication_id-attribute is set when ContentBasedDeduplication=True (https://github.com/getmoto/moto/pull/3538/files) - I assume that it only needs to be set if it isn't explicitly provided by the user

Gotcha, in that case let me take a look 👀


[v2] side panel does not show text, but shows filenames

Server OS: Archlinux

Description
file manager does not show tab names (Active editor, current working folder, the thingy that shows where you are in the code)
 (see left side)
Steps to Reproduce
Literally don't know, was working fine this morning (4 hours ago)

This is a intermittent bug with VSCode's styling because it wasn't really built properly for anything beyond Chromium. Might be worth investigating.

Alright, i found that it happens seemingly at random, (usually when it isnt
loaded WITH the page the first time)
—Merith
On Tue, Oct 8, 2019 at 5:47 AM Ayane Satomi<EMAIL_ADDRESS>wrote:

This is a intermittent bug with VSCode's styling because it wasn't really
built properly for anything beyond Chromium. Might be worth investigating.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cdr/code-server/issues/1061?email_source=notifications&email_token=ACPQOXWBEQWTXSLTN7XTH2TQNR6OBA5CNFSM4I6ITTTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAUA5MQ#issuecomment-539496114,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACPQOXU77MUYPV34CYEUNN3QNR6OBANCNFSM4I6ITTTA
.


audited_entities configured but not used

I'm using this bundle with the Symfony 2.8 app and Doctrine ORM 2.5
I have install, enable and configure this bundle with the entities I want to audit.
# SimpleThings Entity Audit
simple_things_entity_audit:
    audited_entities:
        - AppBundle\Entity\User
        - AppBundle\Entity\Server
        - AppBundle\Entity\IpV4
        - AppBundle\Entity\IpV6
        - AppBundle\Entity\Purchase

The bundle should now only audit this entities and create only 6 tables (for this 5 entities and the revisions table).
But when I use ./app/console doctrine:schema:update --force this create _audit tables for every single table of my database.
Did I forget something or this is a common bug ?

@Jerome1337 I can't replicate this. There is code in the schema listener to prevent against this:
https://github.com/simplethings/EntityAudit/blob/2d8de80e851cdac1071f54fd710bad4b7ae84f51/src/SimpleThings/EntityAudit/EventListener/CreateSchemaListener.php#L60-L76
Can you please reopen this if you can see what the issue is, but i'm going to close for now.

@Jerome1337 Do you solved the problem. I'm having the exact same problem @bendavies. Currently investigating...

@bendavies Found the problem, problem occurs when using Sonata Admin. Do you have this code enabled? This should solve it.
sonata_doctrine_orm_admin:
    audit:
        force: false

@ceesvanegmond Exactly this solve the creation problem.


Fix singleton check + docs for show command

[x] Have you signed the Contributor License Agreement?
[ ] Are you working against an Issue?

Steps to reproduce
wingetcreate show NSIS.NSIS ---> Throws an exception
Singleton check should be the first one to prevent going into show all manifests flow

Microsoft Reviewers: Open in CodeFlow

/azp run


Client has no connection to Kafka anymore after idling for some time

Versions
Please specify real version numbers or git SHAs, not just "Latest" since that changes fairly regularly.

Sarama
Kafka
Go

v1.23.1
v2.3
1.12

Configuration
What configuration values are you using for Sarama and Kafka?
// NewSaramaAdminConfig creates a new sarama config which can be used for the admin client
func NewSaramaAdminConfig(cfg *Config) (*sarama.Config, error) {
	sConfig := sarama.NewConfig()
	sConfig.ClientID = cfg.ClientID
	sConfig.Net.KeepAlive = time.Second * 45

	version, err := sarama.ParseKafkaVersion(cfg.KafkaVersion)
	if err != nil {
		return nil, err
	}
	sConfig.Version = version

	if cfg.SASLEnabled {
		sConfig.Net.SASL.Enable = true
		sConfig.Net.SASL.User = cfg.SASLUsername
		sConfig.Net.SASL.Password = cfg.SASLPassword
	}

	err = sConfig.Validate()
	if err != nil {
		return nil, err
	}

	return sConfig, nil
}

Logs
{"level":"info","ts":"2019-09-10T22:47:59.272+0200","msg":"Server listening on address","address":"[::]:9090","port":9090}
{"level":"error","ts":"2019-09-10T23:24:34.138+0200","msg":"Failed to list topics from kafka cluster","error":"write tcp <IP_ADDRESS>:58796->redacted:19092: wsasend: An established connection was aborted by the software in your host machine."}

Problem Description
I have an admin client which is supposed to return a list of all Kafka topics upon invocation on a REST endpoint. This does work as desired, however after some idling (e. g. not running any requests with the admin client) for 30 minutes or so I can not get any topics anymore because of the error shown above in the logs.
I thought the .Net.KeepAlive config option (as shown in the go code) would resolve this, but apparently this hasn't helped. What is the problem?

You can access debug log if you set the library logger: https://github.com/Shopify/sarama/blob/master/tools/kafka-console-producer/kafka-console-producer.go#L45
Can you share the output?

@FrancoisPoinsot
Hi, I'm working on the same project as weeco, so I've got a log for you 😄
[
   // ...

    {
        "level": "debug",
        "ts": "2019-10-04T15:57:27.316+0200",
        "msg": "Successful SASL handshake. Available mechanisms: [PLAIN]",
        "source": "sarama"
    },
    {
        "level": "debug",
        "ts": "2019-10-04T15:57:27.337+0200",
        "msg": "SASL authentication successful with broker XXXXXXXXX - [0 0 0 0]",
        "source": "sarama"
    },
    {
        "level": "debug",
        "ts": "2019-10-04T15:57:27.337+0200",
        "msg": "Connected to broker at XXXXXXXXX (registered as #1)",
        "source": "sarama"
    },
    {
        "level": "debug",
        "ts": "2019-10-04T16:04:26.781+0200",
        "msg": "client/metadata fetching metadata for all topics from broker XXXXXXXXX",
        "source": "sarama"
    },
    {
        "level": "debug",
        "ts": "2019-10-04T16:14:26.781+0200",
        "msg": "client/metadata fetching metadata for all topics from broker XXXXXXXXX",
        "source": "sarama"
    },
    {
        "level": "error",
        "ts": "2019-10-04T16:19:25.782+0200",
        "msg": "Sending REST error",
        "route": "XXXXXXXXX",
        "method": "GET",
        "error": "one of the brokers failed to return a list of consumer groups: EOF"
    },
    {
        "level": "warn",
        "ts": "2019-10-04T16:22:00.266+0200",
        "msg": "Keep alive has errored",
        "error": "write tcp XXXXXXXXX->XXXXXXXXX: wsasend: Eine bestehende Verbindung wurde softwaregesteuert\r\ndurch den Hostcomputer abgebrochen."
    },
    {
        "level": "debug",
        "ts": "2019-10-04T16:24:26.781+0200",
        "msg": "client/metadata fetching metadata for all topics from broker XXXXXXXXX",
        "source": "sarama"
    },
    {
        "level": "warn",
        "ts": "2019-10-04T16:24:30.472+0200",
        "msg": "Keep alive has errored",
        "error": "write tcp XXXXXXXXX->XXXXXXXXX: wsasend: Eine bestehende Verbindung wurde softwaregesteuert\r\ndurch den Hostcomputer abgebrochen."
    },
    {
        "level": "warn",
        "ts": "2019-10-04T16:25:30.522+0200",
        "msg": "Keep alive has errored",
        "error": "write tcp XXXXXXXXX->XXXXXXXXX: wsasend: Eine bestehende Verbindung wurde softwaregesteuert\r\ndurch den Hostcomputer abgebrochen."
    },

   // ...
]

Some things to note here:
The message Eine bestehende Verbindung wurde softwaregesteuert... is the description for WSAECONNABORTED (that's socket error code 10053).
The "keep alive" is referring to this code: https://github.com/kafka-owl/kafka-owl/blob/master/backend/cmd/api/main.go#L50-L59

I have updated the title as this is not an Admin client exclusive problem. The same happens if you use the sarama client directly, rather than the AdminClient.

Seems like this is actually an issue in Go:
https://github.com/Shopify/sarama/blob/d1948414ad5ca980ff1506c4ca7cb99de2bdeaff/broker.go#L156
Known Issue:
https://github.com/golang/go/issues/31490

Still valid


14 Update code to use isFlat()

Small PR to close #14.
Here's a quick fix to prevent hundreds of warnings in the console (which was causing massive lag in my app).
Thanks for your work on this plugin @ebrelsford it's awesome!

Merged, thanks for the fix!


is it support scrollView?

i hava a image view wrapping the blur view, on the top of my component.the blur effect is ok, but when i scroll the view, the blur view will twinkle.

Is there a way to reproduce it?

Yes, i can reproduce it.When I scroll ScrollView, BlurView fuzzy position does not seem to change. Although BlurView has followed the scroll, but this will cause other common views which went to this position has become blurred.

Can you share a code snippet?

<ScrollView >
  <View>
    <Image
      resizeMode={"cover"}
      source={{uri: this.state.thumb}}
      style={{width: ST.Dim.width,  height: ST.Dim.width * 411/640}}>
      <BlurView shouldRasterizeIOS={false} blurType="light" style={{flex: 1}}>
        <View style={{alignItems: 'center', marginTop: w(35), flex: 1}}>
          <TouchableOpacity onPress={
          ST.interactFunc(function() {
            global.nav.push({component: MyProfile})
          })
        }>
            <Image
              source={{uri: this.state.thumb}}
              style={[styles.thumb, {borderWidth: 1, borderColor: 'white'}]}
            />
          </TouchableOpacity>
        </View>
      </BlurView>
    </Image>
  </View>
</ScrollView>

Try moving ScrollView inside BlurView

Any updates on it? Can I close this one?

I have this issue too. If you have a BlurView/BlurViews inside a ScrollView then it will drop frames when you scroll.


Add the Carl-Orff-Gymnasium Unterschleißheim

Official website: https://www.carl-orff-gym.de/
Development-related courses: Homepageteam (Group of students that manages the webpage, a year or longer), Course "Creating a game" ("Computerspiel") (2 years).
If an additional proof-of-usage is needed, please send an E-Mail to<EMAIL_ADDRESS>so that we can provide you with an contact to our system administrator.

@timschumi Pull request merged. Thank you!


[FRE-1048] Add nice error messages for sourceAsset/destination asset/amount undefined

Add nice error messages for sourceAsset/destination asset/amount undefined
Change text to say "select asset" to match other terminology
https://github.com/user-attachments/assets/632d58a6-fcfe-44ac-82fa-dd287f4e7650

we weill have a flow that without selecting source asset they can connect a wallet


Analysis impossible

Hi, I am the one who asked about https://github.com/arguslab/Argus-SAF/issues/16.
I wrote an application on your framework which collects only interested components and goes a deeper analysis (using idfg and iddg) on them.
It works really good for very small apps. However, when doing the same for normal apps, the framework stops and gives me nothing.
I tested many times and waited for a very long time. (50 different apps and more than 10 hours for each app)
I would really like to use your framework to finish my work, thus, be very appreciated if you kindly give me a solution.
Thanks.

You can limit the analysis time for each component you are interested.
Say there are 10 components you are interested for app A.
You can give the IDFG building process a timeout=5mins, then the overall time for app A will take 50 mins or less.

Sorry for late response and appreciate your kind answer.
Now I ended up excluding components with relatively large size by giving 5 minute timeout,
as those components that are not anlayzable within 5 minute are very likely also not to be successfully analyzed even if I give no timeout.
I will be working in this way for a while. In the meantime, I really look forward to having your next release as metioned in (https://github.com/arguslab/Argus-SAF/issues/14)
Thanks.

#14 almost done. It's in the develop branch apparently, and I have to add more test.

Duplicate of #14


Impossible to create new table when running docker version

Describe the bug
When running docker version there is impossible to create table in the "System Setting" menu
To Reproduce
Steps to reproduce the behavior:
Perform operation for installing APP
$ git clone https://github.com/itsalb3rt/cloudcsv.git $ docker-compose up
Perform operation for installing API
$ git clone https://github.com/itsalb3rt/cloudcsv_api.git $ docker-compose up

Create new user,
login,
navigate to "System Setting"
Find the "Manage tables" sections
Click "Create table" button
Choose some columns names, types and name (ex 3.)
Try to click save button

Expected behavior
Table should be created
Movie from reproducing issue and error that appears:
"DATA NO IN API DOCUMENTATION FORMAT   CERRAR"
https://www.youtube.com/watch?v=beaBTLE94mc
Desktop (please complete the following information):
OS: Tried on both: Centos and Linux Mint
Browser, Firefox, Chrome

Thanks! I check this asap.

Fixed in #46

Thank you! Best regards :)

ĥmmm have the changes been commited to docker repo? I still experience it unfortunately.
(Yes I performed docker stop + docker rm on all old instances and performed new installation)

Make a sure you have a new version code of master branch;

Try git pull origin master
Try to remove the project directory and clone again

I double checked this and still experience this issue :(

Try to get the API response like this video and show me the server response.

Any news @CryptoNGuns ? 👀

"Method not allowed" message appears in the firefox console:

For the information in the tab of the window, you have an old version of the UI, please run git pull origin master and build again the frontend.


Multiple configurations assets issue with ng serve

Command
serve
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
I develop a white label app that should be used by multiple clients. As each client might have multiple environment I set each client assets in a common build configurations as it's persistent across environments and use multiple configuration for ng serve. For example
"clientA": {
    "assets": [
        "src/favicon.ico",
        {
            "glob": "**/*",
            "input": "src/environments/clientA/assets/",
            "output": "/assets/"
        },
        {
            "glob": "**/*",
            "input": "src/assets/",
            "output": "/assets/"
        }
    ]
},
"clientA-staging": {
    "fileReplacements": [
        {
            "replace": "src/environments/environment.ts",
            "with": "src/environments/clientA/environment.staging.ts"
        }
    ]
},

Serving clientA is used with ng serve configuration clientA,clientA-staging. For some reason seems like the assets from src/environments/clientA/assets/ are not included and I see that the browser get 404 error when trying to download an asset from there.
What makes me think it is a bug with ng serve is that when building the app using  ng build configuration clientA,clientA-staging I see the assets from src/environments/clientA/assets/ are included in the build under the assets folder and that everything working as expected when serving the produced build in a docker.
Also note that when changing the order and running ng serve configuration clientA-staging,clientA everything working as expected.
When used ng serve configuration clientA,clientA-staging --verbose to try see some logs I see the log GET /assets/images/brand-logo-light.svg because the client does not accept HTML. ( brand-logo-light.svg is originated from src/environments/clientA/assets/) but I really cant tell if it's related.
Minimal Reproduction
Create similar build configuration hierarchy as described.
Try serving the app using ng serve with multiple configurations.
See if the assets are shown correctly.
Simple Github repository that reproduce the issue can be found here:
https://github.com/OmerSec/repro-assets-issue-app
Exception or Error

Your Environment
Angular CLI: 18.2.5
Node: 18.19.1
Package Manager: npm 10.2.4
OS: darwin arm64

Angular: 18.2.5
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, localize, material, platform-browser
... platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1802.5
@angular-devkit/build-angular   18.2.5
@angular-devkit/core            18.2.5
@angular-devkit/schematics      18.2.5
@schematics/angular             18.2.5
rxjs                            7.8.1
typescript                      5.5.4
zone.js                         0.14.10

Anything else relevant?
No response

This seems like a bug but we'll need to look at a reproduction to find and fix the problem. Can you setup a minimal repro please?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.
This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

@alan-agius4 Simple Github repository that reproduce the issue can be found here:
https://github.com/OmerSec/repro-assets-issue-app

This is working as intended.
When you run the command ng serve --configuration clientA,clientA-staging, the buildTarget configuration is overridden sequentially from left to right. As a result, the effective target becomes repro-assets-issue-app:build:clientA-staging.
For more details, refer to the https://angular.dev/reference/configs/workspace-config#alternate-build-configurations.
To address this, you can update your configuration to something like this:
"serve": {
  "builder": "@angular-devkit/build-angular:dev-server",
  "options": {
    "buildTarget": "repro-assets-issue-app:build"
  },
  "configurations": {
    "production": {
      "buildTarget": "repro-assets-issue-app:build:production"
    },
    "development": {
      "buildTarget": "repro-assets-issue-app:build:development"
    },
    "clientA": {
      "buildTarget": "repro-assets-issue-app:build:clientA"
    },
    "clientA-staging": {
      "buildTarget": "repro-assets-issue-app:build:clientA,clientA-staging"
    }
  },
  "defaultConfiguration": "development"
}

Then, invoke the command:
ng serve --configuration clientA-staging

Alternatively, you can specify the buildTarget directly in the command line:
ng serve --build-target repro-assets-issue-app:build:clientA,clientA-staging