Bug List

Go to -http://localhost/cartinhour/seller/promotions
below Search functionality , Offer expiry date spelling mistake.(UI)
Select all button-  After clicking, a pop is displayed in which there is alignment issue(UI)
Fix

http://localhost/cartinhour/seller/promotions
Select all button- show list and select all button overlapped

Remarks- Fixed

@bayapucg

@vasudevareddyreddem
Go to sign up page
Enter Valid Mobile no and register it
Navigate to   http://localhost/cartinhour/seller/adddetails/categories
Mandatory- If Category field left blank and Add your Category is filled then it  should move to next page

@bayapucg

Comment- All pop up messages will be in center

@vasudevareddyreddem
Seller Part- Once login into the account
Go to the show Ups Category
Clink on all sub category where 3 links are broken

@vasudevareddyreddem

Submit Button issue- After uploading the image, click on submit button
Actual result- submit button is not working

@vasudevareddyreddem @raghavacharee @bayapucg

Once clicking, there is an issue in dropdwon

@bayapucg
http://localhost/cartinhour/seller/personnel_details
Store detail and personal details update issue
while updating its redirected to basic details

@vasudevareddyreddem
Any of the field should be mandatory

@vasudevareddyreddem @raghavacharee

@vasudevareddyreddem @raghavacharee @bayapucg
Message should be like- Password should be atleast 6 character

Inventory and Seller Both Buglist

Seller Issue:-

cartinhour.com/seller/login
UI-scrolling login screen

http://cartinhour.com/seller/login#contact_sc
UI- after sending message, login scree is shiverred.

http://cartinhour.com/seller/login#contact_sc
Functionality- message sent from seller is not received in inventory.

http://cartinhour.com/seller/adddetails/setpassword
Funtionality- Back button should be there before confirming password.

http://cartinhour.com/seller/products/create

6.http://cartinhour.com/seller/personnel_details
Functionality- Submit button is not working

Notification- While creating the profile, notification should be displayed.

8.http://cartinhour.com/seller/Personnel_details
UI- field misplaced while

http://cartinhour.com/seller/Personnel_details
UI- desining issue

http://cartinhour.com/seller/Personnel_details
functionality - Field is not displayed while accepting yes.

11.http://cartinhour.com/seller/login
UI-SignIn and Register Fields alignment issue.

http://cartinhour.com/seller/login
Functionality- After login, leave that account  for an hour, logout option disappears.

scenario- complete signup process
then use this link as trial link-http://cartinhour.com/seller/adddetails/setpassword
then set a new password
result- password changes
Expected Result- It should redirect to login page

Unable to signin- Mail and msg is not gone through.

http://cartinhour.com/seller/products/create
UI- Spelling mistake after updating product.

http://cartinhour.com/seller/Personnel_details
UI-update profile page- case sensitive issue

http://cartinhour.com/seller/Personnel_details
UI- Browse File

http://cartinhour.com/seller/Personnel_details
Functionality- Files uploaded but shown as no file selected.
Functionality- Files uploaded but shown as no file selected.

http://cartinhour.com/seller/Personnel_details
UI- UI issue

dista

UI

UI

Functionality

Functionlaity

Functionalty

Functionality-

Functionality-

Functionality

Functionality

Functionality

Funtionality

Functionality

Functionality

Functionality

Functionality

Functionality

UI-

UI-
Last name should not be mandatory

Funtionality- Major bug
Scenario- while signUp add category as FOOD
again signup with different id and add category as FOOD
then the seller id is shown as same

UI

Functionality-
Calculation wrong

UI

Functionality

UI
update profile is not present

Functionality-How many seller register, notification should be there

Functionality- duplication

Functionality- duplication

Functionality- duplication

Functionality- Quantity should be added for each Seller as Fashion, So for it how many products are there must be listed out

Functionality

Funtionality-

Validation needed in Add Listing

Functionality- Spelling wrong

Functionality- price or percentage

Functionality- Submit button is not working

Functionality- click on submit button first, a pop will displayed
then select product from drop down , pop up should not be displayed

Functionality- submit button is not working

Functionality- submit button issue

UI-

UI-Alignment Issue(Re-Open)

Functionality- it should be old password is required
New Password and confirm password- Password must be at

least six character

Functionality- it should be old password is required
New Password and confirm password- Password must be at

least six character

Functionality- it should be old password is required
New Password and confirm password- Password must be at

least six character

Functionality- it should be old password is required
New Password and confirm password- Password must be at

least six character

UI-Customer part

UI

UI-

UI- payment part is hidden

Functionality- aligned not p

roperly

Functionality- Remember me is not working

Seller- functionality in listing

Functionality- While  refreshing

Functionality- payment message should be popped up

Functionality- Footer Functionality is pending

Functionality- without changing the quantity, click on action button
Result- it is shown as quantity updated

Functionality- Spelling mistake

Functionality- Wrong calculation

Functionality- Link should be in bold

Functionlity- While clicking on the shopp

ing link, it should be redirected to same location which was opted at the begining.

Functionality- After Editing the offers only successful message must be displayed

Functionality- payment of item done even quantity was lesser than available quantity

Functionality- payment of item done even quantity was lesser than available quantity

Functionality- Scenario login with two different credential with two browser and purchase same item than available item, its allowed to purchase

Functionality- Price filter issue

Functionality- Spelling alignment issue

Functionality- product images issue

Functionality- While clicking aside its not being clicked

UI- Bar size UI issue

Functionality- Location issue , after selecting the location , click on select button
Actual Result- All location is not se

lected

Functionality- after comparing click on continue shopping but its not

Functionality- After Comparing the product click on My Shopping cart but its not

Functionality- Product out of stock but still added for shopping

Functionality- Product out of stock but still added for shopping

Functionality- Quantity as in negative integer

UI- Header me

nu bar issue

Functionality- Menu bar is incomplete

UI- Icon colour

UI- Spelling wrong

Functionality- percentage issue

Functionality- Price navigation issue

Functionality - Menu bar is missing in other page

Functionality - Menu bar is missing in other page

Functionality- item added in Top offers item is not displayed
splayed

Functionality- Password must be atleast 6 characters

Functionality- Item out of order but still shown  as Ready Stock

Ui-Issue

Functionality- mail is not activated for unable to login

UI- Cancel button is needed

Functionality- Compare products, once on listing the item cancel button should be there

Functionality- cancel butt

on should be there in compare products

Functionality- Cancel button should be there in Compare products

Functionality- Buy now button should be there

Functionality- Orderid must be as cartinid and space should be there

Functionality- Calculation wrong

Functionality- On clicking banner , its not being rotated

Functionality- Unable to change pic, no editing tabs

Functionality- Size navigation or option should be there

Functionality- Not getting reply to other side

UI- Font colour issue

Functionality- Go to an account then click on wishlist if no item in wishlist then it should be redirected to home page through link

functionality- Tool tip should be there

UI- Issue in home page

UI-Forgot Password

Functionality- Validation needed in forgot pas

sword page

Functionality- enter un registered email and click on submit, it should be asked for enter registered email id

Functionality- Password must be atleast six character

Functionality- items added in Seller Deals of the day Items List but showing as it added to banner

Functionality- banner added by the seller  is 4 and other seller has also have availability of 6

Functionality- While click ok listing its moved to top offers

Functionality- UI issue while searching

Functionality- Buy now button should be there in wishlist

UI- UI issue in order

UI- UI issue in sidebar

Functionality- Click on continue shopping in product page

UI- more spaces

UI- more gap

Functionality- Back button in Payment mode page

UI- Gaps are more as a reminder

Functionality(Seller)- It should be year

UI- Go to the category then select the product
now scroll
Result- roling stucked

Functionality- Name of the customer should be there

Functionality
Scenario-step 1
Step 2 -Login with same id in two different browser
Step 3 -buy same item with two different browser
Step 4- Now delete one item from any one and proceed for payment of that item which is not deleted
Actual Result- It should throw error message

Ui(inventory)- Shivvering in login screen

Functionality- Price should be changed according to quantity

UI

It should be changed , not visible properly

77.UI- blank

UI- Uniform size

UI - Issue when selecting instock

Functionality- While selecting offers , product got disappear

Functionality(Seller)- select item then move to another tab
Result-  submit button is active without selecting

functionality- Only integer

Functionality- Chat option should be there in customer part

Functionality(Seller). Expiry date is taken as back date

Functionality(seller)- Matter must be removed

UI(Seller)- UI issue in http://localhost/cartinhour/seller/Personnel_details

Functionality- add item to the wishlist then add to the cart from there itself
again delete item.
Now again add it
Result- item already added is shown as pop up

Functionality(Wishlist issue)- delete item and again add it
Result- Item is successfully deleted.

Functionality- Product was out of stock but added to wishlist

UI- http://localhost/cartinhour/category/productview/NQ==
Alignment issue

UI- Footer displace while moving to other tab

UI - Issue in compare product

UI- Compare the products consecutively then more spaces are t side bar

94- Functionality- Tracker should be removed and Wishlist icon should be present at the headerr

Functionality- mobile no has hyperlink ed

Functionality- Before login, if any user select item as wishlist and delete then there must be undo option

Functionality- Back button issue when on selecting the product , following error occured

Ui- Ui issue in homepage in Opera browser

UI- Message must be populated in center

Ui - Ui issue at the header on selecting the all locations

Functionality - image is not popped up

Functionality(seller

)Invalid message should pop up

Scenario- Login to Customer  then login to seller in same browser
Now logout from customer and then click to any link of seller, it is logged out

Functionality- Before login to customer , select the location then login to customer , It must be logged in as that location which was selected before login

Searching must be start from one letter also

UI-

Address Removal-

Functionality- Select that location where product is available then click to home link, it should be redirected to the same location

Functionality- Opt category from category list. Pop up should be removed

NEW BUG LISTS OF CUSTOMER

Font Size Issue-

Functionality- hovering it continously browser shiverring issue

UI- while decreasing the quantity,

browser is shivering

Functionality- while removing add to list message should be displayed

Seller Issue-

banner issue

UI- entry is less than 10 then no need of dropdown

Functionality-

redirected to other page without filling category details

Customer
5. upto 10 its shown only

Functionality- Spelling mistake

Inventory
Functionality

It should be thrown error message as , id is not registered

Customer
7. Scenario- Before login, select item then it must be redirected to item page after login

Functionality- banners are not moving by clicking

Functionality- More than 6 banners are displayed

Functionality- If item is out of stock then quantity update button should be disabled

Functionality.

If item is out of stock then add to cart button should b

e disabled

Functionality-
In stock and out stock issue

UI- Remove sale and featured

Functionality- In compare products, No same item should be displayed while comparing, if its differ in any of size, price or else,

then it should be shown

Seller
Font color issue

Functionality- Item is out of the stock but still proceed out link is activated

UI-Laptop(1920x1080)- Alignment is not proper
link- localhost/cartinhour/

UI- arrow is hidden in
http://localhost/cartinhour/inventory/homepagepreview

Functionality-

once adding category  from add listing it should display in drop down by making it active from inventory portal

Functionality- Success! Successfully Updated..(it should be only Successfully Updated)
http://localhost/cartinhour/seller/products

Functionality- Mention the location category list
example- For kphb which product is available

UI- Location issue

Functionality-  Availability of the product

Functionality(Customer)- Footer- Sign Up For Emails

24-Functionality-customer

http://localhost/cartinhour/customer/billing
First name and last name is combined

25.customer- price issue
http://localhost/cartinhour/customer/cart

Functionality-Link is not given

27- Functionality- Content needed after

successful payment

Functionality- Scrolling issue

Functionality-  10 item is allowed but more than that its added

UI- 1280×600
http://localhost/cartinhour/

Functionality-  Spelling mistakes

Functionality-Issue in changing the functionality while increasing or decreasing the quantity

UI -1280×600

Implementation- Notification about the product once it got finished
Scenario- once item is out of stock and it is added in wishlist then notification must be send to the respective customer.

Implementation- For Seller, divide as the local seller portal and others(national)

Functionality- email id

Functionality- Issue in search field

Functionality- alert button

http://localhost/cartinhour/customer/forgotpassword
cancel button is needed to redirect to login page

Functionality- http://localhost/cartinhour/customer/productlist/OTQ=
error after licking on category(food)

Functionality- Category added multiples time in Add listing

Functionality- SubCategory added multiples time in Add listing

My order- http://localhost/cartinhour/customer/orders
not working

41- Functionality- Before login, select the colour of the item then add to cart, it will redirect login page

functionality- issue in homepage

UI- issue in validating login screen

UI- in login page

UI- login screen

please update pop message  above the right of the header

Functionality- link is not working

Functionality

space needed

Functionality-space needed

UI- header

Functionality- In Add listing, special price has maximum price than price

Functionality- submit button has been activated without clicking on check box

New Seller Bugs

http://localhost/cartinhour/seller/adddetails/categories
Add your own category, Enter "FOOD" as category which is not present already
result-Please use another category name. It is already exist

Functionality
Password must be atleast 6 characters
it should be at least characters

3. Functionality
moving to first tab while saving


Wrong Token Scope for Typename

both tested, no diff:
"C_Cpp.enhancedColorization": "disabled"
"C_Cpp.enhancedColorization": "ebabled"
Colors for "T" and "y/x" in the following code are same; moreover, there's the same token scope!
    template<typename T>
    struct RstrPnt
    {
        RstrPnt() = default;
        RstrPnt(T y_, T x_)    : y(y_), x(x_) {}
        T y = 0;
        T x = 0;
    };

choosing T

choosing y

my settings.json's fragment

not sure when this was fixed, but it looks fixed now!


CRUD operations

I'm not seeing any content on how to update or create via sql?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f02ab33b-616c-7055-2375-43c700d609cd
Version Independent ID: 81d1c3e3-c920-61d2-2e5f-8ed42f91c778
Content: SQL queries for Azure Cosmos DB
Content Source: articles/cosmos-db/sql-api-sql-query.md
Service: cosmos-db
GitHub Login: @LalithaMV
Microsoft Alias: laviswa

@tiny-dancer as Mike mentioned, this doc: https://docs.microsoft.com/en-us/azure/cosmos-db/sql-api-dotnet-samples shows the .Net sample to perform CRUD operations on data stored in Azure Cosmos DB SQL API account. You can also find Java, Python and Node.js samples with the dropdown on the page.

#please-close

fyi, this post helped understand the core reason why crud was not in the sql docs: https://stackoverflow.com/a/50418764


Translate README to en-US

Thanks for your contribution, but we ended up using an internal translation. :+1:


ENH: update package version

Hi! This is the friendly automated conda-forge-webservice.
I've started a version update as instructed in #59.
I'm currently searching for new versions and will update this PR shortly if I find one! Thank you for waiting!
Fixes #59

I'm interested in the graphviz=8 thing

That's in one of the CI support files, not managed by us.


Keep session on refresh

When the user does a hard refresh (F5), the session is "lost". Would it be a good idea to add an option to store the session with ngCookie? Bare in mind I'm getting started with Angular and I might be doing things wrong, so it really is just a question.
edit: The other solution is probably just run Auth.currentUser() on the .run on Angular, but I would like to know your opinion on the matter. I hope I'm not bothering you guys too much.

Just a few tips for Angular + Devise beginners:
1. install rack-cors gem
# Gemfile
gem 'rack-cors', :require => 'rack/cors'

# application.rb
config.middleware.insert_before 0, "Rack::Cors" do
  allow do
    origins '*'
    resource '*', :headers => :any, :methods => [:get, :post, :delete, :put, :head]
  end
end

PS: don't put an ":options". If you do that, you won't be able to destroy sessions, because Angular will replace "delete" by "options" when communicating with another domain (and Devise won't recognize the "option" verb as a "delete")
PS II: don't forget to restart the server!!!
2. at your "config" (on Angular):
$httpProvider.defaults.withCredentials = true;

or a more extensive example:
angular.module('myModule', ['Devise'])
  .config(function(AuthProvider, $httpProvider) {
    $httpProvider.defaults.withCredentials = true;
  });

3. remove the CSRF protection from Rails (I know, I know...)
# application_controller.rb
# protect_from_forgery

PS: after do some tests and all it's working, you can use a better solution to deal with CSRF, like use this angular_rails_csrf gem (which doesn't worked for me, but maybe you have more luck).
PS II: "I don't recommend to disable CSRF protection, blah, blah, blah..." Yeah, me neither, it's just a test in order to troubleshooting why sessions are being lost after a refresh.
4. after a refresh, get the session back
angular.module('myModule', ['Devise'])
  .run(['Auth', function (Auth) {
    Auth.currentUser().then(function(user) {
      console.log(user);
      console.log(Auth._currentUser);
    });
  }]);

Thanks very much loureirorg


Don't JSON-encode provider config

See https://github.com/pulumi/pulumi/pull/15032 for context.

Should this code in kubernetes provider be changed? It synthesizes the @import annotation for custom resource properties.
https://github.com/pulumi/pulumi-kubernetes/blob/e49daf0ebf8b9a30de8853c363781166e687d3e7/sdk/java/src/main/java/com/pulumi/kubernetes/apiextensions/Util.java#L46-L50

@EronWright I think the CustomResource feature introduced in:
https://github.com/pulumi/pulumi-kubernetes/pull/3020/files#diff-842f1f409f5a9ae544bb27542564a1e90ccab80a818faa702731ac2048395e11
Is not actually affected, afaik, correct me if I am wrong it only affects custom resources that are not providers? The JSON encoding is only affecting explicit providers (and, as we found out, default providers), but I'm hoping it has no interaction with #3020.
Happy to discuss further.

We will need to add a flag here for a flagged rollout and resurrect this change.


newbie: use yara to detect malware on a Linux host

Hi,
i'm completely new to Yara so excuse asking basic stuff.
I have some image files from Linux virtual machines i'd like to scan for malware. I have a Ubuntu 22.04.03 box on which i installed Yara 4.1.3. I downloaded rules from https://gist.github.com/andreafortuna/29c6ea48adf3d45a979a78763cdc7ce9. But it seems the script which creates the rules is from 2018. Where can i get more recent rules ?
I started yara with:
yara -rNc malware_rules.yar /mnt/crispor-server/
I have e.g. output like this:
/mnt/crispor-server//usr/local/lib/python3.8/dist-packages/tensorflow/python/_pywrap_tensorflow_internal.so: 6
/mnt/crispor-server//home/crispor/crisporWebsite-master/genomes/hg38/hg38.fa.sa: 0
/mnt/crispor-server//usr/local/lib/python2.7/dist-packages/tensorflow_core/python/_pywrap_tensorflow_internal.so: 5
/mnt/crispor-server//home/crispor/crisporWebsite-master/genomes_test/mm39.fa: 0
/mnt/crispor-server//home/crispor/crisporWebsite-master/genomes/mm39/mm39.fa.bwt: 0
/mnt/crispor-server//home/crispor/crisporWebsite-master/genomes_test/hg38.fa: 0
/mnt/crispor-server//home/crispor/crisporWebsite-master/genomes/hg38/hg38.fa.bwt: 1
/mnt/crispor-server//home/crispor/CRISPR_Allele_Designer_Web/in/mgp.v3.snps.sorted.rsIDdbSNPv137.GRCm39.vcf.gz: 5
/mnt/crispor-server//home/crispor/CRISPR_Allele_Designer_Web/in/ORI/mgp.v3.snps.sorted.rsIDdbSNPv137.GRCm39.vcf.gz: 5

Does this mean that e.g. _pywrap_tensorflow_internal.so has 5 viruses (or something like this) ?
If it shows just that it found a certain pattern how do i know if it's malware or not ?
Or is yara not suitable for searching malware ?
Can you recommend other tools to find malware on Linux hosts ?
Thanks.
Bernd

I can't really help too much with this. A match from a YARA rule doesn't actually means that the file is malicious, it can be a false positive. There are a bunch of low-quality YARA rules on Internet that you could trigger with non-malicious file, or rules that are intentionally designed to find specific patterns that don't imply maliciousness. When using a set of YARA rules you must know what the rules are for. I don't recommend using YARA an an antivirus.


Gradle distribution needs to be updated in order to work with JDK v9

Is this a bug report?
Yes

Have you read the Contributing Guidelines?
Yes
Environment

Environment:
OS:  macOS Sierra 10.12.6
Node:  8.7.0
Yarn:  1.2.1
npm:  5.5.1
Watchman:  4.9.0
Xcode:  Xcode 9.0.1 Build version 9A1004
Android Studio:  2.3 AI-162.4069837
Packages: (wanted => installed)
react: 16.0.0-beta.5 => 16.0.0-beta.5
react-native: 0.49.3 => 0.49.3
Steps to Reproduce

Update to JDK version 9+
run react-native run-android

Expected Behavior

Should build android files correctly
Actual Behavior

Errors with following details
FAILURE: Build failed with an exception.

* What went wrong:
Could not determine java version from '9.0.1'.

Solution seems to be described here: https://discuss.gradle.org/t/could-not-determine-java-version-from-9-0-1/24457 I tried it and got past the error, but had issues when opening project in my android studio, so am not sure if further steps are required.

Get the same problem

This work for me:
Edit the file /android/gradle/wrapper/gradle-wrapper.properties and update the last line with:
distributionUrl=https\://services.gradle.org/distributions/gradle-4.3-rc-2-all.zip

So i update the gradle version used for project dependencies.

Opening project in android studio fixes this by prompting to update gradle version.

What it works for me was to rollback to Java8
brew cask uninstall java
brew tap caskroom/versions
brew cask install java8

Same with version '10'. "Could not determine java version from '10'.
"

get the same problem
FAILURE: Build failed with an exception.

What went wrong:
Could not determine java version from '10.0.1'.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/getting-started.html

that work for me
brew cask uninstall java brew tap caskroom/versions brew cask install java8

Same here...

For me, I change my java version to java 8. It's work.
This is Link @jorwan @ditsayakul

I had the error Could not determine java version from '10.0.2'.
I followed @alexanderkjeldaas 's advice and upgraded Gradle. This also made me update the minimum sdk version, but now react-native run-android smoothly opens the app on the emulator.
I still see the warning WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'. It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html, but at least the app runs for now

@Beamanator which gradle version are you using or how did you update your gradle? Am having the exact same error as yours.

@ajharry69 I'm using the following versions:
Android Studio: 3.1.3 (you didn't ask, but I'm just letting you know)
Emulator: Nexus 5, API level 26
Gradle distributionUrl: https://services.gradle.org/distributions/gradle-4.4-all.zip
-> Gradle Version: 4.4

Gradle refresh failed
Error:Could not resolve all dependencies for configuration ':app:debugAndroidTestRuntimeClasspath'.
Could not determine artifacts for com.android.support.test:runner:1.0.1
Could not get resource 'https://dl.google.com/dl/android/maven2/com/android/support/test/runner/1.0.1/runner-1.0.1.aar'.
Could not HEAD 'https://dl.google.com/dl/android/maven2/com/android/support/test/runner/1.0.1/runner-1.0.1.aar'.
dl.google.com

Closing this issue, because RN 0.56 uses gradle 4.x.

Same thing but for Java version 11.
$ react-native run-android
Scanning folders for symlinks in /Users/[redacted]/Code/[redacted]/node_modules (18ms)
JS server already running.
Building and installing the app on the device (cd android && ./gradlew installDebug)...

 FAILURE: Build failed with an exception.

 * What went wrong:
 Could not determine java version from '11'.

Problem solved by changing the line in gradle-wrapper.properties to distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-all.zip which is the latest version as of right now. Still other problems but this solves this one.

I follow danielsellergren latest comment installing:
distributionUrl=https://services.gradle.org/distributions/gradle-4.10.2-all.zip
Got new error when running 'npm run android'

What went wrong:
A problem occurred configuring project ':app'.

Failed to notify project evaluation listener.
javax/xml/bind/annotation/XmlSchema


update to go 1.17

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0%) to 73.333%

Totals

Change from base Build 363630742:
-0.0%

Covered Lines:
121

Relevant Lines:
165

💛  - Coveralls


⚠ Bofrost.at has degraded performance

In 2d8fff8, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1442 ms

Resolved: Bofrost.at performance has improved in d8aa6b1.


“people on” -> “users of”

Summary
@thymikee I changed my mind. I hope you are ok with this.
Test plan
yarn test

"developers on" would feel better IMO, I wouldn't call people writing the code a "user."
Though you could reasonably argue they are users of Jest, but the context of the message does not imply that.

@orta you are the native speaker. Mind sending a PR with better wording?

Of course


Brushup of the documentation

Documentation tends to be always the last thing developers pay attention to, and often what happens is that once a feature is complete and merged, one moves onto the next thing so documentation is never kept up to date. (A good way to avoid this is to force people to document their code by not allowing undocumented code to be merged in in the first place!)
A major issue in PySCF is that it is quite distinctively a developer code. Setting up calculations requires programming, and the user has to explicitly take care of things that happen automatically in other codes, such as the removal of linear dependencies. (I actually still look at the examples distributed as part of PySCF to set up my calculations!) This special characteristic means that documentation is hugely important.
In the old documentation, the tutorial(!) had a lot of specialized code and customizations, like

a function that printed out the occupations by symmetry in section 5.5.1, Hartree-Fock; this happens automatically in other codes, or
a hand-written implementation of unrestricted MP2 in section 5.5.2

While these examples underline the flexibility of PySCF, I'm not sure their proper place is in the tutorial chapter; a much better place would be in the developer documentation. The tutorial section should just consist of straightforward examples for professional quantum chemists, that is, people who already know what they want to do, and just want to see how to run that calculation with PySCF.
Of course, not all bases can be covered in the tutorial, so also the user documentation will have several examples on how to run a bit more complicated calculations with PySCF. As in the manuals for other programs, the user documentation should contain at least a minimal level of theory of what is done in the code and how the equations are solved along with any relevant citations.
Another issue with the current version of the documentation is that molecular and crystalline calculations are discussed together, which makes the documentation extremely hard to follow. The discussion should be started out with molecules - which are easier - and then continue in a new section to crystals, where the differences to molecular calculations can be discussed.
The user documentation should also not go too deep into the code. The code design belongs in the developer documentation section. The developer documentation is the "hard-core" version, with the class structures, coding styles, etc. The section builds on top of the user documentation, so the theory already presented in the user section does not need to be repeated; however, algorithmic details should be discussed at a deeper level in the developer section.

The alpha version of the documentation is now about done.
The next step is to check if it satisfies the specifications above.
Please read through the manual, and file tickets if anything is amiss.


Fix: Fixed FileNotFoundException in Recycle Bin watcher

Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

https://files-org.sentry.io/issues/5610462140/events/0d15202895df4621bcde5b01ed4bc2e6/

Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

Opened Files ...
...

@0x5bfa I don't think wrapping EnableRaisingEvents will help if the error doesn't occur until the watcher is already started.

Why not check before instancing it.

We check on line 51 but that doesn't seem to help.

This method doesn't work sometimes lol I'm wondering why.
It produces not found exception when CreateFile fails. Do you think we should have our own checker using that function?
// bool StorageHelper.IfExists(string path);
HANDLE hFile = CreateFileW(path, ...);
if (hFile == -1) return false;

It's something to look into


fix: salutation appended in title

Pre-Flight checklist

[x] Screenshots and design review for any changes that affect layout or styling
[ ] Migrations

[ ] Migration is backwards-compatible with current production code

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

[ ] Settings

[ ] New settings are documented and present in app.json
[ ] New settings have reasonable development defaults, if applicable
[ ] Opened issue for DevOps regarding necessary configuration changes to deployed environments

What are the relevant tickets?
Closes https://github.com/mitodl/ocw-studio/issues/1073
What's this PR do?

Appends salutation in title only when type is instructor and salutation is present in metadata

A util to append salutation with title is created in websites/utils.py
this util is called in save method of WebsiteContent model in websites/models.py
A test for this util has also been created.

How should this be manually tested?

Go to ocw-studio
Add a new instructor
Set a title without salutation and add salutation in metadata
Verify that, on saving, this salutation is appended with title
Save this instructor again and verify that salutation is not appended again if title already has a salutation.
Repeat the above steps for

ocw-studio/admin and ocw-studio/sites
Creating a new instructor and saving a new instructor

Screenshots (if appropriate)

Note:
Title is a different field from metadata which is set differently so I'm not sure whether it's a good solution to only take salutation from metadata and append it in the title.
In case of instructor, if title is instructor's full name, then I think, title should not be asked upon saving/updating instuctor, title should be auto-populated when instructor is saved/updated. (title = salutation + first_name + middle_name + last_name).
But since in the issue ticket, the expected behavior is: Salutation should be part of the instructor's title when added. so I have updated the save method, but I don't think this is a good approach as there might be some use-cases where this approach will cause few issues, maybe or maybe not.

Codecov Report

Merging #1105 (bc17e0e) into master (a92db71) will increase coverage by 4.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1105      +/-   ##
==========================================
+ Coverage   91.03%   95.37%   +4.34%
==========================================
  Files         206       98     -108
  Lines        7972     2683    -5289
  Branches     1377      553     -824
==========================================
- Hits         7257     2559    -4698
+ Misses        624      124     -500
+ Partials       91        0      -91

Impacted Files
Coverage Δ

websites/models.py

websites/utils.py

news/util.py

websites/factories.py

main/apps.py

videos/management/commands/youtube_tokens.py

content_sync/signals.py

main/__init__.py

...ev/management/commands/generate_example_configs.py

videos/views.py

... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a92db71...bc17e0e. Read the comment docs.

Oh... I didn't realize that studio uses the instructor's title field for the drop-down UI.
Does the course home page in ocw-hugo-themes use the instructor title as well? I'm actually more concerned with seeing the correct "Prof." there. I just assumed that ocw-studio and ocw-hugo-themes would use the same fields.

Does the course home page in ocw-hugo-themes use the instructor title as well?

I guess yes and I think we should get this title thing sorted (as mentioned above) for instructors to avoid such issue or confusion for the course author.
In another issue, related to displaying instructor's full name in search results, title was also used as full_name which was updated to include salutation, first, middle and last name etc in this PR

I'm a little uncomfortable special-casing the behavior for this object, but I guess it's OK.

I'm a little uncomfortable special-casing the behavior for this object, but I guess it's OK.

Is your concern related to the purpose of the title field in instructor object or it's related to special-casing a generic model/class (i.e: website content)?
I'm not sure whether we have any other option in this use case. Do you have any suggestions?

@alicewriteswrongs
Off-topic: Shouldn't this type field be a dropdown?

Am I correct in understanding that the only field we use, out of the whole instructor content type is title?

Am I correct in understanding that the only field we use -- in ocw-studio, and in ocw-hugo-themes -- out of the whole instructor content type is title?

I'm not very sure but I think yes. The only place where I could find first_name, last_name etc being used in studio is in this function import_ocw2hugo_sitemetadata and that's also to compute title

I'm wondering if we should just remove the other fields, to avoid user confusion.

This would be optimal, if the condition, you stated above, is fulfilled.
I guess @alicewriteswrongs or @carey might have better insight on this.

We could definitely remove the other fields and just have title. It is probably fairly surprising right now that you can change someone's name and not see it get reflected in the rendered site. If we did this, then we'd just have to communicate to the course authors that the title field needs to contain the full name + title for the instructors.

We could definitely remove the other fields and just have title

Thanks for confirming. I'll go on and update this PR to have only title field for instructors.

Thanks for you all for helping my understanding of this. We've decided that studio users should focus on the title and ignore the other fields.


Provide secure default hash function for SecureCookieSessionInterface digest_method

Expected Behavior
Default digest_method for SecureCookieSessionInterface should be provide strong collision resistance.  Ideally, upgrade default to sha-256 or better.
class SecureCookieSessionInterface(SessionInterface):
    """The default session interface that stores sessions in signed cookies
    through the :mod:`itsdangerous` module.
    """
    #: the salt that should be applied on top of the secret key for the
    #: signing of cookie based sessions.
    salt = 'cookie-session'
    #: the hash function to use for the signature.  The default is sha1
    digest_method = staticmethod(hashlib.sha1)

Actual Behavior
hashlib.sha1 is default and must be overridden by a custom SessionInterface in applications using flask.  It would be more secure to default to a stronger hash algorithm.
class CustomSecureCookieSessionInterface(SecureCookieSessionInterface):
    """"
    Custom override of flask.sessions.SecureCookieSessionInterface to use
    sha256 rather than sha1 for session signatures.
    """"
    digest_method = staticmethod(hashlib.sha256)```

app.session_interface = CustomSecureCookieSessionInterface()
### Environment

* Python version: 2, 3
* Flask version: all
* Werkzeug version: n/a

ItsDangerous uses HMAC for signing the data. As used in HMAC, SHA1 and even MD5 are still secure.
https://stackoverflow.com/a/42445426/400617


Add not-in-place implementations for several dataset transforms

Should we deprecate in-place versions of such methods?

@lhoestq I am not sure how to test dictionary_encode_column (in-place version was not tested before)

I can take a look at dictionary_encode_column tomorrow.
Although it's likely that it doesn't work then. It was added at the beginning of the lib and never tested nor used afaik.

Now let's update the documentation to use the new methods x)


packing up new version for homebrew formula

Hello!
Thanks for making such a great tool. I've made a homebrew formula around it, but I'm seeing an error when building, because it appears that the v1.0 release is two commits behind current HEAD. I can add some handling to work around this, but I figured I would ask if it was all right for me to create a v1.1.0 release for these commits before I write the work-around in the homebrew formula.
Thanks!

Hi, I've tagged the 1.1 release. Is this okay for you ?

I think that will work. Thanks!


Use multierr instead of k8s aggregate error

Also rewrite schemacompat_test.go to use table-driven tests
Based on non-blocking review feedback in #114

Rebasing this on top of https://github.com/kcp-dev/kcp/pull/122 (once it's merged) should fix all the lint issues (unless I introduced any new ones 😆 )
I'd be fine with introducing a new PR only to add table-driven tests, I can send that soon.

This branch is now based on changes in https://github.com/kcp-dev/kcp/pull/126/
This change is now basically: https://github.com/imjasonh/kcp/compare/table-driven..multierr


Publish to conda-forge

It would be good if felling was available in conda-forge
https://conda-forge.org/docs/maintainer/adding_pkgs.html

https://anaconda.org/conda-forge/felling published on Conda forge


perf(*) increase hard-coded LRU Lua cache sizes

Summary
Because those cache sizes are defined in number of units and not in
memory size, we must draw such an hypothesis as the ones described in
the related comments, and draw a conclusion from it, which is a
theoretical ideal cache size.
Full changelog

Increase LRU cache size for the router
Increase LRU cache size for the DB cache

LGTM. Mocking out a rough example of a match_t shows that 5000 entries would take around 10M of GC space (based on lj-gc-objs.sxx), but that varies widely with string reuse, API  definition, etc. This seems like a safe value.


Running tree kill with superuser via command interface

Hi,
I have a use case where I need to run tree-kill with elevated user privileges to kill a parent and its child processes.
One way to get this use case to work with tree-kill is to call it from the command line like this:
sudo treeKill [pid]
Thanks!

Hi Alice,
That should be pretty easy. Assuming you have NodeJS installed on your path, this ought to work:
#! /usr/bin/env node
kill = require('tree-kill')
kill(process.argv[2])

I'll consider adding a CLI command to the tree-kill package so it's easier to install

I'm done considering, consider it done. Update to v1.1.0 and you'll have a CLI.


[Feature Request] Overdue tasks?

I am not able to find the spot where the tasks I failed to accomplish yesterday and even before yesterday can be found? I would see a natural spot in the first column of the Date on the left of the Today column.
Am I missing something here, are they perhaps automatically moved to today going forward?

Hi @torstenkoepke
Thanks for asking.  They should appear at the top of the Today column above any tasks that are actually tagged for today.  The idea being that it will get steadily more annoying to see what you were planning to do today if you have a lot of incomplete tasks from previous days (my work board from my day job is like this).  Hope this makes sense.
I'll add something to the README to make this clear.
Thanks again
[closing, but feel free to re-open if needs be]


Add responseType as a concept to RCTNetworking, send binary data as base64

In preparation for Blob support (wherein binary XHR and WebSocket responses can be retained as native data blobs on the native side and JS receives a web-like opaque Blob object), this change makes RCTNetworking aware of the responseType that JS requests. A xhr.responseType of '' or 'text' translates to a native response type of 'text'. A xhr.responseType of arraybuffer translates to a native response type of base64, as we currently lack an API to transmit TypedArrays directly to JS. This is analogous to how the WebSocket module already works, and it's a lot more versatile and much less brittle than converting a JS string back to a TypedArray, which is what's currently going on.
Now that we don't always send text down to JS, JS consumers might still want to get progress updates about a binary download. This is what the 'progress' event is designed for, so this change also implements that. This change also follows the XHR spec with regards to xhr.response and xhr.responseText:

if the response type is 'text', xhr.responseText can be peeked at by the JS consumer. It will be updated periodically as the download progresses, so long as there's either an onreadystatechange or onprogress handler on the XHR.

if the response type is not 'text', xhr.responseText can't be access and xhr.response remains null until the response is fully received. 'progress' events containing response details (total bytes, downloaded so far) are dispatched if there's an onprogress handler.

Once Blobs are landed, xhr.responseType of 'blob' will correspond to the same native response type, which will cause RCTNetworking to only send a blob ID down to JS, which can then create a Blob object from that for consumers.
Test Plan: This change comes with extensive changes and expansions to the XHRExamples in UIExplorer. onprogress handler, onreadystatechange handler, and responseType = 'arraybuffer' can be switched on independently. I tested all combinations on both iOS and Android.

By analyzing the blame information on this pull request, we identified @davidaurelio and @nicklockwood to be potential reviewers.

@philikon amazing work
cc @javache

Edge case question: what happens if the requestType property is changed in-flight? That is legal until the request headers are received.

Edge case question: what happens if the requestType property is changed in-flight? That is legal until the request headers are received.

Ah, good point. I failed to address that, both in code and the PR comments. I know the spec says that it's legal until request headers are received, but how useful is that really? I think we should make it illegal to change after the request has been sent -- this PR here would fail horribly otherwise anyway. Supporting the narrow gap between request sent and headers received seems very little benefit for a whole lot of code complexity...

Yeah, I agree that it’s not worth implementing this. Just throw, or print a warning, that should be enough

Yeah, I agree that it’s not worth implementing this. Just throw, or print a warning, that should be enough

Done.
Who else should we get to review this so we can get it landed?

Ping?

@davidaurelio By assigning the PR it will show up in Pieter's diff queue - more visibility for this PR from our core contributor Philipp.

Objective-C and JS changes LGTM, maybe @andreicoman11 or @foghina can help out with the native Android changes.

lgtm, let’s wait for @foghina or @andreicoman11

Thanks for the review, @javache! Addressed your comments.

My comments are mostly questions because apparently our networking module is now a commentless monstrosity and I don't get how things work. Code looks good though. Please make sure to test uploading with progress as well (I think that was supported?).

My comments are mostly questions because apparently our networking module is now a commentless monstrosity and I don't get how things work.

:(
I can try and help document things some time.

Please make sure to test uploading with progress as well (I think that was supported?).

Yep. Still works. UIExplorer examples FTW :)

Thanks for the reviews and questions, everyone. Really appreciate it. If there are no more concerns or questions, would love it if somebody could pull the trigger and import it.

@facebook-github-bot import

Thanks for importing. If you are an FB employee go to Phabricator to review.

@philikon I’m on the internal failures. Making progress.

@philikon I’m on the internal failures. Making progress.

Eeek ok. Thanks! You know how to reach me if I can help with anything :)

@davidaurelio any updates? anything i can help with?

I’ve added a comment here: https://github.com/facebook/react-native/pull/8324#discussion_r69569757
hard to spot, as it didn’t show up at the bottom. Any idea what could cause that?

@philikon any idea what the underlying issue might be? @foghina can you take a look? --> https://github.com/facebook/react-native/pull/8324#discussion_r69569757

Thanks @davidaurelio! I replied to the comment.

Thank you for your pull request.  As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore.  In order for us to review and merge your code, please email<EMAIL_ADDRESS>with your details so we can update your status.


Syntax highlighting breaks for lines that have 'def'

Syntax highlighting breaks for lines that have 'def' in a variable name, like 'default'. Adding a check for a space after 'def' keyword in block regex

Looks fine to me. Thanks!


Enable one to override the file io by moving it to a_draw_stop

[x] Tests added / passed
[x] Passes black dask / flake8 dask

Closing in favor of #6938

Agreed


fix(@schematics/angular): stop offering SASS option for ng new

The old Sass language referred to as "SASS" here is no longer relevant. This was denoted with the file extension ".sass"
Any new projects should use the modern Sass language which is expressed in ".scss" files.
This change does not remove any support for projects which were already created with ".sass" files, we simply stop offering
this option when creating new projects.
Also correct the capitalization of Less based on how they spell it on their website.

Hi all,
With reading some related issues, I still don't understand the reason for dropping support to .sass files. This causes some trouble to ones who want to use the old indented-syntax (at least in newly generated projects). Is it dropped just because it is an old syntax? Could someone explain the reason for me, please?

I would also like to know the reason for dropping support to .sass files. Weren't .sass and .scss released at the same time? So it doesn't make sense to me to call .sass the old language.

I thought there was a bug (ng g c component-name --style=sass no longer works, either, it's producing scss files )
I can't believe they merged this...
What about those of us who prefer using the sass indented syntax?
This is really a problem for my workflow as I am using
let g:angular_cli_stylesheet_format = 'sass'
in my .vimrc file.
This really needs to be reverted.

I'm about to submit a bug and I found this. Could someone explain the reason why sass support was removed? You can remove a feature in Angular but please at least describe a little bit about the reason.

I'm about to submit a bug and I found this. Could someone explain the reason why sass support was removed? You can remove a feature in Angular but please at least describe a little bit about the reason.

This is already added back in about 10 days ago; see the reference to the previous comment.


failed to make an editable install

🐛 Bug Report
failed to make an editable install
🔬 How To Reproduce
Steps to reproduce the behavior:

system-wide it's Anaconda 3.8. there exists poetry, but it's not used as shown below
create an project using all default settings (named python-project)
in the project folder, create a setup.py as follows:

from setuptools import find_packages, setup

setup(
    name="python_project",
    version='0.0.1',

    author='author',

    packages=find_packages(where='python_project'),
    package_dir={'': 'python_project'}
)

in system-wide python & in project folder, run pip install -e ./
getting error:

ERROR: Command errored out with exit status 1:
     command: 'C:\Users\xxx\anaconda3\python.exe' -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\path-to\\python-project\\setup.py'"'"'; __file__='"'"'C:\\path-to\\python-pro
ject\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps
         cwd: C:\path-to\python-project\
    Complete output (3 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
    ModuleNotFoundError: No module named 'setuptools'
    ----------------------------------------
ERROR: Command errored out with exit status 1: 'C:\Users\xxx\anaconda3\python.exe' -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\path-to\\python-project\\setup.py'"'"'; __file__='"'"
'C:\\path-to\\python-project\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"
'"'))' develop --no-deps Check the logs for full command output.

delete pyproject.toml as well as related .pre-commit-config.yaml and .github;
run pip install -e ./ again and it succeeds.

Code sample
NA
Environment

OS: Win10 x64
Python version, get it with: Anaconda x64 3.8.8

Screenshots
NA
📈 Expected behavior
to create an editable install by just adding a setup.py file.
📎 Additional context
For my specific project, an editable install fits better as it involves pywin32.
I found a "fix" as follows:

comment out the build-backend = "poetry.core.masonry.api" line in pyproject.toml;
make an editable install with pip install -e . --no-use-pep517

Be aware of how conda interacts with poetry. The solution:
Create a new conda environment using a yaml file in which you install poetry into the conda environment:
conda env create -f condaenvironment.yaml
The condaenvironment.yaml file:
name: newenv
channels:
  - https://conda.anaconda.org/conda-forge
  - defaults
dependencies:
  - python>=3.6,<3.9
  - poetry=1.1.6
  - poetry-core=1.0.4

Then activate this new environment (conda activate newenv) and run within this environment make install. Do not use the standard system-wide poetry install!
Note that I fixed the poetry & poetry-core versions as the new releases are buggy and cause an error.


etcd-tester: record git commit hash at deployment

Since we have more than one testing cluster, we need to keep track of our deployment. In general, tester and agents share the same git commit, so we can keep git SHA hash in tester status.

/cc @xiang90 @heyitsanthony

We should get commit SHA from etcd agents (that actually talks to etcd binaries), rather than keeping track of this manually in client side. I will rework on this.


VASCO often missing when active companion

When traveling to planets, if VASCO is the player's active companion, he will often not show up to accompany the player. Possibly related to https://github.com/Starfield-Community-Patch/Starfield-Community-Patch/issues/86

Game Version
<IP_ADDRESS>
New Game
No
Reproduction Steps

Take VASCO as active companion
Fast travel to different planet surfaces

This was fixed officially by Bethesda.


Updated Settings.populateDefaults() to account for available columns

refs https://github.com/TryGhost/Ghost/issues/10318
Settings.populateDefaults() is run before migrations during Ghost's startup. This can cause problems when new settings table columns are added (and populated in default-settings.json) because populateDefaults() was using the model layer which assumes that those columns are available, resulting in ER_BAD_FIELD_ERROR: Unknown column type errors.

query the database for the available settings table columns
switch to using raw knex queries without Bookshelf for insertions so that we're in control of the columns that are added
use _.pick to skip any properties in default-settings.json that do not match to an available column - those columns will be added and populated by later migrations
moving away from using the model to insert settings has the side-effect of not emitting settings.added/edited and settings.x.added/edited events, this should be fine because populateDefaults() is called before anything else is set up and listening
added a call to populateDefaults() in our knex-migrator "before migration" hook so that we have consistent db state across both startup initialised migrations and manually triggered knex migrations

Updated to include a call to populateDefaults() after the db backup in our "before migration" knex-migrator hook. This ensures the db state is consistent across both startup initialised migrations and manually triggered knex migrations


Review "All Docs Issues" sheet

https://docs.google.com/spreadsheets/d/1EiTHe3GGe0VNUjc-tdbodKlozpE3mTqLKHEjejgfJi8/edit?usp=sharing

Reviewed and generally looks good to me except for one comment I added.


Why not progressive?

Guetzli generates only sequential (nonprogressive) JPEGs due to faster decompression speeds they offer.

I thought that image-heavy websites prefer progressive mode than sequential mode (facebook, instagram), etc). I haven't done bench marking myself, but how much faster is sequential mode in terms of decompression speed?

Decompression speed of progressive JPEGs is 10-200% slower; the slowdown is worse on underpowered devices. This matters even more when we have an image that is already cached on an underpowered mobile phone.

If you're more concerned about bandwidth than CPU time, you can use MozJPEG's jpegtran to losslessly convert Guetzli images to progressive. This even reduces file size further.

@robryk A website that is properly configured won't be serving small devices full-sized images, so your CPU concern won't have that much impact.  Also with HTTP2 PJEPGs could be rendered to screen faster regardless.

@tomByrer I would argue that a properly configured website will serve high density screens bigger images, if only because they have more pixels to display them. Coincidentally, those screens are often the smaller out there, in phones and tablets. So small devices are likely to get served bigger images than desktops and laptops.

@JasonMrX If you're using Windows, try jpegtran_do_plus.7z. It'll convert all images > Guetzli > jpegtran.

@pieroxy Often mobile will have different 'art direction' (cropping) than a desktop or even 4k site would have.
You're correct that DPI should be a concern for many web images; something I intend to address with progressive.  A full explanation is worthy of a blog post, not a GH-issues discussion ;)

Agreed. FYI I wrote a small piece a while back on how to compress images for high-dpi screens.
http://pieroxy.net/blog/2016/05/01/jpeg_compression_is_80_the_magic_quality_part_1_the_retina_screens.html

chances are that you will serve your bigger images to your slowest users. That doesn't sound right.

hehehe :)
Looking at your examples on my regular desktop 1080p, it would seem that retina-sized at higher compression would be best for both screen types.  Another article came to the same conclusion.

Looking at your examples on my regular desktop 1080p, it would seem that retina-sized at higher compression would be best for both screen types

... and would be much bigger than a lower compression of a non-retina version, so no, it was not my conclusion. :-)


Allow boto3 to determine the current profile name

A small fix to revert the changes that picks up the AWS_PROFILE environment variable and now lets boto3 decide, as highlighted in https://github.com/lyft/cartography/pull/272#discussion_r406471526
For a single account, boto3_session.profile_name will contain the correct value at https://github.com/lyft/cartography/blob/713cc5b3f9bc410e61ae5f7e595b15b39ab588bf/cartography/intel/aws/organizations.py#L27

@SecPrez Thoughts?
I'm think good with this PR because (1) it defers to boto3 for determining the credential source, and (2) we still have @rsclarke-vgw's change where we don't erroneously insist on using a 'default' profile that doesn't exist in the user's config.
There is a broader question though about how we want to manage params going forward (env vars versus CLI switches versus config files) and how should we be consistent.  We can all talk about that here in this thread or in Slack or some other venue.

@SecPrez Thoughts?
I think I'm good with this PR because (1) it defers to boto3 for determining the profile/credential source, and (2) we still have @rsclarke-vgw's other change where we don't erroneously insist on using a 'default' profile that doesn't exist in the user's config.
There is a broader question though about how we want to manage params going forward (env vars versus CLI switches versus config files) and how should we be consistent. We can all talk about that here in this thread or in Slack or some other venue.

Yes, I agree. This is what I do on my local dev environment


[Id][Tooltip] Multiple sibling IdProviders cause mirrored interactions

This is quite specific to storybook configurations because you wouldn't typically render more than one IdProvider inside an app.
Because of the crossover with storybook and snapshot testing, it makes sense to wrap a provider per story via decorators to stabilise the id, however that causes an interesting visual side effect when rendered inline with the docs addon.
The problem is that multiple instances of IdProvider increment in sync so there are duplicate identifiers on the page and the global machine just rolls with it.
https://user-images.githubusercontent.com/11708259/136595395-0705ed61-6fba-4804-a2a4-5dcd8c586780.mp4

Hey @andy-hook May be caused by these issues

https://discord.com/channels/752614004387610674/803656530259738674/911279133617688587
@jjenzz right?

Yeah, from @andy-hook:

This is quite specific to storybook configurations because you wouldn't typically render more than one IdProvider inside an app.

There should only be one IdProvider (to ensure uniqueness) but this issue was raised to see if there is a way we can improve this  storybook experience.
I will look into all of this during this week 🙏


FIX: Fix background color

Closes #259.
@drammock see if it works okay for you, if so feel free to merge

works, thanks!  Just waiting for AppVeyor


Limit by time

Hey @maxim-ge , could you clean up the commit and contains ONLY the relevant changes before marking this ready for review, which I don't think this is  true. Also, when you raise a PR, please make sure that it has the correct description so that reviews can see the intent of the change, approach, etc before looking into the detail. Thanks!


[AutoPR containerregistry/resource-manager] add Azure Container Registry policies api and update OperationDefinition

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3094

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/2774


Use a text-splitter that does not require GPU

The current text splitter uses gpt-2, which limits the performance when there is not access to a GPU. Swap this text splitter out with one that does not require a GPU.

There are a lot of choices here: https://python.langchain.com/docs/modules/data_connection/document_transformers/split_by_token


ToCompactString formats twice

This test:
#[test]
fn to_compact_string_formats_once() {
    #[derive(Default)]
    struct FormatMeOnce(Cell<bool>);

    impl fmt::Display for FormatMeOnce {
        fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
            if self.0.replace(true) {
                panic!("formatted twice!")
            }

            f.write_str("FormatMeOnce")
        }
    }

    assert_eq!(FormatMeOnce::default().to_compact_string(), "FormatMeOnce");
}

fails. This problem occurs in practice with Itertools::format(), since formatting consumes the iterator, so trying to format it twice panics.

The same problem reproduces for format_compact!().

That’s caused by this optimization:
https://github.com/ParkMyCar/compact_str/blob/9e00e7d6fcfd36a6f2608f3b09211128af10d64c/compact_str/src/traits.rs#L104
https://github.com/ParkMyCar/compact_str/blob/9e00e7d6fcfd36a6f2608f3b09211128af10d64c/compact_str/src/utility.rs#L6-L11
which looks sensible, but I think is incorrect to do for unknown types.

Hmmm I am the one who wrote this and I never realized that this could happen.
I guess we can simply remove the count(s), it would produce the correct behavior but less efficient for some types.

One alternative might be to specialize count(s) to do the optimization only for known-good types. The problem with that is that it’s impossible to do so for generic types like Vec<T> without true specialization.

Yeah, we already contain enough specialisation for all primitive types, so it is probably enough.

Good find! I think the proposed fix to remove the call to count(...) is the right one, especially since we have optimizations for other primitive types, I'll put up a PR shortly


Create Asclepius-clouds.netkan

EVE clouds for Asclepius

Remove the commas on lines 22 and 19.

Please change the existing file. Change the extentention to .netkan and update the info.
https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/Asclepius-clouds.kerbalstuff

Closing this as well. Thanks again.


Unpredictable SVG behaviour on iOS

Version

Phaser Version:
v3.12.0
Operating system:
iOS 10, iOS 11
Browser:
Safari

Description
As we discussed on Discord, some SVGs may break the expected behavior of other files on iOS Safari.
Example Test Code

Example URL:
http://test.kirillbunin.com/

Example URL which works on all devices, due to the removal of ball:
http://test.kirillbunin.com/index2.html

Download example
http://test.kirillbunin.com/package.zip

Screenshot of correct behaviour
http://test.kirillbunin.com/correct.png

Screnshot of bad iOS10 behaviour
http://test.kirillbunin.com/ios10.png

Screnshot of bad iOS11 behaviour
http://test.kirillbunin.com/ios11.jpg

Screnshot of bad iPad behaviour (provided by @hypertrifle, thx)
http://test.kirillbunin.com/ipad.png

Additional Information
This is debunk of my previous issue #3667 where I thought problem is in loading. By further research I now think it is in the way SVG behave.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Sorry, but am closing this issue off as it's been 4 years and we never found an easy way to resolve it at the time, and it hasn't been reported since, so I believe it's either no longer an issue (or such an edge case no-one else encountered it since)


Add files via upload

Please merge it and add hacktoberfest-accepted label

@clebsonf I have made the changes.
I don't have any image for the project, but I have added a reference link for the project

closes #2

Thank you @clebsonf

@fineanmol Thank you too! By the way, could you give the project one star? This helps to rank and reach new people.

@fineanmol Thank you too! By the way, could you give the project one star? This helps to rank and reach new people.

Definitely


Illumination Channel Controls

In addition to the led on-off behavior noted in #108, need to be able to use the left and right arrow keyboard keys to change slider settings (all sliders --  illumination intensity, gain, exposure). Ideal behavior would be one slider value increment per arrow press and jumping to continuous increase or decrease when arrow key held down for 2 sec (or so). This could also be implemented with arrow icons in the tool tray.

Customer requested Step and XY Stage arrows be active through keyboard arrows, moved to medium priority


feat: support avatar decorations

About
This PR adds support for avatar decorations
Checklist

[x] The pre-commit code linter has been run over all edited files to ensure the code is linted.
[x] I've ensured the change(s) work on 3.8.6 and higher.
[ ] I have added the versionadded, versionchanged and deprecated to any new or changed user-facing function I committed.

Pull-Request specification
I've made this pull request: (check all that apply)

[ ] For the documentation
[x] To add a new feature
[ ] As a general enhancement
[ ] As a refactor of the library/the library's code
[ ] To fix an existing bug
[ ] To resolve #ISSUENUMBER

This is:

[ ] A breaking change

Codecov Report
Patch coverage: 50.00% and project coverage change: -0.02 :warning:

Comparison is base (7629955) 47.73% compared to head (e5c6c84) 47.71%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##              5.x    #1329      +/-   ##
==========================================
- Coverage   47.73%   47.71%   -0.02%
==========================================
  Files         139      139
  Lines       14284    14289       +5
==========================================
  Hits         6818     6818
- Misses       7466     7471       +5

Impacted Files
Coverage Δ

interactions/models/discord/asset.py
45.45% <33.33%> (+0.21%)
:arrow_up:

interactions/models/discord/user.py
53.18% <66.66%> (+0.15%)
:arrow_up:

... and 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


logging protractor e2e logs to application insights

hi,
i have protractor e2e tests which run to test different workflows from user perspective.  As part of e2e test we have written some console.logs for debugging and trouble shooting purposes. Is there a way i could send this logs to application insights . This will help to write queries to answer questions like most failing paths etc.
I tried using application insight js lib but it was erroring out with some window underfined error.
please share if any links or pointers.  thanks you.

You can use trackTrace instead of console.log to send your telemetry as "log telemetry"


env proxy format.

Signed-off-by: Thomas Sjögren<EMAIL_ADDRESS>Proposed changes
Modify section about proxies.
Related issues (optional)
Fixes #4970

Believe it to be fixed.

Somehow you still had the original commit and added an empty one and a merge one. Not sure how! Anyway I checked out your branch, removed the empty commits, and amended the original commit to change the commit message. Should be fine now after Netlify builds.


Consume batches of messages

Hi
I am working in a consumer that consumes messages to a Apache Hadoop for analytics.
In my consumer I am using kafka-node with Kafka 0.8.2 and  I need to fetch messages in batches because I need to send more than one message at a time for Hadoop. For this I include in my consumer the configurations:
fetch.min.bytes and fetch.wait.max.ms.
With this configurations I see that my the messages are coming in fetches, but the lib (kafka-node)  is send one event 'message' per message. That I think that is right for 'message' event but I need a event that receives all the messages that was fetched.
I see that is in this function that the lib is separating messages:
function decodeMessageSet(topic, partition, messageSet, cb, maxTickMessages) {
    var set = [];
    var messageCount = 0;
    while (messageSet.length > 0) {
        var cur = 8 + 4 + 4 + 1 + 1 + 4 + 4;
        Binary.parse(messageSet)
            .word64bs('offset')
            .word32bs('messageSize')
            .tap(function (vars) {
                if (vars.messageSize > (messageSet.length - 12))
                    vars.partial = true;
            })
            .word32bs('crc')
            .word8bs('magicByte')
            .word8bs('attributes')
            .word32bs('key')
            .tap(function (vars) {
                if (vars.key === -1)  return;
                cur += vars.key;
                this.buffer('key', vars.key);
            })
            .word32bs('value')
            .tap(function (vars) {
                if (vars.value !== -1) {
                    cur += vars.value;
                    this.buffer('value', vars.value);
                } else {
                    vars.value = null;
                }
                if (!vars.partial && vars.offset !== null) {
                    messageCount++;
                    set.push(vars.offset);
                    if (!cb) return;
                    var codec = getCodec(vars.attributes);
                    if (!codec) {
                        return cb(null, 'message', {
                            topic: topic,
                            value: vars.value,
                            offset: vars.offset,
                            partition: partition,
                            key: vars.key
                        });
                    }
                    codec.decode(vars.value, function(error, inlineMessageSet) {
                        if (error) return; // Not sure where to report this
                        decodeMessageSet(topic, partition, inlineMessageSet, cb, maxTickMessages);
                    });
                }
            });
        // Defensive code around potential denial of service
        if (maxTickMessages && messageCount > maxTickMessages) break;
        messageSet = messageSet.slice(cur);
    }
    return set;
}

With this I think that is simple to create a function that send a array with other event ('messages') to get the array with all fetched messages.
It is possible???

I don't think you need to change the module to accomplish this. You should be able to feed the incoming messages into an array and when the done event is emitted send that batch off and clear that array.


Replace hyper-tls with hyper-rustls

hyper-tls uses native-tls, which behave differently on different platforms.
In particular, TLS 1.3 is not supported on Windows and macOS, which is an issue since more and more servers do not support older versions any more.
hyper-rustls uses rustls, which works consistently across platforms, and supports TLS 1.3
Fixes #74

thank you for opening this @jedisct1!
error: the lock file /Users/runner/work/Viceroy/Viceroy/cli/tests/trap-test/Cargo.lock needs to be updated but --locked was passed to prevent this

i believe CI is failing due to a rather minor problem, the lockfile in cli/tests/trap-test needs updating :slightly_smiling_face:

Hidden Cargo.lock updated :)


Update feedstock to new project name

Following the rename ofthe project to docs-versions-menu in #13, the conda feedstock will have to be updated

https://github.com/conda-forge/staged-recipes/pull/14394


Limit exists in the search documents result.

Description:
https://user-images.githubusercontent.com/50368758/236392854-de89a6d9-a5f3-42a9-b8e9-fde6cdcbad4e.mp4
Even if there are more search results, only up to 15 are shown.
And it seems that the search feature doesn't support 'like' search.
Why:

Supporting both pagination and text search simultaneously is challenging with only a database without introducing a search engine. Introducing a search engine can complicate the system, so we are currently not considering such an introduction.
The current document search implementation is based on prefixes and retrieves only the top 15 documents, without support for additional pagination.
However, we believe this approach may cause confusion for users, so it would be advisable to display information on the screen that informs users about the limitation of showing only 15 results.


2586 changing a table from public to private delete visualizations that still have permission

This fixes #2586. Since ACL is not removed when a visualization is made private, explicit permission must be revoked manually, just like when user grant it, but this is consistent with existing UI and we avoid deleting existing visualizations unnoticed. I've tested the full flow (create private table, share, create map with user b, make it public -keeps working-, make it private again -keeps working-, revoke permission -is destroyed-), looks good to me. @Kartones, @javisantana , CR or comments about anything I should've tested?

Frontend tests were OK :+1: (details)

The datasets used in the map were private right? so the named map was used. If yes, then I think is fine...
maybe just try doing some query from A to some table shared from B after playing with permissions, although they should work as no grants/revokes are performed.
:+1:

Yep, it was private, then shared, then public, then private, then revoked permissions and worked as expected.
I've also done some querying scenarios:

Query from new B map to private shared A table --> works, ok.
Revoked permissions --> B map is deleted, ok.
Retry 1 --> permission denied, ok.
Made table public and retry 1 --> permission denied, ok (no explicit grant).
Granted read again and retry 1 --> works, ok.
Made table private --> B map is still working, ok,
Granted write --> still working, ok.
Revoked permission (including map deletion warning) --> B map is deleted, ok.

@Kartones, final :+1:?

I think is a go, yes!

Thanks!


Empty console in OsX El capitan

Atom version: 1.12.3
Package version: 2.2.2
When i click on "plus" button ( or when i use the command ) i always get a blank console with the blink cursor.
I have this error in logs
task.coffee:86 Path must be a string. Received null TypeError: Path must be a string. Received null     at assertPath (path.js:7:11)     at Object.basename (path.js:1357:5)     at Object.module.exports (/Users/kliton/.atom/packages/platformio-ide-terminal/lib/process.coffee:32:24)     at process.<anonymous> (/private/var/folders/sc/7b8zrdl50tndgslkx5_dl_k00000gn/T/AppTranslocation/642A8C95-3A78-4376-BADA-7048AB70BD5D/d/Atom.app/Contents/Resources/app.asar/src/task-bootstrap.js:84:10)     at emitTwo (events.js:106:13)     at process.emit (events.js:191:7)     at process.nextTick (internal/child_process.js:719:12)     at _combinedTickCallback (internal/process/next_tick.js:67:7)     at process._tickCallback (internal/process/next_tick.js:98:9)

I am also seeing this in Atom 1.13.1, Package version 2.2.2.


HumanCount formatting for per_sec?

Using rc.6, the f64 per_sec ProgressStyle key renders without commas if used in a template. And one cannot use HumanCount as it only accepts u64.
What is the best way to render per_sec with commas using the library?

You can probably wire something up with custom format keys. I'd also be open to a PR that improves on this.


Explore using Append Blobs in Long Term Storage

Append Blobs seem to be a better match for the type of work we are doing in the .NET event processor for long-term storage.
Let's do some research and spiking to see what is involved in replacing our block blobs with append blobs.

https://msdn.microsoft.com/en-us/library/azure/ee691964.aspx
The main difference id that AppendBlob does not expose anything about the number of blocks it has internally nor it provides an equivalente method for DownloadBlockListAsync() which we are using to get the id's count.
As the same restriction apply to this blobs (4 MB X 50,000 blocks) we may need to store the count in a separate "Metadata" blob taking care of the possible concurrency issues.

The current implementation avoids concurrency issues by having a single blob per partition. If an instance of an event processor can acquire a lease on a partition. I don't recall what we were doing with DownloadBlockListAsync, since that does imply that we are continuing previous work.


Fixes #12771 - Support lowering user constructed expression with default

Add missing case to take into account ExpressionType.Default

Implement DefaultExpression equality by comparing the type
Add test to ensure ExpressionEqualityComparer works as expected with the new expression type
Add test to cover the expression example from the linked issue

Fixes #12771

I guess changing base branch in the github UI wasn't such a good idea :)


Control order of new TickerItems

This is for the context of sequencing TickerItems that is dynamically added into the Ticker. This is stuff that'll be more fleshed out in the future.


Or of two RunContainers can produce an under-sized BitmapContainer

Describe the bug
There is a very niche edge case, where or:ing two RunContainers can produce a BitmapContainer that is actually undersized, because it happens to serialize more efficiently than the resulting RunContainer. This container works perfectly fine in memory, but as soon as it gets serialized and we then try to deserialize it again, we will try to read the bytes as if they were of an ArrayContainer, because we determine this by cardinality. And obviously the result is garbage :D (if it doesn't just flat out fail during deserialization, which is what we originally observed).
To Reproduce
This is a bit of a pathological example that highlights the issue is possible. But we have observed it in real bitmaps that were created with the high-level APIs, not container level. They are just a bit too large to use as a test case for the library, so I hope the pathological example below will serve.
@Test
public void or6() {
  System.out.println("or6");
  RunContainer rc1 = new RunContainer();
  for (int i = 0; i < 6144; i += 6) {
    rc1.iadd(i, i+1);
  }

  RunContainer rc2 = new RunContainer();

  for (int i = 3; i < 6144; i += 6) {
    rc2.iadd(i, i+1);
  }

  Container result = rc1.or(rc2);
  assertTrue(result.getCardinality() < ArrayContainer.DEFAULT_MAX_SIZE);
  assertTrue(result instanceof ArrayContainer);
}

RoaringBitmap version: 1.0.6-SNAPSHOT
I.e. I tested this on latest master.
Java version: openjdk version "11.0.12" 2021-07-20 LTS
Fix
I already have a fix and will post a PR with test and fix soon.

Thanks. This is a very serious issue. Very glad for the report.


Better ergonomics for WorldBorrow[Mut] API

Objective

Allow mapping a WorldBorrow[Mut]<T> to WorldBorrow[Mut]<U>
Allow cloning a WorldBorrow<T>

Consider the following example:
#[derive(Resource)]
struct SomeResource {
    some_field: Vec<u32>,
    some_other_field: Option<Vec<u32>>,
}

pub fn get_global_some_field(world: &WorldCell) -> Option<WorldBorrow<[u32]>> {
    Some(world.resource::<SomeResource>()?.map(|res| &res.some_field))
}

pub fn get_global_some_other_field(world: &WorldCell) -> Option<WorldBorrow<[u32]>> {
    Some(world.resource::<SomeResource>()?.try_map(|res| res.some_field.as_ref())?)
}

Previously it is very complicated to define the two accessor functions, because &[u32] must outlive the WorldBorrow<SomeResource>, and we have to e.g. return a wrapper around WorldBorrow<SomeResource> implementing Deref<[u16]>.
Now that we have two functions consuming WorldBorrows, it might also be desirable to keep the original borrow by cloning it beforehand. Therefore we implement Clone for WorldBorrow<T>.
Solution

map and try_map consumes self and moves the witness of borrow.
clone simply borrows the data again from the same world.

Unresolved Questions

map and try_map are introduced as functions instead of inherent methods

Official Guideline: https://rust-lang.github.io/api-guidelines/predictability.html#smart-pointers-do-not-add-inherent-methods-c-smart-ptr
But Mut::map_unchanged is already an inherent method, so there is an inconsistency

Changelog

Add map and try_map for WorldBorrow and WorldBorrowMut
Implement Clone for WorldBorrow
Technically this will break downstream code because borrow.clone() is now ambiguous

Migration Guide
WorldBorrow<T> now implements Clone. If you have code cloning the inner value behind a WorldBorrow:
let borrow: WorldBorrow<T>;
let cloned = borrow.clone(); // T

You need to explicitly dereference the borrow to clone the inner value:
let t_cloned = T::clone(&borrow); // or
let t_cloned = (*borrow).clone();

Now you may also clone the borrow itself:
let borrow_cloned = borrow.clone(); // or
let borrow_cloned = WorldBorrow::clone(&borrow);

WorldCell was removed in #12551, visit the linked PR for the rationale.


TiKV cannot send messages to PD after reconnect

Bug Report
What version of TiKV are you using?
Release Version:   4.1.0-alpha
Git Commit Hash:   18b87012ac3450e8037baaa61ea26a73c40ef33e
Git Commit Branch: master
UTC Build Time:    2020-03-17 08:39:08
Rust Version:      rustc 1.42.0-nightly (0de96d37f 2019-12-19)
Enable Features:   jemalloc portable sse protobuf-codec
Profile:           release
What operating system and CPU are you using?
not related
Steps to reproduce

run 1pd+1tikv
kill pd and restart after 10 seconds

What did you expect?
TiKV reconnect to PD and start region heartbeat.
What did happened?
no region hearbeats any more
log:

[2020/03/17 16:51:57.975 +08:00] [INFO] [<unknown>] ["Connect failed: {\"created\":\"@1584435117.975396682\",\"description\":\"Failed to connect to remote host: Connection refused\",\"errno\":111,\"file\":\"/home/menglong/.cargo/registry/src/github.com-1ecc6299db9ec823/grpcio-sys-0.5.0/grpc/src/core/lib/iomgr/tcp_client_posix.cc\",\"file_line\":200,\"os_error\":\"Connection refused\",\"syscall\":\"connect\",\"target_address\":\"ipv4:<IP_ADDRESS>:2379\"}"]
[2020/03/17 16:51:57.976 +08:00] [INFO] [<unknown>] ["Subchannel 0x7fd84f97f000: Retry in 1000 milliseconds"]
[2020/03/17 16:51:57.976 +08:00] [ERROR] [util.rs:315] ["request failed, retry"] [err="Grpc(RpcFailure(RpcStatus { status: 14-UNAVAILABLE, details: Some(\"failed to connect to all addresses\") }))"]
[2020/03/17 16:51:57.977 +08:00] [ERROR] [util.rs:315] ["request failed, retry"] [err="Grpc(RpcFailure(RpcStatus { status: 14-UNAVAILABLE, details: Some(\"failed to connect to all addresses\") }))"]
[2020/03/17 16:51:57.977 +08:00] [ERROR] [util.rs:315] ["request failed, retry"] [err="Grpc(RpcFailure(RpcStatus { status: 14-UNAVAILABLE, details: Some(\"failed to connect to all addresses\") }))"]
[2020/03/17 16:51:57.978 +08:00] [INFO] [util.rs:427] ["connecting to PD endpoint"] [endpoints=http://<IP_ADDRESS>:2379]
[2020/03/17 16:51:58.974 +08:00] [INFO] [<unknown>] ["Failed to connect to channel, retrying"]
[2020/03/17 16:52:03.577 +08:00] [INFO] [<unknown>] ["Connect failed: {\"created\":\"@1584435123.576942607\",\"description\":\"Failed to connect to remote host: Connection refused\",\"errno\":111,\"file\":\"/home/menglong/.cargo/registry/src/github.com-1ecc6299db9ec823/grpcio-sys-0.5.0/grpc/src/core/lib/iomgr/tcp_client_posix.cc\",\"file_line\":200,\"os_error\":\"Connection refused\",\"syscall\":\"connect\",\"target_address\":\"ipv4:<IP_ADDRESS>:2379\"}"]
[2020/03/17 16:52:03.577 +08:00] [INFO] [<unknown>] ["Subchannel 0x7fd84f97f000: Retry immediately"]
[2020/03/17 16:52:03.577 +08:00] [INFO] [<unknown>] ["Failed to connect to channel, retrying"]
[2020/03/17 16:52:08.577 +08:00] [INFO] [<unknown>] ["Connect failed: {\"created\":\"@1584435128.576987579\",\"description\":\"Failed to connect to remote host: Connection refused\",\"errno\":111,\"file\":\"/home/menglong/.cargo/registry/src/github.com-1ecc6299db9ec823/grpcio-sys-0.5.0/grpc/src/core/lib/iomgr/tcp_client_posix.cc\",\"file_line\":200,\"os_error\":\"Connection refused\",\"syscall\":\"connect\",\"target_address\":\"ipv4:<IP_ADDRESS>:2379\"}"]
[2020/03/17 16:52:08.578 +08:00] [INFO] [<unknown>] ["Subchannel 0x7fd84f97f000: Retry immediately"]
[2020/03/17 16:52:08.578 +08:00] [INFO] [<unknown>] ["Failed to connect to channel, retrying"]
[2020/03/17 16:52:13.577 +08:00] [INFO] [<unknown>] ["New connected subchannel at 0x7fd84bc030f0 for subchannel 0x7fd84f97f000"]

This bug may cause by the grpc, after pd had killed, if tikv issue a sync request like client.get_members_opt when try to reconnect, it will never return, which blocking the pd worker, even restart pd and the underlying new grpc connect was established, the pd worker still under blocking and can not handle any new task.

@NingLin-P can we downgrade grpc?

I had try the last used grpc version, but this still happen.

Does 3.0 have such issue?

Does 3.0 have such issue?

No, release-3.0 does not have such issue.


create a page for the new captcha

For:

https://github.com/casdoor/casdoor/pull/765
https://github.com/casdoor/casdoor/pull/833

@Resulte


Show cluster names to the user when running E2E test

We can show bootstrap cluster, management cluster, and workload cluster names when running E2E tests so that the user knows what to look for etc

Fixed in commit


Use Gradle version catalogs to have a single source of truth for dependency versions

I propose using Gradle's version catalogs to have a single source of truth for the project's dependency versions and also (hopefully) reduce the number of dependabot PRs for the same dependency in the project.
This feature should also be supported by gradle 8.9 which this project uses. See https://docs.gradle.org/8.9/userguide/platforms.html

Hey @calebkiage
We're already using that to share dependencies between main/java-8/android projects for each package.
I don't think we can use it across packages since they have different dependencies (e.g. azure identity authentication provider needs azure core that's not needed in other packages)
Can you provide more information on how you'd use this feature in addition to the current configuration please?

Ah scratch the last comment, I thought we were referring to a dependencies catalog, but eventually clicked on the link.
Yes a version catalog would be interesting. We should double check that dependenbot supports it first though.


Sketch too big

Problem Description
I'm attempting to run the bt_receiver_to_internal_dac example, but I'm running out of space on my ESP and getting a "Sketch too big" error. Is there a way to make the sketch smaller?
Device Description
ESP32 WROVER (FNK0060)
Sketch
/*
  Streaming data from Bluetooth to internal DAC of ESP32

  Copyright (C) 2020 Phil Schatzmann
  This program is free software: you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published by
  the Free Software Foundation, either version 3 of the License, or
  (at your option) any later version.
  This program is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU General Public License for more details.
  You should have received a copy of the GNU General Public License
  along with this program.  If not, see <http://www.gnu.org/licenses/>.
*/

// ==> Example to use built in DAC of ESP32

#include "AudioTools.h"
#include "BluetoothA2DPSink.h"

AnalogAudioStream out;
BluetoothA2DPSink a2dp_sink(out);

void setup() {
  a2dp_sink.start("InternalDAC");
}

void loop() {
}

Other Steps to Reproduce
No response
Provide your Version of the EP32 Arduino Core (or the IDF Version)
3.0.7
I have checked existing issues, discussions and online documentation

[X] I confirm I have checked existing issues, discussions and online documentation

https://github.com/pschatzmann/ESP32-A2DP/wiki/Program-Memory


Run CI for eth-bridge-integration and diff against master

PR for running CI of this integration branch against master

cargo fmt/clippy checks
catch conflicts with master early
see how the diff looks against master at any time

Maybe there is a better way to run full CI for every eth-bridge-integration merge (eg directly via ci.heliax.dev)


[WIP] Differential Expression - Gamma

#309
Quick implementation of DE in which the Gamma distribution is involved instead of rho.
Still WIP, as some functions are duplicated for now.
We also need synthetic datasets relative to DE as a whole to evaluate this work.
@adamgayoso

I wouldn't push this work before a full evaluation on simulated data. Let's work on that first.

Codecov Report

Merging #312 into master will increase coverage by 0.42%.
The diff coverage is 88.77%.

@@            Coverage Diff            @@
##           master    #312      +/-   ##
=========================================
+ Coverage   91.28%   91.7%   +0.42%
=========================================
  Files          31      31
  Lines        2547    2640      +93
=========================================
+ Hits         2325    2421      +96
+ Misses        222     219       -3

Impacted Files
Coverage Δ

scvi/inference/posterior.py
91.97% <88.77%> (-0.67%)
:arrow_down:

scvi/dataset/dataset.py
94.29% <0%> (+4.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 547c2bb...d596c42. Read the comment docs.


Pixel inspection UI: misses data in the beginning of a sector

It's because the first 3 days of the data has been truncated (show flux value at day 3 for skyview):
https://github.com/orionlee/tess_tpf_webapp/blob/2ea5e12184ca203bfb46739d04b68f5113bcbfe1/src/tpf/main.py#L752-L753
A version of the original tpf should be sent to pixel inspection UI instead.

Closed with d77c09d0cbffa613d4d57fe0a5136a7aeef654c6


2022-10-05 merge to main.

Codecov Report
Base: 99.58% // Head: 99.59% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (2867fa7) compared to base (a189271).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   99.58%   99.59%
=======================================
  Files         109      110    +1
  Lines        2184     2211   +27
  Branches      307      314    +7
=======================================
+ Hits         2175     2202   +27
  Misses          9        9

Impacted Files
Coverage Δ

...c/components/UsaBannerContent/UsaBannerContent.vue
100.00% <ø> (ø)

src/components/UsaChecklist/UsaChecklist.vue
100.00% <ø> (ø)

...c/components/UsaChecklistItem/UsaChecklistItem.vue
100.00% <ø> (ø)

...onents/UsaModalCloseButton/UsaModalCloseButton.vue
100.00% <ø> (ø)

src/components/UsaNav/UsaNav.vue
100.00% <ø> (ø)

...ents/UsaNavDropdownButton/UsaNavDropdownButton.vue
100.00% <ø> (ø)

src/components/UsaNavbar/UsaNavbar.vue
100.00% <ø> (ø)

src/components/UsaSelect/UsaSelect.vue
100.00% <ø> (ø)

...mponents/UsaTableSortButton/UsaTableSortButton.vue
100.00% <ø> (ø)

src/components/UsaBanner/UsaBanner.vue
100.00% <100.00%> (ø)

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Please support Podman

Is your feature request related to a problem? Please describe.
no
Describe the solution you'd like
Please support podman additionally to docker.
Describe alternatives you've considered
Only alternative I have found so far is cockpit, but it does not provide the same features as portainer does.
Additional context
Podman version 2.0.0 has been released with a new rest API and socket that can be used like the docker.sock
Block Post about apiv2:
https://podman.io/blogs/2020/01/17/podman-new-api.html
API Reference:
https://docs.podman.io/en/latest/_static/api.html

I'll close this as a duplicate request, feel free to comment your info on the existing ssue #2991


feat: remove support for VS2015 in Node.js >=19

Refs: https://github.com/nodejs/node/issues/37472

/cc @nodejs/build @nodejs/npm @nodejs/releasers
We will need to coordinate an npm release with this change, its inclusion in v19.0.0, and adaptations to the Node.js CI.

I think this is something we should do regardless of issues with V8, to prepare users for Node.js 20. Visual Studio 2015 will be out of support on Oct 14, 2025, before the 20.x EoL.

I thought about it but since it only applies to an unreleased version of node, I thought it could not really break anyone

But feel free to land as breaking, I have no strong opinion on that

Ah good point about it referring to an unreleased version. I'm okay with it landing just as a feat (i.e. Node.js 19 support).


Support windows

Just some changes to make it possible to clone and build the repo on Windows.

Rename aux.rs to auxilary.rs since aux is a reserved name on Windows.
Place unix socket code behind platform flag.

🙏  thanks!