Fixing tricksy Android 2.3 bug

Should be clear from the comment, but needs some sanity checking, worried about false positives.

 I have a hangover.

The dreaded mid-week hangover

Sorry for not making a proper test case before now, I've added one to https://github.com/jakearchibald/mobile-boilerplate/tree/double-tap-bug - the bug exists on that branch, and goes away if you merge in my pull request.
I've made a quick video showing the bug on a Samsung Galaxy SII running Android 2.3.4 - http://www.youtube.com/watch?v=I7AlwsveqjE

thanks for the test cases and video :) I ran the same test on 2.3.3, can't really replicate the issue. But from the video, it shows the bug surely happens on 2.3.4.

It's possible that that particular mobile is... diseased or something, don't have any other 2.3.4 devices to test on.

I will tweet about this and ask more people to help test it.

Help needed to test a possible bug in Mobile Boilerplate on Android 2.3.4 and above.
Test case:

go to page http://www.highub.com/t/1.html
click on the link in the page
let us know where the page goes: a. a page with link to Google, b. directly goes to Google

Please help to let us know the result by commenting below, thanks :)

It goes to a. page with link to Google after alerting "hi"

2.3.7
Goes directly to Google for me in both Dolphin browser and stock browser

On 2.3.6:
1.) On first-load I see the link "This is a link to page 2".
2.) Click...
3.) The link-text changes to "This is a link to google"
4.) Without doing anything else, I'm redirected to www.google.com

v4.0.3. it goes directly go google.com

on 1.html link to 2.html
on 2 link to google click an loads google
Android 4.01

2.3.7, CyanogenMod 7 nightly (Nov. 16, Captivate):
Takes me to a link to Google, no additional redirect or alert.

2.3.7, CyanogenMod 7 HTC Vision
Takes me to the Goog on link click from 1.html

Hardware - Google Nexus One
OS - Android 2.3.6
Browser - Default
When i open http://www.highub.com/t/1.html i see the page written  "This is a link to page 2"

2.3.4
Takes me to a "This is a link to page 2", click link, next page shows "this is a link to Google", then redirects to Google.

I get redirected to Google on Android 2.2 sometimes too (htc desire), sometimes works as expected

I think it's pretty clear that this bug happens on more than one version of Android. I will proceed to merge the pull request. Thanks all :)

I wonder if this fix will break mobile devices with both touch screen and virtual mouse via keys, as some blackberries do. That way you could get a click event without a touchstart on a device that supports touch events.

Android 2.3.3, Galaxy S2
On first load I see "This is a link to page 2".
On click I see link "This is a link to Google".
Only when I click ut takes me to Google, without any message or alert.

Android 2.3.3, Galaxy S2
On first load I see "This is a link to page 2".
On click I see link "This is a link to Google".
Only when I click ut takes me to Google, without any message or alert.

Nice to see this fixed.  I ran across it 6 months ago & commented in the old MBP page comments (should've put it on here, sorry).  Ended up doing a caveman-ish fix to get by, but this is much better.


Restoring 4.12 subscription UI for backward compatibility

Signed-off-by: Gowtham Shanmugasundaram<EMAIL_ADDRESS>

/test odf-console-e2e-aws

/approve
/lgtm


BUG: When we fill details in feedback form and not select rating message shown Please Enter Your Details

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
When we fill message but not fill rating message should be Please select rating.
I will add that message when rating not seleted.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@himanshu-03 Can you assign me this issue ?

Hey @zalabhavy !
We need to change the whole page and it is assigned to someoone else.
Happy Coding ✨


performance regression 2023.08 -> 2023.09 to_zarr from netcdf4 open_mfdataset

What happened?
I'm probably doing something wrong, but I'm seeing a large performance regression from 08 to 09 when opening a set of NASA POWER netcdf files, reducing them to only a subset of variables, and then saving them as a zarr file. Updated, see comments below: The speed difference is actually most apparent on the call to .to_zarr().
Deleted: The regression is apparent just in the time to call open_mfdataset; this operation on a month worth of files went from about 3.5 seconds to 9 seconds between these two versions, and remains slow even with 2023.11.0.
One thing about my setup is that I'm reading the source files over NFS; the output zarr file is going to local fast temporary storage.
This regression coincides with https://github.com/pydata/xarray/pull/7948 which changed the chunking for netcdf4 files, but I'm not sure if that's the cause. The performance doesn't change if I use chunks={} or chunks='auto'.
I've tried this with dask 2023.08.0 through 2023.11.0 and there are no changes;
I'm using netcdf4 version 1.6.5.
The merra2 files are all lat/lon gridded and each represents a single day; I'm re-writing them to put multiple days in a one-month file:
netcdf power_901_daily_20230101_merra2_utc {
dimensions:
	lon = 576 ;
	lat = 361 ;
	time = UNLIMITED ; // (1 currently)
variables:
	double lon(lon) ;
		lon:_FillValue = -999. ;
		lon:long_name = "longitude" ;
		lon:units = "degrees_east" ;
		lon:standard_name = "longitude" ;
	double lat(lat) ;
		lat:_FillValue = -999. ;
		lat:long_name = "latitude" ;
		lat:units = "degrees_north" ;
		lat:standard_name = "latitude" ;
	double time(time) ;
		time:_FillValue = -999. ;
		time:long_name = "time" ;
		time:units = "days since 2023-01-01 00:00:00" ;
...
        double T2M(time, lat, lon) ;
                T2M:_FillValue = -999. ;
                T2M:least_significant_digit = 2LL ;
                T2M:units = "K" ;
                T2M:long_name = "Temperature at 2 Meters" ;
                T2M:standard_name = "Temperature_at_2_Meters" ;
                T2M:valid_min = 150. ;
                T2M:valid_max = 350. ;
                T2M:valid_range = 150., 350. ;

What did you expect to happen?
No response
Minimal Complete Verifiable Example
desired_fields = ["PRECTOTCORR", "T2M"]
met_files = glob.glob("power_091_daily_*_merra2_utc.nc")
df = xarray.open_mfdataset(met_files, chunks={'time': 1},
                          parallel=False).astype(np.float32)
pt = df[desired_fields]
pt.to_zarr("out.zarr", consolidated=True)

MVCE confirmation

[X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[ ] Complete example — the example is self-contained, including all data and the text of any traceback.
[ ] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[X] New issue — a search of GitHub Issues suggests this is not a duplicate.
[X] Recent environment — the issue occurs with the latest version of xarray and its dependencies.

Relevant log output
No response
Anything else we need to know?

Can we attribute on only the opening and not the writing?

Hmmmm.  Now I'm uncertain of my benchmarking of just the open; I may have messed up. Re-checking, I think you're right, it's actually the write:
Times are open / write.
      2023.08.0      2023.11.0      2023.10.0

m1    3.29 / 0.62    3.35 / 5.95    3.4 / 6.05
m2    1.84 / 0.47    2.66 / 5.28    1.7 / 5.23
m3    2.07 / 0.52    1.98 / 5.87    2.02 / 5.85

I know these are both important and difficult to produce a perfect MCVE (and generous of you to get this far already).
But I do think it's important to try and pin down exactly which part is slow — I think we can still minimize this case by a decent amount, even if it's not to something perfectly reproducible. If we produce a similarly shaped array and write that, has that also slowed down?

Nope. If I create a kinda sorta similar dataset synthetically using numpy and directly populate it as
ds = xarray.Dataset({"T2M": (["time", "lat", "lon"], temps),
                     "PRECTOTCORR": (["time", "lat", "lon"], precip)},
                    coords={"time": np.arange(grid[0]),
                            "lat": (np.arange(grid[1]) - 180.0)/4.0,
                            "lon": (np.arange(grid[2])/1.6 - 180.0)})

it writes in 0.07 seconds. (I assume some of what's happening is that it's only reading the original files during the write to zarr.)
If I force .load() to happen along with open_mfdataset, it gets a little weird. Under 2023.08 opening the first month takes 20 seconds and writing it takes 0.09. Under 2023.11, it took 161 seconds to open the first month (!), and then the write took 0.09 seconds. This still kinda suggests to me something weird is happening on open_mfdataset.

I've tried simplifying this in a few ways; none of the simplifications quite reflect the exact slowdown I'm seeing but they all have the direction the same. One test is opening a single POWER netcdf file and .load()ing it:
local xarray 2023.11.0 Elapsed: 4.925256
NFS xarray 2023.11.0 Elapsed: 4.680344
local xarray 2023.8.0 Elapsed: 0.919569
NFS xarray 2023.8.0 Elapsed: 0.645585

import xarray
import time

ncfile = "power_901_daily_20190801_merra2_utc.nc"

start = time.time()
df = xarray.open_mfdataset(ncfile).load()
end = time.time()
print(f"xarray {xarray.__version__} Elapsed: {end-start:02f}")

I've put a copy of two merra2 datafiles at

https://www.cs.cmu.edu/~dga/power_901_daily_20190801_merra2_utc.nc
https://www.cs.cmu.edu/~dga/power_901_daily_20190801_merra2_utc.nc

(they're each 16MB, wasn't sure github would appreciate that).
If I return it to the full but somewhat simplified example, I see times that aren't quite as bad as what I see with the multi-file example but it's still slower:
import xarray
import time

ncfile = "power_901_daily_20190801_merra2_utc.nc"

start = time.time()
df = xarray.open_mfdataset(ncfile)
df = df[["T2M", "PRECTOTCORR"]]
df.to_zarr("output.zarr", consolidated=True)
end = time.time()
print(f"xarray {xarray.__version__} Elapsed: {end-start:02f}")

local xarray 2023.11.0 Elapsed: 0.518345
local xarray 2023.8.0 Elapsed: 0.438258
nfs xarray 2023.11.0 Elapsed: 0.613554
nfs xarray 2023.8.0 Elapsed: 0.484871

And if I use two .nc files as the source, I see:
local 2023.8.0 Elapsed: 0.540353
nfs xarray 2023.8.0 Elapsed: 0.599314
local xarray 2023.11.0 Elapsed: 0.904065
nfs xarray 2023.11.0 Elapsed: 0.952745

So the degree of the problem seems to worsen when there are multiple files handed to open_mfdataset though it's present with only one file to a smaller degree. So this is, thus far, the simplest reproducer I've come up with:
import xarray
import time

ncfiles = ["power_901_daily_20190801_merra2_utc.nc", "power_901_daily_20190802_merra2_utc.nc"]

start = time.time()
df = xarray.open_mfdataset(ncfiles)
df = df[["T2M", "PRECTOTCORR"]]
df.to_zarr("output.zarr", consolidated=True)
end = time.time()
print(f"xarray {xarray.__version__} Elapsed: {end-start:02f}")

One test is opening a single POWER netcdf file and .load()ing it:

OK nice progress — so it does seem to be all in the .load() — am I reading that correctly? We don't need .to_zarr to show the problem?

It seems like it, but I don't know if there are weird performance gotchas with .load() as I don't use it in the production version of the code. But it seems like a weird regression on its own that open_mfdataset().load() would be that much slower and I assume it's at least tickling some of the same reasons.

Two more pointers that may help here:

Remove dask from the open_mfdataset case by setting chunks=False (e.g. open_mfdataset(ncfiles, chunks=False).
Drop encoding directly following each of your open_dataset or open_mfdataset calls e.g. open_mfdataset(ncfiles, chunks=False).reset_encoding() )

Ah, I think this is getting at it. With this simplified case, I went and checked all of the possible chunk settings again, and here, setting chunks='auto' does fix the regression.
xarray 2023.8.0 Elapsed: 0.534117 - chunks={'time': 1} and most other configurations

xarray 2023.11.0 Elapsed: 0.571602 - chunks='auto'
xarray 2023.11.0 Elapsed: 0.905893 - chunks={'time': 1}
xarray 2023.11.0 Elapsed: 0.856743 - chunks={'time':1}, reset_encoding
xarray 2023.11.0 Elapsed: 0.933716 - chunks=False
xarray 2023.11.0 Elapsed: 0.934985 - chunks={}
xarray 2023.11.0 Elapsed: 0.873481 - chunks=False, reset_encoding

With that result, I've now been able to rewrite the real code behind this example to also use chunks=auto by moving around some of the other processing. It's now performing in the same ballpark as it was under 0.8 (actually, in a nice outcome, it's faster, because part of the change I made was to use drop_variables to filter things at load time).
Thank you! I'm not sure if this is a bug or if it's .. pure user error or if it's not intended that the default would have a performance glitch across 2023.08 -> 2023.09, but I'm grateful for the suggestions and help working through this!

Could you show the "default" chunking behavior you were getting before setting chunks in open_mfdataset? To understand if there is a bug here, I'd like to understand what chunking you were getting in the default settings.

xarray 2023.11.0, auto, DF chunks Frozen({'time': (1, 1), 'lat': (361,), 'lon': (576,)})
xarray 2023.11.0, default, DF chunks Frozen({'time': (1, 1), 'lat': (36, 36, 36, 36, 36, 36, 36, 36, 36, 36, 1), 'lon': (72, 72, 72, 72, 72, 72, 72, 72)})
xarray 2023.8.0, default, DF chunks Frozen({'time': (1, 1), 'lat': (361,), 'lon': (576,)})
xarray 2023.8.0, auto,  DF chunks Frozen({'time': (1, 1), 'lat': (361,), 'lon': (576,)})
xarray 2023.8.0, chunks={'time': 1}, DF chunks Frozen({'time': (1, 1), 'lat': (361,), 'lon': (576,)})

Right. So this all makes sense now:
ncdump -hs ~/Downloads/power_901_daily_20190801_merra2_utc.nc
netcdf power_901_daily_20190801_merra2_utc {
dimensions:
	lon = 576 ;
	lat = 361 ;
	time = UNLIMITED ; // (1 currently)
variables:
	double lon(lon) ;
		lon:_FillValue = -999. ;
		lon:long_name = "longitude" ;
		lon:units = "degrees_east" ;
		lon:standard_name = "longitude" ;
		lon:_Storage = "contiguous" ;
		lon:_Endianness = "little" ;
	double lat(lat) ;
		lat:_FillValue = -999. ;
		lat:long_name = "latitude" ;
		lat:units = "degrees_north" ;
		lat:standard_name = "latitude" ;
		lat:_Storage = "contiguous" ;
		lat:_Endianness = "little" ;
	double time(time) ;
		time:_FillValue = -999. ;
		time:long_name = "time" ;
		time:units = "days since 2019-08-01 00:00:00" ;
		time:_Storage = "chunked" ;
		time:_ChunkSizes = 512 ;
		time:_Endianness = "little" ;
	double CDD10(time, lat, lon) ;
		CDD10:_FillValue = -999. ;
		CDD10:least_significant_digit = 1LL ;
		CDD10:units = "degree-day" ;
		CDD10:long_name = "Cooling Degree Days Above 10 C" ;
		CDD10:standard_name = "Cooling_Degree_Days_Above_10_C" ;
		CDD10:_Storage = "chunked" ;
		CDD10:_ChunkSizes = 1, 36, 72 ;
		CDD10:_Shuffle = "true" ;
		CDD10:_DeflateLevel = 4 ;
		CDD10:_Endianness = "little" ;

The file you shared has an internal chunk shape of CDD10:_ChunkSizes = 1, 36, 72 ;. These are very small chunks and are not efficient for Dask to work with. So I'm not surprised you get sub optimal behavior with these.
To the question of whether this is a bug, I don't think it is. The two relevant issues are GH1440 and PR7948. I believe you are getting the expected behavior, even if its sub optimal for your particular files.
What would actually be quite nice is if Xarray did a bit more work for you here and created chunks that were clean multiples of the internal chunks (e.g. https://github.com/pydata/xarray/issues/8021). We have an open ticket for that already so I think this could be closed.

Sounds good, and thank you both again.


[BUG] Access denied on Windows when attempting to delete a file created by Cython during the build

Describe the bug
When compiling on Windows, Cython seems to create a read-only file and then attempt to delete it, always resulting in an access denied error even when run from an administrator shell.
This is a new issue that seems to have started relatively recently without any changes in my build process. It also only appears on Windows, everything worked fine when I was testing on WSL.
Here's the relevant part of the build log:
    Generating code
    Finished generating code
    copying build\lib.win-amd64-3.9\cPyparsing.cp39-win_amd64.pyd ->
    error: could not delete 'cPyparsing.cp39-win_amd64.pyd': Access is denied

(and here is a gist with the full log)
The file it is attempting to delete here is one that it previously created in my build directory, and this error persists even when run as administrator. It's entirely possible I'm just doing something dumb, but if so I'm not sure what it could be.
To Reproduce
The Cython project I've been experiencing this error with is cPyparsing. It should be reproducible if you clone the repository and pip install -e . on Windows.
Expected behavior
At least when run as administrator, I shouldn't be seeing access denied errors.
Environment (please complete the following information):

OS: Windows 10
Python version: 3.9.7
Cython version: 0.29.24

Thanks for the report. Cython doesn't actually build the .pyd file itself, that's up to distutils/setuptools.
Can't say what's going wrong here right now, but it seems funny that it says "copying bla.pyd -> [NOTHING]". Shouldn't there be a file name in the end?

I just discovered that the part that follows -> is the relative path to which the file is to be copied. So -> [nothing] simply means the file is being moved to the current directory, since the relative path of the current directory is represented by an empty string, just as you'd see -> folder1\folder2 in case of the .pyd file being copied to folder1\folder2 where folder1 is a folder in the current directory.

Working dir cleanup (from temporary files) fixes this issue. I am using next sequence of git commands:
git reset
git checkout .
git clean -fdx

(do not forget to commit or stash any valuable changes before these commands execution)

Also all instancess of target Python interpreter must be finished before cleanup (see my comment above) and complilation. This means that you must finish you VSCode, PyCharm or other IDE as well.
The issue source seems to be in a difference between Linux and Windows approach: in Linux you are allowed to remove file of launched application or loaded .so file however you are not allowed to do the same in same situation on Windows.
Bit later I'll think what we can do about this. Unload .dll from target Python instance whould be perfect if possible. But script for reloading Python instance might be enough for a development purpose.


Compounding dice with L/H uses total of all rolls

When using compounding dice in conjuction with the H/L modifiers it calculates the values incorrectly.
Instead of using the Highest or Lowest roll, it sums all the rolls, and uses that, meaning that the compounded value returned is always 0 for -H/L and doubled for +H/L.
This works correctly:
2d6!!: [4, 14!!] = 18

These are incorrect:
2d6!!-L: [4, 14!!]-L = 0
2d6!!-H: [4, 14!!]-H = 0
2d6!!+L: [4, 14!!]+L = 36
2d6!!+H: [4, 14!!]+H = 36

It should be:
2d6!!-L: [4, 14!!]-L = 14
2d6!!-H: [4, 14!!]-H = 4
2d6!!+L: [4, 14!!]+L = 22
2d6!!+H: [4, 14!!]+H = 28

Instead of summing only rolls which compounded, it sums them all, so [4, 14!!] becomes [18!!]. So getting the max/min roll will always return 18 as it's now the only roll.
The roll array itself may look something like this:
[4, 6, 6, 2]

Where the last three are the compounded second roll.
Instead of summing the entire roll array, we only want to sum compounded rolls.

Thinking about this, it may actually be corrected. Once rolls have been compounded, then the compounded value should probably be taken as the defacto value.
I'll keep this open for now whilst I think about it.

I'm going to close this as not a bug. Compounded rolls are merged together into a single roll. Realistically, keep/drop modifiers on a compounding roll are incompatible.


feat: extend aws/cloudwatch with CloudWatch client

Summary
This adds the ability to get a CloudWatch client that can be used to manage alarms, metrics and dashboards.
The code was originally created by @whage as part of #229. This adds the automated tests.
Test results
go test -v -run TestNewCloudWatchClient
=== RUN   TestNewCloudWatchClient
=== PAUSE TestNewCloudWatchClient
=== RUN   TestNewCloudWatchClientE
=== PAUSE TestNewCloudWatchClientE
=== CONT  TestNewCloudWatchClient
=== CONT  TestNewCloudWatchClientE
TestNewCloudWatchClient 2021-07-27T15:08:59-04:00 region.go:92: Using region ap-south-1
TestNewCloudWatchClientE 2021-07-27T15:08:59-04:00 region.go:92: Using region eu-west-1
--- PASS: TestNewCloudWatchClient (0.00s)
--- PASS: TestNewCloudWatchClientE (0.00s)
PASS
ok      github.com/gruntwork-io/terratest/modules/aws   0.144s

Related issues
Closes #229
Closes #958

Updated test results with the require.NoError(t, err) change:
go test -v -run TestNewCloudWatchClient
=== RUN   TestNewCloudWatchClient
=== PAUSE TestNewCloudWatchClient
=== RUN   TestNewCloudWatchClientE
=== PAUSE TestNewCloudWatchClientE
=== CONT  TestNewCloudWatchClient
=== CONT  TestNewCloudWatchClientE
TestNewCloudWatchClient 2021-08-03T16:40:29-04:00 region.go:92: Using region ap-southeast-2
TestNewCloudWatchClientE 2021-08-03T16:40:29-04:00 region.go:92: Using region eu-west-3
--- PASS: TestNewCloudWatchClientE (0.00s)
--- PASS: TestNewCloudWatchClient (0.00s)
PASS
ok      github.com/gruntwork-io/terratest/modules/aws   0.365s

Was this closed without being merged in?

Looks like and to be honest, I don't remember why 😓
Feel free to copy my changes into a new PR the maintainers are still interested in them!


Is posible filter by minetype, type etc...?

I see good library
Is posible filter by minetype?
or type photos, anim-images and videos
By size min, max
Date determinate date, range of date, after, before a date...

Could be a nice extension.. Feel free to contibute or email me about it


doesn't work

undefined method state_event' for #Opportunity:0x007ff3cc49d258`
rails_admin do
  edit do
    field :state, :state
  end
  state({
    events: {completed: 'btn-danger', created: 'btn-warning', approved_by_agent: 'btn-success'},
    states: {complete: 'label-important', create: 'label-warning', approve_by_agent: 'label-success'}
  })
  end

try adding
  attr_accessor :state_event

to your model.

Added. Works. But I'm trying to understand how to use it. I see the label of current state and what is weird is: my state name is created, if I specify state: create - it shows in UI, if I specify as created - it doesn't.
2)I can't understand how to display buttons for events.

No worries - now it works as expected.
Only question - how to only add this field with the rest of the fields?

Another problem:
When events are called - > it doesn't save to db :-(

I include all fields + aasm field in this way:
    rails_admin do
      list do
        field :aasm_state, :state
        include_all_fields
      end

      edit do
        field :aasm_state, :state
        include_all_fields
      end
    end

i got erorr
 else
        match = match_attribute_method?(method.to_s)
        match ? attribute_missing(match, *args, &block) : super
      end
    end

@nakamuraagatha  can you post the error backtrace and how did you use this gem?


Update Data-Engineer course

https://www.udacity.com/course/data-engineer-nanodegree--nd027

There is no available syllabus with the exact courses listed. If you can find one, please reopen this issue and include it.
From this project's readme:
All of the Nanodegrees programs listed here meet the following criteria:

Nanodegree lists syllabus on it's public-facing (non-logged in) page
Links to each course in the syllabus are available on the public-facing Nanodegree page
Individual courses are available to take for free via their public facing course page


Fixed random key generation overflow

Problem was that encoded key did not have the right length. Sometimes the expression overflew as max index could be over passed.

Thanks for this fix. v2.0 branch fixes this, but going to get this out as 1.0.5 in the interim. I'm sorry for the error. Seems to have originated in a previous pull request.

Published v1.0.5.

 :)
On Sat, Jan 23, 2016 at 7:15 pm, Mark Bao <<EMAIL_ADDRESS><EMAIL_ADDRESS>> wrote:
Thanks for this fix. v2.0 branch fixes this, but going to get this out as 1.0.5
in the interim. I'm sorry for the error. Seems to have originated in a previous
pull request.
—
Reply to this email directly or view it on GitHub
[https://github.com/speakeasyjs/speakeasy/pull/48#issuecomment-174209741] .[https://github.com/notifications/beacon/ADUjJ8dmjDeJHPCD-tjbrQyk1xNqRyg4ks5pc7rBgaJpZM4HK7VZ.gif]


useWebKit is true by default [DOC]

I think, doc should state that the useWebKit, is true by default.
https://github.com/react-native-community/react-native-webview/blob/master/docs/Reference.md#useWebKit

Thanks for sharing this, helped figuring out why switching from the core version to this had some differences


Manually wrap output lines in HOWTO files

cf https://github.com/nltk/nltk/pull/2856#issuecomment-945193387

Hi @stevenbird , can i start working on this?

Is this issue still open?


add module stability by enabling library evolution support

Hi,
If you try to use SWXMLHash as a dependency in a Swift 5.1 based framework you will get the warning:
Module 'SWXMLHash' was not compiled with library evolution support; using it means binary compatibility for 'MyFramework' can't be guaranteed

To be able to use SWXMLHash using Swift >= 5.1 it need to be built with the flag BUILD_LIBRARY_FOR_DISTRIBUTION = YES.
This PR enable it on both the xcodeproj and on the podspec.
This is because otherwise during the pod install phase it will be ignored by cocoapods (see #9232)
For more information check this: ABI Stability and More and this: Binary Frameworks in Swift
Tested using Swift 5.1.3 and XCode 11.3 targetting an iOS project
Regards,
R.

FYI, see this post on Swift.org - https://swift.org/blog/library-evolution/
From that post, it says (emphasis mine):

Frameworks that are always built and distributed together, such as Swift Package Manager packages or binary frameworks that are internal to your app, should not be built with library evolution support.

and...

Library evolution support should only be used when a framework is going to be built and updated separately from its clients.

Even though many consume this library via CocoaPods or Carthage, I suspect the future direction for pure Swift libraries is via the Swift Package Manager meaning that their recommendations are to not enable this feature. In addition, I wouldn't expect any consumers of SWXMLHash to want to receive a new version of it without also updating both other dependencies and their app, too.
The reasons to not enable this are also mentioned on that post. See the paragraph beginning with:

Enabling library evolution support changes your framework’s performance characteristics...

I hope this helps! I appreciate your interest and contribution regardless. Thanks again!


Reorganize packages

Summary
Reorganizes packages as outlined in #4737.
Relevant Technical Choices
See #4737 for details
To-do
N/A
User-facing changes
N/A
Testing Instructions
N/A

Fixes #4737

@swissspidy Build and JS Unit tests are failing.

@spacedmonkey Yes, I am aware and working on it right now

@dvoytenko @barklund @carlos-kelly Friendly ping; any objections to moving files around like this? Basically moves all our JS "packages" to /assets/src

@swissspidy I think this is definitely an improvement. But TBH I think some sort of /packages/ or /modules/ structure, anchored closer to the root, would work better long-term. E.g.
/packages
    /editor
        /src
        /docs
        config.x.js
    /dashboard
        /src
        /docs
        config.x.js

@dvoytenko Agreed. I think a move from /assets/src to /packages is the next step. As mentioned in #4737, my hope here is to eventually use npm workspaces to achieve such a structure in a clean way. Each package/module can then declare its dependencies, config files, etc. while some parts (like the testing infrastructure) stay global

@swissspidy Sure. The staggered path to that layout makes sense and I think most of these changes help. But then I'd challenge a bit the move to assets/src/karma-puppeteer-client/index.cjs. I think that would slow you down. The karma tooling is already close to the root and looks like a mostly independent package. Not sure it helps you to move it to assets. It has quite a different configuration.

This way all the packages will be on the same level already, making the move from /assets/src to /packages easier in the future by mostly requiring search+replace and not having to deal with different directory levels.
Would you recommend leaving the karma packages as-is for now?
An alternative would be to just move eerything to /packages already in this PR, which would be trivial as well.

@swissspidy Yeah. My recommendation is to move first some "helper" packages such as karma to /packages/, try that out, etc. And then reorg assets contents there as well. But that's just my 2c. If you feel like this pr is still a better approach and others agree - I'll be definitely ok with that as well.

Given that npm 7 is already in RC, it indeed seems wiser to skip this step here and just gradually move over to /packages structure

closing in favor of #4853


Check org UUID exist check when list tenants

Purpose

$subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7798723384

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7798723384
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7801993815

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7801993815
Status: success


Any plan for Bootstrap 4 RTL Feature ? When It will Release ?

No plan yet :-)

@morteza do you have any update on Bootstrap 4 RTL support?
Regards,
kishor

Unfortunately no, not by me. But you can already find several alternatives for v4 :-)


Revisit #1017 Be even less intrusive when registering our Transformer…

@lburgazzoli made me think about #1017 again after merging the first attempt #1018. He asked which service files get embedded into the native image. The previous attempt vastly ignored the question and forced our factory via system property.
As a matter of fact, when multiple service files are available for the same path, using ServiceProviderBuildItem or NativeImageResourceBuildItem will always embed only one of them. There is not only no control which one is picked, but also the winner is different across GraalVM 19.3.1-java8, 19.3.1-java11, 20.0.0-java8 and 20.0.0-java11. So I am coming with the current proposal that pushes our preferred service file using low level GraaVM means. Using this mechanism, there is no need to mess with the system property and thus there is also no need to make it configurable (the user can use the system property on the command line to override our service file).

Is this also taking care of forcing our impl in jvm mode ?

Is this also taking care of forcing our impl in jvm mode ?

It makes its best to do so. Our service file is written to the app, where it should™ be seen as the first and thus be the only effective one: https://github.com/apache/camel-quarkus/pull/1027/files#diff-27a4882bb0ecf7b9d1f46376b12351e9R79-R82

Ah ok was confused because that core in the XalanNativeImageProcessor whereas it should probably bee moved to the XalanProcessor as it is not native specific

All tests from the failing group are passing for me locally.


[Question] - background threads resolving dbcontext

In the startup.cs for my ASP.NET Core 1.0 application, I Add my DbContext services in the usual mannor:
 services.AddDbContext<GcDbContext>(options => options.UseSqlServer(connectionString));

I then start a Hangfire job server running within the same process, which runs scheduled jobs on thread pool threads.
These jobs, are classes, that are activated via the ApplicationServices IServiceProvider.
I am noticing that when injecting my DbContext into these jobs, where there are two jobs running concurrently, they seem to be raising exceptions, because they are attempting to use the same DbContext instance.
My question.. Is this expected behaviour for injecting from ApplicationServices, or should I be seeing a new instance (transient) of a DbContext being injected each time?
Further technical details
EF Core version: 1.0.1
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10
IDE: Visual Studio 2015

@dazinator That call to AddDbContext will add your context as a scoped service. This means that:

You must ensure that a scope has been created before resolving the context. The context will be disposed when the scope is disposed.
Since the same context instance will be returned anywhere in the scope and the context is not thread-safe, you must ensure that only one thread is running for a given scope at a given time.

You might want to look into registering your context as transient instead--there is an overload of AddDbContext for that.

Thank you @ajcvickers - that's cleared things up for me.


Reference doesn't exist

The page references a Your First Day in Teams email in the Customer Success Kit, but there isn't any such email template included in those files

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3cdf3243-40dc-708c-cefc-8be68491a3be
Version Independent ID: 0fc81593-de9a-c453-4a1c-ec1ebbfe2ecf
Content: Support remote workers using Microsoft Teams - Microsoft Teams
Content Source: Teams/support-remote-work-with-teams.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@mgcharumilind Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@mgcharumilind thank you for reaching out and helping improve MS Docs. I've just had a look through the article and see it's been updated this week and there are quite a few templates in the kit.  Please could you confirm all in order.

No, the text on that page still does not match what's in the email templates in the customer success kit.

@mgcharumilind Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Make content scollbars work in React app for Safari and Firefox

Would be good to make the React UI look and work the same on all popular browsers. It now only works correctly on Chromium based browsers it seems. Please add support for Safari and Firefox.
I believe fixing this will make https://github.com/OpenTechFund/hypha/pull/2283 work on all browsers as well.

@frjo I got scrollbars in Firefox(version: Mozilla Firefox 86.0.1), checked on my ubuntu & mac. Could you share version of your mac & firefox?

Working for me as well now so closing this issue. Thanks for looking at it!


Consider removing otPlatRadioIdle() and associated logic.

Currently OT uses otPlatRadioIdle() to transition the radio between receive and transmit.  It might be more natural and straightforward if OT were to instead remove the option for a radio Idle State and instead treat the radio as operating in one of the following States {Disabled, Sleep, Receive, Transmit}.  To transmit a packet OT would then make a call to otPlatRadioTransmit() without a pre-requisite call to otPlatRadioIdle().  This also creates an assumption that if the radio is not Disabled, Transmitting or Sleeping then it must be Receiving.  This should reduce opportunities for missing received packets and simplify the OT code.

I would disagree. A lot (if not all) radios have idle state, so it makes sense that software reflects. Also hardware configuration should be done while in IDLE state, otherwise unexpected behavior might occur. The way I see the states:

Disabled - radio is shut down, almost none current consumption (leakage current), all register/configuration information is lost.
Sleep - radio is in low power on, minimal power consumption, most hardware is disabled (clocks, PLL's, PA's, etc.), registers/configuration is kept. Requires wake-up/warm-up routine.
Idle - radio is configured (or being configured) and running, [almost] ready to TX/RX, small power consumption.
TX/RX - active state, high power consumption.

I don't disagree with your statements.  The problem I have is how OT currently uses otPlatRadioIdle().  OT behaves by treating receive as a one-shot operation, meaning that OT assumes the driver will automatically transition back to Idle after delivering a single received packet.  It would be preferable if receive were treated as more persistent.  The radio would remain in receive and continue to deliver packets until OT explicitly transitioned it to a new State.  Furthermore, as it exists today OT always transitions to idle by calling otPlatRadioIdle before calling otPlatRadioTransmit.  It would be preferable if OT simply called otPlatRadioTransmit without the intermediate call to Idle.  Lastly, after transmit completes, OT should assume that the radio will transition back to receive rather than Idle.  Currently, OT makes an explicit call to otPlatRadioReceive after transmit  done.

Pull request to remove Idle at #275

Addressed in #275.


target-csv hotglue, remove version pin

Version pin caused a Windows failure for me. I like to pin, but on my own terms :D

Version pin caused a Windows failure for me

@visch what's the specific failure you saw? Cause it might be a bug in Meltano if git refs can't be used in pip URLs on Windows 😬.

I like to pin, but on my own terms

You can still override pip_url in meltano.yml AFAICT. I'm not sure where we're gonna land on pinning versions in the Hub vs resolving/pinning them when a lockfile is generated.

Version pin caused a Windows failure for me

@visch what's the specific failure you saw? Cause it might be a bug in Meltano if git refs can't be used in pip URLs on Windows 😬.

I like to pin, but on my own terms

You can still override pip_url in meltano.yml AFAICT. I'm not sure where we're gonna land on pinning versions in the Hub vs resolving/pinning them when a lockfile is generated.

Sorry for the lack of detail, late night!
Specifically it was this issue https://github.com/hotgluexyz/target-csv/issues/1 which their team fixed in a seperate commit, just a tap related issue. We could bump the version here but based on the other taps/targets we're not doing that for others?

This is admittedly a hard problem. Discussion started here: https://github.com/meltano/meltano/discussions/6445

@aaronsteers @edgarrmondragon @rwfeather how do we feel about merging this?
I'm with Derek that, at least in the short term until we have a pinning strategy, we should unpin and recommend users pin in their own project. The majority of the plugins on the hub right now are already unpinned, I only see 3 that are pinned right now and one of them ended up causing this bug https://github.com/meltano/hub/issues/708.


Update SQL Server Management Studio to 18.5.1

Microsoft Reviewers: Open in CodeFlow

I'm closing this PR now since a MS employee has opened a PR #1994


Producing wasm-binary if there's main.rs

Currently, the only way to execute rust code is via exposing a function and then calling it on js side. It would be nice to be able to do something like this:
main.rs
#![feature(proc_macro)]

extern crate wasm_bindgen;

use wasm_bindgen::prelude::*;

#[wasm_bindgen]
extern {
    #[wasm_bindgen(js_namespace = console)]
    fn log(s: &str);
}

fn main() {
    log("Hello from Rust");
}

Then using the cli to generate the required js and including the js directly in the html to execute it, instead of going through an intermediate state of needing to manually write another js file.

This is sort of related to https://github.com/rust-lang-nursery/rust-wasm/issues/18 as the wasm feature here we'd leverage is the start section but the Rust compiler, as of today, doesn't support this feature. I think that's definitely worth supporting though! (I'm not sure it would require anything on wasm-bindgen's side of things though)

But until the start situation is sorted on the compiler side, maybe the wasm-bindgen tool can treat the main function as any other exported function and re-export it in the generated wasm and then add a line to js where its executed like wasm.main() in the js code itself?

Oh certainly! That was actually a bug in wasm-gc which I pushed/published yesterday. Wasm-bindgen internally uses wasm-gc, so updating dependencies should hopefully fix that bug!

Nice. main is now exported and can be executed like any other function from a wasm module(Note: the generated JS file doesn't export it though). How about appending a line like wasm.main && wasm.main() so it checks and executes the function?

Hm perhaps! I think I might prefer though to use the start feature of wasm and expose that through rustc, as I think that's probably the best way to model this with wasm natively

Hmmm, I can understand. Using the start feature definitely feels like the right way.

In the meantime while we're waiting for rustc to catch up though I'd be totally down for doing something like #[wasm_bindgen(start)]

Sorry for the late reply, I got busy with exams and stuff. But I think the #[wasm_bindgen(start)] was a really nice idea.

I implemented this today but I don't think it's necessarily workable. The cyclic dependency between the JS and wasm emitted means that the JS is basically unusable so you can't call imports, but that's pretty non-obvious when writing the wasm.
Until that's fixed I'd personally be a bit hesitant to land this.

I'd love to have this available, such that the js file automatically calls the tagged main/start function as soon as it finishes loading the wasm.

Same, writing applications entirely in Rust should preferably not need extra bootstrapping code hand-written.

@LaylConway I definitely agree.
@alexcrichton Would it then be possible to use the normal main function as start (#[wasm_bindgen(main)]), maybe even by default somehow?

Would it then be possible to use the normal main function as start (#[wasm_bindgen(main)]), maybe even by default somehow?

is this even possible in wasm? you can't have a "normal" main function which would normally host the main loop, but in wasm you setup things in the "main" function and return from it, returning the control to the browser/runtime-environment.

This is definitely possible for us to do, and it largely just hasn't had anyone backing the effort needed to implement it yet!
I believe a rough implementation strategy for this would look like:

We'll likely want to leverage the fact that rustc produces a main exported symbol for binaries
In wasm-bindgen we can probably just either add #[wasm_bindgen(main)] or automatically hook up the main symbol to the start section. (I'd prefer the latter)
We'll need to handle the fact that the main symbol has arguments and a return value, but the start function can have neither.

We may wish to optionally update the main symbol generation for rustc itself, using no arguments and no return value (making it suitable for a start symbol), but that may be a bit more contentious.

@chpio that's a good point yeah, and while Rust has a different set of issues than C/C++ it's definitely true that the libstd initialization function, when it exits, performs global cleanup it assumes won't ever be necessary again.
So actually now that I think about this, I think it's not as clear that we can implement this in the standard library. In the standard library we'd have to bake in the concept of a "wasm main exiting isn't the end of the world, there's no definite end of the world!", but that's not necessarily an easy decision to make.
Instead in the meantime it may be best to simply stick with #[wasm_bindgen(main)]. That has the downside of still requiring crate-type = ["cdylib"] in Cargo.toml, but it provides a way for us to experiment with this today!


🔄 synced file(s) with klaasnicolaas/github-config

synced local file(s) with klaasnicolaas/github-config.

Changed files

synced local directory .github/ with remote directory github/

This PR was created automatically by the repo-file-sync-action workflow run #5244708144

Codecov Report
Patch and project coverage have no change.

Comparison is base (c17e778) 100.00% compared to head (be51b71) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines           86        86
  Branches         8         8
=========================================
  Hits            86        86

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


StrictMethodsFixer

Hi,
Since PHP 7 it doesnt make much sense anymore to have "@param" and "@return" tags in the docblocks. Lots of people are dropping those tags in favour for strict types. It would be great if we could use a fixer that is capable of adding strict types to the method and in the same time remove the annotation.
e.g:
From:
/**
 * @param SomeClass $classes
 * @return SomeClass
 */
function x($class)
{
}

To:
function x(SomeClass $class): SomeClass
{
}

I've started working on something, but there still are some issues to be resolved (it's a bit slow according to the tests, namespaces/alias support, edge cases ...)
If you think this could be of any value, feel free to give me some feedback and I'll try to work something out within my limited timeframe. If not: no problem, I had a lot of fun digging into the code of this project :)

Hi @veewee ,
Thanks for the PR, I really like the idea!
Currently we (the maintainers) are a bit busy so I'm sorry we didn't got back on your PR sooner.
You did mention there are a feel edge-cases that needs resolving, could you pick those up?
Let me know if you've more detailed questions about the project which we can help you with, like to see this finished :)

Thanks for the feedback @SpacePossum. Currently I also lack the time to finish the PR. Lets keep it open and I'll come back at it once I find more time.

I'm thinking it would be nice to split the fixer introduced here into two separate ones:

a fixer that adds parameters and return values type-hints from PHPDoc
a fixer that removes redundant PHPDoc that don't add useful information (same type as the actual type-hints and no desription of parameters or returns values)

WDYT?

@veewee , after #3276 is done, I believe we could focus on this one now :D

@keradus  yeah ... :)
@juliendufresne: Good argument. That's probably the way to go since it makes it possible to upgrade the target codebase in easy to review steps.

I'm closing this PR as all desired functionnalities have been implemented as the following rules:

phpdoc_to_param_type
phpdoc_to_return_type
no_superfluous_phpdoc_tags

Thanks @veewee for the time you invested on this anyway.


Arduino Leonardo ETH hangs using this library

Hi,
Arduino Leonardo hangs when using this library if SAA1064 object is created as global object. Reason is that Wire.begin() is called before Arduino setup() is called.
Fix: add SAA1064.begin() method and move Wire.begin() to this function. Call SAA1064.begin() in Arduino's setup() function. Then it works fine.
Thanks for cool library!

Thanks for the issue and the hint how to solve, even if it is years ago!
Going to change that ..
Chris

.. took it's time but there's a setup method now, doing exactly what you suggested.
cheers
Christian


✨ Enhancement: Support Additional Context for Commit Message Generation

Description
Added the ability to provide additional context when generating commit messages. Users can now type extra information in the SCM input box before clicking the AI Commit button, which will be considered when generating the commit message.
Changes Made

Modified commit message generation to include additional context from SCM input box
Added progress indicators showing when additional context is being used
Updated documentation in both English and Chinese

How It Works

User types additional context in the Source Control panel's message input box
When clicking the AI Commit button, this context is sent to the AI along with the diff
The AI considers both the diff and the context when generating the commit message
Progress messages indicate when additional context is being processed

Benefits

More accurate commit messages by providing extra context
Better control over commit message generation
No breaking changes to existing functionality
Seamless integration with current workflow

Documentation
Documentation has been updated in both README.md and README.zh_CN.md to reflect this new feature.
Related PR
https://github.com/Sitoi/ai-commit/pull/14
Labels: enhancement

Thanks I have merged and released version v0.0.9


Debian 9 requirements

Would it be possible that you could provide the requirements for a Debian system in your requirements (https://github.com/phpbrew/phpbrew/wiki/Requirement)? Any other system seems to be already there.
I'm struggling with the amount of packages which are required, it's kind of tricky to find the required ones without a explicit list. There are so many dependencies...

Have you tried the same Ubuntu requirements?

Tested your provided command with a fresh Debian 9 system.
First of all the package php7.2 and php7.2-cli doesn't exist for Debian 9, so i changed both to 7.0. After that the installation of the packages completed successully.
Unfortunetly phpbrew install 7.3 didn't worked for me:
Linux 4.9.0-8-amd64 #1 SMP Debian 4.9.144-3.1 (2019-02-19) x86_64
debian@debian-9:~/.phpbrew/distfiles$ phpbrew install 7.3
===> phpbrew will now build 7.3.3
You haven't set any variant. A default set of extensions will be installed for the minimum requirement:
[bcmath, bz2, calendar, cli, ctype, dom, fileinfo, filter, ipc, json, mbregex, mbstring, mhash, pcntl, pcre, pdo, phar, posix, readline, sockets, tokenizer, xml, curl, zip, openssl]
Please run 'phpbrew variants' for more information.

===> Loading and resolving variants...
Downloading http://www.php.net/get/php-7.3.3.tar.bz2/from/this/mirror via php stream
===> Extracting /home/debian/.phpbrew/distfiles/php-7.3.3.tar.bz2 to /home/debian/.phpbrew/build/tmp.1553606644/php-7.3.3
bzip2: (stdin) is not a bzip2 file.
tar: Child returned status 2
tar: Error is not recoverable: exiting now
Error: Extract failed:
debian@debian-9:~/.phpbrew/distfiles$

debian@debian-9:~/.phpbrew/distfiles$ ls
php-7.3.3.tar.bz2
debian@debian-9:~/.phpbrew/distfiles$ file php-7.3.3.tar.bz2
php-7.3.3.tar.bz2: HTML document, ASCII text, with very long lines

First of all the package php7.2 and php7.2-cli doesn't exist for Debian 9, so i changed both to 7.0. After that the installation of the packages completed successully.

I am sorry for that, nice that you got the gist of it. 😉

The downloaded php-7.3.3.tar.bz2 file is the source code of a html website. Why? 😕

There is probably an issue while downloading, try opening the file on a text editor to see the output. That might lead us to something.

 This is a security release which also contains several bug fixes.

All PHP 7.1 users are encouraged to upgrade to this version.

For source downloads of PHP 7.1.27 please visit our downloads page,
       Windows source and binaries can be found on windows.php.net/download/.
       The list of changes is recorded in the ChangeLog.

    <time datetime="2019-03-07T10:08:52+00:00">07 Mar 2019</time>

      PHP 7.2.16 Released

The PHP development team announces the immediate availability of PHP
     7.2.16. This is a security release which also contains several minor bug fixes.

All PHP 7.2 users are encouraged to upgrade to this version.

For source downloads of PHP 7.2.16 please visit our downloads page,
     Windows source and binaries can be found on windows.php.net/download/.
     The list of changes is recorded in the ChangeLog.

    <time datetime="2019-03-07T10:10:40+01:00">07 Mar 2019</time>

      PHP 7.3.3 Released

The PHP development team announces the immediate availability of PHP
      7.3.3. This is a security release which also contains several bug fixes.

All PHP 7.3 users are encouraged to upgrade to this version.

For source downloads of PHP 7.3.3 please visit our downloads page,
      Windows source and binaries can be found on windows.php.net/download/.
      The list of changes is recorded in the ChangeLog.

    <time datetime="2019-02-07T11:30:07+00:00">07 Feb 2019</time>

      PHP 7.2.15 Released

The PHP development team announces the immediate availability of PHP 7.2.15.
      This is a bugfix release.

All PHP 7.2 users are encouraged to upgrade to this version.

For source downloads of PHP 7.2.15 please visit our downloads page,
      Windows source and binaries can be found on windows.php.net/download/.
      The list of changes is recorded in the ChangeLog.

    <time datetime="2019-02-07T12:00:19+01:00">07 Feb 2019</time>

      PHP 7.3.2 Release Announcement

The PHP development team announces the immediate availability of PHP
      7.3.2. This is a bugfix release, with several bug fixes included.

All PHP 7.3 users are encouraged to upgrade to this version.

For source downloads of PHP 7.3.2 please visit our downloads page,
      Windows source and binaries can be found on windows.php.net/download/.
      The list of changes is recorded in the ChangeLog.

    <time datetime="2019-01-10T15:01:12-08:00">10 Jan 2019</time>

      PHP 5.6.40 Released

The PHP development team announces the immediate availability of PHP
     5.6.40. This is a security release. Several security bugs have been fixed
     in this release.

     All PHP 5.6 users are encouraged to upgrade to this version.

For source downloads of PHP 5.6.40 please visit our downloads page,
     Windows source and binaries can be found on windows.php.net/download/.
     The list of changes is recorded in the ChangeLog.

Please note that according to the PHP version
support timelines,
        PHP 5.6.40 is the last scheduled release of PHP 5.6 branch. There may be additional release if we
discover
        important security issues that warrant it, otherwise this release will be the final one in the PHP
5.6 branch.
        If your PHP installation is based on PHP 5.6, it may be a good time to start making the plans for
the upgrade
        to PHP 7.1, PHP 7.2 or PHP 7.3.

    <time datetime="2018-11-22T12:22:47+01:00">22 Nov 2018</time>

      PHP 7.3.0RC6 Released

        The PHP team is glad to announce the presumably last PHP 7.3.0 pre-release, PHP 7.3.0RC6.
        The rough outline of the PHP 7.3 release cycle is specified in the
        PHP Wiki.

        For source downloads of PHP 7.3.0RC6 please visit the download page.
        Windows sources and binaries can be found on windows.php.net/qa/.

        Please carefully test this version and report any issues found in the bug reporting system.

        THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

        For more information on the new features and other changes, you can read the
        NEWS file,
        or the UPGRADING
        file for a complete list of upgrading notes. Internal changes are listed in the
        UPGRADING.INTERNALS file.
        These files can also be found in the release archive.

        The next release would be 7.3.0 (GA), planned for December 6th.

        The signatures for the release can be found in the manifest
        or on the QA site.

        Thank you for helping us make PHP better.

    <time datetime="2018-11-08T11:11:26+01:00">08 Nov 2018</time>

      PHP 7.3.0RC5 Released

        The PHP team is glad to announce the next PHP 7.3.0 pre-release, PHP 7.3.0RC5.
        The rough outline of the PHP 7.3 release cycle is specified in the
        PHP Wiki.

        For source downloads of PHP 7.3.0RC5 please visit the download page.
        Windows sources and binaries can be found on windows.php.net/qa/.

        Please carefully test this version and report any issues found in the bug reporting system.

        THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

        For more information on the new features and other changes, you can read the
        NEWS file,
        or the UPGRADING
        file for a complete list of upgrading notes. Internal changes are listed in the
        UPGRADING.INTERNALS file.
        These files can also be found in the release archive.

        The next release would be RC6, planned for November 22nd.

        The signatures for the release can be found in the manifest
        or on the QA site.

        Thank you for helping us make PHP better.

    <time datetime="2018-10-25T11:07:32+02:00">25 Oct 2018</time>

      PHP 7.3.0RC4 Released

        The PHP team is glad to announce the next PHP 7.3.0 pre-release, PHP 7.3.0RC4.
        The rough outline of the PHP 7.3 release cycle is specified in the
        PHP Wiki.

        For source downloads of PHP 7.3.0RC4 please visit the download page.
        Windows sources and binaries can be found on windows.php.net/qa/.

        Please carefully test this version and report any issues found in the bug reporting system.

        THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

        For more information on the new features and other changes, you can read the
        NEWS file,
        or the UPGRADING
        file for a complete list of upgrading notes. Internal changes are listed in the
        UPGRADING.INTERNALS file.
        These files can also be found in the release archive.

        The next release would be RC5, planned for November 8th.

        The signatures for the release can be found in the manifest
        or on the QA site.

        Thank you for helping us make PHP better.

    <time datetime="2018-10-11T13:47:50+02:00">11 Oct 2018</time>

      PHP 7.3.0RC3 Released

        The PHP team is glad to announce the next PHP 7.3.0 pre-release, PHP 7.3.0RC3.
        The rough outline of the PHP 7.3 release cycle is specified in the
        PHP Wiki.

        For source downloads of PHP 7.3.0RC3 please visit the download page.
        Windows sources and binaries can be found on windows.php.net/qa/.

        Please carefully test this version and report any issues found in the bug reporting system.

        THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

        For more information on the new features and other changes, you can read the
        NEWS file,
        or the UPGRADING
        file for a complete list of upgrading notes. Internal changes are listed in the
        UPGRADING.INTERNALS file.
        These files can also be found in the release archive.

        The next release would be RC4, planned for October 25th.

        The signatures for the release can be found in the manifest
        or on the QA site.

        Thank you for helping us make PHP better.

    <time datetime="2018-09-28T10:31:16+02:00">28 Sep 2018</time>

      PHP 7.3.0RC2 Released

        The PHP team is glad to announce the next PHP 7.3.0 pre-release, PHP 7.3.0RC2.
        The rough outline of the PHP 7.3 release cycle is specified in the
        PHP Wiki.

        For source downloads of PHP 7.3.0RC2 please visit the download page.
        Windows sources and binaries can be found on windows.php.net/qa/.

        Please carefully test this version and report any issues found in the bug reporting system.

        THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

        For more information on the new features and other changes, you can read the
        NEWS file,
        or the UPGRADING
        file for a complete list of upgrading notes. Internal changes are listed in the
        UPGRADING.INTERNALS file.
        These files can also be found in the release archive.

        The next release would be RC3, planned for October 11th.

        The signatures for the release can be found in the manifest
        or on the QA site.

        Thank you for helping us make PHP better.

    <time datetime="2018-09-13T10:57:40+02:00">13 Sep 2018</time>

      PHP 7.3.0RC1 Released

        The PHP team is glad to announce the release of the next PHP 7.3.0 pre-release, PHP 7.3.0RC1.
        The rough outline of the PHP 7.3 release cycle is specified in the
        PHP Wiki.

        For source downloads of PHP 7.3.0RC1 please visit the download page.
        Windows sources and binaries can be found on windows.php.net/qa/.

        Please carefully test this version and report any issues found in the bug reporting system.

        THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

        For more information on the new features and other changes, you can read the
        NEWS file,
        or the UPGRADING
        file for a complete list of upgrading notes. Internal changes are listed in the
        UPGRADING.INTERNALS file.
        These files can also be found in the release archive.

        The next release would be RC2, planned for September 27th.

        The signatures for the release can be found in the manifest
        or on the QA site.

        Thank you for helping us make PHP better.

    <time datetime="2018-08-30T17:37:34+02:00">30 Aug 2018</time>

      PHP 7.3.0.beta3 Released

        The PHP team is glad to announce the release of the seventh PHP 7.3.0 version, PHP 7.3.0beta3.
        The rough outline of the PHP 7.3 release cycle is specified in the
        PHP Wiki.

        For source downloads of PHP 7.3.0beta3 please visit the download page.
        Windows sources and binaries can be found on windows.php.net/qa/.

        Please carefully test this version and report any issues found in the bug reporting system.

        THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

        For more information on the new features and other changes, you can read the
        NEWS file,
        or the UPGRADING
        file for a complete list of upgrading notes. Internal changes are listed in the
        UPGRADING.INTERNALS file.
        These files can also be found in the release archive.

        The next release would be RC1, planned for September 13th.

        The signatures for the release can be found in the manifest
        or on the QA site.

        Thank you for helping us make PHP better.

    <time datetime="2018-08-16T14:11:38+02:00">16 Aug 2018</time>

      PHP 7.3.0.beta2 Released

        The PHP team is glad to announce the release of the sixth PHP 7.3.0 version, PHP 7.3.0beta2.
        The rough outline of the PHP 7.3 release cycle is specified in the
        PHP Wiki.

        For source downloads of PHP 7.3.0beta2 please visit the download page.
        Windows sources and binaries can be found on windows.php.net/qa/.

        Please carefully test this version and report any issues found in the bug reporting system.

        THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

        For more information on the new features and other changes, you can read the
        NEWS file,
        or the UPGRADING
        file for a complete list of upgrading notes. Internal changes are listed in the
        UPGRADING.INTERNALS file.
        These files can also be found in the release archive.

        The next release would be Beta 3, planned for August 30th.

        The signatures for the release can be found in the manifest
        or on the QA site.

        Thank you for helping us make PHP better.

    <time datetime="2018-08-02T11:44:58+02:00">02 Aug 2018</time>

      PHP 7.3.0.beta1 Released

        The PHP team is glad to announce the release of the fifth PHP 7.3.0 version, PHP 7.3.0beta1.
        The rough outline of the PHP 7.3 release cycle is specified in the
        PHP Wiki.

        For source downloads of PHP 7.3.0beta1 please visit the download page.
        Windows sources and binaries can be found on windows.php.net/qa/.

        Please carefully test this version and report any issues found in the bug reporting system.

        THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

        For more information on the new features and other changes, you can read the
        NEWS file,
        or the UPGRADING
        file for a complete list of upgrading notes. These files can also be found in the release archive.

        The next release would be Beta 2, planned for August 16th.

        The signatures for the release can be found in the manifest
        or on the QA site.

        Thank you for helping us make PHP better.

    <time datetime="2018-07-19T11:02:21+02:00">19 Jul 2018</time>

      PHP 7.3.0alpha4 Released

        The PHP team is glad to announce the release of the fourth PHP 7.3.0 version, PHP 7.3.0alpha4.
        The rough outline of the PHP 7.3 release cycle is specified in the
        PHP Wiki.

        For source downloads of PHP 7.3.0alpha4 please visit the download page.
        Windows sources and binaries can be found on windows.php.net/qa/.

        Please carefully test this version and report any issues found in the bug reporting system.

        THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

        For more information on the new features and other changes, you can read the
        NEWS file,
        or the UPGRADING
        file for a complete list of upgrading notes. These files can also be found in the release archive.

        The next release would be Beta 1, planned for August 2nd.

        The signatures for the release can be found in the manifest or on the QA site.

        Thank you for helping us make PHP better.

    <time datetime="2018-07-05T11:41:41+02:00">05 Jul 2018</time>

      PHP 7.3.0 alpha 3 Released

      The PHP team is glad to announce the release of the third PHP 7.3.0 version, PHP 7.3.0 Alpha 3.
      The rough outline of the PHP 7.3 release cycle is specified in the
      PHP Wiki.

      For source downloads of PHP 7.3.0 Alpha 3 please visit the download page.
      Windows sources and binaries can be found on windows.php.net/qa/.

      Please carefully test this version and report any issues found in the bug reporting system.

      THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

      For more information on the new features and other changes, you can read the
      NEWS file,
      or the UPGRADING
      file for a complete list of upgrading notes. These files can also be found in the release archive.

      The next release would be Beta 1, planned for July 19th.

      The signatures for the release can be found in the manifest or on the QA site.

      Thank you for helping us make PHP better.

    <time datetime="2018-06-21T11:46:20+02:00">21 Jun 2018</time>

      PHP 7.3.0 alpha 2 Released

      The PHP team is glad to announce the release of the second PHP 7.3.0 version, PHP 7.3.0 Alpha 2.
      The rough outline of the PHP 7.3 release cycle is specified in the
      PHP Wiki.

      For source downloads of PHP 7.3.0 Alpha 2 please visit the download page.
      Windows sources and binaries can be found on windows.php.net/qa/.

      Please carefully test this version and report any issues found in the bug reporting system.

      THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

      For more information on the new features and other changes, you can read the
      NEWS file,
      or the UPGRADING
      file for a complete list of upgrading notes. These files can also be found in the release archive.

      The next release would be Alpha 3, planned for July 5.

      The signatures for the release can be found in the manifest or on the QA site.

      Thank you for helping us make PHP better.

    <time datetime="2018-06-07T18:36:37+00:00">07 Jun 2018</time>

      PHP 7.3.0 alpha 1 Released

     PHP team is glad to announce the release of the first PHP 7.3.0 version, PHP 7.3.0 Alpha 1.
	 This starts the PHP 7.3 release cycle, the rough outline of which is specified in the
	 PHP Wiki.

For source downloads of PHP 7.3.0 Alpha 1 please visit the download page.

     Please carefully test this version and report any issues found in the bug reporting system.

     Please DO NOT use this version in production, it is an early test version.

	     For more information on the new features and other changes, you can read the
	     NEWS file,
	     or the UPGRADING
	     file for a complete list of upgrading notes. These files can also be found in the release archive.

     The next release would be Alpha 2, planned for June 21.

The signatures for the release can be found in the manifest or on the QA site.

Thank you for helping us make PHP better.

    <time datetime="2018-02-01T09:12:34+00:00">01 Feb 2018</time>

      PHP 7.2.2 Released

The PHP development team announces the immediate availability of PHP
      7.2.2. This is a bugfix release, with several bug fixes included.

All PHP 7.2 users are encouraged to upgrade to this version.

For source downloads of PHP 7.2.2 please visit our downloads page,
      Windows source and binaries can be found on windows.php.net/download/.
      The list of changes is recorded in the ChangeLog.

    <time datetime="2017-10-12T11:46:49+02:00">12 Oct 2017</time>

      PHP 7.2.0 Release Candidate 4 Released

     The PHP development team announces the immediate availability of PHP 7.2.0 RC4.
     This release is the fourth Release Candidate for 7.2.0.
     All users of PHP are encouraged to test this version carefully, and report any bugs
     and incompatibilities in the bug tracking system.

THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

     For more information on the new features and other changes, you can read the
     NEWS file,
     or the UPGRADING
     file for a complete list of upgrading notes. These files can also be found in the release archive.

     For source downloads of PHP 7.2.0 Release Candidate 4 please visit the
     download page,
     Windows sources and binaries can be found at
     windows.php.net/qa/.

     The next Release Candidate will be announced on the 26th of October.
     You can also read the full list of planned releases on
     our wiki.

Thank you for helping us make PHP better.

    <time datetime="2017-09-28T12:58:56+02:00">28 Sep 2017</time>

      PHP 7.2.0 Release Candidate 3 Released

     The PHP development team announces the immediate availability of PHP 7.2.0 RC3.
     This release is the third Release Candidate for 7.2.0.
     All users of PHP are encouraged to test this version carefully, and report any bugs
     and incompatibilities in the bug tracking system.

THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

     For more information on the new features and other changes, you can read the
     NEWS file,
     or the UPGRADING
     file for a complete list of upgrading notes. These files can also be found in the release archive.

     For source downloads of PHP 7.2.0 Release Candidate 3 please visit the
     download page,
     Windows sources and binaries can be found at
     windows.php.net/qa/.

     The next Release Candidate will be announced on the 12th of October.
     You can also read the full list of planned releases on
     our wiki.

Thank you for helping us make PHP better.

    <time datetime="2017-08-31T10:53:58+02:00">31 Aug 2017</time>

      PHP 7.2.0 Release Candidate 1 Released

      The PHP development team announces the immediate availability of PHP 7.2.0 Release
      Candidate 1. This release is the first Release Candidate for 7.2.0.
      All users of PHP are encouraged to test this version carefully, and report any bugs
      and incompatibilities in the bug tracking system.

THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

      For more information on the new features and other changes, you can read the
      NEWS file,
      or the UPGRADING
      file for a complete list of upgrading notes. These files can also be found in the release archive.

      For source downloads of PHP 7.2.0 Release Candidate 1 please visit the
      download page,
      Windows sources and binaries can be found at
      windows.php.net/qa/.

      The second Release Candidate will be released on the 14th of September.
      You can also read the full list of planned releases on
      our wiki.

Thank you for helping us make PHP better.

    <time datetime="2017-08-17T10:17:44+02:00">17 Aug 2017</time>

      PHP 7.2.0 Beta 3 Released

      The PHP development team announces the immediate availability of PHP 7.2.0 Beta 3.
      This release is the third and final beta for 7.2.0. All users of PHP are encouraged
      to test this version carefully, and report any bugs and incompatibilities in the
      bug tracking system.

THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

      For more information on the new features and other changes, you can read the
      NEWS file,
      or the UPGRADING
      file for a complete list of upgrading notes. These files can also be found in the release archive.

      For source downloads of PHP 7.2.0 Beta 3 please visit the
      download page,
      Windows sources and binaries can be found at
      windows.php.net/qa/.

      The first Release Candidate will be released on the 31th of August.
      You can also read the full list of planned releases on
      our wiki.

Thank you for helping us make PHP better.

    <time datetime="2017-07-06T12:25:08+02:00">06 Jul 2017</time>

      PHP 7.2.0 Alpha 3 Released

The PHP development team announces the immediate availability of PHP 7.2.0 Alpha 3.
     This release contains fixes and improvements relative to Alpha 2.
     All users of PHP are encouraged to test this version carefully,
     and report any bugs and incompatibilities in the
     bug tracking system.

THIS IS A DEVELOPMENT PREVIEW - DO NOT USE IT IN PRODUCTION!

For information on new features and other changes, you can read the
     NEWS file,
     or the UPGRADING file
     for a complete list of upgrading notes. These files can also be found in the release archive.

For source downloads of PHP 7.2.0 Alpha 3 please visit the download page,
     Windows sources and binaries can be found on windows.php.net/qa/.

The first beta will be released on the 20th of July. You can also read the full list of planned releases on our
     wiki.

Thank you for helping us make PHP better.

Older News Entries

  Conferences calling for papers

Mid-Atlantic Developer Conference

Bulgaria PHP Conference 2019

ScotlandPHP 2019

  Upcoming conferences

PHPerKaigi 2019

PHP Russia 2019

Web Summer Camp 2019

Laracon EU 2019 Madrid

User Group Events

Special Thanks

      Social media

              @official_php

Copyright © 2001-2019 The PHP Group

My PHP.net

Contact

Other PHP.net sites

Mirror sites

Privacy policy

<img width="40" height="40" alt="To Top"<EMAIL_ADDRESS>

I've updated the Requirement and Variant Dependencies wiki pages with the actual requirements for Ubuntu 16.04 and 18.04.
You can find the requirements for a specific Debian distro using this mapping.


'Example' app crashes after performing long press gesture on table view cell

Tested on iOS 8.3

Fixed.


[modal] - Make overlay full height

@workingxx92
On daisyUI site I had to put the modal nested inside the page content because of my components structure. I should fix that, but I must stress that it's not a problem with the component itself. It's a problem with the demo site.
This won't happen if you put the modal after the page content (for example before)
This is also a common practice for all other modal components because a modal is a new layer outside of the current page. If it gets nested, it just fills the first relative parent. So, it's better to put it before the tag.

Hi.
I tried. It not woking in Vuejs

@workingxx92 Here's a Vue project and it works fine

I think the issue is related to the scrolling bar. How to fix it

@workingxx92 what's is the issue with scrollbar exactly? Because I don't see any issues 👀

I'm closing this. Feel free to reopen again with more information provided.

@workingxx92 There should't be a problem if you put the modal after the page content.

      open modal

  <input type="checkbox" id="my-modal-1" class="modal-toggle">

modal text

        Close

If there is still a problem, I need you to make a small example repo on Github so I can reproduce the issue.

HI. I don't put the modal after the page content.

@saadeghi
Please make a modal component that doesn't need put code modal after the page content (before)


Better explanation for 'display'

The alert raised for 'display' should explain to the user why it's not a good idea to use the term, and what to use instead.
[RedHat.Usage] Verify your use of 'display' with the word usage guidelines.

fixed in https://github.com/redhat-documentation/vale-at-red-hat/pull/585


get query result as per type.

In elastic search we are importing brand , product , vendor etc.. when we import brand type is brand , for product type is product and for vendor type is vendor.
At last all type of items store on same index in elastic search. For ex: we store uber as a brand and vendor it's store on same index.
when user search uber for brand I only want to get and show uber which type is brand not vendor. How can I do this ?
In model we have toSearchableArray function that is below for brand and vendor.
BrandModel
public function toSearchableArray()
    {
        //$array = $this->toArray();
        return [
            'id' => $this->brand_id,
            'title' => $this->brand_name,
            'img' => $this->image,
            'url' => $this->website,
            'type' => 'brand',
            'location' => [],
            'created_at' => Carbon::now()->toDateTimeString()
        ];
    }

VendorModel
public function toSearchableArray()
    {
        //$array = $this->toArray();
        return [
            'id' => $this->vendor_id,
            'title' => $this->vendor,
            'img' => $this->image,
            'url' => $this->website,
            'type' => 'vendor',
            'location' => [],
            'created_at' => Carbon::now()->toDateTimeString()
        ];
    }

when user search he/she select type brand/vendor want to search and as per user input we only want to show related result.
for search we are using below functions.
for Brand search
Route::get('search/{keyword}', function($keyword) {
        return App\Brand::search($keyword)->paginate(10);
    });

for vendor search
Route::get('search/{keyword}', function($keyword) {
        return App\Vendor::search($keyword)->paginate(10);
    });

we have different domains for brand and vendor.

Hi @dhavalkaneriya,
Do you store models in the same Elasticsearch type? If so, you try to filter:
App\Brand::search($keyword)->where('type', 'brand')->paginate(10);

Note that type field must have keyword type in Elasticsearch for strict equality.


Speed up CMake configuration checks

https://github.com/cristianadam/cmake-checks-cache suggests that we can speed up the CMake build.
time ./scripts/build.py -t --clean

on my (rather old) laptop takes
real	1m26.180s
user	0m9.613s
sys	0m1.904s

Work so far looks promising:
mkdir external
git submodule add git@github.com:cristianadam/cmake-checks-cache.git external/cmake-checks-cache
cmake . -G Ninja -B _build -DCMAKE_MODULE_PATH=`pwd`/external/cmake-checks-cache

makes subsequent invocations of
cmake . -G Ninja -B _build -DCMAKE_MODULE_PATH=`pwd`/external/cmake-checks-cache

very fast.
scripts/build.py will need updating and we need to decide how to handle a pre-cmake submodule

I've given this module a go without much luck.  On investigation, it appears that even when I pass the module in on the command line (via -DCMAKE_MODULE_PATH=) the checks are not being called.  Initially, I added message statements to the macro definitions, but when this proved fruitless I redirected the trace output to a file as such:
 cmake ../ -DCMAKE_MODULE_PATH=<path to module>-DCMAKE_VERBOSE_MAKEFILE:BOOL=ON --trace >> build.log 2>&1

Looking at the logs I see no calls to any of the expected check calls.  At this point, I am not sure why? It may be the project is not doing anything complicated enough to invoke the checks.  But further research is needed to confirm this.

Feel free to close.
Thanks for taking a look.


expose other windows

Any ETA on when the other views of VSCode are going to be exposed?
Would be great if an official example of such a build was made avaialble.

@mbana I am not sure what you mean. If you wish to create a vscode issue please do so at https://github.com/Microsoft/vscode

thanks


Replace relrefs with plain Markdown links

Given the size and composition of our website today, we’re no longer able to use Hugo relrefs as effectively as we used to. This change removes all Hugo relrefs in Markdown files, replaces them with regular Markdown links, and adds a linting rule to prevent content authors from using relrefs in Markdown files in this repo going forward.
What this means is that in the Markdown files where you write this today:
[Some link title]({{< relref "/some/path" >}})

you can just write this from now on instead:
[Some link title](/some/path/)

As a feature of Hugo, relrefs are great in that they help content authors avoid writing bad links by failing the build when a link target can’t be found. For us, however, they’re problematic in that the links we often write point to content that doesn’t exist in the current module, so we have to suppress relref failures in development builds (essentially negating their usefulness entirely). This often leads to downstream failures in integration builds because of syntax errors or other Hugo-idiosyncratic reasons, slowing us down and leaving people feeling confused and frustrated.
The upshot of this change is that by suppressing relref and letting all links through unchecked, we may occasionally ship a page with a broken link, but we’ll no longer fail the build for random reasons that don’t make sense to Hugo non-experts and that force us to react in the moment to unbreak the pipeline. Overall, it will improve our authoring and shipping velocity — and pragmatically, since we crawl the full site every day for bad links anyway (and alert ourselves on them), we should be able to keep broken links under control by keeping an eye on what breaks and fixing things up on a rolling basis just as we do today.
Note that this change doesn’t prevent using relrefs elsewhere; we’ll still use them in layout files, can use them in other modules, etc. It only applies to this module, as this is the one where most content authoring happens.
Lastly, since this PR is too big to review closely, I’ve set up a PR in the docs repo that uses this branch to build full site previews, which I’ve been testing with the link checker to guard against any regressions:
https://github.com/pulumi/docs/pull/8133
If a scan of the changes aligns with what you’d expect, and you agree with the change in principle, your ✅ would be appreciated; there’s definitely no need to review every change here, as all of these links are well covered by our automated testing. Thank you!

This changeset is HUGE and will be difficult for anyone to review within a reasonable time period. What automated tools, if any, do we have to verify the links that were affected by the change?

@scottslowe See my note at the bottom of the PR description. There’s a link there to a PR in pulumi/docs that I’ve been using to run local tests using the same link checker we run against the production website every day.

@cnunciato Thanks for the clarification! On that basis, the subset of changes I reviewed seem reasonable, so I'll go ahead and approve the PR.

@zchase it does, and good catch. I added the trailing slashes in https://github.com/pulumi/pulumi-hugo/pull/2071/commits/9d842866951135ab7e6cc9acf3fe3d39f105ef1e and we'll probably want to add some linting for this as well.

Ok @zchase -- on this:

Some links don't have a trailing slash now and I wondering if that is going to cause a bunch of SEO warnings.

.. I went through this PR last night and noticed many links still don't have trailing slashes; unfortunately my regex fu wasn't perfect here. My understanding is that tools like Screaming Frog can crawl a full site and produce reports for things like this, though, so if that's possible, I'd be happy to work off such a report to address these as follow ups (and then add some linting to look out for them going forward). Is generating a report like that something you could help with?


Unpacked Metro2 File Print Error

Metro2 Version: v0.2.6
What were you trying to do?
go run ./cmd/metro2/ print an unpacked file.

What did you expect to see?
A printed out version of an unpacked file.
What did you see?
Error, without verbose explanation of the issue.
How can we reproduce the problem?
Attempt to Go Run Metro2 Print an unpacked file using:
go run ./cmd/metro2/ print on the unpacked_fixed_file.dat in testdata folder with format output as JSON.

Was this addressed in slack? Anything to update in our docs or examples?


Krys

https://www.krys.com/
https://github.com/caresteouvert/Covid_enseignes/blob/master/rules.csv#L837

https://github.com/caresteouvert/Covid_enseignes/commit/b2f9fa6a42c5993812958f5b31ab8fda450b5e51


Incorrect screenshot for Authors in "Your first Wagtail site"

The Authors section of the "Your first Wagtail site" page ends in a screenshot that should demonstrate the display of Authors on a blog post. But it instead demonstrates categories (or something like that).
Pertinent section of the Wagtail docs
https://docs.wagtail.org/en/stable/getting_started/tutorial.html#authors
Details
The section is about adding Authors to a blog post and ends with a template in which they're displayed under a heading
Posted by:
.
However the following screenshot (docs/_static/images/tutorial/tutorial_10.png) is this, with a new heading of "Posted in" and showing what looks like a couple of Categories or similar, and no authors:

An updated screenshot is required.

@philgyford what type of content you want to showcase in the tutorial.

I'm unclear what you're both asking. The screenshot should show authors, not categories.

It looks like this issue came about because the tutorial was updated in #10624 to demonstrate snippets by introducing an Author snippet - in the previous version, it used a Category snippet. The screenshot should have been updated at this point, but it wasn't.
For anyone interested in picking up this issue: the task is to work through the tutorial up to this point, then take a new screenshot to replace the current one, showing the "Posted by" authors list in place of "Posted in". This new screenshot should be saved at the existing filename docs/_static/images/tutorial/tutorial_10.png. When taking the screenshot, please take care to match the size and format of the current one.

cc @thibaudcolas @activus-d who worked on the original PR

I have tried to fix this issue, please review it.
Screenshot:


Update to v1.1.1

Issue #, if available:
Description of changes:

Update to v1.1.1 for pre-release

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Previous CI Run
Current CI Run


Loading

Major
this pr adds a custom loading component. you can pass in an assets array of urls to the environment component and it will preload all the files, store the results, and only mount everything on load. this should fix the bug on ios + safari where models download but don't mount correctly. at some point want to make the api a little cleaner to not have to pass in an array of urls, and we also need to actually used the saved data from the loader that's available on the assets component via the LoadingContext
if no assets array is passed, "legacy loader" (just the normal useProgress hook) is used
Minor

remove portal environment and all supporting portal files
remove shopify buy
refactor, formal contexts folder

Needs some testing, will resubmit later today...


[My habits] [Calendar] Pop up with a list of all habits "In Progress" appears in Ukrainian in EN localization

Environment: Windows 10 Version 21H2, Chrome Version 116.0.5845.97.
Reproducible: always.
Build found: 25.08.2023
Preconditions
Registered user has at least 2 habits "in progress"
Steps to reproduce

Go to: https://www.greencity.social/.
Sign in.
Choose the localization 'EN'.
Click a mouse on current or one of 7 previous days on a Calendar.
Pay attention at the pop up with a list of all habits "in progress".

Actual result
Pop up with a list of all habits "In Progress" appears in Ukrainian (see attachment).

Expected result
Pop up with a list of all habits "In Progress" appears in English.
Postconditions
User story and test case links
User story #1431
Labels to be added

Cannot reproduce


feat(front): improve bin deletion UX

The bin deletion via the interface was completly impratical.
From now on, the token storage is done automatically.
Indeed, a Service Worker is registered to intercept in particular
the request of the form and the request of the final page (redirection).
This allows to associate the token with the bin ID, which is not known
in advance.
In the background, the IndexedDB database is used via the localforage
abstraction, which allows to easily store key-value in the same way as
the localStorage (which is not available in a Service Worker).
This feature is only available for the clients with JavaScript enabled.
Closes: https://github.com/readthedocs-fr/bin-server/issues/147.

When you'll resolve the conflict, could you add a comment for the noscript tag explaining that the feature requires javascript and that this bit of code hide the menu in no-script environments ?

When you'll resolve the conflict, could you add a comment for the noscript tag explaining that the feature requires javascript and that this bit of code hide the menu in no-script environments ?

Done

Still waiting for a third person to review and test this branch!

cc @fusetim or anyone who wants to test this.

Might take a while for me

bump @Julien00859?

De mon côté le bouton de suppression de bin ne s'affiche pas
Ai-je mal fait quelque chose ? @Mesteery


Request cookie consent feature

Hi, I have a new feature idea for the Mazer app. This feature is the cookie consent feature, where when a user opens a page, a modal or component will appear with two options. The first option is to Reject Cookies, and the second is to Accept Cookies.
This is useful for developers who want to utilize cookies. The following is an example of a component design that I will make, maybe this design will change if this design is not relevant to Mazer's design.

I think we can make it with Mazer (Bootstrap) modal


VIH-8671 - Dependency cleanup

Change description
Correct a call to a method in BookingsApi where the signature had changed.
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

/azp where

/azp where

/azp run


version bump to 1.10

Bumps version to 1.10 as a followup to the 1.9 release

Hi Mike. We don't bump the version here. We do that when we release the new version only.


Simple faceted search

As a developer, I would like to be able to write faceted search queries as simply in ArangoDB as I can in Solr or ElasticSearch.
Acceptance criteria:

Simple/ergnomic syntax from both Java driver and AQL
Ability to AND constraints across facet groups
Ability to OR contraints within a single facet group
Boolean, NEAR, NOT queries
Debug param
Param to toggle whether filtering by one facet causes all the disincluded facet values to disappear or not

@minnownoir sorry, we have no release date for this. Currently, we are concentrating on auto failover.

@andrew-s Our ArangoSearch team is aware of this feature request and they estimate that it would be quite an effort to implement a fully featured facet search. The basic functionality would not take as long obviously, but please do provide some example use cases so that we can better understand what is desirable and what is expendable.

@Simran-B I think the basic functionality would cover most use cases, (hopefully I've got this right) - from creating a view for the ArangoSearch with the defined indexes to basically when querying (with whatever relevant filters on that view) to return a compiled list of all the indexes with their values and respective counts, e.g;
profile_view:

eye_colour
hair_colour
height

Should return with the view like;
 - eye_colour
 | -- blue (200)
 | -- brown (78)
 | -- green (24)
 - hair_colour
 | -- black (146)
 ..... etc ....

As an initial feature, that would be enough - I think there's more that can be done there absolutely like being able to specify ranges (e.g. grouping age into decade ranges like 10 to 20 and so on). Hope that makes sense!

Im not sure if Im looking for exactly the same feature, but it is related.
When I run a view SEARCH I would like to do a PHRASE/TOKENS search and also aggregate the count of authors represented in the results.
LET docs = (
    FOR d IN en_view
        SEARCH PHRASE(d.text, 'and', 'text_en')
        LIMIT 10
        RETURN {author: d.author, title: d.title}
    )

LET authors = (
    FOR d IN docs
        COLLECT a = d.author WITH COUNT INTO ac
        SORT ac DESC
        RETURN {a,ac}
)
RETURN {docs, authors}

is as close as ive come . unfortunately, this only gives the authors in the top 10, and moving the LIMIT to the authors query, will bring back all the docs results at once. I just want to rollup the authors as im iterating over them, and give a stats count along with the top 10 results, of all the authors that are hit by this SEARCH.
Am i going about this query wrong? Should i just run a parallel collect statement?
Thanks for all the development effort going into the releases.

Faceted search is on our backlog, but unfortunately there is no ETA atm.

There are several possibilities to count query results:

use COLLECT WITH COUNT
getting approximate count with COLLECT WITH COUNT and countApproximate:cost option https://www.arangodb.com/docs/stable/aql/operations-search.html#search-options
return query statistics with fullCount
https://www.arangodb.com/docs/stable/aql/execution-and-performance-query-statistics.html


Release bump to 5.12-1 for bug-fixes

Probably will work for the time being

So just for reference:
https://guides.rubygems.org/patterns/#semantic-versioning

The RubyGems team urges gem developers to follow the Semantic Versioning standard for their gem’s versions. The RubyGems library itself does not enforce a strict versioning policy, but using an “irrational” policy will only be a disservice to those in the community who use your gems.

So I might try some tests with Gem::Version.new("5.12-1") and see how that fairs.  Hold plz...

Glad I checked, looks like it won't work this way:
$ irb
irb(main):001:0> Gem::Version
=> Gem::Version
irb(main):002:0> Gem::Version.new("5.12-1")
=> #<Gem::Version "5.12.pre.1">
irb(main):003:0> Gem::Version.new("5.12-1") > Gem::Version.new("5.12")
=> false
irb(main):004:0>

Makes sense I guess.


must-gather:log the total time taken by collection script

this pr will fix the issue where the collection script was not able to log the total time taken by the must gather collection script
Signed-off-by: RAJAT SINGH<EMAIL_ADDRESS>

This PR is the fix of #1009 this logs the total time taken by the collection script in seconds, I have t disable the shellcheck in order to achieve that, in later releases, I will make the time taken in the format of hh:mm:ss but for now/this relase, this will work.

This is how the gather-debug.log file ends like
total time taken by collection was 351 seconds
collection ended at: 09:31:47 PM
deleting empty files

Removed the shellchecks, thanks @jarrpa

/cherry-pick release-4.7


Fix Kernel#Integer failing specs

Trim leading and trailing ASCII whitespace.
Trim any ASCII whitespace, not just spaces ( ).
Treat a single (potentially whitespace padded) 0 as parsing to 0.

Fixes https://github.com/artichoke/artichoke/issues/2067.
Thanks for the report @b-n.

markdown checks are being rate limited