[Snyk] Security upgrade redhat/ubi9 from 9.3-1476 to 9.5-1734495538

Snyk has created this PR to fix 5 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

spring-boot-tests/spring-boot-integration-tests/spring-boot-launch-script-tests/src/dockerTest/resources/conf/RedHat/ubi9-9.3-1476/Dockerfile

We recommend upgrading to redhat/ubi9:9.5-1734495538, as this image has only 170 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Out-of-bounds Write SNYK-RHEL9-GLIBC-6624544
  721

Out-of-bounds Write SNYK-RHEL9-GLIBCCOMMON-6625493
  721

Out-of-bounds Write SNYK-RHEL9-GLIBCMINIMALLANGPACK-6624576
  721

Improper Check or Handling of Exceptional Conditions SNYK-RHEL9-GLIBCCOMMON-6678305
  614

Authentication Bypass SNYK-RHEL9-KRB5LIBS-8380238
  614

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

:tada: Snyk checks have passed. No issues have been found so far.
:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)


Backend - Performance optimization for Jobs page

Description
Locally I noticed the following from the debugbar:
377 statements were executed, 308 of which were duplicated, 69 unique
My local jobs page has 61 unique entries, and it's executing five times as many duplicate queries when it builds the page. Need to look into how to build the queries for this data to avoid so many duplications.
Required for Completion
Add/remove others as necessary for this specific task.

[ ] Run Lighthouse (Chrome Dev Tools)
[ ] Create pull request to dev
[ ] Address issues found during peer review
[ ] Have someone else accept pull request into dev

Duplicate of #781


Add maxSpan option for DateRangePicker & DateRangeFilter

The maximum span between the selected start and end dates.

Thanks for the great PR


build error: Can't resolve 'viem/chains' in @wagmi\connectors\dist

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
1.0.2
Current Behavior
<EMAIL_ADDRESS>Module not found: Can't resolve 'viem/chains' in ${work_dir}\node_modules@wagmi\connectors\dist'
my dependency:
"viem": "^0.3.21",
"wagmi": "^1.0.2",
Expected Behavior
No response
Steps To Reproduce
No response
Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
No response
Anything else?
No response

Can you please provide a minimal reproducible example via https://new.wagmi.sh? Will re-open when done!

@jxom  ive created a React app using react 17.0.2 and craco 6.3.0 . This is the current stack we are using in our app's codebase
starting the app would automatically display the above error

@jxom ive created a React app using react 17.0.2 and craco 6.3.0 . This is the current stack we are using in our app's codebase
starting the app would automatically display the above error

yes, I'm using react 17.0.2 too

What version of react-scripts are you running? Webpack 4 doesn't support package.json#exports, so it could be worth upgrading?

I'm using "react-scripts": "4.0.1"

Should work if you upgrade to ^5 which comes with Webpack 5!

Should work if you upgrade to ^5 which comes with Webpack 5!

OK, thanks. I'll try it soon!

https://github.com/iandjx/cra-17-wagmi
sorry forgot to post the repo earlier

Confirmed working with react-scripts ^5.0.1 . thanks @jxom

react-scripts ^5.0.1 works, thanks a lot!


Feat(plugins): Add framework for structured config executor

Change Summary

Add framework for structured config executor
Proposed changes

Add base class StructuredConfigGenerator

Mainly just to get class attributes and init the same.
Registers method executions to StructuredConfigExecutor passed to it.

Add RegisterForExecution class method decorator to mark methods to be executed pre, per_tenant, per_vrf, per_svi, per_l2vlan or post
Add StructuredConfigExecutor class

Initializes all given StructuredConfigGenerator classes which in turn registers their methods for execution.
Expose the method execute() to start execution of all methods according to their registered stage.
Expose the method graph() to return a mermaid graph (as string) depicting the registered executions.

How to test

Added pytest of decorator and executor, which also indirectly test the StructuredConfigGenerator base class.
Checklist
User Checklist

N/A

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

will come back later with an improved variant.


pdfstudio: added version 2024.0.0

Also modified how it is called in all-packages.nix to pass the by-name check.
Description of changes
Added new 2024 version. https://kbpdfstudio.qoppa.com/whats-new-in-pdf-studio-2024/
Also changed the way that the packages are called, to pass the by-name check. See the README
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)

Add a :+1: reaction to pull requests you find important.

@PhilippWoelfel I have added pdfstudio2024. I needed to change the way it is included in all-packages.nix to pass the by-name check.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/advice-requested-on-whether-this-is-the-correct-way-to-use-pkgs-by-name/44933/3

How long does it take before PRs are merged?
I have a 2024 license and it doesn't work on 2023.

@PhilippWoelfel I have added pdfstudio2024. I needed to change the way it is included in all-packages.nix to pass the by-name check.

Thanks! Do you want to add yourself as maintainer?

Or is there another way to pull in this change?

Yes, there is, but this should probably be discussed in https://discourse.nixos.org/

Or is there another way to pull in this change?

Since someone else asked me how to install this while this has not been merged, here is how you can do this if you're using flakes:
Add repo of the pull request to your flake inputs:
inputs = {
  pdfstudioFlake.url = "github:daudi/nixpkgs/pdfstudio2024b";
};

And then in your nixos config, you can add this to your system packages:
{ pdfstudioFlake, ... }:
{
environment.systemPackages = [ (import pdfstudio2024 { system = "x86_64-linux"; config.allowUnfree = true; }).pdfstudio2024 ];
<other stuff>
}

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/issue-with-pdfstudio2024-installation/52603/1

{ pdfstudioFlake, ... }:
{
  environment.systemPackages = [ (import pdfstudio2024 { system = "x86_64-linux"; config.allowUnfree = true; }).pdfstudio2024 ];
}

Should be [( import pdfstudioFlake { ....

There is probably a newer version of 2024 out, but this has been sitting for too long already. Please ping me if you want to update it.


Add health check for client

go-etcd cannot detect whether the member in use is healthy when doing read requests. If the member is isolated from the cluster, go-etcd may retrieve outdated data.
This PR add health-check for client, it do health check periodically, if it find client is connected to an isolated member, switch to a healthy member. The health check in this PR support V2.0(with out experimental health endpoint), which I think is very helpful.
In the next step, we can using the experimental health endpoint to do health check https://github.com/coreos/etcd/issues/3265

@combk8s As it mentions here, this is deprecated and we don't accept new features.
Moreover, it could be really really helpful if you could have some proposal or discussion before implementing new features.


Add example project for HazelcastLockProvider

Closes: gh-6

Why is my PR is closed without merging? Is there any error? Please let me know.


tests + fix

#84 should fix this by adding forward referencable enums (strawberry does not need model rebuilds)


Can only enter page from root

I used the angular-cli-ghpages tool and it worked perfectly fine, with deploying it on the gh-pages branch. But I only can access my application from the root directory and not just using a specific URL.
Has anyone came across this problem?

see https://github.com/angular-buch/angular-cli-ghpages/wiki/FAQ#why-is-the-routing-not-working-correctly-on-hard-reload-specific-to-github-pages-only

Thanks @JohannesHoppe!

I will add this be default to the next version -- when I have some spare time.

Great stuff!


added a clear section for supported variables

Variables
The enrichment server provides allows for these variables:
${IP}, ${MAC}, ${USERNAME}, and ${HOSTNAME} and custom entities
Purpose of this pull request
This pull request (PR) ...
Issue number:

Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions and updating sections
[ ] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

@kimsauce I have approved

@kimsauce I have approved

@g-wattz Marie's comments above are still showing as unresolved. You might have to add locally in your fork and re-submit.

@g-wattz thank you! Last step - you just have to sync with main branch to get the latest updates, then you can merge.


BelowRight: incorrect position on first render

Bug
Expected behavior
When BelowRight renders it's show prop component, it does so below and to the right of itself
Actual behavior
The show prop is rendered below and to the left of BelowRight on first render, subsequent renders are correct
BelowLeft instance
show prop ActionMenu
Steps to repro
Please reach out to me or Snugbear team members if more info is needed, but the below should be enough to recreate the issue using StoryBook by simply clicking the button twice:
import React, { useState } from 'react'
import { BelowRight } from '@pluralsight/ps-design-system-position'
import ActionMenu from '@pluralsight/ps-design-system-actionmenu'

export const Component = () => {
  const [isOpen, setIsOpen] = useState(false)
  const onClose = () => setIsOpen(false)
  const onClick = () => {}
  return (
    <div style={{ width: '100%', alignContent: 'right' }}>
      just putting words here so that the button is for sure rendered to the right
      <BelowRight
        when={isOpen}
        show={<ActionMenu onClose={onClose} onClick={onClick}><ActionMenu.Divider /></ActionMenu>}
      >
        <button onClick={() => setIsOpen(!isOpen)}>button</button>
      </BelowRight>
    </div>
  )
}

export default {
  title: 'Component',
  component: Component,
}

Here's an example of this in action:

Related packages

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Environment

OS - MacOS 10.15.6
Browser version - Brave v1.14.84

having trouble reproducing the issue. @MattRCole and i setup a sandbox to attempt to recreate.... but the bug seems to have fixed it's self(magic 🎆 ). also @MattRCole reports he is no longer seeing the issue in his application. closing for now...

https://codesandbox.io/s/pedantic-worker-z4syd?file=/example.tsx


QUESTION: pino and pino-express

Hello maintainers,
Thank you for this awesomeness. I just have a question.
If I use express-pino do i still have to use pino?
im confused so im using it like this.
import pinoExpress from 'express-pino-logger';
import pino from 'pino';
const pins = pino();

app.use(pinoExpress({logger: pins,  prettyPrint: true }, pino.destination(path.resolve(__dirname, '../logs/route.log'))));

// some routes implementation
pins.info('test route..'); < ---- this wont be written in the filie. is this a bug?

You are not passing pino.destination() to the instance of pino.

@mcollina Hello sir. Thank you for responding. Im confused.
Do you mean like this?
const pins = pino({ prettyPrint: true }, pino.destination(path.resolve(__dirname, '../logs/route.log')));

but then I cant use it on express like app.use(pins)

You need to pass the pino instance to this module.

yea. I got it. I was just confused the way js and typescript. im closing this now. thank you.


rancher-nfs error rpc.statd is not running

Error (Error response from daemon: create bar: VolumeDriver.Create: Failed mount -o nolock,nfsvers=4 <IP_ADDRESS>:/nfs /tmp/qf860: mount.nfs: rpc.statd is not running but is required for remote locking. mount.nfs: Either use '-o nolock' to keep locks local, or start statd. mount.nfs: mounting <IP_ADDRESS>:/nfs failed, reason given by server: No such file or directory)
But when I put nolock in MOUNT_OPTS it does not change anything.

rancher-nfs log:
1.2.2017 12:37:04time="2017-02-01T11:37:04Z" level=info msg=create.request name=bar
1.2.2017 12:37:04time="2017-02-01T11:37:04Z" level=error msg=create.response error="Failed mount -o nolock,nfsvers=4 <IP_ADDRESS>:/nfs /tmp/qf860: mount.nfs: rpc.statd is not running but is required for remote locking.\nmount.nfs: Either use '-o nolock' to keep locks local, or start statd.\nmount.nfs: mounting <IP_ADDRESS>:/nfs failed, reason given by server: No such file or directory"

Useful
Info

Versions
Rancher v1.4.0-rc6 Cattle: v0.176.5 UI: v1.4.4

Access
localauth admin

Orchestration
Cattle

Route
stacks.index

OS
RancherOS v0.7.1

I have this error on older versions of rancher

I have the same issue...

+1


Extra stuff!

Hi, I added some funny extra stuff! Hope it deserves merging :)

Ah sorry for being late reviewing. I am closing this now preparing for the next workshop.


feat (auth): add deleteUser API

Issue #, if available:
Description of changes:
Check points: (check or cross out if not relevant)

[x] Added new tests to cover change, if needed
[x] Build succeeds with all target using Swift Package Manager
[x] All unit tests pass
[x] All integration tests pass
[ ] Documentation update for the change if required
[x] PR title conforms to conventional commit style
[ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1582 (4d7911d) into main (393102d) will increase coverage by 8.48%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1582      +/-   ##
==========================================
+ Coverage   48.84%   57.33%   +8.48%
==========================================
  Files         547      628      +81
  Lines       13730    18790    +5060
==========================================
+ Hits         6707    10773    +4066
- Misses       7023     8017     +994

Flag
Coverage Δ

API_plugin_unit_test
62.36% <ø> (ø)

AWSPluginsCore
71.61% <ø> (ø)

Amplify
46.88% <0.00%> (-0.08%)
:arrow_down:

Analytics_plugin_unit_test
71.76% <ø> (ø)

DataStore_plugin_unit_test
76.10% <ø> (?)

Geo_plugin_unit_test
52.12% <ø> (ø)

Predictions_plugin_unit_test
25.01% <ø> (-1.80%)
:arrow_down:

Storage_plugin_unit_test
58.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../Categories/Auth/AuthCategory+ClientBehavior.swift
0.00% <0.00%> (ø)

...Categories/Auth/AuthCategoryBehavior+Combine.swift
0.00% <0.00%> (ø)

...ategories/Auth/Request/AuthDeleteUserRequest.swift
0.00% <0.00%> (ø)

.../DataStore/Model/Internal/Schema/ModelSchema.swift
64.00% <0.00%> (-2.00%)
:arrow_down:

...lugin/CoreMLPredictionsPlugin+ClientBehavior.swift

...ionsPlugin/Operation/CoreMLIdentifyOperation.swift

...Plugin/Operation/CoreMLTextToSpeechOperation.swift

...ictionsPlugin/Dependency/CoreMLVisionAdapter.swift

...lugin/Operation/CoreMLInterpretTextOperation.swift

...eMLPredictionsPlugin/CoreMLPredictionsPlugin.swift

... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 393102d...4d7911d. Read the comment docs.


School Request

@Saijmo08 !School I am sorry, I have to close the request without merging, because you made a mistake in a request and did not specify any filepath. Please ensure that you are familiar with this repository rules located at the bottom of this page and make a new correct request. Thank you for your understanding!


Automated re-render of Galaxy Tools

Results of make render on main

Well that .shed.yaml is definitely not going to work.


Add a Feed for the blog

Hi good people!
Thank you for the great work you have been doing.
I was wondering if you could please add a Feed (RSS/ATOM/JSONFeed) to the blog portion of the website.
This, added to the fact that the feed notifies us to the new posts, let's the reader enjoy the content in an environment suited for their reading needs.
I have checked the heads, and checked the router file, and could not find any trace of it.
I would appreciate it highly if you could consider adding support for any of these formats.

Hi @prmadev! Sorry I missed this issue 🤦 I think a feed would be a great idea! Would you be open to contributing such a feature?

Hi @prmadev! Sorry I missed this issue 🤦 I think a feed would be a great idea! Would you be open to contributing such a feature?

Yes. Definitely. I will be back soon with a PR.


[docs] Full documentation for React Router integration

Closes https://github.com/mui/toolpad/issues/4045
Closes https://github.com/mui/toolpad/issues/4149

Adds integration guide for React Router: https://deploy-preview-4185--mui-toolpad-docs.netlify.app/toolpad/core/introduction/integration/#react-router
Adds example with Vite & React Router
Adds Vite project playground for development

Supporting Vite starter in create-toolpad-app will be done as a separate issue: https://github.com/mui/toolpad/issues/4235 (planned for v0.9.0)

While this is much needed and very appreciated, I believe this example would be more useful if it showcased integration with the new data api routers.

[ ] Mention Vite & React Router example in: https://deploy-preview-4185--mui-toolpad-docs.netlify.app/toolpad/core/introduction/examples/

We could add a working example on the page? Should just work in an iframe with the browser router.

We could add a working example on the page? Should just work in an iframe with the browser router.

Ok, also I'm not linking to the example in Github so will probably add a callout doing it somewhere.

https://deploy-preview-4185--mui-toolpad-docs.netlify.app/toolpad/core/introduction/integration/#1-wrap-all-your-pages-in-an-appprovider-using-a-layout-route

// src/App.tsx
import { AppProvider } from '@toolpad/core/react-router-dom';

should be
// src/App.tsx
import { AppProvider } from '@toolpad/core';

??

We could add a working example on the page? Should just work in an iframe with the browser router.

I've been trying to do this with the Browser Router but our demo iframes have no src set which means they default to about: blank, there is no way to set an src unless we modify the Material UI repo component, and there seems to be no way to make the React Router work with about:blank as far as I've tried and looked.
So I guess we can just have an image instead of a live demo and users can just try out the Vite + React Router example themselves?

we could use the memory router?

we could use the memory router?

ok that should work

Added link to Vite example in examples grid
Fixed all Vite app examples as router configuration was not 100% correct
Updated docs and integration guide instructions to fit this configuration + use live example of Vite app instead of an image, as close as possible to the actual example app

This is really helpful, thank you very much!


Bump natural_sort_jp from 0.3.0 to 0.4.1

Hi 👋
This PR is update a diff that was occurring when I ran bundle install.

Thank you very much!
I’ll merge it.


Qt/OpenCV test(5.14.x/4.1.x) for Android

Early it was a number of issues with Qt build (ndk 10/gcc only) and OpenCV (can build only with certain(old) ndk-tools and clang).
Looks like Qt 5.14.x and OpenCV 4.1.x solve issue with build system and can use up-to-date clang build

out-of-date


[Fix #2] Split rubocop config to smaller parts

This PR split config to smaller parts so that we can use it as for gems, as for Rails application. Also, now we can enable and disable Rspec configs
Before you submit a pull request, please make sure you have to follow:

[x] read and know items from the Contributing Guide
[x] add a description of the problem you're trying to solve (short summary from related issue)
[x] verified that cops are ordered by alphabet
[x] add a note to the style guide docs (if it needs)
[x] add a note to the changelog file
[x] the commit message contains the number of the related issue (if it presents)
and word Fix if this PR closes related issue
[x] squash all commits before submitting to review

🤔 looks like everything is OK

aka no comments - no mistakes

@lazycoder9 ❤


[ZF3] [Debate] Remove ServiceLocatorAwareInterface from AbstractController

Heya people
After a rather interesting discussion in #5156 many people tend to agree that having the AbstractController implement the ServiceLocatorAwareInterface is a bad idea since it allows for poor practise.
Yes, it can be convenient at times but it's used far too carelessly. Removing the ServiceLocatorAwareInterface we can "enforce" better practise among our users ?

Those interfaces not longer exists on SM v3


add a contributing doc for other open-cluster-management repos to refer to

add a contributing doc for other open-cluster-management repos to refer to (if they want a default one to refer to)
Signed-off-by: Mike Ng<EMAIL_ADDRESS>

/lgtm


Added esm and cjs bundles

Ref: https://github.com/bigbinary/neeto-engineering-web/issues/344

Added esm and cjs bundles
Checklist

[ ] I have made corresponding changes to the documentation.
[ ] I have updated the types definition of modified exports.
[x] I have verified the functionality in some of the neeto web-apps.
[x] I have added the necessary label (patch/minor/major - If package publish
is required).

Reviewers

@Amaljith-K _a
Please review.

@Amaljith-K _a
Please review.


New Feature: disable oom killer

Hi there,
We'd like to add a new feature to Docker say, disable oom killer when OOM happend #11034 . This is  useful especially in production scenario but we have not yet been in accord on what's the name would this option be.
By now, --disable-oom-kill is in lead but the name is a little too long, WDYT.
So if someone else has a strong preference, please comment.

Instead of a boolean to disable the oom killer entirely (which is a really bad idea in my opinion), how about a tunable instead? Meaning something like --oom-score=100.
This would use the standard linux oom_score_adj control mechanism. The score controls the tendency for the kernel to target that process when it needs to kill something, and a score of -1000 means to disable the OOM killer for that process.

This is heading in the direction of what we call Priority in Borg.  OOM
scoring is just one facet of it, but an important one.
On Sun, Apr 19, 2015 at 8:35 PM, Patrick Hemmer<EMAIL_ADDRESS>wrote:

Instead of a boolean to disable the oom killer entirely (which is a really
bad idea in my opinion), how about a tunable instead? Meaning something
like --oom-score=100.
This would use the standard linux oom_score_adj control mechanism. The
score controls the tendency for the kernel to target that process when it
needs to kill something, and a score of -1000 means to disable the OOM
killer for that process.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/12528#issuecomment-94347919.

Hi @phemmer , the oom_score_adj is related to a pid and we can't get that before the container start.

I agree with @HuKeping that oom_control and oom_score_adj have different targets - cgroup and process.

I agree with @HuKeping that oom_control and oom_score_adj have different targets - cgroup and process.

I'm not disagreeing, but oom_score_adj offers a lot more flexibility, and can do what oom_control does.

Here's a PoC showing it working (score hard coded to 123):
https://github.com/phemmer/docker/commit/3fe3a89a1d04222b9f3308283b564cb53c2b311c
# docker run --rm -ti busybox sh -c 'cat /proc/self/oom_score_adj'
123

hi @phemmer , When OOM happen, the kernel will try to find out who was the most likely to be killed and that was depend on the oom_score. Generally, the highest score owner will be killed, then how to weight when we doing the creating things? Why should you assign container_1 with 100 and another with 200?
I still think we use the cgroup to control that is safe and enough.

Why should you assign container_1 with 100 and another with 200?

If container_1 is your database container, and another is your application container, your database container will be less likely to be targeted by the OOM killer. This is the behavior you want as killing your database container can result in DB corruption, where as killing the application container is likely to be no more than an inconvenience.
Disabling the OOM killer entirely is a very bad idea as this leaves the kernel with very minimal choices of what it can kill. If you've got a server that runs nothing but docker (and containers started by docker), and you have the OOM killer disabled on every container, the OOM killer is likely to target docker itself, or other critical system processes (network manager, dbus-daemon, etc), of which killing them can lead to major system instability.
If you're going to disable the OOM killer, you should be doing it by disabling overcommit.

Docker is not a toy, in the real world, in every cloud platform , the provider will always run docker for their customer  with option -m and this will prevent system memory leaking.
On the customer side, they would prefer not kill their app directly when OOM happened, that is too aggressive to acceptable.

I think some of the confusion might be coming in on what the OOM killer is for.
The OOM killer is turned on when the system has overcommit enabled. Overcommit is basically when the kernel allows programs to allocate more memory than the system actually has. It does this in the hope that the programs on the host won't actually use all the memory they allocate. For example, the application allocates a 1mb buffer to read some data from the network, but it only ends up reading a few kb. In this scenario you have several hundred kb of unused memory. Thus overcommit prevents wasting this memory.
Now lets say the application ends up using that several hundred kb of extra memory. The kernel already granted the memory to the application, so the application isn't performing a malloc call which the kernel can refuse. So the kernel is obligated to give the program the memory it said it has. This is where the OOM killer comes in. In this scenario, it invokes the OOM killer to kill a program and get some memory back.
As mentioned, if you disable the OOM killer for all your containers, the only thing left which the OOM killer can kill is stuff outside the containers. If you run a box dedicated to docker, the only stuff outside containers is likely to be critical system processes. Killing these processes can result in major system instability.

Docker is not a toy, in the real world, in every cloud platform , the provider will always run docker for their customers with option -m and this will prevent system memory leaking.

This has absolutely no impact on the scenario. The cgroup memory limiting features of the kernel do not disable overcommit. If you limit a container to 100m, and the program performs a 1gb malloc call, the call will not be refused.

On the customer side, they would prefer not kill their app directly when OOM happened, that is too aggressive to acceptable.

While yes, customers would not like their programs getting killed, any hosting provider would prefer to lose a single container rather than have the entire box go down.
As I mentioned earlier, the only proper solution to disabling the OOM killer is to disable memory overcommit. With overcommit disabled, the kernel will instead refuse malloc calls if the malloc would use more memory than allowed by the cgroup limit, or is available on the box.

While yes, customers would not like their programs getting killed, any hosting provider would prefer to lose a single container rather than have the entire box go down.

how can this happen if you limit the container with -m, so you will give a tons of memory to it?

@phemmer One scenario is that user don't want his app be killed but just be hung when the container mistakenly consume more memory than expected. That has nothing to do with system hung or overcommit usage. So oom kill disable is usable.
Oom score support is usable too, but it can't cover all scenario of oom kill disable does, like the above scenario.
@HuKeping You don't get @phemmer 's point, even you limit container with -m, if you overcommit, there is still chance to crash the system. Think about you have 10 containers each of them has a limit of 500M, but you have only 4G memory on the host, if you disable oom kill for all containers, when host got low memory, the only choice it has is to kill some processes outside of containers which might be much more important.

As I mentioned:

The cgroup memory limiting features of the kernel do not disable overcommit. If you limit a container to 100m, and the program performs a 1gb malloc call, the call will not be refused.

To make this point, try the following:
docker run -ti -m 1g gcc sh -c 'cd /tmp && curl https://gist.githubusercontent.com/phemmer/fff60f857ee8ca5a74cd/raw/044f8f59be0b21857ee310e030a9629517fdfeb4/gistfile1.txt > test.c && make test && ./test'

This command will compile and run an application which allocates 2gb of memory. It runs perfectly on any system which allows overcommit (notice that the docker container is run with -m 1g).

@phemmer One scenario is that user don't want his app be killed but just be hung when the container mistakenly consume more memory than expected. That has nothing to do with system hung or overcommit usage. So oom kill disable is usable.

But this isn't what happens. If the box runs out of memory, the kernel isn't going to just hang the app, it's going to kill something. As long as the OOM killer is enabled, it's going to find something to kill, and it's going to keep killing until it either gets the memory it needs, or the kernel panics.
And as much as I consider disabling OOM killer as bad, my proposal does not preclude the possiblity of disabling the OOM killer. My proposal is about using a tunable instead of a binary on/off. It would be a lot more useful to be able to say "container X should be less likely to be targeted by OOM than container Y". As is covered in the oom_score_adj documentation, a score of -1000 will effectively disable the OOM killer.

@HuKeping

how can this happen if you limit the container with -m, so you will give a tons of memory to it?

There are two grades of OOM - "local" memcg OOM and system OOM.  If your container uses more memory than you asked for, you get a local OOM and you should be killed.
If the system overall is overcommitted, SOMEONE has to die, though you don't know who.  This is what OOM scoring is for

But this isn't what happens. If the box runs out of memory, the kernel isn't going to just hang the app, it's going to kill something. As long as the OOM killer is enabled, it's going to find something to kill, and it's going to keep killing until it either gets the memory it needs, or the kernel panics.

I'm talking about disabling cgroup oom, which is what this propose tried to do. If you disable a cgroup's oom, when the cgroup runs out of memory, it will hung the process which was trying to get some memory and can't, put it to wait queue until memory is available. Nothing will be killed.

@phemmer I'm curious about whether these 2 situations are possible:
First that the host system has overcommit enabled but inside the container overcommit is disabled where malloc will fail once past the mem limit. No memcg OOM is possible here, but the host OOM is still possible if the user is overcommitting containers.
Second is where the host system has overcommit disabled, but inside the container, overcommit is enabled. This means the process malloc succeeds past the mem limit but will get OOM killed. But the malloc can also fail in general if the container being created is going past the OS total memory.

First that the host system has overcommit enabled but inside the container overcommit is disabled where malloc will fail once past the mem limit. No memcg OOM is possible here, but the host OOM is still possible if the user is overcommitting containers.

Well, you certainly can't do it via the normal sysctl//proc/sys controls. I just tried, and killed my host when I set it inside the container. Oops.
I just looked to see if there was a way to do this via cgroups, and ran across this patch proposal which was rejected because another feature in the kernel could be used to accomplish the same goal, memrlimit. However it appears either memrlimit was removed from the kernel, or never made it past testing, as current kernels have no mention of it.
TL;DR: does not appear possible.

Second is where the host system has overcommit disabled, but inside the container, overcommit is enabled. This means the process malloc succeeds past the mem limit but will get OOM killed. But the malloc can also fail in general if the container being created is going past the OS total memory.

Given that you can't have separate overcommit settings inside the container, and outside, this scenario isn't possible.

@phemmer Thanks, good to know.


Unexpected Identifier

I followed the instructions on DevNet and I get error below when I try to run it.
I have the latest node installed.
I have git installed
I am not using an node.js IDE.
set DEBUG=sparkbot*,samples*
set ACCESS_TOKEN={mytoken} // yes I used my real token
node examples\helloworld.js
let email = command.message.personEmail; // User that created the message
^^^^^
SyntaxError: Unexpected identifier
at exports.runInThisContext (vm.js:73:16)
at Module._compile (module.js:443:25)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Function.Module.runMain (module.js:501:10)
at startup (node.js:129:16)
at node.js:814:3

The let keyword was introduced for Node.js in v4.x, which is many years old.  Can you try updating Node to a recent version (e.g. LTS v14?)

The let keyword was introduced for Node.js in v4.x, which is many years old. Can you try updating Node to a recent version (e.g. LTS v14?)

I have the latest from their website. I'm not sure why you say v4.x when I do node -v I get v0.12.2.

The let keyword was introduced for Node.js in v4.x, which is many years old. Can you try updating Node to a recent version (e.g. LTS v14?)

I literally installed 14.17.3 yet it says v0.12.2 when I check version. I don't know what's going on

What environment are you using/how is node being launched?  It seems like there is some confusion on how the app is being launched with respect to which node version is used, and/or how/where different node versions are installed?

Yea I can’t run any of these samples. I am following exactly how it says to do it in Cisco DevNet.
Sent from my iPad

On Jul 8, 2021, at 3:35 PM, dstaudt @.***> wrote:

What environment are you using/how is node being launched? It seems like there is some confusion on how the app is being launched with respect to which node version is used, and/or how/where different node versions are installed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

What environment are you using/how is node being launched? It seems like there is some confusion on how the app is being launched with respect to which node version is used, and/or how/where different node versions are installed?

I wonder when the last time these scripts were ran by whoever created them. I skipped this module and went to the next one adn I had to modify a few things to get certain things to work and then now I'm stuck on something else. These do not run as they are instructed in the module.
I am a C#/Java developer and trying to learn Node/Python and these scripts do not run as instructed.

For example.
I am doing the chatops one and if I run it passing in the arguments it runs fine. If I do what the instructions say and add my arguments into the launch.json it won't run anymore. It says "import requests" ModuleNotFoundError, but if I run it from command line passing arguments it's found. Doesn't make much sense to me.


feedback submission

Changes Unknown when pulling 18336ad8c37d56479234d5d577d1225461d98a11 on feedback-jclc into ** on master**.

:+1:

Changes Unknown when pulling 18336ad8c37d56479234d5d577d1225461d98a11 on feedback-jclc into ** on master**.

Coverage decreased (-1.5%) to 72.893% when pulling 18336ad8c37d56479234d5d577d1225461d98a11 on feedback-jclc into 20c171c057d736878313a6aef07d1edb7778bd4d on master.


WebIDL integration

DOMException does't have [[ErrorData]] internal slot. This means that we may need to work on the WebIDL side.
https://webidl.spec.whatwg.org/#dom-domexception-domexception
https://webidl.spec.whatwg.org/#js-DOMException-specialness

The slot is mandated by the JS spec, so if WebIDL lacks that slot then it should indeed be added.

I'm glad to see this issue filed and solution presented. Let's try to get a WebIDL PR out there before Stage 2.7.


Does iPad Pro's LiDAR device improve floor detection?

Description
Does iPad Pro's LiDAR device improve floor detection? Is there any significant benefit from it?
https://www.apple.com/shop/buy-ipad/ipad-pro
Version

model-viewer: v1.2.1

Browser Affected

[ ] Chrome
[ ] Safari

OS

[ ] iOS

I have no idea; hopefully? It will only affect QuickLook for now, which we have no visibility into.

Thanks

It does! AR looks so much better on the Ipad Pro. The only issue I am comming across is that there is no indication of loading when the AR button is pressed, it just stays on the same screen while it loads the object for AR behind the scenes, after a few seconds the camera opens and the AR appears right away.

@AndresMercado yeah, that annoys me too. Please file the issue with Apple, as I have no way to create a progress bar once their native quick-look app launches.


Convert to ONNX and TensorRT

Hi,
Is it possible to convert this model to ONNX or to TensorRT ?
The architecture of this model seems a bit exotic and I'm having trouble converting it to ONNX...
Any experience or information regarding this type of conversion ?

yes, this was very helpful
I managed to create the ONNX and exported to TensorRT
Got inference times around 11 ms with a 4060 TI
Thank you


Change iOS request from function to property

Seems that request from GADRequest now is a property instead of a function. Changed it accordingly.

Hi! Why exactly do you think it's a property? Did they perhaps change that in a newer version of the Pod which this plugin doesn't yet use (the plugin is at 7.37.0).
I just generated typings and it still seems to be a function, and logging also indicated it's still a function.
If there's a good reason to expect it will change to a function in the near future then we may also opt for making it backward compatible by having the {N} runtime figure it out:
      var adRequest = utils.ios.getter(GADRequest, GADRequest.request);

I would happily merge a PR using that pattern (note that it needs to be applied 3 times in this file).


OPT-300

The OPT-300 appears in the examples but not in the documentation: why?

For questions please use the github Discussions, unless you are certain it is a serious issue or bug.
If we determine that this is an issue we will create at ticket on our side to address it.

Hi,
OPT-300 is related to fields that don't exist in the regulation but are required by design. This information will be added to the "Parties" section of the documentation.

OK, I did not understand at the begin the for this kind of evidences I was expected not to open an issue but to start a conversation

Documentation version 1.3, and later, will get fixed with the next publication.


Potential issue with using --no-traffic in first deployments

I see that builders/deploy.yaml is deploying to Cloud Run with the --no-traffic flag.
The --no-traffic flag cannot be used when creating a new service, traffic will always reach the first revision. If used, the command errors out with the message:
Deployment failed
ERROR: (gcloud.run.deploy) --no-traffic not supported when creating a new service.

Is this script expected to be used to create the services? If so, I guess it would fail.
Stepping back, what is the rationale for using --no-traffic?
Is the idea that traffic should be manually routed?

I think that is being used for c/i only at the moment

/assign @sethvargo
The work in progress will make this clear.
Terraform for initial setup and this will be part of incremental, but not first, deploy


[WIP] Remove inactive reviewers/approvers  from OWNERS

What this PR does / why we need it:
Remove inactive approvers/reviewers from OWNERS
https://github.com/kubernetes/kubernetes/issues/76269
used the script from @dims
https://gist.github.com/dims/3261edf075660ad1bf5c338b8794c21b
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

NONE

@dims @hogepodge @lingxiankong @chrigl @ramineni If you are all fine with it we can remove inactive reviewers/approvers from OWNERS.

I'm totally fine with this.
/lgtm

/approve
/hold
please remove WIP when you feel ready and have pinged relevant folks.

pinged them on slack, waiting two weeks for reply,

@adisky Ad matter of fact, I do plan to jump back to work on cloud-provider-openstack for the following months.
It will be nice if you can keep me in reviewer list, but totally understand if I'm removed for now.

@ricolin Thanks for reply, welcome back, will keep your name in reviewers list.

/lgtm

please remove WIP if its final

/hold cancel


Delegate RN - remove March 31 date from upcoming changes

Last month, we announced two delegate changes that were scheduled to take place by March EOM.
https://developer.harness.io/release-notes/delegate/#important-upcoming-changes
This PR removes the date for the changes that are still pending.
What Type of PR is This?

[ ] Issue
[ ] Feature
[x] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screenshot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://660c31d9e6829646ec91c9cc--harness-developer.netlify.app


Feature/ppc support

Contribution with assembly code for ppc64le acceleration. It improves performance by about 10x on this platform.

Wow! Super contribution 👍  I will merge when tests pass and tag a new version.


lazarus: post-install works for 64bit package only

Bug Report
Package Name: lazarus (2.0.12) {32bit}
I found no existing ticket apart from this old PR, which does not address the current issue
Current Behaviour
The post-install step invariably calls the 64bit version of fpcmkcfg.exe:
https://github.com/ScoopInstaller/Extras/blob/53e014cbf04e4d692cccfe1fc7cc60c25f79e816/bucket/lazarus.json#L22
This prevents the 32bit package from being configured automatically by scoop.
Expected Behaviour
The path to fpcmkcfg.exe should depend on architecture so the configuration can be automatic for both the 32- and 64bit packages.
Additional context/output
PS C:\Users\Rob> scoop install --arch 32bit lazarus
Installing 'lazarus' (2.0.12) [32bit]
lazarus-2.0.12-fpc-3.2.0-win32.exe (160.8 MB) [===================================================================================================================================] 100%
Checking hash of lazarus-2.0.12-fpc-3.2.0-win32.exe ... ok.
Extracting lazarus-2.0.12-fpc-3.2.0-win32.exe ... done.
Linking ~\scoop\apps\lazarus\current => ~\scoop\apps\lazarus\2.0.12
Creating shortcut for Lazarus (lazarus.exe)
Creating shortcut for Lazarus (debug) (startlazarus.exe)
Running post-install script...
& : The term 'C:\Users\Rob\scoop\apps\lazarus\current\fpc\3.2.0\bin\x86_64-win64\fpcmkcfg.exe' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the
spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:3 char:3
+ & "$fpcdir\bin\x86_64-win64\fpcmkcfg.exe" -d "basepath=$fpcdir" -o "$ ...
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\Users\Rob\...it\fpcmkcfg.exe:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

'lazarus' (2.0.12) was installed successfully!

Possible Solution
After installing the 32bit package, manually generate the config:
cd $env:userprofile\scoop\apps\lazarus\current\fpc\3.2.0\bin\i386-win32
fpcmkcfg.exe -o fpc.cfg

System details
Windows version: 10.0.22000.282
OS architecture: 64bit
PowerShell version: 5.1.22000.282
Additional software: Windows Terminal (1.11.2921.0)

Yes, this is indeed a bug in manifest. Would you like to submit a fix? (I suppose you're more familiar with lazarus)

Submitted: #7298


format apm code

Coverage increased (+0.06%) to 65.772% when pulling 390e965a9c5c6776676b0a6957fa2422cbd5d08f on surechen:format_apm_code into 2267b68a148d85aabbc6a13eb059507cd8c938b4 on go-chassis:master.

再go.mod改下go-chassis-apm版本


Select Query With Sharding

OrientDB Version:   2.2.33
OS:   Linux, Windows
Expected behavior

I use this config:
{
  "autoDeploy": true, (Also I have tried false value)
  "readQuorum": 1,
  "writeQuorum": "majority",
  "executionMode": "undefined",
  "readYourWrites": true,
  "newNodeStrategy": "static",
  "servers": {
    "*": "master"
  },
  "clusters": {
    "internal": {
    },
    "class_01": {
      "servers": ["n01"]
    },
    "class_02": {
      "servers": ["n01","n02"]
    },
    "class_02": {
      "servers": ["n03"]
    },
    "*": {
      "servers": ["<NEW_NODE>"]
    }
  }
}

Does anyone use something like this config and could use this query: Select from Class (not Select from class_01 or Select from class_02 ...)
As I read "Read records", it is possible to use Select from Class. But I can't use it.
Even if I run Select from cluster:class_03 from n01 I won't have response (I will get error)
If I run Select from cluster:class_01 from n01 I will get the result.
What should I do?
Thanks

Hi @hossein-md
This issue may be  related to read quorum value  issue .
As you know R + W > N .
So please set the  "readQuorum": 1 to "readQuorum": 2 or more and try to run query again .
If you have success about it please say SALAVAT and let me know it .
Thanks
Saeed Tabrizi

Hi @saeedtabrizi
I use this config:
{
  "autoDeploy": true,
  "readQuorum": 1,
  "writeQuorum": "majority",
  "executionMode": "undefined",
  "readYourWrites": true,
  "newNodeStrategy": "static",
  "servers": {
    "*": "master"
  },
  "clusters": {
    "internal": {
    },
    "user_usa":{
         "servers" : [ "usa" ]
    },
    "user_eur":{
         "servers" : [ "eur", "usa" ]
    },
    "user_chi":{
         "servers" : [ "chi" ]
    },
    "*": {
      "servers": ["<NEW_NODE>"]
    }
  }
}

I run my servers with “dserver.sh”
I create a table named Sharding
I run “console.sh” and connect to my server:
Connect remote:localhost/Sharding root myPass
My schema:
ALTER DATABASE MINIMUMCLUSTERS 3
create class User extends V
create property User.name string
create index User.name unique
alter cluster user name user_usa
alter cluster user_1 name user_eur
alter cluster user_2 name user_chi

After use “clusters” console.sh:
|18  |user_chi |  28|User     |    0|    chi     |             |       false        |
|19  |user_eur |  27|User     |    0|    eur     |    [usa]    |       false        |
|20  |user_usa |  26|User     |    0|    usa     |             |       false        |

I use this code to insert one record per server:
public void writeTest()
{
   OrientGraph orientGraph01=new OrientGraph("remote:usa_ip/Sharding");
   HashMap properties01=new HashMap();
   properties01.put("name","name01");
   orientGraph01.addVertex("class:" + "User", properties01);
   orientGraph01.commit();
   orientGraph01.shutdown();

   OrientGraph orientGraph02=new OrientGraph("remote:eur_ip/Sharding");
   HashMap properties02=new HashMap();
   properties02.put("name","name02");
   orientGraph02.addVertex("class:" + "User", properties02);
   orientGraph02.commit();
   orientGraph02.shutdown();

   OrientGraph orientGraph03=new   OrientGraph("remote:chi_ip/Sharding");
   HashMap properties03=new HashMap();
   properties03.put("name","name03");
   orientGraph03.addVertex("class:" + "User", properties03);
   orientGraph03.commit();
   orientGraph03.shutdown();

}

I connect to DB with “connect remote:localhost/Sharding admin admin”
When I run “select * from User” in “console.sh” the output of my “dserver.sh” is:
“dserver.sh” output: ( “usa” ):
dserver.sh(usa)
“dserver.sh” output: ( “chi” ):
dserver.sh(chi)
“dserver.sh” output (“eur”):
dserver.sh(eur)
“Console.sh” output:
Error: com.orientechnologies.orient.server.distributed.ODistributedException: No active nodes found to execute command: sql.select * from User

The console output appeared after all the server thrown an error (about 5 minutes)
And I use this code to connect to graph with java-api
void printTest()
{
   System.out.println("usa output:");
   OrientGraph graph_usa=new OrientGraph("remote:usa-ip/Sharding");
   for (Vertex vertex : graph_usa.getVerticesOfClass("User")) {
       System.out.println(vertex.toString());
   }
   System.out.println("eur output:");
   OrientGraph graph_eur=new OrientGraph("remote:eur-ip/Sharding");
   for (Vertex vertex : graph_eur.getVerticesOfClass("User")) {
       System.out.println(vertex.toString());
   }
   System.out.println("chi output:");
   OrientGraph graph_chi=new OrientGraph("remote:chi-ip/Sharding");
   for (Vertex vertex : graph_chi.getVerticesOfClass("User")) {
       System.out.println(vertex.toString());
   }
}

The output is:
usa output:
v(User)[#26:0]
v(User)[#27:0]
eur output:
v(User)[#27:0]
chi output:
v(User)[#28:0]

When I changed the readquorum from 1 to 2 ("readQuorum": 2) with the same scenario I have these outputs:
In my console.sh with “select * from User”
orientdb {db=Sharding}> select * from User
Error: com.orientechnologies.orient.server.distributed.ODistributedException: No active nodes found to execute command: sql.select * from User

In my dserver.sh nothing happened! (In this time no error occured)
And the output of my java code is:
output
Thanks

Hi @hossein-md
I guess you have trouble with  hazelcast configuration file . because your'e log message shows that did not appear any active node for dispatching the messages between nodes .
did you bind other distribution nodes like the following  lines in the hazlelcast.xml file ?
<network>
		<port auto-increment="true">2436</port>
		<join>
			<multicast enabled="false">
				<multicast-group><IP_ADDRESS></multicast-group>
				<multicast-port>2434</multicast-port>

			</multicast>
			 <tcp-ip enabled="true">
				<member>localhost:2435</member>
				<member>localhost:2436</member>
				<member>localhost:2437</member>
				<member>localhost:2438</member>
			 </tcp-ip>
                </join>
	</network>

Please check it .

@hossein-md OK , i will reproduce it asap.

Hello @luigidellaquila!
I'm afraid I still experience this problem with my snapshot of OrientDB 3.0.1.
I'm  trying to set up 2 nodes (ro and boss) each containing 2 clusters for the same class (Bid). We will have a big database and I'm trying to split the data so that we never have to run a query on the entire database at once. This is why I'm trying to have each node containing exclusively the data for a certain country and only run queries on a few nodes of the database at any time.
None of the nodes should have all the clusters. So, in my test I ended up with a setup very similar to one in the issue:

{
    "@type": "d",
    "@version": 0,
    "readYourWrites": true,
    "newNodeStrategy": "static",
    "servers": {
        "@type": "d",
        "@version": 0,
        "boss": "MASTER",
        "*": "master",
        "ro": "MASTER"
    },
    "autoDeploy": true,
    "readQuorum": 1,
    "executionMode": "undefined",
    "version": 15,
    "writeQuorum": "majority",
    "clusters": {
        "@type": "d",
        "@version": 0,
        "internal": {
            "@type": "d",
            "@version": 0
        },
        "boss_bid": {
            "@type": "d",
            "@version": 0,
            "owner": "boss",
            "servers": [
                "boss"
            ]
        },
        "boss_bid_2": {
            "@type": "d",
            "@version": 0,
            "owner": "boss",
            "servers": [
                "boss"
            ]
        },
        "ro_bid": {
            "@type": "d",
            "@version": 0,
            "owner": "ro",
            "servers": [
                "ro"
            ]
        },
        "ro_bid_2": {
            "@type": "d",
            "@version": 0,
            "owner": "ro",
            "servers": [
                "ro"
            ]
        },
        "*": {
            "@type": "d",
            "@version": 0,
            "servers": [
                "boss",
                "ro",
                "<NEW_NODE>"
            ]
        }
    }
}

I eliminated the automatically created clusters for brevity but you can find the full version in this gist.
CLUSTER CONFIGURATION [wQuorum: false] (LEGEND: X = Owner, o = Copy)
This configuration appears to work -> I get this in the logs:
CLUSTER CONFIGURATION [wQuorum: false] (LEGEND: X = Owner, o = Copy)
+----------+-----------+----------+------+-------------+
|          |           |          |MASTER|   MASTER    |
|          |           |          |ONLINE|NOT_AVAILABLE|
|          |           |          |static|   static    |
+----------+-----------+----------+------+-------------+
|CLUSTER   |writeQuorum|readQuorum|  ro  |    boss     |
+----------+-----------+----------+------+-------------+
|*         |     2     |    1     |  o   |      X      |
|_studio_1 |     2     |    1     |  X   |      o      |
|_studio_5 |     2     |    1     |  X   |      o      |
|_studio_6 |     2     |    1     |  X   |      o      |
|_studio_7 |     2     |    1     |  X   |      o      |
|boss_bid  |     2     |    1     |      |      X      |
|boss_bid_2|     2     |    1     |      |      X      |
|e_4       |     2     |    1     |  X   |      o      |
|e_5       |     2     |    1     |  X   |      o      |
|e_6       |     2     |    1     |  X   |      o      |
|e_7       |     2     |    1     |  X   |      o      |
|internal  |     2     |    1     |      |             |
|ro_bid    |     2     |    1     |  X   |             |
|ro_bid_2  |     2     |    1     |  X   |             |
|v_3       |     2     |    1     |  X   |      o      |
|v_5       |     2     |    1     |  X   |      o      |
|v_6       |     2     |    1     |  X   |      o      |
|v_7       |     2     |    1     |  X   |      o      |
+----------+-----------+----------+------+-------------+

Also when I insert records into one of the nodes they balance nicely among the 2 local clusters. I created 7 records, 5 in the ro node, 2 in the boss node. When I use LIST CLUSTERS I see them all:
CLUSTERS (collections)
+----+---------------+----+---------------+-----+
|#   |NAME           |  ID|CLASS          |COUNT|
+----+---------------+----+---------------+-----+
|15  |boss_bid       |  41|Bid            |    0|
|16  |boss_bids_2    |  66|Bid            |    2|
|56  |ro_bid         |  67|Bid            |    3|
|57  |ro_bid_2       |  68|Bid            |    2|

Both nodes are online and they recognize each other:
+-------+------+--------------------------------+-----+---------+---------------+---------------+------------------------+
|Name   |Status|Databases                       |Conns|StartedOn|Binary         |HTTP           |UsedMemory              |
+-------+------+--------------------------------+-----+---------+---------------+---------------+------------------------+
|boss(*)|ONLINE|elvis-production=ONLINE (MASTER)|3    |10:59:23 |<IP_ADDRESS>:2424|<IP_ADDRESS>:2480|457.58MB/3.83GB (11.66%)|
|ro(@)  |ONLINE|elvis-production=ONLINE (MASTER)|2    |10:59:14 |<IP_ADDRESS>:2424|<IP_ADDRESS>:2480|286.38MB/1.92GB (14.59%)|
+-------+------+--------------------------------+-----+---------+---------------+---------------+------------------------+

In OrientDB Studio they all appear in the count:

However, when I try to retrieve them by running a simple
SELECT * FROM Bid

I get the error: java.lang.IllegalStateException: Cannot calculate projections without a previous source
I get this error if I run this query in OrientDB Studio and in OrientDB console but the database server itself doesn't log anything.

@luigidellaquila +1 ^

Hi all,
Sorry for the late answer, I'll try to check it ASAP and let you know
Thanks
Luigi

In the meantime, could you please post an EXPLAIN of the query on v 3.0.x?
Thanks
Luigi

Hi @luigidellaquila ! Don't mean to be a pain, but our project is under quite some time pressure and would very much appreciate if you could find some time to assist @georgiana-b with the problems she is having.

the version I'm using is 3.0.6. I have the same problem with you,Have you solved this problem?

@lunima618  I didn't but apparently there have been some commits that attempted to solve this problem and I didn't try again since. Did the version you tried include orientechnologies/orientdb@843411f?

@georgiana-b  hi,I read the documentation and said it supports shard mapreduce, but I found a problem with the query. I don't know if it's my configuration file problem or it's not currently supported. I looked at GitHub for a similar problem, but I didn't get a good solution.


Data and preprocessing

Thanks for sharing the whole project! I did not see, however, the data collection and preprocessing procedures. Did I miss anything?

Hello, most of the data is taken from Mixamo and Truebones. You can also use your own .bvh file. Moreover, you can refer (https://github.com/DeepMotionEditing/deep-motion-editing#dataset-1) to get more data.


feat(version-info): update to v5.20.0

Proposing the following what's new communication:

This looks good to me! A couple of very minor suggestions:

"a HTML component" --> "an HTML component"
"Remember recently opened files" -- the other headers are noun phrases, and this is a verb phrase. Maybe "List of recently-opened files" or just "Recently-opened files"? (Also, I think "recently-opened" should have a hyphen because it's a modifier.)
"re-open" --> "reopen"
For "Improved properties and FEEL editing", is there somewhere I can go for a full list of improvements? Not strictly necessary, but people might be curious. I think the others are fairly self-explanatory.

Thanks for your feedback. I think I addressed most of it with https://github.com/camunda/camunda-modeler/pull/4101/commits/697e523ec33af0f1a29b7ee7011fd4e577edceff.


SMTP with encrypted keys

Today the privacy is more a requirement for the Internet, and know with openbsd we can make more secure things, the idea its to make a secure keys for each send mail like, there is already service with encryption mail, but for OpenBSD can be more secure and functional.

Please write it in the opened issue not in a new one.


(node/lsstcam-shutter01.cp.lsst.org) Deploy host as EL9

I changed the name of the fqdn interface from eno1 -> enp0s31f6.


Download project devfile

What type of PR is this?
/kind feature
What does does this PR do / why we need it:
This PR adds a new flag --downloadSource which pulls down the first project specified in the list of project in the devfile.
Which issue(s) this PR fixes:
Implements #2582
How to test changes / Special notes to the reviewer:
Added unit and integrations testing for this feature.

/assign

/ok-to-test

a lot of test failures :-(
/home/travis/gopath/bin/gosec
gosec -severity medium -confidence medium -exclude G304,G204 -quiet  ./...
Results:
[/home/travis/gopath/src/github.com/openshift/odo/pkg/util/util.go:895] - G110 (CWE-409): Potential DoS vulnerability via decompression bomb (Confidence: MEDIUM, Severity: MEDIUM)
  > io.Copy(outFile, rc)
[/home/travis/gopath/src/github.com/openshift/odo/tests/helper/helper_filesystem.go:244] - G306 (CWE-): Expect WriteFile permissions to be 0600 or less (Confidence: HIGH, Severity: MEDIUM)
  > ioutil.WriteFile(devfileLocation, []byte(output), 0644)

If it makes sense to ignore the security check you can add a comment like this // #nosec G306 before the line to ignore the security check. But we need to be careful about that.

It would be great to have some integration tests that will execute the command with the flag and verify that the files get really downloaded

Seems like we can change the file permission to pass that security check. We added a series of integration tests for each type of project with the flag.

/retest

@EnriqueL8 Travis build failing due to the following errors
golangci-lint run ./... --timeout 5m

pkg/odo/cli/component/create.go:721:3: ineffectual assignment to `err` (ineffassign)

		err = errors.Errorf("Project type not supported")

		^

pkg/util/util.go:827:4: Error return value is not checked (errcheck)

		}()

		 ^

pkg/util/util.go:876:15: Error return value of `os.MkdirAll` is not checked (errcheck)

			os.MkdirAll(fpath, os.ModePerm)

			           ^

pkg/util/util.go:833:9: SA9003: empty branch (staticcheck)

	} else {

Can you add error checks to those lines?

/retest

@johnmcollier pushed changes for handling errors, but still getting some weird test failures on travis with something not related to my changes.

@EnriqueL8 Integration tests are failing also due to the --now flag being removed from odo create

Fixed the build issues on my machine, I had to update my Go version to at least 1.13
We need to document this in the repo if odo will now require a higher Go version to build it, as it previously required a much lower Go version

Not sure if only I hit this issue, after I pull down the branch and run odo create --help the flags section is broken
odo create --help                                                                                 ✔  13:25:59 
Create a configuration describing a component.

 If a component name is not provided, it'll be auto-generated.

 A full list of component types that can be deployed is available using: 'odo catalog list'

 By default, builder images (component type) will be used from the current namespace. You can explicitly supply a namespace by using: odo create namespace/name:version If version is not specified by default, latest will be chosen as the version.

Usage:
  odo create <component_type> [component_name] [flags]

Examples:
  # Create new Node.js component with the source in current directory.
  odo create nodejs

  # Create new Node.js component named 'frontend' with the source in './frontend' directory
  odo create nodejs frontend --context ./frontend

  # Create new Java component with binary named sample.jar in './target' directory
  odo create java:8  --binary target/sample.jar

  # Create new Node.js component with source from remote git repository
  odo create nodejs --git https://github.com/openshift/nodejs-ex.git

  # Create new Node.js component with custom ports, additional environment variables and memory and cpu limits
  odo create nodejs --port 8080,8100/tcp,9100/udp --env key=value,key1=value1 --memory 4Gi --cpu 2

Flags:
template: top:15:2: executing "top" at <CapitalizeFlagDescriptions .LocalFlags>: error calling CapitalizeFlagDescriptions: runtime error: index out of range [0] with length 0

@GeekArthur That's from the --now flag being accidentally removed. Once @EnriqueL8 adds it back, it should be fixed.

@johnmcollier @GeekArthur Updated with requested changes. Had to comment some integration tests out due to recent changes from https://github.com/openshift/odo/pull/2798, and there is no interactive support yet for testing. Once  https://github.com/openshift/odo/issues/2194 is implemented, those tests can be modified and added.

@johnmcollier @GeekArthur Updated with requested changes. Had to comment some integration tests out due to recent changes from https://github.com/openshift/odo/pull/2798, and there is no interactive support yet for testing. Once #2194 is implemented, those tests can be modified and added.

Another way for testing pre-defined devfile is via configuring registry to let the configured registry hosts the pre-defined devfile, once this issue https://github.com/openshift/odo/issues/2635 is done, we can go that route for testing.

/retest

Changes look good, pulled down the branch and gave it a try myself.
But, I'm not sure how we should communicate / handle the requirement that Go 1.13 (or higher) is now needed to build odo. CCing @kadel for discussion.

We are already using Go 1.13 in all our builds (CI/Release etc..)
It would be good to state minimal Go version requirements in https://github.com/openshift/odo/blob/master/docs/dev/development.adoc

/approve
/retest

/retest


[Bug] Your Bug Report Here Requesting changes to 'Get Access Request Configuration' (get-access-request-config)

Describe the bug A clear and concise description of what the bug is.
To Reproduce Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior A clear and concise description of what you expected to happen.
Actual behavior A clear and concise description of what actually happens.
Screenshots If applicable, add screenshots to help explain your problem.
Operating System (please complete the following information):

OS: [e.g. Windows 10 19044.1889, Ubuntu 18.04, Mac OS Monterey 12.4]
CLI Environment [e.g. Command Prompt, Powershell, Terminal]
Version [e.g. 1.04]

Browser (please complete the following information):

Browser: [e.g. Chrome, Firefox, Brave, Safari]
Version [e.g. 1.04]

Additional context Add any other context about the problem here.

No details were provided.


Fix issue where if DTS was NONE on a delivery server, publishing failed

Fix issue #988 by checking for NONE.  Tested with DTS configured and up (Completed), DTS configured and down (Completed with Failures), and NONE (Completed).

@rgarg24 Please review the changes so we can merge.


Do not show builder activated notification for new users

Fix for #11709
This hides the builder activated notification (black top bar) for users that never had the editor. We take the decision based on creation date, which should be pretty accurate.
Acceptance

With an old user (created_at < 2016-11-11) with the notification active (you can delete the user from the user_notifications table).

[ ] Check that the notification appears at dashboard
[ ] Check that the notification appears at dataset view
[ ] Check that the notification appears at Builder

With a brand new user (FREE signup)

[ ] Check that the notification doesn't appear at dashboard
[ ] Check that the notification doesn't appear at dataset view
[ ] Check that the notification doesn't appear at Builder

Back to dev then, let's do this right. Thanks @nobuti!

Although it could be an unnecessary worrying (because it is just a date), I'd not like to have that date in several places and without control. Why not passing it to the Frontend from Backend? Using it, for example, in the frontend-config method or just like another variable exposed in the HTML.

checked changing the created_at with the rails c in staging which worked flawslessly, also checked the next urls:
https://{user}.{host}.com/profile
https://{user}.{host}.com/your_apps
https://{user}.{host}.com/account
https://{host}.com/account/{user}/plan
but in those cases the notification wasn't appearing

Not sure if that notification is present there @matallo.

I don't think so, @noguerol ?

I feel we only displayed in dashboard, dataset and builder.

Here is the original ticket: https://github.com/CartoDB/design/issues/272
Right now, it is only displayed in dashboard, dataset and builder (i.e: this is not a regression). But maybe we want to add it to those extra urls.

Well, @noguerol decides, but I would not add that in every page

Why not? if its a global notification its weird to have them on some pages, even if they're not so visited.

Currently it is not added in every page, but ok. Back to development.

If there is not a reason for not having it on a certain page then we have no reason for not making it a global notification.
thanks buds <3

I prepared the js assets for the notification, and it is already appearing in the profile pages above. The problem (as @javitonino advanced) is we need to expose the@dashboard_notifications object in the respective controllers.
Some backender available to help? 🙏
--
also, I realized, the link in the dashboard (cartodb) and the map (cartodb3) templates are different:
one points to https://carto.com/learn/guides
the other https://carto.com/blog/categories/new-features
shouldn't they be the same?

About the link, yes, I feel we should link to guides. Because that one is updated.

updated the link, waiting for some assistance with the controllers

🚀 back to acceptance?

frontend CI is 🔴, is that expected?

arg! damn tests, should be 🍏 soon

Backend CR 👍

I'll make it! 💋

Changes made, back to CR 💃 .

I guess all checks (described in description) are completed right?

Tested in local and it works like expected. Merging!


[Bug] [dao] Rerun does not take effect in case of failure

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
After the task fails to run, it will be rerun according to the configured retryTimes, maxRetryTimes and retryInterval, but the configuration does not take effect.
What you expected to happen
Automatic rerun configuration takes effect
How to reproduce
modify class TaskInstance:
private int retryTimes;   ---> private Integer retryTimes;
private int maxRetryTimes;  ---> private Integer maxRetryTimes;
private int retryInterval;  ---> private Integer retryInterval;
Anything else
mybatis's  method  updateById,
if the field is null, it will not update,
So we can't use basic types，
The basic type will cause the value saved in the field in the database to be 0
Version
1.3.9
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

How to reproduce
modify class TaskInstance:

private int retryTimes; ---> private Integer retryTimes;
private int maxRetryTimes; ---> private Integer maxRetryTimes;
private int retryInterval; ---> private Integer retryInterval;
Hi @FrankZhang996 what your meaning about modifying class TaskInstance?


chore: fix gas price warning in integration test state reader

This change is

#1532  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on  Graphite


Update CLA landing page link

Fixes: #224
@swormke
What's this change do?
I did a search and replace to swap the old github.io URL with the new read the docs URL.
Where should the reviewer start?
Review the changes below.
Any background context?

Nice.


Add documentation provider

For case when last version(7.0.1) of project plugin rebar3_hex is used for publication of documentation to hex.pm, can be received second warning:
$ rebar3 hex publish docs
...
===> Verifying dependencies...
===> docs argument given, will not publish package
===> No documentation provider was configured, docs will not be generated

For this case was added provider as suggested in rebar3_hex documentation.

Pull Request Test Coverage Report for Build 296

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.375%

Totals

Change from base Build 294:
0.0%

Covered Lines:
1296

Relevant Lines:
1518

💛  - Coveralls

Could you please add the explanation you wrote in the pull request to the commit message too?

Done.

Thank you!


GH-1634 javadoc aggregate

GitHub issue resolved: #1634
Briefly describe the changes proposed in this PR:

javadoc aggregate creation has been moved to root pom as per https://maven.apache.org/plugins/maven-javadoc-plugin/examples/aggregate.html
removed obsolete assembly profile from core module pom
release script modified to handle simpler way to generate javadoc and SDK zip.

Lgtm


permission issue on tables after initial docker deploy with external postgresql instance

docker log shows this before running the schema.sql against the db:
}
PrismaClientKnownRequestError2 [PrismaClientKnownRequestError]: The table `public.account` does not exist in the current database.
    at cb (/app/node_modules/@prisma/client/runtime/index.js:34774:17)
    at processTicksAndRejections (internal/process/task_queues.js:97:5) {
  code: 'P2021',
  clientVersion: '2.19.0',
  meta: { table: 'public.account' }
}

then i run postgres@host:~$ psql -dumami -f schema.postgresql.sql
which gives me this:
psql:schema.postgresql.sql:1: NOTICE:  table "event" does not exist, skipping
DROP TABLE
psql:schema.postgresql.sql:2: NOTICE:  table "pageview" does not exist, skipping
DROP TABLE
psql:schema.postgresql.sql:3: NOTICE:  table "session" does not exist, skipping
DROP TABLE
psql:schema.postgresql.sql:4: NOTICE:  table "website" does not exist, skipping
DROP TABLE
psql:schema.postgresql.sql:5: NOTICE:  table "account" does not exist, skipping
DROP TABLE
CREATE TABLE
CREATE TABLE
CREATE TABLE
CREATE TABLE
CREATE TABLE
CREATE INDEX
CREATE INDEX
CREATE INDEX
CREATE INDEX
CREATE INDEX
CREATE INDEX
CREATE INDEX
CREATE INDEX
CREATE INDEX
CREATE INDEX
CREATE INDEX
INSERT 0 1

so that looks pretty successful
but then when i want to log in with the default credentials admin/umami, i get this:
PrismaClientUnknownRequestError2 [PrismaClientUnknownRequestError]: Error occurred during query execution:
ConnectorError(ConnectorError { user_facing_error: None, kind: QueryError(Error { kind: Db, cause: Some(DbError { severity: "ERROR", parsed_severity: Some(Error), code: SqlState("42501"), message: "permission denied for table account", detail: None, hint: None, position: None, where_: None, schema: None, table: None, column: None, datatype: None, constraint: None, file: Some("aclchk.c"), line: Some(3485), routine: Some("aclcheck_error") }) }) })
    at cb (/app/node_modules/@prisma/client/runtime/index.js:34778:17)
    at processTicksAndRejections (internal/process/task_queues.js:97:5) {
  clientVersion: '2.19.0'
}

i loaded the schema with the postgres default admin user, so maybe the actual user i'm using for the app might not have all privileges. could anybody point me in the right direction for troubleshooting this?

ok nevermind, i think those might have been stale connections. the error magically disappeared now.

Hi @whysthatso ! I've followed these instructions and am now facing a similar error. Do you have any idea on why that might be?

@4ortytwo yes, and that might have been part of the problem, but i am not that well versed with postgresql so i can't be certain.

Thanks, I solved the issue https://github.com/code-fabrik/open-knowledge/issues/1, had to run command from umami repo to create db. Will post solution later.


groups: port missing functionality

Implement user group manage function

Add filter on list of group that user can join.

Signed-off-by: Leonardo Rossi<EMAIL_ADDRESS>

Changes Unknown when pulling a8160caa01cd81c56a6a20951bbb83137a928839 on hachreak:1788_groups_port_missing_functionality into ** on inveniosoftware:pu**.


Expose a programmatic API

We are using this module in https://github.com/agentk/fontfacegen, but unfortunately, without a programmatic API, it is a bit hard to integrate. I think it should be a simple matter of adding a main field to package.json, as follows:
{
...
main: 'index.js'
...
}

Helps solve https://github.com/agentk/fontfacegen/issues/32

Close as declined - path should be resolved properly at your side.


nfsv3driver pre-start fail with "cp: cannot create regular file '/usr/bin/fusermount': Text file busy"

Just about every time I re-deploy nfsv3driver to an existing vm the pre-start script fails with the log data:
+ cp lib/.libs/libfuse.so lib/.libs/libulockmgr.so /usr/lib
+ cp util/fusermount /usr/bin
cp: cannot create regular file '/usr/bin/fusermount': Text file busy

Watching processes while doing a deploy I noticed that fuse-nfs is running when the pre-start script executes.  I believe that pkill https://github.com/cloudfoundry-incubator/nfs-volume-release/blob/master/jobs/nfsv3driver/templates/install.erb#L6 is returning before fuse-nfs has stopped and therefore fusermount is busy when it gets to https://github.com/cloudfoundry-incubator/nfs-volume-release/blob/master/jobs/nfsv3driver/templates/install.erb#L11
It might be a good idea to wait until no fuse-nfs processes are running before continuing with the pre-start script.
You may not see this in your environments because mine might be faster at copying files or slower at killing fuse-nfs than your infrastructure.

hmm--ideally, the pkill in the pre-start script isn't supposed to have to do anything because any mounts that were running on the cell are supposed to get unmounted when the workload is drained off of the cell.  It seems as though perhaps that isn't working correctly?
In our CI pipeline, we don't normally carry mounts across bosh deploys, so my best guess is that we don't see this issue because we aren't testing for it.
We'll try re-deploying diego while there are active mounts and see whether or not we can reproduce the issue on our side.

In my dev environment I'm only running on a single cell.  Which I learned yesterday means that the cell doesn't ever properly drain because the rep makes sure instances start somewhere else before completing drain.  So, that might be playing into the situation too.  I'll run a test with 2 cells to see if I experience the same problem.  With a single cell it happens quite consistently.

@julian-hj yeah, it appears it could be related to Diego evacuation timing out before all apps are drained.
If I have 2 nodes and diego.rep.evacuation_timeout_in_seconds=600 then everything seems to work great.
if I have 2 nodes and diego.rep.evacuation_timeout_in_seconds=0 or only 1 cell then I often get this failure.

Interesting, we were seeing this problem on our landscapes too, and I had to hotfix in a sleep after the pkill to ensure that fuse-nfs and fusermount were not busy.
However we have diego.rep.evacuation_timeout_in_seconds=0 set too, so maybe that's the cause.

Turns out that because pkill just signals the process to die, we do need to wait a bit before continuing as @silvestre suggests.  We fixed this by pgrepping in a loop until we don't find any fuse-nfs processes anymore.


CI: Fix botched handling of OPENIMAGEIO_CMAKE_FLAGS during CI builds

The gh-installdeps.bash file accidentally squashed any value that
the env variable already had. Oops.
Signed-off-by: Larry Gritz<EMAIL_ADDRESS>

@AlexMWells This is what was preventing proper setting of the fmt version by the CI scripts!


OSX Build: md5sum and /proc/cpuinfo needed

Followed current build instructions for OSX but building with bazel on OSX/macos also needs a md5sum binary and a /proc/cpuinfo file.
cheap fix (would be better not to grep /proc/cpuinfo or to use 'sysctl -a hw' on OSX):
brew install md5sha1sum
sudo mkdir -p /proc
sudo docker run <linux-image-you-have> cat /proc/cpuinfo  > /proc/cpuinfo

Also OSX Sierra (10.12.x) or greater is required to get the required 8.3.3 version of xcode.  The AppStore will spin forever if you try to upgrade xcode on an earlier OSX.
Complaints before cheap fix:
WARNING: /Users/*/envoy-filter-example/envoy/bazel/repositories.bzl:26:5: /private/var/tmp/_bazel*/60fe7735f74821add3f845fcade3ae2a/external/envoy_deps/./repositories.sh: line 9: md5sum: command not found

WARNING: /private/var/tmp/_bazel*/729952d62f84db3f8ddad6d51f4d2c7d/external/envoy/bazel/repositories.bzl:18:5: Fetching external dependencies...
External dependency cache directory /private/var/tmp/_bazel*/729952d62f84db3f8ddad6d51f4d2c7d/external/envoy_deps_cache_2c744dffd279d7e9e0910ce594eb4f4f
grep: /proc/cpuinfo: No such file or directory

I just reviewed my install history and I think this can be closed.   I was looking at fixing these issues and noticed that they occurred before I updating the envoy submodule in envoy-filter-example. After updating, the files with the warnings cited have OS X/Darwin specific fixes.
Sorry for the noise.

OK closing.


[Meta] Git tags and / or a changelog file?

I was browsing through to update to 0.7, but wanted to know the changes but noticed there is no easy way like a CHANGELOG file or git tags or github releases, this issue is to ask for them to be added (git tags should be the easiest).

[x] git tags
[x] github releases
[x] changelog file

In particular I would ask for breaking changes notice. Of course, the answer had to be in PR #42

Thanks for the suggestion. Definitely needed. Starting from 0.7.1 there will be changelogs and releases.


Invalid URL in README.rst

https://github.com/openedx/tutor-contrib-aspects/blob/fb3efbb58bffab9d4f4f07c6fd3fb8e7f24cdc03/README.rst?plain=1#L10
The plugin docs URL scheme has been repeated by mistake.
Insignificant change, but I can make the PR if I could push my branch.

Hi @moonesque, thanks for your report. For contributions you can fork this repo and push your branch to it, then you can open a PR from the fork to this repo

Hi @moonesque , we actually would need a license agreement with you to accept a PR which is some paperwork and a bit of a process. Unless you are planning to do other work in the openedx org (which we'd love!) this issue is probably the right way to go and we can take care of it.


Fixes up error log notice from user profile page

What's this PR do?
Move reportback gallery theme into the 'if there are reportbacks' check.
How should this be reviewed?
👀
Any background context you want to provide?
this changes nothing, except now there is one less error in the log.
Relevant tickets
Fixes #6529
Checklist

[ ] Tested on staging.

looks good to me 🚢


Very slow on repos with large numbers of PRs

We use a (mostly) mono-repo setup with many developers creating branches and submitting PRs to main. At the moment we have about 120 PRs and 2400 branches (a small number are "perennial" in the git-sync parlance but most are not). Historically though we've had on the order of 100,000 PRs opened - and this seems to be the issue. It looks like the action is enumerating all PRs ever made into a repository. It takes the action ~15 minutes to update the PR description, which is longer than our other CI tasks take.
I think adding a look back limit with some sane defaults (last 100?) on the PR enumeration would help a lot (adding sort: desc; page: 1 to getPullRequests instead of paginating).

@aroon-color Thanks for reporting this! I was curious how the action would perform for large repos so this is perfect feedback.
Yeah, enumerating all PRs/branches is certainly not optimal! The reason why is if we don't, the stack graph may not render properly due to the required PRs/branches in the stack being missing from fetched repo data.
15 minutes sounds like an incredibly long time though. Each page is 100 items, so a request taking ~1s should only take 24 seconds to fetch 2400 branches. Sounds like we're being rate limited by the GitHub API? Is the action consistently taking 15 minutes, or was that happening when there were 100k PRs open?
Either way, I'll look into options for reducing the dependence on the GitHub API. In the meantime if there's any more information you come across I'd love to know about it! Thanks again for reporting this in! 🙌

That's a great problem to have! What do you think about these ideas to reduce the number of PRs that are looked at? I don't have too much background on how this action works, so I might be missing something obvious :)

Limit PR history to a configurable timeframe: For example, only consider PRs that were closed within the last 6 months. This threshold could be user-configurable. While some stacks may require a longer window, I suspect most users would be fine if the extension didn't handle such edge cases. If an older PR is encountered, the tool could print a notification to inform the user.

Early exit when enough data is collected: Could the action stop traversing PRs once it has all the necessary information? For instance, once it determines all ancestor branches up to the main branch (or a perennial branch), it should have everything it needs, no? AFAIK all relevant descendants should have open PRs.

That makes it incredibly fast, down to between 10-15 seconds depending on the stack depth (2-10) from 15 minutes! Thanks for being so responsive 🥳

Awesome!! This is available in v1.0.8. This doesn't require any changes from your end as long as you're using the v1 version tag. Thanks again for reporting this issue! 🚀


DPRINT/Watcher support for idle ethernet cores

CI running: https://github.com/tenstorrent/tt-metal/actions/runs/8806874607

CI passing after extra changes/rebase: https://github.com/tenstorrent/tt-metal/actions/runs/8808751748


rubocop issues: section.rb

== app/presenters/menu/section.rb ==
R:  3: 19: Avoid parameter lists longer than 5 parameters.
C: 39:  5: Use 2 (not 1) spaces for indentation.

@miq-bot add_label cleanup/rubocop

Hi Martin, can you please explain how can I check what exactly broke this patch, I played a little with ManageIQ UI and did not see something exceptional.


refactor!: remove itemType param in get/collection operation

Description
Remove itemType param in get/collection operation and instead use .split().body().unmarshal().json(...)
Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[x] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

Can you send a PR for main branch first - we must make sure the main branch is up to date also


identify shutdown "within" or "outside"

How do I identify whether it is an internal shutdown of the virtual machine or an external shutdown of the virtual machine?

@attlee-wang could you please be more precise about what you mean by internal or external shutdown?

@alicefr  internal: os shutdown，such as user exec shutdown -h now at VM insite.  external:  In addition to kubevirt components by other exceptions caused，such as the problem with the system disk.

AFAIU, if user executes inside the guest shutdown or poweroff, then the pod/VMI should be in Completed/Succeeded state. If there is an error with the system, I'd expect some kind of error message. For example, on IO errors, the guest is in paused state, but the virt-launcher still runs and an event is thrown.
Otherwise, if you are talking about errors during boot, again the virt-launcher pod should be running, and for example you can run vnc to check what caused the problem.
Or do I understand this wrong?


Can't restore Wallet

Hello, I download new app, and tried to restore my wallet, fill all 12 words, pushing restore, than seeing preloader, and after 10-15 sec button again available and nothing happened

Sadly, this service/wallet has been shutdown. Try using your mnemonic in a different wallet either official Chia wallet or Evergreen mobile wallet.


How to add a page

Hello, I want to add a page to toha. I tried to do it by creating a markdown file which I placed in the data folder but I kept getting this error.
unmarshal of format "" is not supported
Is there a specific folder where I can put a markdown file to create a new page? Does toha support a different syntax?

What do you mean by page? Did you mean post?

No, I mean like creating a page that is not the homepage and its sections.

Well, then it's not that easy. You have to create a custom layout for your page. Eventually, I will write a post about how to add custom layout but I can't do it  now.
This branch has an example of custom layout.
https://prometheus.io/docs/prometheus/latest/configuration/alerting_rules/
Check the layout folder. It creates two layout. One for about page and another for contact me page. Once you have created the layouts, you have to write your markdown text in content/<layout name>/_index.md. Check the content/about and content/contact folder for sample.

I have the same issue, I want to add a page for the imprint but can't figure out how.
@hossainemruz in which branch can I find a custom layout as described in the last comment?

Didn't notice that I have provided wrong link for custom layout. Btw, here is the branch with custom layout: https://github.com/hossainemruz/toha-example-site/tree/custom-layout

@hossainemruz since I'm documenting how to add a custom section now as part of https://github.com/hossainemruz/toha/issues/87 I can probably tackle this as well. I am a little confused though, is the request to add a custom section on the main page (like issue 87) or to add a completely standalone page with its own route and everything? Would it need to show up in the navigation?

@alex-bezek I think we should document both adding a new section and a new page. User can use customMenus option if they want to show it in navigation.

PR opened here https://github.com/hugo-toha/guides/pull/13

I have a bit of experience with Hugo and I've managed to pick another theme (Elate) and split it's sections into separate pages. Yet in this case I fail to see how should I do so.

I have a bit of experience with Hugo and I've managed to pick another theme (Elate) and split it's sections into separate pages. Yet in this case I fail to see how should I do so.

Here is a guide on how to add new section:
https://toha-guides.netlify.app/posts/customizing/new-section/


[Documentation] Notice on README about limitations?

Hi! Thanks for the crate!
I wanted to ask if you would consider adding some words about the grammar being parsed, how it relates to (La)TeX and what are the limitations.
I know (La)Tex is super hard to parse, as the parser can be reconfigured during parser...
But it would be nice to know your approach and limitations.
On a side note, I would really enjoy a "development blog" on what were the difficulties while developing the tree-sitter grammar for LaTeX.
I would like to give developing a parser for LaTeX-like syntax a try.

@saona-raimundo I have added a section in the README regarding some limitations.

I know (La)Tex is super hard to parse, as the parser can be reconfigured during parser...

Yes, the only correct way to write a LaTeX parser would be to write a TeX engine that "compiles" the document from start to finish and outputs every step it does along the way. This is a very complicated task so this grammar and texlab uses a best-effort approach instead. We do not try to parse constructs like catcode and focus on the constructs specific to LaTeX (and not TeX).
This grammar originates from the language server so performance is also very important. Potential infinite loops or reparsing every document on every keystroke (which would be needed when going with the TeX engine approach unless you find a way to make the procesing incremental) are undesirable in an editing context.

I would like to give developing a parser for LaTeX-like syntax a try.

The difficulty highly depends on the degree of correctness you want to achieve. This parser (and the one in texlab) only parse a subset of LaTeX, which is easy to parse. If you want to go the complete route, I recommend looking at tectonic. Maybe you can fork it and remove the generation of the output and output the macro expansions along the way.


Hide 'Clear filters' on storefront when filters are not applied

I want to merge this change because...
'Clear filter' link should be visible only when some filtering is applied on products.

Pull Request Checklist
(Please keep this section. It will make maintainer's life easier.)

[x] Privileged views and APIs are guarded by proper permission checks.
[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[x] Database queries are optimized and the number of queries is constant.
[x] The changes are tested.
[x] The code is documented (docstrings, project documentation).
[x] Python code quality checks pass: pycodestyle, pydocstyle, pylint.
[x] JavaScript code quality checks pass: eslint.

Codecov Report

Merging #1405 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1405      +/-   ##
==========================================
- Coverage    82.9%   82.88%   -0.03%
==========================================
  Files         128      128
  Lines        5775     5777       +2
  Branches      663      621      -42
==========================================
  Hits         4788     4788
- Misses        830      831       +1
- Partials      157      158       +1

Impacted Files
Coverage Δ

saleor/dashboard/product/filters.py
100% <100%> (ø)
:arrow_up:

saleor/dashboard/customer/filters.py
100% <100%> (ø)
:arrow_up:

saleor/dashboard/order/filters.py
100% <100%> (ø)
:arrow_up:

saleor/dashboard/staff/filters.py
100% <100%> (ø)
:arrow_up:

saleor/core/filters.py
100% <100%> (ø)

saleor/dashboard/discount/filters.py
100% <100%> (ø)
:arrow_up:

saleor/dashboard/group/filters.py
100% <100%> (ø)
:arrow_up:

saleor/dashboard/shipping/filters.py
100% <100%> (ø)
:arrow_up:

saleor/dashboard/category/filters.py
100% <100%> (ø)
:arrow_up:

saleor/core/analytics.py
71.87% <0%> (-3.13%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 017da02...baf81de. Read the comment docs.


Fix service cluster plugin bug

Please answer these questions before submitting pull request

Why submit this pull request?

[x] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues
#3069

All fixed and added IT tests

@wu-sheng please review

@arugal I have changed the title of this PR, please add a clear title next time, to benefit search.

look like only Zookeeper coordinator needs to change for receiver mode

Zookeeper Nacos and Consul

Such as, what is the bug of NacosCoordinator? I know you change the codes, but it doesn't seem like bug, more like just code refactor.  Do I miss anything?

https://github.com/apache/skywalking/blob/1d13d735bbc1db1edd5a70b92b6bffd40bd9e4cc/oap-server/server-cluster-plugin/cluster-nacos-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/nacos/NacosCoordinator.java#L48-L65
When the node is set to Receiver mode, #registerRemote is not invoker, selfAddress is null, right?

Got your point. Make sense. Waiting for CI to merge.

I missed the IT test of k8s

I missed the IT test of k8s

I know. We need k8s e2e test as a higher priority, if you have interests, we could discuss that.

We need k8s e2e test as a higher priority

So I don't need to add IT test of k8s for the time being ?

if you have interests, we could discuss that.

Yes

/run ci

So I don't need to add IT test of k8s for the time being ?

For now, yes. You don't need to do that.

if you have interests, we could discuss that. Yes

Do you have my personal mail/wechat/qq group? Ping me there. I could set up a discussion group for k8s e2e test

/run e2e

/run e2e

Check the e2e, whether this change breaks test. We test e2e w/ zookeeper