refactor: recipient field

Opening this as a draft PR to get feedback on the implementation here in the STX form. Once the implementation is agreeed on, I will implement in the BTC form and Stacks Sip10.

This is looking good! 👏

Going to move on here and implement with other forms, and then I will open the PR.

Opening this up for review.

@markmhx @mica000 I'm going to merge this into dev so it doesn't get behind. Please review the build there for recipient field / send form changes.


In order to get additional information about the authorized user, as a developer I need a way to access additional fields in the token response.

Some services (i.e. Dropbox: https://www.dropbox.com/developers-v1/core/docs#oauth2-methods) return additional fields in the token response in order to give a client a user identifier.
At present there is no clean way to access these fields.

done


NIFI-6255 NIFI-6287: Hash function for expression language and record…

… path.
Expression function = ${field.value:hash('MD5')}
Record Path function = hash(/field, 'MD5')
Description of PR
hash functions
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Thanks for contributing this functionality. My only question is what happens when the user provides an unsupported algorithm name or doesn't format it explicitly as supported by Java's MessageDigest? Can we improve the messaging in the errors and provide an enumerated list of the exact strings to use in the documentation for both Expression Language and RecordPath syntax?

Thanks for contributing this functionality. My only question is what happens when the user provides an unsupported algorithm name or doesn't format it explicitly as supported by Java's MessageDigest? Can we improve the messaging in the errors and provide an enumerated list of the exact strings to use in the documentation for both Expression Language and RecordPath syntax?

as is it returns an error, saying unsupported algorithm name: the_name given.
Does the list change? message digest docs. Because I would have to update the list to match the java version. The alternative is a utility class to pull the security providers out and list them in the error message.

I don't think the error has to explicitly list all the available options, but I think the docs should. The error can just reference the docs to let people know where the definitive list is.
The list of supported algorithms does not change frequently, and the docs can be updated in the event the list changes.
There are some examples of our current hash usage in HashService and HashAlgorithm. I believe in the docs for CryptographicHashContent the possible values are enumerated even though it's a drop-down list in the processor configuration rather than a freeform text field.

I don't think the error has to explicitly list all the available options, but I think the docs should. The error can just reference the docs to let people know where the definitive list is.
The list of supported algorithms does not change frequently, and the docs can be updated in the event the list changes.
There are some examples of our current hash usage in HashService and HashAlgorithm. I believe in the docs for CryptographicHashContent the possible values are enumerated even though it's a drop-down list in the processor configuration rather than a freeform text field.

Ok, I added the list dynamically to the error message, also to the docs.

Going to close and rebase to master

Closing to re-open on master


GJS programs need to be wrapped specially

Describe the bug
See https://gitlab.gnome.org/GNOME/gjs/-/blob/1.80.2/modules/script/package.js#L38. The name of the js file is used to decide the resource file path. When the js file is wrapped by the wrapGAppsHook, the js file is moved to .<original name>-wrapped and a wrapper is generated to run this js file. The js file is run with shebang and the wrapped name is used by gjs. So the resource file can't be found.
Steps To Reproduce
See https://github.com/NixOS/nixpkgs/pull/318829 for example.
Expected behavior
When wrap the gjs script the file name is not changed.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers
@NixOS/gnome

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

Add a :+1: reaction to issues you find important.

the wrapper hook would use makeBinaryWrapper. as a workaround for now, have you tried with dontWrapGApps = true; + wrapProgram instead?

I thought makeBinaryWrapper is used by default and I don't know how it's supposed to make any difference. :shrug: I just tested and it doesn't work.

make(Binary)Wrapper takes 2 positional args, so that you can specify the wrapper name.

You need to patch package._findEffectiveEntryPointName, see for example:
https://github.com/NixOS/nixpkgs/blob/aa05442b89788a13a4620f8c71c27e20d449abe8/pkgs/desktops/gnome/core/gnome-shell/wrap-services.patch#L10-L12

Yep, another workaround... Can we have a wrapGjsHook which patch the file automatically?

It is difficult to automatically find what file to patch, and where to patch it.


Wrapped requires do not pass on type information

Hi,
Not sure if this is a bug or feature request, but in the nvim community we are trying to improve the loading of plugins built with lua by lazy loading things. A example project doing this is https://github.com/tjdevries/lazy.nvim
When trying to implement lazy loading for lua modules (in the context of neovim plugins) wrapping the require into a setmetatable to delay requiring a module till it is indexed does not return the module type information when you hover over variables or try to autocomplete things.
e.g.
local lazy = {}

--- Require on index.
---
--- Will only require the module after the first index of a module.
--- Only works for modules that export a table.
lazy.require_on_index = function(require_path)
  return setmetatable({}, {
    __index = function(_, key)
      return require(require_path)[key]
    end,

    __newindex = function(_, key, value)
      require(require_path)[key] = value
    end,
  })
end
return lazy

-- In my module
local lazy = require('module.lazy')
local module = lazy.require_on_index('module') -- |has no type information just any|

I originally raised this in https://github.com/tjdevries/lazy.nvim/issues/1 but I'm wondering if it is possible to pass on the type information somehow from the lazy require function so the lsp treats modules required with the lazy module as it would a module/variable required with the global require?
Could there be an extra annotation such as
---@import telescope.path
local path = lazy_require('telescope.path')
-- or even nice
---@require
lazy.require_on_index = function(require_paath)
end

Currently you can use Lua.runtime.special to treat a global variable as require.
But this may not meet your needs. I thought about it. It may only be achieved by manually marking the type, which is the ---@import requirename you gave.
I currently cannot support markup methods like ---@require, because these special functions (require, pcall, rawset, etc.) need to be confirmed in the parsing stage, and this markup method can only be used correctly in the semantic parsing stage.

@sumneko thanks for thinking it over, I think some annotation like @import that at least allows the return value to be specified as the content of the module would be really great especially if something like @require is not currently possible.

I want to use ---@require 'filename with space(or other symbols)' # Use require instead of import, because Lua's search rules are used instead of the real path of the file

@sumneko would it be possible to use just the name of the module since that would be easiest and file paths will be quite long and distracting for example
---@module module.submodule
local submodule = lazy.require('module.submodule')

What I mean is to use module name.
Just considering that the module name can also contain spaces, symbols and Unicode, it should be turned into a string with quotation marks.
---@module 'module.submodule'
local submodule = lazy.require('module.submodule')

Ah, that makes sense I never use special characters in my module names so forgot it was possible, but yeah quotes seem like a good solution for that


A StreamObj implementation

I stole/borrowed the code from the core::future::future_obj module. Now I can store a Stream in a struct and pass it around, so that's cool.
Outstanding questions:

how do I test it?
do I need to edit these docs?

Closes #1221

What's still missing:

Add the parts from src/libcore/mem.rs
if_std! { ... } part at the end that adds the parts from src/liballoc/boxed.rs

Thanks for implementing this! 🙂

About your questions:

Yes, the docs need to be in shape
Tests are not required because it's just a temporary solution until Stream becomes object safe.

@MajorBreakfast thanks for the feedback! I've addressed everything except if_std! {...}. I don't follow what parts of this stream_obj.rs need to rely on std.

Should I put https://github.com/rust-lang/rust/blob/0dd88c97975b2a2e4ea3e4a2bdc3670a9f40bd67/src/liballoc/boxed.rs#L939-L975 and https://github.com/rust-lang/rust/blob/0dd88c97975b2a2e4ea3e4a2bdc3670a9f40bd67/src/liballoc/boxed.rs#L993-L1019 inside of if_std!?

@xrl everything from liballoc goes into if_std!

@MajorBreakfast OK, cool! I've added the code from liballoc. I think this addresses the last of the feedack.

Any idea why the thumbv6m-none-eabi arch doesn't have std::fmt?

@xrl you can use core::fmt, none of std is available on that target but basic functionality is instead exported from the core crate.

Still contains the word "future" a few times 😉

Merged. Thanks!


Why type of variable 'd' cannot be determined?

Code:
  for k in range(segment_num + 6):
      slope_distribution = np.zeros(shape=(11,))
      scaled_degree = patched_raw_slope_distributions[k]
      scaled_degree = (scaled_degree-min_slope) / (max_slope-min_slope)
      for d in scaled_degree:
          slope_distribution[int(d * 10)] += 1
      slope_distributions.append(slope_distribution)

Output:
Type of variable 'd' cannot be determined, operation: $phi648.1, location: /home/tushihao/EEG-50-Server/NineModel13/dataset.py (92)

File "dataset.py", line 92:
def multi_metric_distribution_with_patch(segments, segment_num, segment_length, patch):
    <source elided>
        scaled_degree = (scaled_degree-min_slope) / (max_slope-min_slope)
        for d in scaled_degree:
        ^

@iDestro thank you for asking about this. Unfortunately, we can not debug this code because it is not fully runnable. Please provide a fully runnable example. Thank you!

Closing this issue as it seems to be resolved. If this is not the case please re-open with a comment about any item that appears to be unresolved. Many thanks.


Link to Debian 7.8 in gitian build guide.

Link to 7.7 is broken. Will rebase once master is merged back in.

Merged up, rebase away!

Rebased

ACK. Also, if you didn't see last week, the certificate issue on bitcoincore.org is resolved now (turns out it was a bad server config). So Debian should be able to fetch fine now. Not sure if there's anywhere we need to document that.


Extra prefixes in commands are not recognised as invalid format

The error message is targeted at the previous prefix instead of showing the command usage.

For future features

Merged into #299


Remove unused values from column options

these fields are causing problems after updating doctrine/dbal and we have to remove them

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


setvbuf test in ostest fails on MACOS with 'Illegal instruction: 4'

Steps to reproduce:

./tools/configure.sh sim:ostest
make -j8
./nuttx
Observe next output

$ ./nuttx
stdio_test: write fd=1
stdio_test: Standard I/O Check: printf
stdio_test: write fd=2
stdio_test: Standard I/O Check: fprintf to stderr
ostest_main: putenv(Variable1=BadValue3)
ostest_main: setenv(Variable1, GoodValue1, TRUE)
ostest_main: setenv(Variable2, BadValue1, FALSE)
ostest_main: setenv(Variable2, GoodValue2, TRUE)
ostest_main: setenv(Variable3, GoodValue3, FALSE)
ostest_main: setenv(Variable3, BadValue2, FALSE)
show_variable: Variable=Variable1 has value=GoodValue1
show_variable: Variable=Variable2 has value=GoodValue2
show_variable: Variable=Variable3 has value=GoodValue3
ostest_main: Started user_main at PID=4

user_main: Begin argument test
user_main: Started with argc=5
user_main: argv[0]="ostest"
user_main: argv[1]="Arg1"
user_main: argv[2]="Arg2"
user_main: argv[3]="Arg3"
user_main: argv[4]="Arg4"

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     3efffe8  3efffe8
ordblks         2        2
mxordblk  3eb98f0  3eb98f0
uordblks    466c8    466c8
fordblks  3eb9920  3eb9920

user_main: getopt() test
getopt():  Simple test
getopt():  Invalid argument
getopt():  Missing optional argument
getopt_long():  Simple test
getopt_long():  No short options
getopt_long():  Argument for --option=argument
getopt_long():  Invalid long option
getopt_long():  Mixed long and short options
getopt_long():  Invalid short option
getopt_long():  Missing optional arguments
getopt_long_only():  Mixed long and short options
getopt_long_only():  Single hyphen long options

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     3efffe8  3efffe8
ordblks         2        2
mxordblk  3eb98f0  3eb98f0
uordblks    466c8    466c8
fordblks  3eb9920  3eb9920
show_variable: Variable=Variable1 has value=GoodValue1
show_variable: Variable=Variable2 has value=GoodValue2
show_variable: Variable=Variable3 has value=GoodValue3
show_variable: Variable=Variable1 has no value
show_variable: Variable=Variable2 has value=GoodValue2
show_variable: Variable=Variable3 has value=GoodValue3

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     3efffe8  3efffe8
ordblks         2        3
mxordblk  3eb98f0  3eb98f0
uordblks    466c8    466a8
fordblks  3eb9920  3eb9940
show_variable: Variable=Variable1 has no value
show_variable: Variable=Variable2 has no value
show_variable: Variable=Variable3 has no value

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     3efffe8  3efffe8
ordblks         3        3
mxordblk  3eb98f0  3eb98f0
uordblks    466a8    46618
fordblks  3eb9940  3eb99d0
tls: Successfully set 0
tls: Successfully set ffffffff
tls: Successfully set 55555555
tls: Successfully set aaaaaaaa

End of test memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     3efffe8  3efffe8
ordblks         3        3
mxordblk  3eb98f0  3eb98f0
uordblks    46618    46618
fordblks  3eb99d0  3eb99d0

user_main: setvbuf test
setvbuf_test: Test NO buffering
Illegal instruction: 4

The issue is not reproduced with CONFIG_STDIO_DISABLE_BUFFERING=y

@pkarashchenko Did you try an old version?

Old version of MAC OS or older version of the code?

Currently tested only with NuttX mainline and MAC OS 13.4.1

Just found that line stream->fs_bufend   = newbuf + size; leads to Illegal instruction: 4 if newbuf is NULL and size is 0.

The size value does not matter. It is reproduced with -fsanitize=undefined option when NULL pointer participate in arithmetic operations (add or subtract).

If I replace -fsanitize=undefined with -fsanitize=pointer-overflow, I'm getting
user_main: setvbuf test
setvbuf_test: Test NO buffering
ubsan_prologue: ================================================================================
ubsan_prologue: UBSAN: pointer-overflow in stdio/lib_setvbuf.c:243:32
ubsan_epilogue: ================================================================================
setvbuf_test: Using NO buffering

Seems to be caused by CONFIG_MM_UBSAN_TRAP_ON_ERROR=y

Clang:
-fsanitize=pointer-overflow: Performing pointer arithmetic which overflows, or where either the old or new pointer value is a null pointer (or in C, when they both are).

GCC:
-fsanitize=pointer-overflow
This option enables instrumentation of pointer arithmetics. If the pointer arithmetics overflows, a run-time error is issued.

It's better to avoid the math operation with NULL pointer.

Let me see if I can rework code with minimal performance impact

We can try to go with stream->fs_bufend   = newbuf != NULL ? newbuf + size : NULL;, but that is a bit ugly.


Breaks with ad blocker

@mgiraldo says that disconnect.me prevents the details page from loading.
The solution here might be to do #32, so that I can drop xdomain and do same-domain XHRs for data.
If I take this route, I'd like to do it ASAP so that I'm not mucking with DNS post-launch (DNS changes terrify me).

@mgiraldo if you feel strongly about this, it would help to get some more specifics, e.g. does removing the facebook comment widget make the issue go away?

it works fine in my local instance following the instructions in the README:

i just see it in the hosted version

ReferenceError: FB is not defined in the hosted version

what if we use Disqus or some other non-FB alternative? i know we discussed this as an option

Is it blocking the FaceBook JavaScript bundle? If I open oldnyc.org in Chrome, go to the devtools and type FB, I get an object back. The error you posted would imply that this isn't happening.

correct

On May 13, 2015, at 1:58 PM, Dan Vanderkam<EMAIL_ADDRESS>wrote:
Is it blocking the FaceBook JavaScript bundle? If I open oldnyc.org in Chrome, go to the devtools and type FB, I get an object back. The error you posted would imply that this isn't happening.
—
Reply to this email directly or view it on GitHub.

This is a bug with disconnect.me then, not with OldNYC. I imagine if you went to facebook.com, nothing would load at all!

ok... i wanted to see if we could avoid FB altogether
it's ok if you want to make it a requirement

FWIW, it does work locally:

your call anyway

Yeah, I don't know why your adblocker would block the facebook JS in one case but not the other.


Any plans to move to OpenSAML 3.x+?

This library looks very useful. Given that OpenSAML 2.x has been EOL'd since July 2016, are there any plans to upgrade to use OpenSAML 3.x?
At the current time, 3.3.0 is the latest version

+1

Yup @OnixGH you're right - it looks like this was done a year later in #31 🎊


Dapr control plane components do not adapt to run in a single namespace

In what area(s)?
/area runtime
What version of Dapr?

master

Expected Behavior
Dapr components respect the limited RBAC permissions when using global.rbac.namespaced and work within a single namespace.
Actual Behavior
The Dapr control plane components do not appear to respect the limited RBAC permissions and still require cluster level permissions to operate successfully leading to crash loop backoff. For instance the operators attempts to read cluster level CRDs to patch them even though it does not have permission to do so.

https://github.com/dapr/dapr/blob/83d1727204b6554e302199ab1693033b54bdd6a6/pkg/sentry/config/config.go#L113
https://github.com/dapr/dapr/blob/83d1727204b6554e302199ab1693033b54bdd6a6/pkg/injector/pod_patch.go#L167
also in the operator code

Steps to Reproduce the Problem
Use the helm value global.rbac.namespaced=true and deploy the Dapr control plane to a namespace. The control plane components will all go into crash loop backoff.
I'll look to fix this in a follow up PR.
Release Note

RELEASE NOTE: FIX dapr control plane crashing when global.rbac.namespaced enabled.

/keepalive


Close channel only after last send

In case there is a time out, the goroutine would panic on sending on a
closed channel.
@bparees @mfojtik PTAL
@mfojtik here's the example you asked: http://play.golang.org/p/N5ANWaIdt6

@mfojtik beat you by self-merging.
https://github.com/openshift/source-to-image/pull/432

@bparees and I feel bad about that... should refresh my emails more frequently

@bparees mind merging this? I think I've explained enough of the problem :smile:
No hard feelings @mfojtik  ;)

already merged :)
On Mar 17, 2016 4:41 PM, "Rodolfo Carvalho"<EMAIL_ADDRESS>wrote:

@bparees https://github.com/bparees mind merging this? I think I've
explained enough of the problem [image: :smile:]
No hard feelings @mfojtik https://github.com/mfojtik ;)
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/openshift/source-to-image/pull/431#issuecomment-197938018

Rebased just because I still prefer this than the oneliner that got merged.

[merge]


Run PolicyAutomation tests separately in CI

The PolicyAutomation tests were taking about half of the total e2e test duration. This excludes those tests from the usual make e2e-test target, which will accelerate both the CI and local development. Those tests are now run in a separate (concurrent) GH job in the CI workflow, and the test coverage information is merged in another new job.
This also combines the unit tests and linting tasks into one job, which means that a linting or formatting error will not prevent the e2e tests from running.
Refs:

https://issues.redhat.com/browse/ACM-8239

looks great! but test coverage um... 1 %

looks great! but test coverage um... 1 %

I had missed downloading one of the coverage files 😆

I love this Thanks!


Add support for italic tab titles & italicise unsaved scene tabs

This PR [derived from proposition]:`

Adds support to vary the style of the tab titles on the group TabBar::Tab using the new enum TabBar::TabTitleStyle.
Makes any unsaved scene tab have its title italicised for clearer communication with the user

PS: There's room for improvement when it comes to performance. See Line 343 of scene/gui/tab_bar.cpp

Git has been rebased successfully 👍

Hard-coding font style is a questionable solution. It would be better if TabBar had theme font styles for normal and italic, like in RichTextLabel. Editor theme has such fonts so you'd get them for free, not sure about default theme. It would probably fall on the user to provide an italic font.

After testing a bit, I just noticed that TabBar and TabBar::Tab are indeed nodes creatable by the user. I'll see what I can do about it.

I'll need someone's help, as I am not experienced in adding fields to node objects.

Currently fixing all issues associated with the changes...

I don't know how to feel about having an option for them to be drawn specifically in italics.
Then in the future someone may suggest "Hey, how about bold?", "How about outlines?" or "What about colors?" and the solution in this PR is not exactly scalable.
Of course, just because it says "Italics" doesn't mean you have to provide an italics font, but it does not feel right.
The ability to override the font per Tab sounds more enticing to me, personally.

I don't know how to feel about having an option for them to be drawn specifically in italics.

The purpose of this PR is mainly to build foundation on which other contributors can expand their ideas upon. This gives the user and the source code contributors more control over the styling of each scene tab, making it a more polished experience for the user in general in the long term run, but I understand where your ideas come from, albeit, I don't have an issue with also adding the feature for a bold style in the future.

Problem is, italics_font and italics_font_size Theme items are both available in the public API in this PR as is, which means they would have to be maintained as developers in Godot can make use of it, too. If this implementation is later changed, these items would then become superfluous. Deprecating can be afforded but it's worth being a bit careful.


Unlocalised string during setup

I saw this while watching a video of a user installing VS Code. This is on a machine set to Spanish language (but I don't know which locale as I couldn't see the full screen)
Notice that the second last option is not localised

@stevencl do you know which version of VSCode he demoed. The only fully localized version we have is 1.5.3. which we shipped last week.

Sorry, all I know is that he installed it on September 9th.

From: Dirk Bäumer<EMAIL_ADDRESS>Sent: 26 September 2016 08:28
To: Microsoft/vscode
Cc: Steven Clarke; Mention
Subject: Re: [Microsoft/vscode] Unlocalised string during setup (#12529)
@stevenclhttps://github.com/stevencl do you know which version of VSCode he demoed. The only fully localized version we have is 1.5.3. which we shipped last week.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/vscode/issues/12529#issuecomment-249498249, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABoAe7c3Ta_ip6zga0g7Dr-hahp7lnk7ks5qt3Q4gaJpZM4KFEGD.

Also verified from loc side, loc string is in e.g. Spanish,
/Localize/esn/vscode/build/win32/i18n/messages.en.resx.lcl
  <Item ItemId=";AssociateWithFiles" ItemType="0;.resx" PsrId="211" Leaf="true">
    <Str Cat="Text">
      <Val><![CDATA[Register %1 as an editor for supported file types]]></Val>
      <Tgt Cat="Text" Stat="Loc" Orig="New">
        <Val><![CDATA[Registrar %1 como editor para tipos de archivo admitidos]]></Val>
      </Tgt>
    </Str>
    <Disp Icon="Str" />
  </Item>

1.5.3 got released after September 9th. Closing


apply flake8 linting

@volkamir it was a parameter that was not used that I removed, but was still getting passed into the testbench. It should be fixed.

The split parameter is actually needed since it is a parameter of the flex fifo. Anyway, let's merge now and see how to bring it.
I am still not clear on why it failed since it was there before and never caused an issue.

@volkamir I would suggest adding them back with needed functionality. As it was, it wasn't used by anything.


Added new folder ActionAndFuncDelegates

This is a first test for creating a pull request

Sorry I am testing the pull request for submitting my evaluating article in the following two weeks


Improve the combine feature

From https://code.google.com/p/ndmitchell/issues/detail?id=577 and https://code.google.com/p/ndmitchell/issues/detail?id=121:
The combine feature seems to be a bit useless (doesn't work between modules, a bit too slow in practice) and yet also finds false positives. In particular, the variables that are bound may be quite different. Maybe I should remove it and suggest people use Simian http://www.harukizaemon.com/simian/? Maybe I should improve it?

Chris Brown, Huiqing Li and Simon Thompson have done a reasonable amount of work on this problem:

Clone Detection and Elimination for Haskell
Similar Code Detection and Elimination for Erlang Programs
Incremental Code Clone Detection and Elimination for Erlang Programs

I use hlint all the time and I haven't seen a false positive for this for some time. Maybe i'm getting better :-).

Or maybe I toned the settings down, I don't quite remember :). At this point it's more a feature I experimented with and then forgot about, rather than a useful tool.


Compound word だしといて is split into だ + しといて

Hi again!
I recently came across a tweet with the following text:
もーすぐ　できるよン　お皿だしといてー
https://twitter.com/ktandoku/status/1350350938347696130 (fully SFW)
Looks like on ichi.moe, だしといて (and the uncontracted だしておいて too) is incorrectly segmented as だ + しといて instead of a compound word だしといて.
On the other hand, using the kanji form of だす (出しといて and 出しておいて) work fine.

Also - I'm not sure if I should bring this up in a separate issue, but as a Japanese learner I feel that the current breakdown for "[verb] + とく" compound verbs might be a bit confusing?
Currently for 出しといて, this is displayed:

出しといて 【だしといて】
Compound word: 出して + といて
出して 【だして】
[v5s] Conjunctive (~te)
出す 【だす】
[...]
といて
[to do in advance / to leave in the current state expecting a later change]
[v5k] Conjunctive (~te)
とく

There's nothing indicating that とく here is a contraction of ておく (JMDict on the other hand mentions this), and the breakdown into "出して + といて" seems a bit misleading in my opinion.
I think ideally it should be treated as if it were the uncontracted 出しておいて (i.e. the breakdown should be 出して + おいて), but I understand if there's technical limitations involved here.

Also - I'm not sure if I should bring this up in a separate issue, but as a Japanese learner I feel that the current breakdown for "[verb] + とく" compound verbs might be a bit confusing?
Currently for 出しといて, this is displayed:

出しといて 【だしといて】
Compound word: 出して + といて
出して 【だして】
[v5s] Conjunctive (~te)
出す 【だす】
[...]
といて
[to do in advance / to leave in the current state expecting a later change]
[v5k] Conjunctive (~te)
とく

There's nothing indicating that とく here is a contraction of ておく (JMDict on the other hand mentions this), and the breakdown into "出して + といて" seems a bit misleading in my opinion.
I think ideally it should be treated as if it were the uncontracted 出しておいて (i.e. the breakdown should be 出して + おいて), but I understand if there's technical limitations involved here.

I'll push a fix for だし+suffixes being split incorrectly soon (basically I'll forbid any form of する right after だ)
As for compound word breakdown, you're correct that it's not really consistent right now (for example しちゃ is shown as して＋は), but it's a bit more annoying to do this for conjugated suffixes. Also since JMdict does have the word とく for て+おく, it's also in ichiran database and it's listed in WordInfo for といて, albeit at the bottom because this word is forbidden to be used by itself and its score is 0.

I'll push a fix for だし+suffixes being split incorrectly soon (basically I'll forbid any form of する right after だ)
As for compound word breakdown, you're correct that it's not really consistent right now (for example しちゃ is shown as して＋は), but it's a bit more annoying to do this for conjugated suffixes. Also since JMdict does have the word とく for て+おく, it's also in ichiran database and it's listed in WordInfo for といて, albeit at the bottom because this word is forbidden to be used by itself and its score is 0.

So the original issue is now fixed . I wanted to change the compound word text of this suffix as well, but there is a technical issue preventing this currently, as some forms of suffix とく are disabled and this wouldn't be possible if it was parsed as おく.

So the original issue is now fixed . I wanted to change the compound word text of this suffix as well, but there is a technical issue preventing this currently, as some forms of suffix とく are disabled and this wouldn't be possible if it was parsed as おく.

Thanks for fixing the issue! :)

Thanks for fixing the issue! :)


[FLINK-7004] Switch to Travis Trusty image

Back-port of #4182 for 1.3.

+1 to merge once travis has passed

Will merge once travis is done.


Update go-github to v40

Updates the version of go-github to latest v40 that was recently released. https://github.com/google/go-github/releases/tag/v40.0.0

Champion, thank you


Default Layout Mode

Hi guys,
The default Layout Mode for the one-dark-ui and probably all themes should be Auto and Tab Sizing should be Even. I've gone through a lot of trouble trying to get the tabs back to normal after the update without knowing that there is now a setting for the layout mode. And also, after the Atom update, the layout mode setting should be set to the previous choice of the user.

Sorry about changing the default for "tab sizing".
Because the Font Size and Layout Mode setting both have a default of Auto, it felt more consistent to also use it for Tab Sizing.

I just had the same issue and my tabs used to be Even yet now they're Auto and it's setting them to Minimum when there's clearly enough space for them to be even. In fact I can't make the window large enough to get them to go back to Even when it's in Auto mode. I don't have a problem with the setting being Auto if it works correctly, but the Auto setting for tab size seems to be either buggy or otherwise not working as it should.

@benbalter, @simurai Yeah. This should be reverted in the new Atom update. I doesn't appear cool at all.

@benklebe and it's setting them to Minimum when there's clearly enough space for them to be even.

Unfortunately it's not that smart. Auto switches based on window size. Currently it's set to <= 1280x800. Maybe we could lower that a bit, like 1000x600, so that for example on a 13" MBP you would still get even tabs.

Yeah, I think 13-inch laptops are a reasonable size to start setting "Even".


flow: add unit test for yaw motion

Because unit tests are fun!

Thanks @kamilritz for the review. I addressed your comments.

especially if you find the code not working as expected

Yes, I actually started that because the drone is never really locked-in when yawing in opt flow fusion only. So probably the issue is not on the EKF side, but due to the sensor.

Really sure: https://github.com/PX4/PX4-ECL/blob/df7f261e038aa80b07a91857f2f952280938bfc6/EKF/common.h#L139
Rotation of the image = - rotation of the body
See also in https://github.com/PX4/PX4-ECL/blob/df7f261e038aa80b07a91857f2f952280938bfc6/EKF/optflow_fusion.cpp#L363

@bresch  I do not see any update to the PR. If this is intentional, please go ahead and merge it.

@kamilritz I forgot to push... :|


Feature: Find issues in the support repository

Examples

Note: This command search in the issues only because I couldn't find anything in GitHub documentation to search through the discussions.
closes #183

Hi @alrifay, thank you so much for starting to work on this feature ❤. We always appreciate initiative and your contribution is very valuable!

@BOLT04  Thank you so much 😄

I left some comments that I'd love to get your feedback on, but IMO this is ready to be merged 👍
Sorry for the long delay, I had a lot of work to do 😁 and really appreciate your feedback .

Hi @alrifay, thank you so much for starting to work on this feature ❤. We always appreciate initiative and your contribution is very valuable!

@BOLT04  Thank you so much 😄

I left some comments that I'd love to get your feedback on, but IMO this is ready to be merged 👍
Sorry for the long delay, I had a lot of work to do 😁 and really appreciate your feedback .

Sorry for the long delay, I had a lot of work to do 😁 and really appreciate your feedback .

No problem @alrifay, I totally understand 😃. We are all working together to get PRs merged, even if it might take a few days. We need to rest, and sometimes there is just other stuff going on in our lives. I didn't mean to put pressure on you to give me feedback 😅, so don't worry if you can't respond.
I think everyone in the community respects each other's time, so props for working on this amazing feature 👍.

Sorry for the long delay, I had a lot of work to do 😁 and really appreciate your feedback .

No problem @alrifay, I totally understand 😃. We are all working together to get PRs merged, even if it might take a few days. We need to rest, and sometimes there is just other stuff going on in our lives. I didn't mean to put pressure on you to give me feedback 😅, so don't worry if you can't respond.
I think everyone in the community respects each other's time, so props for working on this amazing feature 👍.

Great work on this everyone 👍

Great work on this everyone 👍

@alrifay @BOLT04 is the PR good to go? Is there work still needed?

@alrifay @BOLT04 is the PR good to go? Is there work still needed?

@alrifay @BOLT04 is the PR good to go? Is there work still needed?

I thought the only thing missing was adding comments to the parseSearchCommand. I can make a suggestion and do that commit.
This can be merged right after 👍 👍

Thanks all 👍 🤓


Make sure old fault codes gets cleared

make no error mutual exclusive with all other fault codes

I'll fix the commit-message to comply with the conventional commits format and add a test for this as well. Will merge and release after that.

Replaced by #314


Fixed: prediction/model#query does not work with Regression models

The prediction#output response from calling Trainedmodels:predict on a Regression model does not include an outputMulti attribute. This attribute is used to calculate the results.score return value from prediction/model#query but this calculation causes an error when predicting using Regression models.
The test for prediction/model#query "query success should return the outputValue as the winner" was not set up correctly so this bug wasn't caught. When the outputMulti attribute is removed from mock apiResponse the error seen when using gcloud-node with Regression models becomes apparent: TypeError: Cannot read property 'sort' of undefined       at lib/prediction/model.js:351:9
I've included the steps to update the test, and a solution to the problem (only calculating query result scores if response.outputMulti is present).
Thanks!

Thanks @savethefails! There were a couple linting issues, so I pushed manually (https://github.com/GoogleCloudPlatform/gcloud-node/commit/63f658619e884ddbeb36bb7f2896372fcd5cb9e4)


Remove AWS dependencies?

Now that viro-react is open source, can we remove all these dependencies?

+1 these seem unnecessary


Document for Mqtt codec

Is there any document about MQTT codec?

I'm not sure about specific for Netty MQTT docs, but you can look to example  MQTT

@BigGitWorld only the javadocs and the examples as mentioned


Enable users to disable VT colors (for accessibility, visibility, contrast, etc.)

Description of the new feature/enhancement
Users, esp those with accessibility needs, should be able to disable command-line apps from altering text and background colors, either via API calls, or via VT sequences.
Terminal should still honor users' color theme and default foreground and background color choices, allowing users to select high-contrast etc. themes / colors if they wish.
Proposed technical implementation details (optional)
Suggest a setting called something like:
disableDynamicColors
disableAppColors

... or similar.

This is a great initiative; however, I don't think it's as simple as disabling coloring escape sequences.
My main concern is that doing this without QAing and tailoring each and every application in this mode (which is clearly not going to happen, unless that guy volunteers :smile:) will often result in unusable behavior, even for users with perfect sight. For example, Midnight Commander highlights the currently focused file by using other colors; and the currently selected (toggled) ones with yet another. If you simply drop coloring, you can no longer track where your cursor is. For black and white UI's, e.g. the mail client pine, chances are that the app uses reverse mode for its highlighted item, so at least that mode should be preserved as a means of switching the colors, but it's still not a generic solution.
Back to mc in particular: This app does have an explicit command line flag to work in black in white (actually 4 grayscale values by using the normal and bright counterpart of both). It does have some serious usability issues though (certain pieces of text being invisible, while certain other things just not getting highlighted). I can't recall any relevant bugreport, suggesting that this feature is hardly ever used on today's graphical terminals, if at all.
There's an initiative no-color.org to address black and white on the application side, using a common approach. The page also includes a list of apps supporting and not supporting it, as well as a list of equivalent command line flags or config options for them. I do have concerns about this particular proposal, though, and I'm not alone. However, per-application support is the only viable approach I can see in order to get black and white only (i.e. not even grayscale – if that's what you really want), I can't see how the terminal could automatically create a usable black and white version of applications.

I have so far seen three different major features offered by terminals, to help the poor sighted:

Minimum contrast. For each character cell, the foreground color is modified if necessary to be farther away(*) from the background, according to a slideable setting. It's implemented at least by macOS's default Terminal.app, and if I remember correctly, iTerm2 too.
(*) Preferably using a sophisticated formula rather than the Pythagorean distance in RGB space which allegedly has hardly anything to do with the human-perceived distance; or even multiple formulas for multiple kinds of typical problems, such as red-green vs. blue-yellow color blindness.

Increased line spacing (and perhaps column spacing, too). This is implemented by VTE (geez, it was much trickier than anticipated with tons of corner cases) and quite a few others.

Some kind of screen reading. This is implemented by VTE, and I guess Konsole too.

Other ideas could also be brainstormed. Here's one that occurred to me right now, combining multiple previous ones.
Add some line and column spacing. Convert all the colors to grayscale. Make sure that the foreground's gray is far enough from the background's for each cell. Moreover:
A potential problem with this is that two backgrounds that are quite different in RGB, conveying the message of switching to another UI item, can now be almost identical, placed next to each other. To mitigate the problem: make the background color of a charcell (the grayscale variant thereof) extend to the gap between cells if and only if the neighboring cell in that direction has the very same original RGB value, or if the grayscale colors are far away. Otherwise, when two different RGBs mapped to almost the same gray, draw a separator line in the gap that is quite different from the neighboring cells' colors.
I have no idea how useful it is, might be worth it creating a mockup screenshot or demo implementation.

All in all, I think this is a topic which requires heavy input from those affected to understand what their preferences are, and also is subject to feasibility since e.g. there's no magic wand to convert apps' output to only black and white in a usable way.

Re minimum contrast: see also https://github.com/microsoft/terminal/issues/2638#issuecomment-527281295.

It's worth mentioning that Windows already has a bunch of built-in accessibility filters for different forms of color blindness, grayscale, inverted colors, etc. I don't know if that's enough for most people, or if it's preferable to be able to control that sort of thing on a per-app basis.

Yeah, this is a huge workitem -- I'm moving it out from v1.0 to the backlog and marking it for the specification tracker. Thanks everyone for your input!

As a legally blind person less than 10% of the vision nerve remaining, the WindowsTerminal is painful to use because of the mess different apps cause with character cell coloring where it is hard to distinguish between the background and the foreground colors (both in terms of color combination as well as luminosity).
Any solution, however primitive/ugly/temporary/experimental will be hugely appreciated. Finesse can come later.
Coloring is supposed to add another dimension to the text - currently it comes at the major cost of making text invisible to us unfortunate ones. It will be more beneficial to lose the extra dimension of highlighting specific parts of the text, than the lose text.
A first attempt where the background is always the terminal background (ignoring the character background) and the foreground is the basic colors with the most contrast (darkest on white backround and lightest on black background) will maket things much better.

@carlos-zamora, @PankajBhojwani and I were just having a discussion on this topic actually. We will likely want to follow up with you with some ideas in the near future 😄

It's worth mentioning that all the DEC color terminals actually had a setting for switching between different color modes - one of the choices being "monochrome". On the VT340 and VT525 this could also be controlled via the DECSTGLT escape sequence, which I'm hoping to implement at some point.
As I understand it, the monochrome mode would disable all SGR colors, so the only text attributes would be things like bold/bright, underline, reverse, etc. I'm not sure if that's exactly what you want here, but it's perhaps worth considering, because then we would just be reusing a standard function rather than having to invent something new.

... "monochrome" ...  I'm not sure if that's exactly what you want here, but it's perhaps worth considering...
Yes, this is definitely a good standard way to make sure a screen is readable regardless of what color/contrast crimes were committed. A good start.

@DrorHarari we relatively messed with the adjustIndistinguishableColors profile setting: https://github.com/microsoft/terminal/pull/13512
If you haven't used it yet, I think it might be up your alley. 😊

FYI, one of our long-term plans for this feature is to allow for an adjustable contrast ratio. Users who need higher contrast text will be able to crank it up (and/or we'll automatically do it if the system is in High Contrast mode globally), and folks who don't need contrast to be quite so harsh can lower it. :)

Thanks Carlos  -  that's great news.
I have installed the latest preview but could not see any difference at all
(including in cases with very low differences):
[image: image.png]
On Thu, Oct 27, 2022 at 9:29 PM Carlos Zamora @.***>
wrote:

@DrorHarari https://github.com/DrorHarari we relatively messed with the
adjustIndistinguishableColors profile setting: #13512
https://github.com/microsoft/terminal/pull/13512
If you haven't used it yet, I think it might be up your alley. 😊
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/terminal/issues/3066#issuecomment-1293910310,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN7HXIBF646JLXWSXLWHO3WFLCYXANCNFSM4I5VL27Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add Iterable[Any] protocol to BaseRowProxy

Unlike normal Mapping, BaseRowProxy iterates over its values instead of its keys.
Adding an Iterable protocol would fix the implied return type of __iter__ method.

Failed because of MRO inconsistency. Will try some other way.


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1262

Questions ?
Please refer to the Backport tool documentation


Code sample font in index.html

I think it might look better if the code sample on the front page used a monospace font, such as IBM Plex Mono.

I've opened a PR for this.

PR has been merged!


TDTM Workflow Rule changes

This pull request enhanced TDTM to cache objects in all After triggers, so that any subsequent Update trigger, in the same transaction, will receive the most up to date version of the objects in the trigger old list.
This work was specifically done to work around a known platform limitation.  From the last paragraph on https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_triggers_order_of_execution.htm
"When a record is updated and subsequently triggers a workflow rule field update, Trigger.old in the last update trigger won’t contain the version of the object immediately prior to the workflow update, but the object before the initial update was made."
This standard behavior prevents our trigger handlers from doing the correct logic after a workflow rule runs, since we may not correctly detect which change just occurred.
Critical Changes
Changes
Issues Closed

@force2b @njjc @judisohn @jessingrass @dylanhansen
Here is the "fix" to the workflow rule issue with triggers.  We do not want to even consider this change until we have finished dealing with our static flag pull request, and have merged that code in.  Since this is a major change with how our triggers will potentially handle workflow rules, we must exercise extreme due diligence to convince ourselves this is the correct solution.  Here are suggestions on what we can do to gain that level of confidence:

run our normal test suite and our LDV test suite, and compare performance/limit numbers to ensure this change hasn't affected anything in scenarios where no workflow rules are involved.

come up with a set of workflow rule tests that try modifying each of our objects and exhibit incorrect behavior in our current release, and then verify this branch resolves those issues.  Some example ideas:

a workflow rule on Address that sets MailingCity to some value when MailingPostalCode = some value
a workflow rule on Contact that sets MailingCity to some value when MailingPostalCode = some value
a workflow rule on Account that sets BillingCity to some value when BillingPostalCode = some value
a workflow rule on Opportunity that sets Stage to Closed / Won, when some custom field is set

Obviously the possibilities are endless, and there is no way for us to do any complete testing.  What I'm hoping we can achieve is a set of representative "reasonable" workflow rules that customers might actually try, that currently fail, that we can see if we've solved.  Given the potential effort, we should discuss our team's strategy on this, and how we want to proceed.

This should fix #2316

If you need help coming up with examples to test against, let me know - I've seen many.

@judisohn As I thought, you would have great knowledge of some workflow rule use cases.  That's why I'd like us to have a group discussion about who should be involved in this work, rather than assume development should do it all.  @dylanhansen @judisohn will you both be available to discuss at architecture review next thursday 7/27?

@davidhabib I'll be there!


(Draft) Restructure

Description of changes

WIP
Relevant Issues

#48

Alright all basic functionality is restored in this pr. Please test and let me know what else is in need of changing.
I still need to work on:

Setting the CI back up

I would close this as this PR didn't see the light in a while.
Is it okay @fdncred ?

ya, it has been a while


[webpack] set up proper dev/prod environment

process.env.NODE_ENV === 'production' is now possible in our js code. I'll use that to switch off the devTools in SQL Lab.
also React looks for this as well and will make a more efficient prod build going forward
@ascott @williaster

Coverage decreased (-0.09%) to 81.345% when pulling 95664e557963b16d538abcef135475ab1961b484 on mistercrunch:dev_prod_setup into baf22c3c60de38a1fe14de5f7120c76abe106460 on airbnb:master.

LGTM


Crowdsale Demo directory shouldn't be labeled "nex"

This is more stylistic but the naming for the directory shouldn't be nex. It doesn't really describe what the files in the directory are for. Also, while many members of CoZ are a part of NEX, NEX isn't part of CoZ - this could confuse people starting out in developing NEP5 contracts.

Clarifying that the merge referenced above is in my own repo. The PR for the CoZ boa branch is here: https://github.com/CityOfZion/neo-boa/pull/100


Add search integration test to verify results

There were some console errors in the integration test output - I don't think we should load the platform-specific features into 'integration' -> testing here https://github.com/duckduckgo/content-scope-scripts/pull/557


Replace 'active: yes' badge with 'last commit'

:sparkles: Enhancement Request
An 'active: yes' badge can actually become out of date, whereas a 'last commit' badge will always be true.
https://shields.io/category/activity

:white_check_mark: Checklist

[x] Following CODE_OF_CONDUCT.md.
[x] Checked for duplicate enhancements.
[x] Title is a summary of the enhancement request, in present tense, and ideally < 50 characters
[x] Ready for review

:tada: This issue has been resolved in version 7.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Instead of restarting right away after a crash, the crash reporter asks me to send a message and only restarts after

Crashes do happen. The correct UX here is to restart QS and then, if you must insist, ask for a crash message but have a checkbox to never see it again also. As it stands, QS crashes and I have no idea that it did other than it stops working. Really, if it restarted automatically upon crash, I wouldn't even care that it crashes every once in awhile and probably no one else would care much either.

The correct UX here is to restart QS and then, if you must insist, ask for a crash message but have a checkbox to never see it again also.

I don’t entirely understand this. It can’t show the crash reporter until after it restarts.
If you don’t want to see it any more, there’s a hidden preference for that: QSRestartAutomaticallyWithoutCrashReporter

Really, if it restarted automatically upon crash, I wouldn't even care that it crashes every once in awhile and probably no one else would care much either.

There are tricks out there on the mailing list or maybe other places that people have used to keep it running. I imagine you could use a launchd Launch Agent for that. Doing this automatically on everyone’s system seems a bit heavy-handed and presumptuous, but if you find a reliable technique, maybe we could add it to the manual.
Also, please make sure you’re using the latest version. There was a long period where checking for updates would cause a crash, so it would only happen about once a week (and you would never get the update that fixed it).

I didn't know there was a newer version. I just upgraded. Maybe that was the problem as the crashes were very rare. If the box comes up after restarting (which of course makes sense, I don't know what I was thinking), is it possible to continue loading QS while waiting for the box? The problem is while the box is active, QS is not loaded and doesn't work. It only starts working after the box is dismissed. It sounds like QSRestartAutomaticallyWithoutCrashReporter will fix this by skipping the box altogether and moving on to. I will try that in combination with the new version and hopefully it should resolve the issue Thank you.

The problem is while the box is active, QS is not loaded and doesn't work.

Well, that’s true. It checks for crashes pretty early on and waits for an answer before doing anything else. I generally agree that it would be nice to let the app keep loading, but what if that’s where the crash is happening?


resetForm() leaves a ↵ when executed.

I have this form:
/**
 * React component MessagesForm
 */

import React, { PropTypes } from 'react'
import {reduxForm, reset} from 'redux-form'

const MessagesForm = p => {

  const {fields: {message}} = p

  const addMessage = e => {
    if(e.keyCode == 13 && e.shiftKey == false) {

      p.handleSubmit()
      p.resetForm()

    }
  }

  return (
    <form onSubmit={p.handleSubmit}>
      <div className="form-group">

        <textarea
          {...message}
          value={message.value || ""}
          rows="1"
          type="text"
          className="form-control"
          onKeyDown={addMessage}
          placeholder="Escribe tu mensaje y presiona Enter para enviar." />

      </div>
    </form>
  )
}

const form = reduxForm({
  form: 'message',
  fields: ['message']
})(MessagesForm)

export default form

As you can see the form is submitted when the user press the enter key (↵) and is not pressing shift. after handling the submit i reset the for immediately, but it leaves a ↵ sign instead of an empty string, so it can show the placeholder again.
I need to be reset to an empty string instead of a ↵, how can i do this?

As a workaround, adding setTimeout(p.resetForm, 1) makes it work. Still looking for a solution.

Shouldn't you have a e.preventDefault() to prevent the ↵ from making it into the input?

@erikras thanks!!! :D

Reopen if this is not solved.


Add a Github Action to auto-assign Mentors for every PR

Description
Add a Github Action to auto-assign Mentors for every PR. It is a pain sometime to take a look at all the Projects for the PRs made by the Contributors. Getting a nice notification about reviewing a PR would make things easy for me.
You can take a look at this Github Action for the purpose. Check this out to know how to achieve the same.

@HarshCasper I would like to work on this issue. I was going through the Auto Assign Action it seems the reviewers list has to be static (hard-coded). Then we can create a couple of groups in this way:
 groupA:
    - reviewerA
    - reviewerB
    - reviewerC
  groupB:
    - reviewerD
    - reviewerE
    - reviewerF

I am GGSOC'21 participant, i would like to work on this issue.
@HarshCasper , please assign it to me: )

Hi @arnabsen1729
Will you be able to work on it on behalf of GSSoC '21 ? If yes, I will forward you the mentors that need to be assigned.
@Uyadav207 Thanks for your interest. If @arnabsen1729 doesn't respond within a couple of days, you can take it up

Thanks @HarshCasper

@HarshCasper yes, I would be working on behalf of GSSoC '21.

@HarshCasper will the mentors/reviewers have write perms to this repo? Accord to this link

anyone who has commented on the issue or pull request, anyone with write permissions to the repository, and organization members with read permissions to the repository.

For further queries should I continue this thread, or wait for the discord channels to be opened.

Yes. Let me know once the action is ready and I will send you the list of all maintainers and mentors


ARROW-4898: [C++] Old versions of FindProtobuf.cmake use ALL-CAPS for variables

Crossbow build: https://travis-ci.org/xhochy/crossbow/builds/506743919


Candlesticks not displayed

Candlesticks are not displayed as in the demo gif.
I'm running ARCH on WSL2 inside alacrity terminal. Any idea why?

Running it on windows with windows terminal, the candles are displayed, however there is a 'gap' inside a candle.

@piotryordanov Each terminal / font causes things to look slightly different. I've used the following settings on Windows to get things to render properly...

Use alacritty as the terminal. I couldn't get things to render perfectly in Windows Terminal
In %APPDATA%\alacritty\alacritty.yml set the following option:

font:
  offset:
    x: 0
    y: -1

With this set, tickrs line and candle charts render perfectly!

I confirm that alacritty on windows actually makes it render well. Thx :)


can't enchant with SpongeVanilla 1.21

Affected Product(s)
SpongeVanilla
Version
1.21-12.0.0-RC1755
Operating System
Windows
Java Version
openjdk version "21.0.3" 2024-04-16 LTS OpenJDK Runtime Environment Temurin-21.0.3+9 (build 21.0.3+9-LTS) OpenJDK 64-Bit Server VM Temurin-21.0.3+9 (build 21.0.3+9-LTS, mixed mode, sharing)
Plugins/Mods
no mods

Describe the bug
spongevanilla-1.21-12.0.0-RC1734-universal
-> A bug occurs when I put an item and lapis lazuli in the enchantment table and click on the enchantment it.
-> Enchantments will appear, but will not be enchanted.
spongevanilla-1.21-12.0.0-RC1755-universal
-> Putting an item in the enchantment table causes a bug.
-> The bug occurs even if you don't put lapis lazuli.
-> Enchantments (sharp II, silk touch....) do not appear.
Link to logs
https://gist.github.com/snowyegret23/5cc0c0642e9e4a37609d0c3c80b9f24f

Holder$Reference cannot be cast to EnchantmentType
https://github.com/SpongePowered/Sponge/blob/api-12/src/main/java/org/spongepowered/common/item/enchantment/SpongeRandomEnchantmentListBuilder.java#L138
Holder needs to be unpacked.
Also check for similar casting issues due to change of registry type to holder


Make TagGroup hook API less Spectrum specific

Since TagGroup is basically a special case of GridList, and we already expose things such as selection/disabled items via useListState, this officially supports those use cases (which are common in other design systems) in the aria API. Not supporting them was a spectrum-specific decision.
Removes labelProps of a Tag from needing to be a separate element, and just uses the tag itself in the aria-labelledby of the remove button. This will make the RAC API simpler later.
Ensures spectrum specific props like maxRows and validationState are not in the aria API.
Changes the onRemove prop to accept a Set<Key> instead of a single Key. This is to support selection, where you can select multiple items and press the backspace key to remove all of the selected items at once. Clicking the delete button on a tag still only removes that one tag.
Automatically passes onRemove through from useTagGroup to useTag so user doesn't need to do this themselves.
Removes allowsRemoval prop and simply infers this from onRemove being present or not. Returns the computed value of this from useTag so render function can decide whether to show remove button or not.
Returns states from useTag for rendering, matching useGridListItem.
Removes TagKeyboardDelegate and adds an orientation option to ListKeyboardDelegate instead, along with support for shouldFocusWrap in arrow left/right.
Converts docs examples to TypeScript
Changes category to Collections instead of Status

One question is whether Set<Key> for onRemove is too cumbersome for the (current) common case of removing a single tag. You'd have to do [...keys][0] to get the first key. We could make it an array, but that wouldn't match selection, and it's kinda nice to do filters with keys.has. 🤔

(Pretty sure the above API diff is missing a bunch of changes)

Realized that page up / page down still didn't work in the ListBox RAC docs because we were assuming that the scroll container also had position: relative. Now we use getBoundingClientRect instead of offsetTop.

The example crashed because useHasTabbableChild was flapping between two values, causing the tag group to switch between tab index -1 and 0. That was because the ref was placed on the wrong element - it should have been on the role=grid element, but was on a wrapper. That meant that useHasTabbableChild considered the tag group itself as a tabbable child.

Ah, don't forget to pull out the docs changes to a separate PR

he, TS failing on the docs but we can't add the changes to the PR is a new problem...

yeah, might need to use super powers this time :-/ we can sort it out later


index_parallel task fails if segmentGranularity has a timeZone

Affected Version
0.18.0 and 0.18.1
Description
Cluster size

1 master (coordinator/overlord)
1 router/broker
1 historical
3-10 middleManagers

Steps to reproduce the problem

create and run an index_parallel task

must include a timeZone in the segmentGranularity in the granularitySpec in the dataSchema
must have maxNumConcurrentSubTasks greater than 1 in the tuningConfig
must have type as hashed for partitionsSpec in tuningConfig

The error message or stack traces encountered.
The main error is the ZipException
2020-06-04T23:39:20,955 INFO [task-runner-0-priority-0] org.apache.druid.utils.CompressionUtils - Unzipping file[var/druid/task/partial_index_merge_datasource_1_geoeiplm_2020-06-04T23:39:16.988Z/work/indexing-tmp/2020-04-24T04:00:00.000Z/2020-04-25T04:00:00.000Z/1/temp_partial_index_generate_datasource_1_ieoldkdf_2020-06-04T23:39:01.964Z] to [var/druid/task/partial_index_merge_datasource_1_geoeiplm_2020-06-04T23:39:16.988Z/work/indexing-tmp/2020-04-24T04:00:00.000Z/2020-04-25T04:00:00.000Z/1/unzipped_partial_index_generate_datasource_1_ieoldkdf_2020-06-04T23:39:01.964Z]
2020-06-04T23:39:20,956 ERROR [task-runner-0-priority-0] org.apache.druid.indexing.overlord.SingleTaskBackgroundRunner - Exception while running task[AbstractTask{id='partial_index_merge_datasource_1_geoeiplm_2020-06-04T23:39:16.988Z', groupId='index_parallel_datasource_1_jjglpmkc_2020-06-04T23:38:57.541Z', taskResource=TaskResource{availabilityGroup='partial_index_merge_datasource_1_geoeiplm_2020-06-04T23:39:16.988Z', requiredCapacity=1}, dataSource='datasource_1', context={forceTimeChunkLock=true}}]
java.util.zip.ZipException: error in opening zip file
	at java.util.zip.ZipFile.open(Native Method) ~[?:1.8.0_252]
	at java.util.zip.ZipFile.<init>(ZipFile.java:225) ~[?:1.8.0_252]
	at java.util.zip.ZipFile.<init>(ZipFile.java:155) ~[?:1.8.0_252]
	at java.util.zip.ZipFile.<init>(ZipFile.java:169) ~[?:1.8.0_252]
	at org.apache.druid.utils.CompressionUtils.unzip(CompressionUtils.java:250) ~[druid-core-0.18.1.jar:0.18.1]
	at org.apache.druid.indexing.common.task.batch.parallel.PartialSegmentMergeTask.fetchSegmentFiles(PartialSegmentMergeTask.java:231) ~[druid-indexing-service-0.18.1.jar:0.18.1]
	at org.apache.druid.indexing.common.task.batch.parallel.PartialSegmentMergeTask.runTask(PartialSegmentMergeTask.java:169) ~[druid-indexing-service-0.18.1.jar:0.18.1]
	at org.apache.druid.indexing.common.task.batch.parallel.PartialHashSegmentMergeTask.runTask(PartialHashSegmentMergeTask.java:44) ~[druid-indexing-service-0.18.1.jar:0.18.1]
	at org.apache.druid.indexing.common.task.AbstractBatchIndexTask.run(AbstractBatchIndexTask.java:123) ~[druid-indexing-service-0.18.1.jar:0.18.1]
	at org.apache.druid.indexing.overlord.SingleTaskBackgroundRunner$SingleTaskBackgroundRunnerCallable.call(SingleTaskBackgroundRunner.java:421) [druid-indexing-service-0.18.1.jar:0.18.1]
	at org.apache.druid.indexing.overlord.SingleTaskBackgroundRunner$SingleTaskBackgroundRunnerCallable.call(SingleTaskBackgroundRunner.java:393) [druid-indexing-service-0.18.1.jar:0.18.1]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_252]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_252]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_252]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_252]

The unzip fails because findPartitionFile fails to find the partition created during the partial_index_generate task. getPartition returns the error message instead of the zip file. So the unzip fails.
The partition file is stored with the timezone offset in the path like this:
2020-04-24T00:00:00.000-04:00/2020-04-25T00:00:00.000-04:00
/tmp/intermediary-segments/index_parallel_datasource_1_iiocmdme_2020-06-04T23:15:56.314Z/2020-04-24T00:00:00.000-04:00/2020-04-25T00:00:00.000-04:00/1/partial_index_generate_datasource_1_cgdlipdp_2020-06-04T23:16:02.960Z

But the http request to getPartition uses the UTC time
startTime=2020-04-24T04:00:00.000Z&endTime=2020-04-25T04:00:00.000Z
2020-06-04T23:39:20,945 DEBUG [HttpClient-Netty-Worker-0] org.apache.druid.java.util.http.client.NettyHttpClient - [GET http://<hostname_removed>:8091/druid/worker/v1/shuffle/task/index_parallel_datasource_1_jjglpmkc_2020-06-04T23%3A38%3A57.541Z/partial_index_generate_datasource_1_ieoldkdf_2020-06-04T23%3A39%3A01.964Z/partition?startTime=2020-04-24T04:00:00.000Z&endTime=2020-04-25T04:00:00.000Z&partitionId=1] Got response: 404 Not Found

Any debugging that you have already done
I'm not very familiar with the druid code so I'm not sure if there is a simple code fix. @jihoonson might know how to fix it, since he is working on https://github.com/apache/druid/issues/8061.
It looks like startTime and endTime param args are from
partial_index_merge
  spec
    ioConfig
      partitionLocations
        interval

Maybe you could store interval with the tz offset instead of the materialized UTC time?

@tarpdalton thank you for the detailed report! I don't have a concrete idea to fix the bug right now, but will take a look.

@jihoonson I don't understand what's the meaning of  setting timeZone, origin for segmentGranularity, and I  don't see any document about this. There is another segmentGranularity setting problem #9894 .

@FrankChen021 it's documented here. #9894 is about duration segment granularity and doesn't seem related to this issue.

@FrankChen021 it's documented here. #9894 is about duration segment granularity and doesn't seem related to this issue.

The doc is about query granularity, although segment granularity shares the same type as query granularity, it does not explain why people need to care about timezone/origin of segment granularity. I don’t see any beneficial from these two parameters on segment granularity

Yes, the doc should say it can be used for segment granularity as well. However, it is at least linked https://druid.apache.org/docs/latest/ingestion/index.html#granularityspec.

The doc is about query granularity, although segment granularity shares the same type as query granularity, it does not explain why people need to care about timezone/origin of segment granularity. I don’t see any beneficial from these two parameters on segment granularity

I'm not sure what you are suggesting. The timezone is useful when you have timestamps of a different timezone from the one where your druid is running. The origin is useful when you want to make time buckets differently.

I'll share my use case for segment granularity. Here is my granularity spec for loading some data:
      "granularitySpec": {
        "segmentGranularity": {
          "type": "period",
          "period": "P1D",
          "timeZone": "America/New_York"
        },
        "queryGranularity": {
          "type": "period",
          "period": "P1D",
          "timeZone": "America/New_York"
        },
        "rollup": true,
        "intervals": [
          "2020-05-12T00:00:00-04:00/2020-05-13T00:00:00-04:00"
        ]
      },

I am rolling up in daily buckets, but offset by the timezone. The granularity is big so the roll up is more efficient.
The event data that I am storing in druid occurs in the EST/EDT timezone. When I query druid to see how many events happened March 12th; I want to see events from March 12th EDT, not March 12th UTC.

@tarpdalton I see there's some benefits by setting timezone for segment granularity. Each segment starts at 00:00 EDT instead of UTC, to query data within a local day exactly falls into one segment. But if segment starts at 00:00 +0, data in local time may spread in two segments.

We are also facing similar issue, We are using druid 0.20.2. Issue started coming when we moved from ec2 r5.4x instance to i3en.4x instance
`    "tuningConfig": {
"type": "index_parallel",
"splitHintSpec": {
"type": "maxSize",
"maxNumFiles": 2
},
"partitionsSpec" : {
"type" : "hashed",
"numShards": 35
},
  "forceGuaranteedRollup": true,
  "totalNumMergeTasks": 100,
  "maxNumSegmentsToMerge": 100,
  "maxNumConcurrentSubTasks": 500,
  "maxRowsInMemory": 3000000,
  "maxPendingPersists": 1,
  "useCombiner" : true,
  "forceExtendableShardSpecs" : true,
  "indexSpec": {
    "bitmap": {
      "type": "roaring"
    },
    "dimensionCompression": "lz4",
    "metricCompression": "lz4"
  }
}`

2022-07-05T18:36:46,245 ERROR [[partial_index_generic_merge_datasource_mngkoeoe_2022-07-05T18:36:44.742Z]-threading-task-runner-executor-3] org.apache.druid.indexing.overlord.ThreadingTaskRunner - Exception caught while running the task. java.util.zip.ZipException: error in opening zip file 	at java.util.zip.ZipFile.open(Native Method) ~[?:1.8.0_282] 	at java.util.zip.ZipFile.<init>(ZipFile.java:225) ~[?:1.8.0_282] 	at java.util.zip.ZipFile.<init>(ZipFile.java:155) ~[?:1.8.0_282] 	at java.util.zip.ZipFile.<init>(ZipFile.java:169) ~[?:1.8.0_282] 	at org.apache.druid.utils.CompressionUtils.unzip(CompressionUtils.java:250) ~[druid-core-0.20.1.jar:0.20.1] 	at org.apache.druid.indexing.common.task.batch.parallel.PartialSegmentMergeTask.fetchSegmentFiles(PartialSegmentMergeTask.java:220) ~[druid-indexing-service-0.20.1.jar:0.20.1] 	at org.apache.druid.indexing.common.task.batch.parallel.PartialSegmentMergeTask.runTask(PartialSegmentMergeTask.java:158) ~[druid-indexing-service-0.20.1.jar:0.20.1] 	at org.apache.druid.indexing.common.task.batch.parallel.PartialGenericSegmentMergeTask.runTask(PartialGenericSegmentMergeTask.java:41) ~[druid-indexing-service-0.20.1.jar:0.20.1] 	at org.apache.druid.indexing.common.task.AbstractBatchIndexTask.run(AbstractBatchIndexTask.java:140) ~[druid-indexing-service-0.20.1.jar:0.20.1] 	at org.apache.druid.indexing.overlord.ThreadingTaskRunner$1.call(ThreadingTaskRunner.java:211) [druid-indexing-service-0.20.1.jar:0.20.1] 	at org.apache.druid.indexing.overlord.ThreadingTaskRunner$1.call(ThreadingTaskRunner.java:151) [druid-indexing-service-0.20.1.jar:0.20.1] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_282] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_282] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_282] 	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_282] 2022-07-05T18:36:46,246 ERROR [threading-task-runner-executor-3] org.apache.druid.segment.realtime.appenderator.UnifiedIndexerAppenderatorsManager - Could not find datasource bundle for [datasource], task [partial_index_generic_merge_datasource_mngkoeoe_2022-07-05T18:36:44.742Z]


Update components which interface with old React context API

Feature Request
Description
In a lot of the terra components that interface with react-intl, we've been interfacing with the old React context API directly. We should update the components to use an abstraction like FormattedMessage or injectIntl to interface with react-intl's Intl context. This should allows us to more easily update to react-intl v3 when it is released.
More info on how we recommend to build components with FormattedMessage and/or injectIntl: https://engineering.cerner.com/terra-ui/#/getting-started/terra-ui/internationalization/building-components-which-include-translations

We've reverted the PR as we had seen it introduced some unintended breaking changes. We are planning to talk through some updates to see if we can make this update passive.

We talked in the terra leadership sync meeting this week and want to move forward with using the render prop version of <FormattedTranslations />
import { FormattedMessage } from 'react-intl';
import Button from 'terra-button';

const Toggle = () => (
  <FormattedMessage id="App.toggle">
    {txt => (
      <Button text={txt} />
    )}
  </FormattedMessage>
);

If we are already using injectIntl in a component, we can continue using that.
The thinking behind this is that we believe this should be a more passive update instead of wrapping components with injectIntl. If you have questions about this change, feel free to post a comment back on this issue.

I was able to implement majority of the scenarios using FormattedMessage, except for the following cases:

https://github.com/cerner/terra-framework/blob/issue-752-replacing-react-context-with-formatted-message/packages/terra-date-picker/src/DateInput.jsx#L150 , How do we retrieve the "locale string" in this case? (similar code segments in "DatePicker" file as well)
https://github.com/cerner/terra-framework/blob/issue-752-replacing-react-context-with-formatted-message/packages/terra-time-input/src/TimeInput.jsx#L144 , How do we retrieve the "messages" without using injectintl?
https://github.com/cerner/terra-framework/blob/issue-752-replacing-react-context-with-formatted-message/packages/terra-date-time-picker/src/_TimeClarification.jsx#L133 , If we wrap this "Button" with "FormattedMessage" then i am unable to simulate a click event in jests.

Can we use the injection API for the above?

@avinashg1994 I'm talking with the team about this update and will post back once I have some consensus on the direction we want to go with this.

@avinashg1994 Talked about this with @ryanthemanuel. The plan is to move forward with injectIntl in the places that you've identified where it doesn't make sense to use <FormattedMessage />


Optimize findConfigedPorts method of ServiceConfig to log only one ti…

What is the purpose of the change
Optimize findConfigedPorts method of ServiceConfig to log only one time when one protocol use random port
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #2928 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2928      +/-   ##
==========================================
- Coverage   63.92%   63.81%   -0.11%
==========================================
  Files         578      578
  Lines       25928    25928
  Branches     4539     4539
==========================================
- Hits        16574    16547      -27
- Misses       7189     7212      +23
- Partials     2165     2169       +4

Impacted Files
Coverage Δ

...in/java/org/apache/dubbo/config/ServiceConfig.java
54.62% <100%> (ø)
:arrow_up:

.../remoting/transport/netty4/NettyClientHandler.java
75% <0%> (-11.12%)
:arrow_down:

...che/dubbo/remoting/transport/mina/MinaChannel.java
43.42% <0%> (-10.53%)
:arrow_down:

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
41.66% <0%> (-8.34%)
:arrow_down:

...in/java/org/apache/dubbo/common/utils/JVMUtil.java
73.58% <0%> (-7.55%)
:arrow_down:

...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
83.33% <0%> (-5.56%)
:arrow_down:

.../apache/dubbo/remoting/transport/AbstractPeer.java
63.04% <0%> (-4.35%)
:arrow_down:

...pache/dubbo/remoting/transport/AbstractServer.java
45.36% <0%> (-3.1%)
:arrow_down:

...he/dubbo/registry/multicast/MulticastRegistry.java
63.79% <0%> (-1.73%)
:arrow_down:

...dubbo/remoting/exchange/support/DefaultFuture.java
68.45% <0%> (-1.35%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 107a0cc...ec6faad. Read the comment docs.

@beiwei30 Thanks for prompt ! I have submit a new pull request. (Because the branch conflict so I check a new branch.)

dup, close it.


[R-package] remove deprecation warnings on lgb.prepare() functions

In LightGBM 3.0.0, the lgb.prepare* family of functions were removed (#3075 , #3095). That release still technically left those functions in {lightgbm}, but had them throw an error encouraging the use of lgb.convert() andlgb.convert_with_rules().
This PR proposes removing those functions completely. It's been more than a month since LightGBM 3.0.0, so I think the deprecation has been in the package long enough.
Removing these functions should slightly reduce the time it takes to build, install, and test the R package, and slightly reduce the size of the installed package.

gently ping @Laurae2 or @guolinke for review. I think this would be a very quick review, whenever you have time.


Warning: Failed propType: Required prop renderPage was not specified in Navigator.

The following code yields this error: Warning: Failed propType: Required prop ``renderPage`` was not specified in Navigator. Check the render method of MainNavigation. I'm using react-onsenui 0.1.1. I also tried with 0.0.17 and it turns out that there the problem does not occur.
The used code is from the blog example: https://onsen.io/blog/react-onsen-ui-navigator-tabs/
class MainNavigation extends React.Component {

  renderScene(route, navigator) {
    // console.log(route, navigator);

    const props = route.props || {};
    props.navigator = navigator;

    return React.createElement(route.component, props);
  }

  render() {
    return (
          <Navigator
              initialRoute={{component: MainPage}}
              renderScene={this.renderScene}
          />
    );
  }
}

ReactDOM.render(<MainNavigation />, document.getElementById('app'));

Problem starts at version 0.0.19

Thanks @corneyl ! The renderScene prop was renamed to renderPage.
We will be releasing a website with docs pretty soon. Thanks for trying it out :)
We are very grateful for all reports we get.


@conda-forge-admin, please add bot automerge

@conda-forge-admin please add bot automerge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/testflows.asserts-feedstock#2.


Added JACC.multi for CUDA. Testing doesn't work, I got a segmentation…

… fault, it can be because of the use of multiple GPUs, we need to know why. Same code runs well on a Julia terminal

Test this, please

test this, please

Test this please


Setup builds for integrating in Cloud UI

Summary of changes
👆
Checklist

[x] Link to issue this PR refers to: https://github.com/crate/cloud/issues/1608
[x] Relevant changes are reflected in CHANGES.md.
[ ] Added or changed code is covered by tests.
[x] Required Grand Central APIs are already merged.

Many thanks for all the suggestions @SStorm. I have implemented all the fixes and suggestions that we have talked about. Let me know if everything is ok 😁


com.github.saurfang#sbt-spark-submit;0.0.4: not found

I try to run MNIST example in Intellij, but I have this error in build phase.
Error:Error while importing SBT project:
...

[error] 	at sbt.util.Tracked$.$anonfun$inputChanged$1(Tracked.scala:149)
[error] 	at sbt.internal.LibraryManagement$.cachedUpdate(LibraryManagement.scala:118)
[error] 	at sbt.Classpaths$.$anonfun$updateTask$5(Defaults.scala:2353)
[error] 	at scala.Function1.$anonfun$compose$1(Function1.scala:44)
[error] 	at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:42)
[error] 	at sbt.std.Transform$$anon$4.work(System.scala:64)
[error] 	at sbt.Execute.$anonfun$submit$2(Execute.scala:257)
[error] 	at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:16)
[error] 	at sbt.Execute.work(Execute.scala:266)
[error] 	at sbt.Execute.$anonfun$submit$1(Execute.scala:257)
[error] 	at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:167)
[error] 	at sbt.CompletionService$$anon$2.call(CompletionService.scala:32)
[error] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[error] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[error] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[error] 	at java.lang.Thread.run(Thread.java:748)
Invalid response.
[error] (*:update) sbt.librarymanagement.ResolveException: unresolved dependency: com.github.saurfang#sbt-spark-submit;0.0.4: not found
[...]

Woj-i, this feels more like a intellij issue, than anything else. What version of intellij are you using? I've noticed some issues with intellij not picking up the dependencies, which is partly due to spark-tsne also building for scala-2.10. I needed to tweak the imported files a bit before everything went smoothly.


Prerender service returns blank page

I have tried our app directly on your service and it runs great:
http://service.prerender.io/https://hearth-net-topmonks-staging.herokuapp.com/app/?_escaped_fragment_=/ad/537c4deda5a5570200000e4d
but when I call your service through ruby middleware on address:
https://hearth-net-topmonks-staging.herokuapp.com/app/?_escaped_fragment_=/ad/537c4deda5a5570200000e4d
it will end after 10 seconds with blank page:

I tried it also on local prerender server and there were same URLs to render in console.
Maybe some static assets may cause problem while fetching page?

Hello,
I am getting the same issue. Any help for that?

Hello,
I am getting the same issue. Any help for that?

For us, the error was (as @thoop said) because of RoR server which was using only one thread so it ended in deadlock (client requested page on ruby, ruby made request to prerender and prerender made request back to ruby to scrape the page, but it was already waiting for prerender's result so it timeouted every time)
We used nginx proxy to handle request from robots and transfer it to prerender and it works fine.. Or you can use some service like DivShot to host your frontend app - it has already prerender support in it.

For us, the error was (as @thoop said) because of RoR server which was using only one thread so it ended in deadlock (client requested page on ruby, ruby made request to prerender and prerender made request back to ruby to scrape the page, but it was already waiting for prerender's result so it timeouted every time)
We used nginx proxy to handle request from robots and transfer it to prerender and it works fine.. Or you can use some service like DivShot to host your frontend app - it has already prerender support in it.

Ok, but I also tried with unicorn and it does not work, always white page but without any error.

Ok, but I also tried with unicorn and it does not work, always white page but without any error.

How many threads did you use with Unicorn? Do you have a public URL that I can test and make sure PhantomJS isn't crashing? Feel free to email me at<EMAIL_ADDRESS>

How many threads did you use with Unicorn? Do you have a public URL that I can test and make sure PhantomJS isn't crashing? Feel free to email me at<EMAIL_ADDRESS>

We are experiencing this but in wordpress site. Do you have any thoughts about why am I experiencing this on wordpress?

Found the issue, we are using intercom plugin and that's where the conflict is. Do you have any suggestion how can I fix this? Do we have to get rid on that plugin?

Shouldn't have any issues with intercom. Feel free to create a new issue with some more information so we can look into it. Thanks!


DataGridCheckBoxColumn usage  -- throws an Unhandled exception.

This happens when DataGridCheckBoxColumn is used in a DataGrid and is bound to a boolean property in the backing model. When the column is clicked and the check boxes checked/unchecked -- it behaves as expected -- but then when I close the main window, the exception is thrown.  This does not happen when only text columns are used and interacted with. It also doesn't happen if I do NOT interact with the checkbox column at all and just close the window. It only happens when I close the window AFTER I have interacted with the check box  column.
Development environment:
OSes:

Arch Linux , Gnome 3 , Wayland.
Windows 10 Pro

Dev:   dotnet core 3.1.103
IDE: VS Code
Steps to reproduce:
General procedure to use a DataGrid was that mentioned  in the tutorial article:
Avalonia DataGrid getting started
The only key change I made to the article  was adding a DataGridCheckBoxColumn to the DataGrid and adding a boolean IsChecked property to the "Person" model class used in the tutorial -- and then bind the two together.
So the key steps are:

$ dotnet new avalonia.mvvm
In the *csproj file,  knock up the versions of all Avalonia  includes to 0.9.10 as thats the version of the DataGrid I'm using.
 $ dotnet add package Avalonia.Controls.DataGrid
In the App.xaml , add the style:
<StyleInclude Source="avares://Avalonia.Controls.DataGrid/Themes/Default.xaml"/>
Add the following property to the model class  "Person" --- rest of the the code is untouched and is as per the linked tutorial:

 public bool IsChecked
        {get;set;}

Add the DataGridCheckBoxColumn to the DataGrid and bind it as shown below (rest of the columns are untouched and are as per the linked tutorial):

<DataGrid.Columns>
        <DataGridTextColumn Header="First Name"
                            Binding="{Binding FirstName}"
                            Width="2*" />
        <DataGridTextColumn Header="Last Name"
                            Binding="{Binding LastName}"
                            Width="2*" />
        <DataGridTextColumn Header="Department"
                            Binding="{Binding DepartmentNumber}"
                            Width="*" />

        <DataGridCheckBoxColumn Header="IsChecked"
                            Binding="{Binding IsChecked}"
                            Width="*" />

    </DataGrid.Columns>

Then when I run the application (either from command line or vscode) -- the GUI shows up as expected-- with all the columns and values -- and the additional checkbox column is normally shown. __
When I click in the checkboxes column -- the check boxes do get checked and unchecked as expected (although one extra click is required).  But then when I close the window by clicking on the "X" on right upper corner -- that's when the unhandled exception happens -- NOT before that.

The complete exception text:
Unhandled exception. System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
at System.Collections.Generic.List1.Enumerator.MoveNextRare()    at Avalonia.Collections.AvaloniaList1.Enumerator.MoveNext()
at System.Linq.Enumerable.OfTypeIterator[TResult](IEnumerable source)+MoveNext()
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Visual.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Input.InputElement.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.Control.OnDetachedFromVisualTreeCore(VisualTreeAttachmentEventArgs e)
at Avalonia.Controls.TopLevel.HandleClosed()
at Avalonia.Controls.WindowBase.HandleClosed()
at Avalonia.Controls.Window.HandleClosed()
at Avalonia.X11.X11Window.Cleanup()
at Avalonia.X11.X11Window.Dispose()
at Avalonia.X11.X11Window.OnEventSync(XEvent ev)
at Avalonia.X11.X11Window.OnEvent(XEvent ev)
at Avalonia.X11.X11PlatformThreading.HandleX11(CancellationToken cancellationToken)
at Avalonia.X11.X11PlatformThreading.RunLoop(CancellationToken cancellationToken)
at Avalonia.Threading.Dispatcher.MainLoop(CancellationToken cancellationToken)
at Avalonia.Controls.ApplicationLifetimes.ClassicDesktopStyleApplicationLifetime.Start(String[] args)
at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime[T](T builder, String[] args, ShutdownMode shutdownMode)
at d3.Program.Main(String[] args) in /home/[myusername]/[pathtoproject]/Program.cs:line 14

Reproduced on Windows 10 as well -- so it has nothing to do with the underlying OS or windowing system.

Hello world,
The link you provided is wrong (found the article nevertheless)
Did you tried latest build ,09.9 i think
Regards,
Remco

Thanks for the reply. I will correct the link.
I tried it on 0.9.10 --- all packages on this version.  Following is the relevant part of my project file:
<ItemGroup>
    <PackageReference Include="Avalonia" Version="0.9.10" />
    <PackageReference Include="Avalonia.Controls.DataGrid" Version="0.9.10" />
    <PackageReference Include="Avalonia.Desktop" Version="0.9.10" />
    <PackageReference Include="Avalonia.ReactiveUI" Version="0.9.10" />
  </ItemGroup>

Works on my machine
win 10

Thanks for the reply. For the time being I have given up on finding a solution. Maybe it will go away in the future.  On the  extra click thing , I have read somewhere on the net that the first click is just for selecting the checkbox (and the second click is for actually checking/unchecking) -- while the three valued checkbox looks very different (I've tried that as well).
Meanwhile I will settle for the following DataGridTemplateColumn based solution/workaround with embedded regular checkbox -- which works for me without throwing any exceptions, and actually has the nice side effect of the checkbox being checked/unchecked on a single click!  So I'm for now :)
<DataGridTemplateColumn Header="Check/Uncheck">
           <DataGridTemplateColumn.CellTemplate>
               <DataTemplate>
                   <CheckBox IsChecked="{Binding IsChecked}"/>
               </DataTemplate>
           </DataGridTemplateColumn.CellTemplate>
       </DataGridTemplateColumn>

if thats works than that is a reasenable solution, actually, i was at te point to advice a datatemplete  which this basicly is.
Stil dont know why it fails i made several datagrid test project with succces
Mabe the wrong version (0.9.1 is a bit old) latest version now is 0.9.9 i believe.
What you could try is to nuget the latest version
Regards,
Remco

Its the latest version. It is 0.9.10 ( and NOT  0.9.1 ).

Its the latest version. It is 0.9.10 ( and NOT 0.9.1 ).

Yeay your right, my bad.
I did read that wrong.
I thought the version after 0.9.9 would be 1.0.0 not 09.9.10
Silly me ;)

This is also happening with 0.9.12.  However, if I put an Exit button and call this.Close() the exception is not thrown.
@danwalmsley Is this being looked at?


Automated role management: create "helper roles"

Given a channel and a role to inherit properties from (currently just color), helper roles should be created and automatically made pingable.
e.g. !createhelperrole #c-language C should create a "C (helper)" role of the same color as the "C" role and should be made pingable from the #c-language channel.

Good idea, will make deletehelperrole too

https://github.com/strinking/futaba/pull/373