Obsolete-some high-level grouping classes AND review children terms

This issue is part of the November 2021 Mondo workshop here
Mondo term (ID and Label)
disease of cell nucleus
hip region disease
abdominal and pelvic region disorder
head or neck disease/disorder
limb disorder
thoracic disease
pigmentation disease - NV: I added the obs tag
Reason for deprecation
This is a grouping class- it is difficult to maintain the children terms and it was determined that is no longer needed.
!!! We need to review and make sure that all the children terms have another parent

Note that we might want to create a new issue for each term being obsoleted, especially if children become orphane and need to be reclassified

Breast disease:
Children are a mix of neoplasm and post-partum,...
TODO:

[ ] Keep this as a high-level term
[ ] Review children (some should have more than one parent (e.g breast neoplasm)

I wonder if we should add jaundice as a grouping class (see NCIT: https://www.ebi.ac.uk/ols/ontologies/ncit/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FNCIT_C3143&lang=en&viewMode=All&siblings=false)
MESH classifies neonatal jaundice as a child of MONDO_0024288 hyperbilirubinemia

Both jaundice and hyperbilirubinemia are not diseases, they should be HPO terms. jaundice is a manifestation of hyperbilirubinemia, which has a ton of different causes.
neonatal jaundice is a disease (phenotypic feature plus implied etiology).

I agree with Peter, except that neonatal jaundice can have many etiologies.  The disease entity is really neonatal jaundice due to ABO incombatibility.  Otherwise the list is very long.

@pnrobinson @ahamosh Thank you for your answers. I however have more questions.
The Mondo term 'neonatal jaundice' (disease) includes terms with different etiologies: due to accelerated destruction of erythrocytes, liver immaturity,...
This is the current classification:

Therefore, 'neonatal jaundice due to ABO incompatibility' would refer to a more specific term. Is this right?
Should we instead obsolete the grouping term "neonatal jaundice", and create more specific terms which would be defined by their etiologies?
Thank you in advance!

I would get rid of this as a disease.
Ada
Get Outlook for iOShttps://aka.ms/o0ukef

From: sabrinatoro @.>
Sent: Thursday, February 10, 2022 3:16:35 PM
To: monarch-initiative/mondo @.>
Cc: Ada Hamosh @.>; Mention @.>
Subject: Re: [monarch-initiative/mondo] Obsolete-some high-level grouping classes AND review children terms (Issue #4111)
@pnrobinsonhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpnrobinson&data=04|01|ahamosh%40jhmi.edu|01a1d3ed851143879ff908d9ecd23d33|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637801209992371984|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=bzPjiU5AatH6q2ZjfTuOC%2B3SXPAWSxoTXPqYsvyoy4s%3D&reserved=0 @ahamoshhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fahamosh&data=04|01|ahamosh%40jhmi.edu|01a1d3ed851143879ff908d9ecd23d33|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637801209992371984|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=HZ3SGSW35R35hcyvXRmBwaCW2WfQep8%2B%2F%2FryxBA2BLw%3D&reserved=0 Thank you for your answers. I however have more questions.
The Mondo term 'neonatal jaundice' (disease) includes terms with different etiologies: due to accelerated destruction of erythrocytes, liver immaturity,...
This is the current classification:
[Screen Shot 2022-02-10 at 12 01 09 PM]https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F12737987%2F153488735-3cef569f-c491-47fb-a387-6e5a5c792ab8.png&data=04|01|ahamosh%40jhmi.edu|01a1d3ed851143879ff908d9ecd23d33|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637801209992371984|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=AnTJYfKdLoSaVUE41N%2FuE3%2F10aFa701MeV6%2FOApKs1c%3D&reserved=0
Therefore, 'neonatal jaundice due to ABO incompatibility' would refer to a more specific term. Is this right?
Should we instead obsolete the grouping term "neonatal jaundice", and create more specific terms which would be defined by their etiologies?
Thank you in advance!
—
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmonarch-initiative%2Fmondo%2Fissues%2F4111%23issuecomment-1035454217&data=04|01|ahamosh%40jhmi.edu|01a1d3ed851143879ff908d9ecd23d33|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637801209992371984|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=WL1F2gva3owRaY6G0yGym4VLJxLoSmWCq3wVfsAS%2FLQ%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKKZWRHAMRTTI4WOOXW2GBTU2QMKHANCNFSM5JSAARNQ&data=04|01|ahamosh%40jhmi.edu|01a1d3ed851143879ff908d9ecd23d33|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637801209992371984|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=wj8tfa782O8PP32Uokcq1LgO3%2B0spiz5Lr4syB9U870%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|ahamosh%40jhmi.edu|01a1d3ed851143879ff908d9ecd23d33|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637801209992371984|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=HMyZ9GMqq8%2Bd1MnX2H%2FdGktUBEtFDSfi0fR9urxrhCI%3D&reserved=0 or Androidhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|ahamosh%40jhmi.edu|01a1d3ed851143879ff908d9ecd23d33|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637801209992371984|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=RQuETTLhCFA0J7L3%2FKMPcUndriKy8QjfPqF8rFFEYX0%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

@sabrinatoro I think we should obsolete these two terms as well (children of thoracic disease, which will become orphaned after thoracic disease is obsoleted):
MONDO_0015879 'non-syndromic diaphragmatic or thoracic malformation'
MONDO_0015880 'syndromic diaphragmatic or thoracic malformation'
I'll add them to the list for June obsoletion

I agree.

New issues were created for the remaining obsoletion. I think this issue can be closed.


Ability to define coerce, serialize, deserialize (etc) in class definitions.

Continuing from what I was thinking in #1385, would it be convenient to allow coerce, serialize, and deserialize (I think they can be handy) to be defined on class prototypes?
For example:
import { withComponent, props } from 'skatejs'

class MyEl withComponent(HTMLElement) {
  static props = {
    foo: props.array
  }

  // we can use `this` in any of these methods, which can be convenient
  get foo() { ... }
  set foo(val) { ... }
  ['coerce foo'](val) { ... }
  ['serialize foo'](val) { ... }
  ['deserialize foo'](val) { ... }
}

@treshugart What I think is nice about having coerce, serialize, deserialize, regardless if they are on the class prototype or not, is that they make a clear path otwards doing what people need to do anyways: parse strings to objects during deserialization, and so by removing all those features in the v6 branch, it's removing some of the main functionality that attracts me to Skate. Otherwise, I could parse attributes myself then call manually re-render React/Vue/etc. I really like the idea of structurizing and conventionalizing how serialization/deserialization happens so that defining it is easy and generic.

Interesting. I think that syntax would be hard to swallow for many. There's also the repeated name of the prop, where it feels more closely organised in the static props. That said, subclassing becomes inherent. On the other hand, inheritance of props being explicit (instead of implicit like this) might be a good thing.

I don't see changed, I think you've already removed it.
But yeah, I really like the idea of this referring to the prop definition, and elem being passed in, because this makes it even more flexible than just this referring to the element. 👍

I want props to be WYSIWYG sans deserialize. Types can help here.

I disagree with that because I want anyone to be able to use my elements and have specific guarantees on the data types (useful errors otherwise), even if they don't use TypeScript or Flow, just plain JS.
It'd be really great if it was easy to opt-in/out to either: a TypeScript library author can decide not to use the features, and leave it up to the typing, while another library author could decide to use the features.
In React, we can use TypeScript, but we can also use a runtime PropTypes system. We have the ability to choose either, or both.

Oh, I see changed was turned into get/set. I think I like the new get/set. Still looking at it...

If at some point there's compelling evidence that doing this style of prop definitions is something we should do, then we can consider it. However, as of right now, it doesn't seem as nice as using props and I want there to be one way.
I think the other concerns have been covered, so I'm going to close this.


[Bug]: Typo in session API response object - "organisation"

Preflight Checklist

[X] I could not find a solution in the documentation, the existing issues or discussions
[X] I have joined the ZITADEL chat

Environment
Self-hosted
Version
2.37.1
Describe the problem caused by this bug
There is a typo in word "organization" in API https://zitadel.com/docs/apis/resources/session_service/session-service-get-session, response object, path session/factors/user/organisationId. Should be `organizationId".
Besides, there is a number of other places in code where this typo "organisation" exists.
To reproduce
Search codebase, a number of same typos exist. In this API too: https://zitadel.com/docs/apis/resources/session_service/session-service-get-session
Screenshots
No response
Expected behavior
No typos in "organization" word :)
Operating System
No response
Relevant Configuration
No response
Additional Context
No response

hei @dimyle
Thanks for the report.
The solution we like to implement for now is that we add the correct one with organizationId, and mark the wrong as deprecated.
Latest for GA of the API we will remove the old one.
Also we should quickly go though other endpoints to see if it is written wrong somewhere else.
Other places:

create human user --> Organisation


Fix grid height

Purpose
Fix #229
Change
Make the height of the grid undefined so that not the default size of the grid is shown.
Drawback: Applying this function to grids with a lot of content makes them expand even more. Maybe we need to dynamically check for the amount of data to be displayed in a grid to make sure it won't get too big.

 Fix issue #229 (Grid size should be responsive to the content shown)

 Fix issue #229 (Grid size should be responsive to the content shown)


Wildcard or undefined react component_name

We have components that seems to be autogenerated, so they change, so it would be cool to be able to do
// with react root element
const loginButton = element(
  by.ReactSelector(undefined, { label: "OK" }, {}, "#root")
);

And this would give me, any react component that has the props {label: "OK}
Our components looks like this

OK - I found out that this actually works in version 2.1.0!
Great


double-beep: Watch +1-860 266 2763

double-beep requests the watch of the watch_number +1-860 266 2763. See the MS search here and the Stack Exchange search here.

Approved by Makyen in Charcoal HQ


Create arc.py Example for arc users

Tested with a 2013 push-button monome arc.
I got some errors when installing the code from pip
aiosc==0.1.4
pymonome==0.10.0

but when running against HEAD I didn't get these errors so I assume this is fixed.

@SuuBro thanks, I've just pushed a new release to PyPI too:
https://pypi.org/project/pymonome/

Thanks! And also thanks for maintaining this repository to a high standards for the community 👍


Feat: Use Ruff as a linter and formatter

In this pull request, the decision was made to exclusively transition from pylint and black to utilizing Ruff, a high-speed Python linter and code formatter written in Rust, due to its rapid feedback loop, comprehensive rule set, and compatibility with popular code editors, aiming to accelerate checks and improve the development flow.

Nice work.


Add support for macOS [SDK-4706] 3/3

[ ] All new/changed/fixed functionality is covered by tests (or N/A)

📋 Changes
This PR updates the sample app to support macOS.

Please disregard the CircleCI failure, its config will be removed in a future PR.


Integrate LLVM at llvm/llvm-project@abfac56

Argh. One of the benchmark jobs flaked and retrying isn't enough to fix the following jobs (they do something "clever" with github runs and expected files to download). Might need to push a new commit to fully re-run the jobs.


Name of the Chat

It would be great to include options -- either in the plugin controls, or in the chat metadata -- to change the text rendering. For example:
[stowe boyd=h3]
> stowe boyd | this is the comment

Would lead to a chat box with 'stowe boyd' rendered in whatever h3 styling is set to in the theme. Also, this could make the text in the comment foldable, potentially.

PS I note that when a chat is referenced through a transclusion, the header is rendered differently:

PS I note that when a chat is referenced through a transclusion, the header is rendered differently:

Could you open a separate issue for this?

Would lead to a chat box with 'stowe boyd' rendered in whatever h3 styling is set to in the theme.

Wouldn't it be a bit weird to have styling per member? Ideally, you would have all messages in the chat set to the same header.

Also, this could make the text in the comment foldable, potentially.

As far as I know, text folding is an obsidian feature. The Chat View is rendered in regular HTML. The title is already an h4. I don't think text folding could work that way.

I've added the ability to customize the style of Chat Headers for the entire block in the new version (1.1.0). You can now add a config to the top of your code block as follows:
{header=h3}
This will change the header styles for all Chat Bubbles as it didn't make sense to do it speaker-wise.


Allow to bypass format detection on upload?

Sometimes the format detection fails, just because if precedence, see https://github.com/ContactEngineering/SurfaceTopography/issues/93#.
Idea: The upload form could have an additional dropdown labeled Format:  with default autodetect.
With that the user could specify a specific format in case the detection fails.

I don't like this suggestion. If the detection fails, we need to fix the detection


Build failing after updating nixpkgs-unstable with ln: failed to create symbolic link '/nix/store/...-vimplugin-treesitter-grammars/parser/lua.so': File exists

⚠ Please verify that this bug has NOT been reported before.

[X] I checked all existing issues and didn't find a similar issue

Description
Started getting this ln: failed to create symbolic link '/nix/store/...-vimplugin-treesitter-grammars/parser/lua.so': File exists build failure on both my Darwin and WSL machines after updating my nixpkgs input (which nvf follows) to the latest nixpkgs-unstable. I should note that the install: skipping file '/dev/fd/63', as it was replaced while being copied line in the logs below is not relevant, see https://github.com/NixOS/nixpkgs/issues/335016.
👟 Reproduction steps
https://github.com/uncenter/flake
No changes to my flake configuration, just update(s) to Nixpkgs seemingly broke this. Not sure where this issue is coming from, https://github.com/NixOS/nixpkgs/pull/319233 might have made it into nixpkgs-unstable around the time I updated the input?
👀 Expected behavior
Build succeeding for nvf.
😓 Actual Behavior
Build failed for nvf.
💻 Metadata

system: "aarch64-darwin"  - host os: Darwin 24.0.0, macOS 15.0  - multi-user?: yes  - sandbox: yes  - version: nix-env (Lix, like Nix) 2.91.0 System type: aarch64-darwin Additional system types: aarch64-darwin, x86_64-darwin Features: gc, signed-caches System configuration file: /etc/nix/nix.conf User configuration files: /Users/uncenter/.config/nix/nix.conf:/Users/uncenter/.nix-profile/etc/xdg/nix/nix.conf:/etc/profiles/per-user/uncenter/etc/xdg/nix/nix.conf:/run/current-system/sw/etc/xdg/nix/nix.conf:/nix/var/nix/profiles/default/etc/xdg/nix/nix.conf Store directory: /nix/store State directory: /nix/var/nix Data directory: /nix/store/gnc7drr3bs3kvmiir7drdigf6f6glagm-lix-2.91.0/share  - nixpkgs: /nix/store/p9sy5nf9jdwj69gmr3c3n03npzr5kkqi-source

📝 Relevant log output
error: builder for '/nix/store/m25bdw4b80qyzv8qwby5gfzdgw9j59m6-vimplugin-treesitter-grammars.drv' failed with exit code 1;
       last 2 log lines:
> install: skipping file '/dev/fd/63', as it was replaced while being copied
> ln: failed to create symbolic link '/nix/store/8r6a1wb959pq23g1vv0p23h1wml5lnlq-vimplugin-treesitter-grammars/parser/lua.so': File exists
       For full logs, run 'nix log /nix/store/m25bdw4b80qyzv8qwby5gfzdgw9j59m6-vimplugin-treesitter-grammars.drv'.
error: 1 dependencies of derivation '/nix/store/ggpgscm87iang25yvfr154fimlflizhg-start-configdir.drv' failed to build
error: 1 dependencies of derivation '/nix/store/sni4sn24a8bwdscqawx2j4az2bc0idsb-neovim-pack-dir.drv' failed to build
error: 1 dependencies of derivation '/nix/store/k0bhynvxxvh1kf2gl4zc5agnqhibafbp-mnw-nvf-0.10.1.drv' failed to build

I was looking at #361 but this is a different issue, though again related to neovim-pack-dir?

CC @Gerg-L since he mentioned breaking darwin before.

Treesitter build failure prob nixpkgs fault

To nobody's surprise...

Treesitter build failure prob nixpkgs fault

I wrote https://github.com/NixOS/nixpkgs/pull/319233; I haven't tested with my personal NixOS configuration yet but it should have been built when I ran the package tests and others (r-vdp, PerchunPak) say it works for them. I ran nix build .#vimPlugins.nvim-treesitter.tests.check-queries on the latest nixpkgs-unstable (https://github.com/NixOS/nixpkgs/commit/4f9cb71da3ec4f76fd406a0d87a1db491eda6870) and it works for me.
The error message (file exists) is particularly strange, either that means there's two different grammars named lua (unlikely) or the build is somehow in an improper state, since there should never be files left from previous builds. Does nix store verify --all do anything? Have you bisected the error to the PR https://github.com/NixOS/nixpkgs/pull/319233?

It's happening because it's trying to build the Lua parser twice.
The Lua language module adds the Lua parser to vim.treesitter.grammars -> vim.treesitter gets enabled -> Treesitter module tries to add all the vim.defaultGrammars to vim.treesitter.grammars (which includes Lua) -> triggers the Lua parser build again.
As a workaround, you can disable adding the default grammar by setting vim.treesitter.addDefaultGrammars to false and add the the grammars you need manually to vim.treesitter.grammars.

I see. Should I change the ln -s to ln -sf?

To handle multiple revisions of parsers, I suggest adding a suffix to each one to tell them apart, considering Neovim supports multiple parsers.
Neovim loads the first available parser and parsers are searched for as parser/{lang}.* in runtimepath according the docs.
nix-repl> pkgs.vimPlugins.nvim-treesitter.builtGrammars.c.name
"c-grammar-0.0.0+rev=deca017"

Grammars already have a revision tag, so it should be an easy task. Identical parsers are unintentional, so the error makes sense. Not sure how it was handled before the changes, though.

It's happening because it's trying to copy the Lua parser twice.
The Lua language module adds the Lua parser to vim.treesitter.grammars -> vim.treesitter gets enabled -> Treesitter module tries to add all the vim.defaultGrammars to vim.treesitter.grammars (which includes Lua) -> triggers the Lua parser copy again.
As a workaround, you can disable adding the default grammar by setting vim.treesitter.addDefaultGrammars to false and add the the grammars you need manually to vim.treesitter.grammars.
The changes introduced in NixOS/nixpkgs#319233 don't handle duplicate entries.

Thanks, will try that! As an extra data point (probably amounting to the same root cause): Inspecting the closures with nix-tree after setting vim.languages.enableTreesitter = false I still get an almost 400MB closure called start-configdir with a dependency vimplugin-treesitter-grammars. But I guess from that PoV the merging behaviour under vim.languages... should be made to correctly take care of duplicates?

I thought it could have been mnw, but it's not.
As far as I remember, we add a few treesitter grammars by default to suppress Neovim health-checks. Markdown, markdown in-line, vim, Lua and one or two more. Those could be the reason behind the increased closure size. I will need to take a look.
I have also been meaning to switch to https://github.com/viperML/tree-sitter/ for the grammars. Maybe this is a good excuse to do so.

@NotAShelf Just to let you know: the (perceived) large size of start-configdir seems to be mostly caused by markdown-preview.nvim-2023-10-17, so it's not "the fault" of any duplicates...

also, withAllGrammars didnt include any queries dirs until recently, but they worked before? and when those were added some parsers started having issues when lazy loaded, meaning there are some being included SOMEHOW?
The issue is IDK how they were being included before, but it still finds them with just the parsers in the rtp.
Does anyone have any insight for me as to how the queries are being resolved when only the parser is in the rtp?

withAllGrammars didnt include any queries dirs until recently, but they worked before?

nvim-treesitter has queries for many languages so that's probably where
https://github.com/nvim-treesitter/nvim-treesitter/tree/master/queries
you can use vim.api.nvim__get_runtime({'queries/rust'}, true, {})  to list matching dirs in rtp

TYSM theyre literally copied into the nvim-treesitter directory hahaha

anyway thank you so much I somehow forgot to look at the original source when I was looking at nixpkgs nvim-treesitter....

https://github.com/NixOS/nixpkgs/pull/339589 (tracker) was just merged, so this can be closed. Please ping me if you see any other issues with current solution

I'll keep this open until the PR hits unstable so that I don't forget about it.

But looks like the universe wants it closed...

The fix is in the nixos-unstable! Though not yet in nixpkgs-unstable

The fix is in the nixos-unstable! Though not yet in nixpkgs-unstable

:+1:  Cool, usually it's the other way around though, or am I mistaken?

usually yeah. idk why but like 25% of the time its not XD

TIL

Since we target nixos-unstable, I consider the issue resolved. Though, I still need to test it myself so I will be keeping this open for a little more, possibly until after I bump the nixpkgs input.

Ignore my previous silly comment...
I consider this issue resolved, but I will keep it open until I am able to test the unstable branch myself. Thank you all for chiming in.

Closed as the fix is now in all branches, the nixpkgs input has been updated.

fyi revert that should fix every other problem was just merged #341079 (tracker)


[dev.icinga.com #12792] write specs for ido and web2

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12792
Created by vkhatri on 2016-09-25 14:17:04 +00:00
Assignee: vkhatri
Status: Assigned
Target Version: (none)
Last Update: 2016-09-25 14:17:04 +00:00 (in Redmine)

Closing for now, will create a new one.


Test against Mongoid 7.

Coverage remained the same at 95.724% when pulling ef59f39a93585cb3f089e41e464e9048f8341ced on dblock:mongoid-7 into 9d25a5a3b93e33147ca0824dfe3d88c9278824d1 on mongoid:master.

Ironic how testing against a newer version of Mongoid fails the build for decreasing test coverage.


Browser version detection issue

Hi,
when I use config like:
var $buoop = { notify:{i: 11, f: 54, o: 45, s: 10, c: 58},  insecure:true,  unsupported: true, api:5 };
then for chrome 65.0.03325.181 (64-bit)  I received information:
Your web browser (Chrome 65) is out of date.

Hi!
I somehow cannot reproduce this with my chrome 65. Can you tell me what you see on this page:
http://browser-update.org/test/bar.html
Then I an try to debug this.

Hi
You have " unsupported:true " in your configuration. Chrome 65 was superseded by chrome 66 6 days ago.
This is why it gets notified.

Usually we will wait for about 2 weeks till we will notify unsupported versions.


Please Triage the Open Issues

It is difficult for a newcomer to get an project-overview, simply because several issues are unprocessed.
Issues should get at a minimum a category (bug, enhancement) and possibly a priority.
This would be something for the existent maintainers to do.
https://github.com/ripple/rippled/issues?q=is%3Aopen+is%3Aissue+no%3Alabel

I've added labels to all the open issues and closed several stale issues. Hopefully that is a bit more helpful.
I believe there are still issues that are only in Ripple's private Jira instance, but the team hopes to stop using Jira soon and have all issues in GitHub.


Indent blankline keeping highlighting when scrolled past

Using the latest indent-blankline from the lua branch.
When vim.wo.cursorline = true is set and vim.cmd 'colorscheme = toykonight' it will cause blank indentlines to keep the background highlighting from cursorline when scrolled past.

You should probably report this to indent-blankline. I'm not doing anything special with the CursorLine, apart from setting the highlights

I totally forgot I actually already added the workaround to my config:
-- HACK: work-around for https://github.com/lukas-reineke/indent-blankline.nvim/issues/59
vim.wo.colorcolumn = "99999"

Thanks! :D


Namespace usage

Describe the solution you would like
When creating a new C# file should use
namespace SampleNamespace;

instead of
namespace SampleNamespace
{
}

@HypeillingerChillinger The C# extension does not have a command to create a new C# file. How are you creating new C# files?

You are right. Thats done by
https://marketplace.visualstudio.com/items?itemName=jchannon.csharpextensions
But may be omnisharp-vscode could provide a command with correct namespace?


Format lambda expression

Summary
See #5810.
Implements ArgumentsParentheses::SkipInsideLambda for FormatArguments to unblock lambda formatting.
Test Plan
Existing snapshots and potentially more fixtures.

0.978 -> 0.98 on django similarity index
I wasn't sure if I wanted to claim this one because I was violating the orphan rule workaround by modifying the generated.rs. I noticed (1) if I regenerated them it'd modify the currently checked in generated.rs, so I figured there may have been some manual adjustments already. (2) I saw #5804 modify it manually in the same way. I looked at some of #4951 as well.
TODO:

[x] Update generated.rs for new ForamtArguments Default
[x] Basic implementation
[x] Review current snapshots
[x] Add more fixtures

TODO(pending):

[ ] Dangling comments https://github.com/astral-sh/ruff/pull/5806#discussion_r1266497499

See comment. In the meantime I'll mark this as ready since the debug assert is a good safeguard IIUC.

Dang! So close


bug: Zig integration broken

Did you check docs and existing issues?

[x] I have read all the LazyVim docs
[x] I have updated the plugin to the latest version before submitting this issue
[x] I have searched the existing issues of LazyVim
[x] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.10.2
Operating system/version
Arch Linux
Describe the bug
On a clean installation, after installing the new Zig extra, as soon as I start witting it shows error messages
Here is a video too in case that helps:
https://github.com/user-attachments/assets/d3c45716-f5b4-4be2-aee6-1733097af163
Steps To Reproduce

Install LazyVIm
Install Zig extra
Open a .zig file (main.zig for example)
Start typing

Expected Behavior
Should not show error messages
Repro
vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    { "LazyVim/LazyVim", import = "lazyvim.plugins" },
    -- add any other plugins here
  },
})

Seems like snippets in zig lsp dont work. Not a LazyVim issues. Feel free to open a PR and/or report upstream

Seems like snippets in zig lsp dont work. Not a LazyVim issues. Feel free to open a PR and/or report upstream

Upstream would be on the ZLS repository (The Zig LSP?)

i have no idea. I don't do zig.
You could also try commenting on the PR that created the zig extra

For now I just disabled it for zig.
return {
  { "garymjr/nvim-snippets", opts = { friendly_snippets = true } },
}

For people stumbling across this; it's a bug in friendly-snippets, there's a PR dating back to 2024-10-08 over at their repo that would fix this.
For anyone not willing to wait until the fix upstream is implemented; you can work your way around as I describe here. Note though that this will make the attempt to update the plugin fail - which I'd consider OK since it seems to be inactive at the moment. The other option would be to disable snippets completely.

Fixed in https://github.com/rafamadriz/friendly-snippets/pull/531


Default to full depth for GitLookup

Fixes #300 using Option 1.  See the issue for justification and other possible solutions.
Also fixes #151 (closed as stale)

This makes better sense but I suspect this will be a good performance hit and needs documented as the default. I'm ok with this but letting @mathieucarbou comment further.

I agree with the change to be the default, it makes complete sense.
The lookup would only be local anyway.
But I would make this configurable through a plugin setting + documented somewhere so that people impacted by the lost perf could set their own "max history count"

This makes better sense but I suspect this will be a good performance hit

Actually, it's not.     The existing default of 10 means that only files with more than 10 commits will take longer; and these are exactly the ones which would otherwise have an incorrect date.
This isn't a benchmark, but I just ran 'mvn license:check -D"license.git.copyrightLastYearMaxCommitsLookup=10" (which replicates the default) on OSHI (2326 commits total) vs. other values from 1 to 150.  It's always pretty snappy on my *nix github action servers and locally on my mac, but these runs are on my MINGW64 terminal on windows which is notoriously slow.  The time for the default (10) depth was 2m14s.  The time for max history (125 or anything greater) was 2m32s.
Depth	Time (seconds)
1	70
2	86
3	93
4	102
5	111
6	117
7	112
8	120
9	124
10	134 <--- this is the current default
15	131
20	135
25	128
30	137
50	128
75	139
100	162
125	152
150	138

Also as another data point posted by @afranken in https://github.com/adobe/S3Mock/issues/241#issuecomment-674772745_

adding <license.git.copyrightLastYearMaxCommitsLookup>100000</license.git.copyrightLastYearMaxCommitsLookup> to the configuration to enable finding a file's creation date even in large GIT histories and changing the line in the copyright template to  Copyright ${license.git.copyrightCreationYear} Adobe. works with version `4.0.rc2.

So I think the performance hit is negligible, and is only slower because it's actually finding the correct answer.

But I would make this configurable through a plugin setting + documented somewhere so that people impacted by the lost perf could set their own "max history count"

They already can set their own using the setting posted above, and that's exactly what is needed to workaround the bug.
I agree, though, that it should be documented, and I complained in #300 that it's not. Should it be a parameter? Should it be renamed to something shorter?

Another data point, demonstrating minimal performance impact:
My CI GHA (Ubuntu JDK17) uses that "essentially infinite" workaround: https://github.com/oshi/oshi/runs/5661865433?check_suite_focus=true
License check took 1m17s.
Compare to the previous (default 10) setting: https://github.com/oshi/oshi/runs/5401533579?check_suite_focus=true
License check took 51s (and failed due to a handful of files losing their earliest year commit history).
There's really no good reason to limit the per-file commit history by default.   Consider the absurdity of this edge case (which I encountered something similar to prompting me to look into this):  a file created 10 years ago in 2012 with no changes except an annual update to the license header copyright year.  So you run license:format to update the range from 2012-2021 to 2012-2022.   You commit.  It complains about the header, because 10 commits ago for this file is the 2013 update, so you run format and it updates to 2013-2022.  You commit. It complains about the header, because 10 commits ago for this file is the 2014 update, so you run format and it updates to 2014-2022.  You commit... and so on 10 times until you're at "Copyright 2022".  For a file written in 2012 with no changes except the copyright header.
I'm happy to document this but I don't know where to put it.

does it belong in the main plugin as a parameter? It's only relevant when the git dependency is included.
it should probably be mentioned where the copyright year substitutions are documented but I don't see where that is.

macOS (native):
with default 10: 21.5 seconds.
with 100000: 26.5 seconds.

Linux (native M1 chip):
with default 10: 10.2 seconds
with 100000: 13.1 seconds

Solaris SPARC (shared compile farm machine):
with default 10: 1m49s
with 100000: 2m14s

AIX POWER8 (shared compile farm machine):
with default 10: 1m06s
with 100000: 1m09s

I'm happy to document this but I don't know where to put it.

I found the docs in the README for the git dependency and updated it.

@dbwiddis : thanks a lot for this analysis this is very helpful!
If the property name makes sense (license.git.copyrightLastYearMaxCommitsLookup) we could stick with it, even if it is long. What I don't like in this name is the part copyrightLastYear... This parameter seems to be much more a global git parameter for maximum history lookup. So if you want to rename it to something shorter, but still keep an alias for the deprecated property so that it is backward compatible, I fully agree. ;-)

If the property name makes sense (license.git.copyrightLastYearMaxCommitsLookup) we could stick with it, even if it is long. What I don't like in this name is the part copyrightLastYear... This parameter seems to be much more a global git parameter for maximum history lookup. So if you want to rename it to something shorter, but still keep an alias for the deprecated property so that it is backward compatible, I fully agree. ;-)

Well the property is only useful for the "last year" lookup but impacts all history.  I changed the name but kept the old value internally for compatibility. Should I add a log warning when the previous name is used?

Should I add a log warning when the previous name is used?

No, don't bother. Goal here would be to "hide" the old prop completely and only document the new one, but still keeping backward compat'.
Thanks a lot for the PR! Tremendous job and cleanup work! 👍


Separate preferences for system light and dark modes

Would be a nice feature to have. Safari reader view already has it.
Need to decide whether this should apply to only the color scheme and tone, or all prefs. Also need to monitor for change in the mode by the user and update the reader accordingly.

Tentative implementation in dev/ b4261e88043162c0eb684e88fbaf399f1bba2b4d. Applying to all prefs.

Final implementation (based on recent changes) in bc127ae, ready for merge.


AzureFileCopyV4 throws AuthorizationPermissionMismatch exception

Note
AzureFileCopyV4 task throws AuthorizationPermissionMismatch exception with my ARM service connection to a subscription; with the exact same ARM service connection, AzureFileCopyV2 is working without a problem.
Required Information
Question, Bug, or Feature?
Type: Bug
Enter Task Name: AzureFileCopyV4
Environment

Server - Azure Pipelines

Account name: msdata
Team project name: AzureSearch
Build definition name: bohuan-StampBuildout-test
Build number: 20210304-1

NOTE: This is also happening in OneBranch pipelines

Agent - Hosted

agent queue name: Azure Pipelines (windows-2019)

Issue Description
AzureFileCopyV4 task throws AuthorizationPermissionMismatch exception with my ARM service connection to a subscription; with the exact same ARM service connection, AzureFileCopyV2 is working without a problem. The same issue exists in OneBranch pipelines, with the following config difference:
AzureFileCopyV2 (working):
- task: AzureFileCopy@2
  displayName: 'Task Name'
  inputs:
    SourcePath: 'SoucePath'
    azureSubscription: 'TEST Subscription connection'
    Destination: 'AzureBlob'
    storage: 'teststorage'
    ContainerName: 'containername'

AzureFileCopyV4 (AuthorizationPermissionMismatch exception):
- task: AzureFileCopy@4
  displayName: 'Task Name'
  inputs:
    SourcePath: 'SoucePath'
    azureSubscription: 'TEST Subscription connection'
    Destination: 'AzureBlob'
    storage: 'teststorage'
    ContainerName: 'containername'

Task logs
AzureFileCopyV2 is working:
Starting: Copy to drop container (TEST)
==============================================================================
Task         : Azure file copy
Description  : Copy files to Azure Blob Storage or virtual machines
Version      : 2.182.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-file-copy
==============================================================================
Import-Module -Name C:\Program Files\WindowsPowerShell\Modules\AzureRM\5.7.0\AzureRM.psd1 -Global
Clear-AzureRmContext -Scope Process
Disable-AzureRmContextAutosave -ErrorAction Stop
Add-AzureRMAccount -ServicePrincipal -Tenant *** -Credential System.Management.Automation.PSCredential -Environment AzureCloud @processScope
 Select-AzureRMSubscription -SubscriptionId 06454cd3-0dcd-4542-aec7-237a0b4c0fae -TenantId ***
Uploading files from source path: 'C:\M\_work\5\b\62\_work\1\a\x64\Release\RollingBuild' to storage account: 'azsbuildstoragetest' in container: 'stampbuildoutv3-20210304-7' with blob prefix: ''
 & "AzCopy\AzCopy.exe" /Source:"C:\M\_work\5\b\62\_work\1\a\x64\Release\RollingBuild" /Dest:"https://azsbuildstoragetest.blob.core.windows.net/stampbuildoutv3-20210304-7" /@:"C:\M\_work\5\b\62\_work\_temp\a095db26-2b3b-402b-a21f-a07eeaba541e" /XO /Y /SetContentType /Z:"AzCopy" /V:"AzCopy\AzCopyVerbose_b5aed33c-9042-4c17-b4ba-7181e454f107.log" /S
[2021/03/04 19:34:00] Transfer summary:
-----------------
Total files transferred: 5093
Transfer successfully:   5093
Transfer skipped:        0
Transfer failed:         0
Elapsed time:            00.00:00:26
Uploaded files successfully from source path: 'C:\M\_work\5\b\62\_work\1\a\x64\Release\RollingBuild' to storage account: 'azsbuildstoragetest' in container: 'stampbuildoutv3-20210304-7' with blob prefix: ''
Disconnect-AzureRmAccount -Scope Process -ErrorAction Stop
Clear-AzureRmContext -Scope Process -ErrorAction Stop
Finishing: Copy to drop container (TEST)

AzureFileCopyV4 is throwing AuthorizationPermissionMismatch exception:
0.0 %, 0 Done, 0 Failed, 5093 Pending, 0 Skipped, 5093 Total,
INFO: Authentication failed, it is either not correct, or expired, or does not have the correct permission -> github.com/Azure/azure-storage-blob-go/azblob.newStorageError, /home/vsts/go/pkg/mod/github.com/!azure/azure-storage-blob-go@v0.10.1-0.20201022074806-8d8fc11be726/azblob/zc_storage_error.go:42
===== RESPONSE ERROR (ServiceCode=AuthorizationPermissionMismatch) =====
Description=This request is not authorized to perform this operation using this permission.
RequestId:cbe2a1c1-d01e-0010-6a2b-11dac2000000
Time:2021-03-04T19:23:21.8333929Z, Details:
   Code: AuthorizationPermissionMismatch
   PUT https://azsbuildstoragetest.blob.core.windows.net/stampbuildout-20210304-1/RollingBuild/AzCmdlet/AzureRM.KeyVault/System.Spatial.dll?timeout=901
   Authorization: REDACTED
   Content-Length: [118448]
   User-Agent: [TFS_useragent AzCopy/10.8.0 Azure-Storage/0.10 (go1.13; Windows_NT)]
   X-Ms-Blob-Cache-Control: []
   X-Ms-Blob-Content-Disposition: []
   X-Ms-Blob-Content-Encoding: []
   X-Ms-Blob-Content-Language: []
   X-Ms-Blob-Content-Md5: []
   X-Ms-Blob-Content-Type: [application/x-msdownload]
   X-Ms-Blob-Type: [BlockBlob]
   X-Ms-Client-Request-Id: [923e9de9-cbd5-4015-70e7-312a4834a29a]
   X-Ms-Version: [2019-12-12]
   --------------------------------------------------------------------------------
   RESPONSE Status: 403 This request is not authorized to perform this operation using this permission.
   Content-Length: [279]
   Content-Type: [application/xml]
   Date: [Thu, 04 Mar 2021 19:23:21 GMT]
   Server: [Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0]
   X-Ms-Client-Request-Id: [923e9de9-cbd5-4015-70e7-312a4834a29a]
   X-Ms-Error-Code: [AuthorizationPermissionMismatch]
   X-Ms-Request-Id: [cbe2a1c1-d01e-0010-6a2b-11dac2000000]
   X-Ms-Version: [2019-12-12]

Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs
   X-Ms-Blob-Content-Type: [application/x-msdownload]
   X-Ms-Blob-Type: [BlockBlob]
   X-Ms-Client-Request-Id: [923e9de9-cbd5-4015-70e7-312a4834a29a]
   X-Ms-Version: [2019-12-12]
   --------------------------------------------------------------------------------
   RESPONSE Status: 403 This request is not authorized to perform this operation using this permission.
   Content-Length: [279]
   Content-Type: [application/xml]
   Date: [Thu, 04 Mar 2021 19:23:21 GMT]
   Server: [Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0]
   X-Ms-Client-Request-Id: [923e9de9-cbd5-4015-70e7-312a4834a29a]
   X-Ms-Error-Code: [AuthorizationPermissionMismatch]
   X-Ms-Request-Id: [cbe2a1c1-d01e-0010-6a2b-11dac2000000]
   X-Ms-Version: [2019-12-12]

0.0 %, 0 Done, 0 Failed, 5093 Pending, 0 Skipped, 5093 Total,

Job 6eb11716-df43-ae4d-7d52-85352e43c00c summary
Elapsed Time (Minutes): 0.0333
Number of File Transfers: 5093
Number of Folder Property Transfers: 0
Total Number of Transfers: 5093
Number of Transfers Completed: 0
Number of Transfers Failed: 1
Number of Transfers Skipped: 0
TotalBytesTransferred: 0
Final Job Status: Cancelled

 & "AzCopy\AzCopy.exe" logout
INFO: Logout succeeded.
Disconnect-AzAccount -Scope Process -ErrorAction Stop
Clear-AzContext -Scope Process -ErrorAction Stop
##[error]Upload to container: 'stampbuildout-20210304-1' in storage account: 'azsbuildstoragetest' with blob prefix: '' failed with error: 'AzCopy.exe exited with non-zero exit code while uploading files to blob storage.' For more info please refer to https://aka.ms/azurefilecopyreadme
Finishing:  Copy to test drop

@huangbolun AzureFileCopyV4 requires additional permissions
Refer this Doc
https://github.com/microsoft/azure-pipelines-tasks/tree/master/Tasks/AzureFileCopyV4#prerequisite-for-the-task

@AmrutaKawade, this is good to know.. Could you add this link to the Azure DevOps UX as well as OneBranch UX? From the interface I have no idea I need to ACL additional RBAC to the service principals/connections (, and apparently simply authorizing the service connection is not adding the Storage Blob Data Contributor role for me).
Azure DevOps UX:

OneBranch UX:

@AmrutaKawade, I am not an expert down the stack so I am not able to raise a PR. This is a usability gap or a legit bug.. To be clear the bug is like this:
Issue: When click on "Authorize" subscription in the Azure File Copy V4 task, it doesn't add Storage Blob Data Contributor for me; Hence, when using the task it throws unauthorized exception when copying to the storage account in the subscription;
Expected: When click on "Authorize" subscription in the Azure File Copy V4 task, it adds Storage Blob Data Contributor for me so that my task@v4 will not fail; Or otherwise, please document in the UX that we need to add addition RBAC for the service principal to the targeted storage account.


[TA] Fixes live test regression

There is a model change in Sept release as service team have moved to inference library and ORT 1.8. Regression is expected.
(1) For a specific test input: "Bonjour tout le monde." with language hint = "FR",  The expected result for keyPhraseExtraction used to be "monde" but returns "Bonjour" now.
(2) For a list of input:Bonjour tout le monde. // only "monde" is returned when languageCode=FR, now the response has additional key phrase, "Bonjour" which is more reasonal. andJe m'appelle Mondly. // used to return nothing but now returns "Mondly"
(3) for a input string, Microsoft employee with ssn 859-98-0987 is using our awesome API's.The return key phrase list used to be "Microsoft employee", "ssn", "awesome", "API"But now it is "Microsoft employee", "ssn", "awesome API"
Create an issue to revisit defaultLanguage() method: https://github.com/Azure/azure-sdk-for-java/issues/24183

/azp run java - textanalytics - tests

Curious, is it common in Java libraries to validate the content of the output (especially a string) from the service?
In .NET we've had conversations about drawing a line between when we are testing the service per se and when we are actually testing the library.

Good point, it depends, if in AppConfig, if a configuration setting (k, v) sent to service, we need to validate if the response setting match with input. But in text analytics, there might not be always the case.
Create an issue to revisit the test strategy: https://github.com/Azure/azure-sdk-for-java/issues/24186


[BUG]   Input data may contain inappropriate content. api error...

是否已有关于该错误的issue或讨论？ | Is there an existing issue / discussion for this?

[X] 我已经搜索过已有的issues和讨论 | I have searched the existing issues / discussions

该问题是否在FAQ中有解答？ | Is there an existing answer for this in FAQ?

[X] 我已经搜索过FAQ | I have searched FAQ

当前行为 | Current Behavior
when I give the input to it , it can not give me the answer, and  it says that "Input data may contain inappropriate content."
I use the
'status_code':
400
'request_id':
'17f9c41d-fbbd-9a78-a35e-e36dcb774c23'
'code':
'DataInspectionFailed'
'message':
'Input data may contain inappropriate content.'
期望行为 | Expected Behavior
No response
复现方法 | Steps To Reproduce
No response
运行环境 | Environment
- OS:
- Python:
- Transformers:
- PyTorch:
- CUDA (`python -c 'import torch; print(torch.version.cuda)'`):

备注 | Anything else?
No response

@jun0wanan Hi, what were you using?

I think you were using the DashScope API. DashScope is a product of Alibaba Cloud and please contact its official support. It is not covered in this project.
Here is what I have found though: https://help.aliyun.com/zh/dashscope/developer-reference/return-status-code-description

@jun0wanan Hi, what were you using?

你好，
所以这个问题是阿里云api的问题吗？
qwen-vl还有除了阿里云其他的api吗？

If you're working with Qwen-VL, kindly note that there are accessible models available at https://github.com/QwenLM/Qwen-VL. I would strongly recommend reaching out to them for guidance and support. Thank you for your collaboration.


Merge back release 0.11.2

Codecov Report

Merging #1107 into master will increase coverage by 2.77%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #1107      +/-   ##
==========================================
+ Coverage   46.14%   48.91%   +2.77%
==========================================
  Files         238      242       +4
  Lines       22243    21992     -251
  Branches     4998     4998
==========================================
+ Hits        10263    10758     +495
+ Misses      11980    11234     -746

Impacted Files
Coverage Δ

@here/harp-mapview/lib/MapView.ts
55.39% <75%> (-1.94%)
:arrow_down:

@here/harp-materials/lib/Utils.ts
20% <0%> (-80%)
:arrow_down:

...e/harp-datasource-protocol/lib/ThreeBufferUtils.ts
16.66% <0%> (-63.34%)
:arrow_down:

@here/harp-materials/lib/IconMaterial.ts
44.44% <0%> (-55.56%)
:arrow_down:

...rp-datasource-protocol/lib/StringEncodedNumeral.ts
62.06% <0%> (-32.72%)
:arrow_down:

@here/harp-map-controls/lib/Utils.ts
46.15% <0%> (-23.85%)
:arrow_down:

@here/harp-omv-datasource/lib/OmvTiler.ts
50% <0%> (-16.67%)
:arrow_down:

...rp-datasource-protocol/lib/InterpolatedProperty.ts
72.97% <0%> (-14.28%)
:arrow_down:

@here/harp-utils/lib/ObjectUtils.ts
83.33% <0%> (-10.22%)
:arrow_down:

@here/harp-mapview/lib/ScreenProjector.ts
71.42% <0%> (-9.06%)
:arrow_down:

... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfae429...dff002f. Read the comment docs.


Does not seem to be compatible with Tailwind 1.0+

Styles don't seem to work with tailwind 1.0+. Plugin was brought in via yarn.

What type of project are you using tailwind with? I've tried it with vue-cli 3 and nuxt and both seem to work fine with Tailwind v1


[SPARK-8924] [MLLIB, DOCUMENTATION] Added @since tags to mllib.tree

Added @since tags to mllib.tree

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Merged build triggered.

Merged build started.

Test build #37658 has started for   PR 7380 at commit fd7c005.

Test build #37658 has finished for   PR 7380 at commit fd7c005.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@manishamde @chouqin Could you make a pass?

@mengxr Sure. I can take a look.
How do we handle API modifications? Any change moves the tag to the newest version?

Yes, only the newest version counts.

@manishamde Could you make a pass?

LGTM apart from those minor comments

Merged build triggered.

Merged build started.

Thanks for taking a look @MechCoder
You mentioned we don't need tags for hashCode, equals and toString - I removed these and one tag for a toDebugString too.   I was also wondering if need tags for save/load?
cc @mengxr

It is good to keep tags for save / load (because it is useful to know when they were added for a particular model and all models since don't have a save / load option)

Test build #40795 has started for   PR 7380 at commit 1e24dc5.

Test build #40795 has finished for   PR 7380 at commit 1e24dc5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@BryanCutler We don't need since tags for hashCode, equals, and toString because they are inherited from Object, and hence have the same since version as the class itself.

Ok, that makes sense.  Tags on those are gone now.

@mengxr Sorry, did not get a chance to review this so far. Will try to do it today.

Apart from that minor comment, LGTM @mengxr
Thanks for the PR @BryanCutler . And @manishamde I took the liberty of reviewing the PR since you were busy. Hope you wouldn't mind.

Okay, I merged this into master and branch-1.5 so we can unblock SPARK-9864. @MechCoder Please fix the issue you found in your PR. Thanks @BryanCutler for adding versions and @MechCoder for review!


⚠ Bofrost.es has degraded performance

In 722e725, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1575 ms

Resolved: Bofrost.es performance has improved in 72f0236 after 6 minutes.


⚠ Bofrost.nl has degraded performance

In 5e7169c, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1016 ms

Resolved: Bofrost.nl performance has improved in edb5dfe.


Refactor qpu sampler params

@JoelPasvolsky: because sampling_params include all params that the final .sample() will accept.
sampler_params would be params used to construct the sampler alone. Not params passed down to the sample method.
Note that the sampler is (almost) never a QPU sampler alone. The embedding layer is included as well, even if it's thin.

:+1:


fix: retry failed messages for MonoVertex sink

let's add a retry-interval too?

I have added it to the config, but I guess we will have to add this to the mono vertex spec that way user can configure it. I will tackle that in a separate PR since it requires controller changes.


[core] Advise to use fbs=1

What does this PR do?
For many reasons, forward_batch_size>1 is not supported for seq2seq models and models that uses a tokenizer with padding_side="left"
As this may take some time before fixing, I propose to use forward_batch_size=1 for now and advice users to avoid using forward_batch_size>1 for now
cc @lvwerra

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Fix printing of private extensible variants

Fixes https://github.com/facebook/reason/issues/1101
Update: due to consistency with normal variants, all constructors will always break recursively, regardless of the amount of constructors & line length.
(https://github.com/facebook/reason/issues/1106)
Example:
type water = ..;

type water +=
  pri
  | Ocean;

type water +=
  pri
  | MineralWater
  | SpringWater
  | TapWater
  | TableWater;

Want to rebase this on master now? Thanks for doing this @IwanKaramazow. We really appreciate the fixes!

Rebased & pushed. Let's pray CI comes through.

Thank you @IwanKaramazow.
It's the many small improvements like this that create a high quality experience.

You can see that the 4.02.3 tests are failing on travis, but they are the expected failures. We should create a directory that's only ran for 4.03 or greater, don't you think?


Add missing fields in doc/API.md

ACK 627a60c -- don't know what this folder is about but looks legit

Lol been struggling for 20 minutes to push my fix to your branch. Anyways.
ACK a3659c4


Run sessions in more than one k8s namespace

Related to #1061
The notebook service should accept a list of namespaces when installed in the values file for helm. One of these will be marked as default.
Then most endpoints will require an optional "namespace" parameter. If this is not specified the default namespace from the helm chart is assumed. If it is defined then the requested namespace is used.
If the namespace is not in the list of predefined namespaces then fail.

Questions to be resolved during sprint planning:

do we enforce uniqueness of session names and sessions across all namespaces?
should we eliminate as much as possible passing the namespace as parameter in notebook service api endpoints or make it a deliberate choice users have to make?
should we just make it so that the notebook service always uses one single namespace but that single namespace can be different from where the notebook service (and the rest of renku) is deployed?


Same route different component

how to render different component base user role ?
example:
admin :
route: /test
component: admin-component
user :
route: /test
component: user-component

You could make a vue component (admin-component). Then add the admin-component in the user-component. And check if the user is an admin with v-if.

@maarteNNNN  i see... can i use it to asyncData ? so before the base load i already know what component is loaded

@paolog22 I'm pretty new to Nuxt, but normal Vue I would just make you admin-component
and in your user-component example in pug
v-if(userIsAdmin)
  admin-component

and for the javascript part
import AdminComponent from '~/components/admin-component.vue'

export default {
  components: {
    AdminComponent
  },
  methods: {
     userIsAdmin () {
        //check if the user is admin and return it
    }
}

If you really need asyncData, I'm not yet qualified to answer how as I'm just getting started.

got it thanks.

You can simplify your code by using dynamic components: https://vuejs.org/v2/guide/components.html#Dynamic-Components


Updated examples/cli/README.md for directory encryption/decryption docs

Hi @SethLK, 👋
Thanks for contribution, great work 🙌, but please make changes requested and we'll be ready to go. 😉


fix: reduce bundle size

Changed the build process to make babel helpers external to reduce code duplication in projects using vuex-map-fields.
Made rollup handle all the different outputs in one config file
Removed uglify-es and used rollup-plugin-terser instead
Removed redundant config in babel.config.js, rollup-plugin-babel already handles modules: false

@maoberlehner Should probably set corejs on @babel/preset-env so it includes polyfills

Coverage remained the same at 100.0% when pulling 93abd4266175c441b6fafa83014034d5a3d11089 on merceyz:bundle-size into fa5c480998e3591199eb614b56b82e849ccc35fc on maoberlehner:master.


Testing HB 1.7.0

Testing https://github.com/NixOS/nixpkgs/pull/280269

@vbgl I do not understand the failure of Interval on Coq 8.10: the configure script there complains about missing bignums and indeed if I do
% nix-shell -A coqPackages_8_10.interval
[nix-shell:~/git/nixpkgs]$ coqtop
Welcome to Coq 8.10.2 (December 2023)

Coq < Require Import Bignums.BigZ.BigZ.
Error: while loading
/nix/store/mvzg7ndixzdd2cp498b1aar7kz0w8iry-coq8.10-bignums-8.10.0/lib/coq/8.10/user-contrib/Bignums/bignums_syntax_plugin.cmxs:
implementation mismatch on Notation

a git bisect points out to https://github.com/nixOS/nixpkgs/pull/277847 which doesn't make much sense to me (the version of interval (4.5.2) does not even depend on gnuplot)

@CohenCyril CoqEAL is broken on Coq 8.18 with MC2, feel free to remove it, the bug is fixed upstream, I just need to do a release.
Remains trakt that broke on Coq 8.18, looks like we cannot have both trakt and HB 1.7.0 on Coq 8.18, I'm in favor of removing trakt on Coq 8.18.

Apparently Trakt it breaking with Elpi 2.0.0 because
(cf https://github.com/coq-community/coq-nix-toolbox/actions/runs/7488698603/job/20384374998)
File "./theories/Commands.v", line 22, characters 0-50:
Error: The syntax 'Elpi Accumulate File "path" From logpath' is deprecated,
use 'From logpath Extra Dependency "path" as name. Elpi Accumulate File
name.' [elpi.accumulate-syntax,elpi.deprecated,deprecated,elpi,default]

Note that 3. only need to be done for 8.18. Also note that trakt only compiles with 8.18 by luck, in fact the OPAM package even reads Coq < 8.16~

Trakt is indeed pretty easy to adapt https://github.com/ecranceMERCE/trakt/pull/8 but this may take time (the PR needs to be merged then a release has to be done), so for now I'd vote for the following strategy:

now: remove trakt from the 8.18 bundle
later: if the upstream PR get merged and a release is done, then readd it

Cannot reproduce the interval failure with Coq 8.10. See: https://github.com/NixOS/nixpkgs/pull/280269/checks?check_run_id=20393115390

Cannot reproduce the interval failure with Coq 8.10. See: https://github.com/NixOS/nixpkgs/pull/280269/checks?check_run_id=20393115390

Strange ... the error happened again:
https://github.com/coq-community/coq-nix-toolbox/actions/runs/7492009181/job/20395819044?pr=192

The only explanation I can see is some cachix coherency isue but I have no idea how to clear the cache. Maybe @Zimmi48 would have an idea?
In any case, I agree it's unrelated to the current PR as I was able to reproduce it with older commits of nixpkgs.

The only explanation I can see is some cachix coherency isue but I have no idea how to clear the cache. Maybe @Zimmi48 would have an idea?
In any case, I agree it's unrelated to the current PR as I was able to reproduce it with older commits of nixpkgs.

There is no clearing of cachix caches... However you can remove your own use of a cache (in this case coq-community) for the sake of the experiment... I do not have the time to try this now, but it would be worth it.
My fear is that this is not the problem, but I still don't see what the **** it could be right now...

I could reproduce the failure after running cachix use coq-community…

I could reproduce the failure after running cachix use coq-community…

That's good news! Thanks!

@proux01 it's my fault I forgot to make this PR a draft, but it is pointing to my fork of nixpkgs rather than master, I will fix asap

@CohenCyril CoqEAL is broken on Coq 8.18 with MC2, feel free to remove it, the bug is fixed upstream, I just need to do a release.

Also it seems I forgot to remove CoqEAL :confounded:

@proux01 it's my fault I forgot to make this PR a draft, but it is pointing to my fork of nixpkgs rather than master, I will fix asap

I did update to master.

Also it seems I forgot to remove CoqEAL

Indeed but hopefully, we'll release it soon.


queue_processors.SignupWorker: Upgrade to MailChimp API v3.0.

Removes the dependence on postmonkey, which is a wrapper around
MailChimp API v1.3. MailChimp recommends using their v3.0 API directly,
rather than through a wrapper library.

Automated message from Dropbox CLA bot
@rishig, it looks like you've already signed the Dropbox CLA. Thanks!

script can be run with
./manage.py add_users_to_mailing_list --optin-time '2016-08-14T00:00:00+00:00'
(= 5pm on Saturday, Aug 13 Pacific Time; maybe bumping it up by a few hours is more accurate.)

Merged!

Note that I changed the commit message to be clear that's it more generically useful than just for zulipchat.com.


[WIP] Refactor secret deployment to use ShootState

What this PR does / why we need it:
This PR is part of the Control Plane Migration
Refactors the deploy secrets step and splits it into 2 parts.

The first one will generate secrets which have to be saved in the ShootState resource so that they can be used for migration at a later point.
The second part uses the saved secret data in the ShootState resource to generate secret objects and deploy them in the Shoot's control plane
An additional temporary step is used to first load already existing secrets in the Shoot's control plane to the ShootState so that they do not get regenerated.

Which issue(s) this PR fixes:
Part of #1631
Special notes for your reviewer:
The ETCD encryption secret will be done in a separate PR.
Release note:

Refactored Shoot control plane secret generation and deployment logic so that secrets which are required to be persisted for control plane migration are saved in the ShootState resource.

Closing this PR as I will split it in a couple of smaller PRs with different implementation


Target vs Actuals IPTT: Midline and Endline periods are showing date ranges

To reproduce the behavior, run a Target vs Actuals IPTT on a program with Midline/Endline targets. Here's what I'm seeing:

Expected behavior: Because Midline/Endlines are not time-aware, we don't want to be displaying a date range under the column headers "Midline" and "Endline".

Validated that the date ranges are no longer showing for Midline/Endline IPTTs. Looks good in all 3 languages and exports as expected.
All other target frequencies look fine as far as column headers go.


feat(configs): let users create new configs

Closes #73
Signed-off-by: Lukas Mertens<EMAIL_ADDRESS>
Stack:

#164
#161
#160
#154
#153
#140
#139
#138
#136
#148
#135
#147
#134
#132
#129
#130
#128 ⬅
#127
#126
#125
#146

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

✓ Commit merged in pull request #164


dialogflow heartbeat/ping using SDK

Is there a way to check if my app is able to talk to dialogflow agent using java SDK? (https://github.com/GoogleCloudPlatform/google-cloud-java/tree/master/google-cloud-dialogflow)
The purpose is just to verify the credentials are working and connectivity is working when I deploy my application, before actual traffic flows in.
One way I can think of is make a intent-request itself which is not a good solution in my opinion; I wrote something as below (in clojure using java sdk)
(defn heartbeat [{nlu-agent :nlu-agent utterance :utterance creds-file :creds-file}]
  (try
    (send-intent-request
     {:nlu-agent  nlu-agent
      :utterance  utterance
      :creds-file creds-file})
    "success"
    (catch Throwable e
      (.getMessage e))))

And obviously I'm using credentials.json provided my gcloud which looks as below (taken from https://cloud.google.com/video-intelligence/docs/common/auth#authenticating_with_application_default_credentials);
{
  "type": "service_account",
  "project_id": "project-id",
  "private_key_id": "some_number",
  "private_key": "-----BEGIN PRIVATE KEY-----\n....
  =\n-----END PRIVATE KEY-----\n",
  "client_email"<EMAIL_ADDRESS>  "client_id": "...",
  "auth_uri": "https://accounts.google.com/o/oauth2/auth",
  "token_uri": "https://accounts.google.com/o/oauth2/token",
  "auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs",
  "client_x509_cert_url": "https://www.googleapis.com/...<api-name>api%40project-id.iam.gserviceaccount.com"
}

But don't want to send actual intent-requests in PROD every minute just for the sake of heartbeat.
I had same question in another place too but this seems a right place to ask questions - https://github.com/dialogflow/dialogflow-java-client-v2/issues/14

Are you changing your credentials all the time?
It seems unnecessary to try and verify that your credentials are continuing to work. This would be the case for any resource on any API - you shouldn't need to check to see if your credentials work every time before making the API calls.


Decrease reliance on yq

Any use of yq should be compact, general and well-documented. It should not be used to apply name-based modifications which can be handled by sheets_and_friends' modifications_and_validation script.
Currently, the validation updates specified by the --validation_config_tsv argument are only triggered when detecting

specified slot ranges
specified slot string_serializations

and only take these actions:

overwriting a slot's pattern
overwriting a slot's DH datatype... which is just a type range as an xsd CURIE?

I don't think the DH datatype changes are necessary any more, as class ranges are generally replaced by the yq operations, and DH seems to understand the range specifications that consist of a linkml:type in name alone.
I would like to continue using yq for these general validation updates, or add additional trigger types to modifications_and_validation.
cc @pkalita-lbl

Does this relate to https://github.com/microbiomedata/nmdc-schema/issues/1846 ??
@sierra-moxon


address or components parameter is require to submit a geocode request

Required parameters in a geocoding request:

address — The street address that you want to geocode, in the format used by the national postal service of the country concerned. Additional address elements such as business names and unit, suite or floor numbers should be avoided. Please refer to the FAQ for additional guidance.
     or
components — A component filter for which you wish to obtain a geocode. See Component Filtering for more information. The components filter will also be accepted as an optional parameter if an address is provided.

publish under npm version 1.8.0


py setup test causes gdbm related error

This occurred on both my laptop and the raspberry pi, both of which have ubuntu 16.04 installed and I had to manually upgrade python3 using this tutorial
ubuntu@roverrobotics:~$ py setup test
Traceback (most recent call last):
  File "/usr/lib/python3.6/dbm/gnu.py", line 4, in <module>
    from _gdbm import *
ModuleNotFoundError: No module named '_gdbm'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/CommandNotFound/CommandNotFound.py", line 7, in <module>
    import dbm.gnu as gdbm
  File "/usr/lib/python3.6/dbm/gnu.py", line 6, in <module>
    raise ImportError(str(msg) + ', please install the python3-gdbm package')
ImportError: No module named '_gdbm', please install the python3-gdbm package

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/command-not-found", line 27, in <module>
    from CommandNotFound.util import crash_guard
  File "/usr/lib/python3/dist-packages/CommandNotFound/__init__.py", line 3, in <module>
    from CommandNotFound.CommandNotFound import CommandNotFound
  File "/usr/lib/python3/dist-packages/CommandNotFound/CommandNotFound.py", line 9, in <module>
    import gdbm
ModuleNotFoundError: No module named 'gdbm'

Closing this as user error. I have no idea why it was searching for gdbm, and the correct way to install this package is with pip. Also, the command py setup test is looking for a file named setup where the setup file is setup.py


Road Map For Spring Cloud Releases?

Is it possible to bump the spring boot dependency on spring cloud to 1.3.3?
We are running into this issue in logback:  http://jira.qos.ch/browse/LOGBACK-730
Spring Boot 1.3.3 depends on logback 1.1.5 (Bug is fixed)
Spring Boot 1.3.2 depends on logback 1.1.3 (where this bug manifests)
For now, we are just overriding the logback dependency in our pom file, but it would be nice to have this in the core once Brixon becomes final.
Is there an updated roadmap for spring cloud releases?

https://github.com/spring-cloud/spring-cloud-build/blob/master/pom.xml
I believe this is already done in Brixton. Are you seeing otherwise?

We are still on Brixton.M5 and I hadn't look on the master branch. It would be very helpful to have a roadmap page that tracks the releases (and future releases of Spring Cloud and its dependent version of Spring Boot).

Is there any sort of time frame or road map for the Spring Cloud releases? We are currently using Brixton.M5 in a production level setting and that feels a bit risky. It would be nice to know when Brixton will become the "official" release.

We've been waiting on spring-cloud-stream which just released RC1 today. We will finish RC1 today or tomorrow. Then a few weeks of bug fixes. Nothing is set in stone though.


Unmatched versions between readthedocs and Github

Today I was following this tutorial and run into an issue when following the steps on https://fiware-tutorials.readthedocs.io/en/latest/big-data-analysis/index.html rather than the ones on this github page.

orion.flink.connector-1.2.1.jar was upgraded to orion.flink.connector-1.2.3.jar
There are a couple of typos on the Logger subscription to context changes. Missing " and } at the end of the payload.
curl -iX POST
'http://localhost:1026/v2/subscriptions'
-H 'Content-Type: application/json'
-H 'fiware-service: openiot'
-H 'fiware-servicepath: /'
-d '{
"description": "Notify Flink of all context changes",
"subject": {
"entities": [
{
"idPattern": ".*"
}
]
},
"notification": {
"http": {
"url": "http://jobmanager:9001" <------
}
} <-------
}'

Corrected typo in docs: https://github.com/FIWARE/tutorials.Step-by-Step/commit/987ff1524adb262ddd5ccc35bfee4fd1aa23cb2f


Automatically add "S-waiting-on-deploy" tag on a merged PR

I used this action to add the tag. The only extra thing needed is to create a token. For which event to used, I used github docs.

I don't think creating a token should be needed, there is an auto-generated token per GHA run that should have the required permissions (since this is running on this repo after the PR gets merged).

I wasn't sure about that but if you think we don't need to add a token, then I guess it's ready to be tested. :)

I updated the action to remove the "S-waiting-*" labels as well.

@GuillaumeGomez after merging I saw it failing.
It seems like the default token in actions only has readonly permissions when the action is being triggered by a fork.
I didn't dig deeper on this, in the end the people merging PRs also have write-permissions, so the action should be fine...


Desgin gallery

Can create a gallery where customers can explore  more desgins

hey @Vanshika1703
Can you elaborate on your idea? and provide some reference images of how the gallery will look like.

@Vanshika1703

I understand what has to be done here, so assign me this issue under GSSOC'23

I understand what has to be done here, so assign me this issue under GSSOC'23

Hey @kunal-2002
Can you elaborate on what are you planning to do ??


Fixed typo in a JSDoc comment.

Thanks for the heads up @googlebot, I've signed it now

Thank you, @jonathanp! Good catch :D Merging


Magic Item Savant

Magic Item Savant

At 14th level, your skill with magic items deepens more:

    You can attune to up to five magic items at once.

    You ignore all class, race, spell and level requirements on attuning to or using a magic item.

Useless in BG3.
Thinking about the impact many attuned items might have in a campaign I'd say +1 AC if you got a magic armor and +1 attack roll and damage rolls (as well as spell damage rolls) if you're wielding a magic weapon.

uhm nope, seems no armor in the game got the magical property

It could give special effects when using magical items that are race restricted. There are plenty of items that has extra effects when used by Githyanki and at least one gloves that work only on Dwarves, Halflings and Goneomes.

I think that would require redefining those magical items or adding race tags to artificer, which would cause trouble indialogues.

Might be more effort than worth it.

Only thing I can think of is to give a +1 to spell damage and a +1 to weapon attack if you have a magic weapon equipped.
To appeal to both playstyles.

we could add an optional file for the  "You ignore all class, race, spell and level requirements on attuning to or using a magic item" effect where we override original game items/boosts

this one only misses the optional addon that overwrites race specific items. Will be done at the very end.

I also just had a flash of genius of a way to implement magic item savant without replacing all items with racial features
we could probably just add a passive that checks if the item X is equipped and just gives a copy of the effect if the tag is missing from the character, like "has gith sword equipped and not tagged gith -> give the same effect the item would have given"


event request - report 297 "Batch Post Sales Invoices" - OnPreDataItem() - OnBeforeRunBatch(var SalesBatchPostMgt)

We have a need to call SalesBatchPostMgt.SetPostingCodeunitId() on the instance of codeunit 1371 "Sales Batch Post Mgt." called by this report, but there's nowhere to do that.
Please add this event publisher:
        trigger OnPreDataItem()
        var
            SalesBatchPostMgt: Codeunit "Sales Batch Post Mgt.";
        begin
            SalesBatchPostMgt.SetParameter("Batch Posting Parameter Type"::Print, PrintDoc);

            OnBeforeRunBatch(SalesBatchPostMgt); // <- NEW and COOL

            SalesBatchPostMgt.RunBatch("Sales Header", ReplacePostingDate, PostingDateReq, ReplaceDocumentDate, CalcInvDisc, false, true);

            CurrReport.Break();
        end;

declared like so:
[IntegrationEvent(false, false)]
local procedure OnBeforeRunBatch(var SalesBatchPostMgt);

We can then subscribe to that and set the posting codeunit ID. (Somehow... I didn't figure out a method yet. It'll probably involve global variables somehow, till we get report exts! Anyway, this is one piece of the puzzle that seems required.)
Thanks!

Hi @dtkb .
I have another suggestion for you. There is event (below) in "Sales Batch Post Mgt." codeunit, not so new but also cool. I can set IncludeSender = true there and then you will be able to set posting codeunit Id there. Or make some other actions. Does it fit for you?
[IntegrationEvent(false, false)]
    local procedure OnBeforeRunBatch(var SalesHeader: Record "Sales Header";var ReplacePostingDate: Boolean; PostingDate: Date; ReplaceDocumentDate: Boolean; Ship: Boolean; Invoice: Boolean)
    begin
    end;

Hi @RomanZanizdra and thanks! I didn't realise the event you mentioned existed; I've been referring to source for BC 17.3 that I have lying around, which is obviously getting a bit old... So what you said sounds fine, if it'll let us achieve the same possibilities, and putting the event in the codeunit seems better and more widely useful than putting it just in the one report. Cheers!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


[Widget Tests] - Key character resolution is broken on iOS

In widget tests, when simulating key presses that correspond to characters, the iOS character resolution is broken.
I'll illustrate this with two tests - one that shows the issues with iOS, and one that shows no such issues with Android.
Bug Repro:
testWidgets("bug repro", (widgetTester) async {
      debugDefaultTargetPlatformOverride = TargetPlatform.linux;

      await widgetTester.pumpWidget(
        MaterialApp(
          home: Scaffold(
            body: Focus(
              onKey: (FocusNode node, RawKeyEvent keyEvent) {
                print("Key event");
                print("$keyEvent");
                print("Character ${keyEvent.character}");
                print("");

                return KeyEventResult.ignored;
              },
              autofocus: true,
              child: const SizedBox.expand(),
            ),
          ),
        ),
      );

      await widgetTester.sendKeyDownEvent(LogicalKeyboardKey.shift, platform: "ios");

      await widgetTester.sendKeyDownEvent(LogicalKeyboardKey.keyG, platform: "ios", character: "G");
      await widgetTester.sendKeyUpEvent(LogicalKeyboardKey.keyG, platform: "ios");

      await widgetTester.sendKeyUpEvent(LogicalKeyboardKey.shift, platform: "ios");

      debugDefaultTargetPlatformOverride = null;
    });

Bug repro output - notice that there's never a "G" character reported:
Key event
RawKeyDownEvent#3b0d6(logicalKey: LogicalKeyboardKey#df100(keyId: "0x200000102", keyLabel: "Shift Left", debugName: "Shift Left"), physicalKey: PhysicalKeyboardKey#ed430(usbHidUsage: "0x000700e1", debugName: "Shift Left"), repeat: false)
Character null

Key event
RawKeyDownEvent#55276(logicalKey: LogicalKeyboardKey#c9177(keyId: "0x00000047", keyLabel: "G", debugName: "Key G"), physicalKey: PhysicalKeyboardKey#8c52b(usbHidUsage: "0x0007000a", debugName: "Key G"), repeat: false)
Character null

Key event
RawKeyUpEvent#a5680(logicalKey: LogicalKeyboardKey#23b97(keyId: "0x00000067", keyLabel: "G", debugName: "Key G"), physicalKey: PhysicalKeyboardKey#8c52b(usbHidUsage: "0x0007000a", debugName: "Key G"))
Character null

Key event
RawKeyUpEvent#8f6fc(logicalKey: LogicalKeyboardKey#df100(keyId: "0x200000102", keyLabel: "Shift Left", debugName: "Shift Left"), physicalKey: PhysicalKeyboardKey#ed430(usbHidUsage: "0x000700e1", debugName: "Shift Left"))
Character null

Here's the same test except using "android" as the simulated platform:
testWidgets("bug counter example", (widgetTester) async {
      debugDefaultTargetPlatformOverride = TargetPlatform.linux;

      await widgetTester.pumpWidget(
        MaterialApp(
          home: Scaffold(
            body: Focus(
              onKey: (FocusNode node, RawKeyEvent keyEvent) {
                print("Key event");
                print("$keyEvent");
                print("Character ${keyEvent.character}");
                print("");

                return KeyEventResult.ignored;
              },
              autofocus: true,
              child: const SizedBox.expand(),
            ),
          ),
        ),
      );

      await widgetTester.sendKeyDownEvent(LogicalKeyboardKey.shift, platform: "android");

      await widgetTester.sendKeyDownEvent(LogicalKeyboardKey.keyG, platform: "android", character: "G");
      await widgetTester.sendKeyUpEvent(LogicalKeyboardKey.keyG, platform: "android");

      await widgetTester.sendKeyUpEvent(LogicalKeyboardKey.shift, platform: "android");

      debugDefaultTargetPlatformOverride = null;
    });

Here's the output that shows things work as expected on Android:
Key event
RawKeyDownEvent#fcd4b(logicalKey: LogicalKeyboardKey#df100(keyId: "0x200000102", keyLabel: "Shift Left", debugName: "Shift Left"), physicalKey: PhysicalKeyboardKey#ed430(usbHidUsage: "0x000700e1", debugName: "Shift Left"), repeat: false)
Character null

Key event
RawKeyDownEvent#e570e(logicalKey: LogicalKeyboardKey#23b97(keyId: "0x00000067", keyLabel: "G", debugName: "Key G"), physicalKey: PhysicalKeyboardKey#8c52b(usbHidUsage: "0x0007000a", debugName: "Key G"), repeat: false)
Character G

Key event
RawKeyUpEvent#2a444(logicalKey: LogicalKeyboardKey#23b97(keyId: "0x00000067", keyLabel: "G", debugName: "Key G"), physicalKey: PhysicalKeyboardKey#8c52b(usbHidUsage: "0x0007000a", debugName: "Key G"))
Character null

Key event
RawKeyUpEvent#c6b9c(logicalKey: LogicalKeyboardKey#df100(keyId: "0x200000102", keyLabel: "Shift Left", debugName: "Shift Left"), physicalKey: PhysicalKeyboardKey#ed430(usbHidUsage: "0x000700e1", debugName: "Shift Left"))
Character null

Reproducible using the code sample provided above.

full sample
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  testWidgets("bug repro", (widgetTester) async {
    debugDefaultTargetPlatformOverride = TargetPlatform.linux;

    await widgetTester.pumpWidget(
      MaterialApp(
        home: Scaffold(
          body: Focus(
            onKey: (FocusNode node, RawKeyEvent keyEvent) {
              print("Key event");
              print("$keyEvent");
              print("Character ${keyEvent.character}");
              print("");

              return KeyEventResult.ignored;
            },
            autofocus: true,
            child: const SizedBox.expand(),
          ),
        ),
      ),
    );

    await widgetTester.sendKeyDownEvent(LogicalKeyboardKey.shift, platform: "ios");

    await widgetTester.sendKeyDownEvent(LogicalKeyboardKey.keyG, platform: "ios", character: "G");
    await widgetTester.sendKeyUpEvent(LogicalKeyboardKey.keyG, platform: "ios");

    await widgetTester.sendKeyUpEvent(LogicalKeyboardKey.shift, platform: "ios");

    debugDefaultTargetPlatformOverride = null;
  });

  testWidgets("bug counter example", (widgetTester) async {
      debugDefaultTargetPlatformOverride = TargetPlatform.linux;

      await widgetTester.pumpWidget(
        MaterialApp(
          home: Scaffold(
            body: Focus(
              onKey: (FocusNode node, RawKeyEvent keyEvent) {
                print("Key event");
                print("$keyEvent");
                print("Character ${keyEvent.character}");
                print("");

                return KeyEventResult.ignored;
              },
              autofocus: true,
              child: const SizedBox.expand(),
            ),
          ),
        ),
      );

      await widgetTester.sendKeyDownEvent(LogicalKeyboardKey.shift, platform: "android");

      await widgetTester.sendKeyDownEvent(LogicalKeyboardKey.keyG, platform: "android", character: "G");
      await widgetTester.sendKeyUpEvent(LogicalKeyboardKey.keyG, platform: "android");

      await widgetTester.sendKeyUpEvent(LogicalKeyboardKey.shift, platform: "android");

      debugDefaultTargetPlatformOverride = null;
    });
}

flutter doctor -v
[!] Flutter (Channel stable, 3.13.2, on macOS 13.4.1 22F770820d darwin-arm64, locale en-GB)
    • Flutter version 3.13.2 on channel stable at /Users/nexus/dev/sdks/flutter
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutters/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutter. Consider adding /Users/nexus/dev/sdks/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutters/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutter. Consider adding /Users/nexus/dev/sdks/flutter/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ff5b5b5fa6 (11 days ago), 2023-08-24 08:12:28 -0500
    • Engine revision b20183e040
    • Dart version 3.1.0
    • DevTools version 2.25.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/223.8836.35.2231.10406996/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode-14.3.0.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/223.8836.35.2231.10406996/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.1)
    • IntelliJ at /Users/nexus/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 75.1.4
    • Dart plugin version 232.9559.10

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/232.8660.185/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.1)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/232.9559.62/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.81.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.70.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.4.1 22F770820d darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 116.0.5845.140

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 3.14.0-14.0.pre.93, on macOS 13.4.1 22F770820d darwin-arm64, locale en-GB)
    • Flutter version 3.14.0-14.0.pre.93 on channel master at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ef9befc9da (17 hours ago), 2023-09-03 11:23:20 -0700
    • Engine revision fbc6f4a540
    • Dart version 3.2.0 (build 3.2.0-131.0.dev)
    • DevTools version 2.27.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/223.8836.35.2231.10406996/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode-14.3.0.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/223.8836.35.2231.10406996/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/232.8660.185/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.1)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/232.9559.62/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.81.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.70.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.4.1 22F770820d darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 116.0.5845.140

[✓] Network resources
    • All expected network resources are available.

• No issues found!

/cc @Renzo-Olivares


Copying project:delete command copies the raw environment variable name

To reduce the noise here and highlight that commands are easy to remember, we could simply remove the project ID from the command. It's fairly low risk as the user will be prompted to select the project they want to delete if they do not provide one. Additionally, if the command is run from within the project directory, the command will default to the current project.

Will be resolved and closed by #45


[FEATURE] sap.ui.demokit.Explored: Migrate all texts to resource bundle

Not all text could be translated. Relevant texts have now been migrated to use the resource bundle.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @bawder
Thank you for your pull request. I contacted responsible developer and we will keep you in informed about the progress.
Regards,
Diana

Hello @bawder
Not all committers have signed the CLA. Jonathan Dawber should assign the CLA in order to continue the process.
Regards,
Diana

Sorted


Move VolumeDriver to HostConfig to make containers portable.

Fixes #15342
/cc @cpuguy83
Signed-off-by: David Calavera<EMAIL_ADDRESS>

lint errors on missing comments for new exported types.

Definitely a +1 from me since I created the issue :)

Yup, +1 from me for changing this. Don't forget to update the docs and man-pages if this moves further.

Should this require backwards compat or should this part of 1.8.2 and thus modify the current API?

My thought is make it part of 1.8.x.

I'm +1 to making it part of 1.8.x, regarding it a "fix" and to reduce the exposure (yes, it's awkward doing an API change in a dot-release, but we should try to avoid people starting to rely on this)

@cpuguy83, @thaJeztah I'm neutral, but this change is completely backwards compatible. Containers started VolumeDriver in the config still work as expected if stopped and started with this new code.

@calavera Oh yes, makes sense. We have to support already created containers here.

I still see VolumeDriver showing up in the inspect output and not in HostConfig.
It does work, though, as VolumeDriver which was committed to the image is not used by a container created from that image.

@cpuguy83 version numbers are hard! I'm going to add some tests for the inspect output.

I've added a couple of integration tests to prevent regressions. It turned out that I left the field in the config inspect for the next version of docker :pensive:

LGTM

I've rebased this. Please, take a look.

If I understand correctly, this design still only allows one VolumeDriver per container.  What happens if you want to mount one volume using Flocker and one using Convoy?

@bboreham Need to use docker volume create, then bind that volume in using the name.

@calavera external volume tests are failing.

@bboreham using the new volume API, this should work;
docker run -d \
   -v $(docker volume create --driver=foo):/volume-a/ \
   -v $(docker volume create --driver=bar):/volume-b/ \
   my-image

Ah, right, thanks.  Wasn't clear from https://docs.docker.com/extend/plugins_volume/

@bboreham it's not released yet; the volume create command will be in the next release (docker 1.9), but you can experiment with it, by downloading a binary from https://master.dockerproject.org (there are still some bugs, so tread carefully)

@calavera volume test are failing after rerunning the tests.

@crosbymichael I don't know what happened with those tests, but it looks like it's passing now.

LGTM

LGTM


update osfmount manifest to 3.1.1002.0

changed 3.1.1001.0 to 3.1.1002.0 and fixed hash, since site does not offer old downloads making old manifests useless

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/azp run


Networking: Add AutoNAT and NAT Traversal

Summary
Problem
We filter out private addresses because they are unreachable on the public Internet. This means Homestar behind a NAT or VPN are not reachable.
Impact
Limits where you can run a Homestar node.
Solution
Add AutoNAT behavior to probe for externally reachable addresses: https://libp2p.github.io/rust-libp2p/libp2p/autonat/index.html. If we cannot reach the node, it is behind a NAT.
We still want to connect to nodes that are behind a NAT. We can attempt hole punching using DCUtR or use circuit relay as a fallback when hole punching fails.
Tasks

[ ] Add AutoNAT behavior
[ ] Add circuit relay
[ ] Add DCUtR and integrate with circuit relay fallback

Adding some design notes for how the pieces fit together.

Our goal is to improve connectivity in Homestar by implementing libp2p AutoNAT, Circuit Relay, and DCUtR hole punching.
Homestar supports a few types of connections today:

Public to public connections
Private to public connections

We would like to extend this to include private to private connections. These connections can be made through relay or directly after hole punching.
AutoNAT
The first step is to determine whether a node is publicly reachable. If a node is publicly reachable, we can make a direct connection without a relay or NAT traversal. In general, this applies to nodes on the public Internet, but some routers may be configured to pass traffic directly to a private node.
If a node cannot be be reached publicly, it is a private node and we need relay or hole punching.
Circuit Relay
Relay is the easiest and most reliable way to get traffic from one private node to another, but may result in low-bandwith, high-latency connections.
DCUtR/Hole punching
We would like to establish a direct connection between private nodes, traversing NATs where possible. This gives us a faster connection with less load on the relay server.
Note that this won't always work out. Trautwein reports a 70-80% success rate for NAT hole punching in libp2p: https://www.youtube.com/watch?v=bzL7Y1wYth8. When we are unable to traverse NATs, we will fall back to circuit relay.
Note that hole punching is generally considered unreliable. For example, the Iroh Hole Punching write up mentions their goal as:

Get as close to 100% connection rate as possible (even if that means falling back to a relayed connection)

The Tailscale NAT Traversal post mentions:

This is a good time to have the awkward part of our chat: what happens when we empty our entire bag of tricks, and we still can’t get through? A lot of NAT traversal code out there gives up and declares connectivity impossible. That’s obviously not acceptable for us; Tailscale is nothing without the connectivity.
We could use a relay that both sides can talk to unimpeded, and have it shuffle packets back and forth. But wait, isn’t that terrible?
Sort of. It’s certainly not as good as a direct connection, but if the relay is “near enough” to the network path your direct connection would have taken, and has enough bandwidth, the impact on your connection quality isn’t huge. There will be a bit more latency, maybe less bandwidth. That’s still much better than no connection at all, which is where we were heading


Error connecting to ws://localhost:9012. Please reload the page.

Hi, when execute  ./scripts/run-wokwi.sh debug  in devcontainer is result open the follow url: https://wokwi.com/_alpha/wembed/xxxxxxxx?partner=espressif&port=9012&data=demo but the page not work.
The error is: Error connecting to ws://localhost:9012. Please reload the page.
Please help me!.

Thank you.

Hi!
Just gave a quick try to simulate the default project template with both the dockerhub image (had to install wokwi-server) and building it from the Dockerfile, and had no issues. Could you elaborate on a few ends?

Are you running the devcontainer using the dockerhub image or building it from the Dockerfile?
What are you using as WOKWI_PROJECT_ID?
Have you tried to simulate the template project with no changes?
I assume you are using VsCode, can you check the PORTS tab of VsCode?

Hi @SergioGasquez .
I was again run the project and it is ok.
Thank you.


arbitrary spacing change to check i have permissions

looks like i don't actually have permissions to update this project
i could fork it, make my changes and send you pull requests or you could alter permissions

@christopheralcock Please fork it :)