Installation is very poor

Hi, I have follow
http://mvc-grid.azurewebsites.net/Home/Installation
but does not work. I want to use AjaxGrid. I have added $('.mvc-grid').mvcgrid(); but I still get
Uncaught TypeError: $(...).mvcgrid is not a function
I think some class "mvc-grid" is missing somewhere?
What about paging HTML, default grid HTML. How to configure it, etc
Documentation how to install and configure is very poor. I am still on jquery 2.x

but does not work. I want to use AjaxGrid. I have added $('.mvc-grid').mvcgrid(); but I still get
Uncaught TypeError: $(...).mvcgrid is not a function

Installation point 3 Include grid scripts after jQuery scripts., that way .mvcgrid will be recognized.

I think some class "mvc-grid" is missing somewhere?

Installation point 1 installs all the needed grid partials which contains .mvc-grid classes.
So rendering any grid with @Html.Grid(Model)... as shown in all usage examples will render the html.

What about paging HTML, default grid HTML. How to configure it, etc

Installation page only show how to configure the project, all the other pages contains the examples.

Documentation how to install and configure is very poor. I am still on jquery 2.x

Not knowing the framework in which you are using the library doesn't mean that the library's documentation is poor.

I did exactly the same
"Installation point 3 Include grid scripts after jQuery scripts., that way .mvcgrid will be recognized."
I am using jquery2 and I have added grid scripts after it but I still get this errors

Do you call $('.mvc-grid').mvcgrid(); after jquery and grid scripts?

I have the same problem.
I followed the tutorial in the same way.
I am using asp.net core 2.1, NonFactors.Grid.Core.Mvc6 of NuGet and the references to the files I have downloaded GitHub and added manually, since this version does not bring them

I solved the error, I had installed NonFactors.Grid.Core.Mvc6 and manually added the references to the .chtml, .css and .js files downloaded from GitHub, because initially when I used NonFactors.Grid.Mvc6 the project did not solve the correct references to asp.net core 2.1.
But I deleted everything and added the version to NonFactors.Grid.Mvc6 again and it worked perfectly, of course following the installation steps of the documentation.
Nothing but VS and its package versioning conflicts.
Good component, 100% recommended!
My only observation is that it would be good to be able to handle the text strings, externally in the case, such as my project, to work on internationalization.

Grid already supports localization, did you find any strings which can't be changed?

Where can I find the documentation about the localization?

I have already found it, thanks

On official page.


Not playing well with 'dictionary-it'

Hey!
Love the library, been really helpful in solving an issue we had. We have this repo successfully working with 'dictionary-en-gb', 'dictionary-fr', and 'dictionary-de'. However, we also need to use 'dictionary-it'.
The Italian dictionary callback gets called (their repo loads the files into memory) but when I pass it into nspell It hangs and eventually crashes because it ran out of memory.
const nspell = require("nspell");
const dict = require('dictionary-it');

dict((err, cb) => {
  // we get here, cb is an obj containing 'aff' and 'dic'.
  const data = nspell(cb);
  // we never get to the cb below, cpu and memory usage spike
  console.log(data);
})

I even tried upping the default memory allowance in node (via --max_old_space_size=2048)  but that just causes it to indefinitely hang.
Note: if I load just the 'aff' file and not the 'dic' file it gets to the console.log, but the dic file seems to be causing issues.
Could this be because the Italian dictionary is simply too big? Although running on a 2.5 GHz Intel Core i7 with 16gb of ram it should load eventually.
I'd love some help debugging the problem if possible!

Wow, thanks the the insanely fast response! I've done just that, and have gotten in a little deeper. I'm not entirely sure whats going on so it makes this very difficult, but one thing I've noticed about Italian as opposed to German/French/English is that it makes it to line 91 of ./lib/util/dictionary much more frequently. In German, the "otherNewWords" variable is typically 3 items max, whereas in Italian I only processed about a 10th of the file and the "otherNewWords" (as shown below) was already very large. I believe this is whats causing the memory issues, as it's required to loop over every item in this array every time.
line 91 called abbandonare 15 26
[ 'l\'abbandonacelo',
  'l\'Abbandonacelo',
  'L\'Abbandonacelo',
  'all\'abbandonacelo',
  'all\'Abbandonacelo',
  'All\'Abbandonacelo',
  'dell\'abbandonacelo',
  'dell\'Abbandonacelo',
  'Dell\'Abbandonacelo',
  'dall\'abbandonacelo',
  'dall\'Abbandonacelo',
  'Dall\'Abbandonacelo',
  'nell\'abbandonacelo',
  'nell\'Abbandonacelo',
  'Nell\'Abbandonacelo',
  'sull\'abbandonacelo',
  'sull\'Abbandonacelo',
  'Sull\'Abbandonacelo',
  'coll\'abbandonacelo',
  'coll\'Abbandonacelo',
  'Coll\'Abbandonacelo',
  'd\'abbandonacelo',
  'd\'Abbandonacelo',
  'D\'Abbandonacelo',
  'quest\'abbandonacelo',
  'quest\'Abbandonacelo',
  'Quest\'Abbandonacelo',
  'quell\'abbandonacelo',
  'quell\'Abbandonacelo',
  'Quell\'Abbandonacelo' ]

Again, very sorry I'm not entirely sure how this code is creating a dictionary. I'm still going to continue investigating on my end but was hoping you could help point me in the right direction.

I've gotten this much father. Commenting out some things caused the code work work.
See my commit here
I'm sure this code does something, although I'm not familiar with what it does.
I ran your unit tests and they all passed (see below)
1..91
# tests 91
# pass  91

This dictionary still takes a long time to load. Here's time timestamps for each language for me to load them (and do some additional dictionary appends). This is unit tests from my code, so results my vary.
 PASS  test/spellchecker.test.js (35.073s)
  ✓ SpellChecking English should work (295ms)
  ✓ SpellChecking French should work (3712ms)
  ✓ SpellChecking Italian should work (24802ms) <-- this took 24 seconds!!!
  ✓ SpellChecking German should work (3442ms)

If you'd like, I can cleanup the code (by removing the commented out lines) and merge it. However I'm a bit hesitant about deleting random things and calling it fixed.
Let me know how to continue.
Thanks!

Sorry for the delayed response! Thanks for investigating it so well, @brandon-pereira!

Maybe it’s slow because this part doesn’t do anything?
The combinable part here references to hunspell: PFX flag cross_product number or SFX flag cross_product number, where man 5 hunspell defines cross_product as: “Cross product (permission to combine prefixes and suffixes).  Possible values: Y (yes) or N (no)”. That’s checked for here.
The it dictionary seems to have a lot of PFX and SFX entries, with Y on, namely 489 and 2744, whereas nl has 44 and 452 respectively, and en-US has 14 and 59.

Do you know Italian and could you check if it still “works” without this loop?

Hey @wooorm I have an Italian translator here who can investigate this. Give me a day or two to work with them to figure this out.

Oh that’s great, thanks Brandon!

I've talked with my translator, removing these lines works but we don't feel comfortable doing a pull request to master. I'll use my forked version as a dependency in my project (partial spellchecking is better than no spellchecking for us). Thanks for the help with this, sorry I wasn't able to help with a better fix!


Make Primitive type compatible with @types/geojson v7946.0.7

Without this, those of us using more recent geojson types get:
node_modules/terraformer/terraformer.d.ts:38:16 - error TS2416: Property 'type' in type 'Primitive<T>' is not assignable to the same property in base type 'GeoJsonObject'.
  Type 'string' is not assignable to type '"Point" | "MultiPoint" | "LineString" | "MultiLineString" | "Polygon" | "MultiPolygon" | "GeometryCollection" | "Feature" | "FeatureCollection"'.

38         public type: string;

thanks for this fix, but if the technique in #323 works for you, its what I'm leaning toward.

Thanks @jgravois  - IMO, this PR is the more correct solution.  These are the only valid GeoJson types, and the only ones Terraformer supports (https://github.com/Esri/terraformer/blob/master/terraformer.js#L643 ) - best to let TypeScript enforce what is essentially the discriminated union you are using.

I started scratching my head trying to figure out why we should need to redeclare GeoJSON typings here and tbh, I don't know why either of these PRs are necessary.

Here's my minimal repro:
git clone https://github.com/holvonixAdvay/test-geojson1
pushd test-geojson1
yarn
yarn compile

$ tsc -p .
node_modules/terraformer/terraformer.d.ts:38:16 - error TS2416: Property 'type' in type 'Primitive<T>' is not assignable to the same property in base type 'GeoJsonObject'.
  Type 'string' is not assignable to type '"Point" | "MultiPoint" | "LineString" | "MultiLineString" | "Polygon" | "MultiPolygon" | "GeometryCollection" | "Feature" | "FeatureCollection"'.

38         public type: string;
                  ~~~~

thanks for that. the error is reproducible in my app too.

best to let TypeScript enforce what is essentially the discriminated union you are using.

I hear what you're saying, but copy/pasting from GeoJSON's own typings isn't the most 'correct' thing we can do.
I've opened #326 with yet another option. call me callous, but I think we could get away with releasing it as a patch (instead of calling it a breaking change).


Number and Quantity searches do not consider implicit ranges / significant digits

Numeric searches may not consider implicit ranges / significant digits. The FHIR user schema uses doubles.
The FHIR Specification uses ranges as described in https://hl7.org/fhir/search.html#prefix:

The range interpretation is provided for decimals and dates. Searches are always performed on values that are implicitly or explicitly a range. For instance, the number 2.0 has an implicit range of 1.95 to 2.05, and the date 2015-08-12 has an implicit range of the all the time during that day. If the target value is a Range, a Period, or a Timing, then the target is explicitly a range.

Notes from the spec:

a number search is used against a resource element that stores a simple integer (e.g. ImmunizationRecommendation.recommendation.doseNumber), and the search parameter is not expressed using the exponential forms, and does not include any non-zero digits after a decimal point, the significance issues cancel out and searching is based on exact matches. Note that if there are non-zero digits after a decimal point, there cannot be any matches
When a comparison prefix in the set lgt, lt, ge, le, sa & eb is provided, the implicit precision of the number is ignored, and they are treated as if they have arbitrarily high precision
The way search parameters operate in resources is not the same as whether two numbers are equal to each other in a mathematical sense
Searching on decimals involves an implicit range. The number of significant digits of the implicit range is the number of digits specified in the search parameter value, excluding leading zeros. So 100 and 1.00e2 both have the same number of significant digits - three
sa (starts-after) and eb (ends-before) are not used with integer values but are used for decimals.

So its clear that the search parameter value should be interpreted as a range, unless:

A. the target of the search is a simple integer type and the search parameter is given as a whole number with no decimal point;

For A, I assume that the data type of the element being search must be integer, so it doesn't apply for decimals that just happen to have whole number values (including the "count" specialization?).

B. a prefix of gt, lt, ge, le, sa, or eb is used

The following questions for the Investigation are:

Should a decimal target value be interpreted as a range or not? Theory is: Yes, a target decimal should be handled like a range. Based on:

Searches are always performed on values that are implicitly or explicitly a range.

leads to some interesting results if both the search value and the target value are interpreted as ranges. For example, a search for value=5 would NOT match any values in [4.5,5.5) except for exactly 5 because in a range search, "eq" is interpreted to mean that the target range is fully contained within the search range.

Note that this would require us to handle integers different from decimals.
Its also worth mentioning that Range was not a searchable type in DSTU2, but I think we supported it anyway. In R4 its explicitly marked as a type thats indexable for a search parameter of type Quantity
Steps

Investigate impact to DB Schema changes with double vs decimal
Create test cases to consider "significant digits" while performing searches.

Reference to DB2's data types - https://www.ibm.com/support/knowledgecenter/en/SSEPEK_11.0.0/intro/src/tpc/db2z_numericdatatypes.html
Original Issue DSTU2 Repo #246

PR https://github.com/IBM/FHIR/pull/474

Currently the PR is open and under review.


False positives - PrestaShop <IP_ADDRESS>

Description
I'm trying to save product in PrestaShop <IP_ADDRESS>. I am receiving error 403 and several false positives in log file.
Audit Logs / Triggered Rule Numbers
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client <IP_ADDRESS>] ModSecurity: Rule 7f0f9b3b2bc0 [id "932150"][file "/etc/apache2/modsecurity-crs/coreruleset-3.3.1-rc1/rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"][line "463"] - Execution error - PCRE limits exceeded (-8): (null). [hostname "domain.com"] [uri "/adminXXX/index.php/sell/catalog/products/206"] [unique_id "YHa1hxtUeu@2oJrdNR6ohQAAAAM"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client <IP_ADDRESS>] ModSecurity: Rule 7f0f9b3b2bc0 [id "932150"][file "/etc/apache2/modsecurity-crs/coreruleset-3.3.1-rc1/rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"][line "463"] - Execution error - PCRE limits exceeded (-8): (null). [hostname "domain.com"] [uri "/adminXXX/index.php/sell/catalog/products/206"] [unique_id "YHa1hxtUeu@2oJrdNR6ohQAAAAM"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client <IP_ADDRESS>] ModSecurity: Rule 7f0f9bc98608 [id "941160"][file "/etc/apache2/modsecurity-crs/coreruleset-3.3.1-rc1/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf"][line "199"] - Execution error - PCRE limits exceeded (-8): (null). [hostname "domain.com"] [uri "/adminXXX/index.php/sell/catalog/products/206"] [unique_id "YHa1hxtUeu@2oJrdNR6ohQAAAAM"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client <IP_ADDRESS>] ModSecurity: Rule 7f0f9bc71920 [id "941200"][file "/etc/apache2/modsecurity-crs/coreruleset-3.3.1-rc1/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf"][line "299"] - Execution error - PCRE limits exceeded (-8): (null). [hostname "domain.com"] [uri "/adminXXX/index.php/sell/catalog/products/206"] [unique_id "YHa1hxtUeu@2oJrdNR6ohQAAAAM"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client <IP_ADDRESS>] ModSecurity: Warning. Pattern match "\\\\\\\\xbc[^\\\\\\\\xbe>]*[\\\\\\\\xbe>]|<[^\\\\\\\\xbe]*\\\\\\\\xbe" at ARGS:form[step1][description][1]. [file "/etc/apache2/modsecurity-crs/coreruleset-3.3.1-rc1/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf"] [line "546"] [id "941310"] [msg "US-ASCII Malformed Encoding XSS Filter - Attack Detected"] [data "Matched Data: XXX"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.1"] [tag "application-multi"] [tag "language-multi"] [tag "platform-tomcat"] [tag "attack-xss"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152 [hostname "domain.com"] [uri "/adminXXX/index.php/sell/catalog/products/206"] [unique_id "YHa1hxtUeu@2oJrdNR6ohQAAAAM"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client <IP_ADDRESS>] ModSecurity: Rule 7f0f9bc48e98 [id "941350"][file "/etc/apache2/modsecurity-crs/coreruleset-3.3.1-rc1/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf"][line "573"] - Execution error - PCRE limits exceeded (-8): (null). [hostname "domain.com"] [uri "/adminXXX/index.php/sell/catalog/products/206"] [unique_id "YHa1hxtUeu@2oJrdNR6ohQAAAAM"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client <IP_ADDRESS>] ModSecurity: Access denied with code 403 (phase 2). Operator GE matched 5 at TX:anomaly_score. [file "/etc/apache2/modsecurity-crs/coreruleset-3.3.1-rc1/rules/REQUEST-949-BLOCKING-EVALUATION.conf"] [line "152"] [id "949110"] [msg "Inbound Anomaly Score Exceeded (Total Score: 5)"] [severity "CRITICAL"] [ver "OWASP_CRS/3.3.1"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-generic"] [hostname "domain.com"] [uri "/adminXXX/index.php/sell/catalog/products/206"] [unique_id "YHa1hxtUeu@2oJrdNR6ohQAAAAM"]
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client <IP_ADDRESS>] ModSecurity: Warning. Operator GE matched 5 at TX:inbound_anomaly_score. [file "/etc/apache2/modsecurity-crs/coreruleset-3.3.1-rc1/rules/RESPONSE-980-CORRELATION.conf"] [line "91"] [id "980130"] [msg "Inbound Anomaly Score Exceeded (Total Inbound Score: 5 - SQLI=0,XSS=5,RFI=0,LFI=0,RCE=0,PHPI=0,HTTP=0,SESS=0): individual paranoia level scores: 5, 0, 0, 0"] [ver "OWASP_CRS/3.3.1"] [tag "event-correlation"] [hostname "domain.com"] [uri "/adminXXX/index.php/sell/catalog/products/206"] [unique_id "YHa1hxtUeu@2oJrdNR6ohQAAAAM"]
Your Environment

CRS version (e.g., v3.2.0): v3.3.1-rc1 (same on v3.3.0)
Paranoia level setting: 1
ModSecurity version (e.g., 2.9.3): 2.9.3
Web Server and version (e.g., apache 2.4.41): Apache/2.4.38 (Debian)
Operating System and version: Debian 10

Confirmation
[X] I have removed any personal data (email addresses, IP addresses,
passwords, domain names) from any logs posted.

Please try increasing these settings in /etc/modsecurity/modsecurity.conf:
SecPcreMatchLimit 100000
SecPcreMatchLimitRecursion 100000

@szymonkrygier let us know if it helps or not, thanks!

Please try increasing these settings in /etc/modsecurity/modsecurity.conf:
SecPcreMatchLimit 100000
SecPcreMatchLimitRecursion 100000

Dear Azurit,
thank you for help but it did not work.
I've found temporary solution - I've added:
SecRuleRemoveById 932150
SecRuleRemoveById 941160
... 941200
... 941310
... 941350

to my Virtual Host's config file but I'm still looking for better solution. :)

How much you increased it?

After you increased it, does error messages changed?

@szymonkrygier it would be good to see the whole request - can you share with us an example? Of course, remove the sensitive data...
Eg. you can try that with curl -v ... http://foo.com/ ...

How much you increased it?

I've set both MatchLimit and MatchLimitRecursion to 100 000 like you suggested.

@szymonkrygier it would be good to see the whole request - can you share with us an example? Of course, remove the sensitive data...
Eg. you can try that with curl -v ... http://foo.com/ ...

I will post the whole request later today. :)

I've set both MatchLimit and MatchLimitRecursion to 100 000 like you suggested.

Sorry, it was misunderstanding, 100 000 is default value. Try setting it to 200 000.

I've set both MatchLimit and MatchLimitRecursion to 100 000 like you suggested.

Sorry, it was misunderstanding, 100 000 is the default value. Try setting it to 200 000.

I've set both settings to 200 000 and even 300 000 but I'm still receiving those errors.
In my opinion PrestaShop should get its exlusion rules like WordPress, etc.. Anyway I need to figure out how to tune CoreRuleSet for latest PrestaShop.
I will post the whole request later like @airween suggested.

We are planning to create exclusion package for Prestashop but it's really complex and will take some time.
I can give you exclusion rules for Prestashop from my private collection but i need to see what exactly is doing problems - which means that first we need to resolve problem with PCRE limits.
Can you upload your modsecurity.conf?

We are planning to create exclusion package for Prestashop but it's really complex and will take some time.
I can give you exclusion rules for Prestashop from my private collection but i need to see what exactly is doing problems - which means that first we need to resolve problem with PCRE limits.

It would be great! :)

Can you upload your modsecurity.conf?

Of course: https://pastebin.com/9eukzFQg

Maybe it is worth noticing that the problem occurs when I'm trying to save a product in a catalog.
After disabling those rules:
932150, 941160, 941200, 941310, 941350
I'm able to save the product without any errors but I treat that as a temporary solution to the problem. I would prefer to avoid disabling any rules and instead of that create some strict exclusions for that action.
Furthermore I've just discovered one more problem - when I'm trying to change text color in product's description (after disabling above rules) another error 403 appears.. But I guess that we should fix the first problem and later focus on different ones.
@azurit it would be great oppurtunity for me to test your exclusion rules for PrestaShop. :)

Can you post URL where you are sending the request? Feel free to censor the domain name.

Can you post URL where you are sending the request? Feel free to censor the domain name.

https://domain.com/adminXXX/index.php/sell/catalog/products/534?_token=XXX

Try putting this rule into /etc/modsecurity/crs/REQUEST-900-EXCLUSION-RULES-BEFORE-CRS.conf:
SecRule REQUEST_FILENAME "@rx /admin[0-9a-zA-Z]+/index.php/sell/catalog/products/[0-9]+$" \
    "id:9994206,\
    phase:2,\
    pass,\
    t:none,\
    nolog,\
    chain"
    SecRule &ARGS:form[id_product] "@eq 1" \
        "t:none,\
        ctl:ruleRemoveTargetByTag=attack-xss;ARGS"

SecRule REQUEST_FILENAME "@rx /admin[0-9a-zA-Z]+/index.php/sell/catalog/products/[0-9]+$"
"id:9994206,
phase:2,
pass,
t:none,
nolog,
chain"
SecRule &ARGS:form[id_product] "@eq 1"
"t:none,
ctl:ruleRemoveTargetByTag=attack-xss;ARGS"

@azurit rule added, apache restarted and your solution works as expected. :)
By the way by adding above rule the second problem is gone too.
Thank you!

You are welcome :)

@azurit it would be great oppurtunity for me to test your exclusion rules for PrestaShop. :)

I will contact you when it's be ready for testing.
Can we close this issue?

You are welcome :)

@azurit it would be great oppurtunity for me to test your exclusion rules for PrestaShop. :)

I will contact you when it's ready for testing.

Contact me whenever you ready!

Can we close this issue?

Sure. Thank you once again!


sprite.worldPosition is NaN at the start of the game => game.camera breaks

A bug in the API:

Phaser version(s): 2.8.0
What should happen: camera.follow() doesn't break like phaser 2.6.2
What happens instead:  camera breaks, life is hard

This can be traced all the way back to pt.tx from UpdateTransform, which is NaN for some reason at the start when calling PIXI's matrix() method => causing game.camera.update() to not update properly if camera.follow(target) is called at that time. (at line 27362 camera.update())
    this.displayObject.position.x = -this.view.x;
    this.displayObject.position.y = -this.view.y;

which is dependent on target's worldPosition.x and worldPosition.y
I fixed this by changing the following lines in updateTransform line 14107
    this.worldPosition.x = wt.tx;
    this.worldPosition.y = wt.ty;

to
    this.worldPosition.set(wt.tx, wt.ty);

which is what is used in Phaser 2.6.2. This prevents worldPosition.x and worldPosition.y from being set to NaN
Broke my game  :(

Can you post a runnable example?
camera/basic follow seems to work correctly.

Can't reproduce this one. 🙁


Multiple Ignore Patterns

I have a few different patterns I want to ignore via --ignorePatterns but it seems this can only accept one pattern? It would be great if this could accept an array similar to --fileExtensions

I also happened to need this today... it's hacky, but you skott is using https://www.npmjs.com/package/minimatch under the hood, so you can use {} with comma-separated lists, e.g.,
--ignorePattern '{src/file1.ts,src/path/to/file2.ts,src/api/**/*.ts}'

Note the surrounding ' since your shell may try to interpolate otherwise.

The above are very helpful, thanks. What I ended up doing was temporarily putting the paths I wanted to ignore it my .gitignore file before running skott.

Hello folks, thanks for opening that issue @rypete!
"ignorePattern" is a pretty new feature for skott so I wanted to collect few feedbacks about the ability of ignoring specific set of files before going further as there is currently the "ignorePattern" option, the "fileExtensions" option that can be also considered as a filter even though it does not really allow fine grained file filtering and also the ".gitignore" support.
If you guys are facing some use cases where you would want multiple patterns to be provided at once I can definitely work on that to make skott support it.
Are you both @jakebiesinger @rypete using skott via the API? For the CLI it would probably require a skott config file as I'm afraid for the CLI itself it would be too verbose and error prone to allow multiple ignore patterns.
FYI I'm currently on vacation till the end of the next week so don't expect quick replies until there but I will catch up asap :)

I'm using skott via the CLI and would love it if there were a config file I could set and forget.
For the large typescript codebase I'm working in now, we prevent PRs containing circular imports everywhere except in a set of "context" files, where we set up helper methods that dynamically import at method call time via await import ('./some/file').doSomeThing().
Skott has found literally hundreds of circular imports that madge missed due to some shortcomings in how they're parsing extended tsconfig files (https://github.com/pahen/madge/issues/322) so we're cutting over to use skott everywhere.

I'm using the CLI but not the config file. My use case is a lot simpler than @jakebiesinger and I only needed it for a showcase demo.

Thanks for the input, by the way the config file is not yet available, we were just discussing about the possibility of implementing it.
Without that config file I hardly see how we could easily provide multiple ignore patterns using the CLI

One way might be, and what I also tried, was to use the --ignorePatterns flag multiple times. I noticed the underlying system turned it into an array. This might be useful but I will of course use whatever you come up with.
Something like skott --ignorePatterns="**/*.test.ts" --ignorePatterns="**/*.js" etc

Could actually be one way to do it, didn't think about that actually, thanks!
I'm back from vacation so you'll get updates pretty soon, stay tuned!

You need to use brackets { } to ignore multiple files
This worked for me
--ignorePattern='{commons/Store/{Redux/types/StateMachineContext.ts,ExerciseTherapySessionState/actions/transition.ts},commons/Utils/TestMocks/Provider.tsx}'

Thanks for the tip @eppisapiafsl! This is what can be used until I investigate in providing a way to stack multiple patterns without losing too much DX

Hello guys,
I was finally able to land support for multiple ignore patterns. It will be released in the next version, that is<EMAIL_ADDRESS>Multiple patterns are supported through the CLI by having multiple occurrences of the --ignorePattern parameter or supported within the API using a simple array skott({ ignorePatterns: ["test/**/*.js", "examples/**/*.js" })
Feel free to re-open the issue if you're still encountering issues after the release


Introduce a GCD Worker Type

This is a work in progress and needs a lot more work to finish it.

What's the status of this? I'd prefer to use the GCD worker type.

The initial worker type has been merged, there are some improvements to be made in the future by asynchronously parsing the request.


fix(performance): comment all log_debug

Hello @gkellogg,
While investigating some memory issues I discovered that the log_debug calls generate a lot of objects. Half of them were already commented so this PR comments all the others.
I did a small benchmark with memory_profiler:
allocated memory by gem (current)
-------------------------------------------------------
  48.30 MB  json-ld
  41.03 MB  rdf-ac80b2f2b82e

allocated memory by gem (with all log_debug commented)
-------------------------------------------------------
  43.33 MB  json-ld (- 10%)
  15.79 MB  rdf-ac80b2f2b82e (- 42%)

The 3 lines that stores a lot of objects:

9.12 MB  rdf/util/logger.rb:181
7.97 MB  rdf/util/logger.rb:224
6.98 MB  rdf/util/logger.rb:180

This is partly because the RDF utils functions  logger_debug /  logger_common use splat operators which is quite costly, so I think the PR provide the best ROI.

Coverage: 84.444% (-1.0%) from 85.432% when pulling 18f84e81485750dc52082ba0e3155440ebc29254 on PerfectMemory:fix/debug-log into 742eecbf47237833071b8bf2dc18a258271923bf on ruby-rdf:develop.


[PowerToys Run] Show windows settings in the search as well

Summary of the new feature/enhancement
The finder does not look for any windows settings, eg. Bluetooth
Proposed technical implementation details (optional)

closing against #6390


gclient sync error

It appears that a recent change to gclient (https://chromium-review.googlesource.com/c/509451/) has enabled syntax validation of DEPS files by default. This causes an error to occur when processing the DEPS file:
ValueError: unexpected AST node: <_ast.Import object at 0x7fd8492ad990> Import(names=[alias(name='os', asname=None)]) (file '/ct/certificate-transparency/DEPS', line 58)

Passing --disable-syntax-validation to the gclient sync command resolves the error. Either the DEPS file should be updated such that it passes validation or the documentation should be updated to specify passing --disable-syntax-validation to gclient sync.

I got the same error when removing  --disable-syntax-validation after getting an initial gclient.py: error: no such option: --disable-syntax-validation


Fix midnight log rotation for cherrypy threads

Fixes #8780
Problem was with the (- 7200 secs), depending on the polling cycle of the cherrypy thread, we were not actually updating the self.baseFilename, thus there were no new log files created.

tested in my VM.


Save does not save nested field as I expected

GORM Playground Link

https://github.com/go-gorm/playground/pull/580
Description

I test the following on Postgres.
First I create the user with the nested account.
Then I pull the record of the user along with the nested account.
Then I modify the nested account and do an update to the user via Save()
I expect that the nested account to be updated. But it seems that ON CONFLICT DO UPDATE does not set the the relevant field.

Use FullSaveAssociations
DB.Session(&gorm.Session{FullSaveAssociations: true}).Save(&result)

SQL is:
INSERT INTO `accounts`(`user_id`, `number`, `id`)
VALUES (1, "My new account", 1)
ON CONFLICT ( `id` )
DO UPDATE SET
	`user_id` = `excluded`.`user_id`,
	`number` = `excluded`.`number`
RETURNING `id`

Thank you, I missed that.

Is there any way to customize to save a particular association and not another?

I have no idea. Perhaps saving alone is the easiest way.


Wrong return URL

Hi guys, I am using Shopware headless with a nextjs strorefront. Mollie works as it should. but now I have set up a staging instance. the store-api is now accessible at https://mydomain.com/stage/store-api/. When I now initiate a payment, I am correctly redirected to the mollie payment page. but after the payment I am redirected to https://mydomain.com/stage/stage/api/mollie/payment/return/018da7b419aa72c08e1173e57f5adf5a
why? where does the double stage come from? does anyone have an idea?
Thanks in advance

I don't have an idea straight away, but I think you should find the culprit pretty quickly by starting debugging at https://github.com/mollie/Shopware6/blob/bf0055d39a7385778a203e517d9c0ea92dede389/src/Service/Router/RoutingBuilder.php#L75-L96

Hi
it just used the symfony router as far as i can remember, as @fjbender  already wrote.
but it also uses an overwrite-combination from the HOST of the .env file in Shopware
maye you have a weird value in there?


Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Branch name
docker
Commit ID
111
Other environment information
No response
Actual behavior
docker部署后修改端口号之后修改头像不显示
Expected behavior
No response
Steps to reproduce
docker部署后修改端口号之后修改头像不显示

Additional information
No response

I think this is irrelevant with port alteration.


Fix 18n fallback when "mount_at_root" is false (4.x)

Backport of #2602 to the 4.x branch.
Fixes #2596 in the 4.x branch.

@guillerodriguez could you please rebase 4.x branch 🙏🏼?

@guillerodriguez could you please rebase 4.x branch 🙏🏼?

Branch updated.


DDCE-5197 - Play 3.0 upgrade

I wont remove testOnlyDoNotUseInAppConf now it can be cleaned up later


Reorg k8s related scripts structure and update readme

Move k8s scripts from kubernetes/examples to kubernetes.
Adding a link to kubernetes Readme from the root Readme.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@eb45b43). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4827   +/-   ##
=========================================
  Coverage          ?   57.63%
  Complexity        ?        4
=========================================
  Files             ?     1212
  Lines             ?    65593
  Branches          ?     9551
=========================================
  Hits              ?    37802
  Misses            ?    24934
  Partials          ?     2857

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb45b43...6e736a5. Read the comment docs.


ide: show go to for function hover return type

I've found myself wanting this...  adds to the hover quick go-to for a function's return type:

This is particularly useful when you are hovering over a function in a long chain, like:
foo.bar().b$0az().some_trait_fn();

where baz's return type is not immediately obvious, but the chain is not long enough to trigger chain inlay hints...
i guess I could just select foo.bar().baz() too to get the types too...

Sounds reasonable, note that you can also use Go to Type Definition to jump to the return type of a call.
bors r+


borders doesnt work

Describe the bug
Borders doesn't work on windows. I have set the borders but it doesn't show. new to neovim here, any guides would be very nice.
To Reproduce
i have set this in my config:
border = { "╔" ,  "═"  , "╗" ,  "║" ,  "╝", "═" ,  "╚" , "║"  }
Desktop

OS: Arch
Terminal: kitty, tmux

Neovim Version

NVIM v0.10.0
Build type: Release
LuaJIT 2.1.1720049189

Hi. This isn't a kickstart issue. You're reporting a problem with neovim itself.
Please file an issue in their repo instead. Thanks!


docs: add redirect plugin and list of redirects

Add redirect plugin (plugin-client-redirects) and a list of a few redirects

This should also fix https://github.com/clearlydefined/website/issues/1048


Allow substitution of "{date}" in @author tag.

Feature

[x] Description of what's added

In addition to {author} and {email}, this PR adds {date} to the @author tag.

[ ] Added gif to README

[ ] Added unit test

@cschlosser, would you welcome PRs for very specific use cases like this?
I needed something like:
@author NAME 2022/12/22 Description

But I don't think there's a lot of people who will be using it this way.
Do you think it would be better if this I generalize this change to making all substitutions work for all tags?

Hi @helixquar ,
It's fine as is. Please just also address the other two checkboxes and then I will merge it.


Bug with "using"

works:
UserControl "AmmyApplicationTest.NewControl1" {
	Grid {
		System.Windows.Input.KeyboardNavigation.TabNavigation: Local
	}
}

does not work (unresolved reference KeyboardNavigation)
using System.Windows.Input

UserControl "AmmyApplicationTest.NewControl1" {
	Grid {
		KeyboardNavigation.TabNavigation: Local
	}
}

Fixed!
The new version is on MyGet: https://www.myget.org/F/ammy/api/v2


Player ignores the playing prop, but only when going from true to false

Current Behavior
I have a player inside a modal, that modal emits an event causing the video playing prop to change from false to true. This does successfully start the video, however when I close the modal I see the property on the ReactPlayer changing from true to false as expected, however the video keeps playing in the background (since the modal is now closed).
I've been using the library for a while, and it is the first time I've seen this behaviour, so a little confused as to why might be causing it.
Other Information
The current implementation looks like this:
The console log updates as the component state does, and as mentioned above as the ReactPlayer component props do too in the React inspector tool.
  render() {
    const { mediaUrl, playing } = this.state;
    console.log(playing);
    return (
      <ReactPlayer
        className="media-player"
        url={mediaUrl}
        playing={playing}
        width="100%"
        height="100%"
        config={{
          youtube: {
            playerVars: {
              modestbranding: 1,
              showinfo: 0
            }
          },
          vimeo: {
            playerOptions: {
              responsive: true
            }
          }
        }}
      />
    );
  }

Anything I could try here? Thank you!

What type of URL are you trying to play? The issue template is there for a reason. It's hard to know what's going on without knowing the type of player being initialised.
I'm confused as to how things are still playing when the modal is closed. ReactPlayer should be unmounted when the modal closes, which calls stop() assuming the player has called onReady previously:
https://github.com/CookPete/react-player/blob/6d57ef35c4fc8469bb006a9aacfd15a5ba57fb71/src/Player.js#L29-L31
Not all players do things on stop(), but the containing div/iframe that the player sits in is destroyed when the player unmounts, so something strange must be going on for it to continue playing in the background.

@CookPete sorry for not mentioning it, but I did tried both with YouTube and Vimeo players, both showing the same behaviour. This modal does not destroy the component as it closes, it is only toggling CSS properties.
What led me to believe it could be a problem in the library itself was the fact that in the React Inspector tool, I see the playing property go from false to true and the video starts playing, but when I close the modal and it goes from true to false, the video doesn't stop.
I'll see if I can find any additional information that I can add to this.

I wonder if the browser is deliberately preventing hidden videos from being controlled, to stop the playing of potentially intrusive videos that the user can't see? Can you update your logic to dismount the player first, before hiding the modal?

@CookPete that's an interesting idea, unfortunately it made no difference. I'll keep looking. Thank you.

@CookPete actually, it wasn't exactly the hypothesis you've mentioned, but it led me to the problem. The modal was originally set to display: none;, and while the video component appeared to initialise properly, showing state and everything normally mounted on the inspector, if I just control the modal visibility with the CSS visibility and z-index properties then it behaves as expected, complying with the current status of the playing property.
So while it is pretty strange that it ends up in this state, this does solve my specific problem here.
Thanks again Pete for the feedback and help provided here.


Error sending one mail to many users

I'm running this script for sending an email to many users. I want it to be, 1 to 1 without others users being copied in the headers.
this is the error i'm having:
400HTTP/1.1 400 Bad Request Server: nginx Date: Tue, 30 Aug 2016 13:31:02 GMT Content-Type: application/json Content-Length: 216 Connection: keep-alive X-Frame-Options: DENY {"errors":[{"message":"Invalid type. Expected: string, given: array.","field":"personalizations.0.to.0.email","help":"http://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/errors.html#message.personalizations.to"...}
This is the script i'm running for v3,
`<?php
require("sendgrid-php/sendgrid-php.php");
// query the users
$resultado = mysqli_query($dbc,"SELECT email, hash FROM newsletter WHERE enviado = '0' AND newsletter = '1'");
$totalRows = mysqli_num_rows($resultado);
if ($totalRows == 0){
echo "No results";
}
$all_users = array(); // intialzie array
while ($usuario = mysqli_fetch_array($resultado, MYSQLI_ASSOC)) {
$usermail = $usuario['email'];
$hash = $usuario['hash'];
mysqli_query($dbc, "UPDATE newsletter SET enviado = '1' WHERE email='$usermail' ");
$all_users[] = $usermail; // push all emails first
}
$apiKey = 'myapikey';
$sg = new \SendGrid($apiKey);
try {
$from = new SendGrid\Email(null, "no_responder@test.ar");
$subject = "Convocatorias Semanales";
$to = new SendGrid\Email(null, $all_users);
$content = new SendGrid\Content("text/html", "Test");
$mail = new SendGrid\Mail($from, $subject, $to, $content);
$response = $sg->client->mail()->send()->post($mail);
echo 'Ok!';
} catch (Exception $e) {
echo 'Caught exception: ',  $e->getMessage(), "\n";
}
echo $response->statusCode();
echo $response->headers();
echo $response->body();
?>`
I can't send the array of users in "to". My purpose is to send one mail to each users individually without others users being copied in the headers.

sendgrid-php Version: 3
PHP Version:  5.5.9

Hello @asantisan,
Here is an example:
<?php
function exampleMultipleTos()
{
    $mail = new Mail();
    $email = new Email("DX", "test@example.com");
    $mail->setFrom($email);
    $mail->setSubject("Hello World from the SendGrid PHP Library");

    // Here is where you would loop through for each To email. Each To email needs its own Personalization
    $personalization1 = new Personalization();
    $email1 = new Email("Example User", "test1@example.com");
    $personalization1->addTo($email1);
    $mail->addPersonalization($personalization1);

    $personalization2 = new Personalization();
    $email2 = new Email("Example User", "test2@example.com");
    $personalization2->addTo($email2);
    $mail->addPersonalization($personalization2);

    $content = new Content("text/html", "some text here");
    $mail->addContent($content);
    $reply_to = new ReplyTo("test@example.com");
    $mail->setReplyTo($reply_to);
    return $mail;
}

function sendEmail()
{
    $apiKey = getenv('SENDGRID_API_KEY');
    $sg = new \SendGrid($apiKey);
    $request_body = exampleMultipleTos();
    $response = $sg->client->mail()->send()->post($request_body);
    echo $response->statusCode();
    echo $response->body();
    echo $response->headers();
}

sendEmail();

Source: https://github.com/sendgrid/sendgrid-php/blob/master/examples/helpers/mail/example.php#L22

Thank you. Any other option to do it?

@asantisan,
You could build the json object yourself, like this: https://github.com/sendgrid/sendgrid-php/blob/master/examples/mail/mail.php#L28

Maybe you need to add this example in readme.md.

@Vahanerevan,
Thank you for taking the time to provide additional feedback!
We already have the basic version here in the README with a link to that code in the paragraph, right under the header. Do you have a suggestion on how I can make that more obvious?
Also, we are building out a Use Cases section (that is linked from the README) and your use case will definitely be included. Hopefully that will help make things easier too.
With Best Regards,
Elmer

Hello ,
Am getting this response
{"errors":[{"message":"Invalid type. Expected: object, given: array.","field":"personalizations.0.to.0","help":"http://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/errors.html#message.personalizations.to"}]}
this is my request body
{"from":{"name":"ERP","email":"dev@gmail.com"},"personalizations":[{"to":[[{"email":"user@gmail.com"}]]}],"subject":"New User Created ","content":

Hi @lafod,
It looks like your request body was truncated, could you please repost.
But from what I see<EMAIL_ADDRESS>should be<EMAIL_ADDRESS>

This error appears to me on WP plugin, what can I do ?! array cannot be passed to wp_mail function as usual?


Investigate "Squadron" support

I'm too tired to look up the specifics right now, but there was some comment about how there's no good way to do a minion group of vehicles currently.

I think this is handle-able with the existing system, and I can't find any specific references to it. Shelving for now.


Updated Profile Page

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Looks good 👍 But I think your fork/branch are not up to date, as you have generated files in there - you can update your fork/branch and push the changes to your branch in your fork and it will automatically update your PR

Looks good 👍 But I think your fork/branch are not up to date, as you have generated files in there - you can update your fork/branch and push the changes to your branch in your fork and it will automatically update your PR

Tried to do that eddie, but don't know what's happening, all check are being failed

Just done and made other PR, sorry for this Eddie

No problem, it happens to us all


Creation of 'Code of Conduct'

I want to create the 'Code of Conduct' for this project.

Issue Resolved


changed next.js from auth-helpers to supabase/ssr

#2  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @trevorpfiz and the rest of your teammates on  Graphite


Make the macOS bundle compatible osx 10.12

On macOS 10.12.6 (as far as I can test), running make app creates a
bundle that refuses to start (it complain application is only compatible
with more recent versions of macOS. The binary works great when running
it directly.
As far as I can tell this fixes the issue and the bundle works great
(despite the other issues reported for login shell, but I guess that's
another story).
I'm going to assume that targeting 10.11 or lower would also work.
I don't know what effect this have on the final binary and whether this
removed  some optimisation. Maybe that could be conditionally setup
depending on the version of macOS this is built on?

Thanks for this PR!
Since the Alacritty build instructions for macOS include make, I wonder if the source code is the right place for this. It would probably be possible to check the macOS version from the makefile and then set the environment variable to override it. That should also take care of any potential optimizations that might be different between macOS versions.

I'll have a look to see if that work, and tryin to detect the current macos version if possible.
As a side (related) question, have you looked in cargo-bundle ? I initially got that to work by side-stepping make app, in which case moving the logic to Make (if we get rid of it later) is counter productive.
I'm also quite new to rust, so may be completely missing some points.

I'm not sure about cargo-bundle. There are a few difficulties I can see with this though. I'm not sure if we'd still have control over the .app file for example, which is important. It would also require installing an extra tool, make itself is already quite common compared to that.
We're already making use of cargo-deb, but even that is more to fill in a gap, rather than using it as a primary form of distribution. Handing this off would mean giving control to someone else. And I'm not sure if outsourcing macOS build support would make anything better, or if it would just introduce additional points of failure.
That said, even if the logic is moved to make now, it shouldn't be an issue to change things later, rather than making a commitment to a change now, which might never happen.

I'm not sure if we'd still have control over the .app file for example, which is important.

Can you develop on that ? The alacritty bundle seem pretty bare... what "control" do you wish to have ?
I was more thinking in the sens that the less you have to do the better, and that cargo-bundle is offloading thinking about packaging... but up to you.
I've push a change that move the detection of MacOS version to the Makefile. There is one drawback though. The following will not work:
 ~/dev/alacritty[osx2 ✓] $ cargo build --release
   Compiling alacritty v0.2.0 (file:///Users/bussonniermatthias/dev/alacritty)
    Finished release [optimized + debuginfo] target(s) in 2m 24s

 ~/dev/alacritty[osx2 ✓] $ make app
MACOSX_DEPLOYMENT_TARGET=10.12.6
cargo build --release
    Finished release [optimized + debuginfo] target(s) in 0.24s
Created 'Alacritty.app' in 'target/release/osx'

Indeed, Cargo does not see that the release need to be rebuilt because of the change in environment variable. Which it does if the logic is in build.rs, and the .app bundle appear as invalid.

Last changes are looking good. I'd like to make sure that this still works on platforms other than 10.12 though. So if anyone can test that, I'd appreciate it.

tested on macOS 10.13, works great!

Thanks @sodiumjoe !

Thanks for you guidance and accepting this PR.
On Tue, Oct 2, 2018, 18:38 Christian Duerr<EMAIL_ADDRESS>wrote:

Merged #1605 https://github.com/jwilm/alacritty/pull/1605 into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jwilm/alacritty/pull/1605#event-1880793867, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAUez656wA7GfRfmUU4mzDPbGvq8BazPks5uhBUJgaJpZM4XAXi3
.


[EngSys] Merge public pipelines that do build and build test

[12:09 PM] Joel Hendrix
I believe this is because the test step will fail if the package didn't contain any tests to run
[12:09 PM] Joel Hendrix
if we could fix this to just skip if no tests are found then we could merge them
cc: @benbp

First step is to combine build and build-test files. Then combine the archetype-sdk-client and archetype-sdk-client-samples file. The latter will be a shortened version of the first without any tests.


record 2: display record title appropriately

The title can be retrieved from an ermrestjs function https://github.com/informatics-isi-edu/ermrestjs/issues/49
The title should come from Tuple.displayName.

This issue is under review at PR #534.

Since the PR has been merged, I'm closing this issue.


⚠ Bofrost.fr has degraded performance

In 2975b64, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1127 ms

Resolved: Bofrost.fr performance has improved in a77d723 after 37 minutes.


Setup Test Projects for NetCoreApp 2.1 and 3.1

Parent #1160
Tasks - Getting Ready

Need to audit all test projects.

Is CI Build ready for this change?  ~No, Need to add tasks for NetCoreApp 2.1 and 3.1~ YES
Which projects are NOT ready for new frameworks? Done. Please review the Inventory Below

Tasks - Consolidate Projects
Most of these test projects were created using the net full framework csproj format and targeting a single framework. This is why you'll see the framework in the name of these projects.
It's common that the actual test classes would be in a Shared project to be reused in each individual project.
This improves maintainability and fewer projects improve compile times.

These projects need to be consolidated into a single (PackageReference) csproj project.

Note that this may include updating the references in Solutions (*.sln)

"Shared" projects should be removed. Test classes should be moved to the single test project.

This may cause some unlisted test classes to suddenly be discovered. These may or may not compile or pass. Will need to investigate each instance individually.

These projects need to support multi-framework targeting.

Tasks - TargetFrameworks

Remove netcoreapp2.0, and netcoreapp3.0

Not necessary to remove netcoreapp1.x yet. This will be addressed in a separate task #1767

All test projects should include netcoreapp2.1, netcoreapp3.1

Our build system is designed to automatically pick up these extra compilations.

Tasks - Cleanup

Remove manual DefineConstants. NetCore 2+ set these automatically. Several of our projects use custom constants instead of the provided constants

Replace "NETCORE" (custom) with "NETCOREAPP" (automatic)
https://docs.microsoft.com/en-us/dotnet/core/tutorials/libraries#how-to-multitarget

Inventory

Microsoft.ApplicationInsights.Isolated.Tests Done
Microsoft.ApplicationInsights.Tests Done
TelemetryChannel.Nuget.Tests
TelemetryChannel.Tests
AspNetCore: Can EmptyApp.FunctionalTests be merged? Mothra will investigate
AspNetCore: CanMVCFramework.FunctionalTests be merged? Mothra will investigate
AspNetCore: Can FunctionalTestUtils be merged? Mothra will investigate
AspNetCore: Can Webapi.Functionaltests be merged? Mothra will investigate
Microsoft.ApplicationInsightsn.AspNetCore.Tests
Microsoft.ApplicationInsights.WorkerService.Tests
DiagnosticSourceListener.netcoreapp1.Tests - Need to convert for multiple frameworks
EtwCollector.Net46.Tests - Neet to convert for multiple frameworks
EventSourceListener.netcoreapp10.Tests - Need to convert for multiple frameworks
ILogger.NetStandard.Tests - Need to convert for multiple frameworks
Log4NetAppender: Need to merge Net45 and NetCoreApp10 into a single test project
NLogTarget: Need to merge Net45 and NetCoreApp10 into a single test project
TraceListener: Need to merge Net45 and NetCoreapp10 into a single test project
DependenceCollector.Tests - Need to remove Shared project
EventCounterCollector.Tests
HostingStartup.Net45.Tests - Need to convert to with newer csproj to support multiple target frameworks
PerfCounterCollector: Need to merge Net45, NetCore, NetCore20 into a single test project and remove the Shared.Tests project
Web.Net45.Tests: Need to convert to newer csproj to support multiple target frameworks and remove shared project
WindowsServer: Need to merge Net45 and NetCore into a single test project and remove the Shared.Tests project

Special Instructions.

Please only work on one project at a time. This will help reduce conflicts with other developers.
Please leave a comment stating which project you are starting.
Please confirm that no one else has started a project before you begin.

@TimothyMothra , just to let you know i will start the TelemetryChannel.Tests project!

@TimothyMothra , just to let you know, i will start the AspNetCore.Tests as well!

@TimothyMothra , just to let you know, I will start the WorkerService.Tests as well!

@TimothyMothra , just to let you know, I'm working in the following projects:

Adding netcoreapp1.1, 2.1 and 3.1 to EventSourceListener.Tests

@TimothyMothra , just to let you know, I'm working in the following projects:

Consolidate DependencyCollector.Tests and DependencyCollector.Shared.Tests
Converting Web.Net45.Tests to Web.Tests (transforming in the new project, which is multiframework)

Finished :)


pass "timeout" to publishRPC as optionial

By default it is 100ms. Lets make it configurable to the end user if the processing on the other side takes longer than expected.

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Is there a way to display calendar on input focus?

Is there a way to display calendar on input focus? Maybe some exposed methods?

I have an untested solution to this issue. Its almost 2am here so the testing can wait until morning.
Basically, you can use the inputProps on DateTimeField to make use of onFocus. Whenever the input gets focus, this function will be called. I am sure it can be tidied up/simplified, but at the moment I get the parentElement of e.target and click on the first span in its children. Hopefully that makes sense, here is the code:
_handleBlur: function() {
  console.log('The input was blurred');
},
_handleFocus: function(e) {
  var parent = e.target.parentElement;
  var children = parent.childNodes;
  for (var i = 0; i < children.length; i++) {
    if (children[i].tagName.toLowerCase() === 'span') {
      children[i].click();
      return;
    }
  }
},

render: function() {

  var inputProps = {
    placeholder: 'DD/MM/YYYY',
    onBlur: e => this._handleBlur(e),
    onFocus: e => this._handleFocus(e)
  };

  return (
    <DateTimeField inputProps={inputProps} />
  );
}

A shorter version:
_handleFocus: function(e) {
  e.target.nextSibling.click();
},

This issue could be closed now. Both solutions work smoothly. You should create a merge request with this feature.


Fix Label description for Create Default Disk on Labeled Nodes

This PR modifies the description for Setting: Create Default Disk on Labeled Nodes such that it now refers to the Label that we're looking for to determine initial Disk creation, which is node.longhorn.io/create-default-disk=true. This value was previously still referring to the old value from when the feature was still being developed, which was node.longhorn.io/role=storage.

Remember to add a reference to the issue in the PR description: https://github.com/longhorn/longhorn/issues/583
LGTM.


Add details of how to sign commits to pass DCO

Signed-off-by: Kyle Den Hartog<EMAIL_ADDRESS>

@kdenhartog - is there a link you used to get this?  It seems that we should link to that vs. adding this text to many contrib documents.


Draft implementation of sigstore for alpine images

All supported python releases now have associated sigstore files available.
This enables sigstore verification in the alpine images using cosign.
Unfortunately cosign 2.4+ is required which is only available in edge, package seems to work fine on 3.19/3.20.
Cosign is removed once the build completes.

Thank you for working on this!  Unfortunately, mixing Alpine releases with packages from Edge is going to be something we're not comfortable with -- it often works, but it also often breaks, and the transition between those is usually unexpected and without warning, so we avoid using Edge entirely as a result. :disappointed:

Totally understandable and exactly why I marked this as a draft.
And this independently verified your points mentioned in #977.
However a068d8102dd7988a8634a208c3314aafd21623ff is probably worth merging.

However a068d8102dd7988a8634a208c3314aafd21623ff is probably worth merging.

Can you elaborate?  I left that in when I made #978 because I'd already done the work and it does work, so even if unused, it should be harmless (and I'm still not totally convinced extracting the SHA256 from the sigstore bundles is a great solution to simply getting checksums).  It also gives us a fallback if the sigstore bundles happen to start using a different hash type (although I don't think that's actually a very likely scenario right now).
I'd actually love to improve our confidence in my really hacky extraction of the signature from the sigstore bundles by cross-referencing the SBOM explicitly, but I'd prefer even more to have officially published upstream checksums in a form that's intended for consumption (and then I'd remove both means of scraping a checksum from other data sources).


Fix send transaction response

@dalebennett1992 So the failure here is that the error is no longer a non-descript "Internal Error" https://github.com/vegaprotocol/vegawallet-browser/blob/fix/send-transaction-response/test/e2e/transaction.test.ts#L77


fail to install using pip on windows

got this error below, i believe it is because i am using windows and use chinese as my system locale. it would be better to save the readme.rst in utf8, which will solve the problem
Collecting django-postgrespool
Using cached django-postgrespool-0.3.0.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 20, in
File "C:\Users\zyuan\AppData\Local\Temp\pip-build-hixoxdz4\django-postgrespool\setup.py", line 26, in
long_description=open('README.rst').read(),
UnicodeDecodeError: 'gbk' codec can't decode byte 0x93 in position 1202: illegal multibyte sequence

Any solution?


Add JSON data type

@kunklejr Any ideas on how to do that, apart from writing custom SQL (not terrible, but not very nice either)?

@jure Jeff is not actively working on this any more.
You can use however whatever type you like, but you get a warning. This warning just means: Hey, this is not officially supported and you need to look out yourself to make it work properly. There might some problems with formatting, but may be there are not. Additional data types are also a topic I want to discuss soon.


the logo and few tools are overlapping

i would like to work on this issue.

@vishanurag kindly assign me this issue


Fix service name caching based on context path

What does this PR do?
Fixes service name caching. Context - https://discuss.elastic.co/t/apm-agent-not-working-after-updating-war-in-tomcat/239750
NOTE: I am not sure the first caching even worth it, only a few String comparisons. Maybe it's enough to leave only the second (class-loader-based) caching in ElasticApmTracer).

Checklist

[ ] This is an enhancement of existing features, or a new feature in existing plugins

[ ] I have updated CHANGELOG.asciidoc
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Added an API method or config option? Document in which version this will be introduced
[ ] I have made corresponding changes to the documentation

[x] This is a bugfix

[ ] I have updated CHANGELOG.asciidoc
[x] I have added tests that would fail without this fix

[ ] This is a new plugin

[ ] I have updated CHANGELOG.asciidoc
[ ] My code follows the style guidelines of this project
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have updated supported-technologies.asciidoc
[ ] Added an API method or config option? Document in which version this will be introduced
[ ] Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.

[ ] This is something else

[ ] I have updated CHANGELOG.asciidoc

:green_heart: Build Succeeded

Expand to view the summary

Build stats

Build Cause: [Pull request #1326 opened]

Start Time: 2020-08-05T05:59:36.195+0000

Duration: 45 min 44 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
1438

Skipped
11

Total
1449


Improvements to ProviderPickerActivity

Replaced vector warning icon with png to avoid importing support
library.
Improved accessibility support by increasing text and image size and
contrast.
Added RTL support.
Added support for canceling the picker by tapping outside the bounds.

Codecov Report

Merging #84 into master will increase coverage by 0.28%.
The diff coverage is 4.76%.

@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
+ Coverage     71.36%   71.64%   +0.28%
  Complexity      454      454
============================================
  Files            62       62
  Lines          2546     2536      -10
  Branches        243      242       -1
============================================
  Hits           1817     1817
+ Misses          662      652      -10
  Partials         67       67

Impacted Files
Coverage Δ
Complexity Δ

...va/org/openyolo/api/ui/ProviderPickerActivity.java
21.97% <4.76%> (+2.17%)
4 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 263ffa0...e6948dd. Read the comment docs.


Left-click eicon to expand to full-size

Doesn't seem to be working, both on animated and unanimated.

@Lady-Luck you have to enable them in settings

Well yeah, of course I have them enabled, otherwise I wouldn't be able to tell what is animated and what is not.
The click to expand just isn't working.

Ahh, I see.


The Challenge for randome numbers in a range has a false description

Challenge http://www.freecodecamp.com/challenges/waypoint-generate-random-whole-numbers-within-a-range : The text in the sidebar does not specify the task that is to be done, it only explains how to generate random ranges. In the code the task is described as such:

"  // Make myFunction return a random number between zero and nine instead of a decimal
// Only change code below this line."

duplicate of #1992


Add to known implementations of fsspec

There is a list of known implementation in the fsspec docs: https://filesystem-spec.readthedocs.io/en/latest/api.html#other-known-implementations
Would be nice to see pyxet on that list.

On it :)
https://github.com/fsspec/filesystem_spec/pull/1323


Fix for shapeless @@ types passed on as args

Fixes https://github.com/lightbend/scala-logging/issues/111

Hi @mwielocha,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
http://www.lightbend.com/contribute/cla

I did sign the CLA.


Preprocessing multi-session anat data

Summary
When I preprocess longitudinal (2 sessions) dwi with anat data, my final preprocessed T1w image looks strange - it appears as if there are two superimposed T1w images. I ran the preprocessing with the --longitudinal flag but get worse results. I also ran each session separately using a bids filter but the preprocessed T1w results get overwritten (they get saved in an anat folder outside the session folders). I checked the raw T1w data from both sessions for this subject and they look fine. Any ideas why I am getting these T1w results or suggestions for a workaround?
Additional details

QSIPrep version: 0.22.0
Docker version: 25.0.4

What were you trying to do?
Preprocess longitudinal dwi and anat data.
What did you expect to happen?
Get preprocessed outputs for longitudinal dwi and anat data.
What actually happened?
The preprocessed anat data either looks like 2 superpimposed T1w images or gets overwritten if I try to preprocess each session separately.
 These are scans acquired in toddlers about two years apart so we expect to see significant changes between their time points/sessions. From the documentation it looks like qsiprep uses mri_robust_template as a default when a subject has more than one T1w image. In the case of considerable changes in brain size, is there any way to disable mri_robust_template and preprocess the anat data of each session separately?

The only way I know of is to use BIDS filters that select each session. You must save the output for each session to separate BIDS datasets. If you process each session in turn using the same output dataset, the participant-level anat/ folder gets overwritten.

Yes, I think that's what I'll do for now. Thanks.


Event Based Gateway error

If an event based gateway is part of a selected test, the generation fails with the following error  " Unexpected error occurred: 'asyncAfter' is not supported for 'Event Based Gateway' ".
Here is a part of the stack trace :
Caused by: java.lang.UnsupportedOperationException: 'asyncAfter' is not supported for 'Event Based Gateway'     at org.camunda.bpm.model.bpmn.impl.instance.EventBasedGatewayImpl.isCamundaAsyncAfter (EventBasedGatewayImpl.java:90)     at org.camunda.community.bpmndt.TestCaseActivity.isAsyncAfter (TestCaseActivity.java:124)     at org.camunda.community.bpmndt.cmd.GenerateJUnit4TestCase.addHandlerFields (GenerateJUnit4TestCase.java:96)     at org.camunda.community.bpmndt.cmd.GenerateJUnit4TestCase.accept (GenerateJUnit4TestCase.java:53)     at org.camunda.community.bpmndt.cmd.GenerateJUnit4TestCase.accept (GenerateJUnit4TestCase.java:32)     at org.camunda.community.bpmndt.Generator.generateTestCases (Generator.java:159)     at org.camunda.community.bpmndt.Generator.generate (Generator.java:68)
The isAsyncAfter() method of TestCaseActivity  which calls flowNode.isCamundaAsyncAfter() throws an UnsupportedOperationException due to EventBasedGatewayImpl.isCamundaAsyncAfter() implementation  :

I have fixed the bug by adding a special handling for event based gateways - please see 602ccf74ecb90aa065a1d94528293ef29a81d256. If you want to try it out/test it with your process definition and test cases:

checkout the bugfix/event-based-gateway-error branch
install it using mvn clean install -DskipTests
set the version of the bpmn-driven-testing-maven-plugin to 0.5.0-SNAPSHOT
regenerate the test code

Until now I had no tests, which included an event based gateway. Moreover I used the extension only for pretty simple processes so far - sorry for the issue. But thanks for reporting the bug!
I plan to release version 0.5.0 of the bpmn-driven-testing extension in the next days (probably mid of next week), the bugfix will be included then.

fyi: the bugfix has been merged to master - if you still want to try it out.

Just tested it on the bug fix branch and it works perfectly fine. Thank you for the fast reply and fix.


fix(scroll): prevent 'cannot read from undefined' exception

Sometimes, I don't know why yet, scrollView is undefined and this line rises an Error.

Do you have an example of some markup where you'll get this error? Your change just adds a double check to make sure there is scroll view, but its not clear why that wouldn't be covered by the original

I'm, sorry. But I don't have a specific snippet that generates this error.
I get it in Android 6.0 with chromium 44, using JS Scrolling on the startup. When I switched to native none of my test devices get the error.
I've tried to read the code on the ionic.views.Scroll but (at this moment) understand it is beyond my capabilities.

+1
I have same issue, and this pull-request fixed it
It happened if data load in controller longer than ionic render template

@igor-slotin @audotto @iltaen @bambriy @GulinSS do you have some code example to share with us?

Thanks, seems like a harmless check to add


Admin / auth required

Hi,
I know that it's now an issue, but I would like to know where you tell the angular App that the "/admin" section requires authentication?
Thanks for the information!!
Simon

Right now I'm not requiring a person to be logged into an admin account to visit /admin. If you try it, you'll probably be able to see a quick flash of it. The reason that it redirects back to the login page is that once you go to /admin, I make a few API calls that require admin privileges. Any unauthorized calls to the API result in a redirect to the login page. This is done here.

This website is based off of the Angular Full-stack Generator. This is how we have solved the issue there.


added chaining

hashing

We are no longer actively maintaining this repo. Please check the latest Hacktoberfest repo and contribute to that. Thank you again for your contribution but will have to mark this as spam and decline this PR.


add linkedIn profile

What kind of change does this PR introduce?
Footer extension

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?

👷 Deploy Preview for peaceful-meerkat-940447 processing.

Name
Link

🔨 Latest commit
198bc909e6a6b9c1058dcff83803087dfdd65416

🔍 Latest deploy log
https://app.netlify.com/sites/peaceful-meerkat-940447/deploys/640727c6a879750008f00408


Can't run a lane that is in not part of a platform if default_platform is specified

Given this Fastfile:
default_platform :ios

lane xcode_pre_compile do
  # organize_imports and other custom actions
end

platform :ios do
  desc "Runs all the tests"
  lane :test do
    scan
  end
end

When I try to run fastlane xcode_pre_compile I get this error:

...
[16:15:42]: ------------------------------
[16:15:42]: --- Step: default_platform ---
[16:15:42]: ------------------------------
[16:15:42]: Variable Dump:
[16:15:42]: {:DEFAULT_PLATFORM=>:ios}
[16:15:42]: Could not find lane 'ios xcode_pre_compile'. Available lanes: xcode_pre_compile, ios test, ios unit_test, ios snapshot_test, ios functional_test

How can I run a lane that doesn't belong to a platform while still having a default platform?
Fastlane version: 1.44.0

I think you are missing a ':' in front of xcode_pre_compile in your lane definition. So it should actually be:
lane xcode_pre_compile do
  # organize_imports and other custom actions
end

Other than that, it doesn't seem like you can have a lane that doesn't belong to a platform when using the 'default_platform' option. It will apply the default platform and then look for your lane belonging to that platform and not find it. If you comment the default_platform line and try running it, you should see what I mean. Maybe someone can provide a way around this. I looked at the sample on this page as a guide:
https://github.com/fastlane/fastlane/blob/master/docs/Platforms.md
As you can see later on in the Fastfile there is a lane that doesn't belong to a platform and the sample fastlane commands explicitly provide the platform.

I guess this is a feature request them. Based on the error message it should be totally possible for Fastlane to find a "platform-orphan" lane after not finding it in the default platform lanes.
The missing : was a typo, thanks for catching it.

Thanks for posting this @fcy, I can reproduce this issue and can confirm this is a bug I need to fix :+1:

Fixed with https://github.com/fastlane/fastlane/commit/0c7a97b029db453bc7049cdd1c9e338de6590452, pushing a new release now :+1:
Thanks again for letting me know :rocket:


Firebase Auth Token

Currently when you authenticate with Google to Firebase you receive a FirebaseUser.UID that is the definitive ID.
Our Flutter application is calling our Rest API and sending this UID is not secure because if stolen there's nothing we can do.
When working with android or Angular2 client you'll get a Firebase Token instead that you can pass to your server as JWT Authorization header and by calling Firebase SDK the backend can get the real FirebaseUser.UID
https://firebase.google.com/docs/auth/admin/verify-id-tokens
How can we accomplish that with Flutter to secure our application ?

@collinjackson would know.

You're right that this is needed if you're talking to a custom backend. I'll add a method to FirebaseUser to retrieve idToken. Thanks for the feedback!

This is fixed in firebase_auth 0.0.4, please give this a try and let me know if it works for you.

You can see the decoded JWT token using jwt.io and my Firebase sdk was also successful.
💯

firebase_auth: ^0.11.0
What is the method to get the token?
I tried with the latest version but can't find any method  for that.
FirebaseUser mUser = FirebaseAuth.instance.currentUser();
    mUser.getToken(true)

The above won't work, neither is this:
FirebaseUser mUser = FirebaseAuth.getInstance().getCurrentUser();
mUser.getToken(true)

@Solido how did you get the token?

@collinjackson  I also need the refresh token . How do we get this value.. We need it to authenticate against our backend
It should similar to the restful call --https://identitytoolkit.googleapis.com/v1/accounts:signUp?key=[API_KEY]

@Solido
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/1000. Any further collaboration will be done there.


Switch Detailed Guide rendering app to government-frontend

This will display PDF attachment previews using draft-origin, which will allow us to test whether https://trello.com/c/1GUkYF5j/318-6-detailed-guides-migration-final-tasks-deploy-2-0-5-days is good to go.

What's the difference between the rendering app in the model and the rendering app in the presenter?

@fofr it seems like the preview document URL is determined from the rendering_app on the model: https://github.com/alphagov/whitehall/blob/change-detailed-guide-rendering-app/app/helpers/public_document_routes_helper.rb#L49

You're correct. Model rendering_app determines which url is given from whitehall admin. The one in presenter determines which frontend app is used for the content item.

Test this on Integration first please. Looks 👍 though

@boffbowsh thanks for the input, I figured out that I also had to do https://github.com/alphagov/whitehall/pull/2932/files#diff-805bcf4ab753fb66d137c6d2f891f53dR24. I think this is clear now.

Can confirm this works on integration.


be/fixes: add users

Description

[x] Resolves

Checklist

[x] I have followed the repository's contribution guidelines.
[x] I have added necessary documentation or updated existing documentation.
[x] My code follows the established code style and formatting of the project.
[x] I have tested my changes and they function as expected.
[x] I have added suitable unit tests (if applicable).

To be reviewed by: @Nasfame

Victor said users can also register with meta mask and in such case they will not have email at the begining.
I this suggest we just work with google and email for now then later we integrate metamask cos this will lead to re writing the schema and changing frontend code base to support that.

u realize the mongo - is no sql (no schema) , we can always change the schema

Victor said users can also register with meta mask and in such case they will not have email at the begining.
I this suggest we just work with google and email for now then later we integrate metamask cos this will lead to re writing the schema and changing frontend code base to support that.

u realize the mongo - is no sql (no schema) , we can always change the schema

Yea I know but for those without email, we will have to use wallet address for checking if user exists .

Referring to the upsert call


Cannot list man pages with apropos

Describe the bug
apropos is supposed to return matching man pages but it never finds any.
TLDR: It seems that man expects a /run/current-system/sw/share/man/index.bt file which doesn't exist.
To Reproduce
$ apropos --regex "^"
^: nothing appropriate.

Expected behavior
This should list all man pages. The same works fine on debian.
Additional context
Here is some debug info:
$ apropos --debug --regex "^"
[...]
final search path = /run/current-system/sw/share/man:/home/cassou/.nix-profile/share/man
path=/run/current-system/sw/share/man
warning: can't read the fallback whatis text database /run/current-system/sw/share/man/whatis
path=/home/cassou/.nix-profile/share/man
warning: can't read the fallback whatis text database /home/cassou/.nix-profile/share/man/whatis
^: nothing appropriate.

There are plenty of man pages in my system though:
$ ls /run/current-system/sw/share/man/
cs  da  de  fi  fr  hu  id  it  ja  ko  man1  man3  man4  man5  man7  man8  pl  pt_BR  ru  sv  tr  zh_CN  zh_TW

$ ls /run/current-system/sw/share/man/man1 | wc --lines1373

Some debugging in the C code reveals that man expects a /run/current-system/sw/share/man/index.bt file which doesn't exist.
Notify maintainers
/cc @ryantm @matthewbauer
Metadata

system: "x86_64-linux"
host os: Linux 5.4.33, NixOS, 20.09.git.87aea649013 (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.4
channels(cassou): ""
channels(root): "nixos-20.09pre222244.22a3bf9fb9e"
nixpkgs: /home/cassou/Documents/projects/nixos/system

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

https://github.com/NixOS/nixpkgs/pull/76841
Though I personally use https://github.com/eadwu/flakes/blob/custom/modules/apropos.nix which addresses some of the comments pointed in the PR, though not sure how effective they are at it.

Thank you @eadwu.
Closing because it is a duplicate of https://github.com/NixOS/nixpkgs/issues/14472.


[NewVPN] Enable IPv6 for HA if needed.

How to categorize this PR?

/area control-plane
/kind enhancement
What this PR does / why we need it:
If the NewVPN feature gate is enabled, an IPv6 transport network is used by the VPN tunnel. In HA mode, an IPv6 address needs to be assigned to the bonding device for the vpn-client. An IPv6 address needs also to be set in the vpn-seed-server in this case. If IPv6 is disabled in the pod (e.g. seen for GKE clusters with IPv4 stack only), the init containers must enable IPv6 by changing a kernel setting.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Depends on #10640
Release note:

[NewVPN] Enable IPv6 for HA if needed.

/hold depends on #10640

/unhold as #10640 merged
rebased on latest master

/test pull-gardener-integration

/lgtm

/unhold


nixos/systemd-stage1: fix initrd build with zfsUnstable

This in particular broke zfsUnstable because it added symbols not present in zfsStable
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Let's merge this as it will affect some people and block their updates.

Thanks, this fixes the issue for me.


Merge 3.13 into master

@skaterdav85 Hey David
Trying to merge in the updates, but it is conflicting with the validator*.js files in the dist directory and I cant seem to get it to merge the PR.
Can you please have a look and let me know why it isnt working

ah I think it is because of a recent PR where someone made updates to the dist/ files. I think you'll need to pull the latest from master into your fork and rebuild the dist files. Another reason why we should get rid of that dist/ folder heh. Btw, you have privileges to work directly on this repo, if you want to.

@skaterdav85 Excellent, thanks for leads.  I can take it from here.    And I am not sure why I was doing PRs, I knew I had access (must have been a brain pause).


release 5.0.2

Hi @solarkennedy. Coul you please merge this and afterwards do a new release?

pleeeease, release it soooner ...


simplified flash message

👨💻 What's being changed:
make code scalable
introduced context to avoid prop drilling
changed name from flash to toast for more understanding

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

I have 2 commits here can't you merge the second one??


Stability of HDFS setup

Mirroring https://github.com/uobdic/dice-lib/issues/2
Relevant items for dice-cli:

dice check environment --hdfs
dice check dice-config
dice restore hdfs-environment: restores env to the default in /etc/dice/config.yml
dice copy <path1> <path2>

Modification
Instead of all of the above, dice-lib has now implemented HDFS via pyhdfs.
This means as long as /etc/hadoop/conf/hdfs-site.xml exists, HDFS commands are available.
Since POSIX and HDFS are now implemented, this means dice-cli can implement

dice fs copy <src> <dst>
dice fs mv <src> <dst>
dice fs rm <src> <dst>

By default local file system is assumed (protocol file://) unless it starts with /hdfs.
/hdfs/<path> maps to hdfs:///<path> internally.

Has been retired in favour of CephFS


Installed packages are not found

I'm getting the an error when trying to use OmniSharp, where it doesn't find any of the installed packages:
:: [17:56:32.218] <-  OmniSharp textDocument/publishDiagnostics: {...
  {'range': {'start': {'line': 0, 'character': 6}, 'end': {'line': 0, 'character': 13}},
  'severity': 1, 'code': 'CS0246', 'source': 'csharp',
  'message': "The type or namespace name 'Spectre' could not be found (are you missing a using directive or an assembly reference?)",
  'tags': []
 },...]}

This happens for any package at all. I'm running macos 14.5 (23F79) with only .net 8 sdk installed.
There's no more related information in the logs, so I'm not sure how to debug it further.

Hello,
There is a higher chance if to get the answer to your question if you ask it at https://github.com/OmniSharp/omnisharp-roslyn

Should be fixed by PR #40, which makes transition to latest .NET 6+ based OmniSharp binaries. They are required to deal with latest .NET projects.


rekor-cli, rekor-server: 0.7.0 -> 0.8.0

Description of changes

https://github.com/sigstore/rekor/releases/tag/v0.8.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build rekor-cli rekor-server

Result of nixpkgs-review pr 177018 run on x86_64-linux 1

2 packages built:

rekor-cli
rekor-server


About Editor

https://ace.c9.io/#nav=about&api=editor
Maybe ace editor will can be better to error handling and extendibility.
that's only a suggestion.

I tried ace but didn't like it. Maybe I can give it another chance.


Support for JMS bytemessage

❗ please do not add sensitive information in issues, you can provide extra information via email using issue number as reference ❗
Describe the issue
We need to be able to receive and send byte messages over JMS
Reporter
jjansenvr

Duplicate of #2022

I'm treating this as a sub-issue of #2022 since the other issue has a broader scope. That's why I'll put this now in progress.


Import Trivy Scan Results (Image, FileSystem IaC)

Problem description
Hello, I need to import three scan types from Trivy: Image, FileSystem, and IaC. How can I do this in just one engagement? I was thinking of merging the three JSON report files into one by combining the results sections and then importing that into Dojo. Is this the best approach?
Steps to reproduce
Generate three Trivy scans (Image, FileSystem, and IaC) in JSON format and import them into a Dojo engagement using the 'Trivy Scan' option.
Expected behavior
A way to import the three report files generated by Trivy into just one engagement.
Deployment method (select with an X)

[X] Docker Compose
[ ] Kubernetes
[ ] GoDojo

The reason we have engagements in the DefectDojo data model is to allow the outputs of 1+ scan or manual effort to be combined and reported on as a single unit.

There no reason to combine the JSON unless you just want to.
Instead, create an engagement and then add 3 tests to that engagement, one for each Trivy scan type.
You can then choose to report/view the findings from one of those tests or combined at the engagement level.
HTH

The reason we have engagements in the DefectDojo data model is to allow the outputs of 1+ scan or manual effort to be combined and reported on as a single unit.

There no reason to combine the JSON unless you just want to.
Instead, create an engagement and then add 3 tests to that engagement, one for each Trivy scan type.
You can then choose to report/view the findings from one of those tests or combined at the engagement level.
HTH

The reason we have engagements in the DefectDojo data model is to allow the outputs of 1+ scan or manual effort to be combined and reported on as a single unit.

There no reason to combine the JSON unless you just want to.
Instead, create an engagement and then add 3 tests to that engagement, one for each Trivy scan type.
You can then choose to report/view the findings from one of those tests or combined at the engagement level.
HTH

I tric

The reason we have engagements in the DefectDojo data model is to allow the outputs of 1+ scan or manual effort to be combined and reported on as a single unit.

There no reason to combine the JSON unless you just want to.
Instead, create an engagement and then add 3 tests to that engagement, one for each Trivy scan type.
You can then choose to report/view the findings from one of those tests or combined at the engagement level.
HTH

O tried

The reason we have engagements in the DefectDojo data model is to allow the outputs of 1+ scan or manual effort to be combined and reported on as a single unit.

There no reason to combine the JSON unless you just want to.
Instead, create an engagement and then add 3 tests to that engagement, one for each Trivy scan type.
You can then choose to report/view the findings from one of those tests or combined at the engagement level.
HTH

MTH, I’ve tried, but the option ‘close old findings with this same engagement’ results in the elimination of findings from different analyses from Trivy.
tks;

The reason we have engagements in the DefectDojo data model is to allow the outputs of 1+ scan or manual effort to be combined and reported on as a single unit.

There no reason to combine the JSON unless you just want to.
Instead, create an engagement and then add 3 tests to that engagement, one for each Trivy scan type.
You can then choose to report/view the findings from one of those tests or combined at the engagement level.
HTH

MTH, I’ve tried, but the option ‘close old findings with this same engagement’ results in the elimination of findings from different analyses from Trivy.
tks;


The status of git-rustfmt

Hi,
I started looking into writing my own tool that wraps rustfmt and git together and then I stumbled into https://github.com/rust-lang/rustfmt/blob/master/Cargo.toml#L30
What's the status of this tool? I see it's not in rustup components. if it doesn't quite work yet I'd like to help working on it.
Thank you :)

What's the status of this tool?

To be honest, I'm not sure. I believe it's complete in terms of the original scope when it was added but it's not a core part of rustfmt like cargo fmt and rustfmt are. There were some semi-recent conversations about incorporating both format-diff and git-rustfmt (or at least their respective capabilities) as subcommands on rustfmt.
It's probably worth revisiting to codify the desired capabilities (format only modified files, format only modified lines, etc.)and determining what the delta is between the current and desired states, if any.

if it doesn't quite work yet I'd like to help working on it

:+1:

I'd like to start working on it, at least get it to a minimal working binary (right now it doesn't really work)
anyone wants to talk about behavior? or should I just go for trying to match git-clang-format?
(ie should I make it a git subcommand?)

Thank you for your interest in contributing to rustfmt!
TBH, I've never used git-clang-format myself, so I cannot say about it, but for git-rustfmt, I am thinking about making a tool with the following behavior:

It accepts similar arguments as git diff

git-rustfmt formats unstaged diffs
git-rustfmt --cached formats unstaged and staged diffs
git-rustfmt HEAD^ formats diffs contained in the last commit

It accepts similar command-line options as rustfmt

--check, --verbose, --edition, --config-path and --config

Thoughts?

Yeah,
Sound good, I think git-clang-format doesn't let you format unstaged changes, and if you go git clang-format COMMITT it will actually format the diff between HEAD(or current staged) and that commit.
I like the idea of trying to stay close to git diff, although what behavior should git rustfmt COMMIT do? if it formats only the diff in the commit maybe we should allow amending it, the problem with formatting the diff in the commit, is that it might conflict with HEAD/cached.
I think I'll start playing with it and adding features, mostly passing them through to git diff except the flags that rustfmt wants (I'm curious if clap will let me easily pass also the inputs after -- )
I'm also trying to decide if I want to use the current approach and execute git as a command, which let's me easily pass in the flags/inputs or should I use https://crates.io/crates/git2 which makes everything nicer but requires me to parse all the options/flags, What do you think?

The conversation on #1324 may be of interest for this thread

There's also cargo scout that may be worth checking out as well

For projects where you can rely on everything being formatted, instead of this seemingly-abandoned diff formatter, you can simply make git store only properly formatted code:
$ grep rust ~/.config/git/attributes
*.rs filter=rustfmt
$ grep rustfmt ~/.config/git/config
[filter "rustfmt"]
	clean = "rustfmt --edition=2021"

At the cost of force-reformatting all legacy code you interact with (which probably shouldn't exist in 2024 anymore), all diffs etc are always well behaved from here on.

At the cost of force-reformatting all legacy code you interact with (which probably shouldn't exist in 2024 anymore), all diffs etc are always well behaved from here on.

As someone who's editor is already set to fmt-on-save, I can tell you that there are many rust projects out there that simply refuse to use rustfmt, often deliberately.

You can disable the thing per git repository. I've had to do that too, but I mostly welcome knowledge that the project I'm looking at is being weird.


[Rest-server] oidc config configurable

Coverage decreased (-0.01%) to 48.425% when pulling cd0b1d4dad36e4cbd0c2e0eac6bff442db0d77ab on yuye/rest-server-path into 3be83aab63ddfa9d3376d2daa24f0277bc524937 on master.

better to have a default value

Default value is : /auth-configuration/oidc.yaml


Publish v1.4

Let's get it live for everyone

We already used 1.4.0 as a next release, so we'll need to tag this release as 1.4.1.

I think we can just change the dist-tag to latest when publishing? https://docs.npmjs.com/cli/dist-tag

This has been completed.


Add track icon

Thanks!! Lots of them!
Would you like to do same in the xecmascript track (xecmascript-231)? It's not mandatory, it's just if you want.


Example how to use with live video stream

An example would be nice to see how it can be used on a live capture from an USB cam for example.
BG, Thomas

Hi, you need to set source=0 for it to work with usb-cam. If it doesn't work can you give feedback?


missing wideresnet and utils file

Hi Guoqing,
Thanks for sharing the code! I am trying to run your code and find that in the cifar dataset file, the "utils" file is missed. And I found it in the clothing dataset file.
In addition, it seems like the "wideresnet" imported in "load_corrupted_data_mlg" is also missed, I didn't find it in other files.
Could you please tell me where to find it or did I miss anything?
Thx

Hi,
Thanks for reporting the issue! I pushed the utils for CIFAR (It's left out in previous push). Also, the dependency on wideresnet is removed (we tried it in pilot studies but it's not used in the paper).
Please report any additional errors you encountered.