Feature zwave preset modes

Breaking Change:
Nothing
Description:
Adds preset modes to the zwave climate integration.
There was an previous PR #25517 that had to be closed because of issues with the CI.
Related issue (if applicable): fixes  #25322
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
The documentation can stay unchanged
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

I'm afrait that there are many preset modes missing. I've added only the modes that are used by my eurotronic spirit z thermostats.

@Santobert , is the attribute hvac_action still functioning properly for you?  I just tried out your new code, and everything seems to be working except that hvac_action keeps showing up as the default value of "None".
I've been using this template to see the state: {{ state_attr('climate.downstairs_thermostat_cooling', 'hvac_action') }}.  It appeared to be working with the standard/constant hvac_modes in 0.96.5.

@DaveCo1701 Try it again. Should be working now. The tests should be passing now, too.

Thank you, everything appears to be functioning properly with my setup using the updated code.
The only two manufacturer specific modes I am using are the "Cool Econ" and "Heat Econ".  Both are now showing up automatically; I don't see a need to add them PRESET_MAPPINGS unless there is a benefit I'm unaware of.

@DaveCo1701 Awesome
@home-assistant/z-wave the PR is ready to be reviewed now.

hvac_mode are never none. You need map the correct hvac mode to the preset too

hvac_mode are never none. You need map the correct hvac mode to the preset too

While looking for an appropriate mapping I discovered that all presets have to be mapped to HVAC_MODE_HEAT_COOL. None of the existing preset modes can be mapped exclusively to HVAC_MODE_HEAT or HVAC_MODE_COOL. So HVAC_MODE_HEAT_COOL is now the default if there is a preset mode active.

@DaveCo1701 I think your climate devices are more complex than mine. Could you please test the latest changes in your field?

@DaveCo1701 I think your climate devices are more complex than mine. Could you please test the latest changes in your field?

Yes, I will test them tonight when I get home.

So it works with some quirks. I can setup my thermostat in two ways. Here's what I've found:
When Auto Mode is Enabled on Thermostat:
HEAT/COOL is an option, selecting a preset mode (Cool Econ for example), sends the thermostat to Cool Econ mode, which is what I would expect.  Home assistant shows that I am in HEAT/COOL mode with the selected preset mode (Cool Econ for example). To go to HEAT/COOL hvac_mode on the thermostat, I have to select a different hvac_mode and then go back to HEAT/COOL.

When Auto Mode is Disabled on Thermostat:
When HEAT/COOL is not an option, I can still select a preset mode, but the Operation mode (hvac_mode) in the front end goes blank. It then lets me select one option between the two lists (when selecting something in hvac_modes, it clears preset_modes; when selecting something in preset_modes it clears out hvac_modes.  This works, but doesn't seem to be what @pvizeli was looking for.

I think this is due to a difference in philosophy between the climate 1.0 updates in home assistant and the way zwave works.  If you look at Table 138 in the zwave command class spec (https://www.silabs.com/documents/login/miscellaneous/SDS13781-Z-Wave-Application-Command-Class-Specification.pdf), zwave Cool Econ (0x0C) is a hvac_mode just like Cool (0x02) or Auto (0x03). If I am understanding the way Climate 1.0 in HA works, it is trying to say Cool Econ is a subset of Cool rather than an alternative hvac_mode. @pvizeli / @Santobert , what do you think?

@DaveCo1701 Thank you for you testing. I was afraid that something like this happens. We try to push zwave into our understanding of hvac and preset modes, while zwave support only one of this. In the understanding of zwave there is only one mode. Adding a second one leading to the solution in commit 8b7e24d, where one mode is always None.
@pvizeli My opinion would be to add another hvac_mode which could be HVAC_MODE_NONE to get the mapping correctly. This would be the cleanest way. What do you think?

See comment to your answer

@Santobert , I believe the solution must ensure that hvac_mode still uses the standard heat, cool, heat_cool and off modes.  Looks like the front end relies on that to be able to use the thermstat cards; I'm also assuming that is needed to map to other integrations like Alexa, Homekit and Google Assistant (I haven't confirmed this). For this reason I don't think we could have the thermostat always in a HVAC_MODE_NONE state.
I think having a HVAC_MODE_NONE (or HVAC_MODE_MFG - manufacturer specific), and then using the presets to activate those specific modes is a good option.
Another one that jumps out at me is to have it setup that when the preset is set to Econ Cool, it sets the HVAC_MODE to Cool.  Similar for the heat function.  The part I don't like about that is it is a specific solution for one ZWAVE device; mappings would have to keep getting updated as more people discover issues.

| OFF | HEAT | COOL | HEAT_COOL | AUTO | DRY | FAN_ONLY
-- | -- | -- | -- | -- | -- | -- | --
NONE | off | heat | cool | auto |   | dry | fan
AUX |   |   |   | aux |   |   |
FURNANCE |   |   |   | furnance |   |   |
MOIST |   |   |   | moist |   |   |
ECO |   | Heat Eco | Cool Eco |   |   |   |
AWAY |   |   |   | away |   |   |
BOOST |   |   |   | full power |   |   |
MANUFACTURER SPECIFIC |   |   |   | manufacturer specific |   |   |
This is a complete mapping of all zwave modes (lower case) to a combination of HA hvac modes and HA preset modes. You can see that ECO is the only preset that maps not to HVAC_MODE_HEAT_COOL. To simplify the code and to increase reliability I've decided to map all unknown modes to presets. This makes the integration compatible with all kind of zwave climates without knowing their naming conventions.

The current solution could work. There is a default hvac mode that is generated out of a sorted list and the supported hvac modes. This is necessary because not all devices support HVAC_MODE_HEAT_COOL.
Furthermore you can unset a selected preset mode by setting preset to PRESET_NONE, which activates the default hvac mode.

Just to chime in on the Zwave part of it:
The ThermostatMode commandclass is the operating mode of the thermostat, aka the set operation.
It's defined here in OZW 1.6: https://github.com/OpenZWave/open-zwave/blob/master/cpp/src/command_classes/ThermostatMode.cpp#L94
and in 1.4: https://github.com/OpenZWave/open-zwave/blob/1.4/cpp/src/command_classes/ThermostatMode.cpp#L51-L68
All modes are enumerated.
For the actuall running state of the thermostat there is a seperate command class called ThermostatOperatingState.
These are enumerated here: in 1.6: https://github.com/OpenZWave/open-zwave/blob/master/cpp/src/command_classes/ThermostatOperatingState.cpp#L51-L53
Many thermostats only provides the ThermostatMode commandclass and not the ThermostatOperatingState at the same time. This is what's causing the misunderstandings of this.
I have not clearly understood the definition of the hvac_*** states yet, but somebody might connect the lines between my info and the new hvac modes/presets.
and in 1.4: https://github.com/OpenZWave/open-zwave/blob/1.4/cpp/src/command_classes/ThermostatOperatingState.cpp#L46-L64

@turbokongen I try to explain my current understanding of all these states:

ThermostatMode: This is the current operating mode of the zwave device. Home Assistant splits this into:

hvac_mode: this is a small set of climate modes that are very basic and most of the devices support at least a subset of these modes
preset_mode: these modes are special operating modes that are more complex and specific over all devices

ThermostatOperatingState: These states are mapped to hvac_action in Home Assistant. From this point of view, they have nothing to do with the other modes, since they are read-only.

@others: Am I right?

@turbokongen Thank you for explanation. I try to explain my current understanding of all these states:

ThermostatMode: This is the current operating mode of the zwave device. Home Assistant splits this into:

hvac_mode: this is a small set of climate modes that are very basic and most of the devices support at least a subset of these modes
preset_mode: these modes are special operating modes that are more complex and specific over all devices

ThermostatOperatingState: These states are mapped to hvac_action in Home Assistant. From this point of view, they have nothing to do with the other modes, since they are read-only.

Am I right?

This is my understanding as well.

The current solution should work. There is a default hvac mode that is generated out of a sorted list and the supported hvac modes. This is necessary because not all devices support HVAC_MODE_HEAT_COOL.
Furthermore you can unset a selected preset mode by setting preset to PRESET_NONE, which activates the default hvac mode.
Hope, I missed nothing :)
@DaveCo1701 can you please test the latest changes one last time?

@Santobert , I like the idea you've setup, but it doesn't seem to be switching modes as intended.  When selecting an HVAC_MODE, everything works fine.  When selecting a preset mode (Heat Econ or Cool Econ in my case), the corresponding HVAC_MODE (Heat or Cool in my case) isn't selected. The thermostat will move to the Heat Econ Mode or Cool Econ Mode, but when PRESET_NONE is selected, it doesn't do anything.  The thermostat does not change state and eventually HA shows the previous setting.  See attached screenshot videos for how my two thermostats are behaving (Upstairs doesn't have Heat/Cool Mode Enabled, Downstairs has Heat/Cool Mode Enabled).
Screenshot_Videos.zip

@Santobert , I like the idea you've setup, but it doesn't seem to be switching modes as intended. When selecting an HVAC_MODE, everything works fine. When selecting a preset mode (Heat Econ or Cool Econ in my case), the corresponding HVAC_MODE (Heat or Cool in my case) isn't selected. The thermostat will move to the Heat Econ Mode or Cool Econ Mode, but when PRESET_NONE is selected, it doesn't do anything. The thermostat does not change state and eventually HA shows the previous setting. See attached screenshot videos for how my two thermostats are behaving (Upstairs doesn't have Heat/Cool Mode Enabled, Downstairs has Heat/Cool Mode Enabled).

@DovaCo1701 Thank you.  Now it works

@Santobert , just tested again this morning. Selecting PRESET_NONE will change the thermostat over to the listed HVAC_MODE; looks like that is fixed.
When I go to COOL ECON on my thermostat that doesn't have HEAT/COOL, the HVAC_MODE goes to HEAT.  When I change the PRESET from COOL ECON to NONE, it switches me into HVAC_MODE HEAT.  Is this the expected behavior?

@DaveCo1701 I've assumed there are no devices that are able to cool and to heat but don't support HVAC_MODE_HEAT_COOL. So when Heat/Cool isn't supported I choose the first supported mode out of a sorted list. This list contains HEAT before COOL. I'll think about a solution...

@DaveCo1701 Should be fixed now.

@DaveCo1701 Should be fixed now. When selecting PRESET_NONE the device should jump to the currently show hvac mode. The currently shown hvac mode is either HVAC_MODE_HEAT if the device supports this and the substring heat is in the selected preset mode, or HVAC_MODE_COOL under the same circumstances. If neither Heat nor Cool matches, it shows the _default_hvac_mode that is selected from the list mentioned above.

@Santobert , just tried your updates, it's still functioning the same as it did last night (same as the videos I uploaded)

@Santobert , just tried your updates, it's still functioning the same as it did last night (same as the videos I uploaded)

Yeah, I should definitely be more alert when I fix bugs. :unamused:

Let run that on beta 👍 good work

@DaveCo1701 Please test this one last time. It should (hopefully) work now.

Works great now! Thanks @Santobert


Fix the session_len assignment logic

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
The scaling_factor can not be used to determine the context window size

Hi @lvhan028 Is it to solve this issue https://github.com/InternLM/lmdeploy/issues/2006

This may also solve a few recent issues on OOM.

This may also solve a few recent issues on OOM.

Yes.

Does rope_scaling_factor need to be updated in the corresponding documents, such as docs/en/advance/long_context.md and docs/en/inference/turbomind_config.md

Hi @lvhan028 Is it to solve this issue #2006

I haven't investigated #2006 yet.

Hi @lvhan028 Is it to solve this issue #2006

I don't think so. Detailed log is necessary for debugging #2006.

rope_scaling_factor

I think the long_context.md is fine. turbomind_config.md needs to be updated regardless of this PR.
I will update it in another PR.


Create dependabot.yml for pip

As this is a application to insert SBOM's into DT, so it should also do for itself what it tries to do for other software. It will update this "build(deps): bump certifi from 2023.7.22 to 2023.11.17"

It's perhaps smart also to add docker? (This would update alpine also )
build(deps): bump alpine from 3.17 to 3.18
  - package-ecosystem: "docker"
    directory: "/"
    schedule:
      interval: "daily"


[Sample Onboard Request] Excel-Add-in-Mail-Merge

Owner:
SiruiSun-MSFT
ID:
Excel-Add-in-Mail-Merge
Title:
Create an Excel Mail Merge Add-in
Description:
This sample demonstrates how to use the Microsoft Graph JavaScript SDK to send emails in Excel from Office Add-ins.
Tags:
"JS", "Excel", "SSO", "Graph", "Office Add-in"
Time:
10mins to run
Configuration:
Ready for local debug
Thumbnail:
https://github.com/OfficeDev/Office-Samples/blob/main/Excel-Add-in-Mail-Merge/assets/taskpane.png
(Optional) Demo GIF:
https://github.com/OfficeDev/Office-Samples/blob/main/Excel-Add-in-Mail-Merge/assets/sampleDemo.gif
(Source code in this Repo) Source Code PR:
In another repo
(Source code NOT in this Repo) Sample URL:
https://github.com/OfficeDev/Office-Samples/blob/main/Excel-Add-in-Mail-Merge/
(Optional) Minimum Teams Toolkit Version:
Teams Toolkit version requirement to run the sample - minimum version
(Optional) Maximum Teams Toolkit Version:
Teams Toolkit version requirement to run the sample - maximum version

Reviewed README file, suggest to make the following update:

In Prerequsites, add one item to install VS Code version 5.6.0+ (version that contains WXP features）：

Do not use M365 Toolkit now, since the rebranding thing is not finalized. Now use Teams Toolkit as the official name:

The command name should be consistent with the screenshot:

updated

[like]  Xuan Zhou reacted to your message:

From: Herman Wen @.>
Sent: Thursday, March 21, 2024 7:09:00 AM
To: OfficeDev/TeamsFx-Samples @.>
Cc: Author @.***>
Subject: Re: [OfficeDev/TeamsFx-Samples] [Sample Onboard Request] Excel-Add-in-Mail-Merge (Issue #1219)
updated
—
Reply to this email directly, view it on GitHubhttps://github.com/OfficeDev/TeamsFx-Samples/issues/1219#issuecomment-2011349817 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHZG6N3DQPDBCI2TBM7VFEDYZKBQ3BFKMF2HI4TJMJ2XIZLTSSBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVI3DOMRQGY2DKNRZGCSG4YLNMWUWQYLTL5WGCYTFNSWHG5LCNJSWG5C7OR4XAZNMJFZXG5LFINXW23LFNZ2KM5DPOBUWG44TQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKJTGQ4DEOBYGE2DDAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDEMJZGY2TMOBQGA2YFJDUPFYGLJLMMFRGK3FFOZQWY5LFVI3DOMRQGY2DKNRZGCTXI4TJM5TWK4VGMNZGKYLUMU.
You are receiving this email because you authored the thread.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

The linked page of "Sideload Office Add-ins to Office on the web" has multiple sections that could be confusing to users to follow.


Possible label leakage problem with the link prediction task

This happens for undirected networks like PPI. The link prediction task class
https://github.com/THUDM/cogdl/blob/4ed7838018400377dae9da30017399f56585208f/cogdl/tasks/link_prediction.py#L116
reads the adjacency matrix directly without removing duplicates, this means the the edge list would have (x, y) and (y, x) at the same time for every edge.
(x, y) and (y, x) are referring to the same edge, producing the same cosine similarity for x and y in  evaluation later. However, the training-test splitting process treats them as independent edges. As a result, a great portion of the generated test edges are also in the training set, just with a reversed order of two ends.
I have tried resolving this label leakage issue, and I can only get about 0.8 ROC-AUC on PPI instead of over 0.9 reported in your leader board.

Hi @yangkcatiu,
Thank you for reporting this to us. We will fix this issue as soon as possible.


⚠ ClamAV has degraded performance

In bcce021, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 119 ms

Resolved: ClamAV performance has improved in 9400a84.


dayWrapper is broken in the new RBC

Do you want to request a feature or report a bug?
Bug
What's the current behavior?
Nothing gets returned in dayWrapper.

What's the expected behavior?

Here is it: https://codesandbox.io/s/pk37nmyp0x


Feature Request | Question: Reference the input value in the error message?

On validation, I would like to be able to reference the input value in the error message.
For example, given that my schema looks like this...
const mySchema = z.object({
  numberOfDays: z.number({
    invalid_type_error: "Sorry, that is not a valid number."
});

...then I would like to instead be able to return an error message like:
"Sorry, 'seven' is not a valid number."
I'm imagining something like either:
invalid_type_error: "Sorry, '{{value}}' is not a valid number."
Or better yet:
invalid_type_error: (val) => `Sorry, '${val}' is not a valid number."
Is this already possible? If not, could this be added in the future?

Is this what you are looking for?
const mySchema = z.object( {
    numberOfDays: z.number( {
        errorMap: ( issue, ctx ) => {
            if ( issue.code == 'invalid_type' )
                return { message: `Sorry, '${ ctx.data }' is not a valid number.` }
            return { message: ctx.defaultError }
        }
    } )
} )

If you found my answer satisfactory, please consider supporting me. Even a small amount is greatly appreciated. Thanks friend! 🙏
https://github.com/sponsors/JacobWeisenburger


example not show data vlaue

hi, sir
why I use  install of npm , can  see map ,but value not show data value. .
think you

@xuhande Thanks for your feedback. We'll need a little more information to be able to help you.
E.g. what sequence of npm commands are you using? npm install, npm start?
Are you trying to run deck.gl examples or writing your own app? etc.

Same issue with me. I am trying to make 3d-heatmap work using HexagonLayer. The data that I am providing to HexagonLayer is in the format [(position:[lon,lat]}...]. I have run npm install and then exported the variable, then npm start. it is not getting rendered. The problem is only with HexagonLayer. I have tried other layers as well which are working fine. Please suggest a solution  as soon as possible

The problem is only with HexagonLayer.

We do have an example for the HexagonLayer (examples/3d-heatmap). I just tested and noticed that it didn't run using npm start but did run using the npm run start-local script (which builds against the local source code instead of an installed version of deck.gl).
Looks like a bug that needs to be fixed asap, thanks for reporting it!
@heshan0131 @shaojingli

This is simply because we forgot to include #590 to the 4.0-release branch

Fixed in v4.0.6. Please update deck.gl installation and try again. Thanks
@xuhande @anmolgupta


CLI should allow user to specify web action extension when creating api

the CLI when creating one route it should allow the user to specify the action name with no extension (which is the same at .http) or include the extension at the end of the action name for example:
wsk api create /basepath /path verb FQNAction[.extension]
Translate to following examples:
wsk api create /store /pets get myaction

With no extension this is the same as .http
wsk api create /store /pets get myaction.http
This is being explicit to use .http
wsk api create /store /pets post myaction.json

wsk api create /store /pets get myaction.html

And son on for the other extensions
The backend today doesn't provide a way to know the list of valid extensions, this would be nice to have for the CLI or CLI helper actions to use to validate that the user used one of the valid actions.
For now I think is OK to hardcode the list of valid extensions in the CLI or CLI helper actions.

After discussing with @mdeuser over the design on how to specify here the final proposal

have an optional flag to specify the content type extension for the response when forming the web action url to be use by the API Gateway
change the default to .json extension

  --response-type CONTENT_TYPE_EXTENSION possible values json, http, text, svg (default json)

$ wsk api create -h

Usage:
  wsk api create ([BASE_PATH] API_PATH API_VERB ACTION] [--response-type EXTENSION] | --config-file CFG_FILE)  [flags]

Flags:
  -n, --apiname string         Friendly name of the API; ignored when CFG_FILE is specified (default BASE_PATH)
  -c, --config-file CFG_FILE   CFG_FILE containing API configuration in swagger JSON format
  --response-type EXTENSION EXTENSION with possible values json, http, text, svg (default .json)

This will allow the following examples:
wsk api create /store /pets get myaction
 (This default to --response-type json)
wsk api create /store /pets get myaction --response-type json
wsk api create /store /pets post myaction --response-type http
wsk api create /store /pets get myaction --response-type html
wsk api create /store /pets get myaction --response-type svg

Presumably this means that if an http extension is used, the API Gateway would pass on the headers and status code provided by the action?

That's correct

Closed by #2149


Online version down (Application error)

I am trying to access the online Heroku app, yet the website displays an error:

Thank you,
Vasilis

Hi @vmavromatis yes, it's been a bit popular this month and we've used our quota on Heroku.
I'm trying to bring up a copy on Google appspot at the moment. Please bear with us.
Thanks for reporting!

Keep up the good work, looking forward.

Would you be able to test the backup version at http://openapi-converter.appspot.com/ ?

Would you be able to test the backup version at http://openapi-converter.appspot.com/ ?

Gladly. However I paste my JSON and get redirected to:
http://openapi-converter.appspot.com/api/v1/convert with a page body that prints:
{
  "status": true
}

If you untick the validate box - does that fix it? I should probably ensure that defaults to off...

Yes, that was it! Thank you, seems to have worked fine.

Thanks for testing. I'll leave this issue open until the Heroku quota resets on October the 1st.

https://openapi-converter.hrmny.pw/
made my own mirror idk why

Thanks!

App is back up again, thanks again for reporting.

Happened again this month

@MikeRalphson Not sure if it's any use but you can extend to 1000hrs with a CC
https://devcenter.heroku.com/articles/free-dyno-hours#usage

@vmavromatis thanks, but I've got a grandfathered account with 1,550 free hours and I'm still running out! I need to move an app elsewhere but still deciding which one and where.

@MikeRalphson There's an open-source alternative https://github.com/githubsaturn/captainduckduck which you could setup on your own server or AWS. I haven't tried it but there's a reddit thread about it here: https://www.reddit.com/r/programming/comments/78lwoy/open_source_heroku/

my mirror is still up if anyone needs it

Thanks @ForsakenHarmony. Heroku version available again.

References updated to hopefully long-term URL: https://mermade.org.uk/openapi-converter


Use User model fields in RLS (row-level security)

I've not yet gotten very far into superset, so forgive me if there's an important piece I'm missing.
Is your feature request related to a problem? Please describe.
Sometimes there is a really big pattern of generating roles and row-level security filters for purposes that do not fit the concept of static application roles very well, and instead are better thought of as dynamic identity-based attributes ("dynamic" from the application's perspective, not necessarily meaning that they'd change over time for a specific person).
For example, think about trying to make a dashboard for each employee in a company to view their own payroll deductions. Which employees exist is not a matter of "application setup" or "security model", it's a matter of user management. Unless there's a piece of Superset's RLS that I'm missing, each employee would need to have their own role, and each role would need to have its own filter. And if any of that setup failed, they'd be able to see everyone's data.
This is made especially important by the fact that Superset doesn't query data from a relational model of its own (like Power BI does, for example), meaning that each of the ultimate data source tables has to have its own RLS filters (whereas if it had its own relational models, security filters could be applied to related tables)[^1].
[^1]: This propagation of security filters would be like if a whole bunch of the queries for a given dashboard came from a single SQL statement with multiple queries, and they all referenced a single "security" CTE, and that CTE took a filter parameter.
Describe the solution you'd like
Add some kind of RLS filter syntax, (autocomplete? :grin:), and validation for User model attributes to the front end, and make use of them in the back end. All the other concepts such as filters attached to roles, and users assigned to roles, and so on, would be unchanged. Flask-AppBuilder makes it pretty easy to augment the User model, and I wonder if Superset could by default add a bunch of generic custom attributes.
Describe alternatives you've considered
In the context of the example, adding a user-specific role for each user.
Additional context

A few user attributes are already provided in functionality like this.

Hi @bjornhauge, I'm facing the same problem you have described. I see that the number of RLS filters and Roles would have linear to exponential growth if I go with the creation of static filter clauses for users getting onboarded in an application I'm working on. I see that the discussion is closed but I really couldn't understand the answer or how I can take this forward in a more efficient manner. I would be grateful if you could provide some insights on how you've managed to solve this.
Thanks in advance!


[Bug]

Describe the bug
When using:
var requestor = teamsContext.AsTeamsChannelAccount(turnContext.Activity.From);
The resulting TeamsChannelAccount object doesn't have any of the Teams specific information added. For example
request.UserPrincipalName is always null
request.Surname is also always null
SDK Version
4.0.0-beta1
Expected behavior
Those properties should be populated

I'm experiencing this bug as well... Any solution available yet?

Same problem here. :/


hover effect added on social media icons for users in main.css file.

social media icons zoom in when hover...

@itsbhavsagar Please create an issue.

Could you please assign it to me?
As this pr is having conflicts, I can give a PR on the same with no conflict.. :)

It has been done in another PR.


WIP: Client certificates for authentication purposes.

Some organisations require authentication via certificates for security purposes. This PR allows for that, by specifying the CA cert in the TLS configuration block, one is able to require certificates to be presented during a request.
Refs: #278
I guess this work could be continued for #280, #279

Could you update the configuration documentation, as well?

@stevvooe Done.

@stevvooe Updated to address concerns.

LGTM!
Required review: @diogomonica @NathanMcCauley

This looks great.
What about adding a test that shows that all the CAs listed are actually loaded into the CertPool?
Besides that, LGTM

@diogomonica Perhaps testing would be nice... Although, I'm unsure how to do that given the current state of my code & the cmd/registry/main.go

LGTM

@dmcgowan fixed. :)

@sthulb We have #215 to fix the main file, with the use case being an "importable registry service". Please excuse the mess.
A simple test in the configuration package to make the listed CA files are populated would be sufficient.
Removing WIP, since we are likely to merge this soon.

I've added the CA to the configuration_test.go, but I'm not happy with it. It makes the tests brittle.

@sthulb Those configuration tests are brittle as they come.
LGTM!

@stevvooe yep.. but theres not much that can be done without changing the HTTP config block


Bump pkg.go.dev version

Problem
I recently tried to run a VMM with the provided SDK but it seems that MachineConfiguration model isn't up to date on pkg.go.dev and I'm unable to set Smt field. I'm still able to use HtEnabled but it's no recognized by Firecracker server.
Solution
Bump the version on pkg.go.dev will solve the problem according that problem has been solved few weeks ago.
Screenshot

Will be closed by #444


Emote parsing bug

Describe the bug
Chatterino seems to have some trouble parsing a certain combination of emotes in a message, seems to be related to the comma character
To reproduce
Kreygasm, = DansGame / PogChamp pepeLaugh
Screenshots

Chatterino version
Chatterino Nightly 2.1.7 (commit 2e39dd4d9, )
Operating system
Win 10 1909 18363.720

In Webchat without any extensions it looks like this https://i.nuuls.com/QGMO1.png

Webchat: https://i.imgur.com/pjBU5hm.png (with FFZ & BTTV)
Chatterino: https://i.imgur.com/a9Ya3VQ.png

has using emotes with a trailing comma in web chat been around? seems like a recent change to me

has using emotes with a trailing comma in web chat been around? seems like a recent change to me

I think emotes working with punctuation has worked for a long time on webchat (if that's what you mean)

is this fixed?

no, you can write the message and see for yourself


install with Homebrew

Is there a way to install wavtap with homebrew?

@hardmantoplz: yes, kind of. It is not fully functional at the moment.
brew cask install wavtap

Struggling with kext loading on macOS 10.13 High Sierra though; see technical notes on kext loading from Apple. Will try to figure it out.


README: add link to project website

The website is already linked as part of github's repo's metadata but its placement at the top can be easy to miss:

@dmehra @demmer

Although redundant can you add this also to the "to learn more" section.

Done (could use a better wording suggestion).

+1 either way


planviewplot superceded by planviewplotcartopy

Codecov Report
Patch coverage: 33.33% and project coverage change: +4.22 :tada:

Comparison is base (4661173) 29.54% compared to head (8d6b09e) 33.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   29.54%   33.76%   +4.22%
==========================================
  Files           1        1
  Lines          88       77      -11
==========================================
  Hits           26       26
+ Misses         62       51      -11

Impacted Files
Coverage Δ

src/GGplot.jl
33.76% <33.33%> (+4.22%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Pkl IntelliJ plugin incompatible with IntelliJ release 2024.2

IntelliJ 2024.2 was released on August 7, 2024.
The Pkl IntelliJ plugin is incompatible with the release

Fixed in 0.29.0


deps bump benchmakr from 1.5.6 -> 1.8.0

Proposed changes
To support some new methods used in #21074
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.85 seconds
stream load tsv:          454 seconds loaded<PHONE_NUMBER>9 Bytes, about 157 MB/s
stream load json:         24 seconds loaded<PHONE_NUMBER> Bytes, about 93 MB/s
stream load orc:          57 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          28 seconds loaded 861443392 Bytes, about 29 MB/s
insert into select:          70.3 seconds inserted 10000000 Rows, about 142K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230625031621_clickbench_pr_166935.html

run buildall

LGTM


[TFLite] Add support for GELU conversion

This commit adds support for converting a TFLite fp32 GELU operation to Relay.
Also includes some neighbouring cleanup of version checks to silence warnings.
cc @leandron @ekalda

@tvm-bot rerun

CI errors seem unrelated. Merging it now, thanks @lhutton1 !


Error config redis

When the plugin turns on
https://hastebin.com/avuqanajen.md
When the plugin hangs up
https://hastebin.com/gemicodine.sql

See the replies on #265.
It is not a LuckPerms issue.
Failed connecting to host <IP_ADDRESS>:6379


[BUG]  manuel downloader FileNotFoundError

Hi, the manuel downloader isn't working for me.
here is the output I get:
2023-03-09 10:25:17,773: INFO    downloader.py -> File output/S15-E52-one-piece.mp4 added to queue. Exception in thread Thread-2 (download): Traceback (most recent call last):   File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.2800.0_x64__qbz5n2kfra8p0\lib\threading.py", line 1016, in _bootstrap_inner     self.run()   File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.2800.0_x64__qbz5n2kfra8p0\lib\threading.py", line 953, in run     self._target(*self._args, **self._kwargs)   File "C:\Users\Gaming\Desktop\aniworld_scraper\src\logic\downloader.py", line 17, in download     with open(file_name, 'wb') as f: FileNotFoundError: [Errno 2] No such file or directory: 'output/S15-E52-one-piece.mp4'
Maybe you can give me hint whats wrong
thx in advance

@LuciDuki Please set Line 23 to debug.
From: setup_logging("info")
To: setup_logging("debug")
After that send me the Logging output.
And a fyi the Microsoft Store Version of Python has alot of issued from what i have seen and got as bug reports. Just so you know that could be a issue but we will first look at the log.

Hi, debug is enabled:
2023-03-09 13:16:01,354: DEBUG   We have Read Permission 2023-03-09 13:16:01,354: DEBUG   We have Write Permission 2023-03-09 13:16:01,701: DEBUG   manuel_episode_download.py -> Link to redirect is: https://aniworld.to/redirect/591100 2023-03-09 13:16:47,283: DEBUG   manuel_episode_download.py -> Return is: https://vidoza.net/embed-2uqviwbrd5ea.html 2023-03-09 13:16:47,284: DEBUG   search_for_links ->Enterd Vidoza to cache 2023-03-09 13:16:47,516: DEBUG   search_for_links ->Exiting Vidoza to Cache 2023-03-09 13:16:47,516: DEBUG   manuel_episode_download.py -> Vidoza Cache URL is: https://str26.vidoza.net/nvl4fa2g7ueuieno3wqq3gh2hekgjmylst2nijbqcea67x4humbdtfwlmdra/v.mp4 2023-03-09 13:16:47,517: DEBUG   downloader.py -> Entered Downloader. 2023-03-09 13:16:47,518: DEBUG   downloader.py -> Entered download with these vars: Link: https://str26.vidoza.net/nvl4fa2g7ueuieno3wqq3gh2hekgjmylst2nijbqcea67x4humbdtfwlmdra/v.mp4, File_Name: output/S15-E52-one-piece.mp4 2023-03-09 13:16:47,518: INFO    downloader.py -> File output/S15-E52-one-piece.mp4 added to queue. Exception in thread Thread-2 (download): Traceback (most recent call last):   File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.2800.0_x64__qbz5n2kfra8p0\lib\threading.py", line 1016, in _bootstrap_inner     self.run()   File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.2800.0_x64__qbz5n2kfra8p0\lib\threading.py", line 953, in run     self._target(*self._args, **self._kwargs)   File "C:\Users\Gaming\Desktop\aniworld_scraper\src\logic\downloader.py", line 17, in download     with open(file_name, 'wb') as f: FileNotFoundError: [Errno 2] No such file or directory: 'output/S15-E52-one-piece.mp4'
Python 3 is actually installed, also the store version as it seems. After work i will change it to the correct python and try again ^^
thx

@LuciDuki pull the image again. Forgot to add the mkdir. (Manuel is not used often so i didnt check.

fixed


What are the shortcomings you have noticed in the framework? [Required]
我自己尝试了，将吐司从右边平移滑动显示的动画，但是都失败了。
Has a similar suggestion been made in the issue list? [Required]
No
Is the suggestion mentioned in the framework documentation? [Required]
No
Did you consult the framework documentation but couldn't find a solution? [Required]
Yes
How do you suggest improving it? [Optional]
No response

小伙子，怎么自定义 Toast 动画，框架文档上面不是有写了吗？

超过两个星期没有响应，自动关闭此 issue。


Using shared connection instead pool between requests

I have created an issue on mysql2 github page about an error that appear after many concurrently requests. The app uses knex to connection on MySQL.
The app logic needs an shared connection_id() (mysql session) between requests. It is because the app needs to create temporary tables to be used on a second request, so to make this possible, I use an singleton pattern to globally save the connection.
If I remove pool options from the knex connection, the lib will create many connection_id(). I need the same connection, so I use pool like this:
            pool: {
                min: 0, max: 1
            }

The error is: Error: Too many connections. So, how to share the same connection (not an pooled one) between request using knexjs as the main lib.
node-mysql2 issue: https://github.com/sidorares/node-mysql2/issues/606

I found this on documentation
connection (http://knexjs.org/#Builder-connection)
(incomplete) - This feature was incorrectly documented as functional.
If implemented, the method would set the db connection to use for the query without using the connection pool.
How to implement it?

Here is the issue talking about the connection method https://github.com/tgriesser/knex/issues/1878
Currently you might be able to reuse the same connection if you create dedicated knex instance with min: 1, max : 1 and set all timers in that way that connection will not be released when idling (not sure how pool implementation does it currently).
About the method setting connection it would need to be defined first how people would like it to work and after that it could be documented, implemented and tested.

Here is also some hacky information how to set connection for query builder manually https://github.com/tgriesser/knex/issues/2090

And this is probably also somewhat related https://github.com/tgriesser/knex/issues/1681

Here is the code I am using to share connection to the same session. Everything is ok except that when I call knex.destroy(), the session connection does not end, but it take 30 seconds to do so.
import { Me } from './Me';
import * as knex from 'knex';

export class BucketDb {

    private static _connection: any = {}

    public static connect(databaseData) {

        if (!this._connection[Me.profile().sessionId]) {
            this._connection[Me.profile().sessionId] = knex({
                client: 'mysql2',
                connection: databaseData,
                pool: { min: 1, max: 1 }
            });
        }

        return this._connection[Me.profile().sessionId];

    }

    public static destroyBucketInstance() {
        const self = this;
        this._connection[Me.profile().sessionId].destroy();
    }

}

I have tried to destroy connection manually too, but this workaround does not destroy it.
this._connection[Me.profile().sessionId].raw('kill (select connection_id())');

When listing process with the mysql command show processlist; after calling destroy method to close pool connection (like the 5570 pool id above), it where not closed.

Does knex.destroy() immediately close  the connection?
Is there an way to call directly connection.end() to manually close those opened pool?

You can create and destroy connection for per request
const config = {
    client: 'mysql2',
    connection: {
      host: process.env.DB_HOST,
      user: process.env.DB_USER,
      password: process.env.DB_PASS,
      database: process.env.DB_NAME
    },
    pool: {
      min: Number(process.env.DB_POOL_MIN),
      max: Number(process.env.DB_POOL_MAX)
    },
    acquireConnectionTimeout: Number(process.env.DB_TIMEOUT)
  }
  var Knex = require('knex')

  this.functionname = () => {
    var output = {}
    return new Promise(function (resolve) {
      var knex = new Knex(config)
      knex(tablename)
        .select()
        .then((result) => {
          if (result.length > 0) {
            output.error = false
            output.result = result
          } else {
            output.error = true
          }
          resolve(output)
        })
        .catch((err) => {
          err.error = true
          resolve(err)
        })
        .finally(() => {
          knex.destroy()
        })
    })
  }

@nareshsr That's gonna blow up your server resources on heavy load.

@nareshsr That's gonna blow up your server resources on heavy load.

Every connection gets created and closed after query execution.

@nareshsr That doesn't matter. What eats a lot of resources is creating the connection in the first place. Multiply that resource usage with amount of requests per seconds and your server will be choking in no time.

#1878 actually made it possible to pass to query builder, which connection to use to execute the query


issue regarding Install dependency for HCodecs version

While installing Euterpea from cabal using command "cabal v1-install Euterpea", I found HCodecs-0.5.1 was required and always failed while building
So I check on Hackage.Haskell.org, figured out there exist HCodecs-0.5.2;
As assuming the fail of build is due to out-of-date version, I separately install HCodecs-0.5.2, (which run succeed), then tried run "cabal v1-install Euterpea" again, to my surprise, the install did not skip version check for HCodes even I installed a latest version of HCodecs-0.5.2
Here is the log the reflecting my separate install of HCodecs-0.5.2 & the fail building of installing HCodecs0.5.1:
PS C:\WINDOWS\system32> cabal v1-install HCodecs-0.5.2
Resolving dependencies...
Downloading  fail-<IP_ADDRESS>
Downloaded   fail-<IP_ADDRESS>
Starting     fail-<IP_ADDRESS>
Building     fail-<IP_ADDRESS>
Completed    fail-<IP_ADDRESS>
Downloading  HCodecs-0.5.2
Downloaded   HCodecs-0.5.2
Starting     HCodecs-0.5.2
Building     HCodecs-0.5.2
Completed    HCodecs-0.5.2
PS C:\WINDOWS\system32> cabal v1-install Euterpea
Resolving dependencies...
Starting     HCodecs-0.5.1
Building     HCodecs-0.5.1
Failed to install HCodecs-0.5.1
Build log ( C:\Users\12798\AppData\Roaming\cabal\logs\ghc-8.10.2\HCodecs-0.5.1-KovArVTnpFnLaEvHYYD8GP.log ):
Preprocessing library for HCodecs-0.5.1..
Building library for HCodecs-0.5.1..
[1 of 7] Compiling Codec.ByteString.Builder ( src\Codec\ByteString\Builder.hs, dist\build\Codec\ByteString\Builder.o )
src\Codec\ByteString\Builder.hs:79:1: warning: [-Wunused-imports]
The import of Data.Semigroup' is redundant       except perhaps to import instances from Data.Semigroup'
To import instances alone, use: import Data.Semigroup()
|
79 | import Data.Semigroup
| ^^^^^^^^^^^^^^^^^^^^^
[2 of 7] Compiling Codec.ByteString.Parser ( src\Codec\ByteString\Parser.hs, dist\build\Codec\ByteString\Parser.o )
src\Codec\ByteString\Parser.hs:143:5: error:
fail' is not a (visible) method of class Monad'
|
143 |     fail  err  = Parser $ (S _ _ bytes) ->
|     ^^^^
cabal: Leaving directory 'C:\Users\12798\AppData\Local\Temp\cabal-tmp-13328\HCodecs-0.5.1'
cabal.exe: Error: some packages failed to install:
Euterpea-2.0.7-16Dwojok2ejBacdiDIytTu depends on Euterpea-2.0.7 which failed
to install.
HCodecs-0.5.1-KovArVTnpFnLaEvHYYD8GP failed during the building phase. The
exception was:
ExitFailure 1
that is mist confusing, for the version check did not skip Hcodecs-0.5.1

Merging #38 will fix this.

Merging #38 will fix this.

actually I just tried install.. so how would that fix

Okay I just want to share the solution here after having another hints from StackOvewrflow:
using an extra param in cabal install:
cabal v1-install --allow-newer Enterpea
link: https://stackoverflow.com/questions/64841853/issue-while-haskell-instaling-euterpeas-dependency-hcodecs-did-not-skip-versio/64842069#comment114649123_64842069
should have solved the dependencies check;
I could finish the function check for Euterpea by now, hoping this add up could help anyone who may strugle with install from cabal and dont want to "get hand dirty" by further configure cabal's self configure file..

Although I hope Euterpea could have this solution label in instruction before they modified their Euterpea.cabal, so until then I think it might be better to keep this issue open and let someone later struggling see this


Make offset and paged paginators links consistent

Per the pagination spec (http://jsonapi.org/format/#fetching-pagination)
previous links should be 'prev'.  It was done this way in the paged
paginator but not the offset.
I left the original key name in there for backwards compat and updated the tests to expect an additional key. LMK if you want me to add a deprecation message and notes around the tests where the link count has changed.

@coryodaniel Thanks. I think we should just remove support for previous and stick with prev to stay compliant with the spec. No sense preserving an incompatible (with the spec) way of working. This will go into a beta release and I'll call out the change in the release notes.

Updated the PR tests and class to not include 'previous'

@coryodaniel Thanks!


Use consistent rounding strategy when converting a duration to a tick.

Ensure that the same strategy of rounding to the nearest tick is used
both when scheduling a timeout and in wakeup thread. Fixes issue #383.

Thanks. Merged: 18d16388b37f8d96618587c87cbd095e115e8e7d


Tapir budget request

Scope
This budget request is to fund Tapir for the month of May for the work already done and the following 2 months, allowing Tapir to continue contributing to the activities outlined in the continuous activity plan.
Plan
Continuous activity:

Internal security reviews of the yearn ecosystem
Risk scoring & risk score maintenance

About the Risk Assessment
I have already worked on and determined criteria for the risk scores, which you can find here.
I have also compiled all the V3 strategies into an Excel sheet.
From now on, for every strategy I review, I will assign scores according to the criteria and update the Excel sheet. Additionally, I am pairing up with Marco to craft a brand new UI for the Yearn Risk Assessment Dashboard, which is already 25% complete and should be ready for an MVP by next month.
About the future of ySecurity
Meanwhile, during this temporary BR, I am planning to recruit a new ySecurity group with clear goals and a roadmap. The ySecurity group will be responsible for all security-related aspects within Yearn, including security reviews of strategies, risk assessment, and maintenance. Additionally, we can explore the development of bots for monitoring external protocol contracts, including depegs, bad debt, and timelock transactions, similar to the SONNE timelock listener and the Pearl treasury’s DAI bot.
Furthermore, the new BR will specifically recognize Marco's contributions to the Yearn Risk Assessment Dashboard. Most likely, he will receive a one-time grant for the excellent work he has done in building it
Deadline
2024-07-31
People
tapir
Money
One time backpay for the work done in May, $12k DAI
Monthly $12k DAI for June and July
Amount (Total)
36000 DAI
Wallet address
0x80c9aC867b2D36B7e8D74646E074c460a008C0cb
Reporting
Monthly

Are we paying people 12k a month for maintaining a spreadsheet and writing a simple 2 page doc?

Are we paying people 12k a month for maintaining a spreadsheet and writing a simple 2 page doc?

The main task is conducting internal security reviews of every contract that Yearn ships. Additionally, each V3 strategy that is reviewed will be included in the risk document. Assessing the risk according to criteria and justifying the scores with comments will be a relatively simple task, considering the hard work of creating the criteria is already done

How many internal security reviews are you conducting per day/week?
Or maybe the number of hours spent/week is a better metric for this?

How many internal security reviews are you conducting per day/week? Or maybe the number of hours spent/week is a better metric for this?

Good question, working 8 hours a day, full-time, as I have been doing for years under the hood of ySecurity.
I appreciate the thorough questioning. I assumed that the people reviewing this budget would be the contributors who already know my contributions. However, I was wrong, as this is a public budget request for the YFI ecosystem. Please let me know if you have any other questions regarding this budget request!

It would probably help build more confidence in this type of requests (especially after the last hack) if this sort of budget requests would be more data driven. Like, you mention 8 hours a day, but is the quantifiable in any way? other than that 2 page document and that spreadsheet as I image those didn't take ~200 hours/month to write.
If this sort of data is available to yBudget it's great as they are the ones that ultimately make the decision but it looks completely opaque from the outside and it shouldn't really be.

I agree. I have been conducting security reviews of all Yearn-related code, from strategies to completely new products like yETH and Yearn Boosted Staker. There haven't been any hacks so far, which might be a good indicator of the quality of my work.
You can also check the previous "Security Team Budget Request" to see the reviews that's done previously in given time period
You can also check the strategies that are reviewed in both v2/v3 here:
https://github.com/orgs/yearn/projects/27/views/18

Are we paying people 12k a month for maintaining a spreadsheet and writing a simple 2 page doc?

Disrespectful comment.
I feel compelled to reply as someone that's been on the receiving end of Tapir's sc reviews.
He's been delivering audit-quality reviews for the dev team for a long time. Has also been helping formulate v3 strategy dev patterns and best-practices.
we should be luck to have him (many examples of this).

Are we paying people 12k a month for maintaining a spreadsheet and writing a simple 2 page doc?

Disrespectful comment. I feel compelled to reply as someone that's been on the receiving end of Tapir's sc reviews. He's been delivering audit-quality reviews for the dev team for a long time. Has also been helping formulate v3 strategy dev patterns and best-practices.
we should be lucky to have him (many examples of this).

Totally agree with @wavey0x.
@tapired has been doing a great job making internal security reviews. And it is not only "maintaining a spreadsheet and writing a simple 2 page doc".

Disrespectful comment.
I'm sorry wavey if it sounded disrespectful, that wasn't my intention.
The issue and my frustration comes from the lack of visibility into the work being done and after the most recent hack I hope you understand why I would be nervous about a tipic like protocol security.

Again, I'm deeply sorry if it sounded harsh or anything like that, that wasn't my goal, but I would still like to see a more results/data driven approach to this type of budget requests.


Fix broken daemon startup with master

Since the daemon flag was deprecated and replaced by the daemon subcommand, the run engine should use the subcommand and only the flag for older version.
Updated docker versions which are tested to include the last 2 releases.
Also the jenkins has been updated to no longer attempt to run the distribution tests on a centos machine (which would fail because it was trying to use aufs).

Current coverage is 57.55%

Merging #1316 into master will decrease coverage by -0.10% as of 8d1c44f

@@            master   #1316   diff @@
======================================
  Files          116     116
  Stmts        10471   10471
  Branches       717     719     +2
  Methods          0       0
======================================
- Hit           6037    6027    -10
- Partial        717     719     +2
- Missed        3717    3725     +8

Review entire Coverage Diff as of 8d1c44f

Uncovered Suggestions

+0.31% via ...ge/driver/gcs/gcs.go#185...216
+0.31% via ...ge/driver/gcs/gcs.go#104...135
+0.23% via ...ge/driver/gcs/gcs.go#469...492
See 7 more...

Powered by Codecov. Updated on successful CI builds.

LGTM


Not Really an issue

Hi,
First of all, thanks for the great work you have been doing and still going on.
I am actually trying to use your work in my project.

I created a module with a lot of models. Unfortunately, none my models is listed in the sidebar.
PS: I didn't either found the models in the permission section.
Thanks in advance

Never mind,
I managed to hack in the code and add some extra code for my models to be shown.
Thanks.


Add templates and generate themes

This PR adds a default template and generates most standard base16 schemes based on it.
@bswinnerton @kevingyori your themes are unchanged because the naming convention is slightly different for the auto-generated themes. I also added both myself and Kevin to the authors (I couldn't find your email Kevin so please update it if you care about it).

Thanks so much for adding these themes, @timcki. Curious how you think we can ensure that the auto-generated themes don't overwrite any manually tweaked themes like @kevingyori and I's. Right now there are duplicates which I think might end up causing confusion to end users.

Sorry for the delay here, @timcki! That approach for _custom to separate out manual and auto-generated themes makes sense. Would you be up for submitting a PR to zed/extensions to bump the version and submodule in order to get these changes in?

Hey, sorry this took so long! I opened a pr in the extensions repo here: https://github.com/zed-industries/extensions/pull/672


503

Creates a centralized fees module which includes a function to get the estimated fee from the server. The function caches its results.
Adds the estimated network fee to the confirm box when clicking Send to send money from the wallet (closes #503).
Refactors the confirmWallet box from the Purchase Payment view:

Gets the estimated fee from the newly created utility module.
When the fee is not available (because it is in the process of being fetched or the fetch failed), the messaging will use the payment amount without the fee and include generic messaging instructing the user that a fee will be / needs to be added in.

Something is off in the math here.
If I have 0.00274301 funds, and I try to send 0.0018, the estimated fee is 0.00078, for a total of 0.00258.
But I get a server message that the funds are insufficient. I had to lower the amount to 0.0015 (total of 0.00228) before it would send (0.0016 was too high), which would seem to make the fee around 0.00108.

@jjeffryes On our end, it's just an estimated fee, so if you're right at the edge with your available balance, I think there will always be potential mismatches between the client and server. There are a couple of things at play here:
1.) The server caches the estimated fee API for one minute. I don't know if it uses this cache when spending from the wallet, or if it always gets a fresh value. Either way, even if it does use the cache. The cache may have expired from what the UI fetched.
Also, the UI is caching the fee for 5 minutes. ! minute seemed a little too low, especially given that if the UI and server cache time line up, the still won't be totally in sync.
2.) BTC fee are per byte and the UI estimated fee does not take the actual transaction size into account. It just uses an average transaction size of 200 bytes. I would think the server is using the actual transaction size.
I'll go ahead and make your suggested text changes. Perhaps, they'll help at least a little?
I do want to stress that this only is an issue when the user is right at the edge of barely having enough money to cover the transaction and fee. But, I do agree, it's weird having the UI estimate one value, that you meet and then the server failing with insufficient funds.


Omit coverage for code with no logic

Is it possible to limit code coverage to only properties and methods that are above a given cyclomatic complexity? This would avoid having to at unit tests for constructors, methods and properties with no logic and no calls to dependencies.
Responding to your point on the Marketplace: yes I'd have a go at implementing this if you could offer some info.

OK. I will get back to you with the info at the weekend.


Package detection

Neofetch only displays 1 package installed under arch linux.

Just tried latest master and it's showing proper value for me on Arch

Give us output of these commands:
pacman -Qq --color never | wc -l

pacman -Qq --color never

ping @465joe55

Do you by any change have dpkg installed on arch?

Fixed.


issue #156: allow unequal array lengths in sublabels

#156

Here is a snippet of code on how we verify the empty inspection. Take a look at the empty list to understand how we expect the structure to be like if empty. This is important so the FE doesn't receive Null value where they do not expect.
Snippet from 📦 tests.fertiscan.test_datastore
def loop_into_empty_dict(dict_data):
    passing = True
    for key, value in dict_data.items():
        if isinstance(value, dict):
            loop_into_empty_dict(value)
        elif isinstance(value, list):
            if len(value) == 0:
                continue
            else:
                passing = False
        elif isinstance(value, bool):
            if not value:
                continue
            else:
                passing = False
        else:
            if value is None:
                continue
            elif validator.is_valid_uuid(value):
                continue
            else:
                passing = False
    return passing

I see we modified new_inspection, however, I dont see a new test showcasing it can handle different type of Null combination

You could include my last comment in your https://github.com/ai-cfia/ailab-datastore/issues/158

nvm you've already done it 🥇


support create-react-native-app ?

will support create-react-native-app?

As far as I know create-react-native-app creates an Expo-app. So the answer is no.
There's been an uptick in Expo-related questions lately https://github.com/idehub/react-native-google-analytics-bridge/issues/154#issuecomment-318976520, perhaps I should add a note in the README.

Closing with README update: https://github.com/idehub/react-native-google-analytics-bridge/commit/915ae33b5a107d27d5562666a3c1cb04f3f0c805


Guard clauses for NSRequiresConcreteImplementation

Use guard statements to exit early with NSRequiresConcreteImplementation(). This approach is more succinct, and has the added safety of guard requiring a transfer of program control.

@swift-ci please test

@parkera the CI failure is the same for PR #372
_swift_stdlib_unicode_strToLower' can not be used when making a shared object
I've been working off the swift-3.0-preview-1-branch as a base as master has build failures on OSX when running the latest swift toolchain for Xcode. Merging master into this PR branch might fix the issue.
Just before I do can you please run CI against current master? It would be helpful to have a green baseline.

Yah we're in a bad state with the CI right now. I think it's going to clear up soon.

@swift-ci please test

@parkera i've merged master into this branch, the base commit for this branch is too old. Can we please run CI against it again?

This should be good to go now

@swift-ci please test

@parkera awesome, my first PR merged 🎉

Congrats and thank you!


pdf download problem

Hi,
I am using archlinux with xfce4 desktop environment.
I downloaded firefox-99.0.r20220411174855-x86_64.AppImage and add executable to it: chmod u+x firefox-99.0.r20220411174855-x86_64.AppImage. Then I open up a pdf file, such as this. When I try to download it with the button

There is no reaction at all, thus I cannot download this pdf file. Would you please tell me what is the cause of this, and would  you please fix it if it is the problem about this appimage?

same as #23

Sorry, I am not able to reproduce it with the latest versions of Firefox ESR at least. let me know if this problem still exist. If it still exists, please continue the thread of #23


[TW#19012] smartconfig problem

Hello! I have got problem with smartconfig on Samsung S8+ with Android 8.0
Log:
I (13942) phy: phy_version: 383.0, 79a622c, Jan 30 2018, 15:38:06, 0, 2
I (13962) wifi: mode : sta (30:ae:a4:3b:c9:d8)
I (14012) smartconfig: SC version: V2.7.1
I (18842) wifi: ic_enable_sniffer
I (18842) sc: SC_STATUS_FINDING_CHANNEL
I (22652) smartconfig: TYPE: ESPTOUCH
I (22652) sc: SC_STATUS_GETTING_SSID_PSWD
assertion "timer_initialized(ptimer)" failed: file "/home/sergey/esp/esp-idf/components/esp32/./ets_timer_legacy.c", line 85, function: ets_timer_arm
abort() was called at PC 0x400d79fb on core 0
0x400d79fb: __assert_func at /Users/ivan/e/newlib_xtensa-2.2.0-bin/newlib_xtensa-2.2.0/xtensa-esp32-elf/newlib/libc/stdlib/../../../.././newlib/libc/stdlib/assert.c:63 (discriminator 8)
Backtrace: 0x4008d07b:0x3ffc17e0 0x4008d1d3:0x3ffc1800 0x400d79fb:0x3ffc1820 0x40089a65:0x3ffc1850 0x40110282:0x3ffc1880 0x40114b24:0x3ffc18a0 0x4011555d:0x3ffc1900 0x4011045e:0x3ffc1920 0x40104939:0x3ffc1940 0x400873c9:0x3ffc1960
0x4008d07b: invoke_abort at /home/sergey/esp/esp-idf/components/esp32/./panic.c:648
0x4008d1d3: abort at /home/sergey/esp/esp-idf/components/esp32/./panic.c:648
0x400d79fb: __assert_func at /Users/ivan/e/newlib_xtensa-2.2.0-bin/newlib_xtensa-2.2.0/xtensa-esp32-elf/newlib/libc/stdlib/../../../.././newlib/libc/stdlib/assert.c:63 (discriminator 8)
0x40089a65: ets_timer_arm at /home/sergey/esp/esp-idf/components/esp32/./ets_timer_legacy.c:85 (discriminator 1)
0x40110282: sc_channel_timer_cb at ??:?
0x40114b24: TOUCH_Find_sync_ht20 at ??:?
0x4011555d: TOUCH_Deal_with at ??:?
0x4011045e: sc_PackCallback at ??:?
0x40104939: ppProcessRxPktHdr at ??:?
0x400873c9: ppTask at ??:?
Rebooting...
ets Jun  8 2016 00:22:57

@Sergey081977 Could you please tell me which router did you use? What is the commit ID of IDF? Did the issue happen every time?

I repeat this bug on routers:
Mikrotik hapAC;
Asus rt-n12;
Keenetic giga II.
I use last id of idf.
Issue happen every time.
If downgrade id of smartconfig to version 2.6.8, then smartconfig is work.

@Sergey081977 What is the last id of IDF? It updates every day. Did you use the smartconfig example of IDF?

Yes. IDF automatic downloading from git. Yes I use exemple from last idf. This bag i find only with samsung S8 plus with android 8. When on samsung S8 was android 7, smartconfig work is correct.

I'm getting the same, android 8.1.0 on google pixel, random residential AP, latest esp-idf master (da2781631455b2c87c01704503f70443799a5187). Of note, before updating idf from<PHONE_NUMBER>2d0918d3add78d9ccf8c2bb7de3152  I was getting auth timed out issues, so no panic but still timer issues.

The problem is most likely using 802.11n and MIMO. As per http://processors.wiki.ti.com/index.php/Smart_Config_Application_development_information_-_Java_Applet#Overview. I couldn't find a way to force 802.11g on android to confirm.

@Sergey081977 @erkki The issue has been solved in IDF v3.1. Please take a look at it. Sorry for telling you late.

@TimXia thanks! I'm guessing though it's better to do some form of bluetooth configuration in light of this technique being fundamentally incompatible with 802.11n and MIMO (and most likely .ac and friends?)


Fix offsets for messages within MessageSet

MessageSet holds the offset of the last message which means
we need to take into account the size of the MessageSet to
set the Message offset properly

@zmstone thanks for the review!

@ale7714 do you have time to continue work on this?

Otherwise I can take a stab at it.

@zmstone thank you for your comments!
@dasch sorry I’m traveling for the holidays and don’t think I wil be able to work on this soon.

https://github.com/zendesk/ruby-kafka/issues/505 @zmstone helped us debug this, this is related :)


fix: add global resource view api

Signed-off-by: lixd<EMAIL_ADDRESS>
What type of PR is this?

/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:
add global resource's view api in project scope,and update roles

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

/lgtm

/lgtm

/cc @x893675

/approve


Terminal tab folder names aren't showing e on Windows PowerShell

Found by @andreamah
I recently changed the serialization of messages from shell integration so that's likely the cause - `e isn't supported in pwsh 5

Still seeing this in newest insiders

Condition is the wrong way around 🤦
https://github.com/microsoft/vscode/blob/9782bbccd6e096b13e0e745a5f30bc5819586233/src/vs/workbench/contrib/terminal/browser/media/shellIntegration.ps1#L62-L64


Add code Coverage reports

This is #53 again. Creating this again, so that bors works.
This PR mainly adds a script that automates test coverage report generation.
To generate the report the binaries is instrumented by setting the RUSTFLAG -Zinstrument-coverage which enables source-based coverage.
I've tested and this works for both unit and doctests (Master currently does not have any doctests, I verified it with a doctest I added locally).
The test coverage generated is specific to the architecture, i.e. the coverage report generated on a Linux machine will not consider any of the code which is for macOS and it won't appear in the reports.
However codecov.io automatically merges reports from different architectures, so the report, that the codecov bot will hopefully link below, should show a complete picture.

I rebased onto the current master HEAD and switched to using the codecov github action instead of the codecov bash script.

I rebased onto the current master HEAD and switched to using the codecov github action instead of the codecov bash script.

The code coverage report can be found at https://codecov.io/gh/hermitcore/uhyve/tree/efa8f0063c9972f7da87b166d2613f52e1d87efe/src
I think the codecov app needs to be installed for codecov to be able to comment on PRs

The code coverage report can be found at https://codecov.io/gh/hermitcore/uhyve/tree/efa8f0063c9972f7da87b166d2613f52e1d87efe/src
I think the codecov app needs to be installed for codecov to be able to comment on PRs

bors try

bors try

I integrated the codecov app to this repository.

I integrated the codecov app to this repository.

bors r+

bors r+

@stlankes It looks like the gitlab runner failed to start. Could you try again?

@stlankes It looks like the gitlab runner failed to start. Could you try again?

bors retry

bors retry


Add (optional) support for toggling plugin output size metric

Add optional support for toggling the emission of a performance data metric listing the plugin output size.
Name: plugin_output_size
This can be useful for troubleshooting issues with Nagios or similar monitoring systems truncating plugin output OR for surveying an environment before enabling embedded payloads (optional feature added recently).

Next steps for dev branch:

doc updates
add test(s)


relatedQueries/relatedTopics : Top and Rising

thank you for your work and your for your package.
But I have question about the results of your relatedQueries() and relatedTopics() functions. I think they don't return the top and the rising status.
Am i false ?
best regards
Fred

Hi @fredoh91,
Thanks for raising an issue, I'm not sure what your problem is though. Can you provide an example of how you're using the module and what it is, or is not returning?

@Dayjo @fredoh91 I think I'll close this for now unless there is still an issue?


rust-analyzer-unwrapped: 2022-03-07 -> 2022-04-04

Description of changes
Just a version bump.
Note that this newest rust-analyzer requires rustc 1.59.0, and hence this pull request is targeted into the staging branch (since our current master is still on rustc 1.58.1).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

rust 1.59 was just merged into master yesterday, if you want to rebase and target master, that's fine too.

Sure, one sec - lemme rebase 🙂

While we're at it, lemme upgrade rust-analyzer to 2022-04-04, which is the newest version now;

Thank you!


Own Service for list

To keep the main Service as simple as possible, i as a DEVELOPEr wants to extract the local cached list into an own service.
AC's

service exists that containts the list
method to register an item by its id exist
method to find an item by its id exists
method to remove an item by its id exist
method to get all unflushed items exists
method to register/find/remove an item by an intermediate id exists (create New)

Parts had been done by the refactoring #9

Ment #11


The patient record issue(showing all patient records)

Miidwife needs to view All previous encounters she has had with the girl plus those of the VHT

Please specify where in the workflow this needs to happen.

Penninah said it should occur just before the appointment note is triggered. That is in the Upcoming appointments.
So she should view and them take more records


How to test the trained generator models?

I have completed the training successfully using Image2Image.py. But I could not test the model using test images. Whenever i run with --eval , the model generates the inference for random images in the training dataset. Could you  please help me with it?
Also in the eval() function,

generate_images function is hard coded with the value of 100. Why is that so?

So you are saying everything works well except it generates predictions for the train dataset? I don't know why that would be the case, I set it up to use the validation dataset here, a few lines before the generate_images call you cited:
# DATASET
dataset = get_aligned_dataset(opt, "val")
input_dataset = CropDataset(dataset, lambda x: x[0:dataset.A_nc, :, :])

I hard-coded the number of images arbitrarily to 100 to have a decent number of outputs to look at, but you can freely change it without breaking the code in any way.


Create elc2135

elc2135

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
sotoyjuan, @holderoftheheel, @barek562810, @phatdoyle, @simple10, @achernetsov, @Market2199897, @cavazinf, @thepandaguitar, @Muzammil98, @samajammin, @Xrayloser, @notPeterPan, @LipYY, @OksanaBorukh, @nireve, @seiewz, @SuplabsYi, @xrsrke, @0xgui

Celestia Airdrop - Claim Your Free TIA Tokens Now!

Don't Miss Out on Your Share of 60 Million $TIA Tokens!
Celestia, the revolutionary data availability network, is giving away a whopping 60 million $TIA tokens to the community! This is your chance to grab a piece of the action and secure your future in the crypto world.
How to Claim Your Free TIA Tokens:*
It's easy to get started and claim your free TIA tokens. Follow these simple steps:

Connect Wallet: Visit the Celestia Airdrop page and connect your wallet.
Claim: Click the Claim button to receive your tokens.
Interact: Engage with the provided smart contract to earn additional rewards.

Why Wait? Start Earning Today!
With Celestia, the sky's the limit. Don't let this opportunity slip through your fingers. Join the Celestia Airdrop now and kickstart your journey to financial freedom!vidalpaul, @alcryptoall, @ugurasan, @Dione-b, @RPing, @williamyang-zzu, @alexzhenyu, @vfalcao, @thuannd97, @sraveendra, @Singer62565658, @sachin-1091, @dskithulgoda, @cohrondrekaftpqh4405, @dmolinac, @nicksonfleury3, @sarathjayasundra13, @Huybang201, @BaofengWu, @unrav31


Breaking changes before v1.0 release

A PR to clean up the user interface and user interaction.
Breaking changes

Report / DataFrame column :steps renamed to :step and from :dτ to :time_step
Renamed function update_dτ to update_time_step
Renamed keyword argument targetwalkers to target_walkers in ProjectorMonteCarloProblem

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.025%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6723

Relevant Lines:
7075

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

68 of 80 (85.0%)  changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 94.996%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/qmc_states.jl
0
2
0.0%

src/StatsTools/reweighting.jl
37
47
78.72%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
6721

Relevant Lines:
7075

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

71 of 83 (85.54%)  changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 94.996%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/qmc_states.jl
0
2
0.0%

src/StatsTools/reweighting.jl
37
47
78.72%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
6721

Relevant Lines:
7075

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

70 of 82 (85.37%)  changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 94.998%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/qmc_states.jl
0
2
0.0%

src/StatsTools/reweighting.jl
37
47
78.72%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
6723

Relevant Lines:
7077

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

69 of 82 (84.15%)  changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 94.984%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/fciqmc.jl
9
10
90.0%

src/qmc_states.jl
0
2
0.0%

src/StatsTools/reweighting.jl
37
47
78.72%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
6722

Relevant Lines:
7077

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

69 of 82 (84.15%)  changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 94.984%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/fciqmc.jl
9
10
90.0%

src/qmc_states.jl
0
2
0.0%

src/StatsTools/reweighting.jl
37
47
78.72%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
6722

Relevant Lines:
7077

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

69 of 82 (84.15%)  changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 94.984%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/fciqmc.jl
9
10
90.0%

src/qmc_states.jl
0
2
0.0%

src/StatsTools/reweighting.jl
37
47
78.72%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
6722

Relevant Lines:
7077

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

69 of 82 (84.15%)  changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 94.984%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/fciqmc.jl
9
10
90.0%

src/qmc_states.jl
0
2
0.0%

src/StatsTools/reweighting.jl
37
47
78.72%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
6722

Relevant Lines:
7077

💛  - Coveralls


Changing helm chart images to 1.1.0-alpha

Purpose
Changing helm chart images to 1.1.0-alpha

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 30.80%. Comparing base (96a646a) to head (0a6b3ac).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2119      +/-   ##
==========================================
+ Coverage   26.03%   30.80%   +4.76%
==========================================
  Files          68       50      -18
  Lines        4732     9138    +4406
  Branches     2426      246    -2180
==========================================
+ Hits         1232     2815    +1583
- Misses       3500     6192    +2692
- Partials        0      131     +131

Flag
Coverage Δ

adapter
27.63% <ø> (?)

config-deployer-service
?

idp-domain-service
80.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update workflows external pr

@fredvd tell me when this is ready, @stevepiercy maybe you can take a look too? Thanks!

@mauritsvanrees
Wath you might be missing, because it is configured on the repo settings, is when/if the workflows for those newly created external pull requests are executed. If they would be executed always uncondtionally it is indeed insecure.
But we're not.

The question is now: how much and how fast are you going to trust outside these fork pull request contributors?   And who is going to check those contributions/changed files?
As we discussed: the workflow files are protected, because the workflow files from the target repo will be used, and not possibly pwned changed workflows in the pull request.
We could also decide to run on: pull_request and not pull_request_target. But then the workflow will not be able to push previews/deployments to netlify or other things that require the secrets.  So how are you going to handle 'verifying' those pull requests.
Accepting contributions from developers we don't just fully trust is difficult to manage. And the tools github gives all have trade offs in security and or convenience or work required.
cc: @davisagli

@fredvd In general I would feel more comfortable using the pull_request event and making sure the required workflows don't need secrets, instead of using the pull_request_target event. My understanding is that if a secret is provided to the workflow as an environment variable and the workflow steps are running code from the external PR branch, then the untrusted code could steal the secret. (In this case the executed steps depends not only on the workflow file which is protected when using pull_request_target, but also on the code in the branch that was checked out.)
Docs builds on Netlify are kind of a separate question. It uses a GitHub app, not a GitHub Actions workflow. Based on reading their docs I think that it can be configured to allow builds from external PRs, and I haven't thought of a reason why that is a security issue.
The main change I'm aware of that we need to avoid relying on secrets is to not send Cypress results to the Cypress dashboard. I will try later today to see if there is a way to do this conditionally.

@fredvd I made a branch which adds the pull_request event as a trigger for the workflows: https://github.com/plone/volto/compare/workflow-pr-trigger?expand=1
And I am trying it out by submitting a pull request from my impostor davisagli2: https://github.com/plone/volto/pull/4628
It seems to be working well. The Netlify build succeeded and the Cypress builds are succeeding even though they don't have the secret to send results to the Cypress dashboard.
So, I think probably the only change we need is what I already have in the workflow-pr-trigger branch, and this would be my preference since it is safer.

In general I would feel more comfortable using the pull_request event and making sure the required workflows don't need secrets, instead of using the pull_request_target event

yes that's also my understandinf from letting this settle in for a week, gathering comments and multiple people reading the documentation and thinking through the consequemces.
Also, we're doing this for a minority of all use cases and developer activity, when onboarding new devs. so it doesn't have to be perfect, larger changes where collaboration is necessary should be developed on a branch on the main repo anyway for best dx.


How To - Offsite Backup of VHD files

ISSUE TYPE

Other

COMPONENT NAME

UI

CLOUDSTACK VERSION

4.15

CONFIGURATION

xcp-ng 7.4
OS / ENVIRONMENT

N/A
SUMMARY

This is not an issue per say, but a question. What is the best way to backup VHD files to an offsite backup for DR?  We are using xcp-ng 7.4 and Cloudstack 4.15. We do not have a second data center. I am thinking to map a NFS drive in Azure Blob storage and map that as a mount on a dedicated Linux server (on prem) and then use rsync to copy VHD files over. First time will take forever, but then incremental rsync should be quick. Will rsync work correctly for VHD backups like this?
STEPS TO REPRODUCE

rsync files

EXPECTED RESULTS

in case of a disaster, the backed up version of rsync'd file can be used as a new VHD and create new VM based on that

ACTUAL RESULTS

N/A

PS  - Note that the VM cannot be shutdown. So rsync will run while VM is running.

Still looking for advice here... Any suggestions are welcome

Thanks for the questions @nxsbi I think it depends on the setup, you can use a backup solution (something like Veeam) or something bare-bone like scripts that say are run by cronjob that rsync your backups vhd files. Can you ask this on users or dev mailing list where you might get more reach to the community - https://cloudstack.apache.org/mailing-lists.html
(closing as this is not an issue)


Chromium download location changed

omahaproxy.appspot.com/all.json returns not a 200
Please investigate and fix.

It looks like the previous hacked way of getting downloads no longer works. They have an official API to download files. See https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json
At the time of this issue, we should throw our stuff away and start over. There is some code that might be helpful unzipping and permission setting but the rest we should get rid of.

Also, at the time of this, we are on version 120 of Chrome. This versions listed range from 113 to 122. This is probably a good range for most users.

{
  "timestamp": "2023-12-15T22:08:41.156Z",
  "versions": [
    {
      "version": "113.0.5672.0",
      "revision": "1121455",
      "downloads": {
        "chrome": [
          {
            "platform": "linux64",
            "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.0/linux64/chrome-linux64.zip"
          },
          {
            "platform": "mac-arm64",
            "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.0/mac-arm64/chrome-mac-arm64.zip"
          },
          {
            "platform": "mac-x64",
            "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.0/mac-x64/chrome-mac-x64.zip"
          },
          {
            "platform": "win32",
            "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.0/win32/chrome-win32.zip"
          },
          {
            "platform": "win64",
            "url": "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.0/win64/chrome-win64.zip"
          }
        ]
      }
    }
  ]
}


Add missing i18n tokens/texts related to View API Backend

Related to #965
Add missing i18n tokens/text related to all aspects of API Backend:

[x] View usage instructions (button)

[x] Make API calls to:

[x] name of tabs

[x] Details

[x] Metadata

[x] Feedback

[x] Backlog

[x]  Export

[ ] Details view

[x]  Delete (button)

[x] Just now

The status text and usage instructions had already been fixed in previous PRs.


Assertion arguments should be passed in the correct order

Fixed problem by swapping expected value with actual value.

Issue 15.


Update exchange/exchange-ps/exchange/organization/Set-OrganizationCon…

Added new Connector params and general parameter/parameter set cleanup.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/organization/Set-OrganizationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Added CSV export for list responses

tasks:

[x] test coverage
[x] UI
[x] config dialog
[x] translations (waiting for FR)
[x] Snippets (no array)
[x] Roles
[x] Categories
[x] Tags
[x] Contact
[x] Account

informations:

q
a

Fixed tickets
none

Related PRs
https://github.com/massiveart/husky/pull/617 https://github.com/sulu-io/sulu-standard/pull/628

BC breaks
none

Documentation PR
none

@danrot this is rebased now

@danrot fixed

@danrot fixed and rebase

@wachterjohannes The build is always hanging at the same tests for PHP7...

@danrot this PR is now ready to review ... tests passes now without any changes

If the empty dropdown value from this screenshot is clicked, it is not written in the dropdown itself. This means it looks like the value " is still selected.

However, the export is correct.

@danrot the mentioned bug is fixed in the husky PR https://github.com/massiveart/husky/pull/617 this changes are also in this branch and can be tested here.


Add Datera CloudStack Storage Plugin <IP_ADDRESS>

1.Create/Delete Dynamic Primary Storage
2.VM create with root disk on Datera
3.Create Datera native snapshots
4.Create template from snapshots
5.Create volume from Snapshots
6.Storage volume QoS.
7.Volume resizing with QoS change.

Submit a new PR after rebased to the latest upstream/master

@jcshen007 can you rebase against latest master and fix the version to <IP_ADDRESS>-SNAPSHOT etc?

Is this still WIP or experimental/PoC or you would want some feedback on this @jcshen007

Ping @jcshen007

Ping @jcshen007 any update, where the integration stands? Can you rebase to latest master?

Closing the outdated PR.


Scp 3705/cucumber tests

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[ ] Test report is updated (if relevant)
[ ] Commit sequence broadly makes sense
[ ] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages
[ ] Formatting, PNG optimization, etc. are updated

PR

[ ] Self-reviewed the diff
[ ] Useful pull request description

Review required
[ ] Substantial changes to code, test, or documentation
[ ] Change made to Marlowe validator (@bwbush and @palas must be included as reviewers)
Review not required
[ ] Minor changes to non-critical code, documentation, nix derivations, configuration files, or scripts
[ ] Formatting, spelling, grammar, or reorganization

[ ] Reviewer requested

This seems to be irrelevant in this repo - we don't have any web apps here to test with cucumber


suggest "npmignore or files" instead of just files

Using files is dangerous, because if you forget to include something, you break people - whereas if you use npmignore and forget to include something, you just publish something extra and unused.
At the least, could the relevant suggestions be agnostic about which mechanism is used to select which files are published?

Showing files only is intentional as I'd like to encourage authors to publish files that are only needed and respect the users' network bandwidth. The same could be said when adding new files that were not meant to be published too. If they prefer to use .npmignore, the rules documentation for the suggestion has a link that indirectly points to it, so I prefer to keep it the way it is for now.

that's unfortunate, since "publish only files that are needed", and the user's network bandwith, is much much less important than protecting the user's runtime application by keeping it working.
it's npm's job to manage bandwith, not individual package authors.

Both are certainly equally important and package maintainers should equally prioritise them before publishing packages. But I think .npmignore gives the bigger leeway to make mistakes without an easy way to identify them.

Downtime is infinitely more expensive than bandwith, thus, npmignore is the safer and better approach.


Update fields of package.json for save time

repository
author
license
bugs
homepage

fiexd by #91

fiexd by #91


docs: bump version to ~>0.4.0 in example

Description
Update docs to use the 0.4.X version.
Type of change

[X] Other (describe)

This is no longer valid. See https://github.com/juju/terraform-provider-juju/pull/159

This is no longer valid. See #159

@juanmanuel-tirado fixed.

@juanmanuel-tirado why did you close it without any comments?


Add Contributor Covenant Code of Conduct

Added CoC per @ebrillhart

🎉  🙌  :shipit:

Coverage remained the same at 96.254% when pulling c7fb1d615970d2f178b053104052629f9189321d on task-addCodeOfConduct into f53cb8c08ec96b1ad3e19f78315612f32aa24574 on master.

LGTM!


fontawseome5 is not working

LaTeX Error: File `fontawesome5.sty' not found.
Type X to quit or  to proceed,
or enter new name. (Default extension: sty)
Enter file name:
! Emergency stop.
<read *>
l.51 \RequirePackage
{hyperref}
*** (cannot \read from terminal in nonstop modes

Hi, did you check that you have the Fonteawesome5 package installed on your system ?

Had the same issue. In my case it worked when I had replaced: \RequirePackage[fixed]{fontawesome5} => \RequirePackage{fontawesome}.
I am using ttf-font-awesome 5.7.0-1, but no idea if AUR package is not properly deployed or there is wrong assumption in projects requirements.

The problem is with the fontawesome5 latex package version, not the font version. The fixed option has been added with the     * 5.4.1 fontawesome5 package

Hi, did you check that you have the Fonteawesome5 package installed on your system ?

Actually, I did it on Overleaf I think they have installed.

Could you double check with them. I'm pretty sure they use a old live tex distribution that don't include fonteawesome5 package. In fact that's why I only share the legacy branch on overleaf...


[Welcome to PowerToys]: Narrator focus does not navigate to ‘Microsoft Docs’ and ‘PowerToys in our release notes’ link.

Microsoft PowerToys version
"0.35.0"
Running as admin
Area(s) with issue?
Welcome / PowerToys Tour window
Steps to reproduce
Test Environment:
OS: Windows 10 Build 21354.1
App version: 0.35.0
App name: PowerToys
Screen Reader: Narrator
Tool: Accessibility Insight for Windows
Repro Steps

Launch 'PowerToys' application.
Turn on the 'Narrator'.
Application will get open with default list item 'General' selected.
Navigate to 'Welcome to PowerToys' link present at the right side of the pane and activate it.
'Welcome to PowerToys' window will get open.
Navigate using 'Tab' key.
Observe the issue.

User Impact: Priority-1
If any application does not expose information and mechanisms necessary to track focus, text insertion point, and selection attributes (e.g. whether text has been selected for copy/paste) of user interface components,  it would be difficult for the platforms that provide Accessibility APIs, and would in turn affect the screen reader dependent users to determine the focus.
MAS Reference:
https://microsoft.sharepoint.com/:w:/r/sites/accessibility/_layouts/15/Doc.aspx?sourcedoc={3C29FC92-CBCC-4A68-9FA6-0F159E3CFEA1}&file=MAS 4.2.10 – Tracking of Focus and Selection Attributes.docx&wdLOR=c15814F13-1B22-4FF5-A80E-802D46292C60&action=default&mobileredirect=true&cid=8d8a8173-bcfa-4764-b18e-ca7fd7332081
Note: Same issue repro with NVDA also.
MAS4.2.10_Welcome_narrator focus not navigating to links.zip
✔ Expected Behavior
Narrator focus should navigate to ‘Microsoft Docs’ and ‘PowerToys in our release notes’ link along with keyboard focus navigating via 'Tab' key.
❌ Actual Behavior
Narrator focus does not navigate to ‘Microsoft Docs’ and ‘PowerToys in our release notes’ link.
Only the keyboard focus navigates and narrator focus stays on 'Welcome to PowerToys' item and remain silent.
Other Software
No response

Fixed in #12470 and will be integrated in the next major release of PowerToys

Resolved with the release of v0.45.


sub-presenter build is expensive, and should be cached

in case a caller wants/needs to call it twice

@jrochkind Can you explain how it's expensive?

I'd have to debug more, I assume it's hitting fedora multiple times. It takes many hundreds of ms every time I call it on a work with many members.  It also is of course building a bunch of ruby presenter objects.
A presenter object like this pretty much can't have data change while it's in effect, can it? Caching seems quite safe.
Do you think it's neccesary to fully debug and figure out exactly why it's taking so long before fixing it with caching?  I may or may not have that capacity at present.

I don't find this kind of thing very easy to debug in the samvera stack. If you have an easier time of it, would you be interested in helping?  Or providing hints to how I'd go about figuring out why it's expensive?  I'm still at the level of spelunking through the many many layers of abstraction involved and trying to benchmark each etc. Very time consuming.

I just wanted more context. Presenters shouldn't be hitting Fedora

indeed this actually causes a problem in my local app too, so this is a no-go.
I honestly have no idea what's going on, I'll have to find some other way to make my local app more efficient. Don't understand why you wouldn't be able to cache/reuse these, arg.

Ah, cause I was caching indifferent to the args passed in, of course that's not going to work!
Locally I'm prob gonna try caching anyway, based on args. Cause it's just way too expensive for me to do what I need with it, and I don't understand what's going on.
But I don't understand what's going on well enough to make a PR.

Should at least be able to trip this in the presenter test with a negative test for ActiveFedora


Update dependency quay.io/vshn/signalilo to v0.12.0

This PR contains the following updates:

Package
Update
Change

quay.io/vshn/signalilo
minor
v0.10.0 -> v0.13.0

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.