HttpContext.GetTokenAsync fails after Upgrade to 2.1.0

Hello,
I have some code that's calling await HttpContext.GetTokenAsync("access_token"). When using Microsoft.AspNetCore.Authentication.JwtBearer version 2.0.4 it works, but upgrading to 2.1.0-preview1-final or newer results in null being returned.
I believe this is because on line 73 in Microsoft.AspNetCore.Authentication.Core/AuthenticationService.cs
return AuthenticateResult.Success(new AuthenticationTicket(transformed, result.Properties, result.Ticket.AuthenticationScheme)); result.Properties is null.
When using JwtBearer auth, result.Properties is never set - however, the properties that are expected to be there are present on result.Ticket. Changing line 73 to return AuthenticateResult.Success(new AuthenticationTicket(transformed, result.Ticket.Properties, result.Ticket.AuthenticationScheme)); appears to fix the issue for me, is there any reason not to do so?
Thanks

JwtBearer Succeeds:
https://github.com/aspnet/Security/blob/e031eff146c8aad43e63cd8d32e8fe382a0c8d66/src/Microsoft.AspNetCore.Authentication.JwtBearer/JwtBearerHandler.cs#L152-L153
Creates a ticket and HandleRequestResult:
https://github.com/aspnet/Security/blob/e031eff146c8aad43e63cd8d32e8fe382a0c8d66/src/Microsoft.AspNetCore.Authentication/Events/ResultContext.cs#L46
Stores the ticket:
https://github.com/aspnet/Security/blob/e031eff146c8aad43e63cd8d32e8fe382a0c8d66/src/Microsoft.AspNetCore.Authentication/HandleRequestResult.cs#L36
Which doesn't set Properties like the base class does:
https://github.com/aspnet/HttpAbstractions/blob/bcb7bcbb7a6461204f4cefd9848e2a782ebb0a6b/src/Microsoft.AspNetCore.Authentication.Abstractions/AuthenticateResult.cs#L57

Yeah looks like a bug

@Tratcher Thanks for accepting the PR - is it possible to have this included in 2.1.0-RTM?

@Tratcher @HaoK Is there a workaround?

The information is still there via result.Ticket.Properties, so the workaround would be to use the underlying apis instead of the top level sugar...
instead of 'context.GetToken("access_token")' something like:
 context.AuthenticateAsync(JwtBearer.Defaults).Ticket.Properties.GetToken("access_token");

Thanks @HaoK. So the workaround is easy. How common do we think it will be for people to hit this?

That workaround doesn't work, all of the Properties collections are empty. You'd have to go a step further and hook into an event and store the token yourself in HttpContext.Items.

Actually, isn't that token the same as the incoming Auth header value?

I was just going by the description in the bug above: "When using JwtBearer auth, result.Properties is never set - however, the properties that are expected to be there are present on result.Ticket"

Assuming that statement is correct, its there just in the wrong place

RE how common this is @ajcvickers this bug has been there since 2.0, its not new in 2.1, so this is the first we've seen it, so its pretty uncommon I guess

No, I debugged it. Part of the trouble is that the ticket gets re-created and loses the Properties from the first ticket.

Actually rereading the OP, this behavior is new to 2.1, let me see what changed in 2.1

Can you try debugging this on 2.0.4 @Tratcher the code path looks the same to me in https://github.com/aspnet/Security/blob/2.0.4/src/Microsoft.AspNetCore.Authentication/RemoteAuthenticationResult.cs doesn't look like we changed anything other than rename the file and you tweaked the exception/error methods to include the properties

For what this background is worth, this is the application I'm working on right now: https://github.com/SteeltoeOSS/Samples/tree/dev/FreddysBBQ
It uses Steeltoe Security for doing JWT on Cloud Foundry, via Microsoft.AspNetCore.Authentication.JwtBearer
I'm in the process of making sure that Steeltoe works with [asp]netcore 2.1, so the changes I'm making are almost exclusively TargetFramework and NuGet dependencies.
The code that's breaking is in GetClientAsync() inside this file https://github.com/SteeltoeOSS/Samples/blob/dev/FreddysBBQ/src/Common/Services/AbstractService.cs
The scenario is that of multiple microservices, where the user's credentials are passed down the chain (in this case a customer site calls an order service which then calls a menu service)

Yes this worked in 2.0. Here's what broke it:
https://github.com/aspnet/HttpAbstractions/commit/321639b0eb2098a6fe3b0d763f48ac3ed025a688#diff-7e92f7940da0e821fc452fc9950db334
AuthentiateResult.Properties change from a pass through to a local field.

Ah cool, I actually looked at the PR...just in the wrong repo doh...I looked at the security half forgot there was a matching one in Http doh

I was able to confirm that pulling the token out of the auth header from the incoming request works fine in my case, so I'm a lot less worried about the extension not working in 2.1.0. We don't depend on GetTokenAsync for anything other than this one sample, so we should be fine.
Thanks again!

If AuthenticationProperties are not saved in cookie (e.g access_token) and/or able to get those after authentication/challenge flow, then it is just a deal breaker for me. You should at least give some example how to store this to enable access it on coming requests.

@avaisane JwtBearer never did store the token in a cookie. The Auth header is sent on every request and GetTokenAsync is only a shortcut for reading the header. You can read the auth header directly.

Ah, have you reproduce this with OIDC? This regression happened a year ago and I've definitely used that code path in OIDC since then...

Hmm, GetTokens works fine in the 2.1 branch in the OIDC sample. https://github.com/aspnet/Security/blob/dev/samples/OpenIdConnectSample/Startup.cs

@tratcher. Thats correct, oidc is having similar phenomenon. After updating
to .net core 2.1.300 functionality break up.
ma 4. kesäk. 2018 klo 20.45 Chris Ross<EMAIL_ADDRESS>kirjoitti:

Ah, have you reproduce this with OIDC? This regression happened a year ago
and I've definitely used that code path in OIDC since then...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/Security/issues/1765#issuecomment-394439882,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABxtIciMga2odb6BTlMvl9ZpIUTwGnrqks5t5XJGgaJpZM4UJaia
.

How are you using it? The sample linked above is working fine.

@Tratcher Goosh, we did broke our own code. We implemented the header trick mentioned above into our shared accesstokenfetcher componed, which was used by APIs and Web App. Thus it bypassed previous  httpContextAccessor.httpContext.GetTokenAsync() 80) Thanks anyway for you assistance!

This is just caused me to waste a day trying to figure out why our token authentication was failing...  any chance at a hot fix release of 2.1 with this fix?

@muratg ?
+This is a regression from 2.0.
-The workaround is trivial.

@Tratcher Could you file a bug for the patch candidate? Thanks.

Filed https://github.com/aspnet/Security/issues/1809

@Tratcher, even after updating to 2.2.0-preview2-35157 I still can reproduce this issue.


Allow GPT 4 Turbo?

Is it possible to use GPT 4 Turbo instead of GPT 4? If not it would be a nice feature.

Hi @ciconsulting thats a great idea! feel free to contribute (:


Cannot put the new pandas dataframe into sqlite table

Hi Dr. @katyhuff ! As mentioned earlier today, seems like the code
CREATE TABLE testTable(
        'index', 'Name' TEXT, 'Coord' TEXT, 'Long' REAL, 'Lat' REAL
    )
    '''

(lines 84-86 in https://github.com/ytan15/webscraping/blob/master/scraping_wikidata.py)
is not working. The error messages says "probably unsupported type".
Earlier it was
CREATE TABLE testTable(
        'index', 'Name' OBJECT, 'Coord' OBJECT
    )
    '''

and it was working fine.
Can you please take a look at it? Thanks!

Please copy and paste the full error message that you are getting.
On Thu, Mar 9, 2017, 4:39 PM Tifa Tan<EMAIL_ADDRESS>wrote:

Assigned #6 https://github.com/arfc/webscraping/issues/6 to @katyhuff
https://github.com/katyhuff.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/arfc/webscraping/issues/6#event-994022041, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAYCq8CTj_CivKh_7w6r9mq3R5xt1qAxks5rkH-rgaJpZM4MYusC
.

Traceback (most recent call last):
File "scraping_wikidata.py", line 95, in
into_sql(df)
File "scraping_wikidata.py", line 90, in into_sql
df.to_sql(name = 'testTable', con = conn, if_exists = 'append', index = True)
File "/Users/yukuntan/anaconda3/lib/python3.6/site-packages/pandas/core/generic.py", line 1201, in to_sql
chunksize=chunksize, dtype=dtype)
File "/Users/yukuntan/anaconda3/lib/python3.6/site-packages/pandas/io/sql.py", line 470, in to_sql
chunksize=chunksize, dtype=dtype)
File "/Users/yukuntan/anaconda3/lib/python3.6/site-packages/pandas/io/sql.py", line 1503, in to_sql
table.insert(chunksize)
File "/Users/yukuntan/anaconda3/lib/python3.6/site-packages/pandas/io/sql.py", line 664, in insert
self._execute_insert(conn, keys, chunk_iter)
File "/Users/yukuntan/anaconda3/lib/python3.6/site-packages/pandas/io/sql.py", line 1291, in _execute_insert
conn.executemany(self.insert_statement(), data_list)
sqlite3.InterfaceError: Error binding parameter 1 - probably unsupported type.

So, the problem was with the type of "Coord" which remaind "Object" rather than "text". There are a couple of ways around this. One is to recast that column as a string. However, it didn't seem like we really needed to keep that coord column around anyway, since the lat and lon can reconstruct it. So, the other alternative is to just drop that column from the dataframe. See https://github.com/ytan15/webscraping/pull/2 .


Gateway Api: Route HTTPS Redirect

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Hi,
I've installed Istio 1.20.0 with minimal profile and I've deployed a Gateway API gateway.
I've deployed the httpbin sample deployment.
I've created a HTTPRoute like the following:
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: test-http-route
  namespace: test
spec:
  parentRefs:
  - name: gateway-prod
    namespace: istio-ingress
  hostnames:
  - test.com
  rules:
  - filters:
    - type: RequestRedirect
      requestRedirect:
        scheme: https
        statusCode: 301
  - backendRefs:
    - name: httpbin
      namespace: test
      port: 8000

The problem is that the RequestRedirect filter takes precedence over the backendRef both in HTTP and HTTPS.
So if I run curl -HHost:test.com http://gateway_ip/get I get a 301 Redirect to https://test.com/get and if I run curl -HHost:test.com https://gateway_ip/get I also get a 301 Redirect so I can't reach httpbin backend.
If I remove the filters part in both HTTP and HTTPS, I can reach the httpbin backend.
The filter should be ignored in HTTPS. Is there a way to apply the redirect filter only when scheme is http?
Version
client version: 1.20.0
istiod version: 1.20.0
data plane version: 1.20.0 (2 proxies)

Client Version: v1.28.3
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.3

Additional Information
No response

To achieve your goal, you need 2 different listeners on your  Gateway and 2 different HTTPRoutes.

Define 2 listeners on your Gateway: one for http (usually to port 80) and one for https (usually port 443)
Remove the second rule in your HTTPRoute. Add a sectionName to the parentRef of the remaining route; it should look like this when you're done:

apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: redirect-test-http-route
  namespace: test
spec:
  parentRefs:
  - name: gateway-prod
    namespace: istio-ingress
    sectionName: http
  hostnames:
  - test.com
  rules:
  - filters:
    - type: RequestRedirect
      requestRedirect:
        scheme: https
        statusCode: 301

This will ensure only http requests get redirected

Create another HTTPRoute whose parentRef has a sectionName of https and goes directly to the backend like so:

apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: test-https-route
  namespace: test
spec:
  parentRefs:
  - name: gateway-prod
    namespace: istio-ingress
    sectionName: https
  hostnames:
  - test.com
  rules:
  - backendRefs:
    - name: httpbin
      namespace: test
      port: 8000

That should get you where you want to go

Hi Keith,
Thanks a lot for your help! sectionName was the thing I was missing.
All good now, cheers!


To use forgot_passwork_link ?

RainLoop version, browser, OS: 1.14.0
Hi,
In application.ini, we could add on logon screen the possibility of adding a link for the users who have forgotten their password.
forgot_password_link_url = ""
registration_link_url = ""

How does it work ? It seems that this feature is not really implemented in Rainloop, else we could have the possibility of defining a backup email in a another different domain of Rainloop. On this other address, after having clicking on this Rainloop link, we should receive a message with a link to change the password in Rainloop.
I will understand it like this.
Is someone succeded to do this in application.ini ?
Thanks for your feedback

RainLoop manages "change password" through plugins.
But there is no full system for registration/reset.
The links are merely there if you want to setup something like protonmail, fastmail, etc.

@the-djmaze
Thanks for you answer. It's clear and it confirms what I was thinking.
Regards


The "Verification hash matches" in the ext drop down links to ERR_FILE_NOT_FOUND page

To recreate
-go to https://pkc.inblock.io/index.php/New_Observations_on_Jupiter
-open the extension drop down
-click on the link below

if the image is no available, click on the "Verification hash matches #" link
-page "Your file couldn’t be accessed" opens

Closed now. Behavior is copy with a copy box. 9610cfa11b587f12747082f9f737c88d134e286f


how to change entropy loss to focal loss?

In order to solve the problem of unbalanced categories and difficult samples

To change an existing entropy loss function to Focal Loss, you'll need to modify the cross-entropy formula to incorporate the focal term, which helps in handling class imbalance by reducing the loss contribution from well-classified examples. Here's how:
Focal Loss was introduced in the paper "Focal Loss for Dense Object Detection" by Tsung-Yi Lin et al., and it modifies the cross-entropy loss as follows:
The standard cross-entropy loss for binary classification is given by:
loss = -y * log(p) - (1 - y) * log(1 - p)
where:
y is the ground-truth label (0 or 1).
p is the predicted probability of the positive class.
For focal loss, we add a modulating factor (1 - p)^γ to the cross-entropy:
`alpha = alpha_factor if y == 1 else 1 - alpha_factor  # weighting factor for class imbalance
focal_weight = alpha * (1 - p) ** gamma
focal_loss = - focal_weight * (y * log(p) + (1 - y) * log(1 - p))`
Here,
gamma is the focusing parameter that adjusts the rate at which easy examples are down-weighted.
alpha_factor is a balancing parameter for class imbalance.
For multi-class problems, you can extend this concept to each class:
'''
import torch
import torch.nn.functional as F
def focal_loss(input, target, alpha=0.25, gamma=2.0):
BCE_loss = F.binary_cross_entropy_with_logits(input, target, reduction='none')
pt = torch.exp(-BCE_loss)
F_loss = alpha * (1-pt)**gamma * BCE_loss
return F_loss.mean()

Assuming input is logits and target is one-hot encoded
input = torch.randn(64, 10)  # batch_size x number_of_classes
target = torch.randint(0, 10, (64,)).long()  # ground-truth labels
loss = focal_loss(input, F.one_hot(target, num_classes=10))
'''
This example shows how to implement focal loss for multi-class classification tasks using PyTorch. Note that in practice, you might want to average the loss over the batch dimension instead of summing it up, as shown above with the .mean() operation. Also, adjust alpha and gamma based on your specific task requirements.


Ability to localize the UI

Similar to how we allow different timezones to be specified via the dashboard yaml, we should also allow localization of the UI in Rill by allowing languages to be specified (i.e. present UI in a different language). Further context needed but this could potentially be done either at the dashboard or project level (as a selectable drop down).
Additional reference:
https://discord.com/channels/959796421832343562/959796422281138247/1174395061639852112

Implementation suggestion in #3547


[BUG] Diacritics / accents not working properly

Reporting an Issue or Missing Feature
I'm trying to use diacritics (see https://en.wikipedia.org/wiki/Diacritic), sometimes called accents, in document library column titles, site column names and site column choices. However, they eventually do not render correctly.
Expected behavior
Proper conversion of accents.
Actual behavior
E.g.,
Get-PnPField | Where {$_.InternalName -eq "SiteColumn"} | Remove-PnPField -Force
Add-PnPField -DisplayName "Site Cólumn" -InternalName "SiteColumn" -Type Choice -Choices "á","ë","ò"

becomes column name

with choices

Steps to reproduce behavior
See above code example.
What is the version of the Cmdlet module you are running?
Version 1.12.
Which operating system/environment are you running PnP PowerShell on?

[x] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

hi @SurinameClubcard , can't reproduce this issue.
Tried the exact cmdlet that you mentioned and it added the values correctly:

Can you please try with the latest version , 2.1.1 and let us know ? Do remember this requires PS 7.2 or later version to be installed on the machine. We have dropped PS 5.1 and ISE support in v2.1.1.

Upgrading both PowerShell and the PnP module to the latest versions fixed this problem. Thanks and sorry for not trying this myself before opening this issue here.


Sd jwt vc iss should support di ds

SD-JWT-VC issuance and presentation/verification should work with DID as issuer key reference.
Currently x5c certificates have to be provided to derive the issuer key for verification.

[ ]  Make issuer did nullable in the issuance request when x.509 are used
[ ]  CryptographicBindingSupportMethod in issuer metadata is always did. should we add x509?
[ ]  Add examples in swagger
[ ]  Rename, split, add required code to LspPotentialTest to make:  haip ietf sd-jwt  tests and oid4vc ietf sd-jwt  tests since
[ ]  Why disable metadata conf in issuer k8s?


Move LastFM module to reply response type

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable
[x] Documentation in docs/ or install-docs/ was updated, if applicable
[x] I have tested all changes

Tested this, works as expected :+1:


Cannot install cxxopts

I tried installing cxxopts (both x86 and x64) and failed with "No CMAKE_C_COMPILER could be found.". Logfile shows the following:

[1/2] cmd /c "cd ../../x64-windows-dbg && "C:/Program Files/CMake/bin/cmake.exe" "C:/work/vcpkg/buildtrees/cxxopts/src/v2.1.1-a29c67cbdc" "-DCXXOPTS_BUILD_EXAMPLES=OFF" "-DCMAKE_MAKE_PROGRAM=C:/work/vcpkg/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/work/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_PLATFORM_TOOLSET=v141" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/work/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/work/vcpkg/packages/cxxopts_x64-windows/debug""
FAILED: ../../x64-windows-dbg/CMakeCache.txt
cmd /c "cd ../../x64-windows-dbg && "C:/Program Files/CMake/bin/cmake.exe" "C:/work/vcpkg/buildtrees/cxxopts/src/v2.1.1-a29c67cbdc" "-DCXXOPTS_BUILD_EXAMPLES=OFF" "-DCMAKE_MAKE_PROGRAM=C:/work/vcpkg/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/work/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_PLATFORM_TOOLSET=v141" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/work/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/work/vcpkg/packages/cxxopts_x64-windows/debug""
-- The C compiler identification is unknown
-- The CXX compiler identification is unknown
CMake Error at CMakeLists.txt:21 (project):
No CMAKE_C_COMPILER could be found.
Tell CMake where to find the compiler by setting either the environment
variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to
the compiler, or to the compiler name if it is in the PATH.
CMake Error at CMakeLists.txt:21 (project):
No CMAKE_CXX_COMPILER could be found.
Tell CMake where to find the compiler by setting either the environment
variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
to the compiler, or to the compiler name if it is in the PATH.
-- Configuring incomplete, errors occurred!
See also "C:/work/vcpkg/buildtrees/cxxopts/x64-windows-dbg/CMakeFiles/CMakeOutput.log".
See also "C:/work/vcpkg/buildtrees/cxxopts/x64-windows-dbg/CMakeFiles/CMakeError.log".
[2/2] cmd /c "cd .. && "C:/Program Files/CMake/bin/cmake.exe" "C:/work/vcpkg/buildtrees/cxxopts/src/v2.1.1-a29c67cbdc" "-DCXXOPTS_BUILD_EXAMPLES=OFF" "-DCMAKE_MAKE_PROGRAM=C:/work/vcpkg/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/work/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_PLATFORM_TOOLSET=v141" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/work/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/work/vcpkg/packages/cxxopts_x64-windows""
FAILED: ../CMakeCache.txt
cmd /c "cd .. && "C:/Program Files/CMake/bin/cmake.exe" "C:/work/vcpkg/buildtrees/cxxopts/src/v2.1.1-a29c67cbdc" "-DCXXOPTS_BUILD_EXAMPLES=OFF" "-DCMAKE_MAKE_PROGRAM=C:/work/vcpkg/downloads/tools/ninja/ninja-1.8.2/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/work/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_PLATFORM_TOOLSET=v141" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/work/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/work/vcpkg/packages/cxxopts_x64-windows""
-- The C compiler identification is unknown
-- The CXX compiler identification is unknown
CMake Error at CMakeLists.txt:21 (project):
No CMAKE_C_COMPILER could be found.
Tell CMake where to find the compiler by setting either the environment
variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to
the compiler, or to the compiler name if it is in the PATH.
CMake Error at CMakeLists.txt:21 (project):
No CMAKE_CXX_COMPILER could be found.
Tell CMake where to find the compiler by setting either the environment
variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
to the compiler, or to the compiler name if it is in the PATH.
-- Configuring incomplete, errors occurred!
See also "C:/work/vcpkg/buildtrees/cxxopts/x64-windows-rel/CMakeFiles/CMakeOutput.log".
See also "C:/work/vcpkg/buildtrees/cxxopts/x64-windows-rel/CMakeFiles/CMakeError.log".
ninja: build stopped: subcommand failed.

Just updated and re-built vcpkg. Using Visual Studio 15.0.0+26228.9 with SDK 10.0.14393.0 on Win10 1803 build 17134.523. Am I missing something?

Hi @eyeco,
Can you attach these files?

-- Configuring incomplete, errors occurred!
See also "C:/work/vcpkg/buildtrees/cxxopts/x64-windows-dbg/CMakeFiles/CMakeOutput.log".
See also "C:/work/vcpkg/buildtrees/cxxopts/x64-windows-dbg/CMakeFiles/CMakeError.log".

Thanks.

Sure!
CMakeError.log
CMakeOutput.log

not found C_COMPILER
reinstall msvc or update Visual Studio 15.0.0 +

don't know what the cause of problem was in the first place and how I would fix it in the future, but installing VS 15.9.11 did the job, thanks!


set-default-repositories-type-to-sources: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.

Description
New GH Projects pages trigger this error:
TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.
    at chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/refined-github.js:7536:13
    at new Promise (<anonymous>)
    at oneMutation (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/refined-github.js:7532:14)
    at chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/refined-github.js:7587:51
    at async chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/refined-github.js:7585:9
    at async runFeature (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/refined-github.js:3851:20)
    at async setupPageLoad (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/refined-github.js:3857:34)
    at async chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/refined-github.js:3882:29

How to replicate the issue
Just open https://github.com/users/janpio/projects/3/views/1 and observe Console
Extension version
22.8.23
Browser(s) used
Version 104.0.5112.81 (Official Build) (64-bit)

Likely because there's an extra dropdown on the page


Question: AAD Authentication integration sample/ advice

Is there any reference material on integrating Azure Active Directory for authentication into the Blazor framework?
Similar, presumably, to ADAL.JS?

Cool, I'll give that a go. Thanks.

As an update, it took about 20mins to integrate and get that library working.

Nice! Is this code someplace that you can share?

@danroth27 It's not, but I'll pull a sample together over the next day or so and link it here.

@danroth27 Here's a quick and dirty sample, instructions in the read me, there's a styling issue with the main content on > 768px page breaks, but I'll get to that when I can.

@danroth27 Here's a quick and dirty sample, instructions in the read me!

Very cool! @blowdart @SaeedAkhter-MSFT it would be great if you guys could take a look and review this usage of adal.js from a Blazor app.

I have here more complete sample: gpeipman/BlazorDemo.
BlazorDemo.AdalClient project has the following features:

adaljs for Azure AD integration
automatic authentication
Azure Functions backend (Azure AD authentication is supported by code)
data manipulation in Blazor using fresh tokens provided by adaljs
thin JavaScript interop for getting tokens
project runs also on Azure Storage static websites

Blog post and updated project description at GitHub will come in the beginning of next week.
@SteveSandersonMS Is there any danger on dragging unmarshalled C# actions to JS interop and then back to Blazor again?


helm deploy hpa apiversion not match helm --debug

kube
Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.6", GitCommit:"ab91afd7062d4240e95e51ac00a18bd58fddd365", GitTreeState:"clean", BuildDate:"2019-02-26T12:59:46Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.6-aliyun.1", GitCommit:"01a904e", GitTreeState:"", BuildDate:"2019-02-28T13:54:16Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}

helm
Client: &version.Version{SemVer:"v2.13.1", GitCommit:"618447cbf203d147601b4b9bd7f8c37a5d39fbb4", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.13.1", GitCommit:"618447cbf203d147601b4b9bd7f8c37a5d39fbb4", GitTreeState:"clean"}

use debug
helm upgrade --install demo . --debug

apiVersion: autoscaling/v2beta1
kind: HorizontalPodAutoscaler
metadata:
  name: demo
  labels:
    app: demo
spec:
  scaleTargetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: demo
  minReplicas: 4
  maxReplicas: 40
  metrics:
  - type: Resource
    resource:
      name: cpu
      targetAverageUtilization: 35

so deployed

@anymb Hi, can you please elaborate? I'm not sure what the issue is.
I see the error in the screenshot, however this may be a kubernetes thing. Can you try helm template . first to see in the manifest looks as you expect?

@anymb Hi, can you please elaborate? I'm not sure what the issue is.
I see the error in the screenshot, however this may be a kubernetes thing. Can you try helm template . first to see in the manifest looks as you expect?

I'm sorry for the confusion. I updated my issues. The apiversion changed out of expection after I deployed the helm template.

It looks like Kubertnetes does this conversion, not helm.
Just deployed an hpa.yaml file with CPU resource and apiVersion: autoscaling/v2beta1 using kubectl and got apiVersion: autoscaling/v1 in the dump of the object back.

Internally, Kubernetes stores HPA objects in the same way regardless of which apiVersion you used to create them. When you fetch them back from the server, the API server converts the internal representation to the version requested. If no version is specified, the latest is used.
This appears to be a duplicate of https://github.com/helm/helm/issues/4976. Please follow up in that issue. Thanks!


Evaluate cardinality within the CurationConcerns Models

There are cases in which there should only be a single Resource in relation to (by ore:aggregates) other Resources.
An example of this is ensuring that Image#image_files is implemented as Image#image_file (and, further, ensuring that this is only a single Resource).

After briefly consulting with the Hydra community, the following was discovered in relation to this feature:

awead: jrgriffiniii: validations are available in AF
jrgriffiniii: awead: Specific to cardinality for aggregated_by relationships?
awead: jrgriffiniii: no, but you can write your own
awead: jrgriffiniii: the work exactly like ActiveRecord validations


Cleanup members without teams, add rekor-monitor maintainer

Adds a maintainer for rekor-monitor, removes members without teams. Also update who is in the security response team.

Summary

Release Note

Documentation

@cpanato will need to unlock users for deletion
@bobcallaway @trevrosen @lukehinds @priyawadhwa for approval


be a better open source user and search the issue tracker before creating duplicate issues

          be a better open source user and search the issue tracker before creating duplicate issues

Originally posted by @asottile in https://github.com/pre-commit/mirrors-prettier/issues/33#issuecomment-1366744994
I've been searching for a solution to this specific issue in the "closed issues" for some time now and have not been able to figure it out. If you can point to an issue where the solution is I would be tremendously grateful. Not specifying any version works, but I can't tell what the version actually installed is, and it's not supported pre-commit behavior. I am trying to install version 2.8.3. I do not want to install the alpha 3.0.0. From looking at previous issues, it looks like this may not be supported. If this is the case, please just say so. Seems mind-boggling that this would be the default behavior, as this makes it infeasible to use in conjunction with CI pipelines. Perhaps the implementation of other behavior is just extremely difficult. I don't know.
What I've tried most recently:
-   repo: https://github.com/pre-commit/mirrors-prettier
    rev: 2.8.3
    hooks:
      - id: prettier
        files: '\.(jsx?|tsx?|css)$'
        additional_dependencies:
          -<EMAIL_ADDRESS>
the error:
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-prettier.
An unexpected error has occurred: CalledProcessError: command: ('/usr/lib/git-core/git', 'checkout', '2.8.3')
return code: 1
stdout: (none)
stderr:
    error: pathspec '2.8.3' did not match any file(s) known to git

Check the log at /home/jordan/.cache/pre-commit/pre-commit.log

the output from the logfile:
### version information

pre-commit version: 2.21.0
git --version: git version 2.34.1
sys.version:
    3.10.6 (main, Nov 14 2022, 16:10:14) [GCC 11.3.0]
sys.executable: /home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/python
os.name: posix
sys.platform: linux

### error information
An unexpected error has occurred: CalledProcessError: command: ('/usr/lib/git-core/git', 'checkout', '2.8.3')
return code: 1
stdout: (none)
stderr:
    error: pathspec '2.8.3' did not match any file(s) known to git

Traceback (most recent call last):
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/store.py", line 182, in clone_strategy
    self._shallow_clone(ref, _git_cmd)
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/store.py", line 164, in _shallow_clone
    git_cmd('-c', git_config, 'fetch', 'origin', ref, '--depth=1')
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/store.py", line 179, in _git_cmd
    cmd_output_b('git', *args, cwd=directory, env=env)
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/util.py", line 143, in cmd_output_b
    raise CalledProcessError(returncode, cmd, stdout_b, stderr_b)
pre_commit.util.CalledProcessError: command: ('/usr/lib/git-core/git', '-c', 'protocol.version=2', 'fetch', 'origin', '2.8.3', '--depth=1')
return code: 128
stdout: (none)
stderr:
    fatal: couldn't find remote ref 2.8.3

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/error_handler.py", line 73, in error_handler
    yield
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/main.py", line 366, in main
    return hook_impl(
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/commands/hook_impl.py", line 254, in hook_impl
    return retv | run(config, store, ns)
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/commands/run.py", line 411, in run
    for hook in all_hooks(config, store)
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/repository.py", line 227, in all_hooks
    return tuple(
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/repository.py", line 230, in <genexpr>
    for hook in _repository_hooks(repo, store, root_config)
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/repository.py", line 205, in _repository_hooks
    return _cloned_repository_hooks(repo_config, store, root_config)
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/repository.py", line 171, in _cloned_repository_hooks
    manifest_path = os.path.join(store.clone(repo, rev), C.MANIFEST_FILE)
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/store.py", line 186, in clone
    return self._new_repo(repo, ref, deps, clone_strategy)
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/store.py", line 143, in _new_repo
    make_strategy(directory)
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/store.py", line 184, in clone_strategy
    self._complete_clone(ref, _git_cmd)
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/store.py", line 157, in _complete_clone
    git_cmd('checkout', ref)
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/store.py", line 179, in _git_cmd
    cmd_output_b('git', *args, cwd=directory, env=env)
  File "/home/jordan/.cache/pre-commit-zipapp/Lhw-Ue-PxVSsv69A3F9z4uPfLYi2T3rXWwqXQrWzFqU/wheels/pre_commit-2.21.0-py2.py3-none-any.whl/pre_commit/util.py", line 143, in cmd_output_b
    raise CalledProcessError(returncode, cmd, stdout_b, stderr_b)
pre_commit.util.CalledProcessError: command: ('/usr/lib/git-core/git', 'checkout', '2.8.3')
return code: 1
stdout: (none)
stderr:
    error: pathspec '2.8.3' did not match any file(s) known to git

For those who run into this issue, the fix was marked by the maintainer as "off-topic", and can be found here.

no, the fix is the one that has thumbs up right above it


Impossible to save blank object {} into field through ModelForm

It gets returned as None after being saved.  I've tried every combination of blank/null on the model field.  Using django 1.5, this is the basic setup:
class Thing(models.Model):
____config = JSONField(blank=True, null=True, default={})
class ThingForm(ModelForm):
____class Meta:
________model = Thing
> w = Thing.objects.all()[0]
> wf = Thingform({'config': {}}, instance=w)
> wf.errors
{}
> w = wf.save()
> w.config is None
True
>
:(

@rogual's solution worked for me too.

Seems like it's workable now, can't verify myself since we're not using this anymore, so just closing.


Encoding issues

Hi there,
seems like there is a bug with encoding somewhere. All I get is the error below. From what I know, there are no unicode characters in the source.
Any ideas on how to solve this?
Thanks!

[+] Connecting to GoPhish at https://10.XXX.XXX.XXX:3333
L.. The API Authorization endpoint is: https://10.XXX.XXX.XXX:3333/api/campaigns/?api_key=XXX
[+] A total of 1 campaign IDs have been provided for processing.
[+] GoReport will process IDs 3
()
[+] Now fetching results for Campaign ID 3 (1/1).
[+] Success!
[+] Building the report -- you selected a csv report.
[!] There was a problem processing campaign ID 3!
L.. Details: 'ascii' codec can't encode characters in position 8-9: ordinal not in range(128)

Seems like it was related to python2. Here is a small recipe to get GoReport running on kali with python3:

apt install virtualenv
virtualenv -p /usr/bin/python3 py3env
source py3env/bin/activate
pip install -r requirements.txt
python3 GoReport.py --id 3 --format word

Hey there,
I'm glad to hear you figured it out. Thanks for updating the issue. You are right -- GoReport is written entirely in Python 3, so it is needed to run GoReport.
Let me know if there are any other issues.


Add mint module to inflate every begin block

fixed #12

Add mint module to inflate every begin block
Inflated token send to fee collector and will be send to distributor to distribute to validators

After run chain investigate balance of distribution module by this endpoint


Bookmarked markets can cause getMarketsInfo before SDK is ready.

@bthaile do you recall if you fixed this one? I believe so


datapath: Fix back-edge in bpf_sock for older kernels

The commit 4fa26a4105eb2 ("datapath: Enable sessionAffinity for older
kernels") enabled the session affinity feature in bpf_sock when running
on older kernels (e.g. 4.19.57). However, the feature was broken on such
kernels due to the back-edge detected by the BPF verifier:
msg="+ tc exec bpf pin /sys/fs/bpf/tc/globals/cilium_cgroups_connect6 obj bpf_sock.o type sockaddr attach_type connect6 sec connect6" subsys=datapath-loader
subsys=datapath-loader
msg="Prog section 'connect6' rejected: Invalid argument (22)!" subsys=datapath-loader
msg=" - Type:         18" subsys=datapath-loader
msg=" - Attach Type:  11" subsys=datapath-loader
msg=" - Instructions: 740 (0 over limit)" subsys=datapath-loader
msg=" - License:      GPL" subsys=datapath-loader
subsys=datapath-loader
msg="Verifier analysis:" subsys=datapath-loader
subsys=datapath-loader
msg="back-edge from insn 624 to 570" subsys=datapath-loader
subsys=datapath-loader
msg="Error fetching program/map!" subsys=datapath-loader

This was happening, as in the backend reselection case (when a backend from
affinity cannot be found) we goto to previous lines in the code.
Fix it by immediately checking whether the backend from affinity exists.
Fixes: 4fa26a4105eb2 ("datapath: Enable sessionAffinity for older kernels")
Reported-by: Paul Chaignon<EMAIL_ADDRESS>Fix #11731

retest-4.19

retest-net-next

retest-runtime

Coverage increased (+0.04%) to 36.963% when pulling 2b5f3b2994535b2be6952328bddaeb18bc3b0730 on pr/brb/fix-back-edge-bpf-sock into 3cf91ac78eccc836467c27479b5ca7b314a9141c on master.


add spanish translations for IL - rename test file to v1-...

add spanish translations for IL - regenerate + rename test file to v1-... for IL.
To test fire up the app and run curl http://localhost:3000/api/v1/calculator?location[zip]=60304&include_beta_states=true&owner_status=homeowner&household_income=35000&tax_filing=joint&household_size=1&authority_types=state&language=es

No longer necessary since: https://github.com/rewiringamerica/api.rewiringamerica.org/pull/343


Stop game on reloading project - Fix #62088 issue

The engine will stop a game on calling restart_editor method(reloading project) so this pull request fixes #62088 issue.

Thanks! And congrats for your first merged Godot contribution :tada:


Change ci viewer email

What?
Use mercari email id.
Why?
To check the jobs running in the kubeflow ci cluster I need to change the google identity every time.
No need to switch if I use work mail id.

@Bobgy mind review?

/lgtm
/approve


Connection demo app: Connection modal

Triggered when user hits “Connect” button. Connect with MetaMask button is primary action. Modal can be cancelled/closed. Should include current network indicator.

[ ] Connect with Metamask button
[ ] Network indicator
[ ] Test

https://github.com/ConsenSys/rimble-app-demo/issues/15


Allow export default abstract class. Related to issue 3792.

Fixes (part of) #3792

@erikmcc,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@erikmcc, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

👍 LGTM

Awesome!
It is a shame this doesn't support interfaces. I tend to abide by the rule that says if you have only one export, it should be the default, and I apply this even to interfaces.
Regardless, I'm really glad to see this. Thank you!

I'm planning on fixing that next. I just wanted to see what the PR
submission process was like before investing too much time.
On Mar 31, 2017 3:26 PM, "Aluan Haddad"<EMAIL_ADDRESS>wrote:

Awesome!
It is a shame this doesn't support interfaces. I tend to abide by the rule
that says if you have only one export, it should be the default, and I
apply this even to interfaces.
Regardless, I'm really glad to see this. Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/pull/14657#issuecomment-290846489,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANbipOT8DVQ6v40yfrRGD0XRkWaA52A_ks5rrX2CgaJpZM4MdGCI
.

@erikmcc Does it make sense that I'm still getting an error if I use the export = syntax (for example, export = abstract class A)?

We are not planning on changing the export =  at the time being.


WIP: start upgrade to 2.8 and remove DS check

References #214

Running this test here and seems as though in test land Ember's event handling has changed and for some reason the height/distance of items in the DOM are also different.  Need to figure out where/why this has changed to be able to modify the tests.
master ember 2.4

this branch ember 2.8

Ok so what is interesting is upgrading from ember-cli-qunit 1.4 to >2.1 is ok.  2.2 is what causes some scroll tests to fail.  Now can dig into that.

@hhff this PR is passing now.  A few other things other than upgrading are listed above.

@snewcomer - in the past I've done const assign = Object.assign || Ember.assign.  Is that simpler?

@snewcomer - right now, a user can't use Ember Infinity without Ember Data (this.store.find or this.store.query are both ED methods)

re: Ember Data - I would like to remove the dep on Ember-Version-Is however...

@hhff I think the case for the util is if <=ie11 and no Ember.assign.  Also here is an acceptance test using a custom store and custom find method :).  Let me know your thoughts.
https://github.com/hhff/ember-infinity/pull/215/commits/450a142c71263e051c8ebbffade42ac53bb1d85b

Awesome work.  I'm cool with all of this.  Ok for me to merge?

@hhff yep if you are good with these changes!


Change Dutch translation in confirmPrompt (‘niet’ to ‘nee’)

Change Dutch translation in confirmPrompt (‘niet’ to ‘nee’).
Niet could be an option, but isn't the correct translation in this 'yes / no' context.

I will have a look if I can port the Dutch .NET BooleanRecognizer in Recognizers-Text also to JavaScript. At the moment I only created all Dutch recognizers for C#.

Pull Request Test Coverage Report for Build 1774

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.06%) to 72.404%

Files with Coverage Reduction
New Missed Lines
%

libraries/botframework-config/src/botConfigurationBase.ts
2
85.59%

Totals

Change from base Build 1771:
-0.06%

Covered Lines:
2293

Relevant Lines:
3047

💛  - Coveralls


TS-70 FEATURE - Team Edit Screen (Admin)

Hovering over the submit button turns the whole button white so you can't see it. Need to add a hoverable colour or whatever shadcn has got going on.

Toast Placement in desktop and No text currently showing

src/app/admin/teams/[teamId]/_TeamForm/index.tsx
        if (!success) return toast({ title: error, variant: 'destructive' })

        toast({ title: 'Team Updated' })
        ```

Do we want to change the toast in desktop to top right?


”Cehal”, ”Cehăluț”, ”Orbău” are listed in the drop-down menu

Description:
When user writes ”Cehal”, ”Cehăluț”, ”Orbău” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Cehal"

Expected results
The location appears in the drop-down menu as "Sat Cehal, SATU MARE (Cehal)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Cehăluț"

Expected results
The location appears in the drop-down menu as "Sat Cehăluț, SATU MARE (Cehal)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Orbău"

Expected results
The location appears in the drop-down menu as "Sat Orbău, SATU MARE (Cehal)".


test3

3rd test PR

hello bulldozer

merge when ready

merge when ready

merge when ready

merge when ready

merge when ready

merge when ready

merge when ready


Update README.md

Blazemeter course about jmeter

My mistake .. the course is already in another section

Added to another section.
Thank you for update.


[CP] Set template and migrate apps to iOS 12 minimum

Issue Link
https://github.com/flutter/flutter/issues/136060
Target
stable
PR Link
https://github.com/flutter/flutter/pull/140921
Changelog Description
Automatically migrate apps to iOS 12 as the minimum deployment version.
Impacted Users
iOS end-customers running Flutter apps using common networking APIs
Impact Description
Shipping production apps that use common iOS Networking APIs, such as in connectivity_plus, crashes on launch.
Workaround
The developer can increase their minimum iOS deployment version to iOS 12 and re-ship their app.
Risk
medium
Test Coverage
yes
Validation Steps
No response

@vashworth @stuartmorgan for review please.


{Packaging} Fix version to conform to pip 20.3

Description

Edge build is broken as pip now compares the version in the wheel package name and the version in Metadata. Previously, we only added .post1 in package name. This PRs changes the version in source code with .post1 suffix as well when building packages for non-release branch code. This also helps us identify requests from edge builds in telemetry data.
CI is broken as azure-cli-core previously pinned azure-cli-telemetry to 1.0.6 while in CI 1.0.6.devxxx is installed. Latest pip will throw an error. This PR changes the dependency version to azure-cli-telemetry==1.0.6.*.
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Packaging


added API support for i18n, subpages and static field values

This is safe to merge but not final yet. I could use your help @mateomorris !

Line 7: the language should be tested against the available languages from the builder, it worked locally but not on Vercel
Line 9: Only needed for line 17
Line 17: We should also match the parent url in case there are multiple subpages with the same url but different parent

Known bugs:

If you have a 1st-level page with a 2-letter url it will think it's a language code and return no results, also no error

Features under consideration

Markdown fields return both html and markup code, this is not efficient and we should filter it by a ?format= URL query parameter
Remove database ids from response
Add sort and limit URL query parameter for pagination

A little backstory: I was tired of updating the category or widget components whenever adding a new product or article.
Using the the following component I can load all the blog posts from the blog posts pages via the API. It does slow down deployment, probably hangs when having too many posts but it's ok for me atm.
News.json
The data is fetched during deployment, not on client-side. There's no reason to spam requests to the primo server when the data change only during deployment. I am applying a 5 post pagination, ideally this should be implemented in the API.
Known Bug: If you hit deploy too fast after adding a post it might not be included in the component above, give it a few seconds to be written in the database first.

Line 7: the language should be tested against the available languages from the builder, it worked locally but not on Vercel
Okay I went ahead and exported the languages from primo builder and imported them

Line 9: Only needed for line 17
Line 17: We should also match the parent url in case there are multiple subpages with the same url but different parent
Fixed the parent url matching for sections. looks like you might have been selecting page!inner twice, causing the issue.

Markdown fields return both html and markup code, this is not efficient and we should filter it by a ?format= URL query parameter
Add sort and limit URL query parameter for pagination
Agreed. I don't have more bandwidth atm so we might want to merge it in as in unless you can keep working on it.

Remove database ids from response
Any particular reason you want to remove them? I figured they'd be useful to target specific pages/sections by their ID (for example, to select particular sections on a page without worrying about them being moved around).

Fixed the parent url matching for sections. looks like you might have been selecting page!inner twice, causing the issue.

Damn, how did I miss that...

Agreed. I don't have more bandwidth atm so we might want to merge it in as in unless you can keep working on it.

Yes, I'll keep working on this.

Any particular reason you want to remove them? I figured they'd be useful to target specific pages/sections by their ID (for example, to select particular sections on a page without worrying about them being moved around).

Just to save bandwidth I guess as I don't use them, but they can stay if they're useful.
How about sort and limit? I think I should add those as well.

Just to save bandwidth I guess as I don't use them, but they can stay if they're useful.

Okay, let's leave them then since they're the only way to absolutely select a page/section.

How about sort and limit? I think I should add those as well.

For sure! What about pagination?

Love the use of the module in the JS tab lol. Does that not run again in the client though?

For sure! What about pagination?

Limit start,end should take care of pagination and we only need to add a total_pages value somewhere in the response. I'll do a commit tomorrow.

Love the use of the module in the JS tab lol. Does that not run again in the client though?

OMG you are right, I just assumed context="module" scripts would only run server-side. I can't use import { browser } from '$app/environment' in there either...
I worked around that using window but then I stumbled upon the fact the the code would not work in the primo iframe as well... Any solutions to that?

I can't use import { browser } from '$app/environment' in there either...

I think '$app/environment' only works in SvelteKit.

I worked around that using window but then I stumbled upon the fact the the code would not work in the primo iframe as well. After some messing around it worked in the iframe and the deployment but blog was overwritten to an empty array on production...

Yeah it looks like when it runs again in production it overwrites the statically rendered content. So I figured that we could output that data as raw json into a hidden div and then pull that instead of fetching data from the API.
const server_host = 'myprimoserver.com'
let blog = []
if (window.location.host === '' || window.location.host === server_host) { // in iframe or primo server (i.e. generating pages)
  blog = await fetchPosts().catch(error => console.error('Error fetching posts:', error));
} else { // in production
  const blog_json = document.querySelector('#blog-json') // get stored data
  blog = JSON.parse(blog_json.innerHTML)
}

Here's the full Block
News (1).json

wow, you are hackier than me!
some minor improvements:
let blog = []
if (typeof window === 'undefined' || window.location.host === server_host || window.location.ancestorOrigins[0] === `https://${server_host}`) {
  blog = await fetchPosts().catch(error => console.error('Error fetching posts:', error));
} else {
  const blog_json = document.querySelector('#blog-json')
  blog = JSON.parse(blog_json.innerHTML)
  document.querySelector('#blog-json').remove()
}

P.S. When this PR is merged I'll write a guide on this and call it "Don't Repeat Yourself", it really saves a lot of time and copy-paste errors. I wonder how I didn't try this sooner tbh...

This isn't extensively tested, but it works. I also moved the sections sorting to the supabase query.
Breaking changes for people already using the API

If you use a 2-letter language code as the url of a top level page for any reason, the API will assume it is a language and won't serve that page or its subpages, without any errors
If you have more than 10 subpages and/or perform your own pagination you need to update your code and use range as a url parameter and look for subpages_total in the response to figure out the pagination

P.S. The API is not strictly typed. Expect errors when you pass bad parameters.
P.S.2. I wish there was a better way to switch between html and markdown but I couldn't think of any.

Thanks @rallisf1! Looks great


Restart command when stopped on odo push

What type of PR is this?
/kind bug
What does this PR do / why we need it:
odo push checks that the component is running on the container. If not, it starts it
Which issue(s) this PR fixes:
Fixes #4822
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

[ ] I have read the test guidelines

How to test changes / Special notes to the reviewer:

Also, please have a look at the second part of the resolution in this PR: https://github.com/openshift/odo-init-image/pull/93

But I'm confused by the functions CheckSupervisordCtlStatus and GetSupervisordCtlStatus.

Of course, the name is causing most of the confusion.

But besides that, IIUC, they both are checking/getting the status of the devfile run/debug command and the not the status of supervisord command itself. The name kinda suggests as though we're checking if supervisord itself is running fine in the pod.

@feloy do you think we can do something about this? I didn't LGTM because I found this a bit concerning.

But I'm confused by the functions CheckSupervisordCtlStatus and GetSupervisordCtlStatus.

Of course, the name is causing most of the confusion.
But besides that, IIUC, they both are checking/getting the status of the devfile run/debug command and the not the status of supervisord command itself. The name kinda suggests as though we're checking if supervisord itself is running fine in the pod.

@feloy do you think we can do something about this? I didn't LGTM because I found this a bit concerning.

Yes, I'll try to make this clearer

@dharmit I had to make some changes (renaming is not as easy as F2 when interfaces are involved :( ) Can you please lgtm again if the tests pass?

@dharmit I had to make some changes (renaming is not as easy as F2 when interfaces are involved :( ) Can you please lgtm again if the tests pass?

Oh. I'm sorry about that. Can I suggest you to try GoLand for such cases? I'm not sure about .go files, but I have been using it even when writing odo docs. When I try to delete a file, it does a sanity check in the repo if that file is being referenced anywhere. Out of curiosity, I tried the same on VS Code, but it didn't perform checks like that.

/lgtm
As the review feedback has been addressed.

I'm not sure about .go files, but I have been using it even when writing odo docs. When I try to delete a file, it does a sanity check in the repo if that file is being referenced anywhere. Out of curiosity, I tried the same on VS Code, but it didn't perform checks like that.

@feloy I can confirm that GoLand does indeed make renaming simpler. I renamed a method in the pkg/odo/cli/service/interface.go file just to play with things, and it renamed it across the code wherever it was being implemented. Rename option is under Refactor when you right-click on a method name. Or use Shift+F6 shortcut.


Slither + Mythril

The result can be found here: https://www.notion.so/bisonai/SM-security-audit-with-slither-and-Mythril-6fadd8c2459a47449fdf2a053dced1d9

@KelvinThai I am going to close this as completed okay? We have created a separate issues for each finding and later we can go through this together.

let's reopen this issue. I'll dive deeper, solve all the reds and yellows, If that's not the problem, I'll explain to the auditors we've alr acknowledge all automated tests through an official document

@KelvinThai Let's focus on this next week if we accomplish everything on the application side.

@KelvinThai Closing :)


Implement Tag SpecialKey || Round 2

NOTE: This PR was remade due to an error that occured when re-syncing my branch with main. Not sure why it happened, but it's not letting me reopen the original pull request.
Fixes #36
This PR might be dependent on #216 due to xtypeof being removed, if necessary we can wait for that to be merged and then modify this code accordingly.

Don't worry, it won't be removing xtypeof :)

Sweet! Will work on this at home!

Btw will be departing soon for RDC so will prob be going quiet for a bit. Feel free to work on stuff and I can help out more usefully when I get back.

All good! Will probably do some work soon and see what I can done

There's been no motion on this PR, so I'm closing it. Design work is continuing over in #137


Project Setup

Hope no one minds but I went ahead and set up the repo and open a PR  ( #1 ) with a basic hardhat project.
Like me, I think there are quite a few people new to Solidity so thought it would be good to collaborate on how the to get a good dev / test environment set up from scratch in here so it's documented and an opportunity for everyone to learn.
My understanding is the next steps for are to get a good localnetwork and testnet configured but have seen a few different configurations (and think we might need an account at infura) so before pushing ahead wanted to get others input and feedback on how we should set this up.

Ey. So, I'm ready to start uploading the backgrounds and the flags. Uploads are disabled, it seems.


Closing the main window makes Teams unusable

Environment Mac OS X 10.14.6
Teams: <IP_ADDRESS>258.
It happened to me several times, accidentally clicking Cmd+W and closing the main Teams window. After that there seems to be no way to reopen it from the Teams app. Other apps like Slack etc (or even Outlook) have the shortcuts to reopen the windows, such as Cmd+1 in Outlook. When I accidentally close Teams window, the only way to get back is to restart the app.

@ngrigoriev Thanks for reaching out. We are looking into this?

@ngrigoriev Could you please share a video recording of the issue?

Please re-open with requested information.

I have found a work-around for your problem - teams window can be reopen by launching it again (while the app is still running with the main window closed) or by clicking Teams icon in the dock. If you do not want to spend 30 seconds reproducing it as per my clear description, why should I spend 5 minutes recording and posting the video?


Adding QTab support With Stipple Routing Support

Currently, I had a conversation with @AbhimanyuAryan  about adding QTab support.
I had started work on this in PR #44 but it had to reverted as QTab support is tricky as it relies on the Vue Router.
In that PR, Abhi said we could do something like this:

@TheCedarPrince you can solve this with a hacky solution i.e. redirect. Where you can redirect to a route on tab click which \about let's say renders a different stipple view. But as I said this is hacky

The best way to solve this is add support for frontend routing and let vue-router/stipple-router handle it which doesn't trigger Genie routing. That will also be faster and more efficient

However, I have no idea how to do this so I am turning it over to you Abhi to add additional thoughts here.
I opened a PR #46 to add in code ideas for our discussion.

cool I'll discuss the best possible approach with Adrian and follow will follow up on this

got it!
Thank you!
let me know if I can help out here.
Looking forward to what you and @essenciary come up with!

Thanks @TheCedarPrince - this is not trivial as the UDM version of quasar does not support Vue Router. We'll check if we can add it or if there is some other router/routing option.

Thanks @TheCedarPrince - this is not trivial as the UDM version of quasar does not support Vue Router. We'll check if we can add it or if there is some other router/routing option.

Oh I didn't realize that...
@essenciary and @AbhimanyuAryan , there were two alternatives I was also considering given the fact that the Vue Router is more complicated than I expected:

I noticed while looking through the Quasar Tab documentation for QRouteTab, there seems to be a field called href which does something similar to what I wanted in that it can connect to another webpage. Although it doesn't use routing, I could use it as a stopgap perhaps.
Could buttons in StippleUI work where each button hooks into the router for routing to another webpage?

In terms of routing, I really do not care about the Vue Router but would be happy to take advantage of the Stipple/Genie routing provided by the GenieFramework.
Is it possible to override the to statement in QRouteTab with a custom function that, on tab click , routes you to another page on the website?
I realize I am a bit out of my depth here but just seeing if these ideas are at all feasible.
Thanks for all the support!

@TheCedarPrince have you tried using  href with QRouteTab I have a strong felling this should serve your use case

I'm not sure about this QRouteTab won’t and cannot work with the UMD version because in that environment you don’t have Vue Router in Warning. Also, not sure if entire component will work in isolation if you don't need vue-router functionality and only want to use href. I need to clarify this maybe create an issue on Quasar repo

Hey @AbhimanyuAryan ,
I have tried using href before but couldn't get it working.
So, not sure what else to do here.

Ok let me create a MWP

https://github.com/AbhimanyuAryan/MultiRoute

You can also use buttons in Stipple for routing @TheCedarPrince try this example
using Stipple, StippleUI

@reactive! mutable struct ButtonModel <: ReactiveModel
  press_btn::R{Bool} = false
end

function handlers(button_model)
  on(button_model.press_btn) do press_btn
    press_btn || return
    @info "pressed"
    button_model.press_btn[] = false
  end
  button_model
end

function ui(button_model)
  page(
    button_model,
    title = "Button Components",
    class = "q-pa-md q-gutter-sm",
    [
      btn("On Left", color = "primary", icon = "mail", @click("press_btn = true")),
      btn("Go to Hello World", color = "red", type = "a", href = "hello", icon = "map", iconright = "send")
    ]
  )
end

route("/") do
  init(ButtonModel) |> handlers |> ui |> html
end

route("/hello") do
  "Hello World"
end

up()

use property href and type= "a" for button navigation

Thanks @hhaensel much cleaner


Should we encourage folks to use yarn instead of npm?

https://www.atatus.com/blog/everything-you-wanted-to-know-about-yarn-package-manager/
It seems it's getting some good reviews, and may help us get the install time down to a reasonable number. Any thoughts?

I'm cool with recommending this 👍 How do you see us encouraging it?

[ ] Where we have npm install now, show yarn add
[ ] Where we have npm install now, add a quick link / explanation about yarn and its speed boost
[ ] Add a mention to it in Troubleshooting question:

Is the google-cloud module on npm really 800 MB?

[ ] Add a new question: "Can I use yarn?"
[ ] Other?

I think with npm@5, the yarn performance benefits aren't as glaring. My vote would be to continue recommending npm.
@jmdobry @callmehiphop any thoughts?

We've been using Yarn in all our Node.js samples since Yarn was version 0.16. The Google App Engine docs have a section on using Yarn. I think it's worth at least mentioning Yarn.

Ping for status on this?  Is there an action for google-cloud-node or can I close this issue?

I don't think it's necessary to mention yarn. As far as I know, any npm package is also supported by yarn, so we don't have to spell that out. I wouldn't go so far as to recommend that folks use yarn instead of npm. And I don't think yarn needs our help with marketing, if we were to only mention that it exists.
@lukesneeringer: how should we proceed?

I agree with @stephenplusplus. Lets stick with simply documenting npm. Closing this. @lukesneeringer reopen if you feel we need to mention yarn.


Automated cherry pick of #11140

Cherry pick of #11140 on release-7.1.
/cc  @babinderrathi
NONE

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: f6c2c880afe356832145f1156bc6ec80edb49b73


Update iohk monitoring

references katip in hackage/stackage again.
update of iohk-monitoring

bors r+


Deleting entry flickers and shows it for a second before finally removing it

The one flicker I've seen so far is deleting my test task... I deleted it, it went away, it came back for a second but then went away so it worked itself out in the end. Not perfect, but I can definitely work with that.

https://github.com/toggl/toggldesktop/issues/2183#issuecomment-308249425
reported on windows

is fixed with syncing fixes. Fixed with version 7.4.52


upgrade: resin-corvus to v1.0.0-beta.31

This version contains a couple of patches to ensure that the Mixpanel
library doesn't send any HTTP request to api.mixpanel.com unless the
user enabled analytics.

https://github.com/resin-io-modules/resin-corvus/pull/35
https://github.com/resin-io-modules/resin-corvus/pull/36

See: https://github.com/resin-io/etcher/issues/1772
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

Just to be pedantic, the bump of resin-corvus from v1.0.0-beta.30 to v1.0.0-beta.31 also includes https://github.com/resin-io-modules/resin-corvus/pull/34  (which hopefully doesn't trigger the "any internal change can break this fix" comment that @jviotti made in https://github.com/resin-io-modules/resin-corvus/pull/35#issuecomment-347027542 ?)

I'll give my changes one more go on this branch, just in case.

Works fine. In case someone wants to test, don't forget to also apply https://github.com/resin-io/etcher/pull/1879, which is the other side of the fix :)


FEATURE: Add a button to switch back to small chat

This feature, in addition to adding a button to get back to small chat
from being in the full-page chat, adds memory to the window size.
This means that if you prefer to open chat in full-size when using the
sidebar it will remember which preference you have set when opening
channels.
See: https://meta.discourse.org/t/221388

This only remembers the preference as long as you don't refresh, right?

It saves it in local storage, so it should remember on refresh. It will be per device though.

and in which case maybe we surface it in the user preference UI

The design comments from Sam were to avoid having a user preference for this.

@oblakeerickson ah I see I didn't realise KeyValueStore saved to localstorage :+1: Thanks for the clarification, will approve :)

why do we need chatWindowFullPage still if we have a dedicated chat-window-store?

well... I added it as a wrapper for the chat-window-store inside of chat.js because I couldn't get it the store service to work inside of the chat-header-icon widget. /shrug


Support for Table tennis

It would be good if there was some example support for table tennis. There is a model detection model here: https://github.com/sisrfeng/TTNet. If that can be used, maybe adding support to figure out when a point starts and when it ends would be helpful in analyzing matches

Hi @mkirank 👋🏻 I've seen some fantastic table tennis AI demos online. I'd love to tackle this, but I'm not sure when I'll be able to get to it. Sports AI is just a side project, and I only work on it from time to time. Perhaps we could build a community around this project and someone else could help us build an open-source table tennis AI.

One challenging thing is detecting the ball due to the high speed and also the small size probably some approches like using sequential model would be a good choice (catch the curves of the ball, etc ...) or as input getting higher fps (more difficult to have in real world)

There is an example if it helps, here https://github.com/Ploruto/TTNet-Real-time-Analysis-System-for-Table-Tennis-Pytorch


Removed warning on README for using covsirphy with Google Colab

Related issues
What was changed

Related issues
#1369
What was changed
Close #1369 by removing the warning on README.

Welcome, I just started contributing as a beginner.
So sorry for not submitting the pull request as provided by the Guidelines.


Problem

Hey,
after setting go environment when i start 'make' a receive the following:

checking code style
running check for unused/missing packages in go.mod
GO111MODULE=on go mod tidy
go: downloading github.com/prometheus/common v0.10.0
go: downloading github.com/prometheus/client_golang v1.7.1
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading gopkg.in/alecthomas/kingpin.v2 v2.2.6
go: downloading gopkg.in/check.v1 v1.0.0-20200227125254-8fa46927fb4f
go: downloading github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751
go: downloading github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d
go: downloading github.com/stretchr/testify v1.5.1
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading golang.org/x/sys v0.0.0-20200724161237-0e2f3a69832c
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/prometheus/procfs v0.1.3
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e
go: downloading github.com/konsorten/go-windows-terminal-sequences v1.0.3
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading google.golang.org/protobuf v1.25.0
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/kr/text v0.2.0
go: downloading github.com/google/go-cmp v0.5.0
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
running check for unused packages in vendor/
GO111MODULE=on go mod vendor
Not a git repository
To compare two paths outside a working tree:
usage: git diff [--no-index]
Makefile.common:212: recipe for target 'common-unused' failed
make: *** [common-unused] Error 129

can you please help me

Hm, I am not quite sure what's going on there. Can you try with a completely clean GOPATH (i.e. create an empty temporary one and try with that)?

Closing, as I am assuming it's no longer an issue. Reopen if necessary.


conditional default preselections for Analyze UI due to recent type=required addition

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1777
Originally created by @derek-knox on 2020-02-21 17:13:08

Follow-up to https://gitlab.com/meltano/meltano/-/merge_requests/1474#note_292440493

One minor note is that I think that this will select the first column even if a required column is set bellow it.
If that's true, this should not be the case in the presence of required attributes: We auto-select the first column cause we want to show a report on load and we are not sure what to show. But when a required attribute is set, we know that the intended behavior is to use that column, so why also select the first one?

FWIW I anticipate this being < 30min (likely much less)

View 2 previous comments from the original issue on GitLab


text selected in a comment is unreadable

Starting with the addition of the Ninja Edit theme on both stable (4.0) and dev (4.1.5124).

Comparison with 3.5:

Whomever made the new theme (which could have been anyone) may have made a last-minute change to selection colors before the 4.0 stable release.
At any rate, it's now fixed in builds >= 4.1.5706-dev:

(As you can see, this also affected things like annotations and low-confidence types. Oops.)
Furthermore, I've made a small change to token selection color as well.
Before:

After:

Combined with an earlier change to local variable token color in HLIL, this should mean 4.1 has proper contrast and color in all scenarios now. 🤞🏼


[BUG]: TS types broken in v5

Describe the bug
Ran tsc against our project after upgrading sentry-testkit to 5.0.0:
packages/modules/application/__tests__/core/application/reportError.test.ts:3:52 - error TS7016: Could not find a declaration file for module 'sentry-testkit'. '/Users/liam.jones/code/proj/node_modules/sentry-testkit/dist/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/sentry-testkit` if it exists or add a new declaration (.d.ts) file containing `declare module 'sentry-testkit';`

3 import sentryTestkit, { Report, ReportError } from 'sentry-testkit'
                                                     ~~~~~~~~~~~~~~~~

To Reproduce
Try and type check a project against 5.0.0
Expected behavior
Type check passes
Sentry Versions (please complete the following information):

Sentry: 4.6.1
Sentry-Testkit 5.0.0

I think this is happening because the package.json says:
"types": "index.d.ts"
and that file doesn't exist.

@liamjones thanks for upgrading and report this right away, I was missing the right pointer for the types file in package.json, sorry for the sloppiness here

It's moved on but it's still not happy. Cmd+clicking through to types shows it's finding dist/index.d.ts but that has been generated as an empty object:
export {};
//# sourceMappingURL=index.d.ts.map

I released<EMAIL_ADDRESS>It resolves the empty export thing, but not yet complete solution.
Since I'm trying to support both Sentry v6 and Sentry v7 (btw, is this working for you on Sentry v4?, I have issues with sentryTransport signature:
transport: sentryTransport,
^^^^^^^^^

I see that you're the TS expert who brought us this:
  type V6TransportClass = {
    new (): Transport
  }

  type V7TransportFunction = () => Transport

We're at the weekend here, I'd appreciate if you can help and PR or we will wait for next week, when I can get my colleagues to work on it.

released version<EMAIL_ADDRESS>where sentryTransport: any so TS compiler won't show errors for now

closing this bug as it has been resolved.
opening different issue https://github.com/wix/sentry-testkit/issues/142 to handle better typings for sentryTransport

We're at the weekend here, I'd appreciate if you can help and PR or we will wait for next week, when I can get my colleagues to work on it.

@zivl apologies, I was on holiday last week and I've only just seen this. I'll see if I can take a look on the new issue this week sometime.

@liamjones sure thing!
Thanks :)


WinRT projections createWith does not work on CALayerXaml instances

I’m passing one of our CALayerXaml objects as IInspectable* into WXFrameworkElement::createWith (or WXCPanel::createWith), but the call fails in verifyCastConformance:
// Grab the layer's backing XAML node
Microsoft::WRL::ComPtr<IInspectable> inspectableNode(GetCACompositor()->DisplayNodeToXamlNode([self->layer _presentationNode]));
self->priv->xamlElement = [WXFrameworkElement createWith:inspectableNode.Get()];

verifyCastConformance calls GetIids on the object passed in, but it's only returning 3 GUIDs:
These are the only IIDs I see for this object after the call to GetIids;
iids[0]       {B93C018E-5625-3D8D-82B7-11655397C0B8}   _GUID
numSupported  3      unsigned long
iids[1]       {9C00AB21-B6BD-3C4C-AE76-E7FB5CA6CD18}   _GUID
iids[2]       {IID_IWeakReferenceSource} _GUID
         obj    0x011b1870 {m_originSet=false m_backgroundColor={A=0 '\0' R=0 '\0' G=0 '\0' ...} m_backgroundBrush=0x083f1178 {...} ...}  IInspectable * {UIKIT.DLL!XamlCompositor::Controls::CALayerXaml}
         [XamlCompositor::Controls::CALayerXaml]  {m_originSet=false m_backgroundColor={A=0 '\0' R=0 '\0' G=0 '\0' ...} m_backgroundBrush=0x083f1178 {...} ...}       UIKIT.DLL!XamlCompositor::Controls::CALayerXaml
         Windows::UI::Xaml::Controls::Panel {...}  UIKIT.DLL!Windows::UI::Xaml::Controls::Panel

It's unclear to me how I can work around the issue.  I tried various casts on the C++/CX object to get to its IInspectable*, but all attempts resulted in the same 3 GUIDs returned from GetIids.  Is it possible we should be calling a different function in verifyCastConformance?

I believe we fixed this a while ago, but forgot to close out the bug.


PR for class

I added a couple simple features to the random guess python file. Feel free to ignore this PR, I have to do it for class :)

Hi Katie,
I am so happy to see your pull request, why would I ignore it!?
First, thank you and second thing, why don't you add Java?
I say some repositories and I know they are for 5 years ago but just wanted to have some more Java here :)
Lope you be successful in your class. If I can help you in any cases, feel free to ask.
All in all, thanks a lot.
Amir.

Hi Katie,
I am so happy to see your pull request, why would I ignore it!?
First, thank you and second thing, why don't you add Java? I say some repositories and I know they are for 5 years ago but just wanted to have some more Java here :)
Lope you be successful in your class. If I can help you in any cases, feel free to ask.
All in all, thanks a lot. Amir.

Thank you! It was a very small contribution but I'm glad you liked it. If I have some extra time today I'll add some more to the Java games/make a new one :)

Yes! I have a lot of time. Send and I'll merge them as soon as possible.


APIs for Stocks

Discord chat

Can you describe what's the issue?

@surajondev We have to create APIs for our new feature. This is currently assigned to our members. Feel free to join our discord server: [Invite Link]

Okay, Thank You


chore: pin dev dependencies

Summary

Issues

Coverage remained the same at 100.0% when pulling 5c4521edfb6fbeee21a1438710dd7b48407e18fe on dev-deps-pin into c61653a1f949d5c9786c152f6556536cebe24f55 on main.


RICH.text

Traceback (most recent call last):
File "/Users/ariebensimon/main.py", line 7, in
from rich.text import Text
ModuleNotFoundError: No module named 'rich'
No rich.text file in folder ... help plz
thanks

You don't need a rich.txt file. The message clearly says what's the issue - the rich Python package is missing.
Did you install all of the requirements?
pip install -r requirements.txt

If you don't know how to use Python, just download the prebuilt binaries from the releases page. That's the easiest way to get started.

Allright  thanks

running now but have this error
How many iCloud emails you want to generate?: 5
[16:31:58] Generating 5 email(s)...                                                                                main.py:94
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 980, in _wrap_create_connection
return await self._loop.create_connection(*args, **kwargs)  # type: ignore[return-value]  # noqa
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 1112, in create_connection
transport, protocol = await self._create_connection_transport(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 1145, in _create_connection_transport
await waiter
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/sslproto.py", line 574, in _on_handshake_complete
raise handshake_exc
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/sslproto.py", line 556, in _do_handshake
self._sslobj.do_handshake()
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/ssl.py", line 979, in do_handshake
self._sslobj.do_handshake()
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:992)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/Users/ariebensimon/main.py", line 185, in
loop.run_until_complete(generate())
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 653, in run_until_complete
return future.result()
^^^^^^^^^^^^^^^
File "/Users/ariebensimon/main.py", line 174, in generate
await hme.generate()
File "/Users/ariebensimon/main.py", line 99, in generate
batch = await self._generate(
^^^^^^^^^^^^^^^^^^^^^
File "/Users/ariebensimon/main.py", line 82, in _generate
return filter(lambda e: e is not None, await asyncio.gather(*tasks))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/ariebensimon/main.py", line 37, in _generate_one
gen_res = await self.generate_email()
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/ariebensimon/icloud/hidemyemail.py", line 65, in generate_email
async with self.s.post(
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/client.py", line 1141, in aenter
self._resp = await self._coro
^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/client.py", line 536, in _request
conn = await self._connector.connect(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 540, in connect
proto = await self._create_connection(req, traces, timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 901, in _create_connection
_, proto = await self._create_direct_connection(req, traces, timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 1206, in _create_direct_connection
raise last_exc
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 1175, in _create_direct_connection
transp, proto = await self._wrap_create_connection(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 982, in _wrap_create_connection
raise ClientConnectorCertificateError(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorCertificateError: Cannot connect to host p68-maildomainws.icloud.com:443 ssl:True [SSLCertVerificationError: (1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:992)')]
Task was destroyed but it is pending!
task: <Task pending name='Task-2' coro=<RichHideMyEmail._generate_one() running at /Users/ariebensimon/main.py:37> wait_for=<Future pending cb=[BaseSelectorEventLoop._sock_write_done(8, handle=<Handle BaseS...2.166', 443))>)(), Task.task_wakeup()]> cb=[gather.._done_callback() at /Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/tasks.py:754]>
Task was destroyed but it is pending!
task: <Task pending name='Task-3' coro=<RichHideMyEmail._generate_one() running at /Users/ariebensimon/main.py:37> wait_for= cb=[gather.._done_callback() at /Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/tasks.py:754]>
Task was destroyed but it is pending!
task: <Task pending name='Task-5' coro=<RichHideMyEmail._generate_one() running at /Users/ariebensimon/main.py:37> wait_for= cb=[gather.._done_callback() at /Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/tasks.py:754]>
Exception ignored in: <coroutine object RichHideMyEmail._generate_one at 0x101e7e790>
Traceback (most recent call last):
File "/Users/ariebensimon/main.py", line 37, in _generate_one
File "/Users/ariebensimon/icloud/hidemyemail.py", line 65, in generate_email
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/client.py", line 1141, in aenter
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/client.py", line 536, in _request
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 540, in connect
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 901, in _create_connection
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 1175, in _create_direct_connection
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 980, in _wrap_create_connection
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 1112, in create_connection
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 1147, in _create_connection_transport
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/sslproto.py", line 112, in close
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/sslproto.py", line 616, in _start_shutdown
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/sslproto.py", line 666, in _abort
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/selector_events.py", line 819, in abort
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/selector_events.py", line 870, in _force_close
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 761, in call_soon
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 519, in _check_closed
RuntimeError: Event loop is closed
Exception ignored in: <coroutine object RichHideMyEmail._generate_one at 0x101e7e9b0>
Traceback (most recent call last):
File "/Users/ariebensimon/main.py", line 37, in _generate_one
File "/Users/ariebensimon/icloud/hidemyemail.py", line 65, in generate_email
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/client.py", line 1141, in aenter
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/client.py", line 536, in _request
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 540, in connect
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 901, in _create_connection
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 1175, in _create_direct_connection
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 980, in _wrap_create_connection
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 1112, in create_connection
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 1147, in _create_connection_transport
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/sslproto.py", line 112, in close
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/sslproto.py", line 616, in _start_shutdown
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/sslproto.py", line 666, in _abort
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/selector_events.py", line 819, in abort
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/selector_events.py", line 870, in _force_close
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 761, in call_soon
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 519, in _check_closed
RuntimeError: Event loop is closed
Task was destroyed but it is pending!
task: <Task pending name='Task-6' coro=<RichHideMyEmail._generate_one() running at /Users/ariebensimon/main.py:37> wait_for= cb=[gather.._done_callback() at /Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/tasks.py:754]>
Exception ignored in: <coroutine object RichHideMyEmail._generate_one at 0x101e7eac0>
Traceback (most recent call last):
File "/Users/ariebensimon/main.py", line 37, in _generate_one
File "/Users/ariebensimon/icloud/hidemyemail.py", line 65, in generate_email
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/client.py", line 1141, in aenter
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/client.py", line 536, in _request
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 540, in connect
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 901, in _create_connection
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 1175, in _create_direct_connection
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/connector.py", line 980, in _wrap_create_connection
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 1112, in create_connection
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 1147, in _create_connection_transport
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/sslproto.py", line 112, in close
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/sslproto.py", line 616, in _start_shutdown
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/sslproto.py", line 666, in _abort
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/selector_events.py", line 819, in abort
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/selector_events.py", line 870, in _force_close
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 761, in call_soon
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 519, in _check_closed
RuntimeError: Event loop is closed