Assets / Fungus-Playmaker / FungusStateTransition.cs (3,7): Error CS0246: Could not find type or namespace name 'Fungus'. Are you missing a using directive or an assembly reference?

 How can I fix it?
Assets / Fungus-Playmaker / FungusStateTransition.cs (3,7): Error CS0246: Could not find type or namespace name 'Fungus'. Are
you missing a using directive or an assembly reference?
Unity version 5.3.0f4

There are 2 potential issues here.

You are missing Fungus or it was not installed correctly. I don't know what Fungus-Playmaker is but it sounds like it's a collection of helper classes and does not include Fungus by default. If Fungus is installed, make sure it's not in any subfolders like Scripts/Fungus and all of its assets are in Assets/Fungus. The Unity Package in Releases should do this for you.

I see you're using Unity 5. I know Unity 5 is in the minimum requirements but I don't think it's recommended with the curernt build. The oldest version I could get it working on was 2017. If everything else supports it and you're not in the middle of production, I would switch to a version like 2019-2020 since Fungus is stable on those versions.

Let me know if nothing else is working; this doesn't seem to be a Fungus specific bug but more user-specific. I would also join the Fungus Discord for one on one help.


Refactor TF Dataset

After talking with @EiffL and @b-remy, we decided to converge on a more usable format for our tfds.
We will have a simple galaxy generator dataset and one based on parametric COSMOS galaxies drawn as CFIS-like stamp images.
This issue is to discuss some design choices and track/discuss this development.
Issues/todo:

[x] sample COSMOS realistic images (gal_type='parametric')
[x] rescale the flux for CFIS like images
[ ] should we put a threshold to remove too faint galaxies?
[ ] do we want to add random knots for realistic images?
[ ]  After the CFIS magnitude cut we may want to augment our dataset. What kind of augmentation? Ellipticities only or also size, SNR, etc.

What do you think about these open questions, @EiffL ?

Yep :-) but I'm a bit confused, I thought we had already done all of that. I remember discussions like here: https://github.com/CosmoStat/autometacal/issues/39

Otherwise I want to say no to knots for now, and we will need to keep fairly faint galaxies in order to apply the selection cuts.

And the only form of augmentation we can make is generating the noise on the fly instead of hardcoded in the dataset

Yep :-) but I'm a bit confused, I thought we had already done all of that. I remember discussions like here: #39

We did, but the current state of the module is not satisfactory, still.

And the only form of augmentation we can make is generating the noise on the fly instead of hardcoded in the dataset

This is kind of a problem. The COSMOS dataset is small, isn't it? We need more than 80k galaxy models.

No it's not really a problem, you can apply random rotations to galaxies, and generate independent noise realisations. At least for training a NN it's more than enough

Ok, that's kind of the data aug I was talking about.

Yep but this can be done on the fly most likely.


Sharing Tab: incorrect error 'Must have at least one visible contributor'

Steps

Go to a project you are admin on
Go to the project sharing tab
Add another contributor, preferably one that is also you
On the sharing tab, in the contributor table give the contributor that is not you read only permissions and save the changes
Now uncheck the box for yourself to be bibliographic, but do not change you admin status. Save the changes
Reorder the contributors so that the read access bibliographic contributor is first and the admin non-bibliographic contributor is second. Save the changes
Now drag to reorder the contributors, moving the first into the second position

Expected
I would expect the reorder would not initiate the error message and would only show the save changes button.
Actual
The reorder causes an error on the page the 'Must have at least one visible contributor', which is incorrect.

@nanchen47 Can you assign me to this?

Yours!

@nicipfeiffer I have replicated this behavior, but it's very inconsistent. I've followed these instructions carefully and I find when this happens it's fixable by simply clicking save changes again. Is this true for you too?

@Johnetordoff Yes, I can clear the error message by putting the order back to it's original state or by saving or canceling the changes.  Irregardless, the error is incorrect and should not be showing.


crictl rmi with force option

looking for the Docker equivalence docker rmi -f imageid.
Is there any?

Hey @AsherShoshan, is this the same request as in https://github.com/kubernetes-sigs/cri-tools/issues/399? Do you think we can close this on if favor of it?

No. It's not the same.
On Mon, Aug 19, 2019 at 4:19 PM Sascha Grunert<EMAIL_ADDRESS>wrote:

Hey @AsherShoshan https://github.com/AsherShoshan, is this the same
request as in #399
https://github.com/kubernetes-sigs/cri-tools/issues/399? Do you think
we can close this on if favor of it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/cri-tools/issues/504?email_source=notifications&email_token=ALCEMQPSHGHONCKMMSRLNU3QFKMXHA5CNFSM4ILH2YZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4S44SQ#issuecomment-522571338,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALCEMQKZGRMWZH56HF5ODITQFKMXHANCNFSM4ILH2YZQ
.

The Kubernetes CRI is not able to specify something like a force flag for image removal. For example CRI-O fails if the image is currently in use. The API states that the call should not return an error if the image has been already removed. @feiskyer, is there any expected behavior when an image is in use?

All,
The use case is:
If you a pod with container image  :latest, and the
imagePullPolicy is "ifnotpresent" - Then you have no way to refresh the
image with a newer image.
(except for rebooting the worker node  or try find a node which image is
not pulled there... )
When the container run-time engine is Docker, you can docker rmi -f
, and then the image will be refreshed.
So what are the options to refresh the image with cri-o
Asher
On Wed, Sep 4, 2019 at 2:34 PM Sascha Grunert<EMAIL_ADDRESS>wrote:

The Kubernetes CRI is not able to specify something like a force flag for
image removal. For example CRI-O fails if the image is currently in use.
The API states that the call should not return an error if the image has
been already removed. @feiskyer https://github.com/feiskyer, is there
any expected behavior when an image is in use?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/cri-tools/issues/504?email_source=notifications&email_token=ALCEMQNXAECZOHWT2HJLUT3QH6MNLA5CNFSM4ILH2YZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD53ISLA#issuecomment-527862060,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALCEMQJNRDFQZVPM7INAXZ3QH6MNLANCNFSM4ILH2YZQ
.

Alright, so one approach could be to force stop the containers before actually removing the image. The problem is now that we cannot guarantee that the kubelet does not re-schedule the workloads before we actually were able to remove the image. :-/

All, The use case is: If you a pod with container image :latest, and the imagePullPolicy is "ifnotpresent" - Then you have no way to refresh the image with a newer image.

You could pull the new image via crictl pull and restart the containers.

On Wed, Sep 4, 2019 at 4:37 PM Sascha Grunert<EMAIL_ADDRESS>wrote:

All, The use case is: If you a pod with container image :latest, and the
imagePullPolicy is "ifnotpresent" - Then you have no way to refresh the
image with a newer image.
You could pull the new image via crictl pull and restart the containers.

Do it on every node...

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/cri-tools/issues/504?email_source=notifications&email_token=ALCEMQNITPWCIOFG6O4IQW3QH622BA5CNFSM4ILH2YZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD53S4XA#issuecomment-527904348,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALCEMQNFYH6WHWD7Z5GPYTLQH622BANCNFSM4ILH2YZQ
.

/remove-lifecycle stale

any news here?

/reopen

@abdennour thanks for reaching out! Do you consider working on a solution around this?

I am thinking about -f option to be added @saschagrunert


reset in completion from stop() is a problem.

First of all thank your for this nice component. It's very useful.
I had a problem when starting immediately a new set of coaches after stoping the first stop() function.
I added a closure and now I call startOn() again inside only when I receive a callback from this new stop. Maybe you have a better solution.
/// Stop displaying the coach marks and perform some cleanup.
public func stop(onComplete: (() -> Void)? = nil) {
    UIView.animateWithDuration(self.overlayFadeAnimationDuration, animations: { () -> Void in
        self.overlayView.alpha = 0.0
        self.skipViewAsView?.alpha = 0.0
        self.currentCoachMarkView?.alpha = 0.0
    }, completion: {(finished: Bool) -> Void in
        self.skipView?.skipControl?.removeTarget(self, action: "skipCoachMarksTour:", forControlEvents: .TouchUpInside)
        self.reset()
        self.detachFromViewController()

        // Calling the delegate, maybe the user wants to do something?
        self.delegate?.didFinishShowingFromCoachMarksController(self)

        onComplete?()

    })
}

Thanks @guilhermeba!
I imagine launching the other set of coach marks from the delegate (didFinishShowingFromCoachMarksController) is not an option for you?

Closing due to inactivity.


How to use switch shadow?

I am trying to use switch shadow to turn off shadowRoot but I does not work no my side.
Is there a property to pass to the plugin in vite?

Sorry, the switch shadow feature has not been implemented yet, I have been too busy recently, but it is planned

It would be nice, some deps/packages/libs like TinyMCE doesn't works as expected when shadow root is present (no matter if it's opened).


[02.todo] checkbox doesn't work correctly

I have to refresh the page to check or uncheck the checkbox.

@xuzheng465 inside the ListItem.vue add this under <style scoped>
input {
  pointer-events: none;
}


Update all the text widgets having the same name with the same value

Fixes #13271.

/botio-linux preview

/botio integrationtest

/botio integrationtest

Thank you for improving this!


Is possible to set --installPath .

Hello,
I would like to define a custom install location for Visual Studio.
Using Install-VisualStudio from chocolatey-visualstudio.extension is it possible to set --installPath <dir>?
Thanks

Yes, it is. However, currently it can be done only by modifying the environment variable used by Chocolatey to pass package parameters:
$Env:chocolateyPackageParameters = '--installPath C:\VS'
Install-VisualStudio ...

I've wanted to implement a facility for passing such additional parameters directly to Install-VisualStudio (and Install-VisualStudioWorkload) for a long time, but never found the time to do it, unfortunately. I'd welcome a PR, though.

Available in extension 1.11.0 (currently in preview) as a new parameter of Install-VisualStudio and other public functions (-DefaultParameterValues <hashtable>).


Updates to Cargo team

Let's try to rerun this and see if CI is happier...

@nrc can you rebase your branch onto anp/master and push? CI should pass once you do.

Hm, it seems that the user database we have from github doesn't have one of the added usernames in it:
thread 'teams::test::team_members_exist' panicked at 'unable to verify team member from database.
if you're running this for tests, make sure you've pulled github users from prod: DieselError(NotFound)', libcore/result.rs:983:5

These usernames are case sensitive, so I think you may need to capitalize eh2406's username, maybe others?

OK, trying again...


Release v0.13.0

Or 0.12.1?

Does it make a real difference? Do node dev pin deps in such a way that patch version auto-upgrades but minor does not? This whole semver thing is a pain. I'm trying to implicitly follow comver https://gitlab.com/staltz/comver
If it is breaking, bump major. If it is non-breaking, bump minor. Leave patch always on zero. Very simple to follow and no surprises for users who follow semver.


rename repository?

I find it helpful when working in orgs to namespace the projects.  So when someone forks this repo, they won't just have a fork called boneskull/api.

guess this goes for "website" and "app" too maybe :D

renamed all three of them.


add 'zeroctl import template' command

We need a command to be able to import a template vdisk from the 0-hub to a local storage cluster.
Reason for that are:

For the restore vdisk to work properly, we need to also have tlog data for templates vdisk. Currently during the command copyvdisk from the hub to a local storage cluster when creating a new boot disk, all the data of the templates are sent to the tlog. So the tlog then has all the data he needs to rollback a vdisk. This process is extremely slow and costly.
Seamlessly importing a template vdisk of a windows machine won't work with 4k block used in boot vdisks. So we need to download the template to the locale storage cluster when installing an environment.

Proposed solution:
During the installation of an environment and after the storage cluster has been deployed. We will import all the templates we want to have available in this environment from the 0-hub. During this process, the tlog data will be created for each local template disk. Thanks to this, we can now create new boot vdisk fast again. The only thing needed then is to copy the metadata of the template vdisk and add a reference to the tlog data. Both actions shouldn't be long to execute.
This flow also solve the windows template problems since the import of template can takes some time, it's not a problem.
Command interface:
zertctl import template templateid dst_clusterid

The only thing needed then is to copy the metadata of the template vdisk and add a reference to the tlog data.

Because we use double linked list for tlog metadata, we also need to copy the metadata.
(double linked list has prev and next pointer).
We can only fork the metadata if it is backward list

For the 0-Disk suite a template does not really exist. Its just another vdisk that can be copied. Templates are an orchestrator concept.


conversion to arrow function breaks syntax when immediately .bind(...)ed

Environment information
$ biome rage
default/bin/biome rage
CLI:
  Version:                      1.4.1
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.19.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       unset

Workspace:
  Open Documents:               0

Configuration
n/a

Playground link
https://biomejs.dev/playground/?code=ZgB1AG4AYwB0AGkAbwBuACAAZgAoACkAewB9AAoAbABlAHQAIABhACAAPQAgADEAOwAKAGYAKAAnAHgAJwAsACAAZgB1AG4AYwB0AGkAbwBuACgAYQApACAAewB9AC4AYgBpAG4AZAAoAG4AdQBsAGwALAAgAGEAKQApADsA
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

I don't understand your issue or the requested feature.


How to represent DISTINCT

How should we best represent distinct?
I would probably vote for it as part of an aggregate transform:
from employees
aggregate first_name by:first_name

which is equivalent to:
select first_name
from employees
group by first_name

But is there something that an actual DISTINCT does that isn't covered by this approach?

I think this covers all cases (in SQL spec at least).
In practice, in some databases (I believe MySQL) GROUP BY will return ordered rows. Additionally, some databases can optimize DISTINCT queries better than GROUP BY, but in others it the other way around. That's why I think we will eventually have to support some way of expressing both of them.
Regarding the language: while in effect this is very similar to aggregation/grouping, the thought process is quite different. But I think its better that we have only one way of doing something, so we should not add new keywords for operation our language already supports.
Another example of a distinct query: getting list of families from list of users:
from users
aggregate by:[last_name, address]

or
from users
select [last_name, address]
aggregate by:*

Why do we have aggregate instead of group?
from users
group by:[last_name, address]

... would make more sense. We can think of arguments as:
from salaries
group by:employee_id aggregate:[sum salary]

... but omit named arg for aggregate.
PS: You could actually drop one first_name in aggregate in your query:
from employees
aggregate by:first_name

Agree with this!
On the one question:

Why do we have aggregate instead of group?

Mostly because group by doesn't contain the actual aggregation in SQL, and I wanted to ensure that wasn't confusing. (And I think that distinction is a great thing about PRQL; Hadley Wickham called it one of his greatest regrets about dplyr in the HN discussion).

I just tried adding docs for this, but I think recently this changed:
from employees
aggregate by:first_name [first_name]

Error:
   ╭─[:2:26]
   │
 2 │ aggregate by:first_name [first_name]
   ·                          ─────┬────
   ·                               ╰────── Ambiguous variable. Could be from either of {"employees", "$"}
───╯

I think this should work.
And without the positional arg (which I think with the existing definition is still required, because positional args are not optional:
from employees
aggregate by:first_name

Error: `aggregate` expected only one argument, but found none

WDYT @aljazerzen ?

I think that aggregate should include by parameter in the frame (as it does now), so there is no need to specify it again in the list.
So it would be like your second example:
from employees
aggregate by:first_name

Note that, when we introduce typing (even for functions), we should also constrain the positional of the aggregate to allow only "multi-variate functions" (many values to one), so specifying just a column would be invalid type.
Actions needed:

remove the requirement of aggregate to have the positional, default to empty list

remove the requirement of aggregate to have the positional, default to empty list

I'm fine trying this for a while. But it violates the rules for user functions (https://lang.prql.builders/functions.html), and it's more coherent if we don't widen the split between user & compiler functions...

and for case of #9 (for each customer return order with the highest total):
from purchases
group customer_id [
  sort desc:total
  take 1
]

Definitely. This is so nice.

With proposed changes from #300, I think that distinct should look like:
from users
group [last_name, address] (
  take 1
)

I think this could work. It's quite imperative, relative to declarative — i.e. if someone said "get me the unique last names & addresses", I could tell them "group all the values into last name & address, and then select one from each group". But it's less simple than their request.
It does fit with the proposed model nicely, though. And there are going to be lots of times where we have to trade off Breadth — more abstractions (like a distinct transformation) — and Simplicity — fewer abstractions (like having to describe the transformation here).

That is true, PRQL as a whole is getting more imperative than declarative.
declarative: "get me this and that from there groupped by this"
imperative: "from there, select this and that and group by this"
We also have only one way of doing this - in SQL you can use DISTINCT or do a GROUP BY and this makes queries harder to understand, because you have to look for the same operation at two different places. C++ has similar problem of "let's support everything", which adopting a codebase in C++ a hard task, because things like initialization is done in a different way than what you are used to. But both are correct!
So I think it is beneficial if we strive to have only one way of expressing any operation.
Even though PRQL does not read like a sentence, I do believe it is already more readable than SQL.

Closed by #503  🙏


Loading replay files fails if the working directory is not the folder root

It seems (without yet digging into the code) that WireMock loads the replay files exactly from src/test/resource/... directory which fails to lookup if the working directory for the tests is different.
In my case I want the working directory to be under target folder so all reports and other assets getting created will be cleaned. This did lead to a situation that I could run the tests without any issues from IDE but it failed with 404s if run trough surefire.
Quick tryout (was a blind guess from experience) shows it is working if I put the mappings and the __files directory under the same structure below target, I just created a folder src/test/resources under the target folder and put in the 2 directories, afterwards running the tests without a clean works fine.
Suggestion (that's what I do in other framework code) is to always load it from the classpath (mapping and __files directory) as the files and folders under resources get copied over to the compilation output if run trough maven or InteliJ Idea and I guess eclipse does the same.

Workaround using antrun build plugin, dirty but does the job for now and fixes the CI build for me ;-):

maven-antrun-plugin
1.8

process-resources

run

Short crawl trough the WireMock code...
com.github.tomakehurst.wiremock.core.WireMockConfiguration on line 51: new SingleRootFileSource("src/test/resources")
I know it can be changed programmatically but it would be good if the default values just work in most cases.
Have to first checkout, change, test and then do a PR but if setting SingleRooFileSource as current working directory it should pick it up.


ls with bash-it configuration does not recognize .mov as media file in macOS

Below is the screenshot on macOS. Notice that the color for trim_3.mov and zz.png are not specially colorized.

However,
those files are specially colorized (for easy recognition) in Linux.

Good question. This seems to be related to the dircolors settings. Please see here for some details:

https://askubuntu.com/questions/17299/what-do-the-different-colors-mean-in-ls
https://unix.stackexchange.com/questions/91937/mac-os-x-dircolors-not-found

@dclong  Are you seeing different behavior when bash-it is and is-not installed?  Just wondering if you confirmed that what you are seeing is related to bash-it and not just standard Mac behavior?
In general, the OS-X built-in ls command (/bin/ls) only comes with basic "LSCOLORS" support (man ls), and does not come with dircolors  / LS_COLORS support.
I found the easiest path to full color support was through installing the coreutils package via homebrew:
$ brew info coreutils

coreutils: stable 8.32 (bottled), HEAD
GNU File, Shell, and Text utilities
https://www.gnu.org/software/coreutils

Conflicts with:
  aardvark_shell_utils (because both install `realpath` binaries)
  b2sum (because both install `b2sum` binaries)
  ganglia (because both install `gstat` binaries)
  gegl (because both install `gcut` binaries)
  idutils (because both install `gid` and `gid.1`)
  md5sha1sum (because both install `md5sum` and `sha1sum` binaries)
  truncate (because both install `truncate` binaries)
...

==> Caveats
Commands also provided by macOS have been installed with the prefix "g".
If you need to use these commands with their normal names, you
can add a "gnubin" directory to your PATH from your bashrc like:
  PATH="/usr/local/opt/coreutils/libexec/gnubin:$PATH"

Among other things, this will install gls and gdircolors
You can use these directly as needed or create aliases that reference them, ie:
.bash_profile
eval $(gdircolors)
alias ls="gls --color=auto"

If you want the coreutils tools to override the built-in mac tools, you can add:
.bash_profile
PATH="${BREW_PREFIX)/opt/coreutils/libexec/gnubin:$PATH"
eval $(dircolors)
alias ls="ls --color=auto"

Hope that helps
-DF
PS: Please do report if you are seeing any further errors specific to Bash-It.  However, please don't ask (me) for further support regarding coreutils, dircolors etc - This was just to (hopefully) get you started - The Internet is your friend - Good Luck !

@davidpfarrell Thank you very much for the detailed explanation! I observe the similar patter (media files are not colorized by ls in macOS while they are colorized by ls in Linux) when bash_it is not installed. I think you are right that it is due macOS standard behavior.


The app returns just 30 repositories

This website will return only 30 repos when you search for a profiles
how to fix it:
-make prev and next buttons
-there is page query for github api, change the page number using the previous buttons
-you can find the file in profile folder inside components folder which also inside src folder

is any work on it?

I fixed it and it's work fine right now


Anonymize DICOM files with javascript

I'm triying to anonymize dcm (dicom) files before uploading it to the server.
I want to do it on the client side using javascript. But I can't find more that dicom viewers.
I searched about the tags of dicom and I have found a lot of tools for remove metadata tags using python, java and ruby, but I don't know how to portrait it to javascript.
I have even decided what tags I would remove, but I'm not sure about how to do it.
Any ideas about?
Thanks for your time

To anonymize the DICOM itself, you'll have to manipulate the actual ArrayBuffer holding the bytes of the DICOM file (the dataSet from dicomParser has all of the array offsets for each tag).  That's the simplified version--the full details are more complicated and you'll have to look at the DICOM standard to figure out (see section 7 in part 5 of the DICOM standard for details on how tags and values are stored in the file).

Also see #31

We plan to support this with dcmjs (https://github.com/pieper/dcmjs) but we have no plans to do this with dicomParser.


Make data migration demo "cycle" the exported data back into a new container running the same container code

Closing this issue as it's now tracked in AB#302


Bump version number (1.1.0)

Bump version number of Xcode project and podspec

Need to update the README too.

Do you mean to include documentation for the new method added here? https://github.com/3squared/SQKDataKit/pull/74

That too :-)

What changes to the README need to be made then?

Your pod version number & new method docs. The version number will automatically update once you push your latest podspec to CocoaPods' trunk.


Suggestion: typeof of generic type

This issue was previously reported as bug at codeplex, now trying to submit as suggestion.

Below, the Collection.model field is supposed to accept type of TModel rather than instance of TModel:
class Model { }
class Collection<TModel extends Model> {
    model: typeof TModel; //Error: Could not find symbold 'TModel'.
    models: TModel[];
}

class MyModel extends Model { }
class MyCollection extends Collection<MyModel> {
    // This is what we want
    model: typeof MyModel = MyModel;

    // This is what we don't want
    //model: MyModel = new MyModel;
}

var coll = new MyCollection();
var modelType = coll.model;
var newModel = new modelType();

Use of typeof keyword seems to be appropriate here, but compiler doesn't understand typeof of generic type. If we said model: typeof Model; it would compile but that is not exactly what we want.
Some of the workarounds we found are the followings:
class Model { }
class Collection<TModel extends Model> {
        model: { new(): TModel; };
        models: TModel[];
}

class MyModel extends Model { }
class MyCollection extends Collection<MyModel> { }

and
class Model { }
class Collection<TModelConstructor extends typeof Model, TModel extends Model> {
        model: TModelConstructor;
        models: TModel[];
}

class MyModel extends Model { }
class MyCollection extends Collection<typeof MyModel, MyModel> { }

Feature suggestion is to allow typeof generic type.

The first workaround actually causes problems with statics:
class Model {
  static doStuff() { }
}
class Collection<TModel extends Model> {
  // With this workaround, you also have to hack in doStuff() here which causes a lot of duplication.
  model: { new(): TModel; };
  models: TModel[];

  doStuffToModel() {
    // This is okay because we hacked in "new(): TModel"
    var model = new this.model();

    // This is not okay because we didn't hack in "doStuff(): void"
    this.model.doStuff();
  }
}

The second workaround is a lot better but also problematic:
class Model { }
class Collection<TModelConstructor extends typeof Model, TModel extends Model> {
  model: TModelConstructor;
  models: TModel[];

  static createCoolInstance<TModelConstructor extends typeof Model, TModel extends Model>(ctor: TModelConstructor): TModel {

    // "Type 'Model' is not assignable to type 'TModel'." so you have to "<TModel>new ctor();" which seems pretty unnecessary
    return new ctor();

  }
}

Let me explain what I think about this with some pseudo code:
class MyClass {
  static foo() {};
  bar() {};
}

// That does something like:
type MyClassInstanceType = { bar: () => void };

type MyClassConstructorType = { new(): MyClassInstanceType; foo(): void };

var MyClassValue = function() {};
MyClassValue.prototype.bar = function () {};
MyClassValue.foo = function () {};

// So if typeof was a function, it would be something like:
function typeof(classValue: Value): Type {

  return ClassValueToConstructorTypeMap[classValue];

}

My question is, why does typeof take a value? Here is an example:
var inst: MyClass = new MyClass();
var ctor: typeof MyClass = MyClass;

The first "MyClass" refers to MyClassInstanceType and the second one refers to MyClassValue.
On the second line, couldn't the first "MyClass" refer to MyClassInstanceType again and get MyClassConstructorType from that?
If changing typeof to or overloading it with "InstanceType => ConstructorType" is breaking, I think we could easily have another operator for it. (constructorof? staticof?)

And some examples would be:
autoConstructor<T>(ctor: constructorof T): T {

  return new ctor();

}

var inst;

/* Works */
class MyClass { }

inst = autoConstructor(MyClass);

/* Should these work? */
inst = autoConstructor<number>(Number);
inst = autoConstructor(Number);
inst = autoConstructor<string>(String);
inst = autoConstructor(String);
inst = autoConstructor(Date);

/* Maybe: */

// Ok
autoConstructor<T extends MyClass>(ctor: constructorof T)......

// Error: Types given to 'constructorof' must extend a class type
autoConstructor<T>(ctor: constructorof T)......

Note that new Number() does not produce a number (it's not primitive).
You can already write this:
interface constructorof<T> {
	new (): T;
}

function autoConstructor<T>(ctor: constructorof<T>): T {
  return new ctor();
}

var inst;

/* Works */
class MyClass { }

let c = autoConstructor(MyClass); // c: MyClass

/* Should these work? */
inst = autoConstructor<Number>(Number);
inst = autoConstructor(Number);
inst = autoConstructor<String>(String);
inst = autoConstructor(String);
inst = autoConstructor(Date);

That doesn't provide the actual type for the constructor:
class MyClass {
  static foo() {};
}

interface constructorof<T> {
    new (): T;
}

function autoConstructor<T extends MyClass>(ctor: constructorof<T>): T {

  // No foo here
  ctor.foo();

  return new ctor();
}

What is the reason for having typeof? Wouldn't constructorof cover all use cases of typeof and more? (And also without the created confusion with JavaScript's own typeof.)

There can be more than one constructor function for any given type.
interface SomeObj { ... }
declare var ctor1: {
  new(): SomeObj;
  foo;
}
declare var ctor2: {
  new(): SomeObj;
  bar;
}

function magic<T extends SomeObj>(ctor: constructorof<T>) {
 // can I use ctor.foo here? ctor.bar?
}

typeof exists so that, given a value of some type that is otherwise anonymous, you refer to that anonymous type without having to rewrite it yourself.

Can there be more than one constructor function for any given class type? If not then a constructorof keyword that only works with class types could solve the issue.
class MyClass {
  static foo() {};
}

/*
  MyClass was declared with the `class` keyword.
  We can be sure that it has one constructor.
  We allow constructorof to be used with it.
*/
var ctor: constructorof MyClass = MyClass;

Can there be more than one constructor function for any given class type?

Yes.
class Foo { }
declare var factory: {
  new(): Foo;
}

Yes, but typeof doesn't care about that:
class Foo {
  static bar() {};
}
declare var factory: {
  new(): Foo;
  foo();
}

var ctor: typeof Foo = Foo;

ctor.bar; // Here
ctor.foo; // Not here

The constructorof implementation can do the same.

I'm still not sure what you're proposing that is meaningfully different from typeof or new() => T.

Enum don't have constructors so new() => T does not work

Enum don't have constructors so new() => T does not work

And what problem is this presenting you with?  Of course enum's don't have constructors.  This was (originally) an issue about how to reference the constructor of a generic, which really turned into how to describe a generic that extends a constructor.

I was making a method that took an enum and one of its values and typeof T said T is not found.
function x<T>(_enum: typeof T, value: T){}

This is a different problem... While the the intellisense lists an enumeration type as a typeof there is no way to narrow a generic to be a value of any enum to be able to try to extract the type it comes from. This is covered in #3440 as "accepting PRs".  Once that is addressed, what you are talking about should work.

I have the same problem, while it is understandable to have to pass the constructor as an argument to reference it later (although ironic since we already have the type parameter), the method(constructor: new() => T) method is unaware of static properties attached to the reference constructor. To get around the syntax error I had to use method(constructor: new() => T : any). After which the compiler allows constructor.staticFoo.

I found that a quite weird syntax may replace "typeof T" syntax.
/** Generic class type. */
type Constructor<T> = { new (...args: any[]): T } | ((...args: any[]) => T) | Function;

Possible usage:
/** Generic class type. */
type Constructor<T> = { new (...args: any[]): T } | ((...args: any[]) => T) | Function;

/** Dummy dependency injector */
export class Injector {

  public resolve<T>(x: Constructor<T>): T {
      // Injector implementation, here a dummy one.
      return undefined as any as T;
  }

}

/** A dummy base abstract class to resolve. */
export abstract class ClassToResolve {

  public n: number;

  protected abstract constructor(a: string, b: string) {
  }
}

let injector = new Injector();

const resolved = injector.resolve(ClassToResolve);

// Compiler says that the variable resolved is of type ClassToResolve, correct!
resolved.n = 1000;

// Compiler will fail here, xxx is not a member of ClassToResolve. Correct!
resolved.xxx = "xxx";

Well, it seems to "abuse" the TypeScript interpreter but it works, and makes sense.
Someone have an opinion over this and especially someone maybe knows if this would not work in the next version of TS?

@SalvatorePreviti that's basically the same as the recommended solution in the FAQ, so I'd say it's well-supported :wink:

I'm sorry to piggy back onto this, but I think my question is very much related to this question, but I couldn't quite figure out if it was so. http://stackoverflow.com/questions/43000982/how-to-create-a-factory-that-returns-anonymous-classes-that-implement-a-generic
I'm trying to do the following to remove boiler plate code of creating concrete classes for a payload type.
export interface TypedAction<T> extends Action {
    type: string;
    payload: T;
}
export function createTypedActionConstructor<T>(type: string): TypedAction<T> {
    return class TypedActionImpl implements TypedAction<T> {
        readonly type = type;
        constructor(public payload: T) {}
    }
}

But I get an error because what I'm returning is the class that implements TypedAction, not the instance. The error says:

TS2322 Type 'typeof TypedActionImpl' is not assignable to type 'TypedAction'. Property 'type' is missing.

Is it impossible to return a dynamic implementation of a generic class from TypeScript?

@juanmendes your return type should be new(payload: T) => TypedAction<T>, not TypedAction<T>. You've declared that you return the instance type but you've provided a constructor type

Thanks Ryan, it mostly works, the problem there is that the return of createTypedActionConstructor is not a true type, that is, I can't cast to it.

I don't understand why the typeof operator should not be applied on type arguments. The language specification states in section 4.18.6:
The 'typeof' operator takes an operand of any type and produces a value of the String primitive type. In
positions where a type is expected, 'typeof' can also be used in a type query (section 3.8.10) to produce
the type of an expression.
So why is something like the followin not allowed?
getConstructor<T>( instance: T )
{
    return instance.constructor as typeof T;
}

typeof X produces the type of the value X. There's no value named T, so the "typeof the value T" question makes no sense. It's like asking how much blue weighs.

@RyanCavanaugh: But if so, why do the specs state that typeof can be used in a type query?
class MyClass {}
let x: typeof MyClass; // MyClass is a type here

@markusmauch
class MyClass {}
let x: typeof MyClass; // MyClass is a value here

x is a variable whose type is the type of the value named MyClass. A class definition introduces a name in the type space that refers to the type of instances of that class, and a name in the value space that refers to the class value (the thing that gets newed).

@aluanhaddad
Well okay, MyClass is a value then. But how do I get the type of the constructor function of the type MyClass?

@markusmauch by writing typeof MyClass in type position. Just as you had done.

Is there a reason typeof MyClass<SpecificType> is not supported when I have it defined as class MyClass<T> { ... }?
I'd like to get the type of the class with a specific type, but without having to create a class that inherits from it:
const MySpecificClass: typeof MyClass<SpecificType> = MyClass;

@leoasis the type argument belongs to the instance side of the class. typeof operator obtains the type of the static side of the class.

Yeah, I know, that's what I wanted to show in the example. In my particular use case, I'm using React, and I have an InfiniteScrollList component that is parametrized on the type of the item it accepts. We did this to force the same type you provide to be the same type you would expect in any callback prop, instead of it being any and making the user specify the type:
The problem there is that when I define the component with a generic type, I can no longer use it in JSX directly, since I cannot write
return (
  <InfiniteScrollList<Item> {...props} />
);

So I tried doing something like this:
const ItemInfiniteScrollList: typeof InfiniteScrollList<Item> = InfiniteScrollList;

but that didn't work.
Couldn't find another way to make that work without creating an empty class that inherits from the parametrized one. That works, but I would like to avoid creating a class (which will be created at runtime) just to enforce type safety.

The workaround mentioned by @SalvatorePreviti and the FAQ only works on classes that don't have any static methods, as the return type is only a constructor.
I can't seem to come up with a decent workaround that would even allow for an identity function that accepts and returns a constructor.
abstract class Animal<T> {
    static identity<T>(T: typeof Animal<T>) : typeof T; // this doesn't work
}

class Dog extends Animal<Dog> {
}

Animal.identity(Dog) // => Dog

A more concrete (and realistic) use-case would be a static method that creates a new copy of the class/constructor (possibly with a different set of static properties, or extra static methods).  This is a pattern often seen in ORMs, notably Sequelize's Model.scope() method.
If anybody has ideas about similar ways to achieve the same result whilst working within the boundaries of TypeScript's existing type system, let's get them documented!

class Animal<T> {
    static identity<T extends new (...args: any[]) => Animal<any>>(C: T): T {
        return  C;
    }
}

class Dog extends Animal<Dog> {
}

Animal.identity(Dog); // => typeof Dog

Or even
```t
class Animal<T> {
    static identity<T extends new (...args: any[]) => Animal<any>>(this: T) {
        return this;
    }
}

class Dog extends Animal<Dog> {}

Dog.identity(); // => typeof Dog

I'm having the same problem, and basically ended up chain casting to any and typeof Model:
// This class is in a 3rd party library:
abstract class Model<T> {
  static count(): number;
}

interface Options<T extends Model<T>> {
  target: new () => T;
}

// `options` type is `Options<T>`
const model = options.target as any as typeof Model;
return model.count();


How to run the project

I've completed the tutorial. But I don't know how the hell run it. And I've been looking in the docs and I found nothing.

hey @mishelashala,
Use typescript to build the project.
If it help I joined my package.json in exemple
{
  "name": "nest.js-tutorial",
  "version": "1.0.0",
  "description": "An implmentation tutorial about NestJS",
  "main": "main.js",
  "scripts": {
    "build": "tsc",
    "start": "node dist/main.js"
  },
  "author": "ThomRick",
  "license": "ISC",
  "dependencies": {
    "body-parser": "^1.17.1",
    "nest.js": "^1.0.0-rc8"
  },
  "devDependencies": {
    "@types/es6-promise": "0.0.32",
    "@types/node": "^7.0.11",
    "typescript": "^2.2.1"
  }
}

and tsconfig.json
{
  "compilerOptions": {
    "module": "commonjs",
    "target": "es6",
    "sourceMap": true,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "outDir": "dist",
    "typeRoots": [
      "node_modules/@types"
    ]
  },
  "include": [
    "src/**/*"
  ],
  "exclude": [
    "node_modules"
  ]
}

I have the following project structure:
src
 |
 --- app
 |       |
 |       --- controllers
 |       |           |
 |       |           --- user.controller.ts
 |       |
 |       --- services
 |       |           |
 |       |           --- user.service.ts
 |       |
 |       --- app.module.ts
 |
 --- main.ts

So I build the project with the command
npm run build

and start it with the command
npm start

https://github.com/cdiaz/nestjs-demo


Canvas control buttons

Is it intentional that the hover behavior for the "See results of a completed game" button is that the button color goes clear or matches the light blue background. Seems a bit weird.

Seems to be an issue with most buttons.

Otherwise it looks really nice. Let me know if you want to fix that. If not, I can go ahead and merge this as is since everything is working.

omfg. I tested every page but the home page. Ugh. One moment please.
On Sun, Mar 21, 2021 at 4:58 PM Melinda Morang @.***>
wrote:

Is it intentional that the hover behavior for the "See results of a
completed game" button is that the button color goes clear or matches the
light blue background. Seems a bit weird.
[image: image]
https://user-images.githubusercontent.com/16789766/111925544-89e95680-8a66-11eb-986d-0ba3b0dd80ff.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/melindamorang/blowyourfaceoff/pull/103#issuecomment-803684394,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARQDLJ4M333GCA5EYII6XKTTE2BZ3ANCNFSM4ZSCVCNQ
.

Okay, try it again.

Looks good.

Woot!
On Sun, Mar 21, 2021 at 5:12 PM Melinda Morang @.***>
wrote:

Merged #103 https://github.com/melindamorang/blowyourfaceoff/pull/103
into main.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/melindamorang/blowyourfaceoff/pull/103#event-4487375711,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARQDLJ2YJRBZBLFOQQBKHGLTE2DNPANCNFSM4ZSCVCNQ
.

Changes are live


Getting following lua error at startup (version 0.5)

Message: ...erface\AddOns\SoulshapeJournal\Localization\frFR.lua:29: attempt to index local 'L' (a nil value)
Time: Thu Nov 25 23:54:17 2021
Count: 1
Stack: ...erface\AddOns\SoulshapeJournal\Localization\frFR.lua:29: attempt to index local 'L' (a nil value)
[string "@Interface\AddOns\SoulshapeJournal\Localization\frFR.lua"]:29: in main chunk
Locals: ADDON = "SoulshapeJournal"
_ =  {
}
L = nil
(*temporary) =  {
apps =  {
}
GetLocale =  defined @Interface\AddOns\AddOnSkins\Libs\Ace3\AceLocale-3.0\AceLocale-3.0.lua:132
NewLocale =  defined @Interface\AddOns\AddOnSkins\Libs\Ace3\AceLocale-3.0\AceLocale-3.0.lua:93
appnames =  {
}
}
(*temporary) = "SoulshapeJournal"
(*temporary) = "frFR"
(*temporary) = false
(*temporary) = "attempt to index local 'L' (a nil value)"

Hello and thanks for your report.
This bug should be fixed in release 0.6. Please let me know.


[hsmtool] add commands to for ECDSA code-signing

Implement the ECDSA-equivalent commands for the same RSA operations currently supported.

Fixed by https://github.com/lowRISC/opentitan/pull/21594.


Improve p2p data fetching. Fetch rest pages in parallel

Improvement to load rest pages in parallel instead of sequentially.

Nice improvement!
Have you read about the Binance API limits? Seems to be listed https://www.binance.com/en/support/faq/360004492232 if I understand ok.
I thin'k we won't want the clients being ip banned in case of a lot of pages of info.
What do you think about doing the fetch but in batches of N pages being fetched in paralell?

I close the PR for the reasons mentioned above by @Lzok.


Standardizing the preprocessing pipeline for large datasets

The pipeline we use in most of the examples is not well adapted to large datasets, as the operations are applied sequentially to all the recordings at once (sleep staging: https://braindecode.org/auto_examples/plot_sleep_staging.html, decoding on BCIC dataset: https://braindecode.org/auto_examples/plot_bcic_iv_2a_moabb_trial.html, MOABB: https://braindecode.org/auto_examples/plot_dataset_example.html, etc.).
This means for instance that all the raw recordings must be loaded at once into memory. This is not practical on larger datasets such as the TUH EEG dataset, which is why @gemeinl made an example for large datasets specifically: https://braindecode.org/auto_examples/tuh_eeg_corpus.html
I'd like to standardize @gemeinl's approach so that we can recommend a "braindecode way" of handling large datasets and, if it's simple enough, maybe even apply it to all the examples so there's a unique way of doing things. Also, this is a good opportunity to think about how to best parallelize the preprocessing/windowing and serialize intermediate results (which I know has been a pain point for people in our lab).
I would suggest providing a helper function (called something like prepare_dataset) that automatically handles the parallelization and serialization. It would require a user-defined callable that loads and preprocesses/windows a single recording. For instance:
def prepare_dataset(fn, ids, save_dir=None, n_jobs=1):
    """
    Parameters
    ----------
    fn : callable
        User-provided function that loads, preprocess, windows and preprocess a
	single recording.
    ids : dict
	Dictionary specifying which recordings to load from the dataset. Keys
	specify the argument name to use in the dataset class and values
	specify the actual values to load. E.g., to load subjects 0 and 1,
	sessions 1 and 2 from the SleepPhysionet dataset:

		ids = {'subject_ids': [0, 1], 'recording_ids': [1, 2]}

    save_dir : str | None
	If provided as string, processed recordings will be saved under that
	directory.
    return_dataset : bool
	If True, return the concatenated dataset.
    n_jobs : int
	Number of jobs.

    Returns
    -------
    BaseConcatDataset OR fnames
    """
    for each combination of ids:  # use joblib if n_jobs > 1
        ds = fn(id)
	serialize ds  # could be optional

    if return_dataset:
	reload files and concatenate in BaseConcatDataset
	return BaseConcatDataset
    else:
	return file names of serialized recordings

def load_and_preprocess_one_record(subject_id)
    """User-defined function.

    Similar to the loop at the end of https://braindecode.org/auto_examples/tuh_eeg_corpus.html
    """
    ds = MyDataset(subject_id)
    my_preproc = [Preprocessor(...)]
    preproc(ds, my_preproc)
    win_ds = create_windows(ds)
    my_window_preproc = [Preprocessor(...)]
    preproc(win_ds, my_window_preproc)
    return win_ds

concat_ds = prepare_dataset(load_and_preprocess_one_record, {'subject_id': [0, 1, 2]},
                            save_dir='my_dir', n_jobs=87)

What do you think? @gemeinl @robintibor @sliwy @agramfort

I think @gemeinl  will have more to say about the specifics, but in general providing clean helper functions with a clear interface is a great idea I think. Then might be fine to keep rest of code as is or maybe only need small changes and still provide nice easy-to-use functionality. Alternatively, would it also make sense to create the whole dataset with preload_data=False first? Then it might be an option to have this whole logic as part of the current preprocess function, and you can just turn it on via an argument? Just a thought, not sure if that would be better in the end.

To keep track of discussions:

we agreed to abandon the idea of adding a function similar to prepare_dataset above
instead we will add parallelization and serialization to preprocess by adding arguments n_jobs, out_path (and maybe batch_size)

Hi @hubertjb,
Can we close this issues?


network: Added gRPC method SubscribeToBlocks

Designed the subscription API for the block service and its
network-core counterpart.

Codecov Report

Merging #465 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   45.33%   45.29%   -0.04%
==========================================
  Files         130      130
  Lines       13067    13067
==========================================
- Hits         5924     5919       -5
- Misses       7143     7148       +5

Impacted Files
Coverage Δ

network-core/src/server/block.rs
0% <ø> (ø)
:arrow_up:

chain-impl-mockchain/src/transaction.rs
89.65% <0%> (-3.45%)
:arrow_down:

chain-core/src/property.rs
93.42% <0%> (-1.32%)
:arrow_down:

...tocol-tokio/src/network_transport/response_code.rs
66.66% <0%> (+6.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e41a3...0870f67. Read the comment docs.


Flatbuffers dependency long-term?

Digging into the source, it made me wonder if the plan is to keep flatbuffers as a dependency long-term, or to define a kind of "standard metadata layout", similar to what's already been done for array layouts. It doesn't seem like there's anything crazy in the metadata section/storage, so just wondering if I'm missing some other kind of benefit from flatbuffers or if it's been viewed as a more short-term solution anyway.

From my perspective, I don't see what would stand to be gained from bespoke metadata serialization (since the memory layout of the metadata does not have a meaningful impact on performance or interoperability), and making changes to the metadata would become much more complex. Flatbuffers also helps with schema evolution (i.e. new fields can be added without breaking existing files), though we aren't yet at a point where we're guaranteeing that old files will be readable in the future.

Thanks for the response. I see the benefits of using flatbuffers as a "black box" for storing metadata (though there's obviously still ways to spec out a memory layout as a dictionary to say "continue reading key-value pairs in this region" that would handle new future metadata fields).
I was mainly interested in hearing if you were planning on this dependency long-term or not.


Failed to build the code from head.

The build page is also failing too.
https://travis-ci.org/Alamofire/Alamofire

Hi @yniesp, everything is building properly. Here's the output from the Alamofire 3.2.0 release:
cnoon:~/Desktop/Tester$ carthage update
*** Fetching Alamofire
*** Checking out Alamofire at "3.2.0"
*** xcodebuild output can be found in /var/folders/s7/qpm0b2pn3d56rjlpl7g3_4fh0000gn/T/carthage-xcodebuild.NXtvLt.log
*** Building scheme "Alamofire OSX" in Alamofire.xcworkspace
*** Building scheme "Alamofire tvOS" in Alamofire.xcworkspace
*** Building scheme "Alamofire iOS" in Alamofire.xcworkspace
*** Building scheme "Alamofire watchOS" in Alamofire.xcworkspace
cnoon:~/Desktop/Tester$

And here's the output from HEAD on master:
cnoon:~/Desktop/Tester$ carthage update
*** Fetching Alamofire
*** Checking out Alamofire at "59ef4f5da3fdba44649026603c6512fd6c5dabd0"
*** xcodebuild output can be found in /var/folders/s7/qpm0b2pn3d56rjlpl7g3_4fh0000gn/T/carthage-xcodebuild.4pVzap.log
*** Building scheme "Alamofire OSX" in Alamofire.xcworkspace
*** Building scheme "Alamofire tvOS" in Alamofire.xcworkspace
*** Building scheme "Alamofire watchOS" in Alamofire.xcworkspace
*** Building scheme "Alamofire iOS" in Alamofire.xcworkspace
cnoon:~/Desktop/Tester$

These were both built with xcodebuild 7.2.1 and carthage 0.12.0. As for the Travis builds, something is going on with Travis. It's extremely unstable right now, so I wouldn't rely on Travis to tell you anything useful.
Cheers. 🍻


Metadata and Project database connection

Description
Feature*: Connect superset to local metadata and project databases
Superset requires backed up database to store metadata relating to the dashboard. It also requires an SQL (Preferably postgresql) database to load/read data from. Data can be loaded into the database via the front end (in .csv format). This has successfully been implemented as a PyPi app but not using docker.
This ticket will be used to record resources and methods to achieve this.
Tasks

[ ] Connect metadata database
[ ] Connect projects database
[ ] FInalise implementaion

https://github.com/apache/superset/issues/28617


brass tunnel can get unlimited items

Describe the Bug
The first item put into the brass tunnel can be obtained infinitely
Reproduction Steps

Set up any brass tunnel group
Use hopper or brass funnel to fill a item
Put items at will

Expected Result
The first time you put an item into the brass tunnel, you will get this item if you put subsequent items into it
This also causes the chute to not be able to put objects inside
Screenshots and Videos
https://www.bilibili.com/video/BV1uS4y1q7GN/?vd_source=305b708bb56696a8ae510ab0fbce9e13
Crash Report or Log
No response
Operating System
Windows 10 & OpenSuse Linux Server
Mod Version
0.4.1
Minecraft Version
1.18.2
Other Mods
No response
Additional Context
No response

The link is missing. Try this one
https://www.bilibili.com/video/BV1rF411F7wC?spm_id_from=333.999.0.0

Images of how-to-reproduce:

only combined brass tunnel have this bug.


Remove transaction set acquire logic from consensus object

This creates a new InboundTransactions object that handles transaction sets, removing this responsibility from the consensus object. The main benefit is that many inbound transaction operations no longer require the master lock.
Improve logic to decide which peers to query, when to add more peers, and when to re-query existing peers.
Reviewers needed.

Here is a commit that fixes up the non-unity build: https://github.com/HowardHinnant/rippled/commit/49851e945656487d506cfef11f02b51893603ed8

:+1: This P/R builds with no warnings on OS X using scons debug which builds both unity and non-unity builds.  The nounity debug build passes unittest, npm, syncs and stops.

Still :+1: This builds and passes tests for me.
Assuming PR 939 goes in prior to this, this will conflict with 939.  The syntax for resolving the conflict is:
#include <beast/utility/make_lock.h>
...
auto lock = beast::make_lock(getApp().getMasterMutex());

@miguelportilla: if you're ok with this, please thumbs up and tag as Passed.

:+1:

Rebased. Reviewers might want to give it one more check to make sure it's still good. There were some minor merge conflicts involving Howard's master lock change.


Support ggmlv3

I download llama-7b.ggmlv3.q4_0.bin from https://huggingface.co/TheBloke/LLaMa-7B-GGML/tree/main, LlamaChat says not a valid model. It seems not support ggmlv3 format.

LlamaChat v2 is coming with expanded support for ggml and other models. development has stalled for a bit but hopefully I'll be able to get back to it soon 👌🏼

LlamaChat v2 is coming with expanded support for ggml and other models. development has stalled for a bit but hopefully I'll be able to get back to it soon 👌🏼

@alexrozanski Looking forward to new version.
BTW, as a kind reminder, llama.cpp will have breaking changes on its model format (ggjt-v3 to gguf).
Maybe it is good to keep an eye on this: https://github.com/ggerganov/llama.cpp/pull/2398


update pyright logic

mgmt package getting run by pyright -- bug fix
wasnt avoiding mgmt samples

/azp run python - search - tests-weekly

/azp run python - search - tests-weekly


Validate PQE page.

What's included?
Missing validation on the PQE page was allowing the form to be submitted empty.
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Attempt to submit a blank PQE form.
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
🟠 Medium risk - this does change code that is shared with other areas
🔴 High risk - this includes a lot of changes to shared code
Additional context
Include screen grabs, notes etc.

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

👍


Unmet peer deps prevent building an SBOM

Hi -- loving the Typescript rewrite here. I'm having some pretty good results running this on my monorepo, and gathering all the package data together.
However, the build is failing due to an unmet peer dependency.  npm ls causes this failure per https://github.com/npm/npm/issues/17624 and https://github.com/CycloneDX/cyclonedx-node-npm/blob/1.0-dev/src/builders.ts#L141-L150.
I'm not worried about this unmet peer dependency -- I know it's just a silly library that hasn't updated its peer deps to say it supports React 18. But it causes me to be unable to generate an SBOM here. If I remove the error throwing from your package, I believe I still get an accurate SBOM, since it uses the deduped dependencies.
Is this desired behavior? Or could this be a warn in the build instead of an error that prevents building an SBOM?

I am thinking of a clinseitch to supress/ignore errors from  npm ls
Therefore it might help to have your use case as a reproducible example somehow.
Could you share your npm lock file or point me to a setup where this behaviour can be seen?

Hey,
The repo i've been using is private but I created a minimal example at https://github.com/alexthemark/example-unmet-peer-dep. If you clone that, run npm install, and run cyclonedx-npm --output-file bom.json, you should see the error.
But then I realized it was printing the scary error message, but I still received an SBOM -- so the error was swallowed somewhere and I am able to create a BOM. It would still be nice to not have a scary error level message for something that seems warn-able, but it's definitely not as urgent as I thought.

Adding to the above, when I run npm run build:bom I receive the following fatal error:
npm run build:bom

><EMAIL_ADDRESS>build:bom
> cyclonedx-npm --output-file=bom.json

DEBUG | options: {"packageLockOnly":false,"omit":[],"flattenComponents":false,"specVersion":"1.4","outputFormat":"JSON","outputFile":"bom.json","mcType":"application"}
DEBUG | packageFile: /Users/code/example-amplify-app/package.json
DEBUG | projectDir: /Users/code/example-amplify-app
DEBUG | lockFile: /Users/code/example-amplify-app/package-lock.json
INFO  | gather dependency tree ...
DEBUG | npm-ls: run /opt/homebrew/lib/node_modules/npm/bin/npm-cli.js with ["ls","--json","--all","--long"] in /Users/code/example-amplify-app
WARN  | npm-ls: STDERR
  npm ERR! code ELSPROBLEMS
  npm ERR! invalid<EMAIL_ADDRESS>/Users/code/example-amplify-app/node_modules/react
  {
    "error": {
      "code": "ELSPROBLEMS",
      "summary": "invalid<EMAIL_ADDRESS>/Users/code/example-amplify-app/node_modules/react",
      "detail": ""
    }
  }

  npm ERR!      /Users/.npm/_logs/2022-08-29T17_45_07_711Z-debug-0.log

ERROR | npm-ls: errors
  {}
/Users/code/example-amplify-app/node_modules/@cyclonedx/cyclonedx-npm/dist/builders.js:80
            throw new Error(`npm-ls exited with errors: ${error.errno ?? '???'} ${error.code ?? npmLsReturns.status ?? 'noCode'} ${error.signal ?? npmLsReturns.signal ?? 'noSignal'}`);
            ^

Error: npm-ls exited with errors: ??? 1 noSignal
    at BomBuilder.fetchNpmLs (/Users/code/example-amplify-app/node_modules/@cyclonedx/cyclonedx-npm/dist/builders.js:80:19)
    at BomBuilder.buildFromLockFile (/Users/code/example-amplify-app/node_modules/@cyclonedx/cyclonedx-npm/dist/builders.js:43:41)
    at Object.run (/Users/code/example-amplify-app/node_modules/@cyclonedx/cyclonedx-npm/dist/cli.js:97:19)
    at Object.<anonymous> (/Users/code/example-amplify-app/node_modules/@cyclonedx/cyclonedx-npm/bin/cyclonedx-npm-cli.js:2:27)
    at Module._compile (node:internal/modules/cjs/loader:1097:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1151:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
    at node:internal/main/run_main_module:17:47

Node.js v17.6.0

Alternatively, by running cyclonedx-npm --output-file=bom.json I get this error, and then it continues:
cyclonedx-npm --output-file bom.json
DEBUG | options: {"packageLockOnly":false,"omit":[],"flattenComponents":false,"specVersion":"1.4","outputFormat":"JSON","outputFile":"bom.json","mcType":"application"}
DEBUG | packageFile: /Users/code/example-amplify-app/package.json
DEBUG | projectDir: /Users/code/example-amplify-app
DEBUG | lockFile: /Users/code/example-amplify-app/package-lock.json
INFO  | gather dependency tree ...
DEBUG | npm-ls: run npm with ["ls","--json","--all","--long"] in /Users/code/example-amplify-app
WARN  | npm-ls: STDERR
  npm ERR! code ELSPROBLEMS
  npm ERR! invalid<EMAIL_ADDRESS>/Users/code/example-amplify-app/node_modules/react
  {
    "error": {
      "code": "ELSPROBLEMS",
      "summary": "invalid<EMAIL_ADDRESS>/Users/<name>/code/example-amplify-app/node_modules/react",
      "detail": ""
    }
  }

  npm ERR!      /Users/code/.npm/_logs/2022-08-29T17_33_01_546Z-debug-0.log

ERROR | npm-ls: errors
  {}
INFO  | build BOM ...
INFO  | writing BOM to bom.json

tried to install https://github.com/alexthemark/example-unmet-peer-dep
via npm ci
got an error straight away

Click to expand the error mesage

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer react@">= 16.8.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@aws-amplify/ui-react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   14 more (@aws-amplify/ui-react-v1, @radix-ui/react-presence, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/react-dom
npm ERR!   peer react-dom@">= 16.8.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@aws-amplify/ui-react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>|| ^17.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@aws-amplify/ui-react/node_modules/@radix-ui/react-dropdown-menu
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@aws-amplify/ui-react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   3 more (@radix-ui/react-menu, @radix-ui/react-portal, @aws-amplify/ui-react-v1)
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/react-dom
npm ERR!     peer react-dom@">= 16.8.0" from<EMAIL_ADDRESS>npm ERR!     node_modules/@aws-amplify/ui-react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!     peer<EMAIL_ADDRESS>|| ^17.0" from<EMAIL_ADDRESS>npm ERR!     node_modules/@aws-amplify/ui-react/node_modules/@radix-ui/react-dropdown-menu
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!       node_modules/@aws-amplify/ui-react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!     3 more (@radix-ui/react-menu, @radix-ui/react-portal, @aws-amplify/ui-react-v1)
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /.../.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR!     /.../.npm/_logs/2022-09-06T12_15_07_227Z-debug-0.log

Yep -- that would be perfect. Obviously I wish that I didn't have unmet peer deps and npm ls errors, but I'm tied to a library tied to a library. And I'd rather have npm ls errors and an SBOM than npm ls errors and no SBOM.

I'm happy to contribute that flag, or wait for a fix.

I am already on it :)

Thank you!! My repository is now successfully building its sbom!


More detailed git tutorials

The existing git tutorial could use some more work. The following aspects should be covered:

basic coverage of branch, checkout
basic fetching, pulling, merging and pushing
most useful git log options

It would be good to add detailed tutorials/demos for each of the above functions in separate script files. In addition, git stash, git rebase should be covered in separate tuterm scripts.

Glad to know, please add hacktoberfest-accepted label then assign this to me

@bhantsi Thanks for helping out.

@bhantsi No. The basic git tutorial goes to the git file that is already in the repo. The other tutorial files you can name as git-branch, git-rebase, etc. The tutorials should be tuterm scripts. Please look at the documentation of that project (especially the man page) to learn the syntax of a tuterm script.


Update hugo

goldmark notes:

I see a difference when we use the markdownify function; we no longer have smartypants. I'm not sure if there's another function for this
there are some cases the resulting HTML isn't valid with goldmark

For the second point, I think goldmark has an issue if there's a space in the inline HTML. I'll need to dig in more and report the issues upstream.
In the mean time we could probably update to the latest version but keep using blackfriday until all issues are sorted or until we find a workaround.

@bep: only thing left AFAICT is the smartypants issue when we use the markdownify function. Now we no longer get them. You can see this on:

https://twbs-bootstrap.netlify.com/docs/4.3/getting-started/introduction/
https://deploy-preview-29750--twbs-bootstrap.netlify.com/docs/4.3/getting-started/introduction/

https://www.diffchecker.com/7neZRrYz

@XhmikosR, you really lost me with this PR. What are goldmark, smartypants, blackfriday or markdownify exactly? Or what is the consequence of upgrading?
The only thing I notice is the table of contents looks different, this might need some more padding on the left.

The new Hugo version has switched the default Markdown library to goldmark
which has a different behavior in some cases like the invalid HTML.
On Thu, Dec 5, 2019, 23:03 Martijn Cuppens<EMAIL_ADDRESS>wrote:

@XhmikosR https://github.com/XhmikosR, you really lost me with this PR.
What are goldmark, smartypants, blackfriday or markdownify exactly? Or
what is the consequence of upgrading?
The only thing I notice is the table of contents looks different, this
might need some more padding on the left.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twbs/bootstrap/pull/29750?email_source=notifications&email_token=AACVLNMP2L35HCJVX3MUHWLQXFUCZA5CNFSM4JSFH7MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGCENDQ#issuecomment-562316942,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACVLNNCWTJLAZHO2XQSV63QXFUCZANCNFSM4JSFH7MA
.

It looks like you managed to fix the invalid HTML? What markup was generated before and is this a problem which will be detected by our tests if it occurs again?

No test can detect this apart from the HTML validator.

https://github.com/twbs/bootstrap/pull/29750/commits/95db6459a2afb13d3d98848792e367a095045100

The first issue I guess we'll live with it for the time being unless anyone has any strong opinion.

The first issue I guess we'll live with it for the time being unless anyone has any strong opinion.

Not really, but are there any benefits we gain from updating then?

For the same reason we update anything.

I'm gonna merge this tomorrow since I'd rather follow the hugo versions than sticking to an old one. The smartypants issue is reported upstream.


Remove message and error on ResendValidationForm load

cc @MonilBhavsar
Details
Clears message and errors when rendering ResendValidationForm.
Fixed Issues
$ https://github.com/Expensify/App/issues/11186
Tests
On android and iOS only:

Enter your email in the login page
Tap Continue
Tap Forgot?
In your terminal, run the command below to send a deep link to the simulator:

Android:
adb shell am start -W -a android.intent.action.VIEW -d "http://new.expensify.com/setpassword/2/HFSKDF"

iOS:
xcrun simctl openurl booted https://new.expensify.com/setpassword/2/HFSKDF

Type a new password and tap Set password
This should result in an error for invalid link
On android: Tap on back button from the android OS
On iOS: Swipe right to go back
You should go back to the Forgot? page and the Link has been re-sent or error messages should disappear shortly after

[x] Verify that no errors appear in the JS console

PR Review Checklist
Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps
On android and iOS only:

Enter your email in the login page
Tap Continue
Tap Forgot?
Tap the Resent link button twice, you should see a Link has been re-sent message
Go to you email and find the magic sign-in link email from Concierge (you should have received a few of them)
Tap the link from the oldest email, this link should be invalid now but that's what we want here
Type your new password
Tap Set Password, see the invalid link error
On android: Tap on back button from the android OS
On iOS: Swipe right to go back
You should go back to the Forgot? page, and notice that the Link has been re-sent or any error messages disappear (there might be a small delay for them to disappear)

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS
https://user-images.githubusercontent.com/22219519/192861944-27b1fd98-885a-4188-bff2-3fa8f3d5091e.mov
Android
https://user-images.githubusercontent.com/22219519/192859801-5fc6c953-6a15-43cb-b408-4df579ddd1f4.mov

@MonilBhavsar Yes, it still shows up for a brief moment until SetPassword unmounts, those keys are cleared from Onyx and ResendValidationForm is re-rendered.
I think a faster way would be to clear those keys in the constructor of ResendValidationForm, but the issue is that ResendValidationForm never unmounts/re-mounts, so this is not a valid solution. Not sure if there are any other faster ways to clear those keys before ResendValidationForm becomes visible.

Ah got it. I agree it's not a blocker but I think we should fix it at some point as it looks bit janky. I can't think a way on the top of my head. I think we can create an issue to polish it.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @Julesssss in version: 1.2.11-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @AndrewGable in version: 1.2.11-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


add IsOperationErrorPreconditionFailed function

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Codecov Report
Base: 60.49% // Head: 57.28% // Decreases project coverage by -3.20% :warning:

Coverage data is based on head (8a82d1d) compared to base (07cff18).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
- Coverage   60.49%   57.28%   -3.21%
==========================================
  Files         234      234
  Lines       25303    25305       +2
==========================================
- Hits        15308    14497     -811
- Misses       9035     9897     +862
+ Partials      960      911      -49

Flag
Coverage Δ

1.16.x
50.41% <0.00%> (-9.73%)
:arrow_down:

1.18.x
53.87% <0.00%> (-6.51%)
:arrow_down:

1.19.x
54.73% <0.00%> (-5.65%)
:arrow_down:

connection
10.38% <0.00%> (-0.01%)
:arrow_down:

database_sql
?

discovery
8.67% <0.00%> (-0.01%)
:arrow_down:

e2e
45.04% <0.00%> (-3.95%)
:arrow_down:

integration
?

macOS-latest
38.30% <0.00%> (+0.03%)
:arrow_up:

ratelimiter
10.27% <0.00%> (+0.15%)
:arrow_up:

scripting
10.67% <0.00%> (-0.31%)
:arrow_down:

table
27.92% <0.00%> (-0.02%)
:arrow_down:

topic
27.50% <0.00%> (+0.07%)
:arrow_up:

ubuntu-latest
57.28% <0.00%> (-3.16%)
:arrow_down:

unit
38.31% <0.00%> (-0.09%)
:arrow_down:

windows-latest
?

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

This feature extends the public SDK API unnecessarily
We recommend to use ydb operation codes for check precondition failed


Make View+SystemKeyboardButton apply more styles

This should include corner radius, shadows etc.

This can be tested in the v5 branch.


Replace playwright with JSDOM

Splitting into two PRs is no problem, I just can't switch modules yet. That's hard for me to do.

Because I haven't learned yet. hahahaha

@Jermolene Split PR Completed

Thank you @Zacharia2. I notice #20 is closed, will you be resubmitting those changes?

OK，@Jermolene

Hi @Zacharia2 I do apologise again for taking so long over these PRs. I haven't been in a position to work on TWPub for a few weeks, but I am very keen to accept these contributions. I would be very grateful if you could re-establish the PRs.

The new recovery PR is now re-opened.


Gitter channel for scalacheck?

It would be nice to have a gitter channel for scalacheck!

A gitter channel for asking questions would be wonderful.

Yes! :+1:

This seems like a good idea. What do you think @rickynils? It should be quite easy for a project owner to set one up (and you wouldn't have to actually visit it if you didn't want to).

👍

That'd be great - I tend to not open issues when the problem is not clearly on the project's side, since it sort of feels like I'm blaming the author for something that is likely my fault. Without a gitter channel, what's the alternative? stack overflow?

Sorry to bump this one, but is any of the maintainers available to go forward with this?

I've finally set up this now: https://gitter.im/scalacheck/Lobby#


Helm does not follow uninstall order.

Output of helm version:
Client: &version.Version{SemVer:"v2.11.0", GitCommit:"2e55dbe1fdb5fdb96b75ff144a339489417b146b", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.13.1", GitCommit:"618447cbf203d147601b4b9bd7f8c37a5d39fbb4", GitTreeState:"clean"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.4", GitCommit:"c27b913fddd1a6c480c229191a087698aa92f0b1", GitTreeState:"clean", BuildDate:"2019-02-28T13:37:52Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.3", GitCommit:"721bfa751924da8d1680787490c54b9179b1fed0", GitTreeState:"clean", BuildDate:"2019-02-01T20:00:57Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.): OPENSTACK
PROBLEM:
Helm does not follow the order while deleting the chart. In My test case, helm first delete the storage class and then go for crd deletion.  but it should be reverse as per
https://github.com/helm/helm/blob/v2.13.1/pkg/tiller/kind_sorter.go
[kube] 2019/04/12 09:12:41 Starting delete for "curator" CronJob
[kube] 2019/04/12 09:12:41 Starting delete for "elastic-cinder-class" StorageClass
[kube] 2019/04/12 09:12:41 Starting delete for "es-custom-config" ConfigMap
[kube] 2019/04/12 09:12:42 Starting delete for "curator-config" ConfigMap
[kube] 2019/04/12 09:12:42 Starting delete for "es-auth" Secret
[kube] 2019/04/12 09:12:42 Starting delete for "es-elastic" Elasticsearch```

ElasticSearch is a CRD.
Any idea what is going wrong??

Ideally First CRD should get deleted then Storage class.

Hi @HarishHothi. Thanks for submitting this.
This does seem strange on a first look. Based on the docs as well as the source, resources for dependent charts should be aggregated into a single set, sorted and then created/deleted based on a defined sort order.
Can you share more information about the chart for which you are seeing this behavior, or better yet, would it be possible to get a minimum working repro of this?
Thanks!

Hi @SlickNik, I am seeing this while I am installing elastic Search using kubedb Operator. Overall flow can be describe as below.

Deploy KubeDB operator
Once Kubedb Installed, it will create ElasticSearch CRDs.
We have custom helm chart which does CRO creation of CRD type elasticSearch along with storage class, secrets, configmap and cron job to purge elastic data.
Installation works Perfectly and Elastic Search cluster will spinup as per the CRO.
While helm purge, I am seeing my storage class will get deleted first then my CRO deletion happens.
Kubedb operator has validation hooks and is not able to delete the CRO since storage class is deleted first.
Please let me know any other info is required.

Hi Guys any update on this?

closing as inactive/stale. If you have more information to share, please feel free to update the ticket.


Requirements.txt error

I'm getting the same error without/with using venv:
Looking in indexes: https://pypi.org/simple, https://download.pytorch.org/whl/cu117
Collecting numpy==1.24.3 (from -r requirements.txt (line 1))
  Using cached numpy-1.24.3-cp311-cp311-macosx_11_0_arm64.whl (13.8 MB)
Collecting openai-whisper==20230314 (from -r requirements.txt (line 2))
  Using cached openai-whisper-20230314.tar.gz (792 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Collecting Wave==0.0.2 (from -r requirements.txt (line 3))
  Using cached Wave-0.0.2.zip (38 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Collecting openai==0.27.6 (from -r requirements.txt (line 4))
  Using cached openai-0.27.6-py3-none-any.whl (71 kB)
Collecting customtkinter==5.1.3 (from -r requirements.txt (line 5))
  Using cached customtkinter-5.1.3-py3-none-any.whl (295 kB)

ERROR: Ignored the following versions that require a different python version: 1.21.2 Requires-Python >=3.7,<3.11; 1.21.3 Requires-Python >=3.7,<3.11; 1.21.4 Requires-Python >=3.7,<3.11; 1.21.5 Requires-Python >=3.7,<3.11; 1.21.6 Requires-Python >=3.7,<3.11
ERROR: Could not find a version that satisfies the requirement PyAudioWPatch==<IP_ADDRESS> (from versions: none)
ERROR: No matching distribution found for PyAudioWPatch==<IP_ADDRESS>

Are you trying to install this on a mac?

yeah, you're on mac. Doesn't work yet

I can see. Thanks for your answers.


Not working in bevy 0.8 in browser

Using v0.4.1 (and prior 0.8 compatible releases), I get the following runing in firefox and chrome:
panicked at 'wgpu error: Validation Error

Caused by:
    In Device::create_bind_group_layout
      note: label = `bevy_atmosphere_associated_bind_group_layout`
    too many bindings of type StorageTextures in stage COMPUTE, limit is 0, count was 1

', /Users/bit/.cargo/registry/src/github.com-1ecc6299db9ec823/wgpu-0.13.1/src/backend/direct.rs:2391:5

Stack:

Error
    at imports.wbg.__wbg_new_693216e109162396 (http://<IP_ADDRESS>:8080/app-61cea4eed552c599.js:1698:21)
    at _ZN24console_error_panic_hook4hook17he2cc4c98d98c1779E (http://<IP_ADDRESS>:8080/app-61cea4eed552c599_bg.wasm:wasm-function[9391]:0xa00de7)
    at _ZN4core3ops8function2Fn4call17hca5dc860f7bd75e4E (http://<IP_ADDRESS>:8080/app-61cea4eed552c599_bg.wasm:wasm-function[37212]:0xd5d164)
    at _ZN3std9panicking20rust_panic_with_hook17h94d65730dd207ad3E (http://<IP_ADDRESS>:8080/app-61cea4eed552c599_bg.wasm:wasm-function[15942]:0xbd5eb6)
    at _ZN3std9panicking19begin_panic_handler28_$u7b$$u7b$closure$u7d$$u7d$17h411a2cda51c5c2f3E (http://<IP_ADDRESS>:8080/app-61cea4eed552c599_bg.wasm:wasm-function[17994]:0xc3786a)
    at _ZN3std10sys_common9backtrace26__rust_end_short_backtrace17h280a719b84229705E (http://<IP_ADDRESS>:8080/app-61cea4eed552c599_bg.wasm:wasm-function[27210]:0xd28ed8)
    at rust_begin_unwind (http://<IP_ADDRESS>:8080/app-61cea4eed552c599_bg.wasm:wasm-function[23275]:0xce5740)
    at _ZN4core9panicking9panic_fmt17h2b1709d02b4266aeE (http://<IP_ADDRESS>:8080/app-61cea4eed552c599_bg.wasm:wasm-function[26186]:0xd1b22b)
    at _ZN4core3ops8function2Fn4call17h920ef82c122a8bc9E (http://<IP_ADDRESS>:8080/app-61cea4eed552c599_bg.wasm:wasm-function[16625]:0xbf9110)
    at _ZN4wgpu7backend6direct7Context12handle_error17hdde4e76247cf4280E (http://<IP_ADDRESS>:8080/app-61cea4eed552c599_bg.wasm:wasm-function[1687]:0x4ed4aa)

Is this some browser related restriction? Happy to try things if there's any suggestions.

(trunk serve as a packaging mechanism. If I would give you a better less mangled stack trace if I could get access to one!)

See #22. In order to increase native performance, I switched to using a compute shader to render to a texture. This breaks browser compatibility with WebGL 2. It should be fixed when WebGPU is shipped sometime next year. You can also enable WebGPU in your browser via experimental flags.


Selection formats, resolutions and codecs

Formats available (no only YouTube)
From werid:
Isn't the main problem with the format list that you cannot choose two formats to merge via that list?
it's only useful for people who might want a pre-combined format or audio only format.
if i check the boxes of mp4 [480p] (Dash video) and mp4 [1080p] (Dash video), they show up in the drop downdown list next to the add button, but it downloads only that video only format, i can't tell yt-dlg to combine with an audio format. i have to keep it at default to get video+audio, and use the cli backend arguments to specify any -f or -S to nudge the default into a specific format(s) direction.
i think if you want to improve this part of yt-dlg, you should make it a bit more abstract. if people want to choose specific formats, they can do that via the manual arguments.
people care about resolution, codec, container - although they often don't know they care about codec and container, and often confuse the two.
imagine a format selection screen where you get choices between the common codec/containers, and then choose your desired resolution.
[ ] I only want the selected resolution, skip downloading if not available

[ ] best available resolution
[ ] 4320p
[ ] 3072p
[ ] 2160p
[ ] 1440p
[ ] 1080p
[ ] 720p
[ ] 480p
[ ] 360p
[ ] 144p

Video with audio  # default to sensible audio choices, i.e. mp4 = m4a, anything else opus
[ ] mp4  (h264)   # show a hint that this is what most people think of when they want mp4
[ ] webm (vp9)
[ ] webm (av1)
[ ] mkv  (vp9)
[ ] mkv  (av1)
[ ] mkv  (ios premium)
[ ] mp4  (h264 ios premium) # this will use --recode mp4, but make sure it forces downloads opus audio)

Audio only
[ ] m4a
[ ] opus
[ ] mp3  # Maybe include quality options like the ones below, but pick a default of vbr or 320 ... ?
    [ ] variable bit rate
    [ ] 320 constant bit rate
    [ ] 128 constant bit rate
[ ] wav
[ ] flac

if user chooses 2160p and mp4 (h264), then maybe alert user that this might take a while because it has to re-encode.
omething i'm unsure of is whether or not to let user choose to skip or fall back to vp9 is av1 is unavailable ... there are also videos where vp9 is unavailable on youtube
something i've not thought about is non-youtube sites, as they tend to default to mp4 (h264)
could separate youtube settings and generic video settings ... this is just an example anyways ... but i could probably come up with something that works if you're interested
i think i would also start checking whether or not ffmpeg is available and tell the user that it is needed for most operations and video download will be limited to a maximum of 720p on youtube and may cause other sites to fail completely. do a popup on start and give users a few buttons ala "show me how to install ffmpeg" and open browser to your ffmpeg installation guide. another button could be "i know what i'm doing, don't show this again", and maybe a third button which will skip the message for now but show again later...
if they keep going into the format selection screen without ffmpeg, then most of the options are useless, so don't let them choose much. either show them a different selection with the limited choices you now have, or show a message that this screen is disabled due to missing ffmpeg.

Use case:
User: 4K would be best. Failing that, 1080p. My videos are in 4k which is why I need it...
Presets:
ok, think i've got a good setting for you.
click the cogwheel and choose options, then go to the Extra tab, and paste the following into the CLI Backend command line options field:
-f "bv[height>1080][width>1920][vcodec^=vp9][ext=webm]+ba[ext=webm]/bv[ext=mp4][vcodec^=avc]+ba[ext=m4a]/b[ext=mp4]/b" --recode mp4

if you need both horizontal and vertical videos, do test it and provide examples if they don't come out in the right resolutions/formats ...