Updated @gnosis.pm/safe-react-gateway-sdk to fix SafeAppsResponse types

What it solves
Resolves this minor issue with the types in the gateway-sdk
How this PR fixes it
Updated @gnosis.pm/safe-react-gateway-sdk to 2.8.2 version and removed the @ts-ignore in the AppList.test.js

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 32.485%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3163

Relevant Lines:
8685

💛  - Coveralls

Tremendo cumbión @DaniSomoza thank you
https://www.youtube.com/watch?v=LT1qnCQ9ED4


Adding service bus operations fluent api

Generated code is modified with a temporary workaround for the issue https://github.com/Azure/azure-sdk-for-java/issues/1641
The swagger is missing definition of description property in Operation model, adding it manually now and will open an issue in the rest api spec.

before we merge this, I'm waiting for my Beta "since" support PR to be merged into annotations, so that we can start marking additions to v1.1 that are initially in Beta with @Beta(Version.V1.1.0)

Assuming the Beta-since support is now live, pls update the PR with @Beta(SinceVersion.V1_1_0):

on top of any new interfaces (just the models, not the fluent definition/update ones) added in this version, related to ServiceBus, if any
on top of any new methods exposing the new functionality added to already previously released interfaces or objects (e.g. Azure, the corresponding Manager class, svcbus interfaces that were already in @Beta in v1.0.0)


Costs field

Allow the costs to be filled in in a separate field (same as location,start/end date, etc.)

I'm currently working on a new way of registrations (with tickets). These will include pricing.

Will this new way of registering be an option which can be enabled separately for each event?

Per event you can add tickets, per ticket you can specify the price of that ticket.


remove errors when updates are skipped

this should be done as part of the upgrade to botmaster 3.0. The middleware should resolve 'skip' to avoid throwing an error.

fixed as part of 4.x


Add decode data method in Tx Service Api

Closes https://github.com/safe-global/safe-eth-py/issues/1006

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

16 of 17 (94.12%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.02%) to 93.499%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

gnosis/safe/api/transaction_service_api/transaction_service_api.py
7
8
87.5%

Files with Coverage Reduction
New Missed Lines
%

gnosis/eth/ethereum_client.py
1
86.16%

gnosis/safe/tests/utils.py
1
60.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
8068

Relevant Lines:
8629

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

16 of 17 (94.12%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.02%) to 93.499%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

gnosis/safe/api/transaction_service_api/transaction_service_api.py
7
8
87.5%

Files with Coverage Reduction
New Missed Lines
%

gnosis/eth/ethereum_client.py
1
86.16%

gnosis/safe/tests/utils.py
1
60.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
8068

Relevant Lines:
8629

💛  - Coveralls


Add constructor for pre-existing DynamicWatcher

This allows users that already have a DynamicWatcher and are using Query Batches to supply their instance to the template resolver. Most details of managing the watcher and the batch are delegated to the user: this package will not automatically stop the query batch after the template is resolved, for instance.

/hold
I believe this is ready for review, but I want to run and end-to-end kind of thing with it before it merges.

https://github.com/open-cluster-management-io/config-policy-controller/pull/235 is an example use of this (also using another change to this package which I think would be a good separate PR).

/unhold


Show customer properties on the card

Hello,
I have a number of custom task fields defined. However, I am not able to pull them on to the card.
Is it anything that can be configured?
Thank you,
IK

I couldn't say for certain without more information but the code utilizes
Microsofts standard objects/properties.
https://msdn.microsoft.com/en-us/vba/outlook-vba/articles/taskitem-object-outlook
On Fri, Jul 21, 2017 at 2:15 PM, iksub<EMAIL_ADDRESS>wrote:

Hello,
I have a number of custom task fields defined. However, I am not able to
pull them on to the card.
Is it anything that can be configured?
Thank you,
IK
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/evrenvarol/outlook-taskboard/issues/28, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABKsCG7TIPWZgoPlz6zwyw0FYET-Wd7Fks5sQRTggaJpZM4Of5pa
.


Improve comparing multiple file lists

Description

Design, Discovery, & Research
Unable to easily compare between files when grouped, requires many clicks to compare two groupings of files. In the below example to compare these three file lists this required ~13 clicks. AIBS would like to do this with dozens of file lists. We also talked about having a breadcrumb style presentation of the groupings when all expanded to save space and more compactly show the difference between groups.

Below to be filled out by UX during kickoff Q&A to the best of current understanding
Size
S
Scope
What will we do? What will we NOT do?
User needs statement(s)
As a user I want to be able to compare 5+ lists of files without having to click 10+ times.
Additional notes
Knowns/unknowns, stakeholders, time/dependency considerations, deliverables

After meeting with Yoav and Nicholas to clarify exact user needs, we decided on the following solution:
Implement functionality and new menu items at all folder levels (right click) to either expand ALL of the tree at once, or the inverse. Use fluent design icons shown here.


feat: magic link

Closes #151. This PR has a lot going on. Something that have changed around that app itself.

The dev container now installs node and also dynamodb-admin, which is a tool to admin dynamoDB databases. It is configure to connect to the local DB and will open a GUI on localhost:8001 if you run it with dynamodb-admin from the terminal.
The DynamoDB table has been changed to overload the schema. Previously the parition key was short_url, now it is key_id. This allows the table to handle different object types that have a key_id of MODEL_PREFIX/id so for example, short_url objects are now URL/abcde. The table also has a global secondary index using an email field, which is what allows a look up if a magic link has already been sent to a specific email.
The terraform has been adjusted to make this change and require a replace of the DB.

The feature works as follows:

User visits / and because they are not logged in, get redirected to /login. Login status is checked by seeing if a uuid (ex. bde8f9fb-8a41-4e38-a8e4-3e9ed9e2967c) is present in a cookie with the key _sessionID. If a UUID is found it is compared to keys in the DynamoDB table that are prefixed withSESSION, ex: SESSION/bde8f9fb-8a41-4e38-a8e4-3e9ed9e2967c. If that record exists in the DynamoDB table, then the user is considered logged in.

On /login a user is asked to provide an email address that ends with a domain on the ALLOWED_DOMAINS env variable. If their domain is not on that list, the receive an error:

if the email is on the safelist, then they see the following:

at the same time a new record is created in the DynamoDB table that records the email and the magic link uuid.
To avoid spamming, they can only request a magic link once every five minutes. This is done by checking the record created in the DynamoDB table:

Once submitted, Notify will send the user an email with a link they can follow:

The app will validate that the magic link is still active, and if it is, delete the magic link entry in the DynamoDB table and create a cookie with a UUID that references the session in the DynamoDB table. After two hours, the session will expire and the user will need to log in again.

Alternatively, the user can also log out using the /logout functionality in the top right.

Tech debt added

Unilingual error messages
Tests that check for unilingual error messages
Some strange templating conditions in jinja
Single table designs 😬
Need to look at TTL for tables (48 hour expiry)

Thank you for catching that issue and I added you and the other folks to the team in Notify!


Replace references auth with the client auth

Currently the references auth only allows one auth per type. The client auth allows multiple. We should swap it out as soon as we get some nice new designs

Hi @amritk, commenting here so that I get notified when this issue gets resolved.


Add support for generating debuginfo RPMs

This change enables the creation and capture of debuginfo RPMs on
Fedora40 and CentOS7.
See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/
Fedora 40 expects the RPM contents to be located in a subdirectory
which is specified using the buildsubdir variable.  In order to
account for this, we need to tweak some of the location details if
debuginfo is enabled.
CentOS expects buildsubdir to have a value like . instead.
In both cases, we disable debugsource packages by ensuring that we
undefine _debugsource_packages, otherwise we'll try to generate them
alongside the debuginfo packages and will fail.
We only want this method of producing debuginfo to apply when we're
using the system rpmbuild because the underlying behaviour is
controlled by a combination of the rpmbuild version, macro
definitions, find-debuginfo.sh, and debugedit.  If we were to expand
this to use a hermetic debuginfo then a different approach might be
desirable.

I'm going to be slow to respond. Every hour of this week is booked.

I'm going to be slow to respond. Every hour of this week is booked.

Thanks for the heads up

But it leads to the question of the name of debuginfo_type. Is it really distinguishing the format of the debuginfo, or is it really a distinguisher of the target os? If you could build for fedora from centos, should it be an attribute of the rule rather than picked up as a side effect in the toolchain?
Are there other constraints or information about cross building which should make sense in the docstring?

tl;dr I don't think I can assert anything about cross building with this at all, unfortunately :(
We're relying on the system rpmbuild for this which means that we're also relying on the various rpm macros and and supporting tools in place that belong to the system that we're building on.  debuginfo_type is a bit of a misnomer here, perhaps, but what it's referring to is the OS configuration for the aforementioned version of rpmbuild (incl macros, etc) not the target OS.  Initially I had allowed this to be selected in the module extension, but decided I just wanted to make this auto-detect so that we could at least hypothetically have the defined rules be system independant.
Can definitely clarify some of how this works in the docstring, however.

Can you just fix that period in the docstring and I'll merge.

Done

Sorry for the  late merge. Hugely busy weekend.


CLOUD-61481 remove slider patch

@keyki

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/cloudbreak-pull-request/2873/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/366/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/367/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/cloudbreak-pull-request/2875/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/369/


Boundaries - Annexation reviews

Is this handled by #256 #257 #258?

Is this handled by #256 #257 #258?

Yes, and currently #404. This issue is a relic of the beginning times of PI planning. Thanks for working to clean up the backlog.


When an account is deleted in Sierra, it should be deleted from Auth0

Need to talk to Library Systems Support when this is picked up so they know what's happening.


Made LiveServerTestCase bind to port 0.

Proof of concept for an idea that came up in IRC the other day. Docs would need to be done.
django-developers thread

buildbot, test on selenium.

That was also on my to-do list :) Looks promising!

buildbot, test on selenium.

buildbot, test on selenium.


Bug Report: cupy.linalg.invand numpy.linalg.invbehave differently on singular matrix

Description
cupy.linalg.invand numpy.linalg.invbehave differently on singular matrix
To Reproduce
import numpy as np
import cupy as cp

a1 = cp.array([[0]])
a2 = cp.linalg.inv(a1)
print(a1, a2)
print(a1 @ a2, np.eye(a1.shape[0]))

print(np.linalg.inv(np.array([[0]])))

Output:
[[0]] [[inf]]
[[nan]] [[1.]]
Traceback (most recent call last):
  File "/test.py", line 9, in <module>
    print(np.linalg.inv(np.array([[0]])))
  File "/usr/local/lib/python3.10/dist-packages/numpy/linalg/_linalg.py", line 615, in inv
    ainv = _umath_linalg.inv(a, signature=signature)
  File "/usr/local/lib/python3.10/dist-packages/numpy/linalg/_linalg.py", line 104, in _raise_linalgerror_singular
    raise LinAlgError("Singular matrix")
numpy.linalg.LinAlgError: Singular matrix

NumPy throws an error, while CuPy returns [[inf]]. As numpy doc claims,

Given a square matrix a, inv returns the matrix ainv satisfying a @ ainv = ainv @ a = eye(a.shape[0]).

a1 @ a2==[[nan]] and eye(a1.shape[0])==[[1.]]. Hence, the return of CuPy is not very sensible.
Installation
Wheel (pip install cupy-***)
Environment
OS                           : Linux-6.8.0-49-generic-x86_64-with-glibc2.35
Python Version               : 3.10.12
CuPy Version                 : 13.3.0
CuPy Platform                : NVIDIA CUDA
NumPy Version                : 2.1.0
SciPy Version                : 1.13.1
Cython Build Version         : 0.29.36
Cython Runtime Version       : 0.29.37
CUDA Root                    : /usr/local/cuda
nvcc PATH                    : /usr/local/cuda/bin/nvcc
CUDA Build Version           : 12060
CUDA Driver Version          : 12040
CUDA Runtime Version         : 12060 (linked to CuPy) / 12020 (locally installed)
CUDA Extra Include Dirs      : []
cuBLAS Version               : 120201
cuFFT Version                : 11008
cuRAND Version               : 10303
cuSOLVER Version             : (11, 5, 2)
cuSPARSE Version             : 12101
NVRTC Version                : (12, 2)
Thrust Version               : 200600
CUB Build Version            : 200600
Jitify Build Version         : <unknown>
cuDNN Build Version          : None
cuDNN Version                : None
NCCL Build Version           : None
NCCL Runtime Version         : None
cuTENSOR Version             : None
cuSPARSELt Build Version     : None
Device 0 Name                : NVIDIA GeForce RTX 4070 Laptop GPU
Device 0 Compute Capability  : 89
Device 0 PCI Bus ID          : 0000:01:00.0

Additional Information
No response

I notice cupy's doc:

This function calls one or more cuSOLVER routine(s) which may yield invalid results if input conditions are not met. To detect these invalid results, you can set the linalg configuration to a value that is not ignore in :func:cupyx.errstate or :func:cupyx.seterr.

But I am not be able to find cupyx.seterr.

This is by design as documented. cupyx.seterr is currently undocumented but should be there.


get_interface_counters fails with stacktrace

Description of Issue/Question
When using get_interfaces_counters() for EOS you will get an error due to the fact that 'show interfaces error countes ' is not supported for port channels
Setup
napalm-eos version
(Paste verbatim output from pip freeze | grep napalm-eos between quotes below)
napalm-eos==0.4.1

eOS version
(Paste verbatim output from show version | json between quotes below)
{
    "modelName": "DCS-7280SR-48C6-M-R",
    "internalVersion": "4.17.1F-3465508.4171F",
    "systemMacAddress": "44:4c:a8:cd:33:7d",
    "serialNumber": "JPE16260700",
    "memTotal": 32472080,
    "bootupTimestamp":<PHONE_NUMBER>.55,
    "memFree": 29033616,
    "version": "4.17.1F",
    "architecture": "i386",
    "isIntlVersion": false,
    "internalBuildId": "5b73e68d-e45b-4748-8d38-abf09997c867",
    "hardwareRevision": "11.03"
}

Steps to Reproduce the Issue
Error Traceback
In [4]: dev.get_interfaces_counters()
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-4-2dba5f41065f> in <module>()
----> 1 dev.get_interfaces_counters()

/home/loke/repos/napalm-eos/napalm_eos/eos.py in get_interfaces_counters(self)
    295
    296             # Errors come from a different command
--> 297             errors = output[1]['interfaceErrorCounters'][interface]
    298             interface_counters[interface]['tx_errors'] = errors.get('outErrors', -1)
    299             interface_counters[interface]['rx_errors'] = errors.get('inErrors', -1)

KeyError: u'Port-Channel2'

Yo @tehhobbit I would need two more info from you:

what do you see in your device when running show interfaces counters | json and show interfaces counters errors | json for those interfaces (port channels)
please paste the complete traceback - I would recommend to jump in a Python console and paste the complete error trace.

Thanks!

Requested output bellow
show interfaces counters
    "Port-Channel1": {
        "inUcastPkts": 0,
        "outMulticastPkts": 0,
        "outUcastPkts": 0,
        "inMulticastPkts": 0,
        "outBroadcastPkts": 0,
        "inBroadcastPkts": 0,
        "inDiscards": 0,
        "inOctets": 0,
        "outDiscards": 0,
        "outOctets": 0
    },

For error port-channel is simply missing

Closed via https://github.com/napalm-automation/napalm-eos/pull/76
Thanks @tehhobbit!


What is the command to disable resetting pc example below

https://www.youtube.com/watch?v=reArD_O5YBw&t=270s <<< seen here

write this to the bot on discord: .cmd reagentc.exe /disable

Hey, just use the ModdedPysilon version, it covers every bug and it make sure your discord account never get banned.
Leave me a star if you like my project ;)


unexpected end of JSON input

Prometheu version=2.3.1
level=error ts=2018-06-21T08:20:01.914472896Z caller=file.go:321 component="discovery manager scrape" discovery=file msg="Error reading file" path=/etc/prometheus/jobs/node.json err="unexpected end of JSON input"

But /etc/prometheus/jobs/node.json file is a valid json file.I use
python -m json.tool /etc/prometheus/jobs/node.json

to check it

Is the file being created atomically via rename?

I know the reason.
I write a program to update /etc/prometheus/jobs/node.json file every minute
And I set refresh_interval to 15s in prometheus.yml

@pc10201 can you close the issue in that case?

@pc10201 I'm closing the issue as it looks like you got things sorted out. If this isn't the case, I recommend that you ask for help on our user mailing list.

@pc10201 How you fixed this problem? I have discovery service for Rancher, which rewrite job file every 30 seconds. So every time Prom try to read this file, it's putting error into log.

@pc10201 How you fixed this problem? I have discovery service for Rancher, which rewrite job file every 30 seconds. So every time Prom try to read this file, it's putting error into log.

I do not fix it.But I change my program to create a tmp file,if the file is same as before and will not override it.

Is the file being created atomically via rename?

Which is best for this situation, writing to a temporary file and then using os.Rename, or overwriting the existing file with ioutil.WriteFile or similar?

I know the reason.
I write a program to update /etc/prometheus/jobs/node.json file every minute
And I set refresh_interval to 15s in prometheus.yml

how you solve the issue?

@pc10201 how you override ? which api do you use?


Webpage

Challenge Build a Personal Portfolio Webpage has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.

@Ririnrinasty same thing here, can you please describe the issue you are having? Thanks!

Closing for now.
@Ririnrinasty ReOpen if you can add further details of the Issue you are having


Create s3 bucket and copy

What does this PR do?
Provides an updated example which has the following changes:

creates the S3 bucket defined by a new variable
uploads DAGS in the dags folder to this new S3 bucket
fixes tags

Motivation
typically you want to define/create./upload the DAGS folder as part of the MWAA build/deployment. Also, this new example provides a cleaner create/delete approach.
More

[ X] Yes, I have tested the PR using my local account setup  (Provide any test evidence report under Additional Notes)
[ ] Yes, I ran pre-commit run -a with this PR

For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

I couldn't push changes to this PR #18  hence i opened another PR which includes your commits
Closing this PR for now


add run in colab button

Thank you for your contribution; I've already merged it. I am currently undertaking a major refactoring of the code to support some new features such as saving and loading IDs, multiple characters, and more. Afterwards, I may need to trouble you to make corresponding modifications.


[REQUEST] I want to request some features

1.In the page that does nothing, you can use that to show lyrics like MusicBee, foobar2000,...
(The page that does nothing)

(Example)

The suggestion to make this possible is to allow the user to paste lyrics from a certain source into the music file (embed lyric) or save it locally in the osu!player folder. (Support sync lyric if possible)
(Example)

2. Add a function to help users see the metadata of the song
It can be simple or complex
The suggestion to make this possible is add a line 'Song Info' on right click or use "the page that does nothing"
3. Add history
4. Plugin support (.dll support)

I don't see any sense, why we should support it. As A it generates a lot of overhead for us to implement (sync) and B osu! songs don't have lyrics in general, so I don't see why any user would look up the lyrics and paste them one by one.
If you mean the metadata of a osu! song, and just the info that is stored inside the Beatmap. Yes we could do that. But on the other hand I'm more thinking why this is needed and should be implemented. In the end this is a music player. Most of the metadata inside that .osu file is just stuff for the Beatmap. Timing points etc. etc. there isn't that much meta data for the song itself
If you mean a play history, then yes why not. this makes sense to implement.
Why? There is like no reason in the world we need that. First we have to write a framework that makes it even possible to create said plugins and load them into our app. Meanwhile you could implement the plugin itself into the player as a feature and make it a feature itself instead of a plugin. There is a reason why we are open source. If a person has an idea and wants to implement it as a feature there is no way of us stopping them. It's all mentioned in the Contributing section on the Read Me.

also I want to mention that the nothing page is already reserved for the beatmap page, when it's done it will replace that view


Cannot delete type

Describe the bug
Trying to delete a custom type I get an error that the version is missing, but I don't see a way to provide it.
To Reproduce
projectApiRoot.types().withKey("test").delete().executeBlocking()
ERROR --- [    httpclient-dispatch-2]                                 commercetools.types.response : DELETE https://api.europe-west1.gcp.commercetools.com/project/types/key=test 400
Exception in thread "main" io.vrap.rmf.base.client.error.BadRequestException: detailMessage: Client error response [url] https://api.europe-west1.gcp.commercetools.com/project/types/key=test [status code] 400 [reason phrase] Bad Request
summary: DELETE https://api.europe-west1.gcp.commercetools.com/project/types/key=test failed  with response code 400 with X-Correlation-ID `{key=x-correlation-id, value=projects-b70262c7-1f96-444a-b12e-c9ebb679e751}` on 2022-01-20T13:42:50.024519Z
http response formatted body: {
  "statusCode" : 400,
  "message" : "Missing version number",
  "errors" : [ {
    "code" : "InvalidOperation",
    "message" : "Missing version number"
  } ]
}
http response: io.vrap.rmf.base.client.ApiHttpResponse@3708eea4[statusCode=400,headers=[{key=date, value=Thu, 20 Jan 2022 13:42:48 GMT}, {key=content-length, value=127}, {key=server, value=istio-envoy}, {key=x-envoy-upstream-service-time, value=0}, {key=access-control-allow-headers, value=Accept, Authorization, Content-Type, Origin, User-Agent, X-Correlation-ID}, {key=x-correlation-id, value=projects-b70262c7-1f96-444a-b12e-c9ebb679e751}, {key=access-control-allow-methods, value=GET, POST, DELETE, OPTIONS}, {key=via, value=1.1 google}, {key=access-control-expose-headers, value=X-Correlation-ID}, {key=access-control-allow-origin, value=*}, {key=x-http-status-caused-by-external-upstream, value=false}, {key=access-control-max-age, value=299}, {key=content-type, value=application/json; charset=utf-8}, {key=server-timing, value=projects;dur=0}, {key=alt-svc, value=clear}],textInterpretedBody={"statusCode":400,"message":"Missing version number","errors":[{"code":"InvalidOperation","message":"Missing version number"}]}]
SDK: 7.3.0
endpoint: DELETE https://api.europe-west1.gcp.commercetools.com/project/types/key=test
Java: 17.0.2
request: io.vrap.rmf.base.client.ApiHttpRequest@6e470b3[method=DELETE,uri="https://api.europe-west1.gcp.commercetools.com/project/types/key=test",headers=[{key=Accept-Encoding, value=gzip}, {key=Authorization, value=**removed from output**}, {key=User-Agent, value=commercetools-sdk-java-v2/7.3.0  Java/17.0.2+8-LTS (Windows 10; amd64)}],textInterpretedBody=empty body]
http request: io.vrap.rmf.base.client.ApiHttpRequest@6e470b3[method=DELETE,uri="https://api.europe-west1.gcp.commercetools.com/project/types/key=test",headers=[{key=Accept-Encoding, value=gzip}, {key=Authorization, value=**removed from output**}, {key=User-Agent, value=commercetools-sdk-java-v2/7.3.0  Java/17.0.2+8-LTS (Windows 10; amd64)}],textInterpretedBody=empty body]

	at io.vrap.rmf.base.client.error.HttpExceptionFactory.createClientException(HttpExceptionFactory.java:52)
	at io.vrap.rmf.base.client.error.HttpExceptionFactory.create(HttpExceptionFactory.java:17)
	at io.vrap.rmf.base.client.http.ErrorMiddlewareImpl.lambda$invoke$0(ErrorMiddlewareImpl.java:30)
	at java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:646)
	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)
	at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2147)
	at com.commercetools.http.apachehttp.CompletableFutureCallbackAdapter.completed(CompletableFutureCallbackAdapter.java:22)
	at org.apache.hc.core5.concurrent.BasicFuture.completed(BasicFuture.java:123)
	at org.apache.hc.core5.concurrent.ComplexFuture.completed(ComplexFuture.java:72)
	at org.apache.hc.client5.http.impl.async.InternalAbstractHttpAsyncClient$1$1.completed(InternalAbstractHttpAsyncClient.java:279)
	at org.apache.hc.core5.http.nio.support.AbstractAsyncResponseConsumer$1.completed(AbstractAsyncResponseConsumer.java:101)
	at org.apache.hc.core5.http.nio.entity.AbstractBinAsyncEntityConsumer.completed(AbstractBinAsyncEntityConsumer.java:84)
	at org.apache.hc.core5.http.nio.entity.AbstractBinDataConsumer.streamEnd(AbstractBinDataConsumer.java:81)
	at org.apache.hc.core5.http.nio.support.AbstractAsyncResponseConsumer.streamEnd(AbstractAsyncResponseConsumer.java:142)
	at org.apache.hc.client5.http.impl.async.HttpAsyncMainClientExec$1.streamEnd(HttpAsyncMainClientExec.java:233)
	at org.apache.hc.core5.http2.impl.nio.ClientH2StreamHandler.consumeData(ClientH2StreamHandler.java:239)
	at org.apache.hc.core5.http2.impl.nio.AbstractH2StreamMultiplexer$H2Stream.consumeData(AbstractH2StreamMultiplexer.java:1604)
	at org.apache.hc.core5.http2.impl.nio.AbstractH2StreamMultiplexer.consumeDataFrame(AbstractH2StreamMultiplexer.java:1010)
	at org.apache.hc.core5.http2.impl.nio.AbstractH2StreamMultiplexer.consumeFrame(AbstractH2StreamMultiplexer.java:728)
	at org.apache.hc.core5.http2.impl.nio.AbstractH2StreamMultiplexer.onInput(AbstractH2StreamMultiplexer.java:444)
	at org.apache.hc.core5.http2.impl.nio.AbstractH2IOEventHandler.inputReady(AbstractH2IOEventHandler.java:65)
	at org.apache.hc.core5.http2.impl.nio.ClientH2IOEventHandler.inputReady(ClientH2IOEventHandler.java:39)
	at org.apache.hc.core5.reactor.ssl.SSLIOSession.decryptData(SSLIOSession.java:594)
	at org.apache.hc.core5.reactor.ssl.SSLIOSession.access$200(SSLIOSession.java:73)
	at org.apache.hc.core5.reactor.ssl.SSLIOSession$1.inputReady(SSLIOSession.java:201)
	at org.apache.hc.core5.reactor.InternalDataChannel.onIOEvent(InternalDataChannel.java:140)
	at org.apache.hc.core5.reactor.InternalChannel.handleIOEvent(InternalChannel.java:51)
	at org.apache.hc.core5.reactor.SingleCoreIOReactor.processEvents(SingleCoreIOReactor.java:178)
	at org.apache.hc.core5.reactor.SingleCoreIOReactor.doExecute(SingleCoreIOReactor.java:127)
	at org.apache.hc.core5.reactor.AbstractSingleCoreIOReactor.execute(AbstractSingleCoreIOReactor.java:85)
	at org.apache.hc.core5.reactor.IOReactorWorker.run(IOReactorWorker.java:44)
	at java.base/java.lang.Thread.run(Thread.java:833)

Expected behavior
A way to be able to provide the version or delete the latest version if it's not present.
Since the update call doesn't require a version, maybe delete shouldn't either.
**Stack information

SDK: 7.3.0

Ah, actually I found out how to set the version from a different call 🤦♂
But my comment regarding the possibility for delete to work even without a version still stands

The reason for this is the Optimistic Concurrency Control. Please see https://docs.commercetools.com/api/general-concepts#optimistic-concurrency-control
Cause without a version you and use never know if you want to delete the correct version as it could have been changed in the mean time. Therefor the version is required.

Btw for updates the version is required, but is meant to be sent in the Body. For DELETE the HTTP RFC says that it doesnt have a body. So the version must be sent as a query parameter.

But the same reason should be applied for updates too, without a version how can you make sure that the client doesn't unknowingly overwrites an object that was modified?

As already said the version is part of the Update body:
https://github.com/commercetools/commercetools-sdk-java-v2/blob/0257ba27b676a709f90a778ffbee65d0a0954e64/commercetools/commercetools-sdk-java-api/src/main/java-generated/com/commercetools/api/models/category/CategoryUpdate.java#L30

But I'm not saying that the property is not available or that it cannot be set.
I'm saying that for updates it is optional and the update works even if it is not set, while delete does not work without a version.

The version is mandatory.
https://github.com/commercetools/commercetools-sdk-java-v2/blob/0c88d9276093ecb93edaaf17482bafb8eb35ff1c/commercetools/commercetools-sdk-java-api/src/main/java-generated/com/commercetools/api/models/type/TypeUpdateBuilder.java#L39-L43
Please see also https://docs.commercetools.com/api/projects/types#update-type

This is the output if trying to update without a version set.
08:44:59.897 [httpclient-dispatch-2] DEBUG commercetools.types.response - io.vrap.rmf.base.client.ApiHttpResponse@3d6124b3[statusCode=400,headers=[{key=date, value=Fri, 21 Jan 2022 07:44:59 GMT}, {key=content-length, value=222}, {key=server, value=istio-envoy}, {key=x-envoy-upstream-service-time, value=4}, {key=access-control-allow-headers, value=Accept, Authorization, Content-Type, Origin, User-Agent, X-Correlation-ID}, {key=x-correlation-id, value=projects-7f44e36f-55f4-47b9-91df-0d2323747858}, {key=access-control-allow-methods, value=GET, POST, DELETE, OPTIONS}, {key=via, value=1.1 google}, {key=access-control-expose-headers, value=X-Correlation-ID}, {key=access-control-allow-origin, value=*}, {key=x-http-status-caused-by-external-upstream, value=false}, {key=access-control-max-age, value=299}, {key=content-type, value=application/json; charset=utf-8}, {key=server-timing, value=projects;dur=3}, {key=alt-svc, value=clear}],textInterpretedBody={"statusCode":400,"message":"Request body does not contain valid JSON.","errors":[{"code":"InvalidJsonInput","message":"Request body does not contain valid JSON.","detailedErrorMessage":"version: Missing required value"}]}]
java.util.concurrent.CompletionException: io.vrap.rmf.base.client.error.BadRequestException: detailMessage: Client error response [url] https://api.europe-west1.gcp.commercetools.com/test-php-dev-integration-1/types/c492c0f3-d297-4312-b422-0cc33f86bd2a [status code] 400 [reason phrase] Bad Request
summary: POST https://api.europe-west1.gcp.commercetools.com/test-php-dev-integration-1/types/c492c0f3-d297-4312-b422-0cc33f86bd2a failed  with response code 400 with X-Correlation-ID `{key=x-correlation-id, value=projects-7f44e36f-55f4-47b9-91df-0d2323747858}` on 2022-01-21T07:44:59.871132Z
http response formatted body: {
  "statusCode" : 400,
  "message" : "Request body does not contain valid JSON.",
  "errors" : [ {
    "code" : "InvalidJsonInput",
    "message" : "Request body does not contain valid JSON.",
    "detailedErrorMessage" : "version: Missing required value"
  } ]
}
http response: io.vrap.rmf.base.client.ApiHttpResponse@3d6124b3[statusCode=400,headers=[{key=date, value=Fri, 21 Jan 2022 07:44:59 GMT}, {key=content-length, value=222}, {key=server, value=istio-envoy}, {key=x-envoy-upstream-service-time, value=4}, {key=access-control-allow-headers, value=Accept, Authorization, Content-Type, Origin, User-Agent, X-Correlation-ID}, {key=x-correlation-id, value=projects-7f44e36f-55f4-47b9-91df-0d2323747858}, {key=access-control-allow-methods, value=GET, POST, DELETE, OPTIONS}, {key=via, value=1.1 google}, {key=access-control-expose-headers, value=X-Correlation-ID}, {key=access-control-allow-origin, value=*}, {key=x-http-status-caused-by-external-upstream, value=false}, {key=access-control-max-age, value=299}, {key=content-type, value=application/json; charset=utf-8}, {key=server-timing, value=projects;dur=3}, {key=alt-svc, value=clear}],textInterpretedBody={"statusCode":400,"message":"Request body does not contain valid JSON.","errors":[{"code":"InvalidJsonInput","message":"Request body does not contain valid JSON.","detailedErrorMessage":"version: Missing required value"}]}]
SDK: 7.4.0-SNAPSHOT
endpoint: POST https://api.europe-west1.gcp.commercetools.com/test-php-dev-integration-1/types/c492c0f3-d297-4312-b422-0cc33f86bd2a
Java: 15.0.2
cwd: /Users/jensschulze/workspace/commercetools-java-sdks/commercetools/commercetools-sdk-java-api
request: io.vrap.rmf.base.client.ApiHttpRequest@1990d74b[method=POST,uri="https://api.europe-west1.gcp.commercetools.com/test-php-dev-integration-1/types/c492c0f3-d297-4312-b422-0cc33f86bd2a",headers=[{key=Accept-Encoding, value=gzip}, {key=Authorization, value=**removed from output**}, {key=User-Agent, value=commercetools-sdk-java-v2/7.4.0-SNAPSHOT  Java/15.0.2+7 (Mac OS X; x86_64)}],textInterpretedBody={"actions":[{"key":"random-key-12354d9d-260d-4e0e-9e30-6eb455f27080","action":"changeKey"}]}]
http request: io.vrap.rmf.base.client.ApiHttpRequest@1990d74b[method=POST,uri="https://api.europe-west1.gcp.commercetools.com/test-php-dev-integration-1/types/c492c0f3-d297-4312-b422-0cc33f86bd2a",headers=[{key=Accept-Encoding, value=gzip}, {key=Authorization, value=**removed from output**}, {key=User-Agent, value=commercetools-sdk-java-v2/7.4.0-SNAPSHOT  Java/15.0.2+7 (Mac OS X; x86_64)}],textInterpretedBody={"actions":[{"key":"random-key-12354d9d-260d-4e0e-9e30-6eb455f27080","action":"changeKey"}]}]
http request formatted body: {
  "actions" : [ {
    "key" : "random-key-12354d9d-260d-4e0e-9e30-6eb455f27080",
    "action" : "changeKey"
  } ]
}

The only exception to this is the custom objects endpoint as it allows upsert operations and the version is optional.
https://docs.commercetools.com/api/projects/custom-objects#create-or-update-a-customobject

Hmm,
I did a test earlier and it's not, at least not in all cases:
INFO : Saved brand: Brand(id=b64234b0-0a2f-4d69-a67b-4bb22fe79a2f, code=apple, name=Apple, assets=[com.commercetools.api.models.common.AssetDraftImpl@97b7e33b], approved=false)
INFO : POST https://api.europe-west1.gcp.commercetools.com/project/custom-objects 200
INFO : Saved brand: Brand(id=b64234b0-0a2f-4d69-a67b-4bb22fe79a2f, code=apple, name=Applex, assets=[com.commercetools.api.models.common.AssetDraftImpl@97b7e33b], approved=false)
INFO : GET https://api.europe-west1.gcp.commercetools.com/project/custom-objects/brands 200
INFO : id=b64234b0-0a2f-4d69-a67b-4bb22fe79a2f, container=brands, key=apple, object=Brand(id=null, code=apple, name=Applex, assets=[com.commercetools.api.models.common.AssetDraftImpl@97b7e33b], approved=false), version=2

So doing a 2nd POST on a custom object with the same key and without a version updates the object and increases the version automatically.

Got it now, as I said, the custom objects exception from the rule got me confused, sorry for all the noise 🙂

If you take a look at the URL. You are POSTing to the /custom-objects endpoint which is for all other types the Create endpoint. Other resources use e.g. POST /types/{id}


Move samples to standalone repo

Remove tomcat, webserver, mysql operator samples to standalone repo
https://github.com/java-operator-sdk/samples

LGTM


Add excluding "enterpriseregistration.windows.net"

We have found changing computer name of Entra Hybrid Joined device fails when there is TLS inspect proxy server for "enterpriseregistration.windows.net". We also found this document. https://learn.microsoft.com/en-us/entra/identity/enterprise-apps/tenant-restrictions#configuration

@MicrosoftGuyJFlo
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Draggability broken in Dashboard demo

Seems that the draggability feature is broken on the demo page: https://rawgit.com/ManifestWebDesign/angular-gridster/master/index.html#/dashboard. Main demo works okay.

I seem to have the same issue in my app when I use master. Commit https://github.com/ManifestWebDesign/angular-gridster/commit/425ef5286d5e3560b6f4444bab661630dd26c86e breaks the functionality for me. The commit before it works okay. @twolff-iow, any idea what could cause this?

This is fixed on the latest master.  I will make a new release soon.


Concerning the LPID rule book

To be added in the rule book: The two attributes of the LPID are atomic, that means they are always presented together as a unit.

This is written in https://github.com/EWC-consortium/eudi-wallet-rfcs/blob/97cb5d043eead6c00575873a7a703bfc9e19ea51/ewc-rfc005-issue-legal-person-identification-data.md to which the rulebook refers.


⚠ Samsung has degraded performance

In 18faf5c, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2510 ms

Resolved: Samsung performance has improved in a870f7f.


Jumbotron border-radius

I've been using the Jumbotron component in Bootstrap 4 (https://getbootstrap.com/docs/4.1/components/jumbotron/) as a full-width banner like section with a background colour/image. The issue I've noticed, is for some reason it comes with .3rem of border-radius... just wondering why, and whether this can be removed?
.jumbotron {
    padding: 2rem 1rem;
    margin-bottom: 2rem;
    background-color: #e9ecef;
    border-radius: .3rem;
}

.jumbotron-fluid exists to accomplish the full-width banner you're referring to. Regular jumbotron is for use within a fixed-width parent.


Install react with CRA

The things that I did in this PR:

Create a new React app called 'hello-react-front-end'
Initialize your project with Git.
Create the App component with react-router.
Create the Greeting component that will display a greeting. Set it up as a route in your App component.
Create a store, an action, and a reducer that will connect to the API endpoint to get the random greeting.
Display the random greeting in your Greeting component.

Invalid Code Review Request ❌
Hi @M-AminAlizadeh ,
While you made a great effort in this project, I cannot proceed to review your code.
You have submitted a project, that doesn't have a summary in the description. Pull Request should have a summary describing the introduced changes in more detail.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

STATUS: APPROVED 👍🎯
Hello @M-AminAlizadeh 👋
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights ⭐
✔action called to get API message
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


TSDM Presentation to CIOEC

Putting this back in backlog.
Issue #1437 needs to be completed first as it will inform the content of the CIOEC deck, and most likely some changes in the TSDM strategy's architecture section (i.e. relationship between data and software)

Putting this back in backlog.
Issue #1437 needs to be completed first as it will inform the content of the CIOEC deck, and most likely some changes in the TSDM strategy's architecture section (i.e. relationship between data and software)

renamed to presentation to DGCOMM

This presentation will most likely change to one that asks for two things:

Inform of the DevOps CoE creation and its ongoing work with other IITB teams (lead by IITB Innovation Team)
Inform of work on a Business Case for a Product Management Framework (lead by IT Strategy)

This would scrap the idea of a "Agile Governance Framework" in favour of just a Product Management one. Product teams are free to chose which governance framework they want as long as it aligns to the Product Management's expectations.


Hotfix/search gke

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
This PR should fix #16379
The first content and container are deployed on the master node, then we only need to deploy n-1 replicas. I checked output config files they look correct, did not had time to try it yet.
Also add the link to security link as mentioned by @kkraune

and thanks for linking the security doc!


ImageDream MVDream?

Hi,
I came across this project https://image-dream.github.io/test_1.html which released by part of the team who created MVDream.
But its paper link point to MVDream. They are not the same project right, since ImageDream is a diffusion model that use image input as prompt

yes we are working on the paper code releasing since it is under patent
process
thanks for the interest
On Sun, Nov 12, 2023, 4:36 PM 俞航 @.***> wrote:

Hi,
I came across this project https://image-dream.github.io/test_1.html
which released by part of the team who created MVDream.
But its paper link point to MVDream. They are not the same project right,
since ImageDream is a diffusion model that use image input as prompt
—
Reply to this email directly, view it on GitHub
https://github.com/bytedance/MVDream/issues/28, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABETY5F55L7SF74KZK4OZILYED3HNAVCNFSM6AAAAAA7IDZR7SVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4DSNBYGAZTOOA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Ferries ToDo List

[x] create new deck (7 cards with 4 states and 1 card with 7 states)
[x] create tile_data
[x] replace old ferries deck
[x] automate setup

from the rules:

[x] after tile and follower placement, check if the new tile has a lake

[x] if so, ask the player where the ferry has to go
[x] automatically put the ferry

[x] then, check if the new tile extended a road attached to a lake

[x] find the closest lake(s)
[x] allow the current player to change the state of the closest affected lake tile(s)

[x] check for completed features to score as always

@DinnerBuffet I've been messing around on my fork of the mod
Now the deck should be complete, I had to add an extra state for the empty tile (with no ferry)
because step 2 of the rules requires you to put down a follower before choosing a ferry, which means we need a way to put followers on the empty tile before connecting the roads.
I've also included the new save with the deck in the ferries sachel and automated the setup process.
Next steps will require me to learn a bit more about TTS API.
I pinged you just to keep you up-to-date, I know you are busy so I don't expect you to do anything.

Cool, this is great progress! I can't think of anything missing from that checklist. I should get the chance this weekend to give some advice on which parts of the code need to be changed, but again busy :)

I should get the chance this weekend to give some advice on which parts of the code need to be changed, but again busy :)

Don't worry, real life comes first and I might get busy as well very soon.

from the rules:

There's a good reference for this in the Carcassonne Annotated Rules (CAR) called "Order of Play" on page 207. I tried to use this loosely as the basis for the stateMachine (which, by the way, isn't a true "state machine" since there is some additional state information stored separately, such as hasAlreadyTakenBuilderTile).

[ ]  whenever the state of a lake tile is changed

[ ]  if so, revert the change if the player does not have permission

Like I previously said, I think the only way to do this would be to listen for an  onObjectSpawn() event. You could then check if the object is a tile and also check if it has a Lake special feature to be double sure. As for restoring the original state, I'm not too sure.

[ ]  after tile and (optional) follower placement, check if the new tile has a lake

[ ]  if so, allow the current player to change the state of the current lake tile
[ ]  check that the state is valid (state 1 is not valid)

Add another state between 'check added tile features' and 'check added tile special figure extension' called 'check added tile feature - lake' to check if the tile added has a lake: https://github.com/DinnerBuffet/TTSCarcassonne/blob/master/scripts/state_machine.ttslua#L23
Add handling for that state similar to this: https://github.com/DinnerBuffet/TTSCarcassonne/blob/master/scripts/state_machine.ttslua#L276
If the tile doesn't have a Lake you can just call nextState('next'). If the tile has a Lake you'll want to create a prompt to confirm the object state. The function will look similar to other functions for checking if a feature is present on a tile. Pressing the confirm button should call removeTile and addTile, then nextState('next')

[ ]  then, check if the new tile extended a road attached to a lake

[ ]  if so, allow the current player to change the state of the closest affected lake tile
[ ]  check that the state is valid (state 1 is not valid)

I gave this a bit more thought and I think you need to store additional information in the featureList about the location of the ferry, like the following:
https://github.com/DinnerBuffet/TTSCarcassonne/blob/master/scripts/feature_map_management.ttslua#L331
Little bit of background, in an effort to make adding and removing tiles as efficient as possible (in order to make the AI quicker), I stored all of the necessary data in the featureList. By only storing the basic necessary information, AI calculations could be done super quick. For example, the only information stored about a road is numTiles, numOpenings, and a list of features associated with it (ie. Inns). When a tile is added to this road, we can simply increase the tiles to numTiles + 1 and the openings to numOpenings - 1 + number of openings on the road in the new tile. If the number of openings gets to 0, we know the road finished and we can score it for numTiles points. The featureMap then keeps a simple map to where each of these features is. I have a debugging tool that I use to view the featureList/featureMap data. I will try to add it to the workshop later, which should help.
This system of storing basic metadata worked so well that I eventually decided to use this method to replace my original tile traversal method for non-AI calculations as well. For some special cases, though, we need to know on which tile a feature exists (ie. cloisters). That is why the featureLocation property exists on some features.
Unfortunately, featureLocation is a property of the feature, which is in this case the feature is the road, and the ferry is a specialFeature of that road. Since the road could potentially have multiple ferries, I think it makes more sense for each ferry to be it's own feature in the featureList, and then to link them to the road. Currently the only way to link separate features together is with linkedSpecialFeatures (should really be called linkedFeatures I think), which I will get to in a bit...

so...
I am abandoning the idea of using states, they are causing a lot of problems and it's probably not worth the work
I have been toying around with a new idea.
instead of storing the "linkedQuadrants" table in the tile itself, I am trying to store in a general table
this way, the lake tiles start off with no connections, and then I prompt the player to choose which 2 streets to connect (I will probably use a button for that)
the "linkedQuadrants" table will be stored in the general table and we can use the card's own guid to retrieve it
for now I managed to replace the loading by defining a new function:
function getLinkedQuadrants(tile)
    local t = FERRIESEXPANSION_LINKEDQUADRANTS[tile.guid]
    if t ~= nil then
        return t
    end
    return tile.getTable('linkedQuadrants')
end

and using this function here and here
links = tile.getTable('linkedQuadrants')
becomes
links = getLinkedQuadrants(tile)

What you could do is link the roads together with linkedSpecialFeatures similar to Road Intersection. This way the roads could remain separate, and changing the ferries would only really need to change the linkedSpecialFeatures. However, it would require a lot of other special handling such as the scoring, so using the hack you proposed to make the roads the same feature in addTile might be easier in the long-run. You might still need to keep a linkedSpecialFeature to tie the roads to the lakes, though.
If you get confused it's probably not your fault. The code is a bit of a hacky mess. Again, I'm sorry that I can't be more help right now. I'm getting married this week and I'm crazy busy.

If you get confused it's probably not your fault. The code is a bit of a hacky mess. Again, I'm sorry that I can't be more help right now. I'm getting married this week and I'm crazy busy.

ok, as far as my tests go I think I got it to work
here's a short video I made:

it still needs some polish (chat messages and stuff like that) but all the mechanics are there

That looks great! Well done! How did you end up coding everything? Today I will make some time to upload the debugger tool, which should help you figure out any odd issues.

Here it is: https://steamcommunity.com/sharedfiles/filedetails/?id=1760133638
Hope you find this helpful. Hopefully I should find time soon to be of more help.

That looks great! Well done! How did you end up coding everything?

I've added some new states to the state machine
I've written a function that generates some buttons over the lake tile to place or move the ferry, and also a function that  looks for the nearest lake whenever you extend a street
whenever a ferry needs to be moved, I just remove the tile and replace it on the same spot (idk if that's bad, it doesn't seem to do any damage)
and to keep track of which street connects to what I wrote a bypass function to provide the linkedQuadrants from a separate table

That looks great! Well done! How did you end up coding everything?

I've added some new states to the state machine
I've written a function that generates some buttons over the lake tile to place or move the ferry, and also a function that looks for the nearest lake whenever you extend a street

From my quick check I don't see any major issues with the way it was coded. Great work! You'll want to double-check that special tiles such as '676a91' from Abbey & Mayor, '094980' from Traders & Builders, and '6a7647' from Inns & Cathedrals don't break it. I think that they should work, though.

whenever a ferry needs to be moved, I just remove the tile and replace it on the same spot (idk if that's bad, it doesn't seem to do any damage)

For these circumstances it is perfectly fine. If you needed to do it hundreds of times per move (ie. AI calculations) then it wouldn't be ideal, but I don't think a very complicated AI for this expansion should be the first thing on the todo list.

and to keep track of which street connects to what I wrote a bypass function to provide the linkedQuadrants from a separate table

Normally I try to avoid any specialized data embedded in the tiles whenever I can, since changing it later can be a nuisance. As long as it doesn't break what's already in the mod I'm fine with the hack.
I noticed that you sent a pull request. Once again I am busy so it will take me sometime before I'll be able to go over it in detail. Please don't take this as a sign that your work isn't appreciated because it certainly is!

If I sent a pull request it was by mistake.
I don't think this is ready to be merged yet
Don't worry about that, I will close it

I checked and there are no pull requests on your repo
You probably got confused with the PR I push on the master branch of my fork
I do that everytime I finish adding a big feature so that I can work on my "development" branch without worrying to mess up too much

Yup I think you were right.
How are things? My availability is opening up and I can help implement/give advice if needed.

How are things? My availability is opening up and I can help implement/give advice if needed.

I have been on pause for a couple of weeks because I was a bit busy.
The changes are mostly finished, all mechanics work as far as I could test.
I would like to improve a bit the notifications when a ferry event is triggered, and I would like to make sure the scoring features work fine.
I had some issues with scoring but I discovered that's a bug present in the base mod as well so I don't think it was triggered by my changes. (when you go back in time ctrl-z sometimes you end up breaking the scoring at the end) I also got a NRE after clicking on the score summary button but I wasn't able to understand if it was an issue with the base mod or with my modification

How are things? My availability is opening up and I can help implement/give advice if needed.

I have been on pause for a couple of weeks because I was a bit busy.
The changes are mostly finished, all mechanics work as far as I could test.
I would like to improve a bit the notifications when a ferry event is triggered, and I would like to make sure the scoring features work fine.
I had some issues with scoring but I discovered that's a bug present in the base mod as well so I don't think it was triggered by my changes. (when you go back in time ctrl-z sometimes you end up breaking the scoring at the end) I also got a NRE after clicking on the score summary button but I wasn't able to understand if it was an issue with the base mod or with my modification

Sorry about that. I broke it in 1.21.11 and fixed it in 1.21.13 (https://github.com/DinnerBuffet/TTSCarcassonne/commit/7a04fb670a7f2e0564d6ce57b2e1fadf305f8a7f)
I'll try out your changes soon and see if I can break it.
One thing I want to point out is that versioning the JSON file didn't seem to work well at all. The commit was a mess and included micro-changes in the positions of objects that weren't even touched. Merging probably won't work well. I'm fairly sure that I haven't made any recent non-code changes. If you had, you can simply use your JSON.

EDIT:
hope everything is fine with you :D

Things are great, thanks!

One thing I want to point out is that versioning the JSON file didn't seem to work well at all. The commit was a mess and included micro-changes in the positions of objects that weren't even touched. Merging probably won't work well. I'm fairly sure that I haven't made any recent non-code changes. If you had, you can simply use your JSON.

every time I push to the file I tried to make sure that only meaningfull changes were included, but some indenting change might have get into it, I would have to check

One thing I want to point out is that versioning the JSON file didn't seem to work well at all. The commit was a mess and included micro-changes in the positions of objects that weren't even touched. Merging probably won't work well. I'm fairly sure that I haven't made any recent non-code changes. If you had, you can simply use your JSON.

every time I push to the file I tried to make sure that only meaningfull changes were included, but some indenting change might have get into it, I would have to check

I didn't put any such effort into my changes. Sorry :)

Hey! I've been pretty busy myself so don't worry...
Can you describe the bug(s) you found?
The bug I found happens when using the "undo" option. After using "undo" even just once during the fame, at the "end game/score points" step the game returns an error. I havent managed to pinpoint that one yet

sure I'll have to fix a couple of changes and then I will send you a pull request that should have only the meaningful changes

Hi there, I finally put some time into this and have what I consider to be a finished version. I manually squashed and merged the code over my main branch (not yet pushed), leaving out a bunch of the white-space changes that were done (not that I don't agree with them, I just want to keep the commit concise to these changes without too much refactoring). In addition to some general cleanup, I changed the following things:

removed activeTiles, since it wasn't necessary to store this information in the save file.
changed ferry buttons and labels to use createNormalizedArbitraryButton. This is for two reasons:

I like to have all buttons rotate towards the seated position of the player, so that no player is forced to rotate their camera to read the buttons.
Buttons attached to objects share that object's scale. Because TTS cards need to be warped to be a square tile, this makes the buttons warped. Using createNormalizedArbitraryButton attaches them to a hidden object with a fixed scale.

Is there anything else you intended to fix up before I upload this? How do you prefer to be credited? Is Sigma88 fine? Also, can you give me a link to your steam profile so that I can add you as an author?
Thanks again for the contribution!

hi there, sorry for disappearing but RL got in the way 🤣
I'll reply to your questions as much as I can:

Hi there, I finally put some time into this and have what I consider to be a finished version. I manually squashed and merged the code over my main branch (not yet pushed), leaving out a bunch of the white-space changes that were done (not that I don't agree with them, I just want to keep the commit concise to these changes without too much refactoring).

most whitespace changes were probably introduced by my text editor, I have no objection to them being reverted, however there are a couple of spaces that I changed in the list of expansions checkboxes to make all of them consistent, some had a space between the number and the dot, some didn't have that space. so you might want to check those to see if the inconsistencies are still there

In addition to some general cleanup, I changed the following things:

removed activeTiles, since it wasn't necessary to store this information in the save file.

I don't really remember why I added those, however I think it's probably because of a lack in understanding of how the mod works, if everything is fine without them it makes it cleaner to remove them

changed ferry buttons and labels to use createNormalizedArbitraryButton. This is for two reasons:

I like to have all buttons rotate towards the seated position of the player, so that no player is forced to rotate their camera to read the buttons.
Buttons attached to objects share that object's scale. Because TTS cards need to be warped to be a square tile, this makes the buttons warped. Using createNormalizedArbitraryButton attaches them to a hidden object with a fixed scale.

again, probably a result of my lack of knowledge, I just tried to get the mod to work and didn't really care about the aestetics, I'm glad you found a more pleasing solution

Is there anything else you intended to fix up before I upload this?

Playing with the base version of the mod, I sometimes wish there was a confirmation button after placing a tile or a follower. I don't know how hard this would be to implement, but it would save a lot of grief from dropping followers on the wrong spot and get credited with an empty field rather than a street or city. This issue is most common with followers but occasionally it happened that I dropped a tile and immediately regretted it. So this might be an idea for a future development.

How do you prefer to be credited? Is Sigma88 fine? Also, can you give me a link to your steam profile so that I can add you as an author?
Thanks again for the contribution!

I don't really care about getting credit for the few changes I made, expecially since you had to go through much of the code and fix it yourself. If you want to credit me as "Sigma88" it is fine but it's up to you really.
Thanks for developing this mod, it's definitely the one I use the most with TTS

most whitespace changes were probably introduced by my text editor, I have no objection to them being reverted, however there are a couple of spaces that I changed in the list of expansions checkboxes to make all of them consistent, some had a space between the number and the dot, some didn't have that space. so you might want to check those to see if the inconsistencies are still there

You must mean this? https://github.com/Sigma88/TTSCarcassonne/commit/1bc71a94c7e91176829dd25b5c793acd3d4934cf
If so you're right, I hadn't noticed. I appreciate your attention to detail :) Is there anything else that wasn't obvious? I pushed the mostly-unchanged ported code here: https://github.com/DinnerBuffet/TTSCarcassonne/commit/100f654c63c128848348546a80b5148cde7a6324
I will push my changes once they are final.

I don't really remember why I added those, however I think it's probably because of a lack in understanding of how the mod works, if everything is fine without them it makes it cleaner to remove them

My general rule is that is that if any information could be lost by saving/loading during a timer delay, coroutine sleep, or while waiting for user input, then that data must be saved. In this case, the data saved in activeTiles (x + y of the tile) is available after the user pushes the button, so it can be stored in a global to be used by the button callback.

again, probably a result of my lack of knowledge, I just tried to get the mod to work and didn't really care about the aestetics, I'm glad you found a more pleasing solution

It probably didn't help that I misused the word "normalized". I'm still not entirely sure what I meant by that...

Playing with the base version of the mod, I sometimes wish there was a confirmation button after placing a tile or a follower. I don't know how hard this would be to implement, but it would save a lot of grief from dropping followers on the wrong spot and get credited with an empty field rather than a street or city. This issue is most common with followers but occasionally it happened that I dropped a tile and immediately regretted it. So this might be an idea for a future development.

I don't advertise this well, but anytime during a turn, the tile that was placed can be unlocked and lifted to reset the turn back to the tile placement phase. As for placed followers, their positions are evaluated real-time, so players always have the option to pick them up and move them to where they intended after the fact. Here it's arguable, though, to have a confirmation in case points are scored by misplacing it, but you can always subtract the points that were scored using the score counters. I prefer to keep the flow moving forward and I try to make a long enough delay so that players can pick the tile/follower up again if they misplace it.

I don't really care about getting credit for the few changes I made, expecially since you had to go through much of the code and fix it yourself. If you want to credit me as "Sigma88" it is fine but it's up to you really.

You absolutely deserve credit. Not only did you have to learn all of the silly nuances of my code, but this was a non-trivial change and you wrote all of the code without any real help. There's a reason you're the only contributor in the years that this mod has been in development. Kudos to you for sure!

You must mean this? 1bc71a9
yes 👍

Is there anything else that wasn't obvious?
difficult to tell, I found some issues in the rivers II tiles: one of them is missing a "shield" (or whatever it's called) from a city
there might be other stuff, but honestly I don't remember right now, if I come across some more issues I will make sure to post them on your repo :)

everything else looks good to me

difficult to tell, I found some issues in the rivers II tiles: one of them is missing a "shield" (or whatever it's called) from a city

Wow you're right! I rarely find tile data issues anymore. Kudos!
I'll upload a new revision to the workshop. Thanks again for the help!

Congrats on the release
Closing this issue since the changes have been included in the latest release
:tada:


NSFS | NC | Add Schema Validation to Bucket and Account Add and Update

Explain the changes

Move the NC NSFS schema validation that we had in file src/sdk/bucketspace_fs.js (from PR #7544) to a separate file (src/server/utils/nsfs_schema_utils.js) to reuse it.
Change the schema of s3_policy in NC NSFS to have the option to be empty ''.
Change the schema of fs_backend in common_api to have the option to be empty ''.
Validate the data using helper functions:
extract_properties_from_account_data_and_validate_schema for account add or update
extract_properties_from_bucket_data_and_validate_schema for bucket add or update.

Issues: Fixed #7694

Add schema validation to bucket and account add and update - using NC NSFS CLI.

Testing Instructions:

I updated the schema according to the needs we have, it was reflected in the test that you can run:
sudo node --allow-natives-syntax ./node_modules/.bin/_mocha src/test/unit_tests/test_nc_nsfs_cli.js

[ ] Doc added/updated
[ ] Tests added

Manual Testing Instructions:
Schema validation for buckets and accounts
First, create the FS_ROOT and give permissions:
mkdir -p /tmp/nsfs_root1
chmod 777 /tmp/nsfs_root1

This will be the argument for:

new_buckets_path flag that we will use in the account commands
path in the buckets commands.

In each case the commands work, hence we added the code change (to sabotage the created object and make sure that it creates an error, in each case we chose one of the properties that is required to be deleted.
Account add

Add account sudo node src/cmd/manage_nsfs account add --name <account-name> --email <account-email> --new_buckets_path /tmp/nsfs_root1 --uid <uid-number> --gid <gid-number>
Add this line:
delete data.email; // test
before passing to the schema validation.
See the error: RpcError: must have required property 'email'

Account update

Create an account (the account that we would update).
Update account sudo node src/cmd/manage_nsfs account update --name <account-name> --email <change-the-account-email>
Add this line (in the first condition - it's neither a name update nor access keys update):
delete data_without_properties_to_update.email; // test
before passing to the schema validation.
See the error: RpcError: must have required property 'email'

Bucket add

Create an account (the account that we would create the bucket for it).
Add bucket sudo node src/cmd/manage_nsfs bucket add --name <bucket-name> --email <account-email> --path /tmp/nsfs_root1
Add this line:
delete data.creation_date; // test
before passing to the schema validation.
See the error: RpcError: must have required property 'creation_date'

Bucket update

Create a bucket (the bucket that we would update).
Update bucket sudo node src/cmd/manage_nsfs account update --name <account-name> --email <change-the-account-email>
Add this line (in the first condition - it's not a name update):
delete data_without_properties_to_update.creation_date; // test
before passing to the schema validation.
See the error: RpcError: must have required property 'creation_date'

Remove bucket policy and fs_backend:
First, Create bucket sudo node src/cmd/manage_nsfs bucket add --name <bucket-name> --email <account-email> --path /tmp/nsfs_root1 In the next commands please use the same <bucket-name> as you created here.


Docker Integration

This integration step brings together to use cases for sensorml2iso. The first use case is wrapping the command line interface for sensorml2iso in a docker container so that users can pull, run and integrate sensorml2iso through docker.
docker run -v $HOME/Desktop/WAF:/srv/iso --name test -it --rm ioos/sensorml2iso -s http://sos.glos.us/52n/sos/kvp --output_dir /srv/iso/glos

The second use case which I needed for IOOS Catalog was deploying the project as a service that would occasionally run and update a WAF. It's less of a service and more of a cron job.
Originally my approach was to use baseimage and setup a cron job but @benjwadams pointed out that it's overkill and the image was 700MiB compressed. @daf pointed out that there was a much better approach if we used ENTRYPOINT so that we can support both simultaneously.
This approach was much better in that it was consistent with the first use case, and the image was considerably smaller.
It would be good for @shane-axiom and @daf to make sure that this change doesn't break any workflow they already have.

Also, wouldn't you want to be able to run sensorml2iso as if it were a command line tool via docker, not just use it in a scheduled manner?

You can run it as a command line tool, if you pass in any arguments the entry point runs the command line tool instead of the cron daemon. The config is meant to serve as an example, and it just so happens the default is handy for where we have it deployed for the IOOS catalog.

Ah, I've re-read the README and see what you mean. Thanks.


refactor: Extract discovery of rule violations from SoraldAbstractRepair

This is step 1 of the targeted repair implementation (#225).
This refactor extracts the discovery of rule violations from the SoraldAbstractRepair class and pulls it up to an earlier level of the execution. It makes it much easier to replace the rule violations with something constructed from violation IDs for the targeted repair. See further comments in the code.

Thanks for the refactoring!


Update CODE_OF_CONDUCT.md

As stated in the above article e-mail is British English and now most of them are using closed compound so I have changed e-mail to email

closes #4887
What does this PR do?
Changed e-mail to email
Description of the task to be completed?
How can this be manually tested?
Any background context you want to provide?
Is there any relevant issue to this PR?
Screenshots (if appropriate)
Questions

working on #8073


JS Pre-release script to update version, create PR, populate Release DevOps

Please reach out to @kurtzeborn and @weshaggard for more details

Now tracked by https://github.com/Azure/azure-sdk-tools/issues/1241


Color Control Feedback

I wanted to get peoples thoughts.
From a yoto API standpoint from what I know:

You can set any color on the v3 player. Not just the few in app.  I can pass RGB to it and it works.
The API never reports the color displayed. So when I set the above I can't later confirm it. If changed via app I wouldn't know.
I can however see and set the day and night configuration.   When this changes it resets the above RGB value based on if it is daytime or nighttime.

So my question is how should I expose these controls?

A Light entity that lets you pick the current color.  It would have to assume it worked and wouldn't update.
A night and day light entity that just lets you pick the support color list.
A service call that can set any color plus a light entity for day and night?

A combo of the above?
Struggling with this since I don't get values back on what color is shown so will make the interface less responsive than I would like.  I can however see "night light mode" which is a value that I don't understand.  It is displayed today.

With option 2, if one was to change the value of the entity for the night version whilst that mode is active, would it immediately change the colour of the light?

Yes, those would the same as what's exposed in the native app.

I like the idea of being able to choose any color. Always annoyed me that the Yoto app only give you a few options and you also can’t changed them throughout the day. Would be great to use as a notification system or even sync to change the color with certain cards or even tracks.

Color control for day night now is complete.   It works for any color as well, the native app doesn't like when you set one not in the list, just shows off.   It works though.
Two things I could add.

A drop down list for day / night with the list of native colors.
A service item to change the current color without changing day night.  Would work for temp override.  The APIs exist for this.


Optimize more kinds of copies

Currently, we understand and optimize a few kinds of copies by expressing the copy as a buffer metadata manipulation like setting the stride. This is supported by this helper: https://github.com/dsharlet/slinky/blob/81bd036e32ff5e725136bcb65e5cba0a5cdfcc80/builder/optimizations.cc#L34
To be more specific, the copies we support now are of the form:

broadcasts: f(x) = g(C) where C is not a function of x.
copies: f(x) = g(x + C)

We could support additional kinds of copies, like:

downsamples: f(x) = g(x * C), by multiplying the stride by C. Interestingly, we can't support upsamples, because dividing the stride is not right.
"modular broadcasting": f(x) = g(x % C), we can only do this if we know that g doesn't already have a fold factor, so we can set the fold factor to C.

#343 seems to be stalled until fold factor + loop split issue is fixed


Problems installing under Windows 7

I've tried installing VS and various net frameworks, playing with the system path - nothing.... Urg.
Note that this log is from a fork, but I get the same problem with this repo. Am I doing something wrong? Anyone got an idea?
MSBUILD : error MSB3428: Could not load the Visual C++ component "VCBuild.exe". To fix this, 1) install the .NET Framework 2.0 SDK, 2) install Microsoft Visual Studio 2005 or 3) add the location of the component to the system path if it is installed elsewhere.
...
380 silly lifecycle<EMAIL_ADDRESS>Args: [ '/d /s /c', 'node-gyp configure build' ]
381 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
382 info lifecycle<EMAIL_ADDRESS>Failed to exec install script
383 verbose unlock done using C:\Users\...\AppData\Roaming\npm-cache\_locks\staging-376f116635f8d794.lock for C:\Users\...\node_modules\.staging
384 silly rollbackFailedOptional Starting
385 silly rollbackFailedOptional Finishing
386 silly runTopLevelLifecycles Finishing
387 silly install printInstalled
388 verbose stack Error<EMAIL_ADDRESS>install: `node-gyp configure build`
388 verbose stack Exit status 1
388 verbose stack     at EventEmitter.<anonymous> (C:\Program Files\nodejs\node_modules\npm\lib\utils\lifecycle.js:255:16)
388 verbose stack     at emitTwo (events.js:106:13)
388 verbose stack     at EventEmitter.emit (events.js:191:7)
388 verbose stack     at ChildProcess.<anonymous> (C:\Program Files\nodejs\node_modules\npm\lib\utils\spawn.js:40:14)
388 verbose stack     at emitTwo (events.js:106:13)
388 verbose stack     at ChildProcess.emit (events.js:191:7)
388 verbose stack     at maybeClose (internal/child_process.js:886:16)
388 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
389 verbose pkgid<EMAIL_ADDRESS>390 verbose cwd ...
391 error Windows_NT 6.1.7601
392 error argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install" "--save" "fast-ratelimit"
393 error node v6.10.3
394 error npm  v3.10.10
395 error code ELIFECYCLE
396 error<EMAIL_ADDRESS>install: `node-gyp configure build`
396 error Exit status 1
397 error Failed at the<EMAIL_ADDRESS>install script 'node-gyp configure build'.
397 error Make sure you have the latest version of node.js and npm installed.
397 error If you do, this is most likely a problem with the hashtable-patch-valeriansaliou package,
397 error not with npm itself.
397 error Tell the author that this fails on your system:
397 error     node-gyp configure build
397 error You can get information on how to open an issue for this project with:
397 error     npm bugs hashtable-patch-valeriansaliou
397 error Or if that isn't available, you can get their info via:
397 error     npm owner ls hashtable-patch-valeriansaliou
397 error There is likely additional logging output above.
398 verbose exit [ 1, true ]

Finally fixed this by installing npm install -g windows-build-tools with elevated privileges (Reference https://superuser.com/questions/1032689/how-do-i-add-vcbuild-exe-to-windows-10-w-o-visual-studio)


Improve readthedocs documentation

After the refactoring:

Place there the main modules used by the user
Add more detailed features description
tbd

Blocked by #230


JSON editor in Azure Portal for authoring & deploying ADF v1 pipelines will be turned OFF on 31st July 2019

The JSON editor in Azure Portal for authoring & deploying ADF v1 pipelines will be turned OFF on 31st July 2019. After 31st July 2019, you can continue to use ADF v1 Powershell cmdlets, ADF v1 .Net SDK, ADF v1 REST APIs to author & deploy your ADF v1 pipelines
Does that mean whatever the process explained in this page cannot be implemented after 31st July 2019?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d40162fc-615f-66b6-b3a3-9a7e1dd8cb81
Version Independent ID: b08172b7-bb21-ce9a-f459-85a9a214a6c4
Content: Tutorial: Create an Azure Data Factory pipeline to copy data (Azure portal)
Content Source: articles/data-factory/v1/data-factory-copy-activity-tutorial-using-azure-portal.md
Service: data-factory
GitHub Login: @linda33wj
Microsoft Alias: jingwang

@bhavyaGidugu Thanks for the feedback. I am assigning the issue to the content owner to review and update the doc.
@linda33wj Can you please take a look at this ?

@linda33wj Any update on this ?

@ChiragMishra-MSFT please re-assign this to @djpmsft

The JSON editor in Azure Portal for authoring & deploying ADF v1 pipelines is now disabled. Please use alternate methods such as ADF v1 Powershell cmdlets, ADF v1 .Net SDK, ADF v1 REST APIs to author & deploy your ADF v1 pipelines.

#please-close


feat(general): fixed submodules paths

apparently you can't clone the submodule without ssh key connected to github, so I've switched to https instead

I did add them with git instead of https, didn't know it wasn't okay.

added a commit to trigger the CI check, apparently it wasn't triggered as I've renamed the repo


onStepEnter fails with Chrome on specific screen size

I have noticed this weird behavior when using scrollama on my laptop vs. my desktop, onStepEnter would only be triggered at around 0.8 progress and go straight to 100%. I use Chrome 76.0.3809.87.
It gets solve when I zoom in and out of my browser.
Let me know if you need more info

I was able to reproduce this behavior by zooming on my desktop to 150%

Same issue here, I recently updated my app to use scrollama.js instead of waypoint.js to improve performance and encountered this issue on my smartphone (Huawei P10).
BTW, it is also reproducible on Chrome with 150% as mentioned above by @maxdulieu.

Possibly duplicate of "Offset trigger not working properly on Chrome mobile."  #87

Another possible duplicate https://github.com/russellgoldenberg/scrollama/issues/64

If this is a zoom issue, that is a duplicate (as @pldg mentioned) of #64. If you can paste the code that would be helpful to try and reproduce.

I'm facing the same issue. One of the elements that we're using to trigger changes in the background colour does not get registered when it crosses the threshold level (have noticed this more often on a laptop both with and without an external monitor).
A few interesting observations:

It's always the same element that does not get registered
This happens only when I scroll up from the bottom of the page
This happens only when I scroll really slowly (easier to reproduce using a trackpad compared to a mouse scroll wheel)
This happens only above a certain viewport width, at least if an external monitor is connected (specifically, < 1388px)

Please let me know if anyone has ideas on how to work around this problem.


Add CSS "scroll-snap-type"

CSS "scroll-snap-type" doesn't appear to be listed. It is supported by many browsers.
See: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-snap-type

Searching leads to https://caniuse.com/css-snappoints, which looking at the spec, seems to cover scroll-snap-type. The feature on caniuse has it as a keyword to make is searchable: https://github.com/Fyrd/caniuse/blob/main/features-json/css-snappoints.json#L439
Related: #1673
Or am I missing something? :)

On the snappoints page, scroll-snap-type is not mentioned anywhere.
Search results for scroll-snap-type-x and scroll-snap-type-y are listed and being listed as obsolete and unsupported by most browsers. This leads me to think that scroll-snap-type is not available/supported as it is not explicitly mentioned anywhere. However, it supported by most browsers.

I agree it is rather confusing the way it works now, largely due to https://caniuse.com/css-snappoints not explicitly mentioning all the properties that are included in the Scroll Snap Module and scroll-snap-type-x & scroll-snap-type-y being deprecated properties from an earlier version of the spec.
Furthermore, the caniuse feature is currently set to replace the MDN table for scroll-snap-type which is why it does not appear. Seems undoing that should fix this particular issue so I'll do that.

This was done, see https://caniuse.com/mdn-css_properties_scroll-snap-type so closing this issue.


fix: Consistent definition of schema_or_source

Ecto.Multi was using an inconsistent definition of schema_or_source from c:Ecto.Repo.insert_all/3.
https://github.com/elixir-ecto/ecto/blob/cc75abde90dbeea29e51611f530e2de768d48c69/lib/ecto/repo.ex#L1307
This PR would fix that inconsistency.

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


[New Feat] If dubbo website need AOS animations for enhanced scroll effects .I can try to pull request

Describe the proposal
Add AOS animations
Integrated AOS (Animate On Scroll) library
Applied animations to various sections of the site
Improved user experience with smooth scroll effects
just like:
https://streampark.apache.org/zh-CN/
https://michalsnik.github.io/aos/

@chickenlj PTAL


Privilege revocation for deleted objects

Currently there seems to be privilege revocation missing which results in orphaned data rows.
Example:
@user.has_role! :provider, @service
If @service or @user is deleted, corresponding privileges need to be revoked. Maybe this could be implemented inside an after_destroy callback.

A little bit late… but thanks for your reply ;-)


Showcase fails to start on case-sensitive OS

❯ kivy /Applications/Kivy2.app/Contents/Resources/kivy/examples/demo/showcase/main.py
[WARNING] [Config      ] Older configuration version detected (0 instead of 14)
[WARNING] [Config      ] Upgrading configuration in progress.
Purge log fired. Analysing...
Purge finished!
[INFO   ] [Logger      ] Record log in /Applications/Kivy2.app/Contents/Resources/.kivy/logs/kivy_17-01-15_0.txt
[INFO   ] [Kivy        ] v1.9.1-dev0
[INFO   ] [Python      ] v2.7.10 (default, Oct 23 2015, 19:19:21)
[GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-7<IP_ADDRESS>)]
[INFO   ] [Factory     ] 179 symbols loaded
[INFO   ] [Image       ] Providers: img_tex, img_imageio, img_dds, img_gif, img_sdl2 (img_pil, img_ffpyplayer ignored)
[INFO   ] [OSC         ] using <multiprocessing> for socket
[INFO   ] [Window      ] Provider: sdl2
[INFO   ] [GL          ] OpenGL version <2.1 INTEL-10.14.73>
[INFO   ] [GL          ] OpenGL vendor <Intel Inc.>
[INFO   ] [GL          ] OpenGL renderer <Intel Iris OpenGL Engine>
[INFO   ] [GL          ] OpenGL parsed version: 2, 1
[INFO   ] [GL          ] Shading version <1.20>
[INFO   ] [GL          ] Texture max size <16384>
[INFO   ] [GL          ] Texture max units <16>
[INFO   ] [Window      ] auto add sdl2 input provider
[INFO   ] [Window      ] virtual keyboard not allowed, single mode, not docked
[INFO   ] [Text        ] Provider: sdl2
[INFO   ] [GL          ] NPOT texture support is available
 Traceback (most recent call last):
   File "/Applications/Kivy2.app/Contents/Resources/kivy/examples/demo/showcase/main.py", line 238, in <module>
     ShowcaseApp().run()
   File "/Applications/Kivy2.app/Contents/Resources/kivy/kivy/app.py", line 802, in run
     root = self.build()
   File "/Applications/Kivy2.app/Contents/Resources/kivy/examples/demo/showcase/main.py", line 72, in build
     self.go_next_screen()
   File "/Applications/Kivy2.app/Contents/Resources/kivy/examples/demo/showcase/main.py", line 93, in go_next_screen
     screen = self.load_screen(self.index)
   File "/Applications/Kivy2.app/Contents/Resources/kivy/examples/demo/showcase/main.py", line 117, in load_screen
     screen = Builder.load_file(self.available_screens[index].lower())
   File "/Applications/Kivy2.app/Contents/Resources/kivy/kivy/lang.py", line 1829, in load_file
     with open(filename, 'r') as fd:
 IOError: [Errno 2] No such file or directory: '/applications/kivy2.app/contents/resources/kivy/examples/demo/showcase/data/screens/accordions.kv'

I was able to fix this locally by removing the both lower calls in line:
https://github.com/kivy/kivy/blob/master/examples/demo/showcase/main.py#L117
and
https://github.com/kivy/kivy/blob/master/examples/demo/showcase/main.py#L122
Instead lower() the screen name in
https://github.com/kivy/kivy/blob/master/examples/demo/showcase/main.py#L71
self.available_screens = [join(curdir, 'data', 'screens',
            '{}.kv'.format(fn.lower())) for fn in self.available_screens]

@JayGray, thanks! You may also open a pull request when you have a fix in mind.

Closed with https://github.com/kivy/kivy/commit/05a109ca31f39c89f0305f4997a65354e58f7a96
@JayGray Nice one :-)


python311Packages.elastic-apm: 6.18.0 -> 6.19.0

Diff: https://github.com/elastic/apm-agent-python/compare/refs/tags/v6.18.0...v6.19.0
Changelog: https://github.com/elastic/apm-agent-python/releases/tag/v6.19.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 260621 run on x86_64-linux 1

4 packages built:

python310Packages.elastic-apm
python310Packages.elastic-apm.dist
python311Packages.elastic-apm
python311Packages.elastic-apm.dist


ADServicePrincipalName: Call test at the top of set in case of explicit call to set function

Pull Request (PR) description
Add check at the top of Set-TargetResource to cover case when Invoke-DscResource -Method Set is called
This Pull Request (PR) fixes the following issues

Fixes #520

Task list

[x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based
help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Community Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[x] New/changed code adheres to DSC Community Style Guidelines.

This change is

Thanks for this! Great work! 🙂


Use "Sublime Text" in context menu entry

Use "Sublime Text" rather than just "Sublime" in the optional context menu entry for Sublime Text.

[x] I have read the Contributing Guide.

I was about to make the changes as well. Thanks for the PR.

/verify

/verify

Why github-actions bot is not triggered?

@Varriount There's a merge conflict. Please advise how to proceed. Thanks, and sorry for the late reply.


Rendering Twice

Hello,
I have dissected, rewritten and analyzed your code and I have a question about when you call renderStereoscopicScene.  In your render method, you call for each eye to be rendered, from my experience, SCNRender is single threaded, and will always complete one after the other, but back on point, after the LEFT has finished, the RIGHT will finish and call, renderStereoscopicScene, since LEFT was "ready".  Then at the end of the render method you call renderStereoscopicScene again, which basically means double render.
I have written my own VR library for iOS using SceneKit and heavily base some parts off ALPS-VR for Unity, but I only have it render "once", which brings up an interesting issue.  The first time, SCNRenderer is used, it messes up the image and makes it appear stretched.  Is that why you opted to have it render twice, so the issue can be corrected.  For my code I have it render an extra blank scene into a tiny viewport, so the issue is resolved with a single extra render.

I have spoken with Apple support about my iOS VR code and they were able to correct the SceneKit rendering errors.  The fix is to bind the texture before you call the render method, not while in the render method.  When you bind inside the render method, its already setup all the matrix operations based upon the bound view port, so when you double render, its corrected because it was already setup before.  SceneKit rendering at least on iOS is single threaded.


SQLAlchemy JSON support

Description

This PR introduces native SQLAlchemy JSON conversion support. While it's unclear whether this is an actual issue or a deliberate design choice to exclude scalar types, I've made the necessary changes to enhance the functionality.
Resuming the changes, I've added {sqlalchemy.JSON: strawberry.scalars.JSON} in  _default_sqlalchemy_type_to_strawberry_type_map.
I'd like to extend my gratitude to @wisdomG for their assistance with Issue #22 .
Additionally, please note that some tests required adjustments due to automatic changes introduced by pre-commit. I am using devcontainers and followed all guides in CONTRIBUTING.md for this development.
Types of Changes

[ ] Core
[ ] Bugfix
[x] New feature
[ ] Enhancement/optimization
[x] Documentation

Issues Fixed or Closed by This PR

#22

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md:
Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Description
This PR introduces native SQLAlchemy JSON conversion support. While it's unclear whether this is an actual issue or a deliberate design choice to exclude scalar types, I've made the necessary changes to enhance the functionality.
Resuming the changes, I've added {sqlalchemy.JSON: strawberry.scalars.JSON} in _default_sqlalchemy_type_to_strawberry_type_map.
I'd like to extend my gratitude to @wisdomG for their assistance with Issue #22 .
Additionally, please note that some tests required adjustments due to automatic changes introduced by pre-commit. I am using devcontainers and followed all guides in CONTRIBUTING.md for this development.
Types of Changes

[ ]  Core
[ ]  Bugfix
[x]  New feature
[ ]  Enhancement/optimization
[x]  Documentation

Issues Fixed or Closed by This PR

Unsupported column type: JSON #22

Checklist

[x]  My code follows the code style of this project.
[x]  My change requires a change to the documentation.
[x]  I have updated the documentation accordingly.
[x]  I have read the CONTRIBUTING document.
[x]  I have added tests to cover my changes.
[x]  I have tested the changes and verified that they work and don't break anything (as well as I can manage).

FWIW the reason why JSON was not originally included when I first wrote the library was because Strawberry didn't have a built-in JSON scalar type at that time, and not as a specific design decision

I understand, please let me know if the code needs any corrections, I'm available!

Description
This PR introduces native SQLAlchemy JSON conversion support. While it's unclear whether this is an actual issue or a deliberate design choice to exclude scalar types, I've made the necessary changes to enhance the functionality.
Resuming the changes, I've added {sqlalchemy.JSON: strawberry.scalars.JSON} in _default_sqlalchemy_type_to_strawberry_type_map.
I'd like to extend my gratitude to @wisdomG for their assistance with Issue #22 .
Additionally, please note that some tests required adjustments due to automatic changes introduced by pre-commit. I am using devcontainers and followed all guides in CONTRIBUTING.md for this development.
Types of Changes

[ ]   Core
[ ]   Bugfix
[x]   New feature
[ ]   Enhancement/optimization
[x]   Documentation

Issues Fixed or Closed by This PR

Unsupported column type: JSON #22

Checklist

[x]   My code follows the code style of this project.
[x]   My change requires a change to the documentation.
[x]   I have updated the documentation accordingly.
[x]   I have read the CONTRIBUTING document.
[x]   I have added tests to cover my changes.
[x]   I have tested the changes and verified that they work and don't break anything (as well as I can manage).

FWIW the reason why JSON was not originally included when I first wrote the library was because Strawberry didn't have a built-in JSON scalar type at that time, and not as a specific design decision

Ok I understand, please let me know if the code needs any corrections, I'm available!

Codecov Report

Merging #40 (62889a1) into main (8ffa1f4) will increase coverage by 0.53%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   76.84%   77.37%   +0.53%
==========================================
  Files          10       10
  Lines         717      725       +8
  Branches      107      108       +1
==========================================
+ Hits          551      561      +10
+ Misses        136      135       -1
+ Partials       30       29       -1

Resolved conflicts with main.


Merge upstream tag v1.27.0

Operator SDK v1.27.0
Merge executed via ./UPSTREAM-MERGE.sh v1.27.0

/lgtm


fix(reader): Fix reading of xlsx richtext

Summary
Fixes #187
Description
This PR adds a stringify method for a richText object.
Todo

Tests

[x] Unit
[ ] Integration
[ ] Acceptance

[ ] Documentation

Coverage decreased (-0.03%) to 89.979% when pulling c3b2293e558f44fe4dab6b6b4729409aa65ad7de on 187-stringify-xlsx-rich-text into a86a88cc9eb7edf07cf761ea208baac513989cc7 on master.