There's no explanation of what a directory junction is and that's a glaring omission! I know what it is from googling it and finding an explanation on howtogeek.com, but really, it should be on the mklink doc page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8715a186-098e-b345-2279-688a9d99ad5d
Version Independent ID: 70faf0b2-4160-8c9c-80f9-fa09f841b6ce
Content: mklink
Content Source: WindowsServerDocs/administration/windows-commands/mklink.md
Product: windows-server
Technology: windows-commands
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


open-vsx badges don't work; results in "inaccessible"

Are you experiencing an issue with...

[x] shields.io
[ ] My own instance
[ ] badge-maker NPM package

:beetle: Description
open-vsx badges don't work; even the example input of redhat / java results in "inaccessible"

:link: https://img.shields.io/open-vsx/v/redhat/java

I observed the same earlier today. During that window while the badge was showing inaccessible (~45 minutes after the issue posting), the API was responsive and providing the expected responses and our service test runs were also passing.
Things seem to be fine again at the moment though but we'll keep an eye out. Could've been a simple transient issue or there could be some upstream throttling/blocking that was preventing our prod servers from being able to access the registry.

Thanks for checking! The badges seem to have been working flawlessly today. I consider the issue to be resolved for now.

Lets assume it was a transient issue for now. If it recurrs feel free to reopen


Adding units for continuous variables

Merge https://github.com/SimonGreenhill/dplace-data/pull/16 before this.
Requires database to be re-built and data to be re-loaded.
Added field 'units' to CulturalVariable model, displayed units in results and legends.
Fix for #327

Current coverage is 91.25%

Merging #330 into master will decrease coverage by -0.18% as of 3c52211

@@            master    #330   diff @@
======================================
  Files           41      42     +1
  Stmts         2079    2093    +14
  Branches         0       0
  Methods          0       0
======================================
+ Hit           1901    1910     +9
  Partial          0       0
- Missed         178     183     +5

Review entire Coverage Diff as of 3c52211

Powered by Codecov. Updated on successful CI builds.


Make it possible to handle a reset of an instance of a component, within the app.

Is your feature request related to a problem? Please describe.
Currently if you reset an instance of a component, this is not sent to Figma Tokens. Therefore FT does nothing with an instance that is reset.
Describe the solution you'd like
Make it possible that the reset of instance is handled in FT.
Additional context
This is probably due to caching on Figma end. FT doesn't get a response from Figma, when a reset of instance is performed.
https://user-images.githubusercontent.com/109062656/183024011-d8493052-9712-4f0d-8d98-c6bd991e392b.mov

@LiamMartens tagging you here. What are your thoughts on this issue?

Will be possible in Release 129


Added a C++ program to implement OOPs for a box

Proposed Changes
Design a class named Box whose dimensions are integers and private to the class. The dimensions are labelled: length l , breadth b, and height h.

Also please remove the changes in the CONTRIBUTING.md file since it is not relevant to this repository.

All changes are done sir
On Sat, 30 Oct 2021, 3:01 pm Vinayak Tekade, @.***>
wrote:

Also please remove the changes in the CONTRIBUTING.md file since it is
not relevant to this repository.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/DSC-ASEB/Hacktoberfest/pull/26#issuecomment-955180578,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARRAZRM7XW7I4O7I3GRNHETUJO3QJANCNFSM5G7UUNUA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I can only see the c++ file. Also, could you update this PR to describe what your code does? See other PRs  here for reference. You could also refer to [Best Pull Request Practices] here.

is it okay now?
On Sat, 30 Oct 2021 at 16:17, Vinayak Tekade @.***>
wrote:

I can only see the c++ file. Also, could you update this PR to describe
what your code does? See other PRs
https://github.com/DSC-ASEB/Hacktoberfest/pulls here for reference. You
could also refer to [Best Pull Request Practices] here.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/DSC-ASEB/Hacktoberfest/pull/26#issuecomment-955189274,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARRAZRM24A4HXMKIIZMOIPDUJPEN3ANCNFSM5G7UUNUA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

i have created a new pull request with all things correct in my new pull
request please see that also
On Sat, 30 Oct 2021 at 16:25, Kanishka Srivastava <
@.***> wrote:

is it okay now?
On Sat, 30 Oct 2021 at 16:17, Vinayak Tekade @.***>
wrote:

I can only see the c++ file. Also, could you update this PR to describe
what your code does? See other PRs
https://github.com/DSC-ASEB/Hacktoberfest/pulls here for reference.
You could also refer to [Best Pull Request Practices] here.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/DSC-ASEB/Hacktoberfest/pull/26#issuecomment-955189274,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARRAZRM24A4HXMKIIZMOIPDUJPEN3ANCNFSM5G7UUNUA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I have edited it for you. Have a look and make PRs like this from now onwards. Happy Learning!

Oh thanks a lot as I am a first year student.
On Sat, 30 Oct 2021, 8:48 pm Vinayak Tekade, @.***>
wrote:

@.**** approved this pull request.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/DSC-ASEB/Hacktoberfest/pull/26#pullrequestreview-793578885,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARRAZRLDZSAW7N2WIVKZCO3UJQEFNANCNFSM5G7UUNUA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hey @kanishkasrivastava!
Just a reminder... Today is the last date for Hacktoberfest.

Updated.  what taking so long merge it sir i did all the changes
On Sun, 31 Oct 2021 at 08:03, Aravind Nair @.***> wrote:

Hey @kanishkasrivastava https://github.com/kanishkasrivastava!
Just a reminder... Today is the last date for Hacktoberfest.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/DSC-ASEB/Hacktoberfest/pull/26#issuecomment-955654963,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARRAZRO3ONFKIWH4WO4RXI3UJTZ4FANCNFSM5G7UUNUA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Updated. what taking so long merge it sir i did all the changes

Hey @kanishkasrivastava! Please take a look at my comment on the GitHub interface than via email. Check this: https://github.com/DSC-ASEB/Hacktoberfest/pull/26#pullrequestreview-793595244


MAINT: type hinting

Summary by Sourcery
Refactor type hinting to use modern Python syntax, improving code readability and maintainability. Update test cases to use more concise patterns and simplify parameterization. Adjust build configuration to ignore specific linting rules in Ruff.
Enhancements:

Refactor type hinting to use Python 3.10+ syntax, replacing typing.Optional and typing.Union with the new union operator (|).
Improve code readability by replacing list and tuple comprehensions with more concise syntax.
Enhance error messages by storing them in variables before raising exceptions.

Build:

Update pyproject.toml to ignore additional linting rules in Ruff, including rules related to naming conventions and positional boolean arguments.

Tests:

Refactor test cases to use the next(iter(...)) pattern instead of list indexing for fetching single elements from iterators.
Simplify pytest parameterization by using lists instead of tuples for test parameters.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

73 of 79 (92.41%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.009%) to 92.306%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/cogent3/core/annotation_db.py
70
76
92.11%

Files with Coverage Reduction
New Missed Lines
%

src/cogent3/core/annotation_db.py
1
94.95%

Totals

Change from base Build<PHONE_NUMBER>6:
-0.009%

Covered Lines:
34084

Relevant Lines:
36925

💛  - Coveralls


The mongo bundle should not be part of the api requirement

"solution/mongo-odm-aggregation-bundle": "*"

The repository https://github.com/open-orchestra/open-orchestra-base-api-mongo-model-bundle has been created to extract all the documents


Enable disabling autolabel in repo

This is needed for astropy/astropy#10974

I don't understand the error message.  Rename that file temporarily and try again.")

            headers = {}
            headers['Authorization'] = 'Bearer {0}'.format(get_json_web_token())
            headers['Accept'] = 'application/vnd.github.machine-man-preview+json'

            url = 'https://api.github.com/app/installations/{0}/access_tokens'.format(installation)

            req = requests.post(url, headers=headers)
            resp = req.json()

            if not req.ok:
                if 'message' in resp:
>                   raise Exception(resp['message'])
E                   Exception: A JSON web token could not be decoded

OK, let's have this merged. If there are issues, those are not limited to this PR, and anyway, it's likely that my understanding is not correct.

@bsipocz , just to close the loop, I think this PR is correct. For example:
>>> from baldrick.config import load
>>> cfg = load('pyproject.toml', tool='astropy-bot')  # From the root dir of this repo
>>> cfg
{'autolabel': {'enabled': True},
 'milestones': {'enabled': True},
 'pull_requests': {'enabled': True,
  'post_pr_comment': False,
  'skip_labels': ['Experimental', 'Work in progress'],
  'skip_fails': True,
  'pull_request_substring': 'issues related to the changelog'}}


FI-3154: Full EHR Adaptive Questionnaire Tests

Summary
This pull request introduces a new set of tests to validate that a DTR Full EHR client can perform a full adaptive questionnaire workflow using the mocked Dinner Order Adaptive Questionnaire. The adaptive workflow involves fetching the adaptive questionnaire package, rendering and pre-populating initial questions, requesting follow-up questions, and completing the adaptive questionnaire response as per the Da Vinci DTR specification.
Changes Made

Added Adaptive Dinner Questionnaire Workflow for the Full EHR suite, including:

Retrieval of the adaptive questionnaire package.
Retrieval of next questions.
Attestation of proper rendering and population of each next question retrieved.
Completion and validation of the QuestionnaireResponse for each next-question call.

Refactored some existing folders and files to allow test reusability and avoid duplication of similar tests.
Updated the Postman Collection to include new tests and requests needed to validate the adaptive questionnaire workflow.

What's Left to Do

[x] Cleanup sample input parameter resources to pass validation (will update the postman collection after)
[x] Add unit tests
[x] Add Adaptive Dinner Questionnaire Workflow for the DTR SMART APP suite (Maybe another ticket?)

Note
The file restructuring affects the following open pull request: FI-3222: DTR Client Tests: Use Random Number for Attestation Continuation Links.  That pull request should be merged first, and I'll rebase this branch accordingly.
Testing Guidance
Attached postman collection for testing :
DTR Full EHR Tests Postman Demo.postman_collection.json

I don't think we can separate the $questionnaire-package and first $next-question calls into separate waits. I expect that typical clients will make almost immediate $next-question calls following the $questionnaire-package call that returns the (empty) adaptive questionnaire. Each other call has a user input step after it, so I think the other divisions are fine.

I tried running against the payer tests and was not successful due to issues with the payer tests. Created a ticket for that FI-3303. We might wait for finalize this IG until that is done as I think it might surface issues with these tests, but more likely we should not wait on it and create follow-up tickets if it does, so let's plan on that.

while writing unit test for questionnaire response validation, I determined that this method check_answer_presence is not doing what it is supposed to do. I might be wrong, or it was not just applicable to my scenario, which is ensuring that all required questions have been answered. I wrote this alternative check_required_answers_presence below that method. Please review and let me know if both methods are needed.

while writing unit test for questionnaire response validation, I determined that this method check_answer_presence is not doing what it is supposed to do. I might be wrong, or it was not just applicable to my scenario, which is ensuring that all required questions have been answered. I wrote this alternative check_required_answers_presence below that method. Please review and let me know if both methods are needed.

Looks to me like these methods are doing the exact same thing. The only difference is that check_answer_presence checks for an answer value and check_required_answer_presence just checks for an answer. When I run this test, check_answer_presence does catch missing answers.

while writing unit test for questionnaire response validation, I determined that this method check_answer_presence is not doing what it is supposed to do. I might be wrong, or it was not just applicable to my scenario, which is ensuring that all required questions have been answered. I wrote this alternative check_required_answers_presence below that method. Please review and let me know if both methods are needed.

Looks to me like these methods are doing the exact same thing. The only difference is that check_answer_presence checks for an answer value and check_required_answer_presence just checks for an answer. When I run this test, check_answer_presence does catch missing answers.

Are you using the example sample QuestionnaireResponse from the postman collection?

Are you using the example sample QuestionnaireResponse from the postman collection?

Yes, but with an answer removed. qr_sample.json

Ah I see the issue. check_answer_presence passes if the entire item is not there. Yeah, you can go ahead and replace what's there with your method.

Did some work towards getting this executing against a local copy of the DTR RI. Currently still working against our private fork, but I hope that we will migrate to the public one and potentially make a PR against it eventually. Being able to interact with the form is crucial to making sure that the workflow and the attestation questions that we ask make sense, so I won't approve this until we've got this working.
Here's where I am:

I can get the RI to do the first $next-question call
problems come up on the second $next-question call, specifically around CORS on the request to get Coverage/devreqe0470 - in my current setup, this is in the additional "EHR-available resources (Dinner Adaptive)" input, so there may be an issue with the "access-control-allow-origin" header in some of those cases.

Getting this far required:

some fixes to our fork of the DTR smart app - committed to the smart-launch-adaptive-with-ri branch
some fixes to the dtr test kit, specifically around the form of the $next-question responses which are not wrapped in parameters (based on "If there is only one out parameter, which is a Resource with the parameter name "return" then the parameter format is not used, and the response is simply the resource itself." from the FHIR operations spec and the $next-question operation definition from SDC which has a single output parameter named return), pushed to this branch.

To run

install start up the dtr smart app locally (I start with NODE_OPTIONS=--openssl-legacy-provider npm start)
start a local copy of the reference server using the current main branch
start the dtr test kit and start a SMART App Launch session
Run the adaptive questionnaire workflow group with these inputs

client_id = sample
launch_uri = http://localhost:3005/launch
EHR-available resources (Dinner Adaptive) = contents of inferno-served-instances.json

use the link to launch the dtr smart app, which should successfully get to an empty questionnaire with a Next Question button.
load up the developer tools in the web browser so you can see requests
click the Next Question button, which load the first three questions (name, location, and dinner choice), pre-populating the name question
Go back to the Inferno tests and do the attestations to get to the next wait for $next-question dialog
go to the dtr smart app, make sure you've filled everything in, and click the Next Question button. For me this displayed "Fetching Resources ..." and hung

Let's get this working the rest of the way!

some fixes to the dtr test kit, specifically around the form of the $next-question responses which are not wrapped in parameters (based on "If there is only one out parameter, which is a Resource with the parameter name "return" then the parameter format is not used, and the response is simply the resource itself." from the FHIR operations spec and the $next-question operation definition from SDC which has a single output parameter named return), pushed to this branch.

I don't think the change made to the test kit is right. "If there is only one out parameter, which is a single Resource with the parameter name "return" then the parameter format is not used, and the response is simply the resource itself." should apply to the server's (inferno) response not the client's input parameter (operation request). We should also note that both the 'IN' and 'OUT' parameters in the $next-question operation definition have a 1..1 cardinality.
The initial Inferno's response to next question request is still wrong. currently returning a single parameter named questionnaire-response. It should be returning a single parameter named return.  But if the cardinality specified in the $next-question operation definition is not relevant then I can simply return the resource.

The code change will also make sense if we ignore the specified cardinality for the in parameter.

Not sure I understand your comments here. The code changes I made are in the logic that builds Inferno's response to $next-question. There are two primary changes (I realize I only listed one and messed up a link).
First, make the output the raw QuestionnaireResponse instead of a Parameters. This is allowed because there is only 1 OUT parameter and it is a Resource (QuestionnaireResponse) as described in the FHIR Operation page. The input parameter is not included in the output, so the 1..1 cardinality does not prevent us from returning the raw QuestionnaireResponse.  This is a MAY requirement, so, it is possible that we want to provide a configuration so that testers can choose which way Inferno provides the response. Not sure.
Second, allow the body of the POST to be the raw QuestionnaireResponse instead of a Parameters. This is allowed based on this statement on the FHIR Operation page: "If, when invoking the operation, there is exactly one input parameter of type Resource (irrespective of whether other possible parameters are defined), that the operation can also be executed by a POST with that resource as the body of the request (and no parameters on the url)." This could probably have been done in a cleaner way, so refactor if you want, but I think allowing both approaches should be supported.

The initial Inferno's response to next question request is still wrong. currently returning a single parameter named questionnaire-response. It should be returning a single parameter named return. But if the cardinality specified in the $next-question operation definition is not relevant then I can simply return the resource.

Your experience doesn't match with my code or what I observed when running against the reference implementation locally.  Can you check again and if you're still having problems, let's meet to sync up.

The initial Inferno's response to next question request is still wrong. currently returning a single parameter named questionnaire-response. It should be returning a single parameter named return. But if the cardinality specified in the $next-question operation definition is not relevant then I can simply return the resource.

For the above statement I was referring to my initial implementation.
I understand the changes made based on the statements from the FHIR Operation Page. I just wanted to make sure that the cardinalities specified in the $next-question operation definition are not relevant and does not add a constrain to what's stated in the FHIR operation page.

I just wanted to make sure that the cardinalities specified in the $next-question operation definition are not relevant and does not add a constrain to what's stated in the FHIR operation page.

It is a somewhat confusing view since they are in the same table, but input and output parameters are considered separately - input parameters appear only in the operation request (body or sometimes in the url) and output parameters appear only in the operation response body. In each case, when there is only 1 resource in the body, it is permissible to send that resource unwrapped without the surrounding parameter boilerplate as described in the links I included above and the cases that we are dealing with here fall into those situations.

This section of the IG might explain why the DTR RI  was making the $next-question request without Questionnaire as the resource type

Starting with a review of the workflows and user experience when going through these tests. Next, for the Full EHR tests, here's what I see and some suggestions to clean it up
Full EHR Flow

Attest to DTR launch in context of a patient with a full name (to pre-populate)
Wait test with instructions for making

$questionnaire-package call
First $next-question call

Attestation of name pre-population
Attestation of first name editing (combine with the prior test as in the SMART app tests - can’t edit if it isn’t pre-populated, so they can fail together)
?? Instructions to answer the “What do you want for dinner” question
Wait test with instructions for making

Follow-up $next-question call

?? Instructions to Answer additional questions if desired?
Wait test with instructions for making

The last $next-question call

Attest that the QR has been stored for future use
Verify QR that has been provided in a text box

Proposal: add instructions to following wait tests:

[ ] Follow-up next-question - answer the what do you want for dinner question and then make a next question request
[ ] Final next-question - answer the remaining questions and then make a final next-question request

Proposal:

[ ] get rid of the text box for the QuestionnaireResponse and instead verify the QuestionnaireResponse sent in the last $next-question call

Proposal:

[ ] combine name pre-population and name editing attestations like it done in the SMART App tests for location

For the Full EHR, the issue I see with combining name pre-population and name editing attestations, as done in the SMART App tests for location, is that we would no longer have a test solely focused on verifying that the client can pre-populate data.

all three $next-question requests are getting associated with the last $next-question test even though only one is being made during that section. I'm assuming this is due to how we're using tags and that it isn't currently easy to fix because the functionality to do so doesn't exist in core. If that's right, fine to leave.

For the Full EHR, the issue I see with combining name pre-population and name editing attestations, as done in the SMART App tests for location, is that we would no longer have a test solely focused on verifying that the client can pre-populate data.

Fine to keep them separate.

in the SMART app suite, all three $next-question requests are getting associated with the last $next-question test even though only one is being made during that section. I'm assuming this is due to how we're using tags and that it isn't currently easy to fix because the functionality to do so doesn't exist in core. If that's right, fine to leave.
One additional thing I think it means is that we should have the whole adaptive group be run as group - otherwise, requests from previous runs could get associated incorrectly.

Yup, I updated to make the adaptive workflow run as group.

ugh - requests from a prior run still be included. I think this means that the $next-question tag needs to be specific to which wait test is active so that you can distinguish the first, second, and third $next-question requests.

I noticed a discrepancy between SMART and Full EHR that got me thinking: The Full EHR next question tests continue immediately. In the SMART tests, we require users to manually continue since they may need to fetch data for pre-population. Even when the returned questionnaire sections don't have prefetch information needed, I think it is right to not make assumptions about what requests the client will make. In the full EHR, inferno is only simulating the payer server, so there’s no data fetch stuff happening, meaning that I think its ok to continue immediately, though it does risk making assumptions (for example, doesn't the RI client make additional $questionnaire-package requests? - what if an EHR wanted to test itself as a complete full EHR with that app). I think I lean towards just making users continue manually for safety, but I'm not fully confident in that.
If we do continue immediately, there’s still an internal discrepancy between the first $questionnaire-package + $next-question waits, which require a user to continue, and the $next-question only waits, which continue automatically. Looks like it may not be easy right now to make them consistent and have all of them continue automatically after the $next-question call, but maybe that can be resolved when Tom converts these to suite endpoints?
Thoughts?

Either way is fine with me.

I'm feeling consistent and conservative, so let's have them all wait for the user to signal they've made all the requests needed.


Branding guidelines

Eventually replacing https://www.mattermost.org/brand-guidelines/

Looks great, thanks Jason!


JsonOutputKeyToolsParser Corrections

Thank you for contributing to LangChain!

[ ] PR title: "package: description"

Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..."  for template changes, "infra: ..." for CI changes.
Example: "community: add foobar LLM"

[ ] PR message: Delete this entire checklist and replace with

Description: a description of the change
Issue: the issue # it fixes, if applicable
Dependencies: any dependencies required for this change
Twitter handle: if your PR gets announced, and you'd like a mention, we'll gladly shout you out!

[ ] Add tests and docs: If you're adding a new integration, please include

a test for the integration, preferably unit tests that do not rely on network access,
an example notebook showing its use. It lives in docs/docs/integrations directory.

[ ] Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

Make sure optional dependencies are imported within a function.
Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
Most PRs should not touch more than one package.
Changes should be backwards compatible.
If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

@yash-web3 what are the corrections? Can you update the PR summary to explain what changed?

Closing as there was no follow up. Feel free to re-open if you think something needs to be changed


Fix setuptools url and curl wants --location to follow redirects

This change also removes:
sys.meta_path = [importer for importer in sys.meta_path if
                 importer.__class__.__module__ != 'pkg_resources.extern']

from _unload_pkg_resources.
These lines were removed from the version at: https://bootstrap.pypa.io/ez_setup.py
I don't know why the code there and here differs.

Fixes 557, I think.

Fixes #557, I think.

That meta path manipulation unloads the old import hook when upgrading setuptools. Why did you remove it? It was necessary to fix #519.

@agronholm I was just reflecting what was at https://bootstrap.pypa.io/ez_setup.py
I'll put them back.

@agronholm I restored your fix and the PR makes more sense now.

Thanks @jaraco .
Can you also merge: https://github.com/pypa/setuptools/pull/560 other otherwise get the ez_setup.py changes on the bootstrap branch so the show up at: https://bootstrap.pypa.io/ez_setup.py ?


Carousel view flapping

Select which package(s) are affected
@livekit/components-react
Describe the bug
details are in #496
thanks @richthegxd for the report!
Reproduction
see #496
Logs
No response
System Info
*

Severity
annoyance
Additional Information
No response

@richthegxd Thanks again for the super clear bug report with the nice screen recording! A+ 👍
One follow up question. What operating system and browser are you using? We have a function that calucaltes the scrollbar width and maybe the bug is that it fails to work in the browser you are using? Or can you reporduce the bug across multiple browsers?

@Ocupe
@lukasIO
Hello everyone! We are testing on Windows, in our small team there is a tester who caught this bug in Chrome and Opera GX


feat(🔥): Rewrite in TypeScript

This is more of a draft and open for discussion before we merge it in.

I've added the changes of 3.1.4 to the PR.

interesting - github still thinks this is in conflict. not sure how to resolve that other than a force-push (very distasteful though I am pragmatic) or an actual rebase (then patching up locally). thoughts?

I think just fix the conflict now and it's ready. I'd think major version just because typings - flow - moved but with a note that nothing should have changed for people, it's an abundance of caution more than anything else. But I could be swayed for it just to be a minor version, I just think people don't take type changes seriously enough personally

Assuming this is because deviceinfo.js changed in master and it was deleted in my branch.
Could merge master into my branch, resolve the conflicts (i.e. delete files) and then merge back into master.
As github suggests,
git checkout master
git merge --no-ff feat/typescript
git push origin master

whatever works :-), it's not easy doing a change-all-files type change, so if that works great, we can merge then be back to normal. That's also why I'm "hovering" / "helicoptering" on this and being ridiculously interactive by the way, want to make sure it lands without any more fuss

a draft for discussion originally perhaps, but it looked like a fair straight port, and I like it. I don't see anything to change now, and I'd merge it. Want to think on it for a little bit, or just merge - I'll leave that up to you. Also, you could squash or make a merge commit, also up to you - I'll let you push the button :-). Thanks!

Hah, I was planning on squashing it.
I'm still thinking about versioning.  I'm leaning towards a minor update.  As the importing of types will differ.  Perhaps that's a breaking change as you suggested.

I see types as breaking changes unless they go less restrictive somehow. To me if I was using typescript, and I get a new version, and tsc doesn't compile anymore - breaking change. But I don't fear large major version numbers (and thus major version bumps). Who cares if it's react-native-device-info v32 ? Even though it sounds sort of silly I think it's a human perception issue when technically things should be marked as breaking more often

Sweet! Needs an entry in the CHANGELOG though - you can just commit that directly to master and push it

mike@isabela:~/work/react-random/react-native-device-info (master) % yarn dev-sync
yarn run v1.17.3
$ cp -r deviceinfo* *podspec windows web android ios src example/node_modules/react-native-device-info/
cp: cannot stat 'deviceinfo*': No such file or directory
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Hmm I removed deviceinfo from dev-sync!  Wonder if the merge of master brought it in again.

this is where the easy build comes in - because the example depends on the git ref for the module in package.json and the build is easy, I can just cd in there and say 'yarn' and it all works :-), so I can still test


createlang cannot find plperl

Getting this error:
    STDERR: createlang: language installation failed: ERROR:  could not open extension control file "/usr/share/postgresql/9.4/extension/plperl.control": No such file or directory

For some reason the cookbook is not installing all the extensions necessary.
My runlist:
"recipe[postgresql]",
    "recipe[postgresql::client]",
    "recipe[postgresql::contrib]",
    "recipe[postgresql::service]",
    "recipe[postgresql::libpq]",
    "recipe[postgresql::setup_users]",
    "recipe[postgresql::setup_languages]",
    "recipe[postgresql::setup_databases]",

Possibly allowing for: install postgresql-plperl

@mmahalwy thank you for the report. This is now resolved as of #137 and has been released with 0.16.1.

@phlipper you're a BO$$


[nice-to-have]: when navigating in the editor with the arrow keys, and I'm in the beginnign of a multi-line transclusion, I can't move to the next line below the transclusion. I does happen correctly when there's a one-line transclusion but not multi-line.

I believe this works in the new editor, although @IsKEK is working on making blocks selectable again


DBZ-8326 Add jackson afterburner to classpath

https://issues.redhat.com/browse/DBZ-8326

Fixed

@vjuranek Applied


Implement File based dataset services for Core Hunter

Update File based implementation of data services for Core Hunter

Completed basic services for all three types. Next step is to implement getMatrixData.

created branch git feature/getMatrixData to add new method to services to original data.

Implemented getMatrix, should now be enough to complete the GUI.


Question: Deserializing with unknown content

After reading the wiki at:
https://github.com/ExtendedXmlSerializer/home/wiki/Example-Scenarios#unknown-content
It does not look like it is working correctly for me.
I was testing the WithUnknownContent() option because an xml document changed and some fields are now deprecated.
Hopefully this can easily solve the problem without using Xslt.
But before I got there I noticed something strange with WithUnknownContent() when trying it out on an xml file without any unknown content.
var configurationContainer = new ConfigurationContainer()
  .EnableImplicitTyping(typeof(InputModel))
  .Create();
var inputModel = configurationContainer.Deserialize<InputModel>(new XmlReaderSettings { IgnoreWhitespace = false }, inputXml);

var configurationContainer2 = new ConfigurationContainer()
  .EnableImplicitTyping(typeof(InputModel))
  .WithUnknownContent()
  .Continue()
  .Create();
var inputModel2 = configurationContainer2.Deserialize<InputModel>(new XmlReaderSettings { IgnoreWhitespace = false }, inputXml);

I tried the above configurationContainers to deserialize an xml file without unknown content but noticed the deserialization no longer works when I add WithUnknownContent().
For var inputModel the deserialization works.
For var inputModel2 the deserialization does not work.
Any idea why the deserialization stops working when I add WithUnknownContent?
Let me know if you need the InputModel class or an example XML file.

Hi @josdemmers thank you for writing in with this.  Unfortunately, I will need a little more information to further diagnose/troubleshoot.  A simple model with the document content that reproduces what you are experiencing will suffice.
Also, it is a little unclear here with the use of XmlReaderSettings  but are you saying that the use of this also contributes to the issue that you are experiencing?

Ok I simplified the model as much as possible so it would still cause the same issue.
XML
<InputModelExample>
	<Configuration xmlns:exs="https://extendedxmlserializer.github.io/v2" exs:member="">
		<Language>LAD</Language>

Section1

		<Plc>FC-6011-SB1-CPU</Plc>
	</Configuration>
	<ModuleStates>
		<ModuleState>
			<Name>BUC</Name>
		</ModuleState>
	</ModuleStates>
</InputModelExample>

Relevant classes
    public class InputModelExample
    {
        public Configuration Configuration { get; set; }
        public List<ModuleState> ModuleStates { get; set; } = new List<ModuleState>();
        //public List<Module> Modules { get; set; } = new List<Module>();
        //public List<Variable> Variables { get; set; } = new List<Variable>();
        //public DBs DataBlocks { get; set; }
    }

  public class Configuration
  {
    public string Language { get; set; }
    public string Section { get; set; }
    public string Plc { get; set; }
  }

  public class ModuleState
  {
    public string Name { get; set; }
  }

Relevant code
var configurationContainer = new ConfigurationContainer()
  .EnableImplicitTyping(typeof(InputModelExample))
  .Create();
var inputModel = configurationContainer.Deserialize<InputModelExample>(new XmlReaderSettings { IgnoreWhitespace = false }, inputXml);

var configurationContainer2 = new ConfigurationContainer()
  .EnableImplicitTyping(typeof(InputModelExample))
  .WithUnknownContent()
  .Continue()
  .Create();
var inputModel2 = configurationContainer2.Deserialize<InputModelExample>(new XmlReaderSettings { IgnoreWhitespace = false }, inputXml);

Regarding XmlReaderSettings that is only relevant because it is part of my Deserialize call.
Issue
Using configurationContainer I get a new InputModelExample that contains the Configuration and ModuleStates from the above mentioned XML.
Using configurationContainer2 i get a new InputModelExample that contains the Configuration from the above mentioned XML. However the ModuleStates list is then empty.
Using Throw instead of Continue I can get the following exception:
{"Unknown/invalid member encountered: 'ModuleState'. Line 8, position 4."}

Which is strange because the ModuleState class exists and when using configurationContainer instead of configurationContainer2 the Deserializer has no problem creating an InputModelExample.

OK great @josdemmers thank you very much for the additional information and the quick reproduction.  It is very helpful.
I believe I see what you are encountering.  If I take the following:
var instance = new InputModelExample
			{
				Configuration = new Configuration(),
				ModuleStates  = new List<ModuleState>() { new ModuleState { Name = "BUC" } }
			};

And serialize it using configurationContainer , I get the following (whitespace/formatting added for readability):
<?xml version="1.0" encoding="utf-8"?>
<Issue571Tests-InputModelExample>
	<Configuration />
	<ModuleStates>
		<Capacity>4</Capacity>
		<Issue571Tests-ModuleState xmlns="clr-namespace:ExtendedXmlSerializer.Tests.ReportedIssues;assembly=ExtendedXmlSerializer.Tests.ReportedIssues">
			<Name>BUC</Name>
		</Issue571Tests-ModuleState>
	</ModuleStates>
</Issue571Tests-InputModelExample>

You can see that ModuleState still requires a namespace.  If it isn't provided, then it is resolved as unknown content.  See if the following configuration treats you better:
var configurationContainer = new ConfigurationContainer()
  .EnableImplicitTyping(typeof(InputModelExample), typeof(ModuleState))
  .Create();

I have added a quick test confirming this using the model you provided here, for your review:
https://github.com/ExtendedXmlSerializer/home/blob/02230c976565949ab8ef176f16af3d809a94bf9e/test/ExtendedXmlSerializer.Tests.ReportedIssues/Issue571Tests.cs#L11-L50

When expanding EnableImplicitTyping with .EnableImplicitTyping(typeof(InputModelExample), typeof(ModuleState))
Then the configurationContainer that uses WithUnknownContent works as well.
Thank you, now can I do some tests with xml files with deprecated properties.
Regarding the serializer, when I serialize it the xml does not contain any namespaces but that is probably because I used EnableImplicitTypingFromNamespacePublic.
Just out of interest, one more question regarding the configurationContainers in my previous example.
Any reason why the configurationContainer (without the WithUnknownContent configuration) does not have any problems with the missing namespace? But configurationContainer2 (with the WithUnknownContent configuration) does not like the missing namespace?

Just tested WithUnknownContent with some deprecated properties in my xml files, works perfect.
Deprecated properties are ignored and next elements are added without any problem!

So very happy to hear it works as expected for you @josdemmers!

Any reason why the configurationContainer (without the WithUnknownContent configuration) does not have any problems with the missing namespace? But configurationContainer2 (with the WithUnknownContent configuration) does not like the missing namespace?

Indeed a very good reason: I wrote broken software. 😁  The default behavior starting in v2 and into v3 (unfortunately we did not catch it in time) is to essentially fail silently.  The deserialization "works" but you'll notice the list is empty, or even populated with one element that doesn't have its properties assigned.  I added a new test to verify this with your model:
https://github.com/ExtendedXmlSerializer/home/blob/778ccbfe86cce3c48796bc0c54c555dafa9d5180/test/ExtendedXmlSerializer.Tests.ReportedIssues/Issue571Tests.cs#L34-L74
This was actually the impetus for the WithUnknownContent APIs.  If we ever do a v4 (which is doubtful as we are basically in maintenance mode now but who knows), the default behavior will be made to throw on exception and essentially obsolete WithUnknownContent().Throw().
Anyways, hope that answers your question.  If you do have any further questions/issues please let me know we'll see if we can help you out.

Thanks again, that answers my question.


[Prefix] Work around the fact Pkg.add modifies dependencies in-place

CC: @Alexander-Barth.  Fix https://github.com/JuliaPackaging/BinaryBuilder.jl/issues/1210.

Thanks a lot!


Supporting custom cultures that are not pre-defined in options.SupportedCultures

Following this StackOverflow question:
http://stackoverflow.com/questions/36590969/enabling-client-based-culture-in-asp-net-core
It's currently impossible to let the CultureInfo be determined automatically from what the client specify in the Accept-Language header (as it used to be using <system.web.globalization enableClientBasedCulture> in Web.config).
The way it is now, I have to pre-register all the cultures I'm planning to support, which renders  AcceptLanguageHeaderRequestCultureProvider quite useless.
The following is the culprit:
https://github.com/aspnet/Localization/blob/b52e33caa7927093dc3ec540fd3282f4f69ae169/src/Microsoft.Extensions.Globalization.CultureInfoCache/CultureInfoCache.cs#L34

I think after design change that discussed here #111 we should to register the supported culture instead of looking into Culture Info list which is removed after this change

@hishamco this change is already done, it's in rc1-final, the version that we're having trouble with

I know @omuleanu, but while web.config is no longer used, is there any reason to have such enableClientBasedCulture?!!

@hishamco yes, a lot of people need that, basically everyone that was/is using culture=auto in web.config and want the same behavior after porting their app to the new asp.net
I need it, to automatically get the user's ShortDatePattern, ShortTimePattern, DateTimeFormat, NumberDecimalSeparator, TimeSeparator

There 're a lot of changes in ASP.NET Core, and there's no guarantee that every feature before will be the same in the new world, nothing but what if you create a culture info list from Accept-Language header and pass it to RequestLocalizationOptions this way it collect the cultures automatically instead of hard coded.
I'm not sure if there's a change in the future to support this out of the box, @DamianEdwards any idea sir?

This is currently by design in ASP.NET Core for the reasons mentioned in https://github.com/aspnet/Localization/issues/111#issuecomment-209539299.
If we do this, it would most likely be a different middleware, or perhaps an option on the current middleware, but it would have negative performance implications.

@Eilon

it would have negative performance implications.

Why? Can you please elaborate?

@chaim770 I go into more detail in https://github.com/aspnet/Localization/issues/111#issuecomment-209539299. The key reason is that ASP.NET has to cache every culture, so it's a trade-off between not caching and having slow performance, or caching but having the cache grow infinitely. Neither is a good option, so we chose to cache, but to limit the size of the cache by requiring apps to specify which items can be cached.

@Elion IMHO if the Accept-Language sent with tens of cultures, typically you’re only interested in the first one for setting the language as that’s the primary language. In this case we avoid the performance impact. If it's need I can write a simple middlware in my repo or in the entropy repo to prove the point

That's not the point. The issue was a single client sending lots of requests (000's) for different cultures. Creating culture objects isn't cheap so we avoid doing it unless we need to. Culture works differently on .NET Core than it did in .NET Framework on Windows, where the list was fixed based on what the OS supported. That said, the logic in this middleware is pretty trivial, and if an app wants to have the format culture set to whatever the client asks for it's very easy for the app to add that custom logic in a simple middleware.

I agree with you that creating a culture object isn't cheap, but what I suggest is a workaround to migrate his old ASP.NET Application to ASP.NET Core 😄

In our multitenant application, a tenant can add a new language from UI and edit localization texts for it. But the tenant can not switch to the new language unless we start IIS (we definetely don't want that). I think this is a very common case and there should be a built-in solution.
Thanks.

As I can see here https://github.com/aspnet/Localization/blob/dev/src/Microsoft.AspNetCore.Localization/AcceptLanguageHeaderRequestCultureProvider.cs#L42-L47, we are interest to the top MaximumAcceptLanguageHeaderValuesToTry even the client has tens of cultures, so why this has a performance impact?!!

@hishamco generally speaking, accepting unbounded inputs is a bad practice, whether for perf or security.

Either ways the AcceptLanguageHeaderRequestCultureProvider accepts the user cultures that set via Accept-Language header, whether they are correct or not, so if AcceptLanguageHeaderRequestCultureProvider is the winning provider, after that we set the current culture if its correct or fallback to the default culture.
What I mean in my last comment is we can consider the provided culture if it's correct while we care about the top 3 which is the default value
Regardless of what I wrote before while the aim of this issue is Supporting custom cultures that are not pre-defined in options.SupportedCultures, so we can go further by allowing the devs and applications authors to provide a custom cultures via configuration file, using Configuration & Options APIs, like what we have seen in EF, in this case we reduce (or eliminate) the impact because these cultures values will provided from the application itself not the end users themselves


[feature request] support a comment command like "/assign" to assign issue to commenter

Why you need it?

This is helpful for the contributor to assign and anchor the issue.
How it could be?

Other related information

This is a good feature request. While could github support assign an issue to a github user who is not currently in this org?

I tried to fix this in https://github.com/pouchcontainer/pouchrobot/pull/73

The new robot has supported this feature. While I am not sure if this is still only supporting assigning members in this repo.
But you could have a try, and please let me know the result. Thanks a lot. @xiaoxubeii


I/O interface cape for the bone.

Not sure what all was exspected for this one.
Comments @jakunesh ?

I believe this in integrated into the ADC cape created by @jasteve4, also complete


Add support for TypeScript Axios

Hey! We've been using our own Axios alternative to the fetch codegen for ~2 years. I did my best to port it to this project's setup. The readme probably needs some love, but yeah, we love this. With the way we do the generation, we output a single axios instance which we then add interceptors to for things like automatic logout and auth headers. This then is imported to all of the data fetches.
Anyways, thank you for porting this to Node.js. Swagger-codegen is a beast to work with. The DX of this project alone is worth it.

Only thing I could not figure out was why all the classes are lowercased

LGTM! Many thanks, and for the kind words. Did you want to update the README.md and maybe bin/checkTs.sh in this PR or get it merged now and you or I could follow it up afterwards?


#111 Add the supporting of Visual Studio Test Platform

Move to the project model of VS 2017
Create the test adapter for Visual Studio Test Platform

@NikolayPianikov this is great work and I appreciate the effort, but this wasn't the approach we were planning on taking with this. If we update this project this way, it will break anyone using the old project.json format. The main issue though is that our current VS adapter implements the required interface, it just needs to be updated to support .NET Core.
My latest thinking is that the nunit.portable.agent isn't the best approach either. It duplicates much of the code in the Engine such as filters, a driver, aggregating test runs, etc. I have been wavering between adding the functionality to the portable agent, or using a .NET Standard version of the engine.
I am open to discussing or help with the project, but I am not sure this is the right place to be doing the work.

Also, notice in the article that you linked to, neither xUnit nor MSTest converted their dotnet-test-* adapters to support the new (old) adapter API, but instead extended their original adapters.

Ok
I understand your point. I just supposed that it is a main direction how NUnit will be developed for .net core (by the way this adapter also supports and other frameworks)
I believe the this is very promising and quite extensible approach for CI. For example we have TeamCity logger which works for all test engines and user should make a minimum efforts to have a CI integration. Also we are planing add some other abilities like a reordering of tests, a gathering of the code coverage, unit tests for memory consumsion and so on. And I am looking forward when we will have a test adapter supporting Visual Studio Test Platform. But I wanted  to note that this PR is quite simple, was tested by me during some time and it is suitable for us :)

So what's the status?

Could we make a fork of this library based on @NikolayPianikov with the needed changes?

I am closing this pull request. We already have a working copy of the proper adapter at nunit/nunit3-vs-adapter#313 and you can track progress at nunit/nunit3-vs-adapter#297. I also put a very initial demo project using the adapter at https://github.com/rprouse/NUnitPlatformTests
I am having trouble getting AppVeyor to build the adapter using VS2017, but other than that, it is very close to ready for an alpha release.

BTW, @NikolayPianikov if you want to help out in the other adapter project, I could use the help 👍


Browser tests are inconsistently failing due to dynamic istanbul import

There are a few PRs currently failing on CI due to the failure to dynamically fetch istanbul for code coverage. This doesn't happen consistently though.
Here are a few affected PRs:

https://github.com/FuelLabs/fuels-ts/pull/2600
https://github.com/FuelLabs/fuels-ts/pull/2601
https://github.com/FuelLabs/fuels-ts/pull/2602
https://github.com/FuelLabs/fuels-ts/pull/2608

Bumping priority to p0 as it seems to affect everything else. cc @nedsalk

I see that some of the CI jobs are now passing upon re-running the jobs, so the PRs in my description may become outdated.


StateNotifierProvider unable to use async and await for FutureProvider

Unable to call the FutureProvider inside StateNotifierProvider there is no option for sync and await
final settingControllerProvider = StateNotifierProvider.autoDispose<SettingController,SettingState>((ref) {

  final settingService = ref.watch(settingServiceProvider.future);

  final controller =  SettingController(settingService: settingService, state: const SettingState())
  controller..getThemeMode()
    ..getLanguageCode();

  return controller;

});

You should await the future instead your StateNotifier
see https://github.com/rrousselGit/river_pod/issues/57

@rrousselGit  sorry that is not related  to my question .How can we await the future in StateNotifierProvider
StateNotifierProvider.autoDispose<SettingController,SettingState> i have passed SettingController and SettingState. I want to await the FutureProvider in StateNotifierProvider

also noticed this problem. Although it can be solved by other methods, it is the easiest and clearest to use it directly.

@xxmn  how did you do it, i found  FutureProvider is useless with StateNotifierProvider it does not work , if you want to use StateNotifierProvider then only option is to use Provider which is not always the case  like with shared preference. If you have a solution please post it here


Xml api

I've redone the layout as per CCP FoxFour's comments. Added endpoint documentation for

APIKeyInfo
CallList

Does this replace #16, or supplement it?

It's a replace for the AccountStatus endpoint as per FF's comments. It also adds new docu for two other endpoints, APIKeyInfo and CallList, following the same layout rules.

Will try and review this a bit later today. :)

Bah, missed that one when fixing up the tabs.


Update get-started-app-chat-template-langchainjs.md

Corrected GitHub repository name as it was pointing to wrong repository

@diberry - In this repo, the PR review team takes the author's approval as a #sign-off. If additional changes are needed, can you open a new PR?


fix: #341 Correcting Hint Effect layer not activating / deactivating

In Effect, the hoverEffect boolean was being checked as a prerequisite to enabling visibleToMouseEvents. During the refactor in bd08f8ce208a2b8e626d1e5f467beb016ac93360 this check was moved. It now happens before anything that can set hoverEffect to true, and in effect evaluates to always false.
This change drops the if check entirely and moves enabling the visibileToMouseEvents flag to Effect#enableHover(). Not sure if that's where you want it, but it seems reasonable.
===
This also corrects a check in the Hint effect itself. When the Hint effect deactivates, it checks if there is exactly one child, and if so, hides the hint panel. I do not know the cause of this one, but there were zero children at this check. (I assume some other code changed that cleaned up the children).
This was changed to check if there is one or less children as a condition to hiding the hint layer.
===
Normally I'd like to put these fixes up separately, but since I went in to fix the hint layer because of the first bug, and then discovered the second one, I'd rather commit it together and put the hint layer back into a working state.
===
It is worth noting that if a hover effect is removed from the element, I think the visibleToMouseEvents flag will remain set. That might be a separate issue where we apply a check to see if visibleToMouseEvents was set exclusively because of adding a hover effect. Uncertain if this is required though.

Please give me some feedback if there are concerns or changes around the content of this PR.

Everything looks good, your branch builds fine with a fresh 'mvn clean install'
I'm having issues running tests at the moment... weird classpath errors I'm not willing to solve right now.
Were you able to run any tests and verify the hover effect is working?
If you can, try testing it in a couple of the big demos (AllExamples, AllControls, etc).

I have tried running the samples in general and they are fine. (To a given point: out of the box, the libgdx sample works. With or without this change, neither the JOGL or Slick demos work for me as-is).
However, I don't think these demos are helpful here. I don't know them (or the Nifty code) at all well. From what I can tell with the right searches, the only place a Hint is defined for use is in the MenuButtonControlDefinition class. I can see this class registered by the ControlsDemo, but I cannot find a reference to it in any Nifty screen xmls (and it seems there are no ScreenBuilder examples at all).
So... yes the demos work, but there are no demos for hints (to the best of my knowledge). I know it works (now) in my own project (because that's how I found the break on upgrading from 1.3.3 in the first place).

The ControlsDemo does use the Hint effect to display a Hint for the top menu buttons. I've checked your commit with that example and it works for me.
I'll apply this merge request now. It looks valid to me. Thanks for figuring it out! :smile:
I think what Martin tried to do with his original change was that any element you apply a hover effect to should automatically be visible to mouse events. Otherwise the hover effect would not work at all unless you manually set visibleToMouse to true too.
But I agree that this didn't work as expected and your change actually makes it work again.
I'm not sure about the checking of the hintLayer children count though but I think it does no harm so I'm ok with that as well.
It would have been nice if you could have added a SSCCE that reproduces the issue and shows that the fix actually fixes the issue but besides that it looks ok to me!

His change worked great actually, but a later refactor changed the ordering of the code which prevented the layer activating.
As for the hintLayer children count, I do not know that area well at all. My best assumption there is that if it only has one hint on disposal it thinks the layer can do. But when I was stopping there with a breakpoint it was routinely 0. I imagine the hint itself was being cleaned up elsewhere (perhaps as a result of another refactor).
What manner of SSCCE would you have liked here? An extra example showing off just a hint working? A gist / link / repo of an SSCCE outside the project? I know how I'd build one, just not sure how you'd want to receive it. This may not be my only contribution, so I'd like to learn and work within your patterns in future.

In the best case a SSCCE would be so small that it could fit into the pull request comment. I mean here on github not the actuall commit comment of course :wink:
It could depend on the NiftyExampleLoaderLWJGL or so. That would be okay. Just anything that would make it simple to copy and paste it somewhere and execute it. Just a dedicated example Main class or ScreenController that reproduces the issue in question. In your case yes, a hint example showing the hint not working correctly without your fix.
That being said, we've been discussing a dedicated nifty-sscce repository (or similar) for such things.
I have locally created seperate Maven projects for some of the issues but they are currently not commited/pushed somewhere. Having a dedicated repo would allow users to contribute example code with resource files too if necessary. But right now we don't have that yet but I still think it's a good idea!
@bgroenks96 Do we want a dedicated project on github for that? Should I create one? What do you say? I could add the issues I already have projects for as examples too ...

I've generally written my own repos, or clones to do it. However a dedicated repository with some minimal setup might reduce the barrier to entry for good examples. It's all down to how much you want to contributors to maintain :)

@void256 For something like nifty-gui where there is so much room for weird little corner case bugs that require SSCEs to repro, yeah that sounds like a pretty good idea to me.
Could also do it as a git sub-module if you're a masochist :laughing:

New repo added here: https://github.com/void256/nifty-gui-issues
And I've added the two issues I had on my local machine as an example.

Cool. I'm sure that will be useful.


Update broken link

Summary
Fixes a broken link to one of the resources at the bottom

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


Fix TLD for Pow

Fix #711

For more information see http://nic.dev ➡ https://www.registry.google/
.dev is a real TLD now
@tohuw But so is .test a TLD https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains#Special-Use_Domains
What's the solution? .local or .localhost?


Update datetime parser to support negative timestamps

Change Summary
Update datetime parser to support negative timestamps. Negative timestamps corresponds to dates before 1970/1/1.

Related issue number
Close #1600

Checklist

[X] Unit tests for the changes exist
[X] Tests pass on CI and coverage remains at 100%
[X] Documentation reflects the changes where applicable
[X] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)

thanks.


Fix adapter error logs

Purpose

$subject

Codecov Report
Patch coverage has no change and project coverage change: +52.72% :tada:

Comparison is base (1b31b03) 27.38% compared to head (e687bb4) 80.10%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1616       +/-   ##
===========================================
+ Coverage   27.38%   80.10%   +52.72%
===========================================
  Files         250        9      -241
  Lines       29355      548    -28807
  Branches     5110      246     -4864
===========================================
- Hits         8040      439     -7601
+ Misses      21045      109    -20936
+ Partials      270        0      -270

Flag
Coverage Δ

adapter
?

common-controller
?

config-deployer-service
?

idp-domain-service
80.10% <ø> (ø)

router
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 241 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Embeding Issues

In a vanilla world with no modules. This exists for a lot of the embeds

This is a bug with Foundry core that will be fixed in the next release: https://github.com/foundryvtt/foundryvtt/issues/11479


fix: link entry with no validations

fixes: #100

While your solution would work, we can be a bit more precise about the possible field shapes.
Instead of returning just Contentful.Entry, we can return Contentful.Entry<Record<string, any>> since Contentful.Entry expects a generic!

I had it in my had that Contentful.Entry defaulted to that for the Generic, but I guess not. Updated it nonetheless 😃

@AndrewLeedham 🚀 🙇


New Release needed

With the current release using<EMAIL_ADDRESS>this library is only useable in deprecated releases of expo. This requires a new release so expo users can use this library.

Closed as fixed at https://github.com/agencyenterprise/react-native-health/pull/303
Thanks for the contribution!


Exploring Unnecessary Conditionals: List

Component contains conditionals around the item.text parameter - which is a required parameter.
Actions

[ ] Establish if this is superfluous or necessary code.
[ ] Remove if not necessary.
[ ] Ensure testing remains intact / update testing as required.

Removing item.text from the examples breaks the component. This param should be left as required parameter


Create builtin protocol handlers on AtomBrowserContext init

In #2384 , I found that interceptProtocol for builtin protocols only works after at least one BrowserWindow is created.
This PR fixes this, by moving initialization of protocol handlers into AtomBrowserContext constructor, instead of AtomBrowserContext::CreateURLRequestJobFactory (and adding atom::FtpProtocolHandler).

The protocol handlers passed to createURLRequestJobFactory map to a few more builtin schemes (blob, filesystem, chrome-devtools etc) apart from the ones explicitly set. Wouldnt the better thing be to emit app ready event after request context is created ?

We can call GetURLRequestContext before using protocol APIs to force creating protocol handlers, otherwise as @deepak1556 said some builtin schemes still can not be incepted.

Wouldnt the better thing be to emit app ready event after request context is created?

It seems that request context is created on demand, so if you never create a window, the request context will never be created.

Closing in favor of #2465, still thanks for the contribution!


Cannot install git  on ubuntu 24.04.1

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 24.04.1 LTS
Release:        24.04
Codename:       noble

$ sudo uniget install git --reinstall
 INFO  Uninstalling git
 WARNING  Unable to find manifest for git
 INFO  Installing git 2.47.1
 WARNING  Unable to install git: failed to process item through callback: ExtractTarGz: Remove() failed for TypeLink: remove usr/local/bin/git-receive-pack: no such file or directory

That's a bummer, I'll look into this!


:bust_in_silhouette:

This looks good but I'd prefer to keep it coupled to the node module. I added it as a post install script over at https://github.com/cfpb/hubot-acrogov/pull/3.


Bug fixing multiple (to) value error

Fixed multiple to value error. Error was happening at HRS 412:5A-300 and anywhere there was a char in the section number

it should keep the article number in the section number.
ex.
...
{
"name": "Reciprocal beneficiary family coverage defined; policyholder and employer responsibility for costs; availability",
"number": "10C-412"
},
"name": "Repealed",
"number": **10C-**501
}
...
There may be multiple section 501's thats why I need to have the article number as well. This only applies to chapters that contain articles.


[Bug]: Error github action during shopify hydrogen deployment

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Hydrogen custom storefront
Expected behavior
The actions should succeed
Actual behavior
After merging the pull request created from the shopify bot the github action step "Build and Publish to Oxygen" fails.
Verbose output
Run npx shopify hydrogen deploy --build-command "yarn build"
  npx shopify hydrogen deploy --build-command "yarn build"
  shell: /usr/bin/bash -e {0}
  env:
    SHOPIFY_HYDROGEN_DEPLOYMENT_TOKEN: ***

  ERROR Raw mode is not supported on the current process.stdin, which Ink uses
The above error occurred in the <SelectPrompt> component:

       as input stream by default.
    at SelectPrompt (file:///home/runner/work/tooa-app/tooa-app/node_modules/@shopify/cli-kit/dist/private/node/ui/components/SelectPrompt.js:12:25)
    at App (file:///home/runner/work/tooa-app/tooa-app/node_modules/ink/build/components/App.js:18:9)

React will try to recreate this component tree from scratch using the error boundary you provided, InternalApp.
       Read about how to prevent this error on
       https://github.com/vadimdemedes/ink/#israwmodesupported

 - Read about how to prevent this error on
   https://github.com/vadimdemedes/ink/#israwmodesupported
 - value (node_modules/ink/build/components/App.js:46:31)
 -  (node_modules/ink/build/hooks/use-input.js:34:9)
 -commitHookEffectLis (node_modules/react-reconciler/cjs/react-reconciler.devel
  Mount              opment.js:14778:26)
 -commitPassiveMountO (node_modules/react-reconciler/cjs/react-reconciler.devel
  Fiber              opment.js:16609:11)
 -commitPassiveMountEffect (node_modules/react-reconciler/cjs/react-reconciler.
  _complete               development.js:16569:9)
 -commitPassiveMountEffe (node_modules/react-reconciler/cjs/react-reconciler.de
  ts_begin              velopment.js:16556:7)
 -commitPassiveMountE (node_modules/react-reconciler/cjs/react-reconciler.devel
  fects              opment.js:16544:3)
 -flushPassiveEffect (node_modules/react-reconciler/cjs/react-reconciler.develo
  Impl              pment.js:19182:3)
 -flushPassiveEff (node_modules/react-reconciler/cjs/react-reconciler.developme
  cts            nt.js:19127:14)
 -performSyncWorkOn (node_modules/react-reconciler/cjs/react-reconciler.develop
  oot              ment.js:18184:3)

Reproduction steps
Run the github actions to deploy on oxygen
Operating System
github action
Shopify CLI version (check your project's package.json if you're not sure)
latest
Shell
No response
Node version (run node -v if you're not sure)
v20
What language and version are you using in your application?
No response

Thanks! Unfortunately that doesn't say what version of cli-hydrogen you are running. What does your package.json say for that dependency? And what is committed as the version to your lockfile?

We are using cli-hydrogen v4.0.3.
I've updated the dependency to the latest version (v8) but now we have another problem, we need to update remix to v2 because the cli requires it.
Is there a guide to migrate our code base from remix 1 to remix 2?
Thank you

Hey @bitforcesrl, please follow this and turn on all the v2 future flags in your project https://github.com/Shopify/hydrogen/discussions/739
Since your project is quite behind, I wonder if it is better to just regenerate a new project and copy your existing project into the new project. Your project is most likely require a very strict dependency between all the Remix, Shopify package versions and if you bump any package's versions, the project might not even run. Since Hydrogen v2023.10.0, Remix becomes a peer dependency along with many other Remix and Shopify packages ... and trying to carefully upgrade your project through all of these changes would be challenging.
We introduced a h2 upgrade in 2023.10.0 cli command that should work retroactively if you can get your project to Hydrogen 2023.1.0. Maybe give this a try? but only run this command after you have turn on all v2 future flags.

Thanks for the advice. The project it's quite big.
It's deployed in a capacitor app on android and apple stores and it runs code to control a robot machine via bluetooth that makes ice cream. Plus in the app there are pages that show products that are on the shopify e-commerce.
Migrating it to a new project structure will be challenging too.
when the current git hub actions will be deprecated?
https://www.tooa.com/en/products/macchina-gelato-bupt0000

when the current git hub actions will be deprecated?

No immediate plans to remove the action but important to note that it won't be receiving any new features. For example, end-to-end testing with authentication bypass tokens is only available through the updated cli-hydrogen package.


Week 6 ready to review

Week 6 first draft is now ready to review. I need as many people as possible to tear this apart as much as possible as this is one of the weeks that I won't be around (and I suspect neither with @bjmorgan).
Please work through it and feel free to make pull requests improving language and how the exercise is scaffolded. If you have any questions drop me a message.
Additionally I go on holiday on Saturday so the chances of doing major changes from then onwards are slim.
@j-m-dean @mjclarke94 @alexsquires @symmy596 @LMMorgan

Just so you are aware, this is meant to be difficult. My hope is that it will keep those that are good busy for the three hours and it will make those the struggle work on it during the week 7 "free-time" session.
I will provide a worked example in Week 8.

From @j-m-dean: a flow chart to explain the MCMC algorithm might be useful

Some changes in #123

More changes in #124


Can i preload data?

When scrolling down or up, i need to preload data before the object gets in to view.
If i use offset:100px, it load after object gets in view by 100px. If i use negative offset, it does not work.
As I understand, jquery.inview plugin can do that if i need to preload images or something else.

I use this config :
in-view-options="{offsetTop: '-400', offsetBottom: '400'}"
and it works for me.


Not work with smartphone Chrome Apple/Android

Hi, i test jeeliz with my smartphone (Iphone) and not work.
i use google chrome.
Works well with Safari...
you can fix the problem on Chrome?
In chrome://flags is not present Enable webgl
*the demo doesn't even work VTO Widget
Thanks

Duplicate of #95

ok thanks... how to do it in android?
with android use chrome and not work...egual firefox.
show request open camera, and not work.
Thanks
Il giorno gio 26 set 2019 alle ore 16:14 Bourry Xavier <
<EMAIL_ADDRESS>ha scritto:

Closed #129 https://github.com/jeeliz/jeelizFaceFilter/issues/129.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jeeliz/jeelizFaceFilter/issues/129?email_source=notifications&email_token=AMD43OJPKX6COGBGRWZS6GTQLS7UBA5CNFSM4I22OQTKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOT3PWL7Y#event-2665440767,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMD43OLHDYMAS6LFYBB7RVLQLS7UBANCNFSM4I22OQTA
.

depends on the phone.
First close all apps using the camera and retry.
Then i can do nothing with such information: "It does not work on mine :("
Please provide informations required here: https://github.com/jeeliz/jeelizFaceFilter#compatibility

ok, thanks for the quick replies
Il giorno gio 26 set 2019 alle ore 16:34 Bourry Xavier <
<EMAIL_ADDRESS>ha scritto:

depends on the phone.
First close all apps using the camera and retry.
Then i can do nothing with such information: "It does not work on mine :("
Please provide informations required here:
https://github.com/jeeliz/jeelizFaceFilter#compatibility
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jeeliz/jeelizFaceFilter/issues/129?email_source=notifications&email_token=AMD43ONGHRW3OBMEO7AI7D3QLTCAPA5CNFSM4I22OQTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7VZGRA#issuecomment-535532356,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMD43OKSUQ22MER25UX3HWDQLTCAPANCNFSM4I22OQTA
.

BREAKING NEWS: Camera access is enabled on IOS14.3 which is released this Monday ( December 14th ). So FaceFilter will work on Chrome, Firefox, Opera for IOS, and into WKWebviews embedded in native apps.


Less background activity opacity

If some one click ActionButton, then background activity opacity will be less for read ActionButton.item text and it will more beautiful.

sry I didn't understand what you mean


binary op not implemented: Pow

how to reproduce
try to compile
MAX_TCP_PORT = (2 ** 16) - 1

expected result
it compiles
actual result
line 3: binary op not implemented: Pow

https://github.com/MirkoDziadzka/grumpy/commit/9ad4a5ad148ca7b356750b15a114ba710d6739f8 solved my immediate problem. But the implementation is neither complete, nor necessary correct or tested

Thanks, I had same problem and your patched helped. Let's hope we will see it in upstream version soon.

Please note that this

works only for integers, not long integers or floating point numbers
works only if the result can be converted into a signed 64bit number (if the result is too big, you will get negative numbers, try 2 ** 64)
may loose precision for large numbers

So it is by no means a fix for the problem, only a hot-fix for some cases which solved my needs.

@MirkoDziadzka Thanks for the PR. I commented on it. I'm fine with an incomplete implementation but I just want to make sure we fail hard when we encounter an overflow situation rather than silently giving bad results.


CHanges made in configuration to allow user to change locale.

One more properties file added for Hindi India.

Hi,
I am trying to get internationalization with Hindi (Indian language), but I am getting questions marks. Values of given properties are as follows:
subscription.email=ईमेल
subscription.type=प्रकार
subscription.submit=प्रेषित करें!
subscriptionType.ALL_EMAILS=सभी ईमेल
subscriptionType.DAILY_DIGEST=प्रतिदिन का पत्र
Could you please help get me desired results? Locale for Hindi is hi_IN.

The JavaDoc for java.util.Properties establishes that the default encoding for Java .properties files is ISO-8859-1 (latin1), whatever the operating system and its default encoding.
You should therefore use Unicode escapes (\uXXXX) for your non-ASCII characters in the .properties file.

Thanks Daniel, however I am doing the same thing but no luck. Could you please check out this branch, place hindi values of property keys in property file (as given in my previous comment) and run the code to see if you get correct text in browser. Please

All that was needed was to add a Messages_hi.properties file with the unicode-escaped characters, and then switch the encoding of the pages being returned (at the ViewResolver) to UTF-8, because the default is ISO-8859-1 (Latin 1, for European languages), and obviously this encoding does not contain the right codes for Hindi language.

See the changes made here: thymeleaf/thymeleafexamples-thvsjsp@5fe0514c96d8f2d79891350b8aedff603244dac5

Thanks @danielfernandez It would be great, if you can merge these changes with master. Lot of Indians are working in IT sector and lot of work is happening in hindi language. Your code and comments will be very useful for all of them.


Feature request - list routes in lagoon PR deployments UI

Currently PR environments do not list their routes like the dedicated environments do on the overview tab in lagoon
example url https://ui-lagoon-master.ch.amazee.io/projects/ipsum/ipsum-pr-58

This usually happens when there hasn't been a successful completed deployment yet.
The routes only get updated once a deployment has completed.

Ah you are correct.  However, (maybe this is a separate subject) when there is an error in post-rollout the deployment is marked as failed and the route is not shown even though the route exists and it did deploy.

I would print the route if the route exists, regardless of what happened in post-rollout.

However, (maybe this is a separate subject) when there is an error in post-rollout the deployment is marked as failed and the route is not shown even though the route exists and it did deploy.

@jordotech you are correct, there is a case were the routes and pods/containers are created but the post-rollout fail.
Lagoon only checks if the routes exist or not if the build is fully successful. We could change that code though that Lagoon checks the routes no matter if the build fails or not and then the routes would appear in the UI for a failed build.

That would be very helpful.  On a larger subject, I think many would benefit by there being a 3rd result that reflects reality - "Deployed with issues" or something like that.  We'll get a slack notification that the deployment failed which isn't true, it did deploy in reality.  Take this example - on production there are new Drupal modules being added in a deployment but in post-rollout drush cim fails.  We all get notified that the deployment didn't go through but in reality, production is running with the new code.

This has been resolved in a more recent release


Support for pep 582

Discussed in https://github.com/microsoft/vscode-python/discussions/15952

Originally posted by thernstig April 14, 2021
Hi! A new, promising Python dependency management tool has entered the market: https://pdm.fming.dev/
It supports pep 582 and has a section to describe how to set it up: https://pdm.fming.dev/#vscode
Would it not be better if this extension has information about this in its documentation for how to setup a project that utilizes pep 582?

cc @frostming

Thank you to everyone who upvoted this issue! Since the community showed interest in this feature request we will leave this issue open as something to consider implementing at some point in the future.
We do encourage people to continue 👍 this issue as it helps us prioritize our work based on what the community seems to want the most.

FYI, there is another new promising Python dependency management tool using PEP 582: https://github.com/David-OConnor/pyflow

The Python steering council announced the rejection of PEP 582 today, so we won't be implementing support.


@zuvaai/document-viewer not found

When installing the dependencies @zuvaai/document-viewer is not found. How can I install this so that I can carrying on with the example provided?
npm ERR! code E404 npm ERR! 404 Not Found - GET https://registry.npmjs.org/@zuvaai%2fdocument-viewer - Not found npm ERR! 404  npm ERR! 404  '@zuvaai/document-viewer@*' is not in this registry. npm ERR! 404  npm ERR! 404 Note that you can also install from a npm ERR! 404 tarball, folder, http url, or git url.

Hi @syatom, we have updated the visibility of the package so that it is now public.
You will also need to update your .npmrc file to be able to install packages from our organization, eg.
//npm.pkg.github.com/:_authToken=TOKEN
@zuvaai:registry=https://npm.pkg.github.com/

You can find more info about this in the GitHub Packages documentation
Hope that helps!

In your example you have "@zuvaai/document-viewer": "0.0.1" in the package.json as a dependency but I cannot get it to install. Can you provide an example on how to get this package installed.

In your example you have "@zuvaai/document-viewer": "0.0.1" in the package.json as a dependency but I cannot get it to install. Can you provide an example on how to get this package installed.

We've added more detailed steps to the tutorial regarding how to create a personal access token and set up the .npmrc file in order to be able to install this dependency from GitHub Packages.
https://zuva.ai/documentation/tutorials/displaying-documents/#requirements-1

Thanks have managed to get it installed now following the updated documentation.


Can we expect standard units for all submitted data?

For example, will winds always be m/s, etc?
Important for correctly annotating our legends in the UI.

CF compliant just means that the units have to be conformant with the canonical units, so the source data should have units defined, and the UI should check the units and convert if appropriate.


Fix: Sentinel Archetype isn't upgrading Ruffian Rogue armor proficiency

Duplicate of #16296, already fixed for next release


Update gtm.html

Make structured code.

Thanks for your contribution @mithlesh4257. This file is generated by GTM, so I don't think it should be auto-formatted.


double pipe connector is being read as redirection

mevans@localhost $ false || echo fail
fail
parent close pipe 1 failed: Bad file descriptor

crashes

again:
mevans@localhost $ true&&echo success||echo fail
success
parent close pipe 1 failed: Bad file descriptor

This bug has been fixed.


event interface like 'fileBegin' or 'file' can get filename normal but the second args file(fd.File) can get file.name error

Context

node version: 12.18.3
module (formidable) version:1.2.2
environment (e.g. node, browser, native, OS):node
used with (i.e. popular names of modules):import fd from 'formidable'
any other relevant information:

What are you trying to achieve or the steps to reproduce?
This is not a must-have problem,I think it is caused by encoding,the first args filename is native,but the second args file is parsed by our module.
import fd from 'formidable'

...
form.on('fileBegin', (filename: string, file: fd.File) => {
        is_upload_finish = false;
        console.log(`filename:${filename},file.name:'${file.name}'`);
});
...

What was the result you got?
filename:'黄立行_绑��者',file.name:'黄立行_绑架者'
What result did you expect?
filename:'黄立行_绑架者',file.name:'黄立行_绑架者'

Hmm. Ahh wait I'm looking at the v2 canary codebase.
Can you try it? There is rename option. Also, an encoding option.
Another thing is that they may be different things. Looking at the code the filename arg is part.name, and file.name is actually part.filename.
I can't remember clearly now, but I'll jump on coding soon.

form.on(`fileBegin`, function(formName, file) {
    // accessible here
    // file.name (http filename)
    // formName the name in the form (<input name="thisname" type="file">)
    // file.path default pathnme as per options.uploadDir and options.filename
});

So in order to solve this you need to change the formName in the html and use proper encoding for the html like utf-8 if the file is utf-8

form.on(`fileBegin`, function(formName, file) {
    // accessible here
    // file.name (http filename)
    // formName the name in the form (<input name="thisname" type="file">)
    // file.path default pathnme as per options.uploadDir and options.filename
});

So in order to solve this you need to change the formName in the html and use proper encoding for the html like utf-8 if the file is utf-8

upadated readme

upadated readme


[Select] component label not shrinking up when matching option is created lazily

Select Component ( outlined and native=true) - the label does not shrink and move up when the options are lazy-loaded and the value is already set.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

i have a select component (outlined variant and native=true) with a set value (example value="newvalue"), but the option is not present yet - for whatever reason, data is being loaded async and options are generated once the data is available. when the option is finally created <option value="newvalue">New Value</option>, the label does not shrink up and shows overlapping with the selected option. once i select a different option, the label behaves properly and shrinks up.
Expected Behavior 🤔

when an option is created lazily that matches the value, the label should shrink up.
Steps to Reproduce 🕹

the demo is from the component demo page forked and slightly edited to show the issue.
https://codesandbox.io/s/material-demo-forked-5c9f1?file=/demo.js
Steps:

the select loads with a value of "newvalue" and 2 options (none of them for newvalue)
click on "click to create options" on the top. this adds new option with value="newvalue" and label="New Label"
the Select updates but the label does not shrink and overlaps the selection

Context 🔦

Creating options lazily from async fetched data.
Your Environment 🌎

`npx @material-ui/envinfo`
browser: Chrome  Version 88.0.4324.96 (Official Build) (x86_64)
materialui: v4.11.1

@rishisharma08 Don't do this, try to always have a matching value. You can add a key to remount the select when the matching option is added. With the non-native implementation, we have a warning that warns when the value doesn't match any option: #18494.

@oliviertassinari changing the key on select works. thanks. appreciate you looking into this.


Implementation of Line graph Transformation

Greetings,
I believe that a transform that manipulates a graph stored Data variable and transforms it to it's line graph can be useful. The Networkx implementation for the same can be found here.
I am working on a regression problem where nodes are featureless and the edges contain a scalar feature (Strength between two nodes).
Going through the documentation, I was not able to find a convolution layer that uses edge attributes, rather than node attributes (I am quite new to the field of Geometric DL, If there is then please let me know) and thus I plan to use Line graph. I believe that there can be many such cases.

Hi, This is a good request and would be a nice contribution to PyG. I plan to integrate it. In the meantime, you can write your own transform in which you convert your graph to the networkx format, call the line_graph functionality and convert the data back. This may not be very fast dependent on your dataset size, but may work as a first starting point. I recommend using this transform as pre_transform.

Hey Matthias,
Thank you, I will do the same.
I am also interested in contributing to PyG and would be glad to implement this as a learning experience.
Please let me know if it is feasible.

Sure, contributions are always welcome :) I actually think this can be implemented within a few lines of code using just PyTorch and the edge_index tensor. Let me know if you need any help.

Hey Matthias!
I have implemented the same for the Directed graph, I will do this for undirected along  with the tests and send a PR by this weekend.

Any update on this?

Hi @pgtgrly,
I'm finding myself needing a line_graph transform as well.  I'm happy to help if you've started, or start on it if you haven't.

Hey @rusty1s @kolia,
I have implemented this for directed graphs, I need to do it for undirected graphs.
I will be sending a PR for the same by this Thursday/ Early Friday. I hope that is alright?

Sound good to me, thanks for putting in the work.  If you want early feedback on the directed version, i'm happy to help.
For now i'm doing to_networkx and back as @rusty1s suggested.

I have created a PR #165 as implementation of Line Graphs


fixed bug in maxItemCount propagation for Order by queries

This PR
-Propagates options to document producer
-adds test for functionality

Can one of the admins verify this patch?


Save the debug console filter to settings

I'd like to save the debug console filter into the project specific settings.json.

Ideally, this would be a separate filter that can be enabled via a checkbox on top of the one specified by the user.
Use case:
Often, Android apps spam the log and with a complex regex you can filter out everything. However, this regex becomes diffficult to edit on-the-fly. By extracting this regex into a settings variable we wouldn't waste time filtering the logs.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


Height bug in Docker

Expected behavior
Equal height in local environment(windows 10) and in docker environment(stable-alpine), for this element:
<canvas ref="chartCanvas" height="390px"></canvas>
Current behavior
The build in local environment(windows 10), height = 400px

The build in docker, height = 869px

Reproducible sample
https://codesandbox.io/p/sandbox/vue-chart-3-chart-js-issue-template-forked-q5vzkk
Optional extra steps/info to reproduce
Surprisingly, but in reproducible sample the behavior charts are similar to Docker's when opening full-screen
Run docker:
FROM nginx:stable-alpine as production-stage
Possible solution
const calculateCanvasHeight = () => {
  if (chartCanvas.value) {
    chartCanvas.value.setAttribute('height', '160px');
  }
};

onMounted(() => {
  calculateCanvasHeight();
});

But the height will be 365px, not 160px. But this brute force method will help you find the correct height
Context
I tried a simple canvas chart with random data and the height was the same everywhere else .
const chartData = ref(generateRandomData());
const chartOptions = ref({
  responsive: true,
  maintainAspectRatio: false,
  scales: {
    x: {
      type: 'category',
      position: 'bottom',
      title: {
        display: true,
        text: 'Month',
      },
    },
    y: {
      type: 'linear',
      position: 'left',
      title: {
        display: true,
        text: 'Sales',
      },
    },
  },
});

const myLineChart = ref(null);
const chartMill = ref();

const renderChart = () => {
  if (chartMill.value) chartMill.value.destroy();
  const ctx = myLineChart.value.getContext('2d');
  chartMill.value = new Chart(ctx, {
    type: 'line',
    data: chartData.value,
    options: chartOptions.value,
  });
};

onMounted(() => {
  renderChart();
});

// Function to generate random data for demonstration
function generateRandomData() {
  const labels = ['January', 'February', 'March', 'April', 'May'];
  const data = labels.map(() => Math.floor(Math.random() * 50));
  return {
    labels,
    datasets: [
      {
        label: 'Monthly Sales',
        borderColor: 'rgb(75, 192, 192)',
        data,
        fill: false,
      },
    ],
  };
}

// Watch for changes in chartData and update the chart
watch(chartData, () => {
  renderChart();
});

I thought chart.js without vue-chart-3 solved my problem.
And that's why I gave up on vue-chart-3
But I was wrong
chart.js version
4.4.0
Browser name and version
Chrome 120.0.6099.200
Link to your project
No response

The maintainAspectRatio: false option is need in all environments except mine(doesn't matter dev or build)


View Config of a cluster is not available and shows Custom cluster icon on the UI for users with no access to cluster

On 2.6-head commit id: b43e4d9

Disabled RKE2 feature flag
Deploy an RKE1 custom cluster
Add a user as project member of a project in this cluster
Login as this user
Go to cluster management --> CLick on cluster --> Config

Breaking looking for types that used to be readable but aren't anymore... it now goes to Ember, though it doesn't really know what to do with not being able to load the nodeTemplates and such so it shows up as custom...

I've verified this and this is working correctly - passing to To Test for QA to sign off and close.

Verified on v2.6-head 1a57856

Created a custom cluster rke1 as an admin by disabling the rke2 flag from Global settings.
Create a standard user and add the user in the default project as a Project member
Login as the user
Click on the cluster and the config edit page is available
from the cluster management page --> Ellipsis --> View Config --> Custom which lands in the Config page edit page is available