Inferno test 1.1.04 OAuth 2.0 Endpoints in the conformance statement match those from the well-known configuration failed.

Here is the error message received during the test execution:

SMART spec conformance recommends advertising the introspect URL
http://hl7.org/fhir/smart-app-launch/conformance.html#metadata
http://hl7.org/fhir/smart-app-launch/conformance.html#sample-response
Inferno expects that it should not be in the Capability Statement and also it must match the .well-known/smart-configuration response, which are contradictory expectations
https://www.hl7.org/fhir/R4/extension-oauth-uris.html

Why do you say that Inferno expects it not to be in the Capability Statement? Inferno expects the value in the Capability Statement to match the value from the well-known endpoint, which is a requirement in the SMART spec.


Add def to increase time limit for create_indiv_master_table

create_indiv_master_table failed due to a timeout.
Solution:
Create def that will increase the time for the rule by 24 hours if a failure occurs.

Added in commit faa4a86c534ffdb91584e3a024620053393f36e0


[1.2] Fix ODR#742: Add switchDevices/postInstallCommands in the options list of install esx task

Fix this issue: https://hwjiraprd01.corp.emc.com/browse/ODR-742
Actually, This is a change after the workflow engine HA design, previous we did allow all options that passed by user to task, but then we changed to only allow options that in the task options' list.
The exact code is: https://github.com/RackHD/on-core/blob/master/lib/workflow/task-graph.js#L230.
@RackHD/corecommitters @zyoung51 @pengz1

Please hold on the merge, I need to confirm whether this is really need in 1.2.0 branch.

*** BUILD #923 ***


test: Cypress | Replace static with Dynamic waits - Part III

Description

This PR removes static wait from below:
ClientSide/ActionExecution/*** & add dynamic waits as needed in below specs:
- /ActionSelector_JsToNonJSMode_1_spec.ts
- /Error_handling_spec.ts
- /NavigateTo1_spec.ts
- /PostWindowMessage_spec.ts
- /disableJSToggle_spec.ts
- /setInterval_spec.js
- /uiToCode_spec.ts
ClientSide/AdminSettings/Admin_settings_spec.js
ClientSide/AppNavigation/**
- /AppNavigationWithMultiplePages_spec.ts
- /AppNavigation_spec.ts
- /Sidebar_spec.ts
- /TopInline_spec.ts
- /TopStacked_spec.ts

Type of change

Script fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

[X] Cypress CI runs

Checklist:
QA activity:

[X] Added Test Plan Approved label after Cypress tests were reviewed

Summary by CodeRabbit

Tests

Enhanced the reliability of Cypress end-to-end tests by replacing fixed sleep times with dynamic element visibility checks.
Streamlined test execution by removing unnecessary wait commands.
Improved test descriptions and ordering for better clarity and test suite organization.
Updated limited test configurations to reflect the current focus of regression testing.

Chores

Adjusted the build workflow to optimize the test matrix based on the type of GitHub event trigger.

/ci-test-limit

/ci-test-limit

Modified tests all pass Run1, Run2

https://github.com/appsmithorg/appsmith/pull/29582#issuecomment-1856155159 is skipped for CI runs. Will be fixed in one of upcoming PR's. Not an item for this.


Annotation Styling

How can we add annotation with style options such as line colour, width etc.
Looked at Web Annotation Model and came up with this
        var annotation = [
            {
                "type": "Annotation",
                "stylesheet": {
                    "type": "CssStylesheet",
                    "value": ".red { color: red }"
                },
                "body": [{ "type": "TextualBody", "value": "Logo", "purpose": "commenting" }],
                "target": { "selector": { "type": "FragmentSelector", "conformsTo": "http://www.w3.org/TR/media-frags/", "value": "xywh=pixel:4529.12646484375,1530.34130859375,871.17236328125,131.33251953125" }, "styleClass": "red" },
                "@context": "http://www.w3.org/ns/anno.jsonld", "id": "#3e4502d0-923a-11ea-95ff-25ef2ceeaad8"
            }]

but it did not display annotation in a red colour.

I‘m not yet making use of style info in the annotation. But the annotations are rendered as SVG shapes (inside a g with CSS class a9s-annotation). This way you can already override styles in your own stylesheet.
Likewise, I‘m planning to write a guide for this on the  Annotorious Wiki... when there‘s time ;-)

I'm after more flexibility than that.
Use Case

User draws annotation
Custom editor allows user to add comment and specify severity ~ green, orange, red type of system
Annotation is saved and displayed in the severity colour

Yes, also coming :-) RecogitoJS, the text annotation companion project has a concept called formatters, where you can configure a function to emit a specific CSS class based on the annotation. I.e. you can supply a function that looks into some kind of severity tag body and then the annotation would get e.g. green, orange etc. as an extra CSS class & you can attach styles. First, you‘d probably want an extra 'severity widget' in the editor though.
I built something similar for a client for RecogitoJS very recently. We can also talk off-list if you want or have specific integration needs at short time frame.

Here's an example setting the style through css as you suggested. It's a JQuery example, but might go into your Wiki guide.
// get annotation element of type g with data-id of @context.id
var element = $('g[data-id="#3e4502d0-923a-11ea-95ff-25ef2ceeaad8"]');

// get outer rect and set style
var outerRect = element.children('rect').first();
outerRect.css({ stroke: 'red', 'stroke-width': '5px', 'stroke-dasharray': '5' });

// get inner rect and set style
var innerRect = element.children('rect').first().next();
innerRect.css({ stroke: 'white', 'stroke-width': '2px' });

The styles would be applied post render, which works on my test as it only draw a few annotations, for 100's it might be possible to add annotations that are hidden, apply styles, then make them visible?

Regarding custom mods, I'm a single developer start-up with no cash! I'll have just work with it as it develops. Beggars can't be choosers, as they say!

Yes, that’s a good workaround before I can implement formatters.
No worries, I know the situation ;-)


[csrng, dv] Add verification for AES_CIPHER.CTRL.SPARSE countermeasure

The first commit belongs to #16427.

Thanks @ctopal . Yes, I was thinking add some bias towards the AES for which_err_code because there are so many countermeasures behind this one error code.


Feature request - Resize image in k9mail on the fly

Hello
this is only a feature request, not an issue.
There could be an option to resize an added image on the fly to a lower resolution. In the options or in a dialog when I add a picture (JPG etc.).
There is no way in k9mail to do this.
Some email-clients can do this, not sure if it is easy done in k9mail, but it would be extremely useful.
At the moment I use an external app to resize pictures and send them to k9mail then.
By the way, what I dream of is a kind of option to use k9mail as Chat Client, e.g. like WhatsApp, Signal, Threema, etc. Could be done I guess and would be very handy on a Smartphone :)
Environment
K-9 Mail version: 5.010
Android version: CM 13 nightly of 21.10.2016 on Samsung Galaxy S4
Account type (IMAP, POP3, WebDAV/Exchange): IMAP
Thanks.
frank

You're talking about resizing images when you attach them to a new email, just to be clear?

Yes, this I mean. I have most pictures with some 5 MB big ("13 MPX") and as email it is not really useable in this size. Mostly I need only pictures in a low resolution, as in Chat Clients. They resize it automatically.

As for chat clients, nice thought, but e-mail is complex enough ;)

Just a few changes, like the above auto resize or show the mail history as a chat history compactly, and some other things.
I am sure this could be done and this would higher the usefulness of k9mail a lot. On smartphones often a simple chat client is the first choice for fast communication for me, but what can a chat client do that couldn't be done in an email client?
It's p

Sorry, I hit the wrong button :)

Ok. We probably can do slightly better on email threading - there's other issues open for that though.
Let's keep this one focused on the image resizing.

Could it be done? Is it a reasonable feature request?

its not a good idea to make an app do everything.
you should rather use:
https://f-droid.org/repository/browse/?fdfilter=size&fdid=mobi.omegacentauri.SendReduced
or
https://play.google.com/store/apps/details?id=mobi.omegacentauri.SendReduced

I'm in two minds.
On the one hand, image manipulation is not really the job of an email program.
On the other hand, I disagree with the idea that you should need a separate app.
SendReduced is open source. It's Apache2 licensed. There's no reason why we couldn't reuse 90% of the code.
If the maintainers co-operated we could modify the upstream library into a core code module and app module and the core code module could be used directly in K-9. We do something similar to allow K-9's functionality to be re-used.
Even if they didn't we could still maintain a close fork and downstream fixes when necessary.
I think it's a reasonable feature on balance - but it needs developer time to implement.

it can be used for other things, like sharing your images via a messenger or bluetooth. it also can strip EXIF data.
1 app should do 1 thing good, not many things average.

Does anyone on a smartphone attach 5 or more mb pictures??
This would be a rare scenario. When there is no easier way to send a foto than email I nearly always reduce size with another app which makes it more uncomfortable to use k9mail.
And k9mail is a client mostly for smartphones.
And the idea to use one app for doing one thing good can be exactly used here: I will need size reduced images on an app which is optimized for smartphones. This should be then post of the app

the best (ideal) option would be to work together with the dev of SendReduced and define an API, so both apps can work together seamless.
doesn't make any sense that k-9 devs need to manage even more features and keep them up-todate

@cketti : I want to work upon the above issue, but am not able to understand, why integrating the feature into k-9 would be a bad idea. It can be done using a 3rd party library, or developed from scratch.

I don't mind including this functionality in K-9 Mail. However, I'd like to see a UI/UX concept first.
Things to consider:

Resizing takes time. When should it be done? How is the progress visualized?
Some people only want to occasionally resize images. Some people only occasionally want to not resize images. How can we accommodate both groups without asking every time an image attachment is added?
What size should images be resized to by default?
Should there be a setting with multiple options?

I would expect image resizing to be in the sub-second range. I would expect this to integrate neatly with Attachment.LoadingState

I guess it could be done after the user presses send. That way the user can change the default behavior (via a button on the attachment box or something) before the image is resized.

The approach that I was thinking of includes a resize button/option in the attachmentView. It solves 2 problems :

In case multiple images are selected, the user would not get multiple dialogs one after the another.
It will work for both groups of people, those who resize occasionally and those who don't. It will be as easy to use as deleting the attachment.

Resizing would most probably take less than a second, so I don't think we should worry about showing a progress for it.

Also I think multiple default resize options should be given (as shown in above pic). We may add an option for custom size if needed.

I think resizing should be done as soon as user chooses a resize option, instead of resizing after clicking send.

I wish to reuse the existing methods available, so my approach will be as follows :

When a user chooses a resize option a temporary file is created that holds the the resized image.
The current attachment is removed and a new attachment is added with Uri from the temporary file.

Resizing after "user chooses a resize option" implies user interaction. That's not acceptable for users who want to resize images most of the time. User interaction should be the exception, i.e. only necessary if you don't want the configured default behavior.

We can add an option in the global settings for that. User can choose a default resize option (1/2 or 1/4th size) and it will be applied automatically to all image attachments.

Well, yes. That's what my comment implied.
Settings: default behavior
Button on attachment box: override default
Then do the actual resizing after the send button has been pressed. Because only then you know that the user won't change their mind and override/change the resize option of an attachment.

Ok, I misinterpreted your comment. I will start working on it now, and comment here in case of any issue 👍

By the way, what I dream of is a kind of option to use k9mail as Chat Client, e.g. like WhatsApp, Signal, Threema, etc. Could be done I guess and would be very handy on a Smartphone :)
Now, years later, there is something like it, called DeltaChat
That was exactly what I ment!

As SendReduced is not available in F-Droid anymore, here's an alternative as long as the feature is not included in K-9: Imagepipe

Any news about this feature?
Indeed it's much missed, as bigger and bigger picture don't make sense as attachment.
So far, my workaround is to send pictures to myself via chat (Signal), so they get resized... hardly efficient.

Give FairEmail a try!
I use it since years now, paid version, never looked back to k9mail :)

SendReduced is nice and all, but  many users don't go looking for images (especially if you intend to attach more than just images to an email) before composing an email, they start with the email and then attach a bunch of things.
Just to give an idea of how needed this is in the real world: users with limited connectivity or limited/expensive mobile data (in Canada it's ludicrously expensive) or in developing countries routinely dismiss K9 mail and pick another proprietary app (like AquaMail) just because they can't size down the images they attach to their emails, while other apps do. In some countries, like Cuba, until any attachment bigger than 30 kilobytes meant a fortune to them.
For encoding, I would recommend K9 to use MozJPEG, as it's hands down the best "traditional JPEG" encoder out there, it makes traditional JPEG pretty much competitive with WebP in terms of filesizes (and hey, MozJPEG is a Mozilla technology, so that makes a lot of sense for K9 mail becoming Thunderbird on mobile)... the only better format for photos would be JPEG XL, but it's not really possible until the other mail clients, browsers and mobile OSes support it; whereas MozJPEG-encoded traditional JPEG would work everywhere without new decoders.

Was expecting this feature to be built in.
Last time I used k-9 was in Android 2.x and had to drop it over lack of exchange support.
Is it feasible to expect the integration of this feature (and also directly snap, optimize and attach pictures from the attach file menu) in a relatively small time window (considering this feature was requested 6 years ago)?

Meanwhile, there are another few apps like Imagepipe available on F-Droid.. https://codeberg.org/Starfish/Imagepipe.
Perhaps the best course of action would be for K9 Mail to suggest those Apps while attaching images and make the process as easy as possible.. although it is pretty easy already now.
Those Apps have some benefit over a pure resolution reduction/compression, offering cropping, exit tag filtering and more goodies you don't want to reimplement in an email program

Meanwhile, there are another few apps like Imagepipe available on F-Droid.. https://codeberg.org/Starfish/Imagepipe.
Perhaps the best course of action would be for K9 Mail to suggest those Apps while attaching images and make the process as easy as possible.. although it is pretty easy already now.
Those Apps have some benefit over a pure resolution reduction/compression, offering cropping, exit tag filtering and more goodies you don't want to reimplement in an email program

I dont agree: most mobile users simply dont know how to handle files, they just browse image from gallery click "attach".
Any chat app (Signal, Telegram, etc...) will not even ask you and resize image directly (croping/editing is something else) because sending image full size (10MB+) is usually not what you want to do.
K9mail includes external PGP support, while mainstream users never heard of this (beside linux guru), what about having a simple feature like this implemented and gain general user adoption?

On April 4, 2024 10:50:53 AM UTC, Tweepy @.***> wrote:

Any chat app (Signal, Telegram, etc...) will not even ask you and resize image directly (croping/editing is something else) because sending image full size (10MB+) is usually not what you want to do.

Yes and that is exactly what I hate about those Apps. I have a few of them, why should I bother with so many image reducing Guis if a single app can do it. Even figuring out how to send an image in original quality is a hassle in those Apps because each has another way to do it.
Also Email isn't yet another chat App. People expect sending attachments without unsolicited manipulation by App or server, completely different use case and different users.
Email is not a replacement for chat apps and exists for different reasons.
Did you try it.. sharing or picking images through Imagepipe or similar  is in no way difficult.

K9mail includes external PGP support, while mainstream users never heard of this (beside linux guru)

LOL, OT. Mainstream users probably never heard about PGP in first place. And yes.. the PGP integration in Thunderbird was a disaster. Refused to import my keys and never worked for me since than. Perhaps 10,000 open bugs on the subject last I looked. One of the two or three working open source email clients with good PGP support totally ruined.


Conda env config vars are not working properly

I use plugin to manage Conda environments in Python and NodeJS projects.
I need to add node_modules/.bin to $PATH and for that I use `conda env config vars set PATH="/Users/user/Code/data-rc/tree-sitter-sql/node_modules/.bin:$PATH"
This works well in MacOS zsh but doesn't work in VSCode zsh.
MacOS zsh
Works here
~ % conda activate /Users/user/Code/data-rc/tree-sitter-sql/.conda
WARNING: overwriting environment variables set in the machine
overwriting variable ['PATH']
(/Users/user/Code/data-rc/tree-sitter-sql/.conda) ~ % echo $PATH
/Users/user/Code/data-rc/tree-sitter-sql/node_modules/.bin:
/Users/user/Code/data-rc/tree-sitter-sql/.conda/bin:
/Users/user/Applications/miniconda3/condabin:
/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin: ...

VSCode zsh

Doesn't work here
(.conda) tree-sitter-sql % echo $PATH
/Users/user/Code/data-rc/tree-sitter-sql/.conda/bin:
/Users/user/Applications/miniconda3/condabin:
/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin: ...

Hello @ilyakochik Thanks for filing the issue.
The issue is due to current limitation of Python extension not having access to what is inside your initialization script which is modified via your conda activate by conda in the back.
However, we need to make sure you have shell integration enabled in order for any fixes to work.
Can you check if you have shell integration enabled?
FYI there are plans to further enhance this but still requires shell integration to be enabled: There are plans to enhance this detection of environment variable via: https://github.com/microsoft/vscode-python/issues/23159

Also have you tried setting the path directly in your shell? like export PATH=value

We haven't heard back from you for awhile, so I will close this issue, but feel free to come back and ping me anytime.


BUG - FlatList automatically scrolls to first when data is too large in horizontal mode RTL (Android)

[x] Review the documentation: https://facebook.github.io/react-native

[x]  Search for existing issues: https://github.com/facebook/react-native/issues

[x]  Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
System:
    OS: macOS 10.15
    CPU: (6) x64 Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz
    Memory: 448.96 MB / 8.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 12.10.0 - /usr/local/bin/node
    Yarn: 1.19.0 - /usr/local/bin/yarn
    npm: 6.11.3 - /usr/local/bin/npm
  SDKs:
    iOS SDK:
      Platforms: iOS 13.1, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0
  IDEs:
    Android Studio: 3.5 AI-191.8<IP_ADDRESS>91312
    Xcode: 11.1/11A1027 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6
    react-native: 0.61.2 => 0.61.2

React Native version: 0.61.2

Code
<FlatList
    style={{
        flexDirection: 'row',
        marginHorizontal: -wp('3%'),
        zIndex: 40
    }}
    initialNumToRender={10}
    data={this.state.data}
    horizontal={true}
    key={item => item.groupNo}
    keyExtractor={(item, index) => index.toString()}
    showsHorizontalScrollIndicator={false}
    showsVerticalScrollIndicator={false}
    ref={ref => (this.flatList = ref)}
    renderItem={({ item }) => (
        <GroupAyeItem item={item} />
    )}
/>

Steps To Reproduce

Added some data to my FlatList
Add horizontal={true} property to flatlist
Set I18nManager.allowRTL(true)
Set I18nManager.forceRTL(true)
Make my renderItem component extends as PureComponent.
Tested with Real Android Device and Emulator

As you see below when my app is running on RTL direction FlatList automatically scrolls to top/first of the list but LTR direction is OK!
RTL:

LTR:

UPDATE ON THIS ISSUE ! :
onScroll will get called rapidly in VirtualizedList.js:1443 when RTL is enabled without scrolling!

But in LTR :

Any update on this issue?!?

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

This issue does exist yet!

label:disucssion

/label Discussion

Having similar issue with scrollview on android, when size changes (e.g. due keyboard open), the scrollview resets it's position

I had this problem even if there is no resize!
On Fri, 20 Mar 2020, 12:53 djhr<EMAIL_ADDRESS>wrote:

Having similar issue with scrollview on android, when size changes (e.g.
due keyboard open), the scrollview resets it's position
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/26436#issuecomment-601604119,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5GCKOPCK4T6EXDNCMXS3DRIMYZZANCNFSM4IWWVM2Q
.

I have the same exact problem too and couldn't find any fix for it

Any Update on this? Or any alternative approach?

yes facing the same issue, I have found multiple issues for the same error ... the strange thing is that this issue has been around for years now without a solution ....
any idea for a horizontal list views libraries out there that don't depend on the flat list ... I have found this library for vertical list: recyclerlistview and till now it is way way better than  the buggy flatlist and performance is much better

The issue should mention RTL in the title
Probably a duplicate of https://github.com/facebook/react-native/issues/19150

even LTR has the issue in horizontal

It has not fixed yet.

Any update?

I've been looking for any solution about this issue for days so far. I haven't found.

You may follow this, https://stackoverflow.com/a/62066090/10464651
<FlatList
ref={(ref) => { this.chatFlatList = ref; }}
style={styles.flatList}
data={this.state.items}
renderItem={this._renderItem}
maintainVisibleContentPosition={{
minIndexForVisible: 0,
}}
/>

You may follow this, https://stackoverflow.com/a/62066090/10464651
<FlatList
ref={(ref) => { this.chatFlatList = ref; }}
style={styles.flatList}
data={this.state.items}
renderItem={this._renderItem}
maintainVisibleContentPosition={{
minIndexForVisible: 0,
}}
/>

Any update? facing the same issue with Hebrew (RTL language).
Maybe any workaround?

Any update? facing the same issue with Hebrew (RTL language).
Maybe any workaround?

taka a look at this https://github.com/satya164/react-native-tab-view/issues/1068#issuecomment-783233062. It worked for me.

Any update? facing the same issue with Hebrew (RTL language).
Maybe any workaround?

taka a look at this satya164/react-native-tab-view#1068 (comment). It worked for me.

This is unrelated to the current issue.

Facing the same issue here..
Tried both a FlatList & ScrollView, same issue.
https://user-images.githubusercontent.com/32934478/134426408-9b4af234-2f96-4cdf-a52d-55574d48c96d.mov

its really strange this is still a thing

@matinzd hey, did you already find a solution for this bug?i also has the same issue just like you, for me it's from LTR not RTL on android...

I had the same issue. For my case it was caused by getItemLayout() in FlatList. Not using getItemLayout() solved the issue for me. Maybe a correct/precise implementation (calculation of length and offset) of getItemLayout() function is needed.

I had the same issue. For my case it was caused by getItemLayout() in FlatList. Not using getItemLayout() solved the issue for me. Maybe a correct/precise implementation (calculation of length and offset) of getItemLayout() function is needed.

But this was just happening on RTL. It should bahave the same way. Since then, I have changed 2 companies but this issue still exists 😅

https://github.com/facebook/react-native/pull/37651
In rn-tester app this fix works

Experiencing this on horizontal FlatList, even without RTL.
After 10 items the list goes back to the beginning

I'm facing the same problem!
I've tried FlashList, and unfortunately, it acts even weirder when RTL is true.

Has this bug been fixed?

In my case, I was using a custom component both for horizontal & vertical flat list,
<FlatList
data={data}
showsHorizontalScrollIndicator={false}
pagingEnabled={true}
horizontal={horizontal}
keyExtractor={(item, index) => key-${index}}
scrollEnabled={data?.length > 0}
initialNumToRender={3}
nestedScrollEnabled
onEndReachedThreshold={0.8}
initialScrollIndex={0}
onEndReached={() => { }}
showsVerticalScrollIndicator={false}
renderItem={({ item }) => ...)}
/> .
        This line  pagingEnabled={true} was a cause in my scenario, as paging is being true for horizontal cases too.
        I just changed it to  pagingEnabled={!horizontal}
        Maybe it will help any of you guys having the same scenario as me.

I have the same issue for android only, RTL

I have the same issue for android only, RTL

Facing same issue, I found some workarounds which may be helpful

updating react native version (there are some rtl fix pr just merged)
force flatlist to scroll to first index / element (you can also hide the component during this animtion for better ux using entering from re-animated)
using getItemLayour for fixed width (for horizontal)

  getItemLayout={(data, index) => (
    {length: ITEM_WIDTH, offset: ITEM_WIDTH * index, index}
  )}

I experienced this issue after some styling updates. I reverted my latest updates one by one. When I removed the flex: 1 in contentContainerStyle property, it is fixed. I hope this helps everyone experiencing the issue.


[QUESTION]How to access cell values when looping through eloquent model

versions: "maatwebsite/excel": "~2.1.0" , "laravel/framework": "5.2.*"
Expected behaviour
I have an eloquent collection that is used to create the excel file using "fromModel" method. I'd like to set the style of a row if a condition is satisfied when I'm exporting in xls my model.
E.g. "if the date is greater than today, then set bold style to the entire row"
Actual behaviour
Actually I have everything set and I'm trying to add this "feature".

$athletes is an array that contains all the athletes of my team
in F column there is the 'date' that I have to check if it is lower that "now"
Here's some code.

for($i = 2; $i < sizeof($athletes)-2; $i++){
  $sheet->row($i, function ($row) use ($i,$sheet) {
       if( Carbon::now()->gt( Carbon::parse($sheet->cell('F'.$i))->addYears('1')))
          $row->setFontWeight('bold');
   });
 }

Can someone help me to check those values and set the style properly?
Thanks in advice

Not sure what your question is?
Your implementation looks more or less like how it should be implemented. Does it work?


Cache key id prefix

Reference Issue: https://github.com/davidalger/capistrano-magento2/issues/151

[x] Bug fix https://github.com/davidalger/capistrano-magento2/issues/151
[x] Docs added?

Going to take this back and work some more on it actually


Use valid semver identifiers for available_versions

Fixes #290 and starts to fix #140.
The strings we use to identify a specific version now are like 1.8.0-rc2+0.x64, and that then translates into folder names on disc like julia-1.8.0-rc2+0.x64.
The general idea is that we supply two pieces of build metadata in the semver, separated by a .: 1) our own build number (always 0 at the moment, but this allows us to replace all shipped binaries if we need to) and 2) the platform string.
Channel names are unaffected by this, i.e. they still read like release~x64 etc.
@pfitzseb and @KristofferC does that make sense? @KristofferC that still does not use the Version type in the code, but once we have changed the identifiers everywhere, we should be able to make that change also sometime down the road.

Same here, merging so that I can test it better, but reviews after the fact would be greatly appreciated.


Upgrade Avro and ORC to the latest compatible version

Upgrade Avro to 1.11.4 and ORC to 1.9.4
We cannot pick the latest versions of them for compatibility reason:

Avro 1.12.0 has API change and bug, see #13764
ORC 2.*.* drops the support of Java 11

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (b09ab70).
Report is 1123 commits behind head on master.

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (b09ab70). Click for more details.
HEAD has 53 uploads less than BASE

Flag
BASE (59551e4)
HEAD (b09ab70)

integration
7
1

integration2
3
1

temurin
12
1

java-21
7
1

skip-bytebuffers-true
3
0

skip-bytebuffers-false
7
1

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14148       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436        3     -2433
  Lines        133233        6   -133227
  Branches      20636        0    -20636
=============================================
- Hits          82274        0    -82274
+ Misses        44911        6    -44905
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <ø> (-61.75%)
:arrow_down:

skip-bytebuffers-true
?

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


License declaration is missing

The package does not have a declaration of what license applies. Just the name would be enough for my needs, but even that is missing. This makes it impossible to distribute with Linux distributions.
Methods that were tried to find any declaration: locate a file whose name matches /copying/i, locate a file whose name matches /license/, locate a file /readme/ which mentions the word /license/i, locate any non-autogenerated file containing the words /gnu.general/i or /warranty/i.

The ANUPQ 3.2 release is still missing a suitable declaration.

I would also like to know what license this code is distributed under.

+1

I've emailed Eamon O'Brien to resolve this

After discussions with Greg Gamble, Werner Nickel, and Eamon O'Brien, it was agreed to license anupq under the Artistic License 2.0. See PR #58

Thank you for handling this @fingolfin .


Token cannot be unfrozen

Problem description
SR is able to freeze token but unable to unfreeze it - unfreeze button freezes token too.
Step to reproduce
Steps to reproduce the behavior:

Import and publish iRec4
Register registrant (first step)
Open token by SR
Click Freeze button, wait
Click Unfreeze button

Expected behavior
Token is unfrozen
Actual behavior
When you click Unfreeze button - it tries to freeze token again instead of unfreezing it

Fixed here


Cloudflare Tunnel Firewall missing IP

Existing documentation URL(s)
https://developers.cloudflare.com/cloudflare-one/connections/connect-networks/deploy-tunnels/tunnel-with-firewall/
What changes are you suggesting?
Remove <IP_ADDRESS> from region2.v2.argotunnel.com, as that address doesn't get returned in a DNS lookup
Add <IP_ADDRESS> to region2.v2.argotunnel.com, as that address does get returned in a DNS lookup, but isn't currently present in the documentation
Additional information
No response

Thanks for flagging! This is indeed a typo.


No alias functions

Hi and thanks for your contribution.
We can't approve your contribution because it does not add any value.
Feel free to add our coding standard https://github.com/PrestaShop/php-dev-tools and then we will accept the no alias function :)
Kind regards


File manager: update/revert file not always working

Hello, where text/log files (example) are there minimized for a while...eg. you keep the window open, then come back to the browser window, change path and so on...
when you click on Revert File it just returns the usual message but really it doesn't update anything.

Hi,
I have given it a try and confirm that it works for me just fine - the file is getting updated content
Are you sure that you're testing it right?

So, any updates here? It still doesn't work for you?
Any steady steps to reproduce it? Any video-screencasts that you could possibly provide?

I have done more tests and I can always revert the file correctly, disregard of the current directory or even with File Manager being closed.

Is this still an issue for you?

I got it for sure more than one time...I don't know what's the cause at the moment, anyway it seems related to network because I remember a red error message about it on dev console...if it happens again I will let you know

Okay, I will close it for now.

ok, got it again....
screenshot
and also, when it happens if you click to minimize a file window, it completely closes it (disappearing from browser window) instead of minimizing...

maybe an issue when PC waking up from sleep...

Your errors doesn't seem to have anything to do neither with the theme nor with Webmin.
Try disabling extensions one by one to see which extension could cause it. It's know problem.
Although, it's normal to get net::ERR_NETWORK_IO_SUSPENDED "error" upon wake up but I don't have any Unchecked runtime.lastError errors on my MacOS and Chrome 75. The revert functionality continues to work after wake up normally.
It seems like one of the extensions issue to me.
What if you not just try to revert the file but do something else? Change folder in File Manager or open some other module? What happens?

Okay, I have realised why this was happening. Thank you for reporting.
It's fixed now. :wink:


Is it possible to have an extension with debugger contribution along with other contribution types

Hi all,
I have a VSCode extension with debugger contribution and I want to add also custom commands to the extension. AFAIK, extension with debug adapter will be loaded in a separate process and will be activated when a debug session is started.
Is it possible to add custom commands in the extension and configure them also to be activation events?
Is it possible to call these commands from my debug adapter code?
If yes, I guess I have to set the entry point of my extension spacifying the main option in package.json, but after doing it VSCode stops recognising my extension as a debugger when trying to generate default launch.json.

@weinand @isidorn fyi

Doesn't the Go extension do this?

A debugger contribution is not special and can coexist with other contributions.
And yes, the Go extension is a good example for this.
But today it is not possible to call into those other contributions from the debug adapter. This is something we want to support in the future.

Thanks :)


Implement Image class

To put image to a tensor, implementation of image class is needed
Basic Features

Support some image types(jpg, png, gif, bmp)
Load and save images
Resizable and croppable
Rotate, transform
Convertable to tensor(or array)

Additional features

Gaussian blur
Noise
Adjust hue, rgb etc...
ETC...

How does this design work together with video streams? One very important use case of a DL environment is object recognition and tracking, with our without optical flow.
Make certain that the image class works well together with video processing workloads.

There'll be a video class which can return an image class per frame. And the video class will be implemented after this work is completed.

Awesome.
What about optical flow-based video analysis? Do you know what is needed for that use case? I don't know, so asking in earnest.

I'm not familiar with flow-based video analysis. I saw a dataset whose r, g and b represents x, y, z-axis movements respectively. But actually I don't know what is needed for that use case specifically.

We should look into what the best practice is for optical flow. I believe that most insect visual systems are optical flow based, and I would think that this translates to DL for autonomous systems such as drones. It might be a separate cognitive system, so a fancy drone may have a 3D visual system for object recognition and tracking, and an optical flow DL system for control.
Let's make certain that CubbyDNN can support these use cases.

We separate task that implements load images.

@Yoogeonhui: Load bmp and gif file format
@utilForever: Load png and jpg file format


Porting eBook upgrade to .NET 6

There were issues with the feature branch caused from merge conflicts, from other eBook upgrades. The changes were rebased away mistakenly. I fetched @ardalis fork and corresponding branch, and manually rebased from main addressing all merge conflicts locally by hand. This should be everything, but please spot check.
Related to:

#27512
#27548
#27552

LGTM!


Upgrade dependency

Upgrade<EMAIL_ADDRESS>to version

Please ignore this PR and close it. Generated by TestIM


uninstall flow delete all noobaa resources

PR will have:
uninstall flow will delete all the Noobaa resources before deleting the namespace
Noobaa default backing store size change
automatic cache BucakeClass reaction code removes
Noobaa CR will have defaultbackingstore name for Front end team
Prometheus version update
Signed-off-by: Naveen Paul @naveenpaul1

/lgtm

/approve

/retest


Cross-namespace owner reference

Describe the bug
Kafka operator creates a certificate named kafka-ca-certificate in cert-manager namespace. That certificate has ownerReference set to a KafkaCluster object from another namespace.  Also after cert-manager reconciles the certificate and creates a secret, the operator assigns cluster ownership to this secret as well.
This randomly triggers bug https://github.com/kubernetes/kubernetes/issues/65200 .
In my case it caused garbage collector to delete CA certificate, server certificate and pods.
Steps to reproduce the issue:
Install kafka cluster with TLS enabled, wait long enough (in my case the bug happened after 3 weeks).
Expected behavior
Do not set ownerReference on CA certificate and secret.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
The problem is present in both master and 0.7 branches. Tested on GKE 1.14.

I thought this was taken care of earlier, but sure enough I just looked and see where it got left behind for that. I'll open a PR soon because its just taking a few lines out.

Hello,

Hello

Hello, we faced a few days ago a complete Kafka cluster deletion, initiated by the Kub garbage collector.
After investigation, we found that one of the two cluster-scoped ClusterIssuers created by the operator had triggered the Kub#65200 bug.
As stated by @tinyzimmer in #230, that fix still leaves an ownerReference on the ClusterIssuer.
Do you plan to fix the same way the ClusterIssuer objects to avoid complete cluster teardown?

Thanks for reporting this @thomasjardin we are going to fix this ASAP.

@thomasjardin this PR https://github.com/banzaicloud/kafka-operator/pull/579 fixes the error.

Thanks @baluchicken!


Added more job-boards for backend-development

Changes proposed

Added more job-boards for backend-development

Hey @siddhant-khisty, I have made the changes that you had suggested. Can you please review again?


I have some videos that I want to add to the scene, but they will start playing after a certain delay.

Oh, you can use ffcreatorlite for multiple videos, check this example
https://github.com/tnfe/FFCreatorLite/blob/master/examples/video.js


Implement bottom

After the rework of the ordering for top, this was just a matter
of adding a flag telling the minheap which way the values should
be sorted.

One minor question, otherwise +1.  Looks fantastic!

+1, but this does need a CHANGELOG entry under features.


(WIP) drive.clear(path) should remove old entries too

Currently drive.clear(path) only removes the most recent blob, so if an earlier version for the same path exists, that one is not deleted from storage (see the failing test for illustration)
I think the expected behaviour is to delete the storage for all blobs which ever existed on the given path.

This functionality is in fact intended, so no need to modify


fix links to android and ios walkthroughs

The old links linked to mapzen.com which redirects to the landing page of the docs, not the specific articles.

Thanks very much @leftshift !!  🎉


Nested transitions causing elements to animate IN when unmounting

I'm trying to nest transitions so that the background fades in and the text content slides in.
It works find when a component transitions in but when un-mounting, the first transition (fade) leaves correctly but the second transition (slide) enters again.
I have a sandbox, you can see the text slides up from the bottom again when you remove an item, rather than sliding from the center back down - https://codesandbox.io/s/1z30zm6z8l
You'll note that this demo doesn't support adding more than 2 items are i've hard coded the keys :(
It seems it could be related to this https://github.com/drcmda/react-spring/issues/118 but no amount of moving keys around seems to help me.
Any help would be much appreciated. It may be that this isn't even possible with this library?
Thanks,

@mattgreenfield this doesn't look correct to me, the nested transition has no reason to ever go into leave, because the key is always the same. You also duplicate keys, after pressing add three times there are 2 elements with the keyname "two".
Have you looked into alternatives? For instance, the config prop can be a function that gives you the name of the prop that animates, so you can animate the background slower than the foreground.
config={name => {
  switch(name) {
    case 'opacity': return { tension: 10, friction: 20 }
    case 'transition': return { tension: 10, friction: 40 }
  }
}}

Or perhaps keyframes, like this: https://codesandbox.io/embed/zl35mrkqmm

Thanks so much for the tips @drcmda - I've ended up with what I needed https://codesandbox.io/s/q33qnoz4ow
I'll be trying to implement this with our real modal system tomorrow so will see how it goes!

@drcmda  In the example above provided by @mattgreenfield , how to make the same transition work if the component is unmounting on close? currently only the opacity and transform change.

Could you adapt the sandbox with updated dependencies and the props you'd like to animate?

So I want the modal to be in the DOM only when it's open. In mattgreenfield's the element is always present with opacity:0. I want to animate the same props (need similar animation) but the only change is that I want to mount/unmount the component based on state.
Here is the updated sandbox.
https://codesandbox.io/s/qqj1w160xw

I ended up setting a timeout in my closeModal function so that the modal would only be removed from the DOM once the animation had finished - and using a Spring rather than a Transition.
We've hard coded the timeout but I believe there is some kind of onAnimationEnd event that we could be using instead.

@ritz078 for mount/unmount you should use the Transition component, your modal would then enter-in or exit-out and then disappear/unmount


chore(lint, types): fix formatting, add missing types

Overview
Minor refactor that address type and formatting errors.
Test Plan
Before:

After:

Looks there is some difference between what you were running for formatting, and our prettier definition?
https://github.com/react-native-netinfo/react-native-netinfo/runs/4954529476?check_suite_focus=true

@mikehardy
Hmm... I think it may be caused by prettier's lf/crlf. What do you think?

Okay, I get it. I'll try to figure out the cause of the problem

I found what the problem is, but I don't understand how to fix it yet. The problem is that the prettier version is in the package.json is not fixed, in this regard, version 1.19.0 was installed on my PC - there are no errors when checking the tests. I installed the fixed version - 1.17.0, after which I started getting a similar error as in CI. The problem is that webstorm does not format as CI requires:(

Apparently this is some kind of eslint + prettier conflict. I was able to achieve the desired result from the CI point of view, but I'm not sure if it's right from the development point of view. It may be worth fixing versions of prettier, slint and all other plugins for them.


Search Function (not logged in)

Search Function (not logged in)
User Story
I WANT to search for new books to read
SO THAT I can keep a list of books to purchase
Acceptance Criteria
GIVEN a book search engine
WHEN I am not logged in and enter a search term in the input field and click the submit button
THEN I am presented with several search results, each featuring a book’s title, author, description, image, and a link to that book on the Google Books site

This has been completed


status.moov.io

We should setup a status page. It's helpful for us to push out when problems happen.
Hosting options?

github pages (allowed?)
statuspage.io (pricing?)

In a perfect world we would have a slackbot which is pingable to flip status to "we're investigating".

Wishlist:

slackbot "I see XX% errors in the last 5 minutes, post to status?"

after 20mins without us stopping the incident slackbot should post "we're still looking"

we can start/stop an incident from chat
bot picks (or we tell during incident) slackbot to watch metrics, every 3mins the bot can mention "looking better" or "looking bad still"


EMERGENCY: merge doesn't work

When merging an entity into another, server error 500 occurs.

can you please post the url of the entity you were working on and the search term for the one you tried to merge?

occurded eg when merging

Serbia

into

Serbien

Appears to be a self merge, not an issue. Please check if you didn't accidentally try to merge an entity on/with itself.  If otherwise and still an active issue – I am watching this issue here, so please simply post an update and I will look into it @sviatoplok.

Also if not an issue, please report back and I will close it here.

OK, same geonames URI, same geo coordinates, insofar it is a self merge.
The goal of merging was to get the URI of the one entry into the other, similar to problem described in #304
I will try as suggested there.

OK, same geonames URI, same geo coordinates, insofar it is a self merge. The goal of merging was to get the URI of the one entry into the other, similar to problem described in #304 I will try as suggested there.

Could't get the URI of the db entry to be deleted into the db entry I want to keep, because it already exists. Will wait until merge works.

as mentioned here:

as gregor mentioned this was to the system a self merge, because - at least in the serbia case - both entities had the same geonames uri. The only difference is that one uri uses https, the other http. Probably the http uri was introduced before we came up with the uri harmonization script. Problem is the harmonization we are now using. The system harmonizes the http geonames uri to https and retrieves the wrong object from the db. This is related to #337 , as soon as this is resolved the error should be gone.

this issue should be resolved as #337 is fixed in latest

please reopen if thats not the case

I tested it now by merging Serbia into Serbien as suggested by @sviatoplok above, and it seems to have worked.


luci-mod-network: mac rewritten on every edit of a static lease

Every time I edit a static lease, even if I save without making changes, luci wants to rewrite the MAC list.
Steps to reproduce:

Open a static lease for editing.
Save without making any changes.
Note 2 unsaved changes.
Apply.
Repeat above, note same changes applied continuously.

Actual behavior:
Nothing actually changes in the config.
My sample lease is
config host
	option name 'testmac'
	option instance 'dns_iotlan'
	list mac '99:88:77:66:55:44'

and the unsaved changes shows:
uci del dhcp.cfg34fe63.mac
uci add_list dhcp.cfg34fe63.mac='99:88:77:66:55:44'

but this happens with every lease I have.
Expected behavior:
Saving without changes should not show any changes.
Additional Information:
root@router:~# opkg list-installed luci-mod-network
luci-mod-network - git-24.205.48215-4f80a61

root@router:~# cat /etc/openwrt_release
DISTRIB_ID='OpenWrt'
DISTRIB_RELEASE='23.05.4'
DISTRIB_REVISION='r24012-d8dd03c46f'
DISTRIB_TARGET='mvebu/cortexa53'
DISTRIB_ARCH='aarch64_cortex-a53'
DISTRIB_DESCRIPTION='OpenWrt 23.05.4 r24012-d8dd03c46f'
DISTRIB_TAINTS=''

Looks good, thanks.


"Manage Amazon API Gateway" key cannot be found when running with flag --update-iam-policies

cfn-lint version: (cfn-lint --version) 0.48.0
Description of issue.
Running the commands:
pip install cfn-lint
cfn-lint --update-specs
cfn-lint --update-iam-policies

in an empty Python 3.8 Docker container results in the following exception:
Traceback (most recent call last):
    File "/usr/local/bin/cfn-lint", line 8, in <module>
      sys.exit(main())
    File "/usr/local/lib/python3.8/site-packages/cfnlint/__main__.py", line 23, in main
      (args, filenames, formatter) = cfnlint.core.get_args_filenames(sys.argv[1:])
    File "/usr/local/lib/python3.8/site-packages/cfnlint/core.py", line 144, in get_args_filenames
      cfnlint.maintenance.update_iam_policies()
    File "/usr/local/lib/python3.8/site-packages/cfnlint/maintenance.py", line 237, in update_iam_policies
      content['serviceMap']['Manage Amazon API Gateway']['Actions'].extend(
  KeyError: 'Manage Amazon API Gateway'

Looking at the code under maintenance.py, I see that the error happens after a file is downloaded on line 226. The file in question is https://awspolicygen.s3.amazonaws.com/js/policies.js, which is missing the string "Manage Amazon API Gateway". I can only find "Amazon API Gateway Management" and "Amazon API Gateway Management V2".
Unfortunately, I do not have the requisite knowledge to know which of the two is meant and if a simple swap is sufficient to submit a merge request, but would be glad to do so if a swap is sufficient.

I'll take a look.  Thanks for reporting this.

Thanks for the fix @kddejong!


Add documentation to do homebrew ports.

Hi, I'm opening this issue to talk about the need for a documentation about porting your godot game as homebrew to consoles, maybe retro consoles.
I would love to port my game to retro consoles and emulators, but It seems godot can't easily add exporting templates to such consoles because of licencing issues, I was wondering how legal would be to easily let the users do the porting themselves and publish the binaries on the web for easy install on users.
Maybe the documentation should have a part about this topic.
I'm not talking about current generation consoles, but homebrew ports on the Wii or PS3 or DS.

Take a look at https://docs.godotengine.org/en/latest/tutorials/platform/consoles.html if you already haven't. As far as older generation consoles are concerned, AFAIK even they are licensed. And their SDK, as docs say, are secret or have limited access. Also, only limited people have knowledge on how these consoles work. Even if they do, some might be able to share it sometimes(legal issues). Even the porting knowledge could be unique for each console because it's proprietary. As you know proprietary software typically don't follow a standard.
If you can find and list out some of the consoles that are out of license(or don't cause any issues) and compatible with MIT license, maybe few from community might help.
I am not against the idea, but it seems more hard than useful because of limited audience.
Let's see what others here think about it.

Take a look at https://docs.godotengine.org/en/latest/tutorials/platform/consoles.html if you already haven't. As far as older generation consoles are concerned, AFAIK even they are licensed. And their SDK, as docs say, are secret or have limited access. Also, only limited people have knowledge on how these consoles work. Even if they do, some might be able to share it sometimes(legal issues). Even the porting knowledge could be unique for each console because it's proprietary. As you know proprietary software typically don't follow a standard.
If you can find and list out some of the consoles that are out of license(or don't cause any issues) and compatible with MIT license, maybe few from community might help.
I am not against the idea, but it seems more hard than useful because of limited audience.
Let's see what others here think about it.

I think it falls under a fair use clause, reverse engineering is legal from my understanding and reverse engineering a piece of hardware to add some functionality or do software ports is legal, since is not piracy and falls under the fair use.
I think at least testing your game on emulators should be legal, since it would have the same legality of emulation (emulators are legal but not piracy of roms).
Also, from my understanding console companies lack any interest on such retro consoles, so they wont be interested in homebrew ports, they care more about piracy of their IPs than homebrews.
So, I don't see why at least testing your roms on an emulator should be illegal.

I think you'd need to do this on an older version. A REALLY old version.
Godot used to be able to run on tons of crazy platforms (even flash at one point IIRC.) but no longer supports any of those
Not exactly sure what strange stuff in the first open source release (pretty sure most of the really weird stuff was already depreciated) but with the 3.0 update tons of vestigial compatibility was wiped.
There's talks of releasing the entire history of Godot's code (sans proprietary SDKs) but you're gonna have to manually convert EVERYTHING. Formats have drastically changed even between the first open source release and now.


Converting Color without Unity's HSVToRGB Method

I'm currently using Unity 5.2.3f and i got an error with the new Entitas Version 0.29.1.
It occurs in "entitas.unity\visualdebugging\entity\editor\entitydrawer.cs" at Line 319:
var componentColor = Color.HSVToRGB(hue, 0.7f, 1f);
The problem will be that my current Unity3D Version doesn't support this method.
I just simply added an static method for this by myself.
But maybe we can mark this, so that Entitas will work out-of-the-box or find another solution.

Can you update Unity?

In my case, yes. I won't be stuck.

Unfortunately, Unity's documentation doesn't tell in which this method was added. I could add an #if, but maybe updating Unity is a good idea anyway ;)

You can add this piece of code
                    #if (UNITY_5_3)
                    var componentColor = Color.HSVToRGB(hue, 0.7f, 1f);
                    #else
                    var componentColor = Color.grey;
                    #endif

If you know a way how I can check if the Unity version is greater that 5.3, let me know. The problem with  #if (UNITY_5_3) is, that it only checks the specific version... That means Color.HSVToRGB would also be deactivated in 5.4 which is not intended

For this version of unity just change Color to EditorGUIUtility.HSVToRGB, to check if version is greater you can use Application.unityVersion

It says:

EditorGUIUtility.HSVToRGB is obsolete. Use Color.HSVToRGB instead

This is solution for  5.2.x and versions below.


[$500] Email-The word "pay" is not centered on the button in Gmail app email notification

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4463509
Issue reported by: Applause - Internal Team
Action Performed:

Open the App
Request money to an account that you have access to the email inbox
Do not read the message in NewDot to trigger the email notification
Open the email on the phone Gmail App (on Android)

Expected Result:
The "Pay" word is centered on the green button
Actual Result:
The "Pay" word is lower on the green button
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018b2cce02f5267c57
Upwork Job ID:<PHONE_NUMBER>188765184
Last Price Increase: 2024-04-02

@garrettmknight  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

I had to bump up the display/text size, but I was able to reproduce.

Adding to split since it's an IOU issue that they'll encounter.

@garrettmknight This is happening in emails that are sent to the user, so it would require a backend fix.

Proposal
I think you are using 2 tags to build that button. One serves as a container and 2nd a text.  So, using the button will definitely keep the text in center.
If you are using button then tweaking with padding or line height will work.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01ff7e928882ddd88c

@akinwale fair, I'll switch internal, but would this solution essentially be the change?

@akinwale fair, I'll switch internal, but would this solution essentially be the change?

I don't think so, because regular contributors do not have access to the code that handles creating or generating the email templates.

Still awaiting a volunteer.

Dropping to weekly - we're calling for volunteers in slack.

Still awaiting internal volunteer

Still awaiting a volunteer

Still awaiting a volunteer

Still awaiting a volunteer

Still awaiting a volunteer

Issue not reproducible during KI retests. (First week)

Moving to daily to test.

Will test tomo.

Didn't get to test today - tomorrow!

Fixed!


Discussion: consider migrating  to TiKV repo?

I was shocked at TiDB Hackathon by this project, it is mature enough and I think it can be used as the official TiKV CLI.
I recommend to migrate to TiKV repo directly, but IMO, we need to use another name, not ticli
How do you think about? @busyjay @sunxiaoguang @c4pt0r

agree

@siddontang Happy to see your proposal! I also think a name more related to tikv should be used.
One question, when you say migrating to tikv repo, do you mean migrating to the tikv org as a separate repo, or integrating it into the tikv/tikv repo?


convert real to rational

julia> zxd = ZXDiagram(4);

julia> push_gate!(zxd, Val(:X), 3, 0.5);

julia> push_gate!(zxd, Val(:X), 3, 0.3);

julia> push_gate!(zxd, Val(:X), 3, 1/3)
ZX-diagram with 11 vertices and 7 multiple edges:
(S_1{input} <-1-> S_2{output})
(S_3{input} <-1-> S_4{output})
(S_5{input} <-1-> S_9{phase = 1//2⋅π})
(S_6{output} <-1-> S_11{phase = 1//3⋅π})
(S_7{input} <-1-> S_8{output})
(S_9{phase = 1//2⋅π} <-1-> S_10{phase = 3//10⋅π})
(S_10{phase = 3//10⋅π} <-1-> S_11{phase = 1//3⋅π})

I'm wondering what if the phase is not something like 0.5, but something like 0.31491304324324423423, will it still get converted? If so, I think call this function explicitly could be better, or have an option to use this.


Conflict between Roku Plex client names and Rokus using the new naming

Home Assistant release (hass --version):
0.38.2
Python release (python3 --version):
Python 3.4.2
Component/platform:
Roku and Plex
Description of problem:
When the Plex component discovers a Roku Plex client, it creates a media player named media_player.<roku_name>.  Now that the Roku component uses the Roku name for it's own media player entity, there's a collision between the names.  Whichever one is found second will become media_player.<roku_name>_2.  Either the Plex component or the Roku component (or both) could maybe namespace their discovered devices, ex. media_player.roku_<roku_name> or media_player.plex_<roku_name>.

Ah yes I've also seen this issue.
Downgrading to 0.36 for now while this and thermostats are broken :(

So, as a fix you can use this feature (namely, the entity_namespace option).
media_player:
  - platform: plex
    entity_namespace: plex
  - platform: roku
    entity_namespace: roku

I still think this should be handled internally by the components, but this gets them identifiable from each other now.

Is this the same issue as described in #5697?

@reedriley No, I don't think so. The only common thing I see between them is that they both relate in some way to the Roku component.


Flash Attention 2

Flash Attention 2 is out, they say it saves half the time, when will it be here?
Thanks for everything

Relevant upstream discussion: https://github.com/ggerganov/llama.cpp/discussions/2257

I understand that it is a matter of time, we will wait patiently
Thank you

Relevant upstream discussion: ggerganov/llama.cpp#2257


adding docs about query/partial/time

seems that query/partial/time was introduced recently by this PR. I am not sure if the name reflects what it means or maybe my understanding is wrong. @fjy can you please explain more how this is different from wait/time ?

:-1:
/partial/time is never used in druid, it is just a default name that is replaced

look at ServerManager

wait/time is about how long a segment waits in queue to be scanned
partial/time is used by realtimeplumber around time to scan each partial segment

@fjy i have some logs that contains that metric, so i am not sure what you mean by overwritten ?

@b-slim look at look at ServerManager.java

@fjy you keep saying look at ServerManager.java, can you be more specific ? i have logs where you can see that indexer realtime node is reporting metric called query/partial/time. So this means it is either a bug or it is the expected behavior.
2016-02-24T01:43:07,293 INFO [topN_svctrace_[2016-02-24T01:00:00.000Z/2016-02-24T02:00:00.000Z]] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2016-02-24T01:43:07.293Z","service":"druid/middlemanager","host”:”indexer0004.xxx.xxxxxx.com:8100","metric":"query/wait/time","value":1,"dataSource":"svctrace","dimension":"dp","duration":"PT3600S","hasFilters":"true","id":"68efded4-b281-4a47-8531-a9e2921b50c5","interval":["2016-02-24T01:00:00.000Z/2016-02-24T02:00:00.000Z"],"numComplexMetrics":"0","numMetrics":"3","threshold":"1000","type":"topN"}]

new MetricsEmittingQueryRunner(
emitter,
builderFn,
new BySegmentQueryRunner(
adapter.getIdentifier(),
adapter.getDataInterval().getStart(),
new CachingQueryRunner(
adapter.getIdentifier(),
segmentDescriptor,
objectMapper,
cache,
toolChest,
new MetricsEmittingQueryRunner(
emitter,
new Function<Query, ServiceMetricEvent.Builder>()
{
@Override
public ServiceMetricEvent.Builder apply(@Nullable final Query input)
{
return toolChest.makeMetricBuilder(input);
}
},
new ReferenceCountingSegmentQueryRunner(factory, adapter, segmentDescriptor),
"query/segment/time",
ImmutableMap.of("segment", adapter.getIdentifier())
),
cachingExec,
cacheConfig
)
),
"query/segmentAndCache/time",
ImmutableMap.of("segment", adapter.getIdentifier())
).withWaitMeasuredFromNow()

@fjy thanks please look at https://github.com/druid-io/druid/pull/2578

Will be fixed by https://github.com/druid-io/druid/pull/2578


Button Styling Looks Off In MS Outlook Web

This image shows the button I get when viewing my email (with the default theme) in outlook web. It looks fine on MS Outlook's desktop app, it just look funny in their web app. I believe it has something to do with the line height, but I might be mistaken. Any idea how to fix this without using a custom theme?

Hi @JPStrydom,
Thanks for the report! Just wondering, how did you fit a description in the button text? Are you using a new-line character (\n)?
The button.text is a string which only expects to receive a single line or phrase:
            button: {
                color: '#22BC66', // Optional action button color
                text: 'Confirm your account',
                link: 'https://mailgen.js/confirm?s=d9729feb74992cc3482b350163a1a010'
            }

I've only given it a single line, much like your example.

Hi @JPStrydom,
I believe the solution would be to add a white-space: nowrap CSS declaration to the button text.
Can you please try to reproduce by using a shorter button text such as Test? Does it still break?


Generator To Serialize/Deserialize Objects

It would be really nice to have a generator to serialize/deserialize objects to binary.
Example:
[Serializeable]
public partial class MyClass {}

that generates two methods, one for serialisation with a binarywriter and one for deserialisation with binaryreader

That's a great idea. Unfortunately I'm a bit swamped at the moment and will only be able to get to this in a couple of weeks.
In the meantime, I'd be happy to accept a PR in case you're interested.

@furesoft I have started working on this, but am not quite sure what you are proposing. Using BinaryFormatter is discouraged, so maybe you could share what the generated code should look like?

Using BinaryWriter and BinaryWriter and serialize/deserialize obeject froms scratch

Hey, I had the same idea, I think, so I would share this here:
https://github.com/xafero/csharp-generators/blob/main/src/Cscg.Compactor/CompactGenerator.cs
Generating a read and write method for every property in the class with BinaryReader and BinaryWriter.

@xafero That looks great! Would you like me to add that to this library?

@xafero That looks great! Would you like me to add that to this library?

Sure. Maybe my code is rough, but I saw this issue and wanted to maybe help. Because I like Lombok and your take on it.

Available in v2.4.0


Use su to install the runner

This change executes the runner install script provided via userdata using su. The script itself has also been changed to assume it's running as the runner user.
Fixes: #113

Very cool - thanks! Was planning maintenance for tomorrow anyway, perfect timing :-)


Unsaved Queries Get Deleted

Almost every time I start writing a new query and start writing code the entire tab gets deleted before I have a chance to save. This has been very frustrating. Aside from this issue I am a big fan of Data Studio, but unfortunately feel like I cannot use it any more with bugs like this

@mattedsonpalmer - That's very unusual - could you explain more about the situation? Does the entire tab disappear or just the text contained within it?
If you could use a tool such as ScreenToGIF to capture this in action that would help us understand the issue as well.
What version of ADS do you have that this is occurring on?


IMigrationsAssembly  vs  MigrationProviderStore for storing migrations !

Hello fellows !
I have researched the Imigrator. and Migration commands !
https://github.com/aspnet/EntityFrameworkCore/blob/04607ac00983705b3b1d4d4ca9834364edd36a01/src/EFCore.Relational/Migrations/IMigrator.cs
And my main target is to store Migration not in Cs files!
I want to store migrations files in database or in some xml files!
And apply migrations with out relaunching the main app!
As I said before is need for enterprise scenarios, when application must work in 24/7 servicemodel!
It'is very sad that dotnet/coreclr still could not provide unloading of assembly!
https://github.com/dotnet/coreclr/pull/18476
I have a few conceptual and technicals questions !
1.Its possible to Realize  IMigrationsAssembly that will store migrations in database or xml files, not in cs files ?
https://github.com/aspnet/EntityFrameworkCore/blob/04607ac00983705b3b1d4d4ca9834364edd36a01/src/EFCore.Relational/Migrations/IMigrationsAssembly.cs
The migration architecture is hard binded to work with assembly!
I think is not right that with architecure principes, that the migrations are stored in Cs files.
I understand, that it is very nice that U inspired with Django and Ruby_on_Rails frameworks, with there simplicity to work with migrations!
Maybe U shall overview the architecture of migrations ?
Maybe must be some kind of MigrationProvider, that will store all migrations ?
By option it could be cs files,xml files,json files,or database storage ?
Fake migrations
https://github.com/aspnet/EntityFrameworkCore/blob/04607ac00983705b3b1d4d4ca9834364edd36a01/test/EFCore.Relational.Tests/RelationalDatabaseFacadeExtensionsTest.cs
 protected virtual void PopulateMigrations(
            IEnumerable<string> appliedMigrationEntries,
            string targetMigration,
            out IReadOnlyList<Migration> migrationsToApply,
            out IReadOnlyList<Migration> migrationsToRevert)
        {
			// Примененные миграции
            var appliedMigrations = new Dictionary<string, TypeInfo>();
			// Не Примененные миграции
			var unappliedMigrations = new Dictionary<string, TypeInfo>();

            var appliedMigrationEntrySet = new HashSet<string>(appliedMigrationEntries, StringComparer.OrdinalIgnoreCase);

			//Если нету миграций в _migrationsAssembly то пишем что миграции не найдены
            if (_migrationsAssembly.Migrations.Count == 0)
            {
                _logger.MigrationsNotFound(this, _migrationsAssembly);
            }

			/// Перебираем все миграции в _migrationsAssembly
            foreach (var migration in _migrationsAssembly.Migrations)
            {
				// Если appliedMigrationEntrySet содержит миграцию _migrationsAssembly
				// то добавляем к примененым
                if (appliedMigrationEntrySet.Contains(migration.Key))
                {
                    appliedMigrations.Add(migration.Key, migration.Value);
                }
                else
                { //Если нет то добавляем не к примененным
                    unappliedMigrations.Add(migration.Key, migration.Value);
                }
            }

			// Если targetMigration не указана то в migrationsToApply ложим не примененные миграции
            if (string.IsNullOrEmpty(targetMigration))
            {
                migrationsToApply = unappliedMigrations
                    .Select(p => _migrationsAssembly.CreateMigration(p.Value, _activeProvider))
                    .ToList();
                migrationsToRevert = Array.Empty<Migration>();
            }
            else if (targetMigration == Migration.InitialDatabase)
            {
                migrationsToApply = Array.Empty<Migration>();
                migrationsToRevert = appliedMigrations
                    .OrderByDescending(m => m.Key)
                    .Select(p => _migrationsAssembly.CreateMigration(p.Value, _activeProvider))
                    .ToList();
            }
            else
            { // В Else случае находим targetMigration в непримененных миграциях и ложим их в migrationsToApply
                targetMigration = _migrationsAssembly.GetMigrationId(targetMigration);
                migrationsToApply = unappliedMigrations
                    .Where(m => string.Compare(m.Key, targetMigration, StringComparison.OrdinalIgnoreCase) <= 0)
                    .Select(p => _migrationsAssembly.CreateMigration(p.Value, _activeProvider))
                    .ToList();
                migrationsToRevert = appliedMigrations
                    .Where(m => string.Compare(m.Key, targetMigration, StringComparison.OrdinalIgnoreCase) > 0)
                    .OrderByDescending(m => m.Key)
                    .Select(p => _migrationsAssembly.CreateMigration(p.Value, _activeProvider))
                    .ToList();
            }
        }

2.The second question is similar to reloading assembly !
If it is not possible to reload asseblyes that stores model class, as i mentioned before!
Then it is possible to make models with dynamic injection in runtime, injection in dbcontext class ?
When litle time application go to service mode, and all models that changed (for example added one column)
all models are reloading and injecting in dbcontext ?
3.And last one!
I understand that many things in ef core realized with interface principals!
And if shall realize some custom Imigrator or IMigrationsAssembly how to make it work when many source files have no documentation and,
writed coments that api may changed ?
 /// <summary>
    ///     This API supports the Entity Framework Core infrastructure and is not intended to be used
    ///     directly from your code. This API may change or be removed in future releases.
    /// </summary>

I wanna say that Ure have some plans to release more modern and fashionable things!
But where is border of source code, when api changeable or not gonna change in future?
Maybe must be some council(soviet) that shall approve architecture and future of EF CORE ?
I Could realize some library that will dependent on EF CORE but, there have some guarantee that feature that I realized will work in future releases of ef core ?

I wonder how coupled it really is... Have you tried just passing dummy reflection instances around?
class MyMigrationsAssembly : IMigrationsAssembly
{
    class DummyTypeInfo : TypeInfo
    {
        public DummyTypeInfo(string migrationId)
        {
            MigrationId = migrationId
        }

        public string MigrationId { get; }
    }

    public IReadOnlyDictionary<string, TypeInfo> Migrations { get; }
        = new Dictionary<string, TypeInfo>()
        {
            ["00000000000000_MyMigration"] = new DummyTypeInfo("00000000000000_MyMigration");
        };

    public Migration CreateMigration(TypeInfo migrationClass, string activeProvider)
    {
        var migrationId = ((DummyTypeInfo)migrationClass).MigrationId;

        return new MyMigration(migrationId);
    }

    class MyMigration : Migration
    {
        string _id;

        public MyMigration(string id)
        {
            _id = id;
        }

        protected override void Up(MigrationBuilder migrationBuilder)
        {
            // TODO: Deserialize migration operations from XML, etc.
        }
    }
}

Actually i want to use already ready types and classes , u just want is to do another storage for migration, all other componets of ef core still be in place !
I wanna say, is all i need is to deserilize MigrationComands and aplly them !
@bricelam for now i dint try it, I am still diving in sources !

Is need not for 1 database.
This kind migration is depended on Ms sql specific
.Annotation("SqlServer:ValueGenerationStrategy", SqlServerValueGenerationStrategy.IdentityColumn),
I'am trying to say when command add-migration executes.
Its code that generates is dependable on 1 database.
Maybe have some abstract class, not depend on specific RDBMS ?
With out            .Annotation("SqlServer:ValueGenerationStrategy",  or it is impossible ???

        protected override void Up(MigrationBuilder migrationBuilder)
        {
            migrationBuilder.CreateTable(
                name: "Authors",
                columns: table => new
                {
                    AuthorId = table.Column<int>(nullable: false)
                        .Annotation("SqlServer:ValueGenerationStrategy", SqlServerValueGenerationStrategy.IdentityColumn),
                    FirstName = table.Column<string>(nullable: true),
                    LastName = table.Column<string>(nullable: true)
                },
                constraints: table =>
                {
                    table.PrimaryKey("PK_Authors", x => x.AuthorId);
                });

            migrationBuilder.CreateTable(
                name: "Books",
                columns: table => new
                {
                    BookId = table.Column<int>(nullable: false)
                        .Annotation("SqlServer:ValueGenerationStrategy", SqlServerValueGenerationStrategy.IdentityColumn),
                    Title = table.Column<string>(nullable: true),
                    AuthorId = table.Column<int>(nullable: false)
                },
                constraints: table =>
                {
                    table.PrimaryKey("PK_Books", x => x.BookId);
                    table.ForeignKey(
                        name: "FK_Books_Authors_AuthorId",
                        column: x => x.AuthorId,
                        principalTable: "Authors",
                        principalColumn: "AuthorId",
                        onDelete: ReferentialAction.Cascade);
                });

            migrationBuilder.CreateIndex(
                name: "IX_Books_AuthorId",
                table: "Books",
                column: "AuthorId");
        }

Have you seen Migrations with Multiple Providers?


Proposal: New rule for prohibiting usage of mutating array methods

It would be great to have a rule that warns about using mutating array methods without explicitly typing the arrays with ReadonlyArray.
Context
In some cases, it's not desirable to explicitly type arrays with ReadonlyArray. For example, when the type of an array can be automatically inferred:
const makeComplexObj = (...) => ({a: new A(...), b: new B(...)});

const someArr = [makeComplexObj(...), makeComplexObj(...), ...];

vs
const someArr: ReadonlyArray<{
  a: A,
  b: B,
}> = [makeComplexObj(...), makeComplexObj(...), ...];

As you can see, typing such an array explicitly can be a bit cumbersome/verbose.
Proposal
Similar to how the no-object-mutation rule deals with objects, the rule would use type information to detect arrays and warn about using methods such as push, pop, shift and others.

This sounds like a nice complement to the no-object-mutation rule, something likeno-array-mutation. I would be happy to take a PR for it, or I'll look into it when I have some spare time.

This is great, especially considering typing as ReadonlyArray causes https://github.com/Microsoft/TypeScript/issues/15972


#886: Applies box-sizing border-box to .apos-ui

Austin pointed out it's scoped to apos-ui. I have no remaining concerns about this.


Support custom user provider names in generator commands

The generator commands only worked when the auth.providers.user configuration was used. When you change this to something else, the user model wouldn't be replaced correctly.
I refactored the retrieval of the authentication model to a seperate method called userProviderModel(). Then I searched and replaced all occurrences of config('auth.providers.users.model').
I don't know if this is the way you'd like to implement this method. But it fixes the bug. I'll keep the PR open for feedback and edits.

This could use some tests.

I know. I searched for some example tests for the commands but I couldn't find any. So I didn't know how you want these tests to look.

I can't even run all tests. I get a memory exception. Is there a way to run all tests in chunks or something? Without increasing my memory limit.

You can run test per Class, Method, Group, etc. but you still need to run all the tests at least once to make sure your changes do not break other parts of the system.

Yeah I don't feel like running through every testclass manually. There should be a way to do this automatically.
Besides that, I know that this change will not break anything. Because all tests get executed with CI.
I do want to write some tests for this change, but I need someone who can tell me where to start. Especially because I cannot find any tests for the artisan:make commands.

I meant that your tests YOUR tests per class/method or group.

Ah yeah, that's possible.
Do you know why there aren't any existing tests for the commands?

Duplicate #24501

Anyone who can help me?


Style the Machine Edit page

Step 1: @ryantg Create a mockup.
Step 1 status: Incomplete.

Details are in the mockup (I just wrote notes rather than actually mocked it up).
This feels like weak style suggestions on my part... but still I hope it really helps the page become more readable. We'll see.
Shit, I need to look at a location that has high scores, and then suggest style changes to that.

Should all be addressed here:
https://github.com/scottwainstock/pbm-ios/commit/738043d07ddde7c3695f95ac0c82716637d1d0cd

Small adjustment: When I said to indent the "Updated on" four spaces, can you change that to TWO spaces?
High scores:
333,333,333
Scored on: Nov 29, 2016 by tzr
Details: New line for the "Scored on" with a two space indent. Color #888888 for that line.

Here's yer formatting:
https://github.com/scottwainstock/pbm-ios/commit/e665c73380e07fe3c476db6a94192be3a097c09c

I'll be the judge of that.


exercism: 3.4.1 -> 3.5.0

exercism: move to by-name
exercism: 3.4.1 -> 3.5.0

Description of changes
https://github.com/exercism/cli/releases/tag/v3.5.0
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Covered by #338452


"./sleigh -n" Should Have Line Numbers

Describe the bug
I'm compiling my processor spec with "./sleigh -a <processor_dir>". I have the following warning:

WARN  4 NOP constructors found (SleighCompile)
WARN  Use -n switch to list each individually (SleighCompile)

Trying again with "./sleigh -n -a <processor_dir>" I get:

WARN  NOP detected at null (SleighCompile)
WARN  NOP detected at null (SleighCompile)
WARN  NOP detected at null (SleighCompile)
WARN  NOP detected at null (SleighCompile)
WARN  4 NOP constructors found (SleighCompile)

Which doesn't help me. I want to know at what line I have a NOP instruction.
To Reproduce
Steps to reproduce the behavior:

Develop a processor spec with empty SLEIGH definitions for some of the instructions.
Compile with ./sleigh -n -a

Expected behavior
I want to see line numbers in the output:

WARN  NOP detected at line 1234 (SleighCompile)
WARN  NOP detected at line 1300 (SleighCompile)
WARN  NOP detected at line 1330 (SleighCompile)
WARN  NOP detected at line 2738 (SleighCompile)
WARN  4 NOP constructors found (SleighCompile)

I looked into this a little, but made no progress really.
In SleighCompiler.g, pcode.recordNop(find(where)); find() has a null location.  Any other time in that c != null, the find() does return a location, but I never figured out where the OP_PCODE gets the filename/lineno assigned

I'm still having the same issue. You can take a look at my code here: https://github.com/VGKintsugi/Ghidra-SegaSaturn-Processor/tree/b83f74d58251fc2c51c6df012e52caf676a3ff77

I took a look, and fixed the issue by modifying the SleighCompiler.g file to pass down the constructor.  There are a few changes needed in other calls to the grammar.

Any chances this makes 9.0.5 or 9.1?  (also maybe #745 )

Should be merged into main soon.  Already fixed, just lagging merges.

Fixed here.


No reference to result.transactions[0].sender_address property in starknet_getBlockWithTxs method.

I noticed that each item in starknet_getBlockWithTxs method's return value's transactions property has an optional property called sender_address. But I haven't been able to find a reference to that property in the source code of the starknet-rs crate.
I wonder if the methods of the RPC provider I am using (it's v0.6) is outdated or something.
If not the return types of RPC methods might need to be updated in the starknet-rs crate.
BlockWithTxs struct: https://github.com/xJonathanLEI/starknet-rs/blob/master/starknet-core/src/types/codegen.rs#L115C12-L115C25
Transaction enum: https://github.com/xJonathanLEI/starknet-rs/blob/master/starknet-core/src/types/mod.rs#L181
For example you can make the request below to a Starknet Testnet RPC provider and notice that some of the items in the result.transactions property have sender_address property.
{
    "jsonrpc": "2.0",
    "method": "starknet_getBlockWithTxs",
    "params": [
        {
            "block_number": 955848
        }
    ],
    "id": 1
}

sender_address is indeed available, but you're probably trying to access it from the umbrella Transaction type, which is an enum type that contains multiple variants.
Only DECLARE and INVOKE transactions have the sender_address field. You will need to match down to these variants to be able to access them.


cjdnsapi: construct port set to default of cjdns

good call, I think the cjdns constructor args should be config constants. Thoughts?


Extensions support should include wildcard searches [Suggestion]

The Extensions section only seems to support specific file extensions to search for. This requires a user to know what files they want to search through. In some cases, it would be helpful to use a wildcard (*) to search for any files in a given directory that contain the keyword of interest.

Wildcard is no longer needed. Everything is searched.  Users can use the filename filter to isolate the search from there


Missing holiday

Is this node still under development?
If so, there is an error in the predefined holidays for "Berlin". Since some years now the "Internationaler Frauentag" is a holiday in Berlin.
On top of that it would be great to have a possibilty to enter a time period (instead of only single days) to use this node also for vacation flows.
If development of this node has been abandoned: is there an alternative to this node? Thank you!

Yes, this node is still being developed. However, this is done with very low priority and therefore there are seldom releases.

Added a PR for this issue.


Support specifying a download location for the SDK

There doesn't appear to be a way to specify where the SDK will be downloaded to, which makes the SDK files more difficult to cache in a CI environment and prevent them from being downloaded/installed every time.
There is tools.cloudSdkHome, but the documentation for that property indicates that the download will only occur if this property is unset:

tools.cloudSdkHome: Optional property to configure the location of the Cloud SDK.
If this property is not specified, then the plugin automatically downloads Cloud SDK.

It would be great to perhaps have a secondary property to configure whether or not the SDK is downloaded to the specified path, e.g.
tools.cloudSdk.home=/path/to/sdk
tools.cloudSdk.downloadIfMissing=true

If the plugin does not download gcloud command when it's missing, the plugin does not work. I think properly caching the tools.cloudSdk.home=/path/to/sdk would resolve your CI problem.
(Sorry I responded to a very old issue. I'll close this next week if there's no new findings)

@suztomo I'm no longer using App Engine or the CI platform in question anymore, so this issue is no longer relevant for me. Happy for you to close it if you wish, thanks.

Thank you for your response.


(fix) added support of percent-encoded chars

First commit adds ability to build the project (resolved hyper version clash).
Second commit fixes #60.

Test fails for some strange reason. I had same problem during development, test re-run helped.

Merged in #67, thanks!