Receiving error in IBM i Output log 'CPD0074:  Value 'REPORTSQLE' for FILE exceeds 10 characters.'

I receive the error CPD0074:  Value 'REPORTSQLE' for FILE exceeds 10 characters. because this command is being run, DSPFFD FILE(*LIBL/REPORTSQLERROR) OUTPUT(*OUTFILE) OUTFILE(ILEDITOR/RREP177272).
The problem looks to occur in parser.js -> fetchTables.
This would be a medium PTY for me but it does prevent to usage of some feature, although I don't know what looking at the output or code.
Thanks, Matt

@m-tyler Are you able to share some f-specs which might be causing this error? That'd be handy. Thanks!

Fix due out soon

You closed this issue indicating that a fix is due out soon.  Did that ever make it out yet?  If so I still see the same error in 0.10.2 if not is it planned soon-ish?
If still not I have another issue that is related.  I am getting this error but I am not able to find the source line that might be linked to it, yet.
{
    "code": 1,
    "signal": null,
    "stdout": "",
    "stderr": "CPD0048:  List of values not valid for parameter FILE.\nCPD0048:  List of values not valid for parameter OUTFILE.\nCPF0001:  Error found on DSPFFD command."
}

Okay I found the source of the data for that.  Its reading the source array space.
system  "DSPFFD FILE(*LIBL/ITT     BE) OUTPUT(*OUTFILE) OUTFILE(ILEDITOR/RITT001851)"; if [[ $? -ne 0 ]]; then exit 1; fi

The program is a free format NOT-**FREE.

@m-tyler would you mind opening a new issue for this with that example in the bottom?
I think I know the issue but need to create a new test case for it.

Yep, no problem.


codemod breakes when render is a non-function variable

Type: Bug

Packages
Version

fela-codemods
10.2.0

Description
When the render prop is a variable that stores a string, for instance, when the rendered element is set dynamically, the codemod assumes it is a function, removes all children and places the variable as children.

Steps to reproduce
The following code:
const Example = ({ as, children, })  => (
  <FelaComponent style={...} render={as}>
    {children}
  </FelaComponent>
);

is transformed into:
const Example = ({ as, children, })  => (
  <FelaComponent style={...}>
    {as}
  </FelaComponent>
);

Expected Behavior
When FelaComponent is NOT a self-closing JSX element, and does not have a children prop set explicitly, render should be transformed into as, and it's children.
<FelaComponent style={...} render={as}>{children}</FelaComponent>
// Should be transformed to
//    <FelaComponent style={...} as={as}>{children}</FelaComponent>

<FelaComponent style={...} render={as} children={children} />
// Should be transformed to
//    <FelaComponent style={...} as={as} children={children} />

<FelaComponent style={...} render={as} />
// Should be transformed to
//     <FelaComponent style={...}>{as}</FelaComponent>

Another bug in the codemod is that arguments of inline functions inside a style functions are transformed as if they were the args of the style function itself.
Before:
<FelaComponent style={theme => ({
  color: (a, b) => a + b,
})} />

After:
<FelaComponent style={theme => ({
  color: ({ a }) => a + b,  // <- This is the problem
})} />

Should I keep this here, or open a separate issue?

Hmm, The second one is invalid anyway as you can't have function values inside Fela rules.
I don't think we should check that as well.
However, the first one is definitely true and should be fixed. Feel free to send a PR that fixes that specific case!

@rofrischmann The second case could be a valid use case with a slightly less contrived example, in which you use a function that takes a callback to generate some styles:
<FelaComponent style={({ theme, someProp}) => ({
  ...myFn((someProp) => `do something with ${someProp }'),
})} />

I think that generally speaking, we should only check for the arguments of the callback directly following style={.
I agree that the first issue is more serious


Typescript integration issues

Hi @josepot , how you doing? I hope you are doing great 😄
This is somewhat related to #228.
While doing minor release updates:

My Typescript app broke:

Apparently Typescript does not support mjs yet so webpack customization is required in this case: https://github.com/formatjs/formatjs/issues/1395
Was that intentional? I.e. the fact that the library now breaks with Typescript?
Ideas, suggestions on how to bypass that? I think writing a custom rule saying mjs is still js is the most promising solution: https://github.com/formatjs/formatjs/issues/1395#issuecomment-518823361
Have a good one,

Hi @cabello !
Thanks for reporting this! I think that we addressed this issue already, but it looks like we forgot to publish the patch for<EMAIL_ADDRESS>Could you please try using<EMAIL_ADDRESS>(there shouldn't be any breaking changes...) and let us know if that solves the "compiling" issue? If it does, then I will publish a<EMAIL_ADDRESS>patch for this issue.
Thanks again!


components loaded via split-require are absent after build

this a 🐛 bug report
Expected Behavior

Running bankai start app.js should build the file(s) bundle-[#].js for the lazily loaded asset.
Running bankai build app.js should build the file(s) bundle-[#].js for the lazily loaded asset.
Current Behavior

The bundle-[#].js file(s) are accessible via HTTP requests after running bankai start app.js.
The bundle-[#].js file(s) are not present in dist after running bankai build app.js

There is no error.
Context
It's obviously possible this is more related to split-require than bankai, but the fact that bankai start app.js works while bankai build app.js does not makes me think otherwise.
Code Sample
I am able to reproduce this with my code as well as the sample code from https://github.com/goto-bus-stop/split-require#what
package.json
{
  "scripts": {
    "build": "bankai build app.js",
    "start": "bankai start app.js"
  },
  "dependencies": {
    "choo": "6.10.3"
  },
  "devDependencies": {
    "bankai": "9.11.1",
    "split-require": "3.1.0"
  }
}

app.js
var html = require('choo/html')
var app = require('choo')()
var splitRequire = require('split-require')

app.route('/', mainView)
app.mount('body')

var component
function mainView () {
  return html`

Loading

  `
}

splitRequire('split-require', function (err, exports) {
  console.log(err, exports)
  app.emitter.emit('render')
})

Your Environment

Software
Version(s)

Package
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Runtime
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Package Manager
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Operating System
macOS 10.13.04

The following versions appear to work together:
➜ npm list split-require bankai
├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>deduped
└──<EMAIL_ADDRESS>

:package: 9.11.2 should fix this. thanks!


Add LFAI logo to sidebar

LFAI Data logo rests at the bottom of the sidebar

LFAI Data and AI logo rests at the bottom of the sidebar

@drewbutlerbb4 -- are you using this PR to add the following items as well? Or, are you planning to add these in a separate PR?

1) Add the following footer to all web pages:
Copyright © 2021 Machine Learning eXchange The Linux Foundation®. All rights reserved. The Linux Foundation has registered trademarks and uses trademarks. For a list of trademarks of The Linux Foundation, please see our Trademark Usage page. Linux is a registered trademark of Linus Torvalds. Privacy Policy and Terms of Use.
2) Top left corner: Replace the MLX icon logo with the full logo
(Here's the white SVG version: https://artwork.lfaidata.foundation/projects/mlx/stacked/white/mlx-stacked-white.svg) AND Add the LF AI logo underneath it (here is the link to the LF AI & Data logo to use in white/svg: https://artwork.lfaidata.foundation/lfaidata-assets/lfaidata/stacked/white/lfaidata-stacked-white.svg
3) Replace this text "   MLX - Data and AI Assets Catalog and Execution Engine" with the following:
Machine Learning eXchange (MLX) is an open source project hosted in the LF AI & Data Foundation whose mission is to design and implement an open source Data and AI assets catalog and execution engine.  It allows the upload, registration, execution, and deployment of AI pipelines, pipeline components, models, datasets, and notebooks. We invite you to visit us on GitHub where our development happens. You are more than welcome to join our community both as a user and also as a contributor to the project's development. We look forward to your contributions!
4) On the left hand side menu - add a new item menu "Join the Conversation"
When you click on it, you get to a page that has the following information:
MLX maintains three mailing lists. You are invited to join the one that best meets your interest.
MLX-Announce (top-level milestone messages and announcements)
MLX-TSC  (top-level technical governance discussions and decisions)
MLX-Technical-Discuss (technical discussions and questions)

@drewbutlerbb4 -- are you using this PR to add the following items as well? Or, are you planning to add these in a separate PR?

This one

Thanks @ckadner you must be prophetic because my email has been down all day and I was able to reference those requirements thanks to your comment! Everything should be addressed except for the (4) where the links differ based on the meeting yesterday.

Thanks @Tomcli I updated as requested

@Tomcli @ckadner Latest is as shown below

thanks @drewbutlerbb4. We can shorten the para a bit more like this, and make the font a bit smaller.
Machine Learning eXchange (MLX) is an open source Data and AI assets catalog and execution engine, hosted in the LF AI & Data Foundation. It allows the upload, registration, execution, and deployment of AI pipelines, pipeline components, models, datasets, and notebooks. Please join our community on Github!

Sure update shown below

thanks @drewbutlerbb4
/lgtm
/approve


When clicking 'view' on AUview page, you must click twice

Schweta has found that she has to click twice on the view link to launch any AU. This is happening irregardless of role.

Shweta has not noticed this issue since connection problems with LRS were fixed, I will leave issue open for about a week to ensure it is gone, but think we are clear on this and it was related to the other problem.

See last note


Stop processing messages from FIFO queue when exception is thrown

:loudspeaker: Type of change

[x] Bugfix
[ ] New feature
[ ] Enhancement
[ ] Refactoring

:scroll: Description

I think there is a bug in SimpleMessageListenerContainer.MessageGroupExecutor class.
When multiple messages from the same message group are recieved and exception is thrown while
processing one them the others should not be processed. I think this is importand because
the order should be maintained even in case of an error.
:bulb: Motivation and Context

I think it solves this issue
https://github.com/awspring/spring-cloud-aws/issues/124
:green_heart: How did you test it?
I integrated it with my app that is using SQS FIFO queue and checked if order is maintained in case of an exception.
Also I prepared a unit test.
:pencil: Checklist

[x] I reviewed submitted code
[x] I added tests to verify changes
[x] All tests passing
[ ] I updated reference documentation to reflect the change
[ ] No breaking changes <- not sure about that.

:crystal_ball: Next steps

Thanks @sebastiandusza and apologies for late review. I am closing this as #192 is already in place and it has a test.


2.0 Preview 2 contributor and commit docs

I like the idea of having a single place to go to see everything that happened but this list is daunting. Commits are too granular and quite often irrelevant or indecipherable.
I really like what Docker does (https://github.com/moby/moby/releases/tag/v17.03.2-ce). They link to pull requests (maybe issues too) and only list substantial changes. They also group related PRs and I believe they sanitize a one-liner per change for quick consumption. This makes it incredibly easy to keep up with all the change in Docker and its related components. I would love to have the same for .NET Core and ASP.NET Core, etc.


[FEATURE Making "To-Do List" more attractive.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Additional context
Add any other context or screenshots about the feature request here.

@Anshgrover23 Please assign me this issue under hacktoberfest.

I will change the font color as then it will be more clearly visible.


Update to Vuetify Version 2.2.18

Updates Wegue to Vuetify version 2.2.18. Based on the changes in https://github.com/halukmegg/wegue/tree/Update-Vuetify but refactored to the current Wegue master.

Please test @justb4 and @JakobMiksch and anyone else who is willing of course.
Before merging this we should release the current master with a new version, like 0.10 (or similar) and add a vuetify1-maintenance branch for backwards compatibility.
Supersedes #129

Ran it and tested the typical GUI features. Everything works like expected.

I just released Wegue version 0.10.0 and added a maintenance branch vuetify-v1-legacy in order to preserve the state compatible to Vuetify v1.
Therefore I am going to merge this now.


Fix/python param order

Related to: #57
This branch supports multiple dispatch ("overload" in C++) using variable arguments and exceptions.
Parameter.init(Shape, list, Device: optional)
          or  (Shape, Initializer, Device: optional)
          or  (np.ndarray, Device: optional)

operators.input(Shape, list, Device: optional, Graph: optional)
           or  (list[np.ndarray], Device: optional, Graph: optional)
           or  (np.ndarray, Device: optional, Graph: optional)

I close this branch and create a new pull request for simpler solution.


[BUG] 'Continue to checkout' redirects to un-customisable liquid page instead of Hydrogen

Describe the bug
Continue to checkout redirects to un-customizable liquid page instead of Hydrogen
To Reproduce
→ Navigate to https://nosto-hydrogen.herokuapp.com/
→ Add product to cart
→ Click on 'Continue to checkout'
→ Redirected to https://nosto-hydrogen.myshopify.com/...
Expected behaviour
This should be a native Hydrogen page, instead of a liquid one. For Nosto's use case, we want to track users' orders. But we cannot interact with the Shopify server since we are redirected away from the main app. We cannot track what orders are being sent by the user until they navigate back to the website (and then we retrieve order details from Shopify), but this is a flawed workflow since the user has no reason to come back to the website once he's placed an order and navigated away.
Screenshots
Additional context
The useCart() hook returns a checkoutUrl which does this redirect. This should really be a page that merchants can customise. For use cases where we want to show other content on the checkout page (like a quick "Add to cart" functionality for "Items bought together frequently").

Hydrogen version
Node version
Device details

Hey @sid2364 I'm not a Shopify employee but I can safely say that this is working as intended and is not a bug. Shopify is doing a lot of work on checkout right now to make it customizable while preserving support for Liquid-based storefronts (of which there are many!). If you're curious which customizations are available in the new checkout architecture, take a look at the documentation for Checkout Extensibility: https://shopify.dev/apps/checkout
Based on my personal perspective having maintained a checkout flow myself in a headless e-commerce app for multiple years, having Shopify maintain the checkout flow is a benefit of using Shopify and Hydrogen. While Checkout Extensibility is in its early stages, there's a lot of great work being done there to allow you to customize checkout using a library of React components.

That clears it up a lot! Thank you so much @davidhousedev. I was under the impression that all pages should be customisable, but it was also pointed out to me that this is done for security reasons as well.
Cheers! 🙌🏽


Html being encoded.

Is there a way to have it not encode html.
I am passing in safe Html and would like it to leave it un-encoded.

{{{}}}} instead of {{}}
John Robert Allan
<EMAIL_ADDRESS>+1.778.837.5218

On Apr 8, 2015, at 10:34, dcumin39<EMAIL_ADDRESS>wrote:
Is there a way to have it not encode html.
I am passing in safe Html and would like it to leave it unecoded.
—
Reply to this email directly or view it on GitHub.

Beautiful!  Thanks for the quick response.


Please Implement Clone for PaddingScheme

Please implement the recommended traits for the enum PaddingScheme.
Clone is missing from  PaddingScheme. Please fix this.
While copy may not be possible due to problems when copying RngCore--namely that an accidental copy may generate the same numbers--, clone is an important implementation which is advised by the creators of rand. With the added implementation of box-clone on Box<dyn DynDigest> and on Box<dyn RngCore>, written out in full bellow, it should be possible to derive Clone on PaddingScheme.
for DynDigest:
pub trait DynDigest {
    ...
}

pub trait DynDigestBoxClone {
    fn clone_dyn_digest(&self) -> Box<dyn DynDigest>;
}

impl<T> DynDigestBoxClone for T where T: 'static + DynDigest + Clone {
    fn clone_dyn_digest(&self) -> Box<dyn DynDigest> {
        Box::new(self.clone())
    }
}

impl Clone for Box<dyn DynDigest> {
    fn clone(&self) -> Self {
        self.clone_dyn_digest()
    }
}

and the same for Box<dyn RngCore>:
use rand::RngCore;

pub trait RngCoreClone: RngCore {
    fn clone_rng_core(&self) -> Box<dyn RngCoreClone>;
}

impl<T: 'static + RngCore + Clone> RngCoreClone for T {
    fn clone_rng_core(&self) -> Box<dyn RngCoreClone> {
        Box::new(self.clone())
    }
}

impl Clone for Box<dyn RngCoreClone> {
    fn clone(&self) -> Box<dyn RngCoreClone> {
        self.clone_rng_core()
    }
}

and switch to using Box<dyn RngCoreClone> rather than Box<dyn RngCore>.
Thanks.
Best regards,
littleTitan

namely that an accidental copy may generate the same numbers--, clone is an important implementation which is advised by the creators of rand

Cloning the RNG feels like a huge footgun here. I'm pretty sure generating the same salt twice in PSS will cripple its security, which this proposal would make way too easy to do accidentally.
FWIW, this is an enum, so you can easily write your own "clone" method from user code, e.g.
fn clone_with_thread_rng(scheme: &PaddingScheme) {
    match scheme {
        PaddingScheme::PKCS1v15Encrypt => PaddingScheme::PKCS1v15Encrypt,
        PaddingScheme::PKCS1v15Sign { hash } => PaddingScheme::PKCS1v15Sign { hash },
        PaddingScheme::OAEP { digest, mgf_digest, label } => PaddingScheme::OAEP { digest: digest.box_clone(), mgf_digest: mgf_digest.box_clone(), label: label.clone() },
        PaddingScheme::PSS { _salt_rng, digest, salt_len } => PaddingScheme::PSS { salt_rng: Box::new(rand::thread_rng()), digest: digest.box_clone(), salt_len },
    }
}

This will create a new instance of PaddingScheme with only salt_rng changed to a new instance of thread_rng(), which may be enough for your use-cases.

After #244, PaddingScheme is now a trait, so this is no longer relevant


can we set image (dynamic size --> fit to slice segment frame) and text in center for slice for any no. of slices in wheel?

Hi, is it possible to set image (dynamic size --> fit to slice segment frame) and text in the center of the slice for any no. of slices in the wheel? I actually tried and get the following output but not able to set image and text in the center but with a vertical offset, we can not get desired output. Any help would be appreciated. can you provide some guidance?

@sh-khashimov, can you provide some guidance or help?

@sh-khashimov from where we can get each slice frame for the wheel? Any idea or suggestions.

@sh-khashimov can we handle slice text ad image with vertical offset in the center of the slice of the wheel or with something else can you provide some suggestion or help then it will be helpful.

@sh-khashimov thanks for the quick reply,
I'm using these for slice configuration like in your library example
let sliceContent = [Slice.ContentType.assetImage(name: prize.imageName, preferences: .variousWheelPodiumImage),
                                Slice.ContentType.text(text: prize.name, preferences: .variousWheelPodiumText(textColor: prize.textColor))]
            var slice = Slice(contents: sliceContent, backgroundColor: prize.color)

Wherein background color I set UIColor with pattern image for square purple layer
With these, it can be possible to get desired output?

Take a look at the example project, which you can see at BackgroundImageExampleViewController.swift.
You should set the image to backgroundImage, not a backgroundColor to the Slice.
Then you can change content mode for background image at fortuneWheel.configuration?.wheelPreferences.slicePreferences.backgroundImageContentMode.


Updated Azure CLI = 2.0.80

Is it possible to update cli version to 2.0.80
Im looking to use: az apim backup
It haves some issues in earlier versions.
Now they added som arguments, but when i apply them i get this:
**ERROR: az: error: unrecognized arguments: --backup-name a-name --storage-account-name a-storage --storage-account-container backup --storage-account-key *****
I tried it local with 2.0.80 and it is supported in the latest version.

Hey @ybelMekk, thanks a lot for crontributing by opening this issue !
Do not hesitate to push a PR with the proper correction if by any chance you feel happy to contribute more 😉
In the meantime, you can still build the image with desired azure CLI & Terraform versions as described in the documentation

Hello! And  thanks for response. Yeah a PR could be a good idea. I use this with github actions and I could not find a option for : docker build in the cointainer options at github actions, only docker create options. So I was not able to set the version my self. Could it be possible to add env. That the cointainer can snap up then using it, like say with G.A? Thanks again. Y

Hello @ybelMekk , I've merged the version update so you should be able to use az apim backup now!
I suggest that you open a new issue to discuss the addition of environment variables 😉


feat(vehicle_cmd_gate): add the keep stopped if steering is not converged parameters

Description

https://github.com/autowarefoundation/autoware.universe/pull/5183
Tests performed
Tested on Psim, worked as we expected.

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Closed because of the latest discussions in main PR: https://github.com/autowarefoundation/autoware.universe/pull/5183


Dropdown Right with Bootstrap 4.1.0 Broken

It looks like the styles and placements were updated again.

How can bootstrap make a breaking change without a major version bump? Are they not following semver?

Perhaps spoke too soon. Not sure how but updated all dependencies including Popper and Bootstrap.

There's now an additional left:0 in the style attribute. It was causing my right align menu to get borked.


Скласти таймлайн

Скласти список всіх (важливих) життєвих подій, визначних дат, досягнень, періодів, що дали приємний і неприємний досвід, тощо. В цьому конкретному випадку довгих списків не буває, натомість бувають погано згорнуті, тому пакуємо сюди все підряд, а про "лишні" події можна буде промовчати пізніше. Список повинен бути систематизованим і посортованим в такий спосіб, щоб читач швидко зрозумів "паттерн" і міг легко орієнтуватись в просторі і часі цього резюме.

EXPERIENCE

2018
Amongst many fighters of the past was featured in the movie "Ready Player One". Ryu ready always!
2017
United with unknown until then to me Power Rangers to defea resurrected M.Bison.Damn good fighters they are, even not knowing karate ways!
2016
In "Street Fighter V" once and for all erased M.Bison from earth and tamed my inner Evil Ryu. Also spent some time on a side-project, mini-series "Street Fighter: Resurrection".
2014
Filmed in a martial arts tutorial "Street Fighter: Assassin's Fist", revealing to the audience forgotten art of Ansatsuken.
2012
The gods of intenet concluded me in the animated movie "Wreck-It Ralph", but rewarded me with a good drink for it!
2008
My evil alter ego sneaked out of control and became a boss in "Street Fighter IV".
2006
Borrowed my famous ripped gi to Soki in "Onimusha: Dawn of Dreams", gods informed me he needed that for the battle.
1998
Defeated M. Bison in "Street Fighter Alpha 2", bastard wanted to use my heroic body for his evil intentions, but retreated with shame. Also this year I encountered Marvel universe in "Marvel vs. Capcom: Clash of Super Heroes" fighter,loyal to my employer, Capcom, of course.
1997
Reunited with Ken, my friend and opponent in "Street Fighter III". Men's friendship works mysteriously. Also helped with Arika project "Street Fighter EX"
1996
Took care of villainous Akuma in "Street Fighter Alpha 2". As a freelance on "Super Puzzle Fighter II Turbo" tried myself in a new genre, puzzle games. Let the wrath of seven heavens come upon these malicious enigmas, never again!
1995
Kept fighting in "Street Fighter Alpha: Warriors' Dreams".
1994
Screened in a movie "Street Fighter", so that the batllesof past would not be forgotten by millenial generation.
1991
Was promoted to "Street Fighter II". Didn't stay there for long, celebrations and office dwelling is not for me!
1987
Started working for Capcom project "Street Fighter". My partner was Ken Masters, the boss'name was Sagat.

PUBLICATIONS

2011
The true and humble story of me under pseudonym Tyler Wilde in an article "The evolution of Ken and Ryu"
2003-2018
For 15 years I have published comic books with Udon Entertainment depicting my adventures, bitter lessons and great victories.

Experience

Recent

2018

                        Amongst many fighters of the past was featured in the movie
                        "Ready Player One". Ryu ready always!

2017

                        United with unknown until then to me Power Rangers to defeat resurrected M.Bison. Damn good
                        fighters they are, even not knowing karate ways!

2016

                        In
                        "Street Fighter V"
                        once and for all erased M.Bison from earth and tamed my inner Evil Ryu. Also spent some time on
                        a side-project, mini-series
                         "Street Fighter: Resurrection".

2014

                        Filmed in a martial arts tutorial
                         "Street Fighter: Assassin's Fist",
                        revealing to the audience forgotten art of Ansatsuken.

2012

                        The gods of intenet concluded me in the animated movie
                         "Wreck-It Ralph", but rewarded me with a
                        good drink for it!

In good old days...

2008

                        My evil alter ego sneaked out of control and became a boss in
                         "Street Fighter IV".

2006

                        Borrowed my famous ripped gi to Soki in
                         "Onimusha: Dawn of Dreams", gods informed
                        me he needed that for the battle.

1998

                        Defeated M. Bison in
                         "Street Fighter Alpha 2", bastard wanted to
                        use my heroic body for his evil intentions, but retreated with shame. Also this year I
                        encountered Marvel universe in
                         "Marvel vs. Capcom: Clash of Super Heroes"
                        fighter,loyal to my employer,  Capcom, of
                        course.

1997

                        Reunited with Ken, my friend and opponent in

                          "Street Fighter III". Men's friendship works mysteriously. Also helped with Arika project
                         "Street Fighter EX".

1996

                        Took care of villainous Akuma in
                         "Street Fighter Alpha 2". As a freelance on
                        "Super Puzzle Fighter II Turbo"
                        tried myself in a new genre, puzzle games. Let the wrath of seven heavens come upon these
                        malicious enigmas, never again!

1995

                        Kept fighting in
                         "Street Fighter Alpha: Warriors' Dreams".

1994

                        Screened in a movie  "Street Fighter", so
                        that the batllesof past would not be forgotten by millenial generation.

1991

                        Was promoted to  "Street Fighter II". Didn't
                        stay there for long, celebrations and office dwelling is not for me!

1987

                        Started working for Capcom project
                         "Street Fighter". My partner was Ken
                        Masters, the boss'name was Sagat.

Publications

2011

                        The true and humble story of me under pseudonym Tyler Wilde in an article "The evolution of Ken
                        and Ryu"

2003 – 2018

                        For 15 years I have published comic books with Udon Entertainment depicting my adventures,
                        bitter lessons and great victories.


Intent Test: FragmentScannerTest

Scanner is independent from our code largely: can't test scanning QR codes. Will test going from scanner to various other fragments if i have time tomorrow, otherwise close


Placeholder issue for next steps control implementation

New features
Support more control listen variables:

From basin: storage and area
[ ] From flow edges: flow (in Control \ condition turn listen_node_id in listen_feature_id)
[ ] when users have been added: the abstraction flow rate of a user
Forcing? Net change of basin?

Support more control affect nodes:

[x] Give nodes other than pump also a control_mapping in the Julia core: FractionalFlow, LevelBoundary, FlowBoundary, LinearResistance, ManningResistance. For this also make a function like parse_static which handles having either controlled or uncontrolled nodes (when the control_state column is missing). Having time governed nodes should eventually also come in to this. Afterwords remove warnings in docs that only pump control is supported.
[ ] Supporting TabulatedRatingCurve probably takes some more individual effort. See #348
Basin profile? That would require special treatment since the profile is not specified in Basin / static.

Control output:

[x] Create new output file in Julia core with record of what control did and when: https://github.com/Deltares/Ribasim/pull/303

Miscellaneous:

[ ] Make sure no fast oscillations occur between control states by setting minimal times for control states (time keeping already implemented): https://github.com/Deltares/Ribasim/issues/374
[ ] Rename Control to DiscreteControl to make the distinction with PID control clear: https://github.com/Deltares/Ribasim/issues/375

QGIS plugin

[x] Plot control and flow edges with different colors, maybe also plot (implicit) listen edges

Documentation

[x] Set up a more realistic example with control in examples.ipynb, e.g. the one used for the samenwerkingsdag presentation
[x] Update addnode.qmd

Validation

[ ] Add control graph validation (Julia)
[ ] Add edge type validation in Ribasim core (currently only "flow" or "control") (Python, Julia)
[ ] Add control logic validation (Python, Julia); e.g. the control nodes only come to control states which are defined for the nodes controlled by that control node, there is precisely one control state for every truth state.

Tests

[x] Add Julia tests on various control behaviours based on control output file

Code refactoring

[ ] Python: Edge.plot kwarg handling, Model.plot_control_listen
[ ] Possibly the schemas involving control, e.g. not having truth_state and control_state as strings. (other possibility: add wildcard option in truth state in stead of only true and false)

Based on PID control. We leave the preprocessing (such as deviation of net precipitation shortage) up to the user

[ ] New condition based on time lookup with dT.

I think we should consider basin-profile and boundary nodes as a given specification that can not/will not be controlled.
Also it is very unlikely (at the moment) that we want to control on volume or surface water area of the basin.
Volume control only may come into scope we ever need to include water accounting (ie reservoing water volumes for specific owners/users and managing that on a volume basis),


Use takeOwnership in File constructor

fix #44

Wow. How did I do that?

Unit test added via #46.


confusion matrix plots

closes #123

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 94.153%

Totals

Change from base Build<PHONE_NUMBER>:
0.9%

Covered Lines:
2367

Relevant Lines:
2514

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 94.285%

Totals

Change from base Build<PHONE_NUMBER>:
1.0%

Covered Lines:
2425

Relevant Lines:
2572

💛  - Coveralls


Tooltip

https://github.com/skclusive/Skclusive.Material.Component/issues/12
WIP
Usage:
<Tooltip>
    <TitleComponent>
        <Typography<EMAIL_ADDRESS>text</Typography>
    </TitleComponent>
    <ChildContent>
        <Button<EMAIL_ADDRESS>    </ChildContent>
</Tooltip>

or
<Tooltip Title="Tooltip text">
      <Button<EMAIL_ADDRESS></Tooltip>

I need some help here. I can't get the transition to work properly.
I tried using the Styles from the transition context but that does not seem to work correctly. Using the reference seems like the only way. But as far as I understand it, the transition begins before the Popper is created (?) and thus the transition does not work when Tooltip is appearing (it works when it is disappearing or when I keep it mounted).

great. will check it.

@esso23 this is really great effort. you have taken one of the complex primitive component. i would need to check this out locally and will update you.
thanks for this contribution. encourages me to concentrate and start working on this library again. :-)

@esso23 looks great. i see we have both primitives Popper and Tooltip (though Tooltip depends on Popper).
can we split them and push the Popper as a standalone component without Tooltip and verify it satisfies the requirement for that component compared to Material-UI?
Once Popper is implemented and tested with samples (https://material-ui.com/components/popper/#popper) we can built the Tooltip component on top of it.
doing so we will end up with one more project (we have to find a better approach fixing multi project) Popper and Tooltip.
do you think this works? because i faced same issues while doing multiple components together. so i started implementing each primitive component one after another with samples to verify against material-ui.

Thanks.
No problem with splitting the project, should be easy. But in the original post I mentioned I have a problem (the implementation is not finished).
Could you help me with that first? I spent like 2 days trying to make the transition work, but I had not success with it.

@esso23 definitely i am looking forward to help fixing the transition issue.
initially i thought the transition is related to Tooltip component. Hence recommended for splitting it which could help identifying issue. Now i checked the material-ui implementation where Popper handles childProps handleEnter and handleExit events. if that were the issue is? could you point out which code block causing the issue? I am also checking it out.

I tried the solution but I ended up just where I was before. I 'm getting the error again (see pic and this issue: https://github.com/skclusive/Skclusive.Material.Component/issues/39). That's why I tried to wrap the transition around the Popper instead of the other way around. This error occurs when the Popper attempts to close. Anyway, I don't see any transition even when the Popper is appearing.

@esso23 oh ok. that is strange. i am unusually bit occupied during this pandemic. will try to reproduce the issue and get back to you.

@esso23 hi. i have took reference of this PR and material-ui implementations and ported in https://github.com/skclusive/Skclusive.Material.Lab/tree/develop now.


In progress/past items edition

When a past or in progress item has a modification on its length, the timetable is not recomputed. Expected behaviors :

finished items : unable to edit the length
in progress items : possible to edit the length and recomputation

Closed by 9e8437b and changes performed in PandaFire/TimeGeneratorComponent


use go mod

The first commit move to use switch to github.com/google/uuid dependency.
It seems to be more well maintained and reliable at this time.
google/uuid works out of box with Go modules, because the most recently
tagged version is compatible with master (at this time, they're equal).
On the other hand, using satori/go.uuid requires reverting back to an
older API because its latest tag is more significantly behind master.
The second commit use go mod

Pull Request Test Coverage Report for Build 63

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 5.519%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sriovnet.go
0
1
0.0%

Totals

Change from base Build 61:
0.0%

Covered Lines:
34

Relevant Lines:
616

💛  - Coveralls


Option to set default sender for all the mails.

Describe the bug
It's not a bug though. I just want to check if there is a way to set the default sender in the config or mailer?
I looked at the docs but could not find that yet.
Steps to Reproduce the Bug or Issue
Not Applicable
Expected behavior
Not Applicable
Your reproducible example
No response
Screenshots or Videos
Not Applicable
Platform

OTP:
Elixir:

Additional context
Not Applicable

Hi, you can add a function to your Mailer module or any module of your choice.
import Swoosh.Email

def default_email do
  from(new(), {"Your name", "Your email"})
end

And use this function instead of new() from Swoosh.Email to start building your email.

Got it thanks.


A option to adjust where the button is

Hi I have the intergrated loquibot and the intergrated demonlist together but they overlap is there a way too adjust where the button can be placed? thanks

nvm figured something out


Refactor the models classes due to repetition

There appears to be quite a bit of repetition in the classes in models.py, especially in e.g. the __init__. I'd suggest refactoring, and moving a lot of the shared code into the base class (and then adding documentation to the base class, of course).

That's true and I'm aware of that but at this point I'm not yet sure what other models I'm going to add and how they would relate to the existing ones (there are dozens of cool VAE/VED extensions that could be tried but given the lack of time a lot will depend on the specific research needs) so I'm bit hesitant to do the refactoring now. In some sense, I'm waiting for "the bigger picture" to emerge in my head. I think that some repetition is acceptable at the early stages of any project.

Sure, not a problem. Something to keep in mind for the future; for now let's close it.


Bug in Multiple Slides Per View Demo

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 5.3.0.

Platform/Target and Browser Versions: Win10 with latest Chrome, Firefox. Also Chrome on Android.

Live Link or JSFiddle/Codepen or website with isssue: https://swiperjs.com/demos/110-slides-per-view.html

This configuration (in my code and in your demo) have a bug when swiper is reached the end.
Please look at this videos:
http://craigy.ru/t/swiper-issue/demo.gif
http://craigy.ru/t/swiper-issue/my.gif

Duplicate of #3398


Refactore Node.STORE and Commit.STORE

The patch looks rather large but it's just shuffling code around to fit the new API, so @talex5 if you want to review, you can just have a look at irmin.mli and irmin_git.mli. Hopefully this will expose enough things for your use-case.

Looks good :-) I'll try rebasing my patches on top of this...


fix: List items not read in Tooltip contents for safari and voiceover

Rally ticket
This PR attempts to fix, or at least work around, the issue where ordered (ol)/unordered (ul)/definition(dl) list items are not read in Safari + VoiceOver within a Tooltip.
Margaree also found out that it's not just the li elements within the list element that aren't being announced - it's also any other content, such as plain text before the lis.
After discussing with Margaree and Dave B, we decided to go with a work around where we can get the list content announced, but with the tradeoff that the list semantics ("bullet/list item #" etc) still aren't announced (only for VoiceOver + Safari).
Note that this change was also tested with:

VoiceOver + Chrome,
NVDA + Chrome/Edge/Firefox,
and JAWS + Chrome/Edge/Firefox,

to check that list contents are still properly announced there (with list semantics), along with plain text still being announced normally.
It was interesting to note that out of the above combinations, only the following actually had list semantics as part of its announcements (i.e. even without this change, and regardless of verbosity setting):

NVDA + Firefox
JAWS + Chrome/Edge/Firefox

This is another PR to consider merging into main directly (rather than the Visibility Switch changes feature branch), since technically it doesn't depend on any of the new Visibility Switch changes, and theoretically it shouldn't make a difference to clients yet, unless there are already uses of lists within the tooltip contents released.

Planning to merge it into the feature branch for Visibility Switch changes.

Yikes, looks like I'll need to make another PR/cherry-pick.


Feature: return error if environments exist when deleting project

Checklist

[ ] Affected Issues have been mentioned in the Closing issues section
[ ] Documentation has been written/updated
[ ] PR title is ready for inclusion in changelog

When deleting a project, return an error if there are existing environments in the project that need to be removed first.

This also goes well with #2946


Update util.js

is there any reason to put the if statement in there?

is there any reason to put the if statement in there?

yes cause i tried removing it and clicked on a button it just disables button only after a click

Well you can disable that single click issue by removing max from collector itself also

Well you can disable that single click issue by removing max from collector itself also

tried but still the same

well this is `   static get paginationEmojis() {
return ["⏮", "◀", "⛔", "▶", "⏭"];
}
static async pagination(msg, author, contents, currPage = 0) {
    /** @type {import("discord.js").InteractionCollector} */
    const collector = msg.createMessageComponentCollector({
        filter: interaction => this.paginationEmojis.includes(interaction.customId) && interaction.user.id === author.id,
        componentType: "BUTTON",
        time: 30000
    });

    collector
        .on("collect", async (interaction) => {
            await interaction.deferUpdate();
            const emoji = interaction.customId;
            if (emoji === this.paginationEmojis[0]) (currPage = 0);
            if (emoji === this.paginationEmojis[1]) currPage--;
            if (emoji === this.paginationEmojis[2]) {
                await interaction.editReply({ components: [new MessageActionRow().addComponents(...interaction.message.components[0].components.map(x => x.setDisabled(true)))] });
                return;
            }
            if (emoji === this.paginationEmojis[3]) currPage++;
            if (emoji === this.paginationEmojis[4]) (currPage = (contents.length - 1));
            currPage = ((currPage % contents.length) + contents.length) % contents.length;
            const embed = interaction.message.embeds[0]
                .setDescription(contents[currPage])
                .setFooter(`Page ${currPage + 1} of ${contents.length}.`);
            await interaction.editReply({ embeds: [embed] });
            this.pagination(msg, author, contents, currPage);
        }
        )
        .on("end", () => {
            msg.edit({ components: [new MessageActionRow().addComponents(...msg.components[0].components.map(x => x.setDisabled(true)))] });
        });
}`
Working Fine for me


ResolvePackageNotFound

配置环境
D:\videocomposer>conda env create -f environment.yaml
Collecting package metadata (repodata.json): done
Solving environment: failed
ResolvePackageNotFound:

pip==23.0.1=py38h06a4308_0
tk==8.6.12=h1ccaba5_0
zlib==1.2.13=h5eee18b_0
libstdcxx-ng==11.2.0=h1234567_1
sqlite==3.41.1=h5eee18b_0
python==3.8.16=h7a1cb2a_3
ca-certificates==2023.01.10=h06a4308_0
ncurses==6.4=h6a678d5_0
wheel==0.38.4=py38h06a4308_0
_openmp_mutex==5.1=1_gnu
xz==5.2.10=h5eee18b_1
libgomp==11.2.0=h1234567_1
libffi==3.4.2=h6a678d5_6
libgcc-ng==11.2.0=h1234567_1
setuptools==65.6.3=py38h06a4308_0
ld_impl_linux-64==2.38=h1181459_1
readline==8.2=h5eee18b_0
certifi==2022.12.7=py38h06a4308_0
openssl==1.1.1t=h7f8727e_0

I am not entirely sure if the configuration of this project can be completed on a Win system. We trained and inferred using Ubuntu and Python 3.8 environment.

I am not entirely sure if the configuration of this project can be completed on a Win system. We trained and inferred using Ubuntu and Python 3.8 environment.

thx,i will try on linux.


Improve Onyx comments and clean up some underscore methods

Details
This is largely a clean up PR that achieves a few things:

Improves comments in react-native-onyx in particular around the connect + keyChanged + keysChanged methods.
Backfills some missing functionality for the keysChanged method where it would not update an Onyx.connect() subscriber to a collection member key (can't think of why this shouldn't work but maybe we are not using it in production)
Replace several _.each() with for loops to try and speed things up at the lower levels.

Related Issues
There is no issue here. Mostly trying to improve the readability of the code and remove some _.each() we I some suspicion will be less performant than for loops.
Automated Tests
Some tests were added for the new behavior of notifying a collection member key subscriber. Automated tests should cover all of the other modifications.
Linked PRs

This has introduced a deploy blocker unfortunately something is off with the merge collection logic. https://github.com/Expensify/App/issues/11754

I think this PR just highlighted another problem which is that we are incorrectly using mergeCollection here:
https://github.com/Expensify/Web-Expensify/blob/23178afe4b30d66145173b1698c942d5cb4de4a5/lib/ReportAPI.php#L2043-L2062
cc @Julesssss
We're calling mergeCollection() with a key of reportActions_273. When it should only be used with reportActions_ and a value of {reportActions_273: {...}}.


[Do not merge yet] Regenerated Network SDK; Fixed customization typos

Description

PR: https://github.com/Azure/azure-rest-api-specs/pull/1726
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@markcowl, I've updated description and metadata. However generate.cmd doesn't work as expected now, because of changed output format of autorest --list-installed. Please note this update: https://github.com/Azure/azure-sdk-for-net/pull/3742/commits/f1baba85c699c94d2786dff85ec845f0c3861e06#diff-96cd8d413b9919dc50c4acd59ae4b201. Let me know if you have comments on this change.

@EvgenyAgafonchikov  The changes look good, except that it appears you updated a file in the tools directory

Please find explanation above.
Temporary tagged as [Do not merge] as there is one more fix in specs that we'd like to get in this version.

@EvgenyAgafonchikov this PR cannot be accepted in it's current state.
I have reached out to you over email explaining you need to merge the latest release first into the public repo and then add the new changes on top of it.
Reopen this PR once you are ready to merge as stated earlier in the email.


Merge remote-tracking branch 'upstream/stable' into merge_stable

Conflicts:
posix.mak
Manually edited:
std/datetime.d (rename toNormalizedPath -> asNormalizedPath)

I confirmed where the all changes comes from. LGTM.

Auto-merge toggled on


Sweep: create a fib.py file and a test file

sweep: the file should contain a fib(n) function that returns the nth fibonacci number

💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: None)

[!TIP]
I can email you when I complete this pull request if you set up your email here!

Actions (click)

[ ] ↻ Restart Sweep

I am currently looking into this ticket! I will update the progress of the ticket in this comment. I am currently searching through your code, looking for relevant snippets.

Step 1: 🔎 Searching
I'm searching for relevant snippets in your repository. If this is your first time using Sweep, I'm indexing your repository. You can monitor the progress using the progress dashboard

🎉 Latest improvements to Sweep:

New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To recreate the pull request edit the issue title or description.
Something wrong? Let us know.


Prepare built value

Prepares a lot of things for #171
depends on #182
EDIT:
Wherever I changed the data structure I've added tests to check for backwards compatibility (see https://github.com/Teifun2/nextcloud-cookbook-flutter/pull/183/commits/482c7737ad9d99ad901c3263c81813dd9ece0e01, https://github.com/Teifun2/nextcloud-cookbook-flutter/pull/183/commits/470a2b149cbb31b72c2e73f3caf3b61c769417d2 and https://github.com/Teifun2/nextcloud-cookbook-flutter/pull/183/commits/148187d91f5126a02c8f3f5a8089731bf2a63a16).

@Leptopoda Thanks!


LVM-LocalPV should pick the node where enough space is available for immediate binding

Currently for the immediate binding case we have two scheduling logic

Volumeweighted, here we pick the node where less number of volumes are provisioned
CapacityWeighted here we pick the node where size of all the provisioned volumes are less

These 2 are not sufficient as there is a possibility of getting a node where enough space is not availabe as none of above scheduling logic look for the free space available in the volumegroup.
Now that since we have lvmnode CR which has all the information about the volume group. We can use that to find the best node. We need to create a node map (https://github.com/openebs/lvm-localpv/blob/d4c4bebc81c9f6f955c0d03f0cc2fb991c6cf374/pkg/driver/schd_helper.go#L96) of free space in the volume group. We should make this as default option for scheduling.
The schedule currently picks the node which one less weighted(https://github.com/openebs/lib-csi/blob/develop/pkg/scheduler/scheduler.go#L81) in the map, we need to modify it to pick the highest weighted node as here we need to pick the node where free space is more.

fixed vai https://github.com/openebs/lvm-localpv/pull/178.


cocos2d-js 越来越慢的定时器schedule

这篇文章说的问题是否是一个bug？
http://www.cnblogs.com/kenkofox/p/4138048.html

Confirmed as a bug on web engine, thanks you !

We'll fix it in this issue: https://github.com/cocos2d/cocos2d-js/issues/1316


Cannot perform specific action because there does not exist a valid use pool domain

I tried this
 aws cognito-idp sign-up \
   --region eu-west-2 \
   --client-id 6o3iivoaqbslnqatt46jche42e \
   --username<EMAIL_ADDRESS>\
   --password Passw0rd!

but get this error
An error occurred (InvalidParameterException) when calling the SignUp operation: Cannot perform specific action because there does not exist a valid use pool domain associated with the user pool

Solved, had to make a domain in app integration, should this be added to the docs?

@QuantumInformation Can you show me what you had to do to get this to work? A screenshot possibly.

In this section in user pools:

@QuantumInformation Thanks for that. I'll take a look.

@quantuminformation  Actualy this is more of a workaround for testing. For production deployment, everything is written in the aws documentation
Step 2: Move Your Account Out of the Amazon SES Sandbox
Step 3: Grant Email Permissions to Amazon Cognito

@quantuminformation  Actualy this is more of a workaround for testing. For production deployment, everything is written in the aws documentation
Step 2: Move Your Account Out of the Amazon SES Sandbox
Step 3: Grant Email Permissions to Amazon Cognito

@manishcronj why the down vote?

@manishcronj why the down vote?


VoterSet and Bitfield Refactoring

This is a proposal for a refactoring (or rather rewrite) of the voter_set and bitfield modules alongside smaller related changes in the round and vote_graph, targeting the v0.11.0 branch (i.e. based on https://github.com/paritytech/finality-grandpa/pull/81).
Below is a rough outline of the main changes.
Bitfield

Simplify definition, as Bitfield::Blank and LiveBitfield(vec![])
are equivalent.
Dynamically-sized with lazy allocation makes for a more ergonomic
API and keeps bitfields smaller with larger voter sets. The reasoning
here is the following: If there are few voters, most votes
are likely on the same or very few nodes / blocks but in that case bitfields
are almost never resized anyway. As there are more and more voters,
votes are likely spread across more and more nodes / blocks and thus not
all nodes need a full-sized bitfield (whose size grows with the voter set).
Avoid allocations when merging bitfields. Previously merging would
always allocate a new bitfield, now the other bitfield is merged
into self and only allocates if self needs to be resized.
Avoid allocations when recording votes in the vote graph and computing weights.
Previously both recording of new votes and computing weights
involved creating and merging bitfields. Now incorporating a
vote into an existing vote-node is a set_bit operation while
computing the vote weight on a node is based on a bitfield-merging
iterator that does not allocate.
Better tests.

VoterSet

Make it impossible to construct inconsistent sets as well as
empty sets. Both were previously possible.
Better tests.

Related changes

Introduce a weights module for encapsulating vote-weight
arithmetic behind newtypes.
Introduce a round::context module for encapsulating the
context of a round in which vote weights are computed,
consisting of the voter set and recorded equivocations.
This combines some functionality from the previous bitfield
module and some from the parent round module.

Looks good at a skim - going to give it a more in-depth review soon. Thanks!

I've been fuzz-testing the old implementation for the last 5 days on the rh-fuzzing branch without exposing any issues. I'm worried that the rewrite opens new opportunities for logic errors, particularly in equivocation counting, GHOST, and completability.

Codecov Report

Merging #93 into v0.11.0 will increase coverage by 1.48%.
The diff coverage is 94.36%.

@@             Coverage Diff             @@
##           v0.11.0      #93      +/-   ##
===========================================
+ Coverage    88.54%   90.02%   +1.48%
===========================================
  Files           10       12       +2
  Lines         3117     3861     +744
===========================================
+ Hits          2760     3476     +716
- Misses         357      385      +28

Impacted Files
Coverage Δ

src/bridge_state.rs
96.29% <ø> (ø)
:arrow_up:

src/vote_graph.rs
98.49% <100%> (+1.53%)
:arrow_up:

src/lib.rs
83.2% <100%> (+2.5%)
:arrow_up:

src/voter/past_rounds.rs
94.62% <100%> (ø)
:arrow_up:

src/voter/mod.rs
82.88% <100%> (+0.2%)
:arrow_up:

src/voter/voting_round.rs
81.25% <100%> (ø)
:arrow_up:

src/weights.rs
82.35% <82.35%> (ø)

src/bitfield.rs
86.75% <89.77%> (+7.12%)
:arrow_up:

src/round.rs
95.23% <94.91%> (+0.91%)
:arrow_up:

src/voter_set.rs
97.43% <97.82%> (+0.76%)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286133e...f4aec49. Read the comment docs.

I would rather not merge this until it has at least the same degree of testing. [..]

I'm fine with waiting until the fuzz-testing is in master and the v0.11 and this branch subsequently rebased on top.


Change Text Color and Language to Months

How can I change the color of the text of each month? Also how can I change the language of these to Spanish? Thank you this packague is awesome!

you can use the monthBuilder input to create your own styled month headers, or the dayBuilder for the days. have a look at https://github.com/casvanluijtelaar/paged_vertical_calendar/blob/master/example/lib/main.dart#L41


PHPSlim Framework + Why GET request

Hi,
I picked up the solution from @logusgraphics  at textAngular issue to implement ng-file-upload into textAngular.
The problem is I have an issue on request made :
GET http://localhost/myblog/app/API/upload/img/ 404 (Not Found)

In my controller I have :
$scope.upload = function(){
    Upload.upload({
        url: API/upload/img',
        file: $scope.files[0],
        method: 'POST'
    }).progress(function (evt) {
        $scope.progress = parseInt(100.0 * evt.loaded / evt.total);
    }).success(function (data) {
        $scope.progress = 0;
        $scope.image = data.dir+data.filename;
    });
};

On the server side I use PHP Slim framework to make an API. I did it according to the wiki provided  :
$app->post('/upload/img', function(){
    $filename = $_FILES['file']['name'];
    $destination = '/upload/img/' . $filename;
    move_uploaded_file( $_FILES['file']['tmp_name'] , $destination );
    echoResponse(200, null);
});

My folder upload/img has the write/read permissions for all.
Why do I get a GET request to this upload/img/  ? I agree if the request would be with the file name but why to this address ? I can't upload my image anymore with the POST method.
Could you tell me if something is wrong in my conf ?
Thanks in advance.

This plugin doesn't send GET it's from another part of your code.

Dear @romainFan3466 you must be aiming wrongfully at the API's address "upload/img" that's why you're getting a 404. You must understand that this image upload implementation needs deep understanding of how AngularJS works and also Danial Farid's Upload Service. Your back end side (PHP Slim) needs to return a response with the directory and the filename in which the image was uploaded.


Data Layer with Android Dependencies

I have only skimmed through the source code, but I noticed that the UserDataStoreFactory and the RestApiImpl have a dependency on Android libraries. This appears to break the rule for the Clean Architecture Dependency Rule: "source code dependencies can only point inwards and nothing in an inner circle can know anything at all about something in an outer circle."
Is the Android Context used for the UserDataStoreFactory and could it be removed?
Is it possible to check connectivity from RestApi without dependency on Android libraries?
I am trying to find an architecture that I can write my core library that would interface with both mobile and web apps.  I like the concepts of the Clean Architecture for this.

The fact that data layer has dependencies with the android framework does not mean the rule is broken. Actually you need them otherwise I would not be able to fulfill the needs of that module.
In other words I would break that rule if I had my data layer depending on the presentation layer for example and not the other way around.
Here is the article where I explain those concepts:
http://fernandocejas.com/2014/09/03/architecting-android-the-clean-way/


Create Policy Mapper 0.5.0 release

Release v0.5.0 created.  Re-work for alignment with policy-orchestrator will happen in new branch.


[bzip2:x86-windows] build failure

Host Environment

OS: Windows
Package: bzip2:x86-windows
Vcpkg version: 2020.06.15-nohash

To Reproduce
In c:/ :
 git clone https://github.com/microsoft/vcpkg
.\vcpkg\bootstrap-vcpkg.bat
.\vcpkg\vcpkg install pcl

Failure logs
Could not locate cached archive: C:\Users\User\AppData\Local\vcpkg\archives\65\6532da60a30562cc34425daa524b71bed22ba786.zip
-- Fetching https://sourceware.org/git/bzip2.git...
-- Extracting source C:/vcpkg/downloads/bzip2-75a94bea3918e612b879d6a11ca64b8689526147.tar.gz
-- Applying patch fix-import-export-macros.patch
-- Using source at C:/vcpkg/buildtrees/bzip2/src/8689526147-1ef169fbaa.clean
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Downloading https://repo.msys2.org/mingw/i686/mingw-w64-i686-pkg-config-0.29.2-1-any.pkg.tar.xz...
-- Downloading https://repo.msys2.org/mingw/i686/mingw-w64-i686-pkg-config-0.29.2-1-any.pkg.tar.xz... Failed. Status: 28;"Timeout was reached"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:181 (message):

      Failed to download file.
      If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
      variables to "https://user:password@your-proxy-ip-address:port/".
      Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
  scripts/cmake/vcpkg_find_acquire_program.cmake:438 (vcpkg_download_distfile)
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:270 (vcpkg_find_acquire_program)
  ports/bzip2/portfile.cmake:43 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:79 (include)

Error: Building package bzip2:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then

Additional context

I don't use any proxy

I don't have any space in the path : C:\vcpkg

When I do .\vcpkg update it says me :
Using local portfile versions. To update the local portfiles, use git pull. No packages need updating.

And when I do a git pull :
Already up to date.

Failure is the download of files from the repo.msys2.org as it seems to be down at this time.

Wasn't this fixed in https://github.com/microsoft/vcpkg/issues/10322

repo.msys2.org is down, and I have to roll back to 2020.07 and change to another mirror
diff --git a/scripts/cmake/vcpkg_acquire_msys.cmake b/scripts/cmake/vcpkg_acquire_msys.cmake
index a663459eb..378456029 100644
--- a/scripts/cmake/vcpkg_acquire_msys.cmake
+++ b/scripts/cmake/vcpkg_acquire_msys.cmake
@@ -84,12 +84,12 @@ function(vcpkg_acquire_msys PATH_TO_ROOT_OUT)
     # download the new keyring, without it new packages and package updates
     # might not install
     vcpkg_download_distfile(KEYRING_PATH
-        URLS http://repo.msys2.org/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz
+        URLS https://www2.futureware.at/~nickoe/msys2-mirror/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz
         FILENAME msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz
         SHA512 a5023fd17ccf6364bc6e27c5e63aea25f1fc264a5247cbae4008864c828c38c3e0b4de09ded650e28d2e24e319b5fcf7a9c0da0fa3a8ac81679470fc6bd120c9
     )
     vcpkg_download_distfile(KEYRING_SIG_PATH
-        URLS http://repo.msys2.org/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig
+        URLS https://www2.futureware.at/~nickoe/msys2-mirror/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig
         FILENAME msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig
         SHA512 c326fefd13f58339afe0d0dc78306aa6ab27cafa8c4d792c2d34aa81fdd1f759d490990ab79daa9664a03a6dfa14ffd2b2ad828bf19a883410112d01f5ed6c4c
     )

repo.msys2.org is down, and I have to roll back to 2020.07 branch and change to another mirror
diff --git a/scripts/cmake/vcpkg_acquire_msys.cmake b/scripts/cmake/vcpkg_acquire_msys.cmake
index a663459eb..378456029 100644
--- a/scripts/cmake/vcpkg_acquire_msys.cmake
+++ b/scripts/cmake/vcpkg_acquire_msys.cmake
@@ -84,12 +84,12 @@ function(vcpkg_acquire_msys PATH_TO_ROOT_OUT)
     # download the new keyring, without it new packages and package updates
     # might not install
     vcpkg_download_distfile(KEYRING_PATH
-        URLS http://repo.msys2.org/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz
+        URLS https://www2.futureware.at/~nickoe/msys2-mirror/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz
         FILENAME msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz
         SHA512 a5023fd17ccf6364bc6e27c5e63aea25f1fc264a5247cbae4008864c828c38c3e0b4de09ded650e28d2e24e319b5fcf7a9c0da0fa3a8ac81679470fc6bd120c9
     )
     vcpkg_download_distfile(KEYRING_SIG_PATH
-        URLS http://repo.msys2.org/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig
+        URLS https://www2.futureware.at/~nickoe/msys2-mirror/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig
         FILENAME msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig
         SHA512 c326fefd13f58339afe0d0dc78306aa6ab27cafa8c4d792c2d34aa81fdd1f759d490990ab79daa9664a03a6dfa14ffd2b2ad828bf19a883410112d01f5ed6c4c
     )

vcpkg_acquire_msys in the current master made mirror adding/changing more difficult, so I have to roll back to the previous stable version.

That worked for me thanks @eugene123tw !!

Proposed above solution worked for me.
Is there any plans to fix this in the vcpkg upstream?

The msys acquisition scripts should probably be changed to automatically retry downloads from a list of known official mirrors in case repo.msys2.org fails.

Was this issue fixed in #13889?

@JackBoosY It's fixed for me.

Fixed.


CASMINST-3902: Add and update procedures related to adding river cabinets to a system.

Description

CASMINST-3902: Add and update procedures to add river cabinets to a
system.
CASMHMS-5462: Added a procedure to configure the root user account a HPE
Node. Updated the Gigabyte controller procedure.
Updated the add a standard rack node to reference WLM documentation.
Added some steps to retrieve the current expected SNMP password on sw-leaf-bmc switches.
Reworked the add NCN procedure to have better flow when configuring settings on replacement hardware.

Added a procedure to enable IPMI access on new HPE nodes, and reference it a better time when the BMC is actually reachable. This is a procedure that can be used for all types of HPE Nodes.
Configure root user procedures at a time where the BMC is actually reachable.
Also added a procedure to set time on HPE nodes. This allows the documentation to point toward documentation that is valid after the system is installed, instead of on the PIT node.

Checklist Before Merging

[ ] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[ ] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[ ] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

Left more comments on the main branch PR

I have applied all of the changes from feedback from https://github.com/Cray-HPE/docs-csm/pull/2344 to this PR.

I'm adding the "do not merge" label because I want to review this before we merge it (and have had bad luck with things being merged when I have only commented on this in my feedback but not added the label). This does not imply anything about my feelings as to the quality of the content here -- it just means that I don't know if I will have time to review this before the first time it will be considered for merging.
I will remove the label once I've finished my reviews and issues identified (if any) are addressed.

@mharding-hpe I've applied your feedback.


Wishlist and thanks

bk is exactly what I was looking for, a terminal epub reader that is easy to install on any platform or architecture. Thanks for your work!
Just wanted to comment on the to-do list you posted in the README and add a few random ideas:

configuration: key options would be number of columns to show, font size, font colour,  background colour, line spacing, possibly font family
pan/zoom/reset keybindings (useful to zoom on an image); not necessarily with dynamic text wrapping (this could be slow and the configuration file could be used to change font size and rewrap text when relaunching bk, or maybe add another keybinding to update configuration file according to the current viewing options)
double column option (terminals windows are most often wider than tall, yet reading narrow text is easier, so double columns would allow easy reading while keeping a bit more context visible if the reader wants to go back to a previous sentence)
command line options to go directly to table of contents, to a given page, or to a given chapter
command line option to show the total number of pages, author, year or any other metadata
highlight keywords found when searching
images? Yes please, would be very useful for books with maps or charts
gui? As long as the extra dependencies are not mandatory to install and use the terminal version
mobi? I don't have any but I can see how that could be useful to many people
css? I'm not sure what are the implications for an epub reader; more customization options?
html? Same
better unicode support? I didn't face any issue so far but I am just a few hours in

This is just my humble wishlist (yet long, I know, but no preessure, I'm enjoying bk already with its minimal features), thanks!

I just realized that search is already implemented, sorry. Highlighting the keyword in the text would be useful.

Hi, thanks for showing interest! In general, things that can be accomplished already are not prioritized, but a PR may be accepted. Selective responses:
your terminal can already be themed, and I'm not sure an app can control font size or line spacing (there could be an option to control the number of blank lines between paragraphs, but that seems like configuration for the sake of configuration)
I feel now that images shouldn't be supported - when I used epr, it was annoying to open an image only to find essentially a fancy line break, and the majority of images were like that. Even for maps, I would go online to search for something high res anyway. If you really want images, foliate seems nice.
epubs are zipped web pages, so image/css/html support can be combined as simply 'better epub support'
for the next release i plan to improve search highlighting, add support for links (footnotes), and make line size configurable

added a line width flag on master. it would be easy enough to add flags to start at a specific chapter or line, but it's kind of awkward if you think about it - what does 'chapter 5' mean? chapters can start at the cover, so 'the 5th chapter' could put at you at the first chapter of the story. and within a chapter is even worse, page and line number depend on the viewport. we could index by word, character, byte, but how useful is that really? maybe it would make sense to have search flags, but you can just launch and then search (well, i have to add toc search).
what's the use case for starting with table of contents open? would a useful heuristic be to open the toc if there is no saved state (it's a new epub)?

Thanks, I'll try it!
You're right, maybe it's not useful. I was thinking it could be nice to open directly the chapter you want instead of the last active page (which should still be the default of course), could be useful for non-linear books, like manuals. If you check a table of contents and confirm the chapter you want, it's easier to type a command to reach it directly than turn pages. But maybe bk supports mouse events to click directly on the TOC item? I didn't try it in a terminal that supports mouse so maybe I just missed that. Also, adding --page and/or --chapter flags would cause other issues: how do we manage saved state? Should bk overwrite the saved state when it's launched with those flags? It seems to be a corner case that causes more issues than benefits, just forget the idea (and sorry for the suggestion).
As for --toc (or similar), the idea was just to facilitate checking the content of a book without turning pages or without any user action when the book is open. It could have been combined with automated scripts, like nnn's preview-tui plugin for instance, to preview TOCs of any hovered epub instead of the cover. But in most cases, I agree that the first page (cover) is enough for previewing, and when the user explicitly wants to check the content of a book, I guess opening the book and pressing Tab is perfectly acceptable too.

Not sure if the issue is only on my end, but I can't display the help with the latest master version:
$ bk --help
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: UnusedArgsLeft(["--help"])', src/main.rs:519:16
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[nemo@Sailfish Templates]$ RUST_BACKTRACE=1 bk
[nemo@Sailfish Templates]$ RUST_BACKTRACE=1 bk --help
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: UnusedArgsLeft(["--help"])', src/main.rs:519:16
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:78
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:59
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1076
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1537
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:62
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:49
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:198
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:218
  10: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:486
  11: rust_begin_unwind
             at src/libstd/panicking.rs:388
  12: core::panicking::panic_fmt
             at src/libcore/panicking.rs:101
  13: core::option::expect_none_failed
             at src/libcore/option.rs:1272
  14: bk::main
  15: std::rt::lang_start::{{closure}}
  16: std::rt::lang_start_internal::{{closure}}
             at src/libstd/rt.rs:52
  17: std::panicking::try::do_call
             at src/libstd/panicking.rs:297
  18: std::panicking::try
             at src/libstd/panicking.rs:274
  19: std::panic::catch_unwind
             at src/libstd/panic.rs:394
  20: std::rt::lang_start_internal
             at src/libstd/rt.rs:51
  21: main
  22: __libc_start_main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

bk itself still works and can display epub files, the issue is only with showing the help. I believe it was working before (but the previous version I had was installed from crates.io).

bk never supported --help, and the current arg library - pico-args - doesn't auto generate help text. i'll switch to something nicer

Oh, my bad. I was sure it did but I probably mixed it up with something else, sorry.

added -t --toc switch to start w/ toc open. i'm curious, how often do you view epubs of manuals / reference material? i hadn't considered that use case; the previous position has less value. i usually use a pdf or a web page for technical docs.

Nice, thank you! I noticed you made it so when quitting bk -t /path/to/epub, it goes to the last saved location first, so that it can be restored later, that's cool.
Most of my manuals books are in PDF indeed, but I got some .epubs and I think it's becoming more frequent now that electronic books are getting more popular. I also have some books on history that are not really manuals, but still can be very long and convoluted, so being able to preview the TOC from nnn's preview-tui plugin without actually opening the .epub in a dedicated terminal will be nice. Since bk can't display images, I believe displaying the TOC in a preview might be more relevant for that use case than the first page, but I agree it is perhaps a rare use case.

added --meta to print metadata and exit, might be useful for previews. the output is kind of messy tho.

added text reflow, search highlighting is kept after search. closing, feel free to make individual issues

Awesome! I just updated, thanks.
On 2020-07-10 06:00 James Campos<EMAIL_ADDRESS>wrote:

added text reflow, search highlighting is kept after search.
closing, feel free to make individual issues
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/aeosynth/bk/issues/1#issuecomment-656469415


Addition of wails to the comparison list

It would be great if you can add wails to your comparison list :-)
https://github.com/wailsapp/wails
From what is see it is architecturally similar to tauri and the api layer is written in golang
It would be great to have a detailed comparison
Thanks in advance :-)

Hi !
Indeed, this could be a nice candidate for this comparison.
I never used Go, but following documentation, it shouldn't be too hard :smile:
Keeping this issue open until I have some time to do it :)
Thanks for your proposition !


Using VB-Audio cable for mic sounds scratchy

Using VB-Audio cable to project hmd mic to applications has scratchy/ poppy sounding result. Might be an issue with hardware. I just know that this works fine with any other use of Audio Cables (FL Studio for example) and the solution for Virtual Desktop works great too. I already tried increasing/ decreasing microphone latency to no avail.

Issue completely on my end a restart fixed it, closing.

Issue completely on my end a restart fixed it, closing.

You could have used Virtual Audio Cable Lite instead.


Find Bean Classes In Inherited '@Inject'-ed Field

I wondered why I had to specify @AddBeanClass with a class the same test inherited an injected field of that type. The bean class would have been found and added automatically if the injected field would have been on the test class itself as opposed to inherited. Weld also makes no such difference on whether injected fields are inherited or not so I figure weld-junit should follow the same rules with @EnableAutoWeld mode as well.
My guess is that there was an error in ClassScanning's method formerly named findAnnotatedFields and now renamed to findAnnotatedDeclaredFields having called getDeclaredFields which excludes inherited fields but the name of that method formerly named findAnnotatedFields did not reflect this restriction and was missed where it is used in scanForRequiredBeanClasses.
Producers, however, are not inherited, see https://docs.jboss.org/cdi/spec/2.0/cdi-spec.html#member_level_inheritance.

https://github.com/weld/weld-junit/issues/114

https://github.com/weld/weld-junit/issues/114

Merged.
Thanks for contributing!

Merged.
Thanks for contributing!


Shutdown error message shows up in interface, but shutdown seems to work

Current behavior
On shutting down the VM through the interface, an error message appears, saying the shutdown failed. Seconds later, the error message disappears, and the shutdown seems to have worked anyway. (Cannot ssh into machine, and state changed to stopped in the interface)

Expected behavior
Error message that shutdown failed should only be displayed when the final shutdown status is failed.

I can't reproduce this. Maybe this is related to #150?

Can't reproduce this either anymore. Was probably fixed with fixing status updates?

Probably. I'll close this for now.


[BUG] Revolut parser not working anymore

Describe the bug
Looks like Revolut changed their statement format and the script always outputs "[ERROR]: Not activities found with parser[revolut]. Please, check the statement files."

yes, I get this when I try parsing my statement:
python3 stocks.py -i revolut -o revolut-out [INFO]: Parsing statement files with parsers: ['revolut']. [INFO]: Collected statement files for processing: ['revolut/0855B379-3631-40B2-B243-D4F22B4A16E5.pdf', 'revolut/0DFA5F35-54DB-4C31-B147-426CEAAE48D9.pdf', 'revolut/16EDD70B-ACAF-43E8-A363-7AC3250FEDD8.pdf', 'revolut/295CA8F3-651B-4433-A88F-5B6ABCF13197.pdf', 'revolut/3827CCA3-BA05-4F8A-BA50-E03F105C0F32.pdf', 'revolut/4E519A45-2E27-4996-B2A1-DEE4C74B1E8D.pdf', 'revolut/5FDB1B94-B252-40CE-AD25-C80BC64F6805.pdf', 'revolut/84BA6D4E-F8B7-444C-9204-4F8440888CFF.pdf', 'revolut/DF315C1F-9504-4EC4-8707-F55BD2B415C3.pdf']. [ERROR]: Not activities found with parser[revolut]. Please, check the statement files.

from the looks of it the structure of the reports generated by revolut is completely different.

can anybody provide a sample of the old report format? I'd like to give it a short to fixing the parser

this code is beyond salvation. it's better to just do it afresh

The app will support the new support Revolut Excel format in the near future.

CSV support is being developed on this branch. The initial commit is successfully parsing and calculating all of the tax documents. The code still needs verification(Revolut is not providing some of the previously available information) and tests need fixing.

CSV support is now released: https://github.com/doino-gretchenliev/revolut-stocks/releases/tag/0.6.0.


Add Bash completion support fot bash versions older than 4.4

Hi guys,
I wanted to know why support for Bash version older than 4.4 was deliberately removed?
I think there are a lot of people who use older versions of the Bash and when they start getting familiar with Click they find autocompletions don't work out of the box. Despite having an extensible completions system, newbies to Click may decide to leave the package rather than write their own extension. It pushes new people away from using Click.
Maybe you should abandon the version check and return to choosing an option in the shell script ?
Alternatively, maybe it's worth adding a small package to the click-contrib that would patch the original BashComplete ?
I can do it if needed.

People shouldn't use ancient versions... but since CentOS 7 (which is still popular on servers and not EOL for another two years) seems to come with 4.2 maybe it indeed makes sense  to keep supporting it

Frankly, I just don't consider the situation as dire as your phrase "newbies to Click may decide to leave the package rather than write their own extension" implies. If you're stuck using CentOS 7, sorry, but I just don't think "has completion" is a decider to abandon an entire project.
You're welcome to make an extension for it. Click-Completion already exists and would be a good place for this, but maintenance activity on it has been quiet.

I just don't think "has completion" is a decider to abandon an entire project.

In my opinion, autocomplete is one of the important features of the Сlick.

I barely understand Bash completion enough to get working as-is.

The whole question in this case is only in using the nosort option

Yes, completion is an important feature. No, it's not the main reason for Click to exist, or for most users to choose Click.
Yes it's "only" that in this case. But whose to say we don't add another feature to completion, then need to figure out how to make that compatible as well? What if it turns out Bash 3 doesn't work, and users ask for that since we're already adding compatibility. As a maintainer with limited resources, I don't want to add more work to benefit a group of people that should be steadily decreasing anyway.

@untitaker,
I've created a repo https://github.com/coreegor/click-bash4.2-completion, could I put it under click-contrib?

Would you be ok moving it to pallets-eco? We're slowly trying to introduce it as the place to consolidate community-maintained projects for all of Pallets.

Yes, i would

I've invited you to the org, you should be able to move after accepting.

It's done. Thanks!


Add support for specifying a minimum protocol version

For https://github.com/ZcashFoundation/dnsseeder/issues/10 but instead of changing the constant, allow the caller to specify the version. (The constant will be then specified by dnsseeder in another PR)

Looks like we did versions for each network elsewhere.

Done in https://github.com/ZcashFoundation/dnsseeder/pull/18


[HOLD for payment 2023-07-24] Create theme/styling hooks and context components

https://docs.google.com/document/d/1KwVVu5-DLjmb-2-UwgIw5ElmyKn0ZXs8wUzxcNZjwDc/edit#bookmark=id.i5bkr5mf4hlp

any comment

@grgia Assign me to the issue, thanks!

@garrettmknight could you help with $1000 C+ review payment for @Santhosh-Sellavel's review of https://github.com/Expensify/App/pull/21667

Will collect via new dot.

Contributor+: @Santhosh-Sellavel

Request $1K on ND

Reviewed details for @Santhosh-Sellavel. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

That's the only payment for this issue so we're good to close.


fix: Eliminate use of django.utils.datetime_safe

Use standard library instead. Hard to test since the code part using datetime_safe does not seem to be called from anywhere. Another alternative to this patch attempt would be to simply remove that code part.
Fixes #4513

I'd be fine with removing the function. @rjsparks?

Seems fine to me, I don't see any use of it.

Rebased commit to remove the mentioned code instead of replacing it


Create loading lobby

For when traversing links and when waiting to load larger experiences.

Interesting idea but not very easy to implement since we don't have control once the UA consider the link traversed but we can create a scene asset to ease the task. This scene could be loaded at the very beginning if we know we are traversing a link.


Python: further trim dependencies

Describe the feature
Once the change from https://github.com/valkey-io/valkey-glide/issues/2298 is released, the deps should be:
dependencies = [
    "async-timeout>=4.0.2",
    "typing-extensions>=4.8.0",
    "protobuf>=3.20"
]

This could be further optimized, with async-timeout and typing-extensions (which is only used so far for Self) not being needed for Python 3.11+
1/
https://github.com/aio-libs/async-timeout reads:

DEPRECATED
This library has effectively been upstreamed into Python 3.11+. Therefore this library is considered deprecated and no longer supported. We'll keep the project open in the unlikely case of security issues until Python 3.10 is officially unsupported.
To migrate a project that needs to support multiple Python versions, we suggest using this code (used in our other projects, such as aiohttp):
if sys.version_info >= (3, 11):
    import asyncio as async_timeout
else:
    import async_timeout

Then in your dependencies, use:
async-timeout >= 4; python_version < "3.11"

2/
Looking for typing_extensions in the codebase on main, only 1 match came up:
https://github.com/valkey-io/valkey-glide/blob/2239c59a2232236868f2b00090aa580f96755667/python/python/glide/glide_client.py#L30
Same here, Self is available from typing starting with Python 3.11 so the requirement could be narrowed to ; python_version < "3.11"
Then adapt the code:
Potential approach from https://github.com/SimplyPrint/printer-ws-client/pull/4/files
try:
    from typing import Self
except ImportError:
    from typing_extensions import Self

Potential approach from https://github.com/stac-utils/stac-geoparquet/pull/67/files
if sys.version_info >= (3, 11):
    from typing import Self
else:
    from typing_extensions import Self

Use Case
Less unneeded deps for Python 3.11+
Proposed Solution
No response
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

Client version used
1.1.0
Environment details (OS name and version, etc.)
python 3.11 on linux amd64

Thanks for opening the issue!
Putting conditional package management solution here for later use.
We will take a look at it and will implement, understand the importance, and your examples of implementation are helpful.
Can you elaborate on your reasons for caring about it from your side? We would like to have a better grasp on users needs.
If you can share your general use case even better.
We can talk directly if you want here.

We have a list of "pre-approved" open source licenses at work (to make sure we don't inadvertently infringe on some clauses), so I made some scripts that force me to vet any new dependency (by referencing a link to its LICENSE file, which requires me to go look at the source repo for each package). This is how I ended up discovering that 2 dependencies could actually be omitted altogether for the Python version I use (3.11).
It's very minor and not a blocker for me, especially compared to https://github.com/valkey-io/valkey-glide/issues/2298

We have a list of "pre-approved" open source licenses at work (to make sure we don't inadvertently infringe on some clauses), so I made some scripts that force me to vet any new dependency (by referencing a link to its LICENSE file, which requires me to go look at the source repo for each package). This is how I ended up discovering that 2 dependencies could actually be omitted altogether for the Python version I use (3.11).
It's very minor and not a blocker for me, especially compared to #2298

We also deliver non-blocking requests :) I didn't mean to measure importance, apologizing if this how it sounds.
My intention was to get some general picture of needs and use cases so we can further learn and improve.
The request seems simple enough to be added to the close release.


Missing

I think there is only one member in this group, as saw only one fork in the  group.

This is the 2 member group. I think @AhmedCode99 has not forked yet.

Probably, he forgot to sent a request to the professor.

Well Thank you for noticing, but he is already a member.


clockwise Polygon order with quantized coordinates

I am using d3.geo.path() to render data from this datasource. At certain zoom levels some items are rendered improperly, because d3 expects the Polygon data to be ordered clockwise.
The example below shows a response containing a quantized Polygon that is correct (in my understanding of clockwise ordered coordinates), but looking at the static longitude 50.87531 it could be rendered as LineString rather than a Polygon.
My suggestion is to remove this kind of 1-dimensional polygons from the GeoJSON response, for the reason that it is not visible at the specific zoom/quantization level.
Example
http://vector.mapzen.com/osm/water/13/4253/2746.json
{
  "type": "FeatureCollection",
  "features": [
    ...
    {
      "geometry": {
        "type": "Polygon",
        "coordinates": [
          [
            [
              6.91268,
              50.87531
            ],
            [
              6.91269,
              50.87531
            ],
            [
              6.91270,
              50.87531
            ],
            [
              6.91268,
              50.87531
            ]
          ]
        ]
      },
      "type": "Feature",
      "properties": {
        "source": "openstreetmap.org",
        "kind": "water",
        "id": 130165730,
        "area": 9724
      }
    }
   ...
  ]
}

To optimize file sizes, we do trim off some of the precision on geometries based on the zoom level. With no trimming, the geometry is indeed a valid polygon:
[
    6.9126808257700585,
    50.875311142200594
],
[
    6.912687297762034,
    50.87531361348527
],
[
    6.912697182431247,
    50.875311142200594
],
[
    6.9126808257700585,
    50.875311142200594
]

Using tangram, I dug into it a little bit, and what it looks like is going on is that the very end of a water polygon is getting cut on a tile boundary. I only end up seeing the polygon at zoom level 15 though, which might be related to this comment: https://github.com/mapzen/vector-datasource/issues/136#issuecomment-137519852
We already do use area filters, but they get applied for the entire geometry's area, not the resulting clipped one. @nvkelso, if those filters are indeed to filter out items that are smaller than a pixel, we might want to also apply that filter on the clipped geometry, or maybe just a very small one. In this case, using the full precision on the coordinates, or at least what comes out of the json without any trimming, the area on the resulting geometry is: 2.0210983054318682e-11. So even if we used a very small sanity check filter, it would catch these cases.
Also I think that this approach using area as a filter would be much more robust than trying to figure out what the precision would need to be to produce a valid geometry.

What's the cost of adding the additional sanity check (per tile'd chunk of the feature, instead of just the entire feature's area)?

Doesn't look like computing area is an intense process. This looks like it, based on me poking around:
https://github.com/libgeos/libgeos/blob/cf89e5c3669ca4b650a8eb51ed34904de31fe62e/src/algorithm/CGAlgorithms.cpp#L296-L319
I'd assume that it doesn't have a huge impact, but I can measure some tiles to see.

This is what helped me getting around the rendering issue in the client:
features = features
.filter(function(feature) {
  if(feature.geometry.type === 'Polygon') {
    return !isFlatPolygon(feature.geometry.coordinates[0]);
  }
  return true;
});

function isFlatPolygon(polygon) {
  var flatX = true, flatY = true;
  polygon.reduce(function(a, b) {
    if(a[0] != b[0]) {
      flatX = false;
    }
    if(a[1] != b[1]) {
      flatY = false;
    }
    return b;
  });
  return flatX || flatY;
}

The second thing I had to apply to ensure the data is in clockwise winding order:
https://github.com/mbostock/topojson/blob/master/lib/topojson/clockwise.js

Looks pretty good! Do we want to have the cut-off configurable so that we can say for particular layers it might be 1.0 sq px, but for others we might want 0.25 sq px or similar?

Hhmm, would there be a reason to include a feature if it's smaller than a pixel?

I reckon if something's 0.9 sq px then it's pretty important, especially if you start zooming in to zoom n+0.99, then it'll be effectively 3.6 sq px. On a retina display, that might be 14.4 actual sq px.
I dunno - I just foresee us having to monkey around with this value to get it right, and figured that would be better done in the config.

+1 for configurable threshold.

Put configurability in a separate issue:
https://github.com/mapzen/vector-datasource/issues/202


mwc-checkbox link is incorrect

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/material-components/material-web/blob/d8bcc64a45c84fbcfee430f98d1bdf51b8e0fc3e/README.md?plain=1#L41
Scroll to the right
Observe that the npmjs.com link is incorrect.

Expected behavior
I was expecting the link to be correct.
Screenshots
If applicable, add screenshots to help explain your problem.
Browser Version (please complete the following information):

OS: Not applicable
Browser: Not applicable
Version: Not applicable

Additional context
The bug was introduced in af9c0471443819082850b13b9c9efb6a7a088aed. Prior to that commit, the content did not exist at all. Additionally, it appears that some links to content within the repo are outdated. Fixing would just require this:
dd if=README.md|tr "https://github.com/material-components/material-components-web-components" "https://github.com/material-components/material-web"|dd of=README.md

It appears that there are 50 instances of incorrect github links, 25 of which are for the individual components.
I'd create a pull request, but I don't want to make my Github email public.

I have no problems sharing my email, can i update this?

Closing this as obsolete


[build] Fix build with MinGW GCC 6.4

GCC 7.1 is minimal version for std::clamp:
An algorithm to "clamp" a value between a pair of boundary values | P0025R0 | 7.1
https://gcc.gnu.org/onlinedocs/gcc-7.3.0/libstdc++/manual/manual/status.html#status.iso.2017

Not sure where the non-std clamp is supposed to come from, it seems to break the build. 8125d53e58f0c08394e2e730bc88cbc57234a147 replaces std::clamp by a min/max pair.
One more reason to drop GCC 6.x support soon...

Not sure where the non-std clamp is supposed to come from

https://github.com/doitsujin/dxvk/blob/master/src/util/util_math.h#L7
template<typename T>
  T clamp(T n, T lo, T hi) {
    if (n < lo) return lo;
    if (n > hi) return hi;
    return n;
  }


docs: remove beta from local redirect policy page

LRP has move to stable. #33032

/test

/ci-multi-pool