HTTPSession Object in Stix Elevator

It appears that currently the HTTPSession Object is not converted by the Stix Elevator, and an "unconvertable_term" is produced in the corresponding pattern, which can not be instantiated as Stix2.
My understanding is that the HTTPSession object is not represented among the Observables in stix2, and is thus not part of the spec. This is also indicated by your chart responding to issue #50. If that is the case, could the elevator just not add the unconverted term to the stix2 json, and leave out the HttpSession Observable all together with a warning?  I think this would produce valid stix2 json.
Reference data below:
We have a number of objects we are processing with Observables like (xxxx added for obfuscation):
<cybox:Observable id="xxxx:Observable-3617ee44-40da-4de3-8d0d-4eba062b0a68">
  <cybox:Object id="xxxx:HTTPSession-64cc44be-98a0-4e96-b060-b4769eb5b974">
    <cybox:Properties xsi:type="HTTPSessionObj:HTTPSessionObjectType">
      <HTTPSessionObj:HTTP_Request_Response>
        <HTTPSessionObj:HTTP_Client_Request>
          <HTTPSessionObj:HTTP_Request_Line>
            <HTTPSessionObj:HTTP_Method>GET</HTTPSessionObj:HTTP_Method>
          </HTTPSessionObj:HTTP_Request_Line>
          <HTTPSessionObj:HTTP_Request_Header>
            <HTTPSessionObj:Parsed_Header>
              <HTTPSessionObj:Referer xsi:type="URIObj:URIObjectType">
                <URIObj:Value>http://sensongsmp3.cc/starmusiq/kadai-kutty-singam/</URIObj:Value>
              </HTTPSessionObj:Referer>
              <HTTPSessionObj:User_Agent>Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36
              </HTTPSessionObj:User_Agent>
            </HTTPSessionObj:Parsed_Header>
          </HTTPSessionObj:HTTP_Request_Header>
        </HTTPSessionObj:HTTP_Client_Request>
      </HTTPSessionObj:HTTP_Request_Response>
    </cybox:Properties>
  </cybox:Object>
</cybox:Observable>

that is producing Stix2 Json like this:
{
    "id": "bundle--3e2b1242-e8ac-43cc-9da2-12fff3c2b77f",
    "objects": [
        {
            "created": "2018-07-16T13:01:54.631Z",
            "id": "indicator--36296f61-afe7-4ece-866b-08a8b8dadcdc",
            "labels": [
                "unknown"
            ],
            "modified": "2018-07-16T13:01:54.631Z",
            "pattern": "[domain-name:value = 'new.clear-online.site'] OR [url:value = 'new.clear-online.site/ZWMwMDBhMDNlYzAwMGU2ODAwMDAwZTM5MDAwZTM5MDAwZTM5N2I0YzlhYjc0YQ==/?name='] OR [unconverted_term:xxxx:Observable-3617ee44-40da-4de3-8d0d-4eba062b0a68]",
            "type": "indicator",
            "valid_from": "2018-07-16T13:01:54.632487Z"
        }
    ],
    "spec_version": "2.0",
    "type": "bundle"
}

Perhaps the final [unconverted_term:xxxx:Observable-3617ee44-40da-4de3-8d0d-4eba062b0a68] could be removed by the elevator...?
Thank you all very much for your hard work on the Stix tools and your attention to this matter.
[edited by @gtback: indention and formatting]

Thanks, @tigerkatz . We deliberately chose not to (silently) drop anything from the XML when converting to JSON. We want users to be aware that content was getting modified, especially in cases when the meaning might change. I can see the use in adding an option ("off" by default) to drop indicator properties that can't be converted. @rpiazza what do you think?

The addition of an option is great. Hopefully we could still have a warning with the option, so that we are alerted when something is being dropped. We are trying to make a distinction between something that could be converted that elevator does not yet support, and something that will never be supported.

That's a good distinction to make! I also agree we should leave the warning in, though it will be possible to silence the warning as well. @rpiazza does this make more sense as a policy or a normal flag?

A few things to note:

You mention that we don't convert HTTPSession objects, which is true, since there isn't really a way to represent it in 2.0 (although using network-traffic might be acceptable).  However, the example you give seems to be a HTTPRequest, which can be represented in 2.0, and which appears to be handled by the elevator, so maybe we have a bug. The table in #50 is probably too old to be reliable.  There is a more comprehensive table at readthedocs.org, but it indicates that http_requests are not converted, so we really need to look into this and get a definitive answer.
As for the more general question of what to do with CybOX 2.x content that cannot be converted, especially in a pattern, I would resist omitting it, even if we still print out a warning.  Warnings have a way of being ignored, and the semantics of an indictor pattern could be completely different when unconvertible content is omitted.  The distinction you make between not yet convertible vs. never convertible, doesn't alter this problem.
It has been suggested that we should enable a user supplied callback function to be run in these situations, which would enable users to explicitly determine what to do in this case - including just omitting the content.

For our conversion, we have a couple considerations at play.
We have some (fortunately not a lot) of data such as HTTP Session Objects that can not be to converted to STIX 2.
Also, we need to be able to convert STIX 1 -> STIX 2 on the fly since migration will be phased in over a period of time as our users are able to switch to STIX 2.  During this time we'll be accepting inbound content in both STIX 1 & 2 format.  All inbound STIX 1 data must be converted to to STIX 2 and stored along with any inbound STIX 2 data in "real-time".  This is in addition to converting a significant amount of historical data.
For data that can NOT be converted to STIX 2, we would like to be able to exclude it from the generated STIX 2 along with a warning, while converting the rest of the package.  If it CAN'T be represented in STIX 2 there is no value to include it, we'll just have to take an extra step to remove it anyway, since the result MUST be valid STIX 2.  The callback suggestion @rpiazza described would be a very flexible way to address the matter.
We strongly prefer, whenever possible, the elevator produce valid STIX 2 output, with warnings/errors as appropriate.

@tlhampton13, I'll be looking into all of this, but in the meantime, are you aware of the "policy" option.  You can use the elevator with a policy of "strict_policy".  This will produce no output if there are any warnings - which you could determine and your users could be notified that their inbound STIX 1 does not convert to legal STIX 2.  Maybe a stop-gap solution??
The elevator keeps track if any messages are generated, and under "strict_policy" will not output STIX 2, if they were.
Of course, many of the messages are for information only - so you would have to decide which you want to to "disable" so you get output if one those would be generated.

@rpiazza We'll take a look at the "policy" feature.  Thanks!


Improve UI customizability

Trying to reach a good trade-off between library consistency and user customizability. Sticky area and week/day headers now have basic customizations (colors and widget builders) and more can be added in the future.

Example:
              weekHeaderBuilder: (context, weekDate) => GanttChartDefaultWeekHeader(
                      weekDate: weekDate,
                      color: Colors.black,
                      backgroundColor: Colors.yellow,
                      border: const BorderDirectional(
                        end: BorderSide(color: Colors.green),
                      )),

Same can be done for dayHeader and StickyArea.

Sure, I'll cleanup the code as you requested in the previous comments then update the changelog. BTW, it should be 100% backward compatible :)

Sure, I'll cleanup the code as you requested in the previous comments then update the changelog. BTW, it should be 100% backward compatible :)

the only breaking change i can see is the isHoliday parameter changing from a Function to a bool

You're right, I thought GanttChartDefaultDayHeader was for internal use only before this PR but actually it was already exposed to the consumer.
I've updated the patch with your suggestions. Should the new version be 1.0.0 or 0.2.0? I didn't want to steal the honor of bumping to 1.0.0 so I opted for 0.2.0.

Should the new version be 1.0.0 or 0.2.0?

I believe we should stay away from 1.0.0 until the library is mature enough

a new PR (#8) and version was published on pub.dev, thanks for your contribution


don't auto close on single quote

In F# the ' is prepended to an identifier to indicate it is generic in type and function signatures:
let fn (x: 'a) (y: 'b) = ...
type Box< 'a, 'b > () = ...
type Inter =
    abstract Op : 'a -> 'b -> 'c

It is also common convention to append it to binding names as it is a valid identifier char, e.g. let x = 10 in let x' = x + 5. These usages are vastly more common than using ' to surround a character literal and as such the auto close behavior is incredibly annoying when writing F#.

Hi @cloudRoutine, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Thanks @cloudRoutine !


Add version when looking for installed gcloud sdk

When used on self-hosted github actions runner without the gcloud cli installed on vm/container, it raises an error:
##[error]Unable to locate executable file: gcloud. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

I guess that this problem cannot  be replicated on github managed runners just because the gcloud is available on PATH.

Hi @paolomainardi Thanks for the PR!
I checked out the current behavior using a container runner. Dockerfile here. This seems to work as intended with the action downloading and installing gcloud. Could you provide some some additional steps to reproduce?

Hi @bharathkkb thanks for your review.
You're right a test case was missing, you can find it here: https://github.com/paolomainardi/test-gcloud-actions/
I've used a local docker container running the runner using your Dockerfile, executed as follows:
docker run -it -e REPO_OWNER -e REPO_NAME -e ACTIONS_RUNNER_INPUT_URL -e GITHUB_TOKEN -e RUNNER_TOOL_CACHE=/opt/hostedtoolcache -v /home/paolo/temp/gh-runner/hostedtoolcache:/opt/hostedtoolcache paolomainardi/gh-runner
As you can see i'm passing also the runner tool cache directory because i need it persistent between runs, i guess this is exactly as hosted GH runner behaves.
As you can see the first run was green: https://github.com/paolomainardi/test-gcloud-actions/runs/1050812877?check_suite_focus=true
name: Test gcloud cli version
on: [push]
jobs:
  setup-gcp:
    name: Setup GCP
    runs-on: k8s-runner
    steps:
      - uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
        with:
          version: "290.0.1"
          service_account_key: ${{ secrets.GKE_SA_KEY }}
          project_id: ${{ secrets.GKE_PROJECT }}
      - run: |-
          gcloud --version
      - uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
        with:
          version: "306.0.0"
          service_account_key: ${{ secrets.GKE_SA_KEY }}
          project_id: ${{ secrets.GKE_PROJECT }}
      - run: |-
          gcloud --version

But the second run of setup-gcloud wasn't really working reporting just 290.0.1, this is one of the drawback of not checking the version at first run:
root@6f7d7b02e8ed:/opt/hostedtoolcache/gcloud# ls -al
total 12
drwxr-xr-x 3 root root 4096 Aug 31 11:11 .
drwxr-xr-x 3 root root 4096 Aug 31 11:11 ..
drwxr-xr-x 3 root root 4096 Aug 31 11:11 290.0.1

Next, the second commit changes the order of the versions:
name: Test gcloud cli version
on: [push]
jobs:
  setup-gcp:
    name: Setup GCP
    runs-on: k8s-runner
    steps:
      - uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
        with:
          version: "306.0.0"
          service_account_key: ${{ secrets.GKE_SA_KEY }}
          project_id: ${{ secrets.GKE_PROJECT }}
      - run: |-
          gcloud --version
      - uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
        with:
          version: "290.0.1"
          service_account_key: ${{ secrets.GKE_SA_KEY }}
          project_id: ${{ secrets.GKE_PROJECT }}
      - run: |-
          gcloud --version

Making the pipeline fails: https://github.com/paolomainardi/test-gcloud-actions/runs/1050836982
I hope to have clarified it a bit more :)

This fix is great. Looks like I assumed users wouldn't be changing the version.

Thanks @bharathkkb and @averikitsch for the review!
I've added the compiled dist file and changed @zeit/ncc which has been deprecated in favor of https://www.npmjs.com/package/@vercel/ncc

@bharathkkb @averikitsch can you review this PR ? thanks!

@bharathkkb do we have a plan for generating the dist/?

@paolomainardi many apologies for the delay and churn, we now have an auto build process in place. Could you remove the dist/index.js from the commit.

Closed in favour of this one: https://github.com/GoogleCloudPlatform/github-actions/pull/209


std::filesystem::path support

Adding std::filesystem::path support in cereal.
Relying on the current std::string serialization since it is the underling storage for filesystem::path.

This looks pretty good, it needs a unit test like the other types, and that unit test should be properly gated behind C++17 conditionals like similar features.


Add a linux-ppc64le toolset

This is pretty far along now:

https://github.com/dotnet/runtime/issues/10055

It would be reasonable to add this toolset now.

This can be done in Zig 0.11.0; earlier versions don't have binaries available for this platform.


added repo info

examples of different microsoft projects to contribute to

The blurb you copied was supposed to be mostly for marketing purposes :) Pointing to opensource.microsoft.com as is should be good enough. Thanks for the suggestion though.


HDFS-14857. FS operations fail in HA mode: DataNode fails to connect to NameNode

This is a fix for HDFS-14857 where the datanode fails to reconnect to the namenode when the namenodes IP address(es) change in an HA environment.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
2613
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1145
trunk passed

+1
compile
43
trunk passed

+1
checkstyle
21
trunk passed

+1
mvnsite
49
trunk passed

+1
shadedclient
737
branch has no errors when building and testing our client artifacts.

+1
javadoc
31
trunk passed

0
spotbugs
130
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
128
trunk passed

_ Patch Compile Tests _

+1
mvninstall
42
the patch passed

+1
compile
39
the patch passed

+1
javac
39
the patch passed

-0
checkstyle
20
hadoop-hdfs-project/hadoop-hdfs-client: The patch generated 2 new + 7 unchanged - 0 fixed = 9 total (was 7)

+1
mvnsite
43
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
760
patch has no errors when building and testing our client artifacts.

+1
javadoc
28
the patch passed

+1
findbugs
135
the patch passed

_ Other Tests _

+1
unit
124
hadoop-hdfs-client in the patch passed.

+1
asflicense
31
The patch does not generate ASF License warnings.

6097

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1480

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 51d126024800 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / b7ae8a9

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-client.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/1/testReport/

Max. process+thread count
415 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
23
Maven dependency ordering for branch

+1
mvninstall
1059
trunk passed

+1
compile
183
trunk passed

+1
checkstyle
54
trunk passed

+1
mvnsite
122
trunk passed

-1
shadedclient
222
branch has errors when building and testing our client artifacts.

+1
javadoc
115
trunk passed

0
spotbugs
163
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
291
trunk passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
108
the patch passed

+1
compile
178
the patch passed

+1
javac
178
the patch passed

-0
checkstyle
48
hadoop-hdfs-project: The patch generated 13 new + 22 unchanged - 0 fixed = 35 total (was 22)

+1
mvnsite
113
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedclient
33
patch has errors when building and testing our client artifacts.

+1
javadoc
106
the patch passed

-1
findbugs
142
hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
120
hadoop-hdfs-client in the patch passed.

-1
unit
5233
hadoop-hdfs in the patch failed.

+1
asflicense
36
The patch does not generate ASF License warnings.

8430

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs-client

Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider.currentProxyIndex; locked 75% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:75% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:[line 67]

Failed junit tests
hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks

hadoop.fs.TestHdfsNativeCodeLoader

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1480

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux b8db6bd4a757 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d7d6ec8

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/3/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/3/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/3/testReport/

Max. process+thread count
4124 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
149
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
19
Maven dependency ordering for branch

+1
mvninstall
1336
trunk passed

+1
compile
207
trunk passed

+1
checkstyle
62
trunk passed

+1
mvnsite
135
trunk passed

-1
shadedclient
242
branch has errors when building and testing our client artifacts.

+1
javadoc
132
trunk passed

0
spotbugs
191
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
358
trunk passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
124
the patch passed

+1
compile
205
the patch passed

+1
javac
205
the patch passed

-0
checkstyle
56
hadoop-hdfs-project: The patch generated 13 new + 22 unchanged - 0 fixed = 35 total (was 22)

+1
mvnsite
127
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedclient
37
patch has errors when building and testing our client artifacts.

+1
javadoc
112
the patch passed

-1
findbugs
156
hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
132
hadoop-hdfs-client in the patch passed.

-1
unit
8273
hadoop-hdfs in the patch failed.

+1
asflicense
37
The patch does not generate ASF License warnings.

12115

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs-client

Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider.currentProxyIndex; locked 75% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:75% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:[line 67]

Failed junit tests
hadoop.hdfs.server.namenode.TestRedudantBlocks

hadoop.hdfs.TestDecommission

hadoop.hdfs.server.namenode.TestFSImage

hadoop.hdfs.server.datanode.TestRefreshNamenodes

hadoop.hdfs.server.namenode.TestStripedINodeFile

hadoop.hdfs.server.mover.TestMover

hadoop.hdfs.server.balancer.TestBalancerRPCDelay

hadoop.hdfs.server.datanode.TestHSync

hadoop.fs.TestHdfsNativeCodeLoader

hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant

hadoop.hdfs.server.datanode.TestDataNodeMXBean

hadoop.hdfs.server.datanode.TestBlockScanner

hadoop.hdfs.server.namenode.TestCheckpoint

hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1480

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux dac0d7b96d95 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d7d6ec8

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/2/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/2/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/2/testReport/

Max. process+thread count
3526 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
13
Maven dependency ordering for branch

+1
mvninstall
1281
trunk passed

+1
compile
222
trunk passed

+1
checkstyle
62
trunk passed

+1
mvnsite
138
trunk passed

+1
shadedclient
1022
branch has no errors when building and testing our client artifacts.

+1
javadoc
128
trunk passed

0
spotbugs
199
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
347
trunk passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
134
the patch passed

+1
compile
197
the patch passed

+1
javac
197
the patch passed

-0
checkstyle
57
hadoop-hdfs-project: The patch generated 14 new + 22 unchanged - 0 fixed = 36 total (was 22)

+1
mvnsite
123
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
909
patch has no errors when building and testing our client artifacts.

+1
javadoc
127
the patch passed

-1
findbugs
170
hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
129
hadoop-hdfs-client in the patch passed.

-1
unit
5248
hadoop-hdfs in the patch failed.

+1
asflicense
41
The patch does not generate ASF License warnings.

10616

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs-client

Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider.currentProxyIndex; locked 75% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:75% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:[line 69]

Failed junit tests
hadoop.hdfs.tools.TestECAdmin

hadoop.hdfs.tools.TestDFSZKFailoverController

hadoop.hdfs.TestErasureCodingExerciseAPIs

hadoop.hdfs.tools.TestDFSAdmin

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.namenode.TestNameNodeMXBean

hadoop.cli.TestHDFSCLI

hadoop.hdfs.TestDFSStripedOutputStream

hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.TestDFSStripedOutputStreamWithFailure

hadoop.hdfs.tools.TestDFSAdminWithHA

hadoop.hdfs.TestLeaseRecovery

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1480

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux ab2b4a588e39 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3d78b12

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/5/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/5/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/5/testReport/

Max. process+thread count
4013 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
78
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
23
Maven dependency ordering for branch

+1
mvninstall
1275
trunk passed

+1
compile
215
trunk passed

+1
checkstyle
55
trunk passed

+1
mvnsite
121
trunk passed

+1
shadedclient
950
branch has no errors when building and testing our client artifacts.

+1
javadoc
114
trunk passed

0
spotbugs
188
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
331
trunk passed

_ Patch Compile Tests _

0
mvndep
12
Maven dependency ordering for patch

+1
mvninstall
114
the patch passed

+1
compile
222
the patch passed

+1
javac
222
the patch passed

-0
checkstyle
53
hadoop-hdfs-project: The patch generated 15 new + 22 unchanged - 0 fixed = 37 total (was 22)

+1
mvnsite
114
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
838
patch has no errors when building and testing our client artifacts.

+1
javadoc
103
the patch passed

-1
findbugs
150
hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
124
hadoop-hdfs-client in the patch passed.

-1
unit
6175
hadoop-hdfs in the patch failed.

+1
asflicense
38
The patch does not generate ASF License warnings.

11321

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs-client

Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider.currentProxyIndex; locked 75% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:75% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:[line 69]

Failed junit tests
hadoop.hdfs.server.namenode.TestRedudantBlocks

hadoop.hdfs.TestDFSShell

hadoop.cli.TestHDFSCLI

hadoop.hdfs.tools.TestDFSZKFailoverController

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1480

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 688933a3a170 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3d78b12

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/4/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/4/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/4/testReport/

Max. process+thread count
2868 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
36
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
20
Maven dependency ordering for branch

+1
mvninstall
1104
trunk passed

+1
compile
234
trunk passed

+1
checkstyle
63
trunk passed

+1
mvnsite
135
trunk passed

+1
shadedclient
908
branch has no errors when building and testing our client artifacts.

+1
javadoc
120
trunk passed

0
spotbugs
165
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
295
trunk passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
112
the patch passed

+1
compile
190
the patch passed

+1
javac
190
the patch passed

-0
checkstyle
51
hadoop-hdfs-project: The patch generated 14 new + 22 unchanged - 0 fixed = 36 total (was 22)

+1
mvnsite
110
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
765
patch has no errors when building and testing our client artifacts.

+1
javadoc
112
the patch passed

-1
findbugs
139
hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
122
hadoop-hdfs-client in the patch passed.

-1
unit
5100
hadoop-hdfs in the patch failed.

+1
asflicense
43
The patch does not generate ASF License warnings.

9862

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs-client

Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider.currentProxyIndex; locked 75% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:75% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:[line 69]

Failed junit tests
hadoop.hdfs.TestDFSShell

hadoop.cli.TestHDFSCLI

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1480

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a48e97a07184 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 6cbe5d3

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/6/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/6/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/6/testReport/

Max. process+thread count
4112 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
426
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
1226
trunk passed

-1
compile
113
hadoop-hdfs-project in trunk failed.

+1
checkstyle
58
trunk passed

+1
mvnsite
119
trunk passed

+1
shadedclient
966
branch has no errors when building and testing our client artifacts.

+1
javadoc
109
trunk passed

0
spotbugs
177
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
311
trunk passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
108
the patch passed

-1
compile
108
hadoop-hdfs-project in the patch failed.

-1
javac
108
hadoop-hdfs-project in the patch failed.

-0
checkstyle
52
hadoop-hdfs-project: The patch generated 14 new + 22 unchanged - 0 fixed = 36 total (was 22)

+1
mvnsite
112
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
844
patch has no errors when building and testing our client artifacts.

+1
javadoc
102
the patch passed

-1
findbugs
144
hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
117
hadoop-hdfs-client in the patch passed.

-1
unit
6479
hadoop-hdfs in the patch failed.

+1
asflicense
39
The patch does not generate ASF License warnings.

11674

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs-client

Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider.currentProxyIndex; locked 60% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:60% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:[line 69]

Failed junit tests
hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots

hadoop.hdfs.server.balancer.TestBalancer

hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean

hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap

hadoop.fs.viewfs.TestViewFileSystemLinkFallback

hadoop.hdfs.tools.TestDFSZKFailoverController

hadoop.hdfs.TestDFSClientFailover

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1480

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 842e0fe3bdc5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / a3fe404

Default Java
1.8.0_222

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/7/artifact/out/branch-compile-hadoop-hdfs-project.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/7/artifact/out/patch-compile-hadoop-hdfs-project.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/7/artifact/out/patch-compile-hadoop-hdfs-project.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/7/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/7/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/7/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/7/testReport/

Max. process+thread count
2742 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
76
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
22
Maven dependency ordering for branch

+1
mvninstall
1167
trunk passed

-1
compile
114
hadoop-hdfs-project in trunk failed.

+1
checkstyle
56
trunk passed

+1
mvnsite
125
trunk passed

+1
shadedclient
916
branch has no errors when building and testing our client artifacts.

+1
javadoc
116
trunk passed

0
spotbugs
178
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
316
trunk passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
115
the patch passed

-1
compile
110
hadoop-hdfs-project in the patch failed.

-1
javac
110
hadoop-hdfs-project in the patch failed.

-0
checkstyle
51
hadoop-hdfs-project: The patch generated 14 new + 22 unchanged - 0 fixed = 36 total (was 22)

+1
mvnsite
110
the patch passed

-1
whitespace
0
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1
shadedclient
759
patch has no errors when building and testing our client artifacts.

+1
javadoc
112
the patch passed

-1
findbugs
142
hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
125
hadoop-hdfs-client in the patch passed.

-1
unit
7596
hadoop-hdfs in the patch failed.

+1
asflicense
39
The patch does not generate ASF License warnings.

12274

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs-client

Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider.currentProxyIndex; locked 60% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:60% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:[line 68]

Failed junit tests
hadoop.hdfs.server.namenode.TestRedudantBlocks

hadoop.hdfs.server.namenode.TestFSImage

hadoop.hdfs.server.namenode.ha.TestObserverReadProxyProvider

hadoop.hdfs.TestDFSClientFailover

hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots

hadoop.hdfs.server.datanode.TestDataNodeUUID

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1480

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 5a1ad76f3b35 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 9700e20

Default Java
1.8.0_222

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/8/artifact/out/branch-compile-hadoop-hdfs-project.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/8/artifact/out/patch-compile-hadoop-hdfs-project.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/8/artifact/out/patch-compile-hadoop-hdfs-project.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/8/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/8/artifact/out/whitespace-eol.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/8/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/8/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/8/testReport/

Max. process+thread count
3771 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
79
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
11
Maven dependency ordering for branch

+1
mvninstall
1210
trunk passed

-1
compile
114
hadoop-hdfs-project in trunk failed.

+1
checkstyle
56
trunk passed

+1
mvnsite
120
trunk passed

+1
shadedclient
967
branch has no errors when building and testing our client artifacts.

+1
javadoc
108
trunk passed

0
spotbugs
176
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
309
trunk passed

_ Patch Compile Tests _

0
mvndep
12
Maven dependency ordering for patch

+1
mvninstall
110
the patch passed

-1
compile
105
hadoop-hdfs-project in the patch failed.

-1
javac
105
hadoop-hdfs-project in the patch failed.

-0
checkstyle
53
hadoop-hdfs-project: The patch generated 14 new + 22 unchanged - 0 fixed = 36 total (was 22)

+1
mvnsite
111
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
837
patch has no errors when building and testing our client artifacts.

+1
javadoc
105
the patch passed

-1
findbugs
145
hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
119
hadoop-hdfs-client in the patch passed.

-1
unit
11325
hadoop-hdfs in the patch failed.

+1
asflicense
61
The patch does not generate ASF License warnings.

16166

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs-client

Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider.currentProxyIndex; locked 60% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:60% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:[line 68]

Failed junit tests
hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.namenode.TestRedudantBlocks

hadoop.hdfs.server.namenode.TestNamenodeStorageDirectives

hadoop.hdfs.server.datanode.TestDataNodeUUID

hadoop.hdfs.server.datanode.TestIncrementalBrVariations

hadoop.hdfs.TestPersistBlocks

hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots

hadoop.hdfs.TestSafeModeWithStripedFile

hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes

hadoop.hdfs.TestDFSShell

hadoop.hdfs.security.TestDelegationTokenForProxyUser

hadoop.hdfs.server.namenode.TestFileTruncate

hadoop.hdfs.TestLocalDFS

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestReconstructStripedFile

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics

hadoop.hdfs.server.namenode.ha.TestObserverReadProxyProvider

hadoop.hdfs.TestDFSClientFailover

hadoop.hdfs.server.namenode.TestSecurityTokenEditLog

hadoop.hdfs.server.namenode.TestDeleteRace

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1480

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 3ed9c7333ffa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / f826420

Default Java
1.8.0_222

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/9/artifact/out/branch-compile-hadoop-hdfs-project.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/9/artifact/out/patch-compile-hadoop-hdfs-project.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/9/artifact/out/patch-compile-hadoop-hdfs-project.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/9/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/9/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/9/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/9/testReport/

Max. process+thread count
2482 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/9/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
75
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
23
Maven dependency ordering for branch

+1
mvninstall
1211
trunk passed

-1
compile
110
hadoop-hdfs-project in trunk failed.

+1
checkstyle
57
trunk passed

+1
mvnsite
118
trunk passed

+1
shadedclient
977
branch has no errors when building and testing our client artifacts.

+1
javadoc
106
trunk passed

0
spotbugs
182
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
317
trunk passed

_ Patch Compile Tests _

0
mvndep
11
Maven dependency ordering for patch

+1
mvninstall
112
the patch passed

-1
compile
106
hadoop-hdfs-project in the patch failed.

-1
javac
106
hadoop-hdfs-project in the patch failed.

-0
checkstyle
51
hadoop-hdfs-project: The patch generated 14 new + 22 unchanged - 0 fixed = 36 total (was 22)

+1
mvnsite
109
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
841
patch has no errors when building and testing our client artifacts.

+1
javadoc
103
the patch passed

-1
findbugs
146
hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
118
hadoop-hdfs-client in the patch passed.

-1
unit
6096
hadoop-hdfs in the patch failed.

+1
asflicense
36
The patch does not generate ASF License warnings.

10933

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs-client

Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider.currentProxyIndex; locked 60% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:60% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:[line 68]

Failed junit tests
hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap

hadoop.hdfs.server.namenode.ha.TestObserverReadProxyProvider

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1480

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 30efc57652f4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / f209722

Default Java
1.8.0_222

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/10/artifact/out/branch-compile-hadoop-hdfs-project.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/10/artifact/out/patch-compile-hadoop-hdfs-project.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/10/artifact/out/patch-compile-hadoop-hdfs-project.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/10/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/10/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/10/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/10/testReport/

Max. process+thread count
3037 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1480/10/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

I am not sure why this is not syncing with the JIRA.
Can you change the title to:
HDFS-14857. FS operations fail in HA mode: DataNode fails to connect to NameNode
?

I am not sure why this is not syncing with the JIRA.
Can you change the title to:
HDFS-14857. FS operations fail in HA mode: DataNode fails to connect to NameNode
?

Copied and pasted that exactly

@jeffsaremi do you mind updating with the checkstyle changes (the file has expired but mostly it was complaining about the 80 chars restriction) to see if the report shows in both (JIRA and PR) now?

I went back and revised some of the code. It looked like we're trying to do some really important stuff right inside the perfromFailover() method. This didn't feel right and we didn't want to deal with all sorts of things that could go wrong. Instead we're doing the minimal here --  making sure the proxy is nullified -- and then when the Retry loop calls the getProxy() we deal with actual IP resetting.
This was important since we already had a lazy initializer inside AbstractNNFailoverProxyProvider and we could just reuse that .
Also there seemed to be some overlap in the old way of resettingProxy and what AbstractNNFailoverProxyProvider is doing. So we're avoiding too much redundancy.
Inside AbstractNNFailoverProxyProvider there are actually two spots that this could happen:
createProxyIfNeeded()
and
getProxyAddresses()
either one could be altered to handle the IP address reset as well.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 35s
trunk passed

+1 :green_heart:
compile
4m 12s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
3m 53s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 55s
trunk passed

+1 :green_heart:
mvnsite
2m 13s
trunk passed

+1 :green_heart:
shadedclient
17m 34s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 40s
hadoop-hdfs-client in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javadoc
0m 36s
hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
1m 19s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
3m  4s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
5m 27s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  0s
the patch passed

+1 :green_heart:
compile
4m  2s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
4m  2s
the patch passed

+1 :green_heart:
compile
3m 40s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
3m 40s
the patch passed

-0 :warning:
checkstyle
0m 54s
hadoop-hdfs-project: The patch generated 14 new + 20 unchanged - 0 fixed = 34 total (was 20)

+1 :green_heart:
mvnsite
1m 57s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m  4s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 38s
hadoop-hdfs-client in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

-1 :x:
javadoc
0m 32s
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
1m 17s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

-1 :x:
findbugs
2m 32s
hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
2m  3s
hadoop-hdfs-client in the patch passed.

-1 :x:
unit
120m 48s
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 40s
The patch does not generate ASF License warnings.

217m 31s

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs-client

Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider.currentProxyIndex; locked 60% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:60% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:[line 68]

Failed junit tests
hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader

hadoop.hdfs.TestDistributedFileSystem

hadoop.hdfs.server.namenode.ha.TestObserverReadProxyProvider

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl

hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1480/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1480

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 2d9295910ec4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e756fe35909

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1480/3/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1480/3/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1480/3/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1480/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1480/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

findbugs
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1480/3/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1480/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1480/3/testReport/

Max. process+thread count
3631 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1480/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 10s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 42s

Maven dependency ordering for branch

-1 :x:
mvninstall
22m  7s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
6m 14s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
5m 37s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 17s

trunk passed

+1 :green_heart:
mvnsite
2m 27s

trunk passed

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m  9s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
5m 40s

trunk passed

+1 :green_heart:
shadedclient
22m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 15s

the patch passed

+1 :green_heart:
compile
5m 51s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
5m 51s

the patch passed

+1 :green_heart:
compile
5m 43s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
javac
5m 43s
/results-compile-javac-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-hdfs-project-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 629 unchanged - 1 fixed = 630 total (was 630)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  4s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 7 new + 13 unchanged - 0 fixed = 20 total (was 13)

+1 :green_heart:
mvnsite
2m  9s

the patch passed

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m  1s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
2m 35s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
23m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 22s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
417m 43s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

552m 52s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs-client

Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider.currentProxyIndex; locked 60% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:60% of time  Unsynchronized access at ConfiguredFailoverProxyProvider.java:[line 68]

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestObserverReadProxyProvider

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1480/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1480

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 4838bf31a4bd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 97b5632841ca2e0cff5ac02851d667e9b97b6c76

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1480/1/testReport/

Max. process+thread count
2948 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1480/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Teaching!

File "/root/miniconda3/lib/python3.11/site-packages/timm/models/_factory.py", line 113, in create_model
raise RuntimeError('Unknown model (%s)' % model_name)
RuntimeError: Unknown model (spikingtransformer_ti)

Thanks for reporting the issue! The bug has been fixed.


Hidden Scrollbar setting doesn't work

Describe the bug
While running both OldTweetDeck and BetterTweetDeck, the hidden scrollbar option in BTT doesn't work. I am still seeing regular scrollbars on refresh.
To Reproduce
Steps to reproduce the behavior:

Go to Better TweetDeck Settings
Click on Theme
Scroll down to Style of scrollbars
Click on Hidden
Go back to TweetDeck
Refresh page
Witness regular scrollbars

Expected behavior
Step 7 above would be "Witness hidden scrollbars"
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Chrome
Better TweetDeck 4.11.2, OldTweetDeck 3.1.5

Additional context
Add any other context about the problem here.

Just ran into the same issue after restarting Chrome, I assume an update was pending. Default scrollbars instead of being Hidden, Default or Thin have no effect either. BetterTweetDeck settings for "Style of scrollbars" are no longer working.
Chrome "Version 121.0.6167.8 (Official Build) beta (64-bit)"
Using the latest versions of OldTweetDeck and BetterTweetDeck from this GitHub.
Are you still maintaining this, @dimdenGD? Thanks!

After latest update I've also had the default (ugly) scrollbars - but after two, three refreshes of tweetdeck everything was normal again 👍

Also having this issue after updating to Chrome 121 (121.0.6167.86) this morning. Refreshing a few times, as mentioned above, doesn't seem to fix it.

Also having this issue. Seems like it has something to do with the newest chrome version because last night I did not have it and now I do and now I have this issue.

I looked at the CSS using DevTools in Chrome and found that html.dark .column-scroller has overflow-x: hidden.

If I change this to overflow: hidden, the vertical scrollbars disappear, as they should be with the toggle set to "Hidden" in BTD. I believe this same value is conflicting with Chrome extensions which are supposed to modify or hide the scrollbar as well; they work everywhere but OldTweetDeck (and X Pro for that matter).
For the horizontal scrollbar at the bottom, if you have a lot of columns, there's another value that has to be changed; overflow-x: auto to overflow-x: hidden... or just remove one and set the other to overflow: hidden.

@dimdenGD - Is this something that could be fixed in this extension? Or perhaps in OldTweetDeck? Thanks!

Had to delete my initial comment because it was wrong... after further review, I believe I found which change caused the issue in Chrome after a release a few weeks ago; they added a new property for scrollbar-width.

If I add scrollbar-width: none (BTD "Hidden"), any vertical and horizontal (if you have a lot of columns) disappear while still allowing to scroll. If I change it to scrollbar-width: thin (BTD "Thin"), the scrollbars get thinner.
@dimdenGD - Is this something that could be adjusted in this extension's "Theme > Style of scrollbars" settings to fix compatibility with Chrome? Thanks!

So, easy fix for this: go to the Settings page of the extension, select Custom CSS and add this:
.scroll-styled-v {     scrollbar-width: thin; }
Change thin to none if you want it hidden.

Easy fix for this: go to the Settings page of the extension, select Custom CSS and add this:
.scroll-styled-v { scrollbar-width: thin; }
Change thin to none if you want it hidden.

That's a great idea instead of doing it manually every time you open or refresh the site.
Since I'm using the Dark theme and want both horizontal and vertical scrollbars hidden, I added the below to my Custom CSS page:
html.dark, .scroll-styled-v, .scroll-styled-h {scrollbar-width: none;}


Use single instance of AppServiceConnection for preview pane thumbnails

Before it was loading a new one each time, which I think may have caused other issues after continued use.

Careful! Does this work after minimizing and restoring the app? I think it may end up using a non-null but closed connection. Also before it wasn't creating a new connection every time.

@gave92 Oh? I thought that Instance returned a function to create a new connection.
In that case, this PR is pointless and should be reverted.
My mistake, sorry for this.

No problem. Previous code was:
public static Task<AppServiceConnection> Instance = BuildConnection();
 ....
var connection = await Instance;

This should be causing a new connection to be created only the first time "await Instance" is called, after that it should be returning an already completed Task with the existing connection as result. If you find that this does not hold true please let me know xD


Add aspectRatio property to responsive doc

Hi There!
This PR includes a single but really useful property documentation for custom aspect ratio charts.
What was my motivation behind this PR?:

The tons of time I spent looking into different issues, StackOverflow pages, and blogs about how to put a 1:1 aspect ratio to my chart.
A lot of comments on different issues where people ask to add this property to the docs
The powerful feature that this property has.

This property is currently fully supported and tested, you just forgot to add it into the docs.
Please review if you feel comfortable with the description I added. If you want to propose another one just comment and I'll gladly change it :).
I hope this change can help a lot of people.
You can find a preview of the MD file in the following screenshot:

Thanks! 🚀

@simonbrunel @etimberg PR updated with the last comments.

@benmccann PR updated with last feedback

I like making it impersonal as well. Simon's suggestion sounds good to me

@benmccann @simonbrunel Cool, I'll make the change during the day

Updated

Thanks @danielcb29


New easycontrol firmware version 05.00.01

I've got new Firmware for my easycontrol today:
bosch_thermostat_client.exceptions.FirmwareException: You might have unsupported firmware version 05.00.01

Fixed in v0.25.1


MAP-1489: Remove indefinite caching in locations service

We thought that the service was spawned once pre request, but it is actually a long-lived object so this code would cause the constant values to be kept in memory until pod restart, so any new values would never be retrieved. Instead we will remove this code and let Redis handle the caching.
MAP-1489

👍


Implement MapAssertion assertions for BTreeMap

Step 2 for #66 in BTreeMap support or specifically an implementation of MapAssertion for BTreeMap. We adjusted the MapLike trait to properly expose utility functions (get, keys etc) and used those in changed MapAssertion to be implemented for any MapLike.
The most important part is that the apporach taken here would not require existing customers to change any code which was tricky considering the hash_map::Keys being returns previously for key set assertion :)

Pinging @cocuh for review 😅

Oops, I missed this PR.  Thank you for the ping!


Add expert mode to elas game

This PR adds an expert mode to the hidden ELAS game

And I like the Elas lollypop :)

Changes:

improved the logic for the different modes
added an independent counter for the modes
removed scoring from the title and placed the scoring board on top of box
added reset button
fixed re-shuffling after switching modes

to do:

[ ] Holding the cheat key results in a flickering dialog.


docs: Added Handling User Events (onClick, onChange, etc.) Event Binding and Event Handlers Synthetic Events in React Passing Arguments to Event Handlers

📑 Description
Added about every events, Event Binding and Event Handlers, Synthetic Events in React, Passing Arguments to Event Handlers (arrow, bind, curried) and Best Practices  in detail with examples. Also, added corresponding to that folders in codes > eventHandlingCode.
✅ Checklist

[x] I have made corresponding changes that follow the style of this project.

🔗 Related Issue(s)
Fixes #20
🚀 Types of changes

[x] Documentation update (docs for this project)

📸 Screenshots (if applicable)

💬 Additional Comments (if applicable)

Hi, Can you please add the 'Hacktoberfest-accepted' label to this?

Hey @Shrey0610 ,
I have reviewed and suggested some changes please update them so I can merge this PR & label it. Thank you

I have made the necessary corrections, you can check now.


fix(test): add pragma for autolayout wasm test

GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?

What is the current behavior?

When_AbsolutePosition_WithPadding test failling because of a different behavior in WinUI and Wasm

What is the new behavior?

When_AbsolutePosition_WithPadding  use different data for wasm

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tested code with current supported SDKs
[ ] Docs have been added/updated which fit documentation template. (for bug fixes / features)
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
[ ] Contains NO breaking changes
[ ] Updated the Release Notes
[ ] Associated with an issue (GitHub or internal)

Other information
create issue in Uno to solve the root issue
https://github.com/unoplatform/uno/issues/11410
Internal Issue (If applicable):


Check if user context is array (fix fatal error)

This fixes an issue, if anything but an array is passed to Laravel/Monolog context as key user.
Assumption: sentry driver is configured as laravel logging driver
Example: Faulty behavior (before):
\Log::error('some error', [
    'user' => 'john_doe',
]);

==> Causes fatal error (in symfony/laravel usually wrapped in FatalThrowableError exception):
Argument 1 passed to Sentry\State\Scope::setUser() must be of the type array, string given, called in .../vendor/sentry/sentry-laravel/src/Sentry/Laravel/SentryHandler.php on line 178

(because user is directly passed to sentry setUser method as it's !empty)
Solution (this PR):
Changing the check from !empty to is_array makes sure this kind of error is prevented

Good idea, I tested the behavior, with your changes a warning is shown in sentry user interface.
Example:
\Log::error('Some error', ['user' => 'myusertest']);

I did not expect that warning in the Sentry interface but that's even better than what I assumed would happen :) Perfect!


OpenSeadragon.Viewport does not return true coordinates when animating

Finally I have an issue that can be clearly reproduced. I wanted to draw point on ISD canvas, relative to the image/map position.
Consider a case when you want to make a point at [0, 0] of the image coordinates (not the canvas or viewport but the actual image. The code should - probably - look like this (CODEPEN):
viewer.addHandler('update-viewport', function() {
    var ctx = viewer.drawer.context;
    // Point at 0 0 - convert real map/image offset to current local canvas coordinate
    var px = viewer.viewport.pixelFromPoint(
         new OpenSeadragon.Point(0,0)
    );
    // Draw circle
    var radius = 4;
    ctx.fillStyle = 'rgba(255,0,0,0.5)';
    ctx.strokeStyle = 'yellow';
    ctx.lineWidth = 1;
    ctx.beginPath();
    ctx.arc(Math.round(px.x), Math.round(px.y), radius, 0, 2 * Math.PI, false);
    ctx.stroke();
    ctx.fill();
});

The problem is that as the map is animated, there's certain lag - the map reaches the display location mich later than the rendered point. The only way to overcome this seems to be to disable animation (I much prefer UI without animations anyway):
var viewer = OpenSeadragon({
    ... stuff stuff stuff ...
    animationTime: 0
});

I wonder what is the way of dealing with this. For me personally, means of disabling the animation at load time would be enough, but generally getting the correct coordinates is also important.

You need to call pixelFromPoint with immediately set to true:
    var px = viewer.viewport.pixelFromPoint(
         new OpenSeadragon.Point(0,0),
         true
    );

The current doc is confusing, but we updated it for the next version: https://github.com/openseadragon/openseadragon/blob/master/src/viewport.js#L1000-L1009

Awesome! Thanks a lot!


OnClik in PanelHolder.Tab()

Ben, good health !
Strange behavior: if you click on the Tab quickly ceases to be called a handler. Try different options and see the wrong result.
package main
import (
"github.com/google/gxui"
"github.com/google/gxui/drivers/gl"
"github.com/google/gxui/themes/dark"
"strconv"
"fmt"

)
func appMain(driver gxui.Driver) {
theme := dark.CreateTheme(driver)
holder := theme.CreatePanelHolder()
for i:=0; i<15 ; i++ {
    image := theme.CreateImage()
    holder.AddPanel(image, "New "+strconv.Itoa(i))
    a := i
    holder.Tab(i).OnClick(func (gxui.MouseEvent) {fmt.Println(a)})
}
window := theme.CreateWindow(800, 600, "test the txt box")
window.AddChild(holder)
window.OnClose(driver.Terminate)

}
func main() {
gl.StartDriver(appMain)
}

That is very strange indeed. I'll investigate...

So the issue is when the tab is dragged - the dragged tab control is destroyed and a new one is created in its place, losing the event subscriptions.
I'm thinking the PanelHolder interface is broken. PanelHolder.Tab() should probably be removed and PanelHolder should adopt the regular Container interface with:
Name(Control) string
SetName(Control, string)

methods.
Why do you want to know if a tab was clicked? Aren't you really interested in knowing whether the panel is visible? If so, you can always listen to Control.OnAttach and Control.OnDetach on the panel. This approach will also work if the tab is dragged to another panel holder, unlike listening to OnClick or using PanelHolder.SelectedPanel.

Proposed new interface:
type PanelHolder interface {
	Control
	Container

	// Select will make the specified Control the selected panel.
	// Select will panic if panel is not a child of this PanelHolder.
	Select(panel Control)

	// Selected returns the currently selected panel, or nil if there are no
	// panels in this PanelHolder.
	Selected() Control

	// Name returns the name of the specified child panel.
	// Name will panic if panel is not a child of this PanelHolder.
	Name(panel Control) string

	// SetName sets the name of the specified child panel, updating the tab text.
	// SetName will panic if panel is not a child of this PanelHolder.
	SetName(panel Control, name string)
}

Yes, good, Control.OnAttach and Control.OnDetach and Name, SetName solve the most problems.
What is the general event is used when replacing the panel to configure the environment ? For example, to clear the current action.

Although if you store a pointer to the Control name do not need to...

Care to elaborate?

What is the general event is used when replacing the panel to configure the environment ? For example, to clear the current action.

I'm afraid I'm not following again. What action? Are you asking how do you remove all the panels?

I need the MAIN EVENT(for ex: OnSwitch() EventSubscription) when switching between panels. Nothing more.

I'd like to know why you need this.
 Panels can be dragged between PanelHolders - if you want to know whether a panel is visible then use OnAttach and OnDetach. If there's some other reason you'd like to be told when a panel is made active in a single PanelHolder, then I'd like to know what the usage case is before implementing it.

Control.OnAttach and Control.OnDetach must be specified in each panels. Is this not excessive if you want to produce one and the same operation when changing tabs ?
a simple example: a variable dragged = 1. When changing tabs must dragged = 0. How it can be easy to implement?

Control.OnAttach and Control.OnDetach must be specified in each panels. Is this not excessive if you want to produce one and the same operation when changing tabs ?

I don't see it is as excessive as it's the correct thing to do, and I don't think it has a common usage case. As I keep on saying, I believe that having a PanelSelected event will just encourage people to do the wrong thing. If you can give me a reason why knowing what panel is active for a single PanelHolder I'll consider adding it.

a simple example: a variable dragged = 1. When changing tabs must dragged = 0. How it can be easy to implement?

What's being dragged? For what duration is dragged == 0?
I know the language barrier is making this hard, but please describe what you are trying to do, and hopefully we can come to some sort of compromise.

Thank Ben, if you believe that having a PanelSelected event will just encourage people to do the wrong thing, then I would agree with your professional opinion. I think more on this topic.
Using OnAttach and OnDetach everything works fine.

I still need to implement the interface as discussed.


Draft VR progress slide for Andy and Bob

We need to provide Andy and Bob with guidance. Short of getting them the full roadmap, at least we should give them high-level talking points.
Here is a draft slide with some points they may cover.

Question: should we coordinate on plans for VA?

@ahwagner I've reviewed and feel the slides are sufficient for the upcoming SC status report. Ideally it would be nice to have our roadmap completed. (Maybe we should mention that in the plans - or maybe we just let that slide by?).
Anyway. I left one comment in there for you to address regarding the final point and thinking that we should accentuate/highlight VRSATILE as the spec that will provide the kind of useful implementation guidance to apply VRS and bridge that work with the VA and SA work will rely on. We may also throw in a mention that VRSATILE intends to provide use on ways to integrate VRS with VCF (something we need to not lose site of)

We do have GKS roadmap in our plans (#3), it's just not on the "ready for review" view since I'm still working on the first draft. Agreed we should get there ASAP.


Allow collector to use use hostNetwork

In the same fashion as the operator allows agents to be attached to the host network interface
This is particularly useful when configuring the address for the agents using
- name: HOST_IP
  valueFrom:
    fieldRef:
      fieldPath: status.hostIP
- name: OTEL_EXPORTER_OTLP_ENDPOINT
  name: http://${HOST_IP}:4318

@carlosjgp thanks for the contribution. Can you also create an Issue detailing out the new feature this PR implements?

I created this issue
https://github.com/open-telemetry/opentelemetry-helm-charts/issues/149

@carlosjgp thanks for the contribution!


Support extending nbsphinx-rst.tpl

Over in astropy/astropy-tutorials, we'd like to add a link to the bottom of each sphinx page generated from a notebook (and only these) that contains a link to the source notebook on github. Maybe there is an easier way, but my initial thought was to add a new section to the jinja template that generates the page. But, it looks like that is hard-coded into nbsphinx.py as a string. If nbsphinx was restructured into a package, I think it could support custom .tpl files as well via an, e.g., nbsphinx_custom_tpl option in conf.py. I tried to spec this out on my own fork of nbsphinx, but got stuck on paths (trying to get the custom template to know about the nbsphinx template, and to get nbsphinx to find the custom template in, e.g., the _static path of the sphinx source directory). Any thoughts or ideas on this? Thanks!
cc @eteq

Thanks for the suggestion!
I would also like to have a way to include links to the source notebook on Github, see #5.
I've tried to work into this direction with https://github.com/sphinx-doc/sphinx/pull/2399 and https://github.com/sphinx-doc/sphinx/pull/2454.
At some point I also wanted to extend this with an option to provide an arbitrary base URL (e.g. for Github), but it seems that I never got to it ...
I've laid out my ideas in a message to the Sphinx mailing list (https://groups.google.com/forum/#!topic/sphinx-dev/q8dGyV6dN4A), it would be great if you want to follow up on this!
Regarding the template files, I'd prefer not to expose those too much, because I would like to get rid of them in the long run. I still hope that at some point we can realize #36, and with that the template-based converter will have to go.
Having some other mechanism to put content to the top or the bottom of the page would be great though, probably something similar to rst_prolog and rst_epilog (http://www.sphinx-doc.org/en/stable/config.html#confval-rst_epilog)?

I've been thinking about custom templates as well. I'd like to be able to hide cell input by modifying the input block to:
{% block input -%}
{%- if cell.metadata.hide_input -%}
{%- else -%}
.. nbinput:: {% if cell.metadata.magics_language -%}
{{ cell.metadata.magics_language }}
{%- elif nb.metadata.language_info -%}
{{ nb.metadata.language_info.pygments_lexer or nb.metadata.language_info.name }}
{%- else -%}
{{ resources.codecell_lexer }}
{%- endif -%}
{{ insert_empty_lines(cell.source) }}
{%- if cell.execution_count %}
    :execution-count: {{ cell.execution_count }}
{%- endif %}
{%- if not cell.outputs %}
    :no-output:
{%- endif %}
{%- if cell.source.strip() %}

Seems like this would be easy to do if I could write a custom template that extends nbsphinx-rst.tpl and put it in the _templates directory(?) but I'm struggling with the same issue as @adrn.
Any thoughts on the best way to do this?

@ajp619
The template-based exporter is just an implementation detail of nbsphinx. And it will be removed once #36 is implemented.
Regarding hiding cell inputs, please see #65, #86 and #185.


Tune MySQL TPCDS image to allow for successful benchmark test run

🗣 Description
This PR include changes to make MySQL TPCDS benchmark to finish within 6 hour github runner limit. Detailed changes include:

Include indexes & MySQL custom configuration to speed up slow queries.
Build separate TPCDS test image for MySQL, independent from the TPCH test image.

MySQL TPCDS image: https://github.com/spiceai/spiceai/pkgs/container/spice-mysql-tpcds-bench
Successful MySQL benchmark test run: https://github.com/spiceai/spiceai/actions/runs/11267281342
🔨 Related Issues

📄 Documentation Requirements

🤔 Concerns

Close by: https://github.com/spiceai/spiceai/issues/3072


Asset registry and user registry alignment

Create an informative issue (See each section)
Compare the current asset-registry API with the APIs that @MHA10 sent (which is in OpenAPI format), to make sure they are aligned, accurate, and have clear descriptions for each endpoint.
We also want to make sure the user registry API performs similar to asset registry API, where users are able to enter the values to test the API

Seems like some endpoints do not have/need parameters. I would like to verify to make sure that's our intention

LINK TO WEBSITE
Using the current documentation as a model, please complete the issue template.
Prerequisite: Start with what we have
Always look at the current website to describe the change that is needed. Use the following link:
AgStack website
Describe the changes in the doc and link to your dev story
Provide info for the following steps:

[ ] Mandatory Choose the page that needs to be updated:

[ ] About
[ ] Contribute
[ ] Projects (specify project name)
[ ] APIs
[ ] Resources
[ ] Glossary
[ ] New topic

[ ] Mandatory for bugs: Clearly define what the problem is, what the change is, and link to the page:

[ ] Mandatory for content:

[ ] Add steps and/or other important conceptual information here:
[ ] Add verification at the end of the task, how does the user verify success (a command to run or a result to see?)
[ ] Add link to related dev story, if applicable

CC: @sumerjohal

Related issue: https://github.com/agstack/agstack-website/issues/15

Attempted to use the API from @MHA10 but received an error stating that we were missing a comma. Will attempt alignment w/developer help

Here is the link to the Jira link: https://team-16705118030816.atlassian.net/browse/AG-21
this issue can be closed


Master nodes need statefulset support

The latest changes for statefulset support only add it for Elasticsearch data nodes.  However, Elasticsearch cluster state is stored across all of nodes, especially the master nodes.  In order to do stateful elasticsearch well, we need the same changes to the master node templates.
Please refer to this link for information:
https://discuss.elastic.co/t/where-cluster-metadata-is-stored/44540

Hi @dcwangmit01.
This is a bit of a facepalm on my part. I'll take care of this this weekend. Thanks for the poke.

This is probably better opened and discussed in https://github.com/pires/kubernetes-elasticsearch-cluster/tree/master/stateful

@sagikazarmark I think both projects need it fixed, but I don't really see that project as a dependency.  This project is quite independent, if not just because of the chart templating.  I'm happy to file an issue there.
@clockworksoul Let me know if you'd like me to PR a fix.

Hi all. Apologies for the delay on this item. I think I have my time-consuming demons slain for the time being though!
@dcwangmit01 If you already have a fix that you can drop into a PR, that would be awesome. If not I'll do it this weekend. It should only take a few minutes in either case. :)
Additionally, as soon as it's complete I'd like to request whoever submits the PR to make an equivalent one for the pires/kubernetes-elasticsearch-cluster project manifests.


Add resampling v2

This is a cleaned up version of #360

Codecov Report

Merging #363 (225597c) into master (f079c6f) will increase coverage by 0.12%.
The diff coverage is 77.00%.

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   52.84%   52.96%   +0.12%
==========================================
  Files         127      128       +1
  Lines       19179    19279     +100
==========================================
+ Hits        10135    10212      +77
- Misses       9044     9067      +23

Impacted Files
Coverage Δ

cxx/include/mspass/seismic/Ensemble.h
98.33% <ø> (ø)

python/mspasspy/algorithms/resample.py
77.00% <77.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[12.1.x] Serialization Context Changes

https://issues.redhat.com/browse/ISPN-13041
https://issues.redhat.com/browse/ISPN-13042

Integrated into 12.1.x, thanks @ryanemerson !


change to Spanish

Hello, is it possible to change the names of months and days to Spanish? Thank you, if it is possible, what files should be modified? Thank you

The names come from the ctime library, I'm not sure whether other locales are supported. See here https://cplusplus.com/reference/ctime/strftime/


new file:   program/find-negative-of-a-number/FindNegativeOfANumber.js

Why:

Closes #ISSUE_NUMBER
What's being changed:

Why:
Closes #ISSUE_NUMBER
What's being changed:

And also you have to mention the issue number that you're solving for example: Closes #100


Improve assertion method call and fix Psalm issue

Changed log

Using the assertTrue to assert expected is true.
To be consistency, using the $this to make all assertion methods call.
Adding the @psalm-suppress DeprecatedMethod annotation for deprecated Doctrine DBAL AbstractPlatform::getName method.

I'm merging this changes at https://github.com/pheature-flags/dbal-toggle/pull/33
Thanks @peter279k for your support :raised_hands::raised_hands::raised_hands:


Adding Yii2-User to existing application

I am trying to add Yii2-user to my application which already has a User table. I received the error below. Is there a straightforward way to resolving this without having to create a self-host custom version of your plugin?
Error Info:
Array
(
[0] => 42S01
[1] => 1050
[2] => Table 'user' already exists
)

There isn't any straightforward way, but you can do following steps:

rename your user table (for example old_user)
run migrations from yii2-user
migrate data from your old_user to user table


Can this tool work well on Windows?

It is currently only tested on macOS and Linux. Windows is not yet tested (Pull request #47 adds tests for windows) but should generally work, too. Please submit a bug report if you find anything not working.


vdirsyncer fails to sync

Issue description
vdirsyncer sync fails with the vdirsyncer version from nixos-unstable. it works if I install vdirsyncer with pip.
$ vdirsyncer -vdebug sync
debug: Using 1 maximal workers.
debug: Fetching value for password.fetch with command strategy.
Syncing contacts/32
error: Unknown error occurred for contacts/32: Server did not return etag.
error: Use `-vdebug` to see the full traceback.
debug:   File "/nix/store/y9qgx26b2w2lzqhqb7sd9cb6cz8dj7pa-vdirsyncer-unstable-2018-08-05/lib/python3.7/site-packages/vdirsyncer/cli/tasks.py", line 69, in sync_collection
debug:     partial_sync=pair.partial_sync
debug:   File "/nix/store/y9qgx26b2w2lzqhqb7sd9cb6cz8dj7pa-vdirsyncer-unstable-2018-08-05/lib/python3.7/site-packages/vdirsyncer/sync/__init__.py", line 143, in sync
debug:     b_nonempty = b_info.prepare_new_status()
debug:   File "/nix/store/y9qgx26b2w2lzqhqb7sd9cb6cz8dj7pa-vdirsyncer-unstable-2018-08-05/lib/python3.7/site-packages/vdirsyncer/sync/__init__.py", line 60, in prepare_new_status
debug:     if prefetch else ()):
debug:   File "/nix/store/y9qgx26b2w2lzqhqb7sd9cb6cz8dj7pa-vdirsyncer-unstable-2018-08-05/lib/python3.7/site-packages/vdirsyncer/storage/base.py", line 149, in get_multi
debug:     item, etag = self.get(href)
debug:   File "/nix/store/y9qgx26b2w2lzqhqb7sd9cb6cz8dj7pa-vdirsyncer-unstable-2018-08-05/lib/python3.7/site-packages/vdirsyncer/storage/_rust.py", line 42, in get
debug:     native.check_error(e)
debug:   File "/nix/store/y9qgx26b2w2lzqhqb7sd9cb6cz8dj7pa-vdirsyncer-unstable-2018-08-05/lib/python3.7/site-packages/vdirsyncer/native.py", line 35, in check_error
debug:     errors.check_exception(e[0])
debug:   File "/nix/store/4xg6a6pqm9v3b1vfmjncqy0w18iqfrhj-python3.7-shippai-0.3.2/lib/python3.7/site-packages/shippai/__init__.py", line 150, in check_exception
debug:     raise exc
error: 1 out of 2 tasks failed.

Technical details
Output of nix-shell -p nix-info --run "nix-info -m":
- system: `"x86_64-linux"`
 - host os: `Linux 4.19.30, NixOS, 19.09pre173349.07b42ccf2de (Loris)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.2`
 - channels(root): `"nixos-19.09pre173349.07b42ccf2de"`
 - channels(****): `"home-manager"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Which vdirsyncer do you get via pip?  Is it the old 0.16 branch or the new 0.17 one (which was mostly rewritten in rust)?  We have the latest git version of 0.17 in nixpkgs.  Unfortunately, vdirsyncer is currently looking for a maintainer so it might be some time before this bug is fixed.

--version outputs this:
$ ~/.local/bin/vdirsyncer --version
vdirsyncer, version 0.16.7

Same problem here. Was there any reason to go for an alpha release except for the issue referenced in #33050? If not, a downgrade to 0.16.7 should be fine, since the original bug is still open and probably won't be fixed for a while without anyone maintaining vdirsyncer.

There are a few bugs that are fixed in master, so I'd rather not downgrade.  I'd be happy with a vdirsyncerStable package for the 0.16 branch though.

That'd be great! I haven't looked into packaging yet, so it would take some time if I tried. Would you mind helping out?

I just opened a PR. It’s my first time contributing to nixpkgs, so I hope it’s up to snuff.


Can not input Chinese character in Firefox 114.0.2

I am using the Firefox 114.0.2 but I can not input Chinese character. It will remain letters and will not convert to Chinese character.
It works in Edge or Chrome.

我也是用的Firefox，无法输入中文


Is there a way to customize the string returned by --version?

I use semantic versioning and would like to be able to add more detail to my versions, for example:
v1.2.3-alpha.1
v1.2.3-beta.2
v1.2.3-rc.3
v1.2.3
etc...
is there a way to override this functionality or customize it in some way.

in the project file .csproj set the version to the value you need or provide it during build:
 <PropertyGroup>
          .....
           <Version>1.2.3-alpha.1</Version>
 </PropertyGroup>

when you run
           myapp --version

it'll display
        myapp 1.2.3-alpha.1

I added the line, but it didn't change anything, I think that may only work for .NET Core applications? It still seems to be pulling my version info from my AssemblyInfo.cs (this is a .NET 4.7 application).

This applied to the new style SDK projects, in vs2017 + ,
AssemblyInfo is not used by default, and msbuild generate AssemblyInfo  during build with the corresponding elements of the csproj file.
I test this in net461 and it's working fine.
If you are using assemplyinfo:
In assemplyinfo.cs, add this line
             [assembly: System.Reflection.AssemblyInformationalVersionAttribute("1.2.3-alpha.1")]

Add this line to the project
           <GenerateAssemblyInfo>false</GenerateAssemblyInfo>

Note:   AssemblyVersion , AssemblyFileVersion are not used for version.

That did the trick! Thanks!

Glad that you resolved your issue.
A new wiki page  is added to show setting AssemplyInfo Attributes


Added bridging script

Added bridging script to deposit ETH and ERC20 tokens to L2.

Can we add an info message to let users know about the withdrawal delay in the "Withdrawals (to L1)" section?

@kailash-manasarovar can you approve?


[RFC] Component for quick layout, spacing, and typography

Moved here: https://github.com/uber-web/baseui/pull/309/files

@Warbring3r @kahwee these comments are useful, can you copy them over to the PR?

Definitely. Thanks @schnerd

Yes, done 👍