Storage endpoint as env var

Is your feature request related to a problem? Please describe.
In order to test storage integration locally I need to setup host in StorageOption Builder by myself, like this:
final storageEndpoint = System.getenv("STORAGE_ENDPOINT");
StorageOption.newBuilder().setHost(storageEndpoint).build().getService();

Describe the solution you'd like
It can be easier and more time proof if StorageOption.DEFAULT_HOST use a env var to get it's value.
Describe alternatives you've considered
I think about something like this in StorageOptions class:
private static final String DEFAULT_HOST = System.getenv().getOrDefault("STORAGE_HOST", "https://storage.googleapis.com");

I can open a PR if you agree with this implementation or have any other idea.

@frankyn Do you know if anything similar to this is done for any of the other clients?

We have it in the Node.js and Python storage clients, but it's not necessarily "official".
It was started a side project for performance benchmarking.
Maybe it's time to help make these official across libraries at this point. There are quirks that need to be ironed out a bit more though.

This has definitely been a source of confusion and bugs in the Go library, so it has to be done carefully. I do think it's a good idea to be consistent about env var naming and how this is supported across libraries though


"test-3.html" test report

Chrome & Firefox (Last Linux / Windows / Android)
On Load html
jquery.js:7152 GET http://<IP_ADDRESS>/src/css/skipback.png 404 (Not Found)

www-widgetapi.js:100 Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('https://www.youtube.com') does not match the recipient window's origin ('http://<IP_ADDRESS>').

On Play MP4/WebM

When i Clicks over the video cant Pause but shows that debug

[wrapper player3.pause()] Object {options: Object, id: "player3_youtube_iframe", mediaElement: mediaelementwrapper#player3, interval: null, name: "youtube_iframe"}
mediaelement-renderer-youtube-iframe.js:342 [youtube_iframe pause()]
mediaelement-core.js:291
[wrapper player2.pause()] <audio id="player2_html5" preload="none" src="http://<IP_ADDRESS>/media/AirReview-Landmarks-02-ChasingCorporate.mp3">…</audio>
mediaelement-core.js:291

The click over video tries to pause player3 and player2 instance instead player1
But when the video is paused and click over the video, works well

When i tries to change the volume using the slider, shows that error

mediaelementplayer-feature-volume.js:166 Uncaught ReferenceError: e is not defined(…)

And doesnt change volume
Youtube Player

When i clicks over the volume icon shows that error

Uncaught TypeError: Failed to execute 'dispatchEvent' on 'EventTarget': parameter 1 is not of type 'Event'.(…)(anonymous function) @ mediaelement-renderer-youtube-iframe.js:311

When i moves the volume slider shows that error

mediaelementplayer-feature-volume.js:166 Uncaught ReferenceError: e is not defined(…)

And doesnt change volume
MP3 Audio

When i click the volume slider shows that error

mediaelementplayer-feature-volume.js:179 Uncaught ReferenceError: e is not defined(…)

And doesnt change volume
MsEdge
On Load shows that errors
HTTP404: NOT FOUND - The server has not found anything matching the requested URI (Uniform Resource Identifier).
GET - http://<IP_ADDRESS>/src/css/skipback.png

MEDIA12606: WebVTT Text Track: Invalid file signature. hr=80004004.

MEDIA12620: TTML Text Track: Invalid XML encountered. XmlLite error code is: c00cee2d.

On Play MP4/WebM

When i Clicks over the video cant Pause but shows that debug

[wrapper player1.pause()] [object HTMLVideoElement]
mediaelement-core.js (291,6)
   "[wrapper player1.pause()]"
   <video width="640" height="360" id="player1_html5" src="http://<IP_ADDRESS>/media/echo-hereweare.mp4" preload="none" poster="../media/echo-hereweare.jpg"></video>

[wrapper player1.play()] [object HTMLVideoElement]
mediaelement-core.js (291,6)
   "[wrapper player1.play()]"
   <video width="640" height="360" id="player1_html5" src="http://<IP_ADDRESS>/media/echo-hereweare.mp4" preload="none" poster="../media/echo-hereweare.jpg"></video>

[wrapper player3.pause()] [object Object]
mediaelement-core.js (291,6)
   "[wrapper player3.pause()]"
   {
      [functions]: ,
      __proto__: { },
      id: "player3_youtube_iframe",
      interval: null,
      mediaElement: { },
      name: "youtube_iframe",
      options: { }
   }

[youtube_iframe pause()]
mediaelement-renderer-youtube-iframe.js (342,7)
[wrapper player2.pause()] [object HTMLAudioElement]
mediaelement-core.js (291,6)
   "[wrapper player2.pause()]"
   <audio id="player2_html5" src="http://<IP_ADDRESS>/media/AirReview-Landmarks-02-ChasingCorporate.mp3" preload="none"></audio>

The click over video tries to pause player3 and player2 instance instead player1
But when the video is paused and click over the video, works well

When i tries to change the volume using the slider, shows that error

SCRIPT5009: 'e' is undefined
mediaelementplayer-feature-volume.js (166,8)

And doesnt change volume

When i tries to change video to OGV format, the video continues playing but video controls dissapear without any error or warning

MP3 Player

When i click the volume slider shows that error

SCRIPT5009: 'e' is undefined mediaelementplayer-feature-volume.js (179,8)

And doesnt change volume
IE11
(The same errors than MSEdge and...)
On Load html
MEDIA12604: Text Track: Unknown MIME type. hr=8007000b.

IE10 w/Flash
(The same errors than MsEdge and IE11...)

When i tries to change video to OGV and WebM format, the video continues playing but video controls dissapear without any error or warning

IE10 w/o Flash
(The same errors than IE10 w/Flash and...)
Shows that error
Make sure you have Flash enabled; otherwise, download the latest version from https://get.adobe.com/flashplayer/

And plays correctly
IE8
Internet Explorer Hangs with that message
Faulting application name: iexplore.exe, version: 8.0.7601.18631, time stamp: 0x544b9b77
Faulting module name: mshtml.dll, version: 8.0.7601.18631, time stamp: 0x544bc3f3
Exception code: 0xc0000005
Fault offset: 0x0008fb54
Faulting process id: 0xf28
Faulting application start time: 0x01d21b7a59b85660
Faulting application path: C:\Program Files\Internet Explorer\iexplore.exe
Faulting module path: C:\Windows\System32\mshtml.dll
Report Id: 97ea7f90-876d-11e6-b917-080027ebface

I tried disabling Flash or any other addon and the same error

@ron666

@isantolin thanks for testing this. I'll take a look on these issues and see what we can do

@isantolin To give you an update, the volume issues and the click to play/pause were addressed. The issues on IE I'm investigating but one of them is because the MIME type in your machine has not been set (http://stackoverflow.com/questions/31873375/loading-webvtt-track-in-ie); IE8 issue I'll investigate more but if I test it on Browserstack and I cannot replicate it we will be in better shape. The IE10 one I'll check why the error is showing up when it shouldn't

@isantolin New update: the skipback error has been resolved as well

@ron666 For mime Types error i think you will add an .htaccess example to files
AddType video/ogg .ogv
AddType video/mp4 .mp4
AddType video/webm .webm
AddType text/vtt .vtt

@isantolin that's something stated already in the documentation as the initial step to install the plugin. I'll add some more mime types in there

Closing this ticket now since test and fixes were put in place


[BAC-715] Update Ropsten USDC asset ID

Compare the updates to expected signatures:

Python: https://github.com/dydxprotocol/dydx-v3-python/pull/5/commits/269fb849c78f78a0ed96ca6894aadaa30020fbf2
TS: https://github.com/dydxprotocol/starkex-lib/pull/31/commits/95e37cede2bea46c76ef824cde6f9730715d621e

Tested locally

Rebased with master

Rebased with master


Unable to download from Spectrum Originals

Checklist

[ ] I'm asking a question
[ ] I've looked through the README and FAQ for similar questions
[ ] I've searched the bugtracker for similar questions including closed ones

Question

WRITE QUESTION HERE
PS C:\Users*****\Desktop\youtube-dl> ./youtube-dl -v https://watch.spectrum.net/ondemand/play/spectrum.com::INMV1119243000689696
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://watch.spectrum.net/ondemand/play/spectrum.com::INMV1119243000689696']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2020.09.06
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg git-2020-06-03-b6d7c4c, ffprobe git-2020-06-03-b6d7c4c
[debug] Proxy map: {}
[generic] spectrum: Requesting header
WARNING: Falling back on generic information extractor.
[generic] spectrum: Downloading webpage
[generic] spectrum: Extracting information
ERROR: Unsupported URL: https://watch.spectrum.net/ondemand/play/spectrum.com::INMV1119243000689696
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpquf06fea\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpquf06fea\build\youtube_dl\extractor\common.py", line 530, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpquf06fea\build\youtube_dl\extractor\generic.py", line 3382, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://watch.spectrum.net/ondemand/play/spectrum.com::INMV1119243000689696
PS C:\Users*\Desktop\youtube-dl>
PS C:\Users*\Desktop\youtube-dl> ./youtube-dl --cookies cookies.txt --no-part --restrict-filenames "https://edge-vod.spectrum.net/DASH_DRM/INMV1119243000689696/manifest.mpd?adId=ae077801-b2bc-448c-991e-4d3c1d5ae33b&streamSessionId=1ecfcb31-ee24-4b3d-807f-f0895741684f|1599881557647"
[generic] manifest: Requesting header
WARNING: Falling back on generic information extractor.
[generic] manifest: Downloading webpage
[generic] manifest: Extracting information
WARNING: [generic] Unknown MIME type application/ttml+xml in DASH manifest
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
I have a Spectrum TV subscription. I'm trying to download the reboot of the TV show Mad About You on Spectrum Originals. I get the following message(s). Does youtube-dl support Spectrum Originals? I'm not too familiar with MPDs and how they work. Any help would be appreciated.

The presence of "DASH_DRM" within the manifest.mpd url means, unsurprisingly, that these dash sources are encrypted with drm (widevine and others).  The only thing in the manifest that is in the clear is the ttml subtitles.  Sorry.

Thank you for responding. I'm not sure if you can help me, I have a manifest.mpd file. Would you know how to take this manifest.mpd file and make a .mp4 file out of it? I have asked questions on Bento4 on GitHub, but know one as answered my questions.

You need more than just the MPD. You also need the license server info. First you download the encrypted media, then you can get a key from the license server, in order to decrypt the media. So the MPD on its own, is only enough to download the encrypted media.


actions.restart() calls onAuthorize again.

Most of the time a merchant will set an on click in onAuthorize to complete the order on click of a review button.  If you are doing actions.restart() on a funding error, 10486, then the onclick is duplicated since we are calling onAuthorize again.  Only way I got around it was setting boolean and checking it before setting my onclick, but I think that this is an odd issue that many merchants many not catch.  Couple options:

Add a parameter to .restart() that would force onAuthorize to execute again.  I think the default should be to not do this since 90% of merchants have a confirmation section and are not doing an execute immediately.  But could be swapped.  Only breaking incompatibility would be if someone is doing payment.execute in the onAuthorized and using actions.restart()

Document that onAuthorize will be called again if they call actions.restart, so anything they want to execute only once needs to be checked.

What if onAuthorize(data) contained data.restart? Then you could do if (!data.restart) { /* register click event */ }?
Documentation is a good idea at the very least. 👍

Yeah that would work if you documented it.

Closing this as an issue for now.


Create 1tohyi.txt

yes it true you need to accept my prikol and vbit' v bazy your

Why?

Пт, 11 марта 2022 г. в 18:41, Luis Alberto @.***>:

Why?
—
Reply to this email directly, view it on GitHub
https://github.com/albertobsd/keyhunt/pull/173#issuecomment-1065175127,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYFWR3X37XL3MYU4TTKJAN3U7NLRBANCNFSM5QPZPYKQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Brat, I decided to try your program, I need some help! Is it possible to
put my key into the key base? Сразу говорю, я русский, помогите


Fix file name

It seems like spaces in file names cause issues.
An alternative way of fixing the file name would have been url-encoding the spaces media/Script Events.png to  media/Script%20Events.png.

Thanks for spotting this problem!


Update the version of the Pym embed loader

Check and see if the Pym update HTML snippet is the newer, more compatible one used in dailygraphics; if not, update.

Confirmed that we're on the newest loader, a release cut by Juan at the same time (July 2017) as the npr-pym-loader was released.
https://pym.nprapps.org/npr-pym-liveblog-loader.v2.js


Move :stdlib-kotlin-extensions to internal package

And deprecate capitalized extension, accidentally used by the nowInAndroid build.
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test AST

I've triggered the following builds for you. Click here to see all build failures.

AllSmokeTestsPullRequestFeedback build

@bot-gradle test APT

I've triggered the following builds for you. Click here to see all build failures.

AllPerformanceTestsReadyForRelease build


Unity 5.6 and NUnit 3 causing error in ZenjectIntegrationTestFixture

Unity have in their 5.6 version upgraded to NUnit 3, where amongst other things the ExpectedExceptionAttribute have been deprecated.
This causes the code that is found in the [TearDown] part of ZenjectIntegrationTestFixture to fail to compile.
[TearDown]
public void TearDown()
{
    if (TestContext.CurrentContext.Result.Status == TestStatus.Passed)
    {
        // If we expected an exception then initialize would normally not be called
        // Unless the initialize method itself is what caused the exception
        if (!CurrentTestHasAttribute<ExpectedExceptionAttribute>())
        {
            Assert.That(_hasStarted, "ZenjectIntegrationTestFixture.Initialize was not called by current test");
        }
    }

    ClearScene();
}

Instead of the ExpectedException attribute, it is now recommended to use Throws instead.
Assert.Throws<System.InvalidOperationException>(() => breakingAction());

Isn't it the same issue as #239?

It is! Sorry didn't see that one!


Payload too large error when syncing graphics

Describe the bug
Graphics sync doesn't work when your Figma file contains a lot of components (we have around 1700 components on a Graphics page). It throws an error in the console: Error: Error: Error: Missing one or more of required arguments: "figmaToken", "figmaUrl" when attempting to get data from Figma API!. But if you try to debug the error is actually 413 payload too large and it comes from:
https://github.com/mikaelvesavuori/figmagic/blob/8ef723cecd4f3204080a64a1d25ab5250c8f2def/bin/frameworks/network/getFromApi.ts#L50
To Reproduce
Just try to sync a Figma project with a Graphics page containing many components (even 1000 should be enough to get this error).

Interesting! I am pretty sure this would be a Figma issue, rather than something on the Figmagic/implementation side.
Unclear how I'd verify it right now though.

Closing as a Figma issue. Will add a backlog task to investigate and find patterns on this.


Out of memory

Describe the issue:
It looks like dask-expr optimizes the query wrongly. Adding the extra persist() fixes the OOM memory:
---------------------------------------------------------------------------
MemoryError                               Traceback (most recent call last)
Cell In[5], line 100
     87 display(
     88     train_df,
     89     test_df,
     90     sku_groups_df,
     91 )
     93 display(
     94     train_df.head(),
     95     test_df.head(),
     96     sku_groups_df.head(),
     97 )
     99 display(
--> 100     *dask.compute(
    101         sku_groups_df['group'].value_counts(),
    102         train_df['group'].value_counts(),
    103         test_df['group'].value_counts(),
    104     )
    105 )
    107 print(train_df.dtypes)
    108 print(test_df.dtypes)

File ~/src/.venv/lib/python3.10/site-packages/dask/base.py:661, in compute(traverse, optimize_graph, scheduler, get, *args, **kwargs)
    658     postcomputes.append(x.__dask_postcompute__())
    660 with shorten_traceback():
--> 661     results = schedule(dsk, keys, **kwargs)
    663 return repack([f(r, *a) for r, (f, a) in zip(results, postcomputes)])

File ~/src/.venv/lib/python3.10/site-packages/distributed/client.py:2234, in Client._gather(self, futures, errors, direct, local_worker)
   2232         exc = CancelledError(key)
   2233     else:
-> 2234         raise exception.with_traceback(traceback)
   2235     raise exc
   2236 if errors == "skip":

MemoryError: Task ('repartitionsize-a141886386f8cc3cbacc3d585efdbc07', 470) has 22.35 GiB worth of input dependencies, but worker tls://<IP_ADDRESS>:40427 has memory_limit set to 15.64 GiB.

Working example:
import dask
import dask.dataframe as dd

groups_df = (
    dd
    .read_parquet(
        f'gs://groups.parquet/*',
        columns=['ItemID', 'group'],
    )
    .astype({'group': 'category'})
    .repartition(partition_size='100MB')
    .persist()
)

def read_dataset(path: str) -> dd.DataFrame:
    df = (
        dd.read_parquet(
            path,
            # We have to request existing cols before renaming
            columns=['ItemID', 'A_n/a', 'AT_n/a'],
        )
        .rename(columns={'A_n/a': 'A_na', 'AT_n/a': 'AT_na' })
        # This fixes weired issue with dask-expr. I faced with OOM
        .persist()
    )

    return (
        df
        .merge(
            groups_df,
            on='ID',
            how='left'
        )
        .query('group in @groups_to_include',
               local_dict={'groups_to_include': ['group1', 'group2', 'group3', 'group4', 'group4']})
        .repartition(partition_size='100MB')
    )

train_df = read_dataset(f'gs://train.parquet/*')
test_df = read_dataset(f'gs://test.parquet/*')

train_df.pprint()

train_df, test_df = dask.persist(train_df, test_df)

display(
    train_df,
    test_df,
    groups_df,
)

display(
    train_df.head(),
    test_df.head(),
    groups_df.head(),
)

display(
    *dask.compute(
        groups_df['sku_group'].value_counts(),
        train_df['sku_group'].value_counts(),
        test_df['sku_group'].value_counts(),
    )
)

pprint:
Repartition: partition_size='100MB'None
  Query: _expr='group in @groups_to_include' expr_kwargs={'local_dict': {'groups_to_include': ['group1', 'group2', 'group3', 'group4', 'group4']}}
    Merge: how='left' left_on='ItemID' right_on='ItemID'
      FromGraph: layer={('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 0): <Future: pending, key: ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 0)>, ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 1): <Future: pending, key: ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 1)>, ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 2): <Future: pending, key: ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 2)>, ..., ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 941): <Future: finished, type: pandas.core.frame.DataFrame, key: ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 941)>, ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 942): <Future: finished, type: pandas.core.frame.DataFrame, key: ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 942)>} _meta='<pandas>' divisions=(None, None, ..., None, None) keys=[('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 0), ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 1), ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 2), ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 3), ..., ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 934), ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 935), ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 936), ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 937), ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 938), ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 939), ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 940), ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 941), ('read_parquet-operation-fe85241c2cbf3f4e3c47c8ce4d1bb145', 942)] name_prefix='read_parquet-operation'
      FromGraph: layer={('repartitionsize-a7f9918679644d0763b0995e4cc22887', 0): <Future: finished, type: pandas.core.frame.DataFrame, key: ('repartitionsize-a7f9918679644d0763b0995e4cc22887', 0)>} _meta='<pandas>' divisions=(None, None) keys=[('repartitionsize-a7f9918679644d0763b0995e4cc22887', 0)] name_prefix='repartitionsize'

An example that leads to OOM:
# ...
        .rename(columns={'A_n/a': 'A_na', 'AT_n/a': 'AT_na' })
        # Commeting out this line leads to OOM
        #.persist()
#...

pprint:
Repartition: partition_size='100MB'None
  Query: _expr='sku_group in @sku_groups_to_include' expr_kwargs={'local_dict': {'sku_groups_to_include': ['no_sales', 'very_intermittent', 'intermittent', 'frequent', 'very_frequent']}}
    Merge: how='left' left_on='InventoryID' right_on='InventoryID'
      RenameFrame: columns={'A_n/a': 'A_na', 'AT_n/a': 'AT_na', ... }
        ReadParquetFSSpec: path='gs://ecentria-ai-team-352717-demand-forecasting/ai-459/data/ecentria/features/train_features.parquet/*' columns=['CN', 'lag1', 'A_n/a', 'AT_n/a', ...] kwargs={'dtype_backend': None}
      FromGraph: layer={('repartitionsize-a7f9918679644d0763b0995e4cc22887', 0): <Future: finished, type: pandas.core.frame.DataFrame, key: ('repartitionsize-a7f9918679644d0763b0995e4cc22887', 0)>} _meta='<pandas>' divisions=(None, None) keys=[('repartitionsize-a7f9918679644d0763b0995e4cc22887', 0)] name_prefix='repartitionsize'

Minimal Complete Verifiable Example:
TBD
Anything else we need to know?:
Environment:

Dask version:

dask = "2024.5.2"
dask-expr = "1.1.2"

Python version: 3.10
Operating System: WSL
Install method (conda, pip, source): poetry

Can you say a bit more about the size of your parquet files, worker specs, ...
dask-expr fuses multiple parquet files to a single partition until we reach 75MB in memory size per partition, this might be relevant here.
Query blocks the optimiser, so not much should happen here tbh.
Is your pprint result optimised? if not, please post df.optimize(fuse=False).pprint()

@phofl , thanks for quick reply.

Can you say a bit more about the size of your parquet files, worker specs, ...
We're utilizing 12 n2-highmem-2 instances, 2 vCPUs and 16GB of RAM per each.

train.parquet/* - 2827 files of ~5MB each
test.parquet/* - 429 files of ~4MB each
groups.parquet - single 5.3 MB file

Is your pprint result optimised?
I believe, yes, because of default behaviour:

...
train_df.pprint()
...

I'll provide unoptimized outputs shortly. Currently, I'm working on reproducing the problem with the latest versions of dask-expr and distributed.

No, pprint is not optimising your query
Can you try setting
dask.config.set({"dataframe.parquet.minimum-partition-size": 1})

that will disable the fusion of partitions in read_parquet

@phofl , the problem is reproducible on the latest version.
Disabling fusion lead to the same error:
dask.config.set({"dataframe.parquet.minimum-partition-size": 1})

train_df.pprint()
train_df.optimize(fuse=False).pprint()

Repartition: partition_size='100MB'None
  Query: _expr='group in @groups_to_include' expr_kwargs={'local_dict': {'groups_to_include': [...]}}
    Merge: how='left' left_on='InventoryID' right_on='InventoryID'
      RenameFrame: columns={...}
        ReadParquetFSSpec: path='gs://ecentria-ai-team-352717-demand-forecasting/ai-459/data/ecentria/features/train_features.parquet/*' columns=[...] kwargs={'dtype_backend': None}
      FromGraph: layer={('repartitionsize-a7f9918679644d0763b0995e4cc22887', 0): <Future: finished, type: pandas.core.frame.DataFrame, key: ('repartitionsize-a7f9918679644d0763b0995e4cc22887', 0)>} _meta='<pandas>' divisions=(None, None) keys=[('repartitionsize-a7f9918679644d0763b0995e4cc22887', 0)] name_prefix='repartitionsize'

RepartitionSize: partition_size='100MB'
  Query: _expr='group in @groups_to_include' expr_kwargs={'local_dict': {...]}}
    BlockwiseMerge: how='left' left_on='ItemID' right_on='ItemID'
      RenameFrame: columns={...}
        FusedIO:
          ReadParquetFSSpec: path='gs://train_features.parquet/*' columns=[...] kwargs={'dtype_backend': None}
      FromGraph: layer={('repartitionsize-a7f9918679644d0763b0995e4cc22887', 0): <Future: finished, type: pandas.core.frame.DataFrame, key: ('repartitionsize-a7f9918679644d0763b0995e4cc22887', 0)>} _meta='<pandas>' divisions=(None, None) keys=[('repartitionsize-a7f9918679644d0763b0995e4cc22887', 0)] name_prefix='repartitionsize'

It might be helpful to run analyze on a subset of the data to see where things blow up, see https://github.com/dask/dask-expr/blob/1c646712b3c74eb9bed52bec59e442ce24d165c8/dask_expr/_collection.py#L479-L504 (not sure if we have "proper" docs for this)

@fjetter , @phofl, it is impossible to create an image for train_df['sku_group'].value_counts().analyze() because it leads to OOM, so I've created the image for a smaller size dataframe test_df:

@phofl , @fjetter , did I understand correcltly that after optimisation test_df['sku_group'].value_counts() Dask tries to perform value counting using a single chunk? So, it might lead to OOM on a single node?
Before optimize(fuse=False):
ValueCounts: sort=True
  Projection: columns='group'
    FromGraph:

After optimize(fuse=False)
ValueCounts(TreeReduce): split_every=8
  ValueCounts(Chunk): sort=True
    Projection: columns='group'
      FromGraph:

Yes, this can cause problems if there are many values and the reduction is not able to shrink the data. You can force this to use multiple outputs with value_counts(..., split_out=N) where N is an appropriately chosen integer. This is something we cannot do automatically because it depends on your data distribution

However, if you call dask.compute at the very end this will fetch all the data to your computer regardless of the split_out paramter which is something you might not want to do any more.

This is a little bit puzzling to me tbh

Dask tries to perform value counting using a single chunk? So, it might lead to OOM on a single node?

it shouldn't anymore, the legacy version used to do this but we changed this to keep the partition count constant to avoid exactly these errors. Is your dtype categorical? That would explain this.
That said, analyse pulls all the data into a single partition, which is also not very great here.

I have a PR here https://github.com/dask/dask-expr/pull/1124 that will improve the value_counts case, but as @fjetter said calling compute will still pull all the data into a single partition.

Yes, this can cause problems if there are many values and the reduction is not able to shrink the data.

There are only five categories.

Is your dtype categorical?

@phofl , you're right. I'm using categorical, which is the logical choice to my understanding because I would like to optimize memory usage:
groups_df = (
    dd
    .read_parquet(
        f'gs://groups.parquet/*',
        columns=['ItemID', 'group'],
    )
    .astype({'group': 'category'})                  # <-----------------
    .repartition(partition_size='100MB')
    .persist()
)

However, it does not make sense to me why persist() solves the OOM issue without changing the column type.
Also, it seems that I'm using column conversion to category type with astype({'group': 'category'}) that leads to unknown categories. Probably I should use categorize(columns=['group']) instead.


Linux/IMX support

I would like to use shaka embedded in Linux environhment. In the description, you say that there is a Linux port, how can I use it? Morever, I have an ARM/IMX board, does shaka embedded support hardware acceleration for this architecture?
Best regards,
Roberto

We don't officially support desktop platforms.  But since I do most of my development on Linux, it helps to be able to build it and test things on my Linux machine.  You can just run configure and then make to build on Linux.  It will use SDL to create the demo and will just play a video (the very simple demo is here).  Unlike the iOS API, you'll need to draw the frames yourself.  For example, the demo uses SDL to do it.
We might support ARM/IMX.  We support ARM on iOS, so we may be able to build for ARM in general.  This may work, but I haven't tested it:
mkdir my_build
cd my_build
CC=my_compiler CXX=my_compiler++ ../configure --cpu arm --disable-demo --no-sdl-utils
make

But again, you'll need to draw the frames yourself using whatever rendering APIs you have access to.  We also won't do any hardware decoding.


WIP: Kubernetes UI Dashboard

Adding the Kubernetes UI dashboard component.

@lavalamp I'm running in to an issue with cAdvisor and accessing the data over SSL. I need to avoid the Mixed Content: The page at 'https://<IP_ADDRESS>/static/app/#/dashboard/' was loaded over HTTPS, but requested an insecure XMLHttpRequest endpoint 'http://<IP_ADDRESS>:4194/api/v1.0/containers/'. This request has been blocked; the content must be served over HTTPS.

I tried something like:
https://<IP_ADDRESS>/api/v1beta3/proxy/nodes/kubernetes-minion-7jpp.c.shared-kraken.internal:4194/api/v1.0/containers but I receive the following error:
{
  "kind": "Status",
  "apiVersion": "v1beta3",
  "metadata": {},
  "status": "Failure",
  "message": "minion \"kubernetes-minion-7jpp.c.shared-kraken.internal:4194\" not found",
  "reason": "NotFound",
  "details": {
    "id": "kubernetes-minion-7jpp.c.shared-kraken.internal:4194",
    "kind": "minion"
  },
  "code": 404
}

The code in the Web UI that is setting up the request is found in: https://github.com/kubernetes-ui/kubernetes/blob/kubernetes-ui-dashboard/www/master/shared/js/modules/services/cAdvisor.js#L10

@lavalamp was thinking that doing something like: strings.Contains("kubernetes-minion-7jpp.c.shared-kraken.internal:4194", ":") and  host, port, _ := net.SplitHostPort(u.Host) with the proxy in https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/apiserver/proxy.go#L53 so the goal is for something like https://<IP_ADDRESS>/api/v1beta3/proxy/nodes/kubernetes-minion-7jpp.c.shared-kraken.internal:4194/api/v1.1/containers/ to work as it does directly at http://<IP_ADDRESS>:4194/api/v1.1/containers/

Please see #7073

@lavalamp I'm trying a build with that fix now.

I'm not really sure why the kubernetes.svg isn't appearing. It's accessible on my test cluster at: https://<IP_ADDRESS>/static/app/assets/img/kubernetes.svg

@roberthbailey any ideas about why the logo wouldn't be appearing?

Looks like the SVG issue is now fixed:
 with the changes in https://github.com/GoogleCloudPlatform/kubernetes/pull/7083

There are a number of things in this change that I don't think are up to production grade yet, however instead of bogging this down and asking for fixes for all of them, I've filed #7122. Please tag me in future UI PRs.

:+1:

:+1:


feat: generate maci keypair

[x] Add public and private keys to session
[x] Add public and private keys to db
[x] Install latest ci maci version

[x]  Add public and private keys to session
[x]  Add public and private keys to db

I'm confused, I thought the plan was to eventually remove the DB given we no longer need it (since ballots will be stored on-chain with MACI)?
I outlined this in #4 & I thought we had reviewed this as a team:

MACI key generation
Once a user connects their wallet & we've confirmed they're an OP badgeholder (by querying the EAS attestation), we should generate a MACI keypair for them so they can sign up
Let's generate the MACI key deterministically, so it's attached to their ETH address (so same implementation as clr.fund). This way, we can completely abstract the MACI keypair away from the user. They don't even need to know it exists. As long as they can connect their wallet & prove ownership of the ETH address, they should be able to generate their MACI private key to sign any messages.

@0xmad curious to understand why you went with this approach. Did your thinking change? Or did we just misunderstand each other in the planning of this?

This work also seems to overlap with @kittybest's PR on the signup flow: https://github.com/privacy-scaling-explorations/maci-rpgf/pull/18/files
So I suggest you two sync up to make sure we're not duplicating work here 😃

[x]   Add public and private keys to session
[x]   Add public and private keys to db

I'm confused, I thought the plan was to eventually remove the DB given we no longer need it (since ballots will be stored on-chain with MACI)?
I outlined this in #4 & I thought we had reviewed this as a team:

MACI key generation
Once a user connects their wallet & we've confirmed they're an OP badgeholder (by querying the EAS attestation), we should generate a MACI keypair for them so they can sign up
Let's generate the MACI key deterministically, so it's attached to their ETH address (so same implementation as clr.fund). This way, we can completely abstract the MACI keypair away from the user. They don't even need to know it exists. As long as they can connect their wallet & prove ownership of the ETH address, they should be able to generate their MACI private key to sign any messages.

@0xmad curious to understand why you went with this approach. Did your thinking change? Or did we just misunderstand each other in the planning of this?

Signature generation is a deterministic process here because it depends on your connected wallet. User will never know if there are any key pairs because this logic will be handled under the hood. As we discussed before, we don't want to change anything, we just extend the functionality and keep all the old code untouched.

This work also seems to overlap with @kittybest's PR on the signup flow: https://github.com/privacy-scaling-explorations/maci-rpgf/pull/18/files
So I suggest you two sync up to make sure we're not duplicating work here 😃

I don't see any duplication with signup flow and my PR. This PR is a preparation for signup and doesn't contain any signup logic.

I don't see any duplication with signup flow and my PR. This PR is a preparation for signup and doesn't contain any signup logic.

Actually I generate keypair after user click on signup, but it doesn't matter, I could remove it :)


[PERF] Remove redundant heap allocation present in the logging framework

Use here, below, and in similar places, theformat_args!() macro instead, to omit redundant allocations produced by the format!() macro (as it returns a new String).
Code Snippets

https://github.com/juspay/hyperswitch/blob/597ec16907a83ce228228b8c00e329495ade117b/crates/router_env/src/logger/formatter.rs#L208
https://github.com/juspay/hyperswitch/blob/597ec16907a83ce228228b8c00e329495ade117b/crates/router_env/src/logger/formatter.rs#L214

Steps for Resolution
While taking up this issue, please document the solution you are going forward with, also include benchmarks or evidence as to how extra heap allocations are avoided. (please use this issue itself for discussion and the approach documentation).
(Optional) in-code documentation is always encouraged.

@NishantJoshi00  Correct me if I am wrong, but the author of the 117 had already mentioned the possible solution.
As part of this issue, should we have to identify if there are other options?
Out of curiosity how can I check how much heap memory is allocated in Rust?

Hey @jeevaprakashdr, if you have any other inputs on a different approach on this problem, we should discuss this, whilst talking about the heap allocation. I came up with some interesting resource you might want to check out, I personally haven't tested them but they seem promising:

https://crates.io/crates/peak_alloc
https://rust-analyzer.github.io/blog/2020/12/04/measuring-memory-usage-in-rust.html

@NishantJoshi00  yup happy to have a look at it. please could you assign the issue to me.  Thanks

Sure, let me know if you have any questions, or want to discuss any approach other than that which was suggested. Definitely open for any enhancement.

@NishantJoshi00 I spent quite a bit of time if we can have a declarative macro around.
as my understanding we cannot compose format_ars! in another user define  macro_rule
unless we actually write a proc macro which is not necessary at the moment.


SOLR-15694 Concept of node roles and non-data nodes

In this PR, only a single role can be assigned to a node, and I'm fixing that. Changes to come soon, hence this is not yet ready for reviewing. Sorry for the confusion.

In this PR, only a single role can be assigned to a node, and I'm fixing that. Changes to come soon, hence this is not yet ready for reviewing. Sorry for the confusion. Also, merging this PR can't happen now, until the SIP-15 has been voted for.

While you're at it Ishan, please fix the formatting of the many if(... that lack a space after the if and change them into:
if (....
Thanks.

While you're at it Ishan, please fix the formatting of the many if(... that lack a space after the if and change them into:

Sure, Ilan. :-)

TODO items:

deprecate ADDROLE and REMOVEROLE commands
throw exception when a node containing cores is started without a data role
the /api/cluster/roles should also list nodes that didn't have -Dsolr.node.roles (they are assumed to have data role)

I think except for these items, this PR is ready for reviewing. FYI @noblepaul @murblanc @hiteshk25. It should only be merged once the SIP-15 voting has concluded.

the /api/cluster/roles should also list nodes that didn't have -Dsolr.node.roles (they are assumed to have data role)

Making sure we agree on the fact that nodes without defined roles are assumed to have all roles, not only data role.

Making sure we agree on the fact that nodes without defined roles are assumed to have all roles, not only data role.

As discussed on the SIP thread (mainly during a back and forth between Ishan & Gus), we don't want to have "all roles enabled by default", since that means any roles added in future will also get enabled by default and that might not be desireable. Rather, we only want the "data" role turned on by default due to backcompat reasons (i.e. those who are not using roles feature are already using their nodes for data).

Rather, we only want the "data" role turned on by default due to backcompat reasons

It seemed pretty clear to me in the dev list thread that this was not a consensus. There are many roles that we want enabled by default, like the "query/compute/whatever its new name is" role. That would also be a backcompat concern.

This is now ready for review. FYI, @murblanc.

This is now ready for review. FYI, @murblanc.

will try to  have a look this week-end, otherwise early next week.

Addressed some comments from Ilan. TODO: Address some others from Ilan and Jan.

PlacementRequestImpl.toPlacementRequest needs to be updated (when nodes are passed in and when not) to filter out nodes that can't take data.

Fixed, thanks.

Thanks everyone for participating


feat: add protobuf 4.27.0RC2 release

update protobuf with release 4.27.0RC2

:tada: This issue has been resolved in version 1.323.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


TFVC will not receive future investment

Per the conversation around a recent Design Change Request targeting TFVC, there will be no future investment in this system (baring security related issues) because of this we need to AT LEAST update the page we offer for helping customers make a decision on which version control system to use.  Rather than try to determine the exact status of TFVC, I emphasized that Git is the system that is receiving investment hopefully making clear that this should be your choice, and that you should start moving away from TFVC to Git.  Hopefully this is strong enough language to help people choose and to sight from support when requests are made for new work or bug-fix.

@SamGrantham : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

For me It is not good idea notify people to use TFVC, if customer has huge repo, they should use TFVC, git is not best choice if repo is the really huge
cc: @vijayma


feat: Support to show the authors of the article

In non-personal blogs, author info needs to be displayed.
Articles list preview
Showing authors after tags (Add @ as prefix)

List of articles by author
Click on the author to see a list of articles

All author list

Thanks, that's a great feature.
And sorry for the long wait.


Hotkey mapping on non-Latin keyboard layouts

This issue is a spinoff of #1040; the main scope of that was delivering key events. The implementation PR (#1049) does a reasonably good job with non-QWERTY Latin layouts, but does not handle non-Latin well, so that's what this issue is about. This analysis is largely based on Windows but similar issues exist across the platforms.
After a bit of research of existing application behavior, I found that when a non-Latin keyboard layout is selected, hotkeys (Ctrl-Z and friends on Windows) map ASCII keys (I think in the US layout, but see below). However, the current code does not do this - it queries VkScanKey to find which virtual-key corresponds to the codepoint for "Z", and that function returns -1 indicating error. Thus, the hotkey binding is dropped.
What is the correct behavior? Since ACCEL is based on virtual-key codes, I suspect what happens is equivalent to having a fallback mapping when VkScanKey fails, choosing 0x5A (b'Z') to represent the mapping of "Z". If this is the case, there are two problems:

First, virtual-key codes are really only well defined for A-Z and 0-9. Others (period, comma, etc) are reasonably stable, while others (VK_OEM_[1-9], corresponding to virgule, octothorpe, brackets, and other ASCII symbols) tend to move around a lot. For example, I have no idea how you'd map a Ctrl-"#" shortcut, which would be Ctrl-Shift 0x33 in a US layout but Ctrl VK_OEM_2 in a DE QWERTZ layout.

Second, if virtual-key codes are the source of truth for such mappings, then with our current types we've lost the ability for event dispatching to interpret the key the same as hotkey bindings, as we currently throw the vk on the floor (after perhaps using it to derive a Key value). The Web keyboard event has a "legacy" keyCode which in my testing on Windows seems to match the virtual-key code, which we might consider restoring. (I'll also note that keyCode is not stable across platforms, for example "#" in a German QWERTZ layout has value VK_OEM_2 on Windows but VK_OEM_5 on macOS, though the non-legacy codes are consistent: Key::Character("#") and Code::Backslash)

A second possibility is to use "code" rather than vk as the source of truth, and fall back to symbol positions in a US layout when the primary mapping fails. In this approach, when there is no key corresponding to "#", then the fallback is to find the key with Code::Digit3 and turn on the shift modifier. Basically, we'd have our own ASCII-to-code map based on a US layout, then on Windows use MapVirtualKeyEx with MAPVK_VSC_TO_VK to map the code back to a vk, and use the resulting vk in the ACCEL structure.
I am currently leaning towards the second approach, as it is based on more robustly standardized codes, and I see more clearly how to make it consistent across platforms. The main downside is that in edge cases it may not match the behavior of native Windows applications.
I'd love feedback from people who regularly use non-Latin layouts. Figuring out the right thing to do here probably mostly involves experimenting with a bunch of apps, and doesn't require any deep knowledge of Druid internals.

Let me propose for the sake of concrete discussion a heuristic for HotKey::match(key_event), which is really the second half of this discussion other than mapping to platform accelerator structures. Goals are:

Reasonably simple.

In particular, don't require additional shell plumbing to query kb layouts or get vk's.

Match the HotKey -> accelerator mapping in most cases.
Fairly consistent across platforms, including web.

Non-goals are:

Match platform behavior in all edge cases.
Match the HotKey -> accelerator mapping in all cases.

Here's the heuristic:

If the HotKey and key event are both Key::Character(), then apply the following logic:

If the strings are a case insensitive match, match. When comparing modifiers, accept shift in key if string is printable ASCII other than alphanumeric.
If the HotKey is a Latin character and the key is not, then match against the shift modifier + code of the key event, mapped by US layout. When comparing modifiers, ignore shift.

If the HotKey is a Key enum other than Unidentified, compare key for equality, and the 4 basic modifiers.
Otherwise, no match.

In some cases, the four basic modifiers are matched (shift, ctrl, alt, meta). In some, shift is accepted in the key event if it is not specified in the hotkey (specifying shift in the hotkey requires it to always be present in the key event). The other modifier flags (caps lock, etc) are not considered.
The predicate "is a Latin character" is defined as "a string consisting of a single codepoint in the range U+0020 to U+024F inclusive."
Here's a bit of rationale:
The reason for the case-insensitive match is so ctrl-[A-Z] works even when Caps Lock is enabled. Basically, for A-Z, we consider the shift modifier to be the source of truth, not case.
The reason for special handling of shift for non-alphanumeric printable ASCII is that the mapped character can be relied upon to capture the shift state. Thus, a hotkey spec of Ctrl-# will match Ctrl-Shift-3 in a US layout and Ctrl-# in a German QWERTZ. We should discourage (either through docs or warning) the specification of hotkeys with shift and ASCII symbols, as Ctrl-Shift-# will fail to match in a German layout. Note also that the correct hotkey for "+" is "+", not Shift-"=".
The rationale for U+024F specifically is that I believe both Western and Eastern European keyboard layouts are likely to contain mappings for ASCII symbols. Therefore, the other keys in this layout should not alias.
Here's an example of an edge case: In a Russian layout there will be more than one key combination that matches the hotkey spec Ctrl-",". For the former, both Code::Comma (ordinarily mapped to "Б") and Shift-Code::Slash will match. For the creation of the ACCEL structure, only one would get mapped (I'm assuming the latter but haven't tested it yet). Obviously the "Я" key will match a Ctrl-Z hotkey spec. I think this behavior is acceptable, if not absolutely ideal.
Another edge case: Ctrl-# will fail to match any key on the Web + macOS + Mozilla + US layout combination, as Mozilla reports Key::Character("3") for that combination (Shift + Code::Digit3). If we adopt this heuristic, we should fix our keyboard event processing so we report Key::Character("#") in that case, matching Safari (which I consider an authoritative source of truth) and Chrome.
If these are the two worst edge cases, I think we're doing well. Of course, it's possible I've missed something, so I'd love feedback.

I haven't studied this issue very closely in relation to Druid, but let me drop a side note here because I saw the idea of –if I understand it right– using raw key scan codes for bindings rather than the symbols they generate. In general this is a bad idea. One of my the most frustrating UI experiences I encounter stems from this. For whatever crazy reason browsers actually expose raw keycodes in addition to input characters. This has let to poorly thought out attempts by web designers to be "more accurate" that are just disastrous as an end user. Most commonly this shows up in form validations ... for example banks with entry fields that expect numbers that will only accept key scan codes that they think generate numbers.
In my case I use several keyboard layouts including a modified Dvorak layout (Programmers Dvorak) and similarly modified Turkish-F layout that has numbers & symbol levels reversed from QWERTY — by default pressing the keys gives me a symbol and using a SHIFT modifier gives me the Arabic numeral. The end result is that I cannot enter data in forms that reject input based on their expected scan codes.
This also turns up occasionally is desktop UI's in relation to hotkeys. When they try to be too smart and skip the OS's input methods and go straight to the source they are inevitably wrong for me and either the hotkeys are not what they say on the tin or it is actually impossible to enter them.
Please don't assume that just because 98% of people stick with QWERTY or other predefined layouts that it's okay to short circuit OS level input method tools. It's very rare that this is the right approach.
One exception where this can be the right solution is window managers. I have some WM bindings that are scan code base specifically so that they remain static across keyboard layout changes.


2nd autocomplete not working across hosted fields

General information

SDK version: 3.53.0 and 3.55.0
Environment: Sandbox
Browser and OS : 78.0.3904.108-1 and Ubuntu Linux

Issue description
Autocompleting credit card hosted fields card number and expiration from browser's stored credit card payment methods works on first attempt. e.g. Auto-completion on card number will also auto-complete the expiration and vice-versa. That is, auto-completion works across hosted fields.
If you then clear the auto-completed card number and expiration hosted fields, then attempt ANOTHER / 2nd autocomplete on card number, the expiration is not auto-completed.

See attached braintree-test.html and replace the 'sandbox_XXXXXX' token with a valid sandbox authorisation token.
Host the attached braintree-test.html in a web server and make sure it is served via HTTPS and that Chrome recognises that entire certificate chain.
Ensure you have stored credit card numbers in Chrome.
Auto-populate from either card number hosted field or expiration date hosted field using the card number suggested by Chrome.
After both hosted fields are auto-populated, clear both the card number and expiration hosted fields.
Do another auto-populate from card number suggested by Chrome.
Card number hosted field is auto-populated, but notice that the expiration hosted field is NOT auto-populated.

braintree-test.zip

Actually, there is also another bug that I discovered,
After loading the page, if you 1st-time auto-complete from the expiration hosted field, the card number is NOT autocompleted.

So the way hosted fields autocomplete works is that the number frame contains a bunch of hidden inputs for the other parts of the credit card. When you start an autocomplete action from the number frame, it populates the hidden inputs inside it and then post messages those values out to the rest of the hosted fields iframes on your page to fill those in.

If you then clear the auto-completed card number and expiration hosted fields, then attempt ANOTHER / 2nd autocomplete on card number, the expiration is not auto-completed.

Given the above structure, this makes sense, since the hidden expiration date in the number iframe has not changed, so there's no need to fill it. And since there's no need to fill it, there's no need to message it out to the rest of the iframes.
Definitely an edge case here we should handle, so thanks for bringing it up. Should be pretty straightforward to keep them in sync.

After loading the page, auto-completing from the expiration hosted field does NOT autocomplete the card number hosted field .. even if it is the first-time you try to auto-complete on the page.

This is expected behavior, because the extra inputs are only present in the number iframe. We made this decision to keep the code simple, but it may be that we instead need to insert the extra inputs in all frames (especially to support autocomplete in the cardholder name field, see #480)
These are added to our backlog.

Fixed in v3.66.0 (note that npm is currently having issues publishing packages ), so this is available via our CDN, but may take a while to be available on npm.


Smart launch patient context

Created simple SMART on FHIR app that pulls in pt data when using SMART Launcher.
To launch the app from a SMART on FHIR app using Patient Context:

Navigate to the directory, and run yarn start -> This will initialize the server but you wont be able to run the application unless from a SMART Launcher

Use this Smart Launcher

Keep everything at default but at the bottom under App's Launch URL use the url http://localhost:4040/

Sign in using the normal doctor login

Select any patient

Voila! you should see the Fhir component loaded into the React app and displayed

Is there a reason for using yarn?  yarn existed to deal with shortcomings of npm which have since been resolved.


[Bug]: Showcase repo links in CRA-RXJS Readme are incorrect

What kit and version are you using?
cra-rxjs
What browser are you using?
n/a
What operating system are you using?
n/a
Actual Behavior
When a user clicks on the GitHub repo link in the bottom of the README, it leads to a 404.

The url points to https://github.com/thisdot/starter.dev-showcases/tree/main/cra-rxjs-styled-components but the correct url should be https://github.com/thisdot/starter.dev-github-showcases/tree/main/cra-rxjs-styled-components
Expected Behavior
The url points to https://github.com/thisdot/starter.dev-showcases/tree/main/cra-rxjs-styled-components but the correct url should be https://github.com/thisdot/starter.dev-github-showcases/tree/main/cra-rxjs-styled-components
Reproduction
See note above
Additional Information
No response

This issue was resolved in this PR


Make CMake package version ARCH_INDEPENDENT

Since strong_type is a header-only library, its package version should be considered compatible independent of the target architecture. The ARCH_INDEPENDENT option of write_basic_package_version_file() ensures just that. See the documentation for more details.
Note that using ARCH_INDEPENDENT increases the minimum required CMake version to 3.14. Given how easy it is to get the latest CMake version on any platform, this should not be an issue, though (see the table under "Picking a CMake Version" of this blog post).

Of course. Much appreciated. Thank you!

Thank you for the fast reply and such a great library.


Not working in folders with nordic charechters in path

I had trouble getting T3S to work, then i noticed that on a project, and found the following error in the console.
typescript initializing
Exception in thread Thread-5:
Traceback (most recent call last):
  File ".\threading.py", line 532, in __bootstrap_inner
  File ".\Typescript.py", line 432, in run
  File ".\subprocess.py", line 633, in __init__
  File ".\subprocess.py", line 842, in _execute_child
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in position 94: ordinal not in range(128)

The folder where the project was in had a Ø in the path.
After renaming the project without the Ø, did it work.

if you are using Sublime Text 3: can you test this with ArcticTypescript and create an issue there?
https://github.com/Phaiax/ArcticTypescript/

I forgot to write that i am using Sublime text 2


Comparision of bge-m3 with bge-small and bge-large

Thanks for sharing your latest work  (bge-models), i took a look at the paper shared, I haven't found any results comparing bge-m3 to the past bge models, can you point me to the right resource ,if I ain't looking in the right direction.

Thanks for your interest in our work!
bge-m3 is a multilingual model, while past bge models only support one language (English or Chinese) that cannot be tested in a multilingual evaluation dataset, so we haven't evaluated the performance of past bge models in our paper.

Thanks for the reply, Yes, that makes sense, btw your work on bge-models has shown significant results in one of the retrieval components I was working on, keep doing the awesome work.


Importing endline causes compilation error

Describe the bug
When trying to import anything from endline, it causes compilation errors.
Possible issue with webpack configuration, need to handle externals.
Expected behavior
For the app to compile properly and be able to run without compilation errors.
Steps to reproduce

Create a project with endline
Create a route file with simple controller
Import Router from 'endline/router'
Run endline dev or endline build

Crash/Log output
$ endline dev

[Info] Initializing server on localhost:3000
[Error] Failed to compile application, please fix the following errors:
{
  moduleIdentifier: '/home/user/endline-test/node_modules/.pnpm/babel-loader@9.1.2_@babel+core@7.21.4_webpack@5.80.0/node_modules/babel-loader/lib/index.js??ruleSet[1].rules[0].use!/home/user/endline-test/src/routes/test.js',
  moduleName: './src/routes/test.js',
  loc: '1:0-40',
  message: "Module not found: Error: Can't resolve 'endline/router' in '/home/user/endline-test/src/routes'"
}

Solved in commit af1ed20219aeaebe88f1ba1975e3ce36f6ce7eaa


DFXML output

Please include an option to output netstorage information in Digital Forensics XML format (DFXML)
https://www.nist.gov/software-quality-group/dfxml-schema
https://github.com/dfxml-working-group/dfxml_schema

NM, this is an API request rather than a tool request.


replace GetTempFileName

fixes #3589

Consider making the same changes to the following (and any other uses of GetTempFileName()):
https://github.com/aspnet/Docs/blob/74a44669d5e7039e2d4d2cb3f8b0c4ed742d1124/aspnetcore/mvc/models/file-uploads/sample/FileUploadSample/Controllers/UploadFilesController.cs
https://github.com/aspnet/Docs/blob/74a44669d5e7039e2d4d2cb3f8b0c4ed742d1124/aspnetcore/mvc/models/file-uploads/sample/FileUploadSample/Controllers/StreamingController.cs

Ah I see. This is fine. Thanks! @Eilon

(Review URL](https://review.docs.microsoft.com/en-us/aspnet/core/mvc/models/file-uploads?branch=pr-en-us-3639) and search for GetTempFileName
@ardalis  what's the profile controller for? Can we delete it?

@jbagga  please review addition:
The 65535 files limit is per server, so another app on the server can use up all 65535 files.

I get "Error	CS1503	Argument 1: cannot convert from 'Microsoft.Extensions.Primitives.StringSegment' to 'string'" in MultipartRequestHelper for 'boundry' on line "if (string.IsNullOrWhiteSpace(boundary))"


Update CFR and Enigma

java.lang.NullPointerException: Cannot invoke "cuchaz.enigma.translation.mapping.EntryMapping.javadoc()" because "mapping" is null

Seems like the enimga update broke some stuff.

Weird, I specifically made sure to test various Yarn versions before submitting my PR and everything had worked fine 🤔


Prompt for '{"errors":"Not Found"}' error when creates or updates an asset for a theme

Issue summary
Document
https://shopify.dev/docs/api/admin-rest/2023-04/resources/asset#put-themes-theme-id-assets
Requirements

[ ] php 8.1
[ ] shopify/shopify-api 4.3

Expected behavior
PUT  /admin/api/2023-04/themes/{themeId}/assets.json
payload
{
    "asset": {
       "key": "templates/xxxxx.liquid",
       "value": "xxxxxx"
   }
}

@adilizm
Starting with Admin API 2023-04, Asset resource PUT or DEL requests are restricted using the write_themes access scope. If an app that's distributed in the Shopify App Store needs to use Asset resource PUT or DEL requests, then it needs to be granted an exemption by Shopify to use the write_themes access scope
https://shopify.dev/docs/apps/online-store/other-integration-methods/asset

I already have the write_themes, read_themes scopes and still getting them while updating theme assets
PUT https://test.myshopify.com/admin/api/2023-10/themes/127604883630/assets.json
{
    "errors": "Not Found"
}

But If i use the older version 2023-01 then it works

Same issue here, it worked well when I reverted to API version '2023-01'

Is there any solution here?

@krisforkpoint  yes you need to fill out the form here and in public url need to write app still in development https://docs.google.com/forms/d/e/1FAIpQLSfZTB1vxFC5d1-GPdqYunWRGUoDcOheHQzfK2RoEFEHrknt5g/viewform
Once you submit that within 2-3 days they will approve your request and you can use the assets api.

Thank you @somin-parate, I will submit a request and see if Shopify approves it.


GraphicsView and Microsoft.Maui.Graphics

Fixes #55
Fixes #17

@jsuarezruiz
The overview page definitely needs some work - I think we should drop the section on platform abstractions. The rest of the overview page is a bit random.
Also, is there anyway of forcing Maui.Graphics to use a specific graphics abstraction? e.g. force use of SkiaSharp on iOS rather than CoreGraphics

Replaced with #241


Create Docs

like in wagtailstreamforms

How can I help? :+1:

Hi @thisdarktao
We just need to start thinking about writing some docs basically replicating whats done in
docs. Theres no real dev docs just prob:

Installation
Basic Usage
Settings
Contributors
Changelog
Screenshots

Would do to start with. There are things that still need work and testing so its not in a state where it can be published so no rush. You will need a virtualenv and do a
pip install -e .[docs]

to install docs dependencies. Then cd docs and in the env
sphinx-autobuild . _build

then http://<IP_ADDRESS>:8000. There is a readme for this in wgtailstreamforms
Ty


submodule url

Please change the submodule url for googletest to
https://github.com/google/googletest (note the protocol https).
This still provides secured connection but allows to clone the repository anonymously, without setting up ssh keys.
Thanks

Thanks


The bubble can not change radius

When i use this method

setViewportCalculationEnabled(false)

in bubbleChart。And resetBubbleViewport like this
private void resetBubbleViewport() {
        final Viewport v = new Viewport(columnChart.getMaximumViewport());
        v.bottom = 0;
        v.top = endYNum + 20;
        v.left = -2;
        v.right = (float) BUBBLES_NUM + 2;
        bubbleChart.setMaximumViewport(v);
        bubbleChart.setCurrentViewport(v);
}

bubbles can not change radius. Every bubble only with default radius,  can not change with Z order.
But when i

setViewportCalculationEnabled(true),

every thing is ok.
How can bubble change radius by Z order  at the same time setViewportCalculationEnabled(false) ???

I'm having the same problem. The changes in x and y values are displayed as expected but the change in the z value isn't displaying. The bubble radius remains the same.


fix bash module

fix https://github.com/gojue/ecapture/issues/490

The number of built-in commands without returned value (such as exit, exec) is limited, perhaps they can be treated specially.
The uretprobe/readline function should check whether the key already exists, and if so, perform an append operation (in fact, this logic should be done in user space rather than in kernel space. The BPF program merely sends the collected data to user space.).

So in this PR:

The BPF program in kernel space merely sends the collected data to user space.
Change bashEvent.eventType from EventTypeOutput to EventTypeEventProcessor.
Rebuild iworker.go.Implemented a new bashEventWorker struct for the iworker interface to handle bashevent.

Can we just reuse the String function for BashEvent to avoid the extensive modification for iworker ?

Rebuild iworker.go.Implemented a new bashEventWorker struct for the iworker interface to handle bashevent.

This approach is not very elegant. It should use the same worker to process HTTP requests, HTTP responses, and bash, regardless of which one it is processing. It only needs to implement a bash IParser.

@sancppp @ruitianzhong 如果你们会说汉语的话，可以在我的公众号私信，留下微信号，我来加你们。近期我们发起一次语音会议，讨论这些问题。


worked on the quicktype definitions

There are several issues with the quicktype generation right now.
First emailVerificationToken defines the following:
"required": [
"token",
"user",
"tokenType",
"tokenStatus",
"expiryDate"
],
Though there is no type user, but a type userid.
In addition the $id of several classes do not match the path they are actually in. E.g. createWebAnalyticEvent.json defines the $id as https://open-metadata.org/schema/api/tests/createWebAnalyticEvent.json, though the actual path is /api/analytics/createWebAnalyticEvent.json.
Lastly, I ran into problems due to the usage of https://open-metadata.org/ in the id, which caused the quicktype generator to constantly do http request, which also lead to blocked requests.
If you want to have a detailed log of the generation, you can always --debug all on the quicktype command on json2ts.sh:
./node_modules/.bin/quicktype -s schema
{schema_directory}$1" -o $PWD"/"$om_ui_directory$2 --just-types --debug all > output.log 2>&1
Also I put the output to a file.

Describe your changes:
Fixes #10811

Type of change:

[x] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Thanks @phalix for the contribution. Hopefully this reduces the time it takes to generate UI typescript

One issue we have is we are using $id to show the exact url where the schema is stored. This is for documentation and discovery purposes. Is there anything we can do to keep that but not let QuickType todo unnecessary lookups?

Hi @harshach, thank you so much for your comment. I can completely understand what you mean. Nevertheless, please keep in mind that the original given url refers always to the main branch. Hence major changes on the main branch, would make it impossible to compile previous branches. Thus I do recommend to refer the local git repo.

Hi we have covered these changes here: #12335


Testing Suite Error Message Unclear - Why Does it Not Run?

Describe the bug
Unclear error message for embedding test suite to front end projects
To Reproduce
Steps to reproduce the behavior:

Build a simple HTML page
Embed the testing javascript the head of that page

Expected behavior
Error message is unclear. Could be something like "ERROR: You're missing this element on your page"
Screenshots

Desktop (please complete the following information):

Browser Chrome
Here is the project live on GitHub Pages
Here is the GitHub project and source code

Additional context
I was building the tribute page project. I added the JS for the test suite. The testing suite isn't opening and the error message isn't helpful.

@iarobinson GitHub issues are reserved when a bug has been validated by others (typically on the forum).  Always reach out to the forum first and if members determine the issue is not your code, then you can open an issue.
I am closing this issue as you just need to move the link to to the test suite from the head element to right before the closing body tag (like below):
    <script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>
  </body>
</html>


Blue Dot Location Marker

Is it possible to show the blue dot marker that show user location like shown on this image: https://galileo-app.com/img/manual/position_marker.png ?

No. The blue dot is provided by Google. Not by this plugin.


Dashboard - Approval stamp wording

As a customer, the word approved is confusing and misleading.  Projects are registered, not approved.
Change the wording on the stamp to say "Registered"

Done, but we also need the same treatment on the certificate. I will make a new issue


Print pdf file

Hello @lukevp, did you get to read something about PDF printing using ESC POS? I could not figure out how to do it using the commands. Thank you!

Maybe transforming the PDF file into bitmap image and print it with image commands?

I also thought about this, but it is very difficult to convert pdf into image

@juliogamasso there's nothing in the ESCPOS standard that would let you print a PDF, you would have to use a separate library to rasterize it before printing.  What sort of PDF do you have that would be printable on a receipt printer?  Perhaps you could get the data in a different format?

The receipts can come in the format of the attached image, would it be possible to align a QrCode the way it is in the image? I have already implemented but only line by line, not side as it is in the image. If it is possible to mount an equal receipt using the commands we have already solved the problem.

To do this natively in ESCPOS, I believe this is something you would have
to use Page Mode for, which is not currently supported in the library. Page
Mode lets you control the printing position and place elements next to each
other. We don't need that for receipt prints since the area is so narrow,
so I haven't implemented Page Mode and don't plan on adding it, but it is
something you could add. Or you can try converting the PDF to a PNG and
printing that way.
On Tue, Jun 4, 2019, 7:57 AM juliogamasso<EMAIL_ADDRESS>wrote:

The receipts can come in the format of the attached image, would it be
possible to align a QrCode the way it is in the image? I have already
implemented but only line by line, not side as it is in the image. If it is
possible to mount an equal receipt using the commands we have already
solved the problem.
[image: danfe nfce]
https://user-images.githubusercontent.com/43079921/58880808-2a626100-86af-11e9-85ab-71e51f21ccdb.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lukevp/ESC-POS-.NET/issues/13?email_source=notifications&email_token=AAJRNSHXNOEBJVILGSIC373PYZREDA5CNFSM4HSRFLV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW4PHEY#issuecomment-498660243,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJRNSF35FDQNFEHTN3A7DLPYZREDANCNFSM4HSRFLVQ
.

Allright thanks.


Update Angular1 version

Since Angular 1.4 was already released... Guess we can expect this router for ng1.5

You should probably update the repo description as well


parallel reads seems to be turned off in lance?

I ran the label distribution query against coco for parquet and lance. For parquet, the total CPU time was greater than the Wall time, but for lance that was not the case. I vaguely remember discussing this before, not sure if it's already a known issue.

Yes, currently we disabled parallel reads when LIMIT / OFFSET is provided for simpler design for Limit exector. We can revise this decision though.


Feedback Milestone 2

Hello, Group 27,
My name is Mohamad Khajezade, and I will be giving you some feedback on your project.
This is a fantastic start, which shows your hard work on this project. However, there are some suggestions I have that will greatly improve the quality of your project."
I have divided up the feedback into several sections, so it is easier for you to implement.
Task 1

[1] The pipeline to load, clean, process, and wrangle the data was not completed, and you have jumped on task 3

Task 2

[1] You need to call your method changing in your notebook

Task 3

[1 ] Most of your charts doesn't include any title, caption, or legend, and the purpose of using these charts is not clear

Task 4

[1] Apart from charts and figures, you need to conduct some analysis that I couldn't find

Thank you for the feedback! I'm still a little bit confused though about a few of your comments under tasks 1, 2 and 4, could you please explain a bit further what I'm missing?
In task 1 I'm not sure what it is I'm missing to wrangle the data?
According to the milestone 2 instructions under task 2 it gives an example of how we should be loading the data into the notebook and calling the method chain which is exactly how I did in my first cell:
df = project_functions.load_and_process()
And for task 4 I'm not sure what analysis I'm missing, could you give an example or explain a bit further here?
Thanks

Hello,
I checked your project again. Sorry for missing your work for task1 and task2. I went to grade scope and changed my feedbacks for all of your tasks for milestone 2. The only thing that I can suggest to improve your project is to add some analysis to address your research questions. By analysis, I mean, for instance, calculating the sum of the trades for each currency, and then based on this sum, you conclude that this type of currency is more popular. Please let me know if you have any other questions. Sorry again for missing your project tasks.
Cheers,
Mohamad

Hi Mohamad,
Thank you for the clarification!
Sorry to bother you again but I just wanted to make sure I'm clear on task 4. I was under the impression that my analysis was covered throughout my section labeled analysis (located under my Exploratory Data Analysis). In the section, I answered my 3 research questions and provided new graphs to answer them as clearly as I could. Not sure whether you are suggesting I add another analysis or if the analysis I had provided was not sufficient for that section.
Again, sorry for the bother and I know it's somewhat last-minute but I want to be extra clear before I put in the time to make the adjustments.
Thanks,
Owen

Hello Owen,
Your work is perfect as far as I am concern. If you check your feedbacks on grade scope, you can see that you exceed expectations for each of these duties.  The suggestion is just to make it even better. Thus, the analysis that I mentioned is just a suggestion to add to your current works.
Cheers,
Mohamad

I see, thank you!


WebHost always calls StopAsync on a Server even if StartAsync wasn't called.

Discovered as part of https://github.com/aspnet/AspNetCore/pull/9859. We have logic in IIS inproc that tries to drain all existing requests before shutting down, which relies on a callback to be set in StartAsync for a tcs to be completed. If an exception is thrown from Configure/ConfigureServices, the server will still call Server.StopAsync from WebHost.StopAsync even if StartAsync wasn't called.
The fix I'm adding is to check if StartAsync was called before doing anything in StopAsync. I feel like this should be solved in a more universal way though. Looking at Stop async in Kestrel https://github.com/aspnet/AspNetCore/blob/master/src/Servers/Kestrel/Core/src/KestrelServer.cs#L172, I think the start/stop logic I suggested is safe here too.

DisposeAsync calls StopAsync:
https://github.com/aspnet/AspNetCore/blob/4cb86bc15160e493e6331190da9973736f0fc240/src/Hosting/Hosting/src/Internal/WebHost.cs#L355-L371
GenericHost no longer does this:
https://github.com/aspnet/Extensions/blob/1b1558ebc1f33a70c76736f6a26d907b6dcca270/src/Hosting/Hosting/src/Internal/Host.cs#L110-L121
Possible fix:
WebHost.StopAsync already checks _stopped to prevent double calls.
https://github.com/aspnet/AspNetCore/blob/4cb86bc15160e493e6331190da9973736f0fc240/src/Hosting/Hosting/src/Internal/WebHost.cs#L312-L316
We could also add a _started and set it at the end of StartAsync and have StopAsync only run if _started.

I'll do this as part of https://github.com/aspnet/AspNetCore/issues/9929.


apps/sys/clusterapp

c.cluster.DeployAppImage(AppQName, image blob) - wrong, should be c.cluster.DeployAppImage(AppQName, ImageBLOBID int64) - no porblem, blob will be stored in the target app - in cluster in our case

error on non-registered app?
what else should it do?

c.cluster.RegisterApp(descr AppDescriptor)

error on exists already or error if already was registered with different parts amount?
manage index by AppID?

c.cluster.DeployAppImage(AppQName, image blob) - wrong, should be c.cluster.DeployAppImage(AppQName, ImageBLOBID int64) - no porblem, blob will be stored in the target app - in cluster in our case

error on non-registered app?
what else should it do?

c.cluster.RegisterApp(descr AppDescriptor)

error on exists already?
manage index by AppID?

`cluster.c.DeployAppImage(AppQName, image blob)

Ref. #1890


Kubernetes@1 reports 'rollout' is not an accepted command when it is

In short
Fix Kubernetes@1 job to accept command rollout.
More details
When a command "rollout" is used with Kubernetes@1 job, the extension reports "Value is not accepted" which is completely false: job works as intended.

(reports "not accepted", however it does work)
This was already reported on StackOverflow 4 years by someone else: https://stackoverflow.com/questions/64268770/azure-devops-pipeline-kubectl-task-command-rollout-unavailable
I think this misinformation really needs to get fixed. I almost ended up thinking your Kubernetes job does not accept rollout command and that I'd have to use "delete" on pods found via labels instead of a normal, graceful rollout restart.

Thanks for reporting @mislavmatijevic - sorry for the confusion. Could you please re-file this over at https://github.com/microsoft/azure-pipelines-tasks? That repo contains the completion definitions for individual tasks (see https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/KubernetesV1/task.json#L141-L154 which is missing the rollout command).

Hello @50Wliu, thanks for such a quick response.
I noticed the enumeration of the command values for the Kubernetes@1 job without the rollout command in question on this repo and therefore opened an issue here. I'll open a new one on that other link. Thanks again!

For anyone coming across this issue in the future, I reopened it here: https://github.com/microsoft/azure-pipelines-tasks/issues/20562


v8 gc-tracer-inl debug assertion: IsMainThread

Title: v8 gc-tracer-inl debug assertion: IsMainThread
Description:
We are seeing a debug assertion triggered when using WASM with debug build:

#
# Fatal error in external/v8/src/heap/gc-tracer-inl.h, line 60
# Debug check failed: tracer_->heap_->IsMainThread() || tracer_->heap_->IsSharedMainThread().
 I can try to reduce to a concrete Envoy config example if needed and when I find time

#0  0x000055e022c74379 in v8::base::OS::Abort()::$_0::operator()() const () at external/v8/src/base/platform/platform-posix.cc:674
674     external/v8/src/base/platform/platform-posix.cc: No such file or directory.
[Current thread is 1 (LWP 44)]
(gdb) bt
warning: Could not find DWO CU bazel-out/k8-dbg/bin/external/v8/_objs/v8_libbase/logging.pic.dwo(0x7eeb01f759ed4652) referenced by CU at offset 0x1d0e57 [in module /tmp/tmp.7XwyQZOcIw/usr/local/bin/envoy]
#0  0x000055e022c74379 in v8::base::OS::Abort()::$_0::operator()() const () at external/v8/src/base/platform/platform-posix.cc:674
#1  0x000055e022c74363 in v8::base::OS::Abort() () at external/v8/src/base/platform/platform-posix.cc:674
#2  0x000055e022c53f7e in V8_Fatal(char const*, int, char const*, ...) () at external/v8/src/base/logging.cc:167
#3  0x000055e022c5390c in v8::base::(anonymous namespace)::DefaultDcheckHandler(char const*, int, char const*) () at external/v8/src/base/logging.cc:57
warning: Could not find DWO CU bazel-out/k8-dbg/bin/external/v8/_objs/v8_libshared_noicu/array-buffer-sweeper.pic.dwo(0x897d6acfe3cf22ec) referenced by CU at offset 0x1c6d6f [in module /tmp/tmp.7XwyQZOcIw/usr/local/bin/envoy]
#4  0x000055e022c54007 in V8_Dcheck(char const*, int, char const*) () at external/v8/src/base/logging.cc:171
warning: Could not find DWO CU bazel-out/k8-dbg/bin/external/v8/_objs/v8_libshared_noicu/1/heap.pic.dwo(0x6844b6fa3feff95b) referenced by CU at offset 0x1c72ff [in module /tmp/tmp.7XwyQZOcIw/usr/local/bin/envoy]
#5  0x000055e0204aa6f6 in v8::internal::GCTracer::Scope::~Scope() () at external/v8/src/heap/gc-tracer-inl.h:59
#6  0x000055e0205b00cb in v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) ()
    at external/v8/src/heap/heap.cc:1845
#7  0x000055e0205af509 in v8::internal::Heap::CollectAllGarbage(int, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) () at external/v8/src/heap/heap.cc:1606
warning: Could not find DWO CU bazel-out/k8-dbg/bin/external/v8/_objs/wee8/c-api.pic.dwo(0x26dc787cf2365f0e) referenced by CU at offset 0x1c3b2b [in module /tmp/tmp.7XwyQZOcIw/usr/local/bin/envoy]
#8  0x000055e0205b2340 in v8::internal::Heap::PreciseCollectAllGarbage(int, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) () at external/v8/src/heap/heap.cc:1736
#9  0x000055e01fb76a51 in wasm::StoreImpl::~StoreImpl() () at external/v8/src/wasm/c-api.cc:414
warning: Could not find DWO CU bazel-out/k8-dbg/bin/external/proxy_wasm_cpp_host/_objs/v8_lib/v8.pic.dwo(0x48bd2bcbe2fcd757) referenced by CU at offset 0x1c3af7 [in module /tmp/tmp.7XwyQZOcIw/usr/local/bin/envoy]
#10 0x000055e01fb76e3a in wasm::Store::~Store() () at external/v8/src/wasm/c-api.cc:460
#11 0x000055e01fb6fc7b in std::__1::default_delete<wasm::Store>::operator()(wasm::Store*) const () at /usr/lib/llvm/bin/../include/c++/v1/memory:1423
#12 0x000055e01fb6fbfc in std::__1::unique_ptr<wasm::Store, std::__1::default_delete<wasm::Store> >::reset(wasm::Store*) () at /usr/lib/llvm/bin/../include/c++/v1/memory:1684
#13 0x000055e01fb3b239 in std::__1::unique_ptr<wasm::Store, std::__1::default_delete<wasm::Store> >::~unique_ptr() () at /usr/lib/llvm/bin/../include/c++/v1/memory:1638
#14 0x000055e01fb3c652 in proxy_wasm::v8::V8::~V8() () at external/proxy_wasm_cpp_host/src/v8/v8.cc:66
warning: Could not find DWO CU bazel-out/k8-dbg/bin/external/envoy/source/extensions/common/wasm/_objs/wasm_lib/wasm.pic.dwo(0x861541c67593e3e2) referenced by CU at offset 0x10878a [in module /tmp/tmp.7XwyQZOcIw/usr/local/bin/envoy]
#15 0x000055e01fb3c689 in proxy_wasm::v8::V8::~V8() () at external/proxy_wasm_cpp_host/src/v8/v8.cc:66
#16 0x000055e01f50443c in std::__1::default_delete<proxy_wasm::WasmVm>::operator()(proxy_wasm::WasmVm*) const () at /usr/lib/llvm/bin/../include/c++/v1/memory:1423
#17 0x000055e01f5043bc in std::__1::unique_ptr<proxy_wasm::WasmVm, std::__1::default_delete<proxy_wasm::WasmVm> >::reset(proxy_wasm::WasmVm*) ()
    at /usr/lib/llvm/bin/../include/c++/v1/memory:1684
warning: Could not find DWO CU bazel-out/k8-dbg/bin/external/proxy_wasm_cpp_host/_objs/base_lib/wasm.pic.dwo(0xecae9a03d54f098b) referenced by CU at offset 0x1c3ac3 [in module /tmp/tmp.7XwyQZOcIw/usr/local/bin/envoy]
#18 0x000055e01f4fc209 in std::__1::unique_ptr<proxy_wasm::WasmVm, std::__1::default_delete<proxy_wasm::WasmVm> >::~unique_ptr() ()
    at /usr/lib/llvm/bin/../include/c++/v1/memory:1638
#19 0x000055e01fb15542 in proxy_wasm::WasmBase::~WasmBase() () at external/proxy_wasm_cpp_host/src/wasm.cc:225
#20 0x000055e01f4e53f3 in Envoy::Extensions::Common::Wasm::Wasm::~Wasm() () at external/envoy/source/extensions/common/wasm/wasm.cc:153
#21 0x000055e01f4ff8dd in std::__1::__shared_ptr_emplace<Envoy::Extensions::Common::Wasm::Wasm, std::__1::allocator<Envoy::Extensions::Common::Wasm::Wasm> >::__on_zero_shared() ()
    at /usr/lib/llvm/bin/../include/c++/v1/memory:2639
#22 0x000055e0264b87de in std::__1::__shared_weak_count::__release_shared() ()
#23 0x000055e01f4fbf5c in std::__1::shared_ptr<proxy_wasm::WasmBase>::~shared_ptr() () at /usr/lib/llvm/bin/../include/c++/v1/memory:3233
#24 0x000055e01f5006ed in proxy_wasm::WasmHandleBase::~WasmHandleBase() () at external/proxy_wasm_cpp_host/include/proxy-wasm/wasm.h:329
#25 0x000055e01f5005a1 in Envoy::Extensions::Common::Wasm::WasmHandle::~WasmHandle() () at external/envoy/source/extensions/common/wasm/wasm.h:126
#26 0x000055e01f5003bd in std::__1::__shared_ptr_emplace<Envoy::Extensions::Common::Wasm::WasmHandle, std::__1::allocator<Envoy::Extensions::Common::Wasm::WasmHandle> >::__on_zero_shared() () at /usr/lib/llvm/bin/../include/c++/v1/memory:2639
#27 0x000055e0264b87de in std::__1::__shared_weak_count::__release_shared() ()
#28 0x000055e01f4fc7ec in std::__1::shared_ptr<proxy_wasm::WasmHandleBase>::~shared_ptr() () at /usr/lib/llvm/bin/../include/c++/v1/memory:3233
#29 0x000055e01fb1527b in proxy_wasm::WasmBase::~WasmBase() () at external/proxy_wasm_cpp_host/src/wasm.cc:225
#30 0x000055e01f4e53f3 in Envoy::Extensions::Common::Wasm::Wasm::~Wasm() () at external/envoy/source/extensions/common/wasm/wasm.cc:153
#31 0x000055e01f4ff8dd in std::__1::__shared_ptr_emplace<Envoy::Extensions::Common::Wasm::Wasm, std::__1::allocator<Envoy::Extensions::Common::Wasm::Wasm> >::__on_zero_shared() ()
    at /usr/lib/llvm/bin/../include/c++/v1/memory:2639
#32 0x000055e0264b87de in std::__1::__shared_weak_count::__release_shared() ()
#33 0x000055e01f4fbf5c in std::__1::shared_ptr<proxy_wasm::WasmBase>::~shared_ptr() () at /usr/lib/llvm/bin/../include/c++/v1/memory:3233
#34 0x000055e01f5006ed in proxy_wasm::WasmHandleBase::~WasmHandleBase() () at external/proxy_wasm_cpp_host/include/proxy-wasm/wasm.h:329
#35 0x000055e01f5005a1 in Envoy::Extensions::Common::Wasm::WasmHandle::~WasmHandle() () at external/envoy/source/extensions/common/wasm/wasm.h:126
#36 0x000055e01f5003bd in std::__1::__shared_ptr_emplace<Envoy::Extensions::Common::Wasm::WasmHandle, std::__1::allocator<Envoy::Extensions::Common::Wasm::WasmHandle> >::__on_zero_s

The thing that triggers it is load + unload module. Seems it might only happen with traffic going through

The issue is again Wasm being deleted on a worker. Not sure where we missed yet another case.

@kyessenov do you happen to have a pointer to previous case(s) you mentioned?

I found this as part of ECDS PR. Basically, Wasm filter factory had to be deleted on main, because something in v8 would only allow deletion on main. I thought we handled that already, but the issue still seems to be present.

https://github.com/envoyproxy/envoy/blob/main/source/common/filter/config_discovery_impl.h#L158

Just fyi this is still happening

Which Wasm module is it btw?

At least in https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/41718/integ-telemetry-istiodremote_istio/1631123843353415680
TestBadWasmRemoteLoad which appears to be a NOP entirely... I am guessing it just is reported later and actually crashed from gcr.io/istio-testing/wasm/header-injector

I think this may have been known, but we are still seeing this so https://github.com/envoyproxy/envoy/pull/26348 did not fix this one

It's possible - there are lots of thread locals in proxy-wasm, and it's not clear to me they are destroyed in the right order @PiotrSikora . My PR should have fixed ECDS for non-wasm filter destruction.

FWIW this still occurs on master


Update dependency to latest version: github.com/aws/aws-xray-sdk-go

What does this PR do?
Update dependency: github.com/aws/aws-xray-sdk-go from v1.0.0-rc.9 to v1.4.0
Motivation
2+ years of bug fixes and improvements
Testing Guidelines
ran go test ./... locally
Additional Notes
Types of changes

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[x] Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

[x] This PR's description is comprehensive
[ ] This PR contains breaking changes that are documented in the description
[ ] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
[ ] This PR impacts documentation, and it has been updated (or a ticket has been logged)
[ ] This PR's changes are covered by the automated tests
[ ] This PR collects user input/sensitive content into Datadog

Hi @drichelson, thanks for opening this PR! We ended up incorporating this change (and a few others) into #84.


Add test spec for log component

Add test spec for log component

Coverage remained the same at 55.309% when pulling c837a1fb9ea8039694724d99884d4d9f6d45a9ab on steven-zou:master into b7e1df7e1c5dac3fda2e10175d177a92be0a992a on vmware:master.


Fold indicator styling via CSS not working

From the documentation in LineNumberFactory class, I should be able to change the fold indicator ("+")  styling using the CSS class ".fold-indicator". I tried doing that but nothing changed. Here is my styling
.fold-indicator{       -fx-text-fill: green; }
and I also tried
.fold-indicator{       -fx-fill: green; }
But it doesn't still work.

I don't know why but if you edit styled-text-area.css and remove the .fold-indicator style then it works ?

I don't know why but if you edit styled-text-area.css and remove the .fold-indicator style then it works ?

Thanks. It worked by removing the fold-indicator class from styled-text-area.css
I just wish there could be another way to

Submitted PR #1000 that will fix and close this issue.

Submitted PR #1000 that will fix and close this issue.


PC freez after i run “sudo bash BootVM”

dear sir if you attempted to update your mac os you will get this error but if you try to stay of the mojave you will be good and if you still get the same error im here to help.

I did not update, its after install VM first run

Anyone fixed yet?


Fixed receiving CSRF token

The controllers UniFI.OS since version 6.4.5 CSRF token is passed to the header and not in the COOKIES

I can confirm that this PR fixes problem mentioned in #19.
Tested on UniFi OS UDM Pro 1.10.4 & Network Controller 6.4.54.
Can we get this merged?


Strings not highlighted anymore

I use a theme that's supposed to highlight strings (in green):

https://github.com/atom/atom/tree/master/packages/one-dark-syntax
Up to today, it was highlighting strings in terraform too.
But not sure what changed today, strings in terraform are not highlighted anymore:

Any idea how to highlight strings back?
Other languages are fine, e.g. python:

It seems specific to this package, and recent.

There are no recent updates to this package as seen in the version history: https://github.com/cmur2/language-terraform/releases
Which version of Atom and of the language-terraform package are you using? Maybe we can narrow down what changed :)

Yes, that's why I'm asking for help, I don't know what happened =(
$ atom --version
Atom    : 1.56.0
Electron: 9.4.4
Chrome  : 83.0.4103.122
Node    : 12.14.1

I'm using the versions of all components and the same Atom version, and I seem to have lost some of the secondary syntax highlighting for Terraform:

Thanks for both of your input! I will have a look at the problem, whether I can reproduce it and what might be causing it.
My first goto was https://atom.io/releases to check whether it mentions anything noteworthy regarding syntax highlighting changes... nothing obvious to me.

I can reproduce the issue locally when updating my Atom from version 1.53.0 to 1.56.0:

Hmmm...

@lra @craigwatson I'm happy to report that the syntax highlighting works again with no changes on current https://atom.io/nightly (1.58.0-nightly) - the comment https://github.com/atom/atom/issues/22168#issuecomment-817189907 made me try this. Would be great if you can confirm this in case you feel adventurous enough to try the nightly.
So for now I'd recommend downgrading to the last known good Atom version 1.55.0 if you consider the weird highlighting of language-terraform important enough + that's possible for you 🙂

Not for me with nightly =(

Also sadly not fixed for me with the latest nightly build:

Confirmed that rolling back to 1.55.0 fixes the problem though:

Given that there is still activity and new reports coming in at https://github.com/atom/atom/issues/22168 I'd not spent further time troubleshooting for now since I realize that the Atom nightly build is a moving target -- it might behave differently every day depending on what upstream does.
Recommendation for now would be going back to 1.55.0 and wait what a release of 1.57.0 and/or 1.58.0 brings.

FTR, 1.57.0 just got released and the problem is still happening.

@lra looks like the problems still persist with Atom 1.57.0 also for other people, such as https://github.com/atom/atom/issues/22168#issuecomment-841309800
I'm still leaning towards waiting how https://github.com/atom/atom/issues/22168 develops (whether it's a theme issue or a language syntax issue) as it's not clear to me how to proceed. During that time downgrading to Atom 1.55.x is what I'd recommend :/


Add {reply} as an embed error

{reply} would simply reply to the command that triggered it with something such as channelSendMessage or sendMessage.

Adding on, there could also be an option messageID argument such as {reply:messageID}


Pass Gradle's System Properties (-D) starting with "org.embulk" to testing JVM.

@muga A small change in build.gradle only impacting tests.
It passes System Properties of Gradle (can be specified with -D) which start with "org.embulk" into testing JVM. It allows developers to test like:
./gradlew -Dorg.embulk.someTestingRuntimeParameter=foobar test

so that the test can switch its behavior at runtime. One typical usage is removing temporary files. Temporary files are to be removed in usual cases. But, we sometimes want to keep temporary files to analyze when we run tests locally.
https://github.com/embulk/embulk/pull/687/files#diff-de1fed31d83d9cbde4b42260d2e2a8f5R48 is an example.

@dmikurube I have one question. How often you want to change the system property? If he values of the system properties are changed every ./gradlew execution time, this approach makes sense. If not every time, can we take an ad-hoc approach like declaring the system property and the value in build.gradle directly like https://github.com/embulk/embulk-input-jdbc/blob/master/build.gradle#L107. I'm still thinking that this approach is a little bit tricky for me.

@muga Hmm, it's not often, and that is the reason why I made it like this.
For example in case of https://github.com/embulk/embulk/pull/687/files#diff-de1fed31d83d9cbde4b42260d2e2a8f5R48, we usually (in-CI and manually) run this without the system property. We sometimes want to change to debug locally.
You mean we should change build.gradle locally when we need such a customization? I think it's not very good because 1) changing build.gradle ad-hoc may impact on unexpected parts, and 2) we may merge that ad-hoc change by mistake. It is better to customize local tests without local edits.
If we write the properties directly in build.gradle like that JDBC example, we cannot customize at runtime. The purpose here is to customize sometimes.

@dmikurube The PR looks good to me as talked directly about it to you. Can you file a ticket about why Embulk's tests failed when all system properties were passed to the Embulk?

Thanks! Filed #692, and merging this PR.


When ./data is old and out of date apps fail to start

Maybe delete it and regenerate if it's older than a week or two?

OK looks like a good feature request, it could also be classed as a bug.  This will need investigating.  I'll take this to the team, also might be worth just regenerating the data directory every time the startup script is run.

OK looks like a good feature request, it could also be classed as a bug.  This will need investigating.  I'll take this to the team, also might be worth just regenerating the data directory every time the startup script is run.

This was addressed in this PR:
https://github.com/alphagov/verify-local-startup/pull/70
Closing this issue.


Do we need interop with trace4cats?

trace4cats lib have some context type classes and lenses right here, so when you use tofu context type classes and lenses with TF style you probably need some interop implicit conversion, which we can provide for users automatically. Can we place it inside tofu?

We definitely need interop, and we already have it. But it's not published and I am not sure if the main repo is a right place for it.

What do you mean 'main repo'? trace4cats or tofu? If we already have it - how I can find it?

We a talking about little bit tidening here and moving some integrations to dedicated repos under the tofu.tf org

Ok then, how I can contribute it now? And how can foreign contributors do it?

I've sent an invitation to you, you can start a new repo, private or public after acceptance

Thank you for the invitation! @Odomontois the last one question - how do we version repo?

@Ssstlis Ideally a foreign repo have the same first two numbers (after zero) as the core tofu version, and then an additional number for it's own updates, unrelated to the core


JetPack -> Modifiers -> Actions: Modifier.swipeable(     state: SwipeableState,     anchors: Map<Float, T>,     orientation: Orientation,     enabled: Boolean,     reverseDirection: Boolean,     interactionSource: MutableInteractionSource?,     thresholds: (from, to) -> ThresholdConfig,     resistance: ResistanceConfig?,     velocityThreshold: Dp )

Doc: https://developer.android.com/reference/kotlin/androidx/compose/ui/Modifier#(androidx.compose.ui.Modifier).swipeable(androidx.wear.compose.material.SwipeableState,kotlin.collections.Map,androidx.compose.foundation.gestures.Orientation,kotlin.Boolean,kotlin.Boolean,androidx.compose.foundation.interaction.MutableInteractionSource,kotlin.Function2,androidx.wear.compose.material.ResistanceConfig,androidx.compose.ui.unit.Dp)
Enable swipe gestures between a set of predefined states.

This modifier is for Wear OS (smart watches)