problem with feed burner: can't load feed

I'm had problems adding this feed to livemarks: http://feeds.feedburner.com/AvasDemon
It said: "Failed to fetch feed"
I then disabled tracking protection and uBlockOrigin on the feedburner site, reloaded it and clicked on this now visible link:

it points to: http://feeds.feedburner.com/AvasDemon?format=xml
then it automatically opened the livemarks page and I could subscribe to the feed
just fyi, maybe add it to FAQ
(or add the "?format=xml" automatically to feedburner links, if thats possible somehow)

I can't reproduce this, http://feeds.feedburner.com/AvasDemon works for me. I actually explicityl tested feedburner before.

Btw http://feeds.feedburner.com/AvasDemon should already render our own preview page, so I am not sure why you even see the other one.

It works now for me, too.
Sorry, maybe this was a one time thing.


Error message presented to user who does not have access to setup is misleading.

Rancher server version  - v1.6.6-rc3
Have AD auth enabled with "Site Access" set to "Allow members of Environments.plus Authorized Users and Organization"
Scenario 1:
Try to log in using valid credentials as a user who does not have access to the setup.
User is presented with "Username or Password incorrect"
Request URL:http://<ip address>:8080/v2-beta/token
Request Method:POST
Status Code:401 Unauthorized
Remote Address:<IP_ADDRESS>:8080
Referrer Policy:no-referrer-when-downgrade

This error message is misleading. Can this be error message be improved?
Scenario 2:
When invalid credentials  are passed ("Valid username but invalid password ) - User is presented with "Error Response from Auth service"
Request URL:http://<ip>:8080/v2-beta/token
Request Method:POST
Status Code:503 Service Unavailable
Remote Address:<IP_ADDRESS>:8080
Referrer Policy:no-referrer-when-downgrade

rancher-server logs:
time="2017-07-26T01:01:30Z" level=error msg="GetToken failed with error: Error LDAP Result Code 49 \"Invalid Credentials\": 80090308: LdapErr: DSID-0C0903CF, comment: AcceptSecurityContext error, data 52e, v2580\x00 in ldap bind"
2017-07-26 01:01:30,020 ERROR [:] [] [] [] [tp1020391880-98] [.a.a.i.e.ExternalServiceAuthProvider] Got error from Auth service. statusCode: 500

Is this error message acceptable?

4xx codes: the client's input is unacceptable and if they try different input the request may succeed.

401 Unauthorized: the credentials provided are wrong.
403 Forbidden: the credentials provided are valid, but we don't want to let you in anyway.
422 Unprocessable Entity: validation of the body contents failed (not really relevant to this issue)

5xx codes: something went wrong on the server's side and the client didn't do anything wrong and can't do anything to fix it.

So both the above sound wrong.  There are three situations:
User or password incorrect:

Status Code: 401 Unauthorized
Body: Something like {"type": "error", "statusCode": 401, "message": "Username or password incorrect"}
The UI shows it's own translation string for this based on seeing 401.

Username and password are correct, but that person is not allowed in:

Status Code: 403 Forbidden
Body: Something like {"type": "error", "statusCode": 403, "message": "Your account does not have access"}
I don't think the UI does currently, but it should show a different translation string based on seeing 403.

Unable to determine if credentials are correct because you couldn't talk to auth provider or the auth service:

Status Code: 500 Internal Server Error
Body: Something like {"type": "error", "statusCode": 500, "message": "Error reaching ActiveDirectory server"}, or "Error reaching auth service", "SSL verification failed while talking to ActiveDirectory server", or whatever you can figure out about what happened.
The UI should show whatever the message is (untranslated), as any number of things can be wrong.

@deniseschannon @sangeethah The above fixes address Scenario 2. Please can you log a separate issue for Scenario 1

@prachidamle , Fix for this is not going to be made for this ?
403 Forbidden: the credentials provided are valid, but we don't want to let you in anyway.

@sangeethah now Scenario1 is also fixed.
Username and password are correct, but that person is not allowed in:
Status Code: 403 Forbidden
Body: Something like {"type": "error", "statusCode": 403, "message": "Your account does not have access"}

Available in v1.6.8-rc1

Tested with Rancher server version - v1.6.8-rc1
Scenario 1:
Site Access setup as - "Allow member of Environment , plus Authorized Users and Organizations"
Try to log in using valid credentials as a user who does not have access to the setup.
User is presented with "Your account does not have access"
Scenario 2:
Site Access setup as - "Allow member of Environment , plus Authorized Users and Organizations"
Try to log in using invalid credentials (valid user name/invalid password , invalid user name)
User is presented with "Username or Password incorrect."
Scenario 3:
Site Access setup as - "Restrict access to only  Authorized Users and Organizations"
Try to log in using valid credentials as a user who does not have access to the setup.
User is presented with "Username or Password incorrect." in this case
time="2017-08-09T18:55:08Z" level=error msg="Cannot locate user information for (&(sAMAccountName=testuser4)(|(distinguishedName=CN=Test User1,CN=Users,DC=tad,DC=rancher,DC=io)(distinguishedName=CN=Test User2,CN=Users,DC=tad,DC=rancher,DC=io)(memberof=CN=testgroup4,CN=Users,DC=tad,DC=rancher,DC=io)(memberof=CN=testgroup3,CN=Users,DC=tad,DC=rancher,DC=io)))"

Reopening this issue to fix scenario 3.

Available with rancher/server:v1.6.8-rc4

Tested with rancher/server:v1.6.8-rc4:
Site Access setup as - "Restrict access to only Authorized Users and Organizations"
Try to log in using valid credentials as a user who does not have access to the setup.
User is presented with  - "Your account does not have access" as expected.


Show icon on files supported by the extension

Ola,
I appreciate seeing an icon for files supported by a language extension (in the explorer, and on the edited file).
It could be great to have it for vento.
A small change in the package.json enables to do it.

With icon
Without icon

Good idea. Thanks!


Add annotate, search, versions, and ancestors functions

CC @pkalita-lbl

Codecov Report

Merging #6 (ff53676) into main (ee040b9) will increase coverage by 0.98%.
The diff coverage is 72.22%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   71.23%   72.22%   +0.98%
==========================================
  Files           4        4
  Lines          73       90      +17
  Branches       14       17       +3
==========================================
+ Hits           52       65      +13
- Misses         17       20       +3
- Partials        4        5       +1

Impacted Files
Coverage Δ

src/ontoportal_client/api.py
85.00% <72.22%> (-3.38%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us.


lIsLinear is being unused

if cmsIsToneCurveLinear is false, it is written to be excluded.
Adding it in if loop to be excluded.

lIsLinear is currently not used, and this is how it has to be. Thanks.


Suppressed Exceptions dropped when converting to PlaceholderException

When running tests, if exceptions are thrown, Gradle is seemingly trying to serialise it before printing the stack trace. Some custom exceptions are however not being printed directly but will be transformed into PlaceholderException where most of the information is copied over. However suppressed exceptions from the original exceptions are lost in the process.
Expected Behavior
All exceptions' suppressed exceptions should be preserved and be printed out.
Current Behavior
Specifically, JUnit5's important new feature, i.e, Assertions.assertAll will throw opentest4j's MultipleFailuresError (extends AssertionError). It will append exceptions thrown by the individual assertions as suppressed exceptions. And then those very useful messages will be dropped by Gradle test tool. I have tried AssertionError itself will not be transformed and suppressed exceptions are preserved.
Context
assertAll is one of the very important new feature from JUnit5 where it will not exit the test case immediately when one of the many assertions failed but instead will run all of them and report results together. However, because of how Java exception works it cannot dump all stack traces for all the assertions' exceptions together. Instead, stack traces are appended as suppressed exceptions. They are very useful because the stack trace of the wrapping exception, MultipleFailuresError, only contains the assertions' results and most useful debugging information are in the suppressed exceptions.
Steps to Reproduce
Create a JUnit 5 test case, use the assertAll assertions and any number of sub assertions. Throw exceptions in any of the sub assertions. No stack trace of that exception is appended. Originally it's an issue in JUnit side, but it's been fixed in 2018 (https://github.com/junit-team/junit5/issues/1602)
Your Environment
Java 8/11, Gradle 6.0.1, JUnit 5.6.2
Build scan URL:
NA

Thanks for the report and detailed explanation.
#12302 is an issue with a similar cause.

I think this can be closed as duplicate of #9487.

Closing as duplicate indeed.


Optionally disable HTML parsing

Taking my cue from #225, I went with a probably-too-naive approach but I figured it'd be a starting point.

Looks like it's failing CI is because the bundle size is too big by 26 B! Yikes. I'm not sure how to get that down when all I did was add conditional rules. Input is welcome.


Add the rest of the APIs to the OpenAPI spec file

There are still missing API paths from the spec document. Add them to the document.
Original reference documentation can be found here.
AC:

[x] Spec contains the RBAC/List resources endpoint - #72
[x] Spec contains the RBAC/Show permitted roles endpoint
[x] Spec contains the RBAC/Show resource endpoint
[x] Spec contains the RBAC/Check permissions endpoint
[x] Spec contains the HostFactory/Create Token endpoint
[x] Spec contains the HostFactory/Revoke Token endpoint
[x] Spec contains the HostFactory/Create Host endpoint
[x] Spec contains the SSH/Show Public Key resources endpoint
[ ] (Optional) Expand the example to test out the generated Python3 client

Closing, as the spec currently contains all of the listed endpoints

Closing, as the spec currently contains all of the listed endpoints