Remove ExportConfig model.  Replace on Job model with foreign key to DatamodelPreset.

Coverage decreased (-1.4%) to 86.482% when pulling 2e43ee761f96c97f8d4102f290167db767cc3c0f on JivanAmara:remove-export-config into 875015be790df2a0fa305f76f0b67deb62c6cb56 on terranodo:master.


Pull upstream

Pulled in upstream changes

merging in since it's been on the build servers since December.


refactor: reorganize atomic api and structure

Exploring best practices for jotai usage in hypothetical "big" projects -- currently not set in stone, see https://github.com/pmndrs/jotai/discussions/896:

Put as much mutation logic into writable atoms (gives nice separation similar to MVC where jotai atoms handle Model and Controller, and React components handle View)
Collocate atoms that are relevant to a single component / subsystem with the component / subsystem itself
Group multiple related write-only (actions) / read-only (states) atoms into custom hooks (as a side effect implementation details like the undoHistoryAtom here need not be exported and can remain "private"

👍🏻


Move from navigate to window.locate for search filters

Navigate in Gatsby was causing a full rerender of the page on trigger,
which meant that n1, you were pushed to the top of the page quite
violently every time you did a search but also with a search being
programatically triggered, it would then get retriggered by the page
refresh. There would then be a race condition and everything got a bit
strange.
One way to solve this would have been to stuck with just using page
refreshes however I much prefer a dynamic search without jumping around
all over the place so went in that direction.
I have stored a page location object which I updated with the new path
name and search params when filters change the URL which allows it to
act like navigate for the pagination which uses page location. I could
have setup pagination to then change page dynamically as well but then
you need to scroll to things and page refreshing is an easy way to skip
all that. Also means the pagination would not have been as easily
reusable.
Its a bit of a Frakensteins monster, however I hope it makes sense!
Happy for any review comments/ideas.
Describe your PR
Related to #
Fixes #
Pages/Interfaces that will change
Screenshots / video of changes
Drop some screenshots of the before and after of your work here. Better yet, take a screen recording using a tool like Loom
Steps to test

Additional notes

Forgot to say, much credit to: https://github.com/Rebuild-Black-Business/RBB-Website/pull/246 who figured out what was going on!

@llexical how can I test this out?

@mbifulco Here's the trello card with details
https://trello.com/c/QNWA1y7N/205-when-changing-search-type-to-all-from-in-need-with-predefined-search-parameters-it-just-returns-all-results

@mbifulco Heres a link: https://5ee38e9165cec40007cd3574--rebuild-black-business.netlify.app/


SVG compound path issue (likely involving edge pixels)

Hello, this is an amazing utility that has been working great for me until I found an issue with the following image (8-bit png w/transparency):

The resulting svg has a flaw:  it seems to have a compound path joining 2 areas that should not be connected, illustrated here:

I have tried playing with every applicable setting, but no luck.
Code:
var settings = {
	ltres:				1,
	qtres:				1,
	pathomit:			8,
	rightangleenhance:	false,
	blurradius:			0
};

ImageTracer.imageToSVG(
	'test-1-advice-10x.png',
	function( svgStr ) { /* do stuff */ },
	settings
);

I wanted to add that I found a workaround for this - I added a transparent 5px border to my source image, applied ImageTracer, then cropped the border back out of the resulting SVG by altering the width, height and viewBox properties.

Hi,
Thanks for reporting and for the workaround! :) I'm not 100% sure what's the cause, but I'll try to fix it.

I hope this is fixed now in the new 1.2.2 version. The problem was incorrect initial values for a bounding box, which is required to find the parent shape of a hole.

Thank you so much.  This library is a lifesaver on a project I am working on!


Multipart upload fails with 'Bad Request' error when file larger than 5Mb.

Hi,
We are using OneDrive API for shipped application on Appstore and mane of our users can't upload file to OneDrive with Bad Request Error. After testing I have found out that it's not possible to upload file larger than 5MB using Multipart upload.
Here is request itself:
POST /v1.0/drive/items/root/children/ HTTP/1.1
Host: api.onedrive.com
Authorization: bearer Ew....
Accept-Encoding: gzip, deflate
Content-Type: multipart/related; boundary="EE5D5990-AD9A-4EA7-A4CD-0D62E10AB969"
Content-Length: 8133957
Accept-Language: en-us
Accept: */*
Connection: keep-alive
Proxy-Connection: keep-alive
User-Agent: Scanbot/113 CFNetwork/711.3.18 Darwin/14.0.0

--EE5D5990-AD9A-4EA7-A4CD-0D62E10AB969
Content-ID: <metadata>
Content-Type: application/json
Content-Disposition: form-data; name="metadata"

{"@content.sourceUrl":"cid:content","file":{},"name":"Filename.pdf","@name.conflictBehavior":"rename"}
--EE5D5990-AD9A-4EA7-A4CD-0D62E10AB969
Content-ID: <content>
Content-Type: application/octet-stream
Content-Disposition: form-data; name="content"

PDF_CONTENT

--EE5D5990-AD9A-4EA7-A4CD-0D62E10AB969--

Response:
HTTP/1.1 400 Bad Request
Via: 1.1 BL3301____PAP060 (wls-colorado)
Content-Length: 93
Content-Type: application/json
Content-Encoding: gzip
Server: Microsoft-HTTPAPI/2.0 Microsoft-HTTPAPI/2.0
X-WLSPROXY: BL3301____PAP060
Strict-Transport-Security: max-age=31536000; includeSubDomains
Strict-Transport-Security: max-age=31536000; includeSubDomains
X-MSNSERVER: BL3302____PAP107
X-QosStats: {"ApiId":0,"ResultType":2,"SourcePropertyId":0,"TargetPropertyId":42}
X-ThrowSite: 1479.b891
X-AsmVersion: UNKNOWN; <IP_ADDRESS>
P3P: CP="BUS CUR CONo FIN IVDo ONL OUR PHY SAMo TELo"
Date: Tue, 05 May 2015 13:20:07 GMT

{"error":{"code":"invalidArgument","message":"Bad Argument","innererror":{"code":"badArgument","innererror":{"code":"badRequest"}}}}

The PDF file and the full request.
Although documentation states that multipart upload supports requests up to 100MB, I can't upload file bigger than 5 MB. Any ideas what could be wrong here?

@Constantine-Fry, thank you for the detailed repro! I've confirmed it's a bug on our side and we'll work on getting it fixed straight away.

Thanks

This should be resolved now, please let us know if you still see issues.

Seems to work. Thank you!


Browser time handling is wonky. Time delta will be huge and reward 1000s of score.

To repeat this bug leave the game running overnight and open it again, Occasionally the browser will wake your tab just to check in.
Sometimes this cause the parallax-jump's internal timer to award the player with many points.
See attatched.

Nice one.
Instead of fixing this, I decided to redesign the scoring mechanic, so this bug is obsolete.
See: https://github.com/soryy708/parallax-jump/commit/045f8d41258f60aa1b2db6cb1765f84eb3a2d607


Fix Consumer ClassLoader Change

What is the purpose of the change
Fix https://github.com/apache/dubbo/issues/11168
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #11179 (7b6b704) into 3.1 (e7146d7) will decrease coverage by 4.82%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.1   #11179      +/-   ##
============================================
- Coverage     69.46%   64.63%   -4.83%
+ Complexity      127       14     -113
============================================
  Files          1496     1422      -74
  Lines         78820    59311   -19509
  Branches      13842     8720    -5122
============================================
- Hits          54752    38336   -16416
+ Misses        19344    16937    -2407
+ Partials       4724     4038     -686

Impacted Files
Coverage Δ

...ster/filter/support/ConsumerClassLoaderFilter.java
100.00% <100.00%> (ø)

...luster/router/script/ScriptStateRouterFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...he/dubbo/test/common/impl/GreetingServiceImpl.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...zookeeper/curator/CuratorZookeeperTransporter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...nfigure/DubboRelaxedBinding2AutoConfiguration.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/dubbo/test/spring/SpringXmlConfigTest.java
0.00% <0.00%> (-96.16%)
:arrow_down:

...egistrycenter/context/ZookeeperWindowsContext.java
0.00% <0.00%> (-81.82%)
:arrow_down:

...istrycenter/processor/FindPidWindowsProcessor.java
5.40% <0.00%> (-81.09%)
:arrow_down:

...pc/cluster/router/file/FileStateRouterFactory.java
0.00% <0.00%> (-80.96%)
:arrow_down:

...ycenter/processor/KillProcessWindowsProcessor.java
10.00% <0.00%> (-80.00%)
:arrow_down:

... and 487 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Tests fail on fresh checkout because of PhantomJS (OSX)

After a fresh checkout and npm install on the repo I can't seem to be able to run the tests for the project. Here's what I did:
➜  react-redux-starter-kit git:(master) git st
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working directory clean
➜  react-redux-starter-kit git:(master) npm test
><EMAIL_ADDRESS>test /Users/ciminian/code/acme/src/react-redux-starter-kit
> better-npm-run test

running better-npm-run in /Users/ciminian/code/acme/src/react-redux-starter-kit
Executing script: test

to be executed: babel-node ./node_modules/karma/bin/karma start build/karma.conf
  app:config Create configuration. +0ms
  app:config Apply environment overrides for NODE_ENV "test". +2ms
  app:config No configuration overrides found for NODE_ENV "test" +1ms
  app:webpack:config Create configuration. +1s
  app:webpack:config Apply ExtractTextPlugin to CSS loaders. +6ms
  app:karma Create configuration. +1ms

[...]

ERROR in ./~/enzyme/build/react-compat.js
Module not found: Error: Cannot resolve module 'react/addons' in /Users/ciminian/code/acme/src/react-redux-starter-kit/node_modules/enzyme/build
 @ ./~/enzyme/build/react-compat.js 37:16-39
Child html-webpack-plugin for "index.html":
         Asset    Size  Chunks       Chunk Names
    index.html  520 kB       0
    chunk    {0} index.html 503 kB
        [0] ./~/html-webpack-plugin/lib/loader.js!./src/index.html 759 bytes {0} [built]
        [1] ./~/html-webpack-plugin/~/lodash/lodash.js 502 kB {0} [built]
        [2] (webpack)/buildin/module.js 251 bytes {0} [built]
Child extract-text-webpack-plugin:
    chunk    {0} extract-text-webpack-plugin-output-filename 2.54 kB [rendered]
        [0] ./~/css-loader?sourceMap&-minimize&modules&importLoaders=1&localIdentName=[name]__[local]___[hash:base64:5]!./~/postcss-loader!./~/sass-loader?sourceMap!./src/views/HomeView/HomeView.scss 1.03 kB {0} [built]
        [1] ./~/css-loader/lib/css-base.js 1.51 kB {0} [built]
Child extract-text-webpack-plugin:
    chunk    {0} extract-text-webpack-plugin-output-filename 22.1 kB [rendered]
        [0] ./~/css-loader?sourceMap&-minimize&modules&importLoaders=1&localIdentName=[name]__[local]___[hash:base64:5]!./~/postcss-loader!./~/sass-loader?sourceMap!./src/styles/core.scss 20.6 kB {0} [built]
        [1] ./~/css-loader/lib/css-base.js 1.51 kB {0} [built]
11 04 2016 19:33:26.780:INFO [karma]: Karma v0.13.22 server started at http://localhost:9876/
11 04 2016 19:33:26.795:INFO [launcher]: Starting browser PhantomJS
11 04 2016 19:33:28.230:INFO [PhantomJS 1.9.8 (Mac OS X 0.0.0)]: Connected on socket /#Rl_kDnqON28XgtRhAAAA with id 48381918
PhantomJS 1.9.8 (Mac OS X 0.0.0) ERROR
  SyntaxError: Parse error
  at /Users/ciminian/code/acme/src/react-redux-starter-kit/tests/test-bundler.js:55 <- webpack:///tests/test-bundler.js:6:0

Finished in 0.197 secs / 0 secs

SUMMARY:
✔ 0 tests completed
npm ERR! Test failed.  See above for more details.

I don't really know what's wrong here, as I'm fairly noob-ish to the stack. Any help is appreciated.
Thanks for this project - it's was really helpful for me to get started with react/redux!

Here are some more details from my environment:
➜  react-redux-starter-kit git:(master) node -v
v4.2.2
➜  react-redux-starter-kit git:(master) npm -v
3.3.6
➜  react-redux-starter-kit git:(master) phantomjs -v
1.9.8

➜  react-redux-starter-kit git:(master) which phantomJS
/usr/local/bin/phantomJS
➜  react-redux-starter-kit git:(master) ls -l /usr/local/bin/PhantomJS
/usr/local/bin/PhantomJS -> ../lib/node_modules/phantomjs/bin/phantomjs
➜  react-redux-starter-kit git:(master) npm uninstall -g phantomjs
[SUCCESS]
➜  react-redux-starter-kit git:(master) ✗ which PhantomJS
PhantomJS not found

I saw that the recommended method of installation on the PhantomJS website was downloading a binary so I removed my global module. The tests still run (using PhantomJS 2.1.1 now, don't know where that's coming from as there doesn't seem to be anything related in the project dependencies) and they still fail with the same error.

Ok, I've just entered the cornfields. My project runs its tests, but only if I change karma.conf.js:
➜  react-redux-starter-kit git:(master) npm test

><EMAIL_ADDRESS>test /Users/ciminian/code/profiler-website/src/react-redux-starter-kit
> better-npm-run test

running better-npm-run in /Users/ciminian/code/profiler-website/src/react-redux-starter-kit
Executing script: test

to be executed: babel-node ./node_modules/karma/bin/karma start build/karma.conf
  app:config Create configuration. +0ms
  app:config Apply environment overrides for NODE_ENV "test". +1ms
  app:config No configuration overrides found for NODE_ENV "test" +2ms
  app:webpack:config Create configuration. +778ms
  app:webpack:config Apply ExtractTextPlugin to CSS loaders. +6ms
  app:karma Create configuration. +1ms

START:
11 04 2016 21:09:20.578:INFO [karma]: Karma v0.13.22 server started at http://localhost:9876/
11 04 2016 21:09:20.588:INFO [launcher]: Starting browser PhantomJS
11 04 2016 21:09:21.437:INFO [PhantomJS 2.1.1 (Mac OS X 0.0.0)]: Connected on socket /#-MQM4skImTvc2mnAAAAA with id 72105283
PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
  SyntaxError: Expected token ']'
  at /Users/ciminian/code/profiler-website/src/react-redux-starter-kit/tests/test-bundler.js:55 <- webpack:///tests/test-bundler.js:6:0

Finished in 0.487 secs / 0 secs

SUMMARY:
✔ 0 tests completed
npm ERR! Test failed.  See above for more details.

# changes to karma.conf.js
➜  react-redux-starter-kit git:(master) git df
diff --git a/build/karma.conf.js b/build/karma.conf.js
index a66d504..b8733fc 100644
--- a/build/karma.conf.js
+++ b/build/karma.conf.js
@@ -64,7 +64,7 @@ const karmaConfig = {
 if (config.coverage_enabled) {
   karmaConfig.reporters.push('coverage')
   karmaConfig.webpack.module.preLoaders = [{
-    test: /\.(js|jsx)$/,
+    test: /it_does_not_care_what_I_put_here\.(js|jsx)$/,
     include: new RegExp(config.dir_client),
     loader: 'isparta',
     exclude: /node_modules/
➜  react-redux-starter-kit git:(master) ✗ npm test
[...]
SUMMARY:
✔ 29 tests completed

=============================== Coverage summary ===============================
Statements   : 100% ( 0/0 )
Branches     : 100% ( 0/0 )
Functions    : 100% ( 0/0 )
Lines        : 100% ( 0/0 )
================================================================================

It doesn't seem to care what I change it to and it runs all tests, it just doesn't want the default the project comes with. This does not fix the vanilla project, that still times out.
Coverage is wrong, but if I change tests they break so it's running them. Really weird.

Sorry, but this fix doesn't solve the actual issue.
The react/addons error was annoying, but it's not what causes the tests to break. I think the problem is somewhere between karma and PhantomJS.
➜  react-redux-starter-kit git:(master) git ll
* e502f4d (13 hours ago) Justin Greenberg  (HEAD, origin/master, origin/HEAD, master)fix(webpack/karma): add react/addons to externals
* 9bee6b9 (2 days ago) David Zukowski docs(readme): fix outdated referenced to production webpack config
* dbebfaf (2 days ago) David Zukowski docs(readme): add Thank You section
[...]

➜  react-redux-starter-kit git:(master) git st
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working directory clean

➜  react-redux-starter-kit git:(master) npm test

><EMAIL_ADDRESS>test /Users/ciminian/code/acme/src/react-redux-starter-kit
> better-npm-run test

running better-npm-run in /Users/ciminian/code/acme/src/react-redux-starter-kit
Executing script: test

to be executed: babel-node ./node_modules/karma/bin/karma start build/karma.conf
  app:config Create configuration. +0ms
  app:config Apply environment overrides for NODE_ENV "test". +3ms
  app:config No configuration overrides found for NODE_ENV "test" +1ms
  app:webpack:config Create configuration. +704ms
  app:webpack:config Apply ExtractTextPlugin to CSS loaders. +5ms
  app:karma Create configuration. +1ms

START:
12 04 2016 11:01:00.763:INFO [karma]: Karma v0.13.22 server started at http://localhost:9876/
12 04 2016 11:01:00.775:INFO [launcher]: Starting browser PhantomJS
12 04 2016 11:02:00.781:WARN [launcher]: PhantomJS have not captured in 60000 ms, killing.
12 04 2016 11:02:02.789:WARN [launcher]: PhantomJS was not killed in 2000 ms, sending SIGKILL.
12 04 2016 11:02:04.796:WARN [launcher]: PhantomJS was not killed by SIGKILL in 2000 ms, continuing.

Finished in 0 secs / 0 secs

npm ERR! Test failed.  See above for more details.

As I mentioned above, I have a project started from last week's version of the starter kit that can run its tests only if I change karma.conf.js; the fresh checkout times out every time I try and run the tests.
Can anyone else reproduce or is my setup a unique snowflake?

Re-opening until we can figure out the cause. I personally haven't been able to reproduce yet, but I'll give it another go later tonight/tomorrow.

Can you enable debugging for Karma/PhantomJS and post the results? There are quite a few issues around StackOverflow/Github/etc. dealing with this, so I'm sure whatever oddities you have with your setup that are causing this have been figured out somewhere.

For karma:
➜  react-redux-starter-kit git:(master) ✗ git df
diff --git a/build/karma.conf.js b/build/karma.conf.js
index 5d4f268..5f4f562 100644
--- a/build/karma.conf.js
+++ b/build/karma.conf.js
@@ -73,4 +73,8 @@ if (config.coverage_enabled) {
 }

 // cannot use `export default` because of Karma.
-module.exports = (cfg) => cfg.set(karmaConfig)
+module.exports = (cfg) => {
+  cfg.set(karmaConfig)
+  cfg.logLevel = cfg.LOG_DEBUG
+  return cfg
+}

Output:
➜  react-redux-starter-kit git:(master) npm test

><EMAIL_ADDRESS>test /Users/ciminian/code/acme/src/react-redux-starter-kit
> better-npm-run test

running better-npm-run in /Users/ciminian/code/acme/src/react-redux-starter-kit
Executing script: test

to be executed: babel-node ./node_modules/karma/bin/karma start build/karma.conf
  app:config Create configuration. +0ms
  app:config Apply environment overrides for NODE_ENV "test". +2ms
  app:config No configuration overrides found for NODE_ENV "test" +1ms
  app:webpack:config Create configuration. +1s
  app:webpack:config Apply ExtractTextPlugin to CSS loaders. +6ms
  app:karma Create configuration. +5ms
13 04 2016 23:52:45.310:DEBUG [config]: autoWatch set to false, because of singleRun
13 04 2016 23:52:45.312:DEBUG [plugin]: Loading karma-* from /Users/ciminian/code/acme/src/react-redux-starter-kit/node_modules
13 04 2016 23:52:45.315:DEBUG [plugin]: Loading plugin /Users/ciminian/code/acme/src/react-redux-starter-kit/node_modules/karma-coverage.
13 04 2016 23:52:45.493:DEBUG [plugin]: Loading plugin /Users/ciminian/code/acme/src/react-redux-starter-kit/node_modules/karma-mocha.
13 04 2016 23:52:45.495:DEBUG [plugin]: Loading plugin /Users/ciminian/code/acme/src/react-redux-starter-kit/node_modules/karma-mocha-reporter.
13 04 2016 23:52:45.498:DEBUG [plugin]: Loading plugin /Users/ciminian/code/acme/src/react-redux-starter-kit/node_modules/karma-phantomjs-launcher.
13 04 2016 23:52:45.534:DEBUG [plugin]: Loading plugin /Users/ciminian/code/acme/src/react-redux-starter-kit/node_modules/karma-webpack-with-fast-source-maps.

START:
13 04 2016 23:52:51.417:INFO [karma]: Karma v0.13.22 server started at http://localhost:9876/
13 04 2016 23:52:51.425:INFO [launcher]: Starting browser PhantomJS
13 04 2016 23:52:51.426:DEBUG [temp-dir]: Creating temp dir at /var/folders/3x/s9pz758552d5dwg15gqxx6zhgq56vw/T/karma-5633752
13 04 2016 23:52:51.429:DEBUG [launcher]: /usr/local/lib/node_modules/phantomjs/lib/phantom/bin/phantomjs /var/folders/3x/s9pz758552d5dwg15gqxx6zhgq56vw/T/karma-5633752/capture.js
13 04 2016 23:53:51.429:WARN [launcher]: PhantomJS have not captured in 60000 ms, killing.
13 04 2016 23:53:53.435:WARN [launcher]: PhantomJS was not killed in 2000 ms, sending SIGKILL.
13 04 2016 23:53:55.441:WARN [launcher]: PhantomJS was not killed by SIGKILL in 2000 ms, continuing.
13 04 2016 23:53:55.441:DEBUG [launcher]: Process PhantomJS exited with code -1
13 04 2016 23:53:55.441:DEBUG [temp-dir]: Cleaning temp dir /var/folders/3x/s9pz758552d5dwg15gqxx6zhgq56vw/T/karma-5633752
13 04 2016 23:53:55.452:DEBUG [launcher]: PhantomJS failed (timeout). Not restarting.

Finished in 0 secs / 0 secs

13 04 2016 23:53:55.456:DEBUG [karma]: Run complete, exiting.
13 04 2016 23:53:55.456:DEBUG [launcher]: Disconnecting all browsers
npm ERR! Test failed.  See above for more details.

I can't figure out how to enable verbose/debug output for PhantomJS. The docs don't seem to have anything useful. Do you know of any other useful configs I can put in?

Just curious, have you managed to use PhantomJS successfully in any other project?

I haven't really done JS/front-end development for a while so I can't speak fully for 'other projects', but it seems to be working fine for me:
➜  tmp cat test.js
console.log('Hello, world!');
phantom.exit();
➜  tmp phantomjs test.js
Hello, world!

If you have a better test case happy to try it out.

I've encountered the same timeout issue.
I'am on windows 10 x64. Karma works on my another project with angular,so it's not the problem of <IP_ADDRESS> localhost.
And rm -r node_modules&&npm install also not works!So,It is strange aha?
I turned on the debug level in karma and I inspected my angular project's karma start process, it turns out that the "PHANTOMJS_BIN" was not correct set in the react-redux-starter-kit clean project ,and the primary reason of which is that the phantomjs-prebuilt installation has some errors that I ignored.And due to this thenode_modules\phantomjs-prebuilt\lib\phantom\phantomjs.exe file wasn't created!
So the solution is npm uninstall phantomjs-prebuilt and npm install phantomjs-prebuilt.
If no error prompt,phantomjs.exe file being created,you are good to go! npm would automatically find the exe file to start phantomjs.
PS.
It took me hours to figure what is wrong with this project,everything works just fine on my linux machine  including centos 6 and ubuntu14.04. And I would appreciate @cimi 's sample of turn on debug level which leads a correct direction for me to investigate this issue.

I worked around this by following @mzvast's instructions but I first had to delete a phantomjs binary I already had, so did
# To find the location of the old binary
which phantomjs
# Remove the old binary
sudo rm -f /usr/local/bin/phantomjs
npm uninstall phantomjs-prebuilt
# This will say it can't find phantomjs on the path and replace it with
# a shiney new version
npm install phantomjs-prebuilt

Closing as resolved. This seems like a system issue, so I will add an entry to the FAQ.

I encountered a problem on a colleague's machine with a new setup where the PhantomJS binary could not be found. My fix was to add PHANTOMJS_BIN to the test script definition in package.json:
    "test": {
      "command": "babel-node ./node_modules/karma/bin/karma start bin/karma",
      "env": {
        "NODE_ENV": "test",
        "DEBUG": "app:*",
        "PHANTOMJS_BIN": "./node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs"
      }
    }


mysql sink allocate a huge number of memory when build multi statement sql.

From the above image, we can see that the MySQL sink allocates a huge number of memory when trying to build the multi-statement SQL, this can be reduced by using a more efficient string concatenation method.

/label affects-6.5
/label affects-7.1
/label affects-7.5


[BugFix] Fix the crash caused by JniScanner

Why I'm doing:
A crash may occur when reading array, map<string,string> types from HiveJniScanner. Taking array as an example, the reasons are as follows:
In OffHeapColumnVector, array uses childColumns[0] to store data. For each row of array data, there are 0 to multiple rows of data corresponding to it in childColumns[0], and offsetData is used to record the Start and end positions of each row of array data in childColumns[0].
Initially, childColumns[0] has the same capacity as array. Assuming that each row of array data corresponds to multiple rows of data in childColumns[0], when appending data, childColumns[0] must be expanded first to accommodate all the data in the array.
ChildColumns[0] is an OffHeapColumnVector of String type. It directly creates a new OffHeapColumnVector when expanding, which means that the offset of the data added later will start from 0, but the offsetData of the array is still continuous. So there will be a situation where offsetData[n-1] > offsetData[n], as shown in the figure below, this will be a disaster, because offsetData will be passed to be, and be will follow offsetData[n] - offsetData[n - 1] Calculate the length of the string. The length of a negative number will be assigned to an unsigned number, so the construction of the string will go out of bounds, causing be crash.

What I'm doing:
When OffHeapColumnVector is expanding, check whether childColumns already exists. If it already exists, there is no need to reset it and just keep it, because the expansion will be done automatically in the appendValue function of childColumns.
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[x] 3.2
[x] 3.1
[x] 3.0
[x] 2.5

Can someone review it?

@dirtysalt @stephen-shelby Could you please review it?


UknownTopic Or Partition

Would it be possible to have this error report which topic/partition in the error?
proto/errors.go:	ErrUnknownTopicOrPartition = &KafkaError{3, "unknown topic or partition"}

Not without drawback. All standard errors are defined in https://github.com/optiopay/kafka/blob/master/proto/errors.go#L11 and because of this you can compare them. If I would build custom error with topic/partition information, there would be no chance to compare it.


Upgrade CodeQL v2.20.2 -> v2.20.3

This PR contains the following updates:

Package
Type
Update
Change

github/codeql-action
action
patch
v2.20.2 -> v2.20.3

Release Notes

github/codeql-action
v2.20.3
Compare Source

[ ] If you want to rebase/retry this PR, check this box

Warning
Renovate's suggested commit message is being replaced with improved initial commits to enable automerging. As a side effect, these suggested commit messages might have changed. Consider comparing the initial commit message and this message to determine the most suitable one. Please leave feedback in #sys-renovate.

Suggested commit message:
Upgrade CodeQL v2.20.2 -> v2.20.3

See:
- https://github.com/github/codeql-action/blob/main/CHANGELOG.md
- https://github.com/github/codeql-action/compare/v2.20.2...v2.20.3

Yeah I think every two weeks is a good start, maybe even less indeed. Let's wait for a bit more to see the cadence 😄.


Mac version?

This isn't a bug report but a question. If here's a better place to post it, please let me know.
Your fontbm tool looks great. The rectangle packing is particularly impressive. We use BMFonts in the Moddable SDK to render anti-aliased text on a variety of microcontrollers. Our graphics documentation provides details about the  features we use.
To generate BMFonts we usually use Glyph Designer, which is excellent but only available for macOS. We would like to have a single tool that works  on all our development environments - macOS, Windows, and Linux. That way we can provide developers with consistent instructions and build integration no matter what  platform they develop on.
One member of our community has already been successful using fontbmwith the Moddable SDK on Windows.
So... I wanted to ask if you had plans to support macOS at some point down the road.
Thank you!

Hi! Sorry for the late reply =)
Afaik, cmake . / make should be enough for macOS build, at least Travis builds it right (https://travis-ci.org/github/vladimirgamalyan/fontbm/jobs/759773086). Unfortunately I don't have access to macOS to check it by myself, but I believe that there are great chances that everything will be ok :santa:.

Hey, @vladimirgamalyan  - thanks for the reply. @andycarle independently found that what you propose works well on macOS! Very cool. Maybe you can update your build instructions to note that the Linux instructions work for macOS as well.
We are looking at ways we can integrate your fontbm tool into our Moddable SDK build system to automatically generate bitmap fonts at the sizes needed by the project.


tags doesn't match

The behaviour with tags is strange.
For example:
With the following code
    steps:
      - name: checkout code
        uses: actions/checkout@v2

      - name: Version match
        uses: actions-ecosystem/action-regex-match@v2
        id: version-match
        with:
          text: ${GITHUB_REF#refs/tags/}
          regex: '^(.*)'

With the tag '1.2.3', it matches '1.2.3'
But with the following code
    steps:
      - name: checkout code
        uses: actions/checkout@v2

      - name: Version match
        uses: actions-ecosystem/action-regex-match@v2
        id: version-match
        with:
          text: ${GITHUB_REF#refs/tags/}
          regex: '^([0-9]*)'

Still with a same tag, it matches ''
And finally with the following code
    steps:
      - name: checkout code
        uses: actions/checkout@v2

      - name: Version match
        uses: actions-ecosystem/action-regex-match@v2
        id: version-match
        with:
          text: '1.2.3'
          regex: '^([0-9]*)'

It matches '1'
Any idea why?

There's no dots in ^([0-9]*) but 1.2.3 got dots.

that's it, I feel so ...
Thanks a lot


Find out why Issues are not being closed with PRs

For New Contributors
How to contribute
Description

Currently Github is not closing issues with PRs. I.E #444
#443 had to be closed manually and we want this to be automated.
Find the reason for this and fix if possible.
Add cause to the comments below.
Intended Design

N/A
Location

N/A
Related Issues

N/A
Requirements

N/A
Additional information

N/A
Definition of Done

[ ] Comment describing problem.

This is due to the PR's not being on the default branch, odd from Github's side..


feat(import): disallow relative parent imports and enforce sort order

BREAKING CHANGE: Relative parent imports ('../') are no longer allowed, and imports must be sorted. Module-relative imports must be grouped first, followed by sibling relative imports. Both groups must be sorted alphabetically. Both of
these rules can be automatically enforced with the fiximports transform in opensphere-jscodeshift.
This also allows import statements to exceed the 120 character line limit, so long paths don't cause problems.

:tada: This PR is included in version 6.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Serve pyramid on pypi

We need to streamline the installation,  so naturally the move to serving pyramid on pypi makes sense to reduce the need for assumptions in the installation process about the underlying environment.
Conceivably this could be served as a single wheel as h2o does with multiple versions of python, operating systems, and architectures supported or possibly as series of wheels as numpy, scikit-learn or pandas does with separate OS versions, python versions, and architectures getting their own wheels.
Not sure what the most elegant solution is. Maybe trying to serve the following 6 major wheels makes the most sense:

os: MAC 64-bit architecture

[in pypitest] python: 2.7
[in pypitest] python: 3.5
[in pypitest] python: 2.6

os: Linux 64-bit architecture

python: 2.7
python: 3.5
python: 2.6

<OS> <os_version> using Python <major_version>.<minor_version>

[ ] 1.) serve the package on the pypi test server, then:
[ ] 2.) test install from pypi test server

[ ] a. with requirements already installed:

[ ] anaconda
[ ] virtualenv

[ ] b. with requirements not already installed:

[ ] anaconda
[ ] virtualenv

[ ] c. with conflicting versions:

[ ] anaconda
[ ] virtualenv

[ ] 3.) serve the package publicly

There are classifieres within setup.py that are invalid. You will have to restrict yourself to the following valid ones:
https://pypi.python.org/pypi?:action=browse
The invalid ones are:

Intended Audience :: Scikit-learn users
Intended Audience :: R users
Topic :: Machine Learning

Create a ~/.pypirc

# These are the contents of the ~/.pypirc

[distutils]
index-servers =
  pypi
  pypitest

# Need to set this up still
[pypi]
repository=https://pypi.python.org/pypi
username=<NEED TO CREATE>
password=<NEED TO CREATE>

[pypitest]
repository=https://test.pypi.org/legacy/
username=<ASK ME FOR IT>
password=<ASK ME FOR IT>

To upload to pypi test server, for each environment run (from the base directory):

pip install -r requirements.txt
pip install twine
rm -rf dist/
python setup.py bdist_wheel
twine upload dist/* -r pypitest

To upload to pypi "production" server, for each environment run the same commands except replace pypitest with pypi.

In order to test across multiple OSs (linux and MAC) we would need to either have a linux box or setup some VMs to run in different environments with similar virtual environments in them in addition to our macs. This would allow us to build the wheels across OSs. I think for now we would only need to create Linux and Mac:
MAC INSTALLATIONS :
PYTHON 2.7
(pyramid) Charless-MBP:pyramid_fork charlesdrotar$ pip install -i https://testpypi.python.org/pypi py-arima
Collecting py-arima
  Downloading https://testpypi.python.org/packages/ab/b0/eae37fed0f7b9bcdcfebdd1a373fccc0e492c40bf203c73cc6163838c24b/py_arima-0.5.dev0-cp27-cp27m-macosx_10_7_x86_64.whl (128kB)
    100% |████████████████████████████████| 133kB 83kB/s
Installing collected packages: py-arima
Successfully installed py-arima-0.5.dev0

PYTHON 3.5
(pyramid_35) Charless-MBP:pyramid_fork charlesdrotar$ pip install -i https://testpypi.python.org/pypi py-arima
Collecting py-arima
  Downloading https://testpypi.python.org/packages/0b/3d/6910b62f31ac9cd4ec683573e62cb2e721bef43cc1107a412963e9245b5e/py_arima-0.5.dev0-cp35-cp35m-macosx_10_7_x86_64.whl (121kB)
    100% |████████████████████████████████| 122kB 1.1MB/s
Installing collected packages: py-arima
Successfully installed py-arima-0.5.dev0

PYTHON 3.6
(pyramid_36) Charless-MBP:pyramid_fork charlesdrotar$ pip install -i https://testpypi.python.org/pypi py-arima
Collecting py-arima
  Downloading https://testpypi.python.org/packages/37/4c/81b9b39dfebe7fb18c3c5ed74769a43a0bdfd44401b9ddfeb4a5786f1eea/py_arima-0.5.dev0-cp36-cp36m-macosx_10_7_x86_64.whl (121kB)
    100% |████████████████████████████████| 122kB 64kB/s
Installing collected packages: py-arima
Successfully installed py-arima-0.5.dev0

One major consideration is that if you screw up in uploading a wheel and you don't like what is in there and you need to release another one - ❗YOU CAN NOT USE THE SAME VERSION NUMBER❗

Would you suggest, then, that we decrement minimum numpy version to 1.9.3?
Let's keep cython around in requirements.txt unless:
Does bdist_wheel build the project and push the compiled .so files as well? Or will there be un-built C code on the other end of the pypi installation?

Ultimately, we need some script that manages build (sphinx and C), tag & release from master. But that will be the final stage in this whole saga.

@tgsmith61591 in response to your numbered questions:

Honestly that is an executive decision based on what your package requires. What happens is that the pypi server finds packages within itself that satisfy the baseline requirements you set forth in install_requires. Given that this is most likely just a factor of the test server only having that version I would do what you think makes the most sense since when the .whl is deployed to the production server it will have all versions of numpy that are collocated there available.
(.. and 3) I will have to do a little sleuthing to validate that part.

On aforementioned points 2 and 3 we should be including Cython and numpy to ensure that building of code goes off without a hitch.

To address your earlier remark, the following wheels should be built:

os: MAC 64-bit architecture

[in pypitest] python: 2.7
[in pypitest] python: 3.5
[in pypitest] python: 2.6

os: Linux 64-bit architecture

python: 2.7
python: 3.5
python: 2.6
python: 3.5
python: 2.6

Done and tested in 52f2f70a9b05fcbbc314d5db7bf488a1f88edfce. Can be installed via pip like so:
$ pip install pyramid-arima


Install setuptools and wheel to cache locally built wheels

Summary
This commit updates the ci configuration to ensure that we have wheel
(and setuptools) installed and at the latest version. Right now in the
azure jobs we cache dependencies but it's not caching locally
constructed wheels from installation. This means the effect of the cache
is minimized to just the wire time to download artifacts from pypi, To
improve the effect of the cache this installs the necessary requirements
to enable pip to build wheels locally when an sdist package is used.
When that happens it will start caching the wheels and saving us from
building from source on every run.
Details and comments

The ci logs show this working. It's building wheels locally now. When this merges the cache should update and pull in the built wheels which will save us the time to build the packages on future runs.
https://dev.azure.com/qiskit-ci/qiskit-terra/_build/results?buildId=12918&view=logs&j=8eacdd59-c2e8-5617-75a5-8ed7c854a78f&t=7bbed03d-5570-5fd0-a182-d30928a799d9&l=289


Provide automated canary deployment and analysis support when applying changes to running kafka cluster

We are using netflix kayenta as service to automatically analyze canary deployments
When making changes to running kafka cluster we want to avoid downtime if changes are breaking cluster

https://www.infoq.com/presentations/canary-analysis-deployment-pattern/
https://github.com/spinnaker/kayenta
https://www.youtube.com/watch?v=3xQm7CsR0ww

So, MVP here - when applying changes operator should support canary deployment and we should have ability to programmatically continue or rollback deployment via deployment pipeline based on data from canary analysis which pipeline will fetch from kayenta

https://github.com/helm/helm/issues/6572
https://github.com/aerospike/aerospike-kubernetes-operator/issues/14
https://github.com/elastic/cloud-on-k8s/issues/3479#issuecomment-686588054

This issue is stale for a while, closing this, but PR's are always welcome.


⚠ Bofrost.fr has degraded performance

In 08bba45, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 881 ms

Resolved: Bofrost.fr performance has improved in 862312a after 6 minutes.


test: initial setup

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Unable to change the styling of the time picker popup🐛

Describe the bug
I am unable to change the style of the Time Picker popup. It has a white background with blue buttons, but I can't inspect or debug it because it disappears automatically.
To Reproduce
Steps to reproduce the behavior:

Enable showTimePicker param
Click on the time icon
A selector for time will appear
There is no way of changing the color

Expected behavior
A css variable could be exposed to change the styles
Screenshots

Desktop:

OS: OSX 14.4
Browser Arc
Version 1.34.0 (47465)
Chromium Engine Version 122.0.6261.129

Hey @Dave-lab12, thanks for submitting a ticket! This is actually a feature request since I used the browser's native time picker. I planned to write my version for this component; I just haven't had time to work on it yet.

I completely missed that. My apologies! 🤦♂


Demo not working

Demo doesn't seem to work. Followed instructions on readme but to no luck :(
Thing I noticed was QR doesn't show up on demo

Fixed, there was a missing index.php file under /api/ and a missing fonts folder.

The demo is fixed, give it another download.
On Fri, Jan 8, 2016 at 7:54 PM, plasmoske<EMAIL_ADDRESS>wrote:

Demo doesn't seem to work Followed instructions on readme but to no luck :(
Thing I noticed was QR doesn't show up on demo
—
Reply to this email directly or view it on GitHub
https://github.com/mohrt/oneblock-server-php/issues/1.

Thanks man. Will give it another go later later today.
:-)


Added preliminary code for graph-based clustering.

          var output = allocate_int32_vector(ncol);
          Module.cluster_snn_graph(nrow, ncol, mat.offset, 2, 0.5, output.offset);
          console.log(output.vector);

@jkanche check that this even compiles on your machine before merge. Was v. tricky to get it to work.


Add option to disable test binaries ZLIB_ENABLE_TESTS

Obviously useful feature when cross-compiling...

Looks good, but holding off on this until renamelib has been merged


added avneesh0612

I have added my profile :D

Oh okay

I forgot the command 🤦♂🤦♂

Reverted it @krishguptadev

Done @krishguptadev

Awesome! Thanks :D

Oh okay


Finish draw laser and draw mirror methods

Laser is done but can be improved.

Are there any benefits to using context.rect() instead of HTML5 Canvas Lines?
I'm guessing lines are better for performance due to having less properties and less to render for the browser; also shorter code.

Oh, you mean very thick lines? That makes sense. Maybe we should switch to that. Do mirrors look better curved? Do you mean a circular mirror? At this point, the artistic side is more flexible.

Yup, thick lines. I think straight-line mirrors would best since calculating the laser reflection angle would be easier as opposed to with a concave or convex mirror.

Great, agreed then. I'll work on the laser for now.

Laser class is done. Mirror class In Progress


Better Debug coverage, smaller binary size

add debug symbols to test builds
keep libwabt debug symbols are being included on release builds.

:shipit:

@Cellule @digitalinfinity Thanks for the review!


Set process.server and process.client in nuxt.config.js

What problem does this feature solve?
Right now, to support different configuration values for server and client contexts, entries in nuxt.config.js must expose options that are specific to the server or client. For example, in the @nuxtjs/axios module:
export default {
  modules: [
    "@nuxtjs/axios",
  ],
  axios: {
    baseURL: "http://localhost:8000/",
    browserBaseURL: "/",
  },
};

Unfortunately, not all configuration options are designed this way, so there's often no good mechanism for providing a different configuration value on the server and on the client.
An example is described in this issue for the @nuxtjs/apollo module. The Apollo module only exposes a single httpEndpoint option, which means you can't provide a different value for the server and the client. This module assumes the GraphQL server is running on a different URL, making impossible to run GraphQL on the same server as Nuxt by setting the httpEndpoint to http://localhost:8000/graphql on the server and just /graphql on the client.
What does the proposed changes look like?
By setting process.server = true when generating the server config and process.client = true when generating the client config, these issues go away, and they also might simplify Nuxt module implementations because they don't need to internally handle different config options:
export default {
  modules: [
    "@nuxtjs/apollo",
  ],
  apollo: {
    clientConfigs: {
      default: {
        httpEndpoint:
          process.server ? "http://localhost:8000/graphql" : "/graphql",
      },
    },
  },
};

This feature request is available on Nuxt community (#c9956)

I would love to have this feature

@pSnehanshu If you follow the discussion of nuxt-community/apollo-module#272, it is not really a solution. process.server and process.client are provided via webpack during build time but nuxt config is loaded with node.js require. It means if we want to do this, have to inject into process and require nuxt.config each time twice by clearing require cache.
For the apollo-module, the same as the axios module now there is a new browserHttpEndpoint option that allows easily can clearely separately provide different values.


Using a language code as a parameter when creating a form

Would it be possible to use a language code parameter when building a TranslatableModelForm, so that the resulting form will display and save the translated fields, maybe creating them if they don't exist?
Or is the expected workflow to use with switch_language(model, lang): MForm(instance=model)?

Looking at the code, I'm not sure what you mean. Are you referring to editing objects, or creating new objects?
Edited objects are always rendered in their active language, which makes sense to me. Overriding that happens on the model (e.g. model.set_current_language('..'))


Your code should not have any div tags.

Describe your problem and how to reproduce it:
I am on the applied accessibility section for responsive web design, and the instructions for this problem and the problem after ask me to change the div tags. I change it to article for the problem I have linked and I'm still getting the "Your code should not have any dig tags" even though the other requirement is having 3 article tags which I do. I am also sure I deleted all div tags.
Add a Link to the page with the problem:
https://www.freecodecamp.org/learn/responsive-web-design/applied-accessibility/wrap-content-in-the-article-element
Tell us about your browser and operating system:

Browser Name: Google Chrome
Browser Version: 87.0.4280.88
Operating System: Windows 10 Pro 2004 OS Build 19041.685

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):

@tyantrinh Please use our forum for debugging the code of your projects.  If the forum members determine there is nothing wrong with your code, you can request this issue to be reopened.  GitHub issues are meant for reporting bugs and not troubleshooting the code in the challenges and projects.
Thank you for understanding.


Change fail2ban state to be count of current bans

Description:
The list of IPs banned are not useful for automation, however the number of bans is more interesting from an historical data collection point of view.
The previous state value is available as the all_bans attribute.
The current state value is the number of currently active bans
The total attribute is the number of total bans seen
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):
No Config changes.
Checklist:

[X] The code change is tested and works locally.
[X ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[X] New dependencies have been added to the REQUIREMENTS variable (example).
[X] New dependencies are only imported inside functions that use them (example).
[X] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[X] New files were added to .coveragerc.

If the code does not interact with devices:

[X] Tests have been added to verify that the new code works.

This PR seems to have gone stale. Closing it.


Class generics forgotten when calling a method with .call or .apply.

TypeScript Version:
TypeScript playground
Code
class Foo<T> {
  myprop: T;
  method(): Foo<T> { return this; }
}

function f(x: Foo<number>) {
  var y: Foo<string>;
  y = x.method(); // correct warning here
  y = Foo.prototype.method.call(x); // missed warning here
}

Expected behavior:
When using .call or .apply on a method, the method type is turned to a function type whose first argument is the receiver object of the method. If the class of the receiver is generic, the type variables should be added to the function type.
Actual behavior:
The class generics become any (I assume), and the type error is not detected.

call and apply are not type safe generally.
function foo(x: string): number {
    return 1;
}

foo.call(4, 8, 2, 4, 5); // ok
foo.apply(4, [2]); // ok

Hey @dimvar, this looks like a duplicate of #212. We don't special case the behavior of any of those methods. Does Closure have a generalized declaration that could work for functions other than call, bind, and apply?

This is not rely a duplicate of #212; though you need #212 for this to behave as the OP suggests.
The issue here is the prototype of a generic class is an instantiation with type any.  so Foo.prototype is Foo<any>.

The issue here is the prototype of a generic class is an instantiation with type any. so Foo.prototype is Foo.

Exactly. I was fixing this in the Closure type checker and ran into a similar issue.

This issue seems to have been already addressed or is unactionable at the moment. I am auto-closing it for now.

Are you referring to the command-line TypeScript compiler? I just checked and the issue still happens when using the playground.

this issue is not fixed, it is a design limitation that we have always had in the system. the message above is my auto-close script.


stateless app definition

Describe your changes
Related issue number or link (ex: resolves #issue-number)
Checklist before opening this PR (put x in the checkboxes)

[ ] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[ ] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@iamNoah1 @CathPag I have fixed the signed off issue here. I had to create this new pull request because for some unknown issues, the signed off didn't update here, only locally.

@FavourDaniel I know it has been some back and forth with this. My question is, are you still interested in finishing this one up?


DriverFramework: update to latest master

Note that this update will require a git submodule sync inside
src/lib/DriverFramework.
I've quickly (but not extensively) bench tested this on Snappy.
FYI @ChristophTobler.

@ChristophTobler please cross-test

@julianoes Thanks. Seems to work with the snapdragon. Can you please add https://github.com/PX4/DriverFramework/pull/194 before merging?

snapdragon flight
http://logs.uaventure.com/view/t2JZQLVe7U5z8z6Rx4qjAn
held okay in stabilize, changed to altitude mode; held altitude well for a few seconds then descended
rapidly with throttle still centered

@ChristophTobler @mcharleb  I tried to rebase this / get it in but the current head of DriverFramework points to a non-existent dspal commit.

@LorenzMeier have you tried git submodule syn inside DriverFramework?

 I thought it would complain about non-existent remote, but it just complains about non-existent ref (or I was blind).
Thanks!
Replacement PR: https://github.com/PX4/Firmware/pull/7011


Ability to style ion-items' detail arrow/icon and lines

Describe the Feature Request
The detail arrow and lines are no easily configurable. My primary issue is if the ion-item is medium is color, those elements 'vanish'.
Describe Preferred Solution
The ability to set the color of these items to provide enough contrast to be visible

@chrisgriffith I just merged some documentation of item's custom properties. I think you'll be interested in --detail-icon-color and --border-color :smile: Those docs will get pulled into the official docs in the next release.

I saw. :)
Cg
On Thu, Sep 20, 2018 at 10:08 AM Cam Wiegert<EMAIL_ADDRESS>wrote:

@chrisgriffith https://github.com/chrisgriffith I just merged some
documentation of item's custom properties. I think you'll be interested in
--detail-icon-color and --border-color 😄 Those docs will get pulled into
the official docs in the next release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ionic-team/ionic/issues/15648#issuecomment-423260023,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgOA_H_W9ol7DHnBtm7jf8SSBLlBZkpks5uc8umgaJpZM4WuYah
.


Fix flaky HttpClientMaxConcurrentStreamTest

received reports for the following flaky test when building with gradle --parallel clean build from local
current CI also uses --parallel option and hasn't failed yet, but should investigate why this happened.
exceededMaxStreamsPropagatesFailureCorrectly()
java.lang.AssertionError:
Expected size:<19> but was:<17> in:
<[{connectionAcquisitionStartTime=2020-02-18T03:26:01.585Z(1581996361585486), connectionAcquisitionDuration=11739µs(11739459ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.585Z(1581996361585493), pendingAcquisitionDuration=11727µs(11727314ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.585Z(1581996361585434), connectionAcquisitionDuration=15207µs(15207833ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.585Z(1581996361585440), pendingAcquisitionDuration=15193µs(15193502ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.578Z(1581996361578827), connectionAcquisitionDuration=35863µs(35863344ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.578Z(1581996361578846), pendingAcquisitionDuration=35838µs(35838911ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.578Z(1581996361578926), connectionAcquisitionDuration=38834µs(38834375ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.578Z(1581996361578936), pendingAcquisitionDuration=38307µs(38307104ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.585Z(1581996361585377), connectionAcquisitionDuration=35240µs(35240807ns), socketConnectStartTime=2020-02-18T03:26:01.603Z(1581996361603879), socketConnectDuration=10753µs(10753924ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.585Z(1581996361585384), pendingAcquisitionDuration=18484µs(18484850ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.585Z(1581996361585307), connectionAcquisitionDuration=42649µs(42649641ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.585Z(1581996361585318), pendingAcquisitionDuration=42634µs(42634408ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.585Z(1581996361585134), connectionAcquisitionDuration=43189µs(43189768ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.585Z(1581996361585161), pendingAcquisitionDuration=43160µs(43160134ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.578Z(1581996361578986), connectionAcquisitionDuration=49793µs(49793084ns), socketConnectStartTime=2020-02-18T03:26:01.619Z(1581996361619083), socketConnectDuration=8840µs(8840534ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.578Z(1581996361578993), pendingAcquisitionDuration=40080µs(40080529ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.579Z(1581996361579038), connectionAcquisitionDuration=59512µs(59512222ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.579Z(1581996361579045), pendingAcquisitionDuration=59500µs(59500543ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.579Z(1581996361579092), connectionAcquisitionDuration=62243µs(62243243ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.579Z(1581996361579099), pendingAcquisitionDuration=62226µs(62226715ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.582Z(1581996361582719), connectionAcquisitionDuration=60362µs(60362363ns), socketConnectStartTime=2020-02-18T03:26:01.628Z(1581996361628544), socketConnectDuration=8991µs(8991803ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.582Z(1581996361582726), pendingAcquisitionDuration=45812µs(45812614ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.582Z(1581996361582658), connectionAcquisitionDuration=66369µs(66369322ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.582Z(1581996361582668), pendingAcquisitionDuration=66355µs(66355084ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.582Z(1581996361582552), connectionAcquisitionDuration=66976µs(66976377ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.582Z(1581996361582570), pendingAcquisitionDuration=66954µs(66954147ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.579Z(1581996361579145), connectionAcquisitionDuration=72877µs(72877287ns), socketConnectStartTime=2020-02-18T03:26:01.642Z(1581996361642837), socketConnectDuration=6151µs(6151724ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.579Z(1581996361579152), pendingAcquisitionDuration=63675µs(63675433ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.579Z(1581996361579195), connectionAcquisitionDuration=78081µs(78081725ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.579Z(1581996361579202), pendingAcquisitionDuration=78070µs(78070274ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.579Z(1581996361579243), connectionAcquisitionDuration=78783µs(78783028ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.579Z(1581996361579250), pendingAcquisitionDuration=78771µs(78771213ns)},
    {connectionAcquisitionStartTime=2020-02-18T03:26:01.580Z(1581996361580323), connectionAcquisitionDuration=78745µs(78745771ns), socketConnectStartTime=2020-02-18T03:26:01.651Z(1581996361651400), socketConnectDuration=5531µs(5531173ns), pendingAcquisitionStartTime=2020-02-18T03:26:01.581Z(1581996361581915), pendingAcquisitionDuration=69473µs(69473803ns)}]>
	at com.linecorp.armeria.client.HttpClientMaxConcurrentStreamTest.exceededMaxStreamsPropagatesFailureCorrectly(HttpClientMaxConcurrentStreamTest.java:261)

Taking a more white-box approach since I was unable to reproduce after 5 tries
The only way Expected size:<19> but was:<17> can happen is if a pendingAcquisition connection has failed. (basically an initial connection to the local server has failed)
This isn't a problem only for this test, but for most tests in HttpClientMaxConcurrentStreamTest
A quick solution would be to decrease expectedNumConnections and add logging so we can investigate why connection failure happens in the future

https://ci.appveyor.com/project/line/armeria/builds/30995349/job/4mr85tgdaeieuab1
Happened again.   Let me upload a PR quickly.

HttpClientMaxConcurrentStreamTest > ensureCorrectPendingAcquisitionDurationBehavior() FAILED
    org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a com.linecorp.armeria.client.HttpClientMaxConcurrentStreamTest
    Expected size: 18 but was: 9 in:
    [CompletableFuture[Incomplete],
        CompletableFuture[Incomplete],
        CompletableFuture[Incomplete],
        CompletableFuture[Incomplete],
        CompletableFuture[Incomplete],
        CompletableFuture[Incomplete],
        CompletableFuture[Incomplete],
        CompletableFuture[Incomplete],
        CompletableFuture[Incomplete]] within 10 seconds.
        at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
        at app//org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
        at app//org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
        at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:939)
        at app//org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:723)
        at app//com.linecorp.armeria.client.HttpClientMaxConcurrentStreamTest.ensureCorrectPendingAcquisitionDurationBehavior(HttpClientMaxConcurrentStreamTest.java:336)

        Caused by:
        java.lang.AssertionError:
        Expected size: 18 but was: 9 in:
        [CompletableFuture[Incomplete],
            CompletableFuture[Incomplete],
            CompletableFuture[Incomplete],
            CompletableFuture[Incomplete],
            CompletableFuture[Incomplete],
            CompletableFuture[Incomplete],
            CompletableFuture[Incomplete],
            CompletableFuture[Incomplete],
            CompletableFuture[Incomplete]]
            at com.linecorp.armeria.client.HttpClientMaxConcurrentStreamTest.lambda$ensureCorrectPendingAcquisitionDurationBehavior$27(HttpClientMaxConcurrentStreamTest.java:336)


fix: consume at_compaction changes

- What I did

Consume the at_persistence_secondary_server PR changes related to at_compaction job

- How I did it

Refactor to use the new AtCompaction job configurations

- How to verify it

All the tests should pass

- Description for the changelog

Refactor the at_compaction job changes to use new AtCompaction abstraction

Is this still a draft or is it ready for review?

Is this still a draft or is it ready for review?

This is ready for review. Since, the dependency_overrides needs to be updated with hosted version, marked as a draft version.


Can't use an opaque C++ type from a different bridge/namespace

In https://github.com/coreos/rpm-ostree/pull/2568, we're trying to make use of an opaque C++ type in one crate bridge which has its ExternType implemented in a separate crate (which has its own bridge). The situation is like this:

The library rpmostree_rust from the crate rpmostree-rust wants to use type DnfPackage as a parameter of a function in the rpmostreecxx bridge.
The type DnfPackage is defined in the library libdnf-sys as an opaque C++ type and is part of a dnfcxx bridge. The library implements ExternType: https://github.com/coreos/rpm-ostree/blob/04839e200f94413aa2c8da1af816ca70f77feb19/rust/libdnf-sys/lib.rs#L17-L21
We want to tell CXX in the rpmostree-rust crate to use the DnfPackage type from the libdnf-sys crate, which on the C++ side is a type defined in the dnfcxx namespace and not rpmostreecxx.

Is there any way to do this presently?
One workaround is to rename the bridge in libdnf-sys to be the same (this is what https://github.com/coreos/rpm-ostree/pull/2568 does for now). Another workaround is to use the newtype pattern and re-implement ExternType in rpmostree-rust. Though I was hoping to avoid the boilerplate that implies converting between them.

It sounds like what you are looking for is:
#[cxx::bridge]
mod ffi {
    extern "C++" {
        ...

        #[namespace = "dnfcxx"]
        type DnfPackage = libdnf_sys::DnfPackage;
    }
}

This is documented in https://cxx.rs/attributes.html#namespace.

Ahh great, thanks! Not sure how I missed that.


Javascript Syntax Highlighting Bug

From @alek5k on March 16, 2018 2:3

VSCode Version: 1.16.0
OS Version: Windows 10

Steps to Reproduce:

Set syntax highlighting to javascript
Type in the following failure case:

if (startDragXOffset < cornerDistanceThreshold && startDragYOffset > (shapeWidth - cornerDistanceThreshold))

Compare with the following success case:

if (startDragXOffset < cornerDistanceThreshold && startDragYOffset >= (shapeWidth - cornerDistanceThreshold))
I have a feeling the regex check is looking for the "> (" combination which is used with arrow functions, eg:
(ctx) => ({ctx})
Does this issue occur when all extensions are disabled?: Yes
Copied from original issue: Microsoft/vscode#45933

Still repos with the most recent versions of the grammar in my testing


Webpack issues with MGT version 4

I assume you mean \node_modules\spfx-fast-serve-helpers\lib\templates\webpack.extend.js
/*
* User webpack settings file. You can add your own settings here.
* Changes from this file will be merged into the base webpack configuration file.
* This file will not be overwritten by the subsequent spfx-fast-serve calls.
*/

/**
 * you can add your project related webpack configuration here, it will be merged using webpack-merge module
 * i.e. plugins: [new webpack.Plugin()]
 */
const webpackConfig = {

}

/**
 * For even more fine-grained control, you can apply custom webpack settings using below function
 * @param {object} initialWebpackConfig - initial webpack config object
 * @param {object} webpack - webpack object, used by SPFx pipeline
 * @returns webpack config object
 */
const transformConfig = function (initialWebpackConfig, webpack) {
  // transform the initial webpack config here, i.e.
  // initialWebpackConfig.plugins.push(new webpack.Plugin()); etc.

  return initialWebpackConfig;
}

module.exports = {
  webpackConfig,
  transformConfig
}

thank you

I am guilty of not reading "Webpack extensibility"  but even trying to use the example in samples/advanced/fast-serve/webpack.extend.js it did not work.
I don't understand webpack that much.

Just try to put below code in your webpack.extend.js:
/*
* User webpack settings file. You can add your own settings here.
* Changes from this file will be merged into the base webpack configuration file.
* This file will not be overwritten by the subsequent spfx-fast-serve calls.
*/

// you can add your project related webpack configuration here, it will be merged using webpack-merge module
// i.e. plugins: [new webpack.Plugin()]
const webpackConfig = {
  module: {
    rules: [{
      test: /\.js$/,
      include: [
        /lit/,
        /@lit/,
        /lit-html/
      ],
      use: {
        loader: 'babel-loader',
        options: {
          plugins: [
            '@babel/plugin-transform-optional-chaining',
            '@babel/plugin-transform-nullish-coalescing-operator',
            '@babel/plugin-transform-logical-assignment-operators'
          ]
        }
      }
    }]
  }
}

// for even more fine-grained control, you can apply custom webpack settings using below function
const transformConfig = function (initialWebpackConfig, webpack) {
  // transform the initial webpack config here, i.e.
  // initialWebpackConfig.plugins.push(new webpack.Plugin()); etc.

  return initialWebpackConfig;
}

module.exports = {
  webpackConfig,
  transformConfig
}

That worked fine.
Thanks!


config.sh breaks in Terraform

I've been writing a terraform script to provision and register a private linux build agent for visualstudio.com.
The repo is located on github. Most of the terraform script runs without a hitch. It's when it gets to the null_resource in virtual_machine.tf that I hit a snag.
When the null_resource runs provision.sh on the remote machine it gets to the ./config.sh line and just hangs. Looking at my private agent list on visualstudio.com shows the new agent, so config.sh must've completed along with the rest of provision.sh. The null_resource just gets marked as tainted.
This is a weird issue because I'm not totally sure where to turn. Should I talk to you guys or Terraform?

@gislikonrad you can also check the agent _diag log see whether agent got configured or not. i would think you might need reach to Terraform, since we didn't receive any report about the ./config.sh script.


Very minor textual fix. Removed a single space in a warning message

This is probably the smallest possible PR.
Just a single space from a warning log message has been removed.
I have also added the copyright notice required in CONTRIBUTING.md but I really don't feel this is earned for such a small change.

It seems like one unrelated test failed : https://github.com/pyocd/pyOCD/actions/runs/6132956098/job/17109369724#step:11:1

/azp run


Failure if folders with .yml and .yaml in the name exist

When running the tool, it will fail if there is a folder with .yml or .yaml in the name.
Maybe we should we skip folders when attempting for format yaml files?

Thanks for making an issue! Never considered this use case. Should be a simple fix. I'll probably be able to get to it this week, but on the off chance there's anyone interested in contributing I'll mark it as a good first issue.


Updated

Fixes #
Proposed Changes

:) I was making changes and now @aravindvnair99 also made so dunno the current position...
Just one comment AR and VR comes under XR

:) I was making changes and now @aravindvnair99 also made so dunno the current position...
Just one comment AR and VR comes under XR

@Praddy2009 To clarify, I didn't make any change. Those are commit suggestions. Unless you accept and commit from the options, the code doesn't change.
And regarding your 2nd point, yes AR and VR comes under XR. That's why I said superset: https://github.com/abhinavsri360/GDSC-Lead-Map/pull/58#discussion_r612226432 Better to name it as AR\VR\XR as people who are familiar with either one or both can be put in one category. Too many choices won't be good.

I don't know aboy squashing so i'll be making a new PR
Closing this and thanks for suggestions @aravindvnair99

I don't know aboy squashing so i'll be making a new PR
Closing this and thanks for suggestions @aravindvnair99

@Praddy2009 Oh you don't have to do it. @abhinavsri360 will do it. It's just an option while merging PRs. Your changes are right so far. You fixed both:

geolocation
Cybersecurity


s3upload: ignore dotfiles under out/

@kislyuk This is the minimal diff for the plugin to make it compatible with the latest versions of miniwdl that touch some dotfiles under the out/ directory. Added a manual test script too (it's not straightforward to automate since it needs to upload into S3).
I would like to generally rework this section of the plugin code, but have foregone that for now to minimize the risk while this is blocking the version upgrade. The current version @morsecodist and I worked out while trying different ways to make Directory uploads work, and the purpose of the new dotfiles was to allow simpler logic (but in fact broke the current logic)

Thanks!


All <> Active toggle status not updated correctly when moving from Domains to Authors List report

Resolved on:
https://github.com/chaineco/bisonexplorer/commit/86196f8389fbb3d82ffaafe04bc6bab922313c70


Bluetooth HCI SPI slave application

This PR adds a sample application which can be used as the slave side of an HCI SPI solution.
It's been tested on 96b_carbon_nrf51 with some additional patches for 96b_carbon which are still being prepared for upstream submission. I don't have an nrf51_pca10028 to test with, but a project configuration file is also provided for this board, which was tested with an earlier version of this application.
I'm happy to drop this PR until the combined patches for 96Boards Carbon are complete, but since it's a useful component in its own right, I thought to submit separately.

@carlescufi @cvinayak @pfalcon FYI

Thanks for the reviews; I've addressed them in v2.
Since this was first written before I joined Linaro, I also looked at the diff between the source and hci_{uart,usb}. There appear to be some structural similarities between hci_uart and hci_spi (switch/break layout, #defines, and included headers), so I've also added back in the Nordic and Intel copyright. I didn't see significant enough code overlap to merit adding in Signed-off-by: lines. Please let me know if that doesn't seem kosher.

Thanks for the additional review.

We dont need debug enabled in default config, please remove for these debug defines for both boards.

I've removed them from prj_nrf51_pca10028.conf, but left them commented out in prj_96b_carbon_nrf51.conf so they're easy to re-enable later.

Remove, already defined in line 2

Done.

nitpicking, general comment throughout in this file, use spaces to align macro values (instead of tabs as of now e.g. between HCI_CMD \t\t\t 0x01).

Done.

Needs hardware specific setup and running instructions.

I intend to post these in the follow-up patch series I referenced in the pull request summary (I actually have these parts written), but I can't post those yet as I'm still working on some patches for 96b_carbon (not 96b_carbon_nrf51) required to enable this.
Are you OK with deferring that to future work, or should I drop this series until both are ready?

Built this PR, it builds ;-). Hope to try to run it next few days.
@jhedberg , @cvinayak : Your comments seems to have been addressed by @mbolivar , can you please re-review?

Built this PR, it builds ;-). Hope to try to run it next few days.

I hope so too! Note that I've also submitted https://github.com/zephyrproject-rtos/zephyr/pull/832. We've been using an out of tree SPI driver for 96b_carbon and I ran into some problems with the mainlined version which PR 832 fixes.
When that's merged, I'll be able to submit the "other half" of this along with hardware-specific docs for usage on 96Boards Carbon (the board, combining the 96b_carbon and 96b_carbon_nrf51 Zephyr "BOARD"s).

@mbolivar :

some patches for 96b_carbon (not 96b_carbon_nrf51)

To clarify, this app should be flashed to nrf51 on the Carbon, which, per previous discussion on 96boards-dev list requires: a) soldering SWD pins for nrf51; b) dedicated SWD adapter - is that true?

To clarify, this app should be flashed to nrf51 on the Carbon, which, per previous discussion on 96boards-dev list requires: a) soldering SWD pins for nrf51; b) dedicated SWD adapter - is that true?

On 96Boards Carbon, yes, it can be flashed onto the nrf51. It can be flashed onto other dev boards with an nrf51 (or any other SoC with a Zephyr SPI slave driver and a BT stack) as well, of course.
I do have a Carbon where I soldered on the nrf51 debug header to flash this, but I find it's not necessary. With an SWD debugger that lets me connect flying 0.1" jumper wire leads (I use the BlackMagic probe with 20 pin JTAG adapter kit and cables, https://1bitsquared.com/products/black-magic-probe), I can just insert the leads into the unpopulated header, press them into place with one hand, and type one-handed into the debugger with the other hand to flash the chip. This works well if you've got some .gdbinit functions defined to attach your debugger and run "load". Feel free to ping me on IRC if you want to discuss further.

@mbolivar : Ok, I did my homework and was able to access Carbon's nRF51 using its STM32 running BlackMagic probe.

Of course, there're no visible effects of that (how to easily run something on nRF51 with visible effect?), so I'm waiting for further instructions ;-).

how to easily run something on nRF51 with visible effect?

Ok, I wasn't able to confirm that it's possible to flash/run anything on nRF51. I followed an obvious idea: make blinky run on nRF51, then run on STM32 "gpio proxy" app which "forwards" gpio signal from one pin to another (LED). I used BLE_RDY (P0.29 -> PB0). Nothing works ;-). Won't spend more time on reverse-engineering Carbon's funky design, will wait for detailed instructions ;-).

will wait for detailed instructions ;-).

@pfalcon, here is a preview of what's to come:
https://github.com/mbolivar/zephyr/tree/96b_carbon-net
It builds on the hci_spi app for nRF51 (this PR #803), the bug fix PR #832 I mentioned above, some additional needed Carbon patches, and the documentation @dbkinder requested tying this all together (docs patch is https://github.com/mbolivar/zephyr/commit/78e980c9e586c16da50894d81980f3d461e3dbdf)
As I mentioned, though, fixing the SPI on STM32F4 in PR #832 is a blocker before I can submit the contents of this branch upstream, and there are some issues with it that will take some remote debugging to resolve.
(Since 1. the hci_spi slave app, 2. the SPI driver bug fixes, and 3. the Carbon patches to tie things together are logically separate, I am trying to get 1. and 2. merged incrementally first to avoid confusing the review by tying too many subsystems together in one PR.)

@mbolivar : Thanks, that branch worked for me (down to ping6'ing the Carbon).

down to ping6'ing the Carbon

Correction: I stupidly pinged local end of IPv6 conn. Now redoing it properly, I hit a typical "nothing works" situation, e.g. https://jira.zephyrproject.org/browse/ZEP-2422

When I fixed something, I got correct TCP echo from ipsp sample, and then somewhere on TCP disconnect:
***** BUS FAULT *****
  Executing thread ID (thread): 0x20002080
  Faulting instruction address:  0x80009ee
  Precise data bus error
  Address: 0xe5f7ffc1
Fatal fault in essential thread! Spinning...

(Many of the recent posts aren't related directly to this patch, but as we were deprived of issue tracker here... Jira doesn't seem good for such "stream of debugging" posts.)

Jira doesn't seem good for such "stream of debugging" posts

What does this even mean?
Is having JIRA open in a different browser tab and clicking the giant "Create" button at the top of the page really that burdensome?
If you're going to complain about the current bug tracking system, please give very specific, actionable feedback on why this is the case.
Otherwise, if an issue is reproducible in the master branch, file a bug...

Yup, crash on closure is 100% reproducible. Let me file it as https://jira.zephyrproject.org/browse/ZEP-2423

@andrewboie :

Otherwise, if an issue is reproducible in the master branch, file a bug...

It's not reproducible in the master branch, that's why filing a Jira ticket doesn't feel right. I'm giving feedback to @mbolivar to the series of patches he's working on, of which this one is only a part, and actually beyond that, of what steps are made and issues are seen on bringing up BLE 6lowpan connectivity 96b_carbon. It started here on Github with patch series and feel like natural to discuss on github too. (I understand desire to keep epics/userstories and other PM activities in Jira; no, I don't see a big issue with having bug and PM trackers separate).

https://github.com/zephyrproject-rtos/zephyr/pull/877 makes ipsp usable with telnet fe80::c103:b6ff:fea2:bd03%bt0 4242 for me.
(I probably should add that some of the recent comments are more like a reply to https://github.com/mbolivar/zephyr/commit/78e980c9e586c16da50894d81980f3d461e3dbdf#commitcomment-23201065 , maybe I even should have posted them there, but then nobody else but us 2 would have a chance to read them, at least here, they can be found by github intra-project search).

@pfalcon @dbkinder @jhedberg @cvinayak
Now that https://github.com/zephyrproject-rtos/zephyr/pull/832 is merged, I've rebased and expanded this pull request. Main changes:

Make Bluetooth HCI SPI changes needed to support controller based on new SPI API, for 96b_carbon and other STM32 targets
Add missing configuration to set this up on 96b_carbon / 96b_carbon_nrf51
Add a fix to the Bluetooth ipsp sample
Add documentation for combining BT ipsp on 96b_carbon with hci_spi on 96b_carbon_nrf51

Could you please review?

Updated to fix Sphinx target error; diff:
diff --git a/boards/arm/96b_carbon/doc/96b_carbon.rst b/boards/arm/96b_carbon/doc/96b_carbon.rst
index 4b5fde556..830d658d4 100644
--- a/boards/arm/96b_carbon/doc/96b_carbon.rst
+++ b/boards/arm/96b_carbon/doc/96b_carbon.rst
@@ -317,6 +317,8 @@ terminal:

    Hello World! arm

+.. _96b_carbon_verify_bluetooth:
+
 Verifying Bluetooth Functionality
 ---------------------------------

Rebased and updated to incorporate most review comments as well as adding more error handling; diff:
diff --git a/samples/bluetooth/hci_spi/README.rst b/samples/bluetooth/hci_spi/README.rst
index ea65a197c..478829e1a 100644
--- a/samples/bluetooth/hci_spi/README.rst
+++ b/samples/bluetooth/hci_spi/README.rst
@@ -10,7 +10,7 @@ the Zephyr SPI HCI transport protocol (similar to BlueNRG).
 Requirements
 ************

-* A board with SPI slave, GPIO and BLE support
+* A board with SPI slave, GPIO and BLE support.

 Building and Running
 ********************
diff --git a/samples/bluetooth/hci_spi/src/main.c b/samples/bluetooth/hci_spi/src/main.c
index 7ca37aa60..c71baabfc 100644
--- a/samples/bluetooth/hci_spi/src/main.c
+++ b/samples/bluetooth/hci_spi/src/main.c
@@ -95,7 +95,7 @@ static inline int spi_send(struct net_buf *buf)
 	u8_t header_master[5] = { 0 };
 	u8_t header_slave[5] = { READY_NOW, SANITY_CHECK,
 				 0x00, 0x00, 0x00 };
-	u8_t ret;
+	int ret;

 	SYS_LOG_DBG("buf %p type %u len %u", buf, bt_buf_get_type(buf),
 		    buf->len);
@@ -153,7 +153,11 @@ static void bt_tx_thread(void *p1, void *p2, void *p3)
 	struct net_buf *buf = NULL;
 	struct bt_hci_cmd_hdr cmd_hdr;
 	struct bt_hci_acl_hdr acl_hdr;
-	u8_t ret;
+	int ret;
+
+	ARG_UNUSED(p1);
+	ARG_UNUSED(p2);
+	ARG_UNUSED(p3);

 	memset(&txmsg, 0xFF, SPI_MAX_MSG_LEN);

@@ -179,6 +183,7 @@ static void bt_tx_thread(void *p1, void *p2, void *p3)
 				     &rxmsg, SPI_MAX_MSG_LEN);
 		if (ret < 0) {
 			SYS_LOG_ERR("SPI transceive error: %d", ret);
+			continue;
 		}

 		switch (rxmsg[PACKET_TYPE]) {
@@ -234,6 +239,8 @@ static int hci_spi_init(struct device *unused)
 		.config = SPI_WORD(8),
 	};

+	ARG_UNUSED(unused);
+
 	SYS_LOG_DBG("");

 	spi_hci_dev = device_get_binding(SPI_HCI_DEV_NAME);
@@ -263,26 +270,35 @@ void main(void)
 	static K_FIFO_DEFINE(rx_queue);
 	struct bt_hci_evt_hdr *evt_hdr;
 	struct net_buf *buf;
+	k_tid_t tx_id;
 	int err;

 	SYS_LOG_DBG("Start");

-	bt_enable_raw(&rx_queue);
+	err = bt_enable_raw(&rx_queue);
+	if (err) {
+		SYS_LOG_ERR("bt_enable_raw: %d; aborting", err);
+		return;
+	}

 	/* Spawn the TX thread, which feeds cmds and data to the controller */
-	k_thread_create(&bt_tx_thread_data, bt_tx_thread_stack,
-			K_THREAD_STACK_SIZEOF(bt_tx_thread_stack), bt_tx_thread,
-			NULL, NULL, NULL, K_PRIO_COOP(7), 0, K_NO_WAIT);
+	tx_id = k_thread_create(&bt_tx_thread_data, bt_tx_thread_stack,
+				K_THREAD_STACK_SIZEOF(bt_tx_thread_stack),
+				bt_tx_thread, NULL, NULL, NULL, K_PRIO_COOP(7),
+				0, K_NO_WAIT);

 	/* Send a vendor event to announce that the slave is initialized */
 	buf = net_buf_alloc(&cmd_tx_pool, K_FOREVER);
-	if (buf) {
-		bt_buf_set_type(buf, BT_BUF_EVT);
-		evt_hdr = net_buf_add(buf, sizeof(*evt_hdr));
-		evt_hdr->evt = BT_HCI_EVT_VENDOR;
-		evt_hdr->len = 2;
-		net_buf_add_le16(buf, EVT_BLUE_INITIALIZED);
-		spi_send(buf);
+	bt_buf_set_type(buf, BT_BUF_EVT);
+	evt_hdr = net_buf_add(buf, sizeof(*evt_hdr));
+	evt_hdr->evt = BT_HCI_EVT_VENDOR;
+	evt_hdr->len = 2;
+	net_buf_add_le16(buf, EVT_BLUE_INITIALIZED);
+	err = spi_send(buf);
+	if (err) {
+		SYS_LOG_ERR("can't send initialization event; aborting");
+		k_thread_abort(tx_id);
+		return;
 	}

 	while (1) {

Pending review comments:

Documentation updates suggested (@pfalcon, waiting feedback from @dbkinder)
Switching to K_FOREVER in the TX thread (@sjanc, feedback from @jhedberg requested by @rsalveti)

FWIW, I've tried these patches with K_NO_WAIT (matching the other samples) and with K_FOREVER (suggested by @sjanc) and neither seems to have serious problems. So my preference would be to keep this as-is and follow up with a bulk change of all the HCI apps to use K_FOREVER if there is a good reason to do so.

And why it's not a full sentence? Text consists of paragraphs, paragraphs consist of sentences. ;-)

It lacks a verb, for one thing :).

I personally don't see it as "branding". This is a niche app, which won't work for 95% of boards. Someone may even wonder if there's a board for which it works, and can find it out. Yes, there're other ways to find it out, but the point of docs (README in our case) is to provide enough information, not make people "reverse engineer" it.

This patch series already includes a reference to 96b_carbon_nrf51 from this very file (README.rst), just lower down in the page. I don't think it makes sense to put this information again in the list of requirements.
Here it it is, for reference:
Refer to :ref:`bluetooth_setup` for general Bluetooth information, and
to :ref:`96b_carbon_nrf51_bluetooth` for instructions specific to the
96Boards Carbon board.

Updated with documentation changes; diff:
diff --git a/boards/arm/96b_carbon/doc/96b_carbon.rst b/boards/arm/96b_carbon/doc/96b_carbon.rst
index 830d658d4..fc59164cc 100644
--- a/boards/arm/96b_carbon/doc/96b_carbon.rst
+++ b/boards/arm/96b_carbon/doc/96b_carbon.rst
@@ -10,38 +10,31 @@ Zephyr applications use the 96b_carbon configuration to run on the 96Boards
 Carbon hardware. It is based on the STMicroelectronics STM32F401RET Cortex-M4
 CPU and also contains a nRF51832 chip connected over SPI for BLE connectivity.

-.. note::
-
-   The nRF51832 chip on this board is supported by Zephyr using
-   another configuration, 96b_carbon_nrf51; see
-   :ref:`96b_carbon_nrf51_board` for more details on this
-   configuration.
-
-   **Although both chips exist on the same physical board,
-   96b_carbon_nrf51 is a distinct Zephyr configuration, targeting a
-   different chip, than the 96b_carbon configuration described on this
-   page**.
-
-   This can be confusing. The important things to understand are:
-
-   1. 96b_carbon should be used when developing programs for the main
-      chip on the board, the STM32F401RET. Users will likely want to
-      write applications targeting this chip, using the 96b_carbon
-      configuration, as it is what is connected to all of the breakout
-      I/O headers.
-
-   2. 96b_carbon_nrf51 should be used for the secondary chip, the
-      nRF51832.  Most users will likely not develop applications for
-      this chip, since Zephyr already provides a sample application
-      that can be flashed onto the nRF51832 to provide Bluetooth
-      functionality to the STM32F401RET.
-
-   For instructions on how to set up the nRF51832 to develop Bluetooth
-   applications using 96b_carbon, see :ref:`96b_carbon_nrf51_bluetooth`.
-
-   After you have flashed your nRF51, you can perform basic validation
-   of this Bluetooth setup using instructions :ref:`below
-   <96b_carbon_verify_bluetooth>`.
+The 96Boards Carbon board is built with two chips: an STMicroelectronics
+STM32F401RET Cortex-M4 CPU and an nRF51832 chip connected to
+the Cortex-M4 CPU over SPI for Bluetooth LE connectivity.  Even though
+both chips exist on the same physical board, they must be programmed
+separately:
+
+- The ``96b_carbon`` configuration is used when developing programs for
+  the main chip on the board, the STM32F401RET. Users will likely want to
+  write applications targeting this chip, using the ``96b_carbon``
+  configuration, since it is connected to all of the breakout
+  I/O headers.
+
+- The ``96b_carbon_nrf51`` configuration should be used for programming
+  the secondary nRF51832 chip. Most users will likely not develop
+  applications for this chip, since Zephyr already provides a
+  sample application that can be flashed onto the nRF51832
+  to provide Bluetooth functionality to applications on the main
+  STM32F401RET chip.
+
+For instructions on how to set up the nRF51832 to develop Bluetooth
+applications, see :ref:`96b_carbon_nrf51_bluetooth`.
+
+After you have flashed your nRF51, you can perform basic validation
+of this Bluetooth setup using the instructions
+:ref:`below <96b_carbon_verify_bluetooth>`.

 .. figure:: img/96b-carbon-front.png
      :width: 487px
@@ -326,11 +319,10 @@ This section contains instructions for verifying basic Bluetooth
 functionality on the board. For help on Zephyr applications
 in general, see :ref:`build_an_application`.

-1. Make sure you have flashed the nRF51 with the hci_spi sample
-   application as described in :ref:`96b_carbon_nrf51_bluetooth`.
+1. Flash the nRF51 with the hci_spi sample application as described in
+   :ref:`96b_carbon_nrf51_bluetooth`.

-2. Make sure you have dfu-util installed as described earlier on this
-   page.
+2. Install the dfu-util flashing app, as described above.

 3. Build the ``samples/bluetooth/ipsp`` application for 96b_carbon::

@@ -345,8 +337,8 @@ in general, see :ref:`build_an_application`.

      $ make BOARD=96b_carbon flash

-Following that, refer to the instructions in
-:ref:`bluetooth-ipsp-sample` for how to verify functionality.
+5. Refer to the instructions in :ref:`bluetooth-ipsp-sample` for how
+   to verify functionality.

 Congratulations! Your 96Boards Carbon now has Bluetooth
 connectivity. Refer to :ref:`bluetooth` for additional information on
@@ -355,7 +347,7 @@ further Bluetooth application development.
 Debugging
 =========

-The 96b_carbon can be debugged by installing 100 mil (0.1 inch) header
+The 96b_carbon can be debugged by installing a 100 mil (0.1 inch) header
 into the header at the bottom right hand side of the board, and
 attaching an SWD debugger to the 3V3 (3.3V), GND, CLK, DIO, and RST
 pins on that header. Then apply power to the 96Boards Carbon via one
diff --git a/boards/arm/96b_carbon_nrf51/doc/96b_carbon_nrf51.rst b/boards/arm/96b_carbon_nrf51/doc/96b_carbon_nrf51.rst
index 16baefe2f..a1c18ab34 100644
--- a/boards/arm/96b_carbon_nrf51/doc/96b_carbon_nrf51.rst
+++ b/boards/arm/96b_carbon_nrf51/doc/96b_carbon_nrf51.rst
@@ -136,13 +136,10 @@ Zephyr application, see :ref:`build_an_application`.)

 .. warning::

-   **Do not flash the hci_spi application on the STM32F401RET chip on
-   the 96Boards Carbon.**
-
-   Both chips are supported by Zephyr and exist on the same physical
-   board hardware, but the hci_spi application must run on the nRF51
-   chip supported by the 96b_carbon_nrf51 Zephyr configuration
-   described on this page.
+   Be sure to flash the hci_spi application to the nRF51832 chip and
+   not to the main STM32F401RET chip.  While both chips are supported
+   by Zephyr, the hci_spi application providing Bluetooth support will
+   only run on the nRF51832 chip.

 References
 **********
diff --git a/samples/bluetooth/hci_spi/README.rst b/samples/bluetooth/hci_spi/README.rst
index 478829e1a..32843031b 100644
--- a/samples/bluetooth/hci_spi/README.rst
+++ b/samples/bluetooth/hci_spi/README.rst
@@ -1,3 +1,5 @@
+.. _bluetooth_hci_spi:
+
 Bluetooth: HCI SPI
 ##################

... anticipating the tests all pass :)

@galak @nashif is this a shippable false negative? I see 500 passed, 0 errored / failed / skipped.
@cvinayak have I addressed your concerns?

@mbolivar :

is this a shippable false negative? I see 500 passed, 0 errored / failed / skipped.

Tests are split in parallel batches. If you click on "3267.2" tab, you'll see "Tests 499  / 1  / 0  / 0".
(I already complained on IRC about recent change of UI design of Shippable, makes everything with Shippable confusing again, as if we just started with it).

Tests are split in parallel batches. If you click on "3267.2" tab, you'll see "Tests 499 / 1 / 0 / 0".

Many thanks. The failing test is:
 Sanitycheck / qemu_nios2:tests/kernel/workq/work_queue/test / qemu_nios2/tests/kernel/workq/work_queue/test

I think this is a false positive. I re-ran sanitycheck locally to confirm no failure, and this PR doesn't touch anything that I can imagine would affect this test's result.

and this PR doesn't touch anything that I can imagine would affect this test's result.

So, please rebase it to retrigger build and erase this random failure ;-).
P.S. I didn't yet have a chance to re-test this patch against master, hope to do this on weekend.

So, please rebase it to retrigger build and erase this random failure ;-).

Yes, I've seen people use that workaround, but that won't help anyone else running into the same issue, so I'm flagging it to see if the flaky test needs to be disabled.
@galak @nashif for what it's worth (since the "just rebase it" or "close it and reopen it" tricks are not 100% intuitive), some bots can monitor the comment stream for a magic string or otherwise take input that retriggers testing. I looked around in the shippable trigger docs (http://docs.shippable.com/validate/trigger-job/) and PR building docs (http://docs.shippable.com/ci/pull-request-builds/). Seems like it might be possible to rig something like that together with shippable, but I didn't see anything obvious.

@mbolivar I just posted a PR to rename BT_CONTROLLER to BT_CTLR. Sorry for the inconvenience if mine gets merged before yours: https://github.com/zephyrproject-rtos/zephyr/pull/1106

@mbolivar I just posted a PR to rename BT_CONTROLLER to BT_CTLR. Sorry for the inconvenience if mine gets merged before yours

Thanks for the heads up!

@galak @nashif for what it's worth (since the "just rebase it" or "close it and reopen it" tricks are not 100% intuitive), some bots can monitor the comment stream for a magic string or otherwise take input that retriggers testing. I looked around in the shippable trigger docs (http://docs.shippable.com/validate/trigger-job/) and PR building docs (http://docs.shippable.com/ci/pull-request-builds/). Seems like it might be possible to rig something like that together with shippable, but I didn't see anything obvious.

we have an issue open about this: #779

this needs rebasing now anyways, so please rebase and we might get rid off the false positive

Rebased and updated. Diff: https://gist.github.com/mbolivar/729dc895e1d36d272491d2efa9ad53e3
@cvinayak, I've left CONFIG_BT_RX_BUF_LEN=255. OK with you? I think that's the last potential issue.

we have an issue open about this: #779

Thanks for the hint. I'll watch this one since I've seen GH issues are getting shut down: https://jira.zephyrproject.org/browse/INF-134

@mbolivar CONFIG_BT_RX_BUF_LEN=255 is ok, with the fact that its the restrictions over SPI.


Agenda days not corresponding to the events viewed

{
                    "id": "S1",
                    "label": "Agenda 30 day View",
                    "shortcut": "S",
                    "type": 0,
                    "size": 30,
                    "focus": 0,
                    "repeat": false,
                    "listTimes": false,
                    "updateRows": false,
                    "schedule": true
                },

I have that set as one of the options
when I toggle to that option, the summary for days at the tops seems to be of size 30.
but the events displayed are off by a day or two
I logged eventDays from Agenda.vue  and that's how i made sure that it was a bug

I'm not witnessing this issue - do you have some steps to reproduce it?


fix: fixed a bug that would cause MDImage.tsx to set the aspect ratio…

…n to NaN causing an app crash
Changes made
Added a ternary in MDImage.tsx that will check if the aspect ratio is a valid value and if not will set it to undefined to avoid setting the aspect ratio to NaN which causes a crash on IOS devices.
Link to Issue
See issue #421 for further details

@travis-racisz Thanks for the fix. I'll prepare a release ASAP


Merge and delete vordlists, add login.html to Logins.fuzz.txt

Merge two domino wordlists, add one more missed endpoint to Logins.fuzz.txt

Thank you!


Usability: QR check-in confusing to find

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[x] Bug is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[x] Bug is not already reported in another issue

Technical details

Device name: iPhone SE (2020)
iOS version: 14.4.2
App version: 2.0.3

Describe the bug

Trying to scan a check-in QR code is really confusing. To get to the function, you need to first select the create QR code field, click through the QR code creation instructions, then select the scan QR code field at the bottom of the screen. You lose many users during the process.
Providing the user with an easily accessible check-in scan option right from the home screen would be preferable.
Steps to reproduce the issue

As described above, navigate through the create QR code menu and find the scan option somewhere at the bottom of the screen.
Possible Fix
Place the scan option directly on the home screen.

@pizuz
Is there no field "Check-In" on your tap bar?

Hi Tim,
Of course it is, but in order to find it, you have to click the create QR
code button and navigate through the bottom screen menu. This is highly
counter-intuitive.
Regards,
Florian
Tim @.***> schrieb am Mi. 21. Apr. 2021 um 11:10:

@pizuz https://github.com/pizuz
Is there no field "Check-In" on your tap bar?
https://user-images.githubusercontent.com/67682506/115528199-1d928a80-a292-11eb-86d4-ba94ba75d319.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/corona-warn-app/cwa-app-ios/issues/2496#issuecomment-823908384,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC7ZV4BFEP6SYX4VIULKSODTJ2JA5ANCNFSM43J5HGPA
.