[#406][#412] Fix 3 frintTypescript Errors

The three errors were encountered when moving the exemplar Multiple-Apps project to Typescript.
In file: core/app/index.ts
import { createApp, AppClass } from 'frint';

import RootComponent from '../components/Root';

export default createApp({
  name: 'MiskApp',
  providers: [
    {
      name: 'component',
      useValue: RootComponent,
    },
  ],
});

Error 1
Within VS Code, the following Typescript error was raised
Default export of the module has or is using private name 'AppClass'.

And at compile time, this error is raised.
ERROR in [at-loader] ./src/core/app/index.ts:1:21
    TS2305: Module '"/Users/aparadi/Development/misk-admin/main/node_modules/frint/lib/index"' has no exported member 'AppClass'.

Based on the first part of this error, the issue is found to be that Typescript requires knowledge of the interface for AppClass within the exported App class. Since AppClass is a private/unexported class, there is an error. The proposed solution is to export AppClass along with App, FrintProvider in frint/index.ts.
export { default as createApp } from './createApp';
export { App, AppClass, FrintProvider } from './App';

Then, in client apps in core/app/index.ts, AppClass can be imported along with createApp from 'frint' without error.
import { createApp, AppClass } from 'frint';

import RootComponent from '../components/Root';

export default createApp({
  name: 'App',
  providers: [
    {
      name: 'component',
      useValue: RootComponent,
    },
  ],
});

Error 2
Within core/index.ts for new client apps, adjustments can be made to prevent the need to use <any> to eliminate Typescript errors.
core/index.ts
import { App as FrintApp } from 'frint';
import { render } from 'frint-react';

import App from './app';

const apps: FrintApp[]= (<any>window).app || [];
const app: FrintApp = (<any>window).app = new App();
(<any>app).push = (options: any) => app.registerApp(...options);
apps.forEach((<any>app).push);

render(app, document.getElementById('root'));

Adjustments that could/have be(en) made include:

[x] Importing FrintApp allows Typescript to take full advantage of the full class when verifying class types apps and app.
[ ] Adding a push interface/function to the App class in frint/App.ts to eliminate the any override
[ ] Adding an interface for Window that includes .app

If these two additional adjustments would like to be pursued, I will go ahead and fix them.
Error 3
One error that took an especially long time to solve was in regards to app.registerApp(...options); which had the following message:
ERROR in [at-loader] ./src/core/index.ts:9:37
    TS2556: Expected 1-2 arguments, but got 0 or more.

The issue seemed to be confusion with matching the rest param operator (ie. ...options) which has no minimum parameters requirement against the compiled function definition in frint/App.d.ts which has 1 required parameter (appClass) and 1 optional (opts?).
Currently, the following in frint/App.ts...
public registerApp(appClass: AppClass, opts: RegisterAppOptions = {}) {...}

...compiles down to a mandatory appClass parameter in frint/lib/App.d.ts
registerApp(appClass: AppClass, opts?: RegisterAppOptions): void;

To fix this, I propose providing an initializer for appClass so that when compiled down there is no mismatch of number of required parameters. Thus the following in frint/App.ts
public registerApp(appClass: AppClass = App, opts: RegisterAppOptions = {}) {...}

The alternative method is to simply use any type as below but I preferred not to rely on that as it eliminates many of the benefits of Typescript.
(<any>app).registerApp(...options);

tl;dr

A few changes suggested and implemented to reduce the need to use (<any>app) or other blunt ways to quiet Typescript compile errors.
2 suggested but unimplemented changes for Error 2 which I can work on if requested.
Open to any suggestions and feedback!

Apologies for missing this PR before, @andrewparadi! 😱
And many thanks for pushing this forward! 💖
My feedback for the Errors below:
Error 1
Please go ahead 👍
Error 2

Adding a push interface/function to the App class in frint/App.ts to eliminate the any override

Possible to avoid extending the API any further, and just leave to to typings only?

Adding an interface for Window that includes .app

window.app is mostly mentioned in the documentation for showing code-splitting examples. why do we need it in TypeScript?
Error 3
API docs for app.registerApp: https://frint.js.org/docs/packages/frint#appregisterapp
Your suggested approach would work really well:
public registerApp(appClass: AppClass = App, opts: RegisterAppOptions = {}) {...}

Please go ahead 👍

Overall, the aim is to migrate to TypeScript without causing any changes in the API of frint-* packages. Once all migrated, we can aim for the next major version with more strict interfaces :)

Thanks @fahad19 for the reply! The fixes for Error 1 and 3 are in the PR and ready to merge.

@fahad19 bump. Could this be merged since no outstanding changes were requested?

Merged and released as v5.4.5: https://github.com/frintjs/frint/releases/tag/v5.4.5
Thanks for your contributions! 💖
I was away for holidays. Will definitely push everyone at @Travix-International to be more active at responding to PRs 👍

Thanks for responding @fahad19! Just wanted to make sure the PR didn't get lost for too long before it was found and merged.


make flyway script rerunnable

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.16%. Comparing base (4bb6472) to head (f36e733).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #226   +/-   ##
=========================================
  Coverage     93.16%   93.16%
  Complexity      484      484
=========================================
  Files            82       82
  Lines          1623     1623
  Branches        101      101
=========================================
  Hits           1512     1512
  Misses           71       71
  Partials         40       40

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Collab: Joined the Whatsapp group

👋 Welcome to Blox AI! 🚀 I'm Subhadeep Roy, the founder of this exciting project along with @Xeven777 ✨
https://chat.whatsapp.com/E5oRd1VG1Ov4HoNPq4QcRU
Join this Whatapp group for issue discussions and a nice Open Source contribution feel. You can collab with other individuals here and work with them. Facing some problems is inevitable so why not discuss it with us in a good place :).
Thats were this grp comes to your help. All the issue resolvers are asked to join this group.
Looking forward to work with you all #BLOX AI

@dakshsinghrathore @sarthakmishra459 @vanshikab52


Execution depedency in composer install prior to running Docker containers

Inside composer.json, one of the post-install-cmd commands is to perform a database migration. This becomes problematic when trying to run the Docker containers for the first time. The docker-compose.yml requires hackgreenville to be built off the Dockerfile inside vendor, which turns into a chicken-and-egg problem.
So, if you're trying to get the Docker containers running for the first time, you'd need to run composer install, but this script will fail because you don't have a database yet available to run migrations against (unless you're running MySQL on bare metal).
My suggestion is to have a Dockerfile pre-defined so you don't need to run composer install to build out your Docker images, or remove php artisan migrate --seed from the composer.json post-install commands.

@irby I second removing php artisan migrate --seed from composer json.

I can't officially review PR's here, but @allella this looks good to me.


fix for canonicals with trailing /

Hey @carlosgauci do you think this change would be ok?
We have an issue in terms of technical SEO in that we get these reported. Showing that the canoncial url for pages is different to what there is in the sitemap. So I did this which would mean that only if there's a canonical_url mentioned then we add the meta. If not we skip.

Hey @TuanaCelik, makes sense, lgtm :)


I have all the newest everything installed and litecore install will not work

I have every single newest version of node.js, npm, java, etc...that this page says to download...I have given all permissions for administrator to run from command prompt...no matter what I do every time the furthest I get is litecore telling me that npm is not compatible with nodejs versions....no matter which version I use they all say this...
I try to npm install -g litecore...it says:
C:\WINDOWS\system32>npm install -g litecore

<EMAIL_ADDRESS>preinstall C:\Users(currentuser)\AppData\Roaming\npm\node_modules\litecore\node_modules\litecore-node
./scripts/download

'.' is not recognized as an internal or external command,
operable program or batch file.
npm WARN Error: EPERM: operation not permitted, scandir 'C:\Users(currentuser)\AppData\Roaming\npm\node_modules\litecore\node_modules\socket.io-parser\node_modules'
npm WARN  { Error: EPERM: operation not permitted, scandir 'C:\Users\Robert\AppData\Roaming\npm\node_modules\litecore\node_modules\socket.io-parser\node_modules'
npm WARN   stack: 'Error: EPERM: operation not permitted, scandir 'C:\Users\(currentuser)\AppData\Roaming\npm\node_modules\litecore\node_modules\socket.io-parser\node_modules'',
npm WARN   errno: -4048,
npm WARN   code: 'EPERM',
npm WARN   syscall: 'scandir',
npm WARN   path: 'C:\Users\(currentuser)\AppData\Roaming\npm\node_modules\litecore\node_modules\socket.io-parser\node_modules' }
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>preinstall: ./scripts/download
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>preinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users(currentuser)\AppData\Roaming\npm-cache_logs\2017-12-03T12_36_27_539Z-debug.log
why am I getting this:
'.' is not recognized as an internal or external command,
operable program or batch file.
?
looks to me like the scripts is written to run in linux and I need it to run in windows 10...like its trying to use "." to execute rather than .exe for the installation problem on the winodws machine
It installed on the linux machine but cant find bitcored because it needs to look for bitcoind...not bitcored...the newest bitcore library has a different name than what this code is trying to use...from what I can gather....
why am I the only one having problems here?
is noone else writing apps for litecoin?
PLEASES HELP ME!!
How can I fix this if I cant even install the code?
what am I doing wrong?
Thanks in advance
Does not work in windows or Linux system...I am convinced that litecore and bitcore both have not been updated...litecore keeps trying to find bitcore and the newest bitcore module is renamed bitcoind not bitcored...
this seems to be the problem....that and npm and node.js not being compatible on either system....I refuse to buy a mac just for a java wallet to work...
PLEASE HELP ME SOMEONE!!!

Agreed - get away from Windows. Throw it up on digital ocean or something if you need to


⚠ Fortnite has degraded performance

In e8cc6bf, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1394 ms

Resolved: Fortnite performance has improved in 73e2118.


[CLAR] Clean and standardize code

[ ] Define framework with automation;
[ ] Apply on modules;
[ ] Create descriptor;
[ ] Use DataFrame.copy() on internal functions;

Found repository with useful list of python linters here

Decided to use one of the wrappers for more functionalities.
Linter must be easy to use configure and yield the greater number of useful issues to the same code. Testing src/COIM/operator.py

Coala: did not work, it could not identify uppercase directories;
Yala: showed 335 issues, did not show pylint grade, friendly messages;
prospector: did not work, requires instalation of poetry, which can't find pyproject.toml file;
Pylama: showed 224 issues, did not show pylint grade;
Ciocheck: only avaiable on conda, for Force's sake;
wemake-python-styleguide: showed 345 issues, but is just flake8 with extra options.

Chose yala.


data_path issue

Hi,
trying to train the model on mnist, but I have the following error after running python train.py :

fuel.exceptions.ConfigurationError: Configuration not set and no default provided: data_path.

can't figure out how fuel should be set up.
thanks in advance for your help

Last release of fuel was in 2016. Might have better luck using a different framework than blocks + fuel tbh.

Yeah, I also would strongly recommend building on something more modern. I would have had trouble debugging that error with an upstream library at the time I wrote the code ... and now ~ seven years later, I have no idea.
One good starting place I know of is Yang Song's github: https://github.com/yang-song/score_sde


[WebGL2] Freezing in Chromium-derived browsers, caused by 2D particles

Godot version:
3.0 (official)
OS/device including version:
Tested on Windows 10 with Opera, Chrome, Firefox and Edge
Issue description:

Opera and Chrome:
The moving platforms or the main character start shaking for few seconds when pressing space (i.e. shooting action). See below:
https://youtu.be/OwxhPNTx2gY

Firefox:
No issue.

Microsoft Edge:
The game does not start at all.

Steps to reproduce:

Export the platformer 2D demo to HTML5
make a local server with python -m SimpleHTTPServer 8000
go to localhost:8000 with your brower
wait the game to start
press space

Minimal reproduction project:
You can find the platformer 2d demo in the template projects in Godot 3.0's Project List screen.

Same thing for me in my personal project, when I press space, moving trees do the same thing.

CC @eska014

This seems to be fixed in Chrome Canary (nightly) 67.0.3390.0, can anyone confirm?

@eska014

This seems to be fixed in Chrome Canary (nightly) 67.0.3390.0, can anyone confirm?

Not fixed at least for me :(  at Chrome 67.0.3390.0 (Official Build) canary (64-bit)

Having the same issue. Really makes the HTML5 export feature useless, unless your game uses no particles at all.

Same issue here, using Chrome Version 66.0.3359.181 (Official Build) (64-bit) with Godot 3.0.2 stable official

Having the same issue with Godot 3.0.2 and Chrome 66 on Mac

Having the same issue with Godot 3.0.3 on Chrome 67.  Confirmed working on Firefox.

Same with Godot Engine v3.0.6 on Chrome 69.0.3497.23 Linux

Tested export from in 3.1 beta 4 and using "Chrome 72.0.3626.109 - 64 bits" to play, but still not working.

Tested an export from 3.1 beta 6 on Chrome Version 72.0.3626.109 (Official Build) (64-bit) - also still not working.

Tested an export from 3.1 beta 6 on Chrome Version 72.0.3626.109 (Official Build) (64-bit) - also still not working.

Did you try on Chrome Version 72.0.3626.119  ????

Tested an export from 3.1 beta 6 on Chrome Version 72.0.3626.109 (Official Build) (64-bit) - also still not working.

Did you try on Chrome Version 72.0.3626.119 ????

No I haven't. I decided to drop the html5 release of my game as there were other issues like delayed audio. There are too many problems with web builds for it to be production ready.

Tested an export from 3.1 beta 6 on Chrome Version 72.0.3626.109 (Official Build) (64-bit) - also still not working.

Did you try on Chrome Version 72.0.3626.119 ????

No I haven't. I decided to drop the html5 release of my game as there were other issues like delayed audio. There are too many problems with web builds for it to be production ready.

I think this solution will come on 3.2 version. :/

I have the same problem with Godot 3.1-stable in Linux 64bit on Google Chrome, strangely enough everything works on Firefox but with a unplayable framerate.

Same problem here. Although it works fine on GLES2!

Confirmed that Particles2D are still causing the described 'screen shaking' issue when using Chrome 74.0.3729.169 and GLES3 on macOS.
Note that everything seems to work correctly on Firefox 67.0.

This seems fixed in latest 3.1 (3.1.2) and 3.2 (3.2.2), tested on both Linux and Windows 10, with Chrome 84 (Nvidia GTX 980).
Closing for now, but feel free to comment if you are still experiencing this issue (possibly providing also hardware info at this point) and I'll reopen it.
If someone could try also on a Mac it would be great.


Clarity on item value calculations

How does the simulation calculate the values of each item?
If you go into the warlock simulator and set all stat weights to zero except for spellpower, you would assume that every item has its value equal to the raw amount of spell power it gives.
This is however not the case, Iron-bound Tome has a spellpower of 74, but has an item value of 155 which is 2.09 times too high.
Pennant Cloak has 64 spellpower and an item value of 114, which is 1.41 times too high
Enchants have their real spellpower value as their item value.
This makes comparing item upgrades very difficult, as 20 points difference for one type of item does not equal 20 points difference on another.
If you change spellpower to 0, every item gets a score of 0 as they should, and if you change it to 2 every item gets twice its value as you woudl expect.
Describe the solution you'd like
Either clarify what background calculation causes these differences in item value, or make an optional button to just use the item weight as values (preferably both)

Im inept at understanding that it adds the value of the best enchantment on the item.


Dynamic offsets incorrectly bound with dynamic descriptors

In descriptor_sets.cpp, ValidateDrawState() function has dyn_offset_index set to 0 for each binding, while it should not.

RE: PR #612.

Fix was cherry-picked and pushed to master


Phone system license not a requirement for voicemail provisioning

Phone system license is not a requirement for cloud voicemail functionality as noted in announcement in 2019
https://tomtalks.blog/2019/04/voicemail-is-now-on-by-default-for-all-voip-enabled-users-in-microsoft-teams/#:~:text=Microsoft Teams has VoIP calling by default%2C both,in their calls app in the app bar.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8228f9b2-a7de-abb4-6f41-70db0b3af155
Version Independent ID: 8fd9fafb-dd76-59a8-e609-56f06d539a31
Content: Set up Cloud Voicemail - Microsoft Teams
Content Source: Teams/set-up-phone-system-voicemail.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Duplicate of https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/7603


fix spec snapshot endpoint

Description
I fixed the snapshot specifications.
https://opensearch.org/docs/latest/api-reference/snapshots/create-snapshot/
https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/snapshots/SnapshotInfo.java
Issues Resolved
https://github.com/opensearch-project/opensearch-api-specification/issues/606
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thank you! Needs some npm run lint--fix, CHANGELOG, etc, please.


Corrected container names in commercial paper tutorial

Corrected container names in commercial paper tutorial
Type of change

Documentation update

Description
Corrected container names in commercial paper tutorial. The container names for Org1 and Org2 were swapped with each other.
Signed-off-by: Nidhi Singh<EMAIL_ADDRESS>

The container names are different each time the test network is run. As a result, the container names are just for reference rather than a value that reflects the user experience.

yes, that is there. The container names for peer of Org1 and Org2 are inter-changed in the documentation.

The container names are different each time the test network is run. As a result, the container names are just for reference rather than a value that reflects the user experience.

yes, that is there. The container names for peer of Org1 and Org2 are inter-changed in the documentation.

But you've only updated the container ids in this PR. They are just examples, so not sure how they could be incorrect and require fixing.

BTW, if you do want to proceed with a PR, you'll need to sign the commit, see:
https://github.com/hyperledger/fabric/pull/3088/checks?check_run_id=4380855094

Haven't heard anything for one month, will close for now...


Functional tests: Include a unique ID in the coordinator's Postgre table name

So we can run the test suite in parallel with a single Postgre server without any race condition.

This is done: https://github.com/revault/revaultd/blob/3ab3c6a4b4e2dda4209c0c2e735d079aa3508aff/tests/test_framework/coordinatord.py#L31-L35


Travis Pro Support

Would be great... Not sure on the practicalities of dealing with OAuth etc. though.

:+1:


Make sysroot macro work when depending on these rules as a git repository

I don't understand why, but if those targets are not fully qualified, you get:

no such package 'cc/toolchains/actions': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
when using this macro.

cc @matts1

I believe this is being fix by another change.

Oh cool, I saw the other commit now. Good to know about the Label function.


Adding chips dynamically

I have a "chips input field" where the user can create tags for some custom data.
After the user has written 3 chars I show him a few tags (as a chip) that already exists. If he clicks on one, it should show up in the input field as well. I tried to to this by just calling the material_chip function and give it all the data as the data attribute. But this doesn't work.
Is there another way of creating chips in the input field dynamically?

+1 I have the same problem

Same here. An autocomplete feature is required. Maybe like https://github.com/henrychavez/materialize-tags/ Materialize Tags

I have suggested a solution for this here: https://github.com/Dogfalo/materialize/issues/3626. Let me know your thoughts

@Dogfalo Please merge my PR to resolve this issue. Looking forward to contribute more

merged


traefik 1.4.* doesn't work with text/event-stream

Do you want to request a feature or report a bug?
Bug
What did you do?
We use concourse (it's a CI/CD tool) under traefik. Concourse UI uses text/stream to get information about builds from its backend. In traefik 1.3.8 everything works fine, but after updating to traefik 1.4.0 - 1.4.5 concourse can't get any event from its backend (infinite waiting...).
What did you expect to see?
Concourse gets events from the backend.
What did you see instead?
Infinite waiting.
Output of traefik version: (What version of Traefik are you using?)
Traefik 1.4.0 - 1.4.5
What is your environment & configuration (arguments, toml, provider, platform, ...)?
The route to concourse was configured statically.
################################################################
# Global configuration
################################################################

logLevel = "DEBUG"

# Traefik logs file
traefikLogsFile = "/var/log/traefik-debug.log"

# Access logs file
accessLogsFile = "/var/log/accessTraefik.log"

# Entrypoints
defaultEntryPoints = ["http", "https"]
[entryPoints]
  [entryPoints.http]
  address = ":80"
	[entryPoints.http.redirect]
	entryPoint = "https"
  [entryPoints.https]
  address = ":443"
  compress = true
    [entryPoints.https.tls]
      [[entryPoints.https.tls.certificates]]
      certFile = ""
      keyFile = ""

...

[file]

[backends]
  [backends.concourse]
    [backends.concourse.servers.server1]
    url = "http://some-ip:8080"
...

[frontends]
  [frontends.concourse]
  backend = "concourse"
  passHostHeader = true
    [frontends.concourse.routes.host]
    rule = "Host:some-host"

If applicable, please paste the log output in debug mode (--debug switch)
Only these lines are related to concourse in traefik logs.
time="2017-12-15T22:13:12Z" level=debug msg="Round trip: http://some-ip:port, code: 200, duration: 6.000457ms tls:version: 303, tls:resume:false, tls:csuite:c02f, tls:server:some-host"
time="2017-12-15T22:13:14Z" level=debug msg="Round trip: http://some-ip:port, code: 200, duration: 2.51749ms tls:version: 303, tls:resume:false, tls:csuite:c02f, tls:server:some-host"
time="2017-12-15T22:13:14Z" level=debug msg="Round trip: http://some-ip:port, code: 200, duration: 3.597858ms tls:version: 303, tls:resume:false, tls:csuite:c02f, tls:server:some-host"```

Could try with 1.5.0-rc2 ?

I tried. The same thing.

Hi @TheCase and @Juliens. We run traefik v1.5.4 and concourse v3.9.0 but still have this issue.
Any thoughts?

Hi @mandrean,
Could you open a new issue with your configuration, and everything needed in order to reproduce your problem?
Thx

Hi everyone!
I have new information about the problem. So, we discovered that traefik1.5.4 works with SSE (we write a test-service with SSE support), but it hasn't worked with Concourse 3.9.2.

Hey @TheCase, what version of Concourse you were using when you saw the events displayed successfully on 1.5.0-rc4?

my working Concourse version is 3.8.0

Reporting in with Traefik 1.5.4-1 and Concourse 3.11.0. Not only are build logs not loading, the entire web UI is timing out. Currently testing to determine if this is a red herring.

Ok so the web container timeouts were due to a taxed instance, but I am reliably experiencing the lack of build logs. Confirmed that Traefik is the cause - this works fine with an Nginx proxy.
Devtools network panel shows that the events API call is the one that hangs with Traefik.  I have tested and confirmed this via cURL by copying the request in curl form from devtools and executing it in terminal:
curl 'https://ci.site.com/api/v1/builds/1352/events' -H 'Accept: text/event-stream' -H 'Cache-Control: no-cache' -H 'cookie: __utmz=xx.xx.xx.xx.utmcsr=linkedin.com|utmccn=(referral)|utmcmd=referral|utmcct=/feed/; hubspotutk=xx; __utmc=xx; __hssrc=1; _ga=GA1.2.xx.xx; __utma=xx.xx.xx.xx.xx.xx; __hstc=xx.xx.xx.xx.xx.xx; ATC-Authorization="Bearer xxxxxx"' -H 'Referer: https://ci.site.com/teams/main/pipelines/mobile-test/jobs/test-pr/builds/7' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36' --compressed

A quick search reveals https://github.com/containous/traefik/issues/819 which mentioned that perhaps the Content-Type header requires charset=uft-8 at the end, but this didn't change anything for me. I also tried adding -H "transfer-encoding:chunked" from https://github.com/containous/traefik/issues/503 to no avail.

I tried with concourse 3.9.2.
I follow https://concoursetutorial.com/ and https://concoursetutorial.com/basics/task-hello-world/ to install my concourse and create a build.
Then I launched a Traefik 1.5.4 (https://github.com/containous/traefik/releases/download/v1.5.4/traefik_linux-amd64)  with this config:
defaultEntryPoints = ["http"]

[entryPoints]
  [entryPoints.http]
  address = ":8081"

[file]
  [frontends.frontend-test]
    backend = "backend-test"
  [frontends.frontend-test.routes.test_1]
  rule = "Host:<IP_ADDRESS>"
  [backends]
    [backends.backend-test]
        [backends.backend-test.servers.website]
            url = "http://<IP_ADDRESS>:8080"

And everythings seems to work on http://<IP_ADDRESS>:8081/builds/1

Hi @Juliens! We talked at KubCon today. So we still seem to have this issue...
GCP GKE cluster: v1.9.6-gke.1 (both master and 3x slaves in node pool)
helm/tiller: v2.9.0 (both)
traefik: v1.5.4, deployed using stable/traefik v1.29.1 helm chart with Let's Encrypt enabled (dns-01/gcloud)
concourse: both v3.10.0 and v3.13.0, deployed using stable/concourse v1.3.2 helm chart with traefik ingress & tls-acme enabled
GCP GCE node:
 Kernel Version:		4.13.0-1011-gcp
 OS Image:			Ubuntu 16.04.4 LTS
 Operating System:		linux
 Architecture:			amd64
 Container Runtime Version:	docker://17.3.2
 Kubelet Version:		v1.9.6-gke.1
 Kube-Proxy Version:		v1.9.6-gke.1

Same issue here ! Any news ?

Ok folks, I did some heavy debugging today and was unable to reproduce the error.
Example cases: https://gist.github.com/emcniece/11824488f7a4d7ef9e51e4ff1217025a
There are 2 Docker-Compose stacks here: one that uses outdated versions (Concourse 3.9.0, Traefik 1.5.4), and one with updated versions (Concourse 3.14.0, Traefik 1.6.4). Instructions for replicating are included in the gist README.
Since both stacks do not exhibit the error, I won't bother detailing their differences.
This may indicate external interfering services. The gist here runs a local stack, and I can currently only see the issue in my production environment. Over the next week or two I'll be upgrading a number of services, this stack included - will report back once I make that upgrade.

I've just hit this..
using both stable helm charts stable/traefik and stable/concourse
Screenshot:

concourse (chart 1.7.0) installed with:
helm upgrade \
  --install \
  --recreate-pods \
  --namespace concourse \
  concourse \
  stable/concourse \
  --set "web.ingress.enabled=true" \
  --set "web.ingress.hosts[0]=concourse.example.com" \
  --set "concourse.externalURL=https://concourse.example.com"

traefik values.yml something like this:
Really nothing fancy and I can maybe set this up on a docker-compose for testing if that'll help
it definitely is just things with the stream header thats effected. I just spent best part of a week thinking concourse was crap but it was my beloved traefik all along :-(
imageTag: v1.6.4-alpine
debug:
  enabled: true
ssl:
  enabled: true
  enforced: true
acme:
  enabled: true
  email<EMAIL_ADDRESS>
  staging: false
  persistence.enabled: false
  challengeType: http-01
rbac:
  enabled: true
service:
  annotations:
    external-dns.alpha.kubernetes.io/hostname: '*.example.com.'

Installing helm like this:
helm upgrade \
  --namespace traefik \
  --install traefik \
  stable/traefik \
  -f values.yml

This effects me on GKE k8s 1.8 and 1.9 both "COS" and "UBUNTU" kernels/hosts.

@emcniece I was certain I'd be able to reproduce this easily with docker-compose but then I tried and disturbingly it just always worked.. I even went the route of host networking for traefik to be sure. I can see why you were so frustrated in your tests
I am pretty sure (when I have the time this week) that I can reproduce it by putting https on the frontend of a docker-compose for u.
The first time I encountered this issue was when I hand-rolled a deployment on a single instance and used docker-compose to flesh out what I needed.. naturally I used traefik+acme ssl but I thought it was concourse that was faulty..
It was only later with k8s also that I isolated it the cause to be traefik. I switched ingress controllers and that sorted the issue. (although I'm not happy about a life without traefik)
TL;DR: The only common thread that I can think of now is having https on the frontend

@starkers OH, yes - SSL could indeed be the problem! My last test didn't use a certificate as it was all local. I'll try this again on a public instance with https.

@starkers Tested with Traefik+ACME, and it's working fine. Check out https://concourse.concourse.concourse.emc2.build/ if you like - this was created using the example setup with some added Traefik ACME config.

this is crazy.. I just reproduced it on a brand new debian:9 box
The exact config files are right here...

https://github.com/starkers/snippets/tree/master/traefik-concourse

Its currently running if you'd like to test although I may switch it to http mode to quickly check

I have the same with
traefik 1.6.2 with acme
concourse 3.14.1
both installed from stable Helm charts.

Encountered this issue today. Same as in previous posts - stuck on "events" API call.

I've noticed when I've disabled compression on https endpoint, the issue disappeared
data:
  traefik.toml: |
    # traefik.toml
    logLevel = "DEBUG"
    defaultEntryPoints = ["http","https"]
    [entryPoints]
      [entryPoints.http]
      address = ":80"
      compress = false
        [entryPoints.http.redirect]
          regex = "^http://(.*)"
          replacement = "https://$1"
      [entryPoints.https]
      address = ":443"
      compress = false
        [entryPoints.https.tls]
          [[entryPoints.https.tls.certificates]]
          CertFile = "/ssl/tls.crt"
          KeyFile = "/ssl/tls.key"
      [entryPoints.traefik]
      address = ":8080"
    [kubernetes]
    [api]
      entryPoint = "traefik"
      dashboard = true

I've noticed when I've disabled compression on https endpoint, the issue disappeared
data:
  traefik.toml: |
    # traefik.toml
    logLevel = "DEBUG"
    defaultEntryPoints = ["http","https"]
    [entryPoints]
      [entryPoints.http]
      address = ":80"
      compress = false
        [entryPoints.http.redirect]
          regex = "^http://(.*)"
          replacement = "https://$1"
      [entryPoints.https]
      address = ":443"
      compress = false
        [entryPoints.https.tls]
          [[entryPoints.https.tls.certificates]]
          CertFile = "/ssl/tls.crt"
          KeyFile = "/ssl/tls.key"
      [entryPoints.traefik]
      address = ":8080"
    [kubernetes]
    [api]
      entryPoint = "traefik"
      dashboard = true

Kubernetes 1.10.8 (minikube)
Traefik 1.6.6 (helm chart stable/traefik 1.43.0)
Concourse 3.14.1 (helm chart stable/concourse 1.3.1)

it's working

Traefik 1.7.3
Same problem. When I set compress = false the issue disappears.

Here is a reproducible case: https://gist.github.com/Overbryd/c07aae9f68f487b0bf699c3ec83998b9
Steps to reproduce:

Download docker-compose.yml
Download config.toml into conf/config.toml
docker-compose up
curl --compress localhost:8080/events stalls

Compare against curl localhost:8080/events which does not stall (note that compression is off for that request).

Hi @Overbryd !
Thank you very much for the stack and steps to reproduce the issue.
I've tried reproducing it using exactly the steps that you provided, and I have been unsuccessful. Both curl commands seem to get a response at the same speed.

I think that I followed the steps correctly, here is my folder's structure:

Let me know if I missed something or if there was a mistake in the gist files and I'll try again :)

@Ullaakut all correct. Mind the trailing slash on your request.
It should be curl --compressed localhost:8080/events/.

Ran into this with Concourse 4.2.1 and Traefik 1.7.4. Took hours to track down.
Steps to reproduce locally:

Set a /etc/hosts entry for <IP_ADDRESS> my.url

Run concourse with:

sudo $(which concourse_linux_amd64) quickstart \
    --worker-work-dir=/tmp/concourse-workers \
    --postgres-user=concourse \
    --postgres-password=somepassword \
    --main-team-local-user concourse \
    --add-local-user concourse:somepassword \
    --external-url http://my.url \
    --worker-garden-dns-server <IP_ADDRESS>

Run traefik with --configfile of:

defaultEntryPoints = ["http"]

[entryPoints]

[entryPoints.http]
address = ":80"
compress = true

[file]

[backends]

[backends.concourse]
[backends.concourse.servers]
[backends.concourse.servers.server0]
url = "http://localhost:8080"

[frontends]

[frontends.concourse]
entrypoints = ["http"]
backend = "concourse"
passHostHeader = true

[frontends.concourse.routes]
[frontends.concourse.routes.route0]
rule = "Host:my.url"

Set up your fly with fly -t ci login --team-name main --concourse-url http://my.url. Follow instructions and log in with credentials above e.g. concourse/somepassword

Execute a build with fly -t ci execute -c <(echo '{"platform": linux, "run": {"path": "ls"}}')

Do the same with/without compress = true. With compression, the build output is not streamed.

I just ran into this issue. For what its worth, I think the size of the payload makes a difference. When I have less than 100 bytes, it shows no data. But when the payload grows bigger then the data shows up.

I just ran into this issue. For what its worth, I think the size of the payload makes a difference. When I have less than 100 bytes, it shows no data. But when the payload grows bigger then the data shows up.

I can see the same behaviour on my setup.

Similar here:
I had a youtrack behind traefik 1.7.
It made a request with "accept: text/event-stream" that stuck on pending state.,.
Setting "compress = false" solved the issue.

Same problem for me, through traefik integrated inside k3s as ingress controller 😓


How can i Integrated with GHE?

Which settings I need to modify to provide the Customized GHE end point for the PRs

This is currently not supported in the most recent version of the extension, but is supported in version 0.15.0. Please see https://github.com/microsoft/vscode-pull-request-github/wiki#2-is-github-enterprise-supported, https://github.com/microsoft/vscode-pull-request-github/issues/1793


Avoid constructing into existing project directory.

Fix for #212.
In the InteractiveCommand the exists directory check should prolly already be done in the projectNameQuestion validator to abort as early as possible. This might require visibility changes of Construct\Construct->saveProjectNames and Construct\Constructors\Src->projectDirectoryExists.

Thanks!


Clsid syntax is invalid

Hello, I have a Softing Opc DA server that works without problems and the connection to the client also works without any problems. However, the connection to node-red does not work. I use Windows 10, the DCOM settings are also made correctly and the PC does not belong to any domain. I keep getting this error no matter what I try.
Can someone please help me and tell me what I did wrong or what you did to make it work?

Can you connect over another OPC DA client like Matrikon Opc Browser in same environment with Node-RED?

I deleted everything (NodeRed etc.) and downloaded it again. Now it works "locally". With these settings.

Still have problems via the network it is probably due to the VMWare or DCOM settings.
Does anyone have a good/working template for the DCOM settings?

It's pretty weird. If I have the source of the OPC data (PLC) on a switch in the network, the data transmitted from the OPC server to NodeRed, works locally but not on another PC in the network. If I connect the PLC to the PC directly, it works too.
(Sketch to aid understanding. Number 1 should work but it doesn't. 2 and 3 works but is not enough.)

i don't think that's a problem with node-red-contrib-opcda-client but maybe someone can help me anyway.


chore: rename StarOrderedRing convenience constructors

StarOrderedRing was recently turned into a Prop mixin. This renames the convenience constructors to adhere to the naming convention for theorems vs. defs.

bors merge


⚠ Bofrost.nl has degraded performance

In 82e6be9, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1723 ms

Resolved: Bofrost.nl performance has improved in 9ff0899.


Dynamic value injection support in CNI config.

Adding this for per-host-subnet feature.
Taking care of comments from original PR: https://github.com/rancher/plugin-manager/pull/76
Original issue: https://github.com/rancher/rancher/issues/9153
Credits: @niusmallnan

LGTM


CountyTag vs. CountryTag

CountyTag vs. CountryTag:
https://github.com/openfoodfacts/openfoodfacts-androidapp/search?q=County

The problem is that the class is an entity, so an update would require a db update, and that's useless for a rename


Porting ModelErrorMessage and ValidationSummary

#189 and ModelErrorMessage

Was there any changes you had to do to the code? If not, then LGTM

minor things w.r.t formatting and getting rid of style guide related error... don't think any risky which needs your attention... so mering.

Sounds good - the rule of thumb I use is get things in as close as possible (deal with formatting and warnings if needed), but any large changes, wait till a follow up so we can easily see (and find later) what changes were made.


Testing

Currently we have ok unit test coverage for quotes, accounts and portfolio (although probably should have more and better ones).
Issues are:

some unit tests are not really unit tests as they call out to external services. these should be contained to code.
no integration testing

Building a CI pipeline using concourse, so probably a good idea to have more automated testing as this will allow to release more often.

It would be good if we could have integration testing for each service and also some end-2-end testing (maybe with selenium???)

Test comment from Martin


webdev server error dart:not found

Looks like you don't have dart on your $PATH... if it is there, maybe restart your terminal session.

Thanks ,It need dart on $PATH

this is my setting for flutter_web

FLUTTER_PATH=/usr/local/src/flutter/bin
PUB_CACHE_BIN=$ULS/flutter/.pub-cache/bin
DART_PATH=/usr/local/src/flutter/bin/cache/dart-sdk/bin
export PATH=$PATH:$FLUTTER_PATH:$PUB_CACHE_BIN:$DART_PATH

offical link

@wmwgithub – did you resolve your issue?

yes,I resolve the problem and run the official example successful

In my opinion, it should be part of the Getting Started section. I encountered the same problem because I was under the assumption that just by installing the Flutter SDK would be enough.

Reopening – the docs should be better here!

Problems
> webdev build
Unhandled exception:
ProcessException: ***OUT***

***ERR***
The Flutter SDK is not available.

***
  Command: C:\SDK\flutter\bin\cache\dart-sdk\bin\pub.bat deps
#0      _runPubDeps (package:webdev/src/pubspec.dart:70:5)
<asynchronous suspension>
#1      PubspecLock.read (package:webdev/src/pubspec.dart:84:11)
<asynchronous suspension>
#2      readPubspecLock (package:webdev/src/command/shared.dart:62:39)
<asynchronous suspension>
#3      BuildCommand.run (package:webdev/src/command/build_command.dart:50:29)
<asynchronous suspension>
#4      CommandRunner.runCommand (package:args/command_runner.dart:196:27)
<asynchronous suspension>
#5      _CommandRunner.runCommand (package:webdev/src/webdev_command_runner.dart:38:24)
<asynchronous suspension>
#6      CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:111:29)
#7      new Future.sync (dart:async/future.dart:224:31)
#8      CommandRunner.run (package:args/command_runner.dart:111:11)
#9      run (package:webdev/src/webdev_command_runner.dart:19:56)
#10     main (file:///C:/Users/yk/AppData/Roaming/Pub/Cache/hosted/pub.dartlang.org/webdev-2.0.4/bin/webdev.dart:17:22)
<asynchronous suspension>
#11     _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:298:32)
#12     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:171:12)

@yousifk do you have both the Flutter and Dart SDKs installed?

@kevmoo I've yet to test on a clean environment, but I suspect that debugging with an IDEs plugin (VS Code, IntelliJ, etc.) works right out-of-the-box without installing Dart SDK. However, running the command in a Terminal fails (as noted in this thread).
Ultimately, the problem lies with the documentation, in my opinion. 😅

Thanks ,It need dart on $PATH

this is my setting for flutter_web

FLUTTER_PATH=/usr/local/src/flutter/bin
PUB_CACHE_BIN=$ULS/flutter/.pub-cache/bin
DART_PATH=/usr/local/src/flutter/bin/cache/dart-sdk/bin
export PATH=$PATH:$FLUTTER_PATH:$PUB_CACHE_BIN:$DART_PATH

offical link

Thanks. I't work for me.

Added all of them to path


Reimplement markdown (Issue #135)

I linked markdown to messages currently sent by user as well as those fetched from server. I also updated version of markdown in script tag in html file.

Hey @KossakowskaKarolina, can you attach screenshots/gifs/videos which show Markdown working in your locally hosted clone?


checkov: 3.2.208 -> 3.2.209

Diff: https://github.com/bridgecrewio/checkov/compare/refs/tags/3.2.208...3.2.209
Changelog: https://github.com/bridgecrewio/checkov/releases/tag/3.2.209
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 330686 run on x86_64-linux 1

3 packages built:

checkov
checkov.dist
nixpkgs-manual


Fixes #5609 -- ToolbarMiddleWare should clear menu-caches respecting current Site and language

see issue #5609

Hello @heppstux ,
Thank you very much for the patch.
Please add tests to the test_menu.py file
Also don't forget to add a changelog entry under 3.3.3 (unreleased) http://docs.django-cms.org/en/release-3.3.x/contributing/development-policies.html#changelog.
Should be something like "Fixed bug where menu cache was not cleared for the current site".

Having a closer look at the patch, it's a bit unclear how it fixes the issue.
menu_pool.clear() will clear the cache for all sites/languages which I think was intended behavior given that you can render menu nodes from different sites.
I think the real issue is #5310.

Closing as this issue is covered in https://github.com/divio/django-cms/issues/5310


Search

Fuzzy finding on the list of images. It could do more work but this is what I have so far.
I should have submitted an Issue first, but I was a bit enthusiastic, I hope you like it.

@omer-biz
I like this PR very much! Thanks!


Node v16 Support

It is unclear from your documentation if you support profiling apps running Node 16.0.0 or higher running on the 16.x branch. Do you know if you support Node v16 profiling and if not, do you know when you will?

Yes, it is the team's intention to support node v16.
Updating the tests to test against node 16 is on my things to do. I hope to work on this within 1-2 weeks, but can't really commit to it because there are other things on my plate now.
Looks like the document also needs to be updated; thanks for pointing that out.

Node v16 support would be really great. Is there any update on this?

I made some progress updating some tests, but I'm not there yet.
The work includes deprecating old versions of Node too, so it's a bit more than I originally expected.

Any news on the progress of supporting Node 16? Are you planning to also support Node 18? As it's expected to be LTS on 2022-10-25

Sorry it's taking a while. I'll try to pick this up if I have some available cycles.
Adding support for node 16 should be straightforward. For node 18, it's more complicated.

Any news on the progress? Isn't now February 2023 and I am not sure if it is supported or not.

Does it support Node 20? It's going to be the new LTS in a month

Node 20 is already supported. If you're seeing a specific issue, please open a new bug with details. I am making another release now and will update the docs to make this clear.


Y24-013 [BUG] Sequencescape does not show request metadata fields

Describe the bug
Sequencescape shows Unlabelled field instead of request metadata keys. For example,

cDNA Prep request in https://uat.sequencescape.psd.sanger.ac.uk/requests/19126986
Limber PCR Bespoke in Production https://sequencescape.psd.sanger.ac.uk/requests/28159555

RT Ticket Number
N/A
To Reproduce
Steps to reproduce the behaviour:
This might be occurring in submissions with sequential multiple request types. Follow the example links above.
Update: After scRNA donor pooling submission unified request types into one, the issue is still there. The assumption of sequential multiple request types is not correct. https://uat.sequencescape.psd.sanger.ac.uk/requests/19198890
Expected behaviour
It should show keys shown in the following query instead.
Request.find(19126986).request_metadata.field_infos.map(&:key)
=>
[:customer_accepts_responsibility,
 :fragment_size_required_from,
 :fragment_size_required_to,
 :gigabases_expected,
 :library_type,
 :pcr_cycles]

Screenshots
Limber PCR Bespoke request in Production: https://sequencescape.psd.sanger.ac.uk/requests/28159555

scRNA Core cDNA Prep request in UAT: https://uat.sequencescape.psd.sanger.ac.uk/requests/19126986

Desktop (please complete the following information):
N/A
Additional context
This was discovered in UAT testing of DPL-913 https://github.com/sanger/sequencescape/issues/3900

So for now, there's a PR which has a hacky fix for this. In this particular case, the key isn't being returned, so instead of creating a view that joins the key-values (plain_value(), it will now just directly join the two.
As for why it's happening, not a clue. I don't think finding exactly why this is happening will resolve anything because this method is used a lot and seems to be working fine, so this specific instance is just being odd. Not sure if it's worth the time to explore why it's not working though.


please help for this error from past 1 week im getting like this

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: react-scripts start
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\AnithaHR\AppData\Roaming\npm-cache_logs\2019-07-25T12_06_26_330Z-debug.log

can you please post logs of it @karthikTshetty

when i enter the command (rm -rf node_modules)
it shows like this,
'rm' is not recognized as an internal or external command,
operable program or batch file.

rm -rf node_modules deletes a directory completely on unix based systems. Since you're using Windows, just delete node_modules directory completely. Windows now supports Linux subsystem or you also can use cygwin. Try to search: how to install linux bash shell on windows

Hi all, I'd like to direct you to our new Spectrum community for questions like this: https://spectrum.chat/create-react-app/general?tab=posts
In this case, I think that @ARKKYN and @message are right - remove your node modules and reinstall :)
On Windows, rm -rf can be substituted with rmdir.

npm ERR! missing script: start
npm ERR!      C:\Users\AnithaHR\AppData\Roaming\npm-cache_logs\2019-07-31T05_36_15_723Z-debug.log

please check package.json for "start" under scripts if "start" is not there then you need to add a command for it or else try to post the file here @karthikTshetty

npm ERR! missing script: start
npm ERR!  C:\Users\AnithaHR\AppData\Roaming\npm-cache_logs\2019-07-31T05_36_15_723Z-debug.log

I have the same problem. Still dont know what to do :/


Adds class renames for downstream Clocker project

It feels like this should be an override in downstream projects, rather than in Brooklyn itself. Do you want to close this?
As discussed with @nakomis offline, a longer-term change we want to make is... instead of a single deserializingClassRenames.properties, we'd like to pick up multiple files so that downstream projects can be additive.
We could have a '/brooklyn/deserializingClassRenames' resource folder. For any .properties file inside that folder (how ever it was added to the classpath), we'd load it and include it in the renames.
We could also do multiple calls to rename for a given class, until the name became stable (or an infinite loop was detected!). Then we can have separate files for 0.7.0->0.8.0, 0.8.0->0.9.0.
Not sure how that would working with OSGi with Karaf @neykov ? What different configuration mechanism would we use, instead of searching the classpath?

@nakomis did we conclude that this was the responsibility of downstream projects, and that working on https://github.com/apache/brooklyn-server/pull/144 was the right way to go?
If so, can you please close this PR.

@nakomis do you want to close this PR, while we discuss https://github.com/apache/brooklyn-server/pull/144?


Make ClientError a subclass of BotoCoreError and allow pickling of exception classes

Fix #834, fix #899.

FTR, being able to pickle exceptions is usful for example when using boto3/botocore with Celery tasks whose exception handling can use pickle to store the exception in case one is raised when a task is executed.

Codecov Report

Merging #1191 into develop will decrease coverage by <.01%.
The diff coverage is 96.29%.

@@             Coverage Diff             @@
##           develop    #1191      +/-   ##
===========================================
- Coverage       98%   97.99%   -0.01%
===========================================
  Files           45       45
  Lines         7277     7298      +21
===========================================
+ Hits          7132     7152      +20
- Misses         145      146       +1

Impacted Files
Coverage Δ

botocore/errorfactory.py
100% <100%> (ø)
:arrow_up:

botocore/exceptions.py
99.2% <88.88%> (-0.8%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ca9e03...7b17311. Read the comment docs.

@kyleknap Any time to review this?

Or @dstufft (hello!) for that matter?

I don't think we can pull this in because it would be a breaking change for anybody catching BotocoreError.

@JordonPhillips I'm not sure I follow, BotocoreError continues to exist. Would you mind elaborating the case for which this would be a breaking change?

Anywhere a user is catching BotocoreError they would suddenly be catching a whole new class of errors. Anywhere a user is only catching a ClientError there would be no issue. Anywhere a user is catching both and performing different actions there may be a breaking change depending on the ordering of the catches. Something like the following would break:
try:
    client.service_call()
except BotocoreError:
    # panic
except ClientError:
    # show error to user

@jezdez   He means you try for a way to make ClientError picklable, without making it a subclass of BotocoreError.

IMO it's a mistake that ClientError and BotocoreError don't have some common, picklable ancestor.  We should have something like this instead
Exception
└── BotocoreErrorForRealsThisTime
    ├── BotocoreError
    └── ClientError

I like the idea of making a common ancestor for BotocoreError and ClientError. Perhaps something like BaseBotocoreError or something.

My problem is that EndpointConnectionError exceptions can't be pickled.
Is that an entirely separate problem? ...considering that EndpointConnectionError inherits from BotoCoreError and ClientError inherits from Exception.

For anybody else stumbling on this and can't wait, I just did the following:
class OwnClientError(ClientError):  # XXX Replace "Own" with "Picklable" ?
    """Because the botocore.exceptions.EndpointConnectionError can't be
    pickled, if this exception happens during task work, celery
    won't be able to pickle it. So we write our own.

    See https://github.com/boto/botocore/pull/1191
    """

    def __reduce__(self):
        return (
            self.__class__,
            (self.response, self.operation_name),
            {},
        )

def reraise_clienterrors(f):
    """Decorator whose whole job is to re-raise any ClientError
    exceptions raised to be OwnClientError because those
    exceptions are "better". In other words, if, instead an
    OwnClientError exception is raised by the task
    celery can then pickle the error. And if it can pickle the error
    it can apply its 'autoretry_for' magic.
    """

    @wraps(f)
    def wrapper(*args, **kwargs):
        try:
            return f(*args, **kwargs)
        except ClientError as exception:
            raise OwnClientError(exception.response, exception.operation_name)
    return wrapper

@shared_task(autoretry_for=(
    ConnectionError,
    OwnClientError,
))
@reraise_clienterrors
def upload_inbox_upload(upload_id):
    # ...the celery task...

Seems to work for now.

btw, can you make sure the callstack gets pickled as well?  This is an issue with the version I created where the callstack doesn't get printed with logger.exception from the parent process.

Is this ever going to get resolved? It makes working with boto3 and celery rather frustrating.

Perhaps a way to allow those chains to remain intact would be to add a new class that's mixed in to BotoCoreError, ClientError, etc, such as AnyBotoCoreError that would leave existing except ClientError / except BotoCoreError chains intact while letting new code have a catchall.

Closing since #1596 at least fixed the pickling issue.


Using my own application id requires admin approval

Hi,
When I use your application id and click sign in with an account everything works as expected
If I put my own application id created using your instructions, than during sign-in it requires admin approval saying;

This app may be risky. If you trust this app, please ask your admin to grant you access

Any ideas?
Regards,

Hi @sinag
Most probably you're using v2 app, switch to v1 app id and secret, grant necessary permissions once.

what do you you mean switching to v1?
What I did was File->New Session->Use my application button

sorry I was thinking that you're using Api Editor, not Mailbox Viewer

Delegated permissions or application permissions?

To be more specific about the problem;
I have an account<EMAIL_ADDRESS>which is from an azure active directory on a tenant and is using exchange online.
With this account, I can login with File->New Session->Sign-in
But if I try to use my own application id, which I have created with another trial personel account, than it requires admin approval from "yyy.com"

@sinag
It seems that sign-in using your app (your application ID) is detected as a risky end-user consent request.
https://docs.microsoft.com/en-us/azure/active-directory/manage-apps/configure-user-consent?tabs=azure-portal#risk-based-step-up-consent
I could not repro the issue, and we have no way to know why your application ID is detected. Unfortunately, we can do nothing from the application side.

great info thanks
my application's domain is not a verified domain, my guess is this could be an issue
what about disabling risk-based step-up consent?
according to my scenario this should be done on "yyy.com" side i guess

Yes. If you want to disable risk-based step-up consent, you need to do it in the tenant which the end-user belongs to.
Though I'm not an Azure AD expert, I think disabling risk-based step-up consent is not recommended for security reasons.


cmd/go: go mod init fails to determine module path in subdirectory

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.11
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
❯ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/andig/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/andig/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.11/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.11/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/andig/htdocs/goelster/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/73/89ycv7qn51j4kbm04jsz9b840000gn/T/go-build453007721=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
Trying to init go modules, I'm seing it fail from one folder but working from another. Both folders only contain two simple go files:
~/htdocs/canprogs/go master*
❯ go mod init
go: cannot determine module path for source directory /Users/andig/htdocs/canprogs/go (outside GOPATH, no import comments)

~/htdocs/goelster master
❯ go mod init
go: creating new go.mod: module github.com/andig/goelster

❯ ls
elster.go main.go

Please attach the output of go env (as requested by the issue template).

Which directory (if any) is at the root of your VCS checkout, and what is your GOPATH?

Please attach the output of go env

Sorry, only noticed the "operating system" question, added go env above. ~/htdocs/canprogs is a git root, so is ~/htdocs/goelster. Neither is part of the gopath.

@bcmills I see this has been scheduled- seems I've hit an actual issue here?

Have you tried go mod init <module_name>? (e.g. go mod init goelster)

That creates a go.mod:
❯ go mod init goelster
go: creating new go.mod: module goelster

❯ cat go.mod
module goelster

is this the expected behavior?

go mod init with no arguments does it's best to determine a module path if the current directory belongs to a VCS repository that has a remote:
$ cd $(mktemp -d)
$ git init
Initialized empty Git repository in /tmp/tmp.T8elQyoqel/.git/
$ git remote add origin https://github.com/myitcv/gobin
$ go mod init
go: creating new go.mod: module github.com/myitcv/gobin

You can alternatively provide an explicit argument, as you outlined in https://github.com/golang/go/issues/27951#issuecomment-429533293.
The bug you correctly identified is that go mod init with no arguments does not do the correct thing in a subdirectory of the VCS repo root:
$ mkdir inner
$ cd inner
$ go mod init
go: cannot determine module path for source directory /tmp/tmp.T8elQyoqel/inner (outside GOPATH, no import comments)

It seems to me that go mod init is completely dependent on the existence of a git remote named "origin". I got the OP's output here because I only had the origins "upstream" and "rfay". Once I added an "origin" (equivalent to upstream), then go mod init worked. This doesn't seem like the behavior I'd expect.

This doesn't seem like the behavior I'd expect.

@rfay - what behaviour would you expect if there are multiple remotes?
Having go mod init specifically look for a remote called origin seems like a reasonable starting point on the basis:

this is the default remote name used by GitHub and Gitlab
it allows things to work where there are multiple remotes (else, which remote would it choose?)

The remote name "origin" is absolutely arbitrary (although ever-so-widely used), and should not be a fundamental assumption. Just a --remote= arg would solve the problem and make it explicit that go mod init is dependent on the remote (and on a specific named remote). It would be fine for "origin" to be the default.

@rfay

should not be a fundamental assumption
...
Just a --remote= arg would solve the problem and make it explicit that go mod init is dependent on the remote

go mod init is documented as follows:
usage: go mod init [module]

Init initializes and writes a new go.mod to the current directory,
in effect creating a new module rooted at the current directory.
The file go.mod must not already exist.
If possible, init will guess the module path from import comments
(see 'go help importpath') or from version control configuration.
To override this guess, supply the module path as an argument.

Therefore, I don't think it's accurate to describe go mod init as being dependent on the remote configuration. Nor do I think we can describe the searching for a git remote called "origin" as a fundamental assumption. With no module path provided, go mod init's behaviour is, at best, a guess. And if the guess is bad you can supply the module path.
go mod init with zero arguments is not, I suspect, going to be a command that people run every day. Indeed I suspect the most common use of go mod init with no args will be converting from another dependency management solution to Go Modules.
Hence to my mind the current behaviour of go mod init is good enough. More flags, config options etc run the risk of bloating what is a very basic command.
But I'll leave this for @rsc and @bcmills to opine.

It's good enough for people who already know the idiosyncrasy, not good enough for n00bs like me coming from dep. There will be lots of n00bs.

Being new to go mod, I run into the exact same issue today. It did take me a while googling, with the right combination of key words to finally land in here. The documentation makes sense to me and I'm OK with the implicit dependency of go mod and git. However, I'd suggest (at least) make the error message more meaningful or explicit. It will save quite a bit of time for n00bs. Cheers,

This has bitten me for the second time today. Needs a meaningful error message at the very least

The original issue here seems to rely on the "last resort" guessing the module import path, by detecting a git repo that has a remote named origin pointing to  github.com (see: modload/init.go#L562).
What makes it work in one folder and not the other, is because the detection  looks in the current directory for .git/config, not recursively up the directory hierarchy (as the git tool does).
I agree that instead extending and complicating (bloating, as @myitcv says) the guesswork that go mod init does, the way to go is to provide more expressive and helpful message that can point the novice user in the right direction. Otherwise, should it be tough how to recurse for .git/config, and then further to handle other the VCS (hosting) systems that Go supports elsewhere?
I find this helpful: https://github.com/golang/go/wiki/Modules#quick-start
But a message should probably not link that?
Should go help mod init be more verbose? I don't find it very helpful currently. Then the message could point to that.

I changed the wording of the message in CL 166319 to fix #30678 (which I think is a duplicate of this). It now says "cannot determine module path for source directory %s (outside GOPATH, module path not specified)". This suggests that a module path should be specified explicitly without being too wordy.
Is this enough info, or should go help mod init be expanded as well? It's pretty brief, but I don't think anything important is missing.
It would be feasible to walk up parent directories, looking at .git/config, but in my opinion, it's too magical, especially for modules that aren't at the repo root, which require a great deal of care and consideration.
I don't think other VCS support can be added here; the .git/config special case is just for GitHub, not even git in general.

maybe a hint towards the correct command?
cannot guess module path for source directory ...
try specifying module path explicitly:

    go mod init <PATH>

I'd :+1: for expanding go help mod init as an alternative.

go get is supporting several VCS including other git platforms. It is unclear from the online documentation about modules and its FAQ answer that support seems currently limited to github as the regex and its use above implies. Mentioning the current limit would improve the understanding of the message.

@iWdGo, to be honest, I'm not sure that inferring github.com paths is really the right behavior either. Some of those are served through other import paths (via redirects and/or <meta> tags), so go mod init can very easily pick the wrong path.
The right solution might be to remove the github.com special-case and always require an explicit path when outside of GOPATH.

I agree that best effort to locate path is confusing and removal seems most appropriate.
A default value set to the folder name where the module resides could be considered but might be the subject of a separate issue. The behavior would become similar to the $GOPATH related code which sets a value  only when the module resides in $GOPATH/src/<module-path>
The discussed message would be irrelevant and could be replaced with "default module path set to ".

I have been able to resolve this with code in a repo subdir with
go mod init `pwd`

Surely this can be automated?!

I have been able to resolve this with code in a repo subdir with
go mod init `pwd`

This solved it for me! Thank you @joshuamkite!!

Or:
go mod init .

will solve this issue.

I have been able to resolve this with code in a repo subdir with
go mod init `pwd`

Surely this can be automated?!

This solved for me too. Thanks!!

why is go mod init pwd solved? why?

go mod init `pwd` is highly unlikely to be correct: the argument to go mod init is a module path, but pwd is generally an absolute filesystem path. (See #28389.)
If the go command cannot determine an appropriate module path, the general solution is no pass one explicitly. See https://golang.org/cmd/go/#hdr-Defining_a_module and https://blog.golang.org/using-go-modules.


Create a new data class named Question.kt

You have to create a new data class named Question.kt and add the following val's inside it ->
id -> type int
question -> type string
optionOne -> type string
optionTwo -> type string
optionThree -> type string
optionFour -> type string
correctOption -> type int
This data class will be used later while setting up the questions for our quizzes.

Claim


Remove Unnecessary Attributes from Manifest

Your library has an AndroidManifest.file with this content at present:
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    package="com.github.polok.flipview">

    <application android:allowBackup="true"
        android:label="@string/app_name"
        android:icon="@drawable/ic_launcher">

    </application>

</manifest>

That will cause build errors for anyone using your library that has attributes that differ from the values that you have defined on the <application> element. Moreover, your library should not be caring about any of those attribute values, as far as I can tell.
If possible, please remove the attributes from the <application> element.
Thanks!

Hi please remove the ic_launcher icon used in the library no point having that ... its a conflict while using other libraries so please change the icon name or remove it.

Done. New version 1.0.1 should be visible in few hours after maven central sync.


Installment widget errors on Shopify

Hi there,
I just implemented the installment widget in a Shopify checkout and wanted to highlight a number or errors I ran into.
I've fixed the issues in my own implementation, so I don't require any response, just thought you would want to know about these.
Shopify-specific implementation
On line 9:
// let sezzlePaymentLine = document.querySelector('[alt="Sezzle Staging"]').parentElement.parentElement.parentElement; //Shopify

This element does not exist in the Shopify checkout -- is the "Staging" part of "Sezzle Staging" a typo?
Browser support

IE 10 and lower do not support the let keyword
IE 11 and lower do not support template strings

I know, I don't want to support IE either, but some customers do use these browsers and I imagine other retailers will need to support these browsers at checkout

Thank you for the insights - I have added these changes for the next release.


Site variable not accepted

Environment variable:
DD_SITE=datadoghq.com

Produces error:
The variable site in the server URL has invalid value datadoghq.com.
Version: com.datadoghq:datadog-api-client:1.0.0
Java/Spring Application
Per the documentation: https://docs.datadoghq.com/api/latest/metrics/
Not specifying the site, and I assume leaving the library to default, results in:
com.datadog.api.v1.client.ApiException<EMAIL_ADDRESS>

Hi,
If you use the US site you don't need to specify the site, though it should work. Can you try with quotes DD_SITE="datadoghq.com"? You do need to specify an API key to be able to use the API too.

Oh bummer, this is some kind of quirk with environment files and Spring/gradle. It imports with the quotes included and the 403's were because the API Key had quotes. If the response was a proper 401 Unauthorized I would have looked there. Thanks.


[Mondrian] Update status line info format

This commit modifies status line output format with the following upgrades:

Trim very long origin names to the maximum of 32 characters
Display block lifetime using alive_from -> alive_till (total size) format.

ONE-vscode-DCO-1.0-Signed-off-by: Alexander Moiseev<EMAIL_ADDRESS>

I like this PR.
One little concern is,
what if lengths of most nodes are very long and the first 32 chars of nodes are almost same.
I saw such situation when I worked on circle models from some Tensorflow language models.

I will wait the response for https://github.com/Samsung/ONE-vscode/pull/1065#issuecomment-1189706321 :)

@hyunsik-yoon @llFreetimell The idea is to introduce a new UI element, a side panel accessible on node click to display all of the node metadata in a similar way that Netron does:

I can implement this UI and merge it first so this PR will not break current usage for longer origins. On-click side panel has several advantages over an on-hover status bar - it allows to select and copy values, has enough space for origin of any length (the need for value trimming in the status bar came after implementation of backend origin info exporter, where nodes contained origins with 1000+ symbol length).

@ai-moiseev Thanks for the explanation. I am looking forward to seeing the new UI!


build: Implement BOM dependency management

tl;dr:

pom.xml now inherits protocol-toolkit-bom for dependency management

Explicit versions of common dependencies and plugins have been removed

artifactId has been changed to modifiable-variable to comply with maven guidelines

Expand compilation log
Build Log
last 200 lines
GitHub pull request #90 of commit d97e656c0b956429b7dca89eb77e2b3b3ae181d9, no merge conflicts.
Running as SYSTEM
Setting status of d97e656c0b956429b7dca89eb77e2b3b3ae181d9 to PENDING with url http://hydrogen.cloud.nds.rub.de/job/Pull%20Request%20Builder%20Jobs/job/ModifiableVariable-PR/41/ and message: 'Build started for merge commit.'
Building on the built-in node in workspace /var/lib/jenkins/workspace/Pull Request Builder Jobs/ModifiableVariable-PR
The recommended git tool is: NONE
using credential 503f4883-9e31-48f9-b1cc-809f6ad8ecd3
> git rev-parse --resolve-git-dir /var/lib/jenkins/workspace/Pull Request Builder Jobs/ModifiableVariable-PR/.git # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/RUB-NDS/ModifiableVariable # timeout=10
Fetching upstream changes from https://github.com/RUB-NDS/ModifiableVariable
> git --version # timeout=10
> git --version # 'git version 2.25.1'
using GIT_ASKPASS to set credentials Github login
> git fetch --tags --force --progress -- https://github.com/RUB-NDS/ModifiableVariable +refs/pull/*:refs/remotes/origin/pr/* # timeout=10
> git rev-parse refs/remotes/origin/pr/90/merge^{commit} # timeout=10
Checking out Revision 31a4460bc9b4710e8fa26d815602df72bf3ef629 (refs/remotes/origin/pr/90/merge)
> git config core.sparsecheckout # timeout=10
> git checkout -f 31a4460bc9b4710e8fa26d815602df72bf3ef629 # timeout=10
Commit message: "Merge d97e656c0b956429b7dca89eb77e2b3b3ae181d9 into aa3b3090388fb8d89d66a42ca31c58a20609b981"
First time build. Skipping changelog.
[Checks API] No suitable checks publisher found.
[ModifiableVariable-PR] $ mvn license:check formatter:validate clean install
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for de.rub.nds:modifiable-variable:3.6.0-SNAPSHOT: Failure to find de.rub.nds:protocol-toolkit-bom:pom:1.0.0 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced and 'parent.relativePath' points at wrong local POM @ line 4, column 13
@
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project de.rub.nds:modifiable-variable:3.6.0-SNAPSHOT (/var/lib/jenkins/workspace/Pull Request Builder Jobs/ModifiableVariable-PR/pom.xml) has 1 error
[ERROR]     Non-resolvable parent POM for de.rub.nds:modifiable-variable:3.6.0-SNAPSHOT: Failure to find de.rub.nds:protocol-toolkit-bom:pom:1.0.0 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced and 'parent.relativePath' points at wrong local POM @ line 4, column 13 -> [Help 2]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException
Build step 'Invoke top-level Maven targets' marked build as failure
[Checks API] No suitable checks publisher found.
Setting status of d97e656c0b956429b7dca89eb77e2b3b3ae181d9 to FAILURE with url http://hydrogen.cloud.nds.rub.de/job/Pull%20Request%20Builder%20Jobs/job/ModifiableVariable-PR/41/ and message: 'Build finished. '

The Jenkins build fails because protocol-toolkit-bom isn't available in the local repository nor maven central. The internal nexus repository does not seem to be configured for jenkins (yet).

Expand compilation log
Build Log
last 200 lines
GitHub pull request #90 of commit 4b0c90fd2857b153535eb7ce83dc6bed4616e89e, no merge conflicts.
Running as SYSTEM
Setting status of 4b0c90fd2857b153535eb7ce83dc6bed4616e89e to PENDING with url http://hydrogen.cloud.nds.rub.de/job/Pull%20Request%20Builder%20Jobs/job/ModifiableVariable-PR/42/ and message: 'Build started for merge commit.'
Building on the built-in node in workspace /var/lib/jenkins/workspace/Pull Request Builder Jobs/ModifiableVariable-PR
The recommended git tool is: NONE
using credential 503f4883-9e31-48f9-b1cc-809f6ad8ecd3
> git rev-parse --resolve-git-dir /var/lib/jenkins/workspace/Pull Request Builder Jobs/ModifiableVariable-PR/.git # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/RUB-NDS/ModifiableVariable # timeout=10
Fetching upstream changes from https://github.com/RUB-NDS/ModifiableVariable
> git --version # timeout=10
> git --version # 'git version 2.25.1'
using GIT_ASKPASS to set credentials Github login
> git fetch --tags --force --progress -- https://github.com/RUB-NDS/ModifiableVariable +refs/pull/*:refs/remotes/origin/pr/* # timeout=10
> git rev-parse refs/remotes/origin/pr/90/merge^{commit} # timeout=10
Checking out Revision 3cd26ee3a68535fa1b40828954c9d9ce5f4bd5ae (refs/remotes/origin/pr/90/merge)
> git config core.sparsecheckout # timeout=10
> git checkout -f 3cd26ee3a68535fa1b40828954c9d9ce5f4bd5ae # timeout=10
Commit message: "Merge 4b0c90fd2857b153535eb7ce83dc6bed4616e89e into aa3b3090388fb8d89d66a42ca31c58a20609b981"
First time build. Skipping changelog.
[Checks API] No suitable checks publisher found.
[ModifiableVariable-PR] $ mvn license:check formatter:validate clean install
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/usr/share/maven/lib/guice.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
[INFO] Scanning for projects...
Downloading from central: https://repo.maven.apache.org/maven2/de/rub/nds/protocol-toolkit-bom/1.0.1/protocol-toolkit-bom-1.0.1.pom
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for de.rub.nds:modifiable-variable:3.6.0-SNAPSHOT: Could not find artifact de.rub.nds:protocol-toolkit-bom:pom:1.0.1 in central (https://repo.maven.apache.org/maven2) and 'parent.relativePath' points at wrong local POM @ line 4, column 13
@
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project de.rub.nds:modifiable-variable:3.6.0-SNAPSHOT (/var/lib/jenkins/workspace/Pull Request Builder Jobs/ModifiableVariable-PR/pom.xml) has 1 error
[ERROR]     Non-resolvable parent POM for de.rub.nds:modifiable-variable:3.6.0-SNAPSHOT: Could not find artifact de.rub.nds:protocol-toolkit-bom:pom:1.0.1 in central (https://repo.maven.apache.org/maven2) and 'parent.relativePath' points at wrong local POM @ line 4, column 13 -> [Help 2]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException
Build step 'Invoke top-level Maven targets' marked build as failure
[Checks API] No suitable checks publisher found.
Setting status of 4b0c90fd2857b153535eb7ce83dc6bed4616e89e to FAILURE with url http://hydrogen.cloud.nds.rub.de/job/Pull%20Request%20Builder%20Jobs/job/ModifiableVariable-PR/42/ and message: 'Build finished. '

retest this please

Jenkins is now able to resolve artifacts from the internal Nexus repository. However, I'd like to integrate the maven-flatten-plugin before merging this into master. So don't merge this yet.


[ENH] Create Docker container

This should hopefully make the toolbox available across more platforms, including Windows.

Also added it to the docs in commit 31d8c58fd727e53aa28ecd9bf85571587bd4d52c.

I will close this issue for now since Docker containers are now available and work (on linux systems that I've tested), but more testing of the current Docker containers is needed on different platforms.


Improved Heroku deploy section in the readme

Made several improvements to the Heroku portion of the readme 😄

I appreciate the updates @Macley-Kun and @codeinteger6 ! One small change - the PR should be into dev rather than master if you don't mind

Done #112

I wasn't aware we were gonna update the readme :P ... Still great work haha


froxen

not working stcuk on  the title

same here, maybe theres a problem, or outlook have patched the system.

same here

Hello guys , outlook patched it , there are a paid version for now ( you can buy it by talking with me on discord / tg )
or just wait for a free update when this repo reach 100 stars .
Regards.


docker-compose.yml cant start Tempo

Description
When trying to start docker from docker-compose.yml there is a problem starting Tempo service.
failed parsing config: failed to parse configFile /etc/tempo-config/tempo.yaml: yaml: unmarshal errors:
  line 1: field metrics_generator_enabled not found in type app.Config
  line 2: field search_enabled not found in type app.Config
  line 52: field index_downsample_bytes not found in type common.BlockConfig
  line 53: field encoding not found in type common.BlockConfig
  line 56: field encoding not found in type wal.Config

Steps to reproduce

Copy repo
Run docker compose up -d

Expected behavior
All services run
Actual behavior
Tempo is not working
Environment
Latest main branch

Working tempo config is below
server:
  http_listen_port: ${TEMPO_PORT}

distributor:
  receivers: # this configuration will listen on all ports and protocols that tempo is capable of.
    jaeger: # the receives all come from the OpenTelemetry collector.  more configuration information can
      protocols: # be found there: https://github.com/open-telemetry/opentelemetry-collector/tree/main/receiver
        thrift_http: #
        grpc: # for a production deployment you should only enable the receivers you need!
        thrift_binary:
        thrift_compact:
    zipkin:
    otlp:
      protocols:
        http:
        grpc:
    opencensus:

ingester:
  trace_idle_period: '10s' # the length of time after a trace has not received spans to consider it complete and flush it
  max_block_bytes: 1_000_000 # cut the head block when it hits this size or ...
  max_block_duration: '5m' #   this much time passes

compactor:
  compaction:
    compaction_window: '1h' # blocks in this time window will be compacted together
    max_block_bytes: 100_000_000 # maximum size of compacted blocks
    block_retention: '24h'
    compacted_block_retention: '10m'

metrics_generator:
  registry:
    external_labels:
      source: 'tempo'
      cluster: '${DEMO_PACKAGE_NAME}'
  storage:
    path: '/tmp/tempo/generator/wal'
    remote_write:
      - url: 'http://${CORTEX_HOST}:${CORTEX_PORT}/api/v1/push'
        send_exemplars: true

storage:
  trace:
    backend: 'local' # backend configuration to use
    block:
      bloom_filter_false_positive: .05 # bloom filter false positive rate.  lower values create larger filters but fewer false positives
    wal:
      path: '/tmp/tempo/wal' # where to store the the wal locally
    local:
      path: '/tmp/tempo/blocks'
    pool:
      max_workers: 100 # worker pool determines the number of parallel requests to the object store backend
      queue_depth: 10000

overrides:
  metrics_generator_processors:
    - 'service-graphs'
    - 'span-metrics'


Rename Symbol goes to undesired places

From @Spown on June 9, 2016 14:18

VSCode Version: 1.2.0
OS Version: Win10x64

Rename Symbol can wander off into files, that are undesired to change. Just now I had several lines using __dirname global variable, I decided to use an another user defined variable settings.paths.root and used Rename Symbol it worked fine, except it also went into .\typings\node\node.d.ts and changed it there as well... This happens even if I exclude the typings dir in .vscode\settings.json
Copied from original issue: Microsoft/vscode#7478

Rename operation is provided by the TS server. Moving...

closing in favor of https://github.com/Microsoft/TypeScript/issues/8227


Great work! May I ask if you have considered adding the bbox of the element executed by the action on the image to the data set, which is quite useful for the CV based methods.

Like the red bbox here:

Yes the bboxes/bbox-*.json are part of the dataset (see weblinx-full on huggingface) which map an element id to coordinates. the target element id can be found in the metadata.json. If you want a tutorial you can check out the modeling/llama/eval.py or the new colab notebook: https://colab.research.google.com/github/McGill-NLP/weblinx/blob/main/examples/WebLINX_Colab_Notebook.ipynb


Implementation of bandit_output_format

It would be great to have a way to output a JSON report for Sonar to pick up
https://docs.sonarqube.org/display/PLUG/Import+Bandit+Issues+Reports

Although the helptext of bandit_ini does not specify (CURRENTLY NOT IMPLEMENTED), it seems to not be passed on either :)

Hi! I just opened a PR.
I'm open to comments, I'm mostly unconvinced myself on the "screen" file format.
The way it does the "default" screen behavior may be confusing too, but I don't see it as a problem (delegating it default args in config, it'd end up as a zip (["screen"], ["screen"])).


Automate MS-DIAL

We can run MS-DIAL from the command line (refer to http://prime.psc.riken.jp/compms/msdial/consoleapp.html). Is it possible to script it for our experiments?
To test the console app:

Download MS-DIAL and extract. The MsdialConsoleApp.exe program can be found in the same location as the GUI app.
Download the sample data file: http://prime.psc.riken.jp/compms/msdial/download/demo/MsdialConsoleApp demo files.zip (link also available from the web page above), and extract.
Copy all the extracted files to the same location as where MS-DIAL is (simplest way, or you need to adjust path etc).
Run the batch file MsdialConsoleApp.bat. This will run 3 example analysis: GC/MS, LC-MS/MS DDA, and LC-MS/MS DIA. Can ignore the GC/MS one.

Edit Msdial-lcms-dia-Param.txt to adjust the path to the input DIA file in the LC-MS/MS DIA folder.

The sample DDA analysis runs fine. However the DIA can't run ...

MsdialConsoleApp.exe lcmsdia -i .\LCMS_DIA\ -o .\LCMS_DIA\ -m .\LCMS_DIA\Msdial-lcms-dia-Param.txt
Loading library files..
Start processing..
Could not load file or assembly 'MsdialCommon, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. The located assembly's manifest definition does not match the assembly reference. (0x80131040)

Seems like some library loading / path problem? To check later..

Looks like that might be hard to fix. Think kei might have found something similar and an older version of MSDIAL worked ok (I think the latest version just adds some ion mobility stuff that we’re not interested in)

We just need to make sure we’re using the version described in the CorrDecon paper

'Data were processed by MSDIAL version 4.12'

Looks like you can drop back into v3.22 if necessary

v4.12 works on both the GUI and command line.
However it seems that from the terminal, the DIA mode only accepts input file in ABF format ..

(the DDA mode works with mzML files)
So we need to install ABF converter: https://www.reifycs.com/AbfConverter. As a pre-requisite, this needs MSFile from thermo (install MSFileReader version 3.0 SP2 or higher except ver. 3.1 SP4).

I don't think converting from .raw is going to work. Remember that the RAW files had the apodization issue (peak smudging).

but looks like maybe that converter will convert from .mzML

Ignore the ABF stuff above. Version 4.12 works with mzML file from both the GUI and terminal (was mistakenly using an .mzXML file to test).

See:

http://www.metabolomics-forum.com/index.php?topic=1557.0
http://www.metabolomics-forum.com/index.php?topic=1558.0

For now, we ended up using two different versions of MSDIAL:

v4.24 for the DDA mode. The msp matching works on this version but not on v4.12.
v4.12 for the DIA mode. The DIA mode runs on this version but not on v4.24.

Have created a script msdial_wrapper.py that can be used to launch MS-DIAL, either on a single mzML or a set of mzML files. However for multiple mzML, it seems tricky to enable CorrDec.


chore: Bump ci environment version

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.62%. Comparing base (cec6e02) to head (2360b9f).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   48.71%   40.62%   -8.10%
==========================================
  Files           8        8
  Lines          39       32       -7
  Branches       19       19
==========================================
- Hits           19       13       -6
+ Misses          4        3       -1
  Partials       16       16

Flag
Coverage Δ

Linux
40.62% <ø> (?)

macOS
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Undefined fields should always return bottom (even for implied root struct)

What version of CUE are you using (cue version)?
master
Does this issue reproduce with the latest release?
YES
What did you do?
eval of
v: a

fails with: failed to build: -:3:4: reference "a" not found
however, eval of:
x: {}
v: x.a

evaluates without error.
What did you expect to see?
Given that the top-level is an implicit struct, why would you return an error for undefined fields? I would expect an eval to just show it referencing this unknown field, as the second example above does, and only return an "undefined field: a" error upon cue export (or other concrete output).  The reason I noticed this difference is I was testing disjunctions with multiple defaults:
_b: "b"
_c: "c"
v: *_a | (*_b | _c)

Which resulted in:
failed to build: -:3:5: reference "_a" not found
But:
_x: b: "b"
_x: c: "c"
v: *_x.a | (*_x.b | _x.c)

produced:
{"v": "b"}

as I expected.
This seems like a bug to me. However, I could see this leading to obvious unreported import errors.  Like referencing "json.Marshal" without importing json.
Related: #1581, #629

This is a duplicate of #629
See first comment for the difference between v: a and v: x.a
Like with Go, one should distinguish a reference from a selector.

A missing reference, the first y in this case, is a unrecoverable compile-time error. It is illegal CUE. CUE cannot evaluate meaningfully without resolving a reference.

This is the only reference of y. The other y's are selectors in the resolved references fn and s. These are not compile time errors. As per the CUE spec, these are just errors that get eliminated as disjuncts as part of CUE evaluation and thus will not generate user-facing errors. In fact, these errors are even resolvable (it is an "incomplete" error), as a user may resolve the error by making a configuration more concrete.

While #629 recognizes the difference in behavior between a "reference" and a "selector", #629 seems to want the below to cause an error (which I disagree with):
x: {}
v: x.a

I'm saying, to be consistent with how selectors are everywhere else, the below should not print out an error:
v: a

CUE is not Go.  A CUE file is data with an implied root struct.  "v" and "a" both are selectors on the implicit root struct.  It is not a reference.
Having said that, I WOULD expect this to fail:
[v: a]

Because this is changing the root object to be instead an array, which cannot have members.
I come from a Ruby background, and I know that as soon as I define any identifier in the top level source code, I know it's actually defining methods on an implicit instance.  To me, queue is the same way.
The compiler needs to differentiate between a real reference and a selector on the implied default struct, and not fail in the latter situation.

Proof the "v" is really a selector on the root struct:
v: 1
[{a: v}]

outputs:
failed to encode: conflicting values [{a:v}] and {[{a:v}],v:1} (mismatched types list and struct)

#629 seems to want the below to cause an error (which I disagree with):

#629 is talking about when that example should result in an error from a developer experience (DX) perspective. That is to say, there is a distinction between when an unresolved selector should be surfaced as an error to a user or not, and the detection of such an error in the first place. CUE today does not raise an error in such a situation because more CUE can be provided to make that unresolved selector error disappear. However, from a DX perspective, that can (and does) cause real errors to be missed, hence #629.
@kcburge - I'm going to close this issue and ask that we move discussion to #629. All of the points you are raising above are relevant to that discussion about DX but come, as you point out, from a different perspective. We should feed those perspectives into that discussion.


README code simplification for cloning this template

Hey, thank for this template !
I send you a small PR for the readme.

I'm afraid but I can't accept your PR. Because:

Home directory should always exist as a pre-requisite. It's not good idea to create it with your own hands.
~/.middleman often exists before you read the readme, in case of that separate shell commands are more convenient to copy & paste them.

Thank you for sending PR anyway!


docs: specify build dependencies

Issue being fixed or feature implemented
In order to guide developers that want to build, compile or run locally directly in typescript, we specified the dependencies that are needed (typescript / ts-node) into the documentation.
What was done?

updated getting-started/quickstart, getting-started/with-typescript, docs/README and the root Readme.

How Has This Been Tested?
N/A
Breaking Changes
N/A
Checklist:

[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have added or updated relevant unit/integration/functional/e2e tests
[X] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[X] I have assigned this pull request to a milestone

Just one question: why we don’t want to add tsc to dev dependencies?


ix-icon web component not loaded. Using local fallback version

Prerequisites

[X] I have read the Contributing Guidelines.
[X] I have not leaked any internal/restricted information like screenshots, videos, code snippets, links etc.

What happened?
Hi, the message “ix-icon web component not loaded. Using local fallback version” started to appear in the console running tests after<EMAIL_ADDRESS>migration. Why this happens and how to overcome this?
What type of frontend framework are you seeing the problem on?
Angular
Which version of iX do you use?
2.5.0
Code to produce this issue.
There's none! It happens when running tests.

Hi, I'll post the minimum of some screenshots to avoid exposing internal project's information. I hope it helps:

The Basic example for the Application component here raises the same error when launched on StackBlitz.

Looks like it jumps over the if statement in the middle, it is never executed in my Chrome browser. Maybe some {} or an else if will fix it?

@rmaspoch just started the linked example looks good here:
StackBlitz:

Local:

Maybe it is a Google Chrome/Windows bug, looks like you use Safari on a MAC? So maybe the interpretation of newline/if is different? I used Webpack and basic Web Components to create/build the project and I also have the warning, the rest works fine. Also Icons are working.

@danielleroux I get the warning locally and in StackBlitz, both in Safari and Chrome. I'm on macOS 15.1. Icons work, though. It's probably a browser/OS quirk. Thanks for looking into it.