bug:  contains and startsWith doesn't work properly when doing submatches

Describe the bug
contains and startsWith doesn't work properly when doing submatches
To Reproduce
Steps to reproduce the behavior:
Having this code:
terraform {
  backend "azurerm" {}
  required_providers {
    azurerm = {
      version = "0>=3.0"
      source  = "hashicorp/azurerm"
    }
    azuread = {
      version = "0>=0.7.0"
      source  = "hashicorp/azuread"
    }
  }
}

If you try to run the following tfsec check and switch between these options: contains/startsWith/endsWith on line 20, you will find that the only option that works as expected is endWith:
---
checks:
- code: check_provider_is_pinned
  description: Ensure that teams are pinning their resource versions/provider in their code.
  impact: Possible version collisions when not pinning the Azure provider.
  resolution: Use the equals operator in the provider version.
  requiredTypes:
  - terraform
  requiredLabels:
  - "*"
  severity: HIGH
  matchSpec:
    action: isPresent
    name: required_providers
    subMatch:
      action: isPresent
      name: azurerm
      subMatch:
        name: version
        action: endsWith
        value: 0
  errorMessage: Version should not contain > It should only contain equals (=)
  relatedLinks:
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs#default_tags

Expected behavior
I would have expected that contains and startsWith would not raise any alerts, but it does.
Output of your tfsec command with --debug flag
I collected the file, but it is quite big, if you want I can share it via email. Or post it in a separate comment below.
System Info

tfsec version: v1.28.1
terraform version: 1.3.8
OS: ubuntu

Example Code
terraform {
  backend "azurerm" {}
  required_providers {
    azurerm = {
      version = "0>=3.0"
      source  = "hashicorp/azurerm"
    }
    azuread = {
      version = "0>=0.7.0"
      source  = "hashicorp/azuread"
    }
  }
}

Additional context

Our efforts have moved to Trivy. Please file a discussion in the Trivy repo if you see fit.


Mention warnings that were turned to errors previously

Forgot to mention a couple task/transform validation warnings that were turned to errors:

[x] https://github.com/gradle/gradle/pull/21737
[x] https://github.com/gradle/gradle/pull/21739

@bot-gradle test and merge please.

OK, I've already triggered a build for you.


Add a Preview Haggadah feature

Currently I ask people to pick scripts without enough info on the script. Add more info and a preview feature. Maybe break “more info” to a separate issue.

This could be merged to main as a first cut of the Plan Seder/pre-Seder answer flow.


Transaction metadata feature

Transaction metadata feature
Discussion:
https://input-output-rnd.slack.com/archives/GPV22FQGN/p1603708639018100
Design:
https://zpl.io/V4JX7NJ

Implemented in #372


Will we support windows and mac agents?

I think we can push this type of support off till later but I do think that we will have to support these at some point, at some time. How we do that, and how it works with our framework will be important. I don't think we can reliably count on "containers" especially on a mac, and the agent might have to "fake" it someway.

was thinking last night that windows (although there are windows containers I don't really know what those are) that windows and mac could be considered their "own" containers. aka, when specifying your container for the step "mac" would be the container. the only problem we would have to solve for here is storage. as the mounted drive would need passed from agent to agent if the job was run on multiple machines?

I think the answer is yes... but not right now.


Resolving tag-based callback dependencies breaks when declared with .js file extension

In module lib/buildanalyzer/resolveDependencies/resolvers/getCallbackDeps.js determining chains of dependencies for callbacks declared with file extensions (data-trio-callback="someFile.js") fails.

The fix for this is to map all paths that are returned from calls to getTagCallbackDependencies to just their file names using path.parse(path).name.


Drive - Duplicate file?

As you can see file4 is duplicated same filesize and name, is this some file revision issue?
When I try and sync this drive to another what should be identical drive sync constantly tries to upload this duplicate file and fails, no matter how many times I run it, it copy new's this file over and over again.
Running the latest beta.
./rclone ls drive_database_backup1:somefolder/someotherfolder/someotherotherfolder
1311587023 file1
1517502971 file2
1396104784 file3
1499103085 file4
1499103085 file4
1338074238 file5
1194734563 file6
1345642954 file7
1381247260 file8
1269234928 file9
1521290370 file10
1334744546 file11
1179343849 file12

Looks like the file is completely identical, except for the id when using --dump-bodies. So rclone can't handle situations like that I guess. Not even sure how to get rid of these duplicates now, I guess the web browser client.

Ah I see, I can use dedupe to correct this. I'd still class this as a bug since sync/copy will never be satisfied in this situation and constantly try and copy the same file every execution.

Drive duplicating files is an old problem - see #28.  I'm pretty sure there is a bug in drive itself as rclone is not the only app to have this problem.  Even google photos on android duplicates pictures!
Your suggestion of warning when it encounters a duplicate is a good one, and one that is now possible with the new style sync routines, so I shall use this amend this issue to implement that.

PS the old sync method did used to warn about duplicate files, so this functionality has gone missing.

It was odd indeed, I wasn't sure how those duplicates even came about, cleaned them out with redupe and sync was fine. Would be good indeed to prevent duplicates with sync.
I ran sync a few times before I figured out what was going on, I had renamed and moved some files around so I thought there was some other conflict, quite odd indeed.

NB this is also causing a problem being discussed on the forum

This will warn about duplicated files
https://beta.rclone.org/v1.36-231-g575e779b/ (uploaded in 15-30 mins)


Implement version field type

@Mpdreamz I've attempted this by reviewing previous PRs and a bit of sleuthing! Please let me know if I've missed anything. I've been able to use the mapping on a test project.
Main challenge in naming in FieldCapabilities since that already has the concept of the "_version" field. I welcome opinions on the naming. Perhaps in 8.0 we can consider renaming both of these so that Version becomes DocVersion?

Thanks @Mpdreamz. I've fixed up the interface causing the failure. Will allow the tests to run in CI and then merge if that's all good.


[PE-D][Tester A] Should not allow last met date to be before the client's birthday

Description:

When using the "met" command or the "edit d/dob" command, the system currently allows users to make the last met date before the birthday which should not be possible.

Replication:

Start up with default json file.
Enter commands:

met 1 d/1950-02-03

Negative Impact:

Can be very confusing on the users if you last met someone before they were born.

Suggested Solution:

When editing a client's dob, ensure that this date can not be after the last met date.
When updating a client's last met date, ensure that this date can not be before the birthday.
Produce error message if invalid attempts are made.

Screenshots:

Labels: type.FunctionalityBug severity.Medium
original: alfaloo/ped#1

The intended feature of Last Met is to allow users to remind themselves on who they should meet. We give users the flexibility to set whatever date they want to be reminded.
Certain clients like newborn babies may be only a few days old. Users can set the Last Met to be earlier than the date of birth so they can bypass the standard Last Met overdue period they set. Otherwise, they would need to change the Last Met overdue period to cater to these outliers.


Errors in HA log

Home Assistant release with the issue:
0.73.0

Last working Home Assistant release (if known):
dont know
Operating environment (Hass.io/Docker/Windows/etc.):

Docker
Component/platform:

Logbook events
Description of problem:
Getting a lot of those errors.
2018-07-12 22:00:56 ERROR (MainThread) [frontend.js.latest.201807040] :0:0 uncaught exception: SyntaxError: Expected "date", "number", "plural", "select", "selectordinal" or "time" but "m" found.,
2018-07-12 22:01:56 ERROR (MainThread) [frontend.js.latest.201807040] :0:0 uncaught exception: SyntaxError: Expected "date", "number", "plural", "select", "selectordinal" or "time" but "m" found.,
2018-07-12 22:02:56 ERROR (MainThread) [frontend.js.latest.201807040] :0:0 uncaught exception: SyntaxError: Expected "date", "number", "plural", "select", "selectordinal" or "time" but "m" found.,
2018-07-12 22:03:56 ERROR (MainThread) [frontend.js.latest.201807040] :0:0 uncaught exception: SyntaxError: Expected "date", "number", "plural", "select", "selectordinal" or "time" but "m" found.,
2018-07-12 22:04:56 ERROR (MainThread) [frontend.js.latest.201807040] :0:0 uncaught exception: SyntaxError: Expected "date", "number", "plural", "select", "selectordinal" or "time" but "m" found.,
2018-07-12 22:05:56 ERROR (MainThread) [frontend.js.latest.201807040] :0:0 uncaught exception: SyntaxError: Expected "date", "number", "plural", "select", "selectordinal" or "time" but "m" found.,

Frontend is showing a short pup-up : Service system_log/write called
after this popup the event is shown in the log.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:
Log entry can be generated clicking a sensor opening the card.
using an internal db and influx, db is 238MB

It is a front end JavaScript error logged back to back end. Please try to isolate issue see which sensor/card/group cause this issue. And also please fill in your relevant configuration.yaml

I'm seeing the same issue on my end and was able to recreate the error on a fresh install with the default config included with the docker image

I can't speak for @Martinvdm but I've traced the problem back to my Caddy config as I'm not seeing this issue when connecting locally via the machines IP address. I still haven't figured out how to resolve the issue (though switching to nginx is my next step as I can't seem to resolve the issue with changes to my caddyfile


[DRAFT DO NOT REVIEW] Make ObserverHolder thread safe by having a thread local observer member

For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

this PR appears to be abandoned, can it be closed?

this PR appears to be abandoned, can it be closed?

I would prefer not to close it yet as it is an alternative approach to https://github.com/apache/geode/pull/6874 as it is mentioned in the comments.


Don't use m.twizmwaz.in

It is my server, I pay for it out of my own pocket. It is not to be mis-used.

I'm still working on removing links to your code. However, I was planning to use a different system. I'll do it later, I have to go do some work.


Allow test host apps up to iOS 14.3

If this is setting minimum_os_version, what are the benefits of making a min version for each OS? e.g. a test host with a min version of 9.4 should also work with 11.0

Consistency with CocoaPods, which generates an app host with the same minimum OS version as the test bundle


Attributes in Links

This is not something we support in OT at the moment, and don't think many vendors support this underneath either.

so this is a "new" feature for Open Tracing. Is it a problem?

So as they are not the same feature (References and Links), I'm closing it indeed.

(Addressed by #14)


Request for azurerm_virtual_desktop_host_pool resource

What resource do you need?
Terraform Resource Name:
All resources involved in creating a Virtual Desktop with Azure AD integration, that includes:

azurerm_virtual_desktop_host_pool
azurerm_virtual_desktop_host_pool_registration_info
azurerm_virtual_desktop_scaling_plan
azurerm_virtual_desktop_workspace
azurerm_virtual_desktop_workspace_application_group_association
azurerm_virtual_desktop_application
azurerm_virtual_desktop_application_group
azurerm_virtual_machine_extension

I saw that these AVD resources were marked as 'irrelevant' but I did not understand why.
What is your use case?
I work for a big organization in an automotive project and I have a use case where I need to deploy an Azure Virtual Desktop with Azure AD integration. To properly integrate with AD I need to run 3 VM extensions alongside the VM creation so it can connect to AD and integrate with Host Pool. The VMs are Windows-based and deployed with a custom image built using Hashicorp's Packer tool. If I could implement all of this using Crossplane, I intend to replace all our Terraform code.

Hi @Zenardi,
Thank you for raising this issue. If you would like to contribute to adding these resources, this guide will help. If you have any questions, feel free to ask.

I created this commit containing all resources related to Virtual Desktop. Can I simply create a PR or do you want to review it first? I followed this guide but I am not sure if what I did is deviating too much from the project.
Thanks

You can open a PR and we can check from there everything.


Expose options/other services on managers

Fixes https://github.com/aspnet/Identity/issues/1061
To be consistent (and to return to how things were in 2.0) I restored public access to all the dependant services again (which were protected internal) except the Store which we don't want people to use directly
cc @divega @blowdart

:shipit: @divega says

b64a32f089f06c8c403f8bb9ee085a580c9555e2


feat(lane_change): add dynamic lateral acc lc

Description
Currently, lane change can only use a single lateral acceleration value to calculate the length of lane change length. However, we can handle many more scenarios by extending the lateral acceleration values, we add a lateral acceleration map for the lane change module. This enables the lane change module to dynamically change its lateral acceleration depending on ego vehicle velocity.
Launch PR

Related links

Tests performed
Unit Tests
Scenario Test 1301/1350
TIER IV Internal Link

Notes for reviewers

Interface changes
There is no interface change caused by this PR.

Effects on system behavior
Lateral acceleration of the lane change module will be changed based on the situation. For example, if the lane change module perform lane change in a short lane, the lateral acceleration value will be increasing.

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@rej55 I merged your suggestions. Could you check if the change is what you intended?


MKLDNN BoundedRelu implementation for Relu6

Added MKLDNNN BoundedRelu op support for Relu6
CpuLayout && CPU assignment pass for BoundedRelu Op
Unit test inter v/s CPU for BoundedReluOp
MKLDNN and default emitter code for BoundedReluOp

(.venv_mxnet) phthoreho@phthoreho-X9DAi:/media/phthoreho/61279ac5-fee9-489e-8593-4891a74aa922/ngraph/build1$ ./test/unit-test --gtest_filter="cpu_fusion.fuse_bounded_relu*"
Note: Google Test filter = cpu_fusion.fuse_bounded_relu*
[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from cpu_fusion
[ RUN      ] cpu_fusion.fuse_bounded_relu
Comparing 24 bytes[       OK ] cpu_fusion.fuse_bounded_relu (42 ms)
[ RUN      ] cpu_fusion.fuse_bounded_relu_inter_vs_cpu
Comparing 24 bytesmkldnn_verbose,exec,eltwise,jit:sse42,forward_training,fdata:nc fdiff:undef,alg:eltwise_bounded_relu,mb2ic3ih22094iw2097608448,7.80493
[       OK ] cpu_fusion.fuse_bounded_relu_inter_vs_cpu (3969 ms)
[----------] 2 tests from cpu_fusion (4011 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (4011 ms total)
[  PASSED  ] 2 tests.

@jbobba addressed the changes requested.


rotation vector in rc_altitude.c

Hi @StrawsonDesign ,
Can you please help me to understand the working principal in IMU filteration that is being used in rc_altitude.c
As for what purpose "rc_quaternion_rotate_vector_array(accel_vec,mpu_data.dmp_quat)"  is required before filter? What does it actually do? then what are the steps that are needed further etc?
I want to understand it's flow so that i can proceed to make a separate code for 2D position estimation with imu integration.
Will appreciate your help.
Thanks.

Or is any slack/any account for roboticscape there? so that discussion can be made over ther.

I just made a slack channel here https://beagleboard.slack.com/messages/CBLPQ5MN2/details/
if that doesn't work please send your email so I can invite you manually.

Hi, it didn't work for me.
Email-<EMAIL_ADDRESS>

Hi, Any update?

Hi, So its done. Closing this.


pubdate not visible

I saw that the feeder module doesn't generate a  tag in the RSS XML. Is it possible to do this.
I looked around for a bit but couldn't find a way to realise this. Is it possible to add this feature in a future release?

Found a way to do this by adding date: new Date(post.createdAt) in the feed creator function of nuxt.config.js


Time range filter applied across all charts, independently of the chosen variable

When a value is selected in a time range filter (in a filter box), the time is applied across all the line charts, even if the time variable composing the X axis of the line chart is not the same as the one selected.
Expected results
When a time variable is set in a filter box, It should filter the database based on the chosen variable (let's say X), and therefore only filter the time axis of the line charts if the time axis is composed by the same variable.
Actual results
All the time variables used by the charts inherits from the chosen Time Range.
Screenshots
This is the filter box where I choose the time filter

The time filter should be applied on the variable that I choose in the chart UI (releasedate in my example)

However, this charts inherits from the filter that I applied, despite the time variable not being the same (fakedate here in my example)

How to reproduce the bug

You need a table with at least two time columns
Create a time filter using the first time variable
Create a line chart using the second variable
See how the time axis of the line chart is filtered

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[X] I have reproduced the issue with at least the latest released version of superset.
[X] I have checked the issue tracker for the same issue and I haven't found one similar.

Hey @michalgala closing this as stale as filter box is deprecated and will be removed in 4.0. If you still have any issue with any of the recent Superset versions (3.x), please feel free to open a new issue. Thank you!


Memory commands fix

Type of Change

[x] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[x] Documentation
[ ] Build system

Purpose
Two "random" things I found on the other day.

:monkey: 💃


YML should upload produced packages as pipeline artifacts

We should have packages available in the pipeline run as pipeline artifacts for inspection. This makes it easier to double check PR changes.

I was thinking about this the other day.  I noticed we do generate the packages, they just don't get stored in a persistent location.
Will we get any kind of pushback from dnceng for using a lot of new space? We would basically create a new persistent artifact location for every commit in a PR. Unless they get deleted and overriden whenever a new commit is pushed?

Nope, we do this in every repository. Pipeline artifacts are expected to be used and they a retention policy setting attached anyway.


Specify types and arguments on databases that support it

Feature Request
What feature are you missing?
There isn't a way to specify the string length (or type) on a string field for databases that support it.
https://www.prisma.io/forum/t/is-there-a-way-to-add-a-length-to-string-varchar/3546/2
Also, it might be beneficial to allow the type (CHAR or VARCHAR) to be specified or the arguments used for any of the other data types like INT
https://dev.mysql.com/doc/refman/5.7/en/create-table.html
How could this feature look like in detail? Tradeoffs?
Either we should add these arguments to the GraphQL type (i.e. String should allow the length argument) if that is even possible, if not, perhaps there should be some "easy" way to specify new primitive types? Like perhaps I could define a new String type that is of database type CHAR(20)?
The tradeoff would be that it cannot be assumed that a String is of the same length for the same field, but I think being able to extend the primitives would aliviate that (and would allow a place to document the restrictions).

Any update on this? Is it possible to specify string field length

I'm interested in this too.
Also wondering...aren't there performance implications to storing all strings as a "mediumtext" column in mysql? (as opposed to designing tables as varchars to match the expected data lengths)

I'd also need this feature. Currently, we always have to check for a specific maximum length inside of our resolvers, this would make all of this logic obsolete, which would be very nice!

+1

+1

+1

+1

+1

+1

+1

+1

+1


Chore/daef 525 Update to latest mobx-react-form

This PR introduces latest available update of MobX React Form plugin.
Biggest change was the way file type fields are handled as from now you have to use set method in place of onChange in order to update field's value (e.g. on file drop or selection).
Note
As a part of this PR a fix for isValidAddress endpoint regression issue has been implemented: https://issues.serokell.io/issue/CSM-557 (endpoint started to throw an error if invalid address has been passed to it - where in fact it should return success with boolean value false)

Reviewing this now


Occasional ECONNRESET & Crash on Startup

Bug Description
Sometimes when Homebridge restarts, the plugin is unable to connect to one of my board. This causes an instant Homebridge crash. Typically, this will occur once or twice in a row, each time homebridge will crash and restart, then startup will happen as normal.
I do believe one of my boards is actually having connection issues, but I feel this should not cause a complete HB crash.
Steps To Reproduce
Restart Homebridge. Unfortunately, it is inconsistent.
Expected Behavior
Homebridge starts normally, and Konnected connects to the boards.
Environment

Homebridge System:

Node.js Version: 18.13.0
NPM Version: 8.19.3
Homebridge/HOOBS Version: Homebridge 1.6.0
Operating System: Alpine Linux
Process Supervisor: Docker

Konnected Panel(s):

Panel Hardware Version: v1 (I believe)
Firmware Version: 3.0.0
Addon Panel(s): 6-Zone Alarm Panel (1)
Interface Panel(s): 6-Zone /w Siren Output (1)

Attach Files to Support Your Experience
Error log:
[1/30/2023, 2:45:45 AM] FetchError: request to http://<IP_ADDRESS>:12108/status failed, reason: read ECONNRESET
    at ClientRequest.<anonymous> (/homebridge/node_modules/homebridge-konnected/node_modules/node-fetch/lib/index.js:1491:11)
    at ClientRequest.emit (node:events:513:28)
    at Socket.socketErrorListener (node:_http_client:496:9)
    at Socket.emit (node:events:513:28)
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)
[1/30/2023, 2:45:45 AM] Got SIGTERM, shutting down Homebridge...

Update: This may be the same as issue #18


[Question] Manually set "should lua file be module or not"

Introduction
I'm developing resources for MTASA on typescript. MTASA does not support Lua's require, therefore, I cannot use Lua Modules. Only global-scoped variables/classes/functions can be used.
However, I would like to use imports in my typescript files (because, for example, there are different function signatures for client and server side), therefore, my typescript files are modules.
At the current moment
There is the visitor, that provides Lua Moduleness for Lua file. It depends on context's isModule.
isModule detects from ts.isExternalModule here, hence, TypeScript module will be converted to Lua Module (with ____exports and local-scoped classes and variables).
My workarounds
I can get rid of require by removing import ts.nodes with transformer
Also I can get rid of all import and export lines in the whole file with the transformer, however, ts.isExternalModule still detects the file as module
I have tried dirty hack and set externalModuleIndicator to undefined here. But this way crashes TypeScript compilation (imported types are undefined).
Illustration
Example TypeScript file:
import {outputChatBox} from 'mtasa-lua-types/types/mtasa/client/function';

const awesomeGlobalVariable: number = 13;
outputChatBox('Sample text here');

Compilation (with my transformer) result:
local ____exports = {}
local awesomeGlobalVariable = 13
outputChatBox(nil, "Sample text here")
return ____exports

Expected result:
awesomeGlobalVariable = 13
outputChatBox(nil, "Sample text here")

Conclusion
Is there any ideas/workarounds, how can I provide that ~(without regexes replacements please)~?
I can try to make enhancement Pull Request with new config property, it that's allowed :)

We support bundling which compiles all your code into a single file. See luaBundle and luaBundleEntry here https://typescripttolua.github.io/docs/configuration.
To make functions or variables global so the engine can read them you can directly assign them to _G or globalThis (which is translated to _G). Here is an example of a class decorator that assigns stuff to _G https://github.com/Shushishtok/dota-reimagined/blob/master/game/scripts/vscripts/lib/tstl-utils.ts

Sure, I forgot about _G and globalThis :)
Thank you!

Well, I wrote the transformer, that replaces export by _G assignment
So, if someone is concerned with that issue, can try to use that...


Don't run gcov coverage for Node

the gcov build is broken for Node and given Node now lives in a separate repo, it probably doesn't make sense to support it for gcov anyway.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


Make styles of input controls less dependent on global app styles

Fixes #53
After this PR:

Ping @tannerlinsley 👋 🙂

:tada: This PR is included in version 2.4.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove static isort classifications for main, disutils

isort lacks these overrides, and classifies them as third-party by default.
I suspect disutils was a typo for distutils, which is in the standard library but slated for removal in Python 3.12. However, at least for now, isort classifies it in the standard library.

FWIW I took these from classify-imports.


documentation - using extended scope

We want to update the current doc.  In general we want to discorage this, but for a number of sites they will need more URLs.    Also point to the spec "also include" work that will replace this once it is in the spec.

this file and this test case needs to be change.
https://github.com/search?q=org%3Amanifoldjs+It+is+recommended+to+specify+&type=Code
we might want to remove the validator, or have it just check to make sure a scope is set and let them know we set it automatically


tweaks to enhance dch audio driver doc

Adding clarity

Thanks so much @nehinnan for the PR, and apologies for the huge delay. This PR for some reason became inaccessible due to a bug in the GitHub platform, and only just became accessible again today after I had an email thread with GitHub support!  Changes will be live within a few minutes.


#1442 test harness updates

closes #1442
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

After selecting a paramDef from dropdown, properties side panel doesn't close. It closes after clicking "Show properties" button
showRequiredIndicator  - Please change On/Off toggle text to (required)/(optional)
setDisableRowMoveButtons - Placeholder should be [{ "name": "parameterName"}] . This config option isn't working.  Tested with example from release - https://github.com/elyra-ai/canvas/releases/tag/release_10.3.0


Changes for language spec update?  compiler-inserted default_action is not const

This issue is related to the following change made from v1.2.3 to v1.2.4 of the P4_16 language specification:

compiler-inserted default_action is not const (Section 14.2).

Basically, if a table definition has no explicit default_action property, the compiler behaves as if the user wrote the property default_action = NoAction();, and adds NoAction to the list of actions if it was not there already.
(see https://p4.org/p4-spec/docs/P4-16-v1.2.4.html#sec-summary-of-changes-made-in-version-124 for the item in context of the full list of changes, but there are separate Github issues for each that might impact the P4Runtime API specification).
This seems worth at least briefly discussing in API work group, but my guess is that this is really just a clarification in the language spec that says explicitly what has already been done for years in the open source P4 implementations.

2023-Sep-08: Decision made that no P4Runtime spec changes needed, so remove this item from bullet list in spec.

This issue can be closed if/when PR https://github.com/p4lang/p4runtime/pull/459 is merged.

PR #459 was merged, so closing this issue as resolved.


Adding provider delegate auth check for processes

This PR contains:

Provider Delegate Auth Check for processes in ProcessAuthZHandler
Code refactoring of error handling to use FailureHandler  in ApiServerVerticle
Tests for provider delegate flow in CollectionAppendingProcessIT

Build finished.

Build finished.

Build finished.

Build finished.


Make it possible to trigger a function each time a value for certain pin is received

While working on my project i see that this is annoying when i want to trigger actions in app each time when certain pin value is received.
Now I'm doing something like this with these two options:

Send value from arduino
Send function name from arduino to check the value in app (making a lot of separated functions for each pin or one big that calculates them all even if one of values is not received).
Do some action in that function

or (I want to avoid this one because I want to have response in real time and it's important to make sure it checks single element not the whole function when two pins are received during the interval).

Send value from arduino
Use setInterval in app to constantly listen for changes in these values
If value is not empty - do some action and clear the variable so the action is not repeated

This could be easier like this:

Send value to arduino
Check if the pin has some action included when data is received and parsed
trigger specific function name or add additional code in onReceive listener.

this could work like this from user site:
involt.triggerPin[pin] = function(thatPinValue){ // do something }
and calling the function could be included like this:
(Depending on their performance)
if received string of pin value ends with T instead of E then trigger function (requires changes in arduino code)
if pin has function in involt.triggerPin then trigger it. (looks easy but must check for something)
Note that this is not a good idea when multiple pins with their functions are working in small delays between.
Or it could be possible to just include empty function when data is parsed so user can make something with anything he gets. Actually this can be done by adding this in involt.js file but I don't think it's good idea. The problem is that this will be working each time something is received without proper if statements

Important: This thing is easier to build when triggering event from app to device.
The Ui element have function included and sends it right after the event. When sending from arduino to app it's harder because this could end with long strings that would not be received properly. For example: A0V1022Ffunction or S0VDisplay this on screenFdisplay
If some action in app has to be done when value is send to arduino you just create custom JQuery for this UI element

Did this improvement for one of my projects. This issue can be closed for now.


Fix SerializesAndRestoresModelIdentifiers trait with model repository

Hi,
Currently, the trait "SerializesAndRestoresModelIdentifiers" via "SerializesModels" doesn't support model repository like that:
<?php

namespace App\Mail;

use App\Models\Group;
use Illuminate\Bus\Queueable;
use Illuminate\Container\Container;
use Illuminate\Mail\Mailable;
use Illuminate\Queue\SerializesModels;

class UserInvitation extends Mailable
{
    use Queueable, SerializesModels;

    protected readonly Group $groupRepository;

    /**
     * Create a new message instance.
     *
     * @return void
     */
    public function __construct() {
        $this->groupRepository = Container::getInstance()->make(Group::class);
    }
}

This PR fix that.

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.
Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.
Thanks!


Could not load type 'Bybit.Api.BybitApiAddresses'

I'm getting error Could not load type 'Bybit.Api.BybitApiAddresses' after I upgraded from version 1.3.0 to the latest version 2.4.0.
System.TypeLoadException: Could not load type 'Bybit.Api.BybitApiAddresses' from assembly 'Bybit.Api, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'.    at ExchangeBybit.Api.Configure(Boolean production, String bybitKey, String bybitSecret)    at ExchangeBybit.Api..ctor(Boolean production, String bybitKey, String bybitSecret) in /../ExchangeBybit/Api.cs:line 26    at Bybit.BybitBrokerV2..ctor(IDatabase db) in /..BybitBrokerV2.cs:line 86    at BotService.Worker.StartBot(CancellationToken cancellationToken) in /../Worker.cs:line 149    at Microsoft.Extensions.Hosting.Internal.Host.StartAsync(CancellationToken cancellationToken)    at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)    at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)    at Program.<Main>$(String[] args) in /home/hampelman/source/jtrading/BotService/Program.cs:line 9    at Program.<Main>(String[] args)
How can I fix this? Any help would be appreciate it. Thank you!

There were breaking changes and had to adjust. Still working on updating all breaking changes. :-(

Bybit.Api doesnt has Bybit.Api.BybitApiAddresses class. It's related with your codes. You may want to take a look for Bybit.Api.BybitApiAddress class


Create Account

Fixed proposed changes from last PR
Created Account runnable and tested
Added identity.sqlite as testing db
Added .travis.yml
Set-cookie not included
Updated account partially written

Can you remove the comment codes, other LGTM.

Instead of storing SQLite database in the source control, I think it would be better to write a script to create and initialize the database to the desired state.

Can you remove the comment codes? Others are LGTM.

Since the updateAccount function in this PR has not been fully developed, all comments will be removed when updateAccount is ready (1-2 PR later estimated).

Instead of storing SQLite database in the source control, I think it would be better to write a script to create and initialize the database to the desired state.

Will remove in next PR and add a bash script to create DB upon testing.

Please remove the sqlite db file in this PR. Not in next one.

Please remove the sqlite db file in this PR. Not in next one.

Apology. Will fix everything tomorrow morning in this PR before merge.
(I previously thought PR was not editable once proposed, now I figure it out :ok_hand: )

Issues have been fixed today:
⋅⋅* DB file has been removed and each time travisCI will run .scripts/buidDB.sh to create a new one
⋅⋅* comments have been removed
⋅⋅* getAccount in updateAccount has been removed


Build process error in Chapter 3 build

Hey all, I just did a quick test of a build  on Linux using a "git clone" of the repo, and I get an error when the build process hits Chapter 3:
[ 60%] Generating VertexShader.spv
-V<num> client input semantics: expected attached non-0 number
make[2]: *** [Chapter3/CMakeFiles/OpenXRTutorialChapter3.dir/build.make:75: Chapter3/VertexShader.spv] Error 1
make[1]: *** [CMakeFiles/Makefile2:559: Chapter3/CMakeFiles/OpenXRTutorialChapter3.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

I tried with the Graphics API set to both VULKAN and OPENGL.

Hi @wsherman64, I think the problem lies in how we are calling glslangValidator in the CMake here:
https://github.com/KhronosGroup/OpenXR-Tutorials/blob/708c6d6397c1e480e02b882e6a74366c305769aa/cmake/glsl_shader.cmake#L95
glslangValidator is looking for a char after the -V argument expecting to find the ver number, but in our case, it seems to
be reading a space character.
I think there are two options to resolve this:

-V "${_glsl_spv_INPUT}"
"-V100" "${_glsl_spv_INPUT}"

I'd prefer option 1 as we have already defined the Vulkan version with --target-env, but maybe it might still be tripped up.
Usage:
https://github.com/KhronosGroup/glslang/blob/b820431a2cddd41155d5750e1ae6ec3def2831c0/StandAlone/StandAlone.cpp#L1956-L1961
Error Message:
https://github.com/KhronosGroup/glslang/blob/b820431a2cddd41155d5750e1ae6ec3def2831c0/StandAlone/StandAlone.cpp#L966-L972
Really strange that this never came up in testing. XR_TUTORIAL_GRAPHICS_API doesn't interact with the CMake configuration or generation.

Thanks Andrew, I'm now getting a different error at the same point.  I first tried your solution #1, and when that didn't work tried #2 -- so the results below are from trying #2.  I turned on CMake Verbose with "export VERBOSE=1", so this has more details:
cd /home/wrs1/Apps/OpenXR/Tutorial/SimulTut/OpenXR-Tutorials_git20231127/Chapter3 && /home/wrs1/Utils/GLSlang/glslang_20220223_Install/bin/glslangValidator -o /home/wrs1/Apps/OpenXR/Tutorial/SimulTut/OpenXR-Tutorials_git20231127/Chapter3/VertexShader.spv -S vert -e main -x -gVS "" "" --target-env vulkan1.0 "-V100 /home/wrs1/Apps/OpenXR/Tutorial/SimulTut/OpenXR-Tutorials_git20231127/Chapter3/../Shaders/VertexShader.glsl"
/home/wrs1/Utils/GLSlang/glslang_20220223_Install/bin/glslangValidator: Error: unable to open input file (use -h for usage)
make[2]: *** [Chapter3/CMakeFiles/OpenXRTutorialChapter3.dir/build.make:75: Chapter3/VertexShader.spv] Error 1
make[2]: Leaving directory '/home/wrs1/Apps/OpenXR/Tutorial/SimulTut/OpenXR-Tutorials_git20231127'
make[1]: *** [CMakeFiles/Makefile2:559: Chapter3/CMakeFiles/OpenXRTutorialChapter3.dir/all] Error 2
make[1]: Leaving directory '/home/wrs1/Apps/OpenXR/Tutorial/SimulTut/OpenXR-Tutorials_git20231127'
make: *** [Makefile:136: all] Error 2

It seems glslangValidator can't find the GLSL file. glslangValidator: Error: unable to open input file (use -h for usage)
I think this is being as a single argument not two:
"-V100 /home/wrs1/Apps/OpenXR/Tutorial/SimulTut/OpenXR-Tutorials_git20231127/Chapter3/../Shaders/VertexShader.glsl"

Okay, I think the issue is with the "-gVS" option.  My version of glslangValidator doesn't seem to have that option.  (Was this recently added to the build process?)
Here's the version info from my glslangValidator:
Glslang Version: 10:11.8.0
ESSL Version: OpenGL ES GLSL 3.20 glslang Khronos. 11.8.0
GLSL Version: 4.60 glslang Khronos. 11.8.0
SPIR-V Version 0x00010600, Revision 1
GLSL.std.450 Version 100, Revision 1
Khronos Tool ID 8
SPIR-V Generator Version 10
GL_KHR_vulkan_glsl version 100
ARB_GL_gl_spirv version 100

I did some more experimentation today on the Linux build process, and I discovered that it's not actually the "-gVS" option that is the problem -- it's the two "" and "" that happen because of some null parameters in the CMake setup generate these double-quote pairs, and in the Linux shell, these are seen as actual arguments of strings of length 0, which then glslangValidator thinks is the name of the file, and so can't find the file.
Here are the lines of the cmake/glsl_shader.cmake file that cause this -- based on choosing the CMAKE_BUILD_TYPE whichever one is set gets the associated option, but the other two generate the empty double-quote-pair:
#$<$<CONFIG:Debug>:-Od>
#$<$<CONFIG:Release>:-g0> ```
For my current build I have ```CMAKE_BUILD_TYPE``` set to ```RelWithDebInfo``` so I had to comment out the other two settings to prevent them from adding the doulbe-quote-pair.

Otherwise, the command looks like:
```cd /home/wrs1/Apps/OpenXR/Tutorial/SimulTut/OpenXR-Tutorials_git20231127/Chapter3 && /home/wrs1/Utils/GLSlang/glslang_20220223_Install/bin/glslangValidator -o /home/wrs1/Apps/OpenXR/Tutorial/SimulTut/OpenXR-Tutorials_git20231127/Chapter3/VertexShader.spv -S vert -e main -x -gVS "" "" --target-env vulkan1.0 -V /home/wrs1/Apps/OpenXR/Tutorial/SimulTut/OpenXR-Tutorials_git20231127/Chapter3/../Shaders/VertexShader.glsl

Commit 5d0ec59 adds COMMAND_EXPAND_LISTS to all the shader compilations. So if any CMake generator expressions resolve as "", COMMAND_EXPAND_LISTS will expand those "" arguments into nothing.
I referenced this question on Stack Overflow: https://stackoverflow.com/questions/72157973/cmake-generator-expression-evaluated-to-instead-of-nothing
Let me know if this works for you.

@wsherman64 I'm not able to repro the problem on our Linux machine, it seems to work fine with or without Andrew's change.
Can you confirm if this fixes it for you please?

Yes, Andrew's change fixes the problem for me.  I also tried with an empty "CMAKE_BUILD_TYPE" with the previous version to see whether that's why Roderick wasn't seeing the problem at all, but I still got the error with that (again, with the version before Andrew's change).  So I'm not sure why it worked for Roderick.  For the record, I'm running Rocky Linux 8.8, and using CMake version 3.27.1.
I wonder @rvkennedy if you can set "export VERBOSE=1" before doing a build with the old method and report what make outputs when doing the Generating VertexShader.spv step -- which for me happens at 60% of the build process.  For me it was as reported above, where glslangValidator is called with these (and more) arguments: -S vert -e main -x -gVS "" "" --target-env vulkan1.0.  I'm curious as to whether it's something CMake is doing, or `glslangValidator is doing.
BTW, I have a couple other questions regarding the CMake options, plus a question about building for Vulkan, but I'll post those as separate issues.

Looks like if you have glslc, that will be used in preference to glslangvalidator. But even disabling this, and using CMAKE_VERBOSE_MAKEFILE to ensure "export VERBOSE=1" is added, I don't see the quote marks. This is CMake 3.27.1 on Ubuntu 20.04:
/usr/bin/glslangValidator -o /home/roderick/openxr-tutorial-src/build/Chapter3/VertexShader.spv -S vert -e main -x -gVS -Od  --target-env vulkan1.0 -V /home/roderick/openxr-tutorial-src/Chapter3/../Shaders/VertexShader.glsl

Thanks for checking @rvkennedy.  I don't have "glslc" on my system (and it doesn't seem to be in any available packages) -- but I'm not overly worried about that, was just hoping the CMake configuration could be simplified.
Regarding the double quotes -- that does surprise me, given that we're using the same version of CMake, and I don't know what other aspect of Ubuntu vs. Rocky would make a difference.
So I do want to confirm -- that was with the version of the tutorial before Andrew added the COMMAND_EXPAND_LISTS command to the CMake configuration?

Hi @wsherman64, for me, neither version adds spurious double quotes.

Okay, well I'm not sure why I was seeing the double quotes and Roderick isn't, but regardless, Andrew's changes has fixed it for me.


[CAMEL-11093] NPE when defaultValueProvider not given

This PR has been merged, do you mind closing it ?


How to add images to gallery categories in the portfolio section?

Gallery section (portfolio): How do I configure the gallery to show images per categories only? Currently the gallery shows all images from all categories and not only the one that the user selects. How to make the gallery working to only show the pictures from a specific category and not all pictures from all categories? Any feedback is highly appreciated....

You could make different instances of a gallery. I'd check out the magific popup plugin's docs to figure out how to add more galleries and customize their galleries.


feat: Add lang option to DataType read operations

Fixes #472
Depends on:

[x] https://github.com/digidem/mapeo-schema/issues/165
[x] #466

TODO:

[ ] Add tests once dependencies are ready

The implementation in this draft PR tries to minimize the overhead for looking up translations.
Ready for an initial review.

@EvanHahn non-urgent, but it would be great to have your eyes on this this week to check this approach makes sense. A full review can maybe wait until we get the dependencies in place, but the approach here might affect how we design the translation API.

TranslationApi need dataType in its constructor, but DataType needs translationApi in its constructor. This means that we usually need to do:
let translationApi;
const dataType = new DataType({
  dataStore,
  table,
  db,
  translation: translationApi
})
translationApi = new TranslationApi({
  dataType,
 table
})

This kinda feels weird but it seems to work. Could there be edge cases where this wouldn't work? Is there a pattern that we could have were we avoid this?
A possibility would be to have an init function in, lets say, DataType so that we pass translationApi there, after instancing it...

@EvanHahn do you feel there are e2e-tests that we can add? The ones I added are pretty similar to the translationApi tests with the added layer of going through dataType.getByDocId(docId, {lang}) instead of using translationApi.get()

Nah, I think those are good enough!
I'll review the rest now.


Fix/improve types for Resource and For/Index/mapArray/indexArray

Some minor changes to types.

Resource<T> still extended Accessor<T | undefined> despite other changes to createResource. This PR completes the fix intended in https://github.com/solidjs/solid/commit/85fe17b18a681d828582c8a0d9b16990d25e6a58 removing the undefined.
Added falsy types to the each accessor in For, Index, mapArray and indexArray so that patterns such as <For each={resource()} /> and For each={store.nullable?.list} work. I'm not sure if false is necessary here, but added it anyway for consistency with Show.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.541%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1065

Relevant Lines:
1127

💛  - Coveralls


Implement benchmark test suite

It would be nice to have a collection of benchmarks for integration methods that could be run to assess potential changes for performance impacts, identify performance regressions and opportunities for improvement, etc.

This GitHub Action package looks promising and has built-in Julia support
https://github.com/marketplace/actions/continuous-benchmark

@JoshuaLampert, have you seen/used AirspeedVelocity.jl? It looks like this is actually what Miles used for the DynamicQuantities.jl reference above. I like how it automatically generates PR comments with benchmark comparisons vs the pull target.

I think I had a brief look at it after I checked the link you send above for DynamicsQuantities, but I don't have any experience with it yet. I agree, it looks pretty nice.


Getting a chown error when running action

/usr/bin/sudo chown -R actions:actions .
chown: invalid user: 'actions:actions'
Error: The process '/usr/bin/sudo' failed with exit code 1

Looks like github changed their image. They are no longer using actions:actions but runner:docker. Very frustrating...

This was resolved on Dec 7, 2020


Remove composer/installers dependency?

As far as I can see composer/installers isn't used in this repo. Is it a remnant from Sage? Eitherway, could the dependency be removed?

Yep, it could be.


UI problems

Hey! It's the guy from reddit. Just filing an issue.
I don't know if it's of any help but here's the link to the Imgur album: https://imgur.com/a/oeCrIQC
Thanks!

Those problems should disappear, when you disallow "custom themes" in preferences settings.

Hey @Jorengarenar would you mind deleting this issue? I'm trying to clean up my github account, and since you have the solution in the readme this issue seems to be useless. Thanks!


[nrf fromtree] twister: Bring back scope selection rule using platfor…

…m_allow
A change to the scope selection rules was introduced by #52715 but it doesn't comply with the description in the code. What's more, the change introduces major issues i.e. non deterministic scope selection, especially in a CI environment. More context at #57595
(cherry picked from commit 3bf7f83f213f96daa9a17cd3ddd4cff0a200bb9d)
Signed-off-by: Maciej Perkowski<EMAIL_ADDRESS>

Is this fromlist or fromtree? If fromlist there should be no SHA, but a link to a PR

fixed, thanks

make it fromtree now please

Done


TouchableWithoutFeedback does not fire onPress like other Touchable Components

🐛 Bug Report

Same as closed bug #18611
TouchableWithoutFeedback does not call the onPress handler unless it's direct child is a View Component. This is counter to the fact that other touchable components will allow custom components as their child.
To Reproduce

Create a FlatList
Create a ListItem that utilizes a TouchableWithoutFeedback component with an onPress handler
Add a non-View child Component, any custom component that renders content.
Test by tapping ListItem and find that no onPress event is fired.

Expected Behavior

I would think that the expected behavior would be that the onPress event would be fired no matter what child component the TouchableWithoutFeedback component
Code Example

https://github.com/haddow777/tech_stack
Specifically look at the file ./src/components/ListItem.js. That is where the TouchableWithoutFeedback component is used. In it's current state, the event does not fire. If I encapsulate the current children in a View component tag, the event will fire. I changed the TouchableWithoutFeedback with a TouchableOpacity component without the View component child, and the onPress fires. It seems they should both work the same.
Environment

React Native Environment Info:
    System:
      OS: Windows 10
      CPU: (4) x64 Intel(R) Core(TM) i5-4300U CPU @ 1.90GHz
      Memory: 1.27 GB / 7.91 GB
    Binaries:
      Yarn: 1.13.0 - C:\Users\SURFACE\AppData\Roaming\npm\yarn.CMD
      npm: 6.8.0 - C:\Program Files\nodejs\npm.CMD
    IDEs:
      Android Studio: Version  <IP_ADDRESS> AI-181.55<IP_ADDRESS>56338

Android Emulator api 27
react-native-cli: 2.0.1
react-native: n/a - not inside a React Native project directory

Repro Snack: https://snack.expo.io/@jkcooper/rn23740-touchablewithoutfeedback-wrapping-custom-component

@haddow777 you are right. Other touchable components wraps child content to another <View> and pass all touchable props into it.
TouchableWithoutFeedback just clone child. And if child doesn't pass all RN props into nested View it doesn't work.

Should there be a View inside a TouchableWithoutFeedback element? Im not sure what effect that would have on existing usages

Dear @haddow777 and @radeno
Thanks, both of you help me a lot, other Touchable component works properly but the TouchableWithoutFeedback without View inside it doesn't dispatch pressing in the iOS.

All that you need to do is to pass your custom child component's props to root view

Repro Snack: https://snack.expo.io/@jkcooper/rn23740-touchablewithoutfeedback-wrapping-custom-component
Seems to affect both iOS and android

fixed in<EMAIL_ADDRESS>

Using latest react-native (0.59.5), I can't make a TouchableWithoutFeedback or TouchableNativeFeedback work inside a FlatList, the ripple is there (with native feedback) but onPress is never called, even with a basic <View />.
No issues with Opacity/Highlight touchable components.
eg:
    <FlatList
      // ItemSeparatorComponent={Platform.OS !== 'android' && ({highlighted}) => (
      //   <View style={[style.separator, highlighted && {marginLeft: 0}]} />
      // )}
      data={data}
      renderItem={({item, separators}) => (
        <TouchableNativeFeedback
          delayPressIn={0}
          delayPressOut={0}
          onPress={() => onPress(item.key)}
          style={{zIndex: 99, flex: 1}}
        >
          <View style={{flex: 1}}>
            <Text>FooBar</Text>
          </View>
        </TouchableNativeFeedback>
      )}
    />

Hello there 👋 by using the repro / the list of steps to reproduce, we can't actually see the reported bug on RN 0.59 so we'll close this issue. It may have something to do with your local setup, please double check that you are using the correct version of Android Studio / XCode / Android NDK / Yarn / etc.

I'm on 0.59.8 and I can confirm that this issue is present. My TouchableWithoutFeedback does not fire inside my FlatList cells, whereas TouchableOpacity does.


How to use Safari view controller plugin to SSO to a corporate web site

We need some help and guidance on the best way to achieve SSO between a mobile app and a web portal hosted within our enterprise.  The mobile app would contain hard links to specific sites within the web portal. Idea is that the user should be able to click on those hard links in the mobile app and navigate to those sites without having to log in again in the web portal.  (hence, the need to establish SSO between the web portal and mobile app).
Currently, the mobile app uses basic auth by authenticating against a simple auth service.  We are changing the auth service to now return a JWT token to the mobile app on a successful login.  The web portal currently allows authentication using a home-grown IDP which uses SAML 2.0 tokens to login a user.  We are also adding a new API in the home-grown IDP to accept a JWT token, validate it with the auth service and return a SAML 2.0 token to allow the user to log into the web portal.  Since the web portal would trust any SAML 2.0 tokens issued by the home-grown IDP, we dont think this would be a problem.
Our challenges for now are how to use the SafariViewController plugin to pass the JWT token the mobile app gets from the auth service to the home-grown IDP when the user clicks on a hard link to the web portal in the mobile app.  I cannot see a way to pass headers in this plugin to the browser.  We want the user to be able to launch the default mobile browser when they click on the link (i.e. Safari on iOS, Chrome on Android).
Ploease help.

@ajayindfw  So you're struggling to find a way to pass your token back to the app, is that right?

I would prob pass it as a parameter to a proxy and curl the final url with just inside the headers.

The current correct approach on iOS 11 is using SFAuthenticationSession I think (not SafariViewController). Take a look at this different plugin and see if it matches what you're trying to do: https://www.npmjs.com/package/cordova-plugin-sfauthenticationsession
Also, take a look at Apple's page on the SFSafariViewController, which says:

If you would like to share data between your app and Safari in iOS 11 and later, so it is easier for a user to log in only one time, use SFAuthenticationSession instead.


bump-formula-pr: fix duplicates check

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew tests with your changes locally?

return unless pull_requests && !pull_requests.empty? and
return unless pull_requests&.empty? are not equivalent.
Fixes a bug introduced by https://github.com/Homebrew/brew/pull/3183
that led to bump-formula-pr claiming there were duplcate PRs when there
were none.

Thanks for the quick fix @ilovezfs and sorry for the breakage.


Add language: dyff

Language name
dyff
URL of example repository
https://github.com/homeport/dyff
URL of syntax highlighting grammar
TBD
Most popular extensions
unaware of extensions, if any
Detected language
N/A(?)
I would love to have dyff highlighting in code blocks on PRs. Initially I went down the path of having a highlight.js addition for this language, but then the github docs seem to suggest liguist as the way to go - to which I am opening this issue here.

Vietnam

Do you know what would be the best way to achieve this?

Yup. Hit the "Contact GitHub" link on any page, or reach out in the discussions at https://github.com/community

Thanks for your input.
For completion, I wrote this community post as product feedback.


Fix onDateChange on iOS

There is an issue with DatepickerIOS regarding onDateChange https://github.com/facebook/react-native/issues/8169 . This is not fixed yet but there is a workaround suggested that I applied on react-native-datepicker

Coverage decreased (-2.7%) to 97.321% when pulling e4e2193ef3d6ba949a12be5496fc94bf08280ff4 on stephanemaillard:master into 95c7d6481541924a2c162f7989906167797a1da3 on xgfe:master.

I've pulled this change into one of my projects and it has resolved all date change issues I was experiencing.  Thank you so much.  Hoping this gets pulled into the project soon.

Wonderful! It dose work. But why set 500ms timeout? Whether it can be sonner?

It could probably work with a shorter timeout but I don't know what is the limit that will work in all situations and devices.


Detect broken links during build

It would be nice when we build to have a report on  internal links, including broken links (with an option to make that an error), broken anchors (same), and pages unreachable from the index.

See e.g. https://github.com/observablehq/framework/pull/1203


Kcctl apply - Read from stdin

Hi,
It would be nice to be able to read the connector configuration from stdin when calling kcctl apply.
As --file option is required, it might be handled like Kubernetes by reading stdin when the option is equals to "-" :

Apply the JSON passed into stdin to a pod
cat pod.json | kubectl apply -f -

cf the kubectl doc :

Interesting proposal; do you have a specific use case in mind for this? Some kind of dynamically generated config perhaps? In any case, seems like a reasonable idea to support reading config from stdin, alone for being a good CLI citizen. Wanna give it a try?

Yes, our connectors' configurations are injected to our pods as environnement variables.
I will gladly provide a PR :)

Excellent, thanks a lot and looking forward to the PR! Out of curiosity, couldn't you expose those connector configs as a config map alternatively? And as you are running on Kubernetes, have you looked into using Strimzi for deploying Kafka, Connect, and connectors via custom resources? Not that I want to argue against the proposed change (I really like it), just curious about your usage :)

We use Helm with the image :  confluentinc/cp-kafka-connect on GKS, we did this as we copied the way we deploy our apps. We also use Vault not only as a secret manager but also as a configuration manager ( thanks to banzai cloud ) so that's why our connectors' configurations are injected as env variables.
I will take a look at Strimzi, Thanks.

And applied, great improvement! Thanks, @Thomas-Dangleterre!


Finalizing the units cleanup for Parameters

What is the change?
Jere I finalized the units cleanup for Parameters, by fixing our units the looked like this:
units="kg/s"

to actually use our units library:
units="{units.KG}/{units.SECONDS}"

Why is the change being made?
This change gives our Parameter units 99% more internal consistency, and removes all kinds of strange spellings and corner cases.
But, also, this should close #351.
And maybe #352 will be complete. OR if you want to go all the way to using pint in ARMI, this PR sets that up to be much less work, because our units are much more consistent.

Checklist

[X] This PR has only one purpose or idea.
[X] Tests have been added/updated to verify that the new/changed code works.

[X] The code style follows good practices.
[X] The commit message(s) follow good practices.

[X] The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
[X] The documentation is still up-to-date in the doc folder.
[X] The dependencies are still up-to-date in setup.py.

@keckler Sorry for the big review lifts lately.  You'll have to tell me if you think this closes the #351 or #352 tickets.
I think this is definitely progress.  What are you thinking?

This definitely closes #351. I would say it doesn't close #352 , but I agree that it gets us much closer. I very much like the last part of the description that Nick put in his comment, and we definitely don't accomplish that here. I suppose we should evaluate whether or not #352 will ever actually happen.


Bug - Uncaught TypeError: Cannot read property 'position' of undefined

My app is crashing due to an uncaught exception. See below for details. Perhaps this could be handled more gracefully such a console warning?
Uncaught TypeError: Cannot read property 'position' of undefined
    at nodes.reduce.x (zoom.js:448)
    at Array.reduce (<anonymous>)
    at getRectOfNodes (zoom.js:448)
    at zoom.js:448
    at easy-peasy.esm.js:333
    at simpleProduce (easy-peasy.esm.js:305)
    at runActionReducerAtPath (easy-peasy.esm.js:332)
    at reducerForActions (easy-peasy.esm.js:342)
    at rootReducer (easy-peasy.esm.js:361)
    at dispatch (redux.js:213)
    at easy-peasy.esm.js:538
    at easy-peasy.esm.js:807
    at index.js:11
    at Object.dispatch (easy-peasy.esm.js:890)
    at actionCreator (easy-peasy.esm.js:698)
    at zoom.js:448
    at commitHookEffectListMount (react-dom.development.js:19731)
    at commitPassiveHookEffects (react-dom.development.js:19769)
    at HTMLUnknownElement.callCallback (react-dom.development.js:188)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:237)
    at invokeGuardedCallback (react-dom.development.js:292)
    at flushPassiveEffectsImpl (react-dom.development.js:22853)
    at unstable_runWithPriority (scheduler.development.js:653)
    at runWithPriority$1 (react-dom.development.js:11039)
    at flushPassiveEffects (react-dom.development.js:22820)
    at performSyncWorkOnRoot (react-dom.development.js:21737)
    at react-dom.development.js:11089
    at unstable_runWithPriority (scheduler.development.js:653)
    at runWithPriority$1 (react-dom.development.js:11039)
    at flushSyncCallbackQueueImpl (react-dom.development.js:11084)
    at flushSyncCallbackQueue (react-dom.development.js:11072)
    at discreteUpdates$1 (react-dom.development.js:21893)
    at discreteUpdates (react-dom.development.js:806)
    at dispatchDiscreteEvent (react-dom.development.js:4168)

Hey! Thanks for the report. How can we reproduce this issue?

Hey,
I think you are trying to access the position property of an element which is not a node (may be an edge).
so, that error usually comes when you try to access position which doesnt have position.
Try checking with the built in - isNode(arr[element]) && // your functionality.
just a guess.
try if it works. I got this issue few times.

this.state.elements.find((el, key) => {
if (isNode(el)) {
// your functionality
}
}
something like this.

So the issue happens when the flow is being rendered. I'm not trying to access the position property of a node. I'm not sure what's causing this as my input seems valid.

can you may be post the input,
and a way to debug it.
we'll see if we can help in any way.
:)

Can you create a codesandbox or repo so that we can check your code?

Thanks for the help. Ok, I was able to reproduce the issue on code sandbox. The ReactFlow elements input below will consistently crash the flow renderer.
https://codesandbox.io/s/cranky-worker-dymfw?file=/src/App.js
[
   {
      "id":"1",
      "data":{
         "label":{
            "key":null,
            "ref":null,
            "props":{
               "nodeData":{
                  "title":"Incoming Call",
                  "value":"callFlowsStart",
                  "icon":"/static/media/phone.b522cc6c.svg"
               }
            },
            "_owner":null,
            "_store":{

            }
         }
      },
      "position":{
         "x":1081,
         "y":500
      },
      "className":"ds__flow__node ds__flow__start__node",
      "type":"input",
      "selectable":true
   },
   {
      "id":"fe76a8ea-743a-45b6-9f5e-59b31af72fe8",
      "data":{
         "label":{
            "key":null,
            "ref":null,
            "props":{
               "showTrace":false,
               "node":{
                  "type":"menu",
                  "id":"fe76a8ea-743a-45b6-9f5e-59b31af72fe8",
                  "options":{
                     "routes":[
                        {
                           "key":"1",
                           "childId":"9d2cc551-4fcc-47c8-b36f-780233b3a9a2"
                        },
                        {
                           "key":"2",
                           "childId":"9dcbe879-154e-44ae-b0d3-31a8fc8ce422"
                        }
                     ],
                     "valid":true
                  },
                  "children":[
                     {
                        "type":"nodeContainer",
                        "id":"9d2cc551-4fcc-47c8-b36f-780233b3a9a2",
                        "children":[
                           {
                              "id":"f214252c-006a-4204-80ae-15f35409e83a",
                              "type":"menu",
                              "options":{
                                 "routes":[

                                 ],
                                 "valid":false
                              },
                              "children":[

                              ]
                           }
                        ],
                        "options":{
                           "key":"1",
                           "containerType":"menu"
                        }
                     },
                     {
                        "type":"nodeContainer",
                        "id":"9dcbe879-154e-44ae-b0d3-31a8fc8ce422",
                        "children":[
                           {
                              "id":"2a499840-bb28-4fef-ac60-c381f05c24b8",
                              "type":"menu",
                              "options":{
                                 "routes":[

                                 ],
                                 "valid":false
                              },
                              "children":[

                              ]
                           }
                        ],
                        "options":{
                           "key":"2",
                           "containerType":"menu"
                        }
                     }
                  ]
               },
               "nodeData":{
                  "title":"Menu",
                  "value":"menu",
                  "icon":"/static/media/menu.fda4821f.svg",
                  "treeModifyNodeModalIconHeight":"4rem",
                  "color":"var(--teal-flow-node)"
               },
               "isExitNode":false
            },
            "_owner":null,
            "_store":{

            }
         }
      },
      "position":{
         "x":1000,
         "y":650
      },
      "className":"ds__flow__node",
      "selectable":true
   },
   {
      "id":"e1--fe76a8ea-743a-45b6-9f5e-59b31af72fe8",
      "source":"1",
      "target":"fe76a8ea-743a-45b6-9f5e-59b31af72fe8",
      "type":"custom",
      "animated":false
   },
   {
      "id":"f214252c-006a-4204-80ae-15f35409e83a",
      "data":{
         "label":{
            "key":null,
            "ref":null,
            "props":{
               "showTrace":false,
               "node":{
                  "id":"f214252c-006a-4204-80ae-15f35409e83a",
                  "type":"menu",
                  "options":{
                     "routes":[

                     ],
                     "valid":false
                  },
                  "children":[

                  ]
               },
               "nodeData":{
                  "title":"Menu",
                  "value":"menu",
                  "icon":"/static/media/menu.fda4821f.svg",
                  "treeModifyNodeModalIconHeight":"4rem",
                  "color":"var(--teal-flow-node)"
               },
               "isExitNode":true,
               "label":"Caller enters 1"
            },
            "_owner":null,
            "_store":{

            }
         }
      },
      "position":{
         "x":600,
         "y":900
      },
      "className":"ds__flow__node",
      "selectable":true
   },
   {
      "id":"efe76a8ea-743a-45b6-9f5e-59b31af72fe8--f214252c-006a-4204-80ae-15f35409e83a",
      "source":"fe76a8ea-743a-45b6-9f5e-59b31af72fe8",
      "target":"f214252c-006a-4204-80ae-15f35409e83a",
      "type":"custom",
      "animated":false
   },
   {
      "id":"ef214252c-006a-4204-80ae-15f35409e83a--2",
      "source":"f214252c-006a-4204-80ae-15f35409e83a",
      "target":"2",
      "type":"custom",
      "data":{
         "centerY":1120
      }
   },
   {
      "id":"2a499840-bb28-4fef-ac60-c381f05c24b8",
      "data":{
         "label":{
            "key":null,
            "ref":null,
            "props":{
               "showTrace":false,
               "node":{
                  "id":"2a499840-bb28-4fef-ac60-c381f05c24b8",
                  "type":"menu",
                  "options":{
                     "routes":[

                     ],
                     "valid":false
                  },
                  "children":[

                  ]
               },
               "nodeData":{
                  "title":"Menu",
                  "value":"menu",
                  "icon":"/static/media/menu.fda4821f.svg",
                  "treeModifyNodeModalIconHeight":"4rem",
                  "color":"var(--teal-flow-node)"
               },
               "isExitNode":true,
               "label":"Caller enters 2"
            },
            "_owner":null,
            "_store":{

            }
         }
      },
      "position":{
         "x":1400,
         "y":900
      },
      "className":"ds__flow__node",
      "selectable":true
   },
   {
      "id":"efe76a8ea-743a-45b6-9f5e-59b31af72fe8--2a499840-bb28-4fef-ac60-c381f05c24b8",
      "source":"fe76a8ea-743a-45b6-9f5e-59b31af72fe8",
      "target":"2a499840-bb28-4fef-ac60-c381f05c24b8",
      "type":"custom",
      "animated":false
   },
   {
      "id":"e2a499840-bb28-4fef-ac60-c381f05c24b8--2",
      "source":"2a499840-bb28-4fef-ac60-c381f05c24b8",
      "target":"2",
      "type":"custom",
      "data":{
         "centerY":1120
      }
   },
   {
      "id":"2",
      "data":{
         "label":{
            "key":null,
            "ref":null,
            "props":{
               "nodeData":{
                  "title":"Exit",
                  "value":"exit",
                  "treeModifyNodeModalIconHeight":"3.6rem",
                  "icon":"/static/media/exit.f9150e2d.svg"
               },
               "noNodes":false
            },
            "_owner":null,
            "_store":{

            }
         }
      },
      "position":{
         "x":1119.5,
         "y":1120
      },
      "className":"ds__flow__node ds__flow__start__node",
      "type":"input",
      "selectable":true
   }
]

Sorry, actually it seems like another issue with rendering objects. Let me see if I can get the same error as before. This is the input I'm using.

So I'm having a tough time reproducing because I'm using a number of custom labels as well as custom edges that would take some time to port over to code sandbox. I tried removing all of those, it seemed to render fine then. I'm going to do some more investigating to see if I can find the cause here. Hopefully, the stack trace above helps in some way. Thanks for the help here though. Really appreciate the quick responses.

@moklick @harish-madugula
Ok so after a lot of testing I finally was able to reproduce this in code sandbox.
The issue seems to be related to updating the position of a node, unmounting the flow render component, and then trying to remount. I also notice this issue when the nodes the flow works on are changed specifically when the flow rendered component is unmounted.
I think the issue is some redux state for the component is being preserved when the component is unmounted and then when it tries to read it again on mount, it throws an error.
Steps to reproduce.

Toggle the flow on
Move reposition nodes
Toggle the flow off
Add nodes
Toggle the flow on

I've attached a screen recording as well to show these steps. See the google drive link if you're having trouble.
https://drive.google.com/file/d/1FrQT1HwJhCU-L2q-v6ugAQG_7aYhcdio/view?usp=sharing
https://codesandbox.io/s/cranky-worker-dymfw?file=/src/App.js

Ok, thanks for the detailed information on this :) I will see how we can fix this

Thanks, @moklick. It's really hard to use this feature in my app right now because of the crashes, so it would be awesome if this could be patched soon.

I just implemented a fix. Can you check v5.9.4?

Seems like this is fixed now. I will continue testing to make sure. Thanks so much for getting this out quickly. I really appreciate it.

I upgraded to 5.9.4 and I get a similar error: cjs.js:12 Uncaught TypeError: Cannot read property 'x' of undefined
the cjs.js is:

var _require = require('./Draggable'),
    Draggable = _require.default,
    DraggableCore = _require.DraggableCore; // Previous versions of this lib exported <Draggable> as the root export. As to no-// them, or TypeScript, we export *both* as the root and as 'default'.
// See https://github.com/mzabriskie/react-draggable/pull/254
// and https://github.com/mzabriskie/react-draggable/issues/266

module.exports = Draggable;
module.exports.default = Draggable;
module.exports.DraggableCore = DraggableCore;```

@chiester Could you link to a code sandbox with steps on how to reproduce the issue.

🆙 My error was due to messing up with node.__rf.width and node.__rf.height properties


[IOS] Scrollbar position is incorrect in ios device

In My sample, I'm wrapping the SingleChildScrollView as a child of the Scrollbar. Then, set the container as a child of the SingleChildScrollView. Now am scrolling the container horizontally, the scrollbar has shown inside the container instead of the end.
Code Sample
import 'package:flutter/material.dart';

void main() {
  runApp(MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const DemoApplication()));
}

class DemoApplication extends StatefulWidget {
  const DemoApplication({Key? key}) : super(key: key);

  @override
  _DemoApplicationState createState() => _DemoApplicationState();
}

class _DemoApplicationState extends State<DemoApplication> {
  ScrollController scrollController = ScrollController();

  @override
  void initState() {
    super.initState();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          title: const Text('Flutter Demo'),
        ),
        body: Scrollbar(
          isAlwaysShown: true,
          controller: scrollController,
          child: SingleChildScrollView(
              scrollDirection: Axis.horizontal,
              controller: scrollController,
              child: Container(
                color: Colors.amber,
                height: 400,
                width: 2000,
              )),
        ));
  }
}

Actual results:

Expected results:

Thanks for your reply, but the details mentioned in that documentation could not solve my issue. Because am facing the issue with the ios device.

@Tamilarasan-Paranthaman
Can you try below code which properly places the scrollbar as expected:
body: MediaQuery(
          data: MediaQuery.of(context).removePadding(removeBottom: true),
          child: Scrollbar(
            thumbVisibility: true,  // on master, isAlwaysShown is replaced by thumbVisibility
            controller: scrollController,
            child: SingleChildScrollView(
                scrollDirection: Axis.horizontal,
                controller: scrollController,
                child: Container(
                  color: Colors.amber,
                  height: 400,
                  width: 2000,
                )),
          ),
        )


Unable to GET Core-Command Device Resources

🐞 Bug Report
Affected Services

 The issue is located in: core-command
Is this a regression?

 No
Description and Minimal Reproduction

Running services with nightly-build docker-compose-nexus-no-secty.yml
Open browser to GET http://localhost:48082/api/v1/device

🔥 Exception or Error

🌍  Your Environment
Deployment Environment:
MacOS
EdgeX Version:
Anything else relevant?
edgexfoundry/blackbox-testing/issues/387

I've investigated this and I believe this was handled by #2370.


[Bug]: The go install command doesn't work

Current Behavior

The command doesn't specify the version
The go.mod contains a replace directive, which is not supported by go install

Expected Behavior
No response
Steps To Reproduce
No response
Environment
No response
Anything else?
No response

Install does not work since we replace it with modified version from milvus-io
Will try to use the original version


clientv3: fix current watcher reconnection

If a current watcher didn't receive any events, a reconnect cycle would
advance its revision to the store's current revision. Instead, reconnect
using the watcher's creation header revision if the watcher hasn't received
any events.
Fixes #4502

LGTM.

merging on greenlight


Fix fossa script

Pull Request Test Coverage Report for Build 29a7e593-e171-4502-abd8-bdef4e94ac93

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 74.662%

Files with Coverage Reduction
New Missed Lines
%

internal/internal_task_pollers.go
2
73.04%

internal/common/convert.go
3
84.62%

Totals

Change from base Build 5db965ff-5fe4-4138-8a26-265184f5b37e:
-0.04%

Covered Lines:
9276

Relevant Lines:
12424

💛  - Coveralls


[REST Server][Web Portal]Apply patches to vulnerable dependencies

Ref: https://docs.npmjs.com/misc/semver#tilde-ranges-123-12-1
Using tilde-version-ranges in package.json will enable yarn(another node package manager)'s upgrade feature to apply patches to each dependencies with minimum changes.
Moreover, using yarn.lock to lock the upgraded version that make user using the validated version.
Unfortunately, file-loader still introduced a breaking change as a patch, already migrated in this PR.

Coverage increased (+8.7%) to 59.984% when pulling f6e3031adc5b626cafa143d6d70a7c5c620f3ee4 on qixcheng/upgrade-dependencies into 6ae607c4ed1a2e4ac173e6b509fd3c8f74a36f76 on master.

Coverage increased (+8.7%) to 59.984% when pulling f6e3031adc5b626cafa143d6d70a7c5c620f3ee4 on qixcheng/upgrade-dependencies into 6ae607c4ed1a2e4ac173e6b509fd3c8f74a36f76 on master.


Performance of GraphCast_small vs regular GraphCast vs GraphCast_operational

Hi,
Is there data comparing the performance of GraphCast_small vs that of the regular, high-resolution version of GraphCast? I would assume that the GraphCast_small wouldn't perform quite as well, but I am curious as to by how much.
Also, for the GraphCast_operational model, what does it mean for the model to be fine-tuned on HRES data from 2016 to 2021 after already being trained on earlier ERA5 data?
Thanks in advance for any insight!

Is there data comparing the performance of GraphCast_small vs that of the regular, high-resolution version of GraphCast? I would assume that the GraphCast_small wouldn't perform quite as well, but I am curious as to by how much.

I don't really recall the exact numbers but resolution does matter, especially in short lead times and especially for variables with high frequency components. That said, if I remember correctly, we are talking about errors that are worse by between 0% and 20% depending on the variable and lead time (but please don't just take my word for it, I would recommend you to run your own comparisons on the provided test data). Of course these differences may be sufficiently large such that the small model may not be better than the operational HRES model in some variables and lead-times.

Also, for the GraphCast_operational model, what does it mean for the model to be fine-tuned on HRES data from 2016 to 2021 after already being trained on earlier ERA5 data?

The ERA5 re-analysis data, does not actually look identical to the operational analysis data that ECMWF publishes in realtime, and that can given as inputs. This is because (1) the NWPs used to do the assimilation are different, (2) the resolution at which the assimilation is done is also different, (3) the assimilation windows are also different, (4) I think sometimes it is also not exactly the same set of observations that contribute to the assimilation. So for a model to work best operationally, it needs to have been trained a bit on operational data.
Now, operational data at this resolution is only available from 2016, but ERA5 is available for tens of years, so it is still beneficial to use ERA5 for the sake of additional availability of data.
So essentially the way we approach this was to pre-train on ~40 years of ERA5, and then fine-tune the models on ~6 years of operational data.
Hope this makes sense!


fix(dropdown): added ngbdropdown to have dropdown class always

Before submitting a pull request, please make sure you have at least performed the following:

[X] read and followed the CONTRIBUTING.md guide.
[X] built and tested the changes locally.
[X] added/updated any applicable tests.
[X] added/updated any applicable API documentation.
[X] added/updated any applicable demos.

fixes #361

This is a good fix but we need to add a check for this class in one of the unit tests.

Do we want tests for all these classes on host? Wouldn't this theoretically mean we need to do this for the other components too?

Do we want tests for all these classes on host? Wouldn't this theoretically mean we need to do this for the other components too?

We do have tests for other cases already!

Ah, was not aware - fair enough then

@pkozlowski-opensource I checked, since there was no check for dropdowntoggle class. I kinda omitted it. Again I think it should be there. I will update

@pkozlowski-opensource ping

@sendilkumarn, please be patient.  we are all busy and Pawel will answer when he has a moment to do so.  he typically bikes home from work around now.
also, you forgot to run the clang formatter so the build failed.

@icfantv just pinged to inform that the issue is fixed.
point noted :)


chore(region): add optional override of base URL through env var

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


For Loops 2.0: Index Notation And The Future Of Tensor Compilers | Peter Ahrens

For Loops 2.0: Index Notation And The Future Of Tensor Compilers, https://www.youtube.com/watch?v=Rp7sTl9oPNI
I hope that these timestamps are not too bad.
Contents
00:00 Welcome!
00:18 My Julia story is surprising normal
01:20 Some horror show code from times before I start using Julia
01:37 How I get interested in tensor compilers
02:40 Loop nest monster, the motivation behind everything I have done
03:36 If you want write compiler that can compile tensor operations, you need to answer couple of questions
05:01 How do we express a tensor operation? The answer to this question changes how we think about all the rest
05:15 Short history of interfaces
07:10 Named operation can trade their performance for expressiveness
07:56 Index notation
09:18 Index notation vs for loop
10:50 Matricized Tensor Times Khatri-Rao Product (MTTKRP)
12:30 Tortilla.jl, wrapper for TACO (The Tensor Algebra Compiler)
13:20 Our operations is data
14:00 Some examples of using index notation
15:00 Friends of index notation
16:25 Few words about tensor compilers
17:40 The polyhedral model
18:42 Halide language
19:25 TACO: A fast and versatile compiler-based library for sparse linear and tensor algebra
21:38 Few thoughts about arrays (see also MetaArrays.jl)
22:28 Cool index notation packages: TensorOperations.jl, Tensor.jl, Einsum.jl, ...
22:40 The home-grown Julia DSL
23:27 You don't need to generate fast code. You only need to generate code that Keno Fischer can make fast with optimizer
23:59 But what about "The Future"?
25:22 Live demo
27:50 Q&A: What tensor compilers can achieve now?
29:57 Q&A: Can TACO generate GPU code?
31:17 Q&A: What do you think about future of GraphBLAS?
Resources
Einsum.jl
GraphBLAS
Halide
MetaArrays.jl
TACO
TensorOperations.jl
Tensor.jl

Timestamps were added to the video. We will close this issue, when we get access rights to this GitHub repository.


python库装不上去是咋回事啊

[root@VM-16-14-centos OPQ-SetuBot]# pip install -r requirements.txt
WARNING: Running pip install with root privileges is generally not a good idea. Try pip install --user instead.
Collecting botoy>=8.0.0 (from -r requirements.txt (line 1))
Could not find a version that satisfies the requirement botoy>=8.0.0 (from -r requirements.txt (line 1)) (from versions: 0.0.2, 0.0.3, 0.0.4, 0.0.5, 0.0.6, 0.0.7, 0.0.8, 0.0.9, 0.0.10, 0.0.11, 0.0.12, 0.0.13, 0.0.14, 0.0.15, 0.0.16, 0.0.17, 0.0.18, 0.0.19, 0.0.20, 0.0.21, 0.0.22, 0.0.23, 0.0.24, 0.0.25, 2.0, 3.0, 3.1, 4.0, 4.1, 4.2, 4.3, 4.4, 4.5, 4.6, 4.7, 4.8, 4.9, 5.0, 6.0, 6.1, 6.2, 6.3, 6.4, 6.5, 6.6, 6.7, 6.8, 6.9, 6.10, 7.0)
No matching distribution found for botoy>=8.0.0 (from -r requirements.txt (line 1))

你这个pip的python3的什么... centos的python版本应该没有到3.8吧
好像是的，我刚去查了下python库是3.6，我这就去升级一下试试

好像是的，刚查了下python库是3.6，我去升级一下再试试

问题解决了，感谢


Rw button count

I did the character count, input, and button styles. I changed the input container to a textarea to allow the text to wrap. I worked on getting the textarea to autosize based on the amount of content but couldn't quite get it. We can do it as a final wrap up item.
I also:

added reset file
added autosize js file (as mentioned, in progress)
fixed accessibility issues

The only outstanding part is making the buttons responsive and moving them to another line. 🍔

Looks good. Great work!


Adding a 'to_hash' method

The base to_hash method try to serialize all the attributes, and any json serialization fails on the encoding of the file.
2.2.2 :001 > Rack::Test::UploadedFile.new("unnamed.jpg", "image/jpeg").to_json
 => {:content_type=>"image/jpeg", :original_filename=>"unnamed.jpg"}
2.2.2 :002 > {test: Rack::Test::UploadedFile.new("unnamed.jpg", "image/jpeg")}.to_json
Encoding::UndefinedConversionError: "\x89" from ASCII-8BIT to UTF-8
    from /Users/andral/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/core_ext/object/json.rb:34:in `encode'
    from /Users/andral/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/core_ext/object/json.rb:34:in `to_json'
    from /Users/andral/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/core_ext/object/json.rb:34:in `to_json_with_active_support_encoder'
    from /Users/andral/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/json/encoding.rb:57:in `to_json'
    from /Users/andral/.rvm/gems/ruby-2.2.2/gems/json-1.8.3/lib/json/common.rb:223:in `generate'
    from /Users/andral/.rvm/gems/ruby-2.2.2/gems/json-1.8.3/lib/json/common.rb:223:in `generate'
    from /Users/andral/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/json/encoding.rb:101:in `stringify'
    from /Users/andral/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/json/encoding.rb:35:in `encode'
    from /Users/andral/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/json/encoding.rb:22:in `encode'
    from /Users/andral/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/core_ext/object/json.rb:37:in `to_json_with_active_support_encoder'
    from (irb):7

@lambda2 I am currently helping to work on the pending issues and PRs.
This PR seems reasonable to me, could you please add a test that reproduces the error / shows the fix
is working?

Ping @lambda2 - do you have a chance to apply @scepticulous suggestions?

Closing for lack of feedback.
@lambda2 - if you happen to fix this, please apply @scepticulous comments and rebase it on top of current master, and submit a new PR - we'll definitely try to respond faster this time since there are now more hands helping out than before.


Remove EMPTY_LINE(); just use LINE()

This is currently very hard to do because macro varargs doesn't work nicely with 0 args, unless some dark macro magic is involved.


swiper v9 doesn't work with storyshots

Check that this is really a bug

[X] I confirm

Reproduction link
https://github.com/king-of-emotion/swiper-test-app
Bug description
I use swiper with storybook and storyshots. swiper v9 does not work with storyshots, but v8 does work.
I prepare reproduction code in my swiper-test-app repository.
I tried to fix this bug, I found the following code can fix it.
  const swiper = this;
+ this.recalcSlides
  const { params, slidesEl } = swiper;

in loopCreate
But, I don't know about swiper core code, so if you know of a better way, please let me know or fix this problem.
Sorry if I'm wrong with my code, please help.
Expected Behavior
work with storyshots.
Actual Behavior
if yarn test you get error message like bellow
TypeError: Cannot read properties of undefined (reading 'swiperSlideSize')

      at Swiper.swiperSlideSize [as slidesPerViewDynamic] (node_modules/swiper/core/core.js:264:43)
      at Swiper.slidesPerViewDynamic [as loopFix] (node_modules/swiper/core/loop/loopFix.js:38:66)
      at Swiper.loopFix [as loopCreate] (node_modules/swiper/core/loop/loopCreate.js:13:10)
      at Swiper.loopCreate [as init] (node_modules/swiper/core/core.js:474:14)
      at init (node_modules/swiper/components-shared/mount-swiper.js:24:10)
      at node_modules/swiper/react/swiper.js:118:16
      at commitHookEffectListMount (node_modules/react-dom/cjs/react-dom.development.js:23049:26)
      at commitLayoutEffectOnFiber (node_modules/react-dom/cjs/react-dom.development.js:23172:15)
      at commitLayoutMountEffects_complete (node_modules/react-dom/cjs/react-dom.development.js:24578:9)
      at commitLayoutEffects_begin (node_modules/react-dom/cjs/react-dom.development.js:24564:7)
      at commitLayoutEffects (node_modules/react-dom/cjs/react-dom.development.js:24502:3)
      at commitRootImpl (node_modules/react-dom/cjs/react-dom.development.js:26779:5)
      at commitRoot (node_modules/react-dom/cjs/react-dom.development.js:26638:5)
      at finishConcurrentRender (node_modules/react-dom/cjs/react-dom.development.js:25937:9)
      at performConcurrentWorkOnRoot (node_modules/react-dom/cjs/react-dom.development.js:25765:7)
      at flushActQueue (node_modules/react/cjs/react.development.js:2665:24)
      at act (node_modules/react/cjs/react.development.js:2580:11)
      at node_modules/@testing-library/react/dist/act-compat.js:63:25
      at renderRoot (node_modules/@testing-library/react/dist/pure.js:159:26)
      at render (node_modules/@testing-library/react/dist/pure.js:246:10)
      at getRenderedTree (node_modules/@storybook/addon-storyshots/dist/ts3.9/frameworks/react/renderTree.js:24:18)
      at node_modules/@storybook/addon-storyshots/dist/ts3.9/test-bodies.js:9:24
      at Object.<anonymous> (node_modules/@storybook/addon-storyshots/dist/ts3.9/api/snapshotsTestsTemplate.js:29:24)

Swiper version
v9.0.0 or later
Platform/Target and Browser Versions
macOS
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

I'm also getting the error Uncaught TypeError: Cannot read properties of undefined (reading 'swiperSlideSize') since V9. basically from what I can tell, slidesPerView: auto doesn't work.

This error occurs when slidesPerView: auto, centeredSlides: true, loop: true.
Removing either of these will allow storyshots to generate snapshots.

Hi! This issue is likely to be resolved by https://github.com/nolimits4web/Swiper/commit/36ef2e608843b4c83a5dc7ecde30aa71794f639e . Thank you very much.


[#127062871] Track account creation using GA virtual page views

Currently, we are not able to tell using GA how many user accounts have been created. We could try to use a page view of the URL after an account is created to indicate this, however the URL is also accessible from other user flows and will not therefore be an accurate count of how many user accounts have been created.
Therefore, as part of this pivotal story, we wish to send a GA virtual page view every time a buyer account is successfully created. By embedding
data-analytics="trackPageView" data-url="/vpv/?account-created=true"
into our template, we will send the required virtual page view on the success page. This behaviour already exists in the supplier front end but did not yet exist in the buyer front end. I have added it here but this may be something that should be moved into the front end toolkit as there is some code duplication?
This tracking tag will only be embedded if they have come through the account creation process (indicated by setting a flash message).
Note, a similar process has been created for the creation of supplier accounts.

I've been testing this by printing out arguments to the window.ga object into the console,(example code below)
// app/assets/javascripts/_analytics.js

window.ga = function() { console.log(arguments); };
//= include ...

but it wasn't appearing to send the right thing back, which was odd, because the HTML was definitely correct and the JavaScript tests were working as expected.
Problem was that the virtualPageViews() function was never getting called, which it is in the supplier app.
The JS tests call it directly, so that's why they were working even though I couldn't duplicate it in the app.
There's also a couple of imports looking for a deleted file (here are the two commits we have in the supplier app remove them, so you should probably do that here.  (You could also do them in your supplier app pull request if you wanted to anticipate the change.)
Code looks good though, as well as the javascript tests you've written.

Yeah, awesome. Looks 👍  to me.

Worth adding (just saw this out now in the supplier app and it's happening here too), that we seem to be sending two pageviews back to google when we do supplier account creation.

In order, those calls:

create a tracker
anonymize the users ip address
send the normal pageview that we always send when we hit the homepage
send a virtual pageview for the first time a new buyer is logged in

If Ash is fine with it, then it should be fine.  Otherwise, maybe intercept the normal pageview if a virtualpageview is triggered somewhow?
I dunno.  It seems like it's probably fine.

Just spoke to Ash and he is happy with the two page views

👍