Unsupported version of Google App Engine sdk

Hi guys,
This came to my attention today: https://github.com/Trii/NoseGAE/issues/21
After a bit of troubleshooting, I noticed that https://github.com/davidwtbuxton/appengine.py package is out of date and installs an old version of the python sdk. Please update accordingly. This is also why your travis builds are failing.
Let me know if you need any help with it!

Pull request accepted!

Daniel Halperin
Director of Research for Scalable Data Analytics
eScience Institute
University of Washington
On Mon, Feb 16, 2015 at 10:10 AM, Josh Johnston<EMAIL_ADDRESS>wrote:

Hi guys,
This came to my attention today: Trii/NoseGAE#21
https://github.com/Trii/NoseGAE/issues/21
After a bit of troubleshooting, I noticed that
https://github.com/davidwtbuxton/appengine.py package is out of date and
installs an old version of the python sdk. Please update accordingly. This
is also why your travis builds are failing.
Let me know if you need any help with it!
—
Reply to this email directly or view it on GitHub
https://github.com/uwescience/myria-web/issues/254.

What are you using https://pypi.python.org/pypi/appengine for? According to the package page, it is A command-line tool to install the Google App Engine SDK..
According to your .travis.yml you are manually downloading the zip and unpacking it into a directory so I'm not sure what the point is of doing both?
FWIW, I took over NoseGAE a bit ago because it wasn't being maintained and was way out of date. I am trying to make it a better piece of software and by doing that, I am also reaching out to people who I see are having issues with it related to configuration. If you have any requests to make it work better for your project then I would be happy to accept them here: https://github.com/Trii/NoseGAE/issues

Aha, well that's cool! Exciting, and thanks!
Um, there was a reason that most likely involved trying solutions in 1 to 100 stack overflow threads to resolve issues with nose gae in the past. Are you suggesting there is a better solution (maybe, after installing the appengine package I should use it to download the newest app engine).
The most useful thing would be working instructions for how to test Python GAE apps on Travis, which there did not seem to be any of when we set this up.

Right now I have this repo that is hooked up to travis https://github.com/Trii/appengine-buildout-template. It uses buildout to manage dependencies including appengine. Unfortunately that won't work for you though. The biggest issue right now is that the appengine package you are using is old and ends up downloading the 1.8.x SDK. I forked your repo and am trying to see if I can resolve this quickly for you.

See the linked PR, that should resolve your .travis.yml config.

Also there is some stuff in the works to add appengine as a deploy step in travis-ci proper: https://github.com/travis-ci/dpl/pull/221

Thanks!!


Extended Builder class requires explicit default constructor definition

I have a class KeywordDefinition that is annotated with @Builder annotation, and class extending
KeywordDefinitionBuilder. Intellij reports an error if extended class does not have an explicit constructor
with explicit super call even if constructor and super constructor are default constructors. And when I explicitly add those constructors Intellij gives hint that super() call is not needed.
Eg:

This type of error does not appear in netbeans. I know that this is bad design but this is legacy code written by an intern and I do not have time to change implementation (except adding constructors).

It looks like a same cause as in issue #145 and should be fixed by PR #407


Update continuous_mountain_car.py

change action[0] to action
Description
There is no need to use action[0], which may cause bugs when using other repo.

Other repo like tianshou will make action shape (1,) as one single number.
Other env like pendulum also has action shape (1,) but doesn't have this code.

Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Screenshots
Checklist:

[ ] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

My reaction is that we shouldn't support/allow actions outside the action space
Can Tianshou update this on their side? It seems like more of an issue with their implementation than Gymnasium?
I see that this works for Pendulum but this seems like an accident than intended code
@RedTachyon Do you have any thoughts?

What exactly is the problem that this solves? As far as I can tell the only difference is that the type hint is removed for no apparent reason, and you can now pass a 0-dimensional array as an action, which isn't a valid action in the env's action space. And if the action is >2D for some reason, then weird stuff can happen.

@pseudo-rnd-thoughts @RedTachyon
I think you are correct. I should fix it in tianshou rather than gym.


⚠ API - Lens has degraded performance

In 9f89ff5, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 625 ms

Resolved: API - Lens performance has improved in 14dfe04 after 6 minutes.


How to overwrite an existing downloaded video?

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
how can I overwrite an existing videofile?
Here the command line I use
yt-dlp  -S vcodec:h264,res,acodec:aac <URL> -P "J:\" -o TEST.mp4
With this line,  yt-dlp returns [download] J:\TEST.mp4 has already been downloaded
Indeed TEST.mp4 exists but I want to overwrite it.
In the past there was the switch to avoid overwriting. I believe it doesn't overwrite anyonger by default (?) so how can I force overwriting?
Thanks in advance
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

pass --force-overwrite


fix: re-add support for config imports

closes #175

I'll get this reviewed and merged this week, thanks!


Removing unused k8s cloud-config node configs

I should have had this with my previous cloud-config change
This should have been in #752

LGTM


Deprecation warnings for decision boundary plots

/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/sklearn/base.py:446: UserWarning: X does not have valid feature names, but LogisticRegression was fitted with feature names
  "X does not have valid feature names, but"

This seems to affect all the decision boundary plots e.g. this one (https://inria.github.io/scikit-learn-mooc/python_scripts/trees_classification.html):

Should be fixed by merging #484

Done


feat: Multi cluster routing

This PR allows users of the client library to provide a list of clusters in an API request so that routing of requests will stay restricted to that group of clusters.

Just an FYI, if you're working on a branch from a fork, add owlbot:run and kokoro:force-run to kick off tests/post-processing.


Memory leak

System information
- Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes, see below
- OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04 (also demonstrated in Windows 7)
- TensorFlow installed from (source or binary): Binary
- TensorFlow version (use command below): v2.0.0-rc2-26-g64c3d38 2.0.0 (problem disappears on v1.14.0-rc1-22-gaf24dc91b5 1.14.0)
- Python version: 3.6.8
- CUDA/cuDNN version: Cuda v10.0, CuDNN v<IP_ADDRESS>
- GPU model and memory: Nvidia GeForce 840M, but problem persists in non-GPU version
Describe the current behavior
When creating a trivially simple model and then entering a loop that calls predict() with dummy input, memory consumption increases indefinitely over time. On my system, a model with a single hidden layer of only 32 nodes will consume all available system RAM (>10gb) after only 10 minutes. The problem happens on v2.0 (GPU or CPU) of tensorflow, but disappears when running identical code on v1.14.
Describe the expected behavior
Expect memory consumption to quickly stabilize but it never does.
Code to reproduce the issue
from tensorflow.keras import Input, Model
from tensorflow.keras.layers import Dense
import numpy as np

# Build model
In = Input(shape=(10,))
x = Dense(32)(In)
Out = Dense(2)(x)

# Compile
model = Model(inputs=In, outputs=Out)
model.compile(optimizer='adam', loss='mse')

# Create dummy input data
fake_data = np.random.uniform(low=0, high=1.0, size=(1, 10, ))

while True:
    # Repeatedly predict:
    model.predict(fake_data) # No memory leak if this line is replaced with "pass"

I have also experienced this critical issue.

I have managed to get around this error by using model.predict_on_batch() instead of model.predict(). This returns an object of type <class 'tensorflow.python.framework.ops.EagerTensor'> - not a numpy array as claimed in the docs - but it can be cast by calling np.array(model.predict_on_batch(input_data)) to get the output I want.
I also noticed a similar memory leak problem with calling model.fit() in a loop, albeit with a slower memory accumulation, but this can be fixed in a similar way using model.train_on_batch().

I think same error here.
This code (https://github.com/ipsec/dqn_tf2/blob/master/nchain-train.py) not finishing.

@MProx ,
Can you confirm if the issue is resolved with the workaround? Thanks!

Hi. Yes it did. I tested it overnight with no leak. I'm not sure why the original functions do not work as expected, but the workaround has fixed my problem.

This issue is NOT resolved. I use predict_on_batch and still get an OOM error after some time of processing data.

Interesting. I think that OOM is telling you your GPU memory is being depleted, and that sounds like a different problem because mine was filling up system RAM, not GPU. Using predict_on_batch() and train_on_batch(), I ran ~800k iterations of my model over 10 hours last night, and it seemed to work fine.
Another thing is that I had to set the environment variable TF_FORCE_GPU_ALLOW_GROWTH=true to avoid tensorflow errors on startup. Maybe try that?

Yeah, I don't have any critical errors when running on CPU. It's definitely GPU memory that's leaky. The GPU memory doesn't deplete immediately, but only after some number of calls to predict_on_batch. I am able to train using fit with no problems, which runs over that same data set over many epochs.

I can confirm actually, that when run on CPU, the leak still persists.

Hmm, in that case I'm

In that case I'm going to re-open this issue so that maybe the TF team can help you.

Issue replicating for TF-2.0, kindly find the gist of colab.Thanks!

This is an issue with how certain object lifetimes are being managed in the tf function cache. Behind the scenes Model.predict is creating some functions which aren't being spun down properly, which is why there is a small but consistent leak each iteration. We are currently working on a fix.

@robieta, would the particular problem that you mentioned affect GPU memory, or just system memory? Is there a Github Issue associated with it?

I was also running a predict loop and getting OOM errors after many iterations. Using predict_on_batch instead eliminated this problem. It also sped up the prediction rate by a factor of 4. Thanks for the workaround!
@ialdencoots, could you confirm whether or not you get an OOM error using the specific example code that @MProx provided in the issue description except using predict_on_batch?

@novog Hmm, using the code that MProx provided with predict_on_batch, I do not get the OOM error. In my considerably less minimal code, where I am feeding inputs via a TFRecordDataset and definitely using predict_on_batch, I still encounter the memory leak.

@ialdencoots It sounds like you might be having a different OOM issue than the author of this issue and I were having. Incidentally, in my case, I am also loading my model from an .h5 file, and predict_on_batch fixed it. I would suggest trying to create a simpler version of your code that still has the problem to narrow down the cause and post it as a separate issue.
@MProx, I would recommend leaving this issue open. Although we have a workaround, there is a defect in the TensorFlow version of Keras's predict function that should be fixed.

In case it helps, this issue does not appear to be present in release 2.0.0.alpha0. You can confirm this by running @oanush's Colab with that version. (Not that it's relevant to this issue, but the same is also true of every other issue I've encountered when working with TensorFlow 2.0.)

Please switch to 2.0.0 (final release). You might need to upgrade pip and setuptools to get it, but 2.0 has been available for a while, no need to still be on alpha

I know. But this problem, as well as several others, is not present on alpha.

Oh, you meant that the breakage happens in between alpha and rc2.
If it's not too much to ask, would you be willing to compare rc1?

The issue does appear to be present in rc1.
I went ahead and tried beta0 as well, and it does not seem to be present there.

Thank you. so the failure is in between beta1 and rc0.
Unfortunately, we fast-forwarded the branch in between these two points, so probably we got the failure from master.
One more test, please. Is the issue also manifesting on latest master?

Oh, I see @robieta already pinned the issue. Apologies for the extra tests, we are expecting this to be fixed on master soon (if not already)

No worries about the tests. I just hope a new release with the fix comes out soon.

It's worth noting that the solution that I was referring to will only fix CPU OOM; it wouldn't explain a GPU leak.

I was experiencing the same issue on the 2.0.0 docker (latest-gpu-py3) image; I changed to the nightly image (tensorflow/tensorflow:nightly-gpu-py3 to be exact) and the problem seems to be fixed, no more memory leak!

Avoiding model.predict and using model.predict_on_batch solves the Memory Error for me. Here's an example to create batched predictions on your test set.
(Note that if only pre-allocating the results array already results in a MemoryError then simply the array does not fit in your available memory regardless of the memory leak issue.)
# custom batched prediction loop to avoid memory leak issues for now in the model.predict call
y_pred_probs = np.empty([len(X_test), VOCAB_SIZE], dtype=np.float32)  # pre-allocate required memory for array for efficiency

BATCH_INDICES = np.arange(start=0, stop=len(X_test), step=BATCH_SIZE)  # row indices of batches
BATCH_INDICES = np.append(BATCH_INDICES, len(X_test))  # add final batch_end row

for index in np.arange(len(BATCH_INDICES) - 1):
    batch_start = BATCH_INDICES[index]  # first row of the batch
    batch_end = BATCH_INDICES[index + 1]  # last row of the batch
    y_pred_probs[batch_start:batch_end] = model.predict_on_batch(X_test[batch_start:batch_end])

model.predict_on_batch solved this problem for me too

Same issue with TF 2.0 stable
Solved with tf.compat.v1.disable_eager_execution()

I got the same problem both on rc2 and on official 2.0.0 release.
model.predict_on_batch workaround worked for me

For anyone visiting this thread with similar issues of memory leakage when invoking model.evaluate() in a loop, the work-around for this case is similar to the one proposed by @MProx, use model.test_on_batch() instead.

Building a model by subclassing the Model class can avoid this problem.
``
class MyModel(tf.keras.Model):
def init(self):
super(MyModel, self).init()
self.dense1 = tf.keras.layers.Dense(32, activation=tf.nn.relu)
self.dense2 = tf.keras.layers.Dense(2, activation=tf.nn.softmax)
def call(self, inputs):
    x = self.dense1(inputs)
    return self.dense2(x)

model = MyModel()
model.compile(optimizer='adam', loss='mse')
Create dummy input data
fake_data = np.random.uniform(low=0, high=1.0, size=(1, 10, ))
while True:
# Repeatedly predict:
model.predict(fake_data) # memory leak will happen
model(fake_data) # There is no memory leak
'

@MProx, about a month ago we added a fix for memory leak and there's a possibility it has fixed this. Can you try !pip install tf-nightly and see if it resolves your issue?

Hi. I have done what you ask and tested tf-nightly with my trivial code example from the original issue above, and it does indeed seem to fix the problem. I also tried it in a different application that I've been using the predict_on_batch workaround with, and there seem to be no memory leaks there either. So yes, the leak seems to have been dealt with.
Thank you!

I've had the same problem and none of the above solutions worked for me.
Ultimately, setting inter_op_parallelism_threads=1 in tf.Config fixed it.
tensorflow/tensorflow#22098

Still getting this error with tf-nightly

@rchao @MProx Still getting this error with TensorFlow version 2.2.0-rc3 on Google Colab. See this gist.

Same getting error even after using train_on_batch i am using custom keras layers

The issue persists. Would be better if someone from tensorflow team made a statement about it. It severely hinders the ability to train for higher number of epochs

Hi,
I am trying to call model.predict() on CPU multiple times and I observe RAM memory leak. clear_session with model reload and gc.collect() doesn't solve the issue. I ran the code on tensorflow 2.1 and 2.3 as well but issue still persists. Is there a workaround for this issue? I am using TF 1.14 and Python 3.6. Have been struggling to solve this problem since so long.

Having similar issue in latest TF 2.4.1. Growing from about 60GB (I'm using a large shuffle buffer) to 128GB over the course of a few hours. Not sure if it't the same issue as originally mentioned here, since it seems to be more subtle and any number of causes could be the memory leak. Would file a new issue but it's challenging to create a minimal reproducible example

Is the issue still open? I am having similar issue with tf.predict() function on TF 2.11.0.

Witnessing the same issue while running inference with TF

Yes, I experience the same issue even with .predict_on_batch. In this case, the memory leak is minor, but it persists.

Seeing this issue with tensorflow 2.13.1, running python 3.11.8. I ran tracemalloc to determine which objects were not being garbage collected. This is just a snippet of the top offenders if a more complete list is needed I can include that as well.
tensorflow/python/ops/gen_array_ops.py:10241: size=52.2 MiB, count=854768, average=64
tensorflow/python/ops/gen_math_ops.py:6577: size=36.6 MiB, count=600142, average=64
tensorflow/python/ops/gen_math_ops.py:462: size=33.8 MiB, count=553135, average=64
tensorflow/python/ops/gen_math_ops.py:9854: size=31.4 MiB, count=514545, average=64
tensorflow/python/ops/gen_math_ops.py:9738: size=30.1 MiB, count=492770, average=64
tensorflow/python/ops/gen_math_ops.py:6014: size=22.9 MiB, count=375486, average=64
tensorflow/python/ops/gen_math_ops.py:11793: size=20.9 MiB, count=341905, average=64
tensorflow/python/ops/gen_array_ops.py:10697: size=18.3 MiB, count=300004, average=64
tensorflow/python/ops/gen_math_ops.py:5110: size=15.8 MiB, count=258130, average=64
tensorflow/python/ops/gen_nn_ops.py:850: size=13.3 MiB, count=217968, average=64
tensorflow/python/eager/execute.py:53: size=13.1 MiB, count=214666, average=64```

Also tested tensorflow 2.15.1 and python 3.11.8 this morning with the same results as above

I have included the above gist to reproduce the issue.
 Have documented findings in this thread

I have tried a lot of different TF versions, and most of the available "solutions" on github - and still couldn't stop TF from leaking.
The CPU RAM is always growing, even if I get to lower the rate of growth (by using predict_on_batch, which was the only thing that helped, but did not solve)
This thing makes it impossible to maintain a live TF inference server - at some time, if you do not restart the machine, the CPU RAM will overload and the machine would crash

I gave up on it and ended up exporting the model to .onnx for inference.


partially enabled searching for embedded resources by secondary key for #8

This is only a partial solution as the test data makes it very difficult to test this independently of the other tests. This is enough to satisfy my use case as it does seem to follow the link from the embedded resource rather than return the resource as embedded.
Obviously, I don't expect this to be merged in as-is, but I am hoping that this can either help you make a similar change independently or start a thread where we could work together to get this to a state that would be acceptable for a merge.

Hey, thanks for the PR. I've created the branch embedded-by-secondary-key and merged your PR there. I fixed a few things. One thing is still missing - for now, we could just assume, that if an embedded has not been found we can just throw an error. This is no longer true. I need to fix the order of things in findNextStep.

All things fixed, I think. Please have a look at it :-)

I got the update pulled into my project and it works as expected. Thanks again!


Add correctness tests

Add overall statistics reporting to falco to count the number of rules that triggered and add correctness tests using the test running framework Avocado. A set of positive and negative trace files are available on s3 and are pulled down by travis and run against falco, which simply verifies the positive traces have a detected event and the negative traces do not detect anything.
Based on these tests, do a pass of rule cleanups to improve fn/fp coverage.
This is somewhat blocked on a sysdig bug I ran into (https://github.com/draios/sysdig/issues/598), although I'd be ok merging this and re-enabling the rule once the sysdig bug is fixed.
@henridf

🎉 we have tests!
👍


index-sort-as elements beginning with newline get sorted as "Specials"

Expected Behavior
A newline (or any other whitespace character) in a  should be ignored. There might be exceptions for mid-phrase newlines, but certainly at the beginning of an entry they should be ignored.
Actual Behavior
The newline is sorted as a special character, so the entry ends up in the "Specials" category, rather than the first non-whitespace character.
Possible Solution
I cannot find a template that matches on index-sort-as, so I'm presuming that this processing occurs in one of the Java modules.
In this case, either the module should convert whitespace characters to spaces and then normalize the space.
Alternatively, the index configuration file should include an index.ignore group before the index.groups, that allows a user to specify characters to ignore in indexes.
Steps to Reproduce

Create indexterm element with index-sort-as.
Enter the index-sort-as in the form:

<index-sort-as>
My sort-as value
</index-sort-as>

Generate output from sources

Copy of the error message, log file or stack trace

Environment

DITA-OT version: 3.6.1
Operating system and version: macOS
How did you run DITA-OT? dita command
Transformation type: PDF
FO processor: AntennaHouse

@simonbate if you are using for publishing the DITA OT PDF5 plugin developed by Antenna House maybe they could help you further:
https://www.antennahouse.com/dita-pdf5-plugin

Unfortunately, we're using the OT pdf2 plugin as our base.
Our temporary solution is to ensure the sources do not include newlines, but that shouldn't be necessary.

@simonbate  right you can probably define a Schematron rule to catch such problems.
I added a similar problem but for CHM and indexterm elements a couple of days ago: https://github.com/dita-ot/dita-ot/issues/4336

Testcase here: 4337.zip

I think the fix would be inside src/main/java/org/dita/dost/reader/IndexTermReader.java, by applying the trimSpaceAtStart() somewhere, but I can't tell where it should be. @raducoravu - if you think you see a potential fix for this, I would be happy to test it.

@chrispy-snps I'm afraid I do not have time to look into this, here "org.dita.dost.reader.IndexTermReader.characters(char[], int, int)" there seems to be an initial normalization using normalizeAndCollapseWhitespace which replaces all consecutive spaces with one.
And then there is this code for the index sort as:
  else if (insideSortingAs && temp.length() > 0) {
    final IndexTerm indexTerm = termStack.peek();
    temp = trimSpaceAtStart(temp, indexTerm.getTermKey());
    indexTerm.setTermKey(setOrAppend(indexTerm.getTermKey(), temp, false));
  }

It's unclear to me what the trimSpaceAtStart does, it seems to not always remove the first space, but removes it when the second parameter to the method also starts with a space. But the "indexTerm.getTermKey()" is probably null at that moment. So maybe replace:
temp = trimSpaceAtStart(temp, indexTerm.getTermKey());

with:
temp = trimSpaceAtStart(temp, indexTerm.getTermKey() != null ? indexTerm.getTermKey() : temp);

so that the first time when the term key is not yet computed to always remove the first space?

So I think the IndexTermReader.java code is used only by the htmlhelp transformation. For pdf2 transformations, index term processing appears to be provided by the org.dita.index plugin. It looks like there is a unit test for <index-sort-as> in there that could be modified to test and resolve the whitespace issue, but I haven't been able to build and test that plugin yet.

In org.dita.index, I filed the following issue:
#2: cannot build or test plugin
Once that is figured out, I hope to implement a fix there.


Add composer.guru- a semver range checker- to the readme

Hi. I just made a tool for myself and my workplace to generate satisfiable ranges from a semver constraint. It's open source.
There's a similar tool located at semver.mwl.be/, but it's not quite practical for me since it requires a public facing repository to compare refs against. semver-check is almost the same tool, but produces slightly different ranges than composer. So I made this (pretty simple) tool which just taps in to the functions made available by the composer/semver repository.

It seems like CI also need all links to resolve correctly so I've removed a couple of lines as well.
I'm not sure what the stance on links to gitlab (vs github) is, but if links to gitlab are disallowed feel free to close this.

Thank you for contributing, Matt!


Added logo

Once merged we should change the url to:
https://cdn.rawgit.com/stickermule/rump/master/assets/images/rump_logo.svg

Awesome! Merging.


Hide numeric value for constants in EditorPropertyEnum

This change was not necessary for CustomPropertyEditor, since it already hides the numeric value. However, I changed it as well as EditorPropertyEnum to calculate values correctly when only some constants have an explicit value:
hint_string = "A,B:3,C,D:2,E,F"

enum {
    A,
    B = 3,
    C,
    D = 2,
    E,
    F
}

// Before. The constants without an explicit value had the constant index as the value itself:
enum {
    A = 0, // Index: 0 (applied)
    B = 3, // Index: 1
    C = 2, // Index: 2 (applied)
    D = 2, // Index: 3
    E = 4, // Index: 4 (applied)
    F = 5  // Index: 5 (applied)
}

// After. The constants without an explicit value had the value of the previous constant incremented by one:
enum {
    A = 0, // Begins at 0
    B = 3, // Explicit
    C = 4, // B + 1
    D = 2, // Explicit
    E = 3, // D + 1
    F = 4  // E + 1
}

This is how it works at least in C#, C++ and GDScript.
Closes #22122

The wrong calculation of values may not have caused any problem in the past, or it may have, I don't know. If it hasn't, the reason is that there probably are no hint_strings where only some values have explicit values; they have either default or explicit values for all the constants.

Thanks for looking into this.
It was some time ago, and I didn't look much further into it, but I do think I bumped into what you're talking about.  I just thought it was the design for it and carried on.

Using item metadata instead of ID now for the values, since a negative ID means no ID.

Thanks!

@neikeq Looking good.  X)
Also a bit late getting back to this, but apologies for my first attempt to test earlier.  I updated my scons build targets in my build script on my desktop a night ago, and looking over this again, I just realized I forgot to update my desktop editor shortcuts on the user profile I was logged into at that hour.  Was looking at the wrong build.  -_-


5.0.0+4 Flutter plugin cannot access BiometricStoragePlugin

i have some trouble when i want to used Biometric Storage. Flutter plugin cannot access BiometricStoragePlugin. I don't know how to solve it

@andiilhamsyahidris Looks like you need to update your JAVA SDK to 17

@andiilhamsyahidris Looks like you need to update your JAVA SDK to 17

I am already using Java SDK version 17

my temporary fix is to remove
kotlin {
jvmToolchain(17)
}
from the libary's Gradle file at /Users/"yourUser"/.pub-cache/hosted/pub.dev/biometric_storage-5.0.0+4/android/build.gradle


GO:0140418. effector-mediated modulation of host process by symbiont

missing parent child relationship
GO:0140418 effector-mediated modulation of host process by symbiont
GO:0140415    effector-mediated modulation of host defenses by symbiont
@pgaudet I am sure you did this. I saw  it? Was there some reversion?

You mean I've added the parents ?
I don't know - but I can add them back

Maybe this one was never done. It needs adding anyway.


No contribution guidelines  documentation

openjournals/joss-reviews#6566
I'm not seeing contribution guidelines documentation or information for users on how to report issues or seek support. For contribution guidelines you may wish to look at https://www.contributor-covenant.org/.
Language from JOSS review requirement: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Small typo of old package name in community guidelines. I made a pull request to fix that. Otherwise this looks good to go.

Oops right. Thank you!


No route found for "GET /admin/login": Method Not Allowed (Allow: POST)

After fresh install I got this error while navigating to /admin/login. What is wrong?

We released the Pagekit Beta today. I close this issue because the code base completely changed. Please open a new issue if it still exists.


xstate/fsm: state.changed is undefined when service first starts

Setup code:
const m = createMachine({
  initialState: 'init',
  ...rest of  typical machine definition here ...
})
const s = interpret(m).start()

s.subscribe(state => {
        console.log('state:', state.value, ' changed:', state.changed);
})

setTimeout(function () {  s.send('SOME_EVENT') }, 2000)

I see this in the console:
state: init   changed: undefined
state: init   changed: false

// 2 seconds-ish later:
state: some_new_state   changed: true

I'm thinking this is related to #826 , like we're not setting the changed value as expected when we run the initial state's entry callback

This is expected. The very first state can't be considered changed or unchanged from some previous state (which does not exist)... and undefined represents that it does not exist.

Although... are you seeing two init updates in the console? Can you share a reproducible code example? That might be a different bug.

are you seeing two init updates in the console

It's possible I mangled the example in my attempt to keep the setup code as simple as possible.
I'll construct a working example right now to validate that this extra init update is really happening. I'll post here with whatever I find.

test.js
import { createMachine, interpret } from '@xstate/fsm'

const m = createMachine({
    initial: 'uninitialized',
    states: {
        uninitialized: {
                entry: function () {
                        console.log('I run :) ')
                },
                on: {
                  SOME_EVENT: 'some_new_state'
                }
        },
        some_new_state: {  }
    }
})

const s = interpret(m).start()

s.subscribe(state => {
        console.log('state:', state.value, ' changed:', state.changed)
})

setTimeout(function () {  s.send('SOME_EVENT') }, 2000)

output:
➜ node -r esm test.js
I run :)
state: uninitialized  changed: undefined
state: some_new_state  changed: true
➜

looks right to me! I must have mangled the example. Sorry about that!


feat(fromEvent): complete the stream after the first value on one time events

Description:
A small quality of life change to fromEvent when the once option is supplied, it makes sense to automatically close the stream after the first emission since the observable will only emit once. this will remove the need to manually unsubscribe every time you work with one time events.

BREAKING CHANGE:
Related issue (if exists):

oops i forgot about the case where you can pass an array of targets, i am setting this to draft for the moment


initial version for reading from solomon

Changelog entry
...
Changelog category

Not for changelog (changelog entry is not required)

Additional information
...

тест ydb/library/yql/sql/v1/ut/SqlToYQLErrors.SelectingFromMonitoringIsNotAllowed починю в след ревью


Random Permission Failures @ Build.

cp<EMAIL_ADDRESS>Permission denied

Also: https://github.com/Homebrew/homebrew-core/issues/5074
Seems to have started since we returned /usr/local to the default permissions. Doesn't consistently reproduce, which is frankly puzzling.

I can get my particular one to reproduce by doing:
brew install<EMAIL_ADDRESS>brew upgrade<EMAIL_ADDRESS>-s -v

Which is just great, because it's blocking me from properly investigating https://github.com/Homebrew/homebrew-core/issues/5126. Throws MacBook into the ocean.

Yeah, I can reproduce, but I don't plan to throw a 2.5 grand MacBook into the ocean, plus there's no ocean around me. 😌

This is just a Makefile bug

But the underlying cause is that the same prefix is being reused due to Homebrew/homebrew-core#5126, so the file is already there. The Makefile doesn't handle that situation correctly, but it ordinarily never would have to because we start out with an empty prefix. In this case it's starting out with a fully occupied prefix, and the problematic files have mode 444.


TypeError: NetworkError when attempting to fetch resource

Describe the issue
Unable to sync with Notion database after the initial setup following directions on Notero's GitHub page.  It looks very similar to #478
Zotero 7.0.5
Notero plugin 0.6.3
Screenshots
Shows the following Error:

Settings:

Console:

Any help would be appreciated!

Hi @SJPhilippov, thanks for reporting this!
This does look very similar to #478 and #51 before that. Unfortunately, I've never discovered any solution for this other than having folks investigate their network setup.
Are you using Zotero while on a work/school network, or is this happening on your home network? Are you using a VPN at all, and if so are you able to try disabling that?

Hi @dvanoni, thanks for the prompt reply!
I've finally figured out the issue. I bet you'll be entertained by what was causing it as much as I am:
My MacBook time was off by like 10 minutes, even though it was set to sync automatically with Apple services.
Looks like I'm not alone in this: https://www.reddit.com/r/apple/comments/84cril/my_mac_shows_the_wrong_time_even_though_its_set/
When I reset it to the actual time, everything started working!

Consider me entertained! 😄
It's really interesting how many things fall apart when clocks are out of sync. I'm glad you figured it out!


VSCode accessibility overview

I have gone through all our accessibility issues, and here are my findings:

All accessibility issues are now tagged with label accessibility for a total of 55 issues
To not get downgraded to score D for Microsoft accessibility the issues tagged with a11ymas have to be fixed.
Interestengly all of the a11ymas have no user interaction on them. None of them have a thumbs up or a comment from a user (unlike our other accessiblity issues which have lively discussions). This and my own analysis of these issues leads me to believe that they are not as important as our user created issues.
There are around 10 low hanging fruit issues, for those I have pinged the owners to provide code pointers so the author, the community or me provide PRs to fix
There are 2 issues which are a big pain for accessibility users tagged with important. They are both upstream, but we should put our focus on getting those fixed (by communicating with Chrome and NVDA).
We have a total of 12 upstream most of them relying on Chrome
Since we upgraded to Electron 4.0 I could close off around 5 issues which got fixed because Electron picked up a newer Chrome version. So this is another benefit of keeping up with Electron updates.
Writing new widgets with accessibility in mind helps a lot. A good example is the new tree for which there were not that many accessibility issues - even though we use it across the workbench

@egamma @chrisdias  Could you please give me the contact of Edge / Chromium contributors that could help us with solving chrome accessibility issues. One example: https://bugs.chromium.org/p/chromium/issues/detail?id=951777
fyi @auchenberg @deepak1556 @kieferrm
fyi @neurrone @pawelurbanski @adincebic for more potential feedback, or if I missed something in my overview
Let me know what you think. Thanks

@isidorn thanks for organizing this information. Looking at the a11ymas issues, most of them don't seem to be that critical, compared to many of the issues opened by end users, so I also feel that prioritizing the latter would be more impactful.

Just a quick update… Unfortunately, I cannot get through the initial Yarn package compilation. There is an issue with the postinstall.js script reported by someone on Github.
It stops me from compilation, and working on the fixes locally.
From: Dickson Tan<EMAIL_ADDRESS>Sent: czwartek, 20 czerwca 2019 15:53
To: microsoft/vscode<EMAIL_ADDRESS>Cc: Pawel Urbanski<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/vscode] VSCode accessibility overview (#75840)
@isidornhttps://github.com/isidorn thanks for organizing this information. Looking at the a11ymas issues, most of them don't seem to be that critical, compared to many of the issues opened by end users, so I also feel that prioritizing the latter would be more impactful.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/75840?email_source=notifications&email_token=AAWAEQD6TBKHPINBDENFKULP3ODU3A5CNFSM4HZTDDA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYFPEIQ#issuecomment-504033826, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAWAEQCKREDW7NMTQ5XUWKDP3ODU3ANCNFSM4HZTDDAQ.

This milestone we have tackled actionable accessibility issues as seen in this query
We have also setup a meeting with the Edge team so we start discussing Chrome accessibility issues.
We can keep this overview around, but we have done what we planned for this milestone, thus removing the milestone from it.

The last big-ish issue for me on a daily basis is that NVDA disagrees with Code about what a word is, so moving by word never provides accurate feedback, tracked in #28306. Not sure if the work being done to add UIA support in Chromium would help, in this case.

Planned items from this issue have been tackled. We are continuing our work on accessibility, however that is captured in other issues. Thus closing this.


Add '$schema' property into root object.

According to JSON Schema spec:

When extending JSON Schema with custom keywords, schema authors SHOULD define a custom URI for $schema.

$schema value could be http://swagger.io/v2/schema.json#
It simple feature which enhance JSON Schema compatibility.
For e.g. it will allow automatic validation of Swagger file by JSON Schema validator.
Also it will motivate creation of schemes for Swagger extension.
On the negative side, it partly duplicate info from swagger field.
Which isn't a big problem, because it occur once per Swagger file.

Duplicate of #496


Add unique strings behind function name for the Zoom connector arm templates

Required items, please complete
Change(s):

Updated azuredeploy.json
Updated azuredeploy_kv.json

Reason for Change(s):

Added uniqueString to parameter FunctionName to generate a unique and consistent name across all resources required for the Zoom connector. Without this change, the initial deployment will fail because the default value ZoomLogs used for the storage account name is not globally unique.

Version Updated:

No

Testing Completed:

Yes

Successfully deployed the Azure Function and Azure Key Vault via the updates templates
Checked that the validations are passing and have addressed any issues that are present:

Yes

No change to anything beyond the arm template

@microsoft-github-policy-service agree

Hi @aka0, can you please provide us a successful running connector screenshot. Thanks

Hi @aka0, can you please provide us a successful running connector screenshot. Thanks

Hi @aka0, thanks for this screenshot but we required functional screenshot. Please refer below screenshot for example.


CosmJS Multisig does not work with Keplr

I am working on some implementation of multisig using the cosmjs, made all the code similar to the example but it is throwing error:
Uncaught (in promise) Error: Broadcasting transaction failed with code 4 (codespace: sdk). Log: signature verification failed; please verify account number (10), sequence (0) and chain-id (deweb-testnet-0): unauthorized
    at StargateClient.broadcastTx

Code implementation:
const chainId = "deweb-testnet-0";
const offlineSigner = window.getOfflineSignerOnlyAmino(chainId);
offlineSigner.getAccounts().then((accounts) => {
    const pubkeys = [{
        type: "tendermint/PubKeySecp256k1",
        value: base64js.fromByteArray(accounts[0].pubkey)
    }, {
        type: "tendermint/PubKeySecp256k1",
        value: "Aop7hUkdmWrwt2jXmtTQwAsxWQ5E/lkj1Q8w52TF1Uyr"
    }]
    const threshold = 1;
    const multisigPubkey = createMultisigThresholdPubkey(pubkeys, threshold);
    const multisigAddress = pubkeyToAddress(multisigPubkey, "deweb");

    const rpcEndpoint = "https://rpc-deweb.deweb.services";
    SigningStargateClient.connectWithSigner(rpcEndpoint, offlineSigner).then((client) => {
        client.getAccount(multisigAddress).then((accountOnChain) => {
            accountOnChain.pubkey = multisigPubkey;
            const msgSend = {
                fromAddress: multisigAddress,
                toAddress: "deweb1v9xfzuxhygcnnjfw8k8pa7hhn04s5esvcemvku",
                amount: coins(1000000, "udws"),
            };
            const msg = {
                typeUrl: "/cosmos.bank.v1beta1.MsgSend",
                value: msgSend,
            };
            const gasLimit = 200000;
            const fee = {
                amount: coins(2000, "udws"),
                gas: gasLimit.toString(),
            };
            const signingInstruction = {
                accountNumber: accountOnChain.accountNumber,
                sequence: accountOnChain.sequence,
                chainId: chainId,
                msgs: [msg],
                fee: fee,
                memo: "Test",
            }
            const signerData = {
                accountNumber: signingInstruction.accountNumber,
                sequence: signingInstruction.sequence,
                chainId: signingInstruction.chainId,
            };
            client.sign(
                accounts[0].address,
                signingInstruction.msgs,
                signingInstruction.fee,
                signingInstruction.memo,
                signerData,
            ).then((signed) => {
                const signatures = new Map();
                signatures.set(accounts[0].address, signed.signatures[0]);
                const signedTx = makeMultisignedTx(
                    multisigPubkey,
                    signingInstruction.sequence,
                    signingInstruction.fee,
                    signed.bodyBytes,
                    signatures
                );
                console.log("signedTx", signedTx);
                StargateClient.connect(rpcEndpoint).then((broadcaster) => {
                    console.log("broadcaster", broadcaster);
                    broadcaster.broadcastTx(Uint8Array.from(TxRaw.encode(signedTx).finish())).then((result) => {
                        console.log("result", result)
                    });
                });
            })
        });
    })
})

I tried same with TypeScript, did not get any different results from this.

Did you see https://github.com/cosmos/cosmos-multisig-ui? Maybe you can compare what you do with this code and spot some differences.
The error you get there is a signature verification failure. This can be anything and is very hard to debug.

Did you manage to fix the issue, I have the exact same error, with the code being similar to yours.

Thanks, that helped to debug. so the issue was I need to have set mandatory using fee from code, keplr overwrote it and this issue was happening.
So solution was to add:
window.keplr.defaultOptions = {
            sign: {
              preferNoSetMemo: true,
              preferNoSetFee: true,
              disableBalanceCheck: true,
            },
};

Thank you for sharing @berelton


add format documentation links

Problem: I wanted to know what color schema is available
Solution: Add links to directly reach the predefined schemes and templates

Thanks for adding these links.

Sure! I plan to add more shields and a good documentation lowers the burden for new-comers.

Great, and agreed! I noticed you opened #889 and look forward to reviewing that as well.


Reusing your assets for an elementary OS clone?

Hi Michael,
I switched recently to elementary OS and I really miss your awesome timer app. Have to admit I fell in love with it on macOS. That's why I just started cloning it: https://github.com/marbetschar/timer
Unfortunately I'm more of a programmer than a designer. And as I really like your design, I wanted to ask you if you're cool if I reuse your assets for a dedicated elementary OS clone, programmed in Vala?
To be fully transparent here, I also plan to release this Timer clone to the elementary OS AppCenter, a Pay-What-You-Want App Store. I'll probably publish it there with a suggested one-time price of 1 or 2 USD.

As promised a quick update on the elementary clone: The first version is done and waits to be released to the elementary AppCenter. This is how it looks like:

Thanks again for all your help and providing the design!!

That looks great!

Updated Sketch file with dark mode.
timer-app.sketch.zip


Problem parsing message object

When I got the facebook link attached to the image it stopped the program
{ error: 'Problem parsing message object. Please open an issue at https://github.com/Schmavery/facebook-chat-api/issues.',
  detail: TypeError: Cannot read property 'text' of null
    at _formatAttachment (E:\bot\node_modules\facebook-chat-api\utils.js:453:46)
    at attachments.map.v (E:\bot\node_modules\facebook-chat-api\utils.js:502:55)
    at Array.map (<anonymous>)

@inoriyuzuriha2018 does everything work well now?

@inoriyuzuriha2018 we published a new version to npm that should handle attachments better so feel free to give it a try and reopen if it doesn't work.


Tooltip with more accurate duration information

Hi,
first of all thank you for the discrete panel, we are using it to monitor the state of a machine.
Is it possible to show a more accurate duration in the tooltip of the panel?
Your screenshot shows the problem:

The duration is mentioned as "a day", but the 30 minutes are ignored.
Or see this example:

Instead of "4 hours", "3 hours 30 minutes" would be better.
Do you think it is possible to add more accuracy to the duration information in the tooltip?
Maybe it is possible to configure the duration time units, e.g. "hour;minute;second" and all duration will be shown in this units, even if it is a higher unit (day) available. So for your screenshot example of "a day" it would be "24 hours 30 minutes".
BR

sounds good -- open to contributions

I have the same problem :-) I use discrete-panel to show running times for a heating system and the user should calculate the gas usage by reading the time of a certain state.
The duration is given by momentjs::humanize. There is an upstream feature request open as well - https://github.com/moment/moment/issues/348.
One of the last comments posts a snippet that looks useful here. But I also feel a bit lazy to put this into place now...

The fix for this is done, and looks like it will go out with v0.0.9.
When does that release go live?


feat(KONFLUX-5297): Expose metrics for Tekton Resolver leases distribution alerts

/retest

@jhutar there was a problematic change at some point causing the e2e to fail, can you rebase this PR, failure might be caused by that problem which is fixed on latest main

Cool, it helped, thank you @hugares !


Fixing ScrollBar regression for Issue #4255

Fixes #4255
We recently added a 1px margin around the ScrollBar, in its default control template. That potentially caused a layout cycle on DPI levels other than 100%. The chosen solution is to remove that ScrollBar 1px margin and add instead a 1px padding where it's used the most: the ScrollViewer control.
So the ScrollViewer's control template is declared in WinUI 2.6 now and includes 2 new Grid elements around the ScrollBar controls, with a 1px Padding around them.
Only ScrollViewer_themeresources.xaml has the additional Grid elements (just like only ScrollBar_themeresources.xaml had the 1px margin).
The same trick is used in the new WinUI ScrollView control. Its default control template now includes 2 additional Grid elements surrounding its ScrollBar controls.
While in there, I also fixed a couple of things:

Updated ScrollViewScrollBarsSeparatorBackground as it is meant to be transparent now like the ScrollViewer's scrollbars separator.
Fixed ScrollViewerScrollBarSeparatorBackground for HighContrast as it is supposed to use SystemControlTransparentBrush and not ControlFillColorTransparentBrush.

/azp run

/azp run

/azp run

@RBrid
This looks like a work-around not a fix. As someone who has spent a lot of time also trying to work-around the 'Layout Cycle Detected' bugs that crop up in apps I'm more interested in what the actual root cause of this is. Is there any plan to address what I assume are rounding errors in the layout math with WinUI 3? It shouldn't be possible to trigger a layout cycle exception by just adding a margin. Something deep is broken and it's going to keep popping up.

@robloo, I agree with you completely. This is a workaround rather than a fix - my title/comments should have been clearer about this, like my branch name user/regisb/ScrollBarWorkaround5.
We opted for a WinUI 2.6 workaround rather than shipping a QFE in every Windows OS version supported by WinUI 2.6. At this point we do not know the exact root cause and its location. It is likely in our layout engine, or maybe the ScrollBar code itself. It is a rounding error for sure, and again I agree that adding any Margin should not cause a layout cycle. We do have an open internal bug to track this issue for WinUI3+. Thanks.

@RBrid Thanks for the details. It makes sense to skip the full fix for WinUI 2.x and instead focus resources on WinUI 3. I just wanted to be sure it wasn't going untracked. Glad to hear there is an internal bug.


Verification tool

Coverage remained the same at 56.29% when pulling 85bace52a2499e00ff7bc82b1f2faebf13a902d4 on Verification-Tool into 99ebe398603a1a102d13c9cf9b2fa20ff36dffc3 on master.


Form submission will be prevented if any errors are encountered - not working

Have the {{#validatable-form action="save"}}  {{/validatable-form}} around my form but not working for me.
I have separate components that are pulled into the form and even tried putting on the actual component. but still form is save and not prevented if not filled in.
Any suggestions.  Still trying to learn the workings of ember-cli  using version 0.2.5

This addon has been rewritten, do not hesitate to evaluate it again, and if you encounter any issue, I'd be happy to assist :).


Typo "Azure database for MySQL"→"Azure Database for MySQL"

https://docs.microsoft.com/en-us/azure/mysql/app-development-best-practices
https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/mysql/app-development-best-practices.md
#PingMSFTDocs

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Misapprehension.
Closed #86478 .


Fixes for ghc-debug

Remove lens and text-show dependencies for the same reasons as https://github.com/Peaker/dwarf/pull/2
Fix some overly restrictive field types, for example, lowPC might not always be present in a compilation unit.
Propagate the .debug_line information into the result.

With these two PRs I can use the library to read dwarf information for a Haskell executable and map pointers to lines in source files.

I changed DW_AT_const_value to accept either UINT or INT now.
https://github.com/Peaker/dwarfadt/pull/6/commits/25fa35d5dde5af6de1cf3b0011cb8e2623cfd173

Thanks


Error in:  Invoke-WPFMicrowin

Calling the Wintool from powershell to generate Microwin failed, this is the outcome:
====Chris Titus Tech=====
=====Windows Toolbox=====
Checking if Chocolatey is Installed...
--       Chocolatey is installed        ---
===========================================                                                         Version: v2.2.2                                                                                Invoking WPFGetIso                                                                                _                     __    __  _                                                            //\  ()  ___  _ __   ___  / / /\ \ () _ __                                                     /    \ | | / || '| / _ \ \ /  / /| || '_ \                                                   / //\ | || (__ | |   | () | \  /\  / | || | | |
/    /|| _||_|    _/   /  /  |||| |_|
oscdimg.exe on system: True
File path C:\Win_CTT\Windows11_23H2_22631-2715.ISO
You have enough space for this operation.
Mounting Iso. Please wait.
Done mounting Iso MSFT_DiskImage (ImagePath = "C:\Win_CTT\Windows11_23H2_22631-2715.IS..., StorageType = 1)                                                                                Iso mounted to 'K'                                                                                Setting up mount dir and scratch dirs                                                               Mounting Iso. Please wait.                                                                          Done setting up mount dir and scratch dirs
Scratch dir is R:\Scratch\Scrach
Image dir is R:\Scratch\micro
Copying Windows image. This will take awhile, please don't use UI or cancel this step!
Copy 1030(s) from K: to R:\Scratch\micro
Copy complete! Total Time: 0m33s
Getting image information R:\Scratch\micro\sources\install.wim
Finding suitable Pro edition. This can take some time. Do note that this is an automatic process that might not select the edition you want.
Selected value '1 : Windows 11 Pro'.....
Done reading and unpacking ISO

Check the UI for further steps!!!
Target ISO location: R:\Win11_CTT_1.iso
Index chosen: '1' from 1 : Windows 11 Pro                                                           Mounting Windows image. This may take a while.                                                      Mounting complete! Performing removal of applications...                                            Remove Features from the image                                                                      Removing features complete!                                                                         Removing Appx Bloat
Invoke-WPFMicrowin : An unexpected error occurred: The request is not supported.
At line:2718 char:24

    "WPFMicrowin" {Invoke-WPFMicrowin}                                                        +                        ~~~~~~~~~~~~~~~~~~                                                             + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException                      + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Invoke-WPFMicrowin                                                                                Unmounting Registry...                                                                              ERROR: The parameter is incorrect.                                                                  ERROR: The parameter is incorrect.                                                                  ERROR: The parameter is incorrect.

ERROR: The parameter is incorrect.
ERROR: The parameter is incorrect.
Cleaning up image...
Cleanup complete.
Unmounting image...
Dismount-WindowsImage : The system cannot find the path specified.
At line:3887 char:9

    Dismount-WindowsImage -Path $scratchDir -Save

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [Dismount-WindowsImage], COMException                   + FullyQualifiedErrorId : Microsoft.Dism.Commands.DismountWindowsImageCommand                                                                                Exporting image into R:\Scratch\micro\sources\install2.wim                                          Remove old 'R:\Scratch\micro\sources\install.wim' and rename R:\Scratch\micro\sources\install2.wim  Windows image completed. Continuing with boot.wim.
Mounting boot image R:\Scratch\micro\sources\boot.wim into R:\Scratch\Scrach
Invoke-WPFMicrowin : An unexpected error occurred: The user attempted to mount to a directory that
is not empty.  This is not supported.
At line:2718 char:24

    "WPFMicrowin" {Invoke-WPFMicrowin}

                   ~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Invoke-WPFMicrowin

Unmounting Registry...
ERROR: The parameter is incorrect.
ERROR: The parameter is incorrect.
ERROR: The parameter is incorrect.
ERROR: The parameter is incorrect.
ERROR: The parameter is incorrect.
Unmounting image...
Dismount-WindowsImage : The specified mounted image cannot be committed back into the WIM.  This
occurs when an image has been through a partial unmount or when an image is still being mounted.
If this image was unmounted with commit earlier, then the commit probably succeeded.  Please
validate that this is the case and then unmount without commit.
At line:3953 char:9

    Dismount-WindowsImage -Path $scratchDir -Save

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [Dismount-WindowsImage], COMException
FullyQualifiedErrorId : Microsoft.Dism.Commands.DismountWindowsImageCommand

Creating ISO image
[INFO] Using oscdimg.exe from: C:\Users\Admin\AppData\Local\Temp\oscdimg.exe
Exception calling "Start" with "0" argument(s): "The specified executable is not a valid
application for this OS platform."
At line:3976 char:9

    $oscdimgProc.Start()

    ~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
FullyQualifiedErrorId : Win32Exception

Exception calling "WaitForExit" with "0" argument(s): "No process is associated with this object."
At line:3977 char:9

    $oscdimgProc.WaitForExit()

    ~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
FullyQualifiedErrorId : InvalidOperationException

(____
_   \ \ ___  ____   ____
| |   | / _ |  _ \ / _  )
| |/ / |_| | | | ( (/ /
|/ _/|| ||___)
ISO creation failed. The  R:\Scratch\micro  directory has not been removed.

the same thing happens to me

Same problem here.


Add documentation for -parameters javac option

Motivation:
Users who want to contribute or use Armeria have trouble configuring their project with -parameters.
Modification:

Add documentation of -parameters javac options into
CONTRIBUTING.md, examples/README.md, and setup.rst.

Result:
Reduce -parameters error when starting Armeria project.

Screenshot for setup.rst


Chai-lab Web Server predicts Intermolecular Forces?

I noticed that the Chai-lab web server can directly display intermolecular forces between complexes. Are these forces predicted by Chai-lab based on amino acids capable of forming salt bridges, hydrogen bonds, and the distances between them? Is it possible to visualize these interactions in PyMOL?

These are provided by the visualization engine, not directly predicted by Chai-1. In other words, if Chai-1 predicts certain atoms to be within certain distances, an IMF will be shown.


Fixes exception message to use compatible version of sentencepiece lib

nbdev_test_nbs --fname nbs/30_text.core.ipynb
Returns:OSError: Not found: unknown field name "minloglevel" in TrainerSpec.
Because it looks like minloglevel flag was dropped from version 0.1.90 and 0.1.91 of sentencepiece library.
But it will be back in 0.1.92:
https://github.com/google/sentencepiece/commit/5bf131908d33b3fdf626f4f3972fe83fc4da1605#diff-20a88935144fc7c1f34aa848fec8cc60R145-R155

Seriously?
Thanks for fixing the install instructions!


Recover and restart Language Server from client side on crash

Description:
We need to implement a mechanism from the client/ plugin side to recover the language server and restart when it crashed
Affected Versions:
0.991.0 at least

This was suggested to recover from grammar inconsistencies experienced earlier and currently, those issues have been addressed. Also, in case of such issue raised users can use the Reload Window command to recover from that. Hence closing the issue.


mutiny vertx binding

Now it is possible to inject:

raw Vertx instance
rxjava2 variant of Vertx
rxjava3 variant of Vertx

Since WildFly has mutiny as well, it maybe good idea to think about inject

mutiny varient of Vertx

with that, it would be possible to use hibernate reactive in users application.

In 1.x branch, it is already possible to expose raw Vertx instance and mutiny Vertx instance via CDI.
There are no planning on other variants of Vertx instance unless there are new demand, so I am closing this.


Get-SQLAgentJobOutputFile

Is this a feature OR bug:
Enhancement
https://trello.com/c/RJG7zLip
Additional comments
https://github.com/SQLDBAWithABeard/Functions/blob/master/Get-SQLAgentJobOutPutFile.ps1

we have it. Get-DbaAgentJobOutputFile


New-ExternalHelp Cmdlet does not rename About topics file correctly- updatable help fails will fail

Context:
The PowerShell help engine about files need to be named .help.txt. in order to be read by the console.
Steps to reproduce
Create a new about topic MD using New-MarkdownAboutHelp
Use New-ExternalHelp cmdlet to convert new about topic MD to text file
Use New ExternalHelpCab cmdlet to create help file for module and supporting about topics
Test the cab files created locally using the -SourcePath param
Help about topic files for the module are not available when running get-help or update help.
Expected behavior
The New-ExternalHelp cmdlet converts the about topic MD to a text file named correctly for the help engine e.g.  "about_testingaboutfiles.help.txt"
Actual behavior
The New ExternalHelp cmdlet converts the about topic MD to a text file named "about_testingaboutfile.txt"
Environment data

v0.6.1

Fixed in 0.7.3


docs: Add another WordPress installation

Add an example of how to set up daisyUI for WordPress using the Yabe Siul plugin

Thank you for the PR.
I apologize but this page can only include links to free tools/libraries.


Unable to Buffer on FeatureCollection of MultiPolygons

When trying to buffer on a FeatureCollection of MultiPolygons(this file), the current Buffer code (turf-buffer v1.0.1 used by turf v2.0.2) prepares the data by running it through combine.  If the FeatureCollection's first feature's geometry type (fc.features[0].geometry.type) is "MultiPolygon", no geometry property is appended to the FeatureCollection during the combine operation. When the bufferOp later passes a stringified version of feature.geometry (which is undefined) to an instance of  jsts.io.GeoJSONReader, the error Uncaught TypeError: Cannot read property 'type' of undefined is thrown. Based on my reading of the GeoJSON Feature Collection Objects spec, it is not invalid for a FeatureCollection object to not have a geometry property on the root of the object.
This bug appears to have been fixed with this committed change, so this issue can likely be tagged wont fix.  I'm more interested in created this issue so that:

It can be logged as a known issue for users of turf v2.0.2 and any other turf versions relying on turf-buffer v.1.0.1.
Propose that a subset of that test file make it's way into a test fixture (likely within turf-combine)
Enquire as to when turf-buffer >v1.0.1 (the repo appears to be at v1.0.4 at this moment) will be rolled into a main version of turf.

@alukach I added your data as a test fixture https://github.com/Turfjs/turf-buffer/commit/2ce85b201d6e2f1f512123818763e387cc8b7118
I will get a new turf version rolled out next week and close this issue then. Thanks!

Any progress>?

Ran into this issue, any further progress getting the fix incorporated into turf?


add deny missing_docs lint

to enforce documentation going forward

I've found that this makes development painful, and you end up adding dummy docs just so it compiles. I would recommend #![warn(missing_docs)] instead.

closing in favor of one issue #68


What are some good resources to start with Test Driven Development and Unit Testing?

I learnt from a lot many resources. However, the best would be funfunfunctuon YouTube channel.
3 videos of Unit Testing
And 1 more video of Dependency Injection
We're eye openers. Let me know if you find them useful too.


'MatiButtonResultDelegate' is not a member type of 'MatiSDK'

Please help me.

@applesubir Hello, could you share yours code screenshot?

@applesubir error still actual?

yes, still facing that error.

Here is another screenshot, I got 354 errors!

@GustavoAlvarez @johnsonejezie @applesubir try to re-install pods, with pod clean command, and then pod install

@aposnovmati Already did that 3 times and still the same errors

@GustavoAlvarez what iOS version do you using?

I found what's wrong, you are using swift 5.4, and I'm using 5.3.2. I think you should mention every time you change Swift/Xcode and IOS version.

Hello @GustavoAlvarez we didnt change swift version, did you use native sdk or crossplatfrom plugin?

Native SDK

Hello,

Please tell me what should I do

SDK version - 3.2.2

Hello @applesubir please use Xcode 12.5, why investigating why it doesn’t work for Xcode 12.4

will it solve if I use Xcode 12.5 ?

@applesubir yes 100%

Let's try

Have you tried compiling your SDK with Xcode 12.4?

Update not available for me.

Have you tried compiling your SDK with Xcode 12.4?

yes, have any solution with Xcode 12.4 ?

@applesubir sorry, why cant use new Xcode 12.5? For Xcode 12.4 we still investigating solution, hope will be provided early next week

I have macOS Catalina.

@aposnovmati we were using iOS SDK v3.1.4...from yesterday app it not working ....after contacting support team ..get to know that version is outdated ...Now we can't use latest sdk due Xcode issue .......
What is the solution now ?
Can you pls help ?

@applesubir ok, understood. As I wrote above, we still investigating a solution, hope will be provided early next week
@mousumi-appnistic You can't update Xcode either?
We will try to find a solution today, but the deadline is early next week

@aposnovmati Xcode update is available yet in my OS  (macOS Catalina ).

@applesubir @mousumi-appnistic @GustavoAlvarez @johnsonejezie  Hello all, please try the new 3.3.1 version, i will wait for feedback

Thanks, @aposnovmati

It works now, thanks!

@applesubir @GustavoAlvarez thanks a lot for patience, if you will have any questions/issues please open new ticket


Statuspage with ToDo-List and Error-Messages/Missing Data

We discussed to have another tab that acts as a starting page, including a ToDo list and notes, and/or a missing data notifier

Added Dashboard with Notes
Can also be used for todos
Notifications for missing data / errors still missing, do we really need that?


Add .swiftlint.yml

resolves #382

Thank you very much :)

PS. I believe you will need to add the config file to the Dangerfile https://github.com/danger/swift/blob/master/Dangerfile.swift#L23

Fails

:no_entry_sign:

Sources/RunnerLib/NSRegularExpression+FilesImport.swift#L6 - Force tries should be avoided. (force_try)

Warnings

:warning:

Sources/Danger/DangerUtils.swift#L112 - Line should be 120 characters or less: currently 141 characters (line_length)

:warning:

Sources/DangerDependenciesResolver/Package.swift#L40 - Don't add a space between the method name and the parentheses. (no_space_in_method_call)

:warning:

Sources/DangerDependenciesResolver/Package.swift#L40 - Don't add a space between the method name and the parentheses. (no_space_in_method_call)

:warning:

Sources/DangerDependenciesResolver/Package.swift#L40 - Don't add a space between the method name and the parentheses. (no_space_in_method_call)

:warning:

Sources/DangerDependenciesResolver/Package.swift#L40 - Don't add a space between the method name and the parentheses. (no_space_in_method_call)

:warning:

Sources/DangerDependenciesResolver/Package.swift#L40 - Don't add a space between the method name and the parentheses. (no_space_in_method_call)

:warning:

Sources/RunnerLib/CliArgs/CliArgs.swift#L4 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)

:warning:

Sources/RunnerLib/CliArgs/CliArgs.swift#L22 - Enum element name should be between 3 and 40 characters long: 'id' (identifier_name)

:warning:

Sources/RunnerLib/DangerCommand.swift#L2 - Enum element name should be between 3 and 40 characters long: 'ci' (identifier_name)

:warning:

Sources/RunnerLib/DangerCommand.swift#L4 - Enum element name should be between 3 and 40 characters long: 'pr' (identifier_name)

:warning:

Sources/RunnerLib/NSRegularExpression+FilesImport.swift#L6 - Line should be 120 characters or less: currently 124 characters (line_length)

:warning:

Sources/RunnerLib/Runtime.swift#L38 - TODOs should be resolved (Support running from a fork?). (todo)

:warning:

Sources/RunnerLib/SPMDanger.swift#L53 - Don't add a space between the method name and the parentheses. (no_space_in_method_call)

  Generated by :no_entry_sign: Danger Swift against 652ee85e4214a7f0bce6d812b79a14bf6517ab90

Fails

:no_entry_sign:

Sources/RunnerLib/NSRegularExpression+FilesImport.swift#L6 - Force tries should be avoided. (force_try)

Warnings

:warning:

Sources/Danger/DangerUtils.swift#L112 - Line should be 120 characters or less: currently 141 characters (line_length)

:warning:

Sources/DangerDependenciesResolver/Package.swift#L40 - Don't add a space between the method name and the parentheses. (no_space_in_method_call)

:warning:

Sources/DangerDependenciesResolver/Package.swift#L40 - Don't add a space between the method name and the parentheses. (no_space_in_method_call)

:warning:

Sources/DangerDependenciesResolver/Package.swift#L40 - Don't add a space between the method name and the parentheses. (no_space_in_method_call)

:warning:

Sources/DangerDependenciesResolver/Package.swift#L40 - Don't add a space between the method name and the parentheses. (no_space_in_method_call)

:warning:

Sources/DangerDependenciesResolver/Package.swift#L40 - Don't add a space between the method name and the parentheses. (no_space_in_method_call)

:warning:

Sources/RunnerLib/CliArgs/CliArgs.swift#L4 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)

:warning:

Sources/RunnerLib/CliArgs/CliArgs.swift#L22 - Enum element name should be between 3 and 40 characters long: 'id' (identifier_name)

:warning:

Sources/RunnerLib/DangerCommand.swift#L2 - Enum element name should be between 3 and 40 characters long: 'ci' (identifier_name)

:warning:

Sources/RunnerLib/DangerCommand.swift#L4 - Enum element name should be between 3 and 40 characters long: 'pr' (identifier_name)

:warning:

Sources/RunnerLib/NSRegularExpression+FilesImport.swift#L6 - Line should be 120 characters or less: currently 124 characters (line_length)

:warning:

Sources/RunnerLib/Runtime.swift#L38 - TODOs should be resolved (Support running from a fork?). (todo)

:warning:

Sources/RunnerLib/SPMDanger.swift#L53 - Don't add a space between the method name and the parentheses. (no_space_in_method_call)

  Generated by :no_entry_sign: Danger Swift against 652ee85e4214a7f0bce6d812b79a14bf6517ab90

As you said (https://github.com/danger/swift/issues/382#issuecomment-706437188), SwiftLint should be executed in whole project.

Some of them are in the JSON, and I'm in favour of ignore them, while I would like to keep the Test files still at a quality that is in line with the rest of the code if possible.

But in current, SwiftLint verifies only on Sources.
I'm trying to fix by unsetting --path property on swiftlint, and it should not need to set config file (.swiftlint.yml file on project root will be read).

@417-72KI what about using
let files = (danger.git.modifiedFiles + danger.git.createdFiles).filter { ($0.starts(with: "Tests") ||  $0.starts(with: "Sources")) &&
$0.fileType == .swift }

SwiftLint.lint(.files(files), inline: true)

?

@f-meloni
Here is my solution (https://github.com/danger/swift/pull/383/files#diff-01136c42fecd3d9a2f9d247c6391859f063fcf4bdb445092e14ccbc8ed02bfcfR23)
or, do you mean to make it runs twice (for Sources and for Tests) ?

@417-72KI The code I wrote is basically filtering the modified files to only include files in test and sources, but I'm totally fine with your solution. Thank you!


isort does not recognize six.moves and email modules properly.

Given something as:
import email  # standard library
import os  # standard library
from os import path  # standard library

from six.moves import zip  # third party

import my_project  # project
from my_project import basic  # project

isort wrongly sorts to:
import os  # standard library
from os import path  # standard library

import my_project # project
import email  # standard library
from my_project import basic  # project
from six.moves import zip  # third party

This seems to be resolved in https://github.com/ESSS/esss_fix_format/pull/17, which already got merged to master.
@timothycrosley Could this issue be closed?

@kchomski-reef that issue was solved in a totally different tool (which uses isort), so, the issue in isort persists (not that users can't manually change it to fix it as was done in the esss_fix_format tool, but the issue is still present on isort).

Ahh, my fault, I haven't looked close enough at the referenced PR, thanks for pointing this out :+1:
I've checked your example against current master (4.2.14) and it seems that at least for email it got fixed, but six.moves still ends up at the bottom:
gh.py
import email  # standard library
import os  # standard library
from os import path  # standard library

from six.moves import zip  # third party

import my_project  # project
from my_project import basic  # project

After running isort gh.py:
import email  # standard library
import os  # standard library
from os import path  # standard library

import my_project  # project
from my_project import basic  # project
from six.moves import zip  # third party

I have the same with a line in sqlalchemy and also with a private "third-party" module. Strangely, I don't get the problem with sqlalchemy all the time. This line in this case is:
from sqlalchemy import create_engine

The problem in my case was twofold:

__init__.py files are skipped by default.
sqlalchemy was not properly detected as third-party due to the usage of a virtualenv

Both could be fixed by adding two lines to my .isort.cfg:
[settings]
not_skip = __init__.py
virtual_env = env

I fixed by introducing this line in isort section.
[isort]
known_third_party = six, six.moves

This should be fixed in develop, with a planned release today.
Thanks!
~Timothy


Error thrown when using a Step from a Definition with an optional parameter

👓 What did you see?
Error is thrown when a valid step is described in a Scenario:
[Error - 6:01:37 PM] Request textDocument/semanticTokens/full failed.
  Message: Request textDocument/semanticTokens/full failed with message: Incomplete group: {"children":[]}
  Code: -32603

✅ What did you expect to see?
No errors.
📦 Which tool/library version are you using?
Extension version 1.3.0
🔬 How could we reproduce it?
With the following valid Step Definition:
Then(/I should( not)? be on the map/i, async (not) => { })

and the Step I should be on the Map :
Feature: Bug Report

  Scenario: User reports a bug
    Then I should be on the Map

📚 Any additional context?
The step definition is valid and made to support a positive and negative case.
Both I should be on the Map  and I should not be on the Map are valid steps.
However, the error is only thrown with the positive case: I should be on the Map

Unfortunately I've stumbled across this error today with the same scenario described by @nextlevelbeard
[Error - 3:13:38 PM] Request textDocument/semanticTokens/full failed.
  Message: Request textDocument/semanticTokens/full failed with message: Incomplete group: {"children":[]}

Thanks for the detailed bug report @nextlevelbeard!


Files in nodes_modules must be ignored when scanning current folder

If no files are passed to toolbelt as param, the current folder and subfolders will be scanned:
gemnasium dependency_files push
[warning] No files given, scanning current directory instead.
[...]

We must exclude node_modules folders, as they will contains a lot of package.json files, and it will mess up the project on Gemnasium.  This folder is used to install packages files locally: https://docs.npmjs.com/files/folders#node-modules

We must also exclude .bundle folders


Make the all-contributors badge render

The all-contributors badge currently doesn't render in the github interface. This PR fixes that.
Also introduced a logo variable to make it easy to inline the badge if you ever want to move it down.

Thanks @Seon82 - can you please run pre-commit over it?

Done, should be good now.

@all-contributors add @Seon82 docs


Multiple BTL icons on FC taskbar

`OS: Debian GNU/Linux 12 (bookworm) (GNOME/gnome)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.36996 (Git) AppImage
Build type: Release
Branch: main
Hash: d92f74ef019fcedbdcdc32055ab2437c950ac23b
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: Polish/Poland (pl_PL)
Installed mods:

btl 0.9.9
`

Whenever I change deactivate FreeCAD (switch windows, move to terminal or switch to web browser) I get another icon of BTL  on the taskbar:

And I have to deactivate every icon with a right click at the taskbar, unless I want a hundred of them after a while ;)

I know 0.22 is a dev version so far, but maybe someone knows the answer to my problem :)

I cannot reproduce it, but just added a safehold that should prevent it from happening anyway. If you update BTL I hope the problem is fixed.

I cannot reproduce it, but just added a safehold that should prevent it from happening anyway. If you update BTL I hope the problem is fixed.

The problem is fixed - thank you! :)


Allow Upload of Tools/Software

There may be scenarios where a user might want to download extra tools to their machine from the LANCommander server that may not be considered a "game". This might also be useful for admins to create little utility scripts that might make someone's machine act better. E.g. they could make a script that automatically enables DirectPlay. This could also be useful for installing common redistributable such as .NET, Java, DirectX, etc.

Closing in favor of project management: https://github.com/users/pathartl/projects/1/views/1?pane=issue&itemId=35771071


[vcpkg] rename hash to sha

in preparation for adding "you don't know #" hashing code

What about MD5?

What about MD5?

@ras0219 hashing objects, for things like unordered_map

@ras0219 hashing objects, for things like unordered_map

I'd like to more clearly know the overall plan before merging this instead of seeing it in tiny steps; for example, what precisely do we need to fix w.r.t. std::hash<> and why shouldn't these share the same name -- the tasks are exactly the same (turn arbitrary object into fixed length integer) with different algorithms and different "guarantees".

I'd like to more clearly know the overall plan before merging this instead of seeing it in tiny steps; for example, what precisely do we need to fix w.r.t. std::hash<> and why shouldn't these share the same name -- the tasks are exactly the same (turn arbitrary object into fixed length integer) with different algorithms and different "guarantees".

@ras0219 yeah, fair enough; I'll write up a mini write-up that explains where I am about this, and then start doing these PRs.

@ras0219 yeah, fair enough; I'll write up a mini write-up that explains where I am about this, and then start doing these PRs.

I believe using "digest" in this fashion is a relic of when MD5 "message digest 5" was the state of the art and "hash" is the modern description of this thing. (e.g. in the replacement SHA "secure hash algorithm")
But certainly not an over my dead body thing.

Replay in vcpkg-tool repo.


feat: Port algebra.punit_instances

Port of algebra.punit_instances

[ ] depends on: #1330

Dependent on #1330

Linter complaints in Mathlib.Algebra.PUnitInstances, new since the merge.
impossibleInstance linter complaining on PUnit.canonicallyOrderedAddMonoid
argument 1 y : PUnit

and simp-normal form linter complaining on PUnit.sub_eq:
Left-hand side simplifies from
  x - y
to
  0
using
  simp only [sub_self, PUnit.zero_eq]

as well as giving "simp can prove this" on PUnit.gcd_eq:
by simp only [gcd_same, normalize_apply, normUnit_eq_one, Units.val_one, PUnit.one_eq, mul_one]

and PUnit.lcm_eq:
by simp only [lcm_same, normalize_apply, normUnit_eq_one, Units.val_one, PUnit.one_eq, mul_one]

If I'm reading correctly, the old version was on top of mathlib4 bfe06a7794b99fc5cd4c62d3f9bdb83ffbc71cc3 and the new version is on top of f46ac6ed5443aea3c63c631a9f79bac26165cae1, i.e. the following commits were added:
feat: port GroupTheory.Subsemigroup.Membership (#1318)
feat: port GroupTheory.Submonoid.Centralizer (#1324)
chore: remove superfluous imports from runLinter (#1322)
feat: ci: upload caches to azure (#1320)
chore: fix source header in Order.Monotone.Monovary (#1310)
feat: port GroupTheory.Submonoid.Center (#1315)
chore: fix more casing errors per naming scheme (#1232)
feat: caching build files on Azure (#1230)

This PR/issue depends on:

leanprover-community/mathlib4#1330
By Dependent Issues (🤖). Happy coding!

Linter complaints in Mathlib.Algebra.PUnitInstances, ~new since the merge.~
impossibleInstance linter complaining on PUnit.canonicallyOrderedAddMonoid
argument 1 y : PUnit

Very strange issue -- I posted it to the Zulip.

and simp-normal form linter complaining on PUnit.sub_eq:
Left-hand side simplifies from
  x - y
to
  0
using
  simp only [sub_self, PUnit.zero_eq]

& sure enough it does -- but the fix is to explicitly define sub_eq rather than to_additive it?

as well as giving "simp can prove this" on PUnit.gcd_eq:
by simp only [gcd_same, normalize_apply, normUnit_eq_one, Units.val_one, PUnit.one_eq, mul_one]

and PUnit.lcm_eq:
by simp only [lcm_same, normalize_apply, normUnit_eq_one, Units.val_one, PUnit.one_eq, mul_one]

De-simp it?

as well as giving "simp can prove this" on PUnit.gcd_eq and PUnit.lcm_eq

De-simp it?

There's been some discussion of this one, see e.g.
https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/simp.20can.20prove.20it/near/319425225
I think you want to de-simp and add a porting note.  Possibly in the future this will change (e.g. we might add a linter mechanism to enforce that simp continues to be able to prove this, throughout the rest of the port).

and simp-normal form linter complaining on PUnit.sub_eq:

& sure enough it does -- but the fix is to explicitly define sub_eq rather than to_additive it?

I looked at this one more closely.  The reason it worked to explicitly define sub_eq rather than to_additive it is that you need to give this lemma the nolint simpNF attribute, and you did not have the right syntax to to_additive-ize that attribute, probably because this changed just recently
https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/improved.20interaction.20of.20to_additive.20with.20other.20attributes
so your mathport output might have been for an old version.  I believe the new syntax would be
@[to_additive (attr := simp, nolint simpNF)]

You probably want to make a pass through the whole file, because I see other lemmas with simp and to_additive attributes that probably also need to be updated.
(Note for the experts: this is a case of a lemma which is marked nolint simpNF because it's proved by rfl so we want to make it available for dsimp.)

@[to_additive (attr := simp, nolint simpNF)]

I think I don't have the updates in this branch. Will hunt down what I need to manually merge..

@[to_additive (attr := simp, nolint simpNF)]

I think I don't have the updates in this branch. Will hunt down what I need to manually merge..

Addressed, now dependent on #1314 as well

Who knew a file that's all trival defs and lemmas could be so difficult.

Thanks!
bors r+


Support dragging multiple elements

There is a common pattern that is hard to implement with native drag and drop: dragging multiple elements. While selection mechanics might vary from app to app (cmd+clicking, checkboxes, predefined groups), but it would be nice to at least make it possible to support this scenario.

Because multiple dragged items may not be siblings in DOM and setDragImage(element, x, y) is pretty much insane and hasn't gotten any better, we won't burden ourselves with trying to render several elements in drag preview at once.
How can we help implement this scenario, if we can't show a "multiple" drag preview?
In a way, this scenario is already possible: consumers can manually keep track of selected elements, set dragPreview to some kind of generic placeholder Image and react appropriately to the dropping of (as far as business logic is concerned) several elements.
However there is currently no supported way for one element to know that it's part of a group that's being dragged. From react-dnd's point of view, if we drag something, this component gets getDragState(type).isDragging = true, but other components don't. From your app point of view, if you support multiple selection, you want all logically "selected" items to be aware that they're being dragged, even if only one of them is being actually "DOM-dragged".
What we need is a way for components to tell react-dnd that, “hey, although onDragStart was received by another component, I want to pretend that I'm being dragged too, and have my getDragState(type) mirror dragged component's getDragState(type), and have my endDrag(didDrop) called too so I could do my stuff”.
How would components opt into that?

Not a priority. We can revisit after introducing drag source keys (https://github.com/gaearon/react-dnd/issues/38#issuecomment-73409935).

I'll be interested in this down the road,  although I think you might be able to just wrap a section of your component tree with a component that has a dragSource...
Like if you hold shift and click, it expands what sections of the array are copied into the dragItem or something?

Kinda.
First we learn to pass null component (needed for #38) and a different component with same key (needed for #53).
Then we add groupKey which is optional. Like key, it is specified in drag source and is a string. When you begin dragging something with a groupKey, we will call beginDrag not just on the caller, but on every mounted drag source with the same groupKey, and gather their items into an array. We will pass these items instead of item to drop target methods. When dragging is over, we will call acceptDrop on drop target with an item array, and then call each drag source's endDrag with their item.
What's fun is that we can draw DragLayer with a custom “composite” thumbnail component and a counter like I screenshotted above because we know the count from items.length.

Thats a way less ugly idea than what I had in mind

:+1: for this feature :-)

Closing, as I don't currently have a use case for this, and it's a significant implementation effort.

@gaearon
I used Java/Swing DnD back in the day, and they had probably an army of developers who grappled with this problem and came up with a pretty refined, extremely generic and flexible framework.  I would recommend researching old desktop frameworks as they probably solved all the difficult challenges with making a good DnD framework like this.
The way to do this in Java/Swing (although it had no built-in support for drag images) was to make the tree view itself the drag source, and make it able to decide whether or not a drag should be initiated based on its current state and the drag start position.  Is monitor.getInitialSourceClientOffset() available when canDrag and beginDrag are called?  People will definitely want it to be available.  They will probably also want modifier keys (ctrl, alt, shift) to be available and to be able to make drag sources specify whether to move or copy, and drop targets to specify whether they support move and/or copy, based upon any of these factors, because that is possible in Java/Swing and I'm guessing other frameworks.  Swing also had the concept of drag gesture recognizers that could be swapped out.
I'd predict that treating all the items in the list as individual draggables will just be difficult compared to having the list component be the single drag source that figures out what kind of drop payload / preview image to construct based upon what's selected in it.
Consider also that a developer might want to change the order of the items being dragged based upon which item the user clicked and dragged from.  I believe Windows Explorer behaves this way.

Has anyone implemented dragging multiple items with react-dnd in their applications? What's you current solution for this?

did you mean multiple drop target for single drag source?

+1 @danii1 : Has anyone implemented dragging multiple items ?

I implemented it, solution is basically what is described in the first post:

Keep track of your selected items
Implement CustomDragLayer (see https://gaearon.github.io/react-dnd/docs-drag-layer.html) and render your selected items yourself
Handle drop if dropped item is part of the selection

I implemented it by:

Keep track of selected items in a Set
Pass this as a property to the dnd Source
In beginDrag retrieve the Set form the props and return it as the drag item
Create a custom drag preview
On EndDrag move all the items in the Set into the dnd Target

I have a slightly different use case for this I think, I want to draw nodes that are draggable with edges that aren't draggable but do move when nodes they're attached to move. My current implementation is a CustomDragLayer that draws the edges when it detects a DraggableNode is moving (also drawn on the CustomDragLayer but I think it might be better to model it as a multiple drag situation by implementing all edges as DragSources with isDragging() implemented to detect if a node they're attached to is moving so that they can draw themselves instead of having the CustomDragLayer inject the coordinates as props.

@danii1
Can you please share the one you have implemented for a reference

I will write a post and add repo about multiple and nested drag and drop with react-dnd + redux.

@nayemmajhar, it would be great

@nayemmajhar any update on an example with this?

I have created this application using react DnD with reduxJS long ago https://www.joomshaper.com/page-builder I am writing a tutorial but need time publish

@serle Would you be able to share a code example of how you did this?

@ianmclean2011 check it out here: https://github.com/react-dnd/react-dnd/issues/590

I'm trying to implement multi-drag in an example similar to the sortable example here: https://react-dnd.github.io/react-dnd/examples-sortable-simple.html. I want to be able to select any objects, and then move them as a unit up and down the list. I'm having trouble wrapping my head around how to use the examples/info shared above to do this. Any thoughts/ideas/feedback on how this might work?

If anyone's interested, I implemented a multiple drag / grid view: https://codesandbox.io/s/rwrly0yxnp.
You can use cmd/ctrl and shift keys to select multiple items, then drag them around the grid and insert them anywhere.
This is still a demo, but I might abstract the code a little bit more and package it in a component later.

@melvynhills Have you investigated a solution that doesn't require passing all the selected cards to each Card component? I don't think there is a solution considering the Card's beginDrag() needs a reference to all selected Cards.

@jmcrthrs No, it doesn't seem possible to me with react-dnd API. I don't think there's a way to know before dragging which specific item is going to be dragged. That's also the only way to know whether the dragged item is within the multiple selection you made, or if it's outside of that selection that we then need to replace.

@melvynhills @jmcrthrs other desktop dnd frameworks I've used rely on making lists and tables the drag sources/drop targets instead of making each individual row, cell, item etc. its own drag source and/or drop target.  The implementation for dragging multiple items, as well as getting the specific drop location within the list or table, comes out a lot cleaner that way.  When a list receives a drag start event it can simply look at its current selected items.

@jedwards1211 do you think it's doable with this library? Especially the use-case of starting dragging an item that wasn't selected before the drag start. I'm not sure it's the way react-dnd is supposed to work.

Does anybody solved case in which there are multiple drop targets?
Let's say one is dragging multiple items (using one of the solutions above) and one item ends up on one type of drop target and the other on the different one. drop will be triggered just for drag source which initiated drag, but not for the other one. Any ideas how to trigger drop individually for each item being moved.
Example:

@melvynhills probably if a mousedown handler triggers item selection (which you should be doing, all software with DnD I have used works this way), it will work just fine with React DnD for the container component to be the drag source.

Have you investigated a solution that doesn't require passing all the selected cards to each Card component?

This is an example of why I would recommend making the container component the drag source instead of the individual items.  I haven't needed to implement multiselect with React DnD but maybe sometime I can make a sandbox to convince folks it's the more maintainable approach

Has anyone implemented dragging multiple items with react-beautiful-dnd in their applications? What's your current solution for this?

Here is my current solution with react-dnd based on @melvynhills's codesandbox. I rewrote the code using new APIs and react hooks.
You can try the live demo here.

@znwang25 and @melvynhills Is it possible if I drag multiple images and hover on another image then that all selected drag images get paste another image.
Something like multiple image selection and upload

check above image in that green note indicate image 4 to 22 is copy inside that image.


Fix nested table type creation parsing in declaration

DECLARE
	TYPE Foursome IS TABLE OF VARCHAR2(15);
BEGIN
       ...
END;

Is translated to
DECLARE
	VARCHAR2 VARCHAR2(15);
BEGIN
        ...
END;

The reason is part of because the name variable is reassigned

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhenggli seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

CI Test一直失败，麻烦核实一下

好像原来的test cases就是有问题的 已经update了... 还有请问是否可以在code中使用JDK17的新特性 比如text block

Codecov Report
Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 58.74%. Comparing base (7c5ca9b) to head (1aee7c4).
Report is 48 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5714      +/-   ##
============================================
- Coverage     58.75%   58.74%   -0.02%
- Complexity    27796    27798       +2
============================================
  Files          1333     1333
  Lines        127689   127716      +27
  Branches      24061    24066       +5
============================================
+ Hits          75024    75026       +2
- Misses        43332    43351      +19
- Partials       9333     9339       +6

Files
Coverage Δ

...l/dialect/oracle/parser/OracleStatementParser.java
79.69% <50.00%> (-0.20%)
:arrow_down:

... and 19 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c5ca9b...1aee7c4. Read the comment docs.