Adds commands to generate multiple proofs at once and manage cache

This introduces some additional commands to improve the speed at which validator proofs can be generated.

A proof for a single validator index requires loading and parsing the state. This implements a simple disk cache of the parsed state which saves ~10 seconds of execution time.
To clear the cache, there's a new command introduced.
There's also a new command introduced to generate proofs for multiple validator indexes in one call.

I don't necessarily expect this to be introduced into the official repo. I understand it's not a very clean implementation. However, these are some changes we're using to improve the speed at which proofs can be generated, and we wanted to share upstream.

Overlap with https://github.com/Layr-Labs/eigenpod-proofs-generation/pull/63. I can revise this PR once that is merged and keep this isolated to just the caching.

This change will no longer apply now that the verification method is changing.


Failure to reload the subprocess gets blueapi into an unrecoverable state

To reproduce:

Run blueapi against a scratch area
Edit the code to introduce a fatal bug (e.g. a syntax error)
Reload
Fix the bug
Try to reload again

The cause of this is that in the endpoint for environment DELETE, the context is only restarted if there exists an initialized context already. The intention was to prevent repeated calls to the endpoint from "stacking up" however on reflection this might not really have been addressed.
When there is a failure the initialized property on SubprocessHandler is never set to true.
We should add an error property to the environment context to allow it to restart if there are errors too.
It can be added to the environment entity.

I think with #504 we wouldn't have this kind of issue


[GitHub] Specify git clone protocol

Description
The option to use the SSH protocol, which previously existed only in clone with option, has been moved to the extension preference, so we can now clone repositories in any way we like, including using the copy clone command or clone and open .
clone with options maintains the same settings as before while respecting Extension Preferences.
Screencast
Extension Preference

Clone with options

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Could you add an entry in the CHANGELOG.md file? Here's our guidelines about that: Version History.


Join cost calculation uses default value of -1

It seems that in certain cases during three way joins, when one of the children of a join is a join itself, its cardinality estimate will be -1, so the cost model will use that -1 value to compute the cost for the overall join (which is bad). This is most likely due to the optimizer not properly updating the cardinality of intermediate joins here

Possibly, this might affect our benchmarking results for our class project, but its hard to say.


better data tab ui

move each option into separate tab so more organized

too vague - closing in favour of specific enhancements


Ternary operator values implicit conversion issues

Is it fully by design or sort of a bug?
1. Describe the bug
When I use the ternary operator with one-character text constants as values, I get conversion errors (compiler or runtime) between Text and Character types.
2. To Reproduce
Standard is TextElement from XmlPort, but it does not matter, it can be any Text variable.
Example 1:
Standard := OptionValue = DummyVATReportHeader."VAT Report Type"::Standard ? '1' : ''; (empty text)
Cannot implicitly convert type 'Text' to 'Char' AL0122
It is the compiler error in VSCode. Ok, two different types of values are used, but couldn't it be more looser?
"Negative" definition is OK in VSC, but I did not try to publish and run it:
Standard := OptionValue <> DummyVATReportHeader."VAT Report Type"::Standard ? '' : '1';
Example 2:
Standard := OptionValue = DummyVATReportHeader."VAT Report Type"::Standard ? '1' : ' '; (one-space-constant) or
Standard := OptionValue = DummyVATReportHeader."VAT Report Type"::Standard ? '1' : '0';
AL compiler in VSC does not complain. BusinessCentral will crash when run that code - and it is not debuggable. But in debug mode, VSC shows the conversion error:
Error: C# compilation has failed for the application object XmlPort_nnn.
The failing c# file name is 5F513583CF61537DB8A2B84F5170D2575517F854DED61E60FD0ECD0091A256A3.cs. You can find this file with the associated AL file saved in the C:\ProgramData\Microsoft\Microsoft Dynamics NAV\252\Server\MicrosoftDynamicsNavServer$BC\apps\compilationerrors folder.
Detailed compilation error: C:\ProgramData\Microsoft\Microsoft Dynamics NAV\252\Server\MicrosoftDynamicsNavServer$BC\apps\metadata\3\5F\5F513583CF61537DB8A2B84F5170D2575517F854DED61E60FD0ECD0091A256A3.cs(1242,60): error CS1503: Argument 1: cannot convert from 'target-typed conditional expression' to 'string'
3. Expected behavior
4. Actual behavior
5. Versions:

AL Language: 14.2.1249978 (I did not test the insider 15.0)
Business Central: 25.2.27733.28023
Operating System:

[X] Windows
[ ] Linux
[ ] MacOS

@BazookaMusic This is related to #7926  - but this time, both return parts are string, so this is another issue.

Yes, I saw that issue and I wanted to continue there, but it is already closed and, as you wrote, there are different types.

Accepting because C# compilation errors is a bug. If it compiles it should run.
However, the conversion errors are because these are the conversion rules for AL. Since the type of the expression is decided by the "true" side, you need to adjust the code so that there is a conversion from the "false" side to the "true" side.
Maybe it makes sense to adjust these conversion rules, so you can add an idea in BCIdeas with some annoying examples.

@BazookaMusic

Since the type of the expression is decided by the "true" side, you need to adjust the code so that there is a conversion from the "false" side to the "true" side.

I don't get this. Did you mean that we should adjust the AL code? Why and how - all of the true and false parts above return a string.

No Natalie, it is as the compiler says in Example 1: true part returns Char type ('1') - unfortunately (because it is only one character). false part in my examples is either Text (empty string ''), or Char (one-spaced string ' '). It is very strict implicit conversion. I would be glad if it has been more looser conversion between these two types, but ok, I get it.
They were very special examples. I did not try it, but if I used Labels or Text variables, it would run correctly, I believe.

As you write, ToString() or Format() should help and I considered that but I chose other solution eventually. Problem is that all of "string helpers" lower readability and simplicity of code - and that is what the ternary operator is meant for (I think).


plots

The plots contain a network outside of the frame.
In jupyter notebook, the following happens:
myscm.plot(node_size=1000, alpha=1)

Thanks for reporting @jwnys. Just found the reason for the bug and going to include it in the 0.2 version release in a few days.

Thanks for reporting @jwnys. Just found the reason for the bug and going to include it in the 0.2 version release in a few days.


Chore/typescript

Converted components in the errors and error-details folder to TypeScript. Refactored state management to account for the recently introduced ProjectsContext and hook. Extracted error rows into their own component. Did a general refactor for more readability and maintainability.

The restructuring is excellent - its very clear what each component is doing and how it relates to the whole while also making the typing more clear and readable.


Small iteration on the plugin

Do not eat whitespace from the message

mypy might add leading whitespace to messages, it's like a form of
indentation, to help with readability.  Keep these!

Tell mypy to omit the summary output as we don't parse it anyway

Combine errors with their notes by merging their messages

Throw away "x" defined here note which is not helpful here

E.g. (after):

You see some indentation in the long message (1).  And the long message is actually one error with some notes integrated (3)
(before)

Also the first error "bark" defined here has been removed. (4)

Hi @FichteFoll,  thanks for the quick look.  I don't have merge and releases right here (unlike on the other repos where we usually met).  😀

Actually mypy is super-important.  Why isn't this in the org?

I don't have merge and releases right here (unlike on the other repos where we usually met).

Oh true, I didn't even realize. I'll take care of it tomorrow. As for moving it to the org, sounds good to me, but that's something that @fredcallaway needs to handle (unless you want to hard-fork). :wink:

As long as "org" is still open source, I'm happy to transfer ownership of the plugin to a group that is actively maintaining it!

(Looks like I have an open transfer to @FichteFoll. I'll merge this for now though.

Everything in the org is open source of course.

Hm, apparently I did receive an email regarding a transfer of this repo in 2016, shortly after you've added me to the repo. Obviously I can't accept that anymore (it's only valid for a day).
I suggest to move it to @kaste since he's also a member of the SL org (which I'm not), so he can then transfer the repo into the org.

@kaste It's not letting me transfer it because you have a fork. Kind of weird github doesn't have a more elegant way to handle that, but I guess you have to delete your fork if you want to take ownership of master.

Lol.  Deleted my fork.

Okay, moved to the org.  Note that you both, @fredcallaway and @FichteFoll, have the same rights as before.  That's probably okay for you. (?)


[FEATURE REQUEST] CSV File Import

Hi, your app looks great. Would you consider adding the ability to import whole decks from CSV files in a future upgrade, please?
Thank you very much, and best regards

Hi there! I'm currently working on this and will try to push the changes in a couple of days. However, for the moment, I will only support importing decks and flashcards that have been exported from memotica.

Thank you ❤
Is it also possible to use a keyboard shortcut to confirm my knowledge of the question (wrong/good/easy), insetead of clicking on the corresponding button on the interface?
For example: "W", "G" and "E" or "1", "2" and "3" ?

Yes! That's something I will start working on soon. For the moment, I will close this issue since I just added the import and export sub-commands, and open a new issue with the request to add the keybindings to the review screen.


update new module script to use geo-compose toolkit component

Description
PR to update the new module script to spin up new samples using the geo-compose toolkit module by default.
Links and Data
Sample Epic: runtime/kotlin/issues/3370
What To Review

Review script files

How to Test

Test if the JAR creates a new sample as expected.
To run the script and create a new sample:
java -jar tools/NewModuleScript.jar
The .jar file will prompt you to type in the name of the new sample.

@shubham7109 Thanks, please re-review?

Could you update the snippets tag in the metada.json here as well? I'll update the tasks to mention this step.

@puneet-pdx There might be some merge issues, as Shubham recently merged main into the feature-branch/geo-compose. I will merge my branch with the latest feature-branch/geo-compose, which should resolve some errors.

@puneet-pdx thanks, a re-review.
Also note, I have updated version.gradle file with arcGISVersion changes, in this PR


[Unified Checkpoint] Accelerate loading checkpoint by multi-thread

PR types
Performance optimization
PR changes
Others
Description
Accelerate loading checkpoint (only safetensors) by multi-thread

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Expand/Collapse Fields

Good morning Nicolas, i'm using this tool and it is so interesting. But miss a resource of expand or collapse a cell like occurs in microsoft excel. Do you intend to develop this? Or is this already exists?
Sorry for my english.
Rafael

@nicolaskruchten, Thanks a lot for such a useful library.
I have added the support for roll-up summary (sub-total rows) using aggregators and renderer concepts . Its available at OnFieldClick branch of the fork that I have made
Would like to receive your comments/feedback from friends here before I send the pull request. I plan to add collapse-and-expand feature on top of this. Thanks.

@nicolaskruchten , friends... I have further enhanced subtotal_renderers with both row-wise and column-wise subtotals. Also added Collapse/Expand functionality for rows. Collapse/Expand for column subtotals is under construction....
Please check Subtotals branch. and provide your feedback. Steps to use:

Download pivottable-Subtotals.zip
Extract and place pivottable and its subfolders under document root of your local webserver
Access the demo using url: http://localhost/pivottable/examples/subtotal.html

Sample screenshot:

@nicolaskruchten and friends, happy to inform you that Subtotal.js is available for download as an NPM module or Bower component.
Subtotal.js is hosted in GitHub as pivottable-subtotal-renderer
@nicolaskruchten , In setting up Subtotal.js, I have shamelessly copied the structure, style and some portions of text and code as is from Pivottable.js repository. Hope you don't mind.
Thanks again to all of you for your feedback and support :+1:

All right, I think we can finally consider this issue resolved! The official answer in the FAQ is now "use Subtotal.js" :)

onrefresh in collapse

@kalimuthu123 probably create an issue in the subtotal repo. 🙂


How to use this project?

Is there a detailed description of this project?

Check the README.md https://github.com/akofman/cordova-plugin-add-swift-support

I've read it, but I still don't understand. So is there a more detailed explanation？I have an app for iOS that has already been written. So make it into a plug-in, and then use your plugin? Or do you use this project directly?

Hello @Jessting, you won't find anything more than the README as a documentation but, it's been enough until then :) To clarify, this plugin will permit you to write the iOS part of your Cordova plugin with the Swift language. An article has been written about how to use it, maybe it will be clearer for you : https://moduscreate.com/blog/writing-a-cordova-plugin-in-swift-for-ios/.
Also in your last comment you're talking about an app, what is exactly your need ?

First of all, @akofman, thank you for your answer. Then I've written an iOS application project that I want to integrate into Cordova's new project. That's my goal.

Hmmm ok, and if you already have an app, why would you want to convert it into a Cordova project ? The main goal of Cordova is to write an app from web technologies, in your case, if I got it well, you already have an iOS app written in Swift ?

Yes, I've written an iOS native project with swift, but I want to use this project as another sub-module of the project created with Cordova. I'm sorry I don't know how to operate it.

Maybe writing your own plugin embedding your app and presenting it from a modal (else I think you will have navigation issues between your views and the Cordova Webview) is a solution. You should talk with the Cordova Slack community (http://slack.cordova.io/), I'm sure they will definitely help you. Sorry if I can't help you more here but what you're trying to do is more than something with this plugin in particular actually.

Thank you very much for your answer, @akofman .I find it really difficult to implement my idea. Now I am inquiring about the information for my project. Last but not least， thank you for your ideas.


Change ctrl+alt access to  vscode-kb-macro ?

I am physically unable ton press Ctrl and Alt together<EMAIL_ADDRESS>)  -- David

Thank you for your question!
If I understand correctly, you are not able to use the keyboard shortcuts Ctrl+Alt+R and Ctrl+Alt+P, and want to change them to other key combinations that you can use.
Yes, you can change the shortcuts.

Open Keyboard Shortcuts on your VS Code.
Search for "ctrl+alt+r", then you will find the two commands: Keyboard Macro: Start Recording and Keyboard Macro: Finish Recording.
Right-click on each line and select Change Keybinding... to change the key combination.
If you have successfully changed the ctrl+alt+r to another key, do the same thing for "ctrl+alt+p".

Thank you, tshino! Finally found this video which answers my question:
https://www.youtube.com/watch?v=kI2idVmblMw
Otherwise, I was going to have my toes or popsickle sticks! -- David
On 2023-04-04 10:48, tshino wrote:

Thank you for your question!
If I understand correctly, you are not able to use the keyboard shortcuts Ctrl+Alt+R and Ctrl+Alt+P, and want to change them to other key combinations that you can use.
Yes, you can change the shortcuts.

Open Keyboard Shortcuts on your VS Code.
Search for "ctrl+alt+r", then you will find the two commands: Keyboard Macro: Start Recording and Keyboard Macro: Finish Recording.
Right-click on each line and select Change Keybinding... to change the key combination.
If you have successfully changed the ctrl+alt+r to another key, do the same thing for "ctrl+alt+p".

--
Reply to this email directly, view it on GitHub [1], or unsubscribe [2].
 Glad to hear that.

Thought you might enjoy seeing the tutorial I wrote for my tech-writing
students at Austin Community College (Austin, Texas):
https://mcmassociates.io/vsc_course/vsc_changekeybindings.html
Prefer to show your full name, location?  Glad to hear that.
--
Reply to this email directly, view it on GitHub [1], or unsubscribe [2].
You are receiving this because you authored the thread.Message ID: @.***>

Links:
[1]
https://github.com/tshino/vscode-kb-macro/issues/230#issuecomment-1497247088
[2]
https://github.com/notifications/unsubscribe-auth/A5RJ6DFO3G4CMY5ROR3Y2NLW7VAZFANCNFSM6AAAAAAWS2ZCOQ


fix: Artist list item meta text

This PR resolves ONYX-186
Description
Artist list item meta text.

Before
After

PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Fix Collected artists list item meta text padding - ole

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Warnings

:warning:

❌ An error occurred while validating your changelog, please make sure you provided a valid changelog.

  Generated by :no_entry_sign: dangerJS against 6a0dccbcb3134fba413aed226249212c96e9ebe1


add initial dashboard

This is basically how it will look

We're currently processing your upload.  This comment will be updated when the results are available.


Getting following error while connecting to Guest OS: Client received SOAP Fault from server: Permission to perform this operation was denied. Please see the server log to find more detail regarding exact cause of the failure

[x] I am using the latest SDK version
[ ] This API is compatible with my vCenter version (You can get this info from the API documentation )
[ ] I have searched existing issues

Description
Environment

SDK version:
6.7.0

Java version:
1.8

vSphere version:
6.7.0

Steps or code snippet to reproduce
String[] opts = new String[]{"guest.guestOperationsReady"};
String[] opt = new String[]{"guest.guestOperationsReady"};
wV.wait(ob, opts, opt,new Object[][]{{true}});
Map<String, ManagedObjectReference> var1 = VimUtil.inFolderByType(vimPort,serviceContent,serviceContent.getRootFolder(), "VirtualMachine");
ManagedObjectReference var2 = (ManagedObjectReference)var1.get(vmName);
if (var2 != null) {
System.out.println("Virtual Machine " + vmName + " found");
System.out.println("Guest Operations are ready for the VM");
ManagedObjectReference guestOpManger =
serviceContent.getGuestOperationsManager();
ManagedObjectReference fileManagerRef =
(ManagedObjectReference) VimUtil.entityProps(vimPort,serviceContent,guestOpManger,
new String[]{"fileManager"}).get("fileManager");
System.out.println(fileManagerRef);
System.out.println(fileManagerRef.getType());
System.out.println(fileManagerRef.getValue());
NamePasswordAuthentication auth = new NamePasswordAuthentication();
auth.setUsername("username");
auth.setPassword("password");
auth.setInteractiveSession(false);
vimPort.validateCredentialsInGuest(fileManagerRef, var2, auth);
System.out.println("validation for guest Credentials");
List li=new ArrayList<>();
li.add("open notepad.exe");
System.out.println("Executing CreateTemporaryFile guest operation");
System.out.println("FileInitailization"+vimPort.initiateFileTransferFromGuest(fileManagerRef, var2, auth, "C:\Users\"));
vimPort.createFolder(fileManagerRef, "C:\Users\Public\dsfsfs");
String result =
vimPort.createTemporaryFileInGuest(fileManagerRef, var2, auth,"TestAfter", "BeforeTest", "C:\Users\Public");
System.out.println("Temporary file was successfully created at: "
+ result + " inside the guest");
Actual behavior
Unable to login to Guest OS and not fetching any files
Expected behavior
Login to Guest OS should happen, file directory inside Guest os should be available to perform read and write operation.
Note: I am not sure that the methods i am trying is the correct one. Please help me with correct one. Even I am not able to fetch the ip address of the VM using sdk.

@kunal-pmj  Could you please me help on this issue???


Propose to clarify

closes https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/3303

@JoanneHendrickson PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@JoanneHendrickson please help me with the review


GEODE-1994, revisited: Removed guaranteed failures.

Removed two uses of ServerLauncher.Builder.setMemberName that are guaranteed to throw under the changes introduced by GEODE-1994.
With the previous update to StringUtils, ServerLauncher.Builder.setMemberName throws when its input is blank.  These two uses are behind conditionals and only occur when the member name is blank, guaranteeing failure.  This results in the status server and stop server commands functioning only when --name is used, but failing with --dir and --pid.

LGTM (pending green precheckin)

Precheckin running...

Green across the board.

Merged as dff937f


OTA question

https://github.com/SuperHouse/esp-open-rtos/blob/master/examples/http_client_ota/http_get.c
http_client_ota Example works with local ip address..
I tried to put blink.bin file on a firebase hosting also to a github repo but couldnt update it..
Is it possible to update a very important release like http_client_ota (i can re-setup homekit settings its ok)
Tried these only local ip worked..
#define BINARY_PATH "/blink.bin"
#define BINARY_PATH "https://testxxx.firebaseapp.com/blink.bin"
#define BINARY_PATH "https://github.com/kiralikbeyin/html/raw/master/blink.bin"

#define SHA256_PATH NULL //bypass sha256

#define SERVER "<IP_ADDRESS>" //local ip works fine
#define SERVER "<IP_ADDRESS>" //github
#define SERVER "testxxx.web.app"
#define SERVER "<IP_ADDRESS>" //firebase

Maybe this is a solution for you? https://github.com/HomeACcessoryKid/life-cycle-manager

@AchimPieters Firmware size makes problem..
https://github.com/HomeACcessoryKid/life-cycle-manager/issues/11


feat: adds getter for program field in TestModel

During testing, I need a mechanism to access the TestModel's underlying program in order to assign it to a program struct that I'm using to send messages back to the TUI during business-logic portions of my app.
In other words, I don't want my test code to have to call tm.Send, I'd rather have the existing Send calls in my business logic work with the same program that the tests are using
Quick and dirty solution is to add a getter for the program, but I'm happy to look into other methods.

thanks!


Add Gitpod setup

Describe your change:
I have configured the environment to run the repository in Gitpod.
I've also edited the README.md file to include the Gitpod "ready to code" badge.

Hi, I am participating in hacktoberfest.

Thank you!  Sorry, I thought I had merged this already


clowdapp: Add object storage for Pulp (HMS-4235)

Add second s3 bucket for commits stored through Pulp. This is for clearer separation of Pulp and direct legacy content.
FIXES: HMS-4235
Type of change
What is it?

[x] New feature (non-breaking change which adds functionality)

Lets get this in, the config is being added in https://github.com/RedHatInsights/edge-api/pull/2570

Let’s just wait until everything is set up correctly in app-interface, I am still not done with the client. I do not expect to finish this week at all.


Support indexed_chars_field in ingest attachment processor plugin

Relates: https://github.com/elastic/elasticsearch/pull/28977
Add support for indexed_chars_field on AttachmentProcessor to be able to specify the size of indexed characters on a per document basis. This new indexed_chars_field property will be of type Field.

This looks like its only for 6.4.0 not 6.3.0

@Mpdreamz agreed. Will update label to target 6.4.0


Sitcky side bar with height more than view port.

See the plunker below...
http://jsfiddle.net/ryanmaxwell/25QaE/
Can we achieve that type of functionality with this package??

This effect is really what I need too. Is there a way to get it using ngSticky?
Thank you,
Luis


[EROR] Unable to read renewal ().renewal.json: result is empty

Please post your question under: https://github.com/win-acme/win-acme/discussions/
version <IP_ADDRESS>
how can i fix error
error message
[EROR] Unable to read renewal ().renewal.json: result is empty
and No options available
i need to renew certificate

Would you mind sharing the content of ().renewal.json file from %programdata%\win-acme\acme-v02.api.letsencrypt.org?
It may be possible to correct the .json. Otherwise you'll have to create a new certificate.


Automatically desaturate contributor images

Who is this for?
Alice and the rest of Editorial.
What is it doing for them?
Contributor images should always be black-and-white, but occasionally they're not, see https://wellcomecollection.org/events/YvTvQxAAACMA2dO4
This applies filter: saturate(0%) to desaturate any colourful contributor images that slip through.

Seems like someone found a hammer today and now everything is a nail

Partly, but I kid you not, this request came via Slack DM from Alice White who had no prior knowledge of today's other work. :O


SOFA and Nudge 2.0

Discussed in https://github.com/macadmins/nudge/discussions/590

Originally posted by aanklewicz July 10, 2024
Hey all, was in the session at PSU today about Nudge and it was mentioned that 2.0 is going to support using SOFA so you don't have to manually edit the config profile for every macOS release.
I created an Okta Workflow that does a similar thing, so I'm excited for this to be a built in functionality.

We have a different due date based on major or minor versions. For minor versions, our staff have 14 days to update.
For major versions they have 90 days to update (unless 90 days means Christmas like 2023)

So macOS 14.6 comes out and then the due date is $releaseDate+14. macOS 15.0 comes out and due date is set to $releaseDate+90. 15.0.1 comes out 14 days after 15.0, so the due date stays the same as it was for 15.0.
Just an idea if others see this as valuable. If not, I have the mechanism to do what is required at my org.

https://github.com/macadmins/nudge/commit/93ce34ab1b307c5266f6ea8a4a80756fefe452f1 done here


Add currentPage as props

In the current version users cannot give current page numbers as props. But sometimes it is necessary to make the page number dynamic.

So this allows a library user to specify which page the datatable starts at?

(It's been billion years since I've made this library or used Vue.js even, so I hard remember anything about this)

So this allows a library user to specify which page the datatable starts at?

yes


adding domain

@nolzie lib/domains/au/edu/student/adelaide.txt represents a domain of adelaide.student.edu.au. Did you in fact wanted to add student.adelaide.edu.au? Thank you.

@nolzie I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host adelaide.student.edu.au not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


How to mark selected images already marked

how can we mark any 3-4 images alreaddy selected

The selection is "toggle-mode" So if you select an already selected image, it will unselect.
I don't know what you mean exactly, you either select it or not (:


Adding the possibility to change the footer year dynamically according to the current year

Earlier the footer note year was hardcoded, So each year we need to update the value, this can be done programmatically using js.

We can use JSF for that. It is not recommended to use our own js at any stage as there are conflicts with JSF generated js.

Working


Add documentation for simplest case

Please add documentation for the simplest case: doing a compare on an entire page as it initially displays.

The test case example is already provided in quick start guide.


macOS: source ~/.ambientum_rc fails because of usergroup in chown

Hi,
macOS, by default, has a primary group named staff, so https://github.com/codecasts/ambientum/blob/master/commands.bash fails.
chown -R $(whoami):$(whoami) $A_BASE

If command is running OK for other *nixes, maybe we could include an extra step, and verify if it is a macOS, and run the right command.
Here's an version that works for macos
chown -R $(whoami):$(groups $(whoami) | cut -d' ' -f1) $A_BASE

Source: https://superuser.com/questions/590683/how-do-i-find-my-user-id-and-group-in-mac-os-x

@rogeriopradoj can you please check which numeric id the group staff has? it would be ok as long they're the same, there are a new version of those scripts coming up without mappings (using volume instead).

@rogeriopradoj just a quick update, the changes on ambientum_rc are comming this week, so just fix it locally for now to be able to use it.
I'll commit a working progress so you can also test it on mac, deal?

This one will remains open, because the directories should be permission fixed at runtime, so volumes and other will work well.
Thank you!


BIGTOP-3677. Building HBase for CentOS 7 on arm64 and ppc64le fails due to missing libraries.

https://issues.apache.org/jira/browse/BIGTOP-3677
[ERROR] /ws/build/hbase/rpm/BUILD/hbase-2.4.11/hbase-protocol/src/main/protobuf/Cell.proto [0:0]: /ws/build/hbase/rpm/BUILD/hbase-2.4.11/hbase-protocol/target/protoc-plugins/protoc-<IP_ADDRESS>-linux-aarch_64.exe: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /ws/build/hbase/rpm/BUILD/hbase-2.4.11/hbase-protocol/target/protoc-plugins/protoc-<IP_ADDRESS>-linux-aarch_64.exe)
/ws/build/hbase/rpm/BUILD/hbase-2.4.11/hbase-protocol/target/protoc-plugins/protoc-<IP_ADDRESS>-linux-aarch_64.exe: /lib64/libstdc++.so.6: version `CXXABI_1.3.8' not found (required by /ws/build/hbase/rpm/BUILD/hbase-2.4.11/hbase-protocol/target/protoc-plugins/protoc-<IP_ADDRESS>-linux-aarch_64.exe)
/ws/build/hbase/rpm/BUILD/hbase-2.4.11/hbase-protocol/target/protoc-plugins/protoc-<IP_ADDRESS>-linux-aarch_64.exe: /lib64/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /ws/build/hbase/rpm/BUILD/hbase-2.4.11/hbase-protocol/target/protoc-plugins/protoc-<IP_ADDRESS>-linux-aarch_64.exe)
/ws/build/hbase/rpm/BUILD/hbase-2.4.11/hbase-protocol/target/protoc-plugins/protoc-<IP_ADDRESS>-linux-aarch_64.exe: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /ws/build/hbase/rpm/BUILD/hbase-2.4.11/hbase-protocol/target/protoc-plugins/protoc-<IP_ADDRESS>-linux-aarch_64.exe)

HBASE-26470(https://github.com/apache/hbase/pull/3860) brought fork of protobuf (org.openlabtesting.protobuf) to support aarch64 but the provided protoc is not enough portable. Since we are using patched protobuf on our own, overriding the external.protobuf.groupid and external.protoc.version should be the fix.

worked for me on my CentOS 7 aarch64:
$ uname -a
Linux ip-172-33-0-128.ap-northeast-1.compute.internal 4.18.0-147.8.1.el7.aarch64 #1 SMP Wed Apr 15 18:13:44 UTC 2020 aarch64 aarch64 aarch64 GNU/Linux

$ cat /etc/os-release
NAME="CentOS Linux"
VERSION="7 (AltArch)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (AltArch)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7:server"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"

CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"

@sekikn Do you think we need the same fix for ppc64le too?

@iwasakims Yes, it also occurred on ppc64le though I missed that. Would you update the PR?
https://ci.bigtop.apache.org/view/Releases/job/Bigtop-3.1.0/1/DISTRO=centos-7,PLATFORM=ppc64le-slave/console

I added the commit for covering ppc64le. Thanks, @sekikn.

Oops. The error is related to protoc 3.17.3. We need additional fix for ppc64le.
[ERROR] PROTOC FAILED: /ws/build/hbase/rpm/BUILD/hbase-2.4.11/hbase-protocol-shaded/target/protoc-plugins/protoc-3.17.3-linux-ppcle_64.exe: /lib64/ld64.so.2: version `GLIBC_2.22' not found (required by /ws/build/hbase/rpm/BUILD/hbase-2.4.11/hbase-protocol-shaded/target/protoc-plugins/protoc-3.17.3-linux-ppcle_64.exe)

The internal.protobuf.version was 3.5.1-1 on HBase 2.2.6. It is 3.17.3 on HBase 2.4.11 (by HBASE-24168 and HBASE-26541).

Since protobuf >= 3.7 supports ppc64le, I removed the protoc-3.5.1-add-support-for-ppc64le.patch in the latest commit.

@sekikn Could you try the latest patch on ppc64le machine in CI env? I do not have testing environment.

+1, ensured the PR also works on ppc64le. Thanks @iwasakims!

Merged into master and branch-3.1.

@iwasakims I've just noticed that we had to align the protobuf version in other places too (e.g., https://ci.bigtop.apache.org/view/Releases/job/Bigtop-3.1.0/5/DISTRO=centos-7,PLATFORM=ppc64le-slave/console). I'm going to submit another PR as an addendum.


Make sure the parent directory of the target file exists

When rendering files, the filename template may hold forward slash characters, in which case Copier attempts to write a directory structure. But it doesn't ensure the directory structure exists before writing the file.
This patch fixes it.
Related to #692

Codecov Report

Merging #932 (605dafc) into master (f8ae8d6) will decrease coverage by 0.62%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
- Coverage   96.45%   95.83%   -0.62%
==========================================
  Files          41       41
  Lines        3018     3027       +9
==========================================
- Hits         2911     2901      -10
- Misses        107      126      +19

Flag
Coverage Δ

unittests
95.83% <100.00%> (-0.62%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

copier/main.py
93.65% <100.00%> (-0.77%)
:arrow_down:

tests/test_copy.py
100.00% <100.00%> (ø)

tests/test_tools.py
47.36% <0.00%> (-15.79%)
:arrow_down:

copier/tools.py
86.74% <0.00%> (-6.03%)
:arrow_down:

tests/test_vcs.py
95.31% <0.00%> (-4.69%)
:arrow_down:

tests/conftest.py
90.90% <0.00%> (-4.55%)
:arrow_down:

copier/subproject.py
95.12% <0.00%> (-2.44%)
:arrow_down:

copier/types.py
83.33% <0.00%> (-2.09%)
:arrow_down:

copier/template.py
95.79% <0.00%> (-0.47%)
:arrow_down:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add localization support for layouts

This PR adds support to localized templates by extracting all hardcoded string to i18n strings.
Also sets the html lang attribute to the current page language using {{ .Language }} as suggested by @remyleone in https://github.com/kubernetes/website/pull/13799/ > layouts/docs/baseof.html.
cc @kubernetes/sig-docs-l10n-admins @zacharysarah @remyleone

looks great.
/lgtm

@raelga Looking at the preview page in Spanish, I still see "Tell Your Story" and not "Cuéntanos tu historia".

@tengqm and @zacharysarah, thanks for the review!
About the "Tell your story", at this point is an image:
https://github.com/kubernetes/website/blob/master/static/images/case_studies/story.png
So the translation affects only to the alternative text:
<img src="https://d33wubrfki0l68.cloudfront.net/1f25fd3bb7209410ad60613770321deb5959c2e6/e2c98/images/case_studies/story.png"
alt="Cuéntanos tu historia">

Any suggestion on how to tackle localized versions of images with Hugo?

@raelga

About the "Tell your story", at this point is an image:

Oh, interesting. That's a great question.
@alexcontini 👋 Does "Tell your story" need to be an image? Is there a way to populate with text instead?

@raelga Once you address @bene2k1's comment, I think we can proceed with merging this PR. We can handle images iteratively. 👍

@bene2k1 comment fixed, thanks for spotting it. I probably commited before saving the localized version.
@zacharysarah Reviews fixed and commits squashed!

@kubernetes/sig-docs-l10n-admins
Summary
This PR includes upstream changes to the contents of i18n/en.toml and layouts/.
Impact for localization teams
These changes are non-breaking.
These changes enable localization of content that was previously hard-coded in English.

/lgtm
/approve


docs: add sentinel example

adds sentinel example support
remove unneeded apiKey variable key exposure

Failing policy output as following: https://dev.azure.com/infracost/base/_build/results?buildId=533&view=logs&j=22bcc13b-ca72-5230-7577-4f447a8fab88&t=3dc9aa31-f613-5d17-681d-5a6e831350c4

LGTM. Sorry I'd also removed the API_KEY var in my branch so this might conflict.

No problemo


Add limit to single log entries (keyed log entries)

Summary
There are some occurrences where we directly log values provided by users. Some attackers can send large data (eg. queries in the links etc.) and we end up logging them into the file and it can eat the disk space. To avoid that, I tried to add some limiting mechanism into the library.
I'm not sure whether this would be the best approach, we can review entire server code and limit the entries while calling the log function instead.
I just wanted to get an opinion from you @wiggin77 whether this looks like a "sane" approach or not. So consider this as a Draft PR to discuss.

@isacikgoz The code looks good, but if we're concerned about large log records I think we should truncate the field before it gets enqueued.  We're saving the disk space with this PR, but not memory.
If you truncate the LogRec.msg field here https://github.com/mattermost/logr/blob/45a1ed2af68b1917e520257b43ac2b809cb8c7f7/logr.go#L248 then it won't get enqueued, and won't stay in memory until each target has managed to write it out.  You can check the options struct there and not have to change all the targets.

Thanks @wiggin77 this was the perfect feedback I was looking into! I'll revisit the whole implementation and simplify.

@isacikgoz a new release will need to be made, and the go.mod updated for server.

Should I also create a new release in this repo, or would you like to do that?

Doesn't matter.  I can do it.

@isacikgoz version v2.0.17 is published.

@isacikgoz version v2.0.17 is published.

Perfect, thank you!

@isacikgoz Purely curious on whether you had considered a zero copy approach here, e.g. by simply replacing the last 3 characters of the string and returning a slice.

@isacikgoz Purely curious on whether you had considered a zero copy approach here, e.g. by simply replacing the last 3 characters of the string and returning a slice.

@streamer45  truncating the string itself wouldn't free the memory, so the intention was to let bigger string to be garbage collected by the runtime.

Thanks @isacikgoz , I wonder if doing something like slices.Clip would be useful here. My understanding is that it should help with this problem. It was also promoted to standard library in Go 1.21.

Wow, I totally missed that feature, thanks! I created a ticket for this improvement (TBA once we start using go 1.21)! Really nice feedback @streamer45 much appreciated!


Execute Minitest.after_run blocks before exiting

I'm not sure how compatible this is with different versions of minitest.  But m should definitely execute Minitest.after_run blocks.  It would be nice to run all at_exit blocks, but I think that would require changes to minitest or more invasive changes to m.

Even though the tests show as passing, they are kind of all failing because of this: https://travis-ci.org/qrush/m/jobs/80917798
I need to make this show as failure. :/
Basically, this should be extracted to the minitest runner, and have the other runners implement the same behavior if possible, or noop otherwise.

@jeremyevans Fixed in 7c36caff1cdc358a6901e4acb78a2a97c0fd6a04, if you want to take a look.

Great! Thanks for taking care of this quickly!


Closes #29. Closes #28

This PR aims at closing :

#29 with ES2015 updates according to hapi style rules
#28 dependencies updated to latest versions

Also :

update of travis target node versions

Sorry for double PR: Webstorm somehow confused me with rebases

@gergoerdosi and @arb : comments on previous PR ack, thanks for them.


mastodon: using different processes for sidekiq queues to increase scaling ?

Issue description
On https://docs.joinmastodon.org/admin/scaling/, one of the advices to scale Mastodon is the following:
The way Sidekiq works with queues, it first checks for tasks from the first queue, and
if there are none, checks the next queue. This means, if the first queue is overfilled,
the other queues will lag behind.

As a solution, it is possible to start different Sidekiq processes for the queues to ensure
truly parallel execution, by e.g. creating multiple systemd services for Sidekiq with different
arguments.

It would be nice in the mastodon nixos module if there was a setting allowing to enable this behaviour.
Tagging the maintainers @erictapen, @happy-river, @izorkin and @ghuntley

There's now a PR for this: #202408

Thanks for the heads up, closing this issue in favor of https://github.com/NixOS/nixpkgs/pull/202408 !


feat: Implement tests for app service metrics

Fix #682
Signed-off-by: Cherry Wang<EMAIL_ADDRESS>

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[ ] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[X] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Issue app-functions-sdk-go issue #1187 was created for the failed tests.


Attribute action_id missing in task actions button.

Prior to this, Slack was assinging a random 4-digit action_id that was causing the resolve and re-open buttons for a task to be a no-op.
Adding this routes the slack action to the right block_action_function (update_task_status).
Tested on my end.

Nice fix. Thank you!


Ability to customize localization

Who's this guy?
I just changed my Github username - nathanl was formerly sleeplessgeek. I have a few patches in already. :)
Though the commit is under my name, I worked on this with @adamhunter.
The changes
Pull localization behavior of localized_string into a separate class, and add configuration option to allow users to specify their own custom localizer class. The default configuration is: FormBuilder.i18n_localizer = Formtastic::Localizer
All tests are green, though I would love to have some other eyes on this to see if we missed anything (maybe there are gaps in the test coverage?), since this is a biggish change. In particular, we've only used it on forms for models.
Also updated documentation and generator to reflect this change.
Why?
We needed this for our own use - see my Gist here: https://gist.github.com/23184d8536f22bb2a8d3
However, this is also a step towards answering the concern in this ticket: https://github.com/justinfrench/formtastic/issues/445
Namely, if you want to change the way Formtastic does localization, but maintain backwards compatibility, you could:

Rename Formtastic::Localizer to something like Formtastic::LegacyLocalizer
Create a new Formtastic::Localizer with the desired behavior
Default to the legacy localizer so people upgrading aren't affected, but for new projects, generate a configuration that points to the new one.

For that matter, you could provide as many localization classes as you like out of the box and let people pick the one they like best.
Thoughts? Attaboys? Howls of derisive laughter?

This is awesome! While you're looking for +1s on the functionality, it'd be great if you could do a few documentation tweaks:

pull the documentation out of the README, it's already too full of edge case stuff
shift the documentation on localize() up to the Localizer class level for YARD
thin out the documentation in the initializer template
basically make sure localizer.rb contains enough information for implementors, with of much of it there in one place

Also consider if this would be a good time for a class-specific unit test for Localizer, rather than the integration-style tests scattered elsewhere. I need to do heaps of work on this, but having this come in the right way will help Future Me™ a lot!

I'd be happy to do the documentation tweaks - will get that done as soon as I can.
I don't think I'll have time (for a while) to add class-specific tests for Localizer, but @adamhunter and I have discussed that we'd like to do that and refactor it; just not sure when yet. If anybody wants to give us a leg up, they could just write dummy pending tests on it: "it should" statements with no blocks. This would help us understand everything the method is supposed to do so we don't break any edge cases.

@nathanl documentation is a great start, let me know when it's ready to merge!

@justinfrench - sorry I didn't get back to this yet; just a bit too busy. Thanks for pulling in this commit.


[Unfinished] Remove ReactiveSwift from Change Email View

📲 What
A working change email view replacing ReactiveSwift with Combine.
🤔 Why
🛠 How
...tbd...
👀 See
...coming.

Before 🐛
After 🦋

✅ Acceptance criteria

[ ] All the functionality is preserved on this page.
[ ] Use should be able to change email, send verification message, see new email when re-entering page.

⏰ TODO

[x] Networking
[ ] Refactor business logic
[ ] Write tests

SwiftFormat found issues:

File
Rules

KsApi/GraphMutation.swift:1:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/GraphMutation.swift:2:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/GraphMutation.swift:25:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/GraphMutation.swift:26:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/GraphMutation.swift:27:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/GraphMutation.swift:28:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/GraphMutation.swift:30:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/GraphMutation.swift:31:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/GraphMutation.swift:32:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/Service.swift:1:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/Service.swift:2:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/Service.swift:3:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/Service.swift:4:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/Service.swift:5:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/Service.swift:6:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/Service.swift:7:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/Service.swift:136:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/Service.swift:348:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/Service.swift:350:1
warning: (todos) Use correct formatting for TODO:, MARK: or FIXME: comments.

KsApi/Service.swift:351:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/Service.swift:679:1
warning: (wrap) Wrap lines that exceed the specified maximum width.

KsApi/ServiceType.swift:1:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/ServiceType.swift:2:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/ServiceType.swift:3:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/ServiceType.swift:62:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/ServiceType.swift:171:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/ServiceType.swift:330:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/extensions/ApolloClient+RAC.swift:1:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/extensions/ApolloClient+RAC.swift:2:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/extensions/ApolloClient+RAC.swift:3:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/extensions/ApolloClient+RAC.swift:4:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/extensions/ApolloClient+RAC.swift:36:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/extensions/ApolloClient+RAC.swift:47:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/extensions/ApolloClient+RAC.swift:53:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/extensions/ApolloClient+RAC.swift:56:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/extensions/ApolloClient+RAC.swift:59:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/extensions/ApolloClient+RAC.swift:62:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/extensions/ApolloClient+RAC.swift:70:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/extensions/ApolloClient+RAC.swift:103:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/extensions/ApolloClient+RAC.swift:116:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/extensions/ApolloClient+RAC.swift:122:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/extensions/ApolloClient+RAC.swift:127:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/extensions/ApolloClient+RAC.swift:130:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/extensions/ApolloClient+RAC.swift:138:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:1:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/models/UserEnvelope.swift:2:1
warning: (sortedImports) Sort import statements alphabetically.

KsApi/models/UserEnvelope.swift:14:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:15:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:16:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:17:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:18:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:19:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:20:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:21:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:22:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:23:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:24:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:25:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:26:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:27:1
warning: (indent) Indent code in accordance with the scope level.

KsApi/models/UserEnvelope.swift:29:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:1:1
warning: (sortedImports) Sort import statements alphabetically.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:2:1
warning: (sortedImports) Sort import statements alphabetically.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:3:1
warning: (sortedImports) Sort import statements alphabetically.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:4:1
warning: (sortedImports) Sort import statements alphabetically.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:5:1
warning: (sortedImports) Sort import statements alphabetically.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:9:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:15:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:36:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:43:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:43:1
warning: (todos) Use correct formatting for TODO:, MARK: or FIXME: comments.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:48:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:54:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:54:1
warning: (todos) Use correct formatting for TODO:, MARK: or FIXME: comments.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:59:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:65:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:71:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:75:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:76:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:77:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:82:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:88:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:98:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:106:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:115:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:120:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:123:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:124:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:124:1
warning: (wrap) Wrap lines that exceed the specified maximum width.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:125:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:126:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:127:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:209:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:228:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:235:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:251:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:261:1
warning: (indent) Indent code in accordance with the scope level.

Library/ViewModels/ChangeEmailViewModelSwiftUIIntegrationTest.swift:265:1
warning: (indent) Indent code in accordance with the scope level.

  Generated by :no_entry_sign: Danger

@scottkicks @ifosli Hey, so I was wrapping this up on Friday - but I think IT locked my laptop at 5pm. You all will have to work with this PR as is I think. Functionality is the same as the previous ReactiveSwift page, but testing is missing.
My biggest resource through this process was this book https://practicalcombine.com/
I'm not sure how long I have org access on github so I may not be able to complete the work on my personal laptop.
Feel free to ping me on github about completing the testing or anything else you need. @msadoon


fix: seed issue when event config has not all keys

Event configurator fails when event has no all default rules

Fixed by #236


Vanguard's effect on the farsight module

With the announcement of Vanguard coming to League I have my doubts about the relative safety of using the farsight module in the spectator mode of custom / tournament code games. Does anyone know if Riot's angle will remain the same about no anti-cheat during spectating?

Riot have not yet released any statement changing their stance on memory reading, though I would welcome any update from Riot through any channel.
From rumors and what I have been able to piece together, it is highly unlikely Farsight will continue working once 14.4 drops, which is the patch where Vanguard is expected to replace the current anti cheat.
Offsets will most likely not get updated to patch 14.4.
The repository will stay online and a warning will be added.

Understandable, thanks for the reply.
RIP🕯


Exception when trying to run radar

When I start debugging 'EftRadar' I am getting the following exception: Exception thrown at 0x0000000000000000 in EftRadar.exe: 0xC0000005: Access violation executing location.
The following line in gltext.h is throwing the exception:
vertexShader = glCreateShader(GL_VERTEX_SHADER);
Is there anything I can do to fix this?

It is failing to create the shader, which probably means that your machine cannot handle OpenGL 3.3. Check stdout as there may be shader creation errors.


Allow for generic post container name

Fixes #4

Hey thanks for this, there was a weird error with the build (Zola doesn't default to theme.toml :thinking:) so I just added some other checks. One thing to note is I changed blog_container to blog_name.

No problem, thanks!


changed our people to advisors and ts

not sure if I should change the folder names for the imgs too?

Sure, change folder name of images for consistency.

not sure if I should change the folder names for the imgs too?

Yes change the folder name of images too


change isShellBuiltin

change isShellBuiltin to have each builtin as a different token in a list and lookup cmd to be an element of the list instead of a sequence of characters in a string (tested only on Python 3.6.7).

I'm OK with this, but probably the right thing to do is something like:
builtins = set(quietRun('bash -c enable').split())

changed, see pull request #872.


Fix facets clear button not showing on mobile

Questions
Answers

Description?
The clear button was never shown on mobile

Type?
bug fix

BC breaks?
yes

Deprecations?
no

Fixed ticket?
Fixes https://github.com/PrestaShop/PrestaShop/issues/28677.

How to test?
Go to category page, verify that the clear button of facetedsearch is working as expected on both mobile and desktop (The buttons has been moved to another place, we're pretty forced to do this, it's not inside the card of mobile facetedsearch instead of outside)

Possible impacts?
Facetedsearch responsive

BC Break
As we move some code from one file to a new override, it's obviously a BC for past themes.
Also, this is probably not the best solution, but it's actually the best in order to keep compatibility without rebuilding the module... Facetedsearch would require a small refactor in order to do this in a cleaner way, but it would introduce a lot of changes that themes would need to handle

@NeOMakinG n @Oksydan I clarified the hidden code and suggested a lighter solution at https://github.com/PrestaShop/ps_facetedsearch/pull/690

Closing as anyway, we will start on another branch if needed and @leemyongpakvn provided something more interesting atm


recipes-bsp/bootbin/xilinx-bootbin_1.0.bb fails to generate deps

Dropping the  + ":do_deploy" from old line 76 in commit a622db9 seems to have broken this recipe. It now produces the following error:

ERROR: Error for /home/ubuntu/git/yocto/poky/build/../../meta-xilinx-tools/recipes-bsp/bootbin/xilinx-bootbin_1.0.bb:do_configure[depends], dependency virtual/fsbl in '  virtual/fsbl virtual/fsbl virtual/fsbl virtual/fsbl virtual/fsbl virtual/bitstream virtual/pmu-firmware virtual/arm-trusted-firmware virtual/bootloader virtual/kernel virtual/dtb' does not contain exactly one ':' character.
Task 'depends' should be specified in the form 'packagename:task'
ERROR: Command execution failed: Exited with 1

i think this is fixed in recent release, please confirm

Not sure which release you were referring to, but I just tried it with 2019.2 and have the same issue. Adding back the do_deploy that I mentioned previously fixes the issue.


Improvement of ignoring setting synchronization

I propose the following improvements for the settings sync feature.

Do not sync settingsSync.ignoredExtensions and settingsSync.ignoredSettings
These settings indicate that they are specific extensions and settings for a machine, and there is no point in syncing them to other machines.

Automatically do not sync settings related to extensions that are not synced.
I would like the settings for extensions that are configured to be ignored by settingsSync.ignoredExtensions to be automatically merged into settingsSync.ignoredSettings.

Do not sync settingsSync.ignoredExtensions and settingsSync.ignoredSettings
These settings indicate that they are specific extensions and settings for a machine, and there is no point in syncing them to other machines.

You can already do that by ignoring these two settings to sync?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Fix SD length calculation when resampling

Description of changes:

Rename StreamingDataset.choose to StreamingDataset.epoch_size
Fix bug in length calculation to use resampled epoch size, not underlying num samples

Issue #, if available:

Merge Checklist:
Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[ ] I have read the contributor guidelines
[ ] This is a documentation change or typo fix. If so, skip the rest of this checklist.
[ ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
[ ] I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

[ ] I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate).
[ ] I ran the tests locally to make sure it pass. (check out testing)
[ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

Overall looks good. One minor question, do we need to also change the def size() implementation ?

Do we also need to modify choose to epoch_size in stream.py file?

Do we also need to modify choose to epoch_size in stream.py file?

I was thinking that we keep Stream proportion/repeat/choose as is, but that choose is not clear what it does at the StreamingDataset level since it's only used when you have proportionally weighted strearms

Overall looks good. One minor question, do we need to also change the def size() implementation ?

The size property is for random access so is in terms of underlying samples so we're good


Update the README a bit and update the docker files for build. And ad…

…d scripts

 gatsby-boilerplate: Add Docker info to README


where do i get the value for zone_id? Error: NoSuchHostedZone: No hosted zone found with ID: Z2ES8B9AZ6SHAE

Is your request related to a new offering from AWS?
Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

No 🛑: please wait to file a request until the functionality is avaialble in the AWS provider
Yes ✅: please list the AWS provider version which introduced this functionality

Is your request related to a problem? Please describe.

Describe the solution you'd like.

Describe alternatives you've considered.

Additional context

You can use aws_route53_zone data source, for example. See example code.


aliased requests in resolver_context.file_dependencies are not normalized/canonicalized

oxc_resolver: 1.2.0-1.3.0
os: Windows

Summary
let root = dir().join("fixtures\\enhanced_resolve\\test\\fixtures");
let mut ctx = ResolveContext::default();

let resolver = Resolver::new(ResolveOptions {
    alias: vec![(
        "@".into(),
        vec![AliasValue::Path(root.join("alias").to_string_lossy().into())],
    )],
    ..ResolveOptions::default()
});
let _ = resolver.resolve_with_context(root, "@/files/a", &mut ctx);

for d in ctx.file_dependencies.iter() {
    println!("{}", d.to_string_lossy());
}

Expected
C:\Users\imkf\Developer\oxc-resolver\fixtures\enhanced_resolve\test\fixtures\alias\files\a.js seen in output,
Actual
C:\Users\imkf\Developer\oxc-resolver\fixtures\enhanced_resolve\test\fixtures\alias/files/a.js got
Related
web-infra-dev/rspack#5445

https://github.com/oxc-project/oxc-resolver/blob/9da91715399764b07a62324a5d03579f373986f6/src/lib.rs#L897
I don't know how to fix this ... I'll check with enhanced_resolved tomorrow.

thank you


well-formed can detect obvious conflicts

It is smart enough to detect conflicts between continuous assignments and group assignments.

@EclecticGriffin  the interp tests need to probably use a guard to not be caught by the pass


support AD FS as idp

When adding AD FS support for ocis we had to customize some of the charts. I'll put the diffs here for documentation, as well as a checklist of things to productize for AD FS support. AFAICT we only really need to make skipping the userinfo endpoint in web configurable and maybe @d7oc can enlighten me on diff no 3.

I was using an ocis version that used SSE, but no sse service was started, yet so I disabled it:

diff --git a/charts/ocis/templates/frontend/deployment.yaml b/charts/ocis/templates/frontend/deployment.yaml
index 88e648f..5dc9639 100644
--- a/charts/ocis/templates/frontend/deployment.yaml
+++ b/charts/ocis/templates/frontend/deployment.yaml
@@ -92,6 +92,9 @@ spec:
             - name: OCIS_EDITION
               value: {{ .Values.features.edition | quote }}

+            - name: OCIS_DISABLE_SSE
+              value: "true"
+
             - name: FRONTEND_MACHINE_AUTH_API_KEY
               valueFrom:
                 secretKeyRef:
diff --git a/charts/ocis/templates/userlog/deployment.yaml b/charts/ocis/templates/userlog/deployment.yaml
index 29e08cf..4fb4e71 100644
--- a/charts/ocis/templates/userlog/deployment.yaml
+++ b/charts/ocis/templates/userlog/deployment.yaml
@@ -44,6 +44,9 @@ spec:
             - name: USERLOG_DEBUG_PPROF
               value: {{ .Values.debug.profiling | quote }}

+            - name: OCIS_DISABLE_SSE
+              value: "true"
+
             - name: USERLOG_HTTP_ADDR
               value: <IP_ADDRESS>:8080

[x] nothing to do here, more recent charts start an sse service

For AD FS the proxy and web ui must skip calling the userinfo endpoint and read the claims from the access token:

diff --git a/charts/ocis/templates/proxy/deployment.yaml b/charts/ocis/templates/proxy/deployment.yaml
index 1a1bcb5..ede864e 100644
--- a/charts/ocis/templates/proxy/deployment.yaml
+++ b/charts/ocis/templates/proxy/deployment.yaml
@@ -57,6 +57,9 @@ spec:
               value: {{ .Values.features.externalUserManagement.oidc.issuerURI | quote }}
             {{- end }}

+            - name: PROXY_OIDC_SKIP_USER_INFO
+              value: "true"
+
             {{- if .Values.features.externalUserManagement.enabled }}
             - name: PROXY_OIDC_REWRITE_WELLKNOWN
               value: "true"
diff --git a/charts/ocis/templates/web/config.yaml b/charts/ocis/templates/web/config.yaml
index 1cb848c..63f6e6b 100644
--- a/charts/ocis/templates/web/config.yaml
+++ b/charts/ocis/templates/web/config.yaml
@@ -55,3 +55,60 @@ data:
           previewFileMimeTypes:
             {{- toYaml . | nindent 12 }}
           {{- end }}
+  config.json: >-
+    {
+      "server": "https://cloud.ocis.test",
+      "theme": "https://cloud.ocis.test/themes/owncloud/theme.json",
+      "openIdConnect": {
+          "metadata_url": "https://idp.ocis.test/adfs/.well-known/openid-configuration",
+          "authority": "https://idp.ocis.test/adfs",
+          "client_id": "https://cloud.ocis.test/",
+          "response_type": "code",
+          "scope": "openid profile email",
+          "loadUserInfo": false
+      },
+      "apps": [
+          "files",
+          "search",
+          "text-editor",
+          "pdf-viewer",
+          "external",
+          "admin-settings"
+      ],
+      "external_apps": [
+          {
+              "id": "preview",
+              "path": "web-app-preview",
+              "config": {
+                  "mimeTypes": [
+                      "image/tiff",
+                      "image/bmp",
+                      "image/x-ms-bmp"
+                  ]
+              }
+          }
+      ],
+      "options": {
+          "previewFileMimeTypes": [
+              "image/gif",
+              "image/png",
+              "image/jpeg",
+              "text/plain",
+              "image/tiff",
+              "image/bmp",
+              "image/x-ms-bmp"
+          ],
+          "sharingRecipientsPerPage": 200,
+          "sidebar": {
+              "shares": {
+                  "showAllOnLoad": false
+              }
+          },
+          "routing": {
+              "idBased": true
+          },
+          "contextHelpersReadMore": true,
+          "openLinksWithDefaultApp": true,
+          "tokenStorageLocal": true
+      }
+    }
diff --git a/charts/ocis/templates/web/deployment.yaml b/charts/ocis/templates/web/deployment.yaml
index 258a5f2..4ad1ab5 100644
--- a/charts/ocis/templates/web/deployment.yaml
+++ b/charts/ocis/templates/web/deployment.yaml
@@ -71,6 +71,9 @@ spec:
             - name: WEB_UI_CONFIG_SERVER
               value: "https://{{ .Values.externalDomain }}"

+            - name: WEB_UI_CONFIG_FILE
+              value: /etc/ocis/config.json
+
             - name: WEB_OPTION_CONTEXTHELPERS_READ_MORE
               value: {{ .Values.services.web.config.contextHelpersReadMore.enabled | quote }}

[ ] needs to be added to the external user management section in the values.yaml ... either as a transparent option or behind a feature flag? And then the question is how we make configuring the web ui less painful. Putting this huge config.json in the config.yaml is the only way for now, but maybe the web ui can always skip that endpoint? or we add a config option that adds the "loadUserInfo": false setting, which is the only difference to the stock config. I prefer the latter and submitted the ocis change in https://github.com/owncloud/ocis/pull/7714

not sure about this one. the openshift cluster is sitting behind load balancers:

diff --git a/charts/ocis/templates/proxy/ingress.yaml b/charts/ocis/templates/proxy/ingress.yaml
index acf1ebd..76fb103 100644
--- a/charts/ocis/templates/proxy/ingress.yaml
+++ b/charts/ocis/templates/proxy/ingress.yaml
@@ -22,7 +22,7 @@ spec:
 {{- end }}
   rules:
     - host: "{{ .Values.externalDomain }}"
-      https:
+      http:
         paths:
           - path: /
             pathType: Prefix

[ ] clarify if this even has an effect

search did not work and I because of the older ocis version I tried to set the jwt secret

diff --git a/charts/ocis/templates/search/deployment.yaml b/charts/ocis/templates/search/deployment.yaml
index 5bdd934..7a4ce7a 100644
--- a/charts/ocis/templates/search/deployment.yaml
+++ b/charts/ocis/templates/search/deployment.yaml
@@ -84,6 +84,12 @@ spec:
             - name: SEARCH_EXTRACTOR_CS3SOURCE_INSECURE
               value: {{ .Values.insecure.ocisHttpApiInsecure | quote }}

+            - name: SEARCH_JWT_SECRET
+              valueFrom:
+                secretKeyRef:
+                  name: {{ include "secrets.jwtSecret" . }}
+                  key: jwt-secret
+
             - name: SEARCH_MACHINE_AUTH_API_KEY
               valueFrom:
                 secretKeyRef:

[x] nothing to do here, because the current charts will start the now needed auth-service pod that is now used by the search service for service accounts

this was also a env var mismatch because of the older ocis version

diff --git a/charts/ocis/templates/users/deployment.yaml b/charts/ocis/templates/users/deployment.yaml
index 86b86c6..32addcb 100644
--- a/charts/ocis/templates/users/deployment.yaml
+++ b/charts/ocis/templates/users/deployment.yaml
@@ -74,6 +74,9 @@ spec:
             - name: USERS_LDAP_GROUP_OBJECTCLASS
               value: {{ .Values.features.externalUserManagement.ldap.group.objectClass | quote }}

+            - name: OCIS_LDAP_USER_SCHEMA_ID
+              value: {{ .Values.features.externalUserManagement.ldap.user.schema.id | quote }}
+
             - name: USERS_LDAP_USER_SCHEMA_ID
               value: {{ .Values.features.externalUserManagement.ldap.user.schema.id | quote }}
             - name: USERS_LDAP_GROUP_SCHEMA_ID

[x] nothing to do here, will just work with the most recent charts

Adding the web config.json option would make lots of other configuration options dependent on this particular option not to be set.
Exposing the configuration introduced in https://github.com/owncloud/ocis/pull/7714 is probably the easier and cleaner option in this case.

Regarding http / https in the ingress: from what I know only http is valid.
Also the chart uses http, where does your diff come from?
https://github.com/owncloud/ocis-charts/blob/ad0bcb0ffe4fdec22c5644d09cfe6b9af021e312/charts/ocis/templates/proxy/ingress.yaml#L25

Regarding http / https in the ingress: from what I know only http is valid.
Also the chart uses http, where does your diff come from?
https://github.com/owncloud/ocis-charts/blob/ad0bcb0ffe4fdec22c5644d09cfe6b9af021e312/charts/ocis/templates/proxy/ingress.yaml#L25

we did that in openstack ... but this is my impression as well. only http should be valid as per https://kubernetes.io/docs/concepts/services-networking/ingress/#the-ingress-resource

we did that in openstack ...

you did use http or https for OpenShift? Because the Chart only uses http but your diff displays a change from https to http...

@butonic Did you experience any CORS errors when using ADFS?

I've added url to allow_origins but still recieves the error message when accesing ocis.

@butonic
Hi!
We are experiencing the same issue when configuring ADFS.
When modifying "charts/ocis/templates/web/config.yaml" with the json config, the web pod fails to start with the following error message.
2024-03-05T19:14:54Z ERR error opening config file error="open /etc/ocis/config.json: no such file or directory" service=web open /etc/ocis/config.json: no such file or directory
Did I miss something? :)

May I ask for an update on that one?

I tried this but was unable to get it working.

May I ask for an update on that one @butonic @d7oc @wkloucek ?

I don't have any information, are not working on it and even if I'd be assigned on it, I have no way to test it.

Maybe a "dumb question". Is it only about this: ??
+            - name: PROXY_OIDC_SKIP_USER_INFO
+              value: "true"

closing here because there was no response within 6 months


When trying to train a Multimodal predictor for object detection following the quick start example, if my dataset has images that are background only negatives with no class, then if I put in [] or None or pd.NA etc in the dataframe (using a pandas DataFrame as input) I get an error in the data pre-processing. If however, I use the COCO format, then those images seem to be getting ignored entirely.
Ideally those images should be processed as part of the training data as negative examples.

Workaround: add a 'background' class and boxes for it spanning nearly the whole image. Not a great solution but does improve metrics.


Bind RMI server to public IP instead of hostname

Previously, it would just bind to the hostname and you couldn't establish a remote JMX connection if you don't have the proper name resolution configured. The easy fix is to always bind the RMI server to the host's public IP address.
@aboudreault / @EnigmaCurry can you guys review please?

I would argue that if you 'don't have the proper name resolution configured' you should just be using an IP address for hostname in the cluster_config.
By calling gethostbyname you're assuming that the client is on the same network as the nodes. If that's the case, why not just use the internal_ip listed in the cluster_config? I'm more partial to using the explicit config in cluster_config than doing auto-determination of IPs.

Oh right I forgot that we actually have the IP addresses specified in cluster_config.json. I will change the logic to read the IP from that file. Thanks for the hint

@EnigmaCurry please re-review

lgtm. Thanks!


Core Icons outdated

core-icons removed all the post-* as they rebased against the open source set from Google.
https://github.com/meteor-useraccounts/polymer/blob/master/lib/at_social.html#L3
http://stackoverflow.com/questions/28153341/were-post-icons-remove-in-core-icons-social-icons-html
https://github.com/Polymer/core-icons/commit/1e94a1175f7b97cb58ef54ecd5ca07c04053bc92#diff-8ea02ad880d928a495d723bd3c6d9978L39
:(

you are absolutely right @RobertLowe ! I had not catched that at all!
Do you have a suggestion on what we should do ?

Any news on this?

ping

These icons are no longer used as of #10

should we close this then?

Yeah it should be closed. There is still a problem with icons, but it's a different problem which might have been fixed when PolymerElements/iron-icons#18 was closed, but I need to check.

thanks guys


3642: Other ways to access service page

routes.rb includes other-ways-to-access-service-cy to ensure ZDD compliance
when we get to releasing the localized version in a later release.
@oswaldquek

👍


Check that all i18n messages are used in the interface, in the CI

Is your feature request related to a problem or area of OpenRefine? Please describe.
It would be nice if the CI could check that all messages ids stored in the translations are actually used in the interface. When changing a part of the UI, it is easy to forget to remove any unused messages. Having this check in place would ensure translators are not wasting their efforts on messages that are never shown.
The script could also check for duplicate message ids in the translation files (#2668).
Describe the solution you'd like
A basic prototype for this would just search for each message id in the JS source. There might be cases where we are dynamically constructing the message id, in which case this would falsely report that the message is not used. This could be fixed by adding as a comment all the possible values of the constructed message ids.
Describe alternatives you've considered
There might be off-the-shelf tooling for this.
Additional context

Is this the only source path to conduct that search? or other paths as well?
/main/webapp/modules/core/scripts

Is it also the case of keeping keys in sync across languages?  Such as this library for i18next : https://www.npmjs.com/package/i18next-json-sync

For the main module the path above looks appropriate (although I haven't checked), but we should also do this for extensions.
Keeping keys in sync across languages is done by Weblate directly.

Something like this could be used as a starting point:
find main/webapp/modules/core/scripts -name '*.js' -exec grep -E -o \\\$\\\.i18n\\\(\\\'\(\[\^\\\'\]\+\?\)\\\' {} \; | cut -f 2 -d '(' | sort | uniq -c | sort -r -n | head

Remove one level of escaping for non-shell use (e.g. Python). The regex has a capture group for the key, but the grep utility doesn't support capture groups.

Hello @wetneb @antoine2711 @tfmorris @thadguidry
About this issue. If I understand correctly you wish to write a test that ensures that all the keys used for localization are actually being used?

The script could also check for duplicate message ids in the translation files

I was wondering if this could be implemented in java so that a test is run whenever the Refine.java class is run? Or do you wish to implement tests which run when the application is deployed?

If I understand correctly you wish to write a test that ensures that all the keys used for localization are actually being used?

Yes! If that could be part of the CI, it would be nice.

I was wondering if this could be implemented in java so that a test is run whenever the Refine.java class is run?

Rather not: this is a check we should do while developing, not running the application.

@wetneb But I think we having any "check"'s be implemented in whatever language works, right?  Then the CI could be modified to use a GitHub Action to launch the check, which could very well just be a java -jar checkI18N.java command?


Reformat how credit information is presented on works page

What?
Credit information on the works page is currently confusing and potentially misleading.

These should be formatted as: {Title}. {Credit}. {Licence label}. Source: {Attribution}. - NOTE: not everything has an explicit {Credit}. Devs need to decide from where to grab this data.
We should offer the option to Copy the credit line (similar to copyURL)
When copying the credit line, the URL for the works page should be included.

To illustrate:
On works page:

Genetics in the 20th century : essays on the progress of genetics during its first 50 years / edited for the Genetics Society of America by L.C. Dunn. Public Domain Mark. Source: Wellcome Collection.

When copied:

Genetics in the 20th century : essays on the progress of genetics during its first 50 years / edited for the Genetics Society of America by L.C. Dunn. Public Domain Mark. Source: Wellcome Collection. https://wellcomecollection.org/works/pe22d89x

Dependencies
Bug https://github.com/wellcomecollection/wellcomecollection.org/issues/10221
Why?
To ensure that all users have the most accurate information we can give, so they can provide credit appropriately
Background
Reworked licence and credit information https://docs.google.com/document/d/1haxvwYphd5dF3dplmTmyN7H5vn7ovJohbi0RHU6AmD0/edit?usp=sharing

To confirm: we were removing the URL on the Licence label, is that correct?

Yes, and that's because we've got the licence link in the humanReadableText so no need to duplicate it

Another question: I might misunderstand what is Credit and what is Attribution. Currently in this work, what I have for Credit is "Wellcome Collection".
  // iiif-image locations have credit info.
  // iiif-presentation locations don't have credit info., so we fall back to the data in the manifest
  const credit = digitalLocation?.credit || iiifCredit;

In your example, that looks like it's "Attribution". What would the difference be and where should I place this information?

In the current Copy URL component there is a GA event tracking clicks:
 trackGaEvent({
       category: 'CopyURL',
       action: 'copy url to clipboard',
       label: id,
     });

As I have to modify it/create a new component for copying regular copy, do we want to add tracking there as well?
cc @taceybadgerbrook

@jennpb @rcantin-w, references in the code to GA event category, action and label were used by UA and are now obsolete.
However, there is an event called, "copy_url," tracks when a user clicks this

This is triggered when CSS selector matches [data-gtm-trigger="copy_url"], [data-gtm-trigger="copy_url"] * .
I would love to be able to track when a user copies the credit information. If you let me know what the CSS selector is, I can do the tagging in GTM.

After a conversation with Ashley, Jamie and Jenn where we determined that credit vs attribution was a bit more complicated to untangle than we'd like, we're putting this under a toggle for now so we can compare various works and images more easily.

We are unable to create an ideal credit line as intended.

For third party material, the attribution and usage label includes the location-of-original data rather than the attributable source; this means we get text that says "This material has been provided by The Royal College of Surgeons of England. The original may be consulted at The Royal College of Surgeons of England."
However, material that we've digitised says 'Wellcome Collection'.
Credits aren't reliably available.

When presenting a credit line, we should be able to reliably include:

{title}
{credit} - this information is not consistently available. Currently Miro images that have not been reingested are the only digital assets that include an explicit credit line.
{source} - where source is Wellcome Collection, as that's where the digital item was found
{licence}

So I moved Licence to end of the sentence, it's the only change I can see from our current instance.
Credit displays if there is a IIIF Presentation or IIIF Image credit field.
Attribution displays if there is an "Attribution and usage" label on a IIIF Presentation.
Should we now remove the "Licence" section above "Licence and re-use"?

If we're happy with this, I'll of course remove the section names.

Credit displays if there is a IIIF Presentation or IIIF Image credit field.

Yes, but if there's a credit, it should not be part of Source:
I would expect this example to be formatted as:
DNA analysis. Paul Griggs. Source: Wellcome Collection. Attribution 4.0 International (CC BY 4.0).

Should we now remove the "Licence" section above "Licence and re-use"?

Yes

@jennpb the discussed changes are in prod: https://wellcomecollection.org/works/a227dajt

For the record, this was implemented as:
{Title}. {Credit}. Source: Wellcome Collection. {Licence label}
AND when item is from a third party, a separate section for Provider which is taken from Attribution and usage

@rcantin-w This is fine to remove from toggle! 🛳

In prod, from behind the toggle


Implement Instruction for *Box wrappers

Currently, only InstructionBox implements Instruction out of all ISI wrappers. I expected RegisterBox, MintBox and the rest of the wrappers to be usable with iroha.submit_*() directly, but they are not. I think it would be more ergonomic if they were.

Additionally, change instances of impl IntoIterator<Item = impl Instruction> function parameters to impl IntoIterator<Item = I>, I: Instruction, which is more flexible due to the turbofish syntax being available. This would allow wrapping multiple instructions into *Boxes without binding them to a separate variable.


Find a rich text editor for notes feature

Find rich text editor to replace old one
Try - https://www.npmjs.com/package/react-native-pell-rich-editor

Testing is done and the rich text editor for notes is working as expected. Thus moving this issue to done.


page not responding

Hi there,
ive done all processes but blocked before logging into the site.
when i put in my digital twin root url + tenant id + client id, there is no response from the site, 'sign in' icon does not work.
any help is appreciated.

WEB: https://tomzstar.azurewebsites.net

@yzll111: could this be related to #10?  (Can you check the url you put in has a trailing slash?)

@yzll111 Did Fernando's suggestion solve the issue or are you still experiencing problems?


Document upgrade and downgrade processes

Hi.
After reading the documentation it is not clear for me, how upgrade and downgrade processes should be performed over the database. Could you please describe somewhere in the documentation:

How to upgrade the database to the newer version (hopefully with no downtime)
How to downgrade the database to the older version (hopefully with no downtime)
Maybe some compatibility policies and notes between versions

Thanks in advance!

Glad you are interested 😃
Nodes cannot be added or removed "dynamically" in the present version -- you need to replace and restart the entire cluster for upgrading or downgrading. Or in other words, we simply do not support changing versions so we didn't document it.
But this is definitely a key feature, we plan to ship it in the next one or two small milestones (v0.4 or v0.5). This is in the design (in mind) stage, @ShiKaiWi may lay out an RFC about how will CeresDB achieve the cluster mode. Graceful upgrade/downgrade should be included.
And for compatibility, we will do our best to keep backward compatibility in the storage format, and will obey the Semantic Versioning across all interfaces. If any breaking change is made it will be documented in the version note.
Hope that helps ❤

@waynexia Thank you! Could you please put this information somewhere into the documentation?

Sure! Sorry for the late reply, I'll document it this morning


[Spanish] localize 'Continuous Delivery (CD)'

Localize the content/en/continuous_delivery.md document to Spanish

I would like to work on this one @electrocucaracha

/close by https://github.com/cncf/glossary/pull/1280

I can not close this issue. Could you close it @electrocucaracha, please?


Week 5 draft

Component
Passed Tests
Total Tests
Points Available
Points Received

All tests, as originally given, are passing.
57
57
80
80

Clear, organized project structure

20
20

Total

100
100


Feature Request: Custom PDF without modifying the source code

Is it possible to add a customPDF without modifying the source code of IMPaCT? For context, I try to run an example with a custom PDF using the docker image and thus I have three options: move the file with customPDF into the source to override custom.cpp, copy it into the same path, or link directly from the example.
If I copy or link it, then I getting a linker error since the function will be doubly defined.
If I instead move it, since I need to mount the examples folder to the host machine to access the results, then I will also remove the file from the host machine.
Do you have a proposal to solve this issue?

Thanks for the speedy reply, Ben! The use case is indeed a large suit of tests that I am running as part of a comparison :-)
I think a shell script to modify IMDP.cpp to remove #include "custom.cpp" (and instead include extern customPDF`?) would be a good temporary option.
For improving the interface of the toolbox, my opinion is that the better option is to include a second parameter when selecting NoiseType::CUSTOM. This way the toolbox is a self-contained and requires no modification :-)


Feature request: Kerberos authentication

Hi
Would be cool to have Kerberos authentication support.

Could you provide a PR?

No, for me the existing code is not really straightforward. It mostly assumes that setting SASL authentication only provides LDAP as a mechanism. The conditionals around that and the various configuration points/settings makes it really tedious. I think the code needs some refactoring to allow any mechanism to be swiftly implemented.

I forked, Kerberos is provided in the realm of LDAP. During setup, hostname and domain name needs be a match to achiece expected behavior.

@djoq can you provide a PR for this feature?

Since the tests are failing @johansmitsnl, maybe we leave this the way it was. There exists issues discussing how this is more of a preference than a bug. It fixed the bug for my case, but as others has mentioned, this does require that unique email prefixes be set and causes conflicts in multi-domain/ email prefix uniqueness. Out of curiousity, which critic tests are failing?

@djoq I did not mention that tests are failing. What do you mean?

I believe you did.
https://github.com/tomav/docker-mailserver/pull/1036
On Fri, Sep 21, 2018 at 1:42 PM Johan Smits<EMAIL_ADDRESS>wrote:

@djoq https://github.com/djoq I did not mention that tests are failing.
What do you mean?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tomav/docker-mailserver/issues/1021#issuecomment-423617757,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGU7u8nzFCXz2qeqG3YfIJ6wqhWbZ5iIks5udSUIgaJpZM4WCdxZ
.

--
Daniel O'Quinn
BS Mechanical Engineering
University of Massachusetts Amherst
<EMAIL_ADDRESS><EMAIL_ADDRESS>617-571-7257 (cell)

This issue was closed due to one or more of the following reasons:

Age
Contributor inactivity
The issue seems to be resolved

If you think this happened by accident, or feel like this issue was not actually resolved, please feel free to re-open it. If there is an issue you could resolve in the meantime, please open a PR based on the current master branch so we can review it.


v8.0.0 is not published to NPM/Yarn

Hello and thank you for the hard work! I noticed you released 8.0.0 several days ago, but I don't see it on NPM/Yarn.
https://www.npmjs.com/package/react-jss
https://yarnpkg.com/en/package/react-jss
Figured I'd open an issue in case it was an accidental oversight. If not, ignore! 👍

i have only merged to master, it i s not released.

what is the plan about publishing it?

When I finish some issues.


Updated version, try it out everyone

for anyone that wants an up to date version of this blog. I attempted to upgrade everything and things are useable. Enjoy!
https://github.com/deonneon/nextjs-netlify-blog-template

Unfortunately, I'm not able to get this to work.

The "next export" command has been removed in favor of "output: export" in next.config.js. Learn more: https://nextjs.org/docs/advanced-features/static-html-export