Make Dark Diamonds more common

After all my testing session near bedrock, I couldnt find any dark diamonds anywhere.

I'll consider it - remember they blend in more though, especially with the deepslate variant


Marcos alberto21

Please review the news features,
added the custom table to put on the top of vuetify table and you can download in file pdf or excel about information in the table.

great job!


fix yaml & use entry_points

fix yaml.load with yaml.safe_load
use entry_points instead of legacy scripts in setup.py
as installing using pip from git scm will not update bin/pipelines script
leave bin/pipelines for back-compatibility purpose
fixed filter matching bug in ghauth handler

filter matching bug in ghauth handler is now fixed


[MBL-1208] Part 3: Pledge Rewards Summary Section

📲 What
Currently showing changes from https://github.com/kickstarter/ios-oss/pull/1970 because that is waiting to be merged. I can clarify the relevant changes for this in a huddle if anyone needs it.
Adds the table view summarizing the current pledge info. Designs
🤔 Why
When offering backers the chance to confirm their pledge info, visualizing everything in a receipt-like a view makes for better UX.
🛠 How
Follows a similar pattern as the existing collapsable PledgeExpandableRewardsHeaderViewController.

I opted to create a new standalone version for PCB because of the following notable difference

We don't want it it be collapsible or have the animating arrow icon button
We need this new table to have rows for shipping and bonus (if there are any) and a pledge total section. All of which the current expandable table doesn't have

We'll also be displaying this in the final PCP Checkout Screen.
👀 See

✅ Acceptance criteria

[x] Table doesn't show when a pledge with no reward is selected
[x] Table shows when a pledge with reward is selected
[x] Table shows the header, selected reward, add-ons (if applicable), shipping, bonus (if applicable), and pledge total section with conversion (similar to the previous PR)
[x] Table values for shipping, bonus, and total update when any are changed.

🪲 Oustanding issues

[x] Bonus does not update when tapping stepper. Need help with this!

@ifosli adding you to this too since you'll likely be using this new table in your current ticket


framework: resolve race condition in id_cr_wl_ map

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


v2 cli does not support loading models from local directory

System Info
docker image michaelf34/infinity:0.0.70
Information

[X] Docker + cli
[ ] pip + cli
[ ] pip + usage of Python interface

Tasks

[ ] An officially supported CLI command
[ ] My own modifications

Reproduction

mkdir models && cd models && git clone https://huggingface.co/BAAI/bge-m3 && cd ..
docker run -it --gpus all  -v $PWD:/models  -p 8081:8081  michaelf34/infinity:0.0.70 v2  --model-id "/models/bge-m3"  --served-model-name bge-m3  --port 8081
error message

INFO:     Started server process [1]
INFO:     Waiting for application startup.
INFO     2024-11-22 07:54:41,359 infinity_emb INFO: Creating 1engines: engines=['bge-m3']                                                                                infinity_server.py:92
INFO     2024-11-22 07:54:41,364 infinity_emb INFO: Anonymized telemetry can be disabled via environment variable `DO_NOT_TRACK=1`.                                                            telemetry.py:30
INFO     2024-11-22 07:54:41,373 infinity_emb INFO: model=`/models/bge-m3` selected, using engine=`torch` and device=`None`                                                                 select_model.py:64
ERROR:    Traceback (most recent call last):
  File "/app/.venv/lib/python3.10/site-packages/starlette/routing.py", line 693, in lifespan
    async with self.lifespan_context(app) as maybe_state:
  File "/usr/lib/python3.10/contextlib.py", line 199, in __aenter__
    return await anext(self.gen)
  File "/app/infinity_emb/infinity_server.py", line 96, in lifespan
    app.engine_array = AsyncEngineArray.from_args(engine_args_list)  # type: ignore
  File "/app/infinity_emb/engine.py", line 291, in from_args
    return cls(engines=tuple(engines))
  File "/app/infinity_emb/engine.py", line 70, in from_args
    engine = cls(**engine_args.to_dict(), _show_deprecation_warning=False)
  File "/app/infinity_emb/engine.py", line 55, in __init__
    self._model_replicas, self._min_inference_t, self._max_inference_t = select_model(
  File "/app/infinity_emb/inference/select_model.py", line 71, in select_model
    unloaded_engine = get_engine_type_from_config(engine_args)
  File "/app/infinity_emb/inference/select_model.py", line 36, in get_engine_type_from_config
    config_path = hf_hub_download(
  File "/app/.venv/lib/python3.10/site-packages/huggingface_hub/utils/_validators.py", line 106, in _inner_fn
    validate_repo_id(arg_value)
  File "/app/.venv/lib/python3.10/site-packages/huggingface_hub/utils/_validators.py", line 154, in validate_repo_id
    raise HFValidationError(
huggingface_hub.errors.HFValidationError: Repo id must be in the form 'repo_name' or 'namespace/repo_name': '/models/bge-m3'. Use `repo_type` argument if needed.

ERROR:    Application startup failed. Exiting.

@michaelfeil It's basically just cloning the model to e.g. /data/model/bge-m3 and then loading from there when starting infinity. This simplifies air gapped mode and makes the startup much faster especially if the model does not change but a new version of infinity is used.


Continue with Listener creation even if one listener in the list fails

This is similar to what has been done for CDS here https://github.com/envoyproxy/envoy/pull/5806 but for LDS. If a listener fails for some reason, we would stop the listener creation and throw exception, half of the listeners would have been created by that time. I think it makes sense to continue with other listeners in the list.
Thoughts?

@ramaraochavali I agree we should be consistent here.

Ok. Cool. Will fix this.

/assign ramaraochavali


Hospitalrun not performing logins.

Hi,
I installed CouchDB 1.6, hospital-run-server, ran npm install then npm start and this time I am on defaults and also following the setup guide to the letter. After logging in I see basically nothing and the only working event is the settings button (logout/about).
Database setup (http://localhost:5984/_utils/index.html):
[~/vagrant_trusty/hospitalrun-server] $ initcouch.sh
""
{"ok":true}
{"ok":true}
{"ok":true}
{"ok":true}
{"ok":true}
"{couch_httpd_oauth, oauth_authentication_handler}, {couch_httpd_auth, proxy_authentification_handler}, {couch_httpd_auth, cookie_authentication_handler}, {couch_httpd_auth, default_authentication_handler}"
"true"
{"ok":true,"id":"org.couchdb.user:hradmin","rev":"1-edefdea74a4de3c96f0764a90ed0b522"}

config.js:
var config = {
  couchDbServer: 'localhost',
  couchDbPort: '5984',
  couchDbUseSsl: false,
  couchDbChangesSince: 'now',
  couchAdminUser: 'COUCH ADMIN USER GOES HERE',
  couchAdminPassword: 'COUCH ADMIN PASSWORD GOES HERE',
  googleClientId: 'FOR GOOGLE SSO; GOOGLE CLIENT ID GOES HERE',
  googleClientSecret: 'FOR GOOGLE SSO; GOOGLE CLIENT SECRET GOES HERE',
  serverPort: '3000',
  server: 'localhost',
  sslCert: 'file location of ssl cert if needed',
  sslKey: 'file location of ssl key if needed',
  sslCA: [], // Array of file locations of trusted certificates in PEM format if needed
  useSSL: false,
  imagesdir: __dirname + '/patientimages',
  logRequests: false,
  logFormat: 'default', // See http://www.senchalabs.org/connect/logger.html for log formats
  useGoogleAuth: false,
  useCertBot: false
};

Screenshots of what happens when I click login:
https://www.dropbox.com/sh/vi4sea2fk87w8de/AAB9Ctw2lz7vVw8eo6bhq88Sa?dl=0

Thanks.

@SheriefAlaa You need to replace the following in config.js:
couchAdminUser: 'COUCH ADMIN USER GOES HERE',
couchAdminPassword: 'COUCH ADMIN PASSWORD GOES HERE',
with the couch admin user and password.  If you just ran initcouch.sh with no arguements, the values should be:
couchAdminUser: 'couchadmin',
couchAdminPassword: 'test',

@jkleinsc I forgot to mention that I tested with and without adding in a user
(hradmin:test, I also just tested couchadmin:test) to config.js. The outcome is the same. Have you checked the screenshots (I added two more to the folder - CouchDB isn't even getting requests)?

@SheriefAlaa a couple of things to investigate:

Do you see any output in the terminal where you are running hospitalrun (eg npm start)
Can you login into futon by going to http://<IP_ADDRESS>:5984/_utils/ and then clicking on login in the lower right hand corner?  You should be able to login with both couchadmin/test and hradmin/test
Once you login, verify that there is a config database and a main database.

Also, you can't login into HospitalRun using couchadmin/test.  You need to use hradmin/test.  Couchamdin/test is a couchdb only user and not intended for logging into HospitalRun.


Update mode.md

Added possible values for mode at the beginning.
Replaced provides with sets, sounds better imo.

@montogeek

Setting --mode to none is the same as omitting it?
If you omit it, it will use production

Sorry, I don't understand your second question.

Never mind, I just found the answer to my question, reading the docs helps in my case ;-)

none --> Opts out of any default optimization options

Thanks!


Allow use as library without structopt dependency

Would it be possible to include as a crate without the binary dependency? Apologies, I'm slightly out of my depth here. In a prototype exercise to include minification with Zola (a rust-based static site generator), the inclusion of the binary raised some concern: https://github.com/getzola/zola/issues/542#issuecomment-646179801

I've extracted the CLI out to a separate package, so the library no longer has a binary or binary-specific dependencies.
There is a Rust RFC for supporting this without having to use a separate package (rust-lang/rfcs#2887), but it looks like it hasn't been approved yet.
Zola looks pretty cool! Let me know how it goes and if you run into any issues.

Fantastic! Thank you for implementing this so quickly. I've worked the update into my prototype.

Can't this be closed?

This was resolved in https://github.com/wilsonzlin/hyperbuild/commit/7a52bd7add644d9b604ba12abe7f97b643612ade


Modal header text rendering as black in firefox

Modal header text rendering as black in firefox in dark mode.
Current Behavior
Modal header text is rendering as black in firefox 98.0.2
Expected Behavior
Modal header text should be rendering as white.
Reproduction URL
https://codepen.io/mxreaper/pen/RwxKNVY
Environment
Windows 10, Firefox 98.0.2

Same in Safari (iOS).

What from i see the examples/live demo don't use the header element. So you don't see the issue.

@MxReaper, thank you.
I was able to reproduce the bug on iOs.
The browser is setting a default color for the dialog element. I had to override it.
The fix will be shipped in the next release.


kick start healing if the vm robot is not reachable #261

fixes #261

@andrewayoub @muhamadazmy  shouldnt part of the fix be refactoring the monitor_vm in the s3? and if the service is not reachable, remove the vm running state?


config file

Any sort of configuration file?

Try the wiki at http://elinux.org/RPi-Cam-Web-Interface


[Storage] Add Queue Permissions enum to represent QueueAccessPolicy.Permissions

Addressed issue here: https://github.com/Azure/azure-sdk-for-net/issues/37653

API change check
API changes are not detected in this pull request.

Looks like CI is failing due to unrecorded tests

Yeah I'm aware, gonna record the tests in a bit


Error while creating a Project using Ansible Template

Error Description:
Error while creating release definition: Tasks with versions 'Replace variables in Ansible script to deploy Azure resources:4., Run playbook to deploy Azure resources:0.' are not valid for deploy job 'Agent job' in stage Azure Dev.
PS: I'm using free tier organization.

@Vijay-333 install the extension Ansible from marketplace, then try provisioning the project.


SOLR-16824: Replace deprecated single-dash arguments

https://issues.apache.org/jira/browse/SOLR-16824
Description
This PR replaces additional deprecated single-dash arguments that were depricated in previous PRs.
Checklist

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[ ] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[ ] I have run ./gradlew check.
[ ] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

Additional Notes / TODOs:
The following list contains the arguments that were looked up:

Argument
Replaced With
main migrated
branch_9x migrated

-help
--help or -h
✅
❓

-version
--version or -v*
❓
❓

-foreground
--foreground
✅
❓

-cloud
--cloud
✅
❓

-host
--host
✅
❓

-port
--port
✅
❓

-scheme
--scheme
✅
❓

-zkHost
--zk-host
✅
❓

--zkHost
--zk-host
✅
❓

-solrUrl
--solr-url
✅
❓

-solr.home
--solr-home
✅
❓

-solr-home
--solr-home
✅
❓

-data.home
--data-home
✅
❓

-data-home
--data-home
✅
❓

-confname
--conf-name
✅
❓

-confdir
--conf-dir
✅
❓

-collection
--collection*
❓
❓

-collections
--collections*
❓
❓

-verbose
--verbose*
❓
❓

-credentials
--credentials*
❓
❓

-prompt
--prompt*
✅
❓

-noprompt
--no-prompt
✅
❓

--noprompt
--no-prompt
✅
❓

-action
--action
✅
❓

-property
--property
✅
❓

-value
--value
✅*
❓

-solrIncludeFile
--solr-include-file
✅
❓

-example
--example
✅
❓

-key
--key
✅
❓

-all
--all
✅
❓

-force
--force
✅
❓

-out
--out
❓
❓

While editing I noticed that:

Between -noprompt, --noprompt and --no-prompt, which option will be maintained?

[ ] There are occurences that have not been replaced

Some arguments are not present in bin/solr nor bin/solr.cmd (e.g. --collections)

[ ] Is this a problem?

[ ] Clarify if -collections is also deprecated and should be replaced with --collections
[ ] Clarify the usage of -collection (was that a typo ir is there an argument called "collection"?)
[ ] Clarify difference between -V and -v

[ ] Both arguments long form is --verbose, is this a problem?
[ ] --value for setting property value does also use -v as short form, is this a problem?

[ ] bin/solr.cmd supports -confdir, but bin/solr does not, should this be fixed?
[ ] bin/solr supports -solr.home, but bin/solr.cmd does not (same applies for -data.home), should this be fixed?
There are overlapping short arguments

[ ] -d is used for --dir and --conf-dir, is this fine?
[ ] -s is used for --solr-url and --solr-home, is this fine?

The multicharacter command url is still used as -url and resolves to --solr-udpate-url (post tool)
[ ] In solr/docker/scripts/docker-entrypoint.sh:37: Does this block need to be updated to cover --help too?
[ ] In solr/ref-guide/modules/deployment-guide/pages/solr-control-script-reference.adoc:1119: Is -scheme deprecated and --scheme the new command? (see also solr/bin/solr.cmd:1390)
[ ] solr/bin/instal_solr_service.sh:171 Should this be -h|-help|--help|--usage|-usage) instead? (--usage was not introduced I think?)
[ ] solr/bin/solr:938: Should we support --collection?
[ ] solr/bin/solr.cmd:258 Should we also have --version as option?
[ ] solr/bin/solr.cmd:530 and follow: Do we have to cover always both (- and --) options in the list? Only a limited list of arguments are covering both options
[ ] solr/bin/solr.cmd:1409 and follow: Do we have to cover additional options (like --conf-dir and --help)?
[ ] solr/bin/solr.cmd:1648 and follow: Do we have to cover additional options (--help and -h)?
[ ] solr/core/test/org.apache.solr.cli.TestSolrCLIRunExample.java:117 Should -cloud also be included in the checks?
[ ] solr/core/main/org.apache.solr.cli.RunExampleTool.java615-620 The arguments are mixed (written out and not), should this be unified for consistency?
[ ] solr/prometheus-exporter/main/org.apache.solr.prometheus.exporter.SolrExporter.java class properties called ARG_***_FLAGS Should they include the single-dash option too?
[ ] solr/core/test/org.apache.solr.cli.TestExportTool.java testWithBasicAuth method uses only single dashed arguments, should be updated?
[ ] solr/core/test/org.apache.solr.cli.DeleteToolTest.java

[ ] Method testFailsToDeleteProtectedCollection uses only single dashed arguments
[ ] Method testDeleteCollectionWithBasicAuth uses only single dashed arguments

[ ] solr/core/test/org.apache.solr.cli.CreateToolTest.java Method testCreateCollectionWithBasicAuth method uses only single dashed arguments

@epugh I went through the main branch first and looked up all the arguments I thought may need replacement.
The above list is contains locations where deprecated arguments might still be used or have no replacement yet.

This is some great analysis...    Not sure the best way to go through this...   Maybe a topic for next week community meetup?   Or a working sesion?   I think I'll comment in the code, and lets see how that goes.   One thing to keep in mind is that we are keeping in branch_9x the deprecated options, however we will be able to get rid of them in 10x.

There are updates in main to test_post.bats and test_help.bats that you probably want ;-)


KBC-1991 remove curl call and replace it with guzzle

Jira: KBC-1991
curl call removed and replaced by guzzle

:eye:


SAK-33530 - Enter grades using comma as decimal separator

Cannot enter a grade in percentage using comma as decimal separator

I've tested the PR at sakai-trunk.atica.um.es. The solutions works fine as described in the JIRA.


Migrations updated

Updated migrations and Ddatabase installation instructions to the new version of the DB.
Main changes are the the deletion of the tables order_details and order_items, now replaced by the relation of purchase, product and purchase_product.
Database tested with manual insertions.
README.md and .envexample updated for ease of use

 Revisar Migrations


JSON Stream logs are 404s

Hello,
It seems that recently the JSON formatted stream logs have been returning 404s. A few examples:
https://lasair-iris.roe.ac.uk/lasair/static/streams/lasair_2AllnucleartransientsandTDEcandidates
https://lasair-iris.roe.ac.uk/lasair/static/streams/lasair_2SN-likecandidates

Austin
Fixed now. Thanks for pointing this out.
Roy

Hi @RoyWilliams, I'm still having this issue with a few streams. In particular Yael's that we would like to start using.
https://lasair-iris.roe.ac.uk/lasair/static/streams/lasair_165NewTDEsEA
https://lasair-iris.roe.ac.uk/lasair/static/streams/lasair_165NewTDEs

Sorry about that Austin. Should be fixed now.
Roy

This issue appears to be back.
https://lasair-iris.roe.ac.uk/streams/lasair_165NewTDEsEA/


Fix client default read timeout setting

Summary
In this PR I removed setting zero timeout in case of passed negative value.
The problem occurs when we call client.Dial:

Firstly here we call dial and sets default options, and when the ReadTimeout value is NoTimeout, we set it to zero.
Then, in client.Connect method, we call opt.setDefault as well here, but by this moment readTimeout had been already set to default value zero, and here it would be interpreted as time duration zero value and be set to DefaultReadTimeout.

To prevent this error it is sufficient just to remove setting ReadTimeout to zero and leave it with negative value, because here is the only place it is used and current check is enough.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Created and updated docs for 1.25

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/hold cancel
/approve


Update to glutin 0.8, Winit 0.6

This will require gfx_window_glutin to be published.
I'm on linux and didn't get a chance to test the trianglell example.

Looks great! One small thing - gfx_app version also needs a bump.

I wonder, where did travis go?..

@homu r+

:pushpin: Commit 55d1347 has been approved by kvark

:hourglass: Testing commit 55d1347 with merge 2844afc...

:broken_heart: Test failed - status

@homu r+

:pushpin: Commit 0705a00 has been approved by kvark

:hourglass: Testing commit 0705a00 with merge d5de10c...

:broken_heart: Test failed - status

Almost there! OSX just needs a fixup.

@homu r+

:pushpin: Commit 23ae748 has been approved by kvark

:hourglass: Testing commit 23ae748 with merge 22b0d06...

:sunny: Test successful - status

Woohoo!

May I ask it to be published?

@ishitatsuyuki I can publish gfx_window_glutin later tonight. Do you need any other crates among the updated ones?

I only need the glutin one. Thanks!

@ishitatsuyuki ok, will do. Please use an override to a locally-checked-out crate in the meantime

@ishitatsuyuki version 0.16.0 is published now from rev https://github.com/gfx-rs/gfx/commit/162221c9de84107130bef51f3c9cc0b7574ee75b


[WIP] Improve MetadataMgr

What type of PR is this：

[ ] bug
[x] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

run starrocks_fe_unittest

[FE PR Coverage check]
:disappointed: fail : 28 / 78 (35.90%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/connector/hive/HiveMetadata.java
0
1
00.00%

:large_blue_circle:
com/starrocks/server/CatalogMgr.java
0
1
00.00%

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
0
4
00.00%

:large_blue_circle:
com/starrocks/external/hive/HiveMetaStoreThriftClient.java
0
1
00.00%

:large_blue_circle:
com/starrocks/external/hive/HiveMetaClient.java
0
5
00.00%

:large_blue_circle:
com/starrocks/connector/ConnectorDatabaseId.java
1
6
16.67%

:large_blue_circle:
com/starrocks/external/hive/HiveMetaCache.java
2
9
22.22%

:large_blue_circle:
com/starrocks/server/MetadataMgr.java
22
47
46.81%

:large_blue_circle:
com/starrocks/external/HiveMetaStoreTableUtils.java
1
2
50.00%

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
2
2
100.00%

run starrocks_fe_unittest

[FE PR Coverage check]
:heart_eyes: pass : 77 / 85 (90.59%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/external/hive/HiveMetaStoreThriftClient.java
0
1
00.00%

:large_blue_circle:
com/starrocks/external/hive/HiveMetaClient.java
2
5
40.00%

:large_blue_circle:
com/starrocks/connector/ConnectorDatabaseId.java
4
6
66.67%

:large_blue_circle:
com/starrocks/server/MetadataMgr.java
45
47
95.74%

:large_blue_circle:
com/starrocks/connector/hive/HiveMetadata.java
1
1
100.00%

:large_blue_circle:
com/starrocks/server/CatalogMgr.java
1
1
100.00%

:large_blue_circle:
com/starrocks/external/hive/HiveMetaCache.java
11
11
100.00%

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
9
9
100.00%

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
2
2
100.00%

:large_blue_circle:
com/starrocks/external/HiveMetaStoreTableUtils.java
2
2
100.00%


[mem-access-utils] Teach memInstMustInitialize that indirect out parameters are initializing.

Just something I noticed while reading the code.

@swift-ci smoke test

@swift-ci smoke test


Canceled Nitro Sub Breaks Nitro Spoof

Hi, I previously tried to get help with this via this via the Aliucord Server, however no one seems to have come across this strange bug. The account i am on used to have nitro, it was a playstore sub if that matters, however that has since long been canceled.
I have the NitroSpoof plugin on and Enabled, and additionally it WORKS In other accounts, but in this specific account, the only one that used to have nitro, instead of it converting the Emojis to Gifs it just writes the Emoji as Like for example if it was PepeHands it will write :pepehands: and then it either gives an error or it just sends the text with no emoji. I am attaching a screen recording.
Just FYI troubleshooting i tried.
I have tried to uninstall ALL other plugins and themes and have ONLY nitro spoof.
I have tried to Re-Install Aliucord all together with only nitro spoof.
I actually even factory reset my entire phone (for another reason) but then reinstalled Aliucord, with only nitro spoof.
Also mentioned I've tried it on accounts that never had nitro and it works so it seems that ever having nitro (even when EXPIRED ) somehow is breaking this plugin
https://user-images.githubusercontent.com/105574409/225733689-761fe588-6aa5-45de-9843-6b23670eeec5.mp4
Thank you for any help!!!

Just pushed out 1.0.10 with some changes by @Delphox in #55. The PR was related to the server boosts, but see if that fixes the issue.

Just pushed out 1.0.10 with some changes by @Delphox in #55. The PR was related to the server boosts, but see if that fixes the issue.

Well, the thing is I reported this over a year ago, since then the problem seems to have resolved itself, Can't really say what exactly fixed it, but at the moment nitro-spoof works fine

Just pushed out 1.0.10 with some changes by @Delphox in #55. The PR was related to the server boosts, but see if that fixes the issue.

Well, the thing is I reported this over a year ago, since then the problem seems to have resolved itself, Can't really say what exactly fixed it, but at the moment nitro-spoof works fine


[8.x] Don't pluralise string if string ends with none alphanumeric character

Avoid scenarios such as below.

Right now we still enable adding s for string ending with numeric to avoid breaking change for Model to table name naming convention.
Signed-off-by: Mior Muhammad Zaki<EMAIL_ADDRESS>

Can we see how much this preg_match query affects performance?


MB-10533 Locust best practices refactors

Description
Implementing some of my suggestions for best practices refactors. Key points are:

Use a RestTaskSet class that can handle automatically parsing json and will auto-fail if the response isn't json.

This also gives us the ability to mark a task as a success or failure, regardless of the status code.
Note that this is different from the original plan to use RestHttpUser because we don't really need the things it provides at a user level, we need them at a task set level since we define all our load tests in task sets.

Make it easier to make requests with all the necessary bits (proper url, certs, etc.). To do this, I've created some helper functions that give you what you need, which can then be used with the client, or with our own thing, e.g. we can use the requests library directly.
Create some parent classes we can easily use without having to worry about the proper order for mixins to be in.

Only have one so far, but I'm going to take a look to see if anything else would be good to do.

Pull cert creation/deletion out of the user classes and instead do it at the locust init/shutdown level. This simplifies it a bit. Also cut down on the ability to run against arbitrary environments since we are only using local and dp3.

Setup
Things are still in progress, but I added a locustfile called rest.py that shows a very simple usage of the new RestHttpUser class. You can run this file by starting up the mymove server, and then running this command:
locust -f locustfiles/rest.py --host local

If you'd like to run without the UI, here's the command with some extra args:
locust -f locustfiles/rest.py --headless --host local -u 100 -r 5 -t 30s -T listMoves

Code Review Verification Steps

[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change.
Locust Best Practices Wiki

I need to update this wiki though with some of my learnings as I've tried to implement changes...

LGTM. I think there are areas that are a bit confusing at the moment since we are supporting both the old way and the new way. Specifically the way that urls are setup in the MilMoveHostMixin, which to my understanding isn't used in the new format you are proposing.

Yeah, I'm going to see how much work it would be to just switch things over so we don't have to live in both worlds. Based on my earlier testing, it should hopefully not be too much 🤞🏼

I've written tests for all the helpers and such I wrote. At least I think I have... 🤔 ...but it's also the end of the day so I may have missed something. At this point, the main thing left is to address what @ronaktruss pointed out about it being confusing at the moment because we have both the new and old ways of doing things. I'll tackle that on monday, and depending on how much it is, might open a second PR to stop this one from getting too much bigger. We'll see. For now though, the core things that I've added I think are ready for review.

Note that I'm still working through updating the README, but as I was doing code examples for it, I realized we really don't need the RestHttpUser class, but rather that functionality at a TaskSet level since we define all our load tests in task sets.

Ok, the docs are done I think, at least based on where the code is now. I'll work on seeing what it takes to switch existing load tests over to use the new stuff in a separate PR to keep it more manageable.


Can't convert custom model to tflite with model config and weights file being separate

Hi,
I am trying to convert a custom model to tflite with these steps:
#creates a custom model that I have previously defined (Resnet50 as a backbone (pretrained weights) + transformer encoder + MLP head)
model = create_model(classes=5)
#the best weights file obtained after my custom model training
model.load_weights(model_weights_path)
converter = tf.lite.TFLiteConverter.from_keras_model(model)
converter.optimizations = [tf.lite.Optimize.DEFAULT]
converter.target_spec.supported_ops = [tf.lite.OpsSet.TFLITE_BUILTINS, tf.lite.OpsSet.SELECT_TF_OPS]
tfmodel = converter.convert()
with tf.io.gfile.GFile(tf_lite_path +  'tflite_model' + ".tflite", 'wb') as f:
    f.write(tfmodel)

I do not get any output on this, no errors as well. The question is - is it possible to convert my custom model with creating the model (without saving it) and then loading the weights the way I have done? Is there any other way how to make my model smaller after training?

@codingzebra333
Could you please provide complete code or Colab gist to replicate the issue reported here ?
Thank you!

Hey, here is the colab file - https://colab.research.google.com/drive/13KYqJWwNQ-ju0APaqEaZj39wYodN0Uu8?usp=sharing
Thank you!

Hi @codingzebra333 ,
When I try to execute the given code on Colab using TF v2.11, I get the following error:
OperatorNotAllowedInGraphError: Exception encountered when calling layer 'tri_q_image_quality_transformer' (type TriQImageQualityTransformer).Using a symbolic tf.Tensor as a Python bool is not allowed: AutoGraph is disabled in this function. Try decorating it directly with @tf.function.
As per above error decorate the call function with @tf.function in transformer_iqa.py file, I was able to convert the model to tflite model without any error. Could you please find the gist here for reference.
Thank you!

Hi!
Could you please share the file that you edited, because it is still not working for me? Thank you in advance!

@codingzebra333
This is the transformer_iqa.py file where I add the @tf.function at 168th line before the call function. Could you please refer to the screenshot amd let us know if it helps .
Thank you !

@codingzebra333
You can evaluate the tflite model by using model.evaluate_tflite('model.tflite', test_data). Please refer to this doc
Could you please Close the issue if it resolves?
Thank you!

Hey, using your suggested evaluation, I got an error: AttributeError: 'Functional' object has no attribute 'evaluate_tflite'. Supposedly, the issue is that the method I am trying to use is not present on the TFLite model class. But I have no idea how to fix it. Would really appreciate your help with this. Thank you in advance!

@codingzebra333
Could you please give a sample code to reproduce the issue ?
Thank you!

@codingzebra333
Could you please give a sample code to reproduce the issue ?
Thank you!

Hey, here is the sample code.

@codingzebra333
Could you please provide an accessible code to replicate the issue ?
Thank you!

You should be able to access it now!

Hey, I tried different approach and got ValueError: Could not open tflite model. Here is the code: https://colab.research.google.com/drive/14zMCm0XaszVrUoWd9bMvBjSXSdPvSWuw#scrollTo=o3lYXU2CwMoG

Hey, is it possible to get some insights regarding this issue? I even tried a different approach how to convert the model to tflite and I still can't evaluate the accuracy. I also provided both ways how I converted my .h5 file to .tflite in tha colab file.

@codingzebra333
This issue is similar to #59684 . This issue will triage on #59684 . Could you please feel free to close this issue?
Thank you!


sped up sdir_tx_isr

The setting of all gpio pins on the port concerns me, but I'll merge this for now.


Accented letters cannot be used in the in-game chat

Describe the bug
The server is unable to recognize accents since the addition of the server bridges. For example, when I type "pokémon", the server removes the "é", showing just "pokmon".
To Reproduce
Steps to reproduce the behavior:

Type any accented letter like é à û ç in the in-game chat.

Expected behavior
Be able to use accented letters.
Username:
Mortenkein
Server name (all applicable):
Atlas, but all servers I guess.

Accented letters do not link from discord to in game however, from server to discord functions.

no longer an issue, closing


Can't build on macOS (I'm noob)

I am building Desmos Desktop from source on MacOS Ventura 13.0.1
When I building it I get some errors and can't figure out how to solve them (I'm not an professional in Linux and totally new to Mac)
There is the last x lines of output:
npm timing metavuln:calculate:security-advisory:electron-builder:/m9e3+4eZoJfOIwv8u2YcZKESjn0cIhdUiW+L61QXSBmG2KZi6k99KfoVT97S8J5FhMGkfsm3PSLHKAk2BZ2jw== Completed in 2ms
npm timing metavuln:packument:update-notifier Completed in 0ms
npm timing metavuln:cache:get:security-advisory:update-notifier:xP9mRUu7m2mo/448iOKQBNLQe2N0zzOtFmffIfl+EP72ua2qlDbi4Wmy47kf6ngmCp6oXq5KSrlC0sT177Bjvg== Completed in 0ms
npm timing metavuln:load:security-advisory:update-notifier:px3BGTh0zXO0FGPeGweQ9jqShrQQXkwvso85ThJdSYlN4ZaZJDL3uEj6l9X6a7TaVNgKnd3jqWD9VSx0Ti/yzQ== Completed in 0ms
npm timing metavuln:calculate:security-advisory:update-notifier:px3BGTh0zXO0FGPeGweQ9jqShrQQXkwvso85ThJdSYlN4ZaZJDL3uEj6l9X6a7TaVNgKnd3jqWD9VSx0Ti/yzQ== Completed in 0ms
npm timing metavuln:cache:get:security-advisory:electron-builder:YsUyPVjiTjxWw/RfhFcyPCsH2D4Q7F2whBXLLS22kSNogjq+UMk+WUbPIOy7yhM8SUKHtlPS2rvSWeFC947B9Q== Completed in 1ms
npm timing metavuln:load:security-advisory:electron-builder:xP9mRUu7m2mo/448iOKQBNLQe2N0zzOtFmffIfl+EP72ua2qlDbi4Wmy47kf6ngmCp6oXq5KSrlC0sT177Bjvg== Completed in 1ms
npm timing metavuln:calculate:security-advisory:electron-builder:xP9mRUu7m2mo/448iOKQBNLQe2N0zzOtFmffIfl+EP72ua2qlDbi4Wmy47kf6ngmCp6oXq5KSrlC0sT177Bjvg== Completed in 2ms
npm timing auditReport:init Completed in 59ms
npm timing reify:audit Completed in 1055ms
npm info run<EMAIL_ADDRESS>postinstall { code: 1, signal: null }
npm timing reify:rollback:createSparse Completed in 119ms
npm timing reify:rollback:retireShallow Completed in 0ms
npm timing command:install Completed in 1711ms
npm ERR! code 1
npm ERR! path /Users/vladyslav/Desmos-Desktop/node_modules/electron
npm ERR! command failed
npm ERR! command sh -c -- node install.js
Downloading tmp-14475-0-electron-v3.1.13-darwin-arm64.zip
npm ERR! Error: GET https://github.com/electron/electron/releases/download/v3.1.13/electron-v3.1.13-darwin-arm64.zip returned 404
npm ERR! /Users/vladyslav/Desmos-Desktop/node_modules/electron/install.js:49
npm ERR!   throw err
npm ERR!   ^
npm ERR!
npm ERR! Error: Failed to find Electron v3.1.13 for darwin-arm64 at https://github.com/electron/electron/releases/download/v3.1.13/electron-v3.1.13-darwin-arm64.zip
npm ERR!     at Request.<anonymous> (/Users/vladyslav/Desmos-Desktop/node_modules/nugget/index.js:197:61)
npm ERR!     at Request.emit (node:events:513:28)
npm ERR!     at Request.onRequestResponse (/Users/vladyslav/Desmos-Desktop/node_modules/request/request.js:1059:10)
npm ERR!     at ClientRequest.emit (node:events:513:28)
npm ERR!     at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:688:27)
npm ERR!     at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17)
npm ERR!     at TLSSocket.socketOnData (node:_http_client:530:22)
npm ERR!     at TLSSocket.emit (node:events:513:28)
npm ERR!     at addChunk (node:internal/streams/readable:324:12)
npm ERR!     at readableAddChunk (node:internal/streams/readable:297:9)
npm ERR!
npm ERR! Node.js v19.2.0
npm timing npm Completed in 1753ms

npm ERR!      /Users/vladyslav/.npm/_logs/2022-12-07T19_15_38_193Z-debug-0.log
sh: electron-builder: command not found
cd: no such file or directory: dist
➜  Desmos-Desktop git:(master)

How to install Desmos Desktop?

Hey! I figured this out just now since I had the same problem. Running npm install electron@latest before npm install -d (inside the Desmos-Desktop directory) made it build properly.

Hey! Old reply but I figured this out just now since I had the same problem. Running npm install electron@latest before npm install -d (inside the Desmos-Desktop directory) made it build properly. The error has to do with that electron version not having a build for macOS arm64, so upgrading fixes it.

I tried to do so, but got the:
➜  Desmos-Desktop git:(master) npm install electron@latest
npm WARN deprecated<EMAIL_ADDRESS>Please use @electron/osx-sign moving forward. Be aware the API is slightly different

added 276 packages, and audited 277 packages in 24s

30 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (4 moderate, 2 high, 2 critical)

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
➜  Desmos-Desktop git:(master) ✗ npm install -d
npm run dist
cd dist && ls
npm info using<EMAIL_ADDRESS>npm info using<EMAIL_ADDRESS>npm http fetch POST 200 https://registry.npmjs.org/-/npm/v1/security/advisories/bulk 324ms
npm http fetch GET 200 https://registry.npmjs.org/ejs 54ms (cache updated)
npm http fetch GET 200 https://registry.npmjs.org/got 189ms (cache updated)
npm http fetch GET 200 https://registry.npmjs.org/app-builder-lib 196ms (cache updated)
npm http fetch GET 200 https://registry.npmjs.org/electron-builder 140ms (cache updated)
npm http fetch GET 200 https://registry.npmjs.org/dmg-builder 154ms (cache updated)
npm http fetch GET 200 https://registry.npmjs.org/package-json 55ms (cache updated)
npm http fetch GET 200 https://registry.npmjs.org/latest-version 888ms (cache updated)
npm http fetch GET 200 https://registry.npmjs.org/update-notifier 58ms (cache updated)

up to date, audited 277 packages in 2s

30 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (4 moderate, 2 high, 2 critical)

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
npm info ok

><EMAIL_ADDRESS>dist
> electron-builder

  • electron-builder version=20.44.4
  • loaded configuration file=package.json ("build" field)
  • writing effective config file=dist/builder-effective-config.yaml
  • no native production dependencies
  • packaging       platform=darwin arch=x64 electron=30.0.1 appOutDir=dist/mac
  • downloading     parts=8 size=102 MB url=https://github.com/electron/electron/releases/download/v30.0.1/electron-v30.0.1-darwin-x64.zip
  • downloaded      duration=21.145s url=https://github.com/electron/electron/releases/download/v30.0.1/electron-v30.0.1-darwin-x64.zip
  • default Electron icon is used reason=application icon is not set
  • skipped macOS application code signing reason=cannot find valid "Developer ID Application" identity or custom non-Apple code signing certificate, see https://electron.build/code-signing allIdentities=
                                               1) 12C13E5B1B894047EF47F9C8C8E043D43C907983 "localhost" (CSSMERR_TP_NOT_TRUSTED)
                                                  1 identities found

                                               Valid identities only
                                                  0 valid identities found
  • building        target=macOS zip arch=x64 file=dist/desmos-1.0.0-mac.zip
  • building        target=DMG arch=x64 file=dist/desmos-1.0.0.dmg
  • building embedded block map file=dist/desmos-1.0.0-mac.zip
Error: Exit code: 2. Command failed: /usr/bin/perl /private/var/folders/fx/lxhzhmnx1l3cd0ymf8xkkgmr0000gn/T/t-3pgysP/1-dmgProperties.pl
Can't locate Mac/Finder/DSStore.pm in @INC (you may need to install the Mac::Finder::DSStore module) (@INC contains: /Library/Perl/5.34/darwin-thread-multi-2level /Library/Perl/5.34 /Network/Library/Perl/5.34/darwin-thread-multi-2level /Network/Library/Perl/5.34 /Library/Perl/Updates/5.34.1 /System/Library/Perl/5.34/darwin-thread-multi-2level /System/Library/Perl/5.34 /System/Library/Perl/Extras/5.34/darwin-thread-multi-2level /System/Library/Perl/Extras/5.34) at /private/var/folders/fx/lxhzhmnx1l3cd0ymf8xkkgmr0000gn/T/t-3pgysP/1-dmgProperties.pl line 3.
BEGIN failed--compilation aborted at /private/var/folders/fx/lxhzhmnx1l3cd0ymf8xkkgmr0000gn/T/t-3pgysP/1-dmgProperties.pl line 3.

Can't locate Mac/Finder/DSStore.pm in @INC (you may need to install the Mac::Finder::DSStore module) (@INC contains: /Library/Perl/5.34/darwin-thread-multi-2level /Library/Perl/5.34 /Network/Library/Perl/5.34/darwin-thread-multi-2level /Network/Library/Perl/5.34 /Library/Perl/Updates/5.34.1 /System/Library/Perl/5.34/darwin-thread-multi-2level /System/Library/Perl/5.34 /System/Library/Perl/Extras/5.34/darwin-thread-multi-2level /System/Library/Perl/Extras/5.34) at /private/var/folders/fx/lxhzhmnx1l3cd0ymf8xkkgmr0000gn/T/t-3pgysP/1-dmgProperties.pl line 3.
BEGIN failed--compilation aborted at /private/var/folders/fx/lxhzhmnx1l3cd0ymf8xkkgmr0000gn/T/t-3pgysP/1-dmgProperties.pl line 3.

    at /Users/vladyslav/tmp/Desmos-Desktop/node_modules/builder-util/src/util.ts:126:16
    at ChildProcess.exithandler (node:child_process:430:5)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at Socket.<anonymous> (node:internal/child_process:457:11)
    at Socket.emit (node:events:519:28)
    at Pipe.<anonymous> (node:net:337:12)
From previous event:
    at _applyProperties (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/dmg-builder/out/dmgUtil.js:179:27)
    at applyProperties (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/dmg-builder/out/dmgUtil.js:166:27)
    at /Users/vladyslav/tmp/Desmos-Desktop/node_modules/dmg-builder/src/dmg.ts:307:9
From previous event:
    at _customizeDmg (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/dmg-builder/out/dmg.js:458:24)
    at customizeDmg (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/dmg-builder/out/dmg.js:402:24)
    at /Users/vladyslav/tmp/Desmos-Desktop/node_modules/dmg-builder/src/dmg.ts:48:54
    at /Users/vladyslav/tmp/Desmos-Desktop/node_modules/dmg-builder/src/dmgUtil.ts:37:31
From previous event:
    at _attachAndExecute (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/dmg-builder/out/dmgUtil.js:120:28)
    at attachAndExecute (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/dmg-builder/out/dmgUtil.js:97:28)
    at /Users/vladyslav/tmp/Desmos-Desktop/node_modules/dmg-builder/src/dmg.ts:48:16
    at Generator.next (<anonymous>)
From previous event:
    at DmgTarget.build (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/dmg-builder/src/dmg.ts:21:42)
    at Function.buildAsyncTargets (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/app-builder-lib/src/platformPackager.ts:140:36)
    at MacPackager.packageInDistributableFormat (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/app-builder-lib/src/platformPackager.ts:119:24)
    at /Users/vladyslav/tmp/Desmos-Desktop/node_modules/app-builder-lib/src/macPackager.ts:91:26
    at processImmediate (node:internal/timers:478:21)
From previous event:
    at /Users/vladyslav/tmp/Desmos-Desktop/node_modules/app-builder-lib/src/macPackager.ts:91:10
    at Generator.next (<anonymous>)
From previous event:
    at MacPackager.pack (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/app-builder-lib/src/macPackager.ts:82:95)
    at /Users/vladyslav/tmp/Desmos-Desktop/node_modules/app-builder-lib/src/packager.ts:430:24
    at Generator.next (<anonymous>)
    at /Users/vladyslav/tmp/Desmos-Desktop/node_modules/fs-extra/lib/mkdirs/mkdirs.js:56:16
    at callback (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/graceful-fs/polyfills.js:306:20)
    at FSReqCallback.oncomplete (node:fs:204:5)
From previous event:
    at Packager.doBuild (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/app-builder-lib/src/packager.ts:396:24)
    at /Users/vladyslav/tmp/Desmos-Desktop/node_modules/app-builder-lib/src/packager.ts:366:57
    at Generator.next (<anonymous>)
    at /Users/vladyslav/tmp/Desmos-Desktop/node_modules/graceful-fs/graceful-fs.js:143:16
    at /Users/vladyslav/tmp/Desmos-Desktop/node_modules/graceful-fs/graceful-fs.js:61:14
    at FSReqCallback.oncomplete (node:fs:193:23)
From previous event:
    at Packager._build (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/app-builder-lib/src/packager.ts:335:133)
    at /Users/vladyslav/tmp/Desmos-Desktop/node_modules/app-builder-lib/src/packager.ts:331:23
    at Generator.next (<anonymous>)
    at processImmediate (node:internal/timers:478:21)
From previous event:
    at Packager.build (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/app-builder-lib/src/packager.ts:288:14)
    at build (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/app-builder-lib/src/index.ts:59:28)
    at build (/Users/vladyslav/tmp/Desmos-Desktop/node_modules/electron-builder/src/builder.ts:228:10)
    at /Users/vladyslav/tmp/Desmos-Desktop/node_modules/electron-builder/src/cli/cli.ts:49:19
builder-debug.yml  builder-effective-config.yaml  desmos-1.0.0-mac.zip  mac
➜  dist git:(master) ✗

npm install -d

Thank You! I build desmos successfully!


Make VolumeNameGenerator public

Is there an existing issue for this?

[x] I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.
No response
Describe the solution you'd like
Please make the VolumeNameGenerator class public so that other 3rd party packages can use it. There is a lot of logic in there to generate a proper volume name. Why make 3rd party packages recreate that same logic?
Additional context
No response

Yes, this should be public.

Yes, this should be public.

I took a swag at this one.

done


Implement ptrdiff_t type in C bindings

At the moment we don't support function input arguments of type ptrdiff_t in bindings to C libraries. The size of ptrdiff_t is chosen so that it can store the maximum size of a theoretically possible array of any type. On a 32-bit system ptrdiff_t will take 32 bits, while on a 64-bit one 64 bits. See here for more details. The definition of ptrdiff_t can be found in stddef.h. This is rather fundamental and we should support it in my opinion :)
Normally I would suggest that ptrdiff_t corresponds to an Int Crystal type, but this name is already reserved in Crystal, so we may choose another name.

Where has C::PtrDiffT gone?
At least it does not exist under LibC in the current version:
> bin/crystal eval 'LibC::PtrDiffT'
Using compiled compiler at .build/crystal
Showing last frame. Use --error-trace for full trace.

error in line 1
Error: undefined constant LibC::PtrDiffT
> bin/crystal version
Using compiled compiler at .build/crystal
Crystal 1.0.0-dev [7d2b41c9a] (2020-08-13)

LLVM: 10.0.1
Default target: x86_64-unknown-linux-gnu


changset should use unstable branch as base

Background
When running yarn changset it should be using the unstable branch as the base branch.
Solution
Updates the config.
Checklist

[X] I have :tophat:'d these changes
[ ] I have updated relevant documentation

Should the versioned branches also be updated to point at different branch names here?

That's a good question. I'll look into it.


I cannot deploy resource conditionally with bicep

Bicep version
Bicep CLI version 0.14.46
Describe the bug
I want to deploy resource only if it does not exists already:
I cannot deploy resource conditionally in bicep.
I have a deployment script checking resource existence and I want to use it output.
To Reproduce
Deployment script
resource checkStorageAccountExistence 'Microsoft.Resources/deploymentScripts@2020-10-01' = {
  name: 'checkStorageAccountExistenceScript'
  location: location
  kind: 'AzurePowerShell'
  identity: identity
  properties: {
    arguments: '-storageAccountName \'${string(name)}\' -resourceGroupName \'${string(resourceGroupName)}\''
    azPowerShellVersion: '3.0'
    scriptContent: '''
      param([string]$storageAccountName, [string]$resourceGroupName)
      $provisioningState = az storage account show --name $storageAccountName --resource-group $resourceGroupName --output tsv --query 'provisioningState'
      if ($provisioningState -eq "Succeeded") {$output = $true} else {$output = $false}
      Write-Output $output
      $DeploymentScriptOutputs = @{}
      $DeploymentScriptOutputs['storageAccountExists'] = $output
    '''
    forceUpdateTag: utcValue
    retentionInterval: 'P1D'
  }
}

Storage account:
resource storageAccount 'Microsoft.Storage/storageAccounts@2022-09-01' if(checkStorageAccountExistence.properties.outputs.storageAccountExists == true){ }
I get Error:
This expression is being used in the if-condition expression, which requires a value that can be calculated at the start of the deployment. Properties of checkStorageAccountExistence which can be calculated at the start include "apiVersion", "id", "name", "type".bicep(BCP177)
Funny enough I would be able to use the output elsewhere in the bicep file but not in the resource creation if?

This is a known limitation, but there is a workaround you can use. You can pass the checkStorageAccountExistence property to a module, which can use the value in an if condition:
main.bicep
resource checkStorageAccountExistence 'Microsoft.Resources/deploymentScripts@2020-10-01' = {
  ...
}

module storageAccountDeployment 'storageAccountDeployment.bicep' = {
  name: 'storageAccountDeployment'
  params: {
    storageAccountExists: checkStorageAccountExistence.properties.outputs.storageAccountExists
  }
}

storageAccountDeployment.bicep
param storageAccountExists bool

resource storageAccount 'Microsoft.Storage/storageAccounts@2022-09-01' = if (storageAccountExists) {
  ...
}

This pattern is permitted because the ARM engine is extremely literal with its rules. if conditions must be decidable at the start of a deployment, but a deployment can kick off another deployment, which is what happens when you include a module. The module deployment doesn't start until after the checkStorageAccountExistence script has finished running.


provide workspace folder alias

i got two same name folder in one workspace. like this.

can i tag the folder named web with a alias name?

/question
https://code.visualstudio.com/docs/editor/multi-root-workspaces#_workspace-file-schema


feat: implement connection as plugin prop

Thanks for this great plugin!
I would like to see this option in your package as it enables you to use it with the package @nestjs/mongoose. You can then do something like this:
MongooseModule.forRootAsync({
  useFactory: async (configService: ConfigService) => ({
    ...
    connectionFactory: async (connection) => {
      connection.plugin(EncryptionPlugin, {
        connection,
        secret: Buffer.from(secretKey, 'hex'),
        algorithm: 'AEAD_AES_256_CBC_HMAC_SHA_512-Deterministic',
        keyAltName: 'encryption_key',
        keyVaultNamespace: 'encryption.__keyVault',
      })
    }
    ...
  }
})

...

Best,
Chris

Thanks, Will try to take some time to implement it for nestjs.

Nice, thank you very much!


Refactor place icons

This PR does the following:

Removes two match blocks which discern national/state/city icons from town and village selectors, where they're necessary because those features are always dot icons. This will give is a small style size savings.
Renames the place icon file names to be consistent with our POI naming standards.

Is the dot smaller on purpose? There appear to be two icons, dot_city.svg and place_dot.svg, that look similar but have different dimensions.

Ah no, that's a regression.

Restored the proper dot in feabf84:

I also found a few other cases where common styling could be extracted to a function. I think with a bit more work the whole city/town/village structure could even be merged into a single layer.

Whoops just saw my review was requested, I'll take a look later this week but I'm certainly fine with the goals of this PR


feat: add keymanager to helm

Did we test this in local?

Also, are we planning to include key manager installation along with the Hyperswitch stack installation, or will this be independent?


Updated to add my suggestions from https://github.com/MicrosoftDocs/OfficeDocs-DeployOffice/pull/483

Subj.

cc @RAJU2529


a: func b, {c: d}

There's probably an open issue on this elsewhere, but I can't find it (@michaelficarra?). Currently,
a: func b, {c: d}

is a parse error (Unexpected ','). Pass the same expression to a function,
method a: func b, {c: d}

and you get the equivalent of
method {a: func b}, {c: d}

rather than what one would probably expect (as reported in this gist several hours ago).
So: Why does
func b, {c: d}

extend the function call to include the object literal, but
a: func b, {c: d}

does not?

method a: func b, {c: d}

Wow, I'd hate to see code that actually uses this; it's not obvious to me what it should mean, even with a working knowledge of the language. Though I suppose the way it's expressed in the gist makes a lot more sense.

I think the parse error is the right result. Folks shouldn't be encouraged to write code like this.

@halfbaked Do you really think it's right that
a = func b, {c: d}

is acceptable, and
{a: func b, {c: d}}

is acceptable, but
a: func b, {c: d}

is not? Does it still look unacceptable if you use concrete names?
spritePos =
  x: computeX prevX, {velocity: vx}
  y: computeY prevY, {velocity: vy}

@halfbaked: It's a bug. There's nothing wrong with the code from the OP. Are you making an argument against braceless object literals?
@erisdiscord: I didn't think it was that hard to parse.

@TrevorBurnham
When you put it in those steps, I see your point. Consistency is ultimately desirable, and after the first two of our examples, the leap to the next is not that great.
@michaelficarra
The point I was trying to highlight is that the dropping on unnecessary parenthesis, punctuation, etc. is supposed to aid clarity, but taking it too far can have the opposite effect. If the ratio of punctuation to complexity of one's statement is getting to the point that  the compiler is having trouble figuring out what your doing, what hope does someone reading your code have?

@halfbaked: I completely agree. I use curly braces around all but the most obvious cases for clarity. But braceless object literals are a part of the language, and should behave consistently with braced object literals wherever they are unambiguously used. The compiler is "having trouble", but it technically shouldn't be, so it's a bug.

@michaelficarra yeah, I see your point. It's actually easier to parse on re-reading; I think my initial reaction was one of a jerked knee.

very small patch to fix the issue and passed the test. but have no idea if there is any side effect.

@jiangmiao: mind opening a pull request so we could discuss it there?

of course, the pull reuqest opened.  https://github.com/jashkenas/coffee-script/pull/1912

The cause is  the rewriter consider , followed with {, is the end of the block.

No simple pull request is going to fix this correctly. I've taken a stab at the real fix, but was unable to get it working.
The gist is this: In order for mutually nested implicit calls and implicit objects to parse:
a: func b, {c: d}, e: f g h: e
... you're going to have to merge the addImplicitBraces and addImplicitParentheses rules in the Rewriter. They need to invoke each other so that each implicit call and implicit object is added as soon as it is encountered, left to right. After a new implicit object has been added, you have to rewind a couple of tokens to make sure that the implicit object isn't forcing an implicit call, which you otherwise would have missed. In addition, you need to invoke the rule recursively ... if you're in the middle of an implicit object, instead of doing a simple detectEnd, you'll need to handle any implicit calls you might find...
Hope that helps.

I agree recursively is the best solution.
exchange add braces and paren and add parens in twice is simple and effecial way. because of the iterator only increase 2 for each detectEnd, so a: func b, {c: d}, e: f g h: e  can be rewrite correctly, too. of course I'm not satisfy with it too.
for rewriting in recursively, I used something like
extend: (force_complex = false)->
    new_tokens = []
    while token = @tokens.shift()
      if tokenMatchCondition
        value      = shiftTokens @tokens
        old_tokens = @tokens
        @tokens    = value
        @extend(true)
        value      = @tokens
        @tokens    = old_tokens
        pushTokens new_tokens, value
      else
        new_tokens.push token
    @tokens = new_tokens

to solve reursively in my branch of CoffeeScript, eg: convert
global.
  FOO: 1
  BAR: 2
  BAZ: baz.{a: a, b, c}

to
global.FOO = 1;

global.BAR = 2;

global.BAZ = __ts_extend(baz, "a", a, "b", b, "c", c);

Use recursion is  easier way to rewrite in recursively I think.

I'm working on this. I think I may be done with the first step which requires a bit of refactoring to allow recursive calls into either addBraces or addParentheses.
Tests are passing. The next step is to fill in the addParentheses code.
I could use a little review at this point before I continue. Thanks.
https://github.com/jaekwon/coffee-script/commit/c50215413ba1e5ace609b601090cafa12c938cf8

Did I parse the following correctly?
a: func b, {c: d}, e: f g h: e
{ a: func( b, { c: d }, { e: f( g, h ), h: e } ) }

After a new implicit object has been added, you have to rewind a couple of tokens to make sure that the implicit object isn't forcing an implicit call.

I'm not sure what the implicit object here is referring to. If it refers to h: e, that isn't a new implicit object but just an extension of an existing implicit object. Am I parsing the line wrong somehow?

Actually, without a comma before the h: e, it would have to be an implicit call, right?
a: func b, {c: d}, e: f g h: e
{ a: func( b, { c: d }, { e: f( g( { h: e } ) ) } ) }  // I think this is the only acceptable parse.

With a comma before h: e, it's ambiguous.
a: func b, {c: d}, e: f g, h: e
{ a: func( b, { c: d }, { e: f( g, { h: e } ) } ) }  # current behavior after patch above
{ a: func( b, { c: d }, { e: f( g ), h: e } ) }       # desired behavior


List all accounts in the service

As a user of the application
I need to list all accounts in the service
So that I can view a comprehensive list of available accounts
Details and Assumptions

The service stores multiple account records that need to be listed.

Acceptance Criteria
Given I want to view all available accounts
When I request to list all accounts
Then I receive a complete list of accounts


Updating already approved ADRs

These commits bring the things we've already agreed out of Google Drive and into ADRs.
I've renumbered one of the existing ones so that the numeric ordering is still consistent with chronological (and hence reading) order.

Codecov Report

Merging #48 into master will decrease coverage by 4.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   72.10%   67.74%   -4.36%
==========================================
  Files          86       90       +4
  Lines        3140     3389     +249
  Branches      197      219      +22
==========================================
+ Hits         2264     2296      +32
- Misses        816     1031     +215
- Partials       60       62       +2

Impacted Files
Coverage Δ

regulations/serializers.py
1.12% <0.00%> (-94.39%)
:arrow_down:

footnotes/models.py
26.58% <0.00%> (-0.35%)
:arrow_down:

commodities/serializers.py
2.56% <0.00%> (ø)

importer/management/commands/import_taric.py
75.86% <0.00%> (ø)

commodities/tests/test_importer.py
69.38% <0.00%> (ø)

importer/taric.py
41.53% <0.00%> (ø)

commodities/import_handlers.py
12.65% <0.00%> (ø)

geo_areas/models.py
22.80% <0.00%> (+0.39%)
:arrow_up:

commodities/models.py
26.59% <0.00%> (+1.06%)
:arrow_up:

importer/handlers.py
56.81% <0.00%> (+1.74%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c73ba5...2cad889. Read the comment docs.

I wouldn't expect this to affect coverage 🤔 - maybe need to tweak setup.cfg to omit docs/
All looks good to me, just one question: the implementation of some of these deviates from what is described in the ADR - should we modify the ADR to reflect reality, or append to them, explaining the deviation?

I think the idea is meant to be that we keep these the same and then create new ones where we supersede these decisions. I've got a few more coming but it might good if you could jot down where the deviations are so that I've not missed anything?

I initially agreed with adding new ADRs to update historical ones. But on reflection having out of date documentation is never a good thing. I reckon it is better to update them to reflect the current situation, The history would be available in git anyway (not with the new ones... but not sure how much that matters)

ADRs that are superseded should have their status updated to link to the new one, and the new ADR should link back:
# 7. Changes go through a stateful workflow

Date: 2020-06-02

## Status

Approved

Supercedes [5. Use tracked models and workbaskets](0005-use-model-tracking-and-workbaskets.md)

and
# 5. Use tracked models and workbaskets

Date: 2020-05-21

## Status

Superceded by [7. Changes go through a stateful workflow](0007-changes-go-through-a-stateful-workflow.md)

as described on Michael Nygard's original article

I've updated with the suggestions, and as discussed kept some things that "aren't true" if we update them in a later ADR.


Advanced Duplicator support

Can we get it?
Every time its pasted from an advanced dupe, it just defaults to 1337, as well as not activating anything.

Just code it:
-- Handling Duplications
local function dooEet(ply, ent, stuff)
if (ent.isFadingDoor) then
ent:fadeDeactivate();
onRemove(ent)
else
ent.isFadingDoor = true;
ent.fadeActivate = fadeActivate;
ent.fadeDeactivate = fadeDeactivate;
ent.fadeToggleActive = fadeToggleActive;
ent:CallOnRemove("Fading Door", onRemove);
if (WireLib) then
doWireInputs(ent);
doWireOutputs(ent);
ent.fadeTriggerInput = ent.fadeTriggerInput or ent.TriggerInput;
ent.TriggerInput = TriggerInput;
if (not ent.IsWire) then -- Dupe Support
ent.fadePreEntityCopy = ent.PreEntityCopy;
ent.PreEntityCopy = PreEntityCopy;
ent.fadePostEntityPaste = ent.PostEntityPaste;
ent.PostEntityPaste = PostEntityPaste;
end
end
end
ent.fadeUpNum = numpad.OnUp(ply, stuff.key, "Fading Door onUp", ent);
ent.fadeDownNum = numpad.OnDown(ply, stuff.key, "Fading Door onDown", ent);
ent.fadeToggle = stuff.toggle;
ent.noEffect = stuff.noeffect;
if (stuff.reversed) then
ent:fadeActivate();
end
duplicator.StoreEntityModifier(ent, "Fading Door", stuff);
return true;
end
duplicator.RegisterEntityModifier("Fading Door", dooEet);

Example from Fading door.

Also wanted this, created fork and fixed the issue. Review pull request #18


Programmatically build workflow definitions with fluent api

What would you like to be added:
Provide a fluent builder API to build the Serverless Workflow, example:
Workflow.
    Name("Beaker").
    withState("operation").eventRef()....
    Build()

Why is this needed:

for reference: https://pkg.go.dev/github.com/lann/builder#section-readme

yep, we assign it to @ribeiromiranda :)


Allow decode functions to decode a &[u8] (fixes #16)

This is not a breaking change.

ty!

Thanks for the minor release!
Your crate is now in Servo's tree. :)
https://github.com/servo/servo/pull/16137


TB: more fail tests (mostly shared with SB)

Although it was not in the tests, mem::transmute works for UnsafeCell -> & as well.
Draft: will also introduce more test cases for cases that fail.
Draft: depends on the new error messages from #2888

@rustbot author

Selection of fail tests to run both TB and SB is done, I'll push when I've verified all the errors

Oh, you are doing this for all fail tests now, wow. Time to rename the PR I guess? :D

Error messages updated after the merge of #2888.
Waiting for comments on

structure (I picked tests/fail/{tree,stacked,both}_borrows which minimizes files moved around, but we could also replicate the src structure with tests/fail/borrow_tracker/{tree_borrows,stacked_borrows,}
coverage (is this enough tests ? are there more things that should be tested ?)
other wording details

Some renames have been wrongly detected as deletion+creation. I can eventually make sure that git properly sees that it's all already existing files

Some renames have been wrongly detected as deletion+creation. I can eventually make sure that git properly sees that it's all already existing files

git decides this via some heuristic, the data model doesn't even distinguish these cases so this is git diff making the decisions. I am not aware of a way to fix this. It's also not a big deal though.

structure (I picked tests/fail/{tree,stacked,both}_borrows which minimizes files moved around, but we could also replicate the src structure with tests/fail/borrow_tracker/{tree_borrows,stacked_borrows,}

Hm... in pass we have {tree,stacked}-borrows so let's match that I guess? Though _ seems more consistent indeed.
both_borrows sounds a bit odd but I also can't think of anything better. :shrug:

coverage (is this enough tests ? are there more things that should be tested ?)

Coverage looks pretty good to me. Which tests did you not copy over from fail/stacked_borrows?

Oh no, need to rebase.
Fixes (2ebc752) is the first commit after we talked yesterday.
The only conflict seems to be the addition of #![allow(cast_ref_to_mut)] in tests/fail/shr_frozen_violation1.rs, it has been replicated in tests/fail/both_borrows/shr_frozen_violation1.rs. The newly added tests/fail/tree_borrows/write_to_shr.rs exhibits exactly the same issue and has also received an #[allow(_)].

That is everything we discussed taken care of, I assume?
All right, then please squash the history a bit (or entirely). Then you can run bors r=RalfJung.
@bors delegate

Or you could if I could type the right command...
@bors delegate+

@bors ping

:sleepy: I'm awake I'm awake

@bors delegate=Vanille-N

@bors delegate+

This is ready to land now anyway. :shrug: Let's see if that works...
@bors r+

:pushpin: Commit 05640c48b11508a33b471d5e00f0f8072d8dba58 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 05640c48b11508a33b471d5e00f0f8072d8dba58 with merge 18662daaa575050ed4217eb4ac75e2cc11814ec7...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 18662daaa575050ed4217eb4ac75e2cc11814ec7 to master...


when one member of a cluster is restarted, it won't rejoin to the cluster automatically

just as the title said, this can be annoy as we have to rejoin the node to cluster by manual
Expected Behavior
when restart a node, it should rejoin the cluster automatically
Current Behavior
it's expected to rejoin the old cluster without any extra operations
Possible Solution
~I have no idea here~
Steps to Reproduce (for bugs)

I'm using CouchDB for this project OpenWhisk, to deploy a CouchDB cluster:

git clone https://github.com/apache/incubator-openwhisk
cd incubator-openwhisk/ansible
# edit the inventory file ansible/environments/distributed/hosts, add 3 nodes under the [db] section
ansible-playbook -i environments/distributed/hosts couchdb.yml

restart the 3rd node or any other node else
call the _membership API againt node1/node2, it will show result like below:

{"all_nodes":["couchdb@x.x.x.x","couchdb@y.y.y.y"],"cluster_nodes":["couchdb@x.x.x.x","couchdb<EMAIL_ADDRESS>
and the node3 will return:
{"all_nodes":["couchdb@z.z.z.z"],"cluster_nodes":["couchdb@x.x.x.x","couchdb<EMAIL_ADDRESS>
So the node3 left the cluster, and doesn't go back
Context
Your Environment
the version of CouchDB is 2.1
it's running in docker, and its image is apache/couchdb:2.1: https://hub.docker.com/_/couchdb/

@jiangpengcheng Did you configure the cookie for the cluster?

This sounds like a problem with the OpenWhisk ansible playbook - you'll need to talk to them, sorry.

Steps to Reproduce (for bugs)

~I'm using CouchDB for this project OpenWhisk, to deploy a CouchDB cluster~ Now I use docker only, create couchdb containers on 3 nodes:
# node1
docker run -d --name couchdb -e COUCHDB_USER=couch_user -e COUCHDB_PASSWORD=couch_password -e NODENAME=<IP_ADDRESS> -p 5984:5984 -p 4369:4369 -p 9100:9100 apache/couchdb:2.1

# node2
docker run -d --name couchdb -e COUCHDB_USER=couch_user -e COUCHDB_PASSWORD=couch_password -e NODENAME=<IP_ADDRESS> -p 5984:5984 -p 4369:4369 -p 9100:9100 apache/couchdb:2.1

# node3
docker run -d --name couchdb -e COUCHDB_USER=couch_user -e COUCHDB_PASSWORD=couch_password -e NODENAME=<IP_ADDRESS> -p 5984:5984 -p 4369:4369 -p 9100:9100 apache/couchdb:2.1

setup the cluster
I follow this guide, and use node1 as the “setup coordination node”
Below command returned an error, so I skipped this command:
curl -X POST -H "Content-Type: application/json" http://couch_user:couch_password@<IP_ADDRESS>:5984/_cluster_setup -d '{"action": "enable_cluster", "bind_address":"<IP_ADDRESS>", "username": "couch_user", "password":"couch_password", "node_count":"3"}'
{"error":"bad_request","reason":"Cluster is already enabled"}

# add node2 to cluster
curl -X POST -H "Content-Type: application/json" http://couch_user:couch_password@<IP_ADDRESS>:5984/_cluster_setup -d '{"action": "enable_cluster", "bind_address":"<IP_ADDRESS>", "username": "couch_user", "password":"couch_password", "port": 5984, "node_count": "3", "remote_node": "<IP_ADDRESS>", "remote_current_user": "couch_user", "remote_current_password": "couch_password" }'
{"ok":true}

curl -X POST -H "Content-Type: application/json" http://couch_user:couch_password@<IP_ADDRESS>:5984/_cluster_setup -d '{"action": "add_node", "host":"<IP_ADDRESS>", "port": "5984", "username": "couch_user", "password":"couch_password"}'
{"ok":true}

# add node3 to cluster
curl -X POST -H "Content-Type: application/json"
http://couch_user:couch_password@<IP_ADDRESS>:5984/_cluster_setup -d '{"action": "enable_cluster", "bind_address":"<IP_ADDRESS>", "username": "couch_user", "password":"couch_password", "port": 5984, "node_count": "3", "remote_node": "<IP_ADDRESS>", "remote_current_user": "couch_user", "remote_current_password": "couch_password" }'
{"ok":true}

curl -X POST -H "Content-Type: application/json"
http://couch_user:couch_password@<IP_ADDRESS>:5984/_cluster_setup -d '{"action": "add_node", "host":"<IP_ADDRESS>", "port": "5984", "username": "couch_user", "password":"couch_password"}'
{"ok":true}

# finish cluster
curl -X POST -H "Content-Type: application/json" http://couch_user:couch_password@<IP_ADDRESS>:5984/_cluster_setup -d '{"action": "finish_cluster"}'
{"ok":true}

the cluster was formed correctly:
curl -X GET http://couch_user:couch_password@<IP_ADDRESS>:5984/_membership
{"all_nodes":["couchdb@<IP_ADDRESS>","couchdb@<IP_ADDRESS>","couchdb@<IP_ADDRESS>"],"cluster_nodes":["couchdb@<IP_ADDRESS>","couchdb<EMAIL_ADDRESS>

restart the 3rd node

call the _membership API againt node1/node2, the result was:
{"all_nodes":["couchdb@<IP_ADDRESS>","couchdb@<IP_ADDRESS>"],"cluster_nodes":["couchdb@<IP_ADDRESS>","couchdb<EMAIL_ADDRESS>
and the node3 returned:
{"all_nodes":["couchdb@<IP_ADDRESS>"],"cluster_nodes":["couchdb@<IP_ADDRESS>","couchdb<EMAIL_ADDRESS>
we can see that the node3 has left the cluster

Context
A strange thing is that when I restarted the node1, it can rejoin the cluster, seems there is something special in the “setup coordination node”.
So I cleaned the env, recreated 3 couchdb containers and use node2 as the “setup coordination node” this time, and find out that the node2 can rejoin the cluster automatically while node1 and node3 can not, this is confusing
@wohali Could you please check this when you have some time? Many thanks

How are you restarting the container?
If you are not externalising the etc/local.d and data/ directories, as explained in the Docker README, the node will lose its configuration.
Please share the contents of your *.ini files on all 3 nodes.

I use command docker restart couchdb
I didn't mount any configuration files to containers, so the default.ini and local.ini are identical in all three nodes, below are contentns of local.d/local.ini:
#node1
[chttpd]
bind_address = any
[httpd]
bind_address = any
[admins]
couch_user = -pbkdf2-aa811c26cee3d5b8392e2c022b8a3f23b5558e6a,c2ee49b331678afc5489e68227c83ce5,10
[couchdb]
uuid = 54fcccdf6afdfd1ca16fc6992f72085a

#node2
[chttpd]
bind_address = any
[httpd]
bind_address = any
[admins]
couch_user = -pbkdf2-e835df2896881bcdac7961176e8f9e8eb0072df1,9fe22744e324c2337f4552eae646411a,10
[couchdb]
uuid = ba8ae822d83b5747749327c7c0658cba

#node3
[chttpd]
bind_address = any
[httpd]
bind_address = any
[admins]
couch_user = -pbkdf2-85e99acc676e998f801922cadfe0b46f703e8b9e,f28bbc54fab83e0d921a24cf63e5653d,10
[couchdb]
uuid = 67d9b8603d12b487f6ff600842a7c4a0

the only difference is the couch_user option

Now I get it, need configure this https://github.com/apache/couchdb/blob/master/rel/overlay/etc/vm.args#L34

should we add this option(https://github.com/apache/couchdb/blob/master/rel/overlay/etc/vm.args#L34) to the docker image? or make it configurable via env?

Glad your problem is solved!
FYI, you can already persist this setting with CouchDB - you need to mount the etc/vm.args file via a -v flag to docker run.
We're not going to support any more runtime options other than the basics via the init script / by env, the proper way to configure the CouchDB docker image is via external files you mount in. You want to persist these, anyway.
If you have any other ideas for the Docker image, use the tracker at https://github.com/apache/couchdb-docker/issues instead. Thanks!


Various tsconfig.json and package.json updates

Benefits of this PR:

squiggle-lang is 10% faster in synthetic benchmarks because we compile to es2022 now (should be ok on all modern browsers)
Possible reasons for the speedup: maybe native object spread syntax, or maybe "use strict" mode.

We now use project references and tsc -b everywhere (except in Hub, because Next.js bundler doesn't support project references).

This means that dev builds (when you call tsc -b or pnpm build:ts) are sometimes faster and benefit from dependencies caching.
It also means that you can run tsc -b in components and squiggle-lang + ui will be rebuilt automatically. (if squiggle-lang's JS peggy parser is already generated... So turbo build is still a safer option).

declarationMap is enabled everywhere, so if you "go to definition" for e.g. SqValue when you're working on components, it will go to the original .ts file, and not to .d.ts file.

Configuration for squiggle-lang is now split into tsconfig.esm.json and tsconfig.tests.json (again, with project references). This allows us to bundle dist/esm/*.js on NPM instead of awkward dist/src/esm/*.js.

All NPM packages use "files" field instead of .npmignore. In other words, we whitelist published files instead of blacklisting them.

We still publish all sources and all source maps, and in some cases the overall install size is larger because we didn't publish some source maps before.
But the resulting package is much cleaner (e.g., @quri/squiggle-lang 0.7.0 included .nyc-output and .turbo logs).

I've removed some default or incorrect tsconfig settings (most of them were cargo-cultish), and added some stricter ones. The most significant one of these is "noImplicitOverride": true for squiggle-lang.


HDDS-7277. [Snapshot] Implement snapshot key listing in Ozone Shell

What changes were proposed in this pull request?
This error was coming from OzoneAddress.ensureBucketAddress() but if we were to modify that method to accept the snapshot name as part of the keyName while checking a bucket path, then every bucket command would accept a snapshot path appended to it. Therefore, a new method was added under OzoneAddress called ensureSnapshotAddress(). This method will accept both a bucket and snapshot but it will only be used with the ozone sh key list command so that there won't be any unpredictable behavior from other commands.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7277
How was this patch tested?
A new unit test was added for checking the snapshot address. Also, this patch was tested manually in a docker cluster like so
in /hadoop-ozone/dist/target/ozone-1.3.0-SNAPSHOT/compose/ozone
❯ docker-compose up --scale datanode=3 -d

❯ docker exec -it ozone_om_1 bash
bash-4.2$ ozone sh volume create /vol1
bash-4.2$ ozone sh bucket create /vol1/bucket1
bash-4.2$ ozone sh key put /vol1/bucket1/key1 /etc/hosts
bash-4.2$ ozone sh key put /vol1/bucket1/dir1/key2 /etc/os-release
bash-4.2$ ozone sh snapshot create /vol1/bucket1 snap1
bash-4.2$ ozone sh key list /vol1/bucket1/.snapshot/snap1
[ {
  "volumeName" : "vol1",
  "bucketName" : "bucket1",
  "name" : ".snapshot/snap1/dir1/key2",
  "dataSize" : 393,
  "creationTime" : "2023-01-12T15:03:53.014Z",
  "modificationTime" : "2023-01-12T15:03:53.774Z",
  "replicationConfig" : {
    "replicationFactor" : "THREE",
    "requiredNodes" : 3,
    "replicationType" : "RATIS"
  }
}, {
  "volumeName" : "vol1",
  "bucketName" : "bucket1",
  "name" : ".snapshot/snap1/key1",
  "dataSize" : 174,
  "creationTime" : "2023-01-12T15:03:37.940Z",
  "modificationTime" : "2023-01-12T15:03:38.927Z",
  "replicationConfig" : {
    "replicationFactor" : "THREE",
    "requiredNodes" : 3,
    "replicationType" : "RATIS"
  }
} ]
bash-4.2$ ozone sh key list --prefix=dir1 /vol1/bucket1/.snapshot/snap1
[ {
  "volumeName" : "vol1",
  "bucketName" : "bucket1",
  "name" : ".snapshot/snap1/dir1/key2",
  "dataSize" : 393,
  "creationTime" : "2023-01-12T15:03:53.014Z",
  "modificationTime" : "2023-01-12T15:03:53.774Z",
  "replicationConfig" : {
    "replicationFactor" : "THREE",
    "requiredNodes" : 3,
    "replicationType" : "RATIS"
  }
} ]
bash-4.2$ ozone sh key list --prefix=.snapshot/snap1/dir1 /vol1/bucket1
[ {
  "volumeName" : "vol1",
  "bucketName" : "bucket1",
  "name" : ".snapshot/snap1/dir1/key2",
  "dataSize" : 393,
  "creationTime" : "2023-01-12T15:03:53.014Z",
  "modificationTime" : "2023-01-12T15:03:53.774Z",
  "replicationConfig" : {
    "replicationFactor" : "THREE",
    "requiredNodes" : 3,
    "replicationType" : "RATIS"
  }
} ]

@smengcl @sadanand48 Can you please take a look at this PR?

@GeorgeJahad I made some changes and now it works with the ozone sh key list command. Could you take another look at this?

+1 LGTM

@hemantk-12 Would this approach seem cleaner? That's from commit 5509ccd365232933fc51c0a688a61a4e2d5d4699

@hemantk-12 Would this approach seem cleaner? That's from commit 5509ccd.

TBH, I'm not sure if that it clearen either. To me, ListKeyHandler should be independent of bucketPath or snapshotPath. You can have different internal implementations of ListKeyHandler based on path type is bucket or snapshot if needed but high level it should be independent.
As I said earlier, SnapshotHandler says that it is to handle snapshot reqeust like snapshot create, delete or list snapshot not listing the keys from snapshot.
Again this is what I think based on my experience with Ozone so far. May be @smengcl or @prashantpogde can look and help us here.

@hemantk-12 Would this approach seem cleaner? That's from commit 5509ccd.

Hi @xBis7 , looks like this approach is add a brand new subcommand to Ozone Shell? If this is the case it is not desired, as we do want a unified interface for listing under regular buckets and snapshotted ones.
On the other hand, I agree with @hemantk-12 that we should try to keep using the previous BucketHandler here. Or maybe we could rename SnapshotHandler into something like BucketAndSnapshotHandler in order not to give the wrong impression?

@hemantk-12 @smengcl Thanks for the reviews, I've updated the patch. I get your point about the SnapshotHandler class.

You can have different internal implementations of ListKeyHandler based on path type is bucket or snapshot if needed but high level it should be independent.

This would be the best, but we would have to reorganize all Handler classes and that would require changes across all shell commands. If we are to go that way, it should be in another PR.

we could rename SnapshotHandler into something like BucketAndSnapshotHandler in order not to give the wrong impression?

This seemed the easiest approach, so I renamed the class to BucketSnapshotHandler.

@hemantk-12 @smengcl Thanks for the reviews, I've updated the patch. I get your point about the SnapshotHandler class.

You can have different internal implementations of ListKeyHandler based on path type is bucket or snapshot if needed but high level it should be independent.

This would be the best, but we would have to reorganize all Handler classes and that would require changes across all shell commands. If we are to go that way, it should be in another PR.

we could rename SnapshotHandler into something like BucketAndSnapshotHandler in order not to give the wrong impression?

This seemed the easiest approach, so I renamed the class to BucketSnapshotHandler.

Doing it as part of another PR is completely fine by me.
Thanks for change the name.

LGTM.
Feel free to merge once Siyao approves it.

Thanks @xBis7 for the patch. Thanks @GeorgeJahad @hemantk-12 for the reviews.

@smengcl @hemantk-12 @GeorgeJahad Thanks for the reviews!


Data pre-processing

Hello sir,
I'm getting difficulties in data pre-processing as the dataset is in png format and we are working on video. Please help me load data, pre-processing it, and preview it as a video or gif.
Thanks

Hi @priyansh1221

I will give you help on how you should go about reading the videos.
The following example shows the mechanism by which a single video is read and the results are stored in an array.
You should extend the work of the script so that you can read all the videos included in the dataset, in addition to the mechanism that you can skip a specified number of frames in order to read all videos of the same length (with the same number of frames), and you can do this by reading more about VideoCapture
Good luck

import cv2
video_file_path = ''
image_height = 60
image_width = 60
video_reader = cv2.VideoCapture(video_file_path)
success, frame = video_reader.read()
previous = frame.copy()
frames_queue = []
while video_reader.isOpened():
    ok, frame = video_reader.read()
    if not ok:
        break
    diff = cv2.absdiff(frame, previous)
    f = cv2.resize(diff, (image_height, image_width))
    f = cv2.cvtColor(f, cv2.COLOR_BGR2GRAY)
    previous = frame.copy()
    normalized_frame = f / 255
    frames_queue.append(normalized_frame)
video_reader.release()


Need nil check for block because some points don't pass block

For example, this point doesn't pass block: https://github.com/zendesk/ruby-kafka/blob/7ffcf2c953b3560014c9312533e6a7eed8663fb4/lib/kafka/producer.rb#L207

Test failure on Circle-CI seems to not relate my patch.

Thanks! I'll review these PRs once I'm back from vacation next week.

:heart:


Memory limits reached when uploading osa-loyalty app

/admin/osa/launcher/app/post --> Exceeded soft private memory limit of 256 MB with 361 MB after servicing 13605 requests total

Does this mean that the handler of /admin/osa/launcher/app/post is the cause of this memory problem?
Or it's just happened when serving a request to /admin/osa/launcher/app/post?
I'm hardly getting what is really meant by this error.

I see a little improvement if the uploads to gcs are done in chunks if possible (if it's not already done this way).

Don't know if uploading the file is the main reason.
Now the file is written to gcs in chunks.

Don't know if uploading the file is the main reason, but now the file is written to gcs in chunks.

Works as a charm


client waits for server response before sending next request

Describe the bug
my server does not receive the next request before sending response to the client
To Reproduce
Steps to reproduce the behavior:

Expected behavior
like angular http

works also fine when using 'ionic serve'
Screenshots
what happens :

Smartphone (please complete the following information):

Device: Redmi note 7 Android 10

Additional context
Add any other context about the problem here.
Can someone help ? i'm not sure if i'm doing something wrong.
thanks a lot.

I have the same problem, it only happens to me on android

I believe PR #65 fixes this. If the upcoming 0.3.0 version does not fix this issue, feel free to re-open this issue

I believe PR #65 fixes this. If the upcoming 0.3.0 version does not fix this issue, feel free to re-open this issue


[Help, not a bug or issue] Crossfade effects

Hi guys, I need some crossfade effects to apply and switch between PIXI.Container.
do you have some private collections to share :satisfied:? online examples, shaders would be great.
for example Three.js crossfade between multiple scenes: https://threejs.org/examples/?q=cross#webgl_postprocessing_crossfade
:gift:

close as no response :sob:


basic destructuring for tuples and entries

[@gavinking] For Ceylon 1.2, we should consider supporting very basic destructuring for tuples and entries, both for specification statements:
    [Integer i, Float... xs] = [1, 1.0, 2.0, 3.0];
    String s->Person p = s->p;

And for for loops:
    for ([x,y] in pairs) {}
    for ([Float x, Float y] in pairs) {}

(We already have destructuring for Entrys in for.)
[Migrated from ceylon/ceylon-spec#520]
[Closed at 2014-12-21 23:51:34]

So, there are two different regular "styles" of destructuring:
[value a, value b, value c] = foo;

[String a, Integer b, Float c] = foo;

value a->value b = foo;

Integer a->String b = foo;

value [a, b, c] = foo;

[String, Integer, Float] [a, b, c] = foo;

value a->b = foo;

Integer->String a->b = foo;

If you asked me, I'd really prefer the second syntax, besides it being arguably uglier, by syntactically separating the declared value from its type. I feel like, for me, in this case, the regularity would be more valuable than the aesthetics...
The way it's currently done, I feel, is just dumping regularity and picking-and-choosing parts of the two different styles that look better for different purposes, which, for me, feels kinda clunky. It's like one of those weird features that try to be and look regular, but just aren't at all...

In response to @Zambonifofex's ancient comment, for the sake of archaeologists:
First: the syntax [value a, value b, value c] is awful, so awful that it would have made destructuring not useful. I don't think that anyone is seriously going to accept that or want to write code using that syntax.
Second: the syntax [String, Integer, Float] [a, b, c] is much less unreasonable, but suffers from several problems:

It's noisier, requiring four additional tokens.
It separates the type declaration from the thing which has the type being declared.
I can't be explicit about some types, and leave others implicit.
The above problems get even worse when I nest patterns ``[String, Integer, [Float,Float]] [a, b, [c,d]]`, so it doesn't scale nicely.

Indeed, since type declarations in destructuring are always optional, and, in practice pretty much never used, harming the readability by making them noisier and harder to write and understand would guarantee that they're really never used.
But let's not discuss this any further on this closed issue.
Instead, see #6446 for further discussion in this area.
(P.S. @Zambonifofex you left your comment on an issue which had, at the time, already been closed for a whole year! Please don't do that.)


Simplify Raster.reproject

We could use the functionality in rasterio.warp.calculate_default_transform to make the calculation of the transform easier in Raster.reproject (I should have seen that earlier...):
https://rasterio.readthedocs.io/en/latest/api/rasterio.warp.html#rasterio.warp.calculate_default_transform
SOme additional details from the rasterio discussion group: "The intent is that rasterio.warp.reproject, given the values output from calculate_default_transform, will produce a result close to that of GDAL's gdalwarp utility without its "-tap" option. And that if you wrap the output of calculate_default_transform with aligned_target, adding a resolution, you will get a result close to that of gdalwarp with its "-tap" option."

This is actually a bit more complex than anticipated, as the functions calculate_default_transform and aligned_target only take into account the input transform, width and height, but not the output bounds.
Obtaining a result similar to what is done in reproject for now (and similar to gdalwarp), but using rasterio's functions seem non trivial for now.

GDAL's logic for default warping options is coded around here https://github.com/OSGeo/gdal/blob/d01976cd4fc11144662f44ec4e658ce1871f1713/gdal/apps/gdalwarp_lib.cpp#L3105

I might add here that #354 is still an issue with our current method when passing dst_bounds and dst_res (or dst_size) individually. See #356


Sent message is not received

A sent message is not received by receiver, but on the device it shows with one checkmark (that should mean that it is received by Whatsapp server). Messages sent in this chat after that will be delivered just fine with two check marks, but the problematic message will still be with one checkmark.
Has anyone else experience this?
After receiving status 2 (one checkmark), retry is fired but nothing happens after

+1

bump

up

more info please

Today I had a similar problem, Baileys sent the message, the cell phone received it but another application that runs Baileys didn't receive the message, I thought it was strange, I'm analyzing logs to see if I can find the problem, detail that this happened with WhatsApp numbers that didn't These are cell phones but business or residential numbers, I am analyzing the logs I have to check for possible errors

Happens with me too, although rarely. Message is shown as sent but with only one checkmark and the receiver never receives it, even though he/she is connected to the internet at the time of sending.

I figured that when this happens, the receiver might see at as "Waiting for this message" or might not see it at all.

@PurpShell please help


[Fluent] Fixed issue with parallel creation of resources

Hi @anudeepsharma, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (ans). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

LGTM.
@anuchandy please sign off explicitly or merge if you are ok with the changes.

LGTM, merging


Added class to separate empty and full stars

I had modified star component to get this functionality. Hope it might be useful for the community too. Extra CSS was used to get this piece working.

@voronianski  Kindly recheck

@dhbalaji thanks!

Is there some css that is needed to get the spacing?  Should it be automatic?


AP CLI Config Workflow

Implemented workflow to interact with Central AP via CLI commands.
PR includes:

cli_config_workflow.py
Workflow for configuring Central Aps via CLI

ap_cli.py
Python class housing modules used for workflow.

Configurations
Directory with sample CLI configurations as usage examples.

-Media
Directory with flowchart images for main README.

Additions to central-python-workflows main README to include ap_config and flowchart.

The formatting on the README has large gaps, but the formatting for the additions are the same as the rest.  Feel free to leave feedback on how to fix this.

Wrong branch.