[swift-3.0-preview-5-branch] stdlib/Foundation: optimize the NSDictionary and NSSet copy-constructors

What's in this pull request?

Resolved bug number: (SR-)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

Builds the compiler incrementally.
Builds the standard library only for macOS. Simulator standard libraries and
device standard libraries are not built.
lldb is not built.
The test and validation-test targets are run only for macOS. The optimized
version of these tests are not run.

A smoke test on Linux does the following:

Builds the compiler incrementally.
Builds the standard library incrementally.
lldb is built incrementally.
The swift test and validation-test targets are run. The optimized version of these
tests are not run.
lldb is tested.

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

rdar://problem/27678985

@swift-ci Please test

I suggested that we take this improvement for preview 5 so that we get more feedback, if there are any issues with it.  (But it looks straightforward to me.)

I need to update the source as the MemoryLayout source change is not in this branch

It would need a considerable rewrite (compared to the change pulled in into swift-3.0), because also the UnsafePointer API is still the old one. Considering this, it doesn't make much sense to merge this change into the preview5 branch.
Closing.


how to install it?

It's great that there is such a module, but how to install it?

@llamafilm did you ever get this working?  I'm not seeing a request history in Slack asking for this module to be checked and added to the betas.

Yes it works for making a route. I haven’t had any trouble with it.
I’m not familiar with the process of adding it to beta. I just keep the folder inside module-local-dev.

Ok.  One of the issues I see with releasing this as-is is that it doesn't support a password.  TELNET and CTP can have a password prompt if set, and I know this because all IP devices we deployed when I worked at a university required CTP to be password protected.  If I were a betting man and we put this out, adding password support will be one of the first tickets.  Any chance you can add a config field for that and test it?

I've just added a password option in https://github.com/bitfocus/companion-module-crestron-digitalmatrix/commit/a2528f3c1544c766cd26cfef875fc143782f01d2.  It works fine on my system, but it would be good to have some more testers.  I'm not sure if the telnet syntax is always the same across different models.

great, I have a matrix of 16. how should I try?  how to install dev?

Download this repo and place the companion-module-crestron-digitalmatrix folder inside module-local-dev folder (inside Companion folder) then restart Companion.

I still need to add support for bigger matrices. Currently you’ll only be able to route the first 8 sources and destinations.

please add instructions on how to install this module! I copied the folder along the way C:\Program Files\Companion\resources\module-legacy\manifests\companion-module-crestron-digitalmatrix-main
how do I add a module?

Running modules in developer mode is for advanced users only.  Instructions are here: https://github.com/bitfocus/companion/wiki/Developing-on-Windows-10
This is supposed to get easier with version 3, but I haven't had time to rewrite this module for v3 yet.

Ok I took some time to get this updated for v3.  So now the installation is much easier.  From the red launcher window, click the settings gear and set the developer modules path to any folder you like.  Then download the v3 branch and place the companion-module-crestron-digitalmatrix folder inside there.

it doesn't work, I did everything according to your words.

it can't be installed, why is it here? or post how to install it...

even after adding, i get errors
`error: node:internal/modules/cjs/loader:1078
throw err;
^
Error: Cannot find module '../../tcp'
Require stack:

D:\bitfocus\companion-module-crestron-digitalmatrix-main\index.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1075:15)
at Module._load (node:internal/modules/cjs/loader:920:27)
at Module.require (node:internal/modules/cjs/loader:1141:19)
at require (node:internal/modules/cjs/helpers:110:18)
at Object. (D:\bitfocus\companion-module-crestron-digitalmatrix-main\index.js:1:13)
at Module._compile (node:internal/modules/cjs/loader:1254:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
at Module.load (node:internal/modules/cjs/loader:1117:32)
at Module._load (node:internal/modules/cjs/loader:958:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'D:\bitfocus\companion-module-crestron-digitalmatrix-main\index.js'
]

}
Node.js v18.14.2
`

Does anyone know how to get this module to work? Please share


Black Screen on presenting TGCameraViewController

I had TGCameraViewController installed by CocoaPods and when I was presenting TGCameraViewController, it is showing me a black screen

Works when downloading TGCameraViewController classes without cocoapods

The problem comes from bundle ressources.
If you want to use cocoapods, you have tu to copy paste all resources of TGCameraViewController in your local bundle


Redesign NavBar

Related to https://github.com/tactilenews/100eyes/issues/1567

[x] Add new 100eyes logo
[x] Add new logo for settings page and relocate
[x] Add new logo for sign out and relocate
[x] Update color to new blue #002332
[x] add favicon

Closed via #1571


I wish /v1.1/docs/admin/kubelet/ did not appear in the search results, since it doesn't exist apparently

I wish /v1.1/docs/admin/kubelet/ did not appear in the search results, since it doesn't exist apparently.

versioned search results will disappear after the impending site re-indexing.


fix blank page if open configuration page with URL directly

Issue #, if available:
Description of changes:

fix blank page if open configuration page with URL directly

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Local yarn test:jest result.
Test Suites: 1 skipped, 40 passed, 40 of 41 total
Tests:       4 skipped, 176 passed, 180 total
Snapshots:   33 passed, 33 total
Time:        48.145s
Ran all test suites.
✨  Done in 51.00s.


Load generation

Adds sufficient plumbing to trigger load generation and monitor its progress through /metrics querying

:+1: overall, just that one comment about logging info.

:+1:


ARTEMIS-4617 upgrade JLine to 3.25.1

I had to remove the indirect dependency between the maven plugin and jline to avoid the maven plugin to parse some classes in jline that require experimental features on the JDK even when they are not in use.

According to this Jansi should be integrated into 3.25.x so we should be able to get ride of the Jansi dependency now.

@jbertram ohh.. jansi.. I think I reverted one change by accident... I will try to remove it now

this was previously discussed here: https://github.com/apache/activemq-artemis/pull/4790
this PR superseded #4790


Bump django to 4.0.6 and postgres to 14.4

Bump deps that required django > 2.2.28
Set AdmissionsConfig.default_auto_field for models to satisfy django warnings
Set AdmissionsConfig.name to full path as is now required
Removed deprecated django.conf.urls.url, replaced with re_path

NOTE: docker volume for postgres must be deleted before 14.4 will work after this has been deployed. If anyone knows a smarter approach than locating the docker volume, rm'ing it and running docker-compose up -d please let me know

Yeah, as you say the postgres image needs to be bumped. The process you describe, eg. delete the volume and docker-compose up -d will work for everyone on dev, but prod is set up a bit different.
The setup isn't strictly confidential, but I think it's better not to divulge all the settings, paths and procedures in this public repo. I'll make an issue in the infra repo and explain what needs to be done. It's not much.


Add: TNPI RFD to work projects

Published articles

Fixed with https://github.com/mbradds/me.dev/commit/96388dfd8b00275b7f9293da4ef6a52ea9c2c8e0


How to run the simple example with docker?

I built successfully a docker image in my local. And i want to runthe simple example by docker-compose which is mentioned in the README.md. But the woker saide that BistroWorkerHandler.cpp:755] Unable to send heartbeat to scheduler: Channel is !good()
Bellow is my docker-compose.yml
version: "3.2"
services:
  scheduler:
    image: bistro
    working_dir: "/home/bistro/bistro"
    command: ["./cmake/Debug/server/bistro_scheduler", "--server_port=6789", "--http_server_port=6790", "--config_file=scripts/test_configs/simple", "--clean_statuses", "--CAUTION_startup_wait_for_workers=1", "--instance_node_name=scheduler"]
    ports:
      - "6789:6789"
      - "6790:6790"

  worker:
    image: bistro
    working_dir: "/home/bistro/bistro"
    command: ["./cmake/Debug/worker/bistro_worker", "--server_port=27182", "--scheduler_host=scheduler", "--scheduler_port=6789", "--worker_command=$HOME/demo_bistro_task.sh", "--data_dir=."]
    ports:
      - "27182:27182"
    links:
      - scheduler
    depends_on:
      - scheduler

I tried following setting for scheduler_host, that all are not working.
 --scheduler_host=scheduler,  --scheduler_host=::,  --scheduler_host=<IP_ADDRESS>
What's the problem? Does anybody used the docker-compose?

Often you would want to define a network and use for all services to avoid such problems
https://docs.docker.com/compose/networking/


Question about reverse proxy

I use lua-resty-openidc for protecting some services in a docker environment. I’ve defined Nginx as a reverse proxy for protected Apps, everything works fine (in a really nice way).
Recently I would like to try the reverse proxy traefik.
Now I tested the reverse proxy traefik.
So, I put traefik in front of Nginx and traefik manage the ssl stuff. By this way Nginx is just here for protecting Apps and manage the OpenId Connect authentication.
But with this configuration it did not work.
server {
    listen       80;
    server_name  "kibana.acme.org";
    access_log off;

    location / {
        access_by_lua '
                local cjson = require "cjson"

                function inTable(tbl, item)
                    for key, value in pairs(tbl) do
                        if value == item then return key end
                    end
                    return false
                end

               local opts = {
                    redirect_uri_path = "/redirect_uri",
                    discovery = os.getenv("DISCOVERY"),
                    client_id = os.getenv("CLIENT_ID"),
                    client_secret = os.getenv("CLIENT_SECRET"),
                    scope = os.getenv("CLIENT_SCOPE"),
                    ssl_verify = os.getenv("SSL_VERIFY")
                }

                local res, err = require("resty.openidc").authenticate(opts)

                if err then
                    ngx.status = 500
                    ngx.say(err)
                    ngx.exit(ngx.HTTP_INTERNAL_SERVER_ERROR)
                end

                if inTable(res.user.role, "admin_kibana") == false then
                  ngx.exit(ngx.HTTP_FORBIDDEN)
                end
            ';

        proxy_pass         http://to_elk_kibana:5601;
    }
}

Another strange thing I’ve seen during my tests. Each time the browser makes a GET request on a protected App, lua-resty-openidc make a call to the OpenId Connect Provider. I don’t know if it’s a normal behavior or a settings mistake?

 It would mean adding something similar as:
https://github.com/pingidentity/lua-resty-openidc/blob/master/lib/resty/openidc.lua#L138
for the X-Forwarded-Host header.
Not sure about 2nd issue; perhaps a debug log would make it clear what that call is.

Thank for the quick answer.
How can I configure a debug log for nginx?

http://nginx.org/en/docs/debugging_log.html

I've found the roots of the issue.
It is stupidly a question of cookie. Since I have put a secret for resty.session, everything work fine !


treewide: migrate to the new rust fetcher

Followup of https://github.com/NixOS/nixpkgs/pull/349360
CC: https://github.com/NixOS/nixpkgs/issues/327063
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I tried to migrate the cosmic packages like https://github.com/NixOS/nixpkgs/blob/e2b0cccf5508f35c234ab79dc29c471e60825d7c/pkgs/by-name/co/cosmic-applets/package.nix#L28 . But some of them failed, could you check @TomaSajt ?

       > Unpacking to /nix/store/2qzby0ikws1xcach4ckvlq4bi7268y4w-cosmic-applets-1.0.0-alpha.1-vendor/i18n-embed-fl-0.6.7
       > Unpacking to /nix/store/2qzby0ikws1xcach4ckvlq4bi7268y4w-cosmic-applets-1.0.0-alpha.1-vendor/i18n-embed-fl-0.8.0
       > Unpacking to /nix/store/2qzby0ikws1xcach4ckvlq4bi7268y4w-cosmic-applets-1.0.0-alpha.1-vendor/i18n-embed-impl-0.8.3
       > Unpacking to /nix/store/2qzby0ikws1xcach4ckvlq4bi7268y4w-cosmic-applets-1.0.0-alpha.1-vendor/iana-time-zone-0.1.60
       > Unpacking to /nix/store/2qzby0ikws1xcach4ckvlq4bi7268y4w-cosmic-applets-1.0.0-alpha.1-vendor/iana-time-zone-haiku-0.1.2
       > Traceback (most recent call last):
       >   File "/nix/store/d9ry6ifpm48hlsgs5xa6j1k1n11akbwf-fetch-cargo-vendor-util/bin/fetch-cargo-vendor-util", line 285, in <module>
       >     main()
       >   File "/nix/store/d9ry6ifpm48hlsgs5xa6j1k1n11akbwf-fetch-cargo-vendor-util/bin/fetch-cargo-vendor-util", line 281, in main
       >     subcommand_func()
       >   File "/nix/store/d9ry6ifpm48hlsgs5xa6j1k1n11akbwf-fetch-cargo-vendor-util/bin/fetch-cargo-vendor-util", line 273, in <lambda>
       >     "create-vendor": lambda: create_vendor(vendor_staging_dir=Path(sys.argv[2]), out_dir=Path(sys.argv[3]))
       >                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       >   File "/nix/store/d9ry6ifpm48hlsgs5xa6j1k1n11akbwf-fetch-cargo-vendor-util/bin/fetch-cargo-vendor-util", line 230, in create_vendor
       >     copy_and_patch_git_crate_subtree(git_tree, pkg["name"], crate_out_dir)
       >   File "/nix/store/d9ry6ifpm48hlsgs5xa6j1k1n11akbwf-fetch-cargo-vendor-util/bin/fetch-cargo-vendor-util", line 167, in copy_and_patch_git_crate_subtree
       >     crate_manifest_path = find_crate_manifest_in_tree(git_tree, crate_name)
       >                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       >   File "/nix/store/d9ry6ifpm48hlsgs5xa6j1k1n11akbwf-fetch-cargo-vendor-util/bin/fetch-cargo-vendor-util", line 163, in find_crate_manifest_in_tree
       >     raise Exception(f"Couldn't find manifest for crate {crate_name} inside {tree}.")
       > Exception: Couldn't find manifest for crate iced inside /nix/store/vqnd8w9d64flfvmmpi0l4z0p33098hpy-cosmic-applets-1.0.0-alpha.1-vendor-staging/git/4f77edd249e1c9cd525232050cec00c752ce7860.
       For full logs, run 'nix log /nix/store/ffcs6ds7s69rnq823r044h6ssxpd8fwb-cosmic-applets-1.0.0-alpha.1-vendor.drv'.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 356385

x86_64-linux

:x: 2 packages failed to build:

chiptrack
conduwuit

:white_check_mark: 6 packages built:

alfis
alfis-nogui
cloud-hypervisor
cloud-hypervisor.debug
mullvad
workstyle

I tried to migrate the cosmic packages like
https://github.com/NixOS/nixpkgs/blob/e2b0cccf5508f35c234ab79dc29c471e60825d7c/pkgs/by-name/co/cosmic-applets/package.nix#L28
. But some of them failed, could you check @TomaSajt ?

Seems like importCargoLock also fetches git submodules, but my fetchCargoVendor does not. Will look into it.

Looks like an false assumption on my part: I assumed fetchgit has fetchSubmodules set to false as a default, just like fetchFromGitHub.
It looks like it is not the case: fetchgit has fetchSubmodules = true by default.
Thanks for reporting the issue, will make a PR.
I checked, there shouldn't be more differences between the defaults of fetchgit and how I'm calling nix-prefetch-git

@ofborg build alfis workstyle mullvad chiptrack cloud-hypervisor conduwuit

@ofborg build cloud-hypervisor

@ofborg build cloud-hypervisor

Looks like a hash mismatch for cargoHash, could you take care of it for me and push? Not near a computer right now.

Consistently gets sha256-7wIt4Ul65i0rqwGdsCJNicaU8Vkv/3KbLohc/ybXiEs= locally and sha256-xqMUB9aqkUIpnX0U30CfiWmjDI7IS5SuJIKF5byXIxk= on ofborg...
very weird

Let's hold any mass migrations until this is resolved.
Very weird, only some packages are affected, in others the hash is rock solid.

@ofborg build cloud-hypervisor

I somehow reproduced the other hash locally, will do some testing to see what triggered it.
And yes, it seems like it is because of submodules.
The earlier hash did not fetch them, while the later one did.

By the way, did some searching and it looks like cargo respects a setting that would make certain git deps not fetch their submodules:
https://github.com/rust-lang/cargo/pull/10717
I don't think we should bother to respect that. The more files we fetch, the less likely it is that the current implementation can't handle some edge case.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 356385

aarch64-darwin

:fast_forward: 3 packages marked as broken and skipped:

alfis
chiptrack
mullvad

:white_check_mark: 3 packages built:

alfis-nogui
conduwuit
workstyle

Not sure if you intend to add more packages and which, but for e.g. zed-editor I migrated to the new fetcher in #356757 and it works fine.

There are still some kinks to iron out, but the submodule stuff should have been the last change that could actually change the hash.
Just opened https://github.com/NixOS/nixpkgs/pull/356821 which decreases the concurrency to some more sane values.

@ofborg build alfis workstyle mullvad chiptrack cloud-hypervisor conduwuit xdg-desktop-portal-cosmic

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 356385

x86_64-linux

:x: 4 packages failed to build:

cloud-hypervisor
cloud-hypervisor.debug
conduwuit
mullvad

:white_check_mark: 7 packages built:

alfis
alfis-nogui
chiptrack
cosmic-session
workstyle
xdg-desktop-portal-cosmic
xdg-desktop-portal-cosmic.debug

Not sure if you intend to add more packages and which

I do not intend to migrate all packages with a Cargo.lock in nixpkgs in this PR, in fact I think it's just more rebuild work, and the packages should be either mass migrated, or migrated when updating.
The packages listed here were decided randomly, and my goal was to find and iron out the bugs before the mass migration and adoption by other packages.

@TomaSajt when running nixpkgs-review.
┃        > The above exception was the direct cause of the following exception:
┃        >
┃        > Traceback (most recent call last):
┃        >   File "/nix/store/rhm7zn3pxrm6805v5fkbvyrxa53yf8fb-fetch-cargo-vendor-util/bin/fetch-cargo-vendor-util", line 283, in <module>
┃        >     main()
┃        >   File "/nix/store/rhm7zn3pxrm6805v5fkbvyrxa53yf8fb-fetch-cargo-vendor-util/bin/fetch-cargo-vendor-util", line 279, in main
┃        >     subcommand_func()
┃        >   File "/nix/store/rhm7zn3pxrm6805v5fkbvyrxa53yf8fb-fetch-cargo-vendor-util/bin/fetch-cargo-vendor-util", line 270, in <lambda>
┃        >     "create-vendor-staging": lambda: create_vendor_staging(lockfile_path=Path(sys.argv[2]), out_dir=Path(sys.argv[3])),
┃        >                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
┃        >   File "/nix/store/rhm7zn3pxrm6805v5fkbvyrxa53yf8fb-fetch-cargo-vendor-util/bin/fetch-cargo-vendor-util", line 133, in create_vendor_staging
┃        >     pool.starmap(download_tarball, tarball_args_gen)
┃        >   File "/nix/store/px2nj16i5gc3d4mnw5l1nclfdxhry61p-python3-3.12.7/lib/python3.12/multiprocessing/pool.py", line 375, in starmap
┃        >     return self._map_async(func, iterable, starmapstar, chunksize).get()
┃        >            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
┃        >   File "/nix/store/px2nj16i5gc3d4mnw5l1nclfdxhry61p-python3-3.12.7/lib/python3.12/multiprocessing/pool.py", line 774, in get
┃        >     raise self._value
┃        > requests.exceptions.ConnectionError: None: Max retries exceeded with url: /crates/rand_chacha/rand_chacha-0.3.1.crate (Caused by None)
┃        For full logs, run 'nix log /nix/store/vxnqpkg5h0x1sq63lp0x4iy0m5gn8pkd-cloud-hypervisor-42.0-vendor-staging.drv'.

There was a hash mismatch with cloud-hypervisor. Fixed.
@ofborg build alfis workstyle mullvad chiptrack cloud-hypervisor conduwuit xdg-desktop-portal-cosmic

There was a hash mismatch with cloud-hypervisor. Fixed. @ofborg build alfis workstyle mullvad chiptrack cloud-hypervisor conduwuit xdg-desktop-portal-cosmic

I guess you forgot to reset your branch to the upstream one, so you accidentally overrode my fixed hash with the outdated one when rebasing.
But it should be okay now.

@TomaSajt hypervisor and mullvad is failing to be built in nixpkgs-review (ran after garbage collecting) due to maximum no of retries hit (not because of a hash error)
https://termbin.com/3mz8

You could add a temporary commit on top of the PR that increases the retry count, like shown before.
And then use nixpkgs-review rev HEAD

Gonna merge this, since eval passed along with a nixpkgs-review


fix bra-ket typo in matrices

Changes
Fixes a pair of typos where kets are given instead of bras in some matrix definitions.

Implementation details

How to read this PR

Screenshots

Thank you!


Cube Fbos need test cases

The API for Cube Fbos is pretty much done. All that is remaining now is writing test cases for them.

And I'll take care of that.

:+1:

As of PR #165, this issue has been solved.


The Map API Key is now hidden.

Updating the Note and image to be in accordance with the other articles such as this one ce/field-service/perform-initial-configurations-setup.md (https://docs.microsoft.com/en-us/dynamics365/field-service/perform-initial-configurations-setup)

This doc has since been updated and should reflect the proper language. Closing this PR.


4.g.ii Number of User Stories Completed

A user should be able to see the number of completed stories.
Priority: LOW
Estimation: 1

Merged into user story #48


Fix typo

python -> Python

Learn Build status updates of commit 7149e72:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/machine-learning/migrate-to-v2-execution-pipeline.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


updates deprecated isNetworkError, isHttpError

gets rid of warning messages when using latest Unity 2020.2.x.

Thanks @mobyjames! I think it's better to wait a bit to merge, as some people are still relying on older versions of Unity (2019), which don't seem to support the .result property.

Thanks @mobyjames! I think it's better to wait a bit to merge, as some people are still relying on older versions of Unity (2019), which don't seem to support the .result property.

Handled in #170 !


essentials mod can't be used

When loading a game with essentials mod and armor stands it will no longer be able to be used or seen in a mod menu and you will not be able to even see it in the key binds.

From the developer on #17:

I'm going to assume you're referring to the microtransactions mod, in which case I don't think I can help you. I did some investigating and can't figure out where the compatibility issue is, but I assume it has something to do with Essential's very VERY non-standard and incredibly convoluted mod loading infrastructure. I was going to report the issue on their GitHub but it seems like they don't have the issue tracker enabled. I'm sorry but I'm not sure what else I can do for you.

Should be fixed with 2.0.1 versions for 1.20.5 up through 1.21.4! Check out the new versions on Modrinth!


Ensure ReplicaCount of 1

Allows addon deployment to function as expected
Signed-off-by: Zachary Kayyali<EMAIL_ADDRESS>

/lgtm


fix: fix logger output

may i ask why the README was completely rewritten from v0.6.6 ?  i did find the previous version of the README more informative, also when it came to the log level.
also a question: is it possible to have the information about which IPs have been banned in the INFO log level? i believe DEBUG is too verbose, but INFO is not adding any real value  compared to NONE, so perhaps would be better to output only the BAN and UNBAN events in the INFO level as well.
also IMO it would be nice if the plugin was outputting some stats info from times to times, something like "[jail-name] currently 120 IPs banned". Where jail-name would be the name of the ingress / ingressRoute that caused the ban.


Temporarily disable azure refresh spec test

We will enable the test after we resolve this problem: https://github.com/ManageIQ/manageiq/issues/4260

@bzwei Should it be marked pending?  I believe the test will actually pass with 0 assertions.  Could you include workaround #4260, sporadic test failure, (or similar) in the commit message so we understand why we're disabling the test for now?  Thanks!

@jrafanie You are right. Now I pended the test and edited the commit comment.

Thanks @bzwei


Update docs with better formatting for v2 protocol page

We should do something very similar to https://docs.seldon.io/projects/seldon-core/en/latest/reference/apis/v2-protocol.html ? as far as the formatting goes.
We should replace the hardcoded table in the v2_protocol page https://kserve.github.io/website/master/modelserving/data_plane/v2_protocol/
Thanks @alexagriffith for the suggestions

👍


Yield cmd_runner thread when nothing to do to limit CPU usage

I noticed the run function in cmd_runner.py constantly checks the transcript queue and polls the simulation process to check if it's still running. The python thread basically never yields and has 100% CPU usage. Adding a short sleep() call when there is no transcript line to process allows the run thread to yield when there's nothing to do and reduces CPU usage significantly.
(I thought maybe there's a more elegant way to yield than using sleep, but it seems like that's actually what people use: https://stackoverflow.com/a/790246).
You can easily see the difference in top etc. in Linux, but I also tested and profiled this in this branch/repo: https://github.com/svnesbo/axistream_uart/tree/hdlregression_profiling_test
That branch has a HDLregression + UVVM testbench with 16x identical test cases. Each TC takes around 30-40s to run on my system. And the run.py script was setup to use the Yappi profiler (which is supposed to support multithreading in Python).
Running 1 TC without yield (sleep) in cmd_runner - around 30s CPU time for the Python thread (sim takes around 30s as well):

Running 1 TC with yield in cmd_runner has much lower CPU time for the Python thread:

That testbench/case has a lot of log activity though (probably much more than you'd normally want), so the run thread actually has quite a lot of work to do. If I disable all the VVC output logs then the CPU time basically reduces to nothing when the line to yield is there (if I run that without the yield though then the results are more or less unchanged, but I chose to not include a picture of that):

If I'm only running 1 TC (one thread) then the simulation takes 30s regardless of yield in cmd_runner, since there's plenty of CPU cores it doesn't matter if some CPU time is wasted. But if I run the full regression using 8 threads (my system has 8 CPU cores), so each thread gets to run 2 of the 16 TCs then there is a difference. Basically, it takes around 1m:17s for the full simulation with the yield, and around 1m:30s without it (that's fairly consistent if I run it again). So that's a speedup of about 15% when I try to utilize all cores on my system.

I should add that this was tested using NVC and in WSL2.


link to mina.staketab.com explorer

Please add the link to our mina.staketab.com explorer.

sorry, I forgot about this 3 PRs here... pls open it again and I'll merge it :)

opened again

Thank you for the submission and sorry for the delay :)


2 more datatypes for PostgreSQL

From<EMAIL_ADDRESS>on January 14, 2010 12:57:51
What steps will reproduce the problem? 1. for a 'TIMESTAMP WITHOUT TIME ZONE' or 'GEOMETRY' column
2. it is shown as INTEGER What is the expected output? What do you see instead? 'Date' or 'Miscellaneous' What version of the product are you using? On what operating system? 2.4 Please provide any additional information below. Documentation about data types for Postgresql : http://www.postgresql.org/docs/8.3/static/datatype.html as attached file, the enhanced XML.
Attachment: datatypes.xml
Original issue: http://code.google.com/p/wwwsqldesigner/issues/detail?id=58

From ondrej.zara on February 28, 2010 00:36:31
Commited as r78 , thanks!
Status: Fixed


"true" as a value in values.yaml breaks upgrade

Hello!
First of all thanks for the great work on Helm. It solves so many problems!
I am trying to install Deis Workflow 2.9 using Helm. I customise some values using values.yaml:
# ...
router:
  deployment_annotations:
    router.deis.io/nginx.platformDomain: "foo.com"
    router.deis.io/nginx.ssl.enforce: "true"
# ...

When running helm upgrade <release name> -f values.yaml I get the following error:
Error: UPGRADE FAILED: unable to decode "": [pos 288]: json: expect char '"' but got char 't'

I believe the "true" messes up the parsing somewhere. This, however, works:
# ...
router:
  deployment_annotations:
    router.deis.io/nginx.ssl.enforce: "\"true\"" # note the escaped quotes
# ...

What if you wrap in single quotes instead of double quotes? ('true' or '"true"')

Also possible: use !!string "true". I haven't tested that one.

I am marking this as closed. Feel free to re-open if the above suggestions didn't fix it.


Storm warning missing

Right now, there is a storm warning for Brussels. I can't find it anywhere. Maybe the warning sensor could be used.

Do you have it in the original app?  On mine I see an orange wind warning for Brussels currently

On the app I have the wind alert on Brussels which is also indicated on the warning sensor in my Home Assistant instance.  I have a zone called 'bxl' on Brussels in here is the warning sensor state.  This is consistent with the only warning shown for Brussels in the app.
Do you have something else that is not consistent?

Yes, I do find this sensor. However, its state is off. I see it was last updated on 22 February 2024 at 11:20:18.
warnings:

slug: wind
id: 0
level: 2
friendly_name: null
text: null
starts_at: '2024-02-22T15:00:00+01:00'
ends_at: '2024-02-23T01:00:00+01:00'
is_active: false

active_warnings_friendly_names:
device_class: safety
friendly_name: Warning H123

The logbook:

OK, that's strange: the friendly name should appear and the is_active should be true given the values of starts_at and ends_at.
I'll try to reproduce the issue this week-end when I have a bit more time to look into that.
In the meantime, if you have settings that you think may interfere with the sensor, don't hesitate to share them.
What language is set in Settings > System > General?  English, English (GB), something else?

English (GB) is indeed what I have. Changing it to French and then restarting HA does make it active, indeed. I see the default weather card doesn't show it.

I managed to reproduce the bug with a slightly different outcome: when using 'en-GB' or another language, the sensor for the warnings becomes unavailable.  Now, when the language is not one that is supported by the API, it defaults to English for the warning data.

This should be fixed in the latest release https://github.com/jdejaegh/irm-kmi-ha/releases/tag/0.2.3.  Feel free to re-open if it does not work for you.
Thanks for reporting the bug!


what is maximum num of streams  publishing  in a application?

were there any restrictions on this? i published 120 streams in four applications success, 30 of each application.  but when i published 120 in one application, there were many failures.
i'm looking for some configs about this, but i cannot find.  max_streams seems not relevant.

It would be good to share the errors here.

I think the max stream nums in one application is 1024 in the code, because the length of the stream hash array was set as 1024 by default. More error info needed to solve your problem.


Laravel 5.7 + Multi-Tenant 3.5

Does anyone have an empty/dummy installation with Laravel 5.7 and Multi-Tenant 3.5? I am trying to get them to work together but I am constantly having problems with the connections.
An empty repository with only the very basics would be awesome. The only think similar that I found was this https://github.com/hyn/dummy-tenant-website but it haven't been updated for years. It would be really helpful for people starting to use this package.
Of course there are many guides online but none of the uses the 3.5 version of this package nor Laravel 5.7

https://github.com/peartreedigital/boilerplate
and then upgrade to 5.3 if it isn't at that version yet


Lifecycle state badges should be hyperlinked to associated state wiki pages

For example:

i.e.  is hyperlinked to https://finosfoundation.atlassian.net/wiki/spaces/FINOS/pages/93061261/Operating
Each of the lifecycle state pages are children of this page.

Fixed on https://rawgit.com/finos/finos.github.io/staging/index.html


[url_launcher] flutter web can't use "url_launcher"

flutter web can't use "url_launcher"

I came up with a temporary solution to this problem using the universal_html and universal_io packages:
import 'package:universal_html/prefer_universal/html.dart' as html;
import 'package:universal_io/prefer_universal/io.dart';
import 'package:url_launcher/url_launcher.dart';

void _openUrl(String url) async {
    // flutter web
    if (kIsWeb) {
      html.document.window.location.href = url;
    }
    // android or ios
    else if (Platform.isAndroid || Platform.isIOS) {
      if (await canLaunch(url)) {
        await launch(url);
      }else {
        throw 'Could not launch $url';
      }
    }
    // unknown platform
    else {
      throw new Exception('Unsupported platform');
    }
}

Tested and working on flutter for web and android.

@sleeyax you can also use window.open(url, 'Link'); to open the URL in a new tab.

you can use the javascript method open to launch an url I tried it works perfectly

url_launcher is supported on Flutter Web, you can find instructions on how to use it here: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher_web

I'm using Flutter v1.13.6. I can't get this to work, not by hot restarting, not by rebuilding the project, not by reopening Android Studio. In pubspec.yaml, with just the dependency url_launcher_web, flutter pub get exits without an error.  With just url_launcher or that dependency with url_launcher_web, it throws an error.  In main.dart, there's a red underline in the import package:url_launcher/_url_launcher.dart';  "Target of URI doesn't exist"

Currently on Flutter 1.19.0-4.3pre and building a flutter we app. url_launcher never returns  from  await launch(url) following the example code in url_launcher. Used the dart:js solution above to work around this.


Adding health checks

Adding health checks for indico, indico-celery and indico-nginx containers.

It'd be nice to add some integration tests.

Please, resolve conflicts. Also, can you run tox locally before resubmitting the PR?

Please, resolve conflicts. Also, can you run tox locally before resubmitting the PR?

I have already did.

Some comments inline. Also, are the changes to indico.Dockerfile expected?

Yes, they are. I have to resolve the conflicts on he file, but the modifications here are one of the necessary fixes to have the checks working in the first place.

If I try to resolve the conflict by using what is in main, the indico image will break and integration tests will fail. I need my changes in the dockerfile to be preserved for this to work, but I don't know if that would break other features.

/rebase

LGTM


fix device hardcode

Differential Revision: D58968208

Is the test failure related?

The failed CI are pre-existing, not related to this PR


Cannot move a static IP from one job to another in a single deploy

I had a static_ip (type vip) bound to a job (api/0) and was adding haproxy/0 job and wanted to move the static IP to it. During deployment, I get an error because the deployment doesn't recognise that its also removing the same static IP from the original job.
Preparing deployment                                                                                [64/477]
  binding deployment (00:00:00)
  binding releases (00:00:00)
  binding existing deployment (00:00:00)
  binding resource pools (00:00:00)
  binding stemcells (00:00:00)
  binding templates (00:00:00)
  binding properties (00:00:00)
  binding unallocated VMs (00:00:00)
  binding instance networks: `ha_proxy/0' asked for a static IP <IP_ADDRESS> but it's already reserved/in use (00:00:00)
Error                   9/9 00:00:00

Error 130008: `ha_proxy/0' asked for a static IP <IP_ADDRESS> but it's already reserved/in use

Closing this due to inactivity. We have since largely refactored the way networks are managed by BOSH, please feel free to reopen if this is still an issue.


missing modules

initial installation startup:
Error: no module named 'dns'.
after copying packages/ from electrum (original wallet):
ModuleNotFoundError: No module named 'bls_py'
from module dash_net.py line 38
I'm just running a raw python3 installation on the latest Void Linux (32bit)
are there any other dependencies I should include??
python can be pretty annoying at times :P

welp, sorry about this one
I wasn't aware of the required dependencies needed to get this thing working
I was expecting this to be like electrum where you can just download and run...
not sure why bls_py isn't included since that's a 100% python module
but cryptodome can't be included unless it can be spot-compiled at runtime (or has a py3-agnostic binary)
it looks like that's all that's needed though
during the time of this issue I've run across many other electrum-based wallets which seem to require many more binaries.
anyways, closing this as I was oblivious

reopening because I managed to get it working, meaning this issue is valid.
cryptodome was not needed, all that's needed is bls_py
just clone as zip and extract the directory to packages/
there's a minor error about bls_py.fields can't be imported
but you'll get a window regardless :)
+1 for managing to be the closest 3rd-party wallet to Electrum yet ;)
(or should I say the only privacy-coin wallet that doesn't need binaries)

Thanks for pointing to this. Will fix soon.

This tar.gz installation method is not supported anymore and the gzip archive that is on the releases page contains the sources, not the installation. I checked that other installation methods, namely the AppImage and the development installation (python3 -m pip install .[fast]) work OK.

I've added a tar.gz including packages to the release. I'll be adding it further. It should have all the modules.

I want to add, I did neither the tgz or gzip methods
in fact I did something I now realize I probably shouldn't've done and just cloned the repo as a zip
lol when you work with python, sometimes your head can get lost in places like this XD
buuuuut I did the same with electrum, and that works, so that's where the focus of this issue was :)
that said though, I probably should've downloaded a stable release :P
I accept my fault there
still though, it's good to know everything's included now :)


chore: Update ruff config

add more basic linters

@gforsyth please check the branch rules. The main branch needs to be protected but should be able to be merged by PRs after approvals.

@gforsyth still it needs status checks to pass.


Provide a good adoption procedure

Yes. I have a preexisting amazon account with some resources like vpc. I want to make controllers reconciling this resource i.e. adopting it. Right now it is possible only with https://aws-controllers-k8s.github.io/community/docs/user-docs/adopted-resource/ procedure. And I don't like it.
For instance. I have a set of resources described in gitops repo like VPC, subnets etc. Then there may be two cases:

the control cluster with all manifests and ack controllers instances was lost. I want to create a new one, connect it to gitops repo and I am expecting that all resources will be synced. Unfortunately, all controllers will give the error, that the resources already exists.
I have already precreated environment and I want to move all resources to gitops repo.

If automatically adopting is not desired, it could be good idea to agree that it's behaviour can be changed by some kind of annotation like:
# if it is already created - it won't be adopted
apiVersion: ec2.services.k8s.aws/v1alpha1
kind: VPC
metadata:
  name: production
  namespace: infra-production
spec:
  cidrBlocks:
    - <IP_ADDRESS>/16
  enableDNSSupport: true
  enableDNSHostnames: true
  tags:
    - key: Name
      value: production

# if it is already created - it will be adopted, the controller will populate status field from the Amazon account
# and all further changes will be controlled in gitops way
apiVersion: ec2.services.k8s.aws/v1alpha1
kind: VPC
metadata:
  annotations:
    services.k8s.aws/adoption: true
  name: production
  namespace: infra-production
...

We have a few existing issue regarding adoption mechanisms. It seems like you are in favour of using an annotation, here is the issue tracking that one - https://github.com/aws-controllers-k8s/community/issues/1381


💅 Design schema for manifest file

As an experiment runner, I want to be able to specify a manifest file that I can provide to the mturk-helper library that will specify HITs and launch them at specified times.
There are several major elements involved. One is a specification of a HIT as viewed by workers, that can be adjusted as needed. It includes things like the HIT's title and description, and also the visual display that the worker sees.
Another part of the specification is the sequence of HITs as they play out over time, and the number of assignments present in each HIT. These can form separate parts of the manifest file.
Here's a working draft that we'll need to refine as we get some experience:
hitTemplates:
  - name: surveyLink
    title: Complete an academic survey (6 mins)
    description: We are interested in your opinions about bagels
    reward:
      - amount: 1
      - currencyCode: USD
    keywords:
      - survey
      - research
      - study
    allowedTimeInMinutes: 5
    visibleForMinutes: 90
    autoApproveInMinutes: 30
    question: surveyLinkFile.html
    visibility: hidden

  - name: empiricaRecruit
    title: Qualify for a multiplayer game at ${launchDate}
    reward:
      - amount: 1
      - currencyCode: USD
    keywords:
      - research
      - study
      - game
      - multiplayer
    question: empiricaRecruit.html

sequences:
  - name: simpleSurvey
    desc: A single HIT that gives participants a long time to complete the task
    steps:
      - template: surveyLink
        allowedTimeInMinutes: 60
        nResponses: 9

  - name: multiPlayerGame
    desc: Coordinates 3 HITs to all be complete at "launchDate"
    reward:
      - amount: 2
        currencyCode: 3
    steps:
      - template: empiricaRecruit
        launchOffsetMinutes: -40
        visibleForMinutes: 10
        allowedTimeInMinutes: 30
      - template: empiricaRecruit
        launchOffsetMinutes: -30
        visibleForMinutes: 10
        allowedTimeInMinutes: 20
      - template: empiricaRecruit
        launchOffsetMinutes: -20
        visibleForMinutes: 10
        allowedTimeInMinutes: 10

If a parameter is present in both the hitTemplate and the sequence that uses it, the value in the sequence takes priority.

Comments from discussion:
Duncan — do we need this now? do we need this for current studies? is this going to get in the way of doing the big thing?


Minimize the queries

Add a relation props like:
This simplification of the code would help speed up part of the code and minimize the number of queries to the database.
prisma.values.upsert({
   where: {id: XYZ},
   create: {
          data: {
            file: {
              CreateOrConnect: {
                where: {noexist},
                create: {name: args.filename},
                connect: {name: args.filename},
              },
            },
          },
        },
   })

Hi @gothdawid and thanks for submitting us feedback.
I struggle to understand exactly the simplification you're referring to, since the example you provide seem related to a Prisma schema I'm not aware of.
Would you mind elaborating? That makes it otherwise difficult for us to know if we can consider it further.
Thank you!

Hello @gothdawid,
can you please elaborate more on this issue, i.e. share the corresponding schema?

I am going to close this as its been 3 months now and there is no activity here.
Please open a new issue at https://github.com/prisma/prisma with a proper description.

I am going to close this as its been 3 months now and there is no activity here.
Please open a new issue at https://github.com/prisma/prisma with a proper description.


extract frames with captions

First，this work is great. I want to ask for how can I extract keyframe from video with the caption of this frame?

Do not spam the issues, you already asked in #8, the network does not predict keyframes or captions.

sorry, I just make a mistake that I think the last issue haven't sent out.


fix: change class to protected

Fixes sonar cloud issue
#182

@NyorJa I got illegal modifier error when the class is protected? Was Sonar wrong with this one?

@NyorJa I got illegal modifier error when the class is protected? Was Sonar wrong with this one?

Not sure but follow what sonar's recommendation. The only solution is remain it like this public abstract class GenericCrudJpaService<P, E>   implements ICrudJpaService<P> {   protected GenericCrudJpaService(IJpaRepository<E> repository,                                ITwoWayConverterJpaService<P, E> converter,                                Logger logger) {     this.repository = repository;     this.converter = converter;     this.logger = logger;   } }

Changes done @NyorJa


Icon for 1Password 8

Description
The app title 1Password 8 is 1Password, this will apply the existing 1Password icon to the new version of 1Password.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Verified app icon was applied.

Thanks!


Correction of a parameter labeling

t was replaced by d in the middle of the paragraph

Thanks a lot for spotting this! I fixed the parameter renaming in one more location in f36047d.


Add option to fix API report file newlines

PR type ? minor feature
Did you add tests for your changes? no
If relevant, did you update the documentation? n/a?
Summary
API Extractor uses CRLF newlines by default and adds trailing spaces after empty comment lines, both of which can add excessive noise to diffs. Add an option to automatically fix those newlines as part of the API Extractor tasks. (The space after empty comment thing could potentially be fixed in API Extractor itself, but they refuse to add an option to use OS-appropriate newlines in output files.)
Does this PR introduce a breaking change? no

(The space after empty comment thing could potentially be fixed in API Extractor itself, but they refuse to add an option to use OS-appropriate newlines in output files.)

@ecraig12345 Where did this impression come from?
I was helping someone to implement this, but they haven't followed up:
https://github.com/microsoft/rushstack/issues/1366#issuecomment-537740747


Possibility to disable periodic rule check/modification

Hi,
I've noticed that ingress is automatically doing rebuild/refresh of rules in ALB every hour.
Is there possibility to disable this behaviour?
Currently I have workaround for missing feature (https://github.com/kubernetes-sigs/aws-alb-ingress-controller/issues/592) that i use ingress to create rule for service, and then run script that is using aws sdk to modify created rule and add authentication-oidc action. It works but ingress is removing this modification every hour during some periodic "refresh" therefore I need to somehow disable this functionality until it is possible to specify authentication directly in ingress annotation.

it's more easier to support the OIDC and cognito than this one 😄, i'll start to work on OIDC and cognito support :D


Isabelle review: participant management

Participant Management
If you find issues not related to the participant manager, please open them as new separate issues, not comments on this review
View a competition here: https://codalabcomp-v2-prod.lri.fr/competitions/11/#/participate-tab
If you follow the Login link, it should bring you back to this page afterword. The signup page should open in a new tab.

[x] You should be able to view the competitions terms by clicking on terms and conditions

[x] once logged in, you should have to check the I agree to the terms checkbox before the register button can be selected
[x] selecting the Register button should create a registration request
[ ] in the linked competition, registrations are auto-approved, so you should not need approval form administration
[x] this competition: https://codalabcomp-v2-prod.lri.fr/competitions/14/#/participate-tab does not have auto approval, so once registering, you should see your registration status go to "pending" and can be approved or denied by the competition administration (admin or collaborators).

To create your own competition, click on the competition link in the header:

Use this zip file:
wheat_seed_competition.zip
and click the upload button in the upper right or follow this link:
https://codalabcomp-v2-prod.lri.fr/competitions/upload/
from the competition detail page, click the teal gears to see a dropdown of admin management options:

(You must be logged in as the competition organizer to see this)
From the dropdown, select Manage Competition

A modal should appear with a blue Edit Competition button.

[x] Clicking this should take you to the competition editor

[x] Clicking on the "Participate" tab brings you to a page with a markdown editor for editing the terms and conditions of the competition, as well as a checkbox to toggle whether the competition should auto-approve participants.

Navigate back to your competition detail page.
Clicking the same teal gears, click on "Manage Participants"

This will bring up a modal with a table of all the participants of this competition

[x] a search box allows you to search through the list of participants, both by email and by username.
[x] You can also filter the table with the status dropdown, to see only users w/ a specific participation status.
[x] There is a large blue button next to the status dropdown that will let you email all the competition participants (this filters based on status=Approved).
[x] This should bring up a modal that will let you write markdown content to send as an email to all participants in a competition.
[x] the modal has a fixed subject A message from the admins of <Competition Name> and cannot, at this time, be changed
[x] clicking the paper airplane button should send the email
[x] clicking the trash can cancels sending the email
[x] this bulk email is sent as bcc instead of cc, so recipients cannot see the emails of all participants
[x] the participation table also has actions: approve, revoke, and send message.
[x] Approve should be visible if the participant is not currently approved
[x] revoke should be visible if the participant is not currently denied
[x] send message should always be visible
[x] clicking the send message button should bring up the same email modal as before, but this time the message will only be sent to the individual user.

It should be possible to view the terms and conditions after having reviewed them.
If I click register without being logged in I get an error:

@madclam
Thank you for the review.
I quickly addressed a few of your comments, so if you retest these specific issues, they should be working correctly now:

[ ] in the editor, you should not need to click the box to see the rules
[ ] you can not see a "register" button if you are not logged in, instead, there are links to "Login" and "Sign Up"
[ ] in the editor, the "auto approve" checkbox should correctly reflect the state of the competition.

In regard to your other comments:

I should be able to add the terms as another page in the "Get started" tab, below all the other pages.
The "email all participants" button does send an email all participants, as you pointed out, since it is currently independent of the search results in the table. We may be able to add the functionality of only emailing the participants based on the search/filter selections, if there is a need for that.
"forgot my password" is not related to participating in a competition, so is not addressed by participant management.

All passed. We'll address other issues separately.


ConnectedProps: dispatch prop expected even if there is no mapDispatchToProps

What version of React, ReactDOM/React Native, Redux, and React Redux are you using?

React:
ReactDOM/React Native:
Redux:
React Redux:

What is the current behavior?
i use ConnectedProps to infer my component props instead of manual typings, but i noticed when reusing the result in a different component where i manually piped down the same props that it expects dispatch.
What is the expected behavior?
Should'nt need dispatch in these cases
Which browser and OS are affected by this issue?
No response
Did this work in previous versions of React Redux?

[ ] Yes

What do you mean by "expects dispatch"?  What error message are you seeing?
Can you put together a sandbox or repo that shows the actual problem?
The PR you filed doesn't look correct.  If you don't provide a mapDispatch argument, React-Redux will pass in props.dispatch automatically.


how to use original destination as hostname in tunneling_config

how to use original destination as hostname in tunneling_config
Description:
I'm using iptables to redirect certain traffic to envoy (for example: iptables -t nat -A OUTPUT -p tcp --dst <IP_ADDRESS>/24 -j REDIRECT --to-port 8099) and then encapsulate it in HTTP1.1 CONNECT following the sample here.
Is there a way to retrieve the original destination at envoy side and dynamically set it as hostname in tunneling_config? Btw, the destination is not https so %REQUESTED_SERVER_NAME% is null here. I also tried with DOWNSTREAM_LOCAL_ADDRESS, the original dst ip:port is retrieved, but set it in hostname doesn't work. (hardcode with ip:port works)
      listener_filters:
      - name: envoy.listener.original_dst
        typed_config:
          "@type": type.googleapis.com/envoy.extensions.filters.listener.original_dst.v3.OriginalDst
      filter_chains:
      - filters:
        - name: envoy.tcp_proxy
          typed_config:
            "@type": type.googleapis.com/envoy.extensions.filters.network.tcp_proxy.v3.TcpProxy
            stat_prefix: passthrough
            cluster: mycluster
            tunneling_config:
              hostname: "%DOWNSTREAM_LOCAL_ADDRESS%"

works now, config error...


PR for Rawposix(dispatcher.rs, fs_call.rs, misc.rs)

modify dispatcher.rs and type.rs to support argument type conversion, mention we have three special syscall fork/exec/exit with used by wasmtime so it won't pass the regular dispatcher path.

add implementation of futex and nanosleep.

So after reviewing it seems there's some unnecessary steps in type conversion.
Before our arguments to the dispatcher were Unions, and they were converted in types.rs to the appropriate Rust type.
Now our arguments are u64s. So we should modify types.rs to convert from u64 to the appropriate Rust type.
What you guys did is convert from u64 to the old unions, and then used types to convert to Rust. We should bypass that middle step because its not needed.

There's also a lot of stuff added to src/lib.rs which shouldn't happen. It seems like some of this is doubled up from functions in the dispatcher? Either way everything should be consolidated in dispatcher.rs for now.

I think besides some minutiae the biggest thing here is figuring out whats going on in lib.rs I'm still very confused about that.


✨ Mobile Number verification

Description
Add mobile number verification for both seller and buyer to make sure the number entered is correct. Else there may be serious troubles in conversation between the buyer and seller during an order
Alternatives Considered
No response
Additional Context
No response
Screenshots
No response
Is there an existing issue for this?

[X] I have searched the existing issues

Hello I have opened a pull request with the first step of the issue done. It requires the Twilio API so you will need to use your own API key.

@MasonScarbro Thank you for your contribution, we'll take care of API keys.


Request for SmolMLv1 Pretraining Code

Hi, thank you for the amazing work! I'm interested in reproducing the pretraining process of SmolMLv1 (135M) on the SmolLM-Corpus. However, I noticed that the repository currently only includes fine-tuning scripts. Could you please share the pretraining code or provide a tutorial? I would greatly appreciate your help.
Thank you!

Hi, we use nanotron for the pre-training https://github.com/huggingface/nanotron/
Here's the config for training SmolLM v1 135M
https://gist.github.com/eliebak/4263659706519536b7eebfe6d9815c60
You might need to adapt the dataset part to use nanosets with tokenized datasets cc @eliebak

Hi, @loubnabnl ! Thanks for sharing the config file, but it doesn't work with last commit of nanotron:
dacite.exceptions.UnexpectedDataError: can not match "launch_slurm_config", "logs_path", "slurm_logs_path", "launch_script_path", "temp_dir", "timestamp_with_run", "config_logs_path", "evals_logs_path", "eval_slurm_config" to any data class field

I am also struggling to find a proper documentation of these fields from Nanotron, which makes it hard to debug.

Hey @ceferisbarov,  the fields were not defined in the main version of Nanotron as you mentioned, I updated the config in #6 and it should work with the last commit of nanotron now!

It works now. Thanks! @eliebak

Hi, @eliebak, Thanks for updating the pretraining config. My reproduction is going smoothly except for the issue with datasets/stackoverflow. I am using the bigcode/stackoverflow-clean dataset, but I encountered an error when using nanosets for preprocessing. I would like to confirm if the dataset I am using is correct.

Preprocessing command:

python preprocess_data.py --tokenizer-name-or-path ~/data/hf_home/SmolLM-135M/tokenizer.json --output-folder datasets/stackoverflow --n-tasks 8 hf --dataset ~/public/corpus/bigcode/stackoverflow-clean/

Error message:

TypeError: unsupported operand type(s) for |: 'str' and 'dict'

can you add --column content ?
python preprocess_data.py --tokenizer-name-or-path ~/data/hf_home/SmolLM-135M/tokenizer.json --output-folder datasets/stackoverflow --n-tasks 8 hf --dataset ~/public/corpus/bigcode/stackoverflow-clean/ --column content

If not working can you send the full error trace?

Thank you very much, it works!
Additionally, I would like to confirm whether the dataset corresponding to datasets/open-web-math is open-web-math/open-web-math. Also, I noticed that the datasets/python-edu does not have a default "text" column. Does it require a special --column?

yes it's this one for smollm1, for python-edu you need to follow this  https://huggingface.co/datasets/HuggingFaceTB/smollm-corpus#downloading-the-data to download the data!

Thank you for your time and help! The preprocessing for all five datasets is completed.
No more questions.


Module Depends On Permissions

Bicep version
Bicep CLI version 0.14.46 (ef2ceb1a0e)
Describe the bug
I'm trying to create a bicep file that will create a resource group, do roleAssignments, and then deploy to that resource group. We have a deployment account that we use for deploying to Azure. We keep the permissions on this account extremely lean, so we are wanting to apply needed permissions on an app by app basis.
This is what I've got going on.
resource resourceGroup 'Microsoft.Resources/resourceGroups@2022-09-01' = {
  name: resourceGroupName
  location: location
}

module resourceGroupRoleAssignment 'modules/permission.bicep' = {
  name: 'resourceGroupRoleAssignment'
  scope: resourceGroup
}

module functionApp 'modules/functionApp.bicep' = {
  name: 'deploy-functionApp'
  dependsOn: [
    resourceGroupRoleAssignment
  ]
  scope: resourceGroup
  params: {
    environmentType: environmentType
    location: location
  }
}

What I was hoping to happen is it would create the resource group, assign permissions and then deploy. What is currently happening is it's creating the resource group then trying to assign permissions and before the permissions have been assigned it trys to deploy, which fails.
What am I doing wrong?

Closing due to no response


locale and format (pickTime, pickDate)

It seems that picktime and pickdate options don't exist anymore.
Ok, but how can I do if I want to use the datetimepicker as a datepicker (or a timepicker) if I don't know the format of the language of the user ?

ok...
$('#datetimepicker').datetimepicker({ 	locale:'fr',         format: 'L'     })


Optimize Index to Accelerate Query

Problem
Through our test, we found that adding index in some table can improve query efficiency, and some index which may make query slow need to be dropped.We will talk about them respectively.
1.member_profile
Add index on column username which will influence TeamRepository#findByUsername.
Add index on column github_id which will influence TeamRepository#findByGithubId.
2.post
Add index on column author_id which is a foreign key refering to member_profile.id.
Drop index on column draft which is boolean type with poor selectivity.
3.project
Add index on column display_order which will influence ProjectMetadataService#sortByDisplayOrderAndId.
Possible Solution
1.Add Index
member_profile.username
member_profile.github_id
post.author_id
project.display_order
2.Drop Index
post.draft

Closing in favor of #968


Speed test on speedof.me doesn't work

Details:
https://github.com/AdguardTeam/AdguardForAndroid/issues/1678

Confirmed that the issue is resolved with the CoreLibs integrated Android build


Package's modules not display in packages view or modules's view

Describe the bug
Package's modules no display in Packages view
To Reproduce
Steps to reproduce the behavior:

Download this stats.json
This comes from a mini demo, which only has a simple import statement in the entry file.

import { add } from 'lodash-es';
console.log(add);

npx statoscope validate --input stats.json

Current behavior
'lodash-es' 's modules neither display in modules' view or in the package's view

Expected behavior
Package's modules display in both packages view and modules's view
Screenshots
I tired debug myself, but have some trouble understanding jora's code.
But found that before jora's query, modules seems can be found in the compilation object.

Versions:

Node (for non-browser bug): 14.15.0
Browser (for browser-bug):
Webpack: 5.38.1
Statoscope: 5.24.0

Additional context
I notice there are huge differences between  demo's  stats.json
and mine which also generate via   webpack --json stats.json.
Again thx for this awesome library!

@icy0307 👋
Hmmm, I can't reproduce this bug. Do you have any ideas what could I do, to reproduce it?

Sorry, I can't reproduce it either now.
I will close this issue and reopen it if I can find the way. Thx for your effort.


SSR ServerStyleSheets || => sheets.toString() stays blank with sheets.collect()

sheets.toString() stays blank for me !!!!!
I followed the documentation and I even followed the repo example
What's the diff between your repo and my code ? you launch SSR with babel-node (not possible in real life because of import of images and svg in ES6), me I put SSR in webpack as entry, and wait for a fresh server as output. Is it why your function sheets.collect() doesn't work ? because it's been compiled in webpack ?? I think so...
const renderFullPage = (html, css, store) => `<!doctype html>

    <meta charSet="utf-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1" />

${html}

`;

app.use((req, res) => {
  const initialState = {};
  const history = createHistory([req.url]);
  const store = configureStore(initialState, history);
  const sheets = new ServerStyleSheets();
  const context = {};
  const html = ReactDOMServer.renderToString(
    sheets.collect(
      <Provider store={store}>
        <StaticRouter location={req.url} context={context}>
          <App />
        </StaticRouter>
      </Provider>
    )
  );

  const css = sheets.toString();

  return res.send(renderFullPage(html, css, store.getState()));
});

This is where I found the function after webpack compilation, and this is why it doesn't work, don't you ?

@tomtom94 Do you have a reproduction for us? I would suspect an issue with a CJS and UMD bundling duplication.

had the same error, sheets.getStyleElement() generated empty sheet, the problem was in duplicated @material-ui/styles in yarn.lock, there should be only one !

@oliviertassinari I probably have this issue because @material-ui/core depends on "@material-ui/styles" "^4.2.0" instead of "@material-ui/styles" "^4.2.1"
"<EMAIL_ADDRESS>  version "4.2.1"
  resolved<EMAIL_ADDRESS>  integrity sha512-hasPQUFAb9OxKng7UX2+SjUWtVZbnkVJ/jHZWXTivVcU+UzvNIpA9AyRRQvZ8SPV6swP/HD2VzUBzoMEeRR6wg==
  dependencies:
    "@babel/runtime" "^7.2.0"
    "@material-ui/styles" "^4.2.0"
    "@material-ui/system" "^4.3.0"
    "@material-ui/types" "^4.1.1"
    "@material-ui/utils" "^4.1.0"
    "@types/react-transition-group" "^2.0.16"
    clsx "^1.0.2"
    convert-css-length "^2.0.1"
    deepmerge "^4.0.0"
    hoist-non-react-statics "^3.2.1"
    is-plain-object "^3.0.0"
    normalize-scroll-left "^0.2.0"
    popper.js "^1.14.1"
    prop-types "^15.7.2"
    react-transition-group "^4.0.0"
    warning "^4.0.1"
"<EMAIL_ADDRESS>  version "4.2.0"
  resolved<EMAIL_ADDRESS>  integrity sha512-VpPCNWYK1KjpurFh1gH02xpAmCqKZrC/rmiBosZcCRDl8AOcUkSxBMNU0rziHgSQ/jYTEh3MdKNs3Gq0vGCQ/w==
  dependencies:
    "@babel/runtime" "^7.2.0"
    "@emotion/hash" "^0.7.1"
    "@material-ui/types" "^4.1.1"
    "@material-ui/utils" "^4.1.0"
    clsx "^1.0.2"
    csstype "^2.5.2"
    deepmerge "^3.0.0"
    hoist-non-react-statics "^3.2.1"
    jss "10.0.0-alpha.17"
    jss-plugin-camel-case "10.0.0-alpha.17"
    jss-plugin-default-unit "10.0.0-alpha.17"
    jss-plugin-global "10.0.0-alpha.17"
    jss-plugin-nested "10.0.0-alpha.17"
    jss-plugin-props-sort "10.0.0-alpha.17"
    jss-plugin-rule-value-function "10.0.0-alpha.17"
    jss-plugin-vendor-prefixer "10.0.0-alpha.17"
    prop-types "^15.7.2"
    warning "^4.0.1"

"@material-ui/styles@latest":
  version "4.2.1"
  resolved<EMAIL_ADDRESS>  integrity sha512-1KSOZ17LBWBqIyPRsEpyb4snT/wRIfQTPi0x66UvSzznVK9MPAfJx3/s5lVT4vrGFObs/nj6Pet6Nhrdl2WCrg==
  dependencies:
    "@babel/runtime" "^7.2.0"
    "@emotion/hash" "^0.7.1"
    "@material-ui/types" "^4.1.1"
    "@material-ui/utils" "^4.1.0"
    clsx "^1.0.2"
    csstype "^2.5.2"
    deepmerge "^4.0.0"
    hoist-non-react-statics "^3.2.1"
    jss "10.0.0-alpha.17"
    jss-plugin-camel-case "10.0.0-alpha.17"
    jss-plugin-default-unit "10.0.0-alpha.17"
    jss-plugin-global "10.0.0-alpha.17"
    jss-plugin-nested "10.0.0-alpha.17"
    jss-plugin-props-sort "10.0.0-alpha.17"
    jss-plugin-rule-value-function "10.0.0-alpha.17"
    jss-plugin-vendor-prefixer "10.0.0-alpha.17"
    prop-types "^15.7.2"
    warning "^4.0.1"

My package json
  "dependencies": {
    "@material-ui/core": "^4.2.1",
    "@material-ui/styles": "latest",

@srghma Have you solved your issue ???

@oliviertassinari @srghma YEAHHH !!!
You were right I was using 3 months ago "@material-ui/core": "^3.9.3",
And I have made an update it works like a charm with "@material-ui/core": "^4.4.0",
Manyyyy cheers


Add roll inspector support for casted spells

The sooner we can get off of SpellPF2e#toMessage() the better.

What is meant by "add roll inspector support?" I can already inspect the attack and damage rolls of casted spells.

It enables the roll inspector for dc computation. I adjusted it so only DC spells receive it. There's no modifiers at all, but the rest are visible


SPM, CocoaPods, Carthage support

Hello.
Thank you for Higher-Order-Function-ObjC.
I know this repository was created for https://medium.com/@weijentu/higher-order-functions-in-objective-c-850f6c90de30, but it is also useful for all Objective-C developers. Do you want to add SPM, CocoaPods, Carthage support for Higher-Order-Function-ObjC?

@RomanPodymov Hi Roman, you are welcome. As to SPM, CocoaPods or Carthage, I think yes. I'll try it in the near future👌


Headings look different?

Heading on the milligram example page: http://prntscr.com/bt1vmy
My headings on a blank page with milligram added: http://prntscr.com/bt1vs0
As you can see, they look very different. Why is this? The css when inspecting seems to be the same. I've also tried on another browser. What might be the issue?

It looks like they just added font-weight or something similar to make it thinner.
Upon further investigation I found it.
h1, h2, h3, h4, h5, h6 {
    font-weight: 300;
    margin-bottom: 2rem;
    margin-top: 0;
}

As you can see, font-weight: 300; is making the letters look thinner and less bold. Milligram is a framework, not a full website maker so it's meant to be customized.

@Mortiferr No, thats not it. As mentioned, the css is exactly the same. I was having this problem with with another css framework as well. I think the issue was I was assuming that the font the framework used was included, and did not need to be explicitly included.
This seemed to fix the issue on the other framework, so I would assume it is also the fix for this issue. I have not tested it, but I'll go ahead and close this for now.


Possible bug in constraint

As noted by @alexwlchan in #54
L45 conference_scheduler/lp_problem/constraints.py
    if events[event].tags is not []:

Did you mean to test identity here, or just equality? Since the second half of the comparison will be created every time, I think this always returns True:
>>> [] is not []
True
>>> x = []
>>> x is not []
True

Yup, my bad, should have been equality. Fixing it now (this doesn't break anything, it just means we haven't shaved off some of the constraints).

Fixed by #61


Remove check for multiple authorization

Fixes #4813
PR #4271 had a check where an exception is throw if a request had multiple authorization checks performed, this is too aggressive for now and this PR removes that check.

#4817 should fix the TC inspections. Not sure why they weren't flagged before.

@gianm I'll make a patch that changes the way the supervisors authorize requests, closing this one


2.x State information propagation in the interest channel to the client

This is a proposal for state information propagation in the interest channel to the client.
Problem to solve
As interest stream subscription is reactive, there is no way for client to know how much relevant data is available when the subscription starts. If the client is a load balancer, it is critical to wait until available pool of servers is loaded before application requests are allowed, to avoid overloading single server that happens to be first in the list. It may be also advantages to know about bigger changes in the system topology (scale up), and do system reconfiguration when all/majority of the new servers are received via the change notification stream.
Proposed solution
Generate markers in the change notification streams indicating when a batch of notifications begins and when it ends. This concept is depicted by the figure below:

When a client subscribes it gets first a hint about batching status. If it is 'Batch', he should expect some data to come soon, so instead of processing individual items, he may postpone computation until more items arrive. Once 'FinishBatching' hint arrives, the items should be processed one after the other as there is no guarantee that any more items ever arrive, or the arrival interval may be prohibitively long for the client to wait.
There are two possible sources of batching hints:

Eureka client registry - it works as a cache of data, and when a client subscribes, the whole subscribed registry content should be delivered as a single batch
Eureka server - whenever server knows about a batch of items to be delivered (that starts with current registry content), the items shall be delineated with the batching markers

The concept is depicted in this figure:

One more level of complexity is added by the way interests are handled in the transport channel, and the index registry. For efficiency purposes, to avoid sending/processing the same data if different subscribes ask for same or overlapping data, the interests are handled at an atomic level. For example:

subscriber A asks for interest {vip=vipA}, and subscriber B asks for interest {vip=vipA or vip=vipB}
internally all subscriptions are merged into list of atomic interests {vip=vipA, vip=vipB}
the batching markers are generated per atomic interest, so must be merged before delivering to the client (just like data are merged)
if subscriber B unsubscribes, all the state related to {vip=vipB} can be safely discarded

Examples
Initial subscription with an interest matching some data
In this case Eureka client registry is empty so no batching hint is generated. There will be however sent 'Batching' hint from the server, followed by 'FinishBatching' after all available entries in the server registry are delivered. Subscriber will consume server's available content as a batch and switch to non-batching mode
Subsequent, parallel subscription to the same interest
Assuming there is already a subscription for a particular interest, another identical one is created:

Eureka client registry will send 'Batching' hint, followed by data, followed by 'FinishBatching'
nothing will come from the channel, unless at some point in time there is another batch to be delivered by server
subscriber will consume initial content as a batch and switch to non-batching mode

Subsequent subscription to the same interest, after the first subscriber unsubscribe
In this case we have some stale content in local Eureka client registry, and it will be fetched by the new interest subscription:

Eureka client registry will send 'Batching' hint, followed by data, followed by 'FinishBatching'
Eureka server will send 'Batching' hint, followed by data, followed by 'FinishBatching' for its known content
subscriber will consume initial content as a batch and all the updates as another batch
or
subscriber will consume all the data as a single batch, if the processing of the replayed stale Eureka client content is not finished before the first notification from the server for the given interest arrives

Data model
Batch hints are implemented as a new kinds of ChangeNotification:
public class ChangeNotification<T> {
    public enum Kind {Add, Delete, Modify, Buffer, FinishBuffering}
    ...
}

Internally a derived class StreamStateNotification is used to carry additional information. It is not however visible to the client.

For the proposed hint markers, it seems the Buffer hint is always sent for all cases described. From a behaviour point, what does the Buffer hint offer? It seems that consuming clients and/or operators only need to listen for the finishBuffer hint for an optimised buffering experience regardless of whether there are prior Buffer hints. E.g. the consumer should be able to apply a collection operator to the stream that emits a new List each time it sees a finishBuffer hint, and possibly timeout otherwise.
On the client side, it seem to make more sense that the source of the hints is only the registry, as it should be the source of truth for all data. On the server side, this is naturally the case, and on the client side the hints should be a merge of local registry hints plus server side hints if any are available. If we make sure the hints are only generated by the registry, we should then be able to merge the multiple hints emitted by atomic interests for composite forInterests so that clients only receive a single finishBatching marker (the logic would then be that a finishBuffer is emitted once all atomic FinishBuffers are received at the merge point).

I think it will be useful to provide code samples on how a client will consume this API. There are a lot of complex constructs as conditional batching and non-batching modes. I would like to see how this manifests on the consumer end.
A few implementation related questions:

How are these batching hints stored? It looks to me from your description of the various scenarios of multiple subscribers to the same interest, that the hints are generated at subscription time. I would have thought that the hints will be stored along with the data & hence will be delivered to multiple subscribers as is.
Is there an attempt to be precise about the hints? I get a feeling of this when you talk about hint merging i.e. an intent not to send multiple hints and de-dup them. If it is so, then what value will it add being precise?
What is the behavior in case of server failure between sending a "Batch" hint and "Finished batching" hint? What if there is no server available and we have already sent a "Batch" hint.

I am not really convinced about the need of "Batch" hint, however, I can see what you are trying to achieve i.e. the ability for the same client to switch between batching & non-batching mode. This is something will be cleared to see in a code example whether the complexity is worth.
@qiangdavidliu

the consumer should be able to apply a collection operator to the stream that emits a new List each time it sees a finishBuffer hint, and possibly timeout otherwise.

I think there is value in having an API where batch or non-batch is not a choice that the client is to make. In this model, the client will always batch & non-batch interaction will be timeout based.

Implemented by PR #403


"Share snappy.card link" does not work with Firefox on Win10

Hi,
apparently, the Share snappy.card link does not work with Firefox on Win10.

Win10 22H2
Firefox 125.0.1 (64-Bit)

Clicking on it does do anything, however, hovering over it shows https://snappy.cards/# as tooltip.

Hi @TiltonJH,
thanks for the bug report. Could you be so kind and attach a screen shot? Because actually it should not even show "Share snappy.card link". Instead "Copy snappy.card link" should be shown.


No string shows on the address bar if click on the address bar then press Tab

Storage Explorer Version: 1.32.0 (95)
Build Number: 20231030.12
Branch: rel/1.32.0
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.0(Apple M1 Pro)
Architecture: x64/x64/arm64
How Found: AD-hoc testing
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container -> Upload one blob.
Click on the address bar-> Press 'Tab'.
Check whether the string on the address bar shows.

Expected Experience
The string on the address bar shows.

Actual Experience
No string shows on the address bar.

Additional Context
This issue can't be reproduced consistently.

I cannot reproduce this issue. Could you record the screen to better illustrate what is happening in the UI?

@JasonYeMSFT This issue can't be reproduced consistently. we will record the screen when we reproduce it.

@JasonYeMSFT Here is the record.

I am still not able to reproduce this issue. Could you try to record the whole process from the very beginning? It's ok if the recording doesn't reproduce the issue in it. You can write down what it looks like when the problem occurs and differs from the recording.

The key to reproduce is to

Split the tab
Close all tab on the new split view
Click on the address bar.

I will make a fix.

Verified this issue on the build 20231121.2. Fixed. So, we are going to close it.


Amazing work!

I absolutely love the dark icon! Looks sick:

Although, I had to increase brightness and saturation, because on dark wallpaper is bearly visible. Maybe you could prepare some semi-dark version, I mean to keep the same appearance but a little bit brighter. I just increased brightness on the whole image so it's not the best way, but still looks great!

Thank you for the compliment!
I would love a pull request on this.

I googled it, because the terminal emulator is fantastic, but the Icon was such a bummer whenever I looked at it! This should be the default one. Beautiful 👍


Updated Particle Background Animation

Description
Particle background animation imported successfully in different pages of the website.
Fixes Issue #128
Type of Change:

New Feature

Hey @rockingrohit9639 I have some problem in my PC that's why I couldn't push another commit in that old PR only and due to it I re-cloned the whole project and again imported all changes, also I have removed the background animation for Home page this time.
I request you to kindly merge my this PR and delete that old PR.

@rockingrohit9639 are you merging this PR as I am not able to understand what exactly the conflict is in package-lock.json

Also I have no idea how to write access for this repository

Did u pulled the changes ? Before making a PR? ...maybe this is creating an issue


CCAP-41 Show submittedAt in Central Time

🔗 Jira ticket
CCAP-41
✍ Description

Always display submitted at time in the time zone America/Chicago (this handles standard and daylight time)
Add a test to check that GMT shows as CT

The updates to change the submitted at date to central time make sense to me.


If ValidationException is raised CORS header is missing in response

Can you give me an example so its clear what behaviour you expect here?


Incorrectly copied comments

Information

Qiskit Metal version: 0.0.4
Python version: n/a
Operating system: n/a

What is the current behavior?
The comments for the run method in qiskit_metal.analyses.quantization.energy_participation_ratio.py are incorrectly copied from the run method of qiskit_metal.analyses.quantization.lumped_oscillator_model.py.
Steps to reproduce the problem
https://github.com/Qiskit/qiskit-metal/blob/e5cbb6559ed650cbb75e696322ccc7a918d9c5a9/qiskit_metal/analyses/quantization/energy_participation_ratio.py#L148-L157
https://github.com/Qiskit/qiskit-metal/blob/e5cbb6559ed650cbb75e696322ccc7a918d9c5a9/qiskit_metal/analyses/quantization/lumped_oscillator_model.py#L119-L130
What is the expected behavior?
Applicable description of the inputs and returns for EPR's run and not the LOM's run method.
Suggested solutions
Relevant comments.

Thanks, @zachparrott , for nothing this!


Use require js

only refac, no additional feature.

Avoid global variable app.
Break JS code modules into separated files, and we are clear about there dependencies.
Separate the client side templates from the server side templates, and break templates into multiple files.

There is however a side-effect: each time when click to show directories, browser try to update all JS files by sending lots of HTTP requests, which will affect user experience. This is to be improved, especially on production.

Coverage remained the same at 87.38% when pulling 8c45cdb722a89827c500c41e23aa3ce2a04e1fd4 on use-require-js into 6b337fda7889b497a55babbc5d96eaff2175b5b1 on master.

Coverage remained the same at 87.38% when pulling 8e4fa0f3618b6472d110ec0cb3019cf56a0b6363 on use-require-js into 6b337fda7889b497a55babbc5d96eaff2175b5b1 on master.

Coverage remained the same at 87.38% when pulling b8edf5222253303ebd0235d6c6cf3612cf6ee36b on use-require-js into 6b337fda7889b497a55babbc5d96eaff2175b5b1 on master.

Coverage remained the same at 87.38% when pulling e8d94ac5ba5c6b08a92d0e3eef15e6f970ac1cad on use-require-js into 6b337fda7889b497a55babbc5d96eaff2175b5b1 on master.

Coverage remained the same at 87.38% when pulling e8d94ac5ba5c6b08a92d0e3eef15e6f970ac1cad on use-require-js into 6b337fda7889b497a55babbc5d96eaff2175b5b1 on master.

Coverage remained the same at 87.38% when pulling 3234bc1c57bb559c388c4ddeaf3b4a3ca45dab53 on use-require-js into 6b337fda7889b497a55babbc5d96eaff2175b5b1 on master.

Coverage remained the same at 87.38% when pulling f7895960e7c628b698b3f9366d66dc2bfbe1a941 on use-require-js into 6b337fda7889b497a55babbc5d96eaff2175b5b1 on master.


📝 Add documentation about AliasPath and AliasChoices

Selected Reviewer: @samuelcolvin

please review

I'm going to have some edits on this. Pls wait before merging

I'm going to have some edits on this. Pls wait before merging

Please apply the changes you wish, and merge it when you think is good. 👍


ENH: add StringMethods (.str accessor) to Index, fixes #9068

fixes #9068

@jreback please let me know what you think of this, thanks

this looks good
pls add a release note in v0.16.1

may also want to update the docs to mention u can do this on Index (I think it's in text.rst iirc)

@jreback both release note and text.rst have been updated

Nice, but 2 points:

There are some function returns bool, and Index(dtype=bool) is not usable very much (related to #8875). It may be better to return np.array in these cases.
Should prohibit to use return_type="frame" in split ?

@sinhrks can you elaborate on the first point (about bool)? an example?
@mortada
I think add a tests for all of the .str methods (e.g. to test the return types issue), I think you will have to raise if return_type='frame' is defined

@jreback just added a check and unit test for the case of Index and return_type='frame'
@sinhrks I'm looking into the bool issue you referenced

@jreback @mortada some str methods return booleans, e.g., str.isalpha. For series, it makes sense to return a  As @sinhrks points out, we probably don't want to return a new Index object for these values, but rather a plain numpy array.

@shoyer, @sinhrks I see, indeed returning np.array in the boolean case seems a lot more useful.
@jreback an example would be:
idx = Index(['a1', 'a2', 'b1', 'b2'])
s = Series(range(4), index=idx)

If we return an np.array then an expression like
s[s.index.str.startswith('a')]

would work naturally, whereas if we return a boolean Index that's not very useful

Just added a check for the boolean Index case, it will now return np.array instead. Please take a look, thanks!

@mortada yeh I think we need to do something for
Index(['foo_bar','bah_baz']).str.split('_',return_type='frame')

@mortada Thanks for quick action:)

Didn't look in detail into this, but a quick question: what is the return type? I suppose in general a new index? But what if the method returns multiple elements for each entry? (eg returning a frame for a series)?

@jorisvandenbossche the return type is Index unless the dtype is bool, in which case the return type will be np.array.
if the method returns multiple elements it will be an Index of lists, and won't be a DataFrame. If the user specifies return_type='frame' it will raise. Here's an example:
In [1]: from pandas import Index
In [2]: idx = Index(['a b c', 'd e', 'f'])

In [3]: idx.str.split()
Out[3]: Index([['a', 'b', 'c'], ['d', 'e'], ['f']], dtype='object')

In [4]: idx.str.split(return_type='frame')
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-4-d22b631e0f0f> in <module>()
----> 1 idx.str.split(return_type='frame')

/Users/mortada_mehyar/code/github/pandas/pandas/core/strings.py in split(self, pat, n, return_type)
    987     @copy(str_split)
    988     def split(self, pat=None, n=-1, return_type='series'):
--> 989         result = str_split(self.series, pat, n=n, return_type=return_type)
    990         return self._wrap_result(result)
    991

/Users/mortada_mehyar/code/github/pandas/pandas/core/strings.py in str_split(arr, pat, n, return_type)
    652         raise ValueError("return_type must be {'series', 'frame'}")
    653     if return_type == 'frame' and isinstance(arr, Index):
--> 654         raise ValueError("return_type='frame' is not supported for string "
    655                          "methods on Index")
    656     if pat is None:

ValueError: return_type='frame' is not supported for string methods on Index

@shoyer added examples to doc
@jreback now using is_bool_dtype
please take a look, thanks.

Only problem with raising on return_type='frame' is that this will be the default in some case (eg the method partition that is being added now), and not so nice to raise with the defaults

By the way, I think this is a very nice feature, especially useful for cleaning up your column names (stripping whitespace at beginning or end -> typical problem you see on SO, replacing whitespace with _, convert to all lower case, ..) For the docs, maybe it would be useful to also focus on this and give an example where the column names are used (but maybe not needed for this PR)

@jorisvandenbossche I don't think its a problem if certain methods which have a return_type='frame' raise if you try to call them on an Index. The only other option is to actually return a frame as I think the purpose is what you mentioned above, to allow cleaning type ops on an Index, which you expect to get an Index.
Another option is to exclude the methods entirely from the Index (meaning ones that have a default return_type='frame')

@jreback I added reture_type='index' as a alias for 'series' as you suggested, please take a look

lgtm. @jorisvandenbossche

@mortada Are you sure you committed it? I still only see the frame/series options (or I am overlooking it completely ..)

@jorisvandenbossche oops I had to do another rebase and missed the last commit, thanks for catching!

@jorisvandenbossche it's fixed, please take a look thanks

The thing I am thinking now: won't it be confusing for users to get a Index back even if he/she supplies return_type='series' on a Index.str.split, or to get a series back with Series.str.split(.., return_type='index')?
I was also thinking of another option: an expand keyword (or another name), that indicates for False: give same dimension back (so for series/index keep it a series/index), and for True: expand series to dataframe.
This would then be a duplicate for return_type of course. But the return_type was only introduced in 0.15.1 (and for partition it is still in a PR), so if we want to change this: better now than later. Or has this ship sailed?
But maybe we shouldn't block this PR with this discussion and open a new issue for this. So I am OK with merging.

@jorisvandenbossche
how about we just do
return_type='same'|'expand' to satisfy this need?

@jreback @jorisvandenbossche I'm happy to do another PR for the return_type

ok, merging this, but @mortada I would appreciate another issue (and PR!) for the return_type issue.

@mortada really a nice improvement!
I will open an new issue to discuss the return_type thing

@jorisvandenbossche thanks!
Another thing you had mentioned was expanding the docs to cover some questions on SO about cleaning up column names. Could you please point me to some of those SO questions? I can add more examples to the docs.

@mortada I don't have a specific SO question on my mind, but you often see questions like: "why does df['my_col'] give a KeyError as it is in the columns?" with response -> "check df.columns, maybe you have starting or trailing spaces in the names" (something you don't easily see in the console output, you can only detect it through the alignment)
So for me, this are typical ways to clean up column names:

remove starting/trailing whitespace (eg leftover of reading it in)
convert all columns names to lower case (eg something typical you would want for writing it to certain databases/on certain platforms to not have to deal with case sensitivity issues)
remove alle whitespace in the column names, or convert all whitespaces to underscores ("my col" -> "my_col")

@mortada  very nice, thanks!


Unexpected end of ZLIB input stream

Error: https://pastebin.com/raw/GxgBYch5

This means something corrupted the data stored on your drive. The next time it saves that region it will overwrite the corrupt file with a fresh one. I wouldn't worry about this unless it's happening often.


build(ide): set WebStorm to use path mappings only when needed

Issue or need
After resetting WebStorm configuration to be able to minimally reproduce a bug an error appeared when WebStorm helped adding import statements. The path mapping was used when importing (i.e.: @davidlj95/ngx-meta/core/src/core-providers.ts) instead of a relative import ./core-providers.ts when adding it in a file that was in core module.
Which triggered build errors regarding cyclic dependencies

Proposed changes
Configure JetBrains IDEs to use path mapping only when needed, not if relative paths can be used.

Quick reminders

🤝 I will follow Code of Conduct
✅ No existing pull request already does almost same changes
👁 Contributing docs are something I've taken a look at
📝 Commit messages convention has been followed
💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
⚙ API Report has been updated if API surface is altered.

#831  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite


Fix/auhorized decorator koa

@NoNameProvided
Looks like you've merged this PR with rebase. It's a bad idea, you should always make a merge commit to keep track of PR and changes on branches.

At work we prefer clean history, but it's totally fine for me to do merge commits. I wont rebase in the future.

That's why rebase on github looks bad 😜