When you put a column name that's a keyword in backticks, it still uppercases

System information:
Mysql M1 mac
Version <IP_ADDRESS>204170718
Describe the problem you're observing:
ALTER TABLE stuff ADD COLUMN USER  <-- It always capitalizes user as I finish typing it even though it's in backticks

@turbobuilt Hello. Can you specify when it happens? I wasn't able to reproduce it in SQL Editor

https://user-images.githubusercontent.com/7775272/166456428-0fdee38e-c5a5-4f64-8c8c-4073a1300f6d.mov
Mysql localhost:3306 Version <IP_ADDRESS>204170718, April 18 2022
I don't know what other information there is!

Hello @turbobuilt
Can you please check this setting?
Preferences -> Editors -> SQL Editor -> Code Completion -> "Insert case"

I have it set to default!

Can you change the "Inser case" setting to the "lower case"?
Default case for the MySQL/MariaDB is mixed.

There has been no update for a long time.
If the issue is still actual, feel free to reopen it.


Walkthrough is missing Step 4 is missing new build commands.

https://codelabs.developers.google.com/codelabs/vr_view_101/index.html?index=..%2F..%2Findex#3
$ git clone https://github.com/google/vrview
should be
$ git clone https://github.com/google/vrview
$ cd vrview
$ npm update
$ npm run build
Thanks

I have gotten this far. I am able to use the old vrview directory and it works. However, since the change to having to execute npm run build, I am not able to get vrview to work.
Very basic user here. How and in which program do I execute npm run build. I am trying to host everything in the cloud, no server on my side.
Thanks

Executnig npm run build from the command prompt, this is what I get
C:\Users\acely\Documents\GitHub\vrview>npm run build

<EMAIL_ADDRESS>build C:\Users\acely\Documents\GitHub\vrview
npm run build-min; npm run build-dev; npm run build-api

npm WARN invalid config loglevel="notice"
npm ERR! missing script: build-min;
npm ERR!       Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\acely\AppData\Roaming\npm-cache_logs\2017-10-05T12_45_53_491Z-debug.log

Hello @AlfkaGit -- I think this fix mentioned in another bug here might work for you. We have to update the npm build commands to work on Windows. Hope this helps in the interim!


Android - Concierge - Blank error message badge appears when tapping "Call me" button in request call  modal

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log in to NewDot with any account
Find the Concierge chat
Tap the phone icon
Tap Call

Expected Result:
The badge displayed with error message inside after tap Call
Actual Result:
The badge displayed without error message inside after tap Call
Workaround:
Unknown
Platform:

Where is this issue occurring?

Android

Version Number: 1.1.70-2
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>/ Feya87Katya
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by:  Applause internal team
Slack conversation:
View all open jobs on GitHub

Hey @kavimuru I'm unable to reproduce this issue locally, would you mind trying again?

@srikarparsi I am still able to reproduce in the version 1.1.70-3
https://user-images.githubusercontent.com/43996225/171741333-b7b52fdd-fae7-4dcc-9370-ee597aabb18f.mp4

Hey,
The error appears in web as well !
In Inbox.js file, below line is used to display message
  Growl.error(result.message, 3000);

However, when we are tapping "Call me" we are getting error from server and the result is not having the expected keys!

we are getting  error-response as Error {jsonCode: 'unableToRetry'}.
There is no "message" key coming from server in response.

Hey, thank you for the details. Do you think you can send a screen recording of the web app not working? My android emulator is currently not working and I wasn't able to reproduce it on web either.

Sure!
https://user-images.githubusercontent.com/4989101/172525088-01b78bea-e393-4d87-b4c3-ed89afca5b37.mov

Hey, thank you for the screen recording. I did some testing and was able to reproduce the error when using the production web proxy but when I used a local dev environment, staging or production, I didn't face the error. Because of this, I believe it's an error with the proxy on web at least and not the code.
https://user-images.githubusercontent.com/48188732/172953862-377e5ec1-bb25-410d-8254-7c8162244107.mov
I am also unable to reproduce this issue on android so I will close out the issue for now.


Average of 30 seconds to compile for each code change

Is this only on my machine or is this normal boilerplate for each change waiting 30 seconds?
✔ Webpack
  Compiled successfully in 30.17s

 DONE  Compiled successfully in 30195ms

System:    Host: ##### Kernel: 5.4.0-3-amd64 x86_64 bits: 64 compiler: gcc v: 8.3.0
           Desktop: Xfce 4.14.1 Distro: MX-19.1_ahs_x64 patito feo February 15  2019
           base: Debian GNU/Linux 10 (buster)
Machine:   Type: Portable System: Dell product: Inspiron 5537 v: A07 serial: <filter>
CPU:       Topology: Dual Core model: Intel Core i7-4500U bits: 64 type: MT MCP arch: Haswell
           rev: 1 L2 cache: 4096 KiB
           flags: avx avx2 lm nx pae sse sse2 sse3 sse4_1 sse4_2 ssse3 vmx bogomips: 19155
           Speed: 798 MHz min/max: 800/3000 MHz Core speeds (MHz): 1: 798 2: 798 3: 798 4: 798
Graphics:  Device-1: Intel Haswell-ULT Integrated Graphics vendor: Dell driver: i915 v: kernel
           bus ID: 00:02.0
           Device-2: AMD Sun XT [Radeon HD 8670A/8670M/8690M / R5 M330 / M430] vendor: Dell
           driver: radeon v: kernel bus ID: 03:00.0
           Display: x11 server: X.Org 1.20.4 driver: ati,modesetting,radeon unloaded: fbdev,vesa
           resolution: 1366x768~60Hz
           OpenGL: renderer: Mesa DRI Intel Haswell Mobile v: 4.5 Mesa 19.2.1 direct render: Yes
Audio:     Device-1: Intel Haswell-ULT HD Audio vendor: Dell driver: snd_hda_intel v: kernel
           bus ID: 00:03.0
Drives:    Local Storage: total: 232.89 GiB used: 90.96 GiB (39.1%)
           ID-1: /dev/sda vendor: Samsung model: SSD 750 EVO 250GB size: 232.89 GiB
Info:      Processes: 262 Uptime: 53m Memory: 7.67 GiB used: 5.74 GiB (74.8%) Init: systemd
           runlevel: 5 Compilers: gcc: 8.3.0 Shell: bash v: 5.0.3 inxi: 3.0.36

while Starting the development server take about 30s is common, change code just 5s. Build also take 30s.hope sth. like snowpack\vite conquer react one day.

有没有解决方法，我也是类似的情况不过情况比你好点，我的在15秒左右。

@cglang webpack做不到，所以有vite/snowpack

glad to see https://github.com/sorrycc/blog/issues/97.
with upgrade of<EMAIL_ADDRESS>webpack5 is supported.
add  webpack5: { lazyCompilation: {} } in .umirc, first dev load time is decrease to 10s.
while in production, azyCompilation: {} could be removed


Sideload does not work after following instructions on this sample readme

Repro steps:

Visit https://github.com/OfficeDev/Word-Scenario-based-Add-in-Samples/tree/main/Word-Add-in-AIGC#sideload-the-sample-add-in-on-word-online
Follow instructions step by step to sideload manifest with Word online
Task pane does not load properly as shown in screenshot

Seems like I found the cause, if the localhost does not run, this error will show, with 'npm run start' if I try again, the sideload on Word online works as expected.


[camerax] ResolutionPreset.medium image stream generates 640x480 images on Android, not 720x480 ones like with camera_android and as stated in the doc

Steps to reproduce

Create a simple Flutter application.
Use the following dependencies on your pubspec.yaml:

camera: ^0.10.5+9

Set up a camera controller using ResolutionPreset.medium and start an image stream through startImageStream.
Run the application on a real device. I use a Sony Z5C with Android 7.1.1 and a Google Pixel 6a with Android 14.
Now update your pubspec.yaml:

camera: ^0.10.5+9
camera_android_camerax: ^0.5.0+26

Perform a flutter clean (to be on the safe side) and run your application again.

Expected results
The CameraImage image instance obtained from the stream should have a resolution of 720x480 in all cases (camera_android and camera_android_camerax) - shouldn't it?
The documentation of ResolutionPreset states:
  /// 480p (640x480 on iOS, 720x480 on Android and Web)
  medium,

I haven't tried with other ResolutionPresets.
Actual results
CameraImage has a resolution of

720x480 when camera_android is used (this matches what the documentation says). The aspect ratio of the camera preview is 720/480=1.5.
640x480 when camera_android_camerax is used. The aspect ratio of the camera preview is 640/480=1.333.

I am (personally) fine if 640x480 is used with camera_android_camerax, but the documentation needs to be updated (or the code of camera_android_camerax or camera_android needs to be changed?)
640x480 matches the iOS resolution.
Code sample
Code sample

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[√] Flutter (Channel stable, 3.16.7, on Microsoft Windows [version 10.0.22000.2538], locale fr-FR)
    • Flutter version 3.16.7 on channel stable at C:\Users\andy\Documents\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ef1af02aea (7 days ago), 2024-01-11 15:19:26 -0600
    • Engine revision 4a585b7929
    • Dart version 3.2.4
    • DevTools version 2.28.5

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\andy\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.0.2)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.0.31919.166
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2022.2)
    • Android Studio at C:\Users\andy\Documents\Applications\android-studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)

[√] Android Studio (version 2022.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)

[√] IntelliJ IDEA Community Edition (version 2021.3)
    • IntelliJ at C:\Users\andy\Documents\Applications\IntelliJ
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] VS Code (version 1.85.1)
    • VS Code at C:\Users\andy\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.80.0

[√] Connected device (5 available)
    • Pixel 6a (mobile) • 29231JEGR03669 • android-arm64  • Android 14 (API 34)
    • E5823 (mobile)    • CB5A28LMYH     • android-arm64  • Android 7.1.1 (API 25)
    • Windows (desktop) • windows        • windows-x64    • Microsoft Windows [version 10.0.22000.2538]
    • Chrome (web)      • chrome         • web-javascript • Google Chrome 120.0.6099.218
    • Edge (web)        • edge           • web-javascript • Microsoft Edge 120.0.2210.133

[√] Network resources
    • All expected network resources are available.

• No issues found!

Thanks for the report. I also can reproduce this issue on my device Realme 6, Android 11 with sample code below (using a piece of code at https://github.com/flutter/flutter/issues/138933#issue-2007478819, and save this sample code to a new file at the plugin example lib directory).

Sample code
import 'dart:async';
import 'dart:io';

import 'package:camera_platform_interface/camera_platform_interface.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';

import 'camera_controller.dart';
import 'camera_image.dart';
import 'camera_preview.dart';

Future<void> main() async {
  // Ensure that plugin services are initialized so that `availableCameras()`
  // can be called before `runApp()`
  WidgetsFlutterBinding.ensureInitialized();

  // Obtain a list of the available cameras on the device.
  final cameras = await availableCameras();

  // Get a specific camera from the list of available cameras.
  final firstCamera = cameras.first;

  runApp(
    MaterialApp(
      theme: ThemeData.dark(),
      home: TakePictureScreen(
        // Pass the appropriate camera to the TakePictureScreen widget.
        camera: firstCamera,
      ),
    ),
  );
}

// A screen that allows users to take a picture using a given camera.
class TakePictureScreen extends StatefulWidget {
  const TakePictureScreen({
    super.key,
    required this.camera,
  });

  final CameraDescription camera;

  @override
  TakePictureScreenState createState() => TakePictureScreenState();
}

class TakePictureScreenState extends State<TakePictureScreen> {
  late CameraController _controller;
  late Future<void> _initializeControllerFuture;

  @override
  void initState() {
    super.initState();
    // To display the current output from the Camera,
    // create a CameraController.
    _controller = CameraController(
      // Get a specific camera from the list of available cameras.
      widget.camera,
      // Define the resolution to use.
      ResolutionPreset.medium,
    );

    // Next, initialize the controller. This returns a Future.
    _initializeControllerFuture = _controller.initialize();
  }

  @override
  void dispose() {
    // Dispose of the controller when the widget is disposed.
    _controller.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('Take a picture')),
      // You must wait until the controller is initialized before displaying the
      // camera preview. Use a FutureBuilder to display a loading spinner until the
      // controller has finished initializing.
      body: FutureBuilder<void>(
        future: _initializeControllerFuture,
        builder: (context, snapshot) {
          if (snapshot.connectionState == ConnectionState.done) {
            // If the Future is complete, display the preview.
            return CameraPreview(_controller);
          } else {
            // Otherwise, display a loading indicator.
            return const Center(child: CircularProgressIndicator());
          }
        },
      ),
      floatingActionButton: FloatingActionButton(
        // Provide an onPressed callback.
        onPressed: () async {
          // Take the Picture in a try / catch block. If anything goes wrong,
          // catch the error.
          try {
            // Ensure that the camera is initialized.
            await _initializeControllerFuture;
            _controller.startImageStream(_processCameraImage);
            if (!mounted) {
              return;
            }
            setState(() {});
          } catch (e) {
            // If an error occurs, log the error to the console.
            print(e);
          }
        },
        child: const Icon(Icons.camera_alt),
      ),
    );
  }

  Future _processCameraImage(CameraImage image) async {
    final WriteBuffer allBytes = WriteBuffer();
    for (final Plane plane in image.planes) {
      allBytes.putUint8List(plane.bytes);
    }
    final bytes = allBytes.done().buffer.asUint8List();

    final Size imageSize = Size(image.width.toDouble(), image.height.toDouble());
    print("size: ${imageSize.width} / ${imageSize.height}");
  }
}

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.16.8, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.16.8 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 67457e669f (27 hours ago), 2024-01-16 16:22:29 -0800
    • Engine revision 6e2ea58a5c
    • Dart version 3.2.5
    • DevTools version 2.28.5

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio Hedgehog.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.85.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.80.0

[✓] Connected device (3 available)
    • iPhone (mobile) • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.8 19H370
    • macOS (desktop) • macos                                    • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)    • chrome                                   • web-javascript • Google Chrome 120.0.6099.234

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.19.0-8.0.pre.49, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.19.0-8.0.pre.49 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 70a4a5de7c (46 minutes ago), 2024-01-18 21:32:18 -0500
    • Engine revision d1afda52d2
    • Dart version 3.4.0 (build 3.4.0-24.0.dev)
    • DevTools version 2.31.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio Hedgehog.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.85.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.80.0

[✓] Connected device (3 available)
    • iPhone (mobile) • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.8 19H370
    • macOS (desktop) • macos                                    • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)    • chrome                                   • web-javascript • Google Chrome 120.0.6099.234

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Can I stress that it is really nice as it is currently - same dimensions for both iOS and Android (640x480 for the medium preset). Just my opinion. Of course, clarifying this for the longer term would help either way, which is why I created the issue.

I double checked and the plugin does request a 720x480 resolution from CameraX for ResolutionPreset.medium (see source), and we also request that CameraX finds the next highest resolution if the resolution requested is unavailable (see source), so it must be that CameraX is falling back to that behavior and choosing 640x480.
It looks like CameraX has some noted limitations for specifying resolutions for ImageAnalysis, the image streaming use case, specifically so I want to note those: https://developer.android.com/reference/androidx/camera/core/ImageAnalysis.Builder#setResolutionSelector(androidx.camera.core.resolutionselector.ResolutionSelector). What stands out to me is that 640x480 is the default resolution and that there are some limitations for limited level hardware devices.

I also want to note that I found a CameraX bug that seems to be referencing a similar issue: https://b.corp.google.com/issues/162121234.

In summary, I see a short term and long term fix here:

Short term: Add documentation that clarifies that the specified preset resolution is a target and CameraX may choose otherwise according to the fallback rule we specified.
Long term: Have this plugin perform a best effort attempt to use the preset resolution. This would potentially involve using camera characteristics to determine the limitations of the hardware camera and taking any actions like binding/unbinding CameraX UseCases as described in the documentation that I mentioned above to best attempt achieving that resolution.

I'm going to do the short term solution now and file an issue for the long term solution, since I believe doing this to be lower priority. That would intentionally involve overriding CameraX default behavior and I think the goal here (unless this issue becomes bothersome for users) is to keep our behavior consistent with theirs to have a more maintainable plugin.
@mariamhas would love you to weigh in here, especially if you feel otherwise!

Short term: Add documentation that clarifies that the specified preset resolution is a target and CameraX may choose otherwise according to the fallback rule we specified.

As long as camera_android_camerax does everything that can possibly be done to return a resolution that is at least the requested resolution (640x480 in this example), this sounds good to me IMHO. If there is no hope to return the requested resolution because of, eg., a hardware limitation, I would personally fail, and let the developer attempt to use a lower resolution. Following your reply here, point 1, that's what I understand the code does.

Does camera_android really guarantee (100% of the time) 720x480 for, eg., the medium preset?
In case you get a headache with exact resolution values, wouldn't it be preferable to just enumerate all supported resolutions and let the developer decide based on this? The spec of camera_platform_interface cannot be fuzzy about resolution values, IMHO. Being vague goes nowhere, I think.
CameraX resolution strategies like "higher_then_lower" feel so weird, I have a hard time understanding them.

As of now, camera_android_camerax does everything that can be done to target the preset resolution and that is, I believe, it's responsibility. To maintain consistency with camera_android, the resolution will fall back to the closest but lower resolution available (in that way, camera_android does not really guarantee (100% of the time) 720x480 for, eg., the medium preset). These facts I will clarify in the documentation.
CameraX not choosing the target resolution for a reason that is not related to hardware limitations (I assume performance optimizations of some kind) is a feature request for them; however, we could certainly forward that feedback along!
Surfacing the supported resolutions to the user versus automatically falling back to a lower one is a feature request for changing how the plugin handles setting resolution for camera use cases, and I would recommend opening a separate issue for that!


SyntaxError: invalid syntax

hey! congrats on launching in HN!
the install went fine but i get this when i run it:
 ✝  ~/OpenSource/OpenSourceApps   master  termtosvg
Traceback (most recent call last):
  File "/usr/local/bin/termtosvg", line 7, in <module>
    from termtosvg.__main__ import main
  File "/Library/Python/2.7/site-packages/termtosvg/__main__.py", line 144
    print(record.to_json_line(), file=cast_file)
                                     ^
SyntaxError: invalid syntax

is python 2.7 not supported?

README says:

termtosvg is compatible with Python >= 3.5

That said, the way the program fails is not very helpful.

lol. cant believe i missed that. i'm gonna close, feel free to reopen if 2.7 support is easy


Transform overview lessons

This addresses the issues present in https://github.com/carpentries/workbench/issues/65

This is ready once https://github.com/carpentries/sandpaper/pull/496 and https://github.com/carpentries/varnish/pull/87 are merged


Hide pages from search

[ ] Assets folders must be excluded

Closing, was an issue only in the previous theme.


Use gulp-jspm

Instead of using a seperate NPM script for building jspm, https://github.com/brillout/gulp-jspm could be used instead
(I am the author of gulp-jspm)

I've made a version using gulp-jspm. Thanks for creating the plugin, very useful :)
https://github.com/kmturley/es6-modules

Open-source ftw! :+1:

@kmturley I've circled back and decided to leverage your plugin since it adds value and helps with the build tasks running in the correct order.
Thanks for the great plugin! :+1:

No problem, glad I could help! There are some useful things to note with gulp tasks:

Use return to tell gulp to wait for task to finish:
gulp.task('clean', function () {
return del(['www']);
});

Use variables for your paths so they can be changed in one place:
global.paths = {
css: '//*.css',
html: '//.html',
img: '/**/.{jpg,png}',
js: '/**/*.js',
};

If you want a task to finish before another task, then it should be a dependancy e.g. the clean folder task:

Should not be:
gulp.task('optimise', ['clean', 'optimise.html',  'optimise.js']);

Should be:
gulp.task('optimise.html', ['clean'], function () {
    // do something
});

gulp.task('optimise.js', ['clean'], function () {
    // do something
});

@kmturley Right on, thanks for sharing that!  In other projects what I've also done a lot of is use execSync for abstract build tasks when the order of execution of dependencies is critical.
To be honest, the build is super minimalistic, I should probably spruce it up a bit :)


Failing Test Scenario Recover keys after a (simulated) failed key change

Failing test:
https://ci.opensmartgridplatform.org/view/Nightly/job/OSGP_open-smart-grid-platform_nightly/1707/cucumber-html-reports/report-feature_145_2784502065.html
Solution: give test more seconds before timeout
Signed-off-by: Harry Middelburg<EMAIL_ADDRESS>

Nightly: https://ci.opensmartgridplatform.org/view/Nightly/job/OSGP_open-smart-grid-platform_nightly/1713/


Update pt.json

thank you so much!!

@ViPeR5000 you gracefully supported this translation for V1, can I convince you to translate V2 (currently in beta) as well, please?  There are two language files this time: one in smart_irrigation/translations and one in smart_irrigation/frontend/localize/languages. Please make a PR against the V2.0 branch.
Thanks in advance!!


Extraneous virtualenv created when installing VCS dependencies using --system

I noticed an issue in my docker builds this morning using this Dockerfile:
FROM python:3.6

WORKDIR /app

COPY . .
COPY docker-entrypoint.sh /
RUN chmod +x /docker-entrypoint.sh
RUN pip install -U pip
RUN pip install pipenv
RUN pipenv install --deploy --system
RUN python -m pipenv.help
ENV PYTHONPATH /app
ENTRYPOINT ["/docker-entrypoint.sh"]

(Pretty standard stuff, I don't believe Docker is the issue here)
Here is a log of the docker build:
Step 1/11 : FROM python:3.6
 ---> 336d482502ab
Step 2/11 : WORKDIR /app
 ---> Using cache
 ---> 485f81cfa840
Step 3/11 : COPY . .
 ---> 278a192259f0
Step 4/11 : COPY docker-entrypoint.sh /
 ---> 1210932b20d0
Step 5/11 : RUN chmod +x /docker-entrypoint.sh
 ---> Running in e48c96b56ad0
Removing intermediate container e48c96b56ad0
 ---> 81d6e6e219bf
Step 6/11 : RUN pip install -U pip
 ---> Running in 55d86b67eef8
Collecting pip
  Downloading pip-9.0.3-py2.py3-none-any.whl (1.4MB)
Installing collected packages: pip
  Found existing installation: pip 9.0.1
    Uninstalling pip-9.0.1:
      Successfully uninstalled pip-9.0.1
Successfully installed pip-9.0.3
Removing intermediate container 55d86b67eef8
 ---> 6c30f77d7fc0
Step 7/11 : RUN pip install pipenv
 ---> Running in 13e33223bd42
Collecting pipenv
  Downloading pipenv-11.10.0-py3-none-any.whl (5.6MB)
Requirement already satisfied: setuptools>=36.2.1 in /usr/local/lib/python3.6/site-packages (from pipenv)
Requirement already satisfied: pip>=9.0.1 in /usr/local/lib/python3.6/site-packages (from pipenv)
Collecting virtualenv (from pipenv)
  Downloading virtualenv-15.2.0-py2.py3-none-any.whl (2.6MB)
Collecting certifi (from pipenv)
  Downloading certifi-2018.1.18-py2.py3-none-any.whl (151kB)
Collecting virtualenv-clone>=0.2.5 (from pipenv)
  Downloading virtualenv_clone-0.3.0-py2.py3-none-any.whl
Installing collected packages: virtualenv, certifi, virtualenv-clone, pipenv
Successfully installed certifi-2018.1.18 pipenv-11.10.0 virtualenv-15.2.0 virtualenv-clone-0.3.0
Removing intermediate container 13e33223bd42
 ---> 2ee25119966e
Step 8/11 : RUN pipenv install --deploy --system
 ---> Running in f541b2c43311
Installing -e git+https://github.com/stratasan/stratatilities.git#egg=stratatilities…
Obtaining stratatilities from git+https://github.com/stratasan/stratatilities.git#egg=stratatilities
  Cloning https://github.com/stratasan/stratatilities.git to ./src/stratatilities
Collecting Click>=6.0 (from stratatilities)
  Downloading click-6.7-py2.py3-none-any.whl (71kB)
Collecting boto3 (from stratatilities)
  Downloading boto3-1.7.4-py2.py3-none-any.whl (128kB)
Collecting requests (from stratatilities)
  Downloading requests-2.18.4-py2.py3-none-any.whl (88kB)
Collecting hvac (from stratatilities)
  Downloading hvac-0.5.0.tar.gz
Collecting jmespath<1.0.0,>=0.7.1 (from boto3->stratatilities)
  Downloading jmespath-0.9.3-py2.py3-none-any.whl
Collecting botocore<1.11.0,>=1.10.4 (from boto3->stratatilities)
  Downloading botocore-1.10.4-py2.py3-none-any.whl (4.2MB)
Collecting s3transfer<0.2.0,>=0.1.10 (from boto3->stratatilities)
  Downloading s3transfer-0.1.13-py2.py3-none-any.whl (59kB)
Requirement already satisfied: certifi>=2017.4.17 in /usr/local/lib/python3.6/site-packages (from requests->stratatilities)
Collecting urllib3<1.23,>=1.21.1 (from requests->stratatilities)
  Downloading urllib3-1.22-py2.py3-none-any.whl (132kB)
Collecting chardet<3.1.0,>=3.0.2 (from requests->stratatilities)
  Downloading chardet-3.0.4-py2.py3-none-any.whl (133kB)
Collecting idna<2.7,>=2.5 (from requests->stratatilities)
  Downloading idna-2.6-py2.py3-none-any.whl (56kB)
Collecting docutils>=0.10 (from botocore<1.11.0,>=1.10.4->boto3->stratatilities)
  Downloading docutils-0.14-py3-none-any.whl (543kB)
Collecting python-dateutil<2.7.0,>=2.1 (from botocore<1.11.0,>=1.10.4->boto3->stratatilities)
  Downloading python_dateutil-2.6.1-py2.py3-none-any.whl (194kB)
Collecting six>=1.5 (from python-dateutil<2.7.0,>=2.1->botocore<1.11.0,>=1.10.4->boto3->stratatilities)
  Downloading six-1.11.0-py2.py3-none-any.whl
Building wheels for collected packages: hvac
  Running setup.py bdist_wheel for hvac: started
  Running setup.py bdist_wheel for hvac: finished with status 'done'
  Stored in directory: /root/.cache/pip/wheels/8c/2f/a0/ffeca10bbc3c674c2423c61c9037ec5d5a573a70a29ee423e3
Successfully built hvac
Installing collected packages: Click, jmespath, docutils, six, python-dateutil, botocore, s3transfer, boto3, urllib3, chardet, idna, requests, hvac, stratatilities
  Running setup.py develop for stratatilities
Successfully installed Click-6.7 boto3-1.7.4 botocore-1.10.4 chardet-3.0.4 docutils-0.14 hvac-0.5.0 idna-2.6 jmespath-0.9.3 python-dateutil-2.6.1 requests-2.18.4 s3transfer-0.1.13 six-1.11.0 stratatilities urllib3-1.22

Adding -e git+https://github.com/stratasan/stratatilities.git#egg=stratatilities to Pipfile's [packages]…
Creating a virtualenv for this project…
Using /usr/local/bin/python (3.6.4) to create virtualenv…
Already using interpreter /usr/local/bin/python
Using base prefix '/usr/local'
New python executable in /root/.local/share/virtualenvs/app-4PlAip0Q/bin/python
Installing setuptools, pip, wheel...done.

Virtualenv location: /root/.local/share/virtualenvs/app-4PlAip0Q
Installing dependencies from Pipfile.lock (6f84a9)…
Ignoring contextlib2: markers 'python_version < "3.2"' don't match your environment
Removing intermediate container f541b2c43311
 ---> ef23e9d6838c
Step 9/11 : RUN python -m pipenv.help
 ---> Running in 55fe7525e82e
<details><summary>$ python -m pipenv.help output</summary>

Pipenv version: `'11.10.0'`

Pipenv location: `'/usr/local/lib/python3.6/site-packages/pipenv'`

Python location: `'/usr/local/bin/python'`

Other Python installations in `PATH`:

  - `2.7`: `/usr/bin/python2.7`
  - `2.7`: `/usr/bin/python2.7`
  - `3.6`: `/usr/local/bin/python3.6m`
  - `3.6`: `/usr/local/bin/python3.6`
  - `3.6`: `/usr/local/bin/python3.6`

  - `3.6.4`: `/usr/local/bin/python`
  - `3.6.4`: `/usr/local/bin/python`
  - `2.7.9`: `/usr/bin/python`
  - `2.7.9`: `/usr/bin/python2`
  - `3.6.4`: `/usr/local/bin/python3`
  - `3.6.4`: `/usr/local/bin/python3`

PEP 508 Information:

{'implementation_name': 'cpython',
'implementation_version': '3.6.4',
'os_name': 'posix',
'platform_machine': 'x86_64',
'platform_python_implementation': 'CPython',
'platform_release': '4.9.87-linuxkit-aufs',
'platform_system': 'Linux',
'platform_version': '#1 SMP Wed Mar 14 15:12:16 UTC 2018',
'python_full_version': '3.6.4',
'python_version': '3.6',
'sys_platform': 'linux'}

System environment variables:

  - `HOSTNAME`
  - `PYTHON_PIP_VERSION`
  - `HOME`
  - `GPG_KEY`
  - `PATH`
  - `LANG`
  - `PYTHON_VERSION`
  - `PWD`
  - `PYTHONDONTWRITEBYTECODE`
  - `PIP_PYTHON_PATH`
  - `PYTHONUNBUFFERED`

Pipenv–specific environment variables:

Debug–specific environment variables:

  - `PATH`: `/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin`
  - `LANG`: `C.UTF-8`
  - `PWD`: `/app`

---------------------------

Contents of `Pipfile` ('/app/Pipfile'):

```toml
[[source]]
url = "https://pypi.python.org/simple"
verify_ssl = true
name = "pypi"

[packages]
boto = "*"
"boto3" = "*"
hvac = "*"
luigi = "*"
"psycopg2-binary" = "*"
raven = "*"
stratatilities = {git = "https://github.com/stratasan/stratatilities.git", editable = true}
click = "*"
botocore = "*"
structlog = "*"

[dev-packages]
ipython = {extras = ["notebook"]}
nbformat = "*"
awscli = "*"
colorama = "*"
pytest = "*"
"flake8" = "*"

[requires]
python_version = "3.6"

Contents of Pipfile.lock ('/app/Pipfile.lock'):
{
       <snip>
        "stratatilities": {
            "editable": true,
            "git": "https://github.com/stratasan/stratatilities.git",
            "ref": "0027bc89c005d5842560d856c59b2bcb72605a71"
        },
        </snip>

Removing intermediate container 55fe7525e82e
 ---> 3e730a1c2fa6
Step 10/11 : ENV PYTHONPATH /app
 ---> Running in 5eeb6a675f18
Removing intermediate container 5eeb6a675f18
 ---> d2fb733b0987
Step 11/11 : ENTRYPOINT ["/docker-entrypoint.sh"]
 ---> Running in d6af7ad2592b
Removing intermediate container d6af7ad2592b
 ---> 4fd18ed472d9
Successfully built 4fd18ed472d9
Successfully tagged peach:latest
```
Expected result
A new virtualenv should not be created when editable dependencies are encountered using --system.
Actual result
If you look in the logs above, there's a new virtualenv created within the container that only contains stratatilities (look for Virtualenv location: /root/.local/share/virtualenvs/app-4PlAip0Q). I believe this is related to recent 11.10.0 changes (potentially #1812?) because this behavior does not occur when pinning pipenv to 11.9.0.
Steps to replicate
A similar Dockerfile that installs w/ a Pipfile that installs django via vcs has the same behavior
$ cat Dockerfile
FROM python:3.6

WORKDIR /app

COPY . .
RUN pip install -U pip
RUN pip install pipenv
RUN pipenv install --deploy --system
ENV PYTHONPATH /app
$ cat Pipfile
[[source]]

url = "https://pypi.python.org/simple"
verify_ssl = true
name = "pypi"

[packages]

Django = {git = "https://github.com/django/django.git", editable = true}

[dev-packages]

[requires]

python_version = "3.6"
$ docker build .                                                                                ~/dev/pipenv-test
Sending build context to Docker daemon  4.608kB
Step 1/7 : FROM python:3.6
 ---> 336d482502ab
Step 2/7 : WORKDIR /app
 ---> Using cache
 ---> 485f81cfa840
Step 3/7 : COPY . .
 ---> 49c882489ae1
Step 4/7 : RUN pip install -U pip
 ---> Running in 4e655cc62b67
Collecting pip
  Downloading pip-9.0.3-py2.py3-none-any.whl (1.4MB)
Installing collected packages: pip
  Found existing installation: pip 9.0.1
    Uninstalling pip-9.0.1:
      Successfully uninstalled pip-9.0.1
Successfully installed pip-9.0.3
Removing intermediate container 4e655cc62b67
 ---> 5477835d99bd
Step 5/7 : RUN pip install pipenv
 ---> Running in 16c2f32f55e4
Collecting pipenv
  Downloading pipenv-11.10.0-py3-none-any.whl (5.6MB)
Collecting virtualenv-clone>=0.2.5 (from pipenv)
  Downloading virtualenv_clone-0.3.0-py2.py3-none-any.whl
Requirement already satisfied: pip>=9.0.1 in /usr/local/lib/python3.6/site-packages (from pipenv)
Requirement already satisfied: setuptools>=36.2.1 in /usr/local/lib/python3.6/site-packages (from pipenv)
Collecting virtualenv (from pipenv)
  Downloading virtualenv-15.2.0-py2.py3-none-any.whl (2.6MB)
Collecting certifi (from pipenv)
  Downloading certifi-2018.1.18-py2.py3-none-any.whl (151kB)
Installing collected packages: virtualenv-clone, virtualenv, certifi, pipenv
Successfully installed certifi-2018.1.18 pipenv-11.10.0 virtualenv-15.2.0 virtualenv-clone-0.3.0
Removing intermediate container 16c2f32f55e4
 ---> 0d6b971f8cad
Step 6/7 : RUN pipenv install --deploy --system
 ---> Running in 1c8c621383f8
Installing -e git+https://github.com/django/django.git#egg=Django…
Obtaining Django from git+https://github.com/django/django.git#egg=Django
  Cloning https://github.com/django/django.git to ./src/django
Collecting pytz (from Django)
  Downloading pytz-2018.4-py2.py3-none-any.whl (510kB)
Installing collected packages: pytz, Django
  Running setup.py develop for Django
Successfully installed Django pytz-2018.4

Adding -e git+https://github.com/django/django.git#egg=Django to Pipfile's [packages]…
Creating a virtualenv for this project…
Using /usr/local/bin/python (3.6.4) to create virtualenv…
Already using interpreter /usr/local/bin/python
Using base prefix '/usr/local'
New python executable in /root/.local/share/virtualenvs/app-4PlAip0Q/bin/python
Installing setuptools, pip, wheel...done.

Virtualenv location: /root/.local/share/virtualenvs/app-4PlAip0Q
Installing dependencies from Pipfile.lock (504886)…
Removing intermediate container 1c8c621383f8
 ---> 8e08221d59d2
Step 7/7 : ENV PYTHONPATH /app
 ---> Running in b2dbe9c39856
Removing intermediate container b2dbe9c39856
 ---> f65135fd2dbf
Successfully built f65135fd2dbf

Sorry if this is super verbose but I hope it helps everyone involved track it down.

per #1939 and #1979 you need to include a lockfile -- see https://github.com/pypa/pipenv/issues/1002#issuecomment-381128601
editable vcs dependencies require you to do dependency resolution which always requires a virtualenv

@techalchemy I am a little confused by the statement:
"editable vcs dependencies require you to do dependency resolution which always requires a virtualenv".
We have editable dependencies in our Pipfile, and when we run pipenv install --system --deploy --verbose in our dockerfile it is creating a virtualenv and a lock file from scratch (even though the lock file is in the image). Is this unavoidable? (it takes an extremely long time...).
This is the output - it happens after it's installed all the editable/local dependencies, and can take 20mins or so.
Creating a virtualenv for this project…
Using /usr/local/bin/python3.6 (3.6.2) to create virtualenv…
Already using interpreter /usr/local/bin/python3.6
Using base prefix '/usr/local'
New python executable in /root/.local/share/virtualenvs/slurmfactory-vhvnywio/bin/python3.6
Also creating executable in /root/.local/share/virtualenvs/slurmfactory-vhvnywio/bin/python
Installing setuptools, pip, wheel...done.

Virtualenv location: /root/.local/share/virtualenvs/slurmfactory-vhvnywio
Pipfile.lock (d9d4e3) out of date, updating to (cc6154)…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…

@joejuzl the —deploy flag is supposed to fail if the lockfile is out of date. If this is not happening please file an issue on that.
No, —system is not meant to create virtualenvs. The problem is you showed me your output but not your input. If you’re experiencing unexpected behavior I need all of your inputs

So the contents of my Pipfileis:
[[source]]

url = "https://pypi.python.org/simple"
verify_ssl = true
name = "pypi"

[packages]

"0527503" = {path = "../diomedes/", editable = true}
"502a27f" = {path = "../tube_transport/", editable = true}
"6f2d9c9" = {path = "../base/", editable = true}
"91927d2" = {path = "../ml_runner/", editable = true}
"7e3d267" = {path = "../xb_logging/", editable = true}
"ecc5d41" = {path = "../mail_utils/", editable = true}
"d4b7ac4" = {path = "../xb_activity_report/", editable = true}
"argon2" = "==0.1.10"
"argon2-cffi" = "==16.3.0"
"jinja2" = "==2.9.6"
aioredis = "==0.3.0"
arrow = "==0.10.0"
click = "==6.7"
flask = "==0.12.2"
itsdangerous = "==0.24"
keras = "==2.0.3"
markupsafe = "==1.0"
pyowm = "==2.7.1"
python-dateutil = "==2.6.0"
python-gmaps = "==0.3.1"
redlock-py = "==1.0.8"
rq = "==0.8.0"
rq-dashboard = "==0.3.8"
rq-scheduler = "==0.7.0"
scikit-learn = "==0.18.1"
scipy = "==0.19.0"
six = "==1.10.0"
uvloop = "==0.8.0"
werkzeug = "==0.12.2"
sklearn = "*"

[dev-packages]

coverage = "*"
pylint = "*"
pytest = "*"
pytest-cov = "*"
pytest-env = "*"
pytest-mock = "*"
pytest-sugar = "*"

I have attached the Pipfile.lock as it's quite large (changed to .txt so I can upload).
Pipfile_lock.txt
They are both in the directory slurmfactory
This is my docker file:
FROM eu.gcr.io/io-xbird-milkyway/base:1.0

COPY . /opt/app/
WORKDIR /opt/app/slurmfactory
RUN pipenv install --system --deploy --verbose
ENV PYTHONUNBUFFERED 1

I have attached the output of my docker build up until it hangs for 20mins creating a lock file. After that point it just continues to install all the non-editable dependencies.
docker_build_output.txt
If you need anything else, let me know!
This only happens on 11.10.0 not 11.9.0
Thanks!

@joejuzl try pip install —upgrade —pre pipenv and let me know if this is resolved

I get his error when running pipenv lock
Locking [dev-packages] dependencies…
odule>
    from .pypi import PyPIRepository
  File "/usr/local/lib/python3.6/site-packages/pipenv/patched/piptools/repositories/pypi.py", line 11, in <module>
    from notpip.index import PackageFinder
  File "/usr/local/lib/python3.6/site-packages/pipenv/patched/notpip/index.py", line 33, in <module>
    from notpip._vendor import html5lib, requests, six
  File "/usr/local/lib/python3.6/site-packages/pipenv/patched/notpip/_vendor/requests/__init__.py", line 98, in <module>
    from . import packages
  File "/usr/local/lib/python3.6/site-packages/pipenv/patched/notpip/_vendor/requests/packages.py", line 8, in <module>
    locals()[package] = __import__(vendored_package)
ModuleNotFoundError: No module named 'pip._vendor.urllib3'

@joejuzl the comment directly above yours describes a temporary fix, I’ll have a release out in an hour or so

This error is still occuring, is there any recommended fix?


Add HTTP API logger, #27570

https://is.roihunter.com/issues/27570
I was just thinking that maybe DI container should be removed and replaces by global services. What do you think?
@business-factory/pythonistas Please review and merge

@Joozty I updated dev branch from master branch (it is not automatic) and set the base branch to master branch (dev branch is unused actually). There are some conflicts apparently, if you would please look at them. :-)
Anyway, I like the idea of global services, just like we have them in other private projects. :-)

@martinvy Thanks for fixes. It's kind of a shame that I did it mostly because of API a I didn't even pass logger to endpoints. :smile: About the _to_decimal you are right. I didn't realise the additional functionality of it. I added two more commits. Please have a look.

@martinvy Take a last look if you want to. :-)


Split northbound and southbound endpoints.

Signed-off-by: Dale Bremner<EMAIL_ADDRESS>

jenkins: depends on https://github.com/RackHD/RackHD/pull/790


Feature zoom to marker

Fixes Issue

Closes #66
Changes proposed

This will add a zoom to feature on each new event to highlight contributors
Another ticket will be opened to refine this feature to consider marker state and only zoom in on new to the map users
This feature will need testing in a live environment to see how it handles new events coming in and the pacing.

Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[X] This PR does not contain plagiarized content.
[X] The title of my pull request is a short description of the requested changes.

Screenshots
Short video of the feature in action
https://user-images.githubusercontent.com/97615019/206065582-2c7bcf7d-dd7c-4850-8feb-44afa2c09929.mov
Note to reviewers
Needs to be tested with more events coming in at the expected live stream pace and likely refined based on that info

Looks great Amanda 👍


Grouped notifications

Add tread-id for notification grouping.

Ooops... this was meant to be a PR to a private fork.


for Windows

Would like to devlop for windows also

Hi Tanmay. This is not an "issue". Have you seen the Discussions tab? We could discuss this there. I had created the program to be cross-platform (which means it should work on multiple OS'es). If you'd like to adapt it, I could add you as a collaborator.


fix: uniq singleflight key

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.16%. Comparing base (279568d) to head (daf96df).
Report is 6 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   92.16%   92.16%
=======================================
  Files           4        4
  Lines         702      702
=======================================
  Hits          647      647
  Misses         40       40
  Partials       15       15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Python: notebooks: await planner.create_plan(ask, kernel) -- TypeError: can only concatenate str (not "NoneType") to str

Describe the bug
TypeError: can only concatenate str (not "NoneType") to str
In file: python/notebooks/05-using-the-planner.ipynb
To Reproduce
I run the code step by step without changing anything.
In Basic Plan section.
basic_plan = await planner.create_plan(ask, kernel)
Screenshots

Platform

OS: [Mac]
IDE: [e.g. Visual Studio]
Language: [Python]
Source: [ main branch of repository, python/notebooks/05-using-the-planner.ipynb]

Additional context
Thanks.

Hi, I just made some updates to that notebook, could you try again? The code behind was fixed but not yet released so you will have to install either from git or use poetry in a cloned environment or wait until the package is updated

Thank you so much. I will try it later.

I ran into the same error. The updated code was released with version 0.9.3b1. This notebook works after updating to that version!


Upgrade script results in 'something went wrong'

BookStack v0.18.2
PHP:
PHP 7.0.25-1+ubuntu16.04.1+deb.sury.org+1 (cli) (built: Oct 27 2017 13:43:45) ( NTS )
Zend Engine v3.0.0, Copyright (c) 1998-2017 Zend Technologies
with Zend OPcache v7.0.25-1+ubuntu16.04.1+deb.sury.org+1, Copyright (c) 1999-2017, by Zend Technologies
MySQL:
mysql  Ver 14.14 Distrib 5.7.20, for Linux (x86_64) using  EditLine wrapper
Ubuntu:
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.3 LTS
Release:        16.04
Codename:       xenial
Expected Behavior
running the upgrade script to 0.19 should just work.
Current Behavior
Instead of the typical Bookstack site, the browser displays the 'something went wrong' page.
Steps to Reproduce
Following these instructions here: https://www.bookstackapp.com/docs/admin/updates/

I had a similar problem and then realised that the update script needs to be ran as sudo.
Try this?

I ran it as Sudo.
Patrick Lynch
c:<PHONE_NUMBER> | v:<PHONE_NUMBER> | g: lynchpatrickj
On Sat, Dec 23, 2017 at 4:09 PM, Jonathan Adams<EMAIL_ADDRESS>wrote:

I had a similar problem and then realised that the update script needs to
be ran as sudo.
Try this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BookStackApp/BookStack/issues/627#issuecomment-353748274,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJVoYR1z9l6diwSbXVKu861IUEU8HKDvks5tDWvsgaJpZM4RKWgj
.

Hi @lynchpatrickj,
Sorry to hear you're having issues.
Did you see any error text or warnings during when running then update commands?
To get more information about why your instance is not running correctly you can view more debug information by following these instructions.

Thanks for the response!
I'm pretty unfamiliar with Linux, and I don't see any files named .env in
my bookstack directory:
[image: Inline image 3]
I don't really know how to search from the command line yet, so could you
help point me to it?
Here are the errors I get running the command::
[image: Inline image 1]
[image: Inline image 2]
Here's the full output:
plynch@ubuntu:/var/www/bookstack$ sudo git pull origin release &&
composer install && php artisan migrate
[sudo] password for plynch:
remote: Counting objects: 1141, done.
remote: Total 1141 (delta 746), reused 746 (delta 746), pack-reused 395
Receiving objects: 100% (1141/1141), 486.42 KiB | 0 bytes/s, done.
Resolving deltas: 100% (856/856), completed with 241 local objects.
From https://github.com/ssddanbrown/BookStack

branch            release    -> FETCH_HEAD
e90da18..22df25a  release    -> origin/release
Updating e90da18..22df25a
Fast-forward
.env.example                                                      |    3 +
.gitignore                                                        |    7 +-
.travis.yml                                                       |    4 +-
app/Book.php                                                      |   29 +-
app/Console/Kernel.php                                            |   17 +-
app/Exceptions/Handler.php                                        |   14 +-
app/Http/Controllers/Auth/LoginController.php                     |   15 +-
app/Http/Controllers/Auth/RegisterController.php                  |   18 +-
app/Http/Controllers/BookController.php                           |   14 +-
app/Http/Controllers/HomeController.php                           |   10 +
app/Http/Controllers/ImageController.php                          |    4 +-
app/Http/Controllers/PageController.php                           |   17 +-
app/Http/Controllers/SearchController.php                         |    6 +-
app/Http/Controllers/TagController.php                            |    6 +-
app/Http/Controllers/UserController.php                           |   16 +-
app/Http/Kernel.php                                               |    4 +-
app/Http/Middleware/Authenticate.php                              |    7 +-
app/Http/Middleware/EncryptCookies.php                            |    4 +-
app/Http/Middleware/TrimStrings.php                               |    4 +-
app/Http/Middleware/TrustProxies.php                              |   47 ++
app/Http/Middleware/VerifyCsrfToken.php                           |    4 +-
app/Providers/EventServiceProvider.php                            |    1 +
app/Repos/EntityRepo.php                                          |   19 +-
app/Services/ExportService.php                                    |   23 +-
app/Services/PermissionService.php                                |    7 +-
app/Services/SearchService.php                                    |    2 +-
app/Services/SocialAuthService.php                                |    7 +-
artisan                                                           |   16 +-
bootstrap/{autoload.php => init.php}                              |   28 +-
composer.json                                                     |   43 +-
composer.lock                                                     |
2649 ++++++++++++++++++++++++++++++++++++----------------------
config/app.php                                                    |    4 +-
config/services.php                                               |    8 +
config/session.php                                                |    2 +-
database/migrations/2017_08_29_102650_add_cover_image_display.php |   32 +
database/seeds/DummyContentSeeder.php                             |   30 +-
package-lock.json                                                 |
5977 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
phpunit.xml                                                       |    2 +-
public/book_default_cover.png                                     |
Bin 0 -> 5672 bytes
public/css/export-styles.css                                      |    4 +-
public/css/styles.css                                             |    4 +-
public/index.php                                                  |   16 +-
public/js/common.js                                               |   55 +-
readme.md                                                         |   13 +-
resources/assets/icons/okta.svg                                   |    1 +
resources/assets/js/components/collapsible.js                     |   37 +
resources/assets/js/components/image-picker.js                    |   59 ++
resources/assets/js/components/index.js                           |    2 +
resources/assets/js/components/markdown-editor.js                 |    2 +
resources/assets/js/pages/page-form.js                            |   19 +
resources/assets/js/pages/page-show.js                            |   62 +-
resources/assets/js/vues/components/autosuggest.js                |    4 +-
resources/assets/js/vues/page-editor.js                           |    6 +-
resources/assets/js/vues/tag-manager.js                           |    4 +-
resources/assets/sass/_forms.scss                                 |   42 +-
resources/assets/sass/_grid.scss                                  |   11 +-
resources/assets/sass/_lists.scss                                 |   51 ++
resources/assets/sass/_tinymce.scss                               |    9 +-
resources/assets/sass/styles.scss                                 |    5 +-
resources/lang/check.php                                          |  114 +++
resources/lang/de/common.php                                      |    4 +-
resources/lang/de/settings.php                                    |    3 +
resources/lang/en/common.php                                      |    5 +-
resources/lang/en/errors.php                                      |    2 +
resources/lang/en/settings.php                                    |    3 +
resources/lang/es/common.php                                      |    4 +-
resources/lang/es/settings.php                                    |    3 +
resources/lang/fr/common.php                                      |    4 +-
resources/lang/fr/settings.php                                    |    4 +-
resources/lang/it/settings.php                                    |    3 +-
resources/lang/ja/common.php                                      |    2 +-
resources/lang/ja/settings.php                                    |    4 +-
resources/lang/nl/common.php                                      |    4 +-
resources/lang/nl/settings.php                                    |    3 +
resources/lang/pl/common.php                                      |    4 +-
resources/lang/pl/settings.php                                    |    2 +
resources/lang/pt_BR/activities.php                               |    4 +-
resources/lang/pt_BR/auth.php                                     |    2 +
resources/lang/pt_BR/common.php                                   |    9 +-
resources/lang/pt_BR/components.php                               |   10 +-
resources/lang/pt_BR/entities.php                                 |   51 +-
resources/lang/pt_BR/errors.php                                   |   15 +-
resources/lang/pt_BR/settings.php                                 |   11 +-
resources/lang/ru/settings.php                                    |    2 +
resources/lang/sk/common.php                                      |    4 +-
resources/lang/sk/settings.php                                    |    3 +
resources/views/books/create.blade.php                            |    5 +-
resources/views/books/edit.blade.php                              |    2 +-
resources/views/books/form.blade.php                              |   20 +
resources/views/books/grid-item.blade.php                         |   18 +
resources/views/books/index.blade.php                             |   29 +-
resources/views/books/show.blade.php                              |    2 +-
resources/views/chapters/show.blade.php                           |   28 +-
resources/views/components/image-picker.blade.php                 |   53 +-
resources/views/pages/form-toolbox.blade.php                      |    6 +-
resources/views/pages/form.blade.php                              |    9 +-
resources/views/pages/show.blade.php                              |   11 +-
resources/views/partials/activity-item.blade.php                  |    2 +-
resources/views/partials/book-tree.blade.php                      |    2 +-
resources/views/partials/custom-head-content.blade.php            |    5 +
resources/views/partials/custom-styles.blade.php                  |    1 +
resources/views/settings/index.blade.php                          |    5 +
resources/views/users/edit.blade.php                              |    9 +-
routes/web.php                                                    |    1 +
tests/Auth/AuthTest.php                                           |   39 +
tests/BrowserKitTest.php                                          |   19 +-
tests/Entity/CommentSettingTest.php                               |   28 +
tests/Entity/EntitySearchTest.php                                 |    4 +-
tests/Entity/EntityTest.php                                       |   22 +-
tests/HomepageTest.php                                            |   25 +-
tests/LanguageTest.php                                            |    2 +-
tests/Permissions/RestrictionsTest.php                            |   66 +-
tests/UserProfileTest.php                                         |   28 +-
version                                                           |    2 +-
114 files changed, 8864 insertions(+), 1364 deletions(-)
create mode 100644 app/Http/Middleware/TrustProxies.php
rename bootstrap/{autoload.php => init.php} (60%)
create mode 100644
database/migrations/2017_08_29_102650_add_cover_image_display.php
create mode 100644 package-lock.json
create mode 100644 public/book_default_cover.png
create mode 100644 resources/assets/icons/okta.svg
create mode 100644 resources/assets/js/components/collapsible.js
create mode 100644 resources/assets/js/components/image-picker.js
create mode 100755 resources/lang/check.php
create mode 100644 resources/views/books/grid-item.blade.php
create mode 100644 resources/views/partials/custom-head-content.blade.php
create mode 100644 tests/Entity/CommentSettingTest.php
Cannot create cache directory
/home/plynch/.composer/cache/repo/https---packagist.org/, or directory
is not writable. Proceeding without cache
Cannot create cache directory /home/plynch/.composer/cache/files/, or
directory is not writable. Proceeding without cache

php -r "!file_exists('bootstrap/cache/services.php') || @unlink('bootstrap/cache/services.php');"
php -r "!file_exists('bootstrap/cache/compiled.php') || @unlink('bootstrap/cache/compiled.php');"
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file

Removing symfony/yaml (v3.2.4)

[RuntimeException]
Could not delete /var/www/bookstack/vendor/symfony/yaml/Unescaper.php:
install [--prefer-source] [--prefer-dist] [--dry-run] [--dev]
[--no-dev] [--no-plugins] [--no-custom-installers] [--no-autoloader]
[--no-scripts] [--no-progress] [-v|vv|vvv|--verbose]
[-o|--optimize-autoloader] [-a|--classmap-authoritative]
[--ignore-platform-reqs] [--] []...
Laravel.log file contents:
#34 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53):
Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#35 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49):
Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#36 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148):
Illuminate\View\Middleware\ShareErrorsFromSession->handle(Object(Illuminate\Http\Request),
Object(Closure))
#37 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53):
Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#38 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(64):
Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#39 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148):
Illuminate\Session\Middleware\StartSession->handle(Object(Illuminate\Http\Request),
Object(Closure))
#40 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53):
Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#41 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/AddQueuedCookiesToResponse.php(37):
Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#42 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148):
Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse->handle(Object(Illuminate\Http\Request),
Object(Closure))
#43 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53):
Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#44 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(59):
Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#45 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148):
Illuminate\Cookie\Middleware\EncryptCookies->handle(Object(Illuminate\Http\Request),
Object(Closure))
#46 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53):
Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#47 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(102):
Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#48 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(561):
Illuminate\Pipeline\Pipeline->then(Object(Closure))
#49 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(520):
Illuminate\Routing\Router->runRouteWithinStack(Object(Illuminate\Routing\Route),
Object(Illuminate\Http\Request))
#50 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(498):
Illuminate\Routing\Router->dispatchToRoute(Object(Illuminate\Http\Request))
#51 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(174):
Illuminate\Routing\Router->dispatch(Object(Illuminate\Http\Request))
#52 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(30):
Illuminate\Foundation\Http\Kernel->Illuminate\Foundation\Http{closure}(Object(Illuminate\Http\Request))
#53 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(30):
Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#54 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148):
Illuminate\Foundation\Http\Middleware\TransformsRequest->handle(Object(Illuminate\Http\Request),
Object(Closure))
#55 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53):
Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#56 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php(27):
Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#57 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148):
Illuminate\Foundation\Http\Middleware\ValidatePostSize->handle(Object(Illuminate\Http\Request),
Object(Closure))
#58 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53):
Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#59 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/CheckForMaintenanceMode.php(46):
Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#60 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148):
Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode->handle(Object(Illuminate\Http\Request),
Object(Closure))
#61 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53):
Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#62 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(102):
Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#63 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(149):
Illuminate\Pipeline\Pipeline->then(Object(Closure))
#64 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(116):
Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter(Object(Illuminate\Http\Request))
#65 /var/www/bookstack/public/index.php(53):
Illuminate\Foundation\Http\Kernel->handle(Object(Illuminate\Http\Request))
#66 {main}
Next Illuminate\Database\QueryException: SQLSTATE[23000]: Integrity
constraint violation: 1048 Column 'name' cannot be null (SQL: insert
into page_revisions (page_id, slug, book_slug, created_by,
type, name, html, markdown, updated_at, created_at) values
(3, 14a01---all, accounts, 3, update_draft, , , , 2017-10-05 01:35:05,
2017-10-05 01:35:05)) in
/var/www/bookstack/vendor/laravel/framework/src/Illuminate/Database/Connection.php:647
Patrick Lynch
c:<PHONE_NUMBER> | v:<PHONE_NUMBER> | g: lynchpatrickj
On Sun, Dec 24, 2017 at 10:23 AM, Dan Brown<EMAIL_ADDRESS>wrote:

Hi @lynchpatrickj https://github.com/lynchpatrickj,
Sorry to hear you're having issues.
Did you see any error text or warnings during when running then update
commands?
To get more information about why your instance is not running correctly
you can view more debug information by following these instructions
https://www.bookstackapp.com/docs/admin/debugging/.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/BookStackApp/BookStack/issues/627#issuecomment-353789851,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJVoYTjcRNTkYzfqfB8fo8QssJvXdltBks5tDmx1gaJpZM4RKWgj
.

In the above it looks like the composer install step does not complete properly due to a permissions issue thus the migrate command never runs.
I'd try removing the whole /vendor file, Reinstall dependencies, Migrate then see if things work:
Commands should be ran from BookStack install folder, Run at your own risk.
# Delete old dependencies
sudo rm -rf ./vendor

# Re-install dependencies
composer install

# Migrate database
php artisan migrate

You probably can't see a .env file as files starting with a . in unix-like systems are hidden files/folders. From the command line, Running the command ls -al from the BookStack install folder should show it.

Try running the command as:
sudo git pull origin release && sudocomposer install && sudo php artisan migrate

Thank you for opening this issue. As part of an issue clean-up we're closing off older support issues that may be outdated or irrelevant so therefore I am closing this issue.
If the issue remains and it is one you are still seeking to actively solve please ensure it is still not apparent on the latest version of BookStack then open up a new issue referencing this one.
Sorry if we were not able to solve your original request.


Allow to install toml11 library with CMake.

This PR allows to install toml11 library with CMake.
E.g. if you do the following:
mkdir _build
cd _build
cmake ..
cmake --build .
cmake --build . --target=install

you can install the header files and by CMake generated config files into your system.
You can also use the project from CMake like this
find_package(toml11 REQUIRED)

add_executable(my_exe test.cpp)
target_link_libraries(my_exe PRIVATE toml11:toml11)

Also added option to not build test, to pass -Dtoml11_BUILD_TEST=OFF.

Thank you for PR!
Basically, it looks good to me. But I found one thing that might not be okay, so I added a comment.
Could you take a look when you have time?

Sure, but I cannot see any comments on the commit? Can you make it again please, or post it here?

I'm sorry I didn't realize it hasn't done yet. Can you see it now?


QPID-8352: [Broker-J] Official Docker image for Broker-J

This PR addresses JIRA QPID-8352, adding functionality for building broker-j container images

Considering we have never had a single image all this time, this feels over elaborate as a starting point.
Are there seriously going to be 192 image variants with the different os/jvm/protocol/store options as described? That seems excessive. Which ones would actually be getting pushed and why?
The 'protocol' images having amqp-all, amqp-0-8, amqp-0-10, amqp-1-0 means it doesnt even allow picking e.g just AMQP 0-9 or 0-9-1 (and doesnt make it obvious the 0-8 one would probably actually include them). The broker already allows selecting specific protocols through its configuration, so I dont see a good reason to complicate things by having 4 (or 6..so make that 288 variants?) different image variations for that. If someone wants a seriously customised image with different protocol deps in it then they can easily [/continue to] roll their own. For everything else they can just configure it.
I also see no good reason to have a postgres specific image (or derby, or memory store either). Are we going to add one for every DB someone likes and explode the matrix of image options even further? We dont even test with postgres at all so its unclear why would we ever have that as a default image option to begin with.
Having a single basic out-the-image setup that gets people started, like the regular broker distribution does itself, and then having ways for people to easily supply custom config (including users if appropriate, as opposed to the hard coded ones) to use instead to meet their specific needs, seem easier to justify and maintain later, while actually being more general for people to get whatever behaviour they want and without needing yet more image variants to be created later.
Even the 4 OS and 3 JVM options seems a bit much.
As comparison, some other Apache projects with brokers that also only started deploying images this year, currently have 1 or 2 images that they actually push, and perhaps a few for local dev that they dont. That seems like a more appropriate path to start with.

Hi Robbie,
Thank you for the feedback.
Would it be OK from your point of view to provide following options by default:
broker storage: memory / BDB
OS: alpine / centos7 / ubuntu
java version: 11 / 17
Possibility for further customization could then be available in a separate "dev" profile.
Best regards,
Daniil

I would personally pick a single setup to start with as I said. Probably something close to what users get with the regular assembly, i.e BDB. Allow its config to be changed out so that people can supply config to do whatever else it is they like, e.g if they want memory store, JDBC, protocol-specific setups, etc. I'd just pick 1 JVM. If people dont like whats picked, they can then roll their own.

Hi Robbie,
The module was reworked.
There are two maven profiles now - the default one and the development one. The default one allows creation of broker images using BDB as a message storage based on java 11 with the possibility of operational system choice:
qpid-broker-j-alpine
qpid-broker-j-centos7
qpid-broker-j-ubuntu
Development profile provides wider configuration options for users who may need them.
The README.md was updated with the examples of broker customization for preparing images having pre-declared queues, exchanges and other broker objects.
Best regards,
Daniil

This still seems way over complicated to be starting with. In some ways actually more than it was first time round now there are 2 different mechanisms to use, and yet still the 192 options.
Other broker projects here at the ASF, some that have done this very recently, ended up with 1 or 2 basic images being published, with configs that roughly match the existing release bundles. Built from the existing release bundle, using a basic script. For anything else configuration wise, users can then configure the broker. They are trivial by comparison, and look far easier to maintain later than this, and actually allow building from any release version as well which this approach by contrast doesnt look to.
E.g I simply do not see a need for us to have, and need to maintain later, 16 new assembly variants inside this module to select protocols or store types from. Which as before, the protocol options are actually not even clear which protocols will be getting enabled and so will actually mislead, and you cant even select any different options if you want a combo. Users that want to configure protocols and store types can and should just configure that using the far more flexible existing configuration mechanisms for that, or just make their own images as they must have been doing for a decade already. All we need to do is make it easy for people to supply their own desired configuration (which its not clear this really does yet).
If they want to customise the deps they based on their protocols and stores, can make their own images, as they  have had to for a decade already.
We can pick a JVM, we dont need to support them all. 17 or 21 at this point makes sense.
We dont need 4 OS options. Particularly when one is going EOL in a bit over 6 months. 1 would be fine, 2 at a stretch if you want to e.g do alpine.

Hi Robbie,
The qpid-docker module was reworked (similar module of ActiveMQ Artemis was taken as an example).
There is a shell script docker-build.sh provided, which prepares the folder containing files needed for docker images either from local distribution or from the Broker-J version specified.
The README.md was updated with the examples of broker customization for preparing images having pre-declared users, queues, exchanges and other broker objects.
Best regards,
Daniil

Hi Robbie,
Thank you for the review and for the remarks and comments. The docker file and scripts were modified, the README.md and the broker book were updated.
Best regards,
Daniil

Hi Robbie,
Thank you for the remarks, the scripts and the documentation were updated. We were thinking about starting with the ubuntu images - apache/qpid-broker-j:{version} and apache/qpid-broker-j:latest. Alpine based images could be added later if there will be a demand for it.
Best regards,
Daniil

Sounds good


facing problem to configure with route

hey can you share me an example by loading different routes on each step because i am facing a problem

I'll look at it soon, thanks.

Hi, can you provide some more details? this doesn't sound like an issue.


Use generic IM(invoke,read,write,subscribe) APIs in android chip-tool

Migrate light on/of, level cluster, sensor cluster, multiple admin cluster, operational credential cluster,basic cluster to use the generic IM API for cluster interaction.

The commit that fixed this was reverted due to CI failures: see https://github.com/project-chip/connectedhomeip/pull/26704


@NonNull creates dead code in Eclipse

Hello,
I have the following problem in Eclipse. When I unable the "Null analysis" using lombok annotations I get a warning about dead code when I use @NonNull to a method parameter.
The following code will have a warning where I use the @NonNull in the constructor:
import lombok.Getter;
import lombok.NonNull;

public class LombokExample
{
  @NonNull
  @Getter
  private String nonNullAttribute;

  public LombokExample(@NonNull String nonNullAttribute)
  {
    this.nonNullAttribute = nonNullAttribute;
  }
}

I used delombok to see the generated code and it looks like this:
  public LombokExample(@NonNull String nonNullAttribute)
  {
    if (nonNullAttribute == null)
      throw new NullPointerException("nonNullAttribute");
    this.nonNullAttribute = nonNullAttribute;
  }

I believe the @NonNull annotation should be removed in the generated code in order to avoid the dead code warning in Eclipse.

We leave the @NonNull on the parameter for documentation purposes. If you want to generate javadoc, you need that annotation there.

Hi Roel,
I do not understand your answer. If I set javadoc to the method, it will not remove the "dead code" warning.

What I meant is that in order to generate javadoc, you typically run delombok and then run the javadoc compiler on the delomboked code.
But it is actually unrelated to your Eclipse problem. Because of the different way we process the eclipse files, we were unable to remove the annotations.
Sorry if that interferes with your plan to use the lombok annotations in the Eclipse the null analysis.
Actually, I thing the Eclipse null analysis is in a way broken, since it doesn't allow for actually enforcing the nullness.
My problem with it is that I both want to document that you shouldn't pass null values and enforce that.
This is especially useful for maintainers of libraries, where you cannot depend on the users of you library also configured their null analysis correctly.
My suggestion is that you file a bug report on Eclipse that they should allow for code to verify the nullness.


Parse submission has extra fields

From https://reportedcab.slack.com/messages/C802R14UX/p1523482792000427:
report->>'objectId' as "objectId", -- automatically generated from parse right?
-- report->>'submission_date' as submission_date, -- readable timestamp - this isnt used on the submission but is used in iOS i think (maybe not)
-- report->>'colorTaxi' as "colorTaxi",  -i'm not automatically categorizing the vehicle based on patterns and other data!  woohoo! so this field is actually not used
report->>'passenger' as passenger, -- boolean, probably not necessary since we already have 'typeofuser' (which is passenger, pedestrian, cyclist)
report->>'typeofcomplaint' as typeofcomplaint,
report->>'medallionNo' as "medallionNo", -- probably should be simplified to 'license'
report->>'reportDescription' as "reportDescription", -- generally shouldnt be blank... but its ok
report->'photoData'->>'url' as photo_url_0, --keep using your photo objects whatever they're called
report->'photoData1'->>'url' as photo_url_1,
report->'photoData2'->>'url' as photo_url_2,
report->'videoData'->>'url' as video_url,
report->>'submission_timestamp' as submission_timestamp, -- timestamp UTC
report->>'loc1_address' as loc1_address, -- used in email template, see https://reportedcab.slack.com/messages/C9VNM3DL4/p1524530584000243
report->>'latitude' as "latitude",
report->>'longitude' as "longitude",
report->>'Username' as "Username", -- this should just be "email_id" or somethign simpler
report->>'FirstName' as "FirstName",
report->>'LastName' as "LastName",
report->>'Phone' as "Phone",
report->>'Borough' as "Borough",
report->>'Building' as "Building",
report->>'StreetName' as "StreetName",
report->>'Apt' as "Apt"

EDIT: Here's the relevant portion of the code at the time of writing (editing): https://github.com/josephfrazier/Reported-Web/blob/c1450b8421cae9ad33db2835232d1b0b39aafb11/src/server.js#L251-L309

Closing this to clean up the issues list, and since both colorTaxi and loc1_address turned out to be needed after all. We can always re-open if it actually becomes a problem.


listAccountSas is not recognized

The listAccountSas function is not recognized.  However, according to https://github.com/Microsoft/vscode-azurearmtools/blob/master/assets/ExpressionMetadata.json#L251, it would seem like it should be recognized.

Sorry, looks like we haven't released with that fix yet (https://github.com/Microsoft/vscode-azurearmtools/commit/672964f1d6b543cc1bef92d9394bd80d5ffabd21#diff-8483a224816d7c272b6910110c5cb189). I will be releasing it very soon, hopefully next week.


SNOW-1487379: Connection Add - PrivateKey support for KeyVaults - as alternate to files

Description
In an IAC world, it is likely that terraform, system users with public/private key credential are set up and the private key is placed in a named, say, an Azure KeyVault (as a secret), as AWS Secret Manager or similar.
On the assumption that one has access to the secret store, it would be good to be able to supply as pat of the connection add the name/type of the (supported) secret store, and secret name, and have the cli pull that secret systematically at runtime.
Context

It is not best security practice to keep the private keys as files on the file system.
It also does not allow a solution that easily scales across multiple developers. Once the key is in the key store, they can be accessed on demand.

Note: we need to use KeyVault Secrets as there is no way to retrieve the private key, from a Key Vault Key resource.  It is assumed the same issue exist with other Key Stores.

Related to #365


Testing time improvements: Alis/3049

DEVOPS PULL REQUEST
Related Issue

Resolves #3049

This is work to reduce the time it takes to run tests.

I took a quick look at testing times, and before this change, I saw time ranges between 17m 4s and 23m 4s. The test runs on this PR are as low as 11m 57s.

Additionally, now you can rerun just the failed test suite, which cuts down on wasted time from test flake, and sonar will still be able to build a full report due to the cache we make.

Changes Proposed

This breaks out backend, frontend, and function tests into different jobs and caches the output required for Sonar to report on the results.

Additional Information

I initially tried using artifacts (because that's what I'm more comfortable with), but the gains were minimal. It took too much time to upload and download the artifacts between jobs.

Testing

Double-check that the testing and coverage output from the jobs is sufficient for sonar to do proper sonar reporting.

Checklist for Primary Reviewer
Cache

[ ] Is the caching sufficient
[ ] Does the cache names make sense

Security

[ ] Changes with security implications have been approved by a security engineer (changes to  authentication, encryption, handling of PII, etc.)
[ ] Any dependencies introduced have been vetted and discussed

LGTM! thanks for the updates! All of the jobs look way faster! Except for the coverity-scan takes 18 minutes! I dont see this job on other PRs, is this a new addition?

@zdeveloper The coverity-scan job usually runs on a cron job but it ran against this PR because I updated the file.
  push:
    branches:
      - "**"
    paths:
      - .github/workflows/coverity_scan.yml


Code generator refactors

Moved MAC code into components and updated code with named text formatting
Moved MemoryInstruction and RegisterPool classes into separate files
Added new asm caps for F64 and VOP3 dot4
Removed some dead code and refactored some functions with duplicated code to combine them

Is this just for refactoring? Or, does this fix any issue?
Did you confirm generated code was same as before your change?

Is this just for refactoring? Or, does this fix any issue? Did you confirm generated code was same as before your change?

This is mostly refactoring. A minor functional change is that MAC code is now selected based on asm caps rather than architecture (with added caps for fma_f64 and VOP3 version of dot4), which could allow a code path to be used on additional architectures that support it.

Is this just for refactoring? Or, does this fix any issue? Did you confirm generated code was same as before your change?

This is mostly refactoring. A minor functional change is that MAC code is now selected based on asm caps rather than architecture (with added caps for fma_f64 and VOP3 version of dot4), which could allow a code path to be used on additional architectures that support it.

Thanks for your reply.
So far, I did not find any issue on your code change.
If you confirmed generated assembly code was same as before for these MAC scenarios, I am OK with this change.

I haven't done a diff on generated code yet, but I will try some. If there are any changes to assembly code, it should just be in formatting.

Generated asm code is functionally identical, some minor updates to whitespace and additional comments.
The CI error is due to a timeout, cannot reproduce any error locally. Looks like the last few builds on develop also timed out.


Unable to get tests to run properly

When I run make test-all I'm getting some errors:
$ make test-all
PLATFORM=iOS /Applications/Xcode.app/Contents/Developer/usr/bin/make test
git submodule sync --recursive || true
Synchronizing submodule url for 'Frameworks/AlamofireImage'
Synchronizing submodule url for 'Frameworks/AlamofireImage/Carthage/Checkouts/Alamofire'
Synchronizing submodule url for 'Frameworks/ios-ksapi'
Synchronizing submodule url for 'Frameworks/ios-ksapi/Frameworks/Argo'
Synchronizing submodule url for 'Frameworks/ios-ksapi/Frameworks/Curry'
Synchronizing submodule url for 'Frameworks/ios-ksapi/Frameworks/Prelude'
Synchronizing submodule url for 'Frameworks/ios-ksapi/Frameworks/ReactiveExtensions'
Synchronizing submodule url for 'Frameworks/ios-ksapi/Frameworks/native-secrets'
Synchronizing submodule url for 'Frameworks/ios-snapshot-test-case'
Synchronizing submodule url for 'Frameworks/onepassword-app-extension'
git submodule update --init --recursive || true
fatal: destination path '/Users/adam/Development/GitHub/kickstarter/ios-oss/Frameworks/ios-ksapi/Frameworks/native-secrets' already exists and is not an empty directory.
fatal: clone of 'https://github.com/kickstarter/native-secrets.git' into submodule path '/Users/adam/Development/GitHub/kickstarter/ios-oss/Frameworks/ios-ksapi/Frameworks/native-secrets' failed
Failed to clone 'Frameworks/native-secrets'. Retry scheduled
fatal: destination path '/Users/adam/Development/GitHub/kickstarter/ios-oss/Frameworks/ios-ksapi/Frameworks/native-secrets' already exists and is not an empty directory.
fatal: clone of 'https://github.com/kickstarter/native-secrets.git' into submodule path '/Users/adam/Development/GitHub/kickstarter/ios-oss/Frameworks/ios-ksapi/Frameworks/native-secrets' failed
Failed to clone 'Frameworks/native-secrets' a second time, aborting
Failed to recurse into submodule path 'Frameworks/ios-ksapi'
git submodule foreach git checkout
Entering 'Frameworks/AlamofireImage'
Entering 'Frameworks/ios-ksapi'
M	Frameworks/Argo
M	Frameworks/Curry
M	Frameworks/Prelude
M	Frameworks/ReactiveExtensions
Entering 'Frameworks/ios-snapshot-test-case'
Entering 'Frameworks/onepassword-app-extension'
cd Frameworks/ios-ksapi
git submodule foreach git checkout
Entering 'Frameworks/AlamofireImage'
Entering 'Frameworks/ios-ksapi'
M	Frameworks/Argo
M	Frameworks/Curry
M	Frameworks/Prelude
M	Frameworks/ReactiveExtensions
Entering 'Frameworks/ios-snapshot-test-case'
Entering 'Frameworks/onepassword-app-extension'
mkdir -p Frameworks/ios-ksapi/Frameworks/native-secrets/ios
cp -n Configs/Secrets.swift.example Frameworks/ios-ksapi/Frameworks/native-secrets/ios/Secrets.swift || true
xcodebuild test -scheme Kickstarter-Framework-iOS -destination 'platform=iOS Simulator,name=iPhone 6,OS=9.3'
xcodebuild: error: Failed to build project Kickstarter with scheme Kickstarter-Framework-iOS.
	Reason: Could not determine bundle identifier for Kickstarter-Framework-iOSTests's TEST_HOST: "/Users/adam/Library/Developer/Xcode/DerivedData/Kickstarter-acvdvuhlopkbghdsdczqpvttunki/Build/Intermediates/CodeCoverage/Products/Debug-iphonesimulator/KickDebug.app"
make[1]: *** [test] Error 70
make: *** [test-all] Error 2

It happened to me when I run test on xcode 8.1. The quickest way to fix it is to rename xcode 7.3.1 to xcode.app in applications and run tests again.

As @vladimir-evsei points out, this is probably an Xcode version issue. In the meantime, could you try running the tests directly in Xcode 7.3 and see things pass?
We typically only run the tests on the command line for CI, but you could use xcode-select to temporarily change which Xcode is used on the command line. We'll hopefully tackle the Xcode 8/Swift 3 migration soon, which should make this easier!

we just merged swift 3 support https://github.com/kickstarter/ios-oss/pull/26 and so now xcode 8.2 can be used.
closing this for now, let us know if you have any questions.

I am getting same error on xcode 8.3.2
Is it xcode issue?


Optuna depreciation warnings: suggest_loguniform

Optuna seems to have deprecated a couple of features in v3.0.0, which results in warnings like
.../cotengra/hyper_optuna.py:21: FutureWarning: suggest_loguniform has been deprecated in v3.0.0. This feature will be removed in v6.0.0. See https://github.com/optuna/optuna/releases/tag/v3.0.0. Use :func:`~optuna.trial.Trial.suggest_float` instead. caused by this:
https://github.com/jcmgray/cotengra/blob/718b0bd3a9c80bdac74ddeb922055c5bcf1a5b71/cotengra/hyper_optuna.py#L21

I am also getting the above warning accompanied another one for the deprecation of suggest_uniform :
cotengra/hyper_optuna.py:18: FutureWarning: suggest_uniform has been deprecated in v3.0.0. This feature will be removed in v6.0.0. See https://github.com/optuna/optuna/releases/tag/v3.0.0. Use :func:~optuna.trial.Trial.suggest_float instead.

Thanks for the issue, looks like it's simply a matter of changing suggest_float(log={False|True}) instead (which I presume has been available for a number of version). I should get to it soon, unless anyone wants to submit a PR first!

This should be fixed by https://github.com/jcmgray/cotengra/commit/2d8b6b406b34fe63c91362e46966dd589d9cddad.


Make requests to non-implemented endpoints

Hi, thank you for the work on this library.
How would one go about making calls to one of the endpoints that are not implemented. request and secType etc are all private so not sure if there is a "generic" way to call other APIs while still using the convenience of this library
Thanks in advance

implement in 1.0.3


0.4.0 release

Updating to the latest heapless release is a breaking change, it might be an occasion to add other breaking changes to a 0.4.0 release.

Remove the remove method: It is already implemented through Deref in heapless (though in a panicking way), and is unused as far as I know.
Remove the cbor feature. In can very easily be implemented outside of the crate and is unlikely to be used since the Bytes struct is meant to be used within a struct.
Remove the from function. It conflicts with the From trait.

Ideally I would even go to the point of removing the Deref trait impl and directly re-implementing all the heapless functions on top of it. This would make the documentation clearer. It would still be possible to implement From/Into a heapless Vec. This would make it possible to deref directly to a [u8].

I think this has been solved by https://github.com/trussed-dev/heapless-bytes/pull/8 and is included in v0.4.0


JSON split / optimization?

Is there a possibility to split JSON translation files to small files, for example by components?
I mean - to load only those translations that are required for particular page/component?
At the moment translations are loaded for entire website.

I'm looking for a similar way. Currently I've only found this: https://github.com/AlexDaSoul/ngx-i18n-combine

This would only take care of separation of concerns, but they would end up concatenated and loaded in their entirety when served.

@neverlose-lv and @axos88 , Please refer @rxweb/ngx-translate-extension package for extending the features of @ngx-translate/core. After extending the app you will resolve the JSON files component-wise as well as HTML section wise.


remove toolchain plugin

Do we still need this? We are now working from master. I have merged your legal-files addition. Are there any more changes we need added to master?


[Bug]: Streamlit error message 'setIn' cannot be called on an ElementNode when re-running application

Version (tag/commit sha)
0.2.0
OS
Linux
Profile

[ ] Expert
[ ] Tech-Savvy
[X] Developer

Problem description
Regression introduced in 0.2.0 (not happening in 0.1.0
Re-running an application (e.g. DeepLearning example) more than once triggers:

many Streamlit error message popups
duplicated log entries in the Streamlit logger

What happened ?

What should have happened
No error message nor duplicated log entries

Bug confirmed.
Introduced by commit: https://github.com/deeplime-io/onecode/commit/56f65b3fc53a37732c7a82533046e46bcd7c61cf

Error message popup seems to be related to the namespacing of the logger with a special character | in |OneCode|
The duplicated logs are still problematic though and seem to come from the _StreamlitLogHandler cumulating the emit() calls

After further investigations, the loggers seem to be accumulated by Logger.add_handler()
=> Logger.reset() only removes the namespace handlers, therefore the root handlers like _StreamlitLogHandler are not removed, then accumulated...

hotfix deployed in 0.2.1


luci-base: force menu to regenerate after uci change

Because the menu JSON can have 'depends' in them, uci changes should force the menu to regenerate.
See #6422
WARNING: I haven't tested this exact patch, since on 22.03.5 I had to modify the file glob in dispatcher.lua rather than in dispatcher.uc.

Please add your Signed-off-by: James Haggerty<EMAIL_ADDRESS>and rebase on master

ping @wryun

Sorry, I missed your ping @systemcrash . Sorry for causing a mess.
We've moved to OpenWrt 23 now, so I've raised a corrected PR: https://github.com/openwrt/luci/pull/7058