Two inverse selection on cartoon representation don't line up

What I'm trying to achieve is a coloured selection, where the rest of the protein is half-opaque. I believe you can not do this with only one representation - please correct me if I'm wrong. However, if I create two representations and selections like that, they won't line up properly - I've replicated the problem in the NGL viewer on the screenshot.
I there a way to align these representations properly?

Sorry @kiraacorsac, that is a shortcoming in NGL. We addressed it in our new project Mol* (molstar.org). There you can render individual residues as cartoon and multiple cartoon representations will always line up.

I'm having the same issue, just FYI. If there's a workaround or suggestion for where to look to start fixing it, I'd be willing to help.

@garyo In case you are not using different opacity for your representations, you can use a custom colour scheme. Otherwise, I think we'll need to switch to Mol*.


Some suggestions and a wrong line break (admin page)

Please see the attached screenshot

All the "should" are personal preferences. It will be customizable with a future Theming API.
The line break depends on the translation but anyway the search box should indeed be prettier and more consistent. This will happen when the whole interface is revamped.


Simplify importing 'test' module on XQuery

This pull request derives from #484. So needs to be handled after that.

In order to test src/compiler/generate-query-utils.xql, src/compiler/generate-query-tests.xsl has a special xsl:if. But it is not necessary. This pull request removes it.

@cirulls
Merged this internal small enhancement.


Improve Lightning package for external use

Context: To allow Lightning to be used in external projects, and support compilation through Spack, we require some adaptions to the external package management, and how certain files are supported in targets. This PR allows better support for Lightning as an external library, usable with and without Python, and enabling inclusion of dependencies when available.
Description of the Change: Update to CMake targets, build variant supports, and Kokkos package inclusion.
Benefits: Improves extensibility of Lightning, and allows support for Spack.
Possible Drawbacks:
Related GitHub Issues:

Hey @mlxd, nice work!


Cosmetic. Tab navigation warning state is missing

Issue: Design of the warning state for the My COVID Alerts tab not implemented when the user receives an exposure alert.
Solution: Implement the red alert in the tab.
https://zpl.io/agA4rmA
@ahurworth

fixed, avail in next build

Tabs are not styled properly. @ckiss .

fixed, avail in next build.
Thanks @helloantoine for your input!

Hmmm. Now I see only the red caution triangle in iOS build 35, but as per the spec above looks like it should be the bell icon with the triangle almost as superscript. Leaving it to @helloantoine to confirm.

Hi Fahd.  I discussed this with Cristian and Alex as well. We're going with the single hazard sign. Simpler.


[BUG] Unknown aggregation type [multi_terms]

Describe the bug
I have some documentations  with source.ip and destinaiton.ip keyword fiedls in my_index. When I use multi_terms, server raises parsing_exception like Unknown aggregation type [multi_terms] did you mean [rare_terms]?.
To Reproduce
Steps to reproduce the behavior:
POST my_index/_doc
{"source.ip":"<IP_ADDRESS>","destination.ip":"<IP_ADDRESS>"}

GET my_index/_search
{
  "query":  {
    "match_all": {}
  },
  "size": 0,
  "aggs": {
    "my_terms": {
      "multi_terms": {
        "terms": [
          {
            "field": "source.ip"
          },
          {
            "field": "destination.ip"
          }
        ],
        "size": 10,
        "order": {
          "_count": "desc"
        },
        "min_doc_count": 1
      }
    }
  }
}
======================
{
  "error" : {
    "root_cause" : [
      {
        "type" : "parsing_exception",
        "reason" : "Unknown aggregation type [multi_terms] did you mean [rare_terms]?",
        "line" : 8,
        "col" : 22
      }
    ],
    "type" : "parsing_exception",
    "reason" : "Unknown aggregation type [multi_terms] did you mean [rare_terms]?",
    "line" : 8,
    "col" : 22,
    "caused_by" : {
      "type" : "named_object_not_found_exception",
      "reason" : "[8:22] unknown field [multi_terms]"
    }
  },
  "status" : 400
}

Expected behavior
Response 200.
Host/Environment (please complete the following information):

OpenSearch: 2.0.0

I found multi_terms aggregation in documentation 2.0.x, but in fact it is supported on 2.1.x.


some bugs fixed and make it more clean

Fix bug of parsing json by boost library.
Make repo more clean by adding some git configs
Copy original list0.json to another file

"update to bug-fixed commit of libscarphase	1c66b82"
This fix a bug on compiling libscarphase


WIP - Reland VelocityTracker update (#132291)

This updates the implementation to use the stopwatch from the Clock object and piping it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync.
There are some other test failures I need to check out, opening for now to verify if the flakes still reproduce.
Relands #132291
Fixes https://github.com/flutter/flutter/issues/97761
The change was reverted due to flakiness it introduced in tests that use fling gestures.

https://github.com/flutter/flutter/issues/135728

Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@yjbanov can you see if the flake still repros with this? I think this will do it. I still need to check a handful of other tests that are failing now separately, but I think they just need to be rewritten like the others I've done so far here from test --> testWidgets.

Yep! This seems to work well now. I see the same values reported by the stopwatch across test runs. The values are also consistent across web and non-web runs. Thanks for solving this!
Yeah, now that the stopwatch returns logically correct values, some tests may start failing, but likely those tests were "succeeding" under wrong assumptions.

Fabulous! I will update the rest of the tests then and get this back in! (FYI @chipweinberger 🎉 )

thanks for working on this @pinks 😃
The updated PR looks totally reasonable to me.

This is now ready for review. 👍

@yjbanov can you review this PR?

🎉🎉 Thanks again for your work on this everyone, especially @Piinks

Reverting because there is an issue with the tree. Will re-stage again.


[123] Deserialization inconsistency to .net fiddle when using literal strings

Fixes #123

Superseded by #130.


Add version parameter

This PR adds a version optional parameter, which defaults to latest, to allow users to pin a specific version of kube-linter to use (see #8 )

Ugh. I am really sorry. I used the wrong git command and accidentally clobbered your PR (and GitHub no longer lets me push to your branch since the PR is closed, so I can't fix it). I've recreated in #10


Fix link to first lab in 'Ready to begin? section

I fixed the link that was previously broken.

Thanks!


Creating two certificates after running

With the latest version, 64bit on windows server 2016 latest version fully updated. I requested a certificate.
I see two certificates in iis. The same timestamp and name. Is this normal?
So far I see it, one would be the right amount.
If so, let me know and I post all details how to reproduce. If this is by design, then please let me know why that is?
Thank you.

There are circumanstances in which this might happen, e.g. when using the Central Certificate Store with a SAN certificate or when running a script which creates a copy from the WebHosting store to the Personal store. Otherwise it's not really possible I think.

Is it something for you to clean it up and only have 1 certificate? As now I am having one certificate for personal store and one in webhosting store.
I am using  Windows Certificate Store and the Exchange script

It's not for me to clean up, it's for you to configure.
Exchange requires the certificate to be in the Personal store and by default the program uses the Webhosting store, so the script - as a courtesy - makes a copy if it detects these circumstances. But it's not going to delete it from the Webhosting store because it may be in use by another applications (which it will be: IIS uses it for OWA).
Fortunately IIS can also read from the Personal store. You can tell the program to put it there via the command line (--certificatestore My, which is also included in the documentation about using win-acme with Exchange) or by setting DefaultCertificateStore in the .json file.

Will do it with the command line. Thank you.
Then it would be good to write that if you have an exchange server and you want to configure, it’s better to use the command line, right?
As I dont see the advantage of using the interactive mode as it makes two certificates. (I know i can ignore it and delete one of the certs from iis/mmc certificate).

It's definately better. I'll make sure to clarify the docs a bit.

Documentation has been updated


Upgrade black to 22.3.0

Description

This PR resolves a CI failure we're observing on main due to some dependency incompatibilities with black: https://github.com/psf/black/issues/2964
As a result, some new black checks were also applied to several files :slightly_smiling_face:
Testing Instructions

Watch CI run successfully! You can also check this branch out and run just lint.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Should we also update the version in the requirements.txt file?

Great call!


fix: docker build on erlang 25

This PR attempts to solve the Docker build issue presenting on main by removing distillery.
Reason: https://github.com/bitwalker/distillery/issues/744
The approach taken here is similar to this commit:  https://github.com/mbta/concentrate/commit/a9b4d57189849b04f927e3248cc1fe83f5dea256
It also adds a Docker build job to the Elixir workflow that runs on PRs.

@bklebe This PR is to address the failure that occurred when https://github.com/mbta/commuter_rail_boarding/pull/215 was merged.
It may be worth a chat tomorrow to test this further locally, since it does rip out a part of the release process and I cannot test the image fully locally without some secrets.
I am also going to go through and make sure each repo has it's Docker image building correctly as well, though at least half of the repos seem to already have a Docker image build on commit test.

@nlwstein I would recommend a dev deploy to see if it boots at least.


Nested component class not registering hints on @RestController

The webflux-netty sample has this code:
@SpringBootApplication(proxyBeanMethods = false)
public class WebfluxApplication {

	public static void main(String[] args) {
		SpringApplication.run(WebfluxApplication.class, args);
	}

	@RestController
	class Foo {

		@GetMapping("/")
		public String greet() {
			return "hi!";
		}
	}

}

It's unusual to have a non-static nested class that works as a @Component, and I think it is working, but by accident. If you delete the Foobar class from this sample it fails at runtime:
Caused by: org.springframework.core.annotation.AnnotationConfigurationException: Attribute 'value' in annotation [org.springframework.web.bind.annotation.RestController] is declared as an @AliasFor nonexistent attribute 'value' in annotation [org.springframework.stereotype.Controller].

because the reflection and resource configurations are not added for @Controller. So even though there is a @RestController (in the nested class), it is not causing the Webflux annotation hints to be applied.

Tentatively scheduled for 0.8.1.

No new test added but tested webflux-netty chopped up as per the description.

@aclement I am sorry for commenting on closed ticket but I am using boot 2.4.0-m3 and spring graalvm 0.8.1 and I still get this issue.
ERROR o.s.boot.SpringApplication - Application run failed org.springframework.beans.factory.BeanDefinitionStoreException: Failed to parse configuration class []; nested exception is org.springframework.core.annotation.AnnotationConfigurationException: A ttribute 'value' in annotation [org.springframework.web.bind.annotation.RestController] is declared as an @AliasFor nonexistent attribute 'value' in annotation [org.springframework.stereotype.Controller].

The sample above is working though right? You might need to supply a few more details, and maybe report as a new issue.

@dsyer I created a new issue and attached all things i could think of in the zip. Please check out #329


Support BigQuery NUMERIC

This PR adds support for BigQuery NUMERIC. These values will be mapped to Ruby's BigDecimal class.

This feature is not yet widely available, so do not merge until it is.

This can be merged whenever it is ready now. The NUMERIC data type is in beta: https://cloud.google.com/bigquery/docs/release-notes#may_15_2018. Thanks!

The official API docs for NUMERIC type.

@blowmage I guess it might be a good idea to rebase this branch for the google-cloud-bigquery 1.4.0 release.

In the past, we have included official disclaimers on Beta / SLA exclusions. Should we be doing that here? One concern, however, is that we might not be told when to remove the statement.

This feature is a Beta release and is not subject to any SLA. Please see Launch stages for further information about a Beta release.

Some background on the SLA from /issuetracker.google.com:

In terms of the SLA, if you run queries in a project that is enrolled in
the alpha but you don't reference any NUMERIC columns or create NUMERIC
values, then the usual BigQuery SLA applies. The Google Cloud Alpha terms
apply for any queries involving NUMERIC, however.

We aren't doing this in clients for the other languages, but I'm not entirely clear on what the policy is or if one exists for documenting launch stages in the client APIs. My expectation would be that someone will consult the BigQuery documentation related to NUMERIC (or other features for that matter) and see the terms that apply.

@ElliottBrossard @blowmage In my opinion, we can leave out the SLA notice, since we have had issues in the past with such copied docs not being kept in sync (removed) with official docs.

I was looking around for some "Standard SQL" policy on rounding to fit scale, and I found this:

NOTE: If you exceed the number of digits expected to the left of the decimal point, an error is thrown. If you exceed the number of expected digits to the right of the decimal point, the extra digits are truncated.

I'm not sure how universal this truncation approach is, but it might be worth investigating.


stdout redirection fails

I have a simple program that writes to stdout using a uv_poll_t handle, then exits.
The program works well when I simply start it from a console; but it fails when I redirect the standard output to a file; it gets a SIGABRT signal.
Using strace, I see the following:
epoll_ctl(5, EPOLL_CTL_ADD, 1, {EPOLLOUT, {u32=1, u64=1}}) = -1 EPERM (Operation not permitted)

Full strace file attached.
test_log.strace.zip
I use libuv 1.8.0 (from Debian unstable).

https://github.com/libuv/libuv/pull/659 for a possible fix.

Well, #659 is a good step forward assuredly. If I understand the code (did not try yet), it propagates an error to the callback. That's great indeed and thank you; however to me it is "just" good behaviour to do that instead of crashing.
Now once I catch the error in my callback, how do I proceed? I really want to write to stdout using a libuv handle.
As I am new to this library, I may have missed something. Any pointer would be appreciated.
Anyway thanks for your work, it helps.

You would normally use uv_tty_init() instead of uv_poll_init() for stdio file descriptors.  That also unlocks functionality for switching to/from raw mode and getting the terminal size.

I tried to use tty. If I understand correctly, except of polling I need to use uv_write() because tty is a stream. Is that right?
Here is what I get when I redirect stdout:
test_log.exe: src/unix/stream.c:1340: uv_write2: Assertion `(stream->type == UV_TCP || stream->type == UV_NAMED_PIPE || stream->type == UV_TTY) && "uv_write (unix) does not yet support other types of streams"' failed.

What do I miss? I don't understand how it is supposed to work.
Thanks

You need to make sure that you hand it a file descriptor that is pollable (tty, pipe, socket.)
If you look at how node.js implements process.stdout and friends, it sniffs the file descriptor with uv_guess_handle() and then creates a handle of the appropriate type.
If the file descriptor refers to a file, it uses uv_fs_write() instead.

It works, thank you very much!


documentation about warnings attribute change

Description
Docs PR for https://github.com/arangodb/arangodb/pull/19932
Upstream PRs
https://github.com/arangodb/arangodb/pull/19932

3.10: not required
3.11: not required
3.12: https://github.com/arangodb/arangodb/pull/19932

Is this really about _api/query/parse, not _api/query? If yes, then we either need to document the endpoint in addition to the release note remark, or if it's supposed to be undocumented, then we can close this PR IMO.

It's about the existing, documented endpoint according to Jan.


Protect expired disputes from being closed

Completes prevent resolving dispute after 45 day timeout expires in #843

Coverage increased (+0.2%) to 31.375% when pulling 907f5a77fd45a44444df310750407c5b616894d7 on 843-dispute-is-expired into 51edb574abef5e3ac9a68f237dc2eeeb24002aaf on 843-dispute-notifications-2.


[MUIC-279] [MUIC-281] New message indicator

This pull request is about 90% identical to the previous one for this feature.
It had to be created again due to a mess in releases and rollback of the said pull request.
Some things have changed, though; it was previously only reviewed by Gerson, so a fresh look wouldn't hurt.

I've pushed a commit with most of the suggestions taken into consideration. Some of the conversations are still open with provided reasoning.


cherry-pick to release-2.0: reconcile klusterlet bootstrap secret

see https://github.com/open-cluster-management/backlog/issues/4914

/retest

/assign @qiujian16

/approve
/lgtm


Unable to find repository named ...

Issue Type: Bug
Not being able to open any public repo at github.com when .git extension at the end of URL.
👎  https://github.com/microsoft/vscode-remote-repositories-github.git
👍🏼: https://github.com/microsoft/vscode-remote-repositories-github
Extension version: 0.13.3
VS Code version: Code 1.59.0 (379476f0e13988d90fab105c5c19e7abc8b1dea8, 2021-08-04T23:14:40.191Z)
OS version: Darwin x64 20.5.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6567U CPU @ 3.30GHz (4 x 3300)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
4, 4, 7

Memory (System)
16.00GB (0.73GB free)

Process Argv
--crash-reporter-id a80e795f-f7bc-4354-b651-70c918cd6eff --crash-reporter-id a80e795f-f7bc-4354-b651-70c918cd6eff --crash-reporter-id a80e795f-f7bc-4354-b651-70c918cd6eff

Screen Reader
no

VM
0%

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspyt653:30270858
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
vscextlangct:30333562
binariesv615:30325510
pythonvssor306:30344512
bridge0708:30335490
vstre464cf:30350173
bridge0723cf:30350415

good issuce, thanks. I am also because this.
I hope the author solves it as soon as possible, otherwise many users may not use this plugin, thus lose users.

Also want to report this issue on Win 10, Extension version: v0.13.4...

This should be resolved in the latest extension version.

@eamodio I am on v0.18.0 and I am still having this issue...

@Ruminateer is this the dialog where you are entering the url that ends with .git, or is it a different place in the extension?

@joyceerhl I selected "GitHub Repositories: Open Remote Repository..." in the command palette, and it looks exactly like the screenshot you posted.

I got similiar issue today on win 10, v0.19.0


Cache metric names provided by KEDA Metrics Server

Signed-off-by: Zbynek Roubalik<EMAIL_ADDRESS>
Cache metrics provided by KEDA Metrics Server instead of requesting list of all ScaledObjects in the cluster, this should reduce the load on k8s server and Metrics Server should respond much faster.
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Changelog has been updated

Fixes #2156

/run-e2e

Should we add a note in the docs explaining this?
I mean, maybe in the KEDA metric server section where we explain how to query metric directly, we could write a short note. We are caching the metrics, IDK if in any case we could have any worng metric exposed there.

Should we add a note in the docs explaining this? I mean, maybe in the KEDA metric server section where we explain how to query metric directly, we could write a short note. We are caching the metrics, IDK if in any case we could have any worng metric exposed there.

This change is just introducing a caching of the metric names that are provided by KEDA Metrics Server, not the actual metrics (values). It is internal change, so I am not sure that it is worth documenting. But I am open to do that if we all agree.

I don't have a strong opinion about it, I was just sharing my thoughts

/run-e2e

/run-e2e

@ahmelsayed PTAL

@zroubalik LGTM. do you think it's worth wrapping the slice pointer and its lock into a separate struct? might make for easier-to-follow code later on, and reduce the likelihood of concurrency bugs down the line. I'd be happy to do that in a follow-up if you like.

@arschles I was thinking about similar approach, but not sure if it doesn't introduce additional complexity. But I am no strongly opposed to this.


Document and check for unsupported Ruby versions

I added code that will check for the current RUBY_VERSION at google-cloud-core load time, and print warnings if an old version is detected.
Also proposed some language in the README (just edited google-cloud-core's readme for now). If this looks good, I'll replicate it over the other readmes.

When do you want this warning to be released?

@dazuma Looking at the build output, it isn't obvious what library the warning is coming from. Should we make it more obvious that the warning is coming from "Google Cloud"?

@blowmage That's a good idea. I'll update the wording. And let's release a google-cloud-core update maybe late this week if that works for you.

@blowmage Also what do you think of providing an environment variable or something that users can set to suppress warnings like this (and maybe the config validation warnings)?

I think giving users a mechanism to suppress the warning is a good idea. I don't have a preference on the mechanism, but an environment variable seems like a logical choice.


1.7 crash

1.7 players are still being randomly disconnected for "proxy error", a few tickets were made about this issues, it's still the same.

I don't think the client was modded since my server is not but I'm not sure, maybe they had optifine, armor status HUD or stuff like that. My server is running paperspigot 1.7.10 protocolhack and players reported that they don't have the bug anymore if they play on 1.8.
Here are my plugins: https://timings.aikar.co/?url=21642111

I can't really remove that plugin, it's essential for my server.
The issue happens on bungee side, it's not the spigot server that disconnects them and I only have this issue with Travertine, when I use another fork of bungeecord (with less good performances thought) I don't have the problem.

Packets are disabled in my chatcontrol config:
Packets:
Enabled: false

ChatControl (my plugin) is working and has been tested on Spigot, Craftbukkit and PaperSpigot. I believe it's caused by some differences in code in your server.
Would it be possible to get some more information/debug on what's exactly causing the problem? E.g. bad json syntax, etc..
Thank you.


PC got Blue Screen of Death after installing SimpleAudioSample

I recently attempted to install the driver SimpleAudioSample.inf by devcon obtained from repository on windows 11.
After completion of the installation process, my system encountered a crash and leading to an automatic restart with Blue Screen of Death. I cannot figure it out the reason I am facing this as I am new to kernel mode driver development. I am attaching the picture of it for better understanding.
Please suggest me a way of avoiding this or the root cause of it for further analysis. Thanks.

I have figured it out. It's happening only for debug build version.
In debug version the driver will print all logs including error logs which will call INT3 (Interrupt 3 - trap to debugger).
This will create BSOD(Blue Screen of Death)
If you use the release build version then you may not face this problem.
Thanks

+1 Thanks for providing the solution to this. (Also a newbie learning this ^^)
Besides the fact that the debug version didn't work, I somehow destroyed my VM and couldn't install any drivers anymore. I also used "devcon remove" to remove all the device but this didn't help. God bless that I had a snapshot of my VM (Win 11 on Hyper-V). After reverting and starting over it all worked.


Realm write transaction should have optional diff of overwritten object

As a mobile app developer, it is a common practice to create an unmanaged object of a particular view and then once the user is done with the view - turn the unmanaged object into a managed realm object - and commit the transaction to Realm by overwriting the existing realm object in the realm.
For sync, this creates a plethora of unnecessary SET transactions for fields that have not changed and clogs up the operation log on the backend - leading to all sorts of unintended side affects (poor merging and seeks).
Instead an optional parameter should be allowed for the developer to diffOrUpdate which only updates the fields that have changed
See this ticket and real-world example:
https://realm.freshdesk.com/helpdesk/tickets/1741
Aha! Link: https://realmio.aha.io/features/ROS-119

@bmunkholm : Can you identify who from the core/object team can focus on this in the upcoming Sprint?

This topic has been raised before and typically implemented at the binding level, see this comment for why it hasn't been implemented at a lower level yet. I'm not against the change, but want to show there are reasons why we haven't done this yet.

@jedelbo ^

This topic has been raised before and typically implemented at the binding level, see this comment for why it hasn't been implemented at a lower level yet.

The goal is to implement it as an optional feature on the createOrUpdate method. In this way it is something done explicitly by the developer. If their intended merge behaviour depends on all changes being reported, they can choose to not use this feature.

At the binding level you should notice that Object::create() and unbox<class T>has been added 2 new parameters:

update_only_diff indicates if we should try to update only properties that are different from what is already in the database.
current_row tells which already existing row in the database we should associate this new object with. This parameter has only relevance if update_only_diff is true and is particularly needed in unbox<RowExpr> as it is called with the same parameters. You can check CppContext::unbox<RowExpr> for reference (https://github.com/realm/realm-object-store/blob/1f91c82eb34cf4eaa2900794a9268390876f19f1/src/impl/object_accessor_impl.hpp#L180)
@cmelchior you should be aware of the current_rowparameter.

Create issues in each repo of the remaining SDKs.

Issues for other SDK's has been created.

Closing as we only need to merge Cocoa now.


Add merge to fix upload download artifact v4

This is the last piece of #631
Did a bunch of name shortening too, so board names are readable.

@brentru This one can be reviewed and then merged into #631 at which point that should be good to go / merge too.

@tyeth  I'm not sure if you want this merged into main or #631, so I'm marking this as approved and leaving the merging up to you.


Fixed minimum version of meta to 1.7.0

Issue #13

Codecov Report

Merging #14 (6b2abd3) into main (1a2b07a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines          185       185
=========================================
  Hits           185       185

Flag
Coverage Δ

unittests
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a2b07a...6b2abd3. Read the comment docs.


[BUG]: DeepLinking in swagger-ui is broken

Describe the bug
deepLinking is not working in docs
To Reproduce
Steps to reproduce the behavior:
from fastapi import FastAPI
from pydantic import BaseModel
from starlette.responses import Response
from starlette.responses import HTMLResponse

app = FastAPI(
    docs_url='/',
    redoc_url=None,
    swagger_ui_oauth2_redirect_url=None,
    openapi_url='/openapi.json',
)

class M(BaseModel):
    h1: str
    h2: str
    h3: str
    h4: str
    h5: str
    h6: str
    h7: str
    h8: str

@app.get('/1', response_model=M)
async def i1():
    return Response()

@app.get('/2', response_model=M)
async def i2():
    return Response()

@app.get('/3', response_model=M)
async def i3():
    return Response()

@app.get('/4', response_model=M)
async def i4():
    return Response()

Expected behavior
deepLinking feature of swagger ui not working, some api should expand and browser should scoll to that section automaticly
Environment:

OS: Windows,
FastAPI Version 0.38.1
Python 3.7.4

Additional context
It can be fixed by
@app.get('/')
async def index():
    return HTMLResponse(
        '''
<!DOCTYPE html>

  <meta charset="utf-8">
  <title>Pol server - Swagger UI</title>
  <link rel="stylesheet" type="text/css"<EMAIL_ADDRESS>>
  <link rel="shortcut icon" href="https://bgm.tv/img/favicon.ico" type="image/x-icon" />

'''
    )

I'm not familiar with swagger ui so I copy this from another example page, and I can't figure it out what fastapi's configuration not working
    <! doctype html>

    <link type="text/css" rel="stylesheet"<EMAIL_ADDRESS>    <link rel="shortcut icon" href="https://fastapi.tiangolo.com/img/favicon.png">
    <title>Pol server - Swagger UI</title>

I find the solution.
-     <!doctype html>
+    <!DOCTYPE html>

I dont get what's wrong, I though deeplinking was the ability to expand and scroll, which seem to work fine with the example you provided
hitting for instance http://<IP_ADDRESS>:8000/#/default/i4_4_get goes and expands to it
see

Maybe it's a browser issue? Which browsers are you both using?

Chromium here

I'm using both CentBrowser(chrome 74) and Firefox 69.0 and both of them don't work.
You can check this html's validation by using https://validator.w3.org/nu/#textarea or by running new XMLSerializer().serializeToString(document.doctype); in your browser console.

whatever the browser it seems to me this is not a FastAPI issue but a swagger-ui one, you should report there
the generated html, in particular this part is what swagger requires to enable the functionality, and it looks correct on FastAPI at 1st sight
(https://github.com/swagger-api/swagger-ui/blob/master/docs/usage/deep-linking.md)

    const ui = SwaggerUIBundle({
        url: '/openapi.json',

        dom_id: '#swagger-ui',
        presets: [
        SwaggerUIBundle.presets.apis,
        SwaggerUIBundle.SwaggerUIStandalonePreset
        ],
        layout: "BaseLayout",
        deepLinking: true
    })

@euri10 You didn't get it.
The reason of this bug is a space before doctype tag(<! doctype html>,should be <!doctype html>), but not the js in html or swagger-ui config.

Thanks @Trim21 , I just merged your PR to set the doctype without the extra space.
I'm not sure how that can affect Swagger UI, but I think it's still better with the change. I hope that solves your issue.
Thanks @euri10 and @dmontagu for the discussion and help!


Improve setup

Improve the README and create helpful commands to properly setup the system.

@eskombro approves 😝


docs: Fix docgen

Fixes #N/A
Description
Fix failures in docgen due to not discovering stateSubsystem
How was this change tested?
make presubmit
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.514%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5016

Relevant Lines:
6079

💛  - Coveralls


solana:getEphemeralSigners feature

Problem
Ephemeral Signers (ES) is a pretty common pattern in the Solana apps ecosystem. ES are keys that are expected to sign the transaction and be discarded right after. An example of when they are needed is the SystemProgram.createAccount instruction. When creating a non-PDA account, this instruction requires the new account to be a signer to verify that whoever calls this instruction actually holds authority over this account.
Most of the time, app developers use Keypair.generate() to create Ephemeral Signers. Then they sign a transaction that requires an ES with the Keypair and throw it away immediately after. This pattern works pretty well when the signed transaction is immediately sent and executed. That said, it prevents a certain class of use-cases when the transaction is stored on chain and executed later when a certain condition is met, e.g. time lock is released, multisig approval threshold is reached, such as with some Smart Wallet implementations (Realms, Squads, Clockwork etc). In these cases, the Ephemeral Keypair will not be available to sign the "execute" transaction because it has already been "forgotten".
Proposed Solution
We suggest a new Wallet Standard feature -getEphemeralSigners(numberOfSigners: number): Promise<Array<Pubkey>> that would allow apps to request any number of ESs from the wallet. The wallet would return an array of public keys that the app developer can use in their transactions.
Implementation of this feature can vary depending on the type of the wallet being used. For instance, for a multisig wallet, an ES can be a PDA owned by the Multisig Program, enabling the Program to sign the transaction on behalf of that account. While for a regular wallet (Phantom, Glow, etc.), it can be a Keypair generated by the wallet itself and stored securely in the extension's background storage over the course of the browser session.
Regardless of the implementation, the app developer doesn't have to worry about how the ES was generated; they can assume that the public key will be a signer of the transaction when it comes to the execution time.
Benefits for Apps
By detecting and using this Wallet Standard feature, app developers can be sure that their app will work with all existing and future wallet implementations out of the box and no hacks are needed.
There’s also a security benefit of never exposing the Ephemeral Signer Keypair to your app code directly - it is kept in the wallet secured storage, so a malicious dependency can’t steal it and use in any sort of re-initialization attacks.
Benefits for Wallets
By exposing this functionality via the Wallet Standard interface, wallets reserve a place for themselves to innovate and add Smart Wallet features in the future without changing their public interface.
Usage
Detecting the feature and requesting an Ephemeral Signer can be as easy as this:
const ephemeralSignerPubkey = "standard" in adapter && "solana:getEphemeralSigners" in adapter.wallet.features && await adapter.wallet
    .features["solana:getEphemeralSigners"]
    .getEphemeralSigners(1)[0]

Here we check that our wallet adapter is a Wallet Standard implementation and if it exposes the solana:getEphemeralSigners feature. If so we request 1 Ephemeral Signer public key from the wallet, which now can be passed as an account into a transaction that needs an extra signer.
Proof of Concept
We (Squads) implemented a proof of concept for this feature as part of our multisig-powered Smart Wallet - Fuse. We tested the integration with Jupiter Limit Orders product and are currently in conversation with other app developers regarding the adoption. We also received some positive initial feedback from other ecosystem participants (Realms). We believe, standardizing this feature will significantly help with its adoption and enable proliferation of Smart Wallets ecosystem on Solana.
Next steps

[x] ~Create an sRFC for this feature proposal and refine the design if necessary~ sRFC

Must the keys be derived from the seed/mnemonic?

If must/can/should be, then what should the path look like?
If must not; how does a wallet know when to dispose of the ephemeral key?

Do dApps expect the ephemeral key to be accessible across devices?

Say I have two browser extensions on two desktop devices with the same seed, should both devices be aware that an ephemeral address has been granted?

Can ephemeral addresses be re-used multiple times?

Two devices with the same seed may accidentally hand out the same ephemeral key to two dApps because the fact that it's being used may not be synced between the two wallets.


GPL-2.0-only detected in GPL-2.0-or-later

Background
I am currently working on copyleft license compatibility rules. For this I created a test repository containing GPL-2.0-or-later and GPL-3.0 (later I added some CC licenses as well, but those are not relevant to the issue). Both license texts were copied from spdx.org.
Bug
When scanning said test repository, ORT detects both GPL-2.0-only and GPL-2.0-or-later, even though only GPL-2.0-or-later was added to the repo. This is due to the results of scancode:
- license: "GPL-2.0-only"
  location:
    path: "license-gpl-2.0-or-later.txt"
    start_line: 3
    end_line: 110
  score: 98.02
- license: "GPL-2.0-or-later"
  location:
    path: "license-gpl-2.0-or-later.txt"
    start_line: 110
    end_line: 114
  score: 100.0

As you can see scancode gives GPL-2.0-only a 98.02 score, even though it ignores the last 4 lines of the license text. And GPL-2.0-or-later only is detected in the last four lines.
I am not sure if this is caused by scancode direktly or by parameters set by ORT. Maybe you can help me clarify. And if only scancode is to blame, I will open an issue in their repo as well.

I can confirm that scancode 31.2.1 produces the same results.
I will now open an issue over there.

I will now open an issue over there.

Thanks. Please add the link to that issue back here for reference when closing this issue in exchange.


pip install . fails on dask-gateway-server

(dev) MROCKLIN-MLT:dask-gateway-server mrocklin$ pip install -e .
Obtaining file:///Users/mrocklin/workspace/dask-gateway/dask-gateway-server
Requirement already satisfied: cryptography in /Users/mrocklin/miniconda/envs/dev/lib/python3.7/site-packages (from dask-gateway-server==0.1.0+16.g210ce7b) (2.4.1)
Requirement already satisfied: tornado in /Users/mrocklin/miniconda/envs/dev/lib/python3.7/site-packages (from dask-gateway-server==0.1.0+16.g210ce7b) (6.0.2)
Requirement already satisfied: traitlets in /Users/mrocklin/miniconda/envs/dev/lib/python3.7/site-packages (from dask-gateway-server==0.1.0+16.g210ce7b) (4.3.2)
Requirement already satisfied: sqlalchemy in /Users/mrocklin/miniconda/envs/dev/lib/python3.7/site-packages (from dask-gateway-server==0.1.0+16.g210ce7b) (1.3.4)
Requirement already satisfied: six>=1.4.1 in /Users/mrocklin/miniconda/envs/dev/lib/python3.7/site-packages (from cryptography->dask-gateway-server==0.1.0+16.g210ce7b) (1.11.0)
Requirement already satisfied: idna>=2.1 in /Users/mrocklin/miniconda/envs/dev/lib/python3.7/site-packages (from cryptography->dask-gateway-server==0.1.0+16.g210ce7b) (2.7)
Requirement already satisfied: asn1crypto>=0.21.0 in /Users/mrocklin/miniconda/envs/dev/lib/python3.7/site-packages (from cryptography->dask-gateway-server==0.1.0+16.g210ce7b) (0.24.0)
Requirement already satisfied: cffi!=1.11.3,>=1.7 in /Users/mrocklin/miniconda/envs/dev/lib/python3.7/site-packages (from cryptography->dask-gateway-server==0.1.0+16.g210ce7b) (1.12.3)
Requirement already satisfied: decorator in /Users/mrocklin/miniconda/envs/dev/lib/python3.7/site-packages (from traitlets->dask-gateway-server==0.1.0+16.g210ce7b) (4.3.0)
Requirement already satisfied: ipython-genutils in /Users/mrocklin/miniconda/envs/dev/lib/python3.7/site-packages (from traitlets->dask-gateway-server==0.1.0+16.g210ce7b) (0.2.0)
Requirement already satisfied: pycparser in /Users/mrocklin/miniconda/envs/dev/lib/python3.7/site-packages (from cffi!=1.11.3,>=1.7->cryptography->dask-gateway-server==0.1.0+16.g210ce7b) (2.19)
Installing collected packages: dask-gateway-server
  Found existing installation: dask-gateway-server 0.1.0
    Uninstalling dask-gateway-server-0.1.0:
      Successfully uninstalled dask-gateway-server-0.1.0
  Running setup.py develop for dask-gateway-server
    Complete output from command /Users/mrocklin/miniconda/envs/dev/bin/python -c "import setuptools, tokenize;__file__='/Users/mrocklin/workspace/dask-gateway/dask-gateway-server/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" develop --no-deps:
    running develop
    running build_go
    error: [Errno 2] No such file or directory: 'go': 'go'

You need a go compiler to build, which wasn't found (that's what that error means). Should get a better error message after #52.


Work-around for Jackson on Java15+

What does this PR do?
Work-around for compatibility issue with Jackson JSON serialization on Java 15 and 16.
Also, rollback jackson version to 2.12.x branch to ensure Java7 compatibility (2.13.x is built with Java 8) (see doc)

:grey_exclamation: Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Reason: Aborted from #2

Start Time: 2021-07-29T08:55:44.784+0000

Duration: 19 min 52 sec

Commit: 5b70521066d186053839cf4182df05629da6b53f

Test stats :test_tube:

Test
Results

Failed
0

Passed
1242

Skipped
0

Total
1242

Trends :test_tube:

Log output
Expand to view the last 100 lines of log output

[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1183)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1011)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:857)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:957)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:289)
[2021-07-29T09:14:27.269Z] [ERROR] 	at org.apache.maven.cli.MavenCli.main(MavenCli.java:193)
[2021-07-29T09:14:27.269Z] [ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[2021-07-29T09:14:27.269Z] [ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[2021-07-29T09:14:27.269Z] [ERROR] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[2021-07-29T09:14:27.270Z] [ERROR] 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[2021-07-29T09:14:27.270Z] [ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
[2021-07-29T09:14:27.270Z] [ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
[2021-07-29T09:14:27.270Z] [ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
[2021-07-29T09:14:27.270Z] [ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
[2021-07-29T09:14:27.270Z] [ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[2021-07-29T09:14:27.270Z] [ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[2021-07-29T09:14:27.270Z] [ERROR] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[2021-07-29T09:14:27.270Z] [ERROR] 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[2021-07-29T09:14:27.270Z] [ERROR] 	at org.apache.maven.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.java:39)
[2021-07-29T09:14:27.270Z] [ERROR] 	at org.apache.maven.wrapper.WrapperExecutor.execute(WrapperExecutor.java:122)
[2021-07-29T09:14:27.270Z] [ERROR] 	at org.apache.maven.wrapper.MavenWrapperMain.main(MavenWrapperMain.java:55)
[2021-07-29T09:14:27.270Z] [ERROR] -> [Help 1]
[2021-07-29T09:14:27.270Z] [ERROR]
[2021-07-29T09:14:27.270Z] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[2021-07-29T09:14:27.270Z] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[2021-07-29T09:14:27.270Z] [ERROR]
[2021-07-29T09:14:27.270Z] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[2021-07-29T09:14:27.270Z] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[2021-07-29T09:14:27.270Z] [ERROR]
[2021-07-29T09:14:27.270Z] [ERROR] After correcting the problems, you can resume the build with the command
[2021-07-29T09:14:27.270Z] [ERROR]   mvn <args> -rf :apm-log4j2-plugin
[2021-07-29T09:14:27.276Z] script returned exit code 1
[2021-07-29T09:14:28.781Z] Post stage
[2021-07-29T09:14:28.817Z] Post stage
[2021-07-29T09:14:28.864Z] Recording test results
[2021-07-29T09:14:28.893Z] Recording test results
[2021-07-29T09:14:28.985Z] Post stage
[2021-07-29T09:14:29.020Z] Recording test results
[2021-07-29T09:14:29.914Z] [Checks API] No suitable checks publisher found.
[2021-07-29T09:14:30.017Z] [Checks API] No suitable checks publisher found.
[2021-07-29T09:14:30.063Z] [Checks API] No suitable checks publisher found.
[2021-07-29T09:14:30.204Z] [INFO] getVaultSecret: Getting secrets
[2021-07-29T09:14:30.252Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-07-29T09:14:30.255Z] [INFO] getVaultSecret: Getting secrets
[2021-07-29T09:14:30.270Z] [INFO] getVaultSecret: Getting secrets
[2021-07-29T09:14:30.316Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-07-29T09:14:30.344Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-07-29T09:14:31.704Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1940/src/github.com/elastic/apm-agent-java
[2021-07-29T09:14:31.801Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1940/src/github.com/elastic/apm-agent-java
[2021-07-29T09:14:31.818Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1940/src/github.com/elastic/apm-agent-java
[2021-07-29T09:14:31.856Z] [INFO] Codecov: Getting branch ref...
[2021-07-29T09:14:31.949Z] [INFO] Codecov: Getting branch ref...
[2021-07-29T09:14:31.962Z] [INFO] Codecov: Getting branch ref...
[2021-07-29T09:14:31.994Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-07-29T09:14:32.025Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-07-29T09:14:32.044Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-07-29T09:14:33.317Z] [INFO] Codecov: Sending data...
[2021-07-29T09:14:33.343Z] [INFO] Codecov: Sending data...
[2021-07-29T09:14:33.371Z] [INFO] Codecov: Sending data...
[2021-07-29T09:14:33.994Z] + echo curl -sSLo codecov.sh https://codecov.io/bash
[2021-07-29T09:14:33.995Z] curl -sSLo codecov.sh https://codecov.io/bash
[2021-07-29T09:14:34.085Z] + echo curl -sSLo codecov.sh https://codecov.io/bash
[2021-07-29T09:14:34.085Z] curl -sSLo codecov.sh https://codecov.io/bash
[2021-07-29T09:14:34.213Z] + echo curl -sSLo codecov.sh https://codecov.io/bash
[2021-07-29T09:14:34.213Z] curl -sSLo codecov.sh https://codecov.io/bash
[2021-07-29T09:14:34.372Z] + echo bash codecov.sh
[2021-07-29T09:14:34.373Z] bash codecov.sh
[2021-07-29T09:14:34.510Z] + echo bash codecov.sh
[2021-07-29T09:14:34.510Z] bash codecov.sh
[2021-07-29T09:14:34.672Z] + echo bash codecov.sh
[2021-07-29T09:14:34.672Z] bash codecov.sh
[2021-07-29T09:14:34.861Z] Terminated
[2021-07-29T09:14:34.851Z] Terminated
[2021-07-29T09:14:35.077Z] Failed in branch Unit Tests
[2021-07-29T09:14:35.087Z] Failed in branch Smoke Tests 01
[2021-07-29T09:14:35.232Z] Terminated
[2021-07-29T09:14:35.323Z] Failed in branch Smoke Tests 02
[2021-07-29T09:14:35.615Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2021-07-29T09:14:35.712Z] Stage "Stable" skipped due to earlier failure(s)
[2021-07-29T09:14:35.803Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2021-07-29T09:14:35.850Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2021-07-29T09:14:36.259Z] Running on Jenkins in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1940
[2021-07-29T09:14:36.360Z] [INFO] getVaultSecret: Getting secrets
[2021-07-29T09:14:36.427Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-07-29T09:14:37.403Z] + chmod 755 generate-build-data.sh
[2021-07-29T09:14:37.404Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1940/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1940/runs/1 ABORTED 1132343
[2021-07-29T09:14:37.404Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1940/runs/1/steps/?limit=10000 -o steps-info.json
[2021-07-29T09:14:37.654Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1940/runs/1/tests/?status=FAILED -o tests-errors.json
[2021-07-29T09:14:37.654Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1940/runs/1/log/ -o pipeline-log.txt

FYI I realized that changing jackson version is not as trivial as it sounds as we have it in many levels of maven dependencies.
For example, mixing spring-boot versions with the one we already have through core module tends to conflict and create weird classloading issues because jackson dependencies structure changed (thus inclusions/exclusions do not work as expected).
Thus we can consider this still WIP until proper review is required.

Update: should be ready to review/merge, even if the build still does not run without error on Jdk 14-16.


VS Code fails to

Hi,
First of all great thanks for a such cool resource.
I'm making my very first steps in ReasonML and OCaml and for me it seems very useful.
I'm stuck with VS Code setup problem. It does not provide autocomplete for JSX HTML tags. As for me the reason may be due to errors I provide in the screenshot below.

Seems it can't find Js.t.

Please add instruction how to manage this problem.

This template https://github.com/melange-re/melange-opam-template does not have such problem.
Autocomplete for HTML tags works as expected.

@mike-kasianov Does npm run build succeed? What is its output?

Probably not related, but this PR reverting back to OCaml 5.1.1. was just merged today. Maybe you can try pulling again and reinstalling the opam switch?

I have no problem with building so npm run build works good.
The only problem is VS code can't build things for it's internal usage. I guess the reason might be in VSCode OCaml Platform setup.
Just open src/counter/Index.re and try to jump to the ReactDOM.Client.render function

From what I understand, the goal is to navigate the opam installed packages the same way that the application sources are handled (cmd-click, see types, not see a bunch of "unbound module" errors...)
This is a larger problem than Melange, as it happens for any OCaml project, including those using "native OCaml", see https://github.com/ocamllabs/vscode-ocaml-platform/issues/624.

I don't think there's much we can do in the melange book, besides waiting for the issue to be fixed upstream or waiting until Dune integrates the package management handling.


rancher-cis-benchmark k8s 1.28 chart support (Infracloud)

This issue is to implement the chart changes & perform the required testing to support k8s 1.28. The generic process that's applicable for most charts is described here. Please adjust the steps to fit your respective chart wherever required. Perform the steps below:

[X] Once you pick up the issue for your chart, apply the label [zube]: Working to the issue
Note: If this is an upstream chart (ex: istio) and if the upstream chart doesn't support k8s 1.28 then this exercise is not applicable to you. Just add a comment that the upstream chart doesn't support k8s 1.28 and apply the label [zube]: Done. If this is not an upstream chart then proceed to the next step.
[X] Update kube-version annotation in Chart.yaml to catalog.cattle.io/kube-version: '>= 1.23.0-0' or catalog.cattle.io/kube-version: '>= 1.23.0-0 < 1.29.0-0'
[X] Follow the usual process to add a new chart version and file a PR to the rancher/charts:dev-v2.8 branch. Link the PR to the issue.
[ ] Perform the usual Developer testing and if everything looks good then merge the PR. After merging the PR,  apply the label [zube]: To Test. Tag the respective QA team members.
[ ] Perform below testing

[ ] Spin up Rancher 2.8 with k8s 1.27
[ ] Add a downstream cluster with k8s 1.28
[ ] Point the Rancher charts repository of the downstream cluster to dev-v2.8 branch
[ ] Install the dev version of the chart. Verify that the installation is successful
[ ] Perform chart functionality testing (any tests in QA test plans for the chart)
[ ] Uninstall the chart. Verify that the uninstallation is successful
[ ] Install the prod version of the chart. Verify that the installation is successful
[ ] Upgrade to the dev version of the chart. Verify that the upgrade is successful
[ ] Add a downstream cluster with k8s 1.27
[ ] Install the prod version of the chart
[ ] Upgrade the k8s version of the downstream cluster to 1.28. Verify the chart still works after the upgrade
[ ] Perform any additional testing specific to your chart if required

[ ] If the testing passes then apply the label [zube]: Done. If you are blocked with any steps, add a comment with details and apply the label [zube]: Blocked

Validated on rancher v2.8.3-rc3, using CIS chart 5.1.0-rc7
Fresh install - CIS v1.8-permissive profile scan:

RKE1 v1.28.7-rancher1-1 node driver and custom - passed
RKE2 v1.28.7+rke2r1 node driver and custom - observed below failures which are expected 42971

Fail
1.1.1	Ensure that the API server pod specification file permissions are set to 600 or more restrictive (Automated)
Fail
1.1.3	Ensure that the controller manager pod specification file permissions are set to 600 or more restrictive (Automated)
Fail
1.1.5	Ensure that the scheduler pod specification file permissions are set to 600 or more restrictive (Automated)
Fail
1.1.7	Ensure that the etcd pod specification file permissions are set to 600 or more restrictive (Automated)

K3s v1.28.7+k3s1 node driver and custom - passed

Upgrade checks :

Provisioned v1.27 RKE1, RKE2 and K3s node driver and custom cluster.
Installed 5.0.0 CIS chart.
Upgraded clusters to v1.28
Upgraded chart to 5.1.0-rc7
Ran permissive profile scan and it passed on all clusters except failures on RKE2 which is expected as mentioned in Fresh install.

Hardened RKE1, RKE2 and K3s - CIS v1.8 permissive as well as hardened profile:

RKE1 v1.28 - scan failed with below expected failure - 42971

Mixed
4.1.7	Ensure that the certificate authorities file permissions are set to 600 or more restrictive (Automated)

RKE2 v1.28 - passed.
K3s v.128 - passed.

Imported clusters:

Provisioned RKE1 v1.28.7-rancher1-1 cluster and ran permissive v1.8 profile scan - passed


changing the name of the secret location to the new folder

i think this was superceeded to im closing


include links path

Include items from Windows 10's  Quick Access list, for example, Downloads.

👍


EnterpriseDB support

Original author<EMAIL_ADDRESS>(October 12, 2012 07:44:28)
Hello,
Since in my company we are using EnterpriseDB (commercial version of PostgreSQL) I couldn't use flyway because I got errors at the point flyway-core is comparing to the RDBMS name receiving when opening a connection. I had to download the sources and for the moment and add an OR check to use PostgreSQLDbSupport also for EnterpriseDB. So I had deployed a custom flyway version in our repository in order to get pass this problem.
Since EnterpriseDB is replacing Oracle in many small companies maybe you should consider also support for EnterpriseDB. I would be glad to join your team and contribute any EnterpriseDB specific features.
Thank you,
Marios
Original issue: http://code.google.com/p/flyway/issues/detail?id=345

Hi there,
I am just encountering the same problem, that is we are using EnterpriseDB instead of Postgres. While the Postgres Driver does allow to connect and work with the database, there are still some minor differences ( e.g. like between Community mysql and Enterprise (Oracle) mysql ).
As far as flyway is concerned, the difference are probably irrelevant. Enterprisedb has some additional features ( e.g. Oracle Compatibility Mode ) and some add on tools. As far as database conversions over jdbc are in question there is almost no differences.
We currently have to stop using flyway or just put the patch in ourselves, as Marios mentioned in his post. It would be great if we could use flyway with enterprisedb, too. We are already using it with some mysql databases, and highly appreciate it.
Regards,
Bernado

One more thing: I know this is an old discussions, but since it is still open, and the change is actually relatively minor, I still think it would be worth considering. Probably more interesting would be that the project also includes enterprisedb in their testsuites.
Regards,
Bernado

Implemented by @rbellamy in #1286 . Thanks!


Add replicas for redis master.

This introduces a way to have more redis masters in a cluster. This also
opens the possibility to have a different setup then master slave.
Instead of deploying x helm deployments, one could deploy one with more
replicas.

What this PR does / why we need it:
As explained above, it allows one to set the number af replicas for the redis master if they just one more separate redis instances rather than making 3 redis releases.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

Using your branch, I've being testing you changes.

Install chart:

$ helm install stable/redis --name redis --set master.replicas=2
$ kubectl get pods -l app=redis,role=master -o json | jq -r '.items[].status.podIP'
<IP_ADDRESS>
<IP_ADDRESS>

Create a Redis Client port:

$ export REDIS_PASSWORD=$(kubectl get secret --namespace default redis -o jsonpath="{.data.redis-password}" | base64 --decode)
$ kubectl run --namespace default redis-client --rm --tty -i --restart='Never' \
    --env REDIS_PASSWORD=$REDIS_PASSWORD \
   --image docker.io/bitnami/redis:4.0.14 -- bash

Connect to both Redis pods and check REDIS INFO:

I have no name!@redis-client:/$ redis-cli -h <IP_ADDRESS> -a $REDIS_PASSWORD
...
Warning: Using a password with '-a' option on the command line interface may not be safe.
<IP_ADDRESS>:6379> INFO
# Replication
role:master
connected_slaves:1
slave0:ip=<IP_ADDRESS>,port=6379,state=online,offset=476,lag=0
master_replid:7c735c51ea6b5f6ad6d487bda7401fa62673e4d5
master_replid2:0000000000000000000000000000000000000000
master_repl_offset:476
second_repl_offset:-1
repl_backlog_active:1
repl_backlog_size:1048576
repl_backlog_first_byte_offset:1
repl_backlog_histlen:476
...
<IP_ADDRESS>:6379> exit
I have no name!@redis-client:/$ redis-cli -h <IP_ADDRESS> -a $REDIS_PASSWORD
Warning: Using a password with '-a' option on the command line interface may not be safe.
<IP_ADDRESS>:6379> INFO
...
# Replication
role:master
connected_slaves:0
master_replid:27447f740cde6f48070498c5360b2fd156ef2366
master_replid2:0000000000000000000000000000000000000000
master_repl_offset:0
second_repl_offset:-1
repl_backlog_active:0
repl_backlog_size:1048576
repl_backlog_first_byte_offset:0
repl_backlog_histlen:0
...
<IP_ADDRESS>:6379> exit

As you can see the master nodes are not talking to each other since and they're not creating any cluster. One says it has one replica while the other doesn't show any replicas.
That's why this configuration is not going to work. The master nodes haven't been configured to work as a cluster and they act as totally separate master nodes.

@juan131 this is the setup that i was trying to get indeed, i could either deploy x helm releases or just increase the replica count.
Maybe what we can do is add another flag to enable clustering for master-master or not.  Or any other suggestions?

I think you're looking for Redis HA (https://github.com/helm/charts/tree/master/stable/redis-ha). This is a different chart that uses a different topology for Redis.

@juan131 ah thanks. Then this PR can be closed. My apologies.


ndjson writer

Support writing output to native ndjson.

Hmm, seeing all the MarshalJSON methods makes me think all the scalar types should not be structs, e.g.,
type Int int64

instead of
type Int struct {
    Native int64
}

Then the default Marshal code would work without the marshaler (right?)
Maybe we could fix this in a subsequent PR.


Added German translations

Added German translations to the strings resources

😍  thank you! I need to do an audit of existing strings in code (I think there's a couple left) to extract resources for some remaining ones. Would you be interested in adding translations for those too when I do (would just CC you on the commit as an FYI)?

You're welcome! 😄
Of course, just open an Issue and tag me :)

Thanks, will do


add SAS's way to read csv file online

using filename url statement

@Jiangtang can you update according to comments

pls reopen if you'd like to update according to comments


Fixing libvirt permission denied issues

This PR is not required now and issue is fixed already with same changes merged based on latest code.


refactor: improve policy for exports field

Improves the policy checker and resolver that validates the exports field in package.json. Improvements include:

Verifies that all non-private packages have an exports field.
Exports field must have a types condition.
Exports field must have a require and import condition unless package is ESM or CJS-only.
Packages with exports should not have the module field set.
Verifies that the types and main fields match the corresponding exports fields. All mismatches are found but the resolver only updates the types field - main could be supported if needed.
Prefers the "simple" form of exports for ESM and CJS-only packages. That is, if the package is only a single format, the extra level of nesting under "default" is removed.
ESM-only packages should have type: module.
Any non-default exports (e.g. ./alpha, ./internal) are ignored and should be preserved by the resolver.

I pre-applied the changes from the new resolver to the client release group in #20523. The main problem was that the types fields didn't match.
I also manually updated some build-tools packages that are CJS-only to set type: commonjs.

Marking this as a draft since it may need to be configurable.


Re-enable the Python Cloud Debugger

Enable the cloud debugger in Python by default.

Looks like I'm running into cla problems. I'll start over.


The namespace AspNetCore does not exist in the namespace Microsoft

Not sure if this is a bug or an issue with my setup.
I'm running on Ubuntu, NeoVim, OmniSharp+Ale, with dotnet 5 installed via snap.
Opening the project I'm seeing many errors about types that are not found or do not exist, yet the project builds and runs from the cli.
Has anybody ran into this problem?

This is literally the empty web project dotnet new web
The contents of my csproj file are:
<Project Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup>
    <TargetFramework>net5.0</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="OrchardCore.Application.Cms.Targets" Version="1.0.0" />
  </ItemGroup>

</Project>

Check :messages and the OmniSharp-roslyn log for load errors: :OmniSharpOpenLog

The :OmniSharpOpenLog
NVIM v0.5.0

OmniSharp server started.
    Path: /home/ghorsey/.cache/omnisharp-vim/omnisharp-roslyn/run
    Target: /home/ghorsey/code/learning/OrchardCore-CustomTheme/OrchardCore-CustomTheme.sln
    PID: 91547

[info]: OmniSharp.Stdio.Host
        Starting OmniSharp on ubuntu 20.4 (x64)
[info]: OmniSharp.Services.DotNetCliService
        DotNetPath set to dotnet
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 1 MSBuild instance(s)
            1: StandAlone 17.0.0 - "/home/ghorsey/.cache/omnisharp-vim/omnisharp-roslyn/omnisharp/.msbuild/Current/Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        MSBUILD_EXE_PATH environment variable set to '/home/ghorsey/.cache/omnisharp-vim/omnisharp-roslyn/omnisharp/.msbuild/Current/Bin/MSBuild.exe'
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: StandAlone 17.0.0 - "/home/ghorsey/.cache/omnisharp-vim/omnisharp-roslyn/omnisharp/.msbuild/Current/Bin"
            CscToolExe = csc.exe
            MSBuildToolsPath = /home/ghorsey/.cache/omnisharp-vim/omnisharp-roslyn/omnisharp/.msbuild/Current/Bin
            CscToolPath = /home/ghorsey/.cache/omnisharp-vim/omnisharp-roslyn/omnisharp/.msbuild/Current/Bin/Roslyn
            BypassFrameworkInstallChecks = true
            MSBuildExtensionsPath = /home/ghorsey/.cache/omnisharp-vim/omnisharp-roslyn/omnisharp/.msbuild
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.Completion.CompletionOptionsProvider, Order: 0
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.ImplementTypeWorkspaceOptionsProvider, Order: 110
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.BlockStructureWorkspaceOptionsProvider, Order: 140
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in '/home/ghorsey/code/learning/OrchardCore-CustomTheme'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Could not find any Cake files
[info]: OmniSharp.MSBuild.ProjectSystem
        Detecting projects in '/home/ghorsey/code/learning/OrchardCore-CustomTheme/OrchardCore-CustomTheme.sln'.
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/home/ghorsey/code/learning/OrchardCore-CustomTheme/src/Learning.CustomTheme/Learning.CustomTheme.csproj'
[info]: OmniSharp.Script.ScriptProjectSystem
        Detecting CSX files in '/home/ghorsey/code/learning/OrchardCore-CustomTheme'.
[info]: OmniSharp.Script.ScriptProjectSystem
        Could not find any CSX files
[info]: OmniSharp.WorkspaceInitializer
        Configuration finished.
[info]: OmniSharp.Stdio.Host
        Omnisharp server running using Stdio at location '/home/ghorsey/code/learning/OrchardCore-CustomTheme' on host -1.
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /home/ghorsey/code/learning/OrchardCore-CustomTheme/src/Learning.CustomTheme/Learning.CustomTheme.csproj
[info]: OmniSharp.OmniSharpWorkspace
        Miscellaneous file: /home/ghorsey/code/learning/OrchardCore-CustomTheme/src/Learning.CustomTheme/Startup.cs added to workspace
Replaying requests for buffer 2
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/home/ghorsey/code/learning/OrchardCore-CustomTheme/src/Learning.CustomTheme/Learning.CustomTheme.csproj'.
All projects loaded
[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /home/ghorsey/code/learning/OrchardCore-CustomTheme/src/Learning.CustomTheme/Learning.CustomTheme.csproj
Workspace complete: 1 project(s)
Replaying on-load requests

:messages just says Loaded server for /home/ghorsey/code/learning/OrchardCore-CustomTheme/OrchardCore-CustomTheme.sln in 2.1s

Yeah, in Vim that "fail" would have been echoed to:messages, but I think neovim tends to eat startup messages.
So the server isn't loading your project properly. It might be a good idea to open an issue in OmniSharp-roslyn to diagnose the problem.

Cool. I'll open an issue over there.  Thanks for the help!

I don't know if it's helpful in this case, but you can start the server in debug mode and get more extensive logs by adding this to your init.vim:
let g:OmniSharp_loglevel = 'debug'

Just to add some additional information here.  I'm running Ubuntu and I installed dotnet via snap.
A fix for me for this was to install dotnet5 via apt as per these instructions: https://docs.microsoft.com/en-us/dotnet/core/install/linux-ubuntu#install-the-sdk

Great to hear, thanks for reporting back


Support Ability to Query Objects in Tooling API

Is your feature request related to a problem? Please describe.
Currently, the SOQL Builder allows one to only execute queries with Regular Salesforce Objects.
Developers often work with Tooling API Objects and tooling SOQL, Workbench and DevConsole provide this capability today.
Salesforce CLI provides a flag to accomplish this for sfdx force:data:soql:query command.
Describe the solution you'd like
It would be nice to have a checkbox in the UI that starts executing the Query using tooling API.
Describe alternatives you've considered
Alternative is to use sfdx force:data:soql:query -t to execute and run the SOQL
Additional context
Maybe a checkbox right next to the Run SOQL to indicate the SOQL is tooling SOQL

There is one already open for this so closing it!


Alacritty toml files

Alacritty now uses yml configuration files instead of yml.
For example, using the existing yml files I now get this warning:

I could attempt to make a PR that adds a new shipwright runner if you're interested in supporting this. If so, would you rather the new toml runner replace the existing yml runner or continue generating both yml and toml files?

I ended up creating an initial PR: #158.

Let's generate toml only moving forward.

I've updated the PR to only generate toml.


fix: all browsers should have their own output folder

When using the combineBrowserReports feature, all browsers reports outputs to the same folder (which is named after the first browser).
These changes fixes this problem by not overriding the configuration.
I'm open for suggestions to complete the tests. But since I don't know what are the restrictions set on the CI server, I can't add a launcher other than the PhantomJS already present.

Codecov Report

Merging #39 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   98.24%   98.23%   -0.02%
==========================================
  Files           2        2
  Lines         114      113       -1
==========================================
- Hits          112      111       -1
  Misses          2        2

Impacted Files
Coverage Δ

src/reporter.js
98.73% <100%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fccc472...0047a8e. Read the comment docs.


Errors in console when send Btc

https://aeternity-blockchain.atlassian.net/browse/SW-1356
Describe the bug
I was sending Btc  in the testnet between accounts in 1 wallet and got errors in console. However Btc was sent. Reproducible on the current dev branch.
Expected result
Steps to reproduce

Send Btc from 1 acc to 2 acc in the testnet
Check the console

Environment selector
Firefox
MacOS
Web wallet

@CedrikNikita Please take a look at this


Using bluetooth to connect to JkBMS draws over 20W

Describe the problem
Hi, I am using a Victron Cerbo GX to connect to a JKBMS via bluetooth. When doing this, I am seeing an over 20W draw extra. We are working with a tight power budget, and I feel like we shouldn't be seeing this much of a power draw. I see the driver polls every 1 second, which seems fast to me. Could we change this to decrease the power draw?
Driver version
1.3.20240705
Venus OS device type
Cerbo GX
Venus OS version
v3.34
BMS type
JKBMS / Heltec BMS
Cell count
4s
Battery count
1
Connection type
Bluetooth
Config file
; --------- BMS specific settings ---------

; -- Unique ID settings
; Some already assembled BMS have no unique ID and no possibility to set one. In this case
; you can use the USB port as the unique ID.
; It may be possible that VRM ID's and custom names are not saved/restored correctly in this case.
USE_PORT_AS_UNIQUE_ID = False

; -- LltJbd settings
; SoC low levels
; Note:
;     SOC_LOW_WARNING is also used to calculate the Time-To-Go even if you are not using a LltJbd BMS
SOC_LOW_WARNING = 20
SOC_LOW_ALARM   = 10

; -- Daly settings
; Battery capacity (amps), if the BMS does not support reading it
BATTERY_CAPACITY = 50
; Invert Battery Current. Default non-inverted. Set to -1 to invert
INVERT_CURRENT_MEASUREMENT = 1

; -- JKBMS settings
; Predefines cell count for Jkbms_can
; The cell count should be auto-detected by identifying the highest cell number,
; but this process may be sometimes slow what could cause that cells voltage is not not
; updated in VenusOS. Try this workaround if you experience problems with cell voltage.
JKBMS_CAN_CELL_COUNT = 1

; -- ESC GreenMeter and Lipro device settings
GREENMETER_ADDRESS  = 1
LIPRO_START_ADDRESS = 2
LIPRO_END_ADDRESS   = 4
LIPRO_CELL_COUNT    = 15

; -- HeltecModbus (Heltec SmartBMS/YYBMS) settings
; Set the Modbus addresses from the adapters
; Separate each address to check by a comma like: 1, 2, 3, ...
; factory default address will be 1
HELTEC_MODBUS_ADDR = 1

; -- Seplos V3 settings
; Use min/max cell voltage, CVL, CCL and DCL from the BMS
SEPLOS_USE_BMS_VALUES = False

; --------- Voltage drop ---------
; If you have a voltage drop between the BMS and the charger because of wire size or length
; then you can specify the voltage drop here. The driver will then add the voltage drop
; to the calculated CVL to compensate.
; Example:
;     cell count: 16
;     MAX_CELL_VOLTAGE = 3.45
;     max voltage calculated = 16 * 3.45 = 55.20
;     CVL is set to 55.20 V and the battery is now charged until the charger reaches 55.20 V.
;     The BMS now measures 55.05 V since there is a voltage drop of 0.15 V on the cable.
;     Since the dbus-serialbattery reads the voltage of 55.05 V from the BMS the max voltage
;     of 55.20 V is never reached and max voltage is kept forever.
;     By setting the VOLTAGE_DROP to 0.15 V the voltage on the charger is increased and the
;     target voltage on the BMS is reached.
VOLTAGE_DROP = 0.00

Relevant log output
024-08-14 19:08:28.996257500 INFO:SerialBattery:BAT: JKBMS 11.XW 4 cells (20240510)                                                       [0/1935]
2024-08-14 19:08:29.041518500 INFO:SerialBattery:publish config values = False
2024-08-14 19:08:29.042698500 INFO:SerialBattery:Battery Jkbms_Ble connected to dbus from ble_c84780097290
2024-08-14 19:08:29.043931500 INFO:SerialBattery:========== Settings ==========
2024-08-14 19:08:29.044986500 INFO:SerialBattery:> Connection voltage: 13.5 V | Current: 14.8 A | SoC: 85%
2024-08-14 19:08:29.045943500 INFO:SerialBattery:> Cell count: 4 | Cells populated: 8
2024-08-14 19:08:29.048666500 INFO:SerialBattery:> LINEAR LIMITATION ENABLE: True
2024-08-14 19:08:29.049840500 INFO:SerialBattery:> MIN CELL VOLTAGE: 2.900 V | MAX CELL VOLTAGE: 3.450 V| FLOAT CELL VOLTAGE: 3.375 V
2024-08-14 19:08:29.050844500 INFO:SerialBattery:> MAX BATTERY CHARGE CURRENT: 50.0 A | MAX BATTERY DISCHARGE CURRENT: 60.0 A
2024-08-14 19:08:29.051825500 INFO:SerialBattery:> MAX BATTERY CHARGE CURRENT: 25.0 A | MAX BATTERY DISCHARGE CURRENT: 200.0 A (read from BMS)
2024-08-14 19:08:29.052916500 INFO:SerialBattery:> CVCM:     True
2024-08-14 19:08:29.053922500 INFO:SerialBattery:> CCCM CV:  True  | DCCM CV:  True
2024-08-14 19:08:29.055058500 INFO:SerialBattery:> CCCM T:   True  | DCCM T:   True
2024-08-14 19:08:29.055996500 INFO:SerialBattery:> CCCM SOC: False | DCCM SOC: False
2024-08-14 19:08:29.056953500 INFO:SerialBattery:> CHARGE FET: True | DISCHARGE FET: True | BALANCE FET: True
2024-08-14 19:08:29.057899500 INFO:SerialBattery:Serial Number/Unique Identifier:<PHONE_NUMBER>
2024-08-14 19:09:32.168350500
2024-08-14 19:09:32.168359500 INFO:Bluetooth details
2024-08-14 19:09:32.201999500 Attempting to disconnect from C8:47:80:09:72:90
2024-08-14 19:09:32.202009500 Successful disconnected
2024-08-14 19:09:37.261777500 Device C8:47:80:09:72:90 (public)
2024-08-14 19:09:37.261786500   Alias: Packout 1
2024-08-14 19:09:37.261789500   Paired: no
2024-08-14 19:09:37.261790500   Trusted: no
2024-08-14 19:09:37.261792500   Blocked: no
2024-08-14 19:09:37.261793500   Connected: no
2024-08-14 19:09:37.261794500   LegacyPairing: no
2024-08-14 19:09:37.261796500   UUID: Device Information        (0000180a-0000-1000-8000-00805f9b34fb)
2024-08-14 19:09:37.261799500   RSSI: -48
2024-08-14 19:09:37.262219500
2024-08-14 19:09:39.542689500 INFO:SerialBattery:
2024-08-14 19:09:39.543425500 INFO:SerialBattery:Starting dbus-serialbattery
2024-08-14 19:09:39.547512500 INFO:SerialBattery:Venus OS v3.34
2024-08-14 19:09:39.548193500 INFO:SerialBattery:dbus-serialbattery v1.3.20240705
2024-08-14 19:09:56.041575500 INFO:SerialBattery:Init of Jkbms_Ble at C8:47:80:09:72:90
2024-08-14 19:09:56.042293500 INFO:SerialBattery:Test of Jkbms_Ble at C8:47:80:09:72:90
2024-08-14 19:10:02.554077500 INFO:SerialBattery:BAT: JKBMS 11.XW 4 cells (20240510)
2024-08-14 19:10:02.555392500 INFO:SerialBattery:Connection established to Jkbms_Ble
2024-08-14 19:10:05.933741500 INFO:SerialBattery:Found existing battery with DeviceInstance = 1
2024-08-14 19:10:06.206297500 INFO:SerialBattery:DeviceInstance = 1
2024-08-14 19:10:06.208285500 INFO:SerialBattery:PID file created successfully: /var/tmp/dbus-serialbattery_1.pid
2024-08-14 19:10:06.209068500 INFO:SerialBattery:Used DeviceInstances = ['1']
2024-08-14 19:10:06.210017500 INFO:SerialBattery:com.victronenergy.battery.ble_c84780097290
2024-08-14 19:10:06.210965500 INFO:SerialBattery:BAT: JKBMS 11.XW 4 cells (20240510)
2024-08-14 19:10:06.240908500 INFO:SerialBattery:publish config values = False
2024-08-14 19:10:06.241729500 INFO:SerialBattery:Battery Jkbms_Ble connected to dbus from ble_c84780097290
2024-08-14 19:10:06.242403500 INFO:SerialBattery:========== Settings ==========
2024-08-14 19:10:06.243148500 INFO:SerialBattery:> Connection voltage: 13.5 V | Current: 14.5 A | SoC: 85%
2024-08-14 19:10:06.243745500 INFO:SerialBattery:> Cell count: 4 | Cells populated: 8
2024-08-14 19:10:06.244317500 INFO:SerialBattery:> LINEAR LIMITATION ENABLE: True
2024-08-14 19:10:06.245124500 INFO:SerialBattery:> MIN CELL VOLTAGE: 2.900 V | MAX CELL VOLTAGE: 3.450 V| FLOAT CELL VOLTAGE: 3.375 V
2024-08-14 19:10:06.246903500 INFO:SerialBattery:> MAX BATTERY CHARGE CURRENT: 50.0 A | MAX BATTERY DISCHARGE CURRENT: 60.0 A
2024-08-14 19:10:06.247757500 INFO:SerialBattery:> MAX BATTERY CHARGE CURRENT: 25.0 A | MAX BATTERY DISCHARGE CURRENT: 200.0 A (read from BMS)
2024-08-14 19:10:06.248414500 INFO:SerialBattery:> CVCM:     True
2024-08-14 19:10:06.249082500 INFO:SerialBattery:> CCCM CV:  True  | DCCM CV:  True
2024-08-14 19:10:06.249722500 INFO:SerialBattery:> CCCM T:   True  | DCCM T:   True
2024-08-14 19:10:06.250314500 INFO:SerialBattery:> CCCM SOC: False | DCCM SOC: False
2024-08-14 19:10:06.250907500 INFO:SerialBattery:> CHARGE FET: True | DISCHARGE FET: True | BALANCE FET: True
2024-08-14 19:10:06.251495500 INFO:SerialBattery:Serial Number/Unique Identifier:<PHONE_NUMBER>

Any other information that may be helpful
No response

SOLVED: we were previously using a smart shunt as a battery monitor. When we hooked up the BMS to the Cerbo, it was showing the incorrect DC load. To fix this we changed the "smart shunt monitor mode" to "dc energy meter".

Thanks for sharing the result.


Offline Search Feature

Looks like having a offline search is great feature for sites built with baker.  Something like https://www.npmjs.com/package/lunr should be ideal for this.
Downstream bug: https://github.com/palewire/cummings.ee/issues/34

This might be something to implement outside the scope of this project.


Mobile-Version

Features Added

Set up linters Config
Added the navbar-menu
Added the main-section area

Alright, but I do not understand this part "Hamburger button", can you please elaborate.
Thanks.


docs: only display main status for Snyk badge

Motivation

the link went to main, but the query for the badge did not
this should only show main, and then for release branches show the release branch

this will need manual backporting as such (np, I can do that)

Modifications

add a branch query to the SVG

Verification

Copied from the Actions page's "Create status badge" button (under the 3 dots)
Can see the rendered manifest

this will need manual backporting as such (np, I can do that)

Backported with modifications to release-3.5 as 9f55687e38fc89176ad1ce99d43b70f8f47d584b.
I actually couldn't cherry-pick it into release-3.4 as it had a merge conflict because the docs are older. Might eventually be able to get the docs up-to-date if there aren't too many conflicts (I made some progress on that, but it's pretty far behind)


Add message validations

Motivation

Changes

Tests

#11  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lmuntaner and the rest of your teammates on  Graphite


The demo page is unavailable

The demo page of this repo is not available for access.
https://vcard-qr-code.herokuapp.com/

yeah i know, you can run it on local by following the instructions in readme.md , actually heroku closed his free subscription tier, that's why demo page is not available.
if you still want the demo page you can comment it down !
regards,
mr_internetix


Feature: exception sorting as makefile targets

What this PR does / why we need it?
This PR adds two Makefile targets, one for validating the exception files' sorting, and the other to sort them recursively.
I took the code added in #295 and converted it to targets, thus simplifying both the Github action and the developer's workflow.
PR Checklist

[ ] This PR adds K8s exceptions (false positives)
[x] This PR adds new code
[ ] This PR includes tests for new/existing code
[ ] This PR adds docs

GitHub Issue
[XX-XX]

Notes for your reviewers

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.92%. Comparing base (5b9c270) to head (f351428).
Report is 6 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   40.96%   40.92%   -0.05%
==========================================
  Files          58       58
  Lines        2910     2913       +3
==========================================
  Hits         1192     1192
- Misses       1530     1532       +2
- Partials      188      189       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


-- Detecting SSL backend...
-- SSL auto detect: Using OpenSSL.
-- Found CURL: /usr/lib64/libcurl.so (found version "7.66.0") found components: HTTP HTTPS SSL
-- Curl 7.66.0 found on this system.

It seems CPR tries to link against WinSSL libraries even though it detects OpenSSL and builds on Linux?? (OpenSUSE WSL2)

Hmmm...
That's an interesting one.
What happens, if you set the following CMake variable:
cmake .. -DCPR_FORCE_OPENSSL_BACKEND=ON

Hmmm...
That's an interesting one.
What happens, if you set the following CMake variable:
cmake .. -DCPR_FORCE_OPENSSL_BACKEND=ON

That fixes the issue...
-- Disabled SSL backend auto detect since either CPR_FORCE_OPENSSL_BACKEND, CPR_FORCE_DARWINSSL_BACKEND, or CPR_FORCE_WINSSL_BACKEND is enabled.
-- Using OpenSSL.

Could you please provide a small example project, so I can reproduce this error?

No response -> closing


Stan Functions Can't Be Overloaded

According to the manual functions should be overload-able,
functions {
  real foo(real x) {
    ...
  }
  real foo(real x1, real x2) {
    ...
  }
}

but the parser uses the same name when creating the underlying functor (functor_foo in this case), creating a conflict at compile time.
Either the functor name needs to be mangled with the signature or the parser needs to fail with an appropriate error message.

I'm going to close this since this issue is stagnant and the manual no longer says something incorrect about overloading being allowed.


Question regarding Quota

The whitepaper mentions

Native executor consumes quota as a realtime clock ticks

So that mean that quota is how long a Nervos smart contract can run [in terms of seconds] (unlike the EVM where the gas limit is how many computational steps it can take)?
What happens if the time differs between miners (for example, quota is reached for one miner, but not the other miner because he has more compute resources)?

Quota is an abstract metric of resources consumed in transaction processing, what it represents depends on the underlying executor. It's gas for evm contract, time for native contract.
As you pointed out, processing time can be differed on different nodes, which will cause consensus failure. In that case the system will lose liveness and requires some kind of intervention. Time difference won't cause correctness problem. We think it's acceptable in permissioned/consortium scenario, and leave it as an option to user.

So that mean that quota is how long a Nervos smart contract can run [in terms of seconds]

Didn't notice you mentioned Nervos. Just for clarification: Nervos CKB is NOT based on CITA, it's a new project. CITA/quota has nothing to do with CKB contracts.

@janx Thanks for the explanation. It seems that CITA is more analogous to HyperLedger than to Ethereum since it's meant to be used in a consortium based network.
Also thanks for clarifying my misunderstanding. Where can I find out more information regarding CKB contracts? Are they similar to contracts in CITA?

@miguelmota that's right, though CITA is more than Fabric: with the effort of Nervos AppChain (which is a layer 2 solution based on CITA), we want to make CITA work together with CKB.
regarding to CKB contract: check the cell model in CKB's whitepaper to grasp an idea. We're still working hard on more specific spec, will release more details soon. Thanks!

@janx looking forward to it!


Issue with k8s.io/docs/concepts/overview/working-with-objects/names/

"...certain resources have more specific restrictions. See the identifiers design doc for the precise syntax rules for names...."
The link to "identifiers design doc" doesn't exist.

@yoHasse Could please confirm the you are looking at the latest documentation in the webpage https://kubernetes.io/docs/concepts/overview/working-with-objects/names/?
From my end, in the mentioned page I can only see the link to the Identifiers and Names in Kubernetes design document in the What's Next Section and it points correctly to achieved design-proposal repo
/triage needs-information

I searched on google and I now noticed that it sent me to https://pwittrock.github.io/docs/concepts/overview/working-with-objects/names/
Closing this Thank you for the response information!


List job fails with runtime error

What happened?:

pachctl list-job

panic: runtime error: slice bounds out of range

goroutine 1 [running]:
github.com/pachyderm/pachyderm/src/server/pps/pretty.PrintJobInfo(0x279b180, 0xc0001495f0, 0xc0004eca80)
	/home/jdoliner/go/src/github.com/pachyderm/pachyderm/src/server/pps/pretty/pretty.go:55 +0x8cd
github.com/pachyderm/pachyderm/src/server/pps/cmds.Cmds.func4.2(0xc0004eca80, 0xc0004eca80, 0x0)
	/home/jdoliner/go/src/github.com/pachyderm/pachyderm/src/server/pps/cmds/cmds.go:158 +0x40
github.com/pachyderm/pachyderm/src/server/vendor/github.com/pachyderm/pachyderm/src/client.APIClient.ListJobF(0x6a598a0, 0xc00016c048, 0x6a599a0, 0xc00016c0c0, 0x6a59a68, 0xc00016c140, 0x6a59b00, 0xc00016c148, 0x6a59bc0, 0xc00016c158, ...)
	/home/jdoliner/go/src/github.com/pachyderm/pachyderm/src/server/vendor/github.com/pachyderm/pachyderm/src/client/pps.go:276 +0x19c
github.com/pachyderm/pachyderm/src/server/pps/cmds.Cmds.func4(0x381d5e8, 0x0, 0x0, 0x0, 0x0)
	/home/jdoliner/go/src/github.com/pachyderm/pachyderm/src/server/pps/cmds/cmds.go:157 +0x3ee
github.com/pachyderm/pachyderm/src/server/pkg/cmdutil.RunFixedArgs.func1(0xc00050ad80, 0x381d5e8, 0x0, 0x0)
	/home/jdoliner/go/src/github.com/pachyderm/pachyderm/src/server/pkg/cmdutil/cobra.go:20 +0x117
github.com/pachyderm/pachyderm/src/server/vendor/github.com/spf13/cobra.(*Command).execute(0xc00050ad80, 0x381d5e8, 0x0, 0x0, 0xc00050ad80, 0x381d5e8)
	/home/jdoliner/go/src/github.com/pachyderm/pachyderm/src/server/vendor/github.com/spf13/cobra/command.go:572 +0x24a
github.com/pachyderm/pachyderm/src/server/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc000470480, 0xc00017478f, 0x220dff0, 0xc00017508b)
	/home/jdoliner/go/src/github.com/pachyderm/pachyderm/src/server/vendor/github.com/spf13/cobra/command.go:658 +0x2cc
github.com/pachyderm/pachyderm/src/server/vendor/github.com/spf13/cobra.(*Command).Execute(0xc000470480, 0x0, 0x0)
	/home/jdoliner/go/src/github.com/pachyderm/pachyderm/src/server/vendor/github.com/spf13/cobra/command.go:617 +0x2b
main.main.func1(0x25696a0, 0xc00018e700)
	/home/jdoliner/go/src/github.com/pachyderm/pachyderm/src/server/cmd/pachctl/main.go:21 +0x4a
main.main()
	/home/jdoliner/go/src/github.com/pachyderm/pachyderm/src/server/cmd/pachctl/main.go:22 +0xc3

What you expected to happen?:
How to reproduce it (as minimally and precisely as possible)?:
pachyderm: 1.8.3
Anything else we need to know?:
Environment?:

Kubernetes version (use kubectl version):
Pachyderm CLI version (use pachctl version):
Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s):
OS (e.g. from /etc/os-release):
Others:

Hi @suneeta-mall, sorry this is affecting you. I think it's a dupe of #3452 which should be fixed as of 1.8.4. Lemme know if that fixes the issue, if not I'll take another look at this.

@jdelfino Nice! thanks for letting me know .. I will try .4 soon .. ta

1.8.4 worked . ta