App Attestation (v2) | design

Description of feature / user story
As an Issuer
I want to know if the wallet app being used is trusted
so that I can trust the wallet to hold a high assurance credential
As an verifier
I want to know if the wallet app being used is trusted
so that I can trust the credential being used
Note:
v1 is a PoC
Acceptance Criteria

~Attestation credential is generated on install but NOT shown in the credential list. User can't delete the credential~
~Attestation proof request is requested and responded to but is proof is NOT shown to the user. Proof request transaction happens in background~
Credential issuance flow doesn't break with addition of App attestation flow
Error message appears if proof request does not succeed
~UX does not impede on the user's happy path~

Wireframes or relevant image assets / links
Link to flow

Need to rethink app attestation flow to include business rules of a verifier. Verifiers may request for the most up to date credential. holder might have multiple credentials.

Also think about scenario in which the app is not updated.


Fix GPT-Neo release year

Source: https://github.com/EleutherAI/gpt-neo

It's updated please check and thanks for reviewing.

Waiting for more new architecture update collaboration.


Bug Report

I've encountered an bug.
Messsage: Cannot read property 'indexOf' of undefined
Stack: TypeError: Cannot read property 'indexOf' of undefined
    at display (chrome-extension://iofggienboopplgnobbjfafkcodclkpl/client.js:1236:23)
    at parse (chrome-extension://iofggienboopplgnobbjfafkcodclkpl/client.js:502:3)
    at chrome-extension://iofggienboopplgnobbjfafkcodclkpl/client.js:282:11
    at <anonymous>
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.96 Safari/537.36
Version: 2.24.1

Hi there! Sorry it's taken so long to get back to this.
I'm not really sure what the problem is.
Are you getting this error frequently or did it only happen once?
Thanks!

So far it's only happened once.

Okay. Eventually I'm going to refactor to code to make it easier to debug, but since this only happened once and I can't tell what could be causing the issue there isn't too much I can do.
I'll leave this issue open, and if you ever get the error again / can cause the error to occur again please post another comment.


"failed to initialize mpv GL context" since chromium 89 (electron 13.0.0 or nw 0.52.0)

There have some windows 11 computers cannot load mpv.js since chromium 89 (electron 13.0.0 or nw 0.52.0), the error message is :
[libmpv_render] glGetString(GL_VERSION) returned NULL.
[libmpv_render] OpenGL not initialized.
[cplayer] failed to initialize mpv GL context

I tried the newest mpv-1.dll library, and recompiled mpv.node, but I got the same error.
I also tried mpv-2.dll, and got the following error:
[12948:0712/085649.515:ERROR:ppapi_thread.cc(271)] Failed to load Pepper module from mpvjs.node (error: 126)

How did you get electron 13 to work? Electron 12+ for me just returns "Couldn't load plugin."

I get the same error @nonesand how did you passed "--use-gpu-in-tests"? Actually i cannot start it at all

@drakonkat app.commandLine.appendSwitch("use-gpu-in-tests");


Use SAP Cloud SDK in UI5 app controller Directly

Is your feature request related to a problem? Please describe.
In UI5 contoller , we can not import SAP cloud sdk (SDK),  so we can not use SDK in UI5 controller directly
Describe the solution you'd like
We can import  SDK  in UI5  controller and use them directly .
Describe alternatives you've considered
Currently No .
Additional context
No

Hey @I501000,
currently the modules that we produce do not support AMD, which is needed for UI5.
Are you trying to import an existing npm module or generating your own?
In both cases an initial workaround that would be worth trying would be the following:

Download the edmx specification file of your service.
Run the generator on that service (generate-odata-client -i <INPUTDIR> -o <OUTPUTDIR>
Go into  and run npm install.
Adjust the tsconfig.json file in the : Set moduleResolution to 'AMD'.

With this I think you should be able to import your sources in UI5, but I have never tried this. If you have time to try it maybe this workaround could solve this issue for you right away.

Hi, @marikaner ,
Thank you very much! I will try and If I run into some difficulties , I will  turn back .

Hi @I501000,
Thanks for trying it out.
Looking forward to hearing about your success. I created a backlog item to look into it from our side. Having your results we might faster establish and support compatibility between SDK and UI5.

Hey @I501000, out of curisotiy - did you have time to try my proposed workaround?

Hi, Marikaner,
When I change tsconfig.json  . The error message is
Argument for '--moduleResolution' option must be: 'node', 'classic'.

screenshot.docx
Hi @marikaner
The related error message screen is in the attachment .

Hey @I501000, sorry I made a mistake, I meant to set module to "AMD". Can you please try again and share your results? If this does not work, we will probably have to investigate a bit deeper.

@marikaner
The classes generated .But there is error in the generated classes . And I can not find the generated classes in controller .
Detailed information ,please refer to the attachment .
screenshot1.docx

Dear @I501000,
can you let me know why you would need the SAP Cloud SDK inside UI5? For OData V2 and V4 you have native support in SAPUI5. And for all other requests you can do simple AJAX calls.
Best Regards
Gregor

Dear Gregor,
JS sap cloud sdk is more convenient to use in controller than AJAX  if it is available in UI5 .
Best regards!
Jacky Liu

Dear Gregor,
JS sap cloud sdk is more convenient to use in controller than AJAX  if it is available in UI5 .
Best regards!
Jacky Liu

Hi, Dear All
Failed in the second step .  The followig is the detailed information .
PS C:\Users\s4extapp\myui5demo> generate-odata-client -i API_SALES_ORDER_SRV.edmx -o APISALESORDERSRV
[2022-03-16T23:09:12.300Z] INFO     (generator-cli): Parsing args...
[2022-03-16T23:09:12.316Z] WARN     (fs): File "C:\Users\s4extapp\myui5demo\API_SALES_ORDER_SRV.edmx\service-mapping.json" does not exist, return empty object.
[2022-03-16T23:09:12.323Z] ERROR    (generator-cli): ErrorWithCause: Generation of services failed.
at C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\generator-cli.js:22:18
TypeError: Cannot read property 'edmx:DataServices' of undefined
at getRoot (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\edmx-parser\edmx-file-reader.js:62:37)
at parseEdmxFile (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\edmx-parser\edmx-file-reader.js:55:18)
at readEdmxFile (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\edmx-parser\edmx-file-reader.js:47:12)
at ServiceGenerator.readEdmxAndSwaggerFile (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\service-generator.js:65:55)
at ServiceGenerator.generateService (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\service-generator.js:33:38)
at C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\service-generator.js:30:116
at Array.map ()
at ServiceGenerator.generateAllServices (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\service-generator.js:30:102)
at parseAllServices (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\service-generator.js:79:42)
at parseServices (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\generator.js:229:63)
PS C:\Users\s4extapp\myui5demo> generate-odata-client -i API_OUTBOUND_DELIVERY_SRV_0002.edmx -o APIOUTBOUNDDELIVERYSRV
[2022-03-16T23:10:45.209Z] INFO     (generator-cli): Parsing args...
[2022-03-16T23:10:45.230Z] WARN     (fs): File "C:\Users\s4extapp\myui5demo\API_OUTBOUND_DELIVERY_SRV_0002.edmx\service-mapping.json" does not exist, return empty object.
[2022-03-16T23:10:45.241Z] ERROR    (generator-cli): ErrorWithCause: Generation of services failed.
at C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\generator-cli.js:22:18
Caused by:
TypeError: Cannot read property 'edmx:DataServices' of undefined
at getRoot (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\edmx-parser\edmx-file-reader.js:62:37)
at parseEdmxFile (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\edmx-parser\edmx-file-reader.js:55:18)
at readEdmxFile (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\edmx-parser\edmx-file-reader.js:47:12)
at ServiceGenerator.readEdmxAndSwaggerFile (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\service-generator.js:65:55)
at ServiceGenerator.generateService (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\service-generator.js:33:38)
at C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\service-generator.js:30:116
at Array.map ()
at ServiceGenerator.generateAllServices (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\service-generator.js:30:102)
at parseAllServices (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\service-generator.js:79:42)
at parseServices (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\generator.js:229:63)
PS C:\Users\s4extapp\myui5demo> generate-odata-client -i API_SALES_ORDER_SRV.json -o APISALESORDERSRV
[2022-03-16T23:14:30.767Z] INFO     (generator-cli): Parsing args...
[2022-03-16T23:14:30.786Z] WARN     (fs): File "C:\Users\s4extapp\myui5demo\API_SALES_ORDER_SRV.json\service-mapping.json" does not exist, return empty object.
[2022-03-16T23:14:30.788Z] WARN     (generator): No service definition files found.
[2022-03-16T23:14:30.789Z] WARN     (generator): No services parsed.
[2022-03-16T23:14:30.793Z] ERROR    (generator-cli): ErrorWithCause: Generation of services failed.
at C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\generator-cli.js:22:18
at processTicksAndRejections (internal/process/task_queues.js:97:5)
Caused by:
Error: The project is undefined.
at generate (C:\Develop\nodejs\node_global\node_modules@sap-cloud-sdk\generator\dist\generator.js:40:15)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
PS C:\Users\s4extapp\myui5demo>

Hi, Dear All ,
The edmx file is downloaed from api hub .
Best regards!
Jacky Liu

Hi, Dear All,
I use openapi-generator -i CF_ADSRestAPI.json -o CFADSRestAPI which is the same situation  by use tsc method . Only one error , the generated js code need lib '@sap-cloud-sdk/openapi', then the question is can the lib  '@sap-cloud-sdk/openapi' be used in UI5 directly  ?
The following is the erro message .
PS C:\Userscustomdomainkey\s4extapp\myui5demo\CFADSRestAPI1\CF_ADSRestAPI> tsc
ads-get-requests-api.ts:6:39 - error TS2792: Cannot find module '@sap-cloud-sdk/openapi'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
6 import { OpenApiRequestBuilder } from '@sap-cloud-sdk/openapi';
~~~~~~~~~~~~~~~~~~~~~~~~
ads-get-requests-api.ts:7:118 - error TS2792: Cannot find module './schema'. Did you mean to set the 'moduleResolution' option
to 'node', or to add aliases to the 'paths' option?
7 import type { PDFInput, AttachmentsOutput, AttachmentsListOutput, FileOutput, SignaturesOutput, TemplateInput } from './schema';
~~~~~~~~~~
ads-render-request-api.ts:6:39 - error TS2792: Cannot find module '@sap-cloud-sdk/openapi'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
6 import { OpenApiRequestBuilder } from '@sap-cloud-sdk/openapi';
~~~~~~~~~~~~~~~~~~~~~~~~
ads-render-request-api.ts:7:46 - error TS2792: Cannot find module './schema'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
7 import type { RenderInput, FileOutput } from './schema';
~~~~~~~~~~
ads-set-requests-api.ts:6:39 - error TS2792: Cannot find module '@sap-cloud-sdk/openapi'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
6 import { OpenApiRequestBuilder } from '@sap-cloud-sdk/openapi';
~~~~~~~~~~~~~~~~~~~~~~~~
ads-set-requests-api.ts:7:66 - error TS2792: Cannot find module './schema'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
7 import type { AttachmentInput, FileOutput, SignatureInput } from './schema';
~~~~~~~~~~
index.ts:12:19 - error TS2792: Cannot find module './schema'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
12     export * from './schema';
~~~~~~~~~~
store-form-schema-api.ts:6:39 - error TS2792: Cannot find module '@sap-cloud-sdk/openapi'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
6 import { OpenApiRequestBuilder } from '@sap-cloud-sdk/openapi';
~~~~~~~~~~~~~~~~~~~~~~~~
store-form-schema-api.ts:7:98 - error TS2792: Cannot find module './schema'. Did you mean to set the 'moduleResolution' option
to 'node', or to add aliases to the 'paths' option?
7 import type { SchemaStoreInput, SchemaMetadata, SchemaStoreOutput, SchemaUpdateStoreInput } from './schema';
~~~~~~~~~~
store-form-templates-api.ts:6:39 - error TS2792: Cannot find module '@sap-cloud-sdk/openapi'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
6 import { OpenApiRequestBuilder } from '@sap-cloud-sdk/openapi';
~~~~~~~~~~~~~~~~~~~~~~~~
store-form-templates-api.ts:7:106 - error TS2792: Cannot find module './schema'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
7 import type { TemplateStoreOutput, TemplateStoreInput, TemplateMetadata, TemplateUpdateStoreInput } from './schema';
~~~~~~~~~~
store-forms-api.ts:6:39 - error TS2792: Cannot find module '@sap-cloud-sdk/openapi'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
6 import { OpenApiRequestBuilder } from '@sap-cloud-sdk/openapi';
~~~~~~~~~~~~~~~~~~~~~~~~
store-forms-api.ts:7:68 - error TS2792: Cannot find module './schema'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?
7 import type { FormStoreOutput, FormStoreInput, FormMetadata } from './schema';
~~~~~~~~~~

Hi, I have build the business partner api in to AMD . But still I don't think we can  use it in ui5 directly. The reason is we need to build other lib used in BP api also . The better way is to use the the method like Using NPM Packages in UI5 without Shims

Hey @horsemanjackyliu, sorry for missing your last comments. Did you try this approach with the SDK and did it work? The SDK is primarily meant for use in the backend, because in the frontend you don't have the same authentication challenges (e.g. there is no JWT). However, we are considering improving the support for frontend, where UI5 is a special case obviously.

Hi,  Marikaner,
Failed .  The reason is businessPartnerApi rely on @sap-cloud-sdk/odata-v2.js . data v2 is not compiled into AMD .
Another issue is after TSC compile, always start with define, then I need to change it to sap.ui.define .

Best regard!
Jacky Liu

Hi,  Marikaner,
Think a step forward , is it possible to issue cloud sdk into 2 versions ?  one version for ui5 , one version for backend development. The big thing we need to think is performance , to control the ui5's version's  lib size, which need to sent to frontend . Currently after TSC compiling, the libs have too many files .
Best Regards!
Jacky Liu

Hi, Marikaner,
Shared another information , I tried this method with third party lib CMISJS .  Also failed . The reason is the same . CMISJS rely on too many other libs , which are almost possible to be compiled into AMD all .
Best regards!
Jacky Liu

Hey @horsemanjackyliu,
have you tried to follow this approach?
With that you would not have to transpile on your own. This was anyways just a workaround, which obviously didn't work.

Hi, Marikaner,
If cloud sdk can be used in UI5 , it really simplify s4 or other sap systems' extension. I think the big thing we need to think about is performance , to control the sdk ui5's version's lib size, which need to sent to frontend . Currently after TSC compiling, the libs have too many files .
Best Regards!
Jacky Liu

Can you explain what you mean by too many files? Does the generated client have too many files in your opinion? Are you experiencing performance issues because of that?
Also, are you bundling your application? Would that solve your concerns?

I'll close this ticket, as we have no plans for supporting the UI5 use cases.


Automated cherry pick of #9872: fix(region): AWS buckets in us-east-1 have null location

Cherry pick of #9872 on release/3.5.
#9872: fix(region): AWS buckets in us-east-1 have null location

Codecov Report

Merging #9875 (f35ae7c) into release/3.5 (6a15e02) will increase coverage by 4.90%.
The diff coverage is 0.24%.

@@               Coverage Diff                @@
##           release/3.5    #9875       +/-   ##
================================================
+ Coverage         5.98%   10.88%    +4.90%
================================================
  Files              796      168      -628
  Lines           125693    17668   -108025
================================================
- Hits              7522     1924     -5598
+ Misses          117504    15577   -101927
+ Partials           667      167      -500

Flag
Coverage Δ

aFlag
10.88% <0.24%> (+4.90%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apis/input.go
0.00% <ø> (ø)

pkg/cloudcommon/db/quotas/errors.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/quotas/handler.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/quotas/register.go
11.11% <0.00%> (-2.41%)
:arrow_down:

pkg/cloudcommon/db/quotas/usageworker.go
0.00% <0.00%> (ø)

pkg/compute/guestdrivers/aliyun.go
2.72% <0.00%> (-0.98%)
:arrow_down:

pkg/compute/guestdrivers/aws.go
2.27% <0.00%> (-0.67%)
:arrow_down:

pkg/compute/guestdrivers/azure.go
2.54% <0.00%> (-0.69%)
:arrow_down:

pkg/compute/guestdrivers/baremetals.go
1.06% <0.00%> (-0.02%)
:arrow_down:

pkg/compute/guestdrivers/base.go
0.00% <0.00%> (ø)

... and 578 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11b419b...f35ae7c. Read the comment docs.

Codecov Report

Merging #9875 (f35ae7c) into release/3.5 (6a15e02) will increase coverage by 4.90%.
The diff coverage is 0.24%.

@@               Coverage Diff                @@
##           release/3.5    #9875       +/-   ##
================================================
+ Coverage         5.98%   10.88%    +4.90%
================================================
  Files              796      168      -628
  Lines           125693    17668   -108025
================================================
- Hits              7522     1924     -5598
+ Misses          117504    15577   -101927
+ Partials           667      167      -500

Flag
Coverage Δ

aFlag
10.88% <0.24%> (+4.90%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apis/input.go
0.00% <ø> (ø)

pkg/cloudcommon/db/quotas/errors.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/quotas/handler.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/quotas/register.go
11.11% <0.00%> (-2.41%)
:arrow_down:

pkg/cloudcommon/db/quotas/usageworker.go
0.00% <0.00%> (ø)

pkg/compute/guestdrivers/aliyun.go
2.72% <0.00%> (-0.98%)
:arrow_down:

pkg/compute/guestdrivers/aws.go
2.27% <0.00%> (-0.67%)
:arrow_down:

pkg/compute/guestdrivers/azure.go
2.54% <0.00%> (-0.69%)
:arrow_down:

pkg/compute/guestdrivers/baremetals.go
1.06% <0.00%> (-0.02%)
:arrow_down:

pkg/compute/guestdrivers/base.go
0.00% <0.00%> (ø)

... and 578 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11b419b...f35ae7c. Read the comment docs.


Add API token authentication to playwright

Description
This enables playwright to run against an API that requires an authentication token.
This is based on the branch stefankracht/dir-716-remove-revision-id-from-the-frontend because that already fixes some tests. So the PR is set up to merge into that branch.
What I did:

Add headers to all requests originating in playwright (mostly for creating and cleaning up test data).
Add a local storage context that will be applied to the front-end app when executed in playwright.
Updated the .env.example (variable to set for using token in e2e tests)
There is a comment in the new file e2e/setup/auth.ts explaining my approach to set up the browser context in playwright.

Notes:

All tests ran without errors against the version deployed on the dev-server (please confirm during review that this also works from another machine against the dev-server).
Locally, two individual tests failed (as reported in PR https://github.com/direktiv/direktiv-ui/pull/432), but there is no problem with the test setup (without authentication).
When no token is defined in env, the storage context is still used. But since the token field is empty in this case, no auth tokens are added to the actual requests. (If worked fine even before I added the guard, when it was "direktiv-token": "undefined". So the API probably just ignores the field if it is not needed).

This is so cool (also the faker part) thanks for taking care of this. All test pass now. I will merge right away!
*I just found a small typo in one of the comments


Add developer guidance document

DEVGUIDANCE.MD is a bit shouty and DOSy.  Any objection to "DeveloperGuidance.md" or something that's a bit easier on the eyes?


Clicking website URL from Github results in a 404

The README.md file for the nlp-with-transformers/website repo has a link to the book website:
Website for our O'Reilly book Natural Language Processing with Transformers.
Following this link results in a 404 on the O'Reilly site

Closed in #9


Should we include a way to deploy to IBM Cloud?

Given the simplicity of this web app and the fact it's embedded into the model it uses I'm not sure we should have a Deploy to IBM Cloud button for this code pattern.
If we really want to include documentation on deploying to IBM Cloud we could consider some of the following options:

Document how to deploy the model then use the embedded app. This could just be an copy-paste-update of the DEPLOY_MODEL.md doc in the Image Caption Generator Web App.

Try to create a Deploy to IBM Cloud button that just accomplishes option 1. This would be a total pain and IMHO a waste of time.

Put a reference to the model README for using IBM Cloud. This is also probably not the best since MAX still hasn't settled on how it wants to support IBM Cloud and thus the only documentation is how to deploy to Kube (which can work on a IBM Cloud Kube cluster).

Just leave it out. This is my favorite option and the current state of affairs, but is not the Code Pattern standard.

@stevemart @rhagarty feedback on this? This is my only "open question" for this new code pattern.

Based on aug 7th discussion I'll add a short section pointing out kube deployment steps in the model readme

Addressed by https://github.com/IBM/MAX-Object-Detector-Web-App/commit/41e7eb257f34d24757ed9f321cab3a45fc29824f


Signup Page broken (due to invalid asset URLs) if hosted on subdirectory

Issue Summary
The signup page does not work when running the blog under a subdirectory (in my case using Nginx to proxy) e.g. /blog (the rest of the admin does work i.e. /blog/ghost/)
The problem stems from the fact that all the asset URLs in the signup page are relative and assume the current URL path is the same as the normal admin page (i.e. /blog/ghost/ in my case) but the actual URL path is something like:

/blog/ghost/signup/MTUxOTc0NzY4NDQ3MXxqb2noZW0UbWFhc0Bwcm5taW5kdXN0cnkubmx8NytwMVhkMlVHWFBkSXRzL3EzWEFscTZQM1hPRGlfZu8xV2ZXTHp5L25UVT0/

this leads to asset URLs like so:

/blog/ghost/signup/<SIGNUP_HASH>/assets/img/touch-icon-iphone-d2790931c3477664981061ed9fa5242e.png

which Ghost responds to with a 301 redirect to:

/ghost/signup/<SIGNUP_HASH>/assets/img/touch-icon-iphone-d2790931c3477664981061ed9fa5242e.png

which give a 404; the correct asset URL in this case should be:

/blog/ghost/assets/img/touch-icon-iphone-d2790931c3477664981061ed9fa5242e.png

It should be noted that I am running behind am Nginx proxy. I tried to work around the problem with a rewrite directive, like so:
rewrite ^/blog/ghost/.*/assets/(.+)$ /blog/ghost/assets/$1  last;

which does cause the assets to load successfully but then I am shown the sign-in page rather than the sign-up page (this seems somewhat unrelated).
Steps to Reproduce

Install Ghost (tested with 1.21.2) and configure it to run on a subdir
Go through initial setup
Invite yourself as an additional user with a different email address
Click the signup link in the email invite
behold the empty page (and 404s in the developer console)

Technical details:

Ghost Version: 1.19.2 or 1.21.2
Node Version: 8.9.0 or 9.4.0
Browser/OS: Ubuntu 16
Database: SQLite

I read about the bug fix, which is why I tried upgrading from 1.19.2, but that was to no avail - also I am pretty sure my issue has nothing to do with HTTP -> HTTPS redirects (my instance is only accessible via HTTPS).
I would like to add that:

I am using running ghost as an npm module.
My node is installed with nvm.
I do not use any globally installed node modules (e.g. ghost-cli, knex-migrator), such requirements are made part of my projects package.json and run from ./node_modules/.bin/*

I'd hazard a guess that these are notable distinction.
My eventual 'solution' has been to ignore the broken sign-up functionality (everything else works) and just generate my users via a data import JSON file.
Using Slack
I don't want to use Slack for numerous reasons, I can understand that you would want to seperate support questions and "real issues" but forcing people to use a propriatary tool they don't have/want in order to engage with support creates an unnecessary barrier.
Slack is pretty much "real-time", making it practically speaking impossible to have an async conversation in the way that you can with things like stackoverflow, "github issues", "google groups" or a plain old mailing-list; Also given the transitory nature of Slack's conversations all the useful conversations/answers are not accessible by other people at a later date.
Does this Issue imply a more fundamental problem?:
This problem I described could be caused by my setup but, given the amount of time I spent reading docs, searching the web, reading open & closed issues, reading ghost source code and trying alternative setups/configuration values, that does imply that ghost is rather painful to setup and somewhat badly behaved with regard to forcing requirements upon the enviroment it runs in (e.g. directory/file paths, webserver config, app mounting, etc) - I say this because:

a well behaved express app should be capable of running without knowning anything about how it's proxied or where it is mounted (albeit, possibly, with the exception of generating absolute URI for use in email/feeds).

a well behaved node module should allow for programmatic configuration (as opposed to requiring that someone creates a config.production.js file in a directory-path dictated by the module)

a well behaved nodejs application works regardless of where/how node is installed (i.e. demanding that nvm be removed )

I guess I run into this because my use case is a bit of an edge case, namely using/running ghost as a npm module under a Nginx proxied sub-directory in the context of a custom automated deployment (my ghost startup script involves code that dynamically generates a config.production.js in the correct location, based on configuration settings that come from my project's own configuration "system")
Setup aside ...
Getting ghost configured/running has always been a PITA for me (I've been at this since roughly 0.7.x) BUT once Ghost is running is it absolutely lovely! both the front-end and admin are delightful to use, really nice software y'all built! 😃

@iamjochem We only support installing Ghost via the CLI.

I can just repeat myself, please use slack (even if you don't like it), otherwise we (or the community) can't help or offer support for you.

Please reopen, my blog is currently on 1.22.1 and when I send authors email to join they end up with a blank screen.

@darrenshrwd I'm unable to replicate at all, ghost has used #-based urls for it's admin since 1.0 so all asset requests are relative to the ghost/ URL (the original error report above) and the signup link in the e-mails will redirect to the correct URL.
I suggest you open a help topic on our forum so that you can get support to track down what's going wrong with your setup. If it's determined that there's a bug in Ghost then a new issue can be opened to track it 😄

Version: 2.22.2
Setup as: subfolder using reverse-proxy in the following way (Ruby on Rails):
    config.middleware.insert(0, Rack::ReverseProxy) do
      reverse_proxy_options preserve_host: true
      reverse_proxy /^\/blog(\/.*)$/, 'https://trippli-blog.herokuapp.com$1'
    end

Hosted at: Heroku.
Have the same problem when trying to visit an email confirmation link. All other features work fine.

Version: 2.22.2
Setup as: subfolder using reverse-proxy in the following way (Ruby on Rails):
    config.middleware.insert(0, Rack::ReverseProxy) do
      reverse_proxy_options preserve_host: true
      reverse_proxy /^\/blog(\/.*)$/, 'https://my-blog.herokuapp.com$1'
    end

Hosted at: Heroku.
Have the same problem when trying to visit an email confirmation link. All other features work fine.

Make sure you don't have admin config and path manually defined in your config.development.json or config.production.json.
That seems to be the case @darrenshrwd


FAB to Toolbar added. Testing Needed!

I've made an initial version of a FAB that turns into a bottom toolbar. Similar to the effect shown here fab-transition-toolbar. You can checkout the documentation for it under buttons, floating buttons on the master branch.
Here is the basic markup:

      menu

insert_chart

format_quote

publish

attach_file

You can also open and close programmatically:
 $('.fixed-action-btn.toolbar').openToolbar();
 $('.fixed-action-btn.toolbar').closeToolbar();

I would appreciate some feedback and testing on this new feature. Thanks everyone!

Hey =)
Hoooo Sh\t this is awesome =D
But i have no idea where i can use it on my project xD
As soon as i use it, i'll come back ;)

Gonna try and do a test with it now...

Hey, I'm tyring to use this. Does it still work??

It is only available on the master branch and is not in our official release. You can try using it and I would appreciate any feedback you have


Revert ISOTime usage to time.Time in SSHKey

Signed-off-by: Philip Marc Schwartz<EMAIL_ADDRESS>

@svanharmelen Here is the roll forward, reverting the ISOTime in the SSHKey struct.


Dropdown Reconstruction

Please makes sure these boxes are checked before submitting your PR, thank you!

[ ] Make sure you follow Element's Contributing Guide.
[ ] Rebase before creating a PR to keep commit history clear.
[ ] Add some descriptions and refer relative issues for you PR.

Now We can use anything as the dropdown trigger and we can style the dropdown-menu.

#181


cannot find nix.useSandbox

Issue description
The template text for a PR mentions: Tested using sandboxing (nix.useSandbox on NixOS, but I can't find that option, neither in the provided link nor in the online search.

You're right, it's nix.useChroot

Err, I should say, it used to be, useSandbox is what you're supposed to use now

I think the reason you can't find it, is that 7cf8daa2bbf7e9ac1b57305a22547271dca28a6e didn't make it to the release.

Ah, should have known...

I agree its a bit confusing, though, so perhaps it'd make sense to backport that change. Doesn't look like it could break anything ...

bump I stumbled over the exact same thing. If I get instructed to use something specific and the link pointing me to that does not work that is really not helpful.

Looks to me like https://github.com/NixOS/nixpkgs/commit/7cf8daa2bbf7e9ac1b57305a22547271dca28a6e could be safely backported, what do you think @vcunat?

@joachifm: I believe the problem is the other way around – the default nix on 16.03 still uses only the old chroot* naming.

We might "postpone" parts of the commit (partially revert it for now), as the old option naming is accepted by all nix versions, but would be a complication and it wouldn't avoid inconsistency at some point anyway.

Hrm, I see ... What about mentioning both in the template? Lacks polish but is simple and might be sufficient to hold us over until the next release.

Hm, I guess sticking with only useChroot in the template makes the most sense.

Right, done in 156105c48. I'm fairly certain noone will remember to revert in on the next release, but that doesn't seem a big deal anyway...


$ref no longer available, can't do onDisconnect calls anymore.

Version info

Angular: 4.4.6
Firebase: 4.6.0
AngularFire: 5.0.0-rc.3
Other (e.g. Ionic/Cordova, Node, browser, operating system):
How to reproduce these conditions
Prior to upgrading to v5, the following code worked.
let donuts = this.db.object(`DONUTS`);
donuts.$ref.onDisconnect().set(false);

Now it no longer works as I can't access the $ref property from the result of the call to this.db.object(). Any ideas on how I might regain onDisconnect functionality? I didn't see this change in the migration docs, so this caught me off guard.

you should search for transaction issue before open this, there is an answer here and I tried, it work:
let donuts = this.db.object(`DONUTS`)
donuts.snapshotChanges()
.subscribe( action => action.payload.ref.onDisconnect().set(false));

rtdb Lists document sample still used $ref

The above solution may work but it is unsatisfactory.   It should not be necessary to open a subscription in order to access the ref or the onDisconnect() method.  It would be preferable if both of these could be added to the ``AngularFireObjectandAngularFireList` classes.

I agree with @jaufgang. The ref should be exposed differently, and that the proposed "solution" is more of a workaround, than a solution. Having to snapshotChanges and then subscribe, so that I can simply get a pointer to the ref is a lot of hoops that were't necessary before. Since the API is being rev'd, this should be considered.

Hey @aaronfrost! The query/ref is available on the AngularFireObject service, it's just called query now.
let donuts = this.db.object(`DONUTS`);
// make sure to call .ref because you could be dealing with a query. Both Query and Reference have a .ref property to deal with this case.
donuts.query.ref.onDisconnect().set(false);

Thanks for flagging this, we'll update our migration guide to indicate this.

wow that good 👍

@aaronfrost what up man!
@davideast I don't see .query mentioned anywhere in the docs either.

Closing, outdated. Solution in 5.0, keep a reference to the ref around (and build it with the firebase js sdk methods + pass into AF2) if you need to access methods on it.


Provide a way of not closing brackets when an exception occurs during serialization.

Related to https://github.com/aspnet/Mvc/issues/5413
On investigating the above issue we found that not closing the json writer in case of exceptions would result in any rented buffers to be not returned to the array pool. And any workarounds on MVC side to fix this seems to be dealing with internal details of Json.NET which feels incorrect.
Proposal:
Could JsonSerializerSettings expose an option to either close(default)/not-close the brackets on exception? Based on the option, could  JsonSerializerInternalWriter poison the state of the writer it's using so that the writer knows not to close the brackets since an exception has occurred?
@Eilon

I don't want to add a setting to JsonSerializerSettings for something so niche but I could add a flag to JsonTextWriter.

That sounds good!

@JamesNK cool. Do you see this feature making its way in at any point in the near future? Anything we can do to help?

It isn't difficult, just a bool property to control what happens when JsonTextWriter is disposed/closed.
I don't know when the next release will be - the number of changes is turning out to be huge and there isn't a pressing need. I'll probably wait until after VS2017 is out and I can move over to the csproj.

Done - https://github.com/JamesNK/Newtonsoft.Json/commit/55afb9aa72a07494aa35015dd2a29f7e9643127f
FYI I might change the property name if I can think of something I like more

@JamesNK very cool, thanks!


Search in all Docsets without Language/Context filtered results

Hi,
Currently the Dash-plugin seems to be recommending the Python docset when invoked from PyCharm. For PyQt projects, this means whenever the user searches for a Qt term, she/he has to manually select the Qt-docset (or "None" for no scope constraints) in order to get to the Qt documentation.
Thus a way to disable or configure the context sensitive search would improve the usability in this scenario, maybe by allowing the user to select a profile for contexts.
Thank you,
Clemens

I'd like to second the request for a preference to set the context in which to search. This is, however, duplicating the search profiles feature of dash in which you can set which docsets are to be searched by default when Dash is invoked from PyCharm (using any method). Thus I would much prefer a plugin that didn't touch the filter and left that to my own Dash prefs.

I am guessing this is somewhat related: When installing and using this plugin in CLion it defaults to ObjectiveC scope (guessing it's because it's related to AppCode?) It should default to C++ in CLion or be configurable.

it is not related. i opened a new issue. thanks for reporting.

so far no other user has expressed the need to search for unfiltered results. the first version of the plugin did this. if there is need for that i will add it.

If you can, I highly recommend that you add it. Dash has grown a lot and it's impossible for plugins to support all the user-contributed docsets and so on. It would be great to give users an option of managing their own docsets using search profiles in Dash.

Any ETA? I've had a few users complain about issues caused by this (e.g. the plugin requesting the HTML docset only while it should have requested Ionic).

sadly i have very little time at the moment. i hope to have the next version ready in some month.
in the meanwhile configuring the ide as described here will search all docsets.

I got the workaround to work, thanks. But I'd also vote for a fix, as selecting e.g. "ng-submit" is a bit difficult compared to how I think this is supposed to work.

I second this even though it's ages old.

I believe my issue was related here:
https://github.com/gdelmas/IntelliJDashPlugin/issues/64

i am currently implementing this feature.

the feature is finally released


Login Fascebook Invalid Keys

Hew to fix it.?

Hi @robbyobett , you should setup facebook sign in. Please follow the 5 step of Setup steps in the Readme:

Enable facebook sign in method. Follow this documentation https://firebase.google.com/docs/auth/android/facebook-login.


Nudge LaunchAgent and Logger packages are not notarized

I'm able to install the main Nudge application pkg without issue, but the Nudge LaunchAgent package fails to install. macOS rejects the pkg file claiming Developer ID is Unnotarized. This can be seen by running spctl -a -vv -t install Nudge_LaunchAgent-1.0.0.pkg
source=Unnotarized Developer ID
origin=Developer ID Installer: Clever DevOps Co. (9GQZ7KUFR6)

By comparison, the main Nudge pkg passes spctl -a -vv -t install Nudge-<IP_ADDRESS>92021162608.pkg
source=Notarized Developer ID
origin=Developer ID Installer: Clever DevOps Co. (9GQZ7KUFR6)```

I don't currently notarize the launchagent package as many people either do not use it or customize it.
I may do this in the future, but only if more people want it notarized. All deployment tools shouldn't have any issue deploying non-notarized packages.

I'm not particularly invested in the idea as I can repackage & notarize one for my own use. I just thought I'd point it out since it is signed.

Now that there is a nudge suite that is signed and notarized, this is not needed in my opinion.


Gamepad: Investigate replacing inputs

May fix #71.
Also likely to alleviate issues we’ve had with threads inside the inputs library getting stuck on quit, and other grievances with the inputs library being janky in general.

Endorsed SDL2 bindings are listed here: https://www.libsdl.org/languages.php
Also, I might consider just using the Python bindings to libudev and libevdev. SDL has the advantage of being very broadly cross-platform, and this approach would by contrast be effectively Linux-only. But I don’t know for sure how much of SDL’s functionality we’ll necessarily need. Might just be simpler to go low-level.
Then again, it might turn out that SDL offers better asynchronous operations and generally nicer abstractions to work with... will have to take a look to determine that.

I did some preliminary reading of the documentation for the python-evdev package and it looks like it could serve as a near drop-in replacement for inputs, but with a couple of key benefits:

Non-blocking read() using select()
Good documentation
Built-in support for asyncio
Repository is more active, possibly more widely used?
Code is broken up into reasonable-sized modules

The level of abstraction appears to be similar to what is provided by the inputs package.

Deferring this for now. inputs may not be perfect but it's good enough. If the shutdown issues continue to be a problem we can re-explore this. At least one instance of needing to do CTRL-C more than once was the gamepad.py main() method, and the problem in that case was that the program did not call the stop() method on the Gamepad object and thus the threads did not get notified to shut down properly. This has since been fixed.


Spring Cloud Binder Event Hubs Error Channel Implementation is missing

Spring Cloud Stream Binder create a dedicated error channel for each input binding to handle error message. Looks like this feature is not available in Event Hub Binder Implementation.
In case of any exception/error message will be lost, it should be passed to error handler and message should be moved configured topic/namespace.
https://docs.spring.io/spring-cloud-stream/docs/current/reference/htmlsingle/#binder-error-channels

Thanks for reporting this. I think these are 3 feature requests.

Support sending error into error channel.
Support auto retry from producer side.
Support auto retry from consumer side.

We'll evaluate these features.

Has this feature been added?

@benweizhu The error channel's been implemented, you could try it with our daily built snapshot.


Leaves out part of Joshua 24:15

I was testing out the api a bit, and I tried putting in Joshua 24:15, using the kjv translation: [url I put in](https://bible-api.com/Joshua 24:15?translation=kjv).  For some reason, it left out the "we will serve the LORD" part, which you can see here.  Is this just an issue with the open bibles repository, or is it something you can fix?

That's wild. I'll take a look!

OK, this is fixed! Turns out some longer verses were getting truncated. 😬 But we're all fixed now.

Ok, thanks!


Rendering error for BaseForm fields

Actual Behavior
Rendering a field in a BaseForm raise an AttributeError:
>>> f = wtforms.form.BaseForm({'foo': wtforms.StringField()})
>>> f["foo"]()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/eloi/dev/wtforms/wtforms/.tox/py39/lib/python3.9/site-packages/wtforms/fields/core.py", line 198, in __call__
    return self.meta.render_field(self, kwargs)
  File "/home/eloi/dev/wtforms/wtforms/.tox/py39/lib/python3.9/site-packages/wtforms/meta.py", line 64, in render_field
    return field.widget(field, **render_kw)
  File "/home/eloi/dev/wtforms/wtforms/.tox/py39/lib/python3.9/site-packages/wtforms/widgets/core.py", line 174, in __call__
    kwargs["value"] = field._value()
  File "/home/eloi/dev/wtforms/wtforms/.tox/py39/lib/python3.9/site-packages/wtforms/fields/core.py", line 660, in _value
    return str(self.data) if self.data is not None else ""
AttributeError: 'StringField' object has no attribute 'data'

Expected Behavior
>>> f = wtforms.form.BaseForm({'foo':wtforms.StringField()})
>>> f["foo"]()
Markup('<input id="foo" name="foo" type="text" value="">')

Environment

Python version: 3.9.0
wtforms version: 2.3.3 and master

In this snippet, the BaseForm.process method has not been called, and this explains the error. However there is no BaseForm.__call__ method, so that may be another issue.


Place ‘img’ node inside correct ‘figure’ parent node.

'img' node must be put inside 'figure' node so that 'stateFromElement' can work properly.

There's a few issues with this including tests not passing (undefined variable). I'll close this for now, but if you want to try again, rebase from master.


reset drawerIsReady promise when BaseDrawerNavigator unmounts

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/14177
PROPOSAL: https://github.com/Expensify/App/issues/14177#issuecomment-1439366694
Tests

Log in NewDot with an account.
Open a new tab, and log in OldDot with a different account that has a existing free workspace.
Go to Settings > Policies > Group.
(Optional) If we can't start OldDot locally, we can open the Chrome developer tools and add a breakpoint in the source panel like the image above.
Click on the free Workspace policy.
(Optional) Execute console.dir(t.replace('https://staging.new.expensify.com', '')) in console to get the  /transition... path part, create a new tab and type localhost:8080 and append the transition path part and then open this url.
Verify that there is no endless spinner and you are logged in the same account as in OldDot.

[x] Verify that no errors appear in the JS console

Offline tests

N/A (This test needs to be online)
QA Steps

Log in NewDot with an account.
Open a new tab, and log in OldDot with a different account that has a existing free workspace.
Go to Settings > Policies > Group and click on free Workspace policy.
Verify that there is no endless spinner and you are logged in the same account as in OldDot.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/8579651/221463956-04c93724-b50b-4355-89c7-f8e0232a9c21.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/8579651/221475478-d6553dea-0114-4266-8fd7-d7d6cd0fee47.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/8579651/221475513-fdec435d-59c9-4f00-a331-82f8cf0d7d9e.mov

Desktop
Feature not yet implemented in the desktop app.

iOS
Feature not yet implemented in the native app.

Android
Feature not yet implemented in the native app.

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.2.77-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.2.77-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Non-basic Lands in Land slots for FRF packs

Just as it had been in DGM packs, FRF packs have a common tapland (two colors, gain 1 life) or rarely a fetchland in place of a basic land.
Is there a way to implement this in 'spoiler' scripts?

pull request welcome

I did hack my way through it by cutting out DGM parts out of cards.js into spoiler scripts.
My implementation has a caveat though - non-english packs can have basic lands along with taplands and fetchlands in their land slot, so my hack reflects that by scraping basic lands in the spoiler page and slapping them in the 'special' rarity array.
Is it still okay to make a pull request?

i can comment on your pr

where did you get the information that english and non-english packs are different?

http://magic.wizards.com/en/articles/archive/feature/fetching-look-fate-reforged-2014-12-24
"Certain languages—Korean, Portuguese, Chinese (Traditional), and Russian—will also contain basic lands in this slot at a high frequency alongside nonbasic lands, as Fate Reforged basic lands will not otherwise be printed in those languages. Other languages will typically not contain basic lands. The frequency at which fetch lands will appear is the same across all languages."
I guess I was partially wrong.

so all packs may contain a basic, tapland, or fetchland. don't worry about the other languages.

@ideocl4st will you make a pr?

@aeosynth I have a final exam tomorrow so it'll a day or two before I can get on it.
You can go ahead if you'd like.

fixed


Add brush feature for transaction history visualization

Reference this gallery example for what the intended implementation will look like: https://airbnb.io/visx/brush
Adding dynamically-resizable subviews to the transaction history visualizations.

Brush feature was implemented in its most basic form on Dec. 18th


Some partitions don't get chance to be consumed with low amount of fetcher threads

Because of golang's channel semantics there's no way to determine which writer will succeed to a non-buffered channel thus leading to some partitions not being consumed properly when having more partitions than fetcher threads.

should be fixed in #92


updated ally link and modal title to be 'report or unlist'

Describe your PR
Ally link should be 'report or unlist' not 'report or update'
Ally modal connected to link should also have the same
Also fixes the legal unused component warning - sorry it got to me
Related to #
Fixes #
Pages/Interfaces that will change
Screenshots / video of changes
Drop some screenshots of the before and after of your work here. Better yet, take a screen recording using a tool like Loom

Steps to test

Go to /allies
view link copy
click link
view modal title

Additional notes

 Ally link and modal should say 'report or unlist'


Can only scrape from localhost

address: <IP_ADDRESS> # Listen address
port: 9348         # Listen port
timeout: 10        # HTTP timeout (in seconds) for Redfish API calls
retries: 1         # Number of retries before a target is marked as unreachable
hosts:
default:
username: urer
password: pass
metrics:
system: true
sensors: true
power: true
sel: false       # iDRAC only
storage: true
memory: true
running in a container. curl times out. There is no firewall between

This is not enough information to go on, but from the sounds of it, this has nothing to do with the exporter itself, but rather your setup.
If there is an actual problem with the exporter I am happy to look into it, but I cannot help with setting it up in your local environment.


Remove Sysprogs.WinCDEmu - driver prompt blocking install

Microsoft Reviewers: Open in CodeFlow

Hey, please approve my JetBrains.ReSharper PR.


docs(api): Various edits to module documentation page

overview
Various improvements to https://docs.opentrons.com/v2/new_modules.html.
changelog

Remove a claim that you can identify a GEN2 module by a label on the side of the device. There is no such label. Writing full guidance for identifying module generations is on Support's to-do list.
Remove the "Checking The Status Of Your Module" section. ~The module sections below it already explain how to check the status, on a module-by-module basis.~ Edit: It doesn't, but it should. In my opinion, that's the more scannable way to write it. To-do before merging.
Reformat the module load name table for readability.
Move the minimum API versions for GEN2 modules from a note to a new column in the load name table. I think this makes the page easier to scan and reference.
Reword the section on module-labware compatibility to explain what "compatibility" means in plain English.
Use lowercase load name strings ("magnetic module gen2" instead of "Magnetic Module Gen2") in the module load name table, because the strings are case-insensitive.
Other minor rewording and restructuring.
To do: Update load_module() reference to point to the module load name table.

review requests
None in particular.
risk assessment
Low. It's just a docs change.

This PR is on hold to prioritize other documentation things. This likely won't be worked on for another week or so.


FaceMesh model not working on iOS browsers

Have I written custom code (as opposed to using a stock example script provided in MediaPipe)
No
OS Platform and Distribution
iOS 16, iOS 15, iOS 14
Mobile device if the issue happens on mobile device
iPhone 13 Pro Max, iPhone X, iPhone 14 Plus, iPad 10.9
Browser and version if the issue happens on browser
Safari 16.5, Chrome 114.0.5735.199
Programming Language and version
JavaScript
MediaPipe version
0.10.1
Bazel version
No response
Solution
FaceMesh
Android Studio, NDK, SDK versions (if issue is related to building in Android environment)
No response
Xcode & Tulsi version (if issue is related to building for iOS)
No response
Describe the actual behavior
Model isn't working on any iOS device, let it be iPhone or iPad but is working on MacOS and safari. Issue seems to be related with iOS.

Simply go to:
https://mediapipe-studio.webapps.google.com/demo/face_landmarker

Describe the expected behaviour
faceMesh model should detect coordinates as it does on other OS

Standalone code/steps you may have used to try to get what you need
Simply go to:
https://mediapipe-studio.webapps.google.com/demo/face_landmarker

Other info / Complete Logs
No response

@bilalahmed24,
Thank you for raising this issue, We are able to reproduce the issue And can see Pose L/andmarker Web demo is not working in iOS browsers. We are forwarding issue internally and let you know once any update becomes available.

@kuaashish faceMesh landmarks model isn't working as well. I am facing same issue in the webApp that I am working on which uses faceMesh model.

Our Web Studio team is looking at this.

This should be fixed now.


Make surveys responsive to numpad hotkeys

From #302

Could be related to DOB entry problems in the about-me survey, as submitted by a couple of users.

Could be fixed using only e.which, will test on keyboard tomorrow morning

Issue: numpad character codes are values 96-106, while top-row character codes are values 48-58. surveyAnimation takes this into account now


Update Bosnia and Herzegovina holidays, add l10n support

Proposed change

update holiday names to official
change subdivision names to ISO 3166-2
observed holidays for all subdivisions
localization (bs, en_US, sr, uk)

Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good: make pre-commit
[x] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
[x] The related documentation has been added/updated (check off the box for free if no updates is required)

coverage: 100.0%. remained the same when pulling a68d861fc2e52a93064609b97f25011487ce350b on KJhellico:upd-bosnia-and-herzegovina into 401e17381aa53b0e8339ce735fa1260ca9570701 on dr-prodigy:beta.


vite + RTL: increase the log output when test failed

Clear and concise description of the problem
My test is failing, but I don't see the problem as my component doest fully show up in the failed test.
Suggested solution
I'd like to be able to see more output of the failed test
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

What do you mean?

when a test fails it prints out the component and what it looks like into the console. the problem is that when a component is relatively big (still under 100 LoC!), the log output doesn't print the entire component, but only a part of it. I'd like to see more to be able to debug it better.

I don't understand how this is Vitest issue? Have you tried looking into RTL settings? For example, changing DEBUG_PRINT_LIMIT


Error when ~/.config is missing

Describe the bug
Error when ~/.config is missing
To Reproduce
Steps / command to reproduce the behavior:
❯ ~/src/crunchy-cli/target/release/crunchy-cli --etp-rt COOKIE_CONTENTS_HERE login
:: ✔ Logged in
:: a unexpected error occurred: No such file or directory (os error 2)

Expected behavior
Either a better error message (example: "~/.config is missing"), or create the missing directory.
Client (please complete the following information):

OS: CentOS7
Version crunchy-cli on  master is 📦 v3.0.0-dev.8 via 🦀 v1.67.1

Additional context
Add any other context about the problem here.

It would be nice if crunchy-cli either had a more clear error message that suggested the need to create the ~/.config dir, or it just created it when needed.

Is the issue resolved with the v3.0.0-dev.9 release?


Exclude setup.py from codecov

@meffij can you verify that this actually does what I think it does? Because we have two code-coverage configuration files in the repo .codecovrc and codecov.yml, both of which include exclude options, so it's unclear to me whether I need to change one or both to keep codecov from failing PRs like this one.

(per discussion, it's better to leave it out of codecov.yml, which controls the codecov tool, then .codecovrc, which controls how the coverage package indexes.)


[FEATURE REQUEST] accommodate people who stumble upon the landing page but don't know what it is

I found myself on the landing page (https://pyribs.org/) and wanted to know what diversity optimization is.  I clicked "tutorials" but was still a little lost.  Then I found "documentation" which has a great overview of diversity optimization and pyribs.  I suggest finding a way to get this info to random people who stumble upon the site, maybe by directing us to the Documentation page and/or by putting it in the Tutorial page and/or the landing page.  I dunno which option is best, but they each seem to accomplish the goal well, albeit in different ways.

resolved by af7ec6ab3fbbf23806e0febf47c6503fe1fe332c


chore: Update logo in readme (again)

In #854, I updated the logo to use white or black based on theme.  While this works well for GitHub, it was pointed out to me that we also render these readme files on package registries, and some (including NPM and also pub.dev) do not set their theme correctly.  (See https://github.com/getsentry/sentry-electron/pull/479#issuecomment-1118755203)
Updating to use the purple Sentry logo instead, which renders well on both white and black backgrounds, and will work for both GitHub and pub.dev.
Sorry for the friction.
#skip-changelog

Codecov Report

Merging #855 (873b611) into main (dac28e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #855   +/-   ##
=======================================
  Coverage   90.29%   90.29%
=======================================
  Files         119      119
  Lines        3762     3762
=======================================
  Hits         3397     3397
  Misses        365      365

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac28e0...873b611. Read the comment docs.


Update reclaim policy documentation to be consistent with field names

Document the actual field values for reclaim policy
Move delete reclaim policy up since that is more common

This change is

/assign @jsafrane @ahmetb @saad-ali

Partially fixes #7469

LGTM

Updated

/lgtm
/assign @tengqm

/lgtm

/approve


Lay down LS localization suppression file on Linux

https://github.com/Microsoft/python-language-server/issues/170
In order to better support Linux containers please add the following to Microsoft.Python.LanguageServer.runtimeconfig.json in the LS folder on Linux:
{
  "runtimeOptions": {
    "configProperties": {
      "System.Globalization.Invariant": true
    }
  }
}

Even better if this can be done only in containers so we don't lose potential localization on Linux in general. It is not appropriate for the LS to suppress localization in general (consider Visual Studio, for example).

Duplicate of #5043


Add ability to rotate subscription keys for Text Analytics service

Issue: https://github.com/Azure/azure-sdk-for-net/issues/8863
Following the patter done for Azure.Storage with SharedKeyCredentials.
To keep this PR simple, test is not configure for recording. Plan to address it when we work on https://github.com/Azure/azure-sdk-for-net/issues/9091

It would be good to have a look at the cognitive auth docs and do a little forward thinking about whether we would also want to support the Subscription-Region header, and if anything different would need to happen for single-service and multi-service subscription keys.

@annelo-msft

support the Subscription-Region header

Currently it is only used for  Translator Text service. We could ask the service team if this is intended to expand to other services (doesn't look like it) for it to be worth making general.
Otherwise it could be something specific to that service.

anything different would need to happen for single-service and multi-service subscription keys

Apart from pricing model, I don't see how our calls will be affected. According to docs it is mandatory to specify the region in the endpoint for multi service. It is ok to have it for single service too, and at the end is just an endpoint that the user gets from either the portal or the Azure CLI, so it will be included.


How to compile .exe for Azure Kinect?

Hi, everyone. I tried to compile the .exe for Azure Kinect with visual studio 2019 but failed. The error outputs are like below:
2>C:\Users\EricXu\Documents\LiveScan3D\LiveScanClient\KinectClient.vcxproj(202,5): error : This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\packages\Microsoft.Azure.Kinect.Sensor.1.4.1\build\native\Microsoft.Azure.Kinect.Sensor.targets.
LiveScanServer: 3>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(1217,5): error MSB3644: 找不到 .NETFramework,Version=v4.5 的引用程序集。要解决此问题，请为此框架版本安装开发人员工具包(SDK/目标包)或者重新定向应用程序。可在 https://aka.ms/msbuild/developerpacks 处下载 .NET Framework 开发人员工具包
LiveScanPlayer: 4>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(1217,5): error MSB3644: 找不到 .NETFramework,Version=v4.5 的引用程序集。要解决此问题，请为此框架版本安装开发人员工具包(SDK/目标包)或者重新定向应用程序。可在 https://aka.ms/msbuild/developerpacks 处下载 .NET Framework 开发人员工具包
I want to ask if there is someone who has successfully compiled the three .exe for Azure Kinect from source? Or is there any possible alternative solutions for this problem?
Thank you very much!

Hey!
As the error message is saying, you're missing the Nuget Packages for the Azure Kinect. You can either right-click on the solution inside of the Solution Explorer in Visual Studio and then click on "Restore Nuget Packages" or you manually download and install the Azure Kinect Nuget Package inside of Visual Studio yourself. This is the package: https://www.nuget.org/packages/Microsoft.Azure.Kinect.Sensor/

Yeah! I solved this! Thank you very much!


How can we access the code?

Hi, How can we access the code?

Dear @comx3i , I push our first version of the LSA framework. You can find instructions in the readme on the main repository.


ios 12 safari graphic glitch phaser 3.60 beta 3

Phaser Version: 3.60 beta 3
Operating system: ios 12
Browser: safari

Description
Moving image from multiable texture atlas leads to graphic glitches.
I did some tests and this bug is only fund in beta 3 not beta 2 and if i reverted
"The Multi Tint fragment shader now uses the new getSampler function approach from Phaser 4" and
"Removed GenerateSrc, removed need for forloop declaration"
it also worked properly again
https://user-images.githubusercontent.com/3351370/141824729-633c3673-4dd2-4afe-a39b-29493cb7e0d9.mp4
Example Test Code
class Demo extends Phaser.Scene
{
    constructor()
    {
        super();
    }

    preload()
    {
        this.load.multiatlas('megaset', 'assets/loader-tests/texture-packer-multi-atlas.json', 'assets/loader-tests/');
    }

    create()
    {
        var atlasTexture = this.textures.get('megaset');

        var frames = atlasTexture.getFrameNames();

        for (var i = 0; i < frames.length; i++)
        {
            var x = Phaser.Math.Between(0, 1024);
            var y = Phaser.Math.Between(0, 768);

            let image = this.add.image(x, y, 'megaset', frames[i]);
            image.setDepth(i);
            this.add.tween({
                targets: image,
                x: x + Phaser.Math.Between(-100, 100),
                y: y + Phaser.Math.Between(-100, 100),
                yoyo: true,
                repeat: -1
            });
        }
    }
}

const config = {
    type: Phaser.AUTO,
    parent: 'phaser-example',
    width: 800,
    height: 600,
    backgroundColor: '#2d2d6d',
    scene: Demo
};

const game = new Phaser.Game(config);

Tested on the latest version of iOS and it doesn't glitch at all, but it is super slow. Like 5 fps. But I also get the same response from Safari on my M1 iMac, yet Chrome on the same machine is 60 fps perfect. So it has to be something in the shader that Apple software, and Apple alone, doesn't like. Just wonderful.

In short, it can't handle 16 texture units (which is what WebGL says it can support). If I limit it to 8 then both iOS and the iMac run ok. It's still not perfect, I can visually see it drop a few frames, but it runs. The 3.55 shader however works fine on iOS, which is very frustrating. I'll have a look further to see if there are any known causes for this. It's a very simple shader function, you'd think Apple could handle it, but I guess not.

Ok, this is now fixed in the master branch. Works fine in Safari on iMac and iPhone, even using all 16 texture units. Drops the for loop from before and goes for a hybrid approach.


Don't env-var evaluate labels from docker build cmd line

Fixes #26027
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

LGTM

@duglin This broke win2lin https://jenkins.dockerproject.org/job/Docker Master (win2lin)/189/console

@tonistiigi @duglin fixed already through https://github.com/docker/docker/pull/27416; looks like two PR's succeeded individually, but resulted in CI to fail when combined

@thaJeztah That link is for revision e5d293375d6f9e4213ba7df68036b1ab082040f1 so after #27416

It looks like this broke some people: #31697


Expect .pm6 extension, not .pm

Some tests were expecting .pm extension but this has been changed
recently:
https://github.com/rakudo/rakudo/commit/98e575de00db42101d4879e43fe740a34791c418

👍 Thanks!


Upload Forecasted Raster Weather-Variability Data

Uses the same logic as previously uploaded historical 4km raster weather-variability. This uploads the same variables from a different forecasted dataset (2006-2099)

Could you also please run lint again:
--- scripts/rff/projected_weather_variability/preprocess_forecast.py	(original)
+++ scripts/rff/projected_weather_variability/preprocess_forecast.py	(reformatted)
@@ -21,9 +21,7 @@
             'rff/raw_data/gcm/NorESM1-M/daily/025deg/agg_year/pr/stats/2021.tif'
         )
         preprocess_raster.create_grids("0.25deg", grids_csv, sample_gtif)
-    src_folder = os.path.join(
-        SCRIPTS_DIR,
-        "rff/raw_data/gcm/NorESM1-M/daily/025deg"
-    )
+    src_folder = os.path.join(SCRIPTS_DIR,
+                              "rff/raw_data/gcm/NorESM1-M/daily/025deg")
     output_csv_fname = f"{CURR_DIR}/WeatherVariability_Forecast.csv"
     main(src_folder, output_csv_fname)
--- scripts/rff/historical_weather_variability/4km/preprocess_4km.py	(original)
+++ scripts/rff/historical_weather_variability/4km/preprocess_4km.py	(reformatted)
@@ -21,8 +21,6 @@
             SCRIPTS_DIR,
             'rff/raw_data/prism/daily/4km/agg_year/ppt/stats/2021.tif')
         preprocess_raster.create_grids("4km", grids_csv, sample_gtif)
-    src_folder = os.path.join(
-        SCRIPTS_DIR,
-        "rff/raw_data/prism/daily/4km")
+    src_folder = os.path.join(SCRIPTS_DIR, "rff/raw_data/prism/daily/4km")

Could you also please run lint again:
--- scripts/rff/projected_weather_variability/preprocess_forecast.py	(original)
+++ scripts/rff/projected_weather_variability/preprocess_forecast.py	(reformatted)
@@ -21,9 +21,7 @@
             'rff/raw_data/gcm/NorESM1-M/daily/025deg/agg_year/pr/stats/2021.tif'
         )
         preprocess_raster.create_grids("0.25deg", grids_csv, sample_gtif)
-    src_folder = os.path.join(
-        SCRIPTS_DIR,
-        "rff/raw_data/gcm/NorESM1-M/daily/025deg"
-    )
+    src_folder = os.path.join(SCRIPTS_DIR,
+                              "rff/raw_data/gcm/NorESM1-M/daily/025deg")
     output_csv_fname = f"{CURR_DIR}/WeatherVariability_Forecast.csv"
     main(src_folder, output_csv_fname)
--- scripts/rff/historical_weather_variability/4km/preprocess_4km.py	(original)
+++ scripts/rff/historical_weather_variability/4km/preprocess_4km.py	(reformatted)
@@ -21,8 +21,6 @@
             SCRIPTS_DIR,
             'rff/raw_data/prism/daily/4km/agg_year/ppt/stats/2021.tif')
         preprocess_raster.create_grids("4km", grids_csv, sample_gtif)
-    src_folder = os.path.join(
-        SCRIPTS_DIR,
-        "rff/raw_data/prism/daily/4km")
+    src_folder = os.path.join(SCRIPTS_DIR, "rff/raw_data/prism/daily/4km")

I ran the yapf command you provided previously to this file. So, we should be good here.


Display Max privacy coins in AVAILABLE  block

Create tab "Max privacy" https://zpl.io/VqWLnGl
Display there max privacy coins https://zpl.io/25LYNQ3

@dariatarakanova need to think through the design so that the user can track the time when the coin becomes available as it is implemented in the desktop wallet

Please add tab "Max Privacy" to Available block https://zpl.io/25LYNQ3

Please add button "more details" https://zpl.io/25LYNQ3

More details screen https://zpl.io/VYlJgge

3.1) Create table with Amount and Latest unlocked time

3.2) Add sort icon

3.3) Sort view https://zpl.io/aMy4OAz

The time calculation will be corrected in this task https://github.com/BeamMW/beam/issues/1672 and then checked.
Time sorting doesn't work

will be closed after checking this task https://github.com/BeamMW/beam/issues/1672

checked


Misalignment on list pages

Something seems to be a little off with size calculations on the list pages; the bottom seems to always be cut off because there is a little extra height that is triggering a scroll bar.

BTW this is version 3.4.13 seen on Safari

which page is this?
it looks okay this my safari.

I see it on the feature list at least.

Safari Version 10.1.2 (11603.3.8)

https://github.com/PATRIC3/p3_web/pull/672


Document how to use Cerbos as a service container on GitHub actions

It should be possible to start Cerbos as a service container on GitHub Actions and use it for tests.

Because services are started before checking out the source, Cerbos will have to start with a SQLite in-mem database as the store.
In the workflow, use cerbos-setup-action to install cerbosctl
Add another workflow step to use cerbosctl put to load policies and schemas from a given directory

I have done a bit of reading on this and actually tried a couple of things on a dummy repository.
Unfortunately, it is not possible to set arguments to the service as of now (source).  Since it is not possible, the service container cannot be configured the way we want.

Because services are started before checking out the source, Cerbos will have to start with an SQLite in-mem database as the store.

I've checked this in case something changed during the time but unfortunately, I did not find anything.
I think one possible solution would be to release an extra image with an image tag like ghcr.io/cerbos/cerbos:0.26.0-ci where we have a default configuration like this;
audit:
  accessLogsEnabled: true
  backend: file
  decisionLogsEnabled: true
  enabled: true
  file:
    path: stdout

engine:
  defaultPolicyVersion: default

server:
  adminAPI:
    adminCredentials:
      passwordHash: JDJ5JDEwJEdEOVFzZDE2VVhoVkR0N2VkUFBVM09nalc0QnNZaC9xc2E4bS9mcUJJcEZXenp5OUpjMi91Cgo= # cerbosAdmin
      username: cerbos
    enabled: true
    grpcListenAddr: ":3593"
    httpListenAddr: ":3592"

storage:
  driver: sqlite3
  sqlite3:
    dsn: ":memory:?_fk=true"

telemetry:
  disabled: true

Then, we could ask the users to use this image if cerbos is needed to run as a container service in a GitHub Workflow.

IIUC, you can override the entrypoint using options. Can it be used to launch Cerbos with:
/cerbos server --set=server.adminAPI.enabled=true --set=storage.driver=sqlite3 --set=storage.sqlite3.dsn=:memory:?_fk=true

Yes, you can override --entrypoint flag of the docker by using options. But, it is not possible to add any arguments or flags into --entrypoint.
The following works;
$ docker run -p 3592:3592 -p 3593:3593 --entrypoint "/cerbos" ghcr.io/cerbos/cerbos:0.26.0

But, this doesn't work;
$ docker run -p 3592:3592 -p 3593:3593 --entrypoint "/cerbos server" ghcr.io/cerbos/cerbos:0.26.0

Overriding the CMD part of the command is only possible by adding the overriding arguments and flags after the image tag;
$ docker run -p 3592:3592 -p 3593:3593 ghcr.io/cerbos/cerbos:0.26.0 server --set=... --set=...

But, this is not supported by GitHub, too.

😞
I guess we can close this then.

😞


⚠ Bofrost.be has degraded performance

In dbf1ed9, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 3041 ms

Resolved: Bofrost.be performance has improved in 8377229.


Add support for cachedb/redis

Hi,
I'm really sorry, I didn't see your pull request before, it was lost in my notifications :(
Thanks a lot for this!


POST health check json having multiple services

I was wondering how to specify multiple service health check configuration in a single JSON.
I was trying with below JSON -
{
  "Checks": [{"Name": "WebApp",
  "Script": "/bin/script.sh",
  "ServiceID": "registrator:dreamy_payne:5000",
  "ServiceName": "webapp",
  "Interval": "10s"
},
{
  "Name": "registry",
  "Script": "/bin/script.sh",
  "ServiceID": "registrator:registry:5000",
  "ServiceName": "registry",
  "Interval": "10s"
}]
}

It gives error- not able to parse multiple services in a single json.
Could anyone please clarify what should be the exact way here?

Not sure. Please refer to Consul docs: https://consul.io/docs/agent/checks.html
If you continue having an issue, I suggest opening an issue with Consul.


Support  Collections level pre-request scripts

Collection/ Folder level scripts are out in Postman 5.5.0. Please see https://github.com/postmanlabs/postman-app-support/issues/882#issuecomment-350535670

Pull Request Test Coverage Report for Build 15

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 14:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls

Pull Request Test Coverage Report for Build 15

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 14:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls

Pull Request Test Coverage Report for Build 15

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 14:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls

Thanks for the enhancement @dsKarthick!


Materialized View on Redshift errors with  "pg_matviews" does not exist

I've installed the dbt experimental features package for materialized-views. When i run dbt compile on redshift, I get the following:
Database Error
  relation "pg_matviews" does not exist

This looks related to the postgres__list_relations_without_caching macro override for Redshift and Postgress:
https://github.com/dbt-labs/dbt-labs-experimental-features/blob/84e676bb0721d32e206e9f7e31def6ce4321513e/materialized-views/macros/postgres/adapters.sql#L24
but pg_matview doesn't exist on Redshift. I confirmed this by running the following on my Redshift cluster as the superuser.
SELECT * FROM pg_matviews

[2022-04-04 14:55:19] [42P01] ERROR: relation "pg_matviews" does not exist

Hey @bxm156, there's a different version of list_relations_without_caching that you should use when running on Redshift:
https://github.com/dbt-labs/dbt-labs-experimental-features/blob/32eff6149f74e626c9932bd61a1604471fb76321/materialized-views/macros/redshift/adapters.sql#L45-L74
If you define both of those macros in your project (redshift__list_relations_without_caching + postgres__list_relations_without_caching), dbt should prefer the former when running on Redshift

@jtcohen6
Here is my macro file, I copied it from the documentation, am I missing something?
{# postgres and redshift #}

{% macro drop_relation(relation) -%}
  {{ return(dbt_labs_materialized_views.drop_relation(relation)) }}
{% endmacro %}

{% macro postgres__list_relations_without_caching(schema_relation) %}
  {{ return(dbt_labs_materialized_views.postgres__list_relations_without_caching(schema_relation)) }}
{% endmacro %}

{% macro postgres_get_relations() %}
  {{ return(dbt_labs_materialized_views.postgres_get_relations()) }}
{% endmacro %}

{# redshift only #}

{% macro redshift__list_relations_without_caching(schema_relation) %}
  {{ return(dbt_labs_materialized_views.redshift__list_relations_without_caching(schema_relation)) }}
{% endmacro %}

{% macro load_relation(relation) %}
  {{ return(dbt_labs_materialized_views.redshift_load_relation_or_mv(relation)) }}
{% endmacro %}

@bxm156 Hmm. Which version of dbt are you using? When I try this locally, by copying the same code into a macro file and running against Redshift, I see the correct query running during list_relations_without_caching (in logs/dbt.log):
select
      '<mydb>' as database,
      tablename as name,
      schemaname as schema,
      'table' as type
    from pg_tables
    where schemaname ilike '<myschema>'
    union all
    select
      '<mydb>' as database,
      viewname as name,
      schemaname as schema,
      case when definition ilike '%create materialized view%'
        then 'materializedview'
        else 'view'
        end as type
    from pg_views
    where schemaname ilike '<myschema>'

I'm on DBT 0.21.0.
Here is what i see in the logs...
2022-04-13 22:21:45.360951 (MainThread):
2022-04-13 22:21:45.361314 (MainThread): Acquiring new redshift connection "master".
2022-04-13 22:21:45.364175 (ThreadPoolExecutor-0_0): Acquiring new redshift connection "list_ads_admin".
2022-04-13 22:21:45.376745 (ThreadPoolExecutor-0_0): Using redshift connection "list_ads_admin".
2022-04-13 22:21:45.376905 (ThreadPoolExecutor-0_0): On list_ads_admin: BEGIN
2022-04-13 22:21:45.377028 (ThreadPoolExecutor-0_0): Opening a new connection, currently in state init
2022-04-13 22:21:45.377149 (ThreadPoolExecutor-0_0): Connecting to Redshift using 'IAM' credentials
2022-04-13 22:21:45.556661 (ThreadPoolExecutor-0_0): unclosed <ssl.SSLSocket fd=7, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('<IP_ADDRESS>', 42418), raddr=('<IP_ADDRESS>', 443)>
2022-04-13 22:21:45.880048 (ThreadPoolExecutor-0_0): SQL status: BEGIN in 0.50 seconds
2022-04-13 22:21:45.880303 (ThreadPoolExecutor-0_0): Using redshift connection "list_ads_admin".
2022-04-13 22:21:45.880424 (ThreadPoolExecutor-0_0): On list_ads_admin: /* {"app": "dbt", "dbt_version": "0.21.0", "profile_name": "admetrics", "target_name": "dev", "connection_name": "list_ads_admin"} */
select
      'ads' as database,
      tablename as name,
      schemaname as schema,
      'table' as type
    from pg_tables
    where schemaname ilike 'admin'
    union all
    select
      'ads' as database,
      viewname as name,
      schemaname as schema,
      'view' as type
    from pg_views
    where schemaname ilike 'admin'
    union all
    select
        'ads' as database,
        matviewname as name,
        schemaname as schema,
        'materializedview' as type
    from pg_matviews
    where schemaname ilike 'admin'

2022-04-13 22:21:45.910986 (ThreadPoolExecutor-0_0): Postgres error: relation "pg_matviews" does not exist

2022-04-13 22:21:45.911182 (ThreadPoolExecutor-0_0): On list_ads_admin: ROLLBACK

Awesome! I was able to use the following successfully:
dispatch:
  - macro_namespace: dbt
    search_order: ['<name_of_your_project>', 'dbt']


Add object detection processing tutorial

The following adds a quick guide on how to process object detection datasets with albumentations.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Great idea! Now that we have more than one task, it makes sense to separate image classification and object detection so it'll be easier for users to follow.

@lhoestq do we want to do that in this PR, or should we merge it and let @stevhliu reorganize separately?


#ext_contract consumes the associated Trait

When defining the ext_contract interface for your own contracts to do callbacks, it is beneficial to implement this Trait using impl. Example:
 #[ext_contract(ext_self)]
 trait FungibleTokenResolver

 { fn ft_resolve_transfer( &mut self, sender_id: AccountId, receiver_id: AccountId, amount: U128, ) -> U128; }

#[near_bindgen]
 impl FungibleTokenResolver for Contract

 { ... }

But because the Trait is consumed, the impl FungibleTokenResolver for Contract fails.
Current workaround is to reintroduce a copy of this Trait:

#[ext_contract(ext_self)]

trait FungibleTokenResolver { fn ft_resolve_transfer( &mut self, sender_id: AccountId, receiver_id: AccountId, amount: U128, ) -> U128; }

trait FungibleTokenResolver { fn ft_resolve_transfer( &mut self, sender_id: AccountId, receiver_id: AccountId, amount: U128, ) -> U128; }

#[near_bindgen]

impl FungibleTokenResolver for Contract { ... }

The new ext API doesn't remove the existing trait


Do not include --all-features in feature combination if --exclude-features passed

See https://github.com/taiki-e/cargo-hack/issues/42#issuecomment-721082000

bors r+


Add support for name parameter on ${Assembly-version}

related #275

Current coverage is 76% (diff: 100%)

Merging #1578 into master will decrease coverage by <1%

@@             master      #1578   diff @@
==========================================
  Files           270        270
  Lines         16318      16327     +9
  Methods        2611       2612     +1
  Messages          0          0
  Branches       1775       1777     +2
==========================================
+ Hits          12432      12437     +5
+ Misses         3483       3474     -9
- Partials        403        416    +13

Powered by Codecov. Last update 8ec0bf3...e1b2167


Improve addressing modes to not need alias cpu functions

Codecov Report

Merging #7 (d687176) into main (7cc15b4) will increase coverage by 1.18%.
The diff coverage is 33.50%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   33.89%   35.08%   +1.18%
==========================================
  Files          57       57
  Lines        4871     4997     +126
==========================================
+ Hits         1651     1753     +102
- Misses       3174     3191      +17
- Partials       46       53       +7


perf: unify glob_match_with_brace and glob_match

@shulaoda Now, its performance when matching expressions without braces surpasses that of glob-match and is similar to fast-glob. However, for expressions with braces, its performance is comparable to glob-match, similar to the main branch of fast-glob.

Amazing! Thanks!


Example is incorrect

I may be mistaken, but I believe your idiomatic FizzBuzz example is incorrect.
In the second stanza when you use the Midnight function to make the logical comparisons you write Midnight taking Desire, when it should be Midnight taking My world,. This is because Desire is set to the numerical value of 100 and functions like the Limit variable in the minimalist example. My world is the variable that is being increased and should accordingly be used in the logical comparisons.

For example:
the line
If Midnight taking Desire, Fire is nothing and Midnight taking Desire, Hate is nothing
should be
If Midnight taking My world, Fire is nothing and Midnight taking My world, Hate is nothing


PUB-1438 - Add custom cert module

JIRA link (if applicable)
PUB-1438
Change description
Add pip shared infra custom module made to do the same as the secrets, but as certs.
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ x ] No

duplicate of line 11?

sorry, to many things at once. I have updated the name


Strange lines get inserted in the wrong place or diff computed wrong

Im not sure what is causing the issue, but ive seen several cases where doing a copy actually results in new differences. ive attached two files that you can paste into the respective editors. copy the difference in the fileb  side to the filea side and you'll see a new difference is then created for the blank line after the original difference.  Not sure if this is line ending related or diff related?
fileb.txt
filea.txt

I think I know how to fix, but I’m currently travelling so I could get to it in a few days.

hmm. nope. that didnt fix the issue. I still get a new difference after copying. It's like it's not initially detecting the blank line as a difference and then once the first difference is resolved then it detects it as a difference.

Still travelling, but managed to create the smallest possible repro:
start

something else

end

and
starts
mid
end

I will be looking into why this is happening. Pushed the branch here for now https://github.com/ace-diff/ace-diff/tree/JackuB/merge-with-newlines

The issue is with newlines - if you look at the raw output from https://github.com/JackuB/diff-match-patch there is \nend (0 means no change, so it's not part of the patch that's applied)

If you manually move the \n to the previous line https://github.com/ace-diff/ace-diff/commit/42b957ee183c614494a614d836f8c8ed1b49d411 it would fix the diffing, as now the newline will be part of the patch.

I think it might be related to this behaviour: https://github.com/ace-diff/ace-diff/blob/42b957ee183c614494a614d836f8c8ed1b49d411/src/index.js#L494-L497

any idea what the solution might be?
On Thu, Apr 19, 2018 at 8:55 AM, Jakub Mikulas<EMAIL_ADDRESS>wrote:

The issue is with newlines - if you look at the raw output from
https://github.com/JackuB/diff-match-patch there is \nend (0 means no
change, so it's not part of the patch that's applied)
[image: snimek obrazovky 2018-04-19 v 17 04 16]
https://user-images.githubusercontent.com/1788727/39003140-878fa57a-43fa-11e8-9e75-747c09910491.png
If you manually move the \n to the previous line 42b957e
https://github.com/ace-diff/ace-diff/commit/42b957ee183c614494a614d836f8c8ed1b49d411
it would fix the diffing, as now the newline will be part of the patch.
[image: 2018-04-19 17_52_12]
https://user-images.githubusercontent.com/1788727/39003244-be0efde4-43fa-11e8-89c9-31cb7f4a2ddc.gif
I think it might be related to this behaviour:
https://github.com/ace-diff/ace-diff/blob/42b957ee183c614494a614d836f8c8
ed1b49d411/src/index.js#L494-L497
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ace-diff/ace-diff/issues/28#issuecomment-382788233,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATV__HlfHRp2sUwkH9IJta7ap8rIittks5tqLN9gaJpZM4SQOWp
.


TimeoutError

I got this error when I start it up
:~/chatgpt-telegram-bot$ xvfb-run -a --server-args="-screen 0 1280x800x24 -nolisten tcp -dpi 96 +extension RANDR" pnpm start

><EMAIL_ADDRESS>start /home/chatgpt-telegram-bot
> node dist/index.js

TimeoutError: Waiting for selector `#password` failed: Waiting failed: 180000ms exceeded
    at Timeout.<anonymous> (/home/chatgpt-telegram-bot/node_modules/.pnpm/registry.npmmirror.com+puppeteer-core@19.5.2/node_modules/puppeteer-core/lib/cjs/puppeteer/common/WaitTask.js:64:32)
    at listOnTimeout (node:internal/timers:564:17)
    at process.processTimers (node:internal/timers:507:7)
 ELIFECYCLE  Command failed with exit code 1.

It looks like there is no password, but I am logged in through Google authentication and I'm sure I set the correct password in .env.
I checked, there are no special characters in my password.
So can give some help?THX

Have you set IS_GOOGLE_LOGIN to true in .env? If not, the bot will use OpenAI authentication, which requires you to solve the recaptcha before you can input the password (like https://github.com/transitive-bullshit/chatgpt-api/issues/199).
If this problem exists when IS_GOOGLE_LOGIN=true, you may forward the display to your local computer and see what went wrong during the authentication.

IS_GOOGLE_LOGIN=ture

It's true not ture 😂.


Menu items within categories are always visible

Checklist

[X] The bug is reproducible against the latest release or master.
[X] There are no similar issues or pull requests to fix it yet.

Describe the bug
If a menu item is added to a category, it wouldn't be hidden, even if is_visible function of the Model/View returns False
Steps to reproduce the bug
class UserAdmin(ModelView, model=User):

    category = 'Accounts'

    def is_visible(self, request: Request) -> bool:
        return bool(request.session.get('username'))

    def is_accessible(self, request: Request) -> bool:
        return bool(request.session.get('username'))

admin.add_model_view(UserAdmin)

This menu item will be visible even if request.session is empty
Though, if you delete (or comment out) category parameter of UserAdmin, this menu item will be hidden for not authenticated users
Expected behavior
Menu item is hidden
Actual behavior
Menu item is visible
Debugging material
No response
Environment

macOS
Python 3.11
SQLAlchemy 2.0.25

Additional context
No response

I think this PR is already closing this #698

#698 doesn't contain any tests :(

@aminalaee
Apologies, I was a version behind. I can confirm this fix works. Is there a way to put an icon on the CategoryMenu?


Changes to settings of redirected printers not retained on server

I know this is seemingly a server-side issue, but I just tested with MSTSC (version 6.1.7601.17514) on a Windows 7 client connecting to both a Windows 2003 Server and a Windows 7 Professional machine, and changes to the settings persisted across sessions.  Any settings made while connecting with FreeRDP 1.0.1 (current git master branch as of a few hours ago) were lost upon logout or disconnection.
Note, I was sure to heed the information here:  http://support.microsoft.com/kb/243942
Otherwise, the redirected printers work great.  Not too much use though, unless I can work this out.

@ipitcher Is this still an issue with master?

Closing du to inactivity. Please re-open or create a new issue if this problem still exists on the current mater branch.

I'm quite sure the issue is still there as we don't handle the message to handle the printer configuration


App crash during Record on Samsung note 3 with android 5

Record not working on Samsung note 3 with android 5, I am trying to recording but app suddenly crashed

Hello @Jithinag007 , thanks for you report. Could you bring more details, like logs or stack traces? Thanks 😄