match for user-defined classes

A long time ago, I put in a special syntax for extracting the contents of a Dynamic out. It's a funky .@(type), and I hardly ever use it now. However, I never put in syntax to allow for doing that kind of cast onto a class. Part because it would involve a new runtime opcode, and part because I wasn't sure I wanted to do it that way.
What I'd like to do is to extend match, so that the input sym can be a user-defined class. Example:
class Base {}
class Left < Base {}
case Right < Base {}

var v: Base = Right()

match v: {
    case Left(l):
    case Right(r):
    else:
}

Rules:
Since users can't control the open-ness of their classes, I think it's unfair to have an exhaustiveness check, because their classes may be extended from a far away place. Instead, I think matching upon a user-defined class should instead require that there is an else clause.
Polymorphic classes will not have this available to them. If, for example, Left was defined as having some generic, then that generic couldn't be filled based on Base because it doesn't exist. I may later relax this to allow it if the generic counts are equal. But I think the more important goal is that this works for more simple classes which I think are more likely to need it.
This will not work for Dynamic, though I may later make it work for Dynamic so that the .@(type) special-case syntax can be removed.
I plan to add a with block that mirrors the Rust-style if let block in the future as a shorthand for when a user is only interested in one particular enum or user class case.

Very cute idea - it's much better than the usual is_instance.


Generate links to definition in source code pages on docs.rs and dev-docs.bevyengine.org

Objective

Fix issue #2611

Solution

Add --generate-link-to-definition to all the rustdoc-args arrays in the Cargo.tomls (for docs.rs)
Add --generate-link-to-definition to the RUSTDOCFLAGS environment variable in the docs workflow (for dev-docs.bevyengine.org)
Document all the workspace crates in the docs workflow (needed because otherwise only the source code of the bevy package will be included, making the argument useless)

I think this also fixes #3662, since it fixes the bug on dev-docs.bevyengine.org, while on docs.rs it has been fixed for a while on their side.

Changelog

The source code viewer on docs.rs now includes links to the definitions.

I excluded the private crates from being documented. While doing so I noticed the release workflow has a similar logic: https://github.com/bevyengine/bevy/blob/09a1f94d142cb88dcbd00483e58fd598deb5b429/.github/workflows/release.yml#L43-L46 However it is not excluding all the private crates (build-templated-pages and example-showcase are missing). I wonder why it's not a problem there.

However it is not excluding all the private crates (build-templated-pages and example-showcase are missing). I wonder why it's not a problem there.

Do certain crates have publish = false in their Cargo.toml?

Do certain crates have publish = false in their Cargo.toml?

They do, TIL!
https://github.com/bevyengine/bevy/blob/09a1f94d142cb88dcbd00483e58fd598deb5b429/tools/build-templated-pages/Cargo.toml#L6
https://github.com/bevyengine/bevy/blob/09a1f94d142cb88dcbd00483e58fd598deb5b429/tools/example-showcase/Cargo.toml#L6
Though the other packages also have that config set (with the exception of errors, which doesn't appear to have a Cargo.toml, but I guess that would also prevent it from being published).


Added new example in examples/features page.

Added a new example on examples page - in the features section.
Live preview

Before starting a code review, do you consider this new example acceptable in terms of design @mdo?

Before starting a code review, do you consider this new example acceptable in terms of design @mdo?

Is there any guidelines for the examples? In terms of design? 🙂
I'm thinking about adding a few more examples.

Can I please have any update on this?
I am happy to make any changes if somehow this examples doesn't fit. :)
@julien-deramond

Always down for more example snippets! Handful of code quality and consistency things here to address first though :).

Hey @mdo,
I've fixed all the issues you pointed out, had some issues with the .editorconfig on my VS Code but It worked out fine on Sublime Text.
Thanks a lot for reviewing this. I'm planning to contribute with more examples! 😊

Just pushed the required changes!
Thanks for the heads up, will surely take care of this in future!

Perfect, thank you @thevipinmishra


Suggestion: let's create CHANGELOG?

Hello!
It seems to be backup hasn't changelog. Version numbering doesn't show appearence (or not) of major changes such as incompatibalities or new faetures.
Suggestion: let's create CHANGELOG?

+1

We do have release notes: http://backup.github.io/backup/v4/release-notes/

thanks a lot for the info @tombruijn
maybe you also consider PR #704 a useful link


DO NOT REVIEW: chore: use npm install retry script in system test

@nolanmar511 The PR title needs some polish. Code lgtm.


Integration tests fixes

https://issues.jboss.org/browse/ISPN-9990
https://issues.jboss.org/browse/ISPN-9991

Integrated into master, thanks @ryanemerson !


Update raw-events.md

🚀 Deployed on https://635b04e63f4fa313e9e16696--cozy-fox-0defec.netlify.app


⚠ SceneTime has degraded performance

In 6a670a1, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 3545 ms

Resolved: SceneTime performance has improved in 8b9291e after 6 minutes.


Update devices.js

Add support for the Philips Hue Welcome white flood light.
This is the warm white only version.
Device details: http://www.p4c.philips.com/cgi-bin/cpindex.pl?ctn=1743630P7&hlt=Link_ProductInformation&mid=Link_ProductInformation&scy=FR&slg=AEN
Image link: https://images.philips.com/is/image/PhilipsConsumer/1743630P7-RTP-global-001?wid=2000&hei=2000&$jpglarge$

Thanks!


Composer install fails

Composer install fails
After cloning my forked repository and grabbing the composer installer, the first thing I do is to install all composer libraries.
php composer.phar install

Unfortuantely it failed immediately.
[Composer\Json\JsonValidationException]
  "./composer.json" does not match the expected JSON schema:
  - authors[0].homepage : Invalid URL format

Here's the screenshot:

fixed by #116

fixed by #116


Private fields

It would be nice if all the SearchView fields were protected, for overriding purposes.

This would be very practical indeed

I will add it to next version in August.


MM-45456 - Gekidou LoadingUnreads component keeps spinning

Summary
As stated in the ticket, the loader next to the server displayname kept spinning when we add a new server.
This PR fixes this issue by:

Ensuring that this component loading state is dictated only when it receives an event, so that it just doesn't spin on mount.
Add a workaround on top of the cancelAnimation function call due to a bug on reanimated 2.  The bug in itself prevents a shared value that switches between two values from being interrupted/cancelled.

@coltoneshaw  - I'm adding you to this PR so that you can verify if the builds work for you.
Ticket Link
https://mattermost.atlassian.net/browse/MM-45456
Device Information
This PR was tested on:
Release Note
NONE

Building app in separate branch.


Request - Add to Homebrew

I created a PR https://github.com/Homebrew/homebrew-core/pull/89471/files

Thanks @jedahan
Once it's merged, I'll update the readme.

@jedahan thank you for your effort. I've created a new PR and will try to get it merged https://github.com/Homebrew/homebrew-core/pull/89631

Smug is available in Homebrew now.


[INSERT EMAIL ADDRESS] placeholder in Code of Conduct

The current version of the Code of Conduct! has a blank:

Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the Project CHIP open source team at [INSERT EMAIL ADDRESS].

Please provide a way to contact the enforcement team of Project CHIP in a way that protects the identity of the person reaching out.
(Note: I have created a new issue because this was not resolved in #1439 as stated).

Still not fixed.

Still not fixed.

Still not fixed.


Sort expansion sequence if all commands are epoch relative

@camargo @cohansen My understanding is that not only epoch commands, but also absolutely timed commands should be sorted (which is the majority of our use cases). See #759 (but in Jira because expanded commands should not be in the public github). Are absolute timed commands included in another ticket?

@camargo @cohansen My understanding is that not only epoch commands, but also absolutely timed commands should be sorted (which is the majority of our use cases). See #759 (but in Jira because expanded commands should not be in the public github). Are absolute timed commands included in another ticket?

Yep, absolute and relative commands are already being sorted per this PR: #876.

@camargo @cohansen My understanding is that not only epoch commands, but also absolutely timed commands should be sorted (which is the majority of our use cases). See #759 (but in Jira because expanded commands should not be in the public github). Are absolute timed commands included in another ticket?

Yep, absolute and relative commands are already being sorted per this issue and associated PR: #828.

Ah-ha! Great, thank you. :-)

Closing. This will not apply an expanded sequence for multiple activities.


[Swashbuckle 4.0] Can't get description for a property inherits from parent class.

Hi,
I have a method:
public User GetUser([FromUri] GetUserRequest getUserRequest)
GetUserRequest inherits from GetRequest. The definition of the GetUserRequest and GetRequest:
public class GetUserRequest : GetRequest
{
///
/// User id
///
[Required]
public int UserId { get; set; }
///
/// User name
///
[Required]
public string UserName { get; set; }
///
/// User status
///
[Required]
public UserStatus Status { get; set; }
///
/// User address
///
public Address Address { get; set; }
}
public class GetRequest
{
    /// <summary>
    /// Other information
    /// </summary>
    public string Other { get; set; }
}

I use operationFilter to convert the complex parameter to be several query parameters. I need to get model.Property.Value.Description for the every properties of GetUserRequest including Other property. But I can't get the description for the Other property which inherits from GetRequest class.
What should I do for this?
Thanks,
Peter

Fixed in the swagger_2.0 branch - hoping to release within a week or so

Swashbuckle 5.0.0 released! This issue should now be resolved. Please try it out when you get a chance.


show flake8 some love

[ ] remove F811, F401 from setup.py
[ ] run flake8
[ ] fix all errors reported

Fixed by #484


Channel, Add Condition and Global label field not showing validation error message if user save without entering any data in these fields.

Framework Version: 0.1.6

Framework Version: 0.1.6

Fixed


Refactor methods to accept optionalParameters Map

Fix #1
Fix #2

Refactored alvariumCreate, alvariumTransit, alvariumMutate to accept Map<String,String> optionalParameters instead of  String artifactPath.
The artifcatPath, checksumPath and sourceCodeChecksumPath is extracted from the Map. If (checksumPath or sourceCodeChecksumPath) is not provided they're set with the default values below.
Refactored alvariumGetAnnotators to accept checksumPath and sourceCodeChecksumPath.

Map<String,String> optionalParameters=[:]: Supports optional parameters (artifactPath, checksumPath, sourceCodeChecksumPath)
artifactPath: Only required when "checksum" annotator is passed in the annotatorKinds list and will throw an error if not present when required by the "checksum" annotator. This parameter is used to locate the artifact.
checksumPath: Used to locate the artifact checksum, default value if not provided is "\${JENKINS_HOME}/jobs/\${JOB_NAME}/\${BUILD_NUMBER}/\${artifactName}.checksum"
sourceCodeChecksumPath: Used to locate the source code checkusm, default value if not provided is "${JENKINS_HOME}/${JOB_NAME}/${BUILD_NUMBER}/checksum"
Example:
 script {
             def artifactChecksum = readFile "/${JENKINS_HOME}/jobs/${JOB_NAME}/${BUILD_NUMBER}/alvarium-sdk-1.0-SNAPSHOT.jar.checksum"
             def optionalParameters = [
               'artifactPath' :'${WORKSPACE}/target/alvarium-sdk-1.0-SNAPSHOT.jar',
               'checksumPath' : '/${JENKINS_HOME}/jobs/${JOB_NAME}/${BUILD_NUMBER}/alvarium-sdk-1.0-SNAPSHOT.jar.checksum'
               ]
             alvariumMutate(['checksum'], optionalParameters, artifactChecksum.bytes)
         }

@o-eissa LGTM, where you able to test this in a working Jenkins pipeline ?

@o-eissa LGTM, where you able to test this in a working Jenkins pipeline ?

Unfortunately not fully, I'm still getting some MqttException while trying to run a test pipeline but trying to make it work. If it looks good to you can keep it open till I verify it's working on the pipeline and merge it then.


[Fix-4705][API] Fix KeeperException$NoNodeException

What is the purpose of the pull request
Fix KeeperException$NoNodeException
This closes #4705
Brief change log

Fix KeeperException$NoNodeException

Verify this pull request
This pull request is already covered by existing tests, such as (please describe tests).

dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/WorkerGroupServiceTest.java

(and)
This change added tests and can be verified as follows:

Manually verified the change by testing locally.

Codecov Report

Merging #4961 (defecc3) into dev (8c68e2c) will decrease coverage by 0.22%.
The diff coverage is 20.00%.

@@             Coverage Diff              @@
##                dev    #4961      +/-   ##
============================================
- Coverage     47.37%   47.14%   -0.23%
+ Complexity     3692     3677      -15
============================================
  Files           568      568
  Lines         23891    23893       +2
  Branches       2754     2754
============================================
- Hits          11318    11265      -53
- Misses        11544    11603      +59
+ Partials       1029     1025       -4

Impacted Files
Coverage Δ
Complexity Δ

...duler/api/service/impl/WorkerGroupServiceImpl.java
71.21% <20.00%> (-8.48%)
9.00 <1.00> (+1.00)
:arrow_down:

...he/dolphinscheduler/common/enums/SqoopJobType.java
0.00% <0.00%> (-88.89%)
0.00% <0.00%> (-3.00%)

...uler/server/master/processor/TaskAckProcessor.java
27.77% <0.00%> (-66.67%)
1.00% <0.00%> (-1.00%)

...he/dolphinscheduler/remote/utils/ChannelUtils.java
16.66% <0.00%> (-16.67%)
1.00% <0.00%> (ø%)

...lphinscheduler/remote/future/ReleaseSemaphore.java
85.71% <0.00%> (-14.29%)
2.00% <0.00%> (-1.00%)

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
3.00% <0.00%> (-1.00%)

...inscheduler/remote/handler/NettyClientHandler.java
29.82% <0.00%> (-5.27%)
5.00% <0.00%> (-1.00%)

...eduler/server/worker/runner/TaskExecuteThread.java
58.53% <0.00%> (-4.88%)
13.00% <0.00%> (-1.00%)

...er/server/worker/task/AbstractCommandExecutor.java
16.66% <0.00%> (-4.63%)
10.00% <0.00%> (-3.00%)

...er/master/processor/queue/TaskResponseService.java
71.23% <0.00%> (-2.74%)
8.00% <0.00%> (-2.00%)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c68e2c...defecc3. Read the comment docs.

can you cherry this pr to 1.3.6-prepare,

can you cherry this pr to 1.3.6-prepare?

I will


One possible solution for "Error: Could not find MIME for Buffer "

I wasn't sure where to post this exactly. This may be just a hack. If there's a better solution, I'd appreciate knowing about it.
Expected Behavior
I'm uploading a file using Apollo (GraphQL), then trying to read an image file using Jimp and resize it.
Un-expected/wanted Behavior
I was getting "Error: Could not find MIME for Buffer "
Solution
I wrapped my jimp code block in a setTimeout like below and that fixed the problem
fileUpload: async (parent, args) => {
      const file = await args.file;
      const filename = `user-${args.uid}.jpg`;
      const filePath = path.join(__dirname, `../../tmp/${filename}`);

      console.log(filePath);

      await file.createReadStream().pipe(createWriteStream(filePath));

setTimeout(() => {
      jimp
        .read(`tmp/${filename}`)
        .then(image => {
          image.cover(400, 400);
          image.writeAsync(`uploads/${filename}`, jimp.AUTO);
        })
        .catch(error => {
          throw new Error(error);
        });
}, 500);

      return file;
    }

Jimp Version: 0.14.0
Operating System: Windows 10, 1909
Node version: v12.16.3

I've just run into the same problem, on my local windows machine it works, but when running it on Ubuntu 18.04.5, I get the same error.

Jimp Version: 0.16.1
Operating System: Ubuntu 18.04.5
Node Version: v14.16.0

Have you found a better solution yet?

Here's my updated code that seems to work better than what I posted above.  Hope this helps. ALl the best.
`
const { promisify } = require('util');
profilePicUpload: async (parent, args) => {
  // have to await file file is uploaded

  const { createReadStream } = await args.file;
  const fileStream = createReadStream();
  const fileName = `user-${args.uid}.jpg`;
  const tmpFilePath = path.join(__dirname, `../../tmp/${fileName}`);
  const tmpFileStream = createWriteStream(tmpFilePath, { encoding: 'binary' });

  const user = await User.findById(args.uid);
  const currProfilePic = user.profileImg;
  const currImgFilePath = path.join(
    __dirname,
    `../../static${user.profileImg}`
  );

  user.errs = [];

  const finished = promisify(stream.finished);

  fileStream.setEncoding('binary');

  for await (const chunk of fileStream) {
    if (!tmpFileStream.write(chunk)) {
      await once(tmpFileStream, 'drain');
    }
  }

  tmpFileStream.end(() => {
    jimp
      .read(`tmp/${fileName}`)
      .then(image => {
        image.cover(300, 300).quality(60);
        image.writeAsync(`static/uploads/users/${fileName}`, jimp.AUTO);
      })
      .then(() => {
        unlink(tmpFilePath, error => {
          user.errs.push(error);
        });
        if (currProfilePic !== '/uploads/users/user.png') {
          unlink(currImgFilePath, error => {
            if (error && error.errno === -4058) {
              user.errs.push('Existing profile image not found.');
            }
          });
        }
      })
      .catch(error => {
        throw new Error(error);
      });
  });

  await finished(tmpFileStream);

}`

Thank you very much! I will look into implementing something similar, even though the whole error is still a bit weird to me.

I guess an easy fix would be to allow an syntetic path as "option". Currently the bitmap is getting parsed with the path defined as null. If this could be also a syntetic path, there would be a suitable workaround for a lot of people who are facing the issue that the file type can't be read from the buffer ...


All EU powered machinery suddenly stops getting power

In my attempts to fix my problem with EBF (Electric Blast Furnace) not getting enough EU power, I connected multiple (4) LV 4A Energy Converters in a row and connected all of them with cables (16x Gold Cable) and a wire cutter to the EBF. Suddenly, it's not getting any power. When trying to connect other LV machinery (Lathe, Wiremill, Compressor) it's too doesn't get any EU power, even after switching to 16x Copper Wire
I am attaching the world archive if anyone can get it working (or is it a bug on my end)
world.zip

I have looked into this, and the reason for the power converter not working is that you have hooked your power "input" into the "output" of the converter.
To fix this, use a wrench and turn the converter.
Converters, and for that matter transformers, have two sides: input (big) and output (small). To change the way you need power to be converted, you can use a mallet.
You might still have power issues with your EBF. This is due to the EBF needing 120 EU/t, and when subtracting cable loss (which on copper cables is 6 EU per block), you only supply the EBF with around 100 EU/t.
To fix this, use the "super overpowered" super conductors (cable with 0 EU/t cable loss) instead. For LV, this is soul-infused wires.
I hope this helped you.
KgN

Yes, this helped me, thanks! I just forgot that i was using a wrong side of the converter
TYSM for other notes too, because it's my first experience with gregtech's LV machines and EU electricity


multiple text and Select on the same line

It is possible create a template with multiple text and Select option on the same line?
How?

Just use <Select> in
 layout block. Does this satisfy your requirements?
<Blocks>

    text with

    multiple lines
    <Select>
      <Option value="foo">foo</Option>
      <Option value="foo">bar</Option>
    </Select>

</Blocks>


MSDKUI-2198: Updated creation of NSKeyedUnarchiver to fix deprecation

Signed-off-by: Piotr Szmyt<EMAIL_ADDRESS>

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   87.53%   87.53%
=======================================
  Files          59       59
  Lines        3683     3683
=======================================
  Hits         3224     3224
  Misses        459      459

Flag
Coverage Δ

#ios
87.53% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b12f5a...99511ca. Read the comment docs.


fixed pin to blog

@Adesojisouljay pin to community logic broken? @ecency account is not moderator on LeoFinance community.

@Adesojisouljay pin to community logic broken? @ecency account is not moderator on LeoFinance community.

Yes, That's why I haven't requested review, I'm looking into that.
Once iI fix that I will notify.
Thanks

What does this PR?
Users who do not have roles in any community do not see the "Pin to blog" option.
This PR fixes that.
See video
https://github.com/ecency/ecency-vision/assets/88087890/ca214fcf-eaf6-4c51-8d0d-119a6ce82519
Issue


groff: 1.22.4 -> 1.23.0

Description of changes
Update groff to 1.23.0

[x] I believe #235505 can be closed if this PR is merged.

✅ In order to enableHtml on Darwin #241869 is needed as it fixes the psutils build on the platform.
ℹ Notice that groffer has been removed from the upstream repo (see upstream commit 1d2df80a933d for details).

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg build groff groff.passthru.tests

groff has about 50 reverse dependencies in nixpkgs. I tried to build my system with your change and encountered man-db failure:
FAIL: man1/zsoelim.1
FAIL: man8/accessdb.8
FAIL: man1/apropos.1
FAIL: man1/whatis.1
FAIL: man8/catman.8
FAIL: man5/manpath.5
FAIL: man1/manpath.1
FAIL: man8/mandb.8
FAIL: man1/man.1
==========================================
   man-db 2.11.2: man/it/test-suite.log
==========================================

# TOTAL: 9
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  9
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: man1/apropos.1
====================

man -E UTF-8 -l ./man1/apropos.1 produced error output:
grotty:<standard input>:(<standard input>):9: warning: unrecognized X command 'sgr 0' ignored
FAIL man1/apropos.1 (exit status: 1)

Do you see it by chance? Or should I retest on clean staging? (I have a few local patches)

Thanks for trying out this PR, @trofi. At first glance the failed tests might be related to bug #61561: [grotty] remove 'sgr' device control command. Does this seem plausible to you?
If you have extra CPU cycles to spare resting on a clean staging would help validate whether it is a man-db using groff 1.23.0 issue or something else.

Tested on clean staging at 87956dffc783d305522cb1819913aeb5697329fe:

without this PR man-db builds fine
with this PR it fails the same tests as in https://github.com/NixOS/nixpkgs/pull/241870#issuecomment-1624244815

Thank you for testing this PR in a clean staging, @trofi, and confirming that the man-db errors stem from the changes proposed here.
I raised this issue on the groff mailing list and the helpful folks noticed that NixOS disables groff colors by default by outputting sgr 0 in site.tmac. With groff 1.23 this is no longer possible.
From this I see several paths forward:

Avoid shutting off SGR by default. The version of less that ships with NixOS should support it. Yet this may have undesired effects for NixOS users as the current preference is no colors.
Maintain grotty's legacy output format without SGR and OSC emitted by ensuring that grotty is called with the -c, for example by setting MANROFFOPT to include -c.

Another recommendation from the groff mailing list was to ensure hyperlinks are enabled for terminals by having .nr U 1 in man.local.
(For details see this mail thread)
Before making more changes to this PR I'd like to be sure that the general direction is right for NixOS, i.e. enable SGR or maintain legacy output format (see above).

What are the implications of enabling SGR for the system and its users?

Good find! Looks like it was set up in 111b5eb6377839b9518ea40fba6a71f121574ea1 groff: Add site.tmac to fix man page coloring 6 years ago. Don't know if it applies any more (or ever applied) to nixpkgs.

FWIW, I'd go with upstream recommendation unless there's a good reason not to.
I'm still building this on x86_64-darwin, it's a huge rebuild.

Does it make man-db build for you? Mine still fails with this branch applied on to of today's clean staging:
FAIL: man1/manpath.1
====================

man -E UTF-8 -l ./man1/manpath.1 produced error output:
troff:<standard input>:125: warning [p 2, 0.3i]: cannot break line
troff:<standard input>:125: warning [p 2, 0.5i]: cannot break line
troff:<standard input>:125: warning [p 2, 0.7i]: cannot break line
troff:<standard input>:125: warning [p 2, 0.8i]: cannot break line
troff:<standard input>:125: warning [p 2, 1.0i]: cannot break line
troff:<standard input>:125: warning [p 2, 1.2i]: cannot break line
troff:<standard input>:125: warning [p 2, 1.3i]: cannot break line
troff:<standard input>:125: warning [p 2, 1.5i]: cannot break line
troff:<standard input>:125: warning [p 2, 1.7i]: cannot break line
FAIL man1/manpath.1 (exit status: 1)

☝ The changes in this PR now have the sgr 0 related groff requests removed from site.tmac.
@trofi can you build another system to verify that said removal fixes the man-db issues you reported earlier?
ℹ This mail thread from the groff mailing list goes a bit into the history of where changes to site.tmac (may) have originated from. I found it an entertaining and interesting read.
Glad to you share my view on the upstream recommendation, @toonn.
❓ What other Nix folks or channels should be made aware of this proposed change, so people can chime in with their expertise?
❓ Are the changes in site.tmac worthy of a mention in the release notes?
Additionally I'd like to introduce a useA4Paper option (open to naming suggestions) to the groff package, which effectively passes PAGE=A4 in the configureFlags when enabled to make the default groff papersize for typesetting output devices A4 instead of letter. I believe this will be helpful to 🇪🇺 folks, like me, who prefer A4 over letter.
❓ Would Nixpkgs maintainers prefer this to be a separate commit or PR or would it be acceptable to include this addition in this PR?

Still fails like in the comment from 30 minutes ago: https://github.com/NixOS/nixpkgs/pull/241870#issuecomment-1627633412

Thanks for the update @trofi! Seems like GitHub did not show me your recent comment until after I posted mine. Let me look into this.

It works on my machine on staging-next, though.

Would it have to change configureFlags? Won't that cause a rebuild of groff and therefore almost anything with man pages? It seems like groff should be respecting locale settings.

I'm giving up on building this. I've been trying for over three days now, running builds at least overnight and I'm just not getting anywhere. If trofi's issues are resolved I'm OK with merging this, we'll have to catch and fix issues on staging-next.

I’m running nix build 'github:NixOS/nixpkgs?ref=pull/241870/head#groff'. I’ll post an update once it finishes.

$ nix build 'github:NixOS/nixpkgs?ref=pull/241870/head#groff'
$ ./result/bin/groff --version
GNU groff version 1.23.0
Copyright (C) 2022 Free Software Foundation, Inc.
GNU groff comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of groff and its subprograms
under the terms of the GNU General Public License.
For more information about these matters, see the file
named COPYING.

called subprograms:

GNU troff (groff) version 1.23.0
GNU grops (groff) version 1.23.0

Can you reproduce trofi's failure for man-db on either architecture?

Can you reproduce trofi's failure for man-db on either architecture?

It builds for me on aarch64-darwin.
$ nix build 'github:NixOS/nixpkgs?ref=pull/241870/head#man-db'
$ ./result/bin/mandb --help
Usage: mandb [OPTION...] [MANPATH]

  -c, --create               create dbs from scratch, rather than updating
  -C, --config-file=FILE     use this user configuration file
  -d, --debug                emit debugging messages
  -f, --filename=FILENAME    update just the entry for this filename
  -p, --no-purge             don't purge obsolete entries from the dbs
  -q, --quiet                work quietly, except for 'bogus' warning
  -s, --no-straycats         don't look for or add stray cats to the dbs
  -t, --test                 check manual pages for correctness
  -u, --user-db              produce user databases only
  -?, --help                 give this help list
      --usage                give a short usage message

Mandatory or optional arguments to long options are also mandatory or optional
for any corresponding short options.

Today's output for x86_64-linux:
$ nix build --no-link github:NixOS/nixpkgs/pull/241870/merge#man-db
error: builder for '/nix/store/dj07q7zzp3hcp2gbrggpbch0n9pz384n-man-db-2.11.2.drv' failed with exit code 2;
       last 10 log lines:
       > ============================================================================
       > make[4]: *** [Makefile:1977: test-suite.log] Error 1
       > make[4]: Leaving directory '/build/man-db-2.11.2/man/it'
       > make[3]: *** [Makefile:2085: check-TESTS] Error 2
       > make[3]: Leaving directory '/build/man-db-2.11.2/man/it'
       > make[2]: *** [Makefile:2216: check-am] Error 2
       > make[2]: Leaving directory '/build/man-db-2.11.2/man/it'
       > make[1]: *** [Makefile:2046: check-recursive] Error 1
       > make[1]: Leaving directory '/build/man-db-2.11.2/man'
       > make: *** [Makefile:1757: check-recursive] Error 1
       For full logs, run 'nix log /nix/store/dj07q7zzp3hcp2gbrggpbch0n9pz384n-man-db-2.11.2.drv'.

It builds if I build it interactively using nix develop 'github:NixOS/nixpkgs?ref=pull/241870/head#man-db'. 🤨

I can confirm that nix build 'github:NixOS/nixpkgs?ref=pull/241870/head#man-db' builds without any errors for me on aarch64-darwin.
@reckenrode can you share more details on the failure on x86_64 and aarch64 linux or is it exactly the cannot break line error as reported by trofi earlier?

@reckenrode can you share more details on the failure on x86_64 and aarch64 linux or is it exactly the cannot break line error as reported by trofi earlier?

It’s the same error.
==========================================
   man-db 2.11.2: man/it/test-suite.log
==========================================

# TOTAL: 9
# PASS:  8
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: man1/manpath.1
====================

man -E UTF-8 -l ./man1/manpath.1 produced error output:
troff:<standard input>:125: warning [p 2, 0.3i]: cannot break line
troff:<standard input>:125: warning [p 2, 0.5i]: cannot break line
troff:<standard input>:125: warning [p 2, 0.7i]: cannot break line
troff:<standard input>:125: warning [p 2, 0.8i]: cannot break line
troff:<standard input>:125: warning [p 2, 1.0i]: cannot break line
troff:<standard input>:125: warning [p 2, 1.2i]: cannot break line
troff:<standard input>:125: warning [p 2, 1.3i]: cannot break line
troff:<standard input>:125: warning [p 2, 1.5i]: cannot break line
troff:<standard input>:125: warning [p 2, 1.7i]: cannot break line
FAIL man1/manpath.1 (exit status: 1)

============================================================================
Testsuite summary for man-db 2.11.2
============================================================================
# TOTAL: 9
# PASS:  8
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See man/it/test-suite.log
Please report to<EMAIL_ADDRESS>============================================================================

Thanks for the helpful comment and question, @toonn, much appreciated! It made me rethink about my idea. To answer your questions:

Would it have to change configureFlags?

There might be other ways, but it's the "easiest" I've found so far.

Won't that cause a rebuild of groff and therefore almost anything with man pages?

I'm afraid yes, so that approach is very likely highly undesirable.

It seems like groff should be respecting locale settings.

There is a whole email thread over on the groff mailing list that does into the detail about selecting the papersize (on the fly), which helped me understand a bit of the history of why things are the way they are.
I'm uncertain whether the locale is a good reference to derive the preferred papersize from. Linux systems seem to offer /etc/papersize (and groff does query it in its configure script), yet Darwin and OpenBSD (my two main systems) do not have it. Le sigh.
I'll keep digging for another way to customize the groff default paper format from within the nixpkgs package.

This would explain why man-db builds on Darwin. It doesn’t do any checks.
https://github.com/NixOS/nixpkgs/blob/83cbd8d70b687db852218a4ff1d727e3c9cbabd5/pkgs/tools/misc/man-db/default.nix#L82C3-L82C93

Great find @reckenrode, I went ahead and locally removed the !stdenv.isDarwin on doCheck as to see what issues arise. At first glance the line-breaking warnings seem to not appear, yet several test failures around recoding UTF-8 from/to ISO-8859-1.
Darwin man-db test failures
  =============================================
     man-db 2.11.2: src/tests/test-suite.log
  =============================================

  # TOTAL: 31
  # PASS:  25
  # SKIP:  0
  # XFAIL: 0
  # FAIL:  6
  # XPASS: 0
  # ERROR: 0

  .. contents:: :depth: 2

  FAIL: man-recode-in-place
  =========================

    PASS: --in-place with no coding tag
    PASS: --in-place with gzip and coding tag matching target encoding
  --- /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.dG45SzWeIk/c.1.exp   2023-07-10 22:23:56.935370087 +0000
  +++ /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.dG45SzWeIk/c.1       2023-07-10 22:23:58.098508039 +0000
  @@ -1,3 +1,3 @@
  -'\" -*- coding: UTF-8
  +'\" -*- coding: ISO-8859-1
   .SH NAME
  -b \- é
  +b \- <E9>
    FAIL: --in-place with gzip and coding tag not matching target encoding
    PASS: --in-place removes compressed input files
  FAIL man-recode-in-place (exit status: 1)

  FAIL: man-recode-suffix
  =======================

    PASS: --suffix with no coding tag
    PASS: --suffix with gzip and coding tag matching target encoding
  --- /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.KZ9hPSpTxQ/c.1.exp   2023-07-10 22:23:56.935370170 +0000
  +++ /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.KZ9hPSpTxQ/c.1.out   2023-07-10 22:23:58.098563582 +0000
  @@ -1,3 +1,3 @@
  -'\" -*- coding: UTF-8
  +'\" -*- coding: ISO-8859-1
   .SH NAME
  -b \- é
  +b \- <E9>
    FAIL: --suffix with gzip and coding tag not matching target encoding
  FAIL man-recode-suffix (exit status: 1)

  FAIL: manconv-coding-tags
  =========================

  --- /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.Dbab2RlUzJ/1.exp     2023-07-10 22:23:57.362385092 +0000
  +++ /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.Dbab2RlUzJ/1.out     2023-07-10 22:23:58.280514136 +0000
  @@ -1,2 +1,2 @@
  -'\" -*- coding: UTF-8
  -á
  +'\" -*- coding: ISO-8859-1
  +<E1>
    FAIL: simple coding tag
  --- /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.Dbab2RlUzJ/2.exp     2023-07-10 22:23:58.298024486 +0000
  +++ /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.Dbab2RlUzJ/2.out     2023-07-10 22:23:58.421205658 +0000
  @@ -1,2 +1,2 @@
  -'\" -*- mode: troff; coding: UTF-8 -*-
  -á
  +'\" -*- mode: troff; coding: ISO-8859-1 -*-
  +<E1>
    FAIL: mode and coding tags
  --- /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.Dbab2RlUzJ/3.exp     2023-07-10 22:23:58.438768676 +0000
  +++ /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.Dbab2RlUzJ/3.out     2023-07-10 22:23:58.546394855 +0000
  @@ -1,2 +1,2 @@
  -'\" -*- mode: troff; coding: UTF-8 -*-
  -á
  +'\" -*- mode: troff; coding: ISO-LATIN-1 -*-
  +<E1>
    FAIL: iso-latin-1 coding alias
    PASS: preprocessor comment but no coding tag
    PASS: coding tag matches target encoding
  FAIL manconv-coding-tags (exit status: 1)

  FAIL: manconv-guess-from-encoding
  =================================

  --- /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.vEfMCT9yR3/coding-tag.7.exp  2023-07-10 22:23:57.408382226 +0000
  +++ /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.vEfMCT9yR3/coding-tag.7.out  2023-07-10 22:23:58.280520011 +0000
  @@ -1,5 +1,5 @@
   .TH coding-tag 7
   .SH NAME
  -coding-tag \- é
  +coding-tag \- <E9>
   .SH DESCRIPTION
   test
    FAIL: recode from encoding guessed from directory name
  ./manconv-guess-from-encoding: line 31: zcat: command not found
  --- /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.vEfMCT9yR3/lang-dir.7.exp    2023-07-10 22:23:58.372104567 +0000
  +++ /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.vEfMCT9yR3/lang-dir.7.out    2023-07-10 22:23:58.500125092 +0000
  @@ -1 +1,6 @@
  -'\" -*- coding: UTF-8 -*-
  +'\" -*- coding: ISO-8859-1 -*-
  +.TH lang-dir 7
  +.SH NAME
  +lang-dir \- <E9>
  +.SH DESCRIPTION
  +test
    FAIL: recode from encoding guessed from directory name
  FAIL manconv-guess-from-encoding (exit status: 1)

  FAIL: manconv-incomplete-char-at-eof
  ====================================

    FAIL: incomplete character at EOF
  FAIL manconv-incomplete-char-at-eof (exit status: 1)

  FAIL: manconv-odd-combinations
  ==============================

  --- /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.ABhG8ulUCp/1.exp     2023-07-10 22:23:57.460950112 +0000
  +++ /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.ABhG8ulUCp/1.out     2023-07-10 22:23:58.281112227 +0000
  @@ -1 +1 @@
  - ¡¢£¤¥¦§¨©ª«¬®¯°±²³´µ¶·¸¹º»¼½¾¿ÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖ×ØÙÚÛÜÝÞßàáâãäåæçèéêëìíîïðñòóôõö÷øùúûüýþÿ
  +<A0><A1><A2><A3><A4><A5><A6><A7><A8><A9><AA><AB><AC><AD><AE><AF><B0><B1><B2><B3><B4><B5><B6><B7><B8><B9><BA><BB><BC><BD><BE><BF><C0><C1><C2><C3><C4><C5><C6><C7><C8><C9><CA><CB><CC><CD><CE><CF><D0><D1><D2><D3><D4><D5><D6><D7><D8><D9><DA><DB><DC>
<DE><DF><E0><E1><E2><E3><E  <E4><E5><E6><E7><E8><E9><EA><EB><EC><ED><EE><EF><F0><F1><F2><F3><F4><F5><F6><F7><F8><F9><FA><FB><FC><FD><FE><FF>
    FAIL: -f UTF-8:ISO-8859-1 -t UTF-8 on ISO-8859-1 input
  --- /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.ABhG8ulUCp/1-latin2.exp      2023-07-10 22:23:58.302727214 +0000
  +++ /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.ABhG8ulUCp/1-latin2.out      2023-07-10 22:23:58.399791340 +0000
  @@ -1 +1 @@
  - Ą˘Ł¤ĽŚ§¨ŠŞŤŹŽŻ°ą˛ł´ľśˇ¸šşťź˝žżŔÁÂĂÄĹĆÇČÉĘËĚÍÎĎĐŃŇÓÔŐÖ×ŘŮÚŰÜÝŢßŕáâăäĺćçčéęëěíîďđńňóôőö÷řůúűüýţ˙
  +<A0><A1><A2><A3><A4><A5><A6><A7><A8><A9><AA><AB><AC><AD><AE><AF><B0><B1><B2><B3><B4><B5><B6><B7><B8><B9><BA><BB><BC><BD><BE><BF><C0><C1><C2><C3><C4><C5><C6><C7><C8><C9><CA><CB><CC><CD><CE><CF><D0><D1><D2><D3><D4><D5><D6><D7><D8><D9><DA><DB><DC>
<DE><DF><E0><E1><E2><E3><E  <E4><E5><E6><E7><E8><E9><EA><EB><EC><ED><EE><EF><F0><F1><F2><F3><F4><F5><F6><F7><F8><F9><FA><FB><FC><FD><FE><FF>
    FAIL: -f UTF-8:ISO-8859-2 -t UTF-8 on ISO-8859-2 input
  --- /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.ABhG8ulUCp/2.exp     2023-07-10 22:23:58.420780611 +0000
  +++ /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.ABhG8ulUCp/2.out     2023-07-10 22:23:58.517127936 +0000
  @@ -1,2 +1,2 @@
  -Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б  ─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░  Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─  ░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б  ─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░  Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─  ░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б  ─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░  Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─  ░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б  ─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б─░Б
  -Б─░
  +‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐  ‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐  ‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐  ‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐‐<E2>
  +‐
    FAIL: -f UTF-8:KOI8-R -t UTF-8 on KOI8-R input with UTF-8 prefix
    PASS: -f UTF-8:ISO-8859-1 -t UTF-8 preserves UTF-8 input
  --- /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.ABhG8ulUCp/4.exp     2023-07-10 22:23:58.682304732 +0000
  +++ /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.ABhG8ulUCp/4.out     2023-07-10 22:23:58.778913519 +0000
  @@ -1 +1 @@
  -<B9><B3>
  +š·ł
    FAIL: recognises input encoding and omits invalid output character
  --- /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.ABhG8ulUCp/5.exp     2023-07-10 22:23:58.804019343 +0000
  +++ /private/tmp/nix-build-man-db-2.11.2.drv-0/tmp.ABhG8ulUCp/5.out     2023-07-10 22:23:58.889803824 +0000
  @@ -1,3 +1,3 @@
  -'\" -*- coding: UTF-8
  -REGISTERED SIGN:
  +'\" -*- coding: ISO-8859-7
  +REGISTERED SIGN: <AE>
   trailing data
    FAIL: copes with invalid input characters
  FAIL manconv-odd-combinations (exit status: 1)

macOS sets LC_PAPER AFAIK that's what paper sizes are supposed to be derived from.

@toonn, unfortunately that does not seem to be the case for me. Checking locale(1) on macOS 13.4.1 does not mention LC_PAPER and searching the Internet for it reveals that it seems to be a glibc extension as stated in locale(5) on Linux:
In addition, since glibc 2.2, the GNU C library supports the
following nonstandard categories:

       •  LC_ADDRESS
       •  LC_IDENTIFICATION
       •  LC_MEASUREMENT
       •  LC_NAME
       •  LC_PAPER
       •  LC_TELEPHONE

Do you have any reference about LC_PAPER reference being available on macOS by any chance?

Kindly re-requesting re-review now that upstream has provided patches for the test failures (for details see gitlab:man-db/man-db#25 and gitlab:man-db/man-db#25) and newly enabled man-db tests on Darwin are passing locally for me.

☝ /cc @trofi, @wegank, @toonn, @reckenrode

@ofborg eval

I've been building this for the last two days again. No eval errors yet but only halfway there. I'm not sure why but many Python packages seem to be taking ages to build.

I was able to build groff on both x86_64-darwin and aarch64-darwin. I didn’t run nixpkgs-review due to the (presumably) large number of rebuilds.

That's good news, thanks @reckenrode. Do you know if any actions need to be taken for this PR in order to address the ofborg-eval check and if yes which actions?

AFAICT that's unrelated. My build still hasn't finished but I'll trust reckenrode's.

I was going to say. 😅
I think the go-modules stuff is fallout from #242905.

Thanks everyone for your help on this, I'm very excited for this to have been merged! 😃👍


python3Packages.mopidy-youtube: 3.4 -> 3.5

Unfortunately the test suite fails on the 3.5 revision source, so although I've kept the imports check, I've removed the rest of the tests as they simply fail on 3.5 otherwise.
Motivation for this change

3.5 is out
CI is broken on revisions like 3.5, unfortunately (hence the "disabled tests" comment in the commit body)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable: Removed python tests but retained import test

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 159320 run on x86_64-linux 1

1 package built:

mopidy-youtube

Apologies for the radio silence but greatly appreciate the assistance @fabaff :pray:


Use more words for Hebrew

There are a lot of words missing from the Hebrew dictionary you use. Could you please include words from this repo?
https://github.com/eyaler/hebrew_wordlists
thanks in advance :)

The current dictionary is copied from that repo. Another user helped doing that. However, I can see there are more than 30 files there and maybe there is more complete one, I suppose? I can't read Hebrew, so I will need hand to pick the right one.

The entire purpose of that repo is to have a big collection because finding a good one is luck luster.
I've searched around for a better one but couldn't find any that have all of the words. The thing about Hebrew is that phrases like and or in are added to the beginning of the word, so it's important to load all of the words in that repo since it contains all of those combinations. Personally when using tt9 I've notices all of the gerunds are missing from the dictionary. Could you make sure all of the files from the repo are loaded? I know it's a lot of files but all of them are necessary.

I've tried merging all files, except the "CC" ones, then cleaned up the repeating words. This resulted in a 95 Mb file, containing 5568356 words. This is way too much. I can't include such a dictionary, sorry.
TT9 can run almost smoothly with up to 1.5 million words. I haven't tested with larger dictionaries, but I suppose, it will be fine with up to 2 million. Beyond that, it will simply overwhelm lower end devices, both in terms of storage space and CPU usage.
If you can come up with some criteria of reducing the word count or maybe using only some of the lists from that repo, I will include the new words. From my experience with Slavic languages, where words have a lot of different suffixes, 1 to 1.5 million words result in very nice typing experience. I believe this is what we should be aiming for. Unfortunately, as I previously said, I can't even read Hebrew, so I can't make the right choice. I can't make any choice.
I am attaching the merged file for reference.
hebrew.merged.zip

@AshiVered אפשר לעזור?

I also used a file that someone else had already created.
@Udif
https://github.com/udif/traditionalt9

... and udif has taken it from the eyealer repo, as per the readme. We've come a full circle. :laughing:
Just to clarify, the problem is with the "all_*_prefixes" files. They are the ones that need filtering. If any of you guys knows of a large Hebrew word frequency list, I can use it to remove the unpopular words and keep the 1 million most popular ones. After that I'll just merge in the personal names, the gerunds, the nouns, the adjectives and whatnot. Most of these smaller files are within the 100k range and it shouldn't be a big deal to keep them all.

frankly, my latest effort were more in my qinpad repo (renamed qinhpad). The crucial piece I was still missing was being able to call the google voice input from within my IME, but that proved a bit more complex than I thought, and I haven't revisited this recently.

No big deal. I just need confirmation that the "cc100.csv" file is ordered by frequency and I can do everything by myself.
@udif, out of curiosity, have you tried TT9 on the Qin 1s? These phones are anything but standard, so I am wondering if it would even install and start up properly. If it does, you may finally get the chance of using voice input.

I try it on Qin1s+.
it's work, but It was too cumbersome for me with too many functions...
So I use my Qinboard T9.
But to each his own preferences :)

@udif, out of curiosity, have you tried TT9 on the Qin 1s? These phones are anything but standard, so I am wondering if it would even install and start up properly. If it does, you may finally get the chance of using voice input.

I have an F21 pro, not a Qin 1s.

Still waiting for someone to check the cc100.csv file...

I try it on Qin1s+.
it's work, but It was too cumbersome for me with too many functions...
So I use my Qinboard T9.
But to each his own preferences :)

Yeah, I agree there are too many functions now. I even think I should stop adding new ones. For this reason, in the newer versions, I tried to make TT9 configure itself automatically, depending on the Android version and the available hardware. Hopefully, new users can just install and use, without playing with the options, if they don't want to.

I have an F21 pro, not a Qin 1s.

I see. As far as I know, on that phone, voice input is possible only with Google services.

I see. As far as I know, on that phone, voice input is possible only with Google services.

That is known 😄

Good news, folks, I think I've figured it out myself! I have included many new words with prefixes, personal and location names and bible words. I am not sure what the last one means, it is just how the file is named. The dictionary now consists of 1.5 million words. I believe this enough to cover most everyday conversations and even some specialized ones.
As for the gerunds, I've double checked and it looks like all of them were previously available in TT9. Or at least, all the gerunds from eyealer's repo. If it feels many of them are still missing, I don't think I can do much more, unless someone suggests another good word source.
All in all, I will include the new words in the upcoming v39.0. I hope you will enjoy typing even more.


pitch angle problem under steady wind

Dear Jonkman:
I meet a similar question like #2461. My model is 5MW onshore wind turbine. The Openfast version is v3.5.4. CompElast=1. I use steady wind, set WindType=1 and HWindSpeed=11.4 (rated wind speed). In INITIAL CONDITIONS, I set RotSpeed=12.1(rated rotation speed), and others remain 0. No other parameters in model are modified.
Then I output some parameters as below.
I do not know why the pitch angle is about 6°？

I also change the HWindSpeed. When HWindSpeed=9, pitch angle and rotor speed curve are like Sin function. But when HWindSpeed=8, pitch angle curve becomes normal.
The results are similar with or without BeamDyn. Please tell me what makes this result happen. If it is the initial condition problem, how to modify the parameters? Thanks.

Dear @Wangzhenyu12,
The pitch angle increases sizeably for wind speeds just above rated.  A pitch angle of 6deg for the NREL 5-MW baseline wind turbine means that the wind speed is slightly above rated.  Given that the rated speed of this turbine is documented to be 11.4 m/s, can you clarify how you set-up your OpenFAST model?  E.g., other than WindType and the wind speed in InflowWind and initial conditions in ElastoDyn, what have you changed relative to the example model provided in the r-test: https://github.com/OpenFAST/r-test/tree/main/glue-codes/openfast/5MW_Land_DLL_WTurb?
As has been discussed in many other topics on this forum, when using active control, it is important to initialize the RotSpeed and BlPitch properly based on their expected (mean) values conditioned on the mean hub-height wind speed you are simulating, otherwise, OpenFAST may respond erratically or take a while to converge.  For the NREL 5-MW baseline wind turbine, the initial conditions are documented in Figure 9-1 of its specifications report: https://www.nrel.gov/docs/fy09osti/38060.pdf.  At 9 m/s, I'd expect that you'd use RotSpeed = 10.3 rpm and BlPitch = 0deg; at 8 m/s, you should use RotSpeed = 9.2 rpm and BlPitch = 0deg.
Best regards,

Dear jjonkman,
Thanks for your quick reply. I check my model input files and find an error modification in Aerodyn15.dat which results in this phenomenon. After correction, the pitch angle remains 0° when HWindSpeed is less than 11.4m/s.
Best regards,


Clean up error messages

The error messages produced by the application need to be reformatted. Currently they look similar to this example:
fatal error: Fatal Error (arguments mismatch): two input image paths, one output image path, c to specify CPU based or m to specify Metal based: file main.swift, line 19 [1]    10178 illegal hardware instruction  ./ImageDiff
This is convoluted and can be simplified.

Added in commit 2a2f7b278f5826fcfbcaf6224725997bdb96a380


dragenter needs to be preventDefault'd too

The default action of dragenter is to "Reject immediate user selection as
potential target element". Internet Explorer follows this, and therefore
stops the drag and drop from working as intended.
See http://www.w3.org/html/wg/drafts/html/master/editing.html#dndevents
and
http://www.quirksmode.org/blog/archives/2009/09/the_html5_drag.html

Looks nice -- merging with gratitude ;)


Add PrintInfo options to dump full keys, apply formatter

@drewfarris Do these changes work on the current development branch? (master) Specifically, I'm concerned that Formatter is not public API, and adding it here could cause problems between branches.

Would Keith's suggestion of BiFunction<Key, Value, String> address this concern? It eliminates the reliance on the Formatter API entirely.

Also, new features typically shouldn't be added to maintenance branches. [..] . I could be convinced that these are important enough changes that we definitely need them in 1.10... but normally, I'd argue for changes like these to be put in the next version.

I agree with the principle of adding this to the newest branch. We really shouldn't be adding features to a 'legacy' baseline. I don't have a compelling argument for putting in in 1.10 other than it is the version we're using in our development and production environments currently and I have a practical need for this feature in that environment. I'd prefer not to maintain a patch/fork for this somewhat trivial feature that most folks won't observe.
I agree with your point about the fact that this should be targeted at all branches 1.10, 2.0, 2.1 - and I intend to do that based on your feedback. Unfortunately there's just not a nice way to do that without opening multiple PR's which I'd like to avoid until we all have notional agreement that this is a good thing to do (in order to maintain a single conversation thread.)

@ctubbsii - retargeted at master.

Unfortunately there's just not a nice way to do that without opening multiple PR's which I'd like to avoid until we all have notional agreement that this is a good thing to do (in order to maintain a single conversation thread.)

While I think new feature development in upstream Accumulo should focus on targeting the master branch, I understand the practical desire to have such features in currently used versions. Once we reach consensus on how this should look in master, I wouldn't be strongly opposed to backporting these flags to 1.10, if the change is small and can be done with minimal impact. I just think it's best to vet new features in master first, since that's where main development is happening.

Would be nice to fail with an error message if --fullKeys and --formatter are specified.

done. The wording is a little weird because both --fullKeys and --dump are mutually exclusive with --formater, but hopefully you'll agree this is sufficient as it.

If you assign the unchecked code to a variable, you can add this suppression on just that assignment, so it doesn't mask other (fixable, avoidable) problems in the method.

done. I'd wanted to do this, but hadn't figured out the variable assignment bit, thanks.

we should probably hard-fail by letting this exception fall through, rather than returning null and by effetively wasting time dumping a file in a format the user doesn't want.

done, also removed the null check as it was unnecessary.


Van Routes

Probably there is a better way to do the join like commands required for the include parameter for analytics.

Honestly, I'm not a fan of having the ridership data as an include parameter. I feel like it would be better as part of some kind of GET /stats/ridership route. This would allow more advanced filtering (by route, by van, by stop?) and also more advanced calculations.

I think it is fine to keep the ridership data here as an optional param, but we definitely need the full ridership route to populate the admin panel

@OxygenCobalt Yep, those routes are needed, but this should technically be available for include. If we change our minds later, we can remove then


Group chat names not appearing all the time

Maybe fixed?

I haven't experienced this ever, and I don’t think anyone has reported it. Hopefully our contact widget fixes change this. Closing for now


[Feature Request]: Integration with Community Toolkits

Summary
It would be great to see some of the features like Jobs, Startup Tasks, Download Manager, etc. integrated into the MVVM and MAUI community toolkits. Since these toolkits already have RelayCommand and other extensions, using both causes some duplication of features.
API Changes
I'm not sure which APIs would change, but they'd likely include Reactive vs RelayCommand, built-in DI container, integration with Messenger, and a few others.
Intended Use Case
Use some of the great features of Shiny alongside the Microsoft Community Toolkits.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

The community toolkits and Shiny are two different things.  Shiny does have DI and v3 prerelease directly integrates with MAUI, but Shiny itself doesn't really touch front end code other than permission requests.  Shiny doesn't have any MVVM or reactive/Icommand implementations, so I'm not really sure what it is that you're looking for here.

Thanks. I'll explore further. It didn't look like I could pull specific capabilities from Shiny without bringing the whole framework. I wanted to be able to add Jobs, Startup Tasks, and Download management to an existing application with minimal changes. We can close this while I investigate my options.

Shiny.Framework is nothing more than additional tools to work with Shiny, Prism, & ReactiveUI.  It is not a requirement for Shiny to be used at all, nor is it required to work with any of the other 3rd party packages I mentioned.


Prevent string unpack by default

Issue Description
A while back I added an env variable ND4J_PREVENT_UNPACK that prevents printing of arrays. This was important since some software - such as Zeppelin or IntelliJ debugger - has a tendency to call .toString on every object in scope.
https://github.com/deeplearning4j/nd4j/blob/master/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/factory/Nd4j.java#L154
I've found myself disabling this more often than not. I think this should be the default behavior. Instead, we should use the env ND4J_PRINT_ARRAYS to allow printing of entire arrays when present. And if a user would want to grab a "glimpse" of an array, we add the signature toString(int maxChars).
Version Information
Please indicate relevant versions, including, if relevant:

Master

Contributing
Yup, easy for me to code if we're happy with this.

No. Just No.
I believe disabling toString() is a terrible idea. We should do something else, like limit number of elements being printed out. I.e. 3-5 per dimension. Something like that. But bing disabled by default - just isn't a good way to solve this problem.

I see your point. You think 3-5 per dimension is a reasonable number?

numpy does something like that for long arrays, so why not?

/cc @agibsonccc  @AlexDBlack  @turambar  @wmeddie

as reference: another/additional option: silently prohibit toString() method, while MLN/CG fit() is running.

Yeah, disabled by default is a terrible idea. I'd be fine with truncation, as long as:
(a) it's obvious to users that it's truncated, and
(b) we have some over overloads to print the full array... maybe toString(boolean allowTruncate) and toString(boolean allowTruncate, boolean fullPrecision) where toString() == toString(true, false)
As far as how much to display/truncate: I'd be tempted to do the same amount as numpy.

BTW, numpy has modes for that, but it's really user-unfriendly, for example:
https://stackoverflow.com/questions/21008858/formatting-floats-in-a-numpy-array

Where we ended up on this issue?

Yeah, this can be closed.


scipy missing from linux installer

The scipy module is missing from the linux installer.
To reproduce:

Run vapor installed with the linux installer
Load any data set (e.g. Duku) and launch the python calculation engine
Create a simply python script that contains the line "import scipy" and hit test. The script will fail because scipy cannot be found.

Describe the bug
(Please click check boxes AFTER submitting ticket)

[ ] Did VAPOR crash?
[x] Did you get wrong results?

Impact

[ ] High - User productivity significantly degraded
[x] Medium - User productivity partially degraded
[ ] Low - User productivity trivially degraded

Desktop
Linux
Additional context

This does not occur on the 3rdPartyLibs branch, which is pending review.

Let’s close it then and we’ll be sure to do our validation testing with the new libraries.
cheers - jc

On Nov 21, 2019, at 12:32 PM, sgpearse<EMAIL_ADDRESS>wrote:
This does not occur on the 3rdPartyLibs branch, which is pending review.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

John Clyne
National Center for Atmospheric Research
303.497.1236 (w),<PHONE_NUMBER> (c)
<EMAIL_ADDRESS>

This error occuring to me as well. For example, I want to smooth the variable with scipy.ndimage module gaussian_filter, which is not loading properly. I spent lot time how to do it, but arrives to this discussion. All vapor_utils use numpy but no scipy packages. Hopefully someone suggest the solution.

@vema1818 Could you provide the script you're trying to execute?  I'm guessing you're on Ubuntu20/22 but that's a guess.  I'm able to import scipy on MacOS/arm64 with the script below:

Thanks Pearse. This problem occurs only in VAPOR3.9 not in 3.8 and 3.4 as I checked. The script I use is
import numpy as np
import os
from scipy.ndimage import gaussian_filter
dx=0.1456
fourpi=12.57
bh = np.sqrt(bx2+by2)
jx = (np.gradient(bz,dx, axis=1) - np.gradient(by,dx, axis=2) )/fourpi
jy = (np.gradient(bx,dx, axis=2) - np.gradient(bz,dx, axis=0) )/fourpi
jz = (np.gradient(by,dx, axis=0) - np.gradient(bx,dx, axis=1) )/fourpi
jtot = np.sqrt(jx2+jy2+jz**2)
jtot1 = gaussian_filter(jtot,sigma=1)
I think, 3.9 version has some issues as I found. So, I am using 3.8.1 version as of now.

This is broken on the AppImage installer on Casper


Clean up room selection event listeners to fix joining new foom

Fixing https://github.com/webrtc/apprtc/issues/143

LGTM. Travis seems to be broken though.


Tooltip Help Component: add new text like button help opener

Story: https://rally1.rallydev.com/#/15545167705d/dashboard?detail=%2Fuserstory%2F637815615647
Design Spec: https://www.figma.com/proto/A8jk5soJf1bz5z560Uld32/Help-Tooltips?page-id=0%3A1&node-id=2%3A98&viewport=469%2C216%2C0.32&scaling=min-zoom&starting-point-node-id=2%3A98
This PR introduces a new reusable d2l-tooltip-help component that renders as a "button" linked to a tooltip, but looks like text with a formatted underline.
Note that styling details (specific values of properties) may change and may be updated in a future PR.
Note that the Visibility Switch component depends on this component.

Not sure if we should merge this directly into main, or just to feat/visibility-switch/indication-of-availability-conditions.
Technically the changes here are standalone, and if merged into main, we could just merge it back into the visibility switch feature branch.
But, at the same time, the styling details aren't final and we're planning to finalize them with Jeff in a live pairing session next week.

For reference, this is more or less how the Daylight page for the tooltip should look like with the changes to the tooltip component README (well, before any additional changes from reviewing this PR are made).
The Best Practices here were based on what Jeff wrote in the Design Spec


Code reviw of Kvasir::Io needed

Io actually needs refactoring, the problem is that since Io and Register are isolated and do not know anything about each other mixing pins and bits in a variadic set or clear call does not work.


missing action microsoft.aad.directory/appRoleAssignments/delete on Cloud Application Administrator

AFAIK action microsoft.aad.directory/appRoleAssignments/delete should be possible for a CAA, but it is missing on the list https://docs.microsoft.com/en-us/azure/active-directory/users-groups-roles/directory-assign-admin-roles#cloud-application-administrator

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0767aac4-fcd9-eaac-2c30-8f17d8eadd92
Version Independent ID: a380a828-03f9-e037-3a62-e4165fda7cb6
Content: Administrator role descriptions and permissions - Azure Active Directory
Content Source: articles/active-directory/users-groups-roles/directory-assign-admin-roles.md
Service: active-directory
Sub-service: users-groups-roles
GitHub Login: @curtand
Microsoft Alias: curtand

@nicolgit
Thanks for your feedback! We will investigate and update as appropriate.

Hi @nicolgit ,
Looks like they took your feedback and updated the doc as it is listed there now.

We will now proceed to close this thread. If you have further questions feel free to tag me or @curtand in the comments and we will gladly continue the discussion.


Using this template locationTemplate

Your Environment

Plugin version: 1.9.1
Platform: iOS
OS version: 12.1.4
Device manufacturer / model: iPhone X
Nativescript version (tns info): 5.2.0
Plugin config

Expected Behavior
Using this template locationTemplate:
httpRootProperty: 'location',
locationTemplate: '[{"lat":<%= latitude %>,"lng":<%= longitude %>,"heading": <%= heading %>,"speed":<%= speed %> }]',
Actual Behavior
Results in this output {"location":[{"lng":-2.1281124147734172,"lat":52.000321439890222,"speed":-1,"heading":-1},{}]}
The ,{} is not required.
<%=timestamp%> crashes app with error BG Geo Template Error You have an error in your location template.
Steps to Reproduce
add "gpsstamp":<%=timestamp%> to locationTemplate
Context

Debug logs

are you watching the logs and using debug: true?  There's a JSON error being printed to the logs for you to look at.

timestamp is an ISO-8601 formatted String (eg: "2019-02-28T10:44:28.157Z").
You are telling the plugin to generate a json object like this:
{
  "timestamp": 2019-02-28T10:44:28.157Z
}

You are responsible for quoting the data
```json
{
  "timestamp": "2019-02-28T10:44:28.157Z"
}

It's like this:
{"locationTemplate":'{"timestamp":"<%=timestamp%>"}'

This is the JSON sent to my server now with all the variables. ,{} is appended to the end.
Template is
httpRootProperty: 'data',
locationTemplate: '[{"lat":<%= latitude %>,"lng":<%= longitude %>,"heading": <%= heading %>,"speed":<%= speed %>,"accuracy":<%= accuracy %>,"timestamp":"<%= timestamp %>","event":"<%= event %>","activity_type":"<%= activity.type %>","activity_confidence":<%= activity.confidence %>,"battery_level":<%= battery.level %>,"battery_charging":"<%= battery.is_charging %>" }]',
{"data":[{"battery_charging":"true","speed":-1,"battery_level":1,"accuracy":65,"event":"motionchange","activity_type":"unknown","activity_confidence":100,"lat":52.000290105969263,"timestamp":"2019-03-01T14:44:13.813Z","lng":-2.1282378635378132,"heading":-1},{}]}

Yes, [ ] templates are problematic.  The plugin doesn't know where to append the extras object so it pushes it onto the Array.  You'll have a much better time with { } templates and modifying your server to consume a different format.
else if ([location isKindOfClass:[NSArray class]]) {
            if (_type == TS_LOCATION_TYPE_GEOFENCE && _geofence[@"extras"]) {
                if (!_extras) {
                    _extras = [_geofence[@"extras"] mutableCopy];
                } else {
                    NSMutableDictionary *tmp = [_extras mutableCopy];
                    [tmp addEntriesFromDictionary:_geofence[@"extras"]];
                    _extras = [tmp copy];
                }
            }
            if (_extras) {
                DDLogWarn(@"Appending #extras to last index of [Array] in JSON template");
                [location addObject:_extras];  // <--------------- HERE IS YOUR EXTRA {}
            }
        }

You should be seeing this warned in the logs:
⚠ Appending #extras to last index of [Array] in JSON template


Invalid css output after running gulp sass

So I'm using scss files from ionic lib to compile them using gulp-sass task with my project files.
The result is that compiled output for ionicons is invalid.
.ion-android-bulb:before {
  content: ""; }

.ion-android-bus:before {
  content: ""; }

.ion-android-calendar:before {
  content: ""; }

.ion-android-call:before {
  content: ""; }

I've also pulled newest ionic source files from github and running npm install, installing global gulp and then running gulp sass tasks ends up the same (creating invalid css file in dist folder).
Node 5.3
Gulp-sass 2.0.4 (2.1.1 works the same)

Greetings @marekstabla!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!


Make one of the active development branches the default branch on GitHub

Currently, the GitHub default branch is master, where the last commit was in 2019. I initially took this as a sign that Gosu development had stopped and the project was abandoned.
I suspect that there might be a sizable number of developers much like me, who simply dismiss a project as abandoned if they see that the latest commit that shows up on the GitHub default branch was more than 3 years ago. To avoid turning away these developers, who might be potential users of and contributors to Gosu, it might be a good idea to make the default branch on GitHub for example the next upcoming release or the latest stable release. This way people coming to the GitHub page to check if the project is active see that Gosu it is in fact in active development and are not turned away by the mistaken perception that the project was abandoned in 2019.

Totally agree !

I thought the project was dead too until I followed a link from Wikipedia to the latest release. There are a few active branches. Which is the main development branch?


Think about a web frontend?

If anyone is still looking for a web dashboard for this type of data, take a look at Linux Dash.
@MrRio If you're going to do web sockets and a simple few lines of Node, it shouldn't be too hard to accomplish the same type of web front-end for vtop. Who knows, now that you have gotten the CLI version right, maybe you can do the web front-end better than what currently exists.
Love this project!


Celebi Template image adjustment

I wanted to create the resume in Celebi template but image is cropped from the head. Hence, either the option to adjust the picture should be given or simply auto-adjust it.

Closing this in favor of Reactive Resume v3 release.
If you continue to face this issue, please raise a new one and I'll have a look at it as soon as I can.
In the meantime, if you are able to, please consider donating to keep supporting the project: https://www.buymeacoffee.com/AmruthPillai :)
Thank you!


ZIP File bug

Hey all I'm running into an issue with zip folders.
When run locally without being in a zip folder, The JSON file that is being passed in the zip will pass as valid JSON. "Input JSON is valid."
cms-mrf-validator validate ValidINNFile.json --schema-version v1.0.0 -o inntest.txt -y
When passing the JSON file to the validator in a zip folder by using the from-url option the validator is failing and returning "Input is not a valid JSON Error(offset 0): Invalid value.".
cms-mrf-validator from-url "https://hcbbmrfprod.blob.core.windows.net/mrf/External/2023-11-16_Trustmark-Health-Benefits-541759962_in_network_rates.zip"  --schema-version v1.0.0  -o ziptest.txt -y
When run locally if you pass the valid JSON file in a zip folder to the validator it will fail and return "Input is not a valid JSON Error(offset 0): Invalid value.".
cms-mrf-validator validate ValidFileZipped.zip --schema-version v1.0.0 -o ziptest.txt -y
Thank you.
Context Update:
When downloading an MRF from a URL for the validator if the content type is application/octet-stream the file will run properly in the validator.
When downloading an MRF from a URL for the validator that has a content type of application/x-zip-compressed, the validator will return that the file is not valid JSON even if it is.

Hey team, Any updates on if this will be resolved?

Hi @jkHCBB
Thanks for the follow up details. We're taking a look at it - hope to having something soon for you.

Hey @jkHCBB -- I appreciate your patience. We just merged a PR: https://github.com/CMSgov/price-transparency-guide-validator/pull/113 that should hopefully address the behavior you were running into.
A new release has been cut to NPM so you can pull down the latest there.
Thank you again for the detailed information. Please keep them coming as you happen to encounter them :).

Thanks again for all you do!


Change options from camelcase to slashes.

As @sindresorhus suggested, do  you agree @flesch?

One thing in favor of camelCase is that it goes inline with the API, since its query string arguments are also camelCase as well as the response.

PR: #7

I like the change.

Or we could drop what's after the dash now. --popularity-weight could be just --popularity...

I would keep the *-weight since it matches the API. Actually changing to dashes will make it backwards compatible since --scoreEffect would still work (just tested it out).
Going to merge #7 if it's ok?

Sounds good! That's makes it easier that it's backwards compatible.

Done!


file download links broken

Hi Mathew,
Thanks for the great repo! I noticed the links to download the data are now broken because a 2017 release of the SEER data is available. I had to update script 002's download link to :
"https://seer.cancer.gov/popdata.thru.2016/yr1969_2016.19ages/us.1969_2016.19ages.adjusted.txt.gz"
and script 003's link to:
"https://seer.cancer.gov/popdata.thru.2016/yr1990_2016.19ages/us.1990_2016.19ages.adjusted.txt.gz" in order to get the download to work.
Emma

Yes, we are stuck there as well. Thanks for adding this all open source!


UI Localisation

S'sheet line: 29
For whom? BNF, NULI, BL, DN
Notes: There are holes, but framework ok. How to review? Consider switch to JSTL?
Est. Milestone: 2.0.x

While a switch to JSTL was suggested, I think, in order to close this, it would be sufficient to ensure that all text strings are read from a properties file and that any dates use a date format read also from the properties file.

I have gone through the JSP files in the project, and hope to have moved out most of the hard coded text strings. During testing I encountered a problem with national characters (ie. chars with ascii value > 127).  The properties class used for loading the WaybackUI_.properties uses by default ISO 8859-1 character set. Since the project uses UTF-8 by default, ascii values > 127 will be displayed incorrectly in the GUI. This can be fixed in a number of ways.

Use ISO 8859-1 for the WaybackUI_.properties: This might be cumbersome to maintain, as one will need to remember to save this single file in another character encoding than the rest of the project.
Use unicode escapes: From the JAVA API DOC "Unicode escapes as defined in section 3.3 of The Java™ Language Specification. " This will lead to poorly readable WaybackUI_.properties, and will make the process of creating new NLS stings more difficult.
Modify StringFormatter: I have made a modification in the getLocalized() method in StringFormatter using "new String(retVal.getBytes("ISO-8859-1"), "UTF-8")". This will make it possible to write the .properties files in UTF-8 and have the NLS characters display correctly in the GUI.

Looking for feedback on which method should be used.

I have made a WaybackUI_<nls>.properties with all UI strings replaced with "*" characters. This file is useful for testing to "smoke out" the strings that are still hard coded in the UI files. I could supply this file for testing by others, but I don't want to include it into the source code. Where would be the natural place to put it?

@RogerMathisen Load the properties files as UTF-8 files.
new String(retVal.getBytes("ISO-8859-1"), "UTF-8") seems hacky though. Could you point at the parts of the code where this is happening?

In the org.archive.wayback.util.StringFormatter
The original method:
public String getLocalized(String key) {
if (bundle != null) {
try {
return bundle.getString(key);
} catch (Exception e) {
}
}
return key;
}

I see. It's basically this issue: https://stackoverflow.com/questions/4659929/how-to-use-utf-8-in-resource-properties-with-resourcebundle
I'd rather do the Control subclass. Feels less brittle. Anyone else have thoughts? @PsypherPunk @anjackson

Yeah, but that's a little more work. If we go that route we might need to move this issue to 2.3.0?

Doesn't seem like that big a task to me. Sketched it out here: https://github.com/iipc/openwayback/compare/iipc:master...kris-sigur:PropUTF8?expand=1
Seems to work as intended.

I tested the code and it seems to work fine. The only thing is that most (if not all?) of the .JSP files use the deprecated WaybackRequest.getFormatter() instead of UIResults.getFormatter(), so we either need to: Add the same change to WaybackRequest as you did to UIResults or alter the JSP-files to use UIResults.
Option two is probably the best, but it takes a little time to do.

Yes, I know, I edited WaybackRequest as well.

Could you please a pull request for this so we get it into the 2.2.0 release?

@RogerMathisen Its best to include it with your changes. What I could do is make a pull request to the branch where you are working on the UI localizations. That would make it super easy for you to incorporate my changes. Just point me at your working branch.

I have your changes in my branch for testing purposes, but was reluctant to create a pull request with them included in fear it would mess things up. If you don't do anything I can just keep them all and create a pull request.

@RogerMathisen That's perfectly fine by me.

I've tried to use this, but it's not quite clear from the documentation how. What do I need to do besides providing WaybackUI_fi.properties file (for Finnish) and setting the browser's language preference accordingly? (Pardon my lack of java webapp-fu)

Just put your modified language file under WEB-INF/classes alongside the original WaybackUI.properties and you should be all set.

Just put your modified language file under WEB-INF/classes alongside the original WaybackUI.properties. Also you might have to look into the language settings your web server is running under.
I'm using Tomcat and Linux, and need to set the LANG environment variable. When I have both the original and the modified WaybackUI_nb_NO.properties the settings:
LANG=nb_NO.UTF-8 Gives the Norwegian translation.
LANG=en_US.UTF-8 Gives the text from the original WaybackUI.properties

If you want to run multiple access points with different languages, you can do this (which we do to support Welsh):
  <!-- Welsh front-end -->
 <bean name="wayback-cy" parent="wayback">
    <property name="accessPointPath" value="${wayback.port}:archive-cy"/>
  <property name="locale">
   <bean class="java.util.Locale">
    <!-- cy_GB -->
    <constructor-arg type="java.lang.String" value="cy" />
    <constructor-arg type="java.lang.String" value="GB" />
   </bean>
  </property>

    <property name="replayPrefix" value="${wayback.urlprefix}archive-cy/" />
    <property name="queryPrefix" value="${wayback.urlprefix}archive-cy/" />
    <property name="staticPrefix" value="${wayback.urlprefix}archive-cy/" />

  <property name="uriConverter">
   <bean class="org.archive.wayback.archivalurl.ArchivalUrlResultURIConverter">
      <property name="replayURIPrefix" value="${wayback.urlprefix}archive-cy/"/>
   </bean>
  </property>
 </bean>

You might also want to consider installing the ICU4J package into your JRE, if you need localisation support for dates in a language that is not supported by the base Java install (again, for us, this is Welsh).

http://userguide.icu-project.org/icu4j-locale-service-provider#TOC-Using-ICU4J-Locale-Service-Provider

Thanks. My issue is probably somewhere in my overlay build process as the correct resource file is not getting copied to the classpath, but I'll keep looking into it. I'm trying to put together a rather minimal overlay example, and localization is one of the things I'd like to include: https://github.com/NatLibFi/openwayback-overlay-example

I updated the Wiki with the basic set up.
https://github.com/iipc/openwayback/wiki/NLS-configuration
We should definitely consider adding the info Andy provided, as I think it might be very helpful for users wanting this kind of functionality.


Implement basic mesh simplification algorithm

Add raw implementation of mesh simplification
based on quadric error matrices.
This setup can process simple glTF files and generate an approximation
containing less than 200 triangles.
The approximations do not include texture information.

Awesome Job 👍
Love my simple and performant Ducky:


Fix updating realtime table config

Although the metadata was updated correctly, the PUT call returned an exception
because it found the kafka partition directory. We should not be checkig for the
kafka partition directory anymore

Codecov Report

Merging #2782 into master will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2782      +/-   ##
==========================================
- Coverage    69.2%   69.16%   -0.05%
==========================================
  Files         903      903
  Lines       43029    43024       -5
  Branches     5834     5832       -2
==========================================
- Hits        29779    29758      -21
- Misses      11286    11297      +11
- Partials     1964     1969       +5

Impacted Files
Coverage Δ

.../partition/StreamPartitionAssignmentGenerator.java
68% <ø> (+19.42%)
:arrow_up:

...edin/pinot/common/metadata/ZKMetadataProvider.java
74.34% <ø> (+0.65%)
:arrow_up:

...ntroller/helix/core/PinotHelixResourceManager.java
61.56% <66.66%> (+0.03%)
:arrow_up:

...a/manager/realtime/RealtimeSegmentDataManager.java
75% <0%> (-25%)
:arrow_down:

...e/operator/dociditerators/SortedDocIdIterator.java
45.94% <0%> (-13.52%)
:arrow_down:

.../impl/dictionary/FloatOnHeapMutableDictionary.java
80% <0%> (-6.67%)
:arrow_down:

.../impl/dictionary/LongOffHeapMutableDictionary.java
81.81% <0%> (-5.46%)
:arrow_down:

...roller/helix/core/PinotTableIdealStateBuilder.java
61.19% <0%> (-5.23%)
:arrow_down:

...e/operator/dociditerators/BitmapDocIdIterator.java
60.71% <0%> (-3.58%)
:arrow_down:

...not/broker/broker/helix/ClusterChangeMediator.java
62.71% <0%> (-3.39%)
:arrow_down:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e90c64...cfa37be. Read the comment docs.

Right now, the only way to test this is by adding integration test. I would prefer that we make pinotHelixResourceManager unit-testable instead of adding an integration for each of these cases, since it increases travis time.


Change: Discontinue

This PR discontinues this project.
It disables the cron schedule and adds a discontinuation notice to the website.

😔


nivelregleta

@pxjacomex - can you explain a bit more about nivelregleta. What exactly does it represent? What does Var14 represent and how does it relate to Var11 (water level)?
In particular, I have tried to translate insertar_nivelregleta to insert_level_rule and can see that it is somehow used to calculate uncertainty value. However, I still don't understand exacty what it represents. Any help is appreciated with this!

All references to nivelregleta are now in unused_templates or unused_scripts.


In october 2024 the tool stopped working with the error "exceptions.InputFileStructureError: No accounting period is found"

This is fixed in the release 1.2.0


Webpack won't minify js files in sub-folder

Webpack runs (to some extent). It finishes the run. There is one error (see below) which many online have explained about.
ERROR in koLabs.js from UglifyJs
SyntaxError: Unexpected token: punc ()) [./~/source-map-loader!./Labs/labsCtrl.js:512,0]
But, it minifies only select js files mainly in the top folder. It leaves out files in the sub-folder without any minification.
/Scripts/Tomat0 - works
/Scripts/Tomat0/(sub-folders) - doesn't minify
Any thoughts on it.

@SD-Dude Your have invalid code in labsCtrl.js on 512 line or your use uglifyOptions.ecma: 5, but your code in es5+, also maybe bug in uglify-es, better use https://github.com/webpack-contrib/terser-webpack-plugin


Flattening error message in _CONDOR_WRAPPER_ERROR_FILE and JobWrapperFailure Ad

Flattening eventual error message written in _CONDOR_WRAPPER_ERROR_FILE and JobWrapperFailure Attribute in ClassAd to make it a single line (\n and \r are replaced with double space)
Condor is failing when a multiline message is written, see https://opensciencegrid.atlassian.net/browse/HTCONDOR-2305

To patch an existing GWMS installation you have to replace the default_singularity_wrapper.sh with the one from this PR branch:
https://raw.githubusercontent.com/mambelli/glideinwms/v310/fix_htcondor_2305/creation/web_base/frontend/default_singularity_wrapper.sh


HttpProxyHandler should use/allow hostname in initial CONNECT request

Expected behavior
The HttpProxyHandler should include the hostname of the requested site in it's initial CONNECT request.
The hostname of the requested site is usually required by some proxies to apply ACLs (e.g. Squid)
Actual behavior
The HttpProxyHandler sends the resolved IP address of the requested host
Steps to reproduce
Add HttpProxyHandler to the pipeline
Minimal yet complete reproducer code (or URL to code)
When a InetSocketAddress is created as unresolved, the function used by HttpProxyHandler to get the requested host will return the hostname
InetSocketAddress testAddress = InetSocketAddress.createUnresolved("example.com", 80);
System.out.println(testAddress);
System.out.println(NetUtil.toSocketAddressString(testAddress));
// Output:
//  example.com:80
//  example.com:80

But when the address is resolved (like it will usually be in a pipeline) the IP address of the host is returned
InetSocketAddress testAddress = new InetSocketAddress("example.com", 80);
System.out.println(testAddress);
System.out.println(NetUtil.toSocketAddressString(testAddress));
// Output:
//  example.com/<IP_ADDRESS>:80
//  <IP_ADDRESS>:80

Netty version
4.1.17.Final
JVM version (e.g. java -version)
java version "1.8.0_162"
Java(TM) SE Runtime Environment (build 1.8.0_162-b12)
Java HotSpot(TM) 64-Bit Server VM (build 25.162-b12, mixed mode)

OS version (e.g. uname -a)
Darwin ##### 17.3.0 Darwin Kernel Version 17.3.0: Thu Nov  9 18:09:22 PST 2017; root:xnu-4570.31.3~1/RELEASE_X86_64 x86_64

This may be a duplicate of #4526, going to test the suggested changes from the ticket and will update this one if it works

Suggestions from #4526 proved successful, closing ticket


[Bug] : ReadMe of Image Processing

Description
I have modified the readme file in Image Processing folder as it was having wrong link redirection and repetitive entries of some of the projects.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

(Add x in the [] to mark as completed.)
Related Issues or Pull Requests
(Link the Issue Number over here.)
Fixes #600

@khusheekapoor Please merge it asap as if any single project of image processing is getting merged, then it is having merge conflicts again and again.


AttributeError: 'list' object has no attribute 'get'

Sorry Frenck, another one, getting this on v0.13.131315. This one repeats
Logger: custom_components.spook
Source: custom_components/spook/repairs/lovelace_unknown_entity_references.py:254
Integration: Spook (documentation, issues)
First occurred: 09:29:35 (5 occurrences)
Last logged: 09:30:34
Unexpected exception from <function AbstractSpookRepair.async_activate.._async_inspect at 0xffff4c76dbd0>
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/debounce.py", line 117, in _handle_timer_finish
await task
File "/config/custom_components/spook/repairs/init.py", line 130, in _async_inspect
await self.async_inspect()
File "/config/custom_components/spook/repairs/lovelace_unknown_entity_references.py", line 108, in async_inspect
for entity_id in self.__async_extract_entities(config)
File "/config/custom_components/spook/repairs/lovelace_unknown_entity_references.py", line 159, in __async_extract_entities
entities.update(self.__async_extract_entities_from_card(card))
File "/config/custom_components/spook/repairs/lovelace_unknown_entity_references.py", line 213, in __async_extract_entities_from_card
entities.update(self.__async_extract_entities_from_actions(config))
File "/config/custom_components/spook/repairs/lovelace_unknown_entity_references.py", line 254, in __async_extract_entities_from_actions
if action := config.get(key):
AttributeError: 'list' object has no attribute 'get'

Don't be sorry! It really helps!
There are so many cards and stuff out, that it is impossible for me to pre-think/catch them all. So these reports allow me to iteratively improve it 👍
../Frenck

It looks like you have a YAML list on a key that is either tap_action:, hold_action:, double_tap_action:, or subtitle_tap_action:.
How do those look in your configuration?
../Frenck

Is this what you mean ?
Now I look at it, I can combine them and there is a risk they might go out of sync, I'll adjust
            tap_action:
              - action: call-service
                service: homeassistant.toggle
                data:
                  entity_id:
                    - automation.immersion_heater_schedule_off
              - action: call-service
                service: homeassistant.toggle
                data:
                  entity_id:
                    - automation.immersion_heater_schedule_on

Hmm tabactions in HA can be a list? 😱

Seems to work ok, but I will redo it

On which card are you using that tap_action?

Mushroom Template Card

Actually, just tested again and it doesn't work, no errors though. I've removed it now

Indeed, was just looking at the mushroom codebase, but they seem to re-use HA parts, which doesn't work with lists.
But thanks for all the info and details! That means I can make it more robust (but don't have to take into account potentially new configuration structures).
👍
../Frenck

I have removed it but still getting this error in the logs

Should be solved with #198

Brilliant, nothing in logs now

Awesome! Thanks for all of that 👍


Roll engine 5ccee9537334..8b1a299ed52d (15 commits)

https://github.com/flutter/engine/compare/5ccee9537334...8b1a299ed52d
git log 5ccee95373348854bc4877cfe240024a36847d2d..8b1a299ed52d4ef9521ccd65c6c52d563129d8af --no-merges --oneline
8b1a299ed [Skia] Rollback Skia to 29d5dec9a0783a033b921dc483fb98d565d684f6 (flutter/engine#8151)
9f50dae33 Look up ICU symbols based on the path to libflutter.so as a fallback (flutter/engine#8139)
59715b71d Disable build_ios task due to lack of credits. (flutter/engine#8150)
31b289f27 Fix indexing error in dart:ui TextStyle.toString (flutter/engine#8143)
fc2e6b61c Typo "fast an inline" to "fast and inline" (flutter/engine#8142)
0f19b2de0 Reland PerformanceOverlayLayer golden test (flutter/engine#8140)
073aadde1 Fix TextStyle decode misalignment (flutter/engine#8141)
d87d29054 Roll src/third_party/skia 406b068942f0..2eecc3ea3d71 (11 commits) (flutter/engine#8138)
5cef4a022 Use final state passed to dart before initialization as the initial lifecycleState. (flutter/engine#8124)
ffef51be6 Roll src/third_party/skia 665bc64a2dc4..406b068942f0 (8 commits) (flutter/engine#8137)
48efd0fb7 Roll src/third_party/skia 762ddd7e4352..665bc64a2dc4 (2 commits) (flutter/engine#8129)
f666adbbd Roll src/third_party/skia 2932a458957d..762ddd7e4352 (3 commits) (flutter/engine#8128)
8b0df6ded Bugfix #29203: NPE in getAccessibilityProvider in old FlutterView. (flutter/engine#8126)
8f7b18345 Roll src/third_party/skia c6d8781c4036..2932a458957d (2 commits) (flutter/engine#8125)
52b67fdd5 Expose decorationThickness to dart:ui (flutter/engine#8008)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5638758966755328

Commit queue failed; closing this roll.