Module not found: Can't resolve 'next/navigation'

I am just starting out installing dependencies as in the starter docs and as soon as I add the <PrismicPreview>...</PrismicPreview> part, I get the following error:
../../node_modules/@prismicio/next/dist/PrismicPreviewClient.js:5:0
Module not found: Can't resolve 'next/navigation'

Import trace for requested module:
<EMAIL_ADDRESS><EMAIL_ADDRESS>./src/pages/_app.tsx

https://nextjs.org/docs/messages/module-not-found

After some digging in the @prismicio/next module, I found that the src/PrismicPreviewClient.tsx is using next/navigation which does not seem to be exported by next nor is it documented in their website. Removing that liner actually solves the problem.
Is this to support the new app router? Well in that case this breaks the existing pages router!
Versions

@prismicio/next:  v1.1.0
next: v12.3.1
node: v16.19.0

Reproduction

Additional Details

In the pages/_app.tsx file I added the following:
import { PrismicProvider } from '@prismicio/react'
import { PrismicPreview } from '@prismicio/next'
import { repositoryName } from '../../prismicio'

<PrismicProvider>
   <PrismicPreview repositoryName={repositoryName}>
           ...
   </PrismicPreview>
</PrismicProvider>

Steps to reproduce
Please follow the steps at the setup Prismic docs
What is expected?
Expected the app to work normally with preview supported
What is actually happening?
The app breaks and shows the above error message.

Moreover I also get the same error for the following modules:

next/headers which is used in src/enableAutoPreviews.ts
next/navigation which is again used in src/redirectToPreviewURL.ts

Replacing them with the following imports worked, respectively:

import { getCookieParser as cookies } from 'next/dist/server/api-utils'
import { redirect } from 'next/dist/server/api-utils'

But I don't think these packages should be used as they are not documented and will probably change without any further notice.

Hi @waleed-alfaifi, thanks for the detailed report!
@prismicio/next v1.0 and later requires at least Next.js 13.0, which should include the modules you listed (including next/navigation).
Upgrading from Next.js 12 to 13 should be a straightforward upgrade. See the upgrade guide here: https://nextjs.org/docs/pages/building-your-application/upgrading/version-13
If you are still experiencing issues with @prismicio/next after upgrading to Next.js 13, please comment here again and I will investigate.
Thank you! 🙂

@angeloashmore OK that might solve the problem but you should really mention it in the docs that you don't support Next 12 anymore. That way one won't have to go through the trouble of debugging a problem that should have not existed.

@waleed-alfaifi It is mentioned in @prismicio/next's documentation: https://prismic.io/docs/technical-reference/prismicio-next
However, it isn't listed in the main Prismic + Next.js guides. I'll make sure we add that note. Thanks for the feedback!


Since 5.20.0 codemirror.js is missing

Hi there,
I wanted to download your last version but since 5.20.0 your lib folder miss codemirror.js
If I check doc/manual.html I got
CodeMirror is not defined
How I can get your last version ?

From NPM, or using the zip file distributed from the website.


[PE-D] Wrong command format for tag-add

Steps to reproduce: Type tag-add 1 Public Relations as stated in the example
Expected behaviour: adds the tag Public Relations to the first person in the contact list
Actual behaviour: shows the message Unkown command format
Additional information: Using add-tag-p instead of add-tag works, so this is a UG bug rather than a functionality bug. It may cause occasional inconvenience to readers

Labels: type.DocumentationBug severity.Medium
original: cpwill01/ped#2

Duplicate with #156


chore(license): update source code headers + copyright year

ref: https://github.com/go-vela/community/issues/747

replaces code file license headers with SPDX header (see https://spdx.dev/ids/#why); this removes copyright + year
update golangci-lint rule to ensure code file enforcement
use first commit date for copyright year and updates year in other select places
format is changed to match "Copyright [yyyy] [name of copyright owner]" as shown here: https://www.apache.org/licenses/LICENSE-2.0.html

will recreate


Update third_party/src/google.golang.org packages [phab:D650]

Created by schroederc at 2015-12-15 17:15:17:

zarko wrote at 2015-12-15 17:21:37:
Any README.google changes?

schroederc wrote at 2015-12-16 20:01:06:
ping

schroederc wrote at 2015-12-16 20:01:34:

! In (earlier comment), zarko wrote:
Any README.google changes?

No, this is just an update.

zarko accepted this revision at 2015-12-16 20:18:20

schroederc closed via commit 654c157256aab2a54cee9a35017808c95af94a2e at 2015-12-16 20:20:38


[Feature] Various improvements to LazyStacked specs

Description
This PR makes a few changes to lazy stacked specs:

Remove unneeded placeholder methods in LazyStackedTensorSpec
Implement the device property for LazyStackedTensorSpec
Implement to_numpy for the two lazy stacked spec variants.

Would be great if you could check my understanding of what's required for to_numpy is correct.

I've added a couple of tests, I think this is good to go.


chore: add node version test matrix

As we will support node v20 in #1544, we should also provide test support for a range of versions. This PR provides a way for testing multiple node versions, however this PR will only introduce a single version. As additional versions are supported, they can be tested by adding to the versions array.

Will fail until #1579 is merged


Xdebug stops working on linux every once in a while

Describe the bug
Xdebug stops working on linux every once in a while.
To Reproduce
This is what happens on linux (Ubuntu, Docker version 18.09.3)
ping docker.for.mac.localhost
PING docker.for.mac.localhost (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: seq=0 ttl=64 time=0.108 ms
64 bytes from <IP_ADDRESS>: seq=1 ttl=64 time=0.168 ms

Because of that the xdebug entrypoint sets the xdebug.remote_host setting to <IP_ADDRESS> and this breaks xdebug.
Expected behavior
xdebug.remote_host is set to point to the host machine.
My workaround
Replacing the entrypoint's get_dockerhost function with the following snippet fixes it for me. I don't know if that's the correct solution for all the supported platforms.
get_dockerhost() {
  # https://github.com/amazeeio/pygmy/blob/267ba143158548628f190f05ecb5cb2c19212038/lib/pygmy/resolv_osx.rb#L26
  if busybox timeout -t 1 ping -c1 <IP_ADDRESS> &> /dev/null; then
    echo "<IP_ADDRESS>"
    return
  fi

   # Fallback to default gateway (should work on Linux) see https://stackoverflow.com/questions/24319662/from-inside-of-a-docker-container-how-do-i-connect-to-the-localhost-of-the-mach
  echo $(route -n | awk '/UG[ \t]/{print $2}')
  return
}

This was fixed in https://github.com/uselagoon/lagoon-images/blob/main/images/php-fpm/entrypoints/60-php-xdebug.sh


1.20.1

can i use it in 1.20.1？

No, you can't load it using 1.20.1, but if you need a 1.20.1 server you can use viafabricplus

thx

You can use it on servers running version 1.20.1 with either this or this mod.
Alternatively, you can change some parameters in the gradle.properties file and build the client again yourself to run it on version 1.20.1.


Missing docs for interfaces contained in azure.containerservice.KubernetesClusterArgs

Interfaces/objects that are contained in KubernetesClusterArgs are not defined and marked as pulumi.Input<{}>.
Example:
KubernetesClusterArgs.networkProfile pulumi.Input<{}>
A Network Profile block as documented below.

There is no further documentation on the page for what fields exist in networkProfile

This touches on a couple of issues we are tracking:

We should display the actual types instead of ... in the docs: part of https://github.com/pulumi/docs/issues/492.
Inner structs should be given names and presented as first class things in the docs and API (including attaching documentation of the inner fields): https://github.com/pulumi/pulumi-terraform/issues/163

The best resource we have currently for this is the .d.ts files.  These are actually linked from the headers in the docs - like property agentPoolProfile which links to https://github.com/pulumi/pulumi-azure/blob/master/sdk/nodejs/containerservice/kubernetesCluster.ts#L245.
Addressing the two issues above, plus improving the raw documentation text itself, will be key to improving on this.

Thanks for the update @lukehoban if you feel this is covered by other issues, then this can be closed. 👍


test:fractions

What?
A test about how well the Explorer handles numbers that can not be perfectly represented in Binary by the SDK
Why?
Setting a fractional number in the Transform can lead to unexpected results

Hey @EibrielInv !
I'm closing this, since we did the fix in https://github.com/decentraland/explorer/pull/1199
Thank you for reporting this, and taking the time to build a scene to reproduce it!


Add support for italic fonts.

I use the Dank Mono font and I really liked its theme and I would like it to support the italic option as well. Check out what it looks like in another theme, Moonlight
Moonlight

Davinci

We will not currently support italics, as this would require creating many theme variants.


Replace unsafe functions with safe alternatives?

I saw recently that Git VCS generates compiler errors if you try to use unsafe C functions. Would a pull request be accepted to add this header and replace the unsafe functions with safe ones?
banned.h
# https://github.com/git/git/blob/master/banned.h
#ifndef BANNED_H
#define BANNED_H

/*
 * This header lists functions that have been banned from our code base,
 * because they're too easy to misuse (and even if used correctly,
 * complicate audits). Including this header turns them into compile-time
 * errors.
 */

#define BANNED(func) sorry_##func##_is_a_banned_function

#undef strcpy
#define strcpy(x,y) BANNED(strcpy)
#undef strcat
#define strcat(x,y) BANNED(strcat)
#undef strncpy
#define strncpy(x,y,n) BANNED(strncpy)
#undef strncat
#define strncat(x,y,n) BANNED(strncat)

#undef sprintf
#undef vsprintf
#ifdef HAVE_VARIADIC_MACROS
#define sprintf(...) BANNED(sprintf)
#define vsprintf(...) BANNED(vsprintf)
#else
#define sprintf(buf,fmt,arg) BANNED(sprintf)
#define vsprintf(buf,fmt,arg) BANNED(sprintf)
#endif

#endif /* BANNED_H */

Usually, we ensure the buffer size before using those functions. But we accept PR anyway.


Improve documentation for running unit tests

The documentation on Contributing has some basic information about running the unit tests. However, it would be helpful to extend that to cover situations such as:

Running individual tests rather than all tests
Running only the CPU, GPU, or Python tests rather than all tests

For example, this will run only the CPU unit tests from the Builtins suite:
tests/cpu/test_cpu_exec --run_only  Builtins
And this will run just Python test:
python3 ../tests/python/OpenColorIOTestSuite.py  $PWD

Can I take this?

To just run one category of unit test, it might be simpler to stick with ctest:
# Get the list of tests
ctest -N
# Run individual tests examples
ctest -V -R test_cpu
ctest -V -R test_gpu
ctest -V -R test_python

But to reach individual tests within a group, I think we have to use our executable directly with --run_only like Doug showed.


Move from Make to better cross platform build tool

TL;DR - WSL on Windows hurts a lot, so it would be good if we could use something that is (a) potentially native to the Rust ecosystem and (b) doesn't force WSL on our developers.
One option: https://crates.io/crates/cargo-make

Since people are will have cargo installed anyway, to install a cargo plugin doesn't seem like an onerous ask if it helps with cross platform development. WDYT?

Yeah I'm totally in favour of this, I think since you have to have cargo anyway asking someone to run cargo install is totally fine. I even thinking asking them to install another tool is fine, as long it's easy to install and work out of the box, rather than make's "setup MinGW or WSL environment" requirement.
There's a few other ones I know of you might want to have a look at. I have no real preference myself (except maybe a slight preference for earthly because I think it's a cool new technology), so whichever tool you find that works best for you is fine with me.

just A self styled "just" a command runner (also written in rust so can be installed with cargo)
cargo xtask Not a tool, but a pattern for having your project automation defined in Rust and callable with cargo directly.
earthly Markets itself as "what if Make and Docker had a baby".

Originally posted by @XAMPPRocky in https://github.com/googleforgames/quilkin/issues/556#issuecomment-1209862000

Just writing out thoughts I have -
One quite large benefit of forcing WSL on Windows users is that it means that there is consistency between all OS's on things like directory pathing, (/ everywhere), config files are usually in the same / similar places etc (Kubernetes local config is always in ~/.kube/config for example).
There's a lot less special case management between platforms. When evaluating other options, we should see if there is anything they provide to make handling these issues between platforms simpler.


create language model fails

cmd/create_language_model.py fails with following message:
Please set your username in the environment variable USERNAME
This is due to the apikey issue which needs to be consistently used. services.json doesn't use USERNAME and PASSWORD, so all of the python scripts need to be modified to accept apikey.

Hi Rich, the python scripts are set up to accept both types of credential for flexibility.  If you have the api key, then you can set the environment variable as:
export USERNAME=apikey
export PASSWORD=
This is explained in the instruction, but I guess it would be helpful to say this in the error message also, so let me do that.


feat: add multiexponentiation function for Pippenger's partition method (PROOF-831)

Rationale for this change
Add a component to compute multiexponentiations using Pippenger's partition algorithm and precomputed generator sums.
What changes are included in this PR?
A new component for computing multiexponentiations.
Are these changes tested?
Yes.

:tada: This PR is included in version 1.48.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Support call-by-name for Box's openOrThrowException.

Closes #1781.
cc @serioga

We should be able to spec-test the call-by-name nature of the parameter by passing something that computes the value + has a side effect, and confirming that the side effect only happens if the Box is non-EmptyBox.
Lookin' good though!

Added examples as requested.

Heh codacy is complaining about duplication in my specs. :unamused:

I'm 👍 for this. Once Lift 3 goes final ofc ;)

Still 👍 here so let's roll 'er in.


11 create scatterplot

@aemabe  Thank you for creating the PR. There are extra axis lines and ticks compared with the figure in the manuscript. Suggest adding the following arguments to the theme() function to remove the extra axis lines and ticks:
axis.line.x =  element_blank(),
axis.line.y =  element_blank(),
axis.ticks.x = element_blank(),
axis.ticks.y = element_blank()

@aemabe Another comment - We may want to avoid the use of "fig11" in the function as the function may be used outside of the context of the manuscript figures.


Error in pulling Image in Kubernetes on mac os

What's your CLI version?
0.86.12
Description & steps to reproduce
Description
Failing to pull the linux/amd64 container in mac os (arm64).
Steps to reproduce

Setup the kubernetes
install minikube
minicube start
update the kurtosis-config.yaml
change the clister to minikube (kurtosis cluster set minikube)
clone the repository https://github.com/HugoByte/polkadot-kurtosis-package.git
run the command
kurtosis run . --args-file ./config.json --enclave polkadot

Screenshot

Desired behavior
parity/polkadot imgae shoul pull automatically and run the node
What is the severity of this bug?
Critical; I am blocked and Kurtosis is unusable for me because of this bug.
What area of the product does this pertain to?
Other: anything not covered by the above

Confirming I saw this live; the image is parity/polkadot:latest that exists on Dockerhub

I can repro this with this particular image on Minikube on ARM Mac:
kurtosis run github.com/kurtosis-tech/postgres-package '{"image":"parity/polkadot:latest"}'
INFO[2024-01-30T10:40:32-03:00] Engine running in Kubernetes cluster, to connect to the engine from outside the cluster run 'kurtosis gateway' to open a local gateway to the engine
INFO[2024-01-30T10:40:32-03:00] Creating a new enclave for Starlark to run inside...
INFO[2024-01-30T10:40:36-03:00] Enclave 'pretty-field' created successfully

Container images used in this run:
> parity/polkadot:latest - locally cached

> add_service name="postgres" config=ServiceConfig(image="parity/polkadot:latest", ports={"postgresql": PortSpec(number=5432, application_protocol="postgresql")}, files={"/data/": Directory(persistent_key="data-postgres")}, cmd=[], env_vars={"PGDATA": "/data//pgdata", "POSTGRES_DB": "postgres", "POSTGRES_PASSWORD": "MyPassword1!", "POSTGRES_USER": "postgres"}, max_cpu=1000, min_cpu=10, max_memory=1024, min_memory=32)
There was an error executing Starlark code
An error occurred executing instruction (number 1) at github.com/kurtosis-tech/postgres-package/main.star[112:40]:
  add_service(name="postgres", config=ServiceConfig(image="parity/polkadot:latest", ports={"postgresql": PortSpec(number=5432, application_protocol="postgresql")}, files={"/data/": Directory(persistent_key="data-postgres")}, cmd=[], env_vars={"PGDATA": "/data//pgdata", "POSTGRES_DB": "postgres", "POSTGRES_PASSWORD": "MyPassword1!", "POSTGRES_USER": "postgres"}, max_cpu=1000, min_cpu=10, max_memory=1024, min_memory=32))
  Caused by: Unexpected error occurred starting service 'postgres'
  Caused by: An error occurred creating pod 'postgres' using image 'parity/polkadot:latest'
  Caused by: An error occurred waiting for pod 'postgres' to become available
  Caused by: Container 'user-service-container' using image 'parity/polkadot:latest' in pod 'postgres' in namespace 'kt-pretty-field' is stuck in state 'ImagePullBackOff'. This likely means:
  1) There's a typo in either the image name or the tag name
  2) The image isn't accessible to Kubernetes (e.g. it's a local image, or it's in a private image registry that Kubernetes can't access)

Error encountered running Starlark code.

Debugged with Shanith - seems like this is an issue of the image not having an ARM version published, and Minikube is hard-blocking it.

AFAIK there is no option to force K8S to pull for a specific arch.  The image above will have to be published with a manifest containing the list of supported archs.  This can be done with Docker buildx: --platform linux/arm64/v8,linux/amd64`.

@laurentluce could we add a third case to the error condition above, saying that the image's architecture might not match? I think we can close this ticket then


Support IPv4 parsing with leading zeros on go 1.17

What this PR does / why we need it:
Since go version 1.17, net.ParseIP() and net.ParseCIDR() functions rejects leading zeros in the dot-decimal notation of IPv4 addresses.
The affected fields in the VMI spec are:

dnsConfig.nameservers (k8s.io.api.core.v1.PodDNSConfig)
domain.devices.interfaces[].dhcpOptions.ntpServers (v1.DHCPOptions)
networks[].pod.vmNetworkCIDR

These fields will be parsed as decimal IPv4 addresses (leading zeros are ignored):
For example: <IP_ADDRESS> => <IP_ADDRESS>
Same for CIDR notation:
For example: <IP_ADDRESS>/24 => <IP_ADDRESS>/24
In order to upgrade Kubevirt's go version to 1.17 and to maintain backwards compatibility - we need to use ParseIPSloppy() and ParseCIDRSloppy() functions from k8s.io/utils.
Because we don't want to have a mix of the go standard library functions and the sloppy functions from K8s, the chosen solution uses them only once in the unmarshaling methods of the three affected structs.
The UnmarshalJSON methods make sure that the affected fields are sanitized before their usage in the system.
This was tested manually and automatically on go 1.17 (locally).
Several other ideas where considered:

Change the validating webhook and the three affected places where string IP/CIDR is converted to bytes - this can lead to a mix to standard and sloppy functions that we want to avoid. Furthermore, it is not simple to determine when to use which function, and unforeseen bugs could occur.
Change all occurrences of net.ParseIP() and net.ParseCIDR() to ParseIPSloppy() and ParseCIDRSloppy().
This can lead to more problems when interfacing with other non Go tools or systems (that may have other interpretation of IPv4 addresses with leading zeros).
Using a mutating webhook - this option is not feasible because the webhook is not being called after a system upgrade from Kubevirt that had been built using go < 1.17 to a version build using go >= 1.17.

For additional details please see issue #6498.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6498
Special notes for your reviewer:
This PR is based on PR #7008, please review the last five commits.
Release note:

NONE

/cc @EdDev @ormergi

/uncc @enp0s3 @vladikr

Tested the fix on current go version (1.16.6) with the following VMI manifest:
---
apiVersion: kubevirt.io/v1
kind: VirtualMachineInstance
metadata:
  labels:
    special: vmi-fedora
  name: vmi-fedora
spec:
  dnsConfig:
    nameservers:
      - <IP_ADDRESS>
  domain:
    devices:
      interfaces:
        - masquerade: {}
          name: default
          dhcpOptions:
            ntpServers:
              - <IP_ADDRESS>3
              - <IP_ADDRESS>
      disks:
      - disk:
          bus: virtio
        name: containerdisk
      - disk:
          bus: virtio
        name: cloudinitdisk
      rng: {}
    resources:
      requests:
        memory: 1024M
  networks:
    - name: default
      pod: {}
  terminationGracePeriodSeconds: 0
  volumes:
  - containerDisk:
      image: registry:5000/kubevirt/fedora-with-test-tooling-container-disk:devel
    name: containerdisk
  - cloudInitNoCloud:
      userData: |-
        #cloud-config
        password: fedora
        chpasswd: { expire: False }
    name: cloudinitdisk

Run the following command inside the VM:
[fedora@vmi-fedora ~]$ journalctl | grep -Ei 'dhcp'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.7147] dhcp-init: Using DHCP client 'internal'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8161] dhcp4 (eth0): activation: beginning transaction (timeout in 45 seconds)
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8245] dhcp4 (eth0): option dhcp_lease_time      => '86313600'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8248] dhcp4 (eth0): option domain_name          => 'default.svc.cluster.local'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8248] dhcp4 (eth0): option domain_name_servers  => '<IP_ADDRESS> <IP_ADDRESS>'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8249] dhcp4 (eth0): option domain_search        => 'default.svc.cluster.local svc.cluster.local cluster.local'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8249] dhcp4 (eth0): option expiry               => '1726481865'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8250] dhcp4 (eth0): option host_name            => 'vmi-fedora'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8250] dhcp4 (eth0): option interface_mtu        => '1480'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8251] dhcp4 (eth0): option ip_address           => '<IP_ADDRESS>'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8251] dhcp4 (eth0): option ntp_servers          => '<IP_ADDRESS> <IP_ADDRESS>'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8251] dhcp4 (eth0): option requested_broadcast_address => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8252] dhcp4 (eth0): option requested_domain_name => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8252] dhcp4 (eth0): option requested_domain_name_servers => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8253] dhcp4 (eth0): option requested_domain_search => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8253] dhcp4 (eth0): option requested_host_name  => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8254] dhcp4 (eth0): option requested_interface_mtu => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8254] dhcp4 (eth0): option requested_ms_classless_static_routes => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8254] dhcp4 (eth0): option requested_nis_domain => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8255] dhcp4 (eth0): option requested_nis_servers => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8255] dhcp4 (eth0): option requested_ntp_servers => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8256] dhcp4 (eth0): option requested_rfc3442_classless_static_routes => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8256] dhcp4 (eth0): option requested_root_path  => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8257] dhcp4 (eth0): option requested_routers    => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8257] dhcp4 (eth0): option requested_static_routes => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8258] dhcp4 (eth0): option requested_subnet_mask => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8258] dhcp4 (eth0): option requested_time_offset => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8259] dhcp4 (eth0): option requested_wpad       => '1'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8259] dhcp4 (eth0): option routers              => '<IP_ADDRESS>'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8260] dhcp4 (eth0): option subnet_mask          => '<IP_ADDRESS>'
Dec 22 10:17:45 vmi-fedora NetworkManager[640]: <info>  [1640168265.8260] dhcp4 (eth0): state changed unknown -> bound

Inside the virt-launcher pod:
$ cat /etc/resolv.conf
search default.svc.cluster.local svc.cluster.local cluster.local
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>

/retest-required

/retest-required

Changes:

Unified production code and unit tests to same commit.
Added E2E test for DNS nameservers.

/retest-required

/retest-required

Regarding the commit messages: Please arrange their first line to fit this format: <topic>: <subject>
The topic is usually the package under which this change occured (e.g. network, dhcp, network, dns, webhooks, etc)

@EdDev  Done.

/test pull-kubevirt-unit-test

About the last commit, what you think about adding another test for leading zero's input addresses input instead of changing the one we have?

@ormergi Done.

Change: Added dedicated E2E tests for DNS nameservers and NTP IPv4 addresses which contain leading zeros.

This PR will be split and rebased on PR #7008

Changes:

Rebased on PR #7008.
Added spacial UnmarshalJSON methods for VirtualMachineSpec and DHCPOptions structs.

This was tested manually and automatically on go 1.17 (locally).

Change:
Changed the signature of SanitizeIP() to return an error as well as a sanitized value.
This was done in order not to assign "" strings to DNS / NTP array elements - so the user can have an indication of what went wrong.

Please add a convincing argument why it is the appropriate to do this at the unmarshal step.

Change:

Fixed code review remarks.
Added handling for networks[].pod.vmNetworkCIDR field.

/retest-required

Change: Fixed a bug in the custom CIDR E2E test.

/retest-required

Change: Fixed review remarks.

/sig network

/retest-required

rebase (to pass pull-kubevirt-generate test)
@EdDev can you please lgtm again?

/retest-required

Using a mutating webhook - this option is not feasible because the webhook is not being called during migration.

Why do you need to mutate the IP during a migration?

Using a mutating webhook - this option is not feasible because the webhook is not being called during migration.

Why do you need to mutate the IP during a migration?

We want to handle the scenario of a system upgrade, on which a migration happens.

Using a mutating webhook - this option is not feasible because the webhook is not being called during migration.

Why do you need to mutate the IP during a migration?

We want to handle the scenario of a system upgrade, on which a migration happens.

I meant that is case of migration, the VM already has the mutated version of the IP. So i don't understand the reasoning of "mutating webhook is not being called during migration"?

Using a mutating webhook - this option is not feasible because the webhook is not being called during migration.

Why do you need to mutate the IP during a migration?

We want to handle the scenario of a system upgrade, on which a migration happens.

I meant that is case of migration, the VM already has the mutated version of the IP. So i don't understand the reasoning of "mutating webhook is not being called during migration"?

The problem here is the upgrade from a Kubevirt version that had been built using go < 1.17 to a version that had been built using go >= 1.17.
During this transition, you can still have IPv4 addresses and CIDRs with leading zeros stored in the DB.

Using a mutating webhook - this option is not feasible because the webhook is not being called during migration.

Why do you need to mutate the IP during a migration?

We want to handle the scenario of a system upgrade, on which a migration happens.

I meant that is case of migration, the VM already has the mutated version of the IP. So i don't understand the reasoning of "mutating webhook is not being called during migration"?

The problem here is the upgrade from a Kubevirt version that had been built using go < 1.17 to a version that had been built using go >= 1.17.
After this transition, you can still have IPv4 addresses and CIDRs with leading zeros stored in the DB.
EDIT: So a mutating webhook won't be called on the VMI.

Please update the PR message. "Migration" is not related to the issue.

Changes:

Removed two unused validating webhook commits.
Fixed a remark from @AlonaKaplan's review.

/approve
Thanks!

/resetst-required

/retest-required

/retest-required

/test pull-kubevirt-e2e-k8s-1.21-sig-storage

/test pull-kubevirt-e2e-kind-1.22-sriov

/cherrypick release-0.49
I think it is the safest to prepare our long lived branch for go 1.17. I am pretty sure that adopters will sooner or later just start using 1.17> and may not know about this issue here.


Review And Update Docs

Check the documentation, add more about:

[x] Building in Docker (instructions on new builder);
[ ] Dockerhub docs update;
[ ] Running different docker images instead of building (Burrow, Ursa etc);
[x] Review other docs.
[ ] Add info about RDB?

@LiraLemur I wanted to ask how Docker images are being created for Dockerhub, and now I don't have to ask, because it would be in documentation. Great!

Iroha v1 is being deprecated


Invalid write in recover_from_partial_skipblock_fill

#include "plf_hive.h"

int throwing = 0;

struct S {
    int x;
    S(int x) : x(x) {}
    S(const S& s) : x(s.x) { if (--throwing == 0) throw 42; }
};

int main()
{
    plf::hive<S> h = {1, 2};
    h.erase(std::next(h.begin()));
    throwing = 1;
    try {
        h.insert(2, 42);
    } catch (...) { }
}

$ valgrind ./a.out
==89089== Memcheck, a memory error detector
==89089== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==89089== Using Valgrind-3.19.0.GIT-lbmacos and LibVEX; rerun with -h for copyright info
==89089== Command: ./a.out
==89089==
==89089== Invalid write of size 1
==89089==    at 0x1007CFDC9: _platform_bzero$VARIANT$Haswell (in /usr/lib/system/libsystem_platform.dylib)
==89089==    by 0x100007978: plf::hive<S, std::__1::allocator<S>, plf::hive_priority::performance>::recover_from_partial_skipblock_fill(std::__1::aligned_storage<4ul, 4ul>::type*, std::__1::aligned_storage<4ul, 4ul>::type*, unsigned short*, unsigned short) (plf_hive.h:2295)

It looks to me like the culprit is this line:
-   const skipfield_type elements_constructed_before_exception = static_cast<skipfield_type>((current_location - 1) - location);
+  const skipfield_type elements_constructed_before_exception = static_cast<skipfield_type>((current_location) - location);

Removing the -1 as shown seems to fix the issue. (current_location here points to the object we were trying to construct when the exception occurred, so that object wasn't constructed, but everything to the left of it was.)

On 2/05/2022 5:15 am, Quuxplusone wrote:

|#include "plf_hive.h" int throwing = 0; struct S { int x; S(int x) :
x(x) {} S(const S& s) : x(s.x) { if (--throwing == 0) throw 42; } }; int
main() { plf::hive h = {1, 2}; h.erase(std::next(h.begin()));
throwing = 1; try { h.insert(2, 42); } catch (...) { } } |
|$ valgrind ./a.out ==89089== Memcheck, a memory error detector
==89089== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et
al. ==89089== Using Valgrind-3.19.0.GIT-lbmacos and LibVEX; rerun with
-h for copyright info ==89089== Command: ./a.out ==89089== ==89089==
Invalid write of size 1 ==89089== at 0x1007CFDC9:
_platform_bzero$VARIANT$Haswell (in
/usr/lib/system/libsystem_platform.dylib) ==89089== by 0x100007978:
plf::hive<S, std::__1::allocator,
plf::hive_priority::performance>::recover_from_partial_skipblock_fill(std::__1::aligned_storage<4ul,
4ul>::type*, std::__1::aligned_storage<4ul, 4ul>::type*, unsigned
short*, unsigned short) (plf_hive.h:2295) |
It looks to me like the culprit is this line:
|- const skipfield_type elements_constructed_before_exception =
static_cast<skipfield_type>((current_location - 1) - location); + const
skipfield_type elements_constructed_before_exception =
static_cast<skipfield_type>((current_location) - location); |
Removing the |-1| as shown seems to fix the issue. (|current_location|
here points to the object we were trying to construct when the exception
occurred, so /that/ object wasn't constructed, but everything to the
left of it was.)

Yes, that's correct - mistake on my part - fixed.


Enabling shell integration in remote with zshell fails with ENOENT

Use the tool Tanha and I have been working on to connect to a remote machine with zshell
Turn on shell integration
See this error in the server's console, and notice creating a shell fails

[Error: ENOENT: no such file or directory, copyfile '/Users/connor/.vscode-server/server-insiders/bin/7fc8af4e2d8f50a3950b809b9beab86fa5135f29/out/vs/workbench/contrib/terminal/browser/media/shellIntegration-profile.zsh' -> '/var/folders/q1/7d0txh0j6gg7gj9_wf70qcgm0000gn/T/vscode-zsh/.zprofile']

That folder contains only the following files, no shellIntegration-profile.zsh:
> ls -a  /Users/connor/.vscode-server/server-insiders/bin/7fc8af4e2d8f50a3950b809b9beab86fa5135f29/out/vs/workbench/contrib/terminal/browser/media/
.                        ..                       shellIntegration-bash.sh shellIntegration.ps1     shellIntegration.zsh

This results in the same state I saw in https://github.com/microsoft/vscode/issues/148312, might be the root cause?

I believe this is happening because in a remote context, there probably isn't permission to be accessing .zprofile - thus the ENOENT

From the command it looked like it was trying to copy a file called shellIntegration-profile.zsh, but that file didn't exist.

that file should definitely exist because we make it
https://github.com/microsoft/vscode/blob/43464213a6989181e9dfe49d0fe9189b1c67f7c7/src/vs/platform/terminal/node/terminalProcess.ts#L213

Hm. I may be misunderstanding the code or error, but it seems like we want to copy it from the out folder of the app
https://github.com/microsoft/vscode/blob/35c2141bf1babe9b8d18a86f80abcb6e6555b546/src/vs/platform/terminal/node/terminalEnvironment.ts#L200
However, it's not included there, at least in the latest Insiders server build that I was using
➜  vscode git:(main) ✗ unzip -l vscode-server-darwin-arm64.zip | grep shellIntegration-profile.zsh
➜  vscode git:(main) ✗

Oh yes you're correct, will fix


[Bug]: Error detected In C file

Neovim version
0.9.4
Language affected
C
Query
No response
Strategy
No response
Description
This problem occurs when I open a C file by nvimdots.
And errors consistently occur as I move the cursor around.
Sometimes the cursor even move itself in a strange way.
Besides, this problem may have associated with the codes.
If I create a new C file and just do "Hello world" print, no error will be reported.
Error Info:
Error detected while processing CursorMoved Autocommands for "<buffer=1>":
Error executing lua callback: ...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:198: attempt to call method 'range' (a nil value)
stack traceback:
        ...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:198: in function 'update_local'
        ...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:223: in function 'fn'
        ...m/share/nvim/runtime/lua/vim/treesitter/languagetree.lua:345: in function 'for_each_tree'
        ...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:222: in function 'local_rainbow'
        ...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:277: in function <...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:273>

Does it happen in any C file? Does it happen with the included test file (test/highlight/regular.c). If you are using a premade configuration please try without; these configurations add all sorts of stuff and there is no way I can troubleshoot that.
The error message says that the method range does not exist on the TSTree object. So chances are that this is some sort of type error.

I have fixed this error in #54 already (discovered it when adding types since I got a type warning). In the local strategy there is a line:
log.debug("Did not build any matches Stack for tree '%s'", vim.inspect(tree:range()))

that should have been
log.debug("Did not build any matches Stack for tree '%s'", vim.inspect(tree:root():range()))

If we want to quickly update just these small problems, I can make a smaller cleanup pull request with small fixes first?

I have fixed this error in #54 already (discovered it when adding types since I got a type warning). In the local strategy there is a line:
log.debug("Did not build any matches Stack for tree '%s'", vim.inspect(tree:range()))

that should have been
log.debug("Did not build any matches Stack for tree '%s'", vim.inspect(tree:root():range()))

If we want to quickly update just these small problems, I can make a smaller cleanup pull request with small fixes first?
Update: Since it wasn't much work, I made a smaller pull request including this fix now.

I do change this line in the local.lua, but error still detected with different info
E5108: Error executing lua: ...y/nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua:220: CursorMoved Autocommands for "<buffer=6>": Vim(append):Error executing
lua callback: vim/inspect.lua:0: attempt to index a number value
stack traceback:
        vim/inspect.lua: in function 'inspect'
        ...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:217: in function 'update_local'
        ...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:244: in function 'fn'
        ...m/share/nvim/runtime/lua/vim/treesitter/languagetree.lua:345: in function 'for_each_tree'
        ...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:243: in function 'local_rainbow'
        ...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:304: in function <...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:300>
        [C]: in function 'nvim_set_current_win'
        ...y/nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua:220: in function 'set_current_win_no_autocmd'
        ...y/nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua:284: in function 'open_in_new_window'
        ...y/nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua:334: in function 'fn'
        ...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:170: in function 'edit'
        ...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:180: in function 'fn'
        ...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:49: in function <...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:46>
stack traceback:
        [C]: in function 'nvim_set_current_win'
        ...y/nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua:220: in function 'set_current_win_no_autocmd'
        ...y/nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua:284: in function 'open_in_new_window'
        ...y/nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua:334: in function 'fn'
        ...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:170: in function 'edit'
        ...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:180: in function 'fn'
        ...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:49: in function <...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:46>

Does it happen in any C file? Does it happen with the included test file (test/highlight/regular.c). If you are using a premade configuration please try without; these configurations add all sorts of stuff and there is no way I can troubleshoot that.
The error message says that the method range does not exist on the TSTree object. So chances are that this is some sort of type error.

I not sure whether I use any premade configuration, how to check it?
By the way, I open the test/highlight folder and  run the C/C++ files and some other files resulting no error.
But just now I find out how to trigger this bug -- add #define in the C/C++ file. I also add #define in the regular.c, and error occurs as I move the cursor to the bracket.

I do change this line in the local.lua, but error still detected with different info
E5108: Error executing lua: ...y/nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua:220: CursorMoved Autocommands for "<buffer=6>": Vim(append):Error executing
lua callback: vim/inspect.lua:0: attempt to index a number value
stack traceback:
        vim/inspect.lua: in function 'inspect'
        ...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:217: in function 'update_local'
        ...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:244: in function 'fn'
        ...m/share/nvim/runtime/lua/vim/treesitter/languagetree.lua:345: in function 'for_each_tree'
        ...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:243: in function 'local_rainbow'
        ...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:304: in function <...elimiters.nvim/lua/rainbow-delimiters/strategy/local.lua:300>
        [C]: in function 'nvim_set_current_win'
        ...y/nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua:220: in function 'set_current_win_no_autocmd'
        ...y/nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua:284: in function 'open_in_new_window'
        ...y/nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua:334: in function 'fn'
        ...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:170: in function 'edit'
        ...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:180: in function 'fn'
        ...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:49: in function <...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:46>
stack traceback:
        [C]: in function 'nvim_set_current_win'
        ...y/nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua:220: in function 'set_current_win_no_autocmd'
        ...y/nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua:284: in function 'open_in_new_window'
        ...y/nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua:334: in function 'fn'
        ...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:170: in function 'edit'
        ...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:180: in function 'fn'
        ...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:49: in function <...share/nvim/site/lazy/nvim-tree.lua/lua/nvim-tree/api.lua:46>

This error seems to be because you are somehow calling an autocommand in the nvim-tree buffer, which shouldn't happen. Thus vim.inspect doesn't get the type of input it expects here. This seems more like an error in nvim-tree, but I am not sure exactly how to best solve it.

I'm not sure whether I use any premade configuration, how to check it?

If you use nvimdots, then you are using a premade configuration.

By the way, I open the test/highlight folder and run the C/C++ files and some other files resulting no error. But just now I find out how to trigger this bug -- add #define in the C/C++ file. I also add #define in the regular.c, and error occurs as I move the cursor to the bracket.

What do you mean by "error occurs as I move the cursor to the bracket"? What bracket? With the given information about adding a #define I wasn't able to reproduce this.

What do you mean by "error occurs as I move the cursor to the bracket"? What bracket? With the given information about adding a #define I wasn't able to reproduce this.

If I move to the line that has {} , the error will be reported.
As you could't reproduce the problem, I assume that maybe it's caused by a conflict with other plug or  some premade configuration.

If I move to the line that has {} , the error will be reported.

I could still not reproduce it.

As you could't reproduce the problem, I assume that maybe it's caused by a conflict with other plug or some premade configuration.

Yes, I think it is something specific to the nvimdots most likely (if it was nvim-tree I think other people would have experienced this before). If I had to guess, it has something to do with the events they use in the setup, but I am not sure about this.

Hello, I find this bug can be reproduced stably by following steps: https://github.com/ayamir/nvimdots/issues/1065#issuecomment-1816555151

Hello, I find this bug can be reproduced stably by following steps: ayamir/nvimdots#1065 (comment)

I was able to reproduce this with the given steps. Note: This only errors in Neovim 0.9.4, not in the latest version of 0.10.
I will try to see if I can figure out a solution.

I have found what causes the error, but now I have noticed another problem.
The error seems to be caused by some problem with vim.inspect, where it can't handle the output of tree:root():range(). This is easy enough to fix, by changing
vim.inspect(tree:root():range())

to
vim.inspect( {tree:root():range()} )

Now we don't get any error anymore with this fix, but rainbow-delimiters still doesn't work as expected in a c file with #define MACRO 0 included, because this seems to mess with the treesitter parser for c. Removing #define MACRO 0 and gets rainbow-delimiters working, and when it works, putting the macro back in the code doesn't break it. I will try to see if I can get it to work from the start without this annoying workaround.

I think #61 should fix both problems I found. Please let me know if it doesn't solve the problem.


Discord: Invalid Invite

https://github.com/neil-zip/pluginstxt/blob/87807c58a399f186969245515718d12edb33e001/README.md?plain=1#L114
@neil-zip There is something wrong with this link.

Thanks alot @szepeviktor ! I've updated the link it should work now. (https://discord.gg/e4NkSj28)


Is it possible to sign this package?

https://learn.microsoft.com/en-au/nuget/create-packages/sign-a-package#verify-a-signed-package

Hi @takanapa, I remember we talked about it here probably @chayim knows better than me where it stands because he started working on PR for it.
@chayim can you help here?

Thanks @shacharPash for looking into this issue, Yes looks like #77 will solve the issue.

@shacharPash can you please help approve that PR from Chayim

Is anyone still looking at it? We're trying to figure out how to make NRedisStack work in our engineering system, but so far, it's giving us a lot of headache.

@chayim what happened with that in the end? (#77)


Ability to add model items to the collection immediately upon create

I find myself needing to do this sometimes from a usability perspective.  It allows the UI to respond immediately and I can deal with the ramifications of a failure later.

I propose you'd do this instead:
colE.create({label: 'f'}).last().save();

I don't have permission to reopen.  But, the proposed solution does not work.
When save() returns, it will try to add the item to the collection again.  When it does, it will find a duplication and throw an exception.


fix links to documentation

Oh, so you wanted this fixed in slog-atomic. Done. Thanks for taking time to report it!


Generating POM files is slower than required because output upToDateWhen always failing

We have hundreds of subprojects in our project.  These are published out to mavenLocal repo.  According to build scan we are spending a significant amount of time in :generatePomFileForCoreJavaPublication tasks.  This is because
GenerateMavenPom  constructor has the following code
public GenerateMavenPom() {
    // Never up to date; we don't understand the data structures.
    getOutputs().upToDateWhen(Specs.satisfyNone());
}

There is no way to add a hook to control this since if ANY of the upToDateWhen calls fail the method will be rerun.
Expected Behavior

GenerateMavenPom should either have proper up-to-date check OR should allow the user to plug in their own check.
I am happy to contribute a patch if given a bit of guidance on what to check.
Current Behavior

Context

Steps to Reproduce (for bugs)

Your Environment

Build scan URL:

This would be really nice, in cases when one might want to put that pom in a resource like a jar; the constant invalidation would really be a pain.
If DefaultMavenPublication had an onPopulated listener, it could be configured to wait until the full set of MavenDependencys are known, and then use those to populate a sane up-to-date check.

I have a reasonable workaround:
tasks.withType(GenerateMavenPom) {
    onlyIf {
        if (!destination.exists()) {
            return true
        }

        def pomGenerator = new MavenPomFileGenerator(pom.projectIdentity, versionRangeMapper)
        pomGenerator.configureFrom(pom)
        pom.apiDependencyManagement.each { dependency ->
            pomGenerator.addApiDependencyManagement(dependency)
        }
        pom.runtimeDependencyManagement.each { dependency ->
            pomGenerator.addRuntimeDependencyManagement(dependency)
        }
        pom.importDependencyManagement.each { dependency ->
            pomGenerator.addImportDependencyManagement(dependency)
        }
        pom.apiDependencies.each { dependency ->
            pomGenerator.addApiDependency(dependency)
        }
        pom.runtimeDependencies.each { dependency ->
            pomGenerator.addRuntimeDependency(dependency)
        }
        pomGenerator.withXml(pom.xmlAction)
        def tempFile = file("${destination}.tmp")
        pomGenerator.writeTo(tempFile)

        return destination.getText('UTF-8') != tempFile.getText('UTF-8')
    }
}

This at least stops it writing the file again, so downstream tasks like jar and test don't have to run again, but I'd at least prefer not to have to duplicate the logic of GenerateMavenPom. Still, this might demonstrate what the task itself could do to avoid it.


[KYUUBI #1536] Add session conf advisor

Why are the changes needed?

closes https://github.com/apache/incubator-kyuubi/issues/1536
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #1892 (6d1f35f) into master (677e2a4) will increase coverage by 0.07%.
The diff coverage is 76.19%.

@@             Coverage Diff              @@
##             master    #1892      +/-   ##
============================================
+ Coverage     59.77%   59.84%   +0.07%
- Complexity      322      323       +1
============================================
  Files           291      294       +3
  Lines         14234    14269      +35
  Branches       1805     1806       +1
============================================
+ Hits           8508     8539      +31
  Misses         5002     5002
- Partials        724      728       +4

Impacted Files
Coverage Δ

...la/org/apache/kyuubi/session/AbstractSession.scala
93.25% <0.00%> (-1.13%)
:arrow_down:

...pache/kyuubi/plugin/DefaultSessionConfAdvisor.java
0.00% <0.00%> (ø)

...a/org/apache/kyuubi/plugin/SessionConfAdvisor.java
0.00% <0.00%> (ø)

...g/apache/kyuubi/session/KyuubiSessionManager.scala
94.87% <0.00%> (-2.50%)
:arrow_down:

.../org/apache/kyuubi/session/KyuubiSessionImpl.scala
84.61% <81.81%> (+1.28%)
:arrow_up:

.../scala/org/apache/kyuubi/plugin/PluginLoader.scala
90.00% <90.00%> (ø)

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
95.85% <100.00%> (+0.02%)
:arrow_up:

.../kyuubi/sql/watchdog/ForcedMaxOutputRowsBase.scala
0.00% <0.00%> (ø)

...rg/apache/kyuubi/engine/trino/TrinoStatement.scala
69.87% <0.00%> (+2.40%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 677e2a4...6d1f35f. Read the comment docs.

thanks, merging to master


fix pkg-config files

helps with ImageMagick/ImageMagick#4029

This repository is for the Windows build of ImageMagick. We will update this when there is a new release of brotli.


linux SCTP support part 2 (revival)

Description
Revival of https://github.com/rust-lang/libc/pull/3117
Adds SCTP structs and constants.
Changes from original PR:

Rebased
Added missing SCTP_ADDR_POTENTIALLY_FAILED enum variant

Sources
https://github.com/torvalds/linux/blob/master/include/uapi/linux/sctp.h
https://man7.org/linux/man-pages/man7/sctp.7.html
Checklist

[x] Relevant tests in libc-test/semver have been updated
[x] No placeholder or unstable values like *LAST or *MAX are
included (see #3131)
[x] Tested locally (cd libc-test && cargo test --target mytarget);
especially relevant for platforms that may not be checked in CI

Apologies for multiple pushes, I wasn't aware that --autosquash doesn't do anything without -i

Powepc seems to die to SIGILL, but it passes locally when running the same suite:
Caused by:
  process didn't exit successfully: `qemu-ppc -L /usr/powerpc-linux-gnu /checkout/target/powerpc-unknown-linux-gnu/debug/deps/main-00ed33f9c2abd801` (signal: 4, SIGILL: illegal instruction)

Locally:

Anyone encountered this?

Sorry, no idea how to debug this PPC issue.


[DOC] how does flagd handle merge conflicts?

Change in the documentation
Given that flagd can read from multiple flag sources, if multiple sources contain the same flag key, which "wins"?
file1.json
{
  "flags": {
     "flagOne": {
      "state": "ENABLED",
      "variants": {
        "on": true,
        "off": false
      },
      "defaultVariant": "on"
    }
  }
}

flag2.json
{
  "flags": {
     "flagOne": {
      "state": "ENABLED",
      "variants": {
        "on": true,
        "off": false
      },
      "defaultVariant": "off"
    }
  }
}

Start flagd to read from both
flagd start \
  --port 8013 \
  --uri http://example.com/flag1.json \
  --uri flag2.json

So flagOne is set to both on and off. Which "wins"?

This is explained in the CLI but needs to be added to docs to be more accessible:
When flag keys are duplicated across multiple providers the merge priority follows the index of the flag arguments, as such flags from the uri at index 0 take the lowest precedence, with duplicated keys being overwritten by those from the uri at index 1. Please note that if you are using filepath, flagd only supports files with .yaml/.yml/.json extension.

Hey @agardnerIT, does this doc answer your question?
https://github.com/open-feature/flagd/blob/main/docs/configuration/flag_configuration_merging.md


Feature/Swiftlint Run Script Build Phase

Description
Added a RunScriptHelper to enable local linting during development.

@bdrelling

LGTM, do we need to update the swiftlint_run_script_.sh script in Shared-iOS?

Already done!

@bdrelling

LGTM, do we need to update the swiftlint_run_script_.sh script in Shared-iOS?

Already done!


It doesn't have a good effect on generating real person faces

It doesn't have a good effect on generating real person faces

Fine-tuning on real-person scan datasets or using a human-specific base model may alleviate this problem.


Memory leak per execution for CompiledCode

From @mattomopt on September 10, 2015 21:57
IronPython seems to leak memory every time I set a variable via compiled Python scripts.  The memory seems to get collected if I let the CompiledCode object go out of scope, but I want to be able to reuse one CompiledCode many times because of the speed benefits.  The leak does not happen when I execute the ScriptSource instead of CompiledCode.  It also doesn't happen when I set the variables in the scope via ScriptScope.SetVariable instead of setting them in Python.
Setting values this way:
d = dict()
d[1] = 1
d[2] = 1
d[3] = 1
# ......
d[100000] = 1

leaks much faster than:
d = dict()
for i in range(1, 100000):
    d[i] = 1

I have reproduced the issue using the below program in 64-bit .NET 4.5 with both IronPython 2.7.4 and 2.7.5.  The Script.py I used is similar to the first Python script above: I set 100000 dictionary entries individually.  Other variations of the C# program I have tried that do not help with the leak:

Using LightweightScopes = false
Using ExecuteAndWrap instead of Execute
Creating a new ScriptScope for each execution
Setting the dictionary variable to be a .NET dictionary in in the program instead of declaring it in Python
Building the script from a string rather than a file

    public static class Program
    {
        public static void Main()
        {
            var engine = Python.CreateEngine(
                new Dictionary<string, object> { { "Debug", false }, { "LightweightScopes", true } });
            var scope = engine.CreateScope();
            var script = engine.CreateScriptSourceFromFile(@"Script.py").Compile();
            for (var i = 0; i < 100000; i++)
            {
                script.Execute(scope);
                GC.Collect();
            }

            Console.ReadKey();
        }
    }

If it helps, I ran the above leaking program in windbg and after many loop iterations, here are the biggest heap stats given by "!dumpheap -stat":
              MT    Count    TotalSize Class Name
000007fee85b0178      326         8627 System.Boolean[]
000007fee85b0a50      125        10000 System.Signature
000007fee859b0b8       20        11424 System.Collections.Hashtable+bucket[]
000007feefa481a0      299        11960 Microsoft.CSharp.RuntimeBinder.Syntax.NameTable+Entry
000007fee858c7e8       94        12032 System.Text.SBCSCodePageEncoding
000007fe8f7ee7a8      305        12200 IronPython.Runtime.Operations.StringOps+EncodingInfoWrapper
000007feefa49788      121        12584 Microsoft.CSharp.RuntimeBinder.Semantics.AggregateType
000007fee85bc370      226        12656 System.Reflection.Emit.OpCode
000007feefa49500       62        16368 Microsoft.CSharp.RuntimeBinder.Semantics.MethodSymbol
000007feefa48730       80        17920 Microsoft.CSharp.RuntimeBinder.Semantics.AggregateSymbol
000007fe8f7ef7d0        1        22080 System.Collections.Generic.Dictionary`2+Entry[[System.String, mscorlib],[IronPython.Runtime.Operations.StringOps+EncodingInfoWrapper, IronPython]][]
000007fee85b0e98      192        23040 System.Reflection.RuntimeParameterInfo
000007fee8592690     1467       164304 System.Reflection.RuntimeMethodInfo
000007fee859d610     2992       167552 System.RuntimeType
000007fee859b320     3764       193132 System.String
000007fee859e070      240       420368 System.Int32[]
000007fe8f8a55c8    99999      2399976 Microsoft.Scripting.Interpreter.DynamicInstruction`4[[System.Object, mscorlib],[System.Object, mscorlib],[System.Object, mscorlib],[System.Object, mscorlib]]
000007feed613088   100000      2400000 System.Linq.Expressions.ClearDebugInfoExpression
000007fee859d960   100051      2401224 System.RuntimeTypeHandle
000007fee85a1300   100064      2401536 System.RuntimeMethodHandle
000007fe8f867e58   100000      3200000 IronPython.Compiler.LookupGlobalInstruction
000007feed61e560   100003      3200096 System.Linq.Expressions.AssignBinaryExpression
000007feed61e208   100009      3200288 System.Linq.Expressions.ListArgumentProvider
000007fee85ef938   100030      3200960 System.Reflection.Emit.GenericMethodInfo
000007feed61bc18   100000      4000000 System.Linq.Expressions.SpanDebugInfoExpression
000007feed61f0a8   100002      4000080 System.Linq.Expressions.MethodCallExpression2
000007fe8f80f3c8   100008      4000320 IronPython.Compiler.LookupGlobalVariable
000007fe8f95d130    99999      4799952 System.Runtime.CompilerServices.CallSite`1[[System.Func`5[[System.Runtime.CompilerServices.CallSite, System.Core],[System.Object, mscorlib],[System.Int32, mscorlib],[System.Int32, mscorlib],[System.Object, mscorlib]], mscorlib]]
000007fe8f8a8720    99999      4799952 System.Runtime.CompilerServices.CallSite`1[[System.Func`5[[System.Runtime.CompilerServices.CallSite, System.Core],[System.Object, mscorlib],[System.Object, mscorlib],[System.Object, mscorlib],[System.Object, mscorlib]], mscorlib]]
000007fe8f82b058    99999      4799952 IronPython.Compiler.PythonDynamicExpressionN
000007fe8f80a5c0    99999      4799952 IronPython.Compiler.Ast.IndexExpression
000007fe8f80a998   100000      4800000 IronPython.Compiler.Ast.AssignmentStatement
000007feed60dbe8    99999      5599944 System.Linq.Expressions.DynamicExpression3
000007fe8f809aa0   100001      5600056 IronPython.Compiler.Ast.NameExpression
000007fe8f8a85d0   100001      6400064 System.Func`5[[System.Runtime.CompilerServices.CallSite, System.Core],[System.Object, mscorlib],[System.Object, mscorlib],[System.Object, mscorlib],[System.Object, mscorlib]]
000007fee85cade0   200004      6400128 System.Reflection.Emit.GenericFieldInfo
000007feed61e3a0   200008      6400256 System.Linq.Expressions.Block2
000007fee859e0d0   299405      7185720 System.Int32
000007fe8f84c958   299552      7189248 Microsoft.Scripting.Interpreter.LoadObjectInstruction
000007fe8f801ea8   199999      7999960 IronPython.Compiler.Ast.ConstantExpression
000007feed61e720   200000      8000000 System.Linq.Expressions.Block3
000007fe8f8428b0   200000      8000000 Microsoft.Scripting.Interpreter.DebugInfo
000007feed60c040   400022      9600528 System.Linq.Expressions.ConstantExpression
000007fe8f7712d0       14     10073568 IronPython.Runtime.CommonDictionaryStorage+Bucket[]
000007feed61e458   400013     12800416 System.Linq.Expressions.BlockExpressionList
000007fee859f498       99     14199148 System.Byte[]
000007feed2c99b0   500023     16000736 System.Collections.ObjectModel.ReadOnlyCollection`1[[System.Linq.Expressions.Expression, System.Core]]
0000000000736640    15294     19583260      Free
000007fee857f5e8   301116     35046696 System.Object[]

Copied from original issue: IronLanguages/main#1228

From @jdhardy on November 15, 2015 17:22
Long delay, for which I'm sorry - can you provide Script.py?

@jdhardy Does https://github.com/IronLanguages/main/pull/1250 fix this as well?

From @mattomopt on November 16, 2015 14:20
Thanks for the reply.  I attached the two scripts described above here.
LeakingScript.txt
NonLeakingScript.txt

From @mattomopt on January 4, 2016 20:28
I tried pulling and testing that fix on my own.  It does not seem to help with my case.

From @jdhardy on December 14, 2015 3:31
Haven't checked yet. The trigger seems to be a bit different than the other cases but I haven't compared it yet.


Fix bug #647 - Legend Items are always "clickable"

closes #647

Nice work! I like these PRs your doing, they're great.


Consider adding a feature for showing scriptableobjects

This thread explains exactly what I'm looking for
https://forum.unity.com/threads/editor-tool-better-scriptableobject-inspector-editing.484393/
It seems to be the kind of feature your package could have.

That'd be a nice addition!
Currently, we've been using this solution: https://gist.github.com/tomkail/ba4136e6aa990f4dc94e0d39ec6a058c
I'm thinking of doing something similar but bind the drawer to an Attribute so one could choose when to draw the ScriptableObject inline.

I did it on Lawendts Unity Utilities.
I extended the drawer to have the create button and the scriptable object display on an attribute. If you want I can open a PR with this!

Feel free to :)
I forgot to add that, in fact, we use your version (empty SO fix) of that script link I posted ahhahaa

Opened #13 with requested feature!

It's now merged! Thanks!


Update sources

:robot_face: Updating sources to the latest version.
Commits touching OCaml packages:

ocamlPackages.sedlex: remove at 1.99.5
ocamlPackages: rename sedlex_2 into sedlex
ocamlPackages.sedlex: 2.4 → 2.5
ocamlPackages.bwd: init at 2.0.0
ocamlPackages.yuujinchou: init at 2.0.0
ocamlPackages.cooltt: unstable-2021-05-25 → unstable-2022-04-28
ocamlPackages.resto:  0.6.1 -> 0.7
ocamlPackages.json-data-encoding: 0.10 -> 0.11

Diff URL: https://github.com/NixOS/nixpkgs/compare/fa66e6d444f37c80d973d75fd3e0d28e286d8ea4...49a2bcc6e2065909c701f862f9a1a62b3082b40a

This one has more changes then the one you merged @anmonteiro


Integration tests flaking, timing out waiting for broker to come up

Opening a separate issue for this flake, as #643 started to become a general hub for all flaky behavior.
Integration tests are intermittently failing with error:
[Build & Unit/Integration Tests] --- FAIL: TestBasicFlows (40.09s)
[Build & Unit/Integration Tests]     controller_test.go:113: error waiting for broker to become ready: timed out waiting for the condition

Can be seen in Jenkins builds #173 and #178.

[Build & Unit/Integration Tests] I0407 17:04:32.483384    3217 request.go:991] Response Body: {"kind":"Broker","apiVersion":"servicecatalog.k8s.io/v1alpha1","metadata":{"name":"test-broker","selfLink":"/apis/servicecatalog.k8s.io/v1alpha1/brokerstest-broker","uid":"33296edb-1bb4-11e7-8034-0242ac110002","resourceVersion":"18","creationTimestamp":"2017-04-07T17:04:02Z","finalizers":["kubernetes"]},"spec":{"url":"https://example.com"},"status":{"conditions":[{"type":"Ready","status":"False","reason":"ErrorSyncingCatalog","message":"Error syncing catalog from Broker"}]}}
[Build & Unit/Integration Tests] --- FAIL: TestBasicFlows (40.10s)
[Build & Unit/Integration Tests] 	controller_test.go:113: error waiting for broker to become ready: timed out waiting for the condition
[Build & Unit/Integration Tests] 	framework.go:58: Shutting down server on port: 37268

It'll be nice to have more errors in the conditions to have a bit more info.
Going by the ErrorSyncingCatalog we've got the catalog, but can't parse it, or can't reconcile it.

Which is very confusing, because at no point are we actually running a broker, right? It's all a mock broker.

Correct, and it is confusing me too. Whittled on this last night for quite a while to no effect.

Observed in https://travis-ci.org/kubernetes-incubator/service-catalog/builds/219893348

cc/ @rifung

A few notes here:

As @MHBauer said, we are not actually running a broker server
The error shown is strictly about the success condition not showing up on the Broker resource

I believe this error is now fixed. Here is my hypothesis on what was happening:

the secure catalog API server started up, but the insecure port is 8080
because the insecure server couldn't serve on 8080, the k8s.io/apiserver package tried to restart both the secure & insecure servers (I have verified that this behavior happens in practice)
before it restarted, the Broker resource was submitted and the controller-manager picked it up and began reconciling it
the catalog API server shut down
the controller-manager hit the fake CF broker's catalog endpoint, then called the catalog API server to update the ready condition
because the catalog API server was not running at the time of the condition update, the ready condition was never set on the Broker resource
the controller test waited for 30 seconds (wait.ForeverTestTimeout) for the ready condition to be set, but it never was

Note that (1) has been fixed by @krancour's #695. This ensures the the API server can always run successfully.
I have pulled that change down, run integration tests 5 times on my machine, and haven't been able to repro. Before that change, I was able to repro this issue about once every 5 runs, so #695 has likely at least reduced the frequency of this flake.

I don't think this is fixed -- I observed a race in travis with a PR rebased onto #695, but sadly have lost the link.

I don't think this is fixed -- I observed a race in travis with a PR rebased onto #695, but sadly have lost the link.

Ok, any additional information (the branch, PR, or travis link if you can find it) would be helpful here. Leaving this open.

Okay, here's another instance of the flake from #682: https://travis-ci.org/kubernetes-incubator/service-catalog/builds/221799879

I have some ideas about how to fix this one, gonna hack on it after I land some other stuff

I think the issue is this:

[Build & Unit/Integration Tests] I0407 17:04:02.620753    3217 request.go:991] Response Body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"serviceclasses "test-service" already exists","reason":"AlreadyExists","details":{"name":"test-service","kind":"serviceclasses"},"code":409}

It seems that maybe we reuse the service class "test-service" in multiple tests. I don't know enough about the test code but I imagine we're either running them in parallel or the delete is not being processed before we try creating a broker again.
Or I could be totally wrong but perhaps someone who knows better can chime in?

@rifung I believe that @pmorie had a similar hypothesis. Note that this behavior may be happening because the controller repeatedly fetches the catalog from the broker. After each fetch, it then tries to write service classes. If that's the case, this is a race.


hide shipyard containers in web

There is 7 containers for a shipyard host and 4 for a node.
It's a lot of messy in web
consider hide shipyard-related containers and images in web page for a cleaner look?

+1 For that. Having a filter to only show non-shipyard containers would be really, really great.

The filter I use for this is "!shipyard" in the search box.

@wouteroosterveld this is pretty great, but i wish this was default. having to type that in every time is a pain.

closing this since long time inactive


Update LND v0.17.2 & recompile protobuffs

https://www.nobsbitcoin.com/lnd-v0-17-1-beta/

done. Closing for release candidate


add PubMed Search and US reference

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   49.67%   49.67%
=======================================
  Files          14       14
  Lines         155      155
  Branches       43       43
=======================================
  Hits           77       77
  Misses         78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33f17f...cacaf45. Read the comment docs.


Fix Style/ClassAndModuleChildren offense

From #752. Expecting the AR3 builds to fail for now.

If I understand correctly, this PR adds a dependency on mocha. I'd rather not add any dependencies, if possible. Can we move this test to rspec instead?

Agreed

All for not adding dependencies :+1: I'll move the test

Closed by https://github.com/airblade/paper_trail/pull/767


List of Material Module Names : Doc

Bug, feature request, or proposal:
No documentation to quickly find the Material component module names, since MaterialModule and MaterialRoodModules are deprecated.
What is the expected behavior?
One would want to quickly look up material component module name to include or create own set of moudule
YOUR MATERIAL MODULES  (For the component / element name  just remove the 'Module' part from the module name - some may not match exactly)
In most cases
Module Name = ComponentName +"Module"
ComponentName = ModuleName - "Module"
const YOUR_MATERIAL_MODULES = [
MdAutocompleteModule,
MdButtonModule,
MdButtonToggleModule,
MdCardModule,
MdChipsModule,
MdCheckboxModule,
MdDialogModule,
MdGridListModule,
MdIconModule,
MdInputModule,
MdListModule,
MdMenuModule,
MdProgressBarModule,
MdProgressSpinnerModule,
MdRadioModule,
MdRippleModule,
MdSelectModule,
MdSidenavModule,
MdSliderModule,
MdSlideToggleModule,
MdSnackBarModule,
MdTabsModule,
MdToolbarModule,
MdTooltipModule,
OverlayModule,
PortalModule,
RtlModule,
StyleModule,
A11yModule,
PlatformModule,
CompatibilityModule,
ObserveContentModule
];

I really would have liked to see the MaterialModule maintained by the team with docs strongly suggesting you create your own only containing the modules you use before going to production. The lack of the "all components module" slows down prototyping and raises the barrier to entry. At the very least, a canonical list of modules should be maintained

Where would you expect this documentation to live?

It's a tough one, one of those things (like maintaining the module) that is overhead on your end - is it something that is a candidate to be generated with build tooling etc?

Even if it were autogenerated, I'm not sure there's a discoverable place for it.

I'd like to see the list of components, the module names maintained - as a reference page , automatically generated  in 'material.angular.io'.  It could be under the 'Guide' line as 4th one.  Developers always like to see a cheatsheet kind of look of the technology, the reference page will serve that purpose. (I do) . This avoids ton of clicks to just to find one syntax or so and we also don't like to remember if working in fullstack with many tools and languages, which is the norm these days.

What's the reason to deprecate MaterialModule anyway, wouldn't it be better to simply mention in the getting started guide that the best practise is to create your module containing only the modules you use, but alternatively, if you don't care about the size or you plan to use everything, you can use MaterialModule.

Worth noting rxjs' approach:

To import the entire core set of functionality:
...
To import only what you need by patching (this is useful for size-sensitive bundling):
...

IMHO the getting started guide should just list all available modules. You can warn the user to only add the ones they need (as is already the case), but a getting started guide should help a newcomer to get an app started as quickly as possible. Having to figure out which modules there are and what they are named is a lot of overhead when likely already learning a lot of new stuff.
I don't think we'd need a module that is part of the library – simply listing them in the getting started guide would already help a vast majority of people.

For some reference, I tried to add a date picker into a newly created app right now. After figuring out that I need MatDatepickerModule, I was greeted by an error that I needed a date adapter. The log message helpfully named the moment adapter, but it couldn't be found, so eventually I settled for the native adapter for now. Next up was a cryptic error message for which I found the solution in #7898, namely having to also import MatInputModule.
This kind of investigative work just to get started is IMHO too much.

It's been more than 8 months, is there still no canonical list of module names?

@Airblader I agree that the docs can be improved... but... "The type of values that the datepicker expects depends on the type of DateAdapter provided in your application." that should give a hint ;)
It'a a lot to read but I think it's all there.. right?

It'a a lot to read but I think it's all there.. right?

I don't think so. As I said, this information would mostly be useful to newcomers to material2 – they will have a hard time understanding what to do. We could help them get started tremendously if we had a simple way of telling them which modules to import. We should want users to get started as quickly and painlessly as possible; when you start out, there are more important things to worry about than to investigate how to even set things up. :-)

I like the concept of having all the modules listed in ONE place, BUT I just started trying to use Material, following the instructions in the GUIDE, and now I find all the modules are MAT something and I can't get them all to satisfy references in the examples (expansion is what I'm working with).  Is the above list vastly out of date or am I missing something?

Some modules depend on each other. A good way to get something specific to work is to open the example from the docs in Stackblitz and seeing how it sets up the modules.

Closing this since I think the main thing I would want to do is tracked in #15340. As it stands, I think the list of components is pretty clear from the docs site as well as the pattern for component --> module name (Mat___Module)

Closing this since I think the main thing I would want to do is tracked in #15340. As it stands, I think the list of components is pretty clear from the docs site as well as the pattern for component --> module name (Mat___Module)


Arango & ArangoSH running in docker

It seems that when I run this, it attempts to find an arangosh script. However, I'm running arangodb in Docker so arangosh isn't immediately available to the script. Any suggestions on how to resolve this?

Migrado was originally designed to be used only from within a Docker context, but we opted to drop this requirement in 8958de1 (0.5.2). It is currently used as part of a web framework where arangosh is available.
To use Migrado on its own with Docker containers, you could either install arangosh, or run Migrado itself from a Docker container, e.g. using something akin to the Dockerfile used for testing.
I believe arangosh itself actually uses the ArangoDB HTTP API, so arangosh may not actually be a hard requirement. Scripts can be run against /_admin/execute with certain limitations. Give me a couple of hours, and I'll add some alternatives.

Thanks for taking the time to do that. Very kind of you. This definitely closes out the issue as I was able to run the script from docker as you have illustrated in the readme.


#245 Set download_model path extension to .pt

Description
Please include a summary in English, of the changes in this pull request. If it closes an issue, please mention it here.
Closes: #245
You should link at least one existing issue for PR. Before your create a PR, please check to see if there is an issue for this change.
PRs from forked repository not accepted.
Change(s)

Set download_model path extension to .pt
They are in compress_model, recommendation_compression and recommendation_compression methods.

Sorry for reverting a commit.
I didn't recognized there is FRAMEWORK_EXTENSION_MAP.
I simply fixed FRAMEWORK_EXTENSION_MAP value to onnx file transformed to .pt


show workspace folder and Test Adapter label

for tests which fails to load
Before:

After:

Thanks!


Fixed number codec and added tests

Codecov Report

Merging #79 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
+ Coverage     74.29%   74.37%   +0.07%
- Complexity      655      656       +1
============================================
  Files            85       85
  Lines          1957     1963       +6
  Branches        196      196
============================================
+ Hits           1454     1460       +6
  Misses          362      362
  Partials        141      141

Impacted Files
Coverage Δ
Complexity Δ

...of/bson/codecs/number/SmofNumberCodecProvider.java
90.9% <100%> (+10.9%)
3 <1> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c5efe5...71c5a37. Read the comment docs.


Formatter reset problem

Hi Christophe,
Looks like there is an issue with formatter.
$client = ClientBuilder::create()
->addDefaultLocalConnection()
->setAutoFormatResponse(true)
->build();
$query = "MATCH (member:Member {username:'member_1'}) RETURN member";
$result1 = $client->sendCypherQuery($query)->getResult();
$query = "MATCH (member:Member {username:'member_2'}) RETURN member";
$result2 = $client->sendCypherQuery($query)->getResult();
When I run first query and check result1 I see that there is only one node in it, which is the expected result. But after running second query, both result1 and result2 has 2 nodes (member_1 and member_2) in them.
Looks like formatter keeps its internal state between queries. There is a reset function in ResponseFormatter but I could not find any reference to it.

Ho thanks for the report, I'll try to run this behavior and report here .

Thank you very much. This has been fixed in #32 . Release 2.1.1 coming.


Potential data loss when used in combination with CloudStack CSI driver

/kind bug
What steps did you take and what happened:
When CAPC is used in combination with the CloudStack CSI driver, there is a potential for data loss when a CloudStackMachine gets destroyed (f.e. in a rollout or scaling-down scenario).
CAPC offers the possibility to create an additional data volume upon creation of a CloudStackMachine by passing a spec.diskOffering.id or spec.diskOffering.name. This is analogous to the behavior of deployVirtualMachine, where a data volume gets created when a diskofferingid and size are passed.
These volumes also need to be cleaned up again, and so DestroyVMInstance does a call to listVolumes to get a list of volumes associated with the VM and passes them using SetVolumeids to the call to DestroyVirtualMachine.
When using the CloudStack CSI driver, PVC's are CloudStack volumes attached to the VM, and since there is no distinction made on which volumes get deleted, any attached PVC at the time of the deletion of the CloudStackMachine also gets instantly destroyed and expunged, leading to data loss.
What did you expect to happen:
Some form of distinction between automatically created datavolumes made during deployVirtualMachine and datadisks attached to the VM at a later stage. Tagging could be an option. Right now the only way i figured out how to make the distinction is that the automatically created volume on deployVirtualMachine is always named DATA-<someID> as can be seen in CloudStack.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Cluster-api-provider-cloudstack version: latest
Kubernetes version: (use kubectl version): 1.29
CSI driver 0.6.0
OS (e.g. from /etc/os-release):

Fair to say it’s an unsupported combination, so probably not a CAPC bug but an improvement to have it work with the CSI driver. cc @Pearl1594 @vishesh92 @weizhouapache


[Decompiler]Low-level Error: Shared type id

Please take a look at the attachment. These two type doesn't have same type id.
To Reproduce
Steps to reproduce the behavior:

download stdin.gz
gzip -d -c "stdin.gz"|decompiler
Low-level Error: Shared type id:<PHONE_NUMBER>000ea

Screenshots
If applicable, add screenshots to help explain your problem.
Attachments
If applicable, please attach any files that caused problems or log files generated by the software.
Environment (please complete the following information):

Ghidra Version: 9.2.2

Additional context
Add any other context about the problem here.

Please feel free to apply this kludge.
0001-a-kludge.patch.txt
Below are changes involved.
Thanks.
Ghidra/Features/Decompiler/src/decompile/cpp/type.cc : (TypeEnum::compareDependency) Fix Enum type comparison.
(TypeCode::restoreXml) Mark flags before base method is called.

Reproducing the error.  Thank you for the report.


Phantom errors, caching issues.

Swift version
swiftlang-<IP_ADDRESS>, 6.0-dev (490cf64aee23f13)
Platform
macOS 14.3.1
Editor
VSCode with Swift extension 1.10.2
Does the issue reproduce with Swift 6?
Yes
Description
LSP (in my case running in VSCode) very often reports errors, that do not in fact exist in the code.
The context here is an empty project, just a "Hello, world":

Here you can see that it complains about identifier v10_14 not being in scope, when .v13 is used (I did put v10_14 there before, the issue here is that it didn't update).

After multiple removals of .build, restarts and re-builds, it finally got it - but then I changed swift-tools-version to 5.6 and it started reporting that v13 is not available yet - okay, I bumped the version to 5.8 and it keeps reporting the same error:

I also encountered issues in another project where the LSP was reporting that a class member did not exist, while at the same time showing me the definition of that field right below the error...
Note that after I add a product and target, the package will build just fine when running swift build, there are no compilation errors, but the LSP will continue to report those kinds of errors.
For me, it happens very often when working on Swift code and it makes it a chore rather than a pleasure. There is no way to get rid of those phantom errors other than by removing the .build, restarting the editor, reloading LSP and hoping that finally it will work - in case of bigger projects, fully re-building them all the time is obviously terrible and sometimes it doesn't even work! Sometimes I need to fully re-build them multiple times, which makes no sense.
Steps to Reproduce

Create a folder and a Package.swift file.
Put this into Package.swift:

// swift-tools-version:5.9
import PackageDescription

let package = Package(
    name: "MyPackage",
    platforms: [
        .macOS(.v13)
    ]
)

Change version on the top to 5.6 and save the file.
Change version back to 5.9 and save the file.
Change the tab to another file and the error will pop up.

Logging
No response

Synced to Apple’s issue tracker as rdar://130144910

FYI, I enabled logging in the VSCode extension to look at what requests are sent to the LSP and it looks like LSP does not report any error there, so (in this case) it might actually be a bug in the extension:
[Trace - 1:43:15 PM] Sending request 'textDocument/hover - (123)'.
Params: {
    "textDocument": {
        "uri": "<< path to project >>/Package.swift"
    },
    "position": {
        "line": 7,
        "character": 6
    }
}

[Trace - 1:43:15 PM] Received response 'textDocument/hover - (123)' in 23ms.
No result returned.

It looks like the diagnostics you see lingering around are from compilation, not SourceKit-LSP (it shows swiftc after the error message, not SourceKit or sourcekitd) and those diagnostics are managed by the Swift extension for VS Code. I can’t move this issue to the VS Code extension repo at the moment, because it’s a different organization, so I filed an equivalent issue over there: https://github.com/swiftlang/vscode-swift/issues/920.


fix(filters): prevent crashes when start_date == date.min

Description
Some reports may include bogus values for start_date, like the date.min value. In that situation, DefectDojo would crash; the bug is not really in DefectDojo, but a bit of defensive programming won't hurt, and we want to avoid a crash even with invalid data.
When that happen, we'll use date.min as start_date rather than date.min - timedelta(days=1) which cannot exist in Python.
Test results
We do have an (internal, home made) scanner that (used to) produce such invalid result, and this patch fixes the issue.
Documentation
N/A
Checklist
This checklist is for your information.

[x] Make sure to rebase your PR against the very latest dev bugfix.
[x] Bugfixes should be submitted against the bugfix branch.
[x] Give a meaningful name to your PR, as it may end up being used in the release notes.
[x] Your code is flake8 compliant.
[x] Your code is python 3.11 compliant.
[ ] Add the proper label to categorize your PR.

I cannot add the bugfix label to my PR, but that's what it is!

Can you also write a unittest for it? If your report contains sensitive info, feel free to anonymize it.

@kiblik sure thing. Could you guide me a bit on how to do that (or point to a documentation)? Where should I store the scan result to test?

@kiblik sure thing. Could you guide me a bit on how to do that (or point to a documentation)? Where should I store the scan result to test?

https://documentation.defectdojo.com/contributing/how-to-write-a-parser/

OK I did read that but how can I be sure that the code I'm fixing is already tested somehow? Do I need to write a specific test for that? In the meantime I have added a test sample file anyway.
The provided test file would currently create this 500 error when navigating to e.g. /finding/open:

@p-l- your unit test could first create a finding with the "bad date" and then invoke the filter class that you are making the change to in this PR in the same way that the /finding/open view does. This would ensure that the exception is handled if the test passes

@Maffooch Thanks. It seems that the results are not sent to the database, so my test won't work. Do you have any idea what the easier way to test it could be?

Could put your test here: https://github.com/DefectDojo/django-DefectDojo/blob/master/unittests/test_finding_model.py

Closing as stale

Yep sorry @mtesauro @Maffooch I did not find the time to create a working test :-/

@p-l-

Yep sorry @mtesauro @Maffooch I did not find the time to create a working test :-/

No need to apologize - I appreciate the work you did to and we can always pick this back up and write a test. Life happens to everyone - feel free to do a PR anytime in the future. :+1:


UGRID tests now account for multiple grids in a single file

Adapted the UGRID checks to look into all mesh_topology grids, instead of just one. Additionally, removed the .nc resource files in lieu of more compact .cdl versions of the same files. References #6
@brianmckenna
@Bobfrat

@Bobfrat @brianmckenna Travis tests passed (re-added the .nc files)


Backbone.History.checkUrl: URI malformed error

If URI has special symbol "%" checkUrl throws URIError exception
How to reproduce:

Hook Backbone Router to /search?q=fat 30%
Change URL to any other.
Got "Uncaught URIError: URI malformed in checkUrl

Yes -- that is indeed a malformed URL. You're responsible for correctly encoding your URLs before passing them to the router.

Seems like it is still failing for me even for encodedURI uri "/#fat%3A1.5%25" ("fat:1.5%")
It is actually ":" character not "%" causing checkUrl to fail.
According to the RFC3986[1] colon char is one of the reserved for usage in the URI
so it needs to be encoded properly.
[1] - http://tools.ietf.org/html/rfc3986#section-2.2
But in the checkUrl call segment we are calling this.getFragment() which returns decoded URI
and we trying to decode it again in the checkUrl call which causing URIError: URI malformed error.
I am trying to fix this in my pull request which was tested in the latest Chromium and Firefox.
I've spend sometime trying to add it as a test in the test/router.js but it looks no so easy as was should to be ...
So here is code to reproduce the URIError: URI malformed error
var history = new Backbone.History();
history.start();
var router = new Backbone.Router({testing: 101});
var q = "fat:1.5%";
router.navigate('search/fat');
router.navigate('search/'+encodeURIComponent(q));
router.navigate('search/fat');

Ping,
let me know if I am doing something wrong or I can help in some other way


Typo in the examples

As you can see below, the example codes are using  "$user_ids" as a variable
Then that variable is used as parameter in the New-CsBatchPolicyAssignmentOperation :   ... " -Identity $users_ids" ..
The problem is that the variable is called "user_ids" but in the command is changed to "users_ids" (extra 's' after 'user')
So when you copy/paste the code and run it,  you get an error saying that "$users_ids is null"
$user_ids = Get-Content .\users_ids.txt
New-CsBatchPolicyAssignmentOperation -PolicyType TeamsAppSetupPolicy -PolicyName "HR App Setup Policy" -Identity $users_ids -OperationName "Example 1 batch"
Thanks
JP

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 888fe05b-1160-452f-90ba-deb19adb740f
Version Independent ID: 4091c5e4-7a90-7fe4-2741-16bbb1f297c1
Content: Assign policies to users and groups - Microsoft Teams
Content Source: Teams/assign-policies-users-and-groups.md
Service: msteams
GitHub Login: @KarliStites
Microsoft Alias: kastites

Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@scanum this can be closed thank you.


Using Snorkel with non-text-based inputs

Reading through most of the documentation and working through the tutorials it seems Snorkel is being specifically targeted for generating labels for unstructured text. Am I wrong in wanting to use it for labeling structured text/numeric data (e.g. web logs)? If so, should I go and create a new set of classes like Corpus -> Document -> Sentence -> Span. or should I reuse these classes and fit my problem into that structure?

Hi @gallamine ,
Snorkel is primarily focused on the problem of extracting structured data from unstructured input sources.  Currently, of different types of unstructured data, we are focused on supporting text, and next up to be merged in very soon, tables and similar "semi-structured" inputs.
The method behind Snorkel--data programming--is a much more general framework for weakly supervising models, and Snorkel also could be applied more generally, and you're right that you would go about this by creating a new context hierarchy; but I don't have a great idea of whether or not it will be worth the effort for your use case, since we mostly had the unstructured-to-structured case in mind!
Thanks,
Alex


Add current_time

Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝

[x] I have updated existing examples or added new ones (if applicable).
[x] My changes were added to the CHANGELOG.md in the proper section.

Extra:

[x] I have read the CONTRIBUTING.md guide and followed its instructions.

Pull Request Details 📖
Description
Closes #1139
This adds time::current_time to get the system uptime.
On ESP32 it uses the (mostly undocumented) LAC timer - same as esp-idf.
On all other chips it uses Systimer.
Testing
The timer_interrupt example is changed to use the API.
I also changed esp-wifi to use it and everything worked fine. (It might also improve performance on Xtensa targets but I didn't benchmark it)

I've tried this out locally and all is working fine!
Could we add a small basic test case to assert that current_time increases? I know its simple, but it will at least tell us if for whatever reason (most likely on the esp32) if it broke. Having this break would be pretty bad for esp-wifi :D


how to use multi-gpu

Sorry..., we currently do not support the distributed training. Maybe you can refer to distributed training in dgl.


Allow separate callbacks for market data and user data stream

v3.3.1 Allows us to specify separate callbacks for market and user data. This would help to manage both types of messages separately.
websocketClient.instant_subscribe(stream=instruments, callback=marketDataMethod)
websocketClient.user_data(listen_key=client.new_listen_key()['listenKey'], id=1, callback=userDataMethod)

v4.0.0rc1 We have to specify callback methods at initialization level. With this implementation for each message received, 1 additional CPU cycle will be required just for the filtering between different types of messages.
websocketClient = UMFuturesWebsocketClient(on_message=marketDataMethod)
websocketClient.subscribe(stream=['btcusdt@kline_1m', 'ethusdt@kline_1m'])
websocketClient.user_data(listen_key=client.new_listen_key()['listenKey'],id=1)

Thanks for the feedback.
In v3, each method will create a new socket connection, which make it possible to hook callback for each connection.
From v4, we only maintain only one connection, which is easy to maintain and reduce the potential problem.
There are 2 solutions:

Multi websocket clients;  You could attach different call back to each client.
Handle event logic behind the on_message call back.  Websocket messages has the event type, which can be used to identify for different process.


lut element build failures

I'm seeing a pretty common pattern of some jobs with large LUTs end up with some fraction of elements (usually < 15-25%) fail to build, with MODTRAN specifically.  Based on the outputs, it appears they fail fairly early (no tp6 to be found).
I'm guessing this has to do with the way the calls are made (and very well be an issue with overwhelming the license server), and the intermittence leads me to suspect it may also be OS / scheduler specific.
Options to explore:

Consider alternative calls (os.system, pipe, etc)
Consider checking for file completion within spawn_rt

The second is fairly inelegant for a variety of reasons, but may be necessary if 1) doesn't pan out.
If anyone else observes similar behavior to what's described above, it would be helpful to know.

This seems to definitely be a MODTRAN issue - getting no complaints with other RTMs, so closing the issue.


Survey index should be designed to display aggregate data for researchers and providers

Providers should actually also see this from their home page.

Messaging added in 58c849fd9f1744f4eeae470dc5a2deb7111cea4f