StandardMaterial Light Transmission

Objective

This PR adds both diffuse and specular light transmission capabilities to the StandardMaterial, with support for screen space refractions. This enables realistically representing a wide range of real-world materials, such as:

Glass; (Including frosted glass)
Transparent and translucent plastics;
Various liquids and gels;
Gemstones;
Marble;
Wax;
Paper;
Leaves;
Porcelain.

Unlike existing support for transparency, light transmission does not rely on fixed function alpha blending, and therefore works with both AlphaMode::Opaque and AlphaMode::Mask materials.
Solution

Introduces a number of transmission related fields in the StandardMaterial;
For specular transmission:

Adds logic to take a view main texture snapshot after the opaque phase; (in order to perform screen space refractions)
Introduces a new Transmissive3d phase to the renderer, to which all meshes with transmission > 0.0 materials are sent.
Calculates a light exit point (of the approximate mesh volume) using ior and thickness properties
Samples the snapshot texture with an adaptive number of taps across a roughness-controlled radius enabling “blurry” refractions

For diffuse transmission:

Approximates transmitted diffuse light by using a second, flipped + displaced, diffuse-only Lambertian lobe for each light source.

To Do

[ ] Figure out where fresnel_mix() is taking place, if at all, and where dielectric_specular is being calculated, if at all, and update them to use the ior value
[x] Add transmission_texture
[x] Add diffuse_transmission_texture
[x] Add thickness_texture
[ ] Add attenuation_distance and attenuation_color
[ ] Connect values to glTF loader

[x] transmission and transmission_texture
[x] thickness and thickness_texture
[x] ior
[ ] diffuse_transmission and diffuse_transmission_texture (needs upstream support in gltf crate)

[x] Add support for multiple screen space refraction “steps”
[x] Conditionally create no transmission snapshot texture at all if steps == 0
[x] Conditionally enable/disable screen space refraction transmission snapshots
[ ] Read from depth pre-pass to prevent refracting pixels in front of the light exit point

Changelog

Introduces diffuse_transmission, transmission, thickness and ior to the StandardMaterial
Introduces a new Transmissive3d render phase for rendering specular transmissive materials with screen space refractions
Adds a NotTransmittedShadowReceiver component for disabling shadows in (diffuse) transmitted light.

A couple of notes:

We should rename things to show that this is specular transmission only, not diffuse.
For the dithering, look into the PCF code. Using the same stochastic IGN sampling when TAA is enabled might lead to better dithering.
Look into downsampled/blurred mip pyramids instead of dithering. Might be lower artifacts / cheaper (if lots of transmissive materials).
Look into how to handle total internal reflection.
This falls under the umbrella of screen space global illumination (SSGI). Along with SSAO (occlusion), SSIL (diffuse), and SSR (specular). SSR techniques in particular are very applicable to you, see the links below. For now whatever you get working is great, but eventually I'd like to combine them all into one module/component, and try to share code where possible. Something to refactor when all that is implemented, however :)

https://www.ea.com/frostbite/news/stochastic-screen-space-reflections
https://github.com/GPUOpen-Effects/FidelityFX-SSSR/blob/master/docs/FFX_SSSR_Technology.pdf

Another way of faking refraction, is to use the environment map instead of sampling from the screen. I'm not sure this is worth bothering to implement though, as it's lower quality then a screen space method.

We should rename things to show that this is specular transmission only, not diffuse.

Now that we have diffuse, we could rename transmission to specular_transmission, but might make sense to keep it as just transmission to remain consistent with glTF. Thoughts?

For the dithering, look into the PCF code. Using the same stochastic IGN sampling when TAA is enabled might lead to better dithering.

👍  Haven't had time to look into that yet, but will do.

Look into downsampled/blurred mip pyramids instead of dithering. Might be lower artifacts / cheaper (if lots of transmissive materials).

(Same as above)

Look into how to handle total internal reflection.

Gave it a lot of thought/reading, and if I understand it correctly, implementing TIR in a useful way (that takes the shape of the back-side of a mesh into account) will likely require introducing an additional depth + normal pre-pass, just for the backside.
We could try a second-lobe based approach similar to what we have for the diffuse transmission, but since the thickness-based volume is implemented as always having an exit normal exactly the same as the entrance normal we get almost useless results.

This falls under the umbrella of screen space global illumination (SSGI). Along with SSAO (occlusion), SSIL (diffuse), and SSR (specular). SSR techniques in particular are very applicable to you, see the links below. For now whatever you get working is great, but eventually I'd like to combine them all into one module/component, and try to share code where possible. Something to refactor when all that is implemented, however :)
https://www.ea.com/frostbite/news/stochastic-screen-space-reflections
https://github.com/GPUOpen-Effects/FidelityFX-SSSR/blob/master/docs/FFX_SSSR_Technology.pdf

👍

Another way of faking refraction, is to use the environment map instead of sampling from the screen. I'm not sure this is worth bothering to implement though, as it's lower quality then a screen space method.

Might be worth it for mobile, and we also need it as a fallback for when the depth test (which I haven't implemented yet) results in a pixel in front of the entrance point.

Now that we have diffuse, we could rename transmission to specular_transmission, but might make sense to keep it as just transmission to remain consistent with glTF. Thoughts?

Rename it to specular_transmission imo.

Look into how to handle total internal reflection.

If we can't get TIR cheaply, oh well. Not a big deal.

There are still additional improvements to be made, but this PR is is now in a sufficiently completed stage where I'm comfortable taking it out of draft mode, to get broader feedback/reviews.
I'm looking for feedback particularly on:

Whether or not the changes I made to expose the main texture view, and the way I'm copying it to the transmission texture raises any performance or compatibility red flags;
The names of the StandardMaterial properties themselves, and the overall preference between glTF spec consistency versus more descriptive/internally consistent names; (e.g. transmission vs specular_transmission)
The names of other behind the scenes methods/properties;
Whether or not this should be put behind a cargo/compile-time flag, or under a Plugin, or behind a #define
If the overall math I'm using checks out;
How well this is performing, especially with multiple screen space transmission steps; (Can someone help me profile this to understand how expensive the screen space effect is?)
Any bugs/compatibility issues/visual artifacts?
Is there any feature this is likely to not interact well with I should test specfically?

Updated this to now include a TAA shader def, that way it doesn't vary the noise pattern with time when TAA is disabled.

Warning
Running this right now requires merging in https://github.com/bevyengine/bevy/pull/8553, otherwise you'll get the following error:
Thread 'main' panicked at 'Requested resource bevy_render::renderer::render_device::RenderDevice does not exist in the > `World`.
               Did you forget to add it using `app.insert_resource` / `app.init_resource`?
               Resources are also implicitly added via `app.add_event`,
               and can be added by plugins.', crates/bevy_core_pipeline/src/taa/mod.rs:286:35

I think PR currently breaks all 3d examples that use the StandardMaterial on webgl. Here's with the 3d_scene example:
Caused by:
    In Device::create_render_pipeline
      note: label = `pbr_opaque_mesh_pipeline`
    Error matching ShaderStages(NONE | FRAGMENT) shader requirements against the pipeline
    Shader global ResourceBinding { group: 0, binding: 16 } is not available in the layout pipeline layout
    Binding is missing from the pipeline layout

', C:\Users\DGriffin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\wgpu-0.16.1\src\backend\direct.rs:3019:5

Some 3d examples that do not use the StandardMaterial are also broken on webgl. Here's with the array_texture example:
Caused by:
    In Device::create_shader_module
Shader '' parsing error: no definition in scope for identifier: 'prepass_depth'
    ┌─ wgsl:750:13
    │
750 │         if (prepass_depth(vec4<f32>(modified_offset_position * view.viewport.zw, 0.0, 0.0), 0u) > frag_coord.z) {
    │             ^^^^^^^^^^^^^ unknown identifier
    no definition in scope for identifier: 'prepass_depth'

I tested both of these on current bevy main and they appear to be working as expected.
Note that the transmission feature will not work on webgl in general due to:
Caused by:
    In Device::create_render_pipeline
      note: label = `pbr_opaque_mesh_pipeline`
    Internal error in ShaderStages(NONE | FRAGMENT) shader: WGSL `textureLoad` from depth textures is not supported in GLSL

First half of my review consisting of just the Rust code. Shader code will be a separate review.

👍

Quality is generally excellent - I especially like that the transmission docs are fairly understandable to the average person, i.e. it's clear transmission is about light going through a mesh, commonly used for wax/glass/etc. Maybe we want to mention skin?

Thanks!
Re: Skin, I don't think this looks particularly convincing for skin just yet, since we don't really support subsurface scattering. You might be thinking about some of the SSS screenshots I posted some time ago. These were using a barebones version of SSS I had in the works in a separate branch, but it required a lot of additional changes, notably refactoring lights to return the attenuation, diffuse and specular components separately (kinda like environment map lights) And it likely wouldn't be ready in time for 0.11, so I put it aside so we could review and land this PR first.

I think this PR currently breaks all 3d examples that use the StandardMaterial on webgl. Here's with the 3d_scene example:

Ouch. I'll add a shader def guard to prevent this from happening. The effect should degrade (mostly) gracefully even without the depth prepass.

@DGriffin91 I pushed this change which makes the other examples no longer crash under WebGL by guarding both usage and definition of the texture bindings in the shader with the same conditions we use to set up the BindGroupEntry and BindGroupLayoutEntry. Can you confirm that this makes it so that we at least do not regress the existing examples?
Now, for the transmission example: Even if I add guards to disable things like TAA, Prepass and HDR, the transmission example is still crashing under WebGL, with an error message about conflicting samplers being used for the same texture:
[Log] ERROR  Conflicting samplers for _group_0_binding_1_fs log.target = "naga::back::glsl"; (wasm_example.js, line 368)
log.module_path = "naga::back::glsl";
log.file = "/Users/coreh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/naga-0.12.0/src/back/glsl/mod.rs";
log.line = 3867;

[Log] ERROR  Shader translation error for stage ShaderStages(NONE | FRAGMENT): A image was used with multiple samplers log.target = "wgpu::backend::direct"; (wasm_example.js, line 368)
log.module_path = "wgpu::backend::direct";
log.file = "/Users/coreh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-0.16.0/src/backend/direct.rs";
log.line = 1174;

Group 0 Binding 1 is the Lights uniform for the PBR shader, so I doubt it's actually the shader that's failing compilation. Searching for @group(0) @binding(1) yields a bunch of results, but these either AFAIK not applicable to the example, or (t the best of my understanding) don't use different samplers for the same texture in the shader code. This leads me to think that this is either a Naga bug, or perhaps Naga is using something like a blit shader internally to emulate the texture copy we request during the prepass phase under WebGL, and that's not working properly for some clash with something on our end, or we are using different samplers and I somehow missed it.
I'll try to continue debugging it, but if I can't figure it out in time for 0.11, we might need to disable (screen space) transmission under WebGL.

⚠  Most importantly, if I understand it correctly, I believe there's something fundamentally inconsistent/wrong with how we're approaching conditionally exposing the depth texture with regards to WebGL compatibility: We expose a depth texture binding without a matching sampler, and since a valid translation for WGSL's textureLoad() is not available under WebGL, even if we add guards like I did in https://github.com/bevyengine/bevy/pull/8015/commits/6573485dcda048cc47768ae661dde62d73acf489 to prevent the binding from being accidentally used in the shaders when it's not properly configured, and you disable MSAA, making it available,  there's no actual useful use for it since you can't read it without a sampler.

@coreh I think you'll also need to disable bloom. As noted above with this code we are still sampling prepass_depth in webgl when msaa is off.
Additionally, with this PR all 3d examples are no longer working on webgl when msaa is disabled.
If I try the 3d_scene example with Msaa::OFF, initially I get this error because of the issue noted above:
Internal error in ShaderStages(NONE | FRAGMENT) shader: WGSL textureLoad from depth textures is not supported in GLSL
And then if I comment out the part with prepass_depth(), I then get this error:
wasm.js:394 panicked at 'index out of bounds: the len is 16 but the index is 16',

I know this has been pretty much ready for awhile, but sadly given that we merged the shader import model changes this now has conflicts. The latest changes could also use reviews and there aren't any approvals yet. I'm regretfully pushing this to 0.12. We should prioritize getting this reviewed and merged early in the cycle as this is really cool stuff!

No problem! Even without the conflicts, given the size of the PR it's completely understandable not risking merging it this late in the 0.11 cycle.
I'll update it next week to use the new import model, so it's ready for 0.12.
With the changes in this PR, we're also fully using the WebGL sampler/texture binding limits for the standard material, (in fact I had to make some of the textures only available in other backends, gated by a feature flag) We might want to introduce a mechanism for dynamically allocating them.

@cart Updated to use the new import mechanism. This is now working again with the latest changes from main.
@JMS55 Added a comment about the “average” of matrix basis vectors to the code.
@DGriffin91 I tweaked the shader defs to work under WebGL, and then further tweaked them under the new import mechanism (since that restricts #define only to the root) I also added a feature flag for some of the extra textures that were causing us to hit WebGL limits, so it's AFAIK all running normally under WebGL: I tried both transmission as well as a bunch of other examples.

Rather then basing it on the TAA component, can we base it on the temporal jitter component, so things like FSR/DLSS will work in the future? Iirc that's what I did with SSAO.

Rather then basing it on the TAA component, can we base it on the temporal jitter component, so things like FSR/DLSS will work in the future? Iirc that's what I did with SSAO.

Is that just replacing #ifdef TAA with #ifdef TEMPORAL_NOISE?

@coreh, feel free to wrangle reviewers to get this in to 0.12 if it's ready in time, but for now I'm bumping it to 0.13 since this isn't the sort of thing we should block on.

For the example, the background seems to change color when HDR is toggled which is kinda weird, but I think is existing behavior in bevy. Please also choose a lighter background though, it's hard to read the black text against it.
Please add an indicator to the example for what the current transmissive quality setting is.

For the example, the background seems to change color when HDR is toggled which is kinda weird, but I think is existing behavior in bevy.

Yeah, we need to convert the clear color to/from sRGB, on one of the modes, not sure which way around.

Please also choose a lighter background though, it's hard to read the black text against it.

I'll do the other way around, since the scene is moody, I'll make it black and use white text.

Please add an indicator to the example for what the current transmissive quality setting is.

👍

Maybe note that HDR also toggles bloom, as you did with depth prepass/TAA. I think this should be good to go once we solve the DEPTH_PREPASS shaderdef. I'll take another look in a bit.

@coreh lots of new conflicts from deferred rendering getting merged. There is strong sentiment among myself and the rest of the rendering crew to try to get this reviewed and merged for 0.12. Do you want help resolving those conflicts?

@cart Finished fixing all conflicts, however with the addition of the gbuffer texture binding, this PR was now unfortunately hitting an error in WebGL 2, because of the 16 textures limit (MAX_TEXTURE_IMAGE_UNITS) adopted by most browsers:

I have a working solution in this branch which is relatively non-disruptive to the current setup, but kinda ugly. It involves pre-allocating 32 BindGroupLayout for MeshPipeline, one for each permutation of:
multisampled: bool,
depth_prepass: bool,
normal_prepass: bool,
motion_vector_prepass: bool,
deferred_prepass: bool,

(in main we currently pre-allocate 2, one for when msaa_samples() > 1 and another for when it's == 1.
This solution also requires #ifdef guarding the respective bindings for each one of the prepasses, which is why I opened #10136.
If you're okay with this solution, I can clean up the code a bit more, extract it and open it up a separate PR for it, as it will be much easier to review without the noise of the whole transmission PR with it. I'm also open to suggestions of alternative approaches that might enable us to not hit the 16 texture unit limit in WebGL 2.

Much appreciated! I don't have opinions yet, but I'm taking a look now!

If you're okay with this solution, I can clean up the code a bit more, extract it and open it up a separate PR for it, as it will be much easier to review without the noise of the whole transmission PR with it. I'm also open to suggestions of alternative approaches that might enable us to not hit the 16 texture unit limit in WebGL 2.

I think this is our best solution atm. I agree that this is just an expansion of a pattern we're already using. I think the most controversial thing is pre-allocating every permutation (rather than doing it on demand). If we expand this pattern further, we will reach a point where that is no longer viable. But that seems like something we can easily iterate on if we decide it is an issue. For now it seems fine.

nice work as usual.

🥳  Thanks

the taa flickering in the starting view in the example is pretty bad. presumably this was improved by the fixes you accidentally brought in ... in the meantime it might be better to default to TAA off.

You mean in the "seams" between the refracted checkerboard tiles?

we should note somewhere that specular transmission won't transmit deferred materials (they will be excluded from the source transmission texture as they are rendered later).

It will! We capture it during the Transmissive3d phase and by then deferred meshes have already been rendered.

(Just modified the example to verify it, in the image above, the left cube is deferred and the right cube is forward.)

also i am not sure how the interaction between deferred and transmission on the same material works. it looks like it will be added to both phases as it stands, which is certainly not what we want. i think the checks for OpaqueRenderMode == deferred should also check for reads_transmission_texture, or the check on queueing the material to Transmission3d should be inside the check for forward.

We already explicitly exclude transmissive items from the prepass so they are not considered for deferred either: https://github.com/bevyengine/bevy/blob/6f2a5cb862d747c9068bf83996c6c1a9f9d3b901/crates/bevy_pbr/src/prepass/mod.rs#L849-L853

@coreh needs rebasing it seems

Fixed ✅

Great work @coreh and everyone else involved ❤🎉


[Bug]: Recognize inverted (white on black) qr-code or with complex design

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Code Scanner does not recognize inverted (white on black) qr-code or with complex design.
Steps To Reproduce

Try to scan any "white on black" qr-code or different design code
Scanner can't scan "white on black" qr-code and some colorful codes

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud 1.9.36

I'm having this problem, the code reader can't decode my QR code because it's an inverted QR code (white on black). Do you have any plans to resolve this issue?


Fix Milvus Conflicts

Description

Fix Milvus Conflicts
By Submitting this PR I confirm:

I am familiar with the Contributing Guidelines.
When the PR is ready for review, new or existing tests cover these changes.
When the PR is ready for review, the documentation is up to date with these changes.

Closing this since there are no active changes. Looks like the conflicts were resolved with the merge of fea-sherlock


Enable signed releases from build server

Can you please send me the link to the build server? Thanks!

http://www.griffenfeld.dk:8080/job/LockscreenDisabler/ - expect uptime to be < 99% though...

@LucasR93 Please close this issue once you've verified that the APK is signed properly and can be installed.

Yes, everything working as expected (version, signature)


Getting ENOENT error on Windows when using Gulp Protractor

Used Yeoman to generate an app with the Angular Gulp generator, getting this
$ gulp protractor
[16:34:45] Using gulpfile d:\Github\AngularMusicStoredotNet\FrontEnd\gulpfile.js
[16:34:45] Starting 'wiredep'...
[16:34:45] Starting 'scripts'...
[16:34:46] Starting 'injector:css:preprocessor'...
[16:34:46] Starting 'webdriver-update'...
[16:34:46] gulp-inject Nothing to inject into index.scss.
[16:34:46] Finished 'wiredep' after 1.09 s
[16:34:46] Finished 'injector:css:preprocessor' after 621 ms
[16:34:46] Starting 'styles'...
selenium standalone is up to date.
chromedriver is up to date.
[16:34:47] Finished 'webdriver-update' after 628 ms
[16:34:47] Finished 'scripts' after 1.53 s
[16:34:47] Finished 'styles' after 1.16 s
[16:34:47] Starting 'injector:css'...
[16:34:47] gulp-inject 1 files into index.html.
[16:34:47] Finished 'injector:css' after 9.19 ms
[16:34:47] Starting 'injector:js'...
[16:34:48] gulp-inject 3 files into index.html.
[16:34:48] Finished 'injector:js' after 430 ms
[16:34:48] Starting 'serve:e2e'...
[16:34:48] Finished 'serve:e2e' after 173 ms
[16:34:48] Starting 'protractor:src'...
Starting selenium standalone server...
[launcher] Running 1 instances of WebDriver
[launcher] Process exited with error code 1
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:1011:11)
at Process.ChildProcess._handle.onexit (child_process.js:802:34)
d:\Github\AngularMusicStoredotNet\FrontEnd\gulp\e2e-tests.js:25
throw err;
^
Error: protractor exited with code 8
Already looked here, https://github.com/mllrsohn/gulp-protractor/issues/10 and it looks like I'm having the same issue and was able to run the tests from the Git repo mentioned, but not sure what to do next.
Thanks,

Never mind. Turned out Java didn't get installed on the machine in question.


Improved TextEdit search usability & documentation

These changes make search() functionality usable in scripts by defining how to get the line and column numbers from the returned PoolIntArray.

It seems a bit convoluted to have to use enum values to index a 2-value array.
How about making result a Dictionary with line and column keys instead? (Breaks compat, so for 4.0.)

Ok, I was trying to keep compatibility but I don't mind changing the returned value to a dictionary.

Well if this PR is actually a bugfix on the order of line/col, we can likely merge as is for 3.2, and improve the API further for 4.0 (probably as part of #31739).

Sounds good!

Thanks!


parsing issue/weirdness with literal arrays in if

if true{log("x")[i,j]}
14:53:22.838 [ERR] parser error: 1: expected next token to be `]`, got `,` instead:
if true{log("x")[i,j]}
                  ^
14:53:22.838 [ERR] parser error: 1: no prefix parse function for `,` found:
if true{log("x")[i,j]}
                  ^
14:53:22.838 [ERR] parser error: 1: no prefix parse function for `]` found:
if true{log("x")[i,j]}
                    ^

()=>if true{log("x");[i,j]} //parses fine with ; but then generates the above which doesn't parse back
()=>if true{log("x")[i,j]}

probably because of index operator

also
a [0]
ie [] should be like () stuck to the left for it to be index and not array literal

the parsing is ok but the space is missing
$ ()=>if true{log("x");[i,j]}
== Parse ==> ()=>{if true{log("x") [i,j]}}
== Eval  ==> ()=>if true{log("x") [i,j]}

fixing in #191


Script assumes black background

2 problems with this:

first two lines of output look weird on white background
sript leaves terminal with black background after it exits

Thank you for your feedback @dimaqq
That sure is a good suggestion, I've updated the code to respect your original background color ;-)


Fix minor issues in the elasticsearch connector documentation

For prior discussion see also this issue in prestodb.  This PR is to fix points 2, 4 and 5 therein.
Further improvements may be of use to the description / explanation of JSONtype and JSONpath but unfortunately I'm out of depth there :( (as of yet anyway).

@cla-bot check

Superseded by recent changes to the Elasticsearch connector.


Can't use ES6 import/export

Hi there,
I had high hopes when I found that plugin because I wanted to develop my NodeJs Lambda's using the ES6 syntax.
I followed all the steps described in the README.md under the Usage with Babel section.
After I completed the setup I can successfully build and run the app in Docker by invoking sam local invoke  with this demo handler:
exports.helloFromLambdaHandler = async (event, context) => {
  try {
    response = {
      statusCode: 200,
      body: JSON.stringify({
        message: "hello world",
      }),
    };
  } catch (err) {
    console.log(err);
    return err;
  }
  return response;
};

which gives me the expected output
START RequestId: 6c8eca3c-36ee-4dac-8e0e-fffb00f1d256 Version: $LATEST
END RequestId: 6c8eca3c-36ee-4dac-8e0e-fffb00f1d256
REPORT RequestId: 6c8eca3c-36ee-4dac-8e0e-fffb00f1d256	Init Duration: 0.33 ms	Duration: 172.13 ms	Billed Duration: 200 ms	Memory Size: 128 MB	Max Memory Used: 128 MB
{"statusCode":200,"body":"{\"message\":\"hello world\"}"}%

but as soon I refactor the handler like that
export const helloFromLambdaHandler = async (event, context) => {
  try {
    response = {
      statusCode: 200,
      body: JSON.stringify({
        message: "hello world",
      }),
    };
  } catch (err) {
    console.log(err);
    return err;
  }
  return response;
};

I get this response
{
    "errorType": "Runtime.UserCodeSyntaxError",
    "errorMessage": "SyntaxError: Unexpected token 'export'",
    "stack": ["Runtime.UserCodeSyntaxError: SyntaxError: Unexpected token 'export'", "    at _loadUserApp (/var/runtime/UserFunction.js:98:13)", "    at Object.module.exports.load (/var/runtime/UserFunction.js:140:17)", "    at Object.<anonymous> (/var/runtime/index.js:43:30)", "    at Module._compile (internal/modules/cjs/loader.js:1063:30)", "    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)", "    at Module.load (internal/modules/cjs/loader.js:928:32)", "    at Function.Module._load (internal/modules/cjs/loader.js:769:14)", "    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)", "    at internal/main/run_main_module.js:17:47"]
}

Which means that Babel didn't compile the code back to ES5 I guess?
Here the content of babel.config.js
module.exports = {
  plugins: [
    "@babel/proposal-class-properties",
    [
      "@babel/plugin-transform-runtime",
      {
        regenerator: true,
      },
    ],
  ],
  presets: ["@babel/env", "@babel/typescript"],
};

and the content of my package.json
{
  "name": "demo",
  "description": "demo",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "test": "jest",
    "build": "webpack-cli",
    "clean": "rimraf .aws-sam .vscode",
    "prebuild": "rimraf .aws-sam .vscode",
    "prewatch": "rimraf .aws-sam .vscode",
    "watch": "webpack-cli -w"
  },
  "dependencies": {
    "@babel/runtime": "^7.13.10",
    "aws-sdk": "^2.863.0",
    "mysql": "^2.18.1",
    "source-map-support": "^0.5.19"
  },
  "devDependencies": {
    "@babel/cli": "^7.13.10",
    "@babel/core": "^7.13.10",
    "@babel/plugin-proposal-class-properties": "^7.13.0",
    "@babel/plugin-transform-runtime": "^7.13.10",
    "@babel/preset-env": "^7.13.10",
    "@babel/preset-typescript": "^7.13.0",
    "aws-sam-webpack-plugin": "^0.9.0",
    "babel-loader": "^8.2.2",
    "jest": "^26.6.3",
    "webpack": "^5.25.0",
    "webpack-cli": "^4.5.0"
  }
}

Changed the function body

@dittmarconsulting can you share how you're referencing the function in your template.yaml?

The mostly likely reason is a change in the way SAM locates the template file. If your template is named template.yml then rename it to template.yaml or upgrade to 0.10.0 when it's released.


pkg/bisect: prevent crash in bisection after failed repo HEAD query

test() expected to always get the current repo HEAD from build(), even
though this query can fail and return nil.
Furthermore build() didn't return the current repo HEAD in some of its
later error handling returns, even if the repo HEAD querry succeeded.
Returning the current repo HEAD where possible allows test() to perform
improved error logging.

I'll include a better version in a larger patch series soon.


BLE Driver

This is done when the ESP32C3 unit is able to broadcast itself over BLE, send relevant data to the app and store logs of its state.
To reach this there are subtasks that need to be done:

[x] Create a broadcast and connection module for the ESP32C3 so smartphones can find and connect to it
[x] Look into using the same protocol as the system to retrieve and send data to smartphone via BLE
[x] Create a module for streaming fake data for testing purposes

Are we ready to merge this?

Ready to be merged, but will wait until CAN is fixed on it aswell


Add more tests

Add more tests and fix a few failing tests related to cloning and updating repos

Some tests were added, maybe integration tests would be nice to have


[BUG] chat_downloader.errors.ParsingError

Basic information

Program version: v0.1.10
Python version: Python 3.6.5
Operating system:Ubuntu 18.04.1 LTS

Describe the bug
A clear and concise description of what the bug is.
raise ParsingError: Unable to parse initial video data when I try to get live chat messages
Command/Code used
url = "https://www.youtube.com/watch?v=EqUKTaxHiEE"
chat = ChatDownloader().get_chat(url)
Otherwise, if using the python module, provide the following:

A minimal reproducible example:

# python code
from chat_downloader import ChatDownloader
url = "https://www.youtube.com/watch?v=EqUKTaxHiEE"
chat = ChatDownloader().get_chat(url)

Output, traceback or other information relating to the bug:

Traceback (most recent call last):
  File "yt.py", line 297, in <module>
    main()
  File "yt.py", line 294, in main
    get_all()
  File "yt.py", line 280, in get_all
    chat = ChatDownloader().get_chat(url)
  File "/home/qqqqq3202390739/.local/lib/python3.6/site-packages/chat_downloader/chat_downloader.py", line 224, in get_chat
    chat = get_chat(match, params)
  File "/home/qqqqq3202390739/.local/lib/python3.6/site-packages/chat_downloader/sites/youtube.py", line 2078, in _get_chat_by_video_id
    return self.get_chat_by_video_id(match.group('id'), params)
  File "/home/qqqqq3202390739/.local/lib/python3.6/site-packages/chat_downloader/sites/youtube.py", line 2069, in get_chat_by_video_id
    initial_info, ytcfg = self._get_initial_video_info(video_id, params)
  File "/home/qqqqq3202390739/.local/lib/python3.6/site-packages/chat_downloader/sites/youtube.py", line 1453, in _get_initial_video_info
    video_id, params, video_type)
  File "/home/qqqqq3202390739/.local/lib/python3.6/site-packages/chat_downloader/sites/youtube.py", line 1378, in _parse_video_data
    original_url, params)
  File "/home/qqqqq3202390739/.local/lib/python3.6/site-packages/chat_downloader/sites/youtube.py", line 1349, in _get_initial_info
    raise ParsingError(f'Unable to parse initial video data')
chat_downloader.errors.ParsingError: Unable to parse initial video data
[output or description]

Expected behavior
A clear and concise description of what you expected to happen.
there's a live chat box for the video so I expect it should return live chat messages

Oh sorry it's a settings problem of my system.


fix(core): Re-throw the error if it's not a require error at require-search.ts

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] The changes are appropriately documented (if applicable).
[x] The changes have sufficient test coverage (if applicable).
[x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
This is a minor change to the error case handling at the plugin loading module search algorithm.
When going through the files at require-search.ts, only consume the MODULE_NOT_FOUND errors, and only for the modules we're looking for. The rest of the errors are actual errors, and shouldn't be manged, but communicated to the user.
Before, when you were loading a plugin that can be found, but throws an error at load time - the plugin would be ignored as if it wasn't there.
This eliminates the confusion of the plugin developers that don't expect this behavior.

Can there be a test for this to avoid regressions in the future?

I think it's doable - we need a file with sth like throw "test, and then assert that the resolution itself throws instead of returning null.
But I need help with repo structure - what's the right place for locating this fixture?

Try a subfolder in packages/api/core/test/fixture.

I added just a bare file at packages/api/core/test/fixture/throw.js. It seems to make more sense than having a subdir.

Can it be packages/api/core/test/fixture/require-search/throw-error.js? That way it's more obvious what the file is for.

Ok! Btw, how do I run just a single test?

Ok! Btw, how do I run just a single test?

The same way you normally would with mocha, use the --grep flag:
yarn test --grep='should throw if file exists but fails to load'

I added the test, but the test environment doesn't match my runtime. Accounted for it by adding another condition. It's quite odd, but this code is a niche thing, and it's kind of expected to have compatibility issues.


Implement Contract methods TS validation based on ABI

throw an error in starknet.js if input object has additional keys that cant be used as input arguments
https://github.com/seanjameshan/starknet.js/blob/d9ec6d3ea3cc0dbf3538fb2fe7b5e1d8a8831490/src/contract.ts#L76
As a dev it's annoying if you pass an object which looks right but don't get an error.
example: https://github.com/argentlabs/argent-x/pull/382
maybe somebody can pick tis up faster than I can.

Creted new Related Issue https://github.com/0xs34n/starknet.js/issues/514 on how to resolve

Have you considered using https://github.com/keep-starknet-strange/abi-wan-kanabi for this feature? I opened an issue  there regarding creating contract instances with type support for methods based on the ABI. Would that be a solution for this issue?

I'll be more than happy to take care of this issue


x/build: add LUCI linux-ppc64-power10 builder.

This will be the LUCI GOPPC64=power10 GOARCH=ppc64 GOOS=linux builder replacement for host-linux-ppc64-sid-power10.
It will share the same VM resources as host-linux-ppc64-sid-power10. The hostname should be linux-ppc64-power10.
Certificate attached: linux-ppc64-power10.csr.txt

Thanks. This is similar to #61274, except it's GOARCH=ppc64 and GOPPC64=power8.
CC @golang/release.

Here's the resulting certificate: linux-ppc64-power10-1702068073.cert.txt.
The builder definitions have been added in CL 548217 so your bot should be able to connect once you follow the rest of the steps on your end.

Thanks! I have one instance started and running.

That was fast, and we now have its first green build!
https://ci.chromium.org/b/8762240340084651697
Thanks very much. Would you like to keep this issue open (e.g., while you're adding more instances) a bit longer, or okay to close now?

Is the GOPPC64=power10 envvar configured for this builder? I didn't see it listed when I clicked through the log above. Should I be configuring that on the builder itself, or is the luci coordinator responsible for setting that?

Good point, it ended up as its default value of power8.
The optimal place to set it might be in our builder configuration, though it's also okay for you to do it in the builder's environment if that doesn't get in the way of something else.

Checking in on the status of this in progress new-builder issue. Is there more to do here before closing it?

@pmur Should this issue also be closed, or is there more to do for it?


ADR 945-Tests updated for Adjustment SPR Duty Rate page

Tests updated for Adjustment SPR Duty Rate page

Closing the pull request as we have issues with approval. The changes have already been merged to main via different pull request.


Stop repeating bot messages.

The gh-pages workflow repeats the message every time gh-pages are rebuilt. The change removes the repeats.

@oleksandr-pavlyk Ignore the error for the job. I wanted to ask if you know how the home directory for a github runner is selected? For example look at line 73 of the  GitHub Pages [PR] job. Why is the directory /home/runner/work/numba-dppy/numba-dppy? The linux upload was failing exactly for the same reason, the runner directory path does not reflect the new numba-dppy/numba-dpex structure and is thus unable to find stuff.

@oleksandr-pavlyk  Why is the directory /home/runner/work/numba-dppy/numba-dppy?

First numba-dppy is the name of the project in github. Second it created by git when cloning the repo.


With tinymce4 the filebrowser lacks the "insert button" column

tinymce3:

tinymce4:

project environment:
Mezzanine master (July 2, 2015)
Django 1.8.2

I was unsure if i should open this issue here or in the file browser_safe repo, but it is broken since tinymce4. So I suppose, this repo is the right one...

ok, i've understood why the select-column does not appear: The custom_file_browser-function has a parameter "pop=5" and in the filelisting.html filebrowser-template only the parameter "pop=2" to "pop=4" are handled. Simply copying one of the 2 to 4 sections to a 5-section doesn't work.
I'll try to dig deeper into it...

Feel free to use anything at http://p-o.co.uk/tech-articles/howto-use-tinymce-with-django-filebrowser-media-manager/ I've had TinyMCE V4 running successfully for well over a year.  The patch http://p-o.co.uk/files/filebrowser-to-tinymcev4.txt should help you get it up and running.

Thanks for the link, Alan. But i've already tried this and its not suitable for mezzanine with filebrowser_safe (it's working for django_filebrowser, I suppose). What I have to do is indeed working out the appropriate parts of this for mezzanine file browser_safe in its current configuration.

I tried to adapt Alans suggestions to the new mezzanine Version and now get an Error with in the file "tiny_mce_popup.js" which is not included in the django_filebrowser templates but in filebrowser_safe: [Error] TypeError: undefined is not a function (evaluating 'b.editor.windowManager.createInstance("tinymce.dom.DOMUtils",document)')
init (tiny_mce_popup.js, line 5)
global code (tiny_mce_popup.js, line 5)

Apparently the file "tiny_mce_popup.js" isn't any more part of the TinyMCE configuration, at least since it was moved from grapple-safe to mezzanine but the filebrowser_safe template "filelisting.html" references this file. Further more the "tinymce_setup.js" in mezzanine sets the pop parameter to 5 but the file browser_safe template "filelisting.html" does handle only 1 to 4. Seems like filebrowser_safe wasn't updated. Can anybody who is more familiar with this code give a hint?
Thanks,Christian

I looked at this today and mostly have it fixed, please hang tight.

Should be resolved by both 1844176e69fd9d847a5fdb71dffddcfafe9fdf00 and https://github.com/stephenmcd/filebrowser-safe/commit/a5e6f1246eddc31c2e79c2b9dd9302ffb21eb584 as also reported in #705


Feedback for basisghana

Hi, can you have a look at the README and let me know what you think? Thank you!

Great work, thank you. I like it a lot.
The only question I have is why you chose a log scale for the figure? Something you could try is to turn the percentages into categories (e.g. 4 with 25% per step) and then use 5 colours with increasing colour scale to show which regions are in which category.


Typings errors and can't import modules

Bug, feature request, or proposal:
Get the given error  below when i run ng serve in my angular project.
What is the expected behavior?
To start up and serve my app.
What is the current behavior?
I get this error:
ERROR in<EMAIL_ADDRESS>(22,40): ',' expected.
ERROR in<EMAIL_ADDRESS>(22,42): Type parameter name cannot be 'any'
ERROR in<EMAIL_ADDRESS>(36,14): Generic type 'MatDialogConfig<D, any>' requires 2 type argument(s).
ERROR in<EMAIL_ADDRESS>(50,15): ',' expected.
ERROR in<EMAIL_ADDRESS>(50,17): Type parameter name cannot be 'any'
ERROR in<EMAIL_ADDRESS>(50,90): Generic type 'MatDialogConfig<D, any>' requires 2 type argument(s).
ERROR in RangeError: Maximum call stack size exceeded
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31539:33)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31645:38)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31619:42)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31680:42)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31645:38)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31619:42)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31680:42)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31645:38)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31619:42)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31680:42)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31645:38)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31619:42)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31680:42)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31645:38)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31619:42)
    at isRelatedTo (/Users/rickardborjesson/Desktop/GreatSigns/angular-src/node_modules/typescript/lib/typescript.js:31680:42)

What are the steps to reproduce?
I could link my repo but not if it's unnecessary.
What is the use-case or motivation for changing an existing behavior?
I just want to know if this error know or not
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
@angular/cli: 1.4.9
node: 6.11.2
os: darwin x64
@angular/animations: 4.4.6
@angular/cdk: 2.0.0-beta.12-65d3630
@angular/common: 4.4.6
@angular/compiler: 4.4.6
@angular/core: 4.4.6
@angular/forms: 4.4.6
@angular/http: 4.4.6
@angular/material: 2.0.0-beta.12-65d3630
@angular/platform-browser: 4.4.6
@angular/platform-browser-dynamic: 4.4.6
@angular/router: 4.4.6
@angular/cli: 1.4.9
@angular/compiler-cli: 4.4.6
typescript: 2.2.2
Is there anything else we should know?
Im not using the the material Dialog. I just noticed that I get this error message: node_modules/@angular/material/material"' has no exported member 'MdProgressSpinnerModule'. when i try to import modules in my app.module.ts file:
app.module.ts
...
import { MdButtonModule,
        MdSlideToggleModule,
        MdRadioModule,
        MdProgressSpinnerModule,
        MdCheckboxModule } from '@angular/material';
...

Just realized you've changed from "Md.." to "Mat.."

i was getting the same error but the below piece of code solved my problem.... Havent properly tested it out though
change in
dialog-config.d.ts
export declare class MatDialogConfig<D = any> to
export declare class MatDialogConfig
and in
dialog-container.d.ts
_config: MatDialogConfig; to
_config: MatDialogConfig;
You will not get a webpack error but i still have to test out how the Components are going to behave
Can someone from the dev team confirm if this is correct??

You can sort out the issue by updating to TypeScript 2.4 or above.

The syntax errors are still an issue for me even with the latest version of typescript.
following the advice of ApoorvBarwa I change D=any to D in dialog.d.ts and dialog-config.d.ts  also changed MatDialogConfig to MatDialogConfig in dialog-container.ts

Landed here with same issue. While I can make the changes mentioned by kpayson and ApoorvBarwa to prevent errors, by following https://github.com/angular/material2/issues/8229 and manually adjusting package versions the issue is fixed without having to adjust code.
I tell VP of company that this package is a great fit and can get up and running quickly, so I show him by installing it but encounter problem after problem. He now has lost confidence in it, and its become something to poke fun at. The point is that it is much easier to fix code and documentation than bad impressions.

Updsting to the latest typescript version solved it for me! Got Angular CLI warnings due to it tho...


facebook response body parsed as a json object

Coverage remained the same at 49.63% when pulling 6b3ca9802f02ff6c002e17f4b73f9f2b32b5a4dc on funyx:master into 0dc13f9ac73fce7b4b14d0ae42c2c132721f5e84 on waterlock:master.

Coverage increased (+0.4%) to 50.0% when pulling 53fe7383cb813cbc648c21a824bd5c3c9ed94e4b on funyx:master into 0dc13f9ac73fce7b4b14d0ae42c2c132721f5e84 on waterlock:master.


License for plugin

Would you mind providing the license for this plugin as separate file checked into the repo e.g. LICENSE.txt or as part of the README.md file?

Done, added apache license file.


Add last move eval to PGN Editor

This way one can cut the ply, compute the eval, select just the ones that have a good position.

Implemented in v2.3.56


[Typography] $expressive-heading-03's line height is not changing between xlg and max breakpoints

$expressive-heading-03 has a size change at max breakpoint. This means line height should adjust accordingly. Currently on the website, the line height remains at 28px for all breakpoints
https://user-images.githubusercontent.com/15144993/134506681-7b21a1eb-5bab-4442-bf75-6f9fb5f02f4d.mp4

@shixiedesign Are you seeing this only on the website or just in code?


New behavior of Thor::Actions#directory

This is pull-request #175 condensed into one commit d02f275. You may refer to the discussion there.

@eventualbuddha, how is it going? If it matters I can rework the patchset to avoid the cukes while still doing CLI tests.


Update fuzz corpora

In the commit message, could you describe what the update does? Is it a new min-corpus? With better coverage? Does the corpus size grow? (The latter is relevant because we run the corpus as a unit test.)

I'll update the commit message, but it's always a min corpus with more coverage.  coveralls even shows that we have 0.5% more coverage in the test suite with it.  The asn1 corpus has the biggest change with 474 more files, but it also didn't get updated since the tests it does changed.
I'll try to come up with more details later this evening.

+1, just add that info to the commit message. We need to keep an eye on Travis so we don't choke it but for now seems fine.

Also, +0.5% is pretty sweet!

I thought I already added an x509 corpus, but it seems I didn't for some reason ...

  Note that all of the ways afl instruments the binary involves random numbers per .o file which results in the tuple count being non-deterministic.

@ekasper: So you're still happy with this?

@ekasper: ping

+1

Yes, still +1

Merged.


[video_player] green pixels and not full screen

i recently received a report from my users that video player has green pixels  also not full screen on some android boxes and android TVs

Can you share more information about the problem ? ... screenshot and logs

Can you share more information about the problem ? ... screenshot and logs
See the bottom gree line 👇

and see same video without green pixels app made with android studio (exoPlayer) 👇

Is your background color green ?
I think it's the style issue of the containers around the video widget, some widgets have standard dimensions for margin or padding.
Use DevTools to see which widget that green line belongs to.

Is your background color green ?
I think it's the style issue of the containers around the video widget, some widgets have standard dimensions for margin or padding.
Use DevTools to see which widget that green line belongs to.

No i didn't used green color i have multiple app with this problem it is VideoPlayer widget on some devices it show big part of screen as green color and video smaller than real size all other pixels are green, note: some videos doesn't have this problem i can give you a video link to test

Please use this to test if problem not exists please test on other devices too
https://ikomg2.mmdlive.lldns.net/ikomg2/107b7df8f5444d778f349100739a09cd/manifest.m3u8

Hi @davidgaspardev
I see there's an open issue addressing the case you described.
Please follow up on that issue, Closing as duplicate of https://github.com/flutter/flutter/issues/55090
If you disagree, please write in the comments and I will reopen it.
Thank you


No reviews.csv file

Hi
Where can i get the reviews the csv file?
please

Can someone please reply to the above issue?
Whole sections of the class are useless without the data file.
Thanks

also w2v_100d.pkl file would be helpful


No route matches for namespaced controllers - rails 3 -> 4 upgrade

I'm attempting to upgrade an app to Rails 4.2.1 and RSpec 3.2.0. I have several nested controllers and I'm getting quite a few errors. I'd like to point out that with Rails 3.2.21 and RSpec 2.14.1 this was working normally.
> bundle exec rspec spec/controllers/admin/address/primaries_controller_spec.rb
app/controllers/admin/address/primaries_controller.rb:1: warning: toplevel constant Address referenced by Admin::Address

Failure/Error: xhr :post, :create, params
   ActionController::UrlGenerationError:
     No route matches {:action=>"create", :address_primary=>{:street=>"69564 Dach Cliffs", :apt=>"405", :city=>"West Morrisview", :state=>"NY", :zip=>"00501", :addressable_attributes=>{:id=>"1"}, :addressable_type=>"Business"}, :controller=>"address/primaries", :field=>"primary_address"}
   # ./spec/controllers/admin/address/primaries_controller_spec.rb:26:in `block (4 levels) in <top (required)>'

This is the spec:
require 'rails_helper'
require 'admin/address/primaries_controller'

describe Admin::Address::PrimariesController do
  let(:address_attrs) { FactoryGirl.attributes_for(:primary_address) }
  context 'primary address' do
    let(:params) { { field:    'primary_address',
                     address_primary: address.merge(addressable) } }

    describe 'valid input' do
      let(:address) { address_attrs }

      it 'creates a new business primary address' do
        xhr :post, :create, params
        ... expectations ...
      end
    end
  end
end

So during the rails 4.2 upgrade I realized not only that rspec wasn't compatible, but several routing deprecation warnings were cleared up with an upgrade... so I had a pile of specs to fix anyway, so I ran transpec, upgraded the gem, ran transpec again, and here I am.
Another batch seems similar.
require 'rails_helper'

describe AppInformationController do
  context 'valid partials' do
    before { get :show, {id: template.to_s} }

    after { is_expected.to respond_with(:success) }

    context 'faqs' do
      let(:template) { :faqs }
      it { is_expected.to render_template(template) }
    end
  end
end

> bundle exec rspec spec/controllers/app_information_controller_spec.rb

Failure/Error: it { is_expected.to render_template(template) }
     expecting <"faqs"> but rendering with <["layouts/app_information/_navigation", "app_information/_title", "layouts/app_information/_start_works", "app_information/_faqs", "app_information/show", "layouts/application/_head", "layouts/application/_navigation", "layouts/application/_messages", "layouts/application/_footer", "layouts/application"]>

This seems different, but there are dozens of these, and they all show up around namespacing.
I've been googling for days... can I get some help headed in the right direction here?

RSpec 3.x is most certainly compatible with Rails 4.2, however I suggest you upgrade RSpec before upgrading rails. Run your app on RSpec 3.3 and Rails 3.2 and get it green before attempting to upgrade rails to figure out where the error is coming from

Oh, I know RSpec 3 and Rails 4 are fine. I was referring to RSpec 2 and Rails 4.2.

My advice still stands, as RSpec is back compatible it's worthwhile completing that upgrade before you upgrade your app (you can even still do this if you've already started with a bit of git foo ;)), we're well aware RSpec 2 doesn't support Rails 4.2 but we don't support RSpec 2 (in part because we've made so much effort to make upgrading painless)

I'm a little confused which version of rspec-rails and Rails you are reporting demonstrating the issue. Can you let us know which one has the error in question. Please also confirm that the issue you are asking about is the final one: expecting <"faqs"> but rendering with <["layouts/app_information/_navigation", ...
This looks like it's a controller spec, have you either added metadata type: :controller or set the `infer_spec_type_from_file_location! configuration option?

It is a controller. I have the infer_spec_type_from_file_location! there, but tried the manual way as well. No dice either way.
As for versions, this is the latest RSpec with the latest Rails.

Can you share your controller code? I'm most interested in the line of code you call for redirect_to or render for this action? As well as any view related defaults you setup else where in the control or parent controller.

Based on the error it looks like you are rendering a partial. Try which tends to have the convention that it is prefixed with an underscore. So while render partial: "faq" is acceptable in the controller, the actual file (template) is app_information/_faqs.html.erb (or slim or json etc). Try render_template(:_faq) to denote it is a partial.

Oh, and as for my question, I'm more concerned with the first issue. I was able to get around the rendering issue by using strings, and explicitly defining the template location, ie render_template('app_information/_faqs')
The 'no route matches error' is what really has me tripped up. that has something to do with namespacing, but I just can't get my finger on it.

The routing one is because somewhere along the line it's lost the 'admin' part...

I believe you may be calling Address somewhere in your code. Classes are just constants in Ruby. So the standard, sometimes unexpected, Ruby constant look-up rules still apply:
class Address
  def to_s
    "OUTTER"
  end
end

module Admin
  class Address
    def to_s
      "INNER"
    end
  end
end

class Admin::Controller
  def get_address
    # Really the top level ::Address
    Address.new.to_s
  end
end

module Admin
  class OtherController
    def get_address
      Address.new.to_s
    end
  end
end

puts Admin::Controller.new.get_address
puts Admin::OtherController.new.get_address

See also: http://cirw.in/blog/constant-lookup.html

Rail's version of autoloading also has some issues. See http://urbanautomaton.com/blog/2013/08/27/rails-autoloading-hell/ and http://guides.rubyonrails.org/autoloading_and_reloading_constants.html
I've never run into this, but a quick check of my work apps shows I don't really nest models in this fashion. I may nest similar controller names, but I don't have to models with the same name but different controllers...yet.

Address is a database backed model, yes. And it's a namespace.
namespace :admin do
  namespace :address do
    resources :primaries, only: [:create, :update]
    ...
  end
  ...
end

Admin is also a database model. Do I agree with that decision? No, I inherited this. I spent a bit of time trying to change the namespacing, but that rabbit hole got deep quickly.
Sounds like an issue with Rails, not RSpec, but the app works fine... just the specs are failing

Right ok, I missed it the first go around. Your error is (I adjusted the hash order here):
No route matches { :action=>"create", :controller=>"address/primaries", params...}

This seems to be loading the wrong scope, which is causing the problem. The warning about which Address is being loaded appears on line 1 of your controller:
app/controllers/admin/address/primaries_controller.rb:1: warning: toplevel constant Address referenced by Admin::Address

Is that just the following or something else?
class Admin::Address::PrimariesController < ActionController::Base

I would advise making sure all necessary parent constants are properly loaded prior to the files. This is really an issue with Ruby constant lookup semantics and Rails autoloading semantics. If necessary, in the controller class specify the nesting manually:
module Admin
  module Address
    class PrimariesController < ActionController::Base
    end
  end
end

It is likely the app runs fine because Rails preloads files for production and the order it loads things happens to be the order which makes this happy.

Admin is not a module (TypeError) and the actual page doesn't load anymore. Same error. http://guides.rubyonrails.org/autoloading_and_reloading_constants.html#nesting-and-qualified-constants seems to suggest that explicitly defining the modules is the preferred method as well.

Admin is not a module (TypeError) I'm guessing that code base has it defined as a class. You can still nest inside constants that are classes:
class Admin
  class Address # Unless this is also a module (i.e. ::Admin::Address)
    class PrimariesController < ActionController::Base
    end
  end
end

The only problem you now face is if this is loaded first, Rails will not autoload the actual class Admin, nor Admin::Address; which means those class def won't get autoloaded. Worse if you manually required those files after this one loads you'll get a superclass mismatch error.
The only way I see resolving this is to manually require the actual other class dependencies at the top of this file, in the order of admin, then the admin/address, and then finally allow this controller to get defined.
I'm going to close this as it's a Ruby constant lookup and Rails autoloading issue.


Hot reload with .net 6?

Hi,
now that .net 6 is already here is the functionality going to improve with hot reload and runtime unloading/reloading of plugins without restarting the application. with net 6 the multiplatform android,ios,mac etc support is also given by microsoft with blazor and all. whats the plan for this next update, what i am after is basically just blazor & hot reload currently.
thanks for such an awesome work

Thank you for the good question and sorry for the long delay in getting back to you. The better support for runtime unloading & updating & reloading is something which is planned to the version 2.0.
We're not yet sure how hot reload is going to affect things as that feature is currently targeted more for as a development time UI feature, allowing you to actively see the changes when you write XAML/Razor etc. That's at least our interpretation of hot reload for now.

thanks for the reply,
There are other plugin libraries that are giving feature of runtime unloading & reload. This is useful in plugin scenario as this enables changes to happen without pushing a big application to a complete restart cycle, where you will loos all your user sessions or other states you were maintaining with signalR or similar cases, think of a case where you just want to update a plugin based social login feature or a payment gateway without taking the whole site down... when you just want to change a small feature. I hope you got my point.
regards

@aloksharma1 can you share the other plugin libraries you've tried? Thanks!

@HybridSolutions sure you can find one here https://github.com/natemcmaster/DotNetCorePlugins, i found it pretty useful in my projects. although i had to customize a bit of code it was easy to implement with what was already provided out of box.


Fix empty/null condition edge-cases across ugit

I have overlooked handling edge-cases in multiple places, they need to be fixed for a more robut and error prone ugit.

handle no commit situation when undoing git commit, do not open the FZF menu.
return custom string when tags are not present while undoing git tag, again dont invoke FZF

Keeping this open to add more missed edge-cases as I discover. If you are looking to contribute please create separate PRs for each item listed above

I would like to work on these issues @Bhupesh-V

I would like to work on these issues @Bhupesh-V

Sure, please go through the codebase to find any other edge cases as well


Haberdasher example generate warning.

I'm trying the Haberdasher example from Twirp documentation here, but the generated code shows warning on GoLand IDE. The code can be run, just curious the reason why it is a warning. I attached the related image.

Scientific notation results in a float64 by default, but the compiler is smart enough to know that it is an int in this context. (Playground example)

Per @3ventic's comment, this appears to be an issue in Goland's hinting. Thanks for letting us know. Closing, as this doesn't appear to be a Twirp bug.


In Line.js s (s= is distance of intersection point from the ray position ) should be more accurate

Can the precision be increased like below
  // bail if it is behind our ray
      if ( s <  0.00000001  ) {
        return result;
      }

instead of
   // bail if it is behind our ray
      if ( s < 0.000001 ) {
        return result;
      }

Made the commit, let me know if it works as expected.

It's worked for me

Thanks  , closing #47


Update pubspecs & changelogs for latest feature

Prepare to release pkg:json_annotation v2.3.0

CC/FYI @lynn


[BEAM-14334] Fix leakage of SparkContext in Spark runner tests to remove forkEvery 1

Usage of forkEvery 1 is typically a strong sign of poor quality / bad code and should be avoided:

It often hides resource leaks, either in code or worse, potentially in the runner itself.
It significantly impacts performance when running tests.

This PR introduces new JUnit rules to better manage the lifecyle of SparkContext or SparkContextOptions and allows to safely reuse those for all tests of a suite where applicable. The previous ReuseSparkContextRule leaks the SparkContext and was removed. Besides, with forkEvery 1 trying to reuse the SparkContext is absolutely pointless ...
There's might be more issues hidden I didn't discover locally ... I'll keep a look.
This also reduce the runtime of tests to ~30 secs from 1:30+ mins.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Hmm, I noticed a related issue here. SparkContextOptions doesn't work with TestPipeline because providedSparkContext is ignored during the serde roundtrip to test that everything can be serialized before actually running the pipeline :/
IMHO providedSparkContext really doesn't belong into PipelineOptions, it can't be serialized and the resulting behavior is very inconsistent... tough that would be a breaking change. I suggest adding methods to set the provided Spark context to SparkContextFactory.  If a context is provided using SparkContextOptions, it will be stored in the factory using setProvidedSparkContext as well.
This also allows to clear the provided Spark context as well, allowing for much cleaner code.
  /**
   * Set an externally managed {@link JavaSparkContext} that will be used if {@link
   * SparkContextOptions#getUsesProvidedSparkContext()} is set to {@code true}.
   *
   * <p>A Spark context can also be provided using {@link
   * SparkContextOptions#setProvidedSparkContext(JavaSparkContext)}. However, it will be dropped
   * during serialization potentially leading to confusing behavior. This is particularly the case
   * when used in tests with {@link org.apache.beam.sdk.testing.TestPipeline}.
   */
  public static synchronized void setProvidedSparkContext(JavaSparkContext providedSparkContext)

  public static synchronized void clearProvidedSparkContext()

@echauchot I pushed one more commit with the change suggested above

I'll follow up with another PR to remove forkEvery 1 from the validates runner tasks

@mosche need to finish something and I take a look

@echauchot ping :)

@mosche sorry for the delay. I should be able to start your review by the end of the afternoon

@mosche reviewing ...

Usage of forkEvery 1 is typically a strong sign of poor quality / bad code and should be avoided:

It often hides resource leaks, either in code or worse, potentially in the runner itself.
It significantly impacts performance when running tests.

This PR introduces new JUnit rules to better manage the lifecyle of SparkContext or SparkContextOptions and allows to safely reuse those for all tests of a suite where applicable. The previous ReuseSparkContextRule leaks the SparkContext and was removed. Besides, with forkEvery 1 trying to reuse the SparkContext is absolutely pointless ...
There's might be more issues hidden I didn't discover locally ... I'll keep a look.
This also reduce the runtime of tests to ~30 secs from 1:30+ mins.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ]  Choose reviewer(s) and mention them in a comment (R: @username).
[ ]  Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ]  Update CHANGES.md with noteworthy changes.
[ ]  If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Bad smell indeed ! Thanks for catching this @mosche and reducing the test time

Thanks for the thorough review @echauchot 🙏  I should have addressed all your questions / comments. Let me know if anything is unclear


dark mode changes part 1

Remaining work for part 2:
1- 600+ more inline rgb definitions and more # color definitions to be processed - done
2- add manifest file for dark mode -done
3- move dark mode toggle to nav bar, available pre-login -done
4- test more - ongoing till 18th

visibility
contrast
look and feel
mobile/small screen
expandable screen
pages e.g. reference manager

5- css files e.g. for quill editor - done
6- Long term plan for color scheme for the website - post 18th
7- Need a dark mode version of the Logo.

PR is ready for review. Here're a few screenshots and a loom recording of how it looks:
Loom: https://www.loom.com/share/b42cad2fd79143428e4ac05a53a73df0?sid=3ca828f4-ad7d-48ea-b74f-fbb2aaae3442.
(I am running the backend and web app on my MacBook air and it's veery slow, however, hopefully gives an idea)

@nkkurt I reviewed your code (finally).
I really like how you structured the theme across files and utilized context to cascade the theme into different components.
I like the usage of the manifest as well. I think you were inspired by the MUI's implementation of dark theme - which is quite nice.
A few (hopefully) minor points of feedback.

Can we convert the .js files into .ts? While at it, I think it will be good to establish types returned through functions of these files for improved type safety
Made a comment about utilizing useEffect in GlobalStyles. Please take a look


linked-list: missing expectation

The test 'deletes the only element' is missing an expectation.
Needs an expectation added, or the test deleted. Maybe check with other language tracks to see if the test exists there, and what is being asserted on?

Yep. The same exercise on xecmascript is:
xit('deletes the only element', () => {
    const list = new LinkedList();
    list.push(10);
    list.delete(10);

    expect(list.count()).toBe(0);

});

Feel free to create a PR including the expect line.
Very well caught.

I've picked this up


Cannot find module 'util'

Issue Description
I use the faceapi in the rendering thread of electron. It is normal to run the browser, but the following errors will occur when starting with electron.
How should we solve it ?
thx

**Environment
electron15 + vue3

vue uses webpack and to create a bundle and it is being too smart for its own good - it tries to bundle all requirements regardless if they are for browser or node. you need to manually exclude them from webpack configuration
for example, take a look at https://github.com/vladmandic/face-api/issues/65#issuecomment-911956356

thx
I found that it was environmental judgment that was wrong,IS_BROWSER=IS_NODE=true in electron.
I edited esm file to deal with it. have any better way ?

electron creates global objects such as process that are normally available only in nodejs also available in browsers, so face-api cannot detect correctly if its running in node or browser
i dont use electron, but if you create a simple git with a reproduction, i'll take a look at what i can do

i just tried faceapi in pure electron and it works just fine:
import * as faceapi from<EMAIL_ADDRESS>
const log = (...msg) => document.getElementById('log').innerHTML += msg + '<br>';
log(`faceapi: ${faceapi.version} browser: ${faceapi.env.isBrowser()} node: ${faceapi.env.isNodejs()}`);
log(`tfjs: ${faceapi.tf.version['tfjs-core']} browser: ${faceapi.tf.ENV.get('IS_BROWSER')} node: ${faceapi.tf.ENV.get('IS_NODE')}`);

faceapi: 1.6.0 browser: true node: false
tfjs: 3.11.0-20211201 browser: true node: false

so your issue is configuration issue specific to electron + vue + webpack - something in your configuration is enabling both browser and node  environment
i'm closing this issue as its specific to this combination of frameworks and i cannot test every combination


TypeScript incorrectly narrows boolean type to true for variable updated within Map<...>.get(...)?.forEach(...) block.

🔎 Search Terms
"type narrowing", "map of set"
🕗 Version & Regression Information

This is the behavior in every version I tried (including v5.6.3 and 5.7.0-beta in playground)

⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.6.3#code/MYewdgzgLgBAtgQwA4HkBmBlAplAXDAWWQB5oAnASzAHMAaGbKUqSmgPjZgF4YwsB3QsgAUASgDcAKESpMOAHQQcwgEQBrLAE8V9PoMaqEK0RMmSANjhhoQIbjBYBXLFJnpG86svVbjAfnkbMgBRBGAAC2Exbk4Ab0kYa1t7NARzJSkAX1NJUEgQS3lzEGphGxBTIA
💻 Code
const mapOfSet: Map<string, Set<string>> = new Map();
mapOfSet.set("key", new Set("a"));

let foo = true;
mapOfSet.get("key")?.forEach(() => {
  foo = false;
});

console.log(foo);

🙁 Actual behavior
The foo variable is expected to be of type boolean because it may change to false within the .forEach(...) block. However, TypeScript incorrectly narrows foo's type to true, assuming it will not change.
🙂 Expected behavior
TypeScript should maintain the boolean type for the foo variable, as it can change to false inside the .forEach(...) block when the map's value is accessed and iterated over.
Additional information about the issue
No response

Duplicate of #9998.


x/crypto/openpgp: SerializePrivate output changes after loading with ReadKeyRing/ReadArmoredKeyring

What version of Go are you using (go version)?

$ go version
go version go1.13.8 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/go/github.com/koshatul/openpgp-hash-change/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build778545963=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I made a reproducible test koshatul/openpgp-hash-change.
When loading the private key from a file, and writing it back to a file the output is different, but it seems to alternate back and forth between two versions, so if I load the key from file, write it, it will now have "content b", then when I load and write it again, it will be back to the original content.
What did you expect to see?
Loading and writing a private key to not change the file content.
What did you see instead?
Whenever I read the private key from the drive and write it back the content changes, but it changes back and forth between two different versions of the output.

I also tested it with unarmored SerializePrivate and ReadKeyRing

/cc @FiloSottile

Per the accepted #44226 proposal and due to lack of maintenance, the golang.org/x/crypto/openpgp package is now frozen and deprecated. No new changes will be accepted except for security fixes. The package will not be removed.
If this is a security issue, please email<EMAIL_ADDRESS>and we will assess it and provide a fix.
If you're looking for alternatives, consider the crypto/ed25519 package for simple signatures, golang.org/x/mod/sumdb/note for inline signatures, or filippo.io/age for encryption. You can read a summary of OpenPGP issues and alternatives here.
If you are required to interoperate with OpenPGP systems and need a maintained package, we suggest considering one of multiple community forks of golang.org/x/crypto/openpgp. We don't endorse any specific one.


Fixed a links issue due to offmesh connections

When creating the tile's links, offmesh connections inside the tile
were added twice, leading to the array of links being full and not
being able to store the links computed after (portals between
tiles).
Google group discussion :
https://groups.google.com/forum/#!msg/recastnavigation/l-_Mk1O4I04/PWE0dGSKBAAJ

I agree, it would be better. I will test your solution tomorrow (since it's just moving a line, it should work but I'll check) and make the change here.
Thanks !

Thanks for the fix! I didn't get a notification about the update, so didn't see it until now.


successful account creation but an error screen appeared

after 10-20s the Congratulations! message came

This is not relevant anymore.


Update to latest open release

Test and update to support Aras 11 SP12.

Verified on Aras 12.0 with proper IOM install

@sampoearas - For future upgrade issues, please leave the issue open until the upgrade PR is merged. You can add a comment in the issue to link the PR if you want to communicate that the issue is being addressed.


Link addons with rpath relative to $ORIGIN on Linux

Before:
$ readelf -d myplugin64.so
Dynamic section at offset 0x52a60 contains 30 entries:
  Tag        Type                         Name/Value
 0x0000000000000001 (NEEDED)             Shared library: [libida64.so]
 [...]
 0x000000000000001d (RUNPATH)            Library runpath: [/full/path/to/idasdk/lib/x64_linux_gcc_64]

After:
$ readelf -d myplugin64.so
Dynamic section at offset 0x1bcf0 contains 35 entries:
  Tag        Type                         Name/Value
 0x0000000000000001 (NEEDED)             Shared library: [libida64.so]
 [...]
 0x000000000000000f (RPATH)              Library rpath: [$ORIGIN/..]

Official Hex-Rays plugin:
$ readelf -d idapython3_64.so
Dynamic section at offset 0x1bcf0 contains 35 entries:
  Tag        Type                         Name/Value
 0x0000000000000001 (NEEDED)             Shared library: [libida64.so]
 [...]
 0x000000000000000f (RPATH)              Library rpath: [$ORIGIN/..]

@illnyang I am not familiar with the importance of this change. Can you please elaborate more?


Define ENV vars in CircleCI for ECS token/secret

To deploy from CircleCI to ECS, we need to define ENV vars with the token and secret of an IAM user with the appropriate permissions.

Bower doesn't use CircleCI anywhere. Not sure how can I help here.


Support CentOS 6 Caffe CPUs

see https://groups.google.com/forum/#!topic/sparknet-users/NBpa6EvEQW4

We provide JARs for CentOS 6 which make it possible to use Caffe with CPUs.
To use them, replace the relevant lines in your build.sbt with the following ones:
resolvers += "javacpp" at "http://www.eecs.berkeley.edu/~rkn/snapshot-2016-03-05/"
resolvers += "javacpp" at "http://www.eecs.berkeley.edu/~rkn/snapshot-2016-03-23-CENTOS6-CPU/"

libraryDependencies += "org.bytedeco" % "javacpp" % "1.2-SPARKNETCENTOS6"

libraryDependencies += "org.bytedeco.javacpp-presets" % "caffe" % "rc3-1.2-SPARKNETCENTOS6"

libraryDependencies += "org.bytedeco.javacpp-presets" % "caffe" % "rc3-1.2-SPARKNETCENTOS6" classifier "linux-x86_64"

libraryDependencies += "org.bytedeco.javacpp-presets" % "opencv" % "3.1.0-1.2-SPARKNETCENTOS6"

libraryDependencies += "org.bytedeco.javacpp-presets" % "opencv" % "3.1.0-1.2-SPARKNETCENTOS6" classifier "linux-x86_64"

libraryDependencies += "org.bytedeco.javacpp-presets" % "tensorflow" % "master-1.2-SPARKNET"

libraryDependencies += "org.bytedeco.javacpp-presets" % "tensorflow" % "master-1.2-SPARKNET" classifier "linux-x86_64"

and uncomment
test in assembly := {}

to make sure tests are not run during assembly (the TensorFlow tests would not work on CentOS 6).
There are instructions in https://github.com/amplab/SparkNet/commit/61b0cbc8c2d5b5b26f64bf130c4cea6c49a24808 merged in #113 on how these JARs were build, in case you need to create your own.


Add Bancor v2

Hey David, I thought I'd help by updating Bancor to v2. I've added a description based on the Uniswap and Balancer descriptions to be consistent, and used the fetcher in the same way as AAVE, as there was only a JSON to parse.
I hope this is okay or at least helps you.

Hey, thanks for creating this PR.
While we're updating the Bancor adapter, I'd love to actually fully update Bancor to V2, which would require fetching data by dates. Are you involved with the Bancor API at all? Do you know if it's possible to query this data by date?

Hey David, I've asked the Bancor team about this - their API is currently being updated and doesn't support querying data by date yet. Can it be partially updated for now? Once the feature is available, I'll communicate here again if you want. Thanks!

Awesome, I messaged with their team too.
Went ahead and merged your PR, thanks for your contribution!


invites_modal: Replace modal confirmation text to Confirm.

Followup of #17926 (Basically, should have been a part of #18073).
Screenshots
Revoke confirmation modal

Resend confirmation modal

FYI @nikhilmaske-2001.

Merged, thanks @aryanshridhar!


ConcurrentModificationException when excluding multi tasks from command line (-x) in a subproject with configureondemand

Expected Behavior
P.s: This error does not happen on gradle 7.3.3 (or previous versions).
Using gradle 7.4.+, when ignoring multiple tasks via command line (using -x as parameter) on a subproject where configureondemand is enabled, and we remove tasks using gradle script as well, the command line should run successfully.
Current Behavior
Currently, when we ignore multi tasks via command line like the example bellow:
./gradlew test-module:taskA -x test-module:taskB -x test-module:taskC

And the project has org.gradle.configureondemand=true on gradle.properties file, and we are removing any task like bellow on the root gradle file:
def modulesExcludedFromCleanBuildTasks = [
        "test-module"
]

modulesExcludedFromCleanBuildTasks.forEach { module ->
    gradle.startParameter.excludedTaskNames.add(":$module:clean")
    gradle.startParameter.excludedTaskNames.add(":$module:build")
}

there is an exception as output:
Configuration on demand is an incubating feature.

FAILURE: Build failed with an exception.

* What went wrong:
java.util.ConcurrentModificationException (no error message)

Context
We have a multi module project where some modules does not have the tasks clean and build, so these tasks are removed via gradle file as the example above (using gradle.startParameter.excludedTaskNames.add()).
In one of these modules, we have code to test our app, and we have some steps on our CI pipeline where we do not run all tests scenarios but only some of them, so we use -x to exclude unnecessary tests for CI. Our pipeline started to get error when we updated gradle to 7.4.+.
Steps to Reproduce
1 - See the issue on reproducer
https://github.com/mauriciogeneroso/gradle-issue-21030-reproducer
2 - Download the project already set up
1 - Download the project already set up: gradle-test.zip
2 - Run the command line: ./gradlew test-module:taskA -x test-module:taskB -x test-module:taskC
3 - Set up from Scratch
1 - Create a gradle project
2 - On gradle.properties file includes org.gradle.configureondemand=true
3 - Create a subproject
4 - Create at lease 3 tasks on the subproject like:
task taskA(type: JavaExec) {
    classpath = sourceSets.main.runtimeClasspath
    mainClass = 'test.HelloWorld'
}

task taskB(type: JavaExec) {
    classpath = sourceSets.main.runtimeClasspath
    mainClass = 'test.HelloWorld'
}

task taskC(type: JavaExec) {
    classpath = sourceSets.main.runtimeClasspath
    mainClass = 'test.HelloWorld'
}

taskA.dependsOn(taskB, taskC)

5 - On gradle root file, exclude any task from the subproject like:
def modulesExcludedFromCleanBuildTasks = [
        "test-module"
]

modulesExcludedFromCleanBuildTasks.forEach { module ->
    gradle.startParameter.excludedTaskNames.add(":$module:clean")
    gradle.startParameter.excludedTaskNames.add(":$module:build")
}

6 - Run the command line: ./gradlew test-module:taskA -x test-module:taskB -x test-module:taskC
Your Environment
Nothing in particular required to reproduce the issue.

Hosted this issue with my personal account: https://github.com/gradle/gradle/issues/22235


Reloading a UI

Hey, I just had a quick question, is it possible to completely reload a UI, currently what I'm doing is using DynamicElementOnStatusChanged to make some of my UI pages "reload" when certain conditions occur, but this is far from ideal as it also means I have to manually reset a bunch of variables. I was wondering if it's possible to say rebuild the root or something, as it would be pretty useful to quickly reset everything all at once. If not, is it possible to close and rebuild it?
Thanks!

Efficient "reload" is not available at the moment.
However, you can destroy the UI with Element.DetachView() and then recreate and rebuild the UI.

Example code
[RequireComponent(typeof(RosettaUIRoot))]
public class RebuildExample : MonoBehaviour
{
    public string stringValue;

    private RosettaUIRoot _root;
    private Element _rootWindow;

    private void Start()
    {
        _root = GetComponent<RosettaUIRoot>();

        _rootWindow = UI.Window(nameof(RebuildExample),
            UI.Page(
                UI.Field(() => stringValue)
            )
        );

        _root.Build(_rootWindow);
    }

    [ContextMenu("Rebuild UI")]
    public void RebuildUI()
    {
        _rootWindow.DetachView();

        _rootWindow = UI.Window(nameof(RebuildExample),
            UI.Page(
                UI.Box(
                    UI.Label("New UI")
                ),
                UI.Field(() => stringValue)
            )
        );

        _root.Build(_rootWindow);
    }

This will result in a complete rebuild of the UI, which may raise concerns about processing load.
If possible, I recommend partially rebuilding the UI using UI.Dynamic*().
UI.DynamicElementOnTrigger() might also be a useful hint for you.
Thank you for using our library😁

Thanks, that did the trick!


Investigate how to implement Custom Action Buttons

See, if possible with React Native, how to implement custom action buttons for Custom Chrom Tab and how much effort would be required.

Closing as this project has reached EOL.


ProjectPaymentsHistory More than one result was returned from Query.getSingleResult()

ProjectPaymentsHistory findByProjectName
More than one result was returned from Query.getSingleResult()
b/c project name is not unique and payment history of a deleted project is still in the db it can return multiple results.

It makes sense that more than one result would be returned since there could be multiple transaction made. I have it set to return the last transaction so that shouldn't return duplicates. How can I reproduce it?


"Tătaru" is listed in the drop-down menu

The commune is  listed in the drop-down menu alongside its corresponding county, according to the law
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and runing. After every step delete the text you typed from the search bar.

Step 1
Write in the search bar "Tătaru"
Expected results
The location appears in the drop-down menu as "Comuna Tătaru, PRAHOVA"


Crash on startup when iconComponent is not provided to HoldMenuProvider

Describe the bug
Crash on application start if iconComponent is not provided to HoldMenuProvider with "cannot read property displayName of undefined"
To Reproduce
Steps to reproduce the behavior:
Clean install, follow the docs, assume that iconComponent is not needed if you don't want to use icons.
Package versions

React: 17.0.1
React Native: 0.64.2
React Native Reanimated: 2.2.0
React Native Hold Menu: 0.0.1

Additional context
Probably should add a default value of class component that renders null to HoldMenuProvider or/and mention it in the docs, since it's marked as required in Typescript defs.

Hi @Pyroboomka, icon component is not optional for now. I did not tried without icon actually but it make sense. Would be good to make it optional. Thanks!

I don't think this is a problem per se - but it'd be great if it's specified in the docs and TypesScript! 🙂

This should be fixed by the new release. Changes were made in the last PR (https://github.com/enesozturk/react-native-hold-menu/pull/73). I'll publish it soon. Thanks!


Add gsw

The oceanographers will need this.
Now that pangeo-notebook is the image for our GCP cluster, this is probably the first of many requests we will get for domain-specific packages. Are we okay with that here?

Now that pangeo-notebook is the image for our GCP cluster, this is probably the first of many requests we will get for domain-specific packages. Are we okay with that here?

Good question. I think we need to figure this out ASAP. A key follow-up question is, will oceanographers also be wanting to use the same image on AWS or Azure? Then building here and pushing to DockerHub makes sense to me. That way any hub can run any image built in this repository by using a profile_list (https://github.com/pangeo-data/pangeo-cloud-federation/blob/f2335fbeb84bfb65dcba7190f46dfa4628ac3800/deployments/icesat2/config/common.yaml#L15).
But, I think we should probably do a little refactoring with the image names as discussed in this issue https://github.com/pangeo-data/pangeo-docker-images/issues/28.  Specifically, I think we might want to:

rename pangeo-notebook to oceanography-notebook and tailor the packages accordingly
probably create a separate remote-sensing-notebook
change github actions workflows to use those new names

Alternatively, you can switch back to building the ocean image in pangeo-cloud federation with hubploy, or pangeo-notebook becomes an ever-expanding list of packages used by oceanographers, seismologists, mineralogists... etc ;)

IMO:

We build all images here rather than in the hubs. The tooling here is just too nice not to use :)
Splitting off to a pangeo-ocean image seems fine. The extra overhead of an additional image isn't too big, right?

Splitting up images and building theme here sounds fine to me...
But if literally the only difference between pangeo-notebook and pangeo-ocean is a tiny package called gsw, it doesn't seem worth the trouble. The GCP hub is used by a wide range of scientists, mostly ocean, atmosphere, and climate folks. So despite what I said in my earlier comment, "oceanography" is probably a bit too narrow.
@scottyhq - I'm curious what additional packages are needed for remote sensing?
I still have a dream that perhaps we don't need a bunch of different images for these very similar domains.

Right I don’t think we’re at the splitting point yet.

On Jul 2, 2020, at 08:02, Ryan Abernathey<EMAIL_ADDRESS>wrote:

Splitting up images and building theme here sounds fine to me...
But if literally the only difference between pangeo-notebook and pangeo-ocean is a tiny package called gsw, it doesn't seem worth the trouble. The GCP hub is used by a wide range of scientists, mostly ocean, atmosphere, and climate folks. So despite what I said in my earlier comment, "oceanography" is probably a bit too narrow.
@scottyhq - I'm curious what additional packages are needed for remote sensing?
I still have a dream that perhaps we don't need a bunch of different images for these very similar domains.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.

@scottyhq - I'm curious what additional packages are needed for remote sensing?

@rabernat see for example the environment for the recent icesat2 hackweek https://github.com/ICESAT-2HackWeek/jupyter-image-2020/blob/master/environment.yml

I push on dask/distributed#3216, to reduce the need for this a bit. But if many people are installing something at runtime then it really should end up in the image.

This would definitely help. Ultimately I still subscribe to the one streamlined conda environment per project, so am wary of an ever expanding list. It's straightforward to do this for a single notebook server https://gist.github.com/scottyhq/2cbd183374d016940f224e3cb36efe59. Using dask gateway complicates things. I experimented a little bit with a 'bring-your-own-conda-environment' using a dask preload script, but is seems the preference is to have everything baked into a docker image.
@TomAugspurger - this PR didn't actually make any changes b/c \condalock wasn't run. We need to modify the github action pr.yml to make sure that is run every time.


Update Namespace plugin for Kserve configs

Namespace plugin config is overwritten by namespace defined by the  kustomization.yaml when the plugin is not explicitly updated to include namespace references into Plugin config
Add all required references to namespace plugin.

lgtm


Show generated IR on verification failure

IR verification in function_body, as is currently done, is more bothersome than helpful.
I'm currently in the following struggle: my code generates invalid IR, and the verify call correctly tells me so. However, now I have to solve the issue, without being able to look at the generated IR -- which is proving to be extremely tough, since LLVM failed verification messages leave a lot to be desired.
It would be great if there was some way in which I could display the generated IR in the case of verification failure -- or, some way to run some closure that will access&print the generated IR before the verification happens. Or, simply remove the verification from function_body, and have it be run on the whole module at the end of code generation (on request of the user?).

I think it sounds like a good idea to remove the call to verify and let users determine when that check should be done. I just made that change here: https://github.com/zshipko/llama/commit/5d9dfdc085d804404870ff6eb80b2998521124ce

I've also just made a new minor release (0.11.1) with this update

Thank you! Looks like a good change, and everything seems in order.
Already helped me solve my issue :smile:


Skywrath Mage IMBA

Includes the folder for Skywrath's new skill particles.
I've put the files on root since I couldn't find the particles folder on Github. Please assign them to the correct folder, since I'm not sure how to do that exactly yet.
Thanks in advance!
Shush

This can't be merged directly because of a version conflict with npc_abilities_custom.txt. I'll add it manually.
Big thanks for your help! :)

@fcalife Why can't the production version match up directly with the github repo? Just curious

@brandonsturgeon short answer is, I don't upload nearly frequently enough for that to happen.
Bad habits. :D

@fcalife Sounds like there are some tools/automation you can use to make your life easier. Would be happy to see if I could help.


Update Support.md with macos workaround

Quick link to the MacOS workaround xattr -cr /Applications/WebCord.app it works

Thank you for this PR!
However, I don't think I will merge it – I'll probably just configure Electron Forge to package my application to the dmg format. From what I've found, packaging the app into a zip archive might result in some issue like that (while I don't think dmg would conflict with the macOS extended attributes). Once I'll do this, I'll close this issue as well unless this workaround will be still relevant.

sounds good! thanks you

On Jan 7, 2022, at 10:38 AM, SpacingBat3 @.***> wrote:
Thank you for this PR!
However, I don't think I will merge it – I'll probably just configure Electron Forge to package my application to the dmg format. From what I've found, packaging the app into a zip archive might result in some issue like that (while I don't think dmg would conflict with the macOS extended attributes). Once I'll do this, I'll close this issue as well unless this workaround will be still relevant.
—
Reply to this email directly, view it on GitHub https://github.com/SpacingBat3/WebCord/pull/90#issuecomment-1007504123, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEVNQF53S5HNG7ZAW5TL6DUU4CGRANCNFSM5LNWNWLA.
You are receiving this because you authored the thread.


[WIP] Convert the project to Ember-cli

This PR converts the project to use Ember-cli. I kept as much as possible of the original code, just moving around the code.
The project is not compatible with Ember 1.13 yet, I will submit another PR updating the Ember version.
This PR is not ready to be merged. A few pending changes:

[ ] Ember.meta().descs doesn't exist anymore (https://github.com/emberjs/ember.js/pull/10323)
[ ] Load Ember.i18n using modules instead of globals
[ ] Tests with input[type=date] and input[type=time] don't work on PhantomJS
[ ] Update the readme

Sweet :)
Can you redirect the target branch to 1-0-stable ?

Sure!


[Algo] Bubble Sort [Rust]

https://en.wikipedia.org/wiki/Binary_search_algorithm
I realize that Rust is not currently an accepted language, but I think it should be considered.
If necessary, I could contribute Rust code samples for every currently accepted algorithm.

GitMate.io thinks possibly related issues are https://github.com/NITSkmOS/Algorithms/issues/147 ([Algo] Merge Sort [C]), https://github.com/NITSkmOS/Algorithms/issues/145 ([Algo] Selection Sort [C]), https://github.com/NITSkmOS/Algorithms/issues/19 ([Algo]: Add Bubble Sort in C), https://github.com/NITSkmOS/Algorithms/issues/146 ([Algo] Quick Sort [C]), and https://github.com/NITSkmOS/Algorithms/issues/296 ([Algo] Quick Sort [Elixir]).

Please read the documentation first. Before adding any algorithms in other languages in the repo, we have many settings to do. So please propose a language first. Thanks for your time.