feat: search index tool

Description
Implement SearchIndexTool to support agent framework. It takes in two string parameters: index and query. Here is the sample usage of this tool. Please remember to replace the model id and agent id.
POST /_plugins/_ml/agents/_register
{
  "name": "Test_Agent_For_ReAct",
  "type": "conversational",
  "description": "this is a test agent",
  "llm": {
    "model_id": "xxxxx",
    "parameters": {
      "max_iteration": 10,
      "stop_when_no_tool_found": true,
      "response_filter": "$.completion"
    }
  },
  "memory": {
    "type": "conversation_index"
  },
  "tools": [
    {
      "type": "SearchIndexTool",
      "description": "Use this tool to search index with a query. You should pass in two parameters: index and query. Index is the index name and the query is an OpenSearch DSL query."
    }
  ],
  "app_type": "my app"
}

POST /_plugins/_ml/agents/xxxxx/_execute
{
  "parameters": {
    "question": "Show me all the name field of all documents in index .plugins-ml-agent",
    "verbose": true
  }
}

The expected successful response should be
{
  "inference_results": [
    {
      "output": [
        {
          "name": "memory_id",
          "result": "xxxxx"
        },
        {
          "name": "response",
          "result": "Thought: To get the name field of documents in the .plugins-ml-agent index, I should search that index using the SearchIndexTool."
        },
        {
          "name": "response",
          "result": "\nObservation: \"{\\\"_index\\\":\\\".plugins-ml-agent\\\",\\\"_source\\\":{\\\"name\\\":\\\"Test_Agent_For_ReAct\\\"},\\\"_id\\\":\\\"xxxxx\\\",\\\"_score\\\":1.0}\\n\""
        },
        {
          "name": "response",
          "result": "Based on the information I was previously provided from searching the index, the name field of the documents in the .plugins-ml-agent index contains 'Test_Agent_For_ReAct'."
        },
        {
          "name": "response",
          "result": "The name field of the documents in the .plugins-ml-agent index is 'Test_Agent_For_ReAct'."
        }
      ]
    }
  ]
}

If there is error when parsing the input, the expected error response could be:
{
  "error": {
    "root_cause": [
      {
        "type": "illegal_argument_exception",
        "reason": "[query] is null or empty, can not process it."
      }
    ],
    "type": "illegal_argument_exception",
    "reason": "[query] is null or empty, can not process it."
  },
  "status": 400
}

Issues Resolved

Implement search index tool
Fix bugs in unit tests

Check List

[x] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Please check the codecov report and add more UTs.

Please check the codecov report and add more UTs.

I have add UT to cover more code. This PR is ready for review now.


[BUG] com.karuslabs:satisfactory 1.1.3 is not available

Describe the bug
While trying to import the project, I noticed that the version 1.1.3 of satisfactory is not available
To Reproduce
Steps to reproduce the behavior:

Navigate to: https://repo.karuslabs.com/#browse/browse:elementary-releases:com%2Fkaruslabs%2Fsatisfactory
Confirm that the last version is 1.1.2

Expected behavior
I was expecting to see the last version of satisfactory to be aligned with all the other version given that this version is found on the REAME.
Screenshots

Environment (please complete the following information):

Java Version 17

Additional context
N/A

Ah it’s a typo, the latest version for satisfactory is 1.1.2. I’m not going to release a new version since 2.0.0 is long overdue, haven’t had the time to release it recently.


Update README.md

Updated instructions for Ubuntu 17 and Debian 9

This change is

Coverage remained the same at 72.504% when pulling bdb0161bfea7496a85822fd47dda438f1ec9e692 on dev into 9eadf805adf83c3f7de53e06f2a7f2630a9fdd8f on master.

Codecov Report

Merging #642 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #642   +/-   ##
=======================================
  Coverage   77.13%   77.13%
=======================================
  Files          25       25
  Lines        7317     7317
=======================================
  Hits         5644     5644
  Misses       1673     1673

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eadf80...bdb0161. Read the comment docs.


zdev/initramfs: add s390-tools- prefix to hook, due to conflicts.

Unfortunately zdev hook already exists in Ubuntu, from an unrelated
project. ZFS uses zdev/zpool names, and ships a zdev hook to do ZFS
specific initialisation. It is available on s390x and thus results in
file-conflict upon installing both. Thus renaming this zdev hook to
s390-tools-zdev.
Signed-off-by: Dimitri John Ledkov<EMAIL_ADDRESS>

This would be fine with me but I'd like to have @oberpar opinion as well before I pull.

Thanks for the contribution. Pulled and integrated internally.


Remove simple branches after BrTable

This code removes branches after BrTable, which reduces code size, and should improve performance. The code still needs polishing. What do you think?

It's better than before!


Alert when file systems fill

Send Slack alert when file system fills over 90%, especially for Cassandra and Galera data partitions

Added manually for lasair-ztf. Not worth trying to automate as too heterogeneous.


Calibrate doesn't work after load remover changes

Need to rework the calibration. Is this even necessary? Who knows. Right now the button does nothing.

Not needed? As long as video feed is local and high quality this shouldn't really matter. Only really required when running against vids that were streamed & downloaded where some of the color quality is lost...


RemoveType the function not working ,why?

factories.RemoveType();
factories.RemoveType();

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9a5cfa38-0e6c-4346-dafc-84ea5c513fcf
Version Independent ID: c6787f0f-3e9a-6efb-0e6e-5ccb957d3f4a
Content: File uploads in ASP.NET Core
Content Source: aspnetcore/mvc/models/file-uploads.md
Service: asp.net-core
GitHub Login: @ardalis
Microsoft Alias: riande

I can't say just looking at it. @scottaddie ... thoughts?
I'll cross-reference the issue tracking work for this topic in case this becomes actionable for the updates: https://github.com/aspnet/Docs/issues/5331

@yxn03 The RemoveType methods were introduced in ASP.NET Core 2.0. For versions prior to 2.0, you'll need to take the following approach:
        public void OnResourceExecuting(ResourceExecutingContext context)
        {
 			// ==== ASP.NET Core 2.0+ ====
            //var factories = context.ValueProviderFactories;
            //factories.RemoveType<FormValueProviderFactory>();
            //factories.RemoveType<JQueryFormValueProviderFactory>();

			// ==== ASP.NET Core 1.1 ====
            var formValueProviderFactory = context.ValueProviderFactories
                .OfType<FormValueProviderFactory>()
                .FirstOrDefault();

            if (formValueProviderFactory != null)
            {
                context.ValueProviderFactories.Remove(formValueProviderFactory);
            }

            var jqueryFormValueProviderFactory = context.ValueProviderFactories
                .OfType<JQueryFormValueProviderFactory>()
                .FirstOrDefault();

            if (jqueryFormValueProviderFactory != null)
            {
                context.ValueProviderFactories.Remove(jqueryFormValueProviderFactory);
            }
        }

This doc is due for a rewrite and update. This change will be taken into account at that time. See #5331 to track its status.


only show feedback if status is rejected

#3245  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tommylau523 and the rest of your teammates on  Graphite

Merge activity

Sep 26, 5:47 PM EDT: @tommylau523 merged this pull request with Graphite.


Error when use jest-environment-jsdom in Typescript

🐛 Bug Report
When I import and use jest-environment-jsdom in my project, using Typescript to build will receive a message error:
TS2416: Property 'global' in type 'JSDOMEnvironment' is not assignable to the same property in base type 'JestEnvironment'.

It's an error when build to publish right?
To Reproduce
In types of build missing a comment // @ts-ignore, check here:
<EMAIL_ADDRESS>

Ah, I didn't know ignores were not emitted... (https://github.com/Microsoft/TypeScript/issues/20360)
We should make sure this works properly in Jest 25.
A PR fixing the type issue is very much welcome, of course!

@SimenB I created a PR to fix it, please review and give me a comment. Thank you very much!

#8352


Implement TripleProducer with support for IRI-only triples

Implements a TripleProducer that produces a set of triples for a parsed document

Open TODOs

[x] Set up testing against reference examples, to make sure that we can emit everything we can parse without errors
[ ] Implement production of everything we can parse so far

[ ] Implement relative IRI resolution algorithm (maybe there is a crate for that?)

CLOSES #4

Merging as initial version. There are still some unsupported constructs that the can't be turned into constructs yet, but for all of the ontologies that are currently in the registry it works.


caffe issues

I'm having a really hard time to get caffe running on my system.
Is there a way to not use caffe?
Would it be possible to convert the model to a tensorflow model and save it's weights (through serialisation in tensorflow)?

https://github.com/ethereon/caffe-tensorflow
You can refer to this link.


Unable to update Bot Responses

Describe the bug
I created a new bot using the template: "Core Bot with Language" (Node).
I updated the Bot Response under  "WelcomeDialog" but the emulator continues to display the original bot response.
I updated the Bot Response under "HelpDialog" and the same thing happens - it continues to use the original responses from the template even though they have been changed in Composer.
I have restarted the bot, restarted composer+emulator, no change.
Version
Version:  2.0.0
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
Browser
[ x ] Chrome
OS
[ x ] Windows
To Reproduce
Steps to reproduce the behavior:

Create a new bot using the template: "Core Bot with Language" (Node).
Update a Bot Response
Start bot and connect with Emulator
Bot responds with original template text instead of what you updated.

Expected behavior
The bot should respond using the Bot Responses defined in Composer.
Screenshots

Hi @someonelikeTIM - this will be addressed in our upcoming release.

Do you have an ETA for that release?

@someonelikeTIM, I just pushed a development build of the JS SDK with the fix for this. Can you update your package.json file to list "botbuilder-dialogs-adaptive-runtime-integration-express": "4.13.5-preview.dev.5bd62f8" (instead of 4.13.4-preview). Then, run npm install and you should be in business.

The bot is now failing to start. Here is the error message:
Error occurred building the bot

Error: DialogSet.add(): Invalid dialog being added. at DialogSet.add (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\node_modules\botbuilder-dialogs\lib\dialogSet.js:119:19) at DialogManager.set rootDialog [as rootDialog] (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\node_modules\botbuilder-dialogs\lib\dialogManager.js:67:26) at new DialogManager (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\node_modules\botbuilder-dialogs\lib\dialogManager.js:48:29) at new CoreBot (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\lib\coreBot.js:23:31) at services.addFactory (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\lib\index.js:173:16) at factories.reduce (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\node_modules\botbuilder-dialogs-adaptive-runtime-core\lib\serviceCollection.js:129:67) at Array.reduce (<anonymous>) at nodes.reduce (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\node_modules\botbuilder-dialogs-adaptive-runtime-core\lib\serviceCollection.js:129:40) at Array.reduce (<anonymous>) at ServiceCollection.buildNodes (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\node_modules\botbuilder-dialogs-adaptive-runtime-core\lib\serviceCollection.js:114:32) npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! CoreWithLanguage@ dev: `cross-env NODE_ENV=dev node index.js "--port" "3980" "--urls" "http://<IP_ADDRESS>:3980" "--luis:endpointKey" "_removed_" "--SkillHostEndpoint" "http://<IP_ADDRESS>:3980/api/skills"` npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the CoreWithLanguage@ dev script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR!  C:\Users\wate18\AppData\Roaming\npm-cache\_logs\2021-05-27T20_44_51_749Z-debug.log

Can you confirm that all your botbuilder-* versions have been updated? They should all list 4.13.5, and if you look at your yarn.lock or package-lock.json file that's the only version number you should see (some may include "-preview").

All of them show 4.13.5 except the following:

Updating all the botbuilder packages in your package.json file and running npm install again should update everything to 4.13.5. There are a few instanceof checks, including where you're seeing this error. If the versions aren't locked to the same exact number this can happen.

I updated all the botbuilder packages in package.json and ran npm install. Everything in package-lock has been updated to 4.13.5. Now I get the following error when trying to run the bot.
Error occurred building the bot

Error: DialogSet.add(): Invalid dialog being added. at DialogSet.add (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\node_modules\botbuilder-dialogs\lib\dialogSet.js:119:19) at DialogManager.set rootDialog [as rootDialog] (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\node_modules\botbuilder-dialogs\lib\dialogManager.js:67:26) at new DialogManager (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\node_modules\botbuilder-dialogs\lib\dialogManager.js:48:29) at new CoreBot (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\lib\coreBot.js:23:31) at services.addFactory (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\lib\index.js:173:16) at factories.reduce (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\node_modules\botbuilder-dialogs-adaptive-runtime-core\lib\serviceCollection.js:129:67) at Array.reduce (<anonymous>) at nodes.reduce (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\node_modules\botbuilder-dialogs-adaptive-runtime-core\lib\serviceCollection.js:129:40) at Array.reduce (<anonymous>) at ServiceCollection.buildNodes (C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\botbuilder-dialogs-adaptive-runtime\node_modules\botbuilder-dialogs-adaptive-runtime-core\lib\serviceCollection.js:114:32) npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! CoreWithLanguage@ dev: `cross-env NODE_ENV=dev node index.js "--port" "3980" "--urls" "http://<IP_ADDRESS>:3980" "--luis:endpointKey" "_removed_" "--SkillHostEndpoint" "http://<IP_ADDRESS>:3980/api/skills"` npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the CoreWithLanguage@ dev script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR!  C:\Users\wate18\AppData\Roaming\npm-cache\_logs\2021-06-01T15_54_21_851Z-debug.log

Here are the contents of the referenced log file:
0 info it worked if it ends with ok
1 verbose cli [ 'C:\\Program Files\\nodejs\\node.exe',
1 verbose cli   'C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js',
1 verbose cli   'run',
1 verbose cli   'dev',
1 verbose cli   '--',
1 verbose cli   '--port',
1 verbose cli   '3980',
1 verbose cli   '--urls',
1 verbose cli   'http://<IP_ADDRESS>:3980',
1 verbose cli   '--luis:endpointKey',
1 verbose cli   '_removed_',
1 verbose cli   '--SkillHostEndpoint',
1 verbose cli   'http://<IP_ADDRESS>:3980/api/skills' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'predev', 'dev', 'postdev' ]
5 info lifecycle CoreWithLanguage@~predev: CoreWithLanguage@
6 info lifecycle CoreWithLanguage@~dev: CoreWithLanguage@
7 verbose lifecycle CoreWithLanguage@~dev: unsafe-perm in lifecycle true
8 verbose lifecycle CoreWithLanguage@~dev: PATH: C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin;C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage\node_modules\.bin;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Program Files (x86)\Integrad.3\MIV;C:\Program Files (x86)\Hyland\Web ActiveX\;C:\Program Files\nodejs\;C:\Program Files\Intel\WiFi\bin\;C:\Program Files\Common Files\Intel\WirelessCommon\;C:\Program Files\PuTTY\;C:\Program Files\dotnet\;C:\Program Files (x86)\Sennheiser\SenncomSDK\;C:\Users\wate18\AppData\Local\Programs\Python\Python38-32\Scripts\;C:\Users\wate18\AppData\Local\Programs\Python\Python38-32\;C:\Users\wate18\AppData\Local\Microsoft\WindowsApps;C:\Users\wate18\AppData\Roaming\npm;C:\Users\wate18\AppData\Local\Programs\Microsoft VS Code\bin;C:\Users\wate18\AppData\Local\Programs\Git\cmd;C:\Users\wate18\.dotnet\tools
9 verbose lifecycle CoreWithLanguage@~dev: CWD: C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage
10 silly lifecycle CoreWithLanguage@~dev: Args: [ '/d /s /c',
10 silly lifecycle   'cross-env NODE_ENV=dev node index.js "--port" "3980" "--urls" "http://<IP_ADDRESS>:3980" "--luis:endpointKey" "_removed_" "--SkillHostEndpoint" "http://<IP_ADDRESS>:3980/api/skills"' ]
11 silly lifecycle CoreWithLanguage@~dev: Returned: code: 1  signal: null
12 info lifecycle CoreWithLanguage@~dev: Failed to exec dev script
13 verbose stack Error: CoreWithLanguage@ dev: `cross-env NODE_ENV=dev node index.js "--port" "3980" "--urls" "http://<IP_ADDRESS>:3980" "--luis:endpointKey" "_removed_" "--SkillHostEndpoint" "http://<IP_ADDRESS>:3980/api/skills"`
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\index.js:301:16)
13 verbose stack     at EventEmitter.emit (events.js:189:13)
13 verbose stack     at ChildProcess.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\lib\spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:189:13)
13 verbose stack     at maybeClose (internal/child_process.js:970:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)
14 verbose pkgid CoreWithLanguage@
15 verbose cwd C:\AzureBots\Development\osumc-helpbot-v2\CoreWithLanguage\CoreWithLanguage
16 verbose Windows_NT 10.0.14393
17 verbose argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "dev" "--" "--port" "3980" "--urls" "http://<IP_ADDRESS>:3980" "--luis:endpointKey" "_removed_" "--SkillHostEndpoint" "http://<IP_ADDRESS>:3980/api/skills"
18 verbose node v10.15.3
19 verbose npm  v6.4.1
20 error code ELIFECYCLE
21 error errno 1
22 error CoreWithLanguage@ dev: `cross-env NODE_ENV=dev node index.js "--port" "3980" "--urls" "http://<IP_ADDRESS>:3980" "--luis:endpointKey" "_removed_" "--SkillHostEndpoint" "http://<IP_ADDRESS>:3980/api/skills"`
22 error Exit status 1
23 error Failed at the CoreWithLanguage@ dev script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]

@someonelikeTIM, could you shoot me an email? I'd like to take a closer look at your package and lock file(s). My email address is in my Github profile.

Closing due to inactivity


refactor(plugin): generate CrcModels during standard rule evaluation

Description of change
Spike a solution that generates CrcModels as ESLint rules.
Associated issue(s)
#41
Reference issues pertinent to this PR here If there are no issues referenced,
replace this line and the following task completion line.

[ ] The acceptance criteria for all associated issues have been completed, tested, and validated.

PR check-list

:white_check_mark: Please review and check the appropriate items.

1. Code standards compliance

[ ] ESLint passes.

2. Code quality.

[ ] The quality gateways pass with an "A" grade.

Measure
Scores

Complexity

Duplications

Issues

Maintainability

Reliability

Security

3. Test coverage

[ ] The source code is 100% covered with passing specs.

4. Contributor License Agreement (CLA)

[ ] I have signed the Contributor License Agreement (CLA).

:information_source: These tasks are not required to open a PR, and may be addresses while the PR is open.

Changes Unknown when pulling c677c61c380aec3fd09cc89df3db9795223edaea on refactor/#41-rule-based-crc-models into ** on develop**.

Changes Unknown when pulling c677c61c380aec3fd09cc89df3db9795223edaea on refactor/#41-rule-based-crc-models into ** on develop**.

Changes Unknown when pulling c677c61c380aec3fd09cc89df3db9795223edaea on refactor/#41-rule-based-crc-models into ** on develop**.

Changes Unknown when pulling a3f5d223d0cde6830ca75a0ab5b3dbe45bb521d1 on refactor/#41-rule-based-crc-models into ** on develop**.

Changes Unknown when pulling a3f5d223d0cde6830ca75a0ab5b3dbe45bb521d1 on refactor/#41-rule-based-crc-models into ** on develop**.

Changes Unknown when pulling a3f5d223d0cde6830ca75a0ab5b3dbe45bb521d1 on refactor/#41-rule-based-crc-models into ** on develop**.

Changes Unknown when pulling 0d78b67a64f776b3c199492ed3c1cbbe0817996c on refactor/#41-rule-based-crc-models into ** on develop**.

Changes Unknown when pulling 0d78b67a64f776b3c199492ed3c1cbbe0817996c on refactor/#41-rule-based-crc-models into ** on develop**.

Changes Unknown when pulling 0d78b67a64f776b3c199492ed3c1cbbe0817996c on refactor/#41-rule-based-crc-models into ** on develop**.


Flutter doctor is no able to install the dart sdk for the operating system

Steps to Reproduce

...
...
...

Logs

This issue looks like it was posted by mistake.
It doesn't contain enough information to be actionable.
If you actually have a bug to report please create a new issue with more information about the scenario.
What actions did lead to the error message?
What Operating System?
How did you install Flutter and in what directory?


Hitting 404 after log in

I can't seem to figure out why I keep hitting a 404 after logging in to the local site. Is there a particular URL I'm supposed to be hitting past the localhost:5050 part?
Any help would be appreciated! Thanks

Sorry to be a pain, but any ideas? @kitajchuk?

Can you give me any more information about your setup? There isn't a particular url you need to hit. The server acts as a proxy to your remote Squarespace site. What template are you using?

I'm using the default base developer template.
I added the siteurl and sandbox option in the template file. see below:
{
  "name" : "Base Template",
  "author" : "Squarespace",

  "server": {
    "siteurl": "https://haris-mahmood-ui3k.squarespace.com",
    "sandbox": true
  },

  "layouts" : {
    "default" : {
      "name" : "Default",
      "regions" : [ "site" ]
    }
  },

  "navigations" : [ {
      "title" : "Main Navigation",
      "name" : "mainNav"
  } ],

  "stylesheets" : [ "base.less" ],

  "systemCollections" : [ "products" ]
}

I run the server as directed. It presents the login screen, but after signing in it just throws a 404 error.

Do you have an active sitewide password?

Nope - i tried testing it out by putting in my squarespace password, but that lead to the same results.

Would someone have a repository on github with their set up? Maybe I can give that a shot or compare it to what I have myself?
Really want to get this working.

This is super hard to troubleshoot from my end. The node server just acts as a proxy, replicating as much of Squarespace as it can. Super particular issues like this are hard to debug from behind a wall with no visibility into your setup. I know sandbox mode sites are particular in general. I'm wondering if something changed there that is causing the issue...

I'm having the same problem. Using a squarespace site in trial/sandbox developer mode. Can enter my username/password but then takes me directly to a 404 screen.
To get started I just followed this guide step-by-step: https://www.youtube.com/watch?v=tl6Dr4wh0ls

Tried it with a paid site, not trial/sandboxed, and it worked fine.
So the problem appears to be with sandboxed sites...

Thanks for the find. Unfortunate that sandbox/trial doesn't work anymore. Wonder what squarespace changed on their end to cause it to break.

This isn't too surprising. Sandbox sites are protected anyway. It was probably a fluke that the header spoofing worked for the node server to get around that. But I'm guessing @harismahmood89 is right and something has changed that stops this from working anymore.

I've got a paid site but I'm still getting hit with a 404.

@justincharles - Which template are you using?

Base Template

Password, no password?

No password

Hmm. Anything else of mention, or just the 404?

No, just the 404.

I have a trial account using base and it works alright locally. But I haven't updated a lot with it. What is your setup like? Pages, config, styles etc?

I'm just setting things up fresh to start development on a new site so it's basically just grunt-init-squarespace.

What does your template.conf file look like?

`{
"name" : "Base Template",
"author" : "Squarespace",
"layouts" : {
"default" : {
"name" : "Default",
"regions" : [ "site" ]
}
},
"navigations" : [ {
"title" : "Main Navigation",
"name" : "mainNav"
} ],
"stylesheets" : [ "screen.css" ],
"systemCollections" : [ "products" ],
"server": {
"siteurl" : "https://eacypaanyc.squarespace.com"
}
}`

Bizarre. Did you bust your cache and restart the server?

Yup : (

It works now. Probably something weird on Squarespace's end.

Really, dang... I've had weird issues with Squarespace in regards to them stopping a site of mine under the pretenses of "too many unknown requests" before. Glad its working now.

If I have a sitewide password, what would the solve be?

I actually just removed the sitewide password AND set a page to be the Homepage and the 404 error was gone.

Sitewide passwords are fine, you just have to define them in the server config in your template.conf file. https://github.com/kitajchuk/node-squarespace-server#usage

So is it a no? for trial mode for this good service kitajchuk ? :( As im unable to pass through the 404 issue and my web is on trial mode...

@shamroze - I don't think so. I have been running sites in trial mode with no issues. I'm not positive what is causing the 404 for you, but I can ask a few questions here that may help.

Are you using the absolute latest version of the server? sqs --version will tell you which version you are on. 0.3.5 is the latest on npm. If you're not up to date, npm update -g node-squarespace-server will do it. Due to the nature of what this project is attempting to achieve, its actually recommended to always use the latest :)
As long as you are up to date with the server, have you busted your local cache and tried again? sqs buster will do this for you.
Beyond the items above, what collection type is your homepage set to? For instance, page, index, folder, blog etc... Obviously this includes any custom collection types you have created, though those all just follow a standard collection type format anyway.
Can you access any pages locally? Beyond the 404 on your homepage, can you directly hit any other page?
Also, which template are you using? Or which one did you start from? I typically start with the blank base-template.

I know I'm asking a lot of questions but its definitely difficult to debug what causes issues for you guys sometimes without being able to run your site myself and debug on the fly. Let me know about this list of questions and we can go from there.

@kitajchuk Im super glad to see your reply!! and thanks a ton for trying to debug  with such care. However I'm at home and my internet connection is not working very well.I'll have to re set it up as i messed quite a lot of stuff. But i'll be responding u as soon as i get to my table. I'll re check and re do all the things u mentioned above and will update you by next 12 hours i suppose. You can reply whenever its cool to you :) Thanks again for the reply!

@shamroze no worries :)

@kitajchuk hey i followed what u asked to and now i can see my demo homepage up and running!! Previously i had an older version.
I did sqs buster
and it was a base template as well.
However when i hit 'sqs server' it throws this error.
events.js:72
throw er; // Unhandled 'error' event
^
Error: listen EADDRINUSE
but then when i do sqs server --port=8000 and do localhost:8000/home on my browser it opens up fine :)
Thanks!!!

That error is due to having something else already running on port 5050, which is the default for the node server. So it makes sense that running the server on another port worked for you. Check your running node processes and make sure you don't have an instance of the server running in the background blocking your ability to run the default port 5050 :D
Glad you're up and running!

(Y) :+1:

:+1:


expose fields

expose fields in conf, including volumeClaimTemplate, etc. in the past, we allow to configure storageClassName in volumeClaimTemplate. that is real case in production environment.
partial fix for https://github.com/observatorium/operator/issues/50
/assign @squat @kakkoyun
Signed-off-by: clyang82<EMAIL_ADDRESS>

I think this generally makes sense, but we should enforce that accessModes: ['ReadWriteOnce'] is always the case, as if this is not the case then there can be various weird situations that the storage was not designed for.

@brancz Thanks for your comment. Do you mean that we should enforce accessModes: ['ReadWriteOnce'] in operator side?

Agree with your point. I can have another PR in kube-thanos side to enforce it. But I think this PR does not depend on that PR. Can we merge this one firstly? Thanks.

Yep, makes sense!

Thanks @brancz


Added docker

Hi Tom,
Thanks for the tool. Added a docker file for convenience if you see fit to merge.

Hey @TomRyan-321 , posted this here but can't add you to reviewers, since I don't have permissions

Thanks so much @chefren will take a look at this shortly 👍


Mirror weave images to rancher

RKE Version
v0.2.8/v0.3.0-rc10
The related image list comes from RKE cli but it is used in the air gap docs so I think we should track it here.
What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
Prepare images for air-gapped environments.
You will run:
$ rke config --system-images >> ./rancher-images.txt

This is the output for the rke command:
INFO[0000] Generating images list for version [v1.14.6-rancher1-1]:
rancher/coreos-etcd:v3.3.10-rancher1
rancher/rke-tools:v0.1.42
rancher/k8s-dns-kube-dns:1.15.0
rancher/k8s-dns-dnsmasq-nanny:1.15.0
rancher/k8s-dns-sidecar:1.15.0
rancher/cluster-proportional-autoscaler:1.3.0
rancher/coredns-coredns:1.3.1
rancher/hyperkube:v1.14.6-rancher1
rancher/coreos-flannel:v0.10.0-rancher1
rancher/flannel-cni:v0.3.0-rancher1
rancher/calico-node:v3.4.0
rancher/calico-cni:v3.4.0
rancher/calico-ctl:v2.0.0
rancher/coreos-flannel:v0.10.0
weaveworks/weave-kube:2.5.0
weaveworks/weave-npc:2.5.0
rancher/pause:3.1
rancher/nginx-ingress-controller:0.21.0-rancher3
rancher/nginx-ingress-controller-defaultbackend:1.5-rancher1
rancher/metrics-server:v0.3.1

Other details that may be helpful:
Related issues:
https://github.com/rancher/rancher/issues/19435
https://github.com/rancher/rancher/issues/19520

Since weaveworks isn't under our support matrix, we don't need to move it under the Rancher Dockerhub repo.


Add AsyncChannel based ServerBootstrap.bind() methods

Motivation
In my previous PR, we added a new async bridge from a NIO Channel to Swift Concurrency primitives in the from of the NIOAsyncChannel. This type alone is already helpful in bridging Channels to Concurrency; however, it is hard to use since it requires to wrap the Channel at the right time otherwise we will drop reads. Furthermore, in the case of protocol negotiation this becomes even trickier since we need to wait until it finishes and then wrap the Channel.
Modification
This PR introduces a few things:

New methods on the ServerBootstrap which allow the creation of NIOAsyncChannel based channels. This can be used in all cases where no protocol negotiation is involved.
A new protocol and type called NIOProtocolNegotiationHandler and NIOProtocolNegotiationResult which is used to identify channel handlers that are doing protocol negotiation.
New methods on the ServerBootstrap that are aware of protocol negotiation.

Result
We can now easily and safely create new AsyncChannels from the ServerBootstrap

I wonder if it's a good time for us to explore (3). However, as this is SPI we can merge this without that change and investigate it later.

I would prefer to merge this now to unblock the HTTP2 work and will track this as an open item before we make the APIs public


social auth / Oauth - insights?

any insights?

Hi @gotexis ,
This package is relying on Python Social Auth:
https://github.com/flavors/django-graphql-social-auth
If you have any questions, please let me know.

@mongkok
Thanks!
I was struggling to get anything right until I saw the project you posted. Let me research into it and will update on any progress.

Hi @gotexis ,
I would just add that you can use cookie authentication instead of storing the token:
https://django-graphql-jwt.domake.io/en/stable/authentication.html#per-cookie


add chinese readme file

add chinese readme file .
add chinese readme file hyperlinks on readme file.

I cannot read Chinese, but I'm going to assume that this is correct. Since it is no actual code changes, I'm going to go ahead to merge this.


Simplified some private methods

Made use of es6 lambdas, and higher order functions defined on arrays.

Rebase please

Closing due to inactivity. I also think we should keep these hotter code paths imperative-style since they perform better, even though I do prefer functional otherwise.


ci(release): use new set of credentials for GPG and Maven Central

What
Use the Vault secrets accessed to run the Release/Snapshots.
Those secrets are managed by the Release team and they provided specific ones for this project.
Why
The release team requested to use them.

On hold for now. https://github.com/elastic/elastic-otel-java/pull/71 was merged, but there are some missing configurations when accessing the Vault secrets, so we are waiting for feedback from the system owners.


Kahramanmaras Istiklal University domain addition

Kahramanmaras Istiklal University domain addition

@mehmetgok Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@mehmetgok You might miss my previous comment. Please react.

@mehmetgok I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


Update CHANGELOG.md

Minor grammar / spelling fix in release notes.

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Tests pass?
no

Fixed issues
Minor grammar / spelling correction in release notes.

Merged. Thanks!


Change default param type from SecretString to SecureString.

Change default parameter type from SecretString to SecureString.
SecretString is a term from AWS Secrets Manager, and is not valid with SSM Parameter Store. The corresponding type is "SecureString".

@dylanbannon I think this is ready for code review. Who can look at this? Thanks.

/test all


Wiki contribution

I have finished a page detailing how to add a new floor as well as other minor edits
Please review and merge (preferably rebase)
https://github.com/CanInBad/BDCC_wiki/tree/modified1
diff

Looks nice
Can you help me with how to merge it? x3
I did git clone https://github.com/Alexofp/BDCC.wiki.git
what would I do next x3

I did it but looks like it doesn't like that you added .md at the end

do you want me to fix or would you like to fix it?

Thank you <333


createImageFromImageBitmap throws when passed valid types

Steps to reproduce
Use createImageFromImageBitmap with a video element.
Expected results
Don't throw exception when passed valid data.
https://developer.mozilla.org/en-US/docs/Web/API/createImageBitmap
This function supports all sorts of sources, not just ImageBitmaps, but the dart code has an unneeded instanceof check inserted. This should just be deleted, or it should be corrected to properly check against the valid types

 if (!domInstanceOfString(imageSource, 'ImageBitmap')) {
    throw ArgumentError('Image source $imageSource is not an ImageBitmap.', 'imageSource');
  }

HTMLImageElement
SVGImageElement
HTMLVideoElement
HTMLCanvasElement
Blob
ImageData
ImageBitmap
OffscreenCanvas
This will be blocking #144591 unless the video_player package manually calls the browser function and then passes the result forward:

    final JSAny tmp =
        await promiseToFuture<JSAny>(web.window.createImageBitmap(widget.element));
    final ui.Image img = await ui_web.createImageFromImageBitmap(tmp);

Actual results
Throws exception
Code sample
<video src='somesource' id='sample' />

import 'dart:web';
import 'dart:ui_web' as ui_web;

createImageFromImageBitmap(document.getElementById('sample')); // throws

Screenshots or Video
https://developer.mozilla.org/en-US/docs/Web/API/createImageBitmap
Logs
No response
Flutter Doctor output
n/a

Could you please share a complete sample code so that we can verify this?

https://github.com/flutter/packages/pull/6286
Implementing this pull request was the source of the bug. This code:

 final tmp =
        await promiseToFuture(web.window.createImageBitmap(widget.element));
    final ui.Image img = await ui_web.createImageFromImageBitmap(tmp);

Should be simply:

 final ui.Image = await ui_web.createImageFromImageBitmap(tmp);

If you pull down the commit for the pull request, change your pubspec.yaml to reference the video player from pull request package instead of the pub.dev version, and make that change in video_player_web.dart:211 to remove the workaround, you'll see the crash with this sample:

import 'dart:async';

import 'package:flutter/material.dart';
import 'package:video_player/video_player.dart';
import 'package:video_player_web/video_player_web.dart';

void main() {
  VideoPlayerPlugin.renderVideoAsTexture = true;
  runApp(const VideoPlayerApp());
}

class VideoPlayerApp extends StatelessWidget {
 const VideoPlayerApp({super.key});

 @override
 Widget build(BuildContext context) {
   return const MaterialApp(
     title: 'Video Player Demo',
     home: VideoPlayerScreen(),
   );
 }
}

class VideoPlayerScreen extends StatefulWidget {
 const VideoPlayerScreen({super.key});

 @override
 State<VideoPlayerScreen> createState() => _VideoPlayerScreenState();
}

class _VideoPlayerScreenState extends State<VideoPlayerScreen> {
 late VideoPlayerController _controller;
 late Future<void> _initializeVideoPlayerFuture;

 @override
 void initState() {
   super.initState();

   // Create and store the VideoPlayerController. The VideoPlayerController
   // offers several different constructors to play videos from assets, files,
   // or the internet.
   _controller = VideoPlayerController.networkUrl(
     Uri.parse(
       'https://flutter.github.io/assets-for-api-docs/assets/videos/butterfly.mp4',
     ),
   );

   // Initialize the controller and store the Future for later use.
   _initializeVideoPlayerFuture = _controller.initialize();

   // Use the controller to loop the video.
   _controller.setLooping(true);
 }

 @override
 void dispose() {
   // Ensure disposing of the VideoPlayerController to free up resources.
   _controller.dispose();

   super.dispose();
 }

 @override
 Widget build(BuildContext context) {
   return Scaffold(
     appBar: AppBar(
       title: const Text('Butterfly Video'),
     ),
     // Use a FutureBuilder to display a loading spinner while waiting for the
     // VideoPlayerController to finish initializing.
     body: FutureBuilder(
       future: _initializeVideoPlayerFuture,
       builder: (context, snapshot) {
         if (snapshot.connectionState == ConnectionState.done) {
           // If the VideoPlayerController has finished initialization, use
           // the data it provides to limit the aspect ratio of the video.
           return AspectRatio(
             aspectRatio: _controller.value.aspectRatio,
             // Use the VideoPlayer widget to display the video.
             child: VideoPlayer(_controller),
           );
         } else {
           // If the VideoPlayerController is still initializing, show a
           // loading spinner.
           return const Center(
             child: CircularProgressIndicator(),
           );
         }
       },
     ),
     floatingActionButton: FloatingActionButton(
       onPressed: () {
         // Wrap the play or pause in a call to `setState`. This ensures the
         // correct icon is shown.
         setState(() {
           // If the video is playing, pause it.
           if (_controller.value.isPlaying) {
             _controller.pause();
           } else {
             // If the video is paused, play it.
             _controller.play();
           }
         });
       },
       // Display the correct icon depending on the state of the player.
       child: Icon(
         _controller.value.isPlaying ? Icons.pause : Icons.play_arrow,
       ),
     ),
   );
 }
}

FYI, the ui_web API is specifically called createImagefromImageBitmap because it only actually accepts ImageBitmap objects, not other image sources. This was my first pass at this API and I kept it intentionally constrained for a couple of reasons:

ImageBitmap objects are essentially immutable, as opposed to objects like HTMLVideoElement. With immutable objects like ImageBitmap, the rendering behavior won't change based on when we actually use the resource, but for mutable objects we may have subtle behavior changes if some of our rendering code defers use of the object, especially across an async boundary.

ImageBitmap objects are transferable, but not all image sources are. This is particularly important for the experimental skwasm renderer which does its rendering on a web worker.

createImageFromImageBitmap takes ownership of the image bitmap itself, and therefore will explicitly dispose of it when the engine is done with it. That is probably less likely to be the case for something like a HTMLVideoElement where the calling code probably retains ownership of the object after it has made the API call.

This was sort of a simplification decision for the first pass at this API. I could imagine ways that this contract could be more flexible, and the engine could do its own copying to an ImageBitmap object internally if it needed. But for the first pass, I decided to basically pass those concerns onto the calling code instead. Definitely open to revisiting this to make a richer API but since it involved some more nuanced design decisions I decided a smaller scoped change would be a good first step.

@eyebrowsoffire I think the issue is that no one needs to call this API with an ImageBitmap, so while it may make sense to constrain the API, people need to be able to get a VideoFrame, a VideoElement, a native SVG, etc. into flutter. Right now, that requires a double copy and calling the browser function on your own wish js interop for every scenario that needs to use this API that I'm aware of (SVG, WebRTC, Video) are there some other places where someone is attempting to use this API? Ok, it's doable, but it's wasteful and it results in extra code and dealing manually with disposal of a temporary ImageBitmap anyway.
While unfortunately you can't transfer DOM elements, for cases like media streaming there are solutions which let you use transferable objects like VideoFrame/WebCodecs where the API gives you a VideoFrame directly which can then be bound directly to a WebGL texture. VideoFrames are transferable resources and you really don't want to go to ImageBitmap, because the videos are often in a different color space like YUV and you want to get them to the GPU or over to the worker without a bunch of extra mutation and GC. Maybe #139271 could make this more efficient, but if you have to create image bitmaps for every frame just to get it into the texture, you're already potentially starting out in a bad spot from a GC perspective in a lot of browsers.
Right now, there's no pathway for anything that's not an ImageBitmap, which prevents doing these types of things as efficiently as they could be done. Certainly one approach of using a VideoFrame is createImageBitmap from the VideoFrame, but that often requires YUV->RGB conversion and extra memory being used so it's probably not the ideal path if it can be avoided.
Ideal end state would be a zero copy way to use the types of things I can get into a WebGL texture with zero copies into a. WebGL with zero copies. I get there are some constraints because of the decision to move the renderer into web workers, but it's a lot of extra hoops to jump through right now and extra bad in non chrome browsers that don't have as efficient pathways to move these resources around.

@jezell yep I agree with everything you're saying. The way the API is set up right now does end up causing extra unnecessary copies in some cases. Supporting VideoFrame itself should be straightforward and have the same semantics as ImageBitmap (immutable and transferable), so that might be a good place to start. But a separate API that doesn't transfer ownership might be needed for HTML elements.

@eyebrowsoffire wonder if exposing CanvasKit.MakeImageFromCanvasImageSource as an alternative would make it a little easier to avoid this and provide a more generic version?
https://github.com/google/skia/blob/main/modules/canvaskit/future_apis/ImageDecoder.md
If you always have to create an ImageBitmap to use this specific API, maybe it should accept ImageBitmap instead of JSAny in the signature to get rid of the confusion rather than doing a runtime check? Would also make the docs a little nicer since they could link straight to the ImageBitmap + createImageBitmap in the web package.

@jezell Hmm, I'm following the given steps above, and running the example on Chrome but can't see the crash. I'm sure that I'm on video_player_web: 2.4.0 which is from your PR above.

I don't think we should close this. This issue is a valid request for loosening the restrictions on createImageFromImageBitmap. I believe @jezell has worked around the issue in the package, hence why you are not reproducing the issue using the original repro steps. We don't need a repro case for this issue, it's actionable as-is.


Navbar is not responsive

we have to add the hamburger menu on this so that user can see the homepage
Can you assign this issue to me under GSSOC'23?

We don't need hamburger menu.

ok, as your wish.. but if you not add this how the user can read the pages if the content is not visible for that navbar?


Fix nullability of List

What does the pull request do?
This PR fixes the compiler emitting a CS8670 warning when using a collection initializer with the Filters property.
What is the current behavior?
new OpenFileDialog
{
	Filters =
	{
		new FileDialogFilter
		{
		}
	}!
}

Produces a CS8670 warning, which does not make sense, since the property is automatically initialized with an empty list.
What is the updated/expected behavior with this PR?
No warning is emitted by the compiler.
Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

You can test this PR using the following package version. 11.0.999-cibuild0032720-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


Add EditGroups support

To make it easier to undo uploads, it could make sense to track uploads made via Pattypan with EditGroups. There is an instance of this tool running at https://editgroups-commons.toolforge.org.
It is quite easy to add support for this on Pattypan's side: all it takes is to add a link in the edit summary, as described here:
https://commons.wikimedia.org/wiki/Commons:Edit_groups/Adding_a_tool#For_custom_bots
I am suggesting this while acknowledging that EditGroups is (in my opinion) a temporary and unreliable measure to mitigate the lack of support for edit groups (or "changesets", to use the OSM term) in MediaWiki itself (or as an extension).

We should definitely implement edit groups. Thank you for such detailed documentation/code examples!


Add upgrade flow for report field feature in qbo/xero

Explanation of Change

Add upgrade flow for report field feature in qbo/xero
Fixed Issues

$ https://github.com/Expensify/App/issues/52397
PROPOSAL: https://github.com/Expensify/App/issues/52397#issuecomment-2475483069
Tests

Precondition: Create a collect workspace and connect to QBO/Xero

Import > Classes > Report Fields
Import > Customers > Report Fields
Import > Locations > Report Fields
Import > Tracking Categories > Map Xero Cost Centres to > Report Fields
Import > Tracking Categories > Map Xero Region to > Report Fields

Open each of the import flows above
Verify that an upgrade page is opened
Click on Upgrade
After Got it page appears, click on Got it button
Verify that Import Report Fields is updated and we navigate to the correct page

[x] Verify that no errors appear in the JS console

Offline tests

None
QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Open each of the import flows above
Verify that an upgrade page is opened
Click on Upgrade
After Got it page appears, click on Got it button
Verify that Import Report Fields is updated and we navigate to the correct page

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/2736b3d9-6404-4154-ab9c-6d43079ffc2f

Android: mWeb Chrome
https://github.com/user-attachments/assets/53841cd7-7eeb-429f-81ee-2f95ec7ee34d

iOS: Native
https://github.com/user-attachments/assets/453d4718-0aba-4eef-8a71-2cc0285ed58d

iOS: mWeb Safari
https://github.com/user-attachments/assets/41e1af4a-16d5-437a-a2a9-8e369e770018

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/abc428ee-43e6-4149-bea5-6ae284158f42
https://github.com/user-attachments/assets/c6a488fc-6e0f-47e6-9227-f3e67ae53abb
https://github.com/user-attachments/assets/a11faf23-2363-4ea0-a421-79ef98995038
https://github.com/user-attachments/assets/b802a41b-46c2-42e4-8a82-ff280419097a
https://github.com/user-attachments/assets/c3184939-b59b-4ea5-a1e7-3db14b13af22

MacOS: Desktop
https://github.com/user-attachments/assets/d5636550-2dfc-4893-a8dc-57744bf68310

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Docker manifest integration

docker v2 manifest integration with artifact manager e2e
removal of /tmp file system for docker v2 manifest files
integration of node_manager put_artifact api
added and improved existing use cases
closes #213

@mgrand i have taken care of most of the comments, please re-review

As we talked about this in Slack, before merge can you squash this PR into meaningful commits so that the commit messages are useful and readable.

@betarelease

As we talked about this in Slack, before merge can you squash this PR into meaningful commits so that the commit messages are useful and readable.
I usually make frequent commits, sometime just because time has passed and I want to be able to look at my work. There is not always a meaningful comment to be made. I might just be committing because I am breaking for lunch.

Do we need to stop using git in this way?  Should we only make commits when we have reached at state that we can articulate in a way that will be clear to others? This will make using git less effective.

@betarelease i see all your comments are related to renaming and some of them in the code which has not been changed in this PR, so i think its better i address them in different PR , the one which is following this one #312 and this one is blocking my next one too.

Yes for the comments that do pertain to old code I do not expect it to be fixed since this PR is pretty involved already.(Although I would like to see that change in the future where we refactor and clean up stuff around the code we are working on).
For all the comments I made that were lines changed in this code, I think those should be addressed as part of this PR.
If this does indeed block another PR, we need to consider that as required waiting time, since reviewers will need time(days) to review and that is just part of the process.

(I did not find a way to respond to this inline so I am copying the conversation here to preserve context)
@mgrand
Do we need to stop using git in this way? Should we only make commits when we have reached at state that we can articulate in a way that will be clear to others? This will make using git less effective.
Using git to make frequent commits helps with preserving work and moving forward. Having said that, before we create a PR I expect the committer to break that PR into 3-4 meaningful commits(squash them locally, cleanup commit messages so that they read well to the users, add more context etc.) and then submit a PR.

Please share a link to documentation describing how to do this. It is not
something I am familiar with.
On Thu, Feb 3, 2022 at 4:51 PM 'Sudhindra Rao' via persia-devops <
@.***> wrote:

(I did not find a way to respond to this inline so I am copying the
conversation here to preserve context)
@mgrand https://github.com/mgrand
Do we need to stop using git in this way? Should we only make commits when
we have reached at state that we can articulate in a way that will be clear
to others? This will make using git less effective.
Using git to make frequent commits helps with preserving work and moving
forward. Having said that, before we create a PR I expect the committer to
break that PR into 3-4 meaningful commits(squash them locally, cleanup
commit messages so that they read well to the users, add more context etc.)
and then submit a PR.
—
Reply to this email directly, view it on GitHub
https://github.com/pyrsia/pyrsia/pull/301#issuecomment-1029435370, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AWLSB4ZTJMOXAVS6BDBVX7DUZL2GXANCNFSM5NB2OWZA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because your review was requested.Message ID:
@.***>

As we talked about this in Slack, before merge can you squash this PR into meaningful commits so that the commit messages are useful and readable.

@betarelease This is the configuration I have forced on everyone since the beginning.
There is no need to take any manual action.


Speedup Antlr runtime

Either contribute back to the Antlr main or create a fork maximized for performance.
the Surelog/third_party/antlr already contains some optimizations where dynamic casting has been replaced by type checking with a class member bitfield.
Relevant discussions with the Antlr community:
https://github.com/antlr/antlr4/issues/2584
https://github.com/antlr/antlr4/issues/1790
https://groups.google.com/forum/#!searchin/antlr-discussion/alainmarcel|sort:date

@hzeller can you share with @octaviis some of your findings when you looked at the Antlr runtime?
@octaviis has some time to dive into it.

Here are the things I know we can do (Low hanging fruits):

Profile Surelog grammar some more to find new grammar level optimizations
Replace Leaf grammar rules used for Lexer by AST 2 Serialization C++ code
Systematically (by script?) replace all dynamic casting by bit field compare (the trick I already manually applied in some parts of the code to get 2x speedup)

Nothing happening on this front.


add support for semantic-ui.com ?

hi
first thanks for your work
would this be hard to adapt to work with semantic-ui (semantic-ui.com) ?

 :)
It shouldn't be that hard to switch out the components used. But I don't have the time to support anything than bootstrap right now. As mentioned in the readme/docs: "If you don't want to use bootstrap, just fork the repo and customize it to your needs!".
Cheers!


Add doctests to release notes

Any other changes?

LGTM. thanks Max

first of all, current master fails to build on RTD, which is because of a title underline being too short, and a typo in the new dev version section: https://github.com/pydata/xarray/blob/788cd605d8270c6aeb6435eb0760eb5f2d97228a/doc/whats-new.rst#L18-L22
Other than that, I noticed we had a few PRs that merged into stable, which means that these commits were lost during the release. I guess these PRs were opened using RTD's Edit on Github links while viewing the stable docs, so a fix would be related to #2821.

Thanks for spotting those @keewis , let me fix

I cherry-picked the commits to master, so only the fix for the Edit on Github is left

Ah great! I was just trying to figure out why I couldn't find them! Thanks!

In lieu of fixing https://github.com/pydata/xarray/issues/2821, we could add a step to the release doc to merge stable into master — would that fix the problem?

it should, but I'm not sure if we'd have other issues instead. I guess we could do both?


Polar line plot

Feature Proposal
Hello,
Firstly, I'd like to thank you for the excellent work on this library.
I was wondering if there's any roadmap or intention to incorporate a line polar diagram option into the library's features. I think it could significantly expand the library's utility for various applications.
Thank you for your consideration,
Best regards,
Gianluca
Possible Implementation
No response

I agree that this would be a great improvement.
The basic need is that the data set values should not be limited to the crosspoints between angle lines and grid lines, but every point inside the plot area can contain a point from the dataset.
The dataset points can be connected (interpolated) or plotted as standalone.


CI: K8sValidatedKafkaPolicyTest KafkaPolicies test failed because kafka image went into error state

Stacktrace

/home/jenkins/workspace/Ginkgo-CI-Tests-Pipeline/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:330
Kafka Pods are not ready after timeout
Expected
    <*errors.errorString | 0xc4204a7c00>: {
        s: "Timeout reached: could not get Pods",
    }
to be nil
/home/jenkins/workspace/Ginkgo-CI-Tests-Pipeline/src/github.com/cilium/cilium/test/k8sT/KafkaPolicies.go:66

f0c5341e_K8sValidatedKafkaPolicyTest_KafkaPolicies.zip

Seen again:
https://jenkins.cilium.io/job/cilium-ginkgo/job/cilium/job/master/1004/testReport/k8s-1/7/K8sValidatedKafkaPolicyTest_KafkaPolicies/

As a note to others, these seem to not have any useful logs, related to https://github.com/cilium/cilium/issues/4414 If you spot one with logs, please do include it here

Build failure: https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/2854/
Stacktrace:
/home/jenkins/workspace/Ginkgo-CI-Tests-Pipeline/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:330
Kafka Pods are not ready after timeout
Expected
    <*errors.errorString | 0xc4210501b0>: {
        s: "Timeout reached: could not get Pods",
    }
to be nil
/home/jenkins/workspace/Ginkgo-CI-Tests-Pipeline/src/github.com/cilium/cilium/test/k8sT/KafkaPolicies.go:93

Logs:
9acb0442_K8sValidatedKafkaPolicyTest_Kafka_Policy_Tests_KafkaPolicies.zip

The root cause is:
default       kafka-broker-910202233-tz1k2           0/1       CrashLoopBackOff   4          5m        <IP_ADDRESS>      k8s2

We don't have logs of kafka broker pods on failure

myself and @ianvernon came to the same conclusion while going through the logs. It would be of great help if CI could capture app logs as well on failure, to debug failures like these. @eloycoto @ianvernon

Echoing @manalibhutiyani here - we see that the pod is in an error state but don't have the Kafka broker pod logs, and thus need to gather them during the build to help triage this.

The test failure in Cilium-PR-Ginkgo-Tests-K8s is similar but a bit different. Not sure if this is related yet or not:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-K8s/320/testReport/k8s-1/11/Non_release_k8s_versions___K8sValidatedKafkaPolicyTest_Kafka_Policy_Tests_KafkaPolicies/
/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-K8s/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:373
Failed to produce to empire-hq on topic deathstar-plans
Expected
    <*errors.errorString | 0xc420538190>: {
        s: "ExecKafkaPodCmd: command 'kubectl exec -n default empire-hq-6c49cd55fc-n5c72 sh -- -c \"echo 'deathstar reactor design v3' | ./kafka-produce.sh --topic deathstar-plans\"' failed '' || '[2018-06-11 21:52:51,959] WARN Removing server kafka-service:9092 from bootstrap.servers as DNS resolution failed for kafka-service (org.apache.kafka.clients.ClientUtils)\norg.apache.kafka.common.KafkaException: Failed to construct kafka producer\n\tat org.apache.kafka.clients.producer.KafkaProducer.<init>(KafkaProducer.java:416)\n\tat org.apache.kafka.clients.producer.KafkaProducer.<init>(KafkaProducer.java:288)\n\tat kafka.producer.NewShinyProducer.<init>(BaseProducer.scala:40)\n\tat kafka.tools.ConsoleProducer$.main(ConsoleProducer.scala:48)\n\tat kafka.tools.ConsoleProducer.main(ConsoleProducer.scala)\nCaused by: org.apache.kafka.common.config.ConfigException: No resolvable bootstrap urls given in bootstrap.servers\n\tat org.apache.kafka.clients.ClientUtils.parseAndValidateAddresses(ClientUtils.java:64)\n\tat org.apache.kafka.clients.producer.KafkaProducer.<init>(KafkaProducer.java:373)\n\t... 4 more\ncommand terminated with exit code 1\n'",
    }
to be nil
/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-K8s/src/github.com/cilium/cilium/test/k8sT/KafkaPolicies.go:117

kafka itself is in running state:
STEP: Testing basic Kafka Produce and Consume
===================== TEST FAILED =====================
cmd: kubectl get pods -o wide --all-namespaces
NAMESPACE     NAME                                   READY     STATUS    RESTARTS   AGE       IP              NODE
default       app1-c4954c58c-4g77p                   1/1       Running   0          3m        <IP_ADDRESS>      k8s1
default       app1-c4954c58c-lwbhd                   1/1       Running   0          3m        <IP_ADDRESS>     k8s1
default       app2-5b59d5764b-8gxl5                  1/1       Running   0          3m        <IP_ADDRESS>       k8s1
default       app3-6d745c45f6-9msmh                  1/1       Running   0          3m        <IP_ADDRESS>      k8s1
default       empire-backup-74547b5f6f-kplfh         1/1       Running   0          35s       <IP_ADDRESS>     k8s2
default       empire-hq-6c49cd55fc-n5c72             1/1       Running   0          36s       <IP_ADDRESS>      k8s1
default       empire-outpost-8888-5d8d98fb99-mqcz9   1/1       Running   0          36s       <IP_ADDRESS>      k8s2
default       empire-outpost-9999-6666dfb499-bg7xf   1/1       Running   0          35s       <IP_ADDRESS>      k8s2
default       kafka-broker-79cd7b588c-zfmfb          1/1       Running   0          36s       <IP_ADDRESS>      k8s2
default       zookeeper-767d644449-dckwm             1/1       Running   0          36s       <IP_ADDRESS>     k8s2
kube-system   cilium-gdvcz                           1/1       Running   0          18m       <IP_ADDRESS>   k8s1
kube-system   cilium-kdjvk                           1/1       Running   0          18m       <IP_ADDRESS>   k8s2
kube-system   coredns-7997f8864c-hrxf6               1/1       Running   0          27m       <IP_ADDRESS>     k8s2
kube-system   coredns-7997f8864c-qzlhc               1/1       Running   0          27m       <IP_ADDRESS>     k8s1
kube-system   etcd-k8s1                              1/1       Running   0          27m       <IP_ADDRESS>   k8s1
kube-system   kube-apiserver-k8s1                    1/1       Running   1          27m       <IP_ADDRESS>   k8s1
kube-system   kube-controller-manager-k8s1           1/1       Running   0          26m       <IP_ADDRESS>   k8s1
kube-system   kube-dns-59d8c5f9b5-2ln5w              3/3       Running   0          27m       <IP_ADDRESS>     k8s2
kube-system   kube-proxy-c9z75                       1/1       Running   0          27m       <IP_ADDRESS>   k8s1
kube-system   kube-proxy-rbccn                       1/1       Running   0          22m       <IP_ADDRESS>   k8s2
kube-system   kube-scheduler-k8s1                    1/1       Running   0          27m       <IP_ADDRESS>   k8s1

This PR need to be in to be able to gather the logs: https://github.com/cilium/cilium/pull/4478

Update: Unfortunately changing the kafka docker image to a more stable tag did not fix the issue.
Without app logs this will be difficult to debug further.
The microscope pr waiting to be merged, will help know what's happening.
I am waiting on the the microscope work #4452
and enabling collecting app logs in CI: #4463

#4476 merged (which fixes #4463 ).

One of the cilium logs points to these:
2018-06-12T09:08:26.518915917Z level=debug msg="Matching cilium endpoint for container create event does not exist yet" containerID=3eca3a1d3a maxRetry=20 retry=1 subsys=workload-watcher willRetry=false
2018-06-12T09:08:26.518926591Z level=info msg="No request received to manage networking for container" containerID=3eca3a1d3a maxRetry=20 subsys=workload-watcher willRetry=false
2018-06-12T09:08:26.719018299Z level=debug msg="Skipping network because of gateway mismatch" endpointID=411c9c45ccdebc22f4619572aab767adc2697ef8e2db4767a80db2b88e8f450b obj="&{<nil> [] [] d42e425176653b2b6ca1726b6d9fecc7cec9bd5abcb1053de369e59ac0122322 411c9c45ccdebc22f4619572aab767adc2697ef8e2db4767a80db2b88e8f450b   0   0 }" subsys=workload-watcher
2018-06-12T09:08:26.719039715Z level=debug msg="IP address assigned by Cilium could not be derived from container event" containerID=8c2de3b7cb subsys=workload-watcher
2018-06-12T09:08:26.719042708Z level=debug msg="Trying to associate container with existing endpoint" containerID=8c2de3b7cb containerName=/k8s_POD_kube-dns-1992960195-7hvb3_kube-system_1524515b-6e1f-11e8-af52-0800274fedc6_0 endpointID=0 identityLabels="k8s:io.kubernetes.pod.namespace=kube-system,k8s:k8s-app=kube-dns" maxRetry=20 retry=1 subsys=workload-watcher willRetry=false
2018-06-12T09:08:26.719045213Z level=debug msg="Matching cilium endpoint for container create event does not exist yet" containerID=8c2de3b7cb maxRetry=20 retry=1 subsys=workload-watcher willRetry=false
2018-06-12T09:08:26.719047262Z level=info msg="No request received to manage networking for container" containerID=8c2de3b7cb maxRetry=20 subsys=workload-watcher willRetry=false
2018-06-12T09:08:26.918894798Z level=debug msg="IP address assigned by Cilium could not be derived from container event" containerID=55707d0b2f subsys=workload-watcher
2018-06-12T09:08:26.918969669Z level=debug msg="Trying to associate container with existing endpoint" containerID=55707d0b2f containerName=/k8s_kube-controller-manager_kube-controller-manager-k8s1_kube-system_873cbfd8453e963a86a881de05df1557_0 endpointID=0

This shows that kube-dns is not being managed by cilium? Is this normal?


Multi-Stage Docker Image Build

Multi-Stage Docker Image Build and Push to GHCR
Create a GitHub Actions workflow to build and push three Docker images to GitHub Container Registry (GHCR), each building upon the last. This will replace the current docker image build. Docker images are tagged with current commit SHA, and build can be skipped if the image already exists.
Base Image (tt-mlir-base-ubuntu-22.04)

Start with ubuntu:22.04.
Install build tools and project dependencies

Project Build Image (tt-mlir-ubuntu-22.04)

Use the base image.
Clone the project repository and prepare the toolchain folder

IRD Image (tt-mlir-ird-ubuntu-22.04)

Extend the project build image.
Install ssh and sudo for access and administrative tasks.

@vmilosevic Is there an ETA for the IRD image? Some builds don't currently work on the standard ubuntu IRD image and using the base without ssh is quite complicated for development.

There are two docker images:
ghcr.io/tenstorrent/tt-mlir/tt-mlir-ird-ubuntu-22-04:latest
and
ghcr.io/tenstorrent/tt-mlir/tt-mlir-base-ird-ubuntu-22-04:latest
base-ird contains only build dependencies and is a much lighter image. With it, you need to build the toolchain first.
ird contains the prebuilt toolchain and is ready to build the project, but it is much larger and you will need to wait longer for the lab machine to download it.
You can make reservations using these images from the command line.
ird reserve --timeout 1-0 --team bgd --docker-image ghcr.io/tenstorrent/tt-mlir/tt-mlir-base-ird-ubuntu-22-04:latest --machine bgdepyc01

Or, if you are using the VS Code IRD extension, just add them to the Docker list.
Set of commands I used to test the base image:
git clone git@github.com:tenstorrent/tt-mlir.git
cd tt-mlir/
export TTMLIR_TOOLCHAIN_DIR=/opt/ttmlir-toolchain
sudo mkdir -p $TTMLIR_TOOLCHAIN_DIR && sudo chown -R $USER $TTMLIR_TOOLCHAIN_DIR
cmake -B env/build env
cmake --build env/build
source env/activate
cmake -G Ninja -B build -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DTTMLIR_ENABLE_RUNTIME=ON -DTTMLIR_ENABLE_RUNTIME_TESTS=ON -DTTMLIR_ENABLE_STABLEHLO=ON
cmake --build build --config Release
cmake --build build -- ttrt
cmake --build build -- check-ttmlir

With the toolchain image, you skip the Toolchain build part. The image still has a few quirks, you will need to change the ownership of the toolchain
folder to your user (or 777), and you may need to install vim if you use it as the default git editor. I'll fix that in the next iteration.
git clone git@github.com:tenstorrent/tt-mlir.git
cd tt-mlir/
export TTMLIR_TOOLCHAIN_DIR=/opt/ttmlir-toolchain
sudo mkdir -p $TTMLIR_TOOLCHAIN_DIR && sudo chown -R $USER $TTMLIR_TOOLCHAIN_DIR
source env/activate
cmake -G Ninja -B build -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DTTMLIR_ENABLE_RUNTIME=ON -DTTMLIR_ENABLE_RUNTIME_TESTS=ON -DTTMLIR_ENABLE_STABLEHLO=ON
cmake --build build --config Release
cmake --build build -- ttrt
cmake --build build -- check-ttmlir


No notification shown when using python 2 venv

Testing #17537

@meganrogge Could you paste here the logs from the Python output panel for the scenario that failed?

User belongs to experiment group 'All'

and that's even though I ran
 C:\Python27\python.exe -m virtualenv .venv without errors

I actually think the extension wasn't activating - works well now!


Support nested path ("dot notation") for $unset operator

(note: sub-task of #74 )
Although there are common pieces wrt "dot notation" paths for update operations, there are some differences so I'll first tackle simplest case of $unset and probably create separate issues for other operators too -- this helps keep PRs from growing too big.

PR #154 ready for review.


Add design notes to docs

As the title suggests adds design notes for the fake tensor and deferred module initialization to the docs.

Thanks for the great details around documentation! All the various design considerations such as bidirectional graph for mutable tensors, being able to trace through the variable interface, etc are super cool - possibly we can post this somewhere like pytorch dev discuss to raise visibility and foster additional discussion!

Thanks! Yes, will do along with the release of PyTorch v1.12.


lattice for Windows ?

Is there a plan to support Windows ?
I have read the latest Spring Guides, but it seems the lattice CLI only supports Mac and Linux. When the Windows system will be the first class citizen?
Thanks.

https://github.com/spring-guides/gs-spring-cloud-and-lattice/issues/2

@cf-gitbot  Thanks.

Hi @hantsy,
Some people have attempted at getting Lattice to work (see issue #80 and #81) on Windows, but you're right, it's not officially a supported platform. We have written a story to support windows and are tracking it here: 85921380. You can follow that ticket in Tracker to monitor how we make progress against it.
We'll continue to iterate on making it easier for Windows folks in the meantime with documentation fixes and hopefully the occasional workaround.
--
Marco Nicosia
Product Manager
Pivotal Software, Inc.

@menicosia , Thanks for your response. Hope there is a Getting started guide for Windows as expected.


Have logged-in/out versions of the collective page queries

For performance, it would be great to have two versions of the collective page queries to avoid fetching these fields for logged-out users. Something like:
const commonFields = gql`
  fragment on Collective {
    id
    name
    host { id name }
    ...
  }
`

const loggedOutQuery = gql`
  Collective {
    ...commonFields
  }
`

const loggedInQuery = gql`
  Collective {
    ...commonFields
    host { id ...ExpenseHostFields }
  }
`

Originally posted by @Betree in https://github.com/opencollective/opencollective-frontend/pull/8707#pullrequestreview-1332226171

cc @kewitz


Making file type an optional argument

If input/output types are not mandatory, should they have a default value then? How does a default behave for an optional parameter?
I will check a code generator for this, as I expect problems.

Any feedback on your tests, @aniewielska? Intuitively I would think that handling defaults should be pretty standard for any validator and code generator based on JSON Schema...

I think at the moment the type is still mandatory, if we leave defaults with optional. I think the spec was wrong previously in combining defaults and required. But the behaviour we want is no default. When no type of in/output is provided the implementation needs to figure it out itself and not assume it is FILE.

Given that the accepted values are defined in an enum, the value passed for  tesFileType has to be a value matching one of the enumerated values. If there's only FILE and DIRECTORY in the enum, one couldn't send a valid request omitting this if there's no default set. I would propose adding UNSET or UNSPECIFIED or something to that effect to the enum and then use that as default.

Right. So, if we cannot have null enums, I vote for adding UNSPECIFIED and making it default as it nicely described th intention here that the caller would not like to specify the type.


Alerting Specifications

Store events via the management api in a storage backend.

Investigated ways of implemented sorted sets in etcd :

it is possible to sort by key, so that is probably the way to go for now

that means the keys for events will have to be timestamps in unix epoch format, e.g.<PHONE_NUMBER>

Instead of including sorted sets as an interface over KVStoreClients, we'll just implement sorted as a wrapper over the returned set of keys

Spent a decent amount of time going over implementation details of the alerting vertical with joe today.
Some of the key takeaways are:

Man in the middle dispatcher : handles "events" in the alerting system
think something like

func() Dispatch(e) {
    persist(e)

   // handle cases based on event labels
   forwardToEndpoint(e)
}

Alerting endpoints & dynamic webhooks to point to them, can automatically be handled via AlertManager HTTP api (we will maintain an upstream replicaset of AlertManager) using AlertManager receivers & routers respectively
----> Alerting endpoints & dispatcher will wrap around those

Alert conditions are yanked from the source that should implement it (upstream, plugins, etc...)

want to create storage interfaces for CRUDING alert events/ conditions/ endpoints in stores.go so the upstream can forward it to the api that should implement it

Renaming this ticket from Alert Event Store to Alerting Specifications, for several reasons:

we discovered early on that etcd would scale very poorly for storing alert logs (even a small size, e.g. 10000)
there is currently no backend store for this usecase in the upstream, with no plugins installed
Defining this store is heavily related to the way alerting is implemented into the upstream

Our design has separated :

Alert logs : persisting alert events
Alert conditions : specification for checking if an alert is triggered, evaluated at the source (e.g. if opni logging wants to have an alert condition, the check happens inside opni logging)
Alert notification targets : (POC) config wrapper & management of AlertManager backend

So that our man in the middle dispatcher can use things from the above to take action on alerts that should be dispatched.

For this sprint, I've defined:

An Alerting backend store interface
An Alerting plugin
Dependency injection into the gateway so that alerting in enabled by default
A versioned restful API for Alerting

Still left TODO, before this is done:

Embed an upstream AlertManager into pkg/config/v1beta gateway
Find a way to inject the Alerting backend store into the gateway config


Windows can not access C:\Program Files\WindowsApps\CanonincalGroupLimited.Ubuntu2...

Environment
Windows build number: 18363.1379
Your Distribution version: ubuntu 20.04
Whether the issue is on WSL 2 and/or WSL 1: wsl2

Steps to reproduce

WSL logs:
After the update of the windos to version 1909, the docker I used to work with (v 2.3.0) does not work and there was errors while launching it, I upgraded to version 3.1.0. I downloaded Ubuntu 20.04 manually following this link: https://docs.microsoft.com/en-us/windows/wsl/install-manual#installing-your-distro
Expected behavior

The ubuntu distribution should be launched successfully.
Actual behavior
The distribution is not launched and I got this error:

There is no folder windowsApps under Program files.

Try this type of manual installation https://docs.microsoft.com/en-us/windows/wsl/install-on-server 😄

Try this type of manual installation https://docs.microsoft.com/en-us/windows/wsl/install-on-server

does not fix the issue


Introduction to stacks

txt files

Mention issue here, if you are adding .txt or .pdf files put it into Free-resources folder accordingly


Collabissues

Codecov Report
Attention: Patch coverage is 68.57143% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.76%. Comparing base (dee4e69) to head (b80e3a5).
Report is 3 commits behind head on main.

Files with missing lines
Patch %
Lines

adsingestp/parsers/jats.py
64.51%
11 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   91.41%   87.76%   -3.65%
==========================================
  Files          25       25
  Lines        2889     2935      +46
==========================================
- Hits         2641     2576      -65
- Misses        248      359     +111

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Images working, date reformatted, food buttons run the food API

Image icons appear

uses low res image

Date reformatted

Tue, Dec 5

Food buttons connected

needs work still might not be fully connected
only showing the same food place for each button

These look good to me, so your vision is that the food.html will open a new page when "food nearby" is clicked with the loaded results?

Yeah either that or it opens under the on you clicked on. Its not working completely yet I cant get it to target the button clicked and use that venue for the food search


Radial/Diametric dimension prefix isn't displayed in AutoCAD

Radial and Diametric dimensions don't display the "R" or "Ø" prefix. Tested in AutoCAD 2012 and 2016.
It's probably caused by this sequence in AcDbDimStyleTableRecord:
3
<>
If I manually delete these two lines from a dxf file. The problem is gone.
Original:

Modified:

dimension drawing.zip

Correct, no need to delete both lines just the <>. The DXF code 3 for the dimension style represents the combination of the prefix and suffix strings defined in the style. The characters <> are substituted by the actual dimension measurement but it is only required if the a prefix is present. I will fix it.

Fixed in netDxf 2.3.0


Re-update ReadTheDocs badge

Pull Request Test Coverage Report for Build 707

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.725%

Totals

Change from base Build 705:
0.0%

Covered Lines:
4541

Relevant Lines:
4845

💛  - Coveralls


Build failure with gcc 11.x on native_posix

Describe the bug
Warnings from new gcc turning into errors:
In file included from /home/nashif/Work/zephyrproject/zephyr/include/kernel_includes.h:39,
                 from /home/nashif/Work/zephyrproject/zephyr/include/kernel.h:17,
                 from /home/nashif/Work/zephyrproject/zephyr/include/zephyr.h:18,
                 from /home/nashif/Work/zephyrproject/zephyr/kernel/init.c:14:
/home/nashif/Work/zephyrproject/zephyr/include/sys/thread_stack.h:155:16: error: ignoring attribute ‘section (".noinit.\"WEST_TOPDIR/zephyr/kernel/init.c\".3")’ because it conflicts with previous ‘section (".noinit.\"WEST_TOPDIR/zephyr/kernel/include/kernel_internal.h\".0")’ [-Werror=attributes]
  155 |         struct z_thread_stack_element __kstackmem \
      |                ^~~~~~~~~~~~~~~~~~~~~~
/home/nashif/Work/zephyrproject/zephyr/kernel/init.c:61:1: note: in expansion of macro ‘K_KERNEL_STACK_ARRAY_DEFINE’
   61 | K_KERNEL_STACK_ARRAY_DEFINE(z_interrupt_stacks, CONFIG_MP_NUM_CPUS,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/nashif/Work/zephyrproject/zephyr/kernel/include/kernel_internal.h:136:36: note: previous declaration here
  136 | extern K_KERNEL_STACK_ARRAY_DEFINE(z_interrupt_stacks, CONFIG_MP_NUM_CPUS,
      |                                    ^~~~~~~~~~~~~~~~~~
/home/nashif/Work/zephyrproject/zephyr/include/sys/thread_stack.h:157:17: note: in definition of macro ‘K_KERNEL_STACK_ARRAY_DEFINE’
  157 |                 sym[nmemb][Z_KERNEL_STACK_LEN(size)]
      |                 ^~~
cc1: all warnings being treated as errors
gmake[2]: *** [zephyr/kernel/CMakeFiles/kernel.dir/build.make:134: zephyr/kernel/CMakeFiles/kernel.dir/init.c.obj] Error
1
gmake[1]: *** [CMakeFiles/Makefile2:2781: zephyr/kernel/CMakeFiles/kernel.dir/all] Error 2
gmake: *** [Makefile:103: all] Error 2

To Reproduce
On fedora 34 with gcc 11.x
Steps to reproduce the behavior:

twister -T samples/philosophers/ -p native_posix
See error

I've encountered this as well with my projects (using the ARM Cortex-M arch) and I would like it fixed.
The actual cause is that there are many separate files defining the z_interrupt_stacks extern symbol:

kernel/include/kernel_internal.h;
other includes / modules declaring the same symbol (e.g., aarch32/cortex_m/stack.h);

Both use the K_KERNEL_STACK_ARRAY_DEFINE macro, which calls upon the __in_section_unique macro generating a unique section string for each filename it's used.
The real solution would be to have a single header file declaring symbols using these file-named sections.
As workaround, I use -Wno-attributes or -Wno-error=attributes (when -Werror is desired) in my project cmake script:
check_set_compiler_property(APPEND PROPERTY warning_base -Wno-attributes)

#35893 should fix this.


Use arm64 for release workflows

What was changed

Use ARM runners for release workflows.
Why?

Previously merged https://github.com/temporalio/docker-builds/pull/223 needs to be run from an arm64 because it needs to be able to run arm64 and amd64.
Checklist

Closes

How was this tested:

Any docs updates needed?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Test for GUI

Question
Description
The developer or maintenance developer wishes to test a new GUI
Environment
during implementation phase, maintenance phase.
Artifact
GUI
Response
The developer can develop unit tests for the GUI and run the tests
Response Measure
within one day. The tests can be run automatically.

To test the GUI it would be possible to write a separate e2e test for each component created. Once these tests are written, the github test pipeline should also look for e2e tests to run automatically.

The component structure makes it easy to write tests...