Numpad input does not work

Hello, after upgrading to v0.5.0 it is impossible to enter transaction amount value using numpad keys. The same error occurs in the current online demo.
Other fields in transaction tab such as description and tags are working properly with numpad input

this commit (https://github.com/mayswind/ezbookkeeping/commit/110179664190f0933de508e96fcd6c0a48de6f0b) has fixed this bug. you can try to use the latest daily build.

Works fine, thank you


doc: Add limitations section to top level readme

Note: reviews for this PR here: https://github.com/mongodb/mongodbatlas-cloudformation-resources/pull/682
Documentation update - DOCSP-29472

Adds a limitations section

A markdown viewer I found online, if it's helpful for copy review: https://markdownlivepreview.com/

Hey @andreaangiolillo, could you review this whenever you have time? Thanks in advance

@zach-carr The PR does not show any changes. I also already reviewed the PR in the description. What am I missing? 🤔

Sorry about that @andreaangiolillo, my mistake - I was trying to pass an evergreen check and went in circles. I added the changes back (you did already approve them, but I can't merge myself without a review from someone with write access)

I see this error

Error: Files were changed during build (see build log). If this was triggered from a fork, you will need to update your branch.

Make sure to run the command npx projen inside your fork and commit any changes in your folder.

Hey @andreaangiolillo, I've been messing with this for a while but can't clear this error. npx projen returns default | node .projenrc.js whatever branch I'm on.
I created a new branch against upstream/main to start from scratch (new PR), but I'm still getting this. There don't appear to be any differences aside from the README update. I must not understand this check properly, could you point me in the right direction?
The error is still:
Error: Files were changed during build (see build log). If this was triggered from a fork, you will need to update your branch. diff --git a/API.md b/API.md
I've updated my branch, I've tried creating a new branch off of main, and there are not any changes in the API.md file. I'll keep working on this, but thanks in advance for any advice


42000: 1064: You have an error in your SQL syntax

On a fresh Ubuntu Server 16.04, I did this:
git clone https://github.com/isuftin/spotweb.git
cd spotweb/
sudo docker-compose up --no-recreate

which eventually results in this error:
spotwebServer_1 | SpotWeb crashed
spotwebServer_1 |
spotwebServer_1 | Database schema or settings upgrade failed:
spotwebServer_1 |    42000: 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IGNORE TABLE spots ADD UNIQUE INDEX idx_spots_1(messageid)' at line 1

Accessing the webserver on http://<IP_ADDRESS>/spotweb/, it says:

Notice: Undefined index: xsrfsecret in /var/www/spotweb/lib/services/Settings/Services_Settings_Container.php on line 62
Notice: Undefined index: schemaversion in /var/www/spotweb/lib/services/Settings/Services_Settings_Container.php on line 62
Database schema has been changed. Please run 'upgrade-db.php' from an console window

Should I indeed run 'upgrade-db.php', or should I do something else?
spotwebServer_1 | 	Validating tmdb_images(aspect_ratio)
spotwebServer_1 | 	Validating tmdb_images(file_path)
spotwebServer_1 | 	Validating tmdb_images(height)
spotwebServer_1 | 	Validating tmdb_images(width)
spotwebServer_1 | 	Validating index idx_spots_1
spotwebServer_1 | 		Adding index idx_spots_1
spotwebServer_1 |
spotwebServer_1 |
spotwebServer_1 | SpotWeb crashed
spotwebServer_1 |
spotwebServer_1 | Database schema or settings upgrade failed:
spotwebServer_1 |    42000: 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IGNORE TABLE spots ADD UNIQUE INDEX idx_spots_1(messageid)' at line 1
spotwebServer_1 |
spotwebServer_1 |
spotwebServer_1 | #0 /var/www/spotweb/lib/dbstruct/SpotStruct_mysql.php(99): dbeng_pdo->rawExec('ALTER IGNORE TA...')
spotwebServer_1 | #1 /var/www/spotweb/lib/dbstruct/SpotStruct_abs.php(131): SpotStruct_mysql->addIndex('idx_spots_1', 'UNIQUE', 'spots', Array)
spotwebServer_1 | #2 /var/www/spotweb/lib/dbstruct/SpotStruct_abs.php(778): SpotStruct_abs->validateIndex('idx_spots_1', 'UNIQUE', 'spots', Array)
spotwebServer_1 | #3 /var/www/spotweb/lib/services/Upgrade/Services_Upgrade_Base.php(42): SpotStruct_abs->updateSchema()
spotwebServer_1 | #4 /var/www/spotweb/upgrade-db.php(44): Services_Upgrade_Base->database()
spotwebServer_1 | #5 {main}spotweb_spotwebServer_1 exited with code 0

I had this problem, too. It's reported on the Spotweb repo and has been closed with a [fix]https://github.com/mesa57/spotweb-master/commit/5ef7d045eac94c663f644ba127915d8211f2ae15) but even though tagged as "deployed," the patch doesn't seem to have actually been merged into media or master yet. In the meantime, I got around this by:
docker cp <containerid>:var/www/spotweb/lib/dstruct/SpotStruct_mysql.php SpotStruct_mysql.php
and manually applying the fix from the above commit, then just docker cping the file back in. Bit of pain, but works perfectly well.

@sammcf I'm having trouble getting that command to work.
I first run "sudo docker-compose up --no-recreate" until getting the same error as the OP
I then do docker ps to get the container ID of the DB ("isuftin/spotweb_db:latest")
I then add that container ID to your cp command
sudo docker cp ##########:var/www/spotweb/lib/dstruct/SpotStruct_mysql.php SpotStruct_mysql.php
But when I run it, I get:
Error response from daemon: lstat /var/lib/docker/aufs/mnt/a71b846e3a79b9ef6261355bc28f5f969104aef431a68fabd9a2097575eafc45/var/www/spotweb/lib/dstruct/SpotStruct_mysql.php: no such file or directory
Am I missing something?

Figured it out - there is a typo in the above docker cp command.  should be:
docker cp <containerid>:var/www/spotweb/lib/d**b**struct/SpotStruct_mysql.php SpotStruct_mysql.php


Change python import sorter to isort

Since reorder-python-imports and black conflict in how they format, the pre-commits were always failing. isort is designed to be compatible with black so it should not have these problems in the future.
Having changed the formatters, this then reformats all files so that the formatter pre-commits all pass.
Fixes #359

Not quite working yet. Perhaps a difference between my version of black and the one running on github. Let me fix this up.

I've also upgraded python to 3.12, black to 24 and flake8 to 7.0.0 and now finally the "Linting / Pre-commit (pull_request)" stage passes.

With that last update all of the checks including hassfest pass so they've become useful as a gating mechanism again.


Correctly decode subject header in gmail client

I just realized this little fix was necessary.

This was causing certain Chinese emails to not be processed in my application.


Mypy Type Error due to Recent Changes to Litestar Middleware

New issue has surface due to the new changes to the litestar exception middleware handling that has been merged in https://github.com/litestar-org/litestar/commit/88284016e3467d0f07f612ab4ac279e14ab96ca8 here leading to a mypy failure on pre-commit

Issue on Line 120 where create_exception_response is expecting two arguments, with the first one being of type Request[Any, Any, Any] and the second being an exception. However, in the previous version only the exception is being passed.

Reference new middleware implementation from litestar:

resolved by #44


fix: fix clippy options (rustflags)

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
closes #5652
The format was already corrected by #5651
By the way, fixed a display error in dashboard
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
None
Refer to a related PR or issue link (optional)
#5652

The Clippy failed. 🥺

target.<cfg>.rustflags
This is similar to the target rustflags, but using a cfg() expression. If several  and  entries match the current target, the flags are joined together.
And then take precedence over build.rustflags

target.<cfg>.rustflags
This is similar to the target rustflags, but using a cfg() expression. If several  and  entries match the current target, the flags are joined together.
And then take precedence over build.rustflags

But I don't know how to deal with -Ctarget-cpu=native 🤔

https://github.com/rust-lang/cargo/issues/11166 🥺


Setup Workflows

This ticket is to setup workflows to use with GithHub actions.
The workflows to look into are:

Linting and Code Analysis
CI/CD:

Resources:
https://blog.logrocket.com/flutter-ci-cd-using-github-actions/
https://docs.flutter.dev/deployment/cd#cicd-options
https://github.com/flutter/gallery/tree/main/.github/workflows
https://github.com/nabilnalakath/flutter-githubaction

Update:
Merge CodeQL branch into this one and update code to use reusable Setup Flutter
Create separate build workflows for the following:

web
windows
android
linux

Afterwards, add it in #42 and configure further.

For Docs:

Add Firebase Distribution to Workflows
https://github.com/wzieba/Firebase-Distribution-Github-Action

https://steveos.medium.com/github-action-and-firebase-app-distribution-ci-cd-ways-part-2-fcf9ba425c0
<EMAIL_ADDRESS>


Add babel-preset-react-hmre dev dependency

Fixes:
ERROR in ../react-slick/lib/index.js
Module build failed: Error: Couldn't find preset "react-hmre" relative to directory "/Users/yn5/stuff/web/puha/react-slick/lib"
    at /Users/yn5/stuff/web/puha/puhastudio-ern/node_modules/babel-core/lib/transformation/file/options/option-manager.js:372:17
    at Array.map (native)
    at OptionManager.resolvePresets (/Users/yn5/stuff/web/puha/puhastudio-ern/node_modules/babel-core/lib/transformation/file/options/option-manager.js:364:20)
    at OptionManager.mergePresets (/Users/yn5/stuff/web/puha/puhastudio-ern/node_modules/babel-core/lib/transformation/file/options/option-manager.js:348:10)
    at OptionManager.mergeOptions (/Users/yn5/stuff/web/puha/puhastudio-ern/node_modules/babel-core/lib/transformation/file/options/option-manager.js:307:14)
    at OptionManager.init (/Users/yn5/stuff/web/puha/puhastudio-ern/node_modules/babel-core/lib/transformation/file/options/option-manager.js:465:10)
    at File.initOptions (/Users/yn5/stuff/web/puha/puhastudio-ern/node_modules/babel-core/lib/transformation/file/index.js:194:75)
    at new File (/Users/yn5/stuff/web/puha/puhastudio-ern/node_modules/babel-core/lib/transformation/file/index.js:123:22)
    at Pipeline.transform (/Users/yn5/stuff/web/puha/puhastudio-ern/node_modules/babel-core/lib/transformation/pipeline.js:45:16)
    at transpile (/Users/yn5/stuff/web/puha/puhastudio-ern/node_modules/babel-loader/index.js:14:22)
 @ ./shared/components/Template/Text.js 32:18-40

The reason the travis check has failed is because of the bug fixed by: #332

This library is not using hot reloading. Closing this for now.
May revisit later


Helper Idea: Logs Manager

It would be nice to monitor the warning and errors the underlying system/environment yields.
Optionally, an option to log activity would be interesting, such as crud and login (or failures). This way, the admin can know who did what.

Oops, I've just noticed the "Operation Log" section.
I still think environment and login logs could be useful.
One thing that might be useful is to be able to use something like $form->logs() (maybe in a tab) so that the related logs can be consulted when viewing the form.
Login activity of the administrator user could be logged too if the logins are logged.


Unable to create different steps(.ts) files for different feature files using typescript

@lgandecki
Need your assistance , I have different feature files that is testing different part of the system and I wanted to create different steps in .ts files to test each features, following the examples you gave , I can only create on step file(.ts) for all the feature files, when I created a folder for other steps, I got the below error
 ./cypress/integration/Mobile/mobile.ts
Module not found: Error: Can't resolve 'cypress-cucumber-preprocessor/mobile' in '/Users/myUser/Documents/game-test/cypress/integration/Mobile'
resolve 'cypress-cucumber-preprocessor/mobile' in '/Users/myUser/Documents/game-test/cypress/integration/Mobile'
Parsed request is a module
using description file: /Users/myUser/Documents/game-test/package.json (relative path: ./cypress/integration/Mobile)
Field 'browser' doesn't contain a valid alias configuration
resolve as module
/Users/myUser/Documents/game-test/cypress/integration/Mobile/node_modules doesn't exist or is not a directory

I did set
"cypress-cucumber-preprocessor": {
   "nonGlobalStepDefinitions": true
 }

And when I use the same step file ( .ts ) for different feature files i got :
Error: Step implementation missing for: I am on mobile
I have created a repo for you to have a look :https://github.com/dfawole/tests.git
Please what am i doing wrong and Thanks in advance

@dfawole  the repo seems to be private, could you make it public?

@lgandecki
I have given you access now
https://github.com/dfawole/tests/invitations

Thanks for your quick response

I would still prefer you made it public - why do you want to limit the audience just to yourself. Someone might stumble upon the same problem and they will end up hitting a dead link. Not very nice, especially if you are asking for a free help :)
but anyway, the problem is that you can't use const {something} = require('module') in multiple files,
I will tweak this in the example repo.
https://github.com/dfawole/tests/pull/1
is your solution,
btw, please do not install cucumber and cucumber types :)

@lgandecki
Thanks for your help .... I have made it public and it was an oversight from my side


Fixed setting main object to the primary node

Main object was assigned to the primary node at the end of jexcel class, which prevented accessing it on initialization, in methods like updateTable() through el.jexcel which pass the el

Do you have any special reason for that?

Yes, I'm using custom options.updateTable = this.updateCell like so:
updateCell = (instance, cell, x, y, value, label, cellName) => {
    const { jexcel } = instance;

    const { type, config } = jexcel.options.columns[x];
    switch (type) {
        case 'formula':
            value = jexcel.executeFormula(config.replace(/\$/g, y + 1), x, y);
            break;
    }
    cell.classList.add('cell-' + type);
    cell.innerHTML = value;
};

And to have access to jexcel object, it has to be assigned before table initialization

el.jexcel = obj
This is alternative to bind the jexcel object to the DOM as an alternative way to persist the access, totally optional. The object you are going to use is obj only. So, I am pretty sure you will get the same results both ways.

Oh well, I just realized you can move it 2 lines up and the result will be the same :sweat_smile:


Windows: Requested Windows Runtime type "Windows.Media.Core.MediaSource" is not registered.

After fixing #882, I was able to build my solution on Windows 10.

Resolved: Windows Media Player was not installed on the system.
Solution: Install the Media Feature Pack for Windows 10 N.


How to integrate AssimpKit manual

I do not want use Carthage, and how to integrate AssimpKit on my project ?

@SongJiaqiang Just clone or fork this project. Open the workspace file.
Next choose the target, example AssimpKit-iOS and also a device if you want to build it for a device. Then build that target. Under Products you will see AssimpKit.framework. You can copy this framework and add it to your project.

@SongJiaqiang

I guess some of the libraries may be missing, and then try to add the following libraries,

Sorry, I haven't tried integrating manually except for the sample projects in the workspace, check those out as well, but you should not need to add those libraries. Try this and please let me know if it works:

Also did you set the Enable Bit Code -> NO in the build settings; that is required for iOS projects.
If this does not work, do you mind sharing a sample project of yours where you are trying to add manually, I can then investigate. This will help us add a integrate manually section with correct instructions.

@dmsurti I got it to work with Xcode 8.3.1 and Swift 3 with following steps:

Build the iOS framework
Drag & drop AssimpKit.framework into your project
Build settings -> Enable Bitcode = No
General -> Embedded Binaries -> Add AssimpKit.framework
Add Bridging-Header and add #import <AssimpKit/SCNScene+AssimpImport.h>

@D-32 Thanks for the instructions to integrate manually.  👍
@SongJiaqiang You can see the steps posted by @D-32  to integrate manually.
Closing this issue now.


Remove type assertion in createMachine

Fixes https://github.com/statelyai/xstate/issues/3006
This assertion made it impossible to use createMachine with a generic TContext type.

cc @Andarist

We should probably add a type-level test for this change - it could potentially guard us against future regressions. @hedgepigdaniel would you be up for working on it?


bump keb images

Description
Changes proposed in this pull request:

bump keb images to include https://github.com/kyma-project/control-plane/pull/2809

Related issue(s)

closing in favor of https://github.com/kyma-project/control-plane/pull/2821


[zh] Sync feature-gates-removed.md

Sync with the en version #36876
content/zh-cn/docs/reference/command-line-tools-reference/feature-gates-removed.md

Preview: https://deploy-preview-37176--kubernetes-io-main-staging.netlify.app/zh-cn/docs/reference/command-line-tools-reference/feature-gates-removed/

/lgtm
/approve

/hold

/hold cancel
/lgtm


[REEF-851] Fix nondeterministic test bug in CommunicationGroupDriverI…

…mplTest
This addressed the issue by

Replacing ThreadPoolStage with SyncStage to make test deterministic

JIRA: REEF-851

This looks good, I'll merge.


error status code 504 after fresh start

Hi Team!
Just wished to try Querybook by quick start guide
git clone https://github.com/pinterest/querybook.git cd querybook
make
get an error ModuleNotFoundError: No module named 'langchain' in loop in console.
in the web getting error
Unexpected Authentication Error
Request failed with status code 504
What's wrong with it?

Hey Yuriy,
It's because we added LLM features recently, but forgot to make the dependencies correct.
Please add -r ai/langchain.txt to your requirements/local.txt as a workaround for now. we'll have a fix soon.

will test it now. Create new file requirements/local.txt and add -r ai/langchain.txt
Many thx!

just had a fix for it #1333

@jczhong84 great job thx 🙏


minio deployed locally access it in spark shell, use domain name in fs.s3a.endpoint  error happens

I startup a minio server locally and try to access it in spark-shell . I just want to use the dns name instead of ip in the fs.s3a.endpoint and I got error while executing write files

@Kaleidoscoper Can you access the minio endpoint when you try http://minioservice:9010.
Can you paste the output of curl http://minioservice:9010 ?

@Kaleidoscoper Closing this issue as stale. Please feel free to reach out to us again when you have the information requested


Add lowest-dependencies Travis build

Coverage remained the same at 45.763% when pulling 5e031e7bfde975e9a1b8b124c5a8ddf5676ed396 on OndraM:feature/composer-lowest-deps into bbfd1fb27e2cf9cfe4a596d01057ab0703d5d9e2 on facebook:community.


eDSL: Superior NameGen

The eDSL currently does a quick and dirty job when it comes to name generation.
It maintains a counter starting at 0, and every time it needs to makes a new name for a cell, it does something like {the_op_in_question}_{counter++}. This is why end up with things like reg_0, add_1, mult_2, etc.
The true solution is something akin to what Calyx itself does:
https://github.com/calyxir/calyx/blob/6f895a1353020ce254860c3aa0fcfa2ba1abf4c4/calyx-utils/src/namegenerator.rs#L7-L10
It actually tracks existing names and avoids clashes. Let's eventually upgrade the eDSL to something like this.
Originally posted by @anshumanmohan in https://github.com/calyxir/calyx/pull/2152#discussion_r1643119305

@rachitnigam, I'm curious why name_hash isn't used additionally to store whether the name has been defined, this task delegated to a separate HashSet? It doesn't seem hard to remove generated_names and keep the same functionality. That being said, it's not important.


pyautogui doesn't work in clipchamp

HI folks!
new in this. I am looking for to automate some tasks. I was using Macro scheduler, but since I didn't want pay for it and trail already gone. I didn't other option than to use pyautogui. But when I started to use it in clipchamp the clicks didn't work, but in other programs works just fine.
?Can you guys explain me why is this happening, explain to me in easy words since I am new in the space.

I have the same problem, I think it has to do with how they call the windows API to do the clicking

may have unique interfaces or interactions that PyAutoGUI may not fully support.


Certificate problem

I followed all install steps but when I run scraper for one single or all rom directories i get this:
INFO: Checking for new MAME history.
Get https://storage.googleapis.com/stevenselph.appspot.com/hash.csv.gz: x509: certificate signed by unknown authority

Hmm it would be odd to get that error. The server and certificate would be Google so those should be known. Is this problem persisting? are you in an odd environment like a corporate network that might be proxying SSL traffic? Is the date set correctly on the device you are using?

I'm just on a normal home network. Problem is persisting. Date/time are
correct.
On Feb 24, 2016 10:29 AM, "Steven Selph"<EMAIL_ADDRESS>wrote:

Hmm it would be odd to get that error. The server and certificate would be
Google so those should be known. Is this problem persisting? are you in an
odd environment like a corporate network that might be proxying SSL
traffic? Is the date set correctly on the device you are using?
—
Reply to this email directly or view it on GitHub
https://github.com/sselph/scraper/issues/70#issuecomment-188306084.

A couple more questions. What OS is the scraper being run on? If it is linux/mac can you try running openssl s_client -connect storage.googleapis.com:443 to get the cert chain. It should look like
---
Certificate chain
 0 s:/C=US/ST=California/L=Mountain View/O=Google Inc/CN=*.storage.googleapis.com
   i:/C=US/O=Google Inc/CN=Google Internet Authority G2
 1 s:/C=US/O=Google Inc/CN=Google Internet Authority G2
   i:/C=US/O=GeoTrust Inc./CN=GeoTrust Global CA
 2 s:/C=US/O=GeoTrust Inc./CN=GeoTrust Global CA
   i:/C=US/O=Equifax/OU=Equifax Secure Certificate Authority
---

You can also try downloading the file using a browser or wget https://storage.googleapis.com/stevenselph.appspot.com/hash.csv.gz

Retropie on raspberry pi. I figured it out and am embarrassed I didn't
figure this out before. I have my home network setup with parental
controls. I never turned them off for the rpi's IP. That's what caused the
issue. Now thegamesdb is down so it still isn't scraping but i think we
solved the main issue here. Thanks for your patience and of course for your
efforts in providing this feature to us all.
John
On Feb 24, 2016 1:28 PM, "Steven Selph"<EMAIL_ADDRESS>wrote:

A couple more questions. What OS is the scraper being run on? If it is
linux/mac can you try running openssl s_client -connect
storage.googleapis.com:443 to get the cert chain. It should look like

Certificate chain
0 s:/C=US/ST=California/L=Mountain View/O=Google Inc/CN=*.storage.googleapis.com
i:/C=US/O=Google Inc/CN=Google Internet Authority G2
1 s:/C=US/O=Google Inc/CN=Google Internet Authority G2
i:/C=US/O=GeoTrust Inc./CN=GeoTrust Global CA
2 s:/C=US/O=GeoTrust Inc./CN=GeoTrust Global CA
i:/C=US/O=Equifax/OU=Equifax Secure Certificate Authority
You can also try downloading the file using a browser or wget
https://storage.googleapis.com/stevenselph.appspot.com/hash.csv.gz
—
Reply to this email directly or view it on GitHub
https://github.com/sselph/scraper/issues/70#issuecomment-188394753.

Glad you figured it out.


Schema "text_key" issue, redundant property

The init function accepts text_key as input, yet it is not being passed to the _default_schema function. Consequently, a property named "text" is hardcoded within the property.

Can I create a PR fixing this?

@pashva thanks for your interest to contribute!
I noticed this too and wanted to get feedback from the community. Here's how I see it:
There's a lot of things you can customise in a weaviate schema. How do we decide which one is worth exposing to langchain users? If we expose all possible settings, then were are just building another abstraction on top of the weaviate client.
If we expose only some settings, then I feel it is an inconvenience for the user since there's now different settings have different ways of tweaking.
A solution I've been considering is to tell users this is what you get with the default schema. If you want something different, then use the weaviate client to create your desired schema, and when you use langchain, remember to specify the index name and which property is the text_key.
What do you think of this?

Yes it makes sense completely but then asking text_key as an input kind of confuses me personally as i believe if i specify the text key then my end schema created should have nothing but that text_key.

asking text_key as an input kind of confuses me personally as i believe if i specify the text key then my end schema created should have nothing but that text_key

I've noted the confusion.
I believe this can be solved with proper documentation in the class' docstring and tutorials/user guides.
What do you think?


Not Recursive

Hello.
When I place dirlister in a directory that has other folder in it the folders show up properly and it lists the files within those folders, however when I open those folders dirlister does not run on them.
Expected behavior: Rather then open the folder directly dirlister could stay in the current directory but show the user the contents of those folders so that it runs

Hello Toby, thank you for your feedback.
I noticed that the initial version of the DirLister plugin doesn't run
folders and files outside its parent directory. I've been thinking about
this, and I hope to work on a new version that addresses the issue, such
that you can set a specific directory to be scanned in the $dir config
option, regardless of where the DirLister's index.php file is placed.
I also welcome any contributions to this update and would highly appreciate
your input.
On Wed, Oct 30, 2024 at 5:09 PM Toby Cowles @.***>
wrote:

Hello.
When I place dirlister in a directory that has other folder in it the
folders show up properly and it lists the files within those folders,
however when I open those folders dirlister does not run on them.
Expected behavior: Rather then open the folder directly dirlister could
stay in the current directory but show the user the contents of those
folders so that it runs
—
Reply to this email directly, view it on GitHub
https://github.com/mikeotizels/dirlister/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI6W3B2CDRSGHIJCUYAQ44DZ6DSBTAVCNFSM6AAAAABQ4GP746VHI2DSMVQWIX3LMV43ASLTON2WKOZSGYZDIMRTGQ4DIMI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


HTTP Client and Server

Team HW1 - Katie, Lucas, and Joel. Simple http server and client. Solves issues #14 and #15.

overall looks great!  I've added a few comments you should fix.

Code has been revised to reflect your suggestions.

looks good!


Failed to slow down for stopped car

Describe the bug
OP was engaged and approaching a stopped car at a red light. The stopped car was detected but OP was not slowing down in time and my car's FCW came on and had to brake manually.
How to reproduce or log data
Approach a stopped car on a very large curve while OP is engaged.
Expected behavior
I expect OP to slow down a lot earlier for the stopped car.
Device/Version information (please complete the following information):

Device: Comma Two
Dongle ID: cd21d47a9d46bdf3
Route: cd21d47a9d46bdf3|2021-05-20--07-50-40--12
Timestamp: May 20 @ 08:02:55
Version: 0.8.4
Car make/model: 2021 Toyota Corolla Hybrid

Additional context

This is similar to https://github.com/commaai/openpilot/issues/20970
Closing and connecting. Will try to find a solution ASAP


dp problems

Not accepting CPP/C dsa codes
Alternative ->
1)Create a page using HTML & CSS Add dsa problem statement and solution in that
2)You can contribute in python and java OR
Ask for an issue assign
3)Contribute Web Project


Issue 117 active column css fix

Addressing issue #117:

Fixed mark active column styling in all themes

Addressing issue #80:

Improved store module interface and adopted pub-sub pattern for persisting page number and page length when paging is on

:+1:


Enable branch to be specified in Repository.push_to_hub

As a user, I would like to be able to push my repo's files to a specific branch on the Hub, e.g.
my_repo = Repository(...)

# create some local files, e.g. save a model

my_repo.push_to_hub(commit_message="I love Git!", branch="my-awesome-branch")

This would be quite useful for the evaluation / benchmarking projects where the current idea (due to @lhoestq) is to store the model predictions for task X in a separate branch on a single repo. (We store the predictions for reproducibility purposes)
I'm not sure if Repository.push_to_hub is the right entry point for this feature or whether it makes sense to have something like Repository.git_checkout
cc @SBrandeis @thomwolf @abhishekkrthakur

(Not a direct solution, but HfApi.upload_file already allows for an optional revision param which can be a branch iirc).
cc @LysandreJik probably has some good ideas about this.

Having a revision option on the push_to_hub method sounds good to me. Feel free to open a PR @lewtun, otherwise, I'll take a stab at it in a bit.

Do you think that the constructor should also support something like this (be it optional revision parameter or allowing to have the revision in the url of clone_from)? That way if your workflow is in a branch you can do this without much issues.
I'm also not sure revision should be the option for push_to_hub, no? I think it should be something like branch, but I'm not completely sure.

cc @lvwerra with whom we have had a similar conversation

Do you think that the constructor should also support something like this (be it optional revision parameter or allowing to have the revision in the url of clone_from)? That way if your workflow is in a branch you can do this without much issues.

You mean something like the following:
from huggingface_hub import Repository

repo = Repository("xxx", clone_from="xxx/yyy", revision="zzz")
# or
repo = Repository("xxx", clone_from="xxx/yyy@zzz")

This would essentially be a clone + checkout, or did you envision it a different way?

Yes, those two options are exactly what I meant (I would go with the second option to avoid having too many parameters and enabling this in downstream libraries). This would enable users that work just in a single, non-main branch. The revision param in push_to_hub will also be needed for those users that want to clone from a branch (normally main) but push to another.
I think it could be either clone+checkout and ensure this points to the right branch or git clone --branch.

Having a revision option on the push_to_hub method sounds good to me. Feel free to open a PR @lewtun, otherwise, I'll take a stab at it in a bit.

I’m on vacation for the next two weeks, but happy to pick this up when I’m back if you don’t beat me to it 😎

I'm taking care of it in the branch-push-to-hub branch!

Opened PR: https://github.com/huggingface/huggingface_hub/pull/276


https://pixijs.io/examples/#/sprite/basic.js

https://pixijs.io/examples/#/sprite/basic.js
Originally posted by @djmisterjon in https://github.com/pixijs/pixi.js/issues/6279#issuecomment-565415054
Thanks for your response. But I want create AnimateSprite. In the Examples they create AnimateSprite use PIXI.Loader.shared.add("assets/spritesheet.json").load(setup);
But i want do this
const jsonObj = get json from other way;
PIXI.Loader.shared.add(jsonObj).load(setup);

Usually its easier to inline spritesheet loader.
https://github.com/pixijs/pixi.js/blob/dev/packages/spritesheet/src/SpritesheetLoader.js#L57
You can do those operations manually:
loader.add('my.png').load(() => {
     let sheet = new PIXI.SpriteSheet(loader.resources['my.png'].texture, jsonData);
     sheet.parse(); // works if number of textures is less than 1000. otherwise you need a callback or increase batch size
});

Good answer. Closing.

Usually its easier to inline spritesheet loader.
https://github.com/pixijs/pixi.js/blob/dev/packages/spritesheet/src/SpritesheetLoader.js#L57
You can do those operations manually:
loader.add('my.png').load(() => {
     let sheet = new PIXI.Spritesheet(loader.resources['my.png'].texture, jsonData);
     sheet.parse(); // works if number of textures is less than 1000. otherwise you need a callback or increase batch size
     console.log(sheet.animations);
});

Make sure your json file contains animation arrays and not just a few textures. If there is only
a collection of textures without animation sequences - you'll have to convert object to array manually.

thanks for a lot . that's  solved my problem


fix(plugins/plugin-kubectl): tab state manager shoud not log "command not found" errors for systems without kubectl

Fixes #7416

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[x] 🐛 Bug fix
[ ] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

/lgtm


PCL project build tests failing on mono:latest os:linux

mono --version
Mono JIT compiler version 4.6.1 (Stable <IP_ADDRESS>/abb06f1 Wed Sep 28 13:54:26 UTC 2016)

This one works:
FSharp.Compiler.Service/tests/projects/Sample_VS2015_FSharp_Library_net45
This one (and some others) fails:
FSharp.Compiler.Service/tests/projects/Sample_VS2015_FSharp_Portable78_Library
with:
FSC: error FS0073: internal error: BuildFrameworkTcImports: no resolution of 'FSharp.Core.dll'

See https://github.com/fsharp/FSharp.Compiler.Service/pull/646
These days we recommend using the FSharp.Core nuget package for PCL compilation, especially on Linux/OSX.

@dsyme Does that mean FSharp.Core.dll is no longer installed as part of referenceassemblies-pcl?

@ncave I'm not entirely sure.  I've been discussing with @directhex.  There are differences between the layout you get from compiling github.com/fsharp/fsharp (which works correctly and installs the PCL libraries) and the one used in the "csharp" Travis profile which I presume uses the Xamarin package).  The "csharp" Travis profile doesn't seem to even have the C# PCL reference assemblies installed.
Perhaps @directhex can advis

Best to loop in @akoeplinger, Travis is his iirc

The "csharp" Travis profile does have the reference assemblies installed. It just installs the referenceassemblies-pcl and fsharp package from the Xamarin repositories (or the Mono MDK .pkg on Mac). If there's something wrong with how F# is installed there then we should coordinate on the Xamarin side :)

@akoeplinger My bad, sorry, where do they get installed?  I did a recursive ls under /usr/lib/mono and didn't spot where they are, see results here https://travis-ci.org/fsharp/FSharp.Compiler.Service/jobs/166991797#L1029
@directhex Can you point me to the code that does the layout of the Xamarin package?  Also, we need to move fsc.exe and friends to /usr/lib/mono/fsharp rather than /usr/lib/mono/4.5 per recent emai discussions (following the layout that http://github.com/fsharp/fsharp now uses - it would be great if we could just use exactly the same layout as that generates, though I know there are issues with also redirecting to /usr/lib/cli)

@dsyme they're in /usr/lib/mono/xbuild-frameworks/.NETPortable, you need to pass -a to ls since they start with a dot and are hidden by default.

you need to pass -a to ls since the folder starts with a dot and so is hidden by default.

@akoeplinger  :) I would never, ever, ever have thought of that :)

These are fixed


Tabbing through fields selects the country selector instead of the phone number input

When in a form with multiple fields including this package and you tab through (say email -> firstname -> phone number ... etc) the phone number field that gets hit is actually first the country selector. Since 99+% of our customers are US based phone numbers we need to ignore this tabbing. can we get a tabindex property on that country selector to not be selected when tabbing?

There is one:
https://github.com/halt-hammerzeit/react-phone-number-input/blob/24844341fa705dc6dc86d9665f42c804784fd504/source/input.js#L134


fix: helm metrics indexing enabled issue

Description
Fix helm issue when poller is empty in main values.yaml file:
 executing "environmental-variables" at <.Values.poller.metricsIndexingEnabled>: nil pointer evaluating interface {}.metricsIndexingEnabled

Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix

How Has This Been Tested?
N/A
Checklist
N/A

:tada: This PR is included in version 1.8.5-beta.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Unable to find downloaded files when running code in a docker container

Hello,
I need some help with running a program using ktrain inside a docker container. I will be running shutting the container down and would like to keep the downloaded models so that on running a new / restarting the container, the models do not download again.
I tried searching for the "torch" folder using bash. But was not able to find the folder where the models have been downloaded to. Can you please help me with this?
Thanks

The files are being downloaded by transformers, not ktrain.  It should be in:
<home_directory>/.cache/torch/transformers


Fix broken link to upgrade ks

Fixes: https://github.com/kubeflow/website/issues/309.

This change is

@sarahmaddox


[Bug] Keyboard popping up in wrong places

This bug report belongs to 2.0.0-beta.4
How to reproduce:

unlauncher mainFragment is shown
Open any app on your phone
Turn the phone to landscape mode
Turn the phone back to portrait mode
Press Home Key

Expected behaviour
unlauncher mainFragment is shown
Actual behaviour
unlauncher mainFragment is shown with a popped up keyboad.

There is also another way to reproduce this (if this is the same bug):
How to reproduce:

Have Unlauncher as the default launcher and open the search ( and implicitly the keyboard) at least once
Launch any App and wait a few seconds
Go back to the Homescreen with the home butten/gesture


Deploy after successful builds in master

The approach using Travis' deploy with a custom script is experimental, the output from the script isn't shown and made it difficult to see what was going on. I've used after_success and a custom script that checks whether the build is for the master branch.
@raulraja please take a look, i tried publishing non-master in my tests and worked perfectly. If we are happy with this setup i'll open PRs for the other two content repos.

LGTM!


如何set share=True

很好的项目，非常期待尝试成功，遇到两个问题：
1.如何set share=True
2.export OPENAI_API_KEY ，仍然warning ，提示要设置OPENAI_API_KEY
我是在colab上运行的，

You can add share=True at https://github.com/OpenBMB/AgentVerse/blob/06e97ef69de4c136a9140223903982442b13084f/main_demo.py#L16
Personally, I don't use Colab, so I cannot be 100% sure about what the problem is. However, I googled it and found that setting environment variables in Colab seems to be tricky. You can try exporting your OpenAI key by adding the following code at the top of  main_demo.py

import os
os.environ["OPENAI_API_KEY"] = "sk-xxx"

Also, remember to reset your API key, as it might be leaked through your screen capture.

谢谢您的回复，还是没能明白怎么添加share=True
是作为参数吗 ，这样 ui.launch(share=True) ？ 貌似还是不行

Ah sorry about that. You may need to add the argument at https://github.com/OpenBMB/AgentVerse/blob/06e97ef69de4c136a9140223903982442b13084f/agentverse/demo.py#L486C62-L486C62

奇怪，486行直接传参貌似不能生成gradio link。 我直接修改了lanuch：share: bool = True, 可以正常启动


docs: add Pyth0nHere's introduction.

Added myself to the List.

@Pyth0nHere - thanks for adding your introduction. Make sure to join our community, by creating an issue here: https://github.com/The-Lively-Developers-Community/become-a-member


Issue with file upload modal window

This is a minor issue on Firefox. It works as expected on Chrome.
Authentic theme version: 19.52 (but prior versions too)
Firefox 79 (but prior version too)
If you select a radio button and then click the file upload icon, nothing happens.

If you do not select the radio button and click the file upload button, the pop up window appears as expected.
So if there are more than 2 file uploads (such as with an SSL cert), you're stuck!
Thanks,
Paul

Hi,
I suppose you're on mysql/exec_form.cgi page and using Execute SQL?
I don't understand what the problem is? It works for me just fine in latest Firefox on Linux. What exactly doesn't work?

The bug is not limited to a specific page, it is on all forms where there is a file upload element.
I wonder if this is limited to MacOSX, as it is not working in either Firefox  78.0.2 or 79b4. However, it works as expected on Firefox/Win10
Expected result: When you click on the paperclip icon, a file brower window pops up.
Actual result: If any radio button is selected first, clicking on the paperclip does nothing.
Here is a video: https://youtu.be/8OTusUwTtK0

Oh, I see an issue here.
Thank you very much. I will take a closer look a bit later. I will update it when it's fixed.

Yeah, I see why it's happening. Unbeforeunload status prevents a click on this button. As a work-around, if you need to do some work, just open a console and run set_onbeforeunload_status(0) before clicking the paperclip button.
I will fix it after dinner break.

It's fixed on the latest commit. We will release minor Webmin version containing the theme update really soon!
Thanks for the heads up!


Cannot stop WebsocketClient from trying to reconnect to a non-existent server

I've implemented a WebSocketClient that tries to connect to a (non-existent) server using wsClient->connectToServer(). The callback I provided is repeatedly called with a NetworkFailure error. Digging deeper into the Drogon implementation I ran across this code.
In WebSocketClientImpl.cc around line 75 I see this:
tcpClientPtr_->setConnectionErrorCallback([weakPtr]() {
        auto thisPtr = weakPtr.lock();
        if (!thisPtr)
            return;
        // can't connect to server
        thisPtr->requestCallback_(ReqResult::NetworkFailure, nullptr, thisPtr);
        thisPtr->loop_->runAfter(1.0, [thisPtr]() { thisPtr->reconnect(); });
    });

So it appears that after reporting a NetworkFailure it repeatedly schedules a function at a 1 second interval to re-connect. This repeats forever and I cannot figure out a way to control this behavior from my code. I'd like to disable this "auto-reconnect" behavior or at least set the number of re-connect attempts it will make. Can you suggest a way to stop the re-connect behavior and if that is not currently possible, add an option to control this feature?
Thanks . . .

I'm not sure I would necessary label this as strictly an enhancement given that once connectToServer() is called there is NO discenable way to stop it from continuously trying to re-connect. The only mechanism that might work is to completely destroy the WebSocketClient. Even then it's not clear that the interal Drogon framework won't keep a reference to it that keeps it alive (and thus continuously trying to re-connect). Is there any other way to shut this thing down? Seems to be a pretty major omission especially if the server you're trying to connect to goes down permanently.
Thanks for any insights or suggestions you might be able to provide . . .

Thanks for your feedback.
I don’t fully understand your use case, please clarify. What would speak against monitoring and destroying the client completely in an undesired case?
You’re certainly expecting some data as a response, can’t you determine based on this if the client should be destroyed?
A code example what exactly you are trying to do and why could help here to give you some better advice I think.

I believe there is a circular reference at play here that prevents the reference to the WebSocketClient from being fully decremented and released. Let's say I have the following code fragment:
using namespace drogon;

struct ClientInfo {
  WebSocketClientPtr wsClient;
};

void connect()
{
  ClientInfo info;

  info.wsClient = WebSocketClient::newWebSocketClient("ws://<IP_ADDRESS>:55000");
  auto req = HttpRequest::newHttpRequest();
  req->setPath("/");
  info.wsClient->connectToServer(
      req,
      [observer = std::move(info)]
      (ReqResult r,
      const HttpResponsePtr &,
      const WebSocketClientPtr& wsPtr) mutable {
        if ( r != ReqResult::Ok )
        {
          // We never got connected or the server went down - so how do I stop the auto-reconnect?
          // Let's try dropping the reference to the WebSocketClient?
          LOG_TRACE << "Before wsPtr.use_count(): " << wsPtr.use_count();
          observer.wsClient.reset();
          LOG_TRACE << "After wsPtr.use_count(): " << wsPtr.use_count();
        }
      }
    );
}

If connect() is called and the WebSocket server is not available or exits early, I'll get a ReqResult::NetworkFailure indication but there doesn't appear to be a way to stop the auto-reconnect attempt. In my situation, it will repeatedly print the following every 1 second:
Before wsPtr.user_count(): 3
After wsPtr.user_count(): 3
...

I don't see how to force the WebSocketClient to drop it's reference count to zero (0) and hopefully squelch further reconnect attempts. My suspicion is that the thisPtr->requestCallback_ callback member variable in WebSocketClientImpl.cc may be preventing the WebSocketClient from dropping it's reference to zero. Another culprit might be thisPtr->loop_->runAfter() callback that is holding onto the thisPtr (== WebSocketClient) in WebSocketClientImpl.cc. Regardless, the reference count to WebSocketClient never drops below 3 so there is no opportunity to break the reconnect cycle by destroying the WebSocketClient instance. Perhaps I am missing something, but this entire mechanism seems to be broken.
You guidance here and any corrections would be appreciated.

Please try this.
void connect()
{
  auto infoPtr=std::make_shared<ClientInfo>();
  info->wsClient = WebSocketClient::newWebSocketClient("ws://<IP_ADDRESS>:55000");
  auto req = HttpRequest::newHttpRequest();
  req->setPath("/");
  info.wsClient->connectToServer(
      req,
      [observer = std::move(infoPtr)]
      (ReqResult r,
      const HttpResponsePtr &,
      const WebSocketClientPtr& wsPtr) mutable {
        if ( r != ReqResult::Ok )
        {
          // We never got connected or the server went down - so how do I stop the auto-reconnect?
          // Let's try dropping the reference to the WebSocketClient?
          LOG_TRACE << "Before wsPtr.use_count(): " << wsPtr.use_count();
          observer.reset();
          LOG_TRACE << "After wsPtr.use_count(): " << wsPtr.use_count();
        }
        else
        {
           storeInfo(observer);
        }
      }
    );
}

I tried your approach of "moving" in a shared_ptr to the ClientInfo instance and it had no effect. This isn't surprising at all since the wsPtr.use_count() remains at 3 after making the change. I think the problem here is that the connectToServer() callback std::function continues to indirectly hold a reference to the wsClient as well as the callback associated with the thisPtr->loop_->runAfter() code. Until these std::function callbacks are destroyed or reset they will still either directly or indirectly hold a reference to thisPtr (e.g. the WebSocketClient instance). I see no means of driving the ref-count on the WebSocketClient to zero in this situation. In addition to being unable to stop the reconnect, I suspect this could easily lead to a memory leak of the WebSocketClient instance since it will never be freed after a call to connectToServer().
Interested in your thoughts . . .

I add a stop() method for this.
void connect()
{
  ClientInfo info;

  info.wsClient = WebSocketClient::newWebSocketClient("ws://<IP_ADDRESS>:55000");
  auto req = HttpRequest::newHttpRequest();
  req->setPath("/");
  info.wsClient->connectToServer(
      req,
      []
      (ReqResult r,
      const HttpResponsePtr &,
      const WebSocketClientPtr& wsPtr) mutable {
        if ( r != ReqResult::Ok )
        {
          wsPtr->stop();
          return;
        }
      }
    );
}

I updated my code and Drogon and tried this new "stop()" method. It does indeed stop the re-connect operation but I'm still concerned about a potential memory leak of the WebSockClient once the connectToServer() method is called. It now shows that wsPtr has a refCount=4 in that callback. At what point will this drop to zero? Once stop() is connected shouldn't you also clear the requestCallback_ callback std::function?
Thanks . . .

I've done more investigation of the potential memory leak in the Drogon implementation of the WebSocketClient. I think I've confirmed there is indeed one using valgrind with the following parameters:
valgrind --tool=memcheck --leak-check=full --show-leak-kinds=all <prog_to_execute>
Basically, using your add_stop_method_to_ws branch with my application it appears a WebSocketClient that invokes connectToServer() cannot drop it's refCount to zero so that it's freed. This seems to be related to the requestCallback_ in WebSocketClientImpl.cc not being cleared appropriately and hanging on to the reference (which may be contained in a lambda closure). I made the following changes to WebSocketClientImpl.cc:
WebSocketClientImpl.cc: ~90
        thisPtr->requestCallback_(ReqResult::NetworkFailure, nullptr, thisPtr);
        if (!thisPtr->stop_)
        {
            thisPtr->loop_->runAfter(1.0,
                                     [thisPtr]() { thisPtr->reconnect(); });
        }
        else
        {
            thisPtr->requestCallback_ = nullptr;    // ADDED!
        }

WebSocketClientImpl.cc: ~227
    if (!responseParser->parseResponse(msgBuffer))
    {
        requestCallback_(ReqResult::BadResponse, nullptr, shared_from_this());
        requestCallback_ = nullptr;      // ADDED!
        connPtr->shutdown();
        websockConnPtr_.reset();
        tcpClientPtr_.reset();
        return;
    }

WebSocketClientImpl.cc`:~243
        if (resp->statusCode() != k101SwitchingProtocols ||
            acceptStr != wsAccept_)
        {
            requestCallback_(ReqResult::BadResponse,
                             nullptr,
                             shared_from_this());
            requestCallback_ = nullptr;     // ADDED!
            connPtr->shutdown();
            websockConnPtr_.reset();
            tcpClientPtr_.reset();
            return;
        }

After running my application again with the previously mentioned valgrind parameters no discernable memory leaks were found with the exception of a Json::Value::nullSingleton() shown below:
==5872== HEAP SUMMARY:
==5872==     in use at exit: 40 bytes in 1 blocks
==5872==   total heap usage: 10,069 allocs, 10,068 frees, 16,245,053 bytes allocated
==5872==
==5872== 40 bytes in 1 blocks are still reachable in loss record 1 of 1
==5872==    at 0x4C3217F: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5872==    by 0x5CE0B89: Json::Value::nullSingleton() (in /usr/lib/x86_64-linux-gnu/libjsoncpp.so.1.7.4)
==5872==    by 0x5CD3348: ??? (in /usr/lib/x86_64-linux-gnu/libjsoncpp.so.1.7.4)
==5872==    by 0x40108D2: call_init (dl-init.c:72)
==5872==    by 0x40108D2: _dl_init (dl-init.c:119)
==5872==    by 0x40010C9: ??? (in /lib/x86_64-linux-gnu/ld-2.27.so)
==5872==
==5872== LEAK SUMMARY:
==5872==    definitely lost: 0 bytes in 0 blocks
==5872==    indirectly lost: 0 bytes in 0 blocks
==5872==      possibly lost: 0 bytes in 0 blocks
==5872==    still reachable: 40 bytes in 1 blocks
==5872==         suppressed: 0 bytes in 0 blocks

It seems my changes fix a significant leak given the number of references a WebSocketClient instance holds on to. Please review my changes and let me know what you think. I may have missed some instances where requestCallback_ should still be reset. Perhaps you can improve on my suggestions or perhaps tell me why you don't think my changes are necessary. I would be interested in your insights.
Thanks . . .

@gschmottlach-xse Sorry for getting to the issue late. May you make a PR or a patch file for your changes? I tried your proposed change with AddressSanitizer (-fsanitize=address). But still getting the same amount of leak in our integration tests. So either you did something to make it not leak or I did something wrong:
Great job hunting the leak down! Many thanks, really.
My diff:
diff --git a/lib/src/WebSocketClientImpl.cc b/lib/src/WebSocketClientImpl.cc
index 7399352..a3bbd09 100644
--- a/lib/src/WebSocketClientImpl.cc
+++ b/lib/src/WebSocketClientImpl.cc
@@ -41,6 +41,7 @@ WebSocketConnectionPtr WebSocketClientImpl::getConnection()
 void WebSocketClientImpl::stop()
 {
     stop_ = true;
+    requestCallback_ = nullptr;
     tcpClientPtr_.reset();
 }
 void WebSocketClientImpl::createTcpClient()
@@ -93,6 +94,10 @@ void WebSocketClientImpl::createTcpClient()
             thisPtr->loop_->runAfter(1.0,
                                      [thisPtr]() { thisPtr->reconnect(); });
         }
+        else
+        {
+            thisPtr->requestCallback_ = nullptr;
+        }
     });
     tcpClientPtr_->setMessageCallback(
         [weakPtr](const trantor::TcpConnectionPtr &connPtr,
@@ -223,6 +228,7 @@ void WebSocketClientImpl::onRecvMessage(
     if (!responseParser->parseResponse(msgBuffer))
     {
         requestCallback_(ReqResult::BadResponse, nullptr, shared_from_this());
+        requestCallback_ = nullptr;
         connPtr->shutdown();
         websockConnPtr_.reset();
         tcpClientPtr_.reset();
@@ -243,6 +249,7 @@ void WebSocketClientImpl::onRecvMessage(
                              shared_from_this());
             connPtr->shutdown();
             websockConnPtr_.reset();
+            requestCallback_ = nullptr;
             tcpClientPtr_.reset();
             return;
         }

❯ ./integration_test_server
...
    #25 0xaaaacf8e095c in std::enable_if<std::__and_<std::is_void<void>, std::__is_invocable<std::_Bind<void (trantor::Connector::*(std::shared_ptr<trantor::Connector>))()>&> >::value, void>::type std::__invoke_r<void, std::_Bind<void (trantor::Connector::*(std::shared_ptr<trantor::Connector>))()>&>(std::_Bind<void (trantor::Connector::*(std::shared_ptr<trantor::Connector>))()>&) /usr/include/c++/10.2.0/bits/invoke.h:153
    #26 0xaaaacf8e0314 in std::_Function_handler<void (), std::_Bind<void (trantor::Connector::*(std::shared_ptr<trantor::Connector>))()> >::_M_invoke(std::_Any_data const&) /usr/include/c++/10.2.0/bits/std_function.h:291
    #27 0xaaaacf502054 in std::function<void ()>::operator()() const /usr/include/c++/10.2.0/bits/std_function.h:622
    #28 0xaaaacf8d84c0 in trantor::Channel::handleEventSafely() /home/marty/drogon/trantor/trantor/net/Channel.cc:106
    #29 0xaaaacf8d81d0 in trantor::Channel::handleEvent() /home/marty/drogon/trantor/trantor/net/Channel.cc:66

SUMMARY: AddressSanitizer: 121736 byte(s) leaked in 801 allocation(s).

@an-tao  It's kinda weird that resetting requestCallback_ made the leak go away. It should release the internal reference when the client destructs anyway. How curious...

Your patches look right from what I can see. Perhaps it's something I did in my application code vs. the library itself. Did you explicitly stop() the WebSocketClient after initially calling connectToServer()? I know I do that (which now explicitly nulls the requestCallback_ callback with your patch).
I'm investigating another issue at the moment. Once I get things sorted out in my application I'll try to re-run my valgrind tests to verify the leaks are truly gone for my use-case. In the interim, here's my GIT diff from the 'add_stop_method_to_ws' branch.
diff --git a/lib/src/WebSocketClientImpl.cc b/lib/src/WebSocketClientImpl.cc
index 7399352..cdf6546 100644
--- a/lib/src/WebSocketClientImpl.cc
+++ b/lib/src/WebSocketClientImpl.cc
@@ -93,6 +93,10 @@ void WebSocketClientImpl::createTcpClient()
             thisPtr->loop_->runAfter(1.0,
                                      [thisPtr]() { thisPtr->reconnect(); });
         }
+        else
+        {
+            thisPtr->requestCallback_ = nullptr;
+        }
     });
     tcpClientPtr_->setMessageCallback(
         [weakPtr](const trantor::TcpConnectionPtr &connPtr,
@@ -223,6 +227,7 @@ void WebSocketClientImpl::onRecvMessage(
     if (!responseParser->parseResponse(msgBuffer))
     {
         requestCallback_(ReqResult::BadResponse, nullptr, shared_from_this());
+        requestCallback_ = nullptr;
         connPtr->shutdown();
         websockConnPtr_.reset();
         tcpClientPtr_.reset();
@@ -241,6 +246,7 @@ void WebSocketClientImpl::onRecvMessage(
             requestCallback_(ReqResult::BadResponse,
                              nullptr,
                              shared_from_this());
+            requestCallback_ = nullptr;
             connPtr->shutdown();
             websockConnPtr_.reset();
             tcpClientPtr_.reset();

@gschmottlach-xse #972 Adds stop() to stop the entire WS. Also fixes a memory leak. Maybe that's the issue you are facing?

I tried your latest change to add stop() and fix other memory leaks. Unfortunately, that does not stop the leak from WebsockClientImpl.cc. In order to get the leaking to stop I had to specifically null the requestCallback_ function pointer in the following locations:
diff --git a/lib/src/WebSocketClientImpl.cc b/lib/src/WebSocketClientImpl.cc
index a72eb6e..74eb2b6 100644
--- a/lib/src/WebSocketClientImpl.cc
+++ b/lib/src/WebSocketClientImpl.cc
@@ -47,6 +47,7 @@ void WebSocketClientImpl::stop()
         websockConnPtr_.reset();
     }
     tcpClientPtr_.reset();
+    requestCallback_ = nullptr;
 }
 void WebSocketClientImpl::createTcpClient()
 {
@@ -231,6 +232,7 @@ void WebSocketClientImpl::onRecvMessage(
         connPtr->shutdown();
         websockConnPtr_.reset();
         tcpClientPtr_.reset();
+        requestCallback_ = nullptr;
         return;
     }

@@ -249,6 +251,7 @@ void WebSocketClientImpl::onRecvMessage(
             connPtr->shutdown();
             websockConnPtr_.reset();
             tcpClientPtr_.reset();
+            requestCallback_ = nullptr;
             return;
         }

I suspect the closure associted with requestCallback_ is inadvertently keeping the WebsocketClientImpl alive longer than it should. If I do not reset  requestCallback_ in the stop() method then it leaks every time. There is some danger here, however, of an invalid memory READ. I typically call stop() from a lambda function passed into the connectToServer() function. It's configured to call stop() if the RequestResult != Ok.  This is because the callback (holding the wsPtr) is freed when the requestCallback_ is reset so you can't have any code that executes following the call to wsPtr->stop(). See the code below for a snippet of the callback. Perhaps it will provide some details on what I'm trying to accomplish.
         listener.wsClient->connectToServer(
                    req,
                    [this, observer = std::move(listener)]
                    (ReqResult r,
                    const HttpResponsePtr &,
                    const WebSocketClientPtr& wsPtr) mutable {
                        if ( r != ReqResult::Ok )
                        {
                            LOG_WARN << "Failed to establish websocket connection";
                            jRpc->resp("Failed to establish websocket connection",
                                    JSONRPCERR_CONN_ERROR);

                            // This *MUST* be the last statement run in this callback
                            // because the call to stop() will cause the callback to
                            // be reset and thus free the data associated with it.
                            wsPtr->stop();
                        }
                        else
                        {
                        . . .
                        }
                    }
            );

I call it from there then it MUST be the last function I call from the lambda callback or valgrind reports a memory READ error

I agree, this is dangerous. Killing yourselves is definitely a UB.
Ahhhh.. I should have read the issue more carefully. In your code:
ClientInfo info;

info.wsClient = WebSocketClient::newWebSocketClient("ws://<IP_ADDRESS>:55000");
auto req = HttpRequest::newHttpRequest();
req->setPath("/");
info.wsClient->connectToServer(
    req,
    [observer = std::move(info)]
    (ReqResult r,
....

You've captured the websocket client itself inside the lambda, causing a self-reference. So event when connectionClosed begin triggered. The self reference prevents the client from destructing. Maybe store the client elsewhere and submit a selection function with app().getLoop()->queueInLoop([ptr=wsPtr.get()](){find_and_delete_the_shared_ptr_holder(ptr);}) to avoid deleting the object while you are running.

Thanks @marty1885 for the suggestion. I was a little more "careful" with what I moved into the closure and it appears to have fixed my WebsocketClientImpl leak. Better to keep the info.wsClient outside the closure and just access it directly in the lamda by passing in [this] and acessing it as a member of the outer class.

Thank all. All questions discussed in this issue seems to have been solve. Closing.
Feel free to reopen if anyone wants to.


[Bug/Security] Invalid Felt value is not rejected

Invalid Felt value is not rejected
We (@fuzzinglabs) found a bug while doing differential fuzzing against Juno Pedersen's hash and felt implementation.
For this specific felt value (0xfb01012100000000000000000000000000000000000000000000000000000000), the following Pedersen/Felt implementations return:

Pathfinder: OverflowError
starknet-rs: FromByteArrayError
starkware-crypto-sys: Error code (1)
Juno: 0xfb01012100000000000000000000000000000000000000000000000000000000

The Juno implementation of a felt object authorizes the creation with a value superior to the prime number used.
Prime number:
0x800000000000011000000000000000000000000000000000000000000000001

Created Felt:
0xfb01012100000000000000000000000000000000000000000000000000000000

This can lead to creating a Pedersen Hash based on this invalid felt value.
Expected Behavior
The program should reject the creation of the Felt.
Your Environment

 Juno commit: c5cc5578235cf9b875dceb23fa229e6467c3d660

 cargo 1.66.0-nightly (082503982 2022-09-13)

 Ubuntu 20.04

Steps to Reproduce
Testing program:
package main

import (
	"fmt"

	"github.com/NethermindEth/juno/pkg/crypto/pedersen"
	"github.com/NethermindEth/juno/pkg/felt"
)

func main() {

	a := new(felt.Felt).SetHex("fb01012100000000000000000000000000000000000000000000000000000000")
	b := new(felt.Felt).SetHex("0000000000000000000000000000000000000000000000000000000000000000")

	fmt.Printf("%s\n", pedersen.Digest(a, b).Hex())
}

this is probably still the case
https://github.com/ConsenSys/gnark-crypto/issues/346


LibCore: Fix SocketAddress.h compilation errors on Windows

Including winsock2.h in a header file is undesirable for architectural reasons, so I pulled the needed types from ws2def.h and ws2ipdef.h into a separate header.
Files inaddr.h and afunix.h are tiny and can be included directly. They each define a single struct (in_addr and sockaddr_un respectively).
I removed the #if (_WIN32_WINNT < 0x0600) code because it is not relevant for us. It is intended for Windows XP/Windows Server 2003 and earlier, but Ladybird doesn't support 32-bit, and 64-bit Windows XP is very rare.

@R-Goc Does it work for you?

It's creating a bit of an issue in system.h and systemWindows.cpp
The issue is that when including system.h we include the sockaddr-win needed there to provide the addrinfo related things. However, this will cause a lot of redefinitions as we need to include WinSock2.h to implement sockets.

I addressed this issue. You can include winsock2.h after sockaddr-win.h.

Ok I'll check. Maybe clang format is moving includes around.

While clang-fromat was indeed moving includes around, turns out the issue is with ws2tcpip.h. Looks like with sockaddr-win.h included the only thing needed from there is gai_strerror(). Though that can be replaced with WSAGetLastError, which would mean different error handling for windows and linux, but I think that's fine.

Should we just change AF_UNIX in SocketAddress.h to AF_LOCAL? Or define AF_UNIX to AF_LOCAL here?

Yes, sockaddr-win.h doesn't work with ws2tcpip.h. If a declaration from ws2tcpip.h is needed it is supposed to be included in sockaddr-win.h. However, I don't want to include gai_strerror  because it is inline and AK::Error::from_windows_error can be used instead.
AF_UNIX is not used anywhere in the codebase, that's why I didn't define it.

It is in SocketAddress.h sockaddr-win isn't a replacement for SocketAddress.h

As mentioned on another PR, please make any and all added header files follow the project conventions for naming

@ADKaster I renamed the file.


Happy Holi!

Happy Holi!
just made this, i think it is cool so i shared it here :smile:
demo: https://anuraghazra.github.io/Verly.js/examples/typography/
made with verly.js: https://github.com/anuraghazra/Verly.js

BTW some letters are still missing i'm working on this verly.js physics engine. if anyone have any ideas to make the typography better please make a PR or create an issue.
i'm using a grid to make the points and then calculate the distance from each points to join them arbitrarily.

Hi,
Thats awesome.
Great work!!

Oh! Thanks!!

Thats Amazing ! keep up the good work

Thank you


Next.js App fails to start with next-i18next-middleware.js in server.js ...

Everything works without the middleware, but as soon as I add that, in fact, added the same server.js as the example, I get the following:
(node:80820) UnhandledPromiseRejectionWarning: TypeError: Cannot destructure property `allLanguages` of 'undefined' or 'null'.
    at _default (/Volumes/HDD80GB/Users/moose/Documents/_DEV/react-apps/deep_cast/dc_next_pwa/node_modules/next-i18next/dist/commonjs/middlewares/next-i18next-middleware.js:29:7)

    at /Volumes/HDD80GB/Users/moose/Documents/_DEV/react-apps/deep_cast/dc_next_pwa/server.js:15:13
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)
(node:80820) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)

(node:80820) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
^C
Mooses-High-Sierra:dc_next_pwa moose$ node -v
v8.12.0

Also, to even get up to here I had to replace my i18n.js from the following:
import NextI18Next from 'next-i18next';

const NextI18NextInstance = new NextI18Next({
	defaultLanguage: 'en',
	otherLanguages: ['de', 'es'],
	localeSubpaths: true,
});

export default NextI18NextInstance;

/* Export class methods as named exports. This is a must! */
export const {
	i18n,
	appWithTranslation,
	withNamespaces,
	Link,
	Trans,
} = NextI18NextInstance;

To the following:

const NextI18Next = require('next-i18next').default;

const NextI18NextInstance = new NextI18Next({
	defaultLanguage: 'en',
	otherLanguages: ['de', 'es'],
	localeSubpaths: true,
});

Because, otherwise, the server won't start with this error:
SyntaxError: Unexpected token import

Transpiling your server code is up to you. Can you please provide a reproducible example? Are you exporting your class?

@ahmedmusawir If you are having troubles using this package, I would request that you open one issue with a link to a reproducible example (repo), and a clear account of what is going wrong.

Thank you very much for your reply. Great job with the plugin by the way. The app's lang support is functional without this plugin, only I'm having some issues at the first load. Here is a working repo:
https://github.com/ahmedmusawir/dc_next_pwa_stage_7
Plz let me know if I'm doing something wrong. Thanx in advance.

Please keep your questions contained to a single issue.


.modal-open class not removed when closing modal quickly

I have multiple modals on a page and whenever I open one and close it quickly by either the .close button or clicking outside the modal the .modal-open class does not get removed from the body preventing me form scrolling my page.
I've also added data-backdrop="static" to the modal so it can only be dismissed by the .close button but this also is not removing the .modal-open class. It also appears it is not removing the inline display: block  from the modal and simply changing the opacity back to 0.
Any ideas of what I might be having an issue with?

Thanks for the find, will look into it asap.

@adibbz ?

@thednp Do you have a email or way to contact you privately? Don't want to share dev link publicly.

dnp.digital @ gmail.com

@adibbz the fade class is now optional for Modal, working as expected. Will also implement this feature for Alert, Tab, Tooltip and Popover components. Both V3 and V4.

@thednp so were you able to build and push this up today?

I am almost there, this got me to a point I found some new unresolved cases, incredibly, with the tabs...

@adibbz please download latest master and do some testing.

@thednp Removing fade class resolved the body scroll issue. Thank you!

Also make sure to test the other components I mentioned, they've been changed to support this functionality.


BoringSSL is not supported on linux

Describe the bug
BoringSSL is not fully supported on linux. The build tools only seem to build for android and do not have offsets for linux (desktop).
Expected behavior
Build scripts and tools should have BoringSSL support.
Screenshots
If applicable, add screenshots to help explain your problem.
Linux Server/Android (please complete the following information):

OS: ubuntu-linux-22-04-02-desktop
Arch: aarch64
Kernel Version: 6.5.0-26-generic
Version: a8acecee080779e1a55a1a57d62e6d682ff21661

Additional context
The ./utils/boringssl_non_android_offset.sh is also broken - it mostly has android code.

You need to empty the existing borlingss repository under the deps directory and re-clone the code using boringssl_non_android_offset.sh.

ping? @mspublic

Even with that it’s looking for android versions - not base Linux. The script needs to be modified to point to a specific commit it seems.

The current difficulty is that there are no feature identifiers in the libssl.so dynamic link library to distinguish between versions. It's not just about being unable to differentiate between Linux and Android.
but even on Android, it's impossible to distinguish the version of BoringSSL. Therefore, the current method for distinguishing BoringSSL versions is by selecting corresponding offsets based on the Android version, rather than using the VersionNumber string in OpenSSL.


'$ANDROID_HOME' is not recognized as an internal or external command, operable program or batch file.

Hi,
I get the following error, please advice how it can be solved
'$ANDROID_HOME' is not recognized as an internal or external command, operable program or batch file.
System Variables:
ANDROID_HOME  - C:\Android\Sdk
Path -  C:\Android\Sdk\tools;C:\Android\Sdk\build-tools
Environment details:
OS - windows 10
Module version:
pure-python-adb==0.3.0.dev0
Additional information:
adb, android recognized in cmd

@bwomsm1


Google Cloud Storage: NoSuchMethodError for method setReturnRawInputStream()

Environment details
OS type and version: MacOS Mojave 10.14.6
Java version: 1.8.0_161
google-cloud-java version(s):  Maven dependency
		<dependency>
			<groupId>com.google.cloud</groupId>
			<artifactId>google-cloud-storage</artifactId>
			<version>1.79.0</version>
		</dependency>

Code example
  public void readerFromStrings(String bucketName, String blobName) throws IOException {
    // [START readerFromStrings]
    try (ReadChannel reader = storage.reader(bucketName, blobName)) {
      ByteBuffer bytes = ByteBuffer.allocate(64 * 1024);

// Value in condition always returns 0 due to NoSuchMethodError from stack trace
      while (reader.read(bytes) > 0) {
        bytes.flip();
        // do something with bytes
        bytes.clear();
      }
    }

Stack trace
Exception in thread "pool-1-thread-1" java.lang.NoSuchMethodError: com.google.api.services.storage.Storage$Objects$Get.setReturnRawInputStream(Z)Lcom/google/api/client/googleapis/services/AbstractGoogleClientRequest;
	at com.google.cloud.storage.spi.v1.HttpStorageRpc.read(HttpStorageRpc.java:666)
	at com.google.cloud.storage.BlobReadChannel$1.call(BlobReadChannel.java:127)
	at com.google.cloud.storage.BlobReadChannel$1.call(BlobReadChannel.java:124)
	at com.google.api.gax.retrying.DirectRetryingExecutor.submit(DirectRetryingExecutor.java:105)
	at com.google.cloud.RetryHelper.run(RetryHelper.java:74)
	at com.google.cloud.RetryHelper.runWithRetries(RetryHelper.java:51)
	at com.google.cloud.storage.BlobReadChannel.read(BlobReadChannel.java:123)

Any additional information below
I have a working version that uses blob.getContent in order to retrieve the file from storage, but due to some limitations on my end I need to stream the file in chunks.  When I refactored my code to use the ReadChannel I started running into this issue. I really appreciate any and all help I can get with this.  From my understanding it could be an issue with my google-cloud-java version, but I tried updating to 1.93 and I still ran into this issue.  Thank you in advance!

@Brett-Wood  I'm not able to reproduce this issue below are the code snippets and output.
Code :
public static void main(String[] args) throws IOException {
    String bucket = "bucketName";
    String blob = "test-blob";
    Storage storage = StorageOptions.getDefaultInstance().getService();
    createBlob(storage, bucket, blob);
    readerFromStrings(storage, bucket, blob);
  }

  public static void createBlob(Storage storage, String bucketName, String blobName) {
    BlobId blobId = BlobId.of(bucketName, blobName);
    BlobInfo blobInfo = BlobInfo.newBuilder(blobId).setContentType("text/plain").build();
    Blob blob = storage.create(blobInfo, "a simple blob has been created".getBytes());
    System.out.println("Blob : " + blob.getName() + " created successfully");
  }

  public static void readerFromStrings(Storage storage, String bucketName, String blobName)
      throws IOException {
    // [START readerFromStrings]
    try (ReadChannel reader = storage.reader(bucketName, blobName)) {
      ByteBuffer bytes = ByteBuffer.allocate(64 * 1024);
      // Value in condition always returns 0 due to NoSuchMethodError from stack trace
      while (reader.read(bytes) > 0) {
        System.out.println("Everything works fine without error");
        bytes.flip();
        bytes.clear();
      }
    }
  }

Output :
Blob : test-blob created successfully
Everything works fine without error

Thank you for your help and trying to reproduce the issue.  I was able to reproduce it again this morning
Here is my exact code snippet that is causing the issue:
	public static String readBlobContent(Storage storage, String bucketName, String blobName, Connection con, String email, String fileName) throws Exception {
		PreparedStatement update_pstmt = null;
		String document_key = String.valueOf(System.currentTimeMillis());
		try{
			try(ReadChannel reader = storage.reader(bucketName, blobName)) {
				ByteBuffer bytes = ByteBuffer.allocate(64*1024);
				while(reader.read(bytes) > 0) {
					byte buffer[] = new byte[64*1024];
					bytes.flip();
					bytes.get(buffer);
					update_pstmt = con.prepareStatement("UPDATE table SET DOCUMENT=DOCUMENT+? WHERE DOCUMENT_KEY=?");
					update_pstmt.setBytes(1, buffer);
					update_pstmt.setString(2, document_key);
					update_pstmt.executeUpdate();
					bytes.clear();
				}
				reader.close();
			}
			return document_key;
		} catch(Exception e) {
			throw e;
		} finally {
			DBUtil.closeConnections(null, update_pstmt, null, null);
		}
	}

I tried using 1.93 again for my version and the full stack trace looks like so:
Exception in thread "pool-1-thread-1" java.lang.NoSuchMethodError: com.google.api.services.storage.Storage$Objects$Get.setReturnRawInputStream(Z)Lcom/google/api/client/googleapis/services/AbstractGoogleClientRequest;
	at com.google.cloud.storage.spi.v1.HttpStorageRpc.createReadRequest(HttpStorageRpc.java:658)
	at com.google.cloud.storage.spi.v1.HttpStorageRpc.read(HttpStorageRpc.java:693)
	at com.google.cloud.storage.BlobReadChannel$1.call(BlobReadChannel.java:127)
	at com.google.cloud.storage.BlobReadChannel$1.call(BlobReadChannel.java:124)
	at com.google.api.gax.retrying.DirectRetryingExecutor.submit(DirectRetryingExecutor.java:105)
	at com.google.cloud.RetryHelper.run(RetryHelper.java:74)
	at com.google.cloud.RetryHelper.runWithRetries(RetryHelper.java:51)
	at com.google.cloud.storage.BlobReadChannel.read(BlobReadChannel.java:123)
	at com.project.util.GoogleBucketUtil.readBlobContent(GoogleBucketUtil.java:158)
	at com.project.util.executors.GoogleBucketSelectExecutor.run(GoogleBucketSelectExecutor.java:48)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

Do you think that there is a chance it could be conflicting maven dependencies in my project?  I only have one goolge-cloud-storage dependency listed in my project, but I do have other google API dependencies as well.  Thanks again for your help.

@Brett-Wood can you please post project dependency tree?

This can be closed.  I realized that I never updated my google-api-client dependency, so I updated that and it resolved my issue.  Thank you for your help!


Add ability to refresh tokens

Details - https://github.com/Lusitanian/PHPoAuthLib/pull/399

Also https://github.com/Lusitanian/PHPoAuthLib/issues/398


upd(RR): update RR version in the go.mod

Reason for This PR

Update RR version

Description of Changes

Update go.mod RR version from 2.1.0-beta.2 to 2.1.0-beta.3

License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

[x] All commits in this PR are signed (git commit -s).
[x] The reason for this PR is clearly provided (issue no. or explanation).
[x] The description of changes is clear and encompassing.
[x] Any required documentation changes (code and docs) are included in this PR.
[x] Any user-facing changes are mentioned in CHANGELOG.md.
[x] All added/changed functionality is tested.

Codecov Report

Merging #59 (8e53eaa) into master (88fda59) will decrease coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   66.70%   66.49%   -0.21%
==========================================
  Files          17       17
  Lines         979      979
==========================================
- Hits          653      651       -2
- Misses        235      236       +1
- Partials       91       92       +1

Impacted Files
Coverage Δ

workflow/process.go
69.86% <0.00%> (-0.92%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88fda59...8e53eaa. Read the comment docs.


Attribution

_> I'm really sorry about this happening again. I think I'm moving too fast with GitHub's PR mechanism

NP


Plugin Creators Guide: add content to debugging sections

The debugging sections need content!

how to debug in a server service using the plugin-ref file
how to debug a plugin Deck component

Relates to #1792 (Umbrella) Plugin Guides

@spinnakerbot remove-label stale


feature: Lazy load of denops plugin

Did you check the docs?

[X] I have read all the lazy.nvim docs

Is your feature request related to a problem? Please describe.
Plugins made by denops are loaded asynchronously using deno, so they require their own delayed loading process.
Related:

https://github.com/Shougo/dein.vim/blob/1fcec99790851d7345498cd4dd8b6b0c5a22ef46/autoload/dein/autoload.vim#L69-L82
https://github.com/wbthomason/packer.nvim/pull/755

Describe the solution you'd like
I will create a PR if there is no problem to include the function.
Here is the code I have on hand to try.
function M.load_denops_on_lazy(plugin_name, opts)
  return function()
    local plugins = require('lazy').plugins()
    local plugin = nil
    for _, p in ipairs(plugins) do
      if p.name == plugin_name then
        plugin = p
        break
      end
    end

    if not plugin or vim.fn.isdirectory(plugin.dir .. '/' .. 'denops') == 0 then
      return
    end

    local denops_plugins = vim.fn.globpath(plugin.dir, 'denops/*/main.ts', true, true)
    for _, denops_plugin in ipairs(denops_plugins) do
      denops_plugin = vim.fn.fnamemodify(denops_plugin, ':h:t')

      local once = false
      for _ = 1, 100 do
        if vim.fn['denops#server#status']() == 'running' then
          break
        end
        if not once then
          require('lazy').load({ plugins = 'denops.vim' })
          vim.fn['denops#server#start']()
          once = true
        end
        vim.cmd([[sleep 10m]])
      end

      if vim.fn['denops#plugin#is_loaded'](denops_plugin) == 0 and vim.fn['denops#server#status']() == 'running' then
        pcall(vim.fn['denops#plugin#register'], denops_plugin, { mode = 'skip' })
        if opts == nil or opts.wait then
          vim.fn['denops#plugin#wait'](denops_plugin)
        end
      end
    end
  end
end

Describe alternatives you've considered
It would be helpful if you could tell me if the lazy load implementation is appropriate, as it does not have to be included in lazy.nvim.
Additional context
No response

Thank you for the suggestion, but I don't think it's a good idea to add this to lazy


Some fixes and polishing

Upgrade to SI Java DSL 1.1.2
Introduce SourcePayloadProperties to move payload option outside of any Source module.
Right now it makes sense only for the TriggerSource.
Make some tests ignorable on Windows, since they are not intended to pass there.
Add server.port=-1 for the CassandraSinkIntegrationTests to make it a bit faster bypassing Tomcat start.
Close context in the CassandraSinkPropertiesTests.
Remove redundant usage of MaxMessagesProperties in the Source modules since it is picked up by the TriggerConfiguration.

LGTM; polishing here https://github.com/garyrussell/spring-cloud-stream-modules/commit/42863c86224b4a413d6b9335aca77145f8a63dfb to address @ericbottard 's concern.

Merged as 7f094f306e0871fe6e1bb4b97e636c3d7f96bc16


feat: update code to use generated discord::user::* code

@LucasMull you can test it in the gen-user branch.

I will close this and create another one.


🚧 Remove MUX from our codebase #1525

There is still the MUX feature flag in FeatureFlags.js in addition to some MUX stuff in the sanityv3 project


How to load a component and a trajectory

Hi,
I want to load a GRO file and its correspondant TRR.
I use NGL from npm client side and the following code, but it returns "Cannot read property getNumframesUrl"
I've tried with some gro files and trajectories without success.
stage.loadFile(pathToGro)
.then(function (component) {
     component.addRepresentation('ball+stick', { color: 'element' });
     stage.autoView();
     component.addTrajectory(pathToTRR);
});

Error Stack
Error TypeError: Cannot read property 'getNumframesUrl' of undefined
    at RemoteTrajectory.getNumframes (/node_modules/ngl/dist/ngl.esm.js:76953)
    at RemoteTrajectory.Trajectory (/node_modules/ngl/dist/ngl.esm.js:66298)
    at new RemoteTrajectory (/node_modules/ngl/dist/ngl.esm.js:76872)
    at makeTrajectory (/node_modules/ngl/dist/ngl.esm.js:77019)
    at StructureComponent.addTrajectory (/node_modules/ngl/dist/ngl.esm.js:77437)

There's no "trajectory" property in DatasourceRegistry.trajectory

Thanks

I experienced the same problem and have spent hours trying to solve it, without success.
Any help would be highly appreciated.

So I've never used this bit of NGL so I don't have a working example to hand other than the ones in the webapp (which you already know about)
Is it possible you're using an out of date version? Looking at the current code, Datasource doesn't seem to have a trajectory attribute. Which version are you getting from npm? - I've only recently got the keys to npm from Alex and haven't had a chance to make a release yet - I think if you specify ngl@next you should at least get a fairly recent version. Failing that you can try building from source and importing with a relative path.
If that doesn't help, could you possibly share some example files for which it's not working?
(Datasource is used to map custom url schemes (as well as mapping standard things like 'https://' to a an Ajax request) - e.g. that's how the data:// and rcsb:// schemes are defined in the examples.)
Any other information you have to create a minimal test case would be really helpful

Hi, thanks for the answer.
I was using version 0.10 but now I've generated the js library from the repository with npm.
The problem persists, it's not possible to load a GRO component with trajectory inside the file but when I load the same file into the web application (MDSrv) it's well represented (loading the file with the asTrajectory checked)
stage = new NGL.Stage('viewport');
self.stage
     .loadFile(pathToGroFileWithFramesInside, { asTrajectory: true })
     .then((component) => {
              component.addRepresentation('ball+stick',  { colorScheme: 'atomindex' });
              stage.autoView();
              console.log(component);
      });

If I load the component and then the trajectory as trr, it also fail. But in the MDSrv loading the component and then attaching a TRR trajectory works good.
stage = new NGL.Stage('viewport');
self.stage
     .loadFile(pathToGroFile)
     .then((component) => {
              component.addRepresentation('ball+stick',  { colorScheme: 'atomindex' });
              component.addTrajectory(trrFile);
              stage.autoView();
              console.log(component);
      });

I attach the files so you can test it.
test_NGL_files.zip

I haven't looked in great detail but a quick observation: loading those files gives me some very strange things (do you have lipids that cross over and periodic boundary conditions?)

Thank you for your reply!
I realize that I chose a very bad example (it is a water droplet solvated with dodecane crossing periodic boundaries, therefore the strange behavior).
I have prepared a new set of files (see attachment) that reproduces the same problem with NGL, but does not have the issue of periodic boundary conditions.
files.zip

Apologies for the long wait, is this still an issue or did you find a fix/workaround?
I just tried with the files you attached - I edited the parser/gro-trajectory.js file to load your input file (trajectory_gro.gro) and it's working for me now:
  stage.loadFile('data://trajectory_gro.gro', { // File from zip above
    asTrajectory: true
  }).then(function (o) {
    o.addTrajectory()
    o.addRepresentation('cartoon')
    o.addRepresentation('helixorient')
    o.addRepresentation('line', {  })
    stage.autoView()
  })

Apologies for the long wait, is this still an issue or did you find a fix/workaround?
I just tried with the files you attached - I edited the parser/gro-trajectory.js file to load your input file (trajectory_gro.gro) and it's working for me now:
  stage.loadFile('data://trajectory_gro.gro', { // File from zip above
    asTrajectory: true
  }).then(function (o) {
    o.addTrajectory()
    o.addRepresentation('cartoon')
    o.addRepresentation('helixorient')
    o.addRepresentation('line', {  })
    stage.autoView()
  })

Now how to play/pause?

how we can separately upload the gro and xtc file using ngl, I tried the method what @ixdi ixdi suggested but got the following error:
Error loading structure file (.gro): TypeError: de.TrajectoryDatasource is undefined
@fredludlow
@ixdi


automatically add dependencies for vim plugins with a *.rockspec

Motivation for this change
Thee are many neovim plugins that are written in lua, compared to vimscript, it favors using external dependencies (well mostly plenary or nvim-treesitter for now).
This is an attempt to leverage *.rockspec files in these vim plugins to autodeduce dependencies, this updates the vim update plugin so that:
1/ it looks for a rockspec in the source of the plugin
2/ if it detects one, it generates the lua derivation via luarocks2nix
3/ it generates the vim plugin derivation as usual but inherits buildInputs/meta from the lua derivation.
Right now, I've separated the lua plugins from the traditional system to ease updates. One question is if we should instead move these plugins to the luaPackages to maintainers/scripts/luarocks-packages.csv
I use this command to update the lua-generated.nix
./pkgs/misc/vim-plugins/update.py --proc=10 --debug DEBUG --input-names ./pkgs/misc/vim-plugins/lua-plugin-names --out ./pkgs/misc/vim-plugins/lua-generated.nix

NB: there is some effort to define a (neo)vim plugin format https://github.com/nvim-lua/nvim-package-specification . For now I've added rockspecs to several plugins not sure how it's going to evolve.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

this was not upstreamable. Much better approach at https://github.com/NixOS/nixpkgs/pull/178180


Add alertsnitch to docker-compose.yml

That'd be great if the docker-compose.yml could contain both mysql and alertsnitch.
I currently use the container at registry.gitlab.com/yakshaving.art/alertsnitch only, in --dry-run mode.

Hey @fabricat in version 0.2.1 you have a docker-compose that includes alertsnitch and connects to the database for testing.
Enjoy.


HostAddress may not test equal after Jackson serialization roundtrip

Presto's HostAddress implementation does not round-trip properly when getting converted to and from String representation.
HostAddress base = HostAddress.fromParts("[1111:2222:3333:4444:5555:6666:7777:8888]", 1234);
HostAddress hostAddress1 = HostAddress.fromParts(base.getHostText(), base.getPort());
HostAddress hostAddress2 = hostAddress.fromString(base.toString());
Assert.assertEquals(hostAddress1, hostAddress2);

This poses a problem because passing a HostAddress through Jackson serialization (which uses the string representation) can produce a HostAddress that will not test equal to the original.

I think the problem is with equals/hashCode methods which takes into account hostname, port and hasBracketlessColons flag.
toString method always prints brackets around IPv6 hostnames ("[1111:2222:3333:4444:5555:6666:7777:8888]:1234" in this case) and getHostText() returns hostname without those brackets ("1111:2222:3333:4444:5555:6666:7777:8888"). In example which you provided, both addresses are equal on hostname and port fields, but not on hasBracketlessColons.
As requireBracketsForIPv6() method is not used I would recommend to completely remove this flag from this class.
I can fix this and add some unit tests.

yup, that's spot on @sogorkis, thanks for offering, but we already have a fix ready to go here =)


Add UI framework

Using, for example:

Ant Design
Material UI
reactstrap

see https://github.com/jmsv/simple-mern#extend-simple-mern
Let me know if you're interested in working on this and I'll make a target branch for the PR 🙂

I'm happy to add Material UI.   It might need some refactoring though once all other branches are merged into master

I'm ready for a target branch 😁

Go for it 😀 No need to worry about the merge - the point of this repo is to keep master as minimal as possible, and other things people might want to add are in branches and linked from the readme

Go for it 😀 No need to worry about the merge - the point of this repo is to keep master as minimal as possible, and other things people might want to add are in branches and linked from the readme

Ah yeah, I get you 👍.

done in #13


Adding notebooks folder, and auto-generating .md files

Adding notebooks folder, and auto-generating .md files from that folder for Docs.
The new notebooks folder we will be used as the canonical resource for both showcasing the notebooks from the GitHub repo, and for auto-generating the .md files of the Docs.
Solves this issue: https://github.com/lgvaz/mantisshrimp/issues/213

Codecov Report

Merging #215 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   79.89%   79.89%
=======================================
  Files         100      100
  Lines        1870     1870
=======================================
  Hits         1494     1494
  Misses        376      376

Flag
Coverage Δ

#unittests
79.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec5de4...b306303. Read the comment docs.


Bump inmanta-dev-dependencies[async,extension,pytest] from 2.106.0 to 2.107.0 (#522)

Pull request opened by the merge tool on behalf of #522

Merged in 3bfaa2fab86ce4ed14f1aa1db8b81e5ffac4f0ae


57 determination canned messages

@chris-lawton this is the branch for determination message templates

@todd-dembrey added request message templates + moved missing view stuff


Create HelloWorld.sc

@him2016 ,
This repo is beginner friendly for open source,
hence not in hacktoberfest 2023
You can contribute to Hacktoberfest-Frontend , if you have any frontend projects created using HTML+CSS+JS.
You can also checkout our Idea-Arca, the project idea bank for any languages, for open-source contributions.
These are in Hacktoberfest.
Happy Contributing season!
Keep up the good work!


Email Subscription

Is your feature request related to a problem? Please describe.

Describe the solution you'd like
I will be creating the email component.
Additional context
I am a GSSOC 2021 participant please assign me this issue.

I think it would be great if I get to work on it too just in order to keep the background theme same for all the sections(join us, newsletter, about us)!

@codewithvk May I work on it?

@Castella1313 @Sapna2001 both can refer #27 issue.


Add better handling of errors

Basically in here I have mostly copied what connexion does for formatting it's error messaging according to: https://tools.ietf.org/html/draft-ietf-appsawg-http-problem-00.
I had missed this, because I was assuming connexion would do it automatically, but actually since we integrate connexion with our own custom blueprint (and don't use it's FlaskApp object) we actually miss this step.
Most of the, little, code in here is copied/inspired by: https://github.com/zalando/connexion/blob/master/connexion/apps/flask_app.py#L38

All the issues should now be fixed. The traceback extraction will work only in python3, but I don't think we even attempt to support python2.