Diffrences in free-decay response OpenFAST v2.3 - v3.0

Hi everyone,
I am updating a model of a floating wind turbine from OpenFAST v2.3 to OpenFAST v3.0.
While running some free-decay tests I’ve noticed large differences in damping between the two OpenFAST versions. The v3.0 model seems to have less quadratic damping that the v2.3 one.
Moorings are modelled with MoorDyn, hydrodynamics are handled trough potential-flow + Morrison drag terms for second order damping. The ElastoDyn files are identical, and aerodynamics and control are switched off.
Potential-flow input files were supplied to me with the model, but I even attempted at re-calculating them with AQWA and I am getting very similar results.
I am using compiled binary executables downloaded from the “Releases” page. The files should be equivalent.
Have any changes been made to the code between these two OpenFAST versions that could explain such a behavior? I have looked at the documentation, NWTC forum and the open GitHub issues but haven't found anything. I am going over my input files again, but I’m quite certain that they are identical, apart from the parts that have been added/removed from the newer version.
I have noticed issue #824 , where a difference in linearization is reported, maybe this could be related?
Thanks in advance to anyone that may help.

Dear @frp09,
Nothing comes to mind immediately as to what would cause these differences in damping level.  It looks like the quadratic drag (dominant for larger amplitude motion) is quite similar between the two versions; the differences appear mostly at low amplitude, where radiation damping (from the potential-flow solution) likely dominates over quadratic drag.
Is the model you are running your own, or is one of the public model NREL provides?  If the former, have you seen similar behavior in one of the public models?
There were many changes and several releases between OpenFAST v2.3 and OpenFAST v3.0.  Have you tried stepping through each release to better isolate when the change occurs?
Best regards,

Dear @jjonkman ,
Thank you for the reply.
The model I'm running is not an NREL public model. For context, it is a model of the DTU 10MW on a spar-buoy. However, I have updated a model of the NREL 5MW on OC5 DeepCWind semi-sub that I created from OpenFAST v2.4 to OpenFAST v3.0 and there is no difference in free-decay results for this model, as expected. I would consider this model close to a public NREL model, since the HydroDyn part is the same as OC4 with tweaks to the Morrison drag coefficients.
Going back to the spar-buoy, based on your suggestion, I have tried to run the model with multiple versions of OpenFAST, the results I'm getting are in the figure attached. Results from v2.4 and v2.5 and from v2.6 and v3.0 are the same respectively.

It seems like I'm seeing differences when there is an API change for HydroDyn. In particular:

from v2.3 to v2.4 ExctnMod was added (I'm using option 1 in v2.4 and latter, this should be consistent with v2.3 right?)
from v2.4 to v2.5 an extra column was added to the line properties table in MoorDyn, but this seems to make no difference
from v2.5 to v2.6 several enhancements have been implemented in HydroDyn
from v2.6 to v3.0 there are no API differences for HydroDyn/ElastoDyn/MoorDyn

Also, this may or may not be relevant, but I've noticed that v2.3 to v2.5 throw an error if I try to lad the .8 WAMIT file to account for slow-drift force while v2.6 and v3.0 run with no errors/warnings. Below is the error message from OpenFAST v2.4:

FAST_InitializeAll:HydroDyn_Init:WAMIT2_Init:CheckInitInput: Warning: the .8 WAMIT output file
does not contain information that can be used for second order force calculations of platform
heave.
No second order heave forces will be calculated within the Newman's Approximation
calculations.
CheckInitInput: Warning: the .8 WAMIT output file does not contain information that can be used
for second order force calculations of platform roll.
No second order roll forces will be calculated within the Newman's Approximation
calculations.
CheckInitInput: Warning: the .8 WAMIT output file does not contain information that can be used
for second order force calculations of platform pitch.
No second order pitching forces will be calculated within the Newman's Approximation
calculations.
WAMIT2_Init:NewmanApp_InitCalc: Maximum wave direction required of 0 is notfound in the WAMIT
data file .\HD_files/HDB/sw_spar.8 for the first wave direction.
NewmanApp_InitCalc: Maximum wave direction re

FAST encountered an error during module initialization.
Simulation error level: FATAL ERROR

Aborting OpenFAST.
Any idea of what could be causing such differences? It is particularly puzzling that the OC5 testcase does not show these differences, in contrast to what I'm seeing here, so I don't know what to think, since the two cases should be quite similar from a methodological standpoint (both used potential+Morrison hydrodynamics).
Any indication, as always, is helpful
Best

Dear @frp09,
The error from the 2nd order HydroDynamics in v2.4.0 is due to a bug in a check of the angles for multi-directional waves.  This was corrected in v2.5.0, which is why you only see this issue in v2.4.0.
Does your model by any chance contain any tapered elements that are crossing the free surface?
Regards,
Andy

Dear Andy,
No worries, it's good to know that this makes sense.
I could try removing the tapering and let you know. Would you just try to remove tapering from the Morrison part or also generate new potential flow inputs without the tapering. Of course the latter requires more work because the displacement of the platform changes at that point.
Thanks again,
Francesco

Dear Francesco,
All the issues we've seen so far are with tapered elements are in Morrison.  So I would just remove it from that section.
Do you have any additional damping terms (AddCLin etc) defined?
Andy

Dear Francesco,
It is interesting that the damping level changes in two separate releases (from v2.3 to v2.4 and again from v2.5 to v2.6).  So, there are two changes to track down.
I'd first like to understand if these changes in damping levels are tied to damping from the potential-flow solution or to drag from the strip-theory solution (or perhaps through AddBLin or AddBQuad if you've set those nonzero).  Could you generate separate models with potential-flow only and with strip-theory only to better isolate the issue(s)?
Best regards,

Thank you for the very useful suggestions. First of all, removing the coning makes no difference at all.
I also tried running with strip-theory only and with potential flow only and in both cases I was seeing similar differences between versions (v2.3 different from v2.4 and v2.5 different form v2.6 and v3.0). This got me thinking that perhaps the issue was in the moorings. The mooring system is kind of complex as each catenary chain is split in two and connects to the spar-buoy in two points. Also, the way this model is set there is significant damping in the moorings. To see if this was the issue I switched to MAP++ and ran the different version of OF with Strip theory only and with potential flow only. Below are the results I got:
It seems that the issue is in the MoorDyn module. When using potential flow only and potential flow + strip theory for Cd all of the versions are in agreement. When using Strip theory only v2.6 and v3.0 do not agree with the rest. The model uses Simple coefficients. This is how they are set for the two models:
OF v2.3, v2.4, v2.5:
OF v2.6, v3.0:

Dear Andy and Jason,
Thank you for the very useful suggestions.
There is some additional quadratic drag (AddBQuad) for the pitch and roll DOFs only.
Removing the tapering makes no difference at all.
I also tried running with strip-theory only and with potential flow only and in both cases I was seeing similar differences between versions (v2.3 different from v2.4 and v2.5 different from v2.6 and v3.0). This got me thinking that perhaps the issue was in the moorings. The mooring system is kind of complex as each catenary chain is split in two and connects to the spar-buoy in two points to improve yaw stability. Also, the way this model is set there is significant damping in the moorings. To see if the issue is related to moorings I switched from MoorDyn to MAP++ and ran the different version of OF with Strip theory only, with potential flow only and with potential flow + strip theory for Cd. Below are the results I got:

It seems that the issue is in the MoorDyn module. When using potential flow only and potential flow + strip theory for Cd all of the versions are in agreement. When using Strip theory only v2.6 and v3.0 do not agree with the rest. The model uses Simple coefficients. This is how they are set for the two models:
OF v2.3, v2.4, v2.5:

---------------------- SIMPLE HYDRODYNAMIC COEFFICIENTS (model 1) --------------
SimplCd    SimplCdMG    SimplCa    SimplCaMG    SimplCp    SimplCpMG   SimplAxCa  SimplAxCaMG  SimplAxCp   SimplAxCpMG
(-)         (-)         (-)         (-)         (-)         (-)         (-)         (-)         (-)         (-)
0.5        0.00        0.40        0.00        1.00        1.00         0.0        0.00        1.00        1.00

OF v2.6, v3.0:

---------------------- SIMPLE HYDRODYNAMIC COEFFICIENTS (model 1) --------------
SimplCd    SimplCdMG    SimplCa    SimplCaMG    SimplCp    SimplCpMG   SimplAxCd  SimplAxCdMG  SimplAxCa  SimplAxCaMG  SimplAxCp   SimplAxCpMG
(-)         (-)         (-)         (-)         (-)         (-)         (-)         (-)         (-)         (-)         (-)         (-)
0.5        0.00        0.40        0.00        1.00        1.00         0.00        0.00       0.00        0.00        1.00        1.00

Perhaps I got something wrog here? The rest of the Morison part of the HydroDyn file is the same.
I will also try to understand if there are settings I can change to solve this issue related to MoorDyn. I must not that no errors or warnings are thrown when using MoorDyn. Do you have any suggestions?
Thanks,
Francesco

Dear Francesco,
Regarding your solution with MAP++ in place of MoorDyn, the only real difference I see is in the natural frequency predicted by the strip-theory only model in OpenFAST v2.6 and v3.0.  Can you clarify what type of free-decay test you are simulating (surge or pitch?) and which DOFs are enabled?  One big difference between OpenFAST v2.5 and OpenFAST v2.6 is in how hydrostatics are solved by the strip-theory solution.  In OpenFAST v2.5 and earlier, the strip-theory solution only solved hydrostatics at the undisplaced position of the body, add AddCLin in HydroDyn was used to specify the hydrostatic stiffness matrix.  In OpenFAST v2.6 and newer, the hydrostatics are solved by HydroDyn in the displaced position, so, nonzero AddCLin is no longer needed.  If you specifying hydrostatic stiffness through AddCLin in both models that would be a problem (double counting the hydrostatic stiffness in OpenFAST v2.6 and newer).  This would mainly effect the natural frequencies in roll and pitch.
Regarding changes to MoorDyn between these versions, I'm not sure.  Hopefully @mattEhall can comment on that.
Best regards,

Hi Francesco,
I can't think of a change in MoorDyn that would explain differences in damping between versions, but it's something we can look into more. Considering what you found about differences in strip theory, could you provide a plot that isolates the difference you think must be caused by MoorDyn? And could you share more information about the mooring system setup?

Matt

Dear Francesco,
I agree that if the free-decay results are changing between OF v2.5 and v2.6 for the strip-theory only model, while these versions compare well for a hybrid strip-theory plus potential flow model, then the difference is likely associated with the strip-theory added mass.  This effect can likely be isolated by setting up a strip-theory only model with all hydrodynamics coefficients zeroed except added mass.  Would you mind trying that?  It may also help to perform the surge free-decay test with one DOF (surge only) to fully isolate the effect.
I let @mattEhall comment on the changes associated with MoorDyn.
Best regards,

Hi @frp09,
I would like to find out how you changed the damping ratio off this floating wind turbine system, please. I am looking at a different platform, the VolturnUS-S and my freedecay test results are not the same as shown in the literature.
Also, how did you use Moordyn to carry out the free decay test? I thought this was only possible using MAP. My plot using MAP is not smooth, so peaks are not well defined; do you know how to fix it?
I have shown the surge free decay test plot below; x-axis is time (s) and y-axis is the surge (m).
Thank you.

AOAW

Dear @andreowhite,
I'll just say that you can use MoorDyn or MAP++ for any simulations (including of free-decay response).
Best regards,

Hi @andreowhite,
To tune your damping ratio you can add linear damping through the optional additional damping matrix in HydroDyn. You can also add quadratic damping through the corresponding quadratic damping matrix or by using strip theory (Morrison equation) and tuning the drag coefficients. It's a lot of trial and error until you get the coefficients where you want them to be. As for your timeseries, it looks like you have a high frequency oscillation in addition to the low frequancy one. My best guess would be surge-pitch coupling. Maybe check the initial conditions of the free decay test, does the system have an initial pitch offset?
Best,
Francesco

Thanks @frp09. I have done the freedecay  tests using MoorDyn and they all seems to agree well with values shown in literature, except one. The pitch/roll plot has practically the same frequency but they are not in good agreement. The roll actually is in good agreement with literature but the pitch is off. See plot below. Any ideas how I could fix this. I note what you said about amending damping ratio but I have never done it before and I am not too sure how to do it.

By the way pitch/roll (deg) is on the y-axis and time (s) is on the x-axis.
Thank you.
Regards,
AOAW


Reacting to Routing repo's EndpointFinder changes

Need unit tests for the conventional route order and name metadata in MvcEndpointDataSourceTests.


Improve the perf of functional tests running with real jupyter

For #7997
Rework the caching algorithm for interpreters (so it doesn't run the fetch at all if the cached value is there) and make a custom cache for tests.
This improves the run time for flakey tests from 3:30 hours to 1 hour on windows. Linux and Mac are similar.

Codecov Report

Merging #10242 into master will decrease coverage by 0.02%.
The diff coverage is 58.82%.

@@            Coverage Diff             @@
##           master   #10242      +/-   ##
==========================================
- Coverage   61.23%    61.2%   -0.03%
==========================================
  Files         567      567
  Lines       30862    30871       +9
  Branches     4432     4435       +3
==========================================
- Hits        18897    18896       -1
- Misses      10982    10989       +7
- Partials      983      986       +3

Impacted Files
Coverage Δ

...reter/locators/services/cacheableLocatorService.ts
82.41% <58.82%> (-2.81%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0%> (-0.73%)
:arrow_down:

.../datascience/interactive-common/interactiveBase.ts
16.64% <0%> (-0.11%)
:arrow_down:

...ience/interactive-common/interactiveWindowTypes.ts
100% <0%> (ø)
:arrow_up:

src/client/common/utils/platform.ts
70.58% <0%> (ø)
:arrow_up:

src/client/common/utils/localize.ts
95.28% <0%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f9fd5...fafb47a. Read the comment docs.

@DonJayamanne and @IanMatthewHuff can you guys take another look? Thanks


chore(deps): update common-dev-assets digest to c48f4b1

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
fdbe89a -> c48f4b1

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 2.0.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add strict versioning for compiler components and checks

Need to ensure versioning across compiler, flat buffer and rt all match. Strict versioning checking.

Compiler will have it's versioning via TTMLIR_VERSION_MAJOR, TTMLIR_VERSION_MINOR and TTMLIR_VERSION_RELEASE
flat buffer has its own built in versioning

major: uint16;
minor: uint16;
release: uint32;

need to do a strict if and only if check to ensure all these versioning match

to do:
version of compiler + flatbuffer + runtime should all match
compiler will embed the v<> into the flatbuffer
ttrt will check version and ensure compatibility
references
include/ttmlir/Version.h
include/ttmlir/Target/Common/version.fbs
flatbuffer root_type

merged: c4f6752ad6c308e5f2d2798205939756986ae8f8


Not able to compile thorvg without thread support

I'm trying to create a version of Godot 4.x that would compile without thread support.
This is to make the editor and to export games on a non-COOP/COEP web environment. Due to Meltdown and Spectre, the web platform requires COOP and COEP in order to have access to SharedArrayBuffer, which is required by Emscripten to compile and use threads.
Unfortunately, I can compile thorvg without USE_PTHREADS=1, but it will inevitably crash when trying to instantiate tvg::TaskScheduler, even if we could set tvg::TaskScheduler::async(false) afterwards.

Ideally, it should be possible to compile thorvg in a way to forgo the use of threads.

@adamscott Hello, basically ThorVG supports intrinsic threading, and you can easily toggle this feature with a single API call. You can set the desired thread number(0) in the initializer. Probably, you can find the call this in Godot(modules/svg/register_type.cpp:45)
tvg::Initializer::init(tvg::CanvasEngine::Sw, 1); -> tvg::Initializer::init(tvg::CanvasEngine::Sw, 0);

That's all you need to do.


[DO-NOT-MERGE] Test 2.3

Test CI stability for branch-2.3

Interesting. This PR https://github.com/apache/hive/pull/4892 was the latest commit in branch-2.3 (well except the "Prepare for 2.3.10 release" I created), and it only has 27 test failures.

I suspect it may be caused by changes outside of the Hive code itself ...

OK, let me merge the other PR first, and see how the post commit CI performs.


Update to latest mongo db

Update to support latest MongoDB      = v3.6.0
Update NetStandard.Library to latest   = v2.0.1
Update MongoDB.Driver to latest         = v2.5.0

@MarLoe,
I build on top of your commit (016faae), should I base off 0.5.8 instead?


[ACR] Add new command to check if specific blob is available to pull from registry

Description

Add new command to check if a specific blob is available to pull from repository using command az acr check-health --name myRegistry --repository myRepository --image sha256@abc123

Testing Guide

Verifies if a specific blob identified by image 'sha256:abc123' is available to pull from the repository: az acr check-health -n MyRegistry -r MyRepository --image sha256:abc123
Verifies if a specific blob identified by tag 'latest' is available to pull from the repository: az acr check-health -n MyRegistry -r MyRepository -t latest

History Notes
[ACR] az acr check-health --name --repository --image: Add new command to check if specific blob is available to pull from registry

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

ACR

Please address this CI issues

@SakoPak Please note that we are launching the release for this sprint this week. Please resolve all comments and conflicts by Tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 12-05)

@SakoPak Please note that we are launching the release for this sprint this week. Please resolve all comments and conflicts by Tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 12-05)

This PR can wait until next sprint as it's still in progress, thank you for the heads up.

@SakoPak Could you please resolve these CI issues?


Not loading cached vuetify material icons when offline

[x ] I have read the troubleshooting section before opening an issue.
[x ] I have tried upgrading iles and vite.

Description 📖
Vuetify material icons load correctly when online. When offline, the material icons aren't displaying despite being correctly cached.
Reproduction 🐞
https://www.penpublic.com/
</details>

### Logs 📜

_If not providing a reproduction:_

<details>
<summary>Output</summary>

_Run `DEBUG=iles:* npm run dev` or `DEBUG=iles:* npm run build` and provide the output:_

</details>

### Screenshots 📷

_Provide console or browser screenshots of the problem_.

Are you able to share your repo? Hard to debug without code. I'm guessing you are referring to pwa?

I can share a few modules but rather not disclose the entire app if that's
ok . Here are some screenshots of offline pwa vs online. Thanks
Kevin
---------- Forwarded message ---------
From: Akayy @.>
Date: Thu, Sep 5, 2024, 3:39 AM
Subject: Re: [ElMassimo/iles] Not loading cached vuetify material icons
when offline (Issue #278)
To: ElMassimo/iles @.>
Cc: kfung21 @.>, Author @.>
Are you able to share your repo? Hard to debug without code. I'm guessing
you are referring to pwa?
—
Reply to this email directly, view it on GitHub
https://github.com/ElMassimo/iles/issues/278#issuecomment-2331190797, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFRTLLI4UIA3DSKAKLGIG7TZVAYHJAVCNFSM6AAAAABNVYGG7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZRGE4TANZZG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

I can share a few modules but rather not disclose the entire app if that's ok .

You are encouraged to provide as little code as possible, as long as it is self-contained and the bug can be reproduced. i.e. You can provide a Minimal, Reproducible Example

how do you recommend sharing reproducible code since it needs to be
deployed in production in order to replicate?
Attached are my vite config, vuetify js, and index.html files. Let me know
if you need anything else. Thanks
On Thu, 5 Sept 2024 at 06:49, Yufan You @.***> wrote:

I can share a few modules but rather not disclose the entire app if that's
ok .
You are encouraged to provide as little code as possible, as long as it is
self-contained and the bug can be reproduced. i.e. You can provide a Minimal,
Reproducible Example
https://stackoverflow.com/help/minimal-reproducible-example
—
Reply to this email directly, view it on GitHub
https://github.com/ElMassimo/iles/issues/278#issuecomment-2331734664,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFRTLLJEAAHRYT5JR76HOC3ZVBOM3AVCNFSM6AAAAABNVYGG7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZRG4ZTINRWGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

// Plugins
import AutoImport from 'unplugin-auto-import/vite'
import Components from 'unplugin-vue-components/vite'
import Fonts from 'unplugin-fonts/vite'
import Vue from @.***/plugin-vue'
import Vuetify, { transformAssetUrls } from 'vite-plugin-vuetify'
import { VitePWA } from 'vite-plugin-pwa'
// Utilities
import { defineConfig } from 'vite'
import { fileURLToPath, URL } from 'node:url'
// https://vitejs.dev/config/
export default defineConfig({
plugins: [
Vue({
template: { transformAssetUrls }
}),
// https://github.com/vuetifyjs/vuetify-loader/tree/master/packages/vite-plugin#readme
Vuetify({
autoImport: true,
styles: {
configFile: 'src/styles/settings.scss',
},
}),
Components(),
Fonts({
google: {
families: [{
name: 'Roboto',
styles: @.;300;400;500;700;900',
}],
},
}),
AutoImport({
imports: [
'vue',
'vue-router',
],
eslintrc: {
enabled: true,
},
vueTemplate: true,
}),
VitePWA({
registerType: 'autoUpdate',
injectRegister: 'auto',
includeAssets: [
'favicon.ico',
'apple-touch-icon.png',
'masked-icon.svg',
],
manifest: {
name: 'PenPublic',
short_name: 'PenPublic',
description: 'Public Sector Jobs with a Pension',
theme_color: '#ffffff',
icons: [
{
src: 'android-chrome-192x192.png',
sizes: '192x192',
type: 'image/png'
},
{
src: 'android-chrome-512x512.png',
sizes: '512x512',
type: 'image/png'
},
{
src: 'android-chrome-maskable-192x192.png',
sizes: '192x192',
type: 'image/png',
purpose: 'maskable'
},
{
src: 'android-chrome-maskable-512x512.png',
sizes: '512x512',
type: 'image/png',
purpose: 'maskable'
},
{
src: '/img/icons/apple-touch-icon.png',
sizes: '180x180',
type: 'image/png'
},
{
src: '/img/icons/favicon-16x16.png',
sizes: '16x16',
type: 'image/png'
},
{
src: '/img/icons/favicon-32x32.png',
sizes: '32x32',
type: 'image/png'
},
{
src: '/favicon.ico',
sizes: '64x64 32x32 24x24 16x16',
type: 'image/x-icon'
}
],
start_url: '/',
display: 'standalone',
background_color: '#ffffff'
},
workbox: {
globPatterns: ['/.{js,css,html,ico,png,svg,woff2,woff,ttf,eot,otf}'],
runtimeCaching: [
{
// Caching locally served Material Design Icons
urlPattern: /^/assets/materialdesignicons-webfont/.*$/,
handler: 'CacheFirst',
options: {
cacheName: 'mdi-font-cache',
expiration: {
maxEntries: 10,
maxAgeSeconds: 60 * 60 * 24 * 365, // 1 year
},
},
},
{
// Caching all other local fonts and icons
urlPattern: /.(?:woff2|woff|ttf|eot|otf)$/,
handler: 'CacheFirst',
options: {
cacheName: 'fonts-cache',
expiration: {
maxEntries: 10,
maxAgeSeconds: 60 * 60 * 24 * 365,
},
},
},
],
},
}),
],
define: { 'process.env': {} },
resolve: {
alias: {
'@': fileURLToPath(new URL('./src', import.meta.url))
},
extensions: [
'.js',
'.json',
'.jsx',
'.mjs',
'.ts',
'.tsx',
'.vue',
],
},
server: {
port: 3000,
},
})
/**

plugins/vuetify.js

Framework documentation: https://vuetifyjs.com`
*/

// Styles
import @.***/font/css/materialdesignicons.css' // Ensure you are using css-loader
// import '../css/material-design-icons-iconfont/dist/material-design-icons.css' // Ensure you are using css-loader
import 'vuetify/styles'
// Composables
import { createVuetify } from 'vuetify'
import { aliases, mdi } from 'vuetify/iconsets/mdi'
// https://vuetifyjs.com/en/introduction/why-vuetify/#feature-guides
export default createVuetify({
theme: {
defaultTheme: 'dark',
},
icons: {
defaultSet: 'mdi',
aliases,
sets: {
mdi,
},
}
})

Thanks for sharing. Next time, when sharing code, please select your code block & wrapping it within a pair of triple tilde's (new lines before and after your code block like below image), this helps with code highlight & make it's scrollable when you submit your comment.

I notice that yours is a Vite based project, as you have shared a vite config, and not an Iles one? I don't see any Iles specific code in what you have shared, can you please confirm if it's an Iles project?
Even if it's still an Iles project and somehow vite config is getting used instead of iles config file, there is a better chance to get any help on this if you raise this issue in the vite-plugin-pwa repo, as this is a pwa related query with you're able to share only certain configs here.

My apologies. Yes this is a vite-pwa issue. I'm not sure how I was routed
to Iles unless it's the same owner. I'll repost accordingly thanks
On Fri, Sep 6, 2024, 1:33 AM Akayy @.***> wrote:

Thanks for sharing. Next time, when sharing code, please select your code
block & wrap it within a pair of triple tilde's (new lines before and after
your code block like below image), this helps with code highlight & make
it's scrollable when you submit your comment.
image.png (view on web)
https://github.com/user-attachments/assets/6ae0976c-04d3-48c2-a053-0e0262309c8a
I notice that yours is a Vite based project, as you have shared a vite
config, and not an Iles one? I don't see any Iles specific code in what
you have shared, can you please confirm if it's an Iles project?
Even if it's still an Iles project and somehow vite config is getting
used instead of iles config file, there is a better chance to get any help
on this if you raise this issue in the vite-plugin-pwa
https://github.com/vite-pwa/vite-plugin-pwa repo, as this is a pwa
related query with you're able to share only certain configs here.
—
Reply to this email directly, view it on GitHub
https://github.com/ElMassimo/iles/issues/278#issuecomment-2333533436,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFRTLLPOATCTJN6NBGLGCMTZVFSGJAVCNFSM6AAAAABNVYGG7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZTGUZTGNBTGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

if you're using íles + pwa check https://iles-docs.netlify.app/guide/pwa

@kfung21, no worries. By the way, I would recommend dropping materialdesignicons.css and instead use css-icon with unocss. You might end up using say 10 icons, but the who css will be included in your built bundle, and it's not treeshaken.
Here is a very simple vue-vuetify template that does it - https://github.com/pinegrow/pg-vue-vuetify. It uses a small hack to use unocss icons for vuetify components as well - https://github.com/Pinegrow/pg-vue-vuetify/blob/main/vuetify.config.ts#L101. Unocss nicely treeshakes unused icons.
You will be surprised to find how much weight you shed in your final bundle ;-)


fix: Add error message for protected branch

Description

When a git push is failed due to reasons other than upstream changes like a protected branch, the application displays there are upstream changes which is not correct. This PR adds a error message when the git push operation fails due to the protected branch rule.

Add a TL;DR when description is extra long (helps content team)

Fixes #15347
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=f7042ff

/ok-to-test sha=60241f6

/perf-test sha=60241f6


GitHub api wait limit

Due to the number of Github API calls in this resource, you can end up reaching the hourly API limit (5000) fairly quickly if you have many pipelines configured with the same Github user.
In an attempt to help address this, we're adding two source parameters:

api_wait_limit:  (s) Max time to wait for API ratelimit to reset. The github api resets the limit every hour, so a simple retry after x seconds isn't enough - if we've reached the limit, we need to either wait it out or give up. api_wait_limit determines how long we're willing to wait before giving up.
api_wait_buffer: Min number of available API retries before waiting. If there are more available requests than this number, we'll proceed, otherwise we'll attempt to wait it out.

Yeah, looking at this rather old post and associated PRs, it seems like it's the best route but requires a lot more complexity and dealing with middleware, as you're then doing caching. Potentially worth exploring as this PR is more of a bandaid than a solution.


[bug] Flickering with raw display handle + winit + wgpu + tauri v2 + transparency

Describe the bug
When running the following tauri app: https://github.com/FabianLars/tauri-v2-wgpu the webview and wgpu context "fight" for the surface resulting in flickering.
https://github.com/tauri-apps/tauri/assets/21245806/02f2553e-01c1-4f72-8927-bc8653449289
Reproduction
Clone https://github.com/FabianLars/tauri-v2-wgpu.
Add the following flake.nix file
flake.nix.txt
Run nix develop
Run pnpm install
Run pnpm tauri dev
Expected behavior
The webview content should be overlaid on top of the wgpu surface.
Full tauri info output
[✔] Environment
    - OS: NixOS 23.11.0 X64
    ✔ webkit2gtk-4.1: 2.42.5
    ✔ rsvg2: 2.57.1
    ✔ rustc: 1.79.0-nightly (3c85e5624 2024-03-18)
    ✔ cargo: 1.79.0-nightly (2fe739fcf 2024-03-15)
    ✔ rustup: 1.26.0 (1980-01-01)
    ✔ Rust toolchain: stable-x86_64-unknown-linux-gnu (default)
    - node: 20.11.1
    - pnpm: 8.15.3
    - npm: 10.2.4
    - bun: 1.0.25

[-] Packages
    - tauri [RUST]: git+https://github.com/tauri-apps/tauri?branch=feat/window-displayhandle#26558f77a8bab39cf320160a1f135f9bae6194d5 (2.0.0-beta.12)
    - tauri-build [RUST]: no manifest (2.0.0-beta.10, 2.0.0-beta.10)
    - wry [RUST]: 0.37.0
    - tao [RUST]: 0.26.1
    - @tauri-apps/api [NPM]: 2.0.0-beta.2
    - @tauri-apps/cli [NPM]: 2.0.0-beta.9

[-] App
    - build-type: build
    - CSP: unset
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - bundler: Vite

Stack trace
No response
Additional context
Display manager: Hyprland
CPU: Ryzen 7 7840U Raedon 78M Graphics
Driver: mesa  23.1.9
I did have to disable DMABUF for webkit to get any render output

This is kinda expected because we are using GTK to create the window (which is basically an X11 window) and so it has its own drawing loop, when you add wgpu on top of it, they both fight on the same x11 surface hence the flickering, we can't really do anything to fix this as we need to use GTK for webviews.

@amrbashir Any idea why it doesn't seem to be a problem when using wry directly instead of tauri?
I basically copy pasted wry's wgpu example into the tauri app.

The WGPU example in wry is using winit along with the webview added as a child X11 window and the webview is rendered on the child surface, which is not the same as your example, which under the hood uses a GTK window and the webview is added as a widget to it so it is rendered on the window surface.

right lol, forgot that we're using winit there sry🏃

Any idea why transparency is not working for me when using the wry example? Or should I make a separate issue for that? @amrbashir

This is kinda expected because we are using GTK to create the window (which is basically an X11 window) and so it has its own drawing loop, when you add wgpu on top of it, they both fight on the same x11 surface hence the flickering, we can't really do anything to fix this as we need to use GTK for webviews.

That's very unfortunate, since this is a necessary feature for Graphite to adopt Tauri. Can you please bring this up with the team to brainstorm solutions/workarounds that could be employed in the Linux version? Having those listed here would at least allow community contributors to open a PR to fix this. And even if there's a technological impediment, shouldn't this issue remain open to track the defect so it can, at least someday, be solved? Thank you.

Ah, I think that might just be https://github.com/tauri-apps/wry/issues/1139

That's very unfortunate, since this is a necessary feature for Graphite to adopt Tauri. Can you please bring this up with the team to brainstorm solutions/workarounds that could be employed in the Linux version? Having those listed here would at least allow community contributors to open a PR to fix this.

Unfortunately, that is not in our hands to fix, we are limited to using Webkit2GTK on Linux and that requires a GTK window. While possible to add a GTK widget as a child X11 window inside raw X11 window, this is however a bit hacky and it is not possible on Wayland at all and so we can't use this method in Tauri.
How can Tauri still achieve multiple child webviews? We use a GTK window with a gtk::Fixed widget that allows to position multiple widgets at arbitrary positions, see this example in WRY https://github.com/tauri-apps/wry/blob/dev/examples/gtk_multiwebview.rs
Can you draw OpenGL into GTK? yes you can combine gtk::Fixed a gtk::GlArea widget and then add the webview widgets on top of it. The only problem here is that you will do the drawing yourself because popular rust crates doesn't support GTK at all and probably has no plans to.


geomeTRIC release v1.0

Hello there,
I released version 1.0 of geomeTRIC 2 days ago.  The software hadn't had a release in more than 2 years, despite a fair bit of development over that time period.  There are some new features such as transition state optimization.  It would be good if you could confirm this new version doesn't cause errors in PySCF, and/or I could help to resolve any issues that arise.  You can also modify your user interface to take advantage of the new features.
Thanks,

Lee-Ping

@fishjojo could you try this out?

It works well.


[TASK] Add README to the prequisite folder

Is your improvement request related to a feature? Please describe (👍 if you like this request)
We can add a readme to prerequisites to have one/two liner explanation for each to make it clear for user why they need all.

@roger-ryao Would you like to contribute the document?


Update README.md

Added my name and made the names on under the T list appear in an order .please review the changes.
@sanjay-kv @HimangshuSharma01 review and merge

@HimangshuSharma01 please don't add such High labels for such PRs. Remove levels, the changes are one liner.

Hey I was asked to do so by Sanjay sir

@HimangshuSharma01 please don't add such High labels for such PRs. Remove levels, the changes are one liner.

Okay I'm doing it for everyone just give me some time


Feature request: Rolling ols takes a time window when the by column is a datetime

It would be convenient if, when x is a datetime datatype that rolling_ols can take a time window such as 1m, instead of a. number of points.

Hi @Ge0rges
does this pattern work for you
https://github.com/azmyrajab/polars_ols/issues/23
That would fallback to polars rolling syntax which is the most flexible option and it would run the regressions in parallel over windows, it should still be fast

Yes it is less elegant to break lazy chaining of an expression I suppose. Sorry I haven’t tested what I’m saying now, but could you try something like:
pls.ols(y, x, …).rolling(index_column=“my_date”, period=“30m”).overy(my_group)
if that works, that should do exactly what you want it to


flit.toml config files?

I quite like toml, and I'm considering switching flit to use it for config files. It's a bit more verbose than ini, because string values have to be quoted, but there's a detailed specification, and it's quite a bit more flexible. We'd gain the ability to have lists (rather than just multiline strings), dates and arbitrarily nested dictionaries, rather than the strict two-level hierarchy we have with ini.
If I did this, I would still support ini files for backwards compatibility for quite some time. It would look for flit.toml first, and fall back to flit.ini if that wasn't found. When supplying the filename explicitly, it would try to parse it as toml if the extension was .toml, and as ini otherwise.

+1 for toml.

+1

The plan for this is that, once PEP 517 is accepted, the metadata for flit will be stored in pyproject.toml, so that it doesn't need two separate packaging info files.

Should this issue be closed now that PEP 517 is accepted?

Yup, this is now decided, even if the implementation isn't merged yet. Thanks for the reminder.


Remove version: Mega.MEGASync version <IP_ADDRESS>

outdated version (old installers not available on official site)
Microsoft Reviewers: Open in CodeFlow

Hi @fancybody,
This manifest adds Apps and Features entries that aren't present in previous PR versions. Should these entries also be added to the previous versions?
(Automated response - build 552.)


trim string before compare it

What does this PR change?
When reading from file, we need to trim the string before we can compare it.
This will fix the IPv6 enabled detection
Test coverage

No tests: already covered

[x] DONE

Links
Issue(s): #

[ ] DONE

Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:

[ ] No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)
Before you merge
Check How to branch and merge properly!

bug number is 1224080, not 1224081

yes, just fixed it

We agreed on not merging this until RC submissions are ready, otherwise releng will need to re-tag them again.

@srbarrios it's making my debugging a nightmare... :crying_cat_face:


feat: The Ahlswede-Zhang identity

The Ahlswede-Zhang identity is a sharpening of the Lubell-Yamamoto-Meshalkin inequality, by expliciting the correction term.
This PR defines Finset.truncatedSup/Finset.truncatedInf, whose cardinalities show up in the correction term, and subsequently proves the Ahlswede-Zhang identity itself.
Co-authored-by: Vladimir Ivanov<EMAIL_ADDRESS>

This is a rehash of https://github.com/leanprover-community/mathlib/pull/18612 and https://github.com/leanprover-community/mathlib/pull/18618.

bors merge

Please merge master and fix compile
bors r-
bors d+

bors merge


Call to undefined method Sofa\Eloquence\Query\Builder::getQualifiedForeignKeyName()

When I try searching related models I get this error. Can someone suggest a fix for this?

Please refer #12 for solution


Pods "xy" is forbidden: unable to validate against any pod security policy: [];

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

create new pod security policy (psp) in Rancher under Security > Pod Security Policy with the same privileges as unrestricted policy (default, created by rancher)
assign pod security policy to project
delete pod and see if pod is running with applied psp

Result:
Error message: Pods "xy" is forbidden: unable to validate against any pod security policy: []; Deployment does not have minimum availability.
Other details that may be helpful:
Created pod security policy:
apiVersion: extensions/v1beta1
kind: PodSecurityPolicy
metadata:
annotations:
serviceaccount.cluster.cattle.io/pod-security: policy-demo
serviceaccount.cluster.cattle.io/pod-security-version: "258848977"
creationTimestamp: 2019-09-24T13:55:41Z
labels:
cattle.io/creator: norman
name: policy-demo-psp
resourceVersion: "258848978"
selfLink: /apis/extensions/v1beta1/podsecuritypolicies/policy-demo-psp
uid: ff51a0ae-ded2-11e9-a0b9-0050568d10c6
spec:
allowPrivilegeEscalation: true
allowedCapabilities:

'*'
defaultAllowPrivilegeEscalation: false
fsGroup:
rule: RunAsAny
hostIPC: true
hostNetwork: true
hostPID: true
hostPorts:
max: 65535
min: 0
privileged: true
runAsUser:
rule: RunAsAny
seLinux:
rule: RunAsAny
supplementalGroups:
rule: RunAsAny
volumes:
'*'

Comparing yaml output of the created policy against the unrestricted policy (default, created by rancher) shows one difference: defaultAllowPrivilegeEscalation: false is not shown in the unrestricted policy (default, created by rancher)
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): Rancher: v2.2.8 / User Interface: v2.2.94 / Helm: v2.10.0-rancher11 / Machine: v015.0-rancher8-1
Installation option (single install/HA):
HA

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Custom
Machine type (cloud/VM/metal) and specifications (CPU/memory): VM
Kubernetes version (use kubectl version): v1.14.6
Docker version (use docker version): 19.3.1

I ran into an simular situation. I used RKE to create my Kubernetes Cluster. Now I added pod_security_policy: true to my cluster.yml. Now I am unable to deploy workloads, I have the same error message

Have you managed to handle this? I have same problem too.

Same problem here

This answer will help some like myself who don't want to always be buried in the command line. In my case, I used RKE to bring the cluster up, but I wanted the rancher dashboard for other things.
When a cluster is imported, rancher cannot do much with it. However you can make it editable by adding in your RKE config to the imported cluster.

Start by heading over to the Rancher UI API ex: https://$YourRancher/v3/clusters/local
Grab the RKE config, dump that into a json converter - https://www.convertjson.com/yaml-to-json.htm
Click edit and look for this value - rancherKubernetesEngineConfig - Your RKE config that you just converted to JSON goes here. Click "Show Request" and then Click "Send Request"
Go to the Cluster and click the : edit button and now you can edit your RKE deployed cluster from the UI (which helps in step 6)
Enable the pod security policy and select your desired default.  (mine is restricted)
Click on Projects/ Namespaces and then edit next to the system project. Make sure the Pod Security Policy is None (or whatever you wanted for the system project).

Reason for all of this is because Rancher does not know about the pod_security_policy value until you tell it that it should be enabled. This fixed my cluster - hopefully it will help someone else.

This answer will help some like myself who don't want to always be buried in the command line. In my case, I used RKE to bring the cluster up, but I wanted the rancher dashboard for other things.
When a cluster is imported, rancher cannot do much with it. However you can make it editable by adding in your RKE config to the imported cluster.
1. Start by heading over to the Rancher UI API ex: https://$YourRancher/v3/clusters/local

2. Take the RKE config used to provision the cluster and dump that into a json converter - https://www.convertjson.com/yaml-to-json.htm

3. Click edit and look for this value - rancherKubernetesEngineConfig - Your RKE config that you just converted to JSON goes here. Click "Show Request" and then Click "Send Request"

4. Back in the UI, go to Cluster and click the : edit button and now you can edit your RKE deployed cluster from the UI (which helps in step 6)

5. Enable the pod security policy and select your desired default.  (mine is restricted)

6. Click on Projects/ Namespaces and then edit next to the system project. Make sure the Pod Security Policy is Unrestricted (or whatever you wanted for the system project).

Reason for all of this is because Rancher does not know about the pod_security_policy value until you tell it that it should be enabled. This fixed my cluster - hopefully it will help someone else.

Running into similar issue with our local Rancher cluster. We had to add RBAC and restart any workloads for monitoring and such in order for them to start. This is cumbersome and I'm wondering I'm doing something wrong here... I suppose I could apply all these as part of user-addons but I am expecting these policies to be there with a fresh installation.
First had to create my own unrestricted-psp
apiVersion: policy/v1beta1
kind: PodSecurityPolicy
metadata:
  name: unrestricted-psp
spec:
  allowPrivilegeEscalation: true
  allowedCapabilities:
  - '*'
  fsGroup:
    rule: RunAsAny
  hostIPC: true
  hostNetwork: true
  hostPID: true
  hostPorts:
  - max: 65535
    min: 0
  privileged: true
  runAsUser:
    rule: RunAsAny
  seLinux:
    rule: RunAsAny
  supplementalGroups:
    rule: RunAsAny
  volumes:
  - '*'

Then create a Cluster Role that uses this new PSP
```yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: unrestricted-clusterrole
rules:
- apiGroups:
  - extensions
  resourceNames:
  - unrestricted-psp
  resources:
  - podsecuritypolicies
  verbs:
  - use

Then in each namespace in System project that has issues with workloads I create a RoleBinding for all service accounts in that namespace
---
apiVersion: v1
kind: Namespace
metadata:
  name: rancher-operator-system
---
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
  name: rancher-operator-system-unrestricted
  namespace: rancher-operator-system
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: unrestricted-clusterrole
subjects:
- apiGroup: rbac.authorization.k8s.io
  kind: Group
  name: system:serviceaccounts

@donnydavis, this solved my problem and I'm very thankful for you sharing this as it saved me a lot of time. Perhaps the installation documentation for Rancher needs to be updated to cover this. I created my cluster with RKE and then used Helm to install Rancher with pod_security_policy: true. Going through the steps you listed did the trick.


KeyError: 'ner_crf' in evaluate.py during crossvalidation

Hello,
Operating system (windows, osx, ...): windows 10
Content of model configuration file:
language: "en"

pipeline:
- name: "tokenizer_whitespace"
- name: "ner_crf"
- name: "intent_featurizer_count_vectors"
- name: "intent_classifier_tensorflow_embedding"
intent_tokenization_flag: true
intent_split_symbol: "_"

Issue:
I am trying to evaluate model by running command:
python -m rasa_nlu.evaluate --data data/nlu_data.json --config nlu_config.yml --mode crossvalidation --folds 5

However, I got issue:
Traceback (most recent call last):
 File "C:\ProgramData\Anaconda3\lib\runpy.py", line 193, in _run_module_as_main
 "__main__", mod_spec)
 File "C:\ProgramData\Anaconda3\lib\runpy.py", line 85, in _run_code
 exec(code, run_globals)
 File "C:\ProgramData\Anaconda3\lib\site-packages\rasa_nlu\evaluate.py", line 857,
in <module>
 main()
 File "C:\ProgramData\Anaconda3\lib\site-packages\rasa_nlu\evaluate.py", line 834,
in main
 data, int(cmdline_args.folds), nlu_config)
 File "C:\ProgramData\Anaconda3\lib\site-packages\rasa_nlu\evaluate.py", line 720,
in run_cv_evaluation
 interpreter, train)
 File "C:\ProgramData\Anaconda3\lib\site-packages\rasa_nlu\evaluate.py", line 684,
in combine_entity_result
 current_result = compute_entity_metrics(interpreter, data)
 File "C:\ProgramData\Anaconda3\lib\site-packages\rasa_nlu\evaluate.py", line 777,
in compute_entity_metrics
 merged_predictions = merge_labels(aligned_predictions, extractor)
 File "C:\ProgramData\Anaconda3\lib\site-packages\rasa_nlu\evaluate.py", line 307,
in merge_labels
 for ap in aligned_predictions]
 File "C:\ProgramData\Anaconda3\lib\site-packages\rasa_nlu\evaluate.py", line 307,
in <listcomp>
 for ap in aligned_predictions]
KeyError: 'ner_crf'

Which rasa_nlu version are you using?
did you install sklearn-crfsuite?

I got the exact same issue. It happens with (out of the box) tensorflow embedding pipeline and crossvalidation.
packages :

rasa-nlu : 0.13.8
scikit-learn : 0.19.0
sklearn-crfsuite : 0.3.6

Used packages:

rasa_nlu 0.13.8
sklearn_crfsuite 0.3.6

@amaurymercier Are you also running Windows or a different OS?
Could you please try to open your python console and do import sklearn_crfsuite. Do you get any error there?

I'm on Ubuntu 18.04 with python 3.6.
import sklearn_crfsuite works fine :)

And what was the command you used to install rasa nlu? pip install rasa_nlu or something like pip install rasa_nlu[spacy]?

only pip install rasa_nlu if I remember well, but I did install spacy & spacy models afterwards.

Mhm, I cannot reproduce this on my machine. Can you please run it with the debug flag and post the output here? python -m rasa_nlu.evaluate --data data/nlu.json --config nlu_config.yml --mode crossvalidation --folds 1 --debug (folds == 1 should be enough I guess)

I put --folds 2 as it was mandatory.
I got more meaningful error messages :
/home/amaury/.virtualenvs/pychat/lib/python3.6/site-packages/sklearn/metrics/classification.py:1137: UndefinedMetricWarning: Recall and F-score are ill-defined and being set to 0.0 in labels with no true samples.   'recall', 'true', average, warn_for) /home/amaury/.virtualenvs/pychat/lib/python3.6/site-packages/sklearn/metrics/classification.py:1137: UndefinedMetricWarning: F-score is ill-defined and being set to 0.0 in labels with no true samples.   'recall', 'true', average, warn_for) 2019-01-03 12:10:42 DEBUG    rasa_nlu.extractors.crf_entity_extractor  - Inconsistent BILOU tagging found, B- tag, L- tag pair encloses multiple entity classes.i.e. [B-a, I-b, L-a] instead of [B-a, I-a, L-a]. Assuming B- class is correct. Traceback (most recent call last):   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main     "__main__", mod_spec)   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code     exec(code, run_globals)   File "/home/amaury/.virtualenvs/pychat/lib/python3.6/site-packages/rasa_nlu/evaluate.py", line 857, in <module>     main()   File "/home/amaury/.virtualenvs/pychat/lib/python3.6/site-packages/rasa_nlu/evaluate.py", line 834, in main     data, int(cmdline_args.folds), nlu_config)   File "/home/amaury/.virtualenvs/pychat/lib/python3.6/site-packages/rasa_nlu/evaluate.py", line 720, in run_cv_evaluation     interpreter, train)   File "/home/amaury/.virtualenvs/pychat/lib/python3.6/site-packages/rasa_nlu/evaluate.py", line 684, in combine_entity_result     current_result = compute_entity_metrics(interpreter, data)   File "/home/amaury/.virtualenvs/pychat/lib/python3.6/site-packages/rasa_nlu/evaluate.py", line 777, in compute_entity_metrics     merged_predictions = merge_labels(aligned_predictions, extractor)   File "/home/amaury/.virtualenvs/pychat/lib/python3.6/site-packages/rasa_nlu/evaluate.py", line 307, in merge_labels     for ap in aligned_predictions]   File "/home/amaury/.virtualenvs/pychat/lib/python3.6/site-packages/rasa_nlu/evaluate.py", line 307, in <listcomp>     for ap in aligned_predictions] KeyError: 'ner_crf'

Thanks. How much training examples do you have per intent and how much of them have annotations? Can you maybe share some (minimal) nlu training data?

I think I got it.
The error happens when there is an utterance without any letters (only spaces and punctuation, for instance : i had the utterance "? ??"). When I removed it, it went fine.

Resolved in PR#1689


Fix: Fix broken indexing – only first two text chunks are indexed

Description
Awesome library, but it it has a pretty serious bug:
docsearch.from_texts(...) doesn't actually add anything to the vectorstore, it only returns a new vectorstore. This means that currently, only the first two text chunks have their indices saved.
Changing to .add_texts() fixes this. No need to pass the OpenAIEmbeddings as it is saved in the instance.

Thanks. It is merged and should be available in 1.5.1


ci: run docs and bsim tests GH actions also on files deletion

Use correct output for the changed-files action so that docs and bsim tests jobs also run when deleted files are detected, not just added/copied/modified/renamed.
See https://github.com/tj-actions/changed-files?tab=readme-ov-file#output_any_changed vs. https://github.com/tj-actions/changed-files?tab=readme-ov-file#output_any_modified
Spotted this when https://github.com/zephyrproject-rtos/zephyr/pull/77522 did not trigger a doc build when it should have
Also bump to latest version of the action (BTW @stephanosio @ceolin @nashif, can/should we switch to using pinned GH Actions SHAs in all our workflows? happy to send a PR)

can/should we switch to using pinned GH Actions SHAs in all our workflows

While this would help, in theory, prevent supply chain attacks, it also comes with extra maintenance burden and potential for missed security updates.
For example, if we have an action referenced by @v1, it would automatically pull any future v1-compatible updates including the security patches; whereas, if we specify explicit SHA, we have to keep track of every minor individual action updates (there are MANY) and ensure that the latest security patches are applied.
Yes, there is Dependabot and the likes that help automate this process; but, any automated process that updates the action SHA without thorough human review is vulnerable to supply chain attacks and we are back to square one.

@stephanosio Yup, I'm with you on the analysis, and pinning just for the sake of making some tool happy only to then blindly bump updates once in a while to actually make sure we get important security updates is not ideal...
I think a good compromise might be to pin everything but actions/* actions as they are certainly (hopefully?) much more trustworthy?


Promise resolve and reject now return Interrupt errors

This is so that it can be handled at all.
Previously the error was just not propagated which lead to interrupts not really working with asynchronous code.
Fixes #623

I went with a bare minimum change and test. If you have some other cases which you will want to test I will gladly add them.


Refactor key_word to be set once, used everywhere

The bot will now use it's key_word as it's regex prefix for matching bot
commands. So the bot's listening string is now set in only one location
and then used everywhere.
This will help with testing. One can just set the key_word to a new string, and all the messages the bot listens to and the regex matches will all use it.

@ifo RSVPBot really needed this. Thank you kindly.


Tall grass blocks drop Hemp seeds

Tall grass blocks drop Hemp seeds when harvested. Hemp seeds should only be available by tilling grass/dirt blocks into farmland.
Source : BTW Change log Version 4.8913 September 3rd, 2013

Removed the Hemp Seed drop entirely from tall grass to make the method of obtaining it more clear cut, and because the existing rate had become so low that it was just encouraging people to do a lot of tedious grinding punching grass in the early game. If you want to find Hemp Seeds, the method to do so is through tilling regular grass blocks. If you want to lure chickens in the early game, look for pumpkins.

Maybe add this as a hardcore config that is disabled by default

Tilling farmland is not really hardcore.
You may think however that removing wood and stone hoe is hardcore, but that's a different thing.
Even for players that play in easy everything non-hardcore, I don't think getting a wooden hoe is hard.

people are picky, it doesn't make much difference if you get it from grass or tiling to us, but it will confuse people

It might be beneficial to keep it consistent with other mods, instead of hooking into tilling soil.

If people try the mod because they played BTW in the past, they may expect the same behavior they have seen in the original mod.
I think we agree in hardcore mode it has to be through tilling anyway, else the progression tree is broken, and at the moment hardcore things are enabled by default but can be disabled.
So it's a matter of consistency with BTW vs consistency with other mods, dilemma =) !
So an hardcore hemp config then ?

Yeah, I think "when in doubt, config it" is a good strategy.

if we do a hemp config, might as well throw in the other seeds into that as well

My main concern with that is other mods that may have different methods of obtaining crops, such as Pam's Harvestcraft.

Closing to clean up issues


Infinite loop Error

How can i fix this issue?

Error: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.
setState
<EMAIL_ADDRESS>(2063:13)

@akshaynmhc Can you share what was the prompt you used when you got this error?
Sharing the code, it generated would be also helpful.


Build and Deployment Workflow for Himanshu Portfolio Hub

This YAML configuration file is for automating the build and deployment workflow of the Himanshu Portfolio Hub project. It ensures smooth integration and deployment using GitHub Actions.

Added a blank workflow configuration to set up automation for building and deploying the Himanshu Portfolio Hub application.


Fix ring .remove() bug due to string/integer types

Because the i variable from the for..in loop is a string, the i + 1 code would be too large and would end up removing most of the points.

bangs head on table - good catch @jimpick!

Thanks! Landed on v0.7.2.


[metaphysics] Artist bio

The current artist bio that is returned by metaphysics appears to only be the short one, we also need the long one, as seen in the design.
{
  "data": {
    "artist": {
      "bio": "born 1965, Bristol, United Kingdom, lives and works in London, United Kingdom"
    }
  }
}

Dupe of #31.


Adding the Search, Pagination Functionality to the Individual Challenges section

Framework/code-stack
Native (HTML, CSS, and JS)
Scope
Core Application
Description

Search Functionality: Implement a search bar to allow users to quickly find challenges by name. This should support partial matches and be case-insensitive to ensure ease of use.
Pagination Functionality: Instead of loading all challenges simultaneously, introduce pagination. This will reduce initial load times, improve performance, and allow users to navigate through challenges in a more organized manner.
Sorting Functionality: Provide users with the ability to sort challenges by name, difficulty, and newly added. Sorting should be both ascending and descending to cater to various user preferences.

Screenshots
I am open to discussion as per the requirements @sadanandpai !
Additional Context
No response

@721-atikshaikh Search, pagination & sort are great features to go ahead with. I suggest to pick one at a time. Also are you planning to implement the search for all tech or as a web components shared

Hi @sadanandpai , sorry for the delay just dealing a lot in life. Will come back with a proper plan on how to proceed with a single feature. BTW do we have any community channel anywhere on Slack/Discord or any other place ? It would be easily available to chat

https://t.me/+rc6Rwd77G_gzMjA1 @721-atikshaikh

@sadanandpai Joined the group. Also I see this issue has been segregated into various small issues. Great idea ! Will pick one of them and start working on it.

yes @721-atikshaikh . that works


Requiring module "node_modules\react-native-make-it-rain\src\index.js"

Hi,
I want to add this package to Success.jsx file. However, when I import that package I receive this error.
Error: Requiring module "node_modules\react-native-make-it-rain\src\index.js", which threw an exception: TypeError: _ReanimatedModule.default.configureProps is not a function. (In '_ReanimatedModule.default.configureProps(Object.keys(NATIVE_THREAD_PROPS_WHITELIST), Object.keys(UI_THREAD_PROPS_WHITELIST))', '_ReanimatedModule.default.configureProps' is undefined)
When I remove the package from the file, my code works.
Is there any way to fix the error ?

Which version of react-native-reanimated is in your app? The one specified in this library is 1.8.0.

Which version of react-native-reanimated is in your app? The one specified in this library is 1.8.0.

Thanks for your kind response.
I'm currently using "react-native-reanimated": "~2.9.1",.
Should I have to install 1.8.0. version in order to use the package ?

Did a different version of reanimated fix your issue?
There's an open PR to update it to 2.8.0 if you'd like to try out that version

Hi,
Yes, the issue is fixed,
Thanks a lot

Thanks for the update. Would you mind listing the versions that work and doesn't work?
2.9.1 : fails?
2.8.0 : works?

Hi,
2.9.1 => 👎
2.8.1 => 👍


HOTFIX: restore missing link between lnurlp and nip57

The nip57 job relies on the dbInvoice desc field to get the metadata it needs to publish the zap receipts
    const desc = JSON.parse(inv.desc)
    const ptag = desc.tags.filter(t => t?.length >= 2 && t[0] === 'p')[0]
    const etag = desc.tags.filter(t => t?.length >= 2 && t[0] === 'e')[0]
    const atag = desc.tags.filter(t => t?.length >= 2 && t[0] === 'a')[0]
    const relays = desc.tags.find(t => t?.length >= 2 && t[0] === 'relays').slice(1)

however at some point there must have been a regression that caused this link to be broken, since this field is not being used anymore.
This PR adds an optional internalDescription context field that when passes is used to set the dbInvoice.desc field (that could be different than the servedInvoice.description field due to privacy settings).
This is an hotfix to restore the functionality with minimal changes, to avoid conflicts, since this code is being worked elsewhere.

Sure, why not. I thought the original intention was to have the desc field set for all the invoices. I've applied your suggestion in the last commit.


Templates loading

Hi, after today Aurelia update, my project stop working:

I'm trying to do more research, but without any luck.

Sounds like you haven't updated that repo properly with jspm. I've just downloaded a fresh copy of the new skelly and it works. So it must be something regarding to updating

You were right. Some packages were installing old version. I have to override their dependencies using -o.
aurelia-computed, aurelia-validtion and aurelia-compiler

@Mordred You ran jspm install aurelia-computed -o and the same with validation, which solved the problem for you? aurelia-compiler isn't part of the skelly. Would you mind pasting your package.config jspm-section?

Until this packages will be up to date with Aurelia, you can override their dependencies with inside package.json:
{
    "jspm": {
        ...
        "overrides": {
<EMAIL_ADDRESS>{
                "dependencies": {
                    "aurelia-binding"<EMAIL_ADDRESS>                    "aurelia-dependency-injection"<EMAIL_ADDRESS>                    "aurelia-templating"<EMAIL_ADDRESS>                }
            },
<EMAIL_ADDRESS>{
                "dependencies": {
                    "aurelia-binding"<EMAIL_ADDRESS>                    "aurelia-logging"<EMAIL_ADDRESS>                    "core-js"<EMAIL_ADDRESS>                }
            },
<EMAIL_ADDRESS>{
                "dependencies": {
                    "aurelia-binding"<EMAIL_ADDRESS>                    "aurelia-dependency-injection"<EMAIL_ADDRESS>                    "aurelia-templating"<EMAIL_ADDRESS>                }
            }
        }
        ...
    }
}

@Mordred you put 2 times<EMAIL_ADDRESS>in your overrides. What is your real 3th override?

you are referencing the latest versions in your overrides..
i deleted couple of times the aurelia jspm packages (and config).
i pasted the overrides in the package.json.
i did
jspm install aurelia-computed -o
jspm install aurelia-validation -o
then i get this in package.json (at bottom)
    "overrides": {
<EMAIL_ADDRESS>2,
<EMAIL_ADDRESS>2
    }

still have same error's as you (in chrome)

-o is option which requires some additional data: JSON or file.
jspm install aurelia-computed -o "...JSON string..."
If you still have errors, check if you haven't some other dependency problem.
Can you write what is your jspm install output?

@Mordred here is the jspm output , package.json and config.js
gist

info of jspm inspect (and --fork) gist

Try to override aurelia-breeze dependencies.
This is the problem:
     Installed Forks

                     github:aurelia/binding 0.6.1 0.7.0
        github:aurelia/dependency-injection 0.7.1 0.8.1
                 github:aurelia/http-client 0.8.1 0.9.1
                     github:aurelia/logging 0.4.0 0.5.0
                    github:aurelia/metadata 0.5.0 0.6.0
                        github:aurelia/path 0.6.1 0.7.0
                  github:aurelia/task-queue 0.4.0 0.5.0
              github:pwkad/aurelia-bs-modal master 0.1.2

Try to solve all dependencies, so you don't have forks of aurelia packages.

that was a great idea @Mordred , unfortunately it didn't work.
But then @jdanyow came with a breeze plugin update which fixed the issue.
Thanks


Update CVE-2024-52270 CISA ADP SSVC

CISA ADP SSVC data is incorrect, requesting update to the correct metrics.

Thank you for the reports. An analyst has reviewed the information relating to these vulnerabilities. We were not able to locate a public PoC, and generally do not accept video-only evidence as PoC. However, our analyst has been able to independently re-create the PoC, and has reassessed the scores based on that work.  Due to differences in our reassessment from your suggestions and additional data that we added to the enrichment record, we are unable to merge this PR. If you have additional questions or information to share for further consideration, please feel free to cite it here or open issues as needed.

@jwoytek-cisa
Let's at least also agree that it is also automatable, as they have an API. :)

Note: See also #144


Serializer is hard code and isn't using UPDATE_ON_DUPLICATE_REG_ID setting

https://github.com/jazzband/django-push-notifications/blob/13a2c6f7b34ab884f65e2791841549975795bebf/push_notifications/api/rest_framework.py#L58
This serializer has  hard code to check for duplicate registration_id , so even if i set UPDATE_ON_DUPLICATE_REG_ID in setting the update registration_id on duplicate doesn't work and always return
{
  "registration_id": [
    "This field must be unique."
  ]
}

regardless of the setting
a quick fix should be checking if UPDATE_ON_DUPLICATE_REG_ID is set in setting, if it's set then don't check for duplicate device on create
elif request_method == "create" and not settings.UPDATE_ON_DUPLICATE_REG_ID:
        devices = Device.objects.filter(registration_id=attrs["registration_id"])

it was a mistake, sorry i forgot to put the setting in PUSH_NOTIFICATIONS_SETTINGS


rewrite mqtt

rewrite mqtt communication( doesnt any sense use an API above the paho mtt)

https://github.com/davisouzaluna/Dpubsub


Questionnaire Constraint support

Is your feature request related to a problem? Please describe.
Do custom validation for a given questionnaire.item with a FHIRPath custom predicate and custom error message.
Use case:
There is a vaccination date field, and we want to make sure that when the user inputs a date. The date must not be before the Patient's DOB.
What should happen:
If the user inputs a date that's before the Patient's DOB. Then show a custom error message below the field: “Date must not be before the DoB”.
Describe the solution you'd like
Add support for Questionnaire Constraint extension to do this.
Describe alternatives you've considered
N/A
Additional context

Confirmed by Lloyd via Zulip chat that the Questionnaire Constraint is the right extension
Questionnaire Constraint docs

FHIR R4
FHIR IG

Questionnaire Constraint is part of the SDC Behavior
Questionnaire Constraint will be used by ticket https://github.com/opensrp/fhir-resources/issues/1248

Would you like to work on the issue?
N/A

@jingtang10 @f-odhiambo @pld @samkanga

another use case is:
enter phone number field
confirm phone number field
if the 2 values are different, then show validation error
cc @mmweru

@jingtang10 it has been finalized that I'm working on this

@shelaghm Should we use the pop-up dialog that displays a list of errors to show a global level error message from this constraint-extension to the user?
What do you suggest?

if we go w/that, is there a setting to disable the "submit anyway" button? there are projects that would not want to have that option available

@pld the visibility of "submit anyway" button is not configurable.
We can discuss to make it configurable, @jingtang10 @santosh-pingle
A question:
Do we have a use case to not use the error dialog itself? or are we ok for that dialog to start showing up in OpenSRP 2? My concern is, our SDK snapshot release should have the latest code on master. So, this dialog should now popping up on our OpenSRP 2 if there are validation errors. This is regardless of what causes the validation errors i.e. it could be from required field or others, so it's not only from this constraint extension.

Closing this in favour of #1849 which was opened first.

if we go w/that, is there a setting to disable the "submit anyway" button? there are projects that would not want to have that option available

@pld we don't have this as a customized option at the moment. but as @FikriMilano said we might be able to add this. i'll create an issue for this.


Suggestion: Have --printHaplotypes and --printLikelihoods on by default

When first interacting with the tool it is not immediately clear that the output files will not be created by default.
It took some time to discover that this was the issues when the program appeared to complete, with no output and no errors in the log file. Additionally, the example command provided in the README file (lines 88-91) does not include the options. The following section of the manual then states all files will be created.
Looking at the code in java/rag/HAROLD/Cluster_RG.java, it is clear that the haplotype and likelihood files are created only if requested.
It would simplify the user experience if the output files were created by default. Especially as they are required inputs for the refinement step.
If there is a use case where the output files are not required, then the inverse options could be provided.
I should note that I am using the V2.0 release.

Hi there,
Just checked and v2 release is fine. As you can see in my comment above, our example included the options to print results with -H and -L (the shorter version of --printHaplotypes and --printLikelihoods).  I will note your suggestion and make that automatic for future versions of the tool!

I can confirm that when the short or long versions of the printHaplotypes and printLikelihood flags are included in the command, then the output files are created.
However when the options are not included, then the output files are not created.
I tested both with the files in the V2.0 release, and a clone of the current repo.
My suggestion is simply that output files should be created by default, without the need to include the command line options.
Regardless, I'm looking forward to working with the tool, it is very cool!


Bot does not work TabError

`Traceback (most recent call last):
File "pokecli.py", line 39, in
from pokemongo_bot import logger
File "/Users/Serkan/PokemonGo-Bot/pokemongo_bot/init.py", line 85
gyms = [gym for gym in cell['forts'] if 'gym_points' in gym]
TabError: inconsistent use of tabs and spaces in indentation`
I can't run bot with "python pokecli.py" on OS X, when I try I did get error message on above. I tried many things (I tried run even with no-change configs file for some encoding problems etc.) but still can't solve problem
Other Information
OS: OsX El Capitan
Python Version: 3.5.1
I use master version

@srknkrn Please run this command: git log -n 1 --pretty=format:"%H" and tell me your result.

Thank your for your interest @TheGoldenXY .
The result is 3aca6d798f8a3e173dce0beb7b13c9505cc5b251

I solved the problem via downgrade of Python version to 2.7


how to save edited table

I have been spinning my wheels trying to save the edited table as a new data frame. Is it possible to do that whit a shiny core? the examples are limited and don't have that option. BTW, this is something rather easy with R DT.

Hi @j0bekt01 Maybe it was a little bit hidden in the main example.
So, I added a new example here.

Hi @j0bekt01 Maybe it was a little bit hidden in the main example.
So, I added a new example here.
I did eventually get it to work. I appreciate the prompt response.


loose mention @ check

Currently, we are strictly checking the @ with the message.mention() method, which means that, if we copy/paste the @name to WeChat input, it will not be recognized as a mention.
This cause lots of confusion from our developers. From a user experience perspective, the copy/paste is the same as the long push mention, so I decide to change those checking to be loose.
Issues & PRs

The old puppeteer web mention implementing PR: #362

Merge to #1991


Minor styling changes for new modals

💬 Description
Nothing big here, should all be self explanatory!
✅ Checklist

[ ] Tests written
[ ] Browser tested
[ ] Added to documentation
[ ] Added to storybook

 Modal snags


Add v1 API Endpoint to get the submitted code of a player

As player
I want to get the code that I currently have submitted in the lobby to more easily edit it
Notes:

See apiv1.md for a description of the endpoint

Acceptance Criteria:

[ ] The API v1 player code retrieval endpoint is implemented according to spec and available at /api/v1/...
[ ] The code is fully tested or a good explanation given why it should not or cannot be tested

please separate apiv0 and apiv1 in different controllers, including their tests


Using gcr.io/google_containers/pause by default

LGTM

Never mind since it only complaint on my desktop. Cluster looks fine.

I saw that same error yesterday. Seems to be a stale client credential problem. Does retrying the command work?

no, it never work from my desktop. But cluster works fine.

Try the following.
rm $HOME/.dockercfg

docker pull gcr.io/google_containers/pause:0.8.

cc @mattmoor

The problem is that the access token in .dockercfg has expired and so technically you are sending gcr.io a bad credential.
We ultimately want better ephemeral credential support in the docker client (think: git credential helpers) to smooth this rough spot and eliminate our need to wrap docker in gcloud today.
FWIW, if you hit this a lot consider aliasing docker as "gcloud preview docker".


Add patch releases: v3.5.2, v3.4.2, v3.3.4, v3.2.5

[ ] Tests
[ ] Documentation
[ ] Release note

None required

Deploy preview for calico ready!
Built with commit 0635fb19822a34c0d040f9adaf1d8c12e7a7af35
https://deploy-preview-2444--calico.netlify.com


After installing HaC-Mini on my NUC8i5BEH, I can't enter the desktop after booting, and the loading progress bar is stuck at about 100%.

Describe the bug
After installing HaC-Mini on my NUC8i5BEH（with opencore）, I can't enter the desktop after booting, and the loading progress bar is stuck at about 100%.
Expected behavior
I originally wanted to install this software so that my box can use the Thunderbolt 3 interface function normally.
Configuration

HaC Mini version [e.g: 2.0]: 2.9
OSX version [e.g: 10.14.6]: 10.15.5
NUC model [e.g: NUC8i7HNK]: NUC8i5BEH
Boot SSD model and protocol [e.g: Samsung EVO 860 1TB, SATA]: Samsung EVO 860 500TB, SATA
Second SSD model and protocol (if installed) [e.g: HP EX920 1TB, NVMe]:
First DIMM model [e.g: Patriot DDR4-2666 16GB]: HyperX Impact DDR4-2666 16GB
Second DIMM model (if installed):
Display port(s) used [e.g: USB-C, mini DP]: HDMI
Display resolution(s) [e.g: 4K, 5K]: 2K
Any TB3 devices:
Any USB devices:

Modifications
List any mods to config.plist, any additional kexts, anything installed to /Library/Extensions and /System/Library/Extensions, any additional patches, etc. Please attach your config.plist if you made any modifications.
Panic log
Include a screenshot of the panic message if applicable.
PLEASE HELP ME !
What should I do to fix it ？

NUC8i5BEH Is not supported


[twitter] Shorten title attribute for #29912

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] Searched the bugtracker for similar pull requests
[x] Read adding new extractor tutorial
[x] Read youtube-dl coding conventions and adjusted the code to meet them
[x] Covered the code with tests (note that PRs without tests will be REJECTED)
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

This request trims the standard Twitter ID field to workaround the bug reported in #29912

@dirkf, I believe I have achieved your request with a little less code. The uploader name is pretty strictly limited by Twitter, so I don't think we need to slice it. That means we can use a more straightforward slice like the one just pushed. Give it a look and let me know what you think.

@dirkf, those changes are in.

The flake errors in the test run appear to be in other files.

Apparently the default flake8 settings that the project uses changed in some way so that a keyword must be separated from the next token by a space, which is basically good but irritating. Otherwise GH somehow removed some spaces from the code, which seems unlikely and would be much worse.
If you update from the current master the 2 places where this caused problems are fixed.

I think I've done that.

imo, this should not be implemented.

Would all extractors be expected to do this?
title != filename. We shouldn't extract wrong metadata just because it is convenient for filenames. Output template should be used to control filename length instead. This is a poorly implemented bandaid.

As I see, changing the default outtmpl to something like %(title).200s-%(id)s.%(ext)s would be much better than this solution.

This extractor is unusual in that there is no title in the plain webpage, although a title and an og:title are set by JS. The full tweet text is extracted in the description. So:

Would all extractors be expected to do this?

No. But Twitter was the source of some of the original issues complaining about filename length errors with the default output template, so this is an opportunity to avoid those in future, without expecting users to check for a FAQ that tells them to use %(title).100s or whatever, and without changing the core code.
Instead of fixing the title, we could generate a warning if the title is "long", or possibly include the FAQ text in the error message if we could reliably detect an exception caused by an over-long filename (a generic "solution" in place of #29989).
Changing the default output template could be an alternative but I would be concerned that setting a sufficiently low value to avoid filename length issues would affect filenames on filesystems with no effective limit, attracting a different set of complaints. The extractor could manipulate the output template by inserting a length field into any %(title)s but that would weirdly affect all URLs in the download session.

title != filename. We shouldn't extract wrong metadata just because it is convenient for filenames. ...

I believe that the default output template was chosen on the assumption that title would be a short text field, for some definition of "short". Implicitly, yt-dl tries to cast all sites in the mould of YouTube, where the title is (a) required (b) not longer than 100 characters, although SEO fiends recommend no more than 70.
Apparently the page title for a tweet set by Twitter has the form (in terms of the extracted fields) {og_title}: "{clean_html(description)}", where og_title, the og:title meta field, is {uploader_id} on Twitter. We emulate that but remove  on Twitter, presumably because, where else would it be, given the context? A profile page has {uploader_id} (@{uploader}) / Twitter, but we don't have an extractor for those [^note].
[^note]: We do have an extractor for twitter:card but it redirects to an invalid URL and all the test URLs but the single only_matching URL give a "nothing to see here" page; even that gets 403 for the API call to list video details, as does the only similar URL known to G.
Nitter tries to improve Twitter by making a tweet title thus {profile.fullname} (@{profile.username}): "{stripHtml(tweet.text)}", combining the two methods used by Twitter. Perhaps we should also do that, as {uploader_id} (@{uploader}): "{clean_html(description)}" (and stripping unwanted Twitter links from the description, as now).
In the browser title bar I see the Twitter title presented with ... replacing as much of the middle of the text as is needed to make the text fit the title bar. Something like that still seems appropriate.

Output template should be used to control filename length instead. This is a poorly implemented bandaid.

After all, yt-dl itself is just a bandaid in some sense. What would make for a better implementation? Surely even a harsh critic would call the current implementation at least "adequate"?

What would make for a better implementation? Surely even a harsh critic would call the current implementation at least "adequate"?

I gave one suggestion above. As you pointed out, that has it's own issues too. (I still think this is a better solution though). If a proper solution was easy, I doubt this issue would have existed for so long
From a user perspective, I do agree this is better than nothing. But I also think that it'll become a headache to maintain any kind of consistency b/w extractors over time.
And I disagree that the twitter is special in this regard. There are plenty of other extractors that face this issue. This search is a quick way to get some examples
That said, since twitter is so popular, I can understand why you'd consider this technical debt to be acceptable.
And for the record, while an FAQ entry might help some users, I don't think it will reduce the number of issues opened. The kind of people who actually read the FAQ are the same people who'd look for duplicate issues.

If you really want to get existential about it, I think the core problem is requiring a title for all sites. As detailed above, there's not a tidy title for a tweet analogous to a YouTube title. So there will never be tidy answer to this problem.
That said making the title field optional seems like a can of worms that isn't worth opening either. Some kind of compromise is necessary and, as documented in the issue that prompted this pull request, the current solution is bad for users. So, IMHO, some alternative is needed. Something along the lines of what's proposed here does seem like the simplest solution. If universality is what you're after, I think enforcing a global trim on all title attributes seems like the most natural extension.

The rationale for title is presumably what I said above, trying to make all sites fit the YT metadata schema. yt-dlp has allowed a None title while continuing to require the title field without the sky falling.

... If a proper solution was easy, I doubt this issue would have existed for so long

Amen to that. If we can get something like #29989 to work, that would fix the problem for all sites. Meanwhile:

... since twitter is so popular, I can understand why you'd consider this technical debt to be acceptable.

Exactly. The Twitter title field is up for grabs: its extraction shouldn't routinely crash the program. I guess that extractor is used more than all the other possibly problematic extractors together, which are also a small proportion of the ~800 (crikey) we have.
And

...while an FAQ entry might help some users, I don't think it will reduce the number of issues opened

Absolutely, why I mentioned putting some FAQ text in error message appears, if only we knew reliably what that would be.

I'm withdrawing this request.


Dead keys do not work on command mode

The dead key issue seems to have been fixed for the text editor (great job, by the way), but I still can't input them on : commands, which is a blocker for me.

They also do not work for normal commands, e.g. ' to move to a mark, " to use a register, ^ to go to the start of the line, ~ to switch the case of a letter.
Perhaps this should be a different issue, but I do not know how to name this issue hahah. "Dead keys do not work for commands"?

The vim/nvim behaviour in this last case, by the way, is to treat the dead key input as usual, i.e., "+i runs an nonexistent í command—to use the i register I need to type "+<space>+i.

Can confirm this on 0.2.10

Ah, so close. Thanks for testing it out, @lbebber !
Glad things are working better in insert mode. Seems like there are two issues:

Dead keys aren't working in normal mode (thanks for calling out the Vim behavior, that's very helpful!)
Dead keys aren't working in cmdline mode

I'll check it out in a bit. Today, in non-insert mode, the KeyboardInput code falls back to just handling keydowns, but that isn't sufficient for handling dead keys - so might need some extra logic there. I think it should be straightforward to fix though (just the platforms have different ways of signaling dead keys, which is annoying!)

Thanks @bryphe—as far as I know this is the only issue that prevents me from using Oni, and I'm really looking forward to it.


Cannot set property 'muted' of null

Bug
What is the current behavior?
When loading in a video with a simple configuration such as
        <mat-video
          src="{{ video.absolutePath | remoteVideo }}"
          [download]="true"
          [title]="video.name"
          [poster]="coverImage(video) | remoteImage"
        ></mat-video>

The following error is thrown in the console.
core.js:5845 ERROR TypeError: Cannot set property 'muted' of null
    at MatVolumeControlComponent.set muted [as muted] (mat-video.js:1150)
    at setInputsForProperty (core.js:13504)
    at elementPropertyInternal (core.js:12319)
    at Module.ɵɵproperty (core.js:20842)
    at MatVideoComponent_div_8_Template (mat-video.js:96)
    at executeTemplate (core.js:11858)
    at refreshView (core.js:11705)
    at refreshDynamicEmbeddedViews (core.js:13070)
    at refreshView (core.js:11728)
    at refreshComponent (core.js:13145)

The video however does play and respond still as expected.
What is the expected behavior?
No console error is thrown.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
"@angular/compiler": "~9.0.1",
"@angular/material": "^9.0.0",
"mat-video": "^2.7.2",
"typescript": "~3.7.5"

Chrome Version 80.0.3987.132
Mac OS 10.15.3

Also getting this exact behaviour

Also getting cannot get muted of null

same here

yep... same bug.. started appearing in last version...
awesome project, please fix...
TX!!!!

what's the status of this bug?

PR is open with a fix; just needs to be merged.

when can it be merged? tx!

Fixed in version 2.8.0.


chore: update to TypeScript 5, Stencil 4 (and more :finnadie: )

[x] Rebase/clean the commit history

Mostly upgrade Stencil to v4 and TypeScript to v5.
Bonuses:

Fix Angular E2E unstable
Jest 29 in most of the project (exclusion on Atomic)

The riskiest/biggest change is around the patch in the Stencil compiler (good old AST :finnadie:) See:

https://github.com/ionic-team/stencil/pull/4771
https://github.com/ionic-team/stencil/pull/4772

Will scope out the type fix of the code-editor component of Storybook into an improvement: Unknown amount of effort, very low reward.

https://coveord.atlassian.net/browse/KIT-2312

I'll checkout the branch and build storybook locally to do some manual/smoke tests with it.
People use it quite a lot when implementing, I wanna make sure everything is still good on that front.

Everything seems 💯
🚢

I'll checkout the branch and build storybook locally to do some manual/smoke tests with it.
People use it quite a lot when implementing, I wanna make sure everything is still good on that front.

Everything seems 💯
🚢

Dependency Review
The following issues were found:

❌ 2 vulnerable package(s)
❌ 1 package(s) with incompatible licenses
❌ 2 package(s) with invalid SPDX license definitions
⚠ 10 package(s) with unknown licenses.

See the Details below.
Snapshot Warnings

⚠: No snapshots were found for the head SHA b86cecd.

Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.
Vulnerabilities
package-lock.json
Name	Version	Vulnerability	Severity
json5	2.2.1	Prototype Pollution in JSON5 via Parse Method	high
json5	1.0.1	Prototype Pollution in JSON5 via Parse Method	high

Only included vulnerabilities with severity high or higher.

License Issues
package-lock.json
Package	Version	License	Issue Type
axe-core	4.8.1	MPL-2.0	Incompatible License
esprima	1.2.2	BSD	Invalid SPDX License
gitconfiglocal	1.0.0	BSD	Invalid SPDX License
@typescript-eslint/scope-manager	5.62.0	Null	Unknown License
@typescript-eslint/types	5.62.0	Null	Unknown License
@typescript-eslint/typescript-estree	5.62.0	Null	Unknown License
@typescript-eslint/utils	5.62.0	Null	Unknown License
@typescript-eslint/visitor-keys	5.62.0	Null	Unknown License
utils/atomic-storybook/package-lock.json
Package	Version	License	Issue Type
string-width-cjs	4.2.3	Null	Unknown License
strip-ansi-cjs	6.0.1	Null	Unknown License
wrap-ansi-cjs	7.0.0	Null	Unknown License
utils/atomic-storybook/package.json
Package	Version	License	Issue Type
@types/lodash	^4.14.198	Null	Unknown License
@types/react	^18.2.21	Null	Unknown License

Allowed Licenses: 0BSD, Apache-2.0, Apache-2.0 AND MIT, Apache-2.0 AND BSD-3-Clause AND Python-2.0, Beerware, BlueOak-1.0.0, BSD-1-Clause, BSD-2-Clause, BSD-2-Clause-Patent, BSD-2-Clause-Views, BSD-2-Clause AND MIT, BSD-3-Clause, BSD-3-Clause-Attribution, BSD-3-Clause-Clear, BSL-1.0, CC-BY-3.0, CC-BY-4.0, CC0-1.0, CNRI-Python, curl, HPND, IBM-pibs, ImageMagick, ISC, JSON, MIT, MIT-0, MIT AND ISC, MIT AND Python-2.0, MIT-advertising, mpi-permissive, NCSA, ODC-By-1.0, PDDL-1.0, Plexus, PostgreSQL, PSF-2.0, Python-2.0, Python-2.0.1, SAX-PD, Unlicense, UPL-1.0, W3C, Wsuipa, WTFPL, X11, X11-distribute-modifications-variant, Xerox, Zlib, ZPL-2.1

Scanned Manifest Files
package-lock.json
package.json
packages/atomic-angular/package.json
packages/atomic-hosted-page/package.json
packages/atomic/package.json
packages/auth/package.json
packages/bueno/package.json
packages/headless/package.json
packages/quantic/package.json
packages/samples/angular/package.json
packages/samples/atomic-next/package.json
packages/samples/atomic-react/package.json
packages/samples/headless-react/package.json
packages/samples/stencil/package.json
packages/samples/vuejs/package.json
utils/atomic-storybook/package-lock.json
utils/atomic-storybook/package.json
utils/nx-plugin/package.json
utils/release/package.json

Verified:

Licenses issues have already been addressed in the past (BSD is fine, MPL is OK here 'cause dev dep)
vuln on JSON5 are OK because there's solely on SFDX-CLI

https://github.com/ionic-team/stencil/issues/3831#issuecomment-1714380998 There might be some side-effects with the patch, waiting for confirmation tho: our tests seems to pass, so I want to see what would break

ionic-team/stencil#3831 (comment) There might be some side-effects with the patch, waiting for confirmation tho: our tests seems to pass, so I want to see what would break

After discussion with both stencil maintainer & the team, we decided to go ahead with the patch/custom behavior and introduce a caveat: https://github.com/coveo/ui-kit/pull/3162/commits/8b5aa97d88777570bcf845cd3badace4a1ee672a


Update to the latest Google.Apis.Auth

(Self-merging when Travis is green in the hope of fixing the myget build)