store: Have GlobalStore manage one PerAccountStore per account

This is stacked atop #26.
As part of #21, we'll want to be able to freely instantiate a PerAccountStoreWidget whenever we want to mark some subtree as being for a particular account, and have that cheaply just refer to the already-loaded data for that account. This PR does that by having a GlobalStore maintain a PerAccountStore for each account, which PerAccountStoreWidget asks it for when it's first mounted in the element tree.
Because the logic in GlobalStore to maintain that, and in particular to avoid redundant requests if several PerAccountStoreWidgets ask about the same account at the beginning, is a bit complex, we want tests for it. To make those possible, we split both GlobalStore and PerAccountStore into a base class (which keeps the name) and a subclass that adds the using-real-data part which a unit test will want to leave out.
We also make sure to accommodate this fun trick (in _PerAccountStoreWidgetState):
    // If we already have data, get it immediately. This avoids showing one
    // frame of loading indicator each time we have a new PerAccountStoreWidget.
    final store = globalStore.ofAccountSync(widget.accountId);
    if (store != null) {
      _setStore(store);
    } else {
      // If we don't already have data, wait for it.
      (() async {
        _setStore(await globalStore.ofAccount(widget.accountId));
      })();
    }

Fortunately the nature of that trick means that other code generally won't have to think about it; just use PerAccountWidget.
(We might eventually want to play the same kind of trick in a small number of other places, where we depend on data that's loaded outside of the initial fetch (and so isn't guaranteed by simply having a PerAccountState) but that we'll sometimes have already loaded. The message list is the main example that comes to mind.)

Thanks for the review! Merging, with that rename.


docker.io/jboss/wildfly server misbehaving

$ docker pull jboss/wildfly
Using default tag: latest
Pulling repository docker.io/jboss/wildfly
Error while pulling image: Get https://index.docker.io/v1/repositories/jboss/wildfly/images: dial tcp: lookup index.docker.io on <IP_ADDRESS>:53: server misbehaving

@gabrielvega are you getting this error on the command line as well?
Please email<EMAIL_ADDRESS>for immediate support. We really care about the experience of our Docker Hub.

Yes, from command line.
Ok, let me email them.
Thanks!


Fix 7 missing dependencies in Makefile

Hi, I've fixed 7 dependencies missing reported.
Those issues can cause incorrect results when greatest is incrementally built.
For example, any changes in "greatest.h" will not cause "example_cpp" to be rebuilt, which is incorrect. Line 45 and 46 in the original Makefile did not work. Makefile and "greatest.h" were not specified successfully as the prerequisites of *.o. This cause the incorrect build results of 5 targets.
I've tested it on my computer, the fixed version worked as expected.
Looking forward to your confirmation.
Thanks
Vemake

Okay, looks good. I also noticed that example_trunc wasn't specified right while testing this, but that's not coming from your change.


[Bug] Incorrect display of workflow instance running status

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
When the last task of the workflow instance is disabled and the final normal task fails to execute, the running status of the workflow instance should display as failed, but it shows success instead

What you expected to happen
The workflow status should be consistent with the actual state
How to reproduce
Reproduce as above, you can see the issue
Anything else
No response
Version
3.1.9
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

You should check failure strategy.


implement UI for working with national identities

⬑ #3994
← #4007 — #4009 →
Punchlist

[ ] remake against master once #4007 lands

aff5bdd2a205f00777209e657f4dadcec6079cd8:

☺

df2b9b552f529768f480d7b3cc077dec27aeada3:

c45687a911e58427c0a392fe37b143d136e3e039:

f50c3f995147eefe51f045ce6e0e7fe966cffee6:

My thinking is that on the /identities/ page where we have the list of identity cards, the "Add Identity" card/button will pop up a country chooser, and then clicking on the country will take you to /identities/XX where XX is a two-letter country code for a country we know about. That'll be where you can add, edit, and remove identity information.

Chooser into form in 506993d19d46591070a7e95c109be9d5f6dcd5a9:

👍
c483a6b67a9cc3787edd5c95dae0e1d9de3708ef:

Alright, this one is far enough along for now.

I kinda like the cardy things. (I got them from PayPal, as I believe I mentioned somewhere.) We should use them for payment routes methods and maybe accounts elsewhere, too.

I kinda like the cardy things.

Yh, uphold has them too

Alright, this one's gonna need a little attention first ...


Add slots for customization

Nice component! It would be nice to be able to customize using slots. For example, I'd like to be able to customize active state beyond css.

Honestly, I am not familiar in using slots.
But if you have nice idea, this repo is open for your Pull Request.
@jacobg


Ballista assumes all aggregate expressions are not DISTINCT

Describe the bug
We have a hard-coded distinct = false parameter in ballista/rust/core/src/serde/physical_plan/mod.rs.
Ok(create_aggregate_expr(
    &aggr_function.into(),
    false, // <-- hard-coded "distinct"
    input_phy_expr.as_slice(),
    &physical_schema,
    name.to_string(),
)?)

To Reproduce
Try running a COUNT(DISTINCT expr) in Ballista
Expected behavior
We need to include the distinct flag in the protobuf for aggregate queries and implement the appropriate serde code.
Additional context
None

Related: https://github.com/apache/arrow-datafusion/pull/3250

Hi @andygrove Ive run in local ballista

The issue is specific to distributed mode because it is the serde that has the hard-coded value

Hi @andygrove Ive run in local ballista

The issue is specific to distributed mode because it is the serde that has the hard-coded value

Is there any doc how to run ballista tests in distributed mode? perhaps its part of CI now?

@andygrove @comphead
I tried to analyze the problem and found that SELECT count(distinct c1) as cnt_distinct FROM aggregate_test_100 is also expected in distributed mode.
Because single distinct is optimized by the optimizer as group by in datafusion:
example sql: select count(distinct c_name) from customer_1;

// Logic plan before optimization:
Projection: COUNT(DISTINCT customer_1.c_name)
   Aggregate: groupBy=[[]], aggr=[[COUNT(DISTINCT customer_1.c_name)]]
     TableScan: customer_1 projection=[c_name]

// Logic plan after optimization:
Projection: COUNT(DISTINCT customer_1.c_name)
   Projection: COUNT(alias1) AS COUNT(DISTINCT customer_1.c_name)
     Aggregate: groupBy=[[]], aggr=[[COUNT(alias1)]]
       Aggregate: groupBy=[[customer_1.c_name AS alias1]], aggr=[[]]
         TableScan: customer_1 projection=[c_name]

The current problem with ballista is that it does not support DistinctCount in non-single distinct scenarios.
Example sql select count(distinct c_name), max(c_name) from customer_1:
[2022-10-18T06:32:14Z ERROR ballista_core::execution_plans::distributed_query] Job 3N8dtpp failed: Error planning job 3N8dtpp: NotImplemented("Aggregate function not supported: DistinctCount { name: \"COUNT(DISTINCT customer_1.c_name)\", data_type: Int64, state_data_types: [Utf8], exprs: [Column { name: \"c_name\", index: 0 }] }")
DataFusionError(ArrowError(ExternalError(Execution("Job 3N8dtpp failed: Error planning job 3N8dtpp: NotImplemented(\"Aggregate function not supported: DistinctCount { name: \\\"COUNT(DISTINCT customer_1.c_name)\\\", data_type: Int64, state_data_types: [Utf8], exprs: [Column { name: \\\"c_name\\\", index: 0 }] }\")"))))

I will sumit a PR for this :)


Add CI checks to ensure Notice.txt and cgmanifest.json stay in sync

Add linting to validate our Notice.txt and cgmanifest.json stay in sync.
Stretch goal, verify the Notice.txt entries are still in use.

Closing since this is a dupe of https://github.com/Azure/azure-sdk-tools/issues/3349 and the fix for that will be general to all languages.


KAFKA-3479: consumer metrics doc

added new consumer metrics section
refactored common metrics into new section
updated TOC

@coughman Thanks for picking this up. I think we have some topic-level metrics for the new consumer as well which can be found in Fetcher.FetchManagerMetrics. Maybe they should go here also?

sure I'll add those in

@hachikuji doesn't this commit already contain the fetch manager metrics? https://github.com/coughman/kafka/commit/8c6ef282dddd68315d735f34d87fd93e21b50309
I'll update the section header to be "fetch manager"

added subsections for topic-level, global request, and global connection metrics

removed "global request section".  refactored into common node metrics

@coughman I think @hachikuji's comment about duplicates still holds -- I see request-rate, request-size-avg, request-size-max, etc multiple times.

removed dupes

LGTM, thanks!


fix: reduce scanning for appmap.yml

This shouldn't be merged until the wip commit gets removed. It's only there as a temporary measure to run the integration tests.
Reduce the cases where the extension scans the entire subtree under the current project directory.
Fixes #633 .

There is some type weirdness happening there.
Also, I wonder if it wouldn't be a better design to move this logic into the ConfigFileProvider instead of littering the watchers with yet another parameter? Feels like it belongs there.

I didn't put it in ConfigFileProvider, because ConfigFileProvider is so simple:
export type ConfigFileProvider = () => Promise<vscode.Uri[]>;

It seems reasonable to expand it with this functionality, though. Let me try it and see what it looks like.

There is some type weirdness happening there.
Also, I wonder if it wouldn't be a better design to move this logic into the ConfigFileProvider instead of littering the watchers with yet another parameter? Feels like it belongs there.

I didn't put it in ConfigFileProvider, because ConfigFileProvider is so simple:
export type ConfigFileProvider = () => Promise<vscode.Uri[]>;

It seems reasonable to expand it with this functionality, though. Let me try it and see what it looks like.

Thanks! You can probably keep the simple API (at least consumer-side), just put more logic there :)

:tada: This PR is included in version 0.68.1 :tada:
The release is available on:

v0.68.1
GitHub release

Your semantic-release bot :package::rocket:


I saw some errors and wanted to know what they meant and if there was an impact

No Permission or Channel exists for <IP_ADDRESS>:47104 on allocation <IP_ADDRESS>:58632 (suppressed 175 log events)
file_client.go:214: config-file-client WARNING: Waiting for config file "etc/stunnerd/stunnerd.conf"

These are two errors:
This is the uglier one and indicates either a NAT/firewall conntrack mapping timeout or a weird violation of the TURN standards on the client side. If, however, your connections are working fine then you can safely ignore this.
No Permission or Channel exists for <IP_ADDRESS>:47104 on allocation <IP_ADDRESS>:58632 (suppressed 175 log events)

This one shouldn't ever happen: this error shows that STUNner cannot load the configuration from a file but we stopped using the file-based config system about 2 years ago. Please check your install and re-install STUNner properly:
 file_client.go:214: config-file-client WARNING: Waiting for config file "etc/stunnerd/stunnerd.conf"


Too long chat history cannot be saved

If the chat history grows too long in one chat then the chat history cannot be saved for all the other chats too.
The solution could be to just keep the last N messages of each chat. Then older messages can be either discarded or stored with other archive mechanisms.

This is implemented as part of #384. The limit currently is 100 messages.


Feature: Batch moving (closed) issues

I would like to kill a particular fork that has many closed issues and move them upstream. Keeping them in the original state (closed).

I have a select group of issues I want to move out of RepoA to RepoB (both in the same org, owned by me).
I put them in a specific milestone.  I thought that was a good way to isolate/group them.
You might also support migrating issues with a specific label

I would love if this could actually happen

+1.
I'd suggest using a label rather than a milestone or some other mechanism - this seems like the natural way to arbitrary group issues together.


pkgfile fails to run

I get the following when trying to run it: C:/msys64/usr/bin/pkgfile.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory
Running strace pkgfile yields the following popup:

and the following error messages:
$ strace pkgfile
create_child: pkgfile
--- Process 6612 created
--- Process 6612 loaded C:\Windows\System32\ntdll.dll at 00007FFE90D40000
--- Process 6612 loaded C:\Windows\System32\kernel32.dll at 00007FFE8E3C0000
--- Process 6612 loaded C:\Windows\System32\KernelBase.dll at 00007FFE8DAB0000
--- Process 6612 thread 11428 created
--- Process 6612 thread 12764 created
--- Process 6612 thread 17380 created
--- Process 6612 loaded C:\msys64\usr\bin\msys-archive-13.dll at<PHONE_NUMBER>A10000
--- Process 6612 loaded C:\msys64\usr\bin\msys-curl-4.dll at 00000005D2420000
--- Process 6612 loaded C:\msys64\usr\bin\msys-2.0.dll at<PHONE_NUMBER>040000
--- Process 6612 loaded C:\msys64\usr\bin\msys-pcre-1.dll at 00000003FF210000
--- Process 6612 loaded C:\msys64\usr\bin\msys-bz2-1.dll at 00000003FFD00000
--- Process 6612 loaded C:\msys64\usr\bin\msys-crypto-1.0.0.dll at 00000003FFB10000
--- Process 6612 loaded C:\msys64\usr\bin\msys-iconv-2.dll at 00000003FF4F0000
--- Process 6612 loaded C:\msys64\usr\bin\msys-lzma-5.dll at 00000003FF470000
--- Process 6612 loaded C:\msys64\usr\bin\msys-idn-11.dll at 00000003FF4B0000
--- Process 6612 loaded C:\msys64\usr\bin\msys-lzo2-2.dll at 00000003FF440000
--- Process 6612 loaded C:\msys64\usr\bin\msys-ssh2-1.dll at 00000003FF060000
--- Process 6612 loaded C:\msys64\usr\bin\msys-nettle-6.dll at 00000003FF2C0000
--- Process 6612 loaded C:\msys64\usr\bin\msys-ssl-1.0.0.dll at 00000003FEFF0000
--- Process 6612 loaded C:\msys64\usr\bin\msys-z.dll at 00000003FED30000
--- Process 6612 loaded C:\msys64\usr\bin\msys-xml2-2.dll at 00000003FED50000
--- Process 6612 loaded C:\msys64\usr\bin\msys-intl-8.dll at 00000003FF4A0000
--- Process 6612 thread 17380 exited with status 0x0
--- Process 6612 thread 12764 exited with status 0x0
--- Process 6612 thread 11428 exited with status 0x0
--- Process 6612 exited with status 0xc0000135
C:/msys64/usr/bin/strace.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory

Yes, same issue here, although I am not setting a specific missing file. Just /msys2/usr/lib/git-core/git-remote-https.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory

I have the exactly the same issue than:  /msys64/usr/lib/git-core/git-remote-https.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory

@ignacio-ca I solved this actually (or a workaround at the very least) -- see my post on stackoverflow

I couldn't make it work. I added git.exe to the path and invoke git from home directory in mingw64 but still get the error.

I reinstall a new msys2 and now works. I don't know the reason. Thanks!

Same problem here. Will try reinstalling, then.


Add Barcode reader to a text attribute

A text attribute might be marked (using annotation TextInput) as a "Barcode" .
For these types of Collect attributes the interface should show a button to start the barcode scan capture. Once the scanner recognizes the barcode, its value should be presented on the text input.

done already!


Support caching icons

Background
#2725
Change List

update document
In auto packing case: getMapping could return an object with an additional field id, used to track which icons are already fetched

Can you add a render test for auto packing with a follow up PR?

Can you add a render test for auto packing with a follow up PR?

Issue #2738


Please clarify license for this repo

Hi SofBoxLab team, this is a great code, thats for sharing.
Can you please clarify license for this repo? Hopefully MIT?

Hello @rturk thanks for reaching out.
We're building this linting rules and there are a few things missing. We extended the eslint-config-standard, got some ideas/rules from eslint-config-airbnb-base and also some ideas from TSlint itself to create gandalf-lint.
I've added both the airbnb and standard MIT's license on the README of this repo. Consequently this project is also MIT licensed. I'll add the LICENSE.md soon enough.
Would you like to contribute on this project? We would be much obliged on having your help :)


feat: Persist wallet seed on disk

The same seed is persisted across multiple runs of the application.
XXX: This seed is not encrypted on disk, and should as such not be used in production.

bors r+


Multiple files to  displays only 1st tab

Issue
When multiple files are supplied to <playground-ide>, only the first tab can be seen.

Expected result

You can see the second tab in this example.
Details
I'm loading playground via skypack CDN...
<script
  type="module"
  src="https://cdn.skypack.dev/playground-elements"
></script>

It looks like <mwc-tab-bar> wraps each <playground-tab>; I can see 2 tabs in my DOM, with the correct data bound to the elements, it looks like <mwc-tab-bar> isn't setting a display: flex property correctly however, other styles aren't being set too, like underlining selected tab.
You can see the 2nd tab is in the DOM but overlapped by the content below it...

Here inline style for display: flex was manually added to <mwc-tab-bar> for proof of concept; the orange arrow points to where the style has failed to inherit (not sure why)...

In an attempt reverse engineer, I mimicked the demo: https://polymerlabs.github.io/playground-elements/
...and then loaded the same script that was on the demo page (with code below), it fixes the issue but that source probably isn't a reliable URL, imagine the CDN is best.
<script
  type="module"
  src="https://polymerlabs.github.io/playground-elements/playground-configurator.js"
></script>

Let me know if any other info is needed, thank you for your help :)

Hi @dave52
Is there anything in the console? I have noticed some problems with MWC compponents loading through skypack/unpkg, so it's possible it's an issue there.

@aomarks console looks clean, nothing suspicious in the network tab too :(

Confirmed this is an issue with importing @material/mwc-tab from Skypack. Filed https://github.com/material-components/material-components-web-components/issues/2359.
Unfortunately importing from unpkg.com is also broken, for a different reason. https://github.com/material-components/material-components-web-components/pull/2177 fixed that, but it hasn't been released.
Will look into what we can do.

Oh awesome, thanks for acting so quickly!


Wrong Battlepass Challenge Completion

Describe the bug
For the 2nd week challenges of the BP, if you try to complete the "Like sitting ducks" challenge (defeat 3 trainers), it will instead make progress on the "He's so metal" challenge (catch 3 steelix) instead.
To Reproduce
Steps to reproduce the behavior:

Kill a trainer
Open BP
See steelix challenge progress instead of trainer defeats

Expected behavior
Expected for the correct challenge to be completed
Screenshots

Username:
Oryso
Server name (all applicable):
Orion and Atlas, probably Titan too
Additional context
Add any other context about the problem here.

I believe this is now fixed.


Package request: frab

Project description
Frab is a FOSS conference mangement system
It was removed from nixpkgs with 6fa3728805f04ec367b8f42ba3d3fc77e3d96513 (parent: https://github.com/NixOS/nixpkgs/tree/d25e1ac42605ad063b895d3c8cead3b5a5ae428e/pkgs/servers/web-apps/frab)
Metadata

homepage URL: https://frab.github.io/frab
source URL: https://github.com/frab/frab
license: mit
platforms: linux

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/packaging-a-ruby-project-using-bundlerenv/33770/1


KMAC 3D EHVI updates and [WIP] multiprocessing

This PR adds the python wrapper for Michael Emmerich's C++ 3D EHVI slice update code and also a work-in-progress overhaul of the interface to allow passing in of solver-specific arguments and multiprocessing of the function evaluations.
To call the 3D EHVI acquisition function, ehvi_kmac3d is now a valid acquifunc. Checks have been added to MOBO.py to prevent the exi2D EHVI from being called when there are 3 objectives.
The existing 2D EHVI function has been parallelised and can be accessed via the acquifunc: ehvi_vec. (Maybe we should explicitly change this to ehvi_exi2d or we can pass the complexity to MOBO.py and just have a global setting of ehvi?)
The full vectorisation of uncGA, uncGA_vec, is not yet successful and needs some debugging, as incorrect population members are being returned. For now, the default GA implementation is set to unGA2 - where the original uncGA code has been cleaned up and simple loops vectorised for better speed. The underlying mutation and crossover functions have also been fully vectorised (and confirmed to work as expected). The SBX implementation could do with a review, however. What is the hardcoded n=17? Genetic length? Perhaps this should be a variable.
Better support for SciPy's differential_evolution. Solver arguments can now be explicitly passed in via a de_kwargs dictionary. If cheap constraints are specified in a SciPy non-linear constraint format and passed to the solver using de_kwargs, the cheap constraints are entirely handled by the DE solver, (in aquifunc.py's multiconstfunc, the cheap constraint contribution is set to 1).
ga and diff_evo acquifuncopts now support parallelisation. To have better control of the number of processors being used, the previous parallel kwarg has been changed to n_cpu. The interface updates are reflected in the new sample 3D Problem class placed in KADAL's demo/demo_3d directory. The use of DE's non-linear constraints are also demonstrated. (N.B. These can only be used to DE.) The saving of trained KRiging models is now automatic and can be reloaded with ease.
Currently, to avoid oversubscription on multiple CPUs, I recommend running something like:
OPENBLAS_NUM_THREADS=1 OMP_NUM_THREADS=1 MKL_NUM_THREADS=1 NUMEXPR_NUM_THREADS=1 python mobo_3d.py test3d

-but in the future, perhaps consider setting this automatically in the code using the threadpoolctl package, which seems to be the accepted way to control numpy's multithreading.

Hi @fazaghifari note that the update breaks your parallel keyword! So the other demo files might need to be checked!

Noted, thanks for the info, Tim!


Add emma as a collaborator to dns/dhcp

Hi @elcorbs I have raised a branch PR for this one as this looks to have been a fork. Will get it approved and merged in for you.

Hi @elcorbs I have raised a branch PR for this one as this looks to have been a fork. Will get it approved and merged in for you.


SFC inspection port

@dmitryintel can you confirm that this change does not break the plugins/backward compatibility


in(-1,map_values(null)) only common path throw

There are two ways to reproduce this error.

Download the attached files of the saved input and expression. Then run velox/expression/tests/velox_expression_runner_test --input_path "/home/weihe/fuzzer_repro/velox_vector_xWVO02" --sql_path "/home/weihe/fuzzer_repro/velox_sql_1KLk7v" --result_path "/home/weihe/fuzzer_repro/velox_vector_yChHFS" (change the file paths to yours).
(internal only) Alternatively, check out 078ffeddc and then run velox/expression/tests/velox_expression_fuzzer_test  --velox_fuzzer_enable_complex_types --velox_fuzzer_max_level_of_nesting 2 --only "array_position,in,map_values" --seed<PHONE_NUMBER>.

======> Started iteration 0 (seed:<PHONE_NUMBER>)
I1026 14:25:40.879932 3101312 ExpressionVerifier.cpp:130] Executing expression: in(-1,map_values(null))
I1026 14:25:40.880069 3101312 ExpressionVerifier.cpp:133] 0 vectors as input:
E1026 14:25:40.882357 3101312 Exceptions.h:68] Line: velox/functions/prestosql/InPredicate.cpp:37, Function:toValues, Expression: size > 0 (0 vs. 0) IN list must not be empty, Source: USER, ErrorCode: INVALID_ARGUMENT
E1026 14:25:40.883929 3101312 ExpressionVerifier.cpp:67] Only common path threw exception:
I1026 14:25:40.884773 3101312 ExpressionVerifier.cpp:288] Persisted input at '/home/weihe/fuzzer_repro/velox_vector_xWVO02' and result at '/home/weihe/fuzzer_repro/velox_vector_yChHFS' and sql at '/home/weihe/fuzzer_repro/velox_sql_1KLk7v'
terminate called after throwing an instance of 'facebook::velox::VeloxUserError'
  what():  Exception: VeloxUserError
Error Source: USER
Error Code: INVALID_ARGUMENT
Reason: (0 vs. 0) IN list must not be empty
Retriable: False
Expression: size > 0
Function: toValues
File: velox/functions/prestosql/InPredicate.cpp
Line: 37
Stack trace:
Stack trace has been disabled.Use --velox_exception_user_stacktrace=true to enable it.

*** Aborted at<PHONE_NUMBER> (Unix time, try 'date -d @1666819540') ***
*** Signal 6 (SIGABRT) (0x37b3c002f5280) received by PID 3101312 (pthread TID 0x7f726c78fec0) (linux TID 3101312) (maybe from PID 3101312, UID 228156) (code: -6), stack trace: ***
    @<PHONE_NUMBER>010fee folly::symbolizer::(anonymous namespace)::innerSignalHandler(int, siginfo_t*, void*)
                       ./folly/experimental/symbolizer/SignalHandler.cpp:449
    @<PHONE_NUMBER>00f711 folly::symbolizer::(anonymous namespace)::signalHandler(int, siginfo_t*, void*)
                       ./folly/experimental/symbolizer/SignalHandler.cpp:470
    @<PHONE_NUMBER>000000 (unknown)
    @<PHONE_NUMBER>09c9d3 __GI___pthread_kill
    @<PHONE_NUMBER>0444ec __GI_raise
    @<PHONE_NUMBER>02c432 __GI_abort
    @<PHONE_NUMBER>0a3fd4 __gnu_cxx::__verbose_terminate_handler()
    @<PHONE_NUMBER>0a1b39 __cxxabiv1::__terminate(void (*)())
    @<PHONE_NUMBER>0a1ba4 std::terminate()
    @<PHONE_NUMBER>0a1ec1 __cxa_rethrow
    @<PHONE_NUMBER>01ec9c facebook::velox::test::ExpressionVerifier::verify(std::shared_ptr<facebook::velox::core::ITypedExpr const> const&, std::shared_ptr<facebook::velox::RowVector> const&, std::shared_ptr<facebook::velox::BaseVector>&&, bool)
                       ./velox/expression/tests/ExpressionVerifier.cpp:227
    @<PHONE_NUMBER>095986 facebook::velox::test::ExpressionFuzzer::go()
                       ./velox/expression/tests/ExpressionFuzzer.cpp:727
    @<PHONE_NUMBER>0d8cfd facebook::velox::test::expressionFuzzer(std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::vector<facebook::velox::exec::FunctionSignature const*, std::allocator<facebook::velox::exec::FunctionSignature const*> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::vector<facebook::velox::exec::FunctionSignature const*, std::allocator<facebook::velox::exec::FunctionSignature const*> > > > >, unsigned long)
                       ./velox/expression/tests/ExpressionFuzzer.cpp:754
    @<PHONE_NUMBER>2c30e3 FuzzerRunner::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned long, std::unordered_set<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&)
                       ./velox/expression/tests/FuzzerRunner.h:108
                       -> ./velox/expression/tests/ExpressionFuzzerTest.cpp
    @<PHONE_NUMBER>2c29ac main
                       ./velox/expression/tests/ExpressionFuzzerTest.cpp:57
    @<PHONE_NUMBER>02c656 __libc_start_call_main
    @<PHONE_NUMBER>02c717 __libc_start_main_alias_2
    @<PHONE_NUMBER>2b8b80 _start
                       /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/csu/../sysdeps/x86_64/start.S:116
Aborted (core dumped)

in_map_values_repro.zip

Here, common path does constant folding turning map_values(null) into a null constant. It then attempts to create an instance of a stateful vector function InPredicate with a constant null second argument. The creation throws. Common path doesn't do constant folding and creates an instance of InPredicate with no constant inputs. The creation succeeds. Common path then evaluates inputs to "in" function, eliminates rows where at least one of the inputs is null (in this case all rows are eliminated because second argument is null) and return nulls without calling InPredicate.
First, failures during creation of InPredicate need to be suppressed and re-thrown (via context.setErrors(rows, exception)) if and when InPredicate::apply is called.
Second, constant folding should be more powerful and apply to function calls with constant null inputs. If these have default null behavior they can be constant folded into a null.
CC: @laithsakka @kagamiori @bikramSingh91

@oerling Orri offered to help with this one.

Part of the fix: #2977

Second, constant folding should be more powerful and apply to function calls with constant null inputs. If these have default null behavior they can be constant folded into a null.

I had a PR for the second part back in August: https://github.com/facebookincubator/velox/pull/2007. It was blocked by fuzzer test failures that have the same root cause as https://github.com/facebookincubator/velox/issues/2749 which has been fixed by https://github.com/facebookincubator/velox/pull/2961 recently.

Second, constant folding should be more powerful and apply to function calls with constant null inputs. If these have default null behavior they can be constant folded into a null.

I had a PR for the second part back in August: #2007. It was blocked by fuzzer test failures that have the same root cause as #2749 which has been fixed by #2961 recently.

OK, the PR #2007 is blocked by another fuzzer test failure again. The failure can be reproduced via the following command.
buck-out/gen/velox/expression/tests/velox_expression_fuzzer_test --only "date_format,from_unixtime,replace,chr,substr,regexp_replace,regexp_extract,split_part,url_extract_path,lpad,strrpos,strpos,bitwise_and,truncate,rpad,to_base64,sha512" --seed<PHONE_NUMBER>

Possible fix from @oerling #3189

Looking at this,
actually the current VELOX implementation of in as function is not accurate.
Velox support select 1 in array(1,2,3) and select 1 in reverse(1,2,3) which are not supported in prestoSQL.
I propose that we right IN as special form that have constant list of literals.


Add contributors

This issue chain adds contributors to the repository using allcontributors bot.
The @all-contributors bot automatically adds contributor acknowledgements according to the all-contributors specification ✨
This issue will remain opeen throughout the projecet so new contributors can always be added.

@all-contributors bot please add @JamesSCTJ for ideas, test, and review

@all-contributors bot please add @JamesSCTJ for ideas

@all-contributors bot please add @BrainonSilicon for planning and ideas

@all-contributors bot please add @gedankenstuecke for planning, ideas, code, infrastructure, and tests

@all-contributors bot please add @gedankenstuecke for infrastructure, tests, and code

@all-contributors bot please add @sowmya9507 for planning, ideas, and code

@all-contributors bot please add @sowmya9507 for infrastructure, tests, and code

@allcontributors add @mridubhatnagar for code and infrastructure

@lottycoupat, I thing the bot is @all-contributors instead of @allcontributors. :)

@all-contributors bot please add @mridubhatnagar to the contributor's list.

@all-contributors please add @mridubhatnagar for code and infrastructure

still no response from the bot...

@GeorgiaHCA, yes. Should we re-configure?

Good idea @mridubhatnagar !

Awesome, what I am not sure about is allcontributors bot to work on AutSpaces. It should be configured in the root repo that is alan-turing-institute or AutSpaces repo?

Hmm I think the root repo is the AutSPACEs one - I originally added it to the repo when it was still owned by me and it transfered to The Turing one just fine

oh okay. Should I update the permission then? I hope nothing else breaks.

Hmm good point - I'm not sure what do you reckon could break?

Hmm good point - I'm not sure what do you reckon could break?

Yes makes sense. Nothing would break as such. Worst case scenario is seems to be the bot not working. I'll give it a shot.

Thanks @mridubhatnagar 🤞

@all-contributors please add @mridubhatnagar for code and infrastructure

@GeorgiaHCA all-contributors app says the updation action must be performed by the organization owner.

Closing here, as #329 works


clojure.java.jdbc vs clojure.jdbc

It looks like your library targets the clojure.java.jdbc library, but your documentation and announcements say clojure.jdbc.   These are two separate libraries, so this is bound to add to the confusion that already exists.  You should change any reference from clojure.jdbc to clojure.java.jdbc.
clojure.java.jdbc
clojure.jdbc
Thanks for the library.  I think it does meet a need for postgresql boilerplate.

Thanks, good catch!
Will get this fixed asap.

I believe this issue is now fixed, thanks for bringing it to my attention!


API: Cross-platform / cross-language support

Add unified API in terms of functionality supporting:

.net core 3.1 (azure function extension);
mono 5.12 (azure function extension + custom handler for mono)
python 3.6+ (azure function extension + bindings for python language worker)

Support for mono 5.12 (.net standard 2.0) will be implemented using embedio webserver to listen for requests from Azure Functions Runtime (using Custom Handler). The webserver will be managed within a Singleton (PerperContext) and upon request it will create the corresponding objects (IStream, IContext and etc.).

After removing the hard dependency on Azure functions in 0.7.0, this has been much simpler to implement in each language directly; .NET Core (now 5.0) support remains, Python support was added starting in 01c4f771e550eb37360c600686b181bcf149d88a, and .NET Standard 2.0 support proved unnecessary; therefore this can be closed.


Cannot build Xamarin.iOS App when Azure.Identity Nugets are installed. If I remove them then it builds and runs fine

Originally opened this on the Developer Community site but Microsoft Identity has passed the buck to YOU!  The issue is with Visual Studio MAC (Both Release and Preview) I cannot build a solution if the Azure.Identity nuget is installed.  If I remove it then it builds fine.
The Azure.Identity team responded with this:

Thank you for your feedback!
This happens because:
During the build, we look at all the P/Invokes and figure out which libraries the app needs to link with.
The Microsoft.Identity.Client.Extensions.Msal.dll assembly has a P/Invoke to the dlopen function from the library /System/Library/Frameworks/System.framework/System.
/System/Library/Frameworks/System.framework/System does not exist on iOS, and thus the native linker complains that it can't link with that library.
The Microsoft.Identity.Client.Extensions.Msal.dll assembly comes from this nuget: https://www.nuget.org/packages/Microsoft.Identity.Client.Extensions.Msal/
Looking at their website, the offending code comes from here: https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/blob/c73434602327f5f28322c9be3a9fc217392c93be/src/Shared/Mac/LibSystem.cs#L13-L19
My suggestion would be to file an issue here: https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/new.
Happy coding!

<
I'm not exactly sure why they are having me raise the issue since it is their product that is using your product but I am including a simple Visual Studio MAC solution that replicates the problem.
IdentityTestApp.zip

Here is the last output from the build.  I attached a sample that demonstrates this to the first post.  I think you'll get better info from it.
Here is the last output from VS 2022 Mac Preview that I get talking about the linker and not finding System framework.
MTOUCH : warning MT5215: References to ‘System’ might require additional -framework=XXX or -lXXX instructions to the native linker
MTOUCH : warning MT5215: References to ‘System.Net.Security’ might require additional -framework=XXX or -lXXX instructions to the native linker
MTOUCH : warning MT5215: References to ‘libsecret-1.so’ might require additional -framework=XXX or -lXXX instructions to the native linker
MTOUCH : warning MT5215: References to ‘kernel32’ might require additional -framework=XXX or -lXXX instructions to the native linker
MTOUCH : warning MT5215: References to ‘ntdll’ might require additional -framework=XXX or -lXXX instructions to the native linker
MTOUCH : warning MT5215: References to ‘advapi32’ might require additional -framework=XXX or -lXXX instructions to the native linker
MTOUCH : warning MT5215: References to ‘libsecret-1.so’ might require additional -framework=XXX or -lXXX instructions to the native linker
error MT5209 : Native linking error : framework not found System
MTOUCH : error MT5202: Native linking failed. Please review the build log.
clang : error : linker command failed with exit code 1 (use -v to see invocation)
20 Warning(s)
3 Error(s)
Process exited with code 1, command:
error MT5209 : Native linking error : framework not found System
MTOUCH : warning MT5215: References to 'System' might require additional -framework=XXX or -lXXX instructions to the native linker
MTOUCH : warning MT5215: References to 'System.Net.Security' might require additional -framework=XXX or -lXXX instructions to the native linker
MTOUCH : warning MT5215: References to 'libsecret-1.so' might require additional -framework=XXX or -lXXX instructions to the native linker
MTOUCH : warning MT5215: References to 'kernel32' might require additional -framework=XXX or -lXXX instructions to the native linker
MTOUCH : warning MT5215: References to 'ntdll' might require additional -framework=XXX or -lXXX instructions to the native linker
MTOUCH : warning MT5215: References to 'advapi32' might require additional -framework=XXX or -lXXX instructions to the native linker
MTOUCH : warning MT5215: References to 'libsecret-1.so' might require additional -framework=XXX or -lXXX instructions to the native linker
MTOUCH : error MT5202: Native linking failed. Please review the build log.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -framework CoreFoundation -framework Security -framework CFNetwork -framework SafariServices -framework QuickLook -framework LocalAuthentication -framework ContactsUI -framework SystemConfiguration -framework Photos -framework OpenGLES -framework MobileCoreServices -framework MessageUI -framework MediaPlayer -framework ImageIO -framework GLKit -framework WebKit -framework Foundation -framework CoreVideo -framework CoreText -framework CoreTelephony -framework CoreSpotlight -framework CoreMedia -framework CoreLocation -framework CoreGraphics -framework QuartzCore -framework Contacts -framework AuthenticationServices -framework UIKit -framework AVKit -framework AVFoundation -framework GSS -weak_framework System /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/registrar.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/main.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/SimpleBlobManager.iOS.exe.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/mscorlib.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Xamarin.Forms.Core.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Core.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Mono.Security.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Xml.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Numerics.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Data.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Drawing.Common.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Net.Http.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Xamarin.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Runtime.Serialization.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.ServiceModel.Internals.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Web.Services.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Xml.Linq.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Xamarin.Forms.Platform.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Xamarin.Forms.Platform.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/SimpleBlobManager.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Xamarin.Forms.Xaml.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Microsoft.Azure.Management.Storage.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Microsoft.Rest.ClientRuntime.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Newtonsoft.Json.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Microsoft.Rest.ClientRuntime.Azure.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Azure.Storage.Blobs.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Azure.Core.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Microsoft.Bcl.AsyncInterfaces.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Text.Json.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Text.Encodings.Web.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Runtime.CompilerServices.Unsafe.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Memory.Data.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Diagnostics.DiagnosticSource.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Azure.Storage.Common.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.IO.Hashing.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Plugin.Fingerprint.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.Buttons.XForms.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.Core.XForms.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.Licensing.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Xamarin.Essentials.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/OpenTK-1.0.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfBusyIndicator.XForms.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfComboBox.XForms.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfListView.XForms.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.GridCommon.Portable.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.DataSource.Portable.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Microsoft.CSharp.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfNumericTextBox.XForms.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Azure.Identity.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Microsoft.Identity.Client.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Microsoft.Identity.Client.Extensions.Msal.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/System.Security.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Azure.Storage.Blobs.Batch.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Microsoft.IdentityModel.Clients.ActiveDirectory.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.Compression.Portable.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.XlsIO.Portable.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Xamarin.CommunityToolkit.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Microsoft.AppCenter.Analytics.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Microsoft.AppCenter.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Microsoft.AppCenter.iOS.Bindings.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Microsoft.AppCenter.Analytics.iOS.Bindings.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Microsoft.AppCenter.Crashes.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Microsoft.AppCenter.Crashes.iOS.Bindings.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfComboBox.XForms.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.Core.XForms.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfBusyIndicator.XForms.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfBusyIndicator.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfPicker.XForms.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfPicker.XForms.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfPicker.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfListView.XForms.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.Expander.XForms.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.Expander.XForms.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfRangeSlider.XForms.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfRangeSlider.XForms.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfRangeSlider.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfPopupLayout.XForms.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfPopupLayout.XForms.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.Buttons.XForms.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfBadgeView.XForms.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfBadgeView.XForms.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfChart.XForms.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfChart.XForms.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfPullToRefresh.XForms.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfPullToRefresh.XForms.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfNumericTextBox.XForms.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/Syncfusion.SfNumericTextBox.iOS.dll.o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/AppCenter.a /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/AppCenterAnalytics.a /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/SDKs/MonoTouch.iphoneos.sdk/lib/libmonosgen-2.0.a /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/SDKs/MonoTouch.iphoneos.sdk/lib/libxamarin.a /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/SDKs/MonoTouch.iphoneos.sdk/lib/libmono-native-unified.a -force_load /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/AppCenterCrashes.a -force_load /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/SDKs/MonoTouch.iphoneos.sdk/lib/libapp.a -lsqlite3 -lc++ -Wl,-pie -arch arm64 -miphoneos-version-min=14.3 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS15.5.sdk -lz -liconv -lz -o /Users/jnorton/Documents/GitHub/SimpleBlobManager/SimpleBlobManager/SimpleBlobManager.iOS/obj/iPhone/Release/mtouch-cache/arm64/SimpleBlobManager.iOS -u _xamarin_log -u _xamarin_release_managed_ref -u _xamarin_set_gchandle_with_flags_safe -u _UIApplicationMain -u _xamarin_find_protocol_wrapper_type -u _xamarin_release_block_on_main_thread -u _xamarin_get_block_descriptor -u _xamarin_IntPtr_objc_msgSend_IntPtr_exception -u _xamarin_IntPtr_objc_msgSendSuper_IntPtr_exception
ld: framework not found System
clang : error : linker command failed with exit code 1 (use -v to see invocation)
Done building target “_CompileToNative” in project “SimpleBlobManager.iOS.csproj” – FAILED.
Done building project “SimpleBlobManager.iOS.csproj” – FAILED

@norton287 - do you get the same when you build via the command line, i.e. dotnet build or msbuild ?
And what is the target framework of your project ?

same from the command line.  it's xamarin.forms so netstandard 2.0

@SameerK-MSFT - can you please take a look at this? This would block development on MacOS when app is using Azure SDK. The error seems wrong and does not seem to appear on Windows.
@norton287 - we'll need to contact .NET folks / Xamarin folks for this. This works fine on Windows, so this seems to be a bad warning.

It also works fine on Android as well.
Get the app here:
From: Bogdan Gavril<EMAIL_ADDRESS>Reply: AzureAD/microsoft-authentication-extensions-for-dotnet<EMAIL_ADDRESS>Date: June 6, 2022 at 9:57:00 AM
To: AzureAD/microsoft-authentication-extensions-for-dotnet<EMAIL_ADDRESS>CC: John Norton @.@.), Mention<EMAIL_ADDRESS>Subject: Re: [AzureAD/microsoft-authentication-extensions-for-dotnet] Cannot build Xamarin.iOS App when Azure.Identity Nugets are installed. If I remove them then it builds and runs fine (Issue #180)

@SameerK-MSFT(https://github.com/SameerK-MSFT) - can you please take a look at this? This would block development on MacOS when app is using Azure SDK. The error seems wrong and does not seem to appear on Windows.
@norton287(https://github.com/norton287) - we'll need to contact .NET folks / Xamarin folks for this. This works fine on Windows, so this seems to be a bad warning.
—
Reply to this email directly, view it on GitHub(https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/180#issuecomment-1147541331), or unsubscribe(https://github.com/notifications/unsubscribe-auth/AKBF5PGNKZTSOVGBYHMOMUDVNYGTZANCNFSM5XZ44ZSQ).
You are receiving this because you were mentioned.Message ID: @.***>
[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/180#issuecomment-1147541331", "url": "https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/180#issuecomment-1147541331", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Was thinking about this some more, here's what I think happens:

AzureIdentity is built for netstandard2.0
AzureIdentity references Microsoft.Identity.Client.Extensions.Msal which is built for netstandrd 2.0 as well

NetStandard means the library is compatible with any target framework which uses MSAL, but this is not in fact the case for mobile targets. Microsoft.Identity.Client.Extensions.Msal only works on desktop OS - Windows, Mac, Linux.
I am actually not sure how to mark Microsoft.Identity.Client.Extensions.Msal as "do not use" on mobile targets...
But I'm pretty sure that Azure.Identity is not meant to be used from mobile targets - I doubt that there are docs around it. Identity libraries are very much tied to the OS features, because we need to pop-up webviews and to perform encryption at rest.
My recommendation here to unblock you is for you to use Microsoft.Identity.Client library directly. It's a bit lower level that Azure.Identity, but we do have samples for Xamarin: https://github.com/Azure-Samples/active-directory-xamarin-native-v2

The reason I am using Azure.Identity is because it was recommended by Azure support for use of either InteractiveBrowserCredential or ClientSecretCredential which are ok for use on mobile since they are considered PERSONAL credentials. I need a credential to authenticate my production app to storage. Have been using a connection string but users seem to have some issue with copy and paste for some reason and it causes issues.
But the Azure Identity guys recommended those two TokenCredential givers to me for use in my Xamarin App.
From: Bogdan Gavril<EMAIL_ADDRESS>Reply: AzureAD/microsoft-authentication-extensions-for-dotnet<EMAIL_ADDRESS>Date: June 6, 2022 at 3:41:49 PM
To: AzureAD/microsoft-authentication-extensions-for-dotnet<EMAIL_ADDRESS>CC: John Norton @.@.), Mention<EMAIL_ADDRESS>Subject: Re: [AzureAD/microsoft-authentication-extensions-for-dotnet] Cannot build Xamarin.iOS App when Azure.Identity Nugets are installed. If I remove them then it builds and runs fine (Issue #180)

Was thinking about this some more, here's what I think happens:
AzureIdentity is built for netstandard2.0
AzureIdentity references Microsoft.Identity.Client.Extensions.Msal which is built for netstandrd 2.0 as well
NetStandard means the library is compatible with any target framework which uses MSAL, but this is not in fact the case for mobile targets. Microsoft.Identity.Client.Extensions.Msal only works on desktop OS - Windows, Mac, Linux.
I am actually not sure how to mark Microsoft.Identity.Client.Extensions.Msal as "do not use" on mobile targets...
But I'm pretty sure that Azure.Identity is not meant to be used from mobile targets - I doubt that there are docs around it. Identity libraries are very much tied to the OS features, because we need to pop-up webviews and to perform encryption at rest.
My recommendation here to unblock you is for you to use Microsoft.Identity.Client library directly. It's a bit lower level that Azure.Identity, but we do have samples for Xamarin: https://github.com/Azure-Samples/active-directory-xamarin-native-v2
—
Reply to this email directly, view it on GitHub(https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/180#issuecomment-1147904492), or unsubscribe(https://github.com/notifications/unsubscribe-auth/AKBF5PARFGXYIHQVHXPCTBLVNZPA3ANCNFSM5XZ44ZSQ).
You are receiving this because you were mentioned.Message ID: @.***>
[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/180#issuecomment-1147904492", "url": "https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/180#issuecomment-1147904492", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Well  I have been using and testing both the ClientSecretCredential and the InteractiveBrowserCredential on Android and UWP for like a couple of months now.  I really want  to use InteractiveBrowserCredential since it requires less credentials and secures the app better since it is a storage app.  And storage will only take a Credential, so InteractiveBrowserCredential fits the bill perfectly.
So if you can fix the iOS issue I can stop running parallel code In my production app and move everything together again and save the pain of having to maintain a fork just for iOS.

I'm sorry, I don't know how to fix this, but am happy to be educated. Maybe the issue is on Xamarin SDK or the analyzer which breaks the build?

The only one with this issue is iOS and Azure.Identity broke it down to this like I quoted in the first post.

Thank you for your feedback!
This happens because:
During the build, we look at all the P/Invokes and figure out which libraries the app needs to link with.
The Microsoft.Identity.Client.Extensions.Msal.dll assembly has a P/Invoke to the dlopen function from the library /System/Library/Frameworks/System.framework/System.
/System/Library/Frameworks/System.framework/System does not exist on iOS, and thus the native linker complains that it can't link with that library.
The Microsoft.Identity.Client.Extensions.Msal.dll assembly comes from this nuget: https://www.nuget.org/packages/Microsoft.Identity.Client.Extensions.Msal/
Looking at their website, the offending code comes from here: https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/blob/c73434602327f5f28322c9be3a9fc217392c93be/src/Shared/Mac/LibSystem.cs#L13-L19
My suggestion would be to file an issue here: https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/new.
Happy coding!

<
So, I'm not sure the others will even touch it with that in the air.

Try building my sample solution with your expertise and see where I need to go?  I mean you can tell more than I can.

The fix is simple: change the library name to be /usr/lib/libSystem.dylib instead of /System/Library/Frameworks/System.framework/System (/usr/lib/libSystem.dylib exists on all Apple platforms)

Thanks for the suggestion @rolfbjarne - the integration tests seem to pass, so I'm happy to take this. We'll probably do a release by end of week / mid next week.

@rolfbjarne @bgavrilMS Thanks a lot guys really appreciate it very very very very very much!

I build a Maui app from the template in Visual Studio 2022, ver. 17.3.1. Upgraded to the latest NuGet packages. Installed Microsoft.Identity.Client.Extensions.Msal 2.23.0 and added this code to the OnCounterClicked method of MainPage.xaml.cs:
        var signInApplication = PublicClientApplicationBuilder
            .Create("6a7fefdb-47b3-4a25-87a3-593c12a4115b")
            .WithIosKeychainSecurityGroup("com.microsoft.adalcache")
            .WithRedirectUri("msal6a7fefdb-47b3-4a25-87a3-593c12a4115b://auth")
            .WithB2CAuthority(@"https://thetarexproduction.b2clogin.com/tfp/thetarexproduction.onmicrosoft.com/B2C_1_SignIn")
            .Build();
        var accounts = await signInApplication.GetAccountsAsync("B2C_1_SignIn").ConfigureAwait(false);
        string[] scopes = new string[]
        {
            "https://aspen-asset-management.com/a47aac20-2077-4910-8cb6-b4bf32069c0b/read",
            "https://aspen-asset-management.com/a47aac20-2077-4910-8cb6-b4bf32069c0b/write"
        };
        AuthenticationResult authenticationResult = await signInApplication.AcquireTokenSilent(scopes, accounts.FirstOrDefault())
            .ExecuteAsync(CancellationToken.None)
            .ConfigureAwait(false);
        this.User = authenticationResult.ClaimsPrincipal;

The result is:
clang++ exited with code 1
This means that no one can build a Maui application that uses MSAL.

We're having same issue with the MSAL sample app for iOS after updating the Nugets to the latest Microsoft.Identity.Client 4.46.2. Also tried installing the transitive dependency for Microsoft.IdentityModel.Abstractions as noticed that was bringing in the min version which was a few off the latest - made no difference. @norton287 can you confirm if the nugets fixed the issue for you? @bgavrilMS Can this issue be reopened, or should we log a new issue?

@DRAirey1 - can you please open a bug on the MSAL repo for this?
@breenbob - I think a new issue should be opened on the MSAL repo - https://github.com/AzureAD/microsoft-authentication-library-for-dotnet

It looks like someone already fixed this. If you install the pre-release of the MSAL package, the problem goes away:
    <PackageReference Include="Microsoft.Identity.Client" Version="4.46.0-preview2" />
    <PackageReference Include="Microsoft.Identity.Client.Extensions.Msal" Version="2.22.0" />

Just push this into production and it should get rid of the problem.

@DRAirey1 @bgavrilMS have not tried 4.46.0-preview2 because there are 4 releases since that release all with same or higher version number, so assumed it was an outdated preview. Targeting the very latest 4.46.2 packages does not fix the issue, so I guess whatever fix was implemented has regressed somehow? Will check 4.46.0-preview2 anyway though just to see if it leaves us with a working version, thanks.

Will check 4.46.0-preview2 anyway though just to see if it leaves us with a working version, thanks.

It allowed me to build a MAUI application and deliver it through the App Store.

@breenbob @bgavrilMS @DRAirey1
I tried with 3 different versions today and and found that Version 4.46.2 is giving clang++ error in ios while building the app. However, the latest version (4.47.0), recently launched, and 4.46.0-preview2 versions works well in Android and iOS both platforms and gives me the Access Token after B2C login.

Only MSAL 4.47.0 and 4.46.0-preview2 have MAUI support. You can check this on nuget by looking at the Frameworks tab. We will be shipping MAUI in each version from now on.

You can check this on nuget by looking at the Frameworks tab

Could you help us out please. It would be useful, in the future, to know what we're getting when we install these packages. How do I determine that this release supports MAUI from this display:

@DRAirey1 - MSAL does 3 things which are highly tied to a specific platform:

pops up browsers (embedded browsers or system browsers)
talks to brokers (Authenticator on mobile / WAM on Windows, tbd on Mac / Linux)
stores tokens in an encrypted location (KeyChain on ios etc.)

Each of these have different implementation on Android, iOS, Windows, Mac and Linux.
net6-android / net6-ios / net6-windows are typical for MAUI and MSAL will keep releasing them with each version from now on. Please have a look at the sample for details on how to integrate MSAL - https://github.com/Azure-Samples/active-directory-xamarin-native-v2/tree/main/MAUI

So when I say I am using InteractiveBrowserCredential on Android and UWP you are saying I’m lying?  Seriously?  I have been a CISSP for 18 years and  I can safely say that ANY mobile device is a 100% more secure than any ZeroDay ridden Windows machine as far as security.  I had over my 15 year career as a penetration tester 100% success accessing servers, desktops, laptops but in the last 6 years phones have been hardened in the corporate sector beyond belief with trip-wire encryption and containerization.
So don’t ever call me a lier when I say I have been running something for quite a while.

From: Bogdan Gavril @.>
Reply: AzureAD/microsoft-authentication-extensions-for-dotnet @.>
Date: June 7, 2022 at 9:37:08 AM
To: AzureAD/microsoft-authentication-extensions-for-dotnet @.>
Cc: John Norton @.>, Mention @.***>
Subject:  Re: [AzureAD/microsoft-authentication-extensions-for-dotnet] Cannot build Xamarin.iOS App when Azure.Identity Nugets are installed. If I remove them then it builds and runs fine (Issue #180)
ClientSecretCredential should not be used on a mobile device. You cannot securily store a secret / cert on a mobile device or on a desktop app. ClientSecretCredential is meant for web sites and web APIs, where you can secure the backend. Our SDK does not even enable this flow on mobile.
InteractiveBrowserCredential is the recommended path indeed at a logical level, but I am not convinced that Azure.identity was ever tested on mobile and I doubt it works. Microsoft.identity.Client is a lower level SDK, so our API is slightly more complex, but we do have samples for Xamarin: https://github.com/Azure-Samples/active-directory-xamarin-native-v2
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/180#issuecomment-1148763436", "url": "https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/180#issuecomment-1148763436", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

I gave up on it.  Identity never incorporated the fix as far as I could tell.  Identity has made their dislike of mobile a little to well known for my tastes.
From: Conor Breen<EMAIL_ADDRESS>Reply: AzureAD/microsoft-authentication-extensions-for-dotnet<EMAIL_ADDRESS>Date: September 16, 2022 at 9:56:25 AM
To: AzureAD/microsoft-authentication-extensions-for-dotnet<EMAIL_ADDRESS>CC: John Norton<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject:  Re: [AzureAD/microsoft-authentication-extensions-for-dotnet] Cannot build Xamarin.iOS App when Azure.Identity Nugets are installed. If I remove them then it builds and runs fine (Issue #180)
We're having same issue with the MSAL sample app for iOS after updating the Nugets to the latest Microsoft.Identity.Client 4.46.2. Also tried installing the transitive dependency for Microsoft.IdentityModel.Abstractions as noticed that was bringing in the min version which was a few off the latest - made no difference. @norton287https://github.com/norton287 can you confirm if the nugets fixed the issue for you? @bgavrilMShttps://github.com/bgavrilMS Can this issue be reopened, or should we log a new issue?
—
Reply to this email directly, view it on GitHubhttps://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/180#issuecomment-1249471983, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKBF5PF2JKUVS23MYHVEGIDV6SDBTANCNFSM5XZ44ZSQ.
You are receiving this because you were mentioned.Message ID: @.***>

I'm sorry if you have a bad experience with the libs or if you feel insulted @norton287 . It was not my intention. Yes you can use InteractiveBrowserCredential on UWP and iOS, I'm just saying that Azure SDK do not test those scenarios.
The bug mentioned in this thread has been fixed as per recommendation from Xamarin folks. For any other bugs, please open new issues or comment on existing ones.

No I was saying at the time I tested several Identity builds after the iOS fix was done and still got the crash from before.  I think the never included the fix until later on, but it was frustrating so I gave up.  It is just a bad situation, they don’t even have Android set to launch the mobile browser for InteractiveBrowserCredential logins so it is something I really cannot use.  But I am glad the iOS fix is in now and working well!
John
From: Bogdan Gavril<EMAIL_ADDRESS>Reply: AzureAD/microsoft-authentication-extensions-for-dotnet<EMAIL_ADDRESS>Date: October 11, 2022 at 3:18:52 AM
To: AzureAD/microsoft-authentication-extensions-for-dotnet<EMAIL_ADDRESS>Cc: John Norton<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject:  Re: [AzureAD/microsoft-authentication-extensions-for-dotnet] Cannot build Xamarin.iOS App when Azure.Identity Nugets are installed. If I remove them then it builds and runs fine (Issue #180)
I'm sorry if you have a bad experience with the libs or if you feel insulted @norton287https://github.com/norton287 . It was not my intention. Yes you can use InteractiveBrowserCredential on UWP and iOS, I'm just saying that Azure SDK do not test those scenarios.
The bug mentioned in this thread has been fixed as per recommendation from Xamarin folks. For any other bugs, please open new issues or comment on existing ones.
—
Reply to this email directly, view it on GitHubhttps://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/180#issuecomment-1274287246, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKBF5PDWYFXAHZGMGOVVC5TWCUPGNANCNFSM5XZ44ZSQ.
You are receiving this because you were mentioned.Message ID: @.***>

I'm not sure about mobile as it builds fine for Android and UWP. I have been running interactive browser credential on those two with no issues. just iOS has build problems with the identity nuget.
they have pretty much flagged everything that is not mobile friendly with platform not supported messages.
From: Bogdan Gavril<EMAIL_ADDRESS>Reply: AzureAD/microsoft-authentication-extensions-for-dotnet<EMAIL_ADDRESS>Date: June 6, 2022 at 3:41:49 PM
To: AzureAD/microsoft-authentication-extensions-for-dotnet<EMAIL_ADDRESS>CC: John Norton @.@.), Mention<EMAIL_ADDRESS>Subject: Re: [AzureAD/microsoft-authentication-extensions-for-dotnet] Cannot build Xamarin.iOS App when Azure.Identity Nugets are installed. If I remove them then it builds and runs fine (Issue #180)

Was thinking about this some more, here's what I think happens:
AzureIdentity is built for netstandard2.0
AzureIdentity references Microsoft.Identity.Client.Extensions.Msal which is built for netstandrd 2.0 as well
NetStandard means the library is compatible with any target framework which uses MSAL, but this is not in fact the case for mobile targets. Microsoft.Identity.Client.Extensions.Msal only works on desktop OS - Windows, Mac, Linux.
I am actually not sure how to mark Microsoft.Identity.Client.Extensions.Msal as "do not use" on mobile targets...
But I'm pretty sure that Azure.Identity is not meant to be used from mobile targets - I doubt that there are docs around it. Identity libraries are very much tied to the OS features, because we need to pop-up webviews and to perform encryption at rest.
My recommendation here to unblock you is for you to use Microsoft.Identity.Client library directly. It's a bit lower level that Azure.Identity, but we do have samples for Xamarin: https://github.com/Azure-Samples/active-directory-xamarin-native-v2
—
Reply to this email directly, view it on GitHub(https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/180#issuecomment-1147904492), or unsubscribe(https://github.com/notifications/unsubscribe-auth/AKBF5PARFGXYIHQVHXPCTBLVNZPA3ANCNFSM5XZ44ZSQ).
You are receiving this because you were mentioned.Message ID: @.***>
[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/180#issuecomment-1147904492", "url": "https://github.com/AzureAD/microsoft-authentication-extensions-for-dotnet/issues/180#issuecomment-1147904492", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]


Add support for Next.js app structure

Next.js 13 is now out and it released the new layout system under the new app folder.
Is it something this package is interested in adopting?

The route structure is slightly different in that folder and both app and pages can be used at the same time so the tool would have to be able to merge the two route structures.

Yes this is definitely something I intend to support. Good call out on supporting both directories at the same time. I think the only remaining piece is checking out the next documentation to get the list of filenames / directories to exclude (eg layouts).

This has been released in 0.1.7


Identify integer percent dates and flag them

To allow the Zapier action to decide whether or not to continue in the case where you only want to take further actions on integer percenages (ie. 30%, 29%, 28%), the script must identify these cases and add a boolean value to the output variable.

Solved in commit 7e9fad3


modify ci file name

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

rename the ci.yml file of template under “sdk/template/.content/testResource/ci.yml” to avoid pipeline tool creating pipeline for it. issue: https://github.com/Azure/azure-sdk-for-net/issues/29123

Fix https://github.com/Azure/azure-sdk-for-net/issues/29123


Add limit to user balance

@vtomole we need to add a limit for internal users (us), right? What did we agree on that being?

@paaige  limit will be the same for both internal and external users.

This change needs to be done server side because I can still use the Swagger UI to go above this limit.

Yeah, I think we should do both, because most users are using the API programmatically and on the client side it seems better to fail first before sending a request

I think we should do both

One thing i'm worried about doing this twice is that it will slip past review in the future. If this limit is ever changed, the reviewer will have to remember that it needs to changed in 2 places.

Sister PR: #2470


"Oops, couldn't connect."

I launched the app in Windows on a PC. I set the preferences: medium quality and highest prices per hour and GB; country selections: Canada and the US. I tried over 20 different connections and every single time, I got a message "Oops! couldn't connect. Try another provider?" What is the reason for this? I was unable to find a single provider that worked.

The reason is the devs probably abandoned this because they don't care and haven't committed anything since January because they're too busy working on their next scam, which is the regular VPN client for phones which charges you $10 flat rate, instead of allowing you to buy their scam token (that only they use) to only be used when you need it.

@DilAw10 This is most likely due to a network related issue. Could you please try following this help article: https://help.mysteriumvpn.com/en/articles/8041432-troubleshooting-oops-could-not-connect-issues-in-legacy-mysterium-vpn-app-step-by-step-guide
If that does not help, please let me know and I will investigate your logs to find out exactly what the issue is. 😊
Looking forward to an update from ya!

@gir489returns
We apologise for any negative experience you may have had with our token or network. Rest assured, we are continuing to improve the daily lives of thousands of people experiencing first hand the adverse effects of government censorship. Our legacy app is one of the most cost-effective in the entire VPN industry, as well as one of the few VPNs that offer truly residential nodes. However, we understand that not everyone is tech-savvy and needs a simpler solution. That's why we're introducing our new app, which offers a user-friendly experience without the need for passwords, private keys, etc... For privacy-conscious users, the legacy app remains available. Our goal is to provide the best user experience for all. If you care about cost over convenience, you are welcome to use our Legacy apps
Additionally, I have great news for ya! We have not abandoned the legacy apps. We may have temporarily reduced hours spent on the old app, but are still improving the app and assisting our users who prefer the Legacy app every single day, including weekends. If you have any feature requests you are more than welcome to report them here: https://github.com/mysteriumnetwork/mysterium-vpn-desktop/issues/new?assignees=&labels=enhancement&projects=&template=feature_request.md&title=[feature+request]
I will personally look into them and implement the changes when necessary. 😉
Thanks for your feedback brother!

I think it has something to do with the ports or firewall. Are there any ports I should open or forward on my router?

I have the same problem, I hope it can be fixed in another update. Could it be other VPN's network configuration messing it up?


[Bug]: When no session is selected in the data source session window, there are no buttons to close the session or close the query

ODC version
odc432
OB version

What happened?

What did you expect to happen?

How can we reproduce it (as minimally and precisely as possible)?
View sessions in the database
Anything else we need to know?
No response

Fixed In Commit 2c524061531005196c4e543a39c6b662cac1714c
------
畅晚
Mon Sep 2 10:10:14 2024 +0800

pass


Scaffolding

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

PR done by mistake


Adding Showcase Apps - Image Handling and Print QR App

Adding 2 apps:

Image Handling App
Printing and QR Generator App

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


iterative machine unit test

Tests that train 3 models:

Complete train till convergence
Train with max number of iteration set low at x
Train a model then prematurely stop it at x iterations, the continue training till convergence

The results are compared to ensure proper state update in every iteration.
Eventually we would want this done automatically for all Iterative Machines.

@karlnapf this solves the problem for now :) The CI seems to be acting weird but :/

The problem was we needed to make sure features do not change when we resume training. We have locally stored the features here that we will not be changed which solves our problem.

ok cool, so let's change the type to generic features and then merge this  and move on ! :)

Ok cool
PR CI builds are currently not active, so you will need to check all tests locally
If you give your ok we can merge (and then closely look at the CI and buildbot outputs)
Shall I? :)

alright ! lets merge it

Ok pls have an eye on the buoldbot and the new azure builds

azure seems fine: https://dev.azure.com/shogunml/shogun/_build?definitionId=2

Cool!
Now what was next? :)

now lets look into the automated tests for this

I have a local branch with an initial attempt on this, but not complete. Will share it


Do again the migration of mangas to mangasData because you forget isbn and genre

The script is already modified so take and hour and do it again, don't forget to retrieve the name of the mangas and cover of the mangas to create a script to gain time

Done


Add Support For Specific 190 Courses

This is a minor suggestion, but currently we see from PPAPI in PeterPortal that all 190 courses are treated as identical.
For example, there are several different MGMT 190 courses that are offered across different quarters.
For the sake of clearer grade distributions / more detailed course descriptions, would it be feasible to look into having separate entries for each specific type of 190 course?

Oops meant to open this for PPAPI not here


Hello World app for Wave Tour

For https://github.com/h2oai/wave/issues/353
Previously there was only a hello world wave script in Wave Tour. This will add a hello world app to the Wave Tour.

Closing this because the counter app is already there to demonstrate the interactivity


HDDS-4926. Support start/stop for container balancer via command line

What changes were proposed in this pull request?
Support start/stop for container balancer via command line
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4926
How was this patch tested?
unit and acceptance tests

@lokeshj1703 PTAL

@adoroszlai Hey，can you help having a look at this CI problem TestReportPublisher.testCRLStatusReportPublisher? it seems nothing to do with my PR, i do not modify any CRL related code.

Hey，can you help having a look at this CI problem TestReportPublisher.testCRLStatusReportPublisher? it seems nothing to do with my PR, i do not modify any CRL related code.

Yes, it's unrelated.  #2302 fixes it.  Please wait for that to be merged first.

thanks @adoroszlai for looking at this!

Yes, it's unrelated. #2302 fixes it. Please wait for that to be merged first.

will wait for that!

@GlenGeng @ChenSammi @siddhantsangwan Do you have any other comments?

thanks @ChenSammi for the review, i have fix the comment.PTAL!

Thanks @JacksonYao287 for working on this.  The path LGTM, only several small issues.

Thank @siddhantsangwan for the review, i have fixed the comment, PTAL!

The last patch LGTM, +1.  Thanks @JacksonYao287  for the contribution and @lokeshj1703 @siddhantsangwan for code review.


Integration does not register all received sensors

Hello Dominik,
I used original integration from junalmeida for some time. Since it has not been updated for some time and also because i experienced some problems I deinstalled it. As a replacement I found an unfinished torque integration based on ha internal torque code. However this version does take care of making sensors permanent. Since this version ( I installed it as custom_component) is not supported at all, I  installed your fork of junalmeidas bits. It is working in general but: it has same weakpoints as original bits:

after restart of HA (or restart of torque_logger) errormessage: "Missing profile name from torque data.". As a consequence no sensor data are updated
not all of my configured and in HA received data are  registered as torque sensors
Since I am owner of an electriv vehicle "standard" sensors are not that interesting for me.

I went back to fully unsupported solution thus I cannot provide any logs. But if you want me to do that  I would deactivat current integration and activate yours again. However this is only useful if you are willing to investigate a bit furhter into both issues.
The unsupported integration I am using currently does use torques user-id along with carname to configure integration.
Here is the link to the repository I used to create a custom_component from HA core bits: https://github.com/skyborgff/core/tree/dev/homeassistant/components/torque
Maybe it can provide some ideas for you how to workaround the weaknesses of your current implementation.
Unfortunately my coding abilitities are very limited. So I cant :-(
PS: I had to change some code in init.py of above code in order to get it working, because there were deprecated functions used...
If it would be of help I can provide my custom_component torque setup as tar file...
My setup generally is:
I have a dedicated mobilephone in my car whis is permanently connected to my OBDII adapater, sending permanently telemtry data like:
position, speed, battery charge status, triptime, trip distance
I am using this for generating fully automated driving logbook but also for having history data for electrical consumption of my car.
Regards
Gerhard

First you can try to use the beta version of this integration, It should get more sensors from the ODB interface:
https://github.com/DominikWrobel/homeassistant-torque/releases/tag/v1.3
I'm also not a programmer, I'm just trying to keep this integration working as long as I can since I use it. If the beta version still is missing some info I will have to find out how to get info from the torque app.
As for the restarts and no data - I don't have this problem, If you can provide logs it would be great.

Give me information about what kind of car you have (I'll try to find it), and what obd2 you use, preferably links to some store.
P.S. I also lack some functionality, maybe I'll work on it later!


Record.pick & Record.omit

Struct.omit now behaves more sensibly, however this leaves a space where a Record.omit should be. Record.pick should possibly be included too for symmetry?
omit :: Array string -> Record string a -> Record string a

export const omit = (xs: Array<string>): (<A>(y: Record<string, A>) => Record<string, A>) =>
  R.filterWithIndex(A.elemV(Str.Eq)(xs));

Is there any reason no one has done this? I could probably find some time to toss such a change in this weekend

No reason, I've just had less energy in the last few months so my own open source contributions have been a bit slower. I'll review any PRs if you'd like to contribute. 🙂

https://github.com/samhh/fp-ts-std/commit/ebb3ecb39837c2320b32d0d58a98e4f2a6c062c4 & https://github.com/samhh/fp-ts-std/commit/759201d365ef4e9d217c171f256652e6c807d826

@samhh is a god among men


Apache Phoenix support

I will appreciate if you add support for Apache Phoenix as it is JDBC driver over HBase

+1. Would love to see Phoenix support as well. The pull request is here: https://github.com/flyway/flyway/pull/1012

Duplicate of #929


Help subcommand for custom primary command prints wrong usage.

The help subcommand for primary commands prints the default docstring instead of trying to print the custom usage string.

If the primary command is overwritten, the help subcommand must be implemented by the new primary command as we have no way of knowing what commands or options it supports.


Remove Diskuv.opam 2.2.0-alpha0-20221104 prerelease

The prereleases like 2.2.0-beta3 are "before" 2.2.0 in the ARP sort order.
Removing the prereleases makes 2.2.0 the latest as it should be, and removes versions that no one should be using.
fixes https://github.com/ocaml/opam/issues/6096
Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/diskuv/dkml-installer-opam/releases/download/2.2.0-alpha0-20221104/setup-opam-windows_x86-2.2.0.alpha0.20221104.exe
OK
(Automated message - build 911)

https://github.com/microsoft/winget-pkgs/issues/142854


jBPM Installer updated for Eclipse Neon

@bbrodt This looks like a duplicate of https://github.com/droolsjbpm/jbpm/pull/551 -- Is that the case or is there something I'm missing?

+1 (it's master vs 6.5.x)


HTTP 202 C# generated client throws exception

Using NSwag.MSBuild 11.17.0
Code generation command:
<Exec Command="$(NSwagExe) swagger2csclient /input:$(ProjectDir)\XXX.swagger.json /output:$(ProjectDir)\XXX.generated.cs /Namespace:XXX /ClientBaseClass:XXX /UseHttpRequestMessageCreationMethod:true /ConfigurationClass:XXX /UseHttpClientCreationMethod:true /GenerateOptionalParameters:true /ClassStyle:Poco" />
The C# generated code for a 202 response always throws an exception.  Is this by design?  2xx codes are supposed to be non error.
Generated code looks like:
if (status_ == "202")
{
	var responseData_ = await response_.Content.ReadAsStringAsync().ConfigureAwait(false);
	var result_ = default(xxx);
	try
	{
		result_ = Newtonsoft.Json.JsonConvert.DeserializeObject<xxx>(responseData_, _settings.Value);
	}
	catch (System.Exception exception_)
	{
		throw new SwaggerException("Could not deserialize the response body.", (int)response_.StatusCode, responseData_, headers_, exception_);
	}
	throw new SwaggerException<xxx>("A server side error occurred.", (int)response_.StatusCode, responseData_, headers_, result_, null);  // <-- ALWAYS THROWING EXCEPTION
}

Hello,
I think this is a duplicate of #1259 : NSwag needs to understand that 202, 204... are success as well.


BUG: Inconsistent Welch results by API

Description of the problem
If you use inst.compute_psd with default arguments, you get very different results compared to if you do mne.time_frequency.psd_array_welch.
Steps to reproduce
import mne
from mne.datasets import sample

data_path = sample.data_path()
meg_path = data_path / "MEG" / "sample"
raw_fname = meg_path / "sample_audvis_filt-0-40_raw.fif"

raw = mne.io.read_raw_fif(raw_fname)

evoked = mne.EvokedArray(raw.get_data(), raw.info)

psd = evoked.compute_psd(method='welch', average=False)
print(psd.shape)

psd2, freqs = mne.time_frequency.psd_array_welch(
    evoked.get_data(picks='data'), evoked.info['sfreq'], average=False)
print(psd2.shape)

Link to data
No response
Expected results
The same shape output.
Actual results
compute_psd : (366, 1025, 20)
psd_array_welch: (366, 129, 162)
Additional information
cc @drammock since I think this relates to changes you've made.

To me it looks like "just" a difference in "n_fft" default. And psd_array_welch's default of 256 is pretty small for typical data, and compute_psd's default of 1024 is better. But it's odd that the evoked.compute_psd docs don't mention that the default is different. We should document where the defaults of compute_psd differ from the psd_array_* methods (might just be n_fft?) in compute_psd then we're okay I think. (The default of 1024 is better in my mind than 256 so don't want to change that, and doesn't seem worth it to change psd_array_welch to match by deprecation.)

I only see the 256 default documented in psd_array_welch, I don't see 1024 mentioned anywhere although that seems to be the case from the data but maybe I'm just missing it

The n_fft default for compute_psd() is actually data-dependent and was inherited from the legacy plot_psd() and plot_psd_topo() functions. It is:
https://github.com/mne-tools/mne-python/blob/43414ba878ee7746464a8fd5aa7f4a555ea0bd5e/mne/time_frequency/spectrum.py#L284
I'll add a docstring note about the default.

What do you think about changing the default in mne.time_frequency.psd_array_welch to match @drammock ? I agree with @larsoner that that tends to be rather few points for how high sampling rates tend to be nowadays but I'm not overly opinionated. I am a bit opinionated that I don't particularly like how two seemingly synonymous APIs don't have the same defaults, I think ideally they'd be the same.

So no to harmonizing?

So no to harmonizing?

Sorry I didn't see your comment before the PR was merged.  My feeling is: the default that uses min(n_times, 2048) is a nice convenience default to avoid folks seeing scipy warnings. Folks who are using the psd_array_* interface are already doing "advanced" things (working outside of our normal MNE objects) so they might actually not appreciate a default that does a bit of magic like that (i.e., they might prefer to see those warnings). So I would want users to be able to turn it off, meaning the psd_array_welch function would need a new n_fft="auto" or so (so that passing an integer would not suppress warnings, but "auto" would adapt the value to the data size if necessary, thereby preventing the warning).
Which all feels a bit too... over-engineered? Folks doing advanced things can just write the min(n_times, 2048) or whatever into their own scripts.

Hmm don't love it but I don't really have a better idea at the moment, I think the documentation will go a long way so thanks for that.


Module pyrabbit2

Hi!
Try this module https://github.com/deslum/pyrabbit2. This is fork pyrabbit with new features and support

It is spam. Opening identical issues in 28 repos to advertise your project is definitely a spam.

True but the original pyrabbit project hasn't seen an update since 2015.


Web url Cross Button Issue

Suppose, you have an item which you already created. Now you want to edit it.So when you click on the item it goes the Fragment where you edit your item. If you click the delete(Cross Icon -> web Url), the total web Url view remains invisible, but it takes the whole space. I think you are trying to remove the url text because you already used an edit text filed. If your goal to hide the view when click on the Cross button, then just need to hide the full view. What is your purpose of using Cross button? I wanna fix this issue.
cross_button_issue.webm

@akshatbhuhagal