x/tools/go/analysis: feature request: need a way of accessing analysis results from another go package

What version of Go are you using (go version)?

$ go version
go version go1.17.3 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/amalcontenti-wilson/Library/Caches/go-build"
GOENV="/Users/amalcontenti-wilson/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/amalcontenti-wilson/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/amalcontenti-wilson/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.17.3/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.17.3/libexec/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.17.3"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/yq/18f4vk0j2m95ycmk2wk8j4qh0000gq/T/go-build1149757957=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
I am looking to write a generator that statically analyses some code, and based on the code paths being used generates a manifest for AWS permissions, similar to how kubebuilder controller-gen walks the directory tree and analyses code comments, then produces a result.
What did you see instead?
x/tools/go/analysis package provides a Analyzer package that is great for writing single use code analyzers, but the only documented way of using the analyzers is via the singlechecker or multichecker packages which expose a Main() method and exit with a status code. This makes it hard to write any code that uses the analysis result directly.
The internal checker package does sort of what I would expect, having a "Run" method that returns an exit code, but is both internal (so cannot be imported) and does not return the analysis results.
What did you expect to see?
An exported method that was capable of running analyzers against a set of packages/files, and returning the result interface{} to the program execution flow.
My current workaround is to copy parts of golang.org/x/tools/go/analysis/checker/internal/checker into my own codebase, such as load() to load packages, and the action code to create and run an analysis pass, to be able to get the result directly, which is a fair amount of extra duplicated code to maintain.

There are 3 ways Analyzers can communicate at the moment: results, facts, and diagnostics. This gives a lot of flexibility for how information can be passed around. OTOH the analysis package is not suitable for all needs (notice that none of the x/tools/callgraph commands use it).

What are you trying to do? What kind of information needs to leave the analyzer and why? I need some detail to confirm that is this is not practical to serialize. How is information passed between packages?
What is the suggested new interface in detail? Which Passes are exposed? All executed? All top level? What is the function signature?
Are such Analyzers going to be compatible with unitchecker? (Related to which Passes are exported.)

FWIW this may eventually need a proposal for acceptance. IMO this is exposing more internal details than were previously. Older Analyzers might not be considered backwards compatible. We can try to iron out the above questions first though.

In the simplest form, what I'm trying to do is analyse a package's method calls, and serialize that into a separate YAML file.  The type i'm using at the moment to move the results around is map[string]bool, where the string keys are the method call names. From these results, I then use that map to read/update/save a separate YAML file which lists what service calls are used by the software.
Perhaps using an Analyzer isn't appropriate for this case - what I'm essentially trying to do here is closer to code generation rather than code analysis or linting, which is what the analysis package appears to be geared towards. Are there more suitable packages for this, or is the suggestion that I "roll my own" and duplicate some of what the analyzer package is doing?
I did try a couple of approaches using the supplied facts and diagnostics APIs:
firstly, using a custom fact struct containing that map, and then using multichecker to run both analyzers, however there wasn't a clean way to "analyze" the yaml code since it's expecting the same package to be used for all analyzers.
secondly, using suggestedfixes to update the yaml file, however that didn't seemed to work in the default config (my guess is it doesn't like adding a non-go file to the Fset after the fact).

Perhaps using an Analyzer isn't appropriate for this case - what I'm essentially trying to do here is closer to code generation rather than code analysis or linting, which is what the analysis package appears to be geared towards. Are there more suitable packages for this, or is the suggestion that I "roll my own" and duplicate some of what the analyzer package is doing?

It is still not very clear to me what you are trying to do. Maybe you can zoom out a bit more? Or explain what you have tried?
FWIW I find it is much easier to think of analysis by thinking about the communication mechanisms: Facts, Results, Diagnostics, and the scheduling relationships of passes than "being about linting/code analysis". This is an insider view but this is an under the hood feature request.
Another tactic that may help is to describe what features you are trying to get out of being an Analyzer? This might indicate if it is simpler to roll your own infra.
Responses and questions about more minor points:

what I'm trying to do is analyse a package's method calls,

Which packages do you want to analyze the methods of? If you run the checker on P and P imports Q, do you know you need the results of Q? Is just P okay? What about Q's imports?

The type i'm using at the moment to move the results around is map[string]bool, where the string keys are the method call names.

This will admit very simple serializations that are stable over time. Facts may be appropriate.

From these results, I then use that map to read/update/save a separate YAML file which lists what service calls are used by the software.

{single,multi}checker do not guarantee each package is analyzed in the same process. This allows reducing to unitchecker to be picked up by go vet -vettool=.... Keep this in mind as locking reads/writes to a shared file needs to be done at a different level, the filesystem (or an external database) may suffice. You can also shard writes to different non-overlapping locations for each pass.

(my guess is it doesn't like adding a non-go file to the Fset after the fact).

This is not supported. The assumption is that the packages.Packages can be loaded all at once before any Passes are run.

I did try a couple of approaches using the supplied facts and diagnostics APIs:
firstly, using a custom fact struct containing that map, and then using multichecker to run both analyzers, however there wasn't a clean way to "analyze" the yaml code since it's expecting the same package to be used for all analyzers.

If you are communicating with an external file/DB that will need to be aware of different Passes, an (Analyzer, Package)-pairs. Potentially different executions of the same (Analyzer, Package).

where the string keys are the method call names

2cents: This may have type incorrect call relationships. Not sure if this impacts your application

Probably a bit late but I got permission to share concrete code of how we're using the analysis library here: https://gist.github.com/adammw/941d15c8b1730e3e89fc61138a6a4f24
Note that I had to essentially copy out the implementation of the internal load() method and create/run an analysis.Pass myself. The API sketch above seems to solve some of the problem of creating and running analysis passes in dependency order as needed, however package loading is still left to the user implementation (which might be fine, users like us want the ability to exclude tests for example).

Perhaps this needs a new issue altogether, but this is the closest thing I could find to what I am running into.
We have a linter that we use today but cannot integrate with the existing analysis tools (we currently use golang.org/x/tools/go/packages and process the AST directly).
We essentially have a linter that ensures specific structs are being initialized with all of their fields. Currently, certain community linters do this by taking in a "pattern" of struct name to match against, we've found this to be cumbersome and inefficient, and instead, our linter allows us to add a comment to the structs we wish this linting rule enforced for. Then for any literal we find, we ensure the rule is applied.
Currently, the limitation of only processing one pkg at a time and comments not being attached to types (or anything we can grab in a pass) keeps us from being able to adapt this otherwise. Is there an alternative approach here?

@josebalius Please open a new issue. It is a different discussion.

@addmmw It seems to me that if your goal is to compute some property of a package and all its transitive dependencies, for the purpose of code generation, you would be better off starting from the go/packages.Load function, which returns a graph of packages that you can analyze using custom logic.
The analysis framework is oriented towards checkers, i.e. functions that produce diagnostics, which is not your desired output, and towards incremental analysis of large codebases, analogous to separate compilation in a compiler. But if your goal is code generation---something done relatively infrequently in the workflow---this optimization doesn't seem very important.
No doubt it is possible to express your problem in the analysis framework (perhaps by encoding the result information into a diagnostics message and then parsing it) but it's forcing a round peg into a square hole. There have been requests for us to provide a more piecemeal set of components for building analysis tools, instead of the inflexible unitchecker and singlechecker packages which provide the complete main function for the application (everything but the checker plugins). Such an API might reduce the needed amount of force. But still it seems to me that what you're doing is most naturally addressed by starting from golang.org/x/tools.go/packages.

We essentially have a linter that ensures specific structs are being initialized with all of their fields. Currently, certain community linters do this by taking in a "pattern" of struct name to match against, we've found this to be cumbersome and inefficient, and instead, our linter allows us to add a comment to the structs we wish this linting rule enforced for. Then for any literal we find, we ensure the rule is applied.

Nice to hear from you @josebalius, I hope you are well.
I think your problem should be very cleanly solvable using Facts in the go/analysis framework. Basically, your analyzer needs to do two things:
(1) figure out which named struct types declared in this package are "special", and for each one, call ExportObjectFact on the TypeName. You can do this by looking for a TypeSpec enclosing a StructType that has a special comment. And:
(2) each time you see a struct CompositeLit, test to see whether its type is a special type, and if so, apply the check.
A type is special if it was discovered by step (1) in this package, or if it was discovered when step (1) was previously applied to one of this package's dependencies, so it's a memoized call to ImportObjectFact. The printf checker should serve as a guide.
In future we may come up with a more standard way to annotate declarations such as your struct type, but for now, looking for a special doc comment seems fine. Best of luck.

I'm going to close this issue because I think the analysis framework is not appropriate; use go/packages instead as described in https://github.com/golang/go/issues/50265#issuecomment-1519093766.

@adonovan hope you are doing well also! Yep that's exactly what I ended up doing after figuring it out by looking at some other linters' implementation.


Doesn't work with ueberauth 0.7.0

Authentication callback fails with CSFR error.
%Ueberauth.Failure.Error{message: "Cross-Site Request Forgery attack", message_key: :csrf_attack}

Hi @tomsharratt.
This is linked to change made here https://github.com/ueberauth/ueberauth/pull/136
Something like this needs https://github.com/ueberauth/ueberauth_facebook/pull/65 needs to happen for the slack client aswell.
More docs can be found here https://github.com/ueberauth/ueberauth/blob/7ebc0aeeb17d0953bdc53a01018307fb03e0b189/lib/ueberauth/strategy.ex#L265

Great work on this! Works like a charm. Any chance you could push this new version to hex? TIA


0 downloads reported for a package (latest version)

From twitter:
https://twitter.com/bradwilson/status/964540973526147072

/cc: @skofman1 @agr

Probably a bug in Statistics version parsing code.

This is the first xunit package with a version containing a . in the prerelease part--@skofman1 is probably right.

But the version in question is a stable version.

Never mind. Got it :)

@anangaur 2.3.1 has over 800k downloads, I assume he's referring to 2.4.0-beta.1.build3958 which has 0 and was uploaded 5 days ago.

@skofman1 and I looked into this. It is being parsed incorrectly as expected. We are working on a fix right now.
The current download count can be viewed at https://www.nuget.org/stats/packages/xunit.2?groupby=Version

Another issue with package name at https://www.nuget.org/stats/packages/xunit.2?groupby=Version
Why is the name of the package xunit2? The link is also broken:

@anangaur To clarify, when we receive the download logs from our CDN, it can be sometimes ambiguous what package was downloaded. This was a case in which we determined what package was downloaded incorrectly. We thought the package was xunit.2 version 4.0.0-beta.1.build3958 and not xunit version 2.4.0-beta.1.build3958.
xunit.2 version 4.0.0-beta.1.build3958 doesn't actually exist--but the stats pipeline isn't aware of this and the gallery just shows the stats data on this page.

How can we fix this? Can you file another issue for this?

Fixed:


Witness spec: 0xbb canary

<Tree> := 0xbb m:<Metadata> n:<Tree_Node(0)>
          {a tuple (m, n)}

Is the 0xbb a canary or does it have any other use? If only a canary, it would be nice to mention it in a note.

Good find. 0xbb can be dropped. It was left over from an earlier draft of the spec.
Maybe there is a reason to keep it (canary, easier to specify and implement new versions using this byte). Otherwise, it seems OK to drop it.

The 0xbb byte was removed in #32 . We still have similar flexibility with the 0x00 byte in metadata, which can be used to extend the witness format in a backwards-compatible way.


Avoid log spam for wire messages

In case an xtra message handler hangs, it logs the message that has
been processing. For messages containing types from within the wire
module, these can be huge. So big that processing the logs becomes
impossible and/or exceeds certain limits of downstream software.
We already have specific Display implementations for these types, use
those for the Debug representation.

bors r+


Upgrading from 0.73.9 to 0.75.2 gives back a Unsupported class file major version 61

Description
A React Native local application upgrade from 0.73.9 to 0.75.2 for long term mantainability, even following strictly what shown in https://react-native-community.github.io/upgrade-helper/?from=0.73.9&to=0.75.2 , didn't worked , so done the command :
gradle --refresh-dependencies --full-stacktrace --debug --scan
because running npm react-native run-android it was stuck at 0% so I decided to debug.
Even using Java 17 and Java 21 it reports the error you can see in Stacktrace section (that one pasted is with Java 17, with Java 21 the error changes just from 61 to 65)
Thinking with Java 17 or 21 could be necessary to tell to Gradle with version of Java I am using so I added in app/build.gradle just this to see if that would change:
    compileOptions {
        sourceCompatibility JavaVersion.VERSION_17
        targetCompatibility JavaVersion.VERSION_17
    }

    kotlinOptions {
        jvmTarget = JavaVersion.VERSION_17.toString()
    }

but seems it didn't affected to solve the issue exposed in stacktrace.
Even I see RN still not released any Breaking Updates. That's why migrate from 0.73.9 to 0.75.2 should be easy, but!....
Steps to reproduce

Existing project to migrate from RN 0.73.9 to 0.75.2 , following https://react-native-community.github.io/upgrade-helper/?from=0.73.9&to=0.75.2, ran npm react-native run-android ---> Stuck at 0%
ran gradle --refresh-dependencies --full-stacktrace --debug --scan ---> obtained ERROR in stacktrace reported in stacktrace section of this issue

React Native Version
0.75.2
Affected Platforms
Runtime - Android, Build - Windows
Output of npx react-native info
System:
  OS: Windows 10 10.0.19045
  CPU: (4) x64 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
  Memory: 8.36 GB / 15.89 GB
Binaries:
  Node:
    version: 20.14.0
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 1.22.22
    path: ~\AppData\Roaming\npm\yarn.CMD
  npm:
    version: 10.8.2
    path: ~\Documents\Projects\React_Native\MyProject\node_modules\.bin\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK:
    API Levels:
      - "20"
      - "22"
      - "23"
      - "24"
      - "26"
      - "27"
      - "28"
      - "29"
      - "30"
      - "31"
      - "32"
      - "33"
      - "34"
    Build Tools:
      - 27.0.3
      - 28.0.3
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 33.0.1
      - 34.0.0
    System Images:
      - android-24 | Google Play Intel x86 Atom
      - android-25 | Google APIs ARM 64 v8a
      - android-25 | Google APIs Intel x86 Atom
      - android-25 | Google APIs Intel x86 Atom_64
      - android-31 | Google APIs Intel x86_64 Atom
      - android-33 | Google Play Intel x86_64 Atom
    Android NDK: Not Found
  Windows SDK:
    AllowAllTrustedApps: Disabled
IDEs:
  Android Studio: AI-213.7172.25.2113.9123335
  Visual Studio: Not Found
Languages:
  Java: 17.0.11
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Stacktrace or Logs
2024-08-29T11:37:05.565+0200 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]
2024-08-29T11:37:05.565+0200 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] FAILURE: Build failed with an exception.
2024-08-29T11:37:05.565+0200 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]
2024-08-29T11:37:05.565+0200 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] * Where:
2024-08-29T11:37:05.565+0200 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Settings file 'C:\Users\npule\Documents\Projects\React_Native\MyProject\android\settings.gradle'
2024-08-29T11:37:05.565+0200 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]
2024-08-29T11:37:05.565+0200 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] * What went wrong:
2024-08-29T11:37:05.566+0200 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Could not compile settings file 'C:\Users\npule\Documents\Projects\React_Native\MyProject\android\settings.gradle'.
2024-08-29T11:37:05.566+0200 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] > startup failed:
2024-08-29T11:37:05.566+0200 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]   General error during conversion: Unsupported class file major version 61
2024-08-29T11:37:05.566+0200 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]
2024-08-29T11:37:05.566+0200 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]   java.lang.IllegalArgumentException: Unsupported class file major version 61

Reproducer
https://.
Screenshots and Videos
No response

The error says that it can't compile this file 'C:\Users\npule\Documents\Projects\React_Native\MyProject\android\settings.gradle'.
Could you verify that:

The file exists
The files looks like this one: https://github.com/react-native-community/template/blob/main/template/android/gradle.properties
?

HI @cipolleschi
I checked the file and it exists. It is filled as like as I followed here https://react-native-community.github.io/upgrade-helper/?from=0.73.9&to=0.75.2.
By the way , the file you referenced in the link is gradle.properties , not settings.gradle....
Yesterday after spending all day investigating on it I tried to upgrade gradle to the latest one, 8.10, and the error was solved and looks like Gradle could compile that file now. Just now it reports another different error about serviceOf reference stuff , precisely
Line 10: import org.gradle.configurationcache.extensions.serviceOf Unresolved reference: serviceOf as described in another issue here ( https://github.com/facebook/react-native/issues/32858 ) ....  but I don't think the solution in that issue is the right one because I just have Gradle 8.10, the latest and the error is shown.....

Sorry for the wrong link. 🤦
Among the answers to the other issue, they mention to both:

upgrade gradle wrapper to >= 7.3.3
use JDK >= 11

Which JDK are you using? Meanwhile I reopened the other issue.
Another thing to try is to run ./gradlew --clean && ./gradelw --stop and then try again. We are seeing some other issues caused by a stale cache and that might be the cause here as well.

@cipolleschi , I'll write everything at the other issue.... this one can be considered resolved... at least so following this issue described in subject, everyone who will encounter my issue will have just to upgrade gradle to the latest.

good, I unlocked the conversation in the other issue, I have not noticed that it was locked.


Akshay panayada rkilonova

I made some changes to kilonova file. Made a data directory. Changed the fle path in the python file

Hi @AkshayPanayada, I'll review that, it looks clean enough. is this MR supposed to replace the work in #16


Tonstakers Liquid Staking dApp

https://app.tonstakers.com/tokens

https://github.com/ton-blockchain/verifier/issues/338


Updated project for Symfony 3.0

Updated some tests for working with new Symfony versions
Updated all project requirements
Updated travis definition

ping @Spea Finally! ^^

awesome! :+1:


Should the color mode expose a variable or event that can be used by third-party components?

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Should a parameter of the current color mode value be exposed for use by other components?
And whether there should be an active event that can be monitored when the color mode of the page changes.
Motivation and context
For example, when using other components on the page, third-party components also support bright mode and other mode switching, and can be modified synchronously with the bootstrap color mode status. Should bootstrap provide convenience for this?

Should a parameter of the current color mode value be exposed for use by other components?

Are you talking about the color mode value used for the whole page? Because the color mode can be used contextually within the page too.

And whether there should be an active event that can be monitored when the color mode of the page changes.

Our color-modes.js is not embedded in the Bootstrap JS file. Whenever the color mode changes for the whole page, I'd say one could add an event in this code to modify synchronously third-party components for instance, or to trigger anything.
Do you have some technical suggestions based on what already exists in Bootstrap?

Are you talking about the color mode value used for the whole page? Because the color mode can be used contextually within the page too.

Yes, I mean that when the color mode of the entire page level is modified by the user through buttons, can know that the color mode of the page has been adjusted through event monitoring without refreshing the page.
I understand that color mode can change the color mode locally in the page, but I currently don't know the relevant scenarios where it is needed.

Our color-modes.js is not embedded in the Bootstrap JS file. Whenever the color mode changes for the whole page, I'd say one could add an event in this code to modify synchronously third-party components for instance, or to trigger anything.

Yes, that's fine if there is.

Do you have some technical suggestions based on what already exists in Bootstrap?

There is not

You can use css variables for this. e.g. in your css you have something like this:
:root, [data-bs-theme=light]{

--bs-blue: #0d6efd;
...

}

We can see that $blue is defined as a scss variable

$blue: #0d6efd !default;

Then again is scss we have somehting like

[data-bs-theme="blue"] {
...
--bs-body-bg: var(--bs-blue);

But these do not appear to be used or fully supported when switching from say light to dark mode. What we do have though are examples where it does. e.g. --bs-body-color
:root, [data-bs-theme=light] {
--bs-body-color: #212529;
...

}

also
@media (prefers-color-scheme:dark)
:root {
color-scheme: dark;
--bs-body-color: #dee2e6;

so here you can access like element: var(--bs-blue)
Interesting the only references to this variable I can find are
<body style="--bs-body-color: #333;">

and
<!DOCTYPE html>

// scss-docs-start custom-color-mode
--
[data-bs-theme="blue"] {
--bs-body-color: var(--bs-white);

Whats interesting about this is assigning or overriding one css variable with another in the scss>
Tbh, I am somewhat surprised  that it is not being used like so:
body {
  color: var(--bs-body-color)
}

and then for dark mode we could do
  @media (prefers-color-scheme: dark) {
    --bs-body-color: var(--bs-white);
  }

Also you can change this value in a differrent context.
I think one issue with colours in bootstrap is they use a combination of css and scss variables. Maybe this will be rationalised in boostrap 6. Is there a version of boostrap 6 available yet?


catch exceptions in resources.msg_handler: fwd_handler

Fixes #1.

Went ahead and merged #3 instead. Thank you.


incorrect JSON data when the grid is sorted/filtered. The hyperlink to inspect the JSON data is assigned to another loaded entry.

Azure Data Studio
Version: 1.33.1 (user setup)
Commit: 0b9ef714c823d662815f441aec4a94eaa21940f8
Date: 2021-11-04T17:45:15.872Z
VS Code: 1.58.0
Electron: 12.0.9
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19041
Steps to reproduce:

Execute a query  that returns an product serial and a related JSON column data (NVARCHAR(Max)) with that also contains this ref somewhere.
In the result set check that the data is consistent (proof its still ok)
sort or filter on the product serial using the result grid
open the json bij clicking in the cell of the grid and find another records JSON values.

For info, i've extracted the serial via json_value(...) to ensure that the data in the database was correct.
(Can't share data example here due confidentiality, sorry)

@alanrenmsft

@VinDeg75 could you please provide the data to reproduce the issue with the confidential information removed.


[Proposal] Add a docs pages linking to and explaining the purpose of each demo.

Proposal
We know have a bunch demos and it would be good to have them documented in an index which could be added to the sphinxdoc/readme.
Motivation

Make content easier to access.
Onboard contributors more easily.

Pitch

No point having docs if people can't find them.
Current "tutorials" page is kind of sad. Having a "demos/tutorials" page with a section of internal content and external resources would be good.

Alternatives
A clear and concise description of any alternative solutions or features you've considered, if any.
Additional context
Add any other context or screenshots about the feature request here.
Checklist

[x] I have checked that there is no similar issue in the repo (required)

Forgot to link in PR but this issue is here: https://github.com/neelnanda-io/TransformerLens/pull/263

This can now be resolved.


First line of Composites docs in dwave-system has an error?

https://github.com/dwavesystems/dwave-system/blob/master/docs/reference/composites.rst
The first sentence under the composites heading states:
dimod composites that provide layers of pre- and post-processing (e.g., minor-embedding) when using the D-Wave system

Should this start with dwave-system composites.. ?

Composite ABC is defined in dimod, so this is probably OK, but I'll defer to @JoelPasvolsky.

Agree, we often refer to Ocean's samplers and composites as dimod samplers and composites because they're derived from the dimod ABC. The ones in this particular repo are a subclass for using D-Wave QCs, either directly or hybridly.

Thanks for the clarification!


Fix trivial typo in docs

Can one of the admins verify this patch?
Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.


[WIP] TBB + backend refactor... DO NOT MERGE!

This refactors the parallel backend and adds TBB.

Codecov Report

Merging #3202 into master will decrease coverage by 0.06%.
The diff coverage is 62.74%.

@@            Coverage Diff             @@
##           master    #3202      +/-   ##
==========================================
- Coverage   81.08%   81.02%   -0.07%
==========================================
  Files         384      385       +1
  Lines       75191    75155      -36
  Branches     8441     8434       -7
==========================================
- Hits        60969    60892      -77
- Misses      12931    12970      +39
- Partials     1291     1293       +2

I've just thrown this into the buildfarm to see what happens:

windows 64: build fail, visual studio 9.0 cannot even parse tbbpool.cpp and also complains about exception handlers in use but no unwind semantics enabled.

windows 32: build fail, cannot compile omppool.cpp, alloca identifier not found and r index in OMP for must be signed integral type.

OSX: build fail, cannot find "<omp.h>" for omppool.cpp.

linux 32 and linux 64: build passes, segfaults during testing somewhere in TBB.

POWER8: passes, but slightly suspicious this is due to tests not actually running. Need to augment the numba -s tool with threading layer detection.

ARMv8, build passes, tests also pass, but same suspicion as for POWER8.

Python 2.7: tests fail as there's no multiprocessing.get_context.

Windows 32 Python 2
N/A
FAIL
N/A

Windows 32 Python 3
PASS
PASS
Scipy missing https://github.com/numba/numba/pull/3257, fork ctx not available on windows

Windows 64 Python 2
N/A
FAIL
N/A

Windows 64 Python 3
PASS
PASS
Scipy missing https://github.com/numba/numba/pull/3257, fork ctx not available on windows

Linux 32 Python 2
PASS
PASS
Segfaults
GNU OpenMP forksafe issue?

Linux 32 Python 3
PASS
PASS
Segfaults
GNU OpenMP forksafe issue?

Linux 64 Python 2
PASS
PASS
Segfaults
GNU OpenMP forksafe issue?

Linux 64 Python 3
PASS
PASS
Segfaults
GNU OpenMP forksafe issue?

Status as of 1c71742

Arch
OMP build
TBB build
Testing
Notes

ARM
FAIL (Missing symbol GOMP_parallel)
FAIL (no TBB pkg)
N/A

OSX Python 2
PASS
PASS
PASS

OSX Python 3
PASS
PASS
FAIL
libomp/libiomp5 collide. Also, @jit is having some issues in the function cache

ppc64le Python 2
PASS
FAIL (no TBB pkg)
PASS
OpenMP testing only

ppc64le Python 3
PASS
FAIL (no TBB pkg)
PASS
OpenMP testing only

Windows 32 Python 2
N/A
FAIL
N/A
TBB pool C++ advanced for compiler

Windows 32 Python 3
PASS
PASS
PASS
Sporadic failure from hang/cash, not sure if it's related

Windows 64 Python 2
N/A
FAIL
N/A
TBB pool C++ advanced for compiler

Windows 64 Python 3
PASS
PASS
Sporadic failure from hang/cash, not sure if it's related

Linux 32 Python 2
PASS
PASS
Segfaults
OpenMP pool sometimes fails to import, TBB segfaults

Linux 32 Python 3
PASS
PASS
Segfaults
OpenMP pool has missing symbol GOMP_parallel, TBB segfaults

Linux 64 Python 2
PASS
PASS
Segfaults
OpenMP pool sometimes fails to import, TBB segfaults

Linux 64 Python 3
PASS
PASS
Segfaults
OpenMP pool has missing symbol GOMP_parallel, TBB segfaults

I've found out the reason for segfaults. In short, I think that anaconda's tbb package is broken because GCC 7 possibly over-optimizes TBB code:
Thread 7 received signal SIGSEGV, Segmentation fault.
tbb::internal::generic_scheduler::allocate_task (this=this@entry=0x7faddd75fe00, number_of_bytes=number_of_bytes@entry=8, parent=parent@entry=0x0,
context=context@entry=0x7fade6008c60 tbb::internal::the_dummy_context) at ../../src/tbb/scheduler.cpp:320
320                 ITT_NOTIFY( sync_acquired, &my_return_list );
(rr) bt
#0  tbb::internal::generic_scheduler::allocate_task (this=this@entry=0x7faddd75fe00, number_of_bytes=number_of_bytes@entry=8, parent=parent@entry=0x0,
context=context@entry=0x7fade6008c60 tbb::internal::the_dummy_context) at ../../src/tbb/scheduler.cpp:320
#1  0x00007fade5deef2e in tbb::internal::generic_scheduler::generic_scheduler (this=this@entry=0x7faddd75fe00, m=...) at ../../src/tbb/scheduler.cpp:100
#2  0x00007fade5df10c8 in tbb::internal::custom_schedulertbb::internal::IntelSchedulerTraits::custom_scheduler (m=..., this=0x7faddd75fe00) at ../../src/tbb/custom_scheduler.h:59
#3  tbb::internal::custom_schedulertbb::internal::IntelSchedulerTraits::allocate_scheduler (m=...) at ../../src/tbb/custom_scheduler.h:120
(rr) p t
*$7 = (tbb::task ) 0xffffffffffffffff     This is the reason for segfault
(rr) f 3
#3  tbb::internal::custom_schedulertbb::internal::IntelSchedulerTraits::allocate_scheduler (m=...) at ../../src/tbb/custom_scheduler.h:120
120             scheduler_type* s = new( p ) scheduler_type( m );
(rr) disassemble
Dump of assembler code for function tbb::internal::custom_schedulertbb::internal::IntelSchedulerTraits::allocate_scheduler(tbb::internal::market&):
0x00007fade5df10a0 <+0>:     push   %rbp
0x00007fade5df10a1 <+1>:     push   %rbx
0x00007fade5df10a2 <+2>:     xor    %edx,%edx
0x00007fade5df10a4 <+4>:     mov    %rdi,%rbp
0x00007fade5df10a7 <+7>:     mov    $0x188,%esi
0x00007fade5df10ac <+12>:    mov    $0x1,%edi
0x00007fade5df10b1 <+17>:    sub    $0x8,%rsp
0x00007fade5df10b5 <+21>:    callq  0x7fade5dda8c8   # call NFS_Alloc
0x00007fade5df10ba <+26>:    mov    %rbp,%rsi
0x00007fade5df10bd <+29>:    mov    %rax,%rdi
0x00007fade5df10c0 <+32>:    mov    %rax,%rbx
0x00007fade5df10c3 <+35>:    callq  0x7fade5deeeb0 tbb::internal::generic_scheduler::generic_scheduler(tbb::internal::market&)
=> 0x00007fade5df10c8 <+40>:    lea    0x213579(%rip),%rax        # 0x7fade6004648 <_ZTVN3tbb8internal16custom_schedulerINS0_20IntelSchedulerTraitsEEE>
So, there are calls in lines 118 and 120 but call to std::memset on line 119  was optimized out! Thus the my_return_list  member variable was never initialized (after re-allocating previously used chunk of memory) and thus allocate_task which is part of the generic_scheduler initialization sequence finds garbage and segfaults.

Thanks for looking at the TBB segfault @anton-malakhov, seems like that would explain the problem.
I think we'll need to patch TBB? Notes under std::memset suggest using e.g. C11's memset_s.

RE fork-exec, yes, noted, thanks. I spoke with @sklam about this mid-last week as the test suite itself also has a parallel testing flag (-m), which uses multiprocessing to distribute the test workload across cores and in practice is what is always used to make the tests run in a reasonable time.
<speculation>
This -m flag on linux + Python 2.7 will cause multiprocessing to end up using fork(3) with no preventative measure available. Under Python 3 the multiprocessing context may be set to use spawn for the test running processes but it is (libc/kernel!) implementation detail as to whether this is achieved via fork(3)+exec(3).
In the following OpenMP refers to GNU OpenMP unless stated otherwise.
Under Python3, multiprocessing.Process from spawn via fork(3)+exec(3):
For the tests we have on this branch I think they may be "safe" if no OpenMP calls are made in the parent thread hierarchy (assuming no libgomp DSO globals), this preventing any OpenMP threads spawning and any OpenMP mutexes being present. Then, repeated sequential fork+exec are potentially ok as the new process will contain the threadpool/mutexes for OpenMP which will then disappear with the child as it joins/exits.
Under Python2, multiprocessing.Process:
I cannot see how using OpenMP can be made safe unless os.spawn* is used to force fork(3)+exec(3) (assuming the C library implements it this way, GLIBC seems to https://sourceware.org/git/gitweb.cgi?p=glibc.git;a=blob;f=sysdeps/posix/spawni.c;h=b138ab4393cabbd8d1bec663bb8a000288ed1680;hb=HEAD), in which case this is back to the Python3 case.
The above however does not cover the unit tests that use the threading backend but are not protected by this mechanism. Should the above be valid, this is ok for internal R&D/testing code but probably not something that users should be forced to deal with. I think perhaps we could add an (#ifdef'd for GNU OpenMP) __pthread_atfork() registered function to the omppool.c that prints a message and aborts or similar to prevent accidental use, this can be added in the launch_threads part of the API (also note that omp_set_num_threads needs moving out of there as that would be a parent call to an OpenMP API)? I don't think it'd be possible to park the GNU OpenMP threads in a safe manner prior to fork as per TBB or Intel OpenMP as there's no API for it (a proposed patch is here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60035, mailing list discussion https://gcc.gnu.org/ml/gcc-patches/2014-02/msg00813.html).
</speculation>

The answer about TBB was that it looks like -flifetime-dse=1 is missed (probably by using CXXFLAGS instead, supplied by conda-build).
After replacing tbb package from intel channel, all the tests pass on linux, including all the fork-exec parts, so there should no be problem for intel runtimes I believe. The GNU OpenMP conclusions are sad.. but unless we contribute those API or create our own patch for Anaconda, there is nothing we can do here besides documenting or/and adding asserts/warnings.

OK, we can open issues to get the TBB builds on conda-forge and Anaconda fixed as well.

The GNU OpenMP conclusions are indeed a little sad. It seems in practice that multiprocessing spawn context does fork()+exec() in a consistent, detectable and GNU OpenMP safe manner. So I've added some code to try and detect situations which are unsafe (multiprocessing fork context) and handle them via raising SIGTERM in the child and printing to stderr. I've also found that Numba does not behave well under os.fork() either but that's out of scope of something we should try and rectify here, there's already enough to do!

@anton-malakhov Just FYI: I've cherry-picked @sklam's PR patches from https://github.com/numba/numba/pull/3278 onto this branch to help with the problems caused by concurrent access in the finalizer.

I think this may be the best option, else there's going to be continuous conflicts present at the DSO level especially when e.g. NumPy et al. are involved. Do you recall if the intel-openmp package provides the omp.h headers etc?

no, there are no headers, but it is not a big problem since it is compatible with native openmp for respective platforms and comply with common OpenMP specification (and we don't want to use Intel's extensions so far). So, it's a matter of proper linking - during build time or in run-time.

Great, thanks for the info, I think I can make this work through llvm-openmp for header provision and then intel-openmp for the linkage, it'll make for an interesting build configuration!

Status as of a23bc19

Arch
OMP build
TBB build
Testing
Notes

ARM Python 3
PASS
N/A
PASS
No TBB package available

OSX Python 2
PASS
PASS
Sporadic fail
Now using libiomp5. Failure due to pickle of closure in Numba's linalg impl

OSX Python 3
PASS
PASS
PASS
Now using libiomp5

ppc64le Python 2
PASS
PASS
PASS

ppc64le Python 3
PASS
PASS
PASS

Windows 32 Python 2
PASS
N/A
PASS
TBB disabled (won't compile)

Windows 32 Python 3
PASS
PASS
PASS

Windows 64 Python 2
PASS
N/A
PASS
TBB disabled (won't compile)

Windows 64 Python 3
PASS
PASS
PASS

Linux 32 Python 2
PASS
PASS
Sporadic fail
Failure due to pickle of closure in Numba's linalg impl

Linux 32 Python 3
PASS
PASS
PASS

Linux 64 Python 2
PASS
PASS
Sporadic fail
Failure due to pickle of closure in Numba's linalg impl

Linux 64 Python 3
PASS
PASS
PASS

Pulled in this https://github.com/numba/numba/pull/3291 to get accurate CPU information.

0932314 passed CI, it's just codecov that failed because I masked off all the tests apart from those impacted by this change to get faster turn around on build state, 31eb370 reinstates all the tests.

@anton-malakhov Since merging in your PR to switch off debug / the last build pass, I've:

switched off Python debugging
removed the thread count arg from the parallel_for signature
Added back in some missing asserts in testing
Added testing for numba.threading_layer() [currently failing on windows... investigating now]
Updated the documentation with regards to requirements for the different backends, and also defined the practice of directly setting a backend as "advanced usage".
Run autoformatters over the code.

Am going to move this to ready-for-review once I've sorted windows out.

Build farm smoke test built the conda packages ok for all platforms on py2/3.


Documentation improvements...

What do we need to do?

[ ] more links between API usage docs

this got no where, I'll create a new better issue.


Outdated metadata

It appears that the phone number metadata hasn't been updated for a while.
For example:
7901012345 is rightfully a valid phone number for India (IN, +91), however it's evaluated as invalid in current iOS phone number metadata.
Following is test result using
https://rawgit.com/googlei18n/libphonenumber/master/javascript/i18n/phonenumbers/demo-compiled.html
Parsing Result:
{"country_code":91,"national_number":7901012345,"raw_input":"7901012345","country_code_source":20}
Validation Results:
Result from isPossibleNumber(): true
Result from isValidNumber(): true
Result from isValidNumberForRegion(): true
Phone Number region: IN
Result from getNumberType(): MOBILE
Formatting Results:
E164 format: +917901012345
Original format: 79010 12345
National format:<PHONE_NUMBER>5
International format: +91 79010 12345
Out-of-country format from US: 011 91 79010 12345
Out-of-country format from Switzerland: 00 91 79010 12345
AsYouTypeFormatter Results
Char entered: 7 Output: 7
Char entered: 9 Output: 79
Char entered: 0 Output: 790
Char entered: 1 Output: 7901
Char entered: 0 Output: 79010
Char entered: 1 Output: 79010 1
Char entered: 2 Output: 79010 12
Char entered: 3 Output: 79010 123
Char entered: 4 Output: 79010 1234
Char entered: 5 Output: 79010 12345

Hi @iziz,  apology for double posting here. Is it possible to cut new release containing this bug fix? I would really appreciate it, Thanks!


feat: report compiler crash

Depends on flix/flix#6262
Fixes #202

Do you have a screenshot?

Can we include the name in the message?

Like "crash_report_0.txt"?

Hmm good point. I suppose the whole path, even if ugly. You want people to be able to find it.

It now looks like this:

Looks good. I need to merge both PRs when I prepare the next release. (This may be a while).

Conflicted :/


Changes towards 'latest' deploy in quickstart

Going to test this now, but LGTM

Cool let me know if this works for you, and if so I will merge it and move to another task. If not, then I want to fix this before task switching. Thanks!

My lab is too small for the full deployment today, but it works better than it did before! I say merge it.


feat(guide/di): adds ES5 version of DI chapter

This one doesn't have runnable examples yet, but comes with code snippets do work.

Closed because PR moved to angular.io pr 541.


Base vote weight on NFX requirements

https://dashboard.effect.ai/proposals/20

This proposal is deprecated in favour of proposal 22 (https://github.com/effectai/effect-network-eos/issues/51)


Can the db automatically be set up when starting?

idk if this involves running diesel-cli from command code, or something else.

Added for first run.


Set up auto-deploying from Github Actions

I configured the push.yml action to push to RubyGems whenever we make a new version tag


Clean up of Show entry & Manage pool actions

ShowAction moved from entry controller to own Controller (ShowController) and both entry & manage actions got seperated template folders for valid and expired templates.

:+1:

@mvanspringel dit was broken in productie


when the logging driver is changed at the daemon level, it should change for the containers

Right now if you create a container while the daemon's logging driver is set to json-file, then you restart the daemon with a different logging driver, it doesn't actually change the logging driver for the containers. There is no way to change the logging driver for containers once they are created. It can be done only for services and it's done by re-creating the container. I suspect that whether the logging driver in use by a container is "default" or not is not tracked at all right now, so I think this is an enhancement request, not a bug report.

This is intentional.
The daemon setting changes the default driver for new containers.
I prefer it to change any container without a setting... but this was made purposefully the way it is.

This was changed in https://github.com/docker/docker/pull/21153 (also see https://github.com/docker/docker/issues/21118), and https://github.com/docker/docker/pull/22575#issuecomment-218130844
Some thoughts for future improvements;
allow setting defaults per driver on the daemon, separate from the default logging driver;
--default-logging-driver=json-file
--logging-defaults driver=json-file,max-files=5,max-size=10M
--logging-defaults driver=syslog,tag=foo,something=bar

for containers, combine driver and driver-options in a single flag (e.g. --logging), using a similar notation as above; driver is a required option, thus driver options can only be set if the driver is specified.
containers that are created without --logging set, use both default driver, and options, from the daemon; changing the defaults on the daemon will take effect next time the the container is restarted
containers that are created with only a driver-name set, take the defaults from the daemon as set for that driver; changing the defaults will also take effect next time the container is restarted
containers created with both driver and any option set, don't inherit settings from the daemon

One thing to wonder is; what happens if (e.g.) max-files is changed in case of the json-file driver ? Should additional files be deleted?


Additions

[ ] coffee timer https://github.com/ashfurrow/yourfirstswiftapp
[ ] https://github.com/mhaddl/mentio
[ ] https://github.com/calebd/SimpleAuth
[x] gifts by orta
[x] game live streamed
[x] https://github.com/Mav3r1ck/Orbit7
[x] https://github.com/mhaddl/Ghosty
[ ] https://github.com/RestKit/RKGist
[ ] https://github.com/chriseidhof/github-issues
[ ] https://github.com/USDepartmentofLabor/Swift-Sample-App
[ ] https://github.com/filipealva/Cepp

Apple Watch

[ ] Guess http://www.appcoda.com/watchkit-introduction-tutorial
[ ] Weather https://github.com/ConnectThink/datTempWatchKit-PartOne

0

[ ] https://github.com/kevinvanderlugt/Swift-Walk-Tracker
[ ] https://github.com/AdnanZahid/Math-Quest-iOS
[ ] Coin Tracker https://github.com/gregheo/CoinTracker
[ ] https://github.com/jenduf/SwiftFanorona

:cn:

[ ] https://github.com/JakeLin/ChineseZodiac
[ ] https://github.com/Lax/iOS-Swift-Demos
[ ] https://github.com/geek5nan/FanFanSwift

Another open source iOS app: https://github.com/1raynes/speakability - Speakability an AAC & Speech Therapy iOS App.

@1raynes added, thanks
hey nice pricing :smile:

Hi, this list is awesome!
We also develop open source camera app, Upupu.

Source: https://github.com/xcoo/upupu
App Store: https://itunes.apple.com/app/upupu/id508401854

If you are OK, please add our app to your list.

:+1:

Thanks!


Restaurant style

Style sheets designed for search bar and restaurant menu. Edited a little HTML just for formatting purposes

lgtm


New version: ByteDance.Doubao version 1.22.7

Created by 🥟 Dumplings in workflow run #8051.

Log
Updated: 1.22.6 → 1.22.7
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


[Xamarin iOS] Marker rendered completely white without color

Description
When adding markers or points with custom bitmap as described in vector objects on map without specifying a color, the object gets rendered completely white.
Using the same logic on android or UWP renders the bitmap correct.
iOS

Android

Code Sample
marker.Bitmap is filled by BitmapUtils.CreateBitmapFromUIImage on iOS and BitmapUtils.CreateBitmapFromAndroidBitmap on Android
PointStyleBuilder pointStyleBuilder = new PointStyleBuilder();
pointStyleBuilder.Size = 32;
pointStyleBuilder.Bitmap = marker.Bitmap;

PointStyle pointStyle = pointStyleBuilder.BuildStyle();

MapPos pos = proj.FromLatLong(marker.Position.Latitude, marker.Position.Longitude);
Point point = new Point(pos, pointStyle);
_localVectorDataSource.Add(point);

My guess is that your project has the following option turned on: 'Optimize PNG images' and your marker image is a PNG file. This option should be turned off, as when turned on, PNG files are transcoded into proprietary format that SDK is unable to read. There should be a warning about this in the SDK log, also.

You're talking about the optimization process during compilation?
If yes, I have to disappoint you, we are painting the images via SkiaSharp and then converting them from SKBitmap to UIImage/Android.Bitmap and then via BitmapUtils to Carto.Graphics.Bitmap.
I mean, the proprietary format may also be used during the conversion, but wouldn't it also be used then without compile time optimization?

Correct, I originally assumed you are using PNG assets for your markers.
Could you share the code that constructs marker.bitmap? It is possible that some variants of UIImage encodings are not properly converted into internal bitmap data, but we need to have a reproducible testcase to investigate this.
A workaround would be to bypass UIImage conversion from SKImage completely, by doing something like this:
var skImage = ...
var bitmapData = new BinaryData(skImage.Encode(SKEncodedImageFormat.Png, 100).ToArray());
pointStyleBuilder.Bitmap = Carto.Graphics.Bitmap.CreateFromCompressed(bitmapData);

This should be fixed now, fix is in 4.4.1RC1.

4.4.1 is released now, thus closing.


Added camera_optical link and camera_optical joint to hd_camera

Basic Info

Info
Please fill out this column

Issue(s) this addresses

ROS2 version tested on
Humble

Aerial platform tested on
Gazebo

Description of contribution in a few bullet points

Added camera_optical link to hd_camera.sdf
Added camera_optical_joint to hd_camera.sdf
Set optical_frame_id parameter to camera_optical in hd_camera.sdf

Description of documentation updates required from your changes

It depends on whether the optical_frame_id gets fixed.

Future work that may be required in bullet points

Setting optical_frame_id involves losing the namespace of the drone in the frame_id of the camera_info message.
Strange behavior of the footprint frame needs to be checked.

Done in #578


Invalid use of mem::uninitialized to avoid a memset doesn't avoid a memset anymore

mem::uninitialized is mostly mis-used (as it is here) so as of recently, it initializes all the bytes of the "uninitializedmemory as0x1`. So by default this program is now not dangerous, but also not fast as intended.
But this 0x1-init behavior is removed under Miri and sanitizers, so with MSan enabled:
running 16 tests
test compress::quickcheck_found_bug ... ==2928065==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x563d6c7f7c14 in lzf::compress::compress::h40c2dbee2dbf2a47 /home/ben/lzf-rs/src/compress.rs:85:12
    #1 0x563d6c7ffcea in lzf::compress::quickcheck_found_bug::h79a6dc7ecd07fb4f /home/ben/lzf-rs/src/compress.rs:261:49
    #2 0x563d6c7ccf4b in lzf::compress::quickcheck_found_bug::_$u7b$$u7b$closure$u7d$$u7d$::h65a739a1c8e7e0e6 /home/ben/lzf-rs/src/compress.rs:258:1
    #3 0x563d6c801055 in core::ops::function::FnOnce::call_once::h7fc99a9ec6f2f441 /home/ben/.rustup/toolchains/nightly-x86_64-u

This crate is rather old and at least to my inexperienced eyes removing the use of uninitialized memory is not straighforward. I'd be submitting a patch if I could see an easy fix. Perhaps the most reasonable thing to do here is just file a RustSec advisory (I'm willing to do this)? This crate gets regular daily downloads, so it is not lost to time.

The right thing is to not use mem::uninitialized.

Refactoring to MaybeUninit does not fix the UB. This implementation actually reads then branches on the value of uninitialized memory, as shown above. But the implementation was deliberately written to avoid the overhead of initializing this large buffer. Are you saying the buffer should just be zero-init?

Yeah, once I implemented just using a vec.
I'll take care of it this week. Probably file an advisory, but still publish a patch release with the now-slow-but-safe vec variant.

https://github.com/rustsec/advisory-db/pull/1465


Make it possible to configure date preferences for a project

This makes it possible to enable and disable date setting as well as choosing date field preferences at the project level

Need to ensure that when switching projects, the date fields are updated


[ARM] Resource commands should support --ids

Currently the generic resource commands only support --id.  We should enhance these commands to support --ids so that they are consistent with the rest of the CLI.  See issue #3457 for an example of why this lack of support is problematic.
The lock commands don't have support for even one ID.
We should ensure both sets of commands support the --ids semantic.

[x] resource (PR #3791)
[ ] lock
[x] managedapp (PR #3791)

--ids support for lock commands is considerably complicated by the fact that the lock commands work at various levels, so I excluded it from PR #3791 and will revisit this in a future sprint.

--ids support for lock commands taken care of by https://github.com/Azure/azure-cli/pull/4412


Bundle ssh

We'd like to start using UNIX port-forwards on the server side for DB
tunnels, but that feature shipped only two years ago (...), so users are
likely to have SSH versions that don't support it (e.g. Trusty and
Precise).
This solves that by including OpenSSH in our binary, and putting it on
the PATH when we run the Aptible CLI (I've also included a tweak I had
laying around to unset APPBUNDLER_ALLOW_RVM when running the Aptible
CLI).

Note: I've also updated Omnibus here (in order to update Omnibus Software, which I needed to grab an updated version of the config_guess recipe).
cc @fancyremarker @blakepettersson

LGTM; I'll have to check any eventual implications for Windows (if any), but this just means I'll have to start getting the Omnibus packaging for Windows in gear 😄

Note: we should avoid merging this until we bump the Aptible CLI. Travis auto-uploads on merge. This is perhaps something we should change (to e.g. build on tags), but for now we'll just make a release once we have a CLI that needs this.


[Bug]: Torchlight install failed on Laravel 11 app

What happened?
I try to follow the doc to syntax highlighting wich asks to do this :
composer require torchlight/torchlight-commonmark
But I obtain this composer conflict
  Problem 1
    - torchlight/torchlight-commonmark v0.5.4 requires torchlight/torchlight-laravel v0.5.10 -> satisfiable by torchlight/torchlight-laravel[v0.5.10].
    - torchlight/torchlight-commonmark v0.5.5 requires torchlight/torchlight-laravel ^0.5.10 -> satisfiable by torchlight/torchlight-laravel[v0.5.10, ..., v0.5.14].
    - torchlight/torchlight-commonmark v0.5.3 requires torchlight/torchlight-laravel ^0.5.9 -> satisfiable by torchlight/torchlight-laravel[v0.5.9, ..., v0.5.14].
    - torchlight/torchlight-commonmark[v0.5.0, ..., v0.5.2] require torchlight/torchlight-laravel ^0.5.5 -> satisfiable by torchlight/torchlight-laravel[v0.5.5, ..., v0.5.14].
    - torchlight/torchlight-commonmark[v0.1.0, ..., v0.4.1] require league/commonmark ^1.5 -> found league/commonmark[1.5.0, ..., 1.6.7] but it conflicts with your root composer.json require (^2.5).
    - torchlight/torchlight-laravel[v0.5.0, ..., v0.5.10] require illuminate/support ^7.26.0|^8.0 -> found illuminate/support[v7.26.0, ..., v7.30.6, v8.0.0, ..., v8.83.27] but these were not loaded, likely because it conflicts with another require.
    - torchlight/torchlight-laravel[v0.5.11, ..., v0.5.12] require illuminate/support ^7.26.0|^8.0|^9.0 -> found illuminate/support[v7.26.0, ..., v7.30.6, v8.0.0, ..., v8.83.27, v9.0.0, ..., v9.52.16] but these were not loaded, likely because it conflicts with another require.
    - torchlight/torchlight-laravel v0.5.13 requires illuminate/support ^7.26.0|^8.0|^9.0|^10.0 -> found illuminate/support[v7.26.0, ..., v7.30.6, v8.0.0, ..., v8.83.27, v9.0.0, ..., v9.52.16, v10.0.0, ..., v10.48.22] but these were not loaded, likely because it conflicts with another require.
    - torchlight/torchlight-laravel v0.5.14 requires illuminate/support ^8.0|^9.0|^10.0 -> found illuminate/support[v8.0.0, ..., v8.83.27, v9.0.0, ..., v9.52.16, v10.0.0, ..., v10.48.22] but these were not loaded, likely because it conflicts with another require.
    - Root composer.json requires torchlight/torchlight-commonmark * -> satisfiable by torchlight/torchlight-commonmark[v0.1.0, ..., v0.5.5].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
You can also try re-running composer require with an explicit version constraint, e.g. "composer require torchlight/torchlight-commonmark:*" to figure out if any version is installable, or "composer require torchlight/torchlight-commonmark:^2.1" if you know which you need.

How to reproduce the bug
Launch this command on a fresh install Laravel + Prezet project
composer require torchlight/torchlight-commonmark
Package Version
0.15.0
PHP Version
8.3.9
Laravel Version
11.23.5
Which operating systems does with happen with?
macOS
Notes
No response

The torchlight commonmark package hasn’t been updated to support Laravel 11.
Until it does you’ll have to use a fork. Here’s how I used a fork of the package in the composer file for the docs site https://github.com/prezet/prezet-web/blob/main/composer.json

I understand. Thank you for the tip.


Carthage support and a Pod bump to v1.2.0.

This commit shares the Ohana scheme, and the schemes for its required dependencies, to allow the library to be consumed via Carthage.

Doesn't look like this makes any changes to the API?  All I see is scheme changes, which shouldn't actually affect the pod, and therefore doesn't shouldn't require a bump to the pod version.

Carthage requires a tag for commit versions. If we don't bump at all it'll automatically try to consume v1.1.1, which doesn't support it.
Since the change isn't a bugfix, I've bumped the semver minor.

Since you bumped the version, also run pod install --project-directory=Example to update the example app's locked pods

done


Are templates of the site "useful links"?

The About page of UMIL links to templates for the site--but since you're already on the site, it seems sort of strange to have templates for past ideas of what the site could look like. I feel like this should be kept as internal documentation...

I'll delete this from the UMIL website.


ValueError: You cannot specify an optimizer in the config file and in the code at the same time.

Anyone had this error?
Here's my launch command: (used ds_config_zero2.json in accelerate config)
(I have used a custom fine-tuned model "falcon=7b" instead of gpt-j-6b in the script).
accelerate launch /ipython-docker/notebook_dir/data/trl/examples/research_projects/toxicity/scripts/gpt-j-6b-toxicity.py

Would appreciate guidance.
Thanks

Can you share the accelerate config you are using? And are you additionally specifying an optimizer in the code? I am not super familiar with DeepSpeed but the error suggests that you can't define an optimizer in the DeepSpeed config and in the TRL code.

Hi @lvwerra Thanks for your reply.
I've used the same file/code as in gpt-j-6b-toxicity.py with only the name of the locally saved model changed (which is, a fine-tuned falcon-7b model).
Accelerate settings:
Tried with the following (With deepspeed) (and got the error as previously mentioned)

compute_environment: LOCAL_MACHINE
deepspeed_config:
deepspeed_config_file: /ipython-docker/notebook_dir/data/configs/ds_config_zero2.json
zero3_init_flag: false
distributed_type: DEEPSPEED
downcast_bf16: 'no'
machine_rank: 0
main_training_function: main
num_machines: 1
num_processes: 4
rdzv_backend: static
same_network: true
tpu_env: []
tpu_use_cluster: false
tpu_use_sudo: false
use_cpu: false
Also tried the following (without deepspeed)

compute_environment: LOCAL_MACHINE
distributed_type: FSDP
downcast_bf16: 'no'
fsdp_config:
fsdp_auto_wrap_policy: TRANSFORMER_BASED_WRAP
fsdp_backward_prefetch_policy: BACKWARD_PRE
fsdp_forward_prefetch: false
fsdp_offload_params: true
fsdp_sharding_strategy: 1
fsdp_state_dict_type: SHARDED_STATE_DICT
fsdp_sync_module_states: false
fsdp_transformer_layer_cls_to_wrap: DecoderLayer
fsdp_use_orig_params: false
machine_rank: 0
main_training_function: main
mixed_precision: bf16
num_machines: 1
num_processes: 4
rdzv_backend: static
same_network: true
tpu_env: []
tpu_use_cluster: false
tpu_use_sudo: false
use_cpu: false
Got the following error:

We haven't experimented with FSDP much and not sure it's compatible, yet. accelerate offers many options and backends and we should better investigate which ones are natively compatible with trl (cc @vwxyzjn & @younesbelkada).
Can you also post the content of /ipython-docker/notebook_dir/data/configs/ds_config_zero2.json?
Alternatively, if GPU memory is a concern you can use the peft integration and use adapters. That way you can go with the native data parallel and without any model parallelism.


SLURM out file

Files containing the standard output from the SLURM jobs, seems to contain only Jupyter logs and job wrap ups - maybe they can be discarded for cleanness? The best way to ignore them from git, is to add slurm-*.out as a new line to the .gitignore file.

That is a good idea. I have add slurm-*.out as a new line to the .gitignore file.
But I have one question, the files like slurm-3909303.out which is already uploaded to github, the updated .gitignore file does not work for it, right? Because after I updated .gitignore file, slurm-3909303.out is still in my github repository.

Exactly, files that are already in the repository will remain - the change will only ignore slurm files from now on. I have removed the files and open a pull request to include changes in the repository


Multiple Cluster Selection Bug

When Selecting Multiple cluster points, the infoj does not stack and show the multiple infoj's

Could this bug be reproduced?

Yes, it’s the same on the pubs and sites layer within M&B when run locally on development on Friday.... I haven’t tried other configs though

Rob, can you provide some detail into the nature of the bug?

I can do the non technical version!  When you click on one point everything behaves normally.... clicking on a second or third and the catchments may show but no details are shown in the infoj and no letter highlights the selected location on the map.  This worked in v2.0.0

We can replicate this on mb_v2.

Basically there is a null object on the lastchild of the nav_bar in the dataview.

fix in, please test.

@RobAndrewHurst can this be closed now?


[feat] <rh-chip> element

Description
RHDS needs the have the ability to filter pieces of content using "chips". This is typically a single taxonomy way of filtering versus the multiple ways of filtering that a taxonomy box offers.
https://www.patternfly.org/components/chip/
Example in production on cloud.redhat.com/learn

Acceptance Criteria

[x] Design done
[ ] Development done

Image
No response
Link to design doc
No response
Other resources
No response

@dcaryll Just so you're aware, here are some concepts that are being explored and reviewed.
https://www.figma.com/proto/JbdmuSkfh0CuzqUZixb1UY?node-id=1-5&locale=en

These are great explorations! Thanks for sharing.
I think it's important to note how labels and chips can be distinguished
from one another.
Dan Caryll
Senior Manager, UX Design and Development
Red Hat - NC
100 E Davie Street
@.***
M:<PHONE_NUMBER>
On Tue, Feb 20, 2024 at 3:37 PM coreyvickery @.***>
wrote:

@dcaryll https://github.com/dcaryll Just so you're aware, here are some
concepts that are being explored and reviewed.
https://www.figma.com/proto/JbdmuSkfh0CuzqUZixb1UY?node-id=1-5&locale=en
—
Reply to this email directly, view it on GitHub
https://github.com/RedHat-UX/red-hat-design-system/issues/1456#issuecomment-1955039172,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJRDU522GMEYOAPXG7W7GDYUUCQZAVCNFSM6AAAAABCFV55BKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJVGAZTSMJXGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Update, here is where I left off.
https://www.figma.com/proto/JbdmuSkfh0CuzqUZixb1UY/rh-chip?page-id=0%3A1&type=design&node-id=61-46&viewport=114%2C135%2C1&t=yQCXPMibdoF7ajpf-1&scaling=min-zoom&mode=design

@markcaron @hellogreg I would like to get this done in Charmander.

pf-chip composes into pf-text-input for things like search. will rh-chip do the same? would that change it's semantics or usability? cc @adamjohnson

pf-chip composes into pf-text-input for things like search. will rh-chip do the same?

Was the <pf-text-input> + <pf-chip> composition use case discussed elsewhere with regards to accessibility?
This is a common pattern seen on the web. Unfortunately, as far as I can tell, the APG Patterns don't have guidance for an input containing multiple selected items (correct me if I am wrong). Select2 is a classic library that does this but has had accessibility issues over the years.
IMO, we should steer users away from this UI pattern until the accessibility story becomes more solidified.

@adamjohnson I think pf-chip is being deprecated in PatternFly 6. I am checking with the team about this.
Here is a comprehensive file of what I have been working on for rh-chip. I just need a few folks from other design teams to approve first before you get started. There are some explorations of smaller chips for inputs on the last page.

@adamjohnson According to the PatternFly team, pf-chip is being replaced by pf-label.
If rh-chip needs to be used in inputs like search, maybe we can use rh-tag instead or add to rh-tag if needed, like a more compact version.

@coreyvickery Just FYI had a short conversation with @eyevana about compact on rh-tag today, maybe get her use case for that as well?

Update 5/22: Design leads will give feedback on this component on Tuesday, May 28. Marionne will present as Corey will be out.

@markcaron Do we need anyone else to approve of the current design or can we proceed with development?


TestCafe hangs if the specified screenshots directory contains forbidden symbols

mkdirp falls into infinite recursion, if the specified path contains some forbidden symbols, e.g. ':' on Windows. To reproduce, just try:
node .\bin\testcafe.js remote test.js -s .\scrs:\

https://github.com/substack/node-mkdirp/issues/70

We can consider switching to another package if this one is abandoned

I'm working on it.


Using C expressions to specify the mem doesn't work

In the mem viewer in 1.6.4 you could just enter the name of an array (and its size) and it would be displayed. That doesn't seem to work in this extension.

One image shows cortex-debug 1.6.4, with the array g_iAbridgedADCVals displayed. The other shows the memview error message when I attempt to display the same thing. The array is a global.

In Cortex-Debug, memory viewer was a one step query with GDB. Now, it is a two step process.

Convert expression to an address (as gdb to evaluate the expression and return the result)
Use that address to fetch memory.

This is done so that we are compatible with all debuggers. This memory viewer is designed to work with all debuggers and uses the Debug Adapter Protocol (DAP). In Cortex-Debug, we had a DAP but we implemented a custom memory fetcher because at the time the DAP didn't have a memory fetcher. Now it does and all debuggers are using it.
Try &g_iAbridgedADCVals for the expression

I am closing this. Make sure any expression you enter will result in an address. Arrays (and structs) need an & or gdb will not print an address for an array.
Reply if it does not work.


Fix logic for validating viewBox prop

Looks like the logic flipped recently on the viewBox prop validation when cleaning up some of the code.
This change seems to reflect the intention.
Fixes #809

Oops. Thanks for this! Apparently I didn't read the rest of the line correctly when fixing the unused parameter warning.

Published v7.1.2 now, thanks a bunch!


Support symbolic links in FileTree

I encountered a need to archive symbolic links, and following a discussion from 2013 I ended up in a design document to add symlink support to FileTree. I started implementing the first easy steps from the story, but I had a few questions.
First of all, how should I approach any issues and questions that appear? Should I use a GitHub issue (this one?)? Should I open a discussion thread in the forums?
Secondly, how should I show the code? Should I use my GitHub fork of Gradle and link to the commits there, or should I send pull requests? (How often? Or should I wait until I complete the feature?)
Regarding the implementation (more specifically, starting at step 6), should I update the FileVisitor interface? I thought about adding a new method visitSymlink (or visitSymbolicLink?), but that would break backwards compatibility. I also thought about adding a default implementation, but I'm also not sure if that would be supported or compatible.
I added the FileTree.visit(Action, SymlinkStrategy) method, but should I also add a FileTree.visit(FileVisitor, SymlinkStrategy) overload?
Lastly, are there any tips on where I should look to implement step 6: "Change the implementation of the file system file tree to honour the symlink strategy"?
Thanks in advance.

@jvff It looks like you've rightly started a discussion on the dev list about this. That or the forum is the best avenue for questions like this. Once you've gotten them answered, I recommend perhaps reopening this issue or opening a new one with all of the sections completed about motivation and context.
Feel free to reply to this issue or contact us via another channel if you need clarifications.


Fix github action to build for amd and arm architectures and also tag the latest build with latest

Currently it is only pushing the SHA hash as the tag for the latest build image and the image is currently only being built for amd. Fix the action to handle arm images and in addition to the SHA hash, push the latest tag.

confirmed that amd and arm images land on docker hub


Delay values of 0 prevent any delays from being applied with no warning.

Description of the bug
Adding any row that has a delay of 0 to globalActions.delays causes no other rows to be applied by Hoverfly
Steps to reproduce the issue
hoverctl start webserver --listen-on-host <IP_ADDRESS>
hoverctl import hoverfly.json
hoverctl mode simulate

hoverfly.json
{
  "data": {
    "pairs": [
       {
        "request": {
          "path": [
            {
              "matcher": "exact",
              "value": "/delay/1"
            }
          ],
          "method": [
            {
              "matcher": "exact",
              "value": "GET"
            }
          ],
          "destination": [
            {
              "matcher": "exact",
              "value": "whocares.org"
            }
          ],
          "scheme": [
            {
              "matcher": "exact",
              "value": "http"
            }
          ]
        },
        "response": {
          "status": 200,
          "body": "Success"
        }
      },
       {
        "request": {
          "path": [
            {
              "matcher": "exact",
              "value": "/delay/0"
            }
          ],
          "method": [
            {
              "matcher": "exact",
              "value": "GET"
            }
          ],
          "destination": [
            {
              "matcher": "exact",
              "value": "whocares.org"
            }
          ],
          "scheme": [
            {
              "matcher": "exact",
              "value": "http"
            }
          ]
        },
        "response": {
          "status": 200,
          "body": "Success (No Delay)"
        }
      }
    ],
    "globalActions": {
      "delays": [{
          "urlPattern": "./delay/1",
          "httpMethod": "GET",
          "delay": 1000
        },{
          "urlPattern": "./delay/0",
          "httpMethod": "GET",
          "delay": 0
        }],
      "delaysLogNormal": []
    }
  },
  "meta": {
    "schemaVersion": "v5",
    "hoverflyVersion": "v1.1.3"
  }
}

Observed result
Hoverfly error messages seen (If none, say none)
None
If possible, add screenshots to help explain your problem
Expected result
Hitting the simulated /delay/1 url should result in a 1 second delay but no such delay occurs, Removing or modifying the /delay/0 row results in the expected outcome.
curl -X GET \
  http://localhost:8500/delay/1 \
  -H 'Accept: */*' \
  -H 'Accept-Encoding: gzip, deflate' \
  -H 'Cache-Control: no-cache' \
  -H 'Connection: keep-alive' \
  -H 'Host: localhost:8500' \
  -H 'cache-control: no-cache'

Additional relevant information

Hoverfly version: v1.1.3
Anything that might help us to diagnose the problem

@Hammer-Inc thank you for raising the issue, the fix will be in the next release :)

fixed in v1.1.4


Update whatis-aadc-admin-agent.md

Minor updates in the installation procedure

@RobdeJong : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Updated "Add-ons API Ref" as private preview

Rendered article for review:
https://review.docs.microsoft.com/en-us/microsoft-edge/extensions-chromium/publish/api/addons-api-reference?branch=pr-en-us-1705
Made a few changes to indicate that this API is available in private preview hence not be visible to everyone.
Writer/Editor pass:
vchapel

Docs Build status updates of commit 349edfa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/extensions-chromium/publish/api/addons-api-reference.md
:white_check_mark:Succeeded
View

microsoft-edge/extensions-chromium/publish/api/using-addons-api.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 757c44f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/extensions-chromium/publish/api/addons-api-reference.md
:white_check_mark:Succeeded
View

microsoft-edge/extensions-chromium/publish/api/using-addons-api.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 9cc0e09:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/extensions-chromium/publish/api/addons-api-reference.md
:white_check_mark:Succeeded
View

microsoft-edge/extensions-chromium/publish/api/using-addons-api.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


add GitHub Actions ci workflow

Fixes # .
Did you remember to?

[ ] Add test case(s)
[x] Update CHANGES.txt

We encourage pull requests that:

Add new features to TestNG (or)
Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

@sullis - It would be great if you could please help add some context behind this PR.
From my limited understanding, it looks like github actions is something similar to what Travis CI (which is what currently TestNG uses) is doing. Is that a fair understanding ?

@juherr your thoughts ?

I'd like to proceed carefully with Github Actions since a lot of these actions are implemented by third parties (not Github) and using their actions means exposing private environment variables to these unknown entities.

IMO, GitHub actions could be a good move but we should remove Travis in that case.
For a more complete sample, have a look at https://github.com/raphw/byte-buddy/blob/master/.github/workflows/main.yml
@sullis Could you try to provide a full replacement of our travis build file? https://github.com/cbeust/testng/blob/master/.travis.yml

Wait, before we go there, is there anything that Github Actions does that
Travis doesn't?
Is there a point in switching at all?
--
Cédric
On Thu, Dec 26, 2019 at 11:13 AM Julien Herr<EMAIL_ADDRESS>wrote:

IMO, GitHub actions could be a good move but we should remove Travis in
that case.
For a more complete sample, have a look at
https://github.com/raphw/byte-buddy/blob/master/.github/workflows/main.yml
@sullis https://github.com/sullis Could you try to provide a full
replacement of our travis build file?
https://github.com/cbeust/testng/blob/master/.travis.yml
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cbeust/testng/pull/2210?email_source=notifications&email_token=AAAWRIUBWFNCKM3QXDE5P63Q2T64FA5CNFSM4J6XU6F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHWAY3Y#issuecomment-569117807,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAWRIW6TUZMR3UYSUPXF4TQ2T64FANCNFSM4J6XU6FQ
.

2 features I see: full github integration (see https://github.com/raphw/byte-buddy/actions) and windows support as target.
It is difficult to compare github actions and travis: travis only runs scripts and github actions is a collection of tasks.

@juherr - Do you think we can close this issue off now since we are now using GitHub actions to basically do our CI and also for our releases ?

@juherr - Do you think we can close this issue off now since we are now using GitHub actions to basically do our CI and also for our releases ?

Fixed

Fixed


Useless Profile Link

There is a useless link that goes no where that needs to be removed

removed profile from UI and added updates to lambda


English word not detected

Hi
The plugins doesn't work using english word but oly using italian words and I'm really confused about it. Do you know why this is appening?

Could you please describe the issue in more detail? Do your note titles include English and Italian words, and only the Italian ones are found? A screenshot would be helpful, as well.

@Dibo002 It does not make sense. All words are strings of text and this plugin does not use a dictionary or NLP features.
It's probably a different problem, such as case sensitive issues, or maybe your note was not created.
And I would say it's a coincidence that those notes are english / italian words.


Implement batching protocol

As described in https://github.com/prisma/specs/issues/242#issuecomment-548382431
This issue only tracks the implementation of the batching protocol both on the query-engine and Photon.js side.
The underlying optimization of "merging multiple findOne" queries is a separate issue.

Internal Note: Will be dropped for this sprint.

+1 without this it is very time-consuming to seed/migrate data with 1000s of records

We have a basic batch protocol implemented under the hood. Exposing that protocol in Prisma client is a separate working item.


Prototype for moving concate lowering to tensors world.

There is an issue when the operands contain constant op.
In buffer world, we will do it like
%x = subview (...)
linalg.fill(%x, %cst)

However, this does not work in tensor world because the tensor version of linalg.fill returns a tensor. The result doesn't have any consumers. No one uses the result, so it get deleted.

Oh I probably have a solution...

Okay it is working now. I will add some tests and open it for review.


isobasins: simplify target_fa check

I may be mistaken, but the condition inla_index < 8 will always be true because the only way to get false is if no inflowing neighbour exists... which is not possible because in order to enter the main loop, the condition fa >= target_fa must be true which itself imply that the cell has at least one inflowing neighbour. Even the odd case where target_fa equals 1 won't cause an issue because (target_fa - inla_mag) < (fa - target_fa) will be false.
https://github.com/jblindsay/whitebox-tools/blob/6ebeab23fd40dedcf112612402bf5b4551c2bb1e/whitebox-tools-app/src/tools/hydro_analysis/isobasins.rs#L429-L442
In the else statement, I now reset fa to 0 instead of 1 as it was erroneously adding 1 cell of accumulation for each nested basin afterwards:
https://github.com/jblindsay/whitebox-tools/blob/6ebeab23fd40dedcf112612402bf5b4551c2bb1e/whitebox-tools-app/src/tools/hydro_analysis/isobasins.rs#L455

Can be closed if #178 is merged.

I would be interested in knowing in which case exactly inla_index < 8 would be False.
I must say that the goal of this PR was to make it easier for someone to understand how this great tool works. Personally, I find looking at the source code of various tools being quite instructive and this section puzzled me. There is great educative value in clear code and that's also why I tried to add a (not so great) comment.


adding forceColor input

Resolves issue #9851
Adding a new attribute to chip component names forceColor which will add a class and thus will enable colors even when the chip is not selected. Currently the selector is set to take into consideration the selected state:
https://github.com/angular/components/blob/e7508adfbf0caaa11d2a18b2ba6fe3040a4a720d/src/material/chips/_chips-theme.scss#L73
There are no tests yet, I just want to validate first that this is the right way to do it and later I will add tests and documentation.

@googlebot I signed it!

i need this... whats the status?

I don't think we would want to move forward with this API. I think we would want to think about different ways of making color decoupled from selection state.


Update CometBFT to v0.37.5

We've been using cometbft v0.37.2 since Penumbra v0.62.0, in 2023-10 (11f6efe5f14ce02786836cc97a3019e1f0d02ae6). Since then there have been several patch releases that we've not evaluated. The most recent, v0.37.5, contains changes to blocksync that may result in faster sync times for nodes.
Let's try it out on preview, and see how it goes. If smooth, we should follow up and update the documentation to mention the minor version bump. Since these are patch releases, they should be backwards-compatible, so we don't need to require node operators to update. Still worth a mention in relevant release notes, though.

The most recent, v0.37.5, contains changes to blocksync that may result in faster sync times for nodes.

Initial results are promising: two fresh fullnodes syncing against current testnet are at height 10k & 13k, for 0.37.2 & 0.37.5 respectively. Last time we measured this, per docs, we saw:

A new node will sync at a rate of approximately 50,000 blocks per 24h.

Will wait for the nodes to sync to full height and update accordingly.

The v0.37.5 node took only ~6h to sync to full height of 111,000, during which period the v0.37.2 node made it to height 72,000. The v0.37.2 node reached 111,000 after about ~10h. Not only does that show a dramatic improvement in sync times between versions of CometBFT, it also represents much faster fullnode syncing than the previous time we documented it.

Amazing!


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
2365130 -> 64fc718

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.35.2 -> v1.35.3

go (source)
toolchain
patch
1.22.4 -> 1.22.5

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.35.3
Compare Source
Bug Fixes

do not destroy the project on failure so schematic workspace logs can remain for debug (#837) (72f3c8e)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This issue has been resolved in version 1.7.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Simplify the reading of the schema files to avoid double reading the parquet files.

Closing #74 By removing unnecessary code and simplifying the schema file reading.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.17%. Comparing base (dba3959) to head (7e6ebae).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                 Coverage Diff                 @@
##           55_dataset_cleanup      #76   +/-   ##
===================================================
  Coverage               64.17%   64.17%
===================================================
  Files                      10       10
  Lines                     723      723
===================================================
  Hits                      464      464
  Misses                    259      259

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: .gitignore .func

:bug: .gitignore file path incorrect when creating in a different path that CWD
:bug: .gitignore /.func was causing the build stamp to update
:gift: can now force inclusion of .func in source control by commenting the line
:gift: adds built log journaling via a WithStampJournal option

/kind bug
/kind enhancement
Fixes an issue where .gitignore was not correctly updated when running func with a custom --path
Improves build caching

Running func run twice in a row do build also on second run, I think that should not be happening.

Running func run twice in a row do build also on the second run, I think that should not be happening.

Although  this might not be caused by this PR.

Running func run twice in a row do build also on the second run, I think that should not be happening.

Although this might not be caused by this PR. EDIT: it is not caused by this PR, it was probably broken some time ago. Deploy does the same unnecessary rebuild, I would swear this worked at some point.

Thanks for taking a look. Yes caching is something that is still not happening with complete reliability, but this PR gets it working in a few places and makes it more auditable so we can get the others.  Also explicitly calling .Stamp when the logic dictates that any changes up to that point need not cause a rebuild should help avoid regression 🤞🏻

/approve
/lgtm


[Kubernetes] Cannot ping adapters when meshery deployed in Kubernetes

Signed-off-by: Michael Gfeller<EMAIL_ADDRESS>Description
This PR fixes https://github.com/layer5io/meshery/issues/2603
Notes for Reviewers
Let's discuss this. If ok, a couple of test should be re-run (in-cluster, outside of cluster).
Signed commits

[x] Yes, I signed my commits.

@mgfeller This is already been done in meshkit - https://github.com/layer5io/meshkit/blob/master/utils/kubernetes/client.go#L15-L38. We just had to bump the version of meshkit to adapt the change.

@kumarabd @leecalcote ok, pitty I didn't know that earlier, used quite a few hours on that tbh

@mgfeller Lets add your profile to the meshkit and adapter-library PR template, so that you are not missed with any of the changes that come in. I think it was a mistake from my side that you weren't aware. We should also create a label, which says if the changes needs to be propagated right away to the components that uses meshkit/adapter-library.

Lets revert this change for now and work towards it? I apologise for this.

Lets revert this change for now and work towards it? I apologise for this. It’s frustrating to me that any amount of your time isn’t optimally spent. Will make sure this doesn't happen in the future.

Ok, thanks @kumarabd !


what's the problem?

I just include ie8.js in the page.
and browser console log this:
value failed on object: [object HTMLSelectElement] 对象不支持此操作

what can i do now?

use a <!DOCTYPE html> on  top of your pages

Just to be clear: I've actually no idea what you can do. There are tests pages, 190+ and nobody with this problem already reported. If you would like to help me understand what could be your problem you need to give me a page I can verify where is the problem,  what could it be,  and why is there.
Without that it could be anything I can only keep providing sentences like a "fortune teller" but I haven't much time these days so apologies if I won't come back.
To help further, this repository doesn't make automatically every page compatible with IE8 ... it's a long way commitment to support IE8 if you've never tried before and you have an already live product that never cared about IE8.
Problems could be everywhere because IE8 has problems everywhere.
If you find same problem with any of the current test pages and scripts, then I'll re-open this and try to  eventually fix it, if that's even possible.
Best Regards

I clone this repos and open index.html to run test cases. 3 tests failed, and console log error.


Raidboss: E8N timeline improvement

(Filing this to remind myself to fix this, and to solicit input.)
Shiva's end sequence is a series of Absolute Zero casts once she is brought to 10% HP. In order for her to begin this soft enrage, she has to be in Ryne form. If she's in frost form at the time the threshold is reached, she will complete her current mechanic and then immediately use Redress (4F4F) --> Shining Armor (4DF1) --> Absolute Zero (4DD7). This is then followed up with repeated 4DD7 casts until she or the party die.
Unfortunately, these abilities are identical to the ones used during her standard rotation. This means we can't just use a full-fight lookbehind sync to catch them, as we do for some others. (An example of a similar issue is in Hades Normal.) We discussed some potential solutions to this, but for the moment it looks like that has landed incomplete.
Currently, I think the "best" solution is to split the rotation block in two so that each one ends with Absolute Zero, and then add a junction to each. This would either point back to the start of the other block, or invisibly lead to the enrage block via jump. Something like:
# Rotation block 1
385.3 "Redress" sync /:Shiva:4F4E:/
390.4 "Frost Armor" sync /:Shiva:4DF0:/
398.4 "Twin Stillness/Twin Silence" sync /:Shiva:4DD[DE]:/
413.7 "Double Slap" sync /:Shiva:4DDA:/
424.8 "Mirror, Mirror" sync /:Shiva:4DD4:/
437.0 "Kick/Frost" sync /:Shiva:4D(D[BC]|E[23]):/
442.1 "Reflected Kick/Frost" sync /:Frozen Mirror:(4DF[EF]|4E0[01]):/
455.2 "Absolute Zero" sync /:Shiva:4DD7:/ window 70,5

# Junction block 1

467.4 "Redress" sync /:Shiva:4F4F:/ jump 1467.4
462.3 "--sync--" sync /:Shiva:4DD7:/ #jump to enrage
472.6 "Shining Armor"
480.6 "Embittered Dance/Spiteful Dance"
484.7 "Spiteful Dance/Embittered Dance"

# Rotation block 2
1467.4 "Redress" sync /:Shiva:4F4F:/
1472.6 "Shining Armor" sync /:Shiva:4DF1:/
1480.6 "Embittered Dance/Spiteful Dance" sync /:Shiva:4DE[4567]:/
1484.7 "Spiteful Dance/Embittered Dance" sync /:Shiva:4DE[4567]:/
1500.8 "Holy" sync /:Shiva:4DE[CD]:/
1513.9 "Absolute Zero" sync /:Shiva:4DD7:/ window 45,5

# Junction block 2
1521.0 "--sync--" sync /:Shiva:4DD7:/ #jump to enrage
1526.1 "Redress" sync /:Shiva:4F4E:/ jump 385.3
1531.2 "Frost Armor"
1539.2 "Twin Stillness/Twin Silence"
1554.5 "Double Slap"

(Note that this is entirely from the perspective of making the timeline correct. It's trivial to warn the healers via trigger that "Hey, there's a lot of incoming damage starting, turn the Glare button off for a moment.")
I haven't tested this setup, it's purely theoretical for now. I'll probably have time to look at it on Sunday, but if anyone has cleaner ideas on how to handle this, it would be appreciated.

Closing this at least for now. I've poked at this a little and it's more effort than I would like to get the syncs working safely with the interlocking blocks. I think it's probably better to wait until we can do timeline injection from triggers rather than attempt some "cleverness" to force the existing structures to work.


VLED Disrupts Other Export Interface

Unsure why but it seems like the VLED Software disrupts the same system that Stream Deck DCS interface uses. I checked the ports and they are not the same but when I removed the VLED lua files, my Stream Interface worked again.
Any ideas?
enertial/streamdeck-dcs-interface: A StreamDeck plugin for interaction with Digital Combat Simulator (DCS) (github.com)

https://github.com/s-d-a/DCS-ExportScripts/wiki/Documentation-in-English#Configuration - it uses this

Hi!

Unfortunately I do not have any clue what to do. The nomral exports won't work in multiplayer and the direct export breaks other exports (but not TACview).

That' s why there currently 2 modes for export (you could choose one of them on the setrup screen).

André

Gesendet: Donnerstag, 23. Juni 2022 um 20:19 Uhr
Von: "Sonny-Crockett" @.>
An: "Nereid42/VLEDCONTROL" @.>
Cc: "Subscribed" @.***>
Betreff: Re: [Nereid42/VLEDCONTROL] VLED Disrupts Other Export Interface (Issue #2)

Looks like you are aware of the issue, any chances for a built in fix, in the future? Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


I met come errors in trainer.py

Thanks for sharing your code for us !
I have trained for more than 2500 epochs on one GTX 1080 ti, but the resolution is still the init phase :4X4 and doesn't grow . And I met the error after 2557 epochs like this:
AttributeError: 'DataParallel' object has no attribute 'grow_network'.
I don't know how to solve.

add module like this
G.module.grow_network
This worked for me

Thanks. @kleinyoni  Where did I  add module "G.module.grow_network"?

Change G.grow_network to G.module.grow_network and do the same thing for D.grow_network as well

@n1dhi Thanks, did you mean change to this
self.G.module.grow_network(floor(self.resl))
self.D.module.grow_network(floor(self.resl))  in the trainer.py?

@n1dhi Thanks, did you mean change to this
self.G.module.grow_network(floor(self.resl))
self.D.module.grow_network(floor(self.resl)) in the trainer.py?

Hi, i met same error, could you solve this problem? please help me! thank you!


Add decimals to Share Ratio Limiting

Currently the max share ratio limit accepts integer values.
Even though it can be enabled in the app, the API rounds the value to a integer as reoprted in qBitorrent project https://github.com/qbittorrent/qBittorrent/issues/4707

It was added in the last released but the current API has not implemented the handling of decimals


Add a class to create Foreign types

Allows specifying the exact format of JavaScript values for FFI code:
data A = A (Maybe String) (Maybe String)

instance aAsForeign :: AsForeign A where
  write (A x y) = writeObject [ "x" .= Null x
                              , "y" .= Null y
                              ]

foreign import data B :: *

foreign import convertImpl :: Foreign -> B

convert :: A -> B
convert = convertImpl <<< asForeign

Fixes #31

Ping @paf31. Any comments here or shall I merge this?

Looks great 👍

Sorry about the delay in merging @puffnfresh, it's out now as 1.1.0.


re-image bigbradley

Bigbradley's config has drifted pretty hard because we removed the RTX 2060 GP and some RAM to build-out compufam.
known bug may block: https://wiki.debian.org/GrubEFIReinstall

Open up bradley ad add the GPU from the older compufam
re-install the OS

done!