VIT2021 in 10.12 is not working

The same last source kext in 10.11.6 is working, in 10.12,the kext is not working(used -alcbeta,can be loaded)
But used patches in fake kext,it's working all right.
why?

Injection or timing issues, I'd guess?

原谅我这次用中文啊，作者
二进制部分手动做的仿冒驱动是没问题的(10.12原版驱动改造)。但是就是用alc会出问题，也能用命令查询到已经被加载。
不过rtl的alc系列声卡是没有问题的。
至于您说的那个问题，我从哪儿可以看到记录呢？

Unofortunately I am not certain I understood you even with the help of google translare.
I think you might have injection or timing issues (e.g. AppleALC installed to /S/L/E may still sometimes fail to load). Best in such cases is to add -alcdbg and see what happens in the bootlog.
Also, if I remember correctly system.log does no longer contain the kernel log on 10.12, you may have to use log command.

I'm sorry to have caused you troubled.This is my friend a question。
He tested it today. Found counterfeit driver does not work in 10.12. Yesterday he automatically connect Bluetooth stereo, so have sound。

Yea, but the problem is still here. Kext is injected properly but there is no outputs I guess thats problem with patching binary ? Maybe this codec require additional patches. It works good on El Capitan.

I also have problem, no sound on Sierra, El Capitan was fine. Here is log (booted with -alcdbg):
log show --debug | grep AppleALC 2016-07-23 16:56:20.656622+0200 0x3005c3   Default     0x0                  363    Dock: unable to create an ECDirectoryFile for AppleALC-master.zip.download in <ECDirectory: 0x6080000b5720> {path=/Users/reyder/Downloads/} during a file changed event 2016-07-23 16:59:10.478072+0200 0x301400   Default     0x0                  7325   sudo:   reyder : TTY=ttys001 ; PWD=/System/Library/Extensions ; USER=root ; COMMAND=/usr/sbin/chown -R root:whel AppleALC.kext 2016-07-23 16:59:15.261479+0200 0x301463   Default     0x0                  7351   sudo:   reyder : TTY=ttys001 ; PWD=/System/Library/Extensions ; USER=root ; COMMAND=/usr/sbin/chown -R root:wheel AppleALC.kext 2016-07-23 16:59:23.589881+0200 0x3014ba   Default     0x0                  7392   sudo:   reyder : TTY=ttys001 ; PWD=/System/Library/Extensions ; USER=root ; COMMAND=/bin/chmod -R 755 AppleALC.kext 2016-07-23 16:59:41.360567+0200 0x30124c   Default     0x0                  7136   kextcache: kext-dev-mode allowing invalid signature -67062 0xFFFFFFFFFFFEFA0A for kext AppleALC.kext 2016-07-23 17:06:17.386674+0200 0x72       Default     0x0                  0      kernel: (AppleALC) AppleALC: init @ force enabling on an unsupported operating system 2016-07-23 17:06:17.386677+0200 0x72       Default     0x0                  0      kernel: calling mpo_policy_init for AppleALC 2016-07-23 17:06:17.386679+0200 0x72       Default     0x0                  0      kernel: Security policy loaded: AppleALC Kernel Extension (AppleALC) 2016-07-23 17:06:17.409174+0200 0x72       Default     0x0                  0      kernel: (AppleALC) AppleALC: init @ version 1.0.13 2016-07-23 17:33:25.409097+0200 0x72       Default     0x0                  0      kernel: (AppleALC) AppleALC: init @ force enabling on an unsupported operating system 2016-07-23 17:33:25.409100+0200 0x72       Default     0x0                  0      kernel: calling mpo_policy_init for AppleALC 2016-07-23 17:33:25.409102+0200 0x72       Default     0x0                  0      kernel: Security policy loaded: AppleALC Kernel Extension (AppleALC) 2016-07-23 17:33:25.413776+0200 0x72       Default     0x0                  0      kernel: (AppleALC) AppleALC: init @ version 1.0.13

You use SLE here, and it is likely to fail loading (because I am not using com.apple prefixes).

Tried with Clover as well, the same result.

In this case the resources are incompatible, I guess.
You could add a log with -alcdbg but given that critical errors are printed even without it, I think the above statement is correct. You are welcome to submit working resources in a pull request.

Here is debug log:
2016-07-23 17:56:25.408357+0200 0x72       Default     0x0                  0      kernel: (AppleALC) AppleALC: init @ force enabling on an unsupported operating system
2016-07-23 17:56:25.408360+0200 0x72       Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) config @ boot arguments disabled 0, debug 1
2016-07-23 17:56:25.408361+0200 0x72       Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) init @ initialising with Policy mode
2016-07-23 17:56:25.408363+0200 0x72       Default     0x0                  0      kernel: calling mpo_policy_init for AppleALC
2016-07-23 17:56:25.408365+0200 0x72       Default     0x0                  0      kernel: Security policy loaded: AppleALC Kernel Extension (AppleALC)
2016-07-23 17:56:25.409475+0200 0x65       Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) policy @ init bsd
2016-07-23 17:56:25.413198+0200 0x72       Default     0x0                  0      kernel: (AppleALC) AppleALC: init @ version 1.0.13 DEBUG build
2016-07-23 17:56:28.907281+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) config @ policy hit
2016-07-23 17:56:28.907288+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) config @ initialising enabler
2016-07-23 17:56:28.907305+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ MachInfo asKernel 1 object constructed
2016-07-23 17:56:28.915311+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ Address of interrupt 80 stub is 0xffffff80068ac0d0
2016-07-23 17:56:28.916820+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ Found kernel mach-o header address at 0xffffff8006800000
2016-07-23 17:56:28.916824+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ Found executable at path: /System/Library/Kernels/kernel
2016-07-23 17:56:28.916826+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found TEXT
2016-07-23 17:56:28.916829+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found LINKEDIT
2016-07-23 17:56:28.916831+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found SYMTAB
2016-07-23 17:56:28.936067+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ Address of interrupt 80 stub is 0xffffff80068ac0d0
2016-07-23 17:56:28.937521+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ Found kernel mach-o header address at 0xffffff8006800000
2016-07-23 17:56:28.937524+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ aslr/load slide is 0x6600000
2016-07-23 17:56:28.937527+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ MachInfo asKernel 0 object constructed
2016-07-23 17:56:28.938370+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ Found executable at path: /System/Library/Extensions/AppleHDA.kext/Contents/PlugIns/AppleHDAController.kext/Contents/MacOS/AppleHDAController
2016-07-23 17:56:28.938379+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found TEXT
2016-07-23 17:56:28.938385+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found LINKEDIT
2016-07-23 17:56:28.938391+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found SYMTAB
2016-07-23 17:56:28.938725+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) patcher @ loaded kinfo com.apple.driver.AppleHDAController at 1 index
2016-07-23 17:56:28.939102+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ Found symbol _usimple_lock at 0xffffff8006a03a30 (non-aslr 0xffffff8000403a30)
2016-07-23 17:56:28.939450+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ Found symbol _usimple_unlock at 0xffffff8006a03c10 (non-aslr 0xffffff8000403c10)
2016-07-23 17:56:28.939841+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ Found symbol _vm_allocation_sites_lock at 0xffffff8007087818 (non-aslr 0xffffff8000a87818)
2016-07-23 17:56:28.939851+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ Found symbol _OSKextLoadedKextSummariesUpdated at 0xffffff8006e648d0 (non-aslr 0xffffff80008648d0)
2016-07-23 17:56:28.939856+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) patcher @ _OSKextLoadedKextSummariesUpdated address FFFFFF8006E648D0 value 2E66C35DE5894855
2016-07-23 17:56:28.940028+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ Found symbol _gLoadedKextSummaries at 0xffffff80070c2950 (non-aslr 0xffffff8000ac2950)
2016-07-23 17:56:28.940031+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) patcher @ _gLoadedKextSummaries address 0xffffff80070c2950
2016-07-23 17:56:28.940034+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) patcher @ diff FFFFFFFF81F46F8B argument 81F46F8B
2016-07-23 17:56:28.940044+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ MachInfo asKernel 0 object constructed
2016-07-23 17:56:28.945502+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ Found executable at path: /System/Library/Extensions/AppleIntelFramebufferAzul.kext/Contents/MacOS/AppleIntelFramebufferAzul
2016-07-23 17:56:28.945510+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found TEXT
2016-07-23 17:56:28.945516+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found LINKEDIT
2016-07-23 17:56:28.945522+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found SYMTAB
2016-07-23 17:56:28.959663+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) patcher @ loaded kinfo com.apple.driver.AppleIntelFramebufferAzul at 2 index
2016-07-23 17:56:28.959685+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ MachInfo asKernel 0 object constructed
2016-07-23 17:56:28.973758+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ Found executable at path: /System/Library/Extensions/AppleHDA.kext/Contents/MacOS/AppleHDA
2016-07-23 17:56:28.973765+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found TEXT
2016-07-23 17:56:28.973771+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found LINKEDIT
2016-07-23 17:56:28.973777+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found SYMTAB
2016-07-23 17:56:28.984954+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) patcher @ loaded kinfo com.apple.driver.AppleHDA at 3 index
2016-07-23 17:56:28.984964+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ MachInfo asKernel 0 object constructed
2016-07-23 17:56:28.994196+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ Found executable at path: /System/Library/Extensions/AppleIntelFramebufferCapri.kext/Contents/MacOS/AppleIntelFramebufferCapri
2016-07-23 17:56:28.994204+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found TEXT
2016-07-23 17:56:28.994211+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found LINKEDIT
2016-07-23 17:56:28.994216+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) mach @ header processing found SYMTAB
2016-07-23 17:56:29.005071+0200 0x1f7      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) patcher @ loaded kinfo com.apple.driver.AppleIntelFramebufferCapri at 4 index
2016-07-23 17:56:32.071445+0200 0x202      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) config @ policy hit
2016-07-23 17:57:28.503605+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ resource-request arrived layout
2016-07-23 17:57:28.503609+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ checking codec 1106:441:100100
2016-07-23 17:57:28.503612+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ selecting from 2 files
2016-07-23 17:57:28.503614+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ comparing 0 layout 5/7
2016-07-23 17:57:28.503616+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ comparing 1 layout 7/7
2016-07-23 17:57:28.503619+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) Found layout at 1 index
2016-07-23 17:57:28.592658+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ resource-request arrived layout
2016-07-23 17:57:28.592662+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ checking codec 1106:441:100100
2016-07-23 17:57:28.592665+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ selecting from 2 files
2016-07-23 17:57:28.592667+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ comparing 0 layout 5/7
2016-07-23 17:57:28.592670+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ comparing 1 layout 7/7
2016-07-23 17:57:28.592672+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) Found layout at 1 index
2016-07-23 17:57:28.951623+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ resource-request arrived paltform
2016-07-23 17:57:28.951627+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ checking codec 1106:441:100100
2016-07-23 17:57:28.951630+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ selecting from 2 files
2016-07-23 17:57:28.951632+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ comparing 0 layout 5/7
2016-07-23 17:57:28.951634+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ comparing 1 layout 7/7
2016-07-23 17:57:28.951637+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) Found platform at 1 index
2016-07-23 17:57:29.045531+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ resource-request arrived paltform
2016-07-23 17:57:29.045536+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ checking codec 1106:441:100100
2016-07-23 17:57:29.045538+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ selecting from 2 files
2016-07-23 17:57:29.045541+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ comparing 0 layout 5/7
2016-07-23 17:57:29.045543+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) alc @ comparing 1 layout 7/7
2016-07-23 17:57:29.045545+0200 0x238      Default     0x0                  0      kernel: (AppleALC) AppleALC: (DEBUG) Found platform at 1 index

From what I can tell the resources are simply incompatible with 10.12. Please reopen the issue when you obtain working resources to include in AppleALC. Thanks.


Holding controller upside-down flips the controls

Hi,
I'm playing No Man's Sky. You can use the left joystick to move around. When I hold the joystick forward to walk forward, it walks forward as expected. But when you keep holding it forward and you hold the controller upside-down, your character starts walking backwards as if it flips the controls.
I asked my friend who was playing with me and using Virtual Desktop to do the same, but for him those controls don't flip around so I assume this is a wrong implementation in ALVR.
This is really annoying because when you reach for your Analytic Visor, you reach next to your ear and hold the controller upside-down for a second, breaking your forward movement.

You are sure its not a setting in NMS? I haven't played it yet, but the tracking is streamed from the HMD to steamvr as it is. There is just a minor offset correction

Hm, I've done some testing and it also happens in Payday 2 VR. I also tried Virtual Desktop Streamer and there it happens as well. Yet, an official Oculus Store game, Journey of the Gods, does not do this behavior.
Is there a possibility you could look into adding this as an optional feature/functionality?

I own Payday 2, I will check it out

I have been playing No Man's Sky on the official ALVR and on your forked version, and I can confirm this is happening to me as well, on this version but not on the main version. It is pretty weird.

The original ALVR used FreePie to emulate the VR controllers. This was necessary to change the controller config on the fly if you only have a 3DOF headset and a limited controller. Its possible that FreePie somehow altered the Joystick input.
As I focus on the quest, I replaced FreePie with the direct emulation of the Rift S Touch controller.
All input from the Quest goes straight into SteamVR.
You can check the input by launching SteamHome and opening the Steam Overlay. Here you can see all button presses and joystick movements. You can see that the joystick always moves in the correct direction whether you flip the controller or not.

That's true. ALVR nor this fork is not to blame. I will look into asking OpenVR Advanced Settings or others to check for a solution.


added an application for detecting horizontal and vertical edges in a…

…n image
using simple filter in the examples folder.
Tasklist

[ ] Review
[ ] Adjust for comments
[ ] All CI builds and checks have passed

I have made changes according to your suggestions. Please review the code and suggest if anything more has to be done.

@sid19991  Your PR is still two-commit PR. After cleaning up, you need to do git commit --amend to update the original commit of the PR. Then, git push --force.
Please, updated your PR to make it single-commit with the desired changes only. Then, it will be reviewed.


fix(tls): use fixed-length cert CommonNames

Welcome to Cryostat! 👋
Before contributing, make sure you have:

[x] Read the contributing guidelines
[x] Linked a relevant issue which this PR resolves
[x] Linked any other relevant issues, PR's, or documentation, if any
[x] Resolved all conflicts, if any
[x] Rebased your branch PR on top of the latest upstream main branch
[x] Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
[x] Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #964
Description of the change:
This change adds allows the users to provide...
Motivation for the change:
This change is helpful because users may want to...
How to manually test:

Insert steps here...
...

/build_test

The check from #897 looks like it's just checking the SecretName referenced by the CA Issuer, and the Issuer's Spec only really contains the SecretName.
https://github.com/cryostatio/cryostat-operator/blob/0ec9a84ffded9865671402790379c2884097f456/internal/controllers/common/resource_definitions/certificates.go#L51
https://github.com/cryostatio/cryostat-operator/blob/0ec9a84ffded9865671402790379c2884097f456/internal/controllers/common/resource_definitions/certificates.go#L66
https://github.com/cryostatio/cryostat-operator/blob/0ec9a84ffded9865671402790379c2884097f456/internal/controllers/certmanager.go#L310
If I'm understanding the problem correctly, it's that the Certificates' Specs have changed (because the CommonName field has changed) - the Issuers and theirs Specs actually haven't changed. But I suppose on upgrade, a new CA gets created again and the old one needs to be invalidated and all its Certificates deleted?

The check from #897 looks like it's just checking the SecretName referenced by the CA Issuer, and the Issuer's Spec only really contains the SecretName.
https://github.com/cryostatio/cryostat-operator/blob/0ec9a84ffded9865671402790379c2884097f456/internal/controllers/common/resource_definitions/certificates.go#L51
https://github.com/cryostatio/cryostat-operator/blob/0ec9a84ffded9865671402790379c2884097f456/internal/controllers/common/resource_definitions/certificates.go#L66
https://github.com/cryostatio/cryostat-operator/blob/0ec9a84ffded9865671402790379c2884097f456/internal/controllers/certmanager.go#L310
If I'm understanding the problem correctly, it's that the Certificates' Specs have changed (because the CommonName field has changed) - the Issuers and theirs Specs actually haven't changed. But I suppose on upgrade, a new CA gets created again and the old one needs to be invalidated and all its Certificates deleted?

Right that's what needs to happen on upgrade. You're right, detecting this will be a little more complicated than just modifying the check done in #897.

I found that the cmp.Equal() check on the whole cert Spec didn't behave quite how I expected, so in that latest commit I'm checking specific properties for equality. This looks like it works as expected, including in the upgrade case as outlined in #897's test steps, so once I figure out what exactly was breaking the deep equality check on the Specs then I can clean it up and I think this will be ready.

/build_test

/build_test

I'm still not really sure what's causing cmp.Equal() to return false unexpectedly.
diff --git a/internal/controllers/certmanager.go b/internal/controllers/certmanager.go
index 0be2db9..fcf156d 100644
--- a/internal/controllers/certmanager.go
+++ b/internal/controllers/certmanager.go
@@ -410,6 +410,7 @@ func (r *Reconciler) createOrUpdateCertificate(ctx context.Context, cert *certv1
                        }
                }

+               fmt.Printf("Cert Name: %s\nDiff:\n%s\n", cert.Name, cmp.Diff(cert.Spec, *specCopy))
                if !cmp.Equal(cert.Spec.CommonName, specCopy.CommonName) &&
                        !cmp.Equal(cert.Spec.DNSNames, specCopy.DNSNames) &&
                        !cmp.Equal(cert.Spec.Duration, specCopy.Duration) &&

I tried running through the #897 upgrade steps again with this log line added so that I could spot whatever difference there is in the specs, but to my surprise:
Cert Name: cryostat-sample-ca
Diff:
  v1.CertificateSpec{
   Subject: nil,
   LiteralSubject: "",
-  CommonName: "ca.cryostat-sample.cert-manager",
+  CommonName: "cryostat-ca-cert-manager",
   Duration: nil,
   RenewBefore: nil,
   ... // 2 identical fields
   URIs: nil,
   EmailAddresses: nil,
-  SecretName: "cryostat-sample-ca",
+  SecretName: "cryostat-ca-d3eeb54a7d5c06da92982118f09f5656cb84f8f9ea567839351b0112a4a83763",
   SecretTemplate: nil,
   Keystores: nil,
   ... // 7 identical fields
  }

Cert Name: cryostat-sample
Diff:
2024-11-21T21:08:27Z INFO controllers.Cryostat Certificate created {"name": "cryostat-sample", "namespace": "test"}
Cert Name: cryostat-sample-reports
Diff:
2024-11-21T21:08:27Z INFO controllers.Cryostat Certificate created {"name": "cryostat-sample-reports", "namespace": "test"}
Cert Name: cryostat-sample-agent-proxy
Diff:

ie. only the CA had a couple of small and expected changes. That doesn't seem to match the cmp.Equal() behaviour I was seeing, where it continuously returned false on every comparison, leading to the reconcile loop never settling.
Any ideas on what I could be missing? Or, is the current property-by-property check OK?
		if !cmp.Equal(cert.Spec.CommonName, specCopy.CommonName) &&
			!cmp.Equal(cert.Spec.DNSNames, specCopy.DNSNames) &&
			!cmp.Equal(cert.Spec.Duration, specCopy.Duration) &&
			!cmp.Equal(cert.Spec.RenewBefore, specCopy.RenewBefore) &&
			!cmp.Equal(cert.Spec.IPAddresses, specCopy.IPAddresses) &&
			!cmp.Equal(cert.Spec.URIs, specCopy.URIs) &&
			!cmp.Equal(cert.Spec.EmailAddresses, specCopy.EmailAddresses) &&
			!cmp.Equal(cert.Spec.SecretName, specCopy.SecretName) &&
			!cmp.Equal(cert.Spec.SecretTemplate, specCopy.SecretTemplate) &&
			!cmp.Equal(cert.Spec.IssuerRef, specCopy.IssuerRef) &&
			!cmp.Equal(cert.Spec.IsCA, specCopy.IsCA) &&
			!cmp.Equal(cert.Spec.Keystores, specCopy.Keystores) &&
			!cmp.Equal(cert.Spec.PrivateKey, specCopy.PrivateKey) &&
			!cmp.Equal(cert.Spec.EncodeUsagesInRequest, specCopy.EncodeUsagesInRequest) &&
			!cmp.Equal(cert.Spec.Usages, specCopy.Usages) {
			return errCertificateModified
		}

I noticed one other funny effect from the #897 upgrade steps - the old separate Grafana Route gets left behind. That makes sense since it was an upgrade from 2.4.0 to 4.0.0-dev, and in 2.x we exposed Grafana as a separate Route. In 3.0 it's exposed as a path on the auth proxy with the same Route. I think the old leftover Route is harmless, but also useless.

I noticed one other funny effect from the https://github.com/cryostatio/cryostat-operator/pull/897 upgrade steps - the old separate Grafana Route gets left behind. That makes sense since it was an upgrade from 2.4.0 to 4.0.0-dev, and in 2.x we exposed Grafana as a separate Route. In 3.0 it's exposed as a path on the auth proxy with the same Route. I think the old leftover Route is harmless, but also useless.

Oh right, how about we delete the old Grafana route in the reconciler, similar to how we do it for CORS modifications?
https://github.com/cryostatio/cryostat-operator/blob/0ec9a84ffded9865671402790379c2884097f456/internal/controllers/openshift.go#L41-L42

Maybe, we should add another test case in env-test that verifies the reconciler when there is an existing old cert?

diff --git a/internal/controllers/reconciler_test.go b/internal/controllers/reconciler_test.go
index 612c69f..dce34d5 100644
--- a/internal/controllers/reconciler_test.go
+++ b/internal/controllers/reconciler_test.go
@@ -1795,6 +1795,34 @@ func (c *controllerTest) commonTests() {
 				t.expectCertificates()
 			})
 		})
+		Context("with a modified certificate TLS CommonName", func() {
+			var oldCerts []*certv1.Certificate
+			BeforeEach(func() {
+				oldCerts = []*certv1.Certificate{
+					t.NewCryostatCert(),
+					t.NewReportsCert(),
+					t.NewAgentProxyCert(),
+				}
+				t.objs = append(t.objs, t.NewCryostat().Object, t.OtherCAIssuer())
+				for _, cert := range oldCerts {
+					t.objs = append(t.objs, cert)
+				}
+			})
+			JustBeforeEach(func() {
+				cr := t.getCryostatInstance()
+				for _, cert := range oldCerts {
+					// Make the old certs owned by the Cryostat CR
+					err := controllerutil.SetControllerReference(cr.Object, cert, t.Client.Scheme())
+					Expect(err).ToNot(HaveOccurred())
+					err = t.Client.Update(context.Background(), cert)
+					Expect(err).ToNot(HaveOccurred())
+				}
+				t.reconcileCryostatFully()
+			})
+			It("should recreate certificates", func() {
+				t.expectCertificates()
+			})
+		})

 		Context("reconciling a multi-namespace request", func() {
 			targetNamespaces := []string{"multi-test-one", "multi-test-two"}

Is this something like what you're thinking of? The t.expectCertificates() looks like it's already making the right assertions. This test passes both with or without this PR's changes, so it isn't really doing anything new, but I guess that is to be expected - the bug is not really with the controller's own behaviour, but with the CommonName length restriction which isn't present in the test harness (since it isn't using a real cluster/client).

Is this something like what you're thinking of? The t.expectCertificates() looks like it's already making the right assertions. This test passes both with or without this PR's changes, so it isn't really doing anything new, but I guess that is to be expected - the bug is not really with the controller's own behaviour, but with the CommonName length restriction which isn't present in the test harness (since it isn't using a real cluster/client).

Oh yup, I guess what I had in mind was to have a scenario where there are existing/old certificates (i.e. with specs defined from previous operator versions) and let the test expect if these certificates are reconciled correctly. Since the changes in this PR apply to all managed certificates, we do like something below. What do you think?
diff --git a/internal/controllers/reconciler_test.go b/internal/controllers/reconciler_test.go
index 612c69f..0db9d3f 100644
--- a/internal/controllers/reconciler_test.go
+++ b/internal/controllers/reconciler_test.go
@@ -1765,13 +1765,16 @@ func (c *controllerTest) commonTests() {
 				})
 			})
 		})
-		Context("with a modified CA certificate", func() {
+
+		Context("with modified certificates", func() {
 			var oldCerts []*certv1.Certificate
 			BeforeEach(func() {
 				t.objs = append(t.objs, t.NewCryostat().Object, t.OtherCAIssuer())
 				oldCerts = []*certv1.Certificate{
-					t.NewCryostatCert(),
-					t.NewReportsCert(),
+					t.OtherCACert(),
+					t.OtherAgentProxyCert(),
+					t.OtherCryostatCert(),
+					t.OtherReportsCert(),
 				}
 				// Add an annotation for each cert, the test will assert that
 				// the annotation is gone.
diff --git a/internal/test/resources.go b/internal/test/resources.go
index bcad916..b5e89a0 100644
--- a/internal/test/resources.go
+++ b/internal/test/resources.go
@@ -1058,6 +1058,12 @@ func (r *TestResources) NewCryostatCert() *certv1.Certificate {
 	}
 }

+func (r *TestResources) OtherCryostatCert() *certv1.Certificate {
+	cert := r.NewCryostatCert()
+	cert.Spec.CommonName = fmt.Sprintf("%s.%s.svc", r.Name, r.Namespace)
+	return cert
+}
+
 func (r *TestResources) NewReportsCert() *certv1.Certificate {
 	return &certv1.Certificate{
 		ObjectMeta: metav1.ObjectMeta{
@@ -1084,6 +1090,12 @@ func (r *TestResources) NewReportsCert() *certv1.Certificate {
 	}
 }

+func (r *TestResources) OtherReportsCert() *certv1.Certificate {
+	cert := r.NewReportsCert()
+	cert.Spec.CommonName = fmt.Sprintf("%s-reports.%s.svc", r.Name, r.Namespace)
+	return cert
+}
+
 func (r *TestResources) NewAgentProxyCert() *certv1.Certificate {
 	return &certv1.Certificate{
 		ObjectMeta: metav1.ObjectMeta{
@@ -1110,6 +1122,12 @@ func (r *TestResources) NewAgentProxyCert() *certv1.Certificate {
 	}
 }

+func (r *TestResources) OtherAgentProxyCert() *certv1.Certificate {
+	cert := r.NewAgentProxyCert()
+	cert.Spec.CommonName = fmt.Sprintf("%s-agent.%s.svc", r.Name, r.Namespace)
+	return cert
+}
+
 func (r *TestResources) NewCACert() *certv1.Certificate {
 	return &certv1.Certificate{
 		ObjectMeta: metav1.ObjectMeta{
@@ -1127,6 +1145,13 @@ func (r *TestResources) NewCACert() *certv1.Certificate {
 	}
 }

+func (r *TestResources) OtherCACert() *certv1.Certificate {
+	cert := r.NewCACert()
+	cert.Spec.CommonName = fmt.Sprintf("ca.%s.cert-manager", r.Name)
+	cert.Spec.SecretName = r.Name + "-ca"
+	return cert
+}
+
 func (r *TestResources) NewAgentCert(namespace string) *certv1.Certificate {
 	name := r.getClusterUniqueNameForAgent(namespace)
 	return &certv1.Certificate{

/build_test

/build_test


fix(fonts): fixes fonts in production

fixes #11

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add cypress tests for visual regression testing

Lots of things break everyday because there are not enough tests

@iamareebjamal Can I work on this issue? I'll start by creating a list of all the components that needs to be tested and then create all the tests one by one.


Delete shape with connectors isn't working anymore

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
In the past (no matter if you used draw.io on Confluence Server or Cloud), there was the shortcut Ctrl+Shift+Delete to delete a shape and all the connectors that were coming from or going to that shape (it's also included in the keyboard shortcut list). It's not working anymore.
To Reproduce
Steps to reproduce the behavior:

Create a few shapes that are connected to each other.
Try to delete a shape that has incoming and outgoing links with the shortcut mentioned above.
Not working

Expected behavior
See above
draw.io version (In the Help->About menu of the draw.io editor): draw.io for Confluence Cloud
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6] MacBook Pro
OS: [e.g. iOS8.1] macOS 10.15.5
Browser [e.g. stock browser, safari] Chrome
Version [e.g. 22] 88.0.4324.150

Additional context
Add any other context about the problem here.

Hi Bastian,
If you try Ctrl+delete (trash can) does it help?
I tested in draw.io 14.4.3. for Confluence Cloud, Win 10 Pro and Chrome Incognito
and at my place Ctrl+delete and Ctrl+Shift +delete work well. What draw.io version are you using? (can be seen under Help in the draw.io editor)
Regards,

Hi Mohammedan,
I use 14.4.3, the latest Chrome version (tested with an without Incognito mode) on Mac OS Catalina. Holding down the Command key and click the trash can item isn't successful. I tried all possible combinations of keys, even testing it in Safari didn't work :(. Maybe it's a Mac issue?

Thanks for the report. This will be fixed in the next release.


chore(examples): add calendar explorer demo app

Related to #1512
As discussed, this moves the calendar example from ratatui to app examples as an "explorer" example. It also adds interactivity where you can press Enter to toggle between different styles of calendars.

I tweaked a bunch of things:

made it interactive (select a date, scroll through months)
replaced the style index with an enum
much tidying (consts and things)
better for loop on the year rendering
etc.


Can't import Bestiary 4 - Ugmitok

Can't import statblock:
Ugmitok      CR 12
XP 19,200
Female wikkawak druid (arctic druid) 10 (Pathfinder RPG Advanced Player's Guide 98, Pathfinder RPG Bestiary 4 278)
CE Medium humanoid (goblinoid)
Init +8 (+13 in cold or icy terrain); Senses darkvision 60 ft., scent, snowcaster; Perception +17 (+22 in cold or icy terrain)
Defense
AC 25, touch 15, flat-footed 21 (+7 armor, +1 deflection, +4 Dex, +3 natural)
hp 146 (16d8+74)
Fort +13, Ref +12, Will +13
Immune dazzled; Resist cold 5
Offense
Speed 30 ft. (20 ft. in armor)
Melee +2 spear +17/+12/+7 (1d8+8/×3)
Ranged +2 spear +17 (1d8+6/×3)
Special Attacks wild shape 3/day
Spell-Like Abilities (CL 6th; concentration +8)
At will—pass without trace
3/day—quench (DC 15)
Druid (Arctic Druid) Spells Prepared (CL 10th; concentration +14)
5th—animal growth (DC 19), control winds (DC 19)
4th—air walk, ice storm, spike stones (DC 18), strong jaw[APG] (DC 18)
3rd—dominate animal (DC 17), greater magic fang, sleet storm, stone shape
2nd—barkskin, chill metal (DC 16), flaming sphere (DC 16), fog cloud, soften earth and stone
1st—faerie fire, frostbite[UM], hide from animals, longstrider
0 (at will)—create water, detect magic, light, spark[APG] (DC 14)
Statistics
Str 18, Dex 19, Con 18, Int 12, Wis 19, Cha 14
Base Atk +11; CMB +15; CMD 30
Feats Augment Summoning, Improved Initiative, Natural Spell, Nimble Moves, Point-Blank Shot, Power Attack, Spell Focus (conjuration), Vital Strike
Skills Acrobatics +2 (-2 to jump), Climb +8, Fly +8, Handle Animal +10, Heal +17, Intimidate +19, Knowledge (geography) +13 (+18 in cold or icy terrain), Knowledge (nature) +16, Perception +17 (+22 in cold or icy terrain), Stealth +15 (+20 in cold or icy terrain), Survival +15 (+20 in cold or icy terrain); Racial Modifiers +4 Intimidate, +4 Perception, +4 Stealth
Languages Common, Druidic, Giant, Goblin
SQ arctic endurance, arctic native, icewalking, nature bond (bear named Polar Bear), nature sense, thuggery, trackless step, wild empathy +12
Combat Gear potion of cure moderate wounds (2), potion of invisibility; Other Gear +3 hide armor, +2 spear, ring of protection +1, 633 gp
Special Abilities
Animal Companion Link (Ex) Handle or push Animal Companion faster, +4 to checks vs. them.
Arctic Endurance (Ex) As per Endure Elements - Cold
Arctic Native (+5) (Ex) Initiative checks and Knowledge (geography), Perception, Stealth, and Survival checks in aquatic terrain, and cannot be tracked there.
Augment Summoning Summoned creatures have +4 to Strength and Constitution.
Darkvision (60 feet) You can see in the dark (black and white only).
Energy Resistance, Cold (5) You have the specified Energy Resistance against Cold attacks.
Icewalking (Ex) No penalties to Acrobatics, Climb or Stealth due to snowy or icy terrain or weather, and does not break through snow/ice crusts.
Immunity to Dazzled You are immune to the dazzled condition.
Natural Spell You can cast spells while in Wild Shape.
Nature Sense (Ex) A druid gains a +2 bonus on Knowledge (nature) and Survival checks.
Nimble Moves (5 ft/rd) Move through the listed amount of difficult terrain each rd as if it were normal terrain.
Point-Blank Shot +1 to attack and damage rolls with ranged weapons at up to 30 feet.
Power Attack -3/+6 You can subtract from your attack roll to add to your damage.
Scent (Ex) Detect opponents within 15+ ft. by sense of smell.
Share Spells with Companion (Ex) Can cast spells with a target of "you" on animal companion, as touch spells.
Snowcaster (Su) See normally in snowstorms (inc. magical). Can replace [fire] with [cold] when casting spells.
Spell Focus (Conjuration) Spells from one school of magic have +1 to their save DC.
Thuggery (Ex) Intimidate and Perception are class skills for wikkawaks.
Trackless Step (Ex) Do not leave a trail in natural settings & can't be tracked unless willing.
Vital Strike Standard action: x2 weapon damage dice.
Wild Empathy +12 (Ex) Improve the attitude of an animal, as if using Diplomacy.
Wild Shape (8 hours, 3/day) (Su) Shapeshift into a different creature one or more times per day.
Driven by belligerence, the monstrous shaman Ugmitok dominates Icerift Castle’s denizens, enforcing her demented religion and damning her people and prisoners alike to the wendigo’s foul curse. Though the shaman has figured out how to call the wendigo, she wields no control over the beast. Once she sounds her horn’s summoning blast, she f lees to her sanctum in the ice caves below the castle.

Used your latest module that was available as of about 10:30 am. I used Hero Lab to produce this statblock. For greater accuracy, you might want to use one of the online resources. Hero Lab can truncate some of the text -- or inject errors due to a lack of data. All the other statblocks from Bestiary 4 imported -- a total of more than 85% imported!


Create Counting_Squares.py

added program for Counting Squares #2340

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Added a program to python/cp which calculates the total number of squares present in a grid, including all the axes.
Checklist

[ ✔ ] I've read the contribution guidelines.
[ ✔ ] I've checked the issue list before deciding what to submit.
[ ✔ ] I've edited the README.md and link to my code.

Related Issues or Pull Requests
issue : #2340

Please don't push duplicated PRs


[imgui] update to v1.89

Library name: ImGui
New version number: 1.89
Other information that may be useful (release notes, etc...)
https://github.com/ocornut/imgui/releases/tag/v1.89

This issue has been fixed in PR https://github.com/microsoft/vcpkg/pull/27838, please update vcpkg and install the new version of imgui.

Works like a charm ... thanks !


switch to PS handling target size

code to pass target Width/Height to PS for handling .

requires https://github.com/adobe-photoshop/generator-assets/pull/412

Also what's the minimum jenkins build for this?

Jenkins build 323 is required

back to @pineapplespatula: JSDoc nit, layerComp-as-boolean nit, and a question.

@pineapplespatula  please prepare a merge to main that includes whatever changes currently in the generator branch necessary to support this PR


DealsTimeline mapping error: JsonMapper::map requires first argument to be an object, array given.

InvalidArgumentException
JsonMapper::map() requires first argument to be an object, array given.
in vendor/apimatic/jsonmapper/src/JsonMapper.php:103

It looks like the getDealsTimeline API response returns an object with the data member as an array for like this:
object(stdClass)#2247 (2) {
    ["success"]=>
    bool(true)
    ["data"]=>
    array(12) {
      [0]=>
      object(stdClass)#2244 (4) {
        ["period_start"]=>
        string(19) "2021-08-01 00:00:00"
        ["period_end"]=>
        string(19) "2021-08-31 23:59:59"
        ["deals"]=>
        array(9) {
          [0]=>
          object(stdClass)#2246 (69) {
            ["id"]=>
            int(1193)
            ["creator_user_id"]=>
            int(149104)
            ["user_id"]=>
            ...

When jsonmapper tries to map this response in pipedrive/pipedrive/src/Controllers/DealsController.php:459 the data ends up being recognized as an object of type \Pipedrive\Models\Data25 rather than as an array. But in apimapper/jsonmapper/src/JsonMapper.php:103 an InvalidArgumentException is thrown because $json that is passed in is an array rather than an object.
Ultimately, I think JsonMapper should be calling mapArray or mapClassArray around JsonMapper.php:247 but it is instead trying to call map which only works with an object.
I wish I could have determined the root cause here to provide a merge request to fix this, but the best I could come up with is to skip using JsonMapper and to instead just return the object that comes back from the API. This looks like:
--- vendor/pipedrive/pipedrive/src/Controllers/DealsController.php.old
+++ vendor/pipedrive/pipedrive/src/Controllers/DealsController.php
@@ -454,7 +454,7 @@ class DealsController extends BaseContro

         $mapper = $this->getJsonMapper();

-        return $mapper->mapClass($response->body, 'Pipedrive\\Models\\GetDealsTimeline');
+        return $response->body;
     }

That solution neglects whatever value JsonMapper has.
Thanks for your help troubleshooting and fixing this issue!

I believe I've found a solution for this that's a very simple change in the GetDealsTimeline model to indicate that the data is an array of Data25 objects, not just a single Data25 object.
--- a/src/Models/GetDealsTimeline.php
+++ b/src/Models/GetDealsTimeline.php
@@ -23,14 +23,14 @@ class GetDealsTimeline implements JsonSerializable
     /**
      * Open and won Deals grouped into periods by defined interval, amount and date-type dealField
      * (field_key)
-     * @var \Pipedrive\Models\Data25|null $data public property
+     * @var \Pipedrive\Models\Data25[]|null $data public property
      */
     public $data;

     /**
      * Constructor to set initial or default values of member properties
      * @param bool   $success Initialization value for $this->success
-     * @param Data25 $data    Initialization value for $this->data
+     * @param Data25[] $data    Initialization value for $this->data
      */
     public function __construct()
     {

I opened a pull request for this change (see above)

Hi!
I'm checking open PRs, one of them is related to this issue. The issue was solved on this commit:
https://github.com/pipedrive/client-php/commit/7734d2075183c589899d7dd9e04bd07e3fa0a4bc


new(driverkit): allow configuring the module driver and device name

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build
/area cmd
/area pkg

/area docs

/area tests

What this PR does / why we need it:
The falco libs client might require a kernel module name which is not called falco / falco, depending on the client. Allow these two options to be passed as command line flags via --moduledrivername and --moduledevicename
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

new(driverkit): add --moduledrivername and --moduledevicename to change the name of the built kernel module.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

4e74790 add moduledevicename and moduledrivername options

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: LucaGuerra
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @LucaGuerra! It looks like this is your first PR to falcosecurity/driverkit 🎉

Thanks a lot for the review @leodido ! Good catch on the readme, I added a commit for the readme.

LGTM label has been added.  Git tree hash: 50872ce613f3d1fa91086b05b8267cfaddea0979


Any thoughts on having the repository moved to its own Github Organization Account?

Feel free to add a thumbs up/down or comment on this. My reasoning is:

Group other related repos. and new ones under one account, (e.g. DICOMcloud-webJS)
Source code licensed to the Organization contributors

I have moved the development of this project under the DICOMcloud Organization.
The project will stay here for reference.


Fix rabbitmq for non-root container

What this PR does / why we need it:
This PR makes the chart compatible with Rabbitmq non-root container
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/ok-to-test

@javsalgar this appears may have broken the chart:
cp: cannot create regular file '/opt/bitnami/rabbitmq/.rabbitmq/': Not a directory


Remove the edit/delete/new page function for the first release

Because the function is not working, we should remove it for the first release.

Fixed


Template update

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.471%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
202

Relevant Lines:
242

💛  - Coveralls


Transform MbedAdd* and MbedRemove* functions to take a variable number of arguments

MbedAdd and MbedRemove functions should allow the user to use them to add/remove many libraries in one call.
see vim varags (http://learnvimscriptthehardway.stevelosh.com/chapters/24.html)

closed by #6


Promoting to country pages not working

The promotion to country pages button is not working, at least for events, maybe for other pages. It blinks on an off and I can't put  in the country name.

I cannot reproduce this. The select have been changed to the 'tag'-like one last week.
By " It blinks on an off and I can't put in the country name " I guess you're talking about the select in the "Publishing options", once you checked "Promoted to country page", right?
What browser were you using when that occur? could you try with another one?

In agreement with Laura the promoted content on the Country page is now showing all content tagged with the given country.
1/ it show stuff promoted to a country page
2/ it show the most recent items to have as much as 4 total.
The field should be clean up in the landportal_promoted module to close this ticket


Update code-generation.md with debugtype values

Summary
Ported the compiler option values from https://github.com/dotnet/roslyn/blob/main/docs/compilers/CSharp/CommandLine.md
@BillWagner @akoeplinger
Fixes #6773

@BillWagner/@adegeo, does this note section (being only applicable to the older compilers) imply that portable/embedded has zero impact on performance (JITing etc) and so is fine to leave on in release mode?
Or should there be a new section discussing that, not under an "only applicable for old compilers" heading...
Also, the mention that "pdbonly - Same as full" is somewhat misleading/confusing, when the section that it references directly below describes significant differences between them...
It seems like it would be a lot clearer to say something like:
| pdbonly  | Same as full for backward compatibility for C# compiler version > 6.0. For C# compilers <= 6.0, see the note below for more information. |


Wildcard Versions should be supported

Visual Studio allows for automatic versioning of assemblies by using a '1.0.*' version number. This causes the build and revision portions of the version number to be computed at build time and always incrementing.
NuGet Pack, when ran against a csproj, can read the version number of the project. Combined with the previously mentioned feature, this results in each build producing a uniquely named & versioned NuGet package.
It would be wonderful if NuProj files directly supported a similar wildcard-enabled version number.

I think this would be covered by #20.


Recover OpenID Account Email with wrong domain

The recover email contains example.com instead of people.djangoproject.com:
e.g. https://example.com/reset/ODY0MQ:1bb3Be:xUrqDuxVFDdO4RraDOTavI0H04E/

I updated the Site in the database to people.djangoproject.com, I think that should fix it. Thanks for the report.


machine.Start() context cancellation ignores clean exit

Since https://github.com/firecracker-microvm/firecracker-go-sdk/pull/182 , I'm seeing a red herring message logged at "level=error" by the SDK:

time="2020-02-19T13:06:51Z" level=info msg="VMM logging and metrics disabled."
time="2020-02-19T13:06:51Z" level=info msg="refreshMachineConfiguration: [GET /machine-config][200] getMachineConfigurationOK  &{CPUTemplate:T2 HtEnabled:0xc00f367494 MemSizeMib:0xc00f367488 VcpuCount:0xc00f367480}"
[... boring boot logs]
time="2020-02-19T13:06:51Z" level=info msg="startInstance successful: [PUT /actions][204] createSyncActionNoContent "
[... machine completes, signals restart to terminate VM]
time="2020-02-19T13:07:03Z" level=info msg="firecracker exited: status=0"
time="2020-02-19T13:07:03Z" level=error msg="failed to stop vm \"35bd7d10-99f1-4f47-99ff-903efeee8d03\"" error="os: process already finished"

I'm nesting all firecracker operations behind a ctx, cancel := context.WithTimeout(...); defer cancel().
That deferred cancellation happens after the VM has completed.
I'd like to patch this by string matching against the returned err from Signal() inside stopVMM(), like containerd does.

The SDK is writing firecracker exited: status=0, meaning that the SDK itself is aware about that the process is no longer aliver. Can't we use the signal to skip sending Signal() or hiding the error message?

@kzys I started down that path in #201 , but the method of firing the signal and recovering had less races to deal with.


Improve error on executeQuery write operations

FIXES NEXT-15902
Improve error message for write operations with executeQuery
1. Why is this change necessary?
I can create a migration with bin/console and my IDE gives me an autocompletion on query for executeQuery, but it doesn't work - now I know immediatly what I did wrong AND how to proceed!
2. What does this change do, exactly?
Improve an error message so the dev know, what the next step/change is.
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hey : )
We've just set your PR to “Scheduled”.
This means our initial screening is passed.
Your PR will now be reviewed and tested before being put trough our internal extended testsuite and review process.
We will keep you informed wether something has to be done by you or when the PR is merged : )
If you have any questions feel free to ask.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-15920
Please use this issue to track the state of your pull request.

@J-Rahe 🎉🎉 I think shopware bot needs some love to not create Duplicates 🙈 Just saying :D
Thanks! <3

@Schrank, every Github PR gets an new Ticket which may then reference other tickets.
The new ticket is bound to the Github-PR and includes information like the Github author, PR description etc. which is then later used e.g. for the mentioning in the changelog.

Sounds like someone thought about it <3 @J-Rahe  I take it back, the bot got enough love.

Thanks for your contribution! :blue_heart:


Alerts for memory utilization of secondaries

Create a script to monitor the memory utilization of secondaries.

@kumarnarendra701 (and @athandle) before we go too far down this road I'd like to have a discussion in an arch call (once I'm back next week).

Closing this ticket, as whatever we do about this problem, it won't be using the seccheck approach.


Add typescript typedefs for the main components

We are switching to TypeScript at the moment so I needed this :)
Fixes #10

Cool thanks, if you can push out a new release as well that'd be great :)

done


set default queue capacity to 40 percent

Set AM scheduler default queue percentage to 40%

:+1: LGTM, pending Travis

closing this, not required. config change in capacity-scheduler.xml was still old config, but the config in node manager UI showed new value, picked up from yarn-site. that caused the confusion.


Adding scroll to top button for enhanced user experience and proper ui/ux

What feature would you like to see?
Adding scroll to top button for enhanced user experience and proper ui/ux
Why is this feature useful?
It will help people from moving bottom to top in single click in place of scrolling so much
How important is this feature to you?

[X] Must have
[ ] Should have
[ ] Nice to have
[ ] Just an idea

Have you seen this feature in other projects?

[X] Yes, I've seen something similar elsewhere
[ ] No, this is a unique idea

Your experience level with this project:

[X] I'm new here (first-time contributor)
[ ] I've used this project before
[ ] I've contributed to this project before

Would you like to work on this feature?

[X] Yes, I'd like to try implementing this feature
[ ] I can help with testing
[ ] I can help with documentation
[ ] No, I'm just suggesting the idea

@aswathcm29 Assign this to under gssoc 2024 ext and hacktoberfest i will work on this issue.

pls assgin me this issue


Upgrade to Netbeans 22

Looks like no harness updates needed at this time, simple and straightforward.
Resolves #607

Hmm, found this archive link where they allow to download the old versions. But looks they always archive the current version as well. Maybe this is more permanent link.

I'll merge this now as the build is really broken at the moment... So it can't go any worse anyway...


Testing Nodejs Express API Endpoints With Jest and supertest

We ask that you please be patient as our team works through approving and publishing all articles/tutorials in a timely manner. Allow 1-3 days for a topic to be reviewed and/or approved - allow 3-7 days for an articles to be reviewed and/or published.
Be sure to visit our Resources Page for tools, resources, and example articles to go over.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
NOTE: We tend to stray away or tend not to publish reviews/comparisons of commercial product offerings.
We're looking for the first 2-3 paragraphs of the article that appropriately summarize what your article will be about.
Proposed title of article
Testing Nodejs Express API Endpoints With Jest and supertest
Introduction paragraph (2-3 paragraphs):
Software testing is the process of verifying a system with the purpose of identifying any errors, gaps, or missing requirements versus the actual requirement. In JavaScript and Node.js, one popular tool for testing is Jest. Jest is a JavaScript testing framework developed by Facebook. It works out of the box with minimal configuration and has an in-built test runner, assertion library, and mocking support. Supertest is a library for testing Node.js HTTP servers. It enables us to programmatically send HTTP requests such as GET, POST, PATCH, PUT, DELETE to HTTP servers and get results.
This tutorial will focus on testing in Node.js Express API using Jest and Supertest.
Key takeaways:

What is testing and why should we write tests?
Configuring supertest and Jest in Node.js
Testing API endpoints using Jest and supertest

References:
N/A
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

@KayveTech
to help avoid a backlog queue we are only accepting one article topic/pr approved at a time 👍

@hectorkambow , can I start working on this issue? Had my paypal changed too. Did contact you via slack.


fix(npm script): change import statement to require call

As node does not support import statements yet we will have to stick to require statements only
Fixes #27

:tada: This PR is included in version 2.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


This document didn't cover usage of Private Endpoint

Any plan to update this document to include new Azure services like Private Endpoint/Link and other practices?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 500a2c86-b9f9-1e9a-1c22-3579450ba95b
Version Independent ID: ce872fbb-7707-5ff3-e1f9-aa8c170553cc
Content: Securing PaaS Databases in Azure
Content Source: articles/security/fundamentals/paas-applications-using-sql.md
Service: security
Sub-service: security-fundamentals
GitHub Login: @techlake
Microsoft Alias: terrylan

@hambster Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

@hambster - Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


regular issue regarding gem dependencies faraday

Checklist

[x] Upgrade Terraspace: last version
[x] Reproducibility: almost at each terraspace update
[x] Code sample: no specific to code

My Environment

Software
Version

Operating System
GNU/Linux Ubuntu 21.04

Terraform
1.0.4

Terraspace
0.6.13-20210902100211

Ruby
2.7.2p137

Expected Behaviour
When there is an update of terraspace, to have just some basic dependency to update
Current Behavior
When there is an update of terraspace, the installation require some update (OK), but most of the time I need to clear dependency to have a valid installation
"You have already activated faraday 1.7.0, but your Gemfile requires faraday 0.17.4. Prepending bundle exec to your command may solve this."
The issue seems to be related to faraday that are required in two different version (0.
Step-by-step reproduction instructions

Create a project with terraspace, make sure everything run smoothly
Wait for terraspace update
Somme dependency issue will appears, update them individually or globally whatever) with "bundle update X"
run terraspace check, see the error with faraday 0.17.4 & 1.7.0 following the dependency
run bundle clean --force and bundle install to fix the issue

Solution Suggestion
Force some dependency or at least check compatibility. In https://github.com/boltops-tools/terraspace/issues/135 it's seems there is the same issue, but upgrade ruby seems to solve the issue.
Note
I'm not a ruby developer...

Bummer. Dug into this. Addressing this by improving the terraspace wrapper generated by the standalone installers. Details here:

https://terraspace.cloud/docs/install/standalone/details/#terraspace-wrapper
https://terraspace.cloud/docs/install/shim/

Believe this should resolve the issues. 🧐
In addition, added a friendly usage message with instructions on how to resolve if the error occurs. PR: https://github.com/boltops-tools/terraspace/pull/177  The standalone installer's new shim, as of terraspace 0.7.0 includes this smarter shim already.


Feat/trust proxy

Adds 'trust proxy' setting from Express, defaulting to 0 (do not trust proxies).
Fixes issue causing the socket connection IP address to always be considered 'trusted' (breaking change).

Namely, here, the returned value from compile and therefore trustRemoteAddress is a function, which is always truthy. Therefore req.proto is always derived from X-Forwarded-Proto.
Additionally, on every request trustRemoteAddress compiles a trust function which will always trust the remote address, which could be considered a security vulnerability.

Thanks for the PR! Do you think we could port all of the proxyaddr tests to make sure we pass the same test suite?

I'm not 100% sure what you mean, but 'more tests' can never hurt!
I presume you mean the tests from the original proxyaddr module (that would make sense, since this is a feature ported from there)

@Lordfirespeed I meant porting tests from here:
I meant porting those tests https://github.com/jshttp/proxy-addr/blob/master/test/test.js

I'm not familiar with CIDR/netmasks so don't think its appropriate for me to try to fix the issues causing the remaining failing tests.

I'm not overly familiar with CIDR notation/netmasks so don't think its appropriate for me to try to fix the issues causing the remaining failing tests.
 FAIL  tests/modules/proxy-addr.test.ts > proxyaddr(req, trust) > arguments > trust > should reject bad CIDR '<IP_ADDRESS>/internet'
 FAIL  tests/modules/proxy-addr.test.ts > proxyaddr(req, trust) > arguments > trust > should reject bad CIDR '::ffff:a00:2/-1'

 FAIL  tests/modules/proxy-addr.test.ts > proxyaddr(req, trust) > arguments > trust > should reject bad netmask '<IP_ADDRESS>/<IP_ADDRESS>'
 FAIL  tests/modules/proxy-addr.test.ts > proxyaddr(req, trust) > arguments > trust > should reject bad netmask '<IP_ADDRESS>/ffc0::'
 FAIL  tests/modules/proxy-addr.test.ts > proxyaddr(req, trust) > arguments > trust > should reject bad netmask 'fe80::/ffc0::'
 FAIL  tests/modules/proxy-addr.test.ts > proxyaddr(req, trust) > arguments > trust > should reject bad netmask 'fe80::/<IP_ADDRESS>'
 FAIL  tests/modules/proxy-addr.test.ts > proxyaddr(req, trust) > arguments > trust > should reject bad netmask '::ffff:a00:2/<IP_ADDRESS>'

 FAIL  tests/modules/proxy-addr.test.ts > proxyaddr.compile(trust) > arguments > trust > should reject bad CIDR '::ffff:a00:2/-1'

shouldn't this CIDR stuff be handled by ipaddr.js?

@talentlessguy Yes, I think it should be - however, I was trying to avoid making behavioural changes so left the parseIpNotation function (here) relatively unchanged.
It looks like that function is a direct port from jshttp/proxy-addr (see here) so some deep-diving may be required to determine intent 🙃

@talentlessguy Yes, I think it should be - however, I was trying to avoid making behavioural changes so left the parseIpNotation function (here) relatively unchanged.
It looks like that function is a direct port from jshttp/proxy-addr (see here) so some deep-diving may be required to determine intent 🙃

@tinyhttp/proxy-addr is indeed a direct port, I wrote the port 😆 . I haven't touched the logic much, just made the code more compact and rewrote it in TS

Looks like the typeof check on this line is causing the issue.
In jshttp/proxy-addr, the comparison was not conditional on the typeof check, so in the case that range = null would compare null <= 0 which evaluates true (of course, thanks JavaScript...)
Tests are now passing.

@Lordfirespeed thanks for the fix! Would you mind running pnpm chgset to recursively bump affected packages? It will open a prompt and you need to select app and proxy-addr in the list and changesets will do the rest

Might add some tests to the core/request.test.ts to cover the 'trust proxy' setting


GENv2 HL7 Validations: Blanket Processing: ReqID-00008 -  Update needed for DT and TS fields

Please review the date validations. Updates are needed in DEX.
Expected Results:  - Some messages need to be similar to MVPS
See tab QA - Date Validations
https://cdc.sharepoint.com/teams/CDC-Data-Exchange/Shared Documents/Build - HL7/Development/QA/QA Validation of Generic_V2_0_1_MMG-and-TS_F_20210722 (1).xlsx?web=1
Postman Collection:
https://cdc.sharepoint.com/teams/CDC-Data-Exchange/_layouts/15/download.aspx?UniqueId=cf2bc4360d93435fb9808b23ceb1609b&e=7l4nI2
Postman Test Results
https://cdc.sharepoint.com/:f:/r/teams/CDC-Data-Exchange/Shared Documents/Build - HL7/Development/QA/POSTMAN TEST RESULTS?csf=1&web=1&e=QacvTC
Also, requirements from #489 (now closed and merged into this ticket):

[ ] institute check for Leap year (Feb 29th) in years where there are no leap years
[ ] add logic around MMWR week field in GenV2 (I believe specified in one of the links above)

Validated along with leap year validations. A new ticket was created for OBR-22.


saveGLB file textures filtering problem

When i export model with saveGLTF method everything looks as it should

But when i export model with saveGLB method textures filtering is different

Same model, same settings only difference is between used method.
I tried everything but nothing seems works. Any ideas why this is happening?
Thank you

can you please test it with the current version again?

can you please test it with the current version again?

Sorry im not working at company anymore. I wish i had better repro


feat: latte redesign

@NyxKrage pinged me about the theme looking off in Latte, this PR is intended to address a few of the visual issues by flipping base/mantle/crust when the light theme is active.
Here's the compiled latte-sky version if you want to give it a shot.

This looks much better but we should probably set the --color-code-bg to base unconditionally

Good shout, I've updated the gist with a few minor changes, including --color-code-bg.

The fact that the elements between the code and the rest of the page is darker feels a bit weird, but I think it's just how it is, because I'm not sure how you would "fix" that without making the rest of the site look worse.


[iOS] Changes to column style padding to improve visual layout of content

Automatically generated task. Any updates to the title and body will be overwritten. Do NOT modify the labels.
iOS implementation of #2755

We have decided not to make this change as it has negative effects on some existing cards.


Publicly release 3.1.3 & 3.1.4

Hi!
Working on building some tooling that will utilize this paritytech/txwrapper and noticed that the latest few releases haven't been uploaded to the public registries. Any chance, you could release the latest versions or include this as part of your CI?
Thanks!

3.1.4 is released!


Implement reset total distance API

I have some doubts about API path, leaved {id} for consistency.

Just re-add  last position with corrected attribute. If there is no last position do nothing (and throw exception to notify user)
Will be thankful for advice where to place it to web-interface. I'm thinking of placing textfield and button in device edit dialog. Or make new dialog and call it from settings menu?

Renamed path

Merged, thanks.


Add option to add BoilR as a shortcut in steam

Make an option to add a shortcut to BoilR itself from steam.
Make it possible to run the ui and non ui version.
This could be extra useful for steam deck where you don't want to have to enter desktop mode.

This is solved in version 1.3.13


Update to fs-extra 11.+

🧩 Feature request
fs-extra recently updated 11.0.0 / 2022-11-28
See: https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md
Should be as simple as updating the dependency, api has been kept the same.

In fact completed in 6418b7639364042cc0cb45d127c76b1e769484c3


:green_heart: adding docker-hub context

closes #38

Yes I was trying to move it to the workflow steps definition, as per the documentation.
I was indeed missing in the publish-latest step.
I will comment out the filter to test it right on this branch, the latest tag will be overridden once merged back in master.

There is still a workspace issue thought, looking into it.

Should be better now @pyaillet 😉


Testing

Comment on this issue to interact with the Comment Bot and run Terraform plans to create and destroy the infrastructure defined in the testing branch.

/redeploy

This is another comment

/plan

/plan

/apply

/destroy

/apply

/plan

/plan

/validate

/test

/test

/test

/validate

/apply

/show

/apply


Issues of training both instance contrast and index contrast

Hello, I appreciate your work and I have read your code. For self-supervised pretraining, either instance contrast or index contrast is trained in the code in my understanding. Is there code implementation of training both instance contrast and index contrast? And for implementation, are MLPs in instance contrast and ConvMLPs in index contrast weight-sharing?
I am looking forward to your reply. Thank you!

Hi~I'm feel so sorry for my mistake. I miss the glboal branch (instance contrast) in the first released commit. I have added the possible implementation of training both instance contrast and index contrast in IndexNetModel/IndexNetContrastMo.py and trainer.py.
Moreover, the MLPs in instance contrast and ConvMLPs in index contrast  are not weight-sharing (see IndexNetModel/IndexNetContrastMo.py).
Thank you for your interest to our work, more questions on the implementation are welcome !


App crash if firebase_auth + geolocation

If I use firebase_auth + geolocation simultaneously, it crash and dont know what to do. If I use either it runs.

Same as #10
See that issue for a proposed workaround

Yeap.


SPLIT.4.2 - dipstaging queue

Changes to CouchDB views and updates to manage the queue needed for Smelter.

I tried to move the VSCode formatting to master separate from this PR, and did it incorrectly.


Add a minimal Duktape-optimized printf() provider to extras

This extra provides a Duktape-optimized printf() which only supports those format codes Duktape actually needs. It's distributed in extras because the format codes should be kept in sync with whatever Duktape needs.
This is useful for barebones platforms where printf() and other standard bindings need to be explicitly implemented (or scavenged). A typical printf() implementation can have e.g. a 20kB footprint, often due to the cost of IEEE double formatting. Sometimes the printf() implementation can be configured for smaller footprint; sometimes not. This extra compiles to less than 1kB.

Added a note on Windows x64 violating the sizeof() assumptions, and also explaining that these are intended for low memory targets.

A related issue is providing a minimal scanf(). That's considerably easier though, there's only one call site for parsing a %p in Duktape, for JX pointer parsing:
src/duk_bi_json.c:        (void) DUK_SSCANF((const char *) js_ctx->p, DUK_STR_FMT_PTR, &voidptr);

It's probably best to bundle this scanf() provider into this same extra because the %p format output should also be parsed back so there's a formatting dependency.
With JX disabled no scanf() calls are used. Another option would be to avoid platform specific pointer formatting for JX or use a configurable provider for it, so that the entire scanf() dependency could be removed.

Now there's a minimal sscanf() in the extra too: it compiles to about 100 bytes.

Testing 32-bit "duk" with minimal printf/scanf:
duk> Duktape.enc('jx', {foo:Duktape.Pointer('foo'),bar:Duktape.Pointer(0)})
= {foo:(0x08f85af8),bar:(null)}
duk> obj = Duktape.dec('jx', '{foo:(0x08f85af8),bar:(null)}')
= [object Object]
duk> obj.foo
= 0x08f85af8
duk> obj.bar
= null

Date formatting uses %02d etc:
duk> new Date()
= 2016-05-22 03:33:32.397+03:00

Had to fix one more bug. Final sizes on x86:

duk__format_long() helper: 137 bytes
duk_minimal_vsnprintf(): 477 bytes
duk_minimal_snprintf(): 43 bytes
duk_minimal_sprintf(): 43 bytes
duk_minimal_sscanf(): 90 bytes
nybble lookup: 16 bytes

Total is 806 bytes.


Change in HTML -index and menu file

Description

Related Issues

Closes #

Type of PR

[ ] ()

Screenshots / videos (if applicable)

Checklist

[ ] I have gone through the contributing guide
[ ] I have updated my branch and synced it with project main branch before making this PR
[ ] I have performed a self-review of my code
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ ] I have commented my code, particularly in hard-to-understand areas.

Additional context:

@sumitrajput96 please mention the issue number and full the PR form properly

@sumitrajput96 please also resolve conflicts

Ok Done,  Please merge

@sumitrajput96 please fill the PR template and mention the issue number

Mam, I was direct changes without create issue in github but my changes was correct and good for project so i have no issue number

Mam, please merge the request


[e2e]: go tag main config-ldflags-assets slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.203
Run: https://github.com/slsa-framework/example-package/actions/runs/3834691309
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.203
Date: Wed Jan  4 02:42:15 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.204
Run: https://github.com/slsa-framework/example-package/actions/runs/3843358490
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.204
Date: Thu Jan  5 02:44:30 UTC 2023
Tests are passing now. Closing this issue.


Set mode to 440 for TLS secrets

Description

Fixes https://github.com/projectcalico/cni-plugin/issues/459
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

@fasaxc thanks, PR updated


Getting face-api.js to work with a non-realtime video (i.e. no webcam)

I'm new to face-api.js, and I've watched the video tutorial to implement real time detection.
Now, I would like to do the same thing with a generic video with its own source, like this:
<video controls id="video" autoplay src="sintel.mp4"></video>
How should I change the code here to do it?
function startVideo() {
  navigator.getUserMedia(
    { video: {} },
    stream => video.srcObject = stream,
    err => console.error(err)
  )
}

you  should draw the video to canvas
requestAnimationFrame(draw(video))

function draw(v) {
      if (v.paused || v.ended) return false;
      canv.height = video.videoHeight
    canv.width = video.videoWidth
      ctx.drawImage(v,0,0,v.clientWidth,v.clientHeight)
      setTimeout(draw, 20, v);
    }


Cache-busting doesn't seem to name the file properly

I want to use cache-busting with:
STATICFILES_STORAGE = 'pipeline.storage.PipelineCachedStorage'
In my index.html template, I call this tag {% stylesheet 'styles' %}
It translates to what looks like a cache-busted url: /static/css/styles.a26c39c46e80.css
However this url returns a 404. So I checked the name of the file that is actually written in filesystem and it is still styles.css
Is this related to the output_filename setting?
'output_filename': 'css/styles.css',
Am I missing anything?

Solved.
Actually there was an error during compilation due to an .otf not found referenced in a css file.
This caused the compilation not to go through the end, and I guess, styles.css was just the old file not being overwritten.


implement HTMLElement.innerText

It seems HTMLElement.innerText was thought about when drafting the designs but forgotten since then.
I guess it could be a simple alias to .textContent since there is no rendering involved.

innerText is supposed to filter out things like scripts and other non-user visible content.

@ejsmith in browsers using DOMParser CSS doesn't apply, so I mirror that behaviour in Deno DOM. Observe main.js in this example https://gist.dumber.app/?gist=04003019076de935dd57a2f81932788b

Hmm... interesting. Seems to be against what this says: https://developer.mozilla.org/en-US/docs/Web/API/Node/textContent#differences_from_innertext

Hmm... interesting. Seems to be against what this says: https://developer.mozilla.org/en-US/docs/Web/API/Node/textContent#differences_from_innertext

See https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/innerText#value. DenoDOM is not a browser and does not render anything, and therefore this is spec-compliant behavior.

I didn't expect it to render anything, but I did expect it to skip things like script blocks.

You'll need to take that up with WHATWG, I'm afraid.

I'm not saying to go against whatever the spec is, the link I pointed to above seems to say that innerText is only supposed to show user visible text.

The part I was linking was this:

A DOMString representing the rendered text content of an element. If the element itself is not being rendered (e.g detached from the document or is hidden from view), the returned value is the same as the Node.textContent property.

It's specified in HTML§3.2.7:

The innerText and outerText getter steps are:

If this is not being rendered or if the user agent is a non-CSS user agent, then return this's descendant text content.

Note: This step can produce surprising results, as when the innerText getter is invoked on an element not being rendered, its text contents are returned, but when accessed on an element that is being rendered, all of its children that are not being rendered have their text contents ignored.

(emphasis mine)


"Given domain name does not redirect to host"

When submitting my domain name through "Add domain name for TLS" in the Control Plane, it returns "Given domain name does not redirect to host"
Same happens with
curl -XPOST -d "domain_name=$my_domain" localhost/control-plane/domain-name -u "USERNAME_PLACEHOLDER:PASSWORD_PLACEHOLDER"

The server is setup on GCP, spun with a snowplow-mini-0-6-1-large tarball, exactly like https://github.com/snowplow/snowplow-mini/wiki/Setup-guide-GCP
I double-checked and DNS indeed has an A record for my domain pointing to the External IP of my compute instance. HTTPS is allowed in the firewall.
Maybe something to do with the fact the collector is running in a docker container?

Thanks for sharing this issue @thsr , next release will be re-checking domain name usage, we're aware that it is broken right now

Thanks @oguzhanunlu  any workaround to enable SSL on a snowplow instance? or when 0.8.1 would it be possible to update from 0.7?

Hi @alperakgun , no workaround I'm aware of. I think we'll include it in the next release, likely to be 0.9.0.


Posting review comments fails

Trying to comment on the review in https://github.com/MessageKit/MessageKit/issues/666 shows a “Something went wrong”.

Bug Report Dump (Auto-generated)

Version 1.19.0<PHONE_NUMBER>)
Device: iPad7,3 (iOS 11.3)
TestFlight: false

It throws here.
The JSON:
▿ 2 elements
  ▿ 0 : 2 elements
    - key : "documentation_url"
    - value : https://developer.github.com/v3/pulls/comments/#create-a-comment
  ▿ 1 : 2 elements
    - key : "message"
    - value : Not Found

So posting to this comment returns a 404, but replying to other PR threads works.
(lldb) po response
▿ [Request]: POST https://api.github.com/repos/MessageKit/MessageKit/pulls/666/comments
[Response]: <NSHTTPURLResponse: 0x60800043c900> { URL: https://api.github.com/repos/MessageKit/MessageKit/pulls/666/comments } { Status Code: 404, Headers {
    "Access-Control-Allow-Origin" =     (
        "*"
    );
    "Access-Control-Expose-Headers" =     (
        "ETag, Link, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval"
    );
    "Content-Encoding" =     (
        gzip
    );
    "Content-Security-Policy" =     (
        "default-src 'none'"
    );
    "Content-Type" =     (
        "application/json; charset=utf-8"
    );
    Date =     (
        "Sun, 06 May 2018 00:17:44 GMT"
    );
    "Referrer-Policy" =     (
        "origin-when-cross-origin, strict-origin-when-cross-origin"
    );
    Server =     (
        "GitHub.com"
    );
    Status =     (
        "404 Not Found"
    );
    "Strict-Transport-Security" =     (
        "max-age=31536000; includeSubdomains; preload"
    );
    "Transfer-Encoding" =     (
        Identity
    );
    "X-Accepted-OAuth-Scopes" =     (
        ""
    );
    "X-Content-Type-Options" =     (
        nosniff
    );
    "X-Frame-Options" =     (
        deny
    );
    "X-GitHub-Media-Type" =     (
        "github.v3; format=json"
    );
    "X-GitHub-Request-Id" =     (
        "9CB8:75DB:2096332:4D00B96:5AEE49A8"
    );
    "X-OAuth-Client-Id" =     (
        a8488ca1ed943b610815
    );
    "X-OAuth-Scopes" =     (
        "notifications, repo, user"
    );
    "X-RateLimit-Limit" =     (
        5000
    );
    "X-RateLimit-Remaining" =     (
        4994
    );
    "X-RateLimit-Reset" =     (
<PHONE_NUMBER>
    );
    "X-Runtime-rack" =     (
        "0.035767"
    );
    "X-XSS-Protection" =     (
        "1; mode=block"
    );
} }
[Data]: 110 bytes
[Result]: SUCCESS: 110 bytes
[Timeline]: Timeline: { "Request Start Time": 547258664.175, "Initial Response Time": 547258664.729, "Request Completed Time": 547258664.729, "Serialization Completed Time": 547258664.729, "Latency": 0.554 secs, "Request Duration": 0.554 secs, "Serialization Duration": 0.000 secs, "Total Duration": 0.554 secs }
  ▿ request : Optional<URLRequest>
    ▿ some : https://api.github.com/repos/MessageKit/MessageKit/pulls/666/comments
      ▿ url : Optional<URL>
        ▿ some : https://api.github.com/repos/MessageKit/MessageKit/pulls/666/comments
      - cachePolicy : 0
      - timeoutInterval : 60.0
      - mainDocumentURL : nil
      - networkServiceType : __ObjC.NSURLRequest.NetworkServiceType
      - allowsCellularAccess : true
      ▿ httpMethod : Optional<String>
        - some : "POST"
      ▿ allHTTPHeaderFields : Optional<Dictionary<String, String>>
        ▿ some : 1 element
          ▿ 0 : 2 elements
            - key : "Content-Type"
            - value : "application/json"
      ▿ httpBody : Optional<Data>
        ▿ some : 97 bytes
          - count : 97
          ▿ pointer : 0x00006080002ed990
            - pointerValue :<PHONE_NUMBER>50736
      - httpBodyStream : nil
      - httpShouldHandleCookies : true
      - httpShouldUsePipelining : false
  ▿ response : Optional<NSHTTPURLResponse>
  ▿ data : Optional<Data>
    ▿ some : 110 bytes
      - count : 110
      ▿ pointer : 0x0000608000157290
        - pointerValue :<PHONE_NUMBER>85968
  ▿ result : SUCCESS: 110 bytes
    ▿ success : 110 bytes
      - count : 110
      ▿ pointer : 0x0000608000157290
        - pointerValue :<PHONE_NUMBER>85968
  ▿ timeline : Timeline: { "Request Start Time": 547258664.175, "Initial Response Time": 547258664.729, "Request Completed Time": 547258664.729, "Serialization Completed Time": 547258664.729, "Latency": 0.554 secs, "Request Duration": 0.554 secs, "Serialization Duration": 0.000 secs, "Total Duration": 0.554 secs }
    - requestStartTime : 547258664.17475605
    - initialResponseTime : 547258664.72867501
    - requestCompletedTime : 547258664.72909296
    - serializationCompletedTime : 547258664.72922397
    - latency : 0.55391895771026611
    - requestDuration : 0.55433690547943115
    - serializationDuration : 0.00013101100921630859
    - totalDuration : 0.55446791648864746
  ▿ _metrics : Optional<AnyObject>

Really not sure what's going on w/ this. It's something to do w/ the scopes we're requesting. If I use a PAT, it works. If I actually login, it doesn't work...

I have also experienced this bug when trying add a reply to an issue that I had opened, here
https://github.com/nodejs/abi-stable-node-addon-examples/issues/12

I cannot reproduce this issue on the prod branch. I suspect it's a bug in the GitHub API V3.

Requests that require authentication will return 404 Not Found, instead of 403 Forbidden, in some places. This is to prevent the accidental leakage of private repositories to unauthorized users.

This is still happening... and annoyingly the apps does not keep the message when it fails to send it.

Oh noes. Would you like to open a ticket to at least persist the message when it fails to send, @ikifof?


Missing version on changelog

Hi,
There is a missing versión in the PowerBI Report Server change log. Version 2.81.5831.1181 is not appearing in the PowerBI Desktop optimized for Report Server but is available for downloading on the following link https://www.microsoft.com/en-us/download/details.aspx?id=56722

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ef9c2df3-28df-34d8-bd4e-4209996f7f8d
Version Independent ID: e5dc42c8-b17a-4e0e-09c5-76124b0ad924
Content: Change log for Power BI Report Server - Power BI
Content Source: powerbi-docs/report-server/changelog.md
Service: powerbi
Sub-service: powerbi-report-server
GitHub Login: @jtarquino
Microsoft Alias: jaimeta

Hi, @nava17490 -- thanks for asking! I'll check and get back to you.

Thanks, @nava17490 ! Got the missing version added. Change will be live tomorrow afternoon.


Dropbox folder/instance as a data source

🚀 The feature
Rather than adding one document at a time, enable the bot to ingest an entire Dropbox folder or directory structure.
Motivation, pitch
Often times, the knowledge on which you want to train the bot is already curated. Pointing it to that repository rather than having to manually enter the URL of each and every file will save a lot of setup time and as well as make supporting more dynamic knowledge bases easier - you don't have to have a preconceived notion of how the knowledge is divided and across which files.

Closing because dropbox dataloader currently accepts folders or directory as input https://docs.embedchain.ai/components/data-sources/dropbox


In DistributedLockService, lock object not removed from the list

Just by enabling the job queue feature, I get this error every minute...
"No record could be found in the database for lock '{0}'."

I could fix it by adding after this line
DeleteDistributedLockRecord(internalName);

This line
_locks.Remove(monitorObj);

Best

In JobsQueueProcessor.cs, because IDistributedLockService is an IDependency referenced by IJobsQueueProcessor that is an ISingletonDependency.
I also use the Work class for this dependency
    private readonly Work<IDistributedLockService> _distributedLockService;

Best

@sfmskywalker, seems to work in other places as in AutomaticDataMigrations. The problem is when it's always the same instance of IDistributedLockService (even there is one per shell) that is executed as in JobsQueueProcessor because it's an ISingletonDependency.
So, can be fix by only applying the last update with the Work<> in JobsQueueProcessor. I've created a PR for this simple fix.
Best

Just by enabling the job queue feature, I get this error every minute...
"No record could be found in the database for lock '{0}'."

I could fix it by adding after this line
DeleteDistributedLockRecord(internalName);

This line
_locks.Remove(monitorObj);

Best

I have had the same "No record could be found ..." issue even after I added Work<> in my singleton service, so I was wondering  why "_locks.Remove(monitorObj);" did not go into the code as a fix?


'identifier' (in plot.identifier) is inaccessible due to 'internal' protection level

To confirm to ScrollableGraphViewDataSource, when i add
func value(forPlot plot: Plot, atIndex pointIndex: Int) -> Double to my code, Xcode gives an error at plot.identifier that "identifier' is inaccessible due to 'internal' protection level". Can anyone help what is going on?
import UIKit
import ScrollableGraphView
class ViewController: UIViewController, ScrollableGraphViewDataSource {
// Class members and init...

var linePlotData: [Double] = [1, 2, 3, 4, 5]// data for line plot
var barPlotData: [Double] =  [1, 2, 3, 4, 5]// data for bar plot
var xAxisLabels: [String] =  ["Jan", "Feb", "Mar", "Apr", "May"]// the labels along the x axis

var numberOfPointsInGraph = 5

override func viewDidLoad() {
    super.viewDidLoad()

    let graph = ScrollableGraphView(frame: self.view.frame, dataSource: self)

    // Graph Configuration
    // ###################

    graph.backgroundColor = UIColor.white
    graph.shouldAnimateOnStartup = true

    // Reference Lines
    // ###############

    let referenceLines = ReferenceLines()
    referenceLines.positionType = .relative
    referenceLines.relativePositions = [0, 0.5, 0.8, 0.9, 1]

    graph.addReferenceLines(referenceLines: referenceLines)

    // Adding Plots
    // ############

    let linePlot = LinePlot(identifier: "linePlot")
    linePlot.lineWidth = 5
    linePlot.lineColor = UIColor.black

    let barPlot = BarPlot(identifier: "barPlot")
    barPlot.barWidth = 20
    barPlot.barLineColor = UIColor.gray

    graph.addPlot(plot: linePlot)
    graph.addPlot(plot: barPlot)

    self.view.addSubview(graph)
}

// Implementation for ScrollableGraphViewDataSource protocol
func value(forPlot plot: Plot, atIndex pointIndex: Int) -> Double {

    switch (plot.identifier) {
    case "linePlot":
        return linePlotData[pointIndex]
        break
    case "barPlot":
        return barPlotData[pointIndex]
        break
    }
}

func label(atIndex pointIndex: Int) -> String {
    return xAxisLabels[pointIndex]
}

func numberOfPoints() -> Int {
    return numberOfPointsInGraph
}

}

While I was waiting for a reply to this, I went to Plot class and made the indentifier property public. This has solved the problem. I'll still wait to hear from @philackm on this.

Ah, this is an issue with the access level of the variable. I've made a mistake and will fix it then push it through! Thank you for the submitting the issue.

Should be fixed! Let me know if it is still not working.


[Backport 1.0] Upgrade CXF and reissue certificates (#1943)

Description
Backport 5a17c72791d9a75f87babbc38b8c04c170a52199 from #1943
Upgrade CXF and reissue certificates
The jackson changes from the original pull request as they were later reverted in https://github.com/opensearch-project/security/pull/1959
Issues Resolved

Closes https://github.com/opensearch-project/security/issues/2578

Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

WhiteSource Security Check results are going to be ignored as this is an unsupported branch.

Codecov Report

:exclamation: No coverage uploaded for pull request base (1.0@dc1045b). Click here to learn what that means.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@          Coverage Diff           @@
##             1.0    #2579   +/-   ##
======================================
  Coverage       ?   64.85%
  Complexity     ?     3219
======================================
  Files          ?      247
  Lines          ?    17271
  Branches       ?     3056
======================================
  Hits           ?    11201
  Misses         ?     4521
  Partials       ?     1549

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Phase 2 Implementation RenderLoopDelegate

Need to clarify how much control RenderLoopDelegate has, and what it's related render methods will be called.  The goal is to get the view drawing a generic Scene object, and potentially have RenderLoopDelegate to the preparation and any post-render work.

This PR has turned into a GitHub Pages development. The new target is partially developed, but given that no commits regarding the new target are actually in this branch, I will rename and redirect its focus toward completion of the new SwiftOpenGL Tutorial website.


How to hide deleted message for one user

Suppose User A has deleted all the messages in the thread with user B. Now user B is able to check all the messages in the thread but user A is not which is good. Now when User B sends a new message to user A then User A is able to check the all his deleted message as well.
What I want to achieve is if user A deletes a thread for himself then he shouldn't be able to view all deleted messages if user B sends a new message.
Can anyone help me on this?

hey @debuGhy, thanks for using the package!
I have the opinion that if User B replies to an old/deleted thread then it should just reactivate the thread for the user that deleted/hid it. This makes the application code a little easier to manage.
One thing that you could do is only show User A the newest messages only, hiding any that came before the deletion. That way you could keep the same thread.
Hope that helps 🙂

Also coming up against this, maybe it's best to have an extra column in participants, deleted_thread_at then we can only show messages that appear after this date.

Hello @cmgmyr , Thanks for your suggestion.
I added two columns in database.
Table: threads
New columns: delete_creator,delete_participant
Table: messages
New columns: delete_creator,delete_participant


series_as_features.base.estimators.interval_based

I'm not sure why this exists and is in this location, may be some legacy code. It should be integrated into classification I think

This is where code lives shared between classifiers and regressors. Happy to move this somewhere else but classification doesn't seem like the right place if it's shared by regressors.

I think it should be in classification or utilities and avoid cloning, especially whilst regression is in development but I'll take a closer look


Setting request timeout for URLs

Version 0.39.6 on linux/docker
With the new version, request timeout is somehow reduced. I am watching a URL which loads in about 40 seconds, always falls into timeout of changedetection. Therefore it doesn't work. It was working until this version.
The solution could be allowing the user set the timeout globally and per record. I can't find a way to modify request timeout.

Try to define exactly what is 'request timeout', there is no setting exactly called 'Request Timeout', add a screenshot or your backup zip file..

Request timeout is the time passed after which the request is considered "timed out". If request timeout is set to for example 30 seconds, all HTTP requests which doesn't finish within 30 seconds will halt immediately logging that the request was unsuccessful due to timeout.
Changedetection has a lower time out setting with the new version. So one my watched URLs stopped reporting diffs as changedetection always fails to fetch this URL. But in fact the URL works perfectly fine; except that it returns data in a longer time than changedetection expects.

Now this is interesting because that URL I am watching usually exceeds 15 seconds. It is odd that it coincided with the upgrade and it is more odd that it could never fetch this URL again even for once.
Whatever.. How can I manually change the default timeout? By the was I'd suggest this to be a feature allowing it to be set per URL in the UI.

Is there an option to automatically retry pages which time out, a specified number of times? For instance I prefer using teddit.net for Reddit and the main instance doesn't have a great availability.
HTTPSConnectionPool(host='teddit.net', port=443): Read timed out. (read timeout=15)

Is it possible to edit the default timeout value (15) with an environment variable?
I'm using the docker image and some of my requests are taking around 30 seconds to resolve.

It can be edited in the store.py file but this is not an effective method. Every time you restart the service or update your image, your modifications are gone. It should be an option which you can set for each URL separately.

No. As I said you have to edit store.py file manually and change the timeout value which will effect all URLs. BUT this is not a good and reliable solution. Because each time the container restarts or you update to a new version, that modification you made will be lost.