How to setting up pyAudioAnalysis

I am new to Raspberry Pi (Raspbian), I have successfully installed all the dependancies, now i am trying the sample codes that provided by pyAudioAnalysis, when I run the codes, the system shows ImportError: No module name pyAudioAnalysis. which i dont understand that python path steps. can anyone teach me? I have added export PYTHONPATH=$PYTHONPATH:"/home/pi" in the .bashrc file, but i dont understand about update the path details which is source ~/.bashrc .........may i know where  to type soruce ~/.bashrc???

have u placed the library in the /home/pi folder?
you just type  source ~/.bashrc in any terminal

yes.. my library is in the /home/pi folder already...... i have also typed "source /.bashrc" in my raspberry pi terminal... but when i run the code in python... python still cant detect the library...

In ~/.bashrc, you will want to add the full path to the pyAudioAnalysis directory.
So if the directory is located in /home/pyAudioAnalysis, add the following line to your ~/.bashrc file:
export PATH="/home/pyAudioAnalysis/:$PATH"
Then try running source ~/.bashrc again.

in which path have u cloned pyAudioAnalysis exactly?


Set feedkit spec homepage to github project.

This prevents trouble with bundler > 1.9 and fixes issue #1.

Thank you very much!


Update KubeDescheduler

Include 'mode'
Correct management_state typo

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

!verified

!cherry-pick v4.11

!cherry-pick v4.11

!test-label

!verified

!-verified

!verified

!cherry-pick v4.11

!cherry-pick v4.11


When I run delve as root, none of my vendor packages are being found

What version of Delve are you using (dlv version)?

1.0.0-rc.1

What version of Go are you using? (go version)?

go version go1.8.3 darwin/amd64

What operating system and processor architecture are you using?

Mac OSX El Capitan - x86

What did you do?

I ran delve as sudo from my project's directory ($GOPATH/src/project/) because I need to listen on ports 80/443.

What did you expect to see?

I expected to see all my packages being found and my program being compiled as usual.

What did you see instead?

I saw a number of path errors such as:
cannot find package "golang.org/x/net/context" in any of: 	/usr/local/go/src/golang.org/x/net/context (from $GOROOT) 	/Users/ev/go/src/golang.org/x/net/context (from $GOPATH)
These are all files that are in my Glide /vendor at the root of the project.
This does not happen when I run delve as my default user.

Delve just calls go to build. I just tried and I get the same thing when doing sudo go build on one of my project. I don't know if it's indetended behavior but it's what go does.

Alright, the reason is that your $GOPATH is something other than $HOME/go and sudo won't forward it to delve. You would have to do sudo -E dlv...


Switch from cachelib to flask_caching

The recent 0.3.2 release seems unreliable. People reported issue #119 the next day.
I received similar report from a repo that I'm maintaining, and one suggestion led to a solution. This PR backport that solution from my fork. It will probably fix #119.

Alternatively, flask-session can upgrade its cachelib dependency when/if that library releases its next version with its fix.

Closing this PR because that upstream fix was released 7 hours ago.


How to identify the target subset in subset membership change operations?

For the AddNodeToSubset and RemoveNodeToSubset changes, the subset the node should be added to/removed from is supposed to be represented by the in_subset slot of a AddToSubset or RemoveFromSubset mixin. That slot expects a OntologySubset, defined in ontology_model.yaml.
But OntologySubset has seemingly no slots at all (either directly or inherited from OntologyElement), so how one is supposed to know which subset the change is about?
Shouldn’t OntologySubset have a id slot to identify the subset?

Closing as this has been fixed by #62 (by making OntologySubset a type of Node, therefore giving it an ID).


"Loading..." does not disappear

"Loading..." does not disappear for most entries in the list. For me, all but the last show "Loading". For newly loaded ones it disappears.
And I can't seem to find the code where it is told to appear/disappear :/

solved by 12cbb711227e4b79f3753b4b44bed68660a238b8


No mechanism exists for including a total count on a query result

The previous azure-mobule-apps client SDK allowed fetching a total count for a table query using the IQueryResultEnumerable but this mechanism does not appear to exist in the current SDK even though a public API appears to exist to request it using the .IncludeTotalCount() method on Microsoft.Datasync.Client.Query.ILinqMethods
To Reproduce
Create an ITableQuery using an IOfflineTable instance.  Invoke the IncludeTotalCount() method and enumerate the results and notice there is no way to retrieve the total count.
Expected behavior
The resultant query interface should either have a CountAsync() call or the ToAsyncEnumerable() should return a type that allows retrieving the total count value (similar to the old version https://stackoverflow.com/questions/35546443/how-to-access-the-data-returned-by-includetotalcount-with-imobileservicesynctabl)

Question for you.  If you cast the response to the AsyncPageable, can you get the count?
i.e.:
var query = table.CreateQuery().IncludeTotalCount();
var enumerable = table.GetAsyncItems(query) as AsyncPageable<T>;
Console.WriteLine(enumerable.Count);

Should work on either a remote table or offline table.
If this works, I'd love to work with you to suggest an API for this.  Perhaps something like this could work? (Proposal only)
// Option 1: Count based on a query
var query = table.CreateQuery().Where(/* whatever */);
var count = await table.CountAsync(query);

// Option 2: Count within the confines of the async enumerable - Count is deferred until first read.
var enumerable = table.IncludeTotalCount().Where(/* whatever */).ToAsyncEnumerable();
// set up Count as an observable int property
await foreach (var item in enumerable)
{
  Count = enumerable.Count ?? -1;
  /* Do something with item */
}

I do get the AsyncPageable as the return type but the long? Count property is null when I use an offline table
var query = table.IncludeTotalCount();
var result = (AsyncPageable<SettingEntity>)table.GetAsyncItems(query);
Assert.AreEqual(6, result.Count); // fails here where result.Count == null

I think I prefer option 1 over option 2 -- but probably because I don't fully understand how option 2 is supposed to work.
I think option 1 should be supported on the ITableQuery interface directly in addition to having the method exposed on  IOfflineTable<T> or IRemoteTable<T> (similar to the way ToAsyncEnumerable is present on both Query and Table types).
Option 2 looks maybe closer to what the API is setup for today. But it confuses me. With option 2 it looks like you must first start enumerating items to get the count. What is the return type of the enumerable var? I'm not sure I understand what //set up Count as an obervable int property means in practice.
This makes me wonder internally how it would get the count if I can both retrieve a count and enumerate the items.  If it's a deferred count query, are there technically still 2 queries being executed (one for the total count and one to enumerate items)? Is the ToAsyncEnumerable return type changing to another type that explicitly has a count property on it, similar to (or the same as) your AsyncPageable?  IAsyncEnumerable already has a CountAsync extension in the base class library, so I would be tempted to use that, so it sets things up for some ambiguity. Ideally the Count query would never actually pull any records out of the database.

The IAsyncEnumerable<> that we have is a deferred paging mechanism that hides the paging for you.  It doesn't execute a request until you request the first item.  Underneath, the AsyncPageable<> is the concrete implementation of that.  The AsyncPageable<> has the Count field on it.  However, it is not set until the first request is made, which is when you request the first item.

How many items are pulled into the page on the 1st iteration if all I want is the count?  Ideally I'd avoid any deserialization of records at all if I only want the count.  So I can see use cases for both options you presented -- the 1st being more efficient if all I care about is the count value, and the other if I may be enumerating the whole list of query results conditionally based on the count.

Will be in the next release.  Supported API:

// Count items in table
long count = await table.LongCountAsync();
long count = await table.CountItemsAsync();

// Count items matching query in table
long count = await table.Where(/* whatever */).LongCountAsync();

var query = table.CreateQuery().Where(/* whatever */);
long count = await table.CountItemsAsync(query);

This incurs a round trip (to the database or remote service).  You can also combine it with an IAsyncEnumerable as we discussed if you don't want to incur the round trip for counting alone.

Well done! Excellent response time!


Documentation could be improved by being clear about incompatibility with AssetMapper

Hi,
On a fresh install (Symfony 6 and 7) after following the doc for installing symfony/ux-react (with webpack-encore-bundle). I get this when running yarn watch (or npm run watch)
Module build failed: Module not found: "./assets/app.js" contains a reference to the file "@symfony/ux-react".
(same for stimulus-bundle)
The reason is that it's not compatible with asset-mapper.
I found the solution here : https://stackoverflow.com/a/77720816/5251749
I think it would be great to write in the doc that symfony ux components are not compatible with asset-mapper (installed by default for webapp).
Thank you 😃

I’m not sure to understand « what » is not compatible with AssetMapper, but there is no « yarn watch » with AssetMapper.
And AssetMapper is the default asset component now.
Maybe what you mean is that WebPack doc should mention it does not work with AssetMapper ?

Hi @smnandre ,
Thank you for your answer. Well you are right, what I mean is that WebPack does not work with AssetMapper and so when using npm install to download symfony ux components (after composer require), only webpack was downloaded in node_modules.
It's just that I struggled on this problem and couldn't find any solution on the web, so I think it could help some people to raise this issue.
Thanks

Hi!
We have this at the top of the ux-react docs:

This package works best with WebpackEncore. To use it with AssetMapper, see Using with AssetMapper.

Maybe the warning isn't obvious enough?

Maybe the warning isn't obvious enough?

It wasn't for me but It may be enough. I agree with your previous comment.

I'm going to close for now. We can see if anyone else has issues. And if so, think about some changes then.
Thanks!


Problem adding NHRangeSliderView via Storyboard

Can you add an example in your demo app?
When I tried to add a UIView in storyboard an change it to be NHRangeSliderView class, it doesn't work. I'm only able to add it programmatically.

@rcmcastro

This is how you do it: drag a normal UIView into a view controller.
Select the view you just dropped and go to the Identity Inspector. In the Custom Class section, change the Class and Module values to NHRangeSlider, and viola!. See attached image, hope this helps...it's the same approach for all these controls that claim Storyboard compatibility.


Implement a function to record the painting in JPG or PNG format, and allow the drawing player to save it to his local device.

9ed0571b518fd97c28e42f6fada2d72e680df7bb


Re-apply "[test] Yet more tweaks to remote-run"

Reverts apple/swift#19138, re-applying #19130. I'll tweak the Apple-internal configuration instead.

@swift-ci Please test


Add doc for upgrade substrait

Folllow PR for https://github.com/facebookincubator/velox/pull/3697: add doc for how to upgrade substrait

cc @mbasmanova

A basic question regarding this document @leoluan2009 :
Is there some sort of manual validation that has to be done when updating substrait ? If not , Would it not be possible to do this via some cmake script that takes the github tag , copies over protos and builds Velox ?

@kgpai  Good suggestion, I have submit https://github.com/facebookincubator/velox/pull/4163 follow your propose, can you help to review


image-rs: Handle gzip whiteouts correctly

This PR readds whiteout handling on platforms that support xattr
Fixes: #604

@squarti @Xynnn007 are you aware of any tools that helps to inspect a container image to figure out if it contains gzip whiteouts?

@squarti @Xynnn007 are you aware of any tools that helps to inspect a container image to figure out if it contains gzip whiteouts? Or any sample image that can be used for testing this PR?

I am not aware of any tool.  I used this image ghcr.io/actions/actions-runner:latest to test it

@squarti @Xynnn007 are you aware of any tools that helps to inspect a container image to figure out if it contains gzip whiteouts? Or any sample image that can be used for testing this PR?

I am not aware of any tool. I used this image ghcr.io/actions/actions-runner:latest to test it

FWIW, I've built images with whiteouts using the distroless tooling in the past. In case it's useful..

Thanks @squarti
Let's keep an eye on image unpacking when we next  bump guest-components just in case.


Start Date Functionality?

Hello, I've tried using start:yyyy-mm-dd but it seems to have no effect. I was hoping the task with a start date would be hidden until that date. Just curious, what functionality is build around the start date?
Thanks.

Hi @velardevines . So far there is no functionality behind the start date. If you use sleek to add a new todo, the start date will be added automatically like mentioned here as the "creation date" https://github.com/todotxt/todo.txt.
Initially I thought it might become handy, if sleek would at some point create statistics on how long you needed to finish a task.

Hi @velardevines . So far there is no functionality behind the start date. If you use sleek to add a new todo, the start date will be added automatically like mentioned here as the "creation date" https://github.com/todotxt/todo.txt.
Initially I thought it might become handy, if sleek would at some point create statistics on how long you needed to finish a task.

As this is not an issue, I would like to close this thread. Nevertheless I added to my roadmap to think of possible use cases on what to do with the start date.

As this is not an issue, I would like to close this thread. Nevertheless I added to my roadmap to think of possible use cases on what to do with the start date.


Docs(web-react): Add Checkbox demo #DS-889

Description
Checkbox demo in web-react is now same as demo in web
Issue reference
Demo: Checkbox má ve všech technologiích stejná dema

Otherwise, this PR is looking good 👍

Please check out my draft of the Checkbox demo when I was testing click outside. There are some more examples we should add to the demo, IMHO.
#969

We agreed with @crishpeen that the demo you mentioned would be better suited within compositions in Storybook.


Adding support to setLanguageCode to FirebaseAuth

related issue:
flutter/flutter#19525

@ffeu Thanks for the PR, this looks good. Could you please:

update comments on dart side.
Bump version number of plugin
Update CHANGELOG with change.

LGTM

Hello, the email updateEmail sent is in English, after I set different laguage like this
await FirebaseAuth.instance.setLanguageCode('es');
final user = await FirebaseAuth.instance.currentUser();
await user.updateEmail('example@gmail.com');

I am doing correct?
Thanks

@basketball-ico
Hi, the language code must be in IETF, try setLanguageCode('es-419') (latin america spanish) or setLanguageCode('es-ES')(spain spanish).
PS: the best place for questions like this is stackoverflow.

@ffeu Hi thanks I try this, but the updateEmail is send in english, the resetPassword  and emailVeification email are sent in the language that I set.


Add new feature project: WasmEdge

What is the project title?
https://github.com/WasmEdge/WasmEdge
What is the project URL?
https://wasmedge.org/
What is the project description?
WasmEdge is a high-performance WebAssembly (Wasm) Virtual Machine (VM) runtime, which enables serverless functions to be embedded into any software platform; from cloud's edge to SaaS to automobiles. In its Ahead Of Time (AOT) compiled mode, WasmEdge is the fastest Wasm VM on the market today. WasmEdge is an official sandbox project hosted by Cloud Native Computing Foundation (CNCF)
What kind of project is this?
An open source Wasm VM runtime with AOT compiler optimization

Thank you @tpmccallum! Please let us know via PR or issue if the description and title formatting are too your liking on the site.


fix: fix publish workflow status issue

Summary
I changed the triggering of the publishing workflow.
And now both Branch Main and  Next will be triggered on push any commit. It is also will be triggered when a Pull Request has been merged.
[skip ci] is added for release commits that do not trigger the workflow on next or prod publish again.
For releasing production,  it tries to merge the next into main by --no-ff strategy, To make sure that a new commit is made And previous commits that may have [skips ci] Do not prevent workflow from triggering.
Fixes # (issue)

Fix close PR issue: Workflow should not be run when closing the PR. Now by putting the trigger on the push, this problem is solved.
Fix the workflow status of each commit: When the PR trigger was on pull_request, The status of commit workflows was not detected. Now by putting the trigger on the push, this problem is solved.

How did you test this change?
Testing scenarios:

Making a pull request on next then merge the PR, it should publishing next versions correctly.
After merging PR into next, You can run yarn release-prod it should trigger the production Github Actions and publish production.

Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

lgtm.


Add tests to check the seek behaviour of leafNodeIterator for post PR#489 merge

After PR#489 lands, this will add some more tests, to show the seek behaviour is captured.

ok, that was was messier, than I expected, should have just waited. But when #489 lands, this should also be merge-able.

These are only new tests so I will merge them without further delay.


Fix CTAS support NULL type

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] others

Which issues of this PR fixes ：

Fixes #6074
Problem Summary(Required) ：

null type should be supported, not throw an error.

[FE PR Coverage check]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/analyzer/CTASAnalyzer.java
2
2
100.00%


Write a Java program to print numbers from n to 1

Description
Write a Java program to print numbers from n to 1
Input  : 5
Output : 5 4 3 2 1

How to contribute

Save the solution in program/PrintNumbersFromNTo1.java file
Add PrintNumbersFromNTo1.java file in print-numbers-from-n-to-1 folder

!assign


Expanding a folder with thousands of files hangs vscode

In the Explorer tab it's dangerous to expand folders with 10k+ files as it's likely to hang. It seems reasonable to stop enumerating files after a certain limit.

#18180


[SPARK-5135][SQL] Add support for describe table to DDL in SQLContext

Hi, @rxin @marmbrus
I considered your suggestion (in #4127) and now re-write it. This is now up-to-date.
Could u please review it ?

Can one of the admins verify this patch?

Thanks for submitting the new version. Are these two PRs working on the same thing? https://github.com/apache/spark/pull/4207 Would be great if you two can chime in on each other's PR.

yeah, @rxin, would you like to talk with @marmbrus for what we'd like to show in describe extended table in SQLContext and then file a JIRA issues?  So that we can do it separately but not in this PR ?

@marmbrus this looks good to me. Any more comments?
@OopsOutOfMemory would be great to bring this up to date with master. Thanks.

May AmplabJenkins test this please ?

Jenkins, test this please.

Test build #26743 has started for   PR 4227 at commit a3061a5.

This patch merges cleanly.

Test build #26743 has finished for   PR 4227 at commit a3061a5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26743/
Test PASSed.

I'd like to merge this into 1.3.0. Can you address the two comments I have and make sure it still works with other changes?
btw does this one conflict with your other change? https://github.com/apache/spark/pull/4249/files

Hi, @rxin Thanks for the advice.
I refined the code according to your advice now I think it's ready to go.
yeah, this PR is a little conflict with https://github.com/apache/spark/pull/4249/files. They all modified logical DescribeCommand. But I think it's not a big deal. This two PRs (this and #4249). No matter which one will be merged first, I'll bring the other one up-to-date quickly. And I don't want to resolve the two issues in One PR which make issues untraceable.

Jenkins, retest this please.

Test build #26855 has started for   PR 4227 at commit 053826f.

This patch merges cleanly.

Test build #26855 has finished for   PR 4227 at commit 053826f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26855/
Test PASSed.

Thanks. Merging now.


Revert "Change drupalyman to source"

Reverts DoSomething/northstar#35
Adds back in drupal_uid.

@jonuy

:+1:


Issue #442

Fixed as per request

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kyungjaeson sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

So checking the docs it always returns a string.
Double checked the application via debugger, and it's an empty string.

Thanks!


build: update 'flutter_secure_storage' to version 6.0.0

Closes #97

@rultor merge it.

@rultor merge it.

@rafamizes Done! FYI, the full log is here (took me 3min)


Feature Request: Support for Structured Questions and Responses in Scripted Aider Using Pydantic Models

Issue
Summary
When using aider as part of a scripted or agentic workflow, it becomes important to have structured, reliable responses from the model to allow for programmatic flow control. This feature request suggests the addition of structured questions and guaranteed structured responses, leveraging models like GPT-4o that support Pydantic or Zod models. By exposing hooks for this within aider, it would allow scripts to interact with aider in a more deterministic and structured manner, driving automated processes with minimal human intervention.
Proposed Enhancement

Structured Questions Using Pydantic/Zod Models:

Allow aider to accept structured questions, where the response is guaranteed to follow a specific schema (e.g., JSON format using Pydantic or Zod models).
This would enable aider to ask detailed questions about the code, workspace, or progress of the session and provide responses that can be consumed by the script controlling aider.
Example:{
  "response": "yes",
  "confidence": 0.97
}

Scripted Aider Flow Control:

A script could ask a detailed question (e.g., about the state of the code, linting results, or following conventions) and get a structured response back.
This structured response could then determine the next action, such as:

Terminate the script if an error is found.
Undo the last action.
Pause and notify for human input.
Attempt a backup prompt to address issues.

Configurable Model for Structured Questions:

Since only certain models like GPT-4o support structured responses with Pydantic/Zod models, there should be a configuration option for specifying the model to use when asking structured questions.
This would allow users to ensure the correct model is used for reliable, structured output.

Use Case Example
When dealing with large codebases, package upgrades often lead to breaking changes that require significant refactoring. One common scenario is the deprecation of methods from third-party libraries. For example, when a method is deprecated, developers need to replace every instance of it with a new method. This is further complicated when the new method requires additional arguments that were not needed in the deprecated version.
Manually identifying and refactoring code across hundreds of files can be tedious and error-prone. Automating this process allows developers to focus on higher-level tasks while ensuring consistency and correctness.
How This Example Code Helps:
The provided script automates the process of identifying and fixing deprecated methods across all .py files in a directory. It uses aider's query_with_response_model to scan each file for library imports and deprecated method usages. If found, it replaces the old method with the new one, adding any additional required arguments. Finally, it runs a linting step to ensure the code is correctly formatted and follows the required coding standards.
This approach can save significant time in large refactorings, minimize human error, and ensure that all instances of the deprecated method are updated consistently.
Simple Explanation of the Logic:

Loop through all Python files: The script scans each .py file in the directory.
Check for library import: If the file imports the library in question, continue. Otherwise, skip to the next file.
Find deprecated method usages: If the library is imported, the script identifies every usage of the deprecated method.
Fix the deprecated method: For each finding, the script instructs aider to replace the deprecated method with the new method and add the necessary argument.
Lint the code: After processing all files, the script runs a lint check to ensure that the changes adhere to the project’s style guide.

Pseudocode:
For each .py file in the directory:
  Add the file to aider's session
  Ask aider: Does this file import the required library?
  If no:
    Drop the file and continue to the next one
  If yes:
    Ask aider: Find all instances of the deprecated method
    For each usage found:
      Ask aider to replace the deprecated method with the new one
      Add the necessary arguments to the new method
    Drop the file after processing
Run a lint check to verify the code quality

Example of how the aider script could look
from aider.coders import Coder
from aider.models import Model
from pydantic import BaseModel, Field
from typing import List
import glob

# Pydantic model for yes/no response with confidence score
class BinaryResponse(BaseModel):
  response: str  # Either "yes" or "no"
  confidence: float = Field(..., ge=0.0, le=1.0)  # Confidence score between 0 and 1

# Pydantic model for findings in the code
class CodeFinding(BaseModel):
  finding: str  # The deprecated method name
  line_number: int  # The line number where it was found
  context: str  # A snippet or brief context of the finding

class CodeFindings(BaseModel):
  findings: List[CodeFinding]

# Initialize aider with a model and the files to work on
model = Model("gpt-4-turbo")
fnames = glob.glob("*.py")  # Find all .py files in the directory

coder = Coder.create(main_model=model, fnames=fnames)

# Define the deprecated method and the new method name
deprecated_method = "old_method"
new_method = "new_method"
new_argument = "'required_arg'"

# Loop over all Python files in the directory
for fname in fnames:
  # Add the file to the coding session
  coder.run(f"/add {fname}")

  # Check if the file imports the library in question
  query_import = f"Does the file {fname} import the library 'library_name'?"
  import_response = coder.query_with_response_model(query=query_import, response_model=BinaryResponse)

  # If the file doesn't import the library, drop it from the session and continue
  if import_response.response == "no":
    coder.run(f"/drop {fname}")
    continue

  # If the file imports the library, check for uses of the deprecated method
  query_deprecated = f"Find all instances of '{deprecated_method}' being used in the file {fname}."
  findings_response = coder.query_with_response_model(query=query_deprecated, response_model=CodeFindings)

  # Loop over all findings and instruct aider to fix each instance
  for finding in findings_response.findings:
    line_number = finding.line_number
    context = finding.context

    # Instruct aider to replace the deprecated method with the new method, adding the new argument
    prompt = (f"On line {line_number}, replace the usage of '{deprecated_method}' "
              f"with '{new_method}', and add the required argument {new_argument}. "
              f"Here is the context: {context}")

    coder.run(prompt)

  # Drop the file from the coding session after processing
  coder.run(f"/drop {fname}")

# After processing all files, run linting
coder.run("/lint")

Natural Language as Unit Test:

This structured question/response model could also serve as the basis for natural language-driven unit tests.
Example: Auto-test by prompting aider to check if code follows naming conventions, and receiving structured JSON feedback on test results.

For instance:

{
  "unit_tests": [
    {
      "test_name": "Variable Naming Clarity",
      "input_code": "int tmp = 5;",
      "expected_result": "fail",
      "actual_result": "fail",
      "metadata": {
        "issue": "Variable name 'tmp' is not clear",
        "suggestions": [
          "Use a more descriptive name, e.g., 'tempValue' or 'temporaryCounter'."
        ],
        "severity": "medium"
      }
    },
    {
      "test_name": "Casing Convention - Camel Case",
      "input_code": "int TempValue = 10;",
      "expected_result": "fail",
      "actual_result": "fail",
      "metadata": {
        "issue": "Variable 'TempValue' does not follow camelCase convention.",
        "suggestions": [
          "Rename the variable to 'tempValue' to match the camelCase convention."
        ],
        "severity": "low"
      }
    }
  ]
}

Pre-Built Pydantic Models for Common Queries:

Include pre-built models for common structured queries such as simple yes/no responses or error reports.
Example: A Pydantic model for yes/no questions that also returns a confidence score.

Example:

from pydantic import BaseModel

class ResponseModel(BaseModel):
    response: str
    confidence: float

This allows for rapid integration of aider into larger workflows where decisions can be made based on the model's structured responses, improving automation.
Benefits

Enhanced Automation: Allowing aider to interact programmatically with a script by providing structured responses ensures greater automation without human intervention.
Flow Control: Enables detailed control of the program’s flow based on reliable, structured data, e.g., undo actions, retry prompts, or awaiting human intervention based on the returned result.
Structured Unit Tests: Enables natural language-driven unit testing, where results are returned in a structured format that aider can then use to drive subsequent actions.
Reduced Duplication of Effort: Instead of building a separate agent to manage this functionality, this enhancement would leverage aider's existing understanding of the codebase and workspace for more effective integration into workflows.

Conclusion
This feature would greatly enhance aider's usability in automated workflows, agentic processes, and scripting, by providing structured responses that can guide the flow of execution based on the content and feedback received.
Version and model info
No response

Thanks for trying aider and filing this issue.
This seems out of scope for aider.

I understand. Aider lets you chat with your code, and it lets you script Aider. This feature would be needed to let your scripting chat with your code. You need predictable, machine-readable responses to do that, and Aider is already great at chatting with your code -- just not in a scripted manner.

I'm going to close this issue for now, but feel free to add a comment here and I will re-open. Or feel free to file a new issue any time.


Full default config file?

Where can I find a full configuration for other models such as the one shown as an example for Mask-RCNN in the documentation website?

Nevermind. I found it in the base/models directory!


Tag filter does not properly click checkboxes

Removed react-multiselect-checkboxes in favor of vanilla react-select with isMulti prop. This resolved issues with drop box selection.


Added content model to image with caption

Added content model to image with caption
Description
Added content model which has a link to the lightbox media viewer. Also, there is an anchor link to the content model.
Changelog
New

Content model
Anchor link to content model

@mfearer94 Any additional changes based on Jame's feedback?

@photodow can you please check the latest changes and see if these address all your comments?
cc: @JennySanchez

@photodow Need a review on this one.


make all tests separate modules [phab:D1315]

Created by evmar at 2017-02-07 21:37:40:
By default in TypeScript, files are "scripts", where every declaration is in
the global scope.  If the file has any import or export declaration, they
become a "module", where declarations are local.  To make tests isolated from
one another, prefix each test with an export {} to make them modules.  In
larger TypeScript projects this doesn't come up because all files are modules.

zarko wrote at 2017-02-07 22:03:29:
Please rebase this; I can't apply it to test it.

zarko accepted this revision at 2017-02-07 22:49:03

zarko closed via commit af3103314848a6ece8137f4a0059b8b3d99096df at 2017-02-07 22:49:32


Update survey default values with data from DB when filling survey

Hello
I created survey with survey_kit commit: 41f32291e87b4c0e41f75b9d7e6bebaa3723a6c9.
At the beginning of the survey, the person's ID is asked. After inserting the person id, I want to check in the DB if the person already exists. If yes, the default survey values will be replaced with the values from the DB. Can I do it and how?
Also, I want to log after every step that goes through in the survey. Can I do it and how?
Thanks in advance

Hey @VladEfanovNewton ,
Pre-loading survey with existing results; I think there are two parts of this: A) you have to persist previous results and B) you'd need to populate the survey object.

For A) check out #79 - I think you could use the toJson and fromJson methods implemented there and store the results in your DB.

For B) this functionality is not yet implemented in the plugin. If you're interested in doing it, maybe start by looking around in survey_presenter.dart. I'd think changing theSurveyPresenter() constructor to get the pre-loaded SurveyResult object and init the Set<QuestionResult> results field with that (instead of setting it empty) could work. At that point you'd need to change how you call SurveyPresenter() in survey_kit.dart but it might not be a lot of work actually altogether.

Alternatively, if your questionnaire is not too long, you might get away with using something else. For example form-management plugins like
reactive_forms or
flutter_form_builder
that are more fine-tuned for realtime validation and can pre-populate form fields with existing values.

Logging: you can only catch navigation events and e.g. log something when those happen (see SurveyController), listening to single user taps (selections of an answer) is not provided by the plugin.
I'd start at looking at createView() in question_step.dart: all the different answer view types would probably need to provide an onAnswerChanged() or similar callback that you can then use at QuestionStep level... It would be certainly more effort to implement than the previous point.
Both features would be very nice to have though so consider opening separate new tickets for enhancement.

Very much interested to see B) implemented. @adar2378

@Numoy Any plan for this? We would also like to prefill the survey with previously completed results from the user.

I will try to integrate this with the next feature release!


Remove status disclaimer from pydoc root.

The Python SDK is stable now, no need to scare first time users. :)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Thanks :)


Convert *string to string.

What kind of change does this PR introduce? (check one with "x")
[*] Bugfix
[] Feature
[] Code style update (formatting, local variables)
[] Refactoring (no functional changes, no api changes)
[] Other... Please describe:

Fixes: #174
What is the current behavior?
coerce.toString not able to convert string pointer to string
What is the new behavior?
Added string pointer to string

Out of curiosity, where is the string pointer coming from?

@fm-tibco it comes from AWS Go SDK.  AWS SDK using pointer of string.  Customer just set AWS object to activity output which face the issue.


Appstudio update rhtap-demo-component-yggd

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: rhtap-demo-component-yggd-on-pull-request-
creating pipelinerun rhtap-demo-component-yggd-on-pull-request- in namespace rhtap-demo-dev-pqqg-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


InstantiationStatementTests.cs:55: 60m/DEV Fix this.

The puzzle 76-ab64b10e from #76 has to be resolved:
https://github.com/DenisZhukovski/ObjectToTest/blob/8b1d2165defd551b53eac272eea8f33eda738235/tests/ObjectToTest.UnitTests/InstantiationStatementTests.cs#L55-L55
The puzzle was created by Denis Zhukovski on 22-Dec-22.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 76-ab64b10e has disappeared from the source code, that's why I closed this issue.


Force synchronous

Added | Out-Null to each command to force synchronous execution, works for everything except the database data import in Powershell IDE, so removed deployment instructions using Powershell IDE
Changed deployment instructions to use Powershell instead of the Powershell IDE.

@mwasham Reworked deploy to use powershell instead of powershell ISE, also added commands to potentially force synchronous operations.


Upgrade to Apache Camel 3.0.0-M1

If possible try out the RC on VOTE and give it a test with camel-k.

done


Introduce source maps for SCSS files

When inspecting where a rule is coming from in the browser, you will find it comes from main.css, but this file does not map to any file in the project. Style in the project is written in .scss files. These get compiled by Webpack to a single CSS file that is what the browser receives. This makes it quite hard to debug which .scss file contains the offending rule. This can be improved by using source maps.
TODO:

[x] Figure out how to generate and bundle SCSS source maps.

Hint:

This can probably be done in Webpack or PostCSS config files.

Done in #33.


Integrate CrowdIn translations

https://trello.com/c/i0f6X4wO/123-remove-plain-text-and-add-translation-files

I'm not sure about how CrowdIn works, but when exporting it creates separate folder for each language and that folder contains all files added to CrowdIn.
I wanted to split translation into different objects, but I don't think CrowdIn can handle it. CrowdIn works best with CSV files - with JSON we cannot add new strings via interface - it's CSV only feature. Exporting translations happens in the same format as source files (so if we use CSV for source file it will export all CSV files).
Not sure if it's issue with GitHub, CrowdIn or some kind of misconfiguration but GitHub sync doesn't work (Sync Issue).

Closing this because CrowdIn doesn't support / in branch name.
Use #646


Error: clone repository: ssh: handshake failed: knownhosts: key mismatch

OS: MacOS Monterey 12.5.1
SSH Configuration seems to be fine, ssh -T<EMAIL_ADDRESS>works

you need ssh-add ~/.ssh/id_rsa

In my case, it turns out that my key in known host was obsolete.

Open  ~/.ssh/known_hosts, search for github, remove the line.
Run ssh -T<EMAIL_ADDRESS>and accept the key
Run protodep up

Alternatively, ssh-keygen -R github.com should work as well.


Found via fuzzing: File takes really long to unpack

This was found while fuzzing ancient. Not sure if much can be done here, since the file in question appears to be identified as an encrypted file, so ancient appears to brute-force an encryption key. However, given the size of the file (9KB), the time to open the file (ancient eventually gives up) is disproportionate (it took several minutes here). Maybe this can be improved?
fuzzing result.zip

Very interesting file. Thanks for this
The PX20 bypassing is basically done in a way that it makes a tree-search of the 32-bit keyspace and uses the property of the compressor that wrong bits guessed have early-failure and invalidate a (large) leaf out of the keyspace. This made the keyspace search feasible since it now takes some milliseconds vs. the some minutes/hours that ppcrack can take when they use linear time. I wont have code in my library if it can't be trusted to open a file in a reasonable time...
Of course, with proper kind of input you can force bad behaviour on this code, and that is what we are seeing here. I need to investigate a bit what can be done.

There was a small improvement I could make (close to a bug almost) where ld-values were compared only for the length part.
Not necessarily a blocker since the behaviour was correct and the input needed to trigger this is pretty much artificial, nevertheless fixed (runtime from 600s down to 1.7s, I doubt I can do better)

Yeah, 1.7s sounds pretty usable. No doubt the input is artificial, but such artificial inputs need to be considered for example in environments where untrusted input is handled, e.g. imagine a website where people can upload old modules or graphics files and the website tries to decode them to verify that the user uploaded a valid file. In that case, keeping one server connectiong busy for 10 minutes could quickly lead to a Denial of Service.

No disagreement from here. I’ll soon-ish combine other fixes and make a new release

Perfect! I can also confirm locally now that the file loads in a much more reasonable time now.


Dockerfile request

Hi, could you provide us with a dockerized version of the code? Thanks!

Someone submitted a PR with a dockerfile

You can find the PR here


Add support for MacOS

it would be awesome to see this library add support for MacOS apps. example: https://github.com/insidegui/WWDC/issues/86

Hello, can you please file a feature request through public issue tracker.
https://developers.google.com/cast/support
Thanks!

Lol no, I don't even remember what this is. It's three years later


FoundationDB dialect integration

This is now ready for review.
For "test_all.sh", at first I wasn't sure about adding foundation, but ultimately I figured it was best to include it.
One interesting lesson I learned while implementing this dialect is that the FoundationDB DATETIME type does not support timezones.

--- PASS: TestCompatibilityMode (0.00s)
=== RUN TestOpenExistingDB
`sqlite` is not officially supported, running under compatibility mode.


Wrong example to update multiple sites at once

In the section "Block or limit access to a specific SharePoint site or OneDrive" you show an example (the 3th once) to update multiple sites at once. The shown example is out of my opinion wrong.
Your actual example:
,(Get-SPOSite -IncludePersonalSite $true -Limit all -Filter "Url -like '-my.sharepoint.com/personal/'") | Set-SPOTenant -ConditionalAccessPolicy AllowLimitedAccess
Should be:
(Get-SPOSite -IncludePersonalSite $true -Limit all -Filter "Url -like '-my.sharepoint.com/personal/'") | Set-SPOSite -ConditionalAccessPolicy AllowLimitedAccess
So the comma at the beginning should not be there. Don't know what the comma at the beginning should do.
Then you set for each found site, the rule on tenant level. I think you like to set the value for each found site itself!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2f2abda5-9273-1a56-91b6-e4e77d5706b0
Version Independent ID: 6a85f2a5-b892-55f7-b49a-4ab15f1e8b73
Content: Control access from unmanaged devices - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/control-access-from-unmanaged-devices.md
Service: sharepoint-online
GitHub Login: @kaarins
Microsoft Alias: kaarins

@AlyaKoni Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hello @AlyaKoni Konrad, how are you?
About the comma, the article states:

This example gets the OneDrive for every user and passes it as an array to Set-SPOTenant to limit access. The initial comma and the parentheses are required for running this cmdlet as a batch request, which is fastest.

About the Set-SPOTenant, have a look at this, as the change was rejected by product team, anyway I'll try to revisit this 👍

Hello @AlyaKoni Konrad, how are you?
Set-SPOSite does not take pipelined input.
I could confirm with the team that the cmdlet is correct.
Thank you
cc @kaarins

As of https://docs.microsoft.com/en-us/powershell/module/sharepoint-online/set-sposite?view=sharepoint-ps the cmdlet Set-SPOSite has a parameter [-Identity]  which takes pipelined input.
It's Set-SpoTenant which does not take any pipelined input. There is no parameter documented which can take pipelined input. So what's the sense behind the example, piping several sites to a cmdlet which does not take pipelined input?
Your example is doing following thing: get all existing OneDrive site collections and set on tenant level for each found site the property ConditionalAccessPolicy. So as an example, if you have 200 OneDrive site collections, you set 200 times the property ConditionalAccessPolicy on tenant level. Why you should set 200 times the same property? What's the reason behind?
After this command all 200 OneDrive site collections still don't have set the property ConditionalAccessPolicy on site level. Which is not, what the example text states: "update multiple sites at once". No site at all will be updated. Only the tenant about 200 times!
This example is definitely wrong!

@AlyaKoni Konrad, how are you? hope you are doing good!
I also thought at first that Get-SpoSite | Set-SPOTenant couldn't be right however I could get information from the team and they informed me that was ok.
I also tried it and the policy at Tenant level was never affected (when running just like that, with the pipe)

Please kindly share with me your test results and I would be glad to review them.

Did some testing. Set-SPOSite looks like completely broken. Using the undocumented feature referenced in the completely misleading and non understandable example from the side, everything works! So you are right. The example works correctly.


[backport] Fix cupy.cumsum on ROCm 5.0

Backport of #6520 by @takagi

/test mini

@kmaehashi, would you merge this if Jenkins is okay?

Timeout happening as cu file is modified.
pfnCI, run Jenkins please.


TableCreationMode.DROP_CREATE is not working

Hi
My code is like this :
           DatabaseSource source = new DatabaseSource(this, Models.DEFAULT, 1);             if (BuildConfig.DEBUG) {                 // use this in development mode to drop and recreate the tables on every upgrade                 source.setTableCreationMode(TableCreationMode.DROP_CREATE);             }             Configuration configuration = source.getConfiguration();             mEntityDataStore = new EntityDataStore<Persistable>(configuration);
With all that I changed the Entity and the table is not created so whenI try to run a query I get :
android.database.sqlite.SQLiteException: no such table: Node (code 1): , while compiling: select id, numberOfKeys from Node where id = ?
Any advice please ?

Whenever you make schema affecting changes you need to increment the schemaVersion. Right now you have it fixed at 1 so the table creation code is not run after the first time you run the application.


Exception on first syncdb with high replication / SQlite dev server

WARNING:root:The rdbms API is not available because the MySQLdb library could not be loaded.
Creating tables ...
Traceback (most recent call last):
  File "manage.py", line 11, in <module>
    execute_manager(settings)
  File "/a/django/testapp/django/core/management/__init__.py", line 438, in execute_manager
    utility.execute()
  File "/a/django/testapp/django/core/management/__init__.py", line 379, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/a/django/testapp/django/core/management/base.py", line 191, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/a/django/testapp/django/core/management/base.py", line 220, in execute
    output = self.handle(*args, **options)
  File "/a/django/testapp/django/core/management/base.py", line 351, in handle
    return self.handle_noargs(**options)
  File "/a/django/testapp/django/core/management/commands/syncdb.py", line 109, in handle_noargs
    emit_post_sync_signal(created_models, verbosity, interactive, db)
  File "/a/django/testapp/django/core/management/sql.py", line 190, in emit_post_sync_signal
    interactive=interactive, db=db)
  File "/a/django/testapp/django/dispatch/dispatcher.py", line 172, in send
    response = receiver(signal=self, sender=sender, **named)
  File "/a/django/testapp/django/contrib/contenttypes/management.py", line 20, in update_contenttypes
    content_types.remove(ct)
ValueError: list.remove(x): x not in list

Only happens sometimes (nearly always with one particular project), fairly hard to reproduce, feels like a concurrency issue (but disabling threading doesn't help) or something similar to this: https://code.djangoproject.com/ticket/7052. With testapp I get it most often after adding:
DATABASES['default']['DEV_APPSERVER_OPTIONS']
    = { 'high_replication' : True, 'use_sqlite': True, }

and using a specific set and order of INSTALLED_APPS:
'django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.sessions',
'django.contrib.sites',
'djangotoolbox',
'autoload',
'dbindexer',
'djangoappengine',

Note that the order is actually significant -- swapping auth with contenttypes seems to fix the issue... Also note that for testapp frequency of this happening may be low (varies a lot depending on what exactly you have in settings), so to see it you'll likely need something like this:
for i in {1..100}; do rm -r .gaedata; python2.7 manage.py syncdb --noinput; done

whats the value of ct that is not in the list?
does turning off high_replication help? maybe using high replication on the dev server does some eventual consistency emulation.

Removing 'high_replication', 'use_sqlite' or any of the contrib apps
does help.
When the exception occurs the content_types list is empty while Django
is trying to remove 'site'.
On Sun, 2012-01-08 at 08:11 -0800, Alex Burgel wrote:

whats the value of ct that is not in the list?
does turning off high_replication help? maybe using high replication on the dev server does some eventual consistency emulation.

Reply to this email directly or view it on GitHub:
https://github.com/django-nonrel/djangoappengine/issues/11#issuecomment-3402777

i ran into this issue myself recently. i'm pretty sure its an eventual consistency issue.
i was able to work around it by temporarily changing the consistency policy, but its a bit of a hack. it also requires modifying the command code.
a better solution might be to always run commands with a strong consistency policy and then change to eventual consistency explicitly. like when running tests or the actual app.


refactor: use node protocol on imports

Curious: what's the rationale for doing this?

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-node-protocol.md

So it's only about style, right?
The style should be determined by the maintainer, not by contributors. Thus closing. (Personally, I'm in favor of this rule, but it isn't my role to take that decision. It should be @nitedani that takes the decision in that regard.)
It's best when contributors focus on bugs of feature requests, while leaving stylistic decisions to the maintainers.

Is a best practice to get more readability and a standard used by the Node.js (documentation) and the community.
Have no sense to reject a simple and completed PR because focus is on other side. Projects should receive all the help they can get especially since they are still under the (early) development stage.

I do personally agree it's a slightly better. But, again, it's best when it's the lead maintainer that takes these kind of decisions which are more often than not subjective. For example, your PR introduces a merge conflict to Joël's PR. (That's actually why I would reject such PR on Vike core: I wouldn't want a PR to introduce a merge conflict to other PRs for merely a stylistic change.)
It's also best if contributors trust maintainers and let maintainers lead. So I'll ask you to be a little bit careful about that. Thank you.


Select option to perform an operation on a set of users

In an organization account, to change a member role, revoke an invitation or remove a member from the organization, the operation has to be done for each user. By providing a select option, a set of users can be selected on which an operation can be performed.

Priority - 1/3

Priority - low


Update User Guide to use TAPros keywords and phrases

and edit minor typos like add to addstu.
Question: should we do this incrementally? i.e. keep making PRs to minor edits on our documentation? Idm doing this

Question: should we do this incrementally? i.e. keep making PRs to minor edits on our documentation? Idm doing this
Yes, we can do this incrementally, and we should do this incrementally anyways, since our documentation would change as our product evolves. We should try to have separate PR for documentation and for code, so that the PR review process would be more straightforward and probably faster.


[WIP][SPARK-49816][SQL][FOLLOW-UP] Fix conflicting CTE ids

What changes were proposed in this pull request?
This is a follow-up PR that reverts https://github.com/apache/spark/pull/48284 in the first commit and offers a new way to deal with the issue of conflicting CTE ids. This PR generates new CTE ids for conflicting ones and retains the pre  https://github.com/apache/spark/pull/48284 reference counting logic. See the the details in https://github.com/apache/spark/pull/48284#issuecomment-2391887954.
Why are the changes needed?
The previous PR relied on the fact that nested, connected CTEs get flattened during resolution (see an example why it worked in a some cases: https://github.com/apache/spark/pull/48284#issuecomment-2386982325), and so the remaining WithCTE nodes in the plan are surely self-contained. If we can't rely on that fact then we need a more robust solution.
Does this PR introduce any user-facing change?
No, because currently some issues (https://github.com/apache/spark/pull/48284#issuecomment-2389011706) can come up with manually assembed plans only. (I think we should not consider an issue user-facing if it can't be reproduced with public APIs.)
How was this patch tested?
Existing and new UTs.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @cloud-fan


typeahead: Add option for word order not mattering for query matching.

Fixes: Uptil now, the query_matches_string function always respected the order of words in the query string when matching a source string. This meant that for query "two one", the source string "one two three" would not be matched.
To make this more flexible, a default parameter order_matters has been added to the function. When it's passed in as false, the function returns true if each word in the query string matches the prefix of any distinct word in the source string, else it returns false.
The algorithm for computing this is quadratic in terms of the source word count so can be a little expensive but it is only currently used for searching topics in Recent Conversations, where the strings' length is limited by the max stream / topic name length allowed, so this should be performant enough for this use case.
Related CZO thread: https://chat.zulip.org/#narrow/stream/9-issues/topic/Filter.20Stream.20List/near/1501097
Screenshots and screen captures:
Before:

After:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Thanks! To help with manual testing, can you add a note to the PR description regarding where in the app this change applies?

I noticed that before I add a space, suffix matches seem to count:

With a space:

I think the intent in this PR is the latter behavior (no matches)?

@alya This is old behaviour that allows any substring match when there is no space in the query, and the new order_matters option is only considered when we have at least 1 space (hence multiple words for order) in the query.
But yes, this does seem buggy and inconsistent so I'll fix this to ensure matches are always prefix

Merged, thanks for maintaining this for so long. I have to admit it took quite a while to read, which is why this sat so long, but I think this is a good improvement.


bug/CollectionValidator fixed bug, so you can pass validator while cr…

Tried to create collection with validator in migration script, but it was impossible. Now it works :)

thank you for contribution


Add fetchAllPages utility function.

Allows all pages of a given relationship to be retrieved.

Should be good to go.
@sandersonet - :+1: / :-1: ?

:+1:!


Implement active filter

We may filter pets with/without active announcements using active=true or active=false

I've decided to reopen this issue due to the tests.


43 create 1 unit test and 1 widget test for c3

added basic widget tests for the Sign In page widgets and for the form validators of Sign In/Up.

Is this runnable on iOS now?

Is this runnable on iOS now?

updating to the latest flutter version should make it runnable, I don't have an iOS emulator to check further


bug(minimise): minimise not functioning as expected when viewport not at top of page on load

I'm submitting a...
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior
sn-minimise class not applied correctly to nav element in repo example app when page loaded with viewport not at top of page.
Expected behavior
sn-minimise class should be be applied as normal (e.g when page loaded with viewport at top of page)
Environment
This repos demo app.

Came here for the same issue. +1

@edoparearyee any chance this might get implemented?

Hi @mbarbuscio thanks for using this library. Unfortunately we've been very busy recently so not had a chance to take a look at this yet. This should be fixed as it's a bug. Hopefully have a chance to look at it within the next week or so.

I am unable to replicate this in the example app so closing for now. If someone can successfully replicate this issue I will reopen it.

Just tested this thorougly. Apparently, the component works fine if you add the (minimiseChange) event handler on the element that has the directive. If there is no event handler, when you navigate or refresh the page whatever is the current scroll will be taken as the initial position and not apply the minimise class.

@mbarbuscio I tested this and found out this wasn't the issue. I was able to replicate this by turning on OnPush change detection instead.
Will get a fix out soon.


Can't install v1.2.0

🐛 Bug
I think v1.2.0 was released, then rolled back as a pre-release. I was able to install it a day or two ago, but this is no longer possible.
To Reproduce
pip install --upgrade pip  # ensures that pip is current
pip install unbabel-comet==1.2.0

Expected behaviour
unbabel-comet v1.2.0 is installed
Screenshots

Environment
OS: Linux 4e9e05fda7ba 5.15.0-56-generic #62-Ubuntu SMP Tue Nov 22 19:54:14 UTC 2022 x86_64 GNU/Linux
Packaging: pip 22.3.1 from /usr/local/lib/python3.10/site-packages/pip (python 3.10)
Version
Additional context
Only a day or two ago, I was able to install with poetry & pip.

There's a workaround, of course:
pip install -e<EMAIL_ADDRESS>
but it would be nice if the latest version were in the registry.

Hi @dblandan I released version 1.2.0 but just for a few hours and then decided to roll-back. We want to release new default models but we want to avoid confusion and people reporting scores that are not comparable with previous versions. To avoid that I need to finish documentation on new models first.
Sorry by the confusion! Also, entmax was breaking the install and I asked Ben Peters if they could bump entmax, I see that it was fixed already!


osbuild/util/ostree: add default-deployment option

Modify stages that take in an explicit deployment option to also
allow a default-deployment option. The schemas for these stages
has also been modifed to only accept one of the two.
Create a function that automatically detects the stateroot path
at {tree}/ostree/deploy/{osname}. Used to find the path
for the var directory when using the default deployment option
instead of explicitly specifying the deployment.

Almost there!

LGTM - opened this upstream (rebased and also fixed a few linter issues): https://github.com/osbuild/osbuild/pull/1553


Keep individual commit log instead of aggregating releases

Currently each release bundles the commits from internal Google git servers into a giant commit:
Release 4.0.0 (2024-09-09) · privacysandbox/bidding-auction-servers@722e154
To allow easier reviewing, trackability and troubleshooting each commit should be available individually on github.
It is the case for commits on the key value server  on the main branch and keeping things stable by targeting the latest release branch by default (release-0.17)
Any idea why the workflow has been changed ?

Hi Fabian,
Thanks for your comment. You're right that key-value-service and bidding-auction-servers follow different approaches. One key difference is that bidding-auction-servers releases more frequently (weeks vs. months).
In key-value-service, the main and release branches are detached, whereas bidding-auction-servers maintains a tree structure. some may prefer one over the other.
Tracking and troubleshooting are better done at the release level because our commit history contains more noise. The same applies to troubleshooting, since each release undergoes thorough verification.
Could you share more about your use cases for granular commit history?

Reviewing and tracking are better done at the release level because our commit history contains more noise.

Best practices of open source projects are to make granular commits and review and validate each commit.
Aggregating commits will hide information from external reviewers that is only available internal to Google. Having noise in commits may be an indicator for code quality issues.
I think, as this code base needs to be trusted open source best practices should be adopted. Potentially review tools like chromium's gerrit https://chromium-review.googlesource.com/q/status:open+-is:wip or github pull requests could also be used.
How do you plan on including external contributions (like bug fixes or up streamed changes from ad selection API) if the development branch is not available to the public ?

I don't know what you mean by hiding information. we squash the commit

We develop our code at a fast pace, which can sometimes result in commits that may later be reverted or modified. However, I don't see this as a "code quality issue".
Regarding "hiding information," I believe there may be a misunderstanding. In our aggregated commits, all intended code changes are included and released transparently.
As for external contributions, we already support them. You can submit a pull request to the main branch, and after evaluation, it may be included in next release. Here's an example for reference.
https://github.com/privacysandbox/bidding-auction-servers/commit/1c32ad4ddf5114ed6f04dab5ad9fd83aa998cd7e

Fabian, I agree with your suggestion and our goal is to get to similar level of acquiring PR commits as Chromium. However B&A test and commit infra is currently setup for this.
At this time we are not in a position to accept large scale commits due to this, however we may be able to consider one-off small commits as Xing mentioned above.
All our code changes are transparent and visible. This can be verified by building and matching the PCR0 hashes.

Regarding "hide information," I believe there may be a misunderstanding. In our aggregated commits, all intended code changes are included and released transparently.

@xinggao01Did you try to search individual changes in one of the last releases. probably not as you have access to the real commits.
https://github.com/privacysandbox/bidding-auction-servers/commit/532e2938d0f82687ceda629ba50eaeae2a3a4102
It changes: 189 files changed +5676 -1692 lines changed
So it looks far to me to say that this hides information or at least makes things more difficult to understand than it should be for external developers.


Homepage Text Alignment

The homepage is looking nice but it can be improved by making some alignment adjustments in the homepage text. Through proper alignment and other changes on the text, I can make homepage look even better.
I want to work on this improvement as a part of GSSOC-23.

Any references on figma/dribbble/behance you would follow for this design enhancement?
PRO-TIP: If its a small change, you can tweak alignments on browser and share screenshot for us to decide either we want it or not

This varies from screen to screen. On my big screen it is looking fine as your desired output. Hence, closing this issue


[GURPS] 2.7.3

Changes / Comments

Skills Table. Show Skill Modifier checkbox state was reversed, fixed. Reported by Mike W.
General Tab - Encumbrance Table. The row that matches the current encumberance level is now highlighted.
Combat Tab - Tools. Improvements to Falling and Collision. Added Hard Object checkbox, added tooltip for terminal velocity, updated RAW notes for Falling and Collision.
Combat Tab - Damage table. Added Flexible Armor tooltip.

Files Updated

GURPS\gurps.html
GURPS\gurps.css
GURPS\translation.json

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[x] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


how to install this pkg offline?

I am working on a cluster, which can't be linked to the internet directly. So I want to know how to install this pkg using its source code on LINUX.
Many Thanks!

What do you mean by "install"?  If you cannot do that for one reason or another, simply git clone this repository.
HTH.

Sorry, I am a freshman in Go & es. I've git clone the source code, but i don't know how to build or install it. Could you give me the details of the steps to install or build the source code of elastic pkg.
I know this question seems stupid, but many thanks!

I've konwn how to install it, THX!!!

I'm sorry, but your question is more about general development with Go. Please get yourself accustomed to Go development in general, e.g. by reading How to Write Go Code or by reading a good book about Go development first. I'm afraid, there is no shortcut.


Questions and answers

Would it be possible to read the document and then get GPT to generate x number of questions and answers based on the text.
This could be used to train an AI bot to help answer questions.
My scenario would be around training an AI to be able to explain a company specific topic. Say you got it to read all internal documents on a certain subject - generated over many years. if it then generated 1000's of questions and answers - you could then train a bot to help users.

I'm already working on pregenerating questions to enhance the retrieval of most relevant text fragments. Extending it to pregenerating full Q&As might be the next step. I'll think about it.

Has there been progress in generating questions and answers? I'm interested in that option.


Problem when importing exactly 25 rows

Importing exactly 25 records, with the following command:
ddbimport -inputFile variantItems.csv -tableRegion eu-central-1 -tableName variantIds concurrency 30
will yield the following error
{"level":"info","ts":1632609775.8067422,"caller":"cmd/main.go:435","msg":"starting local import","v":"","input":"variantItems.csv","tableRegion":"eu-central-1","tableName":"variantIds"}
{"level":"error","ts":1632609776.1104505,"caller":"cmd/main.go:475","msg":"error executing batch write","v":"","input":"variantItems.csv","tableRegion":"eu-central-1","tableName":"variantIds","workerIndex":1,"error":"batchwriter: ValidationException: 1 validation error detected: Value '{variantIds=[]}' at 'requestItems' failed to satisfy constraint: Map value must satisfy constraint: [Member must have length less than or equal to 25, Member must have length greater than or equal to 1]\n\tstatus code: 400, request id: OFQNAKDS1RGLADN1N1FRK26KUBVV4KQNSO5AEMVJF66Q9ASUAAJG","stacktrace":"main.importLocal.func1\n\t/Users/adrian/github.com/a-h/ddbimport/cmd/main.go:475"}
{"level":"info","ts":1632609776.1214213,"caller":"cmd/main.go:505","msg":"complete","v":"","input":"variantItems.csv","tableRegion":"eu-central-1","tableName":"variantIds","records":25,"rps":79,"duration":0.314679}

I can provide test data, or more details, as well, if needed.
Thanks for this great tool, by the way!

Ah thanks, I encountered that error myself just last week (with exactly 1M records), I just hadn't remembered to push the commit. I've fixed it in https://github.com/a-h/ddbimport/commit/e926bcd4f06a147a71847e002b06cf21fdc97e87
I'll push a new release.

I've pushed a new release to https://github.com/a-h/ddbimport/releases/tag/v0.0.40
Once you've confirmed it solves it for you, please close the issue. I'm pretty confident it will, because I was running this last week for a client importing test data, and encountered the same problem.

By the way, it did import all the data, it's just that at the end of the file, it was trying to push an empty set of data to DynamoDB, which throws an error.


Change incl guard to ___SOL2_OPTIONAL_HPP___

This does the work required for ThePhD/sol2#102, next is updating the submodule.
By the way, the master branch has diverged from akrzemi1/Optional.

We're divergent because we implemented some niceties for optional<T&> stuff. I could probably make sure to re-merge things back to akrzemi1.

Yeah, I just figured I'd mention the divergence. Not overly important.


First-class support for bin crates

Motivation
Right now, all crates must have crate-type = ["cdylib"]. This causes some issues:

Even though you're creating an application, you need to use src/lib.rs (which goes against Rust idioms).

You need to use this...
#[wasm_bindgen(start)]
pub fn main_js() {}

...rather than this:
fn main() {}

You can't (easily) have multiple binaries, since you can only have one lib per crate.
So that means you need to create multiple crates, link them together with a workspace, then set up a build script to call wasm-pack multiple times (since it can only compile one crate at a time).
This is a pretty big deal: you might want to develop both the client and server in the same crate, but right now that's quite clunky.
Let's compare that with the standard Rust approach, which is to simply make multiple src/bin/ subfolders.

Proposed Solution
Both wasm-bindgen and wasm-pack should have native support for binaries. You should be able to create a src/main.rs file, slap a fn main() {} into it, and have it Just Work(tm).
Similarly, you should be able to create multiple src/bin/ subfolders, and they should also Just Work(tm).
In other words, the user experience should be exactly the same as creating a non-wasm Rust binary.
That means wasm-bindgen and wasm-pack will need to compile multiple binaries at the same time and output them all together into the output folder.
Additional Context
There might be a bit of size bloat caused by using bin crates rather than lib crates. We should investigate what we can do to reduce that.

I personally see one of the bigger drawbacks here that fn main() {}, the ergonomic and more favorable way to do this, generates bigger binaries. Until we get that under control I don't think we can recommand fn main() {} because it gives off a falsely-bad impression.
The bloat comes from the standard library, specifically this function. This basically the initialization routine of the standard library, and while most of this is stubbed out for wasm (and as a result optimized away) there's two main sources of bloat remaining:

Initialization of thread information. The first thing this does is to_string() which brings in a whole allocator, and then there's a mess of synchronization involved as well. The practical effect of this on wasm is that panics are named thread <main> instead of thread <unknown>. We could presumably update something to be a bit more agnostic and not require allocations on the main thread to reduce the size of wasm binaries.

De-initialization of the standard library. There's two reasons that this brings in bloat. The first is that a Once is used to synchronize calls. This synchronizes on other platforms with calls to std::process::exit. The second reason is that it calls at_exit_imp::process() where we don't really have enough information statically to prove that it's a noop on wasm.

Fixing these two are the major sources of bloat, and there's still small pieces here and there but we're talking on the order of kilobytes for above and the remaining would be on the order of bytes.
Now that's sort of the main drawback I see for this today, but even if we were to solve that I'm not actually sure how we would detect this in wasm-bindgen. The perhaps easiest solution is to simply see that main exists as an export and automatically hook it up to start or otherwise arrange for it to be executed. That feels somewhat bad though since it may not always be intended...

That feels somewhat bad though since it may not always be intended...

Could you elaborate more on that?
If somebody has a bin crate with a main.rs file, and they have an fn main() { ... }, and they compile it to wasm32-unknown-unknown, and then they process it with wasm-bindgen... that seems like pretty clear intent to me.

Oh sorry sure, so for src/main.rs we unconditionally want fn main to "just run", 100% of the time. My thinking though is we can't distinguish:
// src/main.rs
fn main() {}

vs
// src/lib.rs
#[wasm_bindgen]
pub fn main() {
    // ...
}

in the latter case we don't automatically run it today, but we should in the former (even though we don't today)

Ah, I see, yes that's tricky. Ideally rustc itself would insert a bit of extra metadata (perhaps in a wasm custom section) so that we can distinguish between bin and lib crates.

True yeah! If rustc did something like that then we could definitely handle this pretty easily. To be clear I'm not sure my example is a blocker at all, just something to point out. The main blocker to me is the binary bloat problem.

does the bloat really need to be a blocker on this issue? it seems to me that "bin crates Just Work(tm) but the output binary is larger than it needs to be" is still better than the status quo, and that binary bloat could be fixed after the fact.

@boringcactus I tend to agree with that perspective, but... we've had a lot of people complain about the size of the .wasm files (and rightfully so). The file size really does turn a lot of people away.
So if the default experience creates huge file sizes, that's really not good. Most people will try out the default way of doing things, see the huge file sizes, then give up completely.
 Large enough to make even me worried (and I care less about file size than other people).

@Pauan if it's so bad it scares people off, i guess that is not actually better than the status quo.
the thread naming issue could probably be solved by just not setting the thread name on wasm, although i'm not sure if that's really the best approach, or how best to implement that. no clue where to even start on deinitialization, though.

FWIW I think a PR to support this would be fine today (to send to wasm-bindgen), it's orthogonal that we could look to improve libstd's support for wasm

unfortunately, inferring the correct export behavior for fn main() for bin crates is conceptually difficult - not only can i not figure out how to do it, i can't even tell where to do it.
however, if we make users toss
#[cfg(target_arch = "wasm32")]
#[wasm_bindgen(start)]
pub fn wasm_main() {
    main();
}

alongside fn main(), then changing wasm-pack to be accept bin crates is fairly straightforward (although i suspect crawling for extra binaries will be non-trivial; i haven't implemented that yet).
things i tried that don't work, and cause entry symbol 'main' defined multiple times:

wrapping main with #[cfg_attr(target_arch = "wasm32", wasm_bindgen(start))]
wrapping main with that and also #[cfg_attr(target_arch = "wasm32", export_name = "run_main")]

"you need to toss this arbitrary chunk of code at the end of your file" is not great. a short-term solution in lieu of something more optimal would be a new proc macro that generates that automatically, like so:
#[wasm_bindgen_main]
fn main() {
    ...
}

does anybody know if "automatically attach things to the entry point of a compiled binary" is even possible without making changes to rustc itself? is "everything will Just Work(tm) but first decorate your main with this proc macro" an acceptable compromise?

@boringcactus wasm-pack isn't really the problem (we can easily change it to accept bin crates), the tricky bits involve changing wasm-bindgen.
We know that bin crates can be supported as-is by wasm, because stdweb fully supports bin crates, no need to add in extra attributes or anything like that.

@Pauan i was interpreting https://github.com/rustwasm/wasm-bindgen/blob/04c9b32e345e524a7bcb74923ff604b24dd77187/crates/cli-support/src/wasm2es6js.rs#L135-L152 and https://github.com/rustwasm/wasm-bindgen/blob/04c9b32e345e524a7bcb74923ff604b24dd77187/crates/cli-support/src/js/mod.rs#L192-L196 as reasons that just using main() as-is doesn't work, but evidently stdweb resolves that somehow.

@boringcactus Yes, the stdweb solution is reasonable: just treat an exported main function as if it had #[wasm_bindgen(start)] attached to it (even if it doesn't have it in the source code).
I'm not worried about the possible confusion with main in lib crates. I think it's quite rare to export a main function from a lib crate, and in any case they can workaround it with js_name if needed.

i think matching based on name and also type signature, and only checking in the first place if no #[wasm_bindgen(start)] was already declared, is specific enough that incidental library coverage will be minimal. it wasn't actually all that much code that needed to be added, but figuring out what code to add and where was the hard part. #1843 is now ready for discussion.

#[cfg(target_arch = "wasm32")]
#[wasm_bindgen(start)]
pub fn wasm_main() {
    main();
}

@boringcactus Yes, I want it. I'm currenly implementing web feature for env_logger, but I found out that I couldn't add wasm_bindgen as a target featured dependency of the binary, otherwise no functions would work. But if I used wasm_bindgen as a universal dependency, everything works well.


Prepare email to advertize the program to send to mailing lists

Mentioning the pre-application webinar
Which mailing list?

SSI
The Carpentries discuss channel
OBF
Life Science Training slack
Galaxy mailing list: developers, training
de.NBI
ELIXIR training platform
Backofen lab
SFBI (french bioinformatics mailing list)

SSI, The Carpentries discuss channel, twitter, personal invites, OBF (confirm next week), life science training slack

I added few others. Feel free to edit the comment to add more


jquery-ui: switch to fetching it via NPM instead of using a vendored version?

I noticed that we are currently storing our own copy of jquery-ui in the repository.
Because it's available on npm I was wondering if we could instead switch to fetching it from there instead.
I looked into the PRs in which @elebitzero has introduced the use of NPM for frontend dependencies and could not identify any particular blocker (see this comment which surveys the state of the libraries we depend on), but I assume there must have been a reason for leaving it out. @elebitzero, do you remember?
This dependency is in maintenance mode, meaning that we shouldn't expect frequent updates, but it would still be nice to fetch it from NPM in case there are some security updates, and as a way to make this repository a bit cleaner.

According to this comment: https://github.com/OpenRefine/OpenRefine/blob/97bc585e47d77a86a33cc0fa8d30b6d1e8deef6a/main/webapp/README.md?plain=1#L9-L11
it wasn't available in NPM at the time, but it looks like that has since been resolved.
https://jqueryui.com/upgrade-guide/1.12/#official-package-on-npm

Hello, I'd like to work on this issue!
To make it clear, I've to add jquery-ui as a dependency in  OpenRefine/main/webapp/package.json (also push the updated lockfile with it)
Also with the specified version 1.12.1 (latest is 1.14.1)

Thanks for volunteering! Yes, and removing the existing copy of this library from the repository, too.


Running CI with a rust-toolchain present

Quoting from https://twitter.com/Sunjay03/status/997336553528610816:

If you use a rust-toolchain file in your @rustlang project, make sure you delete it when you run CI. If you don't, you'll always build on a single version of Rust and your tests will keep passing even if they shouldn't b/c you aren't testing what  you expect

Summary of the thread at this time:

Suggestion: CI should fail if the file is present
Suggestion: CI should auto-delete the file
Concern: pinned versions in two locations in your VCS (in rust-toolchain, in .travis.yml)
Suggestion: CI should run cargo +nightly build, overriding the pin from rust-toolchain
Note: If only building one supported version (e.g internal company code) it's how the version is defined (i.e CI shouldn't always delete it)

/cc @sunjay, @manishearth, @llogiq, @anp

CI should fail if the file is present and the user has explicitly provided rust versions.
Pinning nighties is a common use case for this and CI should allow that.

@Manishearth I agree, although I think that's probably a better thing to do in an editable template (like this repo) than in the application logic of the CI software. Sometimes you have to do weird things :P.


Enable Multi-Window Support

Allow multiple windows (fixes #922)
Keep application running on osx after all windows have been closed (fixes #365)

Changes and refactoring applied to achieve this:

Store window instances in windows global in main/Main.ts
Introduce methods for window handling including focussed window in main/Main.ts
Add menu items and keybindings for new/close window
Make the electronWindow a property of the ApplicationComponent so we can .close() it when all tabs are gone
Move Menu.ts to src/main/ and register it from within the main process, don't bind the handlers to specifit windows
Create handlers in ApplicationComponent for all menu events so we can call them on the currently focussed window
Move Keybindings.ts to src/

Sorry guys, this has gotten larger than expected.
Had to refactor the menu item handlers to emit events on the passed-in BrowserWindow so the commands are directed to the currently focussed window. Hope this won't break with any other changes currently in the queue…
What do you think, @pmkary, @drew-gross & @vshatskyi ?

@jsphpl I plan to close old PRs to keeps things clean. Is it OK with you if I close this one?

@vshatskyi yes, please close it. Looks like this has fallen asleep and needs a new attempt off the new codebase. Has there been any progress on multi window support in the mean time?


Add gofmt to envoy.code.check

Currently gofmt is being added in https://github.com/envoyproxy/envoy/pull/24819
Ideally we run this in envoy.code.check

cc @doujiang24

done in #700


change scan parm

I want to replace the default scan_fov and scan_beams with my lidar parameter.
so, I edit The value of scan_fov and scan_beams in the file gym_bridge.py,but the laserscan is getting weird.
Am I doing something wrong? Or thinking wrong?

I'm not entirely sure but try to change those params in laser_models.py under f1tenth_gym instead of in gym_bridge.py


Bug with cordova (ionic) url protocol

Hey,
I have an issue with the url protocol of video. In your code, you set url src="//www.youtube.com/embed/but in mobile app with cordova, the protocol is file:// so it throw an error...
I think today https is a requirement everywhere so we can just hardcoded src="https://www.youtube.com/embed/ in this lib.
If you're not agree with this, we can create a parameter to set the protocol manually and use it when it is set.
Let me know what do you want and I will create a PR ASAP.

Thanks!

Yes, https is kinda main for those video streaming services. Thanks, will check out PR. 👍

Closing per https://github.com/SamirHodzic/ngx-embed-video/pull/10.


seems cookbook is unable to set/override default username & password

Regardless of what i tried, it seems i can't override guest/guest

and what have you tried? We are all engineers here, lets leave the guesswork out, please.

@nlawson Please provide the options that you have passed and the exact errors or messages you received.

ok, I'm setting the following attributes
{
    "rabbitmq": {
        "default_pass": "xxx",
        "default_user": "guest",
        "enabled_users": [
            {
                "name": "guest",
                "password": "xxx",
                "rights": [
                    {
                        "conf": ".*",
                        "read": ".*",
                        "vhost": null,
                        "write": ".*"
                    }
                ]
            }
        ],
        "loopback_users": [],
        "version": "3.5.1"
    }
}

And my run list looks like this
{
  "run_list": [
    "recipe[rabbitmq]",
    "recipe[rabbitmq::mgmt_console]",
    "recipe[rabbitmq::user_management]"
  ]
}

Oddly if i don't run     "recipe[rabbitmq::user_management]" i can still login using guest/guest

Hi!
If that's your json then you're missing the override_attributes call. something like: https://github.com/stackforge/openstack-chef-repo/blob/master/environments/vagrant-multi-nova.json#L10-L14
Obviously that's for yum cookbook but you should be able to do something like that to help you out.

so the cookbook ignores the environment settings in default?

did try the override_attributes suggestion @jjasghar and the same result

Can you put your whole environment json override file here? I think that's the point we're at here now.

just tried that, and yes the same result

I'm sorry, but I just tested this and i know it works. If you can't give us the information, we can't help you. Please reopen this when you have file that we can look at that you are leveraging for this issue.

@jjasghar i gave you the information, and clearly it's not working, so just closing the issue doesn't resolve the problem.

however removing /var/lib/rabbitmq/mnesia and restarting rabbitmq does properly set the guest password, so I'm guessing there is an issue of order of events issue.

DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=14.04
DISTRIB_CODENAME=trusty
DISTRIB_DESCRIPTION="Ubuntu 14.04.1 LTS"

=WARNING REPORT==== 7-Apr-2015::16:36:02 ===
HTTP access denied: user 'guest' - invalid credentials
=ERROR REPORT==== 7-Apr-2015::16:36:02 ===
webmachine error: path="/api/users"
"Unauthorized"

I'm setting the attributes in the environment, using knife environment edit ...
then changing the json

Yep, that's the crux; you need an override_attribute section to override the default attributes. RE: http://docs.chef.io/attributes.html
I'm thinking you're gonna need something like:
{
    "override_attributes": {
        "rabbitmq": {
            "default_pass": "xxx",
            "default_user": "guest",
            "enabled_users": [
                {
                    "name": "guest",
                    "password": "xxx",
                    "rights": [
                        {
                            "conf": ".*",
                            "read": ".*",
                            "vhost": null,
                            "write": ".*"
                        }
                    ]
                }
            ],
            "loopback_users": [],
            "version": "3.5.1"
        }
    }
}

Can you test the above first? We might have found an issue with the instantiation of the default and additional users; but first test the above if that fixes it it's NOT the fix but it should resolve the issue.
We are going to keep this open till we have a solid answer for this.

I think I've isolated the behaviour:

Changes to default_user/default_pass in the config after initial start are [disregarded] 1
rabbitmq-server starts up automatically on install (at the very least on Ubuntu 14.04)
an unintended consequence and side effect of reusing the guest account in the enabled_users hash is that it reapplies tags and given the lack of the administrators tag the guest account effectively loses admin access.
there may be potential and mostly unrelated issues wrt to using arrays for the data structure containing users/perms

So the only way you can get in and change the initial administrator user would be to lay down the config before the package is installed or else you're stuck with defaults. That said, it looks like the issue at hand has nothing to do with precedence levels or the fact the attributes are set at the environment level. @nlawson it looks like you're getting bitten twice here.
Suggested course of action:

Lay down config before initial install/start or remove option to configure default_user/pass
Note point 3 from above in the README
Add some tests to validate credentials

thanks for digging a bit on this, i have created a wrapper cookbook to uses your cookbook to delete the guest user than create the new admin user with desired password, seems to work alright, however it seems a bit hackish.

it would be curious to set the RUNLEVEL=1 during the dpkg -i event, in many cases this will prevent background process from starting automatically.

I believe the user_management recipe could be fixed to preserve existing tags or at the very least be more intelligent.
If you've already got a wrapper, then I'd advise just using LWRPs themselves directly instead of dealing with the optional recipes which are themselves just opinionated wrappers.
As for setting a RUNLEVEL that seems like a potentially problematic cross-platform solution but there are a few ways that I can think of to get the desired behaviour.

Additionally, there could be more testing of the optional recipes themselves.

i am using the LWRP's in the wrapper, made that part easy, thanks for responding on this, i will admit i could have provided more details on the initial complaint, however on a side note, i felt like i had to fight to get this looked at, didn't leave me with a great impression, i know we all could do better with these kinds of interactions..

Reproducing errors is hard, doubly so without detail. Several folks volunteered their time today to look over this via video chat - I was brought in as a fresh set of eyes and even then it took me a few hours to fully repro and see that there were multiple issues in play.
Sorry that the initial experience wasn't delightful and thanks for reporting so we can make this better!

I do gratefully appreciate all the hard work that goes in to cookbooks like this one, and i'm grateful for this.

I've got a PR #252 open to address this issue and also, as a side affect, simplifies things a bit by having only one service resource declaration. @nlawson this should fix part of the issue but I'll need to open an issue for point 3 from https://github.com/jjasghar/rabbitmq/issues/245#issuecomment-90769131
The fix is 3 parts:

Disable service auto-starting using dpkg
Remove service declaration/starting from being platform specific on Debian platform family
Move rabbitmq.config template before rabbitmq-env.conf as default_user/pass are set on first boot.

I've confirmed this fixes the issue for both Debian and RHEL platform families and also means we are removing a few unnecessary starts/restarts of the service.

Did #252 definitly fix this issue? I'm still unable to change the default username/password as of v4.1.2. I think it's because the rabbitmq-env.conf template causes an immediate restart of the rabbitmq service before the rabbtimq.conf template is processed (which is where the default user/pass are specified):
[2015-08-13T18:03:34+00:00] INFO: Processing template[/etc/rabbitmq/rabbitmq-env.conf] action create (rabbitmq::default line 157)
[2015-08-13T18:03:34+00:00] INFO: template[/etc/rabbitmq/rabbitmq-env.conf] created file /etc/rabbitmq/rabbitmq-env.conf
[2015-08-13T18:03:34+00:00] INFO: template[/etc/rabbitmq/rabbitmq-env.conf] updated file contents /etc/rabbitmq/rabbitmq-env.conf
[2015-08-13T18:03:34+00:00] INFO: template[/etc/rabbitmq/rabbitmq-env.conf] owner changed to 0
[2015-08-13T18:03:34+00:00] INFO: template[/etc/rabbitmq/rabbitmq-env.conf] group changed to 0
[2015-08-13T18:03:34+00:00] INFO: template[/etc/rabbitmq/rabbitmq-env.conf] mode changed to 644
[2015-08-13T18:03:34+00:00] INFO: template[/etc/rabbitmq/rabbitmq-env.conf] sending restart action to service[rabbitmq-server] (immediate)
[2015-08-13T18:03:34+00:00] INFO: Processing service[rabbitmq-server] action restart (rabbitmq::default line 216)
[2015-08-13T18:03:38+00:00] INFO: service[rabbitmq-server] restarted
[2015-08-13T18:03:38+00:00] INFO: Processing template[/etc/rabbitmq/rabbitmq.config] action create (rabbitmq::default line 165)

BTW I was able to verify the above by changing the default_user/default_pass in the .kitchen.yml file and converging a node. After manually installing curl and enabling the management plugin, I was still able to access the dashboard:
vagrant@default-ubuntu-1404:~$  curl -i -u guest:guest http://localhost:15672/api/whoami
HTTP/1.1 200 OK
Server: MochiWeb/1.1 WebMachine/1.10.0 (never breaks eye contact)
Date: Thu, 13 Aug 2015 18:30:01 GMT
Content-Type: application/json
Content-Length: 85
Cache-Control: no-cache

{"name":"guest","tags":"administrator","auth_backend":"rabbit_auth_backend_internal"}

Would changing the rabbitmq-env.conf and rabbitmq.conf's notifications in the default recipe to delayed break all sorts of stuff? It allowed me to change the user/password, but all I was running was the default recipe.