Editing file on a branch via web UI causes "PR broken due to missing fork information"

Description
If I a edit a file from the gitea website, create a PR, and then make another edit to the same file on the branch, I get "This pull request is broken due to missing fork information." I reproduced it on the demo site. https://try.gitea.io/developers/foobar/pulls/6
Gitea Version
1.16.8
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
2.24.1
Operating System
RHEL 7
How are you running Gitea?
Download the amd64 linux binary from the releases page and run via systemd
Database
MySQL

The bug on try was due to hooks not running from a issue with docker versions and alpine 3.14+.
Please try again.

It would be helpful to check https://///graph .
Look at the branch that has is the head of the PR and check its past for where the #PR label is. If it is not concurrent with the top of the PR then your hooks are not running properly.
That could be because your gitea repositories are not mounted on an executable drive, it could be some permissions thing or it could even be that they're not communicating with Gitea properly.

Copy some information here:
https://try.gitea.io/developers/foobar/pulls/6
This pull request is broken due to missing fork information.
The graph:

@stu1811
I tried some operations on try.gitea.io, can not reproduce your problem.

Test 1: edit README on main -> create a new branch patch-xx -> create a PR from branch patch-xx -> edit README on branch patch-xx -> the PR still works well.

Test 2: based on test1, edit edit README on main again -> commit on main -> the PR from branch patch-xx still works well.

Please help to provide reproducible steps.

Maybe it's related to

https://github.com/go-gitea/gitea/issues/18802#issuecomment-1290792260

Since this issue has been inactive for more than 2 weeks, I will close it (as dup), feel free to re-open it with reproducible steps.

Copy some information here:
https://try.gitea.io/developers/foobar/pulls/6
This pull request is broken due to missing fork information.

As we can see there the #6 head is behind the branch head... that explains the "pull request is broken" thing but it's weird and I don't quite understand how that has happened.

If this was only reproducible on try.gitea.io only then the issue was simply that the hooks weren't working on try for a while due to the docker bug and this bug is yet another duplicate of that.

Another duplicate of: https://github.com/go-gitea/gitea/issues/16428, https://github.com/go-gitea/gitea/pull/16451, https://github.com/go-gitea/gitea/pull/16170, https://github.com/go-gitea/gitea/issues/16464, https://github.com/go-gitea/gitea/issues/16484
See https://github.com/go-gitea/gitea/pull/18050
We put a huge warning in to tell people to upgrade their dockers for 1.17.


Improve load testing metrics

Customize Result outputs https://k6.io/docs/results-visualization/end-of-test-summary/#handlesummary-callback
(Optional) Display Metrics in Gitlab

https://github.com/benc-uk/k6-reporter html reports


WIP for Leaflet 1.0

Leaflet 1.0 was release 27-Sep. I've tried to update the the config file to use this but I'm missing something. When I use the module I get the JS console error
Uncaught Error: Cannot find module "./images/"
@SylvainCorlay , I based my changes on one of your commits. Any suggestions?

Sorry for not responding earlier. I am going though all the issues now. We now use leafletjs 1.2.


Clipboard in WSL

Description of the problem or steps to reproduce
When using Micro in WSL (Windows Subsystem for Linux), the clipboard doesn't work at all. When using "Ctrl + C", the message appears:
"Copied selection (install xclip for external clipboard)"
But the clipboard is empty, even inside Micro its not possible to paste via "Ctrl + v"
Specifications
micro -version
Version: 0.0.0-unknown
Commit hash:
OS: Ubuntu 20.4 on WSL 2
Terminal: Windows Terminal

The workaround is this tool which acts pretends to be xclip while actually just being a frontend for the Windows clipboard. It should fix your issue.

Trying upgrading to micro 2.0.11 which should support this out of the box now.

I just tried to update in Debian WSL, but apt couldn't find any updates. I uninstalled, and on attempting to reinstall with sudo apt install micro, I got the error:
Package micro is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'micro' has no installation candidate

Then I tried to use Pacstall, but it's still 2.0.10. I don't want to install it with the plain deb because I want it to be updated easily, but no package managers are working. Help?

I recommend just downloading an official prebuilt binary from the releases page. You could also use the getmicro script to automatically do that: curl https://getmic.ro | bash.

Thanks a lot, I can confirm that it is working now ;-)


add hermes can

add hermes can

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhangwuzhao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Will first let in and revise.


NPE on Query.addParameter when parameter is not present in query

This problem occurs in sql2o-1.5.4.
connection.createQuery("SELECT * FROM TABLE").addParameter("someparameter", 123);
This snippet results in a NPE because "someparameter" is not present at the current query.
Do not throw a NPE or give some hint through the error message what's wrong.
Thanks

Closing. This is a duplicate of #149


Don't delete the doc/html directories when cleaning

The doc/html sub-dirs get created by Configure. Therefore they should
not be cleaned away by "nmake clean". Otherwise the following sequence
fails:
perl Configure VC-WIN64A
nmake clean
nmake
nmake install
Fixes #17114

... this makes me wonder if we really should rely on Configure to create the build directories.  That's pretty fragile.
This is of course to be balanced against having mkdirstatements everywhere, which might not be very attractive either, albeit more robust.

This pull request is ready to merge

Merged to master and 3.0.


Update Environment.swift

Though I don't know which one (0b01, 0b10) is for production, it seemed an unintentional mistake.

Oh, I mistook, and thanks 🙇


ROS2 Support

Is there a plan to migrate this repo to ROS2?

Yes, there are plans for ros2 support, but currently, UFOMaps (the voxel mapper currently used by the package) only supports ros1, so we are waiting for it to be updated with ros2 support.
There are also plans to support other voxel mapping solutions (with support for ros2), but this is currently a low priority.

Support for OctoMap and ROS2 has been added. See the ros2 branch for the ROS2 package.

Thank you


⚠ PrivateHD has degraded performance

In dfbf2f3, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 1446 ms

Resolved: PrivateHD performance has improved in e8dff37.


Not loading images on Mac OS after failed load

If ever there is an "ERROR" loading an image, e.g. "unknown image type", every subsequent image load will not display, even despite reporting "SUCCESS" in the load operation.

Ouch, that's bad. This must have been a bug for quite a while. Thank you very much for reporting it -- should be fixed now on latest master. I'll push a hotfix release soon.


cors bridged is broken

Disable hoverjs for now

(obviously) its a cors issue. hover.cs web scraper


vidmix: use C11 mutex

ubuntu build is working now.
Got this build error on macOS:
-- Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY OPENSSL_INCLUDE_DIR)
-- Configuring done

is it related to this:
   - name: cmake
      if: ${{ runner.os == 'macOS' }}
      run: |
        OPENSSL_ROOT_DIR=/usr/local/opt/openssl cmake -B build && cmake --build build -j

Should be fixed now. mingw fixing looks a bit harder, so I disabled the workflow until its ready. Can you rebase/merge main?

thanks,
perhaps native Windows is a bit more realistic platform that Mingw ?


Unable to add MobileRTCScreenShare.framework

hi @evilrat
I want to add MobileRTCScreenShare.framework in to the iOS Plugin but I faced the following build error:
Undefined symbols for architecture arm64:
  "_kVTCompressionPropertyKey_FieldCount", referenced from:
      l038 in MobileRTCScreenShare
  "_kVTCompressionPropertyKey_MaxFrameDelayCount", referenced from:
      l038 in MobileRTCScreenShare
  "_VTCompressionSessionEncodeFrame", referenced from:
      l034 in MobileRTCScreenShare
      l040 in MobileRTCScreenShare
  "_VTCompressionSessionCreate", referenced from:
      l032 in MobileRTCScreenShare
      l038 in MobileRTCScreenShare
  "_kVTCompressionPropertyKey_RealTime", referenced from:
      l032 in MobileRTCScreenShare
      l038 in MobileRTCScreenShare
  "_VTCompressionSessionCompleteFrames", referenced from:
      l030 in MobileRTCScreenShare
      l037 in MobileRTCScreenShare
  "_kVTCompressionPropertyKey_ProfileLevel", referenced from:
      l032 in MobileRTCScreenShare
  "_kVTCompressionPropertyKey_AllowFrameReordering", referenced from:
      l032 in MobileRTCScreenShare
      l038 in MobileRTCScreenShare
  "_kVTCompressionPropertyKey_DataRateLimits", referenced from:
      l032 in MobileRTCScreenShare
  "_kVTCompressionPropertyKey_AverageBitRate", referenced from:
      l032 in MobileRTCScreenShare
  "_VTSessionSetProperty", referenced from:
      l032 in MobileRTCScreenShare
      l038 in MobileRTCScreenShare
  "_kVTProfileLevel_H264_Baseline_AutoLevel", referenced from:
      l032 in MobileRTCScreenShare
  "_kVTCompressionPropertyKey_ExpectedFrameRate", referenced from:
      l032 in MobileRTCScreenShare
  "_kVTCompressionPropertyKey_Quality", referenced from:
      l038 in MobileRTCScreenShare
  "_VTCompressionSessionInvalidate", referenced from:
      l030 in MobileRTCScreenShare
      l037 in MobileRTCScreenShare
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

here's my flutter_zoom_sdk.podspec:
#
# To learn more about a Podspec see http://guides.cocoapods.org/syntax/podspec.html.
# Run `pod lib lint flutter_zoom_sdk.podspec` to validate before publishing.
#
Pod::Spec.new do |s|
  s.name             = 'flutter_zoom_sdk'
  s.version          = '0.0.6'
  s.summary          = 'Zoom SDK implementation by EvilRATT'
  s.description      = <<-DESC
Zoom SDK implementation by EvilRATT
                       DESC
  s.homepage         = 'http://evilrattechnologies.com'
  s.license          = { :file => '../LICENSE' }
  s.author           = { 'EvilRAT Technologies' =><EMAIL_ADDRESS>}
  s.source           = { :path => '.' }
  s.source_files = 'Classes/**/*'
  s.public_header_files = 'Classes/**/*.h'
  s.dependency 'Flutter'
  s.platform = :ios, '8.0'

  # Flutter.framework does not contain a i386 slice.
  s.xcconfig = { 'OTHER_LDFLAGS' => '-lc++ -framework MobileRTC -framework MobileRTCScreenShare', 'DEFINES_MODULE' => 'YES', 'ENABLE_BITCODE' => 'NO', 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64'}
  s.swift_version = '5.0'

  s.preserve_paths = 'MobileRTC.framework', 'MobileRTCScreenShare.framework', 'MobileRTCResources.bundle'
  s.vendored_frameworks = 'MobileRTC.framework', 'MobileRTCScreenShare.framework', 'CoreGraphics.framework', 'CoreMedia.framework', 'CoreVideo.framework', 'ReplayKit.framework', 'VideoToolbox.framework'
  s.resource = 'MobileRTCResources.bundle'
end

I appreciate if you help me.
thanks

@evilrat

Hi @evilrat,
Do you have any idea how can I add MobileRTCScreenShare to the iOS project? I got the same error when I tried to add the framework to the flutter plugin.

Checking on it....soon post the solution here

@evilrat

new sdk is release try on that
flutter_zoom_sdk: ^1.0.0


Masakari Controller conf update

Due to issue #15 Source update,
Masakari controller fail to start without following configs.

This patch corresponds to the pull request #15 of masakari project, which fixes the issue #14 of it.
The code looks good to me.


Conditional workflow - Cancel remaining jobs before flow is finalized.

For conditional workflows, if conditionOnJobStatus is ONE_SUCCESS or ONE_FAILED, some jobs might still be running or not started yet when the end nodes have finished. In this case, we need to cancel all the remaining jobs before finalizing the flow.

Pull Request Test Coverage Report for Build 3883

17 of 17 (100.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.1%) to 35.865%

Files with Coverage Reduction
New Missed Lines
%

azkaban-exec-server/src/main/java/azkaban/execapp/event/JobCallbackRequestMaker.java
1
78.13%

azkaban-common/src/main/java/azkaban/jobExecutor/AbstractProcessJob.java
3
63.1%

Totals

Change from base Build 3882:
0.1%

Covered Lines:
10312

Relevant Lines:
28752

💛  - Coveralls

Thanks. One thing to clarify, the end node doesn't have to define condition on job status. As long as there is node in the flow which has defined one_success or one_failed condition, this PR could apply.

This is part of the conditional workflow design - #1826


links without anchor text

okay i figured out what is causing the large number of seo errors about no anchor text
its the link to the github repo in the package details
i think if we drop the https:// from the anchor text (but leave the href as is)
or it may be even better to make the anchor text <package name> repository
then this will be fixed

this causes 5,038 errors
because this is at the bottom of every api docs reference page

@kimberleyamackenzie or @sean1588 either of you up for fixing this?

heres the line i think we need to edit
https://github.com/pulumi/pulumi/blob/master/pkg/codegen/docs/templates/package_details.tmpl#L5

changes are now live as of: https://github.com/pulumi/docs/pull/8480


just --build=x86_64-pc-linux-musl

It can handle --host and --target automatically

Tested and works on my machine. Merged.


Document cdk-drag-handle class

Please describe the feature you would like to request.
The fact that cdkDragHandle adds a cdk-drag-handle class is currently undocumented.

Would it be ok to take this issue? Seems do-able

Yeah, from my side go ahead if you want and thanks for taking care of it. :-) There already is a Styling section in the docs, I think it should just be added there.


.mentions needs to recognize mentions of people not in guild

If you type a correct <@12346789> and that is a correct user id, then .mentions needs to recognize that even if they are not in the guild.

While I may be wrong about this I'm pretty sure this is actually the mentions array included with the message by discord. Which would be the people around who were actually mentioned / notified by the message. If you dislike this I'd... suggest either simply using regex to search the message something like /<@(?:!)(\d+)>/ (may not be right)... or maybe try talking to the discord devs... though I feel they may shoot down the idea.

I'm saying that Discordie .mentions can not recognize an ID from someone who has talked in chat and left.  Discord allows Discordie to pukk any IUser.  Even if that person has never talked in a guild the bot is inside.  Somehow, Discordie's implementation only allows the ones that can be seen in guilds.


[Event Request] Table 39 "Purchase Line" - OnCalcVATAmountLinesOnBeforeProcessPurchLine

Hi, would it be possible to get an OnCalcVATAmountLinesOnBeforeProcessPurchLine event in table 39 (Purchase Line), like this:
    procedure CalcVATAmountLines(QtyType: Option General,Invoicing,Shipping; var PurchHeader: Record "Purchase Header"; var PurchLine: Record "Purchase Line"; var VATAmountLine: Record "VAT Amount Line")
    var
        TotalVATAmount: Decimal;
        QtyToHandle: Decimal;
        AmtToHandle: Decimal;
        RoundingLineInserted: Boolean;
    begin
        if IsCalcVATAmountLinesHandled(PurchHeader, PurchLine, VATAmountLine, QtyType) then
            exit;

        Currency.Initialize(PurchHeader."Currency Code");

        VATAmountLine.DeleteAll();

        with PurchLine do begin
            SetRange("Document Type", PurchHeader."Document Type");
            SetRange("Document No.", PurchHeader."No.");
            OnCalcVATAmountLinesOnAfterSetFilters(PurchLine, PurchHeader);
            if FindSet then
                repeat
                    if not ZeroAmountLine(QtyType) then begin
                         OnCalcVATAmountLinesOnBeforeProcessPurchLine(PurchLine, PurchHeader, VATAmountLine, QtyType); // New Event
                        if (Type = Type::"G/L Account") and not "Prepayment Line" then
                            RoundingLineInserted := (("No." = GetVPGInvRoundAcc(PurchHeader)) and "System-Created Entry") or RoundingLineInserted;
                        if "VAT Calculation Type" in
                           ["VAT Calculation Type"::"Reverse Charge VAT", "VAT Calculation Type"::"Sales Tax"]
                        then
                            "VAT %" := 0;
                        if not VATAmountLine.Get(
                             "VAT Identifier", "VAT Calculation Type", "Tax Group Code", "Use Tax", "Line Amount" >= 0)
                        then
                            VATAmountLine.InsertNewLine(
                              "VAT Identifier", "VAT Calculation Type", "Tax Group Code", "Use Tax", "VAT %", "Line Amount" >= 0, false);

                        case QtyType of
                            QtyType::General:
                                begin
                                    VATAmountLine.Quantity += "Quantity (Base)";
                                    VATAmountLine."VAT Base (Lowered)" += "VAT Base Amount";
                                    OnCalcVATAmountLinesOnBeforeVATAmountLineSumLine(Rec, VATAmountLine, QtyType);
                                    VATAmountLine.SumLine(
                                      "Line Amount", "Inv. Discount Amount", "VAT Difference", "Allow Invoice Disc.", "Prepayment Line");
                                end;
                            QtyType::Invoicing:
                                begin
                                    case true of
                                        ("Document Type" in ["Document Type"::Order, "Document Type"::Invoice]) and
                                      (not PurchHeader.Receive) and PurchHeader.Invoice and (not "Prepayment Line"):
                                            if "Receipt No." = '' then begin
                                                QtyToHandle := GetAbsMin("Qty. to Invoice", "Qty. Rcd. Not Invoiced");
                                                VATAmountLine.Quantity += GetAbsMin("Qty. to Invoice (Base)", "Qty. Rcd. Not Invoiced (Base)");
                                            end else begin
                                                QtyToHandle := "Qty. to Invoice";
                                                VATAmountLine.Quantity += "Qty. to Invoice (Base)";
                                            end;
                                        IsCreditDocType and (not PurchHeader.Ship) and PurchHeader.Invoice:
                                            if "Return Shipment No." = '' then begin
                                                QtyToHandle := GetAbsMin("Qty. to Invoice", "Return Qty. Shipped Not Invd.");
                                                VATAmountLine.Quantity += GetAbsMin("Qty. to Invoice (Base)", "Ret. Qty. Shpd Not Invd.(Base)");
                                            end else begin
                                                QtyToHandle := "Qty. to Invoice";
                                                VATAmountLine.Quantity += "Qty. to Invoice (Base)";
                                            end;
                                        else begin
                                                QtyToHandle := "Qty. to Invoice";
                                                VATAmountLine.Quantity += "Qty. to Invoice (Base)";
                                            end;
                                    end;
                                    OnCalcVATAmountLinesOnQtyTypeInvoicingOnBeforeCalcAmtToHandle(PurchLine, PurchHeader, QtyToHandle, VATAmountLine);
                                    AmtToHandle := GetLineAmountToHandleInclPrepmt(QtyToHandle);
                                    VATAmountLine."VAT Base (Lowered)" += "VAT Base Amount";
                                    OnCalcVATAmountLinesOnBeforeVATAmountLineSumLine(Rec, VATAmountLine, QtyType);
                                    if PurchHeader."Invoice Discount Calculation" <> PurchHeader."Invoice Discount Calculation"::Amount then
                                        VATAmountLine.SumLine(
                                          AmtToHandle, Round("Inv. Discount Amount" * QtyToHandle / Quantity, Currency."Amount Rounding Precision"),
                                          "VAT Difference", "Allow Invoice Disc.", "Prepayment Line")
                                    else
                                        VATAmountLine.SumLine(
                                          AmtToHandle, "Inv. Disc. Amount to Invoice", "VAT Difference", "Allow Invoice Disc.", "Prepayment Line");
                                end;
                            QtyType::Shipping:
                                begin
                                    if "Document Type" in
                                       ["Document Type"::"Return Order", "Document Type"::"Credit Memo"]
                                    then begin
                                        QtyToHandle := "Return Qty. to Ship";
                                        VATAmountLine.Quantity += "Return Qty. to Ship (Base)";
                                    end else begin
                                        QtyToHandle := "Qty. to Receive";
                                        VATAmountLine.Quantity += "Qty. to Receive (Base)";
                                    end;
                                    AmtToHandle := GetLineAmountToHandleInclPrepmt(QtyToHandle);
                                    OnCalcVATAmountLinesOnBeforeVATAmountLineSumLine(Rec, VATAmountLine, QtyType);
                                    VATAmountLine.SumLine(
                                      AmtToHandle, Round("Inv. Discount Amount" * QtyToHandle / Quantity, Currency."Amount Rounding Precision"),
                                      "VAT Difference", "Allow Invoice Disc.", "Prepayment Line");
                                end;
                        end;
                        TotalVATAmount += "Amount Including VAT" - Amount;
                        OnCalcVATAmountLinesOnAfterCalcLineTotals(VATAmountLine, PurchHeader, PurchLine, Currency, QtyType, TotalVATAmount);
                    end;
                until Next() = 0;
        end;

        VATAmountLine.UpdateLines(
          TotalVATAmount, Currency, PurchHeader."Currency Factor", PurchHeader."Prices Including VAT",
          PurchHeader."VAT Base Discount %", PurchHeader."Tax Area Code", PurchHeader."Tax Liable", PurchHeader."Posting Date");

        if RoundingLineInserted and (TotalVATAmount <> 0) then
            if GetVATAmountLineOfMaxAmt(VATAmountLine, PurchLine) then begin
                VATAmountLine."VAT Amount" += TotalVATAmount;
                VATAmountLine."Amount Including VAT" += TotalVATAmount;
                VATAmountLine."Calculated VAT Amount" += TotalVATAmount;
                VATAmountLine.Modify();
            end;

        OnAfterCalcVATAmountLines(PurchHeader, PurchLine, VATAmountLine, QtyType);
    end;

    [IntegrationEvent(false, false)]
    local procedure OnCalcVATAmountLinesOnBeforeProcessPurchLine(var PurchaseLine: Record "Purchase Line"; var PurchHeader: Record "Purchase Header"; var VATAmountLine: Record "VAT Amount Line"; QtyType: Option General,Invoicing,Shipping)
    begin
    end;

Thanks!

This has been implemented already several updates ago, closing the issue. The tag 'ships-in-future-update' is for housekeeping.


Update docs for entry-context

I think this current directory has a ambiguity. Does the current directory refer to the root directory of the project? Or is it the directory where webpack.config.js is located?
After I tested it, I found neither of them, the default should be the directory of the script that starts webpack. For example, I ran the script webpack --config relativebase in a non-project root directory. Then, the value of the context at this time is the directory where the script is located.
In order to better illustrate my ideas, I wrote a demo code, but I don’t know how to give the sample code, so I created a warehouse to store the sample code. https://github.com/spicylemonhaha/webpack-demo

If you check the source code of webpack, that context defaults to process.cwd(),

So maybe just update the the current directory to the current working directory?

First of all, thank you for replying to my pr. After reading your reply and reviewing the relevant code, I think the current working directory is already very appropriate, but I think it may be easier for readers to understand it if it is changed to the current working directory of the Node.js process. If you still think the former is better, then I will change to the former. Thank you again for replying to my pr, you are the first person to reply to my pr.


Vehicle specific constraint that can start with a given value

I need to add constraint that is vehicle specific (similar to transit constraint), but is accumulates values similar to Capacity constraint.
For example, I am trying to add constraint on Draft (for vessel).

Each Vehicle starts with specific Draft
As cargo loaded on vehicle draft increases, but at different rates for each vehicle
Vehicle can only go to a port that has deeper water than the Draft the vehicle has after pickup.

What Dimensions is the best approach to tackle this problem?
Neither VehicleCapacity Dimension or VehicleTransits look right. I tried to make it work with both.
When I try VehicleCapacity, I don't see make changes in draft specific to a vehicle, and I don't see how in start a vehicle with specific draft to match the ports.
With VehicleTransit, since I can create callbacks specific to the vehicle, I can make changes to draft specific to the vehicle, but I don't see how to starting specific position. Also accumulation does work exactly like I want, I get a feeling that VehicleTransit dimension is not an ideal fit for this.
I found DependentDimensionWithVehicleCapacity, but I am not sure if that's what I need.
Let me know if I need to provide more information.
Any help appreciated.

For a given vehicle, what not have a new node, distance 0 from the depot,
with one 1 possible vehicle, that will set the initial value of the
dimension ?
And make sure that no other routing outgoing from the depot can be visited
by that vehicle .
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le jeu. 19 déc. 2019 à 02:52, Akavall<EMAIL_ADDRESS>a écrit :

I need to add constraint that is vehicle specific (similar to transit
constraint), but is accumulates values similar to Capacity constraint.
For example, I am trying to add constraint on Draft (for vessel).

Each Vehicle starts with specific Draft
As cargo loaded on vehicle draft increases, but at different rates
for each vehicle
Vehicle can only go to a port that has deeper water than the Draft
the vehicle has after pickup.

What Dimensions is the best approach to tackle this problem?
Neither VehicleCapacity Dimension or VehicleTransits look right. I tried
to make it work with both.
When I try VehicleCapacity, I don't see make changes in draft specific to
a vehicle, and I don't see how in start a vehicle with specific draft to
match the ports.
With VehicleTransit, since I can create callbacks specific to the vehicle,
I can make changes to draft specific to the vehicle, but I don't see how to
starting specific position. Also accumulation does work exactly like I
want, I get a feeling that VehicleTransit dimension is not an ideal fit for
this.
I found DependentDimensionWithVehicleCapacity, but I am not sure if
that's what I need.
Let me know if I need to provide more information.
Any help appreciated.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1791?email_source=notifications&email_token=ACUPL3IZUIFIWEPQCH7BLEDQZLHVHA5CNFSM4J4XSWA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IBQENMA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUPL3LF6RNYJJKVCQ7ZYXDQZLHVHANCNFSM4J4XSWAQ
.


Blazor - data-binding - event fix

"After each keystroke" is an oninput event

fixed the text
fixed the sampleˇ

cc @guardrex

Internal previews

📄 File
🔗 Preview link

aspnetcore/blazor/components/data-binding.md
ASP.NET Core Blazor data binding

There was a different fix that would just have the text update to 'loss of focus' language, but now that I think about it the example might show both. I'll try a commit to see how that looks.

After looking this over, I think the original intent was a loss of focus. Anyway, it's nice to show it both ways.

I'll wait to merge until you have a chance to respond to my updates.


HELP!!! Increase and decrease window's width

Need help when increase or decrease window's width:
First time increase: press <C-w>>
Second time increase: press >
Third time increase: press >
Exit increase: <Esc>
I'm want set the mapping like that but I have no idea for done that.
Can someone help me.

I tried mapping keys for increase and decrease win height, but it either crash or not working :(

-- Resize with arrows
K.n('<', ':vertical resize -2<CR>')
K.n('>', ':vertical resize +2<CR>')

See the source code for the K function.


python3Packages.aioharmony: 0.2.6 -> 0.2.7

Motivation for this change
Update to latest upstream release 2.0.7
Change log: https://github.com/ehendrix23/aioharmony/releases/tag/v0.2.7
Also, ran nixpkgs-fmt and align layout with other Python modules.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 112079 run on x86_64-linux 1

3 packages built:

python37Packages.aioharmony
python38Packages.aioharmony
python39Packages.aioharmony

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112079 run on x86_64-linux 1

3 packages built:

python37Packages.aioharmony
python38Packages.aioharmony
python39Packages.aioharmony

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112079 run on x86_64-darwin 1

3 packages built:

python37Packages.aioharmony
python38Packages.aioharmony
python39Packages.aioharmony


Go modules

It's time. @mheon @baude @TomSweeneyRedHat @rhatdan PTAL

Fingers crossed for the tests, LGTM.

+100k -50k
Certainly starting the week off on a high note.
Regardless, this LGTM, but I'll let @baude have a look before we merge.

/lgtm


Katacoda use outdated version 0.16.11

Describe the bug/feature
A clear and concise description of what the bug/feature request is.
To Reproduce
Steps to reproduce the behavior:

Go to 'https://www.katacoda.com/ademaria/scenarios/kapitan-intro'
Go until step 3
run kapitan compile
See error

Expected behavior
Compiled prod-sea (0.43s)
Compiled dev-sea (0.43s)

Screenshots
** If it's a bug (please complete the following information):**

python --version: 2.7.15rc1 (3.6.5)
pip3 --version: 9.0.1
Are you using pyenv or virtualenv? nope

Additional context
it's on katacoda, so I had to upgrade the version using pip3 install --user --upgrade kapitan

cc @ademariag  as the one who set up Katacoda (?).

maybe I can help some how?

I have asked the katacoda team to update kapitan to the latest version

I have asked multiple time the Katacoda team but I have not received an answer.
They've recently been acquired so I think I will ask again soon.
Meanwhile I am considering moving to use https://ssh.cloud.google.com/cloudshell/editor which offers similar features, and would allow people to test against their own GCP cloud environment


feat(baremetal): grub http boot initrd and kernel

What this PR does / why we need it:

Does this PR need to be backport to the previous release branch?:

3.9
/area baremetal
/cc @swordqiu
/hold

/hold cancel


How to enable MPT to remember data (or chat based requirement)?

I am interested in exploring techniques to enhance the model's ability to remember and maintain context during text generation. I would like to generate responses that exhibit a more conversational or memory-driven nature, allowing the model to recall and reference previously mentioned information within the generated text.
If any of you have experience or knowledge in this area, I would greatly appreciate your insights.
What changes can I do to the following code to have a memory-based setup -
from typing import Any, Dict, Tuple
import warnings

import torch
from transformers import AutoModelForCausalLM, AutoTokenizer
from transformers import (
    StoppingCriteria,
    StoppingCriteriaList,
    TextIteratorStreamer,
)

INSTRUCTION_KEY = "### Instruction:"
RESPONSE_KEY = "### Response:"
END_KEY = "### End"
INTRO_BLURB = "Below is an instruction that describes a task. Write a response that appropriately completes the request."
PROMPT_FOR_GENERATION_FORMAT = """{intro}
{instruction_key}
{instruction}
{response_key}
""".format(
    intro=INTRO_BLURB,
    instruction_key=INSTRUCTION_KEY,
    instruction="{instruction}",
    response_key=RESPONSE_KEY,
)

class InstructionTextGenerationPipeline:
    def __init__(
        self,
        model_name,
        torch_dtype=torch.bfloat16,
        trust_remote_code=True,
        use_auth_token=None,
    ) -> None:
        self.model = AutoModelForCausalLM.from_pretrained(
            model_name,
            torch_dtype=torch_dtype,
            trust_remote_code=trust_remote_code,
            use_auth_token=use_auth_token,
        )

        tokenizer = AutoTokenizer.from_pretrained(
            model_name,
            trust_remote_code=trust_remote_code,
            use_auth_token=use_auth_token,
        )
        if tokenizer.pad_token_id is None:
            warnings.warn(
                "pad_token_id is not set for the tokenizer. Using eos_token_id as pad_token_id."
            )
            tokenizer.pad_token = tokenizer.eos_token
        tokenizer.padding_side = "left"
        self.tokenizer = tokenizer

        device = torch.device("cuda" if torch.cuda.is_available() else "cpu")
        self.model.eval()
        self.model.to(device=device, dtype=torch_dtype)

        self.generate_kwargs = {
            "temperature": 0.1,
            "top_p": 0.92,
            "top_k": 0,
            "max_new_tokens": 1024,
            "use_cache": True,
            "do_sample": True,
            "eos_token_id": self.tokenizer.eos_token_id,
            "pad_token_id": self.tokenizer.pad_token_id,
            "repetition_penalty": 1.1,  # 1.0 means no penalty, > 1.0 means penalty, 1.2 from CTRL paper
        }

    def format_instruction(self, instruction):
        return PROMPT_FOR_GENERATION_FORMAT.format(instruction=instruction)

    def __call__(
        self, instruction: str, **generate_kwargs: Dict[str, Any]
    ) -> Tuple[str, str, float]:
        s = PROMPT_FOR_GENERATION_FORMAT.format(instruction=instruction)
        input_ids = self.tokenizer(s, return_tensors="pt").input_ids
        input_ids = input_ids.to(self.model.device)
        gkw = {**self.generate_kwargs, **generate_kwargs}
        with torch.no_grad():
            output_ids = self.model.generate(input_ids, **gkw)
        # Slice the output_ids tensor to get only new tokens
        new_tokens = output_ids[0, len(input_ids[0]) :]
        output_text = self.tokenizer.decode(new_tokens, skip_special_tokens=True)
        return output_text

These models do not have their own memory. That's not how they work.
Instead, the "driver" of the model needs to pass in the previous context as additional pre-prompt material when inferring the next step.
Sometimes, it's good enough to only pass in the user prompts, you don't need to pass in the model responses again.
In other cases, summarizing the previous discussion and providing that summary instead of the full text is also helpful.
Finally, with ALiBi, you may be able to get away with a lot more context without "running out." Experiment and find out!


fix: Missing property on Select component

This PR fixes the https://github.com/aerogear/uniforms-patternfly/issues/55 issue by adding a missing property on the Select component and updating some dependecies using the https://github.com/aerogear/uniforms-patternfly/pull/46 as reference.

Hi @wtrocki @kingsleyzissou , could one of you please review this PR?
If something is missing or wrong, let me know. :grin:

Hi @wtrocki @kingsleyzissou , could one of you please review this PR?
If something is missing or wrong, let me know. :grin:

@ljmotta I have merged your PR but then I see that all tests on master started failing:
https://app.circleci.com/pipelines/github/aerogear/uniforms-patternfly/209/workflows/c3a826d7-3c02-43a1-8783-05d01b21f3d4/jobs/204

@ljmotta I have merged your PR but then I see that all tests on master started failing:
https://app.circleci.com/pipelines/github/aerogear/uniforms-patternfly/209/workflows/c3a826d7-3c02-43a1-8783-05d01b21f3d4/jobs/204

@wtrocki As far I could see on the logs, the @patternfly/react-styles is missing or it was downloaded the incorrect version, and it's a direct dependency of @patternfly/react-core. My guess is because it's missing the yarn.lock file on the repo.
I'm not used to the circle-ci, should I open a new PR with just the yarn.lock? or it has an another way to use it?

@wtrocki As far I could see on the logs, the @patternfly/react-styles is missing or it was downloaded the incorrect version, and it's a direct dependency of @patternfly/react-core. My guess is because it's missing the yarn.lock file on the repo.
I'm not used to the circle-ci, should I open a new PR with just the yarn.lock? or it has an another way to use it?

@ljmotta Looking at this now

@ljmotta Looking at this now


Hotkey to focus the source text box

Hi,
I really want to integrate Translate into my keyboard-centric flow, and currently when opening the view, in order to start typing a word to translate I need to press Tab 4 times.
Is it possible to open the view with the 'Type here' box already focused and ready to go?
Thanks in advance!

Thank you, looking forward!

Closing this issue as the fix is shipped with update 1.4.6, sorry for the wait & thanks for the FR!

Thank you!


Support for FLV container in convert-video?

Hi Don,
I have some video files I downloaded a while ago using Get iPlayer Automator.
They use  .flv container for H264 video and AAC audio.
transcode-video recognises them and proceeds 😄
convert-video complains about an unsupported container type 😞
I was hoping to do a quick convert given the contents of the file are "ready to go".
ffmpeg should support it.
Any thoughts?
$ transcode-video --scan video.mp4.flv
+ title 1:
  + stream: video.mp4.flv
  + duration: 00:58:32
  + size: 960x540, pixel aspect: 1/1, display aspect: 1.78, 25.000 fps
  + chapters:
    + 1: cells 0->0, 0 blocks, duration 00:58:32
  + audio tracks:
    + 1, Unknown (AAC) (2.0 ch) (iso639-2: und)
  + subtitle tracks:

That's fine. I ended up using ffmpeg similar to how you described. If I need to use it again I'll set up an alias. Cheers!


implement price converter endpoint support

Implemented support for the Price converter endpoint: https://api.coinpaprika.com/#tag/Tools/paths/~1price-converter/get

@oskarwojciski added


Make view engine configurable

Or should we just remove templates and server a static file?

As of v.1.2.x we have separate api and web generators. We still have the app generator which is a combo of both api and web.
I like having a template engine in the app and web generators to demonstrate visionary. So I think it should templates should stay.
However, I'm leaning towards not making the view engine configurable. It's such an easy thing to change once you create your app. And when I think about which template engines we'd include as options, answering feels more opinionated than just keeping it simple with one.


Cardigan updates

Using Vite builder to run Cardigan.

Hopefully speeds up local builds a bit (especially on subsequent runs)
Makes the Canvas view the default (instead of Docs) and removes the tabs
Removes stale documentation (after discussion, feel like this isn't the right place for very much non-visual documentation)
Added a ReadmeDecorator so that we can add readmes alongside canvas stories if we see the need
Not sure the separation between .tsx and .mdx are still useful/necessary after these changes, but we are where we are and to revert to .tsx only would be a lot of grunt work for (I don't think) any tangible gain at this point.
If we want an e.g. 'Overview' story before a group, this can be added as a <Story name="Overview"> in the .mdx where any markdown (or imported readmes) are valid.

TODO (not necessarily this PR)

Fix ArchiveTree story
Re-add License story (which isn't rendering currently)

Closing this PR as we decided to treat it in multiple PR instead.
(Deployed)
https://github.com/wellcomecollection/wellcomecollection.org/pull/9155/
Left to do:
https://github.com/wellcomecollection/wellcomecollection.org/issues/9156
https://github.com/wellcomecollection/wellcomecollection.org/issues/9157
https://github.com/wellcomecollection/wellcomecollection.org/issues/9158
https://github.com/wellcomecollection/wellcomecollection.org/issues/9159


[PE-D][Tester A] Event window does not check for duplicate meetings

I managed to input 2 of the same meetings which i assume should not happen

Labels: severity.High type.FunctionalityBug
original: Greg-Tan/ped#9

Duplicate of #107


[Reveal] Positioning properties are ignored

The data-v-offset, data-h-offset, and data-btm-offset-pct properties for Reveal modal are ignored in 6.2.0. See this pen demonstrating the Reveal modal can be positioned using data-v-offset in Foundation 6.0.1. While on v6.2.0 this pen shows the property is ignored.
It looks like @gakimball removed support for vOffset, and the other properties in b99cf40.
@kball in 05313e1 added positioning logic in JS. So, it seems the intent is to position in javascript, not CSS.
Was removing the vOffset, btmOffsetPct, hOffset properties intentional, if so the properties listed in the documentation will need to be removed.

@kball It looks like the positioning refactor in 6.2 might make a few of Reveal's plugin options obsolete?

Seems to be fixed already: http://codepen.io/anon/pen/ZOAwxm.


Fixing broken count JS and icons

Hey thanks for accepting my previous PR. It also included some untested ES6 code from Andreas which I fixed yesterday. At the same time, I included the icon registration required for latest discourse compatibility. Both is tested now. Cheers, Arwed

Thank you! Merged.


mpt: remove unrtraceable roots

Close #2095 .
It is ready to review but needs more opimization and testing.
Current implementation adds about 40% overhead on n3 dump restore.

And the last, but actually the most interesting set of results. Here the node is configured to drop old blocks (with tracing depth of 10000) and at the same time only keep the latest state, but the code is modified to actually keep 3 states --- two previous synchronization points (with 10000 interval) and the current one. So it's the lightest configuration possible which is actually what we want for NeoFS chains (while still having enough data to bootstrap any other new node).
LevelDB, mainnet

real    1m39,181s      real    1m39,301s      real    1m39,245s
user    4m11,802s      user    4m10,561s      user    4m10,960s
sys     0m22,075s      sys     0m20,931s      sys     0m21,931s
893M    chains/mainnet 891M    chains/mainnet 880M    chains/mainnet

BoltDB, mainnet

real    1m17,969s           real    1m19,231s           real    1m17,796s
user    2m40,949s           user    2m41,010s           user    2m40,036s
sys     0m31,324s           sys     0m32,706s           sys     0m31,484s
1,9G    chains/mainnet.bolt 1,9G    chains/mainnet.bolt 1,9G    chains/mainnet.bolt

LevelDB, testnet

real    1m53,877s      real    1m54,934s      real    1m52,257s
user    4m34,303s      user    4m36,557s      user    4m27,691s
sys     0m25,678s      sys     0m26,297s      sys     0m25,435s
1,2G    chains/testnet 1,1G    chains/testnet 1,1G    chains/testnet

BoltDB, testnet

real    1m13,096s           real    1m15,921s           real    1m16,232s
user    2m33,576s           user    2m36,489s           user    2m35,309s
sys     0m28,540s           sys     0m29,553s           sys     0m31,852s
2,8G    chains/testnet.bolt 2,4G    chains/testnet.bolt 2,4G    chains/testnet.bolt

We have several cases here:

full archive node in any config (stores everything)
public networks with KeepOnlyLatestState (only needs to store the latest state)
public networks with RemoveUntraceableBlocks (stores a MaxTraceableBlocks number of MPTs)
state-exchange networks with RemoveUntraceableBlocks (stores MaxTraceableBlocks and/or 2×StateSyncInterval MPTs)
state-exchange networks with KeepOnlyLatestState (technically only needs three MPTs, the latest one and 2 sync points)

In my tests the last two are not much different from disk usage perspective, so we can probably always store a bigger number of MPTs. The first two work perfectly the way they are now. RemoveUntraceableBlocks cases are better covered by GC (#2159), I think, keeping a set of MPTs with #2137 can be very expensive. So my proposal would be:

keep "store everything" logic with no counting
keep reference counting logic for public networks as is
add GC for RemoveUntraceableBlocks case that will works instead of reference counting

@fyrchik, @AnnaShaleva? @fyrchik, you can also test "three points" case additionally, maybe it'd be somewhat different on your machine, but for me it's easier to store 10000 MPTs with #2159 than exactly 3 with #2137.

@roman-khimov I will rebase and test this. I think we can have GC implementation along with this one to make it easier to test (though I am not sure it is faster).

I have benched the following configurations (testnet dump with ~350k blocks; everything was benched 3 times, the results were the same):

RemoveUntraceableBlocks: true with MaxTraceableBlocks: 10000:

# master
LevelDB
________________________________________________________
Executed in  113,63 secs    fish           external
   usr time  193,48 secs    0,00 millis  193,48 secs
   sys time   19,69 secs    1,77 millis   19,68 secs

Bolt
________________________________________________________
Executed in  127,90 secs    fish           external
   usr time  268,54 secs    0,00 millis  268,54 secs
   sys time   20,48 secs    1,75 millis   20,48 secs

# reference counting
LevelDB
________________________________________________________
Executed in  101,88 secs    fish           external
   usr time  226,46 secs    0,00 millis  226,46 secs
   sys time   20,55 secs    1,31 millis   20,55 secs

Bolt
________________________________________________________
Executed in   72,38 secs    fish           external
   usr time  157,19 secs  819,00 micros  157,19 secs
   sys time   10,74 secs  455,00 micros   10,74 secs

# GC
LevelDB
________________________________________________________
Executed in  106,85 secs    fish           external
   usr time  202,80 secs  809,00 micros  202,80 secs
   sys time   20,69 secs  470,00 micros   20,69 secs

Bolt
________________________________________________________
Executed in  124,46 secs    fish           external
   usr time  271,11 secs    1,25 millis  271,11 secs
   sys time   24,49 secs    0,00 millis   24,49 secs

# GC, but wait for the last gc cycle to finish
LevelDB
_____
Executed in  114,00 secs    fish           external
   usr time  214,89 secs  967,00 micros  214,89 secs
   sys time   23,79 secs  510,00 micros   23,79 secs

Bolt (last GC cycle took 7 minutes and varied greatly between iterations)
________________________________________________________
Executed in  447,90 secs    fish           external
   usr time  506,86 secs  974,00 micros  506,86 secs
   sys time   71,97 secs  508,00 micros   71,97 secs

Reference counting with GenerationSpan set to 10k (i.e. we store only some of the last sync points if StateSyncInterval=10k) compared with master + KeepOnlyLatestState

# master
LevelDB
________________________________________________________
Executed in   96,59 secs    fish           external
   usr time  204,93 secs  731,00 micros  204,93 secs
   sys time   18,53 secs  476,00 micros   18,53 secs

Bolt
________________________________________________________
Executed in   68,00 secs    fish           external
   usr time  141,78 secs    0,00 millis  141,78 secs
   sys time    9,86 secs    1,68 millis    9,86 secs

# Multiple sync points
LevelDB
________________________________________________________
Executed in  101,33 secs    fish           external
   usr time  219,40 secs    1,10 millis  219,40 secs
   sys time   21,29 secs    0,55 millis   21,29 secs

Bolt
________________________________________________________
Executed in   71,01 secs    fish           external
   usr time  152,08 secs  835,00 micros  152,08 secs
   sys time   10,60 secs  465,00 micros   10,60 secs

There is a problem with GC which we currently don't address (and IMO this is the main reason for it to be slow): generation update is done for all items, but many of them (hypothetically) are long lived. So we traverse these nodes on each GC cycle. Also this traversal takes a lot more time than actual deletion with Seek.
I am thinking about some clever pruning (if an item is old and reachable, all of its children are also reachable). The need to save generation before the GC cycle (because it can take a lot and we must consider all cases) is the biggest issue so far.

Old and slow.


[SPARK-22141][Followup][SQL] Add comments for the order of batches

What changes were proposed in this pull request?
Add comments for specifying the position of  batch "Check Cartesian Products", as @rxin suggested in https://github.com/apache/spark/pull/19362 .
How was this patch tested?
Unit test

Test build #82274 has started for PR 19379 at commit efd73ea.

Test build #82274 has finished for PR 19379 at commit efd73ea.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82274/
Test FAILed.

retest this please.

Test build #82276 has finished for PR 19379 at commit efd73ea.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82276/
Test PASSed.

Thanks! Merged to master


As a Quizmaster I want mark a question correct for the current quizzer so that I can track score

I did a lot of refactoring in this one.


Provide controller access to a vertical position derivative

Requires https://github.com/PX4/ecl/pull/265 and will be part of the solution to  https://github.com/PX4/Firmware/issues/6604
This PR provides controllers with access to a vertical position derivative that is free from steady state offsets that are generated when the EKF is subject to uncorrected  IMU vertical accel and GPS velocity offsets.
This vertical position derivative can be used when the controller is operating in a vertical velocity tracking mode without position feedback.
Modifications to the position controller is required to take advantage of this change.

@MaEtUgR and @Stifael for info

@priseborough I think that makes from a software architectural point of view more sense. One way to benefit from it is that the position controller uses the derivative anytime altitude_hold is NOT engaged.

@priseborough I will wip based on this pr where the controller switches between the two velocity estimates

I think this enhancement is more important than first assumed. It might not only improve the controller, but especially the land-detector which uses vertical movement as a criteria:
https://github.com/PX4/Firmware/blob/master/src/modules/land_detector/MulticopterLandDetector.cpp#L185
When testing in SITL it is obvious that the land detection is very vulnerable for wrong velocity estimates. Depending on the bias, the landing takes much longer.

The white line is the estimated velocity, blue is the velocity setpoint and orange is the thrust during landing (the vehicle is already on the ground). This explains also why the time it takes to land is not deterministic and depends on the bias.

I've rebased this and the corresponding ecl branch

The required ecl library changes have been merged and I have rebased this on latest master and retested.


Peeking unknown rooms

PR meant for review (not for merge)

@psrpinto Thanks for the great suggestions! <3
Could you explain the issue in your screencast? matrix.org doesn't allow previews on their rooms if you are not in the room and hence peeking can't be functional for those rooms. I believe they must have done it to prevent DOS attacks or to improve scaling. How were you able to even trigger the timeline to load for you?

Hydrogen already shows the timeline if you left the room, I believe.

Actually, on master. if I navigate to !OGEhHVWSdvArJzumhm%3Amatrix.org (#matrix:matrix.org)  it shows "You are currently not in !OGEhHVWSdvArJzumhm:matrix.org. Want to join it?", it doesn't render the timeline.
Am I going crazy? I  thought I'd seen hydrogen rendering the timeline for rooms you left, with history up to the point you left, and a message in the bottom saying "You left the room".

So that might explain why the timeline renders for me, which would mean that we would have to take that scenario in account.

That would be the timeline you saw for an archive room. Unless we choose to forget the room, UnknownRoomView doesn't come into the picture and by then peeking functionality handles it.

By "doesn't allow" you mean that you can't call the /messages endpoint for the room if you're not a member?

Correct! If you try to peek into matrix hq room, you will see console errors stating previews are disabled.
I tried peeking into !OGEhHVWSdvArJzumhm%3Amatrix.org and it was 403: User @p1:synapse.dev:8008 not in room !OGEhHVWSdvArJzumhm:matrix.org, and room previews are disabled which is shown in console as well.
I think you got confused by the archive room timeline view after leaving the room.

@psrpinto and I discussed this more and it turns out this happens when you try to peek into a room that you earlier were a member in but not anymore. Weirdly enough matrix.org has room previews disabled if you are trying to peek from another homeserver but if you are logged in with an account on matrix.org, it lets you preview but with this edge case of /messages endpoint acting up. I will continue to look into this.
Also while trying to figure this out, I was happy to learn that back scrolling is functional as is :)

Created PR on upstream - https://github.com/vector-im/hydrogen-web/pull/1037 so closing this PR


Refactor: use @hamster-bot/constructeur instead of local config

resolve #7

reslove #7

closed as superseded by #9


install search_api_solr and facets

GitHub Issue: (link)

https://github.com/Islandora-CLAW/CLAW/issues/698

What does this Pull Request do?
This pull request enable the following modules:

Solr Search
search_api_solr_defaults (part of search_api_solr)
Facets

It copies the required search_api_solr into the solr CLAW instance 'sudo cp -R /var/www/html/drupal/web/modules/contrib/search_api_solr/solr-conf/6.x/* /var/solr/data/CLAW/conf' and restarts the solr service.
How should this be tested?

This PR is dependent on https://github.com/Islandora-CLAW/drupal-project/pull/15  ***
Once that PR gets in, checkout this branch and 'vagrant up'
The above noted modules should be enabled in drupal

@Islandora-CLAW/committers

I've tested along with https://github.com/Islandora-CLAW/drupal-project/pull/15 and it appears to work as described.


fix: stop delegating resume/play to controller.

Revert to keeping logic of resume vs play in the onPlay handler returned from useTts.  Stories were playing paused content from other stories.
Additionally, call clear before playing to empty the utterance queue used by window.speechSynthesis.

Codecov Report

Merging #28 (a533542) into main (cb3dfc7) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   97.60%   97.81%   +0.20%
==========================================
  Files           7        7
  Lines         501      503       +2
  Branches      137      138       +1
==========================================
+ Hits          489      492       +3
+ Misses         12       11       -1

Impacted Files
Coverage Δ

src/controller.ts
99.06% <100.00%> (+0.46%)
:arrow_up:

src/hook.tsx
95.10% <100.00%> (+0.08%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fingerprints file is no longer being generated

It looks like something has changed in the repository configuration around 2 months ago (enabled branch protection on main?), and since then all runs of the gen_fingerprints workflow have been failing, resulting in a drift between the information in the README and the JSON fingerprints.
If you have enabled branch protection on main, I believe the solution would be to create a PAT with public_repo permissions and use that in the checkout step of your workflow so that it's used later on when pushing. Could you look into this please?

Closing this since fingerprints generation seems to work again.


Queue case study: can you make a range of UNITS.minutes or any dimensional unit?

The queue case study has instructions to Set duration, which is the number of time steps to simulate, to 10 hours, expressed in minutes.
I did this in the following way
minutes = UNITS.minutes
hours = UNITS.hour
duration=(10*hours).to(minutes)

Later on, there is a prewritten function that uses the system duration to create a range
for t in linrange(0, system.duration):
When that runs, it gives me the following error:

DimensionalityError                       Traceback (most recent call last)
 in ()
1 # Solution goes here
----> 2 results = run_simulation(system, update)
3 plot(results)
 in run_simulation(system, update_func)
9     results[0] = x
10
---> 11     for t in linrange(0, system.duration):
12         x = update_func(x, t, system)
13         results[t+1] = x
~/projects/modsim.py in linrange(start, stop, step, **options)
178         n += 1
179
--> 180     array = np.linspace(start, stop, int(n), **options)
181     if units:
182         array = array * units
~/miniconda2/envs/simulation/lib/python3.7/site-packages/pint/quantity.py in int(self)
439         if self.dimensionless:
440             return int(self._convert_magnitude_not_inplace(UnitsContainer()))
--> 441         raise DimensionalityError(self._units, 'dimensionless')
442
443     def long(self):
DimensionalityError: Cannot convert from 'minute' to 'dimensionless'

Should duration not be using units, is there a way do create a range with units, or am I missing something simple?

Excellent question.  In the short term, you can work around this by making duration dimensionless.
But I will investigate this and see if there is a good way to make it work the way you wanted it to.

Great, thanks! I thought the instructions were leading us to use Pint when they suggested converting 10 hours to minutes, rather than just saying 600 minutes.

I agree that the instructions were not clear.
I have also updated linspace and linrange to work better with units, so you could try that again.


E2E: Improve reliability of the private label test

This PR improves the reliability of the Branding Private Label tests.
When running locally, the check for the title change would fail for me - I've changed this slightly to improve reliability.

@aalves08 Should be there  - it is generated though, so you won't find it - i.e. look for -color-input and you'll find it in ColorInput.vue.


Add support for traces via opentelemetry

https://opentelemetry.io/docs/concepts/signals/traces/
in our managed service, we trace:

time from transcription to first agent chunk
time from first agent chunk to first synthesis chunk

planning on open-sourcing this soon, just wanted to track it here / see if others had thoughts!

Excited for this! Here is a wishlist of the info I'd like to this exported:
Transcriber latency
I would start with DeepGram since this is the one that is generally recommended currently and provides all the API to properly monitor latency (see article). The specific info I'm interested in are total latency (including network) and transcription latency.
LLM / OpenAPI latency
The time to  first word / chunk, and the average throughput of word / second for each a request. The latter one will be helpful to see if the LLM throughput becomes the bottleneck and leads to pauses between sentences.
TTS latency
The latency to receive the first audio chunk from the first chunk of words / sentences, and once we get the first audio chunk wether or not we send audio chunks at a faster rate than the time it takes to playback that audio.
Playback / Twilio latency
For Twilio, I'd like to be able to monitor the latency between us sending the first audio chunk of an agent response when it's actually played back. We can do this using the mark event.  The absolute value might not be super useful because it includes the time for Twilio to send us back that event, but I think the relative value would be helpful to monitor the stability of the websocket stream and Twilio servers.
Overall latency
I'd like to see the latency from the end of human finishing speaking (as par deepgram timestamp of the last word) to the first audio chunk being played back (acknowledged via the mark Twilio event). This will aggregate all those previous latencies and also account for the things happening in between (such as time from final transcription to sending a request to the llm or the time from which we receive the synthesized audio to which we send it to Twilio) to give us a sense of the overall reactivity of the system at any given time.
Interruptions
Interruptions are key for the system to feel reactive and snappy. In theory, once interruptions are implemented reliably they should be snappy but I still think it would worth monitoring it now to spot any regression in the codebase. I suggest we track the time from first word (as detected by Deepgram to the time it takes from clearing the Twilio buffer using the clear and mark event, which we don't do at the moment but we should.
Overall IO stability
In addition to all of this, we should monitor at the application level stability of all the IO connections (http and websocket) by tracking the number of failures and retries. Longer term, we can look into tracking that TCP packet drops to these hosts at the OS layer.
Next
I would love to hear your thoughts about those. Once we agree on a list of info we care about, let's talk about traces vs metrics / histograms for each piece of info. There are tradeoff around performance and easy of use - but that's a topic of its own.

Got started on this one today with this pr https://github.com/vocodedev/vocode-python/pull/99
Added basic LLM latency + synthesizer latency


[Testing] Ensure unit test coverage of supplier module

Objective
Ensure suffiicent unit test coverage of the supplier module.
Origin Document

Goals

Port applicable, existing, unmerged tests (#266, #250).
Identify and add any important and missing coverage.

Deliverables

[ ] Port applicable tests from #266
[ ] Port applicable tests from #250

Non-goals / Non-deliverables

...

General deliverables

[ ] Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
[ ] Testing: Add new tests (unit and/or E2E) to the test suite.
[ ] Makefile: Add new targets to the Makefile to make the new functionality easier to use.
[ ] Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @bryanchriswhite
Co-Owners:

TOo general.


ftu-tabs

Appearance

[ ] (Only tabs) https://www.figma.com/file/VlNjSrctLEc0Wyu32FmnZq/Functional-Tissue-Unit-Explorer?node-id=390%3A30139&t=o3NbpHYGJM1mOJIO-4

Used components/directives

[ ] https://material.angular.io/components/tabs/overview

Might not be needed. Some global tweaks to mat-tabs might do instead


Scala-style Optional 'when' & 'unless' constructors

Before submitting a pull request, please make sure the following is done:

Fork the repository and create your branch from master. ✅
Run npm install in the repository root. ✅
If you've fixed a bug or added code that should be tested, add tests! ✅
Ensure the test suite passes (npm test). ✅

Note. If you've fixed a bug please link the related issue or, if missing, open an issue before sending a PR. (N/A)
Note. If you find a typo in the documentation, make sure to modify the corresponding source (docs are generated). (N/A)
Note. If you want to send a PR related to<EMAIL_ADDRESS>please create your branch from 1.x (N/A)

closes #1239

@anthonyjoeseph thanks for this PR but I'm afraid I can accept it, just a little above the new when API you can find fromPredicate which is almost identical (actually more general, a Predicate<A> versus a boolean)

In that case, I'll just make a note here that the scala-style when
Option.when(true)

is equivalent to fp-ts:
O.fromPredicate(() => true)

Thanks for such a quick response!


Clean up code in AStarPathfinder

Resolves #794
I did not yet merge the findPath methods as for me it makes sense to have a pure function with the actual implementation. Should I do it regardless?
getValidNeighbours should be fine like this.

Thanks, any thoughts why tests pass on jdk14 and ea, but not 11: travis ci?

I am not sure. I think it might not be deterministic. The test now fails locally for me as well, which it did at some point but not when I pushed. What is especially weird is that the test fails which does not have busy cells.
I will investigate.
Would it bother you if I convert some files to Kotlin?

I think I understand the issue, my change made the solution path non-deterministic. If you look at the example below with the start state s, goal state g, and two other states x and y.
s | x
y | g
Both paths s-x-g and s-y-g are valid, it just depends which state is expanded first. This non-deterministic character was introduced by either the stream or the set.
I think set is not appropriate here as we generally care for order in search. The stream limitation I would like to remove by just going to Kotlin.

Codecov Report

Merging #880 into dev will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev     #880      +/-   ##
============================================
- Coverage     59.20%   59.17%   -0.03%
+ Complexity     2379     2372       -7
============================================
  Files           258      258
  Lines         11750    11739      -11
  Branches       1077     1072       -5
============================================
- Hits           6956     6947       -9
  Misses         4474     4474
+ Partials        320      318       -2

Impacted Files
Coverage Δ
Complexity Δ

...almasb/fxgl/pathfinding/astar/AStarPathfinder.java
88.13% <100.00%> (-0.44%)
20.00 <3.00> (-8.00)

.../src/main/kotlin/com/almasb/fxgl/app/LoopRunner.kt
97.61% <0.00%> (+2.38%)
12.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc7c6bd...01ad759. Read the comment docs.

Nice detective work!

This non-deterministic character was introduced by either the stream or the set.

This got me curious, so I looked up their documentation.

Streams may or may not have a defined encounter order. Whether or not a stream has an encounter order depends on the source and the intermediate operations. Certain stream sources (such as List or arrays) are intrinsically ordered, whereas others (such as HashSet) are not.

The source (grid.getNeighbors()) is a List, so stream() will keep the order, but the implementation of toSet() is a HashSet, which, according to its doc, says:

It makes no guarantees as to the iteration order of the set;

The source (grid.getNeighbors()) is a List, so stream() will keep the order, but the implementation of toSet() is a HashSet, which, according to its doc, says:

Streams actually keep order. Good to know. Thanks.

I improved the reporting of the error and converted the tests to Kotlin. Is this alright?

Good stuff, many thanks!


Update introduction.md

🚀 Deployed on https://630e9381a51b21126a29fb66--cozy-fox-0defec.netlify.app


Document submethod DESTROY, and its intricacies

Custom classes can implement submethod DESTROY to do some clean-up when/if an object of that class is about to be garbage-collected.
AFAICT, p6doc currently does not explain this.

There are some intricacies to document:

It is not guaranteed to be run (e.g. it'll never run for objects that aren't garbage collected before the end of the program).

One mustn't make any assumptions about what the dynamic environment of that thread currently looks like.   ("just about anything can be on the call stack at the point a DESTROY is called" — jnthn).

For example...

if the thread in question has called .protect(&code) on a Lock...
and is in the middle of executing &code when it is paused by garbage collection...
and your DESTROY method calls .protect(&other-code) on the same lock...

...then &other-code will be executed immediately even though &code has not yet finished – because Lock.protect is idempotent (i.e. can be recursively locked from the same thread).

In such cases, one can write a DESTROY method as follows to ensure it is run on a "clean" thread that is not in the middle of doing things which may cause surprises for your clean-up code:
submethod DESTROY { start { ... } }
I.e. in the Lock example:
submethod DESTROY { start $lock.protect: { ... } }
You can safely close over self in the { ... } part, and object destruction will be deferred for as long as necessary. DESTROY won't be called a second time on the same object.
See IRC discussion starting here.

Also worth noting the "you only live twice" semantics - that is, if you bring an object back to life by referencing it from somewhere else again, then the second time it become free the DESTROY method will not be called a second time. For a given instance, DESTROY is called at most once.


SQL ISNULL function not implemented

Function "ISNULL" is either not recognized or defined. Functionality should be similar to base SQL function, able to handle input
"(varchar, varchar)" or "(int, int)"

Adding explicit type castings does not affect result e.g
ISNULL(race_concept_id, 0) //does not work
ISNULL(cast(race_concept_id as text), cast(0 as text)) //does not work
ISNULL(cast(race_concept_id as text), 0) //does not work
ISNULL(race_concept_id, cast(0 as text)) //does not work

Hi @Zwky26,
Perseus uses postgres syntax, try this - coalesce(field, 'Empty')
Thanks,
Anton

That works! A tangential fix to this is to remove the ISNULL quick function from within the SQL function popup, as seen below.


table.insert does not return a Promise

table.insert does not return a promise or has a dangling one

Is this a client library issue or a product issue?
Client library issue

Did someone already solve this?
Node

Do you have a support contract?
No

If the support paths suggested above still do not result in a resolution, please provide the following details.
Environment details

OS: MacOs
Node.js version: v14.16.1
npm version: 6.14.12
@google-cloud/bigquery version: 5.5.0

Steps to reproduce

Call table.insert without a callback and wrap it in a try/catch, as in:

try {
  await this.table.insert({...});
} catch (error) {
 ...
}

If the data has a wrong type, then the call will have an Unhandled rejection.

Below are the errors:
Unhandled rejection
Unhandled rejection
PartialFailureError at Table._insert (/workspace/node_modules/@google-cloud/bigquery/build/src/table.js:1611:19)
                               at processTicksAndRejections (internal/process/task_queues.js:97:5)
                               at async Table._insertWithRetry (/workspace/node_modules/@google-cloud/bigquery/build/src/table.js:1548:24)
                               at async Table._insertAndCreateTable (/workspace/node_modules/@google-cloud/bigquery/build/src/table.js:1510:20)

This might explain why we're seeing data loss when inserting from Cloud Functions. Every day we lose 1-10 rows without errors.
This could be because CF has very strict coding guidelines as in: "Every promise must be awaited". If you have a promise running when it gets to EOF, the CPU loses all resources, making the promise not complete.

@larssn Thanks for the patch! Hopefully this will clear up the issue for everyone.

@feywind Please reopen this and revert the PR. As I pointed out the change does not fix the issue, as the methods were already being promisified.


Test avoidance pkg

This PR enables / fixes tests for the avoidance package.

moved histogram to avoidance pkg
fixed Travis to also test avoidance

This fixes #356

Wow, I was missing out a lot of things...Thanks!


[FLINK-21128][k8s] Introduce dedicated scripts for native K8s integration

What is the purpose of the change
Currently, the native Kubernetes integration assembles a java command that is passed to the docker-script, which first does some magical stuff to create the classpath.
# Set the Flink related environments
export _FLINK_HOME_DETERMINED=true
. $FLINK_HOME/bin/config.sh
export FLINK_CLASSPATH="`constructFlinkClassPath`:$INTERNAL_HADOOP_CLASSPATHS"

and then evaluates the given java command.
This is really confusing for new devs and not easy to maintain. Also we take a burden to the docker-entrypoint.sh in flink-docker repository.
This PR introduces some dedicated scripts(e.g. kubernetes-jobmanager.sh, kubernetes-taskmanager.sh) for native K8s integration. These scripts share the many logics with standalone deployment. And the duplicated java implementation will be removed.
Brief change log

[hotfix][dist] Extract parseTmArgsAndExportLogs to config.sh so that it could be reused
[FLINK-21128][k8s] Introduce dedicated scripts for native K8s integration

Verifying this change

Update unit tests for the CmdJobManagerDecorator and CmdTaskManagerDecorator
Since we do not change the user sensed behavior, the e2e test should pass without changing

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @zentol could you please help to review this PR? I think you are the one who know the intention of this PR best.

@zentol Thanks for your review. Comments addressed.

Rebase master branch and resolve conflicts.

Rebase master branch and resolve conflicts.

+1

@zentol so could you help with the merging?

Ah sorry, I completely forgot you aren't a committer.


Add validation to transiting question

Trello: https://trello.com/c/vp9op3Dd
What's changed?
Validate that users cannot select all of their previously selected countries as transiting countries. At least one country must be unchecked to be considered a destination country.
Why?
In the results, the guidance for transiting countries is much less than the guidance for destination countries. This check guards against users misreading the question, selecting all of the countries thinking that they are selecting destinations and only being provided with limited guidance.
Expected changes
New error

Existing error (remains unchanged)

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

I noticed a problem with this which is that this overwrites the default error message when no questions are checked 'Please answer this question' with 'You must leave at least one country unselected' which looks a bit weird:
I think it will also need to check that the countries are not empty.

Good spot! I've updated the error block so that both errors are now being displayed.


add special chars to dg

eg son of (s/o) and - and various others to known issues in DG

jian bings doing this


Plyr does not react to "native" events

In chrome when right-clicking on the video you can use the native html5 player controls to pause, mute. This is a good ting, but plyr does not reflect the changes.
If you pause the player via native plyr will still show the video as playing (Pause icon). When you click the plyr pause icon the video remains paused, and you have to click one more time to trigger playback again.
Observed in Chrome and Firefox on OSX.

Thanks for this. I'll fix this tomorrow.

Nice, thanks it looks nice otherwise :+1:

Let me know if you run into any more issues :+1:
Cheers!


Issue https://github.com/GoogleCloudPlatform/jetty-runtime/issues/120

Make docker-entrypoint easily extensible for https://github.com/GoogleCloudPlatform/jetty-runtime/issues/120

@gregw Thinking about this a bit more, I think I'd rather just have the child image append to the setup-env.bash, and then this PR is not needed.

OK that works.


Fix formatting

Codecov Report

Merging #232 (7e305e3) into master (ee42271) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage     73.03%   73.03%
  Complexity      787      787
=========================================
  Files           101      101
  Lines          2433     2433
  Branches        284      284
=========================================
  Hits           1777     1777
  Misses          553      553
  Partials        103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee42271...7e305e3. Read the comment docs.


ISPN-8245 Make Hibernate Cache provider work with Hibernate 5.1

We need to get this into Infinispan 9.1.1 so that Wildfly can consume it.

Test failure has nothing to do with PR.

@pferraro we need you to validate this.

@rvansa I've sent a commit fixing the comments agreed upon.

@rvansa I've fixed the latest comment. If you're happy, I'll squash and update branch.

Sure, do so.

@rvansa Rebased

There were no failures in the build before squash, integrated. Thanks.


Update RouteLocation.tsx

Commit Changes added name

What issues out of the bugs mentioned here ( https://github.com/p32929/p32929.github.io/blob/react/BUGS.md ) gets solved in this pull request?


rene: Watch techyabi.blogspot.com

rene requests the watch of the watch_keyword techyabi\.blogspot\.com. See the MS search here and the Stack Exchange search here.

techyabi\.blogspot\.com has been seen in 2 true positives, 0 false positives, and 0 NAAs.

Approved by Nisse Engström in Charcoal HQ


OrderedDataStore compatible number converting function

Since constructed numbers are stored as strings, we can not use them in OrderedDataStores. This means global leaderboards are not possible with constructed numbers.
We can use Reverse to get a normal number again, but if its higher than 1e+308 it will return INF.
This wont work, but the closest idea I have is: we can take the exponent and coefficient and create a number that will be ordered correctly and still not go over the limit.
If we take a number like "1, 500", we can take the amount of zeros as the number, and the coefficient as a decimal
IM.new("1, 500"):ConvertForLeaderboard() --function name pending

This would give us 500.1, which would work perfectly except OrderedDataStores only take Integers which means decimals are not supported.
If we try to get rid of the decimal, ordering will be inaccurate. Say we had "1.2345, 5" (123450), we would get 5.12345, decimal removed would be 512345. 5001 is lower than 512345, but we want 5001 to be bigger because it should have more zeros.

The solution to this was to remove the decimal by multiplying by a set number, instead of just pulling it out of the number. This way, all numbers went up the same amount and decimals were removed, so the order was the same.


Avoid deploy tests

Coverage remained the same at 98.294% when pulling 3c9bd16a708be9b53525f1e08dff60ade4812e65 on avoid-deploy-tests into 5d0c6573924dae330338f909222e308ba80bd55c on master.

Coverage increased (+0.01%) to 98.304% when pulling 12a3927377d3f8ac429f7a1ca0342d75370e43f8 on avoid-deploy-tests into 5d0c6573924dae330338f909222e308ba80bd55c on master.


How do you open webview in new window automatically?

Is there a way to open help files via the webview functionality in a new window? At the moment, it seems to open in the same window where I executed the code?
Is this possible? If not, could this be a an option?

This could certainly be an option. The problem here is that help triggers browser so we actually do not know if it is help or a shiny app. It makes sense to show the shinyapp in active editor group while show help on one side. I'll think about it more.


[Auto-generated] Update dependencies

Update dependencies
Automatically created PR from ci/dependency-updates.
The PR is based on the 'CI - Update dependencies PR' workflow in SINTEF/ci-cd.
To do

[ ] Check that the diff is sensible, and that tests and builds pass with the new dependency versions.
[ ] Make sure the PR is squash merged, with a sensible commit message.

Codecov Report

Merging #97 (0564815) into main (1a35c8c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   53.69%   53.69%
=======================================
  Files           3        3
  Lines         311      311
=======================================
  Hits          167      167
  Misses        144      144

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


offsetParent with padding problem

Using the offsetParent option and setting padding the parent makes the right drag limit wrong (it looks like its padding-left + padding-right).
Reproducing the bug on the demo is easy, just open the dev tools and set the padding to the container with scrollbars.
Setting only the left padding 'works' (in this case, the right padding must not be set and is the same as left...).
Maybe I missed something ?

Unfortunately, I don't have access to a Linux for now so I can't create the PR.
But I found the bug in positionFns.es6:
// Compute bounds. This is a pain with padding and offsets but this gets it exactly right.
    bounds = {
      left: -node.offsetLeft + int(boundNodeStyle.paddingLeft) +
            int(nodeStyle.borderLeftWidth) + int(nodeStyle.marginLeft),
      top: -node.offsetTop + int(boundNodeStyle.paddingTop) +
            int(nodeStyle.borderTopWidth) + int(nodeStyle.marginTop),
      right: innerWidth(boundNode) - outerWidth(node) - node.offsetLeft,
      bottom: innerHeight(boundNode) - outerHeight(node) - node.offsetTop
    };

Despite the comment, the bug is here:

padding is added to left and top, this is good
innerWidth() and innerHeight() functions remove both left, top and right, bottom paddings, this is not good

So the fix would be something like this here:
right: innerWidth(boundNode) - outerWidth(node) - node.offsetLeft - int(boundNodeStyle.paddingRight),
bottom: innerHeight(boundNode) - outerHeight(node) - node.offsetTop - int(boundNodeStyle.paddingBottom)

I also suggest adding paddings to this box in the example, like so:
<div style={{height: '1000px', width: '1000px', paddingTop: '10px', paddingLeft: '20px', paddingRigth: '30px', paddingBottom: '40px'}}>

It would be nice if someone could create a PR for this before I get my hands to a Linux ;)

Nice, thanks


OperatingSystemConfig validation can return an error on Azure during control plane migration

How to categorize this issue?

/area control-plane
/area control-plane-migration
/kind bug
/priority 3
What happened:
The newly added validation of OperatingSystemConfig resources can return an error control plane migration if the cloud-provider-disk-config secret is missing with:
task "Annotating Extensions CRs with operation - migration" failed: 2 errors occurred:
	* admission webhook "validation.extensions.seed.admission.core.gardener.cloud" denied the request: OperatingSystemConfig.extensions.gardener.cloud "shoot-garden-az/cloud-config-cpu-worker-a93d4-gardenlinux-original" is invalid: spec.files[18].content.inline.data: Required value: field is required
	* admission webhook "validation.extensions.seed.admission.core.gardener.cloud" denied the request: OperatingSystemConfig.extensions.gardener.cloud "shoot-garden-az/cloud-config-cpu-worker-etcd-a93d4-gardenlinux-original" is invalid: spec.files[18].content.inline.data: Required value: field is required

This seems to happen because the controlplane webhook for Azure tries to mutate the OperatingSystemConfig by appending an entry to the spec.files array, but if the cloud-provider-disk-config secret is missing from the shoot's control plane the data of the file content will be an empty string and therefore the validation returns an error.
Before the validation of the OperatingSystemConfig resources was introduced the  spec.file[18].content would just be added with an empty data field.
What you expected to happen:
The invalid file array entry (with an empty data field) should not be added to the OperatingSystemConfig by the mutating webhook and the validation should succeed.
How to reproduce it (as minimally and precisely as possible):

Enable the feature gate for the extension resource validation
Create a shoot cluster and wait for it to be reconciled.
Annotate the controlplane resource with gardener.cloud/operation=migrate and wait for the operation to succeed (this will remove the cloud-provider-disk-config secret).
Try annotating the *-original OSCs with gardener.cloud/operation=migrate and observe that the seed admission webhook denies the request.

Anything else we need to know?:
Environment:

Gardener version: latest master branch
Kubernetes version (use kubectl version):
Cloud provider or hardware configuration: Azure
Others:

/assign


Is Radix Sort an advanced Algorithm?

Shouldn't it be classified as "Beginner"?

@buraksarica yes, you're probably right. I've changed that.


Add concurrency block to cancel previous CI runs

Resolves #889

Codecov Report

Merging #894 (c7f0126) into main (3f2d743) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
- Coverage   58.53%   58.41%   -0.13%
==========================================
  Files         125      125
  Lines        7409     7409
==========================================
- Hits         4337     4328       -9
- Misses       2617     2623       +6
- Partials      455      458       +3

Impacted Files
Coverage Δ

ipld/nmt_adder.go
68.00% <0.00%> (-24.00%)
:arrow_down:

ipld/retriever.go
90.38% <0.00%> (-1.93%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2d743...c7f0126. Read the comment docs.

Thanks for working through this @iofq! Good work!


Deprecate Chapter Read Markers

As per deprecation notice in MangaDex API 5.7.1
Uses mark manga chapters as read in batch endpoint to replace all chapter read marker usage
i.e. GET/POST /manga/{id}/read instead of POST/DELETE /chapter/{id}/read
mostly made possible by matching types and bringing over (manga) stuff wherever required
could probably just have passed manga.uuid() instead of entire manga ig
marking as draft because I'll try testing it a bit

Didn't see this PR, but ended up doing it this morning.  Basically the same with a couple minor tweaks