Add chruschong.md for chrus-chong portfolio

Codecov Report

Merging #130 (b5dac66) into master (0cd5900) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #130   +/-   ##
=========================================
  Coverage     61.64%   61.64%
  Complexity      438      438
=========================================
  Files            91       91
  Lines          1661     1661
  Branches        180      180
=========================================
  Hits           1024     1024
  Misses          592      592
  Partials         45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cd5900...b5dac66. Read the comment docs.


HF LLaMA Flax

Hey @ayaka14732! Super cool repo - thanks for working on this! With @vvvm23, we're working on adding the Flax LLaMA model to HF Transformers: https://github.com/huggingface/transformers/pull/24587 Just thought I'd let you know since it might be of interest to you, and potentially a model class that you can leverage in this repo for fast inference/training. It'll be a fully integrated version of the Flax LLaMA model in Transformers by the time of release.

Hi @sanchit-gandhi, thank you for letting me know! I am definitely interested and I will be sure to check out the progress!


neomutt: 20230512 -> 20230517

Description of changes
2023-05-12 is broken, 2023-05-17 has fixes for other platforms than x86_64-linux. https://github.com/neomutt/neomutt/releases/tag/20230517
ZHF #230712
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 233363 run on aarch64-darwin 1

1 package failed to build:

neomutt

Result of nixpkgs-review pr 233363 run on x86_64-darwin 1

1 package failed to build:

neomutt


Enable total number of rows and page size for server side pagination in table widget

Description
Enable number of rows and default page size for server side pagination in table widget
Fixes #1578, #2230
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Cypress test that validates table data with api bindings, default page size and total records count

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: configure-table-data-rows-count

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
51.67 (-0.02)
32.89 (-0.04)
29.64 (0)
52.15 (-0.02)

:red_circle:
app/client/src/widgets/TableWidget/index.tsx
9 (-0.31)
0 (0)
10.64 (0)
9.6 (-0.37)

/ok-to-test sha=cb5a87f

/ok-to-test sha=b256824

/ok-to-test sha=a97963a

/ok-to-test sha=4806ab6

/ok-to-test sha=f2538c7

@riodeuno need you approval here

/ok-to-test sha=1d77bfe

/ok-to-test sha=5bcb388

@vicky-primathon execution_param.spec.js was fixed, can you merge once more.
@NandanAnantharamu kindly correct me if I am wrong

@vicky-primathon execution_param.spec.js was fixed, can you merge once more.
@NandanAnantharamu kindly correct me if I am wrong

yes we have fixed this issue @somangshu


Changing neume encoding examples to version 4.0

Removed uneume and note element with neume and nc

It seems that this PR will be "overwritten" by #135 .
@vigliensoni can you confirm that the issue addressed here is going to be addressed in the PR of the Neumes SIG?

@musicEnfanthen I confirm PR #135 has examples with valid MEI4.0

@timeipert thanks for the contribution, but due to the larger impact of #135 including I'll close this PR without merging


fix[experimental]: Fix text splitter with gradient

Fixes #26221

this seems right. could you add a unit test that fails on current that this fixes?

@efriis sure, test added

thanks!


Expose tab focus mode prop so we can override tab-trapping behaviour

It would be useful to expose this property so that we are able to override the tab behaviour of the editor.
By default in the neo4j setup, we set up handlers for Tab and Shift-Tab - however this traps the user in the editor. Whilst it's then possible to use Esc to remove focus from the editor, in some circumstances (e.g. the editor is in a modal where Esc closes the modal), it'd be nice to be able to disable tab trapping.
https://codemirror.net/docs/ref/#view.EditorView.setTabFocusMode

 Can not navigate to save button using keyaboard when editing saved cypher


pin repository to msrv of 1.41.0

I just saw https://github.com/ron-rs/ron/pull/229, which explicitly tries to keep the version as low as possible. It's up for debate if this PR should be merged or not. I personally don't see any benefit on staying on lower MSRV as using rustup the installation can just be updated anyway. And since I use Ubuntu I always try to stick with their latest version.
I do understand though if people want to stick with lower versions. In this case, the version could be pinned to 1.34.0 instead.


boards/sim: Add duktape config

Summary
Add config for duktape to run build test
Impact
Testing
Tested on sim, but a warning needs to be fixed.

The build break fixed in https://github.com/apache/incubator-nuttx-apps/pull/355

The build break on macOS fixed in apache/incubator-nuttx-apps#356


Add add_hpx_module function

To factorize module's CMakeLists.txt because redundant code in each module.

Part of the idea of introducing modules was to enable people to use those independently. Wouldn't that imply that the CMakeLists.txt for the modules have to have their own project() statement?

Sorry I misunderstood your previous comment, I'll try to put it inside the function

Sorry apparently there is come problems, I will check those :/

Ok this should be good to go, sorry for the wait ^^


Update .active-directory-b2c.json

#https://github.com/MicrosoftDocs/azure-docs/compare/master...cimcgee:patch-5?diff=split#diff-e1b75c2bc7cbcacdfc1796364d359780b419948656c2a6764ac205195e0003a6CODE_OF_CONDUCT.mdR11

https://github.com/MicrosoftDocs/azure-docs/compare/master...cimcgee:patch-5?diff=split#diff-e1b75c2bc7cbcacdfc1796364d359780b419948656c2a6764ac205195e0003a6CODE_OF_CONDUCT.mdR11

@

Hi @cimcgee Your pull request can't be merged in this repository. We'll close it.
@SyntaxC4 @snoviking


Fix/hexanoate

Main improvements in this PR:
This PR addresses #716 by removing the hexanoate MAM03684c species, and swapping hexanoic acid MAM02120c where applicable.
Changes done:

Added mitochondrial and peroxisomal versions of MAM02120c, MAM02120m and MAM02120x, respectively
Species MAM03684c, MAM03684m, MAM03684x, and MAM03684e have been removed
Removed reactions of hexanoate activation (MAR09949), transport (MAR11292) and exchange (MAR11293), which are duplicate to MAR11544, MAR00167, and MAR09811, respectively
In reactions MAR10374, MAR10377, MAR11290, MAR11291, MAR20040, hexanoate was changed to hexanoic acid
Set reaction MAR10377 irreversible, as explained in #689

I hereby confirm that I have:

[X] Tested my code on my own computer for running the model
[X] Selected develop as a target branch
[X] Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

looks nice - please also merge annotation MAM03684 into MAM02120, such as the BiGG id

Good spot - added the BiGG id to MAM02120. This was the only annotation missing (MAM02120 was way more complete than MAM03684.

if there is any evidence supporting an irreversible MAR10377?

It involves hydrolyzing a high-energy bond, so the short answer is "thermodynamics". This traces back to the issues reported by Devlin Moyer and me (#527, #689), where [rightfully] setting reactions irreversible required additional fixes elsewhere

thanks for the clarification - may the GPR be updated with any ACOTs (#689)?

For the peroxisomal reaction MAR10377, the best candidate is ACOT8 (ENSG00000101473), as ACOT4 and ACOT6 are known to be rather specific to certain acyl-CoAs. Alongside, mitochondrial reaction MAR10374 was also missing a GPR, I suggest ACOT9 (ENSG00000123130) since mitochondrial ACOTs with known specificity (ACOT2, ACOT7, and THEM5) are specific to very long-chain FAs.

makes sense - please go ahead to implementation


UI Improvement

Motivation
Just some UI Tweaks
Usage example
when creating a new wallet and you want to copy your seed phrase there should be a confirmation popup that shows that it has been copied.
Possible implementations
when creating a new wallet and you want to copy your seed phrase there should be a confirmation popup thatshows that it has been copied

#206


Update rubymine-eap to 2017.1,171.3019.14

Update to the latest RubyMine EAP.

[X] brew cask audit --download {{cask_file}} is error-free.
[X] brew cask style --fix {{cask_file}} reports no offenses.
[X] The commit message includes the cask’s name and version.

Thank you for your contribution.


Detect memory leaks in run-tests.sh

In run-tests.sh we now use valgrind to make sure we have no memory leaks.
A memory leak will cause a warning, but won't break travis. We chose this behaviour especially because there are some memory leaks that we are not responsible of (SFML has memory leaks because there are memory leaks in OpenGL if I'm correct).
This PR also uses a std::unique_ptr in the image reader.

Ok, so there are two kinds of leak
- the ones we consider as important (that will be written in red in the log and that will make the build fail)
- the ones we consider as less important (that will be written in yellow in the log), and we that can't really do anything about.
The run-tests.py script parses valgrind's output in order to detect if the leaks of the tests are important or not.


[Bug]: Javascript Page Layout is not Align

Describe the bug
The project dashboard layout is misaligned, making navigation and interaction difficult.
I expect the JavaScript page layout in GitLab to align correctly and render all elements as intended.
Expected Behavior
I expect the JavaScript page layout in GitLab to align correctly and render all elements as intended.
Screenshot/ Video

assign me this

@pradeeptosarkar's, I hope this message finds you well. I'd like to request the assignment of this issue to me. I initially raised this issue with the intention of resolving it, and I believe I can provide a timely and efficient solution.
I appreciate @gaudzispriyanshu's interest in contributing to this issue, but given my prior involvement and familiarity with the problem, I would like to continue working on it.
@gaudzispriyanshu, thank you for your willingness to help. If there are other issues or opportunities to collaborate, I'd be more than happy to work together on those.
I kindly request your permission to be assigned to this issue so that I can proceed with the resolution. Your consideration is greatly appreciated.
Thank you for your time and understanding.
Best regards,
@sagarbee

@sagarbee ohh! it's okay


Increased coverage for internal

Ticket Link

Related Links

Description

Steps to Reproduce / Test

Request

Response

Codecov Report
Patch coverage has no change and project coverage change: +2.94 :tada:

Comparison is base (fdccf81) 94.28% compared to head (8a2f925) 97.23%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   94.28%   97.23%   +2.94%
==========================================
  Files          28       28
  Lines        1120     1120
==========================================
+ Hits         1056     1089      +33
+ Misses         50       23      -27
+ Partials       14        8       -6

see 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


AbstractLogstashTcpSocketAppender ignores Encoder#headerBytes and Encoder#footerBytes

AbstractLogstashTcpSocketAppender ignores Encoder#headerBytes and Encoder#footerBytes when encoding log events.
But.... when should these header/footer bytes be appended?

should the prefix be added when opening the stream and the footer when closing it? The appender never closes the stream by itself (except when reconnecting to the master from a secondary)...
should the be added before/after every event? In this case, what's the added value compared to including them inside the encode method?

I can't see any scenario where prefix/suffix would be useful in the context of the TcpSocketAppender...

should the prefix be added when opening the stream and the footer when closing it? The appender never closes the stream by itself (except when reconnecting to the master from a secondary)...

Yes.  The javadoc of the Encoder.headerBytes/footerBytes indicates that the return values of the methods should be added to the stream upon open/close, respectively.
In addition to the reconnect scenario, the appender should close the stream when the appender is stopped.

should the be added before/after every event?

No, at least according to the javadoc of the Encoder.headerBytes/footerBytes methods.
Also note that CompositeJsonEncoder has a separate prefix/suffix concept that can be used to add data before/after each event.  Prefix/suffix are useful if you need to add non-json data around the json event.

should the prefix be added when opening the stream and the footer when closing it? The appender never closes the stream by itself (except when reconnecting to the master from a secondary)...

Yes.  The javadoc of the Encoder.headerBytes/footerBytes indicates that the return values of the methods should be added to the stream upon open/close, respectively.
In addition to the reconnect scenario, the appender should close the stream when the appender is stopped.

should the be added before/after every event?

No, at least according to the javadoc of the Encoder.headerBytes/footerBytes methods.
Also note that CompositeJsonEncoder has a separate prefix/suffix concept that can be used to add data before/after each event.  Prefix/suffix are useful if you need to add non-json data around the json event.

Ok. So they are header/footer of the STREAM - not the EVENT.
I still don’t see how this would fit in the context of the TCP appender.

prefix can be output when opening a new connection - OK
suffix can be sent when actively closing the output stream - OK. But this means the connection must be “alive” - doesn’t work when the appender is disconnected or closes the socket because of a “dead peer” (that may not be actually dead but the network is down). I mean, I don’t see how a receiver can rely on the suffix...

Anyway, I don’t see any actual use case. And I even wonder if it is not “too dangerous” to implement this support. I mean, what would happen if someone uses an Encoder that actually supports these header/footers… This may be a breaking change I’m afraid.
I’m starting to wonder why I created this issue… may be I needed to develop the problem statement to realise it is a “no sense” ;-)

Ok. So they are header/footer of the STREAM - not the EVENT.
I still don’t see how this would fit in the context of the TCP appender.

prefix can be output when opening a new connection - OK
suffix can be sent when actively closing the output stream - OK. But this means the connection must be “alive” - doesn’t work when the appender is disconnected or closes the socket because of a “dead peer” (that may not be actually dead but the network is down). I mean, I don’t see how a receiver can rely on the suffix...

Anyway, I don’t see any actual use case. And I even wonder if it is not “too dangerous” to implement this support. I mean, what would happen if someone uses an Encoder that actually supports these header/footers… This may be a breaking change I’m afraid.
I’m starting to wonder why I created this issue… may be I needed to develop the problem statement to realise it is a “no sense” ;-)

Closing.  Feel free to reopen if you have a use case.


tab-to-indent conflicts with partial native support

Description
GitHub added native tab-to-indent support 🎉 but:

only on selected text (no selection = tab moves focus)
spaces 😩

This also conflicts with indent-textarea:

sometimes it just breaks
sometimes it adds both a tab and spaces

Possible solution

block the native tab-to-indent behavior

Browser
Safari
Example URLs
This page

Hi, I would like to work in this issue @fregante  do you know if we have something to block native GitHub functions to be called? Looks like first the refined-github is applied (with tab) and then the updateIndentation GitHub function is called, adding the spaces to the previous indentation.

I think we just need event.stopImmediatePropagation() inside my indent-textarea module.
To find out whether that works:

Edit node_modules/indent-textarea/index.js
Restart the build (or else changes might not be picked up)
Try reproducing the issue

If that works, you can send a PR directly to indent-text area

You can now open a PR here to update just this dependency, so it will appear in the next release changelog


TST: enable the linalg extension for torch

Oh wow good catch. I had no idea this was still being disabled (in the future, we should exclusively use the skips/xfails files to skip tests).


UI automation

Support UI (and UI automation) the windows ecosystem sadly is often "UI first" when it comes to software design. And the powershell/command line interfaces are not available or not documented at all. It would be great for sysadmins to be able to encapsulate these applications in containers, so that they are no longer bound to a single host and can be put into a k8s cluster without requiring something developers and Ranorex and a lot of time.

Thanks for opening this issue @agowa338.
Have you checked the Windows base container image? (Not Server Core or Nano Server)
This image does provide support for UI automation - the downside comes with the size of the image, but the scenario should work.

Ok, than it might be documentation. I was looking for this for some time only found stuff like this:

Sorry no. Microsoft specifically isn't supporting RDP or GUI's in containers, as far as I know. (...) but if you're trying to develop a desktop app, then containers aren't ideal.
Microsoft made a change sometime after microsoft/windowsservercore:1709_KB4074588, breaking RDS.
I’m looking forward to Windows apps being available with GUI; I think it’ll be really useful in my job.
UI testing is explicitly mentioned in the post, however I (and according to the reactions on that post some other people as well) are unable to actually interact with the app through WinAppDriver or other UI automation tools. (...) and also that there is no mouse support

Same. We need official way for UI automation.

We are waiting for updates here from Microsoft reps

Still waiting....

Microsoft team, please provide an update.

Same. We need official way for UI automation.

From the replies this got I think some clarification is needed. I also think I now understand what @vrapolinario meant with there already being an official way. There is: https://docs.microsoft.com/en-us/dotnet/framework/ui-automation
However the API is quite "limited" in some while being quite capable in other situations.
That API is not able to fake input to notepad without the window being onscreen and having focus.
This is because notepad requires "System.Windows.Automation.TextPattern" to be used instead of "System.Windows.Automation.ValuePattern" and that one does not offer a set text method (more about why that matters in the example at https://docs.microsoft.com/de-de/dotnet/framework/ui-automation/add-content-to-a-text-box-using-ui-automation).
Therefore the only way to write into notepad automatically is using "System.Windows.Forms.SendKeys.SendWait". But if the focus suddenly changes, e.g. a popup opens, an error message is thrown, ... the input is provided to the wrong application...
Because of that, this is not a stable way to automate gui applications.
But there are also advantages of the current API. For example compared to AutoIt it allows to access elements within an WPF element within an dotnet application. And it doesn't require an additional runtime, powershell/dotnet is enough
Tl;Dr: The current state is better than I initially was aware of, but it still needs some polishing.
Example code for automating notepad:
[void][System.Reflection.Assembly]::LoadWithPartialName("UIAutomationClient")
[void][System.Reflection.Assembly]::LoadWithPartialName("UIAutomationTypes")
[void][System.Reflection.Assembly]::LoadWithPartialName("UIAutomationProvider")
[void][System.Reflection.Assembly]::LoadWithPartialName("UIAutomationClientsideProviders")
[void][System.Reflection.Assembly]::LoadWithPartialName("System.Windows.Forms")

# According to the documentation this should be also called, but within powershell 7.1 it fails
# and within Windows Powershell (5.1) it is unstable and always throws an exception the first time it is called and succeeds the 2nd time...
# Also it doesn't seam to be needed for "just" automating notepad.
#$client = [System.Reflection.Assembly]::LoadWithPartialName("UIAutomationClientsideProviders")
#[Windows.Automation.ClientSettings]::RegisterClientSideProviderAssembly($client.GetName())

$autProc =  Start-Process notepad -PassThru
$rootElement = [Windows.Automation.AutomationElement]::RootElement
$condAUTProc = [Windows.Automation.PropertyCondition]::new([Windows.Automation.AutomationElement]::ProcessIdProperty, $autProc.Id)
$autElement = $rootElement.FindFirst([Windows.Automation.TreeScope]::Children, $condAUTProc)

# LocalizedControlTypeProperty is derived using "Accessibility Insights for Windows"
$documentElement = [Windows.Automation.PropertyCondition]::new([Windows.Automation.AutomationElement]::LocalizedControlTypeProperty, "document")
$document = $autElement.FindFirst([Windows.Automation.TreeScope]::Descendants, $documentElement)
$document.SetFocus()

[System.Windows.Forms.SendKeys]::SendWait("FooBar")

Same. We need official way for UI automation.

From the replies this got I think some clarification is needed. I also think I now understand what @vrapolinario meant with there already being an official way. There is: https://docs.microsoft.com/en-us/dotnet/framework/ui-automation
However the API is quite "limited" in some while being quite capable in other situations.
That API is not able to fake input to notepad without the window being onscreen and having focus.
This is because notepad requires "System.Windows.Automation.TextPattern" to be used instead of "System.Windows.Automation.ValuePattern" and that one does not offer a set text method (more about why that matters in the example at https://docs.microsoft.com/de-de/dotnet/framework/ui-automation/add-content-to-a-text-box-using-ui-automation).
Therefore the only way to write into notepad automatically is using "System.Windows.Forms.SendKeys.SendWait". But if the focus suddenly changes, e.g. a popup opens, an error message is thrown, ... the input is provided to the wrong application...
Because of that, this is not a stable way to automate gui applications.
But there are also advantages of the current API. For example compared to AutoIt it allows to access elements within an WPF element within an dotnet application. And it doesn't require an additional runtime, powershell/dotnet is enough
Tl;Dr: The current state is better than I initially was aware of, but it still needs some polishing.
Example code for automating notepad:
[void][System.Reflection.Assembly]::LoadWithPartialName("UIAutomationClient")
[void][System.Reflection.Assembly]::LoadWithPartialName("UIAutomationTypes")
[void][System.Reflection.Assembly]::LoadWithPartialName("UIAutomationProvider")
[void][System.Reflection.Assembly]::LoadWithPartialName("UIAutomationClientsideProviders")
[void][System.Reflection.Assembly]::LoadWithPartialName("System.Windows.Forms")

# According to the documentation this should be also called, but within powershell 7.1 it fails
# and within Windows Powershell (5.1) it is unstable and always throws an exception the first time it is called and succeeds the 2nd time...
# Also it doesn't seam to be needed for "just" automating notepad.
#$client = [System.Reflection.Assembly]::LoadWithPartialName("UIAutomationClientsideProviders")
#[Windows.Automation.ClientSettings]::RegisterClientSideProviderAssembly($client.GetName())

$autProc =  Start-Process notepad -PassThru
$rootElement = [Windows.Automation.AutomationElement]::RootElement
$condAUTProc = [Windows.Automation.PropertyCondition]::new([Windows.Automation.AutomationElement]::ProcessIdProperty, $autProc.Id)
$autElement = $rootElement.FindFirst([Windows.Automation.TreeScope]::Children, $condAUTProc)

# LocalizedControlTypeProperty is derived using "Accessibility Insights for Windows"
$documentElement = [Windows.Automation.PropertyCondition]::new([Windows.Automation.AutomationElement]::LocalizedControlTypeProperty, "document")
$document = $autElement.FindFirst([Windows.Automation.TreeScope]::Descendants, $documentElement)
$document.SetFocus()

[System.Windows.Forms.SendKeys]::SendWait("FooBar")

Thanks @agowa338 for the follow up. Can I recommend you provide the feedback directly to the documentation above. It might be the case that the team who owns it has not seen feedback on it for Windows Containers.
@slavanap apologies for the delay. Does this helps with your case as well?

Thanks @agowa338 for the follow up. Can I recommend you provide the feedback directly to the documentation above. It might be the case that the team who owns it has not seen feedback on it for Windows Containers.
@slavanap apologies for the delay. Does this helps with your case as well?

Does
https://github.com/microsoft/WinAppDriver
work in containers? Because if not then the suggested approach requires manual walkthrough and tinkering of every step, and doesn't support steps recording.

Does
https://github.com/microsoft/WinAppDriver
work in containers? Because if not then the suggested approach requires manual walkthrough and tinkering of every step, and doesn't support steps recording.

There's an issue on that repo: https://github.com/microsoft/WinAppDriver/issues/1046 covering exactly that. While that tool appears not to work on Windows Containers as it depends on an active desktop session, there are alternatives in there.
I went ahead and opened an issue on their repo to add support for Windows Containers. Please remember this is a different team and we don't own their prioritization. We'll definitely work together if needed, though.

There's an issue on that repo: https://github.com/microsoft/WinAppDriver/issues/1046 covering exactly that. While that tool appears not to work on Windows Containers as it depends on an active desktop session, there are alternatives in there.
I went ahead and opened an issue on their repo to add support for Windows Containers. Please remember this is a different team and we don't own their prioritization. We'll definitely work together if needed, though.

The general issue with UI automation is that

app installation,
app startup sequence,
app shutdown sequence
do involve iteration with GUI, although these legacy apps run as a backend service, they require interactions with GUI to get launched.

Also, for such apps state monitoring like an ability to take a screenshot would be really useful.

The general issue with UI automation is that

app installation,
app startup sequence,
app shutdown sequence
do involve iteration with GUI, although these legacy apps run as a backend service, they require interactions with GUI to get launched.

Also, for such apps state monitoring like an ability to take a screenshot would be really useful.

UI automation appears to not work at all when I try using windows:1909 and TestStack.White.
After opening notepad.exe and using the underlying System.Windows.Automation, I don't see any children under the root element (Desktop). IE, the following prints nothing:
using System.Windows.Automation;
...
var lWalker = new TreeWalker( Condition.TrueCondition );
var lElement = lWalker.GetFirstChild( AutomationElement.RootElement );
while ( lElement != null )
{
    Console.Out.WriteLine( $"{lElement.GetType().Name} {lElement.Current.Name} {lElement.Current.ProcessId} {lElement.Current.BoundingRectangle}" );
    lElement = lWalker.GetNextSibling( lElement );
}

UI automation appears to not work at all when I try using windows:1909 and TestStack.White.
After opening notepad.exe and using the underlying System.Windows.Automation, I don't see any children under the root element (Desktop). IE, the following prints nothing:
using System.Windows.Automation;
...
var lWalker = new TreeWalker( Condition.TrueCondition );
var lElement = lWalker.GetFirstChild( AutomationElement.RootElement );
while ( lElement != null )
{
    Console.Out.WriteLine( $"{lElement.GetType().Name} {lElement.Current.Name} {lElement.Current.ProcessId} {lElement.Current.BoundingRectangle}" );
    lElement = lWalker.GetNextSibling( lElement );
}

The Get-Process Notepad | ? MainWindowTitle -ne "" | Select MainWindowTitle Powershell command mentioned as working with windows:1809 in another thread no longer works with windows:1909.
What we could really use is a way to run multiple copies of Windows Sandbox as part of our CI. Why can't we use that as a Docker base? That also doesn't require a 6GB download/17GB image.

The Get-Process Notepad | ? MainWindowTitle -ne "" | Select MainWindowTitle Powershell command mentioned as working with windows:1809 in another thread no longer works with windows:1909.
What we could really use is a way to run multiple copies of Windows Sandbox as part of our CI. Why can't we use that as a Docker base? That also doesn't require a 6GB download/17GB image.

Thanks @agowa338 for the follow up. Can I recommend you provide the feedback directly to the documentation above. It might be the case that the team who owns it has not seen feedback on it for Windows Containers.

The team apparently doesn't accept feedback. There isn't "provide feedback" at the bottom of the page as other docs pages have...

Thanks @agowa338 for the follow up. Can I recommend you provide the feedback directly to the documentation above. It might be the case that the team who owns it has not seen feedback on it for Windows Containers.

The team apparently doesn't accept feedback. There isn't "provide feedback" at the bottom of the page as other docs pages have...

Than can I recommend you provide the feedback directly at their repo? Here's the URL: https://github.com/microsoft/dotnet.

Than can I recommend you provide the feedback directly at their repo? Here's the URL: https://github.com/microsoft/dotnet.

Is it right that UI automation of legacy apps for Windows Containers infrastructure is not a priority for dev team right now?

We made some progress on this with the Windows image that has a larger set of APIs available. Other than that, it seems the request is for tools that perform automation of UI tests need to support its own deployment on Windows containers. This unfortunately is out of our scope on the platform.

@vrapolinario There appears to be negative progress on the Windows image that had a larger set of APIs available. From reading here, things that used to work in 1809 containers (like getting the main window title) no longer work in 1909 containers.
What we could really use is containers based on Windows Sandbox. But Microsoft puts artificial restrictions on that (along with the artificial licensing restrictions on normal Windows sessions) that makes it very very difficult to perform Windows Desktop UI automated testing.

Adding @weijuans-msft for visibility.
Can't speak for the Sandbox option. We do want to address this scenario and we're looking into it, but no timeline at this point.
We'll update this issue once we have more to share.

@vrapolinario re large set of APIs, is it now possible to take a screenshot of an running app under in a Windows Container? If not, when will it be available?

I'm not aware of a PowerShell option (or cmd for that matter) to take a screenshot, so I'm assuming it's not possible.

Folks, after some internal investigation I'm getting the conclusion that we don't have a better answer at this point on UI automation, other than the APIs we provide on the Windows image. Since this seems to be a hot topic, I wanted to comment here and let you know that this is something we're taking in consideration as we evaluate new capabilities for Windows containers. Thanks for your input so far.
We'll close this issue for now, but please rest assured the inputs from this thread will feed our investments on upcoming releases.

Thanks for this. Please let us know if there is any roadmap

update?

Hi @vrapolinario, any update on this? it's been 6+ months since you were last active in this thread.

Hey everyone, the Windows containers product team is still monitoring this issue. I am reopening the issue to keep for tracking the feature request, but there are no new updates to provide--it is still sitting on our backlog. If/when we do have an update, we will post it here or you can monitor the Windows container blog.

Up

At this time, we don't have any plan to support. Close it for now. Can reopen if this is changed.

@weijuans-msft, with all the respect it's not completed, it is failed.

Can you offer an explanation as to why this use case is not supported? Its literally one of the most useful features of containers.  UI testing is a giant chore using VMs. Clearly all the code to make it work already exists (e.g. windows sandbox) and this is a totally artificial software imposed limit.


bind/unbind method not found on AEM 6.1

I got the following error when the com.adobe.acs.acs-aem-commons-bundle was activated.
24.08.2016 22:04:19.746 *INFO* [qtp782094611-821] com.adobe.acs.acs-aem-commons-bundle Service [com.adobe.acs.commons.workflow.process.impl.ParameterizedActivatePageProcess,7285, [com.day.cq.workflow.exec.WorkflowProcess]] ServiceEvent REGISTERED
24.08.2016 22:04:19.747 *ERROR* [qtp782094611-821] com.adobe.acs.acs-aem-commons-bundle [com.adobe.acs.commons.workflow.process.impl.ParameterizedActivatePageProcess(3816)] bind method [bindWcmWfService] not found; Component will fail
24.08.2016 22:04:19.747 *ERROR* [qtp782094611-821] com.adobe.acs.acs-aem-commons-bundle [com.adobe.acs.commons.workflow.process.impl.ParameterizedActivatePageProcess(3816)] bind method [bindWfService] not found; Component will fail
24.08.2016 22:04:19.748 *ERROR* [qtp782094611-821] com.adobe.acs.acs-aem-commons-bundle [com.adobe.acs.commons.workflow.process.impl.ParameterizedActivatePageProcess(3816)] bind method [bindRcManager] not found; Component will fail
24.08.2016 22:04:19.748 *ERROR* [qtp782094611-821] com.adobe.acs.acs-aem-commons-bundle [com.adobe.acs.commons.workflow.process.impl.ParameterizedActivatePageProcess(3816)] bind method [bindWcmWfService] not found
24.08.2016 22:04:19.748 *ERROR* [qtp782094611-821] com.adobe.acs.acs-aem-commons-bundle [com.adobe.acs.commons.workflow.process.impl.ParameterizedActivatePageProcess(3816)] bind method [bindWfService] not found
24.08.2016 22:04:19.748 *ERROR* [qtp782094611-821] com.adobe.acs.acs-aem-commons-bundle [com.adobe.acs.commons.workflow.process.impl.ParameterizedActivatePageProcess(3816)] bind method [bindRcManager] not found
24.08.2016 22:04:19.755 *INFO* [qtp782094611-821] com.adobe.acs.acs-aem-commons-bundle Service [com.adobe.acs.commons.workflow.process.impl.ParameterizedDeactivatePageProcess,7286, [com.day.cq.workflow.exec.WorkflowProcess]] ServiceEvent REGISTERED
24.08.2016 22:04:19.756 *ERROR* [qtp782094611-821] com.adobe.acs.acs-aem-commons-bundle [com.adobe.acs.commons.workflow.process.impl.ParameterizedDeactivatePageProcess(3817)] bind method [bindWcmWfService] not found; Component will fail
24.08.2016 22:04:19.757 *ERROR* [qtp782094611-821] com.adobe.acs.acs-aem-commons-bundle [com.adobe.acs.commons.workflow.process.impl.ParameterizedDeactivatePageProcess(3817)] bind method [bindWfService] not found; Component will fail
24.08.2016 22:04:19.757 *ERROR* [qtp782094611-821] com.adobe.acs.acs-aem-commons-bundle [com.adobe.acs.commons.workflow.process.impl.ParameterizedDeactivatePageProcess(3817)] bind method [bindRcManager] not found; Component will fail
24.08.2016 22:04:19.757 *ERROR* [qtp782094611-821] com.adobe.acs.acs-aem-commons-bundle [com.adobe.acs.commons.workflow.process.impl.ParameterizedDeactivatePageProcess(3817)] bind method [bindWcmWfService] not found
24.08.2016 22:04:19.758 *ERROR* [qtp782094611-821] com.adobe.acs.acs-aem-commons-bundle [com.adobe.acs.commons.workflow.process.impl.ParameterizedDeactivatePageProcess(3817)] bind method [bindWfService] not found
24.08.2016 22:04:19.758 *ERROR* [qtp782094611-821] com.adobe.acs.acs-aem-commons-bundle [com.adobe.acs.commons.workflow.process.impl.ParameterizedDeactivatePageProcess(3817)] bind method [bindRcManager] not found

I downloaded the acs-aem-commons-content-2.6.6-min.zip from the below page and installed it using package manager.
https://github.com/Adobe-Consulting-Services/acs-aem-commons/releases
Environments:

ACS AEM Commons Version : 2.1.2
AEM 6.1 SP1

I can confirm this for AEM 6.0 as well

Hi,
Anyone knows how to solve this error. I am facing the same issue in my project. The code of project is in 5.6 and migrated to 6.1 and using the latest acs-commons pacakge (2.8.0).
Thanks in advance.

Does this manifest itself in any way other than the log messages? i.e. are those workflow processes actually non-functional? I don't think this issue is particularly simple to address on the 6.0/6.1 branch.

@justinedelson, i am not sure about which workflow you were mentioning. I have checked in the workflow management for the below workflows and i am not able to find them. Can you please let me know about those in detail?
Workflows:
com.adobe.acs.commons.workflow.process.impl.ParameterizedActivatePageProcess
com.adobe.acs.commons.workflow.process.impl.ParameterizedDeactivatePageProcess

@KiranVedantam I was referring to the workflow processes in the error message. What kind of details are you looking for?

@justinedelson I am wanting to know why is the error visible in the log files. Can we ignore this? until and unless we leverage ParameterizedActivatePageProcess related workflow I feel it will not impact your implementation. Am I right?

I would also like to have an answer on this one, having the same problems on an AEM 6.1 SP2

@royteeuwen is this happening on a "vanilla" 6.1 + SP2? Are you installing anything else?

Hey @davidjgonzalez ,
I just started a new aem 6.1 quickstart jar, installed SP2 and then CFP4 and then the acs-aem-commons-content 2.9.0 and yup,  I still get the following error:
[com.adobe.acs.commons.workflow.process.impl.ParameterizedDeactivatePageProcess(2272)] bind method [bindWcmWfService] not found; Component will fail
[com.adobe.acs.commons.workflow.process.impl.ParameterizedDeactivatePageProcess(2272)] bind method [bindWfService] not found; Component will fail
[com.adobe.acs.commons.workflow.process.impl.ParameterizedDeactivatePageProcess(2272)] bind method [bindRcManager] not found; Component will fail
[com.adobe.acs.commons.workflow.process.impl.ParameterizedDeactivatePageProcess(2272)] bind method [bindWcmWfService] not found
[com.adobe.acs.commons.workflow.process.impl.ParameterizedDeactivatePageProcess(2272)] bind method [bindWfService] not found
[com.adobe.acs.commons.workflow.process.impl.ParameterizedDeactivatePageProcess(2272)] bind method [bindRcManager] not found
[com.adobe.acs.commons.workflow.process.impl.ParameterizedActivatePageProcess(2304)] bind method [bindWcmWfService] not found; Component will fail
[com.adobe.acs.commons.workflow.process.impl.ParameterizedActivatePageProcess(2304)] bind method [bindWfService] not found; Component will fail
[com.adobe.acs.commons.workflow.process.impl.ParameterizedActivatePageProcess(2304)] bind method [bindRcManager] not found; Component will fail
[com.adobe.acs.commons.workflow.process.impl.ParameterizedActivatePageProcess(2304)] bind method [bindWcmWfService] not found
[com.adobe.acs.commons.workflow.process.impl.ParameterizedActivatePageProcess(2304)] bind method [bindWfService] not found
[com.adobe.acs.commons.workflow.process.impl.ParameterizedActivatePageProcess(2304)] bind method [bindRcManager] not found

Greets,
Roy

My initial analysis is that this issue is not fixable without entirely rewriting these components. Note - this problem is specific to 6.1. It does not happen with the 6.2 branch.

Hey Justin,
Ok no problem, can you clarify why this is resolved in AEM 6.2? What is causing the issue?
Greets
Roy

On 21 Jan 2017, at 14:36, justinedelson<EMAIL_ADDRESS>wrote:
My initial analysis is that this issue is not fixable without entirely rewriting these components. Note - this problem is specific to 6.1. It does not happen with the 6.2 branch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/784#issuecomment-274262204, or mute the thread https://github.com/notifications/unsubscribe-auth/AEvNTpcTjtvif7AuQY016DQqi_vWV7j8ks5rUgn4gaJpZM4Jr_i2.

The problem is that these components extend SCR components from AEM and the injected references into the base components changed between 6.0 and 6.1. The master branch of this project is built against the 6.0 UberJar, so it only knows about the injected references from 6.0.
For the 6.2 branch, we build against the 6.2 UberJar, so this is not an issue there. As far as I can tell, this will not be an issue for 6.3 either.
Long term, if our objective is to be cross-compatible between releases we should probably get rid of all cases where SCR components are extended since the injected references are not currently considered to be part of the API and so are free to change between releases (or even service packs/CFPs).

i assume the problem comes from extending the OOTB De/ActivatePageProcesses?
Would a simple fix me to swap out
super.execute(workItem, workflowSession, args);
with
@Reference(target=<pid>)
private WorkflowProcess workflowProcess;
...
workflowProcess.execute(workItem, workflowSession, args);

Seems like a simple fix?

That does indeed look like a simple temp solution for the AEM 6.1 branch :). And indeed, extending an OOTB component maybe should be avoided

Oh - i guess that won't work..  the problem being:
   @Override
    protected ReplicationOptions prepareOptions(ReplicationOptions opts) {

@davidjgonzalez I don't think that will work. The whole point is to be able to customize the agent filter which gets created inside the execute method of the base class.

Yup .. ^^^

Okey no problem, I'll wait another 2 months for the upgrade to 6.2 ;).

Op 21 jan. 2017 om 18:21 heeft david g<EMAIL_ADDRESS>het volgende geschreven:
Yup .. ^^^
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Is it okay to ignore the bind/unbind error if we are using AEM 6.1 and can still use ACS commons on a PROD instance? We are planning to upgrade to 6.3 early next year, but want to use ACS commons in PROD in meantime.

@ssga-aem as far as I know, this only impacts these two components. If you don't use them (and you apparently can't on 6.1), then it doesn't affect you.

I hate to do this because this is an annoying bug, but I'm making this as wontfix and closing it. If someone wants to come up with a clever solution which works across 6.0 & 6.1, please reopen.


Open Source License

I wanted to bring to your attention the fact that keras-ocr does not have an open source license attached to it. This means that it is unclear to users what they are and are not allowed to do with the code.
As an open source project, it is important that we make it easy for others to understand how they can use, modify, and distribute our code. Without a license, potential contributors may be hesitant to contribute to the project, and it may be unclear to others how they can legally use our code.
I would like to request that we add an open source license to the repository as soon as possible. This will help us to build a strong and healthy community around our project.
There are many open source licenses to choose from, and I would be happy to help with selecting and adding the appropriate license if needed. Here are a few common options:
MIT License
Apache License 2.0
GNU General Public License (GPL)
Thank you for your consideration, and I look forward to seeing the project thrive with the addition of an open source license.

Apologies. I see that it has an MIT license.  Issue resolved.


Set up webhook deployment

[x] Write deployment script
[x] Auth with GitHub
[ ] Finalize Hook JSON

References
Use https://github.com/le717/codetri-webhook as the webhook processor

Not happening.


Diff for comparison with upstream

It's usually better to target PRs against develop.

It's usually better to target PRs against develop.

Yeah, I have no intention of actually merging this, I just wanted a pretty diff against the current master release

It's usually better to target PRs against develop.

Yeah, I have no intention of actually merging this, I just wanted a pretty diff against the current master release

Ok sorry if I'm missing something here, just trying to help.
I think the plan for deploying your changes is to merge your branch into develop, then merge develop into master. Right now develop is 19 commits ahead of master. So you probably want to make sure develop is merged into your branch, and then the most helpful nice diff to look at would be between develop and your branch. But feel free to forget all this if you have some other arrangement with @marinagmoreira.

can we close this since the fsw release was done?


Fix scenario yaml files

When testing #143 with the scenarios from FlexMex1 I found differences in some of the scenario yaml files (introduced with #136):

scenario names in 2c, 2d (typo)
wrong component lists in 2c, 2d, 5, 7b

I derived the correct versions from the preprocessing script files in 0f3212ad.

First commit was not complete, so I reverted and repeated it.

First commit was not complete, so I reverted and repeated it.

Once again I missed something... :man_facepalming:

Once again I missed something... :man_facepalming:

Checked preprocessing results against my local defaults. Can be merged.

Checked preprocessing results against my local defaults. Can be merged.


Improve cross-panel interactions

[ ] “Home” search box: make Language group headings linkable to “/Explore/Language/Language Name”. If this starts looking hard, jump ship. Was just a minor request.
[ ] Add a toggle near the Census search box to turn off language points using the same functionality as ~“Show by: None”~ turning on "Hide points and icons" in the Home panel ~symbology dropdown~.

@rperlin-ela for the ELA data toggle in Census, which of these options seems better?

Instead of a toggle, use a button saying "Hide ELA data" or whatever. If either the ELA points or labels (or both) are visible, the button is enabled, otherwise disabled since the ELA stuff is already hidden.
A toggle as described in the issue above. The toggle's enabled/disabled state would be determined in the same way as the button option.

To me Option 1 feels more natural and follows the same thinking as the "Show in map" of the Census popout: if that census language is already selected, the button is disabled.

Nice. By “otherwise diasbled since the ELA stuff is already hidden”, I assume you mean someone has doine “Hide points and icons” on Home and there are no labels.
If you think button over toggle, let’s do that. I didn’t see this thing as necessarily being in the pop-out, only in the more spacious Census panel, if that makes any difference.

On Mar 17, 2021, at 11:14 AM, Jason Lampel @.***> wrote:
@rperlin-ela https://github.com/rperlin-ela for the ELA data toggle in Census, which of these options seems better?
Instead of a toggle, use a button saying "Hide ELA data" or whatever. If either the ELA points or labels (or both) are visible, the button is enabled, otherwise disabled since the ELA stuff is already hidden.
A toggle as described in the issue above. The toggle's enabled/disabled state would be determined in the same way as the button option.
To me Option 1 feels more natural and follows the same thinking as the "Show in map" of the Census popout: if that census language is already selected, the button is disabled.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/195#issuecomment-801165824, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5A5ODZKZ3XMYFYL3PDTEDBNRANCNFSM4ZEFDSHA.

Actually it does need to be a toggle because if the user clicks a button which becomes disabled after click and then changes their mind, they won't be able to undo their last action without going to the Home panel, and they may not even know about the functionality there in the first place. So yes to original toggle suggestion. ￼

By “otherwise diasbled since the ELA stuff is already hidden”, I assume you mean someone has doine “Hide points and icons” on Home and there are no labels.

Correct. Although now that I think of it we are going to need a checkbox in Home to show/hide labels just like we're doing with the points. Otherwise the "hide all ela data" switch won't know what "Label by" value to restore (Language or Endo) when "hide ela..." is turned back off and showing labels.
There should be plenty of room for the labels toggle in Home, either through minimal text and/or foregoing my "elevated" group in Home. I also like the consistency with the show/hide points toggle. The None stuff probably never should have gone into dropdowns anyway. Bad Jason!
Don't worry if the logic doesn't make sense, I just need an all-clear from you to add that extra checkbox for labels and remove it from the Label By dropdown. ￼

Oh and yes to the panel-only census inclusion for the ELA data toggle, not the census popout.￼

Toggle called “Hide ELA data” in Census sounds good, and I hope it will help people keep straight what’s ELA and what’s census, though elsewhere we haven’t really flagged very clearly that it’s ELA data.
A “Hide labels” set to on, just under “Label by” and right of “Hide points and icons”, sounds like it should be good. Not sure how the dropdown would look by default, but it sounds like you’ve got idea. Whatever we can do to make this as intuitive as possible… To create a clearer parallel, what do you think about changing “Show by” to “Symbolize by” and changing “Hide points and icons” to “Hide symbols”?

On Mar 18, 2021, at 11:26 AM, Jason Lampel @.***> wrote:

Oh and yes to the panel-only census inclusion for the ELA data toggle, not the census popout.￼
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/195#issuecomment-802018787, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5AEO2VAAXYY2F4UKPTTEILQVANCNFSM4ZEFDSHA.

Johnny Minimal, in the house! Ha I can dig those changes, although I thought "symbolize" was too GIS-y to some? Fine by me though. I think "Display by" works too, but symbolize is most accurate and reinforces the "symbols" in "Hide symbols".

Not sure how the dropdown would look by default

It would just be Language, no? As for the initial state and text of "Hide Labels", which of these makes more sense?

"Hide Labels", switched on by default
"Show Labels", switched off by default

I could go either way. Part of me likes having both of those toggled off on load, but another part likes the consistent behavior and wording for both toggles.
Code-wise the logic might get a little screwy mixing it up like that, so unless you have strong feelings about "Show Labels", probably best to stay consistent w/Hide.

All good on this. I think I’d give the nod to the consistency of “Hide Labels”, and I guess still off by default

On Mar 18, 2021, at 1:22 PM, Jason Lampel @.***> wrote:
Johnny Minimal, in the house! Ha I can dig those changes, although I thought "symbolize" was too GIS-y to some? Fine by me though. I think "Display by" works too, but symbolize is most accurate and reinforces the "symbols" in "Hide symbols".
Not sure how the dropdown would look by default
It would just be Language, no? As for the initial state and text of "Hide Labels", which of these makes more sense?
"Hide Labels", switched on by default
"Show Labels", switched off by default
I could go either way. Part of me likes having both of those toggled off on load, but another part likes the consistent behavior and wording for both toggles.
Code-wise the logic might get a little screwy mixing it up like that, so unless you have strong feelings about "Show Labels", probably best to stay consistent w/Hide.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/195#issuecomment-802141785, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5EESBNXSGNAA3HQE3DTEIZEVANCNFSM4ZEFDSHA.

Omni part was a piece of cake. Want it like this:

Or bold with more char spacing?

or larger font

underline

some kind of little char or icon

IMO they all suck in different ways but i'd lean towards the first option or the second.

*sorry, the third: larger font

yeah that one, larger font!

On Mar 19, 2021, at 11:45 AM, Jason Lampel @.***> wrote:
*sorry, the third: larger font
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/195#issuecomment-802926881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5HNTLVX2MA26CA3KO3TENWQFANCNFSM4ZEFDSHA.

k well i spoke too soon about piece of cake. the functionality/linkage is fine, and so is the font, but... i can't get it to stay "sticky". you know how when you scroll, the language heading "sticks" to the top until you get to the next one? that.
anyway got over an hour into that (an hour and two minutes since i posted the screenshot of it working) so gonna have to circle back later if it's a deal-breaker. i like "sticky" but it's not overly useful here since many of the languages only have one location. plus it's only really noticeable if you're scrolling aimlessly versus actually typing something deliberate in the box (which is the main point of it).
i could see arguments for non-sticky too, like it saves space, so i'm fine without sticky if you are, just don't want to rob you of any existing features!

jeez Louise. sticky isn't working in prod anyway so nevermind. disregard, captain!

Ok I knocked out both of the tasks but I can see convos about the census one getting hairy, so here's my take (and @fiddleHeads feel free to weigh in. i'm not sure if you were the requestor on this one but we won't turn down a third voice either way)...
The main problem is that hitting this switch:

...heavy-handedly turns the points and labels on or off regardless of the previous state. Example scenario:

user has Endo's on but points off
goes to Census panel
switch is turned off since labels are shown
user clicks switch. labels and points both hidden like we'd expect.
user clicks again, but now both the labels AND points are shown

rather than go down the road of keeping track of whether or not the points and labels were already hidden or shown in the Home panel, can we just adjust the wording of the toggle in the Census panel to reflect what the switch does? it's semi-confusing as it is, especially if user isn't aware of the show/hide toggles in Home. Maya if you're not in the loop we have added these to Home:

in my experience with UI pieces that affect other UI pieces without the user's knowledge, while well-intended the costs of convoluted code are greater than the benefits to the user. i knew there would be some implications when i started thinking through the UI process, but i don't want to make it more complex than it needs to be since it's kind of a bonus feature anyway (the user can already toggle the stuff in Home).
to make it simpler for them, i suggest one or a combo of these:

change the wording of the text to say bluntly that it turns stuff on or off regardless of what was set before. this could be via one of those ℹ  buttons or directly in the text
if it makes it easier, include a link to Home like  More options or something:

change the wording of the toggle dynamically:

I pushed a deploy so let me know how it "feels": https://deploy-preview-201--languagemapping.netlify.app/

I get the problem, and this is a good way of thinking about it, but I’m checking the deploy… and it seems great, like the thing remembers what I went in with. Could that be, or am not I getting? I’ve tried it with World Region, Size, Status, and different labels, and when I slide the new Census toggle back and forth it seems to go back fine to what I just had. With filters too! It’s just what I would expect as a user.
For the text I’d go with “Hide ELA symbols and labels”. I still feel we could use a line or something somewhere besides Help clarifying what’s ELA data vs. Census data. Maybe you won’t mind me slipping that in somewhere when we give Census its own beautiful panel...

On Mar 19, 2021, at 3:02 PM, Jason Lampel @.***> wrote:
Ok I knocked out both of the tasks but I can see convos about the census one getting hairy, so here's my take (and @fiddleHeads https://github.com/fiddleHeads feel free to weigh in. i'm not sure if you were the requestor on this one but we won't turn down a third voice either way)...
The main problem is that hitting this switch:
https://user-images.githubusercontent.com/4974087/111828333-c1ae9d80-88b0-11eb-8a9c-7a0eea0b22aa.png
...heavy-handedly turns the points and labels on or off regardless of the previous state. Example scenario:
user has Endo's on but points off
goes to Census panel
switch is turned off since labels are shown
user clicks switch. labels and points both hidden like we'd expect.
user clicks again, but now both the labels AND points are shown
rather than go down the road of keeping track of whether or not the points and labels were already hidden or shown in the Home panel, can we just adjust the wording of the toggle in the Census panel to reflect what the switch does? it's semi-confusing as it is, especially if user isn't aware of the show/hide toggles in Home. Maya if you're not in the loop we have added these to Home:
https://user-images.githubusercontent.com/4974087/111828792-6f21b100-88b1-11eb-92e0-5f6569da6ce0.png
in my experience with UI pieces that affect other UI pieces without the user's knowledge, while well-intended the costs of convoluted code are greater than the benefits to the user. i knew there would be some implications when i started thinking through the UI process, but i don't want to make it more complex than it needs to be since it's kind of a bonus feature anyway (the user can already toggle the stuff in Home).
to make it simpler for them, i suggest one or a combo of these:
change the wording of the text to say bluntly that it turns stuff on or off regardless of what was set before. this could be via one of those ℹ buttons or directly in the text
if it makes it easier, include a link to Home like More options or something:
https://user-images.githubusercontent.com/4974087/111830230-48647a00-88b3-11eb-92a2-07dfcd75d732.png
change the wording of the toggle dynamically:
https://user-images.githubusercontent.com/4974087/111829662-962cb280-88b2-11eb-95eb-6572ebc26f68.png
https://user-images.githubusercontent.com/4974087/111829621-890fc380-88b2-11eb-8da1-adca407eaea7.png
I pushed a deploy so let me know how it "feels": https://deploy-preview-201--languagemapping.netlify.app/ https://deploy-preview-201--languagemapping.netlify.app/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/195#issuecomment-803047529, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5FPHU2MJJUY6PJSHATTEONUJANCNFSM4ZEFDSHA.

Hide ELA symbols and labels

oops, good catch!
as much as i'd like to say we've got this issue in the bag, i don't think you tried the scenario i mentioned above (the 1-5 steps), or maybe it's not a concern but i'm guessing the former so i'll break it down:
defaults, on load:

and when i turn this on, it hides everything as expected:

however, when i turn it back off:

it's now showing the labels:

either way, i'm going to throw this in the "circle back later" pile (if you didn't catch it through your testing so far) and knock out #196 . if/when it starts to become a problem, i'm thinking i could just have an additional property in the code to "override" the current state of the two Home toggles, although that might be a different kind of confusing code-wise. i'll have to think on it.

Maybe you won’t mind me slipping that in somewhere when we give Census its own beautiful panel...

i think that falls closely enough into the ol' Census panel task. If you let me know what the text is in a new GH issue which also includes the SOW details about the Census panel task, you've got yourself a deal. ;)
on a related note i was wondering if this:

could use the slim version as in the popout:

or perhaps the 3-line truncation w/ellipsis i mentioned for Read More yesterday. that could get confusing w/the existing More info link though. or maybe it won't be an issue with all the newfound space of dedicated Census panel real estate.

Got it, was moving a little quick. Now I think I see: it does fine with everything except that it turns on the labels even if you had them off (by default or otherwise). That’s not too bad, and seems ok to think on and return to.
Sounds good about Census panel text. Yeah the slim version seems fine and that’ll help squeeze in a touch more about ELA data.

On Mar 19, 2021, at 4:07 PM, Jason Lampel @.***> wrote:
Hide ELA symbols and labels
oops, good catch!
as much as i'd like to say we've got this issue in the bag, i don't think you tried the scenario i mentioned above (the 1-5 steps), or maybe it's not a concern but i'm guessing the former so i'll break it down:
defaults, on load:
https://user-images.githubusercontent.com/4974087/111835760-f9224780-88ba-11eb-9bc4-d70fad5040dc.png
https://user-images.githubusercontent.com/4974087/111835779-00e1ec00-88bb-11eb-9a1f-1501abfb6d09.png
and when i turn this on, it hides everything as expected:
https://user-images.githubusercontent.com/4974087/111835824-11926200-88bb-11eb-9ae9-dddaad9ce85a.png
however, when i turn it back off:
https://user-images.githubusercontent.com/4974087/111835779-00e1ec00-88bb-11eb-9a1f-1501abfb6d09.png
it's now showing the labels:
https://user-images.githubusercontent.com/4974087/111835916-338be480-88bb-11eb-9761-0a816bf8cf0c.png
either way, i'm going to throw this in the "circle back later" pile (if you didn't catch it through your testing so far) and knock out #196 https://github.com/Language-Mapping/language-map/issues/196 . if/when it starts to become a problem, i'm thinking i could just have an additional property in the code to "override" the current state of the two Home toggles, although that might be a different kind of confusing code-wise. i'll have to think on it.
Maybe you won’t mind me slipping that in somewhere when we give Census its own beautiful panel...
i think that falls closely enough into the ol' Census panel task. If you let me know what the text is in a new GH issue which also includes the SOW details about the Census panel task, you've got yourself a deal. ;)
on a related note i was wondering if this:
https://user-images.githubusercontent.com/4974087/111836536-11df2d00-88bc-11eb-916a-2453f0139a75.png
could use the slim version as in the popout:
https://user-images.githubusercontent.com/4974087/111836598-2cb1a180-88bc-11eb-9177-2ba2c7516b1a.png
or perhaps the 3-line truncation w/ellipsis i mentioned for Read More yesterday. that could get confusing w/the existing More info link though. or maybe it won't be an issue with all the newfound space of dedicated Census panel real estate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/195#issuecomment-803090147, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5BGU6JOUUP2TFQUWOTTEOVG7ANCNFSM4ZEFDSHA.

except that it turns on the labels even if you had them off (by default or otherwise)

right and same goes for symbols.
i also could see the accidentally-forced-on labels as a happy accident. like "whoa cool didn't know i could do that" if the user hadn't played with the Label By dropdown yet.

Just catching up here and agree it doesn't seem too bad that the labels turn on even when they were previously off and could perhaps even be a neat surprise.
I also think the slim version for the Census panel text seems fine.


Provide and standardize use of builtin compiler functions

Modern compilers have a set of builtin compiler functions that can be availed of to optimize code (speed and code size).
Nim does a good job of this for some of them, as shown at the following links.
https://github.com/nim-lang/Nim/blob/devel/lib/pure/bitops.nim
https://github.com/nim-lang/Nim/blob/master/lib/pure/math.nim#L103
It would nice for Crystal to provide these same type of optimizations for standard methods that use them.
I have an immediate use for countOfTrailingZeroes and popcount.

popcount is present already:
https://crystal-lang.org/api/0.27.2/Int.html#popcount-instance-method
count of trailing \ leading zeros intrinsics aren't present though and doesn't work even when called as intrinsics: https://carc.in/#/r/6fps

@konovod It works if you use the correct signatures: https://carc.in/#/r/6fqi
Be sure to check the signature in LLVM's Reference Docs: https://llvm.org/docs/LangRef.html#llvm-ctlz-intrinsic

Interesting! I didn't know anything about an intrinsics lib (I found no docs on them).
But the code given from the site only works for 32 or 64 bit integers (I tried them on bitint values too).
What is desirable for me (as an application programmer, and not language developer) is having in the API method names to perform these functions which will work with any integer type (including arbitrary size). This probably means, like in the Nim code, having different implementations that are applicable to the appropriate use case.

@asterite my bad! I was looking at docs but somehow missed a parameter. 😄
@jzakiya #popcount is already implemented for all Int and BigInt too.
Looks like the only thing missing is a countTrailingZeroes - perhaps issue could be renamed to reflect it.
LibGMP have  mpz_scan1 that implements it, so if you really need it you can import it directly.
https://carc.in/#/r/6fvk
But adding it to standard library can be discussed.

I renamed the issue.
We won't expose LLVM intrinsics publicly. Proper methods should be created on the (big) integer types to implement the feature, if accepted. It's a simple addition, given the two available carc.in examples above.

I marked this with the community:newcomer issue.
For trailing zeros we can probably use the names trailing_zeros_count and leading_zeros_count, unless someone has a better idea.

@asterite Should they be defined on Number as abstract, similarly to Number#popcount?

I'm not sure. Maybe that abstract thing was a mistake because I don't know if these can be implemented for all numeric types (isn't it just in Int?)

(isn't it just in Int?)

My bad, it is! I dunno why but for some reason I thought I've seen it in inside Number.

I think it's fine then. The only subclass of Int we have is BigInt and I doubt others extend it. That's why I'm not sure those abstract methods serve any real purpose (we can later remove it).

Thanks to all for these new methods. :-)

@konovod Any idea how to return leading_zeros_count for BigInt? I haven't found any function for that in GMP.


FRO and project page creation: add more clarifying description to the language step

During FRO profile and project creation process on the language step, provide a clear description that these are the languages that FRO needs to provide translations for. Currently it is assumed that the website or the service organization will provide those translations.
You can replace the current description of "You can add different language translations to your project. If you pick a language here, you will have to add the translation yourself in the following pages" with something clearer like "Please select the languages that your organization is able to translate this page/project to"  .

https://www.figma.com/file/AXufBnFAVHvGdsxnQMVhNF/The-Accessibility-Exchange-Wireframes?node-id=1297%3A18818

updated copy.


Various enhancements

Env defaulting to first env of the envs list
Allowing for chaining after setEnvs

:+1:


Insufficient clarity about calling an instance from JS

This document is very confusing for me as a C# developer who left JavaScript behind 10 years ago.
Could use a section describing how DotNetObjectReference could be used to pass an instance of a Blazor component to JavaScript (and therefore make its methods available) - or pass an injected singleton, for example.
It was not obvious to me that .then is synonymous with .ContinueWith and .ContinueWith is not ideal in BlazorWASM. A more simple JavaScript example would be welcome, it looks like an attempt has been made to cram as many different use cases as possible into one example, and it reads like insanity - creating a whole class to be a DotNetObjectReference factory to then call JavaScript to call the object created in that factory, which is a separate class to any Blazor pages.
(In the real world, on Client-Side Blazor, I found it simplest to create a static method on the Blazor component and have that call a static Action which is set to the instance method I actually want to call by the component's OnInitialized method - which is great so long as I only have one instance of the Blazor component)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 49807900-0d56-e23c-1aef-d79099caeffb
Version Independent ID: feff434f-912c-0985-d575-4a23a629057d
Content: ASP.NET Core Blazor JavaScript interop
Content Source: aspnetcore/blazor/javascript-interop.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

https://github.com/aspnet/AspNetCore.Docs/issues/14972

@HughPH Are you re-opening a new issue with the same content as on #14972?

Close the other one if you're providing more/new information for the same issue.

Sorry ... didn't see that it was a different community member. I'll look and close it as a duplicate if that's the case.

I think they are associated but not duplicates of one another. Definitely worth looking at together.

Ok ... cool. Thanks.

Thanks for jumping on it so fast!

We should be getting a round of triage from engineering on all of these issues fairly soon. I don't have an ETA, but getting past the 3.0 release was a big milestone.

@mkArtakMSFT I'm taking a look at rolling this into the JS interop topic split updates today, which should be up for review by EOD or first thing Wednesday morning. Let's go over the pattern and discuss further. Consider this example for discussion ...
wwwroot/index.html:

Pages/MyTest.razor:
@page "/mytest"

My Test

    Message: @_message

    <button onclick="updateMessageCallerJS()">Do IT!</button>

@code {
    private static Action _action;
    private string _message = "Select the button.";

    protected override void OnInitialized()
    {
        _action = UpdateMessage;
    }

    private void UpdateMessage()
    {
        _message = "UpdateMessage Called!";
        StateHasChanged();
    }

    [JSInvokable]
    public static void UpdateMessageCaller()
    {
        _action.Invoke();
    }
}

Is this pattern acceptable/reasonable?
Name the gotchas (e.g., explain out a bit more "which is great so long as I only have one instance of the Blazor component").
Is this example (or one close to it, since I'll probably mod it a bit for the PR) fairly close to what you'd like to show?
Prioritize this pattern relative to the current coverage (links to 'Instance method call' section): Should this pattern be shown first (i.e., a new first bullet and example there)?

This is fairly easy to follow example to understand how to call a static method of a component to update UI, which is alright, as you pointed out, as long as is only component, but in case of list of same components there is no example so far.
I ran into that issue few times, regarding calling a promise and updating list item on complete of promise. I tried many ways including passing component as object DotNetObjectReference('this'). Every time it failed to update all the list items component but one. So I came up with this solution, which is hybrid of your code and Instance method call.
Maybe you can extend your example like this.
Index Page

Index Razor
@page "/"

List Items

    <InstanceCall.Pages.components.ListItemComponent></InstanceCall.Pages.components.ListItemComponent>
    <InstanceCall.Pages.components.ListItemComponent></InstanceCall.Pages.components.ListItemComponent>
    <InstanceCall.Pages.components.ListItemComponent></InstanceCall.Pages.components.ListItemComponent>
    <InstanceCall.Pages.components.ListItemComponent></InstanceCall.Pages.components.ListItemComponent>

ListItemComponent
@inject IJSRuntime JsRuntime

My Test List Item

    Message: @_message

    <button @onclick="@InteropCall">Do IT!</button>

@code {
    private static Action _action;
    private string _message = "Select the button.";

    MessageUpdateInvokeHelper messageUpdateInvokeHelper;

    protected override void OnInitialized()
    {
        _action = UpdateMessage;
        messageUpdateInvokeHelper = new MessageUpdateInvokeHelper(_action);
    }

    protected async Task InteropCall()
    {
        await JsRuntime.InvokeVoidAsync("Blazor31.updateMessageCallerJS", DotNetObjectReference.Create(messageUpdateInvokeHelper));
    }

    private void UpdateMessage()
    {
        _message = "UpdateMessage Called!";
        StateHasChanged();
    }

}

MessageUpdateInvokeHelper
public class MessageUpdateInvokeHelper
    {
        Action _action;

        public MessageUpdateInvokeHelper(Action _action)
        {
            this._action = _action;
        }

        [JSInvokable]
        public void UpdateMessageCaller()
        {
            _action.Invoke();
        }
    }

I find this case to be more common in cases of web development, such as waiting for promises or async JS calls results, image manipulation, or end of animation, so on.

I think that would be best as an extended example, shown after the simple one that I put up. Also, I'd update the example a bit. There isn't a list item for an ordered/unordered list in the example. It would be easy to make that into a list item example.
btw -- Note that you don't need the @ on the method now (i.e., @onclick="InteropCall").

Sounds great!


[Enhancement][TileLang] Introduce Pass LegalizeSafeMemoryAccess to auto protect memory access by Injecting IfThenElse Node

ref to issue #265 , This pull request introduces Pass  LegalizeSafeMemoryAccess
To address the need for auto-injection of if-then-else checks for out-of-bounds memory access in TileLang, we’ve implemented a new pass: tl.LegalizeSafeMemoryAccess. This pass is designed to analyze memory accesses within loops, identify potential out-of-bounds conditions, and automatically insert the appropriate if-then-else statements to guard such accesses.
Key Features of the Pass:

Global Memory Access Detection: The pass scans for BufferLoad and BufferStore operations targeting global memory and analyzes their access patterns.
Bounds Checking: It compares indices against the buffer’s shape dimensions and automatically generates conditions to ensure access safety.
Condition Injection: If the pass detects that a memory access could potentially be out of bounds, it wraps the loop body in the necessary if-then-else conditions to enforce valid access.
Leaf Loop Analysis: The pass only applies the transformations to loops that do not have inner loops, ensuring that it does not over-constrain the program unnecessarily.
Simplification-Ready Conditions: The generated conditions are compatible with downstream simplification passes, ensuring they are optimized efficiently.

Here’s an example of how the pass transforms a loop:
Input:
for i, j in T.Parallel(block_M, block_N):
    m, n = by * block_M + i, bx * block_N + j
    C[m, n] = C_shared[
        i // micro_size_x,
        j // micro_size_y,
        i % micro_size_x,
        j % micro_size_y,
    ]

Output (after the pass):
for i, j in T.Parallel(block_M, block_N):
    m, n = by * block_M + i, bx * block_N + j
    if m < M and n < N:
        C[m, n] = C_shared[
            i // micro_size_x,
            j // micro_size_y,
            i % micro_size_x,
            j % micro_size_y,
        ]

The injected condition ensures safe memory access by checking that m < M and n < N before accessing C[m, n].
How to Use the Pass
The pass can be applied as part of the TVM compilation pipeline by invoking tl.LegalizeSafeMemoryAccess. The registration of the pass allows it to be seamlessly integrated into existing workflows. For example:
    mod = tl.transform.LegalizeSafeMemoryAccess()(mod)
    # Inject Simplify to remove the duplicated conditions
    # which may be introduced by the LegalizeSafeMemoryAccess
    mod = tir.transform.Simplify()(mod)

This should address scenarios where loops access memory blocks with dimensions larger than the actual data, such as in the case of padding or tiling.

ops, Test Loop All Dynamic is failed.
Looks like we transformed ir:
A_shared[0, i * 4 + v // 32, v % 32 // 4 * 32 + (v % 32 // 16 + v % 4 // 2) % 2 * 16 + (v % 16 // 8 + v % 2) % 2 * 8 + vec_1] = T.if_then_else(by * 64 + i * 32 + v // 4 < m and k_1 * 32 + v % 4 * 8 < k, A[by * 64 + i * 32 + v // 4, k_1 * 32 + v % 4 * 8 + vec_1], T.float16(0))

into
if k_1 * 32 + v % 4 * 8 + vec_1 < k:
    if by * 64 + i * 32 + v // 4 < m:
        A_shared[0, i * 4 + v // 32, v % 32 // 4 * 32 + (v % 32 // 16 + v % 4 // 2) % 2 * 16 + (v % 16 // 8 + v % 2) % 2 * 8 + vec_1] = T.if_then_else(k_1 * 32 + v % 4 * 8 < k, A[by * 64 + i * 32 + v // 4, k_1 * 32 + v % 4 * 8 + vec_1], T.float16(0))

Which must be incorrect behavior, we should have an else node to set A_shared to zero instead of skip the BufferStoreNode.

Summarize current solution:

Traverse the final for node:

Rewrite each buffer store node with an if_then_else buffer load, unless storing to global memory (skip in this case).
If storing to shared memory from global memory, replace the store with zeros (shared memory might be uninitialized).
Rewrite each buffer call node with an if_then_else buffer load.

Detailed information please checkout Pass SafeMemoryLegalizer
// Class to legalize safe memory access by transforming them appropriately
class SafeMemoryLegalizer : IRMutatorWithAnalyzer {
 public:
  // Static method to substitute and transform the given PrimFunc
  static PrimFunc Substitute(PrimFunc f) {
    arith::Analyzer analyzer;
    // Create an instance of the legalizer with the analyzer
    SafeMemoryLegalizer substituter(&analyzer);
    // Get a mutable copy of the function node
    PrimFuncNode* fptr = f.CopyOnWrite();
    // Apply the legalizer to the function body
    fptr->body = substituter.VisitStmt(f->body);
    return f;
  }

 private:
  // Constructor initializing the base class with the analyzer
  SafeMemoryLegalizer(arith::Analyzer* analyzer) : arith::IRMutatorWithAnalyzer(analyzer) {}

  // Override the VisitStmt_ method to handle ForNode (loop statements)
  Stmt VisitStmt_(const ForNode* op) final {
    // Visit and potentially modify the loop node
    For for_node = Downcast<For>(IRMutatorWithAnalyzer::VisitStmt_(op));
    auto has_inner_loop = HasInnerLoop(for_node->body);
    if (!has_inner_loop) {
      SafeMemorysRewriter rewriter(analyzer_);
      for_node.CopyOnWrite()->body = rewriter(for_node->body);
      // // Detect Buffer Load Node in the loop body, collect the indices and buffer size

      // // Run the checker on the loop body
      // GlobalMemChecker checker(analyzer_);
      // checker(for_node->body);
      // Array<PrimExpr> conditions = checker.GetConditions();
      // auto body = for_node->body;
      // // Note that we might have duplicate conditions
      // // Which will be optimzied by simplify pass
      // // Replace the loop body with the new body
      // for (auto cond : conditions) {
      //   body = IfThenElse(cond, body);
      // }
      // for_node.CopyOnWrite()->body = body;
      return std::move(for_node);
    }

    // Visit a For Node
    return IRMutatorWithAnalyzer::VisitStmt_(op);
  }

  static bool HasInnerLoop(const Stmt& stmt) {
    LeafForFinder finder;
    finder(stmt);
    return finder.leaf_for_nodes.size() > 0;
  }
};


[azure-cli-ml] update to 1.18.0

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it mcr.microsoft.com/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/j-so/azure-cli-extensions.git@jenns/azml1180#subdirectory=src/$EXT&egg=$EXT"

hi @bim-msft could you pls review this PR? thanks


Move from Buddy to GitHub Actions

Due to new memory restrictions on the free plan of Buddy it isn't possible to build new production versions of zskarte.
My suggestion is to move to GitHub Actions with automated testing and deployment.

action performed on master (without pull request)


Logging per Rocketlet

One of the reasons the current integrations inside of Rocket.Chat are hard to develop against and debug is because the log messages are merged with the rest of the logging system.
A few requirements I would like to see the Rocketlets have for logging:

Separated from the the rest of Rocket.Chat
Logs per run of any method (when a debugging mode is enabled)
Logs viewable per level type
Overall view of logs

The interface for viewing logs would ideally be searchable, filterable, and all of that (putting this here more for future reference).

very important point, indeed!
I'd expect a "sandbox console" which is parametrized to write to an own log file would be established for each Rocketlet.
This console should be available at runtime globally within the scope of the Rocketlet.


⚠ Bofrost.fr has degraded performance

In 059f978, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1460 ms

Resolved: Bofrost.fr performance has improved in 56fa7df after 13 minutes.


Fixes Tox link in docs

Found a little typo when browsing, fixed it for yah!
lates > latest

Awesome thanks!


re-add algolia

wip

Heyo, @codewithkristian, for the conflicts, can you just accept the incoming ones?
It's related to https://github.com/cloudflare/cloudflare-docs/pull/8348, which added some new functionality to the products grid.

@codewithkristian, we actually still need the ability to trigger Coveo searches for a few specific scenarios... which I imagine is easier than re-building similar functionality in Algolia.
Scenarios:

The current Tutorials page, which is broken in the preview
The existing search page, which is linked to from the API docs / the dashboard landing page, and the empty state of our newer product grid.

Seems to be a visual bug here


clockid_t and clock_gettime

I would like (need) to add bindings to clock_gettime and hence clockid_t. However I don't know how to do that in a platform independent way: the documentation says that clockid_t should exist, but doesn't seem to define what it should be (so I guess the precise implementation is platform specific?). What's the right solution using ctypes?

There used to be a binding to clockid_t in the posix-types package, but it was removed because OS X didn't support that type.

Ah, I see... What would be the right way of reusing the infrastructure of posix-types for type info discovery, and exposing clockid_t where it is available? Could there be a linux-specific (or unix-but-not-osx-specific?) sub-package of posix-types?

On the other hand, it may not be worth the hassle, and I could probably just use an ocaml time library (mtime?) and convert to Timespec.t.

I just noticed that mtime is implemented using clock_gettime(CLOCK_MONOTONIC,...) on linux. So I should be fine with just converting the output of mtime to Timespec.t :).


KOGITO-777: Include SCESIM editor

@ederign @tiagobento
See https://issues.redhat.com/browse/KOGITO-777
It successfully built in my local machine (
yarn run init yarn run build:fast
but I'm not sure what should happen inside vscode - not sure if it is actually working or not.

@gitgabrio Hi! Thanks for the PR, your changes look good to me. To make it will pass our CI, remember to use yarn run build:prod so that Lint and Tests are run as well.
Regarding testing if it's working or not, you should compile a kogito-tooling enabled [1] webapp and unpack the resulting WAR into kie-bc-editors-unpacked/scesim before building. Note that the build results will be avaiable at the dist folders.
Please also change the vscode-extension-pack-kogito-kie-editors/webpack.config.js file to copy the editor during the build.
[1] You should have a gwtEditorBeans property available on window.

Hi @tiagobento
I've searched again everywher for instances of "dmn" string, and wherever I've found one, I verified there is also a corresponding "scesim".
I also launched
but I get
[9967:1216/085708.128436:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /home/gcardosi/Developing/git/kogito-tooling/packages/vscode-extension-pack-kogito-kie-editors/.vscode-test/vscode-1.41.0/VSCode-linux-x64/chrome-sandbox is owned by root and has mode 4755.
I would like to avoid to create a "root-owned" directory inside the project ones; beside that, launching whatever process as "root" on linux machine is generally discouraged - unless not strictly needed (in my local machine could be an issue or not, ma on "servers" like jenkins I would strongly avoid that). Is there a way to run such process as normal user?

@tiagobento
The build failed on jenkins, but I really can't understand why.
@tiagobento @ederign
My I ask you to write simply step-by-step guide inside the kogito-tooling - the Readme or another file.
What is completely missing - IMHO - are the required step to add a new editor inside kogito-tooling
(exactly what I'm currently doing).
The blog you pointed me to could be related, but I think that proper place for such documentation should be, first, where it is needed for, i.e. in the project itself.

@gitgabrio Build on Jenkins is currently failing. About your "root" error, our VSCode tests download the latest VSCode version to run, and for some reason your packages/vscode-extension-pack-kogito-kie-editors/.vscode-test/vscode-1.41.0/VSCode-linux-x64/chrome-sandbox folder has root permissions. Try deleting the packages/vscode-extension-pack-kogito-kie-editors/.vscode-test folder and building again.
About the instructions on how to add a new editor, you're the first one doing that, so it might be a good opportunity for you to document the process you're going through so that it gets easier in the future.

@gitgabrio Build on Jenkins is currently failing. About your "root" error, our VSCode tests download the latest VSCode version to run, and for some reason your packages/vscode-extension-pack-kogito-kie-editors/.vscode-test/vscode-1.41.0/VSCode-linux-x64/chrome-sandbox folder has root permissions. Try deleting the packages/vscode-extension-pack-kogito-kie-editors/.vscode-test folder and building again.

@tiagobento Pls read carefully the message- it states exactly the other way around: it complains because the folder is not owned by root (as a matter of fact, owner is standard user)

@tiagobento @ederign
The build on jenkins failed again.
I've successfully issued the following one in my machine, though:
yarn run init && yarn run build:prod
Could you please take a look at error on jenkins to see what's going on? Thanks

@gitgabrio @tiagobento Hi guys, I'm trying to install kogito-tooling in my local and I'm encountering the same problem reported by Gabriele  [29232:1217/144723.356207:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /home/yamer/IdeaProjects/kogito-tooling/packages/vscode-extension-pack-kogito-kie-editors/.vscode-test/vscode-1.41.0/VSCode-linux-x64/chrome-sandbox is owned by root and has mode 4755.
Did you have an idea to fix?

@yesamer on future, this integration experience will be more easy, sorry for the inconvenience. For now, better check with @gitgabrio  how he worked around this error.

@yesamer @gitgabrio my guess on the root error is that something on your environment (probably node) is installed with root permissions.
Nobody on our team has this issue, and we are using osx and also linux, so this is probably something on your side.
Jenkins can be safely ignored because it's not proper configured. @tiagobento wdyt about removing it ?
@gitgabrio are you able to open your editor with your vscode extension?

@gitgabrio jenkins build fails because it uses node 11.0.0. We need LTS there to make it work.

Updated the PR name. We will wait to merge it together with the SceSim editor.

Please add me as a reviewer once ready for a re-review

I'll open a new PR for this ticket.


Sort was called multiple times in commands.ts

I have created a pull request for this issue fix and optimise list of commands from using sort #22


feat: added resource_reports into Table model

Summary of Changes
Added resource_reports  into Table model to support integration with tools generating static HTML reports, such as popmon, pandas-profiling or great_expectations.
additionally, there were conflicts with pytest version used in ci-pipeline,  version had been changed to >=4.6 so that ci-test could be completed
Tests
N/A
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x ] PR includes a summary of changes.
[x ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[x ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[ x] PR passes make test

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   73.27%   73.27%
=======================================
  Files           6        6
  Lines         116      116
  Branches        8        8
=======================================
  Hits           85       85
  Misses         26       26
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac6503...983e4c2. Read the comment docs.

the change make sense and lgtm.

cc @jinhyukchang , hey Jin, I recall you fix some pytest issues as well, do we need enforce the version pin for all repos?