[SPARK-28040][SPARK-28070][R] Write type object s3

What changes were proposed in this pull request?
Follow-on to https://github.com/apache/spark/pull/24885 -- implement writeType and writeObject as S3 methods
How was this patch tested?
Untested; please advise
Please review https://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11820/
Test PASSed.

Test build #106582 has started for PR 24888 at commit 5455fa6.

Test build #106582 has finished for PR 24888 at commit 5455fa6.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106582/
Test FAILed.

You mean this? Yea it doesn’t like comments that “looks like code”, you can “fix” it by making it  looking less like code ;)
style: Commented code should be removed.
if (length(object) > 1L) return(writeBin(as.raw(0x61), con)) #charToRaw('a')
About this part
#charToRaw('a')

@felixcheung thanks, have filed a new commit based on the errors/style issues with last commit

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11853/
Test PASSed.

Test build #106616 has started for PR 24888 at commit 91e087a.

Test build #106616 has finished for PR 24888 at commit 91e087a.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106616/
Test FAILed.

Hmm I don't follow the test fails this time. stuff coming from Scala (?)

i think it failed the session because of R version @HyukjinKwon
During startup - Warning message:
In .First() :
  Support for R prior to version 3.4 is deprecated since Spark 3.0.0
Loading required package: methods

Jenkins, retest this please

Test build #106860 has started for PR 24888 at commit 91e087a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12077/
Test PASSed.

Test build #106861 has started for PR 24888 at commit 91e087a.

Test build #106860 has finished for PR 24888 at commit 91e087a.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106860/
Test FAILed.

Test build #106861 has finished for PR 24888 at commit 91e087a.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106861/
Test FAILed.

Anything in the build log about:
[INFO] Spark Project ML Library ........................... FAILURE [01:26 min]

From: Michael Chirico<EMAIL_ADDRESS>Sent: Sunday, September 15, 2019 8:15 PM
To: apache/spark
Cc: Felix Cheung; Mention
Subject: Re: [apache/spark] [SPARK-28040][SPARK-28070][R] Write type object s3 (#24888)
@MichaelChirico commented on this pull request.

In R/pkg/R/serialize.Rhttps://github.com/apache/spark/pull/24888#discussion_r324500771:

} -writeTime <- function(con, time) {-  writeDouble(con, as.double(time))+# Used to pass arrays where all the elements are of the same type+writeArray <- function(arr, con) {+  # TODO: Empty lists are given type "character" right now.+  # This may not work if the Java side expects array of any other type.+  writeType(if (length(arr) > 0L) arr[[1L]] else "somestring", con)+  writeObject(length(arr), con, writeType = FALSE)

Hey @felixcheunghttps://github.com/felixcheung have finally sort-of got a Docker image able to build Spark from source to help me iterate locally 🎉
I'm able to build Spark on master with ./build/mvn -DskipTests clean package -X, but on the branch here I get:
[INFO] ------------------------------------------------------------------------[INFO] Reactor Summary for Spark Project Parent POM 3.0.0-SNAPSHOT:[INFO] [INFO] Spark Project Parent POM ........................... SUCCESS [04:47 min][INFO] Spark Project Tags ................................. SUCCESS [ 30.888 s][INFO] Spark Project Sketch ............................... SUCCESS [  4.329 s][INFO] Spark Project Local DB ............................. SUCCESS [ 15.605 s][INFO] Spark Project Networking ........................... SUCCESS [ 14.312 s][INFO] Spark Project Shuffle Streaming Service ............ SUCCESS [  5.987 s][INFO] Spark Project Unsafe ............................... SUCCESS [ 11.286 s][INFO] Spark Project Launcher ............................. SUCCESS [ 46.401 s][INFO] Spark Project Core ................................. SUCCESS [02:46 min][INFO] Spark Project ML Local Library ..................... SUCCESS [ 14.346 s][INFO] Spark Project GraphX ............................... SUCCESS [ 12.020 s][INFO] Spark Project Streaming ............................ SUCCESS [ 28.049 s][INFO] Spark Project Catalyst ............................. SUCCESS [01:52 min][INFO] Spark Project SQL .................................. SUCCESS [02:41 min][INFO] Spark Project ML Library ........................... FAILURE [01:26 min][INFO] Spark Project Tools ................................ SKIPPED[INFO] Spark Project Hive ................................. SKIPPED[INFO] Spark Project Graph API ............................ SKIPPED[INFO] Spark Project Cypher ............................... SKIPPED[INFO] Spark Project Graph ................................ SKIPPED[INFO] Spark Project REPL ................................. SKIPPED[INFO] Spark Project Assembly ............................. SKIPPED[INFO] Kafka 0.10+ Token Provider for Streaming ........... SKIPPED[INFO] Spark Integration for Kafka 0.10 ................... SKIPPED[INFO] Kafka 0.10+ Source for Structured Streaming ........ SKIPPED[INFO] Spark Project Examples ............................. SKIPPED[INFO] Spark Integration for Kafka 0.10 Assembly .......... SKIPPED[INFO] Spark Avro ......................................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time:  16:41 min[INFO] Finished at: 2019-09-16T01:47:41Z[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal net.alchim31.maven:scala-maven-plugin:3.4.4:testCompile (scala-test-compile-first) on project spark-mllib_2.12: Execution scala-test-compile-first of goal net.alchim31.maven:scala-maven-plugin:3.4.4:testCompile failed.: CompileFailed -> [Help 1]org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal net.alchim31.maven:scala-maven-plugin:3.4.4:testCompile (scala-test-compile-first) on project spark-mllib_2.12: Execution scala-test-compile-first of goal net.alchim31.maven:scala-maven-plugin:3.4.4:testCompile failed.    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)    at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)    at java.lang.reflect.Method.invoke (Method.java:566)    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)Caused by: org.apache.maven.plugin.PluginExecutionException: Execution scala-test-compile-first of goal net.alchim31.maven:scala-maven-plugin:3.4.4:testCompile failed.    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:148)    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)    at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)    at java.lang.reflect.Method.invoke (Method.java:566)    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)Caused by: sbt.compiler.CompileFailed    at sbt_inc.SbtIncrementalCompiler.zincCompile (SbtIncrementalCompiler.java:146)    at sbt_inc.SbtIncrementalCompiler.compile (SbtIncrementalCompiler.java:88)    at scala_maven.ScalaCompilerSupport.incrementalCompile (ScalaCompilerSupport.java:320)    at scala_maven.ScalaCompilerSupport.compile (ScalaCompilerSupport.java:136)    at scala_maven.ScalaCompilerSupport.doExecute (ScalaCompilerSupport.java:116)    at scala_maven.ScalaMojoSupport.execute (ScalaMojoSupport.java:574)    at scala_maven.ScalaTestCompileMojo.execute (ScalaTestCompileMojo.java:50)    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)    at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)    at java.lang.reflect.Method.invoke (Method.java:566)    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)[ERROR] [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR]   mvn  -rf :spark-mllib_2.12
It doesn't seem like particularly helpful diagnostics to me? Any insight on how to proceed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/apache/spark/pull/24888?email_source=notifications&email_token=ACENZ65GZDOWGBNU3LWWEV3QJ325HA5CNFSM4HYS7WZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEYLLJI#discussion_r324500771, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACENZ65FESD66PZP5U3OFLTQJ325HANCNFSM4HYS7WZA.

I didn't see anything earlier.
Of course on re-build when I pipe to a log to grep... the build succeeds 🤔
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  27:59 min
[INFO] Finished at: 2019-09-16T05:39:37Z
[INFO] ------------------------------------------------------------------------

Will keep investigating.

OK so I succeeded building twice with ./build/mvn -DskipTests clean package -X, but failed again when omitting -DskipTests.
Here's where I get FAILUREs -- output of grep FAILURE -B 10 -A 10 on the > output:
- accuracy - Int
- mergeInPlace - Int
- accuracy - Long
- mergeInPlace - Long
- accuracy - String
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Spark Project Parent POM 3.0.0-SNAPSHOT:
[INFO]
[INFO] Spark Project Parent POM ........................... SUCCESS [03:43 min]
[INFO] Spark Project Tags ................................. SUCCESS [ 26.374 s]
[INFO] Spark Project Sketch ............................... FAILURE [ 35.692 s]
[INFO] Spark Project Local DB ............................. SKIPPED
[INFO] Spark Project Networking ........................... SKIPPED
[INFO] Spark Project Shuffle Streaming Service ............ SKIPPED
[INFO] Spark Project Unsafe ............................... SKIPPED
[INFO] Spark Project Launcher ............................. SKIPPED
[INFO] Spark Project Core ................................. SKIPPED
[INFO] Spark Project ML Local Library ..................... SKIPPED
[INFO] Spark Project GraphX ............................... SKIPPED
[INFO] Spark Project Streaming ............................ SKIPPED
[INFO] Spark Project Catalyst ............................. SKIPPED
--
--
[INFO] Spark Project Graph ................................ SKIPPED
[INFO] Spark Project REPL ................................. SKIPPED
[INFO] Spark Project Assembly ............................. SKIPPED
[INFO] Kafka 0.10+ Token Provider for Streaming ........... SKIPPED
[INFO] Spark Integration for Kafka 0.10 ................... SKIPPED
[INFO] Kafka 0.10+ Source for Structured Streaming ........ SKIPPED
[INFO] Spark Project Examples ............................. SKIPPED
[INFO] Spark Integration for Kafka 0.10 Assembly .......... SKIPPED
[INFO] Spark Avro ......................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  06:10 min
[INFO] Finished at: 2019-09-16T06:27:08Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.scalatest:scalatest-maven-plugin:2.0.0:test (test) on project spark-sketch_2.12: There are test failures -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.scalatest:scalatest-maven-plugin:2.0.0:test (test) on project spark-sketch_2.12: There are test failures
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)

Test build #110656 has started for PR 24888 at commit 8dafcd2.

Test build #110656 has finished for PR 24888 at commit 8dafcd2.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110656/
Test FAILed.


Visualization - Cytoscape - general Questions

There is no hurry in answering my questions here, I was just looking for a good place to put them as I assume that I will come up with further questions in future.
I am trying to get more accustomed to cytoscape .
So, I created a sample file with people connected to Ibn Ridwan, Ibn Butlan and the Calif, very similar to the tsv. table "index-relations". It worked quite well so far, I was able to extract the required network, to adapt the layout and to display some tools for analyses such as betweenness centrality. But I face some problem in replacing the URI with the proper names.
My notes tell me, that I have to import the same file again, however as a table to a network collection (with person 2 URI as key, I import nothing from person one and add the data-file symbol to person 2) is this correct so far?
I am somehow not getting rid of the URIs

@lunadine Sorry I forgot to discuss this with you today!
There are potentially two issues here.

You have to get the Person 1 and Person 2 name or entry into the same column, so when you do the second import as you're doing, you have to name the uri and entry/name columns to match the ones you used for Person 1. An alternative is to have your node information (uris & names) for persons in a separate sheet from your edge info (just uris and relations). The more recent version of this spreadsheet does that https://docs.google.com/spreadsheets/d/1rfuZR5i3JDve0MapTFVzcU79Arwg8ZbCiE-Y6sXTa2c/edit#gid=0 . Then you do 2 imports, first the node table, then the edge table.
Also, in the Style > Node tab in Cytoscape you have to set the "Label" to your custom name column (whatever it's called) and select "passthrough mapping."

Hope this helps. Let me know if it works.

Unless you have more questions on this, I'll archive it :-)


Handle empty line from pipe

Sister issue: https://github.com/cruisen/cli-calc/issues/11
Does not provide a line feed to output, therefore 2 output lines in one

[ ] Investigate
[ ] Refactor
[ ] Test

See https://stackoverflow.com/questions/13238566/python-equivalent-of-input-using-sys-stdin
And https://stackoverflow.com/questions/38723140/i-want-to-use-stdin-in-a-pytest-test

Is duplicate of https://github.com/cruisen/cli-calc/issues/20


Column grow() only works within a Split or Stack

Package
filament/filament
Package Version
3.0.103
Laravel Version
10.34.1
Livewire Version
3.2.1
PHP Version
8.1.25
Problem description
When adding columns to a table for a model resource, all columns take up an equal percentage of the table width, even when adding grow(false) to the TextColumn.
Expected behavior
I expected the columns with grow(false) to shrink to their minimum width, as described in the manual. This does work if I wrap these columns in a Split, but Splits don't support labels; so I have to choose between sensible column widths and column headings?
Steps to reproduce

Create a new project with Laravel 10.x and Filament 3.x
Follow Filament 3.x Panels install documentation to install filament panels and create a new user account
Create an ExampleModel model, db migration, and seeder, with 3 columns; run migration and seed some sample data
Create a control panel and index table for ExampleModel (php artisan make:filament-resource ExampleModel --generate)
Log into the admin panel and select Example Models to view the table to see that the columns are all about the same width
Add to the table function in app/Filament/Resources/ExampleModelResource.php:

   public static function table(Table $table): Table
   {
       return $table
           ->columns([
               //
               TextColumn::make('col1')
                   ->grow(false),
               TextColumn::make('col2'),
               IconColumn::make('col3')
                   ->grow(false),
           ])
...
   }

Reload the page to see that col1 and col3 columns have not shrunk to their minimum width with col2 taking up the remaining space

Reproduction repository
https://github.com/nmalinoski/filament-grow-column-not-working
Relevant log output
No response

This change has the effect I'm looking for: https://github.com/filamentphp/filament/compare/3.x...nmalinoski:filament:9933-apply-column-grow-to-html-column

If you want to make a PR then, go for it. Does flex-1 really make a difference in tables though?

If you want to make a PR then, go for it. Does flex-1 really make a difference in tables though?

Looks like it doesn't. I dropped it from the added classes. I'll submit a PR shortly.


[Quickdraw] I am here to learn how to open and close issues on Github!

I am here to learn how to open and close issues on Github! 🤠
I will close it in 10 seconds 🤞

Hello

Hello

Superdev908

Superdev

Superdev

Superdev


Column sorting does not work

Sorting in example does not work

Column sorting in example isn't meant to work - it isn't implemented.
It is up to the user to sort the data and re-render following the change of props.

In that case the name of the library is misleading...
Datatables usually provide sorting out of the box.

@advance512 Thanks for your comment!
@mantydze Yes, you are right! most of Datatables component provide features like sorting are done within the library. but on the other hand, in react and flux(redux) world, it means you will lose some of your controls of components. so far, I don't know which is the right way. So, you can choose! :) there are a lot of cool react datatables already!

@hyojin
Could you please provide the demo example source code, so it might help us to see how you implement sorting, pagination and search functionality.
Right now the examples are not working as the demo. :)

@hyojin
Could you please provide the demo example source code, so it might help us to see how you implement sorting, pagination and search functionality.
Right now the examples are not working as demo. :)

Here is how I use the this component. I have placed it in another component so I can easily change to another library, if I run into a wall.
Haven't done sorting yet, but as you can see it should be quite easy. Look at the filtering example, but instead of filter - use Array.prototype.sort().
/* eslint-disable class-methods-use-this */
import React, { PropTypes } from 'react';
import DataTables from 'material-ui-datatables';
import { RefreshIndicator } from 'material-ui';
import get from 'lodash/get';

export class DataTable extends React.Component {

  constructor(props) {
    super(props);

    this.state = {
      page:        1,
      rowSize:     10,
      filterValue: null,
    };

    this.handleCellClick = ::this.handleCellClick;
    this.handleCellDoubleClick = ::this.handleCellDoubleClick;
    this.handleFilterValueChange = ::this.handleFilterValueChange;
    this.handleSortOrderChange = ::this.handleSortOrderChange;
    this.handleRowSizeChange = ::this.handleRowSizeChange;
    this.handlePreviousPageClick = ::this.handlePreviousPageClick;
    this.handleNextPageClick = ::this.handleNextPageClick;
  }

  handlePreviousPageClick() {
    const newState = Object.assign({}, this.state, { page: this.state.page - 1 });
    this.setState(newState);
  }

  handleNextPageClick() {
    const newState = Object.assign({}, this.state, { page: this.state.page + 1 });
    this.setState(newState);
  }

  handleRowSizeChange(rowSizeIndex, rowSize) {
    const newState = Object.assign({}, this.state, { page: 1, rowSize });
    this.setState(newState);
  }

  handleCellClick(tableRow, tableColumn, dataItem, dataItemField) {

    const { handleClick } = this.props;

    // eslint-disable-next-line no-console
    // console.log('handleCellClick', dataItem, dataItemField);

    handleClick(dataItem, dataItemField);
  }

  // eslint-disable-next-line no-unused-vars,no-unused-vars-rest/no-unused-vars
  handleCellDoubleClick(tableRow, tableColumn, dataItem, dataItemField) {
  }

  handleFilterValueChange(...args) {
    // eslint-disable-next-line no-console
    let filterValue = get(args, '[0]', null);
    if (filterValue) {
      filterValue = filterValue.toLowerCase();
    }
    const newState = Object.assign({}, this.state, { filterValue });
    this.setState(newState);
  }

  handleSortOrderChange(...args) {
    // eslint-disable-next-line no-console
    console.log('SortOrderChange', args);
  }

  render() {

    const { loading, tableColumns, dataItems, dataItemFormatter } = this.props;

    if (loading) {
      return (
        <div>
          <RefreshIndicator
            size={64}
            left={10}
            top={10}
            status="loading"
            style={{
              position: 'relative',
            }}
          />
        </div>
      );
    } else {

      // Only filter if required
      let filteredItems = dataItems;

      // Filter to select only the items that pass our seach, but only in the selected columns
      if (this.state.filterValue) {
        filteredItems = filteredItems.filter((item) => {

          for (const currentColumn of tableColumns) {
            if (get(item, currentColumn.key, '').toString().toLowerCase().includes(this.state.filterValue)) {
              return true;
            }
          }

          return false;
        });
      }

      // TODO: Prime reselect location right here
      const formattedDataItems =
        filteredItems
          .slice(this.state.rowSize * (this.state.page - 1), this.state.rowSize * (this.state.page))
          .map(dataItemFormatter);

      return (
        <DataTables
          height={'auto'}
          selectable={false}
          showRowHover
          columns={tableColumns}
          data={formattedDataItems}
          showCheckboxes={false}
          showHeaderToolbar
          onPreviousPageClick={this.handlePreviousPageClick}
          onNextPageClick={this.handleNextPageClick}
          onRowSizeChange={this.handleRowSizeChange}
          onCellClick={this.handleCellClick}
          onCellDoubleClick={this.handleCellDoubleClick}
          onFilterValueChange={this.handleFilterValueChange}
          onSortOrderChange={this.handleSortOrderChange}
          count={dataItems.length}
          page={this.state.page}
          rowSize={this.state.rowSize}
        />
      );
    }
  }
}

DataTable.propTypes = {
  loading:           PropTypes.bool,
  tableColumns:      PropTypes.arrayOf(PropTypes.shape({
    key:   PropTypes.string,
    label: PropTypes.string,
  })),
  dataItems:         PropTypes.arrayOf(PropTypes.object),
  dataItemFormatter: PropTypes.func,
  handleClick:       PropTypes.func,
};

DataTable.defaultProps = {
  loading:           true,
  tableColumns:      [
    {
      key:   'name',
      label: 'Name',
    },
  ],
  dataItems:         [],
  dataItemFormatter: item => item,
  handleClick:       () => {
  },
};

@advance512 Thank you for giving us your code! :)
@bharadwajag It depends on your data and how you want to implement, but if you are thinking sorting on client side, I think using lodash is a good option. https://lodash.com/docs/4.17.4#sortBy
And also you can find my demo code on gh-pages branch,
https://github.com/hyojin/material-ui-datatables/tree/gh-pages/demo/src

@hyojin
Thanks for the quick reply.

Hi,
I went through your example code but did not understand how to implement it (React novice here). I fetch my data from an external API, store it in props (eg. this.props.foo.posts), then map it into table rows.
Could you please help point out how to modify the FakeApi function in the code below?
FakeAPI(this.state.currentPage, this.state.rowSize, key, order, this.state.filter, (result) => {
	this.setState({
		total: result.count,
		data: result.data,
		sort: key,
		order: order,
	});
});

Any help would be appreciated. Thanks!

@ekaoddlass Hi, FakeAPI just slices data array based on currentPage and rowSize parameters and returns it. So if your api already has pagination, call your api, instead of FakeAPI, and just pass page and row size parameter and set the result as data prop. if it doesn't, you can fetch all data then manipulate as same as what FakeAPI does.
I'm not sure what is your problem exactly, if you have troubles with managing data on front-end side, I recommend you to look through the documents of Flux/Redux.


On windows in Python 3.5.2 The bot gets a TypeError: cannot 'yield from' a coroutine object in a non-coroutine generator

I don't get this because it works on my bot without issues at all. However If I was to run your bot this spams up all the time for some odd reason. It happens upon login and upon every message it sees.
DWhen it sees messages:
Task exception was never retrieved
future: <Task finished coro=<_run_event() done, defined at E:\Users\Elsword\Desk
top\Klarity by Eleria\New folder (4)\MusicBot-master\discord\client.py:272> exce
ption=TypeError("cannot 'yield from' a coroutine object in a non-coroutine gener
ator",)>
Traceback (most recent call last):
  File "E:\Users\Elsword\Desktop\Klarity by Eleria\New folder (4)\MusicBot-maste
r\discord\client.py", line 275, in _run_event
    yield from getattr(self, event)(*args, **kwargs)
TypeError: cannot 'yield from' a coroutine object in a non-coroutine generator

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "E:\Users\Elsword\Desktop\Klarity by Eleria\New folder (4)\MusicBot-maste
r\asyncio\tasks.py", line 238, in _step
    result = next(coro)
  File "E:\Users\Elsword\Desktop\Klarity by Eleria\New folder (4)\MusicBot-maste
r\discord\client.py", line 280, in _run_event
    yield from self.on_error(event, *args, **kwargs)
TypeError: cannot 'yield from' a coroutine object in a non-coroutine generator

While logging in:
[INFO] launcher: Starting sanity checks
[INFO] launcher: Checking for python 3.5+
[INFO] launcher: Checking console encoding
[INFO] launcher: Setting console encoding to UTF-8
[INFO] launcher: Ensuring we're in the right folder
[INFO] launcher: Adding local bins/ folder to path
[INFO] launcher: Checks passed.
[INFO] launcher: Moving old musicbot log
Loaded autoplaylist with 3055 entries
Creating a client session outside of coroutine
client_session: <aiohttp.client.ClientSession object at 0x03820FB0>
Creating a client session outside of coroutine
client_session: <aiohttp.client.ClientSession object at 0x0387D0D0>
[INFO] launcher: ConnectingE:\Users\Elsword\Desktop\Klarity by Eleria\New folder
 (4)\MusicBot-master\discord\client.py:275: RuntimeWarning: coroutine 'on_ready'
 was never awaited
  yield from getattr(self, event)(*args, **kwargs)
E:\Users\Elsword\Desktop\Klarity by Eleria\New folder (4)\MusicBot-master\discor
d\client.py:280: RuntimeWarning: coroutine 'on_error' was never awaited
  yield from self.on_error(event, *args, **kwargs)
Task exception was never retrieved
future: <Task finished coro=<_run_event() done, defined at E:\Users\Elsword\Desk
top\Klarity by Eleria\New folder (4)\MusicBot-master\discord\client.py:272> exce
ption=TypeError("cannot 'yield from' a coroutine object in a non-coroutine gener
ator",)>
Traceback (most recent call last):
  File "E:\Users\Elsword\Desktop\Klarity by Eleria\New folder (4)\MusicBot-maste
r\discord\client.py", line 275, in _run_event
    yield from getattr(self, event)(*args, **kwargs)
TypeError: cannot 'yield from' a coroutine object in a non-coroutine generator

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "E:\Users\Elsword\Desktop\Klarity by Eleria\New folder (4)\MusicBot-maste
r\asyncio\tasks.py", line 238, in _step
    result = next(coro)
  File "E:\Users\Elsword\Desktop\Klarity by Eleria\New folder (4)\MusicBot-maste
r\discord\client.py", line 280, in _run_event
    yield from self.on_error(event, *args, **kwargs)
TypeError: cannot 'yield from' a coroutine object in a non-coroutine generator

I have no idea why this happens. I happens even if I downgrade discord.py on this from 0.16.2 to 0.12.0 So it is not the discord.py version at all.
It happens with not only the master branch for me but also the review branch.

You've installed the bot wrong. You didn't clone from GitHub like the guides suggest.
You've installed discord.py within the same folder as the MusicBot.

We're not going to help you with this.


How can I look up the admin of an org that I don't have access to?

Navigating to an Azure DevOps organisation that I don't have access to indicates that I need to reach out to the admins of the org to get access. But without access to the org, I have no way to find out who the admin is.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20dce3f1-1133-3084-c5f4-7a5d6d0d6cf8
Version Independent ID: 31579324-f0e5-607a-caa1-ec31b444af79
Content: Find an admin or organization owner - Azure DevOps
Content Source: docs/organizations/security/lookup-organization-owner-admin.md
Product: devops
Technology: devops-security
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@fiksen99  Thank you for the question.
You will need at minimum basic access to see this information, please refer to these FAQ.
Private repos with no access allow no information to be accessed, unless alternatively an organization decides to create a public facing wiki, help page, etc.
If the screen is misleading, please include the details below and start a ticket in the Azure DevOps Community.  Include a link to this issue and the product team can review and assess.


Lossnay Devices are not working

After a fresh installation with V3 i get my ecodan heatpump the climate device but not the ERV Lossnay devices.
homebridge-melcloud-control.log (1).txt

Fixed

Very fast fix! It works. Thanx


[wip][rfc] New readme from Fig1; fix #42

This adds a readme that recreates Fig1 of the NLMpy paper as suggested in #42.
This is their Fig1:

This is the one of this PR:

The code here ports this file https://besjournals.onlinelibrary.wiley.com/action/downloadSupplement?doi=10.1111%2F2041-210X.12308&file=mee312308-sup-0002-dataS2.py
to our julia format. As you can see there are some discrepancies that we could revisit to make our syntax more intuitive.
I also don't really know about Fig1s, and of course I just need to update the colors on the classified ones.

Codecov Report

Merging #45 (7784ee8) into main (efab0af) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main     #45      +/-   ##
========================================
- Coverage   6.80%   6.75%   -0.05%
========================================
  Files         13      13
  Lines        294     296       +2
========================================
  Hits          20      20
- Misses       274     276       +2

Flag
Coverage Δ

unittests
6.75% <0.00%> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/algorithms/nnelement.jl
0.00% <0.00%> (ø)

src/classify.jl
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efab0af...7784ee8. Read the comment docs.

Now with updated colors

AMAZING 👀

I'm going to be my usual self and say: can we update the discrete color palette with something that is accessible, like Wong or IBM?

I agree that would be nice, but isn't there something to be said for choosing the exact same one as the original paper?

I'm all for reproducibility, but I think it's better to make a point about accessible color schemes - it wouldn't change the message, and it would make the figure accessible to ~ 10% of people with different color perception.

Looks great. I'm just wondering why the Y axis seems to be flipped in d and e in our version?

@tpoisot in fact this is one of the high-quality color schemes from RColorBrewer, which are all vetted for accessibility and scientific accuracy. I'm a 100% in agreement with making a statement for using high-quality accessible color schemes, but don't think we should support the notion that this restricts us to a very small portion of schemes, like wong. Even for full color deficiency it should be possibly to tell these apart, with possibly a slight issue for 100% deuteranopics:

if you like, maybe we can use a different color scheme for the docs?
@rafaqz because Plots and matplotlib interpret matrix orientation differently in heatmap. "Correct" matrix orientation is a real religion among plotting packages.

Interesting, the simulation plugin I used made the color much less distinguishable than your screenshot - let's go with this then.


allow for custom frontmatter field names

released!
https://github.com/jparkerweb/pexels-banner/releases/tag/1.2.0


The customer still can be registered when the marketplace is not accessible for this supplier.

Date: 2016/07/01
[Test category]: creative Test
Severity: minor
[Steps to reproduce]

In first browser such as Firefox, Platform operator create a marketplace "mp1" make a supplier access to it.
In another browser, such as IE, log in as supplier, go to "register customer", input all the information, select the marketplace "mp1", do not click "save" button, just stay at this page with information input.
In first browser, platform make the supplier has no access to "mp1".
In the second browser, supplier click on "save" button.

[Expected result]
Register customer failed, because the selected browser is not accessible at that time. And should give some error message.
[Observed result]
Register successfully with the message "The organization 96ef71d6 has been successfully registered."

This is not a bug. Some small synchronization gab is unavoidable, however the setting is read in the other browser session. Anyhow, after completing the registration the update is reflected correctly. This works as expected.


no ssh

Hey, first of i want to thank you for your hard work. you did incredible job!
i was copy hostname to the sdcard root folder.
its seems like the camera does not listen on port 22 for SSH at all.
any suggestions?

telnet is open. sorry

Glad this is working for you! You could build dropbear with the right toolchain. Although there is not much free disk space as only half of the 32Mb flash is usable. These hacks just modify the existing firmware and telnet is all I needed.

telnet is more than enough! thank you.
is it possible to add timestamp and / or change the stream resolution?


unclear statement about anonymous or unauthenticated proxy traffic

Hi folks,
for page: https://learn.microsoft.com/en-us/microsoft-365/security/defender-endpoint/configure-proxy-internet?view=o365-worldwide
this sentence/paragraph , seems incomplete and unclear?
If a proxy or firewall is blocking anonymous traffic as Defender for Endpoint sensor, and it's connecting from system context to make sure anonymous traffic is permitted in the previously listed URLs.
should it instead be like this?:
If a proxy or firewall is blocking anonymous traffic from the Defender for Endpoint sensor, and it's connecting from system context , it's important to make sure anonymous traffic is permitted in your proxy or firewall for the previously listed URLs.

@msbemba Thank you very much for the contribution and updating the documentation with PR. @DonPick Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Is it  bug

Continuous plus or minus the time will be wrong, such as an initial value of 0.05, I added twice after 2.05, when I press the time, his value becomes 1.049999999998.

Duplicate


Front end 4

Coverage decreased (-10.7%) to 89.333% when pulling d0fff2a6e3e7f64c19eb7cd5a4b3540c9209bfa3 on front-end-4 into 91a56cfe909f1ae3524af0c8a4e324d6709bfca2 on master.

Coverage decreased (-10.7%) to 89.333% when pulling 7790f7ac7b409b74b2697fce464d0eda8e3c5c9d on front-end-4 into 91a56cfe909f1ae3524af0c8a4e324d6709bfca2 on master.

Coverage decreased (-10.7%) to 89.333% when pulling 7790f7ac7b409b74b2697fce464d0eda8e3c5c9d on front-end-4 into 91a56cfe909f1ae3524af0c8a4e324d6709bfca2 on master.

Coverage decreased (-10.7%) to 89.333% when pulling 05843d101a6269a78fc67da75e887c7c8cc15c0d on front-end-4 into 91a56cfe909f1ae3524af0c8a4e324d6709bfca2 on master.


fix(sink): resolve schema mismatch due to row_id column

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fixes #4303
Please explain IN DETAIL what the changes are in this PR and why they are needed:
When writing to a mysql table, an schema mismatch error occurred due to writing the _row_id column along with the intended columns. In the initial version of this PR I "fixed" the issue by simply omitting columns suffixed with "_row_id" when writing to MySQL. However, this solution was lacking some nuance.
Hidden columns should not simply be omitted in SinkExecutor. In the current version all columns, including hidden columns are written to MySQL.
This PR:

Adds fn prepare() to SinkImpl in order to make sure (in case of MySQLSink) that a table with correct schema (including hidden columns)  before data is written to the external sink.
Makes sure sink is properly dropped in stream manager (closes: #4302).
Tests

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Please hold for a while

After a second thought, it can't be correct if we need to manually remove a column like this. For agg MV, the pk will be the group key. For join MV, the pk will be join key + original pk. Removing row_id might make sense for table source, but for other sources there might not be a column called "row_id" and might have something more to remove.
The logic needs to be handled in frontend instead of in sink. Need revisit the code instead of merging this PR.

agree with @skyzh , sink have no following executors, its column (or visibility) should be aligned to external tables

@skyzh @tabVersion I agree as well, so I've updated the code. Main difference is that no columns (including hidden ones) are omitted anymore. I also added fn prepare method to SinkImpl which ensures a table with correct schema is created in MySQL. Perhaps at a later stadium an option can be added to Sink's properties so that the user can decide whether not to include hidden columns.
(I've updated the description of this PR as well)

hidden columns (generally stream pk) is crucial to correctness. We should always include them. One example:
If users create a MV which contains exactly one visible column A, with two rows of the same value 1. Without hidden column of stream key, we can never distinguish them.

... which leads to inconsistency between RisingWave's query result and sink's stored result during updates and deletes.

... and thus I believe this impl is correct. No need to use projections to remove hidden columns cc @tabVersion

hidden columns (generally stream pk) is crucial to correctness. We should always include them. One example:
If users create a MV which contains exactly one visible column A, with two rows of the same value 1. Without hidden column of stream key, we can never distinguish them.

Good point. I agree that we should include _row_id to the sink table in case it has not declared any primary key column. Then the two records will be seen as undistinguishable from our side. It should have a _row_id to allow us uniquely update its value.

it has not declared any primary key column

If MySQL has declared pk column, we should do an extra shuffle on our side, and we'll need to specify new pk in create_sink statement. May discuss later.

If MySQL has declared pk column, we should do an extra shuffle on our side, and we'll need to specify new pk in create_sink statement. May discuss later.

Tao is on a new design. One thing for sure: we will have pk on sink


unbound-control-setup hangs sometimes depending on the openssl version

Describe the bug
unbound-contro;-setup hangs sometimes depending on the openssl version
To reproduce
Run the script when an old version is installed
Expected behavior
A clear and concise description of what you expected to happen.
System:

Unbound version: unbound-1.21.0
OS: FreeBSD and probably others
unbound -V output: Not relevant

Additional information
See FreeBSD bug report: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281804
and proposed solution: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=253969&action=diff

I think this is a duplicate of #1126 . I do not mind adding the 'openssl version' as the additional parameter on the commandline, but perhaps the commit that fixes that issue already fixed this one as well.

Committed the fix. This is in addition to the other fix, which looks to be fine. Thanks for the patch provided!


Persist/Retrieved username to/from local storage

Store user preferences (last room and name)

https://github.com/jangouts/jangouts/pull/374


Intercepts errors happening in exquisite/puppeteer to fail tests

This should help with "Non deterministic render test failures".
A couple of examples.

Network failures:

While executing the test, you will get a verbose console message like:
Error: Request failed: URL="https://libs.cartocdn.com/mapbox-gl/v0.45.0-carto1/mapbox-gl.css"; Reason="net::ERR_INTERNET_DISCONNECTED"
    at Page.requestfailed (/Users/rochoa/projects/carto-vl/test/common/util.js:74:29)
    at emitOne (events.js:116:13)
    at Page.emit (events.js:211:7)
    at NetworkManager.Page._networkManager.on.event (/Users/rochoa/projects/carto-vl/node_modules/puppeteer/lib/Page.js:96:80)
    at emitOne (events.js:116:13)
    at NetworkManager.emit (events.js:211:7)
    at NetworkManager._onLoadingFailed (/Users/rochoa/projects/carto-vl/node_modules/puppeteer/lib/NetworkManager.js:301:10)
    at emitOne (events.js:116:13)
    at CDPSession.emit (events.js:211:7)
    at CDPSession._onMessage (/Users/rochoa/projects/carto-vl/node_modules/puppeteer/lib/Connection.js:219:12)
    at Connection._onMessage (/Users/rochoa/projects/carto-vl/node_modules/puppeteer/lib/Connection.js:119:19)
    at emitOne (events.js:116:13)
    at WebSocket.emit (events.js:211:7)
    at Receiver._receiver.onmessage (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/WebSocket.js:141:47)
    at Receiver.dataMessage (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/Receiver.js:389:14)
    at Receiver.getData (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/Receiver.js:330:12)
    at Receiver.startLoop (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/Receiver.js:165:16)
    at Receiver.add (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/Receiver.js:139:10)
    at Socket._ultron.on (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/WebSocket.js:138:22)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:250:11)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at TCP.onread (net.js:607:20)
Failed to load resource: net::ERR_INTERNET_DISCONNECTED
Error: Request failed: URL="https://libs.cartocdn.com/mapbox-gl/v0.45.0-carto1/mapbox-gl.js"; Reason="net::ERR_INTERNET_DISCONNECTED"
    at Page.requestfailed (/Users/rochoa/projects/carto-vl/test/common/util.js:74:29)
    at emitOne (events.js:116:13)
    at Page.emit (events.js:211:7)
    at NetworkManager.Page._networkManager.on.event (/Users/rochoa/projects/carto-vl/node_modules/puppeteer/lib/Page.js:96:80)
    at emitOne (events.js:116:13)
    at NetworkManager.emit (events.js:211:7)
    at NetworkManager._onLoadingFailed (/Users/rochoa/projects/carto-vl/node_modules/puppeteer/lib/NetworkManager.js:301:10)
    at emitOne (events.js:116:13)
    at CDPSession.emit (events.js:211:7)
    at CDPSession._onMessage (/Users/rochoa/projects/carto-vl/node_modules/puppeteer/lib/Connection.js:219:12)
    at Connection._onMessage (/Users/rochoa/projects/carto-vl/node_modules/puppeteer/lib/Connection.js:119:19)
    at emitOne (events.js:116:13)
    at WebSocket.emit (events.js:211:7)
    at Receiver._receiver.onmessage (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/WebSocket.js:141:47)
    at Receiver.dataMessage (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/Receiver.js:389:14)
    at Receiver.getData (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/Receiver.js:330:12)
    at Receiver.startLoop (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/Receiver.js:165:16)
    at Receiver.add (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/Receiver.js:139:10)
    at Socket._ultron.on (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/WebSocket.js:138:22)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:250:11)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at TCP.onread (net.js:607:20)
Failed to load resource: net::ERR_INTERNET_DISCONNECTED
    11) /geometries/collection-point/color

In the summary for all the tests you get a shorter message:
  11) Render tests:
       /geometries/collection-point/color:
     Error: Request failed: URL="https://libs.cartocdn.com/mapbox-gl/v0.45.0-carto1/mapbox-gl.css"; Reason="net::ERR_INTERNET_DISCONNECTED", Request failed: URL="https://libs.cartocdn.com/mapbox-gl/v0.45.0-carto1/mapbox-gl.js"; Reason="net::ERR_INTERNET_DISCONNECTED"
      at Object.testSST (test/common/util.js:84:15)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)

Something related to CARTO VL itself

Verbose trace while executing:
Error: Error: Another atomic change was done before this one committed
    at Layer.update (http://localhost:5000/dist/carto-vl.js:7281:19)
    at Page._handleException (/Users/rochoa/projects/carto-vl/node_modules/puppeteer/lib/Page.js:427:38)
    at CDPSession.Page.client.on.exception (/Users/rochoa/projects/carto-vl/node_modules/puppeteer/lib/Page.js:103:60)
    at emitOne (events.js:116:13)
    at CDPSession.emit (events.js:211:7)
    at CDPSession._onMessage (/Users/rochoa/projects/carto-vl/node_modules/puppeteer/lib/Connection.js:219:12)
    at Connection._onMessage (/Users/rochoa/projects/carto-vl/node_modules/puppeteer/lib/Connection.js:119:19)
    at emitOne (events.js:116:13)
    at WebSocket.emit (events.js:211:7)
    at Receiver._receiver.onmessage (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/WebSocket.js:141:47)
    at Receiver.dataMessage (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/Receiver.js:389:14)
    at Receiver.getData (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/Receiver.js:330:12)
    at Receiver.startLoop (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/Receiver.js:165:16)
    at Receiver.add (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/Receiver.js:139:10)
    at Socket._ultron.on (/Users/rochoa/projects/carto-vl/node_modules/ws/lib/WebSocket.js:138:22)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:250:11)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at TCP.onread (net.js:607:20)
    19) /regression/layer-update

Message for the summary:
  19) Render tests:
       /regression/layer-update:
     Error: Error: Another atomic change was done before this one committed
    at Layer.update (http://localhost:5000/dist/carto-vl.js:7281:19)
      at Object.testSST (test/common/util.js:84:15)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)

@rochoa the atomic change error is due our famous synchronicity issues but doesn't affect the test result. (it should not, maybe we just discovered the source of non-determinism)
Not the suite fails because you throw an error maybe a console.error would be better... not sure

I always prefer duplication over a wrong abstraction.

I want the suite to fail if a non-expected error happened, that's why I used the throw.

Now the tests will fail more because the atomic change error

Now the tests will fail more because the atomic change error

I would look into that, that smells... a lot

I would look into that, that smells... a lot

sure!


PowerShell Core $IsOSX has been renamed to $IsMacOS

Update the constrained runspace to use the new variable.

I screwed up the signing of 1.1.0 so I'll have to ship 1.1.1 today.  Maybe we can include this there?


Setup GitHub Action for Build

🆕🐥 First Timers Only
This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
👾 Description of the issue
We decided that the service should be a Maven project (see https://github.com/adoptium/documentation-services/issues/1). We need a GitHub Action that automatically builds (and tests) the service for PullRequests.
📋 Step by Step
To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here.

[ ] Claim this issue: Comment below.
[ ]  Fork the repository in github by simply clicking the 'fork' button.
[ ]  Check out the forked repository
[ ]  Create a feature branch for the issue. We do not have any naming definition for branches.
[ ]  Commit your changes.
[ ]  Start a Pull Request.
[ ]  Done 👍 Ask in comments for a review :)
[ ]  If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
[ ]  You did it 🎉 We will merge the fix in the master branch.
[ ]  Thanks, thanks, thanks for being part of this project as an open source contributor ❤

🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a change to receive cool goodies like a T-Shirt. 🎽
🤔❓ Questions
If you have any questions just ask us directly in this issue by adding a comment. You can join our community chat at Slack. Next to this you can find a general manual about open source contributions here.

I'd like to take care of this. I think #1 should be finished first, right?

setting up an action for just building it...what else beyond just building?


Renames spring.sleuth.propagation-keys to remote-keys

spring.sleuth.local-keys and spring.sleuth.remote-keys make sense
together, especially as baggage-keys will be removed.

The old property will still be read, just with a warning.

Added to https://github.com/spring-cloud/spring-cloud-sleuth/wiki/Spring-Cloud-Sleuth-3.0-Migration-Guide


[BEAM-1928] Translate a Pipeline in SdkComponents

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify.
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @kennknowles

Coverage increased (+0.01%) to 70.748% when pulling 1a05a6a66fabfaa2968f81a73df6b8a1a6fc1301 on tgroh:translate_pipeline_in_components into d6cc850a93eaec6103b5fc95d4c02653e945f2b4 on apache:master.


Allow for bounds to be specified for WMS layers so requests aren't made outside the bbox

WMS layers have a BoundingBox defined which defines the location of the data. It is more efficient to not request data that is outside of the bounding box, because it just results in needless HTTP requests that result in empty/transparent tiles.
There should be a way to configure the bounding box for the layer for TileLayer.WMS, ideally accounting for the CRS.

maxBounds should solve this.

Looks like it doesn't. maxBounds is set,
          maxBoundsViscosity: 1,
          bounceAtZoomLimits: false,
          worldCopyJump: true,

When I drag past my maxBounds limit, leaflet tries to load tiles which are outside of the bounds.

@kaynz @ericdahl Can you check if this is solved in master by #4646? If not, please provide
a fiddle/codepen/playground that displays this behaviour.

For me it is not solved. I will try to provide a fiddle laters.

This works fine for me with GridLayer's bounds attribute, testing using 1.0.1.
Thanks

@ericdahl great to hear! Only took us a year to notice, but I'm closing this now. Thanks!


Deprecate input/output getters throwing an exception

Gradle is currently lenient at task creation and task graph building time when input/output getters throw an exception. It should report the exception.

cc: @gradle/build-cache

Let's close this for now.


[sort] Code generation cleanups around sort

Part of the ongoing series of PRs to make code generation easier to develop and test.
Summary:

Move out sort function into its own case class for better testability
Fix code generation such that select() is called instead of the old name filter()
Enhance CFunction2 abstraction to contain header information.  The idea is to eventually replace all uses of CFunction with CFunction2 and simplify CodeStructure and CombinedCompilationColumnarRule to use higher-level abstraction than raw String
Introduce FunctionTemplateTrait to capture existing function templates like SortFunction, GroupingFunction, etc
Add toVeFunction to FunctionTemplateTrait to reduce boilerplate around VeFunction generation
Migrate function templates over to com.nec.spark.agile package

TPCH with all VE-related flags turned on:

For some reason I run into this error on Query 22 when doing a full run... but if I run 22 by itself it doesn't fail... https://gist.github.com/wmeddie/c49a804abcf52a7e2a498cc9e8f38fca
I can run it with --conf spark.executorEnv.VEO_LOG_DEBUG=1 but since it's at the end it'll be annoyingly difficult to get to it.

When I run nm on it there's a few undefined symbols.

I have been unable to reproduce the issue on the other machines, even with all *-on-ve flags turned on.  It is likely not an issue directly caused by this PR.  In either case, we will investigate the issue separately.


make uri dynamic

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

closed having got confirmation that it's working, from doc am team


HowTo Change Base url of swagger?

I'd like to have the help page generated blow
/help/ not /swagger/
how can i set this?

See the readme section on Custom Routes ...
https://github.com/domaindrivendev/Swashbuckle#custom-routes

hey,
I tried this but the UI doesn not show at /sandbox/ui/index it returns an expection
"Mapping not found - ui/index"
The /docs/v1 works fine and returns json text.
I am running version 5.2.1

I'm having the same problem, up to and including "Mapping not found - ui/index". Has a solution been found for this?

I have also noticed, if you use a custom route, the default route mapping is no longer used (eg. ../swagger routes to ../swagger/ui/index).  In order to do this with your custom mapping, you must manually put an additional route mapping into your route configuration:
config.Routes.MapHttpRoute(
		name: "help_ui_shortcut",
		routeTemplate: "help",
		defaults: null,
		constraints: null,
		handler: new RedirectHandler(SwaggerDocsConfig.DefaultRootUrlResolver, "help/ui/index"));


ReferenceError on error() call

Font.js:628 throws ReferenceError: Can't find variable: error whenever a font is not loaded yet.

obsolete with the 2019 rewrite


Add pytest backend implementation of testing.parameterize

A step to migrate to PyTest-style tests.
The PR adds pytest.mark.parametrize implementation of cupy.testing.parameterize.  The pytest implementation is opt-in.  For now, the trigger is to stop inheriting unittest.TestCase.
pytest.mark.parametrize is fast because it does not generate classes/functions.  With pytest==4.1.1, pytest test_arithmetic.py was 8432 passed in 27.47 seconds and will be 8432 passed in 18.72 seconds.  The difference reflects the speed-up of the collection time (pytest --collect-only) 14s -> 3s.
cupy.testing.helper decorators (e.g. numpy_cupy_allclose, for_dtypes) will support non-unittest.TestCase test collection.  The change required a hack because the decorators change function signatures, which pytest does not expect.  Other cupy.testing functionalities (e.g. repeat, retry, fix_random) still assume unittest.TestCase (e.g. unittest.TestSuite, unittest.setUp), and they are out of scope of the PR.

Jenkins, test this please.

Jenkins CI test (for commit a6e02a63c16c8e63e74923efb4bca84ef62a227b, target branch master) succeeded!

LGTM.


Delete command with --interactive flag corrupted output

Expected behavior
I expect kubecolor to properly handle input/output when delete command has --interactive flag.

Linux
Kubectl and kubecolor version
Client Version: v1.31.2
Kustomize Version: v5.4.2
Kubecolor Version: v0.4.0

Additional context
No response

It can be workarounded via --plain option to disable colors, but that presumes client-side effort. Perhaps we could just disable coloring if we stumble on -i/--interactive option?

Yeah agreed we should just imply --plain in this case.
In #65 we hit a similar issue, where then plan is to do some bigger refactorings to still have color support in these cases, but for now let's just disable coloring when the user provides the interactive flag


[release-v1.8] Replace heartbeats test image in rekt resources with midstream variant

Same as https://github.com/openshift-knative/eventing/pull/170

/retest

/retest


Strict broken for floats

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
A strict mode model will accept integers into float fields.
The opposite /does/ work however (fails when inserting a float into an int field)
Example Code
from pydantic import BaseModel, ConfigDict

class Test(BaseModel):
  model_config = ConfigDict(strict=True)
  a: float

x: int = int(1)
assert type(x) is not float
assert type(x) is int
assert not issubclass(float, int)
assert not issubclass(float, int)

Test(a = x) # should fail

Python, Pydantic & OS Version
pydantic version: 2.8.2
        pydantic-core version: 2.20.1
          pydantic-core build: profile=release pgo=true
                 install path: /Users/owner/code/codewars/.venv/lib/python3.11/site-packages/pydantic
               python version: 3.11.7 (main, Feb 11 2024, 14:54:11) [Clang 15.0.0 (clang-15<IP_ADDRESS>)]
                     platform: macOS-13.5-arm64-arm-64bit
             related packages: typing_extensions-4.12.2
                       commit: unknown

@Mardoxx,
Thanks for your question. Though this seems counterintuitive at first, we've sourced this logic / behavior from PEP 484. Specifically:

when an argument is annotated as having type float, an argument of type int is acceptable

Also worth adding for anyone else reading: JSON does not have distinct types for ints and floats. So this follows also.


[examples] Update dependency in the dashboard template

The provided dependency in the README for the Dashboard example/template is outdated, replaced with the correct one which is @mui/x-charts

Ah, nice, it was forgotten in #40107. We should have searched for "recharts" on the codebase


bug(ripple): all nested matRipple ancestors get launched, not only the the closest one

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
14.2.7
Description
There is already a locked bug (#26656), but I would like to approach from a different point.
In angular/components v14 the ripple event management was different, probably not delegated, but mainly it was using the bubble phase of events. with v15 this was changed and using global delegation causes all the ancestor ripples to fire.
The fact that ripple is now using the capture phase makes it worse, cause it is virtually impossible for the developer to stop/control these events to avoid the aforementioned ancestor ripple cascade.
By chaning the RippleEventManager::_delegateEventHandler (and optionally adding a boolean return value to the ripple event handlers) this issue could be easily mitigated.
Reproduction
StackBlitz link: https://stackblitz.com/edit/stackblitz-starters-gbsh9b
Steps to reproduce:

click on any of the buttons
see how the ripple get fired both on the button and the card

Expected Behavior
Ripple should be handled by the ripple renderer closest to the event target.
The event should either be swallowed by the first handler or in case it is disabled the next closest handler should be called, etc.
Actual Behavior
All ripple renderers that contain the event target will be launched at the same time.
Environment

Angular: 16.0.3
CDK/Material: 16.0.2
Browser(s): Chrome 113.0.5672.127
Operating System (e.g. Windows, macOS, Ubuntu): Windows 10

@preda7or When I try to follow the stackblitz link I just get an error. Could you provide a new link?

Closing this issue due to no recent activity, if this is still an issue please create a new issue with a reproduction.


Fix typos found by codespell and typos

@mittagessen, are there already any public models? I just tried to train one and had several issues:

I had to remove the option -f xml because it is unsupported.
The training requires additional Python packages (pip install . albumentations pillow-jxl-plugin torchao).
It then still fails with "AttributeError: module 'torch' has no attribute 'float8_e4m3fn'".

On 24/11/08 12:37PM, Stefan Weil wrote:

@mittagessen, are there already any public models? I just tried to train one and had several issues:

No, not yet. It will probably take another two to three weeks until I
get the base model pretrained as I got to pretrain the LLM decoder
first.
The code right now is in a research state. You probably won't be able to
train anything with it and there are much lower resource ways to do so
once I upload the pretrained model than the current code permits.


37 join project

you can join a project now as a user. The only thing i didnt implement yet is that the if the user has already joined the project and tries the key again that it will show that he already joined. But nevertheless it will show him the project so that works.
Not sure why it says it cant automatically merge

Codecov Report

Merging #37 into master will decrease coverage by 0.58%.
The diff coverage is 10.63%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   23.75%   23.16%   -0.59%
==========================================
  Files          39       39
  Lines         960      993      +33
  Branches      123      133      +10
==========================================
+ Hits          228      230       +2
- Misses        662      689      +27
- Partials       70       74       +4

Impacted Files
Coverage Δ

user-app/App.js
100% <ø> (ø)
:arrow_up:

user-app/src/components/Projects/projectInfo.js
0% <0%> (ø)

user-app/src/components/Projects/joinProject.js
0% <0%> (ø)
:arrow_up:

user-app/src/components/Login/login.js
33.33% <0%> (ø)
:arrow_up:

user-app/src/components/Login/auth.js
14.28% <100%> (ø)
:arrow_up:

user-app/src/components/Projects/keyValid.js
9.37% <9.37%> (ø)

user-app/src/components/Projects/projects.js

user-app/src/components/secondScreen.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215e3b4...d69b585. Read the comment docs.


test: get kvstore, debuginfo, and bugtool output

Get output of cilium kvstore get cilium --recursive in both runtime and
Kubernetes test suites.
Get debugtool output and bugtool archive for each Cilium pod in the
Kubernetes test suite.

Signed-off by: Ian Vernon<EMAIL_ADDRESS>Fixes: #2746
Fixes: #3006

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please


chore(deps): update common-dev-assets digest to 2e77009

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
7241dd8 -> 2e77009

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

:tada: This issue has been resolved in version 2.8.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


padding

Thanks for the great library. Just wanted to let you know that, though one of the listed options for your SmilesDrawer object is "padding," that value is in fact hardcoded:
// Add padding var padding = 5.0; maxX += padding; maxY += padding; minX -= padding; minY -= padding;
Would be nice to make it a true user-defined parameter when you get a chance. Thanks again!

You are welcome and thank you for your interest. This issue should have been solved with PR #69. Please feel free to reopen the issue if the problem persists.


Unable to find FirebaseCppApp-7_0_0

[REQUIRED] Please fill in the following fields:

Unity editor version: Unity 2019.4.11f1
Firebase Unity SDK version: 6.15.0
Source you installed the SDK: Unity Package Manager
Problematic Firebase Component: RemoteConfig
Other Firebase Components in use: Analytics
Additional SDKs you are using: Facebook、IronSource、IAP
Platform you are using the Unity editor on: Windows
Platform you are targeting: Android and iOS
Scripting Runtime: IL2CPP

[REQUIRED] Please describe the issue here:
(Please list the full steps to reproduce the issue. Include device logs, Unity logs, and stack traces if available.)
Steps to reproduce:
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?
What's the issue repro rate? (eg 100%, 1/5 etc)
I can not reproduce by Firbase Unity quickstarts。This error message occur in our own project as a sudden。Several days before i can build apk and run ok，but now the logcat output the error as title shown,and the remote config cannot be download any long
I have unzipped my apk, and find libFirebaseCppApp-6_15_0.so at lib/arm64-v8a、libFirebaseCppApp-6_15_0.so at lib/armeabi-v7a。The annoy thing is that why apk need version7_0_0
Also I checked Android Resolver Settings, also unchecked Resolution On Build
Also I checked my svn history,no any new or update for aar/jar recently
What happened? How can we make the problem occur?
If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.
Relevant Code:

Hi @iningwei,
It's dififcult to determine what might have started to suddenly cause this issue.  Perhaps one of your other imports has a dependency on Firebase version 7.0.0?  For instance, I searched for IronSource and noted that it has some sort of integration with Admob.  I'm not sure it's at the SDK level or in the backend, but it might be worth removing the other Assets that you're importing and add them back one by one, testing the build each time as you go.
I hope this helps.

Hi @iningwei,
It's dififcult to determine what might have started to suddenly cause this issue.  Perhaps one of your other imports has a dependency on Firebase version 7.0.0?  For instance, I searched for IronSource and noted that it has some sort of integration with Admob.  I'm not sure it's at the SDK level or in the backend, but it might be worth removing the other Assets that you're importing and add them back one by one, testing the build each time as you go.
I hope this helps.

Sorry no more can afford,now we quit use remote config,just use default value~

Still i'm facing the same issue in latest SDK , after adding Firebase latest SDK (7.1.0) in unity i'm facing the  log error unable to load Dll "FirebaseCppApp-7_1_0: The specified module could not be found.

Please can someone help me about it ? . if i integrate firebase in empty project its working well but when i integrate in my main project it giving me log error after build apk .

@iningwei
In your first post, you mentioned that you are using Firebase 6.15.0, but you are getting error related to FirebaseCppApp-7_0_0 which is from Firebase 7.0.0. Are you sure you are not mixing different version of Firebase in your project?
I would recommend you to reimport both RemoteConfig and Analytics from the same version of Firebase. If you are using Unity Package Manager, make sure Firebase App is in the same version as well.
Otherwise, could you provide the log when this issue occurs?
@itsfaisalali
As I mentioned above, this error usually occurs when you mix different version of Firebase in your project.
If reimport does not work for you, could you include a bit more information about your configuration, like the followin:

Unity editor version: _____
Firebase Unity SDK version: _____
Source you installed the SDK: _____ (.unitypackage or Unity Package Manager)
Problematic Firebase Component: _____ (Auth, Database, etc.)
Other Firebase Components in use: _____ (Auth, Database, etc.)
Additional SDKs you are using: _____ (Facebook, AdMob, etc.)
Platform you are using the Unity editor on: _____ (Mac, Windows, or Linux)
Platform you are targeting: _____ (iOS, Android, and/or desktop)
Scripting Runtime: _____ (Mono, and/or IL2CPP)

Also, logs would be helpful too!
Shawn

FYI, the way @google-oss-bot setup is that it will wait for the original author to response.  After a while, it would close the issue automatically.  This is one little tool to make our support rotation live a bit easier.
It does look like @ningwei  is no longer using Firebase.  I would assume there will be no more response from them.
@itsfaisalali I would actually recommend you to open a new issue and include your configuration in it, if reimport does not work for you.  This way, the bot will not close the issue until we resolve your issue.

FYI, the way @google-oss-bot setup is that it will wait for the original author to response. After a while, it would close the issue automatically. This is one little tool to make our support rotation live a bit easier.
It does look like @ningwei is no longer using Firebase. I would expect no more response from them.
@itsfaisalali I would actually recommend you to open a new issue and include your configuration in it, if reimport does not work for you. This way, the bot will not close the issue until we resolve your issue.

@chkuang-g  Thanks for reply . i reimport the firebase sdk in survival times but no success . you can check my actual issue briefly from here


Implement Base64 functionality

Implement encryption and decryption algorithm for base64

Hi, I'd like to work on this issue.


Typos and constant corrected.

I assume the scientific notation example is supposed to be Avogadro's Number.

Thanks so much! Can't believe I didn't look up that value. (It has been a long time since HS chemistry...)


Create 0000-01-02-deepakvenugopal81.md

Completing my introduction to gitHub

Vdksksk

Change in text


Rename resource to resourceType in ResourceDetail

Summary
Fixes #

Occurred changes and/or fixed issues

Technical notes summary

I'm identifying all instances of resource: in our edit components with the following
grep -rc --exclude-dir=node_modules/ 'resource:' shell/edit/ | grep -v ":0"
shell/edit/__tests__/monitoring.coreos.com.prometheusrule.test.ts:1
shell/edit/autoscaling.horizontalpodautoscaler/metrics-row.vue:1
shell/edit/autoscaling.horizontalpodautoscaler/resource-metric.vue:1
shell/edit/fleet.cattle.io.cluster.vue:1
shell/edit/logging.banzaicloud.io.output/__tests__/logging.banzaicloud.io.output.test.ts:1
shell/edit/management.cattle.io.projectroletemplatebinding.vue:1
shell/edit/monitoring.coreos.com.receiver/index.vue:1
shell/edit/monitoring.coreos.com.route.vue:1
shell/edit/networking.k8s.io.ingress/Certificates.vue:1
shell/edit/provisioning.cattle.io.cluster/import.vue:2
shell/edit/provisioning.cattle.io.cluster/index.vue:1
shell/edit/provisioning.cattle.io.cluster/rke2.vue:5
shell/edit/workload/mixins/workload.js:1
shell/edit/management.cattle.io.project.vue:2

Areas or cases that should be tested

Any components with an actual resource prop that might be dynamically rendered via:
https://github.com/rancher/dashboard/blob/f634802dfe32a7ebfaccefcc366a50d009900e74/shell/components/ResourceDetail/index.vue#L420-L435
It's difficult to assert that this is a safe approach without any form of contract between components that we can dynamically render and ResourceDetail.
We would also need to assert that any mixins associated with any given component does not also declare a resource prop.
Areas which could experience regressions

Screenshot/Video

Checklist

[ ] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[ ] The PR has a Milestone
[ ] The PR template has been filled out
[ ] The PR has been self reviewed
[ ] The PR has a reviewer assigned
[ ] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[ ] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@eva-vashkevich you've addressed a lot of regressions in edit components by adding inheritAttrs: false. Would you be willing to confirm that this change would have resolved the issue?

@richard-cox I'm adding you as a reviewer to get your feedback on whether or not we believe there to be too much risk associated with this change. My testing has been looking good up through this point, and I want to get a fresh perspective on this change.

This does seem to fix the issues I've worked on that were fixed with inheritAttrs

General approach looks good, the more eyes on this the better though.
I'd like to kick the tires a bit more before this merges

@aalves08 @mantis-toboggan-md adding you as reviewers so that we can more eyes on this change

This comment has additional information and a minimal repro to demonstrate the behavior:
https://github.com/rancher/dashboard/pull/11956#issuecomment-2364072848


STOR-1453: Bump(library-go): to get TLS ciphers from observed configuration

/hold
for testing

/retest

/close
in favor of https://github.com/openshift/gcp-pd-csi-driver-operator/pull/97


tabs scrollable bugs

tabs scrollable bugs after open or close devtools

@maystrenkoYurii do you have a minimal reproducible example?

Why? These bugs are also on your site, on the example tabs page. Open your site, go to tab tabs, open and close the developer panel and watch the bugs.
https://material-ui.com/demos/tabs/

@maystrenkoYurii I don't see the issues you described. Pleas fill out the issue template. Otherwise it's very hard to help you.

Not funny.... Appears after the opening and closing devtools

panel

What version of chrome are you using?

Latest version Google Crome

I can't reproduce it:

This happens when I follow these steps:

Open dev tools
Set size to 627 and 472
Press F12

@joshwooding We add some still to hide the scroll bar 🤔. Any idea what's wrong? I still can't manage to reproduce.

@oliviertassinari I'll have a look, I can't reproduce the scrollbar issue though, It also does depend on the screen with CSS issues so that might be why I can't produce it with my lower res screen

@joshwooding Oh, thanks; it's just a rendering issue with Chrome and the dev tool. I'm closing.

@oliviertassinari I thought as much 👍


Wrong pydantic type assigned for ManyToMany relation with ForwardRef

Hello,
Following on from the fix implemented in https://github.com/collerek/ormar/discussions/220#discussion-3394029, I am trying to create a Country with no borders referenced, however I seem to be getting Validation issues when attempting to create a Country. This is even though I have the borders field set to Optional, and with a default value of None.
I am not sure if I am doing this correctly, but any assistance would be greatly appreciated!
Thanks in advance
Model:
# models.py
class Country(ormar.Model):
    class Meta(BaseMeta):
        tablename = "countries"
        constraints = [ormar.UniqueColumns("name"), ormar.UniqueColumns("iso2")]

    id: int = ormar.Integer(primary_key=True)
    name: str = ormar.String(max_length=128)
    iso2: str = ormar.String(max_length=3)
    iso3: str = ormar.String(max_length=4)
    population: int = ormar.Integer(maximum=10000000000)
    demonym: str = ormar.String(max_length=128)
    native_name: str = ormar.String(max_length=128)
    capital: Optional[CityRef] = ormar.ForeignKey(CityRef, related_name="capital_city", nullable=True)
    borders: Optional[List[CountryRef]] = ormar.ManyToMany(CountryRef, default=None, skip_reverse=True)

Country POST handling with crud helper function:
# countries.py
@router.post("/", response_model=Country, status_code=status.HTTP_201_CREATED)
async def create_country(country: Country):
    return await db.create_update_entity(country)

async def create_update_entity(model: Model) -> Model:
       try:
            EntityModel = cls.get_entity_model(model)
            return await EntityModel.objects.update_or_create(**entity_kwargs)
        except Exception as e:
            print("Issue creating/updating entity")
            print(e)
            raise HTTPException(status_code=422, detail=f"Unable to create/update {model.__name__} entity.")

POST example:
{
    "name": "Thailand",
    "iso2": "TH",
    "iso3": "THA",
    "population": 23123123,
    "demonym": "Thai",
    "native_name": "Thailand"
}

Exception/Error raised:
Issue creating/updating entity
6 validation errors for Country
borders -> name
  field required (type=value_error.missing)
borders -> iso2
  field required (type=value_error.missing)
borders -> iso3
  field required (type=value_error.missing)
borders -> population
  field required (type=value_error.missing)
borders -> demonym
  field required (type=value_error.missing)
borders -> native_name
  field required (type=value_error.missing)

Originally posted by @josushiman in https://github.com/collerek/ormar/discussions/249

Fixed in 0.10.12 (via #251)


Initial hosted SE2 docs

Currently our SE2 docs mostly pertain to self-hosted SE2, so we need to instantiate docs for hosted SE2. More details to come!

Closed in favor of PR #


User Registration - Red MineIntegration

You'll need to create and update the config.yaml: REDMINE_KEY/SECRET_KEY and UI_API_KEY

hey @ssontag55 , this should live in the redmine user route, not in the ooi user route.  Then pull the needed info from the db (role, org, etc).

@ssontag55 Need to add back in the netcdf dependency.

@FBRTMaka Why does he need to move this?

My intent with this, as prescribed by the requirements, is that when a new user account is created a redmine issue is generated that tells  to enable his/her account.

That makes sense, so then you call the url_for(create_redmine_ticket) and supply the new user info

@ssontag55 , you should rework this code from the approach that we have a route for creating a ticket already.  Let the redmine/route handle the lifting and config.

I did that at first, but why have another level request when you can just
have 4 lines of code and call it in the same function?
Stephen
On Thu, Feb 19, 2015 at 1:28 PM, Matt Campbell<EMAIL_ADDRESS>wrote:

@ssontag55 https://github.com/ssontag55 , you should rework this code
from the approach that we have a route for creating a ticket already. Let
the redmine/route handle the lifting and config.
—
Reply to this email directly or view it on GitHub
https://github.com/asascience-open/ooi-ui-services/pull/216#issuecomment-75107832
.

@FBRTMaka @ssontag55 We can discuss where this sits another time.  Let's keep it where it is for now, and add it as a Bug in delviery 4.  We don't have time to rewrite the code, and I'm not overly sold that it is in the wrong place.
Let's get the Travis CI test fixed so it properly creates the user and see if Travis CI builds.  Once we resolve all TravisCI failures, we will merge the code.

Well, it's not really a matter of being in the wrong place but more so it's duplicating what we already have.  If it's written efficiently then the travis ci issue will go away.  But, just saying.  You're the boss!

No, the Travis CI test isn't creating a user properly (No First or Last Name, both required fields).  That's my concern.
If this could all be reworked by COB tomorrow and we could get everything else done, I would be all for reworking the code, but I don't see that as an option.

If this is trying to create a user, why is in the GET method and not the POST?

ignore that last bit

@FBRTMaka No worries, I always ignore you!

This needs REDMINE_KEY/SECRET_KEY and UI_API_KEY to create an issue, that is why it failed.  Should I push the key?

That doesn't sound like a good idea.

Which, is why it should use the route from the redmine blueprint...it has this all figured out already...

Do not push the key @ssontag55

@ssontag55
We have an error and a fail.  We need to get this hammered out tomorrow.  Error is a little weird to me, maybe i have an old version of the test.  failure is based off your recent changes.  I think the test is wrong though, not your code.


Upgrades to latest version of aws SDK

This allows using us-east-2 as a region for S3 buckets. Fixes https://github.com/s3-wagon-private/s3-wagon-private/issues/46 cc @sheelc

Looks good, thanks @leourbina !


add link to Carbon Svelte components on home page

This PR adds a link under "Other Resources" on the home page that links to the Carbon Svelte GitHub repository.
Changed

add resource card linking to Carbon Svelte components on the home page

I have read the DCO document and I hereby sign the DCO.


Base data service

Created a base data service for consuming REST endpoints

Whoops, I meant to do this in a separate pull request.


Harmonize ergocub FT sensor names with the one used in ergocub URDF

The PR https://github.com/icub-tech-iit/ergocub-software/pull/158 (that was released in ergocub-software v0.3.4) change the FT sensor names:

ergocub-software <= 0.3.3 names : l_arm_ft_sensor, r_arm_ft_sensor, l_leg_ft_sensor, l_foot_front_ft_sensor, l_foot_rear_ft_sensor, r_leg_ft_sensor, r_foot_front_ft_sensor, r_foot_rear_ft_sensor
ergocub-software >= 0.3.4 names : l_arm_ft, r_arm_ft, l_leg_ft, l_foot_front_ft, l_foot_rear_ft, r_leg_ft, r_foot_front_ft, r_foot_rear_ft

However, the wbd configuration files for the real robot were not updated accordingly. This PR should fix this.
Fix https://github.com/icub-tech-iit/ergocub-software/issues/165 .
Related to https://github.com/robotology/icub-models-generator/issues/242 .
Implements Option 1 (O1) as described in https://github.com/robotology/icub-models-generator/pull/240#issuecomment-1604172317 .

@traversaro If you agree, I would test it on the robot before approving it.

@traversaro If you agree, I would test it on the robot before approving it.

Sure!

CI is failing with:
[ERROR] |yarp.device.multipleanalogsensorsremapper| Impossible to find sensor name l_leg_ft_sensor , exiting.
[ERROR] |yarp.device.multipleanalogsensorsremapper|     Names of available sensors are:
[ERROR] |yarp.device.multipleanalogsensorsremapper|     *  l_foot_front_ft
[ERROR] |yarp.device.multipleanalogsensorsremapper|     *  l_foot_rear_ft
[ERROR] |yarp.device.multipleanalogsensorsremapper|     *  l_leg_ft

We need to change also the remappers.

CI is failing with:
[ERROR] |yarp.device.multipleanalogsensorsremapper| Impossible to find sensor name l_leg_ft_sensor , exiting.
[ERROR] |yarp.device.multipleanalogsensorsremapper|     Names of available sensors are:
[ERROR] |yarp.device.multipleanalogsensorsremapper|     *  l_foot_front_ft
[ERROR] |yarp.device.multipleanalogsensorsremapper|     *  l_foot_rear_ft
[ERROR] |yarp.device.multipleanalogsensorsremapper|     *  l_leg_ft

We need to change also the remappers.

This should be fixed by https://github.com/robotology/robots-configuration/pull/561/commits/4eb44616d83333b7f39ea825efc565776cc6342e .

Awaiting tests before merging then.
cc @isorrentino


increase randomness of passcode

addresses #1698

LGTM, better if you could squash the commits since first commit breaks tests.


Create alpha prototype of task-list

What
Work with community to create alpha prototype of task-list component.
Why
Part of ongoing task-list collaboration
Who needs to work on this
Community designer
Interaction designer assigned to collaboration
Who needs to review this
Feedback from team
Working Group - first review
Done when

[x] Get steering group together to filter out incompatible designs
[x] Run a workshop to decide on 2/3 design for alpha
[x] Plan workshop to run alpha by community
[x] Use community feedback to decide which version of alpha to proceed with
[ ] Prototype the alpha

Blocked until we run a session in a few weeks.


Some JavaScript stubs are not valid JavaScript

See, for instance, ada_lovelaces_note_g.js. This code will not run since the variables aren't defined using let or var before use, and the syntax for assignment/returning looks like Python syntax (improper use of the , operator). This issue is also present in some of the other JavaScript stubs.

Thanks for pointing this out!
Indeed I'm a Javascript noob haha but it's definitely no excuse to be misleading others by writing bad Javascript.
Will look into cleaning up the Javascript code stubs. If you have the time we would love your help!

I'll take a look at cleaning the JS stubs tomorrow. Unless you think I should do otherwise, I'll update the relevant ones to work assuming the list issue gets fixed on the engine side.

Sounds good! I'll have a look at https://github.com/project-lovelace/lovelace-engine/issues/85 in the mean time.


About timesteps_embeddings

Could you please explain the purpose of timesteps_embeddings in this code? Is it also necessary to include timesteps_embeddings in an AR model? Are there any related papers or ablation studies that support this? Thank you.
`        # seperate condition token for each step, at generation, we start from 1 to seq len
condition_token = condition_token.unsqueeze(1) + self.timesteps_embeddings[:, :x.shape[1]]
`

Hi,
This is because adaLN was originally designed for diffusion models; We consider the token location (as in AR image is generated token by token) to mimic timestep embedding to better adapt adaLN for transformer generators. It is a straightforward adaption to use adaLN for transformer models.


Update to reflect ponyc --version output change

As part of the recent cmake upgrade, the error where Compiled with: wasn't capitalized was fixed. It is now capitalized like Defaults: is.
Two tests started failing because of that as they are case-sensitive.

This will fix the nightly rests against ponyc master failing, however, PRs are run against release so this shouldn't be merged until the next ponyc release is done.