HBASE-26126 Backport HBASE-25424 "Find a way to config OpenTelemetry …

…tracing without directly depending on opentelemetry-sdk" to branch-2
3/17 commits of HBASE-22120, original commit 57960fa8fa7228d65b1a4adc8e9b5b1a8158824d

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 45s
branch-2 passed

+1 :green_heart:
compile
8m 44s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 19s
the patch passed

+1 :green_heart:
compile
8m 47s
the patch passed

+1 :green_heart:
javac
8m 47s
the patch passed

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 45s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

45m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3552

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile

uname
Linux 844874d93543 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ca096437d7

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
141 (vs. ulimit of 12500)

modules
C: hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/1/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 17s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 44s
branch-2 passed

+1 :green_heart:
compile
3m  4s
branch-2 passed

+1 :green_heart:
shadedjars
7m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 13s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 29s
the patch passed

+1 :green_heart:
compile
3m  2s
the patch passed

+1 :green_heart:
javac
3m  2s
the patch passed

+1 :green_heart:
shadedjars
7m 58s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
242m 33s
root in the patch passed.

289m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3552

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ed122d6f2ce8 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ca096437d7

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/1/testReport/

Max. process+thread count
3959 (vs. ulimit of 12500)

modules
C: hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 11s
branch-2 passed

+1 :green_heart:
compile
2m 39s
branch-2 passed

+1 :green_heart:
shadedjars
7m 56s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 46s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 42s
the patch passed

+1 :green_heart:
compile
2m 23s
the patch passed

+1 :green_heart:
javac
2m 23s
the patch passed

+1 :green_heart:
shadedjars
7m  2s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 31s
the patch passed

_ Other Tests _

-1 :x:
unit
320m 10s
root in the patch failed.

357m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3552

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bd93e65ef3a9 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ca096437d7

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/1/testReport/

Max. process+thread count
4476 (vs. ulimit of 12500)

modules
C: hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 53s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 50s
branch-2 passed

+1 :green_heart:
compile
9m 52s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 32s
the patch passed

+1 :green_heart:
compile
9m 23s
the patch passed

+1 :green_heart:
javac
9m 23s
the patch passed

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
12m 15s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

48m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3552

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile

uname
Linux 8e1433eb0088 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ca096437d7

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
141 (vs. ulimit of 12500)

modules
C: hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 18s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 10s
branch-2 passed

+1 :green_heart:
compile
3m 22s
branch-2 passed

+1 :green_heart:
shadedjars
8m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 25s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  0s
the patch passed

+1 :green_heart:
compile
3m 21s
the patch passed

+1 :green_heart:
javac
3m 21s
the patch passed

+1 :green_heart:
shadedjars
8m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
242m 31s
root in the patch passed.

288m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3552

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1992cb733be9 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ca096437d7

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/testReport/

Max. process+thread count
3919 (vs. ulimit of 12500)

modules
C: hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 36s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 27s
branch-2 passed

+1 :green_heart:
compile
2m 19s
branch-2 passed

+1 :green_heart:
shadedjars
6m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 25s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 19s
the patch passed

+1 :green_heart:
compile
2m 11s
the patch passed

+1 :green_heart:
javac
2m 11s
the patch passed

+1 :green_heart:
shadedjars
6m 26s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 25s
the patch passed

_ Other Tests _

-1 :x:
unit
309m 45s
root in the patch failed.

343m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3552

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e46d835fb084 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ca096437d7

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/testReport/

Max. process+thread count
5049 (vs. ulimit of 12500)

modules
C: hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

changing the base to HBASE-25853 as the feature branch of branch-2 for all remaining commits and PR of HBASE-22120, merging as the HEAD is the same as the branch-2 when opening this PR.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 17s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25853 Compile Tests _

+0 :ok:
mvndep
0m 29s
Maven dependency ordering for branch

-1 :x:
mvninstall
0m 11s
root in HBASE-25853 failed.

-1 :x:
compile
0m  8s
root in HBASE-25853 failed.

-1 :x:
shadedjars
0m  6s
branch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m  9s
root in HBASE-25853 failed.

-0 :warning:
javadoc
0m 30s
hbase-assembly in HBASE-25853 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

-1 :x:
mvninstall
0m  9s
root in the patch failed.

-1 :x:
compile
0m  8s
root in the patch failed.

-0 :warning:
javac
0m  8s
root in the patch failed.

-1 :x:
shadedjars
0m  6s
patch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m  9s
root in the patch failed.

-0 :warning:
javadoc
0m 10s
hbase-assembly in the patch failed.

_ Other Tests _

-1 :x:
unit
0m  9s
root in the patch failed.

5m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3552

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7dc294d8d353 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25853 / ca096437d7

Default Java
AdoptOpenJDK-11.0.10+9

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-root.txt

shadedjars
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-assembly.txt

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt

shadedjars
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-assembly.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/testReport/

Max. process+thread count
51 (vs. ulimit of 12500)

modules
C: . hbase-assembly U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25853 Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 35s
HBASE-25853 passed

+1 :green_heart:
compile
8m 45s
HBASE-25853 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
compile
8m 45s
the patch passed

+1 :green_heart:
javac
8m 45s
the patch passed

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 10s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

45m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3552

Optional Tests
dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile

uname
Linux 015748b28e92 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25853 / ca096437d7

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
141 (vs. ulimit of 12500)

modules
C: hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25853 Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 36s
HBASE-25853 passed

+1 :green_heart:
compile
2m 16s
HBASE-25853 passed

+1 :green_heart:
shadedjars
6m 20s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 24s
HBASE-25853 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 20s
the patch passed

+1 :green_heart:
compile
2m 17s
the patch passed

+1 :green_heart:
javac
2m 17s
the patch passed

+1 :green_heart:
shadedjars
6m 23s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 27s
the patch passed

_ Other Tests _

-1 :x:
unit
274m 57s
root in the patch failed.

308m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3552

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e179bcddbdfc 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25853 / ca096437d7

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/testReport/

Max. process+thread count
3870 (vs. ulimit of 12500)

modules
C: hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Errors when exporting win11

This means you don't have clang installed.  But last time I tried tup on windows there were some issues.  I'd try using CMake, following the steps in the Compiling guide.  (If CMake complains that you don't have a compiler, make sure you install at least the Visual Studio build tools first).


Simplify calculation of x and z in luv_to_xyz

Return from xyz_to_luv earlier if u and v are NaN

Looks good, thanks!


Transform for F# Pipeline

Q
A

Fixed Issues?

Patch: Bug Fix?

Major: Breaking Change?

Minor: New Feature?
Yes

Tests Added + Pass?
Yes

Documentation PR Link

Any Dependency Changes?
No

License
MIT

This is a transform for the F# proposal of the pipeline operator based on @mAAdhaTTah's parsing code.
It is basically the minimal visitor with support for paramless await. The most relevant lines are fsharpVisitor.js/44-47
TODO:

[x] dedup optimization logic between minimal and fsharp
[x] integration tests for paren-less arrow functions

Arrow functions don't require parens, so we def need tests to make sure those are transpiled correctly as well.

exec guarantees runtime behaviour. input/output can be used to check for optimizations that do not show up at runtime, for example.

Arrow functions don't require parens, so we def need tests to make sure those are transpiled correctly as well.

Yeah, that would be nice. I'll add some tests on that vein for integration testing purposes. But this is more of a parser concern, in my opinion. It would be nice to cover that more thoroughly in the parser tests.

It would be nice to cover that more thoroughly in the parser tests.

I think we've got it covered there, but I'd definitely be more comfortable if I saw the full transform here. We can then address that in the parser if we need to.

Trying to write parenless tests. What should g(1) be here? 2 or 4?
const y = 2;
const g = (x) => x
  |> (y) => (
    y + 1
    |> (z) => z * y
  )

Yeah, Nicolo pointed out the same issue on the parser PR. I think that's a bug I'll need to address; in the last arrow, y should not be in scope.

Oh wait, you're writing this with parens... so that's a different issue.

Ping me on slack to discuss this, probably easier that way.

Nicolo pointed out the same issue on the parser PR.

Yeah. I stole Nicolo's code from there.
😜

Ping me on slack to discuss this

For anyone following this, we've discussed it and came to the conclusion that g(1) should be 2.

Updated to latest parser and did the initial clean up. I will port this PR to the main babel repo once the parser PR gets merged.
I still plan on deduping the arrow function optimization logic between this and minimal.

I think we've got it covered there, but I'd definitely be more comfortable if I saw the full transform here. We can then address that in the parser if we need to.

Regarding that, do you think the added test is sufficient to address the concerns you raised?

Yeah, this looks great! Thank you so much for working on this.
This is finally happeninggg! Makes me really excited for the possibilities of the proposal itself.

Deduped optimization logic between fsharp and minimal. Please let me know what you think.

Oops... Fat-fingered the PR branch. Reopening...

LGTM! Looking forward to getting this all in place.

This was moved to the main repo as babel#9984


Dlp redux

Update one sample https://github.com/GoogleCloudPlatform/dotnet-docs-samples/blob/master/dlp/api/DlpSample/DeIdentify.cs#L28
and its test to the proposed canonical form.

First thoughts after reading through DeidentifyMasking... 2¢

Looks fabulous! tada

I adore having 1 file per sample, so it can include the imports easily and everything! And I love that the sample uses real values, so this sample runs ok_hand without a developer having to add their own values!

There is no description of what the sample does, e.g. "De-identify sensitive data in text content"

Added.

This could, for example, be added as a method comment on DeidentiyMasking(...)

There is no description of the method parameters the sample accepts, e.g. projectId

Added.

This for, for example, be added as <param> method comment on DeidentiyMasking(...)
For projectId, the user can see a default value of "YOUR-PROJECT-ID" provided; uncertain of the readability of this vs using param documentation, which is familiar to developers

Why is the class partial? <-- something which "surprised" me when I read through; unexpected & I have no idea why (I would have to dig around to figure it out)

For convenience maintaining the code.  The tests are simpler because they don't have to instantiate a little new class for every test.  The translate sample was the former canonical sample and that's what it does.  It also makes the code easier to write.  First, I don't have to choose what to name the class.  Second, when it's time to write a new sample, I just copy an old .cs file and the class name is one less thing I have to update.
I'm surprised the partial class was so distracting.

Nit: What is using Google.Api.Gax.ResourceNames; needed for?

It's a pretty gnarly using statement imo. "What is Gax? Why Google.Api not Google.Cloud?"
Library feedback, not so much sample

I don't see how I can improve this.

Could y'all add comments to help provide a readable outline/structure of the sample?

It's a lot of text to look at without comments helping me break it down into sections. Comments like these would be helpful:
// Instantiates a client
// Construct Request
// Execute Request
// Process Response

Done.

// Imports the Google Cloud Data Loss Prevention library

I find such a comment does not tell me anything that the code already does not tell me.  A using statement does only one thing in C#.  I think in other languages, a comment here is more appropriate.

To my eyes, it's non-trivial/quick for me to pick out the parts of the sample that I, as a developer, care about...

That is to say: the INPUT to the API which I'll want to edit to running the request with my own data. For this sample, the values which my eyes have trouble picking out are: Item.Content.Value and InspectConfig.InfoTypes[0]
Could these be moved into variables near the top of the sample method? e.g.

public string DeidentiyMasking(string projectId = "YOUR-PROJECT-ID")
{
  var infoTypeName = "US_SOCIAL_SECURITY_NUMBER";
  var contentText = "My SSN is 372819127.";

  // ... the rest of the sample, as is .... using the variables ...
}

Done.

Also, I restored all the old files so that we can merge this PR when we agree this one sample looks like the canonical sample we want.  That way, we don't have to migrate all the code to unblock others like Alix who need a stable canonical sample yesterday.

partial class

[the class is partial] For convenience maintaining the code. The tests are simpler because they don't have to instantiate a little new class for every test.

Would it be OK for us to "instantiate a little new class for every test"? Seems like an easy fix. This way the class can be a familiar public class ProductSnippets 🙂

Do you happen to know what Google.Api.Gax.ResourceNames is needed for?

None of the other samples in dotnet-docs-samples use this namespace. And very few how-to samples (3 individual snippets) use the Google.Api.Gax namespace at all.
I can take this feedback back to the C# Client Library team

// Imports the Google Cloud Data Loss Prevention library

The comment could be useful to sample templates in a number of ways

a. Clarify which namespaces being imported are required for the client library, versus SDK imports
b. Using the secondary comment // Import other required libraries helps clarify imports needed to perform additional required functionality in the sample, e.g. Base64 encoding/decoding, File reading/saving, etc.

^--- see this currently proposed Node sample for an example of this:

I incorporated all the comments from the meeting and added an InspectFile sample.


Generate and use SSH key internally even for static hosts.

Opening this PR to discuss whether it's appropriate to do this for static hosts.
It's convenient if the user hasn't already configured a common SSH keypair on all hosts, and convenient for SSH-ing into openstack compute instances from the host, because this key gets added as a nova keypair.
But.. if a common keypair was already installed (for this ansible_ssh_user) then it'll overwrite it.
Is that bad?
The workaround would be copying the desired keypair to romana_id_rsa and romana_id_rsa.pub before installing, or creating a different user on the hosts.

Ok

I think this is the correct balance: install the generated key onto the host if no public/private keypair files already exist. If either already exist, then we skip this step.
No error or force option, just a reasonable default.

looks good to me.


More extendable Scaffolder page

Hey, I just made a Pull Request!

We recently extended scaffolder page and it would be really nice to have a possibility to change also header and subheader as well.
I also added export of routes to have a possibility to use those when creating custom TemplateCard
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thanks for the proposal! This PR needs an updated API report. I will need to defer to @benjdlambert if this is a desired level of customisation for the ScaffolderPage.

As an idea we can also pass scaffolder route refs inside TemplateCard as a prop instead of exposing them so they can be used in custom cards.


Added missing metadata to pom.xml

The Sonatypoe OSS repository requires us to add more metadata to the pom.xml.
http://central.sonatype.org/pages/requirements.html

Merging this without explicit approval, because the change is straight forward.


:seedling: Combine hasLicenseFile and hasLicenseFileAtTopDir probes

What kind of change does this PR introduce?
probe cleanup

[X] PR title follows the guidelines defined in our pull request documentation

What is the current behavior?
There are 3 license probes, but 2 of them (hasLicenseFile and hasLicenseFileAtTopDir) always exhibit the same positive/negative behavior so there are effectively only 2 license probes.
What is the new behavior (if this is a feature change)?**

hasLicenseFileAtTopDir is deleted
ensure license findings use the license file locations
finding logging is simplified using the standard checker.LogFindings function

since hasFSFOrOSIApprovedLicense can sometimes return OutcomeNotApplicable, this converts one message to a DEBUG message. But its identical to the WARN message already produced by hasLicenseFile.

before:
"details": [
        "Info: project does not have a license file",
        "Info: project does not have a license file"
      ],

after:
  "details": [
        "Warn: project does not have a license file",
        "Debug: project does not have a license file"
      ],

[X] Tests for the changes have been added (for bug fixes/features)

Tests modified at least
Which issue(s) this PR fixes
Fixes #3590

Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Reduced duplicate logging messages related to License details.

/scdiff generate License


Migrate REP modal

Desktop:
https://www.figma.com/file/bZh7tOiLm6Ls9Hl4RL6qMC5X/Augur-Redesign?node-id=12884%3A109
Mobile:
https://www.figma.com/file/bZh7tOiLm6Ls9Hl4RL6qMC5X/Augur-Redesign?node-id=12888%3A2312
For both desktop and mobile:

[x] Update the description copy "Migrate your V1 REP to V2 REP to use it in Augur V2. The quantity of V1 REP shown below will migrate to an equal amount of V2 REP. For example 100 V1 REP will migrate to 100 V2 REP." HIGH
[x] Update the learn more button, it should just be text and icon Low - but do it if quick!
[x] Remove the 'V2 REP balance' box HIGH
[x] Centre the 'v1 rep' box HIGH
[x] Update the copy in the 'v1 rep' box -> "V1 REP to migrate" HIGH
[x] Update transaction fee color HIGH
[x] Centre the transaction info message below and update the copy **Low - but do if quick!"
[x] Update the 'convert' button copy to 'migrate' HIGH
[x] Check that text styles and colors match figma **Low - but do if quick!"

Desktop

Mobile

modals look correct and updated - closing


MINOR: Add 3.0 and 3.1 to broker and client compatibility tests

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

System test: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4758/

There are failures in the system tests but they are not related to this change. All the tests changed in this PR have passed. http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2022-01-24--001.system-test-kafka-branch-builder--1643039583--dajac--minor-update-broker-client-compat-test--68c0eaf80/report.html


User Authentication

Currently users are "signed in" without any authentication. They just give their git username and are able to comment as that user. This can be a problem because any person can use anyone's git username to show up as that person.
Authentication with GitHub or another service will make sure that the person who is commenting or creating threads is actually that person.

This will help pave the road for #23 by linking to an external API to help with notifications and mentions.

Another idea could be linking the username with the JupyterHub id when running through JupyterHub


Create Modules.md

[X] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
This swaps the outdated and unsearchable Modules.xlxs with an updated and searchable Modules.md
Why should this Pull Request be merged?
Updates c-Series module support and converts the format to markdown.
What testing has been done?
document preview

documentation update for supported modules
replace outdated XLXS file with updated MD file

@dbendele can you update docs/Adding New Modules.md to include updating this file?
I also am leaning towards this documentation being moved to the top level docs/ directory to make it more discoverable... @Karl-G1, thoughts?

@dbendele can you update docs/Adding New Modules.md to include updating this file?
done

I also am leaning towards this documentation being moved to the top level docs/ directory to make it more discoverable... @Karl-G1, thoughts?

Karl was also in favor of elevating the location of Modules.md. That 'entire' directory should probably disappear. He said that could happen in a later housekeeping effort.


Mods to showcase how to test out new bootstrap-shell API loadDefaultP…

…ortal
Leverage new expected loadDefaultPortal method when it is available.  Keep using Traditional APIs if not there yet.

One thing I noticed while testing this is that the message that's written to the console by config_access when I have an empty "appPortal" in sdk-config.json says:
Using appPortal: MediaCo
So, this isn't caused by the this PR but I realize it's confusing given the similarity to the new messages. In the past, I think an "empty" appPortal in the config meant that we used the default portal. So, maybe we set appPortal to that default. If these messages are going to need to be documented, we should think about changing the message written by config_access to just say something like "Using portal: " to reduce confusion about what the value of appPortal actually is.

I adjusted message so it now should say:
Using non-excluded portal: MediaCo
...so this might be a different message.  Prior intent was to have these two messages be the same.


Need a reliable method to destroy the editor

Need a reliable method to destroy the editor
Thanks

me too

Please open this issue over at https://github.com/bootstrap-wysiwyg/bootstrap3-wysiwyg


docs: remove godoc link

I'm not sure if the Godoc badge is required considering this isn't a Go pkg and the current Godoc doesn't seem necessary

oops yea just my readme template haha

that's what I was guessing hah


Changing Graph Type

When you change graphs types after making a certain line invisible it most likely will break completely, or show some of the bars/points/lines. Its a little hard to explain but if you make a line invisible then switch graph types you will see what is happening. I think this might be an issue with the scatter plot because that one doesn't show up on mine. The line you disable doesn't show up.

Yeah this is part of a previous issue, I'm working on it. Getting closer. Should have it fixed by the end of the day

Hide persistence has been fixed

The graph still does't show up for scatter.
Below is what the graph looks like as well as the error I got when I go to the scatter after disabled a newly added row of data in the bar graph:

The graph still does't show up for scatter.
Below is what the graph looks like as well as the error I got when I go to the scatter after disabled a newly added row of data in the bar graph:

Fixed scatterplot error. Need to work on making scatterplot only circles

The scatterplot works now. (The graph isn't blank anymore.)
Also, while changing to another graph type with the row unchecked, it doesn't show up, at first, on the next graph when enabled.
This is the error I've got while doing that:
[Error] TypeError: undefined is not an object (evaluating 'chart.datasets[row-1].points[col - 1]')
(anonymous function) (slickTable.js, line 107)
notify (slick.core.js, line 126)
trigger (slick.grid.js, line 1015)
execute (slick.grid.js, line 3185)
commitCurrentEdit (slick.grid.js, line 3206)
commitCurrentEdit (slick.core.js, line 451)
handleClick (slick.grid.js, line 2291)
dispatch (jquery-1.11.2.js, line 4665)
dispatch (jquery.event.drag-2.2.js, line 374)
handle (jquery-1.11.2.js, line 4333)

I noticed this morning the scatter plot does not allow line color change. Is this a feature or a bug?
If you try to change the color for scatter nothing happens, then if you change to bar or line the color shows up, then if you change back to scatter the color will still be there. It just doesn't change color initially.


add support for sessionToken

When the S3 resource upload is set with sessionToken access rights, the file upload will fail

Thanks for the contribution merging it. Will publish new version in 12 hours.

Hi can you take a look at this use case
https://github.com/Yoda-Man/aws_s3_upload_lite/issues/5


Odd filter difference between Nest and Sense

In my nest code, I have the following code:
        var unresolved = _sourceElasticClient.Search<SearchTrackWithDevice>(s => s
               .Query(q => q
                   .Filtered(fq => fq
                       .Filter(f => f
                           .Bool(b => b
                               .Must(m => m
                                   .Missing(mis => mis
                                       .Browser.BrandName))
                               .MustNot(mn => mn
                                   .Term(t=>t.UserAgent, string.Empty))))))
                                   .Aggregations(ag=>ag
                                       .Terms(UserAgentTermAgg, t=>t
                                           .Field(f=>f
                                               .UserAgent)
                                               .Size(NumberOfTerms))));

I am specifically excluding records with an empty UserAgent string.  This field is not analyzed.
Those records with an empty UserAgent are being returned in the aggregation.
With this in Sense, I am getting the results I would expect.
GET searchtrackinfo/SearchClickWithBrowser/_search?search_type=count
{
"query": {"filtered": {
"query": {"match_all": {}},
"filter": {
"bool": {"must": [
{"missing": {
"field": "browser.brandName"
}}
], "must_not": [
{"term": {
"userAgent": ""
}}
]}
}
}},"aggs": {
"userAgentTermAgg": {
"terms": {
"field": "userAgent",
"size": 1000
}
}
}
}
Those records without the user agent are being excluded as expected.
I am currently running 1.4.2 elastic and also using the 1.4.2 Nest client.
Thanks in advance

Hey @djnelson9715 this behavior is due to the conditionless construct was added to NEST in 1.0: https://github.com/elasticsearch/elasticsearch-net/issues/414.  Check out this blog post for a good explanation of the feature.
You can disable it by adding .Strict() to the query:
 .Query(q => q
     .Strict()
     .Filtered(fq => fq


fix #103

@ntrp FYI - I implemented something quick on my end

any known/planned release with the fix?

I'm on it right now: https://github.com/conduktor/kafka-security-manager/actions/runs/892252296

@simplesteph ok thank you very much, I was supposed to come back from vacation last week but my wife derailed everything to go to the sea so I am working remotely and have no extra time right now ^^'. When I find some time will try to add an integration test to avoid this problems in the future.


Add keyboard accessibility enhancement

This PR adds keyboard accessibility to react-slider (and closes #41).
refactors

_move() now takes a new slider value (used to take a mouse position)
_move() logic for calculating value and position diff are moved into new functions

_getValueFromPosition(position) returns a corresponding slider value
_getDiffPosition(position) compares the argument to state.startPosition and inverts if needed

_onMouseMove() and _onTouchMove() now use these new functions and pass a value to _move()

additions

add _moveUpOneStep() and _moveDownOneStep() functions
add tabIndex and aria-* attributes to handle
add _onKeyDown(), _onBlur(), _getKeyDownEventMap(), and _createOnKeyDown()

_createOnKeyDown() is called on focus
_onBlur() is called on focusout

misc

don't blur the activeElement if it's the currently active handle's ref

Thanks for working on this @B-Reif! Is this supposed to work with example in index.html or it needs to be updated? Because I can't change the slider value with arrow keys using the example. Tested on OS X with Safari and Chrome.

I just tested it with Chrome without any issue. Are you able to tab-focus the slider handles, and then the keybinds aren't working? Or can you not even tab to them?

Just checked again and it worked this time after setting a focus with tab.
It looks like Y-axis is reverted, i.e. up arrow moves the slider down and down arrow up. Is this intentional? I'd expect that it worked the other way around.

I was going by examples from http://oaa-accessibility.org/example/32/ where Up/Left always decrements and Down/Right always increments.
The vertical slider example has invert: true so the arrow key functionality seems backward; it works as expected if it's not inverted.
We can flip the arrow key functions if invert: true. This might cause some confusion for blind users though. Let me know which way you'd like to go.

We definitely should stick to accessibility standards. Looks good to me. Can you just add missing semicolons? Then I'll merge. Thanks!

Ok, should be good to go.


adding global options to all models after generation

so i'd like to add hooks & classMethods to every generated table (in my case, i added some code to custom code to the generated models/index.js
var globalOptions = {
    classMethods : {
        findByGUID: function(guid, attributes, includes) {
            return this.find(_.extend({
                where: { guid: guid },
            }, [{ attributes: attributes }, { includes: includes }]));
        }
    },
    hooks: {
        afterFind: function(instance) {
            if(!instance) { throw new Error("No instance with specificied guid!");}
            return instance;
        }
    }
};

then changed, defineModel() to =>
function defineModel(file) {
    var object      = require(file),
        options     = _.(object.options || {}, globalOptions),
        modelName   = object.modelName;

    fs.writeSync(debugFD, 'var ' + modelName + ' = Sequelize.define("' + modelName + '",\n' + util.inspect(object.attributes) + ',\n' + util.inspect(options, {depth: null}) + ');\n\n\n');

    models[modelName] = sequelize.define(modelName, object.attributes, options);
    if (object.relations !== undefined) {
        relationships[modelName] = object.relations;
    }
}

Obviously i'd rather not modify generated code, and since this code is intended to the same for every model, i wont' want to duplicate it in every /definition-files-custom/[table.js] file.
is there a better way, or hopefully you could add one?

sequelize-pg-generator does not have this feature. However all code is generated via templates, so you can try to write custom templates. Have a look in template folder.
If it solves your problem, please post a message how you solved it for others.


Support for Unreal 5

Fixing support for Unreal 5
⚒ WIP
Close #3101

We are now missing support for ue 4.2x (we will probably need to retain two versions of integration plugin). And rendering is not working #3207


Dynamic export formats

Short description

Allow export to other formats supported by tablib / django-import-export
We were troubleshooting what looked like an encoding problem with feedback exported as CSV, and by the time we found that EXCEL was at fault and our CSVs were flawless, this was already half done. I figured I might as well clean it up and submit it as a low prio PR.
Proposed changes

Extend feedback export URL endpoint by format parameter
Check if requested format is available through the dependency library
Automatically determine mime type

Side effects

We just throw a ValueError if the format is not available. This is likely not the most elegant solution, but at the moment we hard-code which format can be requested through the UI anyway.

Resolved issues

none

Pull Request Review Guidelines

Is this to fix the problem reported here?

@MizukiTemma More or less. The fix is to trick EXCEL into actually reading it as UTF-8. But this was the related discussion that resulted in this PR, yes.

Ah, and one last information I forgot to mention. The length of your commit message is currently at 72 characters. I was wondering, if this might be to long. However the Linux kernel documentation says:

For these reasons, the summary must be no more than 70-75
characters, and it must describe both what the patch changes, as well
as why the patch might be necessary.  It is challenging to be both
succinct and descriptive, but that is what a well-written summary
should do.

So apparently this is not an issue. I just wanted to mention to you that it was something I thought about, and let you know what made me decided not to make it part of my review :)


Project Level Whitelisted Bot

Summary
Project managers would like to whitelist a bot for their project.
Background
TODO - add more details
Additional Notes:
Ha, interesting topic. Different approaches were discussed: If they want
dependabot to be whitelisted, we can create a solution in EasyCLA without too
much difficulty.  This could easily be a Project Management console
configuration item (for the repos).
David Deal 2:34 PM on 01/07/2019
On the EasyCLA project side, we can implement whatever the legal team decides.
An elegant solution would look like (assuming they want to leverage the
whitelist solution) - pending legal team review and approval:

Project Management Console: - add an option to allow Project Managers to
whitelist the dependabot…or greenekeeper bot or whatever - just need the GH ID
details fo the bot - bot list is a fixed list defined by the EasyCLA team approved by the legal team (not dynamically added by PM's).
Project Management Console: add edit/management control to enable/disable
after the project is created - default is off for existing projects
The bot details will be stored with the project/CLA Group configuration
(along with the CLA template).
We will modify the CLA check logic to check the flag to determine if the bot
was whitelisted: repo -> project lookup -> bot whitelisted flag -> yes/no -> if
no, continue with ICLA + CCLA checks.

User Story
As a project manager, I want to whitelist a bot for my entire CLA Group.
Acceptance Criteria
The "done" criteria when this feature or problem is resolved. Such as:

Unit Tests added and running in CI
Functional Tests updated to cover feature, if applicable
Demonstrate the set of capabilities to the product team while the code is running in the STAGING environment.

References
(Optional) Provide any code or specification references that would be helpful for the developer implementing this feature.

I encountered this issue in messageformat/gettext-to-messageformat#3, with the GitHub Dependabot. To be clear, that repo is still using jsf-clabot, but it'll be switching to easycla once that's available for OpenJS projects.
Possibly relevant here is this section of the Dependabot terms:

Intellectual Property
As part of providing the Service, Dependabot generates software code contributions to the customer's repositories. For the avoidance of doubt, Dependabot grants to each customer a non-exclusive, worldwide right or license to perform, display, and use the contributions and any content contained in, accessed by or transmitted through Dependabot to customer's repositories.

Given the above, I would like for the whitelisting of Dependabot to happen automatically, without me needing to configure anything.

Moved to post V2 LFX integration.


thousands separator same as floating point

goaccess 1.5.1 macos 11.4
When generating html reports, numbers in the columns look like this:
207.286 (8.80%)
the man page does not mention locales at all, but in any case i have:
$ echo $LANG
C

I think in this case the number should look like any of these:
207,286 (8.80%)
207 286 (8.80%)
207_286 (8.80%) (some programming languages accept these numbers nowadays)

btw it would be really nice to have the thousands separators in the terminal version as well...

The formatting is done through LC_NUMERIC. You can try changing/setting the env variable for LC_NUMERIC.
# export LC_NUMERIC="en_US.UTF-8"

or
# LC_NUMERIC="en_US.UTF-8" bash -c 'goaccess access.log --log-format=COMBINED'

hm. i don't have LC_NUMERIC set. i thought LC_something is not set, LANG takes precedence, but i might be wrong...  i give it a try, thank you.

$ LC_NUMERIC= goaccess -p .goaccessrc log.2021-05-01 -o log.2021-05-01.html
 [PARSING log.2021-05-01] {2401556} @ {66860/s}

$ LC_NUMERIC=en_US.UTF-8 goaccess -p .goaccessrc log.2021-05-01 -o log.2021-05-01.html
 [PARSING log.2021-05-01] {2,399,617} @ {66,656/s}

the terminal indeed printed correct thousand separators.  however the generated html is the same in both cases:

4.506 (0.53%)
30 (0.04%)


Updated Newtonsoft.Json from 10.0.2 to latest to fix security vulnerability.

Pull Request Template
Description
This project referenced an outdated version of Newtonsoft.Json (10.0.2) which had a vulnerability introduced on 24 Apr 2022.
For context, quoting the description from the nist.org page:

Newtonsoft.Json before version 13.0.1 is affected by a mishandling of exceptional conditions vulnerability. Crafted data that is passed to the JsonConvert.DeserializeObject method may trigger a StackOverflow exception resulting in denial of service. Depending on the usage of the library, an unauthenticated and remote attacker may be able to cause the denial of service condition.

For consistency, other projects that also use Newtonsoft.Json were brought up to the same version.
No other changes were made to the code.
References

Snyk: https://security.snyk.io/vuln/SNYK-DOTNET-NEWTONSOFTJSON-2774678
CVE- 2024-21907: https://www.cve.org/CVERecord?id=CVE-2024-21907 / https://nvd.nist.gov/vuln/detail/CVE-2024-21907
CWE-755: https://cwe.mitre.org/data/definitions/755.html

Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)

Closing issues
To automatically close an issue: closes #IssueNumber

Considering the point made by @FabianMeiswinkel, I'm closing this PR, since it wouldn't make much sense to update some, but not all the package versions, because the overall project would still be left vulnerable, and still generate alerts by code analyzers (such as Snyk, and SonarCloud).

Hi all involved,
Is there a plan on how to treat vulnerable dependency versions?
To be frank, I am not sure why would a major dependency version upgrade mean also a major release for the SDK. But besides this point, Newtonsoft.Json does not really adhere to the semver, as its minor version is always "0". So upgrading from 10.0.2 to 13.0.3 is not a major version upgrade in a semver sense.

@RockyMM the problem is that between 10.0.2 and 13, there were breaking changes in Newtonsoft.Json.
We cannot bump a dependency that has breaking changes on a minor version upgrade of the SDK.

@RockyMM the problem is that between 10.0.2 and 13, there were breaking changes in Newtonsoft.Json.
We cannot bump a dependency that has breaking changes on a minor version upgrade of the SDK.

Hello,
In my opinion, the problem is two-fold:

the library uses vulnerable versions of existing libraries, mentioned are Newtonsoft/System.Net.Http/System.Text.RegularExpressions and IIRC there is another library as well that has issues.
the library works from the assumption that we want to use Newtonsoft.JSON to serialize, rather than system.text.json or something else entirely. In my opinion, a NuGet package shouldn't include items the end user doesn't necessarily need.

In my employer's implementation of the Cosmos library, we use system.text.json for everything rather than Newtonsoft.  We also use a custom CosmosSerializer to get that to happen. But, because of this library, we still carry a needless (!) faulty version of the library in our builds. We also probably use some of those vulnerabilities from the other libraries. Granted, the code on production goes from an Azure Web App to Cosmos and back on the same region using a connectionstring acquired from a KeyVault, so I doubt anything can go wrong, but still.
If possible, could it be done that a major revision will get in the works for a quick release with the intent to:

fix the library issues
allow the end user to choose their JSON usage, with very small NuGet packages that contain nothing more than a Newtonsoft/system.text.json serializer. (the end user can also decide to use neither to allow one to create their own custom CustomSerializer)

Thank you!

@Lucasharskamp

The library uses Newtonsoft.Json, even if you use System.Text.Json or other custom serialization engine for your Data Plane operations, Newtonsoft.Json is used for metadata and service calls.
If you read the Security Notice it says that upgrading is just one way to fix the security issue.

To mitigate the issue one either need to update Newtonsoft.Json to 13.0.1 or set MaxDepth parameter in the JsonSerializerSettings. This can be done globally with the following statement.

We cannot upgrade the dependency to 13.0.1 because it poses breaking changes to customers. Following SemVer, the only way to push a change that creates a breaking change is to bump the Major Version, so this is only possible in a 4.X SDK, not 3.X.
We already fixed the library issue, every place the library uses Newtonsoft.Json, has the MaxDepth set. So from the security perspective, the library is secured. If your application does not use Newtonsoft.Json, then based on the Security Notice, your application is secured. If there is tooling that decided to enforce nuget package versioning when the security notice clearly says that that is only one of the options, that seems to be a gap in the tooling analysis. If your application uses Newtonsoft.Json, then you can decide to either bump to 13.0.1 and address the breaking changes or use MaxDepth in the places you interact with Newtonsoft.Json.

@ealsur Thank you! That resolved my issue as well, just putting the Newtonsoft.Json most recent version together in the same assembly as where I azure Azure.Cosmos did the trick.


convert windows path delimiter to posix (#2149)

Fixes #2149
When generating lwip file system data convert windows directory separators by posix separators.
This is an issue when native directory during resource generation separator is "\" as on windows. Running toolchain from mingw64 python3 would also preserve "\" in resource name which would cause mismatch on resource lookup.
Fix should be portable with python 3.4 and up.

ping @ndabas , in light of the work he did in #1841

added explicite posix conversion result variable https://github.com/raspberrypi/pico-sdk/pull/2150/commits/3a7f95dfff7339344d0173c9b8e90f2bee8eba05


Add Universe Selection feature in QuantBook

Expected Behavior

In QuantBook, it should be possible to use the Universe Selection feature.
Actual Behavior

Not supported.
Potential Solution

N/A
Reproducing the Problem

N/A
System Information

N/A
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

We're back and forth on this one's design;

Concept 1 is to make notebooks an algorithm in an engine, where the engine steps through time. The advantages are lower maintenance and all the existing APIs would work immediately. The weirdness is that its a very nonstandard way to do interactive research that would require the user to step through time.

Concept 2 is to make new batch-focused helper methods for each primary API method and do history requests and data frame conversions to get all the data into a friendly format. This is the current design.

Typically we'd be plan 1, but it feels strange and not jupyter friendly.
Leaving open; a solution with the current design would be to make a helper like this:
symbols = GetUniverseSelection(date, filter Coarse, filterFine)
Then the community could load the history for those indicators and do any batch analysis they prefer.
We've been hesitant to implement because its further down a pathway that requires heavier maintenance and new API methods.

To avoid a look ahead bias without a universe of stocks for each date,, how would one create a dataset for machine learning to train our models on fundamentals data? using arbitrary symbols creates look ahead bias since we need to access delisted symbols from past years to build the dataset without lookahead bias

Hi!
What about a combination of Concept 1 and Concept 2. When creating a Universe Selection, run through time and keep tabs on which symbols went into the Universe as defined in a coarse/fine function as well as interesting data. With this table of date, symbol, data1, ... dataN, the Jupyter can be filled.
Currently, a backtest, the data storage (with a subscription), and Jupyter notebook can be used for such an endeavour.
Best


robot framework builtin function does not support multiple thread?

class Test(object):
def __init__(self):
    self._thread_pool = {}

def run_keyword(self, keyword, *args):
    BuiltIn().run_keyword(keyword, *args)

#def runner(self, keyword, *args):
#    print keyword
#    BuiltIn().run_keyword(keyword, *args)

@keyword
def run_keyword_async(self, keyword, *args):

    def runner(*args):
        BuiltIn().run_keyword(keyword, *args)

    t = threading.Thread(target=runner, args=args)
    t.start()

I write the above program, it seems does not work when I call  Test.Run Keyword Async (report error that cannot find out argument); however, it works if I call Test.Run Keyword, what can I do to fix this issue?

Robot Framework isn't thread safe and thus running keywords in parallel isn't possible. We already have issue #1792 about this. With the limited development resources we unfortunately cannot give any estimates when this could be fixed.


Support for /meta-data/instance-life-cycle

is there a plan to support for /meta-data/instance-life-cycle?

hey @petrukngantuk, I confirmed this is definitely a valid path on my ec2 instance, but not seeing it in the documentation. Out of curiosity, how did you come across this path?
I'll do some research on my end to see if this is a one-off addition or if it's one of many paths that need to be added so we can batch appropriately. From there, I can provide a better answer as to if/when we can support /meta-data/instance-life-cycle
For future reference:
[ec2-user@ip-172-31-34-43 ~]$ curl http://<IP_ADDRESS>/latest/meta-data/instance-life-cycle
on-demand[ec2-user@ip-172-31-34-43 ~]$
[ec2-user@ip-172-31-34-43 ~]$ curl http://<IP_ADDRESS>/latest/meta-data/instance-life-cycle/on-demand
<?xml version="1.0" encoding="iso-8859-1"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
	"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

  <title>404 - Not Found</title>

404 - Not Found

Well when I use mixed asg on-demand n spot instance in our eks cluster
When instance type on-demand its return normal/on-demand,iirc. But when we have spot instance it's return spot. When we curl to /meta-data/instance-life-cycle


Clarify Pod6 implicit code blocks syntax

The problem
The documentation specifies implicit code blocks as follow:

A code block may be implicitly specified as one or more lines of text, each of which starts with a whitespace character. The implicit code block is then terminated by a blank line.

But there's some problems with that definition.
Needs to start with a blank line
This is not always true. Roast test
=begin pod
This is a paragraph
    And this is not a code block.
=end pod

say $=pod[0];

raku /tmp/pod.raku
Pod::Block::Named{:name("pod")}
  Pod::Block::Para
    This is a paragraph And this is not a code block.

Reducing the original indentation terminates the code block
It's not only terminated on a blank line. Roast test
=begin pod
    First code block
         also first code block
    Also first code block
  A second code block
This is a paragraph
=end pod

say $=pod[0];

raku /tmp/pod.raku
Pod::Block::Named{:name("pod")}
  Pod::Block::Code
    First code block
         also first code block
    First code block
  Pod::Block::Code
    A second code block
  Pod::Block::Para
    This is a paragraph

A block can start with white space and not be a code block
Roast test
=begin pod
    =head1 Head

    A paragraph.
=end pod

say $=pod[0];

raku /tmp/pod.raku
Pod::Block::Named{:name("pod")}
  Pod::Heading{:level("1")}
    Pod::Block::Para
      Head
  Pod::Block::Para
    A paragraph.

Works inside =begin item but not on other blocks.
Like Itemization or Quitem. Roast test.
Suggestions
Mention this cases in the documentation and add some examples. This are all the cases that I can recollect from the code roast test and will help with https://github.com/Raku/doc/issues/2907.

Good catch, thanks!


KAFKA-15199: Remove Leading and Trailing Spaces

The changes remove leading and trailing spaces from user input while running release.py.
No change to any core functionality or tests.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Unrelated test failures. Merging this in.


Allow the sidebar heading to not be a link

We want to use this component with the "Elsewhere on GOV.UK" heading,
which doesn't have a link.
Trello:
https://trello.com/c/vM6Kaw9B/505-ias-and-content-designers-can-curate-related-links-for-any-content-type

@Davidslv could you please add a screenshot of how this would look like together with other taxon related links?

@carvil It will look like this screenshot, but bear in mind that we haven't built the functionality into navigation helpers yet so this isn't a screenshot of the end result.

@alextea would you like to give us some input on this please?

I'd like to understand more about when this would be used, with real examples of content.

Spoken to Holly and I think this is good as it is for now. We will continue to look at the data to see how the links are used.

Rebased and resolved conflicts.


Request for release of 2.0.0-rc4

As you have integrated lots of important fixes since last RC it would be great to see another RC to be integrated in our openSUSE repository...

Working on it.
The remaining issues and pull requests need some review, any help appreciated.

Thanks, @akallabeth. I know how much work a "simple" release is. I'm looking forward to update our sources in openSUSE as many issues have been fixed again!

@weberhofer looks like you'll get your wish

Cool.

Here we go #5032.


feat: Add functional tests to master commits

Overview
Implements functional testing for commits to master
Changes

CircleCI config updated
Workflow runner addition

Testing
Example output:
2019-06-12 14:14:57,903 INFO    :Workflow started
2019-06-12 14:14:59,022 INFO    :Job created: 3c8f15feab8bab78876afc01fe7fcb64
2019-06-12 14:19:50,154 INFO    :Job completed successfully
2019-06-12 14:19:50,267 INFO    :Tests completed successfully

test-runner-6bcfb44468-5dgjn test-runner stdout:   3 passing (5m)
test-runner-6bcfb44468-5dgjn test-runner
test-runner-6bcfb44468-5dgjn test-runner
test-runner-6bcfb44468-5dgjn test-runner Exited: 0

Coverage increased (+0.09%) to 77.999% when pulling 2a8486b27f2264b66c2b10d58d92ea46456e9ae8 on add_functional_tests_ci into 7fd679bd2a4319eaf2a437d9678ddf1dd67d3131 on master.


Reward Surveys in Android

What
Allow users to see unanswered surveys in the Android client
Put this feature behind a feature flag since it will be a WIP for a little while
Why
Missing feature that is wanted by all!

I started working on the tests last night and may need some help. I will
attach screenshots when I get into the office 🏢. 👍
On May 11, 2017 07:32, "Brandon Williams"<EMAIL_ADDRESS>wrote:

@mbrandonw requested changes on this pull request.
just did another pass. will do one last review pass today to cover the
tests and the xml layouts.
could you drop some screenshots of the UI in the PR too?
In app/src/main/java/com/kickstarter/ui/adapters/ActivityFeedAdapter.java
https://github.com/kickstarter/android-oss/pull/102#discussion_r115997105
:

@@ -39,7 +39,7 @@ public ActivityFeedAdapter(final @NonNull Delegate delegate) {

 insertSection(SECTION_LOGGED_IN_EMPTY_VIEW, Collections.emptyList());
 insertSection(SECTION_LOGGED_OUT_EMPTY_VIEW, Collections.emptyList());

insertSection(SECTION_SURVEYS_HEADER_VIEW, Collections.singletonList(null));

insertSection(SECTION_SURVEYS_HEADER_VIEW, Collections.emptyList());

can we still write tests for this adapter since there's quite a bit of
logic in it?
In app/src/main/java/com/kickstarter/ui/viewholders/
UnansweredSurveyHeaderViewHolder.java
https://github.com/kickstarter/android-oss/pull/102#discussion_r115997209
:

   "Reward_Surveys",

   unansweredSurveyCount,

   "reward_survey_count",

   String.valueOf(unansweredSurveyCount)));

headingTextView.setVisibility(unansweredSurveyCount > 0 ? View.VISIBLE : View.GONE);

if (unansweredSurveyCount > 0) {

 headingTextView.setText(

   ksString.format(

     "Reward_Surveys",

     unansweredSurveyCount,

     "reward_survey_count",

     String.valueOf(unansweredSurveyCount)));

 headingTextView.setVisibility(View.VISIBLE);

} else {

 headingTextView.setVisibility(View.GONE);

I don't think we need to mess with the visibility of the text view. we
will simply not render this view holder if the survey count is 0
In app/src/main/java/com/kickstarter/libs/ActivityViewModel.java
https://github.com/kickstarter/android-oss/pull/102#discussion_r115998825
:

private final PublishSubject intent = PublishSubject.create();

protected final PublishSubject onResume = PublishSubject.create();

sorry, this was my suggestion, but after seeing it IRL now I think we
should revert and go back to the explicit resume input you had before. I
really don't wanna push more functional into this VM base class. there's a
lot of benefit to making our VM's very explicit in what they require, so
it's nice to see this VM say it has functionality built on top of the
activity resuming.
do you mind reverting this commit? you can just do a git revert to do it
cleanly.
also you can make the resume observable just a simple  observable
since we no longer need the activity lifecycle event.
In app/src/main/java/com/kickstarter/viewmodels/ActivityFeedViewModel.java
https://github.com/kickstarter/android-oss/pull/102#discussion_r115998965
:

         ? this.client.fetchUnansweredSurveys()

       : Observable.just(Collections.emptyList())

   );

 responses

       : Observable.just(new ArrayList<SurveyResponse>())

any reason not to use Collections.emptyList()?
In app/src/main/java/com/kickstarter/ui/adapters/ActivityFeedAdapter.java
https://github.com/kickstarter/android-oss/pull/102#discussion_r115999264
:

@@ -42,6 +49,14 @@ public void takeActivities(final @NonNull List activities) {
notifyDataSetChanged();
}

public void takeSurveys(final @NonNull List surveyResponses) {
if (surveyResponses.size() > 0) {

 setSection(SECTION_SURVEYS_HEADER_VIEW, Collections.singletonList(surveyResponses.size()));

 setSection(SECTION_SURVEYS_VIEW, surveyResponses);

}

we need an else to this if so that if surveys later load 0 results we
will clear the area.
a good test case to have too.
In app/src/main/java/com/kickstarter/viewmodels/ActivityFeedViewModel.java
https://github.com/kickstarter/android-oss/pull/102#discussion_r116003046
:

public interface ActivityFeedViewModel {

interface Inputs extends ActivityFeedAdapter.Delegate {

interface Inputs extends Delegate {

let's not import the delegate like this. from a code reviewer perspective
it's nice to see where that delegate interface is coming from.
In app/src/main/java/com/kickstarter/viewmodels/ActivityFeedViewModel.java
https://github.com/kickstarter/android-oss/pull/102#discussion_r116003235
:

}

final class ViewModel extends ActivityViewModel implements ActivityFeedAdapter.Delegate,
Inputs, Outputs {

final class ViewModel extends ActivityViewModel implements
ActivityFeedViewModel.Inputs, ActivityFeedViewModel.Outputs {

on the other hand, these make sense to just be Inputs and Outputs because
they are defined right above and it works the exact same way in every view
model.
In app/src/main/java/com/kickstarter/viewmodels/ActivityFeedViewModel.java
https://github.com/kickstarter/android-oss/pull/102#discussion_r116004091
:

public final Inputs inputs = this;
public final Outputs outputs = this;

public final ActivityFeedViewModel.Inputs inputs = this;
public final ActivityFeedViewModel.Outputs outputs = this;

same here...
In app/src/main/java/com/kickstarter/viewmodels/ActivityFeedViewModel.java
https://github.com/kickstarter/android-oss/pull/102#discussion_r116004450
:

 Observable.combineLatest(

     this.onResume,

     this.currentUser.isLoggedIn(),

     Pair::create

   )

   .filter(resumedAndLoggedIn ->

     resumedAndLoggedIn.first == ActivityEvent.RESUME && resumedAndLoggedIn.second

   )

   .compose(Transformers.combineLatestPair(surveyFeatureEnabled))

   .switchMap(resumedAndLoggedInAndEnabled ->

     resumedAndLoggedInAndEnabled.second

       ? this.client.fetchUnansweredSurveys()

       : Observable.just(new ArrayList<SurveyResponse>())

   )

   .subscribe(this.surveys::onNext);

looks like we are missing a .compose(this.bindToLifecycle()) on this.
In app/src/main/java/com/kickstarter/viewmodels/
UnansweredSurveyHolderViewModel.java
https://github.com/kickstarter/android-oss/pull/102#discussion_r116004628
:

/** Emits creator avatar image */

Observable creatorAvatarImage();

/** Emits the creator name */
Observable creatorName();

/** Emits the survey description */
Observable<List> surveyDescription();

/** Emits the survey url */
Observable loadSurvey();
}

final class ViewModel extends ActivityViewModel implements
UnansweredSurveyHolderViewModel.Inputs,
UnansweredSurveyHolderViewModel.Outputs {

can drop these fully qualified names
In app/src/main/java/com/kickstarter/viewmodels/
UnansweredSurveyHolderViewModel.java
https://github.com/kickstarter/android-oss/pull/102#discussion_r116004660
:

   .map(this::getSurveyDescription);

 this.goToSurvey = this.configData

   .compose(takeWhen(this.surveyClicked));

}

private final PublishSubject configData = PublishSubject.create();
private final PublishSubject surveyClicked = PublishSubject.create();

private final Observable creatorAvatarImage;
private final Observable creatorName;
private final Observable<List> surveyDescription;
private final Observable goToSurvey;

public final UnansweredSurveyHolderViewModel.Inputs inputs = this;
public final UnansweredSurveyHolderViewModel.Outputs outputs = this;

here too
In app/src/main/java/com/kickstarter/viewmodels/
UnansweredSurveyHolderViewModel.java
https://github.com/kickstarter/android-oss/pull/102#discussion_r116005671
:

}

@Override public Observable creatorAvatarImage() {

 return this.creatorAvatarImage;

}
@Override public Observable creatorName() {

 return this.creatorName;

}
@Override public Observable<List> surveyDescription() {

 return this.surveyDescription;

}
@Override public Observable loadSurvey() {

 return this.configData;

}

private List getSurveyDescription(final @NonNull SurveyResponse surveyResponse) {

a few things:

all private helper functions should be static because they shouldn't
rely on anything in the view model. they should just be lil pure functions
that take all their input and spit out output.
it is dangerous to use a list to represent two pieces of data that you
later get(0) and get(1) on. we have no compiler time guarantee that
that contract will continue to hold in the future.
There are two options to make it safer.

We can make it a pair and name the variable explicitly as
creatorNameAndProjectName to make it clear what first and second are.
we can pass the Project back to the view and let the view just pluck
out the data it needs to render it's string. then the output could be
called something more like projectForSurveyDescription.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kickstarter/android-oss/pull/102#pullrequestreview-37583609,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAe7uC5H12h2HIOIYDfGFHA7kcTMzsc2ks5r4xwUgaJpZM4NXO-H
.

With Surveys

Without surveys


Can my application extract identity from incoming request

Scenario: client send request to my application (Pod) to get it's role. My application will check identity of request and return a JWT token with role value.
Most examples in Document are about Allow/Drop request. So can Cilium Allow all request but inject a HTTP Header like X-Auth-Identity to request? Or client can get it Identity by some API?
Looks Envoy extentsion can do this but existing example is too complex because I just want to inject a value.

As far as I know, L7 policy rules can be used to allow/drop packets, but not inject HTTP headers. @jrajahalme might know more.

Closing due to inactivity.


Issue/8145 reschedule deferred deploys order

Description

Ensure that when a deploy task gets deferred because of an incoming dependency, it is added back to its original position in the queue when it becomes unblocked again, mitigating starvation.
Small refactor of PrioritizedTask and related classes because they were becoming unwieldy. Replaced with two protocols: one for the fields required internally, the other for the ones to be exposed to the scheduler (and a third combining the two). This makes it easy to have different dataclasses with variations, while keeping them consistent.
Small bugfix on _new_version: take all resources, and then a set of up-to-date resources, rather than to disjunct dicts. This caused us to consider all up-to-date ones as "deleted resources" later on, essentially acting as if they were not there at all. I expect the first export after server start would in practice lead to an almost complete repair (everything that was in a known good state when the server came up).

closes #8145
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[x] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Looks nice!


Fix raw reference to Guava in OptionalPropertyFactory

This was causing uncompilable code to be generated when using J8 Optional properties without Guava as a dependency. This fixes #153.

:+1:


When  "--code-coverage" does not present, text summary should not be printed out

OS
Mac OSX - El Capitan
Versions.
angular-cli: 1.0.0-beta.19-3
node: 6.4.0
os: darwin x64
Repro steps.

Create a new app using ng new command
Modify remapIstanbulReporter config in karma.conf.js, to the following:

    remapIstanbulReporter: {
      reports: {
        'text-summary': null, // 'null' means falling back to the default console.log
      }
    },

Execute ng test (NOTE: without --code-coverage)

The log given by the failure.
$ ng test
....
=============================== Coverage summary ===============================
Statements   : 100% ( 0/0 )
Branches     : 100% ( 0/0 )
Functions    : 100% ( 0/0 )
Lines        : 100% ( 0/0 )
================================================================================

Expected behavior
The coverage summary above should not be printed out at all.
Mention any other details that might be useful.
Maybe it is an issue with karma-remap-istanbul.

Hm... I understand the argument. We do some config manipulation so maybe we should remove the remapIstanbulReporter entry when we're not doing code coverage.

This is fixed in recent versions.

cheers


[Bug Report] No option to Set column size of Element-UI table without words breaking to the next line

Element UI version
0.1.0
OS/Browsers version
ubuntu/chromw
Vue version
2.6.10
Reproduction Link
https://codepen.io/rameezcubet/pen/QWLoMbr
Steps to reproduce
Hi
How do we set column size of Element-UI table without words breaking to the next line?
please check the address column in  https://codepen.io/rameezcubet/pen/QWLoMbr
I have min-width="100", so where content is larger than 100px it should expand, but it goes to the next line.
What is Expected?
All data in a single row without breaking text into the next line. like how intercom application handles this

What is actually happening?
I have min-width="100", so where content is larger than 100px it should expand, but it goes to the next line.

I did some testing and find that the min-width will work if the actual content fits in the 100% width of the table (not scrollable on the x-axis). If there are too many columns, as @rameezcubet's example, it will be wrapping the content instead.
Have not look into the code yet.


Cannot boot to iso when volume_id is used.

System Information
Linux distribution
 Centos7
Terraform version
terraform -v

Terraform v0.12.18
Provider and libvirt versions
terraform-provider-libvirt -version

terraform-provider-libvirt 0.6.0+git.1569597268.1c8597df
Compiled against library: libvirt 4.1.0
Using library: libvirt 4.5.0
Running hypervisor: QEMU 1.5.3
Running against daemon: 4.5.0
If that gives you "was not built correctly", get the Git commit hash from your local provider repository:
git describe --always --abbrev=40 --dirty

7ca2904c213159e0cc23ff4470f89a32622bdfc2-dirty

Checklist

[ ] Is your issue/contribution related with enabling some setting/option exposed by libvirt that the plugin does not yet support, or requires changing/extending the provider terraform schema?

[ ] Make sure you explain why this option is important to you, why it should be important to everyone. Describe your use-case with detail and provide examples where possible.
[ ] If it is a very special case, consider using the XSLT support in the provider to tweak the definition instead of opening an issue
[ ] Maintainers do not have expertise in every libvirt setting, so please, describe the feature and how it is used. Link to the appropriate documentation

[x] Is it a bug or something that does not work as expected? Please make sure you fill the version information below:

Description of Issue/Question
When I use both a volume and a file disk in a domain I get No bootable device.  If I just use the file the iso will boot.
Setup
resource "libvirt_volume" "devcomp" {
  name   = "devcomp"
  pool   = "default"
  size =<PHONE_NUMBER>0
}

# Create the machine
resource "libvirt_domain" "devcomp" {
  name = "devcomp"
  vcpu = 2
  memory = "8192"
  autostart = true

  network_interface {
    network_id     = libvirt_network.mainnet.id
    hostname       = "devcomp"
    addresses      = ["<IP_ADDRESS>"]
    mac            = "22:fc:55:12:ed:7b"
  }

  # IMPORTANT: this is a known bug on cloud images, since they expect a console
  # we need to pass it
  # https://bugs.launchpad.net/cloud-images/+bug/1573095
  console {
    type        = "pty"
    target_port = "0"
    target_type = "serial"
  }

  console {
    type        = "pty"
    target_type = "virtio"
    target_port = "1"
  }

  disk  {
                file = "/usr/local/libvirt-pool/manjaro-xfce-19.0-200224-linux54.iso"
        }
  disk {
                volume_id = libvirt_volume.devcomp.id
                scsi = true
        }

  graphics {
    type        = "spice"
    listen_type = "address"
    listen_address = "<IP_ADDRESS>"
    autoport    = true
  }
}

(Please provide the full main.tf file for reproducing the issue (Be sure to remove sensitive information)
Steps to Reproduce Issue
(Include debug logs if possible and relevant).
Run the above .tf file and you will get this on 6.0.

Additional information:
Do you have SELinux or Apparmor/Firewall enabled? Some special configuration?
Have you tried to reproduce the issue without them enabled?

I got following error:
Error: Error creating libvirt domain: virError(Code=38, Domain=18, Message='Cannot access storage file './xxxxxx.iso': No such file or directory')

Yes, I have ./xxxxxx.iso exists.
when use iso disk and volume_id
  disk {
    volume_id = libvirt_volume.xxxx-qcow2.id
  }
  disk {
    file = "${path.module}/xxxxxxxxxxxxxxxxxxxxx.iso"
  }

Ah, this is not true, I still able to tf apply successfully and the vm is running.

After make vnc to work, I can confirm this issue, I can't boot iso disk and it gives "No bootable device"
I thought if we specify iso disk first then it must use iso disk to boot first, but somehow this happens, I believe this is a bug.

After doing some more thinking on this and trying out some solutions that seem pretty obvious now.  Adding a boot order fixes this.
  boot_device {
    dev = [ "hd", "cdrom"]
  }

If you add this order with cdrom last you can boot the iso and then when the OS is installed on the next restart you will get the installed OS.


Function createStorage changes type of state element

Do you want to request a feature or report a bug?
I think that behavior is a bug.
What is the current behavior?
Example:
import {  createStore } from 'redux';

function postsReducer(state, action) {
  console.log('The post will be changed.');
  return state;
}

const posts = [{
  "code": "BAcyDyQwcXX",
  "caption": "Lunch #hamont",
  "likes": 56,
  "id": "1161022966406956503",
  "display_src": "https://scontent.cdninstagram.com/hphotos-xap1/t51.2885-15/e35/12552326_495932673919321_1443393332_n.jpg"
}, {
  "code": "BAcJeJrQca9",
  "caption": "Snow! ⛄🌨❄ #lifewithsnickers",
  "likes": 59,
  "id": "1160844458347054781",
  "display_src": "https://scontent.cdninstagram.com/hphotos-xaf1/t51.2885-15/e35/12407344_1283694208323785_735653395_n.jpg"
}];

const defaultState = {
  posts
};

Current behavior:
Before createStore():
console.log('Is defaultState.posts instance of Array', defaultState.posts instanceof Array); // true

After createStore():
const store = createStore(postReducer, defaultState);
console.log('Is store.state.posts instance of Array', store.getState().posts instanceof Array); // false

What is the expected behavior?
Before createStore():
console.log('Is defaultState.posts instance of Array', defaultState.posts instanceof Array); // true

After createStore():
const store = createStore( postReducer, defaultState );
console.log('Is store.state.posts instance of Array', store.getState().posts instanceof Array); // true

Which versions of Redux, and which browser and OS are affected by this issue? Did this work in previous versions of Redux?

"redux": "^3.7.2"

@avkis You pass postReducer to creareStore instead of postsReducer. And according your example this problem is not reproduced here https://www.webpackbin.com/bins/-KrewOSuF9yLQ7VxmRfa

@TrySound Sorry for postReducer, it was typo. In your example the bug is not appeared. I don't know why, but in my project there is the bug. The code almost the same, except I cut it a little for convenience purposes. And I don't know yet how to fix it. I attached debugger and console screenshots.

You're using combineReducers which will always return an object.
However, this is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux. Thanks!


build: automatically add lint fixes during precommit hook

@illiphilli tested this locally, it works on his system as well


Fix deadlock when trying to close an account

Fixes #3044.

@Changaco Would I need a fake payday for this to matter? It worked locally form I just want to make sure I'm testing it right.

@Changaco Would I need a fake payday for this to matter? It worked locally form I just want to make sure I'm testing it right.

When exactly does this happen? I'm trying to write a test for it, but can't seem to trigger that kind of behaviour. I created a team, added the person as a member, and then tried to close the account. What error should we be expecting?

It happens when the participant has a non-zero balance and is part of a team. I've modified the tests to trigger the problem.

Travis is green, the fix is trivial, I'm merging and deploying.


Set the default Python version in pre-commit to 3.10

Follow up on #1326
Checklist

[ ] Type annotations added to new functions
[ ] Docs added to functions touched in main classes
[ ] Dry-run produced the expected results
[ ] The to-be-announced tag added if this is worth announcing

The CI should become green after merging #2115

@Mergifyio rebase


Search list results : why not allowing a right-click on a result to open it in a new window

Describe the bug
Spontaneously, I would like to be able to right-click on a search result to open it in a new window or tab.
To Reproduce Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

OPTIONAL: Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem (drag-and-drop the image directly here).
Desktop (please complete the following information):

OS: macOS 10.14.6 (18G103), French
Browser Firefox
Version 70.01.1

Additional context
Add any other context about the problem here.

this issue has been moved to YouTrack: DSP-358


Chat - Scrolling does not work if the user adds a message or clicks 'New messages' button

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com or open Desktop App
Login with any account and go to chat with long history
Scroll to the beginning of the chat
Post new messages > Check the result
Mark any message as unread and scroll up the chat until the "New messages" button appears
Click the "New messages" button > Check the result

Expected Result:

Message added and chat scrolled to new messages
Chat scrolled to new messages

Actual Result:

Message added and chat did not scroll to new messages
Chat did not scroll to new messages

Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/93399543/27f30d24-d4d6-4ff8-a427-ca71d1552163

View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Hmm yeah, the 'New Message' indicator doesn't scroll me anymore

This came from https://github.com/Expensify/App/pull/28793
cc: @perunt @janicduplessis @thienlnam

If you press this button without navigating to thread would it scroll you down?

If you press this button without navigating to thread would it scroll you down?

Nope. Seems like ref of MVCPFlatList is not forwarded correctly

https://github.com/Expensify/App/blob/a1a0f3897995a0992f38a885412af723174c7be2/src/hooks/useReportScrollManager/index.ts#L12-L18
Early returned because flatListRef.current is not set

@perunt You around to get a PR up for this? Ideally we can just fix the ref forwarding and then we won't have to revert the PR

There's another similar regression: #30935

Confirmed https://github.com/Expensify/App/pull/30962 fixes this issue as well

Great - we'll link that one there then. Thanks for the help here!

This was taken care of in https://github.com/Expensify/App/pull/30962


pyopenssl deprecated?

since pyopenssl is soon to be dropped, is this an easy resolvable task?

Yes. In fact, this has already been resolved. The modules openssl_* docs say "The module can use the cryptography Python library or the pyOpenSSL Python library." At the moment vars/default variables "certificate_packages" list both packages. This can be customized. The sanity checks whether any of the packages have been installed. See variables "al_sanity_packages_required" in vars/defaults.

Closed. Feel free to ask to reopen.


Error in load_clinvar_to_es in v0.1

File "/opt/seqr/hail-elasticsearch-pipelines/hail_scripts/v01/load_clinvar_to_es.py", line 100, in
summary = vds.summarize()
File "", line 2, in summarize
File "/opt/seqr/hail-elasticsearch-pipelines/hail_builds/v01/hail-v01-10-8-2018-90c855449.zip/hail/java.py", line 121, in handle_py4j
hail.java.FatalError: NumberFormatException: For input string: "NW_003315947.1"
I did some search and is this related to VCF header?
Thanks

I looked at the ClinVar file and found "NW_003315947.1" is in the #CHROM column. I guess that's a problem? Where the data structure was defined for this column?

I think I located the cause of the problem. It doesn't handle the case I mentioned above. I am wondering did you encounter the same problem?

@SimonLi5601 I do see this issue in the GRCh37 version of clinvar.
As a workaround, you can add --subset 1-22XY to discard records with unusual chromosome names. Let me know if this doesn't work for you.

@bw2 Oh, I see, that should work. I will get it a try to see if any other problem.Thanks!

@bw2 Hi Ben. I kind of addressed the issue mentioned above. But I have another issue for mapping a VDS field to a ElasticSearch filed.
File "/opt/seqr/hail-elasticsearch-pipelines/hail_scripts/v01/utils/elasticsearch_utils.py", line 87, in _map_vds_type_to_es_type
raise ValueError("Unexpected VDS type: %s" % str(type_name))
ValueError: Unexpected VDS type: Set[Struct{db:String,name:String}]
Please see the partial schema for the KeyTable below and the domains are a Set of Struct.
export_kt_to_elasticsearch - KeyTable schema: Struct{
allele_id: Int,
chrom: String,
clinical_significance: String,
domains: Set[Struct{
db: String,
name: String
}],
gene_ids: Set[String],
gold_stars: Int,
I added a trick without looking into deeply, but it seems not working, do you have any suggestions? Thanks!
VDS_TO_ES_TYPE_MAPPING.update({
'Array[Struct]': 'nested',

'Set[Struct]': 'nested',
})

It seems that data structure has been changed during annotate_variants_expr call.
I made a ad-hoc modification on my local in this toSet  -> toArray and it works. I am not sure if I have different VDS schema from the upstream pipeline from you.

Hi Simon, glad you found a work-around.
I'm not sure what the issue is, and would need to do more troubleshooting to reproduce this.
@knguyen142 is making good progress with converting all pipelines to hail 0.2, so if your patch is working fine, perhaps it's best to stay with that until the 0.2 pipelines are ready.

Hi Ben, thanks for the update. Glad to hear that. Yes, currently I am working on this (more on load_dataset_to_es)  just to have a demo dataset to be used in seqr application. We will stay tuned for the progress of v 0.2.


Bring back .form-text

In the notorious form updates PR (https://github.com/twbs/bootstrap/pull/28450), .form-text was dropped. I don't think that was the right thing to do, having a class which we can use to keep form descriptions consistent would help. We could also add some null variables (font size, font weight, font style, color) to make this element more more configurable.
Thoughts @twbs/css-review?

Yep, and eventually be consistent with .*-feedback classes too.

I've asked @mdo about this on Slack and he's ok bringing .form-text back. Since we also did https://github.com/twbs/bootstrap/pull/30476, I think it makes sense to continue with this.
@zalog do you mind having a look at this, since you already did some research in https://github.com/twbs/bootstrap/pull/30397?

Yep, sure. I'm glad that I can help :)
I'll get back on it soon.


number to string

Closes [issue link]
https://github.com/codinasion/codinasion/issues/103
What's being changed:
added string to number program in program folder

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

done