@yieldreturn not specifying the type

The method summary says it returns a Object even if @yieldreturn is specified with a type.
Steps to reproduce
# @yieldreturn [Integer]
def something
  100
end

Actual Output
Instance Method Summary

#something ⇒ Object

Instance Method Details

#something ⇒ Object

Yield Returns:
(Integer)

Expected Output
Instance Method Summary

#something ⇒ Integer

Instance Method Details

#something ⇒ Integer

Yield Returns:
(Integer)

Environment details:

OS: Ubuntu 16.04
Ruby version (ruby -v): ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux]
YARD version (yard -v): yard 0.9.5

I think you want @return, not @yieldreturn. The latter is for return values of blocks.

You're right, my bad, sorry.


Add show util

Closes #107
Closes #194
The idea is that you can visualize any world object immediately.
New API:

Geometry.bounding_box()
Geometry.bounding_sphere()
gfx.trimesh_geometry(mesh)
Matrix4.to_ndarray()
gfx.linalg.utils.transform(vectors, matrix)
gfx.linalg.utils.aabb_to_sphere(aabb)
gfx.linalg.utils.transform_aabb(aabb, matrix)
WorldObject.get_world_position()
WorldObject.get_world_bounding_box()
WorldObject.get_world_bounding_sphere()
Camera.show_object(target)
gfx.show(object)

New examples:

examples\show_util.py

examples\show_stl.py

examples\show_scene.py

I think this is ready now!

There were quite a lot of gotchas here, but it's working nicely now.
I guess it only falls apart when the near/far planes are too small for the scene you're showing. That can be addressed in #231


Input fields of metadata_quicklook_download.py have changed

It seems like some of the input fields have changed in the LANDSAT csv files. For example, the metadata_quicklook_download.py file is looking for the "ACQUISITION_DATE" column in the csv and that column is now "acquisitionDate." Additionally, I wasn't able to find the equivalent of the "WRS2_TILE" column in the new csv files that should have values like "p038r031."

Nevermind, I realized that I hadn't successfully run the metadata_csv_filter.py script. It seems like that script does all the formatting.


Bug: caret color changes when paragraph is empty

I've notice an issue that could be a bit problematic in dark mode. In the screenshot I changed the base text color to red because it was easier to show, but imagine the same with dark background with white text.
Imagine you set your base text color to red. The caret will change color once we type text:

The reason is that the caret color will take the text color, but when your paragraph is empty, there is no text color.
You can work around it it by applying a caret-color style to your ContentEditable. In my opinion this is not great as you need to specify this color in two different places (one which is not even inside your theme).
I had a small look at this and my first attempt was to apply the text.base style to paragraph node : https://github.com/facebook/lexical/compare/main...caret-color but then I figured out we would have to do this for headings, code, etc, which wouldn't scale well. So I think this might need a deeper discussion.
Lexical version: 0.2.5
Steps To Reproduce

Apply the changes in https://github.com/facebook/lexical/compare/main...caret-issue to make you text color red
Notice how the caret color is different once you start typing text

The current behavior
Caret color does not depend of text color when text is empty
The expected behavior
They should be in sync

Addressed in https://github.com/facebook/lexical/pull/2080 :)

Following the discussion in https://github.com/facebook/lexical/pull/2080, it seems that it will be a won't fix as it's by design. How can I mark it as won't fix?


Create a TosiDrop specific DataDog account

Boris:
I could work on getting this setup as well, while i'm doing the cloudflare part.
Are there any requirements as for the "type" or "plan" that needs to be setup?

feature-datadog Branch was created for this.  It currently installs the agent.  Need to figure the correct configs for this on things we want to monitor


[interop] verify that a C++ record is a Swift nominal type before try…

…ing to add explicit protocol conformances
This fixes the issue where we crashed printing foundation

@swift-ci please test


feat: add some plumbing to enable multiple channels

Note that Client might create multiple channels but the SessionPool
only uses the first one right now. I'll add proper support for multiple
channels in a subsequent change but wanted to get some of the more
mechanical parts out of the way.

This change is

google/cloud/spanner/client.cc, line 226 at r1 (raw file):

  stubs.reserve(num_channels);
  for (int i = 0; i < num_channels; ++i) {
    stubs.push_back(internal::CreateDefaultSpannerStub(options));

@coryan to resolve our discussion from yesterday, should I modify the channel_pool_domain for each one of these channels?  append the value of i to each of them or similar? kind of a pain that options isn't mutable.


Change mapper test to correctly check timing.

#552  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on  Graphite


Taiko Bridge wrong amount of eth

Describe the bug
While using bridge from Holesky to Katla, there i see two different eth amounts from my metamask eth. Especially the 2.d amount was a bit strange but after i clicked the max it showed -(negative) amount of eth.

0x6cB562eDe1273A4bf554d2D2E273a6110e2F3c5B is the metamask adress i used
Steps to reproduce
Steps to reproduce here.
Additional context
Additional context here.

Duplicate https://github.com/taikoxyz/taiko-mono/issues/15507


Vala language server fails to start: vala-language-server.sh file does not exist

Due to a recent change where ${workspaceFolder} is now used (#211), the Vala language server cannot start. This may be because VS Code does not resolve the ${workspaceFolder} variable in settings.json, so it passes the string as-is to the Vala extension.
I'm not quite sure that it is really advisable to assume that extensions will handle variables exposed by VS Code in other scopes.

so it passes the string as-is to the extension.

That is not really true. See https://github.com/bilelmoussaoui/flatpak-vscode/blob/master/src/manifest.ts#L641

I meant that VS Code passes the string "${workspaceFolder}/.flatpak/vala-language-server.sh" to the Vala extension, instead of expanding ${workspaceFolder} and then passing the full path to the Vala extension.

I created a patch for the Vala extension. This works on my machine. Can you verify this fixes your problem?
https://github.com/vala-lang/vala-vscode/pull/25

I was testing the approach that Meson extension uses for the vscode_compile_commands.json file, which is to simply use neither absolute path nor the ${workspaceFolder} variable, but just use the relative path: _build/vscode_compile_commands.json.
It seems to work
I will be testing your patch for the Vala extension.

Removing ${workspaceFolder} seems to fail for the Rust extension. It seems there is not a "one size fits all" solution.
I think the patch to the Vala extension is the way to go.

Is this still happening with latest release?

@bilelmoussaoui this is still hapenning, but the solution will be just to patch the Vala extension an that's it

Let us close this one then . Feel free to open an issue on the vala sdk extension side

@bilelmoussaoui this is still hapenning, but the solution will be just to patch the Vala extension and that's it

Do you mean the Vala Sdk or the vala-vscode plugin?

@lw64 the vala-vscode plugin

So the flatpak-vscode plugin is currently broken with vala?

@lw64 kinda

If its broken, then thats definitly a problem that needs to be fixed. Using the vala-vscode extension is not a good solution, as you need the language server for it installed on the host. I am sadly not much into vscode extensions, so I don't know what is the issue here and how to fix it. Also what does "kinda" mean? Does it work sometimes, and sometimes not?

@nahuelwexd @lw64 The new release of vala-vscode v1.1.0 has the fix for this issue: https://github.com/vala-lang/vala-vscode/releases/tag/v1.1.0
Can you verify that this fixes your problem and report back?

@caspermeijn I tested your PR in advance, and I already tested the new release, everything works as expected

Great to hear this is fixed.


feat: auto create mcs resource for some service

What type of PR is this?
/kind feature
What does this PR do?

Which issue(s) does this PR fix?

Fixes Part of #85
Special notes for your reviewer:

Does this PR introduce a user-facing change?

/lgtm

/approve

/approve


Add in the Microsoft.IdentityModel.Tokens.Jwt library

The library should meet the following requirements:
•	Remove automatic short-to-long claim type mapping that occurs when tokens are created.
•	Prepare a framework for future work that will involve asynchronous token validation and creation.
•	Improve the speed of JWT token validation and creation.
•	Simplify the way in which JWT tokens are stored and dealt with.
•	Provide a single extensibility model using delegates. Previous models provided two models: virtual methods and delegates.

library was added

Is it safe to assume that JsonWebTokenHandler is basically the new version of JwtSecurityTokenHandler? I've been using JwtSecurityTokenHandler and I saw the latest version added JsonWebTokenHandler. Is there a reason to use one over the other? Looking over it, it seems the basic difference is encryption support, but I just want some additional clarification here on why this new handler was added.

Hi @mafurman @brentschmaltz, any insight into the above?

@EatonZ JwtSecurityTokenHandler was modeled after the existing System.IdentityModel.SecurityTokenHandler. There were some compromises that we had to make, such as using System.Security.ClaimsIdentity as the type to build the JWS or JWE when using SecurityTokenDescriptor. ValidateToken had an out parameter, which doesn't for async.
We then returned a collection of S.S.ClaimsPrincipal, sometimes using claim type mapping.
This model new model, is much lighter weight and works with native Json.Net objects.
We plan on layering on top, so that you can get back to the existing types, but we will allow users to control what is returned using injection and delegates.
We saw performance improvements of up to 100% in some scenarios.


Create proper documentation

Right now, the docs are very thin and there are just a few tutorial videos scattered around about using this plugin.
What is needed:

[ ] Details on implementing both UDP Receiver and Sender;
[ ] Creating your own data structures for data transmission;
[ ] MATLAB/Simulink side;
[ ] Troubleshooting.

Details on implementing both UDP Receiver and Sender;


Update test sqlmigrationconstraint

Take into account the great changes on SQL Server 2016 SP1 which have all features available  on 'all' editions

Based on @ctrlbold lab.
If you run the following code (using SQLCMD Mode - Query Menu -> SQLCMD Mode):
:connect sql2016
SELECT @@SERVERNAME AS ServerName, SERVERPROPERTY('ProductLevel') AS ProductLevel, SERVERPROPERTY('Edition') AS Edition, SERVERPROPERTY('ProductVersion') AS ProductVersion
GO

:connect sql2016a
SELECT @@SERVERNAME AS ServerName, SERVERPROPERTY('ProductLevel') AS ProductLevel, SERVERPROPERTY('Edition') AS Edition, SERVERPROPERTY('ProductVersion') AS ProductVersion
GO

:connect sql2016\STANDARDRTM
SELECT @@SERVERNAME AS ServerName, SERVERPROPERTY('ProductLevel') AS ProductLevel, SERVERPROPERTY('Edition') AS Edition, SERVERPROPERTY('ProductVersion') AS ProductVersion
GO

:connect sql2016\sqlexpress
SELECT @@SERVERNAME AS ServerName, SERVERPROPERTY('ProductLevel') AS ProductLevel, SERVERPROPERTY('Edition') AS Edition, SERVERPROPERTY('ProductVersion') AS ProductVersion
GO

:connect sql2012
SELECT @@SERVERNAME AS ServerName, SERVERPROPERTY('ProductLevel') AS ProductLevel, SERVERPROPERTY('Edition') AS Edition, SERVERPROPERTY('ProductVersion') AS ProductVersion
GO

Returns:

ServerName
ProductLevel
Edition
ProductVersion

SQL2016
SP1
Standard Edition (64-bit)
13.0.4001.0

SQL2016A
RTM
Enterprise Edition (64-bit)
13.0.1601.5

SQL2016\STANDARDRTM
RTM
Standard Edition (64-bit)
13.0.1601.5

SQL2016\SQLEXPRESS
SP1
Express Edition (64-bit)
13.0.4001.0

SQL2012
SP3
Enterprise Edition (64-bit)
11.0.6020.0

Use the following parameters to test the improvements:

[ ] Test-SqlMigrationConstraint -Source SQL2016 -Destination SQL2016A -> Expected result: For every database should say "Database can be migrated"
[ ] Test-SqlMigrationConstraint -Source SQL2016A -Destination SQL2016 -> Expected result: For every database should say "Database can be migrated"
[ ] Test-SqlMigrationConstraint -Source SQL2016A -Destination SQL2016\STANDARDRTM -> Expected result: For every database that have features should say "Database cannot be migrated. There are features in use that are not available on destination instance edition." otherwise "Database can be migrated"
[ ] Test-SqlMigrationConstraint -Source SQL2016 -Destination SQL2016\STANDARDRTM -> Expected result: For every database that have features should say "Database cannot be migrated. There are features in use that are not available on destination instance edition." otherwise "Database can be migrated"
[ ] Test-SqlMigrationConstraint -Source SQL2016A -Destination SQL2016\SQLEXPRESS -> Expected result: For every database that have 'ChangeCapture' feature should say "Database cannot be migrated. Destination server is running Express Edition which does not support 'ChangeCapture' feature." otherwise "Database can be migrated"
[ ] Test-SqlMigrationConstraint -Source SQL2012 -Destination SQL2016\SQLEXPRESS -Databases DBWithCompression -> Expected result: "Database can be migrated"

Please feel free to try other combinations and ask at will if you have any questions.
 You get like 8 🥇🥇🥇🥇🥇🥇🥇🥇for the level of detail in this PR! Thank you @ClaudioESSilva. Looks like I'll have time to work on this tonight!

This was a really gorgeous PR. Thanks so much for the tests!  Please resubmit.


add support for customizing log format

This pull request implements a requirement that we have with regards to changing the log format of the vpc flow log
Currently flow log default format only lists the ENI and not the VPCID
As we have several ENIs in each VPC it would be easier to summarize data using the VPCID field and therefore we need to use a custom format

@tonynv @andrew-glenn @tlindsay42
We would like for this pr to be approved and merged
this is a rather simple enhancement to the module
please approve merge and release if no changes are required


Masking with '9' digit

I need to mask like a +90 (123) 123 12 12. But If i write  '9' after the '+' symbol, plugin starting to mask on this point. :)
How can i set default value to +90?

@batuhantozun I'm not a maintainer of this project but your mask would be:
+99 (999) 999 99 99 and then you would need to pass in a value prop to the component that begins with 90.
Something like
render() {
  const value = "90" + this.props.valuel
  return (<InputElement
    mask="+99 (999) 999 99 99"
    value={value}
  />);

Prefix 9 with backslash.
<InputMask mask="+\90 (999) 999 99 99" />


simgrid: use lib.cmakeBool/cmakeFeature

Description of changes
use lib.cmakeBool/cmakeFeature
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 335664 run on x86_64-linux 1

2 packages built:

simgrid
simgrid.python

I suppose the rebuild is due to a change in the order within the list


Change tag image on next for getting last changes in the test codebase

What does this PR do?
Changes the nightly tag for the test image on the next
What issues does this PR fix or reference?
eclipse/che#20406
Is it tested? How?
PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v8-devworkspaces-operator-e2e, v8-devworkspace-happy-path to trigger)

[ ] v8-devworkspaces-operator-e2e: DevWorkspace e2e test
[ ] v8-devworkspace-happy-path: DevWorkspace e2e test

/test v8-devworkspaces-operator-e2e, v8-devworkspace-happy-path

e2e tests fails because controller fails with

E0903 14:47:43.754688       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.20.6/tools/cache/reflector.go:167: Failed to watch *v1beta1.Ingress: failed to list *v1beta1.Ingress: ingresses.extensions is forbidden: User "system:serviceaccount:devworkspace-controller:devworkspace-controller-serviceaccount" cannot list resource "ingresses" in API group "extensions" at the cluster scope

Not sure why it happens. Probably due Josh's image, which should be fixed in https://github.com/devfile/devworkspace-operator/pull/572

/test v8-devworkspaces-operator-e2e, v8-devworkspace-happy-path

/test v8-devworkspace-happy-path

happy path test fails due the recent changes how tests deploy DWO, but it's not related to this PR.
So, merging this and prow will get yq and other prerequisites separately.


feat: Add Onboarding View (only UI)

What it Does

Related to https://github.com/mikaelacaron/Basic-Car-Maintenance/issues/40
When app will be launch for the first time, will be presented 2 onboarding screens
1st screen present the highlighted features of the app
2nd screen allows to add basic data about first car
This pull request contains only UI (logic to remember app state whether User launched app for the first time or launched already, is commented. No more different logic is not included)
1st and 3rd bullet point description had to be shortened due to SwiftLint policy

How I Tested

Run the application in Preview
Run the application in Simulator (with temporary logic turned on to show whether WelcomeScreen is loading when app is launched for the first time)
Check whether view components are shown correctly based on the design created in Figma

Notes

May need further updates to include logic when app is launched for the first time and to remember to not load onboarding screens when app is launched again

Screenshots

Screencast
Works only with temporary logic turned on (video only shows how Onboarding screens looks in simulator)
https://github.com/mikaelacaron/Basic-Car-Maintenance/assets/53284922/f3f32ac7-10ca-493f-a851-57430313739f

Thanks for the PR! I see this! I haven't had time yet to review it @maartinj

@mikaelacaron Sure, you welcome 😊 Happy to help with other tasks 👍

Thank you! I can message you here or DM me, I have very specific issues I want to do to wrap everything up and get it shipped this month


binded arguments in the "path" between function's decorator and parameters' decorators are different

Having isuue while running npx nestia setup
Seems like Param's definition as an object is not supported, In Nestjs @Param() params: { id: string; countryId: string } is valid.
@TypedParam() doesn't support it yet.
@Get('/:countryId/states/:id')
  findOneState(@Param() params: { id: string; countryId: string }) {
    return this.countriesService.findOneState(+params.countryId, params.id);
  }

  - binded arguments in the "path" between function's decorator and parameters' decorators are different (function: [countryId, id], parameters: []).

@micalevisk Is this intended spec of NestJS? Or just unexpected behavior but just supported by express?

I don't see anything wrong with that code snippet

Got it, it is supported spec from NestJS, but I'll make it to be a compilation error.

@yadav-saurabh Is it okay to support object typed @Param(), but SDK library decomposes it to individual parameters?

@yadav-saurabh Is it okay to support object typed @Param(), but SDK library decomposes it to individual parameters?

yes, my initial thinking was the same. They are going be individual parameters from the frontend POV, just nestjs (maybe express) makes an object so that's easier to access if there are multiple parameters.

In the object type case, how @nestjs/swagger composes the parameters (OpenApiOperation.parameters) ?

type defs like that has not effect for @nestjs/swagger (the CLI plugin)

In the object type case, how @nestjs/swagger composes the parameters (OpenApiOperation.parameters) ?

type defs like that has not effect for @nestjs/swagger (the CLI plugin)

Then should I define @ApiParam() to the object typed path parameter, and write the object path parameter type with @ApiProperty()?

it will work if you don't use types but concrete classes, due to how tsc works
or if you use @ApiParam(), of course
not sure about the behavior when using both approaches

@micalevisk Thaks for help.
@yadav-saurabh To accomplish this mission, I've to disassemble the object typed @Param() in the compilation level, and it needs lots of change in both @nestia/core and @nestia/sdk projects. Furthermore, as @Param() is not of my development, but of pure NestJS feature, it may needs lots of time.
By the way, this mission's benefit for users is a little bit lower, so that it can be delayed for a while.
Until that, recommend to avoid using the object typed @Param().

@micalevisk Thaks for help.
@yadav-saurabh To accomplish this mission, I've to disassemble the object typed @Param() in the compilation level, and it needs lots of change in both @nestia/core and @nestia/sdk projects. Furthermore, as @Param() is not of my development, but of pure NestJS feature, it may needs lots of time.
By the way, this mission's benefit for users is a little bit lower, so that would be delayed due to lower priority.
Until that, recommend to avoid using the object typed @Param().

Yes, I can understand.
Thanks for the quick response

Will start this ticket after #211


ordinal humans pfp

Hey there, uploaded 6e27a1f92f42d1e41a45a949cb4ed475ced7fd93d012a011f451c30e8d0fe3adi0 as a pfp in meta.json, but it uploaded a random ordinal, could you please change it?

Hello @ordinalhumans , we changed your inscription_icon to 6e27a1f92f42d1e41a45a949cb4ed475ced7fd93d012a011f451c30e8d0fe3adi0. Thank you for your patience. Closing this issue now.


[MM-22841] Add copy URL, download source image icon buttons, to image thumbnail

Summary
Adds the following functionality:
On hover over an image preview, icon buttons appear on the top right of a thumbnail mage so the user doesn't have to open preview to copy link to the image or download.
Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/19369
Related Pull Requests

NA
Screenshots

before

after

Release Note

Added copy URL, and download buttons over image thumbnail for quicker interactions.

Hello @plant99,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Hi @plant99. Thanks for the PR! Apologies for the notification spam while we get everything set up on our end.
Since this is marked as a Draft, I assume you're still working on it. Feel free to let us know if you have any questions about anything around it

Hey @hmhealey no worries at all! Yes, since this is my first PR to this org, it's taking some time for me to get the hang of CI checks and tests. Once I get them all to pass, I'll tag it ready for review, and mention Eric and @ AshishDhama for review.

Hi @AshishDhama this PR is ready for review.

@plant99 thanks for your contribution ... I have some suggestions and changes to be done before we can move on.

@plant99 it looks like some checks failed that are blocking the cloud test server from being created.
Also, I added a case for smaller images in the Figma design file.

@matthewbirtch sure I'll modify this according to the figma file for small images.
Also regarding the failing checks, it's generally taking a long time to do the Setup a remote docker engine process. For other PRs it's generally in seconds, also in this one, there are cases where it succeeded although took a longer time than usual.
@michelengelen thanks for the review, I'll make sure to fix these issues when I open this PR for review again, after accommodating changes for small images.

Thanks for the PR @plant99! Let us know when it's ready for another round of reviews

Hi, @matthewbirtch I don't think the design files consider the collapse button, the left offset of 8px overlaps with the collapse button. Could you please update the file? For now, I'm working with a value that doesn't make the two buttons overlap. It'd be a simple change later.

Hi, @matthewbirtch I don't think the design files consider the collapse button, the left offset of 8px overlaps with the collapse button. Could you please update the file? For now, I'm working with a value that doesn't make the two buttons overlap. It'd be a simple change later.

Ahh, good catch @plant99. I forgot about the collapse icon. I've updated the Figma file to allow for this now.
also, don't forget the border and the shadow on the container
<100px wide

100px wide

Understood, thanks @matthewbirtch , I've made the necessary changes.
One last thing that remains is the definition of small image. In the existing code, small-image__container is only rendered when either dimension is less than https://github.com/mattermost/mattermost-webapp/blob/master/components/size_aware_image.jsx#L10
In the figma file, 100px is mentioned as the threshold for design change.
Which one should I follow for an image of dimension say 52x52 px? (Clearly won't render image inside small-image__container, if I've understood this correctly)

In the figma file, 100px is mentioned as the threshold for design change.

Ya, I recommended his change because moving the hover actions inside the image container only works above 100px.

Thanks @matthewbirtch for the review, I'll ask for a review again when I've fixed these issues.

@matthewbirtch Do we need a collapse icon I mean you have added one which I think can replace the icon (marked in red box) as right now we don't image name?

The latest doesn't show the image name in the expanded state if I remember correctly

One addition note @plant99, can we show these controls when hovering over the image only rather than hovering over the entire row?

Hi @matthewbirtch, the recent commits,

move buttons inside the image only after width = 100 px
address the css changes you commented.
show buttons on image hover, than row hover

Please review again?

@plant99 Just a note on process which you may already know: once you believe you've addressed all of the comments of a given reviewer please click the "Re-request review" icon beside their name so that the PR re-appears in their Review requests list. Thanks.

Looks great @plant99 - just one small change noted in the CSS (I think I missed that in the last round). Should be good after that from a UI/UX standpoint

@matthewbirtch I have a couple questions about the design for this which unfortunately I think might be tough to fix in this PR:

Is the copied link supposed to be a public link that's viewable by users outside Mattermost? If so, that's off-by-default, and we'll have to add a state for when that button isn't visible.
If that is the case, we also don't have the public link available on the post list when this is shown, so we might need to make some changes to the API on the server which we may have to run past the security team. Public links for files are only generated on demand, so we wouldn't have that available without asking the server for it.
Ideally, I think we could get the public link automatically as part of the data sent from the server when loading information about files, but there's a chance that that's a security issue since we currently track when people access the public link for files in the Auditing system. Alternatively, we could fetch the public link when the user clicks on the "copy link" button, but there may be a delay there as we request it from the server, so that could be a UX concern

Is the copied link supposed to be a public link that's viewable by users outside Mattermost? If so, that's off-by-default, and we'll have to add a state for when that button isn't visible.

@hmhealey It's intended to be the equivalent of this that currently exists in the gallery - so I guess it needs to be treated the same
https://community-daily.mattermost.com/files/np37pjdc87d6mq7qngut4kiwic/public?h=_o66hNt6WmVWQ_fujI8lYouNov_wMogJGT5gRw7AqTc

2. If that is the case, we also don't have the public link available on the post list when this is shown, so we might need to make some changes to the API on the server which we may have to run past the security team. Public links for files are only generated on demand, so we wouldn't have that available without asking the server for it.
Ideally, I think we could get the public link automatically as part of the data sent from the server when loading information about files, but there's a chance that that's a security issue since we currently track when people access the public link for files in the Auditing system. Alternatively, we could fetch the public link when the user clicks on the "copy link" button, but there may be a delay there as we request it from the server, so that could be a UX concern

Can we just make it behave exactly the same as it does in the full screen gallery view?

Although waiting for a confirmation from @hmhealey   on @matthewbirtch 's comments , could someone please confirm if https://github.com/mattermost/mattermost-webapp/blob/master/components/file_preview_modal/file_preview_modal.tsx#L260-L272 can be used to know if link-sharing is true ? Or if there's a part of the state which should be looked at?

Although waiting for a confirmation from @hmhealey on @matthewbirtch 's comments , could someone please confirm if https://github.com/mattermost/mattermost-webapp/blob/master/components/file_preview_modal/file_preview_modal.tsx#L260-L272 can be used to know if link-sharing is true ? Or if there's a part of the state which should be looked at?

cc// @hmhealey on the above

@plant99 enablePublicLink is actually the field you want to look at there since that's the one that comes from the config. showPublicLink is used to only show that button for time attachments and not Markdown images or the previews that show if you send a message that contains a link to an image.
Its value comes from https://github.com/mattermost/mattermost-webapp/blob/master/components/file_preview_modal/index.ts#L34

Thanks for the information @hmhealey  will work on this, and I'll re-request review when this logic is changed.

Thanks very much! Let me know if you have any questions or need any help on this since I could definitely see loading the public link for those images on-demand being a bit tricky with our current APIs

Hi @hmhealey , could you please check https://github.com/mattermost/mattermost-webapp/pull/9705/commits/ca4c16a0fb15642c455c948af03c642d0e211c6b?
Also @matthewbirtch this needs a UX review again, since copy URL button is hidden for some cases.

Looks like the download and copy link buttons might be missing an on-click effect. See the post hover menu for examples:
https://gyazo.com/dd4ce25d9c68219d13abb52a467f1b3b
cc// @matthewbirtch

You're right @esethna. Good catch. @plant99 can we add the active state? Should follow the same style as the post hover icon buttons as noted in the example @esethna provided

@plant99 I think there may be a bug where copying the image link, then pasting it in the text input and posting is causing a crash

We should definitely look into that crash. It looks like it has to do with the SizeAwareImage not having a fileInfo passed into it for external images. It should be able to handle when fileInfo is missing

I see that in case of image link embeds, the parent is not SingleImageView, but post_view/message_attachment.
Also there are other parents namely post_view/post_attachment_opengraph, markdown_image/markdown_image.jsx, components/post_view/post_image/post_image.
I'll modify SingleImageView to account for other sources of images while rendering copy and download buttons.
Meanwhile, the crash was due to a reference to fileInfo without checking if it's valid.

I see that in case of image link embeds, the parent is not SingleImageView, but post_view/message_attachment.
Also there are other parents namely post_view/post_attachment_opengraph, markdown_image/markdown_image.jsx, components/post_view/post_image/post_image.
I'll modify SizeAwareImage to account for other sources of images while rendering copy and download buttons.
Meanwhile, the crash was due to a reference to fileInfo without checking if it's valid.

Continuing on this, for images of which the sources are external, like from link attachments or markdown image tags.

Should copy link functionalities be available for them? Download button can use fileURL / src props.
If yes, are there recommended ways to distinguish these two types of images from any prop? One can always use class names, wanted some opinions. Since  getting a public url from server won't be necessary for images with external source.

cc: @hmhealey

I'd say they probably should. They're different, but we've been slowly but surely making them work the same over time. That also applies to Markdown images (from typing something like ![alt text](https://example.com/image.png)).
I think the biggest difference between them would probably be whether or not that postInfo prop is provided since it would be provided for image attachments, but not for external images

Thanks @hmhealey for the suggestions and reviewing again, and apologies about the rebase I had realized later, but it won't happen again :)
Also thanks @michelengelen for reviewing again, I've understood both of your suggestions and will implement them asap.

Seems like there might be a z-index issue now on smaller images:

Thanks @plant99
few small issues

on some markdown images, collapse button is behind the image

wide images are not displaying correctly, container is too wide, copy/download icons are out of view

smaller markdown image links have the buttons slightly cut off on the top

E2E report has high number of failures (54) vs. master (36), not sure yet if many are related to this PR. I will re-run after above is fixed.

Thanks for pointing it out, have fixed this, please check.
There is a constraint on width of images in master, it's mostly something I've changed, will push a fix asap.
@matthewbirtch need some inputs on this(case of  smaller markdown images) again, should we reduce the size of buttons in this case, to accommodate the size of image? Or should I look into making the post at least the size of these buttons?

I thought the minimum size of those images was larger so that that sort of thing wouldn't happen? I'm surprised that the minimum is only 50px tall and not more like 100-150px.

@jgilliam17 could you please run E2E tests again? I've fixed the issues you had mentioned above along with Matthew's suggestions.

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/177110

Thanks @plant99
E2E report pending
Seeing one issue, copy/download button on wide images is positioned slightly off the image

Oh @jgilliam17 I think it's a requested feature by @matthewbirtch only for images treated as 'small'.

Oh @jgilliam17 I think it's a requested feature by @matthewbirtch only for images treated as 'small'.

@plant99 @jgilliam17 yes, this is as expected. However, maybe if the image is small in height, but wider than 100px, we can adjust the positioning so it doesn't have to sit so far off the right edge?

/update-branch

Thanks @plant99
Tested, looks good to merge.

Verified copy/download button on images
E2E report looks good, no PR related failures.

@hmhealey gentle ping on this.

Thanks again for the PR, @plant99! Definitely looking forward to having this in since it'll definitely help those images feel polished

Thank you for helping folks, it was my first major PR to this repository and learned a lot from it. Would definitely help me make meaningful changes quicker for the upcoming ones!


Update help.md

It is missing info about --sub-directory  and also it has reference link to degit repo instead of tiged. So fix that too.

It appears I've already done this ages ago. lol


Latest release doesnt work

crashes on compile in host project ...

somehow it seems elixirc_paths isnt used when compiling the dependency ...

need to override files in package config ref https://github.com/testcontainers/testcontainers-elixir/commit/5386a3c20d5e042e1c5e870d4bfe3401f0891a71

fixed by https://github.com/testcontainers/testcontainers-elixir/commit/480355d4cefe0fd232755ee6ad8d2c0da1b480f9


Add control mechanism for collecting performance and usage data

On July 18th of 2018 the publishing of versions 1.10.8 and 1.10.9 inclusively have been disabled after their review on Mozilla Add-ons.
In order to continue publishing releases, we must conform to Add-ons
Add-on Policies.
This requires us to disclose how the add-on collects, uses, stores and shares user data in the privacy policy field on AMO. In addition, users must be provided a clear way to control this data collection and the control mechanism must be shown during the installation process of the add-on.
This issue should handle the introduction of the control mechanism, where we provide users the ability to control the collection of performance and usage data.

copy for privacy notice for add-on:

We collect automated error and crash reports as well as general usage statistics.
We use this information to better understand the most used integrations and to help us fix issues as they appear.
All information we collect is anonymized.
We collect usage statistics through Google Analytics:

analytics tracking ID
generated user ID (anonymized, not tied back to Toggl account)
user activity in the add-on (which features and integrations are used)
add-on settings

When a crash or error occurs, we collect the following information via Bugsnag:

Toggl user ID
add-on version, the user's operating system
log of the error and error message

The data collected in the add-on is also covered by the policies in our Privacy Policy: https://toggl.com/legal/privacy/

We're back on :fox_face:, with new privacy controls and an updated policy. Thank you everyone for your patience :bowing_man:!


Allow to route through highway=construction

In some usecases it would be useful to treat highway=construction as accessible roads.
For example, I could use map matching API to snap some older GPX track and get OSM informations. This would allow to maintain original GPX geometry without avoiding roads under construction.
By default highway=construction shouldn't be accessible but there should be an option to change that with custom profile.
link to the forum discussion

@karussell I think it's not enough. I had to add "construction" to allowedHighways here.
But then construction ways are included by default so they would have to be de-prioritized by default somehwere.

@karussell without changing BikeCommonAccessParser.java it's not working.

After adding changing BikeCommonAccessParser:

@karussell Your custom model worked server side! I need to read more about client vs server side models.
Open PR with adding CONSTRUCTION TO RoadClass?

Thanks for the explanation. I'll prepare the PR shortly.


add SpinButton component #261

This closes #261

the branch name is not totally compatible with our branch naming conventions :)
Please review other PRs in order to find out about your mistakes here.

please resolve the conflict


[Docs]: add best practice guide

In the last core meeting, we came up, that we want to have an official recommendation within the official docs. It should include:

Don't sub-class
handling subscribe + unsubscribe
mention linting rules
...

I'm very open to any kind of suggestion, so please let me know about anything you could think of.

@JWO719 is wonderful!
I suggest adding the article https://medium.com/p/92502d5639d0 to explain handling subscribe-unsubscribe

The section should clarify what .subscribe does. It ends composability.
Subscribe starts a process and/or is here to perform a side effect.
If people want to compose the values further they should not subscribe.
Even if it a very essential basic practice shows this is not clear.

Error handling should also be implemented

Build own operators (i know that rxjs docs already have it but that could be a good point for best practice guide)
The general rule is for takeUntil to be placed last (Avoiding takeUntil Leaks)

Cover testing as well please, the marble tests can be tricky sometimes. I'd like to see more examples of more complex scenarios.

I think @cartant 's rxjs-tslint-rules should be mentioned as well.

Hi @JWO719
I think it should include also performance tips and common mistakes that can lead to memory leaks.
Thanks

As far as I know there is no official best practices page in the docs, and I would love to create one, using both my experience with the library (I've written several articles on both good approaches and incorporating RxJS in Angular, see: this, this and this one) and the advice shared by contributors in this thread. Is there anything that could block me? What is a good starting point? Any insight on how that page will be located and what it could look like, also, how much creative freedom can I have if we choose to go forward with it?

@Armenvardanyan95 I can contribute on this also

@lamisChebbi thank you. I have created a markdown file where I have written some introductory stuff. I can create a separate repo with it, until we understand how we proceed with that doc inside RxJS docs

hi @Armenvardanyan95 & @lamisChebbi please feel free to make suggestions for such a page. It would basically require a seperate md document in the docs_app project and an adjustment in the navigation.json file to make your changes reflect in the navigation menu.
I would highly appreciate suggestions from your side and iterate over a pr together with you, if that would work for you?
Is there anything else I could help you with to get you started with it?

@niklas-wortmann thanks a lot. I have started working on an md file, I will continue working on an initial version of it for a day or two and then submit a pr, then we can probably discuss it more concretely. As of I don't have specific questions, there is lots of thoughts in this very thread I can use as guidance, we will see then how it goes

@niklas-wortmann Although upon re-reading this thread I have q question. You mentioned in the very first comment "don't subclass", do you mean that we should not subclass Observable classes and use customized versions? Why is that so? I have not been aware this is an antipattern

yeah that's exactly what I meant. We came around this issue a couple of times, here's one reference I found quickly:
https://github.com/ReactiveX/rxjs/issues/5431
The problem is basically, that it is quite easy to shoot yourself in the foot and it might break when we do changes to those classes as there are very tightly coupled this way

Thank you. I will add that to the doc

@lamisChebbi @niklas-wortmann I submitted an initial PR, would be happy to continue discussion there and hear opinions on how it can be improved
https://github.com/ReactiveX/rxjs/pull/6157


Functional Programming slide

Adds a slide to explain Functional Programming
Please @rafaparadela could you review? Thanks

LGTM


Version of zoom-sdk ?

which version of zoom sdk ( android and ios) are you using?

It is older version as newer version removed support for user login to start the meeting.....not it need jwt to start the meeting

But the current version of the SDK do not include Android 12 support, which cause an immediate crash on Android 12.

But the current version of the SDK do not include Android 12 support, which cause an immediate crash on Android 12.

ok will find out the way to deal with it.

Unfortunlly it is a very high priority requirement because a lot of devices are updating to Android 12 now and the new devices is already shipped with it by default.
Would be great if we see an update in the next days ❤

Unfortunlly it is a very high priority requirement because a lot of devices are updating to Android 12 now and the new devices is already shipped with it by default.
Would be great if we see an update in the next days ❤

working on it to shift to jwt.....but will be available to use old sdk too

Great News, waiting for that ❤
Thanks ❤

Could you please tell me which version zoom sdk is being used? It would be nice if you can put the zoom sdk version info in readme too. Thanks heaps!


Dccf name changes

@srveit 2nd try!
https://ctliotest.atlassian.net/browse/CTLIO-646

@srveit is this something you can override? I think it is addressed in the redirects that I submitted separately.

No. Edit Cloud Application Manager/Core Concepts/providers.md and remove the reference to Dedicated Cloud Compute/Dedicated Cloud Compute Foundation/dcc-foundation-in-cloud-application-manager.md

@srveit ready to merge!


Cannot list all DBs from a virtual MYSQL Server (by CData SQL GateWay) But Workbench Can

System information:

Operating system (distribution) and version: Win10 Updated
DBeaver version Version <IP_ADDRESS>005311732
Additional extensions

Connection specification:

Database name and version MYSQL ( Virtual MYSQL Server by CData SQL Gateway latest version )
Driver name mysql:mysql-connector-java:RELEASE
Do you use tunnels or proxies (SSH, SOCKS, etc)? No

Describe the problem you're observing:
There two Databases in CData Gateway, CData Acumatica Sys and INFORMATION_SCHEMA.
But Dbeaver cannot list any database.
In Creating Connection screen, we can put one database name, but it couldn't use  IntelliSense function because of no INFORMATION_SCHEMA database.
However, Workbankch (6.3 64bit) it works fine, it can list all database and IntelliSense well.
Steps to reproduce, if exist:
Include any warning/errors/backtraces from the logs

hi @BillVSGitHub ,
do you have Show system objects enabled in connection property (F4)?

Hi There,
I appreciate the fast response,
Yes, that box has been ticked as default.
It could not list any database, but it can query the default database which is setup in the connection.
Thanks,
<EMAIL_ADDRESS>Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From<EMAIL_ADDRESS>Sent: Wednesday, 3 June 2020 11:52 PM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [dbeaver/dbeaver] Cannot list all DBs from a virtual MYSQL Server (by CData SQL GateWay) But Workbench Can (#8873)
hi @BillVSGitHubhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBillVSGitHub&data=02|01||0c8516e1f5e2487d82a008d807c56148|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637267891602068565&sdata=ZB1IU1NBL3fv0XU5g0IkcDSk06tOq9myQAws5V3b9n8%3D&reserved=0 ,
do you have Show system objects enabled in connection property (F4)?
[image]https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F31996417%2F83644975-945f6000-a5ba-11ea-9c5a-92702b35d5f1.png&data=02|01||0c8516e1f5e2487d82a008d807c56148|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637267891602078556&sdata=5BDOLjixyd%2Fd2IYTiCXLKFghVGDojuIr%2BW7aSC05JAk%3D&reserved=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdbeaver%2Fdbeaver%2Fissues%2F8873%23issuecomment-638212402&data=02|01||0c8516e1f5e2487d82a008d807c56148|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637267891602088557&sdata=OmYx3W0SMrb1dC%2F6EMBXqRnPGspzraoppZ3cuNeeKmY%3D&reserved=0, or unsubscribehttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAP2GT4CYR5RD666RDOVLSWTRUZISLANCNFSM4NRKM5VA&data=02|01||0c8516e1f5e2487d82a008d807c56148|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637267891602088557&sdata=NhkqrVxDn9YKo06Ef3EHAk9TS4BV5v3TuhyqVwJVk%2Bc%3D&reserved=0.

Am I correct that you do not see available databases in DB Navigator tree?

Doesn't SQL Assist function work in SQL Editor?
Does this issue still exist in 7.1.3 release https://dbeaver.io/download/?

Yes,
It still does not work in 7.1.3 but workbench can for same CData server
<EMAIL_ADDRESS><EMAIL_ADDRESS>Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From<EMAIL_ADDRESS>Sent: Thursday, 23 July 2020 6:49 PM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [dbeaver/dbeaver] Cannot list all DBs from a virtual MYSQL Server (by CData SQL GateWay) But Workbench Can (#8873)
Am I correct that you do not see available databases in DB Navigator tree?
[dbeaver_qqWgyN3ZtM]https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F51405061%2F88267940-432a3d80-ccda-11ea-933f-f59875ec095e.png&data=02|01||7f02cf8ad6624b8ba96908d82ee56014|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637310909972332355&sdata=W4FH4HpprNQ%2BMjZ2PwcrWaIWsohzem1fkr27P99g18U%3D&reserved=0
Doesn't SQL Assist function work in SQL Editor?
Does this issue still exist in 7.1.3 release https://dbeaver.io/download/https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdbeaver.io%2Fdownload%2F&data=02|01||7f02cf8ad6624b8ba96908d82ee56014|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637310909972332355&sdata=kyyMnOYqDLuLdk9p5q1HT4Yj%2FE6u9BW5jZf2Gh0jg3E%3D&reserved=0?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdbeaver%2Fdbeaver%2Fissues%2F8873%23issuecomment-662891768&data=02|01||7f02cf8ad6624b8ba96908d82ee56014|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637310909972342346&sdata=KHEWJ%2BReaY0Rzuq0%2BCg3WI5SVy8el5IwOJIHSBuzbx4%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAP2GT4EBDMJA4WFKBCKRGDTR472TJANCNFSM4NRKM5VA&data=02|01||7f02cf8ad6624b8ba96908d82ee56014|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637310909972342346&sdata=M%2B7hgCHwX1cTrvVytnIX2sjuyk7mAtxxrSGpJ8hP3Jg%3D&reserved=0.

Please send screenshot how your database looks now in DB Navigator tree

there are not any update on issue for a long time.
If issue is still actual for you - feel free to reopen the ticket with additional info that could help to investigate and reproduce an issue.


Fix type preventing it from working

Fixed in latest commit, could not merge because I had local changes that have not been pushed. Thank you for raising this PR.


Limit the resources used by the asynchronous cache filling process

Is your proposal related to a problem?
The async cache filling process may use a significant amount of CPU and network resources on both sides of the thanos-store and the cache service. This could potentially have a negative impact on regular query requests. Furthermore, frequently adjusting the configuration requires the thanos-store to be restarted.
Describe the solution you'd like
One idea is to implement the circuit breaker pattern to dynamically limit the asynchronous cache filling requests when latency or timeouts increase significantly.
Describe alternatives you've considered

Perhaps consider adding some additional options to reduce concurrency when there are ongoing user queries.
Additional context

(Write your answer here.)

This makes total sense. We found similar issues as well when backfilling a large amount of data to cache, especially postings.
Circuit breaker is a good idea.

Is this issue ok to be closed?


Control Bridge device type is missing from esp-matter (CON-1279)

@jonsmirl Thanks for the report, we will add it soon!!


Disable running of tests.

Disable running of tests because our test setup hasn't been configured yet.
Signed-off-by: Ringo De Smet<EMAIL_ADDRESS>

You have a point. Closing this one in favor of #56


Server table & data tests failing (not finding IP address)

This came up when I was working on something else, realized these tests fail even for master branch:
  1) Servers index table displays server information
     Failure/Error: expect(body).to have_text('<IP_ADDRESS>0')
       expected to find text "<IP_ADDRESS>0" in "Quimby Quimby Repositories Servers server-dev pupgraded"
     # ./spec/features/servers_table_spec.rb:10:in `block (2 levels) in <top (required)>'

  2) ServerPuppetdbData#load_data with valid response creates objects from api response
     Failure/Error: expect(server.ip).to eq '<IP_ADDRESS>0'

       expected: "<IP_ADDRESS>0"
            got: nil

       (compared using ==)
     # ./spec/models/server_puppetdb_data_spec.rb:29:in `block (4 levels) in <top (required)>'

It just looks like the ip address isn't getting passed in the test object, but happy to try to look at later today if someone else doesn't have time / can't fix in like 2 seconds.

stubbed out fake responses to the puppetdb api calls, and the tests work.
not sure why tests should rely on access to an external service (especially when fake responses are given), and that seems problematic. but happy to close this and consider my own ignorance the reason.


Replace --quit with --quit-after <number-of-iterations>

Combined with #73564 , this would allow pixel-perfect reproducible movie captures to be automatically recorded from nearly any public Godot project for regression testing,[^can] greatly expanding the potential test coverage of Godot rendering.
[^can]:Notable candidates being godot-benchmarks and godot-demo-projects
Note that as OpenGL/Vulkan renders are not consistent across hardware, captures will need to be made and compared in the same script to work.
Example shell script:
$GODOT_BIN_A --random-seed 5 --fixed-fps 10 --quit-after 20 --write-movie /tmp/capture.avi
shasum /tmp/capture.avi >/tmp/capture.sha

$GODOT_BIN_B --random-seed 5 --fixed-fps 10 --quit-after 20 --write-movie /tmp/capture.avi
shasum -c /tmp/capture.avi

Note to self: document this in the Creating movies page if this is merged, as this can be useful as an alternative to AnimationPlayer's Movie Quit on Finish property.

This PR doesn't remove --quit, but it now shows a deprecation warning that recommends using --quit-after 1 instead. As long as the behavior of --quit hasn't changed it doesn't break compat.
Or maybe what you are saying is that --quit should not be deprecated and serve as a shorthand for --quit-after 1.

Why not keeping both --quit and --quit-after?

I've observed that most projects prefer to avoid duplicate functionality, only adding shorthands/aliases for commonly used features.
I don't have a strong opinion on this, though. What's the typical decision for Godot in these cases?

I would keep both, because a lot of users use --quit and forcing them to do --quit-after 1 when they don't need the additional functionality provided here seems unnecessary.

Looks good! Just needs updating the commit message itself too like the PR title was.

Oops, fixed

Thanks!


404 Not Found

14: from /Users/tommysadiqhinrichsen/.gem/bin/babelfish:23:in `<main>'
13: from /Users/tommysadiqhinrichsen/.gem/bin/babelfish:23:in `load'
12: from /Users/tommysadiqhinrichsen/.gem/gems/babelfish-0.0.1/bin/babelfish:15:in `<top (required)>'
11: from /usr/local/Cellar/ruby/2.6.1/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
10: from /usr/local/Cellar/ruby/2.6.1/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
 9: from /Users/tommysadiqhinrichsen/.gem/gems/babelfish-0.0.1/lib/babelfish.rb:10:in `<top (required)>'
 8: from /Users/tommysadiqhinrichsen/.gem/gems/babelfish-0.0.1/lib/babelfish.rb:39:in `<module:BabelFish>'
 7: from /usr/local/Cellar/ruby/2.6.1/lib/ruby/2.6.0/open-uri.rb:31:in `open'
 6: from /usr/local/Cellar/ruby/2.6.1/lib/ruby/2.6.0/open-uri.rb:736:in `open'
 5: from /usr/local/Cellar/ruby/2.6.1/lib/ruby/2.6.0/open-uri.rb:165:in `open_uri'
 4: from /usr/local/Cellar/ruby/2.6.1/lib/ruby/2.6.0/open-uri.rb:224:in `open_loop'
 3: from /usr/local/Cellar/ruby/2.6.1/lib/ruby/2.6.0/open-uri.rb:224:in `catch'
 2: from /usr/local/Cellar/ruby/2.6.1/lib/ruby/2.6.0/open-uri.rb:226:in `block in open_loop'
 1: from /usr/local/Cellar/ruby/2.6.1/lib/ruby/2.6.0/open-uri.rb:756:in `buffer_open'

/usr/local/Cellar/ruby/2.6.1/lib/ruby/2.6.0/open-uri.rb:378:in `open_http': 404 Not Found

Happens every time and on all commands


Create Figma For Demo Website

We need to create a Figma file for the demo website of this package. This should server as a reference for the UI/UX design and layout of the demo website. This website should of course showcase all components/features.
Maybe there are some creative people who want to work on this, I would greatly appreciate it!

Hey @gxrsti,
Let me know if I can work on this !
Best regards,
Kabiir Krishna

Hey @Kabiirk!
Of course,assigned you this issue! Thanks for helping out!

Thanks ! appreciate it !

Closed with #35


Create patterns folder and multiple-choice pattern

Created the patterns folder and the multiple choice pattern, and added preliminary multiple choice documentation (WIP)

Closing this since it's stale now. We can reopen if needed.


{pkg/trace/api,cmd/trace-agent}: use container's procfs for pid-cid mapping

What does this PR do?
This commit causes the agent to always use its own procfs (/proc) to map PIDs to container IDs.
Motivation
Previously, the ID Provider was using the host's procfs (/host/proc) when available. This does not work with UDS, since the PID we receive is always in the agent's pid namespace. Instead, the agent must always read its own procfs, otherwise it will get wrong data.
This will specifically affect deployments where the agent is not in the host's PID namespace, but shares a PID namespace with the application.
Additional Notes
https://github.com/DataDog/datadog-agent/pull/13224
https://github.com/DataDog/integrations-core/pull/13183

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

We don't have good automated tests for this. I don't know if you kept your notes from deploying to k8s under cgroup v2, but that will be required for testing this.
I've done some manual testing locally, but this should be tested on k8s again.


Remaining links to Delivery API in legacy location

Issue in /src/pages/before-administer/recs-api/fetch-recs-server-side-delivery-api.md
Example:
"Once you have your client code, construct your Delivery API call. The example below begins with the Web Batched Mboxes Delivery API Call provided in the Delivery API Postman collection, making relevant modifications."
Check repo for instances of "/api/" to find both Delivery API legacy locations, as well as any errant references to old "/api/" file structure.

Fixed when fixed Issue #108


link text is dup

from JPN feedback:  should be sync w/ the title on the target page?

@SunnyDeng : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@SunnyDeng Thanks for your feedback. After investigating, we've discovered that the content is intentional as there are 2 versions of the command. Therefore, we respectfully decline to fix this. But, thanks again; we always appreciate feedback on our documentation
Because we cannot change the referenced page to include the information and functionality that you're asking for, we are closing this issue.
#please-close


component refactoring

refactoring class based componemt to funtional componrnt in src/component/Search/Search.jsx

@jasim00021 you need to sign the Plone Contributor Agreement to merge this pull request.
Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

chengelog

@jasim00021 you need to sign the Plone Contributor Agreement to merge this pull request.
Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@jasim00021 you need to sign the Plone Contributor Agreement to merge this pull request.
Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement


Include steps for gaining access to volumes created before upgrade to FAQ

Release 0.10 needs a manual upgrade step documented here. The current steps do not include a process for for restoring access to volumes created before upgrade.

Fixed in https://github.com/vmware/docker-volume-vsphere/pull/843


Python: No idea!

Hackerrank problem link
Provide your hackerrank problem link here.
https://www.hackerrank.com/challenges/no-idea/problem?isFullScreen=true
Issue Checklist

[ ] If you have previously contributed to this repo, you declare that you have not made a pull request for more than one issue in this repo till now.
[x] Your forked repo is up-to-date with the the origin remote.
[x] Have you checked that the hackerrank problem you are raising is not already present in the repo?
[x] Have you checked that the hackerrank problem you are raising is not raised by or assigned to another contributor?

Hacktoberfest Contributor

[x] Are you a Hacktoberfest Contributor?

Any other Changes?
NA

@PurviSaini
It's great that you contributed to the repo twice😃🥳.
Unfortunately, I cannot assign you more than two issues for this repo.
You may look into some other repos for hackrtoberfest contribution.
Thanks😃!All the best!

@Riddhi9570 Can you assign this issue to me. I am eager to contribute to this Hackerrank problem

@PurviSaini It's great that you contributed to the repo twice😃🥳. Unfortunately, I cannot assign you more than two issues for this repo. You may look into some other repos for hackrtoberfest contribution. Thanks😃!All the best!

No problem, Thankyou so much for the considering the previous contribution!!

@ShivayeModi
I've assigned you the issue and you may please go ahead!
Happy Coding😃!

@Riddhi9570
I have solved the given problem, you can review my pull request now.
Thanks 😃


ILS Answers are processed by an algorithm in the Backend

User Story
As a Student i want to fill out the ILS Questionnaire and get Results.
Acceptance criteria

[ ] ILS Answers are processed by an algorithm
[ ] After determining the dimensions, the user can see his results in the Frontend
[ ] Marcs Learning Path Algorithm can use the determined dimensions to calculate the student paths

Definition of Ready

[ ] User Story is small enough for Sprint
[ ] User Story is clearly understandable for everyone involved
[ ] User Story effort is estimated
[ ] User Story has acceptance criteria
[ ] User Story has added value for the product or development
[ ] User Story origin is known (stakeholder)
[ ] User Story is assigned to Release
[ ] Backend and Frontend are cloned from GitHub and Running locally
[ ] Basic knowledge of the backend and frontend architecture
[ ] Activity diagram (or sequence diagram) screenshot in issue

Definition of Done

[ ] All acceptance criteria are met
[ ] The implementation of the User Story has been successfully accepted by the Product Owner
[ ] The implementation is in GitHub
[ ] A code review has been performed (or created in pairing program)
[ ] Code conventions are followed
[ ] Unit test coverage must be greater than 90%
[ ] All tests must have passed
[ ] Technical documentation created (Feature documented in GitHub Wiki)
[ ] UML class diagrams and component diagrams created and up-to-date
[ ] Documentation in realization created (source code)
[ ] Changelog created (Clear description in merge request)
[ ] There are no known bugs

ILS results should be determined with a basic algorithm:

answering a dimension with a) (+1) or b) (-1) impacts the results accordingly


In Admin in Production the sidebar with cover details is missisng

Here is how it looks in production:

Here is how it looks in development:

Let me have a look this weekend.


Vim segfaults when built with CCE compiler

I'm trying to build Vim 8.1.0338 with CCE 8.4.6 on a Cray supercomputer but it segfaults when I try to open any file:
Vim: Caught deadly signal SEGV
Vim: Finished.
Segmentation fault

Here is the build log and build environment. Let me know if I can provide you with any other debug information.

Hard to tell what's going on. I don't have a cray supercomputer to reproduce :-)
Can you get a stack trace where it crashes?
Hopefully there is a debugger to get a stack trace.
At https://support.pawsey.org.au/documentation/display/US/Compiling+on+a+Cray I see that it should be possible to build either with the cray compiler (i.e. the one you used), the Intel compiler or gcc.
Did you try with other compilers than craycc?
With gcc on Ubuntu, I know that vim crashes at startup when it's not built with -D_FORTIFY_SOURCE=1.
I wonder whether the same happens with craycc.
You could try to add -D_FORTIFY_SOURCE=1  the compilation flags.

Maybe you've fallen athwart of the following warning:
Cross Compilation

Note that code compiled on the front end is compiled to run on the back end
(it is a "cross-compilation"). Attempting to run an executable containing instructions
- specifically vector instructions - for the back end (Haswell architecture on Magnus
and Ivybridge on Galaxy) on the front end (Sandybridge architecture on both Magnus and
Galaxy) will result in
    magnus-1:-> ./a.out
    Illegal instruction
for code compiled under PrgEnv-cray or
    magnus-1:~> ./a.out
    Please verify that both the operating system and the processor support
    Intel(R) MOVBE, F16C, FMA, BMI, LZCNT and AVX2 instructions.
for code compiled under PrgEnv-intel.

So, executables can not, in general, (and should not) be run on the front end.
All production work is carried out on the back end via the queue system (see below).

IIUC, "via the queue system" means in batch. (Again, IIUC), you cannot compile interactive programs such as Vim, because these have to be run on the frontend and the compilers available to you are cross-compilers producing code for the backend.

Did you try with other compilers than craycc?

Yes, I tried GCC 7.3.0 and that worked.

you cannot compile interactive programs such as Vim, because these have to be run on the frontend and the compilers available to you are cross-compilers producing code for the backend.

I think the login nodes use the same architecture as the backend nodes on this cluster, but I'm not sure.

Can you get a stack trace where it crashes? Hopefully there is a debugger to get a stack trace.

gdb, ddt, atp, and stat are all installed. But I don't know how to use them. Can you tell me what to do to get a stack trace?

@adamjstewart wrote:

gdb, ddt, atp, and stat are all installed. But I don't know how to use them.
Can you tell me what to do to get a stack trace?

First make sure that vim is not stripped. You can uncomment this line in vim/src/Makefile:
STRIP = /bin/true

It's also best to rebuild also with compilation options -g -O0  (for symbols and to avoid optimizations)
with this line in vim/src/Makefile:
CFLAGS = -g -O0

Rebuilding vim and run vim in gdb using:
$ cd vim/src
$ make clean
$ make
$ gdb --args ./vim
...
(gdb) run

If vim crashes, you can get a stack trace with the 'bt' gdb command:
(gdb) bt

Or if you ran vim without gdb and get a core dump file, you can look at the
stack post-mortem from the core dump:
$ cd vim/src
$ ./vim
...
core dump

$ gdb ./vim core
(gdb) bt

Okay, here is what I'm getting:
$ gdb --args ./vim
Reading symbols from /mnt/c/scratch/sciteam/stewart1/vim-8.1.0338/src/vim...done.
(gdb) run
Starting program: /mnt/c/scratch/sciteam/stewart1/vim-8.1.0338/src/vim
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Error detected while processing /mnt/a/u/sciteam/stewart1/.vimrc:
line   25:
E484: Can't open file /usr/local/share/vim/syntax/syntax.vim
Press ENTER or type command to continue
Program received signal SIGSEGV, Segmentation fault.
0x00000000005f2929 in RealWaitForChar$$CFE_id_2c0cb807_352a1cd6 (fd=0, msec=0, check_for_gpm=0x0, interrupted=0x0) at os_unix.c:6268
6268		FD_ZERO(&rfds);
(gdb) bt
#0  0x00000000005f2929 in RealWaitForChar$$CFE_id_2c0cb807_352a1cd6 (fd=0, msec=0, check_for_gpm=0x0, interrupted=0x0) at os_unix.c:6268
#1  0x00000000005f2662 in mch_breakcheck (force=0) at os_unix.c:5958
#2  0x000000000070758e in ui_breakcheck_force (force=0) at ui.c:416
#3  0x000000000070754e in ui_breakcheck () at ui.c:396
#4  0x00000000005238fd in vgetorpeek$$CFE_id_7256f6ca_489242a3 (advance=1) at getchar.c:2078
#5  0x0000000000522b53 in vgetc () at getchar.c:1634
#6  0x000000000052346a in safe_vgetc () at getchar.c:1838
#7  0x000000000077c5b6 in wait_return (redraw=1) at message.c:1128
#8  0x00000000007708c2 in vim_main2 () at main.c:695
#9  0x0000000000770357 in main (argc=1, argv=0x7fffffff3cc8) at main.c:443

Is this the error message?

Can't open file /usr/local/share/vim/syntax/syntax.vim

Or is that just because it thinks it should be installed in /usr/local but I haven't ran make install yet so it doesn't know where to find its syntax.vim file?

If you haven't yet ever run make install for Vim on this system, then $VIMRUNTIME hasn't yet been created; its default location for self-built versions of Vim on Unix-like systems is /usr/local/share/vim/vimxx/ with xx replaced by the major version (i.e. 81 at the moment).
IMHO, of course, a crash is a bug come hell or high water; yet I'm still curious (if it isn't an abuse of your time) to know what happens if you run the same test again with the same binary (the one under src/ in the source clone, which is never stripped, not even if you don't specify not to strip) but after running make install.
That $VIMRUNTIME/syntax/syntax.vim script is responsible for the :syntax on command (this built-in command, and a few others, are programmed in Vim script rather than in C).

I no longer use the CCE compilers, so I'll close this issue.


Minor documentation issue with backward/derivative

Describe the bug
The documentation in tutorial/advanced/index.rst reads:

Next, we use the derivative method to see how a small change in p would affect the solution x. We will perturb p by 1e-5, by setting p.delta = 1e-5, and calling the derivative method will populate the delta attribute of x with the the change in x predicted by a first-order approximation (which is dx/dp * p.delta).

p.delta = 1e-5
problem.backward()
print("x.delta is {0:2.1g}.".format(x.delta))

In this case the solution is trivial and its derivative is just 2*p, we know that the delta in x should be 2e-5. As expected, the output is

Note that in the first paragraph it says "calling the derivative method will", but in the code sample the backward() method is used. I haven't been able to upgrade to 1.1.11 locally, so I can't test if they give the same result, but something here seems incorrect.

Thanks for reporting! We'll fix this, the code sample should call the derivative method.


CI fails for PR contributions from other than weaveworks/scope...

See: https://circleci.com/gh/weaveworks/scope/4769
Its due to the image tagging.

Fixed by #1655.
(although we currently have "Run forked pull requests" turned off)


feat: agent install name

Implemented the option to change the container name of dagent, to avoid name collision when installing multiple agents on the same node.

The same collision is true for crane as well. The name workload would be more appropriate to address the running instances of both environments.