git worktree add fails because JSON5 is not available to tools/check-devcontainer-version.js

I relied on JSON5 to parse .devcontainer/devcontainer.json because JSON can not parse JSON files with comments.
vscode@9099a05e6679:/workspaces/challenge-registry$ git worktree add ~/challenge-registry-hyperfine
Preparing worktree (new branch 'challenge-registry-hyperfine')
HEAD is now at 2ec772a feat: update Node.js and Java packages via git hooks only when required (#582)
✨ Preparing Node.js packages
✨ Preparing Java packages
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module 'json5'
Require stack:
- /home/vscode/challenge-registry-hyperfine/tools/check-devcontainer-version.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/vscode/challenge-registry-hyperfine/tools/check-devcontainer-version.js:4:15)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/vscode/challenge-registry-hyperfine/tools/check-devcontainer-version.js'
  ]
}
husky - post-checkout hook exited with code 1 (error)

Solutions:

Remove comments from .devcontainer/devcontainer.json and use the library JSON with is available with Node.js.
Make .devcontainer/devcontainer.json more portable, possibly by writing it in bash.

git worktree add <new branch> now works as expected:
vscode@ade7130aff68:/workspaces/challenge-registry$ git worktree add ~/second-feature
Preparing worktree (new branch 'second-feature')
HEAD is now at 90135cc fix: `check-devcontainer-version.js` no longer needs non-native Node packages (#595)
✨ Preparing Node.js packages
✨ Preparing Java packages

vscode@ade7130aff68:/workspaces/challenge-registry$ git branch
  connect-app-and-backend
  doc-linter-formatter
  document-stack-components
  gradle-unit-integration
* main
+ second-feature

vscode@ade7130aff68:/workspaces/challenge-registry$ cd ~/second-feature/

vscode@ade7130aff68:~/second-feature$ ls
LICENSE.txt  babel.config.json            checkstyle.xml      docs                           gradle.properties  jest.config.ts  nx-cloud.env.example  settings.gradle     workspace.json
README.md    build.gradle                 dev-env.sh          eclipse-java-google-style.xml  gradlew            jest.preset.js  nx.json               tools               yarn.lock
apps         checkstyle-suppressions.xml  docker-compose.yml  gradle                         gradlew.bat        libs            package.json          tsconfig.base.json


Fix openssl

@ethanrublee @isherman I think this is ready to merge to build this reliably on MacOS.


CLMUL - remaining functions

https://en.wikipedia.org/wiki/CLMUL_instruction_set

PCLMULLQLQDQ xmmreg,xmmrm	[rm:  66 0f 3a 44 /r 00]	Multiply the low halves of the two registers.
PCLMULHQLQDQ xmmreg,xmmrm	[rm:  66 0f 3a 44 /r 01]	Multiply the high half of the destination register by the low half of the source register.
PCLMULLQHQDQ xmmreg,xmmrm	[rm:  66 0f 3a 44 /r 10]	Multiply the low half of the destination register by the high half of the source register.
PCLMULHQHQDQ xmmreg,xmmrm	[rm:  66 0f 3a 44 /r 11]	Multiply the high halves of the two registers.

PCLMULQDQ is already implemented: https://github.com/simd-everywhere/implementation-status/blob/main/x86.md#pclmulqdq

There is no intrinsic defined for PCLMULLQLQDQ, it seems..

PCLMUL[L/H]Q[L/H]QDQ is a "Mnemonic specifying specific values of the immediate operand".
So it is just some cheeky disassembly naming.
aka. PCLMULQDQ(a, b, 0) == PCLMULLQLQDQ(a, b)
SIMDe operates at the intrinsic level so CLMUL is at 100% completion.
Someone could add SIMDe extensions for the mnemonics but... no one is going to able to find them.
Maybe a source code comment on _mm_clmulepi64_si128 to mention the other mnemonics names  would make it greppable?


fs: Fix fs_unmount while mountpoint is busy.

Fixes fs_unmount when IO is potentially ongoing in a different thread. By using an use counter on the mountpoint we can prevent any thread from unmounting while busy. The fs_unmount adds -EBUSY as return value to reflect this case.

Do you try to address the issue https://github.com/zephyrproject-rtos/zephyr/issues/73501 ?

Do you try to address the issue #73501 ?

Yeah, but in hindsight there are a few corner cases. Especially the file systems that have no close()/closedir() implementation. The test framework brings up this issue.
Is it worth to continue going in this direction or do you see another better way fixing this issue ?

Actually to know whether system has the call or not you have to call it.
Generally it is  just good practice to have every open paired with close, and that is it.

Hi @bas-archembedded, any progress here?

This probably needs more work and becomes tedious in the USB 'forced' removal case. Any thoughts about this ?

This probably needs more work and becomes tedious in the USB 'forced' removal case. Any thoughts about this ?

First focus on the support for internal process, so avoidance of unmounting something that is used by other process, and lets have this done.
We can not process forced removal without knowing it has happened, and forced removal will not call umount until the forced removal has already been done - so that means w have to have some proposal with subsystems with forced removal to inform VFS that it happened and policy towards them when they now have to call something forcing removal of the mount point regardless of counters or usage.
If you want to have proposal for that take a look look at how SD cards react, in Zephyr, to gather some info on how thinks are happening, so that you could fit the idea within how the system works, but not in this PR.


Bug: Table mobileCards not working as expected

Overview of the problem
Oruga version: [0.9.X]
Expected behavior
mobileCards: false disable the cards behavior.
Actual behavior
When using the Table component with `mobileCards: false', the the Table will be displayed as cards anyway.

hey I want to work on this issue can you assign this to me @mlmoravek

Hey @akhileshverma92,
just open a PR if you have something finished :)


All member names are linked rather than being separated by class hierarchy.

Renaming com/example/food/Bananas method isConsumable would rename com/example/event/Consumables method isConsumable even if the two are not related in any way.

Fixed in 369ca6c


Add switchboard.app

Unlike all other web desktops in this list, this one isn't free and locked behind a login


Fix primitiveNextPutAll for UTF strings

The stream nextPutAll: primitive fails (gracefully) for UTF strings, falling back on slower Smalltalk backup code. There is some perf loss here between 7.0 (pre UTF) and 7.1 (UTF enabled)

This issue was moved to dolphinsmalltalk/Dolphin#536


Feature Request - Ignore OneDrive and Network drives

When running a scan or fix, ignore OneDrive and also ignore any network drives in all drives mode.

@MarkSe99 Would you test v2.1.1 release? It ignores all network drives with --all-drives option.
Btw, You can ignore OneDrive using --exclude-pattern OneDrive


Fix build error on Android target

Hello, I found a build error on Android target.
There was a similar issue (https://github.com/sfackler/rust-openssl/issues/321), so I fixed it in the same way.

Thanks!


Would you like to add a function to reset thread like on the website?

As the title mentioned.

Currently, conversations are not tracked, so the thread is implicitly reset every time. The appearance of the chat history implies otherwise, which is misleading. If #21 (conversation support) is merged then there will be a ChatGPT: Reset thread command.

Thanks!


Add stats of the projects

Currently, Harness has very few projects (eg: Drone, Litmus Chaos) that are on GitHub and it all has some good stats in terms of the total number of stars, issues, PRs
It'll be great if we highlight all these numbers on the site landing page as it'll attract more developers to look into what we are doing as a company and empower them to be a part of it.

Hey @Ompragash could you please assign this to @rkapoor10


fieldgroups request for table 99000754 "Work Center"

We would like to add a fieldgroups property in table Work Center so we can extend this with our addon fields:
fieldgroups
{
fieldgroup(DropDown; "No.", Name)
{
}
}

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release.
We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues.
If you have follow-up questions or requests, please create a new issue where you reference this one.


⚠ AGE-Vicmap_Index-MS has degraded performance

In e4cef28, AGE-Vicmap_Index-MS (https://vicmap.land.vic.gov.au/hosting/rest/services/vicmap/Vicmap_Index/MapServer/0/query?where=1%3D1&resultRecordCount=1) experienced degraded performance:

HTTP code: 200
Response time: 5216 ms

Resolved: AGE-Vicmap_Index-MS performance has improved in 2f96f8c after 22 minutes.


Remove deprecated :follow-redirects options

The supported way of setting redirects is using :redirect-strategy. We should remove the :follow-redirects option and the deprecated middleware.
I think this will address the confusion around redirects and all the many options.
Done Criteria:

[ ] Updated README
[ ] Updated Changelog
[ ] Removed :follow-redirects (boolean) option

Yep, this can be done now that we have a 4.x branch :)


Fix Issue 18683 - no toHash in rbtree

I'm trying to implement toHash functionality for RedBlackTree. I used this as a reference, hope it's not a problem.
Offtopic: it would be nice to have an example like the one here on how to use rbtrees in the docs, it helped me a lot.

This PR is a great step forward and will be merged once it handles null objects gracefully. Some problems will remain though. With a custom comparison function it still may not hold that if(a == b) a.toHash() == b.toHash(). Consider:
https://run.dlang.io/is/iKD5BJ
void main()
{
    import std.container.rbtree : RedBlackTree;
    static bool unsignedLess(int a, int b)
    {
        import std.math : abs;
        return abs(a) < abs(b);
    }

    auto tree1 = new RedBlackTree!(int, unsignedLess)(1, 2, 3, 4);
    auto tree2 = new RedBlackTree!(int, unsignedLess)(1, -2, 3, -4);
    assert(tree1 == tree2); // Passes because unsignedLess is used for equality! Probably undesirable.
    assert(tree1.toHash() == tree2.toHash(), "Fails before PR #6517. Still fails after PR #6517.");
}

Since this is an issue with the design of RedBlackTree.opEquals this isn't a reason to reject this PR, but in the mean time the limitation should be documented.

Is it ok if I wrote this in the ddoc comment of the function

Yeah that makes sense.

Also, I made the change for the is(T == class) case but I still get a sigsev

You need to use a custom comparison function that is not a virtual function of MyInt2, because calling the opCmp virtual function will segfault if the receiver is null. Here it will also segfault if the argument is null since it tries to read one of the argument's fields.
An example of the less function you could use is:
bool nullSafeLess(scope const MyInt2 a, scope const MyInt2 b)
{
     return a is null || (b !is null && a < b);
}

I made some changes, hope it's better now.

Rebased and implemented @wilzbach's suggestions.


Define cache_key on Ember::Handlebars::Template

We recently ran into an issue having to do with the Sprockets cache not being invalidated when changing the templates_root configuration.  See script below for an example of how to reproduce the bug.
The fix is to define the cache_key method on Ember::Handlebars::Template.  This feature was added to Sprockets in https://github.com/sstephenson/sprockets/pull/672, and allows processors to define dependencies on things like version numbers and configuration variables.  Any relevant config, including templates_root, should be defined for Ember::Handlebars::Template#cache_key.
To reproduce:
rails new test1
cd test1
echo "gem 'ember-handlebars-template'" >>Gemfile
bundle
echo "Sprockets.register_engine '.hbs', Ember::Handlebars::Template" >config/initializers/sprockets.rb
mkdir app/assets/javascripts/foo
mkdir app/assets/javascripts/foo/templates
echo '//= require_tree ./templates' >app/assets/javascripts/foo/application.js
echo 'foo' >app/assets/javascripts/foo/templates/template.hbs
rake assets:precompile

head -n1 /Users/afn/test1/public/assets/foo/application-*.js
# => Ember.TEMPLATES["foo/template"] = Ember.HTMLBars.template((function() {

echo 'Ember::Handlebars::Template.configure {|config| config.templates_root = %w(foo/templates)}' >config/initializers/handlebars.rb
rake assets:precompile
head -n1 /Users/afn/test1/public/assets/foo/application-*.js
# => Ember.TEMPLATES["foo/template"] = Ember.HTMLBars.template((function() {
# ^^^ That's wrong.  rake assets:precompile should have updated the contents of the file.

rake assets:clobber
rake assets:precompile
head -n1 /Users/afn/test1/public/assets/foo/application-*.js
# => Ember.TEMPLATES["template"] = Ember.HTMLBars.template((function() {
# ^^^ That's the right value, which I would have expected earlier, without having to explicitly clear the cache

Thanks!
Tony

Oops, this is a regression introduced by https://github.com/tricknotes/ember-handlebars-template/pull/6

This issue was fixed by https://github.com/tricknotes/ember-handlebars-template/pull/10 and using Sprockets 3.3.


prisma 4

Hi guys, does this plugin work with Prisma 4?

@conioX i am going to upgrade package

@conioX package has upgraded


Multiple transaction in single microframe for interrupt endpoints

Hi,
I am using STM32 mass storage HOST example from : https://github.com/azure-rtos/sample
I was going through code ( in STM32 mass storage HOST example ) and in :
UINT  _ux_hcd_stm32_td_schedule(UX_HCD_STM32 *hcd_stm32, UX_HCD_STM32_ED *ed)
I seen this line :
number_packets =  (td -> ux_stm32_td_length + endpoint -> ux_endpoint_descriptor.wMaxPacketSize - 1) / endpoint -> ux_endpoint_descriptor.wMaxPacketSize;
Now if you see carefully then this line will always return 1 irrespective of ux_endpoint_descriptor.wMaxPacketSize.
In my opinion it should be :
max_packet_size  = endpoint -> ux_endpoint_descriptor.wMaxPacketSize & UX_MAX_PACKET_SIZE_MASK;
number_packets =  (td -> ux_stm32_td_length + max_packet_size - 1) / max_packet_size;

Not sure fully , but let me know your thoughts on this.
Also I wanted to know does USBx code supports multiple transaction in single microframe for interrupt endpoints ?
and also multiple transaction in single microframe for isochronous endpoints ? I simply tried to search "UX_HCD_STM32_OTG_FS_HCTSIZ_DPID_MDATA" but was not able to find it ?

Thanks for the feedback.
Unfortunately the HCD inside the sample is obsoleted.
Please try the HCD which is released by ST in STMCube, with STM32 H7 examples (can be generated by STM32Cube for UX examples), where STM32 HAL is used to support STM32 controllers.

Hi xiao,
Thanks for the suggestion , STM32 cube code is very optimized compared to sample code.
Though I have same question. Is multiple transactions supported in single microframe for isochronous transfer ?
I see following code,
when do we load HC_PID_DATA1 and HC_PID_DATA2 ? or is it maintained by USB IP ?
in stm32h7xx_hal_hcd.c

case EP_TYPE_ISOC:
      hhcd->hc[ch_num].data_pid = HC_PID_DATA0;
      break;

For ISO transactions, the PID sequence is fixed for high-bandwidth case, it's possible the PIDs are generated automatically by hardware and the setting actually has no effect in this case.
But you should ask ST for the actual behavior of their USB controller IP, also the stm32h7xx_hal_hcd.c code (that's offered by ST).


csail network out for a day

csail will be updating their network.

replaces https://github.com/CCI-MOC/moc-status/pull/55

Please make sure to update the severity to 1 on the 15th.


feature: Add a QR code that takes the user directly to the Play Store for simple download.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
We need to establish a user-friendly website that users can quickly access, and the problem with our website is that if a person wants to access an app from their mobile device, they must first search for it.
Describe the solution you'd like
A clear and concise description of what you want to happen.
For this according to me the adding QR code is the best option.

@karan-vaishnav Can i take up this issue?

@karan-vaishnav can you please assign me this task.

hey @karan-vaishnav , is this still available?

hey i can fix this if still open?


Robert Longson: Watch botanicalfarmscbdorder.tumblr.com

Robert Longson requests the watch of the watch_keyword botanicalfarmscbdorder\.tumblr\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

botanicalfarmscbdorder\.tumblr\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


Utility from Parent Directory

Hi. I'm a novice studying business analytics. I attempted to run your code, but it breaks when attempting to import "util" Where can I find this code? Thanks

there is a util.py in the folder. Thanks.

Thanks...I will search for it.
On Tue, Jun 16, 2020 at 12:32 PM Wei Deng<EMAIL_ADDRESS>wrote:

there is a util.py in the folder. Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/WayneDW/Sentiment-Analysis-in-Event-Driven-Stock-Price-Movement-Prediction/issues/22#issuecomment-644873702,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANMZKHE4EM266S3I42O2WP3RW6NATANCNFSM4N6577HQ
.


fix: ensures that the Pooler deployment has the securityContext populated

This patch ensures that the generated Pooler deployment has the securityContexts populated
Closes #479
Signed-off-by: Armando Ruocco<EMAIL_ADDRESS>

/test


Only this error

Traceback (most recent call last):
File "/Users/foxs5local/Downloads/ton-connect-bot-main/src/main.py", line 12, in
import config
File "/Users/foxs5local/Downloads/ton-connect-bot-main/src/config.py", line 6, in
TOKEN = env['my token']
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/os.py", line 679, in getitem
raise KeyError(key) from None
KeyError: 'my token'

The error does not seem to be related with pytonconnect library.
I don’t know where they got this package with the bot, but the bot needs a token from BotFather, which apparently needs to be entered into config.py


Re-enable Global Visual Focus in theme Calydon

Now that we have theme calydon in place let's try to re-enable the global visual focus in the calydon/cx-base before trying to fix it component by component.

To QA this ticket, theme calydon needs to be activated. All elements with implicit focus will show a blue outline as they're focused on. (buttons, inputs, checkboxes, radio buttons, links).
Individual inconsistencies will be dealt with in this other board:
https://github.com/SAP/cloud-commerce-spartacus-storefront/projects/40?card_filter_query=label%3Aa11y%2Fux%2Ffocus

Find a store -> View all stores, select a store, then we click on 'Get Directions'. can't really see the blue outline on the 'Get Directions' button because the button turns black when clicked -> Ticket ?


Rubocop Autochange on if !!something

Is your feature request related to a problem? Please describe.
After running rubocop -A on my controller the following change was made an resulted in failing specs.
# original code
if !!raise_error

# changed by rubocop
unless raise_error.nil?

This is dangerous if we have booleans.
Describe the solution you'd like
To avoid the error above I do not have a suggestion in pure ruby.
In rails I go with:
if rais_error.present?

This solved the issue for me.

If it's a boolean the double-negation doesn't make a lot of sense in the first place. 😉 I think the auto-correct is already marked as unsafe. There's little else we can do on this topic.

Agreed. Note that rubocop -A performs all autocorrections, safe and unsafe. Closing.


Support syncing of settings in Chrome extension

Use chrome.storage.sync to store preferences instead of chrome.storage.local, to allow settings to be synchronized if the user chooses to sign in in Chrome and enables synchronization of extension preferences.
Tested with Chrome 50 as follows:

Build the Chrome extension (node make chromium).
Load the extension at chrome://extensions.
Open the options page, right-click and choose Inspect element to open Chrome's devtools and run the following snippet in the console (to simulate the behavior before this PR):
storageAreaName = 'local'; storageArea = chrome.storage.local;
Change some preferences in the options page.
Close the options page and re-open it. You will observe that the settings are back to their defaults (because the settings at step 3 and 4 are saved to storage.local).
Inspect the background page and reload it (e.g. by running location.reload() from the console).
Confirm that the background page shows "Successfully migrated preferences from local to sync storage."
Repeat step 6 (i.e. reload the background page).
Confirm that no extra messages are printed (i.e. there is nothing to migrate since the last migration succeeded).

With the above steps, you can verify that the migration logic works as intended. Now, also test whether the preferences are actually applied:

Visit the options page of the extension at chrome://extensions
Untick the "Activate Hand tool by default" checkbox.
Open any PDF file, e.g. http://www.orimi.com/pdf-test.pdf
Press the mouse and move it around.
Confirm that text is being selected (=handtool is disabled).
Go back to the options page, and check the "Activate Hand tool by default" checkbox.
Repeat step 3 and 4.
Confirm that the page is moved up and down (=handtool is enabled). (If your screen is big then the page fits on one page, in that case just zoom in or resize the window so that the page doesn't fit in the viewport).

Fixes #7325.
/cc @timvandermeij Please review this PR.

@timvandermeij I rebased and amended the commit so that the pref from #7353 is also migrated when needed.

I'm stuck at step 7 of the migration logic testing steps. When I reload the background page, the console does not show the intended message. Instead I get:

undefined
Navigated to chrome-extension://liebonjgmjnebbagcedpdnmffffkjpmd/options/options.html

It's not clear to me where the undefined comes from. Do you also have this with the most recent commit? Do you have to be signed in to Chrome for this to work (currently I'm not)?

I've got the same setup - ArvhLinux, 50, not signed in. Did you follow all
steps?
And I don't know where undefined is coming from. The console shows a
link/filename+linenumber at the right.

I see now. I was reloading the options page, not the background page (pdfHandler.html). Now I do see the message in the console.

Thank you for the patch!

Looking to sync data from one extension that i need to set up add rules will this be able to sync the data from folder location \Chrome\User Data\Profile\databases\chrome-extension_  this is where that data is stored after i add and save info i applied to a chrome extension?


Malformed token calls with wrong user inputs

Related issue of https://github.com/wso2/api-manager/issues/2460
Describe the issue:

Following behavior can be observed when we generate tokens with invalid/ malformed basic credentials. Malformed input is constructed by appending additional special characters and numbers to the Authorization header value.
 This should be a 401 response.
Pattern 02: With single character or number
curl --location 'https://localhost:9443/oauth2/token' \
--header 'Authorization: Basic SV95RGhxQlJUMGVKOVRXNm43ZjhmWHVVN0lRYTpQMWk5R19CX3VRZXN2ZHJLUFgxZU1GYURiTmdh1' \
--header 'Content-Type: application/x-www-form-urlencoded' \
--data-urlencode 'grant_type=password' \
--data-urlencode 'username=admin' \
--data-urlencode 'password=admin'

or
curl --location 'https://localhost:9443/oauth2/token' \
--header 'Authorization: Basic SV95RGhxQlJUMGVKOVRXNm43ZjhmWHVVN0lRYTpQMWk5R19CX3VRZXN2ZHJLUFgxZU1GYURiTmdhw' \
--header 'Content-Type: application/x-www-form-urlencoded' \
--data-urlencode 'grant_type=password' \
--data-urlencode 'username=admin' \
--data-urlencode 'password=admin'

Response is giving with 200 HTTP response code + accessToken and expectation is to have 401 error Response Code.
How to reproduce:
Tryout the above curl commands with valid client credentials.


Fixed checkstyle rule 'File does not end with a newline' on windows

With this rule change checkstyle will work fine on Windows and Linux both.

Coverage remained the same at 96.653% when pulling 0683a54e9a0dfaeaf591da03839eb895d28f0533 on ameyjadiye:master into 343b4a9cbed087206bc7466f8caad910a4f059b1 on apache:master.

Coverage remained the same at 96.653% when pulling 0683a54e9a0dfaeaf591da03839eb895d28f0533 on ameyjadiye:master into 343b4a9cbed087206bc7466f8caad910a4f059b1 on apache:master.

Coverage remained the same at 96.653% when pulling 0683a54e9a0dfaeaf591da03839eb895d28f0533 on ameyjadiye:master into 343b4a9cbed087206bc7466f8caad910a4f059b1 on apache:master.

I'll pull this in after the release.

@chtompki , I thinks its good time to merge this PR.


Disable example test cases for SoftAssertionsExtension

Prior to this commit, the example test cases used to test the SoftAssertionsExtension were properly excluded from the Maven build by intentionally not following the "*Test" naming convention; however, those test cases were executed within IDEs, resulting in failures.
This commit addresses this inconvenience by annotating all example test cases with @Disabled and deactivating the DisabledCondition when actually executing the test cases via the EngineTestKit.
See #1418

Changes have been force-pushed.

Integrated thanks @sbrannen !

Thanks for the quick turnaround, and... you're welcome!


Seems like the annotations have zero effect

(I'm using Android Studio 1.2, if that does matter…)

Thanks your report. I wrote a sample app for testing. It's my mistake. please use 1.0.2+ version.

Fixed


[ENHANCEMENT] Add "Go to source" button in rightclick

Please confirm these before moving forward

[X] I have searched for my feature proposal and not found a work-in-progress/duplicate/resolved/discarded issue.
[X] This improvements refers to an existing feature. If you want to suggest a new feature, please use this template
[X] This improvements is not a bug. If you want to report a bug, please use this template

Describe the improvement
Add a single menu item to the right click menu of installed software, that lets me go to the respective directory the software is isntalled in.
If this is not possible, alternatively it would be helpful to document the installation path in the FAQ for various sources.
Describe how this improvement could help users.
Right now it is very troublesome to find the location, where stuff is installed. For example installing maven via chocolatey results in the path C:\Users\User\AppData\Local\Programs\WingetUI\choco-cli\lib. But this path is already different when installing stuff via winget.
Adding the menu item improves fluidity and streamlines workflow.

Would be a possible temporary fix for #1036

@marticliment thanks for the quick answer! I just realized that "Go to Source" is a bit misleading.

For Winget there is an open issue about this https://github.com/microsoft/winget-cli/issues/2298

Its actually quite important, since not all Apps are shown in the Start menu or windows search after the installation.
(I'm looking at you QEMU,...)


[PolicyInsights] Trigger evaluation command + version info

Description of PR (Mandatory)
Adds one new command az policy state trigger-scan which triggers a policy compliance evaluation for a subscription or resource group.  The scan updates the states exposed by az policy state list and similar.
Also exposes versions for policyAssignments, policyDefinitions, and policySetDefinitions in az policy state list
Testing Guide
Triggers a compliance scan on the "myRg" resource group and does not wait for it to complete:
az policy state trigger-scan -g myRg --no-wait
History Notes:
[PolicyInsights] az policy state: add trigger-scan command to trigger policy compliance evaluations
[PolicyInsights] az policy state list: expose versions of policy entities in each compliance record

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

add to S168

@calecarter FYI

@zhoxing-ms @Juliehzl @qianwens this PR needs a review when you get a chance

@zhoxing-ms resolved your comment.  Added an isempty check to the new test.

@pilor Could you add some tests with return data?

@pilor Could you add some tests with return data?

The new commands themselves don't return anything but you are right that their side effect should be tested more completely.  I added validation that the compliance state was updated after the scan was completed.

add to S170

@zhoxing-ms can you re-review?

add to S171

@Juliehzl @zhoxing-ms Can this be merged?

@Juliehzl @zhoxing-ms Can this be merged?

@Juliehzl @zhoxing-ms @qianwens Is there something blocking the merge of this PR?

@Juliehzl @zhoxing-ms Can this be merged?

@Juliehzl @zhoxing-ms @qianwens Is there something blocking the merge of this PR?

Ping.  Is merging blocked?

@Juliehzl @zhoxing-ms @qianwens @yonzhan Whats going on with this PR?  What is blocking the merge?


Remove prop_samples from calc_confidence_interval

The sampling part of the procedure of Bootstrapping can be summarized at high level if I understand it correctly:

Resample each sample in the given data.
Repeat Step 1 several times

where the number of random samples generated in Step 1 should be same as the number of samples in the data.
(The similar description is found in scipy.stats.bootstrap)
However, it seems calc_confidence_interval implements differently, which raises a concern for the correctness of the algorithm. I could be wrong, but it seems better to prefer the correctness over the efficiency of resampling given that computed values with this library could be used in someone's research. With this in mind, this PR removes prop_samples from calc_confidence_interval.

FYI: We can find some explanations, e.g., https://www.stata.com/support/faqs/statistics/bootstrapped-samples-guidelines/
Roughly speaking, resampling from $n$ data with other sample size $n'$ changes the tendency of obtained statistics from the original sample. To avoid this effect, we need to always use the same sample size $n$ for every resampling round, or the obtained statistics lacks the correct meaning.


Small documentation nit

Hi, this looks cool! One small suggestion: switch "he" in docs to "they", presumably not all your users will be male.

The docs are written in General American English. In my native dialect, "he" is gender-neutral when there is no specific person being referenced. I should probably make an effort to write in "Hollywood English", given its dominance on the world stage, but it takes extra effort to maintain text in a non-native dialect. Realistically, it will not be high on my priority list to try.

There actually was not very much of this, so I just pluralized everything. Pronoun usage now conforms to both General American and Hollywood English. Future documentation PRs will be required to maintain this standard.


requestPermission on Android 14

Describe the bug
Calling requestPermission will lead into an error: "No Activity found to handle Intent { act=androidx.activity.result.contract.action.REQUEST_PERMISSIONS (has extras) }
However, on Android 13 the issue does not exist.
To Reproduce
When trying to request permissions the application crashes with the error (see above)
Expected behavior
HealthConnect shows the permission selection (Same behavior as on Android 13).
Screenshots

Environment:

Health Connect Version: 1.2.1
React Native Version: 0.72.6
Expo Version: 49.0.15

Please read the documentation for setting up the project. You may have missed setting up your AndroidManifest.xml configurations.

"Thank you for your response! I've double-checked the configuration in AndroidManifest.xml, but the issue persists. For reference, I initiated a brand-new expo project and strictly followed the Get started guide.
Here is my AndroidManifest.xml for further reference:
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
  <uses-permission android:name="android.permission.INTERNET"/>
  <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
  <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
  <uses-permission android:name="android.permission.VIBRATE"/>
  <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
  <uses-permission android:name="android.permission.health.READ_ACTIVE_CALORIES_BURNED"/>
  <queries>
    <intent>
      <action android:name="android.intent.action.VIEW"/>
      <category android:name="android.intent.category.BROWSABLE"/>
      <data android:scheme="https"/>
    </intent>
  </queries>
  <application android:name=".MainApplication" android:label="@string/app_name" android:icon="@mipmap/ic_launcher" android:roundIcon="@mipmap/ic_launcher_round" android:allowBackup="true" android:theme="@style/AppTheme">
    <meta-data android:name="expo.modules.updates.ENABLED" android:value="false"/>
    <meta-data android:name="expo.modules.updates.EXPO_SDK_VERSION" android:value="49.0.0"/>
    <meta-data android:name="expo.modules.updates.EXPO_UPDATES_CHECK_ON_LAUNCH" android:value="ALWAYS"/>
    <meta-data android:name="expo.modules.updates.EXPO_UPDATES_LAUNCH_WAIT_MS" android:value="0"/>
    <activity android:name=".MainActivity" android:label="@string/app_name" android:configChanges="keyboard|keyboardHidden|orientation|screenSize|uiMode" android:launchMode="singleTask" android:windowSoftInputMode="adjustResize"<EMAIL_ADDRESS>android:exported="true" android:screenOrientation="portrait">
      <intent-filter>
        <action android:name="android.intent.action.MAIN"/>
        <category android:name="android.intent.category.LAUNCHER"/>
      </intent-filter>
      <intent-filter>
        <action android:name="androidx.health.ACTION_SHOW_PERMISSIONS_RATIONALE" />
      </intent-filter>
      <intent-filter>
        <action android:name="android.intent.action.VIEW"/>
        <category android:name="android.intent.category.DEFAULT"/>
        <category android:name="android.intent.category.BROWSABLE"/>
        <data android:scheme="com.test.hctest"/>
      </intent-filter>
    </activity>
    <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" android:exported="false"/>
  </application>
</manifest>

Is this just happening on Android 14?

Yes the issue occurs only on Android 14. I tested it with the emulator (API 34) and a physical device (Pixel 6 Pro). Android 13 (with the HealthConnect app) does work fine.

Try submitting the issue in Google's Issue Tracker and see if they have answer for it:
https://issuetracker.google.com/u/1/issues?q=status:open componentid:1232764&s=created_time:desc

FYI: https://issuetracker.google.com/u/1/issues/307049403

Same issue for me when I run on Android 14
Found the migration plan here, hopefully this may help.
https://developer.android.com/health-and-fitness/guides/health-connect/migrate/migrate-from-android-13-to-14

Hello, I managed to fix it by adjusting the Intent action for Android 14 on the native side. In HealthConnectManager.kt, in the request permission function, replace the intent declaration with this
val intent = if(Build.Version.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) { Intent("android.health.connect.action.MANAGE_HEALTH_PERMISSIONS") } else { HCPermissionManager(providerPackageName).healthPermissionContract.createIntent( applicationContext, latestPermissions!!) }
I am pretty sure, It still misses something but I am not very familiar with native Android development.

@matinzd What do you think about the solution of @PopJoestar? Is it suitable for a PR?

Hi
I reviewed the code, and it appears that this issue should not occur. Creating an intent should ideally be managed through the Google Health Connect.
I recommend following the document here and checking if you encounter any errors after making these modifications, without altering the underlying structure:
https://developer.android.com/health-and-fitness/guides/health-connect/migrate/migrate-from-android-13-to-14#testing-apis-with-sdk
@LeonNissen

We're hit by the same issue.
I've tried this solution and while it does prevent the crash, it simply opens Health Connect for us, and does not request permission.
While the issue should not occur, it definitely does occur here.

I've tried the same fix as @antontanderup — it does prevent the phone from crashing, but we don't get to actually authenticate with Home Connect.
The library works great on Android 13, but we get that crash every time on Android 14.

Hi @antontanderup and @fredefl,
I was able to implement the solution suggested by @PopJoestar.
Yes you were right, when using the Intent android.health.connect.action.MANAGE_HEALTH_PERMISSIONS the HealthConnect app will present all apps and their permissions. However, a hot fix for this would be to just select the app in this menu, allow the specific (or all) permissions and return to the app.
Thereafter the app is able to access HealthConnect's data.
However, I think we would need a different intent but I'm unfortunately no android developer. Additionally, I agree with @matinzd's answer:

I reviewed the code, and it appears that this issue should not occur. Creating an intent should ideally be managed through the Google Health Connect.

https://github.com/matinzd/react-native-health-connect/assets/50104433/55b0e9b8-a4f3-4300-bd88-19d1b0363d99

Given the instability, I've opted to hold off on updating this library until a stable version from Google is released. Let's wait for that to ensure reliability. In the meantime, feel free to fork the project and tailor it to your needs, or send a pull request.

I'm holding off on updating this library until Google releases a stable version. We'll wait for that to ensure it's reliable. In the meantime, you're welcome to fork the project and customize it, or send a pull request.

I got the same crash issue on android 14. if you any solution for this crash issue. please help me on this
thanks in advance

Came across this fix for a flutter plugin today. Dont have time to dig into this issue right now but I will circle back if its not resolved.
Waiting for google to be stable before modifying is a good idea. Could also be forever haha
https://github.com/cph-cachet/flutter-plugins/issues/800
Official migration docs: https://developer.android.com/health-and-fitness/guides/health-connect/migrate/migrate-from-android-13-to-14

@LeonNissen it looks like you have a minimal expo android project/repo with the temporary fix that you implemented, do you mind sharing that minimal reproduction with us so we can see exactly how you implemented the fix?

@seanblonien sure thing!
I've pushed it into a new repo: https://github.com/LeonNissen/test-hc/tree/main
Most important, you need to follow @PopJoestar's answer: https://github.com/matinzd/react-native-health-connect/issues/50#issuecomment-1782411647
The actual fix for react-native-health-connect can be found here:
https://github.com/LeonNissen/test-hc/blob/f742cce66551d1fbeb927f82e20ca4bdaefdb474/node_modules/react-native-health-connect/android/src/main/java/dev/matinzd/healthconnect/HealthConnectManager.kt#L79

@LeonNissen Ah perfect, thank you for sharing, it helps a lot!

If you want to make any small changes to your packages, use patch-package to patch your modules instead of commiting your node_modules folder.

@matinzd I did @LeonNissen changes in node modules and created patch package after that i am getting issue for
Permission Denial: starting Intent { act=android.health.connect.action.REQUEST_HEALTH_PERMISSIONS cmp=com.google.android.healthconnect.controller/com.android.healthconnect.controller.permissions.request.PermissionsActivity }  requires android.permission.GRANT_RUNTIME_PERMISSIONS
Please help on this
Thanks in advance

I'm also having the same issue that @chganesh does. I don't know what the problem is, I simply tried to run the repo @LeonNissen put up.

Hi @chganesh and @qtdinh,
I'm sorry I haven't tested the code before committing...
I committed a new version with the intent android.health.connect.action.MANAGE_HEALTH_PERMISSIONS.
It works now 🚀
Thanks @matinzd for the patch-package heads up, I will look into that!

It seems you are right @LimAlbert. The main issue when I was implementing this library was the RN limitation regarding the new way of handling activity results and permission contracts.
The patch you provided seems ok, but it needs some more work because we are calling setProvider inside the MainActivity.kt which is not ideal.
@cortinico Are there any roadmaps/plan to support Androidx Activity Result APIs inside native modules?

I started investigating this. @LimAlbert You are right. There is a problem with RN core. Do you want to send a pull request to fix that?

@matinzd Thanks for your work ! I have made a PR for the onRequestPermissionsResult issue (https://github.com/facebook/react-native/pull/42478)

For all those wondering about this issue, I have some updates:

There is an open PR, as you can see, that can address this problem. Once it gets merged, there will be a breaking change in the library. You will need to modify your MainActivity file to set the permission delegate and set up the proper AndroidManifest for permission rationale on Android 14 and above.
See here for more information: https://github.com/matinzd/react-native-health-connect/pull/60

We are currently awaiting meta to backport the permission contract issue to older versions of RN. This implies that after the new release, we will likely only support RN 70 and above, and the latest patch version, as the backport may only be available for recent RN versions. If you want to follow up on this matter, please read here: https://github.com/reactwg/react-native-releases/discussions/98#discussioncomment-8208768.

@matinzd What is the process for updating your package or adding those changes to my current package and applying a patch?
My Current Versions
react-native-health-connect": "^1.1.0
react-native": "0.72.4"
@matinzd @LimAlbert Please help on this

@chganesh If you can't upgrade to<EMAIL_ADDRESS>follow what I've written regarding react-native here (Edit the source code and then use patch-package to create patch)
For react-native-health-connect, you can use the fork that @matinzd made, it should be working

@AlbertCardi Edited my source code to reflect changes made by @LimAlbert, but I am unable to receive the steps count.

Fixed in v2.0.0.

@matinzd
after upgrading to v2.0.0, it is not asking for permission for health connect datatypes in android 14. my App is not showing in health connect App permissions list

I also tested in android 13 device it is working fine and asking for permissions

@matinzd is there anything else that I am missing..

Try checking the example app changes and see if you are missing anything:
https://github.com/matinzd/react-native-health-connect/pull/60/files#diff-8fc083d75c4d06482dc1ee1c9ba3edab0192a99add6fa96679b6ed189a049c88
I may have missed something in the documentation.

I tried running example app but getting this issue
https://github.com/matinzd/react-native-health-connect/issues/64

Try checking the example app changes and see if you are missing anything:
https://github.com/matinzd/react-native-health-connect/pull/60/files#diff-8fc083d75c4d06482dc1ee1c9ba3edab0192a99add6fa96679b6ed189a049c88
I may have missed something in the documentation.

@matinzd I checked the example app changes and tried to run it, and it is working fine as aspected.
I notice one change that you have made in example app but not documented. I made these changes in my app, then it is also working fine.
Missed Changes from PR::

example/android/app/src/main/AndroidManifest.xml
example/android/app/src/main/java/com/healthconnectexample/PermissionRationaleActivity.kt

Hi, I encountered the same issue "No Activity found to handle Intent...". After upgrading the plugin to version 2.0.1, as well as adding the extra changes as @nHussain18, my app no longer crashes when calling requestPermission . However, now the requestPermission method never returns on Android 14 when using await. Does anyone else has this problem?
I tried adding logs in the native code as well, and the following logs are not printed.
fun requestPermission(
    reactPermissions: ReadableArray, providerPackageName: String, promise: Promise
  ) {
    Log.d("HealthConnectManager", "before throwUnlessClientIsAvailable")
    throwUnlessClientIsAvailable(promise) {
      coroutineScope.launch {
        val granted = HealthConnectPermissionDelegate.launch(PermissionUtils.parsePermissions(reactPermissions))
        Log.d("@requestPermission", "inside coroutine")
        promise.resolve(PermissionUtils.mapPermissionResult(granted))
      }
    }
  }

requestPermission = activity.registerForActivityResult(contract) {
      coroutineScope.launch {
        Log.d("@activityResult", "inside coroutine")
        channel.send(it)
        coroutineContext.cancel()
      }
    }

Hi, I encountered the same issue "No Activity found to handle Intent...". After upgrading the plugin to version 2.0.1, as well as adding the extra changes as @nHussain18, my app no longer crashes when calling requestPermission . However, now the requestPermission method never returns on Android 14 when using await. Does anyone else has this problem?
I tried adding logs in the native code as well, and the following logs are not printed.
fun requestPermission(
    reactPermissions: ReadableArray, providerPackageName: String, promise: Promise
  ) {
    Log.d("HealthConnectManager", "before throwUnlessClientIsAvailable")
    throwUnlessClientIsAvailable(promise) {
      coroutineScope.launch {
        val granted = HealthConnectPermissionDelegate.launch(PermissionUtils.parsePermissions(reactPermissions))
        Log.d("@requestPermission", "inside coroutine")
        promise.resolve(PermissionUtils.mapPermissionResult(granted))
      }
    }
  }

requestPermission = activity.registerForActivityResult(contract) {
      coroutineScope.launch {
        Log.d("@activityResult", "inside coroutine")
        channel.send(it)
        coroutineContext.cancel()
      }
    }

I'm encountering the same issue. Did you find a solution to fix it ?

Hi, I encountered the same issue "No Activity found to handle Intent...". After upgrading the plugin to version 2.0.1, as well as adding the extra changes as @nHussain18, my app no longer crashes when calling requestPermission . However, now the requestPermission method never returns on Android 14 when using await. Does anyone else has this problem?
I tried adding logs in the native code as well, and the following logs are not printed.
fun requestPermission(
    reactPermissions: ReadableArray, providerPackageName: String, promise: Promise
  ) {
    Log.d("HealthConnectManager", "before throwUnlessClientIsAvailable")
    throwUnlessClientIsAvailable(promise) {
      coroutineScope.launch {
        val granted = HealthConnectPermissionDelegate.launch(PermissionUtils.parsePermissions(reactPermissions))
        Log.d("@requestPermission", "inside coroutine")
        promise.resolve(PermissionUtils.mapPermissionResult(granted))
      }
    }
  }

requestPermission = activity.registerForActivityResult(contract) {
      coroutineScope.launch {
        Log.d("@activityResult", "inside coroutine")
        channel.send(it)
        coroutineContext.cancel()
      }
    }

having same issue. Did you find any solution?

For older versions, I added below code while reading permission
  let grantedPermissions = await getGrantedPermissions();
  if (grantedPermissions.length === 0) {
    // request permissions
    grantedPermissions = await requestPermission([
      {accessType: 'write', recordType: 'ExerciseSession'},
    ]);
  }

and asked users to manually give permissions via health connect app.

Hi, I'm having this issue in lower versions of android, on android 14 is working great but in android 13 and below is crashing due to android.content.ActivityNotFoundException: No Activity found to handle Intent { act=androidx.health.ACTION_REQUEST_PERMISSIONS pkg=com.myapp.app (has extras) }

@matinzd im using react-native cli
"react-native": "0.72.3",
.... im unable to configure health-connect.. there is some kind of issue

Your manifest is not valid. Please open the android project in Android Studio so that you get some help from IDE to resolve it.

not working in my  physical phone android 14

it is working fine for below android 14 but not working in my physical phone android 14

Same here, any solution for RN < 0.70 ?

No

it is working fine for below android 14 but not working in my physical phone android 14

Same here, any solution for RN < 0.70 ?

No

@matinzd  im using react-native cli
"react-native": "0.72.3",
.... im unable to configure health-connect.. there is some kind of issue
i have checked my manifest file too still can't figure out... please @matinzd have a look and guide me,
Thankyou.  i have attested the images

@matinzd Followed everything from the documentation but getting this error. Maybe i have java folders. Can u please help me on that?

I won't be able to help unless I get a bare minimum reproduction with a public link to the repo.

@matinzd Followed everything from the documentation but getting this error. Maybe i have java folders. Can u please help me on that?

@codewithhannan , here's the solution for android folder's
 HealthConnectPermissionDelegate.INSTANCE.setPermissionDelegate(this, "com.google.android.apps.healthdata");

@matinzd im using react-native cli "react-native": "0.72.3", .... im unable to configure health-connect.. there is some kind of issue i have checked my manifest file too still can't figure out... please @matinzd have a look and guide me, Thankyou. i have attested the images
i get response on initialize but My app crashes when i do requestpermissions

check the solution I posted above for java files

@matinzd , are you happy to update the docs and include solution for java files, this will mainly be old react-native projects

Since most upgraded RN projects are using kotlin, it's not really needed to be mentioned in the documentation. If you have time, feel free to create a pull request to update the docs and I will merge the changes.
I have mentioned your solution here before:
https://github.com/matinzd/react-native-health-connect/issues/108#issuecomment-2198253141

hey @matinzd , let me raise a PR was away only seeing this now

hey @matinzd , I have opened a PR to update the docs, thanks

I am going to provide the best solution for this.
Do to some constraints and business needs I wont be able to upgrade to React Native 72+ or 73+ atleast till December or Android 15 is available for public use because I dont want surprise crashes here and there in the app due to the nature of android ecosystem.
As I use React native 71+, I used 1.2.3 version and it worked properly for android 13 but not for android 14.
But it seems many people are upgrading to android 14 so it has become a business need for me to make this package work.
Here are the steps to follow for RN 71.0 - RN 72

Install the latest package at 2.1.0.
As we have the native files in Java use the following in MainApplication above onCreate and not in it

   @Override
    public Intent registerReceiver(@Nullable BroadcastReceiver receiver, IntentFilter filter) {
        if (Build.VERSION.SDK_INT >= 34 && getApplicationInfo().targetSdkVersion >= 34) {
            return super.registerReceiver(receiver, filter, Context.RECEIVER_EXPORTED);
        } else {
            return super.registerReceiver(receiver, filter);
        }
    }

Now go to MainActivity.java and add the import at top and permission handler inside the onCreate.

import dev.matinzd.healthconnect.permissions.HealthConnectPermissionDelegate;
import android.os.Bundle;

   // Inside onCreate at its last line

    // In order to handle contract results, we need to set the permission delegate.
    HealthConnectPermissionDelegate.INSTANCE.setPermissionDelegate(this, "com.google.android.apps.healthdata");

After all this I tried in android 13 and android 14 it worked perfectly.
The requestPermission is working and showing the popup but  not resolving while using async await and not moving to the next line of code which is an active issue - @matinzd please solve this - I used .then().catch() and made it work (Which is not ideal)
But the app wont run in android 15 because the RN version is Old so better to upgrade to 73.8+ React native version and it worked properly for my Demo App.
Let me know if this works.
@pridemusvaire thanks for sharing the Java Code - It worked smoothly.


Fix urls for root domains

We are familiar with the fact that we need to pass host and/or subdomain parameters in url helper for it to work properly, especially for asset urls.
And we were passing either Subdomain.current.hostname or Apartment::Tenant.current as the subdomain, which is not consistent. Subdomain.current.hostname returns nil for root domain, which is fine, but Apartment::Tenant.current returns 'public' which causes all the asset urls to be prefixed with 'public'
rails_blob_url(attachment, subdomain: Apartment::Tenant.current,  subdomain: Apartment::Tenant.current)
Issue: https://github.com/restarone/violet_rails/issues/1537
With this PR, we will no longer have to pass host and subdomain value to url helper. They are set by default based on the request host.
rails_blob_url(attachment)
You can pass the host and subdomain parameters if you want to override the default value

test plan 🧪

API Renderer - car app, car video app ⌛
Password reset flow ⌛
account creation flow ⌛
user invite flow ⌛
forum file uploads
CMS file uploads
Forum post URL's

@Pralish I see the API surface for URL's and asset linking as changed, could you write some documentation to include as part of the release for server engineers to use as reference?

@Pralish could you please take a look at the review app? There are some major breakages that prevent UAT:
Admin redirect broken:
https://user-images.githubusercontent.com/35935196/235655799-86f198f7-565b-4f3e-9a66-3350c6a7c411.mov
password reset email link is broken


MetricsReporters not running in EnvironmentCommand

The reporters via their factory are initialized however it seems that the LifecycleEnvironment is not started and thus the managed reporter object never receives a call to start().  Is this expected?  If so is there a way to achieve reporting metrics via a command?
Dropwizard 0.9.2.

That's a good question.
Based on my reading of this code, LifecycleEnvironment hands management off to Jetty, so the lifecycle of managed objects is tied to that of the server. In the case of ServerCommand, when the Jetty server is started, the managed metrics reporter is too.
I suspect that the reasoning behind this was that metrics are only warranted for long-running processes and the server command is the main entry point for an application's long-running process.
To expose metrics in non-server commands, one would feasibly extend LifecycleEnvironment to handle managed objects differently.

Thanks for the information.  I'm currently using a command to run a long running worker inside of our drop wizard env.
Two questions:

Is this considered a bad use of a command and if so is there s recommended practice.

Would Dropwizard be interested in having support for something like this in LifecycleEnvironment?

On Thu, Jul 28, 2016 at 4:45 PM Evan Meagher
<
mailto:Evan Meagher<EMAIL_ADDRESS>
wrote:

a, pre, code, a:link, body { word-wrap: break-word !important; }
That's a good question.
Based on my reading of this code,
LifecycleEnvironment
https://github.com/dropwizard/dropwizard/blob/ac9a7dcb755eff6e7ceec18fa662e107269a73de/dropwizard-lifecycle/src/main/java/io/dropwizard/lifecycle/setup/LifecycleEnvironment.java#L41
, so the lifecycle of managed objects is tied to that of the server. In the case of
ServerCommand
,
https://github.com/dropwizard/dropwizard/blob/ac9a7dcb755eff6e7ceec18fa662e107269a73de/dropwizard-core/src/main/java/io/dropwizard/cli/ServerCommand.java#L43
, the managed metrics reporter is too.
I suspect that the reasoning behind this was that metrics are only warranted for long-running processes and the
server
command is the main entry point for an application's long-running process.
To expose metrics in non-
server
commands, one would feasibly extend
LifecycleEnvironment
to handle managed objects differently.
—
You are receiving this because you authored the thread.
Reply to this email directly,
https://github.com/dropwizard/dropwizard/issues/1653#issuecomment-236057482
, or
https://github.com/notifications/unsubscribe-auth/AA9D-jSEsCWQWxVd9URRxy3cWXpWNzLIks5qaT8MgaJpZM4JXp9U
.

Is this considered a bad use of a command and if so is there s recommended practice.

By "a long running worker inside of our drop wizard env", do you mean that you'd like to run a long-running process within the same shell environment/on the same instance as a Dropwizard server?
You could alternatively use a Task. It depends on whether you want your worker to run as its own process separate from your server application (use a Command) or if it can be run concurrently with your server, triggered by an endpoint on the server's admin port (use a Task).

Would Dropwizard be interested in having support for something like this in LifecycleEnvironment?

This is the second time to my knowledge that the topic of long-running, non-HTTP-server commands have come up recently (the other involved running a gRPC server). I think it's an interesting idea that should be discussed, but it would represent a concerted push to expand Dropwizard beyond solely supporting HTTP servers. Given that the project at its core trumpets simplicity and the Unix philosophy ("do one thing well"), I imagine this idea could be contentious.

Thanks for the information


Added to intergration, but cant find Strava when i press + Add repository

I am able to install Strava integration. But i am not able to find Strava in + Add repository.
I have tried both https://github.com/codingcyclist/ha_strava and https://github.com/madmic1314/ha_strava.
I have deleted and reloaded. But it never shows. Why?

Also with version 2022.2.1, the Strava Home Assistant Integration doesn't show up in the available Integrations list (after successful install via HACS: it's visible there as "Strava Home Assistant Integration" and I restarted HA).

and there is a folder /config/custom_components/ha_strava on my server with the right files.
But there seems to be no way to proceed with the configuration and activation of the integration.

Logger: homeassistant.loader
Source: loader.py:346
First occurred: 15:48:10 (1 occurrences)
Last logged: 15:48:10

The custom integration 'ha_strava' does not have a version key in the manifest file and was blocked from loading. See https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions for more details

https://github.com/codingcyclist/ha_strava/issues/30

Found that out too. I added the version string locally, and now I can install the integration. Let's see if I can get it working. The version string fix was not yet merged in the released version, right?


fails due no dockerhub creds

Hi,
I tried to install the demo, but it seems it fails due that it tries to pull postgresql image from dockerhub. Nowadays dockerhub requires auth, so it fails as the demo doesn't add credentials.
This should be implemented into demo:
https://docs.openshift.com/container-platform/4.7/openshift_images/managing_images/using-image-pull-secrets.html#images-pulling-from-private-registries_using-image-pull-secrets

Hello @ikke-t, I've installed the demo in a fresh 4.7 install in AWS (opentlc) and it worked for me perfectly, but I agree with you that we need to use the image pull secrets. I'm thinking also to move the cicd infra images (gogs, postgres, nexus, etc) to the quay.io registry. It's suitable this idea?

Would be nice if the images came from quay.io, yes. For me it immediately complained about dockerhub access denied. Probably somehow cloud IPs have been exceeding the free limits.

@ikke-t I'll add the images into quay.io / registry.redhat.io to avoid the dockerhub limit failure. Also I'll use as well the Nexus Operator to deploy latest and greatest Nexus version.
Meanwhile you can avoid the dockerhub rate limiting using:
https://developers.redhat.com/blog/2021/02/18/how-to-work-around-dockers-new-download-rate-limit-on-red-hat-openshift#authenticate_to_your_docker_hub_account

Branch with WIP work: https://github.com/rcarrata/devsecops-demo/tree/use_quay

@ikke-t solved in the 43d0507 commit. Merged into main branch and working now. Thanks for raise this issue!


Change contenteditable and tabindex to use attribute.

https://github.com/elm-lang/virtual-dom/issues/12#issuecomment-222211201

Please go through https://github.com/process-bot/contribution-checklist/blob/master/pulls.md in future PRs. Specifically the part about having prose in the description. Even just a little context in addition to the link is great.

I believe the contenteditable change introduces a bug. Did you test? Calling toString True should produce "True" instead of "true". Is that a problem?

We can reopen when these questions get answered.

Folded this in to #54 with the lower casing thing.


BS: send RevInfos to PS, not IFStateInfos.

Currently the BS sends IFStateInfos to the PS for simplicity, but the PS doesn't care about anything except the embedded RevInfo. Having the BS send a RevInfo directly would mean there's one less (non-obvious) message type the PS needs to implement.

partially fixed in #2625
When we do no longer support BS:PY we can drop the message handler in the PS

Python services are remove from the repo, thus this can be closed.


Latest Commit Breaks Android Build

Latest commit (648d98b) breaks android build for me, also tried 19/02/2016 commit (ee8a081) with same problem.
After looking though the closed issues, #15 states commit (79333b3) builds successfully, which indeed does work for me and works successfully in my app.
Corvoda version 5.4.1
Java version 1.8.0_74
Error:
:compileDebugJava
C:\PhoneGap\<appname>\platforms\android\src\mx\ferreyra\callnumber\CFCallNumber.java:27: error: cannot find symbol

    cordova.requestPermission(this, requestCode, CALL_PHONE);

           ^

  symbol:   method requestPermission(CFCallNumber,int,String)

  location: variable cordova of type CordovaInterface

C:\PhoneGap\<appname>\platforms\android\src\mx\ferreyra\callnumber\CFCallNumber.java:35: error: cannot find symbol

    if (cordova.hasPermission(CALL_PHONE)) {

               ^

  symbol:   method hasPermission(String)

  location: variable cordova of type CordovaInterface

ERROR building one of the platforms: Error: cmd: Command failed with exit code 1
You may not have the required environment or OS to build this project

Error: cmd: Command failed with exit code 1

Yeah I'm facing the same problem with the latest version of this plugin. can't build to Android . Please can it be fixed as soon as possible?

Same problem here, looks like the people at cordova added cordova.requestPermission from Cordova 5+ to check for the permissions required by Android Marshmallow.
If you have Cordova < 5 you can try with
cordova plugin add https://github.com/Rohfosho/CordovaCallNumberPlugin.git#dd1b05e13f90992668cdf8da730995f98ecfe256

That commit worked for me.
The weird thing is that I have Cordova 5.4.1 but I am still having those build problems, I even recreated the android platform but the problems persists, however I think that's a problem of my environment not a bug of the plugin.

I was just able to use the latest commit, but a lot of my configuration has changed since I last tried so I am not sure where it got fixed. Most likely when I upped the android build spec from 4.1.1 to 5.1.1, you can give this a go by setting it in the config.xml;
<engine name="android" spec="~5.1.1" />
You will probably need the correct Android sdk dependencies for it if you don't already.
of course remove, add and (attempt to) build Android.
Hope this helps!

@maxrevilo Your solution worked for me. Thanks

@maxrevilo Hey man! Your solution worked for me as well.

@maxrevilo Gracias tambien funciono para mi..!!


Py3 compatibility

Are there any plans for py3 compatibility using one of paramiko's forks?:
https://github.com/paramiko/paramiko/pull/236
Michal

+1

+1

Currently lives here: https://github.com/leopoul/ncclient/tree/devpy3
Next release which is going to be really soon will include it
Best,
L.

Hi Leopoul,
Any news on this? It's hopefully our last blocker for our migration to python 3 ;)
Thank you,
Mathieu

Any news on the soon to come release ? :-)

In the readme it says, that 0.5.0 with py3 support can be installed from pypitest, but when I look there ther is only 0.4.7 also without py3. I also can't find the code for it anywhere in the git repo. How do I install the dev version with py3?

OK, I just saw, that it is already merged into master, so pip install -e git+https://github.com/ncclient/ncclient.git#egg=ncclient does the job


Change Task from CDex conformant to PAS

Summary
This PR changes the Task resource in the dtr_bundle_patient_pat015.json file from a CDex Task to a PAS Task. This is to reflect changes to the DTR Light EHR Test suite in the davinci-dtr-test-kit based on this PR comment: https://github.com/inferno-framework/davinci-dtr-test-kit/pull/35#discussion_r1868310626.
New behavior

Task is now conformant to the PAS Task profile rather than the CDex Task Profile.

Code changes

Example PAS Task from the PAS IG instead of CDex Task.

Testing guidance

Run this branch locally and run this branch of the davinci-dtr-test-kit and run the DTR Light EHR Profiles Tests in the DTR Light EHR Test Suite using the Inferno Reference Server (Local) preset.

For resources that aren't referenced outside the bundle (E.g., in the DTR Light EHR preset), change the request method to POST so that ids assigned by the server and not fixed. HAPI should handle updating the references inside the bundle to use the newly generated id (though test and verify that!)


First Missing Positive

Problem Link
https://leetcode.com/problems/first-missing-positive/
Coding platform
Leetcode
Programming language

[ ] C
[ ] C++
[ ] Java
[ ] Python

Additional context (OPTIONAL)
I would like to work on this in C++

I want to solve it in python

Hi @Nivedita967
I would like to solve it in Java. Please assign it to me.

Can I do it in C?

I would like to do it in python. Can you please assign it to me!

Hi @Nivedita967
I would like to solve it in Java. Please assign it to me.

Java solution of this problem is already present in this project.

I would like to do it in python. Can you please assign it to me!

Python is not open.

I would like to do it in C++. Please assign it to me

Hi @Nivedita967
I would like to solve it in Java. Please assign it to me.

Java solution of this problem is already present in this project.

Okay then. Can I do it in C?

@Nivedita967 Please check my pull request

Hi @Nivedita967
I would like to solve it in Java. Please assign it to me.

Java solution of this problem is already present in this project.

Okay then. Can I do it in C?

C is not open.


Local Storage Question ?

I am not sure if this is a future or not but if I visit sites like twitter.com and youtube.com and I checked under chrome://settings/siteData I have local storage, cookies and so on.
 If I close one more time the browser, then the local storage's finally are cleaning. Is there any reason why we keep this local storage for 1 session and on the 2-nd there cleaned???
It's that a bug? I am thinking everything should be clean when Ungoogled is closing unless there are exception.

Is that issue reproducable in vanilla (standart) chromium?

Closing due to inactivity.


Placeholder docs for impl Trait

r? @matthewjasper
While we wait for the comprehensive docs, it'd be nice to have a placeholder so that we at least acknowledge it exists.

Modified this a bit due to discussion on IRC:
<isHavvy> What kind of type is "impl Trait"?
<est31> it is an universal type if in argument position
<est31> it is an existential type if in return position
<isHavvy> est31: I ultimately looked at the RFC and they called it an "Abstract type".
<est31> you mean the named existentials RFC?
<est31> or which RFC do you mean
<isHavvy> Conservative impl trait RFC
<isHavvy> "Abstract return type" specifically is the wording they use.
<est31> IIRC it didnt have any argument position impl trait
<est31> that's the thing the aturon RFC added
<rkruppe> the "return" is an important bit IMO, since existential impl trait isn't really any more abstract than generic parameters (which is to say, not entirely b/c we don't have parametricity)
<est31> we do have variance
<est31> it's just made to be variant on *all* input types of the function
<est31> even those on which aren't parameters of the actual return type
<est31> but yeah we don't have -> impl Trait<A,B,C>
<est31> that would run against the goals of impl Trait in argument position though
<est31> named existentials / abstract types require explicit variance
<isHavvy> So are they called "universal type" and "existential type" in type theory then? I figured that was just a property they had. After all, aren't generics also existential types?
<isHavvy> Err, universal*
<est31> idk about type theory, it's just the words being thrown around in the discussions :p
* est31 like a parrot
<est31> http://cultofthepartyparrot.com/parrots/hd/parrot.gif
<rkruppe> isHavvy: generics in general are universal types, impl Trait in argument position is just universal because it's another way to spell generics
<rkruppe> isHavvy: likewise there's plenty more to existential types than the little "abstract return types" that are impl Trait in return position, though unlike with universal types rust right now only has impl Trait in this space
<isHavvy> Alright. That all makes sense. So, is there an actual name to "impl Trait in argument position" that doesn't say "impl Trait"?
<rkruppe> also, although i've parrotted "universal type" here i am pretty unsure whether one can rightfully call "impl Trait" (or plain old T) on its own a type in the same sense e.g. char or Vec<i32> or &[&str] is a type. it's always situated in a function signature and pretty meaningless outside of it. and when type checking the function body there's just another free type *variable* corresponding to it
<isHavvy> It's a type in the sense that it's a predicate on what values are allowed, even if it's masking another type like e.g. generics do.
<isHavvy> "Anonymous generic type"?
<est31> yeah something like that

Thanks!


High vulnerabilities

Describe the bug
I found some high vulnerabilities in kafka-lag-exporter Docker image for version 0.8.1:

Severity
VulnerabilityID
Package Name
Package Version
Fixed Versions

High
CVE-2022-42003
com.fasterxml.jackson.core:jackson-databind
2.13.3
[2.14.0-rc1]

High
CVE-2022-34917
org.apache.kafka:kafka-clients
3.2.2
["2.8.2", "3.0.2", "3.1.2", "3.2.3"]

High
CVE-2022-42004
com.fasterxml.jackson.core:jackson-databind
2.13.3
[2.14.0-rc1]

High
CVE-2022-25857
org.yaml:snakeyaml
1.26
[1.31]

Environment
0.8.1

The Kafka lib has been upgraded in 0.8.2. I can't speak for the rest. Feel free to create another report.