Added documentation for the compiler-wrapper script hpxcxx.in in creating_hpx_projects.rst

@msimberg @hkaiser please check the documentation and correct me wherever I've gone wrong

Could you add some examples (for a component and/or executable) demonstrating the tool, please?

I am new to this project and am not comfortable with the invoking part of the script, can someone please direct me to some reference/tutorial that can help me? ( @stevenrbrandt )

@MukundVaradarajan could you please rebase your PR on top of current master to overcome the spell-check problems that are reported by the CircleCI builder?

Could you add some examples (for a component and/or executable) demonstrating the tool, please?

Let me clarify one thing. The only way to invoke it is to run python3 hpxcxx.in flags files, isn't it? Please correct me if I am wrong. I also have little or no idea about components and executables. Is it possible to get some clarity on this? ( @stevenrbrandt )

If someone can please point me to some tutorials or stuff like that, it would be awesome. Really sorry for the trouble I'm causing :( @msimberg @hkaiser any updates on this?

@hkaiser I am also not able to build hpx due to the following CMake error
`CMake Error at src/cmake_install.cmake:53 (file):
file INSTALL cannot find
"/home/mukund/open-source/hpx/my_build/lib/libhpx.so.1.4.0".
Call Stack (most recent call first):
cmake_install.cmake:138 (include)
Makefile:61: recipe for target 'install' failed
make: *** [install] Error 1`
Should I pull again from current master?

@MukundVaradarajan that should not happen under normal circumstances (and master is not broken, at least not like that). Could you post the full output, please?

@MukundVaradarajan that should not happen under normal circumstances (and master is not broken, at least not like that). Could you post the full output, please?

I had a install.sh script which had contents from https://stellar-group.github.io/hpx-docs/latest/html/quickstart.html#building-hpx where my install path was /home/<my-name>/open-source/hpx/my_build nothing else changed while I ran. My local version is basically a clone of my fork of this repo.
https://drive.google.com/open?id=1-4c_c3P_WjXEcTJHZE0SKPY1boshpk95 this was my ouptut

@MukundVaradarajan could you also put you're cmake command ?

@MukundVaradarajan could you also put you're cmake command ?

mkdir my_build && cd my_build cmake -DCMAKE_INSTALL_PREFIX=/home/mukund/open-source/hpx/my_build .. make install
These were the contents of install.sh that I used

@MukundVaradarajan that's strange. I don't see the error you posted in https://github.com/STEllAR-GROUP/hpx/pull/4414#issuecomment-598168185 in https://drive.google.com/open?id=1-4c_c3P_WjXEcTJHZE0SKPY1boshpk95. Are they different runs? Do you get the same errors every time?

@msimberg @hkaiser while this problem might be specific to me, I would like to update the docs with the examples, this whole issue was because I was experimenting. Could you kindly help me get it done in some way? I currently have no idea on how to build things. Really sorry for the trouble I'm causing. I feel this is taking too long for a simple issue.

@MukundVaradarajan this definitely not causing any trouble! The reason I'd like to resolve your install issues is that then you could see the script in action yourself. But I think it might be easiest to try to solve it live on IRC (you can also join through matrix). Let me know if you need help finding or joining the channel.
As a minimal executable example you could do the following:

Include the source of https://github.com/STEllAR-GROUP/hpx/blob/master/examples/quickstart/hello_world_1.cpp using .. literalinclude like here: https://github.com/STEllAR-GROUP/hpx/blob/master/docs/sphinx/quickstart.rst#hello-world. This will be our "example executable".
I think (once you've installed HPX) that you can then compile it with hpxcxx --exe=hello_world main.cpp (where main.cpp is the name of the source file)

@MukundVaradarajan this definitely not causing any trouble! The reason I'd like to resolve your install issues is that then you could see the script in action yourself. But I think it might be easiest to try to solve it live on IRC (you can also join through matrix). Let me know if you need help finding or joining the channel.
As a minimal executable example you could do the following:
* Include the source of https://github.com/STEllAR-GROUP/hpx/blob/master/examples/quickstart/hello_world_1.cpp using `.. literalinclude` like here: https://github.com/STEllAR-GROUP/hpx/blob/master/docs/sphinx/quickstart.rst#hello-world. This will be our "example executable".

* I _think_ (once you've installed HPX) that you can then compile it with `hpxcxx --exe=hello_world main.cpp` (where `main.cpp` is the name of the source file)

I was about to ask about solving my issue somewhere easily accessible and more live-oriented. Can you kindly direct me towards joining the channel? I would love to get my issues solved. Thanks so much for the help!

This is probably the fastest way to get on IRC: https://webchat.freenode.net/. The channel name is #ste||ar. Alternatively you can join through a dedicated IRC client. If you have a matrix.org account you can also join the IRC channel that way (the channel over there is called #hpx:matrix.org). I may not be very responsive during the weekend, but others may be around. Please don't get discouraged if noone replies immediately :)

Hi @MukundVaradarajan. How did it go with your build errors in the end?

Hi @MukundVaradarajan. How did it go with your build errors in the end?
Hi, @msimberg I am still facing errors, just with a different file, this time. is it ok if I resolve this through IRC?

Hi @MukundVaradarajan. How did it go with your build errors in the end?
Hi, @msimberg I am still facing errors, just with a different file, this time. is it ok if I resolve this through IRC?

IRC is always ok!

I've wrote on IRC but I didn't see you left the room, here is some tips:
"MukundVaradaraja: I managed to reproduce the error, I couldn't cp the hpxrun.py file into the /usr/local dir because the owner of the directory is root (output of ls -l /usr/local), please consider specifying another -DCMAKE_INSTALL_PREFIX=<path> to a location you know you are the owner of the directory (to see your username : whoami)"

@MukundVaradaraja what is the status of this? Do you plan to finish this up?

@MukundVaradaraja what is the status of this? Do you plan to finish this up?

Hi, @hkaiser  I have been really busy this week and I am unable to properly work on this, I am really sorry. But if there is some way that I can just include examples without building, I would be happy to finish this because the build issue is pretty frustrating and I would like to handle it separately. Is it possible to get relevant help from here?

I've wrote on IRC but I didn't see you left the room, here is some tips:
"MukundVaradaraja: I managed to reproduce the error, I couldn't cp the hpxrun.py file into the /usr/local dir because the owner of the directory is root (output of ls -l /usr/local), please consider specifying another -DCMAKE_INSTALL_PREFIX=<path> to a location you know you are the owner of the directory (to see your username : whoami)"

Thanks so much for the help, @aurianer .
I think the build went well, but is there a way to know for sure that the build went smoothly?

Thanks so much for the help, @aurianer .
I think the build went well, but is there a way to know for sure that the build went smoothly?

Building and running the tests is the surest way. We have some tests which fail occasionally but you should definitely see 99% pass. There are a lot of tests though and you don't really need to run those. If you just want a basic sanity check you can run e.g. hello_world_1 and hello_world_distributed (both in the bin directory). You should be able to compile hello_world_1 with hpxcxx as well. The source file is in examples/quickstart.

Thanks so much for the help, @aurianer .
I think the build went well, but is there a way to know for sure that the build went smoothly?

Building and running the tests is the surest way. We have some tests which fail occasionally but you should definitely see 99% pass. There are a lot of tests though and you don't really need to run those. If you just want a basic sanity check you can run e.g. hello_world_1 and hello_world_distributed (both in the bin directory). You should be able to compile hello_world_1 with hpxcxx as well. The source file is in examples/quickstart.

@msimberg
Build and tests went successfully, thanks a lot everyone! I have to come back to my initial question. I am unaware of what an application/component is in the context of hpx. Can I get some help on this? Some kind of tutorial or helpful links would also do :)

@msimberg
Build and tests went successfully, thanks a lot everyone! I have to come back to my initial question. I am unaware of what an application/component is in the context of hpx. Can I get some help on this? Some kind of tutorial or helpful links would also do :)

Applications are just what it says :) i.e. an executable (that is using HPX of course, but it's still an executable in the sense of any other executable). Components are a slightly overloaded term in HPX. On one hand it's a distributed object (https://stellar-group.github.io/hpx-docs/branches/master/html/terminology.html, https://stellar-group.github.io/hpx-docs/branches/master/html/manual/writing_distributed_hpx_applications.html#writing-components). On the other hand it's also the name we use for a shared library which contains HPX components. But in the context of compiling an application or component with hpxcxx they are just synonyms for executable and library that link to HPX.

@MukundVaradarajan do you think you'd have time to do the last small changes on this one? I'd say it's ready to merged and it'd be nice to have it in the next release. If you don't mind I can also do the last changes on this.

@MukundVaradarajan do you think you'd have time to do the last small changes on this one? I'd say it's ready to merged and it'd be nice to have it in the next release. If you don't mind I can also do the last changes on this.

I apologize for not responding soon. I got caught up in various personal issues.
I don't think I'll be able to add examples since I don't have experience in shared libraries and hpx components and I'm still caught up in various other issues. It would be great if @msimberg could apply the final changes to this. I apologize again for the delay in reply and inability to complete this.


Turn md-card element to mdCard Directive to give other elements 'Card powers'

Proposal:
To have md-card be a Directive instead of a Component so any element/component can be given Card behavior
What is the expected behavior?
To be able to have <my-component mdCard>.
What is the current behavior?
Currently only a <md-card> component can be visualized as a Card.
What is the use-case or motivation for changing an existing behavior?
Be able to apply whatever logic to <my-component> and still keep visualization like a Card with mdCard directive.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
All

Unfortunately its not possible to have md-card as a Directive because it uses a template.
Furthermore, if the templating were to be removed, styles cannot be applied via Directive selectors as shown in the documentation for the @Directive decorator.
If you are looking to provide the elevated look of the md-card, you should be able to do this using box-shadow on any components.

To supplement @josephperrott's answer, material provides a mat-elevation mixin and helper classes for adding elevation to elements:

I am an elevated div

Me too!

.elevate-me {
  @include mat-elevation(8);
}

See https://github.com/angular/material2/pull/3917 for in-progress guide

Elevation is not the only feature that a card provides... If I only wanted a
 to look like a card, I could just use class mat-card. That is not the point.
All the elements (<md-card-header>, <md-card-title>, <md-card-content>, etc) lose all their appearance and behavior if there is no <md-card> element on top.


Remove messages from dataset.json

Reason
This is a big security issue. In this file there are many messages made by Julia, which should not be public.
Implementation
I just cleared the file itself, and added some test messages to lead the way.

at this point anyone can just look up the commit history and take the dataset :3333
but still, you've fixed a very important security flaw!!!!!!!!!!!!!! so i am gonna merge it
thank you for your contribution!!!


System variable lookup not working with PatternLayout

Description
A custom layout with a pattern that has an environment variable lookup will not work in 2.17.2+
Introduced in https://github.com/apache/logging-log4j2/commit/9ffa643d69cdca4764bc2c4c0fe529379d17db2b#diff-0a2384aacbc3b28013b2f813d55a6504ae18d858d141a76b333606b2cdea98aaL766
PatternLayout#build no longer creates a default configuration
[A clear and concise description of what the bug is.]
Configuration
Version: [Log4j version]
2.17.2
Operating system: [OS and version]
Macos
JDK: [JDK distribution and version]
java 17.0.2 2
Logs
[Stacktraces, errors, etc. relevant applications logs.]

a log line from a example code in 2.17.1 (without a bug)
2023-07-12 11:22:16,252 envValue hello
a log line from an example code in 2.17.2 (with a bug)
2023-07-12 11:22:22,346 ${sys:envVar} hello
Reproduction
#src/x/Main.java
package x;

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.logging.log4j.core.Layout;
import org.apache.logging.log4j.core.LogEvent;
import org.apache.logging.log4j.core.config.Node;
import org.apache.logging.log4j.core.config.plugins.Plugin;
import org.apache.logging.log4j.core.config.plugins.PluginFactory;
import org.apache.logging.log4j.core.config.plugins.util.PluginManager;
import org.apache.logging.log4j.core.layout.AbstractStringLayout;
import org.apache.logging.log4j.core.layout.PatternLayout;

import java.nio.charset.Charset;

public class Main {

    public static void main(String[] args) {
        PluginManager.addPackage(Main.class.getPackage().getName());

        System.setProperty("envVar", "envValue");
        Logger logger = LogManager.getLogger("bug");
        logger.info("hello");
    }

    @Plugin(name = "CustomLayout", category = Node.CATEGORY, elementType = Layout.ELEMENT_TYPE, printObject = true)
    public static class CustomLayout extends AbstractStringLayout {
        private final PatternLayout patternLayout;

        public CustomLayout(String type, Charset charset, String[] overrideFields) {
            super(charset);
            this.patternLayout = PatternLayout.newBuilder()
                    .withPattern("%d ${sys:envVar} %msg%n")
                    .build();
        }

        @Override
        public String toSerializable(final LogEvent event) {
            return patternLayout.toSerializable(event);
        }

        @PluginFactory
        public static CustomLayout createLayout(String type, Charset charset, String[] overrideFields) {
            return new CustomLayout(type, charset, overrideFields);
        }
    }
}

#log4j.properties
appender.console.type = Console
appender.console.name = console
appender.console.layout.type = CustomLayout

rootLogger.level = info
rootLogger.appenderRef.console.ref = console

compile
javac -cp .:log4j-api-2.17.1.jar:log4j-core-2.17.1.jar src/x/Main.java -d .
run with 2.17.1
java -cp .:log4j-api-2.17.1.jar:log4j-core-2.17.1.jar x.Main
2023-07-12 11:36:33,496 envValue hello
run with 2.17.2
java -cp .:2.17.2/log4j-api-2.17.2.jar:2.17.2/log4j-core-2.17.2.jar x.Main
2023-07-12 11:36:27,196 ${sys:envVar} hello
a github repo with code to reproduce
https://github.com/pgomulka/log4j-bug-layout
git clone https://github.com/pgomulka/log4j-bug-layout
cd log4j-bug-layout
javac -cp .:log4j-api-2.17.1.jar:log4j-core-2.17.1.jar src/x/Main.java -d .
java -cp .:log4j-api-2.17.1.jar:log4j-core-2.17.1.jar x.Main
java -cp .:2.17.2/log4j-api-2.17.2.jar:2.17.2/log4j-core-2.17.2.jar x.Main

[An isolated test reproducing the test.
JUnit tests similar to the ones in the code base are extremely appreciated.]

@pgomulka,
The idea behind the change you are referring to is that:

we don't want to create configurations that are only used for interpolation,
every component should use the interpolator from the currently used configuration. Interpolators from different configurations can give different values.

I don't think there is a reason to rollback the change. If you want to use lookups in your layout, just inject a Configuration object into your factory method:
@Plugin(name = "CustomLayout", category = Node.CATEGORY, elementType = Layout.ELEMENT_TYPE, printObject = true)
public class CustomLayout extends AbstractStringLayout {

    private final PatternLayout patternLayout;

    private CustomLayout(final String type, final Charset charset, final String[] overrideFields, final Configuration config) {
        super(charset);
        this.patternLayout = PatternLayout.newBuilder()
                .withPattern("%d ${sys:envVar} %msg%n")
                .withConfiguration(config)
                .build();
    }

    @Override
    public String toSerializable(final LogEvent event) {
        return patternLayout.toSerializable(event);
    }

    @PluginFactory
    public static CustomLayout createLayout(
            @PluginAttribute("type") final String type,
            @PluginAttribute("charset") final Charset charset,
            @PluginAttribute("overrideFields") final String[] overrideFields,
            @PluginConfiguration final Configuration config) {
        return new CustomLayout(type, charset, overrideFields, config);
    }
}

BTW: since you are just using the serialization features of PatternLayout, you can replace it with a Serializer that you can obtain from PatternLayout#newSerializerBuilder

I can confirm that a workaround with passing down a configuration works.
However I think the argument of this breaking sem-ver is still valid.

@pgomulka,
I agree, that change probably should have caused a minor version bump to force custom component developers to update their code. Thank You for noticing it.


I overlooked the API for cache.Cache. It requires one to call Start() before it can be used and that call is blocking. Therefore it would require a goroutine and I believe it doesn't belong to library because it gets very well hidden very quickly. Hence I'll remove this from here and instead just configure it on-demand when needed.
Checklist

[x] Update changelog in CHANGELOG.md.

Going with a ping


Add licenses

We need to add a license to all classes similar to the one we have for the other hibernate projects

I'd suggest to enable checkstyle for this, with a single rule: just check the headers?

Oh gawd no, please no checkstyle. It's evil incarnate.
I really don't want to have to deal with failing CI builds because someone accidently removed a newline at the end of the file.

Well you can customize it :)
We can set it up to only check that the expected copyright header is in place

P.S. we can also set it to just warn rather than fail the build - not sure if people will pay attention in that case though..

By the way, I just checked, and none of the code in the Quarkus repo has headers, so I don't think we need them either.

@gavinking you'd not have needed them if you'd have opted for ASL2 :P

AFAIK we don't need them at all. A license file in the repo and in the dist is plenty.

P.S. we can also set it to just warn rather than fail the build - not sure if people will pay attention in that case though..

I don't like this, too easy to miss. If we need to add the license on the class it has to fail when the license is missing. In eclipse it's a template that add it automatically. I'm sure we can do something similar in Intellij

If we need to add the license on the class it has to fail when the license is missing.

Again, AFAIK we don't.
You put the license in the project root directory. That is the standard approach.
Adding headers to source files is just yet another thing that makes it harder to do work and creates problem for contributors.

Again, AFAIK we don't.

I haven said you are wrong. Shouldn't we check, though?

By the way, I just checked, and none of the code in the Quarkus repo has headers, so I don't think we need them either.

That's fine but this seem to me a legal problem (as far as I can tell). Is it enough to say: "they don't do it, so we won't either"?

Adding headers to source files is just yet another thing that makes it harder to do work and creates problem for contributors.

We've been doing it in all the other Hibernate projects for years and doesn't cause any issue of this kind (we have templates ready). It's not something new.

I've sent an email to Richard, you're all in CC - so let's wait for that.

If we need to add the license on the class it has to fail when the license is missing.

See this is precisely what cheeses me off about this sort of stuff. So there's a sort of soft recommendation from legal that if we add these notices it's nice because we can make life easier for some sort of automated source code scanning tools that people might hypothetically use.
Which is fine. I'm OK with that.
But then somehow we get from that to it's an absolute hard requirement that EVERY SINGLE SOURCE FILE HAS TO HAVE COPYRIGHT!!!!!!! and if we find one single file that doesn't have it then we make the build fail and everyone has to drop what they're doing and immediately go and race off and fix it right now even though some of us were actually doing real work at the time.
Back in reality it's simply not a problem at all if a few files in the code base are missing a header, and it's 99% probable that nobody's running an automated source code scanning tool on our source code anyway.
But y'know, while we're making checkstyle nags, I think I'll make a checkstyle nag that fails the build every time you guys check in a file that doesn't have Javadoc on it. Something tells me you wouldn't like that. And you'd be right. And you know wanna know what is the only difference between license notices and Javadoc?
That's right. Javadoc is actually really useful and important.

We've been doing it in all the other Hibernate projects for years and doesn't cause any issue of this kind

Well, wait, how do you think I even know that Hibernate ORM has a checkstyle build that fails when there's a missing header?  And it's really a pain.
First of all, checkstyle is incredibly dog slow.  And please don't try to tell me this is a nonissue because it's an issue right now in Hibernate ORM that I had to deal with when I was working on Hibernate 6.
And, I mean, look, I already feel like I spend more time dealing with gradle and git than I spend actually making things in Java, so I would really prefer to not add another slow step to the build.
Finally: outside contributors don't have their IDEs set up with exactly the same templates and stuff that you have in your IDE. (And that's especially the case since you insist that we're not allowed to check IntelliJ/Eclipse metadata into git.)
So anyway, if we have to do this then at least please be sensible about it and treat missing copyright noticed in just the same way you already treat missing Javadoc.

So in summary. I support adding checkstyle iff it will prevent you from checking in code without Javadoc 🤭

I agree with your concerns @gavinking , we don't want to waste time on pesky tooling. ll propose a solution which doesn't use checkstyle and still lets us have the headers consistently and hopefully at minimal hassle.

This was fixed via #191

Thanks!
On Tue, May 26, 2020 at 3:02 PM Sanne Grinovero<EMAIL_ADDRESS>wrote:

Closed #60 https://github.com/hibernate/hibernate-reactive/issues/60.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hibernate/hibernate-reactive/issues/60#event-3373700434,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEIQ5PQ3R4BPLBKKD2W363RTPDVZANCNFSM4K3EZ7TA
.


Update cell code in model as user types into editor

For #8589
For #9870

Code is kept upto date as user types into the editor/cell
Hence when running a cell, we only pass the cell id
When moving a cell up/down we only need the cell id
When changing focus we no longer attempt to update the cell source
When changing cell types from markdown to code, we use code in current state instead of passing it.

Basically the expectation is that the cells in extension and state will always be up to date with latest code
We'll always strive to keep the cells updated with the latest source upon typing text as per issue requirement.
Found some places where we're blowing away cell source, hence stuff thats supposed to be multi line isn't.
Again, WIP

[ ] Add functional tests
[ ] Review issues where code was lost (when changing cell types), ensure this still works
[ ] Add tests for https://github.com/microsoft/vscode-python/issues/9719
[ ] Add tests to ensure redux state is updated as we type into the editor

The cell.data.code should be updated with latest code
The inputBlockText should be updated with latest code

[ ] Add tests to ensure the model in extension is updated as a result of changes in editor.
[ ] Add tests to ensure changing from markdown to code results in

[ ] Updates to corresponding cells in redux state
[ ] Updates to corresponding cells in extension model
[ ] Mardown to code
[ ] Code to markdwon

Codecov Report

Merging #10339 into master will decrease coverage by 0.04%.
The diff coverage is 3.12%.

@@            Coverage Diff             @@
##           master   #10339      +/-   ##
==========================================
- Coverage   60.84%   60.79%   -0.05%
==========================================
  Files         570      570
  Lines       30720    30737      +17
  Branches     4376     4378       +2
==========================================
- Hits        18691    18686       -5
- Misses      11078    11098      +20
- Partials      951      953       +2

Impacted Files
Coverage Δ

src/datascience-ui/interactive-common/mainState.ts
54.11% <ø> (ø)
:arrow_up:

...ience/interactive-common/interactiveWindowTypes.ts
100% <ø> (ø)
:arrow_up:

...tascience/interactive-ipynb/nativeEditorStorage.ts
50.64% <0%> (-1.53%)
:arrow_down:

...ient/datascience/interactive-ipynb/nativeEditor.ts
11.06% <4.34%> (+0.04%)
:arrow_up:

src/datascience-ui/react-common/arePathsSame.ts
75% <0%> (-12.5%)
:arrow_down:

src/client/common/utils/platform.ts
64.7% <0%> (-11.77%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0%> (-0.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56670f...04390ca. Read the comment docs.

@rchiodo @IanMatthewHuff @DavidKutu I am yet to add the tests.
But would appreciate a review of the changes if possible. Thanks


error: pq: SSL is not enabled on the server

It looks like you need to pass an option to indicate this on your connection string.
http://stackoverflow.com/questions/21959148/ssl-is-not-enabled-on-the-server

thanks. I understand

No problem.

You need to pass the ?sslmode= option to the URL.


Dict provider

https://python-dependency-injector.ets-labs.org/providers/dict.html
Very similar to https://that-depends.readthedocs.io/providers/list.html

@lesnik512 Is it possible to start working on this improvement? Are there any particular rules I need to know before opening a PR?

@Denis-Frunza yes, it would be great!
It's better to put this provider here with list https://github.com/modern-python/that-depends/blob/main/that_depends/providers/collections.py
And here is small guide for contributors https://that-depends.readthedocs.io/dev/contributing.html


[SPARK-14883][DOCS] Fix wrong R examples and make them up-to-date

What changes were proposed in this pull request?
This issue aims to fix some errors in R examples and make them up-to-date in docs and example modules.

Fix the wrong usage of map. We need to use lapply if needed. However, the usage of lapply also needs to be reviewed since it's private.

-teenNames <- map(teenagers, function(p) { paste("Name:", p$name)})
+teenNames <- SparkR:::lapply(teenagers, function(p) { paste("Name:", p$name) })

Fix the wrong example in Section Generic Load/Save Functions of docs/sql-programming-guide.md for consistency
Fix datatypes in sparkr.md.
Update a data result in sparkr.md.
Replace deprecated functions to remove warnings: jsonFile -> read.json, parquetFile -> read.parquet
Use up-to-date R-like functions: loadDF -> read.df, saveDF -> write.df, saveAsParquetFile -> write.parquet
Replace SparkR DataFrame with SparkDataFrame in dataframe.R and data-manipulation.R.
Other minor syntax fixes and a typo.

How was this patch tested?
Manual.

Test build #56835 has started for PR 12649 at commit 5d6d45e.

Test build #56835 has finished for PR 12649 at commit 5d6d45e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56835/
Test PASSed.

Merged build finished. Test PASSed.

Hi, @davies , @shivaram, @felixcheung .
Could you review this PR when you have some time?

Test build #56876 has started for PR 12649 at commit 47aa57e.

looks good!

Test build #56876 has finished for PR 12649 at commit 47aa57e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56876/
Test PASSed.

Merged build finished. Test PASSed.

Thank you, @felixcheung !

LGTM. Merging this

Thank you for merging, @shivaram .


draftsight: 2018SP2 -> 2019SP0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/draftsight/versions.
meta.description for draftsight is: '"2D design & drafting application, meant to be similar to AutoCAD"'.
meta.homepage for draftsight is: '"https://www.3ds.com/products-services/draftsight-cad-software/"

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 2019SP0 with grep in /nix/store/piwhbaa0f565milf6kmm917amsjmm9yf-draftsight-2019SP0
directory tree listing: https://gist.github.com/8954e16eea4e31db0c56eba78a7e9aa4
du listing: https://gist.github.com/2f61bbf1d13c3e357d0fc16a5e08f142

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
draftsight

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/piwhbaa0f565milf6kmm917amsjmm9yf-draftsight-2019SP0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A draftsight https://github.com/r-ryantm/nixpkgs/archive/f389d2b0a1ecfd3b616a05abb55a566bb3676bd6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/piwhbaa0f565milf6kmm917amsjmm9yf-draftsight-2019SP0
ls -la /nix/store/piwhbaa0f565milf6kmm917amsjmm9yf-draftsight-2019SP0/bin

cc @Hodapp87 for testing.

@worldofpeace can you please assist with this package? It fails with following:
This application failed to start because it could not find or load the Qt platform plugin "xcb"
in "".

I did try to wrap it around with QT_PLUGIN_PATH and moving it to LibsForQT5's mkDerivation, but I cannot make it work. Do you mind looking at it?

That's weird. I don't see it using anything qt related anywhere in the expression.
Then I noticed that it bundles everything lots of things, included qt libraries and that includes its plugins.
The reason wrapping had no effect is because it's already wrapped and wrapQtAppsHook ignores this.
So to fix this we should probably

use qt5's mkDerivation
drop manual wrapping in installPhase (note the symlinks to bin still need to be made)
add the args makeWrapper was already given to qtWrapperArgs

Then you have to set qtPluginPrefix to the appropriate directories in the output.
I think that's

draftsight/opt/dassault-systemes/DraftSight/PlugIns/QtPlugIns

cc @Hodapp87

ping @Hodapp87 do you mind looking at this?

@mmahut I am going to look at it a little today as time permits

@worldofpeace I am trying to follow your directions here, but I am still stuck at:
[nix-shell:~]$ DraftSight
terminate called after throwing an instance of 'std::runtime_error'
  what():  This application failed to start because it could not find or load the Qt platform plugin "xcb"
in "".

Available platform plugins are: linuxfb, minimal, offscreen, vnc, xcb.

Reinstalling the application may fix this problem.
Aborted

Below is the patch for what I'm trying from draftsight-update/auto-update/draftsight:
diff --git a/pkgs/applications/graphics/draftsight/default.nix b/pkgs/applications/graphics/draftsight/default.nix
index<PHONE_NUMBER>a..3e500b28000 100644
--- a/pkgs/applications/graphics/draftsight/default.nix
+++ b/pkgs/applications/graphics/draftsight/default.nix
@@ -27,9 +27,7 @@ stdenv.mkDerivation {
       patchelf --interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" \
                --set-rpath $libPath:\$ORIGIN/../Libraries \
                $out/draftsight/opt/dassault-systemes/DraftSight/Linux/$exe
-      makeWrapper $out/draftsight/opt/dassault-systemes/DraftSight/Linux/$exe \
-          $out/bin/$exe \
-          --prefix "QT_XKB_CONFIG_ROOT" ":" "${xkeyboard_config}/share/X11/xkb"
+      ln -s $out/draftsight/opt/dassault-systemes/DraftSight/Linux/$exe $out/bin/$exe
     done
     for lib in $out/draftsight/opt/dassault-systemes/DraftSight/Libraries/*.so*; do
       # DraftSight ships with broken symlinks for some reason
@@ -55,6 +53,8 @@ stdenv.mkDerivation {
     find $out/draftsight/opt/dassault-systemes/DraftSight/APISDK/Samples/C++ \
          -type d -name _lib | xargs rm -r
   '';
+  qtWrapperArgs = [ "--prefix" "QT_XKB_CONFIG_ROOT" ":" "${xkeyboard_config}/share/X11/xkb" ];
+  qtPluginPrefix = "$out/draftsight/opt/dassault-systemes/DraftSight/PlugIns/QtPlugIns";

   # TODO: Figure out why HelpGuide segfaults at startup.

diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index f642f9e1832..5b8ce6df559 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -17459,7 +17459,7 @@ in

   dr14_tmeter = callPackage ../applications/audio/dr14_tmeter { };

-  draftsight = callPackage ../applications/graphics/draftsight { };
+  draftsight = qt5.callPackage ../applications/graphics/draftsight { };

   dragonfly-reverb = callPackage ../applications/audio/dragonfly-reverb { };

qtWrapperArgs needs to be one string.
- "--prefix" "QT_XKB_CONFIG_ROOT" ":" "${xkeyboard_config}/share/X11/xkb"
+ "--prefix QT_XKB_CONFIG_ROOT : ${xkeyboard_config}/share/X11/xkb"

and I think you should be using libsForQt5.callPackage
- draftsight = qt5.callPackage ../applications/graphics/draftsight { };
+ draftsight = libsForQt5.callPackage ../applications/graphics/draftsight { };

Can you also check if the executable at $out/bin is a script and not a wrapper?
Also, there was a regression on 19.09 and master recently that prevent wrapGAppsHook from following symlinks and wrapping the binaries. https://github.com/NixOS/nixpkgs/commit/15e99a06a8d06f992ff4b148ee2cbeaf763a674f
Do you ^ commit in your branch? (i.e rebase?)

I'm now at the below diff and having the same errors. The hash was identical, so I don't think it changed anything. $out/bin/DraftSight is just a symlink to the binary draftsight/opt/dassault-systemes/DraftSight/Linux/DraftSight (it's not a script).
draftsight-update/auto-update/draftsight was branched awhile ago, so I don't expect that the most recent regression is in it.
diff --git a/pkgs/applications/graphics/draftsight/default.nix b/pkgs/applications/graphics/draftsight/default.nix
index<PHONE_NUMBER>a..e9f2e0be189 100644
--- a/pkgs/applications/graphics/draftsight/default.nix
+++ b/pkgs/applications/graphics/draftsight/default.nix
@@ -27,9 +27,7 @@ stdenv.mkDerivation {
       patchelf --interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" \
                --set-rpath $libPath:\$ORIGIN/../Libraries \
                $out/draftsight/opt/dassault-systemes/DraftSight/Linux/$exe
-      makeWrapper $out/draftsight/opt/dassault-systemes/DraftSight/Linux/$exe \
-          $out/bin/$exe \
-          --prefix "QT_XKB_CONFIG_ROOT" ":" "${xkeyboard_config}/share/X11/xkb"
+      ln -s $out/draftsight/opt/dassault-systemes/DraftSight/Linux/$exe $out/bin/$exe
     done
     for lib in $out/draftsight/opt/dassault-systemes/DraftSight/Libraries/*.so*; do
       # DraftSight ships with broken symlinks for some reason
@@ -55,6 +53,8 @@ stdenv.mkDerivation {
     find $out/draftsight/opt/dassault-systemes/DraftSight/APISDK/Samples/C++ \
          -type d -name _lib | xargs rm -r
   '';
+  qtWrapperArgs = [ "--prefix QT_XKB_CONFIG_ROOT : ${xkeyboard_config}/share/X11/xkb" ];
+  qtPluginPrefix = "$out/draftsight/opt/dassault-systemes/DraftSight/PlugIns/QtPlugIns";

   # TODO: Figure out why HelpGuide segfaults at startup.

diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index f642f9e1832..2f7d8b26475 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -17459,7 +17459,7 @@ in

   dr14_tmeter = callPackage ../applications/audio/dr14_tmeter { };

-  draftsight = callPackage ../applications/graphics/draftsight { };
+  draftsight = libsForQt5.callPackage ../applications/graphics/draftsight { };

   dragonfly-reverb = callPackage ../applications/audio/dragonfly-reverb { };


Update README

Fix crontab schedule to run every minute, not only 1st minute of the hours between 5-11.

Btw, did you plot anything? Wondering what kind of data you got.


Skipping previous scene without popping onBackPress in Full screen

I am having 3 scenes flow like this A -> B -> C
A Scene : This is the scene where I will select video
B Scene : In this scene when user clicks play button I will navigate to Scene C
       `NavigationActions.sceneC();`

C Scene : In this scene I will defaultly play youtube video in full screen mode like below
<YoutubePlayer
        videoId={videoId}
        play
        hidden={false}
        loop={false}
        fullscreen
        showFullscreenButton={false}
        onError={(e) => {
          if (__DEV__) console.log('Youtube playing Error', e.error)
        }}
      />

Here the problem is After getting into Scene C when I press back button I am directly going to Scene A. And When I select another video I am getting error like navigation state children key conflicts with another child (Seems to be Scene B is still in the stack I guess).  I am using react-native-router-flux for navigation.  Am I doing any thing wrong ? Basically I want to navigate user directly to youtube full screen mode without inline in another scene.
Info :
"react": "~15.4.0-rc.4",
"react-native": "0.42.3",
"react-native-youtube": "^1.0.0-alpha.4",
"react-native-router-flux": "3.38.0",

@Dineshchitta Is it the hardware Android back button of the back button of the navigation?
iOS and android are a bit different when it comes to the fullscreen mode so I'm afraid you'll have to solve it different for each platform.
Basically the YouTubeStandaloneAndroid can accomplish your needs in Android, in iOS you can do stuff a bit different

@davidohayon669 I tried with YoutubeStandaloneAndroid but problem still exist. I tried debugging by putting another normal scene at that time there is no problem.

@Dineshchitta so what is the problem now?


Load strings from PDN 4.2.5's IWebPFileTypeStrings

This is part of the work for bundling this plugin with PDN 4.2.5, https://github.com/paintdotnet/paint.net/issues/1206 and https://github.com/paintdotnet/paint.net/pull/1515

@0xC0000054

Looks good to me.
I will merge this commit and work on some refactoring.
Thanks Rick.


feat: class navigation sidebar

Closes #319
Adds a class navigation sidebar for quickly navigating methods, properties, etc.
To avoid too much squishing because of the extra horizontal room it takes up, I changed the responsive layout for package pages so that the switching point between tablet and desktop layouts is at chakra's "lg" instead of "md".
Currently this sidebar is created based on the JSON doc schema that is generated in conjunction with markdown docs for each package. Since these are different sources of information, there's some logic that had to be duplicated from how we are generating the markdown and generating links / IDs. Once we generate the API reference straight from the API.json and remove the markdown from the picture, it's possible we could simplify this down a lot.
Screenshot:

Just noticed one more small issue, which is that the query params aren't properly added to the links - fixing...


update NOTICE to align with java.

a bunch of documentation taken from java pre-dates the cpp repo, so keeping the 2015 copyright start date

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.347%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2184

Relevant Lines:
2365

💛  - Coveralls


Add tap on the descirption

I would like to add tap feature on the description label.
So that I can either click the button or label to trigger the function.
But as if I add the UITapGestureRecognizer on the description, it is not working
Would you mind help me have a check for the method?
- (void)setDescriptionsTap
{
    for (NSUInteger i=0; i<_descriptionsArray.count; i++)
    {
        [_descriptionsArray[i] setUserInteractionEnabled:true];
        UITapGestureRecognizer *tapGesture = [[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(buttonActionForTap:)];
        tapGesture.delegate = self;
        [tapGesture.view setTag:i];
        [_descriptionsArray[i] addGestureRecognizer:tapGesture];

    }
}

Hi,
I would need exactly the same behaviour when i click on the description and on the button.
Is there any way to do that ?
Regards,
Morgan

@morganbigot
I fixed this function now
`- (UIView *)hitTest:(CGPoint)point withEvent:(UIEvent *)event
{
//NSLog(@"\nself = %@\nsuper = %@\nsubviews = %@\nsupersubviews = %@\n\n", self, [super hitTest:point withEvent:event], self.subviews, self.superview.subviews);
UIView *view = nil;

for (LGPlusButton *button in _buttonsArray)
{
    CGPoint newPoint = [self convertPoint:point toView:button];

    view = [button hitTest:newPoint withEvent:event];
    if (view) break;
}

if(!view){
    for (LGPlusButtonDescription *description in _descriptionsArray)
    {
        CGPoint newPoint = [self convertPoint:point toView:description];

        view = [description hitTest:newPoint withEvent:event];
        if (view) break;
    }
}

if (!view && _coverColor && !_coverView.isHidden)
{
    CGPoint newPoint = [self convertPoint:point toView:_coverView];

    view = [_coverView hitTest:newPoint withEvent:event];
}

return view;

}
`
By Adding these code, then you can add UITapGestureRecognizer function on the Description label with userInteractionEnabled = YES

Thank you!
Morgan BIGOT
Co-CEO SeeMeCab
<EMAIL_ADDRESS>+33 (0)6 60 24 41 07

Le 3 mars 2016 à 17:55, johnny51925<EMAIL_ADDRESS>a écrit :
@morganbigot
I fixed this function now
`- (UIView *)hitTest:(CGPoint)point withEvent:(UIEvent *)event
{
//NSLog(@"\nself = %@\nsuper = %@\nsubviews = %@\nsupersubviews = %@\n\n", self, [super hitTest:point withEvent:event], self.subviews, self.superview.subviews);
UIView *view = nil;
for (LGPlusButton *button in _buttonsArray)
{
CGPoint newPoint = [self convertPoint:point toView:button];
view = [button hitTest:newPoint withEvent:event];
if (view) break;

}
if(!view){
for (LGPlusButtonDescription *description in _descriptionsArray)
{
CGPoint newPoint = [self convertPoint:point toView:description];
    view = [description hitTest:newPoint withEvent:event];
    if (view) break;
}

}
if (!view && _coverColor && !_coverView.isHidden)
{
CGPoint newPoint = [self convertPoint:point toView:_coverView];
view = [_coverView hitTest:newPoint withEvent:event];

}
return view;
}
`
By Adding these code, then you can add UITapGestureRecognizer function on the Description label with userInteractionEnabled = YES
—
Reply to this email directly or view it on GitHub.

Hi,
Will you make an update of the POD with that fix ?
Regards,
2016-03-03 17:55 GMT+01:00 johnny51925<EMAIL_ADDRESS>
@morganbigot https://github.com/morganbigot
I fixed this function now
`- (UIView *)hitTest:(CGPoint)point withEvent:(UIEvent *)event
{
//NSLog(@"\nself = %@\nsuper = %@\nsubviews = %@\nsupersubviews = %@\n\n",
self, [super hitTest:point withEvent:event], self.subviews,
self.superview.subviews);
UIView *view = nil;
for (LGPlusButton *button in _buttonsArray)
{
CGPoint newPoint = [self convertPoint:point toView:button];
view = [button hitTest:newPoint withEvent:event];
if (view) break;

}
if(!view){
for (LGPlusButtonDescription *description in _descriptionsArray)
{
CGPoint newPoint = [self convertPoint:point toView:description];
    view = [description hitTest:newPoint withEvent:event];
    if (view) break;
}

}
if (!view && _coverColor && !_coverView.isHidden)
{
CGPoint newPoint = [self convertPoint:point toView:_coverView];
view = [_coverView hitTest:newPoint withEvent:event];

}
return view;
}
`
By Adding these code, then you can add UITapGestureRecognizer function on
the Description label with userInteractionEnabled = YES
—
Reply to this email directly or view it on GitHub
https://github.com/Friend-LGA/LGPlusButtonsView/issues/24#issuecomment-191856249
.

--
Morgan BIGOT
CO-CEO  ArchiReport by SeeMeCab
phone: +33 2 23 25 61 98
mobile: +33 6 60 24 41 07
http://www.archireport.com
http://www.seemecab.com
http://www.seemecab.com


ublacklist doesn't work in firefox (desktop browser)

Expected Behavior ublacklist extension to work in firefox
Actual Behavior doesn't appear at all next to websites with firefox
Steps to Reproduce the Problem

Install firefox
Install ublacklist extension
search anything and watch no ublacklist block site text/option appear at all next to sites

Specifications

Browser: Firefox
Other extensions/add-ons: None

Search engine: Duckduckgo
Language: English
Region: US

The extension appears to be totally broken in Firefox. Any suggestions?


Sort same ranked items alphabetically

What:

Sort same ranked items alphabetically rather than by the index they were inputted.
Updated tests.
One new test.

Why:
Currently, if items are the same rank with the same key based index, the items are sorted based on their index in the starting input.  This is fine in general but I believe it makes more sense to sort them alphabetically when they have the same ranking and also by length allowing the smaller words to float to the top and make filtering a progressive act.
Example:
search: ap
input:            ['wrapped','snap', 'pap']
old output:   ['wrapped','snap', 'pap']
new output: ['pap', 'snap', 'wrapped']

How:
We can take advantage of the base String.prototype.localeCompare() to do a comparison while ignoring diacritics.

Checklist:

[ ] Documentation
[x] Tests
[x] Ready to be merged (discussion may be needed)
[ ] Added myself to contributors table

Comments
This currently does not go past first level items e.g. when keys are provided with a list of objects as we only have a keyIndex at the point they are being sorted and not the actual key so it relies upon the same index ranking as it was previously doing.

Closing to rebase.  Will create new pr.


Display sq area/distance while drawing polygons/polylines/circles

Hey @codeofsumit,
Thanks a lot for this project and your time!
I have been looking around the documentation and repo and was unable to find support for showing sq area/distance when drawing polygons/polylines/circles. I guess it's a feature request. I hope it can be added to this awesome library.
Thanks a lot!

Will close until this has more upvotes. But definitely something I want to add within the next months! Thank you for the suggestion.

turf.js works really well for calculating area.
turf.area(layer.toGeoJSON())

the method described by @kunKun-tx works perfectly for polygons with distinct vertices. does anyone know if a way to calculate the area of a drawn circle? my existing function throws no errors however the geometry object which the circle generates only contains one coordinate pair (the center point) so the area is always calculated as 0. Any suggestions?

@bw1984
it's probably easier to calc the circle area using its raduis layer.getRadius()?
ref:
https://leafletjs.com/reference-1.6.0.html#circlemarker-getradius

I all, this feature is now implemented in Leaflet-Geoman Pro which is the way we fund the development of this open-source library. Eventually, features of the Pro version will trickle down to the OSS library which is happening already with many features. If you use Leaflet-Geoman in a professional environment, please consider going for the Pro version to get more features and support this open source project.


[FEATURE] SemVer container image tags

Scope of your request
Add additional SemVer container image tags to published images. This will allow users more flexibility in balancing compatability vs staying up to date with new versions.
Describe the solution you'd like
More or less what is described in this blog: https://medium.com/@mccode/using-semantic-versioning-for-docker-image-tags-dfde8be06699.
Describe alternatives you've considered
We are using k3d to perform e2e testing on feature branches for our K8s controllers. Since this is not a production system, and to avoid updating versions constantly, we are currently using the latest tags of the k3d images. This has been working good, but with the recent 5.0.0-dev releases, all our builds are currently failing. (I will create a separate issue for the errors observed.)

Hi @erikgb , thanks for opening this issue!
Can you elaborate a bit on what images you're referring to? :thinking:
I may be missing something, but afaik all images pushed by Drone use semantic versioning :thinking:

@iwilltry42 We pulling the k3d (and k3s) images from Docker Hub. What I would like to see, is that the follow search could give an exact match: https://hub.docker.com/r/rancher/k3d/tags?page=1&ordering=last_updated&name=v4. So for every release, you would publish (at least) 3 tags on the image. Using the latest release as an example (version 4.4.7), I would like to see the following tags:

v4.4.7
v4.4
v4

That will allow us to consume the latest version of the version 4 major version series, but NOT version 5 images - which might contain breaking changes. So we would probably use the v4 tag.

Aaah now I got it, you're missing the tag hierarchy there 💡
I'll see how we can add this to the Drone workflow 👍

Double checking the correctness of the pipeline in the next release(s)


fix incorrect ecosystem name in README

fixes #140
Also links directly to the file in dependabot-core that has the ecosystem names.

Smoke test failures seem to be an upstream bug https://github.com/docker/cli/issues/4437


Auto Update while running doesn't restart app

It seems that when the AppVersion auto updates and it does not restart the Presence app by itself... (so it needs to be manually restarted)
I am aware that the update check also occurs at the initial launch but its also doing a auto check while running and auto updating after terminating the app.
Can we have it auto-restart?

There isn't a graceful way for me to restart the application on update , I can inform the user that an update is available and restart it. Would that be good solution?

Ah - that is a pain , i know i have seen other apps be able to restart themselves somehow!
Maybe in the meantime - 2 options based on user config/setting preference

AutoUpdate OFF - but do a windows toast notification when there is a new one available and click to update
AutoUpdate ON - and do a windows toast notification that it was auto updated (and click to restart?)

thoughts?

I don't have a ton of control regarding updates. Sorry I have to close this. If you find something (or a similar app experience) I will circle back. I recommend a hotkey or something to close/start PL


MonthPicker Problem

Month picker not working. here  is my code like this
$('.datepicker3').bootstrapMaterialDatePicker({         format: 'YYYY-MM',         time:false,         monthPicker:true,     });

Not work for me too.
The monthpicker seems to work

until you click on the prev

I've fixed the problem, just paste
if (this.params.monthPicker === true)
{
     this._hideCalendar();
}

To the end of these functions
onMonthBeforeClick
onMonthAfterClick
onYearBeforeClick
onYearAfterClick
onYearRangeBeforeClick
onYearRangeAfterClick

I'm thinking about commiting this fix

thanks. my is solved.

@mssc89  am not having _hideCalendar() function in bootstrap-material-datetimepicker.js, could you give that function code...

Why this issue is still not fixed?


Unable to successfully compile the sample project

# OS
ProductName:    Mac OS X
ProductVersion: 10.14.5
BuildVersion:   18F132

# Xcode
Xcode 10.2.1
Build version 10E1001
iOS SDK 12.2

# Swift
Apple Swift version 5.0.1 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.6.0

Procedure

Create the sample project

$ mkdir -p SwiftDemo && cd SwiftDemo && swift package init --type library

(structures) =>
.
├── Package.swift
├── README.md
├── Sources
│   └── SwiftDemo
│       └── SwiftDemo.swift
└── Tests
    ├── LinuxMain.swift
    └── SwiftDemoTests
        ├── SwiftDemoTests.swift
        └── XCTestManifests.swift

4 directories, 6 files

Add Alamofire as dependency

// swift-tools-version:5.0
// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription

let package = Package(
	name: "SwiftDemo",
	products: [
		// Products define the executables and libraries produced by a package, and make them visible to other packages.
		.library(
			name: "SwiftDemo",
			targets: ["SwiftDemo"]),
	],
	dependencies: [
		// Dependencies declare other packages that this package depends on.
		// .package(url: /* package url */, from: "1.0.0"),
		.package(url: "https://github.com/Alamofire/Alamofire.git", from: "5.0.0-beta.5"),
	],
	targets: [
		// Targets are the basic building blocks of a package. A target can define a module or a test suite.
		// Targets can depend on other targets in this package, and on products in packages which this package depends on.
		.target(
			name: "SwiftDemo",
			dependencies: ["Alamofire"]),
		.testTarget(
			name: "SwiftDemoTests",
			dependencies: ["SwiftDemo"]),
	]
)

Generate the Xcode project

$ swift package generate-xcodeproj

Initialize Accio

$ accio init -p SwiftDemo -t SwiftDemo

(outputs) =>
⚠  A non-empty Package.swift file already exists, skipping template based creation.
✨  Adding .gitignore entries for build & dependencies directories.
✨  Successfully initialized project.

Install or update using Accio

$ accio install

(outputs) =>
Fetching https://github.com/Alamofire/Alamofire.git
Completed resolution in 40.34s
Cloning https://github.com/Alamofire/Alamofire.git
Resolving https://github.com/Alamofire/Alamofire.git at 5.0.0-beta.6
✨  Reading package manifest at ~/SwiftDemo/Package.swift ...
✨  Generating dependency graph ...
✨  Resolving dependencies for target 'SwiftDemo' on platform 'macOS' ...
✨  Found cached build products for Alamofire in local cache - skipping build.
✨  Resolving dependencies for target 'SwiftDemoTests' on platform 'macOS' ...
❌  DependencyGraph: Could not find library product with name 'SwiftDemo' in package manifest for project 'SwiftDemo'.
An error occurred: libraryNotFound

Solutions:
// Remove `SwiftDemo` from `SwiftDemoTests`'s dependencies

...
targets: [
	// Targets are the basic building blocks of a package. A target can define a module or a test suite.
	// Targets can depend on other targets in this package, and on products in packages which this package depends on.
	.target(
		name: "SwiftDemo",
		dependencies: ["Alamofire"]),
	// .testTarget(
	// 	name: "SwiftDemoTests",
	// 	dependencies: ["SwiftDemo"]),
]
...

or
#  Start over and change target to SwiftDemoPackageDescription
$ accio init -p SwiftDemo -t SwiftDemoPackageDescription

Install or update using Accio again

$ accio update

(outputs) =>
✨  Reverting any changes in the checkouts directory ...
✨  Updating dependencies ...
Updating https://github.com/Alamofire/Alamofire.git
Completed resolution in 2.66s
Everything is already up-to-date
✨  Reading package manifest at ~/SwiftDemo/Package.swift ...
✨  Generating dependency graph ...
✨  Resolving dependencies for target 'SwiftDemo' on platform 'macOS' ...
✨  Found cached build products for Alamofire in local cache - skipping build.
✨  Copying build products of target 'SwiftDemo' into folder 'Dependencies' ...
✨  Adding frameworks ["Alamofire"] to project navigator group 'Dependencies/SwiftDemo' & linking with target 'SwiftDemo' ...
✨  Creating new copy build script phase 'Accio' for target 'SwiftDemo'...
✨  Updating input paths in copy build script phase 'Accio' for target 'SwiftDemo' ...
✨  Removing frameworks ["Package.swift"] from project navigator group 'Dependencies/Alamofire 5.0.0-beta.6' ...
✨  Removing empty groups ["Alamofire 5.0.0-beta.6"] from project navigator group 'Dependencies' ...
✨  Successfully updated dependencies.

Wanted

Where can I found the SwiftDemo.Framework?
(Or does the swift command line not support creating frameworks?)

How do I compile for multiple platforms (iOS, watchOS and etc.) at once? (
If I don't manually modify the generated Xcode project.)

Thanks!

I think there's a general misunderstanding here. You are using Accio to handle your dependencies in a SwiftPM project. But actually, SwiftPM can do that already, there's no need to manage dependencies with Accio in SwiftPM projects. That's what SwiftPM already aims to do.
Accio is for apps targeting iOS, tvOS, macOS or watchOS to include dependencies that support either SwiftPM or Carthage. So all the questions you're asking are questions for the SwiftPM project itself and should probably be asked on a site like SO.
Does this clarify the situation for you? Or maybe I misunderstood something?

Sorry, I misunderstood. Anyway, thank you.
And I temporarily solved my problem with xcodebuild.


Added LargeFizzBuzz_AsOutput.py

My python program gives the output as a large FizzBuzz made up of small FizzBuzz numbers.

neat! thanks :D


Support private HuggingFace Hub models?

I think in order to support private HF Hub models, invocations of .from_pretrained, e.g. here, would need to have a parameter, use_auth_token. This parameter defaults to None. Setting it to True uses a local cached auth token (from calling $ transformers-cli login). It can also be set to a string, the API Key, found at https://huggingface.co/settings/token (or https://huggingface.co/organizations/ORG_NAME/settings/token for organizations).
Would you be open to a PR which adds this? I did something similar in fastT5.

good idea, please, do it.


Inspect and / or delete cached properties

Hi @pydanny,
Thank you for this package! This pull request addresses issues #32 and #196. Here is a sum-up:

All cached properties derive from a parent class CachedProperty, so that we can use isinstance to identify them easily.
Add function cached_properties: iterate over the cached properties of an object.
Add function is_cached: whether a cached property is already cached.
Add function un_cache: empty the cache for a cached property. As @Tinche noted, it avoids exposing an implementation detail.
Add function delete_cache: empty the whole cache of an object.
Add decorator property_deleting_cache: a property that deletes the cache when it is set or deleted. A typical example of application is given in the docstring (and in the readme).

For property_deleting_cache, some people may find it strange to have this parameter func whose output is ignored. As a matter of fact, in most use cases, I guess that its code will be pass. I hesitated a bit and I also implemented another syntax option in property_deleting_cache_2. However, I still prefer option 1 because its usage as a decorator is more similar to what we use for regular properties and cached properties. Tell me which one you prefer (and just remove the other one)!
In the readme, I suggest replacing the running example about monopoly by a more generic example. This monopoly example seemed quite unnatural to me, and I hope that the new one is more telling, even if it is a bit less funny.
This is my first pull request ever so do not hesitate to tell me if I did something wrong :-). Best,
François

No reaction? :'-(

Bump.


Crash - Date and java.lang.NullPointerException

java.lang.NullPointerException: Attempt to invoke virtual method 'long java.util.Date.getTime()' on a null object reference
I have 2 classes:
'''java
@Table(databaseName = AppDatabase.DB_NAME)
public class Car extends BaseModel {
@Column(columnType = Column.PRIMARY_KEY_AUTO_INCREMENT)
public long _id;

@Column
public String model;

@Column(notNull = false)
public Date manufacturedDate;

}
'''
and
'''java @Table(databaseName = AppDatabase.DB_NAME)
public class Owner extends BaseModel {
@Column(columnType = Column.PRIMARY_KEY_AUTO_INCREMENT)
public long _id;

@Column(columnType = Column.FOREIGN_KEY,
        references = {@ForeignKeyReference(columnType = int.class, columnName = "id_car", foreignColumnName = "_id")})
public Car id_car;

@Column
public String name;

@Column
public Date purchasedDate;

@Column
public Date soldDate;

}'''
for tests:
Car car = new Car();
car.model = "Honda";
car.save(false);
Owner owner = new Owner();
owner.name = "Smith";
owner.id_car = car;
owner.save(false);
Crash happens at "owner.save(false);"

it appears problem is here:

public class DateConverter extends TypeConverter<Long, Date> {

    @Override
    public Long getDBValue(Date model) {
       ** return model.getTime();**
    }

    @Override
    public Date getModelValue(Long data) {
        return new Date(data);
    }
}

I would try (for now) to create a new custom one, and put in a null check inside of getDBValue()

But it is possible that you return null?
I need the null value. ;-)

@Override
    public Long getDBValue(Date model) {
       return model == null? null : model.getTime();
    }

this?
or
this:

@Override
    public Date getModelValue(Long data) {
        return data == null ? null : new Date(data);
    }

both would be fine

yeah that should be expected. Good find, and i will make a bugfix 1.5.2 for it some point later today/tomorrow.

ok thanks.
closing issue

ill keep it open for reference that I need to fix this. thank you

fixed


[Bug] ERROR CODE: 42000

What happened?
My website was installed and working fine few days ago. However today I visit this page again and it says error and I don't know what to do to fix it. Please help me!
I tried opening debug I noticed the problem was reported that PDO error.
And, I tried a fresh install of boxbilling on a brand new site and when I got to the step of declaring the database it stopped there and gave me an error, even though the declared information was correct!
Pictures are attached below!
ERROR
ERROR CODE: 42000
SQLSTATE[42000]: Syntax error or access violation: 1227 Access denied; you need (at least one of) the SUPER, SYSTEM_VARIABLES_ADMIN or SESSION_VARIABLES_ADMIN privilege(s) for this operation
Look for detailed error explanation
Powered by BoxBilling
IMAGE
https://i.postimg.cc/zfyNGLCz/box-2.jpg
https://i.postimg.cc/4dtTpr2j/box1.jpg
https://i.postimg.cc/1zmgCK1W/box3.jpg
BoxBilling Version
v4.22-beta.1
What version of PHP are you running?
PHP 7.4
Additional Notes
Additional notes

It looks like you may not have the required permissions given to the DB user

I have allowed all access rights for this database user.
Before that the website was running and one day it suddenly came up with an error, I don't know where it originated!
https://i.postimg.cc/wBtZBQL1/box6.jpg

MariaDB or MySQL?

@ptnhan91 Would you mind trying the latest release please?

@ptnhan91

I have the same problem, does anyone have a solution?
recently I have transferred a website from my previous hosting provider and before everything worked fine, but after the transfer to new hosting one of the software (Boxbilling) began to give me this error
ERROR CODE: 42000
SQLSTATE[42000]: Syntax error or access violation: 1227 Access denied; you need (at least one of) the SUPER, SYSTEM_VARIABLES_ADMIN or SESSION_VARIABLES_ADMIN privilege(s) for this operation
the created user of database has all the privileges and all the permissions, but it still gives me that error
it seems that there is some kind of problem with the version or configuration of mySql
i dont know
does anyone have a solution?

fix will be published with the next release.
meanwhile, you can also patch your existing installation: https://github.com/boxbilling/boxbilling/issues/1181#issuecomment-1026900063


add queryString to snake_case when using the fallback REST Method.

I'm using gapic-generator-typescript to generate client-side REST fallback methods from protobuf.
which internally depends on gax-nodejs.
when requesting "Post" method with body, it works fine. but when i use "Get" method with query string
(to support pagination features like page_size, page_token), it sends camelCased query string.
https://my-domain.com/api/v1/taskGroups/-/tasks?pageSize=10

so when i checked implemented code on this module, it works like this.
in comment, it says "use camel case for query string".
// transcoding.ts
export function transcode(
  request: JSONObject,
  parsedOptions: ParsedOptionsType,
  requestFields?: {[k: string]: Field}
): TranscodedRequest | undefined {
...
const queryStringObject = deepCopy(request); // use camel case for query string
...
const queryStringComponents =
        buildQueryStringComponents(queryStringObject);
const queryString = queryStringComponents.join('&');
...
}

I'm wondering why gax-nodejs formats query string as "camelCase". because in google aip examples,
it seems like query string would be "snake_case". (https://google.aip.dev/127)
// The user-specified ID for the book.
// When using HTTP/JSON, this field is populated based on a query string
// argument, such as `?book_id=foo`. This is the fallback for fields that
// are not included in either the URI or the body.
string book_id = 3;

If you have any ideas of supporting snake_case in queryString?
(By the way, i forked this repository and use camelToSnakeCase Method to make query string snake _case)

[Additional Comment]
It seems like Google pub/sub GET API is using camelCase for queryString 🤔
https://cloud.google.com/pubsub/docs/reference/rest/v1/projects.topics.subscriptions/list

Hi @sckimynwa, gax-nodejs explicitly changes snake case query string paramaters to camel case. However, you're right the AIP comments are misleading:
  // The user-specified ID for the book.
  // When using HTTP/JSON, this field is populated based on a query string
  // argument, such as `?book_id=foo`. This is the fallback for fields that
  // are not included in either the URI or the body.

We've created a PR to update the documentation. Thanks for submitting the bug!


youtube-dl cookie problem

Hello
I am just a basic linux CL user.
I have been using youtube-dl for a long time, thank you guys for this great piece of script.
I have now tried to use youtube-dl with cookies.
I nee dto simulate a different country for youtube download. So far I have used other scripts to find complete URL and then I used wget with --header option to download it. It was cumbersome though. Then I found out youtube-dl allows using cookie file.
So I have this cookie file (cookie.txt) which has content: VISITOR_INFO1_LIVE=kVOjAYmlXSE
I run: youtube.dl --cookies cookie.txt http://www.youtube.com/videourl
but i get error "ERROR: unable to open cookie file"
I tried chmod 777 for cookie.txt, I tried putting a full path to the cookie.txt file, copying cookie.txt to /usr/bin
trying everything and I always get error unable to open cookie file.
What am I doing wrong?
Thank you,
George

Hi George, sorry for the late answer, but here it goes: Like any other command, youtube-dl expects filenames to be relative to the current working directory or absolute. To clarify, if you're currently in the directory /home/george/ytdownloads, and your cookie.txt is in /home/george/Desktop/cookie.txt, the following will work:
youtube-dl ../Desktop/cookie.txt videourl # Relative URL

youtube-dl /home/george/Desktop/cookie.txt videourl # Absolute URL

youtube-dl ~/Desktop/cookie.txt videourl # Absolute URL with substitute for HOME

cd ../Desktop # change the current working directory
youtube-dl cookie.txt videourl

By the way 0777 is definitely the wrong mode. You want u+w,a+r, or 0644. I'm closing this issue for now, but I'm anxious to hear whether that worked or not, so feel free to comment. Since I'm currently writing my Master's thesis, the reaction may be delayed, but I promise I'll read and answer everything into it eventually.


[System Request] Tormenta20

Could you make this work on Tormenta20? I think it's based on the code of D&D, if it helps. Thanks in advance!

Added in v1.1.2


Trying to fix dependabot

Codecov Report

Merging #40 (3f7a50d) into main (dde28cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   19.04%   19.04%
=======================================
  Files           5        5
  Lines          63       63
=======================================
  Hits           12       12
  Misses         51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde28cc...3f7a50d. Read the comment docs.


Sprint4: Address client feedback and improve features

Please refer to #57 for the change list for this PR.

Tested on both my laptops and device and it works well.


Remove kube-vip docs, point to metallb package docs

Description of changes:
This PR removes kube-vip (and pointers to kube-vip docs) from EKS-A docs. It also points metallb docs to use the new metallb instructions provided with curated packages.

/lgtm
/approve

/retest

/lgtm

/cherry-pick release-0.10


Only fail check-libs on PRs

Issue
https://github.com/canonical/mysql-operator/pull/165#issuecomment-1489127957
Outdated charm libs block release

Wouldn't updating the mysql libs make check-lib fail the PR? IIRC they are counted as local changes until the PR is merged and the release workflow publishes them.


Use uname -m instead of arch as latter isn't available everywhere

In the make-postgresql.sh script, the system architecture is queried by arch. However, that command isn't present by default on a lot of systems (for example, Arch Linux). Since uname is already used elsewhere in the script, it is also presumed to exist, so favor uname -m, which provides the same functionality, so that the script completed successfully on a broader set of OSes, without expecting additional superfluous dependencies.

Thank you.  Backported to patch.


Added get_open_scenes_roots to Editor Interface API

Original get_open_scenes function provided by Godot is quite limited as it only returns a string array containing the names of opened scenes. This feature is necessary for situations where accessing all opened scenes in depth is required and it is also essential for the Jenova Framework Hot-Reloading feature.
This commit includes :

Changes to the Editor Interface API (editor_interface.h and editor_interface.cpp)
Updates to the Editor Interface documentation (EditorInterface.xml)

We're discussing this internally, would you be willing to also send this PR to Godot as well, to see what their maintainers say about it and see if they demand fixes?

@SkogiB It's approved and it's on 4.4 milestone. This change is simple and basically replicated from get_open_scenes.

@SkogiB It's approved and it's on 4.4 milestone. This change is simple and basically replicated from get_open_scenes.

Oh nice, ok. So basically Spartan wants to minimize merge conflicts and what not by preferring to let Godot merge PRs and then we pull them down to us, when it looks like we have good odds of Godot doing so in a timely manner. https://github.com/godotengine/godot/pull/97838 This is the PR correct?

Any merging into master will wait until it is believed that it will not be merged to a 4.4 release, for 4.3 there now is #908.

@SkogiB Yes, It's developed in Godot 4.3, I use Godot 4.3 stable as the base for Jenova development for now.

This is the PR correct?

Yes, Cyclone is a friend of mine and I sent him changes and he made the PR request. I used to work on a separate fork but I am no longer maintaining it. It would be nice if Redot come with such compatibility so people interested in framework could use Redot as their distro.
Not that this change is only required for Sakura Hot-Reloading system in Jenova Runtime, The runtime itself works perfectly with any fork of Godot including Redot.

Thanks, one of our members says they have been using Jenova for a month on redot with great success. They were the one who brought your pr to our attention. Your project looks great.

@SkogiB Yes, It's developed in Godot 4.3, I use Godot 4.3 stable as the base for Jenova development for now.

This is the PR correct?

Yes, Cyclone is a friend of mine and I sent him changes and he made the PR request. I used to work on a separate fork but I am no longer maintaining it. It would be nice if Redot come with such compatibility so people interested in framework could use Redot as their distro.
Not that this change is only required for Sakura Hot-Reloading system in Jenova Runtime, The runtime itself works perfectly with any fork of Godot including Redot.

Awesome, I'm glad you sent it to us. Always happy to see more interest from guys making plugins and what not. We'll be doing it on our 4.3 and then hopefully Godot will get it in 4.4 so it comes down to us

Closed by #908


Labeled epoch line ticks in static plotters

💡 Feature request
Static plotters are a great feature, especially for generating visual material which can be used for scientific articles, were no interactive plots or animation can be included. When plotting several orbits and trajectories, adverting the dynamics being represented by the plot can be a tedious task, even if using different colors and labels.
This feature request proposes to include line ticks within the plotted orbit paths indicating the epoch value for which the orbiting body will occupy that position along its orbit. As an example, see the image below these lines:

Line ticks indicate here the year of passage. For example, it is more easy to spot that Pioneer 10 made a Jupiter flyby by the end of 1973, as the line is close to the '74 tick. From Wikipedia article, the real date was December 3, 1973.
📝 Resources
This tutorial from scipython blog might be useful.

Blocking this on gh-1544.

I'm thinking of implementing this and have the location figured out. What's the best way to incorporate the LineTicks repo? It isn't setup on PyPI or conda or distutils: https://github.com/xnx/lineticks
@jorgepiloto @astrojuanlu

As discussed in the chat, it's okay to copy-paste lineticks in poliastro (remember to include the license on top)


Alternative for "if" chaining

What is the alternative to
{
"if": [
conditional,
then,
conditional2,
then2,
...,
else
]
}
Thanks,

Hey @rockus123,
I still need to update the documentation on the website and set up CI for making that easy;
See: https://github.com/TotalTechGeek/json-logic-engine/issues/30
This behavior is fully supported in JSON-Logic-Engine. However, if it wasn't, you'd nest the if statement logic.


Nothing happens on click on getPictures()

Hi there,
I followed the several tutorials and tried to implement an imagepicker. Unfortunately I was not yet successful.
i.e.: https://www.positronx.io/ionic-angular-image-picker-integration-tutorial/
I always ended up with an app where nothing happens on 'getPictures' not even an error message.
config.xml:
<plugin name="cordova-plugin-telerik-imagepicker" spec="https://github.com/Telerik-Verified-Plugins/ImagePicker.git">         <variable name="PHOTO_LIBRARY_USAGE_DESCRIPTION" value="your usage message" />         <variable name="ANDROID_SUPPORT_V7_VERSION" value="27.+" />     </plugin>
package.json:
"@ionic/angular": "^6.0.0", "@ionic-native/core": "^5.36.0", "@ionic-native/image-picker": "^5.36.0",
in app.module I added the image picker in the provider section.
This is my click action:
this.imagePicker.getPictures(this.options).then((res) => {       console.log(res);       for (let i = 0; i < res.length; i++) {         this.imageObj.push("data:image/jpeg;base64," + res[i]);       }     }, (error) => {       console.log(error);       alert(error);     });
I am using a real android device with android 11
and an emulator with SDK 30.
Any help is highly appreciated!
Thanks

This happened to me too.
package.json:
{ "@ionic/angular": "^4.0.0","@ionic-native/core": "^5.36.0","@ionic-native/image-picker": "^5.36.0","cordova-plugin-telerik-imagepicker": "^2.3.6",}

Did you manage to figure out the reason, i just walked into the same issue...
on the console log it says
Image URI: O
Image URI: K
But nothing is happening....


Invalid apiVersion

The following error is displayed when trying to perform a terraform plan.
Error: Kubernetes cluster unreachable: exec plugin: invalid apiVersion "client.authentication.k8s.io/v1alpha1"
Searching for the error and deleting helm elements, it was found that the helm provider used the api
client.authentication.k8s.io/v1alpha1
As the helm provider version was not fixed, we updated to the latest version and stopped using that api.

Fixed on https://github.com/nimbux911/terraform-aws-eks/releases/tag/v3.1.5 , thanks !


Per monitor DPI Awareness causes issues with touch and pen input

On a Surface Pro 2 when I use [assembly: DisableDpiAwareness] it causes an issue where touch and stylus input has a large offset to the bottom right. This causes trouble when trying to manipulate onscreen controls such as a button click without a mouse (which works fine).

I managed to resolve this issue:
The problem arose for me when creating the startup window from a custom Startup method in App.xaml.cs. instead of using StartupUri in App.xaml. This caused the startup window (but not any windows created from this window) to interpret touch coordinates wrong.
The problem seems to be that ModernUIHelper.TrySetPerMonitorDpiAware is called to "late" during application startup (called in the DpiAwareWindow constructor). Manually calling it during OnStartup in App.xaml.cs does not help either.
Looking at the documentation for SetProcessDpiAwareness (the winapi function called by the helper) the following is found:

You must call this API before you call any APIs that depend on the dpi awareness.

My guess is that this constraint is violated when calling the function from OnStartup or a custom startup.
The fix is simple: The first thing the auto-generated wpf main function does is to create the App object, so creating a constructor and calling the helper function make everything work:
public partial class App : Application
{
    public App()
    {
        ModernUIHelper.TrySetPerMonitorDpiAware();
    }
}

I'd be happy to provide a PR for this issue, but I don't know how to fit it in the scope of this library.


fixed typeo

There was a typo in the spelling of "self" in one of the methods. The other changes are because of my linter.

Thanks for the fix @jdg589


Strategies and Accelerator teardown logic clean up

Proposed refactor
After #11022 Move accelerator to strategies, the teardown logic can be simplified and cleaned up a bit.
Motivation
Reduce redundant code and make code more clean
Pitch
In ddp, ddp_spawning and hovorod plugins, teardown() all has device specific logic like:
https://github.com/four4fish/pytorch-lightning/blob/move-accelerator/pytorch_lightning/plugins/training_type/ddp.py#L507-L511
with accelerator moved into strategy, device related teardown should move to X_accelerator
class GPUAccelerator()
        def teardown(self):
               # self.lightning_module.cpu()  suggested by @ananthsub module movement should be handled by strategies
               torch.cuda.empty_cache()

Some teardown() logic are shared between different strategy and same device type, like single_tpu and tpu_spawn has the same teardown() logic:
https://github.com/four4fish/pytorch-lightning/blob/move-accelerator/pytorch_lightning/plugins/training_type/single_tpu.py#L90-L92
we can move it to TPUAccelerator
class TPUAccelerator()
          def teardown(self) -> None:
                 os.environ.pop("PT_XLA_DEBUG", None)

Additional context

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @justusschock @awaelchli @akihironitta @kaushikb11 @ananthsub

As discussed in other places before, I agree with this. The strategy calls into accelerator.teardown() which handles device specific teardown. I am also working on teardown related things, e.g., #10990, happy to take this one or otherwise ping me for review <3

As discussed in other places before, I agree with this. The strategy calls into accelerator.teardown() which handles device specific teardown. I am also working on teardown related things, e.g., #10990, happy to help with this one or otherwise ping me for review <3

Oh Awesome, you already work on the similar things. Will assign to you then :) Happy to review when it's done ~~

@four4fish I don't understand the proposal for the GPU accelerator

The accelerator does not have a reference to the LightningModule.
We explicitly made teardown control the device movement logic to accommodate parallelization strategies like FSDP: #7579

If the proposal is for the GPU accelerator to call torch.cuda.empty_cache() in teardown that's perfectly reasonable. But the accelerator should not control the device movement - that should be determined by the strategy

@ananthsub yeah make sense, the self.lightning_module.cpu() should definitely in strategy not accelerator. I saw it was user self.on_gpu() check, so suggested move to accelerator. But you are right, module/model movement logic should be in strategy.  (will update the proposal)
Current fsdp has lightning_module.cpu() logic too, but we should revisit these. I think YIfu find out that ligtning_module.cpu() cause OOM for both DDP and FSDP. I started #10415 but it was won't fix.

I believe this is finished

I think YIfu find out that ligtning_module.cpu() cause OOM for both DDP and FSDP.
@four4fish Could you please give a reference/link to the OOM error ?
I recently had an OOM error because of constantly calling teardown method. My pl version is 2.0.3


Add Yarn 🚀

Great! We probably also need to remove npm scripts from package.json file so Heroku can switch to yarn.

heroku will use yarn if yarn.lock file is present. npm script should not be an issue.


Introducing reduceProps functionality replacing inject option

react-jss had one option called 'inject' which was used to whitelist properties injected by injectSheet to the child component:
// Only `classes` prop will be passed by the ReactJSS HOC now. No `sheet` or `theme`.
const Button = injectSheet(styles, {inject: ['classes', 'sheet']})(
  ({classes}) => <button>My button</button>
)

However, if we want to inject only some part
of theme as prop there is no way. So adding one more key to inject option to give
the flexibility to inject only part of theme.
So lets take an example component where we are consuming a property 'height' and we want to provide flexibility where property can directly be passed to the component or at a global level as part of theme so that all component instances will get the same value for that property.
const Example = props => {
const height = props.height || props.theme.ButtonBase.height; //give priority to props.height
//as it is passed specific to this instance
  return <div> value of height is {height} </div>;
};

While this works, there are two problems with this approach:

Entire theme object is passed to the component which might be huge and the component required
only few of the properties.
For each of the property that we are allowing to be defined in theme, we will end up writing code
like:

props.height || props.theme.ButtonBase.height

which makes the code look ugly and difficult to maintain.
With this change, we replace inject option with another option called 'reduceProps' whose value should be a function that should return the props to be injected.
By providing the provision to inject only part of theme as prop to the component, we solve
both of the above problems. Only required properties will be injected making props
object small.
Secondly, for each property  we just need to consume it like:
props.height

and createHoc takes care of overriding theme passed prop if prop is passed to component
instance and it makes the code look independent of theme and easy to maintain.
Sample Usage
const styles = {
color: 'red'
}
const Example = props => {
  return <div className={props.classes.hello}> Hello </div>;
};
const reduceProps = (props) => {
   const {theme, classes, sheet, ...rest} = props
    return {theme, classes, ...rest}
 }
export injectSheet(styles, {reduceProps})(Example)

So, with this change user can write any function and decide what properties should go to the child component. Not just for whitelisting some properties like theme, classes, sheet. But we can even whitelist some properties within these objects:
const styles = {
color: 'red'
}
const reduceProps = (props) => {
   const {theme, classes, sheet, ...rest} = props
    return {classes, ...theme.ButtonBase, ...rest}
 }
const Example = props => {
  const height = props.height;
  return <div> value of height is {height} </div>;
};
export injectSheet(styles, {reduceProps })(Example)
//and if we render this Example component wrapped with ThemeProvider:
<ThemeProvider theme={{color: 'blue', ButtonBase: {height: 10, width:20}}}><Example /> </ThemeProvider>
//height and width will be injected to props of Example
//Output will be: value of height is 10

reduceProps function can also be set a global level by passing a prop to the JssProvider:
const styles = {
color: 'red'
}
//only thene and classes will be injected
const reduceProps = (props) => {
   const {theme, classes, sheet, ...rest} = props
    return {classes, ...theme.ButtonBase, ...rest}
 }
const Example = props => {
  const height = props.height;
  return <div> value of height is {height} </div>;
};
export injectSheet(styles)(Example)
//and if we render this Example component wrapped with JssProvider:
<JssProvider reduceProps={reduceProps}><ThemeProvider theme={{color: 'blue', ButtonBase: {height: 10, width:20}}}><Example /> </ThemeProvider></JssProvider>
//height and width will be injected to props of Example
//Output will be: value of height is 10

Sorry for taking so long, I will try to get back to this soon.

@yash-bagadia this repo was moved to https://github.com/cssinjs/jss/tree/master/packages/react-jss
Please recreate your PR if you want this feature.


better cross domain errors

Given a cross domain request:
request({url: "http://pizza.com/api"}, function(e,r,b) {
  console.log(e,r,b)
})

e and b are null
request({url: "http://pizza.com/api", json:true}, function(e,r,b) {
  console.log(e,r,b)
})

e is a JSON parse syntax error and b is null
Would it be possible to detect and return an error about the single origin policy?

I hit this bug yesterday rewriting the Iris Couch signup. You're on Chrome, right? If you check your console you should see a cross-origin error. And r.body will be "". I didn't notice what r.statusCode and others were.
I prefer to get between the programmer and the XHR object as little as possible (basically just enough to follow the request API) but in this case I'd like to make it an error. Maybe it could have a .cross_origin field so you could distinguish that error from other kinds.
Another thing I need to do is check that jQuery cors flag and see exactly impact that has to the underlying XHR object.
The final thing to to to close this bug is identify how the other browsers handle a CORS failure and at least unify that for the browser-request user.


Create a connection as "Scheduled" but after creation, build mode is "Manual"

Create a reservation with the build mode as the default "Scheduled".
After the reservation is created, invoke Details for that reservation and see that the build mode is now "Manual", with the control "Set build mode to Scheduled" available.  Wait until the reservation start time, and the connection is not automatically built, it indeed needs to be built explicitly by a user.
Observed on oscars-backend 1.0.8.

actually a frontend issue; closing this


Final tidying up before 17.06 release

Some housekeeping, and also adding info about the new testing repository.
cc/ @andrewhsu

There's one commit coming still. I need to update the upstream references to pull from docker/docker-ce.

OK, the upstream fetch script has been updated and the 1.30 API has been added to the TOC. I think this is ready. You'll want to build it locally with docker build and test the local build to get a true idea. It looks good to me. I did file https://github.com/docker/cli/pull/241, and we will get some spurious Liquid errors until it's cherry-picked into 17.06.


Make password validation error on startup more visible

When the SA_PASSWORD does not pass the password complexity checks, the container will fail to start.
Example:
$ docker run -e ACCEPT_EULA=Y -e SA_PASSWORD=abc -p 1433:1433 -it microsoft/mssql-server-linux
Configuring Microsoft(R) SQL Server(R)...
Microsoft(R) SQL Server(R) setup failed with error code 1. Please check the setup log in /var/opt/mssql/log for more information.

It takes a big of digging to figure out how to start the bash shell via docker exec in order to actually see what is in /var/opt/mssql/log/setup*.log. It would be nice to show the error on in docker's default output.
2017-03-11 00:47:10.07 spid17s     Password validation failed. The password does not meet SQL Server password policy requirements because it is not complex enough. The p
assword must be at least 8 characters long and contain characters from three of the following five sets: Uppercase letters, Lowercase letters, Base 10 digits, Non-Alphan
umeric characters, or unicode characters that are categorized as alphabetic characters, but are not uppercase or lowercase.
2017-03-11 00:47:10.07 spid17s     An error occurred while setting the server administrator (SA) password: error 33064, severity 16, state 2.

Agreed.  We have this in the backlog already.  Should happen in the next couple of releases.  Not just for this but in general we need to surface issues better in the output.

This is fixed and will be in CTP 2.1 coming out very soon...

How would you use that with docker-compose
That is what i've got now:

  sqlserver:
    container_name: 'sqlserver'
    image: microsoft/mssql-server-linux:2017-CU1
    environment:
      - ACCEPT_EULA=Y
      - MSSQL_PID=Developer
      - SA_PASSWORD=%^!ndhHGxcC
      - MSSQL_DB=mydb (was expected db to be created)
      - MSSQL_USER=me
      - MSSQL_PASSWORD=1!qazxcV
    ports:
      - "1433:1433"
    networks:
      - app-network

+1


Lazy load from API

I'm using this library and, thank you, it's awesome!
Still, I've got a problem. I can't make it to work with an API which loads the images 5 by 5 at a time. I've tried to make the request in the noMore function (which is called when there are no more cards to display), but when the request is finished and the data is loaded again, the SwipeCards view becomes white/ invisible.
Is there any other recommended way to accomplish this?

@razvanpaul did you find a solution for this? I'm trying to achieve the same

+1

@razvanpaul  could you send me an example on how you load your cards via api?

+1


Handling existing connections

Hi,
I have following problem: In my application, I want to connect to a BLE device.
I have a list with devices and if a user clicks a list item I create a device and connect to it.
In the connect method I listen to the state:
subscriptionHandleState = _currentDevice.state.listen(_handleConnection);

And in handleConnection I start discovering (and register notifications), handle disconnect, whatever...
My problem:
If a device is still connected and a user clicks another list item I want to disconnect and reconnect to the device (same device or another device).
My disconnect:
await subscriptionHandleState?.cancel();
subscriptionHandleState = null;
await _currentDevice?.disconnect();

I cancel the subscription handler because I dont't want to execute the _handleConnection with the disconnect event (because of it reconnects the current device).
This works fine with iOS. The old connection is canceled and the new connection is started.
But if I try this with Android my _handleConnection is called twice. That means in my situation that I start discovery and register notification twice and that I get some faults while reading values.
It works if I make a delay after my disconnect procedure
 await Future.delayed(const Duration(milliseconds: 1200), () {});

Hi, same issue.
I'm looking into :
_deviceConnectStream = _bluetoothDevice.connect(timeout: Duration(seconds: _CONN_TIMEOUT_S)).timeout(Duration(seconds: _CONN_TIMEOUT_S)).asStream().listen((_){});
I'll let you know how that works out.

Okay this seems to work by giving you a handle to cancel the listener on the connect. Let me know if you need more info.
Maybe the library should be modified to return a StreamSubscription from the .connect method.


fix(files): File rework

What this PR does 📖

Update files page stuff

Remove the whole folderstack thing and instead update the files directly from warp
Fix some store subscription things. e.g. not unsubscribing (change to $: syntax)
Fix drag drop into folder triggering for everyfile instead of just target file moving all files into the target folder
Fix drag into files instead of folder
Fix renaming sometimes breaking

Which issue(s) this PR fixes 🔨

Resolve #428

Found one more bug on this branch

Create a new folder lets say "test"
Create another folder lets say "test2"
Enter to "test" folder and nothing is shown on tree and also you can no longer upload files

https://github.com/user-attachments/assets/5e1afab2-d40a-4454-bb0b-8f13553b1aec

Found one more bug on this branch

Create a new folder lets say "test"
Create another folder lets say "test2"
Enter to "test" folder and nothing is shown on tree and also you can no longer upload files

Grabacion.de.pantalla.2024-09-02.a.la.s.2.19.40.p.m.mov

regarding the file tree thats also how it works in dev. it only shows the file tree from current downwards
regarding uploading files... strange. that still works for me. can you show the logs?

Found one more bug on this branch

Create a new folder lets say "test"
Create another folder lets say "test2"
Enter to "test" folder and nothing is shown on tree and also you can no longer upload files

Grabacion.de.pantalla.2024-09-02.a.la.s.2.19.40.p.m.mov

regarding the file tree thats also how it works in dev. it only shows the file tree from current downwards. (though current folder should also show which it does for me) regarding uploading files... strange. that still works for me. can you show the logs?

Hey @Flemmli97 Revalidated now with latest commits from branch and I cannot see the issue now. Will add a ticket for fixing the tree folder structure in dev.

Hey  @Flemmli97 I noticed one bug being introduced on this branch, user is able to create folders with empty name. Thats the reason this test is failing - F8 - If user tries to create a folder with empty name or press Esc while name input is displayed, folder is not created

fixed


Citrate Synthase Is Not Reversible In Humans

MAR04145: CoA [m] + H+ [m] + citrate [m] ⇔ H2O [m] + OAA [m] + acetyl-CoA [m], GPR: ENSG00000062485 (citrate synthase) should be irreversible, since the human citrate synthase enzyme (and apparently most organisms' citrate synthases) only catalyze the forward reaction (source focused on the human enzyme specifically is page 130 of this book)

Nice catch! Please go ahead and make the change

Resolved by #676


Zero valued registers not published to MQTT

Zero valued registers not published to MQTT

Fixed in https://github.com/mbs38/spicierModbus2mqtt