Unexpected duplicate nested components

When I mount() some components, they end up having nested duplicates.
For example,
import React from 'react';
import {
	View,
	Text,
	TouchableOpacity,
	ActivityIndicator,
} from 'react-native';

import { mount } from 'enzyme';

describe('component', () => {
	it('renders', () => {
		console.log(mount(<View />).debug());
	});
});

Here's what I see in the log:
  console.log /__tests__/test.js:44
    <View>
      <View />
    </View>

I see this behavior with View, Text, ActivityIndicator, but not with TouchableOpacity or custom components. Finding components becomes much more complicated.
What might be going on here? Is this behavior expected or is it a bug?

Sorry to hear that you are having trouble @andriichernenko.  I tried running your code and got a different result.  Rather than a nested View I got a nested component with the name react-native-mock.  This is expected with the current implementation.
I also tried running the same code for TouchableOpacity and received a similar result to the one  I received for View. Below is the code I ran and the result I got.
Code:
import React from 'react';
import { View, TouchableOpacity } from 'react-native';
import { mount } from 'enzyme';

describe('View', () => {
  it('renders', () => {
    console.log('\nView\n');
    console.log(mount(<View />).debug());
    console.log('\nTouchableOpacity\n');
    console.log(mount(<TouchableOpacity />).debug());
  });
});

Console Output:
View

<View>
  <react-native-mock />
</View>

TouchableOpacity

<TouchableOpacity>
  <react-native-mock />
</TouchableOpacity>

If the structure of the the mocked views is causing trouble for you, I'm happy to explore mocking in a different shape.  Before exploring options on that front I think it's best to get to the bottom of why we are getting different outputs.
It's possible that differences in our test setups or other project level factors could cause a difference in our results.  Would you mind running the code I included in your project and letting me know what console output you get?  Thanks!

I have the same problem using mount() from enzyme. Using .debug() I see that the component structure shows nested duplicates. My setup:
react: 15.4.2
enzyme: 2.7.1
jest: 18.1.0
node: v7.8.0
Did someone find a solution?

Ok, in my case I found the reason was some mocking of react components with jest mocking functions before tests running. So I guess this might be a problem of individual test setup. Solved for me.

Glad to hear you fixed your issue @Michbeckable.
I'm not using Jest at all while trying to reproduce this, and this package is currently being maintained for use with Enzyme only.  That said, if there are any changes that would make Jest users' lives easier, we are happy to take a look at them.  Let us know if you have any further issues!


cirq.Sampler program argument should be AbstractCircuit

I'm getting type errors in pycharm when I'm trying to run a FrozenCircuit. I think there should be no downside to switching the type annotation to AbstractCircuit, of which both Circuit and FrozenCircuit derive?

Agreed; there are probably quite a lot of places where we could change Circuit type annotations to AbstractCircuit instead, but Sampler is certainly one.

Hey, I am new to Cirq. I just created the above PR for the issue, could you please check?

This is fixed thanks to @banrovegrie . I changed the complexity label lol since it turned out to be a pretty far-reaching change


⚠ Bofrost.be has degraded performance

In e8a62e7, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2845 ms

Resolved: Bofrost.be performance has improved in 0b1213d.


HTTPCLIENT-2222: fixed ProtocolNegotiationException

Aligned with the implementation of the latest release to get rid of
ProtocolNegotiationException:
https://github.com/apache/httpcomponents-core/blob/rel/v5.2-beta2/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/ClientH2PrefaceHandler.java#L142
cc @ok2c

@gaojieliu These are reasonable changes, though, I thought they were only relevant to protocol negotiators in master that have been completely rewritten in the course of 5.2 development.

Hi @ok2c
Thanks for the update, and enjoy your vacation!

Hi @garydgregory
Thank a lot, and let me give it a try!


FancyZones Editor displays incorrectly in multi monitors scenario when monitors are not in order

Microsoft PowerToys version
"0.35.0"
Running as admin
Yes
Area(s) with issue?
FancyZones Editor
Other Software
No response
Steps to reproduce
Go into display settings
Rearrange display so monitor number 2 is on the left of monitor number 1
Start PowerToys
Open FancyZones Editor
The editor is shifted unextectedly to the left and editing operations have a mismatch between the mouse and the display
✔ Expected Behavior
The mouse and display match
You can fix the error by swapping the monitors  in Windows settings / display settings by swapping the monitors so they start with 1 on the left
❌ Actual Behavior
The display is shunted to the left
When creating or editing a custom layout, the mouse and the on screen visuals do not align
With the setting "Allow zones to span across all monitors" I am seeing some undesired layout issues.
I was able to do some digging and the issue is around the fact that if monitor 1 is on the right, the overlay of the FancyZones Editor is incorrectly placed on the screen.

The result on screen looks like this - notice the overlay does not cover some apps on the right hand side of the dual monitor system:

Simply reversing monitor 1&2 in settings makes this correct:

In the example below, my mouse was just below cancel, but the grid bar is significantly further to the left (1/4 of 1 monitor width to the left).
Both monitors have the same DPI and scaling settings:

Upon further investigation, it is not about the monitor ordering, but if the primary monitor is further right than other monitors.  I can repro the issue by having the monitors as number 1 & 2 in that order, but make the right monitor the primary monitor and the same issue happens.
I can also work around the issue of the grid bar in the wrong place by changing my scaling factor to 100%.  This suggests that the scaling factor is part of the problem for the grid bar.

Thanks for reporting! Can you please verify if this issue is still present in the latest version of the PowerToys?

Actually, there are two different issues described here.
Rearrange displays issue is related to https://github.com/microsoft/PowerToys/issues/8104.
The second issue is improper layout displaying with a 125% scaling on both monitors.

does this issue still happen with v0.73.0? /needinfo


Storing portals in a minecraft compatible manner

When removing the mod, every portal is unlinked and reactivating a portal connects to a new location. Thus it seems you don't use the minecraft algorithm of determining the portal to link to or to spawn. It would be nice if you could change the algorithm to the minecraft way (because we had floating portals several times aswell)

There are invisible blocks filling portal area. Maybe these blocks in the other dimension are not deleted when removing the mod. If the portal filling block still remains, the obsidian frame will be regarded as empty and will not be linked.
And I will decrease the possibility of generating floating portal.

If you remove the mod you should go to nether and the portal filling blocks should vanish.

If you remove the mod you should go to nether and the portal filling blocks should vanish.

Yep, though as the chunks of the other portals weren't loaded in the other dimension, I have to go through every portal to remove these blocks. And since you use another placing mechanic than vanilla, it places the portal not next to it but rather radomly far away. Every time you use a portal the first time when the chunk in the other dimension hasn't been loaded.
As an idea:
a) Change vanilla portal blocks such that when the mod is removed every portal is actual vanilla portal block
b) only save the portal blocks as vanilla portals and replace them again when loading
That way the saves will always contain valid portals

Order of activation: Left one, right one

Left Entry:

Right Entry:

Watch the huge difference between coordinates. Shouldn't they connect to the same portal in nether?
I found out, that when swapping the order in which I activate the portals, the endpoints in nether are swapped too (now the nether fortress is left):

Update: activating the second one produces that error:
[16:17:48] [Server thread/ERROR]: [Portal] Cannot find the reverse portal. Nether portal may not be removed normally.

It will search for big lava lake, this could make portal generate far from its corresponding position.
This mod is not intended to work when the mod was removed and added again. It's hard to store information without this mod installed.
The "Cannot find the reverse portal" is an issue and I am trying to fix it.

Btw why does it look for a big lava lake? Especially where vanilla minecraft rather tries to prevent spawning midair above a lava lake :/


Extract affected column name on column related errors with PlanetScale/Vitess instead of (not available)

Bug description
While using Prisma with Planetscale, using the Prisma Client to make a request to the database. if a column that is declared in the Prisma and in the request payload is not available in the database, Prisma throws and error but with meta: { column: '(not available)'
How to reproduce
I have created a small repository to reproduce the issue with a readme
repository link
the steps are:

create a Prisma project with a planetscale database
make sure schema.prisma and database are out of sync (columns exist in schema but not in database)
attempt to make a request with non existent columns
receive an error with meta: { column: '(not available)' }

Expected behavior
The expected output should include the column name. in fact if we try with a non-planetscale database the column name will appear
Prisma information
Included in reproduction
Environment & setup
OS: Windows
Database: Planetscale
Node.js version: v16.13.1
Prisma Version
4.1.0 and also tried 3.15.0

The error message from Vitess/PlanetScale are slightly different, and right now we do not support that format to parse the affected field out. We could add that parsing to make this go away.

In this related issue about this error message, @Jolg42 dug into our codebase to surface which code path is responsible for these suboptimal error messages: https://github.com/prisma/prisma/issues/10829#issuecomment-1362788473
If anyone wants to look into this, that is where one should start to understand how PlanetScale/Vitess are different and if/how the parsing of the error messages can/has to be adapted to make it work there as well.

2 temporary PRs that show where this code currently affects our tests: https://github.com/prisma/prisma/pull/19753 + https://github.com/prisma/prisma-engines/pull/4043
And an internal conversation: https://prisma-company.slack.com/archives/C058VM009HT/p1686746923698139

Potential next step:

Take reproduction provided above, and run query both against a "normal" MySQL and against Vitess directly (not via Prisma), share both full error messages here. Parsing logic can currently only handle the MySQL one, and needs to be adapted for Vitess.

Looking forward to this one. Would be extremely helpful


No Additional Downloads

As a user, I want to be able to receive information without downloading anything else.

This is a web app, only a browser is needed.


jack-example-tools: init at 4

Description of changes
jack2 dropped its tools from the main package recently. they now live here. examples are included too as previously, and unlike previously we also include zalsa plugins. they're tiny though, adding them won't hurt anything.
darwin is marked as broken because we have no clue where to even start with darwin, not because it's actually known to not work.
fixes  #253188
@cillianderoiste @matthiasbeyer  @risicle
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 253299 run on x86_64-linux 1

2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test

1 package built:

jack-example-tools

Quite a huge number of rebuilds... should this go to staging?

That was just initially as you can see above ofborg dropped the labels again. It also confused me the first time I looked at it.

cc @NixOS/darwin-maintainers

@pennae, did you not search for existing PRs before opening this?
I had already created #243378 months before. It makes me wonder what's the point in putting in hours of effort building and testing if the PR will just be ignored.

While having people do their due diligence on existing work prior to embarking on a PR seems like the best solution, I wonder if there's any room here for another bot that might search existing open PRs and reply with a list of them. Unfortunately I expect people are probably not opening PRs until they have already put in significant effort.

Yes, sorry for the harsh words @pennae. It's not your fault.
I believe you are correct that the PR review tools on github are not fit for task.


Fix dump/restore of migrations with annotations on them

When we parse the script back, parse it as a migration body, not a
generic block of commands.
Fixes #5151.
Related to this, we drop the DDLStatement enum value for generated_by.
This is because there isn't a good way currently to preserve it across
dumps. We could add
SET generated_by := schema::MigrationGeneratedBy.DevMode to the stored
script, but that cure seems worse than the disease.
There is another potential approach (to both parts of this) that I
might actually prefer, but which has some other downsides: strip SET ... commands from the stored text of migration (and only allow them
at the start of the migration). Then we don't need to do anything
special on the parsing side and can easily carry through whatever
state we want.
The downside is that it's a clear compatability break... but only if
there are any users who are setting message (which isn't documented)
in a migration.
(If there are, and if we care about them, then dump/restore is broken
for them right now and we'll want to cherry-pick this PR to 2.x to let
them dump).

Related to this, we drop the DDLStatement enum value for generated_by.

Sorry, I'm not sure what that means. Do you mean that generated_by is a string now? It looks like tests still use enum.
Or do you mean that generated_by value is just dropped in dump/restore cycle? That would be weird. We can make it a string if that makes it simpler to implement.

We could add SET generated_by := schema::MigrationGeneratedBy.DevMode to the stored script,

It is in the script, currently:
  schema::Migration {
    id: 4c6a2843-c255-11ed-a35c-2193c57f7a29,
    name: 'm1egbemkuo4mkf3tnvmo4blvnwnpyhuhc574pqkud5yqohk446joeq',
    internal: false,
    builtin: false,
    computed_fields: [],
    script: 'SET generated_by := schema::MigrationGeneratedBy.DevMode;
CREATE TYPE default::TestType;',
    message: {},
    generated_by: DevMode,
  },

Does your change removes that, or am I misunderstanding something?

only allow them at the start of the migration

Fine by me.

The downside is that it's a clear compatability break... but only if there are any users who are setting message

Personally I don't think anybody uses messages so far. We don't even display them anywhere (which probably should be improved eventually) and it's undocumented. But if it's just a matter of cherry-picking this PR, we should probably do it.

Sorry, I forgot to post an update on the PR: Per discussions offline with @elprans, I undid the whole generated_by thing (just straight reverted it) and then started sticking SET generated_by := schema::MigrationGeneratedBy.DevMode;.
I meant "add SET generated_by := schema::MigrationGeneratedBy.DDLStatement" to the stored script, which I have now done


The Excel.Load(excelFile) doesn't use the fluent api

The Excel.Load(excelFile) doesn't use the fluent api, will be fixed when v2.1 released next month

v2.1 had been released


flake.lock: Update nixos-org-configurations

Removes NixOS 22.05 from the search.

The nixpkgs update has to be done separately: https://github.com/NixOS/nixos-search/pull/597

Reduced the scope to nixos-org-configurations.


Failed install 20348

Response 400 Error
https://software-download.microsoft.com/download/sg/Windows_InsiderPreview_SDK_en-us_20348_1.iso

Hi @xiaozhuai - Thanks for the report. I can confirm this link does not work.
Interestingly, Wikipedia still lists 19041 as "Stable release": https://en.wikipedia.org/wiki/Microsoft_Windows_SDK
The download script used by this action contains the following note, although I don't think that matters here since 20348 was released in May 2021:

Note: there is a delay from Windows SDK announcements to availability via the static link

Do you happen to know if there was a change in the static link format/location?

Hi @xiaozhuai - Thanks for the report. I can confirm this link does not work.
Interestingly, Wikipedia still lists 19041 as "Stable release": https://en.wikipedia.org/wiki/Microsoft_Windows_SDK
The download script used by this action contains the following note, although I don't think that matters here since 20348 was released in May 2021:

Note: there is a delay from Windows SDK announcements to availability via the static link

Do you happen to know if there was a change in the static link format/location?

It seems the new link format is something like this:
https://software-download.microsoft.com/download/sg/20348.1.210507-1500.fe_release_WindowsSDK.iso
But I'm not sure if it will always works.
I'm still looking for a workaround to build my repo xiaozhuai/angle_builds


Update DropDuplicateTransformer

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (7b7611a) to head (0047fe2).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #343   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           49        49
  Lines         1305      1304    -1
  Branches        50        50
=========================================
- Hits          1305      1304    -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cancelled Download Instance seen in Downloads Tab, When Save Dialog Dismissed.

Cancelled Download Instance Seen in Download, even if the download save dialog is dismissed.

When the user tries to download a file, the save dialog pops up.
Then, if the user dismiss the save dialog.
There should not be any instance of the file in the downloads section but the file is shown in the downloads tab in cancelled state.

What operating system and which version : MacOS 12.5
Which version of Rocket.Chat (Server) : demo Server
Which version of Rocket.Chat.Electron (Electron/Desktop): latest
Is there any setting relevant changed : No
To Reproduce

Click on the download button of any file.
When the savepath dialog pops up asking for the file path, cancel it.
Now you can see the file you were trying to download in the downloads, in the cancelled state.

Expected behavior
When the savepath dialog is dismissed, no file should exist in the downloads tab of the App.
Screenshots

What happened with the another PR?

What happened with the other PR?

Hey Jean, While I working on the previous PR, I could see that it was continuously failing some tests and during the process, I made a mistake pushing some unnecessary conflicting commits.
Hence, I decided to keep the process clean, ran all the tests in my local machine provided in the GitHub workflow, and hence created a new fresh PR.


Implement API and TP holdings infinite rules

What you should see for assets with OWNERS_HOLDING_INFINITE and ALL_HOLDINGS_INFINITE is that their Holdings won't decrease when they are involved in an offer.


Prep for presentation

We'll be presenting on project findings at the end of the month.
Acceptance Criteria:

[ ] Create PPT document
[ ] Build out presentation outline
[ ] Create presentation
[ ] Pass to project team for feedback

Can this Epic be closed? @jaimiebutton @Dianadec

Hey Patricia, I think so. We did a report a while back on best practices for public reporting of industrial emissions but never presented to the branch. I'm not sure if it's still a priority but it was over a year ago... (the report was fun though if you're ever curious to take a look!)


New line

I can't press Shift+Enter to start a new line.

You can press Control+Enter, or Option+Enter to start a new line.
Shift+Enter, Command+Enter will be supported in the next update.
Thanks for your feedback.


Update mobilenet_v2.py

Removed "
x = layers.ReLU(6., name=prefix + 'expand_relu')(x) "  wrt  "https://github.com/tensorflow/tensorflow/issues/50835"

What's the ImageNet validation set performance of the model (with its pretrained weights) after the change?

@Saduf2019 have you verified this?

Closing due to inactivity, we also aren't sure of the outcome following future testing.  This change wouldn't be checkpoint compatible which makes it difficult to merge.


Tag a new version with SF4 compatibility

I see the code has been updated to support Symfony 4, but it has not been tagged yet.
@Seldaek Could you tag a new version please?

Waiting for the same...

Seems like packagist has new version now https://packagist.org/packages/nelmio/cors-bundle#1.5.4


ClientFunction dependencies can’t be in another file

Are you requesting a feature or reporting a bug?
Bug
What is the current behavior?
ClientFunction code errors with undefined references when injected dependencies are located in a separate file from the ClientFunction itself
What is the expected behavior?
dependencies can be imported from anywhere
How would you reproduce the current behavior (if this is a bug)?
// get-location.ts
export const getLocation = () => window.location;

// get-href.ts
import { getLocation } from './get-location';

const getHref = ClientFunction(() => getLocation().href, {
  dependencies: { getLocation }
});

An error occurred in ClientFunction code:
ReferenceError: get_location_1 is not defined

Specify your

operating system: macOS 10.13.3 Beta
testcafe version: 0.18.6
node.js version: v7.10.0
TypeScript version: 2.6.2

Sorry for a long response. TypeScript compiles the code in the same manner: see the exapmle. So the problem is actual here too.

Ah, I think I understand now. Thanks for explaining. I bet a custom Babel plugin could fix this. If the compilation could be slightly tweaked to output either
var _getLocation = require('./get-location');
 var getHref = ClientFunction(function () {
  // this part will be executed in the browser. But browser's script doesn't have _getLocation definition
  return (0, _getLocation.getLocation)().href;
}, {
  dependencies: { _getLocation: _getLocation }
});

or
var _getLocation = require('./get-location');
 var getHref = ClientFunction(function () {
  // this part will be executed in the browser. But browser's script doesn't have _getLocation definition
  return (0, getLocation)().href;
}, {
  dependencies: { getLocation: _getLocation.getLocation }
});

it would work... I have no experience writing Babel plugins, so not sure how feasible this is, and not sure if something equivalent could be done with TypeScript. Just a thought.


update NumberGuessingApp and add VS-AI mode

Type of change

[ ] Added new project
[x] Bug fix
[x] New features
[x] Enhanced documentation

Changes proposed in this pull request

Use a simple and easy algorithm for better understanding the concepts
Added a feature user can play against computer

Short description :

Rewrite the code and added vs-ai mode
Checklist

[x] The code is Python 3 compatible
[ ] I have added relevant comments in my file to make code understandable
[x] I have added my project in a folder which includes all the necessary files

It's good thanks for your work 👍


Snowflake Connector Snowflake Driver

Hi, this page does not reference the requirement to install the Snowflake ODBC driver? I'm trouble shooting with a colleague and I'm not entirely sure it's still required?
Original posts indicated it was required: https://powerbi.microsoft.com/en-au/blog/power-bi-enables-connectivity-to-snowflake/
If no longer required for current version it'll probably be useful to include a reference to the versions for which it is required.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 35e91b2c-b946-0945-4ef5-6451a1833b5f
Version Independent ID: 730bf023-2cab-5db2-c1fd-d96e8bac4e02
Content: Connect to Snowflake computing warehouse in Power BI Desktop - Power BI
Content Source: powerbi-docs/connect-data/desktop-connect-snowflake.md
Service: powerbi
Sub-service: pbi-data-sources
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for your comment, @antrogers . This issue has been assigned to the doc author for review.

We've updated the article, thanks.


Firefox crashes on wayland with NVIDIA due egl-wayland update and related sync issue

Describe the bug
Firefox crashes on wayland when using an NVIDIA card through egl-wayland. This issue has been partially addressed upstream and on other distributions, some patches are available. Refer to:

https://gitlab.freedesktop.org/mesa/mesa/-/issues/11541
https://gitlab.archlinux.org/archlinux/packaging/packages/firefox/-/issues/7

Steps To Reproduce
Steps to reproduce the behavior:

Launch firefox on wayland with egl-wayland (NVIDIA)
Toggle fullscreen -> crash

Notify maintainers
@edolstra @lovesegfault @mweinelt

Add a :+1: reaction to issues you find important.

firefox-unwrapped> In file included from Unified_cpp_webrender_bindings0.cpp:29:
firefox-unwrapped> /build/firefox-129.0.1/gfx/webrender_bindings/RenderCompositorEGL.cpp:162:13: error: use of undeclared identifier 'MozContainerSurfaceLock'
firefox-unwrapped>   162 |   UniquePtr<MozContainerSurfaceLock> lock;
firefox-unwrapped>       |             ^
firefox-unwrapped> /build/firefox-129.0.1/gfx/webrender_bindings/RenderCompositorEGL.cpp:164:23: error: no member named 'LockSurface' in 'mozilla::widget::GtkCompositorWidget'
firefox-unwrapped>   164 |     lock = gtkWidget->LockSurface();
firefox-unwrapped>       |            ~~~~~~~~~  ^

(fetchpatch {
  name = "nvidia-egl-wayland-compat.patch";
  url = "https://hg.mozilla.org/mozilla-central/raw-rev/eb230ecdf8eb";
  hash = "sha256-IaLltxf5W1WEzxvbi10wphqXVQPtBiLc2zlk38CIiz4=";
})

The patch does not apply on any of the source builds we have. Will have to recheck tomorrow.


Add Clamperl to Random Battles

DeepSeaTooth allows Clamperl to out-damage its evolutions, just like
Pikachu, which is already allowed.

To be honest, this could be a really bad idea from a server load perspective! The re-inclusion of LC/NFE Pokemon into the initial rotation and then weeding out literally all but one in a later check is sub-optimal due to the extra time needed for randomize() to run and iterating through double the amount of Pokemon, most of which will be scrapped.

Clamperl isn't even PU...

Oh, right. I did say that in 23c830562a4754f18ee4eab4cd3068597d2f9c8e, didn't I?


Support deployment annotations

Describe the feature:
It would be very nice, if deployment annotations would be supported
Describe a specific use case for the feature:
We're using Wave to manage deployments in our k8s cluster, which will trigger a Rolling Update, if related Config Maps or Secrets are updated. Unfortunately Wave keeps track of the managed deployments by targeting a specific deployment annotation. Would be super cool, if we could open a small pull request for this behavior :)

Could you please give some feedback, if this is feasible or not - we have to manually restart pods in production, whenever a configuration or secret changes.

@kernkonzentrat so according to https://github.com/pusher/wave/issues/59#issuecomment-526607098, wave will look for the annotations on the Statefulset aswell.
So you should be able to use the existing podannotations support.
Which charts were you looking at using with wave?

@fatmcgav ...thanks for the reply. We're using metricbeat charts from v7.7.1 - I already came across pusher/wave/issues/#59 but podannotations won't work, as they only label the created pods within a deployment/ daemonset...wave only looks at the labels of a deployment/ daemonset / statefulset to support monitoring (at least in my understanding)

@kernkonzentrat Ah, ok...
In that case, and based on the example in the Wave docs, this should be a relatively trivial addition.
Something like adding this additional block:
      annotations:
        {{- range $key, $value := .Values.deploymentAnnotations }}
        {{ $key }}: {{ $value | quote }}
        {{- end }}

after this line: https://github.com/elastic/helm-charts/blob/75263dd4776430d63c2b4cdb1b95be74cb385eaa/metricbeat/templates/deployment.yaml#L10
Also set a default value in values.yml:
# Annotations to apply to the deployment
deploymentAnnotations: {}

And then adding a test to make sure the values are being set correctly. Something similar to https://github.com/elastic/helm-charts/blob/75263dd4776430d63c2b4cdb1b95be74cb385eaa/metricbeat/tests/metricbeat_test.py#L960-L975 should work, just with the correct paths.
If you fancy taking a stab at opening a PR with these changes, we can review and provide feedback as appropriate.

@fatmcgav cool...will open the PR within the next few days 👍

Closing as #713 was merged


support cluster credentials api

The accessProfile API is going to be deprecated not to mention that there's no out of the box RBAC role that permits this API without adding Admin access to the cluster/namespace.
The newer API differentiates between admin and user credentials and is covered by all built in AKS RBAC roles.
HelmDeployV0 and HelmDeployV1 should be migrated to use this newer API to simplify working with AKS.

@microsoft-github-policy-service agree
On Mon, 5 Aug 2024 at 21:48, microsoft-github-policy-service[bot] <
@.***> wrote:

@smiklos https://github.com/smiklos please read the following
Contributor License Agreement(CLA). If you agree with the CLA, please reply
with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of
intellectual property rights to my Submissions and I am not making
Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work
for my employer (or my employer has intellectual property rights in my
Submissions by contract or applicable law). I have permission from my
employer to make Submissions and enter into this Agreement on behalf of my
employer. By signing below, the defined term “You” includes me and my
employer.

@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the
party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its
affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is
effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable
or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft
and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or
distributing code or other content to any
Project, including but not limited to communication on electronic
mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf
of, the Project for the purpose of
discussing and improving that Project, but excluding communication
that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material
Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement
before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now
or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions
is entirely Your original work.
Should You wish to Submit materials that are not Your original work,
You may Submit them separately
to the Project if You (a) retain all copyright and license information
that was in the materials as You
received them, (b) in the description accompanying Your Submission,
include the phrase “Submission
containing materials of a third party:” followed by the names of the
third party and any licenses or other
restrictions of which You are aware, and (c) follow any other
instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include
Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a
contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your
employer has intellectual
property rights in Your Submission by contract or applicable law, You
must secure permission from Your
employer to make the Submission before signing this Agreement. In that
case, the term “You” in this
Agreement will refer to You and the employer collectively. If You
change employers in the future and
desire to Submit additional Submissions for the new employer, then You
agree to sign a new Agreement
and secure permission from the new employer before Submitting those
Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the
Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive,
royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly
display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all
of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the
Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive,
royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or
the combination of the
Submission with the Project to which it was Submitted to make, have
made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the
Project.
Other Rights Reserved. Each party reserves all rights not
expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without
limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are
legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your
original work (except as You may
have disclosed under Section 3). You represent that You have secured
permission from Your employer to
make the Submission in cases where Your Submission is made in the
course of Your work for Your
employer or Your employer has intellectual property rights in Your
Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You
represent and warrant that You
have the necessary authority to bind the listed employer to the
obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless
You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE
WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED
UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO,
ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of
any facts or circumstances of which
You later become aware that would make Your representations in this
Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to
Projects and information about
contributions may be maintained indefinitely and disclosed publicly,
including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the
laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal
courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in
which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County,
Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire
agreement between the parties, and
supersedes any and all prior agreements, understandings or
communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may
be assigned by Microsoft.

—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/azure-pipelines-tasks-common-packages/pull/360#issuecomment-2269793112,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYR27H5DOTKONMT5UNZPDTZP7JHVAVCNFSM6AAAAABMA5MZH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRZG44TGMJRGI
.
You are receiving this because you were mentioned.Message ID:
<microsoft/azure-pipelines-tasks-common-packages/pull/360/c2269793112@
github.com>

Added some tests but as far as I can tell none of the L0-* tests are running under azure-arm-rest package...

@manolerazvan Could please review this?

@starkmsu any chance you could take a look? this Is related to https://github.com/microsoft/azure-pipelines-tasks/issues/16614
I'm trying to add support for the new APIs without removing the old one for now. If this gets merge we can change HElmDeploy and other tasks to use the newer APIs

Thanks for the review! Are we not concerned that the tests are not running for this package?

ZzzZZz


Why is Atlas a requirement ??

Hey,
Is atlas a requirement to run this project?
Regards

Depends, If you are using the vagrant provider you wont need Atlas at all.
At the moment if you are using digitalocean or AWS you will. Although for AWS we have made our AMI public (as well as the Atlas artifact) so you should be able to use that https://atlas.hashicorp.com/capgemini/artifacts/apollo-mesos-ubuntu-14.04-amd64.
Unfortunately digitalocean does not support public images so you won't be able to re-use our artifact there but will need to bake your own at present.
Atlas is used at present for artifacts and provisioning from them and also for consul integration (a la https://www.consul.io/docs/guides/atlas.html). This means when you provision you should get a monitoring dashboard with the health of your consul instances at https://atlas.hashicorp.com/environments.
I'm open to discussion about atlas support and whether we maintain it, drop it or change it. I think in an ideal world we would have the ability to deploy using atlas artifacts but by default that would be turned off and just use AMI / droplet IDs in the terraform configuration. Unfortunately terraform does not do conditional logic yet, See this issue -
https://github.com/hashicorp/terraform/issues/1604
If it did we could do something like -
  resource "atlas_artifact" "machine" {
    name = "${var.atlas_artifact.name}"
    type = "aws.ami"
  }
}

then in a resource

resource "aws_instance" "machine" {
  if ${var.atlas_enabled} {
     ami = "${atlas_artifact.machine.id}"
  } else {
     ami = "${var.ami_string}"
  }
}

Reversing the atlas support would be fairly trivial. in fact it was only recently added for digitalocean in this commit https://github.com/Capgemini/Apollo/commit/163c735d09928df34446257fe7f177a3d182f21a
We'll have an investigation and see if we can make the requirement around atlas a bit more flexible

We should make Atlas one of the frameworks or things we make pluggable like marathon, vault etc.

Lets figure out the best way to this pluggable. I find atlas a good default approach as for aws it allows to the user skip the step of building the image. Not sure is gce or do is planning to allow publi images at some point.

Wondering if we might be able to use terraform modules to optionally load the atlas configuration or fallback to default if atlas is not enabled. For example -
in terraform/aws create a default and atlas folder. move the atlas configuration to a terraform file inside the atlas folder. in the main terraform files do something like -
variable "config_type" {
 default = "atlas"
 description = "Type of configuration to use. can be either default/atlas"
}

module "artifact" {
    source = "./${var.config_type}"
}

the default and atlas modules would provide the same output that could be used in the ami field of the resource type. This would mean we could use atlas optionally by setting config_type via an environment variable. Need to have a play around and see if this works though

I raised a ticker here https://github.com/hashicorp/terraform/issues/1846

Atlas is no longer a requirement for the project - we've removed the Atlas support. Closing this.


Help please - Better Image Quality and text cut

Thank you so much for this great extension.
First issue
My text gets cutted. Se the numbers in the images.
Next "issiue"
I have installed the extension on my vb.net server and I am linking to a function (called latex2png - see below) in the code:
Shared Function latex2png(latex As String) As MemoryStream
        Dim parser = New TexFormulaParser()
        Dim formula = parser.Parse(latex)
        formula.GetRenderer(TexStyle.Script, 15.0, "Arial")

        Dim pngBytes = formula.RenderToPng(15.0, 0.0, 0.0, "Arial")
        Dim latexpng As New MemoryStream(pngBytes)

        Return latexpng
    End Function

Everything is working great, but sadly the quality of the image could be much better. Is there any way to get a higher quality of the png image that is created? Hope you can help me.
Seems like making the scale bigger is better. But the image gets to large in the end.
SCALE 12

SCALE 15

SCALE 25

BTW. I am writing the code in vb.net in aspx, and I am a novice. So go easy on me, when explaining. :)
Kind regards
Troels Christensen

At the moment, I can't guarantee that this would be a good solution (because we're still working on improving the rendering quality), but you could try it out if you want to.
//The code sample below is in "WpfMath/TexRenderer.cs
//If the method you're using calls the method below, the x and y values should be enough to prevent the text from getting cut (I could suggest 3.5 for both x and y).
public BitmapSource RenderToBitmap(double x, double y)
        {
            var visual = new DrawingVisual();
            using (var drawingContext = visual.RenderOpen())
            {
                //this.Render(drawingContext, x, y);
                drawingContext.DrawGeometry(Brushes.Black,new Pen(Brushes.Black,0.7),this.RenderToGeometry(x, y));
            }

            var width = (int)Math.Ceiling(2*x+this.RenderSize.Width);
            var height = (int)Math.Ceiling(2*y+this.RenderSize.Height);
            var bitmap = new RenderTargetBitmap(width, height, 96, 96, PixelFormats.Default);
            bitmap.Render(visual);

            return bitmap;
        }

Thank you for your quick response, @B3zaleel.
Sadly it's not possible for me to use this code. I'm coding for a webpage. I'm using Visual Studio when coding and can't see the files. Installed Wpf-math as a socalled Nuget package. I'm coding in vb.net. Tried to convert your code, but I cant get it to work. But thanks anyway.
I'm also using a memorystream, because I'm not allowed/it's not possible to use an image. It's working. But the image quality is not good.
calling the latex2png function like this:
latex2png("\vec{AB} = 0_E ")
Shared Function latex2png(latex As String) As MemoryStream
        Dim parser = New TexFormulaParser()
        Dim formula = parser.Parse(latex)
        formula.GetRenderer(TexStyle.Display, 15.0, "Arial")
        Dim pngBytes = formula.RenderToPng(15, 0.0, 0.0, "Arial")
        Dim latexpng As New MemoryStream(pngBytes)
        Return latexpng
    End Function

Kind regards.
Troels
The text does not get cut off, when using a scaling factor below 16.

If you you're using and have Visual Studio 2017 (version 15.7.5+) for coding, just click the Clone button, download the files, extract them at your working folder and you have the complete project with you(the built version is what you get from nuget, but you can't edit the files). If you try to build it, there won't be bugs waiting for you. You won't be able to convert the code if you don't have the project files.
See the attached file.
WpfMath-dotnet40.zip

Ok. Thank you again. I’ll try to look into it. For now I have fixed it. I use scale 50 first and then shrink it afterwards. Images now look much better. I use wpf-math together with Gembox extension in VS2017.

And here is the quality of the images now.

Much better. So if a future version of wpf-math could bring support for quality/dpi I think it would be nice.

@troelschristensen one of the quality solutions for now would be to use SVG instead of PNG. Take a look at our example project: it has the stuff to render the formula into SVG image, it will scale much better.

Alright, after some additional research I have the working prototype. There're two problems:

"Text cutting": with default settings, some of the letter elements are sometimes drawn out of bounds of our images. See image attached (this is SVG, but it has the same problems anyway):

Solution: Fix the images by adding a TranslateTransform to them if they're out of bounds.
Images generated by TexRenderer.RenderToBitmap have poor resolution by default (something like 96 DPI because that's the default resolution for "Display Independent Pixels").
Solution: Allow the user to define their own resolution instead of the default one.

@ForNeVeR That sounds great. Hope that I Can save as svg and not png. But I can’t get to the sample projekt. The link is simply not working. 🤷♂ Great that you found the cutting issue. I’ll try to use the translateTransform, but right now I don’t know, how I would do that.🤷♂
Sent with GitHawk

@ForNeVeR Instead of using a TranslateTransform, why can't the origin be changed? It could prevent the text from getting cut.

@troelschristensen You can save as svg without the sample project.
For example:
    Dim renderer = formula.GetRenderer(TexStyle.Script, 15.0, "Arial")
    Dim geometry = renderer.RenderToGeometry(3.5, 3.5)
    Dim converter = new SVGConverter()
    Dim svgPathText = converter.ConvertGeometry(geometry)
    Dim svgText = AddSVGHeader(svgPathText)
    Using  writer As New System.IO.StreamWriter(New IO.FileStream("c:\test.svg", mode:=IO.FileMode.Create))
              writer.WriteLine(svgText)
    End Using

@B3zaleel well the origin could be changed, too, but for now there's another issue because our PNG rendering code was ignoring the user-provided origin. I'll fix that, too 😄

@B3zaleel Thank you. I’ll try that.👍 Sounds great, @ForNeVeR 👌
Sent with GitHawk

@ForNeVeR That's why in my first code sample here, I multiplied the origin by two and added it to the width, so that the end doesn't get taken out.

FYI, the changes were published in WPF-Math 0.6.0.


add antergos 128x128 icon

Also noticed that the manjaro icon was executable, so I did a chmod 664 on it.
Thanks for this awesome rEFInd theme!

Thank you !

Happy to be able to contribute! :smile:

From 0 @joshuarli s to at least 1. Crazy


[iOS] Screenshare is not working

Describe the bug
A clear and concise description of what the bug is.
Hey thank you for this great app but there are still things that aren’t working:
After joining the demo meeting the microphone button does nothing and the screen recording button does nothing too!
Screenshots
If applicable, add screenshots to help explain your problem.
Smartphone (please complete the following information):

Device: [e.g. iPhone6
iPhone 12 Pro Max
OS: [e.g. iOS8.1]
IOS 14.5
Browser [e.g. stock browser, safari]
Safari
Version [e.g. 22]
14.1

BBB Server
What version does the used BBB Server have (if known to you)?
Demo.bigbluebutton.org
Additional context
Add any other context about the problem here.

Hi there, thank you for the bug report.
"After joining the demo meeting the microphone button does nothing" -> Should be fixed with the next maintenance release v0.2.6.
"screen recording button does nothing" -> This one's new! Will rename the issue accordingly and we will try to reproduce the problem. May be fixed with the new maintenance release as well.

@lukaskirner Have you checked screen share recently?

Tomorrow I send you a video of this issue

Am 11/02/2021 um 19:22 schrieb Benjamin Eder<EMAIL_ADDRESS>
@lukaskirner Have you checked screen share recently?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Here is the video:
https://user-images.githubusercontent.com/11319871/107761670-0d0ee280-6d2c-11eb-8318-b72d7080da2b.mov


Possible debian bug preventing vanguards from running while Tor is not available

Current:
When Tor was killed (by service tor restart or something), vanguards kills itself too.
Expected:
When Tor is killed, vanguards retry connection infinitely, until the system admin kills it by service vanguards stop.

Hrmm this may be a side effect of how the debian service is configured. Are you talking about the debian service?
When I run vanguards from the command line, it does indeed keep trying to reconnect until the tor process comes back.

* * * * * /path/to/watcher.sh
...

if [ $(ps aux|grep vanguards|grep pypy|wc -l) = 0 ]; then
logger ATTENTION! VANGUARD DOWN!!
service vanguards restart
fi

...


Missing tabs in the security section

When navigating to the security section the right top tabs are not visible but on a refresh they come back. This is also the case when you go another step deeper and select a user the tabs are not present but reappear on refresh.
After navigating to the area:

After navigating to a user:

On browser refresh:

I can't reproduce it; It seems fine to me? Can you give more concise reproduction steps please?

All repos are up-to-date with master...
When I navigate to the security area (eg from files area), the security area loads but without the tabs. On browser refresh the tabs appear. In chrome.

This is no longer an issue for me so closing.

Issue is back again for me so re-opening

Hasn't happened since I can remember, putting it down to caching and closing.


feat: boost search result with table usage

Changes

Add a new query param sortby in the API that accepts usage (only for now). If this is passed, we return search results that sorted by table usage (the bigger usage_count, the more it prioritized to appear first)
Convert ES query
From this

{
	"query": {
		"bool": {
			"should": [
				{
					"multi_match": {
						"fields": [
							"urn^10",
							"name^5"
						],
						"query": "sample"
					}
				},
				{
					"multi_match": {
						"fields": [
							"urn^10",
							"name^5"
						],
						"fuzziness": "AUTO",
						"query": "sample"
					}
				},
				{
					"multi_match": {
						"fuzziness": "AUTO",
						"query": "sample"
					}
				}
			]
		}
	},
	"min_score": 0.01
}

To use function score query
{
	"query": {
		"function_score": {
			"functions": [
				{
					"field_value_factor": {
						"field": "data.profile.usage_count",
						"missing": 1,
						"modifier": "log1p"
					},
					"weight": 1
				}
			],
			"query": {
				"bool": {
					"should": [
						{
							"multi_match": {
								"fields": [
									"urn^10",
									"name^5"
								],
								"query": "sample"
							}
						},
						{
							"multi_match": {
								"fields": [
									"urn^10",
									"name^5"
								],
								"fuzziness": "AUTO",
								"query": "sample"
							}
						},
						{
							"multi_match": {
								"fuzziness": "AUTO",
								"query": "sample"
							}
						}
					]
				}
			},
			"score_mode": "sum"
		}
	},
	"min_score": 0.01
}

instead of hardcoding data.profile.usage_count, could we get it from querystring so that users can sort using another field? This is just to make it more generic not specific to our use case because data.profile.usage_count is our model while users are free to use any structure that they want.
wdyt? @mabdh

instead of hardcoding data.profile.usage_count, could we get it from querystring so that users can sort using another field? This is just to make it more generic not specific to our use case because data.profile.usage_count is our model while users are free to use any structure that they want.
wdyt? @mabdh

yes, that could be done. let me update the code.


minor issue

when using the live editing function, after quitting the editor the shader did not also quit.
export CURV_EDITOR=gvim
./curv -e -l  lollipop.curv

That sounds reasonable. (The -e flag is not well thought out right now.)
With this change, the CURV_EDITOR variable will need to be set to a command that opens a GUI editor window, and remains running in the foreground until the window is closed. Not all editors are suitable. 'gvim' won't work, but 'gvim -f' will work.

fixed

and now documented in docs/README.rst


API - v1 users

API - v1 users: account, consumers, emails, invitations, privileges, ssh-keys;
suppression for AvoidInlineConditionals

This pull request is now managed with CodeReviewHub. Refresh.

Just moved to a new house. I will need some time before I can review /
merge this one. Sorry...


Creating New Azure Machine Learning Workspace

System Information (please complete the following information):

Model Builder Version:
Visual Studio Version

Describe the bug

On which step of the process did you run into an issue:
Clear description of the problem:

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

@Aamirkhan10218 sorry you ran into this problem! Can I get more details? Is your issue similar to this https://github.com/dotnet/machinelearning-modelbuilder/issues/1104?

Not enough information to investigate. @Aamirkhan10218 please let me know if this is still an issue!


Adds ability to use an async error handler with XPCServer

Also added tests to validate that the server's error handler actually gets called.

@amomchilov For your review. Unless I overlooked something (totally possible), this should complete adding async support within SecureXPC.


AX_FOCUS_02: Is a focusable span with onclick keyboard accessible?

In AX_FOCUS_02, we see the following:

Click me!

Click me too!

Followed by:

Elements which have click handlers but are not focusable can not be used by keyboard-only users.

Would one be able to invoke doSomething() with the keyboard alone? I was under the impression that only inherently focusable elements were keyboard accessible without also adding a keydown|keyup handler.

Thanks for the question. I checked it out and actually it's only interactive content which gets synthetic clicks - so yeah, roughly only the inherently focusable elements.
So this text should be clarified, and the rule should probably also check for a keyboard (keydown/keypress/keyup) event.


feat(planning_evaluator): add planning evaluator

Related Issue(required)
Resolves https://github.com/autowarefoundation/autoware.universe/issues/289

Description(required)
Add the planning_evaluator package which implements a node to calculate various planning metrics.

Review Procedure(required)

run ros2 launch planning_evaluator planning_evaluator.launch.xml alongside Autoware.
Metric values are publishes on topics /planning_evaluator/metrics/....
Set an output_file in the parameters and when shutdown, the planning_evaluator node will write metrics to the file.

To check Obstacle_time_to_collision is calculated, you have to change the parameter dist_thr_m to around 10.
https://github.com/autowarefoundation/autoware.universe/pull/288/files#diff-1ad54c5e1a9f25da8c26f6eea0ff5fcf62de9c3b5441875d1e214e049f75b68eR30
Because Obstacle_time_to_collision is calculated only when the distance between ego and obstacle is smaller than dist_thr_m. If the condition is not satisfied, none is outputed.

Related PR(optional)

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Read commit-guidelines
[x] Assign PR to reviewer

If you are adding new package following items are required:

[x] Documentation with description of the package is available
[x] A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[x] Commits are properly organized and messages are according to the guideline
[x] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@kyoichi-sugahara colcon test failed in my environment. Do you have any idea of its cause?

Test passes in the latest branch.


import MobileRTC

warning: [CP] Unable to find matching .xcframework slice in 'ios-i386_x86_64-simulator ios-arm64_armv7' for the current build architectures (arm64 x86_64).
/Users/pearlorganisation/Downloads/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_zoom_sdk-1.1.0+4/ios/Classes/SwiftFlutterZoomSdkPlugin.swift:2:8: error: no such module 'MobileRTC'
import MobileRTC
^

warning: [CP] Unable to find matching .xcframework slice in 'ios-i386_x86_64-simulator ios-arm64_armv7' for the current build architectures (arm64 x86_64). /Users/pearlorganisation/Downloads/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_zoom_sdk-1.1.0+4/ios/Classes/SwiftFlutterZoomSdkPlugin.swift:2:8: error: no such module 'MobileRTC' import MobileRTC ^

currently doesn't support on simulator ---- m1 chip

@evilrat
The same error appears with Intel chips too.

@evilrat The same error appears with Intel chips too.

Did you fixed the issue?


GLFW on Linux only needs to be linked with libGL since version 3.1.2

I'm submitting a ...

[x] bug report
[ ] feature request

What is the current behavior?

NimGL links all these unnecessary libraries when compiling GLFW:
https://github.com/nimgl/nimgl/blob/2ffe9e1d527aab6085decfbb56741276c480a5df/src/nimgl/glfw.nim#L52
Excerpt from the GLFW changelog:

If the current behavior is a bug, please provide the steps to reproduce and
if possible a minimal demo of the problem

Just use NimGL's GLFW wrapper.

What is the expected behavior?

NimGL should only link to libGL and maybe pthread.

What is the motivation / use case for changing the behavior?

By linking to all the X11-related libraries we're only pulling in unnecessary hard dependencies to executables. This might prove running NimGL executables difficult on Wayland-only environments. Also, requiring users to install all of those libraries is just plain inconvenient in the long run.

Please tell us about your environment:

Version: 1.1.5
OS: Linux
Bindings: GLFW

Other information (e.g. detailed explanation, stacktraces, related issues,
suggestions how to fix, links for us to have context, eg. stackoverflow,
docs.gl, documentation etc)

The solution should be simple; replace the current line with this:
{.passL: "-pthread -lGL".}

By the way, linking to libm is unnecessary as Nim links it by default.

Thanks for the explanation, fixed by https://github.com/nimgl/nimgl/commit/1298b31f4bc86f27f7725f3cba882f71b31683db.
Tested in xorg-server 1.20.10, would like to know if there are any inconveniences in Wayland. Can't personally test since I use nvidia drivers.


Adjust tests workflow for fork PRs

[x] changed tests workflow to pull_request_target trigger

Potential vulnerabilities:

stolen secrets.

@tunetheweb, I did minimal changes (hope I understood you correct)
And existing PRs need to rebase in order to use a new workflow.

Any ideas why it didn’t kick off a run for this PR?

I think it's because it will run once merged (source)
Could replicate it in a test repo.


GEODE-2653: Fix testRemoveMember and remove FlakyTest.

And do some cleanup while I'm here:

Change Mockito's any to isA.
Replace some Thread.sleep() calls with Awaitility calls.
Remove our MethodExecuted class -- this can be done with Mockito'sverify().

@bschuchardt this is https://reviews.apache.org/r/58155/

@kohlmu-pivotal


Validation Errors list cards that have no validation errors

When triggering validation, those ValidationErrorSources who have no errors are not filtered.

Fixed with #53


decouple listen_event and wakeword handling

i'll adjust the test as we cant test it this way any more


Register

@JuliaRegistrator register()

@JuliaRegistrator register()

Error while trying to register: "Tag with name v0.1.0 already exists and points to a different commit"

@JuliaRegistrator register()

Error while trying to register: "Tag with name v0.1.1 already exists and points to a different commit"

Error while trying to register: "Tag with name v0.1.1 already exists and points to a different commit"

@JuliaRegistrator register()

Error while trying to register: Version 0.1.1 already exists

@JuliaRegistrator register


Develop API Endpoint and Frontend Feature for Displaying Available Agents

To enhance our game's user experience, we need to implement a new feature that allows players to view a list of available agents they can choose to fight against. This requires both backend and frontend development.
Acceptance Criteria:

[ ] Implement an API endpoint (/api/agents) that returns a list of all available agent names in a structured format
[ ] Give HTTP status code for success (Put the response in the ResponseEntity)
[ ] Frontend displaying list of available agents

From this issue you will learn how to connect frontend and backend and get a broader picture of the entire stack

This has also given possibility of choosing agent to play against in frontend

Amazing work @JonBergland


[DCOS-42020] Check for package manager before doing any uninstall work

uninstall will not proceed if the package manager is not installed
as a note: tested this from cluster UI and cli to double check errors, cluster UI hangs with no error when cosmos reject uninstall request.

sequence of uninstalls now gives the following messages
Mesospheres-MacBook-Pro-44:~ karanvishwanathan$ dcos package uninstall beta-mke
WARNING: This action cannot be undone. This will uninstall [beta-mke] and delete all of its persistent data (logs, configurations, database artifacts, everything).
Please type the name of the service to confirm: yes
Expected 'beta-mke'. You supplied 'yes'.
Please type the name of the service to confirm: beta-mke
Uninstalled package [beta-mke] version [2.0.0-1.12.0-beta]
The Mesosphere Kubernetes Engine service is being uninstalled.
Mesospheres-MacBook-Pro-44:~ karanvishwanathan$ dcos package uninstall beta-kubernetes
WARNING: This action cannot be undone. This will uninstall [beta-kubernetes] and delete all of its persistent data (logs, configurations, database artifacts, everything).
Please type the name of the service to confirm: beta-kubernetes
the custom manager: '/beta-mke', is not installed for this package'

I have cleanup a method in Custom Manager Router so that we can remove the ignore of cyclomatic check. See https://github.com/dcos/cosmos/compare/uninstall-fixes-2...cleanup-uninstall-handler
Can you paste a well formatted command line output when the CLI tries to install (I see uninstall above, but I am hoping the error message has been updated with proper formatting) a package that requires a custom manager but none is installed.
Just as an FYI, after this is merged, we have to merge https://github.com/mesosphere/cosmos-enterprise/pull/60 as well so that we can make a 0.6.1 release.

install output with no mke
Mesospheres-MacBook-Pro-44:~ karanvishwanathan$ dcos package install beta-kubernetes --yes the custom manager: '/beta-mke', is not installed for this package

@kvish You can merge after someone from k8 team reviews the error messages.

got an offline ack on the error messages, merging this


Index France?

"epinal, france" doesn't get "Epinal" as first result, because Epinal document doesn't contain "France".
We have two options:

index country name for each document (bigger index)
add a special case for handling "france" in search algo (hackish)

I'm in favour of option 1.

As addok is language/country specific. Allow detection and remove of the country from the query

That's an option, but how you prevent from removing "France" from, for example, "Tremblay-en-France"?

So, maybe not remove. But have a 'fake' index on constant values on the data set like country or state.


GCI - Improve development guide

We have this guide but it's not detailed. It would be great to have a detailed guide on how to install the dev env on various OS Windows/macOS/Linux which will include the instructions, screenshots, troubleshooting etc.

@akashnimare would it be fine it you require have to require('console') in order to log to devtools

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot I have done the work and waiting for review.

@zulipbot claim

@zulipbot abandon

@zulipbot claim


Finetuning with llm-foundry (composer format)

Hi,
Is there any option to convert HF ckpt to composer and FT with the llm-foundry scripts?
Thanks!

The finetuning example (https://github.com/mosaicml/llm-foundry/blob/main/scripts/train/finetune_example/gpt2-arc-easy.yaml) yaml loads gpt2 from huggingface and then trains using the llm-foundry. Is that what you are looking for?

Closing this issue as it's gone stale.
We have HF conversion instructions here: https://github.com/mosaicml/llm-foundry/tree/main/scripts/inference#converting-a-composer-checkpoint-to-an-hf-checkpoint-folder
And we have two PRs (#229 and #253) adding FasterTransformer support.


Fuzzer assertion in refine_node

My new fuzzer is hitting an assertion. Note the failure is nondeterministic despite the fact that the fuzzer itself is deterministic and I am running in debug mode with -lg:inorder:
Assertion failed: ((current_sets == NULL) || (mask * current_sets->get_valid_mask()) || refine_current), function refine_node, file region_tree.inl, line 7311.

Backtrace:
* thread #8, stop reason = hit program assert
    frame #0: 0x00007ff8066d57a2 libsystem_kernel.dylib`__pthread_kill + 10
    frame #1: 0x00007ff80670df30 libsystem_pthread.dylib`pthread_kill + 262
    frame #2: 0x00007ff80662ca49 libsystem_c.dylib`abort + 126
    frame #3: 0x00007ff80662bd30 libsystem_c.dylib`__assert_rtn + 314
  * frame #4: 0x0000000105eef0d0 liblegion.1.dylib`Legion::Internal::EqKDNode<1, long long>::refine_node(this=0x00007feac0f15ee0, rect=0x000070000ca6b2c0, mask=0x000070000ca6b170, refine_current=false) at region_tree.inl:7310:7
    frame #5: 0x0000000105edff51 liblegion.1.dylib`Legion::Internal::EqKDNode<1, long long>::initialize_set(this=0x00007feac0f15ee0, set=0x00007feb1201f200, rect=0x000070000ca6b2c0, mask=0x00006000018b47b0, local_shard=0, current=true) at region_tree.inl:6855:13
    frame #6: 0x0000000105edaf6d liblegion.1.dylib`Legion::Internal::EqKDSparse<1, long long>::initialize_set(this=0x00006000023b4ec0, set=0x00007feb1201f200, rect=0x000070000ca6b330, mask=0x00006000018b47b0, local_shard=0, current=true) at region_tree.inl:8695:18
    frame #7: 0x0000000105e114fb liblegion.1.dylib`Legion::Internal::IndexSpaceNodeT<1, long long>::initialize_equivalence_set_kd_tree(this=0x00007feb06016400, tree=0x00006000023b4ec0, set=0x00007feb1201f200, mask=0x00006000018b47b0, local_shard=0, current=true) at region_tree.inl:5154:25
    frame #8: 0x00000001053b39c7 liblegion.1.dylib`Legion::Internal::InnerContext::initialize_region_tree_contexts(this=0x00007feb06022800, clone_requirements=size=1, version_infos=size=1, unmap_events=size=1) at legion_context.cc:10859:34
    frame #9: 0x0000000105831dd7 liblegion.1.dylib`Legion::Internal::SingleTask::launch_task(this=0x00007feb12825000, inline_task=false) at legion_tasks.cc:4742:28
    frame #10: 0x000000010585809e liblegion.1.dylib`Legion::Internal::SliceTask::map_and_launch(this=0x00007feb12823c00) at legion_tasks.cc:11517:18
    frame #11: 0x00000001058379b6 liblegion.1.dylib`Legion::Internal::MultiTask::trigger_mapping(this=0x00007feb12823c00) at legion_tasks.cc:5646:15
    frame #12: 0x0000000105ba7482 liblegion.1.dylib`Legion::Internal::Runtime::legion_runtime_task(args=0x00007feac0f15de8, arglen=12, userdata=0x00006000034acac0, userlen=8, p=(id =<PHONE_NUMBER>099910144)) at runtime.cc:32306:31
    frame #13: 0x0000000109e5b158 librealm.1.dylib`Realm::LocalTaskProcessor::execute_task(this=0x00007feb11928d30, func_id=4, task_args=0x000070000ca6c8e0) at proc_impl.cc:1176:5
    frame #14: 0x0000000109f01fd8 librealm.1.dylib`Realm::Task::execute_on_processor(this=0x00007feac0f15cb0, p=(id =<PHONE_NUMBER>099910144)) at tasks.cc:326:40
    frame #15: 0x0000000109f08ccc librealm.1.dylib`Realm::KernelThreadTaskScheduler::execute_task(this=0x00007feb11928450, task=0x00007feac0f15cb0) at tasks.cc:1421:11
    frame #16: 0x0000000109f07355 librealm.1.dylib`Realm::ThreadedTaskScheduler::scheduler_loop(this=0x00007feb11928450) at tasks.cc:1160:6
    frame #17: 0x0000000109f07d5a librealm.1.dylib`Realm::ThreadedTaskScheduler::scheduler_loop_wlock(this=0x00007feb11928450) at tasks.cc:1272:5
    frame #18: 0x0000000109f1cb6c librealm.1.dylib`void Realm::Thread::thread_entry_wrapper<Realm::ThreadedTaskScheduler, &Realm::ThreadedTaskScheduler::scheduler_loop_wlock()>(obj=0x00007feb11928450) at threads.inl:97:5
    frame #19: 0x0000000109f20f18 librealm.1.dylib`Realm::KernelThread::pthread_entry(data=0x00006000001a0420) at threads.cc:831:5
    frame #20: 0x00007ff80670e202 libsystem_pthread.dylib`_pthread_start + 99
    frame #21: 0x00007ff806709bab libsystem_pthread.dylib`thread_start + 15

The trace that generates the assertion is quite short:
$ ./src/fuzzer -level 4,fuzz=2 -fuzz:ops 10 -fuzz:seed 0 -lg:leaks -lg:inorder
[0 - 7ff849d357c0]    0.000158 {4}{threads}: reservation ('dedicated worker (generic) #1') cannot be satisfied
[0 - 70000c0bf000]    0.078761 {3}{fuzz}: Fuzzer Configuration:
[0 - 70000c0bf000]    0.078783 {3}{fuzz}:   config.initial_seed = 0
[0 - 70000c0bf000]    0.078786 {3}{fuzz}:   config.region_tree_depth = 1
[0 - 70000c0bf000]    0.078788 {3}{fuzz}:   config.region_tree_width = 4
[0 - 70000c0bf000]    0.078790 {3}{fuzz}:   config.region_tree_branch_factor = 4
[0 - 70000c0bf000]    0.078795 {3}{fuzz}:   config.region_tree_num_fields = 4
[0 - 70000c0bf000]    0.078798 {3}{fuzz}:   config.num_ops = 10
[0 - 70000c0bf000]    0.132885 {2}{fuzz}: Operation: 0
[0 - 70000c0bf000]    0.132905 {2}{fuzz}:   Launch type: single task
[0 - 70000c0bf000]    0.132909 {2}{fuzz}:   Task ID: 1
[0 - 70000c0bf000]    0.132913 {2}{fuzz}:   Launch domain: <2>..<3>
[0 - 70000c0bf000]    0.132916 {2}{fuzz}:   Elide future return: 1
[0 - 70000c0bf000]    0.132918 {2}{fuzz}:   Field set: 0x1
[0 - 70000c0bf000]    0.132922 {2}{fuzz}:   Privilege: 0x1
[0 - 70000c0bf000]    0.132926 {2}{fuzz}:   Partition: LogicalPartition(1,IndexPartition(5,1),FieldSpace(1))
[0 - 70000c0bf000]    0.132929 {2}{fuzz}:   Shifting shard points by: 2
[0 - 70000c0bf000]    0.132933 {2}{fuzz}:   Task: 2
[0 - 70000c0bf000]    0.132936 {2}{fuzz}:     Shard point: (2)
[0 - 70000c0bf000]    0.135129 {2}{fuzz}:   Task: 3
[0 - 70000c0bf000]    0.135149 {2}{fuzz}:     Shard point: (3)
[0 - 70000c0bf000]    0.137861 {2}{fuzz}: Operation: 1
[0 - 70000c0bf000]    0.137876 {2}{fuzz}:   Launch type: index space
[0 - 70000c0bf000]    0.137880 {2}{fuzz}:   Task ID: 2
[0 - 70000c0bf000]    0.137884 {2}{fuzz}:   Launch domain: <1>..<2>
[0 - 70000c0bf000]    0.137887 {2}{fuzz}:   Elide future return: 1
[0 - 70000c0bf000]    0.137890 {2}{fuzz}:   Field set: 0x4
[0 - 70000c0bf000]    0.137894 {2}{fuzz}:   Privilege: 0x7
[0 - 70000c0bf000]    0.137896 {2}{fuzz}:   Projection: 1
[0 - 70000c0bf000]    0.137901 {2}{fuzz}:   Partition: LogicalPartition(1,IndexPartition(2,1),FieldSpace(1))
[0 - 70000c0bf000]    0.140866 {2}{fuzz}: Operation: 2
[0 - 70000c0bf000]    0.140878 {2}{fuzz}:   Launch type: index space
[0 - 70000c0bf000]    0.140882 {2}{fuzz}:   Task ID: 3
[0 - 70000c0bf000]    0.140885 {2}{fuzz}:   Launch domain: <1>..<3>
[0 - 70000c0bf000]    0.140888 {2}{fuzz}:   Scalar redop: 1048580
[0 - 70000c0bf000]    0.140891 {2}{fuzz}:     Ordered: 1
[0 - 70000c0bf000]    0.140893 {2}{fuzz}:   Elide future return: 1
[0 - 70000c0bf000]    0.140896 {2}{fuzz}:   Field set: 0x0
[0 - 70000c0bf000]    0.140898 {2}{fuzz}:   Privilege: 0x10000007
[0 - 70000c0bf000]    0.140901 {2}{fuzz}:   Projection: 0
[0 - 70000c0bf000]    0.140904 {2}{fuzz}:   Partition: LogicalPartition(1,IndexPartition(1,1),FieldSpace(1))
[0 - 70000c0bf000]    0.141547 {2}{fuzz}: Operation: 3
[0 - 70000c0bf000]    0.141563 {2}{fuzz}:   Launch type: index space
[0 - 70000c0bf000]    0.141567 {2}{fuzz}:   Task ID: 2
[0 - 70000c0bf000]    0.141570 {2}{fuzz}:   Launch domain: <0>..<3>
[0 - 70000c0bf000]    0.141573 {2}{fuzz}:   Elide future return: 1
[0 - 70000c0bf000]    0.141576 {2}{fuzz}:   Field set: 0x6
[0 - 70000c0bf000]    0.141581 {2}{fuzz}:   Privilege: 0x0
[0 - 70000c0bf000]    0.141583 {2}{fuzz}:   Projection: 0
[0 - 70000c0bf000]    0.141587 {2}{fuzz}:   Partition: LogicalPartition(1,IndexPartition(1,1),FieldSpace(1))
[0 - 70000c0bf000]    0.142309 {2}{fuzz}: Operation: 4
[0 - 70000c0bf000]    0.142321 {2}{fuzz}:   Launch type: single task
[0 - 70000c0bf000]    0.142324 {2}{fuzz}:   Task ID: 2
[0 - 70000c0bf000]    0.142327 {2}{fuzz}:   Launch domain: <0>..<0>
[0 - 70000c0bf000]    0.142330 {2}{fuzz}:   Elide future return: 1
[0 - 70000c0bf000]    0.142333 {2}{fuzz}:   Field set: 0x9
[0 - 70000c0bf000]    0.142337 {2}{fuzz}:   Privilege: 0x4
[0 - 70000c0bf000]    0.142339 {2}{fuzz}:   Region redop: 1048685
[0 - 70000c0bf000]    0.142343 {2}{fuzz}:   Partition: LogicalPartition(1,IndexPartition(2,1),FieldSpace(1))
[0 - 70000c0bf000]    0.142346 {2}{fuzz}:   Shifting shard points by: 1
[0 - 70000c0bf000]    0.142349 {2}{fuzz}:   Task: 0
[0 - 70000c0bf000]    0.142352 {2}{fuzz}:     Shard point: (0)
[0 - 70000c0bf000]    0.145289 {2}{fuzz}: Operation: 5
[0 - 70000c0bf000]    0.145298 {2}{fuzz}:   Launch type: index space
[0 - 70000c0bf000]    0.145301 {2}{fuzz}:   Task ID: 1
[0 - 70000c0bf000]    0.145304 {2}{fuzz}:   Launch domain: <0>..<1>
[0 - 70000c0bf000]    0.145307 {2}{fuzz}:   Scalar redop: 1048625
[0 - 70000c0bf000]    0.145309 {2}{fuzz}:     Ordered: 1
[0 - 70000c0bf000]    0.145312 {2}{fuzz}:   Elide future return: 0
[0 - 70000c0bf000]    0.145314 {2}{fuzz}:   Field set: 0x4
[0 - 70000c0bf000]    0.145318 {2}{fuzz}:   Privilege: 0x7
[0 - 70000c0bf000]    0.145320 {2}{fuzz}:   Projection: 0
[0 - 70000c0bf000]    0.145324 {2}{fuzz}:   Partition: LogicalPartition(1,IndexPartition(2,1),FieldSpace(1))
[0 - 70000c0bf000]    0.148133 {2}{fuzz}: Operation: 6
[0 - 70000c0bf000]    0.148148 {2}{fuzz}:   Launch type: index space
[0 - 70000c0bf000]    0.148151 {2}{fuzz}:   Task ID: 3
[0 - 70000c0bf000]    0.148155 {2}{fuzz}:   Launch domain: <2>..<3>
[0 - 70000c0bf000]    0.148157 {2}{fuzz}:   Scalar redop: 1048655
[0 - 70000c0bf000]    0.148160 {2}{fuzz}:     Ordered: 0
[0 - 70000c0bf000]    0.148162 {2}{fuzz}:   Elide future return: 0
[0 - 70000c0bf000]    0.148165 {2}{fuzz}:   Field set: 0xb
[0 - 70000c0bf000]    0.148170 {2}{fuzz}:   Privilege: 0x1
[0 - 70000c0bf000]    0.148172 {2}{fuzz}:   Projection: 2
[0 - 70000c0bf000]    0.148176 {2}{fuzz}:   Partition: LogicalPartition(1,IndexPartition(2,1),FieldSpace(1))
Assertion failed: ((current_sets == NULL) || (mask * current_sets->get_valid_mask()) || refine_current), function refine_node, file region_tree.inl, line 7311.

If you want to reproduce, you must run exactly the command line above, and use this exact commit of the fuzzer: https://github.com/StanfordLegion/fuzzer/commit/f8cf28f6450f1cdd2172f8170774653a2c3faf11
I'm on my Mac but in theory it should be possible to reproduce this anywhere.

Keeping in mind the fact that this one crashes, the Legion Spy logs that I am able to generate pass logical and physical verification. Attached here:
spy_0.log

This isn't a bug in the physical analysis (which is why Legion Spy is fine). This is (yet another) issue with virtual mappings. Fixing it will take a bit of work, but I at least understand it. If you turn off virtual mappings in the mapper then it should go away completely.

Ok, I have confirmed that this one goes away if I modify the fuzzer not to use any virtual mappings.

Worked around via https://github.com/StanfordLegion/fuzzer/commit/3d77d6c97241517056e1e05bb0ab46ff41a82c1e.
I will keep this issue open as there is an underlying Legion bug here, even if I can work around to avoid it.

Will be fixed with this:
https://gitlab.com/StanfordLegion/legion/-/merge_requests/1191
Note this will make virtual mapping initialization for read-only and reduction-only privileges considerably more expensive than they were before but it is necessary for correctness. (Although not as expensive as virtual mappings for read-write privileges which is easily another order of magnitude worse.)

Confirmed the fix with the original reproducer.

Fixed with the merge request above.


For Clarification on OCSP response expiration in OCSP Stapling

Hi, "OCSP response expires" related behaviors are described at https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/transport_sockets/tls/v3/tls.proto#envoy-v3-api-enum-extensions-transport-sockets-tls-v3-downstreamtlscontext-ocspstaplepolicy. And in Envoy, it relies on the "nextUpdate" field within OCSP response to check whether a response "expires" https://github.com/envoyproxy/envoy/blob/main/source/extensions/transport_sockets/tls/ocsp/ocsp.cc#L128-L131. And it looks like if "nextUpdate" field is not set within OCSP response, the response will be marked as expired directly, which may cause outage when OCSP stapling policy is "STRICT_STAPLING" or "MUST_STAPLE".

According to the https://www.rfc-editor.org/rfc/rfc6960#section-<IP_ADDRESS>, it is possible that "nextUpdate" is not set, and it does not mean that the response is not valid. In this case, should such OCSP response be used at Envoy? (Currently looks like it should not be sent to Envoy by the control plane).
If the local time is within [thisUpdate, nextUpdate] (inclusive), the OCSP response is considered as valid. What is the Enovy behavior when the local time is < thisUpdate? Will Envoy wait until thisUpdate to use the OCSP response with the cert or this OCSP response is dropped together with the cert when OCSP stapling policy is "STRICT_STAPLING" or "MUST_STAPLE"?
According to https://www.rfc-editor.org/rfc/rfc6960#section-2.4, it is possible that the new OCSP response is available exactly at "nextUpdate" time (or very close to). Then there will be latency sending this OCSP response to Envoy. Is there some buffer at Envoy to be configured which can accommodate such latency (when means Envoy will still use a cert with "expired" OCSP response for TLS during the buffer time)?

cc @ggreenway

cc @zuercher

For reference:

The thisUpdate and nextUpdate fields define a recommended validity
interval.  This interval corresponds to the {thisUpdate, nextUpdate}
interval in CRLs.  Responses whose nextUpdate value is earlier than
the local system time value SHOULD be considered unreliable.
Responses whose thisUpdate time is later than the local system time
SHOULD be considered unreliable.

If nextUpdate is not set, the responder is indicating that newer
revocation information is available all the time.

Perhaps I'm missing something, but I think the a stapled OCSP response without next-update is not useful for OCSP stapling. If an SSL certificate is compromised and the pre-revocation OCSP responses have no next-update value then it seems to me the attacker can use the revoked certificate and staple the pre-revocation OCSP response. Client would continue to accept the certificate until its revocation reached them through other means (e.g. a certificate revocation list). Envoy does currently treat an OCSP response with no next-update as immediately expired and hence does not return it in lenient-stapling mode and triggers failures in strict-stapling and must-staple mode. I'm willing to consider changing the behavior so that responses without next-update can be treated as having an indefinite expiration. I expect this would be a runtime flag given what I outlined above. Do you have a use case that requires this behavior?
Currently Envoy only uses the this-update field to populate certificate details in the admin API. I think this encodes the implicit expectation that some external process queries the certificate authority for an OSCP response and hence this-update is never in the future (given reasonably-well synchronized clocks). Is there a case where a certificate authority produces OSCP responses with a validity interval starting in the future? Arguably Envoy should treat that the same way it treats responses past the next-update time.
Envoy expects that the authority that generates the OSCP response is capable of producing responses with overlapping validity intervals and that the overlap is sufficient to distribute the response. The lenient-stapling mode allows some flexibility here: Envoy won't staple the response if it's expired. However, that mode is meant as an operational stepping stone to strict stapling or must-staple modes.


proposal: Add option to wrap all immediately-invoked functions in parentheses

It would be nice if escodegen will have option which will work similar to this package:
https://github.com/nolanlawson/optimize-js
Why? No additional dependencies is required, no need to iterate through AST-tree twice, no problems with source map and looks like this package is very slow in getting of updates.

ping

This tweak seems to work for me.  It wraps IIFE's like
var x = function() { return stuff })();

and leaves alone declared function variables:
var x = function() { return stuff };

diff --git a/escodegen.js b/escodegen.js
index 42c05ae..db129a5 100644
--- a/escodegen.js
+++ b/escodegen.js
@@ -1887,7 +1887,10 @@
             if (!(flags & F_ALLOW_CALL)) {
                 return ['(', result, ')'];
             }
-            return parenthesize(result, Precedence.Call, precedence);
+            // check if this CallExpression is an IIFE.  If so, then always wrap in parens.
+            return (expr.callee.id === null && expr.callee.params.length === 0) ?
+               parenthesize(result, 0, 1) :
+               parenthesize(result, Precedence.Call, precedence);
         },

         NewExpression: function (expr, precedence, flags) {

Obviously this needs a settable option.    But I have some free time tomorrow, and can make a proper pull request.


authn v2 support

@pangea-andrest I pushed a doc strings commit to your branch. Please pull it before committing anything else.


altair starter altair.static.basepath is not used anywhere

i am not sure what it suppose to do.
this is what i assume.
if i put basePath same as servlet context path (say /a)
and access {domain:port}/a
loaded altair page must get related vendor files from {domain:port}/a/vendor/ right?
however, regardless of what i specify on basePath, it always try to load file from {domain:port}/vendor/
searched staticBasePath usage on your AltAirController and found none

I'm having the same issue. This issue prevents us from setting the Servlet context path other than root.

@sukyology @ntatsumi Is the base path set in the HTML when you view source of the app?

@sukyology @ntatsumi Is the base path set in the HTML when you view source of the app?

no, it is not specified in the html page.

@sukyology What is the href value of the <base> tag in the HTML?

@sukyology What is the href value of the <base> tag in the HTML?

/vendor/altair

@sukyology And that was not the baseURL you set?
Cc @Sparow199

I'll update Altair to last version with support of headers injection and
fix this issue
On Thu, Mar 21, 2019, 07:43 Samuel<EMAIL_ADDRESS>wrote:

@sukyology https://github.com/sukyology And that was not the baseURL
you set?
Cc @Sparow199 https://github.com/Sparow199
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/graphql-java-kickstart/graphql-spring-boot/issues/218#issuecomment-475126750,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVP80mrE87ur8egKkOD8Re7WyCsg7mt8ks5vYyoHgaJpZM4by9rr
.

@imolorhe
yes whatever i set for altair.static.basepath it is always same.
thank u.

@sukyology , should be fixed with this PR

v5.7.1 syncing to central now which contains this fix


Physical Boot Media

Issue Description
Steps to Reproduce (if applicable):
Acceptance Criteria (how do we know when this is done?)
Related Tickets
Additional Info
Output of uname -a:
Environment (physical, VM, cloud provider, etc.):
Other Relevant Info:

Super simple grub-legacy boot media can now be created.


[Bug] [Module Name] Bug title

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
dolphinscheduler3.1.x api server start error, org.springframework.context.ApplicationContextException: Failed to start bean 'documentationPluginsBootstrapper'; nested exception is java.lang.NoClassDefFoundError: Could not initialize class org.apache.dolphinscheduler.common.enums.WarningType
What you expected to happen
dolphinscheduler3.1.x api server start successful!
How to reproduce
dolphinscheduler3.1.x api server start error, org.springframework.context.ApplicationContextException: Failed to start bean 'documentationPluginsBootstrapper'; nested exception is java.lang.NoClassDefFoundError: Could not initialize class org.apache.dolphinscheduler.common.enums.WarningType
Anything else
No response
Version
3.1.x
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Please change the Bug title


Python tests failing

See https://github.com/CQCL/hugr/actions/runs/9941200862/job/27459740120 .

At first glance appears to be induced by #1226


Adopt Google Python Style

At some point we should update the codebase to https://google.github.io/styleguide/pyguide.html - starting with the things that don't conflict with pep8

@felipesanches and @davelab6 why we don't try to use Google Linter for Python called YAPF? This maybe the solution to this item!

@vmesel cool, I didn't know of that linter; how many errors does it report? :)

I read some more details and its not actually a linter, it is a pep8 formatter. It gets your code and format for pep8.

Such tools are useful for passing flake8 (https://github.com/googlefonts/fontbakery/blob/e3378ebf8b327c7ac15be2c78844357ba549e538/.travis.yml#L30)

@davelab6 Those specific flake8 errors are being explicitely ignored not because we're unable to fix them, but because at some point I decided that my codestyle is better than what flake8 expects to see in those particular cases.

@felipesanches so why we dont create a new coding style, so we can get a pattern and a linter for checking the code?

@vmesel For the current code style, flake8 with those few specific --ignores does the job already.
What this issue is really about is adapting our codebase to a Google Python coding style. Not sure if there's any real technical benefit in doing it by itself. But given that FontBakery is a useful tool for people working on the Google Fonts project, I think it can be reasonable to have a codestyle that is more familiar to Google engineers.

I decided that my codestyle is better than what flake8 expects to see in those particular cases.

I would prefer no exceptions to pep8 but this is such a low priority thing I even wonder about just closing this issue :)

@davelab6 I am not working on this, precisely because it is extremely low-priority, but this issue could be a good task for @vmesel if he's interested in submitting a pull request.

@felipesanches and @davelab6 do you know any linter for the Google Python Code Style?

Nope

@felipesanches I made this your top item in the 0.2.0 milestone ;)

I did run pylint on the fontbakery-check-ttf.py script and noticed that it complains about the 2 spaces indentation style I use. That's something I won't change at all. At least not now, as I truly prefer 2-space indentation over 4, or even 8. So, in order to ignore those, I figure one can run this:
pylint --disable=bad-indentation fontbakery-check-ttf.py
And the result is just a minimal set of issues:
************* Module fontbakery-check-ttf
W:127, 0: TODO: Not sure why these are disabled. I need to review this. (fixme)
C:  1, 0: Invalid module name "fontbakery-check-ttf" (invalid-name)
C:  1, 0: Missing module docstring (missing-docstring)
W: 32,25: Redefining name 'config' from outer scope (line 496) (redefined-outer-name)
R: 32, 0: Too many local variables (50/15) (too-many-locals)
C: 34, 2: Invalid variable name "fb" (invalid-name)
C:146,10: Invalid variable name "f" (invalid-name)
C:299, 4: Invalid variable name "is_listed_in_GFD" (invalid-name)
C:319, 8: Invalid variable name "is_listed_in_GFD" (invalid-name)
E:333, 8: Assigning to function call which doesn't return (assignment-from-no-return)
C:336,12: Invalid variable name "f" (invalid-name)
E:336,17: Instance of 'FamilyProto' has no 'fonts' member (no-member)
E:400,66: Instance of 'FamilyProto' has no 'name' member (but some types could not be inferred) (maybe-no-member)
W:407, 8: Unused variable 'remote_family' (unused-variable)
R: 32, 0: Too many branches (49/12) (too-many-branches)
R: 32, 0: Too many statements (248/50) (too-many-statements)
C:479, 0: Invalid constant name "parser" (invalid-name)
C:495, 2: Invalid constant name "args" (invalid-name)
C:496, 2: Invalid constant name "config" (invalid-name)

Global evaluation
-----------------
Your code has been rated at 8.85/10

I also dislike all of the invalid-name errors, so I would add it to the ignore list as well.

OK. By also ignoring invalid-name convention warnings, this is what I (supposedly) really gotta do for the check-ttf script:
************* Module fontbakery-check-ttf
W:127, 0: TODO: Not sure why these are disabled. I need to review this. (fixme)
C:  1, 0: Missing module docstring (missing-docstring)
W: 32,25: Redefining name 'config' from outer scope (line 496) (redefined-outer-name)
R: 32, 0: Too many local variables (50/15) (too-many-locals)
E:333, 8: Assigning to function call which doesn't return (assignment-from-no-return)
E:336,17: Instance of 'FamilyProto' has no 'fonts' member (no-member)
E:400,66: Instance of 'FamilyProto' has no 'name' member (but some types could not be inferred) (maybe-no-member)
W:407, 8: Unused variable 'remote_family' (unused-variable)
R: 32, 0: Too many branches (49/12) (too-many-branches)
R: 32, 0: Too many statements (248/50) (too-many-statements)

Global evaluation
-----------------
Your code has been rated at 9.19/10

OK. I removed flake8 and replaced it by pylint with a whole bunch of ignore statements. I've updated the description of this issue above to list each of the ignores and then gradually remove the ignores and fix them.

@behdad do you have preferences for this?

@vmesel (or really anyone else interested in helping with small/quick chunks of code) There's plenty of low-hanging-fruit style work do be done here, if you feel like contributing. Take a look at the previous commits and you'll see a pattern:

remove (on .travis.yml) a single pylint check from the list of ignored ones
run it locally to see where that check fails with the current code (which script, which line, etc)
implement fixes to not simply silence the errors/warnings but actually address the root cause for the issue (this is sometimes trivial, and sometimes may require deeper analysis)
commit it and push
take a look at the status on Travis to make sure the build continues green (that means the specific pylint issue was indeed properly fixed)
check the corresponding check-mark at the top-comment in this issue.
move on to the next pylint issue (it doesn't have to be done in order at all, choose anyone you feel like working on!)

This should work for the vast majority of the currently ignored pylint checks. For a few though, we may prefer to decide that we don't want to adhere at all. This is the case at the moment for the indentation style we use, for instance. These checks are listed in the WONT_FIX environment variable on the .travis.yml file.
There's a lot of stuff here and I acknowledge that it will likely lead to code quality improvements. But I think my time is better spent on other fontbakery issues at the moment. Also, it seems that now the setup is done and the problem is well described and pretty much ideal for external contributors who may be interested in helping the project. So I'll leave it as an ongoing effort open to whoever may be interested in helping with.

'''Note:''' The Travis automated checks will only run if you have an open pull request. So, you'll need to do open a pull request after the first commit you push. And then you can continue pushing to the same feature_branch until I decide to merge your contributions. Then a new pull request will be needed in case you feel like continue sending more contributions.
Travis automated checks show up at https://travis-ci.org/googlefonts/fontbakery/pull_requests

alright :-)

OK. I'll work a bit more today on this one before moving on to other issues.

@behdad do you have preferences for this?

I couldn't care any less.

I suggest others not waste their time on this either.

Thanks for pointing that out, @behdad I'll move on then.
I gotta point out, though, that at least one bug was detected and fixed last Friday due to the above code changes guided by pylint warnings. So it is not really wasted time if some external contributors may want to put the effort. For that reason, I'll restrain from dealing with this issue now, but I'll keep it open.
Does it sound good, @davelab6 ?

Sounds good.

I never said lint is not useful.  Linting to detect bugs is very good practice. Changing existing code for the sake of conforming to a stylesheet is waste of resources, in particular when there's so much font-related code that needs to be written...

The intent is for the code here to be used in google3

Yep! I agree with both @davelab6's and @behdad's respective last comments here :-)

I never said lint is not useful. Linting to detect bugs is very good practice. Changing existing code for the sake of conforming to a stylesheet is waste of resources, in particular when there's so much font-related code that needs to be written...

Actually, an idea similar to that one was also expressed by myself on a google-fonts mailing list message a few days ago, where I said:
"It is not a matter of simply shutting down warnings and errors, but instead an exercise on understanding why the lint-check exists at all and how to effectively improve the code quality by adhering in non-hacky manners."

The intent is for the code here to be used in the GF API onboarding process

Still. Not a requirement. Third-party code doesn't have to comply with Google coding style.

@graphicore @felipesanches @m4rc1e do any of you want to keep open or close this issue?
Behdad makes a compelling case that we can forget this, if you all agree :)

yes, we can forget it!

I'd put the errors/flags we (don't) want into setup.cfg, so flake8 and pylint pick them up as you edit the source.


Float Label not accurate and Legend is not visible

Hello! We would like to raise this issue on labels of c3 it doesn't show the accurate value and it showing too long numeric data when data type is float. Also the legend in the graph is not adjusting whenever the visualization is being added on dark dashboards. Hover tooltip also showing not clear values due to its color schemes. Thanks

Number formatting is a must have. Is there anything that will be made for this ?


Fix/daef 406 tls and notify api issues

This PR includes all the various fixes for the issues with the notify and tlsInit endpoints in production environment.

@darko-mijic this PR is now ready for review …

Please merge https://github.com/input-output-hk/cardano-sl/pull/1331 first (as this PR depends on it)
be aware that the tests cannot be run because the backend does not work correctly in dev mode. (cardano-node-simple: AllPeersUnavailable error)