ibus-engines.typing-booster-unwrapped: 2.25.11 -> 2.25.14

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/ibus-typing-booster/versions.
meta.description for ibus-engines.typing-booster-unwrapped is: Completion input method for faster typing
meta.homepage for ibus-engines.typing-booster-unwrapped is: https://mike-fabian.github.io/ibus-typing-booster/
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.25.13 with grep in /nix/store/h8wl4m67kiaffij0sdvbpyly5k28nybx-ibus-typing-booster-2.25.13
found 2.25.13 in filename of file in /nix/store/h8wl4m67kiaffij0sdvbpyly5k28nybx-ibus-typing-booster-2.25.13

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

ibus-engines.typing-booster
ibus-engines.typing-booster-unwrapped

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/h8wl4m67kiaffij0sdvbpyly5k28nybx-ibus-typing-booster-2.25.13 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ibus-engines.typing-booster-unwrapped https://github.com/r-ryantm/nixpkgs/archive/759679250bad2423b09c1ff9168405e3a2c73303.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/759679250bad2423b09c1ff9168405e3a2c73303#ibus-engines.typing-booster-unwrapped

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/h8wl4m67kiaffij0sdvbpyly5k28nybx-ibus-typing-booster-2.25.13
ls -la /nix/store/h8wl4m67kiaffij0sdvbpyly5k28nybx-ibus-typing-booster-2.25.13/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

ibus-engines.typing-booster
ibus-engines.typing-booster-unwrapped

Maintainer pings
cc @ncfavier for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/mike-fabian/ibus-typing-booster/releases.
meta.description for ibus-engines.typing-booster-unwrapped is: Completion input method for faster typing
meta.homepage for ibus-engines.typing-booster-unwrapped is: https://mike-fabian.github.io/ibus-typing-booster/
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.25.14 with grep in /nix/store/vi9bighyahkvi1xi4wi66n7d31wj88ds-ibus-typing-booster-2.25.14
found 2.25.14 in filename of file in /nix/store/vi9bighyahkvi1xi4wi66n7d31wj88ds-ibus-typing-booster-2.25.14

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

ibus-engines.typing-booster
ibus-engines.typing-booster-unwrapped

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vi9bighyahkvi1xi4wi66n7d31wj88ds-ibus-typing-booster-2.25.14 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ibus-engines.typing-booster-unwrapped https://github.com/r-ryantm/nixpkgs/archive/44c189f6563cdaaa2e01f6355ae5c2b8617725d0.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/44c189f6563cdaaa2e01f6355ae5c2b8617725d0#ibus-engines.typing-booster-unwrapped

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vi9bighyahkvi1xi4wi66n7d31wj88ds-ibus-typing-booster-2.25.14
ls -la /nix/store/vi9bighyahkvi1xi4wi66n7d31wj88ds-ibus-typing-booster-2.25.14/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

ibus-engines.typing-booster
ibus-engines.typing-booster-unwrapped

Maintainer pings
cc @ncfavier for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/mike-fabian/ibus-typing-booster/releases.
meta.description for ibus-engines.typing-booster-unwrapped is: Completion input method for faster typing
meta.homepage for ibus-engines.typing-booster-unwrapped is: https://mike-fabian.github.io/ibus-typing-booster/
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.25.15 with grep in /nix/store/k1x2zsc2pc3s2rdzwlbwwc2zirqan27l-ibus-typing-booster-2.25.15
found 2.25.15 in filename of file in /nix/store/k1x2zsc2pc3s2rdzwlbwwc2zirqan27l-ibus-typing-booster-2.25.15

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

ibus-engines.typing-booster
ibus-engines.typing-booster-unwrapped

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/k1x2zsc2pc3s2rdzwlbwwc2zirqan27l-ibus-typing-booster-2.25.15 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ibus-engines.typing-booster-unwrapped https://github.com/r-ryantm/nixpkgs/archive/ac58a5e8b51e03b429b21f28afe7497bdd71126c.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/ac58a5e8b51e03b429b21f28afe7497bdd71126c#ibus-engines.typing-booster-unwrapped

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/k1x2zsc2pc3s2rdzwlbwwc2zirqan27l-ibus-typing-booster-2.25.15
ls -la /nix/store/k1x2zsc2pc3s2rdzwlbwwc2zirqan27l-ibus-typing-booster-2.25.15/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

ibus-engines.typing-booster
ibus-engines.typing-booster-unwrapped

Maintainer pings
cc @ncfavier for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 328856 run on aarch64-linux 1

2 packages built:

ibus-engines.typing-booster
ibus-engines.typing-booster-unwrapped


Support Mi Robot Vacuum-Mop 2 Ultra

Device model
dreame.vacuum.p2150a
Device name
Mi Robot Vacuum-Mop 2 Ultra
Does the device require a MiCloud connection?
Yes
Anything special about the device?
It doesnt work with the default tools.

What is the issue currently? Does it not work completely or just partially?

That was my mistake. It works with default settings if your plugin is up to date.


bn2binpad: Use memset as the buffer will be used later

Apparently using OPENSSL_cleanse() confuses the fuzzer so it
makes the buffer to appear uninitialized. And memset can be
safely used here and it is also potentially faster.
Fixes partially #17237

OK, I've decided to not change the semantics so changed the condition to if (tolen != 0).

I don't understand why the PR fixes anything. OPENSSL_cleanse() should
have the same effect as memset, and might even call it.

It works around a false-positive warning from the memory sanitizer reported in #17237,
It is funny that the @shao-hua-li does not use no-asm, therefore it is possible that the
sanitizer is confused by the assembler code that implements the OPENSSL_cleanse function.

Is it?  There is another problem with BIO creation.  Is that the real cause of the complaint?

Is it? There is another problem with BIO creation. Is that the real cause of the complaint?

Please note that the initial report in #17237 did not involve the incorrect patch with the BIO_new_fp(stdout, "w"); call. And it was verified to be fixed by this PR.

It is funny that the @shao-hua-li does not use no-asm, therefore it is possible that the
sanitizer is confused by the assembler code that implements the OPENSSL_cleanse function.

Yeah, that is IMO the case. And there is really no point in using OPENSSL_cleanse here. It should be used only in cases where the cleansed buffer is not going to be used further so there is a possibility that compiler optimization would remove a memset() call.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged to master and 3.0 branches.


Documentation states incorrect permission requirements

It appears that permission is also needed for Glue Tables, and that S3 access needs to include write access as well as read access.
It may be best to advise users to create a specific policy with the correct permissions, scope it to only needed buckets, and assign that to their IAM user.

Also, thanks! This is awesome!


Allow middle click pasting into terminal on Windows and Mac

It seems that this code https://github.com/microsoft/vscode/blob/86cc884a9e1742a3fddd4e8c36b20cbf198d7260/src/vs/workbench/contrib/terminal/browser/terminalEditor.ts#L134 prevents middle click pasting in the terminal on Windows and Mac.
To make the experience more streamlined when changing between different systems, it would be useful to have this possibility.

Tracked in https://github.com/microsoft/vscode/issues/3130, note that some work has happened there and it's looking like we'll be able to support your ask in a mousebindings.json file or similar.


🚦 Command filters!

Pull request

[x] I have read and agreed to the code of conduct.
[x] I have read and complied with the contributing guidelines.
[x] What I'm implementing was assigned to me or was not being worked on and is a somewhat requested feature. For reference see our GitHub projects.
[x] I have tested all of my changes.

Added/Changed

Command filters

Filter a command by the user, role or channel
Both blacklist and whitelist is supported
For filtering, users can select that all conditions have to be correct (AND) or only one of them (OR)

TODO

[x] ;filters commands
[x] ;filters list
[x] ;filters roles
[x] ;filters users
[x] Proper message / not message for when commands are blocked

@weeryan17 Ready to review, just need to finish a language string 👌

;jenkins build

jenkins build


fix: suppress clang -Wdeprecated-declarations in libuv

Electron builds on Windows with clang, not msvc, and likewise hits this issue without this extra handling. This would allow us to remove a patch

Do we actually need to call GetVersionEx? That's the fallback for when RtlGetVersion isn't available but it always is nowadays, isn't it? (Windows Vista and up?)

Actually I think you're right, we should assume it's there these days!

@saghul @bnoordhuis alright - shall i go ahead and just remove GetVersionEx then?

@saghul @bnoordhuis done!

Since we can call the API directly does it still make sense to load the symbol dynamically?

@saghul i was going to ask that actually 😅 personal thought is no, and am happy to refactor that appropriately!

Let's do it yeah 🙌

Since we can call the API directly does it still make sense to load the symbol dynamically?

Yes, because RtlGetVersion is from ntdll.dll, which we don't link against, we GetModuleHandle it. I'd say this PR is good to merge.

Using GetModuleHandle is exactly the same as saying that we link against it. In fact, I think everything must link against ntdll (IIUC, it is the only address range allowed to make syscalls)

Link as in compile-time link. Is ntdll.dll always compile-time linked? Even if, the definition of RtlGetVersion is in ntddk.h or wdm.h so it's probably not available without installing the DDK; e.g. mingw doesn't have it in its headers.

Yes, the GetModuleHandle function only returns compile-time linked modules. It is similar to specifying RTLD_DEFAULT, except that on Windows you always have to give the name of the library to search. I can see it is in ddk/ntddk.h in mingw (which might not be quite the right spot according to the function documentation, but close enough), though being missing from the headers has never been an obstacle to libuv before

So, can this be merged?

By looking at the comments again it seems this PR is good to go. I'll go ahead and merge so it can make it into the release. Please, let me know if it needs to be reverted


How to add a new language?

Hi,
it might be cool to add a "how to add a new language" to the retext plugins. Does a decorated "awesome retext" list anywhere :smiley: ?

Good idea! For now, just the README of retext contains information.
For other languages, I suggest cloning this repo, trashing .git, replacing all instances of simplify with another name (possibly suffixed by a language code? e.g., retext-simplify-nl for dutch), and changing the data!

I would suggest to a add a setLanguage() methode and rename /data/index.json to /data/EN-gb.json and use this as fallback if the given language does not exist. If we clone plugin repos we cannot benefit from improvements authors make in their codes.

Maybe this issue might be more addressed to the https://github.com/wooorm/retext constructor where the plugins could ask for the current language?

I’d rather not build that into retext, it’s not as easy as just specifying languages because sentences and paragraphs can contain multiple languages. It’s not very easy.
And, another problem is the size of packages: my preference is to keep the size low. retext-simplify is 18KB, of which around 17KB is the database. If I were to add other languages, those would significantly increase the size for the English language, and for the other languages themselves.
An alternative would be to publish different packages from one (this) repository. That could also work.
But, for now this is all theoretical; are you in fact considering creating patterns for other languages?

I’d rather not build that into retext, it’s not as easy as just specifying languages because sentences and paragraphs can contain multiple languages. It’s not very easy.

Yes this is true.

And, another problem is the size of packages: my preference is to keep the size low. retext-simplify is 18KB, of which around 17KB is the database. If I were to add other languages, those would significantly increase the size for the English language, and for the other languages themselves.

Well for example Moment.js ships different locales and let the developer decide what they want to deploy in their packages.  https://github.com/moment/moment/tree/develop/locale

are you in fact considering creating patterns for other languages?

Yes I think about to write some text author helping tools for german language. Watching retext for some time and the last missing element was a spelling checker :smile:

Well for example Moment.js ships different [...]

Difference being that moment users (often) need multiple locales at the same time, plus that the localisation is quite small.

Yes I think about to write some text author helping tools for german language [...]

Cool! :+1: Also check out parse-dutch, you’ll probably want to create something like that, for German, too!
For now, I’d say we wait until there are actual translations, before making a decision.


Hyperspeed Accelerators dont seem to import with /wse or in website.

Describe the bug
importing my gear from /wse addon doesnt seem to be account for engineering enchant on gloves, Hyperspeed Accelerators.
Expected behavior
I went to import this, which in game has Hyperspeed Accelerators enchant on my gloves, but it doesnt come in on wowsims website.  So i just manually add it, but still a bug it seems.
{"talents":"000000000000000000-3312212300311212211-3320200000000000000","glyphs":{"minor":[{"spellID":58079},{"spellID":58094},{"spellID":58070}],"prime":[{"spellID":56218},{"spellID":56228},{"spellID":63303}],"major":[{"spellID":56240},{"spellID":63320},{"spellID":63312}]},"class":"warlock","unit":"player","race":"Orc","name":"Dothappy","gear":{"items":[{"id":59449,"gems":[68780,59479,59493],"enchant":4207},{"id":57933,"gems":[]},{"id":60252,"gems":[52207],"enchant":4200},{"id":59457,"gems":[],"reforging":144,"enchant":4115},{"id":65262,"gems":[52207,52217],"reforging":144,"enchant":4102},{"id":60211,"gems":[],"reforging":145,"enchant":4089},{"id":65259,"gems":[52205]},{"id":54503,"gems":[52235,52207],"reforging":167},{"id":60250,"gems":[52205,52207],"enchant":4112},{"id":59234,"gems":[52207],"reforging":151,"enchant":4092},{"id":58188,"gems":[],"reforging":144},{"id":63494,"gems":[],"random_suffix":-114},{"id":59326,"gems":[]},{"id":62047,"gems":[],"reforging":165},{"id":65041,"gems":[],"enchant":4097},{"id":59484,"gems":[]},{"id":59314,"gems":[],"reforging":117}]},"professions":[{"name":"Engineering","level":525},{"name":"Tailoring","level":525}],"level":85,"spec":"demonology","realm":"Mankrik"}
Desktop (please complete the following information):
Chrome, Windows

Accelerators (and all other Engi Tinkers) are NOT enchants, and thus are not on the enchant UI. You can apply a regular enchant + Engi tinkers onto the same item.
They are listed under the Settings tab, in the Engineering section.


Don't allow clearing focus with esc in notebooks

I have to press esc for lots of things while using notebooks - clearing notifications, moving from editor focus to cell focus, dismissing the find widget. I constantly press esc one too many times, which clears notebook focus so focus moves to the first cell in the notebook and I lose my place.
Pressing esc when there is no multiselection should have no effect in a notebook list

https://github.com/microsoft/vscode/issues/121129


Update bundler to esbuild

Background
We bumped to webpack@5. Should we move to esbuild?
Let's weight which one is better, in terms of size and speed (for DX).
esbuild
Our bundle must be ES5. But esbuild emit bundle with ES6+. Thus, after esbuild, we need to transpile the bundle again.
esbuild config to use for isomorphic-react
In our webchat*.js bundle, although we bundled<EMAIL_ADDRESS>if the environment already have a window.React and window.ReactDOM object available, we will prefer them over our own bundled React. This is called "isomorphic React".
We need to configure esbuild to redirect all import 'react' to this isomorphic React package.
Content of esbuild.base.js
const { resolve } = require('path');

const onResolveReact = {
  name: 'isomorphic-react',
  setup(build) {
    build.onResolve({ filter: /^react$/ }, () => {
      return {
        path: resolve('node_modules/isomorphic-react/dist/react.js')
      };
    });

    build.onResolve({ filter: /^react-dom$/ }, () => {
      return {
        path: resolve('node_modules/isomorphic-react/dist/react-dom.js')
      };
    });
  }
};

module.exports = {
  bundle: true,
  entryPoints: ['src/index.js'],
  logLevel: 'info',
  plugins: [onResolveReact],
  sourcemap: true,
  watch: process.argv.slice(2).includes('--watch')
};

Babel config to use on bundle emitted by esbuild
The bundle emitted by esbuild contains many features from ES6+. We need to run Babel again to transpile it back to ES5.
We need to enable a very specific set of plugins. If we enable all plugins via @babel/preset-env, it will cause a conflict with Symbol polyfill from core-js@3.
Content of babel.post.config.json
{
  /*
    These are plugins that can transpile bundle emitted by ESBuild and also compatible with core-js@3.
    Some plugins included by @babel/preset-env will break core-js@3 for Symbol, so we select plugin carefully.

    List of plugins included by @babel/preset-env:
    https://github.com/babel/babel/blob/master/packages/babel-compat-data/scripts/data/plugin-features.js

    If we use @babel/preset-env on the bundle emitted by ESBuild, it will cause this issue.
    https://github.com/zloirock/core-js/issues/514

    The solution is to skip Babel on node_modules/core-js. But in our case, we can't because it is already in the final bundle.
  */
  "plugins": [
    "@babel/plugin-proposal-nullish-coalescing-operator", // This is only needed for --minify build, which emit "??" operator.
    "@babel/plugin-transform-arrow-functions",
    "@babel/plugin-transform-block-scoping",
    "@babel/plugin-transform-destructuring",
    "@babel/plugin-transform-for-of",
    "@babel/plugin-transform-parameters",
    "@babel/plugin-transform-shorthand-properties",
    "@babel/plugin-transform-spread",
    "@babel/plugin-transform-template-literals"
  ],
  "sourceMaps": true
}

Dependencies
jsonwebtoken requires buffer. Since we don't verify the token (we merely check the userId), we should move to jwt-decode instead.
Investigations
Steps to compile:

Babel with @babel/plugin-transform-runtime and inject core-js-pure for usage
Bundle with esbuild
Babel again with @babel/preset-env to convert to ES5
Minify with terser

Some updates:

webpack@5 is much slower than webpack@4 when used in watch mode
esbuild has an internal template that is written in ES6+ (TBD: link to the template file)
We should try running Babel on-the-fly in esbuild to reduce repeated transpilation
corejs@3 is probably needed because we prefer babel/plugin-transform-runtime to scope our polyfills

We should try something outside of Web Chat.

Updates:

Multiple transpilation passes does not work
Although ESBuild do support some ES5 transpilation with ES5-compatible templates, there are some syntaxes not transpiled yet. We probably need to run Babel in front of ESBuild
Babel on-the-fly via ESBuild plugin is very slow, we should run CLI side-by-side
Bundle size by ESBuild is 20-30% larger than Webpack for unknown reasons

Currently in #4330, we are using ESBuild as development server. We should continue to investigate ESBuild for production build with Babel as the transpilation tool.


Tower: Add Open With and migrate to new Raycast API

Description

Added OpenWith action to the repositories, so user can decide to open the repo in different app than the existing options - iTerm and VSCode.
Migrated the source code to the new Raycast API.
Removed not used libraries

Screencast

https://user-images.githubusercontent.com/2267270/154087809-d5063d45-2dc7-4510-be82-bea503f002c4.mp4
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast

Nice one! Thanks for extending!


Remove fixuid from the docker image

The fyne-cross tool has removed the need for using fixuid. We should remove it sometime going forward. Might require new versions as this would be a breaking change for someone using the old tools.

I think this is a very low priority as this will be a breaking change which require bumping up fyne-cross major release and the image too. Making also sure that old version won't pick the new version. I don't see a good reason to go through all this burden.

Yeah, I understand. I simply opened the issue to keep track of it so it doesn't get lost and forgotten.


Update SDK to 4.4.4

update DittoSwiftTools package to v4.4.0

This PR accidentally duplicated existing PR by @kndoshn


DB Json field not decoded in asArray() method

What steps will reproduce the problem?
I have a table called 'Menu' in PostgreSQL, data field has json type. Then I populate one row
$a = Menu::findOne(110);
$b = Menu::find()->where(['id' => 110])->asArray()->one();

$a->data returns an array
$b['data'] returns a string with json inside
What is the expected result?
In my humble opinion, most users expect an Array when they call asArray() method, but somehow it is not decoded as in populate method
Additional info

Q
A

Yii version
<IP_ADDRESS>

PHP version
7.0.28

Operating system
CentOs

Duplicate of #15803 ?

Yes.


Add ziontee113/syntax-tree-surfer

Checklist:

[X] The plugin is specifically built for Neovim.
[X] The lines end with a .. This is to conform to awesome-list linting and requirements.
[X] It's not already on the list.
[ ] If it's a colorscheme, it supports treesitter syntax.
[X] The title of the pull request is Add `username/repo`  when adding a new plugin.

Thanks for the PR!


ValueError: recompute_scale_factor is not meaningful with an explicit size

Hi ,
I am trying to infer only one image ,
Data folder :
/home/HRNet/semantic-segmentation/large_data/data/cityscapes/leftImg8bit_trainvaltest/leftImg8bit/

train : empty
val : empty
test : one image (1920x1080 pixels)

Not able to run command with runx
python3 -m runx.runx scripts/dump_folder.yml -i      :  error : /home/HRNet/bin/python: No module named torch.distributed
So I am running command : python3 -m torch.distributed.launch --nproc_per_node=1 /home/HRNet/semantic-segmentation/train.py --dataset cityscapes --cv 0 --bs_val 1 --n_scales "1.0,2.0" --eval folder --eval_folder '/home/HRNet/semantic-segmentation/large_data/data/cityscapes/leftImg8bit_trainvaltest/leftImg8bit/test/'  --snapshot "ASSETS_PATH/seg_weights/cityscapes_ocrnet.HRNet_Mscale_outstanding-turtle.pth" --arch ocrnet.HRNet_Mscale --result_dir ./save
None
Global Rank: 0 Local Rank: 0
Torch version: 1.7, 1.7.0+cu101
n scales [1.0, 2.0]
dataset = cityscapes
ignore_label = 255
num_classes = 19
Found 1 folder imgs
cn num_classes 19
Using Cross Entropy Loss
Using Cross Entropy Loss
Loading weights from: checkpoint=/home/HRNet/semantic-segmentation/large_data/seg_weights/cityscapes_ocrnet.HRNet_Mscale_outstanding-turtle.pth
Warning:  using Python fallback for SyncBatchNorm, possibly because apex was installed without --cuda_ext.  The exception raised when attempting to import the cuda backend was:  No module named 'syncbn'
=> init weights from normal distribution
=> loading pretrained model /home/HRNet/semantic-segmentation/large_data/seg_weights/hrnetv2_w48_imagenet_pretrained.pth
Trunk: hrnetv2
Model params = 72.1M
Selected optimization level O1:  Insert automatic casts around Pytorch functions and Tensor methods.
Defaults for this optimization level are:
enabled                : True
opt_level              : O1
cast_model_type        : None
patch_torch_functions  : True
keep_batchnorm_fp32    : None
master_weights         : None
loss_scale             : dynamic
Processing user overrides (additional kwargs that are not None)...
After processing overrides, optimization options are:
enabled                : True
opt_level              : O1
cast_model_type        : None
patch_torch_functions  : True
keep_batchnorm_fp32    : None
master_weights         : None
loss_scale             : dynamic
Warning:  multi_tensor_applier fused unscale kernel is unavailable, possibly because apex was installed without --cuda_ext --cpp_ext. Using Python fallback.  Original ImportError was: ModuleNotFoundError("No module named 'amp_C'",)
Warning:  apex was installed without --cpp_ext.  Falling back to Python flatten and unflatten.
Traceback (most recent call last):
File "/home/HRNet/semantic-segmentation/train.py", line 601, in
main()
File "/home/HRNet/semantic-segmentation/train.py", line 426, in main
dump_all_images=True)
File "/home/HRNet/semantic-segmentation/train.py", line 574, in validate
args, val_idx)
File "/home/HRNet/semantic-segmentation/utils/trnval_utils.py", line 142, in eval_minibatch
output_dict = net(inputs)
File "/home/.local/lib/python3.6/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/.local/lib/python3.6/site-packages/apex/parallel/distributed.py", line 560, in forward
result = self.module(*inputs, **kwargs)
File "/home/.local/lib/python3.6/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/HRNet/semantic-segmentation/network/ocrnet.py", line 332, in forward
return self.nscale_forward(inputs, cfg.MODEL.N_SCALES)
File "/home/HRNet/semantic-segmentation/network/ocrnet.py", line 238, in nscale_forward
pred = scale_as(pred, cls_out)
File "/home/HRNet/semantic-segmentation/network/mynn.py", line 79, in scale_as
align_corners=align_corners, recompute_scale_factor=True)
File "/home/.local/lib/python3.6/site-packages/apex/amp/wrap.py", line 28, in wrapper
return orig_fn(*new_args, **kwargs)
File "/home/.local/lib/python3.6/site-packages/torch/nn/functional.py", line 3110, in interpolate
raise ValueError("recompute_scale_factor is not meaningful with an explicit size.")
ValueError: recompute_scale_factor is not meaningful with an explicit size.
Traceback (most recent call last):
File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/.local/lib/python3.6/site-packages/torch/distributed/launch.py", line 260, in
main()
File "/home/.local/lib/python3.6/site-packages/torch/distributed/launch.py", line 256, in main
cmd=cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python3', '-u', '/home/HRNet/semantic-segmentation/train.py', '--local_rank=0', '--dataset', 'cityscapes', '--cv', '0', '--bs_val', '1', '--n_scales', '1.0,2.0', '--eval', 'folder', '--eval_folder', '/home/HRNet/semantic-segmentation/large_data/data/cityscapes/leftImg8bit_trainvaltest/leftImg8bit/test/', '--snapshot', 'ASSETS_PATH/seg_weights/cityscapes_ocrnet.HRNet_Mscale_outstanding-turtle.pth', '--arch', 'ocrnet.HRNet_Mscale', '--result_dir', './save']' returned non-zero exit status 1.
Please help me to solve this error
I am using Ubuntu 18.04
pytorch 1.7
python 3.6
cuda 10.1

Looks like you'll have to modify line 79 of mynn.py to remove the recompute_scale_factor=True arg.

Looks like you'll have to modify line 79 of mynn.py to remove the recompute_scale_factor=True arg.

How to modify ?  I met the same problem, and changed 'recompute_scale_factor' to False.

remove it

Thanks ajtao, it worked.

Is it possible to do inference only on sky and terrain class? if Yes, can you please let me know how to do it?

Hi @SupriyaB1 I'd like to suggest that you try to get more familiar with the code. I bet that with just a few minutes of work you can figure it out.

Thanks @ajtao , I am able to do it now.


Locker won't start without build.json

Hi,
On the latest code, lockerd.js trys to open build.json but this file isn't created or under source control. I've got round it by creating this file with dummy data but I'm not sure what data needs to be in here?
Cheers,
Tom

I'm mobile at the moment, but I believe the makefile should create it, try typing 'make'?
On Feb 28, 2012, at 5:02 AM<EMAIL_ADDRESS>wrote:

Hi,
On the latest code, lockerd.js trys to open build.json but this file isn't created or under source control. I've got round it by creating this file with dummy data but I'm not sure what data needs to be in here?
Cheers,
Tom

Reply to this email directly or view it on GitHub:
https://github.com/LockerProject/Locker/issues/879

Yeah that fixed it thanks.


RSS for extensions

An RSS or RSS like system for updating extensions. You'd paste the link to the feed into a dialogue box in playnite, or they can be embedded into the extension itself, possibly as a "link" in extension.yaml. This could allow for easier updating without manually checking for updates.

https://github.com/JosefNemec/Playnite/issues/1672


Add Ability to List LookupKeys Present in a Credential Store

Currently, the only way to check if a key is available is to try to use it, getting an exception if it isn't present. If would be nice to be able to check before attempting use to allow better client use patterns

It may be better to instead just allow determining if a single, known key is present instead of listing, from a security standpoint

Resolved by #37 - We went with the ability to list, as this further enhances the core mission of allowing interaction and use without requiring decryption for maintence tasks


run_all_when_everything_filtered not working as expected

I've tried implementing run_all_when_everything_filtered along with rspec-retry so that retries only run individual examples instead of whole specs on retry.
On the first run of the spec with rspec --only-failures, it will find no failing tests and hence all examples will be filtered out. I was expecting the run_all_when_everything_filtered option to counteract this, and actually run the tests.
Am I doing something wrong, or am I misunderstanding how run_all_when_everything_filtered works?
My config, shortened for brevity:
# spec/spec_helper.rb
RSpec.configure do |config|
  config.example_status_persistence_file_path = "examples.txt"
  config.run_all_when_everything_filtered = true
end

# rspec --only-failures
Run options: include {:last_run_status=>"failed"}

All examples were filtered out

Randomized with seed 31670

Finished in 1.82 seconds (files took 17.43 seconds to load)
0 examples, 0 failures

Randomized with seed 31670

I'm using Rspec version 3.4.4
UPDATE: Just had a look at the Rspec code, and it seems it's happening because of this line. It actually ignores run_all_when_everything_filtered  if the tests are being run with --only-failures. Why would this be?

See #1941 and #1945.  We decided that since the point of --only-failures is run only failures, it did not make sense to allow the option to run all passing specs instead.  It exits quickly and tells you all examples were filtered out, which allows you to re-run w/o --only-failures if you really want to run all specs.
You're right that it's a bit inconsistent and perhaps confusing--but it would have been more confusing, IMO, to allow a flag like --only-failures to be cancelled out by another config option.  This is especially true when you consider why run_all_when_everything_filtered exists: it was created so that you can leave focus-filtering config in place:
RSpec.configure do |c|
  c.filter_run :focus => true
  c.run_all_when_everything_filtered = true
end

Without run_all_when_everything_filtered, the :focus => true filtering would always be in effect, meaning that nothing would run if nothing was focused.  Not ideal.
Anyhow, as it happens in RSpec 3.5 we're introduced a new filtering option that is meant to replace this setup (and effectively soft-deprecates run_all_when_everything_filtered):
RSpec.configure do |c|
  c.filter_run_when_matching :focus => true
end

This is a conditional filter that only applies when something is tagged with :focus metadata.  The new API allows you to pick on a filter-by-filter basis which should be conditionally applied and which should be unconditionally applied -- where as filter_run_when_matching forced all filtering to be conditional.
See #2260 for the implementation of the new config option and #1920 for some background.  #1920 in particular goes into some of the issues that the semantics of run_all_when_everything_filtered cause -- which is why we are doing away with it.
We plan to remove run_all_when_everything_filtered in RSpec 4, FWIW.

Thanks for the in-depth explanation!


Sorbet does not check the type of default kwargs value of private class methods

Input
→ View on sorbet.run
# typed: strict

class A
  extend T::Sig

  sig {params(x: Integer).void}
  def self.foo(x: nil)
    nil
  end

  sig {params(x: Integer).void}
  private_class_method def self.bar(x: nil)
    nil
  end
end

Observed output
editor.rb:7: Argument does not have asserted type Integer https://srb.help/7005
     7 |  def self.foo(x: nil)
                          ^^^
  Got NilClass originating from:
    editor.rb:7:
     7 |  def self.foo(x: nil)
                          ^^^
Errors: 1

Expected behavior

I expected self.bar's kwarg x default value nil to fail typechecking as its type is declared as non-nilable

Not sure when this is fixed, but I am seeing two errors for this now.

# typed: strict

class A
  extend T::Sig

  sig {params(x: Integer).void}
  def self.foo(x: nil)
    nil
  end

editor.rb:7: Argument does not have asserted type Integer https://srb.help/7007
     7 |  def self.foo(x: nil)
                          ^^^
  Got NilClass originating from:
    editor.rb:7:
     7 |  def self.foo(x: nil)
                          ^^^

editor.rb:12: Argument does not have asserted type Integer https://srb.help/7007
    12 |  private_class_method def self.bar(x: nil)
                                               ^^^
  Got NilClass originating from:
    editor.rb:12:
    12 |  private_class_method def self.bar(x: nil)
                                               ^^^
Errors: 2


Hide index.php from the root folder

index.php should not be listed in the root folder

Resolved.


Please update to LINE OAuth v2

Hey, this is wonderful stuff and really helpful! But it's using a deprecated API, which makes it less helpful. 😢
Any chance this can be updated to LINE OAuth v2?
Thanks a lot!!!!!

@mesqueeb this repo is not under active development although if you'd like to try updating it to Line v2 and sending a Pull Request I'd be happy to review!


Adding AGCE doc links

Hi @j-martens - Could you review the proposed changes? We can move the commit to the private repository if you'd like to see the updates on staging.

@ktoliver & @dciborow - lets close this one and make these changes instead: https://github.com/MicrosoftDocs/azure-docs-pr/pull/95016 .
#please-close

@j-martens, I cannot see the private PR (MicrosoftDocs/azure-docs-pr#95016). At a high-level, what's the triage result?

@md260 Instead of the original proposal, we plan to put in these locations:
Sample and Reference nodes of the table of contents.
And in Next steps of the MLOps concept page.


update packages

:white_check_mark: Build TheIdServer 8.1.0-fix-dependencies.1+52.build.3877 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/b58faadb7f by @invalid-email-address)


AWS::AutoScaling::ScheduledAction add more features

Adding support for:

describe_scheduled_actions: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.describe_scheduled_actions
delete_scheduled_action: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.delete_scheduled_action

Issue
https://github.com/spulec/moto/issues/5335

@bblommers What do you think of this PR?
Thanks!

Codecov Report

Merging #5305 (0f84ad6) into master (c51ff9b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5305      +/-   ##
==========================================
- Coverage   95.99%   95.97%   -0.02%
==========================================
  Files         704      704
  Lines       69898    69972      +74
==========================================
+ Hits        67097    67159      +62
- Misses       2801     2813      +12

Flag
Coverage Δ

servertests
36.02% <24.00%> (-0.01%)
:arrow_down:

unittests
95.92% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/autoscaling/models.py
96.81% <100.00%> (+0.06%)
:arrow_up:

moto/autoscaling/responses.py
99.34% <100.00%> (+0.02%)
:arrow_up:

moto/codebuild/exceptions.py
92.85% <0.00%> (-7.15%)
:arrow_down:

moto/ec2/models/availability_zones_and_regions.py
97.77% <0.00%> (-2.23%)
:arrow_down:

moto/codepipeline/models.py
99.08% <0.00%> (-0.92%)
:arrow_down:

moto/resourcegroupstaggingapi/models.py
82.93% <0.00%> (-0.60%)
:arrow_down:

moto/sns/models.py
96.83% <0.00%> (-0.40%)
:arrow_down:

moto/route53/responses.py
96.05% <0.00%> (-0.33%)
:arrow_down:

moto/efs/models.py
91.07% <0.00%> (-0.30%)
:arrow_down:

moto/sqs/models.py
96.73% <0.00%> (-0.18%)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51ff9b...0f84ad6. Read the comment docs.


About executing extstore exception exit

Hello, when I fuzzed the memcached, I found that the stats extstore command will cause memcached exited abnormally.
When I compild with AddressSanitizer(ASan), I print out these error.
ASAN:DEADLYSIGNAL
=================================================================
==52177==ERROR: AddressSanitizer: SEGV on unknown address 0x0000000000a0 (pc 0x7f3d9f2effd0 bp 0x7f3d9affcee0 sp 0x7f3d9affce88 T2)
==52177==The signal is caused by a READ memory access.
==52177==Hint: address points to the zero page.
    #0 0x7f3d9f2effcf in __pthread_mutex_lock_full (/lib/x86_64-linux-gnu/libpthread.so.0+0x9fcf)
    #1 0x5602e0b55eeb in extstore_get_stats /home/zer0e/memcached/memcached-1.6.9/extstore.c:160
    #2 0x5602e0b5e25d in process_extstore_stats /home/zer0e /memcached/memcached-1.6.9/storage.c:72
    #3 0x5602e0b4555c in process_stat /home/zer0e/memcached/memcached-1.6.9/proto_text.c:718
    #4 0x5602e0b4ae10 in process_command /home/zer0e/memcached/memcached-1.6.9/proto_text.c:2628
    #5 0x5602e0b4cfe3 in try_read_command_ascii /home/zer0e/memcached/memcached-1.6.9/proto_text.c:409
    #6 0x5602e0b036a7 in try_read_command_negotiate /home/zer0e/memcached/memcached-1.6.9/memcached.c:2249
    #7 0x5602e0b0c699 in drive_machine /home/zer0e/memcached/memcached-1.6.9/memcached.c:3014
    #8 0x5602e0b0e0d9 in event_handler /home/zer0e/memcached/memcached-1.6.9/memcached.c:3291
    #9 0x7f3d9f5238f7  (/usr/lib/x86_64-linux-gnu/libevent-2.1.so.6+0x1e8f7)
    #10 0x7f3d9f52433e in event_base_loop (/usr/lib/x86_64-linux-gnu/libevent-2.1.so.6+0x1f33e)
    #11 0x5602e0b2b1e0 in worker_libevent /home/zer0e/memcached/memcached-1.6.9/thread.c:481
    #12 0x7f3d9f2ed6da in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76da)
    #13 0x7f3d9f01671e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0x12171e)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV (/lib/x86_64-linux-gnu/libpthread.so.0+0x9fcf) in __pthread_mutex_lock_full
Thread T2 created by T0 here:
    #0 0x7f3d9f78dd2f in __interceptor_pthread_create (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x37d2f)
    #1 0x5602e0b2fa65 in create_worker /home/zer0e/memcached/memcached-1.6.9/thread.c:369
    #2 0x5602e0b2fa65 in memcached_thread_init /home/zer0e/memcached/memcached-1.6.9/thread.c:1012
    #3 0x5602e0b1877a in main /home/zer0e/memcached/memcached-1.6.9/memcached.c:5741
    #4 0x7f3d9ef16bf6 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6)

==52177==ABORTING

When I read the document, I know extstore is on by default after version 1.6, but need to work with -o ext_path=/path/to/a/ datafile:5G  startup options.
I think maybe should deal with this mistake more friendly, Instead of quit by mistake?
Thanks.

Yup, bug, whoops. thanks! Think I got another report for this as well but I'm behind on maintenance, sorry.

@dormando Oh, glad to get your reply. I read the source code of memcached. I think the code should be added at line 718 of proto_text.c to prevent the program from crashing and exiting.
else if (strcmp(subcommand, "extstore") == 0) {
    if (ext_storage == NULL) {
        out_string(c, "SERVER_ERROR storage file not specified");
        return;
    }
    process_extstore_stats(&append_stats, c);

What do you think of this code change?
Thanks.

Yes, thanks. This is a simple change but I'm in the middle of some larger changes at the moment. I'll get to this as soon as I can.

That's wonderful! Wish you all the best!

This took way too long to get to, sorry. It's queued up for the next release.

Out in 1.6.10

Fixed in commit https://github.com/memcached/memcached/commit/6512edb22e326acdf8267b4d3c0b88fe707bb86f


Length of EQU name limit?

Is there a limit on chars in an EQU?
Trying to debug someone else's code and the build fails error 5 trap, or something like that. Sounds like too much trying to get into too little space.
If so, just add name limit to docs??
May just be similar to file name lengths issues we had.
UPDATE. Seems to fail if more than 32 chars. Feels like a suspicious number!! ;-)
This works:
VDU_5678901234567890123456789012:  equ 136
This does not:
VDU_56789012345678901234567890123:  equ 136
./build.sh: line 24: 62385 Trace/BPT trap: 5       /usr/local/bin/ez80asmm4 "$1" "-l" "-x"

There is a maximum limit of 32 characters on a label. I'll put it in the docs

Good call. Glad that was the likely culprit :-)
I guess that is ANY label?

Any global label indeed; I'll need to check the size maximums for local labels after the @ next

Yes, the same, though technically they might work with longer names depending on their scope. However, supported up to and including 32 characters, updated the docs

These are BIG-ass labels ;-)

He was using things like this:
VDU_SCREENMODE_640x240x16_60HZ_DB:  equ 132
which is big, but understandable.

Totally unrelated, but as I have no other way to contact you anymore, just wondering if you might have any thoughts on my i2c issues and if my thoughts on this 'bug' makes sense???
https://github.com/AgonConsole8/agon-mos/issues/118


implicit lenses

Many of my case-classes have fields that each have unique types. I have a bunch of generic operations over individual fields and I'd like to be able to implicitly lift them over the case class. To do this at the moment, I manually lift them with the lens for the field. However, if the lenses were implicit, I could write this lifting code once and have it discover the right lens implicitly.
Could we have an option to the lens annotation to make the generated lenses implicit? That would cut out a whole world of biolerplate I'm currently writing. The only other way I can fix it is to manually create the lenses and store them in implicits in the companion object of the case class, but this is also brittle biolerplate.

I don't think generated Lenses should be defined as implicit for two reasons:

@Lenses is already doing a lot and I would prefer not to complicate it

I believe that implicit should be globally unique and reserved to type class instances, `Lens` or other `Optics` are not a type class

I could be convinced to mark them as implicit if someone can convince me (on the second point in particular).

@julien-truffaut Pointed out why this is problematic and I agree,
So it will probably not happen.
Can we close the issue?

Yes. We can close this. I need to write up a related abstraction which does
have typeclass instances which can be used to summon the required lens.
On 21 Sep 2015 11:24, "Ilan Godik"<EMAIL_ADDRESS>wrote:

@julien-truffaut https://github.com/julien-truffaut Pointed out why
this is problematic and I agree,
So it will probably not happen.
Can we close the issue?
—
Reply to this email directly or view it on GitHub
https://github.com/julien-truffaut/Monocle/issues/232#issuecomment-141934316
.


sync

📝 Description

🎯 Goals

❌ Non Goals

🚦 Testing

⏮ Backwards Compatibility

📚 Related Issues & Documents

🖼 Screenshots/Recordings

📖 Added to documentation?

[ ] 📜 README.md
[ ] 📑 Documentation
[ ] 📓 Javadoc
[ ] 🍕 Comments
[ ] 🙅 No documentation needed

😄 [optional] What gif best describes this PR or how it makes you feel?

Pan, this is not how to do this :angery:


Add time features for sites

There are trigonometric time features windnet uses instead of sun position which are now not present in site pipeline (see here in datapipes). We should add them and make sun position optinal.

More sepcifcially theya re here - https://github.com/openclimatefix/ocf_datapipes/blob/main/ocf_datapipes/transform/numpy_batch/datetime_features.py#L45


Undefined symbol: H5T_NATIVE_SHORT_g

If you have compiled the netcdf4 and hdf5 libraries statically (in my case, because I want to deploy to AWS Lambda), then the module is built but it cannot be loaded due to missing symbols:
Error: node_modules/netcdf4/build/Release/netcdf4.node: undefined symbol: H5T_NATIVE_SHORT_g
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:718:18)
    at Module.load (internal/modules/cjs/loader.js:599:32)

It turns out this is due to a missing library dependency in binding.gyp, and the solution is to specify the dependent library:
{
  "targets": [
    {
      "libraries": [
        "-lnetcdf",
        "-lhdf5"       # Must specify
      ],
...

I haven't been able to test this with shared libraries (as my environment is only building static ones) but if it doesn't break the shared library build, could this change be included for the benefit of those using static libraries?

I don't think the change could be harmful, especially because hdf5 lib is already a dependency of netcdf, so this change does not add further pre-reqs.
Would you mind doing a PR?

Sorry for the delay with this, PR created.


Add basic support for non-embedded GillSansMT fonts (issue 18801)

Given the following excerpt from the Wikipedia article, mapping this to Helvetica should hopefully be fine:

It has been described as "the British Helvetica" because of its lasting popularity in British design.

/botio test

/botio makeref


Deserialize NestedField initial-default and write-default Attributes

Ensures that these attributes are correctly applied to the NestedField when reading an Iceberg schema json file.
Fixes #1431

Thanks for the great catch @paulcichonski


Download as PDF button

After completing the book our tool generate HTML and JSON file. Two options -

[x]  Add "download as PDF " button in the tool.
[x]  Export the post-edited document to a latex-compatible zip file

Added a download as PDF option in the software. This will generate a PDF file of the correcter/verifier HTML pages in the currently working project with the name "Bookset.pdf", please refer to 06860dca759a78cbcdf7ed2ce1a28b1716f01f41

The stand-alone python application which uses pandoc has been revised and now the tool is functional. Image capabilities has been added and now the generated latex files automatically contains images without any manual addition.


Define a Docker health check

Feature Description
I'd like to use Docker Compose's health checks to bring up the proxy before starting dependent services, but I can't seem to be able to ping the readiness endpoints from within the container image.
It would be awesome if there was a health check defined in the cloud-sql-proxy image itself (see https://docs.docker.com/engine/reference/builder/#healthcheck).
Sample code
No response
Alternatives Considered
I tried pinging the existing readiness endpoint:
services:
  ...
  cloud_sql_proxy:
    ...
    healthcheck:
      test: ['CMD', 'curl', '-f', 'http://localhost:9999/readiness']
      interval: 3s
      timeout: 3s
      retries: 5

However, it seems that curl is not available in the Docker image, and neither is any other utility that would allow one to hit the readiness endpoint.
Additional Details
No response

Hi @GergelyKalmar thanks for raising an issue on the Cloud SQL Proxy 😄
I'll take a look into this and see about adding a built-in health check to the docker image.

I bet the new wait command would be a perfect fit for this: https://github.com/GoogleCloudPlatform/cloud-sql-proxy/pull/2041. @GergelyKalmar Do you think the new wait command would help?
In terms of Kubernetes, I see the Docker healthcheck has been disabled for years now: https://github.com/kubernetes/kubernetes/issues/50703. So I think that means we could safely add a health check to our images without affecting kubernetes.

Got it. I think it would be nice if we could avoiding a dependency on curl or similar, such that people could use this with the distroless container. Maybe cloud-sql-proxy ready that exits 0 or otherwise?


Test ping simplifications

[trickle] Performance differences noted:
Benchmark                                      svr_transport_stalls_per_iteration
---------------------------------------------  ------------------------------------
BM_PumpStreamServerToClient_Trickle/128M/128M  -99%
BM_PumpStreamServerToClient_Trickle/128M/2M    +9999%

[qps] No significant performance differences


Separate the ROI and type for negative control input

Would be a lot easier to manage the negative controls if the ROIs and types (shuffled, sampled, randomized) were separated

Regions: Full, ROI, background
Types: Shuffled, sampled, randomized
Product of the region and types provided as input (e.g. full + shuffled,sampled would make full_shuffled and full_sampled)


Add sphinx auto-generated documentation

This is a first pass at setting up a sphinx-based documentation site.

FYI: going to squash all the commits into one presently...


handling the case of multiple top-level headers

I ran into a weird bug - if you have a page with multiple top-level headers, then the in-page TOC logic breaks down.
This is less-common (though possible) with rST, but consider in markdown a page like this:
My title
========

# My header 1

Content 1

# My header 2

Content 2

In this case, Sphinx will parse all of the headers at the same, top level. Our in-page TOC code assumes that the only top-level header is the title node, and that all other headers are underneath it.
This PR does the following:

Check if there is more than 1 entry in the TOC object. If so, it means there is more than 1 header at the top level.
Assume that the non-title top-level headers are the "true" headers for the document
In the Jinja step, take the non-title top-level headers, and append them to the title's top-level header, so that we can render

The one awkward thing is that if there are other 2nd and 3rd level headers in-between the next 1st-level header, they will be missed in the TOC. Something like this:
My title
========

## My second level

# My header 1

Content 1

# My header 2

Content 2

The TOC would only show "My header 1" and "My header 2".
But I think that's probably the behavior we'd want to encourage?
Lemme know if you'd like me to explain a bit more...I think the longer-term solution will be to make the "get_page_toc" function a little bit less-hacky, but this seems like a reasonable patch for now

@choldgraf Can you rebase this? Or do you directly want to do a different solution as described in https://github.com/pandas-dev/pydata-sphinx-theme/issues/197 ?

closing in favor of https://github.com/pandas-dev/pydata-sphinx-theme/pull/199


Image expand functionality

Image expand functionality

I like it, but I think it also needs the ability to close the modal by clicking outside of the image and/or by hitting the Esc key. Right now you can only close by clicking on X.
Edit: @wladimiiir

I have added both possibilities to close the modal.


Datastore (Walkthrough 5)

Add persistent comments

follow walkthrough to use Datastore
add accordion for comments section
dynamically generate comment accordion components, use key value of Comment entity as unique identifier
update Comment class to have id attribute
display link only if there is one entered
style comments section

Add description component of recommendations

add description textarea
add description property to comment entity
display user input description with original white space
refactor code to append all dynamically generated components at once after they've all been generated
switched window.onload to $(document).ready()

Rotate caret if comment collapse is shown.


cmd/compile: optimize struct reset logic

Consider the following:
type S struct {
	Large [8]int
	Small int
}

var s = new(S)

func BenchmarkResetA(b *testing.B) {
	for i := 0; i < b.N; i++ {
		*s = S{Large: s.Large}
	}
}

func BenchmarkResetB(b *testing.B) {
	for i := 0; i < b.N; i++ {
		s.Small = 0
	}
}

Performance:
BenchmarkResetA
BenchmarkResetA-24    	131323767	         9.117 ns/op
BenchmarkResetB
BenchmarkResetB-24<PHONE_NUMBER>	         0.2167 ns/op

Both snippets are semantically equivalent, but ResetB is much faster.
However, ResetA is common in reset logic where the intention is to reset all fields except a few select fields. This pattern is more maintainable since it properly resets the struct even if new fields are added to it later on.
The compiler should recognize the pattern exhibited in ResetA and avoid the unnecessary copy of s.Large = s.Large.

dup of https://github.com/golang/go/issues/24386?

Also possible related, #24416


Extend customized-homepage setting to Sidebar

Closes #1203
Test: kp
Approach
For now, make the customize-homepage setting the single source of truth, instead of duplicating 2 sets of settings.
Notes

Sidebar: needed a place to put the "customize" button, so I had to introduce a section header to house it. The "manage" button for subscriptions is now styled the same way, which I think looks more structured than having it at the bottom.
"Following" and "FYP" will not appear in the section, because the former is locked at a higher section (honoring that for now) and the latter doesn't have a dedicated page at the moment. Users should be able to figure out what's happening.
When all categories are removed, I left the header there so it's easier to put categories back in. Could be removed if needed, since it's easy to access the customize button from the homepage.

This is looking great! We can probably remove from early feature in a few weeks.
Something to think about is how to introduce new categories when they get created - would they be auto added, or maybe the notification idea you had, or maybe some pop up to 'add to homepage', etc.

My suggestion about using an attribute along side the category wouldn't be backwards compatible, but we can try to time an android release right after if there's no good way (as long as it doesn't make the other version crash). If not, maybe just make a V2, and then we'll sunset the old one.

512d76d to 287e440

Make the feature an "opt-in" one

Rebase


Update marks.lua

If I open it using the GUI file manager, utils.join_path(utils.getcwd(), mp.get_property_native("filename") . ".marks") The result is ~/filename.marks , so change it to mp.get_property_native("path") .. ".marks".
And added "on-screen notifications", it runs on linux platform.

By 'on-screen-notifications' I meant notifications directly in the mpv UI, but this works, so thanks!

By 'on-screen-notifications' I meant notifications directly in the mpv UI, but this works, so thanks!

Just mp.osd_message("message.")
https://mpv.io/manual/stable/#lua-scripting-mp-osd-message(text-[,duration])


how can i know all files are downloaded?

i wanted to know is there a method in fetch that lets you know when your group download is complete and all files in the group is downloaded? so far i have bee doing this by constantly checking the equality of request numbers and number of downloaded files but it takes takes resources to do so

i do this
Group the downloads ie put downloads with the same group in sparsearray
after that you can easily know if the group has finished downloading by doing this
  public int getDownloadCountWithStatus(Status status) {
        int count = 0;
        for (Download download : group) {
            if (download.getStatus() == status) {
                count++;
            }
        }
        return count;
    }

int size = group.size();
if(getDownloadCountWithStatus(Status.COMPLETED) == size){
            return Status.COMPLETED;
 }

i have successfully implemented bunch downloads using that logic

@Moeinh77 Because a download in a group can fail there is no method to call that will tell you when all downloads in a group are downloaded. You can use @duncanokeyo suggestion or
  private Fetch fetch;
    int groupId = 2343; //example group

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_single_download);
        fetch = Fetch.Impl.getDefaultInstance();
        fetch.addListener(groupCompleteFetchListener);
    }

    private final FetchListener groupCompleteFetchListener = new AbstractFetchListener() {
        @Override
        public void onCompleted(@NotNull Download download) {
            if(download.getGroup() == groupId) {
                //Check if all downloads are completed in the group
                checkIfGroupDownloadCompleted(groupId);
            }
        }
    };

    private void checkIfGroupDownloadCompleted(int groupId) {
        fetch.getDownloadsInGroup(groupId, new Func<List<Download>>() {
            @Override
            public void call(@NotNull List<Download> result) {
                int totalDownloads = result.size();
                int completedDownloads = 0;

                for (Download download : result) {
                    if (download.getStatus() == Status.COMPLETED) {
                        completedDownloads += 1;
                    }
                }
                if (totalDownloads == completedDownloads) {
                    //All the downloads in this group are completed.
                }
            }
        });
    }

    @Override
    protected void onResume() {
        super.onResume();
        checkIfGroupDownloadCompleted(groupId);
    }


Temporarily consume https://github.com/crossplane/terrajet/pull/210

Description of your changes

Fixes https://github.com/crossplane/terrajet/issues/209
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

make generate build

@turkenh thank you so much for the quick fix!


pyramidal tiff from save_image_at_spacing.py raises ValueError(f"cant open image {path}")

Hi,
I have generated the pyramidal .tiff with your script save_image_at_spacing.py (https://github.com/DIAGNijmegen/pathology-whole-slide-data/blob/main/scripts/save_image_at_spacing.py). and the mask from the .svs file via QuPath/Fiji.
when I run:

python3 -m hooknettls
hooknettls.default.image_path=/Volumes/hooknet_test/1A1_script.tif
hooknettls.default.mask_path=/Volumes/hooknet_test/1A1_mask.tif

I get this error:
Traceback (most recent call last):
File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/home/user/pathology-hooknet-tls/hooknettls/main.py", line 8, in
objects = build_config(config_reader.read()["default"])
File "/usr/local/lib/python3.8/dist-packages/dicfg/factory.py", line 124, in build_config
return _ObjectFactory(deepcopy(config)).build_config()
File "/usr/local/lib/python3.8/dist-packages/dicfg/factory.py", line 26, in build_config
return self._build(self._configuration)
File "/usr/lib/python3.8/functools.py", line 912, in _method
return method.get(obj, cls)(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/dicfg/factory.py", line 38, in _build_dict
config[key] = self._build_object(value)
File "/usr/local/lib/python3.8/dist-packages/dicfg/factory.py", line 67, in _build_object
return attribute(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/wholeslidedata/iterators/patchiterator.py", line 46, in create_patch_iterator
commander = commander_class(
File "/usr/local/lib/python3.8/dist-packages/wholeslidedata/buffer/patchcommander.py", line 41, in init
wsi = WholeSlideImage(image_path, backend=backend)
File "/usr/local/lib/python3.8/dist-packages/wholeslidedata/image/wholeslideimage.py", line 35, in init
self._backend = get_backend(backend)(path=self._path)
File "/usr/local/lib/python3.8/dist-packages/wholeslidedata/interoperability/asap/backend.py", line 15, in init
raise ValueError(f"cant open image {path}")
ValueError: cant open image /Volumes/hooknet_test/1A1_script.tif
I am unsure if the error is caused but the pyramidal tif or the mask? what is the best way to generate the mask in a pyramidal format?
any help would be greatly appreciated!
thank you so much in advance

Dear Goterm,
Thank you for your interest in HookNet-TLS!
I am not sure what kind of file QuPath/Fiji outputs for the mask. But the mask needs to be a pyramidal tiff file. Please checkout the preprocessing notebook to get such a mask:
https://github.com/DIAGNijmegen/pathology-hooknet-tls/blob/main/hooknettls/preprocessing.ipynb
Please let me know if you have any further questions.
Best wishes,
Mart

Hi,
thanks for the quick feedback.
I have now both pyramidal tifs from both scripts (save_image_at_spacing.py and preprocessing.ipynb).
However, I still get the same error after running (within the provided docker container):
python3 -m hooknettls
hooknettls.default.image_path=/Volumes/hooknet_test/1A1_script.tif
hooknettls.default.mask_path=/Volumes/hooknet_test/1A1_script_mask_script.tif
root@8bd7dc239b13:/# python3 -m hooknettls \

hooknettls.default.image_path=/Volumes/hooknet_test/1A1_script.tif \
hooknettls.default.mask_path=/Volumes/hooknet_test/1A1_script_mask_script.tif

Traceback (most recent call last):
File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/home/user/pathology-hooknet-tls/hooknettls/main.py", line 8, in
objects = build_config(config_reader.read()["default"])
File "/usr/local/lib/python3.8/dist-packages/dicfg/factory.py", line 124, in build_config
return _ObjectFactory(deepcopy(config)).build_config()
File "/usr/local/lib/python3.8/dist-packages/dicfg/factory.py", line 26, in build_config
return self._build(self._configuration)
File "/usr/lib/python3.8/functools.py", line 912, in _method
return method.get(obj, cls)(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/dicfg/factory.py", line 38, in _build_dict
config[key] = self._build_object(value)
File "/usr/local/lib/python3.8/dist-packages/dicfg/factory.py", line 67, in _build_object
return attribute(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/wholeslidedata/iterators/patchiterator.py", line 46, in create_patch_iterator
commander = commander_class(
File "/usr/local/lib/python3.8/dist-packages/wholeslidedata/buffer/patchcommander.py", line 41, in init
wsi = WholeSlideImage(image_path, backend=backend)
File "/usr/local/lib/python3.8/dist-packages/wholeslidedata/image/wholeslideimage.py", line 35, in init
self._backend = get_backend(backend)(path=self._path)
File "/usr/local/lib/python3.8/dist-packages/wholeslidedata/interoperability/asap/backend.py", line 15, in init
raise ValueError(f"cant open image {path}")
ValueError: cant open image /Volumes/hooknet_test/1A1_script.tif

Dear goterm,
Are you running it in a docker? If so can you double check if  /Volumes/hooknet_test/1A1_script.tif  exists. Maybe something went wrong when mounting the /Volumes/ in de docker?
Otherwise it might be that your file cannot be opened. Could you double check that with
from wholeslidedata import WholeSlideImage
wsi = WholeSlideImage("/Volumes/hooknet_test/1A1_script.tif")
print(wsi.spacings)

If all is good, can you send me the original image file before converting to .tif (to mart.vanrijthoven@gmail.com). Then I will try to reproduce your problem.
Best wishes,
Mart


[WIP] Ignore conflicting storage inserts with version="*"

Upsert with DO NOTHING will ignore insert on conflicting key, instead of failing. The intended upside is that transactions with conflicting inserts will not have to be retried anymore, saving unnecessary database processing.
Results do not change, as the new query will still return no rows on conflict, hence the batch insert will be aborted with ErrStorageRejectedVersion.

New query should return success for concurrent writes of identical objects. Had to use ON CONFLICT UPDATE to return a row for this scenario, that's an extra step but it should be better than retrying (additionally, the previous WHERE NOT EXISTS will avoid unnecessary updates for non-concurrent duplicate writes and keep the semantics of rejecting them).

UNION ALL LIMIT 1  variant doesn't unnecessary overwrite row just to return it and can be made to work by checking returned row on the Go side: If returned row is the same which is written, then write succeeds.

This is a behaviour change which needs to be prominently mentioned in release notes and docs. Previously it was possible to use this operation to create distributed lock/ leader election , now it is still possible but written value must be unique for each node

After internal discussion, we determined the current behaviour is actually desirable: "*" must fail on any existing value even if fully identical. This allows Nakama to support use cases such as using a storage object as a lock or signal if needed.
We may however introduce a new OCC operator at some point that allows the write to succeed if the object already existed but the value was identical.


Bug when using sig method that's not T::Sig.sig

Input
→ View on sorbet.run
x = T.let(nil, T.untyped)
x.sig # error: Method sig does not exist on NilClass
x.anything # no error, as expected

Observed output
editor.rb:3: Method sig does not exist on NilClass https://srb.help/7003
     3 |x.sig # error: Method sig does not exist on NilClass
        ^^^^^
Errors: 1

Expected behavior
No errors since x is T.untyped

From Jez in slack:
We move the sig when we shouldn’t:

❯ sorbet -p ast bar.rb
begin
  <emptyTree>
  class <emptyTree><<C <root>>> < (::<todo sym>)
    def self.<static-init><<static-init>$153>(<blk>)
      begin
        x.sig()
        x = begin
          ::Sorbet::Private::Static.keep_for_typechecking(::T.untyped())
          T.let(nil, T.untyped)
        end
        x.anything()
        <emptyTree>
      end
    end
  end
  <emptyTree>
end
No errors! Great job.

@jeffcarbs I might take a stab at this issue since its labeled a good first issue. Any reason not to?

No reason on my end 🙂

A bit stuck, but I think I am making slow progress! If it is something that needs to be done, I would go ahead and move forward with a fix. I don't want to slow anyone down :) I'll keep working on it until I hear otherwise.


[5.6] optimize manifest requests for registry based dependencies (#3929)

cherry pick #3929 into 5.6

@swift-ci test


Invalid Index Error

I am trying to use this module plan giving below error, any patch on this
Version : 0.9.0
╷
│ Error: Invalid index
│
│   on .terraform/modules/vpc_network/modules/network-firewall/main.tf line 86, in resource "google_compute_firewall" "private_allow_all_network_inbound":
│   86:     data.google_compute_subnetwork.public_subnetwork.secondary_ip_range[1].ip_cidr_range,
│     ├────────────────
│     │ data.google_compute_subnetwork.public_subnetwork.secondary_ip_range is list of object with 1 element
│
│ The given key does not identify an element in this collection value.
╵

Apologies for the delay in responding to this issue. Please see below:
Sunset notice
We believe there is an opportunity to create a truly outstanding developer experience for deploying to the cloud, however developing this vision requires that we temporarily limit our focus to just one cloud. Gruntwork has hundreds of customers currently using AWS, so we have temporarily suspended our maintenance efforts on this repo. Once we have implemented and validated our vision for the developer experience on the cloud, we look forward to picking this up. In the meantime, you are welcome to use this code in accordance with the open source license, however we will not be responding to GitHub Issues or Pull Requests.
If you wish to be the maintainer for this project, we are open to considering that. Please contact us at<EMAIL_ADDRESS>

Closing this issue per the message above.


aws-resolver-rules-operator fails to delete resource share

Issue
aws-resolver-rules-operator fails to delete resource share.

I was not capable of reproducing the error.
When deleting a cluster I don't see any errors in the controller related to RAM resources, and the RAM resource was quickly marked as "Deleted" in AWS.


CU#1fxh6bc Test Commit

What
Please provide a short description of the purpose of this pull request.
Why
Explain why the proposed change is necessary.
Task: https://omnivector-solutions.monday.com/boards/XXXX/pulses/YYYY

Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.

Can we close this?

@heitorPB, @zsinx6 I want to leave it open for now because I'm still trying to get the ClickUp integration figured out. Once I have that going, I'll get rid of this PR


[Crashlytics] Fix build issues on visionOS

Fixed Firebase Crashlytics SDK build issues for visionOS, along with corresponding unit test changes. This also resolves build issues with the underlying Firebase Sessions SDK.
#no-changelog

Omitting this for the 10.12.0 release, will re-evaluate in future releases.
cc: @ncooke3 @samedson

Replaced by #11515


Terminal window accidentially shows up when calling system in callback of job_start and ! is in guioptions

Steps to reproduce
/tmp/a.vim:
vim9script
set go=!
job_start("echo", { exit_cb: (..._) => system("echo") })

Invoke gvim with gvim --clean -S /tmp/a.vim, and the statusline appears in the middle of the frame, indicating that vim attempts to show the terminal window.
Meanwhile, the equivalent code in legacy vimscript would only move the cursor to the command line and swallow the next keystroke:
set go=!
call job_start("echo", #{ exit_cb: { ... -> system("echo") } })

Expected behavior
Both invocations should be invisible to users.
vim version: 9.0.542

FWIW, I noticed something similar when using a completion function in issue https://github.com/vim/vim/issues/9759

FWIW, I noticed something similar when using a completion function in issue #9759

Sorry for didn't find that... However, since system() is not intended for users to interact with the subprocess, maybe it shouldn't "leak" the terminal window, just like job_start()?
Or, at least, the behavior should be consistent in legacy script and Vim9...?

since system() is not intended for users to interact with the subprocess, maybe it shouldn't "leak" the terminal window, just like job_start()?  Or, at least, the behavior should be consistent in legacy script and Vim9...?

Yes, I don't think it's expected for a terminal window to be visible.  And even if it is, the type of syntax (legacy vs Vim9) should not matter here.


Add ability to tag particles

Already can group particles by their parents in a topological sense, using graphicle.select.hard_descendants(). At hadronisation vertices, the ancestry becomes mixed, so only using topological information of the generation DAG results particles outgoing from a hadronisation vertex getting equal attribution to each hard parton's descendants entering.
However, the final products of hadronisation form distinct clusters whose centres match the momenta of the hard partons incident to the hadronisation vertex.
Take descendants from DAG, and where there is overlap in ancestry, provide functionality to attribute particles to their nearest parent in delta R.
The interface and data representations for this need careful thought. Considerations are:

overlap only occurs after hadronisation
hadronisation vertices are clearly important, how should these be represented?
hard partons may have descendants incident on multiple hadronisation vertices: should this be transparent in the heritage represented using the masks?
when a W decays into quarks, the quarks are also part of the hard process and may produce distinct jets: should MaskGroups be used to represent the composite nature?

Want to split the leaf-level filtering into functions which act on the lowest level MaskGroup objects. One of them can be partition_hard(), and another could be filter_background(). This could then either be applied after the hierarchy() tree is generated, or during when each leaf-level MaskGroup is complete.
Would also be nice to create an iterator over the leaves of nested MaskGroup trees.

Want to split the leaf-level filtering into functions which act on the lowest level MaskGroup objects. One of them can be partition_hard(), and another could be filter_background(). This could then either be applied after the hierarchy() tree is generated, or during when each leaf-level MaskGroup is complete.
Would also be nice to create an iterator over the leaves of nested MaskGroup trees.

Could levy the strategy pattern to pass the hierarchy() function post-processing functions on the leaves, so both partition_hard() and filter_background() could be passed, but also it would allow user extensibility.

Almost complete, just need to modify the masks so that the hard partons in the latent masks go into their respective children masks, instead. Once that is complete, the PR can be merged, and the new version can be shipped.


shortcut guide will sometimes fall

@GHdemigod we need way more information on this. What version of Windows, PowerToys, what exactly are you seeing past this. Without this, it is too vague and hard for anyone to reproduce

closing due to no author feedback


Having trouble getting the derive attribute

When implementing a custom derive, the DeriveInput structure generated from parsing the input TokenStream doesn't seem to have any derive attributes.  Doing something like what's in the below code will print an empty vec for the attributes.
#[proc_macro_derive(Bar)]
pub fn bar(input: TokenStream) -> TokenStream {
    let input: DeriveInput = syn::parse(input).unwrap();
    panic!( "Attributes:\n{:?}", input.attrs);
}

#[derive(Bar)]
struct Foo;

The above will generate the error:
error: proc-macro derive panicked
  -->
   |
   | #[derive(Bar)]
   |          ^^^
   |
   = help: message: Attributes: []

I'm looking to try and generate a different implementation of a trait based on the other derived traits on an Item.
Thanks.

The compiler does not allow custom derives to see other derives on the same struct. To see the list of derives you would need to implement your macro as a proc_macro_attribute rather than a proc_macro_derive.
#[bar]
#[derive(Copy, Clone)]
struct Foo;

Then this is a non-issue of syn.  I guess a note could be made about this somewhere in the documentation, but I go ahead and close this if you feel otherwise.
Thanks @dtolnay!


collector's bug

Hi,
I have found a bug  want to contribute.
Here's some code
public void Activate() {
for (int i = 0; i < _groups.Length; i++) {
var group = _groups[i];
var groupEvent = _groupEvents[i];
switch (groupEvent) {
case GroupEvent.Added:
group.OnEntityAdded -= _addEntityCache;
group.OnEntityAdded += _addEntityCache;
break;
case GroupEvent.Removed:
group.OnEntityRemoved -= _addEntityCache;
group.OnEntityRemoved += _addEntityCache;
break;
case GroupEvent.AddedOrRemoved:
group.OnEntityAdded -= _addEntityCache;
group.OnEntityAdded += _addEntityCache;
group.OnEntityRemoved -= _addEntityCache;
group.OnEntityRemoved += _addEntityCache;
break;
}
}
}
As you can see, "group.OnEntityRemoved += _addEntityCache;" is add wrong EventHandle

Collector caches entities on Added/Removed/AddedOrRemoved, it looks as intended.

I mean why did group.OnEntityRemoved  and group.OnEntityAdded add the same EventCache

I mean why did group.OnEntityRemoved and group.OnEntityAdded add the same EventCache

group.OnEntityRemoved and group.OnEntityAdded can add to the same HashSet. Based on how Collector was set up.

Think you, I got it wrong.


New method in Randomizer class

Can you add new method in Randomizer class:
public T getRandomValue(EnhancedRandom random);

This is useful if you are generating object and you need to use EnhancedRandom.
Right now I'm using this workaround:
class MyRandomizer implements Randomizer<MyObject>{
    private final EnhancedRandom random;

    MyRandomizer(final EnhancedRandom random) {
        this.random = random;
    }

    @Override
    public MyObject getRandomValue() {
        // ...
    }
}

and in EnhancedRandomBuilder
public class RandomEntity extends EnhancedRandom {
    private final EnhancedRandom random;

    public RandomEntity() {
        random = EnhancedRandomBuilder.aNewEnhancedRandomBuilder()
                         .randomize(MyObject.class, new MyRandomizer(this))
                         .build();
    }

    @Override
    public <T> T nextObject(final Class<T> type, final String... excludedFields) {
        return random.nextObject(type, excludedFields);
    }

    @Override
    public <T> Stream<T> objects(final Class<T> type, final int amount, final String... excludedFields) {
        return random.objects(type, amount, excludedFields);
    }
}

but this solutions creates really weird looking code, that's smells like dead fish.

Can you add new method in Randomizer class:
public T getRandomValue(EnhancedRandom random);

This is a breaking change. Getting a random value using a delegate EnhancedRandom should not be added to the API, but as an implementation of the interface which delegates to a EnhancedRandom  instance. Something like:
public class EnhancedRandomDelegatingRandomizer<T> implements Randomizer<T> {

    private EnhancedRandom delegate;
    private Class<? extends T> type;

    public RandomDelegatingRandomizer(EnhancedRandom delegate, Class<? extends T> type) {
        this.delegate = delegate;
        this.type = type;
    }

    @Override
    public T getRandomValue() {
        return delegate.random(type);
    }
}

What do you think?

that's smells like dead fish

😄

I'm closing this issue. Delegating to a random instance can be done as shown previously, not by adding the delegate as a parameter to the getRandomValue method.


Add opt-in setting for moving to next feed on read

Steps to Reproduce
Click all read butzon
Side drawer opens
Expected behavior
Just mark all as read - open nothing
Screenshots or screen recording
No response
Device, Operating system, and app version
No response

hey @sozifa - this is a new feature i'm testing out. I'll add a setting to disable it in the next release and make it opt-in only. I'll respond here when that's ready.

Fixed in version the latest version, 2024.12.1083.


Should the circle become green during recognition test?

Should the circle turn green during a test recognition? Mine is always red, already rised param to 5 for a more relaxed setting but still red.
It is on ubuntu 21.10 impish

No don't worry, the circle is always red.

Probably good to add at some point but as @EmixamPP said it currently doesn't take any face models into consideration


UseCGroupMemoryLimitForHeap ?

Shouldn't run-java.sh be adding that UseCGroupMemoryLimitForHeap JVM option?
JAVA_OPTIONS=-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap

See fabric8io-images/run-java-sh#27 for discussion about UseCGroupMemoryLimitForHeap JVM option.


[LiveComponent] Forever Scroll

Good morning,
I would like to be able to create a system with Live component to be able to load 50 data on the page and when scrolling 50 other data appear. Or an infinite data load
How to do it knowing that the data I display with ux live component precisely

We actually talk about this topic in here #1515 😁

It's not quite the same, because I would like when I scroll it to display the rest of the data. here is an example,
// src/Components/Products.php

public function __construct(private ProductRepository $productRepository){}

public function getProducts(): array
{
      return $this->productRepository->findAll();
}

        {% for product in this.products %}

{{ product.name }}

        {% endfor %}

I retrieve the list of all my products, I have 2000 I do not want it to load my 2000 products.

I have a demo incoming next week to show you how to do that. If you cannot wait i can send you some quick explanation.

Hello @smnandre,
Yes, I would like a quick explanation if you have 5 minutes.
thanks in advance

I will post there a short example tonight then :)

I will post there a short example ~tonight~ tomorrow then :)

Good morning @smnandre
Would you have 5 minutes to send me a demo regarding my previous request?

I'm working on it during my launch break.. ;)
You can look this upcoming demo: https://github.com/smnandre/ux/tree/site/demo-infinite-scroll
https://<IP_ADDRESS>:8000/demos/live-component/infinite-scroll
Look in "InfiniteCollection" template / component
The idea is to have a custom id for the current page and add data-live-ignore
For the following pages always add a fake previous page.
And wrap all this with an id you'll change when the "context" change (there, the search query).
Sorry i don't have more time right now, but i'll answer later if you have some questions.

@ag-erwan Happy if that helped you :) I'll try to publish it soon-ish, but bug fixes/features always take priority over demos..
Regarding 2.17, I anticipate it could be around the end of the month (without any guarantee)

If you need, you always can use 2.x-dev branch until then !

Hello team
Just to let you know that I have found an alternative solution. Instead of going with an infinite scroll, I went with a pagination that I linked to ux live component here is the code if it can help some of you.
// template/components/paginator.html.twig

{% if pageCount > 1 %}

			{% if first is defined and current != first %}
				<button data-action="live#action" data-live-action-param="nextPreviousPage" data-live-page-param="{{first}}" class="flex items-center justify-center px-4 h-10 ms-0 leading-tight font-bold text-gray-500 bg-white border border-e-0 border-gray-300 rounded-s-lg hover:bg-gray-100 hover:text-gray-700"><<</button>
			{% endif %}

			{% if previous is defined %}
				<button data-action="live#action" data-live-action-param="nextPreviousPage" data-live-page-param="{{previous}}" class="flex items-center justify-center px-4 h-10 leading-tight font-bold text-gray-500 bg-white border border-gray-300 hover:bg-gray-100 hover:text-gray-700"><</button>
			{% endif %}

			{% for page in pagesInRange %}
				{% if page != current %}
					<button data-action="live#action" data-live-action-param="nextPreviousPage" data-live-page-param="{{page}}" class="flex items-center justify-center px-4 h-10 leading-tight font-bold text-gray-500 bg-white border border-gray-300 hover:bg-gray-100 hover:text-gray-700">{{ page }}</button>
				{% else %}
					{{ page }}
				{% endif %}
			{% endfor %}

			{% if next is defined %}
				<button data-action="live#action" data-live-action-param="nextPreviousPage" data-live-page-param="{{next}}" class="flex items-center justify-center px-4 h-10 leading-tight font-bold text-gray-500 bg-white border border-gray-300 hover:bg-gray-100 hover:text-gray-700">></button>
			{% endif %}

			{% if last is defined and current != last %}
				<button data-action="live#action" data-live-action-param="nextPreviousPage" data-live-page-param="{{last}}" class="flex items-center justify-center px-4 h-10 leading-tight font-bold text-gray-500 bg-white border border-gray-300 rounded-e-lg hover:bg-gray-100 hover:text-gray-700">>></button>
			{% endif %}

{% endif %}

public function __construct(private PaginatorInterface $paginator, private ClientRepository $clientRepository)
{}

#[LiveAction]
public function nextPreviousPage(#[LiveArg] int $page)
{
    $this->page = $page;
}

public function getAllData()
{
    return $this->paginator->paginate($this->clientRepository->findAll(), $this->page, 50);
}

For privacy rights, I haven't put the real code, but this is a summary of the code I made.
I hope it can help and inspire some people.
By the way, the paginator is KnpPaginatorBundle


Stefva/sdk update nov

Description
Regenerating the SDK with latest spec changes found here: https://github.com/Azure/azure-rest-api-specs/pull/1928

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@azuresdkci retest this please

@stefanvalianu our CI is currently blocked due to a Jenkins plugin bug.
We are in process of upgrading the plug in and as soon as we are done upgrading, we will have this tested.

cool, thanks for the heads up :)

Looks all good, yea?


how to resend buffer data

Check CONTRIBUTING guideline first and here is the list to help us investigate the problem.

fluentd or td-agent version.  fluentd:0.12
Environment information, e.g. OS.   centos
Your configuration
Your problem explanation. If you have an error logs, write it together.
I use fluentd read and write data to write es, because of es problems, resulting in a lot of chunk underneath worker(some file like buffer.q570**.log and .meta), so I move buffer worker to other disk and  restart fluentd, write recovery normal, now how can I  resend that data, I tried to copy meta and the log files  into the new buffer worker folder, which is not well.

I guess you can use file buffer.
<match **>
  @type elasticsearch
   buffer_type file
   buffer_path /var/log/fluent/myapp.*.buffer
  # ...
</match>

https://docs.fluentd.org/v0.12/articles/buf_file
And this is a question. Github issue is not for questions. Closed.


Not detecting types from structs correctly

Background
Let's imagine I have the following struct in a file called book.ex:
defmodule Book do
  @enforce_keys [:title, :authors]
  defstruct [:title, :authors]

  @type t :: %__MODULE__{
          title: String.t(),
          authors: [String.t()]
        }
end

Now let's define another module that actually uses this:
defmodule DealingWithListsOfLists do
  alias Book

  @spec recommended_books(String.t()) :: [Book]
  def recommended_books(friend) do
    scala = [
      %Book{title: "FP in Scala", authors: ["Chiusano", "Bjarnason"]},
      %Book{title: "Get Programming with Scala", authors: ["Sfregola"]}
    ]

    fiction = [
      %Book{title: "Harry Potter", authors: ["Rowling"]},
      %Book{title: "The Lord of the Rings", authors: ["Tolkien"]}
    ]

    case friend do
      "Alice" -> scala
      "Bob" -> fiction
      _ -> []
    end
  end
end

The careful reader will see that the specification for the recommended_books functions is wrong. It should be returns [Book.t()] and not [Book], which is the struct.
Actual behaviour
$ mix gradient
Typechecking files...
No problems found!

Expected behaviour
It should complain that the specification for the return type is incorrect. Dialyzer does this (although, in quite a cryptic manner):
lib/cb_5.7/dealing_with_lists_of_lists.ex:4:invalid_contract
The @spec for the function does not match the success typing of the function.

Function:
DealingWithListsOfLists.recommended_books/1

Success typing:
@spec recommended_books(_) :: [%Book{:authors => [<<_::56, _::size(8)>>, ...], :title => <<_::64, _::size(8)>>}]

________________________________________________________________________________
done (warnings were emitted)
Halting VM with exit status 2

Thanks, @Fl4m3Ph03n1x!
This is an interesting example of a false negative :+1: Marking it as a bug.

It should complain that the specification for the return type is incorrect.

Or that the returned value is of a wrong type if we assume that specs are the source of truth (they are for Gradient / Gradualizer). In any case, we should get a warning hinting at the discrepancy between the spec and the actual value.
I have a hunch that [Book] in
  @spec recommended_books(String.t()) :: [Book]

is interpreted as a list of atoms Book which is a valid spec, since a singleton atom is a valid type. However, Gradient should then report a warning that the returned list [Book.t()] does not match the declared type [Book]. This needs further investigation.


Fix win/osx makefiles

I'm closing this as we're transitioning to https://github.com/identifi/identifi-daemon


use scala.collection.breakOut to speed up the MapReader

Same behaviour, but skips a Map creation.
See https://docs.scala-lang.org/tutorials/FAQ/breakout.html

Thx


mouse/human gene symbols in CrosstalkeR

Hi,
CrosstalkeR is a great tool for our projects.
I tried the human data and it worked perfect well. but when I tried mouse genes, it seemed to fail to read the gene symbol.
Is it compatible with mouse genes now? or any way to make it work for mouse genes?
Thank you.
below is the error showed in my running:
Annotating the top Cell Genes
'select()' returned 1:many mapping between keys and columns
Error in .testForValidKeys(x, keys, keytype, fks) :
None of the keys entered are valid keys for 'SYMBOL'. Please use the keys method to see a listing of valid arguments.

Dear @Wulin-Tan,
Im more than happy to know that our tool is working for you. We are currently improving CrossTalkeR and a small release might be available by the end of the week.
Hope that it fits to you
Best

the murine data annotation was added to the package


[MM-47629] Don't crash when a run channel has been deleted

Summary
This PR allows for a run page to be visited even if the associated channel has been removed.
Ticket Link
https://mattermost.atlassian.net/browse/MM-47629
Checklist
- [ ] Telemetry updated
- [ ] Gated by experimental feature flag

[x] e2e tests updated

Might we infer that the channel doesn't exist by virtue of channel being undefined?

@lieut-data Unless it's been hard deleted, the channel is returned with deleted_at in this case. Also if I test for the channel neing undefefined to detect hard deletes, I would probably have to add and the request is not pending


JsonResource improvements

https://github.com/amihaiemil/docker-java-api/issues/202

Job #220 is now in scope, role is REV

This pull request #220 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

Pull Request Test Coverage Report for Build 382

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 85.882%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/com/amihaiemil/docker/JsonResource.java
2
38.89%

Totals

Change from base Build 374:
0.0%

Covered Lines:
511

Relevant Lines:
595

💛  - Coveralls

@rultor merge

@rultor merge

@paulodamaso Thanks for your request. @amihaiemil Please confirm this.

@rultor merge it

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 2min)

Job was finished in 3 hours, bonus for fast delivery is possible (see §36)

The job #220 is now out of scope

Order was finished: +20 point(s) just awarded to @paulodamaso/z