Feature/dark mode support

Looks good to me. Though, you may want to consider usingWebSettings.FORCE_DARK_AUTO in some way (possibly by default). Related to #125 .


Fix resizing viz config covering chart

Resizing the visualization config area covers the visualization until screen is refreshed.

After expanding configuration area

After clicking refresh button

#1044 PR adopting designs of wizard app addressed this.


Fatal error install on fresh laravel 5.2 installation

[2016-02-25 10:45:13] local.ERROR: exception 'Symfony\Component\Debug\Exception\FatalErrorException' with message 'Call to undefined method Illuminate\Foundation\Application::bindShared()' in /var/vhosts/project/vendor/zizaco/entrust/src/Entrust/EntrustServiceProvider.php:72
From this answer:
https://laracasts.com/discuss/channels/laravel/call-to-undefined-method-illuminatefoundationapplicationbindshared
In the vendor/zizaco/entrust/src/Entrust/EntrustServiceProvider.php changing the following:
private function registerCommands()
    {
        $this->app->bindShared('command.entrust.migration', function ($app) {
            return new MigrationCommand();
        });
        $this->app->bindShared('command.entrust.classes', function ($app) {
            return new ClassCreatorCommand();
        });
    }

To:
    private function registerCommands()
    {
        $this->app->singleton('command.entrust.migration', function ($app) {
            return new MigrationCommand();
        });
        $this->app->singleton('command.entrust.classes', function ($app) {
            return new ClassCreatorCommand();
        });
    }

The application now loads without issue. I have got no further with the testing though and have not yet starting using the routing options or anything else yet.

Same here & your fix works for me.

That fix worked for me as well, this needs to be pulled into the master branch ASAP for 5.2 installs.

Fix works great, any idea when this will be pulled into master branch?

I found a a few more issue with this plugin and stopped when i found the migration script contains a typo which prevents the tables from being generated.

+1

+1


classifier website using JS

Describe the project
Building three different classifiers with the help of API.
Text Analyzer
Detect Sentiments in the text. It will classify into 3 different categories: Positive, Negative & Neutral.
News Analyzer
Classify News articles by the topic such as Politics, Sports and many more.
Language Analyzer
Detect language in text. I will detect different langauges
Issue Type:

[ ] Bug Report
[ ] Feature Request
[ ] Documentation
[x] New Project

Additional context
Add any other context or screenshots about the project here.
Screenshots

If applicable, add screenshots to help explain your problem.

Please assign me this

@Vanshiii203

@Anubhavgupta14


Automatically setup Docker Builds for newly forked repositories

An idea that I already thought about a couple of times:
It should be possible to use the DockerHub APIv2 to automatically create a DockerHub repository for that pipeline upon creation.
Sets up:

repository + correct name (e.g. nfcore/)
sets build rules accordingly for branches master, dev, and a release version.

Triggers initially on master and dev.

https://github.com/RyanTheAllmighty/Docker-Hub-API

Seems not to be really easy or working at all, barely any information on how to do this:
https://docs.docker.com/registry/spec/api/
This is the endpoint of DockerHub: https://registry-1.docker.io/v2/
So using the V2 API, we should be able to query it - however, authentication remains a problem for me here. Maybe someone else has an idea.... @nf-core/core

The headers for the API auth error look like this:

And reference this URL: https://auth.docker.io/token - which gives a massive token. So I guess it has something to do with this.
But before I go down this rabbit hole - I can't see anything in the docs about creating new repos? It's all pushing and pulling images..?

😆  https://docs.docker.com/registry/spec/auth/ -

Yeah I think the biggest issue here is as well that this API just defines image interaction(s). What we need, would be the Registry / Hub interaction, which doesn't exist. Or I didn't find it (yet).

Best I can find is posts like this and this where people are reverse-engineering the APIs used on the dockerhub website. Doesn't really fill me with confidence - I imagine it could be tricky to set up and is likely to break without warning.. 😕

Here's an NodeJS package for the API which says it can do it: https://github.com/RyanTheAllmighty/Docker-Hub-API#createrepositoryusername-name-details
Someone has made a PHP version here: https://github.com/realpage/waves (looks like there is a method for creating a repo). Not been updated for quite a long time, but might be a good place to start...

Closing, as I don't think this will ever happen with DockerHub. What is much more likely that we will start hosting images on the GitHub package repository. But that's for another day.


bug: Cannot change AM/PM input in ion-datetime

Bug Report
Ionic version:
[x] 4.x
Current behavior:
Cannot change AM/PM input in ion-datetime element.
Expected behavior:
Should be able to change AM/PM input in ion-datetime element.
Steps to reproduce:

cd into cloned github project directory
run ng serve
open website in browser
click rendered ion-datetime element
try to change am/pm input
see "Error parsing date: "[object Object]". Please provide a valid ISO 8601 datetime format: https://www.w3.org/TR/NOTE-datetime" in console

Related code:
https://github.com/godspeed529/datetime-error-parsing-date
Other information:
This regression was introduced in v4.5.0
Ionic info:
Ionic:

   ionic (Ionic CLI)             : 4.12.0 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.5.0
   @angular-devkit/build-angular : 0.13.9
   @angular-devkit/schematics    : 7.3.9
   @angular/cli                  : 7.3.9
   @ionic/angular-toolkit        : 1.5.1

System:

   NodeJS : v10.14.1 (/usr/local/bin/node)
   npm    : 6.9.0
   OS     : macOS Mojave

This regression makes uses of ionic with ion-datetime unusable. We had to issue an update reverted to<EMAIL_ADDRESS>Will this be hotfixed outside of the normal 2 week release cycle?

@brandyscarney can this issue get some love also.  It is blocking our 4.6.x upgrade.

Thanks for the issue! This isn't a regression, it's actually a bug that was uncovered when we fixed another bug oddly enough 🙂.
We are looking into a fix, and I will update this thread when I have more to share.
Thanks!

@liamdebeasi I'm not sure I understand. I don't have this issue on 4.4.2 so in that case it appeared to be working as intended. If there was another bug that was fixed but as a result this happened then I would call that a regression.

In an older version of Ionic (probably around 4.4.2) we fixed a bug where changing the selected month/day/year etc did not refresh the picker values according to the max and min constraints.
That functionality should have been in there from the start, but there was a bug that prevented it from working. Had that bug not been in there, this current bug would have appeared. The AM/PM switching appeared to work only because another part of the datetime functionality was broken.
In reality, switching AM/PM should update which date/time values are displaying in ion-datetime since it is possible a user sets the max value to be something like June 28, 2019 5:30pm. With June 27, 2019 selected, the user should be able to select past 5:30pm but not if June 28, 2019 is selected.
Hope this clears things up. I am currently investigating a fix, and I hope to have it land soon. Thanks!

This might require creating a different issue, but I think it's also wrong that changing the time to 12 changes the amPmColumn to pm automatically since the user has no way of selecting 0 as hour:
export function getValueFromFormat(date: DatetimeData, format: string) {
    if (format === FORMAT_A || format === FORMAT_a) {
        return (date.hour! < 12 ? 'am' : 'pm');
    }
    ...
}

I think the consistent behavior would be to take into account amPm selection and setting the hour to 0 if am is selected instead of 12 changing it to pm

@liamdebeasi - hope you don't mind I added a PR for the AM/PM issue. I hope it helps.
I tried the maxValue feature but unfortunately that only works on HH format. I didn't check the code but from what I saw it just removes the options in the picker columns so for example if you set max="2019-07-01T17:06Z" but use format h:mm a, it won't restrict the hours for that date.
If you use max="2019-07-01T09:06Z", it will restrict the values in both hour and minute column to be lower than 9 and 6 but you will still be able to select 8PM so it's still incorrect.

@topalavlad Thank you! I will take a look at the PR soon.

@liamdebeasi do you have a timeline on this fix?

Also ran into this issue, created a simple repro in codepen: https://codepen.io/corysmc/pen/ydQpbX?editors=1010

We're also running into this issue and is preventing us from a release. A fix for this would be greatly appreciated.

100% in the same boat @CitizenBeta

I just double checked and we're 100% on the latest version<EMAIL_ADDRESS>tested again and can reproduce the bug.

Hoping to merge in the PR with this fix later today. I’ll create a dev build once it is merged for people who need access to the fix before the next release. Thanks!

Thank you @liamdebeasi !!

Thanks @liamdebeasi. Will the dev release be based off of the latest tag 4.6.2 versus master?

Hi everyone,
I have created a dev build with the AM/PM datetime fix. If people could test with their apps and let me know if the issue is resolved for them, that would be great!
Using Angular:
npm i<EMAIL_ADDRESS>
Using Ionic Core:
npm i<EMAIL_ADDRESS>
Thanks!

@liamdebeasi THANK YOU! This does fix the AM/PM being able to be selected; however, it reverts back to AM when you change the day. Minor bug compared to not being able to change AM/PM and very much appreciate the dev build <3

@CitizenBeta Can you provide a test case of AM/PM reverting when changing the day? We are aware of an issue where that happens when changing the hour, but that seems to be unrelated to the changes made here.

@liamdebeasi my mistake, it was on changing the hour.

That fixed it for us @liamdebeasi Thanks!! Will be releasing soon :)

Thanks! This issue has been fixed and will be released in Ionic 4.7.0. 🎉

@liamdebeasi Thanks for this fix.  Can you provide a link to the issue, for tracking, where changing the hour reverts the AM/PM input?  We are seeing this issue now and I don't remember this happening with Ionic 4.4.0.

@liamdebeasi Looks like this issue is there in Ionic 4.4.0.

@godspeed529 this issue was fixed in Ionic 4.7.0. Please update to that version to get the bug fix. Here's the full changelog: https://ionicframework.com/docs/release-notes

@liamdebeasi  I am talking about your comment:

@CitizenBeta Can you provide a test case of AM/PM reverting when changing the day? We are aware of an issue where that happens when changing the hour, but that seems to be unrelated to the changes made here.

@godspeed529 seems to be related to this issue: https://github.com/ionic-team/ionic/issues/18908
Datetime issues are being tracked here: https://github.com/ionic-team/ionic/issues/16630

Added #18924 before I saw the last comment.

@liamdebeasi very good.  i must say that every direct interaction i have had with team Ionic has been confidence inspiring.
that being said i am experiencing some issues upgrading to 4.7.1 and I am wondering whether they may be related to the recently added Angular 8 support.  there is no way I can afford to upgrade to
Angular 8 at the moment considering the NgRx changes it would necessitate, so I am just curious about the risk entailed when using Ionic Angular in these circumstances.  should i be concerned about using Ionic 4.7.1 with the latest Angular 7.2.x/NgRx 7.2.x?
thanks to you and your team for the awesome work and awesome product.
m.

@godspeed529 If you are running into issues, I would recommend creating a new issue and including steps to reproduce. We can take a closer look there, thanks! 🙂

@liamdebeasi Hey there! I have updated to the latest 4.7.1 now and I see that AM/PM are now selectable without any issues. But there still seems to be the issue of PM changing to AM when changing the hour. I am using the format "h mm a". Changing the minutes is fine, but if I change the hour and PM is selected, then it slides it back to AM

I have the same issue as @ShaneJohnsonCC after updating to 4.7.1 and following all angular 8 upgrade steps.
I can now select AM and PM without it glitching out, but anytime I change the hour while on AM it automatically switches to PM. Luckily at least now the user can go back and switch it to AM before submitting - but still very weird behavior


"Running the contributed command: 'zoombar-vscode.zoomIn' failed."

On cmd +/-, I'm frequently getting this warning:

Running the contributed command: 'zoombar-vscode.zoomIn' failed.

However, all seems to be working fine, for example, my custom settings "zoombar.defaultZoom" and "zoombar.zoomUnit" are both honored.
I'm not sure what the warning is about but I thought I'd report it.
UPDATE: I have this in Log (Extension Host):
[2021-06-08 15:28:35.384] [exthost] [error] undefined zoombar-vscode.zoomOut
[2021-06-08 15:28:35.572] [exthost] [error] undefined zoombar-vscode.zoomOut
[2021-06-08 15:28:42.474] [exthost] [error] undefined zoombar-vscode.zoomOut
[2021-06-08 15:28:42.613] [exthost] [error] undefined zoombar-vscode.zoomOut
[2021-06-08 15:29:48.157] [exthost] [error] undefined zoombar-vscode.zoomIn

Unfortunately I'm not sure what's going on.
I would be grateful if you could let me know if you have any additional findings in the future. I also keep this in mind.
I don't know if it's related to this issue, but VS Code have various issues if you change settings frequently in a short amount of time.
Zooming is achieved by changing settings, so quick zooming means changing settings quickly.
When zooming continuously, try to operate slowly.

Thanks. If there was a way I could provide more debug information, I'd be happy to do so.


Button to hide dotfiles/configs in Explorer

Add a button to hide common dotfiles/configs:

Possibly here:

You can hide them with the "files.exclude" setting. Is that like what you are thinking of?

@roblourens yes, I want to achieve the same effect with a button if it makes sense.

Ok so this would be a button to toggle files.exclude, similar to the button we have in search to toggle whether exclude patterns are applied.


Documentation update

Updated JerryScript Internals documentation form section High-Level design to section Virtual Machine.
JerryScript-DCO-1.0-Signed-off-by: István Kádár<EMAIL_ADDRESS>

LGTM

LGTM


Chore(snyk): Fixes snyk security scan on chaos-operator

Signed-off-by: uditgaurav<EMAIL_ADDRESS>What this PR does / why we need it:

Fix snyk security scan on chaos-operator

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Checklist:

[ ] Fixes #
[ ] Labelled this PR & related issue with documentation tag
[ ] PR messages has document related information
[ ] Labelled this PR & related issue with breaking-changes tag
[ ] PR messages has breaking changes related information
[ ] Labelled this PR & related issue with requires-upgrade tag
[ ] PR messages has upgrade related information
[ ] Commit has unit tests
[ ] Commit has integration tests

Let's track the known vulnerability with a dedicated issue!


fix(inline-code): Render whiteSpace: nowrap prop on component if the content does not exceed a certain width.

Closes #358
📝 Description

Remove whiteSpace from the extended theme config as it is now redundant.
Add ref to the component
Import useDimensions hook to retrieve the border-box width
Create a ternary in the whiteSpace prop where if the border-box width is less than or equal to 363, then return the value nowrap else remain at the default value.

The value "363" represents the minimum width of the li element in the Changelog page before the page layout shifts to mobile.
⛳ Current behavior (updates)
The component will force no wrapping of its text no matter the parent container size.
🚀 New behavior
Only instances of the component that are equal to or shorter than 363px wide will receive white-space: nowrap. Because whiteSpace: nowrap value is being determined in the component, remove the instance from the extended theme file's base styles.
💣 Is this a breaking change (Yes/No):
No

@noobinthisgame Hmmm. Working as expected on my end. 🤔
Is there something else I need to check/test to ensure it renders properly every time?

@TylerAPfledderer what browser are you using ? I've checked this on chrome on the deployed preview version. Haven't done anything special tho except checking it in mobile view.

I use Firefox. I've checked with Chrome and see the expected result.
When checking the Vercel preview link in Chrome, I see this:

With a width of 600 it works for me as well. I tried on iphone SE and X and there it breaks again. You could try to add the wordBreak prop when no whitespace prop is set. That might help.

I'll check it out! 😁

@noobinthisgame I'm now viewing localhost on my Pixel 5a with Chrome and I see the issue. wordBreak is not immediately fixing it. I will keep exploring the problem. 👍

@noobinthisgame so I found a strange solution.
Simply flipping the ternary operator!
So instead of
whiteSpace={ dimensions?.borderBox.width <= MIN_CONTENT_WIDTH ? 'nowrap' : '' }

Now:
whiteSpace={ dimensions?.borderBox.width > MIN_CONTENT_WIDTH ? '' : 'nowrap' }

I'm not quite sure why this works. I'll push this change for you to review.

Thanks @noobinthisgame! I will make that update later today.
Would you happen to know why this change worked?

@TylerAPfledderer TBH I've tried to understand but I have no clue. I'd need to check into that deeper :/
It works and that's what matters :D


commit characters don't trigger additionaledits

normally clangd inserts missing includes via additionaledits attached to code completion items, this doesn't seem to be triggered when you commit the completion with any other key than enter though.

coc.nvim has added suggest.acceptSuggestionOnCommitCharacter.


Cydonia Missing Airlock

Cydonia exterior airlock only consist of a single door if this door is opened the atmosphere would vent to the outside

Game Version
<IP_ADDRESS> XBOX
Language
English (EN)
New Game
Yes
Reproduction Steps
go to Cydonia and enter through main airlock

This isn't a bug.


Jenkins/Github needs to send notification when a pull happened from UI ( pull needs to go through review )

I think we need to do it from GitHub , we are already receiving email , when there is a pull.
need a notification that also works for merge.

I don't think you quite got the suggestion: we think there should be a notification is someone commits without a pull request (& ideally if they merge in before a thumbs up too). I've updated the issue.

@klazizpro why closed? I think this still needs doing... :)

Our master branch is now a protected branch, to which all merges must pass through a (green) PR.


Null Safety

Please let us know what is the null safety support status for this plugin.
Thank you.

You can use new version 1.0.0 which support null safety just now.

Thanks for providing support for null safety. 👍


Give wrappers the same owners as the pipeline

This is breaking the 'rebuild' functionality is the wrappers are not deleted when the DependencyBuild is deleted, so subsequent attempts to create the same pipeline run fail due to it already existing.

tekton never came up in the e2e
let's try again
/test jvm-build-service-in-repo-e2e

also curious how fixing rebuild helps with the service registry build
/test jvm-build-service-in-repo-apicurio-e2e

openshift install AWS VPC fail with the apicurio run ... I'll check the openshift slack channels if this is a known situation or if this is just a flake
that said, the normal e2e passed; so I'll merge this before EOB today, but will try an apicurio if it makes sense at least one more time

/test jvm-build-service-in-repo-apicurio-e2e

about the same I guess, give or take
    types.go:25: time: 2022-09-19 18:30:14.743890445 +0000 UTC m=+3876.823370730: dependencybuild FINAL created count: 117 complete count: 93, failed count: 22, contaminated count: 1
merging


Unslick not working as expected

@ubergeoff
https://i.gyazo.com/1d024c67db83cc0f130e5abe2ccd0c3d.mp4
I ran unslick function and all slide item are removed :)

Hi there @chinhphan099 - is this not the correct/expected result..?
If you "unslick" - then do you not wish to destroy/unload the current carousel..?

I want after destroy slider. All HTML element have to back as before init slider. Because when the popup is shown, I'd like to re-init the slider.

I think you have 1 or two options.

Just dont use "unslick" - if you want to keep the the pop-up as before.
OR
If you do "unslick" - then you must reinitialize the the Slick object..?

👍 I can hot fix now. But it better if after unslick, all element still not remove as begin, like Slick Slider (jquery version)

I reinitialize because when I init I have an option of initialSlide, I don't want to use "slickGoTo"

@chinhphan099 - Please can you share an example again..?

Hey @ubergeoff ,
I updated some codes in my repository. In this commit: https://github.com/chinhphan099/chinhphan099.github.io/commit/8f5a51cf547f1fbe374294620c497525c4a4f50b

Optimized at line 578. Remove line 624
Recover original Slide item after unslick.
Move out focus and blur event. Avoid repeating focus and blur events when re-init slick slider. Then update the called function to:
_.$slider.addEventListener('focus', _.focus);
_.$slider.addEventListener('blur', _.blur);

demo: https://chinhphan099.github.io/slick-vanilla/index.html
console log run: commentSlick.unslick(); to destroy
Re-slick: var commentSlick = new Slick(document.querySelector('.comments--root .w_inner'), {infinite: false});

@ubergeoff hey! amazing work with this
How can I use the slick events? I'm trying this:
slider.$slider.addEventListener('beforeChange', (event, slick, currentSlide, nextSlide) => {
            console.log(event, slick, currentSlide, nextSlide);
        });

but args slick, currentSlide, nextSlide are empty.
Same happens with the rest of the events.


Add image registry and repository separation

It would be beneficial to add image source options to trust-manager in the same way that cert-manager has them.
For example, in cert-manager, each workload image has the following structure in the template and values file.
Template snippet:
containers:
        - name: {{ .Chart.Name }}-controller
          {{- with .Values.image }}
          image: "{{- if .registry -}}{{ .registry }}/{{- end -}}{{ .repository }}{{- if (.digest) -}} @{{ .digest }}{{- else -}}:{{ default $.Chart.AppVersion .tag }} {{- end -}}"
          {{- end }}

values.yaml snippet:
image:
  repository: quay.io/jetstack/cert-manager-controller
  # You can manage a registry with
  # registry: quay.io
  # repository: jetstack/cert-manager-controller

  # Override the image tag to deploy by setting this variable.
  # If no value is set, the chart's appVersion will be used.
  # tag: canary

  # Setting a digest will override any tag
  # digest: sha256:0e072dddd1f7f8fc8909a2ca6f65e76c5f0d2fcfb8be47935ae3457e8bbceb20

Repository and tag are the only options available on trust-manager.
Motivation
I deploy cert-manager and trust-manager together as sub-charts of a parent chart, and need to serve images from a private registry. Having this feature will allow a single registry to be configured once and declared as a yaml anchor, and referenced as an alias for cert-manager and trust-manager.

/kind feature


buildPythonPackage: document why we always propagate python

python applications should not propagate python in PATH but we do it
nevertheless to avoid rebuilds see https://github.com/NixOS/nixpkgs/issues/170887
for an explanation.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I don't think that few extra rebuilds is such a big issue here. What's probably is a real issue is that those rebuilds might require the applications to stop providing the python modules and vice versa. Otherwise we may get double references if both the pythonPackage and its tooling are pulled in by a derivation.

I don't think that few extra rebuilds is such a big issue here. What's probably is a real issue is that those rebuilds might require the applications to stop providing the python modules and vice versa. Otherwise we may get double references if both the pythonPackage and its tooling are pulled in by a derivation.

Simply wrapping applications would mean a tiny additional derivation instead of a larger rebuild.


TO BE CLOSED

Pls

Pls2

Pls3

Pls

Pls2

Pls3

Pls4

Pls5

Pls6

Pls7

Pls8

Pls9

Pls10

test1

run

run

run

run test

e

run

run2

runtest

testrun

tty

run!

test1

test2

test3

test4

test5

test6

test7

test8

test9

test10

test11

gta-runner test1

gta-runner test1

gta-runner test2 { "testing-in": "This is a string!" }

gta-runner test1

gta test1

gta-runner

gta-runner

gta-runner test1

gta-runner test1

gta-runner test2 { "testing-in": "This is a string!" }

gta-runner test2 { "testing-in": "This is a string!" }

gta-runner test2 { "testing-in": "This is a string!" }

gta-runner test1


Seems not working on mobile browsers

Tried to use on mobile browsers but it doesn't work.
It always renders loading component. No errors.

Interesting. I haven't deployed this on mobile at all but I'll test it out. Any particular OS and browser combination so that I can try reproducing what you're experiencing?

I think thats all the same, used different versions. Both on Android and IOS. Safari, Chrome.
fyi also tried your demo project for that, just broadcasting with vite --host.

@jkgenser  Have you had a chance to look at this?

@jkgenser Have you had a chance to look at this?

No, not yet.

@jkgenser Have you had a chance to look at this?

I just tried logging in to my application that uses this library on mobile. Using android and chrome and the PDF viewer was able to load.

@jkgenser Have you had a chance to look at this?

I just tried logging in to my application that uses this library on mobile. Using android and chrome and the PDF viewer was able to load.

That's great it is working, then the problem is related to bundling I guess.
I use Next 14 and deployed on Vercel. But it doesn't work on local environment as well.
Does your app using Nextjs ?

@jkgenser Have you had a chance to look at this?

I just tried logging in to my application that uses this library on mobile. Using android and chrome and the PDF viewer was able to load.

That's great it is working, then the problem is related to bundling I guess. I use Next 14 and deployed on Vercel. But it doesn't work on local environment as well.
Does your app using Nextjs ?

I am using Vite in my build. Do you have any details on what exactly isn't working, e.g. from console?
In your build, have you tested that it works on web and it's only mobile that doesn't work?

I have some logic that manually fetches the worker code
import * as pdfjs from 'pdfjs-dist';

export async function fetchWithRetry(
  url: string,
  retries: number = 2,
): Promise<void> {
  const attemptFetch = async (attempt: number): Promise<void> => {
    try {
      const response = await fetch(url);
      if (!response.ok) {
        throw new Error(`HTTP error! status: ${response.status}`);
      }
      const workerScript = await response.text();
      const blob = new Blob([workerScript], { type: 'application/javascript' });
      const workerUrlBlob = URL.createObjectURL(blob);
      pdfjs.GlobalWorkerOptions.workerPort = new Worker(workerUrlBlob);
      pdfjs.GlobalWorkerOptions.workerSrc = workerUrlBlob;
    } catch (error) {
      if (attempt < retries) {
        console.log(`Retrying fetch... Attempt ${attempt + 1}`);
        await attemptFetch(attempt + 1);
      } else {
        console.error('Error loading PDF worker script', error);
        pdfjs.GlobalWorkerOptions.workerSrc = url;
      }
    }
  };

  await attemptFetch(0);
}

import { useEffect } from 'react';
import { create } from 'zustand';
import { fetchWithRetry } from '../api/pdf';

interface FetchState {
  isPdfWorkerFetched: boolean;
  setIsFetched: () => void;
}

export const usePdfFetchedStore = create<FetchState>((set) => ({
  isPdfWorkerFetched: false,
  setIsFetched: () => set({ isPdfWorkerFetched: true }),
}));

const usePdfWorker = ({ pdfWorkerUrl }: { pdfWorkerUrl: string }) => {
  const { setIsFetched } = usePdfFetchedStore();
  useEffect(() => {
    const loadPdfWorker = async () => {
      try {
        await fetchWithRetry(pdfWorkerUrl, 3);
        setIsFetched();
      } catch (error) {
        console.error('Failed to load PDF worker script:', error);
      }
    };

    loadPdfWorker();
  }, []);
};

export default usePdfWorker;

I've seen a lot of different ways for apps to fetch the worker. That's one of the most common ways that using pdf.js can get tripped up. You can read more about other ways to try a worker fetch setup that works for you here: https://github.com/wojtekmaj/react-pdf (this library depends on)

I wrote a script to copy build file into /public folder during CI, in this way it works on web browsers
pdfjs.GlobalWorkerOptions.workerSrc =<EMAIL_ADDRESS>
There is another issue saying Promise.withResolvers is not defined, which is probably related to the nodejs version used next. Let me try the worker loading code you have shared and share the result

@jkgenser
Solved this issue by injecting this polyfill and using legacy build of pdfjs-dist
pdfjs.GlobalWorkerOptions.workerSrc =<EMAIL_ADDRESS>

export function promisePolyfill() {
  if (typeof Promise.withResolvers === 'undefined') {
    if (typeof window !== 'undefined') {
      // @ts-ignore
      Promise.withResolvers = function () {
        let resolveFunc: (value: any) => void;
        let rejectFunc: (reason?: any) => void;

        const promise = new Promise((resolve, reject) => {
          resolveFunc = resolve;
          rejectFunc = reject;
        });

        return {
          promise,
          resolve: resolveFunc!,
          reject: rejectFunc!,
        };
      };
    }
  }
}

@jkgenser
Closing this issue since its not related to the library


KAFKA-15972: Add support to exclude labels for telemetry metrics (KIP-714)

Changes in the PR are to support excluding client_id label when sending telemetry metrics.
Some of the labels/tags which are present in metric should be skipped while collecting telemetry as data might already be known to broker hence, we should minimize the data transfer. One of such labels is client_id which is already present in RequestContext hence broker can append that label prior emitting metrics to telemetry backend.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@AndrewJSchofield @mjsax @wcarlson5 @philipnee - Minor PR to exclude client client_id label in metrics.

Build passed with flaky tests.


[Web][Html]: SweepGradient not rendering correctly

Steps to Reproduce

Run the attached file in HTML web renderer.
flutter run -d chrome --web-renderer html

you can see the reported issue.
Example.zip
Expected results:

Actual results:

Logs

D:\Git\example\lib>flutter run --verbose
[ +107 ms] executing: [C:\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +88 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[   +1 ms] b22742018b3edf16c6cadd7b76d9db5e7f9064b5
[   +1 ms] executing: [C:\flutter/] git tag --points-at b22742018b3edf16c6cadd7b76d9db5e7f9064b5
[  +62 ms] Exit code 0 from: git tag --points-at b22742018b3edf16c6cadd7b76d9db5e7f9064b5
[   +1 ms] 2.2.0
[   +8 ms] executing: [C:\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +49 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[   +1 ms] origin/stable
[        ] executing: [C:\flutter/] git ls-remote --get-url origin
[  +44 ms] Exit code 0 from: git ls-remote --get-url origin
[   +1 ms] https://github.com/flutter/flutter.git
[ +170 ms] executing: [C:\flutter/] git rev-parse --abbrev-ref HEAD
[  +51 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] stable
[ +140 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +4 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +90 ms] executing: C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l
[  +73 ms] List of devices attached
           emulator-5554          device product:sdk_gphone_x86_arm model:sdk_gphone_x86_arm device:generic_x86_arm transport_id:1
[   +9 ms] C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell getprop
[  +78 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +7 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +45 ms] Changing current working directory to: D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example
[  +95 ms] Skipping pub get: version match.
[ +174 ms] Generating
D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\android\app\src\main\java\io\flutter\plugins\GeneratedP
luginRegistrant.java
[ +105 ms] ro.hardware = ranchu
[  +19 ms] Using hardware rendering with device sdk gphone x86 arm. If you notice graphics artifacts, consider enabling software
rendering with
           "--enable-software-rendering".
[  +61 ms] Initializing file store
[  +16 ms] Skipping target: gen_localizations
[  +10 ms] complete
[   +6 ms] Launching lib\main.dart on sdk gphone x86 arm in debug mode...
[   +7 ms] C:\flutter\bin\cache\dart-sdk\bin\dart.exe --disable-dart-dev
C:\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root
C:\flutter\bin\cache\artifacts\engine\common\flutter_patched_sdk/ --incremental --target=flutter --debugger-module-names
--experimental-emit-debug-metadata -DFLUTTER_WEB_AUTO_DETECT=true --output-dill
C:\Users\RATHAN~1\AppData\Local\Temp\flutter_tools.7e5400a\flutter_tool.435d9907\app.dill --packages
D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\.dart_tool\package_config.json -Ddart.vm.profile=false
-Ddart.vm.product=false --enable-asserts --track-widget-creation --filesystem-scheme org-dartlang-root --initialize-from-dill
build\3c113a45063dc6628e68a4111abcacad.cache.dill.track.dill --enable-experiment=alternative-invalidation-strategy
[  +28 ms] executing: C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell -x logcat -v
time -t 1
[  +25 ms] <- compile package:example/main.dart
[ +108 ms] --------- beginning of kernel
                    06-10 11:51:21.144 D/logd    (    0): logdr: UID=2000 GID=2000 PID=7377 n tail=1 logMask=99 pid=0 start=0ns
                    timeout=0ns
[  +19 ms] executing: C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\platform-tools\adb.exe version
[  +37 ms] Android Debug Bridge version 1.0.41
           Version 31.0.2-7242960
           Installed as C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\platform-tools\adb.exe
[   +5 ms] executing: C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\platform-tools\adb.exe start-server
[  +39 ms] Building APK
[  +36 ms] Running Gradle task 'assembleDebug'...
[  +19 ms] Using gradle from D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\android\gradlew.bat.
[  +39 ms] executing: C:\Program Files\Android\Android Studio\jre\bin\java -version
[ +215 ms] Exit code 0 from: C:\Program Files\Android\Android Studio\jre\bin\java -version
[   +1 ms] openjdk version "11.0.8" 2020-07-14
           OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
           OpenJDK 64-Bit Server VM (build 11.0.8+10-b944.6842174, mixed mode)
[   +4 ms] executing: [D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\android/]
D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\android\gradlew.bat -Pverbose=true
-Ptarget-platform=android-x86 -Ptarget=D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\lib\main.dart
-Pdart-defines=RkxVVFRFUl9XRUJfQVVUT19ERVRFQ1Q9dHJ1ZQ== -Pdart-obfuscation=false -Ptrack-widget-creation=true
-Ptree-shake-icons=false -Pfilesystem-scheme=org-dartlang-root assembleDebug
[+1682 ms] Welcome to Gradle 5.6.2!
[   +1 ms] Here are the highlights of this release:
[        ]  - Incremental Groovy compilation
[        ]  - Groovy compile avoidance
[   +1 ms]  - Test fixtures for Java projects
[        ]  - Manage plugin versions via settings script
[  +10 ms] For more details see https://docs.gradle.org/5.6.2/release-notes.html
[+4855 ms] > Task :app:compileFlutterBuildDebug
[  +23 ms] [ +173 ms] executing: [C:\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[   +4 ms] [ +160 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[   +5 ms] [        ] b22742018b3edf16c6cadd7b76d9db5e7f9064b5
[   +1 ms] [   +1 ms] executing: [C:\flutter/] git tag --points-at b22742018b3edf16c6cadd7b76d9db5e7f9064b5
[        ] [ +106 ms] Exit code 0 from: git tag --points-at b22742018b3edf16c6cadd7b76d9db5e7f9064b5
[   +1 ms] [        ] 2.2.0
[  +32 ms] [  +13 ms] executing: [C:\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +81 ms] [  +73 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[   +3 ms] [        ] origin/stable
[        ] [        ] executing: [C:\flutter/] git ls-remote --get-url origin
[        ] [  +95 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] [        ] https://github.com/flutter/flutter.git
[   +1 ms] [ +143 ms] executing: [C:\flutter/] git rev-parse --abbrev-ref HEAD
[   +1 ms] [  +60 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[   +1 ms] [        ] stable
[  +98 ms] [ +197 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[  +51 ms] [        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[   +3 ms] [        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] [   +6 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] [  +13 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[   +3 ms] [        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] [   +1 ms] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[   +1 ms] [   +5 ms] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[   +1 ms] [        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +286 ms] [ +299 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[   +1 ms] [        ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[        ] [   +7 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[   +1 ms] [        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +1 ms] [        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +1 ms] [        ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[        ] [        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[   +2 ms] [        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[   +1 ms] [        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[   +1 ms] [        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[   +1 ms] [   +1 ms] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[   +1 ms] [        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[   +1 ms] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[   +1 ms] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[   +2 ms] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[   +1 ms] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] [        ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[   +4 ms] [        ] Artifact Instance of 'PubDependencies' is not required, skipping update.
[  +63 ms] [  +79 ms] Initializing file store
[ +109 ms] [  +79 ms] Skipping target: gen_localizations
[  +45 ms] [  +19 ms] kernel_snapshot: Starting due to {}
[   +7 ms] [  +32 ms] C:\flutter\bin\cache\dart-sdk\bin\dart.exe --disable-dart-dev
C:\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root
C:\flutter\bin\cache\artifacts\engine\common\flutter_patched_sdk/ --target=flutter --no-print-incremental-dependencies
-DFLUTTER_WEB_AUTO_DETECT=true -Ddart.vm.profile=false -Ddart.vm.product=false --enable-asserts --track-widget-creation
--no-link-platform --packages
D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\.dart_tool\package_config.json --output-dill
D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\.dart_tool\flutter_build\740501c8319ab47755d4133d75b86f
ec\app.dill --depfile
D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\.dart_tool\flutter_build\740501c8319ab47755d4133d75b86f
ec\kernel_snapshot.d package:example/main.dart
[+17033 ms] [+17111 ms] kernel_snapshot: Complete
[ +703 ms] [ +708 ms] debug_android_application: Starting due to {}
[ +291 ms] [ +258 ms] debug_android_application: Complete
[ +911 ms] [ +963 ms] Persisting file store
[  +92 ms] [  +25 ms] Done persisting file store
[   +1 ms] [  +15 ms] build succeeded.
[   +1 ms] [  +35 ms] "flutter assemble" took 19,708ms.
[ +292 ms] [ +270 ms] ensureAnalyticsSent: 262ms
[   +2 ms] [   +2 ms] Running shutdown hooks
[   +1 ms] [   +1 ms] Shutdown hooks complete
[   +1 ms] [        ] exiting with code 0
[ +294 ms] > Task :app:packLibsflutterBuildDebug
[   +1 ms] > Task :app:preBuild UP-TO-DATE
[   +1 ms] > Task :app:preDebugBuild UP-TO-DATE
[        ] > Task :app:compileDebugAidl NO-SOURCE
[        ] > Task :app:checkDebugManifest
[ +109 ms] > Task :app:compileDebugRenderscript NO-SOURCE
[   +1 ms] > Task :app:generateDebugBuildConfig
[        ] > Task :app:cleanMergeDebugAssets UP-TO-DATE
[        ] > Task :app:mergeDebugShaders
[   +1 ms] > Task :app:compileDebugShaders
[        ] > Task :app:generateDebugAssets
[   +2 ms] > Task :app:mergeDebugAssets
[ +484 ms] > Task :app:copyFlutterAssetsDebug
[   +1 ms] > Task :app:mainApkListPersistenceDebug
[   +1 ms] > Task :app:generateDebugResValues
[        ] > Task :app:generateDebugResources
[+1503 ms] > Task :app:createDebugCompatibleScreenManifests
[ +500 ms] > Task :app:processDebugManifest
[   +2 ms] > Task :app:processDebugJavaRes NO-SOURCE
[ +192 ms] > Task :app:checkDebugDuplicateClasses
[+1336 ms] > Task :app:validateSigningDebug
[ +262 ms] > Task :app:signingConfigWriterDebug
[ +472 ms] > Task :app:desugarDebugFileDependencies
[   +6 ms] > Task :app:mergeDebugJniLibFolders
[ +608 ms] > Task :app:mergeDebugResources
[+5014 ms] > Task :app:processDebugResources
[+16189 ms] > Task :app:compileDebugKotlin
[ +402 ms] > Task :app:mergeDebugNativeLibs
[   +2 ms] Unable to strip library
'D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\build\app\intermediates\merged_native_libs\debug\out\l
ib\x86\libflutter.so' due to missing strip tool for ABI 'X86'. Packaging it as is.
[ +408 ms] > Task :app:stripDebugDebugSymbols
[   +1 ms] Compatible side by side NDK version was not found.
[   +1 ms] Unable to strip library
'D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\build\app\intermediates\merged_native_libs\debug\out\l
ib\x86_64\libflutter.so' due to missing strip tool for ABI 'X86_64'. Packaging it as is.
[   +2 ms] > Task :app:javaPreCompileDebug
[+2023 ms] > Task :app:compileDebugJavaWithJavac
[   +2 ms] > Task :app:compileDebugSources
[+1665 ms] > Task :app:transformClassesWithDexBuilderForDebug
[   +3 ms] > Task :app:mergeExtDexDebug
[ +586 ms] > Task :app:mergeDebugJavaResource
[ +800 ms] > Task :app:mergeDexDebug
[+4805 ms] > Task :app:packageDebug
[ +226 ms] > Task :app:assembleDebug
[   +1 ms] BUILD SUCCESSFUL in 1m 4s
[        ] 31 actionable tasks: 30 executed, 1 up-to-date
[ +634 ms] Running Gradle task 'assembleDebug'... (completed in 65.6s)
[  +52 ms] calculateSha: LocalDirectory:
'D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\build\app\outputs\flutter-apk'/app.apk
[ +929 ms] √  Built build\app\outputs\flutter-apk\app-debug.apk.
[  +13 ms] executing: C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\build-tools\30.0.3\aapt dump xmltree
D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\build\app\outputs\flutter-apk\app.apk
AndroidManifest.xml
[  +60 ms] Exit code 0 from: C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\build-tools\30.0.3\aapt dump xmltree
D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\build\app\outputs\flutter-apk\app.apk
AndroidManifest.xml
[   +3 ms] N: android=http://schemas.android.com/apk/res/android
             E: manifest (line=2)
               A: android:versionCode(0x0101021b)=(type 0x10)0x1
               A: android:versionName(0x0101021c)="1.0.0" (Raw: "1.0.0")
               A: android:compileSdkVersion(0x01010572)=(type 0x10)0x1c
               A: android:compileSdkVersionCodename(0x01010573)="9" (Raw: "9")
               A: package="com.example.example" (Raw: "com.example.example")
               A: platformBuildVersionCode=(type 0x10)0x1c
               A: platformBuildVersionName=(type 0x10)0x9
               E: uses-sdk (line=7)
                 A: android:minSdkVersion(0x0101020c)=(type 0x10)0x10
                 A: android:targetSdkVersion(0x01010270)=(type 0x10)0x1c
               E: uses-permission (line=14)
                 A: android:name(0x01010003)="android.permission.INTERNET" (Raw: "android.permission.INTERNET")
               E: application (line=22)
                 A: android:label(0x01010001)="example" (Raw: "example")
                 A: android:icon(0x01010002)=@0x7f080000
                 A: android:name(0x01010003)="io.flutter.app.FlutterApplication" (Raw: "io.flutter.app.FlutterApplication")
                 A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff
                 A: android:appComponentFactory(0x0101057a)="androidx.core.app.CoreComponentFactory" (Raw:
                 "androidx.core.app.CoreComponentFactory")
                 E: activity (line=28)
                   A: android:theme(0x01010000)=@0x7f0a0000
                   A: android:name(0x01010003)="com.example.example.MainActivity" (Raw: "com.example.example.MainActivity")
                   A: android:launchMode(0x0101001d)=(type 0x10)0x1
                   A: android:configChanges(0x0101001f)=(type 0x11)0x40003fb4
                   A: android:windowSoftInputMode(0x0101022b)=(type 0x11)0x10
                   A: android:hardwareAccelerated(0x010102d3)=(type 0x12)0xffffffff
                   E: intent-filter (line=35)
                     E: action (line=36)
                       A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN")
                     E: category (line=38)
                       A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER")
                 E: meta-data (line=45)
                   A: android:name(0x01010003)="flutterEmbedding" (Raw: "flutterEmbedding")
                   A: android:value(0x01010024)=(type 0x10)0x2
[  +10 ms] Stopping app 'app.apk' on sdk gphone x86 arm.
[   +1 ms] executing: C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell am
force-stop com.example.example
[ +122 ms] executing: C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell pm list
packages com.example.example
[  +92 ms] package:com.example.example
[   +3 ms] executing: C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell cat
/data/local/tmp/sky.com.example.example.sha1
[  +86 ms] 04bac02d995a6a60f3665c9e453aecfee1feb147
[   +2 ms] Installing APK.
[   +2 ms] Installing ..\build\app\outputs\flutter-apk\app.apk...
[        ] executing: C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 install -t -r
D:\Git\Latest\flutter-gauges\flutter_gauges\syncfusion_flutter_gauges\example\build\app\outputs\flutter-apk\app.apk
[+1387 ms] Performing Streamed Install
                    Success
[   +2 ms] Installing ..\build\app\outputs\flutter-apk\app.apk... (completed in 1,388ms)
[   +2 ms] executing: C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell echo -n
8dd05af081004a28ab1c7d8f5d2605b38a944680 > /data/local/tmp/sky.com.example.example.sha1
[ +115 ms] executing: C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell -x logcat -v
time -t 1
[ +834 ms] --------- beginning of system
                    06-10 11:52:30.060 W/Looper  (  515): Slow dispatch took 106ms android.fg h=android.os.Handler
                    c=runnable@9bd181f(com.android.server.policy.PermissionPolicyService@9d6e76c,1001) m=0
[  +11 ms] executing: C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell am start -a
android.intent.action.RUN -f 0x20000000 --ez enable-background-compilation true --ez enable-dart-profiling true --ez
enable-checked-mode true --ez verify-entry-points true com.example.example/com.example.example.MainActivity
[ +458 ms] Starting: Intent { act=android.intent.action.RUN flg=0x20000000 cmp=com.example.example/.MainActivity (has extras) }
[   +4 ms] Waiting for observatory port to be available...
[+3686 ms] Observatory URL on device: http://<IP_ADDRESS>:37293/6_6FIFVaJmk=/
[   +3 ms] executing: C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 forward tcp:0
tcp:37293
[  +43 ms] 56603
[   +1 ms] Forwarded host port 56603 to device port 37293 for Observatory
[  +15 ms] Caching compiled dill
[  +67 ms] Connecting to service protocol: http://<IP_ADDRESS>:56603/6_6FIFVaJmk=/
[ +922 ms] Launching a Dart Developer Service (DDS) instance at http://<IP_ADDRESS>:0, connecting to VM service at
http://<IP_ADDRESS>:56603/6_6FIFVaJmk=/.
[ +281 ms] DDS is listening at http://<IP_ADDRESS>:56607/zdMwnxlqOuI=/.
[ +135 ms] Successfully connected to service protocol: http://<IP_ADDRESS>:56603/6_6FIFVaJmk=/
[  +50 ms] DevFS: Creating new filesystem on the device (null)
[ +163 ms] DevFS: Created new filesystem on the device (file:///data/user/0/com.example.example/code_cache/exampleMAWCCY/example/)
[   +6 ms] Updating assets
[ +205 ms] Syncing files to device sdk gphone x86 arm...
[   +8 ms] <- reset
[        ] Compiling dart to kernel with 0 updated files
[   +5 ms] <- recompile package:example/main.dart e25b58d5-d026-4660-893a-af678ebbf689
[   +1 ms] <- e25b58d5-d026-4660-893a-af678ebbf689
[ +163 ms] Updating files.
[   +1 ms] DevFS: Sync finished
[   +1 ms] Syncing files to device sdk gphone x86 arm... (completed in 182ms)
[   +1 ms] Synced 0.0MB.
[   +2 ms] <- accept
[  +32 ms] Connected to _flutterView/0xf6941c20.
[   +7 ms] Flutter run key commands.
[   +4 ms] r Hot reload.
[   +1 ms] R Hot restart.
[   +1 ms] h Repeat this help message.
[   +3 ms] d Detach (terminate "flutter run" but leave application running).
[   +2 ms] c Clear the screen
[   +2 ms] q Quit (terminate the application on the device).
[   +2 ms]  Running with sound null safety
[   +3 ms] An Observatory debugger and profiler on sdk gphone x86 arm is available at: http://<IP_ADDRESS>:56607/zdMwnxlqOuI=/
[+2024 ms] The Flutter DevTools debugger and profiler on sdk gphone x86 arm is available at:
                    http://<IP_ADDRESS>:9101?uri=http%3A%2F%2F<IP_ADDRESS>%3A56607%2FzdMwnxlqOuI%3D%2F

D:\Git\example\lib>flutter analyze
Analyzing lib...
No issues found! (ran in 2.6s)

D:\Git\example\lib>flutter doctor -v
[√] Flutter (Channel stable, 2.2.0, on Microsoft Windows [Version 10.0.19042.928], locale en-US)
    • Flutter version 2.2.0 at C:\flutter
    • Framework revision b22742018b (4 weeks ago), 2021-05-14 19:12:57 -0700
    • Engine revision a9d88a4d18
    • Dart version 2.13.0

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\RathanaKumarSekar\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Professional 2019 16.9.4)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional
    • Visual Studio Professional 2019 version 16.9.31205.134
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[√] VS Code (version 1.56.2)
    • VS Code at C:\Users\RathanaKumarSekar\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension can be installed from:
       https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (4 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • Windows (desktop)           • windows       • windows-x64    • Microsoft Windows [Version 10.0.19042.928]
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 91.0.4472.77
    • Edge (web)                  • edge          • web-javascript • Microsoft Edge 90.0.818.49

• No issues found!

Thanks for the detailed report and code sample. Verified this on latest stable and master and issue persists with html rendering.

With canvaskit:

With html:

 flutter doctor -v
dhs@Dhss-MacBook-Pro ncflutter % flutter doctor -v
[✓] Flutter (Channel master, 2.3.0-17.0.pre.296, on Mac OS X 10.15.4 19E2269
    darwin-x64, locale en-GB)
    • Flutter version 2.3.0-17.0.pre.296 at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d744bcc52e (30 minutes ago), 2021-06-10 05:44:03 -0400
    • Engine revision ab2955e7e5
    • Dart version 2.14.0 (build 2.14.0-194.0.dev)

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.56.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (3 available)
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                               •
      web-javascript • Google Chrome 91.0.4472.77

• No issues found!

Adding an additional sample - it appears that SweepGradient is implemented but it is being clipped to the shape size without inflating to account for the stroke width.
DartPad


[Feature Request]: Migrate documentation/*.md to wiki

In the /documentation folder are present some markdown files with HowTos. The same information is stored on luci wiki. There is some divergences like something is converted from Wiki format to Markdown and something isn't. Also in some places information seems more old that in other source.
So I tried to synchronize them and now Wiki contains latest version.
Please review those articles and remove the documentation from sources to avoid collisions.

@jow- I think the configuration should be maintained in the source. And not in a separate system.
@stokito Thanks for working to maintain this in the Wiki
It's a matter of time until the Wiki is no longer synchronous. A Solution would be that we update the feature CI/CD to generate the doku and push this to a proper place.

Technically speaking WIki is also can be accessed as a git repo. You can clone it like git clone https://github.com/openwrt/luci.wiki.
I agree that GitHub's WIki has few problems:

Nobody ever looking into the WIki. It should be some link in README that refer to the WIKI page i.e. Read the Wiki https://github.com/openwrt/luci/wiki.
When you cloned sources that would be nice to have docs or examples just in place. When you searching for something you may find the doc.
When you changing or renaming something in sources then the IDE (like CLion) can show you that you probably should rename this in documentation.

As a pros for the WIki:

It's easy to change it: I updated those docs without sending any PRs
The docs are moved out from sources and this makes cloning the repo a little bit faster especially for CI.
It becomes searchable by Google and other crawlers and anybody can read it directly from website.

would it be possible to include the wiki as a submodule in a folder named docs? Or would that be to clumsy to keep updated?

yes, that's possible and I guess that's will be a good solution

The only con (if that's what you wanna call it) I can for see is that documentation would have to be edited via the wiki?

I tried but I got 403 error and it looks like only collaborators can do pushes to master.
Also it looks like that you can't create PRs for Wiki. This is a big limitation.


Package the code and check open source specifications

Setup function to install the package locally
Pipy package
Continuous integration

The pypi package shoud superset https://pypi.org/project/plasp/

For CI, add unit test, syntax setting and profiling

Version 1.0.0 has been uploaded to pypi


[VCDA-4773] Update kubectl commands in managerment cluster.md (#329)

Description
Please provide a brief description of the changes proposed in this Pull Request

Update kubectl commands in docs

Checklist

[x] tested locally
[ ] updated any relevant dependencies
[ ] updated any relevant documentation or examples

API Changes
Are there API changes?

[ ] Yes
[x] No

If yes, please fill in the below

Updated conversions?

[ ] Yes
[ ] No
[ ] N/A

Updated CRDs?

[ ] Yes
[ ] No
[ ] N/A

Updated infrastructure-components.yaml?

[ ] Yes
[ ] No
[ ] N/A

Updated ./examples/capi-quickstart.yaml?

[ ] Yes
[ ] No
[ ] N/A

Updated necessary files under ./infrastructure-vcd/v1.0.0/?

[ ] Yes
[ ] No
[ ] N/A

Issue
If applicable, please reference the relevant issue
Fixes #

This change is

Closing this PR as it is no longer needed


Section Control On Esp32

Hello, I’m trying to implement the SC features on my generic ESP32 board. The VT and TC connect to the server (on my tractor) correctly. SC even starts working because I can see that my tractor sends PGN messages through the UART debug, and I can observe the setpoint value when I enter a zone where the sections should be off.
However, I don’t receive any messages when the sections should be on. I even performed a CAN trace, identified the ID that sends the DDI commands, and verified the correct message when the sections should be off. But when the sections should be on, it’s not working.
What could be the issue? Could it be something related to the DDOP settings during the TC setup?
I used the Seeder And TC client example from stack just a little changes for ESP32

Can you please include a CAN trace? We'll need to see the DDOP upload and the subsequent commands to get a full picture of what's happening.
It's probably something simple, like the section control or prescription state being 0....

First of all, thank you so much for taking the time to respond, especially during the New Year. You've done an excellent job with this stack—it’s truly impressive!
I included the file containing the CAN trace and checked the ID where the DDIs appear, which is 0x0CCB80F7. After starting the trace, I initiate the task and enter and exit the area where the sections are supposed to run twice.
When checking the Setpoint DDI ID, I noticed that the Setpoint DDI only comes when exiting the area, but no value is observed upon entering. I debugged this using a printf statement I added to the value callback, and the value output in the terminal is -65536. This indicates that the desired value for 8 sections (the target count) has its bits zeroed out when converted to binary. As I mentioned, I only get this value when the sections are supposed to be off.
case static_caststd::uint16_t(isobus::DataDescriptionIndex::SetpointCondensedWorkState241_256):
{
std::uint16_t sectionIndexOffset = NUMBER_SECTIONS_PER_CONDENSED_MESSAGE * (DDI - static_caststd::uint16_t(isobus::DataDescriptionIndex::SetpointCondensedWorkState1_16));
printf("PROCESS VAL : %ld\n", processVariableValue);
for (std::uint_fast8_t i = 0; i < NUMBER_SECTIONS_PER_CONDENSED_MESSAGE; i++)
{
sim->set_section_state(sectionIndexOffset + i, (0x01 == (processVariableValue >> (2 * i) & 0x03)));
}
}

Additionally, I also checked the SectionControl DDI, and its value is as expected: 1.
The issue I suspect, though I’m not completely sure, is that the TC server might always consider the unit states to be on, and it only sends the command when they go off. However, I can’t get any request commands to report this to TC. It might be something missing during the initialization of DDOP or TC. I used the example code provided with the stack, but could this be related to the ESP32?
I also tried another Seeder example and faced issues with std::vector<> variables returning incorrect sizes. For instance, no matter which unit count I set, it always returned 16. I'm not entirely sure if this is related to the issue.
canout.txt


Reva update v1.4.1-0.20201127111856-e6a6212c1b7b

Fix capabilities response for multiple client versions #1331 [cs3org/reva#1331](Fix capabilities response for multiple client versions #1331)
Fix home storage redirect for remote.php/dav/files cs3org/reva#1342

https://drone.owncloud.com/owncloud/ocis/1812/26/7
  Scenario Outline: Uploading file to a user read/write share folder works                                             # /srv/app/testrunner/tests/acceptance/features/apiShareOperationsToShares/uploadToShare.feature:95
    Given using <dav-path> DAV path                                                                                # FeatureContext::usingOldOrNewDavPath()
    And user "Brian" has been created with default attributes and skeleton files                                       # FeatureContext::userHasBeenCreatedWithDefaultAttributes()
    And user "Alice" has created a share with settings                                                                 # FeatureContext::userHasCreatedAShareWithSettings()
      | path        | FOLDER |
      | shareType   | user   |
      | permissions | change |
      | shareWith   | Brian  |
    And user "Brian" has accepted share "/FOLDER" offered by user "Alice"                                              # FeatureContext::userHasReactedToShareOfferedBy()
    When user "Brian" uploads file "filesForUpload/textfile.txt" to "/Shares/FOLDER/textfile.txt" using the WebDAV API # FeatureContext::userUploadsAFileTo()
    Then the HTTP status code should be "201"                                                                          # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the content of file "/FOLDER/textfile.txt" for user "Alice" should be:                                         # FeatureContext::contentOfFileForUserShouldBePyString()
      """
      This is a testfile.

      Cheers.
      """

    Examples:
      | dav-path |
      | old      |
      | new      |
        The downloaded content was expected to be 'This is a testfile.

        Cheers.', but actually is ''. HTTP status was 500
        Failed asserting that two strings are equal.
        --- Expected
        +++ Actual
        @@ @@
        -'This is a testfile.\n
        -\n
        -Cheers.'
        +''

Hmmm - is that 500 status a new thing, or a "random" fail of something?

drone.owncloud.com/owncloud/ocis/1812/26/7
  Scenario Outline: Uploading file to a user read/write share folder works                                             # /srv/app/testrunner/tests/acceptance/features/apiShareOperationsToShares/uploadToShare.feature:95
    Given using <dav-path> DAV path                                                                                # FeatureContext::usingOldOrNewDavPath()
    And user "Brian" has been created with default attributes and skeleton files                                       # FeatureContext::userHasBeenCreatedWithDefaultAttributes()
    And user "Alice" has created a share with settings                                                                 # FeatureContext::userHasCreatedAShareWithSettings()
      | path        | FOLDER |
      | shareType   | user   |
      | permissions | change |
      | shareWith   | Brian  |
    And user "Brian" has accepted share "/FOLDER" offered by user "Alice"                                              # FeatureContext::userHasReactedToShareOfferedBy()
    When user "Brian" uploads file "filesForUpload/textfile.txt" to "/Shares/FOLDER/textfile.txt" using the WebDAV API # FeatureContext::userUploadsAFileTo()
    Then the HTTP status code should be "201"                                                                          # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the content of file "/FOLDER/textfile.txt" for user "Alice" should be:                                         # FeatureContext::contentOfFileForUserShouldBePyString()
      """
      This is a testfile.

      Cheers.
      """

    Examples:
      | dav-path |
      | old      |
      | new      |
        The downloaded content was expected to be 'This is a testfile.

        Cheers.', but actually is ''. HTTP status was 500
        Failed asserting that two strings are equal.
        --- Expected
        +++ Actual
        @@ @@
        -'This is a testfile.\n
        -\n
        -Cheers.'
        +''

Hmmm - is that 500 status a new thing, or a "random" fail of something?
I restarted drone CI.

oh wow, weird, thanks for restarting

https://drone.owncloud.com/owncloud/ocis/1812/26/7
  Scenario Outline: Uploading file to a user read/write share folder works                                             # /srv/app/testrunner/tests/acceptance/features/apiShareOperationsToShares/uploadToShare.feature:95
    Given using <dav-path> DAV path                                                                                # FeatureContext::usingOldOrNewDavPath()
    And user "Brian" has been created with default attributes and skeleton files                                       # FeatureContext::userHasBeenCreatedWithDefaultAttributes()
    And user "Alice" has created a share with settings                                                                 # FeatureContext::userHasCreatedAShareWithSettings()
      | path        | FOLDER |
      | shareType   | user   |
      | permissions | change |
      | shareWith   | Brian  |
    And user "Brian" has accepted share "/FOLDER" offered by user "Alice"                                              # FeatureContext::userHasReactedToShareOfferedBy()
    When user "Brian" uploads file "filesForUpload/textfile.txt" to "/Shares/FOLDER/textfile.txt" using the WebDAV API # FeatureContext::userUploadsAFileTo()
    Then the HTTP status code should be "201"                                                                          # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the content of file "/FOLDER/textfile.txt" for user "Alice" should be:                                         # FeatureContext::contentOfFileForUserShouldBePyString()
      """
      This is a testfile.

      Cheers.
      """

    Examples:
      | dav-path |
      | old      |
      | new      |
        The downloaded content was expected to be 'This is a testfile.

        Cheers.', but actually is ''. HTTP status was 500
        Failed asserting that two strings are equal.
        --- Expected
        +++ Actual
        @@ @@
        -'This is a testfile.\n
        -\n
        -Cheers.'
        +''

Hmmm - is that 500 status a new thing, or a "random" fail of something?
I restarted drone CI.

It passed on the second run (and I restarted as well without paying close attention.. but passed there as well). So it seems to  be a random failure @phil-davis


codeAction and executeCommand

I'm trying to figure out how textDocument/codeAction and workspace/executeCommand
are supposed to work together.
I think what should happen when code is selected and a command is ran like extractMethod is as follows:

Client sends a codeAction request to the server when text is selected. It contains the start/end range of the code selected. (I believe the server needs to store this information somewhere and update it whenever changed.)
The users uses a command like extractMethod. The client would send a executeCommand to the server that contains the command name and some arguments. (Still haven't figured out if you can add your own arguments to this request)
The server would run the command and send a workspace/applyEdit to the client to finalize the changes.

Is this correct so far? Does anything further need to happen? Document Syncing or anything ?
Thanks

This is a tricky part of the API right now. I documented my own adventures understanding it here: https://github.com/Microsoft/language-server-protocol/issues/144#issuecomment-345467473
It sounds like you're on the right track. You can use WorkspaceEdit.documentChanges (in supporting clients) to send over the intended starting versions of the documents in your change.

@rictic Cool ill check that out. Its a little weird I think that codeAction sends over all available commands each time. I would have thought these would be pre-registered somewhere.
I tried looking at other language servers for examples like the python one for example. I don't think it behaves this way at all.
Another confusing thing is, Having codeActions causes the lightbulb icon to appear on text selection. I haven't dug enough into that yet to see if there is a way to filter it or not.

@willt What do you mean by "pre-registered"? The server should only send the commands that are relevant to the selection back to the client. The server does however need to state all the commands that it supports in its ExecuteCommandOptions when responding to an initialize request.
What you described is exactly how it's done in my Dockerfile language server. Feel free to take a look at the server's code and the actual implementation of the analysis of the diagnostics and the commands. I don't currently support versioned edits via WorkspaceEdit's documentChanges though.
The light bulb issue has been brought up before. Please see Microsoft/vscode#33241, Microsoft/vscode#33459, and Microsoft/vscode#33555. The final comment is probably what's most relevant as it is the latest update on the issue. Please also see #389 regarding the necessary work to incorporate it into the language server protocol's specification.

@rcjsuen Thanks for a link to your code. I will check it out. Okay so are you saying when the server receives a codeAction request it would evaluate what text is selected and then decide what commands to send back to the client?
If that's correct, do you know if there is a way of dynamically enabling commands in the context menu of vscode ? I know when you setup the commands in package.json you can do "when": "editorHasSelection && editorLangId == python" but I don't think you can dynamically change that can you ?

What I don't understand is how the client is supposed to know when the "command" has finished executing. Like what if the user changes the document between "applyEdit" commands from the server? It just seems too racy.

@willt Yes, the CodeActionParams includes a Range as well as a context with a Diagnostic[] array so you should only send back what is relevant instead of all your commands.
And no, I don't know the answer to your second question. I haven't dabbled in the art of writing VS Code extensions myself.
@puremourning Right now the response to a workspace/executeCommand is either any | null so you are correct that it is ambiguous as to when it has truly finished. Regarding changes to the document "in between" things happening you should version your edits via the method @rictic described in his earlier comment.

Versioned edits don’t help from the user perspective. What should we do? Just refuse to apply the codeaction of it changed? What if it is partially applied? Would we even know that given the other problem of the separate channel for the actions vs the request.
Ideally the API would be that the apply command request returns an array of actions to perform. That solves all the problems.

What should we do? Just refuse to apply the codeaction of it changed? What if it is partially applied?

Yes. The client should never partially apply an edit. It should be atomic.

Would we even know that given the other problem of the separate channel for the actions vs the request

workspace/executeCommand is a request, not a notification, so the server can report errors in running the command.
It would be a nice feature if getCodeActions could return workspace/applyEdit rather than sending down a command that is then passed right back to the server. I believe one argument for the current workflow is that the command the server sends down could be much terser than a workspace/applyEdit, which can get pretty big.

Also see #178 which suggests augmenting the textDocument/codeAction request to return a Command[] or a WorkspaceEdit though I realize some of the people here are already aware of that issue.

What should we do? Just refuse to apply the codeaction of it changed? What if it is partially applied?
Yes. The client should never partially apply an edit. It should be atomic.

if we don't know when the full set of edits has been delivered for a command, how is this possible?
let's say the server issues two edit requests, with an arbitrary delay between them.
when the client receives edit 2, let's say something has changed, but edit 1 has already been applied. Thus you have a torn command with no way for the client to protect it.

I believe one argument for the current workflow is that the command the server sends down could be much terser than a workspace/applyEdit, which can get pretty big.

If executeCommand returned an array of WorkspaceEdit, or something, rather than issuing a completely unrelated set of messages with no restriction on when or how they are delivered, this would all be trivial and there would be no issue. As it stands, unless i'm (still!) missing something important, there's just a huge race condition with the current protocol.

if we don't know when the full set of edits has been delivered for a command, how is this possible?
let's say the server issues two edit requests, with an arbitrary delay between them.
when the client receives edit 2, let's say something has changed, but edit 1 has already been applied. Thus you have a torn command with no way for the client to protect it.

If you have a set of edits that must all be applied atomically then they must be sent down as a single workspace/applyEdit command, not two separate ones.

If executeCommand returned an array of WorkspaceEdit, or something, rather than issuing a completely unrelated set of messages with no restriction on when or how they are delivered, this would all be trivial and there would be no issue. As it stands, unless i'm (still!) missing something important, there's just a huge race condition with the current protocol.

A single WorkspaceEdit should be enough. Maybe that's the missing piece? A WorkspaceEdit contains any number of changes to make to any number of files, so there is no need to return an array of WorkspaceEdits.
(Ok, that's not entirely true. I've lobbied in the past for the option for workspace/applyEdit to take an array of workspace edits, where each edit is considered atomic but the client is free to apply only a subset of the edits, but I believe that's unrelated to the discussion here)

Sure. If the server is required to produce a single WorkspaceEdit and nothing else, then why can’t that be the response to the executeCommand request? Otherwise Cthulhu.

See also https://github.com/Microsoft/language-server-protocol/issues/389 and https://github.com/Microsoft/language-server-protocol/issues/432

I am closing this now that #389 is in.


Added new Java counterparts for List and ListItem nodes.

Also provided an implementation for the Inline interface.
Additionally moved Ruby to Java node conversion to separate class org.asciidoctor.ast.NodeFactory.
I tried hard for a DynamicProxy based approach and it worked fine for converters.
But the whole approach got mixed up when TreeConverters are added.
It seems to be impossible or at least very hard to mix and match JRuby type conversion and own DynamicProxies.

I have only one word to say. Awesome.

Thanks!

I have merged, today I will update the code with some additions like an spi for converters.

:+1:


field_object.type is wrong

Sorry, my English is not good.
I have a csv file with two empty lines.

when I run the below code:
auto field = csv.next_field();
std::cout << (field.type == FieldType::DATA) << std::endl;

The result is 1 (true).
I think field.type should be FieldType::ROW_END  instead of  FieldType::DATA.

Thanks for the bug report @8NAF. Your english is great :). Regarding the bug, I don't have a ton of time to investigate why this is happening or to fix it. Do you  want to try figuring out what's going wrong?

Thanks for the suggestion.
Like you, I'm pretty busy too, but if I find something I'll let you know.


[ClangImporter] Make proper retain for CompilerInvocation

Explanation: When cloning the clang instance in ClangImporter to perform tasks like PCM/PCH compilation, make a proper retain for the std::shared_ptr so the CompilerInvocation doesn't get prematurely deleted when ClangImporter is still alive.

Scope: This fixes a case where clang emits a diagnostics in a source buffer that gets mapped in via CAS, and mapped into swift source manager. While CAS has the ownship from CompilerInvocation -> CASOptions -> CAS, if the CompilerInvocation is deleted when the cloned instance is deleted, it left an invalid buffer in the swift source manager.

Issues: rdar://141284501

Original PRs: https://github.com/swiftlang/swift/pull/78138

Risk: Low.

Testing: UnitTest added

Reviewers:

@swift-ci please test


Buyer Property Search

The website should allow potential buyers to search for properties based on various criteria

From Use Case: REA-001
https://github.com/RequirementsProject/RealtorWebsiteProject/blob/main/Use Cases.pdf


FatalThrowableError in Client.php line 81: Class 'MongoDB\Driver\Manager' not found

I've installed the mongodb driver with PECL, and keep getting this error when attempting a simple query

❤ 💚 💙 💛 💜

<?php

namespace App;

use Jenssegers\Mongodb\Eloquent\Model as Eloquent;

class Profile extends Eloquent
{
    //
    // $manager = new MongoDB\Driver\Manager("mongodb://localhost:27017");
    protected $connection = 'mongodb';
    protected $collection = 'Profiles';
}

I was with this same error, which I did was as follows, I installed the latest version of the driver with threadsafe for the phpinfo () platform, in my case the 86x, after that the composer worked without problem


Use .lintr files for lintr

Hi,
I am using lintr to lint R files. However, the .lintr file, which is in the same directory is not read, so I can't set any configuration settings. How do I set configuration settings for lintr?
Thanks.

I'm not familiar with how lintr is supposed to read .lintr files. Is there a command line argument which can be used for specifying the file to load?

When you run .lintr in Rstudio or from the console, it will read the file from the working directory.
Here's my workaround. I made a clone of your repo and modified the lint function, so I could pass parameters to it:
function! ale_linters#r#lintr#GetCommand(buffer) abort     return ale#path#BufferCdString(a:buffer)     \   . 'Rscript -e ' . ale#Escape('lintr::lint(commandArgs(TRUE), lintr::with_defaults(line_length_linter = lintr::line_length_linter(120), assignment_linter = NULL))') . ' %t' endfunction
A better solution would be to create a variable you could set in .vimrc, where you could put the R variables lintr::with_defaults(line_length_linter = lintr::line_length_linter(120), assignment_linter = NULL)).
If you like this solution I can put in a PR in the next few days.

Okay then, that shouldn't be hard to fix. If the the linter has to be run from the directory containing the .lintr file, we should use the function for finding files to find a directory containing the file, and use the function you used before for changing directory. This is also easy to cover with Vader tests.
Then we could consider other options for configuring things.

@ilyakopy @w0rp
Would love to see that feature being added.
I work in projects with different style guides that make a global setting of g:ale_r_lintr_options not very practical.
Your last comment sounds like that implementing this would not be much of a hassle?


Build system update

Everything built and compiled fine. Thanks!

Everything built and compiled fine. Thanks!

Thanks guys!


fixed misleading error message

This branch is to fix #26. active_measurements only looks at the maptree, so saying the missing bin is in the response file leads the user in the wrong direction for investigating a problem

Do you want to fix the typo (it -> is) as well while you're at it?

I can confirm it works, but since it is a small change any potential problems caused by it should be easily traceable and fixable.

Going to merge this since only error messages have been changed.


The type of this PR is: TYPE

This PR solves [GRO-]
Description

@rajsam003 - gonna close this, feel free to reopen when wanting to work on it again!


After an appliance reboot, the UI login spinner spins forever

This might be related to #3444
The UI worker strace is showing futex(0xca9634, FUTEX_WAIT_PRIVATE, 1721, NULL)
Note, I'm able to wget localhost:3000 so it is responding to requests and works but the UI worker seems stuck via strace.
To recreate this:  you need to ensure 7a05adb5d2a271a592e1369bb94302d6feb41768 is applied.
The initial deployment of the appliance seems to work (logging in and navigating around works).  After you reboot the appliance, that's when you get the login page but it spins forever.
Reverting that commit and setting the database.yml pool to 1, bundling and things work again.

@dmetzger57 Weren't you looking at this today?

Yes, LJ kindly helped me triage and we discovered the issue is related to our move to Puma.

On Jul 15, 2015, at 12:55 PM, Oleg Barenboim<EMAIL_ADDRESS>wrote:
@dmetzger57 https://github.com/dmetzger57 Weren't you looking at this today?
—
Reply to this email directly or view it on GitHub https://github.com/ManageIQ/manageiq/issues/3468#issuecomment-121678417.

Note that @hsong-rh found you can still type through the spinner...so you can hit enter and login anyway.

FWIW i can still reproduce the bug with the connection pool set to 1 (but still running puma). restarting doesn't seem to be necessary - just logging out/in again. if i hit refresh, sometimes i am logged in and sometimes i am taken back to the login page, where i can then log in successfully.
some other odd behavior that @gtanzillo found that i have also reproduced: hitting refresh will sometimes result in some HTML being printed rather than rendered.

Found some things of interest when comparing a happy request to POST dashboard/authenticate (top in each screenshot) with an unhappy one (bottom in each). Some things to note:

The response time of an unhappy request (20+ seconds)
The difference in response body
The XML parsing error in the unhappy request

I believe this is https://github.com/puma/puma/pull/743

I've updated the Gemfile on the appliance to pull puma from git, and done an evm:restart.
I wasn't doing a very good job of reproducing it, however, so... let me know whether you can still get it to break? ¯\_(ツ)_/¯


bpfel-unknown-none / bpfeb-unknown-none support?

bpfel-unknown-none and bpfeb-unknown-none have been tier 3 targets since mid last year, as listed on https://doc.rust-lang.org/nightly/rustc/platform-support.html, and merged in https://github.com/rust-lang/rust/pull/79608.
I'm a bit confused why they aren't listed in https://github.com/oxalica/rust-overlay/blob/master/manifests/targets.nix.
Am I misunderstanding something about what rust-overlay can support?

bpfel-unknown-none and bpfeb-unknown-none have been tier 3 targets since mid last year,

This overlay (re)ships binary distributed rust toolchains from rustup server. If a target doesn't have rustc/cargo built, it's indeed not supported by us. We don't build anything. We just download and patch binaries from the rustup server.

I'm a bit confused why they aren't listed in https://github.com/oxalica/rust-overlay/blob/master/manifests/targets.nix.

This file is generated from every nightly/stable/beta manifests TOML of rustup. It's a collection of all target having binaries available (from rustup server).


chore: replace vulnerable dependencies for flexfields

Removes dependency on unmaintained react-scripts package, replaces it with vite/vitest. Also resolves dependency resolution issues with contentful field-editor packages.

Hello @vipulchadda -- this Pull Request is being directed to you as a Contentful Marketplace App owner
This PR removes your apps dependence on react-scripts in favor of vite (and vitest). This is done in service of removing security vulnerabilities. You may see other nested dependencies updated as well, like typescript or emotion/css, as these libraries were required for react-scripts and often pinned to stale or deprecated versions. While the PR is complete, we’d like your help as the owner of the app, to confirm that no bugs or regressions have been introduced with these updates.
Required Action:
Please review this PR, and QA your app with these changes. If all functionality remains safely intact, please just reply with a "LGTM" (or more) and we’ll merge the PR and release these changes.
If you do discover issues as a result of these changes, please open a new PR against this branch with fixes once identified.
Please plan to complete this action within 30 days.
Sincerely,
The Contentful Ecosystem Team

We have verified the changes, and everything looks good. It should be good to merge.

thank you for the prompt response vipulchadda!


Misleading wording in Note box  in "Using Microsoft Fakes in the CI" section

Hello,
the following wording is misleading

Shouldn´t that be "source control" instead of "CI" ?
Regards,
Holger

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 069d29c9-b269-6e1f-08af-91ac135ebb1e
Version Independent ID: cd993f76-8077-d566-4c48-0ab425c62b83
Content: Isolating Code Under Test with Microsoft Fakes - Visual Studio (Windows)
Content Source: docs/test/isolating-code-under-test-with-microsoft-fakes.md
Product: visual-studio-windows
Technology: vs-ide-test
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

Duplicate of #7867


#82 Fixing clearing 0 at the end  if fraction is 0

Hi @oriolcp! I have merge some major PRs to code, could you recheck this and update your PRs?
Thanks a lot!
Best regards,
Luis


Update driver configuration due to submodule update.

The demo doesn't compile because some defines are missing.

Thank you!


how to dynamic work.id for snowflake

In SnowflakeShardingKeyGenerator.java:44 says

  Call @{@code SnowflakeShardingKeyGenerator.setWorkerId} to set worker id, default value is 0.

but the the getWorkId method is private and there isn't have setWorkId method.
I need dynamic set it from the IP address, how can I setWorkId?

Hi @toby1024 , You can try org.apache.shardingsphere.orchestration.internal.keygen.LeafSnowflakeKeyGenerator, it can init workId at RegistryCenter.

Hi @toby1024 , You can try org.apache.shardingsphere.orchestration.internal.keygen.LeafSnowflakeKeyGenerator, it can init workId at RegistryCenter.

It will introduce zookeeper，not the best way for me

FIY: https://shardingsphere.apache.org/document/current/en/manual/sharding-jdbc/configuration/config-java/