Provide more friendly error messages

We should try to provide more friendly error messages.
@sharwell
Sam, we are using your optimized version of antlr4 to implement a groovy parser, which will be merged into Groovy project.  Could you tell me how to remove the rule information(e.g. rule parExpression) of FailedPredicateException?  Thanks in advance!
PS: We want to report the error message and stop parsing right now.
current error message:
Script1.groovy: 1: rule parExpression Missing ')' @ line 1, column 7.
   (1 + 2
         ^

expected error message(NO rule information):
Script1.groovy: 1: Missing ')' @ line 1, column 7.
   (1 + 2
         ^

antlr4 code:
parExpression
    :   LPAREN statementExpression RPAREN

    // !!!Error Alternatives!!!
    |   LPAREN statementExpression               { false }?<fail={ "Missing ')'" }>
    ;

(complete content: https://github.com/danielsun1106/groovy-parser/blob/master/src/main/antlr4/org/apache/groovy/parser/antlr4/GroovyParser.g4)
input content:
(1 + 2

Fascinating! I'll take a look.

parExpression
    :   LPAREN statementExpression RPAREN

    // !!!Error Alternatives!!!
    |   LPAREN statementExpression               { false }?<fail={ "Missing ')'" }>
    ;

:arrow_right: You need to create an error strategy derived from DefaultErrorStrategy, and override DefaultErrorStrategy.reportFailedPredicate to not add the rule {name} prefix.

As you said, the error alternative impact the parsing performance quite a lot(26min#297 -> 31min#300, https://travis-ci.org/danielsun1106/groovy-parser/builds ).
Thank you, Sam :) I'll give it a try. BTW, your optimized version of antlr4 is quite amazing!

📝 I recently updated my YourKit license and plan to use this test suite for further evaluation of the runtime.

In the master branch, groovy-parser contains 10419 test cases, most of which are from famous groovy project, e.g. Grails, Gradle, Spock, Geb and Groovy itself.
The antlr4 branch is using groovy-parser(based on your optimized antlr4) to build and test Groovy programming languange. In addition, the new parser will be used in the Groovy 3. Thanks to your great work achieving the optimized antlr4.
http://ci.groovy-lang.org/viewType.html?buildTypeId=Groovy_Antlr4grammar&guest=1
BTW, after modifying the rule parExpression as the following:
parExpression
    :   LPAREN statementExpression
        (   RPAREN
        |   // !!!Error Alternatives!!!
            { false }?<fail={ "Missing ')'" }>
        )
    ;

The error message changed, it seems that the sematic predicate switches on/off some other alternative?
Script1.groovy: 1: no viable alternative at input '<EOF>' @ line 1, column 7.
   (1 + 2
         ^

Before modified:
Script1.groovy: 1: rule parExpression Missing ')' @ line 1, column 7.
   (1 + 2
         ^

@sharwell
Sam, I use assert to interrupt the parsing when occurred in the lexer. Is there any other elegant way to throw an exception to complete the same thing? Thanks in advance!
current code:
assert null != paren: "Too many '" + text + "' " + genPositionInfo();
assert text.equals(PAREN_MAP.get(paren)): "'" + text + "' can not match '" + paren + "' " + genPositionInfo();

experimental code(fails to stop parsing when lexer error occurred):
        if (null == paren) {
            throw new RuntimeException("Too many '" + text + "' " + genPositionInfo());
        }
        if (!text.equals(PAREN_MAP.get(paren))) {
            throw new RuntimeException("'" + text + "' can not match '" + paren + "' " + genPositionInfo());
        }

@danielsun1106 The file PostgreSqlLexer.g4 contains what I believe is the strongest example to date of a robust lexer. The comments describe the mechanisms used to handle a variety of input errors.

Thanks a lot, Sam. I'll try later :)

@sharwell
Sam, I tried to check the missing RPAREN. The original way is inefficient but genenates better error messages, and the efficient way you provided has better performance but generates confused error messages. Could you tell me how to improve the error message of the efficient way? Thanks in advance!
input text:
 (1 + 2

efficient way:
parExpression
    :   LPAREN statementExpression
        (   RPAREN
        |   // !!!Error Alternatives!!!
            { false }?<fail={ "Missing ')'" }>
        )
    ;

error message of efficient way:
Script1.groovy: 1: no viable alternative at input '<EOF>' @ line 1, column 7.
   (1 + 2
         ^

Error handling in ANTLR 4 is very interesting. There are two goals we're trying to achieve: good error reporting, and good error recovery. It turns out that ANTLR is quite good at both reporting and recovery for errors that occur where decisions are LL(1). For other cases, the current implementation appears to favor recovery over reporting (not necessarily the intent, but this is my observation).
Back when I was working on GoWorks, I decided to experiment with an alternate error handling strategy. To me, it seemed strange that adaptivePredict would look ahead several symbols, and then fail to return any decision at all if it encountered an error later in the input. In my experiment, I modified adaptivePredict so that a syntax error occurring at LL(k>1) would cause adaptivePredict return the "best known answer so far", which really meant returning the minimum alternative number which successfully matched input leading to the error. The result was fascinating - the strategy had near perfect localization and reporting for the first syntax error in a file, but the recovery was just a disaster (numerous errors were reported through the remainder of the file, suggesting that the parser had no idea what to do after the first error).
The answer to this probably lies in a hybrid approach. Consider the following:

Parse the file using an error handler with good recovery characteristics, but don't report syntax errors.
For each node in the parse tree which contains a sequence of tokens skipped by the error recovery, attempt to re-parse that node using a recovery strategy with good localization. Stop after reporting the first error since we're not relying on this step for recovery.

I haven't implemented anything like this yet, but I imagine it would do quite well with grammars, especially if/where semantic predicates can be avoided.

Hi Sam,
  Thanks for your explaining the internals to me in detail ;)
  As to the 2 approaches, we can not choose the first one because Groovy should help developers locate syntax errors instead of fixing them automatically. The second approach seems better to apply, could you provide some examples or some reference documentations?

Thanks,
Daniel.Sun
在 2016年11月29日 上午2:09，Sam Harwell<EMAIL_ADDRESS>Error handling in ANTLR 4 is very interesting. There are two goals we're trying to achieve: good error reporting, and good error recovery. It turns out that ANTLR is quite good at both reporting and recovery for errors that occur where decisions are LL(1). For other cases, the current implementation appears to favor recovery over reporting (not necessarily the intent, but this is my observation).
Back when I was working on GoWorks, I decided to experiment with an alternate error handling strategy. To me, it seemed strange that adaptivePredict would look ahead several symbols, and then fail to return any decision at all if it encountered an error later in the input. In my experiment, I modified adaptivePredict so that a syntax error occurring at LL(k>1) would cause adaptivePredict return the "best known answer so far", which really meant returning the minimum alternative number which successfully matched input leading to the error. The result was fascinating - the strategy had near perfect localization and reporting for the first syntax error in a file, but the recovery was just a disaster (numerous errors were reported through the remainder of the file, suggesting that the parser had no idea what to do after the first error).
The answer to this probably lies in a hybrid approach. Consider the following:

Parse the file using an error handler with good recovery characteristics, but don't report syntax errors.
For each node in the parse tree which contains a sequence of tokens skipped by the error recovery, attempt to re-parse that node using a recovery strategy with good localization. Stop after reporting the first error since we're not relying on this step for recovery.

I haven't implemented anything like this yet, but I imagine it would do quite well with grammars, especially if/where semantic predicates can be avoided.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/danielsun1106/groovy-parser/issues/12#issuecomment-263347093, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIukgBn8kwnU1DT7Bkt1ivNrZfod_N5Nks5rCxjWgaJpZM4KW8RF.

@sharwell
I'm trying to throw GroovySyntaxError and find that the approach works fine. Now I'm looking for the general way to get line and column of the position where throwing error.
parExpression
    :   LPAREN (statementExpression | standardLambda)
        (   RPAREN
        |   { if (true) throw new GroovySyntaxError("Missing ')'"); }
        )

@sharwell
I find throw GroovySyntaxError works fine in lexer(https://github.com/danielsun1106/groovy-parser/commit/54889f5dc4ff1b7d2346c6c62a92695b14db5694),
but the approach does not fit parser... because some test cases fails. I guess antlr4 will trigger the throwing GroovySyntaxError action when choosing alternatives. LPAREN and RPAREN are not used in  rule parExpression only, rule formalParameters uses LPAREN and RPAREN as well, so when antlr4 try to match rule parExpression  and failed, it triggers the throwing GroovySyntaxError action of rule parExpression . Could you confirm it for me? Thanks in advance!

@sharwell
I address the issue that some test cases fail when adding throw error action.
It's because I use the two stage parsing strategy and the SLL mode triggers the action :)


FSharp.Core nupkg not working with Xamarin iOS Unified API

I got an iMac at work about a week ago. We have a iPad app in production that uses Xamarin iOS. I'm in charge of the builds and I'm attempting to get them to work with the FSharp.Core package on NuGet. Xamarin has a new Unified API and an existing Classic API. The Unified API has a new project type, set of project templates, and different behavior even when adding NuGet packages. The pull request https://github.com/fsharp/fsharp/pull/364 makes things work for the Classic API, but is not working with the new Unified API.
Using the Unified API, instead of packages\FSharp.Core.<IP_ADDRESS>\lib\MonoTouch1\FSharp.Core.dll like Classic mode, the Unified mode ends up using the assembly for .NET Portable Profile 7 packages/FSharp.Core.<IP_ADDRESS>/lib/portable-net45+netcore45+MonoAndroid1+MonoTouch1/FSharp.Core.dll. Building the project them fails with Error FS0074: The type referenced through 'System.String' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime'. (FS0074) (iPadUnified86).

I don't understand yet how library selection is supposed to work in Unified mode. Which PCL Profiles are supported by it?
All the switches for the FSharp.Core libraries are here:
https://github.com/fsharp/fsharp/blob/master/src/FSharpSource.targets
I've already contacted Xamarin support about this. It would be great to get the NuGet package working with their new API.
//cc @7sharp9

Here is the full build output:
Building: iPadUnified86 (Debug|iPhoneSimulator)

Build started 1/4/2015 7:29:29 PM.
__________________________________________________
Project "/Users/cameron/Documents/Projects/iPadUnified86/iPadUnified86.fsproj" (Build target(s)):

	Target PrepareForBuild:
		Configuration: Debug Platform: iPhoneSimulator

	Target _DetectAppManifest:
		FindItemWithLogicalName Task
		  Items:
		    Info.plist
		    Entitlements.plist
		    packages.config
		  LogicalName: Info.plist
		  ProjectDir: /Users/cameron/Documents/Projects/iPadUnified86
		  ResourcePrefix: Resources

	Target _DetectSdkLocations:
		DetectSdkLocations Task
		  Platform: iPhoneSimulator
		  SdkVersion: 8.1
		  XamarinSdkRoot: /Library/Frameworks/Xamarin.iOS.framework/Versions/Current

	Target _CoreCompileInterfaceDefinitions:
		IBTool Task
		  AppManifest: Info.plist
		  InterfaceDefinitions:
		  IntermediateOutputPath: obj/iPhoneSimulator/Debug/
		  Platform: iPhoneSimulator
		  ResourcePrefix: Resources
		  SdkBinPath: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk/Developer/usr/bin
		  SdkRoot: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk
		  SdkVersion: 8.1

	Target _CollectColladaAssets:
		CollectBundleResources Task
		  BundleResources: <null>
		  OptimizePNGs: False
		  ProjectDir: /Users/cameron/Documents/Projects/iPadUnified86
		  ResourcePrefix: Resources

	Target _CoreCompileColladaAssets:
	No input files were specified for target _CoreCompileColladaAssets, skipping.

	Target _CoreCompileSceneKitAssets:
		CompileSceneKitAssets Task
		  IntermediateOutputPath: obj/iPhoneSimulator/Debug/
		  ProjectDir: /Users/cameron/Documents/Projects/iPadUnified86
		  ResourcePrefix: Resources
		  SceneKitAssets:
		  SdkDevPath: /Applications/Xcode.app/Contents/Developer
		  SdkRoot: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk
		  SdkVersion: 8.1

	Target _CoreCompileTextureAtlases:
		TextureAtlas Task
		  AtlasTextures: <null>
		  IntermediateOutputPath: obj/iPhoneSimulator/Debug/
		  ProjectDir: /Users/cameron/Documents/Projects/iPadUnified86
		  ResourcePrefix: Resources
		  SdkBinPath: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk/Developer/usr/bin
		  SdkDevPath: /Applications/Xcode.app/Contents/Developer
		  SdkUsrPath: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk/Developer/usr

	Target _CollectITunesArtwork:
		CollectITunesArtwork Task
		  ITunesArtwork: <null>

	Target _CollectBundleResources:
		CollectBundleResources Task
		  BundleResources:
<EMAIL_ADDRESS>		  OptimizePNGs: True
		  ProjectDir: /Users/cameron/Documents/Projects/iPadUnified86
		  ResourcePrefix: Resources

	Target _CoreOptimizePngImages:
	Skipping target "_CoreOptimizePngImages" because its outputs are up-to-date.

	Target _UnpackLibraryResources:
		UnpackLibraryResources Task
		  IntermediateOutputPath: obj/iPhoneSimulator/Debug/
		  Prefix: monotouch
		  ReferencedLibraries:
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/System.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/System.Xml.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/mscorlib.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Xamarin.iOS.dll
		    packages/FSharp.Core.<IP_ADDRESS>/lib/portable-net45+netcore45+MonoAndroid1+MonoTouch1/FSharp.Core.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/System.Core.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Collections.Concurrent.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Collections.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.ComponentModel.Annotations.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.ComponentModel.EventBasedAsync.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.ComponentModel.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Diagnostics.Contracts.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Diagnostics.Debug.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Diagnostics.Tools.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Dynamic.Runtime.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Globalization.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.IO.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Linq.Expressions.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Linq.Parallel.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Linq.Queryable.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Linq.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Net.NetworkInformation.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Net.Primitives.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Net.Requests.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.ObjectModel.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Reflection.Extensions.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Reflection.Primitives.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Reflection.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Resources.ResourceManager.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.Extensions.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.InteropServices.WindowsRuntime.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.InteropServices.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.Numerics.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.Serialization.Json.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.Serialization.Primitives.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.Serialization.Xml.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Security.Principal.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.ServiceModel.Http.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.ServiceModel.Primitives.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Text.Encoding.Extensions.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Text.Encoding.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Text.RegularExpressions.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Threading.Tasks.Parallel.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Threading.Tasks.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Threading.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Xml.ReaderWriter.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Xml.XDocument.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Xml.XmlSerializer.dll
		    /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.dll

	Target CopyFilesMarkedCopyLocal:
		Copying file from '/Users/cameron/Documents/Projects/iPadUnified86/packages/FSharp.Core.<IP_ADDRESS>/lib/portable-net45+netcore45+MonoAndroid1+MonoTouch1/FSharp.Core.dll' to '/Users/cameron/Documents/Projects/iPadUnified86/bin/iPhoneSimulator/Debug/FSharp.Core.dll'

	Target GenerateSatelliteAssemblies:
	No input files were specified for target GenerateSatelliteAssemblies, skipping.

	Target CoreCompile:
		Tool /Library/Frameworks/Mono.framework/Versions/3.12.0/lib/mono/4.0/fsc.exe execution started with arguments: -o:obj/iPhoneSimulator/Debug/iPadUnified86.exe -g --debug:full --noframework --define:__UNIFIED__ --define:__MOBILE__ --define:__IOS__ --define:DEBUG --optimize- --tailcalls- -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/System.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/System.Xml.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/mscorlib.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Xamarin.iOS.dll -r:packages/FSharp.Core.<IP_ADDRESS>/lib/portable-net45+netcore45+MonoAndroid1+MonoTouch1/FSharp.Core.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/System.Core.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Collections.Concurrent.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Collections.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.ComponentModel.Annotations.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.ComponentModel.EventBasedAsync.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.ComponentModel.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Diagnostics.Contracts.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Diagnostics.Debug.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Diagnostics.Tools.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Dynamic.Runtime.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Globalization.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.IO.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Linq.Expressions.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Linq.Parallel.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Linq.Queryable.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Linq.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Net.NetworkInformation.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Net.Primitives.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Net.Requests.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.ObjectModel.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Reflection.Extensions.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Reflection.Primitives.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Reflection.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Resources.ResourceManager.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.Extensions.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.InteropServices.WindowsRuntime.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.InteropServices.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.Numerics.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.Serialization.Json.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.Serialization.Primitives.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.Serialization.Xml.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Runtime.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Security.Principal.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.ServiceModel.Http.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.ServiceModel.Primitives.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Text.Encoding.Extensions.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Text.Encoding.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Text.RegularExpressions.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Threading.Tasks.Parallel.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Threading.Tasks.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Threading.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Xml.ReaderWriter.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Xml.XDocument.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Facades/System.Xml.XmlSerializer.dll --target:exe --warn:2 --warnaserror:76 --fullpaths --flaterrors --highentropyva- AppDelegate.fs
		F# Compiler for F# 3.1 (Open Source Edition)
		Freely distributed under the Apache 2.0 Open Source License

/Users/cameron/Documents/Projects/iPadUnified86/AppDelegate.fs(7,3): error FS0074: The type referenced through 'System.String' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime'.

/Users/cameron/Documents/Projects/iPadUnified86/AppDelegate.fs(8,6): error FS0074: The type referenced through 'System.Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime'.

/Users/cameron/Documents/Projects/iPadUnified86/AppDelegate.fs(8,1): error FS0074: The type referenced through 'System.Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime'.

/Users/cameron/Documents/Projects/iPadUnified86/AppDelegate.fs(22,7): error FS0074: The type referenced through 'System.AttributeUsageAttribute' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime'.

/Users/cameron/Documents/Projects/iPadUnified86/AppDelegate.fs(24,9): error FS0074: The type referenced through 'System.Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime'.

/Users/cameron/Documents/Projects/iPadUnified86/AppDelegate.fs(25,9): error FS0074: The type referenced through 'System.Int32' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime'.
	Task "Fsc" execution -- FAILED
	Done building target "CoreCompile" in project "/Users/cameron/Documents/Projects/iPadUnified86/iPadUnified86.fsproj".-- FAILED

Done building project "/Users/cameron/Documents/Projects/iPadUnified86/iPadUnified86.fsproj".-- FAILED

Build FAILED.
Errors:

/Users/cameron/Documents/Projects/iPadUnified86/iPadUnified86.fsproj (Build) ->
/Library/Frameworks/Mono.framework/Versions/3.12.0/lib/mono/4.0/Microsoft.FSharp.Targets (CoreCompile target) ->

	/Users/cameron/Documents/Projects/iPadUnified86/AppDelegate.fs(7,3): error FS0074: The type referenced through 'System.String' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime'.
	/Users/cameron/Documents/Projects/iPadUnified86/AppDelegate.fs(8,6): error FS0074: The type referenced through 'System.Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime'.
	/Users/cameron/Documents/Projects/iPadUnified86/AppDelegate.fs(8,1): error FS0074: The type referenced through 'System.Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime'.
	/Users/cameron/Documents/Projects/iPadUnified86/AppDelegate.fs(22,7): error FS0074: The type referenced through 'System.AttributeUsageAttribute' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime'.
	/Users/cameron/Documents/Projects/iPadUnified86/AppDelegate.fs(24,9): error FS0074: The type referenced through 'System.Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime'.
	/Users/cameron/Documents/Projects/iPadUnified86/AppDelegate.fs(25,9): error FS0074: The type referenced through 'System.Int32' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime'.

	 0 Warning(s)
	 6 Error(s)

Time Elapsed 00:00:02.2710200

---------------------- Done ----------------------

Build: 6 errors, 0 warnings

This may be a bug in the F# Compiler dealing with reference assemblies in different folders. It is worth looking into. Notice in the above build, several of the references are in a Facades folder the is a subdirectory, such as Xamarin.iOS/Facades/System.Runtime.dll. It is not the same folder as Xamarin.iOS/mscorlib.dll or Xamarin.iOS/System.dll.
See this bug that also results in error FS0074: Moving reference assemblies causes compile to fail for .NETCore portable profiles (7, 78, 259)
For comparison, here is a Classic API build that does work.

Cleaning Solution: iPadClassic84 (Debug|iPhoneSimulator)

Cleaning: iPadClassic84 (Debug|iPhoneSimulator)
Removing output files...
Clean complete

Building Solution: iPadClassic84 (Debug|iPhoneSimulator)

Building: iPadClassic84 (Debug|iPhoneSimulator)
Performing main compilation...
/Library/Frameworks/Mono.framework/Versions/3.10.0/bin/fsharpc --noframework --nologo
--target:exe
--out:"/Users/cameron/Documents/Projects/iPadClassic84/bin/iPhoneSimulator/Debug/iPadClassic84.exe"
--noframework
--define:DEBUG
--debug+
--optimize-
--tailcalls-
-r:"/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/2.1/System.Core.dll"
-r:"/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/2.1/System.Xml.dll"
-r:"/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/2.1/System.dll"
-r:"/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/2.1/monotouch.dll"
-r:"/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/2.1/mscorlib.dll"
-r:"/Users/cameron/Documents/Projects/iPadClassic84/packages/FSharp.Core.<IP_ADDRESS>/lib/MonoTouch/FSharp.Core.dll"
"/Users/cameron/Documents/Projects/iPadClassic84/AppDelegate.fs"
Build complete -- 0 errors, 2 warnings

Compiling to native code
/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/bin/mtouch -sdkroot "/Applications/Xcode.app/Contents/Developer" --cache "/Users/cameron/Documents/Projects/iPadClassic84/obj/iPhoneSimulator/Debug/mtouch-cache" --nomanifest --nosign -sim "/Users/cameron/Documents/Projects/iPadClassic84/bin/iPhoneSimulator/Debug/iPadClassic84.app" -r "/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/2.1/System.dll" -r "/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/2.1/System.Xml.dll" -r "/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/2.1/System.Core.dll" -r "/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/2.1/mscorlib.dll" -r "/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/2.1/monotouch.dll" -r "/Users/cameron/Documents/Projects/iPadClassic84/packages/FSharp.Core.<IP_ADDRESS>/lib/MonoTouch/FSharp.Core.dll" -debug -nolink -sdk "8.1" -targetver "3.2" --abi=i386 "/Users/cameron/Documents/Projects/iPadClassic84/bin/iPhoneSimulator/Debug/iPadClassic84.exe"
Xamarin.iOS 8.4.0 Business Edition using framework: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk
iPadClassic84.app built successfully.

Extracting embedded content

Updating application manifest

Updating debug configuration file

Updating debug settings manifest

---------------------- Done ----------------------

Build: 0 errors, 2 warnings

I think we can ignore my last comment being that the build does work with their provided /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/FSharp.Core.dll.
With help from Xamarin Support, we discovered that we get a successful build when copying the packages/FSharp.Core.<IP_ADDRESS>/lib/portable-net45+netcore45+MonoAndroid1+MonoTouch1/FSharp.Core.dll to the root folder of the project.
    <Reference Include="FSharp.Core">
      <HintPath>FSharp.Core.dll</HintPath>
    </Reference>

It fails if I put the files in any subfolder such as packages or lib:
    <Reference Include="FSharp.Core">
      <HintPath>lib\FSharp.Core.dll</HintPath>
    </Reference>

A bug has been filed with Xamarin Engineering. I'd like to leave this issue open until this is resolved in case we need to make adjustments to the packaging in any way.

See http://blog.xamarin.com/how-to-update-nuget-packages-for-64-bit/ for details on the correct folder structure for nuget that targets the 64bit unified API.

The supplied FSharp.Core that is shipped in the various Xamarin packages comes from a tagged version that is communicated to Xamarin normally via Don when a release is finalised.

I've already read that blog, looked at the source code and done a bunch of testing. Is there something wrong with the portable-net45+monoandroid1+monotouch1+xamarinios1 folder structure? From my testing, it works on:

OS X Xamarin Studio 3.6 Classic & Unified
OS X Xamarin Studio 3.8 Classic & Unified
Xamarin for Visual Studio 3.9 Classic C#
Xamarin for Visual Studio 3.9 Unified C# (+xamarinios1 required)

The only place it is currently failing to put in the correct reference is:

Xamarin for Visual Studio 3.9 Unified F#

When I add the FSharp.Core package, the file gets saved without the path information:

Even though when you initially add it, its properties are to the correct file location:

I'm expecting it to behave the same way as the C# projects:
Unified

Classic

anything to do on this bug?

No, the changes were already merged in.


Error handling for DM datasets in GUI

Fixes #645
Contributor Checklist:

[x] I have added a changelog entry for my contribution

Actually I just had an idea to fix the codeclimate issue: the whole "detection worked ok" branch could be extracted into its own function. What do you think?

Actually I just had an idea to fix the codeclimate issue: the whole "detection worked ok" branch could be extracted into its own function. What do you think?

Sounds good! I'll try do that.

the error is shown as currently, and the user is navigated back to the file browser

I went with this option by not dispatching datasetActions.Actions.open.


Add link to Beam docs

Please add new icon to the side menu that leads to https://documentation.beam.mw/
Design: https://zpl.io/25mJzmW

If "Allow opening external links" switch is disabled, when we open link to Beam docs, add a warning pop-up "External link"


Introduce waitWhileSelector

What are you trying to achieve?
I would like to be able to wait while an element is present.
For example I usually need to wait while a spinner is present to go on.
What do you get instead?
I have to reply a feature I was using in casperJs:
Casper.prototype.waitWhileSelector = function waitWhileSelector(selector, then, onTimeout, timeout) {
    "use strict";
    this.checkStarted();
    timeout = getTimeoutAndCheckNextStepFunction(timeout, then, 'waitWhileSelector', this.options.waitTimeout);
    return this.waitFor(function _check() {
        return !this.exists(selector);
    }, then, onTimeout, timeout, {
        selector: selector,
        waitWhile: true
    });
};

Details

CodeceptJS version: 1.0.1
NodeJS Version: 6.11.2
Operating System: Windows 7 (sadly)
Nightmare version: 2.10.1
Configuration file:

{
  "output": "logs",
  "helpers": {
    "Nightmare": {
      "url": "http://<IP_ADDRESS>:8080",
      "width": 1900,
      "height": 1200,
      "waitTimeout": 20000,
      "waitForAction": 2000,
      "waitForTimeout": 20000
    }
  },
  "include": {
    "I": "./steps_file.js",
    "loginPage": "./pages/Login.js",
    "mainPage": "./pages/Main.js",
    "mainMenuFragment": "./fragments/MainMenu.js",
    "navbarFragment": "./fragments/Navbar.js"
  },
  "mocha": {},
  "bootstrap": false,
  "teardown": null,
  "hooks": [],
  "tests": "tests/*_test.js",
  "timeout": 90000,
  "name": "codecept"
}

+1

Feature introduced under the name waitUntilExists with pull request


[Refactor] [BE] Remove overly verbose log

This scenario is quite common e.g. with Iceberg, with schema evolution, etc.
Why I'm doing:
This currently results in a lot of noisy useless logs when reading parquet files.
What I'm doing:
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[x] Miscellaneous: Minor, logging.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Samrose-Ahmed thank you for this change, could you sign the CLA, then we can accept this contribution

@mergify backport branch-3.3 branch-3.2


Do not throw error on missing audience

The login sample Readme states that the audience value is optional:

However, if the audience is not set the following error is thrown when running the sample with npm run dev:

While it doesn't prevent the rest of the sample from running, it makes for a rather poor experience. This PR logs a message when the audience is missing and then cleanly exits the API server instead:

cc @woloski


Update requirements.txt use reflect published Deephaven and jpy packages

Once Deephaven publishes standard pypi packages, requirements.txt needs to be updated to reflect this.  Files also need to be updated when Deephaven switches to using the standard jpy module.

Resolved by #63


Release 0.9.1 on clojars?

Hi, first of all, thank you for this excellent work!
I was wondering if version 0.9.1 could be released on Clojars as I see the milestone 0.9.1 is 100% complete.
I would need the fix for issue #142 which is marked as resolved in it. I've tested my use case against 0.10.0-SNAPSHOT locally (just a few minutes ago) and it works very well.
Thanks.

Sure, I'll release 0.9.1 (essentially the current 0.10.0-SNAPSHOT) within the next day or so. It's been on the to-do list, so I just needed a nudge. ;)
I'll post back here when it's available.

0.9.1 is up on Clojars! Details of the release are in the changeling, but it's basically just issue #142 and another change that supports it.
https://github.com/rbrush/clara-rules/blob/master/CHANGELOG.md#091
Closing the issue since there is nothing more to do, but we can reopen or create a new issue if anything comes up.


feat(blockifier): add compiler version to V1ContractClass

This change is

#730  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @TzahiTaub and the rest of your teammates on  Graphite


refactor(sozo-migrate): set migrator account block to pending

@tarrencev do you think there would be any unwanted behaviour because of this? because we're basing all the read request to pending state now.

Hmm this just sets all requests to pending? Executes included? Should be fine. I'm pretty sure 0.12 is removing pending though. Not sure what the plan with the rpc is. cc @xJonathanLEI

Hmm this just sets all requests to pending? Executes included? Should be fine. I'm pretty sure 0.12 is removing pending though. Not sure what the plan with the rpc is. cc @xJonathanLEI

v0.12 only removes the pending tx status, no? but pending block will still exists. https://docs.starknet.io/documentation/starknet_versions/upcoming_versions/#removal_of_pending_status

@kariy is right. Pending block still exists. It's actually funnier than that. So with tx status PENDING gone you end up with ACCEPTED_ON_L2 txs that are in fact PENDING because they live in the PENDING block and has no block hash when queried.

@kariy is right. Pending block still exists. It's actually funnier than that.

Ah I see. A bit confusing lol. Either way I think this change is good, we always want to operate against the most up to date sequencer state


Talent Degrees not showing in full character sheet

Thanks for accepting my PR. There seems to be an issue with your implementation, tough.
The degree isn't shown in the full character sheet.

It is shown correctly in the block sheet.
Seen in v10.

It is now fixed on version 2.0.1


Updates / Compatibility?

It seems like this plugin is not working for the latest version of Phaser (Phaser 3.21. 0). I can see the original changes that broke the plugin in newer Phaser versions was resolved, but I am still unable to see animated tiles, although there are no thrown errors?
`import AnimatedTiles from 'phaser-animated-tiles/dist/AnimatedTiles';
let Water: Phaser.Tilemaps.DynamicTilemapLayer;
export default class ForestC extends Phaser.Scene {
public player: Player;
public cursors: Phaser.Types.Input.Keyboard.CursorKeys;
public controls: Controls;
public spawn: any;
public direction: any;
constructor() {
super({
key: 'ForestC',
});
this.spawn = null;
this.direction = null;
}
preload(): void {
this.load.scenePlugin('AnimatedTiles', AnimatedTiles, 'animatedTiles', 'animatedTiles');
this.load.spritesheet('player', '../../../assets/character/player.png',
{
frameWidth: 16, frameHeight: 32, margin: 0, spacing: 0,
});
this.load.image('tileset2', '../../../scenes/maps/source2.png');
this.load.image('tileset3', '../../../scenes/maps/source3.png');
this.load.tilemapTiledJSON('ForestC', '../../../scenes/maps/ForestC/ForestC.json');
}
init(data): void {
this.spawn = data.spawn || { x: 100, y: 100 };
this.direction = data.direction || 'down';
}
create(): void {
// Parse map
const tilemapLayers = [];
const map = this.make.tilemap({ key: 'ForestC' });
const tilemap = map.addTilesetImage('tileset2', 'tileset2', 16, 16, 1, 2);
// Layers
const Grass = map.createDynamicLayer('Grass', tilemap, 0, 0);
Water = map.createDynamicLayer('Water', tilemap, 0, 0);
console.log((this as any).animatedTiles);
(this as any).animatedTiles.init(map);
}
update(): void {
Water.fill(362, 0, 16, 20, 4);
(this as any).animatedTiles.updateAnimatedTiles();
}
}
`

@nkholski I'm happy to provide more information as well.


Fix DRM cross-compile without sysroot

Encountering /usr/include/xf86drm.h:40:10: fatal error: drm.h: No such file or directory
when doing a cross-compile I found that
cmake -DCMAKE_C_FLAGS=-I/usr/include/libdrm …

is needed. Some digging revealed that in my case #1717 spoils the libdrm includes.
The unexpected and different situation here: I'm doing a cross-compile on a multi-arch image.
I.e. I run an arm-linux-gnueabihf compiler on aarch64 and the armhf libs are installed side-by-side with the arm64 libs -- no need for a sysroot.
I propose to only drop the libdrm include path if a sysroot is actually used.

@zuckschwerdt Thanks for the review!

Kudos!
Using the cmake example project was a completely frictionless experience.
I went from a functioning sketch to feature-complete in 2 days.
Then another day to sort out Github Actions…
My project is https://github.com/zuckschwerdt/ledstrip-ddp-simulator


Refinement of grouping by date

When grouping by date, photos are currently grouped per day. Sometimes, especially when filtering photos, this leads to a very long list (lots of scrolling, not much visible content on screen).
I think it would be great to have an option that allows to refine the grouping by date. E.g. there could be an option to group by day (the current default), week, month, or year to create collection of best photos, or something like memories (photos from the same week of the past years).

The key part of this feature to make it super easy and straight forward to use. I would like to keep the UI simple.
What I can image is to add a small drop down to the date group by to change the defaoult behaviour:

let me know if you would like to give it a try. I dont think I will have time to implement it.


[web] transfer not working

https://github.com/bitsuperlab/web_play/commit/00ed5a7439b2bb9af21d8f55bf8720b5dfac517b


Formatting of declarator blocks in subroutine's parameters

Declarator blocks (#=) for a subroutine's parameters are formatted as H2-level headings while the subroutine's name is formatted as H3-level heading. This makes them seem out of place. Ideally, the subroutine's name would be formatted with a heading level higher than anything else that belongs to it.
Example: https://gist.github.com/uzluisf/ec9fa34e603bdc11d5e84642e6d74ddc

Additionally, the argument name is missing altogether from the Markdown output.

Thanks for this bug report. I think my reason for this was to copy the way Pod::To::HTML behaved at the time. This should be revised. I welcome any patches should you get to it before I do.

Unfortunately, it appears that fixing this requires a (major?) fix to rakudo. The contents of $=pod are a flat array, with no way to determine that a sub belongs to the class before it, and no way to identify that the variable is a parameter of the subroutine or method rather than a stand-alone. There is no nesting. The params are not in the contents of the routine they belong to.
I can't think of a hack to fix this in the short term. Long term I'm sure there are bugs open in rakudo for this, but I don't know which. I'd appreciate anyone linking relevant rakudo bugs here.

I've raised a Rakudo ticket


proper instructions

@bitnet-io please don't resolve conversations without actually resolving them

a lot of the suggestions here are opinonated changes. these docs are the opposite of that - they are generic minimally viable.

@bitnet-io please don't resolve conversations without actually resolving them

you guys are free to fix it using my proper instructions that work 100%
i was nice enough to help I'm not part of the stacks payroll as a developer or employee to be ripped apart like this for fixing it
you are welcome

@bitnet-io please don't resolve conversations without actually resolving them

you guys are free to fix it using my proper instructions that work 100%
i was nice enough to help I'm not part of the stacks payroll as a developer or employee to be ripped apart like this for fixing it
you are welcome

you don't have to like the suggestions,  we're simply asking you to remove your opinionated changes which improves the quality. you also don't have to make the changes, and we can discard this PR and you can wait until someone has the time to adjust on our side.

they aren't my opinions
they are technical facts so that the thing will function 100%
i did write anything opinionated
if i wrote something opinionated it would be something like this
" i really like stacks but I think it's a slow network if your transaction doesn't confirm because you have to wait 256 blocks to get your pending transaction back if it doesn't confirm"
that contains my personal opinion as an example that I like stacks and would be opinionated
everything I wrote contains 100% technical facts in order for the thing to operate normally and safely...

closing as spam

the facts...
the WIF key must be imported using
importprivkey
after creating a legacy wallet with Bitcoin
or it will not work
the facts...
Config.toml must contain the wallet name from Bitcoin or stacks-node will not properly connect with rpc
[burnchain]

wallet_name = "your-bitcoin-wallet-name"

the facts...
rpcallowip=<IP_ADDRESS>/0
is dangerous for unsuspecting users that expose the Bitcoin wallet internally to the WAN side of the Internet
the safest way is to keep rpc restricted only to localhost to listen for commands locally
rpcallowip=<IP_ADDRESS>
this protects the user so that the wallet's internal commands can't be accessed by anyone remotely on the Internet since there are constantly robots and scripts that scan IPs on the Internet for open ports with nmap to exploit IPs including ports
22,80,443,8332,9332


tools: Replace string functions with secure safe string

Changes:

Replace strlen() with strlen_s()
Replace snprintf () with snprintf_s_X ()

Not need


WebSocketMultiplayerPeer server crashes if it's configured with a TLS certificate.

Godot version
4.0.dev
System information
Windows 10
Issue description
If a WebSocketMultiplayerPeer server is configured with a TLS certificate, the program crashes whenever a client tries to connect.
I don't get any error messages (which is driving me crazy)
I tried with a self-signed (in Godot) certificate and a properly signed Let's Encrypt certificate, but same results.
Steps to reproduce

Configure a WebSocketMultiplayerPeer server with a TLS certificate
Try to connect to the server

Minimal reproduction project
test_client.zip
test_server.zip

https://github.com/godotengine/godot/blob/19c9fd6926b958016d562e3b2e93b0e9480300f5/modules/websocket/websocket_multiplayer_peer.cpp#L336-L350
Is line 345 causing the problem?

CC @Faless

4.0.dev

Please be explicit about the commit hash, "4.0.dev" spans 3 years of development.


set field always as array

Hello... how can i prevent this behavior
Object 1
{
cards_types: [ 2, 3 ]
}

Object 2
{
cards_types: 3
}

as you see in object 1 cards_types is an array, but in object 2 is a integer
this is a pice of my sql query:
SELECT
Descuento.discount_id as "_id",
DescuentoTipoTarjeta.tipo_tarjeta_id as "Discount.cards_types"
FROM discounts AS Descuento
LEFT JOIN r_discounts_tipos_tarjetas AS DescuentoTipoTarjeta
   ON DescuentoTipoTarjeta.discount_id = Descuento.discount_id

Here is my use-case:
I have a field "tags", that stores one or more strings as an array (or "multi value").
When i rename a tag globally, i issue an updateByQuery query with a replace script.
This script currently fails if the "tags" field is not an array (this happens if the entry has only one tag), because i expect the field it to be an array.
So the current behaviour forces me to handle the 2 cases (is array / is not array) separately in my script, and that sucks :)
I'd love an option to force certain fields to be multi-valued.

@smoove Having the exact same use-case.

@smoove @Frozire you can use rather convoluted scripts to still have 1 op
script: {
  inline: "ctx._source.tags = ctx._source.tags == null ? [tag] : (ctx._source.tags in String ? [ctx._source.tags] + tag : (ctx._source.tags.contains(tag) ? ctx._source.tags : ctx._source.tags + tag))",
  params: {
    tag: "foo"
  },
  upsert: {
    tags: ["foo"],
  },
}


Schema updates

Updating the config schema based on: https://github.com/CDCgov/cfa-epinow2-pipeline/blob/c9292dff551eba326dad62988beecb6b71f8a3c7/tests/testthat/data/sample_config.json
@zsusswein let me know if I missed anything.
Added:

generation_interval, delay_interval, right_trunction parameters
iter_warmup, iter_sampling sampler opts
converted as_of_date from timestamp back to iso format
fields for min/max reference dates

If there are any other schema changes that we anticipate but aren't in the cfa-epinow2-config pipeline yet, let's add them here.

@natemcintosh I agree; we should have some single source of truth and generate based on that for this service and the pipeline runner. Once we have this first pass version running we can think about how best to handle that

I'm currently attempting to run the epinow2 pipeline locally, and it expects a top level report_date field in the config. @zsusswein would that be the same as as_of_date in this case?

Since the as_of_date pertains only to the parameters (am I understanding that correctly?), maybe it would be worth renaming it params_as_of_date? Would potentially take a lot of work to change throughout the epino2-pipeline code base though.

Yeah this is a good point. I'm torn about it because I think it only relates to the params right now but it's a more general concept.
If we start pre-aggregating to state and national in the gold table then we'll want an as_of date there too.
But maybe that as_of date is different? Maybe it should be nested under the parameters key? Or if it's a general concept left at the top level?

As you say, if we do pre-aggregation, that would potentially be a different as-of date.
I really like your suggestion of putting it under the parameters key for now, to make it clear that it is specifically for the parameters. And if we do need the data as_of later, we can add it under the data key?

Just found one other thing. The data['path'] default currently points to a folder, and the reader tries to read that folder, as opposed to a file.
I think we should alter this
https://github.com/CDCgov/cfa-config-generator/blob/e897a1fc7e0f5ea6136016548d70967cf331fafb/utils/epinow2/functions.py#L26
to instead have a default of f"gold/{report_date}.parquet"

@natemcintosh done!


Rework dfs_server to gather state and expose all options

Have it actually grab the initial state and then converge if it's changed. This also exposes all the options in the cmdlet.
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

I think this makes this resource useful enough at this point that we can ship it in core.


fix Revert Fix Jemalloc hook failed to start BE with JDK 17

This reverts commit 5fee7157ccfc8ed88bc3405eb404a2916b5aac3e.
Proposed changes
#33946 exist two error:

unable to use jemalloc heap profile
maybe cause jemalloc memory not  to be freed.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Slider 'change' event is fired twice

Describe the bug
mwc-slider's 'change' event is fired twice on changes to the slider's value.
To Reproduce
Steps to reproduce the behavior:

Go to the official slider demo https://mwc-demos.glitch.me/demos/slider.html
Open Devtools Console (Ctrl+Shift+J / Cmd+Opt+J)
Attach an event listener to the sliders:
Copy this into the console

document.querySelectorAll('mwc-slider').forEach(slider => slider.addEventListener('change', console.log))

Adjust a slider and observe that two CustomEvents are logged

Expected behavior
A slider's 'change' event should only be fired once, as per the docs:

Change: Fired when the value changes and the user has finished interacting with the slider.

Screenshots

Browser Version (please complete the following information):

OS: Windows
Browser: Chromium Edge
Version: 80.0.361.56 (Official build) (64-bit)

Additional context

Perhaps the docs mean to say that the change event fires when the value has changed or the user is done interacting? I wouldn't think so, however since the 'input' event exists for the former.

Can't add labels myself, but this is Component: Slider

Seems to be an issue with the foundation setting event listeners on both mousedown and pointerdown. This is an issue with MDC library


CsvDelimiter parameter only works for 2 CSV files

After adding the -CsvDelimiter "," parameter when running the script, only 2 CSVs switched to using the proper delimiter:

perf.csv
ManagedIdentityUserAssignedAssociatedAzureResources.csv

All the other CSV files are still using the ";" delimiter.

@cjtous1 thanks for reporting. Do you want to file a PR (search export-csv)?


ngs: init at 0.2.16

close #344215
ngs is the next generation shell.
I defined a derivation because #344215 and https://github.com/ngs-lang/ngs/issues/661 requests this package.
https://github.com/ngs-lang/ngs
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Doesn't seem to build properly, here's the relevant log:
build flags: -j12 SHELL=/nix/store/izpf49b74i15pcr9708s3xdwyqs4jxwl-bash-5.2p32/bin/bash
[ 14%] Generating syntax.include
[ 14%] Generating errno.include
[ 21%] Generating pcre_constants.include
[ 28%] Generating stdlib.ngs.h
/nix/store/izpf49b74i15pcr9708s3xdwyqs4jxwl-bash-5.2p32/bin/bash: line 1: /build/source/build-scripts/make-errno-include.sh: cannot execute: required file not found
make[2]: *** [CMakeFiles/ngs.dir/build.make:89: errno.include] Error 127
make[2]: *** Deleting file 'errno.include'
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:84: CMakeFiles/ngs.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 28%] Built target man
make: *** [Makefile:146: all] Error 2

Doesn't seem to build properly, here's the relevant log:
build flags: -j12 SHELL=/nix/store/izpf49b74i15pcr9708s3xdwyqs4jxwl-bash-5.2p32/bin/bash
[ 14%] Generating syntax.include
[ 14%] Generating errno.include
[ 21%] Generating pcre_constants.include
[ 28%] Generating stdlib.ngs.h
/nix/store/izpf49b74i15pcr9708s3xdwyqs4jxwl-bash-5.2p32/bin/bash: line 1: /build/source/build-scripts/make-errno-include.sh: cannot execute: required file not found
make[2]: *** [CMakeFiles/ngs.dir/build.make:89: errno.include] Error 127
make[2]: *** Deleting file 'errno.include'
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:84: CMakeFiles/ngs.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 28%] Built target man
make: *** [Makefile:146: all] Error 2

Thank you for checking to build. What the platform did build this package on?

x86_64-linux, sorry for not specifying. I just tested it on an aarch64-linux box and I'm getting the same error, so it seems to be an issue with linux builds instead of an issue with the architecture.


TFKUBE-439: Refactored creating nfs pv and pvc

Pull request description
Provide description for the PR
Checklist

[ ] I have successful end to end tests run (with & without domain)
[ ] I have added unit tests (if applicable)
[ ] I have user documentation (if applicable)

Can you run e2e test?

@nghazali not sure how I feel about this change. NFS is now the new shared storage paradigm. We may decide to change this down line, but how likely is that? For me I think things are more cohesive and easier to reason with if we leave the NFS PVC with the NFS module?

I am closing this PR as result of the team decision for not separating PV-PVC from NFS module.


clear stale states when creating new one

This fixes the case when clearStaleState is never called in user code. Sooner or later window.localStorage is full and adding an additional state results in a QuoteExceededError.
Closes/fixes #466
Checklist

[ ] This PR makes changes to the public API
[x] I have included links for closing relevant issue numbers

@kherock would be nice if you have time to review this one...


Plugin for Effect.ts Schemas

Describe what you want
An extension to convert Drizzle DB Schemas to Effect Schemas to use them as Validators just like the drizzle-zod plugin.

There's a SQL Drizzle offical package https://github.com/Effect-TS/effect/releases/tag/%40effect%2Fsql-drizzle%400.1.0

actually, that package just enables to run the drizzle queries using the effect runtime,
it doesn't have a mechanism to create effect schemas based on drizzle table schemas
that's what I implemented here
https://github.com/drizzle-team/drizzle-orm/pull/2665


Creation of Dockerfile

I believe it would be beneficial for this project to include a Docker file to facilitate containerization. Consequently, I am contemplating the creation of such a file.

Hello @Aryangp,
Thank you for suggesting the addition of a Dockerfile to our project! It's a fantastic idea that will undoubtedly streamline the containerization process and enhance the project's scalability and deployment efficiency.
Rest assured, I'll prioritize the creation of the Dockerfile and integrate it into our project very soon. Once implemented, it will provide a robust foundation for containerization, making it easier for us to manage dependencies and deploy the application across various environments.
If you have any further suggestions or questions, please don't hesitate to let me know. Your input is greatly appreciated as we continue to improve our project.
Best regards,
Md Ariful Islam


Mainly a refactor to unify imports pages structure and types.

The goal of this PR is to make the template more consistent. I still have some big changes to make but this is a start.
The reason I made these changes are:

We might want to use this template and showcase how codux works with it.
I wanted to learn about the headless platform.

The changes mainly include:

Extracting page content to components.
Aligning all imports to use @app/.
Fixing some any types.

I would like to discuss what I think should be the next steps in the refactoring process.
I have not tested this extensively.
I have some insights to share regarding the headless API, specifically the data and UI.

👑

i just hope you tested everything because we don't have tests for 90% of the code here. if you are confident with your changes, go for it

I'm most worried about the tickets table in the event page as we barely have any coverage for all the cases there but i see that you didn't change it much.
overall it looks fine.


Enable to put module versions into compiler's build log.

Summary
This commit enables to put asakusafw-dag module versions into compiler's build log.
Background, Problem or Goal of the patch
The compiler's build log only includes information about terminal extensions, so that the assistant modules in asakusafw-dag were not appeared in it.
Design of the fix, or a new feature
see asakusafw/asakusafw-compiler#59
Related Issue, Pull Request or Code
asakusafw/asakusafw-compiler#59
Wanted reviewer
@akirakw

BUILD SUCCESS. <jenkins-prb-asakusafw-dag-32>


Document includeFilter setting

As per a conversation in Gitter, it would be great to document the use of includeFilter setting, to be able to include different extension files as part of the built microsite.
https://github.com/47deg/sbt-microsites/blob/0a8387363c2c87179c433ca406fd85d428ece6dc/src/main/scala/microsites/MicrositesPlugin.scala#L113
Inherited setting from sbt-site

Closed through https://github.com/47deg/sbt-microsites/pull/307 🙂


Add Argo Workflows and Events

This commit installs Argo Workflows and Events also replaces argocd-config with a helm chart argo-services, since this now configures the config for all Argo services (cd, cd-notifications, events). It also removes the ArgoCD Notifications configuration from Terraform, as this will be configured in argo-services.
Co-Authored-By: @fredericfran-gds
Trello: https://trello.com/c/h8F7nBbu/676-smoke-tests-after-each-deploy-by-app

I'll wait for https://github.com/alphagov/govuk-helm-charts/pull/20 to be merged before merging this one.


Refactor the test suite

This adds a test helper that creates a testing function, which is usually called thePlugin, which streamlines testing transforms. I’ve also gone through and edited some of the test names for clarity.

The cleanup looks good overall.. Thanks a lot 👍

This looks great!
I thought of moving it to fixtures based testing - each test case in 2 files - source.js and expected.js. But this is fine for now.


 This PR locks this down in order to prevent introducing new CC problems in the build.

@bot-gradle test and merge

OK, I've already triggered a build for you.

Your PR is queued. See the queue page for details.

Pre-tested commit build cancelled.

OK, I've already triggered a build for you.

I restarted the build to integrate a fix I just pushed.


Add Double Wilson Test

There's currently no test to make sure the Double Wilson code executes.

resolved by #170


google-cloud-sdk: 483.0.0 -> 485.0.0

Description of changes
Release notes:

485.0.0 (2024-07-23)
484.0.0 (2024-07-16)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks. Test on aarch64-darwin as well and builds fine.


alluxio fs startSync failed

ALLUXIO ENVIRONMENT:
(1) ALLUXIO 2.0.0
(2) HADOOP-2.7.3(HDFS)
(3) Hadoop client (Hadoop3.3)
(4) JAVA 1.8
we set the hdfs and we want to set dir /nn-cluster/user/bigdata/tensorflow/submarine sync to hdfs dir。when we execute the command：alluxio fs startSync /nn-cluster/user/bigdata/tensorflow/submarine ，it report errors：

can anyone give us some advices？

Hi @myg821561935 . It helps us if the initial post is in our standard format for bug reports. We ask that you follow the format next time.

You're initial post is not quite clear enough as to what HADOOP-2.7.3 means. Is this the UFS version?
What do you mean by Hadoop client. Is this what you're using to try to connect to Alluxio?

If my assumption in (1) is correct that your UFS is HADOOP-2.7.3, then the error message is accurate. ActiveSync is not supported on Hadoop versions < 3. From my limited knowledge ActiveSync relies on the DSFInotifyEventInputStream  which is not available in Hadoop 2.7.3 (I couldn't find it in their reference docs https://hadoop.apache.org/docs/r2.7.3/api/index.html)

yes，ufs hdfs version is 2.7.3. In this blog（https://www.alluxio.io/blog/two-ways-to-keep-files-in-sync-between-alluxio-and-hdfs/）, mentioning hadoop2.7+ is fine. Maybe I was misled. thanks

@yuzhu can you help take a look at this issue and verify the HDFS version required

I could be wrong as well.  I'll also make sure it gets added to our documentation. I noticed that at https://docs.alluxio.io/ee/user/stable/en/advanced/Namespace-Management.html?#metadata-active-sync-for-hdfs we don't mention version compatibility

@myg821561935 can you also provide your Alluxio master configuration?

@myg821561935 can you also provide your Alluxio master configuration?
ok
alluxio-site.properties.txt

Hi @myg821561935 can you try to configure the alluxio property alluxio.underfs.version?
https://docs.alluxio.io/os/user/stable/en/ufs/HDFS.html#using-site-properties
From the documentation, you should be able to put 2.7 as the value for this property. It defaults to 2.2: https://github.com/Alluxio/alluxio/blob/v2.0.0/core/common/src/main/java/alluxio/conf/PropertyKey.java#L3395-L3401

alluxio.underfs.version

thanks ,after configure alluxio.underfs.version=2.7 ,it's ok

@myg821561935 great to hear!


Output index in lsif format

I have checked that this feature is not already implemented

[X] This feature does not exist

Use case
Lots of tools online use the lsif file format to provide "smart" features related to a codebase. One of them is navigating around the codebase by clicking on class names in SCM tools (like GitLab). This project generates an index internally, used for navigating though the codebase, but it's not dumped to a file, and it doesn't use the lsif format.
Description
The index that ruby-lsp generates is dumped into a lsif file that I can use with other tools.
Implementation
No response

Thank you for the feature suggestion! Do you know how the exported LSIF is used by online tools? For example, if we were to expose an executable command to index and dump the LSIF:

When do you dump it? Is it manual or does the extension need to do it?
What do you do with the file? Do you need to upload it manually?

In terms of implementation, I think we should create an index exporting structure. Basically, we can have an abstract exporter that defines the interface and then we can create multiple exporters for LSIF, SCIP or any other formatter. That would also benefit caching (#1009 and #1040) since we could have a similar structure for importers.
I'm thinking something like this:
module RubyIndexer
  class Exporter
    extend T::Sig
    extend T::Helpers

    abstract!

    sig { params(index: Index).void }
    def initialize(index)
      @index = index
    end

    sig { abstract.void }
    def export; end
  end

  class LsifExporter < Exporter
    def export
    end
  end
end

Thank you for the context. Yeah, indeed I think providing an executable for the indexer will make the most sense 👍.


Add a Gitter chat badge to README.md

chzyer/adrs now has a Chat Room on Gitter
@chzyer has just created a chat room. You can visit it here: https://gitter.im/chzyer/adrs.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Coverage remained the same at 38.16% when pulling d4f85a93a2153f21d30868e5c93934a11c9ac6ec on gitter-badger:gitter-badge into ad835974571aff05783e9b6d127fd714d667a245 on chzyer:master.


Adds "View on map" button to Shows

Adds Map png
Adds "View on map" button to More shows components
TODO: Needs navigator function for onPress

Fails

:no_entry_sign:

[danger-plugin-jest] Could not read test results. Danger cannot pass or fail the build.

Warnings

:warning:

This PR comes from a fork, and won't get JS generated for QA testing this PR inside the Emission Example app.

  Generated by :no_entry_sign: dangerJS


Bug: Nameserver records are sometimes deleted in terraform state but still exist on INWX

I've had it multiple times that I deleted records in terraform, they appear to be deleted but still exist on INWX.  So I always need to manually check the records on the website, clean leftovers up so that terraform can work.
That's not how it's supposed to work. If terraform reports a resource as deleted, it should really be deleted.

In addition, sometimes entries are not created on the name server at all, but are nevertheless added to the Terraform state. So you really have to read the entire list of entries in the web UI to determine whether everything has been created correctly, which is very cumbersome and error-prone and takes forever with lots of entries.

Same here. Will be this fixed soon? Or do you know a partner company which supports terraform correctly?

Could you provide a sample configuration terraform file which reproduces this issue? Additionally is this issue limited to our live environment or does it affect OTE as well?

terraform {
  required_providers {
    inwx = {
      source = "inwx/inwx"
      version = ">= 1.0.0"
    }
  }
}

provider "inwx" {
  api_url = var.api_url
  tan = var.tan
  username = var.username
}

resource "inwx_nameserver_record" "a_records" {
  domain    = "mydomain.org"
  name      = "www"
  type      = "A"
  content   = var.a_record_ip
  ttl       = 3600
}

If you change the ip several times or destroy this entry, it will end up with a unpredictable state

Also affected by this. It's actually a big blocker as totally breaks the reasons to go for the provider.

That's not how it's supposed to work. If terraform reports a resource as deleted, it should really be deleted.

Wholeheartedly agree here. Trust in the provider is fundamental to using it. We can deal with the provider reporting errors and having to retry. But if terraform apply/destroy reports success, the expectation is that the final state matches reality.

Same here. Is there anything I can do to support solving the issue?

I already wrote to the INWX support and they don't really care and are not going to do anything against this issue.
Please write to the support as well. Maybe they will start to do something....

Done - as you you suggested. Let's see what happens.

Hi Guys,
It’s Montgomery from INWX and I would brief you shortly:
My colleagues had a lot of work in November and December (and a bit of vacation for some colleagues =D). That’s the reason why the fix is not released until yet.
My colleagues told me, that the bugfix is already in the actual sprint and in progress soon.
So, I’ll bet you guys to have some patience about this. We are working on that bug and release the fix as soon as possible!
All bests,
Montgomery

Got a similar answer like @montybanse‘s.
Gotta wait a little bit longer.

I couldn't reproduce this issue live either. If this problem still persists, please provide additional information: the output of the command which caused this error prefixed with TF_LOG=debug and either the domain/record/nameserver for which this problem persists or preferably the terraform.tfstate (since this can include sensitive information, you can send this via encrypted mail to support, if you prefer that).

Same here, I have the feeling if I wait one our before I change something. it is working "sometimes" but If I run my commands within 1-3 minutes. everything starts to break.

I tried it a second ago to change the TTL of my domain. It is not working ...
Terraform says:
Apply complete! Resources: 0 added, 1 changed, 0 destroyed.
But nothing changed


Support Portuguese

Support Portuguese
I will go translate for portuguese in seven days It will be ready!
I Can?

Go for it :) The more languages the better!

Yes, please do. :+1:

:+1:

Hi @andreustimm , have you finished the translation to PT-BR? I'm thinking about do it!

Hi @ricardofontanelli, i see that you make. I did not had time.
Thanks!


Yocto packagegroup-lxqt-base Failed tasks kwidgetsaddons do_compile

Hi,
I am building an image with Yocto Project (morty). The layer "meta-qt5-extra" includes the recipe "packagegroup-lxqt-base" in my project. However the building generated the following failed tasks:
/*
2 errors
oe_runmake failed
Function failed: do_compile (log file is located at /home/user-test/poky-morty/build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-linux-gnueabi/kwidgetsaddons/5.30.0-r0/temp/log.do_compile.20270)
*/
Why "kwidgetsaddons" generated these errors and how do I resolve this issue?
See below the build log for more details:
NOTE: Logging error 2: {'pathname': '/home/user-test/poky-morty/_toaster_clones/_git___git.yoctoproject.org_poky_morty/bitbake/lib/bb/init.py', 'lineno': 100, 'build': <Build: 105 Project object distro-with-lxqt>, 'message': 'oe_runmake failed', 'level': 2}
ERROR: oe_runmake failed
NOTE: Logging error 2: {'pathname': '/home/user-test/poky-morty/_toaster_clones/_git___git.yoctoproject.org_poky_morty/bitbake/lib/bb/build.py', 'lineno': 589, 'build': <Build: 105 Project object distro-with-lxqt>, 'message': 'Function failed: do_compile (log file is located at /home/user-test/poky-morty/build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-linux-gnueabi/kwidgetsaddons/5.30.0-r0/temp/log.do_compile.20270)', 'level': 2}
ERROR: Function failed: do_compile (log file is located at /home/user-test/poky-morty/build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-linux-gnueabi/kwidgetsaddons/5.30.0-r0/temp/log.do_compile.20270)
NOTE: recipe kwidgetsaddons-5.30.0-r0: task do_compile: Failed
ERROR: Task (/home/user-test/poky-morty/_toaster_clones/_git___github.com_schnitzeltony_meta-qt5-extra.git_morty/recipes-kde/kf5/tier1/kwidgetsaddons/kwidgetsaddons.bb:do_compile) failed with exit code '1'
NOTE: Logfile for task /home/user-test/poky-morty/build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-linux-gnueabi/polkit-qt-1/0.112.0-r0/temp/log.do_populate_sysroot.22244
NOTE: Logfile for task /home/user-test/poky-morty/build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-linux-gnueabi/polkit-qt-1/0.112.0-r0/temp/log.do_populate_sysroot.22244
NOTE: Logfile for task /home/user-test/poky-morty/build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-linux-gnueabi/kguiaddons/5.30.0-r0/temp/log.do_configure.22142
NOTE: Tasks Summary: Attempted 2115 tasks of which 2110 didn't need to be rerun and 1 failed.
NOTE: No package dependencies created
NOTE: No package dependencies created
WARNING: KeyError in save_target_file_information'dirs'
Would you please help me resolve them?
I thank you in advance.

On Sat, Nov 4, 2017 at 11:16 AM, denyste<EMAIL_ADDRESS>wrote:

Hi,
I am building an image with Yocto Project (morty). The layer
"meta-qt5-extra" includes the recipe "packagegroup-lxqt-base" in my
project. However the building generated the following failed tasks:
/*
2 errors
oe_runmake failed
Function failed: do_compile (log file is located at
/home/user-test/poky-morty/build-toaster-2/tmp/work/
cortexa7hf-neon-vfpv4-poky-linux-gnueabi/kwidgetsaddons/
5.30.0-r0/temp/log.do_compile.20270)
*/
Why "kwidgetsaddons" generated these errors and how do I resolve this
issue?
See below the build log for more details:
NOTE: Logging error 2: {'pathname': '/home/user-test/poky-morty/_
toaster_clones/git___git.yoctoproject.org_poky_morty/bitbake/lib/bb/
init.py', 'lineno': 100, 'build': <Build: 105 Project object
distro-with-lxqt>, 'message': 'oe_runmake failed', 'level': 2}
ERROR: oe_runmake failed
NOTE: Logging error 2: {'pathname': '/home/user-test/poky-morty/
toaster_clones/_git___git.yoctoproject.org_poky_morty/bitbake/lib/bb/build.py',
'lineno': 589, 'build': <Build: 105 Project object distro-with-lxqt>,
'message': 'Function failed: do_compile (log file is located at
/home/user-test/poky-morty/build-toaster-2/tmp/work/
cortexa7hf-neon-vfpv4-poky-linux-gnueabi/kwidgetsaddons/
5.30.0-r0/temp/log.do_compile.20270)', 'level': 2}
ERROR: Function failed: do_compile (log file is located at
/home/user-test/poky-morty/build-toaster-2/tmp/work/
cortexa7hf-neon-vfpv4-poky-linux-gnueabi/kwidgetsaddons/
5.30.0-r0/temp/log.do_compile.20270)
NOTE: recipe kwidgetsaddons-5.30.0-r0: task do_compile: Failed
ERROR: Task (/home/user-test/poky-morty/_toaster_clones/_git___github.
com_schnitzeltony_meta-qt5-extra.git_morty/recipes-kde/
kf5/tier1/kwidgetsaddons/kwidgetsaddons.bb:do_compile) failed with exit
code '1'
NOTE: Logfile for task /home/user-test/poky-morty/
build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-
linux-gnueabi/polkit-qt-1/0.112.0-r0/temp/log.do_populate_sysroot.22244
NOTE: Logfile for task /home/user-test/poky-morty/
build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-
linux-gnueabi/polkit-qt-1/0.112.0-r0/temp/log.do_populate_sysroot.22244
NOTE: Logfile for task /home/user-test/poky-morty/
build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-
linux-gnueabi/kguiaddons/5.30.0-r0/temp/log.do_configure.22142
NOTE: Tasks Summary: Attempted 2115 tasks of which 2110 didn't need to be
rerun and 1 failed.
NOTE: No package dependencies created
NOTE: No package dependencies created
WARNING: KeyError in save_target_file_information'dirs'
Would you please help me resolve them?
I thank you in advance.
Honestly - I am not using morty and it would cause lots of efforts for me
to check. Whatever:

A look into
/home/user-test/poky-morty/build-toaster-2/tmp/work/
cortexa7hf-neon-vfpv4-poky-linux-gnueabi/kwidgetsaddons/
5.30.0-r0/temp/log.do_compile
gives more information what goes wrong with kwidgetsaddons.

I do not know why "kwidgetsaddons" has failed.
I think the problem comes with "kwidgetsaddons" during the compiling.
What recipes "kwidgetsaddons" depend on?
I have looked carefully the "packagegroup-lxqt-base" but why is it not there?
I do not have more information about this error.
I only know that layers and recipes are working with OpenEmbedded.
The Yocto project uses OpenEmbedded to build an image.
There is two ways to build an image, one with "bitbake" (terminal) and the other with Toaster (web interface)
I only used Toaster.

You have further information. The first log you sent says:

ERROR: Function failed: do_compile (log file is located at /home/user-test/poky-morty/build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-linux-gnueabi/kwidgetsaddons/5.30.0-r0/temp/log.do_compile.20270)

And I suggested to look into that. Now I suggest to upload it here so I can look into.
Another suggestion: Could you try to build with bitbake to see if the error still occurs?

These two-way "user interfaces" (bitbake with terminal and Toaster with browser) are different paths and configuration files.
For example: /home/user-test/poky-morty/build/conf/local.conf, etc. and  /home/user-test/poky-morty/build-toaster-2/conf/toaster.conf, etc.
There are currently no configuration for "bitbake" (default settings), but the configuration files for "Toaster" are updated.
Please see below the last lines error code of the file log.do_compile.20270:
/home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtCore/qlist.h:382:13:   required from 'QList& QList::operator<<(const T&) [with T = QVariant]'
/home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtCore/qvariant.h:765:27:   required from here
/home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtCore/qlist.h:448:39: warning: cast from 'QList::Node*' to 'QVariant*' increases required alignment of target type [-Wcast-align]
else if (QTypeInfo::isComplex) reinterpret_cast<T*>(n)->~T();
^~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtCore/qshareddata.h:46:0,
from /home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtCore/qsharedpointer.h:45,
from /home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtGui/qpixmap.h:47,
from /home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtGui/qbrush.h:51,
from /home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtGui/qpalette.h:45,
from /home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtWidgets/qwidget.h:47,
from /home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtWidgets/qcombobox.h:43,
from /home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtWidgets/QComboBox:1,
from /home/user-test/poky-morty/build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-linux-gnueabi/kwidgetsaddons/5.30.0-r0/kwidgetsaddons-5.30.0/src/kdatecombobox.h:25,
from /home/user-test/poky-morty/build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-linux-gnueabi/kwidgetsaddons/5.30.0-r0/kwidgetsaddons-5.30.0/src/kdatecombobox.cpp:20:
/home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtCore/qhash.h: In instantiation of 'static QHash<K, V>::Node* QHash<K, V>::concrete(QHashData::Node*) [with Key = QString; T = QVariant; QHash<K, V>::Node = QHashNode<QString, QVariant>]':
/home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtCore/qhash.h:533:13:   required from 'static void QHash<K, V>::deleteNode2(QHashData::Node*) [with Key = QString; T = QVariant]'
/home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtCore/qhash.h:573:5:   required from 'void QHash<K, V>::freeData(QHashData*) [with Key = QString; T = QVariant]'
/home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtCore/qhash.h:252:45:   required from 'QHash<K, V>::~QHash() [with Key = QString; T = QVariant]'
/home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtCore/qvariant.h:779:30:   required from here
/home/user-test/poky-morty/build-toaster-2/tmp/sysroots/cubietruck/usr/include/qt5/QtCore/qhash.h:235:16: warning: cast from 'QHashData::Node*' to 'QHash<QString, QVariant>::Node* {aka QHashNode<QString, QVariant>*}' increases required alignment of target type [-Wcast-align]
return reinterpret_cast<Node *>(node);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: Leaving directory '/home/user-test/poky-morty/build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-linux-gnueabi/kwidgetsaddons/5.30.0-r0/build'
CMakeFiles/Makefile2:3914: recipe for target 'src/CMakeFiles/KF5WidgetsAddons.dir/all' failed
make[1]: *** [src/CMakeFiles/KF5WidgetsAddons.dir/all] Error 2
make[1]: Leaving directory '/home/user-test/poky-morty/build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-linux-gnueabi/kwidgetsaddons/5.30.0-r0/build'
Makefile:141: recipe for target 'all' failed
make: *** [all] Error 2
WARNING: exit code 1 from a shell command.
ERROR: Function failed: do_compile (log file is located at /home/user-test/poky-morty/build-toaster-2/tmp/work/cortexa7hf-neon-vfpv4-poky-linux-gnueabi/kwidgetsaddons/5.30.0-r0/temp/log.do_compile.20270)

Please find attached file [log.do_compile.zip]
log.do_compile.zip
All packages with the prefix "Qt" are version 5.7.1+git0+a55f36211e in my project.

Ahh - OK symptom is clear - will check later at home how to solve...

I have created a morty-next branch and hope that fixes your problem - it would take ages for me to test as I am in the middle of something else...
Be aware that it rebuilds a lot - qtbase was changed and let me know if the fix works for you.

There appears to be a new issue with the morty-next branch.
After the parsing,  the "tasks starting" are frozen (see the attached screenshot in jpg format).
X-lxqtshot-2017-11-08_10-21-23.zip
I have tried to build several times, but nothing happens.

To support there is more information required - log-files particularly - the screenshot tells me nothing.

Please refer to the following files:
"truncated_toaster_ui.log" from "toaster_ui.log" because the file was too large (13 MBytes),
truncated_toaster_ui.zip
and the file from /home/user-test/poky-morty/build-toaster-2/cache,
local_file_checksum_cache.zip
and copy and paste content from the terminal,
copy_content_terminal.zip
I hope that all of this will help you.

Most helpful information I found in truncated_toaster_ui.zip. Something times out. Since I never saw this kind of error and never used Toaster (and never will) I cannot help you on this.
I suggest you ask at yocto mailing list [1]. Tell your problem / the layers you added / add a link to this thread / mention that you use debian-9.1 (builder complained for that). I will follow the thread and if it turns out that it is meta-qt5-extra problem (or other layer I am involved) I try to fix.
For now I close this issue.
[1] https://lists.yoctoproject.org/listinfo/yocto

Ok ! I thank you for your support and suggestion.
Maybe later I will use the useful "bitbake" commands.


Pinning golang version for doc builds to 1.21.7

There is an ongoing issue with doc builds under dataplane-operator-docs-preview https://review.rdoproject.org/zuul/builds?job_name=dataplane-operator-docs-preview The new version of go 1.22 is not compatible with some of the source, due to several modules moving from experimental to builtins.

Might something like this be simpler:
---
- name: Test
  hosts: localhost
  vars:
    _golang_version: "-1.21.7"
  tasks:
    - name: Install required packages
      become: true
      ansible.builtin.package:
        name:
          - make
          - python3
          - golang{{ _golang_version | default("") }}
          - ruby

Another thought is maybe _golang_version should be defined outside this playbook in the projects job definition? i.e: [1]
The reason being this change will effect 3 projects and the other two jobs are not affected by go1.22. They can continue with whatever is install by default and dataplane-operator-docs-preview can be pinned.
[1] https://github.com/openstack-k8s-operators/data-plane-adoption/blob/main/zuul.d/jobs.yaml#L5

In principle this could work. As long as repos carry the version in question. History has proven that we can not rely on that.
By downloading it straight from source we avoid the issue completely. It is true that other projects are not affected.
But I'm not certain that will remain the case in the long run. GO does make breaking changes in minor versions.
Eventually we will hit this again.

/approve


Move SocialConnect packages into new repo (out of monorepo)

Context

I propose moving
phone number privacy packages + identity + encrypted backup to all to a new repo. (social connect)
these all depend on each other and depend on some other celo packages but other packages do not depend on them.
This will make releasing social connect easier, make celo sdks releasing simpler, and provide a home base for social connect which will help developers use that project more easily,

Source: This large issue:

https://github.com/celo-org/celo-monorepo/issues/10554

Tactics

moving away from celo tool to build/ deploy combiner
what does new repo structure look like?
who does what?

Meeting notes https://www.notion.so/clabsco/Social-dis-connect-277f0756c5d54bf2a381a4fe2526bac7


Respect imagePullPolicy for VMs

I'm working on DIND cluster that is set up with:
./demo.sh

There is image-server pod that serves QCOW2 images to virtlet daemon pod. Everything works fine, but if you update QCOW2 image inside image-server (folder /usr/share/nginx/html/), the update is not reflected on virtlet daemon. In fact, I can delete QCOW2 image from image-server and virtlet daemon can still spawn new pods based on this image 😅
Does virtlet daemon cache images somewhere? Is it possible to disable caching?

Image server in example is only for demo purpose. It's really not needed, you can use in pod definition any http accessible resource (http, https is planned for next 2 weeks).
Image after downloading by http is stored in local store (to be more precise, in libvirt store), just like docker images are stored in docker registry.
That's true that we don't have yet support for imagePullPolicy - it's a bug and hopefully will be quickly fixed.

Thanks for the answer @jellonek. Do you perhaps know how can I manually remove downloaded image from libvirt store? I'm able to connect to image-server container, but what to delete there? I queried
virsh vol-list volumes

but the volumes listed here seems to get deleted when qemu-system process exits.

Found it, it's /var/lib/libvirt/images/, thank you so much!

Yeah, it's in different pool. virsh pool-list will show you which are configured and we have two of them, volumes (pointing to /var/lib/virtlet) for storing disk drives generated for use as volumes, and default (pointing to mentioned /var/lib/libvirt/images/) which should contain VM images used to create snapshot disk, from which VM will be booted.
So now preferred method to "cleanup" old images is to use virsh vol-delete --pool default image_name. As we don't store any additional metadata for volumes in libvirt - also it could be safe to rm file directly from directory, but for future - it should be safer to use virsh for that ;)


Cannot validate fields of an object property

Hi, and first thank you for your great work.
I am using a simple schema with properties referencing other properties defined in a separate schema through a $ref like this:
{
  "$schema": "http://json-schema.org/draft-03/schema#",
  "type": "object",
  "definitions": {
  "adress": {
  "$schema": "http://json-schema.org/draft-03/schema#",
  "type": "object",
  "required": true,
  "properties":{
    "NUMRUE": {
      "type": "string",
      "title": "Numero"
    },
    "NOMRUE": {
      "type": "string",
      "title": "Rue",
      "Required": true
    },
    "COMPLRUE": {
      "type": "string",
      "title": "Complément"
    },
    "CDP":{
      "type": "string",
      "title": "Code postal",
      "description": "12345",
      "pattern": "^\\d{5}$"
    },
    "VILLE":{
      "type": "string",
      "title": "Ville"
    },
    "PAYS":{
      "title": "Pays",
      "$ref": "#/definitions/adress/definitions/country",
      "required": true
    }
  }
  }
  }
  "properties": {
    "ADRESSE_CLI":{
      "type": "object",
      "title": "Adresse",
      "$ref": "#/definitions/adress"
    }
}

The issue is when validating the generated form the individual nested "adress" properties are not validated even though they are marked as "required" and leaved empty.
Did I miss something?
Notes:

I am new to js...
My final schema is populated recursively with the various separated sub-schema by inserting each of them into the top level schema "definitions" node.
The issue is the same with your "Definitions ($ref)" example when adding "required": true to d1

Hi!
You wrote

"NOMRUE": {
"type": "string",
"title": "Rue",
"Required": true
},
but "required" has to be in lowercase.
This should fix your problem....
Cheers!

As simple as that!
Thanks it works.
But, what about the $ref example?

That is a good question @joguiMultimedia!
Yes, it is the expected behavior. Nested required properties trigger a validation error when:

The whole object is also required and the property is empty
The whole object is not required, but it is being instantiated (other properties are informed)

It might be a little confusing at first, but it has sense. Think about an object that is not required, but some of its properties are. It is legal to not informing it, but if informed the property has to be informed also.
Cheers

It does make sense indeed.
The confusion in my mind was that the object does not really exist (in terms of instanciation) even though the form's fields are displayed.
Thanks for fast and accurate reply!


Adding my Community named Tech Empire

Hello @itstalmeez! The 2023 event for Global Azure is now behind us. We will very soon open up for Global Azure 2024 locations to be submitted. Please return at such time for the new event ahead! Make sure you are a member on our web site so that you will receive comms for when it is time to submit your location! Looking forward to interacting with you then! thanks! M/

So I can;t apply in 2023?

That event was in the spring of this year. No, this has already past!


Fix htlc example

It used to fail because of failed txn, commented it, added error throw, doesn't need update in changelog

We need to comment the failing txn, it was causing the error, after commenting it we need to build it else the same code runs as it is written in typescript

Pre-approving. Please update the changelog before merging

But there isn't any change which needs to be added in changeLog


eshop >= 8.0.0 with mongodb instead of NoSQL Embedded ?

Anyone can provide some examples integrate eshop with mongodb ? I tried with sqlagent but it wasn't working.

Hi,  it doesn't support MongoDB. Why do you want to use MongoDB? How many products do you expect?

I got some exists system I want to integrate with. So even with sqlagent, I can't change models code to support MongoDB right ?

No, eshop is optimized for Total.js NoSQL embedded database only... You can change the models but it takes much time....

Thank you for answer.


The link to the prebuilt binaries does not work.

This link on the homepage doesn't work. Its a 404.

Thanks for the report! I've just removed the link. Looks like the gobuild.io service has been discontinued.


UserWarning: This overload of add_ is deprecated

With torch==1.5.0 the following user warning is displayed when using AdaBelief -
/pytorch/torch/csrc/utils/python_arg_parser.cpp:756: UserWarning: This overload of add_ is deprecated:
        add_(Number alpha, Tensor other)
Consider using one of the following signatures instead:
        add_(Tensor other, *, Number alpha)

Wow, thanks for the feedback, will correct this later