[I tensorflow/contrib/lite/toco/import_tensorflow.cc:1080] Converting unsupported operation: ReadVariableOp

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mac
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
binary
TensorFlow version (use command below):
1.12.0
Python version:
Python 3.6.5 :: Anaconda, Inc.
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
N/A
GPU model and memory:
N/A

You can collect some of this information using our environment capture script
You can also obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the current behavior

I am trying to convert a graph from .pb to .lite format using toco, but I get this error:
2018-11-26 03:31:18.511856: I tensorflow/contrib/lite/toco/import_tensorflow.cc:1080] Converting unsupported operation: ReadVariableOp
I think ReadVariableOp is the basic op, Lite shoud support it.

@jason9693  Please add it here #21526


Unable to access private room on staging but shows a page with composer on production

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging dot at first and login with User A
Create a new workspace and invite User B
Create a new room in PRIVATE mode
Send a message to that room
Click on header and copy the share URL of the room
Now on another web chrome, login with User B and paste the URL on the tab on User B side
Result: See that on User B, it shows 'unable to access the chat' even when the User B was invited to the room
Follow the same steps on production app and see that 'Unable to access' message is not shown. Instead a blank page with chat composer is shown. Inconsistency between staging and production environment is seen

Expected Result:
Should be able to access private room on staging
Actual Result:
Unable to access private room on staging but shows a page with composer on production
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.28-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/ff559641-9558-4b9b-9a0d-6220b6898033
https://github.com/Expensify/App/assets/43996225/a0bdcddf-3d81-4a00-9771-cea9e8dee6ba
Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686722925761399
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a9b420914de094eb
Upwork Job ID:<PHONE_NUMBER>334002176
Last Price Increase: 2023-06-15

Thanks @avi-shek-jha for asking in the Slack thread that, if it's on staging only, should it be a deploy blocker.  I asked https://expensify.slack.com/archives/C049HHMV9SM/p1686867131810959?thread_ts=1686722925.761399&cid=C049HHMV9SM and internally.
@amyevans wasn't sure about internal/external

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@mallenexpensify @kavimuru are we certain the conversation should actually load, and that what we're seeing on staging isn't by design? The thing is, the video doesn't show the channel actually loading, it just shows the skeleton UI that suggests it's loading

cc @dukenv0307 @fedirjh @aldo-expensify  is it possible this is by design, and was implemented in this PR?

I wondered the same thing @cead22 .  But "Private" appears to mean "Private to the workspace", so the chat should load if a user is a member of the workspace (as it does on production).   Since this is a deploy blocker, let me test again

Tested again and was able to reproduce

Discussing here
https://expensify.slack.com/archives/C01GTK53T8Q/p1686868596435629

Maybe this isn't caused by that PR since it is on staging and production, so the behavior from the PR should be the same on both

Upon multiple retests (where I double checked I was logged in on both production for User B with the correct accounts) I was unable to produce.
Where I think the problem is is that, when creating a new room, we state People invited to this room can find it and... there's no way I can find to invite people to the room.

Bumping to weekly since it needs reproduction and/or it might be a feature request?  Will dig in soon-ish

Still need to look into

I'm going to close this for now since I wasn't able to reproduce and Vit mentioned this a few weeks ago

I am not sure about the each behaviour either but we definitely do not have the invite flow implemented.

I think we're planning on addressing this flow but it'll take a while to get everything fleshed out


Create custom field for tracking lastUpdated time for news, magazine and localNews

https://equinor.slack.com/archives/C01A4BGNRMJ/p1720690169328049?thread_ts=1720511418.101329&cid=C01A4BGNRMJ

@meols I have added the custom field for the lastModifiedAt, this works similar to the firstPublishedAt field, which gets updated everytime someone publishes a news, localNews, magazine.

Great Padmaja! There isn't anything I can test for this - or?

@meols There isn't much to test here except that you will find an extra property called "lastModifiedAt" when you inspect in studio ( similarly how to find the _lang field). While we migrate, we run the script to populate this property based on the _updatedAt property for all the existing news. For the new ones it will be set everytime you publish

Sounds good, Padmaja :thumbsup:


IconPicker doesn't fit on iPad third column

The icon size should probably be dynamically set

It's still offcenter

everywhere really

iPad 7th gen


Fixing memory leak in uncompressed audio and video processing.

Frames allocated with av_frame_alloc need to be freed with av_frame_free
Thanks to @mcosmin222 for finding the issue. Issue #142

Looks good so far. I don't think we still need to unref the frames first, av_frame_free seems to do that automatically according to docs.

Ok, I've run the changes over night on a WP8.1 app on a phone with 1GB of memory to test long running performance and the app remained stable. I think it is good now.


@enroute decorator does not fit periodic events

As we've discussed in #400 it's somewhat weird to have the periodic events grouped within @enroute.
We've come to agree that moving it to an independent decorator doesn't make any good either, so the one possibility remaining is to think of a new name for @enroute. Maybe something like binding ports and adapters might be good? :man_shrugging:

Closing this issue as it is moved to https://github.com/minos-framework/minos-python/issues/74


feat(seo): introduce dynamic sitemap.xml and robots.txt

:tada: This PR is included in version 1.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Multi-image Comparison ?

Hi,
First, I'd like to congratulate and thank you for this great tool which is really amazing both on desktop and mobile.
Do you think it might be possible in a future version to allow multiple image comparison like what is done in this plugin but is not "mobile friendly" and still has some flows?
https://github.com/Elphel/sravnitel
Thanks a lot.
Best regards,
Stephane.

You can achieve this affect today just by changing out the image from some control.

@raphaeleidus could you provide a code example?


campbell_diagram_data.m Needs to be Updated for Recent Linearization Upgrades to OpenFAST

The  campbell_diagram_data.m script provides a useful representation of the eigensolution so as to enable users to interpret the eigenvectors and eigenvalues resulting from the MBC3 analysis in terms of the full system natural frequencies, damping ratios, and mode shapes.  However, the script has not been updated to reflect recent improvements to OpenFAST involving linearization of SubDyn, MoorDyn, AeroDyn, and the structural control (StC) submodel of ServoDyn.  A few improvements are warranted:

For the ElastoDyn and BeamDyn states, only the displacement states are included in the eigenvectors because the velocity states contain redundant information.  However, both the displacement and velocity states from MoorDyn are currently included.  These velocity states should be removed from the reported eigenvectors.

The script applies scaling to the blade and tower translation states of ElastoDyn and BeamDyn so as to ensure all states represented in the eigenvector have similar units (radians).  That is, the blade translation states are scaled by one over the blade length and the tower translation states are scaled by one of the tower length, effectively converting the translation in meters to an equivalent slope in radians.  Similar scaling should be added for the platform transnational displacements in ElastoDyn (based on the tower length) and the mooring line translational states in MoorDyn (based on the water depth).  Likewise, a scaling of the C-B mode states in SubDyn and the StC states in ServoDyn should be developed.

Aerodynamic states from the DBEMT and UA submodels of AeroDyn can now be included in the linearized state-space matrices derived from OpenFAST.  It is desired to account for the effect of these aerodynamic states on the frequencies and damping of the structure, but not to have aerodynamic modes themselves show up in the eigensolution.  A way to eliminate the aerodynamic modes from showing up in the eigensolution should be developed.

Regarding MD:
The velocity states in the model we were looking at may be due to that particular OF code that was run.  That branch was missing the updates to MD and the glue code to fix the ordering of the MD states.


astro comments not working "invalid comment string"

astro has a treesitter parser, but it seems Comment and treesitter aren't fully playing together out of the box. Wanted to check in here before going down the JoosepAlviste/nvim-ts-context-commentstring route.
Commenting in the typescript 'header' part of a .astro file works.
eg:
---
typescript -> here it works
---
<html> -> here does not

In the html section, attempting to comment returns the error:
[Comment.nvim] Invalid commentstring for astro! Read `:h commentstring` for help.

Should they be working by default (as per the readme statement -> if treesitter parser, then it works)?
Or is astro an edge case as it's a relatively new format?

Try to check the parsed tree (using Playground) and the language you are getting at the <html> node, I guess there must be something funny going on.

Yup. The html is defined as astro for its language.
Adding this to my config works.
require('Comment').setup()

local ft = require('Comment.ft')
ft.set('astro', '<!--%s-->')

thanks. I will make a PR for this.


Unexpected exception importing platform custom_components.xiaomi_gateway3.climate

Since the latest core update (2024.1.0b0), I get:
2023-12-28 15:16:01.463 ERROR (MainThread) [homeassistant.loader] Unexpected exception importing platform custom_components.xiaomi_gateway3.climate
2023-12-28 15:16:01.486 ERROR (MainThread) [homeassistant.setup] Unable to prepare setup for platform 'xiaomi_gateway3.climate': Platform not found (Exception importing custom_components.xiaomi_gateway3.climate).

I had no issue before the update (12 different devices working well)

Same here. Core 2024.1.0b0 & 2024.1.0b1
Unable to prepare setup for platform 'xiaomi_gateway3.climate': Platform not found (Exception importing custom_components.xiaomi_gateway3.climate). Unable to prepare setup for platform 'xiaomi_gateway3.sensor': Platform not found (Exception importing custom_components.xiaomi_gateway3.sensor).
  File "/home/homeassistant/.homeassistant/custom_components/xiaomi_gateway3/sensor.py", line 42, in <module>     "power": POWER_WATT,              ^^^^^^^^^^ NameError: name 'POWER_WATT' is not defined
  File "/home/homeassistant/.homeassistant/custom_components/xiaomi_gateway3/climate.py", line 14, in <module>     HVAC_MODE_OFF: CURRENT_HVAC_OFF,     ^^^^^^^^^^^^^ NameError: name 'HVAC_MODE_OFF' is not defined

Logger: homeassistant.setup
Source: setup.py:403
First occurred: 8:22:42 PM (1 occurrences)
Last logged: 8:22:42 PM
Unable to prepare setup for platform 'xiaomi_gateway3.climate': Platform not found (Exception importing custom_components.xiaomi_gateway3.climate).
Logger: homeassistant.loader
Source: loader.py:842
First occurred: 8:22:42 PM (1 occurrences)
Last logged: 8:22:42 PM
Unexpected exception importing platform custom_components.xiaomi_gateway3.climate
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/loader.py", line 842, in get_platform
cache[full_name] = self._import_platform(platform_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/loader.py", line 859, in _import_platform
return importlib.import_module(f"{self.pkg_path}.{platform_name}")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 1204, in _gcd_import
File "", line 1176, in _find_and_load
File "", line 1147, in _find_and_load_unlocked
File "", line 690, in _load_unlocked
File "", line 940, in exec_module
File "", line 241, in _call_with_frames_removed
File "/config/custom_components/xiaomi_gateway3/climate.py", line 14, in
HVAC_MODE_OFF: CURRENT_HVAC_OFF,
^^^^^^^^^^^^^
NameError: name 'HVAC_MODE_OFF' is not defined

HA Core 2024.1 is now here and this beta issue is now a reality in prod.

Same problem here!

Logger: homeassistant.loader
Source: loader.py:842
First occurred: 上午11:36:06 (1 occurrences)
Last logged: 上午11:36:06
Unexpected exception importing platform custom_components.xiaomi_gateway3.sensor
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/loader.py", line 842, in get_platform
cache[full_name] = self._import_platform(platform_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/loader.py", line 859, in _import_platform
return importlib.import_module(f"{self.pkg_path}.{platform_name}")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 1204, in _gcd_import
File "", line 1176, in _find_and_load
File "", line 1147, in _find_and_load_unlocked
File "", line 690, in _load_unlocked
File "", line 940, in exec_module
File "", line 241, in _call_with_frames_removed
File "/config/custom_components/xiaomi_gateway3/sensor.py", line 42, in
"power": POWER_WATT,
^^^^^^^^^^
NameError: name 'POWER_WATT' is not defined
Logger: homeassistant.setup
Source: setup.py:403
First occurred: 上午11:36:06 (2 occurrences)
Last logged: 上午11:36:06
Unable to prepare setup for platform 'xiaomi_gateway3.climate': Platform not found (Exception importing custom_components.xiaomi_gateway3.climate).
Unable to prepare setup for platform 'xiaomi_gateway3.sensor': Platform not found (Exception importing custom_components.xiaomi_gateway3.sensor).

Hi, the same problem..

Hi, same problem.

https://github.com/AlexxIT/XiaomiGateway3/pull/1246/commits/4d92d50f1488ed9f80d76e89e717b74da9710b66
This is fixing the problem for persons who dont want to rollback or wait.

To apply #1246 PR quickly, go to your .homeassistant directory and run
curl https://patch-diff.githubusercontent.com/raw/AlexxIT/XiaomiGateway3/pull/1246.patch | git apply --check -v

(to check that everything will be applied successfully) and then
curl https://patch-diff.githubusercontent.com/raw/AlexxIT/XiaomiGateway3/pull/1246.patch | git apply

for me it does not work :(
Thanks

Ok my mistake i was outside .homeassistant directory it WORKS
Thanks

I applied #1246.  It works !

Thank you :).. it work

how to apply? from file manager? ssh command line? tried from file manager-settings-run shell command- didnt change anything, from ssh i couldnt change directory

I did it over ssh , i have haos

I did it over ssh , i have haos

how did you change directory?

cd homeassistant/

I get this error... The patch looks like an email... is that right?

You forgot to use curl at the beginning of command.

You forgot to use curl at the beginning of command.

Thanks, For some reason when I pasted into the terminal, it dropped the curl command and added a tilde ~ to the end of it... Hmm probably arising from using a mac... thanks for your quick reply though, I noticed the problem and tried to delete my comment, but you were too quick to reply!

@Chupaka Thank you for sharing!It does work.

@Chupaka thank you
It works !

The patch has been merged and is available as part of the master branch.
To install it formally, use the "Redownload" option in the 3-dot menu in the HACS web interface:

..and choose master (not v3.3.4).
Once downloaded, you will need to restart HA for the changes to take effect.

"master" asks for update and installs 3.3.4 and the error returns.

Sorry, yes that is correct. You should not upgrade.
I have updated my above comment:

After restart, you will be prompted about a pending update (to v3.3.4) - do not upgrade until v3.3.5 is released. If further fixes are released in the meantime, just redownload master and restart again.

https://github.com/AlexxIT/XiaomiGateway3/releases/tag/v3.3.5


Possibility to use identity acquired from system certificate store

Private key chains stored in Windows certificate store are often marked as non-exportable and cannot be acquired into the application, but they still have to be used as an identities during TLS handshake.
Would it be a huge effort to implement this in native-tls? I'd imagine for example TlsConnectorBuilder having an extra method like system_identity(true) which will assume whatever default keystore from the system.
On openssl-based systems that would probably do nothing.

I'd recommend using the schannel crate directly if you want to do Windows-specific stuff.

The problem is that it won't be integrated into native-tls and, as a consequence, into tokio-tls and the whole tokio thing. A lot should be reimplemented, and the code must be kept platform-independent.
I can do this in a fork and later submit a PR for review, if that kind of functionality would be accepted as a feature.

Sorry, wasn't meant to close the issue.

Someone can make tokio-schannel.


Add build hook tests

Summary of Changes

Add test to run build trigger (stage) and confirm successful message appears

Update: Test now logs in as a publisher to test the build trigger

Add test to confirm only publisher and administrator roles have access to build trigger

Update: Test now updated to use the "Preview Changes" button to test.

Build Results

drupal-8-composer Build with the Tests running successfully
Gatsby Build triggered by test
Stage site that gets updated as a result of gatsby build vs the Live site that hasn't been updated yet

Pull Request Checklist
Is Content created by the story?

[x] No
[ ] If yes, the content is:

[ ] Accessible
[ ] Mobile-friendly
[ ] Version-controlled
[ ] Governed by appropriate roles and permissions
[ ] Organized by taxonomy

Are there User-facing changes in the Drupal UI?

[ ] No
[x] If yes, then:

[x] User documentation is updated
[ ] User training is updated [No training exists yet]

Are there Upstream Code changes?

[ ] No
[x] If yes, then:

[x] Code is complete and commented.
[x] Code is secure to the best of our knowledge and does not contain anything that cannot be on a public repo (e.g. passwords)
Is a test necessary?

[ ] No
[x] If yes, then:

[x] Add a test if existing tests do not effectively test the code change
[x] Test passes

[x] Pull request (PR) is mergeable with develop branch
[x] PR has a meaningful title
[x] PR has a summary of changes
[ ] PR is peer reviewed and meets team standards.
[ ] PR builds without error

@brharp I can probably rewrite the test in that manner. It would take more time to run the test, but it's probably doable. Did you want me to update the test so it also involves a publisher logging in and checking that the button is available?
Note that I would still need to somehow confirm that all other roles (besides publisher and administrator) do not have the permission. Rather than logging in as every other role and confirming that the role fails to access the button, I still believe it's more efficient to check via the permissions page that only publisher and administrator have the expected permissions.

@brharp Updated the test so the build trigger check logs in as a publisher prior to pressing the button. That way we can confirm the publisher is able to both see and trigger the button at the same time.
In order to confirm that ONLY publishers and administrators can view the button, I still left the second test so that it checks the permissions page. That way in future, if more roles are added, we don't have to attempt to log in as every single role. If you disagree, let me know and we can discuss.
One thing - I am wondering if we should create a "test" release pipe to use as the button trigger OR if you want it to be testing the real release build hook (a.k.a. the Preview Changes button). Right now it triggers the real build. Let me know if you want me to update it to trigger a "test" release pipeline instead.

Note: I'm updating DrupalTest to include some of the more generic methods. Once the artifact appears on the uoguelph, I can update the tests so they call the generic methods. (Although for now, if you think the tests are okay to merge, we may as well merge them now.

The tests worked for me.
I'm still not convinced that checking the permissions page is the best way to assert the correct permissions.  We don't need to test all other roles, we only need to make sure that if you have one of the required roles you can trigger the build, and if you do not have any of the required roles you cannot.
I have also seen Drupal tests that generate a role with the required permissions and use that for testing.

@brharp Hey Brent, based on discussions yesterday, I've updated the tests as follows:

BuildHookSuccessful test logs in as publisher and tests the build hook
BuildHookOnlyVisibleForPublisherAndAdmin test logs in as a publisher and confirms build hook page is visible, then logs in as a user who has all roles except publisher/administrator and confirms access is denied.

I'm satisfied with this logic (and you convinced me about the usefulness of logging in for the tests). Let me know if both work for you and if you'd like to see any changes.


chore(deps): update terraform terraform-ibm-modules/client-to-site-vpn/ibm to v1.7.23

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/client-to-site-vpn/ibm (source)
module
patch
1.7.22 -> 1.7.23

Release Notes

terraform-ibm-modules/terraform-ibm-client-to-site-vpn (terraform-ibm-modules/client-to-site-vpn/ibm)
v1.7.23
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the landing zone da extension (#330) (3ed38a9)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 7.1.0 :tada:
The release is available on:

GitHub release
v7.1.0

Your semantic-release bot :package::rocket:


⬆ Upgrade actions/checkout

When i use upptime, i get this:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16<EMAIL_ADDRESS><EMAIL_ADDRESS>
I found it caused by actions/checkout.
Now, it had upgraded to v3 to use node16.

Let's upgrade it!

I have read the CLA Document and I hereby sign the CLA

recheck


ABI Serializer should be best effort and fail gracefully

Description
When an exception is thrown while trying to extract a data blob into a more-human-readable variant using the ABI in the ABI serializer, this exception bubbles all the way to the top.  This potentially fails the conversion when the ABI and the serialized data do not match.  In these cases, the ABI serializer should be considered "best effort" where data blobs which cannot be extracted remain as data blobs but the conversion proceeds to success.
Acceptance Test Criteria

[ ] a transaction or block with incorrectly serialized but non critical data (the value of a nonce or the memo on a transfer) do not fail to deserialize.  They may not completely deserialize.
[ ] a transaction or block with missing types in the ABI does not fail to deserialize.  They may not completely deserialize
[ ] a transaction or block with a missing or corrupt ABI does not fail to deserialize.  They may not completely dererialize

I'm going to extend this issue to include missing or incomplete ABIs.

Upgraded this bug/issue to fix reports like #2345 and #2218 at the abi serializer level as well so that we never hide success/failure of the real operation from the user and favor serialized output when errors occur.

@wanderingbort @heifner I believe that this was handled via other issues.  If I don't hear from you I will presume that is the case.

Parts of this was incorporated through other issues and the rest were OBE (Overcome By Events).


Cannot find a model when generating angular classes with grunt or lb-ng

I started to customized the scaffold project adding loopback-component-passport and a basic user authentication system (I've already done directly in loopback and it works).
I added a new model in /common/models/user-credential.json like so
{
"name": "userCredential",
"plural": "userCredentials",
"base": "UserCredential",
"properties": {},
"validations": [],
"relations": {
"user": {
"type": "belongsTo",
"model": "AppUser",
"foreignKey": "userId"
}
},
"acls": [],
"methods": {}
}
and updated model-config.json like so
{
"_meta": {
"sources": [
"loopback/common/models",
"loopback/server/models",
"../common/models",
"./models",
"./node_modules/loopback-component-passport/lib/models"
],
"mixins": [
"loopback/common/mixins",
"loopback/server/mixins",
"../common/mixins",
"./mixins"
]
},
"userCredential": {
"dataSource": "db",
"public": false
},....
Even if the new "sources" field for passport is correctly defined when launching grunt or lb-ng I get an error that userCredential cannot be found.....
Any hint?

@dev-augmenta
I'm not able to reproduce this one. I feel like there's more to this configuration than just an npm i loopback-component-passport. Have you included any other packages or introduced any other code?
By simply scaffolding and adding this code to the common models I'm not experiencing any errors, but I'm not seeing any new functionality either, so I must be missing something.


domainName is invalid.  Certificate creation failed unexpectedly for this domain

I'm getting the following error message when attempting to add custom domain:
domainName is invalid.  Certificate creation failed unexpectedly for this domain: DOMAIN.TLD

This is rather unexpected issue as I was able to use SWA with two other custom domains, and had zero issues with it.

This issue seems to have been resolved on its own.


Add SPM support

This PR adds support for Swift Package Manager (and closes #27).
I added explicit UIKit imports to all source files that needed it. It wasn't a problem in Cocoapods, but when imported through SPM, the individual source files need to import UIKit or the compiler will fail.

@colejd Do you mind tossing something in the README for SPM? Then we're good to go.

Done @heyltsjay


[MS2] Reactive element 3: Density plot

Implement the density plot visualization of the dashboard complete with interactivity.

done.


'debugger' statement in the tsserver assert function?

When there is an assertion failure in the tsserver, then the tsserver appears to hang to the user without any visible indication of the error state. This is caused by a debugger statement inside the assert function. This will make the tsserver wait until a debugger attaches. This makes good sense under development, but it is confusing to the user in production.
        function assert(expression, message, verboseDebugInfo) {
            if (!expression) {
                var verboseDebugString = "";
                if (verboseDebugInfo) {
                    verboseDebugString = "\r\nVerbose Debug Information: " + verboseDebugInfo();
                }
                debugger;
                throw new Error("Debug Failure. False expression: " + (message || "") + verboseDebugString);
            }
        }

Is the node process for tsserver started under debug? do you have TSS_DEBUG set?

I was under the impression that debugger; is a no-op when a debugger is not attached.  Kind of odd it would hang like that.

Closing I had the TSS_DEBUG environment variable set.


[WIP] Add test logs as a PR comment

Description
Add a PR commenter bot to add a link to the PR test log as a PR comment.
Which issue(s) does this PR fix

Fixes [Test automation] Integrate PRs with CI infra to add links within PRs to test logs

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

looks good; only negative commment is that the comment says "finished with errors" but the test shows a checkmark for a successfully completed pipeline:

looks good; only negative is that the comment on teh PR says "finished with errors" but the test shows a checkmark for a successfully completed pipeline:

Might be nice (if possible) to make the "fnished with errors" bold or red or just more obviously wrong. :D

Thanks @nickboldt. Yes, as I mentioned in the demo, this issue that you mentioned is a known issue and already handled with this PR. BTW, I didn't expect any review as it's a draft PR. :)

I didn't expect any review as it's a draft

Yeah, I know you mentioned this was a known concern. I just wanted to write it down to avoid it getting lost.

looks good; only negative is that the comment on teh PR says "finished with errors" but the test shows a checkmark for a successfully completed pipeline:

Might be nice (if possible) to make the "fnished with errors" bold or red or just more obviously wrong. :D

Your wish came true. :) I added code to make the test result displayed in boldface.

Ready to be merged.


Laravel 8

Suggested updates for laravel 8.   I am suggesting a new branch as laravel 8 upgrades to symphony 5.
Includes edits by @npostman
Welcome any additional suggestions.

Not yet ready

Confirmed functional.   Misread configuration

Implemented and confirmed to work with L8.6.0. Thanks @bryanrscott

Acknowledgement link
https://github.com/squareboat/sneaker/pull/57

Up and running in Laravel 8. Thanks @bryanrscott

@JorisDebonnet Agree and have updated README as suggested

@JorisDebonnet Agree and have updated README as suggested

Okay, uh, but it's not 100% as I meant now 😄
My suggestion for the 'mathematically most correct' version was this:
#### For Laravel <= 5.2, please use the [v1 branch](https://github.com/squareboat/sneaker/tree/v1)!
#### For Laravel 5.3 <= version <= 6.x, please use the [v5 branch](https://github.com/squareboat/sneaker/tree/v5)!
#### For Laravel 7.0 <= version <= 8.x, please use the [v7 branch](https://github.com/squareboat/sneaker/tree/v7)!

Alternatively, 'plain English' could be even easier to read:
#### For Laravel up to 5.2, please use the [v1 branch](https://github.com/squareboat/sneaker/tree/v1)!
#### For Laravel 5.3 to 6.x, please use the [v5 branch](https://github.com/squareboat/sneaker/tree/v5)!
#### For Laravel 7 and up, please use the [v7 branch](https://github.com/squareboat/sneaker/tree/v7)!

Yes Laravel 8 would need a seperate branch.

Hopefully Laravel support for version 8 can be added soon.

Hopefully Laravel support for version 8 can be added soon.

For what it's worth, here's how to use bryanrscott's fork in your own project (that's what I'm doing at the moment) in order to use Sneaker with Laravel 8:
composer.json
{
    "require": {
        "squareboat/sneaker": "dev-master"
    },
    "repositories": [ { "type": "vcs", "url": "https://github.com/bryanrscott/sneaker" } ],
}

Hi, I just ported my application to Laravel 8 and Sneaker does not seem to work. I have run into this same issue when porting to Laravel 6 and 7, and it was due to the composer version (I had to downgrade composer to 1.10).  But now this happens both with composer 1 and 2.
This is the message at the end of composer install:
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover

In Container.php line 835:

  Target class [sneaker] does not exist.

In Container.php line 833:

  Class sneaker does not exist

Do ypu have a workaround for this?

@michaelheumann  I would recommend
a) use composer 2
b) uninstall sneaker, including commenting out the lines in app/Exceptions/Handler.php
c) composer update
d) install sneaker via composer
e) complete install by uncommenting lines in app/Exceptions/Handler.php

@bryanrscott Thanks for keeping this nice package up to date!

Curious if this project has stalled or if it's possible to install in Laravel 8, or even better, Laravel 9?

@ eugenevdm the forked version supports Laravel 9

@ eugenevdm the forked version supports Laravel 9


Remove merged branches

There are many, many branches in the repo and it begins difficult to say which one is useful or not. It would be clearest to remove all merged branches. :)

Well spotted, thanks !
We did some cleanup of merged branches and old closed branches.
@SFSandra There are two branches, fr and zh, that we're not using. Can we close them ?

Yes good idea @roipoussiere, we can start cleaning up there. I'm gonna go ahead and close some, @domi41 feel free to do the same


Some things seem to be higher elevation / z-index than nav bar

Screen recording 2024-06-19 9.42.33 PM.webm

Hello, I'll like to work on this, please assign this issue to me

Done.

You can run the demo to see the issue in action.


Add support for exporting Signature objects as JSON

The format is compatible with the format produced by Griffe, except we don't use an ast form for the annotations.

Note that this relies on inspect.formatannotation for files that don't use from __future__ import annotations. Don't know how robust that is or if there could be weird annotation objects that it can't handle (although I would expect such things wouldn't be handled well by Sphinx either?)

Still need to output this to the actual data files, and add tests.

Thanks, I had forgotten ammit had started this class. I'm guessing it is also not used everywhere and some place are still carrying str signatures.

Thanks, merged and updated as part of #291, one change was that None is a valid annotation so I had to add a workaround between to not serialize and empty annotation as None. Otherwise both def f(a):pass and def f(a:None) would serialize as the same. This was present in annotation and default values. Of course in parameters annotation it's rare, but probably less in return annotations.


Rename execution variable to liveacton in action execution controller

It was utterly confusing when I was reading the code to call liveaction as execution. So here's something.

+1

Agreed.
I've fixed some in the past, but I believe there are some more places like that left.


Add Nong Song: Skibidynamix

Song Name
Skibidynamix
Artist Name
Dj-Nate. Rohva Topper
Source
Youtube
Youtube Link
https://youtu.be/JX_WTs0wng4?si=j7CIDYadgSR5OnIj
Direct File Link
No response
Song ID
14 (Electrodynamix RobTop short Version)
Start Offset [ms]
No response
Extra
No response

reject
song id cant contain text


Add a Gitter chat badge to README.md

extr0py/oni now has a Chat Room on Gitter
@extr0py has just created a chat room. You can visit it here: https://gitter.im/extr0py/Lobby.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

off in readme


pythonPackages.pynacl: use system libsodium

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

/cc @va1entin

Built it successfully on my machine, looks good 👍

I have run the matrix-synapse test using this version of pynacl and it works fine.


exa: add gitSupport input parameter

Description of changes

add gitSupport input parameter for a more convenient way to configure the package.
final: prev: {
  exa-minimal = prev.exa.override { gitSupport = false; };
}

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@grahamc can you help please with "no space left on device"?

@ofborg eval
(should be sufficient to re-trigger the eval)


Animated Navbar Toggler for Better UX

Hello!
I was wondering if we could work in an animated Navbar Toggler for better UX when on a website.
I love the hamburger that comes with Bootstrap but it lacks in the UX department. When I open a menu, the only way I can tell the menu is open is with the menu being open. There is no animation with the Navbar Toggler (hamburger) when I open the menu and no animation when I close the menu.
I have have been using code that I built upon for projects for months now and finally made a pen out of it so I could share it with people having the same issues. The example is incredibly basic for demonstration purposes. It takes care of some simple issues:

Animate the Navbar Toggler to an "x" when open and back to the default toggler when closed.
Remove the outline around the toggler when active and focused.
Close the menu when clicking on a link.

That code can be found here with the example of it functioning.
It could use a bit of work with the animation end position but is pretty close to perfect.
Bootstrap is a phenomenal framework and I enjoy using it the most out of other frameworks. Thank you for all the hard work you do to make it functional.
Thank you for taking the time to read my post!
Sincerely,
John M

Appreciate the demo and the post, but I don't think this is something that's necessary out of the box. Could be useful to do an example maybe though with some animation work applied to our components. Thanks!


Result conflicts with that in Editing Models with Task Arithmetic

Hi,
In your paper, Fig. 5 indicates the average performance decreases when the number of merged tasks increases.
This is different from Fig. 3 in Editing Models with Task Arithmetic. How to explain this phenomenon.

Hi @cll-mtk, Thanks for your question!
I would suggest that you look at Appendix D4 and Figure 16 from the Editing Models with Task Arithmetic. The results are consistent, however, they are presented in a more cryptic way in the Task Arithmetic paper.
Let me know if this does not answer your question, feel free to reopen the issue.
Thanks,
Prateek


Are pull requests possible?

Hello,
are pull requests possible? I don't have any idea how it works.

Hi @Garios,
You can create Pull Requests to the repository by clicking the "Fork" button at the top right, and then raising a PR from your repository to this one. There is more information about this available here.


switch to Pyside6

The main change that everything is centered around is moving to PySide6. This removes the dependency on ImageMagick to handle SVG files because PySide6 is much more consistent and reliable (and faster than using CLI). Additionally, using PySide6 also replaces the need for pillow as a image processing library.
Breaking changes

Jinja syntax is customized to be YAML friendly. Now also includes a yaml filter to represent complex color specs in layouts/templates.
Colors are validated using pydantic_extra_types
colors from mkdocs-material (& sphinx-immaterial) are only used during config loading. this means that any colors specified in layout and the social_cards config must be valid RGB/HSL strings or known color names
re-prioritized rectangles to be rendered before ellipses
polygon's points are clamped to layer size while also respecting any border specified
renamed validators.base_model module to common.py as it houses all commonly used/referenced models in other validator modules.
removed typography.border feature as it isn't available in PySide6 and not easily implemented.

Other changes

revised layouts to be easily inherited for custom layouts (added a tutorial in the docs)
adds support for color gradients (finally). Linear, Radial, and Conical types are supported. PySide6 comes with 180 presets to be used for gradient colors; these are now generated in a separate page. Preset gradients can also be modified using the custom colors field (which can also be used to create entirely new gradients)
switch most of all pillow usage over to PySide6 except for anything related to text
added math module to the jinja contexts
leading and trailing whitespaces are removed because it looks wired to have leading spaces in centered text
the border.width spec is now a positive float type thanks to the precision provided by PySide6.

Codecov Report

Merging #11 (d0e2f80) into main (c036986) will increase coverage by 0.48%.
The diff coverage is 97.82%.

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   98.14%   98.63%   +0.48%
==========================================
  Files          14       14
  Lines        1187     1393     +206
==========================================
+ Hits         1165     1374     +209
+ Misses         22       19       -3

Files Changed
Coverage Δ

src/sphinx_social_cards/validators/layers.py
97.84% <90.90%> (-2.16%)
:arrow_down:

src/sphinx_social_cards/generator.py
97.51% <96.80%> (-2.16%)
:arrow_down:

src/sphinx_social_cards/validators/common.py
98.90% <98.90%> (ø)

src/sphinx_social_cards/colors.py
100.00% <100.00%> (ø)

src/sphinx_social_cards/fonts.py
98.92% <100.00%> (+0.07%)
:arrow_up:

src/sphinx_social_cards/images.py
99.14% <100.00%> (+10.59%)
:arrow_up:

src/sphinx_social_cards/validators/__init__.py
98.54% <100.00%> (+0.38%)
:arrow_up:

src/sphinx_social_cards/validators/contexts.py
100.00% <100.00%> (ø)

src/sphinx_social_cards/validators/layout.py
100.00% <100.00%> (ø)


Prevent opening a book that is already open

Looks good in v0.0.18 build cc1f350. When user tries to open a book which is already open in a card, then a pop-up is shown at the bottom of screen that the "Book is already open", hence preventing the users to open multiple cards with the same book.

Tested with v0.9.0-rc.2 build 29a2450 QA. Looks good


Add customizable equality and hash functions to UDFs

Which issue does this PR close?

Closes #127.
Rationale for this change
After #9436 it's possible to write and use all kinds of custom UDF functions e.g. parameterized by additional arguments, but the issue is that equality and hash code are based only on the name and signature. As such some plan rewrites that put expressions in a hash set (e.g. FilterPushDown) violate this assumption and we end up with semantically incorrect rewrites.

What changes are included in this PR?
Added equals and hash_value methods to scalar, aggregate and window UDFs. By default they delegate to the name and signature as before but custom UDFs can override them to account for additional parameters. Unfortunately we can't extend the Eq and Hash traits because they prevent us from using trait objects.

Are these changes tested?
Not yet, will work on a test.

Are there any user-facing changes?
Yes, the UDF interfaces grow with two new functions.

Closes https://github.com/apache/datafusion/issues/127.

Trophy for lowest PR number closed

Maybe it is not something that could be feasibly tested though. I can't really think of a great example of how to do it (other than to show the traits could be extended, which doesn't seem like a very useful test)

Yes, I have an idea. I think we already have some parameterized UDFs in the tests. I will just create a query that would be broken currently and be fixed by these changes.

@alamb this should be ready


Reduce number of UserPoints stored by stopping to track points for each day

PR: https://github.com/NationalSecurityAgency/skills-service/pull/1257

PR: https://github.com/NationalSecurityAgency/skills-service/pull/1264


Not able to disable touch/focus ripple on Tab component

https://github.com/mui-org/material-ui/blob/master/packages/material-ui/src/Tab/Tab.js#L183

[x] This is a v1.x issue (v0.x is no longer maintained).
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Hey @mmartha, if you add disableRipple to a <Tab /> it will spread to the root element (ButtonBase), which will the disable the ripple effect for you.


Blockwise transfer for PUT requests

Does this library allow for blockwise transfers as described here: http://www.google.com/url?q=http%3A%2F%2Ftools.ietf.org%2Fhtml%2Fdraft-ietf-core-block-08&sa=D&sntz=1&usg=AFQjCNGpPAnNm15802QG7Kgw_7iJ0BWuPw

whats the approach for blockwise GET request?


Banglejs and Espruino website down

I know this is likely the wrong place for this but I noticed that all of the Espruino websites are down including the forms.
Does anyone know when they will be back up? Does anyone know what is happening?
I will close this issue once they come back online

#metoo, i have sent an email to gw to noticify he/christine.

Seems to be back

...and down again

I get the feeling that no one is in the office. I guess I'll just wait till Monday

Hi - yes, sorry - it's fixed now. There was a server issue while I was away.


About us Page Design Afos Project.

We need a design of the About Us page highlighting in detail the goals and objectives of the Afos Project. The PRD and style guide will be made accessible to potential contributors to guide your design process.

I'd like to work on this

Thank you @lizzlix for your interest in working on this issue. I'd like to clarify a few things as we enter Hacktoberfest season and welcome new contributors. Here are some guidelines for contributing:
Please join our Slack community channel for better communication: Link to join
It's essential to note that this is an open issue, which means multiple contributors may be assigned to these tasks.
We usually have a design call every Wednesday 11am - Noon WAT biweekly where we talk about the tasks. You can provide your email address to be added to the call.
We will provide you with access to our Afos Assets, allowing you to start working on this project.

Thank you @lizzlix for your interest in working on this issue. I'd like to clarify a few things as we enter Hacktoberfest season and welcome new contributors. Here are some guidelines for contributing:
Please join our Slack community channel for better communication: Link to join
It's essential to note that this is an open issue, which means multiple contributors may be assigned to these tasks.
We usually have a design call every Wednesday 11am - Noon WAT biweekly where we talk about the tasks. You can provide your email address to be added to the call.
We will provide you with access to our Afos Assets, allowing you to start working on this project.

Alright. My email is<EMAIL_ADDRESS>

Hi @iamkingsleey, I'm interested on working the issue


Can't drag & drop on small laptop, tablet & menu always visible

How fix menu always visible on small screen & can't drag drop

menu always visible when click on right side on the form

"menu always visible" is a design decision; this will fit all but the smallest of screens. As for "can't drag and drop", do you mean on a touch screen?

how to display the menu if the screen resolution is small? can't drag and drop on the touch screen and use the mouse if the screen resolution is small

I decided early on to make this desktop-focused because the user in my mind was using a desktop or decent laptop to create the forms. The rendered forms can be displayed and used on any size screen, but creation/editing of the forms was created to be desktop-only. I may have to revisit this once I update the library to Quasar v2 (Vue 3).

Hello, i may have similiar problem
The menus always visibile on browser at max zoom level 90%, but more than that (like 100% zoom level), the menus is gone..
Device: Laptop with 11" screen
Screen resolution: 1366 x 768 px

I will try to find some time to investigate this and perhaps reduce the screen size requirement.

thanks @baggachipz
reducing q-page padding a little bit solves the problem


Add dag-json implementation

Once #8 is complete, I would like to revive https://github.com/vmx/rust-ipld/pull/2 to add dag-json support here.
We did have a lengthy conversations about where we should or should not use serde. My personal opinion had being let's use it where it's usable given it's well tested and time proved, we can always rewrite internals (to rip it off) after the fact.
If it does not feel reasonable please let me know.

I think we can use serde for dag-json as it's not going to be very fast anyway. I can see some reasons why we should support it: debugging, compatibility and possibly because it works well with js. Does anyone have a use case for it (as in is planning to use it for something)?

I only have test cases as example. DagJSON is used for testing selectors in the Go implementation as it's an easy way to create fixtures with is. Example: https://github.com/ipld/go-ipld-prime/blob/530ccd6893ea4a528ffb0c7a3957754ed874be57/traversal/selector/exploreRecursive_test.go#L312

We do have the ipld! macro which was created for exactly that purpose, just in case you hadn't seen it yet.

@Gozala hi there! do you have any unpushed implementation of any dag-json work somewhere waiting? Looking at https://github.com/vmx/rust-ipld/pull/2 I think it looks quite a good start. If you have anything like work in progress notes or stuff like that I'd be interested in those! My question in relation to https://github.com/ipfs-rust/rust-ipfs/issues/91.


Avoid running SmartState against the image-inspector image

When a SmartState analysis runs (on any image), a new image-inspector pod is scheduled which triggers the scan on the image-inspector image.
We should exclude image-inspector from the automatic image discovery scan.
cc @moolitayer @enoodle

@miq-bot add_label providers/containers, smartstate, bug

@simon3z related to a question we had before: do we want to show inventory coming from management-infra ?

@simon3z related to a question we had before: do we want to show inventory coming from management-infra ?

Yes (I don't like to start hiding things we run).

Can you explain the motivation?  It should only scan the image once, no?
Or does it actually fail the scan?

@miq-bot assign enoodle

@simon3z @enoodle I understand we want a fix for this asap.
If we don't have a better solution we can temporarily disable the ootb policy that initiates scans of newly discovered images. We can do that since that is only an optimization. that should be a 1 line patch for the miq policies yaml.

@miq-bot add_label smart_state

@simon3z Yes it should. Copied policies will not be effected though.

@simon3z Yes it should. Copied policies will not be effected though.

@moolitayer can you submit a PR that we can look at?

What's wrong with #9484 skipping that policy for */image-inspector?
The only concern there was false positives for unrelated images with this name; but I don't see how disabling that policy for all images is better.

@cben right, I confused #9484 with #10067 where @moolitayer reported it as not working.
If we verified #9484 I think we could move ahead with it. @moolitayer ?

Scanning new images does not handle currently short lived images of any kind - image inspector as well as other for example images used for kubernetes batch jobs.
I think we should disable or completely remove it.
Submitted #10257

Some background for public record:

disable the ootb policy that initiates scans of newly discovered images. We can do that since that is only an optimization

The reason it's "only and optimization" is that user should also schedule periodic scanning of all images.  Scanning an image only once is not enough because openscap definitions are getting updated with newly discovered vulnerability, so an image that was deemed good yesterday might fail today.
[@moolitayer while the docs explain how to schedule, they don't really explain why.]

I think the long-term solution is retaining images in DB for a long time after they aren't used.


Can't run it on macOS

Describe the bug
Installed using the two provided commands.
Copy/pasted the first example code.
Here's what I get:
Nesk\Rialto\Exceptions\Node\FatalException
Cannot find module 'puppeteer' Require stack
@vendor/nesk/rialto/src/ProcessSupervisor.php:307

Environment

OS: macOS 10.15.5
Node version: 14.15.1
PHP version 8.0.1
NPM 6.14.10

My bad. I'm using this inside a package, and was testing it in a local project, so I had to install node dependencies in the project as well.

My bad. I'm using this inside a package, and was testing it in a local project, so I had to install node dependencies in the project as well.


Support more than one reference with the same internal name

Enables the skipped test added by #370. Part of issue #259.

Yep! (Hopefully!)


Add "Institut Badalona VII" institute

http://www.institutb7.cat/

Website url: http://www.institutb7.cat/

@akex06 lib/domains/cat/institutb7: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

I'm sorry, I've just modfied it. Thanks for your time

@akex06 First stage of verification passed, official domain is educaciodigital.cat as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://educaciodigital.cat/iesb7/moodle/

@akex06 Pull request merged. Thank you.

Should I be able to redeem my license? It appears as my email is not registered

The educaciodigital.cat is not the school domain, that's the domain from the Generalitat de Catalunya's  Education Department


feat: test2

:tada: This PR is included in version 0.2.0-alpha.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


chore: create deploy all contracts workflow

Motivation
Reduce time to deploy all contracts.
Explanation of Changes

Created new workflow to deploy all contracts with one run, and to set the circular dependencies on the Proxy once the other contracts are deployed.
Echo contract name in deploy singular contract.
Remove deprecated deploy WASM storage contract workflow.

Testing

Tested on a fork.
Related PRs and Issues

Closes #74
Closes #72

@Thomasvdam if it helps I have this written up in a rust binary as well for the local chain. Would just need to change some stuff so it's not hard coded to the local chain. Also doesn't rely on docker to build the contracts! So it's a bit simpler.


Merging new changes

Merging

Your merge request is backward. You probably want to merge from my repo to yours. Instead, this request attempts to merge your content into my repo.


Add atomic mutex implementation for ARM

Based on previous version here.
This PR actually forces the mutex version on all arm devices. I tried to use the experimental #[cfg(target_has_atomic = "64")], that seems to be more appropriate for this scenario, but failed.
With this change, I successfully compiled and run the basic example on my armv5te based Zyxel NSA325v2.
Fixes #743.

LGTM , but can you run cargo fmt ?

It seems you missed one line in your rustfmt run. I manually ran it on your branch and merge than into master. Closing your PR.


Ingress kind

Added ingress to kind and extended the profile to use most C8 components

Hi @plungu,
thank you for you PR. I find it a little hard to review this. Would you have a chance to rebase this?
Cheers,
Falko

Dependency for https://github.com/camunda-community-hub/camunda8-greenfield-installation/pull/4

@plungu we should get this done before https://github.com/camunda-community-hub/camunda8-greenfield-installation/issues/3 happens

Hi @plungu, I merged this into #36.
I still need to merge your latest from the kind-zeebe-gateway-ingress
Thanks!


Warn about unused fields

Hi all 👋 I just had a thought about a potential feature that could maybe be built into GraphQLSP: Show a warning for any field in a fragment or query that is unused. I could imagine two different kinds of warnings:

On the query level, it would make sense to warn about fields that are never used anywhere in my codebase.
On the fragment level, I would love to see which fields of my fragment are not used in the co-located component.

Why? A common pattern with GraphQL is to co-locate data requirements in the form of GraphQL fragments with UI components. When I refactor a UI component it's easy to add more fields that I need now, however, it's also easy to forget removing a field that I'm no longer using. I would love to have tooling that yells at me to do so 😄

Fan of this idea as well...although I'd want the ability to blacklist some fields like id which I query simply to satisfy the URQL normalized cache.

There's a start in here but it's proving to be quite complex 😅 https://github.com/0no-co/GraphQLSP/compare/wip-fields?expand=1


Allow user to download project as zip file.

The idea would be to allow users to upload their project as a zip by clicking a button in the webapp.

Do you mean download the generated project instead ?
Because I don't understand why the user should upload the code to JHipster Lite

Yes dowload, it would be another option than just directly creating in their repository.

So, can you update the title plz?

The 1st step would be to add this to ProjectRepository.java :
void zip(Project project);

Then, you need to work on the implementation

@matthieulapatate : I'm waiting this 1st small PR, which should contain only:

the method in interface
the implem in secondary
the unit test
maybe the lib in pom.xml

Nothing more.

closed by https://github.com/jhipster/jhipster-lite/pull/1266


Allow see/hide password toggle in login popup

https://github.com/BobaBoard/boba-components/pull/94


Add field short_name to Cleaner

With max character count <10, which we can display in buttons and such. Prevents long names from ruining layout

Current names have a max char count of 20, and there haven't been any layout problems yet.


Performance mode strategy update for input_embeds input

Description
Performance mode strategy update for input_embeds input
https://github.com/analytics-zoo/nano/issues/1570#issuecomment-2324330157

PR validation: https://github.com/intel-analytics/ipex-llm-workflow/actions/runs/10679816769


v1.4.3 patchset

Manually cherry-picked due to merge conflict. Wasn't a real conflict, the addition of cifs-utils to the hyperkube dockerfile near where we added ceph-common caused it.

lgtm


Use release and nightly versions

In our Nexus, we recently refined the structure to have seperate repos for dev, nightly and release. The T2 templates must reflect that change in order to allow the user to use all kinds of versions of our packages.

TODO: Test PR-Build from Zookeeper-Operator to see if these Versions are usable as well.

We decided to leave the dev versions for now.


feat: support config push command

What kind of change does this PR introduce?
feature
What is the new behavior?
Running supabase config push will prompt user to update linked project's config to match local config.toml. For eg.
Pushing config to project: vpefcjyosynxeiebfscx
Updating API service with config: diff remote[api] local[api]
--- remote[api]
+++ local[api]
@@ -1,7 +1,7 @@
 enabled = true
 schemas = ["public", "graphql_public"]
 extra_search_path = ["public", "extensions"]
-max_rows = 1000
+max_rows = 100
 port = 54321
 external_url = "https://<IP_ADDRESS>:54321"

Do you want to push api config to remote? [Y/n]

Answering Y (default) will call mgmt-api to update config, n will skip to next config, and ctrl + c will abort the update.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

4 of 32 (12.5%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 59.623%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/config.go
4
12
33.33%

internal/config/push/push.go
0
20
0.0%

Totals

Change from base Build<PHONE_NUMBER>9:
-0.1%

Covered Lines:
6385

Relevant Lines:
10709

💛  - Coveralls


community: add token usage to bedrock models' responses if available

Description: Get token usage (if available) from the response body of bedrock model responses and pass it to the llm_output field of ChatGeneration
Issue: Solves #11906 for some models

@baskaryan @3coins, tiny reminder! Thanks 😄

Hi, I opened a similar PR a couple of weeks ago: https://github.com/langchain-ai/langchain/pull/19127#issuecomment-2019208568
Here I'm using the Bedrock headers to extract the token counts, which should work across different providers (hopefully). Maybe it would be great if you could confirm that such headers are also available for meta models (unfortunately I only have access to anthropic models). Thanks!

thanks @AlexisGado! as @dmenini #19127 implements same functionality and just landed — ok to close this pr?

these models are now in their own integration packages


Error when the CogVideoXFUN sampler uses the PAB

I think this is a new issue with some recent update, as it was running fine before.
BTW, it's no problem with CogVideo Sampler.
Init Pyramid Attention Broadcast. steps: 50. spatial broadcast: True, spatial range: 2, spatial threshold: [100, 850]. temporal broadcast: False, temporal range: 4, temporal_threshold: [100, 850]. cross broadcast: False, cross range: 6, cross threshold: [100, 850]. mlp broadcast: False.
Temporal tiling and context schedule disabled
0%|                                                                                | 0/20 [00:01<?, ?it/s]
!!! Exception during processing !!! CogVideoXTransformer3DModel.forward() got an unexpected keyword argument 'video_flow_features'
Traceback (most recent call last):
File "D:\AI\ComfyUI_windows_portable\ComfyUI\execution.py", line 323, in execute
output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\AI\ComfyUI_windows_portable\ComfyUI\execution.py", line 198, in get_output_data
return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\AI\ComfyUI_windows_portable\ComfyUI\execution.py", line 169, in _map_node_over_list
process_inputs(input_dict, i)
File "D:\AI\ComfyUI_windows_portable\ComfyUI\execution.py", line 158, in process_inputs
results.append(getattr(obj, func)(**inputs))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\AI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-CogVideoXWrapper\nodes.py", line 1154, in process
latents = pipe(
^^^^^
File "D:\AI\ComfyUI_windows_portable\python_embeded\Lib\site-packages\torch\utils_contextlib.py", line 116, in decorate_context
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "D:\AI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-CogVideoXWrapper\cogvideox_fun\pipeline_cogvideox_inpaint.py", line 1092, in call
noise_pred = self.transformer(
^^^^^^^^^^^^^^^^^
File "D:\AI\ComfyUI_windows_portable\python_embeded\Lib\site-packages\torch\nn\modules\module.py", line 1736, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\AI\ComfyUI_windows_portable\python_embeded\Lib\site-packages\torch\nn\modules\module.py", line 1747, in _call_impl
return forward_call(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\AI\ComfyUI_windows_portable\python_embeded\Lib\site-packages\accelerate\hooks.py", line 169, in new_forward
output = module._old_forward(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: CogVideoXTransformer3DModel.forward() got an unexpected keyword argument 'video_flow_features'
Prompt executed in 26.90 seconds

I'm actually aware of this yes, what I'm considering at this point however is dropping PAB altogether in favour of FasterCache, which seems to do same thing but...well, faster.

I'm actually aware of this yes, what I'm considering at this point however is dropping PAB altogether in favour of FasterCache, which seems to do same thing but...well, faster.

I guess the FasterCache is useful for 50 steps, but how to set proper paramters for as low as 20 steps?

I'm actually aware of this yes, what I'm considering at this point however is dropping PAB altogether in favour of FasterCache, which seems to do same thing but...well, faster.

I guess the FasterCache is useful for 50 steps, but how to set proper paramters for as low as 20 steps?

Don't know the exact math, but something like start at step 5-7, HF to around middle and LF near end, like with the 50 step defaults.


Context Club Centenary

https://tinyurl.com/forgotten-movies
More than 100 films have been viewed over the past 2 years.
In chronological and ranking order, let's make a grid (10x10) of the title cards of those movies.
Left-right starting at the top and wrapping down makes the most sense, and since most of the title cards will be wider than tall, the overall picture will be that way too.
It'd be funny if those title cards were diverse enough, color-wise, to form a mosaic picture.


Add a hazard assessment to the second report

Hazard assessment: identify hazards and safety issues
Hazard control: what are they going to do to minimize the hazards discover in 1.

There is a tool (a pyramid): https://en.wikipedia.org/wiki/Hierarchy_of_hazard_controls

Would the hazard assessment would be aided by a risk assessment similar to this (likelihood vs consequence): https://safetyculture.com/topics/risk-assessment/

This is done. Very nice work!


space-before-colon breaks :hover selector for Less file

Enabled space-before-colon breaks less nested selector, note the space between a: and hover:
/* before */

li {
	a, a:link, a:visited, a:hover {
		font-weight: normal;
		text-decoration: underline;
	}
	a:hover {
		text-decoration: none;
	}
}

/* after */

li {
    a: hover {
        text-decoration: none;
    }
        a, a:link, a:visited, a:hover {
            font-weight: normal;

            text-decoration: underline;
        }
}

csscomb version: 3.0.0

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/3558268-space-before-colon-breaks-hover-selector-for-less-file?utm_campaign=plugin&utm_content=tracker%2F214563&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F214563&utm_medium=issues&utm_source=github).

Best bet would be to create a "whitelist" of pseudo-classes to not insert the space for.
Such as these: https://developer.mozilla.org/en-US/docs/Web/CSS/Pseudo-classes
also similar ticket --> https://github.com/csscomb/csscomb.js/issues/309

Looks like this is a result of a bug in the CSS parser (tonyganch/gonzales-pe#28). It's not parsing sub-rulesets in less properly, but is actually parsing them as declarations.

Upgrading gonzales-pe would probably fix it, but I think it requires changing a lot of code.

Fixed in dev, published as @4.0.0-alpha.


Started work on issue and PR templates

As explained in #373, a PR template doesn't exist and an issue template needs to be decided on
Please review and suggest changes

@jbcoe thanks for the review - happy to wait for the feedback from the others and add/change tomorrow

Yep, that looks good to me too.  Go for it.


Add state to equipment

there isn't an option to mark an equipment as lost or missing similar to keys (or the states in SN assets). We store our loaner equipment in PEAKS and would be nice to store states like that (ordered, available, reserved, lost, missing, stolen, etc). If that's not an option, we could use something like tags or attributes, but would be nice to have a built-in state

Votes: 5
Author: rcasteli
Voters: rcasteli,rfoster,ekurabe,vanslyke,guatemal

Yup let's add it
Author: postit


Stuck on apple logo after jailbreaking

Describe the bug
Just recently with unc0ver, after I jailbreak, the apple logo stays for 5 minutes, then I get rebooted to the lockscreen un-jailbroken. This hasn't happened before. I have reset Cydia cache but that doesn't help/
To Reproduce
Steps to reproduce the behavior:

Press jailbreak button in Unc0ver
Click OK on the popup once jailbroken in Unc0ver
Stuck on apple logo for 5 minutes
Finally at lock-screen but in an un-jailbroken state

Screenshots

Device (please complete the following information):

iOS Version: 13.3
iOS Device: 10,1 iPhone 8
unc0ver Version: 4.3.1

Place an "x" between the brackets if true:

[ ] this is a bug others will be able to reproduce
[X] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[ ] this issue is present after a rootfs restore
[X] this issue is present on the latest version of unc0ver

@BaileyRob41 You have a bad tweak post unc0ver diagnostics. This is not an issue with unc0ver itself.

@BaileyRob41 You have a bad tweak post unc0ver diagnostics. This is not an issue with unc0ver itself.

Ohhhh ok, I'l uninstall the tad tweak. Thanks!


[ENH] Use simulated data instead of MNE sample data for I/O demo

Since I already wrote most of how to do that here: https://github.com/pactools/pactools/pull/22, I could change a few lines around so that you make an MNE object with PAC, save it to a temp directory, load it in and compute PAC. IMO that would make a better example.
This is in reference to this demo: https://pactools.github.io/auto_examples/plot_mne_epoch_masking.html.

Yes, that would be a much better example !


Custom bbcodes and list of all available default bbcodes

Hi,
I have two questions: How/where could I add custom bbcodes for the parser? And where do I find all supported bb-tags by default?
Thanks!

Hi! BB codes are defined by presets https://github.com/JiLiZART/bbob#html-preset
You can create your own preset or extend existing.
Default html5 preset defines processing for b, i, u, s, url, img, quote, code, style, list, *text. You can see it here https://github.com/JiLiZART/bbob/blob/master/packages/bbob-preset-html5/src/defaultTags.js#L63

Thank you


Fix to prevent saving attributes from clearing selected product type with 1.0 Dashboard

I want to merge this change because...
Currently if you save an attribute using the 1.0 Dashboard it will clear out that attributes product type with blank data.
This PR will exclude any product type related fields ("product_types", "product_variant_types") from the AttributeForm to ensure that this information is not overridden and the selected product types are retained.
Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] Database migration files are up to date.
[x] The changes are tested.
[ ] GraphQL schema and type definitions are up to date.
[ ] Changes are mentioned in the changelog.

Here is the report for ec249714d99f6ecfbf6944862f78df538a76d3dc (fermorltd/saleor @ master)
Base comparison is 65e00b0d1497d329320b33c8bcdbe1fa8febfb9d.
No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         48	         48	             24

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	         15	         15	              8

Hi! Thank you for your finding and your pull request! I will open a new pull request with the suggested change it is quite major (#4683).


Add a new ContainmentDetector interface that the Sat algorithm would implement (and Gjk?)

Create a new interface that the Sat algorithm would implement to allow detection of full containment of two convex polygons.  Ideally, Gjk could implement this as well, but doesn't initially.

Just went with Sat implementing this for now.  Thinking about it more, Gjk would need to do something different than what it does today (using Epa to find the separation normal).  The effect of this is that the Ellipse and HalfEllipse shapes are not supported (because Sat doesn't support them) which is probably fine for now.  The more I deal with curved shapes, the more I think that polygonal versions of those shapes would be better for simulation in every way.


Added test_chrome command. Closes #45.

Issue number
{if exists provide related issue}
Expected behaviour
{what should have happened}
Actual behaviour
{what happens}
Description of fix
{small description of what fixes the issue}
Other info
{anything else that might be related/useful}

Ship it


Dodo Helper

I hope you can help...When using dodo helper it can't enter airport. it takes me to back of map and stops. am i doing something wrong?

Make sure the (Virtual)yellow/green controller is in the first slot.
Dock your joy-con if they are not. And disconnect any pro-controller you might have.
You can't have any other controller activated at the same time.

i just tried that and it still came up with connection to the switch was lost and that dodo helper has been aborted. it is connected via wired connection and is still online with dodo code?

Make sure your switch is docked so that your wired connection works. Boot up the game and let it stay at the title screen.

Start dodo helper and press the "Detach" -> then "A" button on the VIRTUAL controller. The VIRTUAL controller should pop up.

Using the VIRTUAL controller on dodo helper, navigate the "Home" screen and return to your game.
Start the dodo helper while your game is on the title screen.

Remember that you can't control your Switch with your  REAL controller after you have given the control to the VIRTUAL one, all movement and button press have to be done using the VIRTUAL controller. (Or the keyboard shortcut)


Reloading FPGA bitstream causes all outputs whose Vio is enabled to strongly drive high

This unfortunately happens because the reset state for the FPGA is pull-high, which translates to DIR=H (B=A), where A is FPGA-side and B is DUT-side.
Solutions:

Turn off Vio during FPGA reconfiguration and wait for the output cap to discharge before proceeding.

Pros: costs nothing.
Cons: slow, turns off DUT power which is undesirable, makes Vsense alert even less useful.

Add pulldowns on Dxn nets.

Pros: preserves existing design as much as feasible.
Cons: another BOM line, @esden has 4000 revC3 PCBs.

Switch to 74AXP1T45 and swap A/B.

Pros: improves performance of the device, doesn't add a BOM line.
Cons: @esden has ~2000-3000 boards worth of SN74LVC1T.

Power gate the FPGA bank or the IO drivers

Pros: zero new BOM lines, one added part
Cons: really awkward solution, may have unintended consequences

Swapping A/B on SN74LVC1T isn't feasible since this level shifter is asymmetric.
We have to implement (1) anyway to handle the existing devices; we must implement (2) or (3) for revD. What is not clear is whether or when revC4 will be designed, tested, and put into production.

You can also power gate the VCCIO of the FPGA bank. Either using a power switch or having two 3v3 rail ( fed by another TLV75533PDRVR with a different EN line). Not saying it's a great option, but it's a fourth option.

Thanks, added.

Many thanks for building and maintaining glasgow... I've got a question regarding this issue ... how practically does this affect using the current device revision (C3)? I'm new into this and can't reason about it if it's only an issue when there is some edge case hacking where you need to power the DUT or does it interfere using glasgow with some common setup? As this hasn't been detected during the different PCB version integration tests I guess it should be a minor concern, right?

@nekrondev We'll deploy a firmware based fix that only has trivial effect on usability of device (slight delay added to firmware reload).

Apparently we did notice this... back in 2019: https://github.com/GlasgowEmbedded/glasgow/issues/96

While working on this (testing it with the UART applet) I discovered another buggy behavior in transients:

Because the FIFO interface was turned off before the FPGA was reset, and because turning it off meant that several active-low flags would go permanently low, applets would receive an endless stream of phantom zero bytes. This could potentially cause very undesired operation.


Fix filename reference

@fldvrees : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@fldvrees It appears that both the folder mentioned in the current version + the folder you mention exist in the samples folder. How do you know it's the c2d_streaming_proxy_sample versus the c2d_proxy_sample?

@robinsh because the code described in line 150 to 153 is not present in iothub_client_c2d_streaming_sample/iothub_client_c2d_streaming_sample.c

@fldvrees Thanks for clarifying that for me, I appreciate it. Thanks also for making this change for us. Good catch!
#sign-off


Consider unit testing approach in Cairo1 template

Currently the template contract is basically tested using integration tests.
We want to encourage users to use unit testing to make tests efficient and faster.
Pic rel

I think template presents both approaches which is the best option, new docs clearly mention integration tests speed issue.


support filesystem paths as pin-depends URLs

The opam manual describes URLs (permalink) as possibly being a filesystem paths.
This modifies fetchImpure to support absolute and relative filesystem paths. To support relative paths the function signature was changed to add the current project path.
The monorepo functions don't require this for a relative path, I think, as if the source is already present locally we wouldn't want to vendor it again. So the getURL function passes a null project which fetchImpure checks for and ignores.
The use case is for github.com/ryanGibb/eon having a vendored dependency with a modified opam file with an additional dependency that I want to pick up. This is yet to be pushed, but if it's of interest I can point to it.
Would you be interested in including something like this upstream?

Thanks!


lost plot creation as I do it.

since I started v0.5.3, the plot isn't updating as I create it.
look at the draw portion to see why

fixed, Was using the wring coordinate system


Commit emails missing since 2022-02-25

This is about an OpenSSL project infrastruture issue. I didn't know a better place to report, sorry.
The last commit email I received via<EMAIL_ADDRESS>for either the 1.1.1, 3.0 or main branch was Feb 9th (1.1.1) and Feb 24th (3.0, main). It seems something is broken or has changed since Feb 25th.
Thanks and regards,
Rainer

I think it is not really mysterious given the migration from gitolite to ghe for the primary repository.

I think it is not really mysterious given the migration from gitolite to ghe for the primary repository.

Did we actually publicly announce that the ‚blessed‘ repository has moved? 🤔

The last commit email I received via<EMAIL_ADDRESS>for either the 1.1.1, 3.0 or main branch was Feb 9th (1.1.1) and Feb 24th (3.0, main). It seems something is broken or has changed since Feb 25th.

I wonder whether these email updates are still in keeping with the times. Anyone could simply watch the GitHub repo for those push events.

I wonder whether these email updates are still in keeping with the times. Anyone could simply watch the GitHub repo for those push events.

I don't think it's a particularly analogous experience.  GitHub doesn't send notifications on pushes to the repo, just on PR merge/closure, which should be correlated per our process but there is no technical enforcement thereof.
And the commit mails include the actual commit contents, which github notifications do not.

The e-mails are generated and I receive them. @rainerjung are you subscribed to the openssl-commits mailing list?

You can see the e-mails in the archive: https://mta.openssl.org/pipermail/openssl-commits/2022-June/thread.html

Thank you. I am subscribed and indeed I get the mails. I was used to the nice feature of seeing the branch name in the subject. That's why I though mails for the 1.1.1 and 3.0 branches do not arrive. But in fact they do.
The public unavailability of the diffs is unfortunate, but for me as the reporter of the missing emails issue it would be fine to close this issue here.


Edit Stash

It should be possible to expand stash for edit.

Essentially it means expanding a stash, modifying it and then re-creating it with the same name.