transaction build still takes --constitution-file ; it should be any --action-file

This command
cardano-cli transaction build
...
  --vote-file FILE         Filepath of the vote.
  --constitution-file FILE Filepath of the constitution.
...

should be
cardano-cli transaction build
...
  --vote-file FILE         Filepath of the vote.
  --action-file FILE      Filepath of the action file.
...

This will become obvious when we are trying to submit any other type of governance action.

Resolved in https://github.com/input-output-hk/cardano-cli/pull/219


Is it possibile to delete existing artifacts?

Is it possibile to delete existing artifacts like:

Fields
Content Types
Lists

Thanks

Hi,
No it is not possible.
However, you can create a custom extension handler that you register in your template. It will be called during provisioning of the template. In the handler you can then remove the artifacts. This however requires that your write a C# assembly.
I wrote a blog post on how to use them here: http://www.erwinmcm.com/using-an-extensibility-provider-with-the-pnp-provisioning-engine/. I also plan to write a guidance article about it.

OK thanks


[Bug] Terrain Details Artifacts

It's not always visible, but sometimes foliage will appear distorted, in a smashed area about 1 meter or so big.
It's definitely on the Terrabrush node, and it does not react to terrain changes.
See attached video:
https://github.com/user-attachments/assets/b74a3c86-1e94-4951-88ed-7a5c20b95c55

It should be noted, there's a massive frame drop, GPU time is x5+ in this area.

Reference images as requested.

@David-Everlasting-Media It should be fixed with the version 0.9.3Alpha.
Let me know if it works! 🙂
I'll close the issue for now, we can reopen it if needed.


Lazy loading regression after DataQueriesProvider refactor

Need to look into regression after #1318 where lazy loading queries is broken
<DataQueryProvider> sits above the component that decides to render if it’s not within the viewport. We need to add pause props that are controlled by the viewport react-intersection-observer
<DataQueryProvider {…props} pause={!isInViewport}>….</>

Closing since will be fixed in #1340


Enable MPI tests for Python wrappers

sanity check doesn't do much but it does not hurt to have it...

Fix the typo and merge yourself

@Rombur: Would you review the changes to CMake plz?

Fix the typo and merge


HTML

HTML
User Story
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
Acceptance Criteria
GIVEN a Prework Study Guided website,
WHEN I visited the website in my browser,
THEN I see four boxes titled HTML,CSS,GIT, and JavaScript with associated notes listed.

HTML completed


feat: Add proper example of configuring Rust functions.

Changes

-:gift: As discussed in #430, here's the concrete example on how to use function configuration.

/kind feature

It uses a simple configuration struct to provide users with easy to adapt example on how to provide configuration to their functions.

/kind enhancement

/lgtm

Thanks for helping out with the review @jcrossley3
/lgtm

/assign lance

@dejanb pkged.go is such a pita. Could you please rebase this PR?

@dejanb pkged.go is such a pita. Could you please rebase this PR?

@lance sure, just did it. Tests look good now. Let me know if there's anything else needed.

/lgtm


Can't be seen inthe Obsidian community store

Great plugin! Why can't it be seen in the Obsidian community store?

Thank you for visiting our dusty repository. I couldn't put it on the community store because it duplicates functionality with the following plugin.
https://github.com/joethei/obsidian-link-favicon


cli: fix generated read hooks select type

Description
fix generated read hooks select type
// before
const { data } = useMyGeneratedHook({
  select: data => data[0].toBigInt()
 })

data
// ^? type data = [BigNumber] | undefined

// after fix
const { data } = useMyGeneratedHook({
  select: data => data[0].toBigInt()
 })

data
// ^? type data = bigint | undefined

Good spot! Made a couple changes and looks ready to go.


Allow for repeated runs of phases in the @run statement

Allow for repeated runs of phases in the @run statement, e.g.
@run 8*phase1 runlabel:foo

Incorporated into https://github.com/learningsimulator/learningsimulator/issues/89


Ignoring tags in file name while batch processing

It's a small request since it'd save a lot of time in batch processing many images. If there's a chance of disabling the tags that are added once the files are generated so that the file name remains same as the original.
Example:
File name is: 0004.png
Output is turning into: 0004_[NS-L3][x2.000000].png
While it should be: 0004.png
Thanks!

Have you considered just using make and explicitly giving the output filename with -o?


actions: bump node 18

Applied mkpr on .github/workflows/*.yml
sed s/18\.12\../18.12.1/

:tada: This PR is included in version 1.34.11 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.34.11
GitHub release

Your semantic-release bot :package::rocket:


#3 Feature: Uses 'glider-js' for the carousel view.

Summary

Updates carousel view to use 'glider-js'.
Circles view is displayed as carousel.

Relevant Technical Choices

Uses tiny JS library 'glider-js' to make carousel feel more consistent on non-AMP and AMP pages.
Uses 'amp-carousel' for AMP pages.

Testing Instructions

Insert Web Stories List block with 'circles' or 'carousel' as view type.
Observe the rendered block.

Please make sure that unit test pass.

The failing test is for
Google\Web_Stories\Tests\Plugin::test_is_amp_endpoint_polyfill_on_wp_action
I believe we are not working on core plugin files for this PR.

Please make sure that unit test pass.

The failing test is for
Google\Web_Stories\Tests\Plugin::test_is_amp_endpoint_polyfill_on_wp_action
I believe we are not working on core plugin files for this PR.

There is a valid PHP lint. I think we can ignore on this method and fix it later.
Otherwise I will approve this, this PR.

There is a valid PHP lint. I think we can ignore on this method and fix it later.
Otherwise I will approve this, this PR.

@spacedmonkey I've ignored it in this PR, so it will be taken care of once it gets merged.

@spacedmonkey I've ignored it in this PR, so it will be taken care of once it gets merged.

I have now approved https://github.com/rtCamp/web-stories-wp/pull/232 As a merge and rebase it should fix the php lint issues.

I have now approved https://github.com/rtCamp/web-stories-wp/pull/232 As a merge and rebase it should fix the php lint issues.


goog.net.XhrIo.shouldUseXhr2Timeout_ may return the falsy result

As you can see, the code only check for Internet Explorer, but Chrome 38.0+ has support xhr2 level timeout property and ontimeout callback.
I test it on MAC OS with chrome.

Safari6 also support it

Support table for timeout: https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest#Browser_Compatibility

Feel free to create a PR.

This issue is being closed as a preparation step before archiving the repository.  See the README for more detail.


added deduplication of findings

hey @devGregA - I feel like ENABLE_DEDUPLICATION should be defaulted to False, thoughts?  Also, did you test code when there is no ENABLE_DEDUPLICATION entry at all in settings file?  I believe you may get a key error if you reference it and it does not exist.  This is important because for all existing installations the setting will not be there initially.
We also may need to add some documentation around this new setting and what it accomplishes.
@cneill - thoughts?

I agree that we should default this to False and document it so that users know what they're getting and aren't surprised by Findings suddenly going missing.
See my other comments inline.


Index definition isn't persisted

In the case of adding an index to an existing Collection, the index definition isn't persisted, so on DB restart, it won't exist anymore. Index definitions are persisted when provided at Collection creation time.

Oh, damn... good catch!


X-Etcd-Index is less than modifiedIndex

Repro:
Clean install of 2.0.5. One-node, simply launched with "etcd" on command line. No data. Index is 2.
Wait for next change:
http://<IP_ADDRESS>:4001/v2/keys/test?wait=true&waitIndex=3
Create key:
curl http://<IP_ADDRESS>:4001/v2/keys/test -XPUT -d value="Hello world"
Waiting request returns, with modifiedIndex = 3, and X-Etcd-Index = 2. I assume this is not the expected behaviour?
{"action":"set","node":{"key":"/test","value":"Hello world","modifiedIndex":3,"createdIndex":3}}
Remote Address:<IP_ADDRESS>:4001
Request URL:http://<IP_ADDRESS>:4001/v2/keys/test?wait=true&waitIndex=3
Request Method:GET
Status Code:200 OK
Content-Type:application/json
Date:Thu, 19 Mar 2015 17:37:22 GMT
Transfer-Encoding:chunked
X-Etcd-Cluster-Id:7e27652122e8b2ae
X-Etcd-Index:2
X-Raft-Index:62
X-Raft-Term:2

X-etcd-index is the etcd index when this watch starts.

Thank you for the clarification, @yichengq.


fix the flags for mp3 ffmpeg sample config

this allows the audio to be converted on the demo site.
the flag needed to changed to the audio flag

Thanks for the fix!


Add allowTapToDismiss to PanModalPresentable

Summary
The goal of this PR is to add an additional point of configurability to the PanModalPresentable protocol. The allowTapToDismiss function will determine whether or not the presentable is dismissed when the dimmed background view is tapped.
Similar to allowDragToDismiss, this functionality can prevent the user from dismissing the presentable with an accidental tap. This is particularly important when they have unfinished work, or are in the middle of an important workflow.
Requirements

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.

[x] I've read and agree to the Code of Conduct.

[x] I've ~written~ added assertions to existing tests to cover the new code and functionality included in this PR.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Proposal: Normalize metadata storage class

As described in Proposal: Normalize Metadata, we need to normalize private meta's value.
The first one is storage-class. Every object storage service has their own storage class set, we need to do convert between their SDK and storage.

Proposal and implementation: https://github.com/Xuanwo/storage/pull/71


Fixed #34125 -- Prevented double LIMIT on sliced UNION singleton.

The bug existed since sliced query union was added but was elevated to query union slices by moving the .exists() optimization to the compiler in 3d734c09.
Thanks Stefan Hammer for the report.

@charettes Thanks! :1st_place_medal:

I assume this is something we could address in PR as well but I could open a separate ticket for it since it's not a regression/release blocker (it use to crash before these changes). Let me know what works best.

Let's address it separately.

buildbot, test on oracle.

@charettes Thanks :+1:


Allow "recent" as infraction ID for infraction edit command

Resolves #624
Could support multiple phrases but I left it at "recent" to start with. The confirmation message now displays the infraction ID to reduce uncertainty as to which infraction was edited when "recent" is used.

A conflict was introduced here due to #681


Fix building with "trace"

This should hopefully fix the remaining of #352.

Please wait for Travis to finish before merging this to see if anything else needs to be changed.

Coverage remained the same at 62.818% when pulling 2a8d6d2165a55c1fd0bf8949615b809dfeafe16c on fancycode:fix_trace into 14e5ed17730620eb192dabe78bdf1e4d4d1e6504 on mattn:master.

Coverage remained the same at 62.818% when pulling 2a8d6d2165a55c1fd0bf8949615b809dfeafe16c on fancycode:fix_trace into 14e5ed17730620eb192dabe78bdf1e4d4d1e6504 on mattn:master.

Coverage remained the same at 62.818% when pulling b11c6150cd1ddc8d69ff0e14cdd323c4b2f80c47 on fancycode:fix_trace into d1009b4fa6f47db5c69b882339a977fb934f2abc on mattn:master.

@mattn Building now works for all cases but libsqlite3 trace:
could not determine kind of name for C.SQLITE_DETERMINISTIC
could not determine kind of name for C.SQLITE_TRACE_CLOSE
could not determine kind of name for C.SQLITE_TRACE_PROFILE
could not determine kind of name for C.SQLITE_TRACE_ROW
could not determine kind of name for C.SQLITE_TRACE_STMT
could not determine kind of name for C.sqlite3_expanded_sql
could not determine kind of name for C.sqlite3_trace_v2

Is this supposed to work or should I remove it from the Travis build matrix? If it is unsupported it would be better to not build the tracing code if libsqlite3 is defined (even it also trace is defined).

Thank you. But, I modified master branch already because it will need more fixes.
https://travis-ci.org/mattn/go-sqlite3/builds/174141111

You should at least merge / cherry-pick this commit:
https://github.com/mattn/go-sqlite3/pull/354/commits/b11c6150cd1ddc8d69ff0e14cdd323c4b2f80c47
Otherwise the combination of libsqlite3 trace is not tested correctly in Travis (only sets libsqlite3). Also I rebased to your latest changes on master...

merged. thank you

libsqlite3 on travis is too old.


Reduce memory usage

Need to do a profiling pass to find out what is allocating so much. I mostly notice this when there are cycles (before we break them), but the memory grows far too quickly.

This seems to have happened with runaway cycles, but in general the profile shows that not much memory is consumed during evaluation.


High update rate causes disconnects from RoboRIO when there are many topics. Need a way to set lower update rate.

Summary:
When you have a lot of network table entries and attempt to connect to a live robot using AdvantageScope, the Network Tables server disconnects you.
Why does this happen?
According to the WPILib contributor Peter (excerpts of quotes from unofficial FIRST discord):
"it's taking a significant amount of time to send the list of topics over.  meanwhile, it's [NT Server] starting to send value updates every 5 ms.  it checks to see if the transmit buffer is full 10 times (this is a multiple of the update time, not a fixed timer), if that happens it thinks the transmit is stalled and closes the connection."
"advantagescope has ... aggressive subscriber options.  .. periodic=0 (which is forced to the minimum of 5 ms by the server), send all = true"
What could be done?
If there was a way to configure the requested update rate on the AdvantageScope side (the NT default is 100ms), users with many network table entries could still use AdvantageScope live with reduced fidelity. This would be fine, since we can always recover the high-fidelity logs from the robot after the fact.

Could you check if b44b33a fixes your issue? You can download the dev build from GitHub Actions here. This subscribes with a 250ms period at first (to work around the NT server bug where the transmit buffer fills up while sending the list of topics), then it lowers to a 20ms period after one second. Using 20ms instead of 5ms should reduce the server's overly aggressive disconnect behavior.

Thanks, @jwbonner. I will have the opportunity to test later today.

No problem. It looks like Peter fixed some of the issues on the server side too in WPILib 2023.3.1. I'll put out an AdvantageScope release later today.


included 6.0.1

closing in favor of https://github.com/cypress-io/cypress-docker-images/pull/416 that is built on top of an image with newer browsers


Can't seem to get this working on Android, just get a white background

I've tried it by copying all code from the example\app.js down into a new react native app with react-native-maps setup as per the application instructions. I also have put the api key in the app.manifest and followed the instructions to install google play. I am using genymotion free with a custom phone 5.1.0 -api 22 image.
It maybe due to the fact that the Google Apps zip would not flash. can you confirm this as the problem and what I can do about it.

after logcatting i get 'Google Play services is missing' going to retry the flash

everytime i try to to flash the google play zip to my genymotion device it just says failed to flash. ANy ideas?

@sammosampson usually you have to go through a couple of cycles of updating "Google Play Services" in the app store in order to get it to finally work. I think the error you are seeing is normal, you just need to keep going.

I got it working finally with your api key, but it doesn't seem to work
with mine
On Wed, Feb 3, 2016 at 2:24 AM, Leland Richardson<EMAIL_ADDRESS>wrote:

@sammosampson https://github.com/sammosampson usually you have to go
through a couple of cycles of updating "Google Play Services" in the app
store in order to get it to finally work. I think the error you are seeing
is normal, you just need to keep going.
—
Reply to this email directly or view it on GitHub
https://github.com/lelandrichardson/react-native-maps/issues/61#issuecomment-178961667
.

Had the same issue until i checked my developer console. I forgot to enable the Google Maps Api...Now it works great

@sammosampson Closing this since it appears resolved by providing a valid key.


SVC Crawler Sometimes Doesn't Get Full Resolution Images

For some reason the SVC Crawler downloads some images at 540 or lower, even if they are available at 1280.
For example, on this post SVC found the 540 version:
https://66.media.tumblr.com/8fd7c78410baad22922c1f979e5c45b6/afe7ebb0102e1866-3a/s540x810/0d4adcf1ca8511376d8d5fe699f616be3477864e.jpg
but did not find the full quality 1280 version
https://66.media.tumblr.com/8fd7c78410baad22922c1f979e5c45b6/afe7ebb0102e1866-3a/s1280x1920/0926daa27480a7e726df601b4559652ace3d86b2.jpg
Search for image patterns and download specified size don't have any effect.
Setting the crawler to 1280 manually just caused it to download 1280 versions of 2048 images,
I've made sure my quality is set to best, I'm logged in, and the crawler is actually set to SVC.
Is there anything I'm forgetting or is this an issue/limitation of SVC?

No, you are doing everything correctly.
If you look at the attached example data taken from the blog of your screenshot, what we are currently doing if best is chosen in the image size settings is taking the first image from the alt_sizes array:
"photos": [
	{
		"caption": "",
		"original_size": {
			"url": "https://66.media.tumblr.com/b5ea0cc7b102dc5e4efb0d7a8f011886/06839483cd173825-49/s1280x1920/4604aca68d2e5910153e3b00e25e31c1ca6a6b67.jpg",
			"width": 1280,
			"height": 1707
		},
		"alt_sizes": [
			{
				"url": "https://66.media.tumblr.com/b5ea0cc7b102dc5e4efb0d7a8f011886/06839483cd173825-49/s2048x3072/a2347a5f012015bdc424f93c4afbc63ff43c701c.jpg",
				"width": 2048,
				"height": 2731
			},
			{
[..]

I just briefly scanned through this data, and the first item was usually larger (i.e. a 2048px width image) or the same size as the original_size image.
The problem with this "full resolution/_raw" sizes is that they are some kind of an afterthought. All the other sizes are always available for all images, hence just selecting "2048px" might sometimes fail.
However, one could check if the size of the first element of the alt_sizes array is actually larger than the original_size, if yes, take that, otherwise keep the original. But I'm not sure if this is actually the case, that the first element of the alt_size is every smaller than the original_size.
nyx-chaos-nix_svc-data.txt

Thanks for getting back to me!
Again, the issue is with some posts, but not others. If you look at the specific post I referenced above, the photo shown to the user on web (0926daa27480a7e726df601b4559652ace3d86b2) isn't present in the crawler dump.
I'm on mobile so I can't look through the data in depth yet, but this seems to be a problem with answer posts specifically. Answer posts don't have a photoset or photos array, only a 540 version of the image in HTML a few times.
So does Tumblr web make the svc request differently for answer posts? Or do they get the photo to show to the user some other way? I apologize for not being that familiar with the Tumblr api, but I'll experiment and try to figure out tonight.

This looks like a limitation of the api. I'm not really sure how tumblr gets the full size image for answers in web view internally, but it's hard to tell since it is pre-rendered on the server side.
Either way, I was able to download what I needed manually.
Thanks for all the help!

No, you are doing everything correctly.
If you look at the attached example data taken from the blog of your screenshot, what we are currently doing if best is chosen in the image size settings is taking the first image from the alt_sizes array:
"photos": [
	{
		"caption": "",
		"original_size": {
			"url": "https://66.media.tumblr.com/b5ea0cc7b102dc5e4efb0d7a8f011886/06839483cd173825-49/s1280x1920/4604aca68d2e5910153e3b00e25e31c1ca6a6b67.jpg",
			"width": 1280,
			"height": 1707
		},
		"alt_sizes": [
			{
				"url": "https://66.media.tumblr.com/b5ea0cc7b102dc5e4efb0d7a8f011886/06839483cd173825-49/s2048x3072/a2347a5f012015bdc424f93c4afbc63ff43c701c.jpg",
				"width": 2048,
				"height": 2731
			},
			{
[..]

I just briefly scanned through this data, and the first item was usually larger (i.e. a 2048px width image) or the same size as the original_size image.
The problem with this "full resolution/_raw" sizes is that they are some kind of an afterthought. All the other sizes are always available for all images, hence just selecting "2048px" might sometimes fail.
However, one could check if the size of the first element of the alt_sizes array is actually larger than the original_size, if yes, take that, otherwise keep the original. But I'm not sure if this is actually the case, that the first element of the alt_size is every smaller than the original_size.
nyx-chaos-nix_svc-data.txt

It sounds like this would be a way to re-implment being able to download _raws, is this still being looked into?

Not sure what you mean exactly, but it's already implemented since Feburary. It doesn't work for answer posts however, because the data simply doesn't exist for those posts for some reason.
See this release notes information and the corresponding issues for more: https://github.com/TumblThreeApp/TumblThree/releases/tag/v<IP_ADDRESS>

I think it is still present, e.g. https://www.tumblr.com/betaboiseat4feet-blog
has this post
https://www.tumblr.com/betaboiseat4feet-blog/666787421031170048
And the pic can be downloaded 2-3 bigger by web.
either SVC or Api.
I can't achieve that using tumblrthree app.
The same, bigger size I mean.
It downloads like 540 width all the time


Updates to Power BI against master branch

Added description, fixed naming, and linked to samples per team feedback. Tagging @camsoper (I closed the request that was incorrectly against live) and @guyinacube as FYI. Will have team review for sign-off.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/overview/azure/powerbi-embedded.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

#sign-off

#sign-off

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/overview/azure/powerbi-embedded.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


completed assignment 7

Hey @KevinSFC - your code looks good, but it looks like you accidentally opened this pull request into Bloc's ios-exercises repo instead of your fork of the repo. :)


Feat(eos_cli_config_gen): Extend match lists to support IPv4 and IPv6

Change Summary
This PR extends the existings match-lists from just strings to include both IPv4 and IPv6 prefix lists
Related Issue(s)
Fixes #3768
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
The change extends the existing match-list dict to include 2 new keys - prefix_ipv4 and prefix_ipv6.
The data model, as discussed in #3768 is below:
match_list_input:
  prefix_ipv4:
    - name: <str; required; unique>
      prefixes:
         - <list of IPv4 prefixes>
  prefix_ipv6:
    - name: <str; required; unique>
      prefixes:
        - <list of IPv6 prefixes>

How to test

Checklist
User Checklist

N/A

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

Tested the config on CLI, LGTM


Map License

Having a hard time tracking down the license used for the maps, is it okay to redistribute them? Can you point me in the direction of the license for the maps? Especially the official ones from Blizzard.
Thanks!

This is a good to consider the situation.
First, at the bottom of the documentation are references to various map repos -- I talked with each of the map repo owners and obtained their permission to include them in this package.  Some don't have licenses; others don't.  pysc2 uses the same apache 2.0 license.  That's pretty cut and dry.
Previously, I found nothing concrete for Blizzard maps that specifies this repo publication would go against anything Blizzard claims. Nothing in their policies that I could see govern distributing maps, even Blizzard maps -- except unless its done for financial gain or commercial purpose.
In the SC2 map editor, the 'author' is listed as Blizzard, but most maps list the actual creator in the description.  Blizzard's policy is pretty anal about map ownership.  In fact, in the EULA they outright claim 100% ownership of all maps ever created for their games.

Blizzard EULA
Blizzard Acceptable Use

While the EULA's assertions don't hold water legally speaking, this also isn't worth going to war over. I published this repo to help others, that's it. This is somewhat murky water.  I'll reach out to Blizzard and ask permission. If Blizz objects to our usage, we'll just unpublish this repository from github.

Ticket ID US63604078

If we can't redistribute, then we can keep the repo and just have a script
that downloads the maps. That's what a lot of people do to get around the
redistribution limitation.
On Thu, Jun 14, 2018 at 9:49 PM, Ttinies<EMAIL_ADDRESS>wrote:

Ticket ID US63604078
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ttinies/sc2gameMapRepo/issues/1#issuecomment-397505709,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALOI3vxl36HUORYMUK7YM5axp4ZbYeVcks5t8y7FgaJpZM4UnWCf
.

Lady Game Master Powencis responded.  Besides a mildly entertaining email, she confirmed that maps already provided for free by Blizzard "should be fine" as long as there's no profit for doing so.  She also included another link to a legal FAQ that also seems to confirm as much.


Document Indent/Outdent shortcut for the Description Editor

PR: https://github.com/NationalSecurityAgency/skills-docs/pull/258


Manage Page Enhancements

Requires

Dropdown to filter by role
Total hours volunteered on the bottom

@Cubified How should we implement this total hours volunteered stat?
The user model tracks events and manually added events.

Track each user's hours as a virtual in the user model -- this would cause us to calculate this every time a user is fetched, which is not necessary. We would then sum the visible users' hours and display.
Calculate the total hours just on this page based on visible users, this would require a longer client-side compute time but could have a loader just for this


Do PoC on docker doc build with intersphinx using mounted index build

Pull request for Do PoC on docker doc build with intersphinx using mounted index build.

This is mainly for @nadade for demonstration, but also //cc @JackuB and @smizell as I feel they may be interested ;)

@Almad I've successfully ran the script and produced output, I think it's good to go :+1:
sidenote: I'd vote for more emphasis on using namespaces with the common terms to avoid duplicity and confusion

Finished my typo hunt. Minor stuff.

@honzajavorek I think every library should have its docs eventually plus even now there are various terms used for the same thing throughout the documentation, this will definitely help keep things tidy and coherent..

@honzajavorek yes. every service should have its own docs. apiary has it even now, but it'll be more widespread, hopefully :)


mzMLb

Hello,
I've seen you cross-post a few places regarding mzMLb reading and writing. The current development version of https://github.com/levitsky/pyteomics has support for mzMLb reading, and the last release of psims includes an mzML to mzMLb conversion tool:
from psims.transform.mzml import MzMLToMzMLb

MzMLToMzMLb("mzml_path", "mzmlb_path").write()

Both require h5py and hdf5plugin.

Amazing. I will give it a try. Thank you!!

From: Joshua Klein @.>
Sent: Wednesday, April 28, 2021 10:14:04 AM
To: soerendip/ms-mint @.>
Cc: Subscribed @.***>
Subject: [soerendip/ms-mint] mzMLb (#23)
Hello,
I've seen you cross-post a few places regarding mzMLb reading and writing. The current development version of https://github.com/levitsky/pyteomics has support for mzMLb reading, and the last release of psims includes an mzML to mzMLb conversion tool:
from psims.transform.mzml import MzMLToMzMLb
MzMLToMzMLb("mzml_path", "mzmlb_path").write()
Both require h5py and hdf5plugin.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/soerendip/ms-mint/issues/23, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAZ4A7Q2VDYQVIQBG2IJDDLTLAX4ZANCNFSM43XMVV4Q.

This was all written pretty quickly, so if you encounter issues please let me know. Also, because mzMLb is an HDF5 file, it was written with extensibility in mind.
If there are particular search or metadata indices you think would be useful to have, that would be good to know about. I know a lot of people write index files that sit beside their spectra files to store extra metadata, but mzMLb has the capacity to include them directly without violating compatibility.


Create shadow color design tokens for light mode and darkmode

Description
Create shadow color design tokens for light mode and darkmode
Technical Details

Do audit of current box shadows in IA Nav and current code base @georgewrmarshall
Discuss audit and pull out common rules or patterns
Define the 4 design tokens for color default, alternative, muted etc or create new versions

Acceptance Criteria
TBC
References
TBC

Duplicate #36


app.client.getWindowCount() includes an extra window for electron-react-devtools

I'm using electron-react-devtools for my react app.
When I call app.client.getWindowCount(), it returns 2 windows; the 2nd window has the url chrome-extension://react-developer-tools/_generated_background_page.html
This is causing some issues for my tests, since I don't want to count that page as an actual window.
Is there any way to ignore this window for all Window commands (eg. windowByIndex)?

@scottrippey This has been discussed before and TLDR: no.  The API currently acts as expected (the background page is technically it's own window).  If you don't want your tests to include this window, don't install the devtools in your tests.
Or you yourself can apply a filter to the returned windows and exclude the ones you want.

Ok, thank you for the fast response.  I was considering the filter approach.  Do you have any recommendation on what criteria to filter by?  Is there any easy way to identify non-app windows like this?
I'm considering using getUrl(), and filtering by the chrome-extension:// protocol.

@MarshallOfSound Do you have any suggestions for the above?  I'm still not sure if there's a better way to handle number 1 above?  (number 2 is looking to be viable)
Also, is there any alternative to switchTabs that lets me specify which window I want to switch to?  Seems like maybe switchTabs is occasionally switching to the dev-tools.


Add Workflow for Closing Old Issues

Is your feature request related to a problem? Please describe.
Over time, repositories can accumulate a large number of open issues, including some that may no longer be relevant or actively worked on. Manually closing these old issues can be time-consuming and tedious.
Describe the solution you'd like
I would like a workflow that automatically identifies and closes old issues based on certain criteria, such as no recent activity or being open for a specific duration.
What problem is this feature trying to solve?
This feature aims to automate the process of managing old issues, ensuring that the repository remains organized and focused on relevant tasks. By automatically closing old issues, it reduces manual overhead for repository maintainers and helps keep the issue tracker tidy and up-to-date.

@Trisha-tech please assign me this issue under gssoc'24

Hello @Asymtode712 , Go for it
All the best


Picture plugin enhancements

Enter your suggestions in details:
I've been testing the picture plugin, as I'm looking to migrate from Eleventy (and it's image plugin) to Lume. There are a few additional features the Eleventy's image plugin offers that I'd love to see in Lume's picture plugin[^1]:

width and height attributes are added to the img element.
Images aren't scaled up beyond their original dimensions.
It's easy to add deocding="async" and loading="lazy" attributes to the img element.
It enforces that there is an alt attribute set on the img element.
A hash of the image's contents is included in the filename of generated images (to support setting long cache headers).

I thought I'd raise them here to see if any of these could be incorporated into the picture plugin. I'd be happy to try and implement some of these myself, if there is an appetite to add these.
I think item 5 is covered by https://github.com/lumeland/lume/issues/352, and I think it makes sense to be a separate plugin rather than something purely image related. I'd love to see some progress made on this (and would be happy to try and contribute this, but would need some guidance on the right approach to take).
I think items 3 & 4 are simple enough to do with a plugin I could write myself, so no worries if these don't become part of the picture plugin.
I don't think that item 2 is possible with the picture plugin. Is this currently possible? If not, is this a feature you'd like to see with the picture plugin?
Now for item 1, again this could be done as part of plugin I could write. However, this one gave me some pause for thought. Doing this myself would mean that I've have to read the contents of the generated images to work out their dimensions. As the imagick plugin has already read and processed the images, it seems a bit wasteful to re-read them. However, this is totally doable with another plugin that runs after the picture/imagick plugins, so it's also not a deal breaker if I have to write this myself.
Is adding width and height attributes to img elements something that could be done with the picture plugin?
[^1]: This has partially been covered by this discussion. Apologies for re-raising some of these points.

For point 1: Yeah, your code looks reasonable. There's a repo for experimental / beta plugins: https://github.com/lumeland/experimental-plugins
If you want to work on this plugin, we can include it here, in order to test it.
For point 2: Ok, sorry for the missunderstanding. I'll check that.
For point 5: Great! let me know when you want to start!

I think point 2 is the only outstanding issue from this thread, and that seems to have been addressed by #530, so I think this issue can be closed.


forge coverage --via-ir fails with stack too deep

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
No response
What command(s) is the bug in?
No response
Operating System
None
Describe the bug
I'm forwarding this issue and tagging @0x5chn0uf.
Link to original issue: https://github.com/Cyfrin/foundry-full-course-cu/discussions/1966#discussioncomment-9986282

Hi!
At the end of Lesson 15: Foundry Account Abstraction, I'm looking to complete the test suite. However, I encounter a problem when using forge coverage --via-ir to compile my Solidity project. The following error occurs:
minimal-account-abstraction % forge coverage --via-ir
[⠒] Compiling...
[⠰] Compiling 88 files with Solc 0.8.24
[⠑] Solc 0.8.24 finished in 8.39s
Error:
Compiler run failed:
Error: Compiler error (/solidity/libyul/backends/evm/AsmCodeGen.cpp:67):Stack too deep. Try compiling with `--via-ir` (cli) or the equivalent `viaIR: true` (standard JSON) while enabling the optimizer. Otherwise, try removing local variables. When compiling inline assembly: Variable value0 is 2 slot(s) too deep inside the stack. Stack too deep. Try compiling with `--via-ir` (cli) or the equivalent `viaIR: true` (standard JSON) while enabling the optimizer. Otherwise, try removing local variables.
CompilerError: Stack too deep. Try compiling with `--via-ir` (cli) or the equivalent `viaIR: true` (standard JSON) while enabling the optimizer. Otherwise, try removing local variables. When compiling inline assembly: Variable value0 is 2 slot(s) too deep inside the stack. Stack too deep. Try compiling with `--via-ir` (cli) or the equivalent `viaIR: true` (standard JSON) while enabling the optimizer. Otherwise, try removing local variables.

Command executed:
forge coverage --via-ir
Environment
Solidity Version: 0.8.24
Foundry Version: forge 0.0.2 (from foundry-zksync)
OS: MacOS 14.2.1
Context
I also have this problem with the final code of the minimal-account-abstraction repository. I run the forge coverage command and get the error mentioned above.
What I've tried

Enable optimization: I've tried using --via-ir --optimize but the error persists.
Reduce local variables: I tried refactoring some functions to reduce the number of state variables, but this didn't solve the problem.

I read that the error seems to be related to assembler, but I don't see where I can rework the code and modify the stack.
Do you have any suggestions on how to solve this problem or additional leads to explore?
Thanks in advance!

Hi there, thanks for bringing this up @PatrickAlphaC! 🙂
To add more context, I'm (in theory) using the latest version of foundry-zksync after running the foundryup-zksync installation command.
I'm encountering this problem on the repo associated with Patrick's course on Account Abstraction, but also on another repo linked to ZkSync (MondrianWallet2 FirstFlight).
Here is the version installed:
minimal-account-abstraction % forge --version
forge 0.0.2 (ab00f2e 2024-07-12T00:22:09.735302000Z)

Additionally, here is the content of my foundry.toml file, where via-ir and is-system are set to true.
[profile.default]
src = "src"
out = "out"
libs = ["lib"]
remappings = ['@openzeppelin/contracts=lib/openzeppelin-contracts/contracts']
is-system = true
via-ir = true
fs_permissions = [
    { access = "read", path = "./broadcast" },
    { access = "read", path = "./reports" },
]

forge build executes successfully with and without the zksync flag
minimal-account-abstraction % forge build --via-ir
[⠒] Compiling...
[⠰] Compiling 88 files with 0.8.24
[⠒] Solc 0.8.24 finished in 78.79s
Compiler run successful!

minimal-account-abstraction % forge build --via-ir --zksync
[⠃] Compiling (zksync)...
Compiler run successful with warnings:
.
.
.

However, when I try to obtain test coverage, despite using the --via-ir flag, the command fails with the Stack too deep error described in the initial thread.
 minimal-account-abstraction % forge coverage --via-ir

[⠆] Compiling...
[⠢] Compiling 88 files with 0.8.24
[⠒] Solc 0.8.24 finished in 9.12s
Error:
Compiler run failed:
Error: Compiler error (/solidity/libyul/backends/evm/AsmCodeGen.cpp:67):Stack too deep. Try compiling with `--via-ir` (cli) or the equivalent `viaIR: true` (standard JSON) while enabling the optimizer. Otherwise, try removing local variables. When compiling inline assembly: Variable value0 is 2 slot(s) too deep inside the stack. Stack too deep. Try compiling with `--via-ir` (cli) or the equivalent `viaIR: true` (standard JSON) while enabling the optimizer. Otherwise, try removing local variables.
CompilerError: Stack too deep. Try compiling with `--via-ir` (cli) or the equivalent `viaIR: true` (standard JSON) while enabling the optimizer. Otherwise, try removing local variables. When compiling inline assembly: Variable value0 is 2 slot(s) too deep inside the stack. Stack too deep. Try compiling with `--via-ir` (cli) or the equivalent `viaIR: true` (standard JSON) while enabling the optimizer. Otherwise, try removing local variables.

Same with --zksync flag
minimal-account-abstraction % forge coverage --via-ir --zksync

[⠢] Compiling...
[⠒] Compiling 88 files with 0.8.24
[⠰] Solc 0.8.24 finished in 8.04s
Error:
Compiler run failed:
.
.

Tests are compiled and run correctly with the forge test command
minimal-account-abstraction % forge test --zksync
[⠢] Compiling...
No files changed, compilation skipped
[⠢] Compiling (zksync)...
No files changed, compilation skipped

Ran 5 tests for test/ethereum/MinimalAccountTest.t.sol:MinimalAccountTest
[PASS] testEntryPointCanExecuteCommands() (gas: 42342)
[PASS] testNonOwnerCannotExecuteCommands() (gas: 42364)
.
.
.

Do not hesitate to let me know if you need any further information!

Thanks for posting the issue. forge coverage is not fully supported but is being prioritized. I will keep this open in the meantime.

@PatrickAlphaC @0x5chn0uf have you tried using vanilla foundry to run coverage for those contracts? Currently we don't do anything different from them. coverage tries to compile using solc without much optimizations to be able to output the source map and then runs on plain EVM for now. If the contracts you try to compile give stack too deep with plain solc, there wont' be much specific things we can do about this case afaik.


OCPBUGS-33934: Add newline after TLS certs referenced by image.config

Once you add more than one certificate to the ConfigMap referenced in the image.config.openshift.io spec field, the getImageRegistryCABundle processes the certificates properly. However, if you add these through the UI console, the user might not include the newline character, which results in overlapping certificates. This PR ensures a newline is always added after each certificate processed.
Which issue(s) this PR fixes :
Fixes #OCPBUGS-33934

/jira refresh

/lgtm

/lgtm

/cherry-pick release-4.16


Visualization tool for the AGE 0.4.0 release

@Kim-Changhyun @emotionbug
Guys, does the current AGViewer (available at https://github.com/bitnine-oss/AGViewer) support AGE 0.4.0?

Yes. However, nothing has been changed for AGE 0.4.
because, we are control just for metadata.

@emotionbug I see, I suppose what you meant was that the parts AGViewer talks to in AGE remained same from 0.3.0 to 0.4.0.

Yes, that’s right.


Database Model for Inventory Items

Need to create the Database Model for Inventory Items
Description:
As a developer, I need to create the database model for inventory items using SQLAlchemy so that we can store and manage inventory data effectively in the PostgreSQL database.
Assumptions:
We are using SQLAlchemy as the ORM (Object-Relational Mapping) tool.
The inventory items will have the following fields:
The inventory items will have the following fields:
id (Integer, primary key)
name (String, required)
description (String, optional)
quantity (Integer, required)
price (Float, required)
product_id (Integer, required)
restock_level (Integer, optional)
condition (String, optional; new, open box, used)
Acceptance Criteria:
Database Model Creation:

Given the requirement to store inventory items,
When I create the SQLAlchemy model,
Then the model should include fields for id, name, description, quantity, price, product_id, restock_level, and condition.

Database Table Creation:
Given the SQLAlchemy model,When I initialize the database,Then the table should be created in the PostgreSQL database with columns corresponding to the model fields.
API Endpoint for Creating Inventory Items:
Given the InventoryItem model,When I create a POST endpoint /inventory,Then I should be able to create a new inventory item by sending a JSON object containing the required fields (name, quantity, price, product_id) and optional fields (description, restock_level, condition).
API Endpoint for Reading Inventory Items:
Given the InventoryItem model,When I create a GET endpoint /inventory/int:item_id,
Then I should be able to retrieve the inventory item details by its id.
Field Validations:
Given the InventoryItem model,
When I create or update an inventory item,
Then the following validations should be applied:

name must be a non-empty string.
quantity must be a non-negative integer.
price must be a non-negative float.
product_id must be a valid integer.
condition must be one of ["new", "open box", "used"], if provided.

Test Cases:
Create tests for the InventoryItem model to ensure it meets the specifications.
Ensure RESTful return codes and headers are correctly implemented.

Added PR for above Issue :
https://github.com/CSCI-GA-2820-SU24-001/inventory/pull/11


Generating service worker fails when some Unicode paths need to be cached

Use this config file:
{
  "boilerplate_dir": "caterpillar-boilerplate-\ud83d\udcc2",
  "report_dir": "report-caterpillar-\u2611",
  "start_url": "index.html"
}

Convert an app. Service worker generation raises errors.

Resolved in this CL.


fix: reorder DA tasks

What is the current behavior?
Publish state then prove
Resolves: #NA
prove then publish state, as in validity mode the eth core contracts update_state check for the proof

lgtm


1.4 bread multiple scopes

Here is the PR for [feature] multiple scopes for a datatype #5353.
It permits to define and apply several query scopes to BREAD model.

Codecov Report

Merging #5373 (d88908e) into 1.4 (af3498f) will increase coverage by 0.01%.
The diff coverage is 44.44%.

:exclamation: Current head d88908e differs from pull request most recent head c5252eb. Consider uploading reports for the commit c5252eb to get more accurate results

@@             Coverage Diff              @@
##                1.4    #5373      +/-   ##
============================================
+ Coverage     63.53%   63.55%   +0.01%
+ Complexity     1399     1392       -7
============================================
  Files           195      195
  Lines          4136     4141       +5
============================================
+ Hits           2628     2632       +4
- Misses         1508     1509       +1

Impacted Files
Coverage Δ

src/Models/Page.php
75.00% <0.00%> (-25.00%)
:arrow_down:

src/Http/Controllers/VoyagerBaseController.php
62.80% <50.00%> (+0.16%)
:arrow_up:

src/Http/Controllers/VoyagerBreadController.php
57.14% <50.00%> (+0.93%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af3498f...c5252eb. Read the comment docs.

Hi @MrCrayon
I've applied proposed changes.
Cheers.

Automatic tests failed with messages like:
Warning: Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/25a956c84d5dd820d28caab9f86b8d183aeeff3d'. Error: The operation was canceled.
Warning: Back off 18.674 seconds before retry.
Warning: Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/25a956c84d5dd820d28caab9f86b8d183aeeff3d'. Error: The operation was canceled.
Warning: Back off 21 seconds before retry.


fails with indexed and optimized image with low colors

I assume this is an issue with the respective library, https://github.com/kornrunner/php-blurhash.
As a workaround, my Thumbhash plugin seems to handle this image just fine.


Testing auto merge and test of pull requests: test/anand/auto-build

@Moritz, feel free to merge this. This is just a test exercise.


[jinja2.api] Sidebar contents extend into the main area

Just for your information: I found sidebar contents extend into the main area.
https://jinja.palletsprojects.com/en/3.1.x/api/

Duplicate of issues in both the jinja amd themes repos.

Sorry, I mistake place to report. And this issue is a duplicate of https://github.com/pallets/jinja/issues/1761


[BOT PR] to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
Assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
1430b73bb1159f9ad9805a37925e1eed26cfdbbe
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Fix crash for optional properties (Also upgrades to Swift 5.0)

This enables Fuse to safely access optional properties that might be nil.
Also upgrades to Swift 5.0 & bumps version in Podspec but I can exclude that change if necessary for some reason.

Sorry, after further investigation there are still some issues and it doesn't work as expected.
I'll close this for now.


RHIROS-987 - upgrade flask,werkzeug to newer versions

Why do we need this change? :thought_balloon:

This updates the flask*, werkzeug and rest of the packages to latest version.
This removes the pinning of the markupsafe = "==2.0.1" as I don't see any of the latest dependencies using soft_unicode from markupsafe. More about issue at https://github.com/aws/aws-sam-cli/issues/3661

Documentation update? :memo:

[ ] Yes
[x] No

Security Checklist :lock:
Upon raising this PR please go through RedHatInsights/secure-coding-checklist
:guardsman: Checklist :dart:

[ ] Bugfix
[ ] New Feature
[ ] Refactor
[ ] Unittests Added
[ ] DRY code
[x] Dependency Updated
[ ] DB Migration Added

This updates flask to 2.2.3, I am yet to go through change matrix of 2.2.1, 2.2.2 and 2.2.3 https://github.com/pallets/flask/releases

The sqlalchemy query api has been deprecated and we will need to migrate the queries as per new 2.0 specification : https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#migration-20-query-usage . I will checking this further.

\retest

/retest

After rebase I can see test failures :\ I am still working on to get all queries based on 2.0 spec

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.45 :tada:

Comparison is base (8ce7aaa) 72.69% compared to head (36545e1) 73.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   72.69%   73.15%   +0.45%
==========================================
  Files          27       28       +1
  Lines        1311     1326      +15
==========================================
+ Hits          953      970      +17
+ Misses        358      356       -2

Flag
Coverage Δ

unittests
73.15% <100.00%> (+0.45%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

ros/api/common/utils.py
92.72% <100.00%> (+0.13%)
:arrow_up:

ros/api/main.py
93.75% <100.00%> (+0.89%)
:arrow_up:

ros/api/v1/call_to_action.py
29.16% <100.00%> (ø)

ros/api/v1/hosts.py
86.46% <100.00%> (ø)

ros/api/v1/status.py
100.00% <100.00%> (ø)

ros/extensions.py
100.00% <100.00%> (ø)

ros/lib/app.py
100.00% <100.00%> (ø)

ros/lib/models.py
100.00% <100.00%> (ø)

ros/lib/utils.py
87.74% <100.00%> (ø)

ros/processor/garbage_collector.py
75.75% <100.00%> (+0.75%)
:arrow_up:

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

/retest

/retest

As per the discussion with @yash2189 the EE failures should not be related to this change. He is checking further on this.

/retest

/retest

/retest

@upadhyeammit - jobs are not happy :)

I rebased, squashed and looks like we are green!


Switch tabs through code

Is there a way to switch the tab in our code?

I'm planning a sprint on tabs, with full styling (changing colors), setting selected tab through code, adding badges over tabs (from the PR). Should be done in a day or two

How long would it be before we see these changes in react-native-navigation packages.

@talkol Sounds great, as always great work!

Done. Added on https://github.com/wix/react-native-controllers/commit/e54a3371adf33eced40c35980ba2d040864e9fc5. Going to work on the README and immediately after that @smooJitter add all the stuff to react-native-navigation

notice I will only release the package with this stuff tomorrow after some qa

released 1.2.6 with this inside

@smooJitter all tab features (styles, switching, badges, toggle) are now available in react-native-navigation 0.1.5


Please add stagehand integration

So that the user can easily create new Dart projects.

+1 :)
This would get a bit easier once we're compiled with the ddc - it'll be easier to consume custom elements written in JS, which some of the more sophisticated atom controls are, like the select list.


[BAT] merge drone with master

Coverage increased (+1.08%) to 54.584% when pulling ade3e6512d4062c7d29dee4d53f7c8dc96cb4797 on wy65701436:drone into 57794eab860771976de480bbab01016b2bede15c on vmware:drone.

Coverage increased (+1.08%) to 54.584% when pulling cbbf09d2ac74ca50d643d6c0f419ee67fdf867c1 on wy65701436:drone into 57794eab860771976de480bbab01016b2bede15c on vmware:drone.

Coverage increased (+1.08%) to 54.584% when pulling 5ec19996375095f7954cfa8fc3f5b9daf9ae2d53 on wy65701436:drone into 57794eab860771976de480bbab01016b2bede15c on vmware:drone.


Fix multiple tables scaling incorrectly

This PR sets the table layout to fixed whenever a table has more than two columns. I'd love to hear your thoughts on this change.
Before:

After:

Tables with less than two columns don't have a fixed table layout:

But if this needs to change: this is what it would look like if the same table has a fixed table layout:

I think this is a pretty good work around,  but still somewhat fragile ;). I guess the decisions page (https://avisi-cloud.github.io/structurizr-site-generatr/main/internet-banking-system/decisions/) is still a but off with this PR.
I think a better and more consistent approach might be to handle a fixed percentage per column type. So e,g. give all columns with the name ID, Date and Status a width of 20%, columns for Systems, Technology and Name a width of 30%. Other columns might not need a set width.


[fix] reduce unique errors coming out of our AccessDenied error logging

The request-id field prompted a flood of unique errors in our error reporting system, so I got rid of that unique identifier.

Codecov Report

Merging #72 into main will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   58.05%   58.05%
=======================================
  Files          14       14
  Lines         875      875
=======================================
  Hits          508      508
  Misses        322      322
  Partials       45       45

Impacted Files
Coverage Δ

pkg/aws_config_server/list_roles.go
87.76% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f9a4a...7629377. Read the comment docs.


Build static libraries for arrow.

We should build both dynamic and static leaf libs. Let me know if I can help

FYI: We have merged in the last days CMake code that will also build static Arrow libs.

Awesome, thank you!


Help wanted

Expected Behavior
I want to read cookies from different domain
Actual Behavior
... N/A
Steps to Reproduce the Problem
... N/A
Specifications

Version: ...
Browser: ...
...

@CunningFatalist  I have read that already. There is no option to read cookies from another domain by using this library.

@sajanv88 Yes, that is why I linked the FAQ. For security reasons, what you are trying to do is impossible. This is not something we decided to do, it is browser default behaviour.


Adding a test with KWStyle for Travis CI

@RyDroid thanks for the suggestion.
For enforcing the style, I would prefer to use Stickler CI or alternatively the Nitpick CI.
I prefer the first because it is actively used for the CakePHP framework, build by its lead developer Mark Story, which I personally know, too.

Created #457

KWStyle is free/libre software and can be used localy. Stickler CI seems to be proprietary and online only. It is easier and faster to test locally. Moreover with a service, there is always the risk that it stops.

Sure, by using services you always inherit some risks.
Nonetheless, I already have integrated Stickler CI now.
Plus KWStyle is not popular in the PHP community. Also it is not written in PHP.
While PHPCS is both and we already use it.
So I do not see the need for KWStyle.
By the way, have you seen https://github.com/phpmd/phpmd/commit/24ff5a9ec3308458db66da019901e4013a6ca4ee?
This way you can simply type composer cs-check and get the code checked against PSR-2.

Ok.
https://github.com/phpmd/phpmd/commit/24ff5a9ec3308458db66da019901e4013a6ca4ee looks like cool (but I never used composer, I am used to the C/C++ world with make and packages of my GNU/Linux distribution).

Plus KWStyle is not popular in the PHP community.

That does not seem to me to be a good reason. Because by refusing to use it, you are partly responsible for his lack of popularity in the PHP community (it can look like a personal attack, but it is not the case, unfortunately I did not find an other way to write it).

Also it is not written in PHP.

I can understand the problem of coherence (especially if the program has to be compiled or installed with a language specific tools, but here it is provided by Debian as a deb package). However with this argument, you rewrite each program in your own favorite language: a big lack of effort and time.

Plus KWStyle is not popular in the PHP community

It is not a reason, but a fact, I stated.

That does not seem to me to be a good reason. Because by refusing to use it, you are partly responsible for his lack of popularity in the PHP community (it can look like a personal attack, but it is not the case, unfortunately I did not find an other way to write it).

That's OK, I got yoru message. 😼
In the end, the PHP community has chosen or created its tools of choice over many years, just like C/C++ has, I assume.
One of those tools is Composer, which has revolutionized the way the PHP community can organize packages and dependencies. It's similar to NPM (inspired by, if I recall correctly).
The PHP community has moved away from system managed packages and dependencies for many good reasons.
As for code style checking in PHP there is already one ubiquitous tool: PHPCS. PHPMD already uses it and services like Scrutinizer CI and Travis CI either integrate it already or integrate with it well.

However with this argument, you rewrite each program in your own favorite language: a big lack of effort and time.

While I do agree with you on this, this also allows to specialize and optimize a tool.
Since with PHPCS you only can check code style for languages a typical PHP web developer cares about (PHP, JavaScript and CSS), it does not get bloated but is the optimized tools for it.
If you are interseted in future contributing within the PHP community, I'd love to support you.

Ok. :-)


ENS support

It'd be awesome if the ledger plugin supported ENS! Please feel free to use me as a resource; implementer docs are here: http://docs.ens.domains/en/latest/implementers.html

I second this. ENS support would drastically reduce human error when inputting a recipient.

Any estimation on this? ENS is getting really popular now that they opened 3-6 character domain names. I think it would be really helpful to be able to send transactions to ENS domain names and it’d be nice to see account balance addresses in ENS

@ivan-prodanov https://github.com/LedgerHQ/ledger-live-desktop is the repository you are looking for. No ETA at the moment.


local installation fail

System Info
Iam refferng to  https://github.com/huggingface/text-generation-inference?tab=readme-ov-file#local-install to install TGI locally. But iam keep on getting an error related to vllm
RuntimeError: Cannot find CMake executable
make[1]: *** [Makefile-vllm:5: build-vllm-cuda] Error 1
make[1]: Leaving directory '/home/gpu/path/llm/text-generation-inference/server'
make: *** [Makefile:2: install-server] Error 2

Information

[ ] Docker
[X] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction
git clone https://github.com/huggingface/text-generation-inference.git
cd text-generation-inference/
BUILD_EXTENSIONS=True make install
Expected behavior
To complete build

Hi @ragesh2000 👋
Thanks for reporting this!
It seems like you might not have cmake installed?

@ErikKaum  I have cmake in my system with version cmake version 3.22.1
Here is the complete traceback
-- Enabling C extension.
-- Enabling moe extension.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/gpu/ai/llm/quantise/text-generation-inference/server/vllm/build/temp.linux-x86_64-cpython-311
gmake[2]: Entering directory '/home/gpu/ai/llm/quantise/text-generation-inference/server/vllm/build/temp.linux-x86_64-cpython-311'
gmake[3]: Entering directory '/home/gpu/ai/llm/quantise/text-generation-inference/server/vllm/build/temp.linux-x86_64-cpython-311'
gmake[4]: Entering directory '/home/gpu/ai/llm/quantise/text-generation-inference/server/vllm/build/temp.linux-x86_64-cpython-311'
gmake[5]: Entering directory '/home/gpu/ai/llm/quantise/text-generation-inference/server/vllm/build/temp.linux-x86_64-cpython-311'
gmake[5]: Leaving directory '/home/gpu/ai/llm/quantise/text-generation-inference/server/vllm/build/temp.linux-x86_64-cpython-311'
gmake[5]: Entering directory '/home/gpu/ai/llm/quantise/text-generation-inference/server/vllm/build/temp.linux-x86_64-cpython-311'
[ 33%] Building CXX object CMakeFiles/_moe_C.dir/csrc/moe/moe_ops.cpp.o
[ 66%] Building CUDA object CMakeFiles/_moe_C.dir/csrc/moe/topk_softmax_kernels.cu.o
/usr/include/c++/11/bits/std_function.h:435:145: error: parameter packs not expanded with ‘...’:
  435 |         function(_Functor&& __f)
      |                                                                                ^
/usr/include/c++/11/bits/std_function.h:435:145: note:         ‘_ArgTypes’
/usr/include/c++/11/bits/std_function.h:530:146: error: parameter packs not expanded with ‘...’:
  530 |         operator=(_Functor&& __f)
      |                                                                                ^
/usr/include/c++/11/bits/std_function.h:530:146: note:         ‘_ArgTypes’
gmake[5]: *** [CMakeFiles/_moe_C.dir/build.make:90: CMakeFiles/_moe_C.dir/csrc/moe/topk_softmax_kernels.cu.o] Error 1
gmake[5]: Leaving directory '/home/gpu/ai/llm/quantise/text-generation-inference/server/vllm/build/temp.linux-x86_64-cpython-311'
gmake[4]: *** [CMakeFiles/Makefile2:112: CMakeFiles/_moe_C.dir/all] Error 2
gmake[4]: Leaving directory '/home/gpu/ai/llm/quantise/text-generation-inference/server/vllm/build/temp.linux-x86_64-cpython-311'
gmake[3]: *** [CMakeFiles/Makefile2:119: CMakeFiles/_moe_C.dir/rule] Error 2
gmake[3]: Leaving directory '/home/gpu/ai/llm/quantise/text-generation-inference/server/vllm/build/temp.linux-x86_64-cpython-311'
gmake[2]: *** [Makefile:182: _moe_C] Error 2
gmake[2]: Leaving directory '/home/gpu/ai/llm/quantise/text-generation-inference/server/vllm/build/temp.linux-x86_64-cpython-311'
Traceback (most recent call last):
  File "/home/gpu/ai/llm/quantise/text-generation-inference/server/vllm/setup.py", line 383, in <module>
    setup(
  File "/home/gpu/miniconda3/envs/tgi/lib/python3.11/site-packages/setuptools/__init__.py", line 108, in setup
    return distutils.core.setup(**attrs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/gpu/miniconda3/envs/tgi/lib/python3.11/site-packages/setuptools/_distutils/core.py", line 184, in setup
    return run_commands(dist)
           ^^^^^^^^^^^^^^^^^^
  File "/home/gpu/miniconda3/envs/tgi/lib/python3.11/site-packages/setuptools/_distutils/core.py", line 200, in run_commands
    dist.run_commands()
  File "/home/gpu/miniconda3/envs/tgi/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 970, in run_commands
    self.run_command(cmd)
  File "/home/gpu/miniconda3/envs/tgi/lib/python3.11/site-packages/setuptools/dist.py", line 956, in run_command
    super().run_command(command)
  File "/home/gpu/miniconda3/envs/tgi/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 989, in run_command
    cmd_obj.run()
  File "/home/gpu/miniconda3/envs/tgi/lib/python3.11/site-packages/setuptools/_distutils/command/build.py", line 135, in run
    self.run_command(cmd_name)
  File "/home/gpu/miniconda3/envs/tgi/lib/python3.11/site-packages/setuptools/_distutils/cmd.py", line 316, in run_command
    self.distribution.run_command(command)
  File "/home/gpu/miniconda3/envs/tgi/lib/python3.11/site-packages/setuptools/dist.py", line 956, in run_command
    super().run_command(command)
  File "/home/gpu/miniconda3/envs/tgi/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 989, in run_command
    cmd_obj.run()
  File "/home/gpu/miniconda3/envs/tgi/lib/python3.11/site-packages/setuptools/command/build_ext.py", line 93, in run
    _build_ext.run(self)
  File "/home/gpu/miniconda3/envs/tgi/lib/python3.11/site-packages/setuptools/_distutils/command/build_ext.py", line 359, in run
    self.build_extensions()
  File "/home/gpu/ai/llm/quantise/text-generation-inference/server/vllm/setup.py", line 188, in build_extensions
    subprocess.check_call(['cmake', *build_args], cwd=self.build_temp)
  File "/home/gpu/miniconda3/envs/tgi/lib/python3.11/subprocess.py", line 413, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['cmake', '--build', '.', '--target', '_moe_C', '-j', '64']' returned non-zero exit status 2.
make[1]: *** [Makefile-vllm:5: build-vllm-cuda] Error 1
make[1]: Leaving directory '/home/gpu/ai/llm/quantise/text-generation-inference/server'
make: *** [Makefile:2: install-server] Error 2

Ah okay okay, gotcha. Thank you for the full stack trace 👍
So your getting a subprocess.CalledProcessError: Command '['cmake', '--build', '.', '--target', '_moe_C', '-j', '64']' returned non-zero exit status 2.
And I think unix return status 2 means invalid shell command.
One way of getting a better understanding would be to run that command in the terminal directly to see why it's invalid.

The result of cmake --build . --target _moe_C -j 64 was
Error: could not load cache
@ErikKaum

hmm, seems still like a cmake error: https://stackoverflow.com/questions/16319292/cmake-error-could-not-load-cache
btw, do you specifically need to build TGI form source? In general, if you want to run it using the dockerized verison is easier to get going.

Actually I am running the whole thing in a GPU docker. So I think running a docker inside a docker may have some conflicts. @ErikKaum

Yeah that for sure doesn't make things easier!


Change shading prefix so as to minimize conflicts with other libaries

Low hanging fruit
We currently use the prefix shaded to relocate our dependencies. e.g. org.apache.commons to shaded.org.apache.commons
This prefix however is quite commonly used among various other third party libaries (since it is used by default in most examples on Stackoverflow)
The PR changes the prefix to org.apache.pinot.shaded to better reflect the package which uses these dependencies as well as avoid any accidental conflicts.

Codecov Report

Merging #8602 (9523978) into master (05a7f28) will decrease coverage by 3.82%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8602      +/-   ##
============================================
- Coverage     70.77%   66.94%   -3.83%
+ Complexity     4290     4237      -53
============================================
  Files          1681     1281     -400
  Lines         87957    64558   -23399
  Branches      13320    10127    -3193
============================================
- Hits          62252    43219   -19033
+ Misses        21354    18234    -3120
+ Partials       4351     3105    -1246

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
66.94% <ø> (-0.08%)
:arrow_down:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a7f28...9523978. Read the comment docs.

Will this remain backward compatible? A recent discussion in slack made me think about this one: https://apache-pinot.slack.com/archives/CDRCA57FC/p1651496807383319

@npawar After merging this change, the code will fail at compile stage if the newer release is cut, since there is no more import paths like shaded.org.apache.pinot.*. We can mark this PR to be backward incompatible.

@jackjlli @npawar Yep, it will be backward-incompatible which is why I haven't merged it yet.

@jackjlli IMO, the only place it will cause an issue is while importing the Kafka classes. Anywhere else, it should work fine the way it is. In our code at least we don't import anything with shaded. prefix.


chore(deps): upgrade axios

Related Ticket(s)
#8786
Description
Upgrade axios to latest version
Changelog
Changed

upgrade axios to latest

LGTM! Should we also update in the utilities package? https://github.com/carbon-design-system/carbon-for-ibm-dotcom/blob/3dda922731680e878ae116054bbe3303689c77ff/packages/utilities/package.json#L52

LGTM! Should we also update in the utilities package?

Doh, good catch!

Digging into the yarn.lock file,

@jeffchew Yep, good catch! Upgraded to latest, but the sub-dependency is only on 0.25, but at least the very old version we were using will go away.


Changes to fix issue that prevents enabling/disabling of HBase features

The changes in this PR helps to conditionally enable/disable HBase features using a wrapper cookbook. Refer issue #580 for details.

Looks good


Fix apparent race condition with conforms type lookup

A report has been received of some thermometer tests failing at the
point of writing metadata to sinks, with the following runtime exception:
scala.ScalaReflectionException: <none> is not a class
  at scala.reflect.api.Symbols.asClass(Symbols.scala:275)
  at scala.reflect.internal.Symbols.asClass(Symbols.scala:84)
  at commbank.coppersmith.Feature$.getClazz(Feature.scala:172)

The error is intermittent, though there appears to be a correlation
with the number of records processed. Moving the Conforms type Class
lookup to the object constructor fixes the issue in an otherwise
reproducable failure case.
Also part of this change is adding missing conforms instances to
allConforms (and reformatting to make it a little more obvious in the
future), and bringing maestro dependency up to date.

Note that the Conforms type Class lookup fix was tested independently of the maestro upgrade.

:+1:
OK let's just hope this is the first and last time we run into such a weird bug. I don't see any problem with the original code itself, so (unless there are some obscure rules about using scala reflection of which I am unaware) this might be a compiler bug. Anybody think they could craft a minimal scala program that reproduces this failure?

Anybody think they could craft a minimal scala program that reproduces this failure?

Inspired by this comment, I had a go at porting over the generally reproducable test code (and its dependent internal library code) over from the internal project. I succeeded in reproducing the failure within the coppersmith codebase, and in the process of paring it back, I've made the following further observations:

When running in a single sbt session, only the first test run will fail; subsequent runs will progress
The problem only manifests itself when running two feature set executions in parallel - if I remove one of the feature sets, or run them sequentially, I cannot reproduce the problem

Due to the first point, paring the internal code back has been a slow process. Based on the second point, I'm also trying to reproduce the behaviour via the ScaldingJobSpec.multiFeatureSetJobPar test, but have been unsuccessful so far.
In undergoing this process, I am confident that the fix in this PR addresses the underlying problem. This is reinforced by the observation that when using the old code, but having the new eagerly initialised typeTagClass member just present in the code, also appears to address the problem (even though the member isn't actually used).
As such, I'm hesitant to spend much more time trying to get a minimal test case that consistently exhibits this failure. I can't imagine any risk that the code would change in such a way that such a test would pick up the regression, however, I will add comments to the changed code prior to merging as a precautionary measure.

@dkristian I also had the same impression, that the revised code is sensible at face value and unlikely to be intentionally reverted.
My interest in a minimal and/or reproducible test case was that it could aid in submitting a scala compiler bug report. Have you pushed your work somewhere? I'd love to try it with a few other scalac versions, for a start.


Inline drawing in Markdown file

Hi, is it possible to create such a drawing and embed it into a markdown note?

Not yet, I'm working on this atm.

I've made a pull request that implements, this feature. See more info here https://github.com/holxsam/tldraw-in-obsidian/pull/22#issuecomment-2154213634

@jon-dez, I saw your pull request and it looks great! I was wondering if you could add the feature to automatically export to PNG/JPG with the addition for light and darkmode? Excalidraw also has implemented this feature, so it'd be great if you could do the same!

@fugohan, If you don't mind creating a new issue detailing the specifics of the feature I will take a look at it when I have free time. Also include some screenshots and/or a screen recording if applicable.

Merged jon's PR and released the update: https://github.com/holxsam/tldraw-in-obsidian/releases/tag/1.0.6


[ONNX] Enable transposed convolution

CI is failing:
/ngraph/src/ngraph/frontend/onnx_import/op/conv_transpose.cpp:136:34: error: unused variable 'new_shape' [-Werror,-Wunused-variable]
                    const Shape& new_shape = conv_node->get_shape();
                                 ^


Integrations app user service

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@71e9b82). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff            @@
##             master      #94   +/-   ##
=========================================
  Coverage          ?   97.46%
=========================================
  Files             ?      112
  Lines             ?     1499
  Branches          ?      183
=========================================
  Hits              ?     1461
  Misses            ?       24
  Partials          ?       14


Added support for Kotest tests

Addresses #123

Added Kotest framework to project
Rewritten all tests in ktoml-file and ktoml-source modules
Rewritten a few tests in ktoml-core module
Sometimes making minor improvements in tests, like migrating away from TomlTable.fullTableName method or removing unused classes

Hope that you would like the way tests look now, and accept my humble contribution :)

Hey, thank you, you are awesome, we had big discussions about kotest https://github.com/akuleshov7/ktoml/issues/123

One more thing: I did this PR because I'm participating in the Hacktoberfest. I would be grateful if you add "hacktoberfest-accepted" label to this PR to make it count. But if for any reason you don't want to do it, I'm also ok with it 👍

One more thing: I did this PR because I'm participating in the Hacktoberfest. I would be grateful if you add "hacktoberfest-accepted" label to this PR to make it count. But if for any reason you don't want to do it, I'm also ok with it 👍

Added, am I right?

Added, am I right?

Yes, thank you!

Any update on this PR? Do you need anything more from me?


Command jsx threebot-test doesn't work

Starting threebot server times out on starting
It requires phonebook actor to init the threebot identity

PR at: https://github.com/threefoldtech/jumpscaleX_core/pull/223

I got this error.

am still facing this error while testing
3BOTDEVEL:jsx:~: jsx threebot-test -d -w -p

Sun 17 10:06:50 GedisClient.py       - 118 - gedisclient_explorer               : load schema: actors.default.html_test.hello.537cc19efef1a82cef8751bd84c39d82
Sun 17 10:06:50 GedisClient.py       - 121 - gedisclient_explorer               : cmds for actor:html_test
Sun 17 10:06:50 GedisClient.py       - 121 - gedisclient_explorer               : cmds for actor:myjobs
Sun 17 10:06:50 /ThreebotExplorer.py -  36 - threebot_record_get                : EXCEPTION:
    AttributeError("'GedisClientActors' object has no attribute 'phonebook'",)
--TRACEBACK------------------
/tmp/3bot.py in <module>
    19    configure()
/tmp/3bot.py in configure
    9    j.tools.threebot.init_my_threebot(name="3bot.3bot", interactive=False)
/sandbox/lib/jumpscale/Jumpscale/tools/threebot/ThreebotToolsFactory.py in init_my_threebot
    43    r = j.tools.threebot.explorer.threebot_record_get(name=name, die=False)
/sandbox/lib/jumpscale/Jumpscale/tools/threebot/ThreebotExplorer.py in threebot_record_get
    36    r = self.actors.phonebook.get(tid=tid, name=name, die=die)
-----------------------------

Sun 17 10:06:51 BCDB.py              - 340 - bcdb                               : DATAPROCESSOR & SQLITE STOPPED OK
Connection to localhost closed.
Sun 17 10:06:51 tall/InstallTools.py -2265 - execute                            : EXCEPTION:
    Could not execute:bash /tmp/jumpscale/scripts/15096.sh
--TRACEBACK------------------
/sandbox/bin/jsx in <module>
    891    cli()
/sandbox/bin/jsx in threebot_test
    732    docker.jsxexec(configure, explorer_addr=explorer_addr, docker_name=docker.name)
/sandbox/code/github/threefoldtech/jumpscaleX_core/install/InstallTools.py in jsxexec
    4952    self.sshexec(cmd, asfile=True)
/sandbox/code/github/threefoldtech/jumpscaleX_core/install/InstallTools.py in sshexec
    4933    cmd2, interactive=True, showout=False, replace=False, asfile=asfile, timeout=3600 * 2, retry=retry
/sandbox/code/github/threefoldtech/jumpscaleX_core/install/InstallTools.py in execute
    2250    original_command=command,
/sandbox/code/github/threefoldtech/jumpscaleX_core/install/InstallTools.py in execute
    2265    raise Tools.exceptions.Base("Could not execute:%s" % command)
-----------------------------

jsx version

3BOTDEVEL:jsx:jumpscaleX_threebot: git log -1
commit 2bb097589a45ac80e8aa4c3bceb614a909a59cbb (HEAD -> development, origin/development, origin/HEAD)
Author: Christophe de Carvalho<EMAIL_ADDRESS>Date:   Fri Nov 15 17:54:27 2019 +0100

    directory: add node id v1 to node model
3BOTDEVEL:jsx:jumpscaleX_threebot:

fixed at commit: https://github.com/threefoldtech/jumpscaleX_core/commit/70ee7a12c27217b375f2c37ba11d617c90c8f072

jsx threebot-test
jsx threebot-test -d -w -p
Both commands have been executed on a  digital ocean vm and both worked fine


PhpdocLineSpanFixer - do not crash on trait imports

closes https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/6036

Coverage increased (+0.0007%) to 92.778% when pulling d60ff679f7870d9ef832a0827de4b77013b9e219 on SpacePossum:master_/PhpdocLineSpanFixer_6063_1 into c1a4a9103c384b05bfac3d47730c0895577c087d on FriendsOfPHP:master.


Colorit library name

On Ubuntu 20.04 with python3.8, the colorit library is installed by pip install color-it instead of colorit.

Thanks!
Solved in 6fcb2aecc44381b85f5ceab1d2e794cff29ee3da
Now README.md shows how to install each package.


Qingwei/charts fetching

Coverage decreased (-0.6%) to 35.863% when pulling fa820e43ed1737b6b3b220433ad6a1be469a1565 on qingweibinary:qingwei/charts-fetching into 141a4dbfc1250162f44fa9920de2d2c5821ec1ef on binary-com:master.

Coverage decreased (-0.6%) to 35.863% when pulling 9fabb598d463f35208137697fe89e463a1437fe6 on qingweibinary:qingwei/charts-fetching into 141a4dbfc1250162f44fa9920de2d2c5821ec1ef on binary-com:master.


MQTT Discovery: Light objects should report supported_color_modes

Checklist

[x]  I am not using Home Assistant. Or: a developer has told me to come here.
[x] I have checked the troubleshooting section and my problem is not described there.
[x] I have read the changelog and my problem is not mentioned there.

Deploy method
Manually built (git clone - npm run build - npm install
Z-Wave JS UI version
9.18.1
ZwaveJS version
13.3.0
Describe the bug
Light objects are advertised for MQTT AutoDiscovery using an out-of-date method.
The documentation at https://developers.home-assistant.io/docs/core/entity/light/ says that all lights should report supported_color_modes, including those which only support ColorMode.BRIGHTNESS or ColorMode.ONOFF.
To Reproduce
Use a Z-Wave light/dimmer device, and see the contents of its discovery topic.
Expected behavior
I expected to see
  supported_color_modes: ["brightness"],

or
  supported_color_modes: ["onoff"],

in the device configuration object.
Additional context
No response

@dwmw2 Prepared a fix on #3895

That was fast. Thanks!


How can i get my rtsp channel 2 with jetson

Hi , thanks for your project.
Now I want to pull the rtsp://<...>:port/Streaming/Channels/2 , it failed.  Channels/1 in ok
How can i pull channel 2 ?
(channel2 is lower quality in stream and faster during stream decode)

can't even run it with one!

can't even run it with one!

Can you post the terminal log from the console that you get?
If it says it can't detect the codec, you can use --input-codec to specify it manually.

Can you post the terminal log from the console that you get?
If it says it can't detect the codec, you can use --input-codec to specify it manually.

Can you post the terminal log from the console that you get?
If it says it can't detect the codec, you can use --input-codec to specify it manually.

like this:
[OpenGL] glDisplay -- X screen 0 resolution:  1920x1080
[OpenGL] glDisplay -- X window resolution:    1920x1080
[OpenGL] glDisplay -- display device initialized (1920x1080)
[video]  created glDisplay from display://0
glDisplay video options:
-- URI: display://0
- protocol:  display
- location:  0
-- deviceType: display
-- ioType:     output
-- codec:      raw
-- width:      1920
-- height:     1080
-- frameRate:  0.000000
-- bitRate:    0
-- numBuffers: 4
-- zeroCopy:   true
-- flipMethod: none
-- loop:       0
[gstreamer] initialized gstreamer, version <IP_ADDRESS>
[gstreamer] gstDecoder -- creating decoder for<EMAIL_ADDRESS>[gstreamer] gstDecoder -- failed to discover stream info
[gstreamer] gstDecoder -- try manually setting the codec with the --input-codec option
[gstreamer] gstDecoder -- failed to create decoder for rtsp://admin:lettin20@<IP_ADDRESS>:554/Streaming/Channels/2
Traceback (most recent call last):
File "zrm_demo0.py", line 38, in
vs = VideoCaptureAsync('rtsp://admin:lettin20@<IP_ADDRESS>:554/Streaming/Channels/2')
File "zrm_demo0.py", line 9, in init
self.cap = jetson.utils.videoSource(src)
Exception: jetson.utils -- failed to create videoSource device

Can you post the terminal log from the console that you get?
If it says it can't detect the codec, you can use --input-codec to specify it manually.

like this:
[OpenGL] glDisplay -- X screen 0 resolution:  1920x1080
[OpenGL] glDisplay -- X window resolution:    1920x1080
[OpenGL] glDisplay -- display device initialized (1920x1080)
[video]  created glDisplay from display://0
glDisplay video options:
-- URI: display://0
- protocol:  display
- location:  0
-- deviceType: display
-- ioType:     output
-- codec:      raw
-- width:      1920
-- height:     1080
-- frameRate:  0.000000
-- bitRate:    0
-- numBuffers: 4
-- zeroCopy:   true
-- flipMethod: none
-- loop:       0
[gstreamer] initialized gstreamer, version <IP_ADDRESS>
[gstreamer] gstDecoder -- creating decoder for<EMAIL_ADDRESS>[gstreamer] gstDecoder -- failed to discover stream info
[gstreamer] gstDecoder -- try manually setting the codec with the --input-codec option
[gstreamer] gstDecoder -- failed to create decoder for rtsp://admin:lettin20@<IP_ADDRESS>:554/Streaming/Channels/2
Traceback (most recent call last):
File "zrm_demo0.py", line 38, in
vs = VideoCaptureAsync('rtsp://admin:lettin20@<IP_ADDRESS>:554/Streaming/Channels/2')
File "zrm_demo0.py", line 9, in init
self.cap = jetson.utils.videoSource(src)
Exception: jetson.utils -- failed to create videoSource device

What happens if you set the --input-codec=h264 option (or change to other codec if your stream is using a different codec)
--input-codec=CODEC    RTP requires the codec to be set, one of these:
                             * h264, h265
                             * vp8, vp9
                             * mpeg2, mpeg4
                             * mjpeg

What happens if you set the --input-codec=h264 option (or change to other codec if your stream is using a different codec)
--input-codec=CODEC    RTP requires the codec to be set, one of these:
                             * h264, h265
                             * vp8, vp9
                             * mpeg2, mpeg4
                             * mjpeg

i tried every one , all is failed to create decoder for channel2, but opencv and deepstream is all ok.

i tried every one , all is failed to create decoder for channel2, but opencv and deepstream is all ok.

and today  I meet a So strange issue:
import jetson.utils
import jetson.inference
import argparse
import sys

inp = jetson.utils.videoSource('rtsp://admin:lettin20@<IP_ADDRESS>:554/Streaming/Channels/1')
outp = jetson.utils.videoOutput()

while True:
    image = inp.Capture()
    outp.Render(image)

when above codes runs , no output come out , and output video comes out  if I delete "import jetson.inferense"  like following:
import jetson.utils
import argparse
import sys

inp = jetson.utils.videoSource('rtsp://admin:lettin20@<IP_ADDRESS>:554/Streaming/Channels/1')
outp = jetson.utils.videoOutput()

while True:
    image = inp.Capture()
    outp.Render(image)

and today  I meet a So strange issue:
import jetson.utils
import jetson.inference
import argparse
import sys

inp = jetson.utils.videoSource('rtsp://admin:lettin20@<IP_ADDRESS>:554/Streaming/Channels/1')
outp = jetson.utils.videoOutput()

while True:
    image = inp.Capture()
    outp.Render(image)

when above codes runs , no output come out , and output video comes out  if I delete "import jetson.inferense"  like following:
import jetson.utils
import argparse
import sys

inp = jetson.utils.videoSource('rtsp://admin:lettin20@<IP_ADDRESS>:554/Streaming/Channels/1')
outp = jetson.utils.videoOutput()

while True:
    image = inp.Capture()
    outp.Render(image)

this strange issue solved by change the inp oup order:
import jetson.utils
import jetson.inference
import argparse
import sys

outp = jetson.utils.videoOutput()
inp = jetson.utils.videoSource('rtsp://admin:lettin20@<IP_ADDRESS>:554/Streaming/Channels/1')

while True:
    image = inp.Capture()
    outp.Render(image)

but I'm currious about the reason

this strange issue solved by change the inp oup order:
import jetson.utils
import jetson.inference
import argparse
import sys

outp = jetson.utils.videoOutput()
inp = jetson.utils.videoSource('rtsp://admin:lettin20@<IP_ADDRESS>:554/Streaming/Channels/1')

while True:
    image = inp.Capture()
    outp.Render(image)

but I'm currious about the reason

@dusty-nv   hi , dusty,
for a period of time , I stiil can not find the way to pull my sub stream, can you tell me the reason or any method?


Increases default expires/max-age to 24h

Attempt to close #11. Also, changing default cache duration to 24h (instead of 12h).

This actually only augments the max age to 24h instead of 12h. Having 2 Cache-Control headers is not an actual issue.

My cache control header is there just in case somebody want to host it publicly.  Since the cache set to "public" / client-side.   It really doesn't matter to anyone who is hosting it behind a proxy like me.  I override that cache-control on my CDN anyway.  Approve merging per request.


Digitalocean TXT record disappears shortly after certificate creation when using it as a DNS challenge.

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
yes

Are you sure you're not using someone else's docker image?
yes

If having problems with Lets Encrypt, have you made absolutely sure your site is accessible from outside of your network?
yes

Describe the bug

A clear and concise description of what the bug is.
I have a domain I'm using for my home lab which is registered and NS records pointed to DigitalOcean. I only have NS zone records on this domain and I haven't used it for anything else. When setting up a new SSL certificate and using DO as my dns challenge, the whole process seems to work as intended; I can refresh my Network > domain and see my TXT record pointing to the _acme-challenge subdomain, however, if I refresh the page shortly after creation, the TXT record disappears. This results in an invalid certificate authority error NET::ERR_CERT_AUTHORITY_INVALID when attempting to use that certificate in NPM.

To get around this, I've refreshed the Network page on DO, copied the TXT value, then manually created the TXT records after it disappears with the value that was there before it vanished. When adding it manually the record stays and SSL works as intended.
Unsure if this is a bug within NPM or on DO's side.

What version of Nginx Proxy Manager is reported on the login page?
v2.7.2

To Reproduce
Steps to reproduce the behavior:

Go to SSL Certificates
Click Add SSL Certificate > Let's Encrypt
Type domain name, email, toggle Use a DNS Challenege
Set DNS Provider to DigitalOcean and enter the newly created API key for NPM in the Credentials File Content box below.
Open up DigitalOcean and go to Networking > MyAwesomeDomainName.com in a new tab/window.
Go back to the NPM window and toggle "I Agree to the Let's Encrypt Terms of Service" and click save.
Go back to the DigitalOcean tab/window and hit refresh while NPM is creating the certificate.
Notice the TXT record shows up, then after the certificate is created, another refresh of DigitalOcean will show that the TXT record is now missing.

Expected behavior
A clear and concise description of what you expected to happen.
The TXT record should persist.
Screenshots
If applicable, add screenshots to help explain your problem.
Operating System

Please specify if using a Rpi, Mac, orchestration tool or any other setups that might affect the reproduction of this error.
Ubuntu Server 20.04 inside of a VM on Proxmox.

Additional context
Add any other context about the problem here, docker version, browser version if applicable to the problem. Too much info is better than too little.
Nothing else to add.

It also appears that if I remove the certificate and attempt to recreate it, the TXT record never shows up in DigitalOcean. I tried a few more times and unfortunately I hit a rate limit error which will clear out after a week. There were too many requests of a given type :: Error creating new order :: too many certificates already issued for exact set of domains: [REDACTED]: see https://letsencrypt.org/docs/rate-limits/

It also appears that if I remove the certificate and attempt to recreate it, the TXT record never shows up in DigitalOcean. I tried a few more times and unfortunately I hit a rate limit error which will clear out after a week. There were too many requests of a given type :: Error creating new order :: too many certificates already issued for exact set of domains: [REDACTED]: see https://letsencrypt.org/docs/rate-limits/

I managed to figure out what my issue was. User error. I believe my issue was that I was enabling the HSTS option when I shouldn't have been. Also, it makes sense that the TXT record gets removed.

I managed to figure out what my issue was. User error. I believe my issue was that I was enabling the HSTS option when I shouldn't have been. Also, it makes sense that the TXT record gets removed.


converted nav log svg to functional component

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[ ] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

Removed eslint-disable as suggested


Feature request - Native Java API & Objective-C API access

Hi Ionic Team.
Would you please make it possible for us to access android's native java API & apple's objective-C api using simplified typescript command on Ionic 4?
That'll be much better than using old cordova plugins which no one manages anymore. To be honest, it feels so weird to contact people who made those plugins 5 years ago to ask about bug fixes......
Android's java API provides what those plugins provide:
https://developer.android.com/reference/packages.html
Actually, they have more to offer beyond what those old cordova plugins can do for us.
What if we can get access to them by using typescript on Ionic 4?
Java is a superior programming language for android overall but XML is nowhere close to HTML5 & CSS3 in terms of styling..
Please make this happen in Ionic 4.
Then Ionic app will be perfect.

Hello! Thank you for opening an issue with us!
I am going to close this as we already have plans in place along these lines: https://ionic-team.github.io/avocado/
Thank you for using Ionic

WOW! thanks a lot for that.
I wanted to move to NativeScript just because of limited Java API features I could use on Ionic...
If you guys remove all existing problems in Ionic 3, I'm with you guys.

slow loading time, overall chunky & slow speed of app when lots of things are done on Angular 5
bizarre loading screen problems which don't happen on other app frameworks. Gray loading screen can't be removed.
Java API, Objective-C API access not available. Google ships a plenty of android java APIs!
It relies on old cordova plugins which no one manages anymore. Users need to contact an unknown publisher who made those plugins 5 years ago. They have no idea about them at all...
bugs in Ionic UI components. I had to spent roughly 20+ hours on some issues which have nothing to do with actual programming problem of my own.
Modal component is really slow... it takes 2 seconds to show up when you have lots of things going on in Angular 5. I'm choosing to not use it in my project.

Is Avocado going to use Angular 5?
and will it integrate with Ionic 4?
Angular 5 still works well and it provides lots of convenience for mobile development.


Shoot a live demo

It would be great to shoot a small live demo of how the process of using msw looks like. It can be converted into a GIF later and put at the top of the README file.
The demo would consist of the following steps:

Installing the package.
Writing mocks.js
Running your app and demonstrating that the Mock Service Worker works.

@kettanaito What kind of program do you use for the demo if you want to record it? The react app or the vue app?
I tried to create a simple vue demo using codesandbox, but the service worker could not respond to the data. I think it was the domain name.
If it could be a demo like codesandbox, it would be a great start!

@hehehai the problem with sandboxes is that you cannot execute npx (or any other commands) in its environment. One of the prerequisites for working with MSW is to copy its mockServiceWorker.js to your public directory. Even when manually copied into a sandbox, I have doubts what you see as "public" is actually the public directory of the served app. We can try, however, I haven't attempted to upload the Service Worker manually, it may work.
I think in terms of shooting a demo you can use the examples/create-react-app in this repository. I'd probably rework the UI to be more, em, presentable :) But having a sandbox with the example is a nice start, I totally agree. Do you mind trying uploading the mockServiceWorker.js manually to the public folder of a sandbox?

@kettanaito codesandbox react msw example
Have you looked at this example?
I do not know why MSW does not capture and respond to information normally

@hehehai, thanks for sharing. I've had a brief look into that and can see that Service Worker failed to register. There are also infinite errors regarding an invalid RegExp, which may be related to the usage of :username parameter in the path. I've removed the parameter and trying to mock an exact URL. Will update this thread with the result.

I'm going to shoot a quick tutorial once the following pre-requisites are done:

#100
#107

The pre-requisites for this task are done, and I'm preparing a setup and script for an introductory tutorial. I see no reason for this ticket anymore. Will update the README once the tutorial is public.


add morse code background example

SOS. TEST. SOS. TEST.

nah, there's already one other demo that depends on 7.3.0 in the repo.