[openimageio] Configure failed when using openimageio

Operating system
All platform
Compiler
Not related to compiler
Steps to reproduce the behavior
1. ./vcpkg install openimageio[libraw]
2. Use openimageio in custom project.

Failure logs
CMake Error at D:/installed/x64-windows-static/share/openimageio/OpenImageIOTargets.cmake:71 (set_target_properties):
  The link interface of target "OpenImageIO::OpenImageIO" contains:

    lcms2::lcms2

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Additional context
I found this bug in my another PR https://github.com/microsoft/vcpkg/pull/38034.
The description is port lcms target lcms2::lcms2 was not found. And this issue can only be reproduced in static build.
After analyzing the dependency relationship, I found this is caused by openimageio's feature libraw, which depends on port libraw, which depends on port lcms.
After reading the generated OpenimageIOConfig.cmake / OpenimageIOTargets.cmake:

there is no find_package(lcms2 CONFIG) in the config.cmake file.
target lcms2::lcms2 was found in the Targets.cmake file:

set_target_properties(OpenImageIO::OpenImageIO PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "OIIO_STATIC_DEFINE=1"
  INTERFACE_COMPILE_FEATURES "cxx_std_14"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include;${VCPKG_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "OpenImageIO::OpenImageIO_Util;...\$<\$<NOT:\$<CONFIG:DEBUG>>:${VCPKG_IMPORT_PREFIX}/lib/libraw_r.a>;\$<\$<CONFIG:DEBUG>:${VCPKG_IMPORT_PREFIX}/debug/lib/libraw_r.a>;...;\$<LINK_ONLY:lcms2::lcms2>;..."
)

So I checked the libraw generated config / targets cmake files:
In librawConfig.cmake:
...
if(true)
    if(1)
        find_dependency(lcms2 CONFIG)
    elseif(false)
        find_dependency(LCMS)
    endif()
endif()
...

In librawTargets.cmake:
# Create imported target libraw::raw
add_library(libraw::raw STATIC IMPORTED)

set_target_properties(libraw::raw PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "LIBRAW_NODLL"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include/libraw"
  INTERFACE_LINK_LIBRARIES "m;lcms2::lcms2;..."
)

# Create imported target libraw::raw_r
add_library(libraw::raw_r STATIC IMPORTED)

set_target_properties(libraw::raw_r PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "LIBRAW_NODLL"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include/libraw"
  INTERFACE_LINK_LIBRARIES "m;lcms2::lcms2;..."
)

That's weird. We expected libraw find lcms2 first, then pass the found targets lcms2::lcms2 to openimageio's targets.cmake, which not executed.
So I consider there have some issues in this.
Edit:
In src/raw.imageio/CMakeLists.txt:
    add_oiio_plugin (rawinput.cpp
                     INCLUDE_DIRS ${LibRaw_INCLUDE_DIR}
                     LINK_LIBRARIES ${LibRaw_r_LIBRARIES}
                     DEFINITIONS "-DUSE_LIBRAW=1" ${LibRaw_r_DEFINITIONS})

And in config-TRIPLET-out.log:
-- Found LibRaw 0.21.2
--     LibRaw_INCLUDE_DIR = J:/vcpkg_commit/vcpkg/installed/x64-windows-static/include/libraw
--     LibRaw_LIBRARIES = optimized;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/lib/manual-link/raw.lib;debug;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/debug/lib/manual-link/rawd.lib;optimized;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/lib/jasper.lib;debug;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/debug/lib/jasperd.lib;optimized;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/lib/jpeg.lib;debug;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/debug/lib/jpeg.lib;lcms2::lcms2;optimized;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/lib/zlib.lib;debug;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/debug/lib/zlibd.lib
--     LibRaw_r_LIBRARIES = optimized;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/lib/raw_r.lib;debug;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/debug/lib/raw_rd.lib;optimized;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/lib/jasper.lib;debug;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/debug/lib/jasperd.lib;optimized;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/lib/jpeg.lib;debug;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/debug/lib/jpeg.lib;lcms2::lcms2;optimized;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/lib/zlib.lib;debug;J:/vcpkg_commit/vcpkg/installed/x64-windows-static/debug/lib/zlibd.lib

However, libraw's usage should be
    find_package(libraw CONFIG REQUIRED)
    # non-thread-safe
    target_link_libraries(main PRIVATE libraw::raw)
    # thread-safe
    target_link_libraries(main PRIVATE libraw::raw_r)

So I think this is why the issue happened.
Trying to use config mode instead.

Hope I can get more details later with debugger that which targets are injected into target `OpenImageIO.

Ok confirmed the problme is caused by using findLibRaw.cmake, will create PR to fix this later.


Text selecting support using mouse

Unless you're using tmux (or some terminal multiplexer) copying text to the clipboard it's hard, this is mainly because you can't select text using the mouse.
This would be a nice to have feature.

I can take a stab at this

Unfortunately, it seems like a limitation of gocui

@sponomarev does termbox provides that?

@gchaincl I don't think so. I guess it's a limitation of mouse handling in the terminal. I've checked the most popular terminal product with mouse support - midnight commander. It uses ncurses which is much more advanced than their competitors and even it doesn't support text selection with mouse.
I want to underline that it's just a guess. I'm not an expert in terminal questions.

Thanks for investigate into it, I'll let this open until someone else confirms

Usually, you can select text in terminal apps like midnight Commander while holding the shift key. This works just fine for me with httplab too!

Oh I didn't knew that. @dnguy078 are u still working on this? Otherwise I'll close it

Looks like there's nothing we can do to fix it, so I'm closing this


[zh] Update link for "AMD GPU device plugin" in "Devices Plugins" page

en PR https://github.com/kubernetes/website/pull/45296/files

/approve


Vickel: Watch +17542156033

Vickel requests the watch of the watch_number +17542156033. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Makyen in Charcoal HQ


Crash on opening inventory

My client crashed when I pressed E to open my inventory.
Here is the console log from after the crash.
http://pastebin.com/rZNWaxex

May be a dupe of https://github.com/TheCBProject/NotEnoughItems/issues/7
In which case https://github.com/TheCBProject/NotEnoughItems/issues/7 was closed before the issue was fixed.

It needs updating to 1.10.2 I think

if that's the case, then NEI is an exception to needing updating to 1.10.2
As most 1.9.4 mods work straighting out of the box in 1.10.x, albeit sometimes with a very (very) minor issue.

Nei will not load on any 1.10 version. I will support 1.10 after btm.


adamround bugfix, refine import

By the way, check why the unit test didn't catch the issue and add a new test to cover it.


support regexp separators and automatically handle windows/unix/mac properly by default

This change makes the default separator /\r\n?|\n/, so that it automatically handles windows, mac, or unix files properly.  It still supports string separators as well.  If the regexp match is at the very end of the string, it will try to read more so in case there is a longer match.
I added tests for windows, mac, and unix files, and also a test where the buffer boundary falls in the middle of an \r\n (it should still parse as a single line break with the default settings).
This also fixes https://github.com/nickewing/line-reader/issues/24 by adding this check to the beginning of getLine():
    function nextLine(cb) {
      function getLine() {
        if (separatorIndex < 0 && eof) {
          separatorIndex = bufferStr.length;
        }

Cheers!
Andy

Hi @jedwards1211,
This change looks great.  Thank you for taking the time to fix this issue!

No problem!  I may try to fix some others in the future, depending on if I have time.
I adapted the code into a synchronous line reader for my own use...would you be interested in incorporating that into this project?

Sure, it would be great to have that as an option as long as the current functionality is preserved as well.

Right, it would be a separate thing


Done a general layout for client side #25

#25

@hoangdangninh can you resolve that merge conflict please, just shove that form and the javascript code into your new index.html anywhere. We can clean it up later on


[WIP] Constraints

Adding field value constraints to JSTTypes.
Relates to #25.

Closing in favour of the develop branch.


Reordering README and fixing typo

:+1:

Coverage remained the same at 84.37% when pulling 3be3b17fde040802be9673f94af31a124e91eb22 on steph-test into b57d229944590dc6635364d1640da9b77ec07f18 on master.


Parser for circular dependency in OpenAPI

fix: for https://github.com/Tufin/oasdiff/issues/163
Verification

Download api with 2 circular dependencies

wget https://gist.githubusercontent.com/wtrocki/2e272375386ddecff69d6228c89d2a05/raw/09c332bdb9edc728054e765f2c75340e2661b55a/scheduler-openapi.yaml

build binary

go build main.go

Run binary with new argument

main -base scheduler-openapi.yaml -revision scheduler-openapi.yaml -max-circular-dep=5

Run binary without new argument

main -base scheduler-openapi.yaml -revision scheduler-openapi.yaml -max-circular-dep=2

failed to load base spec from "scheduler-openapi.yaml" with kin-openapi bug found: circular schema reference not handled - #/components/schemas/OnlineArchiveScheduleView -> #/components/schemas/DefaultScheduleView -> #/components/schemas/OnlineArchiveScheduleView -> #/components/schemas/DailyScheduleView -> #/components/schemas/OnlineArchiveScheduleView

CC @reuvenharrison Small fix that resolves some design flaw in the underlying go parser that prevents multiple circular dependencies. Other parsers handle that without limits. I think overall it will be good to be able to override that value in oas-diff as fixing it on parser would require much more work.

Codecov Report

Merging #164 (0a0d42d) into main (83802c9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   89.48%   89.48%
=======================================
  Files          71       71
  Lines        4174     4174
=======================================
  Hits         3735     3735
  Misses        311      311
  Partials      128      128

Flag
Coverage Δ

unittests
89.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[SPARK-7584] [MLLIB] User guide for VectorAssembler

This PR adds a section in the user guide for VectorAssembler with code examples in Python/Java/Scala. It also adds a unit test in Java.
@jkbradley

Merged build triggered.

Merged build started.

Test build #33913 has started for   PR 6556 at commit 0cd47f3.

Merged build triggered.

Merged build started.

Test build #33915 has started for   PR 6556 at commit 11313f6.

@mengxr  I don't see any problems, so LGTM.  One comment: Should the Java unit test be identical (or as close as possible) to the example, to help test it?
Caveat: I read but did not generate the docs.

The Java unit test is the same as the Scala unit test, but the example code in the user guide is different. I thought about this difference. One reason is that the unit test is for API coverage while the example code is for hands-on. So it would be too much if we show, e.g., both sparse vectors and dense vectors in the example code. But it would be nice to have some level of similarity.

Test build #33913 has finished for   PR 6556 at commit 0cd47f3.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class JavaVectorAssemblerSuite

Merged build finished. Test PASSed.

Test build #33915 has finished for   PR 6556 at commit 11313f6.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class JavaVectorAssemblerSuite

Merged build finished. Test PASSed.

@mengxr Oh OK that makes sense.  LGTM

Merged into master and branch-1.4.


Translate storage/persistent-volumes.md in Korean

This is a Feature Request

What would you like to be added

Translate concepts/storage/persistent-volumes.md in Korean.
Why is this needed
There is no documents with concepts/storage/persistent-volumes.md in Korean.
Comments

https://kubernetes.io/docs/concepts/storage/persistent-volumes/

/language ko
/assign


Fixes for api breaking changes

Coverage decreased (-0.009%) to 71.727% when pulling 4cf8ff47c67464697211028c85351271a573f3ea on eatonphil:fixes-for-api-breaking-changes into 327b412be8a7a66f4782e4fb39cee58ea1b89159 on linode:master.


chore(scripts): remove openapitools.json

🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
most of the logic now lives in the generator or the clients.config.json, we can remove the openapitools.json config file in order to only keep the on the fly one

the file is also referenced in scripts/ci/githubActions/utils.ts btw

scripts/ci/githubActions/utils.ts

good catch! fixed in https://github.com/algolia/api-clients-automation/pull/2481/commits/e0926c6665d078c4a5d06de59437a964c28dbdc4


When does "onRead" callback call?

I use BLECharacteristicCallbacks class for writing and reading characteristics.
I thought that onReadcallback calls before the actual reading moment, so you can set BLE value in this step, but it seems that onRead calls after actual reading. That thing prevents me to bind my model and characteristics.
Am i understand this thing well, and can you suggest us some of best practice for binding model and ble?

Hi I am new on BLE, but in my little experience, the onRead and the onWrite are events fired when You try to read and write the characteristics.
I do this in my project:
1 the client write the characteristic on the server "Hey, somenthing new?"
2 the onWrite in the server is fired, if  there is something new the server write the new value in the characterisic
3 after some milliseconds the client read the characteristics and have the new value.

I see. I forgot to explain what i want to achieve.
I have a model, that contains some value (just a class with data). And also there is a BLE value, that actually should present the model data. I can copy my model's data to BLE stack in loop for example, but i think it is not a food way. It would be more convenient to bind it somehow. And onWrite onRead can make this binding.
Advantages:
Async binding, BLE just calls 'onWrite' 'onRead' and our model become updated "automatically"
Disadvantages:
???
Maybe it's convinent only for my purposes? I would like to know your opinion.

@MikhailNatalenko You are correct, it was my mistake and onRead callback should be called before sending response. Here is code that needs to be changed to fix it in arduino and which seems to be fixed in this repo:
https://github.com/nkolban/ESP32_BLE_Arduino/blob/master/src/BLECharacteristic.cpp#L385-L407
https://github.com/nkolban/esp32-snippets/blob/master/cpp_utils/BLECharacteristic.cpp#L389-L414

@chegewara  Oh. nice to hear it.
Should i make a pull request? I'm working on a project with remote CI, it compiles firmware for me with standart libraries (platformio), so i can't solve this problem with haks.
Maybe i can help you to fix this bug ASAP

@chegewara I'm sorry, when this bugfix will appear in arduino repo? I really need that fix

Hi @MikhailNatalenko
sorry, but i dont maintain any longer BLE library.

fwiw, as of today, on 1.0.4 of the arduino-esp32 BSP, this seems to behave as one would expect. Before returning data to the client (i.e. phone) the onRead callback provides an opportunity for the firmware to modify the value of the characteristic (i.e. call pCharacteristc->setValue...) and that is what the client will receive.


Important: This repo is no longer maintained

Just wanted to let everybody know why none of the issues have been solved/closed.
We no longer have write access to this repo since the owner company revoked our access rights to this repo in 2014 and missed the opportunity to transfer ownership since then.
So take the repo as it is, but don't expect any fixes/updates here.

Thanks @pke. I find this behavior to be extremely shameful and wish this repo could be transferred to a responsible individual or organization. I hope someone in https://github.com/orgs/doo/people can help get this resolved!

They are still unwilling to transfer the repo or even merge #146 to notify people of the maintained repo. This all despite the fact this repo has no connection to anything in their line of products or IP and is for a development OS/model no one really uses anymore (except maybe UWP apps).
But the boards decision is final I was told.
We can be lucky we got it published under MIT back in the days in the first place.


HMR and React with Mix

Laravel Mix Version: 1.4.5 (npm list --depth=0)
Node Version (node -v): 7.3.0
NPM Version (npm -v): 3.10.10
OS: Windows 10

Description:
Hi, I'm trying to run Hot reloading for my react assets for a long time but without any success. I was trying many configurations from GH and nothing works. Could you help / share your config and tell what exactly should I do for enable it.
My webpack.mix.js:
mix.webpackConfig({
    devtool: "source-map", devServer: {
        contentBase: path.resolve(__dirname, 'public'),
    },
    module: {
        loaders: [{
            test: /\.js$/,
            loaders: ['react-hot-loader/webpack', 'babel'],
        }]
    },
    entry: {
        'app': [
            'babel-polyfill',
            'react-hot-loader/patch',
            './resources/assets/js/app'
        ]
    }
});

mix.react('resources/assets/js/app.js', 'public/js').sourceMaps(true);
mix.sass('resources/assets/sass/app.scss', 'public/css').sourceMaps(true);

.babelrc:
{
  "plugins": ["transform-decorators-legacy", "transform-class-properties", "transform-object-rest-spread", "react-hot-loader/babel"]
}

my app.js:
import 'react-hot-loader/patch';
import React from 'react'
import ReactDOM from 'react-dom'
import {AppContainer} from 'react-hot-loader';
import App from './components/App'
import './styles/app.scss'

const MOUNT_NODE = document.getElementById('app');

ReactDOM.render(
    <AppContainer>
        <App/>
    </AppContainer>
    ,
    MOUNT_NODE
);
if (process.env.NODE_ENV === 'development' && module.hot) {
    module.hot.accept();
}

And hot script in package.json:
"hot": "cross-env NODE_ENV=development node_modules/webpack-dev-server/bin/webpack-dev-server.js --inline --hot --output-public-path=public/ --config=node_modules/laravel-mix/setup/webpack.config.js",

Generally hot script starts without errors, and it says that compiled successfully, I am on app.dev and js file is loaded from localhost:8080, but there are no any effect in browser, also there are nothing about HMR in console. Watching files with browserSync works well but it reloads full page, but I want to achieve hot reload.

Do you have any solutions for this issue ?

Anyone got it working yet ??

Any Updates ?

I've managed to got it working now

<EMAIL_ADDRESS><EMAIL_ADDRESS>
webpack.mix.js
mix.react('resources/assets/js/app.js', 'js')
    .sass('resources/assets/sass/app.scss', 'css');

mix.webpackConfig({
    output: {
        publicPath: 'http://localhost:8080/',
    },
    devServer: {
        hot: true, // this enables hot reload
        inline: true, // use inline method for hmr
        contentBase: path.join(__dirname, 'public'),
        port: 8080,
        headers: { 'Access-Control-Allow-Origin': '*' },
        watchOptions: {
            exclude: [/bower_components/, /node_modules/]
        },
    },
    node: {
        fs: 'empty',
        module: 'empty',
    },
    plugins: [
        new webpack.SourceMapDevToolPlugin({
            filename: '[name].js.map',
        }),
    ],
});
// Per this issue: https://github.com/JeffreyWay/laravel-mix/issues/1483
Mix.listen('configReady', (webpackConfig) => {
    if (Mix.isUsing('hmr')) {
        // Remove leading '/' from entry keys
        webpackConfig.entry = Object.keys(webpackConfig.entry).reduce(
            (entries, entry) => {
                entries[entry.replace(/^\//, '')] = webpackConfig.entry[entry];
                // }
                // console.log(entries);
                return entries;
            },
            {}
        );
        // Remove leading '/' from ExtractTextPlugin instances
        webpackConfig.plugins.forEach((plugin) => {
            if (plugin.constructor.name === "ExtractTextPlugin") {
                // console.log(plugin.filename);
                plugin.filename = plugin.filename.replace(/^\//, '');
                // console.log(plugin.filename);
            }
        });
    }

    console.log(webpackConfig.output);
});

.babelrc
{
    "presets": [
        "react",
        "env"
    ],
    "plugins": [
        "react-hot-loader/babel",
        "transform-class-properties"
    ]
}

npm scripts
"scripts": {
    ...
    "hot": "cross-env NODE_ENV=development webpack-dev-server --progress --colors --hot --config=node_modules/laravel-mix/setup/webpack.config.js",
    ...
  },

Happy hot reload everyone !!

Try this Hot Reload method:

Open webpack.mix.js and add at the bottom:
mix.browserSync('localhost:8000');

The parameter inside depend on your php artisan serve url and port.

Run npm run watch to install dependency needed for browserSync method.
Run php artisan serve and npm run watch (on different cmd)

Hope this help.
source<EMAIL_ADDRESS>

mix.react('resources/js/app.js', 'public/js')
    .sass('resources/sass/app.scss', 'public/css')
    .browserSync({
    proxy: 'http://<IP_ADDRESS>:8000',
    files: [
        'resources/js/**/*.js'
    ]
});

I think this is how michael-harley suggested. it works but there is a problem, when using react router when url changes and u make changes in the js file page reloads and then laravel takes u to 404 page as the new route is not defined in web.php which is the normal behavior , any work around for this ?

@michael-harley
Its Live reloading not hot reloading

In my laravel project it working now
Package use:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
and my mix config
const mix = require('laravel-mix');

mix.ts('resources/ts/app.tsx', 'public/js')
    .postCss('resources/css/app.css', 'public/css', [
        require("tailwindcss"),
        require("autoprefixer"),
    ]);`

mix.babelConfig({
    presets: [
        [
            '@babel/preset-env',
            {
                modules: 'auto',
                targets: { node: 'current' }
            },
            '@babel/preset-react',
        ]
    ],
    plugins: [
        [
            'react-hot-loader/babel',
            '@babel/plugin-proposal-class-properties',
            {
                loose: true
            }
        ]
    ]
})

App.tsx
import React from 'react';
import {Redirect, Route, Router, Switch} from "react-router-dom";
import { history } from "../helper/history";
import { routes } from "../helper/routes";
import {CustomRoute} from '../components';
import { hot } from 'react-hot-loader/root';

const App = () => (
    <>
        <Router history={history}>
            <Switch>
                { routes.map((route, i) =>
                    <CustomRoute key={i} {...route} />
                ) }
                <Redirect from="*" to="/"/>
            </Switch>
        </Router>
    </>
)
export default hot(App);

Hope it helps.


Define high-level rpc interface for out-of-process signer

As discussed, we use a stateless protocol, either some rest/rpc type or fully asynchronous messages. (eg. send a push notification to a phone as request, get a message from long-polling a bridge server).
@webmaster128 can you link the presentation you made?
Also, look at https://docs.walletconnect.org/tech-spec for inspiration for connecting phone and desktop apps... It is ethereum-only, so I don't know if we can use any of the code, but at least look at the design for inspiration.
We need two main functionalities on the client side (beyond connecting)

Request the current active identity (only if the user gives permission in the signer)
Request the signer to sign a transaction (value name lookup, nonce lookup, and posting tx all occur in the signer. user must verify in the signer ui)

This replaces #397 although you can look there for some ideas as well.
Also, please take a look at #305 for some more half-finished ideas.

Some basic ideas exist but I don't want to finish this ticket without having a first implementation that shows if the overall interface makes sense.
Currently blocked by https://github.com/iov-one/iov-core/issues/621


[IA-3340] Fixed issue causing incorrect CPU number to be passed on update

Originally, when a user would create a GCE runtime and then try to update it to a Dataproc one, they would get an error because the incorrect value was being passed in the update for the masterMachineType. This line fixes this by updating the masterMachineType to the default value when the application configuration is changed, which mirrors what the CPUs dropdown value changes to when the application configuration is changed.
Testing:

Created a default runtime and then updated it to a Hail runtime and saw no issues and verified that the network calls showed the correct masterMachineType value
Updated the CPUs value and verified that the network calls showed the expected values
Updated a Hail runtime to a default runtime and verified that the network calls showed as expected with no errors

Think this looks good. Is there a way to test this in the UI?

Yes, I tested it locally in my UI. You could check out my branch and do the same if you want to verify as well.


Optimized Code

That isn't a optimized code
  const args = message.content.slice(prefix.length).trim().split(/ + /g);
  const cmd = args.shift().toLowerCase();
  const command = client.commands.get(cmd);
  if (command) {
    if (!message.content.startsWith(prefix)) return; // the problem is here

I suggest you doing this:
if (!message.content.startsWith(prefix)) return; // now if message isn't starts with prefix, he don't execute a lot of code .

  const args = message.content.slice(prefix.length).trim().split(/ + /g);
  const cmd = args.shift().toLowerCase();
  const command = client.commands.get(cmd);

  if (command) {

Although this would usually be an effective change, in this case the bot needs to be able to continue with the else statement.
if (command) {
  ...
} else {
  ...
}

Instead I will be able to change it to this instead to help with optimization.
if (message.content.startsWith(prefix)) {
    const args = message.content.slice(prefix.length).trim().split(/ + /g);
    const cmd = args.shift().toLowerCase();
    const command = client.commands.get(cmd);
    ...
  } else {
    ...
  }

Thanks for the help!

if and that puts the content of else before the message.content.startsWith?

The change I made will instead of checking for the prefix then returning it moves the else from the if (command) statement and places it under the new message.content.startsWith() statement allowing the bot to still respond to the messages that it is allowed to that aren't commands. Apologies if I misread what you are trying to say here.


Added weather app

Weather app added using api key from openweather closes the issue #102
screenshots:

Please merge the PR @artimanputra and @Shreyaar12 thankyou!!

Please merge it @gekkowrld

can anyone merge this issue , its been approved @gekkowrld @artimanputra @Shreyaar12 .


Controller taking as much EU as possible

Issue description:
We are playing with Industrial Craft and the Controller takes as much EU as possible.
What happens:
The controller says it needs 74 RS/t. That should be ~19 EU/t.
When connected to a CESU (max output: 128 EU/t) the controller takes 128EU/t. With a LV-Transformator (max output: 32EU/t) the controller just takes 32 EU/t.
What you expected to happen:
The controller should take 19 EU/t.
Steps to reproduce:

Plant a controller and some things that consume RS.
Build a CESU and put an advanced Battery in it to charge it.
Connect the Controller with the CESU by Copper Cables.
Measure the EU Out/Input with an EU-Reader. It says 128 EU/t.
Put an LV-Transformater between Controller and CESU.
Repeat step 4 and you see 32 EU/t.

Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: <IP_ADDRESS>5
Refined Storage: 1.2.14
Industrial Craft 2: 2.6.140-ex110

Does this issue occur on a server? yes
I can provide screenshots, if required.

I addition to this we noticed that the output of an LV-Transformer is (always enough).
The controller says it needs 226 RS/t (56.5EU/t). The LV-Transformer has a max output of 32EU/t.
But the controller wont go empty.
The in- and output was again verified by the EU-Reader.

I addition to this we noticed that the output of an LV-Transformer is (always enough).
The controller says it needs 226 RS/t (56.5EU/t). The LV-Transformer has a max output of 32EU/t.
But the controller wont go empty.
The in- and output was again verified by the EU-Reader.

I have no idea what causes this bug. We are using the IC2 api correctly, and I can do nothing to fix it because IC2 is closed-source. Also, IC2 support is removed in the 1.11 version of the mod so I'm going to tag this as wontfix.

I have no idea what causes this bug. We are using the IC2 api correctly, and I can do nothing to fix it because IC2 is closed-source. Also, IC2 support is removed in the 1.11 version of the mod so I'm going to tag this as wontfix.


Proxy from env

Coverage increased (+0.09%) to 94.845% when pulling 2fbc7e4d3072d0be9a2529477f3f4bbf970e32a2 on proxy_from_env into e63f02f5ac8ec27df4a63d6f17806c59ce9db8e9 on master.


Generated management libraries using locale links

See this PR for an example: https://github.com/Azure/azure-sdk-for-js/pull/20606/files#diff-f46f1e77a805cf4787ad307ba749477b58eb4a8be597b428d135aefef31580a5R15
I am not well versed in the generation process, and where the source of truth is for these links, but we should not include locale information in links.
Either the swagger repo needs a validation rule against locale links (en-us for example) or the generator that is used here should be smart enough to remove them.
Additionally, ideally we'd validate these in PRs rather than in our aggregate pipelines

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Storage:0.08740165,Data Factory:0.04072615,CodeGen:0.03683309'

@maorleger I create a new lint rule proposal here https://github.com/Azure/azure-openapi-validator/issues/282

close it as swagger lint rule has added. Thanks


Notebooks doesn't display images that have uppercase file extensions

Create an image and give it an uppercase file extension (e.g. test.PNG)
Attach the image to the Notebook

The image will either show as a broken link or fail to attach and these errors appear in the console :
Failed to fetch: TypeError: Failed to fetch
file: Refused to load resource c:\Users\chgagnon\Desktop\test.PNG from file: protocol (original URL: file:///C:/Users/chgagnon/Desktop/test.PNG)
If I change the URL in the notebook to lowercase (![](c:\src\AzureDataStudio\extensions\notebook\test.png)) then it works fine. (on Windows at least)

@VasuBhog can you take a look at this one please?

@Charles-Gagnon it would be good to know what machine you are using in said issues regarding image linking. I was not able to repro this issue on Mac, so I assume it's Windows.

Moving to August. Let's try to get this in for August if we can @MaddyDev

@MaddyDev does this still repro?

@MaddyDev does this still repro?

Yes this still repros.


[ci] Increase check-gitlab-pipeline timeout

Current timeout for monitoring the tagged release pipeline is 130 minutes. Successful builds of this pipeline can sometimes take longer than that. Increase timeout to 3h.
ref https://github.com/paritytech/substrate/issues/5638

bot merge


wg_engine: MSAA support, part 1 - move blending to fragment shaders

Apply custom blending using fragment shaders instead of compute shaders.
This reduces the number of context switches (from 4 to 2) when using a custom blend
Also removes artifacts on surface boundaries when using analiasing (will be added in part 2)

closed due to multiple merge-conflicts. will be recreated


Include number of expected runners in reconciliation metric

Applicable spec: n/a
Overview & Rationale
Adaptions for https://github.com/canonical/github-runner-manager/pull/28
Update "Runners after reconciliation" dashboard panel to include expected number of runners

Note that the number of expected runners is not available for reactive runners, so you may need to filter out reactive runners in the application filter to get a more meaningful visualisation.
Update "Available runners" dashboard panel to visualise max expected number of runners.

Juju Events Changes

Module Changes
runner_manager: Change LXD runner manager to issue the metric.
Library Changes
n/a
Checklist

[x] The charm style guide was applied.
[x] The contributing guide was applied.
[x] The changes are compliant with ISD054 - Managing Charm Complexity
[x] The documentation is generated using src-docs.
[x] The documentation for charmhub is updated.
[x] The PR is tagged with appropriate label (urgent, trivial, complex).
[x] The changelog is updated with changes that affects the users of the charm.
[x] The changes do not introduce any regression in code or tests related to LXD runner mode.

Could we also add it to the chart with the green horizontal bars that show the available runners? Perhaps as a vertical stack or something?

Could we also add it to the chart with the green horizontal bars that show the available runners? Perhaps as a vertical stack or something?

Updated.


Using mongomock for async tests

I am trying to use mongomock to mock all connections going to mongodb.
I do it as suggested by the docs:
@mongomock.patch(servers=(('localhost', 27017),))
def test_something():
     mongo_client = MongoConnector('localhost)
     mongo_client.insert_new_case('id', {})

This works fine, but I also have tests which need to run async as the are testing a client which uses aiohttp:
@mongomock.patch(servers=(('localhost', 27017),))
def test_something(test_client):
    client = await test_client(create_app)
    resp = await client.get('my_url')

Where the test_client itself makes calls to mongo_db.
The problem is: when using the mongomock.path decorator the async tests are no longer able to execute and are just skipped:

Skipped: async def function and no async plugin installed (see warnings)

But the the plugins are indeed installed, without mongomock they run fine.
So the question is:
Is there any change to get mongomock running with async tests, did you already tried something in that direction? My problem right now is, I do not yet have a deep enough understanding of pytest/pytest add-ons and mongomock interacting with each other to know where to start looking...
Even an estimation of if that is possible at all, or where to start looking at, would be interesting.
Thanks in advance

your issue is with pytest. You need to use pytest-async and decorate your function with that

Hey, thanks for your answer, as I stated above

But the the plugins are indeed installed, without mongomock they run fine.

Meaning if I run the same tests running against a real DB and thus not using mongomock they are running fine -> pytest async is installed and indeed working.
But adding the @mongomock.patch decorator somehow prevents my tests from using pytest-async

you can use with patch ("pymongo.MongoClient",mongomock.MongoClient).
Mongomock.patch under the hood uses patch decorator. that is known to have problems with other decorators like pytest.mark.async


Cannot install powershell in docker ubuntu 24.04 image

Describe the issue
Unable to install powershell in ubuntu 22.04 docker image following the instructions for ubuntu from Microsoft at https://learn.microsoft.com/en-us/powershell/scripting/install/install-ubuntu?view=powershell-7.4#installation-via-package-repository-the-package-repository
If applicable, what package did you attempt to install, and from which repo?
powershell, packages-microsoft-prod
Steps to Reproduce
FROM ubuntu:24.04 AS build

ARG DEBIAN_FRONTEND=noninteractive

RUN apt-get update && \
    apt-get upgrade -y

# Install dotnet
RUN apt-get install -y \
    dotnet-sdk-8.0

# Install prerequisites for powershell
RUN apt-get install -y \
    wget \
    apt-transport-https \
    software-properties-common

# Install powershell
RUN wget -q https://packages.microsoft.com/config/ubuntu/$(lsb_release -rs)/packages-microsoft-prod.deb && \
    dpkg -i packages-microsoft-prod.deb && \
    rm packages-microsoft-prod.deb && \
    apt-get update && \
    apt-get install -y \
    powershell

Actual Result
powershell package is not installed. Instead, exit code 100 is returned and apt-get saying: E: Unable to locate package powershell
Expected Result
powershell package should be installed

The issue is being tracked here: https://github.com/PowerShell/PowerShell/issues/21385


Lucknow Call Girls EsCoRT Service-<PHONE_NUMBER>

Lucknow Call Girls EsCoRT Service-<PHONE_NUMBER>Lucknow Call Girls EsCoRT Service-<PHONE_NUMBER>Lucknow Call Girls EsCoRT Service-<PHONE_NUMBER>Lucknow Call Girls EsCoRT Service-<PHONE_NUMBER>Lucknow Call Girls EsCoRT Service-<PHONE_NUMBER>Lucknow Call Girls EsCoRT Service-<PHONE_NUMBER>Lucknow Call Girls EsCoRT Service-<PHONE_NUMBER>Lucknow Call Girls EsCoRT Service-<PHONE_NUMBER>Lucknow Call Girls EsCoRT Service-<PHONE_NUMBER>Lucknow Call Girls EsCoRT Service-<PHONE_NUMBER>

https://additigupta.in

[](https://additigupta.in)https://additigupta.in

https://www.additigupta.in


UI Design for Login page

Here is the final design. Please refer to screenshot below.

You can refer to the following image for further details on creating the page :

You can get all the related assets for creating the page from the link below :
https://drive.google.com/drive/folders/1JsK6l1B5pSKJY2MCSMQVZYq1EwGuOx4t
Please comment below if you want to work on this or in case of any question/suggestion.
Mentors for EvalAI-ngx Project (@aka-jain @spyshiv @shivaniprakash95 @RishabhJain2018 @deshraj) will try to respond to this thread ASAP so that you are not blocked.

These are the additional icons for SignUp page. Please take reference from the present website so as to get the exact picture of things. Here is the link to the page: https://evalai.cloudcv.org/auth/signup

Closing this since it is already merged.


Cannot find module 'ControlStrings'

Hello,
Can someone please help me in this issue. I am using listItemComment controls in my web part to add list item comment functionality. I had taken a local copy of the control and make use of it in my web part so that I can make certain changes in the CSS of the locally installed control and while doing this I had came across issue with 'import strings from "ControlStrings";  '.
In Code If I hower on this issue its says "Cannot find module 'ControlStrings' or its corresponding type declarations.ts(2307)". I had also checked that in my 'config.Json' Control Srings is already added under 'Localized resources'. To resolve the issue, I also tried downgrading my Node version, but it didn't work for me.
To resolve the issue, I also tried to downgrading my Node version to 8.14.0, but it didn't work for me. So I have upgraded my node version once again.
Please refer below details related to this webparts.
Versoning information
Node - v14.17.2
+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>`--<EMAIL_ADDRESS>Config.Json-
{
"$schema": "https://developer.microsoft.com/json-schemas/spfx-build/config.2.0.schema.json",
"version": "2.0",
"bundles": {
"list-item-com-web-part": {
"components": [
{
"entrypoint": "./lib/webparts/listItemCom/ListItemComWebPart.js",
"manifest": "./src/webparts/listItemCom/ListItemComWebPart.manifest.json"
}
]
}
},
"externals": {},
"localizedResources": {
"ListItemComWebPartStrings": "lib/webparts/listItemCom/loc/{locale}.js",
"ControlStrings"<EMAIL_ADDRESS>"PropertyControlStrings"<EMAIL_ADDRESS>}
}
Error screenshots-

@AnsariFurqan - if I understand correctly, you copied a single component from the code but you didn't nom install the library - is that correct?
if yes - ControlStrings module will not be defined as you simply don't have it.
You will need to copy the appropriate strings definitions to your localization file.


Update mdoc, sbt-mdoc to 2.2.23

Updates

org.scalameta:mdoc
org.scalameta:sbt-mdoc

from 2.2.21 to 2.2.23.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta" } ]

labels: library-update, semver-patch

Superseded by #89.


Inline script in barcode.html require csp 'unsafe-inline' in the script-src directive

The unsafe-inline keyword annuls most of the security benefits that Content-Security-Policy provide.
It'd be better if you created a new javascript file with the inline script that you inserted into barcode.html file and then point to the external script file through the src attribute.

@massmarz Is this a warning that you are getting or an error? This is how we are using js file in html now.
 .

@CodingWithTashi If you enable CSP on you web server (I use helmet with expressjs ) the inline script inside barcode.html is blocked with the error: Content Security Policy: The page’s settings blocked the loading of a resource at inline (“script-src”).
The problem in not  but the following inline script. The solution is to create a new javascript file (ex. reader.js) and to put inside this file the inline script:
//refer doc here https://github.com/mebjas/html5-qrcode
const html5QrCode = new Html5Qrcode("reader");
etc.

Then inside barcode.html point to the external script:

Hi @massmarz , I will check it out but it might take some time since I am involved in other tasks, feel free to create a pull request.


set panel content background also dark

extended the night mode so that the content of the panels also follows the dark mode.
old:

new:

Thanks. That's a useful change.


[Bug] OrderBy column

Bug report
What I did
Update from v6.7.23 to v6.7.24 and above
What I expected to happen
OrderBy will work as in previous version
What happened
It works in v6.7.23 but after update to v6.7.24 and above it does not work with an error:
SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '."id" desc limit 25' at line 1

select
  `document`.*
from
  `document`
order by
  "document"."id" desc

It probably should be something like this:
select
  `document`.*
from
  `document`
order by
  `document`.`id` desc

This is the commit and part that changed:
https://github.com/Laravel-Backpack/CRUD/commit/ab969cddf3023d629e51adc11b4aebbd9a2526f6
Specifically from this:
https://github.com/Laravel-Backpack/CRUD/commit/ab969cddf3023d629e51adc11b4aebbd9a2526f6#diff-7b3eda922f455b17224d490ff2fb7ea813665afbc56acdcb6b0af29e70e8f9efL179
To:
https://github.com/Laravel-Backpack/CRUD/commit/ab969cddf3023d629e51adc11b4aebbd9a2526f6#diff-7b3eda922f455b17224d490ff2fb7ea813665afbc56acdcb6b0af29e70e8f9efR181
Column that has error has specific orderLogic in column definition but the same orderLogic works with v6.7.23 and it does not with v6.7.24 and above
What I've already tried to fix it
Revert to v6.7.23
Is it a bug in the latest version of Backpack?
After I run composer update backpack/crud the bug... is it still there?
Yes from v6.7.24 and above
Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:
### PHP VERSION:
8.3.8

### PHP EXTENSIONS:
Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, bz2, calendar, ctype, curl, dba, dom, hash, FFI, fileinfo, filter, ftp, gd, gettext, gmp, json, iconv, intl, SPL, ldap, mbstring, session, standard, odbc, pcntl, exif, mysqlnd, PDO, pdo_dblib, pdo_mysql, PDO_ODBC, pdo_pgsql, pdo_sqlite, pgsql, Phar, posix, pspell, random, readline, Reflection, mysqli, shmop, SimpleXML, soap, sockets, sodium, sysvmsg, sysvsem, sysvshm, tidy, tokenizer, xml, xmlreader, xmlwriter, xsl, zip, xdebug, Zend OPcache

### LARAVEL VERSION:
<IP_ADDRESS>

### BACKPACK PACKAGE VERSIONS:
backpack/activity-log: 2.0.5
backpack/backupmanager: v5.0.4
backpack/basset: 1.3.5
backpack/calendar-operation: 1.0.6
backpack/crud: 6.7.24
backpack/editable-columns: 3.0.10
backpack/filemanager: 3.0.8
backpack/generators: v4.0.5
backpack/language-switcher: 1.0.1
backpack/logmanager: v5.0.2
backpack/medialibrary-uploaders: 1.2.0
backpack/menucrud: v4.0.1
backpack/newscrud: 5.1.0
backpack/pagemanager: 3.3.0
backpack/permissionmanager: 7.2.1
backpack/pro: 2.2.14
backpack/revise-operation: 2.0.0
backpack/settings: 3.1.1
backpack/theme-tabler: 1.2.11

Hey @preBit thanks for the report 🙏
Just released 6.7.30 with the fix, our tests didn't caught this because we were asserting against hardcoded strings we created using the orderByRaw.
Let me know if you are still experiencing issues after the update 👍
Cheers

Thanks for the quick fix! 🙌 I tested the update, and the issue is resolved. Everything’s working perfectly now. Appreciate the support! 👍
Cheers


404: "The requested resource wasn't found." with a valid record on PATCH request

I'm running version ^0.18.0 and after coming back to my codebase after a few days it seems like my update call to the Pocketbase database has broken. I'm getting a 404 error telling me the record doesn't exist but if I look in the database the record does exist and the server does respond when I manually request it through the /api/collections/users/records/:id endpoint. I also tried running a PATCH request manually through the /api/collections/users/records/:id endpoint, only to be met with the same problem. Please let me know if there's any more information I could add to assist further
My logs

The GET Request

Double check whether your request satisfy the collection Update API rules, eg. whether you are authenticated (see the note in https://pocketbase.io/docs/api-rules-and-filters/#api-rules).
If that's not the case, please export your collections configuration as json (Admin UI > Settings > Export collections) and provide an example how you are sending the request and I'll have a look.


Add Code Owners

Codecov Report

Merging #103 (dfe761c) into main (e4d50e6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   98.76%   98.76%
=======================================
  Files          61       61
  Lines         970      970
  Branches      195      195
=======================================
  Hits          958      958
  Misses         12       12


Update Pages “auction-management”

Automatically generated by Netlify CMS

👷 Deploy Preview for docbracing processing.

Name
Link

🔨 Latest commit
33496c13ac194beeff479ecc0d122a4c44f368be

🔍 Latest deploy log
https://app.netlify.com/sites/docbracing/deploys/6510c8c7fa5cfd0008eded3f


Carthage doesn't build it for OSX (though it does for iOS, tvOS, and watchOS)

Could you try out #53 and tell me if it fixes your issue?

Ah! That did it. Thanks.


Validations are not working when creating a new API with a swagger definition

Description:
In the Integration Studio, we can create an API with a swagger definition. However, it throws NPE if the swagger definition is not in the correct format. We need to handle this tooling itself. Also, in Create new API wizard we can create an API without pointing a swagger definition file. It always enables the Finish button in the wizard to create an API.
Suggested Labels:
Type/Bug

Fixed

Fixed


cmd/govim: goimports fails in github.com/eliasnaur/gophercon-uk-2019-talk

What version of Vim/Gvim are you using?
Vim/Gvim version
$ vim --version
VIM - Vi IMproved 8.1 (2018 May 18, compiled Aug 22 2019 04:01:19)
macOS version
Included patches: 1-1900
Compiled by Homebrew
Huge version without GUI.
Git commit b6bbbaec1c8457db55c5f7e26d3030fe5c118d13.
What is the output of :messages in Vim?
Messages maintainer: Bram Moolenaar<EMAIL_ADDRESS>Do the Vim channel, govim or gopls log files show anything interesting?
@myitcv kindly debugged the issue with me and found nothing interesting in the logs.
What did you do?
$ cd $(mktemp -d)
$ export HOME=$PWD
$ git clone https://github.com/myitcv/govim.git ~/.vim/pack/plugins/start/govim
Cloning into '/var/folders/_7/lnt35k555hl2bs7fjygkhgx00000gp/T/tmp.6dcyONcR/.vim/pack/plugins/start/govim'...

...

testmac:~ elias$ git clone https://github.com/eliasnaur/gophercon-uk-2019-talk.git

...

$ cd gophercon-uk-2019-talk
$ cd demo/
$
$ vi main.go
Installing govim and gopls

I then deleted the import "gioui.org/ui/layout" line and issued :w to save the file.
What did you expect to see?
The import line re-added by govim.
What did you see instead?
No change.

Thanks for the report.
Bizarrely, I cannot reproduce this any more.
I used the following as a starting point:
export GOVIM_LOGFILE_TMPL=%v
cd $(mktemp -d)
export HOME=$PWD
git clone https://github.com/myitcv/govim.git ~/.vim/pack/plugins/start/govim
cd ~/.vim/pack/plugins/start/govim
git checkout b6bbbaec1c8457db55c5f7e26d3030fe5c118d13
cd $HOME
curl -LSso ~/.vimrc https://raw.githubusercontent.com/myitcv/govim/b6bbbaec1c8457db55c5f7e26d3030fe5c118d13/cmd/govim/config/minimal.vimrc
export GOPATH=$(mktemp -d)
git clone --single-branch --branch live https://github.com/myitcvforks/gophercon-uk-2019-talk
cd gophercon-uk-2019-talk/demo
vi main.go

then waited for "things to settle", which is more precisely defined as waiting for the following to appear in the govim log:
PublishDiagnostics callback: &protocol.PublishDiagnosticsParams{
    URI:         "file:///tmp/tmp.HR7HCq9goZ/gophercon-uk-2019-talk/demo/main.go",
    Version:     0,
    Diagnostics: {
    },
}

Then delete line 6 (via dd), then :w. Leaves me with:
package main

import (
	"gophercon/simple"
	"log"

	"gioui.org/ui"
	"gioui.org/ui/app"
	"gioui.org/ui/layout"
)

func main() {
	go func() {
		theme := simple.NewTheme()
		w := app.NewWindow()
		ops := new(ui.Ops)
		btn := new(simple.IconButton)
		q := w.Queue()
		for e := range w.Events() {
			switch e := e.(type) {
			case app.UpdateEvent:
				cfg := &e.Config
				ops.Reset()
				theme.Reset(cfg)
				cs := layout.RigidConstraints(e.Size)
				for e, ok := btn.Next(q); ok; e, ok = btn.Next(q) {
					log.Println(e)
				}
				btn.Layout(cfg, ops, cs)
				w.Update(ops)
			}
		}
	}()
	app.Main()
}

Are you able to repro with the above?

I can't reproduce the bug with your steps. I re-reproduced the bug on my local checkout of gophercon-uk-2019 a few times, but suddenly I couldn't. Event the steps from my original report doesn't reproduce the bug anymore :(
I suppose we can close this as not reproducible. I'll re-open it if I manage to reproduce the error again. Perhaps my home machine still has the problem.

I'll re-open it if I manage to reproduce the error again. Perhaps my home machine still has the problem.

Please do.

Aaaand it's back! I'm not sure what makes it intermittent, but now I can reproduce the bug with my own steps and for a small demo with just a single directory with a go.mod and a single main.go. But I can't reproduce the bug with @myitcv's steps above.

Got somehow nerd-sniped into this as well on my way home from work.
I managed to reproduce it using Paul's steps (except for the wait for "things to settle") on the subway a few times, but as soon as I got home the error disappeared.
Haven't had time to dive deeper, but I realised that the connection was pretty bad on my way home, and during this "things to settle" wait, there were a few network requests to gioui.org.
Could it be related to gopls being interrupted by a save during some init phase that takes longer time on slow connections? And then doesn't recover fully.
I had to try running it at home again but manually blocking the network requests for a few seconds, then I'm able to reproduce it again.

I managed to reproduce it using Paul's steps (except for the wait for "things to settle") on the subway a few times, but as soon as I got home the error disappeared.

One thing to potentially note here. With current master (https://github.com/myitcv/govim/commit/b6bbbaec1c8457db55c5f7e26d3030fe5c118d13) we do not have a number of fixes to race conditions, threading model etc in gopls. With https://github.com/myitcv/govim/tree/tools_gopls_95c3470cfb70 (branch for #467) we do. So it would be interesting if you can repro using the latter, modulo https://github.com/golang/go/issues/33647 (which is the blocking reason why #467 is not merged)

except for the wait for "things to settle"

This could be a very significant part of the problem. Again, with https://github.com/myitcv/govim/tree/tools_gopls_95c3470cfb70 the problem may just have "gone away". Otherwise, it's possible (likely?) that the initial run of gopls "does something different/significant", which if interrupted or some such, causes things to get into a bad state, much like you both have suggested.
The one other thing to note from previous tests is that the git server behind gioui.org is much slower than github.com.  I recall from our debugging session that @eliasnaur is using tip, so perhaps not an issue there, assuming valid package/module import paths are being used (because if not they proxy will fall through to the git server in any case)

For some reason, setting GOPATH=$HOME makes goimports work. Unsetting
GOPATH again makes the problem re-appear. That applies to @myitcv's example
as well.

That's interesting. I'm still stuck as to how you reproduce this with my steps given I can't reproduce it. But it sounds like @leitzler has made progress on reproducing?

Unfortunately I'm back to not being able to reproduce it (in a consistent way). Played around with different network issues but after letting network requests through it does actually recover. Next save formats everything..
@eliasnaur just out of curiosity, could you add a pair of logs where you do the same steps where one works and the other doesn't?

I think I can do better. Here is a Dockerfile with everything set up:
https://gist.github.com/eliasnaur/a61fb0ad106b3a762c2e81ec8d82a464
I can then reproduce the problem with:
$ docker build . # From the directory with the Dockerfile
$ docker run --rm -it <image name> /bin/bash

and then following the instructions from my report. I did
wait for things to settle, and ran a go test . from the demo
directory to make sure everything was warmed up.
Then, running export GOPATH=$HOME makes the automatic
goimport work for me! Unsetting with export -n GOPATH again
broke the import. Remember to git checkout . between attempts.

Ha! Nice repo indeed :+1:. I just gave it a quick try but it didn't work at all, as in doesn't seem to try to load govim.

Able to repro at least. But did you not have GOPATH set explicitly when running into the issue the first time?
I've seen some places where scripts/code assume that GOPATH is set (probably written pre Go 1.8 where the default value was introduced). Could this be the case here as well?
I'm not super familiar with gopls internals, but maybe here for example? https://github.com/golang/tools/blob/922a4ee32d1add0a49cd363b04bb56407baa2ec6/internal/lsp/cache/view.go#L193

I've run with GOPATH cleared ever since I set GO111MODULE=on on my machines.

@leitzler created a fix for this in https://go-review.googlesource.com/c/tools/+/191600/
We're just blocked on https://github.com/golang/go/issues/33647, then we can update

Because https://go-review.googlesource.com/c/tools/+/192719 is listed in https://github.com/govim/govim/commit/6961210ff30a5862594ff04dde9f3a5f62120ae4, I assume this is fixed with v0.0.23. Thank you for working on this!


Add "Invite" button on top right

Pull Request Description

Implement https://github.com/enso-org/cloud-v2/issues/884

Add an "Invite" button that is present when the "Share" button is not present

Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

We need to polish this modal a bit:

make the input bigger

remove add user button
instead after user hits space you change the email into bubble/tag with x to remove it (like here https://kopi.dev/tailwind/tags-input/ but within the input)
if I type email which doesnt meet the format lets color it red and prevent from submitting the whole modal

@PabloBuchu initial implementation of the new input has been added.

The text area seems big but the text can be only 24 characters wide..


Add typing

Version: 0.7.0b1
Python: 3.9.13
OS: macOS

What was wrong?
Include typing so downstream libraries can use without having to place type: ignore statements on the imports.
e.g.
from eth_tester.exceptions import TransactionFailed  # type: ignore

How can it be fixed?
Including type declarations everywhere + a py.typed file in the core source directory.

@pacrob, over the past year, there has been no activity here. Could you confirm the relevance/necessity of this issue, and if so, I am prepared to attempt to do it?

@DavidRomanovizc Typing is still desired here. I'll get a pr in soon to start the typing and make it easier to add typing file by file, and will make note of it in this issue.


weave_flows metric is fastdp-only, no way to see how many sleeve flows there are

(note: I'm not very familiar with Weave internals, so apologies if I make terminology mistakes below - please correct me!)
We recently ran into the issues fixed in 2.6.2 (#3781, #3783, #3782), and while working through upgrading our clusters were wondering how we could detect this sort of thing in the future.
We use Prometheus for our monitoring, and have the weave_flows metric graphed on a Grafana dashboard. It's obvious when looking over a period of time that the number of flows plummets (in our case, from an average of a few thousand per node to below ~100 per node).
However, we found no way to measure the number of sleeve flows.
Note that this may be related to #2557, but that may be a big general, and it's been stale for a long time.
What you expected to happen?
A metric to measure the number of sleeve flows should be present, or perhaps a label to indicate which kind of flows are being measured.
What happened?
No indication of what weave_flows is actually indicating.
How to reproduce it?
Grab the output of the /metrics endpoint from a weave process.
Anything else we need to know?
Probably not relevant, but we're running on AWS with KOPS.
Versions:
Note: we were running Weave 2.6.1, but have now upgraded to 2.6.2. (can't exec into the weave-net pod, but we're running weaveworks/weave-npc:2.6.2).
$ docker version
Client:
 Version:           18.09.9
 API version:       1.38 (downgraded from 1.39)
 Go version:        go1.11.13
 Git commit:        039a7df9ba
 Built:             Wed Sep  4 16:51:48 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Server:
 Engine:
  Version:          18.06.3-ce
  API version:      1.38 (minimum version 1.12)
  Go version:       go1.10.3
  Git commit:       d7080c1
  Built:            Wed Feb 20 02:26:45 2019
  OS/Arch:          linux/amd64
  Experimental:     false
$ uname -a
Linux ip-10-40-108-161 5.3.0-0.bpo.2-cloud-amd64 #1 SMP Debian 5.3.9-2~bpo10+1 (2019-11-13) x86_64 GNU/Linux
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.3", GitCommit:"06ad960bfd03b39c8310aaf92d1e7c12ce618213", GitTreeState:"clean", BuildDate:"2020-02-11T18:14:22Z", GoVersion:"go1.13.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.10", GitCommit:"1bea6c00a7055edef03f1d4bb58b773fa8917f11", GitTreeState:"clean", BuildDate:"2020-02-11T20:05:26Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}

Logs:
(not relevant IMO)
Network:
(not relevant IMO)

"flow" is an object in the OVS kernel module used by fastdp; there is no analogous structure for sleeve.
But I think you are looking for some indication that peer-to-peer connections have stuck at sleeve when they should be fastdp.  We could add the connection type as a label on weave_connections.
Does weave_connections{state="established"} - weave_flows give you the number of sleeve connections?

"flow" is an object in the OVS kernel module used by fastdp; there is no analogous structure for sleeve.
But I think you are looking for some indication that peer-to-peer connections have stuck at sleeve when they should be fastdp. We could add the connection type as a label on weave_connections.

Ah, thanks for clarifying. Yes, that's definitely what I'm looking for, and connection type on weave_connections sounds about right!

Does weave_connections{state="established"} - weave_flows give you the number of sleeve connections?

That's kind of what I was wondering, but the scale seems off. From what you're implying weave_connections{state="established"} should include both fastdp and sleeve connections?
For example, during one of the instants when we were running Weave 2.6.1, for one of the pods, weave_connections{state="established"} is 15, where weave_flows is 42, though the weave_flows count seems to vary quite a bit more than connections:

And then, after the upgrade to 2.6.2, weave_flows is quite a bit larger than weave_connections{state="established"}:

So I suppose that means that no, weave_connections{state="established"} - weave_flows won't really mean anything 😉

Ah, right: flows are per-MAC whereas connections are per-machine (or peer if you prefer).
Would you be interested to try a PR to add the connection-type label?

perhaps, though I'm not at all familiar with the weave code so it may take some time... I'll poke at it and see 😉

Great!  Start here: https://github.com/weaveworks/weave/blob/0c4659c3b545f2fa719474ef941629d28b699820/prog/weaver/metrics.go#L50
The status struct has a dictionary Attrs where key name should give a string like sleeve or fastdp.  (There may also be keys like encrypted and mtu)

@bboreham thanks - I was wondering what Attrs would be! map[string]interface{}s are the bane of my existence 😂

@bboreham I've issued #3789 - PTAL when you have a chance, it's perhaps a bit rough, let me know how I can improve it!


Ensure that git repository is closed before transfer

Repository Transfer requires that the repository directory is renamed - which
is not possible on Windows if the git repository is open.
Fix #17885
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Codecov Report

Merging #18049 (a97a6e8) into main (1c7db70) will decrease coverage by 0.02%.
The diff coverage is 47.95%.

@@            Coverage Diff             @@
##             main   #18049      +/-   ##
==========================================
- Coverage   45.20%   45.18%   -0.03%
==========================================
  Files         823      824       +1
  Lines       91371    91441      +70
==========================================
+ Hits        41305    41317      +12
- Misses      43471    43528      +57
- Partials     6595     6596       +1

Impacted Files
Coverage Δ

cmd/dump.go
0.89% <0.00%> (ø)

models/asymkey/ssh_key_verify.go
0.00% <ø> (ø)

modules/log/colors.go
69.86% <0.00%> (ø)

modules/util/path.go
56.17% <0.00%> (ø)

routers/api/v1/repo/pull.go
28.69% <0.00%> (-0.15%)
:arrow_down:

routers/api/v1/repo/transfer.go
56.52% <0.00%> (-3.95%)
:arrow_down:

routers/web/repo/pull.go
30.38% <0.00%> (-0.17%)
:arrow_down:

routers/web/repo/repo.go
31.87% <0.00%> (-0.31%)
:arrow_down:

routers/web/user/auth_openid.go
0.00% <0.00%> (ø)

routers/web/user/oauth.go
35.38% <0.00%> (ø)

... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be91df4...a97a6e8. Read the comment docs.

Please send backport.


Retain ordering groups and controls

When running the migration for processes with both inherited and custom groups and fields, the order isn't retained so that custom fields are always last. This PR will keep the order of the fields and groups so that they are the same when migrating processes.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: sawpresto sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@liang2zhu1 Will this get merged or is the project inactive now?


Improve language around handling redirects

Adding this as an issue here but with the expectation that https://github.com/orgs/AMWA-TV/teams/nmos-architecture-review will move it somewhere more general.
IS-04 and IS-05 say things like:

For Controllers performing GET and HEAD requests, using these methods SHOULD correctly handle a 301 (Moved Permanently) response.
When a 301 is supported, the Controller MUST follow the redirect in order to retrieve the required response payload.

E.g. at https://github.com/AMWA-TV/is-05/blob/v1.1.x/docs/APIs.md#get-and-head-requests
This seems like strange conformance language: "SHOULD handle a 301 [and if it does] MUST follow the redirect".
At least automated test cases seem possible...

Summarizing @AMWA-TV/nmos-architecture-review Slack thread:

I'm slightly wary of putting "automatically follow" since best practice is probably not to follow HTTPS -> HTTP, to give up if you get stuck in a loop, etc. So maybe the simplest thing is just to delete the second sentence with the MUST and leave it as "correctly handle"? E.g. see the Remarks section in HttpClientHandler.AllowAutoRedirect Property (System.Net.Http)

But what does "correctly handle" imply? That your application doesn't explode?

The obvious spec reference would be RFC7231
But that only says "The user agent MAY use the Location field value for automatic redirection"

Now on ARG backlog

Is the change as simple as merging the two sentences:

Clients performing requests using these methods SHOULD correctly handle a 301 (Moved Permanently) response by following the redirect in order to retrieve the response payload.

This gets rid of the second MUST which was conditional and weakened by the preceeding SHOULD.


fix: blockNumber is not bigNumber

Pull Request Test Coverage Report for Build 702

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 52.839%

Totals

Change from base Build 700:
0.0%

Covered Lines:
552

Relevant Lines:
924

💛  - Coveralls


Roslyn csc exits with Segmentation fault

Hello,
I am setting up a testing pipeline on gitlab and always get a segfault when running the tests:
 -----CompilerOutput:-stdout--exitcode: 139--compilationhadfailure: True--outfile: Temp/UnityEngine.TestRunner.dll  -----CompilerOutput:-stderr----------  /opt/unity/Editor/Data/Tools/RoslynScripts/unity_csc.sh: line 13:   467 Segmentation fault      (core dumped) "/opt/unity/Editor/Data/Tools/RoslynScripts/../../Tools/Roslyn/csc" /shared /noconfig @Temp/UnityTempFile-f986ab8ffbc50a42cb29d29ed01f73ca  -----EndCompilerOutput---------------
I added export RoslynCommandLineLogFile=$UNITY_DIR/roslyn.log to my script and get no useful hints :( Has anyone an idea what could be causing this? Could it be, that the gitlab runners resources are too low?

--- PID=469 TID=1 Ticks=300302408: Attempt to open named pipe 'fk0ePXpgfzxwDCqHQp37sqgqEEy74tUh2YFuCiPy1CM'
--- PID=469 TID=1 Ticks=300302410: Attempt to connect named pipe 'fk0ePXpgfzxwDCqHQp37sqgqEEy74tUh2YFuCiPy1CM'
--- PID=499 TID=1 Ticks=300302656: Keep alive timeout is: 600000 milliseconds.
--- PID=499 TID=1 Ticks=300302667: Constructing pipe 'fk0ePXpgfzxwDCqHQp37sqgqEEy74tUh2YFuCiPy1CM'.
--- PID=499 TID=1 Ticks=300302722: Successfully constructed pipe 'fk0ePXpgfzxwDCqHQp37sqgqEEy74tUh2YFuCiPy1CM'.
--- PID=499 TID=1 Ticks=300302722: Waiting for new connection
--- PID=469 TID=5 Ticks=300302725: Named pipe 'fk0ePXpgfzxwDCqHQp37sqgqEEy74tUh2YFuCiPy1CM' connected
--- PID=499 TID=1 Ticks=300302730: Pipe connection detected.
--- PID=499 TID=1 Ticks=300302730: Memory available - accepting connection
--- PID=469 TID=5 Ticks=300302732: Creating BuildRequest
--- PID=469 TID=5 Ticks=300302732: Working directory: /builds/awsm-core/frontend
--- PID=469 TID=5 Ticks=300302732: Temp directory: /tmp/
--- PID=469 TID=5 Ticks=300302733: Lib directory: null
--- PID=469 TID=5 Ticks=300302733: Compiler hash: 8da8ba0cf0754c14cff7fb7d22335889f7f44f2b
--- PID=469 TID=5 Ticks=300302733: argument[0] = /noconfig
--- PID=469 TID=5 Ticks=300302733: argument[1] = @Temp/UnityTempFile-48a82e7836b7181ad97aeb42ed582173
--- PID=469 TID=5 Ticks=300302743: Begin writing request
--- PID=499 TID=1 Ticks=300302744: Client 0: Begin reading request.
--- PID=499 TID=1 Ticks=300302751: Reading length of request
--- PID=469 TID=5 Ticks=300302751: Formatting request
--- PID=469 TID=5 Ticks=300302754: Writing length of request.
--- PID=499 TID=1 Ticks=300302755: Attempting to read 4 bytes from the stream
--- PID=469 TID=5 Ticks=300302759: Writing request of size 325
--- PID=469 TID=5 Ticks=300302761: End writing request
--- PID=469 TID=5 Ticks=300302761: Begin reading response
--- PID=469 TID=5 Ticks=300302764: Reading response length
--- PID=469 TID=5 Ticks=300302771: Attempting to read 4 bytes from the stream
--- PID=499 TID=1 Ticks=300302784: Read 4 bytes
--- PID=499 TID=1 Ticks=300302784: Finished read
--- PID=499 TID=1 Ticks=300302784: Attempting to read 325 bytes from the stream
--- PID=499 TID=1 Ticks=300302785: Read 325 bytes
--- PID=499 TID=1 Ticks=300302785: Finished read
--- PID=499 TID=1 Ticks=300302785: Parsing request
--- PID=499 TID=1 Ticks=300302790: Client 0: End reading request.
--- PID=499 TID=7 Ticks=300302810: Client 0: Begin compilation
--- PID=499 TID=1 Ticks=300302828: Constructing pipe 'fk0ePXpgfzxwDCqHQp37sqgqEEy74tUh2YFuCiPy1CM'.
--- PID=499 TID=1 Ticks=300302829: Successfully constructed pipe 'fk0ePXpgfzxwDCqHQp37sqgqEEy74tUh2YFuCiPy1CM'.
--- PID=499 TID=1 Ticks=300302829: Waiting for new connection
--- PID=499 TID=7 Ticks=300302836: CurrentDirectory = '/builds/awsm-core/frontend'
--- PID=499 TID=7 Ticks=300302836: LIB = ''
--- PID=499 TID=7 Ticks=300302836: Argument[0] = '/noconfig'
--- PID=499 TID=7 Ticks=300302836: Argument[1] = '@Temp/UnityTempFile-48a82e7836b7181ad97aeb42ed582173'
--- PID=499 TID=7 Ticks=300303222: Begin Analyzer Consistency Check
--- PID=499 TID=7 Ticks=300303231: End Analyzer Consistency Check
--- PID=499 TID=7 Ticks=300303231: ****Running C# compiler...
--- PID=499 TID=7 Ticks=300309843: ****C# Compilation complete.
****Return code: 0
****Output:
Microsoft (R) Visual C# Compiler version 3.5.0-dev-20359-01 (8da8ba0c)
Copyright (C) Microsoft Corporation. All rights reserved.
--- PID=499 TID=7 Ticks=300309843: Client 0: End compilation
--- PID=499 TID=7 Ticks=300309844: Client 0: Begin writing response.
--- PID=499 TID=7 Ticks=300309846: Formatting Response
--- PID=499 TID=7 Ticks=300309846: Writing response length
--- PID=499 TID=7 Ticks=300309848: Writing response of size 277
--- PID=499 TID=7 Ticks=300309848: Client 0: End writing response.
--- PID=469 TID=6 Ticks=300309851: Read 4 bytes
--- PID=469 TID=6 Ticks=300309851: Finished read
--- PID=499 TID=7 Ticks=300309851: Pipe 0: Closing.
--- PID=469 TID=6 Ticks=300309852: Reading response of length 277
--- PID=469 TID=6 Ticks=300309852: Attempting to read 277 bytes from the stream
--- PID=469 TID=6 Ticks=300309852: Read 277 bytes
--- PID=469 TID=6 Ticks=300309852: Finished read
--- PID=469 TID=6 Ticks=300309854: End reading response

Sorry, I forgot to mention that we use Unity 2020.2.3.f1

Try the -nographics option.
If you're using the game-ci/unity-test-runner action, See https://github.com/game-ci/unity-test-runner/issues/95.

I'm having the same issue, version 2019.3.2f1.
I attached my job log
I used the example CI folder, so -nographics is set for us.

EDIT2: It was indeed caused by an error in the BuildCommand.cs

Could you please elaborate what the error was and whether there is something we could improve, so that others can learn from this issue in the future?

Sure thing.
Essentially, I partially overwrote my existing BuildCommand.cs with this new one and overwrote a function I was referencing. Since I didn't look at Unity (which had thrown an error message about it) but rather pushed it straight to CI, Unity began building up to the point of the function call, where it then segfaulted.
My guess is that Unity just doesn't check for compiler errors in the script file before executing it, leading to some strange effects.
So make sure your BuildCommand.cs contains no errors, if you roll with your own version (we essentially added support for asset bundle building and some more variables for our game)

Closing this issue as the root cause was a compiler error in the user's build method.


chore(deps): bump https://github.com/jenkins-x/jx-cli to 3.0.180

Update jenkins-x/jx-cli to 3.0.180
Command run was ./promote/main

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


WIP Add verification to import [closes #10385]

Read more here: #10385.
Before fully implementing this, I think we need to decide on how to verify that the tarball isn't an image.
Right now, just checking if the repositories file exists like @runcom did in https://github.com/runcom/docker/commit/e4a6a6c0d612d5da3ef275118a81571a1d9a1ad7.
/cc @unclejack @runcom -- your feedbacks?
Status

implement the verifyTarball method
gunzip tarball if needed
write tests

Thanks.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "verify_import" git@github.com:ripcurld00d/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Wondering if this will all change with the new image manifest format https://github.com/docker/docker/pull/18785
/cc @aaronlehmann (think he's on vacation now for the Holidays though)

@thaJeztah  thanks for letting me know.
From reading the doc it looks this change doesn't completely depend on @aaronlehmann's work.

@ripcurld00d ah cool, I hadn't read the full description yet, so wasn't sure; thought I'd point you to that in case it did make a difference. :smile:

ping @unclejack PTAL :grinning:

ping @aaronlehmann perhaps you can have a look at this as well?

I'm confused about what happens in case of a remote URI. It looks like before this change, the client would just relay the URI to the daemon. Now, the client appears to download the tar, and send both the tar data and the URI to the daemon. Which does the daemon use?
It may be problematic for the client to pre-download the tar. Why can't the verification happen on the daemon side?

@aaronlehmann - I didn't implement this on the daemon because I prefer to get the verification error quickly and saving time on sending the tarball file (especially when it's a large file).
On the other hand, it makes the code cleaner if implemented on the daemon.
What do you think?
Thanks.

Maybe it makes sense to put the verification code in a library that's shared between the client and the daemon. When importing a local file, the client could perform the verification before sending it. When importing a URI, the daemon could be responsible for verification.
I see your point that it's preferable not to send a tar to the daemon just to find out it's invalid. But I think the remote URI case is much better handled by the daemon, because otherwise it either needs to be downloaded by both the client and daemon, or downloaded by the client and sent to the daemon. Either option generates more network traffic and latency.

@aaronlehmann :+1: I will be working on this today. Thanks for your feedback. :smile_cat:

I have just seen that Docker has the pkg/chrootarchive package that can be useful for this patch. I will update more this PR.
Let you know when I am done. :laughing:

@thaJeztah @aaronlehmann can you review this now?
I didn't write any tests yet, because I am not satisfied with the VerifyTarballNotImage function in the api/common.go file.
Looking at the load command and its server API, it looks like there is no format for the image tarball. Am I right? If so, how can one determine whether a tarball is a valid image or not? Should I just assume the format should be according to the tarball generated when running docker -o <tarball_name> save?
Thanks. :gift:

The image tarball structure is as followed:

The tarball consists of repositories file and directories
The repositories file is a JSON file, which has the name, the tag and the layer ID of the image.
Each directory represents a layer. The directory name is the layer ID.
In each directory, there are the "json", the "layer.tar" and the "VERSION" files.

Let me know what you think about the following (greedy?) "algorithm" to verify that the tarball is a valid image:

Ensuring "repositories" exists in the main directory
"repositories" is a valid JSON file
every directory in the root directory has the "json", the "layer.tar" and the "VERSION" files

Thoughts?

cc @tonistiigi ^

I'm not convinced we should do this at all. Both of these enpoints accept tars, there is no limitation on the tar files import endpoint takes. It would be "nice to have" if it didn't come with a performance penalty but I don't think this is possible as currenly import directly loads the tarball and doesn't do any scanning on content.

+1 to what @tonistiigi has said above. I'd much rather do something such as checking for the existence of the repositories file or whatever after extracting. This seems to be the kind of code which could introduce some bugs after a few passes of refactoring.

@unclejack @tonistiigi @aaronlehmann  - thanks for your feedback.
I thought that looking for the "repositories" file was just a small part or at least the first step of the validation.
So if I got it right, I am going to untar the tarball to a temporary folder and check the "repositories" file is there, then remove that folder. Does that sound good?
Thanks.

@ripcurld00d If I interpret @unclejack's comment correctly, the idea is to hook the validation into the current import / load functionality. That code already extracts the tarball, and the validation would be part of that code.
We obviously loose the advantage of doing the validation earlier, but I share the concerns raised that an extra extraction step, or reading in-memory would be dangerous and potentially introducing bugs / performance issues.

@thaJeztah We don't extract the tarball for import on docker side. The tar is directly sent to layerStore and from there to the graphdrivers.

@tonistiigi oh! sorry, I thought we processed before that, my bad :blush:

@thaJeztah thanks for the clarification. :bow:
@tonistiigi @unclejack - I'll let you know when I am done.

Ping @ripcurld00d :innocent:

@icecrime, yeah still working on it. I just was too busy preparing to a  conference that I lectured there.

ping @ripcurld00d have you had time, or should we close this in the meantime?

@thaJeztah Let's find somebody to carry.

After some discussion, we decided there's possibly too much connected to changing this, and we think it's better to not implement this.
Thanks so much for contributing @ripcurld00d, but I'll close this one :heart:

@thaJeztah no problem. Looking for another way to contribute. :smile:


colcon build very slow in docker container

I build a package in host, it takes 2 minutes. But in a docker, it takes 16 minutes.

Any update on this?

nvm, I checked the logs and the slowness was from pytest, I removed some libraries and it was as fast as the non container environment (don't ask me why doing that makes pytest faster)

@baker-Xie Did you ever find a way to improve this? I have seen this in multiple scenarios as well.


Stops working once Laravel 5.4.24 version gets updates

Stops working once Laravel 5.4.24 version gets updates

Can anyone suggest what should be the changes required for this.
Thank you !

Same issue!

@usamanoman :
I have researched more on this and the final solution is to make your laravel version fix till "5.4.23".
Now do not update to version "5.4.24" or above, till Laravel Session Tracker gives us updated package.
Thanks !

Hi,
Since Laravel 5.4.24 has a Method called "refresh" in Model Class. Then you have to rename the method in src/Models/Session.php and src/SessionTracker.php.
There are a Problem to with jenssegers/agent for version 2.6, i made a pull Request. You can find the 2 solutions there.
https://github.com/hamedmehryar/laravel-session-tracker/pull/6/files
https://github.com/hamedmehryar/laravel-session-tracker/pull/5/files
https://github.com/hamedmehryar/laravel-session-tracker/pull/4/files


Find Slovakian border guard website links

https://www.financnasprava.sk/sk/infoservis/hranicne-priechody
includes wait times at each border crossing

https://www.financnasprava.sk/sk/infoservis/hranicne-priechody
includes wait times at each border crossing
That link doesn't work anymore. It returns 404 now.

I've overlooked a piece of information in the previous research, and that is that one of the reddit thread opening posts mentioned that Chop (railway checkpoint) was closed to individual traffic - I'm not sure whether that refers to some road crossing I haven't seen mentioned anywhere, or whether the rail checkpoint actually isn't available for individuals.
https://www.stellacentrum.sk/dopravne-informacie/hranicne-priechody/

Contains various pieces of information as well as tables with border crossings for the Slovakian neighbour states Austria, Czech Republic, Hungary, Poland and Ukraine, namely the ones corresponding with Uzhhorod and Malyj Bereznyj.

Another page that seems intended to show waiting times, but... kinda doesn't, I think? (I very much doubt the 00:03 part, for example - and it's always the same, too): https://kordon.customs.gov.ua/uk/home/countries/sk/o
This page offers quite a wealth of information on the overall subject of crossing into Slovakia and seeking refuge there in general: https://www.ukraineslovakia.sk/en/z-ukrajiny-na-slovensko-english/
Chop is missing from all of these three pages (Mali Selmentsi is mentioned on ukraineslovakia.sk).

All of this is telling me that Chop probably shouldn't readily be put on display in a way that suggests to people that it's a checkpoint they can just up and head towards. It's probably a good idea to have it in the data somewhere, however.

Is this complete?  I see there is a Slovakia scraper.


Improve cross-platform build compatibility and dependency management

See #147 for motivation.
This is a reminder to myself that I need to work on it when I feel like shooting myself in the foot with a CMake-sized gun again.
Alternatively, if we want to bite the bullet entirely, I can experiment with some MSBuild based project management, which actually works extremely well with NuGet and .NET Core:
https://github.com/FiniteReality/thermite/blob/master/natives/NativeLibrary.props
https://github.com/FiniteReality/thermite/blob/master/natives/NativeLibrary.targets
https://github.com/FiniteReality/thermite/blob/master/natives/minimp3/minimp3.cxxproj
(In our case, we'd change <TargetFramework> to be Native, since we're building a native project.)
If we do go the MSBuild route, I can't guarantee full compatibility with Visual Studio (hell, Visual Studio may just croak entirely due to how radically different these projects are from standard vcxproj projects), but we can make the dependencies work more or less just fine. We may, however, require custom repos to host our MSBuild-ified versions or just end up absorbing the source in-repo.

CMake is probably more stable. How you choose to set up CMake is your decision. Whatever makes the most sense and will play ball with whatever dependency management we need to use (I still have no idea how this is gonna proper build on Linux...).

We did it reddit.
In all seriousness, nice work @FiniteReality - closing this.


Add docker-compose file as example

Describe in detail the problem you had and how this PR fixes it
There wasn't an example of how to use docker-compose with code-server.
Is there an open issue you can link to?
Yes. docker-compose examples #648

With docker-compose, would it be trivial to add https with certbot for  example purposes ?

With docker-compose, would it be trivial to add https with certbot for example purposes?

It could be easy, but I don't think it is in the scope of the example. The goal was to reproduce the docker command example:
docker run -it -p <IP_ADDRESS>:8443:8443 -v "${PWD}:/home/coder/project" codercom/code-server --allow-http --no-auth

@sr229 why is this obsolete? There is no merge conflict.

@nhooyr @sr229 it's not obsoleted, it just uses old flags that changed since v2

I manually changed it to v2 flags. I'll work on this so it can be merged.

CC @code-asher feel free to merge this in or cherrypick.


refactor(router): show endpoint id in url

close #454

Technically LGTM, interestingly I would have thought that this PR would remove a lot more code but I see we still need to keep the EndpointProvider/StateManager endpoint related features.
EDIT: been playing with it, LGTM

I support refactoring/removing the endpointProvider and state manager endpoint related features, but I felt like it can be done in a future PR, as this one became big just by adding the endpoint id to the URL. A refactor is needed, not sure if it's needed in this PR.

I support refactoring/removing the endpointProvider and state manager endpoint related features, but I felt like it can be done in a future PR, as this one became big just by adding the endpoint id to the URL. A refactor is needed, not sure if it's needed in this PR.

Agree, let's bring the feature first.


Tabbing into field no longer works in 2.1.0

Since 2.1.0, possibly due to this commit, you can no longer tab into the multiselect control.
Reproduction Link
https://jsfiddle.net/4qzahx3b
Steps to reproduce

Click the first input
Try tabbing into the multiselect. Focus will skip to the last input.
Try shift+tabbing into the multiselect. Focus will skip to the first input.

Expected behaviour
Focus should land on the multiselect control.
Actual behaviour
Focus skips the multiselect control.

Sorry, this was reported in #685 (evidently I didn't go back far enough). I'll follow that issue.


Question: Background monitoring?

Hi!
Is it possible to monitor characteristics when the app is in background or sleeping?
Currently, without any additional setup, the app just does nothing when phone screen turned off. Monitoring (or receiving the values) continues after the app is opened again. (tested only on iOS)
Have you considered adding some kind of buffer to native code so that app could keep receiving data from the BLE device while screen is turned off? The buffer data would then be accessible from JavaScript.
Thanks for the great library!

I would really appreciate this feature as well

Hi,
Have you turned on bluetooth background mode on iOS?
You could only do it entering proper info in plist.
In this way, when bluetooth action is happening(for example notification on characteristic), your iOS app is woken up by the system and have a bit of time to do it's job.

I certainly need to test it on both Android, iOS and check if any API changes or additional steps are required.

@Kacper20 Turning on bluetooth-central background mode doesn't seem to make any difference. Something more has to be done.. :)
The app continues from where it was left. Tested also with Instruments' Time Profiler and there seems to be no activity.

I'm working on this for Android. I think the app needs a scheduled background job to do this.

Hi guys!
I just found out that the background monitoring actually works out of the box (with background-mode turned on).
I had beed sending requests to my device to response me with data and that didn't work.
Instead of that, now I send the data from my device (Arduino with BLE chip) automatically without the need of the request and the app will continue to monitor and receive that data after turning display off. 😄
This was tested on iPhone.

@stami Have you tried killing the app?

@vikeri Sorry for delay.. I hadn't notifications on for this thread.
Killing the app? In order to achieve what?
Currently the connection breaks if I reload the app. Haven't tried bundling and building release for some time...

@stami My experience is that it works as long as iOS/Android keeps the app in the memory. As soon as they kill the app due to inactivity or otherwise high memory load the BLE connection will be lost.

@vikeri I haven't got much knowledge on this but to me, that sounds something that cannot be helped even with native code.

@stami True, what I did was to put the code in a background job that schedules every 15 min. Then the app is woken up in the background and reconnects again to the Bluetooth. I did a library for it (only Android atm) vikeri/react-native-background-job

@Kacper20 Is there any known blocker for supporting state-restoration for iOS? Otherwise i would start working on that.

@mane87 It's supported on backing RxBluetoothKit library, so I think that it's just the matter of creating API and wrapping this calls in JS.
@Cierpliwy any objections?

I don't have any objections really. All I want is an API which won't require iOS/Android specific JS code. I'm not sure if it's doable though.

To be precise:
I'm talking about State Restoration section from Bluetooth Programming Guide.
There's detailed description provided by Apple here
RxBluetoothKit has listenOnRestoredState method, which you should subscribe to after re-instantiating BluetoothManager(on applicationDidFinishLaunching).
We need to have API from side of this library to wrap this one call, but I'm sharing @Cierpliwy doubts that this would have to be platform-specific logic, since this differs so much on Android and iOS.
So we would have to implement method that would have to be only available on iOS. Since I'm not really into ReactNative I don't know whether it's possible to do this in a nice way and how it'll affect library.
Does this answers your question @mane87?

@Kacper20 @Cierpliwy Thanks for the fast answers guys. Sounds good. I'll have a look at it and see if i come up with a clean solution.

Hey guys, it's a really great feature, any news?

@edencakir Background monitoring is working.
As for state restoration, that is totally different question and should be discussed in another thread, in my opinion.
I opened this issue and consider it solved. Background monitoring was working, I wasn't just using it correctly as I was trying to poll the data instead of just monitoring changes.
I'm closing this issue now. Please create another one for state restoration. :)

Glad to hear that.

Currently, without any additional setup, the app just does nothing when phone screen turned off. Monitoring (or receiving the values) continues after the app is opened again. (tested only on iOS)

Your comment made me confused, thank you for the clarification.


Hardware Acceleration didn't work,it can't decode.

@Sean-Der Thanks for the hint.
browser webrtc log info:
Report type=inbound-rtp
id=RTCInboundRTPVideoStream_597189778
time=1617955656066.087
ssrc: 597189778
isRemote: false
mediaType: video
kind: video
trackId: RTCMediaStreamTrack_receiver_52
transportId: RTCTransport_0_1
codecId: RTCCodec_1_Inbound_102
firCount: 0
pliCount: 1680
nackCount: 0
packetsReceived: 37785
bytesReceived: 40068701
headerBytesReceived: 453420
packetsLost: 0
lastPacketReceivedTimestamp: 17640.963
framesReceived: 8525
framesPerSecond: 25
framesDecoded: 0
keyFramesDecoded: 140
framesDropped: 8474
totalDecodeTime: 0
totalInterFrameDelay: 0
totalSquaredInterFrameDelay: 0
decoderImplementation: FFmpeg
did i miss something?
Hey @cRuiTe
Thanks for checking out Pion. The example is hardcoded to always use x264enc you can change the encoder here
Thanks for checking out Pion. If you run into anything else I am also available in Slack
Originally posted by @Sean-Der in https://github.com/pion/example-webrtc-applications/issues/95#issuecomment-817348140

#95 #

Sorry I missed this, were you able to get it to work @cRuiTe ?

yes,just update to the Latest... @Sean-Der


!feat: VEC-273 0.9.1 support

replace ScheduleDelay with Schedule
replace merge.Parallel with merge.IndexParallel
add merge.ReIndexParallel
add applyDefaults to IndexList

Can be reviewed now. Will need to change the image used in the docker compose files after AVS 0.9.1 is released

Codecov Report
Attention: Patch coverage is 15.35714% with 237 lines in your changes missing coverage. Please review.

Project coverage is 21.34%. Comparing base (b7ab11d) to head (54b9635).

Files with missing lines
Patch %
Lines

protos/index.pb.go
2.08%
188 Missing :warning:

protos/index_grpc.pb.go
0.00%
20 Missing :warning:

client.go
65.30%
17 Missing :warning:

protos/types.pb.go
0.00%
12 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   21.19%   21.34%   +0.14%
==========================================
  Files          18       18
  Lines        5520     5716     +196
==========================================
+ Hits         1170     1220      +50
- Misses       4264     4407     +143
- Partials       86       89       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


nar/serialize.go: fix reader

There's no guarantees on how many bytes the Read() method of an io.Reader will write.
We can't assume it to block until all bytes requested are there - it can
return before (especially if it's still receiving on the other side).
This adds a "hesitantReader", which behaves like this, a failing unit test, then switches serialize.go over to use io.ReadFull (which behaves like we want it to).
After all that is done, we switch over to encoding/binary instead of bitshifting manually to produce the (u)int64.

Note the other read* methods suffer the same problem - I'll address that in a followup.


Without scrollbars, the user may read only the part of terms of service and think that he read them completely

Currently
The page length is clear

Can we solve the issues like this by disabling middle alignment on small screens (mobile) instead?

@paolomolo do we need a scrollbar on the Terms page?


removing added address field from MachineAccountInfo

We need to be able to upgrade the contract, so we can't include the address field because it wasn't in the original version.
Removed the part of the tests that compared the address field since it doesn't exist any more

Yep, I've included on in my latest changes