[R][Python] Unable to load pyarrow package through reticulate in R on windows

Describe the bug, including details regarding any error messages, version, and platform.
I'm trying to use arrow to share large data frames between python and R. If I load the R packages then try to import the python module this fails with an ImportError from python:
> library(arrow)
The tzdb package is not installed. Timezones will not be available to Arrow compute functions.

Attaching package: ‘arrow’

The following object is masked from ‘package:utils’:

    timestamp

> library(reticulate)
> py_discover_config()
...
version:        3.9.18 | packaged by conda-forge | (main, Dec 23 2023, 16:29:04) [MSC v.1929 64 bit (AMD64)]
Architecture:   64bit
...
> pa <- import("pyarrow")
Error in py_module_import(module, convert = convert) :
  ImportError: DLL load failed while importing lib: The specified procedure could not be found.
Run `reticulate::py_last_error()` for details.

Note that I can load the pyarrow in a vanilla python REPL just fine.
If I ensure to import pyarrow before loading the R package then it works, however this is difficult to guarantee (other packages may have already loaded the R arrow package), and causes failures during package development.
> library(reticulate)
> import('pyarrow')
Module(pyarrow)
> library(arrow)
The tzdb package is not installed. Timezones will not be available to Arrow compute functions.

Attaching package: ‘arrow’

The following object is masked from ‘package:utils’:

    timestamp

Because it seems to be driven by some sort of incompatibility between the R and python arrow libraries, I tried various different versions to see if I could get anything that works. Initially I was using R 4.2.1, but could also reproduce with a fresh install of R 4.3.2. I tried various python versions including fresh installs of the latest (3.11.5), and also the conda version as installed by reticulate::install_miniconda (3.9.18 above). I tried using the latest version of the pyarrow package (15.0.0), and also downgrading to 14.0.0 to match the latest available R package.
Component(s)
Python, R

I've attempted to diagnose it by loading the library directly as follows:
> library(arrow)
...
> reticulate::repl_python()
Python 3.12.2 (C:/Program Files/Python312/python.exe)
Reticulate 1.35.0 REPL -- A Python interpreter in R.
Enter 'exit' or 'quit' to exit the REPL and return to R.
>>> import ctypes as c
>>> dll = c.WinDLL(r'C:\Program Files\Python312\Lib\site-packages\pyarrow\lib.cp312-win_amd64.pyd')
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\PROGRA~1\PYTHON~2\Lib\ctypes\__init__.py", line 379, in __init__
    self._handle = _dlopen(self._name, mode)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [WinError 127] The specified procedure could not be found

That produces a pop up with the mangled C++ symbol name that caused the issues, in this case eg: "The procedure entry point ?type@StringBuilder@arrow@@UEBA?AV?$shared_ptr@VDataType@arrow@@@std@@XZ could not be located in the dynamic link library C:\Program Files\Python312\Lib\site-packages\pyarrow\lib.cp312-win_amd64.pyd".
If I repeat the above without first loading the R arrow package, it will load the python libs just fine. Is this problem caused by both the R and python packages having different "arrow.dll" files that they're attempting to load into the same address space?

After some more digging, I think that the cause is indeed the two "arrow.dll" files. Loading the python package first works because the R "arrow.dll" is loaded directly, whereas the pyarrow version is loaded indirectly by being dependencies of the .pyd files.
I tried a hacky solution of renaming the python one to "xrrow.dll", and running sed -i.bak 's/arrow.dll/xrrow.dll/g' on the .pyd files in the directory, and it now "works" when loading the R package first:
> library(arrow)
> library(reticulate)
...
> pa = import('pyarrow')
> pa
Module(pyarrow)

Perhaps the easiest solution then is for the R library to use a different name for its dll, though I'm not sure if it has to match the package name or if that is just a convention? Alternatively perhaps dll manifests can be used on the python side.

I was able to get a manifest solution to work, following https://devblogs.microsoft.com/oldnewthing/20171011-00/?p=97195.
First I created "force_local_arrow.manifest" with the following:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
    <file name="arrow.dll" />
</assembly>

Then I patched each of "arrow_flight.dll", "arrow_python.dll", "lib.cp312-win_amd64.pyd", and "_hdfsio.cp312-win_amd64.pyd" (probably incomplete, just enough to load the package) as follows:
> mt.exe -manifest force_local_arrow.manifest -outputresource:lib.cp312-win_amd64.pyd;#2

Perhaps this approach is better than just renaming the R dll; by amending the build process for the windows python wheel to include the necessary flags to embed the manifest and avoid the problem altogether.

Hi @aquasync, thanks for the report and your work getting to a cause and fix. I can reproduce what you saw in your original report on my Windows ARM machine so I can offer that as a start here. I'll work on getting some more eyes on this.

If it's of any use/related, this message just started showing up in some of our R CMD CHECK github actions of an R package that has arrow as a dependency. In tests of a function that uses arrow to read csv files (without loading the package) we now get a new message:
 Message
 The tzdb package is not installed. Timezones will not be available to Arrow compute functions.

only on windows, causing comparison against our previous snapshots to fail because of the message: https://github.com/Infectious-Disease-Modeling-Hubs/hubValidations/actions/runs/8083994354/job/22088275404?pr=74
The last time the action was run and passed was Feb 13.
Let me know if you think this should be moved into a separate issue

Hi @annakrystalli, I don't think that's related but feel free to file a new issue and tag me. It doesn't look like anything related to that code has changed recently so my guess is that something in your environment may have changed. tzdb is a Suggests and getting this warning is expected on Windows.

Hey @aquasync, I did a little bit more research on this today and have a few notes:
I found this older Jira ticket that seemed related. That led me to try installing R arrow from conda instead of CRAN and I was able to get things to work:
$ conda create -n reticulate-test -c conda-forge python==3.12 r-reticulate r-arrow pyarrow
$ conda activate reticulate-test
$ R
> library(arrow)
> library(reticulate)
> import("pyarrow")
Module(pyarrow)

So that's possibly a workaround in case you need one right now.
As for next steps, it seems like we can modify either the Python build or the R build here and my preference would be to modify the R build as it would be relatively low impact and we know it already works because of our conda package. And we'd only have to modify it for Windows. @assignUser do you have any immediate reaction or insights into this idea?
Before I figured the above out, I filed an issue over on the reticulate repo to see if they have any ideas so I'll be curious to see if they have any thoughts.


[QUESTION] Why are the tests for GROUP BY commented out

https://github.com/mbdavid/LiteDB/blob/master/LiteDB.Tests/Query/GroupBy_Tests.cs#L49
I am especially interested in the GROUP BY and SUM from expressions calls

Further to that I wonder if Sum is in he plans? I dont see it here
https://github.com/mbdavid/LiteDB/blob/8bfdc4fb58559c62a2a394c55847b80e65ac24d5/LiteDB/Client/Database/ILiteQueryable.cs

@dangershony I believe these tests were made for a possible implementation of grouping expressions in Linq, which are not currently available in LiteDB. Personally, I don't think it makes much sense to use Linq expressions with GROUP BY: Linq expressions are meant for "typed" collections, where there is a fixed structure to the documents (defined by the LiteDB mapper), and grouping modifies the structure of the documents.
You can still use GROUP BY with Bson expressions and with the SQL syntax.

thanks @lbnascimento


Upgrade to Patternfly 2.0

Updating Angular Patternfly to use patternfly 2.0.

The only lines that changed on the gruntfile are 99-110 which represented additional script and css includes needed for ngDocs. I 100% blew away my fork and started fresh and it is still flagging that file so I don't think there is anything I can do to fix the formatting "flag"

I 100% blew away my fork and started fresh and it is still flagging that file so I don't think there is anything I can do to fix the formatting "flag"

Is it possible that it's the line endings that are different?
https://help.github.com/articles/dealing-with-line-endings/

Wouldn't all my files be flagged if was a line ending issue? It is picking up whitespace differences but I didn't format the file. You can see the diff without the whitespace changes here:
https://github.com/patternfly/angular-patternfly/pull/24/files?w=1

My guess is still the line endings.  Perhaps your editor is automatically replacing them?
[walden@wraines-sandbox angular-patternfly ((4719e39...))]$ file Gruntfile.js
Gruntfile.js: ASCII English text, with CRLF line terminators

See also https://github.com/patternfly/angular-patternfly/pull/25.  You may want to wait until that is merged and then rebase in order to get rid of the whitespace changes to Gruntfile.js

OK, please let me know when your PR is in so I can move forward. I would really like to have the date picker in by EOD if possible.

OK, please let me know when your PR is in so I can move forward. I would really like to have the date picker in by EOD if possible.

I don't have merge capabilities for angular-patternfly so hopefully someone can merge this for me.

I will go ahead and accept it. Thanks for your help on this.

Merged in PR 25 and pushed. The line ending changes did the trick.

What about rebasing after #25 instead of merging it in?  That way this PR will only have your changes and thus be easier to review.

Ok, I rolled back the merge and rebased instead.

Does anyone have any issues with this? Or can this be pulled in?

LGTM, thanks.


[4128] Add data migration to fix funding methods for 2019/20

Context
https://trello.com/c/1POTbi8l/4128-fix-funding-rules-for-2019-20
Changes proposed in this pull request
Add data migration that:

Deletes the funding method's we have for 2019/20
Adds the correct ones based on the section "Undergraduate bursary" in the manual: https://www.gov.uk/government/publications/initial-teacher-training-itt-bursary-funding-manual/initial-teacher-training-bursaries-funding-manual-2019-to-2020-academic-year#undergraduate-bursary

Guidance to review
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Register: build workflow notification bug

 Fix funding rules for 2019/20


Replace add to dock video in settings

Task/Issue URL: https://app.asana.com/0/72649045549333/1208648960421865
Description:
Replace the Add To Dock video in the App Settings.
Steps to test this PR:

Open App Settings.
Scroll to "Next Steps” section.
Tap on “Add App to Your Dock”.
Ensure that the video playing is the same of the Add To Dock onboarding experiment

Definition of Done (Internal Only):

[ ] Does this PR satisfy our Definition of Done?

Copy Testing:

[ ] Use of correct apostrophes in new copy, ie ’ rather than ’

Orientation Testing:

[ ] Portrait
[ ] Landscape

Device Testing:

[ ] iPhone SE (1st Gen)
[ ] iPhone 8
[ ] iPhone X
[ ] iPhone 14 Pro
[ ] iPad

OS Testing:

[ ] iOS 15
[ ] iOS 16
[ ] iOS 17

Theme Testing:

[ ] Light theme
[ ] Dark theme

—
Internal references:
Software Engineering Expectations
Technical Design Template

In the end we decided not to replace the video. Closing this PR


Users of the script editor in DMN should be able to insert newlines

Currently it is not possible for a user to enter newlines when editing a script.
Steps to reproduce:

Create a new DMN diagram.
Click on the first elements green table icon to open the table underlying this DMN.
Click on Enter Advanced Mode on the upper right corner.
Click on an empty cell (above string for example)
In the opening popup, click on Script
You should now be presented with something similar to this: https://www.dropbox.com/s/vudfc1v7dogjrwn/Screenshot 2017-06-27 14.08.54.png?dl=0
Enter text into the Editor and try to add a newline by pressing, enter, or cmd + enter or ctrl + enter or shift + enter

Expected: add a new line
Actually happening: nothing, or weird stuff (moving textarea etc.)

JIRA ISSUE: https://app.camunda.com/jira/browse/SUPPORT-3451

Closed via https://github.com/camunda/camunda-modeler/commit/70a7641b408677090f351eab3e3d0b378fa21aab


[Bug]: Zitadel deployment on EKS with AWS PostgreSQL RDS instance - setup job failure

Preflight Checklist

[x] I could not find a solution in the documentation, the existing issues or discussions
[x] I have joined the ZITADEL chat

Environment
Self-hosted
Version
8.5.0
Database
PostgreSQL
Database Version
16
Describe the problem caused by this bug
Attempting installation of Zitadel on EKS Kubernetes cluster fails at setup job when using AWS RDS for PostgreSQL. Initially the issue was with SSL, but after setting SSL mode to disable, and rds.force_ssl = 0 on RDS, I was able to connect successfully to RDS using username and password.
Database initialization was also successful, but setup job will get stuck to infinity with the following error:
time="2024-10-16T18:28:34Z" level=warning msg="migration already started, will check again in 5 seconds" caller="/home/runner/work/zitadel/zitadel/internal/migration/migration.go:130" migration step=projections.login_policies5
Can you help point out if this is known issue and there is a workaround.
To reproduce

Provision PostgreSQL DB instance on RDS
Edit Parameter Group and set rds.force_ssl = 0
Create a secret with RDS DB credentials - host and password
Deploy Zitadel on Kubernetes using Helm, while using correct values for configSecretName and configSecretKey
Zitadel init job will be successful
Setup job will not be successful

Screenshots

Expected behavior
Init and Setup job successful for Zitadel to be healthy and running.
Operating System
Kubernetes (AWS EKS) - 1.30
Relevant Configuration
Database:
Postgres:
Port: 5432
Database:
MaxOpenConns: 20
MaxIdleConns: 10
MaxConnLifetime: 30m
MaxConnIdleTime: 5m
User:
Username: zitadel
SSL:
Mode: disable
Admin:
Username: zitadel
SSL:
Mode: disable
configSecretName: zitadel-config-secret
configSecretKey: config.yaml
Additional Context
No response

Hi,
I am also facing the same issue while upgrading the zitadel from v2.55.8 to 2.56.0. The deployment is based on EKS with Postgres
Please suggest

Any update/workaround on this issue?

The ssl mode should be required (I switched from RDS to CNPG but that was working with RDS).
Here is my repository: https://github.com/Smana/cloud-native-ref

Hi the error of the screenshot can be fixed by executing zitadel setup cleanup cli command

The error of the screenshot can be fixed by executing zitadel setup cleanup cli command

We are running the installation of Zitadel in Gitops version. Is there solution to that suits to automated setup process?

The ssl mode should be required (I switched from RDS to CNPG but that was working with RDS). Here is my repository: https://github.com/Smana/cloud-native-ref
More specificaly here

Do you have working configurations for RDS that you can share?. I will really appreciate.

@Smana Do you have working configurations for RDS that you can share?. I will really appreciate.

@jmutai As I mentioned the trick is to keep the default sslMode for RDS but ensure that Zitadel uses require
These are the envvars that I source
ZITADEL_DATABASE_POSTGRES_USER_SSL_MODE=require
ZITADEL_DATABASE_POSTGRES_ADMIN_SSL_MODE=require

And here is the working code (when I was using RDS).

@Smana will test this out and see on how it goes. Thank you!

@Smana thanks for the example.  I am confused though.  You are setting the master password in the crossplane config also referencing the same envvar secret.  Does that mean that the master password is just being used for other rds postgresql admin funcionality for the database and not by zitadel?  I am missing where rds is being configured to trust client certs issued by the vault cert manager cluster issuer.

I was confusing myself, now I see you are using username/password auth for connecting to RDS and not client certs.

Yes and all the configurations are loaded from environment variables.

After using the zitadel setup cleanup and env variables as mentioned above, the setup job is stuck at following:
time="2024-11-15T14:38:08Z" level=info msg="verify migration" caller="/home/runner/work/zitadel/zitadel/internal/migration/migration.go:43" name=23_correct_global_unique_constraints time="2024-11-15T14:38:08Z" level=info msg="verify migration" caller="/home/runner/work/zitadel/zitadel/internal/migration/migration.go:43" name=24_add_actor_col_to_auth_tokens time="2024-11-15T14:38:08Z" level=info msg="verify migration" caller="/home/runner/work/zitadel/zitadel/internal/migration/migration.go:43" name=26_auth_users3 time="2024-11-15T14:38:08Z" level=info msg="verify migration" caller="/home/runner/work/zitadel/zitadel/internal/migration/migration.go:43" name=29_init_fields_for_project_grant time="2024-11-15T14:38:08Z" level=info msg="starting migration" caller="/home/runner/work/zitadel/zitadel/internal/migration/migration.go:66" name=29_init_fields_for_project_grant
Please suggest

@suchitsancheti did you try increasing activeDeadlineSeconds value of setupJob?
setupJob:           activeDeadlineSeconds: 600

@jmutai I have tried with values 600, 900 and 1200 and got the same result.
Anything else that I can try/check?


Use indexed DB for storing favorite layers

User can select favorite layers and this is stored in the browser's indexed DB.
User can switch between favorites layers and all layers in menu.

Ser bra ut!


Make evaluation of Binning corrections JAX-traceable

The evaluation of a scipy.interpolate.CubicSpline is not traceable by JAX (because of an explicit cast to np.array somewhere in there).
This in turn makes it impossible to pass CorrectionWithGrad.evaluate to jax.jit or jax.vmap if a Binning correction is involved.
For 1D histograms (Binning) we might be able to use something like relaxed.hist instead.
For MultiBinning histograms I don't know of a jax-friendly implementation of a bin look-up differentiable relaxation, we might have to come up with one.

Some discussion at https://iris-hep.slack.com/archives/C0155BGPGE4/p1699120426133849

options I see:

re-implement scipy.interpolate.CubicSpline using XLA primitives or jax.numpy methods
switch to sigmoids as per Lukas' suggestion
switch to a sum of gaussians


fix python interoperability notebook

Colab treats the first line as a comment if it begins with "#". So adding any line above the "#if" line fixes it.
Fixes https://github.com/tensorflow/swift/issues/405.

This does solve the issue. Will try doing the same while dealing with conditional blocks.


Mocking objects - remove default functionality?

We've been using mocks for a bit and ran into an issue. Let me first start with a simple example:
var mock = sinon.mock(myAPI);
mock.expects("myMethod").once();

This works pretty simply, I know that if I don't call myAPI.myMethod(), then the test will fail (or if it gets called more than once). I also know that the actual functionality for the method will not execute. That part works great.
The problem we've run into is if I call, for instance, myAPI.anotherMethod() in a test but it was unexpected that this would happen. Without hardcoding an expectation for each remaining method, I will never be informed that an unexpected method call occurred and, because I've already mocked out at least one method, there's a chance that the interaction between a fully-functional method and a mocked method will cause side effects.
There are mocking libraries in other languages that automatically create expectations for all methods on a mocked object (expects that the methods are not called unless otherwise specified) and remove the default functionality from those methods. Is there any chance this is being planned or discussed for Sinon?

Coming from a Python background, this is something I miss. What's the recommended way to stop incorrect calls passing through? If I'm mocking something that hits an external resource (db, http, etc.), I never want my call to actually hit the underlying library...
I could, as you suggest, stub(obj) and assert on that, but I still don't see the incorrect calls.
Agree with what @nzakas says about expectations; I feel like if stub can stub out everything in an object, mock should at least have option of doing so. How would you feel about a strictmock or similar?

@wryun I created Leche to handle this case: https://github.com/box/leche

Great - thanks!


How multiple show toasts with various options?

I need show toast for error with option "positionClass": "toast-top-right", and need show toast for warning with option "positionClass": "toast-bottom-right", but both toasts use only one setting.
CodePen
toastr.options = {
    "closeButton": false,
    "debug": false,
    "newestOnTop": false,
    "progressBar": false,
    "positionClass": "toast-bottom-right",
    "preventDuplicates": false,
    "onclick": null,
    "showDuration": "300",
    "hideDuration": "1000",
    "timeOut": "5000",
    "extendedTimeOut": "1000",
    "showEasing": "swing",
    "hideEasing": "linear",
    "showMethod": "fadeIn",
    "hideMethod": "fadeOut"
};
toastr.error('error','error');

var supportToastr =  toastr;
var options = {
    "closeButton": false,
    "debug": false,
    "newestOnTop": true,
    "progressBar": false,
    "positionClass": "toast-top-right",
    "preventDuplicates": false,
    "onclick": null,
    "showDuration": "300",
    "hideDuration": "1000",
    "timeOut": 0,
    "extendedTimeOut": 0,
    "closeClass": 'toast-close',
    "hideEasing": "linear",
    "showMethod": "fadeIn",
    "hideMethod": "fadeOut",
    "tapToDismiss": false
};
supportToastr.warning('warning','warning',options);

Duplicate of #438

I think that there is an easy way to manage different positionClass by specifying the containerId in the toastr options. Example:
toastr.options = {
    "positionClass": "toast-top-right",
};

toastr.success("default toastr position");

toastr.info('custom toastr position', '',
     {
         positionClass: 'toast-bottom-full-width',
         containerId: "toast-container-notifications"
     }
 )

The only change necessary to make this work is CSS. You need to find all css styling for #toast-container and replace that with [id^='toast-container']. You only need to make sure that you always name the containers with toast-container*


Genabio Onboarding – Testing in Staging and Prod

Acceptance Criteria

[ ] Sender has tested in staging and production
[x] RS engineer has determined the data is good enough and graduates Sender to send Prod data to receiver

To Do

[ ] RS engineer: update this ticket with comments with every interaction with sender
[x] RS team member who originates this ticket: add dependencies:

[x] [name of company] Onboarding – Create Org and Sender Settings
[x] [name of company] Onboarding - Validate Test Files

[x] RS team member who originates this ticket: complete the following when creating this Issue.

[x] Pipelines: Onboarding & Operations (New)
[x] Labels: "Onboarding-ops," "Sender"
[x] Epics: [select the epic for this API onboarding sender]

Hi Juehua,
I have included the new public key you sent in our staging environment. Could you also provide one for production and I will add it.
When you are ready could you attempt to send some test data to the staging environment? Please note that no real data should be sent to staging, only test data.
Let me know if you have any other questions.
Thanks,
James

Hi Juehua,
I think I've found the issue. In your payload you have:
{'iss': 'genabiolab.default', 'sub': 'genabiolab.default', 'aud': 'staging.prime.cdc.gov', 'exp':<PHONE_NUMBER>, 'jti': 'xxxxxxxxx'}
Whereas ReportStream is expecting
{'iss': 'genabio.default', 'sub': 'genabio.default', 'aud': 'staging.prime.cdc.gov', 'exp':<PHONE_NUMBER>, 'jti': 'xxxxxxxxx'}
also, make sure that your header replaces genabiolab.default with genabio.default and that you change your scope from genabiolab..report to genabio..report in the CURL request to get the token.
That should allow you to generate the token.
Once you have the token, remember that you should put genabio as the client in when submitting data as below:
curl -H "authorization:bearer " -H "client:genabio" -H "contenttype:text/csv" --data-binary<EMAIL_ADDRESS>"https://staging.prime.cdc.gov/api/waters"
This is probably a mistake on our part where we gave you the wrong org name so I apologize.
For your other question " "I have included the new public key you sent in our staging environment. Could you also provide one for production and I will add it." We recommend different public/private keypairs for staging and prod. The .pem file you provided with your public RSA key I have associated with your account in staging and I am requesting a .pem file with the public key associated to the public/private keypair that you will use in production (this does not have to be done now and can be done once we complete testing in staging.)
Thanks,
James

Hi James,
Thanks a lot for your detailed information in your previous email. We fixed the problems and have sent our dummy csv file verified previously by CDC ReportStream team with bearer token, however, a failure JSON response was sent back to us, please see the attached "genabio.output.txt". We also used the sample csv file in the manual page 31, "Appendix B: Sample Payloads and Output", unfortunately, we never got the response listed in the manual instead of error JSON info, please see "sample.output.txt". We suspect the errors are due to the missing values in the csv file. Do you have any suggestion?
We truly appreciate your great help!
Juehua

Hi Juehua,
It looks we had created you a custom schema with different column headers. I have reverted your settings to use the default CSV upload schema. If you submit a file following the Programmer's guide now you should receive a successful response.
Thanks,
James

Hi All,
I forgot to mention that if you would like to keep using the existing custom schema you have if you could forward me the dummy file you attempted to send in I can troubleshoot. It looks like you are missing the field testing_lab_clia.
Thanks,
James

Hi James,
Thank you so much for your email. We could not submit our dummy csv file yet by bear token, though we used the sample csv file provided by ReportStream Programmer's Guide at Appendix B, Page 31, for successful submission. After carefully checking the csv files, we noticed that testing lab information are required, however, our Covid19 antigen testing kits are OTC products and the information about testing lab is not available. So we wonder whether you can do sth in your side to ingore the testing lab information, such as name, address, phone, etc, for our submission.
In attached, please find our dummy csv file.
Best wishes,
Juehua Yu

-multiple issues with latest test file that need to be corrected.

Hi Juehua,
Apologies for my delay in response. I've checked the most recent file and I think the only thing we have that's still an issue in the file is the timestamps. Currently the date and timestamps are being sent in format dd/mm/yy. For DOB we would like yyyyMMdd and for the other timestamps in the file (order_test_date, specimen_collection_date, test_result_date, date_result_released) we would like to use the format yyyyMMddhhmmss+/-zzzz where zzzz is the offset from UTC time (for example for PST this would be<PHONE_NUMBER>2800-0800). If the offset is not included we will assume the timezone is UTC.
As far as documents, the only thing we need is acceptance on our Terms of Service, do you know if you have completed that yet? Once we have that and the timestamps issues fixed we can move to testing in production. One other thing I will need is the public key for the public/private keypair that you want to use in production. We recommend using different keypairs in staging and production.
Thanks,
James

Thanks Juehua!
The file looks good. Can you submit this through the API to our staging endpoint? If we don't have any problems there we can move on to testing in Prouction. Is there a particular state or territory that you want to test with? (usually this would be the state where most of results will go or where you are located).
Thanks,
James

Hi Juehua,
I saw some test files come in on 12/13 to staging and I have validated they look ok. The last step will be testing in production. In this step we will need you to send a few real patient results to our production api. Is there a State you would like to test with or are you only looking to report federally?
Please make sure that any real patient data is only sent to the production api. No real data should be sent to staging.
Thanks,
James
James Gilmore (Agile Six)
Senior HL7 Data Analyst
Pandemic-Ready Interoperability Modernization Effort (PRIME)

Hi James,
I have submitted real patient data already. Could you please check whether they look good?
Best,
Juehua

Waiting on Genabio


Installing GCMPushPlugin via cocoapods

Hi All,
I have run into the "Google/Cloud Messaging.h file missing" error and so I am trying to install via cocoapods following Google's instructions, however I am getting an error whenever I run pod install:
Specs satisfying the 'Google/CloudMessaging' dependency were found, but they required a higher minimum deployment target.
If I try to cordova build ios, it fails at the missing file error.
I have set deployment target to 7.1, enabled modules and added $(inherited) to my other link flags.
My Podfile is:
xcodeproj '/Users/user/projects/tenant-app/platforms/ios/CordovaLib/CordovaLib.xcodeproj'
target 'CordovaLib' do
prod 'Google/CloudMessaging'
end
Any suggestions? This was really easy to set up for android, but is proving to be a real pain for ios.

Ended up being that I was using the wrong project to build against. I am now running into the much more common linking and bitcode issues on ios, but this can be closed now.

Hello, how did you end up getting this working? I am having this same issue.


Flux notification controller with github enterprise

Hi Team and @phillebaba
this is the continuation of previous request: https://github.com/fluxcd/notification-controller/issues/161
Notification controller image updated to :

image: ghcr.io/fluxcd/notification-controller:v0.13.0

When I'm trying to create github alert observing following issue in notification controller logs

kind":"Kustomization","name":"appname","namespace":"platform"}
{"level":"error","ts":"2021-05-13T08:35:41.567Z","logger":"event-server","msg":"failed to send notification","reconciler kind":"Kustomization","name":"appname","namespace":"platform","error":"Revision string format incorrect: environment/dv01aws/e0358f0de99e1a078105b05ec2e18a8f242aef5694a"}

the github authentication is through SSO that's why I set up the gitrepsotiory resource with SSH (URL and creds) however the  Provider resource has HTTPS address
Will it be a reason for this kind of issue?
Also I didn't find in the doc https://fluxcd.io/docs/guides/notifications/ that github token should be base64 encoded or not?

I don't see how is this related to GitHub auth. The revision parser has a bug, it fails to detect that the branch is environment/dv01aws and the commit is e0358f0de99e1a078105b05ec2e18a8f242aef5694a .

@stefanprodan so I updated branch from environment/dv01aws to master for testing thinking the issue could be the '/' within in the branch name.
After updating branch to master seeing different error

{"level":"error","ts":"2021-05-13T14:43:17.484Z","logger":"event-server","msg":"failed to send notification","reconciler kind":"Kustomization","name":"appname","namespace":"platform","error":"could not list commit statuses: Get "https://github.mycompany.com/api/v3/repos/s-voggu/myrepname/commits/b2acde7 │
│ c62007333a53c0a8c4f6c05f69907525d/statuses?per_page=50": net/http: invalid header field value "Bearer u\xcd\xf5\xd5\xed\xb8i\xceuoV\xf5\u007fm\xba\ │
│ \u007fM\xddkO{\xd5\xd7{q\xbd\x9d\xf5\xbd\xf5" for key Authorization"}

Ok so these are 2 different issues, the first one is a revision parse bug, the 2nd one looks like the token is encoded twice.

@stefanprodan for second issue does  github token should be base64 encoded or not?

No, Kubernetes does the encoding for you, run this:
kubectl create secret generic gh-token \
--from-literal=token=GH-TOKEN-AS-PASTED-FROM-UI

Make sure there is no \n\r at the end of the token.

You need to set the certSecretRef , see https://fluxcd.io/docs/components/notification/provider/#self-signed-certificates

@stefanprodan I created secret name tls-certs with ca.crt file and I'm referring token and .crt as following in provider resource. please correct if I'm wrong

apiVersion: notification.toolkit.fluxcd.io/v1beta1
kind: Provider
metadata:
name: github-environment-notification
spec:
type: github
address: https://github.mycompany.com/s-voggu/reponame
secretRef:
# token
name: githubsai
# tls-cert
name: tls-certs

Thanks @stefanprodan  above cerSecretRef worked and able to get alerts if branch name doesn't have any '/'
In our case we have branches like "enviornment/dev" environment/test" environmet/prod" with these branch names in notification controller we are observing Revision string format incorrect: above you mentioned it as a bug. Could you please let us know once this bug is fixed we can test it

I will have a look at this and fix the revision parser so that it can deal with more formats.

thanks @phillebaba any ETA?

@phillebaba @stefanprodan any ETA on this issue when this fix can be released?

As much as this may be a high priority issue to you personally @sairamvoggu1007; please refrain from pinging maintainers for ETAs.
Given the people responsible to get the pull request merged are already watching the repository activity and receive notifications for review requests, this only causes additional noise and will generally not result in acceleration of closing the issue, especially not if done within a 48h window.
Thank you :sunflower:

may I know to what version I need to update notification-controller docker image to get these changes work

There is no release yet that includes these changes.

may I know expected release date with these changes?

This has been released in v0.14.1.

thanks very much!. I will be updating notification controller image to v<IP_ADDRESS>


Support C99 standards (enums, assert)

Cast enum values to int to prevent errors like:
deps/tinycbor/src/cborconstants_p.h:47:31:
error: ISO C restricts enumerator values to range of ‘int’
[-Werror=pedantic]
MajorTypeMask           = ~0U << MajorTypeShift,
"error: ISO C99 does not support" ‘Static_assert’
This effort is needed for RIOT port of iotivity-contrained
Change-Id: Ib8addf7c6703298faecfc4006cf2a9e3c1036d4c
Bug-RIOT: https://github.com/RIOT-OS/RIOT/issues/6241

cc: @kmaloor @thiagomacieira

Thank you, the change looks good. But I need a Signed-off-by line. Can you sign your commit, please?
Drop the Change-Id line while you're at it, this is not JIRA.

Merged as 3e23929


Set the system volume to provided value in bluetooth-udev

This one fixes a minor bug in bluetooth-udev which sets the system volume to 100% all the time and always.

@barhun you almost got it, apart from the Change-type line should be in the body of the commit message, last, on a line of its own. You've put it in the header.
Additionally, for this particular change, it should be Change-type: patch as you're fixing a bug rather than adding a new feature.

Thanks, it should be O.K. now. (:

@balena-ci retest

@balena-ci retest

@barhun thanks for working on this! We're just trying to figure out why the CI is still failing; could you try adding a blank newline in your commit message before Change-type: patch?
Currently you have:
Set the system volume to provided value in bluetooth-udev
Change-type: patch

Can you try:
Set the system volume to provided value in bluetooth-udev

Change-type: patch

You can use amend in the same way as you did a moment ago.

@balena-ci retest

@barhun great stuff, thanks again for the contribution! 👍

You're all welcome. (: Sorry for causing a bit of trouble, it was my first contribution to your repos.


[WIP] Exposing ImageWork, RasterWork, and VectorWork metadata using the GeoBlacklight schema

Implementing the RSpec suites for the updated Solr schema; Working to implement more complex parsing for WKT Feature Envelopes.

Closed in lieu of #154.


Create channel nuke command

It's a nuke command which deletes all messages of the channel. Actually it delete the channel and create a clone channel of it with the same position and permission.

Please add hactoberfest lebel on it

Done :)


Feliz?

I think Feliz is the most widely used web framework, but missing in the list.

Of course. Thanks!


DTSPO-16138 - Update readme

Jira link (if applicable)
https://tools.hmcts.net/jira/browse/DTSPO-16138
Change description
Add more info to readme around active instances, DNS and SSH
Checklist

[x] commit messages are meaningful and follow good commit message guidelines
[x] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)
[x] Does this PR introduce a breaking change

Plan Result (nonprod_dynatrace_activegate)
No changes. Your infrastructure matches the configuration.

Plan Result (prod_dynatrace_activegate)
No changes. Your infrastructure matches the configuration.


Feature Request: String

Sometime needs to convert an ArrayString to a raw string.
It would be very helpful if the ArrayBuffer-encoding library could handle it.

Hi @sokcuri! You can convert from an ArrayBuffer (or one of its views like Uint8Array) with a one-liner (assuming ab is an ArrayBuffer):
const str = (new TextDecoder('utf-8')).decode(ab)

I think I would prefer to keep this library lean and focused on buffers to avoid the scope expanding too much!

Thanks for comments! I'll try it TextDecoder.


[FLINK-24437][HA]Remove unhandled exception handler from CuratorFrame…

…work before closing it
What is the purpose of the change
This pull request enhances the usage of curator by removing unhandled exception handler from CuratorFramework before closing it
Verifying this change
This change is already covered by existing tests.

Please help review this PR when you are free @tillrohrmann

@tillrohrmann Thanks for your quickly reviewing :) , I have addressed your comments.
Regarding to the failure test, I have fixed it only by spying the correct curatorFramework  object, I have not come up with a good idea to introduce a CuratorFrameworkFacade, I will think about it later.

About the naming of CuratorFrameworkWithUnhandledErrorListener, I have followed you suggestion but still have some doubts that with the name of InternalCuratorResource we can expand the class when there are some other resource shipped with curatorFramework client 🤔.
Any way,  I agree for the naming for current version.


Fix coredns CVE-2023-44487 by upgrading vendor tar

Replace all uses of golang.org/x/net with version v0.17.0 in go.mod

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

coredns still has vendored code that is vulnerable to CVE-2023-44487 (golang.org/x/net/http2). The version requirement is coming from a 3rd order dependency (github.com/openzipkin/zipkin-go v0.4.2 -> github.com/IBM/sarama v1.40.1 -> golang.org/x/net v0.12.0 for example). There were multiple conflicting requirements for the version of net, so a blanket module upgrade is used. (I'm hoping the golang.org/x/net module will generally be fairly stable and backwards compatible which may not be the case for the intermediate modules).
IBM/sarama does have a version that updates to use updated x/net (version v1.41.3) however zipkin does not have any version which consumes this updated version.
Change Log

Add replace golang.org/x/net => golang.org/x/net v0.17.0 to coredns's go.mod file.
Add %check section to coredns (it only covers go unit tests, not true e2e testing).

Does this affect the toolchain?

NO
Associated issues

https://microsoft.visualstudio.com/DefaultCollection/OS/_workitems/edit/48735735

Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2023-44487

Test Methodology

local build
Buddy Build TBD

Waiting on local build before uploading sources

Thinking about this more last night, this might be a repeated task across several golang packages. I'm wondering if it wouldn't be better to use a patch file to surgically target the affected http2 module instead. It would mean we don't need to update the vendor tars for each package at the cost of slightly more cumbersome spec file patching.

Thinking about this more last night, this might be a repeated task across several golang packages. I'm wondering if it wouldn't be better to use a patch file to surgically target the affected http2 module instead. It would mean we don't need to update the vendor tars for each package at the cost of slightly more cumbersome spec file patching.

Yeah, I think that sounds better than having to patch the source before we upload it to our blobstore. Like you said, this way we can keep the same vendor tarball, but it's also in line with how we patch the upstream source and makes it easier to see, which patches were already applied. Btw. I see there's an example of what you're suggesting in #7542 now.

Rebased with latest

Auto cherry-pick results:

main :white_check_mark: -> https://github.com/microsoft/CBL-Mariner/pull/7628

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=496728&view=results


Fix a dump error in restful API of ORM

@tao-an: thanks for how to use git

@JuergenGleiss I've merged the PR #748

@JuergenGleiss Please close this PR if you ensure the change has been merged.


boot-scripts: use itest for comparison, as setexpr calculates in hexa…

…decimal
If you use numbers greater than 9 for the boot attempts, you will get the wrong result for pure letter numbers (A..F). The test command incorrectly leads to the result that e.g. F would not be greater than 0. This leads to an incorrect A/B switchover.

@matthiasklein While using itest when comparing integers seems to be more correct, I noticed that no u-boot defconfig has enabled it by default.
I would assume that using 0xa instead of a when setting default would also resolve this, issue. Doesn't it?

@ejoerns As long as there is still a number in front (e.g. 0x10), the comparison with test is also TRUE. But in the range 0xA ... 0xF the comparison becomes FALSE.
It is not just about the value that is set by RAUC, but in the boot script it is decremented by 1 before the comparison. And this happens with setexpr in hexadecimal. And then the comparison goes wrong depending on the value.
I did not have to activate the itest command separately. It was available in the meta-raspberrypi (kirkstone):
U-Boot 2022.01 (Jan 10 2022 - 18:46:34 +0000)

DRAM:  948 MiB
RPI 4 Model B (0xa03115)
MMC:   mmcnr@7e300000: 1, mmc@7e340000: 0
Loading Environment from FAT... OK
In:    serial
Out:   serial
Err:   serial
Net:   eth0: ethernet@7d580000
PCIe BRCM: link up, 5.0 Gbps x1 (SSC)
starting USB...
Bus xhci_pci: Register 5000420 NbrPorts 5
Starting the controller
USB XHCI 1.00
scanning bus xhci_pci for devices... 2 USB Device(s) found
       scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot:  0
U-Boot>
U-Boot> help
?         - alias for 'help'
base      - print or set address offset
bdinfo    - print Board Info structure
blkcache  - block cache diagnostics and control
boot      - boot default, i.e., run 'bootcmd'
bootd     - boot default, i.e., run 'bootcmd'
bootefi   - Boots an EFI payload from memory
bootelf   - Boot from an ELF image in memory
booti     - boot Linux kernel 'Image' format from memory
bootm     - boot application image from memory
bootp     - boot image via network using BOOTP/TFTP protocol
bootvx    - Boot vxWorks from an ELF image
cmp       - memory compare
coninfo   - print console devices and information
cp        - memory copy
crc32     - checksum calculation
dhcp      - boot image via network using DHCP/TFTP protocol
dm        - Driver model low level access
echo      - echo args to console
editenv   - edit environment variable
env       - environment handling commands
exit      - exit script
ext2load  - load binary file from a Ext2 filesystem
ext2ls    - list files in a directory (default /)
ext4load  - load binary file from a Ext4 filesystem
ext4ls    - list files in a directory (default /)
ext4size  - determine a file's size
false     - do nothing, unsuccessfully
fatinfo   - print information about filesystem
fatload   - load binary file from a dos filesystem
fatls     - list files in a directory (default /)
fatmkdir  - create a directory
fatrm     - delete a file
fatsize   - determine a file's size
fatwrite  - write file into a dos filesystem
fdt       - flattened device tree utility commands
fstype    - Look up a filesystem type
fstypes   - List supported filesystem types
fsuuid    - Look up a filesystem UUID
go        - start application at address 'addr'
gpio      - query and control gpio pins
gzwrite   - unzip and write memory to block device
help      - print command description/usage
iminfo    - print header information for application image
imxtract  - extract a part of a multi-image
itest     - return true/false on integer compare
lcdputs   - print string on video framebuffer
ln        - Create a symbolic link
load      - load binary file from a filesystem
loadb     - load binary file over serial line (kermit mode)
loads     - load S-Record file over serial line
loadx     - load binary file over serial line (xmodem mode)
loady     - load binary file over serial line (ymodem mode)
loop      - infinite loop on address range
ls        - list files in a directory (default /)
lzmadec   - lzma uncompress a memory region
md        - memory display
mdio      - MDIO utility commands
mii       - MII utility commands
mm        - memory modify (auto-incrementing address)
mmc       - MMC sub system
mmcinfo   - display MMC info
mw        - memory write (fill)
net       - NET sub-system
nfs       - boot image via network using NFS protocol
nm        - memory modify (constant address)
panic     - Panic with optional message
part      - disk partition related commands
pci       - list and access PCI Configuration Space
ping      - send ICMP ECHO_REQUEST to network host
pinmux    - show pin-controller muxing
printenv  - print environment variables
pxe       - commands to get and boot from pxe files
random    - fill memory with random pattern
reset     - Perform RESET of the CPU
run       - run commands in an environment variable
save      - save file to a filesystem
saveenv   - save environment variables to persistent storage
setcurs   - set cursor position within screen
setenv    - set environment variables
setexpr   - set environment variable as the result of eval expression
showvar   - print local hushshell variables
size      - determine a file's size
sleep     - delay execution for some time
source    - run script from memory
sysboot   - command to get and boot from syslinux files
test      - minimal test like /bin/sh
tftpboot  - boot image via network using TFTP protocol
true      - do nothing, successfully
unlz4     - lz4 uncompress a memory region
unzip     - unzip a memory region
usb       - USB sub-system
usbboot   - boot from USB device
version   - print monitor, compiler and linker version
U-Boot>

@ejoerns should we move on and merge this pull request?
@matthiasklein thank you for your contribution to meta-rauc-community and the provided feedback for improvements.

I think this GitHub pull request makes sense so I merged it. I tested it as part of my efforts for porting RAUC to BeagleBone Black: https://github.com/rauc/meta-rauc-community/pull/77
@matthiasklein thank you for your contribution to meta-rauc-community!


final questions

There are some other people's .yaml updates mixed into your PR. Split them out, and I'll merge?

:question: :question: :question: :exclamation:


mSplashDialog should init again in show function

when press back key to exit app and enter it immediately, it will crash, beacause the dialog does not belong to the activity now, so it needs to init mSplashDialog again in show function

Makes sense; thanks


fix(cli): tz command annot be executed by spawn

Changes
This PR addresses the issue mentioned in #349. I have run into the same problems for a while now and just kept using Cobalt UI until today. I would usually call tz build in a npm script, which runs into the same problem as described in #349. Debugging the script call in VS Code reveals that npm is throwing the error and not Terrazzo (see screenshot).

I managed to fix it by adding the shebang specifier (not sure if that is the name) from the Cobalt UI CLI to the Terrazzo CLI script, where it has been missing until now.
How to Review
Try to invoke the Terrazzo CLI through an npm script in a project. It should succedd with this PR.
I am not sure, how this can be tested. All CLI tests seem to invoke the script directly through Node.js. However, testing this requires the test to invoke the built package through npm, right? Is this possible with the current test setup? Does this need a test?
closes #349

Released in 0.2.1. Thanks! 🎉


[SPARK-29544] Collect the row count info and optimize the skewed conditions with row count info in the OptimizeSkewedJoin rule

What changes were proposed in this pull request?
Currently the OptimizeSkewedJoin rule check the skewed partition only based on the compressed data size, which is not accurate when the compression ratio is very high. This PR collect the row count info by using the CollectionAccumulator and then add the row count info to check the skew partition in the OptimizeSkewedJoin rule.
Why are the changes needed?
Optimize the OptimizeSkewedJoin rule by using the row count info.
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing ut

@cloud-fan @maryannxue

Test build #126689 has started for PR 29268 at commit 6c37017.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31311/
Test PASSed.

Test build #126689 has finished for PR 29268 at commit 6c37017.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class RowCountInfo implements Serializable

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126689/
Test FAILed.

Test build #126691 has started for PR 29268 at commit 4a9f8f7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31312/
Test PASSed.

Test build #126691 has finished for PR 29268 at commit 4a9f8f7.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126691/
Test FAILed.

can we use the ShuffleWriteProcessor API to avoid touching code in core?

@cloud-fan  If we collect the row count info in ShuffleWriteProcessor, we may need to traverse the Partition records additionally as following code:
private def collectRowCountInfo(
      mapId: Long,
      records: Iterator[Product2[Any, Any]],
      dep: ShuffleDependency[_, _, _],
      writeMetrics: ShuffleWriteMetricsReporter): Unit = {
    val numPartitions = dep.partitioner.numPartitions
    val rowCountInfo: Array[Long] = new Array[Long](numPartitions)

    while (records.hasNext) {
      val record: Product2[Any, Any] = records.next
      val key: Any = record._1
      val partitionId: Int = dep.partitioner.getPartition(key)
      rowCountInfo(partitionId) += 1
    }

    writeMetrics.addMapRowCountInfo(new RowCountInfo(mapId, rowCountInfo))
  }

But It may be bring performance degradation for the iterator of records additionally?

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33323/
Test PASSed.

Test build #128848 has started for PR 29268 at commit d0e0084.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33471/
Test PASSed.

Test build #128848 has finished for PR 29268 at commit d0e0084.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128848/
Test FAILed.

Looking forward to this feature... : )

Test build #132845 has started for PR 29268 at commit d0e0084.

Test build #132845 has finished for PR 29268 at commit d0e0084.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132845/


Procure SSL certificates

Notes:

Need to setup the domain
We need the commercial certs
We need the VA certs

Certificates from DigiCert have been purchased for:

dev.api.notifications.va.gov
staging.api.notifications.va.gov
api.notifications.va.gov


AddNullKeyInFlowSwitch test broken

Test is here

I'll review this and hopefully, I'll have a solution very shortly

@dmetzgar so what exactly do you mean by "broken" Doesn't run? Don't output anything? Or, what's supposed to be the expected result from this test?

Let me take a look at the test again.


Content Security Policy temporarily cached

Describe the bug
When manually updating the connect-src array in stripe-app.json to add a new 3rd party URL, the CSP rules appear to be temporarily cached and trigger CSP errors even after restarting the development server
To Reproduce
Steps to reproduce the behavior:

Add new URL to content_security_policy.connect-src manually
Restart dev server
Attempt to access URL from Stripe App

Expected behavior
I would expect the CSP rules to be updated on server restart and not encounter permission errors.
Desktop (please complete the following information):

OS: macOS 12.3.1 (21E258)
Browser Chrome
Version 102.0.5005.61

Additional context
Add any other context about the problem here.

@rmanzer-stripe it's currently required to enable to preview again any time the manifest is changed.  This is done by going to https://dashboard.stripe.com/apps/enable-preview while your local dev server is running.  After restarting the dev server, you can press Enter to be taken to this page automatically.  This is required to get the new CSP.

@cchalstrom-stripe The preview was refreshed several times and this was demonstrated to @tjfontaine-stripe during our Zoom call.

I'm not able to reproduce that behavior.  The connect-src eventually updated for you just by refreshing the dashboard?  For me, that never results in any manifest data being updated.  Restarting the dev server by itself shouldn't be able to change the connect-src, which is what I'm seeing while trying to reproduce this.

I paired with @rmanzer-stripe and found out that an older version of Stripe Apps CLI was used. This issue has been resolved after upgrading the Stripe apps CLI: stripe plugin upgrade apps and re-enabling app preview after change in stripe-app.json


RAC-5619: add SOL/VNC into OVA Post Test

Background:
in this PR, OVA-Post-Test  is added with VNC record/SOL logs.
NOTE: flvrec.py is updated to support this.
Test Done:
http://10...**5:8080/job/MasterCI_VNC_OVA_TEST/28/artifact/OVA_POST_TEST/ova-Install-ESXI-6.0%5Bvmslave14%5D/

Details in code:

jobs/build_ova/ansible/main.yml
-- dns_server_ip : it's for Jenkins Sandbox , which OVA need DNS to be able to connect to internet, to download flvrec.py from github.
-- BUILD_ID: fetch Jenkins BUILD_ID env variable, and attach to video record file name.
-- nohup bash vnc_record.sh &: if without nohup, the background script will exist once ansible exist.

jobs/build_ova/ova_post_test.groovy
--  typically, ./build-config is invoked in FunctionTest.groovy, but at this moment, we need vnc_record.sh being generated. so BMC_VNODE_CREDS and build-config is required earlier than before

test.sh.in
-- previously, once FIT fail, the fetchOVAlog will never be invoked .  so I used signal handler(trap) to ensure it's run.

Can we download flvrec.py in local host, then copy it to ova just like generate-sol-log.sh?
In this way, the vnc_record.sh doesn't need to access public network.

Hi, @PengTian0 , I just fixed what @changev  missed before. when he added the gateway, it still can not connect with internet because DNS is missing.
so I added it back.
for this time, I would like to  pip install vnc2flv and download flvrec.py.
next time, there may be other CI test setup requires OVA to access internet during ova-post-test period.
So I think it's fair and make sense to make OVA has the option to connect with internet during ova-post-test.

:+1:


Inheritance of Organization workflow for Teams

When workflow is not define in Team the workflow come from Organization.

Done and merged in dev branch


Associations between a class and a class hierarchy can lead to Null Pointer Exception in Java with common usage

What steps will reproduce the problem?

The following example demonstrates the issue:

// Here we define our base classes
class Vehicle {}
class Wheel {}
// Here we define our subclasses
class Bicycle { isA Vehicle; }
class Bicycle { isA Vehicle; }
association { 0..1 Vehicle vehicle -- 0..* Wheel wheel; }
association { 0..1 Bicycle vehicle -- 0..2 Wheel wheel; }
Since this declares a relationship for wheel to one Vehicle or Bicycle called vehicle, the class has just one member variable Vehicle vehicle.
Generated Wheel.java important parts:
public Bicycle getVehicle_OneBicycle()
{
    return (Bicycle)vehicle;
}

public boolean setVehicle(Vehicle aNewVehicle)
{
    ...
    vehicle = aNewVehicle;
    ...
}

public boolean setVehicle_Bicycle(Bicycle aNewVehicle)
{
    boolean wasSet = false;
    if (aNewVehicle == null)
    {
        ...
        return ....;
    }

    Bicycle currentVehicle = getVehicle_OneBicycle();
    ...
}

The problem is the Bicycle currentVehicle = getVehicle_OneBicycle();, because it is possible that vehicle would NOT be a Bicycle, but instead a generic Vehicle. In this case, a run time exception would be generated by changing what it is attached to:
Wheel wheel = new Wheel();
wheel.setVehicle(new Vehicle());
wheel.setVehicle_Bicycle(new Bicycle()); // Would crash on this line

I think this example is not correct. The reason is that there are two associations with the same role name. We should consider role names as IDs for associations. It means, for this example, we need to raise a warning and point out that the second association will be removed. I am more in favor of having an error instead of a warning because a different order in defining these associations can result in having different output. Therefore, it is better to force modelers to decide which one they want to keep.
@TimLethbridge  what do you think?
Having role names as IDs also critical for extending associations in subclasses (check issue #961).

Note:: The way we deal with subclasses in associations must be explored in more details. it must be explored why we generated those APIs


Moved font-family definitions to variables.less

I moved the font-family definitions from mixins.less to variables.less. I thought it would make more sense to have those there.

Right now, I think this complicates things unnecessarily. I'd rather keep this isolated to mixins for now.

No worries. I just thought it may have been an idea to have font-family definitions in the same place as color definitions.


need a way to remove box and decorations

hiding just the iput isn't enough especially for markup, latex, html, text cells.

we have latex in markdown now, so this is nearly irrelevant.

@scottdraves is this still something that you would like?


[iOS 13] segmented control is different

It seems now invariant from the primary color now

Will this be the new default for the Cupertino framework or will there be some kind of "activation option". Looks like big changes to me and maybe not everyone wants this also in their pre-iOS13 apps.
I think it would be best to have a kind of type attribute in the CupertinoSegmentedControl widget to choose between the different styles. And if the type is not set, select the type by the current platform version.


Axis format

Hello, I have a column char (https://jsfiddle.net/0Lnxcofk/9/). I want to know how can change the color of the text of the axis and also how add the char "%" to the x axis.
Thanks

https://jsfiddle.net/0Lnxcofk/12/


Improve  input in the comment field

There are many ways to simplify creation of tables. This is the simplest UI I've seen but I'm open to suggestions. It's only 2 clicks to add a table.

Click on "add table" button (dropdown opens)
Click the desired table size

The grid is too big for us, but a 5x5 would be plenty. No need to get fancy with alignment options and headers; those can be more easily added by the user if desired.
Example table usage: https://github.com/sindresorhus/refined-github/issues/2874
Output would be a simplified HTML5 table markup:

		 A1
		 B1

		 A2
		 B2

 A1
		 B1

 A2
		 B2

GFM can be used instead of HTML5: https://github.github.com/gfm/#tables-extension- & https://help.github.com/en/github/writing-on-github/organizing-information-with-tables

Indeed. The problem with those tables is that they’re unreadable unless there’s a only a couple of words in each cell. The moment a table row “wraps” good luck finding the separator for the next cell (especially here since there’s no syntax highlighting)
 *test*

I think, yeah, while Markdown tables are unreadable they’re easier to use

Can I work on this? and also don't you think entering numbers of columns and rows will be more efficient than dragging and it is also not restricted to any size??

entering numbers of columns and rows will be more efficient

No, because that requires at least 4 clicks and 2 key presses, while this is only 2 clicks (no dragging, just a click)

not restricted to any size??

Nobody needs 100 columns in a GitHub comment; rows can be trivially added by copy-pasting the result as many times as needed, if you need more than 7 rows.

Can I work on this?

You can, but please keep it as simple as possible, probably around 50 lines due to the dropdown’s JSX. You can copy the DOM from the canned replies (but the dropdown content would of course be like in the very first gif):

Sure I will keep it simple..

This looks fun, imma try it too.


Unable to send mail via SES in Grails 3

This line has been working for years in grails 2.x:
        def mailId = sesMail {
            from sentFrom
            to sendTo
            subject emailSubject
            html markup
        }

``
ERROR grails.app.controllers.myapp.AuthController - No signature of method: myapp.PasswordResetService.sesMail() is applicable for argument types: (myapp.PasswordResetService$_sendIt_closure1) values: [myapp.PasswordResetService$_sendIt_closure1@21620546]
Possible solutions: sesMail(groovy.lang.Closure)
groovy.lang.MissingMethodException: No signature of method: myapp.PasswordResetService.sesMail() is applicable for argument types: (myapp.PasswordResetService$_sendIt_closure1) values: [myapp.PasswordResetService$_sendIt_closure1@21620546]
Possible solutions: sesMail(groovy.lang.Closure)

Here is a way to workaround the issue:

inject sendSesMail

def sendSesMail

use sendSesMail.send

def mailId = sendSesMail.send {...}


[OSX Template] Updated Edit menu to include items generated by Xcode

Add Find, Spelling and Grammar, Substitutions, Transformations, Speech sub-menus to Edit

Thanks! :)


chore: cleanup

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to
change)
[x] Cleanup

Description

Typo fixes
Remove unused parameters
Simplified where possible

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[x] All new and existing tests are passing.

Codecov Report

Merging #4529 into dev will decrease coverage by <.01%.
The diff coverage is 70%.

@@            Coverage Diff             @@
##              dev    #4529      +/-   ##
==========================================
- Coverage   91.09%   91.08%   -0.01%
==========================================
  Files          61       61
  Lines        2190     2188       -2
  Branches      528      528
==========================================
- Hits         1995     1993       -2
  Misses        177      177
  Partials       18       18

Impacted Files
Coverage Δ

packages/config/src/options.js
94.36% <ø> (ø)
:arrow_up:

packages/webpack/src/builder.js
93.68% <ø> (ø)
:arrow_up:

packages/cli/src/list.js
0% <0%> (ø)
:arrow_up:

packages/webpack/src/utils/postcss.js
94.11% <100%> (-0.12%)
:arrow_down:

packages/webpack/src/config/base.js
95.34% <100%> (ø)
:arrow_up:

packages/vue-renderer/src/spa-meta.js
85.18% <100%> (ø)
:arrow_up:

packages/common/src/utils.js
98.63% <100%> (ø)
:arrow_up:

packages/cli/src/utils/formatting.js
80.95% <100%> (ø)
:arrow_up:

packages/builder/src/builder.js
96.42% <100%> (ø)
:arrow_up:

packages/core/src/resolver.js
86.95% <100%> (-0.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88668f0...653da2a. Read the comment docs.


refactor: 💡 add generics to useForm

This is what I've come up with so far - it seems to be working okay for my tests with SQFormTextField, but not quite right for SQFormDropdown (cc @SeanGroff )
https://www.loom.com/share/579531579466421885d6a3583d68265a
✅ Closes: #337

Thanks you @codyarose for taking on this challenge 🚀 ❤

Thanks you @codyarose for taking on this challenge 🚀 ❤

It's a challenge for sure. The dropdown change handler is really throwing me off

Thanks you @codyarose for taking on this challenge 🚀 ❤

It's a challenge for sure. The dropdown change handler is really throwing me off

When I was reading about this issue, MUI mentioned the onChange for the <Select> component is completely different than the onChange of the rest of the MUI components.
Should we expose a handleSelectChange hook in addition to onChange in the useForm hook? (If we can't solve this challenge with generics)

Should we expose a handleSelectChange hook in addition to onChange in the useForm hook? (If we can't solve this challenge with generics)

I've been trying to implement that for a bit now and thought I had it figured out, but still errors...

I've used the exact props it expects (SelectProps['onChange']) and it still somehow gets
((event: ChangeEvent<{ name?: string | undefined; value: unknown; }>, child: ReactNode) => void) | ChangeEventHandler<HTMLInputElement | HTMLTextAreaElement> | undefined

I'm not sure how the ChangeEventHandler<HTMLInputElement | HTMLTextAreaElement> is getting in there

@SeanGroff The main issue appears to be that Formik expects the onChange to be in one shape and the Mui components expect it to be in another shape. Select passes along a child prop with the event, Checkbox passes along a checked prop with the event, etc... while Formik just expects an event
I think something like this will work:
interface UseFormParam<ChangeEventType> {
  name: string;
  isRequired: boolean;
  onBlur?: React.FocusEventHandler;
  onChange?: (
    event: React.ChangeEvent<ChangeEventType>,
    ...args: any[]
  ) => void;
}

There's a rule to allow any[] on rest parameters, which I think is a valid option because sometimes you can't know exactly what all the parameters will be

https://www.loom.com/share/294836a04eb247c4b43168261b920c16


[Revise subclass] 'TAFRO syndrome'

Mondo term (ID and Label)
'TAFRO syndrome'
Update the label to Castleman-Kojima disease
Suggested revision and reasons
autoimmune disease
to do:
look at papers to see if there is a genetic cause.
If so, add parent Mendelian disease (for a monogenic cause). Can add the gene too (disease has dysfunction in some GENE)

I couldn't find evidence of a gene being involved in this syndrome.


Dont understand the Scenario 2: Error message is received in the Azure Account Center

I read the description of the scenario 2 and dont understand that in order to resolve this issue, the account must be Account Admin or normal account?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 27983d8d-b2af-4b0d-72e5-4aaeebd28c97
Version Independent ID: 4c7b01dc-5bf6-1de6-bcd3-ce5603549609
Content: No subscriptions found error - Azure portal sign in
Content Source: articles/cost-management-billing/manage/no-subscriptions-found.md
Service: cost-management-billing
Sub-service: billing
GitHub Login: @genlin
Microsoft Alias: banders

Thanks for the question. We are currently reviewing this and will update you shortly.

@nguyenbs When you login to Azure Account Center and is prompted with message "No subscriptions are found". Then the scenario indicates to check the Account Administrator of the subscription that you see in Azure portal and tally with the account logged in to Azure Account Center.
In short, only the Account Administrator of the subscription can view the subscriptions in Azure Account Center.
As there are no further documentation changes, we will close the issue for now. If there are further questions , please revert and we will be glad to assist you.


feature request: allow fakes to fallback to RPC calls for un-mocked methods

When testing against a forked mainnet, it's useful to use Fakes to mock responses at a given address. In some cases, you only want to mock the response to some calls to that mainnet address, and for others you want to fallback to the mainnet value.
This is similar to overwriting storage slots with Hardhat, where you overwrite a slot at an address—if you modified a slot locally, Hardhat returns that value, but for all other storage slots if returns the value of the RPC query. Similar functionality for fakes would be very helpful.
My current workaround for this is creating a fake, setting the desired mock response, then setting the mainnet response as the mocked response for other methods. For example:
// Create the fake
const fakeCrvPool = await smock.fake<ICurvePool>('ICurvePool', { address });

// Mock the response to get_virtual_price so it reverts
fakeCrvPool.get_virtual_price.reverts(); // set get_virtual_price() to revert

// "Mock" the response to balances so it returns the current mainnet values
balances.forEach((bal, i) => fakeCrvPool.balances.whenCalledWith(i).returns(bal));

The downside to this approach is that it can become impractical to "mock" the true responses when the number of methods or the range of input values is large
For the syntax, you could add a flag to the smock.fake call which enables or disables this feature, e.g.:
const fakeCrvPool = await smock.fake<ICurvePool>('ICurvePool', { address, fallbackToRpc: true });

hi @mds1 ! a task has been created to address this feature request, i hope there's progress anytime soon.


Remove deprecated IBMEstimator class

What is the expected feature or enhancement?
The IBMEstimator class was deprecated in favor of the Estimator class. It can be now be removed.
Note: IBMSampler was removed in this PR https://github.com/Qiskit/qiskit-ibm-runtime/pull/342 and can be used as an example.

Hello @rathishcholarajan . Can you please assign me to these issues #359 and #364 as well for the future. I know that these issues are currently on hold due to the Qiskit version policy but I surely would love to solve these issues as well.

@bopardikarsoham I am not able to assign external collaborators. Thank you very much. You could create the PRs and we'll leave it on hold until 0.6.0.

Fixed by https://github.com/Qiskit/qiskit-ibm-runtime/pull/363


text doubles with contenteditable

Hi,
when using   {{> afFieldInput type="contenteditable"  name="editor" class="form-control" }} the content duplicates on submit. I know there is a bug with meteor / blaze and a possible solution:
https://github.com/Swavek/contenteditable but i don´t know how to connect it with autoform. Please help.
thanks

"reactive: false" is works as workaround, thanks.

"reactive: false" is works, thanks.

Done in AutoForm 5.0, now released.


Prevent GitOps-managed resources from being edited in the web UI

Towards https://github.com/giantswarm/roadmap/issues/624.
This is the issue tracking the implementation of the specs from https://github.com/giantswarm/roadmap/issues/1176

Closing as a duplicate of https://github.com/giantswarm/roadmap/issues/624


issue: doesn't work with apps that require scancodes, fix within

I was trying to use this with ZSNES and it wasn't working.  I noticed after playing around with Spy++ that it only worked if you send the scanCode
my fix was: add to NativeMethods:
        [DllImport("user32.dll")]
        public static extern uint MapVirtualKey(uint uCode, uint uMapType);

add to InputBuilder::AddKeyDown() the following at the top:
ushort scanCode = (ushort)Native.NativeMethods.MapVirtualKey((uint)keyCode, 0);

and then below change Scan = 0 to Scan = scanCode
If you want I can submit a patch though it's really simple.  However, there may be other places where you need to update it to use the scanCode

I am also facing the same issue with citrix terminal . Key down and key up are not working. I see a pull request by @TChatzigiannakis which seems to address the issue. @michaelnoonan - Could you please look in to that PR #13  and accept the changes?

Having problems with this also, when it is getting accepted as a change??????

@RudiHansen You can use my fork where this issue is addressed.

Thanks @TChatzigiannakis that solved my problem

I think this was fixed, aside from LMENU #27


Staking Contract: Abstract TOKE deposit / withdrawal

There will be many different protocols implemented to FOXy, we need to abstract the functions to be able to add/remove protocols easily

What would be examples of other protocols we could support? I suppose their interface and withdrawal methods would be different from ITokePool ? In other words, do we want to be able to be able to make withdraw/deposit (and also probably abstract balance retrieval) calls from contracts we'll add in the future and which interfaces are unknown ahead of time?

As per our discussion on discord: The methods will be different than TokePool, but it will be fine to hold off on going too deep in planning these calls for only V1


Windows - System Menu doesn't receive keyboard input.

OS:
Windows
Issue Descriptions:
Windows system menu (ALT + SPACE) doesn't receive keyboard inputs.
Version: 4.4.1
Steps to Reproduce:

Open Google Play Music Desktop Player.
Ensure Main UI window is in foreground
Press ALT+SPACEBAR on keyboard, opening the universal Windows' System menu for windows.
Try to press a hot key that would normally work in the menu. E.g. pressing 'N' should minimize the window.
Notice no hotkeys for menu or arrow keys for selecting a menu item work in the menu. Mouse clicking does work, however.

NOTE: This happens in normal and mini player.
My 2 cents: Looks like it could be an electron/input handling issue where every key input is eaten regardless of window modal state.

I wasn't able to reproduce this with great certainty. I actually never knew that alt+space was a thing until trying it just now. However I was able to ctrl+space and press the corresponding letters to get it to work about 95% of the time. Occasionally the window would shift focus and I wouldn't be able to press a letter, or navigate the menu with arrow keys. I am curious however, do you have system window borders, or the themed variant enabled?

Any update on this? Going to close out as a non-issue otherwise.

Automatically closed as tagged Awaiting Response


encoding/decoding base64

This recipe shows how to encode and decode base64 (https://github.com/brson/rust-cookbook/issues/116).
A first (messy) PR was created here. Thanks to @budziq I'm not using the github interface again.

@budziq Thanks!! I fixed it.


CLI 2.45.0 breaks Github Actions that tried to install a specific version of Bicep

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Related command
Run on Github actions
az bicep install --version
az bicep version

Describe the bug
New behaviour (use_binary_from_path) / if_found_in_ci has broken Bicep pinning by users. Coupled with breaking changes in Bicep versions, this has resulted in broken CI production build / deploys.
To Reproduce
From a Github Action
az bicep install --version
az bicep build --file main.bicep
#metadata in published file is no longer the explicitly installed bicep version
Expected behavior
Either document a breaking change (https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/docs-ref-conceptual/release-notes-azure-cli.md) doesn't call this as breaking, or revert it to being intuitive where an explicit az bicep install results in the expected version being used.
Environment summary
Github Runner ubuntu:latest
Additional context
None. This has broken production builds.

route to CXP team

@graemefoster Thanks for the feedback! We will review and update accordingly.
In the meantime, setting the following config value in your scripts should fix build pipelines.
az config set bicep.use_binary_from_path=false


Updating with latest version of Windows SDK

Overview
Link was pointing to preview
Changes

Fixes: # .

Thanks for the change!

/azp run mrtk_docs


Tenant qualified URL support for basic request path authentication

When using basic request path authentication with tenant qualified urls, users in the tenant domain specified in the url context should not be needed to append tenant domain in the login identifier. This is valid for both SaaS and non SaaS apps
Effort BE::15

Tested the basic auth request path authentication flow.
For both SaaS and non-SaaS apps, using tenant qualified URLs, users can login with both usernames with/without tenant appended.
Ex request:
https://localhost:9443/t/foo.com/oauth2/authorize?sectoken=cGV0ZXIxMjM0QGZvby5jb206YWRtaW4=&response_type=code&client_id=tX569N5nzlG1Wfl27kfi8QiTMg4a&redirect_uri=https://oidcdebugger.com/debug&scope=openid

where sec token is base64 encoded username:password of a user in foo.com tenant. Using the username without appending the tenant domain succeeded.
Therefore this issue is fixed now.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Python bindings don't respect CMAKE_INSTALL_PREFIX

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
Any

Firmware Version
N/A}

Operating System & Version
{Linux}

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC

SDK Version
{ 2.50.0 }

Language
{python }

Segment
{Robot/Smartphone/VR/AR/others }

Issue Description
When configuring a build with -DBUILD_PYTHON_BINDINGS=ON, the generated
python libraries are always installed relative to / (e.g., /usr/lib/python3.10/dist-packages), regardless of the value of CMAKE_INSTALL_PREFIX.
Specifying -DPYTHON_INSTALL_DIR manually works around this issue.
I believe the issue is related to how the Python install directory is determined.
In wrappers/python/CMakeLists.txt:64, PYTHON_INSTALL_DIR is set to ${Python_SITEARCH}, which I believe is always an absolute path.
I think the code used for CMake Version <3.12 may not have this issue.

Thanks very much @m-elwin for highlighting this CMake issue to the RealSense community and advising about a manual workaround!

Case closed due to no further comments received.  Thanks again @m-elwin for sharing your workaround!

@m-elwin
First, thanks for your contribution.
But I have to ask, why do you want to override the install directory?
Installation is supposed to put the compiled code in a place where a python import command would see it. Python itself sets this folder and, according to the docs, that's the folder that should be used.
Do you have two different Python installations? Is CMake finding the wrong Python executable?

Wanted to install under my home directory instead of system python directory (which requires root).


Implement a flexible draw line

You can now choose the color of the lines, if its 2d or 3d and if it has to be affected by the depth test or not


Can you share the link to paper?

Hello! Thank you for your interest in our research.
This paper has been submitted to ICASSP 2025.
We do not plan to make the paper public until the results are announced.


⚡  [Feature Request] - Remove Participant in Group

What problem does your feature request solve?
.
Describe the solution you are proposing.
.
Describe alternatives you have considered.
Hi, Could you please add the feature to remove participants from groups, It would greatly help with group management.
Importance
I Need It
Additional Context

[ ] This missing feature presents as a bug.
[X] This missing feature is forcing me to consider alternatives.

https://github.com/aldinokemal/go-whatsapp-web-multidevice/releases/tag/v4.15.0


Fix Spotify authentication

This should fix #2429.
Everyone experiencing this issue is invited to test this fix.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.51%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
453

Relevant Lines:
577

💛  - Coveralls

To be checked https://github.com/mopidy/mopidy-spotify/issues/394#issuecomment-2401706956

Can someone please tell me what i have to do … i dont see the solution here!

Can someone please tell me what i have to do … i dont see the solution here!

Hey @boboschkah , please find the solution here: https://github.com/mopidy/mopidy-spotify/discussions/405

I can't test it, but from my point of view this could be merged.


Option to disable ruby-lsp-rails server-dependent addon features [low-prio]

I have checked that this feature is not already implemented

[X] This feature does not exist

Use case
We employ a Docker setup for our e-learning plattform MaMpf. We make use of the awesome Ruby LSP VSCode extension.
In our logs (Output pane of VSCode), we find that Server dependent features will not be available. This is reasonable due to these lines in the ruby-lsp-rails addon since a connection to our database cannot be established as the database is running inside a Docker container, while the Ruby LSP extension only accesses our local files (in a WSL environment).
Description
As we don't need the server-dependent features of Ruby LSP (*), we propose introducing an option to disable automatic bundling/activation of the ruby-lsp-rails addon/gem such that Ruby LSP does not try to communicate/instantiate our Rails app and instead only relies on static analysis of the code at hand.
(*) Of course, these additional features would be nice to have, but the static analysis is sufficient for us. Or rather, spawning a new Docker container every time one saves a Ruby file would be way too slow. And the setup would evolve quite some effort to get the Ruby LSP commands routed to the Docker container correctly, that we don't see the benefits for right now. And note that development inside a docker container as described in your VSCode extension Readme (section title "Developing on containers") is not an option for us.
Implementation
Include a check in setup_bundler.rb and make it available as flag in the VSCode settings.
Priority
For us, this issue is of low priority, as it's just a warning/error we don't want to see in the logs, but apart from that, everything works fine for us.

Yes, we can indeed run any rails commands (e.g. rails console) inside our "main" docker container using docker compose exec -it (or docker compose run -it to start a new container for interactively executing the specified command).
For RSpec tests, we use the Ruby Test Explorer extension and specify in its settings that it should execute a custom python script when running the tests to make sure they are executed inside a new docker test container. While the execution of the tests itself is quite fast, the startup of the container takes quite a few seconds (haven't measured, but my guess is around 15 to 20s on my i7 4 core, 16 GB RAM machine and that feels like an eternity).
That's just why I fear that even with a customized Rails runner command path for the Ruby LSP extension, we'd rather not use a "dockerized" command as I don't want to wait 15s every time I change something in a Ruby file in VSCode in order to be able to use the features of Ruby LSP. Hence, I think I'd prefer an option to only use static language features of the language server and deactivate the "dynamic" ones that rely on executing actual Ruby commands against the project. Not using Docker at all is not an option for us as it's just too much of a hassle to set up every component of our whole infrastructure individually (e.g. database, mail server and so forth...).

Unfortunately, it fails due to the condition ActionDispatch::Routing::Mapper.respond_to?(:route_source_locations) && ActionDispatch::Routing::Mapper.route_source_locations not being satisfied. And yes, the line you mentioned would probably return an incorrect path that one would have to translate back to the local filesystem path.
I have to be honest and say that the features I deem relevant for a nice development experience already come shipped with Ruby LSP, even without ruby-lsp-rails, i.e. getting semantic highlighting, jumping to definitions, seeing an outline, getting documentation links etc. While the extra features provided by Ruby LSP Rails would be nice to have, personally I can live without them. Having setup our app in Docker containers, it's of course more effort to get Ruby LSP Rails to work nicely if communication has to happen with the Rails app.

We previously did offer a way to disable the server addon features via an initializer but we deprecated it when we changed the server approach in https://github.com/Shopify/ruby-lsp-rails/pull/256. We can considered making that option available again if necessary.

I feel like that'd be the preferred way for us based on my first little experiments here. If you could make this option available again somehow, it'd be much appreciated. For now, we will continue to ignore the Server dependent features will not be available message and the accompanying error in the logs.

(I'll move this to the ruby-lsp-rails repo since that's where the change would be needed)


Use go.mod go version as a single source of truth of Ginkgo version

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We currently use different versions between the ginkgo binary and the ginkgo library.
So, I modified Makefile to use the same version for the ginkgo across the whole of this repo.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

None

/lgtm
/approve