KIWI-1503 Dynatrace Integration

Proposed changes

What changed

Why did it change
KIWI-1503 Dynatrace Integration
modified:   template.yaml

Issue tracking

KIWI-1503

Checklists
Environment variables or secrets

[ ] Documented in the README
[ ] Added screenshots to show the implementation is working
[ ] Ran cfn-lint on any SAM templates

Other considerations

should be fixed now


feat: add tooltips to markets

Description
Fixes #461
Related issues

#503
#448

Motivation and Context
This PR uses the new custom tooltip introduced in #503 to add tooltips to the PositionCard and MarketDetails components
How Has This Been Tested?
Performed simple QA testing on the MarketDetails component:

Is the new tooltip text being displayed?
Is the text in the tooltip correct?
Are there any noticeable bugs/issues?
Is each tooltip text added to en.json?

I did not test the PositionDetails component because I did not have any positions open to test with
Screenshots (if appropriate):
Screen recording of Tooltips working on MarketDetails component:
https://user-images.githubusercontent.com/99768011/168385406-e5d10f0a-ac96-4766-8594-4b410657901f.mov

Hey, on a first glance it looks good!
The tooltips in the PositionCard however seem to have a transparent background compared to those in the MarketDetails card, making them difficult to read. We should make sure they're the same (taking MarketDetails tooltips as a base)

@0xwontonsoup thanks for the fixes!  One last lint warning I noticed, kindly have a look at https://github.com/Kwenta/kwenta/pull/844/files#diff-318ad35f575da4bd3219252cf8285104f303d984b319470acf46ec44d444f4d6L217

Seems like tooltips for "Net Funding" and "Unrealized PnL" on the PositionCard are missing.

The code looks good. Added a comment related to tooltip presets vs custom styles. It's a bit of a nitpick, but it makes the Tooltip component a little less complicated. Also think that React.ReactNode might be a bit more consistent with existing code than JSX.Element.

@koredefashokun When i use React.ReactNode i get an error saying that data can be null

@0xwontonsoup My bad. Looks good.


Created header view component for using across other screens.

Created header view to use in all other view in the app.
This view can be created by passing urls for background image and the foreground image,
Local asset images aren't supported at the moment, if needed can be amended.
We need some default images to show, if there is any error occurred on the remote image fetching.
Preview screenshot below.

@kannanprasad87  above commit is just fixing the merge conflicts 👍🏻


[WIP]Ci/pre release

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: cristianciutea:white_check_mark: Noly:x: cciuteacciutea seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: cristianciutea:white_check_mark: Noly:x: cciuteacciutea seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


added files to be ignored during export

Additional files to be ignored during export:

.docheader
CONDUCT.md
CONTRIBUTING.md
README.md
CHANGELOG.md

@gabbydgab can you rebase? I changed the target to develop on purpose.

@Ocramius updated from upstream develop

Eh, no, that's a merge :-\

@Ocramius sorry about that.. fixed rebase.. thanks

Why excluding important documents (CONDUCT, CONTRIBUTING, README, CHANGELOG) from tarballs?
Same in zendframework/zend-expressive-zendrouter#17

@xtreamwayz
For consumer - may be irrelevant (except for change logs; if affected by X.Y.Z release)
For contributor - needed as guide.
If they experience BC breaks/bugs during updates, most of them look at the package repository and not in the vendor folder.
IMO, it will be much effective if release information will be added on composer.json  similar to suggestions because it explicitly explains the updated version of the dependency - maybe new composer feature? :thinking:
"changes": {
    "added": ["new features"],
    "deprecated": ["notices"],
    "removed": ["removed"],
    "fixes": ["bc fixes or not"]
}

Thoughts?

Have you seen some of the changelogs? Besides issues with formatting, I don't think you want all that info in composer.json.

Yes, but probably will just add a summary link pointing to those non-critical impacts. ONLY critical impacts like BC changes will be added, others will be a summary link.

I'll merge, but with the following changes to no longer exclude the following files within .gitattributes:

CHANGELOG.md
README.md

These are user-facing files, and contain information that users may want/need to reference. While they may end up going to the repository website, this puts information at their fingertips immediately, and without requiring a network connection.

Thanks, @gabbydgab


Grafana pod never created

With this CR
apiVersion: integreatly.org/v1alpha1
kind: Grafana
metadata:
  name: monitoring-grafana
spec:
  ingress:
    enabled: False
  config:
    log:
      mode: "console"
      level: "warn"
    security:
      admin_user: "admin"
      admin_password: "admin"
    auth:
      disable_login_form: False
      disable_signout_menu: False
    auth.basic:
      enabled: True
    auth.anonymous:
      enabled: True
  dashboardLabelSelector:
    - matchExpressions:
        - {key: app, operator: In, values: [grafana]}

The grafana svc is present but the grafana pod is not created.
Here are the operator logs :
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.359364,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:256","msg":"Phase: Create Config Files"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.3632724,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:452","msg":"Resource grafana-serviceaccount does not exist, creating now"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.3850758,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:286","msg":"Creating the grafana-dashboards resource"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.3909838,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:452","msg":"Resource grafana-dashboards does not exist, creating now"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.3993938,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:286","msg":"Creating the grafana-providers resource"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.4050183,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:452","msg":"Resource grafana-providers does not exist, creating now"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.4121027,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:286","msg":"Creating the grafana-datasources resource"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.4180439,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:452","msg":"Resource grafana-datasources does not exist, creating now"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.4305937,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:286","msg":"Creating the grafana-service resource"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.4351752,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:452","msg":"Resource grafana-service does not exist, creating now"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.4587262,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:293","msg":"Config files created"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.4808128,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:256","msg":"Phase: Create Config Files"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.5761788,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:286","msg":"Creating the grafana-dashboards resource"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.7659416,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:286","msg":"Creating the grafana-providers resource"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350508.965594,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:286","msg":"Creating the grafana-datasources resource"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350509.1760461,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:286","msg":"Creating the grafana-service resource"}
grafana-operator-c59c5b98c-vrbfd grafana-operator {"level":"info","ts":1576350509.3649647,"logger":"controller_grafana","caller":"grafana/grafana_controller.go:293","msg":"Config files created"}

Hey @yogeek , judging by the logs it looks like you're running an older version of the operator but the provided CR looks fine and should work. My guess is that the deployment is created, but fails to create the Grafana pod for some reason. So best to debug the deployment first. What's the output of:
kubectl get deployments -n <your namespace>
and
kubectl describe deployment <name of the grafana deployment from previous command> -n <your namespace>?

About the version, I installed the last release : v3.0.1.
So you want me to test with the master branch instead ?
Currently, the deployment is not there, only the service is created :
# No grafana deployment
kubectl get deployments -n monitoring | grep grafana
NAME                  READY   UP-TO-DATE   AVAILABLE   AGE
grafana-operator      1/1     1            1           3m12s

# No grafana pod
k get po --all-namespaces| grep grafana
monitoring     grafana-operator-6d49c98cd4-b2jth                                         1/1     Running     0          4m59s

# Grafana service is ok
k get svc --all-namespaces| grep grafana
monitoring     grafana-service          ClusterIP      <IP_ADDRESS>   <none>                                                                             3000/TCP                                     3m29s

3.0.1 is fine, but the logs you showed appear to be from an older version. So maybe there's something wrong with the operator deployment or the image? Can you confirm that the grafana-operator deployment points to the 3.0.1 image?

Additionnal info : when I install the operator from OpertorHub like this :
curl -sL https://github.com/operator-framework/operator-lifecycle-manager/releases/download/0.13.0/install.sh | bash -s 0.13.0

kubectl create -f https://operatorhub.io/install/grafana-operator.yaml

I works correctly !!!
What release has been published to OperatorHub ? It is not the last release of your github repo ?

Installation from OperatorHub :
kubectl get deploy grafana-operator -o=jsonpath='{$.spec.template.spec.containers[:1].image}'
quay.io/integreatly/grafana-operator:v2.0.0

Installation from manifests :
kubectl get deploy grafana-operator -o=jsonpath='{$.spec.template.spec.containers[:1].image}'
quay.io/integreatly/grafana-operator:latest

When I look at https://quay.io/repository/integreatly/grafana-operator?tab=tags, I have different tags :
docker images | grep quay.io/integreatly/grafana-operator
quay.io/integreatly/grafana-operator                                                    v3.0.1              73391e6c9576        4 days ago          45.8MB
quay.io/integreatly/grafana-operator                                                    v2.0.0              b9a8bae9ac63        2 months ago        47.2MB
quay.io/integreatly/grafana-operator                                                    latest              abaa4cf3c673        2 months ago        43MB

It seems that your operator.yaml points to latest tag which is different from the V2.0.0 of the OperatorHub and also different from the 3.0.1 you told me about.

Ah I see. The latest tag hasn't been updated, best to make sure you're selecting a specific tag in operor.yaml. Also, operatorhub is not yet updated with 3.0.1. You can find all the available tags here: https://quay.io/repository/integreatly/grafana-operator?tab=tags
Does it work when you install 3.0.1?

@pb82 I can confirm that using the 3.0.1 tag is working ! Thank you for your help
I use kustomize to modify the release manifests for now but it would be great if you could either update the tag in the operator manifest or push the latest tag corresponding to the last image.
Plus, how is managed the publication to the operatorhub ? Each release is not deployed currently ?

@yogeek We are aiming to update the operatorhub release, just wanted to wait a bit to fix incoming bugs with the new version. I'll also update the latest tag.

I've updated the latest tag now. Closing this issue as the original problem has been resolved.

@pb82 Thank you. Did you update it manually because I do not find the corresponding  docker push in your travis CI file

@pb82 is the latest tag up to date now please ? (cf. previous message)

Yes, I pushed it manually. It should be up to date now.

Thank you 👍
Is it possible to add it in your .travis file to avoid you to do it manually ?


[FEATURE] Run benchmark --model-list in subprocess

Is your feature request related to a problem? Please describe.
While doing benchmark on timm-models with benchmark.py, I tried the following two ways:

python benchmark.py --model-list _models.txt -b 128
python benchmark.py --model xception -b 128

where _models.txt is a text file that contains 65 different models, including xception on the last line.
Due to possible pytorch memory allocation fragmentations, when the first command executes xception model, available GPU memory could be much smaller than the second command's equivalent. This may cause cuDNN convolution to choose a more conservative but slower method.
(I've seen plenty of pytorch CUDA OOM warnings using command 1 on an A100 40GB GPU. 😨 )
As a result, for xception model, on A100, with pytorch source build https://github.com/pytorch/pytorch/commit/cd51d2a3ecc8ac579bee910f6bafe41a4c41ca80, cuda 11.5 + cudnn next version of 8.2.4, I got

Benchmarking in float32 precision. NCHW layout. torchscript disabled
Model xception created, param count: 22855952
Running inference benchmark on xception for 40 steps w/ input size (3, 299, 299) and batch size 128.
Infer [8/40]. 754.69 samples/sec. 169.605 ms/step.
Infer [16/40]. 754.71 samples/sec. 169.601 ms/step.
Infer [24/40]. 754.74 samples/sec. 169.596 ms/step.
Infer [32/40]. 754.74 samples/sec. 169.595 ms/step.
Infer [40/40]. 754.74 samples/sec. 169.595 ms/step.
Inference benchmark of xception done. 754.65 samples/sec, 169.59 ms/step
Model xception created, param count: 22855952
Running train benchmark on xception for 40 steps w/ input size (3, 299, 299) and batch size 128.
Train [8/40]. 267.01 samples/sec. 479.391 ms/step.
Train [16/40]. 266.97 samples/sec. 479.463 ms/step.
Train [24/40]. 266.96 samples/sec. 479.476 ms/step.
Train [32/40]. 266.96 samples/sec. 479.480 ms/step.
Train [40/40]. 266.95 samples/sec. 479.488 ms/step.
Train benchmark of xception done. 266.37 samples/sec, 479.49 ms/sample

Benchmarking in float32 precision. NCHW layout. torchscript disabled
Model xception created, param count: 22855952
Running inference benchmark on xception for 40 steps w/ input size (3, 299, 299) and batch size 128.
Infer [8/40]. 1219.51 samples/sec. 104.960 ms/step.
Infer [16/40]. 1219.10 samples/sec. 104.996 ms/step.
Infer [24/40]. 1219.20 samples/sec. 104.987 ms/step.
Infer [32/40]. 1218.06 samples/sec. 105.085 ms/step.
Infer [40/40]. 1218.27 samples/sec. 105.067 ms/step.
Inference benchmark of xception done. 1217.86 samples/sec, 105.07 ms/step
Model xception created, param count: 22855952
Running train benchmark on xception for 40 steps w/ input size (3, 299, 299) and batch size 128.
Train [8/40]. 308.69 samples/sec. 414.653 ms/step.
Train [16/40]. 308.69 samples/sec. 414.651 ms/step.
Train [24/40]. 308.70 samples/sec. 414.648 ms/step.
Train [32/40]. 308.69 samples/sec. 414.654 ms/step.
Train [40/40]. 308.69 samples/sec. 414.655 ms/step.
Train benchmark of xception done. 307.78 samples/sec, 414.65 ms/sample

It is seen that the first command gives smaller throughput than the second command.
Describe the solution you'd like
Run benchmark --model-list in subprocess. A bash script with for-loop doing python benchmark.py --model x -b 128 would already be good.
A subprocess guarantees GPU memory recycling. Though it's slower and introduces overhead, several seconds of overhead is not a big problem because it introduces more accurate benchmark.
The better way would be doing this in the benchmark.py script natively. Somehow, doing --model with a single mode doesn't create a benchmark.csv file that summarizes the results. I will need to collect it manually if using the bash for-loop solution.
Describe alternatives you've considered
I tried to add code here but it doesn't help.
    gc.collect()
    torch.cuda.empty_cache()

https://github.com/rwightman/pytorch-image-models/blob/aaff2d82d06109703a06aca2c0c20815b9d46cbb/benchmark.py#L493-L494
Additional context
This issue started to appear since around 10/22/21. It might be changes from pytorch or cuda libraries. Since using subprocess resolves this issue, it's beneficial to have that.
Timm-models is git clone'd from github at a41de1f666f9187e70845bbcf5b092f40acaf097
cc @ptrblck

@xwang233 it's definitely related to specific pytorch and cuda / cudnn releases, I have to stick to ones that work to get through, recently I found that the release 1.10 was pretty decent for a cuda 11.x release, the 10.x were generally quite a bit more reliable for this sort of use case (I do the same thing batch validating a large amount of models).
I do agree though, for reliability I should do each model in a separate process so I don't screw up the cuda context. Actually I need to do this for PyTorch XLA (TPU) benchmarking soon so I do plan to come up with a way of doing this for validate.py and benchmark.py

bulk_runner.py does this, been using it for mass benchmark and validation for a while


Disable detailed warnings on CI builds

This should help to avoid failures on Travis CI (and possibly others):

The job exceeded the maximum log length, and has been terminated.

Tasklist

[ ] All CI builds and checks have passed

@stefanseefeld Having more and more tests, I'm afraid, we have no other choice. I also think it's more practical to observe and resolve those extra warnings locally, than based on CI logs. Let's stick to CI providing us with boolean green/red status

@mloskot yes, I agree.

The branch builds on my Travis CI: https://travis-ci.org/mloskot/gil/builds/497270642
It also builds fine on AzP and AppVeyor.
I'm merging without waiting long hours for the boostorg's Travis CI.


add auth for relayhost

After a couple of searches I found a way to send mail through SMF_RELAYHOST that require login, and got it working.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you very much for your contribution!
Cloud you please:

document your new feature in README, so that the users could be able to learn how to use it?
indent your shell code correctly with the original code.

done

also accidentally found a fix for mail log not displaying, so attaching it here

Great work!
Appreciate for the fix & improvement.

no worries, just needed to get this work so i can cancel my mailgun subscription heh (:


format-on-save seems to break plugins such as linter-eslint

I'm here to report an unexpected interaction, between atom plugins, that I notice while using both prettier-atom and linter-eslint.
If you enable prettier-on-save and save a document, it'll cause linter's inline error highlighting and gutter icons to break. They'll disappear until you continue typing again, etc. I believe it's the prettier-atom plugin changing the text that causes the linter plugin to no re-draw its inline error icons, etc.
I had initially opened an issue about this on linter's repository. Through that issue, I feel as though I have narrowed this issue down to prettier-atom's format-on-save feature. I asked, there, about what prettier-atom could do to perhaps play more nicely with the linter plugin (ideally any other plugin that would need to know to re-draw stuff, but in this specific case just linter). It was suggested, in my linter issue, that prettier-atom could trigger linter:lint command on the text editors after prettier-atom is done with them.
 So, with that said, I just wanted to open this issue so that a discussion can happen as to how to make this plugin be a bit friendlier to other plugins that have drawn stuff on text editors, etc.

@ryancole Oh I've been noticing this as well, but couldn't figure out why it was happening.

Now, I can see this fix being a slippery slope in your eyes, because it'd suck to get into a situation where prettier-atom needs to trigger commands from all other plugins, etc

True, but because we specifically have an ESlint integration, I think fixing unexpected linter-eslint problems should be considered in-scope for this repo. If it was some obscure unrelated package then I might be more wary of trying to fix it. I will mark this as a bug and hopefully come up with a fix soon.
Thank you so much for taking the time to investigate this and link the discussions.

Just a side note that if you trigger the linter:lint command on the editor, it'll fix this issue for not just ESLint, but all of the linter providers

@steelbrain roger that, good to know, I'll make sure to use that more generic command and not a linter-eslint-specific command


Connect to gitcoin

How do I connect to gitcoin and increase my human score?

How do I connect to gitcoin and increase my human score? Please

How do I connect to gitcoin and increase my human score?

How do I connect to git coin increase my human score?

How do I connect to git coin increase my human score?

go for www.gitcoin.com thats it

How to increase gitcoin human score?

how to increase gitcoin human score ???


My Profile Page - Remove Buttons

Web Path
Home Page -> John Doe -> My Profile

Requirement
Remove Delete and Cancel buttons

This issue was moved to Code4SocialGood/c4sg-web#54


Switch to improved citation formatting in pandoc 2.11

pandoc 2.11 introduced citation processing as an internal feature. Apart from being included in the package, it also improves the formatting and is therefore superior to the prior pandoc-citeproc feature.
However, updating is currently blocked by pantable not supporting pandoc > 2.9.

I've updated to pandoc 2.11 in 95ddede43ac01b64ce17a727cb86e6ef562b08e8, but there's currently an incompatibility between pantable and tablenos.

See #23 for the above-mentioned problem. Apart from that, this issue has long been solved.


why add "novalidate" to the form?

I would like to combine jquery.validation with HTML5 validation (use HTML5 for basic stuff and jquery.validation for complex things like checking upload file sizes etc).
But jquery.validation has silently (!) added novalidate attibute to my form, I had to spend 20 minutes debugging why my pattern attributes have stopped working.
Please consider removing, otherwise this is obtrusive, non-obvious "easter-egg" behavior.
Thanks for considering.

See https://github.com/jquery-validation/jquery-validation/pull/7 for context


Changing query name reset all the settings

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
All my options are lost, transformation, params, etc.
Expected behavior 🤔
The dialog keeps all the options set.
Steps to reproduce 🕹
Steps:

Open https://master--toolpad.mui.com/_toolpad/app/cl7z6bymv24562awr0skxffqio/pages/ne1a0zn
Click Add query
Pick a "Fetch | default"
Add https://api.github.com/repos/mui/mui-x/issues in the get URL.
Focus the name field
Change the value
Blur the field 💥

https://user-images.githubusercontent.com/3165635/195729389-0aeed02e-e5f3-4ea9-9c35-b8e49f389ad9.mov
Context 🔦
I face this problem while I was building a quick UI for Greg to help us with the support on GitHub https://www.notion.so/mui-org/Set-GitHub-scope-labels-12a84fdf50e44595afc55343dac00fca#3f39c7660fc448b1a6c0f554a29a5ce2. If you are interested about the other pains I faced but I didn't open issues for you will find:

Duplicate queries https://github.com/mui/mui-toolpad/issues/1172
Data grid column type link (see Metabase for an example) https://github.com/mui/mui-toolpad/issues/827
Undo (I pressed the Recrete columns icon button by mistake) https://github.com/mui/mui-toolpad/issues/226
Support for the size prop with the button to be smaller.

But I only open an issue for my biggest pain. BTW, I love the new query UI. Building the whole UI felt fast, I'm not sure I would have been quicker the pro-code way;
Your environment 🌎
v0.0.22

I think this has the same root cause as https://github.com/mui/mui-toolpad/issues/1126. Tackling https://github.com/mui/mui-toolpad/issues/1126 should solve this issue as well.

it's related. The name change input operates directly on the dom (it uses a shared component that's used throughout Toolpad). The rest of the dialog operates on a draft copy. when the dom changes the draft copy gets updated to the actual value in the dom. That's why changing the name resets the fields.
Solution: the name change input needs to operate on the draft copy as well. The part that's slightly tricky will be about how to deal with duplicate names.

@Janpot I assigned this to myself because I thought I could take it but let me know if you think you should take it instead, I can find other tasks.

I was going to take it but wanted to merge https://github.com/mui/mui-toolpad/pull/1149 first
I'll close this ticket as a duplicate of https://github.com/mui/mui-toolpad/issues/1126


Adding functionalities

Adding several other relevant functionalities to the code .

i want to work on this issue

i want to work on this issue

I want to contribute

I want to contribute

Assigned to @rbhack12 and @Avik47 , try to be as innovative as you can and bring out different functionalities

Assigned to @rbhack12 and @Avik47 , try to be as innovative as you can and bring out different functionalities

would like to contribute in it..

would like to contribute in it..

sure, assigned to @shagun25 as well. Let me know the functionalities before implementing

sure, assigned to @shagun25 as well. Let me know the functionalities before implementing

I want to contribute

I want to contribute

go ahead @shivangisahay14

go ahead @shivangisahay14

I want to contribute to this project!


[ENH] Optimize arbitrary accesses and len() on ctuples and python tuple constants

Is your feature request related to a problem? Please describe.
The length of a ctuple is known at compile time, however Cython doesn't optimize len() on a ctuple and instead converts it to a python tuple at runtime. This optimization could also be made for constant python tuples.
Example:
cdef int test((int, int, int) v):
    return len(v)

Example 2:
cdef int test(a, b, c):
    return len((a, b, c))

Arbitrary access of an element of a ctuple results in it being convert to a python tuple first. A switch statement of all indicies could be used instead.
Example:
cdef int test((int, int, int) v, int i):
    return v[i]

Describe the solution you'd like.
No response
Describe alternatives you've considered.
No response
Additional context
No response

I understand that item access should be fast, but len()? What is the use case for calling len() on a ctuple?

Presumably things like fused types, where there are a few different possible lengths to deal with so it can't be hard coded?
Arbitrary item access is probably trickier in general because "ctuple with all items of the same type" really isn't a typical use case.

I understand that item access should be fast, but len()? What is the use case for calling len() on a ctuple?

I use a macro to get a random element of a constant tuple. Randint requires the number of elements and thus len().


structure of err returned should be documented

The README shows err being returned in a few places, but as far as I noticed an sample a value that err might contain is never shown.
Some Node modules put a string in this value, while some return structured objects. It would be helpful to know what type of values this module is returning via err. If objects are returned, it would be helpful to know if the returned error objects follow any particular structure.

In my first test, the error I got back with a JavaScript Error object.


Live Ping of server

Have you considered doing a ping of the plex server on the plex port to see if the server is available then letting that change the image as needed?
On fail it could give a red screen and on success it could be the green one; while waiting the screen could be yellow.
ping via JS
https://github.com/alfg/ping.js

I tried to implement this but was unable to configure it. It would be a great idea though. I've added a server offline image to the assets if you want to give it a shot.

Perhaps try something like this?
http://jsfiddle.net/EldonMcGuinness/gcgww53p/1/

I don't have time to work on this right now. I wouldn't mind if you want to go ahead and contribute by creating a pull request. If not, I will work on it over the weekend and update you here.

I just added a PR to the ping.js dev's branch as I added a timeout option to it. This will make the server come back as down if the time it takes exceeds a specified interval. You can find the updated JS in his repo here
You can see it in action with this fiddle:

I've been working on some PHP by modifing the orignal template a tiny bit.  All it's doing now is check the server status by using the Plex API as well as mapping the libraries and their keys.  I'm also hiding the navbar if it's down so the only thing that shows up is the error image.  It's admittedly kind of hacked together at the moment as I just wanted to get something simple together.  It can take a while to load if the library is large, though because of the large xml responses.  Haven't found a lightweight method to get the library counts without going to http://server:32400/library/sections//all  Any interest in that?

Hiding the navbar would be easy with the addition of the ping script in this PR, but I think displaying counts and the like are a bit much for a page that is not login protected. I would rather save that for the user to see once they have logged in.

@EldonMcGuinness I've added your code to the git and a new orange checking img. Thank you for your help. If you could just add the orange img now I would really appreciate it.

@cwire4 Like @EldonMcGuinness said, I don't think displaying that type of info without a protected website is ideal. Since this website is technically only for users, they can see that info once they log in to their Plex account.

@ITRav4 done


[SPARK-20409][SQL] fail early if aggregate function in GROUP BY

What changes were proposed in this pull request?
It's illegal to have aggregate function in GROUP BY, and we should fail at analysis phase, if this happens.
How was this patch tested?
new regression test

cc @gatorsmile

Test build #75985 has started for PR 17704 at commit 87619eb.

Test build #75985 has finished for PR 17704 at commit 87619eb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75985/
Test PASSed.

LGTM - merging to master/branch-2.2

Also cherry picked this into 2.1


The auto prompt disappears after the update

Issue Type: Bug
It still doesn't work after configuration. Python doesn't prompt anything, it doesn't have syntax hints.
VS Code version: Code 1.47.1 (485c41f9460bdb830c4da12c102daff275415b53, 2020-07-13T22:42:53.386Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz (4 x 2712)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
3.90GB (0.74GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

arepl
alm
1.0.24

vscode-eslint
dba
2.1.8

vscode-language-pack-zh-hans
MS-
1.47.3

csharp
ms-
1.22.1

python
ms-
2020.7.94776

markdown-all-in-one
yzh
3.1.0

Please file this issue on the vscode-python extension's repo: https://github.com/microsoft/vscode-python/issues
And please include more details


Extra  tags are breaking bootstrap's buttons, labels, etc

Hi,
I've started using this library recently but I've seen that many things get broken, especially when using Twitter's bootstrap like "buttons", "labels", etc because it adds an extra  tag and hence the CSS does not correctly apply to it.
Is there any way to fix this? Maybe an option during configuration phase that it shouldn't add extra  tags?
Thanks!

Have you tried angular 1.6? It looks like they might have taken care of the span tags in 1.6. I've not had time confirm it.

Angular 1.6 fixes the span issue. See:
Spans in 1.5.9: http://plnkr.co/edit/tKloB8LFk3GCAsu0UEUx?p=preview
No spans in 1.6.0: http://plnkr.co/edit/tE96QrOPtqxuxR4xbxRL?p=preview

Yes, upgrading to angular 1.6 resolves this issue for good! thank you so much @circlingthesun for the updates!


When using epoll to listen on multiple uring_fds, occasionally, when an event occurs on a uring_fd, it may not wake up the epoll.

When using epoll to listen on multiple uring_fds, occasionally, when an event occurs on a uring_fd, it may not wake up the epoll.
Scenario:
Using epoll_wait to monitor multiple uring_fds. When submitting io_uring_prep_nop to one of the uring_fds, sometimes epoll is not awakened. a very mysterious bug.  By proactively peek the uring, can peek at the nop_sqe that was submitted earlier.

Do you have a reproducer for this? I can certainly take a look, but would save me a lot of time if I didn't have to write a reproducer first.

Please include a comment on when you close an issue. Was it a problem in your application?

关闭问题时请添加评论。您的应用程序中存在问题吗？

the qs  is must new uring in newthread,

or you can create it with IORING_SETUP_R_DISABLED, pass the ring to your final task/process and enable it there using IORING_REGISTER_ENABLE_RINGS.


[Fixed] $minLat was undefined in cos() arg

$minLat was undefined in cos() arg here.
And removed the redundant commented code.

👍


Duplicate keys in object literals have inconsistent behavior

This behavior is slightly different from the C jq (jq-1.7).
$ jq --version
jq-1.7

$ gojq --version
gojq 0.12.13 (rev: HEAD/go1.20)

$ jq -n '{a: 1, a: {b}}'
{
  "a": {
    "b": null
  }
}

$ gojq -n '{a: 1, a: {b}}'
{
  "a": 1
}

However, gojq is consistent with jq-1.7 if I write a: {}, a: {b: "b"}, a: {b: null}, etc instead.
I also reproduced this case with a non-null expression, but I cannot provide the exact reproducible case since that query contains something personal, and I am unable to reduce the other case into an {"a": 1} output.

$ gojq -n '{a: 1, a: {b}}'
{
  "a": 1
}

$ gojq -n '{a: 1, a: {b: .b}}'
{
  "a": 1
}

$ gojq -n '{a: 1, a: {b: {c}}}'
{
  "a": 1
}

$ gojq -n '{a: 1, a: {b: length}}'
{
  "a": 1
}

$ gojq -n '{a: 1, a: {b: null}}'
{
  "a": {
    "b": null
  }
}

$ gojq -n '{a: 1, a: {}}'
{
  "a": {}
}

Based on the above experiments, my hypothesis that gojq uses the latter value if it is a literal, and uses the former value if it involves any dynamically resolved data.

It seems that I didn't expect this case when implemented the executor but I'll fix soon. Constant folding makes it working correctly.

Haven't had time to reduce a minimal reproducible example yet, but I think there is another similar issue with the order of object keys as well; I just reproduced a case where gojq does not correctly preserve object key order when adding two objects, while jq does it correctly.


Inverse horizontal mouse look in the editor

Inverse horizontal mouse look in the editor
Description

In the settings under: File->Settings->Editor->Navigation for Navigation mode Orbit, there is an option to invert vertical mouse look. It would also be nice to also have the option to invert the horizontal mouse look as well.

This is definitely necessary, also including a code controller (allowing users to revert it under any "game settings", if preferred)


Adds directories and share data tutorial

Organized existing tutorials into directories based on the action performed. Added a new tutorial notebook to share one dataset (GET and PUT operations).
Closes #4

Reviewed - looks good.


text input bar and right button unresponsive

Description

Hey I'm unable to get the text input bar and "Right Button" working. I've only been able to activate the text input bar manually.  It was working fine with ios10 and now not working on ios11. I set it up exactly like the example. Anyone else experiencing something similar or have a workaround?

 Just need to bring them to front.
For example: self.textInputbar.bring(SubviewToFront:self.textInputbar.rightButton)
see #604


check notebooks

workflows are currently run here: https://github.com/zacharyburnett/tutorials/actions/workflows/test.yml

python -m nbcollection execute .

[nbcollection (INFO)]: Collected 7 notebook files
[7](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:8)
[nbcollection (INFO)]: Finished running notebook 'Anatomy_of_an_ASDF_file.ipynb' (8.13 seconds) ✅
[8](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:9)
[nbcollection (INFO)]: Finished running notebook 'Validation_and_Dealing_with_Errors.ipynb' (1.10 seconds) ✅
[9](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:10)
[nbcollection (ERROR)]: Notebook 'Your_second_ASDF_converter.ipynb' errored ❌
[10](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:11)
[nbcollection (ERROR)]: Notebook 'Your_first_ASDF_converter.ipynb' errored ❌
[11](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:12)
[nbcollection (INFO)]: Finished running notebook 'Reading_a_JWST_ASDF_file.ipynb' (119.88 seconds) ✅
[12](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:13)
[nbcollection (INFO)]: Finished running notebook 'High_Level_Introduction_to_ASDF.ipynb' (1.17 seconds) ✅
[13](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:14)
[nbcollection (INFO)]: Finished running notebook 'ASDF_and_World_Coordinate_Systems.ipynb' (5.97 seconds) ✅
[14](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:15)
[nbcollection (ERROR)]: Notebook 'Your_second_ASDF_converter.ipynb' errored: An error occurred while executing the following cell:
[15](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:16)
------------------
[16](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:17)
import numpy as np
[17](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:18)
import asdf
[18](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:19)
from myconverters.photo_id import PhotoID
[19](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:20)
from myconverters.traffic_citation import TrafficCitation
[20](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:21)
------------------
[21](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:22)
[22](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:23)
---------------------------------------------------------------------------
[23](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:24)
ModuleNotFoundError                       Traceback (most recent call last)
[24](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:25)
Input In [38], in <cell line: 3>()
[25](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:26)
      1importnumpyasnp
[26](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:27)
      2importasdf
[27](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:28)
----> 3frommyconverters.photo_idimport PhotoID
[28](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:29)
      4frommyconverters.traffic_citationimport TrafficCitation
[29](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:30)
[30](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:31)
ModuleNotFoundError: No module named 'myconverters'
[31](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:32)
ModuleNotFoundError: No module named 'myconverters'
[32](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:33)
[33](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:34)
[nbcollection (ERROR)]: Notebook 'Your_first_ASDF_converter.ipynb' errored: An error occurred while executing the following cell:
[34](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:35)
------------------
[35](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:36)
import asdf
[36](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:37)
import numpy as np
[37](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:38)
import mfconverter.photo_id as pid
[38](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:39)
image = np.zeros((10,10), dtype=np.byte)
[39](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:40)
p = pid.PhotoID('man', 'invisible', image)
[40](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:41)
af = asdf.AsdfFile()
[41](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:42)
af.tree = {'id': p}
[42](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:43)
af.write_to('test1.asdf', auto_inline=200)
[43](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:44)
------------------
[44](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:45)
[45](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:46)
---------------------------------------------------------------------------
[46](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:47)
ModuleNotFoundError                       Traceback (most recent call last)
[47](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:48)
Input In [18], in <cell line: 3>()
[48](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:49)
      1importasdf
[49](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:50)
      2importnumpyasnp
[50](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:51)
----> 3importmfconverter.photo_idaspid
[51](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:52)
      4 image = np.zeros((10,10), dtype=np.byte)
[52](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:53)
      5 p = pid.PhotoID('man', 'invisible', image)
[53](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:54)
[54](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:55)
ModuleNotFoundError: No module named 'mfconverter'
[55](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:56)
ModuleNotFoundError: No module named 'mfconverter'
[56](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:57)
[57](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:58)
Traceback (most recent call last):
[58](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:59)
  File "/usr/share/miniconda/envs/asdf-tutorial-Linux-py3.10-latest/lib/python3.10/runpy.py", line 196, in _run_module_as_main
[59](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:60)
    return _run_code(code, main_globals, None,
[60](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:61)
  File "/usr/share/miniconda/envs/asdf-tutorial-Linux-py3.10-latest/lib/python3.10/runpy.py", line 86, in _run_code
[61](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:62)
    exec(code, run_globals)
[62](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:63)
  File "/usr/share/miniconda/envs/asdf-tutorial-Linux-py3.10-latest/lib/python3.10/site-packages/nbcollection/__main__.py", line 37, in <module>
[63](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:64)
    main()
[64](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:65)
  File "/usr/share/miniconda/envs/asdf-tutorial-Linux-py3.10-latest/lib/python3.10/site-packages/nbcollection/__main__.py", line 33, in main
[65](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:66)
    commands[parsed.command](args)
[66](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:67)
  File "/usr/share/miniconda/envs/asdf-tutorial-Linux-py3.10-latest/lib/python3.10/site-packages/nbcollection/commands/execute.py", line 24, in execute
[67](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:68)
    nbcollection.execute()
[68](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:69)
  File "/usr/share/miniconda/envs/asdf-tutorial-Linux-py3.10-latest/lib/python3.10/site-packages/nbcollection/converter.py", line 144, in execute
[69](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:70)
    raise RuntimeError(f"{len(exceptions)} notebooks raised unexpected "
[70](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:71)
RuntimeError: 2 notebooks raised unexpected errors while executing cells: ['Your_second_ASDF_converter.ipynb', 'Your_first_ASDF_converter.ipynb'] — see above for more details about the failing cells. If any of these are expected errors, add a Jupyter cell tag 'raises-exception' to the failing cells.
[71](https://github.com/zacharyburnett/tutorials/runs/7456202660?check_suite_focus=true#step:8:72)
Error: Process completed with exit code 1.

The CI doesn't appear to be running on github.

The CI doesn't appear to be running on github.

yes, it's running in the fork but it seems not be running in this repository (perhaps because it's not in the main branch). I'm not sure why that is, but for this PR at least we can see the runs in the fork

Trying close/reopen

Could you add a simple .pre-commit-config.yaml file to this? We can try merging and seeing if we can run the CI then.

Am I reading this right that the CI job to check notebooks is not yet running in the main branch?
Also, there are errors in the 2 notebooks: Your_first_ASDF_converter.ipynb and Your_second_ASDF_converter.ipynb
Both of these notebooks have cells that write files to disk (in a folder created in the home directory). Is this sort of pattern supported by nbcollection?
So far I've been unable to replicate those errors locally and am instead running into other errors.

The problem with these tutorials is when relevant schemas are updated, so do the example files need to be. It's almost like there needs to be a script to reconstruct the example files without manual intervention.


Writing the increment is now optional

Description
Thanks to @fabiolrdiniz 's https://github.com/JCSDA-internal/oops/pull/955, we can now remove the hard-coded writing of the increment in add_increment.
What was done:

By default, the increment is not written. Happy  @travissluka ?
Removed a save statement!
Copy/pasted the increment write example in l95 into soca 3dvar_godas (but I did change the date ... hard work)

The example implemented if for one outer loop only, but the increment can be saved at every outer loop.
Issue(s) addressed
closes #451
Testing
What compilers / HPCs was it tested with? gnu/container
Are the changes covered by ctests? added to the 3dvar_godas ctest

... so the lesson learned here is that if we wait long enough other people will fix our issues?

I'm thinking of making a label out of that comment ... The fakenews one is pretty handy, but a if we wait long enough other people will fix this issue sounds good too. Applies to 50% of the soca issues?


Add NetSurf to browser list

I'm concerned about Chrome's dominance and I want my web sites to support independent browser engines.
NetSurf is one of the more complete and functional independent browser engines, although that's a low bar given the complexity of the modern web, and the browser+engine is under active development. Unlike e.g. Servo, it is a complete web browser, not a disembodied engine.
Their outdated documentation (last updated in 2012 as of now) shows that they are working on support for HTML5, CSS3, and Javascript, and chatting with them in their IRC channel they confirmed that it still lacks support for many features helpful for dynamic layout, such as CSS variables and calc(). I would like to help them update their documentation, but that is irrelevant here.
Supporting independent browser engines like NetSurf would be very helpful for limiting Chrome's dominance, and it would be much easier to support browsers like NetSurf if you could easily check what features it supports on a site like caniuse and plan around their limitations, without having to go to the individual browser's documentation.
I see previous discussion in #4666 that two concerns about including browsers are:

difference from existing browser engines
usage

NetSurf is not based on another browser engine, so it should be sufficiently different from Chrome/Firefox/Safari etc. The primary issue with including it is probably the low number of users.
What is the cutoff for usage? What kind of usage numbers would NetSurf need to hit to merit inclusion? And are the sites that we rely on for tracking usage correctly capturing NetSurf usage so that we know when it hits the required numbers? Given its poor support for Javascript, built-in adblocker, and perhaps catering to users who dislike Javascript / ads, will it even show up in trackers?
Could we support NetSurf despite its low usage numbers as a hedge against browser engine dominance?

NetSurf's UA String is supposed to be NetSurf/[version] ([operating system]; [CPU architecture]).
My copy of NetSurf is currently reporting NetSurf/3.10 (Linux).

The main reason for those criteria is because it takes time and effort to keep support data up to date, so if a new browser is to be added I want to make sure that effort is worthwhile. As I don't think there's much interest for developers to support browsers with low usage (NetSurf does not even appear in StatCounter's list) I'd prefer to keep the effort on browsers that are in use.
For the record, I do share concerns about the browser monoculture problem, but I don't see caniuse adding NetSurf as another browser to maintain making any difference towards this as I don't currently see it gaining any significant amount of marketshare to make a difference.

I don't disagree with what you've said here, but what I'd like to get on record is what the usage/popularity cutoffs are. Because you might be wrong, and perhaps someday NetSurf (or some other independent browser) will gain enough popularity, but if we haven't defined what that is, we could have this discussion indefinitely. If the answer is just "I'll know it when I see it", I guess I'll have to respect that, but it doesn't seem like a good standard.
Is whether a browser appears in StatCounter's list the cutoff? What is the least popular browser that CanIUse supports? Looking at https://caniuse.com/usage-table, it appears that Baidu Browser has 0% marketshare, which doesn't seem very impressive. Blackberry Browser also looks to be at 0%+0%=0%.

Indeed there isn't a specific cutoff, though StatCounter is the primary source to see what's popular. The reason QQ and Baidu were added was because I was informed these browsers have very high usage share in China, though it does seem StatCounter doesn't detect Baidu separately as its user agent may not differ from that of Chrome's (though it does use a custom version of Chromium).
BlackBerry and IE mobile were removed from the main site's tables a few years ago due to their reduced usage. Have just fixed it so they no longer appear on that page either, thanks for pointing that out.


[CI][Python] Cython test is failing in conda packaging builds

See for example this log output of the latest conda-linux-x64-cpu-py3 build.
The test_cpp_extension_in_python is failing, which is a test building some custom cython, and it's failing with
...
            # Compile extension module
>           subprocess.check_call([sys.executable, 'setup.py',
                                   'build_ext', '--inplace'],
                                  env=subprocess_env)

...
>           raise CalledProcessError(retcode, cmd)
E           subprocess.CalledProcessError: Command '['$PREFIX/bin/python3.11', 'setup.py', 'build_ext', '--inplace']' returned non-zero exit status 1.

../../../subprocess.py:413: CalledProcessError
----------------------------- Captured stdout call -----------------------------
Compiling extensions.pyx because it changed.
[1/1] Cythonizing extensions.pyx
Extension module: <setuptools.extension.Extension('extensions') at 0x7f8bfb469c90> ['$PREFIX/lib/python3.11/site-packages/numpy/core/include', '$PREFIX/lib/python3.11/site-packages/pyarrow/include'] ['arrow_python', 'arrow'] ['$PREFIX/lib/python3.11/site-packages/pyarrow', '$PREFIX/lib']
running build_ext
building 'extensions' extension
creating build
creating build/temp.linux-x86_64-cpython-311
gcc -pthread -B $PREFIX/compiler_compat -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem $PREFIX/include -fPIC -O2 -isystem $PREFIX/include -fPIC -I$PREFIX/lib/python3.11/site-packages/numpy/core/include -I$PREFIX/lib/python3.11/site-packages/pyarrow/include -I$PREFIX/include/python3.11 -c extensions.cpp -o build/temp.linux-x86_64-cpython-311/extensions.o -std=c++17
----------------------------- Captured stderr call -----------------------------
error: command 'gcc' failed: No such file or directory

So it's complaining about "gcc" not found. I don't know if this test is supposed to work on those builds, but the strange thing is that we have other tests that call the exact same subprocess command, and those are not failing.

This seems to have been fixed by https://github.com/apache/arrow/pull/34652

Yes, I added a compiler to the test requirements, so gcc will be found on linux


Create a first release

If you could just create a v1.0.0 release, it'd be most helpful for managing composer dependencies.
git tag -a v1.0.0 -m "First Stable Release"
git push --tags

Sure, created the v1.0.0 tag.


Earth object lacks heliocentric coordinates property

Subj

Could you be more precise: what type of heliocentric coordinates? Ecliptical heliocentric?

Yes, ecliptic heliocentric coordinates.

@alex-vasenin I've made a quick change that might help out. Seems simple, but Earth didn't seem to inherit from Planet. ¯_(ツ)_/¯

If I remember well, that was intentional. The general philosophy, when I started, was to have a protocol and its default implementation for every part of AA+, which follows more or less the chapters of the AA book. And then create meaningful objects inheriting from relevant protocols.
But today, I think the situation became too complex and unreadable. I plan to create a kind synthetic picture of the current situation about protocols and inheritance.

Great. I look forward to it.
It sounds like you have it had a lot on your plate. Is your schedule lightening up or are you still off the clock for now?

Yes, I have a lot on my plate. But I'm back from vacations. :-) My schedule for night-projects is still very unpredictable. But SwiftAA is on top of my list (right below little-fire-that-must-be-extincted-asap).

As for this very specific problem of ecliptic heliocentric coordinates, the functions exist in (Obj-C)AA+ layers. And they were actually misleadingly used for computing times of rise, transit and set.
So it's only a matter of re-enabling them, for all planets, and for Earth in particular. But this question hits precisely the issue of difficult readability of APIs and protocol inheritance. I'll be happy to look at at asap once the little fire is extincted.

With the help of this great tool, I came up with this:
SwiftAAClassDiagram.pdf

Is there a way to vectorize those class diagrams? It's mostly text right? Feels like this should be possible.

It was easier than I think to add these coordinates for the Earth. The (Obj-)C++ functions exist, and they just needed to be added to the Swift class. I close the issue.


unable to install

Where:
Build file '/home/hduser/hipi/tools/build.gradle' line: 10

What went wrong:
A problem occurred evaluating project ':tools'.

Could not resolve all files for configuration ':tools:covar:runtime'.
Could not resolve org.apache.hadoop:hadoop-common:2.7.1.
Required by:
project :tools:covar
project :tools:covar > project :core
Could not resolve org.apache.hadoop:hadoop-common:2.7.1.
Could not get resource 'https://repo.maven.apache.org/maven2/org/apache/hadoop/hadoop-common/2.7.1/hadoop-common-2.7.1.pom'.
Could not GET 'https://repo.maven.apache.org/maven2/org/apache/hadoop/hadoop-common/2.7.1/hadoop-common-2.7.1.pom'.
java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty
Could not resolve org.apache.hadoop:hadoop-mapreduce-client-core:2.7.1.
Required by:
project :tools:covar
project :tools:covar > project :core
Could not resolve org.apache.hadoop:hadoop-mapreduce-client-core:2.7.1.
Could not get resource 'https://repo.maven.apache.org/maven2/org/apache/hadoop/hadoop-mapreduce-client-core/2.7.1/hadoop-mapreduce-client-core-2.7.1.pom'.
Could not GET 'https://repo.maven.apache.org/maven2/org/apache/hadoop/hadoop-mapreduce-client-core/2.7.1/hadoop-mapreduce-client-core-2.7.1.pom'.
java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty
Could not resolve com.googlecode.json-simple:json-simple:1.1.1.
Required by:
project :tools:covar
project :tools:covar > project :core
Could not resolve com.googlecode.json-simple:json-simple:1.1.1.
Could not get resource 'https://repo.maven.apache.org/maven2/com/googlecode/json-simple/json-simple/1.1.1/json-simple-1.1.1.pom'.
Could not GET 'https://repo.maven.apache.org/maven2/com/googlecode/json-simple/json-simple/1.1.1/json-simple-1.1.1.pom'.
java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty
Could not resolve com.drewnoakes:metadata-extractor:2.8.1.
Required by:
project :tools:covar
project :tools:covar > project :core
Could not resolve com.drewnoakes:metadata-extractor:2.8.1.
Could not get resource 'https://repo.maven.apache.org/maven2/com/drewnoakes/metadata-extractor/2.8.1/metadata-extractor-2.8.1.pom'.
Could not GET 'https://repo.maven.apache.org/maven2/com/drewnoakes/metadata-extractor/2.8.1/metadata-extractor-2.8.1.pom'.
java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty
Could not resolve com.twelvemonkeys.imageio:imageio-jpeg:3.1.1.
Required by:
project :tools:covar
project :tools:covar > project :core
Could not resolve com.twelvemonkeys.imageio:imageio-jpeg:3.1.1.
Could not get resource 'https://repo.maven.apache.org/maven2/com/twelvemonkeys/imageio/imageio-jpeg/3.1.1/imageio-jpeg-3.1.1.pom'.
Could not GET 'https://repo.maven.apache.org/maven2/com/twelvemonkeys/imageio/imageio-jpeg/3.1.1/imageio-jpeg-3.1.1.pom'.
java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty
Could not resolve com.twelvemonkeys.imageio:imageio-pnm:3.1.1.
Required by:
project :tools:covar
project :tools:covar > project :core
Could not resolve com.twelvemonkeys.imageio:imageio-pnm:3.1.1.
Could not get resource 'https://repo.maven.apache.org/maven2/com/twelvemonkeys/imageio/imageio-pnm/3.1.1/imageio-pnm-3.1.1.pom'.
Could not GET 'https://repo.maven.apache.org/maven2/com/twelvemonkeys/imageio/imageio-pnm/3.1.1/imageio-pnm-3.1.1.pom'.
java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty
Could not resolve com.twelvemonkeys.imageio:imageio-tiff:3.1.1.
Required by:
project :tools:covar
project :tools:covar > project :core
Could not resolve com.twelvemonkeys.imageio:imageio-tiff:3.1.1.
Could not get resource 'https://repo.maven.apache.org/maven2/com/twelvemonkeys/imageio/imageio-tiff/3.1.1/imageio-tiff-3.1.1.pom'.
Could not GET 'https://repo.maven.apache.org/maven2/com/twelvemonkeys/imageio/imageio-tiff/3.1.1/imageio-tiff-3.1.1.pom'.
java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty
Could not resolve org.bytedeco:javacpp:1.0.
Required by:
project :tools:covar
project :tools:covar > project :core
Could not resolve org.bytedeco:javacpp:1.0.
Could not get resource 'https://repo.maven.apache.org/maven2/org/bytedeco/javacpp/1.0/javacpp-1.0.pom'.
Could not GET 'https://repo.maven.apache.org/maven2/org/bytedeco/javacpp/1.0/javacpp-1.0.pom'.
java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty
Could not resolve org.bytedeco:javacv:1.0.
Required by:
project :tools:covar
project :tools:covar > project :core
Could not resolve org.bytedeco:javacv:1.0.
Could not get resource 'https://repo.maven.apache.org/maven2/org/bytedeco/javacv/1.0/javacv-1.0.pom'.
Could not GET 'https://repo.maven.apache.org/maven2/org/bytedeco/javacv/1.0/javacv-1.0.pom'.
java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty
Could not resolve org.bytedeco.javacpp-presets:opencv:3.0.0-1.0.
Required by:
project :tools:covar
project :tools:covar > project :core
Could not resolve org.bytedeco.javacpp-presets:opencv:3.0.0-1.0.
Could not get resource 'https://repo.maven.apache.org/maven2/org/bytedeco/javacpp-presets/opencv/3.0.0-1.0/opencv-3.0.0-1.0.pom'.
Could not GET 'https://repo.maven.apache.org/maven2/org/bytedeco/javacpp-presets/opencv/3.0.0-1.0/opencv-3.0.0-1.0.pom'.
java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

for installing HIPI ,does the path of hadoop and gradle sholud be same??Exactly as shown in https://gradle.org/install/  ??


Error 400 - Sending to Discord

I am running the latest release for docker, and it just stopped working for Discord.
My config looks like this:
configs:
"@":
urls:
- discord://116282579146/zn0S_c_pMFh1o5U68yT7Msef_8TgXPCXEwpZ3oEf_ZMFJ54b8Uc
This is the same config I've been using for quite some time with no issues, yet now all the emails are getting rejected.  The logs say:
2023-10-14T19:05:15.430152683Z [2023-10-14 12:05:15] WARNING:mailrise.skeleton:Notification failed: Postmaster Copy: Undelivered Mail ➤ postmaster@
2023-10-14T19:05:15.544137022Z [2023-10-14 12:05:15] WARNING:mailrise.skeleton:Notification failed: Undelivered Mail Returned to Sender ➤ webmin@
2023-10-14T19:05:26.990883518Z [2023-10-14 12:05:26] WARNING:mailrise.skeleton:Notification failed: Undelivered Mail Returned to Sender ➤ root@
2023-10-14T19:05:28.231093925Z [2023-10-14 12:05:28] WARNING:apprise:Failed to send to Discord notification: Bad Request - Unsupported Parameters., error=400.
2023-10-14T19:05:28.232503392Z [2023-10-14 12:05:28] WARNING:mailrise.skeleton:Notification failed: Cron root@pve2 test -x /usr/sbin/anacron || { cd / && run-parts --report /etc/cron.daily; } ➤ root@
2023-10-14T19:10:27.620136150Z [2023-10-14 12:10:27] WARNING:apprise:Failed to send to Discord notification: Bad Request - Unsupported Parameters., error=400.
2023-10-14T19:10:27.622009431Z [2023-10-14 12:10:27] WARNING:mailrise.skeleton:Notification failed: vzdump backup status (pve2.cotb.local.lan) : backup failed ➤
2023-10-14T19:10:33.244988612Z [2023-10-14 12:10:33] WARNING:mailrise.skeleton:Notification failed: Undelivered Mail Returned to Sender ➤
I've tried a new webhook, just to be sure there's no problem there, same issue.
Any ideas?  Perhaps we need an update to the Discord library?
Thanks!

Note, I redacted the server names and email  adresses.

Could you get another log with the latest image? I've added some additional logging that will tell us more about the contents of your messages.
From what I've seen, if there's a problem with Discord, it tends to be that the emails produce messages that are too large for the service. Did you recently stop using Nitro?

afaik "@" needs to be: "*@*"
splitting is supported with newer apprise-version and url-parameter ?overflow=split

Joining here as I also get issues with proxmox to discord


Add LL::quotient and remove uses of divideRight and sublayoutIsIdentity

We add a new abstraction LL::quotient that abstracts the idea of "a
linear layout does not permute certain dimensions". Doing so, allows us
to remove divideRight and subsume them into this higher-level abstraction.
We also fix a bug in isCrossCTAConversion.
We also remove some code duplication from transferWithinThreads and
cvtReorderRegisters in favour of a more generic approach.
We fix a bug in sublayout that meant that sublayout would reorder outDims
at will by using a set instead of a vector.
I am missing adding tests for LL::quotient, will do in a minute.

This means that the kBlock of the output will be defined uninquely and as the identity by the kBlock of the input, which is fine. But we are missing a check that layout.sublayoutIsZero({kBlock}, nonBlockOutDims.getArrayRef()), as otherwise the layout will depend on the kBlock, but a few lines after that we are "removing" the kBlock dimensions, effectively assuming that that sublayout is zero.

Sure, I think it makes sense


ignore-rhs should be configurable to only apply outside of conditionals

Feature request
We'd like to use ignore-rhs but do not want to use it inside conditionals or other contexts (like the result of a filter() function) which require a boolean.  This could potentially be called ignore-rhs-when-bool-not-required though that's wordy.
Here's an example. I'd like the first two statements to get flagged but the third to not be flagged - so in places where we absolutely must have a boolean, we're sure to get a strict one and not, for example, a truthy empty string.
const func = (b: boolean, s: string): boolean | string => {
  // Gets flagged with ignore-rhs on - correct
  if (s) {
    // ...
  }

  // Does not get flagged with ignore-rhs on, but I'd like it to!  We don't want strings inside of if/while/ternaries/filter or anywhere a bool is required
  if (b || s) {
    // ...
  }

  // This does not get flagged and that's good!  Function is able to return a boolean or a string
  return b || s;
}

I don't see where the confusion comes in, typescript has no problems if you add an intermediate variable:
const func = (b: boolean, s: string) => {
    // typescript knows `typeof thing === true | string` according to how || evaluates.
    const thing = b || s;
    // since true | string is not a valid boolean type this gets flagged.
    if(thing){
        // ...
    }
    // however this, even though it evaluates to true | string it is not flagged when passed to an if statement.
    if(b || s){
        // ...
    }
  }

can't the rule do the same?  If the expression passed to if/while/ternary is not a boolean then throw an error, I don't even see how ignoring the right hand side would even cause it to ignore that.

Yeah, this seems reasonable as a rule option. We could take it in.
Please keep #4534 in mind: we're nearing the deadline for no more non-essential PRs.

☠ TSLint's time has come! ☠
TSLint is no longer accepting most feature requests per #4534. See typescript-eslint.io for the new, shiny way to lint your TypeScript code with ESLint. ✨
It was a pleasure open sourcing with you all!

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


reduced complexity to O(N^3 log N), updated notation

As per the latest paper version.

Codecov Report

Merging #27 into master will decrease coverage by 0.54%.
The diff coverage is 80.68%.

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   79.77%   79.23%   -0.55%
==========================================
  Files          10       10
  Lines         534      520      -14
  Branches      105      104       -1
==========================================
- Hits          426      412      -14
  Misses         80       80
  Partials       28       28

Impacted Files
Coverage Δ

persim/gromov_hausdorff.py
81.66% <80.68%> (-1.33%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 989e5c6...aedb1c8. Read the comment docs.


Add support to use dotenv file

Is your feature request related to a problem? Please describe.
Since most of the flags are backed by env variables it will be easier to use and commit them with dotenv file
Describe the solution you'd like
Using dotenv file to read env variables
I have tried using tools such as direnv, autoenv, zsh configurations etc. but to be honest it is very cumbersome to configure and deal with them, although they would work but the biggest questions for such tools is that if we have configured some envs when a user enters a directory how will we unset them when user exits the directory and that does create an .env mess. Hence a better solution is always to adopt the application itself to add support for reading .env files.

Can we keep this open since I have made the changes for this as well in the MR

Oh I just checked that a label for wontfix is placed, is there a specific reason for the same?

Released in 0.33.0


Responsive design and window size

After bringing in some css my app now has a responsive navigation where a window size narrower than 769 pixels wide will turn into a hamburger menu. Since the default window size in wallaby is 100 x 100 I end up running tests against the responsive layout and can not click on links in the responsive menu since it involves an extra step. This leaves me with two options:

Account for extra step
resize_window in the current session

I opted for the second option, but I have quite a few tests where I have to keep resizing the window. Is there a way to configure the default window size for all acceptance cases? I'd love to set this option globally so that I don't have to keep resizing across all my tests. I'm happy to help if this option isn't available. I just wanted to double check a feature like this doesn't already exist.
Cheers!

I don't think there's a window size option to pass on session creation in webdriver. You will have to set it after creating the session. You could add something like this to your AcceptanceCase:
{:ok, session} = Wallaby.start_session(metadata: metadata)
session = Wallaby.Browser.resize_window(session, 300, 500)
{:ok, session: session}

That way each session would be sized correctly. We could probably support this as a configuration option. It probably makes sense to open to window larger then 100x100 by default.

It probably makes sense to open to window larger then 100x100 by default.

Most definitely. I imagine it being a gotcha moment in the first couple of tests that that's why maybe the menu doesn't show :D

Thanks a lot for that, @keathley. That clears things up quite a bit. I was wondering how to go about setting that in the AcceptanceCase file.
However, I'm wondering now weather or not a config is necessary. Perhaps adding a line or two about that in the README could suffice?
What do you guys think would be a good default? Perhaps something like 960x500? I'm happy to submit a PR over the next few days if you'd like.

I think an addition to the README would be quite nice, and agree that it's an easy enough change that it doesn't need a config imo :)

Just got nailed by this myself! I'm testing real-time updates across different sessions, so I'm consistently starting a second session. For now, I'm resizing the second session's window winthin my real-time update tests such that it matches the size I've given to the first session in my IntegrationCase setup, but @keathley, I'm happy to submit a PR for passing screensize options to Wallaby.start_session if you're down with it.
Instead of
 {:ok, session_two} = Wallaby.start_session()
 session_two = resize_window(session_two, 960, 500)

It'd be something like:
 {:ok, session_two} = Wallaby.start_session(
  [some_driver_initialization_config: "derp"],
  window_dimensions: [960, 500]
)

If you'd rather keep Wallaby.start_session limited to just starting the driver, I totally get it, but I have a feeling other folks are gonna hit this issue.

I'm OK with accepting something like window_size or window_dimensions as an option to Wallaby.start_session/1. If someone wants to submit a PR for that I'd be happy to take a look.

{:ok, session} = Wallaby.start_session(metadata: metadata)
session = Wallaby.Browser.resize_window(session, 300, 500)
{:ok, session: session}

is resizing the window in a strange way. I'm using bootstrap and I'm working on registering an account using a sign up button from the navbar, but my navbar is always blank because the CSS class collapse (having a media query) is hidding it.
Increasing the window size doesn't fix the issue, even with a width of 2000.
To test it, I removed the CSS for the navbar responsiveness and used a width of 1500 and see the result:

As you can see, the window is well resized, but the content of the navbar is like it is in a very small window, while it should look like this:

@zedtux which browser are you using?

The second screenshot has been done with Firefox 57.0.1 and the first one is from Wallaby.

I'm wondering if this is a phantom bug. You might try with chrome to see what that does. Phantom has issues with new-ish css and such.

I'm OK with accepting something like window_size or window_dimensions as an option to Wallaby.start_session/1. If someone wants to submit a PR for that I'd be happy to take a look.

I will take a crack at this.

@mhanberg were you able to find anything?

I have been exploring how the different drivers work and getting a feel for the codebase, but haven't yet written any code yet.

This can be closed due to #390


Uploading Iris_params csv file and adding test_from_csv function for …

Checkout PR comments here:
https://docs.google.com/presentation/d/1EAqWGjisOUSLG4fkg0lhQEm7Z_vVOO3VNiCFr5r1bHA/edit#slide=id.g98c6256277_0_62

@BruisVanVlijmen2020 This looks correct. You can generate the files on your local machine and then put them on the Arbin. Once you are able to start the cells, we can merge this PR (its a hardware in the loop test :) so it really is a good test to have in the repo)
Thanks!

@BruisVanVlijmen2020 Almost done! Could you also remove the generated files from the PR?
Something like:
git rm beep/tests/test_files/raw/Iris_parameters - GP.csv
git rm beep/tests/test_files/Iris_000100.sdu
git rm beep/tests/test_files/Iris_000101.sdu
git rm beep/tests/test_files/Iris_000102.sdu
git rm beep/tests/test_files/Iris_000103.sdu
git rm beep/tests/test_files/Iris_000104.sdu
git commit -m "removing unnecessary files"
git push

Thanks!

Lovely, thanks PK


Some ustream videos can't be downloaded

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.04.03. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2017.04.03

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

youtube-dl.exe -v  "http://www.ustream.tv/recorded/100659713"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'http://www.ustream.tv/recorded/100659713']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2017.04.03
[debug] Python version 3.4.4 - Windows-10-10.0.10586
[debug] exe versions: ffmpeg N-85266-g1229007, ffprobe N-85266-g1229007
[debug] Proxy map: {}
[ustream] 100659713: Downloading JSON metadata
[ustream] 100659713: Downloading connection info
[ustream] 100659713: Downloading stream info
[ustream] 100659713: Downloading connection info (try 2)
[ustream] 100659713: Downloading stream info (try 2)
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpam8ojdsi\build\youtube_dl\YoutubeDL.py", line 761, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpam8ojdsi\build\youtube_dl\extractor\common.py", line 429, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpam8ojdsi\build\youtube_dl\extractor\ustream.py", line 217, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpam8ojdsi\build\youtube_dl\extractor\common.py", line 1042, in _sort_formats
youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description of the issue, suggested solution and other information
Hello.
Some (not all) videos from ustream as the one present in the output above are not supported by youtube-dl.
Here is the callstack of the execution interrupted right at the point where the problem appear:
InfoExtractor._download_json in common line 665	Python
UstreamIE._get_stream_info in ustream line 106	Python
UstreamIE._get_streams in ustream line 113	Python
UstreamIE._real_extract in ustream line 204	Python
InfoExtractor.extract in common line 429	Python
YoutubeDL.extract_info in YoutubeDL line 761	Python
YoutubeDL.download in YoutubeDL line 1890	Python

Inside "InfoExtractor._download_json" the function "_download_webpage" is called to download a JSON-formatted file containing some infos about the video.
Here is the last few lines of a JSON file describing an ustream video that youtube-dl can download:
   "stream":[
               {
                  "name":"uhls",
                  "url":"http://c742eece-lp-live.ums.ustream.tv/playlist/auditorium/recorded/100652907/playlist.m3u8?token=17518093_1491439035019&appType=11&appVersion=2&ts=1491439035&chunkingType=improved&geo=US&sgn=887863d4a1b5549864f56e941dadae2a5f874363&cdnHost=uhs-akamai.ustream.tv/"
               }
            ]
         }
      ],
      "cmd":"moduleInfo"
   }

And the next snippet is from the JSON file of the video I'm trying to download:
"args":[
         {
            "stream":[

            ]
         }
      ],
      "cmd":"moduleInfo"
   }

It seems that the stream link (m3u8 file) is missing in the above JSON file.
Unfortunatly, I have no idea how to solve the issue. And my zero knowledge about python isn't helping me either.

It seems that the video was deleted because it reached 30 day.
Here is annother one with the same problem
http://www.ustream.tv/recorded/101156587

http://www.ustream.tv/recorded/101156587 is also gone. Any new example?

Closing as no response for a long time. Feel free to open a new issue if another Ustream video breaks youtube-dl.


Add possibility to provide placePreference/placeProperty as input to /availabilities/placeMap

To accomodate hot seating algorithms in IMS

Hello @stinacarlstedt does it mean that you want to add AccommodationType, AccommodationSubType and maybe string place properties as additional filters into PartReference and basically adjust the suggested PlacePreSelection in the PlaceAvailabilitiesResponse?


Browser self-updating feature

Because why not :)
I think ota updates

OTA support? What do you mean by OTA in this case?

Updates via browser ,not github

Oh okay. I'm not very familiar with the browser's built-in update feature since I've never seen it on Chromium and I've never tried it on Chrome.
However, I don't really want to implement this since there are so many ways to setup ungoogled-chromium, and I don't want to write very complicated code to accomplish something that has little value. If you have a very good reason for implementing this, let me know.

FreeSMUG has Chromium builds. They don't auto-update, but there's an extension that checks for newer builds. It then prompts you to download the updated version. It's not a perfect solution, but it's a good one.

@reclaimer: It's not a bad idea, but I don't want that to be a part of this project. This project tries not to deviate too much from the user experience provided by vanilla Chromium. It would be fine if that extension if such extension was made into a separate project and then referenced from ungoogled-chromium's documentation (e.g. the README).

The extension is basically checking Sourceforge for a newer build. A Github-based approach might actually be more elegant.

If you have a very good reason for implementing this, let me know.
Because i don't want every day check for updates...

@the4anoni You don't need the browser to self-update to know if there's an update. @reclaimer's solution will notify users when there's an update.


Traffic Light Recognition

Hi,
In the moment I am testing Open Planner with different scenarios in Carla + Autoware 1.14, Ubuntu 18.04.
I am trying to implement traffic light recognition to test Open Planner in traffic light stop scenario.
I have a vector map with traffic light data, when I launch the feature_projection node, it publishes the Roi_signal topic with no data.
How can I fix this problem?

Hello,
This is not a bug in Autoware, I will answer your question on ro answers.

Thank you @hatem-darweesh !


feat-sonarqube: Added sonar quality gateway conversion

Sonar Quality Gate go-conversion:
Added "Sonar Quality Gate" support to go-convert specific to jenkins migration.
Sonar Quality Gate Jenkins Trace:
vani_sonar_Trace.json
go run main.go jenkinsjson --downgrade ~/go/vani_sonar_Trace.json
Sonar Quality Gate Harness test pipeline here.
Sonar Quality Gate harness pipeline step:
- step:
    identifier: waitforqualitygate6278c9
    name: Sonarqube_Quality_Gate
    spec:
      image: 'plugins/sonarqube-scanner:v2.4.2'
      settings:
        scm_disabled: 'false'
        skip_scan: 'false'
        sonar_host: <+input>
        sonar_key: <+input>
        sonar_name: <+input>
        sonar_organization: <+input>
        sonar_quality_enabled: 'true'
        sonar_qualitygate: OK
        sonar_token: <+input>
        sources: .
        timeout: '300'
    timeout: ''
    type: Plugin

Hello @Ompragash,
Could you please review the PR for sonar quality gate conversion and provide your comments on that?
Thank you.


docs(LanguageConfiguration): fix typo (interfaces --> interface)

Hi @gkalpak, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;


make test_frontier.py more memory efficient

@vbuterin @heikoheiko I'm going to merge if you're ok with this change.


Install liblzma on linux.

This change is

:pushpin: Commit ae99a43 has been approved by jdm

@bors-servo r+

:hourglass: Testing commit ae99a43cd9a161ab7480496a25c3459e830a2869 with merge f43d9e656dd505ac49f595ce70eed8fb94c3f389...

:broken_heart: Test failed - checks-travis

:sunny: Test successful - checks-travis
Approved by: jdm
Pushing f43d9e656dd505ac49f595ce70eed8fb94c3f389 to master...


Question: Does this work with YAGO?

Sorry for abusing the project issues for asking a question! I didn't find any other way to contact you.
I'm the maintainer of @photoprism and we need a compact ontology to improve our search. If you search for fish, you should also find sharks. Same for NYC and New York etc...
It seems like YAGO is a good starting point. Obviously we need to parse the files and reduce the amount of data for our use case (image classification). Can we use gofp for this? If yes: What specific YAGO files / themes do we need to download? Can you give us an example?
I hope you see this... Thank you very much and sorry again 😃

Gofp, as I expect, needs further completion to fully parse YAGO. You also need an OWL-functional representation.
The size of YAGO might be handled by replacing the default implementation of the Gofp store.AxiomStore interface. This decides how to store axioms, and if at all. The parser calls the "Store*" functions with each single axiom parsed -- thats a "Visitor" pattern -- and you decide to keep or discard each one.
Feel also free to mail me at: shful2019b3 at example.org with example=posteo.

@shful Thank you! We've decided to manually define related terms for now as there are only 1000 different labels. We might come back to this later, when we have more time.


Internal Server Error when viewing reports

Everything on my install works great, except if go to "Reports" or load up a Node (its list of reports never populates - everything else shows fine).
Where the data table of Reports should be it just says Processing... and then in the console there's a 500. Tracing that into the logs I see this:
ERROR:pypuppetdb.api:Illegal value '{:field "end_time", :order "None"}' in :order_by; 'order' must be either 'asc' or 'desc' puppetdb.dev.local:8080 over HTTP.

Here is settings.py
DEV_LISTEN_HOST = '<IP_ADDRESS>'
DEV_LISTEN_PORT = 5000
LOGLEVEL = 'info'
PUPPETDB_HOST = 'puppetdb.dev.local'
PUPPETDB_PORT = 8080
PUPPETDB_SSL_VERIFY = False
PUPPETDB_TIMEOUT = 20
UNRESPONSIVE_HOURS = 3
ENABLE_CATALOG = False
ENABLE_QUERY = True
LOCALISE_TIMESTAMP = True
OFFLINE_MODE = False
PUPPETDB_EXPERIMENTAL = False
DEFAULT_ENVIRONMENT = 'dev'
REPORTS_COUNT = 10

I'm sure its something I'm doing wrong, but what could be going on here? I'm on PuppetDB 4.3.2

I'm on 4.3.0 and working.
Add:
OVERVIEW_FILTER = None

What version of puppetboard board and pypupetdb are you using?

@mterzo Adding OVERVIEW_FILTER = None didn't change anything. I'm running Puppetboard 0.2.2 and pypuppetdb 0.3.2. I'm installing using the Puppet module: https://github.com/voxpupuli/puppet-puppetboard

One of my Puppet master happens to be on the same PuppetDB/board/pypuppetdb versions and I can reproduce the problem if I choose to show reports for an environment that is not default (production) or all of them (*).

Yeah my default env is "dev" and it's gotta be like that for reasons. Which part of the code handles that? Maybe I can make a PR
On May 18, 2017, 7:40 AM -0400, Benjamin Merot<EMAIL_ADDRESS>wrote:

One of my Puppet master happens to be on the same PuppetDB/board/pypuppetdb versions and I can reproduce the problem if I choose to show reports for an environment that is not default (production) or all of them (*).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (https://github.com/voxpupuli/puppetboard/issues/383#issuecomment-302379726), or mute the thread (https://github.com/notifications/unsubscribe-auth/AB5KbIB7QOVe4naPIz2ge7iHa9AtUxpsks5r7C4fgaJpZM4Nb8Gr).

@phybros, you can start looking around the /reports/json endpoint.
The problem is either in that endpoint or in pypuppetdb.

What browser are you using and what version of jinja2 was installed from pip.
I upgraded my puppetdb to 4.4.0 and expected to run into a problem, but I'm not seeing any issues.  I went through the code and found:
https://github.com/voxpupuli/puppetboard/blob/v0.2.2/puppetboard/app.py#L474-L478
The sort order and by what comes from the client.
If you enable debug in the puppetboard, you can send the URL that was requested when you get the failure as well.  It's either browser encoding with javascript or jinja2 template issue.

sorry I was just on vacation, will check out jinja and the debug mode

Just hitting /reports/json with chrome produced this
[Wed May 31 15:14:06.407833 2017] [:error] [pid 19834] DEBUG:pypuppetdb.api:_query called with endpoint: environments, path: None, query: None, limit: None, offset: None, summarize_by None, count_by None, count_filter: None
[Wed May 31 15:14:06.408027 2017] [:error] [pid 19834] DEBUG:pypuppetdb.api:_url called with endpoint: environments and path: None
[Wed May 31 15:14:06.408766 2017] [:error] [pid 19834] INFO:requests.packages.urllib3.connectionpool:Resetting dropped connection: puppetdb.dev.trello.local
[Wed May 31 15:14:06.423649 2017] [:error] [pid 19834] DEBUG:requests.packages.urllib3.connectionpool:"GET /pdb/query/v4/environments HTTP/1.1" 200 16
[Wed May 31 15:14:06.424192 2017] [:error] [pid 19834] DEBUG:pypuppetdb.api:_query called with endpoint: reports, path: None, query: ["and",["=", "environment", "dev"]], limit: 100, offset: 0, summarize_by None, count_by None, count_filter: None
[Wed May 31 15:14:06.424313 2017] [:error] [pid 19834] DEBUG:pypuppetdb.api:_url called with endpoint: reports and path: None
[Wed May 31 15:14:06.428953 2017] [:error] [pid 19834] DEBUG:requests.packages.urllib3.connectionpool:"GET /pdb/query/v4/reports?query=%5B%22and%22%2C%5B%22%3D%22%2C+%22environment%22%2C+%22dev%22%5D%5D&order_by=%5B%7B%22field%22%3A+%22end_time%22%2C+%22order%22%3A+%22None%22%7D%5D&limit=100&include_total=true&offset=0 HTTP/1.1" 400 103
[Wed May 31 15:14:06.429322 2017] [:error] [pid 19834] ERROR:pypuppetdb.api:Illegal value '{:field "end_time", :order "None"}' in :order_by; 'order' must be either 'asc' or 'desc' puppetdb.dev.trello.local:8080 over HTTP.
[Wed May 31 15:14:06.429681 2017] [:error] [pid 19834] ERROR:puppetboard.app:Exception on /reports/json [GET]
[Wed May 31 15:14:06.429742 2017] [:error] [pid 19834] Traceback (most recent call last):
[Wed May 31 15:14:06.429769 2017] [:error] [pid 19834]   File "/srv/puppetboard/virtenv-puppetboard/lib/python2.7/site-packages/flask/app.py", line 1817, in wsgi_app
[Wed May 31 15:14:06.429796 2017] [:error] [pid 19834]     response = self.full_dispatch_request()
[Wed May 31 15:14:06.429819 2017] [:error] [pid 19834]   File "/srv/puppetboard/virtenv-puppetboard/lib/python2.7/site-packages/flask/app.py", line 1477, in full_dispatch_request
[Wed May 31 15:14:06.429841 2017] [:error] [pid 19834]     rv = self.handle_user_exception(e)
[Wed May 31 15:14:06.429862 2017] [:error] [pid 19834]   File "/srv/puppetboard/virtenv-puppetboard/lib/python2.7/site-packages/flask/app.py", line 1381, in handle_user_exception
[Wed May 31 15:14:06.429882 2017] [:error] [pid 19834]     reraise(exc_type, exc_value, tb)
[Wed May 31 15:14:06.429902 2017] [:error] [pid 19834]   File "/srv/puppetboard/virtenv-puppetboard/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
[Wed May 31 15:14:06.429928 2017] [:error] [pid 19834]     rv = self.dispatch_request()
[Wed May 31 15:14:06.429950 2017] [:error] [pid 19834]   File "/srv/puppetboard/virtenv-puppetboard/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
[Wed May 31 15:14:06.429971 2017] [:error] [pid 19834]     return self.view_functions[rule.endpoint](**req.view_args)
[Wed May 31 15:14:06.429992 2017] [:error] [pid 19834]   File "/srv/puppetboard/puppetboard/puppetboard/app.py", line 550, in reports_ajax
[Wed May 31 15:14:06.430012 2017] [:error] [pid 19834]     for report in reports_events:
[Wed May 31 15:14:06.430032 2017] [:error] [pid 19834]   File "/srv/puppetboard/virtenv-puppetboard/lib/python2.7/site-packages/pypuppetdb/api.py", line 798, in reports
[Wed May 31 15:14:06.430053 2017] [:error] [pid 19834]     reports = self._query('reports', **kwargs)
[Wed May 31 15:14:06.430076 2017] [:error] [pid 19834]   File "/srv/puppetboard/virtenv-puppetboard/lib/python2.7/site-packages/pypuppetdb/api.py", line 340, in _query
[Wed May 31 15:14:06.430097 2017] [:error] [pid 19834]     r.raise_for_status()
[Wed May 31 15:14:06.430117 2017] [:error] [pid 19834]   File "/srv/puppetboard/virtenv-puppetboard/lib/python2.7/site-packages/requests/models.py", line 834, in raise_for_status
[Wed May 31 15:14:06.430138 2017] [:error] [pid 19834]     raise HTTPError(http_error_msg, response=self)
[Wed May 31 15:14:06.430158 2017] [:error] [pid 19834] HTTPError: 400 Client Error: Bad Request
[Wed May 31 15:14:06.430250 2017] [:error] [pid 19834] DEBUG:pypuppetdb.api:_query called with endpoint: environments, path: None, query: None, limit: None, offset: None, summarize_by None, count_by None, count_filter: None
[Wed May 31 15:14:06.430346 2017] [:error] [pid 19834] DEBUG:pypuppetdb.api:_url called with endpoint: environments and path: None
[Wed May 31 15:14:06.436692 2017] [:error] [pid 19834] DEBUG:requests.packages.urllib3.connectionpool:"GET /pdb/query/v4/environments HTTP/1.1" 200 16

What OS is this?  I want to try and set up vagrant testbed.

Wasn't completely fixed by #386.

@mterzo Ubuntu Server 14.04

I have solved the problem - the issues all came from Apache being used as a reverse proxy. We had copied over some settings from other systems that are behind that same reverse proxy.
Basically the solution was basically, to change the WSGIScriptAlias source from / to
WSGIScriptAlias /puppetboard "/srv/puppetboard/puppetboard/wsgi.py"

And then in our reverse proxy section we had:
      SetOutputFilter INFLATE;proxy-html;DEFLATE;
      ProxyPass http://localhost:8083/
      ProxyPassReverse /

Which is now
      ProxyPass http://localhost:8083/puppetboard/
      ProxyPassReverse /puppetboard
      ProxyHTMLURLMap / /puppetboard/

We could probably get rid of the ProxyHTMLURLMap alltogether by changing one of the application settings so that it knows its under /puppetboard. But this works for now. Thanks for your patience.

I've seen the error while using Nginx in front of Puppetboard served via Gunicorn. Not sure what changed between 0.2.1 and 0.2.2 since the Nginx configuration is the same.

The internal server error is pretty common when things are misconfigured.  This one was due to a pretty custom apache config getting in the way.
 This will help logging and identify misconfiguration.