Vend contraband/emag inventory expansion

About the PR

Adds contraband (disable MGR) and emagged inventory to multiple vends
...and also operative larp clothes, and do a 2-year old TODO. Too small/insignificant to atomize.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

add: Added hidden items in multiple vending machines.

@EmoGarbage404 does cybsun pen/toxinbottle in emagged lawdrobe and chemvend respectively warrant a discussion?

I am not a maintainer. I do often give balance insight and my opinion, but that opinion means nothing. For PR review and approval, you are better off seeking someone in an official position (maintainer) rather than me.
(The thing you asked sounds fine imo. I would take a second opinion, however)


Custom Certificates: source of kube-ca.pem file?

After running rke cert generate-csr, I do not see either kube-ca.pem, or kube-apiserver-requestheader-ca.pem, (assuming the latter is a symlink); however, per the doc this file should be in the ./cluster_certs directory.
See: https://rancher.com/docs/rke/latest/en/installation/certs/#generating-certificate-signing-requests-csrs-and-keys

See also: https://github.com/rancher/rke/issues/2168#issuecomment-678005765


Any chance to convert to Metal? OpenGL deprecated in iOS 12

Since iOS 12 has deprecated OpenGL / GLKView, it would be great if this project could be converted to Metal. I don't know how much longer OpenGL will still work in iOS. Current version is iOS 13.3 and it still works. But still, one day it will fail.

OpenGL is a standard in all platforms, it's weird that they even deprecated it...


Display all roles when an admin, filter by OnlyAdminCanApply when not

There's a logic problem when trying to apply Roles to Groups. When the OnlyAdminCanApply checkbox for Roles is check, the Roles don't show up in the dropdown for Groups when the logged in user is an admin. It does appear when the logged in user is not an admin.

This doesn't make any sense, so I'm just reverting the logic there. When the user is an admin it will display all Roles, when not, it will filter by the OnlyAdminCanApply attribute.

I think you're right. ;D


including NER tasks

Hi
I would need to run the mt5 model on NER tasks, could you please help adding them? thanks

The WikiAnn NER task has been added here:
https://github.com/google-research/multilingual-t5/blob/master/multilingual_t5/tasks.py#L446


Optimize Custom_Scope_TagV1

We can optimize Custom_Scope_TagV1.
Today the view is only used to get HeatTraces, and is only useed to search a HT and to get a HT. We could also remove a lot of fields in the view, since those is not used. The view is only used in RC.

what is this issue? can we close?

Aman says its closed


Bug: Pranking fails in compact version

The nested token.balanceOf call uses up the vm.prank, resulting in the transfer call being from address(this) and failing.
ERC20 _token = ERC20(0x853d955aCEf822Db058eb8505911ED77F175b99e);
address _whale = 0xce6431d21e3fb1036ce9973a3312368ed96f5ce7;
address _to = address(0); // set 'address(0)' to the receiver
vm.prank(_whale);
_token.transfer(_to, _token.balanceOf(_whale));

Should be
ERC20 _token = ERC20(0x853d955aCEf822Db058eb8505911ED77F175b99e);
address _whale = 0xce6431d21e3fb1036ce9973a3312368ed96f5ce7;
address _to = address(0); // set 'address(0)' to the receiver
address _amount = _token.balanceOf(_whale);
vm.prank(_whale);
_token.transfer(_to, _amount);

Thank you sir for point it out, resolved on https://github.com/codeislight1/token-dealer/commit/4afe3cf8cf3262dbb6f78ac445d5a1948df5c89a


[Fix #9874] Fix a false positive for Style/RegexpLiteral

Fixes #9874.
This PR fixes a false positive for Style/RegexpLiteral when using %r regexp literal with EnforcedStyle: omit_parentheses of Style/MethodCallWithArgsParentheses.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic Looks good! Can you please merge this and cut a new release later today, as I'm traveling for the next few days and there's an important bugfix we need to ship.

@bbatsov I get it! I will release RuboCop 1.17 later today.

RuboCop 1.17 is out :-)
https://github.com/rubocop/rubocop/releases/tag/v1.17.0


How to change selected tag color ?

After clicking  tags color is not changing , without changing color how  user will identify which is selected?

The tag group has two mode: APPEND and DISPLAY, the APPEND mode is capable for add tags or remove tags, and the DISPLAY mode is only capable for presentation.
I think you should clone the code and create a SELECT mode which extends the DISPLAY mode.

here same problem too and I put in my style    false

 name="atg_isAppendMode false

can you please tell me when i clicked on tag it select with diffrenet color


Unable to remove old ping locations

I dont see a place to remove old ping locations.

Hey @haxigon, yeah it's not possible to explicitly remove an old ping location. However it works in a FIFO way, the more you add the more get evicted/deleted from the list. Hope that helps.


train

Hello, thank you very much for the work of you and your team. Could you please add your contact information, WeChat or QQ? I would like to make some changes in your work.

Hello, you can send your contact information to my e-mail.


fix up xname/xref within seriesseed_investment_agreement_sg.xml

many of the Section cross-references are hardcoded at the moment.

in progress.


fix netInfo library conflict

fix netInfo library conflict

Hi, @teoarjun I will release npm as soon as possible, Thanks.

Hi Tejas,
Thanks man ☺
Sent from my iPhone

On 22-Jul-2022, at 6:46 PM, Tejas Gajjar @.***> wrote:

Hi, @teoarjun I will release npm as soon as possible, Thanks.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.


aubuf: add auframe functions

this looks good to me. please go ahead and merge (also retest)

Discussion: https://github.com/baresip/rem/discussions/16


usage for libremesh / chef

atm this project was claimed to be the official chef.libremesh.org, the successor of the former chef (https://github.com/libremesh/chef/) which had more features than this project atm.
please provide readme, documentation oder hints:

how to create images for libremesh
how to change package-list, flavors, network-config and local settings

atm this project was claimed to be the official chef.libremesh.org, the successor of the former chef (https://github.com/libremesh/chef/) which had more features than this project atm.

I think there is a misunderstanding. ASU support was added to support libremesh/chef, but I need YAFS for Freifunk projects I am involved in. They do not use libremesh or gluon and the other firmware selectors available have a hard dependency on Gluon.

please provide readme, documentation oder hints:
* how to create images for libremesh

This topic feels to be too far removed from this project...

* how to change package-list, flavors, network-config and local settings

This should be documented in the ASU project, as it is their API.
YAFS should link to that.

ok i will ask libremesh people


fix: improve remove wallet analytics

Checklist

[x] JIRA - LW-10150
[ ] Proper tests implemented
[ ] Screenshots added.

Proposed solution
Improve remove wallet analytics
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes

coverage: 50.567%. remained the same
when pulling 2c8e06c42cfd3ebb8ea305bb58264b96ef85b27d on fix/lw-10150-remove-wallet-analytics
into e8a9096cf2da863f8e75f0933ea9c709589ac0eb on main.


Close modal programatically

First of all, thank you for this plugin!
I'm using this in ionic 3, and as you say in the docs, backNative is set to false. I would like to implement the backNative functionality using ionic, but for that I need some function that I can trigger when the back button is pressed.
Is there a function to do that available or a way I can implement it?

Hi,
Currently there's no public method to close the modal, but you can select the #zuck-modal element and then call el.close();


Can norma convert from fulltext.html to scholarly.html?

I've been using norma quite effectively with an OA journal that provides nice fulltext.xml files for each of its articles.
However, I'm now trying to work with a non-OA journal which doesn't provide XML files, and so I've just got a fulltext.html file and a fulltext.pdf file.
I haven't managed to find a proper list/description of the transforms that can be used with norma (maybe I haven't looked in the right place), but is there any transform that will help me convert me HTML or PDF to scholarly.html files?

Thanks Robin for interest and perseverance.
YES, we can usually convert from HTML to scholarly html. See:
http://discuss.contentmine.org/t/overall-architecture/142/2
(slide 8/9).
The "HTML" created by publishers is hugely variable. Some is excellent semantic XHTML (balanced tags), some is reasonably conformant HTML5. We can use standard tools to convert both of these happily and they are in the norma transforms.
The problem is with
(a) HTML + JS. Some "HTML" is mainly JS which loads pages dynamically. So we have to use a headless browser , often recursively. The "DOM" that results is not an XHTML Dom but may be tractable.
(b) really bad HTML. We have found smart quotes instead of quote, for example. meaningless namespaces, etc.
I have linked 3 Java tidiers into norma - JTidy, JSoup, and HtmlUnit. I am not sure all these are supported. It also makes sense to use tidiers in any other language. Hopefully we can come up with per-publisher hacks.
Other problems are gifs for high-code points, especially in maths, and horrors such as "/" overstriking "=" for not-equals. But they are gradually getting fewer.
Once you have transformed to HTML it may well need reprocessing. If end tags are missed we may get badly nested lists, for example. A single "" is sometimes used as a paragraph separator.
Then it is often unclear where sections start and end. For example:

big title

stuff

more stuff

little title

yet more stuff

second big title

more stuff

This displays to the human eye as sections (just!) but has to be gathered into machine sections.
I have written lots of code to do this, and so have others.

Thanks @petermr that's really useful to know.
I'm currently trying to convert the fulltext.html from http://www.tandfonline.com/doi/full/10.1080/01431161.2014.971469#abstract to scholarly.html. Do you have any suggestions as to which transforms I should start with?
I've tried running some of the 'cleaning' transforms that you mentioned (jsoup, jtidy etc), but I get the following output for all of them:
norma -q . -i fulltext.pdf -o scholarly.html --transform jsoup 0    [main] ERROR org.xmlcml.norma.NormaTransformer  - no transforms given/parsed
Once I have clean HTML (which, as you say, I could get using other tools), how should I run norma to get scholarly.html?

norma -q . -i fulltext.pdf -o scholarly.html --transform jsoup 0 [main] ERROR
are you starting with PDF or HTML? If html you should use one of the three I mentioned. If PDF the transform should be pdf2txt with TXT output.
org.xmlcml.norma.NormaTransformer - no transforms given/parsed
^^
this is a spurious error - ignore it. I thought we had removed it.
list what you want to do and I'll see what the current code will do.

Thanks.
I'm starting with fulltext.html (from the URL I gave in my last message) and trying to get scholarly.html.
When running this: norma -q . -i fulltext.html -o scholarly.html --transform jsoup, I get the output:
0    [main] ERROR org.xmlcml.norma.NormaTransformer  - no transforms given/parsed
.

I thought the . was a sort of progress bar saying norma has processed something - but there is no scholarly.html in the output directory. There is also nothing in the logs in the target directory - is there a way to turn on some sort of verbose/debug logging?
I've tried with --transform set to jsoup, jtidy and htmlunit and I get the same results for all of them: the error about no transforms given and no scholarly.html output.

Has there been any progress on this?
I'd love to be able to take fulltext.html (from http://www.tandfonline.com/doi/full/10.1080/01431161.2014.971469#abstract) and convert it to scholarly.html.

Suggest that you work with the development branch of norma. Tom is in
charge of this and you and I can branch and make pull requests.
The message no transforms given/parsed is misleading and I think has been
withdrawn.
If you can commit a (failing) test with a CProject of (say) 2 CTrees at
most then we can jointly debug this. I think it's a general problem - not
just T+F . I am keen we get norma cleaned up!
P.
On Fri, Apr 29, 2016 at 10:01 AM, Robin Wilson<EMAIL_ADDRESS>wrote:

Has there been any progress on this?
I'd love to be able to take fulltext.html (from
http://www.tandfonline.com/doi/full/10.1080/01431161.2014.971469#abstract)
and convert it to scholarly.html.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/ContentMine/norma/issues/23#issuecomment-215663497

--
Peter Murray-Rust
Reader in Molecular Informatics
Unilever Centre, Dep. Of Chemistry
University of Cambridge
CB2 1EW, UK
+44-1223-763069

The error message still happens when it can't find a transform or a stylesheet. It just used to also happen when it was only passed a stylesheet and no transform (these internals are a little bit unclear to an outsider)
I'm not sure that @robintw has built from source and in any case he (and we) probably can't distribute CTrees containing closed access papers. If you could make a test that fails (using JUnit) from an open source that would be fairly awesome but if you're not a java developer then don't sweat it.
I can always try and replicate the bug on the open literature so we can distribute a test.

I think we can find some Open Access T+F papers...
On Fri, Apr 29, 2016 at 4:54 PM, tarrow<EMAIL_ADDRESS>wrote:

The error message still happens when it can't find a transform or a
stylesheet. It just used to also happen when it was only passed a
stylesheet and no transform (these internals are a little bit unclear to an
outsider)
I'm not sure that @robintw https://github.com/robintw has built from
source and in any case he (and we) probably can't distribute CTrees
containing closed access papers. If you could make a test that fails (using
JUnit) from an open source that would be fairly awesome but if you're not a
java developer then don't sweat it.
I can always try and replicate the bug on the open literature so we can
distribute a test.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/ContentMine/norma/issues/23#issuecomment-215774333

--
Peter Murray-Rust
Reader in Molecular Informatics
Unilever Centre, Dep. Of Chemistry
University of Cambridge
CB2 1EW, UK
+44-1223-763069

TandF_OA_Examples.tar.gz is a compressed directory containing two open-access papers scraped from the T&F journal the International Journal of Remote Sensing. It should work as an example for the problems I'm having.
I have tried running norma -q . -i fulltext.html -o scholarly.html --transform jsoup in that directory (this may or may not be the right command to try and run), and I get the output:
0    [main] ERROR org.xmlcml.norma.NormaTransformer  - no transforms given/parsed
.%

I can manage little bits of Java programming if necessary, but I don't have any experience of JUnit and would rather not get too far into that...!

@robintw
The commands are badly documented. I tested:
		File targetDir = new File("target/tutorial/tf");
		CMineTestFixtures.cleanAndCopyDir(new File("src/test/resources/org/xmlcml/norma/pubstyle/tf/TandF_OA_Test"), targetDir);
		String args = "--project "+targetDir+" -i fulltext.html -o scholarly.html --html jsoup";
		DefaultArgProcessor argProcessor = new NormaArgProcessor(args);
		argProcessor.runAndOutput();

and got an output:
so try:
norma -q . -i fulltext.html -o scholarly.html --html jsoup

This is a mess. I think we should bring html2scholarly back to --transform
and allow what you wrote.

Note, the the result is nowhere near scholarlyHtml - it's a mess because it needs structuring. But at least it's well-formed.

Thanks a lot - it's definitely progress to be able to get it to run!
As you probably saw, it gives an error saying .!1    [main] ERROR org.xmlcml.norma.NormaArgProcessor  - Cannot parse HTML, but at least it produces the output.
I had a look at the output and found that it wasn't very close to scholarly HTML! What is the best way forward to try and improve the structuring of the output to get it as close to 'proper' scholarly HTML as possible? I'm happy to have a play with bits of code if you can point me in the right direction.

I think it needs an XSL stylesheet to snip off the useless publisher stuff. It's tedious rather than difficult. It's relatively easy if you know it;s a TF paper - harder to recognize that it is one in a mixed bunch. How keen are you for this? I can give you a start and suggest you add the details. It's not hard once I have started this. I also need to think of the command to do it... more tomorrow.

TIDY html. I think we are going to have to have three or 4 passes for normalizing HTML.

turn non-wellformed HTML into wellformed using standard tools (tidy, htmlunit, jsoup, etc.)
remove publisher cruft - scripts, advertising, publisher self-promotion, metrics
create a structured document (e.g. nested divs )
tag sections and create conformant ScholarlyHTML

I think we should have a separate issue for this... and will create it.


GraphQL: JSON encoding not implemented for public_key

# mina adv pooled-user-commands
(monitor.ml.Error (Failure "JSON encoding not implemented for public_key!")
 ("Raised at Stdlib.failwith in file \"stdlib.ml\", line 29, characters 17-33"
  "Called from Graphql_lib__Serializing.unimplemented_serializer in file \"src/lib/graphql_lib/serializing.ml\" (inlined), line 10, characters 50-78"
  "Called from Graphql_lib__Serializing.Public_key.serialize in file \"src/lib/graphql_lib/serializing.ml\" (inlined), line 120, characters 18-55"
  "Called from Init__Graphql_queries.Pooled_user_commands.Pooled_user_commands_inner.serialize.(fun) in file \"_none_\", line 0, characters 254-1023"
  "Called from Stdlib__Array.map in file \"array.ml\", line 106, characters 21-40"
  "Called from Init__Graphql_queries.Import_account.Import_account_inner.serialize in file \"_none_\", line 0, characters 254-1023"
  "Called from Init__Client.pooled_user_commands.(fun) in file \"src/app/cli/src/init/client.ml\", line 1147, characters 29-49"
  "Called from Async_kernel__Deferred1.M.map.(fun) in file \"src/deferred1.ml\", line 17, characters 40-45"
  "Called from Async_kernel__Job_queue.run_job in file \"src/job_queue.ml\" (inlined), line 128, characters 2-5"
  "Called from Async_kernel__Job_queue.run_jobs in file \"src/job_queue.ml\", line 169, characters 6-47"))


5076 upgrade patternfly 5 (#5140)

Pull request opened by the merge tool on behalf of #5140

Merged in db72e5ba4f162e7d80d1f7e1d5dd3d469fae7139


rtaudio: 5.0.0 -> 5.1.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/rtaudio/versions.
meta.description for rtaudio is: '"A set of C++ classes that provide a cross platform API for realtime audio input/output"'.
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 5.1.0 with grep in /nix/store/gn1mri67f6ijw6l2zapamixf8x079j4m-rtaudio-5.1.0
directory tree listing: https://gist.github.com/2221bf5268bb139c33240e0df1197600
du listing: https://gist.github.com/c8c1e671e61ab9691b7f107a38b50acc

Rebuild report (if merged into master) (click to expand)

11 total rebuild path(s)
4 package rebuild(s)
4 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
i-score
muse
rtaudio
vcv-rack

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gn1mri67f6ijw6l2zapamixf8x079j4m-rtaudio-5.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A rtaudio https://github.com/r-ryantm/nixpkgs/archive/d9e9d72e81df3d779df24c34a5f965c6e3662ad4.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gn1mri67f6ijw6l2zapamixf8x079j4m-rtaudio-5.1.0
ls -la /nix/store/gn1mri67f6ijw6l2zapamixf8x079j4m-rtaudio-5.1.0/bin

cc @magnetophon for testing.

nox-review WFM, non-nixos linux x86_64


Add padding to the exit and reload butttons so they don't overlap with battery status on ipad

fixed in #196


How to archive log files used as source of Log Analytics agent custom log

Log files must be rotated or archived for disk space management.
Defining a Log Analytics agent custom log does not allow for log file rotation.
How can such a log file be archived / content deleted to properly manage disk space and have the agent still upload data correctly to Log Analytics?
Note: we are using this mechanism with a log4j RollingFile adapter with immediateFlush=true, and it seems to work, I did not check though if any messages may be lost.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cf637b70-eb07-3fd7-4594-c52af96f5ad8
Version Independent ID: 29eced7b-1277-4ee1-21d0-0079d6b95a2f
Content: Collect custom logs with Log Analytics agent in Azure Monitor - Azure Monitor
Content Source: articles/azure-monitor/agents/data-sources-custom-logs.md
Service: azure-monitor
Sub-service: agents
GitHub Login: @bwren
Microsoft Alias: bwren

@ciufudean  - Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can review and update accordingly.

any update on this?

Sorry, took some time to get to our backlog here. You would presumably need some automated method to move out the log on a nightly basis. You could create your own automated method to collect the log using the new custom logs API. Beyond that, you may want to check the Azure Monitor Q&Q forum for alternate ideas.
#please-close

@ciufudean could you please share your log4j config you use.

here my log4j2 attempt: https://gist.github.com/TiloGit/071105f053e1961146dcfe0622d1915c


Error load fields

When I try to get the parent id, I get an error "Fatal error: Cannot access field before it is initialized or fetched: country_id".
I found that all fields are empty except id
extension AddressModel {
    func getCountry(context: Context, _: NoArguments, eventLoopGroup: EventLoopGroup) async throws -> CountryModel? {
        let id = self.$country.id
        return try await context.request.graphQLDataLoader
            .countryLoader.load(key: id, on: eventLoopGroup).get()
    }
}

This is Parent and not OptionalParent. The country_id field in the database is full. I don’t do join and with because I just need to get the parent’s id, I also tried to get here and other fields, for example zip_code, this field is also filled in the database but comes empty. As a result, I can only get the id. I used this library before and getting the parent id worked.

Can you share more about the AddressModel and the schema as well? I'll look into it and figure out why this is could be happening.

This happens with any model, not just the AddressModel. Here's what the AddressModel looks like:
final class AddressModel: Model {
    static let schema = "addresses"

    @ID(key: .id)
    var id: UUID?

    @Field(key: .address)
    var address: String

    @Field(key: .zipCode)
    var zipCode: String

    @Field(key: .city)
    var city: String

    @OptionalField(key: .longitude)
    var longitude: Double?

    @OptionalField(key: .latitude)
    var latitude: Double?

    @Parent(key: .countryID)
    var country: CountryModel

    @Timestamp(key: .createdAt, on: .create)
    var createdAt: Date?

    @Timestamp(key: .updatedAt, on: .update)
    var updatedAt: Date?

    @Timestamp(key: .deletedAt, on: .delete)
    var deletedAt: Date?

    init() {}

    init(
        address: String,
        zipCode: String,
        city: String,
        longitude: Double?,
        latitude: Double?,
        countryID: CountryModel.IDValue
    ) {
        self.address = address
        self.zipCode = zipCode
        self.city = city
        self.longitude = longitude
        self.latitude = latitude
        self.$country.id = countryID
    }

    init(_ arguments: CreateAddressArguments) {
        self.id = UUID()
        self.address = arguments.address
        self.zipCode = arguments.zipCode
        self.city = arguments.city
        self.longitude = arguments.longitude
        self.latitude = arguments.latitude
        self.$country.id = arguments.countryID
    }
}

In the schema, the type looks like this:
    Type(AddressModel.self) {
        Field("id", at: \.id)
        Field("address", at: \.address)
        Field("zipCode", at: \.zipCode)
        Field("city", at: \.city)
        Field("longitude", at: \.longitude)
        Field("latitude", at: \.latitude)
        Field("country", at: AddressModel.getCountry, as: TypeReference<CountryModel>.self)
        Field("createdAt", at: \.createdAt)
        Field("updatedAt", at: \.updatedAt)
    }

I couldn't reproduce the issue.
I tried getting the Parent relation (getting the parent's id) and make a similar models worked fine as long as its correct in the database.
Here is the code I used

Model classes
final class User: Model, Content {
    static var schema: String = "users"

    @ID(key: .id)
    var id: UUID?

    @Field(key: "name")
    var name: String

    init() { }

    init(id: UUID? = nil, name: String) {
        self.id = id
        self.name = name
    }
}

final class Item: Model, Content {
    static let schema = "items"

    @ID(key: .id)
    var id: UUID?

    @Field(key: "name")
    var name: String

    @Parent(key: "user_id")
    var user: User

    init() { }

    init(id: UUID? = nil, name: String, userID: UUID) {
        self.id = id
        self.name = name
        self.$user.id = userID
    }
}

extension Item {
    func owner(ctx: Context, _: NoArguments) async throws -> User? {
        // I receive no fatal error here
        print("\(self.$user.id)")
        // No fatal error here either
        return try await User.query(on: ctx.req.db).filter(\.$id == $user.id).first()
    }
}

Type(Item.self) {
    Field("name", at: \.name)
    Field("owner", at: Item.owner, as: TypeReference<User>.self)
}

Can share how do you fetch the AddressModel itself (the Query / Mutation resolver) before the getCountry method was called?

Resolver
    func getAddress(
        context: Context,
        arguments: IDArgument
    ) async throws -> AddressModel {
        guard
            let model = try await AddressModel.query(on: context.request.db)
            .filter(\.$id == arguments.id)
            .first()
        else {
            throw Abort(.notFound, reason: "Address with id \(arguments.id) not found")
        }
        return model
    }

Schema
    Query {
        Field("getAddress", at: GraphQLResolver.getAddress) {
            Argument("id", at: \.id)
        }
    }

Country field is empty

I'll try to look into it more to find what went wrong here.
Honestly, I am not sure why is this happening. My test code also uses PostgreSQL but mine worked. There is nothing out of the ordinary with the code you shared, so it should work fine. The only notable thing is that your model is  @Parent(key: .countryID) instead of @Parent(key: "country_id"), but if that part compiles, it shouldn't break all of the sudden.
I'll also share my migrations code used to build the tables for my test code, just in case you manage to find the problem from it
struct CreateUser: AsyncMigration {
    func prepare(on database: Database) async throws {
        try await database.schema("users")
            .id()
            .field("name", .string)
            .create()
    }

    func revert(on database: Database) async throws {
        try await database.schema("users").delete()
    }
}

struct CreateItem: AsyncMigration {
    func prepare(on database: Database) async throws {
        try await database.schema("items")
            .id()
            .field("name", .string)
            .field("user_id", .uuid, .references("users", "id"))
            .create()
    }

    func revert(on database: Database) async throws {
        try await database.schema("items").delete()
    }
}

I found what the problem is, I wrote a parser for the fields that come in the request to get from the database only those fields that were requested, and there was no country field in it. This parser is more like a crutch. Perhaps you know if there is a way to get the list of requested fields in Graphiti?

It's good to know that you figured out why the bug is happening. I don't think you can get it from Graphiti directly but you could probably grab those requested fields from the Request object, probably by parsing the request into GraphQLRequest.
From that you can access the source and using the GraphQLSwift/GraphQL parse method to get the Document and manually find the field being requested from OperationDefinition.
You will have to go low level into the GraphQLSwift/GraphQL library.
You'll ended up doing something like this.
let gql = try ctx.req.content.decode(GraphQLRequest.self)
let fieldsRequested = try parse(source: Source(body: gql.query))
    .definitions
    .flatMap { def -> [Selection] in
        guard let op = def as? OperationDefinition else {
            return []
        }
        return op.selectionSet.selections
    }
    .compactMap { selection -> Field? in
        guard let field = selection as? Field else {
            return nil
        }
        return field
    }

Thanks for the help!


Add documentation for the new API

For now there is nothing added but I'll update it soon with some draft of documentation

Hi, I just pushed an outline of documentation so that we can discuss it here

Hi, I just added what could be a minimal documentation for a first merge, including minimal descriptions of the preprocessor and the recent changes in the API of Weakly Supervised Metric Learners. I just need to optimize a bit the style (align the text, format well examples sections etc, try to make the sandwich example plot something), before merging I think, but the content should not change so you can already have a look at it. Basically I copied what was already present in the doc/docstrings, into the new sections of the new doc, as we said @bellet and @nvauquie

@perimosocordiae @terrytangyuan maybe you could review this PR ? Then we could merge it as soon as possible into new_api, so that we can then merge new_api to master (cf discussion in https://github.com/metric-learn/metric-learn/pull/117#issuecomment-447198836 )

Thanks for the review @terrytangyuan and @perimosocordiae !

Thanks for the review @bellet ! To answer your remarks:

Thanks, looks good! I left some minor comments.
Additional remarks:
are the docstrings up to date? For instance it does not show preprocessor as an argument of init

This should be updated now that I merged back the updated new_api_design into the PR

code examples in the doc for weakly supervised algorithms use the supervised version! so this should be changed

I agree, I'll update them, for instance with this kind of examples:
from sklearn.datasets import fetch_lfw_pairs
from metric_learn import MMC

dataset = fetch_lfw_pairs()
pairs, y = dataset.pairs, dataset.target
pairs = pairs.reshape(pairs.shape[0], 2, -1)
y = 2*y - 1  # we want +1 to indicate similar pairs and -1 dissimilar pairs
mmc = MMC()
mmc.fit(pairs, y)

Or the same but maybe with a smaller artificial dataset

the previous code examples could be used in the supervised section to document the supervised version of the weakly supervised algorithms (can add later)

I agree, I've added a simple example with MMC. Indeed in the future it could be good to add more documentation on how the constraints are created from a labeled dataset. issue #135 should keep track on that.

like you said it would be nice to show the figures for the sandwich examples (but that can also be done later)

Yes, I'm still trying to understand why it's failing :p

finally, there is an empty "module contents" section in the package overview part

Yes, it was already there in the previous docs, but I'm still trying to understand how this modules and submodules part is generated. @perimosocordiae maybe an idea on that ?

I agree, I'll update them, for instance with this kind of examples:
from sklearn.datasets import fetch_lfw_pairs
from metric_learn import MMC

dataset = fetch_lfw_pairs()
pairs, y = dataset.pairs, dataset.target
pairs = pairs.reshape(pairs.shape[0], 2, -1)
y = 2*y - 1  # we want +1 to indicate similar pairs and -1 dissimilar pairs
mmc = MMC()
mmc.fit(pairs, y)

Looks good, but I would indeed use a smaller dataset

I agree, I've added a simple example with MMC. Indeed in the future it could be good to add more documentation on how the constraints are created from a labeled dataset. issue #135 should keep track on that.

Maybe this should be put in the supervised section instead? Linking "weakly-supervised algorithm" in the text to the appropriate section, and maybe rename "_Supervised version" into "Supervised versions of weakly-supervised algorithms"

finally, there is an empty "module contents" section in the package overview part

Yes, it was already there in the previous docs, but I'm still trying to understand how this modules and submodules part is generated. @perimosocordiae maybe an idea on that ?

maybe last reply in https://github.com/sphinx-doc/sphinx/issues/3177 ?

Looks good, but I would indeed use a smaller dataset

I've updated the docs with some toy dataset

I've updated the examples in the weakly supervised section as you said

finally, there is an empty "module contents" section in the package overview part

Yes, it was already there in the previous docs, but I'm still trying to understand how this modules and submodules part is generated. @perimosocordiae maybe an idea on that ?

maybe last reply in sphinx-doc/sphinx#3177 ?
otherwise it looks like "module contents" will show the docstring of __init__.py, and there is an option to show this before the submodules:
sphinx-doc/sphinx#2190

Turns out it comes from the file metric_learn.rst. I changed it manually, but I guess it was generated at the beginning with some command like sphinx-apidoc as in the link you gave @bellet
So I don't know if my manual modification is what would generate sphinx-apidoc with the right flag --implicit-namespaces from https://github.com/sphinx-doc/sphinx/issues/3177#issuecomment-434746494, but maybe this is fine for now and later we could think of the process of generating the rst files ?

Turns out the problem with sandwich.py was that it needs to be named plot_sandwich.py to be executed: https://sphinx-gallery.readthedocs.io/en/latest/getting_started.html#structure-the-examples-folder
Now it works

It's likely that we aren't using good parameter settings for SDML in that example. We should file a bug to investigate further, though.

Docs are merged! Now we can merge new_api_design into master.


[SourceKit] Resolve info request

This adds a new request to SourceKit that provides resolve information for the references in a file. It returns the path to the document, the offset, and the length of the declaration if this information is available. For the declarations that are not in the
project sources, it returns the USR and the module name. tools/SourceKit/docs/Protocol.md contains a detailed description of the request.
@rintaro do you mind taking a look at this?

Added USR to the response for declarations that aren't in generated interfaces and updated tests accordingly.

Thanks for the feedback. I didn't know about the -index-include-locals. If I update our internal strategy a bit, I think it might be a better fit than the request I was working on. I will close this PR for now.


faster_rcnn_end2end.sh: command not found

linyi@TITAN-X:~/study/Faster-RCNN_TF/experiments/scripts$ sh faster_rcnn_end2end.sh gpu 3 VGG16 pascal_voc

set -e
export PYTHONUNBUFFERED=True
PYTHONUNBUFFERED=True
DEV=gpu
DEV_ID=3
NET=VGG16
DATASET=pascal_voc
array=($@)
len=4
EXTRA_ARGS=
EXTRA_ARGS_SLUG=
case $DATASET in
TRAIN_IMDB=voc_2007_trainval
TEST_IMDB=voc_2007_test
PT_DIR=pascal_voc
ITERS=70000
++ date +%Y-%m-%d_%H-%M-%S
LOG=experiments/logs/faster_rcnn_end2end_VGG16_.txt.2018-08-02_11-13-15
faster_rcnn_end2end.sh: line 48: syntax error near unexpected token `>'

the last line is the error

You can comment out 48, 49, 50 lines (plus # in front), but the result is training without log files.


[DPE-4595] Immediate connection on database created

Issue
Pgbouncer is not set up to receive connections immediately when publishing credentials
Solution
Sync up configuration and reload PGB when establishing the interface

This seems to cause instability on juju 2 scale up, but I want early feedback since the changes are aggressive.


When VideoPlayer and TextButton are placed on the Stack, buttons do not work when Transform or FittedBox is used

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
When VideoPlayer and TextButton are placed on the Stack, buttons do not work when Transform or FittedBox is used.
At first, I tried to apply FittedBox's BoxFit, but I found a problem that buttons on the web did not work.
I applied Transform.scale to find another solution, but the same problem occurred.
If I remove the Transform widget or change Transform.scale to 1, the problem does not occur.
The same problem occurs when the Transform widget is changed to FittedBox.
Expected results
A button event is fired at the button's position.
Actual results
Button events are firing in the wrong place on the screen.
When you move the mouse, you can see that the button hover effect occurs in a completely different place.
Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:video_player/video_player.dart';

void main() {
  runApp(const MainApp());
}

class MainApp extends StatefulWidget {
  const MainApp({super.key});

  @override
  State<MainApp> createState() => _MainAppState();
}

class _MainAppState extends State<MainApp> {
  late VideoPlayerController _controller;

  @override
  void initState() {
    _controller = VideoPlayerController.network(
      'https://flutter.github.io/assets-for-api-docs/assets/videos/bee.mp4',
    )..initialize().then((_) {
        setState(() {});
      });

    super.initState();
  }

  @override
  void dispose() {
    _controller.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Stack(
          fit: StackFit.expand,
          children: [
            ClipRect(
              child: Transform.scale(
                scale: 1.5,
                child: Container(
                  width: double.infinity,
                  height: double.infinity,
                  color: Colors.red,
                  child: TestVideoPlayer(controller: _controller),
                ),
              ),
            ),
            DecoratedBox(
              decoration: const BoxDecoration(color: Color.fromRGBO(0, 0, 0, 0.5)),
              child: Column(
                children: [
                  SizedBox(
                    width: 48,
                    height: 48,
                    child: TextButton(
                      onPressed: () {
                        print("touch");
                        if (_controller.value.isPlaying) {
                          _controller.pause();
                        } else {
                          _controller.play();
                        }
                      },
                      child: const Icon(
                        Icons.settings,
                        color: Colors.white,
                      ),
                    ),
                  ),
                ],
              ),
            ),
          ],
        ),
      ),
    );
  }
}

class TestVideoPlayer extends StatelessWidget {
  const TestVideoPlayer({
    super.key,
    required VideoPlayerController controller,
  }) : _controller = controller;

  final VideoPlayerController _controller;

  @override
  Widget build(BuildContext context) {
    return Stack(
      children: [
        AspectRatio(
          aspectRatio: _controller.value.aspectRatio,
          child: VideoPlayer(_controller),
        ),
      ],
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/75677950/a2672a0e-05ee-46e6-ac5e-cfadf843c539

Logs
Logs
Launching lib\main.dart on Edge in debug mode...

Exited.

Flutter Doctor output
Doctor output
[√] Flutter (Channel master, 3.11.0-6.0.pre.86, on Microsoft Windows [Version 10.0.22621.1555], locale ko-KR)
    • Flutter version 3.11.0-6.0.pre.86 on channel master at D:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ea5eddb5a9 (27 hours ago), 2023-05-15 21:39:26 -0700
    • Engine revision c4d4b40c65
    • Dart version 3.1.0 (build 3.1.0-113.0.dev)
    • DevTools version 2.23.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at D:\Android\sdk
    • Platform android-33-ext5, build-tools 33.0.2
    • ANDROID_HOME = D:\Android\sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.2.3)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.2.32526.322
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2022.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)

[√] VS Code (version 1.78.2)
    • VS Code at C:\Users\sgbai\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.64.0

[√] Connected device (4 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 12 (API 31) (emulator)
    • Windows (desktop)            • windows       • windows-x64    • Microsoft Windows [Version 10.0.22621.1555]
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 113.0.5672.93
    • Edge (web)                   • edge          • web-javascript • Microsoft Edge 112.0.1722.64

[√] Network resources
    • All expected network resources are available.

Hi @sgbai78
This issue looks similar to a recent issue at https://github.com/flutter/flutter/issues/126754. After checking this on Flutter 3.7.12, I see it can work as expected.
So I will close this issue as a duplicate of https://github.com/flutter/flutter/issues/126754, please follow up on that issue for further updates. Thanks!


SimpleGoogleAnalytics dll not found

I download XML notepad v <IP_ADDRESS> from https://microsoft.github.io/XmlNotepad/##handy-features-include
It works well but when I start it I get this error. If you click it away XML notepad will start fine.

Correction, the program was not usable as it threw exceptions while executing.
I used the click once version and that works.
The problem seems to be wit the standalone installer.

Thanks for the but report I published a new version that adds the missing dependencies, thanks.

Should be fixed now.


Add --stdout to format tool

Allow crystal tool format to output to stdout instead of modifying files in-place by specifying --stdout.
This is a very basic implementation that introduces the minimal amount of change.
Closes #1863

I couldn't find an appropriate spec to modify. I either didn't know where to look, or we're not directly testing invocations of the CLI with different arguments.

@luislavena Done

Would be better to have --output option (or -o)? If - is specified, the output would be the stdout, otherwise it writes to the file with the name passed as argument.

@waj  I considered that but it's a little awkward with formatting multiple files or an entire directory. --output doesn't have a real meaning in that case.

@meagar @jhass Do we have a real use case for this? (like, do you need it for an IDE plugin?) If not, let's keep things as they are right now.

My usecase that I would attempt with this would stay to single files.

@waj suggested to me the same, but doing that diff algorithm would basically be the the diff algorithm, so I would do cat file | crystal too format - | some_diff of some sort and that's it.

@asterite No use case. Interested in the project, wanted to contribute, picked the first issue that looked doable from https://github.com/manastech/crystal/issues

I'm closing this. If anyone needs this for a specific use case (i.e.: you need it in a tool you are building) please reopen or send a PR. Thanks!


Confirmation token is invalid

I just tried create an account and receive this error when I click on confirmation link
Resend confirmation instructions
1 error prohibited this user from being saved:

    Confirmation token is invalid

I receive same message!

Me too.
And another thing, if I try to resend the validation token, the same token was sended to my e-mail.
I first try to login with Twitter, but no success. Then I tried the "old school" way. And the message above was shown. So I think that when my first attemp to login with Twitter fail, then other attemps failed too.

+1

@ricardovaleriano can you merge the PR #101 to fix this?
Tks

Should be solved by #101, can you guys check and repot any problems?
Thank you @lucianosousa!


Add test where compaction selector sporadically throws an exception.

Add test that does the following to org.apache.accumulo.test.CompactionIT

Create a compaction selector that only compacts file names that match a pattern and throws an exception randomly 50% of the time.
Initiate a compaction of a subset of file using above selector.  Confirm subset if compacted.
Add files and run above step a few times.

This test will ensure that compaction selector is retried when it throws an exception and a single exception does not cause compactions to hang.

I will look at it.

@keith-turner   Is this ticket still relevant base on your new updates to Compaction? If so, what components do I directly affect to accomplish the task? Plus, what was your expected result?

@tynyttie As far as I can tell this ticket is still relevant.  You would still be creating a CompactionSelector implementation as described and initiating the compaction.

@tynyttie I would add the test to the following class.
https://github.com/apache/accumulo/blob/main/test/src/main/java/org/apache/accumulo/test/CompactionExecutorIT.java
The test could do something like the following.  Could create BuggySelector as a static public class in CompactionExecutorIT
@Test
public void testBuggySelector(){
     //TODO create table bst and Accumulo client

    // add 3 files to table...
    addFile(client, "bst", 1, 1000, false);
    addFile(client, "bst", 1, 500, false)
    addFile(client, "bst", 1, 250, false)

  // get the current files
   var files = getFiles(client, "bst");

   // TODO somehow select a random subset of files from above set
  randomSubset = ....
  String rsl = .... somehow join randomSubset into a comma sep list

  // configure compaction to use BuggySelector. BuggySelector should select the files passed in the option fileToCompact and it should sometimes randomly throw an exception.
   var cc1 = new CompactionConfig()
       .setSelector(
           new PluginConfig(BuggySelector.class.getName(), Map.of("filesToCompact", rls)))
       .setWait(true);

     client.tableOperations().compact("bst", cc1);

     var files2 = getFiles(client, "bst");
     // TODO verify that files does not contain anything from randomSubset
}

@keith-turner Thank you for replying back to me. My issue is when the unchecked exception is thrown, where in Compaction Manger hierarchy should I appropriately handle it in order for Accumulo to re-kick and select a new compact-able? Should it be in the Compaction Manger Class, Compaction Executor class or Compaction Service class?

My issue is when the unchecked exception is thrown, where in Compaction Manger hierarchy should I appropriately handle it in order for Accumulo to re-kick and select a new compact-able?

@tynyttie my hope is that it already works, but the test will let us know if it actually works.  The following code is where files are selected.
https://github.com/apache/accumulo/blob/18ba45e144ea8213a9637fe36bf0d8a68c3f15f5/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactableImpl.java#L328
If an exception is thrown, the following should catch and hopefully reset things to a good state so that future compactions can run if an exception is not thrown.
https://github.com/apache/accumulo/blob/18ba45e144ea8213a9637fe36bf0d8a68c3f15f5/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactableImpl.java#L353


Sign up API seems to be down

I'm attempting to sign up for a huggingface account and, during the sign-in process, this is what the web interface returned after 20-30 seconds of stalling without a sign that the signup form submittal occurred:

Steps to reproduce:

Fill in a valid email address and password into the form
Press enter or manually press the "Next" button
Wait until the console is updated (took 20-30 seconds on my internet connection)

As a result, I'm unable to create an account.

To clarify, this is not an internet connectivity issue. Other websites load very quickly

we had some intermittent backend trouble today, it's possible this was related


sql: execute queued up schema change through synchronous path

PR: https://github.com/cockroachdb/cockroach/pull/15598
From alpha release notes:

Schema change commands now wait until the schema change is complete instead of starting it in the background

No usage updates required, and we don't have explicit docs on how online schema changes work, so closing this for now.


too many open files

Hi, thanks, probably you have much bigger project than I used for testing. Will fix that, need to change a way I do initial scanning of project structure.

Thanks！

Same here, running it on a mid-sized angular 6 app. Thanks for starting the project, looking forward to seeing it in action.

Make sure, you do not point codecrumbs to directory that contains node_modules dir.

thanks, I will try to fix that ASAP.
@wiecznyPoszukiwacz thanks for pointing out, I actually now doubtful if I do filter node_modules, will make sure to do.

@TUPOBO @chrisjibm I just published v1.1.1, it excludes node_modules (and few more fixes).
Can you please test and let me know it's fine now? If it's still failing I will think about chunking approach with reading files.

@ar-naturalint FYI

Sorry for delay, only just got to this. Thanks for the update, no more errors :)

Awesome, thanks, closing the issue then ;)


Reset STEP to 0 and fix YAML files

Reset STEP to 0
Fix YAML conditional expressions
Use skills/action-update-step@v1
Delete 'close' in <details id=1>
Some minor changes

Why:
Closes #7
What's being changed:

First, I reverted 51da327 to reset STEP to 0.
Then I fixed YAML files so that the GitHub Actions workflows can function as expected.
I also edited the 'Update to step n' steps.
Check off the following:

[x] For workflow changes, I have verified the Actions workflows function as expected.
[x] For content changes, I have reviewed the style guide.

@andyfeller Thank you for your approval. I would greatly appreciate it if you could merge this PR.


[CP] Please cherry pick da18c7c9a7080cc0ccd8455e1df85289b6445174 into the beta branch

Commit(s) to merge
da18c7c9a7080cc0ccd8455e1df85289b6445174
Target
beta
Issue Description
Future produced by async function has wrong type argument
This is a regression that was introduced in the new restructured async implementation.
What is the fix
In order to create a Future for the result of async closure,
closure needs to instantiate a type argument of its result type.
The result type may reference type arguments of enclosing function or
class and scope builder should visit closure's result type
in order to capture receiver or type arguments variable of parent
factory.
https://dart-review.googlesource.com/c/sdk/+/251320
Why cherry-pick
It is a regression
Risk
low
Issue link(s)
https://github.com/dart-lang/sdk/issues/49424
Extra Info
The CL merges cleanly into the beta channel.

@a-siva is this regression applicable to the stable branch also?
@vsmenon @athomas @sigmundch could you give votes on this cherry-pick?

lgtm

lgtm as well

@a-siva is this regression applicable to the stable branch also?

No.

This fix is cherry-picked in 2.18.0-271.4.beta.


replace handmade PIN with OS authentication

use OS-provided authentication like fingerprint, pattern, other biometrics to unlock an account

Is this for cantillon? Or do you want to have generell os pin? Because then it means, that all accounts on the app are connected to the same pin

the question is: would more then one person use the same phone (maybe not).

The OS can register many fingerprints, so it doesn't actually matter how many people use a device

Ok, should I look into it?

yes, I think this could be nice. should be fairly easy though, please revert if it looks like much effort

I would like to do two things here:

The pin dialog should not be a dialog, but a page that opens. This also prevents that the dialog and the keyboard interfere with the currently displayed page. Something like this, but encointer style:

If the biometric login is enabled, display the biometric sign on the page, and ask the user to use his finger.


[$500] [ANDROID APP] Notifications are displayed in the wrong order

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open New Expensify app
Log in with account A
Minimize the application under account A
From another device under account B, send 10 messages (for example, numbers from 1 to 10) to the device with account A.
Check the order in which notifications are displayed on the device with account A

Expected Result:
Notifications are received and displayed in the correct order
Actual Result:
Notifications are displayed in the wrong order
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.64-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/2be01dd5-01d1-43ca-afbb-d15150153a46
Expensify/Expensify Issue URL:
Issue reported by: Applause - Interanal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e28fb1f0dbce38ca
Upwork Job ID:<PHONE_NUMBER>921251328
Last Price Increase: 2023-09-13

Wow, yes can definitely reproduce!

Proposal
Problem Statement
The issue at hand pertains to the incorrect order of notifications in the Expensify app. When messages are sent from one user to another, the notifications are not being received in the expected chronological order. This disrupts the natural flow of communication within the app.
Root Cause Analysis
The root cause of this problem lies in the current notification handling process. Currently, all notification requests are sent to the server in rapid succession. As a result, the server processes these requests asynchronously, leading to notifications being delivered to the recipient in a seemingly random order. This behavior deviates from the sender's original message order.
Proposed Solution
To address this issue effectively, we recommend the following changes:
Introduce Delay: Modify the Android app to incorporate a minor delay when sending notifications to the server. By introducing this delay, we aim to mitigate the asynchronous handling of requests, ensuring that notifications are processed and delivered in the order they were originally sent by the sender.
Alternative Solutions (Optional)
While investigating this issue, we considered alternative solutions. However, after careful analysis, it was determined that introducing a delay in the notification sending process is the most practical and effective approach to resolving the problem. Other alternatives explored included modifying server-side processing and message queuing mechanisms, but these were deemed less efficient and more complex to implement.

Problem Statement:
Notifications from the Expensify app are not always displayed in the intended order on the client device. This can lead to a confusing user experience, as more recent notifications might appear before earlier ones.

Root Cause:

Lack of Sequential Identifiers: The current push notification handling mechanism does not consider the sequence of notifications. Notifications are processed as they arrive, and if there's any delay in the network or the processing of earlier notifications, later notifications might be displayed first.
Server-Side Ordering: It's uncertain if the server sends notifications in a strict sequence. Variabilities in how the server sends notifications or how they're routed through push services can affect the order in which they're received on the client side.

Proposed Solution:
Leverage a promise-based mechanism to ensure notifications are processed and displayed in the correct order:

Buffered Notifications: Store incoming notifications in a buffer.
Promise Queue: Queue notifications as tasks instead of processing them immediately. Each task will be a promise that processes a notification.
Processing Chain: Chain the promises to execute sequentially, ensuring the order of processing.
Error Handling: To prevent any error from disrupting the entire promise chain, integrate proper error handling using async/await with try/catch.

Code Implementation:
let bufferedNotifications = [];
let promiseChain = Promise.resolve();  // Start with a resolved promise as the base of the chain

function pushNotificationEventCallback(notificationEvent) {
    const { pushPayload } = notificationEvent;
    const timestampOrSeqNum = pushPayload.timestamp || pushPayload.sequenceNumber;

    // Check for duplicates
    if (bufferedNotifications.some(notif => notif.notification.id === pushPayload.id)) {
        return;  // Skip processing this notification
    }

    // Add the notification processing as a new link in the promise chain
    promiseChain = promiseChain.then(async () => {
        try {
            // Store the notification in the buffer
            bufferedNotifications.push({
                timestampOrSeqNum: timestampOrSeqNum,
                notification: pushPayload
            });

            // Sort the buffered notifications
            bufferedNotifications.sort((a, b) => a.timestampOrSeqNum - b.timestampOrSeqNum);

            // If the buffer gets too large, process and display the notifications
            if (bufferedNotifications.length > BUFFER_SIZE_LIMIT) {
                displayNotifications();
            }
        } catch (error) {
            console.error("Error processing the notification:", error);
        }
    });
}

function displayNotifications() {
    // Display notifications from the buffer
    console.log(bufferedNotifications);

    // Clear the buffer after display
    bufferedNotifications = [];
}

Alternative Solution:

Direct Handling with Timestamps/Sequence Numbers: Instead of buffering notifications, process them immediately as they arrive. Use their timestamps or sequence numbers to determine if they should be displayed immediately or held back waiting for any missing notifications. This approach minimizes memory usage but might introduce complexities in handling out-of-order arrivals.
Server-Side Adjustments: Collaborate with the backend team to ensure notifications are sent in a strict sequence. Implement server-side mechanisms to confirm delivery or resend missing notifications, potentially reducing the likelihood of out-of-order arrivals.
Custom Notification UI: Implement a custom in-app notification UI to have greater control over the order and display of notifications. Handle any out-of-order scenarios before presenting them to the user.

Bump @Ollyws for reviews!

Bumping @Ollyws for reviews. If you're unable to review, let me know and I can reassign another C+.

Hi @cead22 - hoping you could confirm that this is an Internal issue to be worked on? Thanks!

I think we should close this issue. Push notifications aren't guaranteed to be delivered in the order they're sent to apple/google. Moreover, this is an edge case that is unlikely to be experienced while using the app normally because usually there is some time from the moment you send a chat to the next.
Give that, this is more a feature request than a bug imo.
As an aside, it would be good if the video showed the full reproduction steps (cc @lanitochka17), and if we're just sending 1, 2, 3, ... in full speed, then it reinforces that this is an edge case that isn't reflective of the normal use of the app.
Please reopen if you disagree, including the video showing the full reproduction steps

Issue not reproducible during KI retests. (First week)


Trello Invalid Signature

I have a Google Apps Script program that Does Stuff to Trello cards (and other things) based on external outputs. In this case, we cycle through cards in a certain lane and download their attachments to Google Drive folders indicated in a custom field on each card, then mark the card to say the files have been downloaded. Pretty simple stuff, except Trello's API now doesn't let you directly download files without authentication. While most of the operations you can do in the API just let you pass key and token as URL parameters, downloading a file makes you set up Oauth1 to initiate the GET request. And for the life of me I can't get it to work. I'm using the GAS Oauth1 library and the Trello sample for the library from here:
https://github.com/googleworkspace/apps-script-oauth1/blob/master/samples/Trello.gs
When I run the code, I get "Error starting OAuth flow: Invalid Signature." Here's the contents of the connection object:
{authorizationUrl_=https://trello.com/1/OAuthAuthorizeToken?scope=read,write,
accessTokenUrl_=https://trello.com/1/OAuthGetAccessToken,
consumerSecret_=[REDACTED],
paramLocation_=auth-header,
requestTokenUrl_=https://trello.com/1/OAuthGetRequestToken,
scriptId_=[REDACTED],
consumerKey_=[REDACTED],
method_=get,
serviceName_=trello,
propertyStore_=ScriptProperties,
signatureMethod_=HMAC-SHA1,
callbackFunctionName_=authCallback_Trello,
oauthVersion_=1.0a}
It's not the library, because I can authenticate and post to Twitter through OAuth fine using the same library from the same GAS project. But the error is so vague I can't diagnose what the issue might be. I've tried a variety of different connection scripts but can't get any closer to figuring it out.

Invalid signatures might have something to do with this
https://github.com/googleworkspace/apps-script-oauth1/issues/79


FLUTTER_NOTIFICATION_CLICK action or Navigation from push notifications is not working as expected

I have included  "firebase_messaging" package in my project and added below intent filter in AndroidManifest.xml
<intent-filter>
                <action android:name="FLUTTER_NOTIFICATION_CLICK" />
                <category android:name="android.intent.category.DEFAULT" />
</intent-filter>

Now in my main.dart file I have configured below code in initState() method of the main Application stateful widget which is called via runApp();
---------SETUP------------------
firebaseMessaging.requestNotificationPermissions(
        const IosNotificationSettings(sound: true, badge: true, alert: true));
    firebaseMessaging.onIosSettingsRegistered
        .listen((IosNotificationSettings settings) {
      print("Settings registered: $settings");
    });

    firebaseMessaging.getToken().then((String token) {
      print("FCM Token: " + token);
    });

--------CONFIGURE------------
firebaseMessaging.configure(
      onMessage: (Map<String, dynamic> message){
        print("onMessage :${message.toString()}");
        Navigator.pushNamed(context, '/promote');
      },
      onLaunch: (Map<String, dynamic> message){
        print("onLaunch :${message.toString()}");
        Navigator.pushNamed(context, '/notify');
      },
      onResume: (Map<String, dynamic> message){
        print("onResume :${message.toString()}");
        Navigator.pushNamed(context, '/chat');
      },
    );

with the FCM token printed in my app console I used firebase cURL command mentioned in docs to push a notification . After receiving the notification on my device , I clicked on the notification.
-----ISSUE-----
whenever I clicked on the notification the app gets launched with the route '/' but not with the '/promote' or '/notify' or '/chat' provided in onMessage, onResume or onLaunch callbacks in configure. it is observed the even the print statement is not executed.
Please help in navigation to different screens from Push notification

I got the same problem, I receive the notification, but when I click on notification I just got again the token
I tried app running on background and closed, both I got the notification but I can't get the print events

I guess the context in Navigator.pushNamed(context, '/promote'); is not the one that contains the Navigator that knows about the route.
Use instead a https://docs.flutter.io/flutter/material/MaterialApp/navigatorKey.html and get the context from there to Navigator methods.
See also https://stackoverflow.com/questions/50124355/flutter-navigator-not-working or https://medium.com/coding-with-flutter/flutter-case-study-multiple-navigators-with-bottomnavigationbar-90eb6caa6dbf for how to use navigatorKey

Update
Sorry about that, I didn't see that I was supposed to send the data: "click_action": "FLUTTER_NOTIFICATION_CLICK", so I added this and everything worked :)

work fine when add click_action and FLUTTER_NOTIFICATION_CLICK :D .
tks

Anyone can help me how to run the app in background if the app is terminated. (Because when app terminated then firebase notification are not received by device)

@minh98 Where do I need to add this?

@minh98 Where do I need to add this?

work fine when add click_action and FLUTTER_NOTIFICATION_CLICK :D .
tks

To the "data" object in json

Update
Sorry about that, I didn't see that I was supposed to send the data: "click_action": "FLUTTER_NOTIFICATION_CLICK", so I added this and everything worked :)

where should i put "click_action": "FLUTTER_NOTIFICATION_CLICK" bro?,  anyone can provide a tutorial please.

@jhoanrivers you put "click_action" next to "title" and "body" when sending out the notification.

Update
Sorry about that, I didn't see that I was supposed to send the data: "click_action": "FLUTTER_NOTIFICATION_CLICK", so I added this and everything worked :)

I put it in my notification and data, but still both method are not working..
loh:
D/EGL_emulation(30282): eglMakeCurrent: 0x9e5049c0: ver 2 0 (tinfo 0x890d34a0)
W/FirebaseMessaging(30282): Unable to log event: analytics library is missing
W/FirebaseMessaging(30282): Missing Default Notification Channel metadata in AndroidManifest. Default value will be used.

I guess the context in Navigator.pushNamed(context, '/promote'); is not the one that contains the Navigator that knows about the route.
Use instead a https://docs.flutter.io/flutter/material/MaterialApp/navigatorKey.html and get the context from there to Navigator methods.
See also https://stackoverflow.com/questions/50124355/flutter-navigator-not-working or https://medium.com/coding-with-flutter/flutter-case-study-multiple-navigators-with-bottomnavigationbar-90eb6caa6dbf for how to use navigatorKey

I had the same problem and It has been the solution for me.


When Setting A Breakpoint In VS Code While Debugging OSS, Electron often crashes

I'm on Windows and this is a real paper cut.
I cannot reliably reproduce this. Tell me what you need and I use this issue to collect missing information.
I would love to gain knowledge how I can debug electron issues.
edit: It just happened. This is the error:

If you can follow these steps https://github.com/microsoft/vscode/wiki/Native-Crash-Issues#creating-and-symbolicating-local-crash-reports and attach the crash dump it would be a good start. Thanks!

Thanks for the crash logs, the issue you are hitting is same as https://github.com/microsoft/vscode/issues/122225#issuecomment-827393564. I will merge this to https://github.com/microsoft/vscode/issues/122225


New version: vim.vim version 9.0.1237

Pull request has been automatically created using 🛫 WinGet Releaser.


Add manage product types and attributes permission

Split MANAGE_PRODUCTS to MANAGE_PRODUCTS and MANAGE_PRODUCT_TYPES_AND_ATTRIBUTES.
⚠
Frontend changes required.
SALEOR-1285

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-1285 Split MANAGE_PRODUCTS permission

@korycins I will check docs and update if needed.

Shouldn't we create a feature branch for these changes instead of merging to master? We don't want to release it in 2.11 unless you agreed on something else while I was on sick leave @IKarbowiak.

Related frontend PR: https://github.com/mirumee/saleor-dashboard/pull/768


Minimal shiny example

Not quite sure how this would work in regards to BrowserViz, but I would like to see a minimal example of embedding one of the visualizations created by RCyjs into a Shiny web application.

We are about to start working on this - me and two students working with me this summer.  Progress will be slow at first.   We will contribute to https://github.com/cytoscape/r-cytoscape.js which has been idle for a few years.
BrowserViz won’t be needed - the good folks at RStudio provide other ways to send data and commands back and forth between R and the browser.
You might find igvShiny interesting, a genome browser widget for shiny.
https://github.com/paul-shannon/igvShiny
This is an early version, and builds upon my more extensive work, igvR, which uses the BrowserViz approach.
So there are these two natural sets:
Cytoscape desktop, cytoscape.js, RCyjs, cyjsShiny
IGV desktop, igv.js, igvR, igvShiny
Both of the desktop programs are written in Java.
Note also that the Cytoscape consortium has taken over our Bioconductor package RCy3 - an R interface to the latest Cytoscape desktop. They have done some very fine work with this.

Paul

On Jul 4, 2018, at 6:56 AM, kyleweise<EMAIL_ADDRESS>wrote:
Not quite sure how this would work in regards to BrowserViz, but I would like to see a minimal example of embedding one of the visualizations created by RCyjs into a Shiny web application.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Option import issue

Error with the from tos.views import login line:
Unhandled exception in thread started by <function wrapper at 0x103d295f0>
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/django/utils/autoreload.py", line 226, in wrapper
    fn(*args, **kwargs)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/django/core/management/commands/runserver.py", line 121, in inner_run
    self.check(display_num_errors=True)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/django/core/management/base.py", line 385, in check
    include_deployment_checks=include_deployment_checks,
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/django/core/management/base.py", line 372, in _run_checks
    return checks.run_checks(**kwargs)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/django/core/checks/registry.py", line 81, in run_checks
    new_errors = check(app_configs=app_configs)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/django/core/checks/urls.py", line 14, in check_url_config
    return check_resolver(resolver)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/django/core/checks/urls.py", line 24, in check_resolver
    for pattern in resolver.url_patterns:
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/django/utils/functional.py", line 35, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/django/urls/resolvers.py", line 310, in url_patterns
    patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/django/utils/functional.py", line 35, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/django/urls/resolvers.py", line 303, in urlconf_module
    return import_module(self.urlconf_name)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/Users/jgates/Desktop/SBGBookv2/gbsite/gbsite/urls.py", line 26, in <module>
    url(r'^gbook/', include('gbook.urls')),
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/django/conf/urls/__init__.py", line 50, in include
    urlconf_module = import_module(urlconf_module)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/Users/jgates/Desktop/SBGBookv2/gbsite/gbook/urls.py", line 3, in <module>
    from tos.views import login
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/tos/views.py", line 9, in <module>
    from django.contrib.sites.models import Site
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/django/contrib/sites/models.py", line 86, in <module>
    class Site(models.Model):
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/django/db/models/base.py", line 113, in __new__
    "INSTALLED_APPS." % (module, name)
RuntimeError: Model class django.contrib.sites.models.Site doesn't declare an explicit app_label and isn't in an application in INSTALLED_APPS.

Also wondering what version of Django you're running. Thanks!

That was it. There was another one missing, as well: from django.conf.urls import include in urls.py.
Thanks!


Nether and end not missing rendered chunks correctly 1.15

Environment info

BlockMap version: 1.6.1
Java version: OpenJDK 12
Operating system: macOS 10.15.3
MC 1.15

Description

Some of the regions I render for the end and the nether are empty and seem to have a lot of skipped chunks. The rendered.json reports RENDERED and FULL for most of the fields.
Steps to reproduce

use 1.14.4 world
use the mc jar to --forceUpgrade the chunks to 1.15.2
java -jar BlockMap-cli-1.6.1.jar render -o nether_gen --max-height=72 --create-tile-html world/DIM-1/region

Never mind this, it's just a problem with --create-tile-html and the html now displaying all the regions


Fix cmod/xmod waveform flickering and zoomed barlines flickering

I think it should all work, I tested it in a few scenarios with some advanced stops/scrolls/speeds/etc and it seems fine
Edit: Also added in "Snap Every Scroll" option to get AV-style scrolling because I preferred it over the existing functionality
Edit 2: Also fixed arrow rendering a bit

minor fix, besides that lgtm. good work!


95% Makefile?

https://github.com/KevEdwards/CrazeeRiderBBC

This is because of your use of the .mak extension which is only associated with Makefiles:
https://github.com/github/linguist/blob/58ef7278579a6dca0bc16729836833e19d6d28cd/lib/linguist/languages.yml#L2725-L2735
You'll need to use an override to set the correct language. We'll also consider a pull request to help identify the correct language in future.

Off the top of my head (on mobile right now) I'm not sure why the other files aren't being associated with any language.

It's because the repository's source files are using .6502 as a file extension, which we don't currently associate with any language.
@sharpaper I suggest sending a pull-request to that repository's author to mark the files as assembly if you feel it should be corrected.


-L, -B, -E wrap their argument in P()

-L/--each-line-print "XXX" should be equivalent to -l/--each-line "P(XXX)", same with -E and -B

The savings isn't worth the cost, it will occasionally save 3 characters while increasing complexity.


Add MCP connection and nack rate limiting

Fixes https://github.com/istio/istio/issues/8471
This PR also reworks the scheduling mechanism between the snapshot and serving layers in the MCP layer. The previous logic relied on channels to buffer pending pushed responses between the snapshot and serving code. This made enforcing rate limiting trickier and was potentially subject to pushing unnecessary intermediate state if the snapshot changed at a higher rate than the downstream components ACK/NACK'd. The new scheduling mechanism uses a mailbox to store the latest snapshot and a channel for indicating that the mailbox is full. This should be more durable in cases where write_rate (new snapshot) is greater than read_rate (response pushed to client). The latest snapshot version will be pushed and any intermediate snapshots skipped in such cases.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ayj
If they are not already assigned, you can assign the PR to them by writing /assign @ayj in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/mcp/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
5710ba75325be78e91029fa436d666e19a388257
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
5710ba75325be78e91029fa436d666e19a388257
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/istio-pilot-multicluster-e2e.sh
5710ba75325be78e91029fa436d666e19a388257
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
5710ba75325be78e91029fa436d666e19a388257
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/istio-pilot-multicluster-e2e.sh
5710ba75325be78e91029fa436d666e19a388257
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5710ba75325be78e91029fa436d666e19a388257
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ayj
If they are not already assigned, you can assign the PR to them by writing /assign @ayj in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/mcp/OWNERS
tests/e2e/tests/pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
5710ba75325be78e91029fa436d666e19a388257
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/istio-pilot-multicluster-e2e.sh
5710ba75325be78e91029fa436d666e19a388257
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5710ba75325be78e91029fa436d666e19a388257
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-unit-tests.sh
869d97f0cd7cd86362e08a49333b711bbb5d5135
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ayj
If they are not already assigned, you can assign the PR to them by writing /assign @ayj in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/mcp/OWNERS
tests/e2e/tests/galley/OWNERS
tests/e2e/tests/pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
1a8cdda332477429762b63dbb7312547528d8a52
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
1a8cdda332477429762b63dbb7312547528d8a52
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
1a8cdda332477429762b63dbb7312547528d8a52
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: ayj, kyessenov
If they are not already assigned, you can assign the PR to them by writing /assign @ayj @kyessenov in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS
mixer/OWNERS
pilot/OWNERS
pkg/mcp/OWNERS
tests/e2e/tests/galley/OWNERS
tests/e2e/tests/pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
1a8cdda332477429762b63dbb7312547528d8a52
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
1a8cdda332477429762b63dbb7312547528d8a52
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
1a8cdda332477429762b63dbb7312547528d8a52
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-presubmit

prow/istio-integ-local-tests.sh
adbe8333dbd694595b88d856ce6093c204b8bf42
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-unit-tests

prow/istio-presubmit.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-presubmit

prow/istio-integ-local-tests.sh
adbe8333dbd694595b88d856ce6093c204b8bf42
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
adbe8333dbd694595b88d856ce6093c204b8bf42
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ayj
If they are not already assigned, you can assign the PR to them by writing /assign @ayj in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/mcp/OWNERS
tests/e2e/tests/galley/OWNERS
tests/e2e/tests/pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-unit-tests

prow/istio-presubmit.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-presubmit

prow/istio-integ-k8s-tests.sh
adbe8333dbd694595b88d856ce6093c204b8bf42
link
/test istio-integ-k8s-tests

prow/istio-integ-local-tests.sh
2ca1813d97e5da70d65aa51776076f703e9bebe1
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-unit-tests

prow/istio-presubmit.sh
257f48161f03d10dae00d47c1505a3136f2403d8
link
/test istio-presubmit

prow/istio-integ-local-tests.sh
2ca1813d97e5da70d65aa51776076f703e9bebe1
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
2ca1813d97e5da70d65aa51776076f703e9bebe1
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
2ca1813d97e5da70d65aa51776076f703e9bebe1
link
/test istio-integ-k8s-tests

prow/istio-integ-local-tests.sh
9c5523ff4f80ebd688ba5a9c6cbcb344ba91853d
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
9c5523ff4f80ebd688ba5a9c6cbcb344ba91853d
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
9c5523ff4f80ebd688ba5a9c6cbcb344ba91853d
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
9c5523ff4f80ebd688ba5a9c6cbcb344ba91853d
link
/test istio-integ-k8s-tests

prow/istio-integ-local-tests.sh
43a8c7e5049e389bbfc1d1498462a18595c13ad1
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
43a8c7e5049e389bbfc1d1498462a18595c13ad1
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
43a8c7e5049e389bbfc1d1498462a18595c13ad1
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
43a8c7e5049e389bbfc1d1498462a18595c13ad1
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
43a8c7e5049e389bbfc1d1498462a18595c13ad1
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
43a8c7e5049e389bbfc1d1498462a18595c13ad1
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests
(flaky fs test)

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ozevren
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ayj
If they are not already assigned, you can assign the PR to them by writing /assign @ayj in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/mcp/OWNERS [ozevren]
tests/e2e/tests/galley/OWNERS [ozevren]
tests/e2e/tests/pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nmittler, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/mcp/OWNERS [nmittler,ozevren]
tests/e2e/tests/galley/OWNERS [nmittler,ozevren]
tests/e2e/tests/pilot/OWNERS [nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
43a8c7e5049e389bbfc1d1498462a18595c13ad1
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
43a8c7e5049e389bbfc1d1498462a18595c13ad1
link
/test istio-integ-k8s-tests

prow/e2e-dashboard.sh
43a8c7e5049e389bbfc1d1498462a18595c13ad1
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

failed to get a Boskos resource

/test e2e-dashboard


The link to developer-notes.md is broken when clicked from the hosted docs (https://solid.github.io/community-server/docs/)

Environment

Server version: 2.0.1
Node.js version: v16.13.1
npm version: 8.1.2

Description
While reading the developing server code section in the api docs, I clicked the link on "📓 developer notes" but that took me to:
https://solid.github.io/community-server/docs/guides/developer-notes.md which returns a 404.
Am I correct in assuming the file is actually at https://github.com/solid/community-server/blob/main/guides/developer-notes.md? If so I can open up a PR for this, but wanted to follow process and create an issue first.

Fixed in #1099, thanks!