Pass secret handler when instantialize Credential controller

Please provide a description of this PR:
This is to prevent adding handler after secret informer has been started.
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-distroless_istio

integ-ipv6_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-ipv6_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-distroless_istio

integ-ipv6_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-distroless_istio

integ-ipv6_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot-istiodremote_istio

integ-pilot_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-distroless_istio

integ-ipv6_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot-istiodremote_istio

integ-pilot_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot_istio

integ-cni_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-distroless_istio

integ-ipv6_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot-istiodremote_istio

integ-pilot_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot_istio

integ-cni_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-cni_istio

integ-security-istiodremote_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-security-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-distroless_istio

integ-ipv6_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot-istiodremote_istio

integ-pilot_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot_istio

integ-cni_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-cni_istio

integ-security-istiodremote_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-security-istiodremote_istio

integ-pilot-istiodremote-mc_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot-istiodremote-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-distroless_istio

integ-ipv6_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot-istiodremote_istio

integ-pilot_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot_istio

integ-cni_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-cni_istio

integ-security-istiodremote_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-security-istiodremote_istio

integ-pilot-istiodremote-mc_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot-multicluster_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-distroless_istio

integ-ipv6_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-ipv6_istio

integ-pilot-istiodremote_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot-istiodremote_istio

integ-pilot_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot_istio

integ-cni_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-cni_istio

integ-security-istiodremote_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-security-istiodremote_istio

integ-pilot-istiodremote-mc_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot-multicluster_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-pilot-multicluster_istio

integ-security-multicluster_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
44be9d0392445ae4567de829155505e81d3d15be
link
true
/test integ-security-multicluster_istio

integ-pilot-multicluster_istio
fbe9aac489d96105d65edcfa0087cac4ae85972d
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster_istio

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
5224f823fc33187641b023aaf972de0a5fa32edb
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
5224f823fc33187641b023aaf972de0a5fa32edb
link
true
/test gencheck_istio

lint_istio
5224f823fc33187641b023aaf972de0a5fa32edb
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
35bab1040759c2cca86a42d8cc5b9c53c5ef2ea4
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Give better error message on resource not found

When an embedded resource is not found the program emits a message that tells the user what is happening but fails to tell the user what file name was not found. This information is required for troubleshooting and should be included.

Fixed. This annoyed me more than I thought it would.


cargo clippy (pedantic) lints

Running cargo clippy --release -- -W clippy::pedantic and fix some of them.

Sorry for the delay, I hadn't check this repo :/
Merged, thanks


Add new hero modal art, descriptive text, and difficulty indication.

Changes Unknown when pulling 49cd00583cb8e918cc0f925223a9a6ab74465b16 on hero-modal-images into ** on master**.

Looks good to me 👍


Add descriptions for all links that are missing them

hii

Hey please assign this to me.

Hi I am beginner and I want to fix this please assign me and explain me

If this issue is not assigned to anyone, can I work on this issue??

hey can I work in this issue please assign it to me

@AyushAgarwal15 this repo is dead mostly you can try to check things on @Shakil-Shahadat 's fork of this repo.

hey i am beginner can i work on this??

Hello can i work on this ?


Data ingestion from various RDBMS?

Hi GE folks, do we have plan to load data from sqlsvr, mysql, postgres?

We'll keep adding tools and sample code for data loading. Tools and sample code for handling tsv/csv and json data will be among the first.

I need some tools for cortana


Transition to transform:translate(123em) is not working right

I'm trying to perform a transition to a transform:translate style with values specified as em.
This jsfiddle is reproducing the problem : https://jsfiddle.net/59ushyut/
Note the body font-size:2px so that 1em should be considered as 2px in the document.
When I start at transform: translate(100em) :

doing element.style("transform", "translate(200em)") is ok.
but doing element.transition().duration(1000).style("transform", "translate(200em)"); is sending my element way too far. The final style becomes transform: translate(3200px, 0px);, as if d3 was considering that 1em = 16px.

D3 version is 4.10.0
Issue reproduced on last versions of Chrome and Firefox.

The problem is that transition.style on the transform style uses d3.interpolateTransformCss, which computes the normalized form of the transform style property using an off-screen DIV element; see parse.js. Thus the interpolator ignores the inherited style from the body, and transitions from matrix(1, 0, 0, 1, 1600, 0) to matrix(1, 0, 0, 1, 3200, 0).
(Prior to d3-transition<EMAIL_ADDRESS>the computed style property value on the transitioning element was used as the starting value for the transition, so the starting value was correct: matrix(1, 0, 0, 1, 200, 0). However, the ending value would still be interpreted incorrectly as matrix(1, 0, 0, 1, 3200, 0).)
You can workaround this issue by not depending on inherited styles, by using px units, or by using transition.attr (which only allows pixel units). You could also compute the normalized values yourself on each transitioning element, and pass them to d3.interpolateTransformCss using transition.styleTween.
Fixing this is possible, but it doesn’t look easy, since it requires computing the normalized transform on the transitioning element for both the starting and ending value. And there’s no easy way to pass along the transitioning element to d3.interpolateTransformCss (without either further special-casing of transitions on the transform style, or always passing the transitioning element as the third argument to the interpolator factory, which seems like overkill and could also cause surprising behavior if interpolator factories are not expecting that additional argument).
This might require a completely different code path in transition.style for the transform attribute, so that the computed value is always used as the starting and ending value, rather than the normal behavior where the inline value takes priority.
Alternatively, we could use the computed value for both the starting and ending values, as discussed in https://github.com/d3/d3-transition/issues/47#issuecomment-232654843. However, this behavior was recently changed in 1.1.0 as mentioned above, and I think in general using the inline values (as specified by the caller) leads to more predictable behavior; transforms are special because they are normalized rather than interpolated as-specified using d3.interpolateString. So I think it’d be better to change the special case in transition.style as described in the previous paragraph.


UI improvement: history dropdown interference

Description of the new feature / enhancement
Pretty much every time I use PowerToys Rename, I find myself annoyed by the history dropdown getting in the way, especially for the search box. Part of this is because it doesn't shrink as the matching history items do (in fact, it doesn't even filter at all, so it's borderline useless), so it stays the full size no matter how many matches there are, even if there aren't any. Then, in order to access the other options, since it covers all but the text formatting buttons, I have to either tab or click out of it. While this isn't exactly a big deal, it's a minor annoyance that adds up every time I use it, and it just makes it feel clunky and cumbersome to use.
I would suggest a couple improvements to deal with this. First, fix the history so it actually filters to show matching items only, and adjust the size of the dropdown accordingly. Second, either space things out better so the dropdown doesn't cover the stuff under it, at least by the time it's hopefully narrowed down so it's only showing one or two items, or, probably even better, shift the items under it down so they're always visible below it, and shift them up as it shrinks, so they're always visible.
Scenario when this would be used?
Always.
Supporting information
No response

Just found another issue caused by this. Since the dropdown box doesn't filter and shrink to show only matching history items, when I just clicked outside of the box to close the dropdown, I accidentally clicked in the dropdown, replacing my replacement string (which took much longer than it should have to create, longer than it would have taken to just rename the files manually, due to it not working as expected based on extensive regex experience in other programs). And, of course, ctrl+z doesn't work to undo (another fairly serious issue), so I couldn't get it back.


Restoring the resource context while rendering a block

Coverage increased (+0.005%) to 99.243% when pulling d2464624fbade2783443df96a33e6b20ab8f5142 on lyncodev:master into 145f5f2dc3113a70826e8bcd413aadecf2176c2a on jtwig:master.


Add files via upload

Added exploratory notebook.
Description
Number of Files changed
1 file added
Questions for Reviewer
NA
Type of Change

[ x ] New Feature
[ ] Feature Update
[ ] Fix Error

Status

[ x ] Tested

Description
Moved the notebook to the notebooks folder
Number of Files changed
1
Questions for Reviewer
Type of Change

[ ] New Feature
[ ] Feature Update
[ x ] Fix Error

Status

[ N/A ] Tested


feature: use .css

added a line in the manifest to source the .css file
commented out style injected by script

thought it was a little odd that the packages includes a css file, yet doesnt use it


Failed to build GodotSharp solution

Godot version:
3.1 beta 5 Mono x64
3.1 beta 6 Mono x64
3.1 beta 7 Mono x64
3.1 beta 8 Mono x64
OS/device including version:
Windows 10 / Acer Aspire E15
Issue description:
C# build fails
Steps to reproduce:

Clone the following project
https://github.com/StStep/ink-godot-example
Open it in Godot
Observe build error:

Проект "GodotSharp.sln" (целевые объекты Build):
Message: Создание конфигурации решения "Release|Any CPU".
Проект "GodotSharp.csproj" (целевые объекты по умолчанию):
C:\Program Files\Mono\lib\mono\msbuild\15.0\bin\Microsoft.Common.CurrentVersion.targets(2126,5): error MSB4018: непредвиденная ошибка при выполнении задачи ResolveAssemblyReference".
System.NullReferenceException: Object reference not set to an instance of an object

The linked project was made for Godot 3.0 alpha 2, it's not unexpected that it would no longer be compatible with 3.1 beta 6.
I would advise to open an issue on https://github.com/StStep/ink-godot-example asking to update the project for compatibility with Godot 3.1.
I'll let @neikeq review if something should be done on Godot's end, but IMO this needs to be debugged in https://github.com/StStep/ink-godot-example first.

test1.zip
OK, here is new test project, just created in this new 3.1 beta 6
One spatial node & default cs script

test1.zip project above works nicely in 3.1 beta 4

...but failed to build with the same error in 3.1 beta 5

The attached project builds fine for me with 3.1 beta 6 on Linux, with MSbuild <IP_ADDRESS> from Mono.

C:\Program Files\Mono\bin>msbuild.bat
Microsoft (R) Build Engine версии <IP_ADDRESS>163 (xplat-master/d375bb6e Sat Jun 30 05:26:28 EDT 2018) для Mono
My Mono MSbuild version, hope that helps

There is also message in the log output:
ERROR: initialize: The loaded Core API assembly is out of sync
At: modules/mono/mono_gd/gd_mono.cpp:356
Mono: Proceeding to unload scripts domain because of invalid API assemblies.

The same error is in the recent build 3.1 beta 7

The same error is in the recent build 3.1 beta 8
Error in log:
ERROR: call_build: A Godot Engine build callback failed.
At: editor/editor_node.cpp:4532
This time the project was opened successfully, but failed at the build stage when I tried to run the game,

Tested on Linux with 3.1 beta 8, still works fine for me. I guess it's specific to Windows or your configuration.

Can you try changing Editor Settings > Mono > Builds > Build Tool to MSBuild (VS Build Tools) and see if it builds correctly? It requires Visual Studio or Visual Studio Build Tools to be installed.
We've experienced several issues with Mono's msbuild.bat on Windows so it's not recommended for now.

When I changed it the first time, it was an error MSB3644 for ".NETFramework,Version=v4.5", then I edited the csproj file and manually changed
v4.5
to
v4.5.2
After that, the project was built and ran successfully!
By the way, maybe there is some option for selection of target framework version from within the Godot? :)

Hmm, I had a similar issue yesterday. I had to delete the .mono/temp folder. Not sure if running the "clean solution" command would work as well.

Just tried on the latest beta 9, running with Mono still causing the same errors.
BUT changing to the MS Build tools indeed helps, with the only downside that I need to change target framework from v4.5 to v4.5.2 manually. Maybe it is really viable workaround for Windows system, then...

Have you tried my last suggestion instead of switching the TargetFramework to v4.5.2?

Yes, I tried to delete .mono/temp folder, but this does not help, unfortunately
Visual Studio's msbuild complains about missing NETFramework,Version=v4.5, Mono's msbuild complains about System.NullReferenceException: Object reference not set to an instance of an object

Yeah, I guess I'm a victim of this now as well.
The first commits of v3.2 worked fine but now I'm getting this all the time.

That's the Visual Studio output because it looks cleaner.
It the same that gets written to mono's logs anyway.

@piratesephiroth That's a different issue which was fixed by #27729

oh thanks, I'll try again

@Antokolos Can you still reproduce this issue in the latest Godot 3.2 builds?

Yes, without changing the target framework from v4.5 to v4.5.2 manually in the csproj file the project does not compile. Deletion of .mono/temp folder does not help either.

@Antokolos have you tried installing that version of the .NET Framework? MSBuild on Windows does not use Mono's framework when resolving assemblies (not even the MSBuild version Mono ships). So you need to install the .NET Framework.


[Bug]: jaeger-operator-webhook-service selector does not match any pod / may be a leftover to remove

What happened?
Currently, in clusters where I did deploy jaeger-operator, I would find the following Service:
apiVersion: v1
kind: Service
metadata:
  creationTimestamp: "2022-03-24T15:13:09Z"
  labels:
    app.kubernetes.io/name: jaeger-operator
    name: jaeger-operator
    operators.coreos.com/jaeger-product.openshift-operators: ""
  name: jaeger-operator-webhook-service
  namespace: openshift-operators
  ownerReferences:
  - apiVersion: operators.coreos.com/v1alpha1
    blockOwnerDeletion: false
    controller: false
    kind: ClusterServiceVersion
    name: jaeger-operator.v1.36.0-2
    uid: 29ed0838-3af8-4a31-9111-4f35e4dcfd70
  resourceVersion: "5113346526"
  uid: bc98efee-9c16-44d1-9d22-a053579d14d1
spec:
  clusterIP: <IP_ADDRESS>
  clusterIPs:
  - <IP_ADDRESS>
  internalTrafficPolicy: Cluster
  ipFamilies:
  - IPv4
  ipFamilyPolicy: SingleStack
  ports:
  - port: 443
    protocol: TCP
    targetPort: 9443
  selector:
    app.kubernetes.io/name: jaeger-operator
    name: jaeger-operator
  sessionAffinity: None
  type: ClusterIP
status:
  loadBalancer: {}

The selectors for that Service do not target any Pod.
The mutating/validating webhooks deployed by the operator would instead query a jaeger-operator-service Service, which does work.
I suspect that jaeger-operator-webhook-service is a leftover from some previous of jaeger operator. Yet the ownerReference does suggest it is owned by the current version of jaeger operator.
I see this webhook-service is mentioned here:
https://github.com/jaegertracing/jaeger-operator/blob/8695866b4c71af5967f2b567c3280757af647561/config/crd/patches/webhook_in_jaegers.yaml
Although I don't find that conversion in my clusters - while the CRD is here.
I also found this: https://github.com/jaegertracing/jaeger-operator/blob/d7440c17f55bf68ff47a4d43e1e389bd10007838/bundle/manifests/jaeger-operator-webhook-service_v1_service.yaml
Which suggests to me we somehow still want that service being here, but the selector should no longer mention app.kubernetes.io/name label?
What should it be?
Should that service be removed from operator?
Or should OLM (or jaeger-operator?) make sure to replace existing objects, rather than merge over a new selectors on top of a previous one, resulting in broken services as I have here?
Steps to reproduce
deploying "a previous" version of jaeger (I see creationTimstamps around 2022-03-24)
upgrade to 1.36.0-2
Expected behavior
jaeger-operator-webhook-service should either point to jaeger-operator pod (removing app.kubernetes.io/name label from selector), or we should get rid of it and use the jaeger-operator-service everywhere (that one seems to be re-created during operator upgrades already, somehow. points to that operator pod, same port, ... why would we need another Service?)
installing/upgrading operators, I shouldn't be left with endpoints with no targets
Relevant log output
No response
Screenshot
No response
Additional context
No response
Jaeger backend version
No response
SDK
No response
Pipeline
No response
Stogage backend
No response
Operating system
No response
Deployment model
No response
Deployment configs
No response

anyone maintaining that project?

hi @faust64 i will have a more detailed look soon. let me come back to you during the week.

Thanks!


Feature/dimension properties final

Fixes #18, Sucessor of #34
Allows dimension properties per axis. Sample:
from TM1py import TM1Service

from mdxpy import MdxBuilder, MdxHierarchySet, Member, DimensionProperty

with TM1Service(address='localhost', port=12354, ssl=True, user="admin", password="apple") as tm1:
    query = MdxBuilder.from_cube("c1")
    query.add_hierarchy_set_to_row_axis(MdxHierarchySet.all_leaves("d1", "d1"))
    query.add_properties_to_row_axis(DimensionProperty("d1", "d1", "Description"))
    query.rows_non_empty()
    query.add_hierarchy_set_to_column_axis(MdxHierarchySet.member(Member.of("d2", "e1")))
    query.columns_non_empty()

    print(query.to_mdx())

    df = tm1.cells.execute_mdx_dataframe(mdx=query.to_mdx(), include_attributes=True)
    print(df.head(4).to_markdown())

Output

SELECT
NON EMPTY {[d2].[d2].[e1]} DIMENSION PROPERTIES MEMBER_NAME ON 0,
NON EMPTY {TM1FILTERBYLEVEL({TM1SUBSETALL([d1].[d1])},0)} DIMENSION PROPERTIES [d1].[d1].[description] ON 1
FROM [c1]

d1
Description
d2
Value

0
e1
a1
e1
1

1
e2
a2
e1
2

2
e3
a3
e1
3

3
e4
a4
e1
10

@vishn90
I created this PR based on your commits and added one additional commit on top. Please review and approve my changes.

Thanks for reviewing.
Yeah. It's a big step forward for mdxpy!!


Re-done work reflecting on engineering rather than UX?

Under "User-Centered Approach" for Low Maturity, a bullet reads, "After work is complete, it must be re-done because..."
This feels less like user-centered and more about iterative development and deployment

@skcain revisiting this comment too, I wonder if there is a way to emphasize the comments above in the matrix?


Implementation PDP

Implement PDP based on https://github.com/sphereio/sphere-sunrise-design/issues/2

@trangng can you please list what are the MVP for this page?
For example, do we have to implement wishlist, reviews, etc.?

And how is the algorithm for the "You may also like" section?

And when is a product available? When stock units > 0?

What means "Sunrise #SUN123456" in http://sphereio.github.io/sphere-sunrise-design/pdp.html# ? The second one is probably the SKU but what is the first one?

What should happen if I click "VIEW DETAILS" in http://sphereio.github.io/sphere-sunrise-design/pdp.html# ?

Idea: It scrolls to "PRODUCT DETAILS" and opens the accordion?

https://github.com/sphereio/sphere-sunrise-design/blob/master/input/templates/pdp.json#L965
what is the exact meaning of priceOld?

If you have a product discount. You want to get the attention of the customer by showing 99.99 strikethrough and 79.99 as new price next to it.

still internal doc: https://sphere.atlassian.net/wiki/pages/viewpage.action?pageId=19333572

@lauraluiz @peter-gerhard MVP for PDP is everything except:

wishlist
review

@trangng What is with inventory?

I think it would be better to have a whitelist what in this development step needs to be done.

algorithm for the "You may also like" section?:
4 products should be shown from

same gender
different categories

And when is a product available? Yes, when stock units > 0

What means "Sunrise #SUN123456" in http://sphereio.github.io/sphere-sunrise-design/pdp.html# ?
This is the article number. So right text would be e.g.: "Article number CYBORG Z01"

What should happen if I click "VIEW DETAILS" in http://sphereio.github.io/sphere-sunrise-design/pdp.html# ?
If customer clicks on "VIEW DETAILS" the full product description will be shown. Other wise only the first 2 lines.

Idea: It scrolls to "PRODUCT DETAILS" and opens the accordion?
No, under "PRODUCT DETAILS" we show the product attributes e.g.:
Material: 60% viscose, 35% polyamide, 5% elastane
One button on front
Two patch pockets on front
Front longer than back
The model wears a size 38: Dry clean only

@schleichardt what do you exactly mean by inventory? the inventory import?

No, there is a green check mark and right next to it "Available", can we just hardcode it to always be on stock for now?
Adding stock to logic makes not much more to see for demos right now but would kill much time.

There is no UI element for "VIEW DETAILS" to display further information.

@schleichardt I will add that, I wasn't sure myself what is the purpose of having so much text space and 2 accordions for displaying one product's information...

No, there is a green check mark and right next to it "Available", can we just hardcode it to always be on stock for now?
@schleichardt ok you can hardcode it for now

is there a specification of how the prices should be formatted?

@trangng can you provide a product with multiple variants that differ in size and color, please?
currently there are a lot of products where the color is not represented in variants but in the product title,
like
see: https://admin.sphere.io/sunrise-staging/products/cfedbda7-55cf-4c1e-9e35-1378a0418c64
for the color and size chooser i need the products to use the model like intended.

"Quantity: you can insert a quantity up to 100 pieces. If there is an insufficient stock, you will get an error message" from https://sphere.atlassian.net/wiki/pages/viewpage.action?pageId=19333572
if its possible to select up to 100 pieces the selection box gets  quite huge, because it tries fit as much choices on the screen as possible, just a minor design issue. for now i will limit the number to 10.

@schleichardt Why adding stock logic to PDP would kill much time? Isn't just fetching inventories for given sku?

Sunrise is a demo shop, it is not visible by the outside world how much is in the imaginary stock.

Your last statement sounds like a cryptic oracle forecast :) Could you elaborate why demo shop should not show availability infos and it would kill much time?

It is a demo shop, there is no real stock.

How are you going to show PDP if you have no real product and no real stock?

Just show the product data and hardcode that is available.

How are you going to add to cart if its not on stock?

The default cart does not check inventory:

http://dev.sphere.io/http-api-projects-carts.html#inventory-mode
http://dev.sphere.io/http-api-projects-carts.html#inventory-mode

I think its wrong as we should use ReserveOnOrder by default and should always check if item is on stock before we allow the customer to add to it to a cart. As customer you do not want to make whole checkout process and pay for something which is not stock or even not available anymore. @trangng please check that and specify how we should proceed here.

"Size guide: if you click on the sizeguide a overlay with the measurements will be shown"
@trangng  how is this provided?

@trangng "Product Details" and "Delivery and Returns" are currently simple String types in pdp.json
it would be nicer to show details and shipping methods as lists.

@peter-gerhard size guide was done by @JulianSamarjiev I'm not sure if he only have it local or it's not done yet. I'll ask him as soon as he's back from holiday

@peter-gerhard I'll talk to @JulianSamarjiev about the tabs "Product Details" and "Delivery and Returns"

@peter-gerhard In The future, can you include the issue number in the commit message, please?
This way they will be shown here.
Example:
Use Add sku prefix to ProductData. #87
instead of Add sku prefix.

@trangng @peter-gerhard When you want to quote something, then prefix it with >  so it is easier to understand:
code:
> Idea: It scrolls to "PRODUCT DETAILS" and opens the accordion?

No, under "PRODUCT DETAILS" we show the product attributes e.g.:
Material: 60% viscose, 35% polyamide, 5% elastane

result:

Idea: It scrolls to "PRODUCT DETAILS" and opens the accordion?

No, under "PRODUCT DETAILS" we show the product attributes e.g.:
Material: 60% viscose, 35% polyamide, 5% elastane

Create a new ticket for new questions with the pdp label, please.


Add some PineTime logos for anyone to use

@lupyuen, let me know if there's any issues with these.
Any resemblance to real logos or other real-life entities is purely coincidental. All symbols and other entities appearing in these works are fictitious. Any resemblance to real logos, dead or alive, or other real-life entities, past or present, is purely coincidental.

Thanks! :-)


needed a few more requirements

this is what I needed to get the install working in a fresh conda env on my mac
also, wasn't sure if you had the < > in the README links on purpose - didn't fix (<https://github.com/>czbiohub/khtools.git )

just saw you have these on your other PR's - I'll close and go try out those branches!


Example of Cash Drawer (Purchasable)

I was interested in creating a sample POS application using Raspberry Pi and the Cash Drawer / PosPrinter sample. I was wondering if a link could be provided of an example Cash Drawer that was used during development.

I don't understand the question. The CashDrawer sample is here but you probably knew that.

I am looking to purchase a physical cash drawer to use with this sample. What do I need?

This page documents the devices which are supported.


fix: svg asset

Impacted file:

product_not_found.svg: cleaned the metadata in order to avoid warnings

Systematic warnings:
flutter: unhandled element defs; Picture key: AssetBundlePictureKey(bundle: PlatformAssetBundle#07613(), name: "assets/product/product_not_found.svg", colorFilter: null, theme: SvgTheme(currentColor: Color(0xff000000), fontSize: 14.0, xHeight: 7.0))
flutter: unhandled element metadata; Picture key: AssetBundlePictureKey(bundle: PlatformAssetBundle#07613(), name: "assets/product/product_not_found.svg", colorFilter: null, theme: SvgTheme(currentColor: Color(0xff000000), fontSize: 14.0, xHeight: 7.0))
What

Cleaned an asset svg file's metadata in order to avoid systematic warnings

Codecov Report

Merging #2710 (e8105cd) into develop (2ea0da3) will decrease coverage by 1.65%.
The diff coverage is n/a.

:exclamation: Current head e8105cd differs from pull request most recent head 1e496b3. Consider uploading reports for the commit 1e496b3 to get more accurate results

@@            Coverage Diff             @@
##           develop   #2710      +/-   ##
==========================================
- Coverage     8.86%   7.20%   -1.66%
==========================================
  Files          161     219      +58
  Lines         6623   10587    +3964
==========================================
+ Hits           587     763     +176
- Misses        6036    9824    +3788

Impacted Files
Coverage Δ

...kages/smooth_app/lib/widgets/attribute_button.dart
0.00% <0.00%> (-92.00%)
:arrow_down:

...s/smooth_app/lib/data_models/user_preferences.dart
8.73% <0.00%> (-23.57%)
:arrow_down:

packages/smooth_app/lib/themes/smooth_theme.dart
60.00% <0.00%> (-22.98%)
:arrow_down:

...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart
15.11% <0.00%> (-19.10%)
:arrow_down:

...mooth_app/lib/data_models/product_preferences.dart
21.68% <0.00%> (-9.75%)
:arrow_down:

packages/smooth_app/lib/main.dart
14.65% <0.00%> (-3.24%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/welcome_page.dart
0.00% <0.00%> (-3.13%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/scan_example.dart
0.00% <0.00%> (-2.28%)
:arrow_down:

...p/lib/pages/onboarding/consent_analytics_page.dart
0.00% <0.00%> (-1.57%)
:arrow_down:

...ackages/smooth_app/lib/pages/scan/scan_header.dart
3.33% <0.00%> (-1.43%)
:arrow_down:

... and 236 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

For some reason we're stuck here, cannot merge...

@monsieurtanuki I've told @teolemon about this on Slack. It's because of the name change in the Workflow. A user with settings access has to change the "required" workflow list.

Fixed


Camera Error

Browsers and versions affected
Steps to reproduce
Expected results
Actual results

Crome v  848.0

Crome v  848.0


Add GZipEncoderDecoder es-ES translation

Spanish translation of GZip Encoder tool
Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[x] Internationalization and localization
[ ] Other (please describe):

Quality check
Before creating this PR, have you:

[x] Followed the code style guideline as described in CONTRIBUTING.md
[x] Verified that the change work in Release build configuration
[x] Checked all unit tests pass

Thanks :)


Adds hash to curve circuits

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Testing
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

The tests will pass once the corresponding changes are merged and released in the garaga repo


cargo objcopy with no arguments outputs incorrect (?) help message

Calling cargo-objcopy appears to output llvm-objcopy help message instead of the cargo-objcopy help message, afaik this should should require cargo objcopy -- -help?

Or perhaps it should just do the right thing (tm) when no arguments are provided? For example, default behaviour of building the binary/binaries listed in Cargo.toml in --release mode and outputting .bin files?

Right now, invoking cargo-$tool is the same as invoking path/to/llvm-$tool. I think it's fine to change the semantics (to e.g. print the cargo-$tool help) since it's very likely that no one is using cargo-$tool (without passing any arguments).

Should work just fine now and improve even more with #61. Closing thus.


[Review][CARBONDATA-1386] fixed findbugs errors in carbondata-core

retest this please

SDV Build Success with Spark 2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/220/

retest this please

retest this please

SDV Build Success with Spark 2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/227/

SDV Build Success with Spark 2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/232/

LGTM


Update to mention Azure Firewall

@MikeWasson : Thanks for your contribution! The author(s) have been notified to review your proposed change. @telmosampaio

Sorry wrong repo :-)


IDL .pro files identified as prolog files

2 of my 3 IDL Projects are identified as Prolog.
I found this closed older issue of the opposite problem (Prolog identified as IDL).
So the issue is not yet fixed from all points of view. Can I do anything to force it to be identified as IDL?

Whoops, a little late here.  Looks like a bit of work is needed to improve the classification here.  We'd welcome a PR to improve the classification.
If you're looking for a quick fix: an override to specify the correct language will do the trick.

#3931 fixes a slight defect of our Prolog heuristic identified while going through your IDL projects. It won't change the detection results for any of them unfortunately. The issue here is that we're often relying on the last-resort Bayesian classifier to classify .pro files. Two ways to improve this:

Improve the IDL .pro heuristic to identify more IDL files. Our current heuristic is very basic and we could use your help to improve it.
Improve the last-resort Bayesian by adding more sample IDL files. I've noticed that your repositories are under GPL license so those files can't be used for Linguist (requires a permissive license), but maybe you know some other source for samples, or could relicense a few of your files under a permissive license?

Flagging as stale.


Fix corrosive acid taking to long to apply on items.

About the PR

Title.
Why / Balance

Parity
Technical details

Changed the delay to be attached to the corrodible comp. Base Item now gets 1 second, default is 4. Anything that's off can be adjusted easily in YML.
Media

https://github.com/user-attachments/assets/fed44b84-b968-4310-9941-ceeba74b89dd
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:

fix: Fixed corrosive acid taking to long to apply. It's now 1 second for items and 4 for structures.

too*


Purse resets when opening recipe book

Minecraft: 1.19.2
Fabric loader: 0.14.14
Fabric API: 0.73.2
OwO Lib: 0.9.3
Numismatic Overhaul: 0.2.8
https://user-images.githubusercontent.com/108554062/217428862-7d67484e-2365-42c9-9178-1978e940fee3.mp4
When using a custom position for the purse widget, it reverts back to its original position when opening the recipe book (and stays there until the inventory is completely closed and reopened.) Tested in a fresh instance with only the mods listed above.

Thanks for reporting this problem, it has now been fixed in 0.2.9


Fix pod.yml definition which fails on kubernetes 1.16.2

Seen on microk8s:
$ kubectl apply -f pod.yml
Error from server (BadRequest): error when creating "pod.yml": Pod in version "v1" cannot be handled as a Pod: v1.Pod.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.Env: []v1.EnvVar: v1.EnvVar.Value: ReadString: expects " or n, but found f, error found in #10 byte of ...|,"value":false}],"im|..., bigger context ...|iners":[{"env":[{"name":"WEBMIN_ENABLED","value":false}],"image":"sameersbn/bind","name":"bind","por|...
$

Quoting false to "false" seems to work.

not sure why this is marked as won't fix, just because it's stale? I can't push the change so marking it as stale is hardly my fault.


Fix undefined vsc configs variable

http://<IP_ADDRESS>:8080/job/Scheduled-Tests/job/INSTALL-GCP-6.0.3-NO-VSC-FALLOCATE/13/


Feat: Rescue Tokens from Deprecated Debt Swap Adapters

Rescue tokens from Paraswap debt swap adapters which have been deprecated due to the exploit from August 28, 2024. Only rescue tokens from the networks where the accumulated token value stuck in the contracts is >=$10.
Transfer rescued tokens to treasury.
Summary (all values approximate):
V2Ethereum - DEBT_SWAP_ADAPTER (0x6A6FA664D4Fa49a6a780a1D6143f079f8dd7C33d)
Owner: 0x5300A1a15135EA4dc7aD5a167152C01EFc9b192A
Tokens to rescue:

sUSD: $52
USDC: $10

V3Ethereum - DEBT_SWAP_ADAPTER (0x8761e0370f94f68Db8EaA731f4fC581f6AD0Bd68)
Owner: 0x5300A1a15135EA4dc7aD5a167152C01EFc9b192A
Tokens to rescue:

USDT: $78
crvUSD: $33

V3Ethereum - REPAY_WITH_COLLATERAL_ADAPTER (0x02e7B8511831B1b02d9018215a0f8f500Ea5c6B3)
Owner: 0x5300A1a15135EA4dc7aD5a167152C01EFc9b192A
Tokens to rescue:

GHO: $3,120
rETH: $31
WBTC: $23

Tokens to Rescue via GovernanceV2 Executor (NOT included in this proposal)
Ethereum - REPAY_WITH_COLLATERAL_ADAPTER (0x1809f186D680f239420B56948C58F8DbbCdf1E18)
Owner: 0xEE56e2B3D491590B5b31738cC34d5232F378a8D5
Tokens to Rescue:

LUSD: $12

Polygon - REPAY_WITH_COLLATERAL_ADAPTER (0x10D2fA27166d94894d850a9a851EE06870F14b09)
Owner: 0xdc9A35B16DB4e126cFeDC41322b3a36454B1F772
Tokens to Rescue:

agEUR: $75
CRV: $47
miMATIC: $14

Arbitrum - REPAY_WITH_COLLATERAL_ADAPTER (0xB0526BFb4047aE1147DC7caAF3F1653904C2D568)
Owner: 0x7d9103572bE58FfE99dc390E8246f02dcAe6f611
Tokens to Rescue:

MAI: $31

missing rescue for other adapters and networks

Implementation looks good to me. Thanks for the code and analysis @yan-man

closing as i think was incorporated into another proposal


Add parser error for empty TagHelper bound attributes.

Errors are only created for TagHelper bound attributes that are not bound to string.
Added tests to validate proper errors for expected input.

#289

/cc @dougbu

Updated.

:watch:

Updated.

:shipit:


Fix the "Out of memory" EVP KDF scrypt test

This test did not really execute, since usually
the OPENSSL_malloc(0) will fail and prevent the
execution of the KDF.

Checklist

[ ] documentation is added or updated
[x] tests are added or updated

backport of #16444

This pull request is ready to merge

Merged to 1.1.1 as dc3520b.  Thanks!

https://en.wikipedia.org/wiki/Scrypt
I think this test should have verified that openssl implementation of scrypt uses a lot of memory, as it should.
Depending on ulimit, I get either KDF_DERIVE_ERROR or KDF_MISMATCH.
For example, 32-bit AIX processes have a historical limitation to 128 MB, and there are two other platforms/build machines where 1.1.1m tests fail.
If I disable the limitation with an AIX environment variable, the new test passes, but it think makes no sense now after your patch. It just calculates a KDF then tests its output against nothing.
How to simulate a low memory environment:

setrlimit(RLIMIT_AS  and also RLIMIT_DATA) on Unix
CreateJobObject/AssignProcessToJobObject/SetInformationJobObject(JobObjectExtendedLimitInformation) on Windows
other methods on other platforms
or skip the test if you cannot limit the memory.

I see what you mean, but this is still 1MB below the default memory allocation limit of scrypt which is defined here:
https://github.com/openssl/openssl/blob/e9dc49c009a34b429d6dddcbb1813efa561481c7/crypto/kdf/scrypt.c#L66-L73
so when you enable scrypt for your target at all, you should make sure your target is able to allocate up to maxmem_bytes.

We also don't verify that KDF's consume lots of CPU time.
I think we should verify that they work correctly, not that they necessarily consume lots of resources.
If somebody submits a version of scrypt that doesn't consume lots of memory, we'd accept it.

The other scrypt tests pass because they use smaller values for N (CostFactor).
This last test bears the comment "Out of memory" and has no reference output, so maybe it was supposed to check if memory allocation failures are handled correctly by the implementation of this memory-hungry algorithm?
(if there were an scrypt implementation that used less memory, the algorithm would be broken security-wise so the openssl implementation would have to be removed, not made more efficient)

This test did obviously not do what the original author expected it to do, as the scrypt function was not executed at all
prior to my patch, it was only testing that OPENSSL_malloc(0) may return NULL.
However, it would be easy to optimize the memory allocation of this corner case like this:
diff --git a/crypto/evp/pbe_scrypt.c b/crypto/evp/pbe_scrypt.c
index 57da82f..434d738 100644
--- a/crypto/evp/pbe_scrypt.c
+++ b/crypto/evp/pbe_scrypt.c
@@ -234,7 +234,7 @@ int EVP_PBE_scrypt(const char *pass, size_t passlen,
     }

     /* If no key return to indicate parameters are OK */
-    if (key == NULL)
+    if (key == NULL || keylen == 0)
         return 1;

     B = OPENSSL_malloc((size_t)(Blen + Vlen));


Deploy the documentation to GitHub pages

@HereAround I took the liberty of merging this as further steps may be needed but this can only be done when. Hope you don't mind

@fingolfin: Thx for the PR and looking into this!
I just looked at https://oscar-system.github.io/JToric.jl/. This is where I believe the documentation should be hosted. This page still returns "page not found". Hence, as you anticipated, further steps may be necessary.

Docs are now available at https://oscar-system.github.io/JToric.jl/dev/
basically, I had to set a working DOCUMENTER_KEY  and matching deploy key by following the instructions at https://juliadocs.github.io/Documenter.jl/stable/man/hosting/#travis-ssh
Then I restarted the CI job, which created the gh-pages branch. Finally I pointed GitHub pages at the gh-pages branch.

Perfect! Thank you!


Show previous (already closed) job posts

Reason/Context
When a new user lands on the website, they may find no jobs or just a few of them. It would be great to let them see that this page is alive and it's actually working.
Description
It would be great to add a new section at the bottom to display the —already closed— job posts. This list can be initially hidden and only visible after users click on "Show previously published jobs" or similar. Another option is that the list is visible by default but the job posts are a bit faded out or show a clear indication that this job post is not open anymore.
Related issues
#369

Is this issue still open? I would like to work on it.

@theprojectcode Yes, you can work on it :) Please ping me or Fran if you will have problems with setup dev environments, implementation etc :)

@magicmatatjahu I just would like a bit more clarity on the assignment. Also, is there a website that I can visit to see the project?

@theprojectcode
website -> https://www.asyncapi.com/jobs
The description of issue seems exhaustive to me:

It would be great to add a new section at the bottom to display the —already closed— job posts. This list can be initially hidden and only visible after users click on "Show previously published jobs" or similar. Another option is that the list is visible by default but the job posts are a bit faded out or show a clear indication that this job post is not open anymore.

I would prefer the first option with button which will show/hide (by default hide) the previously closed job positions.

@magicmatatjahu Got it! I'm pretty new to open source, so please excuse the redundancy. I'm willing to work on this. This will be my first issue so bear with me, please.

@theprojectcode You have our support. The readme describes what you need to do to create a local work environment. The whole idea is to display closed jobs, so all you need to do is "reverse" the logic of displaying current jobs - the olders than the current day should display in a separate section of the page :)

@magicmatatjahu Thank you so much! I'm going to fork the project on my local machine and work on it.

You can assign it to them. Sorry, I got really busy. In the future, I'll choose a new task. @magicmatatjahu

@magicmatatjahu is this issue still open ?  I'll like to work on this!

@UtkarshA135 just keep in mind it will be challenging if you use windows. I think this is why others did not manage to complete this task that seems to be trivial -> https://github.com/asyncapi/website/issues/478
Keep in mind that we have recently configured Gitpod for this repo (check readme), so you could basically work on it by forking and opening it in Gitpod

Hey since there isn't any update on this can I open a PR fixing this?


Adding setcap to the Dockerfile causes the HasModifiedFiles check in Preflight 1.6.1 to fail

Bug Description
Adding setcap to the Dockerfile causes the HasModifiedFiles check in Preflight 1.6.1 to fail.
Version and Command Invocation
1.6.1
Steps to Reproduce:

Build an image quay.io/tkrishtop/setcap-example:v0.0.2 using the Dockerfile below:

FROM registry.access.redhat.com/ubi8/ubi:8.7-1112

RUN microdnf -y install iptables && \
    microdnf clean all

RUN setcap CAP_NET_ADMIN,CAP_NET_RAW+eip /usr/sbin/xtables-nft-multi

CMD [ "cat", "hello world"]

Run the Preflight check and observe the HasModifiedFiles check fail:

podman run -e PFLT_LOGLEVEL=trace quay.io/opdev/preflight:1.6.1 check container quay.io/tkrishtop/setcap-example:v0.0.2

-- snip --

time="2023-04-28T07:38:06Z" level=debug msg="found disallowed modification in layer" file=usr/sbin/xtables-nft-multi layer="sha256:0765ec7ff35e3e077fb047f7a8710cdcef9c2ad08877fce70f25c94492b8a213"
time="2023-04-28T07:38:06Z" level=info msg="check completed" check=HasModifiedFiles result=FAILED

Confirm that the issue is caused specifically by the setcap line: setcap CAP_NET_ADMIN,CAP_NET_RAW+eip /usr/sbin/xtables-nft-multi by building another image quay.io/tkrishtop/setcap-example:v0.0.3 without setcap:

FROM registry.access.redhat.com/ubi8/ubi:8.7-1112

RUN microdnf -y install iptables && \
    microdnf clean all

CMD [ "cat", "hello world"]

This image passes the HasModifiedFiles check
$ podman run -e PFLT_LOGLEVEL=trace quay.io/opdev/preflight:1.6.1 check container quay.io/tkrishtop/setcap-example:v0.0.3

-- snip --

time="2023-04-28T10:10:45Z" level=info msg="check completed" check=HasModifiedFiles result=PASSED

Expected Result
Telco partners often require the use of setcap:
CAP_NET_ADMIN - Allow various network-related operations (e.g., setting privileged socket options, enabling multicasting, interface configuration, modifying routing tables).
CAP_NET_RAW - Permit use of RAW and PACKET sockets.
Containers using setcap do nothing wrong or non-standard, they should pass the certification checks.
Actual Result
check=HasModifiedFiles result=FAILED
Additional Context
Since there is no solution on our side, this issue is becoming urgent and has the potential to impact many Telco partners.
cc: @bcrochet @acornett21

This should not be a failure. I'm working on a solution. I've identified what happens in the layer that causes this. The problem is not making it so broad of a fix that other things slip through.

Hi @bcrochet @acornett21 thank you for the fix. Could you please let us know when do you plan to release Preflight containing this fix?

@tkrishtop We are waiting on a change in go-rpmdb to be merged and referenced in preflight before we cut a release. Reference to PR here


PR1

This Pull Request resolves Issue #
Description:
In this Pull Request we have done the following additions/edits for the code:
Note: Delete all the text including this!

Make sure you replace #<IssueNumber> with the particular Issue that you are referencing with!
Make sure you describe the Issue properly and ask as many people as possible to review your Pull Request so that it can be merged as soon as possible!

We are no longer actively maintaining this repo. Please check the latest Hacktoberfest repo and contribute to that. Thank you again for your contribution but will have to mark this as spam and decline this PR.


Mark corpus endpoints obsolete

ignore CS0612 obsolete endpoint warnings in E2E and integration tests

Resolves #515

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.95%. Comparing base (e2f1f25) to head (fd87197).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   56.95%   56.95%
=======================================
  Files         299      299
  Lines       15734    15734
  Branches     2173     2173
=======================================
  Hits         8962     8962
  Misses       6122     6122
  Partials      650      650

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

src/Serval/test/Serval.ApiServer.IntegrationTests/Serval.ApiServer.IntegrationTests.csproj line 16 at r2 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
We should use #pragma warning disable CS0612 like you did in the controller.

done


Secrets documentation

MapLibre GL Native has 14 GitHub secrets. Are these documented somewhere?

Who is CR? I see that we use their personal access token in the android ci workflow...
https://github.com/maplibre/maplibre-gl-native/blob/ca5810f61fde26d0fbccbe4d48d4c771d02e460f/.github/workflows/android-ci.yml#L43-L45

The graddle config might be related to
https://github.com/maplibre/maplibre-gl-native/blob/5b3d936521040149e343f81ed4bd2ce24b75e690/platform/android/scripts/create-signing-key.sh#L13-L17

At the moment we have these github secrets:

Lets store all the secrets as clear text in our password manager...
Is in password manager?

[ ] BINTRAY_API_KEY
[ ] BINTRAY_USER
[ ] CR_PAT
[ ] DIST_GITHUB_TOKEN
[ ] GLCLOUD_SERVICE_JSON
[ ] GPG_KEY_CONTENTS
[ ] GPG_PASSPHRASE
[ ] MAPBOX_DEVELOPER_CONFIG_XML
[ ] MAPLIBRE_DEVELOPER_CONFIG_XML
[ ] NODE_PRE_GYP_GITHUB_TOKEN
[ ] OSSRH_PASSWORD
[ ] OSSRH_USERNAME
[ ] SIGNING_KEY_ID
[ ] SIGNING_PASSWORD
[ ] SONATYPE_STAGING_PROFILE_ID

Since CR_PAT is used in the container section here:
https://github.com/maplibre/maplibre-gl-native/blob/73973703426ebf11c3c6bea60857644c44d7b5e5/.github/workflows/android-release.yml#L12-L16
It might be that the abbreviation stands for "Container Registry Personal Access Token"...

It's also possible to get the plain text of a secret with a hack: https://stackoverflow.com/questions/63003669/how-can-i-see-my-git-secrets-unencrypted

Indeed we should have a strategy for this. We should decide where we store the secrets and how do we make them available. If there is anyone that has an overview about this I'd love to setup a short call with.

We store the secrets in a password manager where the Governing Board has access. What the secrets are doing or used for should be documented in the places close to where they are used, i.e., in MapLibre GL JS and Native for the things related to CI. And in maplibre/maplibre for the things unrelated to a repo. Some things in the password manager like the zoom password are also self-explaining...

@wipfli alright then we need to understand how can we automate this. IE: How can we can ensure security while trying to still access those secrets, for the ones that are really needed. So my suggestion is to make a list of all secrets used in codebase + CI then tackle each one individually. cc @louwers

I have cleared up unused secrets and added documentation for the secrets here: https://github.com/maplibre/maplibre-native/wiki/Repository-secrets


HTMLElement.shadowRoot is deprecated.

The contents of atom-text-editor elements are no longer encapsulated
within a shadow DOM boundary. Please, stop using shadowRoot and access
the editor contents directly instead.
HTMLElement.shadowRoot (/private/var/folders/jr/flh0m8dd7f3fspvj5xqfr4gr71tf02/T/AppTranslocation/9C5BDB85-8848-42BE-9ACB-3621EE153C53/d/Atom.app/Contents/Resources/app/src/text-editor-element.js:13:10)
MarkdownScrlSync.getVisTopHgtBot (/Users/hongjian01/.atom/packages/markdown-scroll-sync/lib/utils.coffee:20:33)
MarkdownScrlSync.setMap (/Users/hongjian01/.atom/packages/markdown-scroll-sync/lib/map.coffee:25:14)
MarkdownScrlSync.startTracking (/Users/hongjian01/.atom/packages/markdown-scroll-sync/lib/main.coffee:75:12)
<unknown> (/Users/hongjian01/.atom/packages/markdown-scroll-sync/lib/main.coffee:58:23)
Function.module.exports.Emitter.simpleDispatch (<embedded>:63490:20)

duplicate of #94


[feat]: add support for configuring the VPC interface

What this PR does / why we need it:
This PR supports customizing the VPC interface with 1:1 NAT or public interface settings through providing an explicit VPC interface on the LinodeMachine such as
---
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha2
kind: LinodeMachineTemplate
metadata:
  name: test-cluster-md-0
  namespace: default
spec:
  template:
    spec:
      image: linode/ubuntu22.04
      interfaces:
      - purpose: VPC
         primary: false
      - purpose: public
         primary: true

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
TODOs:

[ ] squashed commits
[ ] includes documentation
[ ] adds unit tests
[ ] adds or updates e2e tests

The change looks good to me. Should we also add some documentation related to it just in case someone else is interested in using such settings?


Cherry picked network changes for cardano-node-1.35.5 release

This cherry-picked patches from the following PRs:

#3794
#3844
#3785
#3904
#3915
#3852
#3970
#3979
#4015
#4067
#4004
#4086
#4113
#4106
#4127
#4103

Also cherry-picked almost all the commits which modify GitHub actions:

18c5244ee5 Run GitHub Actions on pull requests
3adf5a94f5 Use newer version of io-sim
ee9b7a6f91 Fix GH Actions Windows CI: switch from pkgconf to pkg-config
e6cf074235 github-actions: use ubuntu-latest
9a8b959c90 Updated versions of github actions
fc8f8f05c8 Fix GH Actions Windows CI caching
7f07c40769 Windows Github Actions now use MSYS2
b21a7ced89 Fix chocolatey CI error
#4134

TODO:

[x] bump versions of packages
[x] input-output-hk/cardano-haskell-packages#84

bors merge


Update yaml files

C1_ports_shipping_aq C2_ports_cars_aq  C3_ports_people_aq E13o_vessel_density_all E13p_vessel_density_cargo E13q_vessel_density_tanker E13r_vessel_density_others CDS3_wind_10m_u CDS4_wind_10m_v

Hi @santilland @lubojr
I don't know if I'm doing something wrong. I tried to modify the YAML files directly from here as we agreed, but I see that "all checks have failed". I don't know what these checks are.
Please tell me if I have to do something different :)

Hi @santilland and thanks for your reply. How can I do that?

You can write the list of collection identifiers (separated by spaces) you want to test in the body of the pull request. So by editing the first "comment" of the pull request. After you push a commit it should then only generate the collections provided in that list.

Like this?
Sorry for these questions, but I'm not an expert GitHub user

No problem, it is not common use what we are doing here, so questions are very much welcome, we will need to better describe and document the process we are still evaluating.
The collection identifier for generation is the file name (without the extension), so in this case it would be:
C1_ports_shipping_aq CDS3_wind_10m_u

Ah ok! Clear
Thanks Daniel

Looks good, this should apply for your next commit then

@FedericoRondoni please make sure that the license field uses a spdx license identifier as defined here:
https://spdx.org/licenses/

@FedericoRondoni please make sure that the license field uses a spdx license identifier as defined here: https://spdx.org/licenses/

Hi Daniel, I checked already, but I couldn't find any relevant license. I will check again.
However, is there a procedure to bypass this issue if one license is not present in the spdx catalogue?

Hi @santilland, I also added the license field to two yaml files here, but maybe there is something that you need to implement in this branch as well?

Yes, we will need to merge the updates from the other branch to this one, i can do it once we merge the other branch

Yes, we will need to merge the updates from the other branch to this one, i can do it once we merge the other branch

Ok perfect!

Hi guys @santilland @lubojr once the merging of the assets branch YAML-alignment is done, we can ask Anca to review these YAMLs and descriptions.
We will continue to prepare the other batches.

@aapopescu this pull request is the first batch ready to be merged, you can see the preview of the catalog with following url:
https://eodash-testing.eox.at/ui-panels-cat-stacinfo/?catalog=yaml_test

@FedericoRondoni @aapopescu the new stac structure was introduced and merged into this branch, we also merged the test branch of the client, so you can explore the client with the current data here:
https://eodash-testing.eox.at/ui-panels-cat/?catalog=yaml_test
I will write an extra mail with information on "grouping".


MSDKUI-1735: Update coordinates inject functionality

Updated documentation and improved naming

Signed-off-by: Ants Peetsalu<EMAIL_ADDRESS>

Codecov Report

Merging #95 into master will increase coverage by 0.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   88.39%   89.22%   +0.83%
==========================================
  Files          89       59      -30
  Lines        5497     3527    -1970
==========================================
- Hits         4859     3147    -1712
+ Misses        638      380     -258

Flag
Coverage Δ

#ios
89.22% <ø> (+0.83%)
:arrow_up:

Impacted Files
Coverage Δ

MSDKUI_Demo/IconButton.swift

MSDKUI_Demo/OptionsViewController.swift

MSDKUI_Demo/ManeuversOverviewViewController.swift

MSDKUI_Demo/GuidanceDashboardViewController.swift

MSDKUI_Demo/ExtensionArray.swift

MSDKUI_Demo/RouteViewController.swift

MSDKUI_Demo/ExtensionUITableViewCell.swift

MSDKUI_Demo/ExtensionBundle.swift

MSDKUI_Demo/ExtensionNMAMapMarker.swift

...UI_Demo/GuidanceDashboardTableViewDataSource.swift

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 731c832...ca0ffac. Read the comment docs.


Provide a better customization API for Stetho.initialize

Now that many more configuration options are becoming available it's
important to provide a more streamlined API for overriding plugins or
adding new ones, especially for dumpapp.
Closes #195

@rightparen I actually took a look at doing it using a Map per your out-of-band suggestion but I honestly think this approach is still better.  It's more concise and doesn't require callers to repeat the name of the plugin in two places (one in registration and one in the plugin itself).  Technically that can be modified so the plugin no longer self identifies but since this is not ABI compatible it cannot be done quickly.
Also I noticed that the flexibility desired by your approach is still possibly by simply manipulating this design and saying new DefaultDumperPluginsBuilder(...).build(), yielding a list which can be trivially converted to a map yourself.  Few callers would need this, however, but it is important to observe that it is still possible.


[SUPPORT]In the scenario of writing from mysql cdc to hudi use flink，does hudi already supported schema evolution？

Tips before filing an issue

Have you gone through our FAQs?

Join the mailing list to engage in conversations and get faster support at<EMAIL_ADDRESS>

If you have triaged this as a bug, then file an issue directly.

Describe the problem you faced
A clear and concise description of the problem.
I'm using flink ingest data from mysql to hudi，but I'm running into a problem： mysql table schema will change，i want implement automatic schema evolution，  does hudi already support this requirement, or is it already in development
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.
Environment Description

Hudi version :

Spark version :

Hive version :

Hadoop version :

Storage (HDFS/S3/GCS..) :

Running on Docker? (yes/no) :

Additional context
Add any other context about the problem here.
Stacktrace
Add the stacktrace of the error.

@danny0405 Hello Danny, can you help me with this problem?

@Tomccat3 Hudi should support it. Are you facing issues? What kind of schema changes you are having?

@Tomccat3 , schema evolution in Hudi is supported, but not automatically, you still need to alter the table schema manually and maybe restart the writing job.

Commenting for visibility as this might be a feature-request for implicit comprehensive schema evolution for Hudi-on-Flink.

@Tomccat3 , schema evolution in Hudi is supported, but not automatically, you still need to alter the table schema manually and maybe restart the writing job.

Thanks for you reply, i don't want to restart the writing job, can schema evolution be made automatic in flink datastream job?

@Tomccat3 Hudi should support it. Are you facing issues? What kind of schema changes you are having?

For example:

I have a flink datastream job consume mysql binlog and then write to hudi 。
When the upstream mysql table schema has changed，i need to alter hudi table schema manually, and restart the flink job, i hope it can be made automatic。

be made automatic in flink datastream job

No, the open source Flink does no support pass the schema around to the sink, that is a tricky part for Hudi to track the schema changes dynamically.

be made automatic in flink datastream job

No, the open source Flink does no support pass the schema around to the sink,
ok, what if we implement a RowData with schema?

yeah, possible, you can pass around the schema together with the RowData, before each commit, you can overwrite the schema with the latest schema, only feasible for Flink DataStream API.

ok, i will try

ANy example o how to do this? How can you build the Hoodie Pipeline Builder dynamically from RowData?

@Tomccat3 Can you please provide an example of passing the schema along with the RowData? Currently, it seems to be tightly coupled with the HoodiePipelineBuilder with a static schema.


Default resources on pod-spec-patch throws validation error

I tried to implement the exact yaml example supplied in:
https://github.com/buildkite/agent-stack-k8s?tab=readme-ov-file#default-resources
The helm install operation works, but all of the containers fail with:
- config.pod-spec-patch.containers.0.resources.limits.memory: Invalid type. Expected: map, given: string
- config.pod-spec-patch.containers.0.resources.requests.cpu: Invalid type. Expected: map, given: string
- config.pod-spec-patch.containers.0.resources.requests.memory: Invalid type. Expected: map, given: string

Here is the exact values.yaml file I'm supplying
config:
    org: ...
    debug: true
    cluster-uuid: ...
    config:
      pod-spec-patch:
        containers:
          - name: agent          # this container acquires the job
            resources:
              requests:
                cpu: 100m
                memory: 50Mi
              limits:
                memory: 1Gi
          - name: checkout       # this container clones the repo
            envFrom:
              - secretRef:
                  name: secret-key
            resources:
              requests:
                cpu: 100m
                memory: 50Mi
              limits:
                memory: 1Gi
          - name: container-0    # the job runs in a container with this name by default
            resources:
              requests:
                cpu: 100m
                memory: 50Mi
              limits:
                memory: 1Gi

Hey @bnovick, I think I've found the bug - something missed in the push to get pod-spec-patch released. I hope to fast-follow with another release for you!


Popup

It would be nice if there was one modal/pop-up with all these controls in a form layout.

You wouldn't submit the form, you would just change the values and they would stay in those boxes. Like a settings page.

Or instead of a popup, there's just another settings page under the video somehwere.

For now, just create the HTML page that would be this page. The actual position on the page can be decided later.

Drafting: https://jsfiddle.net/yg60905y/9/

Idea: In the HTML, have different tabs for each gadget to reduce clutter.

https://jsfiddle.net/yg60905y/35/


Spec versioning scheme is not clear

Looking at the history of:
https://github.com/swagger-api/swagger-spec/commits/master/schemas/v2.0/schema.json
As the schema for the spec itself changes, should not the version number change as well?
It's been "2.0" for a while. This is leads to a lot of confusion where multiple products say they support "Swagger 2.0" ... but they are really talking about different specs :confused: !
Take for example this issue:
https://github.com/swagger-api/swagger-spec/issues/452
What used to be valid "Swagger 2.0" ... is not anymore.
If I am   third party product, and I want to claim that I am "Swagger 2.0" compliant,  what should I be looking at as the source of truth for what "Swagger 2.0" is?

The source of truth is the spec itself - https://github.com/swagger-api/swagger-spec/blob/master/versions/2.0.md - and not the schema. The schema is a tool, just like swagger-ui snd so on. The "version" of it is going to stay 2.0 as that's the version of the spec. That said, we have been meaning to include a revision property too in the schema to show internal document versions but haven't gotten around to it. We'll take extra care in the next version of the spec with that regards. So Swagger 2.0 is Swagger 2.0, there are no 'different specs'.

Thanks for clarifying that I should be looking at the MD file as being "the spec".
In that case, should not the "Revision History" section be updated when there are spec changes.

What kind of spec changes warrant a new version being introduced?
Any thoughts on using semantic versioning for the spec itself?

The spec updates with clarifications, typo fixes and such, but not with structural changes. 2.0 is the first version of the spec that was written alongside the creation of the spec itself, so the process itself was fairly new. Even though the 1.2 spec exists, it was actually reverse engineered and was written quite some time after the 1.2 version was released.
We're definitely looking to improve the process in future versions (read: minor/major versions, not document updates) and the feedback is welcome. We're considering semver for the spec, although I'm not sure how well it would suit the spec itself.

See #561


liferea hash error

Liferea 1.10.18 fails to install, possibly due to upstream changes to the binary (https://github.com/lwindolf/liferea/issues/310):
output path ‘/nix/store/2c8x8dkxsfisahy447mcggj335h6n6cg-liferea-1.10.18.tar.bz2’ has sha256 hash ‘0xyy0qm3h22b69if2hmg36jzvvljxb1w0zy2m2a28kdqfzpa6m8g’ when ‘0wpinar2cxyzq2j7ff7lznc08f0n6qjdm9aavsarbgdpaf2s1xvq’ was expected

My nixos-version is 16.03pre76756.885acea (Emu)

thanks, PRed

Context: https://github.com/NixOS/nixpkgs/commit/7fd2cc1ea8687568901e7f8efec940ccb9e06657

Closing as it's fixed in master

And I though noone was using the package around here...


feat: Upgrade goreleaser

Please describe the Improvement and/or Feature Request

Scope (please mark with X where applicable)

New Functionality              [ ]
Install                        [ ]
Gateway API - GatewayClass     [ ]
Gateway API - Gateway          [ ]
Gateway API - HTTPRoute        [ ]
Gateway API - TLSRoute         [ ]
Gateway API - TCPRoute         [ ]
Gateway API - UDPRoute         [ ]
Gateway API - PolicyReference  [ ]
Ingress                        [ ]
Egress                         [ ]
MultiCluster                   [ ]
PIPY Control Plane             [ ]
PIPY Script/Config             [ ]
CLI Tool                       [ ]
Metrics                        [ ]
Certificate Management         [ ]
Sidecar Injection              [ ]
Logging                        [ ]
Debugging                      [ ]
Tests                          [ ]
Demo                           [ ]
CI System                      [x]
Project Release                [x]

Possible use cases

As we have upgraded golang to v1.19, should upgrade goreleaser as well.


Test issue

- [ ] https://github.com/octo-org/octo-repo/issues/45
- [ ] Draft task

[ ] hello

[ ] sfsdf

[ ] sdfsdf

[ ] sdfsdf

duplicate of 2


[#227] Add Project Configurations document

Resolve #227
What happened
As we have a workflow that supports publishing docs to the wiki, we need to bring all iOS templates' documents into the repository's source.
Insight

Add document into the folder wiki

Brings document from the Notion page into the repository's source

Proof Of Work

@suho can you check the CI issue, please? 🙏

@markgravity The issue will be fixed by this #269

@minhnimble Thanks for your comments, I fixed all comments, please double-check this pull request again!


Change font style

Coverage remained the same at 93.231% when pulling 78b3f83ea260ff9c05d003925ca5e069ab789185 on change-font-style into ce94670171d6938a09bda6989875446bacf409ef on search-pagination.

Coverage remained the same at 93.231% when pulling 100523d2237769a87003efecff618ced08ff061e on change-font-style into ce94670171d6938a09bda6989875446bacf409ef on search-pagination.

Coverage remained the same at 93.231% when pulling 100523d2237769a87003efecff618ced08ff061e on change-font-style into ce94670171d6938a09bda6989875446bacf409ef on search-pagination.

Coverage remained the same at 93.231% when pulling 100523d2237769a87003efecff618ced08ff061e on change-font-style into ce94670171d6938a09bda6989875446bacf409ef on search-pagination.


ARROW-11243: [C++] Recognize time types in CSV files

Allow reading CSV columns as time32 and time64
Automatically infer "hh:mm" and "hh:mm:ss" as time32[s]

@ursabot please benchmark

(rebased)

This could be a future JIRA or "wait until it's asked for" but technically ISO-8601 allows the omission of the colons if you add a leading T but I've never seen it in practice...
Thh
Thhmm
Thhmmss
Thhmmss.sss

@westonpace I'd rather wait before someone requests it.


[Docs] StarGo binary doesn't exist

File: /docs/administration/stargo.md
This file doesn't exist https://github.com/wangtianyi2004/starrocks-controller/raw/main/sr-ctl
I believe the correct file is https://github.com/wangtianyi2004/starrocks-controller/raw/main/stargo-pkg.tar.gz

we shall remove this doc, or make a fork to under our org account. A link pointed to a personal repo, doesn't sound like professional.


Fixing regression in our SDK due to recent UIKit.Xaml namespace colli…

…sion fix.  We were copying the wrong .pri file into the SDK output for UIKit.Xaml.dll.  Validated the fix locally after rebuilding the entire SDK project.

This change is

:shipit:


Video Resolution?

Is there a way to specify the resolution the recorded video will be generated with (eg. 1080p)?

I am also looking for the same option. Can anyone help

<ReactMediaRecorder
  video={{
    width: { ideal: 1920 },
    height: { ideal: 1080 },
    aspectRatio: { ideal: 16 / 9 },
    facingMode: 'user',
    frameRate: { ideal: 60, max: 60 },
    // if using typescript press CTRL + SPACE with
    // cursor in this object to see available options
  }}
  // other props...
/>

spec


Text fill style do not show unless they have stroke style as well.

Hello,
I upgraded to 3.10.0 this morning and when I run my app I have noticed that all labels disappeared.
After some research I have found the problem. If I have the fill style I also need the stroke style set for the ol.style.Text.
This is caused by this piece of code:
ol.render.canvas.TextReplay.prototype.drawText =
function(flatCoordinates, offset, end, stride, geometry, feature) {
if (this.text_ === '' ||
!this.textState_ ||
(this.textFillState_ &&
!this.textStrokeState_)) {
return;
}
....
As you can see if fill style is set and stroke style is not - the method quits and does not render the text.
While the method:
ol.render.canvas.TextReplay.prototype.setTextStyle
sets the values for textFillState_ and textStrokeState_ independantly and does not require textStrokeState_ to exist if the fill is given.
As a temporal workaround I have added the stroke style to my text style
text.stroke = new ol.style.Stroke({color: 'rgba(0, 0, 0, 0)'})
just to make it work as expected.
But I am guessing it might be a bug :)

Possible regression from 31a68e21a51ee378c3698354523d185eef52f543
Previously the relevant lines looked:
  if (this.text_ === '' ||
      goog.isNull(this.textState_) ||
      (goog.isNull(this.textFillState_) &&
       goog.isNull(this.textStrokeState_))) {
    return;
  }

after 31a68e21a51ee378c3698354523d185eef52f543
They look like
  if (this.text_ === '' ||
      !this.textState_ ||
      (this.textFillState_ &&
       !this.textStrokeState_)) {
    return;
  }

I think it should be
  if (this.text_ === '' ||
      !this.textState_ ||
      (!this.textFillState_ &&
       !this.textStrokeState_)) {
    return;
  }

We definitely need tests for these as @tschaub already mentioned (https://github.com/openlayers/ol3/pull/4216#issuecomment-145614080)

@jmekaelthas Can you check if #4242 fixes your issue?

I have downloaded 3.10.1 a moment ago. The issue seems fixed :) Thanks a lot.


How to set rust-analyzer.cargo.target?

Hi, I have a mixed native/wasm32-unknown-unknown project and #[cfg(target_arch = "wasm32")] blocks don't get analyzed.
Apparently you can set a rust-analyzer.cargo.target option for this but I don't see an easy way to do it with rust-tools (ideally based on my project's Cargo.toml or .cargo/config).
Any ideas on how I can achieve this?

https://github.com/simrat39/rust-tools.nvim/wiki/Server-Configuration-Schema


Default values aren't being persisted

I am interested in using AttrJson to store "notification settings" (think, subscribed/unsubscribed to various email, push notifications, etc...). As a very simple case, I have something like the following set up
class User
  include AttrJson::Record
  include AttrJson::Record::Dirty
  include AttrJson::Record::QueryScopes

  attr_json :subscribed_to_weekly_report, :boolean, default: :true, container_attribute: :notification_settings
end

class AddNotificationSettingsToUsers < ActiveRecord::Migration[5.2]
  def change
    add_column :users, :notification_settings, :jsonb, default: {}
    add_index :users, :notification_settings, using: :gin
  end
end

The default value is present when I fetch back a record that's not yet had the key set, or when I create a new instance via User.new. But in neither case is the default value persisted back to the db upon user#save. That seems... odd. I even added dirty tracking to see if that would do it, but it's the same behavior.
u = User.new
#<User> { notification_settings: { "subscribed_to_weekly_report: => true } }
u.save!
# INSERT INTO "users" ("created_at", "updated_at") VALUES ($1, $2) RETURNING "id"
#<User> { created_at: <DateTime>, updated_at: <DateTime>, notification_settings: { "subscribed_to_weekly_report: => true } }

I have to set the attribute to a non-default value (e.g., false for the boolean attribute I've setup above) and then save. At which point it's persisted. And setting it back to true and saving then persists that value.
Is this expected? Am I doing something incorrectly?
Thank you.

That definitely doesn't sound right. I wonder if it's a bug specifically related to boolean values. I will try to look into it.
If you wanted to try to create a failing test in a PR, that would be helpful and a head start -- but not required, I'll look into it either way.

oh also, can you tell me what version of Rails just in case?

Sure. Rails 5.2

Aha, I did reproduce on travis when I added a test.
It is specifically a problem with boolean attributes it looks like, which i hadn't tested.  Defaults seem to work reliably for other types, just not boolean.
Weird that I don't seem to be able to reproduce on my dev machine, just on travis -- the test I added passed on my dev box, and I was shocked to see it fail on travis.
Anyhow, now I need to figure out what's going on and hopefully find a way to fix it.
Thanks for taking it for a spin reporting the problem. I could suggest various workarounds (like using AR callbacks instead of attr_json default), but I'm not really sure the nature of the problem, or if it only effects defaults or there will be other problems with booleans. I will investigate more!

Wait, sorry, deleted that last comment.
That was my user error, I'm actually not succesfully reproducing your problem yet. I'll try harder to do exactly what you are doing, but if you want to put a full rails app demonstrating the problem in github, or PR a failing test case, or anything else with runnable code demonstrating the failure, it would be helpful! (But not required, I'll keep digging).

oh wait, I do now understand what you're reporting better now. OK, i'll keep digging. Hmm, this might be tricky.
Thanks for taking it for a spin and reporting!

gah, yeah, this is a consequence of how I did defaults. I will try to figure out how to fix it, hmm.

@jrochkind thanks for digging in. And sorry it's turning out to be tricky. It sounds like you've got a handle on it, but if you still need something reproducible, I can try to get a failing test together. Else, let me know if you need more info.
Thanks!

thanks, yeah, i've got a failing test written now, just got to dig into AR internals to understand what's going on and why it's not what I expected, heh.

Hmm, I've found a way to maybe make it work more of the time, but it's pretty tricky dealing with AR with regard to this stuff. I can't believe I didn't notice it wasn't working like this already, I would have expected it to, thanks for pointing it out.
Can you talk about about your use case, and what problems this will cause you as is?
As it is, I believe if you have any attr_json in the same container_attribute that you DO set manually (by any means), then the defaults will all be saved to db. But if it's only defaults, nothing will be saved to db for that column, AR at the moment thinks there have been no changes to save.

you can also of course use normal AR migration/db defaults, I wonder if this would work for you:
add_column :users, :notification_settings, :jsonb, default: {"subscribed_to_weekly_report => true}

I may have found a way to change it in all cases, but now I'm starting to get confused about which is the better behavior!
  I may experiment more with what AR does in similar situations without my code.
But still interested in your use cases!

Okay, so right now.... notice that your migration with default: {} is neither recommended by docs nor necessary (although it doesn't hurt).  You don't need any default there.
In the situation where you supply no default in the migration, and no defaults in attr_json -- if you create a record without assigning any values to attr_json at all, your container attribute remains null/nil in the db, not the empty hash. Or you can set it to the empty hash yourself, or whatever. It's up to you, but you can have a distinction between nil and the empty hash if you want.
With the way I've found to make it work how you expect for your case, this will go away -- even if you have no attr_json defaults, saving a model with any attr_json's will result in an empty hash to the container attribute, never nil.
I'm not really sure if this is a problem?
I'm also not really sure I understand how I tricked AR into doing what we want in this ticket either, I don't totally trust it.

a default value of the empty hash always seemed better/advised b/c it made querying the data more consistent - not having to deal with null. Though... perhaps even that's unnecessary?

It seems I might have been right to default to the empty hash. A jsonb column with nil value must be specially accounted for when querying. Whereas the contains operator (@>) handles an empty hash as you'd expect:
SELECT * FROM "users"
  WHERE NOT("notification_settings" @> '{"subscribed_to_weekly_report":false}')

/* rows with an empty hash are returned. Rows with nil are not */

A) Your use case makes sense, I get why you need/want this.
B) Yes, that makes sense for querying. Not everyone has gotta query, but it does make sense. In general, I'm trying to keep this thing as open and non-assumption about what you want to do as I can, to make it a suitable flexible lower-ish-layer.
C)  You could actually do an AR migration db-level default to default: {subscribed_to_weekly_report: true, I tested that and it works in Rails 5.2 at least. It serializes to JSON and puts that string as the db default, and everything else in attr_json works. But I'll assume this is not ideal and you understandably would prefer to keep everything together.
D)

To be clear, I absolutely think that User.new should not, ever, write to the DB. But, I would expect that User.create would write to the DB, and that any default values I've setup for the column are persisted.

Right, I understand and am on the same page. the question is:  if you don't have any attr_json defaults, and don't have a migration-db default to {}, when you do Record.create, should your container attribute be forced to be {}, or should it be allowed to be nil, might some users want to allow it to be nil (ie entirely NULL in the db, no json value at all)  and have nil  and an empty hash be different things?
Do you follow? I'm not sure. Interested in your opinion if any. But I am reluctant to take that option away. But I think there's probably a solution.
Oddly, for reasons I mostly but don't entirely understand, what makes this do what you want is putting in an AR attributes-API default of {}.  Because AR ends up storing the {} somewhere in it's depths it uses for change-tracking, and then realizes that the hash-with-defaults is not the same as {}, and the column is dirty and needs to be persisted.  Which otherwise there's no good API to access from where the attr_json code is currently.  The migration/db-level default is not enough. And if the AR attributes-API default is there, you wouldn't need the migration/db-level default, it would always end up being an empty hash anyway.
So what I'm thinking is I need an additional argument to attr_json that controls whether there is an AR-level (not db) {} default enforced, or not. And it will probably default to doing what will make things how you want, but still be optionally settable for the 'old' way.
It's also possible I don't need the configuration, and should just force AR-level default to {}.
I appreciate your conversation and feedback!

(Oh, and there was something else I had to fix to make the AR-level-default-to-{} work too, btw.)

Side bar: I just stumbled across https://github.com/byroot/activerecord-typedstore, which might be of interest. At least there might be some tips, tricks, or ideas in the implementation that could inspire implementation of attr_json. 😄

Getting back to your post from yesterday, I'd agree with what you have there. A default of {} makes sense, so long as there's a way to allow a nil default I suppose.

You could actually do an AR migration db-level default to default: {subscribed_to_weekly_report: true} [...] I'll assume this is not ideal and you understandably would prefer to keep everything together.

The other problem is I'd need to change the db default every time we add a new kind of notification setting (e.g., a new email, or push notification). I'd rather have the default defined in the AR model, right next to where I'm declaring the attribute. In fact, using the following, which all comes out of the box in modern Rails, mostly gets it done:
  attribute :notification_settings, :json, default: { subscribed_to_weekly_report: true }
  store_accessor :notification_settings, :subscribed_to_weekly_report

This only works for simple cases and breaks down if need to nest data, or have compound/custom types. Or if I want/need to type-cast the values. Which is what AttrJson is for, I suppose. Or activerecord-typed-store if I only need/want the type casting. And of course, I have to hand-roll all of the querying.

Yep, I'll get it working one way or the other. Into some investigations to understand what's going on and the implications better. Thanks for your patience, I'm trying to be really intentional with this gem, cause I want it to be really solid, cause I plan to build other layers on top of it.

I can now make it work, but it messes up my Dirty implementation for reasons I don't understand yet.
I think that my previous implementation actually wouldn't let you set the container attribute to nil anyway. I had that in mind as a use case, but apparently never tested it and it wasn't possible anyway, so once I confirm that for sure in master branch, that's not a concern.

The bizarre thing is when I apply my own under-the-hood attributes ... default: -> { {} } under the hood... and then use the stock AR dirty stuff.... the "original value" of the container attribute switches from empty hash to nil. Like it's the opposite of what I expect.
But if I account for that, all my dirty tests pass again... so I guess I'll just accept it and not do more AR code archeology.
@stevenharman are you interested in looking over the PR to help out?  I have nobody regularly doing code review.


refactor LoaderDependency to es6

What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
current tests should pass
If relevant, link to documentation update:
N/A
Summary
upgrade LoaderDependency to es6
Does this PR introduce a breaking change?
No

🚢 it. Thank you


ScreenCloud.ScreenCloudPlayer version 2.11.14

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

/AzurePipelines run

False Detection, https://screen.cloud/ and https://screencloud.com/ are operated by the same company.


Fixed issue #7 - use getText() on StylarView

Issue #7 states that the text can not be read directly from the StylarView
It can be done as follows:
\\ ...
StylarView stylarView = findViewById(R.id.zStylarView);
\\ ...
stylarView.getText()
\\ ...

Contributing has more information and tips for a great pull request.

@zeobot set lc to pass

@zeobot set lc to pass


Set up Hugo with documentation stubs

Not sure if there is a way to combine this with #12, but this is the corresponding pull request I made.

@callumcurtis this should be good to go - only unknown is whether the workflow file will run correctly. If you'd rather I could open a separate repo to check first?

It's low risk so let's give it a shot first and then you can add a fix on top if something goes wrong.

Haven't pulled to look at the theming locally but we can iterate on that as we go. For the future, a screenshot of the theme appearance in the browser would be helpful! LGTM


Support listing posts by tag

Relevant endpoints

All tags: https://lobste.rs/tags.json
Posts by tag: https://lobste.rs/t/rust.json

Additional info
Tags can be combined in an OR fashion, so posts tagged both plt and rust can be fetched at https://lobste.rs/t/plt,rust.json.

Don't really think I want this anymore

This seems like a good feature to have since tags are already there. Any specific reason not to have this ?

This seems like a good feature to have since tags are already there. Any specific reason not to have this ?

Couldn't think of a good enough UI at the time, plus the search functionality lets you use tag:<tag name> to filter results so it's a relatively acceptable compromise.


Add a convenient way of setting/adding charset in the HTTP content-type header of the Response

For example text/html; charset=utf-8. Currently this requires a call to set_header but not forgetting to add the mime-type that may already be there.

Is there a reason we wouldn't always set the charset for HTML?

Not that I can think of but I'm no expert regarding http headers. Of note is that charset can be set for other text types as well, and application/json.
I'm also unsure of the economics here, could it be utf-8 by default and then have some way of changing it such as "wisp.set_charset"? Or are there too many people out there for whom utf-8 would be just plain wrong?

Gleam uses utf-8 so the these bodies are guaranteed to be that charset. Let's add it to all of them


secrets.yaml

What is:
kit_api_key
lroom_api_key
I searched the ESPHome documentation, but i can´t find it...

Nevermind, found it in the code.
But it doesn´t compile.
INFO ESPHome 2024.11.3
INFO Reading configuration /config/esphome/cyd.yaml...
ERROR Error while reading config: Invalid YAML syntax:
mapping values are not allowed here
in "/config/esphome/common/CYD.yaml", line 209, column 74

An update to Home Assistant broke the code a little while ago - I'll try to get the fix uploaded


TestExplorerResults.xml is created in root of projects

When you run tests using your plugin it creates TestExplorerResults.xml in the root of my projects.

Not sure I want that there? Maybe some configuration for it, or default to temp?

pesterExplorer.testResultsFilePath is a path relative to your workspace... but you're right it should probably go somewhere in a temp file. I can't remember why I did it this way...

For now, add it to your gitignore

I agree, it's easy enough to gitignore.

I agree, it's easy enough to gitignore.


[OKD-Core] Add namespace prop to EventStream and fix scrolling

commit is missing OKD label

commit is missing OKD label

label added