fix health probes for VM's

This resolves the issue explained here: #34407
tl;dr
VM's that specify the ISTIO_SVC_IP fail the health checks (this wasn't an issue in Istio 1.9.x when manually specifying the env variable)
With this PR we update the istioctl workload entry configure command to set the env var REWRITE_PROBE_LEGACY_LOCALHOST_DESTINATION to true, which will use localhost instead of IP address for the health probes.

Hi @rinormaloku. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevenctl and @howardjohn, tagging you guys as you helped review the previous story regarding supporting VMs that specifying the workloadIP: #32383

I understand the problem but am not sure this is the correct fix. Will think about it more and get back to you soon

Specifically because this requires applications to bind to localhost, which historically has proven to be something many applications do not do

Thought about this some more:
One idea is to keep using external IP, but auto-detect the IP is external and not use the ::6 bind. This does not work; the request would loop back through envoy inbound and be rejected (strict mtls, etc).
Other option is to have a separate setting for internal IP and external IP. This would work but I think a bit complex.
Third option is to do exactly what you did here, but under a flag (say --external-ip or something) so it only impacts the (somewhat small) set of external IP users. For these users, they need to take care to ensure their applications bind to localhost.
I am leaning towards the third option, WDYT?
Other option is to find an alternative to "tag" traffic we don't want iptables captured besides source IP, but I have not found a good way

For the third option would these be the changes:

rename workloadIP flag to --external-ip (this appends the REWRITE_PROBE_LEGACY_LOCALHOST_DESTINATION env)
add a new --internal-ip flag that adds only the ISTIO_SVC_IP

Or only the first point?

For the third option would these be the changes:

rename workloadIP flag to --external-ip (this appends the REWRITE_PROBE_LEGACY_LOCALHOST_DESTINATION env)
add a new --internal-ip flag that adds only the ISTIO_SVC_IP

Or only the first point?

In a vacuum those both sound good. But would be slightly worried about renaming existing flag? I suppose it could be an alias. I don't have a strong opinion here, will leave to @istio/wg-user-experience-maintainers (owners of this code) to decide on best flag names

Most likely nobody uses the flag workloadIP as Istio 1.11 is the first release containing it — and if someone would have used it they would have filed a ticket as the feature is not working. I think it is safe to rename those. However, I'll wait for a confirmation before I make and submit the updates

Oh I was not aware that it's new! No wonder no one else had this issue :-).
In that case, I think --internal-ip and --external-ip are good choices.
On Thu, Jul 29, 2021 at 11:02 AM Rinor Maloku @.***>
wrote:

Most likely nobody uses the flag workloadIP as Istio 1.11 is the first
release containing it — and if someone would have used it they would have
filed a ticket as the feature is not working. I think it is safe to rename
those. However, I'll wait for a confirmation before I make and submit the
updates
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/34411#issuecomment-889349401, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXNZVOIHCCK54REOCFLT2GJT5ANCNFSM5BGMEANQ
.

@howardjohn made and tested the changes.
Should I update this release note? https://github.com/istio/istio/blob/master/releasenotes/notes/32462.yaml
Or should I create a new one?

 Please keep workloadIP, but mark it as deprecated. If it is supplied, print a warning then either fail the command or use it to set internalIP.

The flag is new in 1.11, so we never released it. That is why we should make sure to merge this in 1.11 (or not at all, in the current state)

/ok-to-test

@rinormaloku: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
deaa0d0daacc8b4dd626e8620e3690599aefc6bf
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
deaa0d0daacc8b4dd626e8620e3690599aefc6bf
link
/test release-notes_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
deaa0d0daacc8b4dd626e8620e3690599aefc6bf
link
/test release-notes_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
deaa0d0daacc8b4dd626e8620e3690599aefc6bf
link
/test release-notes_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
deaa0d0daacc8b4dd626e8620e3690599aefc6bf
link
/test release-notes_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-multicluster-tests_istio

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
deaa0d0daacc8b4dd626e8620e3690599aefc6bf
link
/test release-notes_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-multicluster-tests_istio

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

integ-pilot-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-multicluster-tests_istio

lint_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
deaa0d0daacc8b4dd626e8620e3690599aefc6bf
link
/test release-notes_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-multicluster-tests_istio

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

integ-pilot-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-multicluster-tests_istio

lint_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test lint_istio

integ-cni-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-multicluster-tests_istio

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

integ-pilot-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-multicluster-tests_istio

lint_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test lint_istio

integ-cni-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-cni-k8s-tests_istio

release-notes_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-multicluster-tests_istio

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

integ-pilot-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-multicluster-tests_istio

lint_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test lint_istio

integ-cni-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-cni-k8s-tests_istio

release-notes_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-notes_istio

integ-security-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-multicluster-tests_istio

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

integ-pilot-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-multicluster-tests_istio

lint_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test lint_istio

integ-cni-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-cni-k8s-tests_istio

release-notes_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-notes_istio

integ-security-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-k8s-tests_istio

unit-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-multicluster-tests_istio

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

integ-pilot-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-multicluster-tests_istio

lint_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test lint_istio

integ-cni-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-cni-k8s-tests_istio

release-notes_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-notes_istio

integ-security-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-k8s-tests_istio

unit-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test unit-tests_istio

integ-operator-controller-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-multicluster-tests_istio

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

integ-pilot-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-multicluster-tests_istio

lint_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test lint_istio

integ-cni-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-cni-k8s-tests_istio

release-notes_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-notes_istio

integ-security-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-k8s-tests_istio

unit-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test unit-tests_istio

integ-operator-controller-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-multicluster-tests_istio

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

integ-pilot-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-multicluster-tests_istio

lint_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test lint_istio

integ-cni-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-cni-k8s-tests_istio

release-notes_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-notes_istio

integ-security-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-k8s-tests_istio

unit-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test unit-tests_istio

integ-operator-controller-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-k8s-tests_istio

gencheck_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-multicluster-tests_istio

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

integ-pilot-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-multicluster-tests_istio

lint_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test lint_istio

integ-cni-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-cni-k8s-tests_istio

release-notes_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-notes_istio

integ-security-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-k8s-tests_istio

unit-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test unit-tests_istio

integ-operator-controller-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-k8s-tests_istio

gencheck_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test gencheck_istio

integ-helm-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-multicluster-tests_istio

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

integ-pilot-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-multicluster-tests_istio

lint_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test lint_istio

integ-cni-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-cni-k8s-tests_istio

release-notes_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-notes_istio

integ-security-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-k8s-tests_istio

unit-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test unit-tests_istio

integ-operator-controller-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-k8s-tests_istio

gencheck_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test gencheck_istio

integ-helm-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-helm-tests_istio

analyze-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test analyze-tests_istio

integ-telemetry-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-multicluster-tests_istio

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

integ-pilot-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-multicluster-tests_istio

integ-cni-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-cni-k8s-tests_istio

integ-security-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-k8s-tests_istio

unit-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test unit-tests_istio

integ-operator-controller-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-k8s-tests_istio

gencheck_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test gencheck_istio

integ-helm-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-helm-tests_istio

analyze-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test analyze-tests_istio

integ-telemetry-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-ipv6-k8s-tests_istio

lint_istio
fb3c86095191a1c4d9dd533d082a803b38603e87
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-mc-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-multicluster-tests_istio

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

integ-pilot-multicluster-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-multicluster-tests_istio

integ-cni-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-cni-k8s-tests_istio

integ-security-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-k8s-tests_istio

integ-helm-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-helm-tests_istio

analyze-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test analyze-tests_istio

integ-telemetry-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-ipv6-k8s-tests_istio

lint_istio
fb3c86095191a1c4d9dd533d082a803b38603e87
link
/test lint_istio

unit-tests_istio
fb3c86095191a1c4d9dd533d082a803b38603e87
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

integ-cni-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-cni-k8s-tests_istio

integ-security-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
fb3c86095191a1c4d9dd533d082a803b38603e87
link
/test unit-tests_istio

lint_istio
3696f59aa7c76bb181929f7f3f7f89ce0558b4f9
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rinormaloku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test release-test_istio

integ-cni-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-cni-k8s-tests_istio

integ-security-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1957f94c307bf4ead993c261a2490f913eb01275
link
/test integ-telemetry-k8s-tests_istio

lint_istio
3696f59aa7c76bb181929f7f3f7f89ce0558b4f9
link
/test lint_istio

unit-tests_istio
3696f59aa7c76bb181929f7f3f7f89ce0558b4f9
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

btw @howardjohn thinking about this, does it make more sense to have these flags:
--workloadIP and
--probe-on-localhost
?
I.e. workloadIP configures the IP that the workload uses to auto register and for health checks,
Meanwhile --probe-on-localhost overwrites so that the health check is performed on localhost for apps bound to it. (I think the --internal-ip and --external-ip might confuse users)

Meanwhile --probe-on-localhost overwrites so that the health check is performed on localhost for apps bound to it. (I think the --internal-ip and --external-ip might confuse users)

idk, personally I think --probe-on-localhost is more confusing to users (then again, I am not a user :slightly_smiling_face: ). It specifies what we want to do, but a user needs to know why they want to do that - I doubt anyone will know that unless they get a broken VM and stumble upon this PR/issue?
Whereas with external/internal, they will see both flags and realize they need to decide which their IP is. Under the hood we make it work - which could be through different means in the future.

Makes sense...
So, I am asking as I don't know the implementation details and what I am
not sure is:
Do we want to always set  REWRITE_PROBE_LEGACY_LOCALHOST_DESTINATION to
true when we have an external IP?
If yes then the current implementation is good :))
On Tue, Aug 3, 2021, 16:54 John Howard @.***> wrote:

Meanwhile --probe-on-localhost overwrites so that the health check is
performed on localhost for apps bound to it. (I think the --internal-ip and
--external-ip might confuse users)
idk, personally I think --probe-on-localhost is more confusing to users
(then again, I am not a user 🙂 ). It specifies what we want to do, but a
user needs to know why they want to do that - I doubt anyone will know
that unless they get a broken VM and stumble upon this PR/issue?
Whereas with external/internal, they will see both flags and realize they
need to decide which their IP is. Under the hood we make it work - which
could be through different means in the future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/34411#issuecomment-891914184, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACE3XE7MXGG2RF43KWGYPR3T277ITANCNFSM5BGMEANQ
.

Today we do. Maybe in the future we have a better solution
On Tue, Aug 3, 2021 at 8:05 AM Rinor Maloku @.***>
wrote:

Makes sense...
So, I am asking as I don't know the implementation details and what I am
not sure is:
Do we want to always set REWRITE_PROBE_LEGACY_LOCALHOST_DESTINATION to
true when we have an external IP?
If yes then the current implementation is good :))
On Tue, Aug 3, 2021, 16:54 John Howard @.***> wrote:

Meanwhile --probe-on-localhost overwrites so that the health check is
performed on localhost for apps bound to it. (I think the --internal-ip
and
--external-ip might confuse users)
idk, personally I think --probe-on-localhost is more confusing to users
(then again, I am not a user 🙂 ). It specifies what we want to do, but a
user needs to know why they want to do that - I doubt anyone will know
that unless they get a broken VM and stumble upon this PR/issue?
Whereas with external/internal, they will see both flags and realize they
need to decide which their IP is. Under the hood we make it work - which
could be through different means in the future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/34411#issuecomment-891914184, or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ACE3XE7MXGG2RF43KWGYPR3T277ITANCNFSM5BGMEANQ
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/34411#issuecomment-891923831, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXMYAUR33NHIBHQ53S3T3AAU3ANCNFSM5BGMEANQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

@howardjohn do we want to /cherrypick release-1.11 this change?

hm, it was supposed to.. from the label
/cherrypick release-1.11

@howardjohn: new pull request created: #34563

In response to this:

hm, it was supposed to.. from the label
/cherrypick release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Migrate tutorial to use the quarto framework

This PR aims to move the kornia tutorials to use the quarto framework instead of sphinx to generate the tutorials webpage.
You can check out this change on the deployed version on my gh page: https://johnnv1.github.io/tutorials/

Main page

Main dark

tutorial page

tutorial page code

tutorial page dark

Improvements

The tutorials page will look like blog posts

With date, authors, thumbnails, etc

Tags system!!!

We can add categories into each tutorial, which allow the users to filter the tutorials

better search engine
new UI
order by

What changed with this

readthedocs.org/ didn't support quarto so, we will need to move to use GitHub pages (TODO: need to configure the kornia/tutorials to publish the gh-pages from the branch gh-pages)

Migrate from https://kornia-tutorials.readthedocs.io/ to https://kornia.github.io/tutorials/

Instead of using the sphinx we need to setup the https://quarto.org/docs/get-started/

to mitigate the breaking changes, I added a make setup and make setup-quarto to help installing the dependencies

This command just works for linux -- the quarto is a binary and not a python package! To setup it up into another OS please check out the quarto documentation.

The UI/theme isn't the same from the main docs -- but we update it to look like it

What has been done

[x] Minimal setup using Quarto

[x] Delete sphinx and myst-st configs files
[x] Initial configuration of Quarto (_quarto.yml)
[x] Index page: A temporary page in a "blog posts listing" style before #45 be done.

Should list our tutorials

Option for filtering, ordering and search
Tag!!! Be able to add categories "tags" into our tutorials, to be easy to navigate.

[x] Update the Makefile

Update the generate command to convert inplace the notebooks: Just to check if they are a valid jupyter notebook.
Update the execute command to execute inplace the notebooks.
Update the setup command

Added a setup-quarto: Which will works just on linux machine. This command directly download the binary of quar»
Update the command to after pip install the dependencies execute setup-quarto

Added preview command to execute the quarto preview to test locally the webpages. Use this command to develop locally it's easily to debug with it!!
Added render command to build the webpages.

[x] Added a CI to deploy the quarto build into GH pages!

[x] Customize the theme to look like the main documentation (furo theme for sphinx)
[x] Add a basic front matter into each tutorial! And update the "open in colab" badge to be a HTML tag instead of the markdow»
[x] Add/generate a thumbnail and add it into the front matter for each tutorial!

LGTM. Is it possible to have sub-categories for a better organization of the right-side area?


lib: posix: Make sure the name string is NULL terminated

Make sure the name string is NULL terminated in the readdir().
CID: 186037
Fixes Issue #7733
Signed-off-by: Ramakrishna Pallala<EMAIL_ADDRESS>

Codecov Report

Merging #7985 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7985      +/-   ##
==========================================
+ Coverage   55.03%   55.04%   +<.01%
==========================================
  Files         481      481
  Lines       53936    53937       +1
  Branches    10474    10474
==========================================
+ Hits        29686    29687       +1
  Misses      19981    19981
  Partials     4269     4269

Impacted Files
Coverage Δ

lib/posix/fs.c
48.29% <100%> (+0.35%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5405f68...593878a. Read the comment docs.

@lpereira I have updated the PR. Please have a look.

@lpereira are you ok with that?


Option to disable UPPERCASE SQL statement

Hi, this extension is great for VSCode, thanks! For SQL, is it possible to add a setting to disable the highlighting on UPPERCASE statements? I often read existing code with embedded SQL that does not have semicolon endings. For these cases, the highlighting will be incorrect for the rest of the code. Python example below.
print(2) # Highlighted correctly

query = """
SELECT *
FROM db.tbl
"""

print(2) # Not highlighted correctly

Hi @bscan,
This extension implements the highlighting by syntax highlight method , which means there is only a JSON config for highlight rules, and any function of setting should be implemented in TS or JS. So currently, any rule cannot be disabled by settings.
There is a manual way to disable it:

locate to the extension install folder in your computer.
delete highlighted part of the following picture in syntaxes/highlight-string-code.json.

reload this extension or restart VSCode to make it work.

Also, I have an idea to modify the rule JSON config by a TS/JS script, but I am not sure if it can work. Please excuse me for the slow development, because my current work has less relation with SQL or other embedded languages.

The SQL uppercase rule is triggered by any match, even if the keyword is in the middle of another word.  Additionally, the text must include a ; semicolon for the matching to end.
(Example using PowerShell, where I encountered the issue, but it should affect any language)

While the SQL keyword matching is useful for inline text it is more likely to cause problems than solve them as implemented.
At the very least, the SQL keyword rule regex should match if the keyword is preceded by a word boundary metacharacter - this would fix issues where the keyword appears at the end of another word in a non-SQL statement.  However, this is only an edge case.
For best experience, the SQL keyword rule should be removed completely.  SQL syntax highlighting can still be achieved using multiline text with --beginsql / --endsql comments.

The SQL uppercase rule is triggered by any match, even if the keyword is in the middle of another word. Additionally, the text must include a ; semicolon for the matching to end.
(Example using PowerShell, where I encountered the issue, but it should affect any language)

While the SQL keyword matching is useful for inline text it is more likely to cause problems than solve them as implemented.
At the very least, the SQL keyword rule regex should match if the keyword is preceded by a word boundary metacharacter - this would fix issues where the keyword appears at the end of another word in a non-SQL statement. However, this is only an edge case.
For best experience, the SQL keyword rule should be removed completely. SQL syntax highlighting can still be achieved using multiline text with --beginsql / --endsql comments.

In my view, adding a ; is much easier than multiline text to highlight a sql.
If you prefer to disable this feature, the above response can help.

In my view, adding a ; is much easier than multiline text to highlight a sql.

In case there is a misunderstanding - adding a ; cannot not fix this issue, since the code is not even SQL.  None of the code shown is SQL yet the extension highlights it anyway.

In my view, adding a ; is much easier than multiline text to highlight a sql.

In case there is a misunderstanding - adding a ; cannot not fix this issue, since the code is not even SQL. None of the code shown is SQL yet the extension highlights it anyway.

I understand. I was just explaining why I added the SQL keyword rule. Due to the limitations mentioned in #6, this is the best compromise I can offer. Different people have their own requirements, so I recommend editing the syntaxes to solve your problem.


Better: Add documentation about Huawei Push Notifications for Engage Messaging. RD-18728

Hey!
Ticket(s):
RD-18728
Change(s):

Add documentation about the Huawei Push Notifications configuration for Engage Digital Messaging channel

LGTM

merged manually


trying to deploy and get maximum call stack error

Describe the bug
A clear and concise description of what the bug is.
RangeError: Maximum call stack size exceeded
at Array.values ()
at recurseDependencies (/.../packages/contracts/node_modules/hardhat-deploy/src/DeploymentsManager.ts:1168:45)
at recurseDependencies (/.../packages/contracts/node_modules/hardhat-deploy/src/DeploymentsManager.ts:1172:15)
at recurseDependencies (/.../packages/contracts/node_modules/hardhat-deploy/src/DeploymentsManager.ts:1172:15)
at recurseDependencies (/.../packages/contracts/node_modules/hardhat-deploy/src/
...
To Reproduce
Steps to reproduce the behavior:
run 'deploy' with many contracts
Expected behavior
no error
versions

hardhat-deploy v 0.11.34
hardhat  v2.16.1
nodejs  v16

Additional context

had infinite dependency loop


Natural functions for Map

We have a series of helper functions for Lists that work with Naturals over Ints, could we get this for Maps?
The pattern of functions like Map.take . fromInteger . natToInteger gets a little cumbersome

What kind of Maps are these @samuelWilliams99? Plutus ones, or some other kind?
Is there a list of functions you would like?

Data.Map or PlutusTx.AssociativeMap, or both.
And I'm thinking functions like
take, drop, size
Nothing too involved

Maybe it's better to generalize these functions to work on any Witherable, at least off-chain.
https://hackage.haskell.org/package/witherable-0.4.2/docs/Data-Witherable.html#t:Witherable

I agree with @blamario for the off-chain part at least. For on-chain with AssocMap, I'll come up with a list.

If the off-chain part is for all Witherables then it may make sense for them to be put in plutus-list, but not quite so for AssocMap-specialized on-chain code. @kozross do you think we should create another package for it?

I tried to implement take and drop for Witherable:
takeW :: Witherable t => Int -> t a -> t a
takeW n = flip evalState 1 . wither (\x ->
  state $ \s -> (if s > n then Nothing else Just x, succ s))

dropW :: Witherable t => Int -> t a -> t a
dropW n = flip evalState 0 . wither (\x ->
  state $ \s -> (if s < n then Nothing else Just x, succ s))

The efficiency will be O(length) which is not very desirable. length for Foldables are already in plutus-list.

@re-xyr I think we might want to rename plutus-list to plutus-collection. That way, we can put all collection-related code in there, regardless of what collection(s) it's usable for or with.
Regarding efficiency for Witherable: @blamario and @samuelWilliams99 can have the final call, but I suspect this should use specialized versions for now, since we only need it to generalize to like, two kinds of collection?

@re-xyr Sorry this list took a while. I think we need AssocMap versions of take, drop and splitAt, since they're the only functions that take numeric arguments related to length. They should also be possible for any Witherable for offchain use. Does this meet your criteria @samuelWilliams99?

Absolutely! Just to clarify, we'll have those functions inlinable specialise for onchain, then just do instances of Witherable for offchain?

I think off-chain code does not use PlutusTx typeclasses or types, so there isn't much point in defining take and drop for Natural. @kozross what do you think?

We do use Naturals offchain, for both plutustx types like AssocMap, and non plutustx types like simply Map

@samuelWilliams99 is right - we use values of plutus-numeric types off-chain fairly regularly in several projects.


[FR] add support for ctrl-shift-[*]

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues -> example

Feature Request
At the moment in version 0.30.0 (latest) under the "AVAILABLE KEYS" section of the manpage there are many options listed (including shift-[arrows], ctrl-alt-[a-z], alt-shift-[arrows], alt-[*] which is case sensitive), but I couldn't manage to find an answer for why, ctrl-shift-[*] is not accepted (perhaps not implemented). For example:
❯ fzf --bind='ctrl-shift-n:half-page-down'
unsupported key: ctrl-shift-n

It would be super nice and handy if we can either have ctrl-shift-[*] or at least ctrl-[a-zA-Z].
Thanks for this amazing software. It has really improved my workflow.

Terminals can't differentiate between ctrl-shift-* and ctrl-*; they register identical byte sequences. This is a small Ruby code that confirms that.
#!/usr/bin/env ruby
# frozen_string_literal: true

require 'io/console'

$stdout.sync = true

printf("\e[?1000h\e[?1006h")
loop do
  chars = $stdin.getch + ($stdin.read_nonblock(1024) rescue '')
  break if [3, 4, 26].map(&:chr).include?(chars)

  p chars
end

FYI, I have found this to not be true. For example, open nvim (I'm using iTerm2 to run it), and in insert mode:

press Ctrl-V, then press Alt-Shift-R - nvim will show <M-R>
press Ctrl-V, then press Alt-R - nvim will show <M-r>

Notice that the r and R in those outputs are different. Neovim is able to pick up the difference.
It's possible different terminal emulators support this differently and I understand the complexity that creates. However, this seems useful despite that complexity. It opens up more flexibility in fzf and enables better key-bindings when the relationship between a shifted and non-shifted key-stroke makes sense.

I don't want to necro, but I also don't want to dupe. I'll try here, before creating a new issue duplicating this one.

Terminals can't differentiate between ctrl-shift-* and ctrl-*; they register identical byte sequences. This is a small Ruby code that confirms that.

I don't mean to argue, but my terminal (KDE's Konsole) does, and most of the big ones (kitty, wezterm, gnome, xterm, etc, etc) do these days. I hope you'll reconsider the 'wontfix' response to this.
Here, I run your code, and press enter, shift+enter, ctrl+enter, etc, to demonstrate that nearly all combinations are functional.
> ./test.ruby
"\r"
"\e[13;2u"
"\e[13;5u"
"\e[13;1u"
"\e[13;3u"
"\e[13;6u"
"\e[13;4u"
"\e[13;7u"
"\e[13;8u"
"\r"

This is the behaviour described by the following proposals:
https://sw.kovidgoyal.net/kitty/keyboard-protocol
http://www.leonerd.org.uk/hacks/fixterms/
The former link is more recent and discusses the latter. I hope that will be helpful, and one day I can use ctrl+enter/shift+enter in fzf like I am enjoying elsewhere in the terminal. If I can assist in any way, please do let me know :)

Please consider reopening the issue @junegunn


[core] Close fetch / fetchSeries spans

LGTM. What are the throws Exception moves about - just fixing compiler warnings?

LGTM. What are the throws Exception moves about - just fixing compiler warnings?

Yes indeed :)
Going to add some more changes to this PR after I continue troubleshooting.


Xenomai kernel issue on Arrow BeagleBone Black

Hello,
I am having an issue booting a Xenomai Linux kernel on an industrial temperature rated BeagleBone Black I purchased from Arrow electronics.
I’m not sure where’s the best place to post, but I am posting to the omap-image-builder project because the issue applies to both the eMMC image detailed below and @machinekit’s bone-debian-8.5-machinekit-armhf-2016-06-19-4gb.img.xz image on an SD card.
The following is a description of the problem.  I can flash a minimal Debian image to the eMMC with the following steps:

wget https://rcn-ee.com/rootfs/2016-06-09/flasher/BBB-eMMC-flasher-debian-8.5-console-armhf-2016-06-09-2gb.img.xz
xzcat BBB-eMMC-flasher-debian-8.5-console-armhf-2016-06-09-2gb.img.xz | sudo dd of=/dev/sdX
Hold down the button near SD card until "Cylon" lights start.
Once the lights go out, power off the unit, remove the SD card, and power it back on.

After power cycling, the unit boots as expected.  However, the system hangs on boot when I try the following additional steps:

sudo apt-get update
sudo apt-get install -y linux-image-3.8.13-xenomai-r79 linux-headers-3.8.13-xenomai-r79 linux-firmware-image-3.8.13-xenomai-r79
sudo reboot
The system hangs with all four user LEDs lit and nothing shown over HDMI.

As mentioned earlier, the same issue happens if I try the recent @machinekit bone-debian-8.5-machinekit-armhf-2016-06-19-4gb.img.xz image on an SD card.  On a regular BeagleBone Black the above steps work flawlessly and Xenomai functions great in all the benchmarks I’ve thrown at it.
Does anyone have any suggestions for how to fix this?  Also, once fixed, what tests would you recommend to be reasonably assured the Xenomai image is stable on this Arrow board?
I don’t have a TTL UART adapter handy, but I can try to get one tomorrow to see if more debug information can be gleaned from the boot loader.
Thanks.
-Adam
P.S. Thank you so much @RobertCNelson for providing a packaged Xenomai kernel.  It really makes Xenomai so much more accessible by avoiding the dance with multiple patches, “well aged” kernel commits, and reading up on old blog posts just to get it going.  I greatly appreciate it.

@subspclr4 So the problem with the Arrow board, they swapped out the NXP based HDMI framer for an Analog Devices unit.  The Analog Devices patches where written for v4.1.x:
https://github.com/RobertCNelson/ti-linux-kernel-dev/tree/ti-linux-4.1.y/patches/beaglebone/abbbi
With some work, these could be back-ported to our 3.8.13 based kernel.
Regards,

@RobertCNelson Thank you for the quick reply.
That is unfortunate to hear about the HDMI framer.  Is it possible adjust the Device Tree to disable / workaround this HDMI conflict?  For my application I believe (based on this post) that I need to disable HDMI anyway since it's muxed with the extra encoder pins I'm looking to use.
I agree those patches could be back ported, but I unfortunately don't have the bandwidth to do that right now given other project deliverables.  I'd also greatly prefer to to stick with a well-tested kernel like the packaged one you kindly offer.

@subspclr4 It is indeed possible to cut it out of the device tree and run with a 3.8 kernel. Did you figure it out?

@jadonk No, not yet, but that's mainly because I haven't made it a priority given other project deliverables.  My first pass at adding cape_disable=capemgr.disable_partno=BB-BONELT-HDMI,BB-BONELT-HDMIN to uEnv.txt worked as expected on an ordinary BeagleBone Black with the 3.8.13 Xenomai kernel, but didn't solve the problem on the Arrow board with the same kernel.
My next thoughts were to try recompiling:

The base Device Tree blob without HDMI instead of using a capemgr overlay.
The Xenomai kernel without HDMI support.

Is there anything else you'd recommend I try?

Matt Porter at Konsulko might have a good suggestion.

We just ran into this. Have a deadline to ship units and couldn't source the Element14 board. We're running 3.8.13. I'd prefer not to have to have to two SD cards for production. Do we think that removing HDMI from the device tree would work on both boards?

@razed11 the hdmi encoder is the only difference, if your not using video, just remove it.

Sorry @RobertCNelson: Remove it in what way? Do I find the source for one of these and rebuild?

@razed11 use https://github.com/RobertCNelson/yakbuild
use the "recipe.sh.v3.8.x.sample" sample
then change kernel_tag="3.8.13-bone86" -> kernel_tag="3.8.13-bone62"
You'll find the hdmi cape under /firmware/capes/ or similar and nuke the file and the reference in teh same dir's makefile..
Regards,

Is found an included dtsi. Remove these and rebuild?

yeap

@RobertCNelson Not much luck so far. I used yakbuild (which I used successfully in the past to increase the SPI buffer size). I removed the HDMI dts files from KERNEL/firmware/capes. There is no makefile in that directory but I removed the reference in KERNEL/firmware/Makefile. Using dtc to convert it back to dts I get:


Bump version to 0.8.0.dev2

Bumps the version to 0.8.0.dev2. This is a pre-release, so pip will ignore it by default (https://pip.pypa.io/en/stable/cli/pip_install/#pre-release-versions).

I'll wait until #123 is merged!

Just merged!


Offtopic: VIO algorithm info of T265

Hi,
this might be a little bit off-topic but I'm interested in details about the vslam/VIO algorithm inside the T265. I found this site (here), but it's just about the basic and not e.g. which feature detection/classifier has been used. Do you know where I can further information/paper on this?
Thanks and best regards

Thanks for your interest. Unfortunately we are not really releasing any more details on our exact approach at this time. I hope you understand.


Render only visible items on the map

Implemented rendering only visible items on the map(issue #82 )
Added VisibleClusteringDemoActivity activity which demonstrates clustering of 20k items.

@broady or @markmcd could you rerun this build on Travis?  The initial build failed with com.android.ddmlib.ShellCommandUnresponsiveException, which isn't related to the PR contents.

Thanks, looks like the Travis build passed now.  I've been seeing occasional failures due to com.android.ddmlib.ShellCommandUnresponsiveException on Travis builds on other projects too.  Increasing the timeout doesn't seem to help, so right now unfortunately the workaround is just to poke Travis again, and it usually passes on the second attempt.

+1 for merge

+1

Mark or @jfschmakeit can you look at this more closely?

Awesome - thanks for this contribution. It's looking great on the device. Just a couple of comments around the code.
Oh and I'll re-run the Travis builds when needed, they're very flaky at the moment.

FYI - looks like the Travis timeout issue should hopefully be fixed in 2.0.0-beta3 - see https://code.google.com/p/android/issues/detail?id=189764#c17 for details.

I think the getVisibleBounds() method in the VisibleNonHierarchicalDistanceBasedAlgorithm class not working correctly. On bigger screens the bounds not matching to the screen and the displayed area with markers is more bigger. I've tried to fix it with getVisibleRegion() method and calculation, but if user rotate the map, this solution is not working :)
Do you have any idea?

What screen size/dimension do you use?
Also, if  you rotate the map, you have to recluster everything.
There is updateViewSize() method in the latest update, call it with the new map size and recluster it.

I've checked with a 480x800 and a 1920x1080 resolution.
Now, I've solved with this code:
`private Bounds getVisibleBounds(int zoom) {
Log.i("TAG", "mapWidth: " + zoom);
if (mMapCenter == null) {
return new Bounds(0, 0, 0, 0);
}
    Point p = PROJECTION.toPoint(mMapCenter);
    Point left = PROJECTION.toPoint(this.left);
    Point right = PROJECTION.toPoint(this.right);

    return new Bounds(Math.min(left.x, right.x), Math.max(left.x, right.x),
            Math.min(left.y, right.y), Math.max(left.y, right.y));
}

private LatLng left;
private LatLng right;

@Override
public void onCameraChange(CameraPosition cameraPosition) {
    VisibleRegion visibleRegion = map.getProjection().getVisibleRegion();
    mMapCenter = cameraPosition.target;
    left = visibleRegion.farLeft;
    right = visibleRegion.nearRight;
}`

I believe you use too old code. I don't use map bounds anymore. Please, pull the latest version of the patch

Okey, thank you!

Any idea when this is gonna be merged?

Is it a part of the plan to integrate / merge this functionality?

I am just trying to keep it up to date

Is there any reason not to merge this? (besides perhaps squashing commits)

Commits will be squashed by merge, isn't it?

Someone with merge rights could, indeed.

@googlebot I consent to have my commit merged to this project. Looking forward to having this pull request as well as my other two that are pending merged into the base project.

@zamesilyasa I noticed that NonHierarchicalViewBasedAlgorithm.shouldReclusterOnMapMovement() always return true, causing recluster on map movement even if it is just centering at selected cluster.
So when user taps at cluster to see info window it is shown only for a second, then disappear.

@b1n0m13
I had this problem before, but I solved it with custom popup windows. I had a view on top of the map, which showed popup windows. It was not hard to implement, because map is centered after click. So just show a popup at the center of a layout.

always return true
That's the core idea of the algorithm - recluster on map movement.

If you will disable this in case popup is shown and scroll the map, you will see an empty square of the map, what breaks consistency between visual representation and data set

@markmcd
Is there any chance to merge it into dev?

Will this be merged with main code?

This is merged now, thanks all.

Is there any plan to release this as part of next release? Managing gradle dependencies are much easier than moving the aar in multiple project.

I also want to use this feature in my project with gradle dependencies. Please release it !

+1 Would love this

Could someone tell me how I can add this to my project? I am looking for an .aar or .jar file to be to use this new feature as it's still not part of a new release


Add support for TLS connection strings

Signed-off-by: Daniel Guidry<EMAIL_ADDRESS>This will additionally match tls:// and include it in the first capture group (containing the host string), if found.
I have tested this against live Redis servers using both tcp:// and tls:// connection strings and have tested the pattern itself against various strings.
Issue #5982 has details.

Sorry for the long delay and thank you for your contribution. It's been quite awhile and I wanted to alter your patch a bit, so I just went ahead with it myself - see the linked commit.
On another note, if you want to contribute code again, you don't need to create an issue just to link a PR to it - a pull request can serve as an issue by itself.

Sorry for the long delay and thank you for your contribution. It's been quite awhile and I wanted to alter your patch a bit, so I just went ahead with it myself - see the linked commit.
On another note, if you want to contribute code again, you don't need to create an issue just to link a PR to it - a pull request can serve as an issue by itself.


To provide options to user whether they want to log their keypresses or not - and if yes, then how?

Provide these options:

do not log anything
log on the command prompt but not in the execution.log file
log in the execution.log file but not on the command prompt
log at both the places

@hetulbhatt can you please explain the requirements more?

You can pick up the spike if you want to.


Invalid link on support page

The support page, in section Community meetings/meetups contains a link to "list of .NET meetup groups on Twitter", which points to https://twitter.com/DotNet/dotnet-user-groups. But that page does not exist.

@terrajobst do you know what is the right URL if we still have this?

@blackdwarf can we remove that link?

It seems the link was fixed, it now points to https://twitter.com/dotnet/lists/net-user-groups, which works.


License issue of superpoint + LightGlue onnx

Hi, your work is really great and helpful. Thank for your effort to maintain this repo. I wonder if Superpoint+LightGlue onnx have any issues of license for commercial use ?

Hi @QuanNguyen94 , thank you for your interest in LightGlue-ONNX!
This fork inherits the original repository's license (Apache License, Version 2.0).

Is it not infringe copyright of Superpoint of MagicLeap ? https://github.com/magicleap/SuperPointPretrainedNetwork/blob/master/LICENSE

You could try opening an issue in the original LightGlue repository. I'm not a legal expert.


fix(pkg/driverbuilder): rocky release urls

Break out the vault releases from the mainstream releases, and append them all to the url list

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area pkg
What this PR does / why we need it:
Rocky Linux uses two different areas for their packages based on whether its a current release version or a previous.  The previous ones are put at a vault url, so the update was required to add a separate list of vault releases to support when looking for the urls to find the kernel-devel package.
Which issue(s) this PR fixes:
Fixes #245
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

e37b913 fix(pkg/driverbuilder): rocky release urls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jgornowich
Once this PR has been reviewed and has the lgtm label, please assign fededp for approval by writing /assign @fededp in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @jgornowich! It looks like this is your first PR to falcosecurity/driverkit 🎉

Hi! Thanks for the PR!
You need to add DCO to the commit. It is done using the "-s" git flag when committing, or manually adding "Signed-off-by name " line as last line of the commit message.
A quick rebase/amend of the commit should do the trick ;)
For more info, see https://github.com/falcosecurity/.github/blob/main/CONTRIBUTING.md#developer-certificate-of-origin

DCO added

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, jgornowich
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 04513bf7503ca768d28960ef6baa846db948af40


V2.2.0 tests

@ksubryan have these been integrated into the 10.10 branch? If so will remove this pull request.


Fix BZ1467852 add ENV HOME to Dockerfile

@eriknelson Yes. Should I do a separate PR or will it get merged forward?

@jmontleon yeah I think we just need another PR against master and maybe reference this one.


create a test project

And add some missing codes.
Didn't copy to main.yml because that's completely different.
Use Microsoft.AspNetCore.Mvc.Testing:

https://www.claudiobernasconi.ch/2022/03/03/integration-testing-asp-net-core-6-webapi-applications/
~~https://adamstorr.azurewebsites.net/blog/integration-testing-with-aspnetcore-3-1~~

closed in favor of upstream 119


corne-classic .svg files are wrong size

Problem: .svg files from the master branch located in the corne-classic/case folder are incorrect size (scaled down).
I've detected the issue in the corne-classic-tent.svg and corne-classic.svg files.
Resulting in too tiny case plates from the lasercutter when using the .svg files included.
Note: The .ai files do look to be the right scale, however my crkbd kit is still in transit therefore I am unable to verify their scale correctness. They look good to the eye, where the .svg certainly do not.
Image below will illustrate the issue, on the left the .svg file on the right the .ai file (both loaded without modification into Inkscape)

Thanks for your feedback. I'll fix svg files.

Where I can find this svg files? Thanks you!! (:


heron side containers

This is a rough draft to gather feedback.

@moomou - any update on this?

Sorry about the confusion, I opened this with the idea of gathering feedback, but I suppose it wasn't clear what I was asking for.
Basically,

Is the location where I am putting these files good? I am proposing (with this PR) to make heron/config/src/yaml/conf/k8s/ for all k8s related things sans source code (ie scripts, configs, etc)
Is the choice of zookeeper image acceptable (https://github.com/fabric8io/fabric8-zookeeper-docker)?

If there are no major objections, I consider this PR to be basically done. Just need to integrate it when a kubernetes controller is ready.

@moomou could you please provide some more context as to what this PR and the files included. Things like a description for this PR (what's a side container?), a README, comments on the python code, etc would all be helpful.
Also better to use kubernetes as the directory name than k8s.


FAB-17456 fabric-samples - pre-read ccp

Applications must pass an 'Common Connection Profile' object
to the Gateway as of v2. NodeSDK should not have access to the
file system.
Signed-off-by: Bret Harrison<EMAIL_ADDRESS>

using https://github.com/hyperledger/fabric-samples/pull/117 instead


[WIP] Simplify KAK decomposition

Summary
Attempting to simplify and speed up KAK decomposition.
Details and comments

I'm interested to see if you can make the Childs et al method work. I was able to get the Weyl coordinates, but I couldn't get the full corresponding KAK decomposition.

Closing this to add it to #2539 as I can check the validity of the Weyl values using the local invariant coordinates.


Further improve upload performance

This PR continues the work done in #73 and further improves the upload performance drastically by creating multiple connections to the telegram servers. (Upload of a 23MB takes now ~1100ms (before ~2700-3000ms) on a 1Gbit/s connection)

wow. WOW :o

[*]


kluctl: 2.22.1 -> 2.25.0

Description of changes
Changelogs:

https://github.com/kluctl/kluctl/releases/tag/v2.23.0
https://github.com/kluctl/kluctl/releases/tag/v2.23.1
https://github.com/kluctl/kluctl/releases/tag/v2.23.2
https://github.com/kluctl/kluctl/releases/tag/v2.23.3
https://github.com/kluctl/kluctl/releases/tag/v2.23.4
https://github.com/kluctl/kluctl/releases/tag/v2.23.5
https://github.com/kluctl/kluctl/releases/tag/v2.24.0
https://github.com/kluctl/kluctl/releases/tag/v2.24.1
https://github.com/kluctl/kluctl/releases/tag/v2.25.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Should I add a notice about the breaking changes to the release notes?

Did some further testing locally and I'm getting issues involving an unpatched python3 executable, do not merge this.

Latest version has made it possible to repack the Python executables and patch them. I've been able to build working versions of kluctl, but am currently trying to fix an issue with the vendorHash not being static.

Latest version has made it possible to repack the Python executables and patch them.

Good news

It seems the reproducibility issues may have been related to my usage of mktemp (seems obvious in hindsight...). Removing it seems to result in a consistent vendorHash. I'd appreciate some testing for if this is actually the case and if kluctl works as intended, and I'm also not sure if my modPostBuild shenanigans are acceptable, they seem unprecedented in this repo.

The plot thickens. I just rebased on latest master, and the vendorHash changed. But subsequent builds still show the hash being static. Just as a sanity check, this is what I've tried to confirm that it is static:

I ran nix-collect-garbage -d with and without sudo
I ran nix-build -A kluctl and watched the whole build process including the vendor step.
I ran nix-build -A kluctl --check, which finished successfully.
I swapped one character in the vendorHash and rebuilt kluctl and its modules again, and the build failed with a mismatched vendorHash, showing the original hash that differs by one char as the expected one.
This process showed differences earlier when I still used mktemp, but now it does not.

Looking at CI again, it does seem like x64 Linux is building successfully! So the hash is platform-specific...
I'll rent out an arm64 VPS to do comparisons next week.

https://github.com/kluctl/kluctl/pull/1099 was just merged, meaning I can remove the go-embed-python hack and simplify the build again. I've tested it with kluctl master and it seems to work perfectly.
Once a stable version containing that PR gets released I'll update the commit accordingly and finally move this PR out of draft.

The PR is now ready for review/merging; cc @sikmir

Result of nixpkgs-review pr 280260 run on x86_64-darwin 1

1 package built:

kluctl

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/1016/158

@sikmir Are you able to merge this or is something blocking it?

CI is unhappy on x86_64-darwin as far as I see

@ofborg build kluctl

Had to rebase on master due to conflicts

Result of nixpkgs-review pr 280260 run on x86_64-darwin 1

1 package built:

kluctl

Added the requested changes. I've also pinned Python to 3.10 as this is the version kluctl embeds by default and I noticed some deprecation warnings popping up with 3.11.


All commands fail when  slash character is present at the end of host name

For example:
$ export PAPERMERGE_CLI__HOST=http://papermerge.local/
$ export PAPERMERGE_CLI__TOKEN=e4e9206c6f2b2.. balh ..a0b9eefd28dba

Notice the slash / at the end of host name. Now if I invoke list command for example:
 $ papermerge-cli list

The result is:
Traceback (most recent call last):
  File "/home/eugen/.local/bin/papermerge-cli", line 8, in <module>
    sys.exit(cli())
  File "/home/eugen/.local/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/eugen/.local/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/eugen/.local/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/eugen/.local/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/eugen/.local/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/eugen/.local/lib/python3.10/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/eugen/.local/lib/python3.10/site-packages/papermerge_cli/main.py", line 100, in _list
    perform_list(
  File "/home/eugen/.local/lib/python3.10/site-packages/papermerge_cli/rest.py", line 135, in perform_list
    response = api_instance.users_me_retrieve()
  File "/home/eugen/.local/lib/python3.10/site-packages/papermerge_restapi_client/paths/api_users_me_/get.py", line 124, in users_me_retrieve
    return self._users_me_retrieve_oapg(
  File "/home/eugen/.local/lib/python3.10/site-packages/papermerge_restapi_client/paths/api_users_me_/get.py", line 101, in _users_me_retrieve_oapg
    api_response = response_for_status.deserialize(response, self.api_client.configuration)
  File "/home/eugen/.local/lib/python3.10/site-packages/papermerge_restapi_client/api_client.py", line 922, in deserialize
    raise ApiValueError(
papermerge_restapi_client.exceptions.ApiValueError: Invalid content_type returned. Content_type='text/html' was returned when only {'application/vnd.api+json'} are defined for status_code=200

It is expected that commands (e.g. list) will work when slash character is present at the end of the host name.

https://github.com/papermerge/papermerge-cli/pull/16


Support credentials objects for user-assigned Managed Identities

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
We were trying to use the new support that was added recently by microsoft to allow to use user-assigned managed identities for credentials for some data factory objects such as linked services for example, but when we tried to deploy that version that contained an autogenerated credential folder containing the related user assigned identity, the cmdlet threw an error inside the AdfObject.class.ps1 ADFT0029: Unknown object type: Credential.
Basically our linked service had a credential property inside its TypeProperties using a type CredentialReference
Describe the solution you'd like
A clear and concise description of what you want to happen.
It would be nice if that could be supported somehow.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
For now because of this restriction we were planning on still using plain connection strings with user and password for now, which we already handle through the csv substitution.
Additional context
Add any other context or screenshots about the feature request here.

Currently, Credentials are not supported by Az.DataFactory module. So, it is blocked by this.

Hi
are there any updates on this?  do we know when DataFactory module will include credentials and userAssignedIdentites?

Mentioned: https://twitter.com/NowinskiK/status/1502616575899324417

Hi,
It seems like the az module supports it now, I haven't tested the update part, but the needed parameters seem to be there. It would be nice to have support for managed identities in this module as well.

Hi. Same issue here. Can I help to fix it? Trying to understand... Should we only add 'credential' to $AllowedTypes in private\AdfObject.class.ps1 file to make it work or is there something else to change?

No, az.datafactory PS module still doesn't have the appropriate cmdlet to support this type of object.
I raised that to Microsoft yesterday.
Thanks for offering your help though, @Viguro79

Ok. Thanks. While waiting for an update on the Azure side, would it be possible to add an exception in the module to skip the credentials deployment? We deploy them at creation of the DataFactory with Terraform :

Something like :
if 'type' == 'credential'
   then # do nothing on this object
else validate_object() and deploy_object()

We have added the following line in the code to skip credentials objets :
In /azure.datafactory.tools/private/Get-ReferencedObjects.ps1, after line 11, add this condition : if ($type.Equals('CredentialReference')) { $script:ind--; return  }
    -and $node.PSobject.Properties.Name -contains 'type')
{
    [string] $type = $node.type
    if ($type.Equals('CredentialReference')) { $script:ind--; return }
    if ($type.EndsWith('Reference')) {
        $type = $type.Substring(0, $type.Length-9)
        #Write-Verbose "$type.$($node.referenceName)"

So that the module won't stop anymore on ADFT0029: Unknown object type: Credential error.
However, we are in a situation where we already manage credentials deployments via Terraform. So that the targeted DataFactory is still able to find a valid credential when deploying.

Hi @Viguro79, can you share some insights on how you manage credentials with Terraform? There doesn't seem to be a TF resource for the credentials object yet either. We are in a similar situation but unfortunately not in a position where we can make changes to the Powershell module, so this issue is currently blocking us from deploying ADF objects. If it were possible to do it with Terraform I could work with the azurerm_data_factory_*  resources but it would still need to deploy credential objects.

Sorry guys for the delay. This gonna be implemented today.

Hi @Viguro79, can you share some insights on how you manage credentials with Terraform?
We are using an ARM template to deploy it :

This is the arm template we use :
{
    "$schema": "http://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#",
    "contentVersion": "<IP_ADDRESS>",
    "parameters": {
        "factoryName": {
            "type": "string",
            "metadata": "Data Factory name"
        },
        "identId": {
            "type": "string",
            "metadata": "the managed identiry id"
        },
        "credName": {
            "type": "string",
            "metadata": "Credential name"
        }
    },
    "variables": {
        "factoryId": "[concat('Microsoft.DataFactory/factories/', parameters('factoryName'))]"
    },
    "resources": [
        {
            "name": "[concat(parameters('factoryName'), '/',parameters('credName'))]",
            "type": "Microsoft.DataFactory/factories/credentials",
            "apiVersion": "2018-06-01",
            "properties": {
                "type": "ManagedIdentity",
                "typeProperties": {
                    "resourceId": "[parameters('identId')]"
                }
            },
            "dependsOn": []
        }
    ]
}

And the terraform we use to deploy it in live mode :
resource "azurerm_resource_group_template_deployment" "rgp_cred" {
  name = "Credential_RGP"
  resource_group_name = var.rgp_name
  deployment_mode = "Incremental"
  template_content = file("${var.MODULE_FACTORY_DIR}/modules/datafactory/cred_arm-template/arm_template.json")
  # template_content = file("../datafactory/cred_arm-template/arm_template.json")
  parameters_content = jsonencode ({
    factoryName = {value = azurerm_data_factory.current.name}
    identId = {value = var.mgd_id_rgp}
    credName = {value = "cred-id-project"}
  })
  depends_on = [azurerm_data_factory.current]
}

Currently deployed on preview version: https://www.powershellgallery.com/packages/azure.datafactory.tools/0.98.0-preview Please check, test and let me know if that works as expected.

Better. But still an issue there :
STEP: Deployment of all ADF objects...
Start deploying object: [linkedService].[ls_adls_projectname] (2 dependency/ies)
Write-Error: /home/AzDevOps/.local/share/powershell/Modules/azure.datafactory.tools/0.98.0/private/Deploy-AdfObject.ps1:29
Line |
  29 |  …   $depobj = Get-AdfObjectByName -adf $adf -name "$name" -type "$type" …
     |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | ADFT0014: Type [Credential] is not supported.

Check the latest:
https://www.powershellgallery.com/packages/azure.datafactory.tools/0.99.0-preview

This one is working as excepted.

Released in ver.0.99


feat: qemu 6.x support

qemu 6.x support
go mod support

This merge request should be processed. This is the only thing that got it working on my Hackintosh.

@CandySunPlus thank you for contributing this, and sorry for not merging upstream before
Did the changes to go.mod and to qemu 6.2, but don't want to change the unit for "size"


Version 1.3 - revisions for journal

Major changes:

new function supporting seurat objects
new vignette on a ST dataset
new logic in download_profile_matrix
correction: use pnorm() instead of pt() when calculating p-values

merged offline for v1.3 release


Add retro-compatibility in entrypoint for older datadog.conf

datadog.conf layout was recently improved, making #100 necessary, but we still need to support older datadog.conf until https://github.com/DataDog/dd-agent/pull/2618 is released in version 5.9.0. This commit can be reverted once 5.9 is out.
Thank you @fotinakis for reporting this issue.

:shipit:


Wyrm Body and Tail Segments need to be added to layer 8

Done in Enemies Branch. Waiting for tonight to merge.


Task assumes large concourse workers

The task defaults to run across 12 nodes. This assumes a very large concourse worker. Our concourse workers are n1-standard-8s and fail CATs >90% by default use of this task. By scaling down to 9 nodes on our task against 6 n1-standard-8 workers, we get a significantly higher pass rate on CATs.
I would like to see documentation surrounding the need to configure number of nodes against an average machine size.

Hi @JohannaSmith. It looks like we're using n1-highcpu-16 for our concourse workers, which enables us to use 12 ginkgo nodes.
One thing that makes this a bit annoying is that there isn't really a notion of an "average" machine size -- plenty of teams using n1-standard-8, n1-standard-4, as well as various types in the n1-highcpu family. We can only hope to do a best effort in documenting the number of nodes to use for a given machine size. A simple way to do this might be to just ask teams that are already using the task for what they've found. For example, the README could include a table like this:

Num CPUs
GCP VM Type (as an example)
Recommended Gingko nodes

16
n1-highcpu-16
12

8
n1-highcpu-8
9

4
n1-highcpu-4
6

Does that seem like a reasonable way to document this?
Also, just in general, I'd recommend a different approach to Concourse workers. Instead of having many smaller workers, we've found that we prefer just a few larger workers -- partially so that we can run tests this way, but also because we've found that CPU is almost always the bottleneck resource (as opposed to memory) and we can optimize for that by using the highcpu series.

Closing issue since repo has been archived.


deleted duplicate variable

Description
deleted a duplicate variable.
Related issues and discussion
#565 #757
closes #885
Checklist

[x] Apply the AndroidStyle.xml style template to your code in Android Studio.
[x] Code is well documented
[x] Include unit tests for new functionality
[x] All user-visible strings are made translatable
[x] Code passes Travis builds in your branch
[x] If you have multiple commits please combine them into one commit by squashing them.
[x] Read and understood the contribution guidelines .

This one fixes #885 - Hi @teolemon, please merge this one ASAP

Merged thanks @jaztriumph


[Icons] Add support for icon aliases during icon:lock command

Context
Currently, the IconFinder only scans templates to identify used icons, using the following regex:
$token = '[a-z0-9]+(?:-[a-z0-9]+)*';
$pattern = "#(?:'$token:$token')|(?:\"$token:$token\")#i";

This approach means that only icons directly referenced in templates are locked when running the icon:lock command.
Problem
Some icons are defined as aliases in the ux_icons configuration file. These aliased icons are not detected by IconFinder and therefore are not locked automatically, which can lead to inconsistencies during deployment.
Request
Would it be possible to add support for scanning icon aliases defined in the ux_icons file, in addition to using the regex to search templates? This enhancement would ensure that all icons actually used in the application are properly locked.

Hello @jvancoillie ! You can check #2356 it should fix things for you
Nice catch and good idea :)


Form explainers: flag for migration of LE & CD into Wagtail

We are in the process of migrating the two original hard-coded form explainers (for the Loan Estimate & Closing Disclosure forms) into Wagtail. This PR adds a flag that can be used to switch over from the hardcoded templates to the Wagtail versions once they're ready.
Additions

WAGTAIL_FORM_EXPLAINERS flag

Changes

Updates LE + CD routes to use flagged_wagtail_template_view

How to test this PR

Check out branch
Pull the latest db dump and publish the draft Wagtail Closing Disclosure and Loan Estimate explainer form explainer pages locally.
Update the slug on the Loan Estimate explainer page to loan-estimate.
Navigate to the loan estimate and closing disclosure explainer paths and verify that the hard-coded pages are still being displayed (they have a gray Buying a House banner under the mega menu).
Enable the WAGTAIL_FORM_EXPLAINERS flag
Navigate to the loan estimate and closing disclosure explainer paths and verify that the Wagtail versions (sans banner) are now being shown

Screenshots
Original CD explainer

Wagtail CD explainer

Checklist

[x] PR has an informative and human-readable title

PR titles are used to generate the change log in releases; good ones make that easier to scan.
Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".

[x] Changes are limited to a single goal (no scope creep)
[x] Code follows the standards laid out in the CFPB development guidelines

Thanks for reviewing, @willbarton!


Remove source maps from build

This PR removes the source maps from the build output.
We currently include source maps, but we don't include the original source files meaning the maps point to invalid references.

I assume once we merge this, we can close https://github.com/trybento/bentwo/issues/10102?


[Feature Request] do the same on headers

Outliner is extremely useful, so useful that I wish it did the same for headers.  With long documents, headers are necessary but I'd like to rearrange and navigate these hierarchies with the speed and keyboardiness that outliner provides.  Would you consider adding similar navigation and manipulation commands for headers?
If so, I'd suggest doing it like it's done in other editing programs that have both headers and lists:

when the cursor is in a list do outliner list operations, as always
when the cursor is on a header, do header operations

the same operations as can be done on lists, as much as possible
consider the lists inside headers as plain text, not hierarchical objects

when there is a selection region

operate on the highest level of hierarchy within the region (more complicated)

For headers, there is the Obsidian core outline plugin, but this is totally mouse driven, and you have to open up a side pane to use it.  There is also a zoo of plugins which implement some kinds of header manipulation.  But none of them does everything, and most of them are inconsistent with each other.
It would be lovely to have list and header manipulations handled coherently, in a single plugin.

For the record, I've discovered that the heading shifter plugin can indent or outdent headers


ctrl+pgup, ctrl+pgdown

Things like shift+t  (browser new tab, makes sense to make a 'new tab' support in tui via same key combo
Also, crtl+pg up  or ctrl+pg down

Hey, @Bwahharharrr! shift+t is supported (it comes in as a literal capital T):
// Here's what shift+t looks like
tea.Key{type: tea.KeyRunes, runes: []rune{'T'}}

// Matching on it in an update:
func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
    switch msg := msg.(type) {
        case tea.KeyMsg:
            switch msg.String() {
                case "T":
                // shift+T!
        }
    }
    // ...
}

As for ctrl+pgup and ctrl+pgdown, iirc they're not matchable because of terminal limitations beyond our control, but it's worth looking into again.

Yeah I only thought about pgup and pgdown because of the familiarity using them in browser tabs, so using the same commands in tui tabs also makes sense.

Turns out this is actually parseable from the input stream. Fix in master.


fix: sidebar & toc spacing on nextui docs

Closes #
📝 Description

revised spacing for sidebar and toc to show the blocked content

⛳ Current behavior (updates)

Please describe the current behavior that you are modifying

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

@wingkwong fixed here https://github.com/nextui-org/nextui/pull/2438/files


Incompatible with ModernFix Dynamic Resources.

Describe the bug
Game crashes when using ModernFix with Dynamic Resources on in it's settings
To Reproduce
Install ModernFix alongside Dynamic Trees, enable Dynamic Resources in ModernFix' settings
Additional context
The issue was already fixed, but only in 1.19.2. Here is the issue the creator of ModernFix made, I would greatly appreciate if you backport this fix to 1.18.2. https://github.com/DynamicTreesTeam/DynamicTrees/issues/795

This is still active


angular 2  is next  python 3 ?

eveyone use python2 （angular 1）， not python3(angular 2)
Google is still promote angular 1 , not angular 2
thank you
:)

They are not promoting angular 2 because it is not even in beta yet...

Github is for issues only, please take discussions to the mailing list


Announcement: Meetup in Berlin, June 10th

👋 Hey everyone. In case you're not a watcher in the community repo, we're planning a meetup in Berlin on June 10th. We'd love to know if you're in the area and would like to join us.
Our planning thread is here: https://github.com/orbitdb/welcome/issues/63. Let us know if you can make it!
Locking this thread to avoid duplicative comments and noise.

Closing this as the event has passed


Enforce tansaction size limit

TransactionSizeError should be translated to BadRequest in history handler?

This diff does the following:

Enforces transaction size limit at persistence layer
Fixes existing bug in RespondDecisionTaskCompleted. Workflows which were being failed by us due to a size check validation failure were not being cleaned up.
Makes two small refactors in RespondDecisionTaskCompleted.
Fails workflow if transaction size error occurs.

Here is an example of a workflow history which results from triggering a transaction size beyond limit.

Fixes #1894


ROS bag to test out and understand the framework will help a lot

ROS bag to test out and understand the framework will help a lot.
Requesting you to provide smaple bag fils so that community can understand repo better

This is really just a personal project - I'm not sure any of the code is really built to be portable to other robots.


Add hierarchy json file

Description
An entity_hierarchy_info.json file has been added into gamechangerml/data/features as a datasource used to ingest hierarchy nodes into the graph. Also, GraphRelations.xlsx has been updated to add in additional aliases for organizations to include terms that are used by documents in their display_org_s field (to ensure proper mapping between documents and entities)
Ticket(s) or Issue(s):
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
The added json file (and updates to the xlsx file) have been used in testing out ingestion into neo4j locally and work as expected. Additional testing in dev environments will be performed as part of code review

[x] Local
[ ] Server 119
[ ] Server 115
[ ] K8

Screenshot of automated jenkin tests (if applicable):
Checklist:

[x] My code follows the style guidelines of this project

[x] I have performed a self-review of my own code

[ ] I have commented my code, particularly in hard-to-understand areas

[ ] I have made corresponding changes to the documentation

[x] My changes generate no new warnings

[ ] I have added tests that prove my fix is effective or that my feature works

[x] New and existing unit tests pass locally with my changes

[x] Any dependent changes have been merged and published in downstream modules

[ ] I have used an autoformatter like lint or blackc

[x] This requires a code review

@JLyons1985 thanks for fixing this branch, I rebased on dev and I'm not sure why but that threw things off.