admins can delete quotes from any server

If you are an admin, you can delete quotes that are not from your server as well.
This means you can create a personal server where you are an admin and delete every quote there is.

Don't trust your bot with strangers? 😜 In all seriousness, that is probably a bug.

Fixed already locally. Thanks


Update faq.yml

Added QA to clarify the use of semantic search for the blob and upload files options.

@mrbullwinkle
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Retries fail because of missing controller action

The JobScoped concern sets a before_action on the index action that does not exist in the RetriesController. For retries, it needs to run on the create action instead.
This is caused by the new Rails 7.1 default config for raising errors on missing callback actions.
AbstractController::ActionNotFound (The index action could not be found for the :set_job
callback on MissionControl::Jobs::RetriesController, but it is listed in the controller's
:except option.

Raising for missing callback actions is a new default in Rails 7.1, if you'd
like to turn this off you can delete the option from the environment configurations
or set `config.action_controller.raise_on_missing_callback_actions` to `false`.
):

The before_action might need to get extracted to the controllers, but it would be nice if it didn't have to?

Ahhh, great catch @excid3! We've been running this in Rails 7.1 for a bit, but without having all of Rails 7.1 defaults yet. Because of that, we haven't run into this 😳 We'll fix it, will see how it'd look best 🤔


Fix comments regarding Atari disks.

Fix out of date comment. Used to be three boot tracks, but since the loader was introduced, it's only one.
Regards,
Ivo

Thanks --- merged.

Hi,
Didn't see it merged into master yet. Here's another fix when building the 90kB SD image.
Regards,
Ivo

Huh --- maybe I forgot to press the button. Done now.


Update New-CsCallingLineIdentity.md

Changed the example descriptions to clarify which example snippets were being referred to.

Docs Build status updates of commit e0770cd:
:clock10: Full build: the average full build time is 14 min(s) 15 sec(s), this is based on the last 269 build(s) for this repository.

Docs Build status updates of commit e0770cd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsCallingLineIdentity.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit c6e9af0:
:clock10: Full build: the average full build time is 14 min(s) 17 sec(s), this is based on the last 288 build(s) for this repository.

Docs Build status updates of commit c6e9af0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsCallingLineIdentity.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit bd696f2:
:clock10: Full build: the average full build time is 14 min(s) 16 sec(s), this is based on the last 295 build(s) for this repository.

Docs Build status updates of commit bd696f2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsCallingLineIdentity.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add crate: RustaCUDA

Please add crate to category: GPU Computing
RustaCUDA helps you bring GPU-acceleration to your projects by providing a flexible, easy-to-use interface to the CUDA GPU computing toolkit. RustaCUDA makes it easy to manage GPU memory, transfer data to and from the GPU, and load and launch compute kernels written in any language.

Added via #61


Fixing Dask ZeroDivisionError - DO NOT MERGE

Some users experience a dask ZeroDivisonError in the latest master branch of Parcels. See e.g. https://github.com/OceanParcels/parcels/issues/889#issuecomment-666869317.
By running git-bisect, we were able to pinpoint this bug to https://github.com/OceanParcels/parcels/commit/cbf9e287e3e5bcefd6c60821fddaf30425cb094c.
While removing the line data = data.rechunk(self.chunk_mapping) from field.py fixes this bug, it causes other unit tests to fail. Clearly, some further work is needed on the dask chunking

In my opinion, this change is the right way to go, but triggers an error due to incorrect behaviour elsewhere. The test requests field_chunksize=(1, 2, 2). Since the depth chunking is only singular, it gets dropped from the chunk_mapping dictionary:
            self.chunk_mapping = {}
            if(isinstance(self.field_chunksize, tuple)):
                j = 0
                for i in range(len(self.field_chunksize)):
                    if self.field_chunksize[i] <= 1:
                        continue
                    self.chunk_mapping[j] = self.field_chunksize[i]
                    j += 1
                self.field_chunksize = tuple([self.chunk_mapping[i] for i in range(len(self.chunk_mapping))])

So after this, you end up with chunk_mapping = {0: 2, 1: 2}. Before the data.rechunk() call prior to its removal in this PR, data looks like:
dask.array<getitem, shape=(4, 3, 3), dtype=float32, chunksize=(1, 2, 2), chunktype=numpy.ndarray>

but afterwards, chunksize=(2, 2, 2). In other words, it incorrectly rechunks the depth dimension to size-2 chunks.

Thanks @angus-g, yes we saw that too. We are now working on a more comprehensive refactoring of the NetcdfFileBuffer class (#905), and will properly fix this bug in that PR. This PR is only here so that users who encounter the ZeroDivision Error can in the meantime find a quick fix. We have no intention to merge it into master

This is now fixed in #905, so closing this PR


Randomness

Issue(s): https://github.com/NethermindEth/StarknetByExample/issues/128
Description
Added code for Dice Game VRF application.
Checklist

[x] CI Verifier: Run ./scripts/cairo_programs_verifier.sh successfully
[ ] Contract Tests: Added tests to cover the changes

@okhaimie-dev Hello! Let me know if you need any help on finishing this

Done in #238


Secondary Index problem

I added a secondary index for an Integer attribute of my SimpleFeature
NumericIndexStrategy indexStrategy = new SimpleIntegerIndexStrategy();  FeatureAttributeDimensionField[] dimensionFields = {new FeatureAttributeDimensionField(getPlaneFeatureType().getDescriptor("flightId"))}; CommonIndexModel indexModel = new BasicIndexModel(dimensionFields); Index numericIndex = new CustomNameIndex(indexStrategy, indexModel, "flightIdIndex");
"flightId" is declared as an attribute at my SimpleFeatureType definition as;
sftBuilder.add(atBuilder.binding(Integer.class).nillable(false).buildDescriptor("flightId"));
When I run my code, it creates two tables for my two different indicies;
cassandraDataStore.addType(adapterForPlane, spatialTemporalIndex, numericIndexForFlightId);
and I am not sure It should be like that or not. Each table has 1 million rows data right now and when I try to query for flightId with the secondary index(my numeric index defined above), query returns nothing. And when I try the same query with my spatial temporal index, query works fine and returns true result but it takes really too much time (approximately 60 seconds).
My query;
final CloseableIterator<SimpleFeature> iterator2 =                 cassandraDataStore.query(                         bldr.addTypeName(adapterForPlane.getTypeName())                                 .allIndicies().constraints(                                 bldr.constraintsFactory()                                         .cqlConstraints("flightId = 8812"))                                 .build());
         while (iterator2.hasNext()) {             SimpleFeature sf = iterator2.next();             resultList.add(sf);         }
So what am I doing wrong about this secondary index for querying in millions of data at cassandra datastore according to Integer field?

I think you got a really good amount of the way through your use case, the problem is that as of this moment, geowave does not wire the CQL query constraint to a range of rows in that custom index you had defined. To choose the flight ID index replace allIndices() with indexName("flightIdIndex") and to make sure the constraints are applied to the row ranges the easiest approach is to use a different query constraint that will be a bit more direct than CQL (and note CQL is not the cassandra CQL here, its the geoserver CQL).  One constraint you could use for a range scan may be new SimpleNumericQuery(...) such as how this section of test code runs.
There's a few other options as well that are direct such as InsertionIdQuery or prefix(...) from QueryConstraintsFactory.
Also, you should be aware, for secondary indexing you have to options at the datastore level.  What you are doing currently is duplicating the data in 2 different indices which will be faster retrieval, but additional storage.  You can set secondary indexing to enabled on the data store which will write Data IDs to a separate table where the full values are held and each of the indices are just a reference to that table stored by data ID (less storage, extra referencing on retrieval).   If your data ID is flight ID in your case that could work out nicely because then as a query constraint you can simply get the data by data ID directly (on the QueryConstraintsFactory there is a method for this).  Of course it would have to be unique so that may not work as nicely.

Actually, flightId is not unique in my case because I save each flight's instantaneous location and other infos (such as time) at each second. So, of course a flightId represents a unique flight but in my datastore I have 3600 rows of data for a 1 hour flight and these 3600 rows have same flightId attribute.
I forgat to state that I replaced allIndices() part of my code with indexName("flightIdIndex") and query returned nothing (no exception too).  Now, I replaced my CQL part of the query code with SimpleNumericQuery(...) as you suggested and it worked well. Thank you for your help. My query code is
final CloseableIterator<SimpleFeature> iterator2 =                 cassandraDataStore.query(                         bldr.addTypeName(adapterForPlane.getTypeName())                                 .indexName("flightIdIndex").constraints(                                 new SimpleNumericQuery(Range.between((double) 8812, (double) 8812))                         ) .build());
     while (iterator2.hasNext()) {             SimpleFeature sf = iterator2.next();             sf.setAttribute("uavId", uavId);             resultList.add(sf);         }
now, and for 3.6 millions rows of data, this query returns resultset (approximately 100.000 rows of data) at 13-14 seconds. However, each returned SimpleFeature object's "flightId" attribute is null. Is this something expected?
And how can I combine this type of query with a spatialtemporal query with using my spatialTemporalIndex and flightIdIndex, I mean is it possible to combine the above with the expression like;
constraints(                                 bldr.constraintsFactory()                                     .spatialTemporalConstraints()                                     .addTimeRange(oneHourBack, currentDate)                                     .build()                         )
I have a few other questions too but they might not be directly related with this secondary index issue. I appriciate for your help and contribution Mr. @rfecher

glad you're having much more success.
flightID returning as null is not what I'd expect.  It should use the index model to read/write flight ID in that particular situation, perhaps this is an underlying bug we will need to look at.
For the intersection of 2 different queries, we don't have anything built in, but there are ways to make it more efficient.  For one, if this is a common use case, I'd consider trying secondary indexing.  I'll share code snippet examples later when I have some time.

I would like to see code snippet examples when you have time

so what I've done for a join before to minimize the volume of data returned is to enable secondary indexing on the data store so that its storing the values once by data ID and then joining as many individual queries as you like by doing the intersection of Data IDs.  Furthermore, in order for the secondary index to not return the full value when it is unnecessary I use an aggregation.  And lastly, for subsequent queries/aggregation after the initial one you can add a constraint that the data ID must match one thats in your intersection set.  In your case you'd have 1 aggregation collecting data IDs and 1 query.
/// the aggregation(s) would look like this:
VectorAggregationQueryBuilder<?, Set<String>> featureDataIdAggregationQuery =
        VectorAggregationQueryBuilder.newBuilder().aggregate(
            <your data type adapter>.getTypeName(),
            (Aggregation) new CollectDataIdsAggregation());
featureDataIdAggregationQuery.indexName("flightIdIndex");
featureDataIdAggregationQuery.constraints( new SimpleNumericQuery(Range.between((double) 8812, (double) 8812)) );
Set<String> dataIdsMatchingFlightName = cassandraDataStore.aggregate(featureDataIdAggregationQuery.build());
// and the final query would just pre filter by the previously collected data IDs and look like this:
final CloseableIterator<SimpleFeature> joinedResults = cassandraDataStore.query(constraints( new QueryConstraintsFilterWrapper (bldr.constraintsFactory() .spatialTemporalConstraints() .addTimeRange(oneHourBack, currentDate) .build(), new GeoWaveDataIdFilter(dataIdsMatchingFlightName) );

And here's some of the supplemental classes that help if you are trying to be extra efficient while using a data store with secondary indexing enabled to only return data IDs and prefilter by data IDs (avoiding any unnecessary lookups for values that don't match the full intersection):
public class CollectDataIdsAggregation implements
    CommonIndexAggregation<Persistable, Set<String>> {
  private Set<String> results = new HashSet<>();

  public CollectDataIdsAggregation() {}

  @Override
  public Persistable getParameters() {
    return null;
  }

  @Override
  public void setParameters(final Persistable parameters) {}

  @Override
  public Set<String> getResult() {
    return results;
  }

  @Override
  public byte[] resultToBinary(final Set<Integer> result) {
return new byte[0];
  }

  @Override
  public Set<String> resultFromBinary(final byte[] binary) {
//for data stores that distribute the aggregation such as accumulo and hbase the to and from binary would need to be filled in
  }
  @Override
  public void clearResult() {
    results = new HashSet<>();
  }
  @Override
  public void aggregate(final CommonIndexedPersistenceEncoding entry) {
    results.add(StringUtils.fromBinary(entry.getDataId()));
  }
  @Override
  public byte[] toBinary() {
    return new byte[0];
  }
  @Override
  public void fromBinary(final byte[] bytes) {}
}

public class GeoWaveDataIdFilter implements QueryFilter {
  private final Set<String> ids;

  public GeoWaveDataIdFilter (final Set<String> ids) {
    this.ids = ids;
  }

  @Override
  public void fromBinary(final byte[] arg0) {}

  @Override
  public byte[] toBinary() {
    return new byte[0];
  }

  @Override
  public boolean accept(
      final CommonIndexModel indexModel,
      final IndexedPersistenceEncoding<?> encoding) {
    return ids.contains(StringUtils.fromBinary(encoding.getDataId()));
  }
}

public class QueryConstraintsFilterWrapper implements QueryConstraints {
  private final QueryConstraints constraints;

  private final QueryFilter preConstraintsFilter;

  public QueryConstraintsFilterWrapper(
      final QueryConstraints constraints,
      final QueryFilter preConstraintsFilter) {
    super();
    this.constraints = constraints;
    this.preConstraintsFilter = preConstraintsFilter;
  }

  @Override
  public List<QueryFilter> createFilters(final Index index) {
    final List<QueryFilter> constraintsFilters = constraints.createFilters(index);

    final List<QueryFilter> retVal =
        new ArrayList<>(
            constraintsFilters.size() + 1);
    retVal.add(preConstraintsFilter);
    retVal.addAll(constraintsFilters);
    return retVal;
  }

  @Override
  public void fromBinary(final byte[] binary) {
    constraints.fromBinary(binary);
  }

  @Override
  public List<MultiDimensionalNumericData> getIndexConstraints(final Index index) {
    return constraints.getIndexConstraints(index);
  }

  @Override
  public byte[] toBinary() {
    return constraints.toBinary();
  }
}

regarding the error message "Data writer of class class org.locationtech.geowave.core.store.index.BasicIndexModel does not support field for org.locationtech.geowave.adapter.vector.FeatureAttributeCommonIndexValue@2a190cf3"
that'd be why you're seeing null flightIDs ... are you enabling secondary indexing on the data store at this point?  Basically for you CommonIndexModel you'll need to return a reader and writer for field name "flightIdIndex" although I'm not sure thats required when secondary indexing is enabled.

Basically I define two indices, one is spatialtemporal, and the secondary index is "flightIdIndex".
public Index getSpatioTemporalIndex() {         return new SpatialTemporalDimensionalityTypeProvider.SpatialTemporalIndexBuilder().setPartitionStrategy(IndexPluginOptions.PartitionStrategy.ROUND_ROBIN).setNumPartitions(10)                 .setPeriodicity(TemporalBinningStrategy.Unit.HOUR).createIndex();     }
public Index getNumericIndexForFlightId() {         NumericIndexStrategy indexStrategy = new SimpleIntegerIndexStrategy();         FeatureAttributeDimensionField[] dimensionFields = {new FeatureAttributeDimensionField(getUavDataSpatialFeatureType().getDescriptor("uavId"))};         CommonIndexModel indexModel = new BasicIndexModel(dimensionFields);         Index numericIndex = new CustomNameIndex(indexStrategy, indexModel, "uavId_IDX");         return numericIndex;     }
and I use these two indicies when writing data to Cassandra as;
cassandraDataStore.addType(adapterForFlights, spatioTemporalIndex, numericIndexForFlightId);
Writer<SimpleFeature> writer = cassandraDataStore.createWriter(adapterForFlights.getTypeName());
and use this writer object to save data. So I couldn't get what you mean by enabling secondary indexing on datastore. Should I set some other fields of CommonIndexModel when I define my secondary index?

By the way, I achieved to combine queries with your QueryConstraintsFilterWrapper class approach.
Collecting dataId's matching with flight Id part takes 3-5 seconds and the spatialTemporal queryConstraint part which works on the collected set takes almost 75-80 seconds. Consequently, this result shows that I cannot take advantage of my spatialTemporal Index. Is this long duration something expected when using this approach?

ah, so when I mention enabling secondary indexing I'm referring to CassandraOptions.setSecondaryIndexing(true) when you create the data store (this must stay constant on the data store so if you've already ingested data you can't switch it, but you can ingest into a different gwNamespace if you want to give it a try). Its a member of CassandraRequiredOptions which is how you end up creating a data store and its also an available option from the commandline on geowave store add
Regarding slow spatial-temporal queries, I think you'll likely want a periodicity greater than an hour (try month for example... the default is year).  The space filling curve portion of the keys is broken up by that periodicity so you'd basically only have effective range scans within periodicity boundaries.  Also, you are not specifying a spatial extent from what I see so you'd be considerably better off with a temporal index than a spatial-temporal index for this type of query.  A spatial-temporal index works best with both reasonable geospatial and temporal constraints.

I will try enabling secondary index with a new gwNamespace. Actually I will add reasonable geospatial and temporal constraints in the future, however I also need non-spatial queries too now. Thank you for your contribution, I am able to add and use secondary numeric index to my datastore successfully. I have a few other questions (and performance issues) too but I'm closing this issue if its ok for you too Mr. @rfecher


chore(docs): update README and license to Apache 2.0

:tada: This PR is included in version 2.2.2-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix Long video thumbnail titles issues.

hi
i added "aspectRatio" to solve issue.
Fixes #72

@cloner93 Thanks for you contribution. It seems that you have forgotten to format the code. please apply code formatting with spotless


Added Dimension Data examples

Bumped version to 2.2.0-SNAPSHOT across all modules
Added three examples:

org.jclouds.examples.dimensiondata.cloudcontrol.DeployNetworkDomainVlanAndServer - deploys Network Domain, VLAN and a Server and waits for them to be state Normal and in the case of the Server for it also to be started.
org.jclouds.examples.dimensiondata.cloudcontrol.DeleteServerVlanAndNetworkDomain - deletes all of the assets deployed in 1.
org.jclouds.examples.dimensiondata.cloudcontrol.NetworkDomainTearDown - given a Network Domain - clean down all of the associated assets.

Thanks for taking a look @nacx I will make the required changes.

merged to master as a145a8fd. Thanks, @trevorflanagan!


problem when compiling iou3d and roipool3d in Windows

I have compiled the codes of iou3d and roipool3d in Ubuntu successfully, but when I tried to compiled iou3d in Windows, the error occurred that showed 'identifier "EPS" is undefined in device code'. Thus, I change the code like below.
//#define DEBUG
const int THREADS_PER_BLOCK_NMS = sizeof(unsigned long long) * 8;
//const float EPS = 1e-8;
#define EPS 1e-8

However, I met another problem
iou3d.obj : error LNK2001: 无法解析的外部符号 "public: long * __cdecl at::Tensor::data<long>(void)const " (??$data@J@Tensor@at@@QEBAPEAJXZ)
build\lib.win-amd64-3.6\iou3d_cuda.cp36-win_amd64.pyd : fatal error LNK1120: 1 个无法解析的外部命令
error: command 'C:\\Program Files (x86)\\VC\\BIN\\x86_amd64\\link.exe' failed with exit status 1120

Anyone know how to solve it?

I guess it's because in Linux, unsigned long == 64 bits, in windows, unsigned long == 32 bits, so u can change all the definition of at::tensor:: data to "unsigned long long" which is 64 bits. Try if u can solve it

@candisjesus  Thank you for your reply! However, there is no "at::tensor::data" in the codes that I want to compile(iou3d.cpp, iou3d_kernel.cu). I still have no idea how to deal with it.

I mean try to change long * keep_data = keep.data();
To
Long long * keep_data = keep.data();
U need to change “keep.data”to
| |
李晶津
<EMAIL_ADDRESS>|
签名由 网易邮箱大师 定制
On 09/11/2019 15:19, lonely7yk wrote:
@candisjesus Thank you for your reply! However, there is no "at::tensor::data" in the codes that I want to compile(iou3d.cpp, iou3d_kernel.cu). I still have no idea how to deal with it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@candisjesus Wow! It works! I have been suffered from the problem for two days. Thank you very much!!

@lonely7yk  I appled Long long * keep_data = keep.data(); but give me the same error
roipool3d.obj : error LNK2001: unresolved external symbol "public: long * __cdecl at::Tensor::data_ptr(void)const " (??$data_ptr@J@Tensor@at@@QEBAPEAJXZ)
build\lib.win-amd64-cpython-39\roipool3d_cuda.cp39-win_amd64.pyd : fatal error LNK1120: 1 unresolved externals
error: command 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\bin\HostX86\x64\link.exe' failed with exit code 1120


Change execution of execute_operations_sequentially

Create split_enums.jsonl

Addresses #501

Closing this PR as https://github.com/mlcommons/croissant/issues/501 is closed.


tidal bell Op12gage

I traded for a tidal bell last night from ViolentNature and it popped away from my hotbar. I've checked every storage box i have, to make sure i didnt accidentally put it away, and nothing.

What server do you play on?

This item has been found to be just a visual glitch after further investigation; Closing


Updated index.md

Added some more member functions of vector related to size of vector

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@elfreki I have corrected the issues camperBot found.


Support for caching null values

优化缓存括展，支持缓存null值
当前CacheFilter存在无法缓存null值问题
但是某些rpc接口被设计成可能返回空值（比如跟据用户名查询用户信息接口，如果查询不到，返回null）
增加一个内部类包装待缓存的数据
static class ValueWrapper {
	private final Object value;
	public ValueWrapper(Object value){
		this.value = value;
	}
	public Object get() {
		return this.value;
	}
}

Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Pls check and fix ci problem.

The unit tests failed.
Failed tests:
  CacheFilterTest.testNull:137 expected:<null> but was:<value1>
  CacheFilterTest.testNull:137 expected:<null> but was:<value1>
  CacheFilterTest.testNull:137 expected:<null> but was:<value1>
Tests in error:
  CacheFilterTest.testException:124 Â» HazelcastSerialization Failed to serialize...
  CacheFilterTest.testMethodWithArgs:110 Â» HazelcastSerialization Failed to seri...
  CacheFilterTest.testNonArgsMethod:97 Â» HazelcastSerialization Failed to serial...
  CacheFilterTest.testNull:134 Â» HazelcastSerialization Failed to serialize 'org...

Pls. take a look.

Codecov Report

Merging #2480 into master will decrease coverage by 0.11%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master    #2480      +/-   ##
============================================
- Coverage     55.09%   54.97%   -0.12%
- Complexity     5270     5279       +9
============================================
  Files           573      573
  Lines         25446    25508      +62
  Branches       4518     4527       +9
============================================
+ Hits          14019    14023       +4
- Misses         9335     9389      +54
- Partials       2092     2096       +4

Impacted Files
Coverage Δ
Complexity Δ

...ava/org/apache/dubbo/cache/filter/CacheFilter.java
76.19% <77.77%> (-3.81%)
5 <0> (-1)

...ache/dubbo/remoting/p2p/support/AbstractGroup.java
45.45% <0%> (-11.37%)
7% <0%> (-1%)

.../dubbo/remoting/transport/netty4/NettyChannel.java
57.64% <0%> (-8.61%)
22% <0%> (-1%)

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
41.66% <0%> (-8.34%)
3% <0%> (ø)

...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java
58.06% <0%> (-6.46%)
3% <0%> (ø)

...src/main/java/org/apache/dubbo/rpc/RpcContext.java
46.62% <0%> (-5.25%)
54% <0%> (ø)

...exchange/support/header/HeaderExchangeChannel.java
79.16% <0%> (-4.35%)
35% <0%> (ø)

...ava/org/apache/dubbo/common/utils/ClassHelper.java
71.83% <0%> (-4.29%)
17% <0%> (ø)

...apache/dubbo/rpc/cluster/support/ClusterUtils.java
63.15% <0%> (-4.19%)
2% <0%> (+1%)

...ing/transport/dispatcher/ChannelEventRunnable.java
79.16% <0%> (-1.69%)
9% <0%> (ø)

... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a86d61...249eb02. Read the comment docs.


2 files found with path 'META-INF/com.google.dagger_dagger.version'.

After updating to 1.14.0 from 1.10.2 getting this error during the build:
2 files found with path 'META-INF/com.google.dagger_dagger.version'.
AGP version: 7.2.1
Dagger-Hilt Version: 2.42

Looking into it

Hey @atick-faisal — could you check the 1.14.1-SNAPSHOT release if it fixes your problem?

Hello @dariuszseweryn. Thanks for the reply. I added the following in my build.gradle file:
implementation("com.polidea.rxandroidble2:rxandroidble:1.14.1-SNAPSHOT")
Getting this error:
> Could not resolve com.polidea.rxandroidble2:rxandroidble:1.14.1-SNAPSHOT.
         > Unable to load Maven meta-data from https://jitpack.io/com/polidea/rxandroidble2/rxandroidble/1.14.1-SNAPSHOT/maven-metadata.xml.
            > Could not GET 'https://jitpack.io/com/polidea/rxandroidble2/rxandroidble/1.14.1-SNAPSHOT/maven-metadata.xml'.
               > Read timed out

Am I doing something wrong?

Instructions how to use snapshot releases are in the README

Thank you @dariuszseweryn. This solved the issue. Build completed successfully.

Awesome, thank you for verifying

1.15.1-SNAPSHOT should be OK. Regular 1.15.1 should be available shortly


Add instructions for MacPorts

I've just added a port for mvnd to MacPorts: https://ports.macports.org/port/mvnd/
This merge request adds the command for installing mvnd via MacPorts to the readme.

Thanks @breun!


Document new context API and fix some docs mishaps

Fixes #207. Fixes #241.
This PR documents the new context API (#4) that was recently merged while cleaning up some of the little problems about our docs.

Changed <hr> tags to be solid lines instead of dashed ones (#207)
Added extra static notice to validateProps (#241)
Removed custom CSS in favor of using Admonition
Added baseline documentation for the new context feature

lgtm


pipeline

What/Why

Implement a CI pipeline as ChatOps slash commands. For several reasons, this is much safer and more economical than always running pipelines on new commit pushes

Saves on the free CI minutes we get from GitHub
Will save money on AWS usage charges once we get the ephemeral E2E tests integrated
Protects our secrets like tokens and AWS creds from automatically being used on new PRs from people we don't know

This initial PR sets up the framework, and includes a couple of test runs as a proof of concept.

/test ping: Adds a new status check that just says "pong"
/test hello: PoC of a fully implemented test run, just runs echo "Hello World!" for now.
/test quote: Adds a new status check that outputs a famous quote
/test all: Runs all of the above except ping

You can chain them together too: /test ping hello quote
None of this will work in this PR, since GitHub Actions only uses actions in the trunk branch.
A huge amount of work has been copied from CloudPosse's "Actions" repo: https://github.com/cloudposse/actions
Big shout out to all the great work from @osterman and the rest of the CP team.

@osterman if you wouldn't mind eyeballing this if you have a few minutes it would be a huge help to me. I'm very experienced with Jenkins and GitLab pipelines but GitHub Actions are new to me.

Testable PoC here: https://github.com/defenseunicorns/slash-command-dispatch-test/pull/4

Depends on how you did your sync.  For most things I'd prefer to rebase, but I had to do a merge commit last night for my k8s-native-apply-pr because rebasing would have been a total nightmare due to it's # of commits, complexity and frankly that branch doing a poor job of staying in it's lane.


Missing Templates

Every time I create a controller, I need to transfer files to a folder of the controller to the theme? No function built-in?
Example:
$ rails g themes_on_rails:generatelayouts SomeController
Just does'not exists in doc. about this.Thx.

I'm not really sure what you mean.

No built-in function, you can custom generator on your own if needed.


Can't change color of splitcontainer

Godot version
3.3.stable
System information
Windows 10, GLES2, NVIDIA GTX 970
Issue description
I've tried messing around with the theme options for the HSplitContainer, but I was unable to change the color of the divider. It's stuck to this plain gray.
Steps to reproduce
Create a HSplitContainer and try to change the divider's color.
Minimal reproduction project
No response

Having a divider modulate theme option for SplitContainer would be nice to have.
As a workaround, you can either color the image used for the divider or change the self_modulate property to color it.

I don't understand the issue, why is using modulate or self_modulate the workaround rather than the exact solution?

@Mickeon Most Control nodes that display images (like Button, ItemList, etc.) have a theme color for modulating the image only, but SplitContainer doesn't.

I was trying to implement this but I am struggling to even have a SplitContainer show its image on master...


Support disabled prop for buttons

I'm trying out to swap a generic Touchable component I use in an app to use this library instead of react-native TouchableX and one simple feature I noticed was missing is a way to disable the buttons, RN touchables have a disabled prop.
From what I understand this feature could be implemented in JS land by just not showing feedback and preventing the call to onPress.

👍
This sounds good. Ideally I'd like for gesture handlers to have active property, which could be used for this purpose. If that'd only be done on the JS side the button would still capture click events which could be undesirable.
Also I think regular RN's touchables are "disabled" when onPress is empty

True we'd have to handle this in native, I might try to implement it next time I get some free time :)

This has landed in #33
Thanks for suggesting this feature!


Export models as enums.

Since we want our customers to be able to perform iterations on these
enums, union types cannot be used. This fully moves all models to enums.
Changes in the examples have been updated to reflect the new way of
using them.
Signed-off-by: Ruben Aguiar<EMAIL_ADDRESS>

@jstasiak There was clearly more enums than I reported, so I think the other PR had an issue because it wasn't catching up all enums 🙏


265 integrate with medium

Description
This PR makes the news section of NavHub run off the Medium publication by injecting react components into the static site.
There's still a bit of work to do but i wanted to get the preview links up. Don't merge.
Issues Resolved
#265
Preview Links
https://deploy-preview-267--compassionate-colden-815a55.netlify.com/
https://deploy-preview-267--compassionate-colden-815a55.netlify.com/news/
https://deploy-preview-267--compassionate-colden-815a55.netlify.com/article/?id=navcoin-community-roundtable-003-f499c447c896
Checklist

[x] Update the guide of how to contribute articles
[ ] Put redirects in place for the old URL structure
[x] Test the changes work across both mobile and desktop

The downside of this approach is;
Problem: I can only pull the latest 10 articles from the RSS feed to display on the news feed.
Solution: Instead of paginating all results just link to the medium publication for more articles.
Problem: Rendering each article is really janky, there's no way to get it properly from the API so I have to basically wget each article URL and do a bunch of transforms to get the data in the right shape. The issue is that if its probably quite fragile and if they change the structure then its likely to look broken on our site.
Potential Solution: Only host the /news/ page and not even try to render the article, send the user directly to the article on medium. Probably better anyway since they can clap and subscribe etc from there.

@aguycalled @mxaddict @roast-nav do any of you guys have an opinion about the issues i wrote about above?

redirects are not actually necessary because all the old URL's still exist.

I'm going to merge this in if no one has any objections.

1 x bounty high = 1000 NAV.
Payment Address: NNxVwZMkmu9cqayKBmPLpVB2mgprQ15yVD

Paid: 3c4ec5a5dffe534b69a321acc490fd40cd6b5a4be027327ce8ca63d47e365a4c


check timestamps on files when hash is not available

https://github.com/siliconcompiler/siliconcompiler/actions/runs/9725273960


vimPlugins.vim-pets: init

Description of changes
Added vim-pets
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Please fix the merge conflict by regenerating this.

I didn't realize you were waiting on me for this @superherointj, I apologize. I've rebased off of latest main and have re-run nix run .#vimPluginsUpdater. Please let me know what else you need from me on this.

@heywoodlh Please ask for a review from someone related to the Vim ecosystem. I suggest you use git history and add reviewers that have altered the vim files. I won't be proceeding with review here since my familiarity in vim ecosystem is limited. And also, the delays between your answers leads me to lose context.

Please ask for a review from someone related to the Vim ecosystem.

I am willing to review

Please, drop the last 3 commits and include changes only related to this plugin:
  # generated.nix
  vim-pets = buildVimPlugin {
    pname = "vim-pets";
    version = "2024-07-26";
    src = fetchFromGitHub {
      owner = "MeF0504";
      repo = "vim-pets";
      rev = "17d33f160c8fd3fb6492e7cd76f397ddaa26ad8d";
      sha256 = "0zn6kf088kqfdf5y0x6sd8rr3skrjwppsdfxmf044qk1h07lcgcc";
    };
    meta.homepage = "https://github.com/MeF0504/vim-pets/";
  };

@PerchunPak, I believe I have done what you requested on the latest push, please let me know if you need any further follow up from me.

Result of nixpkgs-review pr 260055 run on x86_64-linux 1

2 packages built:

vimPlugins.vim-pets
vimPluginsUpdater

Result of nixpkgs-review pr 260055 run on x86_64-linux 1

2 packages built:

vimPlugins.vim-pets
vimPluginsUpdater


Application crash in /solid/lib/Controller/AppController.php

Hi, I just installed this app only to see what it's all about, but could not do anything with it:
Whenever I access '/apps/solid/', I get the NextCloud's internal server error (HTTP 500).
In the NextCloud's  logs, I get 3 error entries:

[PHP] Error: Undefined variable $userClients at /var/www/html/custom_apps/solid/lib/Controller/AppController.php#37
GET /apps/solid/
from <IP_ADDRESS> by aa at 2021-12-30T15:55:09+00:00
[PHP] Error: foreach() argument must be of type array|object, null given at /var/www/html/custom_apps/solid/lib/Controller/AppController.php#37
GET /apps/solid/
from <IP_ADDRESS> by aa at 2021-12-30T15:55:09+00:00
[index] Error: in_array(): Argument # 2 ($haystack) must be of type array, string given in file '/var/www/html/custom_apps/solid/lib/Controller/AppController.php' line 55
GET /apps/solid/
from <IP_ADDRESS> by aa at 2021-12-30T15:55:09+00:00

'not too sure what's happenning here.
NextCloud v<IP_ADDRESS>
PHP 8.0.14
Apache 2.4.51 from Docker image nextcloud:23.0.0-apache

The first 2 seem to be related  to me.
The line 37 refers to variable $userClients. I searched for it but could not find it anywhere and var_dump() tells me it's indeed null...
I tried to replace it by $allowedClients (an empty array) right above and it seemed to fix (?)
The call to in_array() at line 55 seem to not like the $origin variable. Here's the result of its "var_dump()": string(24) "notepod.vincenttunru.com".
I tried replacing the line by if(false) and the screen could load successfully (?). Not too sure where to go from here (ie. don't know enough of PHP since I'm a bit allergic to it ;-) ).

Full log entry dump:
{"reqId":"MPLFyLESE9hEFsEbktAC","level":3,"time":"2021-12-30T15:55:09+00:00","remoteAddr":"<IP_ADDRESS>","user":"aa","app":"PHP","method":"GET","url":"/apps/solid/","message":"Undefined variable $userClients at /var/www/html/custom_apps/solid/lib/Controller/AppController.php#37","userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36 Edg/96.0.1054.62","version":"<IP_ADDRESS>","exception":{"Exception":"Error","Message":"Undefined variable $userClients at /var/www/html/custom_apps/solid/lib/Controller/AppController.php#37","Code":0,"Trace":[{"file":"/var/www/html/custom_apps/solid/lib/Controller/AppController.php","line":37,"function":"onError","class":"OC\\Log\\ErrorHandler","type":"::","args":[2,"Undefined variable $userClients","/var/www/html/custom_apps/solid/lib/Controller/AppController.php",37]},{"file":"/var/www/html/custom_apps/solid/lib/Controller/AppController.php","line":50,"function":"getUserApps","class":"OCA\\Solid\\Controller\\AppController","type":"->","args":["aa"]},{"file":"/var/www/html/custom_apps/solid/lib/Controller/AppController.php","line":77,"function":"getAppsList","class":"OCA\\Solid\\Controller\\AppController","type":"->","args":[]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":217,"function":"appLauncher","class":"OCA\\Solid\\Controller\\AppController","type":"->","args":[]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":126,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Solid\\Controller\\AppController","contactsManager":{"__class__":"OC\\ContactsManager"}},"appLauncher"]},{"file":"/var/www/html/lib/private/AppFramework/App.php","line":157,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Solid\\Controller\\AppController","contactsManager":{"__class__":"OC\\ContactsManager"}},"appLauncher"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Solid\\Controller\\AppController","appLauncher",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"_route":"solid.app.appLauncher"}]},{"file":"/var/www/html/lib/base.php","line":1006,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/solid/"]},{"file":"/var/www/html/index.php","line":36,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/html/lib/private/Log/ErrorHandler.php","Line":92,"CustomMessage":"--"},"id":"61cdd65e291f0"}

{"reqId":"MPLFyLESE9hEFsEbktAC","level":3,"time":"2021-12-30T15:55:09+00:00","remoteAddr":"<IP_ADDRESS>","user":"aa","app":"PHP","method":"GET","url":"/apps/solid/","message":"foreach() argument must be of type array|object, null given at /var/www/html/custom_apps/solid/lib/Controller/AppController.php#37","userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36 Edg/96.0.1054.62","version":"<IP_ADDRESS>","exception":{"Exception":"Error","Message":"foreach() argument must be of type array|object, null given at /var/www/html/custom_apps/solid/lib/Controller/AppController.php#37","Code":0,"Trace":[{"file":"/var/www/html/custom_apps/solid/lib/Controller/AppController.php","line":37,"function":"onError","class":"OC\\Log\\ErrorHandler","type":"::","args":[2,"foreach() argument must be of type array|object, null given","/var/www/html/custom_apps/solid/lib/Controller/AppController.php",37]},{"file":"/var/www/html/custom_apps/solid/lib/Controller/AppController.php","line":50,"function":"getUserApps","class":"OCA\\Solid\\Controller\\AppController","type":"->","args":["aa"]},{"file":"/var/www/html/custom_apps/solid/lib/Controller/AppController.php","line":77,"function":"getAppsList","class":"OCA\\Solid\\Controller\\AppController","type":"->","args":[]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":217,"function":"appLauncher","class":"OCA\\Solid\\Controller\\AppController","type":"->","args":[]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":126,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Solid\\Controller\\AppController","contactsManager":{"__class__":"OC\\ContactsManager"}},"appLauncher"]},{"file":"/var/www/html/lib/private/AppFramework/App.php","line":157,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Solid\\Controller\\AppController","contactsManager":{"__class__":"OC\\ContactsManager"}},"appLauncher"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Solid\\Controller\\AppController","appLauncher",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"_route":"solid.app.appLauncher"}]},{"file":"/var/www/html/lib/base.php","line":1006,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/solid/"]},{"file":"/var/www/html/index.php","line":36,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/html/lib/private/Log/ErrorHandler.php","Line":92,"CustomMessage":"--"},"id":"61cdd65e29140"}

{"reqId":"MPLFyLESE9hEFsEbktAC","level":3,"time":"2021-12-30T15:55:09+00:00","remoteAddr":"<IP_ADDRESS>","user":"aa","app":"index","method":"GET","url":"/apps/solid/","message":"in_array(): Argument #2 ($haystack) must be of type array, string given in file '/var/www/html/custom_apps/solid/lib/Controller/AppController.php' line 55","userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36 Edg/96.0.1054.62","version":"<IP_ADDRESS>","exception":{"Exception":"Exception","Message":"in_array(): Argument #2 ($haystack) must be of type array, string given in file '/var/www/html/custom_apps/solid/lib/Controller/AppController.php' line 55","Code":0,"Trace":[{"file":"/var/www/html/lib/private/AppFramework/App.php","line":157,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Solid\\Controller\\AppController","contactsManager":{"__class__":"OC\\ContactsManager"}},"appLauncher"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Solid\\Controller\\AppController","appLauncher",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"_route":"solid.app.appLauncher"}]},{"file":"/var/www/html/lib/base.php","line":1006,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/solid/"]},{"file":"/var/www/html/index.php","line":36,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","Line":158,"Previous":{"Exception":"TypeError","Message":"in_array(): Argument #2 ($haystack) must be of type array, string given","Code":0,"Trace":[{"file":"/var/www/html/custom_apps/solid/lib/Controller/AppController.php","line":55,"function":"in_array","args":[[],"notepod.vincenttunru.com"]},{"file":"/var/www/html/custom_apps/solid/lib/Controller/AppController.php","line":77,"function":"getAppsList","class":"OCA\\Solid\\Controller\\AppController","type":"->","args":[]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":217,"function":"appLauncher","class":"OCA\\Solid\\Controller\\AppController","type":"->","args":[]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":126,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Solid\\Controller\\AppController","contactsManager":{"__class__":"OC\\ContactsManager"}},"appLauncher"]},{"file":"/var/www/html/lib/private/AppFramework/App.php","line":157,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Solid\\Controller\\AppController","contactsManager":{"__class__":"OC\\ContactsManager"}},"appLauncher"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Solid\\Controller\\AppController","appLauncher",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"_route":"solid.app.appLauncher"}]},{"file":"/var/www/html/lib/base.php","line":1006,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/solid/"]},{"file":"/var/www/html/index.php","line":36,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/html/custom_apps/solid/lib/Controller/AppController.php","Line":55},"CustomMessage":"--"},"id":"61cdd65e29087"}

Hi! Thank you for taking the time to report this! Kudos for also diving into the code.
A certain kind of mind is certainly required when dealing with PHP. That's what we're here for, doing the PHP so you don't have to! :grin:
Anyway, I've just taken a look at the code, both problems are developer mistakes. 😰

The $userClients error is a developer copy/paste mistake.
The $origin problem is caused by the needle and haystack being in the wrong order.

I've gone through the other controllers as a precaution and added fixes for some other potential bugs.
That should at least fix these issues, though others might be lurking deeper in the code.
Once #63 has been reviewed and merged, we need to deploy a release with those changes to the NC app store before you can start using them.


Update console.md

In recent versions, the library folder has been renamed to 64bits. Also remove extra / while we are touching this.

@dlech : Thanks for your contribution! The author(s) have been notified to review your proposed change. @migueldeicaza


esp32-s3 i2c failure in esp-idf 5.2 (IDFGH-12268)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.2
Espressif SoC revision.
esp32-s3
Operating System used.
macOS
How did you build your project?
VS Code IDE
If you are using Windows, please specify command line type.
None
Development Kit.
n/a
Power Supply used.
USB
What is the expected behavior?
I recently upgraded my setup from esp-idf 5.1.2 to 5.2, and am trying to write a driver for a magnetic encoder that configures the chip via i2c. This code/driver runs fine on an esp32-c3 seeed module I have, but fails the same way on two different esp32-s3 boards I've tried. I don't understand the error that's being offered. I am using:
#include "driver/i2c_master.h"
and the failure occurs when I try creating a new master bus like so:
    // https://docs.espressif.com/projects/esp-idf/en/v5.2/esp32/api-reference/peripherals/i2c.html#i2c_master_controller
    // We are configuring the i2c master bus first.
    i2c_master_bus_config_t i2c_master_config = {
        .clk_source = I2C_CLK_SRC_DEFAULT,
        .i2c_port = I2C_MASTER_PORT,
        .scl_io_num = I2C_MASTER_SCL_IO,        // SCL pin
        .sda_io_num = I2C_MASTER_SDA_IO,        // SCL pin
        .glitch_ignore_cnt = 7,                 // a default from esp's docs
        .flags.enable_internal_pullup = true,
    };

    i2c_master_bus_handle_t bus_handle;
    i2c_new_master_bus(&i2c_master_config, &bus_handle);

For other boards, the above code runs fine - a new master bus handle is created and I can probe it for i2c devices.
What is the actual behavior?
Instead of a new master bus handle, my code seems to fail when trying to create the new master bus, providing an output message that I don't find helpful for troubleshooting. It does not crash outright, but instead provides this error message:
assert failed: xTaskRemoveFromEventList tasks.c:3826 (pxUnblockedTCB)

Backtrace: 0x403758e2:0x3fc9a2b0 0x40379ed1:0x3fc9a2d0 0x40380371:0x3fc9a2f0 0x4037bec2:0x3fc9a410 0x4037a744:0x3fc9a430 0x4037a7f6:0x3fc9a470 0x40376865:0x3fc9a490 0x40376945:0x3fc9a4c0 0x420082b3:0x3fc9a4e0 0x42006e61:0x3fc9a500 0x420069d2:0x3fc9a520 0x4200f77e:0x3fc9a540 0x4200ef4d:0x3fc9a560 0x4200efaa:0x3fc9a580 0x4200f5e9:0x3fc9a5b0 0x420136b7:0x3fc9a5e0 0x4201307a:0x3fc9a600 0x4200f7f5:0x3fc9a920 0x4201b565:0x3fc9a950 0x403800e5:0x3fc9a980 0x42009b8d:0x3fc9a9d0 0x4200b6fe:0x3fc9aa30 0x4200a925:0x3fc9aa90 0x4200ae88:0x3fc9aac0 0x4200834c:0x3fc9ab10 0x4037a8c1:0x3fc9ab60
0x403758e2: panic_abort at /Users/me/dev/github/esp-idf-v5.2/components/esp_system/panic.c:472
0x40379ed1: esp_system_abort at /Users/me/dev/github/esp-idf-v5.2/components/esp_system/port/esp_system_chip.c:93
0x40380371: __assert_func at /Users/me/dev/github/esp-idf-v5.2/components/newlib/assert.c:81
0x4037bec2: xTaskRemoveFromEventList at /Users/me/dev/github/esp-idf-v5.2/components/freertos/FreeRTOS-Kernel/tasks.c:3826 (discriminator 1)
0x4037a744: xQueueSemaphoreTake at /Users/me/dev/github/esp-idf-v5.2/components/freertos/FreeRTOS-Kernel/queue.c:1763
0x4037a7f6: xQueueTakeMutexRecursive at /Users/me/dev/github/esp-idf-v5.2/components/freertos/FreeRTOS-Kernel/queue.c:835
0x40376865: lock_acquire_generic at /Users/me/dev/github/esp-idf-v5.2/components/newlib/locks.c:144
0x40376945: _lock_acquire_recursive at /Users/me/dev/github/esp-idf-v5.2/components/newlib/locks.c:158
0x420082b3: uart_write at /Users/me/dev/github/esp-idf-v5.2/components/vfs/vfs_uart.c:209
0x42006e61: console_write at /Users/me/dev/github/esp-idf-v5.2/components/vfs/vfs_console.c:73 (discriminator 1)
0x420069d2: esp_vfs_write at /Users/me/dev/github/esp-idf-v5.2/components/vfs/vfs.c:482 (discriminator 4)
0x4200f77e: __swrite at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/stdio.c:94
0x4200ef4d: __sflush_r at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/fflush.c:224
0x4200efaa: _fflush_r at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/fflush.c:278
 (inlined by) _fflush_r at /builds/idf/crosstool-NG/.build/src/newlib-git-af24ceb7/newlib/libc/include/stdio.h:417
0x4200f5e9: __sfvwrite_r at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/fvwrite.c:251
0x420136b7: __sprint_r at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/vfiprintf.c:429
 (inlined by) __sprint_r at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/vfprintf.c:399
0x4201307a: _vfprintf_r at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/vfprintf.c:1774 (discriminator 1)
0x4200f7f5: vprintf at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/vprintf.c:34
0x4201b565: esp_log_writev at /Users/me/dev/github/esp-idf-v5.2/components/log/log.c:215
0x403800e5: esp_log_write at /Users/me/dev/github/esp-idf-v5.2/components/log/log.c:225
0x42009b8d: gpio_config at /Users/me/dev/github/esp-idf-v5.2/components/driver/gpio/gpio.c:408 (discriminator 1)
0x4200b6fe: i2c_common_set_pins at /Users/me/dev/github/esp-idf-v5.2/components/driver/i2c/i2c_common.c:235
0x4200a925: i2c_param_master_config at /Users/me/dev/github/esp-idf-v5.2/components/driver/i2c/i2c_master.c:642
0x4200ae88: i2c_new_master_bus at /Users/me/dev/github/esp-idf-v5.2/components/driver/i2c/i2c_master.c:799
0x4200834c: i2c_scan_task at /Users/me/dev/esp/i2c-scan/main/i2c-scan.c:62
0x4037a8c1: vPortTaskWrapper at /Users/me/dev/github/esp-idf-v5.2/components/freertos/FreeRTOS-Kernel/portable/xtensa/port.c:134

Steps to reproduce.

#include <stdio.h>
#include "freertos/FreeRTOS.h"
#include "freertos/task.h"
#include "driver/i2c_master.h"

#define I2C_MASTER_SCL_IO 9        /*!< GPIO number for I2C master clock */
#define I2C_MASTER_SDA_IO 10        /*!< GPIO number for I2C master data  */
#define I2C_MASTER_PORT I2C_NUM_0    /*!< I2C port number for master dev */
#define I2C_MASTER_FREQ_HZ 400000   /*!< I2C master clock frequency  - FAST MODE */

static void i2c_scan_task(void *arg) {

     // -------------------------
    // Configure i2c

    // Per these docs:
    // https://docs.espressif.com/projects/esp-idf/en/v5.2/esp32/api-reference/peripherals/i2c.html#i2c_master_controller
    // We are configuring the i2c master bus first.
    i2c_master_bus_config_t i2c_master_config = {
        .clk_source = I2C_CLK_SRC_DEFAULT,
        .i2c_port = I2C_MASTER_PORT,
        .scl_io_num = I2C_MASTER_SCL_IO,        // SCL pin
        .sda_io_num = I2C_MASTER_SDA_IO,        // SCL pin
        .glitch_ignore_cnt = 7,                 // a default from esp's docs
        .flags.enable_internal_pullup = true,
    };

    i2c_master_bus_handle_t bus_handle;
    i2c_new_master_bus(&i2c_master_config, &bus_handle);
    /// this is the point at which this code fails. It does not exit entirely; instead I just
    /// enter the below loop infinitely producing the same error message(s) over and over.

    while (1) {

        printf("Scanning I2C bus...\n");

        // for (uint8_t addr = 0x08; addr < 0x78; addr++) {
        for (uint8_t addr = 1; addr < 127; addr++) {

            esp_err_t error_status = i2c_master_probe(bus_handle, addr, -1);

            // If we received the ACK bit, we found something! Print its address.
            if (error_status == ESP_OK) {
                printf("Found device at address %d (0x%02X)\n", addr, addr);

                uint8_t write_address = (addr << 1) | 0;
                uint8_t read_address = (addr << 1) | 1;

                printf("Write address: %d (0x%02X)\n", write_address, write_address);
                printf("Read address: %d (0x%02X)\n", read_address, read_address);

            }
         }

        vTaskDelay(2000 / portTICK_PERIOD_MS); // Wait 2 seconds before rescanning.
    }

}

void app_main() {
    xTaskCreate(i2c_scan_task, "i2c_scan_task", 2048, NULL, tskIDLE_PRIORITY, NULL);
}

Debug Logs.
assert failed: xTaskRemoveFromEventList tasks.c:3826 (pxUnblockedTCB)

Backtrace: 0x403758e2:0x3fc9a2b0 0x40379ed1:0x3fc9a2d0 0x40380371:0x3fc9a2f0 0x4037bec2:0x3fc9a410 0x4037a744:0x3fc9a430 0x4037a7f6:0x3fc9a470 0x40376865:0x3fc9a490 0x40376945:0x3fc9a4c0 0x420082b3:0x3fc9a4e0 0x42006e61:0x3fc9a500 0x420069d2:0x3fc9a520 0x4200f77e:0x3fc9a540 0x4200ef4d:0x3fc9a560 0x4200efaa:0x3fc9a580 0x4200f5e9:0x3fc9a5b0 0x420136b7:0x3fc9a5e0 0x4201307a:0x3fc9a600 0x4200f7f5:0x3fc9a920 0x4201b565:0x3fc9a950 0x403800e5:0x3fc9a980 0x42009b8d:0x3fc9a9d0 0x4200b6fe:0x3fc9aa30 0x4200a925:0x3fc9aa90 0x4200ae88:0x3fc9aac0 0x4200834c:0x3fc9ab10 0x4037a8c1:0x3fc9ab60
0x403758e2: panic_abort at /Users/me/dev/github/esp-idf-v5.2/components/esp_system/panic.c:472
0x40379ed1: esp_system_abort at /Users/me/dev/github/esp-idf-v5.2/components/esp_system/port/esp_system_chip.c:93
0x40380371: __assert_func at /Users/me/dev/github/esp-idf-v5.2/components/newlib/assert.c:81
0x4037bec2: xTaskRemoveFromEventList at /Users/me/dev/github/esp-idf-v5.2/components/freertos/FreeRTOS-Kernel/tasks.c:3826 (discriminator 1)
0x4037a744: xQueueSemaphoreTake at /Users/me/dev/github/esp-idf-v5.2/components/freertos/FreeRTOS-Kernel/queue.c:1763
0x4037a7f6: xQueueTakeMutexRecursive at /Users/me/dev/github/esp-idf-v5.2/components/freertos/FreeRTOS-Kernel/queue.c:835
0x40376865: lock_acquire_generic at /Users/me/dev/github/esp-idf-v5.2/components/newlib/locks.c:144
0x40376945: _lock_acquire_recursive at /Users/me/dev/github/esp-idf-v5.2/components/newlib/locks.c:158
0x420082b3: uart_write at /Users/me/dev/github/esp-idf-v5.2/components/vfs/vfs_uart.c:209
0x42006e61: console_write at /Users/me/dev/github/esp-idf-v5.2/components/vfs/vfs_console.c:73 (discriminator 1)
0x420069d2: esp_vfs_write at /Users/me/dev/github/esp-idf-v5.2/components/vfs/vfs.c:482 (discriminator 4)
0x4200f77e: __swrite at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/stdio.c:94
0x4200ef4d: __sflush_r at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/fflush.c:224
0x4200efaa: _fflush_r at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/fflush.c:278
 (inlined by) _fflush_r at /builds/idf/crosstool-NG/.build/src/newlib-git-af24ceb7/newlib/libc/include/stdio.h:417
0x4200f5e9: __sfvwrite_r at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/fvwrite.c:251
0x420136b7: __sprint_r at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/vfiprintf.c:429
 (inlined by) __sprint_r at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/vfprintf.c:399
0x4201307a: _vfprintf_r at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/vfprintf.c:1774 (discriminator 1)
0x4200f7f5: vprintf at /builds/idf/crosstool-NG/.build/HOST-x86_64-apple-darwin21.1/xtensa-esp-elf/src/newlib/newlib/libc/stdio/vprintf.c:34
0x4201b565: esp_log_writev at /Users/me/dev/github/esp-idf-v5.2/components/log/log.c:215
0x403800e5: esp_log_write at /Users/me/dev/github/esp-idf-v5.2/components/log/log.c:225
0x42009b8d: gpio_config at /Users/me/dev/github/esp-idf-v5.2/components/driver/gpio/gpio.c:408 (discriminator 1)
0x4200b6fe: i2c_common_set_pins at /Users/me/dev/github/esp-idf-v5.2/components/driver/i2c/i2c_common.c:235
0x4200a925: i2c_param_master_config at /Users/me/dev/github/esp-idf-v5.2/components/driver/i2c/i2c_master.c:642
0x4200ae88: i2c_new_master_bus at /Users/me/dev/github/esp-idf-v5.2/components/driver/i2c/i2c_master.c:799
0x4200834c: i2c_scan_task at /Users/me/dev/esp/i2c-scan/main/i2c-scan.c:62
0x4037a8c1: vPortTaskWrapper at /Users/me/dev/github/esp-idf-v5.2/components/freertos/FreeRTOS-Kernel/portable/xtensa/port.c:134

More Information.
I have tried specifying different pins for I2C, and tried a few different esp32-s3 boards from different manufacturers, all with the same result.

Seems that 2048 in your task create is not sufficient. Please try 4096.

Thank you! Increasing the task allocation to 4096 does indeed make these errors go away. However, my microcontroller still seems unable to communicate via i2c with an attached device.
When I run the above code on an esp32-c3, I see it output the following:
Scanning I2C bus...
Found device at address 54 (0x36)
Write address: 108 (0x6C)
Read address: 109 (0x6D)

However, running the same code on an identical circuit setup using an s3 produces:
Scanning I2C bus...
Scanning I2C bus...
Scanning I2C bus...
Scanning I2C bus...
Scanning I2C bus...
Scanning I2C bus...

I've tried different pins, but can't seem to produce a different result.

Don't know you are using v5.2.what. But I tried on the latest 5.2 branch esp32s3 probe works fine with SCL=9 SDA=10 port=0/1. So, is it possible to try latest 5.2? And paste logic analyzer on I2C bus if possible. That helps us go forward.

I'm also have i2c errors in v5.1.2
	  > E (19574) i2c: ack error
	  > E (19574) i2c: i2c_master_cmd_begin failed

AFAIK this code used to work in v4.4.X.
Still debugging it.

The problem seems is the device address.
I try it with a I2C oled with ssd1306.
The device is 0b01111000, and the last bit is used for R/W.
We usually called the device address is 0x78 = 0x01111000. And when I use 0x78 with old i2c driver, it's works. But if I use the 0x78 with new i2c_master driver, it's wrong.
So I changed the address to 0b0111100 = 0x3C, it's works again!
`
i2c_master_bus_config_t i2c_conf = {
.clk_source = I2C_CLK_SRC_DEFAULT,
.i2c_port = I2C_NUM_1,
.scl_io_num = OLED_SCL_PIN,
.sda_io_num = OLED_SDA_PIN,
.glitch_ignore_cnt = 7,
.flags.enable_internal_pullup = true,
};
i2c_master_bus_handle_t i2c_bus_handle;
ESP_ERROR_CHECK(i2c_new_master_bus(&i2c_conf, &i2c_bus_handle));
i2c_device_config_t i2c_dev_cfg = {
	.dev_addr_length = I2C_ADDR_BIT_LEN_7,
	.device_address = 0x3C,
	.scl_speed_hz = 400000,
};
i2c_master_dev_handle_t i2c_oled_handle;
ESP_ERROR_CHECK(i2c_master_bus_add_device(i2c_bus_handle, &i2c_dev_cfg, &i2c_oled_handle));

`

@ahemberger Did you success on s3 on latest 5.2?

Hi, @ahemberger I tried with my esp32s3 board on latest v5.2 with your code and your io pins. That I cannot reproduce the issue. I'm using ssd1306 as a device. The code is almost as same as yours as following:
    i2c_master_bus_config_t i2c_mst_config_1 = {
        .clk_source = I2C_CLK_SRC_DEFAULT,
        .i2c_port = 0,
        .scl_io_num = 9,
        .sda_io_num = 10,
        .glitch_ignore_cnt = 7,
        .flags.enable_internal_pullup = true,
    };
    i2c_master_bus_handle_t bus_handle;

    TEST_ESP_OK(i2c_new_master_bus(&i2c_mst_config_1, &bus_handle));
    for (uint8_t addr = 0; addr < 127; addr++) {
        esp_err_t error_status = i2c_master_probe(bus_handle, addr, -1);

            // If we received the ACK bit, we found something! Print its address.
            if (error_status == ESP_OK) {
                printf("Found device at address %d (0x%02X)\n", addr, addr);

                uint8_t write_address = (addr << 1) | 0;
                uint8_t read_address = (addr << 1) | 1;

                printf("Write address: %d (0x%02X)\n", write_address, write_address);
                printf("Read address: %d (0x%02X)\n", read_address, read_address);

            }
    }

If you still fail on v5.2, it would be helpful if you paste a logic analyzer picture around your truly address, I want to see what really happens.
(If there is no further respond in several days, I'm going to conclude this issue~) Thank you.

Hi!
I confess I did not previously own a logic analyzer, so I bought one to try to address this request and better-understand what was going on. The answer is ultimately both embarassing and infuriating (TL;DR, idf 5.2 and 5.2.1 both work fine - the initial observation you made about using a larger stack size is actually what unstuck me). But if you're curious:
The esp32-s3 board I have been using is this one from seeed:
https://www.amazon.com/dp/B0BYSB66S5?psc=1&ref=ppx_yo2ov_dt_b_product_details
The pinout diagram (about halfway down the product page) shows the pins along the right edge of the board: D10, D9, D8, D7, which are the pins I was trying to use - actually correspond (rather unintuitively, I think) with GPIO pins 9, 8, 7, and 44). The pins on the esp32-c3 seed board have identically-named digital pins, but the GPIO pins also correspond to them. So, basically, I was accidentally using the incorrect pins and didn't notice until my logic analyzer showed me no communication happening where I expected some to be.
 Thank you, and I'm sorry? :)

Thanks for reporting, and sharing the updates, feel free to reopen.


Unable validate secret if secret is cert in der x509

I use:
cert = load_der_x509_certificate(base64.b64decode(config['jwt']['secret']), backend)
secret = cert.public_key()
app = web.Application(
middlewares = [JWTMiddleware(
secret,
algorithms = config['jwt']['algorithms'],
audience = config['jwt']['audience'],
issuer = config['jwt']['issuer']
)]
)
But raise on check secret:
if not (secret_or_pub_key and isinstance(secret_or_pub_key, str)):
raise RuntimeError(
'secret or public key should be provided for correct work',
)
If i disable this check, my token work correctly.
How i can validate token if secret in der-509 ?

Hello, just serialize you key like
serialized = public_key.public_key().public_bytes(
    cryptography.hazmat.primitives.serialization.Encoding.PEM,
    cryptography.hazmat.primitives.serialization.PublicFormat.SubjectPublicKeyInfo,
) # receive bytes here

Also take a look on a similar issue https://github.com/hzlmn/aiohttp-jwt/issues/108

Package from pip doesn't have this patch. Thanks about this!


Video-intelligence: Regeneration

Changes Unknown when pulling f9b918e5365de6f43a665a65d3cf8a9dcddeb045 on landrito:videointelligence into ** on GoogleCloudPlatform:master**.

Changes Unknown when pulling 7454e9e96d35da8f0dd253719011bb4b4cdbcd26 on landrito:videointelligence into ** on GoogleCloudPlatform:master**.

@swcloud Made this simply the generated packages including the docs. I'll address the hand-edits in toolkit.
One hand-edit i needed to do was changing the path and packagename to video-intelligence.

@landrito LGTM except the GAPIC version number. @stephenplusplus may also need to approve it before he merges to the master.


Bad Request: can't parse entities in message text

While running the manual script on my already downloaded Mr Robot, I got this message:
Execute: telegram.py -t "*Mr. Robot*" -m "_S01E01 - eps1.0_hellofriend.mov_ is ready."
OK: False
Error: 400
Description: Bad Request: can't parse entities in message text: Can't find end of the entity starting at byte offset 44
Here's the log for the move command in case it helps
[MOVE] Rename [C:\Users\Bradl\Downloads\torrents\Mr.Robot.Season.1.720p.BluRay.x264.ShAaNiG\Mr.Robot.S01E01.720p.BluRay.x264.ShAaNiG.mkv] to [C:\Users\Bradl\Downloads\torrents\Mr. Robot\Season 1\S01E01 - eps1.0_hellofriend.mov.mkv]
If there's any more details I can provide, please let me know. Once again, thanks for all the help!

Turns out the download wasn't finished, so it had an underscore at the end.
The problem is entirely caused by the user, not the script. Sorry for wasting your time.

Actually, the file name is interfering here. The script uses markdown for formatting, and because of your file name containing an underscore, it brings it to a total of 3 underscores. If you have an odd number of underscores/asterisks in the message, it causes the API to throw this error.


increased precision of CO frequencies

Increased precision of CO frequencies in constants.jl

Thank you... clearly the sig figs on these weren't ideal 📏


[WEEKLY RELEASE] Bump HotShot

Closes #<ISSUE_NUMBER>

This PR:

This PR does not:

Key places to review:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

118 of 124 (95.16%)  changed or added relevant lines in 10 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 89.693%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

crates/legacy/src/service.rs
36
37
97.3%

crates/legacy/src/testing/finalization_test.rs
5
6
83.33%

crates/legacy/src/testing/mod.rs
15
16
93.75%

crates/marketplace/src/testing/mod.rs
12
13
92.31%

crates/shared/src/testing/mock.rs
17
19
89.47%

Totals

Change from base Build<PHONE_NUMBER>6:
0.03%

Covered Lines:
6918

Relevant Lines:
7713

💛  - Coveralls


Fixing text column bulleted bug

[x] Changes have been thoroughly tested to not break existing functionality.

This PR fixes bug #8055

@zepfietje this is the current behavior:

If I remove the flex class from a <li> element the bullet is showing:

Thanks!


#share button is meaningless for secret gist

Might still be good to keep it for user sharing gist with himself/herself, like saving the link to other personal  apps (Evernote).


bboxes example only works if fill is None or has transparency < 1.0

In draw_bboxes.rs line 45 rtree.root().append_kind(usvg::NodeKind::Path(usvg::Path ...) the fill is set to None because otherwise the fill overlays everything. This makes sense as it is appended as a child to the tree. I could not find documentation in usvg to "prepend" to a Tree or to append one Tree to another. Is there some other way to generate a background as the actual background without overlaying on top of all the other elements from the file?
I recognize this might be more of a usvg question, but the repository does not take issues and I'm not certain it is in active development.

I guess you're looking for something like this:
    /// ...

    for bbox in bboxes {
        let node = usvg::Node::new(usvg::NodeKind::Path(usvg::Path {
            id: String::new(),
            transform: usvg::Transform::default(),
            visibility: usvg::Visibility::Visible,
            fill: Some(usvg::Fill {
                paint: usvg::Paint::Color(usvg::Color::black()),
                opacity: usvg::Opacity::new(0.2),
                rule: usvg::FillRule::default(),
            }),
            stroke: stroke.clone(),
            rendering_mode: usvg::ShapeRendering::default(),
            data: Rc::new(usvg::PathData::from_rect(bbox)),
        }));

        rtree.root().prepend(node);
    }

    /// ...

See rctree documentation for details.
usvg is part of resvg. They are developed in parallel.

Thank you so much. That is perfect. I missed the documentation that said usvg::Node is an "Alias for rctree::Node."


Feature: Relationships add type

Current Behavior
Relationships have kind and subtype, which is not enough to accurately identify a given relationship definition.
Desired Behavior
Add type as a first-class property of the Relationship schema.
Implementation

[ ] 1. Revise Relationship schema to include new property. Include field validation and description.
[ ] 2. Version and release this new schema.
[ ] 3. Open issue in github.com/meshery/meshkit to support this new property.
[ ] 4. Open issue in github.com/meshery/meshery to support type in REST API.
[ ] 5. Add field type and initial values to existing relationship definitions in Meshery Integrations sheet.
[ ] 6. Support type in Registry in Meshery UI

Acceptance Tests

Users can see all Relationships by type in Meshery Registry.

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@RipulHandoo @pandeyshubham03 @MUzairS15 @Yashsharma1911 edit this issue's description to add your github handle next to the items that you will undertake.

Gents, I can take assignment of this if needed.

Number 1 has been taken care of. @RipulHandoo prep the existing relationships, please.


Add splash category to DamageDiceRuleElement

{
  "key": "DamageDice",
  "category": "splash",
  "diceNumber": 1,
  "dieSize": "d4",
  "selector": "strike-damage",
  "damageType": "bludgeoning"
}

{
  "key": "DamageDice",
  "category": "splash",
  "modifier":"2",
  "selector": "strike-damage",
  "damageType": "acid"
}

{
  "key": "DamageDice",
  "category": "splash",
  "diceNumber": 1,
  "dieSize": "d4",
  "modifier":"2",
  "selector": "strike-damage",
  "damageType": "acid"
}

Mixing modifier and dieSize/dieNumber like the last example will work but produce a damage instance like this:

I just noticed the second example doesn't have flavor for the splash damage

This also breaks the damage roll tooltip for some reason. Needs more work.


Gauge get's black - Enable alerting ON

If I enable "Enable alerting" on Data Sources, if a trigger on Zabbix is activated and it's defined on Grafana as a Gauge, then the gauge get's black with no values. Not only the one defined with the trigger, all gauges in the dashboard happens the same.
Software versions
Grafana 6.4.1
Zabbix 4.2.6
Zabbix Plugin 3.10.4

In screenshots, only the first one gauge has an alert, the other ones are UP.


Improve ado validation resiliency and error message

### Tasks
- [ ] If we fail to connect to ADO with an error that seems transient (ex: `Exception: System.Net.Http.HttpRequestException: No such host is known. (dev.azure.com:443) ---> System.Net.Sockets.SocketException (11001): No such host is known.`), we should retry a couple of times.
- [ ] Create and return a new general 'ado connection failed' error when the issue is not authentication based

https://github.com/microsoft/onefuzz/blob/be56814e439f43f8a312940f14fc6f040d1994c5/src/ApiService/ApiService/onefuzzlib/notifications/Ado.cs#L72-L80
AB#152444

We should also pool VssConnection since it does a sign-in and is IDisposable.


Model filenames get truncated when they contain multiple '.' characters in the filename when using the Toolkit tab.

Similar issue to https://github.com/arenasys/stable-diffusion-webui-model-toolkit/issues/27, but was not fixed for the Toolkit tab.
There exists this line in scripts/toolkit_gui.py's get_name(tm, arch) function on line 367:
name = os.path.basename(tm.filename).split(".")[0]
it should read something like this:
name = os.path.basename(tm.filename).rsplit(".", 1)[0]

I created a pull request with the change in it. The actual change is 1 line, but my editor decided to eliminate trailing whitespace so that's why there are so many lines touched.


Not convert between currencies

Current coverage is 95.95%

Merging #4 into master will decrease coverage by -0.61% as of 233c1db

@@            master      #4   diff @@
======================================
  Files           24      22     -2
  Stmts          727     668    -59
  Branches        93      82    -11
  Methods          0       0
======================================
- Hit            702     641    -61
  Partial         10      10
- Missed          15      17     +2

Review entire Coverage Diff as of 233c1db

Uncovered Suggestions

+0.45% via ...e/mysql/withdrawl.go#24...26
+0.45% via ...rage/mysql/income.go#44...46
+0.45% via ...e/mysql/withdrawl.go#18...20
See 7 more...

Powered by Codecov. Updated on successful CI builds.


Update AppFlow 18.6.0->51.0.0

Updates AppFlow to the latest version. Resolves #1986. Includes support for:

LookoutMetrics, Upsolver, and Zendesk connectors
Configurable incremental pulls
Time offsets for scheduled jobs

Thanks for this change. I saw a couple of automated changes that are needed. Could you run both make fix-black and make fix-isort to fix them up?

Done!

Thanks!


[BAEL-12669] - Check modules that don't use our standard parents

Can one of the admins verify this patch?


Selecting references entry

DH entry about the 'selecting references' feature and content changes we made to make the process clearer to candidates.
(Copied an existing DH entry and then populated it with content for this entry)

Preview post

@B-Bonner maybe we could say why we decided to do this, to give some context for the change

It'd be good to have some context about why - although this might have been a 'just because' moment!

Preview link


[Quest 3/Pro] ERROR Handshake error for 5185.client: EOF while parsing a value at line 1 column 0

Description
https://aur.archlinux.org/packages/alvr-git + apk from https://github.com/alvr-org/ALVR-nightly/releases/tag/v21.0.0-dev00%2Bnightly.2024.02.18 result in ERROR Handshake error for 5185.client: EOF while parsing a value at line 1 column 0 on both Quest 3 and Pro.
Alvr v20 works on both.
Installation
ALVR Version: https://aur.archlinux.org/packages/alvr-git + apk from https://github.com/alvr-org/ALVR-nightly/releases/tag/v21.0.0-dev00%2Bnightly.2024.02.18
ALVR Settings File: default (after deleting)
SteamVR Version:  https://archlinux.org/packages/multilib/x86_64/steam/
6.7.5-arch1-1.
KDE Plasma 6 rc2.
NVidia 550 beta.

same for me

The latest build works for me.

The bug returned on v<IP_ADDRESS>


Y.js V2 Update Format

(I didn't find anything in docs on this.)
Please support Y.js V2 Update Format, which provides much better compression.
https://github.com/yjs/yjs#using-v2-update-format

Yeah we should do this, but I don't think it'll happen soon; we'd have to make sure it' backward compatible with existing projects/persisted data. Happy to review a PR.

How's about making it a opt-in, so it's easier to get started? New projects could start with V2, and get the performance benefits, right away!

@threepointone  What do you think about the previous idea mentioned? If you could outline how this first opt-in version can be added, I'm open to give it a try.

I think just adding an option to YPartyKitProvider would work. So something like { updateProtocol: 'V1' } then using that as a flag to either transform the  incoming update via the helper function convertUpdateFormatV1ToV2 or just directly pass the update.


not able to use mysql async inside a msps receiver

I want to listen on a receiver of a channel and for each element, i want to fire my query to database. Here is my code
fn sql_conn(handle : &tokio_core::reactor::Handle, rx:futures::sync::mpsc::Receiver<ChannelHolder>){
    let database_url = "mysql://suraj:Suraj@<IP_ADDRESS>:9106/yuka";
    let pool = my::Pool::new(database_url, handle);
    println!("Amount is 123");
    let f2 = rx.for_each(move|res| {
    let future = pool.clone().get_conn().and_then(|conn| {
        // Load payments from database.
        // conn.prep_exec("SELECT txnid, amount FROM txn_update where txnid=6959177461", ())
        conn.prep_exec("SELECT `key`, `value` FROM `config` where isactive=1", ())
    }).and_then(|result| {
        // Collect payments
        result.map_and_drop(|row| {
            let (txnid, value):(String, Option<String>) = my::from_row(row);
            match value.clone(){
                Some(x) => {
                    println!("key:value is {}: {}", txnid, x);
                    GLOBAL_CONFIG_CACHE.write().unwrap().insert(txnid.clone(), value.clone());
                },
                None    => println!("null value"),
            }
        })
    }).and_then(|(_ /* conn */, value1)| {
        // The destructor of a connection will return it to the pool,
        // but pool should be disconnected explicitly because it's
        // an asynchronous procedure.
        pool.disconnect().map(|_| value1)
    });
    handle.spawn(future.then(|_| Ok(())));
    Ok(())
    });
}

I am getting below error
error[E0507]: cannot move out of captured outer variable in an FnMut closure
--> src/main.rs:559:17
|
540 |     let pool = my::Pool::new(database_url, handle);
|         ---- captured outer variable
...
559 |     }).and_then(|(_ /* conn */, value1)| {
|                 ^^^^^^^^^^^^^^^^^^^^^^^^ cannot move out of captured outer variable in an FnMut closure

Hi and sorry for late response.
The problem here is unrelated to the library and described on stackoverflow.
The closure that may be called multiple times here is the for_each handler on rx. So to fix this you need to clone and move pool into the last and_then handler.


Distance between camera and subject

Hi!
I am photographing a business card.
When I set the resolution to 1600x900, I have to move the phone 8-10 cm from the object than when setting the default resolution. And the higher the resolution, the farther from the object.
How to make the distance smaller with higher resolution?

@araimbekoff Is it something we can control with this component?


Handle Llama 3.2 chat template

This is a work in progress, and I'm not sure how to proceed, since I'm not very familiar with Jinja or this package. I think I managed to solve the test for if tools is defined, but now it's failing when it tries to iterate through an undefined tools.

The chat template of Llama3.2 uses tojson, but Swift Jinja has not been implemented yet. You can refer to the commits of jinja.js for porting.
https://github.com/huggingface/huggingface.js/commit/78e6a5eb81c63446c03cba8bd2325d8124c171be
https://github.com/huggingface/huggingface.js/commit/717d69d8ad11e90dde79ebda416d0127ee8dc56a

Would you be willing to become a Swift Jinja Collaborator? I hope to find like-minded partners to co-build Swift Jinja, as my abilities are limited on my own.

Sure, I'm happy to help out, although Jinja and the way it's used in these chat templates are still quite new to me.

The chat template of Llama3.2 uses tojson, but Swift Jinja has not been implemented yet. You can refer to the commits of jinja.js for porting.
huggingface/huggingface.js@78e6a5e huggingface/huggingface.js@717d69d

I think this line is not being evaluated as false:
{%- if tools is not none %}

Because then it tries to iterate over tools, which is not iterable when it is none.

The chat template of Llama3.2 uses tojson, but Swift Jinja has not been implemented yet. You can refer to the commits of jinja.js for porting.
huggingface/huggingface.js@78e6a5e huggingface/huggingface.js@717d69d

I think this line is not being evaluated as false:
{%- if tools is not none %}

Because then it tries to iterate over tools, which is not iterable when it is none.

Yes, none also needs to be implemented.
You can port the commit.
https://github.com/huggingface/huggingface.js/commit/80cd45661ced1df0c1a19d5ee20e96b850c4021d

Thank you. Is there a point in time at which this package fully mirrored the JavaScript implementation? That would be helpful to know so that I can see which new additions might need to be added here.

Thank you. Is there a point in time at which this package fully mirrored the JavaScript implementation? That would be helpful to know so that I can see which new additions might need to be added here.

This package started development on May 20 https://github.com/huggingface/swift-transformers/pull/77#issuecomment-2008571237 , but at that time it did not fully mirror the JavaScript implementation. It only completed the mainstream LLM chat template Tests/ChatTemplateTests.swift .
It should be at https://github.com/huggingface/huggingface.js/commit/80cd45661ced1df0c1a19d5ee20e96b850c4021d.

Both none and the use of tools were introduced very recently in jinja.js, to support Llama 3.1. I think that implementing them would go a long way towards supporting most of the chat templates currently in use.

These Jinja packages are complex enough that at the moment the best I can do is hand the problem off to Claude 3.5 Sonnet, and that seems to only get part of the way to a solution. So feel free to take it from here if you want to. It would probably take me several days to get up to speed, and I unfortunately don't have enough capacity to do that right now.

It's okay, I can help you solve the problem.

Okay, I got this working with Llama 3.2. I haven't implemented the tools part with tojson, but it will work for inference in a normal chat scenario. I also haven't added tests, and I can see that one test is already failing.

I added a test for none, and I had to make some changes from the TypeScript version to make it pass. Please check if this is correct.

I checked https://github.com/huggingface/huggingface.js/pull/846 again and fixed a few things that I think now bring this in line with the TypeScript implementation. I think this is now ready for review.

Thanks a lot for the PR!


BUG: Toggled zip_safe

Coverage remained the same at 67.296% when pulling d2ab31e31074d4b122967a4663b691669fc03a5c on thermokarst:oops into 56f3c2458acc4247f9aa7c1f83bc4c37a5c3b382 on nervous-laughter:master.


fix: add ctxRenderer and shape of 'custom' to options

egh... forgot to add the options... I had bad errors...

@Thomaash Is the realease stuck? it seems to not release this and the previous PR


HELP - Potentially infinitely nested states. Is it possible for me to do?

Ok so here's my problem Imagine a photo feed that can be grouped by tags.
I have $stateProvider defined states feed, feed.photo and feed.photo.tags;
Now when you go to feed.photo.tags its meant to show you all tags that you tagged the photo with.
But from there I'd like to be able to click the tag and see the feed of photos grouped by this tag so dynamically go to feed.photo.tags.feed and from there deeper and deeper as much as linking allows me (feed.photo.tags.feed.photo.tags.feed.photo.tags....) potentially infinitely nested.
Can someone point me in the right direction whether it is possible to do without actually specifying the state nesting through the $stateProvider other than getting to lets say feed.photo.tags and from there going dynamically down whatever route user chooses?

You probably want to rethink your states so you don't have this. Maybe you would rather have the photos and tags be parameters instead of child states?

Also, this is a better question for Stackoverflow as it isn't a bug in ui-router and we are trying to keep it for bugs and feature enhancements and leave stackoverflow for support and implementation questions.

For something like this I would suggest using a path as a single parameter
rather then splitting these states into three different things. Something
like XPath, that your state parses and then seeks out would work much
better for this kind of abstraction.
On Fri, Jul 24, 2015 at 1:54 PM Eddie Monge<EMAIL_ADDRESS>wrote:

Also, this is a better question for Stackoverflow as it isn't a bug in
ui-router and we are trying to keep it for bugs and feature enhancements
and leave stackoverflow for support and implementation questions.
—
Reply to this email directly or view it on GitHub
https://github.com/angular-ui/ui-router/issues/2125#issuecomment-124628822
.


Social

Hi, can you add some description for this PR? :)
There are a lot of changes.
Thx.

It seems like this PR was sent accidentally.
Thanks


Validation should check extension for portable packages

If a manifest is submitted for a "portable" installer type, the validation infrastructure should verify the extension type for the downloaded portable package.
          It's actually a `ps1` script, not an executable

I installed it using the InstallerType: portable but it creates a file at C:\Users\natob\AppData\Local\Microsoft\WinGet\Links\scoop.exe. It's probably great for portable apps but this is a PowerShell installer for a full-blown PowerShell project. I guess a new installer type is still required?

I haven't followed the project recently, so I don't know if that new installer type made it in
Originally posted by @NatoBoram in https://github.com/microsoft/winget-pkgs/issues/19425#issuecomment-1498453595

Thanks for mentioning this one as well @NatoBoram. I don't know if it would be possible to do something similar to what chocolatey did with respect to building an installer or not, but that would certainly be an option for Scoop to get into the community repository.

Maybe it would be possible to package install.ps1 with PS2EXE?


[npo] Downloading video's has stopped working

[x] I've verified and I assure that I'm running youtube-dl 2018.02.26

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
$ youtube-dl -v https://www.npo.nl/door-het-hart-van-china/25-02-2018/VPWON_1265684
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.npo.nl/door-het-hart-van-china/25-02-2018/VPWON_1265684']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.02.26
[debug] Python version 2.7.10 (CPython) - Darwin-17.4.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg N-45166-ga877d22d9, ffprobe N-45166-ga877d22d9, rtmpdump 2.4
[debug] Proxy map: {}
[npo] VPWON_1265684: Downloading JSON metadata
[npo] VPWON_1265684: Downloading token
[npo] VPWON_1265684: Downloading formats JSON
[npo] VPWON_1265684: Downloading Adaptive stream JSON
[npo] VPWON_1265684: Downloading m3u8 information
[npo] VPWON_1265684: Downloading Hoog stream JSON
[npo] VPWON_1265684: Downloading Normaal stream JSON
[npo] VPWON_1265684: Downloading Laag stream JSON
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on u'npo+drm://internetvod.omroep.nl/VPWON_1265684'
ERROR: unable to download video data: <urlopen error unknown url type: npo+drm>
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1896, in process_info
    success = dl(filename, info_dict)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1835, in dl
    return fd.download(name, info)
  File "/usr/local/bin/youtube-dl/youtube_dl/downloader/common.py", line 364, in download
    return self.real_download(filename, info_dict)
  File "/usr/local/bin/youtube-dl/youtube_dl/downloader/http.py", line 340, in real_download
    establish_connection()
  File "/usr/local/bin/youtube-dl/youtube_dl/downloader/http.py", line 109, in establish_connection
    ctx.data = self.ydl.urlopen(request)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2199, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 431, in open
    response = self._open(req, data)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 454, in _open
    'unknown_open', req)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 409, in _call_chain
    result = func(*args)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 1265, in unknown_open
    raise URLError('unknown url type: %s' % type)
URLError: <urlopen error unknown url type: npo+drm>

It seems like the NPO/uitzendinggemist website has changed in someway, which make their video's undownloadable with youtube-dl. Given the error output, it seems like it has something with new DRM protection. Interestingly, using streamlink + mpv still allows me to watch NPO urls.

@dstftw What is this a duplicate of? This behavior was introduced fairly recently (last week or so) and I didn't find any other mention of it.

Somewhere between version 2018.02.04 and 2018.02.26 this regression was introduced. I know this because I have an older version of youtube-dl on another machine. It works fine when using that version. @rien333, if you want it to work you can downgrade to 2018.02.04.
@dstftw, I suppose a fix is in the pipeline.


KAFKA-3473; More Controller Health Metrics (KIP-237)

This patch adds a few metrics that are useful for monitoring controller health. See KIP-237 for more detail.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@becketqin Just in case you have time, can you review this patch?

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-test-coverage/299/

@junrao @ijuma I will update the patch if we want to include the new sensor in 1.1 release. Otherwise never mind.

@junrao It is merged now. Thanks!

kafka.metrics.MetricsTest.testMetricsLeak is failing frequently. Could it be related to this? One example:
https://builds.apache.org/job/kafka-trunk-jdk8/2655/testReport/kafka.metrics/MetricsTest/testMetricsLeak/

@ijuma This patch metrics in controller and the number of new metrics does not depend on client request. Since testMetricsLeak does not bounce broker, the test failure is probably not due to this patch. I opened https://github.com/apache/kafka/pull/5062 to print the metric name to help debug this flaky test.