1.7.5: download plugin checks-api to file: status code: 403, reason phrase: Forbidden

Jenkins and plugins versions report

Environment

jenkins/jenkins:2.319.3

What Operating System are you using (both controller, and any agents involved in the problem)?
Kubernetes
Reproduction steps
jenkins-plugin-cli --verbose \
    --war "$JENKINS_WAR" \
    --plugin-download-directory "$JENKINS_HOME/plugins" \
    --plugins "artifactory cloudbees-disk-usage-simple cloudbees-folder config-file-provider configuration-as-code credentials gerrit-trigger git mailer matrix-auth prometheus saml simple-theme-plugin ssh-slaves" \
    --latest "false"

Expected Results
checks-api 1.7.5 should be available at https://archives.jenkins.io/plugins/checks-api/1.7.5/checks-api.hpi
Actual Results
...
Downloaded gradle from https://mirror.gruenehoelle.nl/jenkins/plugins/gradle/1.39.4/gradle.hpi (attempt 1 of 3)
Downloaded and validated plugin gradle
Checksum valid for: gradle
Downloaded artifactory from https://mirror.gruenehoelle.nl/jenkins/plugins/artifactory/3.17.0/artifactory.hpi (attempt 1 of 3)
Downloaded and validated plugin artifactory
Checksum valid for: artifactory
Unable to resolve plugin URL https://archives.jenkins.io/plugins/checks-api/1.7.5/checks-api.hpi, or download plugin checks-api to file: status code: 403, reason phrase: Forbidden
io.jenkins.tools.pluginmanager.impl.DownloadPluginException: Unable to download checks-api
    at io.jenkins.tools.pluginmanager.impl.PluginManager.lambda$downloadPlugins$4(PluginManager.java:565)
    at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
    at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1655)
    at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
    at java.base/java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290)
    at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:746)
    at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
    at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
    at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
    at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
    at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)
Unable to download checks-api

Anything else?
Manually installing checks-api worked as it somehow resolved another endpoint to fetch it from.
# jenkins-plugin-cli --verbose --war "$JENKINS_WAR" --plugin-download-directory "$JENKINS_HOME/plugins" --plugins "checks-api" --latest "false"
...
Checksum valid for: script-security
Downloaded caffeine-api from https://mirror.gruenehoelle.nl/jenkins/plugins/caffeine-api/2.9.1-23.v51c4e2c879c8/caffeine-api.hpi (attempt 1 of 3)
Downloaded and validated plugin caffeine-api
Downloaded plugin-util-api from https://mirror.gruenehoelle.nl/jenkins/plugins/plugin-util-api/2.17.0/plugin-util-api.hpi (attempt 1 of 3)
Downloaded and validated plugin plugin-util-api
Checksum valid for: caffeine-api
Checksum valid for: plugin-util-api
Downloaded checks-api from https://ftp-nyc.osuosl.org/pub/jenkins/plugins/checks-api/1.7.5/checks-api.hpi (attempt 1 of 3)
Downloaded and validated plugin checks-api
Checksum valid for: checks-api
Done

Please raise this on https://github.com/jenkins-infra/helpdesk

Done https://github.com/jenkins-infra/helpdesk/issues/3095


add Windows support

This PR adds Windows support by adapting the provided makefile.vc and nmake.opt. I had to create a patch for freexl.c as it provides internal versions of round() and lround() when using VC, but the various VC versions are inconsistent with providing these (VC2015 provides both, VC2008 provides neither) so the easiest way seemed to rename the internal ones so they won't conflict with the VC ones where they exist.
I also had to add libiconv as a dependency since this package does use it - not sure how it was building on Linux etc before.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

LGTM


Is this hardware supported?

https://www.waveshare.com/wiki/CM4-DUAL-ETH-BASE
It uses rPi Compute 4 module.
Thanks in advance!  :)

The hardware shouldn't be an issue, but I haven't gotten enough feedback about the CM4 being supported, all I know that the previous SmoothWAN versions didn't work, while the latest does according to one report since the latest use owrt22.03 which supports cm4. I highly recommend getting any generic mini x86/PC instead (intel atom) considering it would cost the same and much more reliable.


Bring consistency between error and failure.

The completion callbacks and Result use failure, while Promise uses the word error. Is there any reason for this? It seems to me it would be more clear that one leads to another if they were both called either error or failure.

I agree. A future/promise either succeeds with a value or fails with an error. I'll rename the methods accordingly.

I think this is much better: 881346055e411d149fdd98f5a8908f559e25bab4. Agreed?

:+1:


entity:drawHud...() functions don't work

drawHud...() funcs works well, but when thing goes to entity:drawHud() funcs then nothing draw to screen
reproduced bug:
code:

bug showcase:

*I've shown only hudDrawText, but it relative to other types of hudDraws

These aren't standard functions, you should report this to the creator of the extension.

That extension is also not necessary. EGP can already render to the HUD without an extension.

That extension is also not necessary. EGP can already render to the HUD without an extension.

so that's a problem. I dislike EGP for HUD things.

well, I guess have fun with your extension that no one uses because EGP exists :)


Dir add hyperlink

This PR adds support for hyperlinking of folders to terminals that support it.
This will require extensive testing and feedback, so please feel free to test it :)
Implements #890 on the new code base (as requested in #857)

@dritter
In non-supported terminals this should just not show up.
General url support would be great if it'll work.


Unable to install it on windows

I am on windows 10 64 .
After doing npm install, I am getting the following error npm ERR! enoent ENOENT: no such file or directory, rename 'C:\Users\Win 10\Desktop\github\design-system-react\node_modules\@salesforce-ux\design-system' -> 'C:\Users\Win<EMAIL_ADDRESS>

This may be an issue with SLDS. Have you filed an issue over at https://github.com/salesforce-ux/design-system ?


Support for Huggingface Serverless Inference API

I think it would be helpful to have support for the Huggingface Serverless Inference API given that is supports a range of models and includes a limited number of free calls.
I'm a novice here, but from my understanding of the documentation, the API endpoints vary by model, so the URL may need special configuration  for each one. Right now I've added a new provider for each model that I want to use and I've also had trouble with the interpreter updating the contents within my template.

Excited for this! Any idea when 0.10.6 will drop?


Default List Order not working

When I try to have my list sorted with criteria "Score" it doesnt sort it. The setting seems to have no impact whatsoever.

Is the development halted? Or abandoned?


repo.Reference(HEAD) return "reference not found" error in brand new repo

I've just init a normal repo by PlainInit and then check its current branch. I called:
// same as "git symbolic-ref HEAD"
ref, err := repo.Reference(plumbing.HEAD, true)

and get an error said "reference not found".
But when I use Git CLI tools and "refs/heads/master" is the result.

I also have the same problem. But it worked when I used:
ref, err := repo.Reference(plumbing.HEAD, false)

The second parameter means that you want a hash reference.  When false it returns a symbolic ref, the same as your git example.


Usage Reporting

Generation of periodic reports around Protocols.
Link in with user management to determine recipient

@seg1129  recommend closure due to kibana integration


running on hpc environment

Hi,
I'm running metamorpheus on my cluster with task toml files.
I was wondering if there was a way to add more cores (maybe an extra line in toml file?). Task4 takes several days and the task takes 4 cores when i have 120 to allocate.
Also wondering how to add BayesianFoldChange analysis (flashlfq portion) to my run. Do i add a line in my Task5 toml for that?
TY

in windows, the "MaxThreadsToUsePerFile" parameter in the toml file adds more cores. This is line 50 in the latest version. Here, I show 7, which is all my laptop will allow.

Running MM in HPC may not accomodate the use of threads in the same way as for windows. I have almost no experience w/ HPC. Some collaborators worked to adapt MM to HPC. You can check on that here: https://github.com/PSTL-UH/HPCMetaMorpheus  I don't think that it is up to date.

Quantification with FlashLFQ occurs by setting the "DoQuantification" setting in the toml to true (Line 18 in the latest release)

However, this doesnt do the bayesian thing. You can add a ExperimentalDesign file to the same directory as your raw files and MM will use that in the quant. It allows you to specify conditions/bioreps/fractions/techreps

Here is an example ExperimentalDesign.tsv file:
ExperimentalDesign.zip

Thanks for the info. I supplied the Experimental design file and it was read in by metamorpheus. Does that mean I will get the Bayesian fold change file automatically or is there no way to attain that without running flashLFQ separately?
In the case I do have to run FlashLFQ separately after metamorpheus finishes: I set Normalize to "true" in my metamorpheus Task5 toml. Should I still set normalization (with --nor argument) in the FlashLFQ thereafter or leave it out?

MM will do FlashLFQ and provide quantitative protein values. But it will NOT do the bayesian thing. For that, you have to run FlashLFQ separately. I made an issue to add the bayesian thing to MM. I don't think it will be hard. But it is on a list so it may take a few weeks to complete.
I'm not sure how well normalization works. I would leave it off for now. You can see how it works in FlashLFQ. That has normalization capabilities. I don't think you need normalized data for bayesian anyway. I think that it takes care of what it needs


Clarify purpose of C-REEXPORT

This guideline is mostly about preventing stuttering, and to present a different external structure than the internal structure. It is not a blanket recommendation to put things at the crate level.

The c-reexport guideline was not sufficiently actionable so I have removed it.


No output after entering access token for npx supabase login

Bug report
Describe the bug
I run the npx supabase login and enter the access token but it just hangs no output or anything then I terminate with Ctrl+c.
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
System information

OS: Ubuntu 20.04 on WSL2
Browser (if applies) [e.g. chrome, safari]
Version of supabase-js: [e.g. 6.0.2]
Version of Node.js: [e.g. 10.10.0]
supabase cli version: 1.35.0

Additional context
Add any other context about the problem here.

I think the problem is that there is no progress indicator so I thought it wasn't responding  and hang. I think a progress bar with what's going on would be nice to see when you run the command

I also am experiencing the problem. it's first time login using Supabase CLI

Hey @stan-dot ~ npx supabase login currently works on the latest version. Can you try updating your Supabase CLI to the latest version v1.38.6? Let me know if that works. Thanks.

Thanks for reporting. This issue happens on WSL because CLI tries to store the access token in freedesktop secret service which doesn't exist on WSL. The temporary workaround is to specify your access token via environment variable. For example
SUPABASE_ACCESS_TOKEN=<token> supabase start

Thanks for reporting. This issue happens on WSL because CLI tries to store the access token in freedesktop secret service which doesn't exist on WSL. The temporary workaround is to specify your access token via environment variable. For example
SUPABASE_ACCESS_TOKEN=<token> supabase start

If you are on native windows, macOS, or linux, please let me know as that would be something else.

No, that did not work, still hangs

@wowczarczyk which command did you run exactly? Login is optional if you specify the access token env var.
I will close this as won't fix to focus on the related ticket on supabase link command.

This makes supabase cli essentially unusable on wsl, unless you prefix calls that require the access token in this fashion.  I suppose the command hangs looking for this secret service, then falls back to just checking your env after several minutes? I'm sure that is presumptuous, but I spent a lot of time blaming my connection and in retrospect, I wish it just gave some message on why it took so long to ask for my project ref.  I have since written a bash script that just wraps my supabase calls with the token & project ref.


Improve the CLI

[ ] probably move to questionary
[ ] ask if want to update embeddings / --refresh-embeddings flag
[x] support #8
[x] currently, CLI only supports a limited amount of characters for input.

I started having a conversation about some code. But when I pasted a chunk of code into the CLI, the cli only took the first line -- which led to a nonsensical conversation. Perhaps could we support toggling between single line + multiline inputs (like chatgpt UI)

@drnic Did you try typing // to enter multi-line mode?

@vivi I hadn't and that's embarrassing :) I've now found https://github.com/cpacker/MemGPT#interactive-cli-commands section of bonus commands :)


Unknown column since latest update

Hello, since the last update i keep getting unknown column even though i'm sure that i have the datasource added and even selected the database i want for the query in settings..

Hi. Can you share the full code statement?

This is one statement.

This is another one

Does CompetitorUser model has $table property defined? How is the table itself named? What do your plugin settings look like?
For the second, just out of curiosity - does it work if you rename first declaration of $query variable to something else, but leave $query = match name variable name unchanged? Or vice versa

CompetitorUser has $table in it yes. and the table name is competitors_users
the valriable $query can be renamed and still have the same issue, actually this issue is in the whole project.
since you mentioned plugin settings, it seems that this issue occurred only to this project, all my other projects are working fine, and it's weird because i'm pretty sure i did not change any setting, it just happened once i updated the plugin.
and here is the settings for it

If you temporarily unselect Filter data sources ?  Is it for sure correct dabase selected? Is it refreshed and up to date in Databases toolbar view?

the issue still persists if i unselect filter data sources.
the database is for sure selected yeah i even deleted the datasource in Database toolbar and added it again and still persists.

Managed to fix it finally, had to delete the laravel-query-settings.xml file from .idea folder

here is how it did look inside
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
  <component name="LaravelQuerySettings">
    <option name="filterDataSources" value="true" />
    <option name="filteredDataSources">
      <set>
        <option value="30eca40e-d219-4cd8-bf22-f78372aabbbd<-/lq/->linda" />
      </set>
    </option>
    <option name="tablePrefix" value=" " />
  </component>
</project>

Most likely. Should probably trim this value before saving. Don't think in any database spaces are allowed in table names 🤔

i actually don't do any table prefixes, so i'm not sure why it was added

Most likely by accident

i see, thanks a lot.
i hope at least you can make something for this in the future to trim any spaces before saving.
i will close this issue.

Had the same issue. Deleting the .xml fixed it.


security group rule must take fromPort and toPort as input

Then it must not have <proto> protocol and port <portNumber> for <IP_ADDRESS>/0  This will check for port with <IP_ADDRESS>/0.
I don't want any port to not have <IP_ADDRESS>/0 except some ports.
I should be able to give input as below,
| Any           | tcp   | 1000          | 65535  |
So that, if any port from 1000 to 65535 have access from/to <IP_ADDRESS>/0 then terraform-compliance should identify them as issue.

This is cool, portRange maybe the field name.

oh sure that is a custom name, you can even set it to <karthikeayan>

Can you test it again with 0.5.2 release @karthikeayan please ?

I think the new pull request merge broke the functionality.
I have this in tf file,
resource "aws_security_group" "cluster" {
  name_prefix = "${var.cluster_name}"
  description = "EKS cluster security group."
  vpc_id      = "${var.vpc_id}"
  count       = "${var.cluster_create_security_group ? 1 : 0}"
}

resource "aws_security_group_rule" "cluster_ingress_internet" {
  description       = "Allow cluster mysql ingress access from the Internet."
  protocol          = "tcp"
  security_group_id = "${aws_security_group.cluster.id}"
  cidr_blocks       = ["<IP_ADDRESS>/0"]
  from_port         = 3306
  to_port           = 3306
  type              = "ingress"
  count             = "${var.cluster_create_security_group ? 1 : 0}"
}

When I run terraform-compliance with 0.5.2, getting the below output:

1 features (1 passed)
9 scenarios (9 passed)
26 steps (26 passed)
Run<PHONE_NUMBER> finished within a moment
Cleaning up.

Same feature with same tf file when run with, 0.5.1,

1 features (0 passed, 1 failed)
9 scenarios (8 passed, 1 failed)
26 steps (25 passed, 1 failed)
Run<PHONE_NUMBER> finished within a moment
Cleaning up.

Looks like different tests are required to be implemented. Will check in few hours

Yes, you are right, found and fixed the problem.
Releasing 0.5.3, must be there in few minutes after PR is approved.

Great, thanks for implementing this.
Can I have same scenario twice in single feature with different values?

Of course, but instead of using Scenario you can use Scenarios and keep port ranges as a parameter like ;
    Scenario Outline: No publicly open ports for given ranges
    Given I have AWS Security Group defined
    When it contains ingress
    Then it must not have <proto> protocol and port <port_range> for <IP_ADDRESS>/0

    Examples:
        | ComplianceId | proto | port_ranges |
        | COMP001      | tcp   | 1-21        |
        | COMP002      | tcp   | 23-79       |
        | COMP003      | tcp   | 81-442      |
        | COMP004      | tcp   | 444-65535   |

.. which gave an idea that we need to have a step defined similarly;
Then it must only have <proto> protocol and port <port_range> for <cidr>


🐛 Can't use VSCode extension (node not found)

Environment information
CLI:
  Version:                      1.2.2
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.15.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/8.6.10"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?
I can run it from the CLI just fine, but the extension throws this error:
Configuration file required, looking for one.
Config file found at<EMAIL_ADDRESS>enabling Biome extension
Using Biome from<EMAIL_ADDRESS>[cli] exit 127
[cli-stderr] data 92
[cli-stderr] end
[cli-stdout] end
[Error - 12:33:39 PM] Biome client: couldn't create connection to server.
Error: Command<EMAIL_ADDRESS>__print_socket" exited with code 127
Output:
<EMAIL_ADDRESS>16: exec: node: not found

    at getSocket (/home/hyoretsu/.vscode-server/extensions/biomejs.biome-1.4.2-linux-x64/out/main.js:19600:11)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at createMessageTransports (/home/hyoretsu/.vscode-server/extensions/biomejs.biome-1.4.2-linux-x64/out/main.js:19615:16)
    at LanguageClient2.createConnection (/home/hyoretsu/.vscode-server/extensions/biomejs.biome-1.4.2-linux-x64/out/main.js:15576:28)
    at LanguageClient2.start (/home/hyoretsu/.vscode-server/extensions/biomejs.biome-1.4.2-linux-x64/out/main.js:15152:30)
    at activate (/home/hyoretsu/.vscode-server/extensions/biomejs.biome-1.4.2-linux-x64/out/main.js:19421:3)
    at p.n (/home/hyoretsu/.vscode-server/bin/6c3e3dba23e8fadc360aed75ce363ba185c49794/out/vs/workbench/api/node/extensionHostProcess.js:103:6206)
    at p.m (/home/hyoretsu/.vscode-server/bin/6c3e3dba23e8fadc360aed75ce363ba185c49794/out/vs/workbench/api/node/extensionHostProcess.js:103:6169)
    at p.l (/home/hyoretsu/.vscode-server/bin/6c3e3dba23e8fadc360aed75ce363ba185c49794/out/vs/workbench/api/node/extensionHostProcess.js:103:5626)
[cli-stdout] close
[cli] close 127
[cli-stderr] close

Expected result
It should work just fine.
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

Is your OS supported? I saw this error before, most of the time it's because Biome runs on an OS that is not supported

It definitely is, I'm using Ubuntu. I also don't think running VSCode Remote on WSL2 messes something up.

Starting using Biome in Bun environments and it ran mostly fine, tried to adopt it in a NodeJS environment (running on WSL2 Ubuntu) and running into the same error (exit code 127):
/mnt/c/Users/31645/AppData/Roaming/npm/node: 8: /mnt/c/Users/31645/AppData/Roaming/npm/node_modules/node/bin/node: not found

	at getSocket (/home/mirasaki/.vscode-server/extensions/biomejs.biome-1.4.2-linux-x64/out/main.js:19600:11)
	at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
	at async createMessageTransports (/home/mirasaki/.vscode-server/extensions/biomejs.biome-1.4.2-linux-x64/out/main.js:19615:16)
	at async LanguageClient2.createConnection (/home/mirasaki/.vscode-server/extensions/biomejs.biome-1.4.2-linux-x64/out/main.js:15576:28)
	at async LanguageClient2.start (/home/mirasaki/.vscode-server/extensions/biomejs.biome-1.4.2-linux-x64/out/main.js:15152:30)
	at async activate (/home/mirasaki/.vscode-server/extensions/biomejs.biome-1.4.2-linux-x64/out/main.js:19421:3)
	at async E.n (/home/mirasaki/.vscode-server/bin/abd2f3db4bdb28f9e95536dfa84d8479f1eb312d/out/vs/workbench/api/node/extensionHostProcess.js:108:6206)
	at async E.m (/home/mirasaki/.vscode-server/bin/abd2f3db4bdb28f9e95536dfa84d8479f1eb312d/out/vs/workbench/api/node/extensionHostProcess.js:108:6169)
	at async E.l (/home/mirasaki/.vscode-server/bin/abd2f3db4bdb28f9e95536dfa84d8479f1eb312d/out/vs/workbench/api/node/extensionHostProcess.js:108:5626)

node -v
v19.0.1

Is there a way to run vscode extension with bun?

@ematipico unfortunately vscode languageclient does not yet support bun as a runtime https://github.com/microsoft/vscode-languageserver-node/issues/1321
I'll try submit a PR on biome once there is advances on vscode.

Related to https://github.com/biomejs/biome/issues/412
@hyoretsu have you tried this? ⬆

Same problem on macOS 13.5.2 (22G91) with node v18.13.0 (via nvm).

Related to #412
@hyoretsu have you tried this? ⬆

It didn't work, I tried restarting both WSL and my computer.

Hey :wave:, this issue may be fixed in the latest nightly version.
Could you try it and tell us if you're still experiencing the issue?
Here's the command to install the nightly version
code --install-extension<EMAIL_ADDRESS>
After your tests, you can revert to the current stable version with the following command.
code --install-extension<EMAIL_ADDRESS>

This was not fixed 4 days ago for me (not speaking for anyone else), but a couple of hours ago with the most recent VSCode update. I'm not sure if VSCode updates also bump all the plugins to their latest versions, or if this was released in a non-nightly version - but it's definitely fixed, amazing! 🥳

@Mirasaki, could you tell which version you’re currently on ?

Biome 1.2.2
And VSCode 1.83.0

It actually looks like the last local VSCode update was a week ago, so I'm not sure of anything anymore relating this haha. Except that it still works. Sometimes it loses the connection to the server, but very quickly recovers.

Biome doesn't work for me either in WSL. Funnily enough, it isn't working on Windows either, when both Prettier and ESLint do, and I have installed biome both in the local as well as the global environments. I've tried with Node 18 and 20, no luck. VS Code is up to date

@BoscoDomingo you might want to open a different issue/discussion in the biome-vscode repository, and propose the feature

@BoscoDomingo you might want to open a different issue/discussion in the biome-vscode repository, and propose the feature

Yup, did so right after editing the comment. Thanks!


dev(hansbug): add walk method for FastTreeValue class

Description
As the title saied.
Check List

[x] merge the latest version source branch/repo, and resolve all the conflicts
[x] pass style check
[x] pass all the tests

Some problems:

When the depth is given, and include_nodes is False, some treevalue object (tree node) will not be appeared. Is this ok?
I think that flatten function is designed not, maybe the default value of include_nodes can be set to True. The flatten function is used to flatten values, and walk is used to iterate all the nodes. Do you think this is ok? If yes, you need to check the existing code due to the change of default value.


Add donation BTC address to readme

Please can fund your project  / appriciate the work you've done by sending a donation.
Perhaps add a IRC channel somewhere to report issues, like build errors

I will add our gitter and donation addresses. Thanks for the support!!

Done.


Add integration for new comment server methods

Comment Server was upgraded to the official JSON RPC 2.0 Spec

[ ] everything now user /api/v2
[ ] non-zero id must be sent, or it is considered a notification which gets no response.
[ ] methods are now referenced with a service so <service>.<method> ie comment.List. See list below

Transitioned APIs

get_claim_comments =>    comment.List
get_claim_hidden_comments =>   comment.List, paramter added to main list api
get_channel_from_comment_id => comment.GetChannelFromCommentID
create_comment => comment.Create
abandon_comment =>  comment.Abandon
edit_comment => comment.Edit

New APIs

react.List

Request
type ListArgs struct {
	CommentIDs  string  `json:"comment_ids"`
	Signature   string  `json:"signature"`
	SigningTS   string  `json:"signing_ts"`
	Types       *string `json:"types"`
	ChannelID   *string `json:"channel_id"`
	ChannelName *string `json:"channel_name"`
}

Channel name plus timestamp should be signed, in order to get a list of both yours and others reactions

react.React

Request
type ReactArgs struct {
	CommentIDs  string  `json:"comment_ids"`
	Signature   string  `json:"signature"`
	SigningTS   string  `json:"signing_ts"`
	Remove      bool    `json:"remove"`
	ClearTypes  string  `json:"clear_types"`
	Type        string  `json:"type"`
	ChannelID   *string `json:"channel_id"`
	ChannelName *string `json:"channel_name"`
}

Channel name plus timestamp must be signed

This was done.


Overlay toggle

It would be useful to be able to toggle the overlay.

Fixed in commit bbfa852c8e7afa2cc45ff7e8a4fb9ca40cbf7212 by adding a "Toggle Overlay" context menu option to the system tray icon.


incinerate "average hit" is the dps --> dps calculation is bloated

Using incinerate. The Average hit is actually the dps on stage 1. ie:
I currently have a build hitting for about 770 in fire damage per hit in game. however Path of building is showing average hit without charge as 5915.8  on a cast speed of 7.65. and the dps as 45256 (at level 45) there seems to be something off with this calculation

I'm not aware of any issues with Incinerate's calculations; it's quite impossible for it to be bugged in the way you suggest. It would help to have the exact build you're looking at; either the account/character name or the build export code.

Hey there, I restarted, and it has come right. It's very strange. If I copy the skill group and use that instead, it shows that the damage is correct, however if i go back to selecting my original skill group, it still shows as bloated


nixos/testing: Fix graphical tty output

Prior to this contribution, the Kernel's frame buffer output boot log wasn't visible on the graphical console.
Now, we can also test applications with graphical output that run during the boot process.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@tfc


Add ex commands, including save

Many of the ex commands are critical to true vi heritage, including :w. From wikipedia's article on ex:

ex was eventually given a screen oriented visual interface (adding to its command line oriented operation), thereby becoming the vi text editor.

We've got a lot of our movement commands, but it would be great to have our :w, :%s, :g.
Most of the movement commands are there, so I'm generally having a good time. Thanks for this package!

I would like to see this enhancement realized in some way. Seperate package would work for me also.
+1

+1 I def. want this! I keep hitting :w, and was sad not to be able to goto line using :.

You guys are trying to reinvent how vim emulation should work ?. The whole point of vim emulation is to make it easy for vim users to work on atom. If there is no way to save a file using :w then it's not vim emulation. Why not just go ahead invent a novel alternative to pressing Escape ?.
Mean while I was waiting on this issue I went back to vim and have been playing around with spacemacs and tried other editors that have basic vim keybindings. Unsubscribing from this issue, I no longer want to get these +1 mails.

If it's in a different package, fine, but +1 on this being essential. This is muscle memory, and it's a misconception to think that many long-term vim users are interested in 'transitioning' their muscle memory to the atom way.

Maybe the easiest would be to use the vim binary for this feature, just
send the command to it, let it execute and save. That way people can use
custom commands and use vimscripts.
On Wed, Feb 4, 2015 at 5:09 PM, Nick Perez<EMAIL_ADDRESS>wrote:

If it's in a different package, fine, but +1 on this being essential. This
is muscle memory, and it's a misconception to think that many long-term vim
users are interested in 'transitioning' their muscle memory to the atom
way.
—
Reply to this email directly or view it on GitHub
https://github.com/atom/vim-mode/issues/50#issuecomment-72882591.

@joelmo the problem seems to be that the vim module currently doesn't support all the commands (someone please correct me if I am mistaken about this). So acting as a delegate and calling into the vim module won't work.

On Wed, Feb 4, 2015 at 5:20 PM, Jeff Schwartz<EMAIL_ADDRESS>wrote:

@joelmo https://github.com/joelmo the problem seems to be that the vim
module currently doesn't support all the commands (someone please correct
me if I am mistaken about this). So acting as a delegate and calling into
the vim module won't work.

The commands that vim-mode supports doesn't have to be delegated.

—
Reply to this email directly or view it on GitHub
https://github.com/atom/vim-mode/issues/50#issuecomment-72884996.

@joelmo so how can you save a file now just using vim emulation? I don't see a "save" option in the command palette. I'd guess if "save" were implemented then it would be exposed as would other ex commands and would show in the command palette, right?

I don't understand what you mean. If atom supports opening external processes, then it could just execute /usr/bin/vim /path/to/file +CustomCmd +w +qa!, CustomCmd could be %substitute or anything. If those commands have to show up in the command palette there probably is a way to query them, ':command' in vim will list all user commands.

@joelmo that's my point, this isn't vim and currently vim emulation doesn't implement what the actions that external commands would need, like saving a file in response to :w - it doesn't do that now. I'm not saying it wouldn't be nice if it did. Either a separate ex command module will have to implement :w or the current vim module will have to implement it. Personally, I sort of like the idea of a separate ex command module but I'd be happy in either case. The bottom line for me is that I don't expect vim emulation to emulate every facet of Vim. If I wanted that then I'd just use Vim (and I do at times). Perhaps when Neovim is ready, then some enterprising UI person will craft a sweet GUI around it. Until then for me there's Atom with decent (but could be better) emulation and the real deal when I want it.

FWIW, the key resolver is very awesome, and vim mode is quite happy to work with it.
This could be a good workaround for ya'll, if you weren't doing this already:
In your keymap.cson
'.editor.vim-mode:not(.insert-mode)':
  ': w enter': 'core:save'

And that's :w taken care of.
Some of the other commands may require more creativity, however. Not sure what to do for :%s You could launch atom's native find and replace though, as a productive step:
'.editor.vim-mode:not(.insert-mode)':
  ': w enter': 'core:save'
  ': % s enter': 'find-and-replace:show'

Again, not truly vim emulation, but it might be helpful to some for the time being.

I agree that not everything have to be emulated, but I believe the core commands people are asking for is  substitute, global, sort, bufdo. All those, except last accept a regex, and also supports operating on ranges. I think it would be hard work to implement an emulation for these. This feature was suggested one year ago, but I don't feel like doing that work so I'm just using vim and follow some progress on neovim.

This is the only issue keeping me from using Atom

No one was stepping up so, ex-mode here. While there's only w and write, groundwork is done, so adding new commands is easy: https://atom.io/packages/ex-mode

+1 This is the main thing that makes me not use Atom. I want :commands.
...But cool that finally someone has started working on the ex-mode.

: commands are essential.
Simply life is not possible without them.
Atom is nice, fancy, great, has a lot of potential and I'm sure I could love it. (with :)

ex-mode now supports :s as well. Could we add a link to ex-mode in the readme?

@flyingfisch you're too modest (: https://github.com/atom/vim-mode/commit/40e7f3d6fea306063e6249953954c0d873f345de
Does it make sense to close this in favor of opening bugs on ex-mode?  Or is there anything that still needs to be tracked here?

I'm happy to close the issue now that I know about ex-mode.

@bronson yeah after i posted here i thought i would just do it the github way ;)

Heh, I never closed this. I'll keep it open now that ex-mode is looking for maintainers: https://github.com/lloeki/ex-mode/issues/116
Perhaps there are contributors here that would like to help there (or bring over some of it?)

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


⚠ Fortnite has degraded performance

In dcdd6c8, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1597 ms

Resolved: Fortnite performance has improved in a45b707.


Bank's Items Counter

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always
frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've
considered.
Additional context
Add any other context or screenshots about the feature request here.

There is already a banked items counter in the top left; this is a vanilla feature.


Enable inliner for Scala 2

Currently Pekko uses the @inline annotation and while for earlier versions of Scala this may have done something, with the latest version of Scala 2.12/2.13 the @inline annotation only inlines if you actually enable the inliner via scalac flags, quoting from https://docs.scala-lang.org/overviews/compiler-options/optimizer.html

The @inline annotation only has an effect if the inliner is enabled. It tells the inliner to always try to inline the annotated method or callsite.

While this argument may be considered a bit of a stretch (I don't know the history of Akka here), on first glance it appears that in previous versions of Scala that had the older version of the inliner Akka actually expected @inline to work (we are dealing with performance critical sections of the code after all) and then when Scala was updated which brought in the new inliner written by Lukas Ritz all of the inlining capability via the @inline annotation was lost even because current versions of scalac won't warn if you use @inline without the inliner enabled.
Hence this PR enables inlining for Pekko. While it is true that the original inliner used in older versions of Scala (including in the early minor versions of Scala 2.12/2.13) had many issues which is why it was disabled in Akka, afaik the latest inliner is considered safe especially considering that even modules used within Scala have the inliner enabled (i.e. https://github.com/scala/sbt-scala-module/blob/main/src/main/scala/ScalaModulePlugin.scala#L57). This is also evidenced by the fact that when enabling the inliner, various changes had to be done because its actually a lot more comprehensive when doing checks, more specifically

The latest version of the inliner actually cross checks between both the JVM bytecode and source to make sure code behaves the correctly. This can cause issues when mixing Java/Scala sources of which Akka/Pekko codebase is one. While this can be solved by changing the compiler order to CompileOrder.JavaThenScala unfortunately the problematic sources in question have cyclic dependencies between Scala and Java (I originally tried to move the problematic modules into a non published core sub project using dependsOn but this only worked with the non cyclic dependencies of which org.apache.pekko.util.Unsafe is the only one). Instead to solve this issue I opted to convert the problematic Java sources to Scala, thankfully the Java code that ended up being converted is trivial and hence even on bytecode level its basically equivalent.
Some code which used to have @inline had the it removed because inlining wasn't possible (and in the old version of the inliner it would have either been unsafe or just silently not inline anything). An example of this is @inline final def head: Byte = array(from), i.e. @inline had to be removed because it was overriding a non final head method from outside of pekko (in this case head was occurring in Scala stdlib collections). Conversely this also means if we found an @inline annotation for a non final method defined within Pekko, the method was changed to be final (i.e. see https://github.com/apache/incubator-pekko/pull/305/files#diff-3e1ec66267cb7d4e96501b2f01cb462341571959c64387e74eea929d51ef593cR223). At least from what I could tell in such cases not having the method final was an oversight and there was zero expectation that users would override the method.
Any source files that contained the @inline annotation and were contained within scala-2.13+ folders were copied over to scala-2.13 and scala-3 folder with the scala-3 variant changing @inline to inline (in Scala 3 inline was moved to a keyword and hence the @inline annotation doesn't do anything).

Currently blocked by what appears to be the inliner being too aggressive, made an issue about it on scala contributors at https://contributors.scala-lang.org/t/scala-2-12-2-13-inliner-is-too-aggressive/6191

Found a bug with the inliner in Scala 2.13, see https://github.com/scala/bug/issues/12787

A fix for the Scala 2.13 inline bug that I found has already been supplied (see https://github.com/scala/scala/pull/10404). Hopefully it will get merged and then released for Scala 2.13.11

Currently blocked by https://github.com/lampepfl/dotty/issues/18646 (although may not be entirely critical).

So there may be a bit more work (and more info needs to be added to PR) but its at a stage where people can review it. I have created 2 builds of pekko, one with inline enabled and one without inline enabled

inlined: https://drive.google.com/file/d/1jfBdLgA_2g-TmFGCxnyvgUQePG6040Rz/view?usp=sharing
no-inlined: https://drive.google.com/file/d/11ulnOvuNSlwKu9NhurHDSZgwfN-73jI3/view?usp=sharing

You can place either in ~/.ivy2/local/org.apache.pekko to test them out and of course you can use tools like jardiff to do a diff between the jars to see the bytecode differences.
@He-Pin If you have time doing some initial performance testing would be fantastic. The most critical thing would be if there is a regression (I don't expect this at all) but of course the main point of this PR is to see performance gains, especially for JDK 8/JDK 11 (I know that very recent versions of JDK do a better job of inlining but most people are still using 8/11)

Excellent! A little busy at the shopping festival, will take a closer look soon~

I have added more info in the original post about the inliner.

Looks good, I can start testing Java11 this weekend. Is the scope of the test to add or remove inline methods, or is part of it just fine?

Looks good, I can start testing Java11 this weekend. Is the scope of the test to add or remove inline methods, or is part of it just fine?

I would be more curious about the performance impacts rather than testing correctness, after all that is the whole point of the inliner.

@He-Pin @jxnu-liguobin Did you manage to have a look into this? I was thinking of merging this so its ready for milestone 1 so i can get properly tested (@pjfanning what are your thoughts on this as well)?

@He-Pin @jxnu-liguobin Did you manage to have a look into this? I was thinking of merging this so its ready for milestone 1 so i can get properly tested (@pjfanning what are your thoughts on this as well)?

I will take another look at it on Sunday.

A test failed

This appears to be unrelated, if you look at the source code i.e.
https://github.com/apache/incubator-pekko/blob/b0fdac259bd57fdd481483f3fe9a7aec6e1ff38a/stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/StreamRefsSpec.scala#L361-L362
specifically against the linked issue https://github.com/akka/akka/issues/30844 you can see that upstream its also reported as a flaky test

I have written some tests (without using artifacts) that do not show any performance impact.

This is both good and bad news depending on how it was tested, it does mean that potentially akka has a lot of hotspots already taken care of (not surprising) but I would also be curious as to what JDK was used.

Is it necessary to use packaged artifacts for testing?

Nope, the packages were more designed to test it with projects like pekko-http however I would raise what I said earlier in the OP, specifically

The general idea is that once this is merged into Pekko 1.1.x series we can start enabling the inliner in the other Pekko modules.

i.e. To enable full inlining in other modules like pekko-http that in addition to enabling the inliner in pekko-http build you would actually need to compile against pekko core artifacts that have the inliner enabled.

My feedback:

I don't think we should rewirte those Java code to Scala, we maybe migrate those to VarHandle later. cats-effects doesn't too https://github.com/typelevel/cats-effect/tree/series/3.x/core/jvm/src/main/java/cats/effect/unsafe
We need split this PR:

the @inline annotation modification and inline addition for Scala 3.
the java to scala rewritten, we may not need it.
the plugin itself.

My feedback:

I don't think we should rewirte those Java code to Scala, we maybe migrate those to VarHandle later. cats-effects doesn't too https://github.com/typelevel/cats-effect/tree/series/3.x/core/jvm/src/main/java/cats/effect/unsafe

We have to because the inliner doesn't work (as in it will fail to compile). This is because the inliner needs to reference bytecode with .scala files and so existing @inline anmotations won't work with rewriting these specific

We need split this PR:

the @inline annotation modification and inline addition for Scala 3.
What's reasoning behind this (not sure what this is meant to achieve)? The splitting out of traits for different Scala versions is intended to be in a single PR?
the java to scala rewritten, we may not need it.

As mentioned before it was definitely necessary when I was writing the PR. Some of it may no longer be necessary as stuff did move around as PR was being worked on over time.

the plugin itself.

Which plugin ate you talking about?

Maybe the @inline annotation is misleading that there might or should be a performance optimization potential that can somehow be realized. But it's important to understand that most of the code that contained @inline annotations were written more than a decade ago ~ in Scala 2.9.x time where expectations and realities of the backend and of the JDKs in use were vastly different.

If this is the case then maybe its best to just remove all of the @inline annotations (aside from the obvious cases which are inside of org.apache.pekko.util.* where there is no reason not to inline). Most of the complexity of the PR is arising from making the @inline annotations work on both Scala 2/Scala 3 and apparently according to the author of the Scala 2 inliner, its heuristics are already good enough that it would be quite surprising if it didn't catch code that should be inlined.

Basically, the only place where you can expect wins through inlining early in the pipeline is highly abstract, megamorphic code that requires explicit code expansion (explosion) in a way that the JIT will never do (i.e. expand megamorphic call sites leading to potential exponential code blowup). In some case, the fact that a call-site is mostly monomorphic but looks megamorphic can mislead the JIT, or you want a single call-site to be optimized. These are the places where macros like parboiled2 or loop fusion solutions can shine, but these are very specific cases.

Agreed and this is the main intent of enabling the inliner. I had a presumption that there is a reason why the Akka codebase was littered with these @inline annotations but it appears that at least for modern Scala backends its largely a red herring.
It seems like the best way to go is to actually remove all of the @inline annotations (aside from the exception I listed earlier) while still enabling the Scala 2 inliner to see if we get some easy wins and make sure we diagnose what those wins are. Do note that the Scala 2 inliner is enabled for some of the most critical/performance sensitive Scala OS code, i.e. the Scala 2 compiler itself as well as Zinc so I see this really as a case of having some free lunch with almost no risk.

Would the buy in be better for this feature if I change the scope of the PR to do what I stated

I think so, or at least it will keep people more focused.
btw, Our team started using pekko this week.

As discussed, PR is closed in favour of https://github.com/apache/incubator-pekko/pull/857 (I made a new PR to keep this one as a reference).

I think we can split this PR to make the progress more smoth.

I think we can split this PR to make the progress more smoth.

Its already been done, see https://github.com/apache/incubator-pekko/pull/857

Closing this PR, as stated in https://github.com/apache/incubator-pekko/pull/857 if there are further inline opportunities its best to tackle them individually while also demonstrating the performance benefits.


bdd-spring-1557154142 to 0.0.1

Promote bdd-spring-1557154142 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Memory bug

Well even if I'm not 100% sure about this, there seems to be a leakage. I started IE with a nivo-slider before I went to bed and it used about 49MB in memory. When I woke up, IE used more than 300MB in memory.

Any resolution on this?


[CLI] Add data directory support

Granted, the CLI is mostly for experimenting purposes and most likely people will be using a more specialized tool in the future, it'd still be nice to round it out to be a complete showcase of stager's capabilities.
--data

Accept directories
Allow multiple --datas
Recursively walking, translating dir_name.file_name into variable hierarchy.

Fixed by #10


Solutions for errors related to no minimum deposit and no gas price specified (v1.9)

Hi rubykube devs,
There are a couple of issues I experienced when building and running the new Peatio master (v1.9) from source. One is related to the lack of a minimum deposit threshold.
The issue is in the collect_eth_deposit function here. Specifically, this line:
amount = deposit.amount_to_base_unit! - options[:gas_limit] * options[:gas_price]
amount will be negative if the deposit is lower than the fees. Temporarily, the solution is to use an if statement, like so:
def collect_eth_deposit!(deposit, destination_address, options={})
      if(deposit.amount_to_base_unit! > options[:gas_limit] * options[:gas_price])
      	# Default values for Ethereum tx fees.
      	options = DEFAULT_ETH_FEE.merge options

      	# We can't collect all funds we need to subtract gas fees.
      	amount = deposit.amount_to_base_unit! - options[:gas_limit] * options[:gas_price]
      	pa = deposit.account.payment_address
      	client.create_eth_withdrawal!(
        	{ address: pa.address, secret: pa.secret },
        	{ address: destination_address },
        	amount,
        	options
      	)
	else
		# Do something like lower the gas price or throw error
    end
end

A second issue I encountered was with the create_erc20_withdrawal function here specifically with the json_rpc part. There is no gas limit or gasPrice specified, so Geth will use a gas limit and gas price that it estimates is correct based on the ERC20 contract and the mempool usage, respectively. But this is bad for deposit collection, because only 0.001 ETH is sent to the deposit address as a fee by default (here) so if Geth estimates that the fee should be bigger than 0.001 ETH, the deposit will never move to the hotwallet.
I recommend specifying a gasPrice and gas limit, like so:
json_rpc(
          :eth_sendTransaction,
          [{
               from: normalize_address(issuer.fetch(:address)),
               to:   options[:contract_address],
		gas: "0x186A0",
		gasPrice: "0x2540BE400",
               data: data
           }]

This sets the gasPrice to 10 gwei and the gas limit to 100k which should be enough for almost any ERC transfer function (note that this is also exactly the amount speicified here). But this is only a temporary solution, because if more than 100k gas is required the transfer will fail on the blockchain. I recommend using web3.eth.estimateGas as a full solution.
Finally, as the Ethereum network is constantly being overworked and does not scale well, the recommended gas limit fluctuates constantly. Generally 10 gwei is enough to get a transaction mined quickly but not always, so I recommend using the ethgasstation API "fast" as the default fee and { gas_limit: 21_000, gas_price: 10_000_000_000 } as a fallback if the ethgasstation API is down or returns nil. Note that the number returned for "fast" will have to be multiplied by 100_000_000 to convert it to Wei for the gasPrice.
Thank you for all your work.

@jdowning100 Thanks a lot for your advices !
Using estimateGas that is what we were going to implement in the nearest future if we will not have luck with smart contract
About ethgasstation API we don't want to depend on other external services we suppose that hot/warm/cold wallets have enough funds for performing withdraw

closed in https://github.com/rubykube/peatio/commit/db9d354216781f75d3e8b0aeff15478ffdb3b60f


Updated the support doc with correct links

Updated the doc support.md to match the B2k repo with proper links.

Codecov Report

Merging #69 (2f0f78e) into main (9b0ecd7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   65.33%   65.33%
=======================================
  Files          33       33
  Lines        2634     2634
  Branches      101      101
=======================================
  Hits         1721     1721
  Misses        913      913

Flag
Coverage Δ

unittests
65.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Adding support for executing a selection

Hey, I needed to execute a selection, this little change adds support for that. Hope might be useful, thanks for the great extensions!

Thanks @PabloRosales !

:) thanks to you for the extension, very useful!


The search-google-by-version feature is worse than useless

Too many times to count I get zero results from the little box, only to find there are plenty of docs on what I'm looking for. This is way worse than not having a little box.
Go try searches for
ProjectRef site:http://www.scala-sbt.org/0.13.1/docs

No results. That's the default search. Now try
ProjectRef site:http://www.scala-sbt.org/release/docs

Listen: if someone is searching for results for some version which is NOT the release version, then it's really important that their results be customized to the version they are search for. This thing is obviously completely untested - it can't find any results, let alone a specific subset of results - give up the pretense of being able to deliver granular results and have a single unconfigurable search box which searches at http://www.scala-sbt.org/release/docs.
They're programmers, they're well aware that there are multiple versions of things and that they need to make sure what they're reading applies to what they're using. THAT problem, EVERYONE has. THIS problem - finding no results for the front-line documentation search - sbt has created, and for no benefit.

Heh, I'm here because Google hasn't been working for me and I was wondering where the search box went :)
Google: while it's true that most of the time the results aren't burried and one result will LOOK like the current site, after clicking, the result is invariably out of date. And each result tops out at a different version number, none of them linking to the current docs.
The reference manual pdf is a last resort, but of course it's clunky and requires exact search terms.
Anyways, thanks for all the work guys, just sharing my pain hoping to encourage a fix.

The search box was removed when we moved to Pamflet, and we've been hearing surprisingly few complaints about it. Maybe because it was never functional as this issue points out.
This case is now split into two issues:

sbt/website#5 Search box
sbt/website/issues#180 Search Engine Optimization

My guess was that Google was confused due to the sitemap we were producing (or suspected that we are spam site that produces same content over and over). I've renamed the sitemap in sbt/sbt.github.com@5d3b4a8a37d79c3d1b8502cf9cff9cb4c83e8b21, also we produce one site per binary compatible series. The following Google result looks ok:
ProjectRef site:www.scala-sbt.org/0.13/docs

cool, thanks for clarifying for me


Prepare October 2022 Identity release

This rolls back several beta features in this release branch.

API change check
API changes are not detected in this pull request.


Generated request/response struct specs for General Commands

Problem
We'll need generated request/response struct specs for General Commands. We never created these for Dotdot ZCL implementation due to the use of CoAP, we'll need these for general ZCL General message handling.
Proposed Solution
Create generated request/response struct specs for General Commands

SW BRB: Closing this as we're covering this in @vivien-apple 's work

SW BRB: Closing this as we're covering this in @vivien-apple 's work


[Mod Request] Light Overlay

Simple as. Just want a light overlay mod with the little red and yellow x's

I agree with this, but the pack is designed to be played on peaceful, so the usefulness of this is questionable.


Is there a way to test GHA that use main before merging?

I hate having to merge things before knowing for sure they work but for some GHA it seems this is the main way to know if they work? I will look online to see if there's a better way to run a test before merging that might save me time and also catch mistakes earlier.
See #213 as an example of what I'm talking about.

There's not a great solution to this problem and there's other problems that are more pressing. Closing.

Figured out an okay solution: If you have a manual workflow trigger then you can specify the branch from which you'd like to test! Bingo.


Fix build error for int to string conversion (#396)

Fixes build issue
pkg/kfapp/aws/aws.go:564:74: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)

Fixed as suggested, sinc the result should be string with the actual port number.

@googlebot I signed it!

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

Googlers: Go here for more info.

@googlebot I signed it!

/ok-to-test

@pinkavaj What's your golang version?  We didn't see this issue in the past

@pinkavaj What's your golang version? We didn't see this issue in the past

go version go1.15 linux/amd64

I see. That's probably the reason. Seems this is an backward incompatible change after checking https://github.com/golang/go/issues/32479 and https://github.com/prometheus/prometheus/issues/7706
We can make this change for higher go versions.  Thanks for contributing!
/lgtm
/approve


Adding some documentation

Needing to retrieve using this as an interesting pl/pgsql example...

Thanks for the PR Chris!


Mistake in configuration for Symfony

Hi
I found a error in https://github.com/korridor/symfony-scaleway-tem-mailer#symfony
<EMAIL_ADDRESS>
In think it should be :
<EMAIL_ADDRESS>
Thank you for your work

@sylvainlg Thanks for your issue. I just updated the README. I'm not convinced that I agree with the statement that this is an error, but it is for sure clearer this way.


some style changes and fixes

Full-sized website window for a modern look.
Added transitions to everything.
A new look for badges.

Also, added a new Legacy badge.

Provided a Hugo executable file like gradlew (fixes https://github.com/neoforged/websites/issues/33).
Fixed the single-lined code block on notices to look unreadable in light mode.
Covered some more IDEs in .gitignore.

Preview URL: https://pr-34.neoforged-website-previews.pages.dev

Hmm... I'll revert the changes you asked in a bit. It'll be nice if someone could make a better fullscreen solution; the current one is just pretty bugging.

Ok!
Also, I'll record some visual representations of the changes you and Sci have asked for better comparison. (and btw the highlight and the versions dropdowns were made pr-ed by me; just reading project-talk on discord lol)
the transition effect is already on neoforged.net

Does this look nice? I've removed the highlight on the dropdown text; it's now only on the badges.
https://github.com/neoforged/websites/assets/140878474/fbf76162-64ea-4ede-b3aa-baa7553edb4f

I've fixed the latest hugo crash, by disabling the google analytics feature.
https://github.com/neoforged/websites/issues/36 has been fixed by renaming Latest News to News. (This is already performed by the Recent Posts widget by showing the latest 5 news)
I've reverted back the fullscreen change.
Hovering on the installer, the dropdown title will no longer be dimmed.
The hovering feature is now only on the badges and the new version block on the dropwdown title.
I've fixed the odd-looking toggle button, when it changes from a square to a circle. It's now from a squicircle to a circle.

Should I do this?
https://github.com/neoforged/websites/assets/140878474/4af0adbb-13dc-4eb9-99a2-de7953f745f2

Should I do this?
rec_neo2.mp4

I think that's too distracting, personally.


[feature] add participant count to fast endpoint

Feature
Modified existing fast endpoint to also return the "participant count," i.e., the number of people participating in the fast (including the user). Only required adding participant count to the FastSerializer and defining a method to count the number of participants in a fast.
Additional Changes

Refactored retrieval of fast from request
Updated README

Looks good--manually tested


unsolved legend issue

Did anyone manage to solve legend issue? Otherwise the function is useless

I implemented them, please see my fork: https://github.com/kupiqu/plot2svg
Note beware that my fork presents many edits wrt to this repo


fix: impose dataset ownership check on old API

SUMMARY
The old API does not check for ownership, this PR fixes it
When a user tries to changes a dataset they do not own (and their not admins):

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

@villebro good point, adding it

@villebro good point, adding it

Codecov Report

Merging #12491 (4c0d674) into master (7aba4c2) will decrease coverage by 3.11%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #12491      +/-   ##
==========================================
- Coverage   66.29%   63.18%   -3.12%
==========================================
  Files        1015      486     -529
  Lines       49554    29912   -19642
  Branches     5079        0    -5079
==========================================
- Hits        32854    18901   -13953
+ Misses      16562    11011    -5551
+ Partials      138        0     -138

Flag
Coverage Δ

cypress
?

javascript
?

python
63.18% <50.00%> (-0.91%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/views/datasource.py
89.39% <42.85%> (-5.61%)
:arrow_down:

superset/commands/exceptions.py
91.30% <100.00%> (ø)

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.24%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-11.48%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

... and 552 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aba4c2...0ae16bf. Read the comment docs.

Codecov Report

Merging #12491 (4c0d674) into master (7aba4c2) will decrease coverage by 3.11%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #12491      +/-   ##
==========================================
- Coverage   66.29%   63.18%   -3.12%
==========================================
  Files        1015      486     -529
  Lines       49554    29912   -19642
  Branches     5079        0    -5079
==========================================
- Hits        32854    18901   -13953
+ Misses      16562    11011    -5551
+ Partials      138        0     -138

Flag
Coverage Δ

cypress
?

javascript
?

python
63.18% <50.00%> (-0.91%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/views/datasource.py
89.39% <42.85%> (-5.61%)
:arrow_down:

superset/commands/exceptions.py
91.30% <100.00%> (ø)

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.24%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-11.48%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

... and 552 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aba4c2...0ae16bf. Read the comment docs.

Could you add this popup and prevent edition also for legacy editor?
https://user-images.githubusercontent.com/25153919/104449773-6a820900-559f-11eb-8a75-beb2df2aa6da.mov

Could you add this popup and prevent edition also for legacy editor?
https://user-images.githubusercontent.com/25153919/104449773-6a820900-559f-11eb-8a75-beb2df2aa6da.mov

It would be nice if we could disable the buttons that the user does not have access to, like edit and delete (not necessarily here, but in a follow-up PR)

It would be nice if we could disable the buttons that the user does not have access to, like edit and delete (not necessarily here, but in a follow-up PR)

after latest commit:
for legacy editor: You don't have the rights to alter [FCC 2018 Survey2]
small question -> should we in [] display original name or the one we would like to set?

after latest commit:
for legacy editor: You don't have the rights to alter [FCC 2018 Survey2]
small question -> should we in [] display original name or the one we would like to set?

@adam-stasiak unfortunately it's sort of hard to get the old state at this point just by using FAB the pre FAB hook. This views are going to be removed I hope pretty soon, so probably not worth to invest too much time on it

@adam-stasiak unfortunately it's sort of hard to get the old state at this point just by using FAB the pre FAB hook. This views are going to be removed I hope pretty soon, so probably not worth to invest too much time on it

A lot of our users rely on editing datasets they're not owners of, so this was a breaking change. I've had to manually alter the owners of ~10 important datasets that were owned by users who are no longer active, and we're concerned that this feature might inadvertently encourage users to create duplicate datasets to avoid this restriction.
It'd be nice if we could enable this feature again with a permission (instead of a role), feature flag, or similar.
@villebro @dpgaspar


translationRecorder: Pre-Recording Level Test

User Story
As a user, I would like to be able to determine and test the recording level so that I can know beforehand if input would be truncated.
Definition of Done

This User Story reflected a previous design feature where testing of the audio levels happened prior to and separate from the actual recording page.  As that is now happening on the recording page, this User Story is being deprecated


OCF host unable to pay with TransferWise even though it's connected

Transferwise is activated for Foundation:

But on an expense you're unable to select bank transfer as the payout option:

Hey @alanna, I wasn't able to reproduce this on production.
Can you confirm that this was an expense being submitted to the host itself? (through https://opencollective.com/foundation/expenses/new)

May have been solved in https://github.com/opencollective/opencollective/issues/3302 with https://github.com/opencollective/opencollective-api/pull/4159 + https://github.com/opencollective/opencollective-frontend/pull/4573

this is working now thanks


[Export-T2TAttributes] PrimarySMTPAddress is defined by UPN

Currently the Import-T2TAttributes defines the PrimarySMTPAddress based on the user's UPN. Even if in most cases UPN should match the PrimarySMTPAddress for best practices, there are scenarios where both values don't match.
The destination PrimarySMTPAddress must be the same source PrimarySMTPAddress but replacing the domain according to the domain mapping CSV logic.

Fix https://github.com/SignorelliDenis/T2TScripts/pull/28


Make the config from env more obvious at first glance; explain cascading config

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

:book:

Thanks for contributing to our documentation. We :heart: our documentarians!

  Generated by :no_entry_sign: dangerJS against 31868e915d47b58b48c5b7d4a3a8623776b785fc

Oops! Will re-approve once prettier is satisfied 😄


pubsub Message class does not set timestamp

pubsub.Message timestamps are not set.  There are two object properties, neither of them is set.  What's even more confusing is that attempting to access an attribute of an instance throws an error.
To reproduce:
from gcloud import pubsub
t = pubsub.Client(project='...').topic('${TOPIC}')
# MAY NEED t.create()
s = t.subscription('${SUBSCRIPTION}')
# MAY NEED s.create()
t.publish('test data')  # RETURNS A MSG ID
ack_id, m = s.pull()  # WAS t.pull()

Trying to repro right now.

@kir-google-cloud-pubsub I can't reproduce. ack_id, m = s.pull() is essentially invalid, but maybe you meant to say
pairs = s.pull()
ack_id, m = pairs[0]

When I run the slightly modified code, I get
>>> pub_id = t.publish('test data')
>>> pub_id
u'44126525330808'
>>> msgs = s.pull()
>>> assert len(msgs) == 1
>>> ack_id, m = msgs[0]
>>> m.message_id
u'44126525330808'
>>> m.message_id == pub_id
True
>>> m.data
'test data'

Any more details you can provide?

You are right -- about the mistake I meant.  In your code, try m.timestamp -- it should be set, but is not.

also, m.service_timestamp

There are two timestamps possible on a message:

message.timestamp is in the attributes of the message, and must therefore be set by the topic:  setting those is controlled by the topic.timestamp_messages attribute, which defaults to False.
message.service_timestamp is set by the back-end, and parsed from the publishTimestamp field of the pulled message resource.

To activate the first kind:
from gcloud.pubsub.client import Client
client = Client(project='...')
topic = client.topic('${TOPIC}', timestamp_messages=True)
t.create()
s = t.subscription('${SUBSCRIPTION}')
s.create()
t.publish('test data')
ack_ids = []
for ack_id, m in s.pull():
    ack_ids.append(ack_id)
    print(m.data, m.timestamp, m.service_timetamp)
sub.acknowledge(ack_ids)

On my box, the previous example yields:
(datetime.datetime(2016, 9, 7, 20, 42, 18, 810563, tzinfo=<UTC>), 'test_data', None)

That tells me that for some reason the back-end is not setting the publishTimestamp field in the message resource it is returning, but that the timestamp attribute set by the publishing application is being set.

It appears that the GAX/gRPC adapter for pubsub is not mediating between the publish_timestamp field in the PublishedMessage proto and the expected publishTimestamp field (as returned from the JSON-over-HTTP API).


Fix/wit bindgen file check

Summary by CodeRabbit

Chores

Enhanced validation process for WIT API in CI workflow.
Updated module import paths and refactored configuration deserialization in Hetzner plugin.

/merge

/approve
/merge

/merge force


docs: add links

为插件添加套件的链接
修复 https://github.com/ice-lab/iceworks/pull/86 引入的 Lint 问题

Codecov Report

:exclamation: No coverage uploaded for pull request base (releases/0.1.2@6d1f28e). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             releases/0.1.2      #87   +/-   ##
=================================================
  Coverage                  ?   78.81%
=================================================
  Files                     ?       25
  Lines                     ?      958
  Branches                  ?      185
=================================================
  Hits                      ?      755
  Misses                    ?      203
  Partials                  ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d1f28e...5567a8d. Read the comment docs.


Correction for raw affiliation Professor, Department of Family Medicine, Schulich School of Medicine & Dentistry, Western University, London, ON, Lecturer, Department of Family and Community Medicine, Temerty Faculty of Medicine, University of Toronto, Toronto, ON.

Correction needed for raw affiliation Professor, Department of Family Medicine, Schulich School of Medicine & Dentistry, Western University, London, ON, Lecturer, Department of Family and Community Medicine, Temerty Faculty of Medicine, University of Toronto, Toronto, ON.
raw_affiliation_name: Professor, Department of Family Medicine, Schulich School of Medicine & Dentistry, Western University, London, ON, Lecturer, Department of Family and Community Medicine, Temerty Faculty of Medicine, University of Toronto, Toronto, ON.
new_rors: 03dbr7087;02grkyz14
previous_rors: 03dbr7087;05167c961
works_examples: W4389620880
contact: bef53d41f6515e304297ea1760009d6e:8496a3971a07162b @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Update README.md

Please remember the Contributing Guidelines :heart:
:star2: What does this PR do?
Close the a tag to avoid the link underline

:bug: Recommendations for testing
All changes should be tested across Chrome and Firefox.
View README mode preview
:memo: Links to relevant issues or information
No issue related

@nose-gnome merge it please

@nose-gnome merge it please

@AdrianBou Done, sorry it took so long, I only just saw this.


[Feature]: All execution plan are expanded by default

Is your feature request related to a problem?
All execution plan are expanded by default
Describe the solution you'd like
All execution plan are expanded by default
Additional context
No response

this feature had been merged at
https://github.com/oceanbase/odc-client/commit/4a99cf47453c137fe8a2ff26a85b473baa5d1663


Support multibatch test

update bbox_results to support multi batch test [#89 ]
fix unittest bug in test_part_aggregation_ROI_head.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.wuyuefeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Make the unit test data tests/test_samples/parta2_roihead_inputs.npz smaller than 100KB to reduce the burden of downloading/cloning the repo.


Display entire Commons category names in category autosuggestion

When I want to select a Commons category with a long name in the Commons Extension category selector screen, and when there are multiple categories that have the same beginning, it's currently not possible to distinguis the difference between them during autosuggest. See screenshot:

In this example, we have for instance Category:Sculptures in Rotterdam-Noord / Category:Sculptures in Rotterdam-Zuid etc etc. It would be good to redesign the dropdown a bit so that the full category names become visible (even though they may sometimes be really long).
In the screenshot above, the category names (truncated) are actually repeated (bigger bold and smaller greyish), which may replicate other design patterns in OpenRefine (?) but perhaps it makes more sense to display the category name only once, but then fully.
For comparison, this is what autosuggest looks like in Wikimedia Commons' own search box

Approaches can be:

Only display category name
And make the box longer/wider

In the v4 wireframes by @lozanaross the dropdown menu looks quite simple:

Not sure if this is in line with other menu formatting in the tool, but it looks good to me (simple and clear).


Create CODE_OF_CONDUCT.md

issue #753
Note:
Some edits are required in the last few paragraphs

Hey @BobinMathew could you follow the comment made by @arielvalentin?  -> https://github.com/open-telemetry/opentelemetry-ruby/issues/753#issuecomment-842502725
The java implementation took the approach suggested above as well https://github.com/open-telemetry/opentelemetry-java/blob/main/code-of-conduct.md
This way we don't have to worry about our copy falling out of sync if the community code of conduct changes at any point.

Hi @robertlaurin, is this what you want ?

@BobinMathew can you please sign the CLA?

@BobinMathew can you please sign the CLA?

I did ;but it's not working.
I signed a CLA with opentelemetry-cpp, it worked.
Now when I sign its redirecting to the opentelemetry-cpp repo

Hmm, weird - can you try pushing an empty commit?

I think the problem's solved now 😃


doesn't work for me

Hello,
I can't understand how to get your extension work in Laravel 4.2
I just made a controller
thumbnail($size, $mode);
    $destination = 'img/header.thumb.jpg';
    $thumbnail->save($destination);
    return "thumbnail created";
}

in router.php
Route::get('gallery/thumb', 'ImageController@create_thumbnail');

and I got empty page and thumbnail is not created in img folder

You need to include a full path to 'img/header.jpg', Imagine can't just magically know the file location, provide a full path.

img folder located just in public
so for example this works fine
$files = File::allFiles('img');
foreach ($files as $file)
{   echo '';   }

Above code are Laravel, for Imagine we don't dictate how you want to store your file, you could either use public directory, storage directory and only allow access from a controller or etc. Again provide a full path is how you solve this.

I tried like this
$thumbnail   = Imagine::open(public_path().'img/header.jpg')->thumbnail($size, $mode);
$destination = public_path().'img/header.thumb.jpg';
and like this
$thumbnail   = Imagine::open(public_path().'/img/header.jpg')->thumbnail($size, $mode);
$destination = public_path().'/img/header.thumb.jpg';
but no success. I even don't have any error page. Just white blank page.

Have you look in Laravel error logs?

last error I have in log file is about wrong template file, not about ImageController or wrong path to file

Fresh Laravel 4.2 with Imagine 2.2 configured:
<?php

use Imagine\Image\Box;
use Imagine\Image\ImageInterface;
use Orchestra\Imagine\ImagineManager;
use Orchestra\Imagine\Facade as Imagine;

function create_thumbnail($path, $filename, $extension)
{
    $width  = 320;
    $height = 320;
    $mode   = ImageInterface::THUMBNAIL_OUTBOUND;
    $size   = new Box($width, $height);

    $thumbnail   = Imagine::open("{$path}/{$filename}.{$extension}")->thumbnail($size, $mode);
    $destination = "{$filename}.thumb.{$extension}";

    $thumbnail->save("{$path}/{$destination}");
}

Route::get('/', function()
{
	create_thumbnail(public_path(), 'adam', 'jpg');

	return View::make('hello');
});

So I not sure how I can replicate this issue, I might be related to GD http://stackoverflow.com/questions/5531105/php-gd-always-shows-blank-page


python311Packages.nettigo-air-monitor: 2.2.0 -> 2.2.1

Diff: https://github.com/bieniu/nettigo-air-monitor/compare/refs/tags/2.2.0...2.2.1
Changelog: https://github.com/bieniu/nettigo-air-monitor/releases/tag/2.2.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 266425 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.nam
python310Packages.nettigo-air-monitor
python310Packages.nettigo-air-monitor.dist
python311Packages.nettigo-air-monitor
python311Packages.nettigo-air-monitor.dist

Uh, that commit is a mix of a lot of things now.

Result of nixpkgs-review pr 266425 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.nam
python310Packages.nettigo-air-monitor
python310Packages.nettigo-air-monitor.dist
python311Packages.nettigo-air-monitor
python311Packages.nettigo-air-monitor.dist

Uh, that commit is a mix of a lot of things now.

Yupp, that rebase went wrong. Should be fixed now.

The master branch is already on 2.2.1, so you're only refactoring the package. Please update the commit message accordingly.

@ofborg eval


Export table schema

Related issue #423

@paulfitz I made the modifications you suggest but I got an issue on the CI. It broke I don't know the reason.

@paulfitz I made the modifications you suggest but I got an issue on the CI. It broke I don't know the reason.

@LouisDelbosc Looks like there was a random timeout, sorry. Ran again and got this:
...
***
(1) DocApi should work with a home server and a docworker GET /docs/{did}/download/table-schema serves table-schema-encoded document
AssertionError: expected { Object (format, mediatype, ...) } to deeply equal { Object (format, mediatype, ...) }
    at Context.<anonymous> (test/server/lib/DocApi.ts:2145:12)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

@paulfitz I could reproduce the error in local. Here the issue:
When Redis is used, we have a different serverUrl than the req.get('host') in express gets us.
Do you have an idea how to fix this ? It seems than using a homeserver and a docworker make it difficults for requestUtils.getOriginUrl to get the path called to the server.

GristServer.getResourceUrl is an empty string, which is kinda weird. I'm still investigating.

It returns a Promise, you need to await it.


draft commit to setup Solid

cd dnd5esheets/front
npm install
npm run dev -- --open

The connection with the backend is not started yet, I focued on the presentation. We'll need a store to use the backend client to populate the characters, and provide them to the different pages. In the meantime, I just put the json as a mock in a few pages.
Everything is still a bit drafty, but it start to take shape.

I have merged the PR directly in main as there were conflicts deemed to complicated to resolve in the web editor. Somehow, github does not see this PR as merged, but it is!
<3<3<3


CBMC: State and prove spec for poly_basemul_montgomery_cached()

State and prove spec for poly_basemul_montgomery_cached(). Make sure the output bound is strong enough to ensure accumulation of MLKEM_K instances in the higher-level matrix-vector product.
Depends on: #280 #281

Done in #283

Done in #299


Spaces Stats Endpoint

It would be nice to be able to fetch:

number of claimed spaces
number of expired spaces
number of moved spaces
number of set keys
number of deleted keys
total value set
total value expired

This would involve a database migration for existing spacesvm's and a couple new singleton db values.

Can this be stored directly on spacesvm? Using simple embedded logic?


revgrid option implementation

Code reference: https://github.com/erkyrath/remglk/blob/master/main.c#L208
Option is in help, but is it implemented in the code?  RIght now the text grid for status has style 'normal' - was your thought to set this to a 'reverse' when that line goes out?  That wold work for me.

No, remglk has no revgrid option. I originally created remglk by cloning glkterm, long ago, and I accidentally left that line in the help text. It has now been removed.
Remglk does not make any text style decisions at all; it just passes the window information over to the display layer. So there's no place in it for "reverse grid".


Valid number in Norfolk Island reported as invalid

Imported from Google Code issue #561 created by<EMAIL_ADDRESS>on 2014-11-25T10:06:27.000Z:

What steps will reproduce the problem?
Try to validate +672350360.
What is the expected output? What do you see instead?
Expected: Number is valid.
What version of the product are you using? On what operating system?
r715
Please provide any additional information below.
I called to this number (it's a hotel) and talked with this person.
http://en.wikipedia.org/wiki/Telephone_numbers_in_Norfolk_Island

Fixed in v7.0.2


After exporting the louislam/uptime-kuma container then importing to new server, i get errors.

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
cat mykuma_export.tar.gz | docker import --message "Imported from Mike's laptop" - louislam/uptime-kuma:1
sha256:ceda731d0e13fe6fb434372dc66f2644272ad52792c523dd684549fbbe00d936
root@DCWVM20UBU08043:/home/user/mykuma#
root@DCWVM20UBU08043:/home/user/mykuma# docker images
REPOSITORY             TAG       IMAGE ID       CREATED         SIZE
louislam/uptime-kuma   1         ceda731d0e13   8 seconds ago   345MB
root@DCWVM20UBU08043:/home/user/mykuma# docker-compose up -d
Creating uptime-kuma ... error
ERROR: for uptime-kuma  Cannot create container for service uptime-kuma: No command specified
ERROR: for uptime-kuma  Cannot create container for service uptime-kuma: No command specified
ERROR: Encountered errors while bringing up the project.
root@DCWVM20UBU08043:/home/user/mykuma# ^C
root@DCWVM20UBU08043:/home/user/mykuma# docker-compose down
Removing network mykuma_default
root@DCWVM20UBU08043:/home/user/mykuma# docker-compose up -d
Creating network "mykuma_default" with the default driver
Creating uptime-kuma ... error
ERROR: for uptime-kuma  Cannot create container for service uptime-kuma: No command specified
ERROR: for uptime-kuma  Cannot create container for service uptime-kuma: No command specified
ERROR: Encountered errors while bringing up the project.
root@DCWVM20UBU08043:/home/user/mykuma# docker-compose up
Creating uptime-kuma ... error
ERROR: for uptime-kuma  Cannot create container for service uptime-kuma: No command specified
ERROR: for uptime-kuma  Cannot create container for service uptime-kuma: No command specified
ERROR: Encountered errors while bringing up the project.
root@DCWVM20UBU08043:/home/user/mykuma# docker-compose down
Removing network mykuma_default
root@DCWVM20UBU08043:/home/user/mykuma# docker-compose up
Creating network "mykuma_default" with the default driver
Creating uptime-kuma ... error
ERROR: for uptime-kuma  Cannot create container for service uptime-kuma: No command specified
ERROR: for uptime-kuma  Cannot create container for service uptime-kuma: No command specified
ERROR: Encountered errors while bringing up the project.
root@DCWVM20UBU08043:/home/user/mykuma# docker run -d --restart=always -p 3001:3001 -v uptime-kuma:/app/data --name uptime-kuma louislam/uptime-kuma:1
docker: Error response from daemon: No command specified.
🐻 Uptime-Kuma Version
1.18.5
💻 Operating System and Arch
Ubuntu 20.04 x64
🌐 Browser
Microsoft Edge Version 106.0.1370.52 (Official build) (64-bit)
🐋 Docker Version
Docker version 20.10.12, build 20.10.12-0ubuntu2~20.04.1
🟩 NodeJS Version
No response

3 things I would think of from start:
Permission problems?
File paths of the imported compose file not correct set?
Other conflicts caused by settings?
Aside from that, why not just copying the data folder (or just the database) to the new computer?

The permissions are the same as the working server.
I have copied the data.  My problem is importing the container then starting it up.  Since I don't have internet access, I had to export it from my test server.

Not sure why it would be needed, but could try adding command in the docker compose to the same command that's set in the dockerfile.


Wordpress: Uncaught ReferenceError: Invalid left-hand side in assignment

This is:

question

Specifications

AOS version: 2.3.4
OS: Windows 10
Browser: Chrome 75

Actual Behavior
When I load AOS from within Wordpress, I get an error in the browser console: Uncaught ReferenceError: Invalid left-hand side in assignment. No animations work.
Steps to Reproduce the Problem

Direct download latest version
Copy aos.js and aos.css from aos-master\dist folder
Enqueue these files using Wordpress wp_enqueue_script
Load page and see the console error Uncaught ReferenceError: Invalid left-hand side in assignment. No animations work.

Detailed Description
First I tried installing with npm and found this error. I checked a couple of past issues and thought it might be an issue with my local install. Downloading from the direct link, however, and the problem still remains.
If I load aos from a plain html file (not within Wordpress), everything is working fine, so the problem is Wordpress. I don't know if this is fixable or if I should give up.

Hi, did you solve this problem?

@adamskaiza Yes, indirectly, I installed a plugin from the Wordpress repository called Animate It! It introduces unwanted behaviour (such as a new button in any rich text editor field), but otherwise I'm happy with it.


Vault secured with external certs

I'd like to deploy this app, but unfortunately it makes quite a few assumptions about Vault TLS config.
I secure my vault HTTP API access with an external CA cert/cert/key. With the deployment method listed, I can't supply a CA bundle to verify access to it.
It would be good to not have such a reliance on the vault pki store, and have the option to pass a base64 or pem encoded CA/Cert using the TLSConfig option: https://godoc.org/github.com/hashicorp/vault/api#TLSConfig

Thanks for your interest in this project. These are all very good points and the controller should definitely support using an external CA for dealing with TLS.
I think introducing new environment variables to support this would probably cause too much confusion.
Perhaps it's time to move all the configuration into a config file and have it mounted to the container using kubernetes' ConfigMap?

Totally agree, a configmap is a great idea.

Alternatively, it seems possible to just make use of ReadEnvironment for less messing with env vars within the code?
https://godoc.org/github.com/hashicorp/vault/api#Config.ReadEnvironment

I believe that reads in environment variables for configuring Vault. Since this controller is deployed separately to vault, we would have our own set of environment variables or configuration.

I've merged PRs #7 and #8 to change configuration of the controller to use config files. Included is also support for using CA Root bundles, certificate files and keys.
The documentation in the README has been updated to reflect this.
I am planning to resolve a few more issues before releasing 0.3.0 which will include this improvement.


Add interface for managing the output files

Add an interface to manage the files outputted by the translation engine. This will make the implementations of the translators cleaner and will create a structure that will be easy to extend to for other UI testing frameworks.

This has been completed I have added an interface to handle this, it is named FileModifierInterface.

5106b559a035d3bbe3980444ea9356d94e378e78
commit number id above.