Deleting installed app should show the helm operations logs

When deploying an app, we show the helm operations log. Can we do the same when we delete an app which is calling a helm uninstall?
Since there is a delay before anything is updated, it would be good to have it show the operations as it uninstalls it.

This won't be relevant after apps become their own first-class type again.

https://github.com/rancher/dashboard/pull/1710

On 2.5-head - commit id: 0465f049

Deploy CIS app.
After it has successfully deployed, select app and crd app. and click on Delete
EOF is seen in the pop up window and the app is NOT deleted

Request sent : Post on https://rancher-server/k8s/clusters/c-m4p4x/v1/catalog.cattle.io.apps/cis-operator-system/rancher-cis-benchmark?action=uninstall gives a 500 Internal Server Error

On 2.5.2-rc4 and master-head - commit id: 8aa1d48c

Deploy CIS benchmark app
Delete the app
Logs seen:

helm uninstall --namespace=cis-operator-system rancher-cis-benchmark
--
Fri, Oct 30 2020 8:45:04 pm | Starting delete for "cis-operator" Deployment
Fri, Oct 30 2020 8:45:05 pm | Starting delete for "cis-operator-installer" ClusterRoleBinding
Fri, Oct 30 2020 8:45:05 pm | Starting delete for "cis-operator-rolebinding" ClusterRoleBinding
Fri, Oct 30 2020 8:45:05 pm | W1031 03:45:05.307508 21 warnings.go:67] rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding
Fri, Oct 30 2020 8:45:05 pm | Starting delete for "cis-operator-role" ClusterRole
Fri, Oct 30 2020 8:45:05 pm | Starting delete for "cis-admin" ClusterRole
Fri, Oct 30 2020 8:45:05 pm | Starting delete for "cis-view" ClusterRole
Fri, Oct 30 2020 8:45:05 pm | W1031 03:45:05.421794 21 warnings.go:67] rbac.authorization.k8s.io/v1beta1 ClusterRole is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRole
Fri, Oct 30 2020 8:45:05 pm | Starting delete for "default-clusterscanprofiles" ConfigMap
Fri, Oct 30 2020 8:45:05 pm | Starting delete for "cis-serviceaccount" ServiceAccount
Fri, Oct 30 2020 8:45:05 pm | Starting delete for "cis-operator-serviceaccount" ServiceAccount
Fri, Oct 30 2020 8:45:05 pm | Starting delete for "default-allow-all" NetworkPolicy
Fri, Oct 30 2020 8:45:06 pm | Starting delete for "rke-cis-1.5-permissive" ClusterScanBenchmark
Fri, Oct 30 2020 8:45:06 pm | Starting delete for "cis-1.5" ClusterScanBenchmark
Fri, Oct 30 2020 8:45:06 pm | Starting delete for "gke-1.0" ClusterScanBenchmark
Fri, Oct 30 2020 8:45:06 pm | Starting delete for "eks-1.0" ClusterScanBenchmark
Fri, Oct 30 2020 8:45:06 pm | Starting delete for "rke-cis-1.5-hardened" ClusterScanBenchmark
Fri, Oct 30 2020 8:45:06 pm | the server could not find the requested resource (delete clusterscanbenchmarks.cis.cattle.io rke-cis-1.5-permissive)
Fri, Oct 30 2020 8:45:06 pm | the server could not find the requested resource (delete clusterscanbenchmarks.cis.cattle.io rke-cis-1.5-hardened)
Fri, Oct 30 2020 8:45:06 pm | the server could not find the requested resource (delete clusterscanbenchmarks.cis.cattle.io cis-1.5)
Fri, Oct 30 2020 8:45:06 pm | the server could not find the requested resource (delete clusterscanbenchmarks.cis.cattle.io eks-1.0)
Fri, Oct 30 2020 8:45:06 pm | the server could not find the requested resource (delete clusterscanbenchmarks.cis.cattle.io gke-1.0)
Fri, Oct 30 2020 8:45:06 pm | Starting delete for "gke-profile" ClusterScanProfile
Fri, Oct 30 2020 8:45:06 pm | Starting delete for "cis-1.5-profile" ClusterScanProfile
Fri, Oct 30 2020 8:45:06 pm | Starting delete for "rke-profile-hardened" ClusterScanProfile
Fri, Oct 30 2020 8:45:06 pm | Starting delete for "rke-profile-permissive" ClusterScanProfile
Fri, Oct 30 2020 8:45:06 pm | Starting delete for "eks-profile" ClusterScanProfile
Fri, Oct 30 2020 8:45:06 pm | the server could not find the requested resource (delete clusterscanprofiles.cis.cattle.io eks-profile)
Fri, Oct 30 2020 8:45:06 pm | the server could not find the requested resource (delete clusterscanprofiles.cis.cattle.io rke-profile-hardened)
Fri, Oct 30 2020 8:45:06 pm | the server could not find the requested resource (delete clusterscanprofiles.cis.cattle.io rke-profile-permissive)
Fri, Oct 30 2020 8:45:06 pm | the server could not find the requested resource (delete clusterscanprofiles.cis.cattle.io gke-profile)
Fri, Oct 30 2020 8:45:06 pm | the server could not find the requested resource (delete clusterscanprofiles.cis.cattle.io cis-1.5-profile)
Fri, Oct 30 2020 8:45:06 pm | release "rancher-cis-benchmark" uninstalled
Fri, Oct 30 2020 8:45:06 pm |
Fri, Oct 30 2020 8:45:06 pm | ---------------------------------------------------------------------
Fri, Oct 30 2020 8:45:06 pm | SUCCESS: helm uninstall --namespace=cis-operator-system rancher-cis-benchmark
Fri, Oct 30 2020 8:45:06 pm | ---------------------------------------------------------------------


tixati: 2.88 -> 2.89

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/tixati/versions.
meta.description for tixati is: "Torrent client"
meta.homepage for tixati is: "http://www.tixati.com"
meta.changelog for tixati is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/2qddxqkidcsk1bchc83qjf88dmgn49gd-tixati-2.89/bin/tixati had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 2.89 with grep in /nix/store/2qddxqkidcsk1bchc83qjf88dmgn49gd-tixati-2.89
found 2.89 in filename of file in /nix/store/2qddxqkidcsk1bchc83qjf88dmgn49gd-tixati-2.89

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
tixati

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/2qddxqkidcsk1bchc83qjf88dmgn49gd-tixati-2.89 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tixati https://github.com/r-ryantm/nixpkgs/archive/e70add1c86e7f45745c7299dd2ae00af9c39775e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/2qddxqkidcsk1bchc83qjf88dmgn49gd-tixati-2.89
ls -la /nix/store/2qddxqkidcsk1bchc83qjf88dmgn49gd-tixati-2.89/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

tixati

Maintainer pings
cc @volth for testing.

Result of nixpkgs-review pr 165330 run on x86_64-linux 1

1 package built:

tixati


Separate model, interface, and client generation

I'd love to be able to specify 3 separate filenames for each of these so I can properly modularize my app without doing work after each generation, which is a bit impractical during initial development.

Option to generate contracts and clients


Handle semicolon properly

issue:
#1
What I did:
Allow multiline function call
Added case
class Test
  def foo(a: Int, b: Int) -> Int
    return a + b
  end
end

Test.new.foo(1,
2)

puts "ok"

Ready for review
Plz review this when it's convenient

Could you move the new tests under errorneos/method_call to a new directory like erroneous/parsing/? Then I'm ready to merge this :+1:

Yes. I'll work it later 👌

Could you move the new tests under errorneos/method_call to a new directory like erroneous/parsing/? Then I'm ready to merge this 👍

Done,  plz review this🙏
Move new tests under erroneous/parsing

Merged. Thanks!


Exported Excel doesn't import into PowerBI Online

When trying to import via the onedrive for business method, it returns "error 400" on the file. If I take the file, open it in excel, and save it, then it works fine. It also imports into PowerBI Desktop Fine without having to open it in excel first.
I wanted to use this in an Azure Function to batch export data from a proprietary system into a format I can use with PowerBI and automatically refresh hourly, and one excel with multiple worksheets is ideal so I can create relationships. I may be able to make this work with CSVs or an Azure SQL database I dump and rebuild periodicall but that is cumbersome.
Here is an example of "before" and "after" opening in excel and saving, maybe you can diff for what it's looking for. The excel file is significantly larger.
testexport.xlsx
testexport-saveinexcel.xlsx

Very cool. Will dig deeper.
I think this module in Azure functions will be very powerful.
I wired up the module here in an Azure function. Give it try.
https://getstockquoteinexcel.azurewebsites.net/api/RequestExcelStockInfo?symbol=msft,xom,ge,ibm,jpm,fb&email="<<your email address>>"

It's not the Azure functions part, that works great, it's that the file
generated doesn't import into power BI, regardless of if it was made in
functions or locally.
I'm guessing though I'm going to have to go to the EPPlus library people
about it as it seems to do with the internal format missing something
that's in a "Normal" excel save that PowerBI is erroring out on.
On Fri, Oct 27, 2017, 7:41 AM Doug Finke<EMAIL_ADDRESS>wrote:

Very cool. Will dig deeper.
I think this module in Azure functions will be very powerful.
I wired up the module here in an Azure function. Give it try.
https://getstockquoteinexcel.azurewebsites.net/api/RequestExcelStockInfo?symbol=msft,xom,ge,ibm,jpm,fb&email="<>"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dfinke/ImportExcel/issues/240#issuecomment-339987334,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOjVUoUdR4oWa5njxY61Vios7hhoirb8ks5sweh8gaJpZM4QIJUK
.

There appears to be an issue logged with EPPlus https://github.com/JanKallman/EPPlus/issues/168  where they even propose a fix.  Related to #254

As a workaround sounds like we can unzip/rezip the file with the. Net
compression library till the fix is implemented upstream. I'll give this a
try.
On Sat, Apr 7, 2018, 4:32 AM CrashM<EMAIL_ADDRESS>wrote:

There appears to be an issue logged with EPPlus JanKallman/EPPlus#168
https://github.com/JanKallman/EPPlus/issues/168 where they even propose
a fix. Related to #254 https://github.com/dfinke/ImportExcel/issues/254
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dfinke/ImportExcel/issues/240#issuecomment-379462909,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOjVUrPUmX0nli-arug48XNKqCmwDOjxks5tmKPDgaJpZM4QIJUK
.

@JustinGrote Sounds great.  Hope you can figure a minimalist set of commands.  Can you post your attempt please?

I've submitted #312 for a workaround for now until upstream EPPlus gets fixed

@JustinGrote Patch confirmed working with -ReZip parameter


libuv fails on MontaVista Linux

uv_accept is failing on MontaVista Linux.

Can you fill out the issue template? Please provide steps to reproduce.


Question

Does this package have a option like the Mail option in LARAVEL?
Mail::to($topicCreator->email)->send(new NewReply($user, $topic));

No, currently the package doesn't have anything like this built in. I've been planning the v3 of the package and definitely want to include events and other options that developers can hook into. Pre-made mailables would be nice too. I'll make a note of this :)

thanks


Added a fuzz target for baggage parsing

+ make clean

@howardjohn Who/When are the fuzz tests being run? I can't see it being run as part of the CI and locally it ran for hours.

@ymesika: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
878948cd16d2152261a2ae9c069329e6e8a6f211
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Typing on the editor is very slow

What steps will reproduce the problem?

Opened Spyder
Typed into editor

I use MacOS Catalina 10.15.7 and Spyder 5.0.5. Typing is significantly laggy but weirdly there's no such problem if I typed into the console.

Hey @vin9912, thanks for reporting. This is a duplicate of issue #15631. Please take a look at it for possible workarounds.


Memory leak in esp_mqtt_destroy_config() (IDFGH-2293)

Module or chip used:  ESP32-WROOM-32D
IDF version: v4.0-beta1-279-g0a03a55
Build System: Make
Compiler version: 8.2.0
Operating System: Linux
Power Supply:  external 3.3V

Problem Description
Calling esp_mqtt_destroy_client leaks about 216 bytes of memory because even loop is not freed.
The leak is located inside esp_mqtt_destroy_config which should call  esp_event_loop_delete but a is memset clears the handle before it is freed.
After some time of internet outage, the application will stuck becuse no memory available and error mbedtls ssl setup returned -0x7f00
Expected Behavior
esp_event_loop_delete should be called before memset, or vice-versa
Actual Behavior
Steps to repropduce

call esp_mqtt_client_init
call esp_mqtt_client_destroy
loop

Code to reproduce this issue
In file mqtt_client.c
static esp_err_t esp_mqtt_destroy_config(esp_mqtt_client_handle_t client)
{
    mqtt_config_storage_t *cfg = client->config;
    free(cfg->host);
    free(cfg->uri);
    free(cfg->path);
    free(cfg->scheme);
    memset(cfg, 0, sizeof(mqtt_config_storage_t));
    !!!!!!!!!!!!!!!!!!!! NOTE client->config->event_loop_handle now is NULL !!!!!!!!!!!!!!!!!!!!
    free(client->connect_info.will_topic);
    free(client->connect_info.will_message);
    free(client->connect_info.client_id);
    free(client->connect_info.username);
    free(client->connect_info.password);
    memset(&client->connect_info, 0, sizeof(mqtt_connect_info_t));
#ifdef MQTT_SUPPORTED_FEATURE_EVENT_LOOP
    !!!!!!!!!!!!!!!!!!!!  NOTE This never gets called !!!!!!!!!!!!!!!!!!!!
    if (client->config->event_loop_handle) {
        esp_event_loop_delete(client->config->event_loop_handle);
    }
#endif
    free(client->config);
    return ESP_OK;
}

This fixes the problem, allowing esp_event_loop_delete to be called:
static esp_err_t esp_mqtt_destroy_config(esp_mqtt_client_handle_t client)
{
    mqtt_config_storage_t *cfg = client->config;
    free(cfg->host);
    free(cfg->uri);
    free(cfg->path);
    free(cfg->scheme);
    free(client->connect_info.will_topic);
    free(client->connect_info.will_message);
    free(client->connect_info.client_id);
    free(client->connect_info.username);
    free(client->connect_info.password);
    memset(&client->connect_info, 0, sizeof(mqtt_connect_info_t));
#ifdef MQTT_SUPPORTED_FEATURE_EVENT_LOOP
    if (client->config->event_loop_handle) {
        esp_event_loop_delete(client->config->event_loop_handle);
    }
#endif
    memset(cfg, 0, sizeof(mqtt_config_storage_t));
    free(client->config);
    return ESP_OK;
}

Debug Logs
This is the log of heap trace recordered from init to destroy
3 allocations trace (100 entry buffer)
24 bytes (@ 0x3ffd8d30) allocated CPU 0 ccount 0xd7ac8400 caller 0x4018380e:0x4014c5db
0x4018380e: esp_event_loop_create at /media/paolo/Data/working/FW/esp32/esp-idf/components/esp_event/esp_event.c:418

0x4014c5db: esp_mqtt_client_init at /media/paolo/Data/working/FW/esp32/esp-idf/components/mqtt/esp-mqtt/mqtt_client.c:391

104 bytes (@ 0x3ffd8d4c) allocated CPU 0 ccount 0xd7ac8cb0 caller 0x4008e63a:0x4018383e
0x4008e63a: xQueueGenericCreate at /media/paolo/Data/working/FW/esp32/esp-idf/components/freertos/queue.c:392 (discriminator 2)

0x4018383e: esp_event_loop_create at /media/paolo/Data/working/FW/esp32/esp-idf/components/esp_event/esp_event.c:424

88 bytes (@ 0x3ffd8db8) allocated CPU 0 ccount 0xd7ac94f4 caller 0x4008e63a:0x4008e81b
0x4008e63a: xQueueGenericCreate at /media/paolo/Data/working/FW/esp32/esp-idf/components/freertos/queue.c:392 (discriminator 2)

0x4008e81b: xQueueCreateMutex at /media/paolo/Data/working/FW/esp32/esp-idf/components/freertos/queue.c:499

216 bytes 'leaked' in trace (3 allocations)
total allocations 27 total frees 24

This is the log of heap trace recordered after the fix:
0 allocations trace (100 entry buffer)
0 bytes 'leaked' in trace (0 allocations)
total allocations 27 total frees 27
Free Heap Size 2: 168372

Yeah, this looks like an oversight. We will fix this and close the issue when it has been deployed to Github.
Thank you for reporting this.

Hi @david-cermak
The fix has been in esp-mqtt tree for a month but not yet in esp-idf.
I'm wondering if it is normal taking such long time to merge the fix into esp-idf
especially when the fix is so trivial.

@AxelLin Hi,
Yeah, sorry for being slow about getting it into esp-idf, I'll push a merge request for it today.
Sorry for keeping you waiting.


Use mockito-scala-scalatest to enable strict mocks on all tests.

Inspired by the comment on #172 this PR uses the ScalaTest integration of mockito-scala so all mocks are strict by default.
An easy way to verify this would be to re-write the first test on LoggerSpec as (notice the extra direct call to underlying.info
    "call the underlying logger's error method if the error level is enabled" in {
        val f = fixture(_.isErrorEnabled, isEnabled = true)
        import f._
        logger.error(msg)
        underlying.info("called by accident")
        verify(underlying).error(msg)
    }

Executing such test would fail as
Unexpected invocations found

The following invocations are unexpected (click to navigate to relevant line of code):
1. logger.info("called by accident"); -> at com.typesafe.scalalogging.LoggerSpec.$anonfun$new$2(LoggerSpec.scala:26)
Please make sure you aren't missing any stubbing or that your code actually does what you want
org.mockito.exceptions.misusing.UnexpectedInvocationException: Unexpected invocations found

This change has already paid by itself as it shown that the tests on LoggerWithTaggedArgsSpec L#68 and L#77 were not testing anything as the wrong log level was being enabled

I don't know anything about Mockito... is there anyone watching this repo who can review this?
(If we can't find anybody, I guess I'll merge regardless after a waiting period...)


Now working when using tls client certificate auth

1. Is bug reproducible with latest forwardproxy build?
Yes

2. What are you trying to do?
using forwardproxy toghther with caddy's built-in TLS client certificate auth. the same configuration works fine without that  clients config/cert.pem line. The exact same configuration works fine when not using proxy (i.e., just website hosting)
3.  How is your client configured?
5.  If multiple servers are used (for example with upstream), describe those as well.
just run it in the bash
6. Please paste any relevant HTTP request(s) here.

7. What did you expect to see?
The proxy working. Client certificate and https proxy works fine when I use the software I wrote using nodejs with chrome, meaning chrome supports such configuration. so the problem is on the server side.
8. What did you see instead (give full error messages and/or log)?
chrome gives me ERR_PROXY_CONNECTION_FAILED.
9. How can someone who is starting from scratch reproduce the bug as minimally as possible?

generate a tls key-cert pair, transform these into a .p12 file
using the same caddy configuation, add some static files to host folder and the certificate generated at step 1 to the config folder
add the .p12 file to chrome (OS dependent)
you should be able to access the page, but there will be error when using it as proxy

NOTE: in practice I don't use chrome directly with the proxy, but that doesn't matter since the error occur anyway.

One more thing, when i use the nodejs client that i write instead of chrome, the tls connection can be established, its just that nothing will happen after that.

Log from my caddy server:
[ERROR] https://caddy.example.com - strict host matching: SNI (caddy.example.com) and HTTP Host (destination.example.com) values differ

By default, Caddy doesn't allow domain fronting when using client auth because of the obvious problem: clients could send a ServerName with the TLS handshake for an unprotected domain, then make HTTP requests with a Host header of a protected domain on that connection, thus bypassing authentication.
Caddy 2 allows you to disable this protection. Caddy 1 might too but I can't remember how without looking. 😅

@mholt, I was looking for a way to disable StrictHostMatching. My scenario is I'm using Caddy as a sidecar for my applications to do mTLS. The caddy receiving the TLS client auth has only 1 TLS listener and host being served, so the concerns about the SNI + Host header matching do not apply. Is there a way for me to disable StrictHostMatching? Browsing through the code I couldn't find it.
Note: Caddy v1.0.4

Hmm, there's not in v1 I don't think, but we can do this pretty easily in v2!

Gotcha... unfortunately v2 is still a no go for us since we rely entirely on DNS SRV for upstream discovery. Hence why I'm having the StrictHostMatching issue on v1 😄 . I have my upstream set as srv+https://myapp.service.consul and, obviously, that is not the same hostname that is in the Host header.

@danlsgiga We can change that, would your company be open to sponsoring that feature's development? I won't be working on v1 much anymore.


.zap files are too large and contain redundant data

"Shrink" the .zap files, essentially eliminating duplication. Go back to the model of "only record deviations, not the whole duplication". So if ZAP file is using the default Basic cluster, for example, it will NOT record duplications of all attributes that are mandatory anyway. It will only record the data BEYOND what the spec already lists.

Should .zap capture the version of xml it is complying with for "versioning" purpose?
Otherwise, what happens when the XML are updated and the .zap's "baseline" is essentially changed?

Based on our discussion, we can have a save as option which just saves the enabled content in the zap file. The saved options should follow the hierarchy in the following order:

endpoint
cluster
attribute and commands

For eg:

If 1 is not enabled then we should lose 2 and 3 from the json file.
if 2 is not enabled for an endpoint then lose 3 from the json file

Resolved in https://github.com/project-chip/zap/pull/1153


Make section alignable

Currently all emails are centered. I would like to send emails which are not centered.
I have attached screenshots for this mjml code.
<mjml>
  <mj-body>
    <mj-section align="left">
      <mj-column>
        <mj-divider border-color="#F45E43"></mj-divider>
        <mj-text font-size="20px" color="#F45E43" font-family="helvetica">Hello World</mj-text>
      </mj-column>
    </mj-section>
  </mj-body>
</mjml>

Hey @thomaschaaf, thanks for this PR.
Can you please explain the use-case? It's not very clear to us and we're a bit afraid of issues that could be caused by this PR. Example: I just tried having 2 sections with one left-aligned and one right-aligned and it produces this:

This was merged by mistake and reverted

@ngarnier why not use the revert merge from github? I have now created a new pr.

I was waiting for your feedback on the comments + question @thomaschaaf. Let's now keep it on the new PR you opened then.


k8s hooks should create Jobs, not Pods

I originally filed this bug with ARC(https://github.com/actions-runner-controller/actions-runner-controller/issues/2031#issuecomment-1324354979) but got redirected here. Kubernetes has a known race where Pods can get scheduled on nodes, but then get rejected by the kubelet (for example, for OutOfcpu). As noted in the comment thread, using plain Pods is an anti-pattern. It's preferable to use Jobs, so they can handle retries as needed.

Hey @willchan,
Thank you for raising this issue and using runner-container-hooks! I would say that using pods really depends on your use case.
If the job's pod fails, do we really need to restart it? What if the run-script-step kills the container? Does it make sense to re-run the job container that will be cleaned up after the job?
The idea is to use the simplest resource that should exist during the execution of a hook. If the job pod fails, we should fail the job. And also, the idea of k8s job resource is to execute something. What we really need here is a place where we can attach and execute commands within.
But maybe I am wrong.
But on the other hand, you can always customize this hook the way you see fit.

The Runner Container Hooks repo provides a set of packages that implement the container hooks feature in the actions/runner. These can be used as is, or you can use them as a guide to implement your own hooks.

However, I will discuss this issue with the team and let you know as soon as we decide how to proceed :relaxed:

Thanks for the response @nikola-jokic. I see this issue is more nuanced than I had anticipated. I wrote this as a new user of ARC, and was (and am still) unfamiliar with the internals of ARC and runner-container-hooks. From my perspective, it's a poor user experience to have scheduled k8s pods that fail to ever run cause my GitHub job to fail. I'm not really clear on the best way to address this issue however.

Thank you for raising this issue and using runner-container-hooks! I would say that using pods really depends on your use case. If the job's pod fails, do we really need to restart it? What if the run-script-step kills the container? Does it make sense to re-run the job container that will be cleaned up after the job? The idea is to use the simplest resource that should exist during the execution of a hook. If the job pod fails, we should fail the job. And also, the idea of k8s job resource is to execute something. What we really need here is a place where we can attach and execute commands within. But maybe I am wrong.

I can see an argument for using pods directly instead of k8s jobs here. That said, I don't know if the job pod fails, we should always fail the job. In my scenario, the job pod gets scheduled to a k8s node, and the kubelet rejects it before it ever gets a chance to run. This manifests as a pod failure, but since the pod never ran, it hasn't really failed, per se. It's more an artifact of k8s that they are forcing the user to retry this pod, or use a k8s job instead. Note the particular failure Pod failed to come online with error is at:
https://github.com/actions/runner-container-hooks/blob/643bf36fd8657dfdbff3f6272ed75b97c8346c06/packages/k8s/src/hooks/prepare-job.ts#L72-L81.

Hey @willchan,
No problem, I am happy to discuss it. As noted in Readme, this is just a basic implementation. If your cluster is not in a state where you can actually have it like this, you can customize it. One way you can also tackle this issue is, schedule your runners to run on nodes that are not running your applications. The issue would still persist if we change it to the Job, since we are having a nodeName being the same node where the runner is executing (see https://github.com/actions/runner-container-hooks/blob/d988d965c57642f972246e28567301f6b4c054e1/packages/k8s/src/k8s/index.ts#L130). The reason for that is volume mounts.
It would be rather difficult or impossible to have a hook working on every cluster in the world. There are so many variables that can affect its execution. That is why we provided this repository to serve as a base.
In most use-cases, you should not have issues executing the hook as is. But if your cluster is in a state where it is not possible, consider changing the way you are scheduling the runner pods to run on nodes running other containers, or changing the hook implementation itself :relaxed:

I think I hear that you are saying that this is beyond the scope of what runner-container-hooks should address since it's just a basic implementation, which seems reasonable to me. I'll go back to ARC and see what they have to say. While your suggestions sound reasonable at first blush, I am not qualified to evaluate them. The suggestion about tweaking the cluster might be reasonable, but I am deliberately trying to simplify our cluster administration by using vanilla GKE autopilot configurations. So I am loathe to tweak them. Maybe ARC will consider changing the hook implementation itself. Thanks for sharing your thoughts on this.

I mean, to change the hook in the ARC, the issue would still persist, since it would be related to your use-case, but not the generic one.
I think that having the basic hook is the right approach, and to change the implementation, the only thing you really need to change is this Dockerfile.
https://github.com/actions-runner-controller/actions-runner-controller/blob/fe05987eea33140abc11f70e49a8486b0dcd8cdd/runner/actions-runner.ubuntu-22.04.dockerfile#L64
Here, you don't pull the hook, you copy your own implementation build to the assets directory. And that is pretty much it. After you are done, you push your own image to your container registry and specify the image for the resource.


CoreOS Multinode cluster documentation fails on 1.3.0

For the life of me I can't get this working with verison 1.3.0 of Kubernetes via http://kubernetes.io/docs/getting-started-guides/coreos/coreos_multinode_cluster/
1.1.2 seems to work fine, but not 1.3.0.
Going to investigate this a bit further and throw some debug output in here.
cc @kelseyhightower

@cdrage I really want to get these "getting started guides" out of this repo and yield control of these docs to the upstream provider such as CoreOS in this case. Thoughts?

@kelseyhightower since a lot of these docs are outdated now in regards to documentation, I would agree for them to be remove and their respective upstream providers dedicate time / monitor them for changes :)

Page has vanished. Closing.


Signature window doesn't appear after inserting function from completion list

Make sure you have done the following

[X] I have updated to the latest version of blink.cmp
[X] I have read the README

Bug Description
The signature window doesn't appear immediately when I'm selecting function from the completion list. The function and its parameters are inserted correctly and the cursor jumps to the first parameter, but the signature window doesn't appear until I trigger it manually by deleting pre-inserted brackets and type the left bracket again (or insert a comma after first argument).
The behaviour is identical no matter whether the nvim-autopairs plugin is enabled or not.
Relevant configuration
accept = { auto_brackets = { enabled = true } },
signature = {
  enabled = true,
  trigger = {
    show_on_insert_or_trigger_character = true,
  },
},
windows = {
  autocomplete = {
    border = "rounded",
    selection = "manual",
  },
  documentation = {
    border = "rounded",
    auto_show = true,
  },
  signature_help = {
    border = "rounded",
  }
}

neovim version
NVIM v0.10.2
blink.cmp version: branch, tag, or commit
main

Fyi, on main, the configuration was reworked

Thanks a lot! I'll double check the config.


Feature/78 toast

pc Screenshots toast

@ElishaSamPeterPrabhu I have made some alignment fixes for iOS and also moved the close and action button to the xaml. Please run and check before merging. Please check Sofia's comment too

@rthanga1 Modified some padding and margin to fix alignment .Can you run it in iOS before merging?


useful-links: use public presentation links

These are now stored in the DPTP "presentations" directory, which is accessible
by all of Red Hat (but not publicly).

People from outside the team request access to these with some frequency (e.g.
https://coreos.slack.com/archives/CBN38N3MW/p1663766854625619), and no one was
oppoosed to making them public.  This replaces private links with news ones
which are visible to all inside Red Hat.

/lgtm


Add support for launching notebooks in Deepnote

New Feature: Deepnote Badge

Deepnote badge appears by default for notebooks along with GitHub, Colab and Binder badges
Option to switch it off is similar to all other badges
Details about the usage are added to README

Preview

This PR is inspired by #216, feel free to correct me if I missed something.
Example notebook in Deepnote: https://deepnote.com/project/fastpages-QBBzHgACTRe9w3frw8LAzw/%2F_notebooks%2F2020-02-21-introducing-fastpages.ipynb
Disclaimer: I am a developer at Deepnote, I am pushing this since some of our users requested this after migrating from Colab to Deepnote 🙂

/preview

Any feedback or help with approving me as a first-time contributor, please @hamelsmu?

Awesome! Can I apply it in my custom environment?

@goodboychan you mean Deepnote Custom Environment? Not currently, I'm sorry. This just picks up the .ipynb on the fastpages / github, and creates a new project with it. We're working on a possibility to use your Dockerfile in GH repo to build the custom env, but it'll take some time since it's not a priority. For now, I just suggest adding a hidden cell to the notebook that installs all required stuff. Or prepare your custom environment project in Deepnote and link that directly in your blogpost or page. Anyone who duplicates your existing Deepnote project with custom env will get that custom env automatically (cached).
@Dstiers1191 / @hamelsmu  would it be possible to allow CI in this PR so we can see that everything is passing?

@jakubzitny No, I mean that I can test it on my fastpages.
See the application like this
Sorry for confusion.

Oh, sorry about that @goodboychan. I think you'd have to merge the upstream version of fastpages, or somehow rebase to it. Once this is merged of course. Not sure what was your process of creating your own instance, but I'd guess rebase will work.

@Dstiers1191 / @hamelsmu thanks for the approval. Is there anything on our side that we can do to help get this merged?

I'll look into this today or tommorow sorry for the delay

/preview

LGTM thanks for the update!


Set a better AccessModifierOffset in clang-format

Default appears to be -2, which causes clang-format to mix tabs and spaces

what code is there to review

what code is there to review

More just the formatting changes that this incurs

@uniboi precisely what @ASpoonPlaysGames said. There's obviously no code review but rather the question whether the changes are wanted or not. The needs code review label is just the closest we have to indicate that there's still a need for someone to look at the changes and decide whether they are wanted (next to the obvious feedback wanted label)
@ASpoonPlaysGames should we merge this before or after some primedev cherry-picks? primedev doesn't have it so it might increase the div unless someone backports it to there ^^

@ASpoonPlaysGames should we merge this before or after some primedev cherry-picks? primedev doesn't have it so it might increase the div unless someone backports it to there ^^

idk, I fix formatting on primedev cherry picks anyway so i dont think it matters if this comes first for what i'm doing

Merging with 2 in favour (@ASpoonPlaysGames @p0358) and 1 slightly (but not fully) opposed (@Jan200101)
I asked for feedback on the #development on the Northstar Discord multiple times and this is all I got so I assume the remaining contributors are indifferent on the change.


Identity scaffolded item: default password validation

Default password validation doesn't allow to use letters from other languages.
Try to use password like:
паРоЛь999%=*
There will be an error:
Passwords must have at least one lowercase ('a'-'z').
Passwords must have at least one uppercase ('A'-'Z').

Package version of Microsoft.AspNetCore.App: 3.0.0-rc1.19457.4
Package version of Microsoft.VisualStudio.Web.CodeGeneration.Design: 3.0.0-rc1-19462-10

@blowdart this is by design I think right?

Feels like it yes. You can always replace it.


password -> tokenUrl   none is not an allowed value

I'm trying to set this up for a FastAPI which should authenticate against an existing Keycloak 17.0.1 server which I've customized according to https://fastapi-keycloak.code-specialist.com/keycloak_configuration/
FastAPI 0.95.0, fastapi-keycloak latest
During startup of the FastAPI server I get this stacktrace:
  File "/home/jovyan/app/main.py", line 93, in <module>
    def current_users(user: OIDCUser = Depends(idp.get_current_user())):
                                               ^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.11/site-packages/fastapi_keycloak/api.py", line 244, in get_current_user
    token: OAuth2PasswordBearer = Depends(self.user_auth_scheme),
                                          ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.11/functools.py", line 1001, in __get__
    val = self.func(instance)
          ^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.11/site-packages/fastapi_keycloak/api.py", line 223, in user_auth_scheme
    return OAuth2PasswordBearer(tokenUrl=self.token_uri)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.11/site-packages/fastapi/security/oauth2.py", line 151, in __init__
    flows = OAuthFlowsModel(password={"tokenUrl": tokenUrl, "scopes": scopes})
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "pydantic/main.py", line 341, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 1 validation error for OAuthFlows
password -> tokenUrl
  none is not an allowed value (type=type_error.none.not_allowed)

server_url is set to https://<server>:8443/realms/<realm>/protocol/openid-connect/auth
I see no option to configure the tokenUrl, with our keycloak server we configure as https://<server>:8443/realms/<realm>/protocol/openid-connect/token for other clients.
(I've also used the suggestion in #60 to avoid issues with the admin_cli which I don't need in that FastAPI server)

Hey @arminus unfortunately we abandoned developing this when the Keycloak API stability got worse and worse. The time we stopped has been with v15, so I can only confirm this package is working with v15. Your issue is most likely related to another breaking change.

We're open to Pull Requests, if you want to provide one.

Ok, thanks for the quick response. We'll into the code then.

Actually, the suggestion in https://github.com/code-specialist/fastapi-keycloak/issues/40#issuecomment-1189885336 gets me past that issue so I'll close this.


Advanced example custom markercluster.

Hello @jperelli.
This is not a issue report. I'm just starting to learn vue and js.
Your plugin helps a lot.
Please show an advanced example for changing the cluster marker color settings via refreshClusters ().
If necessary, I can bring the cog of my component with the map.
Thank you.

Hi, please provide your component code

`

Zoom: {{ zoom }}

            {{ item.title }}

                Подробнее

`

Hey, any news on this ?
I'm trying to change the clusters Icon but I did not find how to...
Where and how should I place the iconCreateFunction option ?
Thanks

@AlexisWalravens iconCreateFunction should be part of the options for the marker cluster.
<l-marker-cluster :options="clusterOptions">
with clusterOptions in you data of the component:
data() {
  return {
    ...
    clusterOptions: {
      ...
      iconCreateFunction: () => {
        ...
      }
    }
   ...
  }
}

all possible options are documented here: https://github.com/Leaflet/Leaflet.markercluster#all-options


UI of the deepActivity screen improved

@plazzy99 please check this pr
i have updated the bottom bar of the deep news screen


Issue with components library : Cannot read properties of null (reading 'registered')

I'm using a components library with @emotion/styled components (MUI components). I don't use any emotion cache.
As I understood it, it looks like vite-react-ssg prerender components server-side, and so I got this error because of this :
[vite-react-ssg] error: TypeError: Cannot read properties of null (reading 'registered')
    at file:///Users/<COMPONENT_LIBRARY>/dist/react-uikit.js:3258:49
    at file:///Users/<COMPONENT_LIBRARY>/dist/react-uikit.js:3174:12
    at renderWithHooks (/<MY_PROJECT_PATH>/node_modules/react-dom/cjs/react-dom-server.node.development.js:5724:16)
    at renderForwardRef (/<MY_PROJECT_PATH>/node_modules/react-dom/cjs/react-dom-server.node.development.js:5919:18)
    at renderElement (/<MY_PROJECT_PATH>/node_modules/react-dom/cjs/react-dom-server.node.development.js:6082:11)
    at renderNodeDestructiveImpl (/<MY_PROJECT_PATH>/node_modules/react-dom/cjs/react-dom-server.node.development.js:6181:11)
    at renderNodeDestructive (/<MY_PROJECT_PATH>/node_modules/react-dom/cjs/react-dom-server.node.development.js:6153:14)
    at renderForwardRef (/<MY_PROJECT_PATH>/node_modules/react-dom/cjs/react-dom-server.node.development.js:5936:5)
    at renderElement (/<MY_PROJECT_PATH>/node_modules/react-dom/cjs/react-dom-server.node.development.js:6082:11)
    at renderNodeDestructiveImpl (/<MY_PROJECT_PATH>/node_modules/react-dom/cjs/react-dom-server.node.development.js:6181:11)

If i dig into the lines :

Any ideas ?
(I already tried to set @emotion/styled as a peerDep in my components library, and dedupe it in the vite.config of my project).
An "ugly" solution :
I succeeded to fix this by using  <ClientOnly> in my project around my library components, but this look quite ugly.

Can you provide a minimum reproduction repository?


Correct usage of .where() filter

Hello,
I'm trying to use the .where() filter
I have a schema "product" with multiple "productSpecificationAttributes"
but when I try to filter the "product" by properties of the "productSpecificationAttributes" using .where() I get an error
this query
{
    products(filter: "productSpecificationAttributes.where(customValue == \"Test\")")
    {
        items {
                id,
                name,
                productSpecificationAttributes {
                    customValue
                }

            }
    }
}

returns the error
[message, Object of type 'System.Linq.Expressions.Expression1`1[System.Func`2[Repository.Entities.Products.Products.Product,System.Collections.Generic.IEnumerable`1[Repository.Entities.Products.Products.ProductSpecificationAttribute]]]' cannot be converted to type 'System.Linq.Expressions.Expression`1[System.Func`2[Repository.Entities.Products.Products.Product,System.Boolean]]'.]
Am I doing something wrong in the query?

Same doubt here

How is customValue defined?
Oh actually this is likely related to having paging on as well. Which means it is the same as #378

Same doubt here. For what is worth, check if any() works for your use case:
{
    products(filter: "productSpecificationAttributes.any(customValue == \"Test\")")
    {
        items {
                id,
                name,
                productSpecificationAttributes {
                    customValue
                }

            }
    }
}

It can work to give me the Products that have ProductSpecificationAttributes matching the condition, but not if I want only the list of ProductSpecificationAttributes filtered by the condition

How is customValue defined?
Oh actually this is likely related to having paging on as well. Which means it is the same as #378

The product class has a collection of ProductSpecificationAttributes
public virtual ICollection<ProductSpecificationAttribute> ProductSpecificationAttributes { get; set; }
and a ProductSpecificationAttribute has a string property called CustomValue
public string CustomValue { get; set; }
the Product schema is declared like this
schema.Query().AddField("products", "List of products")
.Resolve(ctx => ctx.Product)
.UseFilter()
.UseSort()
.UseOffsetPaging();

but I also tried without the UseSort() and UseOffsetPaging() and got the same result, so I don't think this is related with pagination... could you give an example of a correct usage of the .where() filter? I don't see any example in the documentation, maybe I'm declaring it wrong.

If I add this test in FilterExtensionTests
[Fact]
    public void SupportUseFilterAnyMethodOnCollection()
    {
        var schema = SchemaBuilder.FromObject<TestDataContext2>();
        var gql = new QueryRequest
        {
            Query =
                @"query Query($filter: String!) {
                    people(filter: $filter) { id name }
                }",
            Variables = new QueryVariables { { "filter", "taskCollection.any(name == \"Home\")" } }
        };
        var data = new TestDataContext2().FillWithTestData();
        data.People.Add(DataFiller.MakePerson(33, null, null));
        data.People.Add(DataFiller.MakePerson(33, null, null));
        data.People.First().Name = "Lisa";
        data.People.First().TaskCollection.Add(new Task { Name = "Home" });
        var tree = schema.ExecuteRequestWithContext(gql, data, null, null);
        Assert.Null(tree.Errors);
        dynamic people = ((IDictionary<string, object>)tree.Data)["people"];
        Assert.Equal(1, Enumerable.Count(people));
        var person = Enumerable.First(people);
        Assert.Equal("Lisa", person.name);
    }

And add taskCollection to the test Person type
public virtual ICollection<Task> TaskCollection { get; set; } = [];

This passes for me.
Are you able to make a test that fails?
How are you sending the query? Is it messy up the string?. What if you use variables in the request?
// full JSON requests
{
  "query": "query MyQuery($filter: String!) {
    products(filter: $filter)
    {
        items {
                id,
                name,
                productSpecificationAttributes {
                    customValue
                }

            }
    }
}",
  "variables": {
    "filter": "productSpecificationAttributes.where(customValue == \"Test\")"
  }
}

Closing unless we can get more information of reproducing the issue.


Travis: Remove manual installation of python pip package "mysql-python".

The apt package python-mysqldb is available now and we can use that
instead.

LGTM

For reference: Travis CI tracked whitelisting the package here: https://github.com/travis-ci/apt-package-whitelist/issues/39


Add support for a "since" parameter to the people-updates WebSocket

At the moment, the server starts sending updates on the /api/kansa/people/updates WebSocket as soon as it's operational, which e.g. kansa/admin applies to the data it received from GET /api/kansa/people. If an update happens in that interval, it's not reflected in the client state. Adding support for a ?since=[timestamp] query parameter to the WebSocket could help make sure any such updates can be sent to the client when the socket is initially opened.

This is a requirement for our integration with Grenadine to work well.


feat(useField) Add validation at field's level

Description
This PR enables in useField the usage of config's getValidator.
It contains a test checking the form's validate function is not called if field one does not pass it.
The useField TS type has been updated as well.

@erikras could you review this ? we would love to use this feature too :)

Published in v2.0.0.


Add what.cd user agent option

Add back the option to use a custom user agent for searching on what.cd.
Fix small oversight in response handling.

Don't we need a schema update as well?

Nope, it's already there. It just wasn't removed when the use of the actual value was removed.

Nope, it's already there. It just wasn't removed when the use of the actual value was removed.

Oh, gotcha. Thanks!


Update BUMP YAML keys

See https://github.com/JCSDA-internal/mpas-jedi/pull/811
Can do #173 at the same time.

See https://github.com/NCAR/MPAS-Workflow/tree/feature/clean_yamls


⚠ PrivateHD has degraded performance

In 4ce0a6f, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 3952 ms

Resolved: PrivateHD performance has improved in a65aef7.


Add favicon to docs?

Don't know if we want this, but it's possible to replace the default RTD icon. I'm not even sure if the cool kids are using bookmarks anymore, but I still do. This is how it looks like on my Firefox fav tab:

Tabs also display it on firefox or chromium, so it does have some visibility:

:

Ha great! This will certainly help people like me who are struggling with many open tabs including a bunch of RTD pages for different libraries :)


bump the dart sdk version to 2.0.0-dev.17.0

bump the dart sdk version to 2.0.0-dev.17.0 to is it addresses the "Minimum version ("2.0.0-dev.20.0") must be less than maximum ("2.0.0-dev.16.0")" issue

And now try 2.0.0-dev.20.0.

And, down to 2.0.0-dev.19.0 to avoid Package flutter_tools requires SDK version >=1.19.0 <=2.0.0-dev.19.0 but the current SDK is 2.0.0-dev.20.0..

LGTM

@devoncarew @xster If the issue was a local problem, shouldn't this be updated back to 2.0.0-dev.20.0? The newer version contains a significant amount of fixes (143 commits).

We needed a version newer than dev.16; dev.20 is ahead of what our internal system is using (which we don't like to be ahead of).


Duplicate warnings and using suggestions - mac only

Environment data
vs code 1.20 mac os high sierra
dotnet --info output:
VS Code version:
C# Extension version:
Steps to reproduce
open any c# project, throw in some classes, generate some warnings.  it's not a pattern as to which ones will double, but it has been this way since day one one the mac.  I use it on a pc and mac, but i prefer the mac :).  I just thought it was some quirk that would eventually go away but it never has.
Expected  behavior
work the same as a pc
Actual behavior
see the link below where i pasted some screenshots.  I love the extension, just need to clean up some stuff if possible.
https://github.com/Microsoft/vscode/issues/43663

@CoderJason123 We believe this was fixed in the recent 1.14 release of the C# extension for VS Code. Can you confirm what version of the extension you have?

Hi.  I am on 1.14.0 :(

@CoderJason123 Can you try deleting ~/.omnisharp ?

To reinstall omnisharp you will also need to delete the install.Lock file in the extension folder.

I did all of these suggestions.  And for about 2 seconds, it appeared to work, but then the duplicates reappeared.  I will note this..there is one set of warnings showing a path, and another showing a path with a trailing slash. Like "startup.cs" and "startup.cs/"  Screen shot attached.
And another thing, i am only seeing this now for duplicate "usings", not all messages.  Now that i've updated, I can not tell you what the behavior was before.

@CoderJason123 Are you using the build command to build your project? It looks like you're seeing https://github.com/OmniSharp/omnisharp-vscode/issues/1197 .
If you close and reopen VS Code to your folder, do you see any duplicate errors with the "/" character before you do a build?

no, no duplicates before I build.  interesting.

@CoderJason123 Thanks for following up, I'm going to close this as a duplicate of #1197

@CoderJason123 I was able to reproduce this on a Windows machine (build -> duplicate warnings). I don't believe it's Mac specific.

Ok, good to know!  I had not seen it there or just forgot.  Thank you!


Compilation fails because of unused variable

Hi, the following happens on both M1 and Intel Macs:
❯ asdf install thrift 0.13.0
Downloading source.....
Configuring build....
Compiling with flags -j16....
/Users/foo/.asdf/installs/thrift/0.13.0/src/compiler/cpp/src/thrift/thrifty.yy:1.1-5: warning: POSIX Yacc does not support %code [-Wyacc]
    1 | %code requires {
      | ^~~~~
src/thrift/generate/t_java_generator.cc:5369:9: error: variable 'j' set but not used [-Werror,-Wunused-but-set-variable]
    int j = 0;
        ^
1 error generated.
make[2]: *** [src/thrift/generate/thrift-t_java_generator.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [install-recursive] Error 1
make: *** [install-recursive] Error 1
asdf-thrift: An error ocurred while installing thrift 0.13.0. See /var/folders/lf/dtnk7rp90rgc24_9pr6n8rkh0000gn/T//thrift-install-0.13.0.txt

Getting the same error for at least Thrift versions 0.13.0, 0.15.0, and 0.18.1 -- except that the line number for the unused variable is different.
Something like -Wno-unused-variable could bypass this, but I couldn't find how to pass options to asdf build.
System:
MacOS Ventura 13.4.
❯ gcc --version
Apple clang version 14.0.3 (clang-14<IP_ADDRESS>.1)
Target: x86_64-apple-darwin22.5.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Same here!
Also, on an M1, it seems default pkg-config was not good enough. Had to install a new one with brew install pkg-config (might be worth documenting)

I looked a bit more into this.
It seems the warning can be disabled by adding the -Wno-unused-but-set-variable CXXFLAG at  at https://github.com/alisaifee/asdf-thrift/blob/master/lib/utils.bash#L49:
export CXXFLAGS="-Wno-inconsistent-missing-override -Wno-unused-but-set-variable"

However after doing that I'm facing yet a new error:
src/thrift/generate/t_cl_generator.cc:29:10: fatal error: 'boost/tokenizer.hpp' file not found
#include <boost/tokenizer.hpp>

I already installed boost with brew, but that does not seem to be enough.

Here, have a patch:
diff --git a/lib/utils.bash b/lib/utils.bash
index a2aff74..d649bbe 100644
--- a/lib/utils.bash
+++ b/lib/utils.bash
@@ -47,7 +47,7 @@ install_version() {
 		local bison_brew_path
 		bison_brew_path="$(brew --prefix bison)/bin"
 		export PATH="$bison_brew_path:$PATH"
-		export CXXFLAGS="-Wno-inconsistent-missing-override"
+		export CXXFLAGS="${CXXFLAGS:--Wno-inconsistent-missing-override}"
 		local bison_version
 		if ! type "automake" >/dev/null 2>&1; then
 			fail "Thrift requires automake"

Tested like this:

keeps existing behavior

$ asdf install thrift 0.18.0

Downloading source.....
Configuring build....
Compiling with flags -j10....
${HOME}/.asdf/installs/thrift/0.18.0/src/compiler/cpp/src/thrift/thrifty.yy:1.1-5: warning: POSIX Yacc does not support %code [-Wyacc]
    1 | %code requires {
      | ^~~~~
src/thrift/generate/t_java_generator.cc:5754:9: error: variable 'j' set but not used [-Werror,-Wunused-but-set-variable]
    int j = 0;
        ^
1 error generated.
make[2]: *** [src/thrift/generate/thrift-t_java_generator.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [install-recursive] Error 1
make: *** [install-recursive] Error 1
asdf-thrift: An error ocurred while installing thrift 0.18.0.

works on M1

$ env CXXFLAGS="-Wno-inconsistent-missing-override -Wno-unused-but-set-variable -I$(brew --prefix)/include" asdf install thrift 0.18.0

Downloading source.....
Configuring build....
Compiling with flags -j10....
${HOME}/.asdf/installs/thrift/0.18.0/src/compiler/cpp/src/thrift/thrifty.yy:1.1-5: warning: POSIX Yacc does not support %code [-Wyacc]
    1 | %code requires {
      | ^~~~~
ld: warning: -bind_at_load is deprecated on macOS

@alisaifee: can we get a release with this? 👆

Resolved in fecdd6c3b081ef499527ed0aa03fbab2374820dd

You may want to add some documentation in the readme about passing in the CXXFLAGS env var to build on M1


reconciliation: include debit entries in ReconciliationFile event

Changes

ReconciliationFile event updated to also include debit entries

Why Are Changes Being Made

The ReconciliationFile event should include debit entries

Codecov Report

Merging #57 (05b6c5b) into master (d7f17cd) will increase coverage by 0.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   39.90%   40.34%   +0.44%
==========================================
  Files          79       79
  Lines        3057     3036      -21
==========================================
+ Hits         1220     1225       +5
+ Misses       1582     1559      -23
+ Partials      255      252       -3

Impacted Files
Coverage Δ

internal/incoming/odfi/reconciliation.go
0.00% <ø> (ø)

internal/upload/sftp.go
65.04% <0.00%> (+2.42%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f17cd...05b6c5b. Read the comment docs.


Addition of All Contributors Photos in Readme | Readme Updation

We can add all the contributor's photos in Readme file as a token of appreciation for their work.
Please assign this to me.

Like this

Cool, You can get started @Shariq2003

thanks


Add comparisons to YouTube Redux

This updates the README to compare both CustomTube and YT Redux replicating the Hitchhiker 2016 layout, in the watch and home page.

Ehhhhhhhhhhhhh... I don't know about this.
Straight up saying "my extension is better than this other one" that blatantly is kinda disrespectful, no matter how true it is. I mean, it's not like YouTube Redux has done something bad like implement tracking or anything. If it did, then I would've already smashed it for all its flaws.
I think saying that my extension lets you use any layout from 2008-2021 already kinda implies that it's better than Redux, but in a much more respectful manner.
Also, I would not accept a screenshot including "PlayerTube". Actually, I don't really want to include any screenshots that aren't my own.


[BUG] Unable to show nfs disk mounts with fastfetch

This maybe a feature request or a bug so please change the label if I have placed it incorrectly.
I'm moving off neofetch to fastfetch and I'm having one problem which I'm hoping you can help me with.  I'd like to display nfs disk/mount information via fastfetch.  Is this possible with fastfetch?  I'm able to do it with neofetch so I'm hoping its possible with fastfetch as well.
Description:
As an example, I have a mount <IP_ADDRESS>:/nfs/4a-Music mounted to /data/MediaServer/4a-Music and when I configure the disk module like this ...
{
"type": "disk",
"keyColor": "cyan",
"folders": "/data/MediaServer/4a-Music",
"key": "Disk (4a-Music)"
},
... it does not display.  There is no error, it just does not display.  I've tried adding the showExternal property but that doesn't help. Is this somehow possible ?
My OS is fedora 40 which is running fastfetch 2.9.1 (x86_64) installed via dnf.

2.9.1 is kind of old. Please try installing the latest version: https://github.com/fastfetch-cli/fastfetch/releases/download/2.12.0/fastfetch-linux-amd64.rpm
If it still doesn't work, please paste the content of fastfetch -c none -s disk --format json

Thank you for the quick reply.  I installed fastfetch 2.12.0 linked above and its now detecting the nfs mounts as I was expecting.  I guess the fedora repro is just a bit behind.


[Question] How to customize WYSIWYG in Block Editor

Hi,
while testing the new version of twill I tried to update the existing toolbar.
My configuration for the block editor is the following (config/twill.php):
<?php

return [

   'block_editor' => [
       'blocks' => [
           'text' => [
               'title' => 'Body text 1',
               'icon' => 'text',
               'component' => 'a17-block-wysiwyg',
           ],
           'image' => [
               'title' => 'Image',
               'icon' => 'image',
               'component' => 'a17-block-image',
           ]
       ]
   ]
];

I created a simple module, the form.blade.php is the following:
@extends('twill::layouts.form')

@section('contentFields')
    @formField('input', [
        'name' => 'description',
        'label' => 'Description',
        'maxlength' => 100
    ])

    @formField('wysiwyg', [
        'name' => 'description',
        'label' => 'Description',
        'toolbarOptions' => [ [ 'header' => [1, 2, false] ], 'list-ordered', 'list-unordered', [ 'indent' => '-1'], [ 'indent' => '+1' ] ],
        'maxlength' => 200,
        'editSource' => true,
    ])

    @formField('block_editor')
@stop

As you can see, i have modified the @formField('wysiwyg') and the changes are shown correctly.
But if the wysiwyg field is part of the block editor, I can't see a option to do this.
Changing the config/twill.php to this doesn't worked (in my tests):
<?php

return [

   'block_editor' => [
       'blocks' => [
           'text' => [
               'title' => 'Body text 1',
               'icon' => 'text',
               'component' => 'a17-block-wysiwyg',
               'toolbarOptions' => [ [ 'header' => [1, 2, false] ], 'list-ordered', 'list-unordered', [ 'indent' => '-1'], [ 'indent' => '+1' ] ],

           ],
           'image' => [
               'title' => 'Image',
               'icon' => 'image',
               'component' => 'a17-block-image',
           ]
       ]
   ]
];

Did I missed something?
Thanks!
Tested with:

Homestead (with mySQL)
Laravel 5.7.15
Twill 1.2.0

Hi @ifox,
thanks for your feedback.
Are there some reserved words for the blocks?
I mean, can I create a block with the name wysiwyg ? If I understood it correctly, the component name will be a17-block-wysiwyg and then, for my understanding, the existing block will be overwritten.
Or is there some "magic" which knows what is a core component and what is a custom component?

You can create a block with the name wysiwyg, for sure, it will be preferred over the existing one.

Not sure I'm following you. Why would you need to use the existing a17-block-wysiwyg if you create your own block that include a WYSIWYG field with more styling options? Maybe to have 2 different blocks with a WYSIWYG but with different styling options? You could create your own 2 blocks to do that too, or like you said, keeping the existing one and adding another one with a different name. In the end, that component name is just technical glue, in the UI you can give each block a title that makes sense to your CMS users.

Hi,
Maybe my wording was not the best, here a new try :)
Twill comes with some ready-to-use Block components (for me, they are core components).
One of them is a17-block-wysiwyg.
When I create a new component (for me they are custom components) they can have the same name.
Example: creating a new component with the name wysiwyg will be also accessible via a17-block-wysiwyg.
For me, it sounds like that I can overwrite existing core components with this. (Tbh, I have no clue, if the used code from this component is used somewhere else or not)
But I think I have overcomplicated this case - just creating my custom block with a custom name and adding the form inside the form should solve everything.
My main question is answered already and the solution makes sense and keeps the config and everything clean and small :)
Thanks again for your fast feedback!

Hey @ifox
First of all thank you for the awesome work, have been working with Twill now for quite some time and love it!
Right now I'm struggling a bit with the custom block editor. I did everything exactly like you described in your first answer and with your example it works out fine. But as soon as I want to modify the parameters, I can't get it to work anymore 🤔
For Example, if I set the toolbarOptions parameter like this:
@formField('wysiwyg', [
    'name' => 'content',
    'label' => 'Text',
    'toolbarOptions' => [ [ 'header' => [1, 2, false] ], [ 'font' => [] ], 'link', [ 'align' => [] ] ],
    'maxlength' => 200,
    'editSource' => true,
])

No alignment Icon will be shown, the dropdown is also empty.

The same also happens with other attributes like color or background.
What am I doing wrong? Thank you in advance 🙂

Hi @helloiamlukas ! Have found what was the issue? I am currently struggling as well to have the toolbar buttons to display. Quill.js docs explain it pretty straightforward ... but some buttons like "align", "color", "background" do not show on TWILL.
'toolbarOptions' => [
                "bold", "italic", "underline", "strike","blockquote", "code-block",
                ["header" => [2, 3, 4, 5, 6, false]],
                ["list" => "ordered"],  ["list" => "bullet"],
                ["indent" => "-1"], ["indent" => "+1"],
                ["size" => ["small", false, "large", "huge"]],
                "link", "image", "video",
                ["color" => []],
                ["background" => []],
                ["align" => []],
            ],

@adelinferaru No, I still haven't found out why this isn't working unfortunately...

Hello @helloiamlukas, @adelinferaru.
There are some conflit between Quill default style and our custom styles. Default buttons should be definitely present. I'm currently working on that. I will open a PR soon.

@ifox

Hi @noxify,
the a17-block-wysiwyg component is provided by default in the block editor, but it is not intended to be customized directly. I do like the way you tried to though, and might think about implementing that support.

Would it be possible to include a plugin option used by Quill.js ? Specifically I'm trying to incorporate
https://github.com/kensnyder/quill-image-resize-module
Maybe something like...
@formField('wysiwyg', [
    'name' => 'case_study',
    'label' => 'Case study text',
    'toolbarOptions' => [ [ 'header' => [1, 2, false] ], 'list-ordered', 'list-unordered', [ 'indent' => '-1'], [ 'indent' => '+1' ] ],
    'modules' => ['imageResize' =>[]]
  ])

Do we have another issue or discussion regarding the customization of the WYSIWYG component? I'm having a similar issue where I have to customize or add more modules to Quill.


Unsure on How to Visualize Matplotlib to show Pointcloud

Hello, I believe I am running the sick_scan_api and am successfully communicating with the multiScan100, but am unsure on how to show the matplotlib since I am using the generic driver.
Here is what my terminal looks like:
PythonAPI.txt

Here is how my sick_scan_xd_api_test.py looks like:
sick_scan_xd_api_test.txt

Thanks for your feedback. According to your logfile (PythonAPI.txt), sick_scan_xd has successfully established the TCP-communication, but does not receive any scan data from the multiScan via UDP. Please check that the configuration parameter udp_receiver_ip:=<IP_ADDRESS> is correct. udp_receiver_ip is the ip address of the PC receiving the UDP scan data, i.e. the  ip address of the PC running sick_scan_xd. If this is not <IP_ADDRESS>, the UDP scan data are sent to a different machine. If in doubt, use SOPAS Air by opening //<IP_ADDRESS> in a browser.


Calendar Organisms

Resolves #7

"implement" the Calendar, Scheduler components (using https://github.com/Cubified/react-simple-scheduler)
implement the CalendarLabels component

react-simple-scheduler also uses<EMAIL_ADDRESS>but the project is<EMAIL_ADDRESS>This is causing a peer dependency conflict (as seen in CI), so we might need an upstream update anyways?


Suggestion - Get the query operation type while maintaining the autocompletion

This issue is about advanced typing - https://genql.now.sh/docs/usage/advanced-typings
Given the following code:
// based on the issue https://github.com/remorses/genql/issues/49
function tuple<T1, T2>(data: [T1, T2]): typeof data
function tuple(data: Array<any>) {
    return data
}

const q = {
    advertisers: tuple([
        { skip: 1},
        { isActive: true }
    ])
};

const { query, variables} = generateQueryOp(q);
const { data, error} = useQuery<QueryResult<typeof q>>(gql(query), { variables: variables });

Everything will work as expected. I can't mistype and the type of the data will be correct. Although, there's one disadvantage with this approach.
Since q isn't explicitly typed, we lose the ability to autocomplete (although if we mistype something, the compiler will complain).
Is there a way we could dance at two weddings by both having the data typed and having the autocompletion?

Unfortunately this is a typescript limitation, you can’t have bot because this way you would lose the selected fields information
the best thing you can do is create a wrapper around useQuery so that you don’t have to create a separate variable for query

Made an example here
https://github.com/remorses/genql/blob/c0bc0250f79dea5e8064f84f44bbc689648ade07/example-usage/pages/apollo-wrapper.tsx

Amazing. works like a charm!


I'm trying to launch labs.play-with-k8s locally

Hello Folks,
I'm trying to lauch a labs.play-with-k8s.com locally.
In some old issues, I've seen a configuration to set DIND_IMAGE=franela/k8s . The tip does not say where  or if it will work with docker-compose. Is it possible to setup labs.play-with-docker locally nowdays?
Thanks

yes it is possible. Are you trying to run the docker or k8s variant?

K8S variant

I figured out how to run play with k8s locally:

Change franela/docker to franela/k8s in api.go.
Change AssetsDir in handlers/bootstrap.go to k8s instead of default.

Then make the changes for the domain name in config/config.go
docker compose up -d and it should work, but I don't know if it's the proper way to run PWK. @marcosnils could you please confirm, so I can add it to the README.md

I dit it, but there is underline OS issues.

Using ubutuntu 18.04 -> 20.04 i'm receiving an error to unapck containers if crictl is used to pull images. Docker pull is working, i don't know what is happening. The issue seems to be related to filesystem options, but no clue how to solve it
need to uninstall apparmor in Linux to make the creation works.
Using ubuntu 24.04 succeffully created an instance of franela/k8s, But kubeadminit does not complete, pods isn't starting , something related to cgroupsv2 i think

"The issue seems to be related to filesystem options, but no clue how to solve it" --> I've seen that on Ubuntu 22.04 the storage driver used by franela/k8s was different between my setup and the labs play with k8s setup. Mine was using an old one.
So, finally did you manage to run it successfully on Ubuntu 22.04 after uninstalling apparmor?

Not yet, did you get it?
Docker Version
Distro
Filesystems,
Etc

Still not working with 22.0.4.  same problemas from 18.0.4, 20.04 and 22.0.4
the same extract error
E1014 23:26:39.162897     428 remote_image.go:171] "PullImage from image service failed" err="rpc error: code = Unknown desc = failed to pull and unpack image "registry.k8s.io/kube-scheduler:v1.27.16": failed to extract layer sha256:06d84c7e474c1b4311890a004c0880577d0fb8d3b89639b7541765289ca36355: failed to convert whiteout file "usr/local/.wh..wh..opq": operation not supported: unknown" image="registry.k8s.io/kube-scheduler:v1.27.16"
FATA[0006] pulling image: rpc error: code = Unknown desc = failed to pull and unpack image "registry.k8s.io/kube-scheduler:v1.27.16": failed to extract layer sha256:06d84c7e474c1b4311890a004c0880577d0fb8d3b89639b7541765289ca36355: failed to convert whiteout file "usr/local/.wh..wh..opq": operation not supported: unknown

I no longer have access to the machine because it's been cancelled, but it was an Ubuntu 22.04 with the latest version of docker as of October 03 (i.e. 27.3.1). The file system used by docker was overlay2 on my host. Play with docker worked fine, but not play with kubernetes.

I've managed to make PWD works in all Ubuntu versions, but PWK didn't works in any


node-agent: implement SDS for mesh expansion

Describe the feature request
Implement SDS in node-agent for Mesh Expansion.  Currently (1.4) CA cert chain and workload certs are stored in /etc/certs directory on the VM.  This is fine during bootstrap but not very secure in the long term, especially before Istio has a good cert revocation story.  Citadel agent has built-in SDS support.  node-agent should also implement SDS support so that /etc/certs directory can be deleted after VM becomes part of Istio service mesh.
Describe alternatives you've considered
There is not a good way to secure directories on a VM if a user has sudo permission.
Additional context

In istio 1.5 SDS is on by default, this means that mesh expansion is broken?

I am pretty sure this is done, @irisdingbj is there any work left?

I know @costinm has sent out some PR for SDS, but i'm losing the track w.r.t doc/release etc
Closing as above comment suggests. Anyone can reopen if see any gap in 1.5 in any aspects.


Python 3.5 (windows)

Anaconda now has a python 3.5 version in public (non-rc) is basemap going to be update soon to work on windows with 3.5?

Ok thanks @WeatherGod

Ok thanks @WeatherGod

my hope is that the next release (~a month or 2 from now) will utilize appveyor, and as such, we will be able to release binaries for windows.

@WeatherGod did this ever happen? I can only find the binaries on SF for 3.3. Also, the wheels from Christoph Gohlke are at v1.0.8 though git only has an v1.0.7 tag so I'm a bit wary to use them ... is that version from master? Is it safe to use?

No, I still haven't done a release (haven't figured everything out yet).
Christoph's v1.0.8 is basically what was on master when he made them
because v1.0.7 was so old. They should be good to use.
On Wed, May 18, 2016 at 1:54 PM, Florian Bender<EMAIL_ADDRESS>wrote:

my hope is that the next release (~a month or 2 from now) will utilize
appveyor, and as such, we will be able to release binaries for windows.
@WeatherGod https://github.com/WeatherGod did this ever happen? I can
only find the binaries on SF for 3.3. Also, the wheels from Christoph
Gohlke are at v1.0.8 though git only has an v1.0.7 tag so I'm a bit wary to
use them ... is that version from master? Is it safe to use?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/matplotlib/basemap/issues/249#issuecomment-220107015


dharmanin/catalog

I am getting this error message for all pages of your provisional site, @michaelnmmeyer :

Fixed in https://github.com/michaelnmmeyer/dharma/commit/e9e8a8431dee1f1b71770e0c24427a3387077d7d


add CPU & GPU data columns to Prometheus

CPU & GPU models are calculated once and set as global variables.

@remolina please remember to squash these commits into a single feature commit whenever the code is ready

@remolina when you've finished testing please post the updated output / screenshot here

@remolina container build is failing.. can you take a look?

Just saw this. I had forgotten to move a package import over from functions.go when I moved the code over to prometheus.go. It's good to go now

Did you redeploy it somewhere? So we can check

@cmisale I redeployed it on pokmvp000 today and its running as expected


Fix error api

Summary by CodeRabbit

Refactor

Improved import order in accounting exports for better code readability.

New Features

Added support for accounting export data in error reporting.

Bug Fixes

Enhanced custom queryset logic in ErrorsView for improved filtering based on query parameters.

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ed61812) 94.64% compared to head (f4eab47) 94.56%.

Files
Patch %
Lines

apps/accounting_exports/views.py
73.33%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   94.64%   94.56%   -0.08%
==========================================
  Files          84       84
  Lines        4460     4472      +12
==========================================
+ Hits         4221     4229       +8
- Misses        239      243       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Not able to install in ubuntu 23.10

Which Cloudflare product(s) does this pertain to?
<IP_ADDRESS>, WARP Client
Subject Matter
Installation in Ubuntu 23.10
Content Location
Under linux installation
Additional information
No response

👋 @karthikvijay5227 Thanks for reaching out. We only take care of developers.cloudflare.com documentation in this repo.
Would you mind clarifying which of the following guides you were trying to use and providing more details on what difficulties you've been having? Are you getting any error messages, for example?
https://developers.cloudflare.com/<IP_ADDRESS>/setup/linux/
https://developers.cloudflare.com/warp-client/get-started/linux/


Get user analytics for popup vs. full-page mode

We'd like to better understand the usage of the Wallet and how users operate within popup vs full-page mode.
We should take into account not just number of sessions, but the length of sessions. This is to cover the scenario where a user uses fullscreen for longer periods of time but probably launches the popup window more frequently.

In Mixpanel, we can filter events by numeric properties using less- and greater-than operators. As such, I'd recommend here that we simply start reporting two new viewport measurement properties whenever we call View page as an event in Segment:

width: Total width of viewport
height: Total height of viewport

Then we can measure, for example, all the unique users who viewed the extension in a given month in a window greater than the standard popup width (~400px).
This will also give us greater flexibility in the future to learn other things (e.g. average window size and how many users are loading the wallet in super-wide windows).

We can track width/height for all actions adding it to the default props.


Change the name and signature of mapToLowerScalarOp

This patch is to change the name of mapToLowerScalarOp function to emitScalarOpFor in order to avoid confusion in using the function.

@tungld seems like you'll need to sync this patch with https://github.com/onnx/onnx-mlir/pull/75/files ?

Right, let me do it now.

@tjingrant Done.


Adding diagram service generation endpoint to the website

Reopening from #50

@tsurdilo, you can test these changes (here)[https://deploy-preview-51--serverlessworkflow.netlify.app/]

@tsurdilo, you can test these changes (here)[https://deploy-preview-51--serverlessworkflow.netlify.app/]


chore(customPropTypes): use direct imports for customPropTypes

This PR removes reexport customPropTypes from lib/index.ts as it useless.

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


RecvBuf +  SendBuf Memory Usage

I saw that quiche_config_set_initial_max_data controls the amount of unacknowledged data allowed to buffer into RecvBuf's and SendBuf's data: BinaryHeap<RangeBuf>.
I'm concerned about overall memory usage of the server over time.
It seems to me that in the worst case, the limits set in quiche_config_set_initial_max_data quiche_config_set_initial_max_stream_data_bidi_local etc, could cause both buffers to grow to their capacities and that memory is never reclaimed?
Even at a modest 512KB value for the send and receive buffers, with 100,000 connections, we're talking 100GB.
I haven't had a chance to learn Rust yet, so maybe I'm missing something.
In C my approach would be to mmap(..., MAP_PRIVATE | MAP_ANONYMOUS | MAP_NORESERVE,...) in the memory and then MADVISE_COLD the pages after consuming them. Otherwise we're in a position where a MASSIVE amount of unused memory is trapped. (And in my case this is untenable because I don't have that much memory per connection available on my machines).
I wish Rust had per container instance allocator specialization like C++ so we could back the BinaryHeaps with mmap-ed memory... maintaining operational convenience but maximally exploit memory efficiency.
Maybe a simple solution is to just add some shrink_to_fit or shrink_to calls?
And on this subject, are there any other parts of the implementation that would suffer from similar memory usage problems at such a high connection count?

since Rust has native mmap and madvise support, i suggest we replace the BinaryHeap object with a raw memory buffer that we track the head and tail of, shift when needed and madvise cold once consumed.
just requires rounding up the supplied max data config values to the nearest page boundary.
whether this above direction or not, i can work on this PR once a direction is agreed upon.

It seems to me that in the worst case, the limits set in quiche_config_set_initial_max_data quiche_config_set_initial_max_stream_data_bidi_local etc, could cause both buffers to grow to their capacities and that memory is never reclaimed?

Based on what are you saying that? The data is stored as a list of buffers. Those buffers actually own the chunks of application data sent/received (i.e. what initial_max_data and initial_max_stream_data limit) and those are moved/freed after they are read by the application (in case of incoming data), or when they are acked (in case or outgoing data), so what you are saying is not really true (unless of course there is a bug in the code).
The lists themselves are not reduced in size, but the overall memory consumed by them should be pretty low, even in cases where they have been grown a lot.


🐛:  SVGs are displayed as Zipped SVGs

Contact Details
No response
Location
runBiosimulations
What happened?
SVG files are displayed as Zipped SVG files even if they have the regular ".svg" extension
https://run.biosimulations.dev/simulations/61cf6049e3202b690abca986#tab=files
What made it happen?
Run a simulation that contains an svg file. For example  https://run.biosimulations.dev/simulations/61cf6049e3202b690abca986#tab=files
Version
Development (Deployed on a .dev domain)
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Probably due to recent changes in #3931 and how the onology api is using that information to lookup file descriptions/names

Yes, its due to the PR cited above. Our apps use the format URI, not the extension. Unfortunately, SVGZ doesn't have its own canonical media type. As a result, I used the same URI for both SVG and SVGZ.
One option is to use a different media type for SVGZ such as image/svg+xml-compressed as suggested in w3c/svgwg#701. This would entail a few small changes:

[ ] Modify https://github.com/biosimulations/biosimulations/blob/dev/libs/ontology/extra-sources/src/lib/edam-biosimulations-formats.json#L1121
[ ] Modify BioSimulators-utils
[ ] Rebuild and re-submit COMBINE archives for Physiome

@bilalshaikh42 thoughts?
A long-term solution it to register unique terms for SVG and SVGZ with EDAM and use EDAM URIs. This would be a more elegant solution, but the timeline is indefinite because EDAM has been very slow to approve and release changes.

I can take care of the first two tasks as part of supporting the other file formats discovered in Physiome.

I agree with the long-term solution.
In the short term, I think it would make more sense to default the other way. Meaning, it is acceptable to label SVGZ files as regular SVG files, since users familliar with SVGZ files would understand the intent.  For most users however, showing the common SVGs as an unexpected format may cause confusion.

Having read through the issue, I think agree that the simplest solution would be to just label the SVGZ files as
image/svg+xml-compressed.
The worst-case consequences of using the nonstandard mimetype will be some programs that rely exclusively on mime-type not recognizing it, but this seems to happen anyway since they try to interpret the file as SVG without running any sort of decompression leading to errors. The alternative of not recognizing the mimetype actually seems better to me.

I changed the media type/URI for SVGZ in #3937. Using a non-standard media type/URI allows us to print a more informative description than something like "Unknown binary format". The downside seems minimal to me because using a non-standard media type doesn't seem worse than using none at all.

I changed the media type/URI for SVGZ in #3937. Using a non-standard media type/URI allows us to print a more informative description than something like "Unknown binary format". The downside seems minimal to me because using a non-standard media type doesn't seem worse than using none at all.

:tada: This issue has been resolved in version 8.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Refactored getDragInput, fixing frame-delay bug, and cleaned its uses.

Callback function takes an instance and the current mouse position now.
Uses RenderStepped instead of Heartbeat to fix the frame delay.
Slider now makes use of the dragger. ColorPicker has been adjusted accordingly.
The API has changed accordingly:

clean instead of cleanup.
forceEnded is available now to stop a drag forcefully without an instance, does not trigger the callback.

Thanks for the work here. I decided to go with a hooks approach for sharing drag-input code, but this was helpful in reaching a good API and adapting existing components to use it. Closing in light of https://github.com/sircfenner/StudioComponents/pull/36.


Fix duplicate AddOrgToConsortium

master is broken, also cleans up the test for AddOrgToConsortium

Merging with CI to fix master.


Recently added compact view

Modified things as requested...

I moved the "compact mode" settings into each module, as you should be able to set it on a per-module basis. Also, I don't think it really belonged in server settings.


feat: forward isBlocking to Alert and Marketing modals

Move requiredWhen from DataTable/utils/propTypesUtils into a top-level utils dir, and generalize into customPropTypeRequirement
requiredWhen and new requiredWhenNot methods wrap customPropTypeRequirement.
ModalDialog now forwards the isBlocking prop to the ModalLayer, and thus its inheritors now have that prop notated.
for MarketingModal and AlertModal, the onClose method is marked as required only if isBlocking is false-y.

:tada: This PR is included in version 16.17.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update snapshot docs for 1.0 stable

#163  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rbro112 and the rest of your teammates on  Graphite


Source of data?

What is the source for the data you're using to calculate the r0 (infection rate)? I didn't see it listed in the README.md. Apologies if I missed it.

Sorry, just found the COVID Tracking Project reference in the main repo


Allow PHP8

Related to https://github.com/Sylius/Sylius/issues/12298 and #86

Thank you, Pablo! :1st_place_medal:


Add optional timings to title, subtitles and action bars

Tasks

[ ] Titles
[ ] Subtitles
[ ] Action bars

Will be included with the next version :3


Place vite file outside folder

Describe the bug

I have the structure

api

vite.cms.config.mts

cms (vite + vue 3)

I use the laravel-vite-plugin and place vite.cms.config.mts inside the api folder (Laravel).
Problem:

When I create a new file, AutoImport and Components do not automatically update the file.d.ts.
This issue only occurs when the configuration file is placed outside the cms folder.

vite.cms.config.mts
export default defineConfig({
  plugins: [
    laravel({
      input: [resolve(__dirname, '../cms/src/main.ts')],
      buildDirectory: 'build/cms',
    }),
    tsconfigPaths({ loose: true }),
    AutoImport({
      resolvers: [
        ElementPlusResolver(),
      ],
      imports: [
        'vue',
      ],
      dirs: [
        resolve(__dirname, '../cms/src/uses/**'),
        resolve(__dirname, '../cms/src/api'),
      ],
      dts: resolve(__dirname, '../cms/auto-imports.d.ts'),
      vueTemplate: true,
      viteOptimizeDeps: true,
    }),
    Components({
      extensions: ['vue', 'tsx'],
      resolvers: [
        ElementPlusResolver({
          importStyle: 'sass',
        }),
      ],
      dirs: [resolve(__dirname, '../cms/src/components')],
      globs: [
        resolve(__dirname, '../cms/src/components/**/*.vue'),
      ],
      include: [/\.vue$/, /\.vue\?vue/, /\.tsx?$/],
      dts: resolve(__dirname, '../cms/components.d.ts')
    }),
  ],
});

Reproduction
Place vite.config.ts outside root folder
System Info
None

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Help


#11 : Extend and improve the README

It would be good if a gif could be added to demonstrate the app. Once in the flutter_beautifuls_ui's and in the habit_tracker itself. What do you think?

Yes, a gif for demonstration sounds good.


IManagedMqttClientStorage Expectation

Can someone tell me what the expectations are for the load/retrieve methods?  For example, during the load, do we purge the underlying store, or is there a guarantee when the messages are sent to the server, etc.?

Hi,
messages are only deleted from the managed client when they are successfully sent. So QoS 0 only means sent but not received from server. QoS 1 means sent and received.
So when the method of the interface is called you can assume that the messag was sent.
Best regards
Christian

Apologies for the delay in responding.  I almost understand your response, but the interface has Load() and Save(), but there are no instructions on the expectations the load method and/or Save method should be doing.  Did i miss something within code?

To be honest, I do not understand the question...

I'm closing this now. Please feel free to re-open it or add another issue if you have further questions.


⚠ Bofrost.es has degraded performance

In 0569a16, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1429 ms

Resolved: Bofrost.es performance has improved in 5b2aad8 after 6 minutes.


[BUG]: TypeError: movedTables is not iterable

What version of drizzle-orm are you using?
"^0.32.0"
What version of drizzle-kit are you using?
"^0.23.0"
Describe the Bug
I ran introspect command and following were the error
bunx drizzle-kit introspect
drizzle-kit: v0.23.0
drizzle-orm: v0.32.0
No config path provided, using default path
Reading config file '/Users/some_dirs/drizzle.config.ts'
Pulling from ['product'] list of schemas
Using 'pg' driver for database querying
[✓] 192  tables fetched
[✓] 1074 columns fetched
[✓] 0    enums fetched
[✓] 0    indexes fetched
[✓] 285  foreign keys fetched
TypeError: movedTables is not iterable
at applyPgSnapshotsDiff (/Users/some_dirs/node_modules/drizzle-kit/bin.cjs:29346:22)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async introspectPostgres (/Users/some_dirs/node_modules/drizzle-kit/bin.cjs:126156:42)
at async _Command. (/Users/some_dirs/node_modules/drizzle-kit/bin.cjs:131714:7)
And the following warnings/errors were shown in the vscode
Cannot find name 'nextval'.
Cannot find name 'regclass'.
export const resource = our_schema.table("resource", {
resource_id: uuid("resource_id"),
clicked_at: date("clicked_at").defaultNow(),
clicker_ip: varchar("clicker_ip"),
clicked_by: varchar("clicked_by"),
id: integer("id").default(nextval('ourschema.social_clicks_id_seq'::regclass)).notNull(),
});
Expected behavior
No response
Environment & setup
No response

I'm having the same issue
❯ npx drizzle-kit introspect
drizzle-kit: v0.23.0
drizzle-orm: v0.32.0

No config path provided, using default path
Reading config file '/Users/redacted/Documents/workspace/redacted/drizzle.config.ts'
Pulling from ['public'] list of schemas

Using 'pg' driver for database querying
[✓] 8  tables fetched
[✓] 46 columns fetched
[✓] 0  enums fetched
[✓] 0  indexes fetched
[✓] 11 foreign keys fetched

TypeError: movedTables is not iterable
    at applyPgSnapshotsDiff (/Users/redacted/Documents/workspace/redacted/node_modules/drizzle-kit/bin.cjs:29346:22)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async introspectPostgres (/Users/redacted/Documents/workspace/redacted/node_modules/drizzle-kit/bin.cjs:126156:42)
    at async _Command.<anonymous> (/Users/redacted/Documents/workspace/redacted/node_modules/drizzle-kit/bin.cjs:131714:7)

I did notice that the drizzle/relations.ts, drizzle/schema.ts and meta/_journal.json were created and appear to be correct however.

I also having the same issue
$ npx drizzle-kit introspect
drizzle-kit: v0.23.0
drizzle-orm: v0.32.0
No config path provided, using default path
Reading config file 'C:\Users\Admin\Desktop\Evitamin\am484\evitstool_full\drizzle.config.ts'
Pulling from ['public'] list of schemas
Using 'pg' driver for database querying
[✓] 339     tables fetched
[✓] 13792   columns fetched
[✓] 16      enums fetched
[✓] 68      indexes fetched
[✓] 1586579 foreign keys fetched
TypeError: movedTables is not iterable
at applyPgSnapshotsDiff (C:\Users\Admin\Desktop\Evitamin\am484\evitstool_full\node_modules.pnpm\drizzle-kit@0.23.0\node_modules\drizzle-kit\bin.cjs:29346:22)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async introspectPostgres (C:\Users\Admin\Desktop\Evitamin\am484\evitstool_full\node_modules.pnpm\drizzle-kit@0.23.0\node_modules\drizzle-kit\bin.cjs:126156:42)
at async _Command. (C:\Users\Admin\Desktop\Evitamin\am484\evitstool_full\node_modules.pnpm\drizzle-kit@0.23.0\node_modules\drizzle-kit\bin.cjs:131714:7)

drizzle-kit: v0.23.0
drizzle-orm: v0.32.0
No config path provided, using default path
Reading config file '/Users/cristonmascarenhas/Documents/projects/trail-backend/drizzle.config.ts'
Pulling from ['public'] list of schemas
Using 'pg' driver for database querying
[✓] 19  tables fetched
[✓] 109 columns fetched
[✓] 2   enums fetched
[✓] 0   indexes fetched
[✓] 14  foreign keys fetched
TypeError: movedTables is not iterable
at applyPgSnapshotsDiff (/Users/cristonmascarenhas/Documents/projects/trail-backend/node_modules/.pnpm/drizzle-kit@0.23.0/node_modules/drizzle-kit/bin.cjs:29346:22)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async introspectPostgres (/Users/cristonmascarenhas/Documents/projects/trail-backend/node_modules/.pnpm/drizzle-kit@0.23.0/node_modules/drizzle-kit/bin.cjs:126156:42)
at async _Command. (/Users/cristonmascarenhas/Documents/projects/trail-backend/node_modules/.pnpm/drizzle-kit@0.23.0/node_modules/drizzle-kit/bin.cjs:131714:7)

Same error with drizzle-kit introspect with the latest version.
This is one of the first steps when we migrate from Prisma to Drizzle.

Same problem here

I run the same problem after upgrading the drizzle-orm version.
I fixed it by manually updating themigrations/meta/_journal.json file from
{
  "version": "5",
  "dialect": "pg",
  ...
}

to
{
  "version": "7",
  "dialect": "postgresql",
  ...
}

Maybe the command drizzle-kit up can help

Same error with drizzle-kit introspect with the latest version.
This is one of the first steps when we migrate from Prisma to Drizzle.

Same here. I want to generate a schema.ts file using introspect.

Same issue on latest version of drizzle/drizzle-kit

Even I am facing the same error.

Ditto here

Same here

Same

I directly edited bin.cjs inside my node_modules to check if movedTables is declared.

I don't know if this is right, but I was able to generate the schema based on the schemas that were already present in my Postgres.

This issue is reproducible for me in drizzle-kit version 0.23.0 but does not occur in version 0.22.8 or 0.22.9-92953ac. So downgrading the version is a temporary workaround.
In all my tests drizzle-orm is on version 0.32.0.

This issue is reproducible for me in drizzle-kit version 0.23.0, 0.23.0-03c18d1 and 0.23.0-21045a0 but does not occur in version 0.22.8 or 0.22.9-92953ac. So downgrading the version is a temporary workaround. In all my tests drizzle-orm is on version 0.32.0 (i guess drizzle-orm is not used in this process?).

this fixed it for me too

Having the same issue
drizzle-kit: v0.23.0
drizzle-orm: v0.32.1
No config path provided, using default path
Reading config file '/Users/elihirwa/Desktop/Development/BAG/Projects/bag-app/drizzle.config.ts'
Pulling from ['public'] list of schemas
Using 'pg' driver for database querying
[✓] 93  tables fetched
[✓] 641 columns fetched
[✓] 0   enums fetched
[✓] 1   indexes fetched
[✓] 151 foreign keys fetched

TypeError: movedTables is not iterable
    at applyPgSnapshotsDiff (/Users/elihirwa/Desktop/Development/BAG/Projects/bag-app/node_modules/drizzle-kit/bin.cjs:29346:22)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async introspectPostgres (/Users/elihirwa/Desktop/Development/BAG/Projects/bag-app/node_modules/drizzle-kit/bin.cjs:126156:42)
    at async _Command.<anonymous> (/Users/elihirwa/Desktop/Development/BAG/Projects/bag-app/node_modules/drizzle-kit/bin.cjs:131714:7)
✨  Done in 135.54s.

Same here

PLEASE FIX IT BUDDY T__T

0.22.8

this worked for me

Same

This issue is reproducible for me in drizzle-kit version 0.23.0, 0.23.0-03c18d1 and 0.23.0-21045a0 but does not occur in version 0.22.8 or 0.22.9-92953ac. So downgrading the version is a temporary workaround. In all my tests drizzle-orm is on version 0.32.0 (i guess drizzle-orm is not used in this process?).

Worked amazingly for me as well

do you see it on 0.24.0 version of drizzle-kit? Trying to reproduce it there, but no luck


Re-evaluate FontAwesome instead of SF Symbols

FontAwesome5 doesn't integrate nicely with Xamarin Forms, but there may be other options, such as using its typeface directly.
If we use SF Symbols, we need macOS 11, which may be fine.

Nah. In the long run, SF Symbols is the right approach here.


Add option to set RPC deadline

This affects multiple people if server goes down unexpectedly and causes gWhisper hanging.
We should

add user configurable timeout via CLI flag
set the timeout to default value of a few seconds for unary RPCs
set the timeout to infinity by default for streaming RPCs
document this very well in --help output


When will account resets be allowed again?

I haven't used keybase for a year or so and something is wrong with my paper key. I'm trying to reset my account but got the following a few weeks ago (still present):

Any news on when we'll be able to recover accounts again?

How did you open this screen? I must've missed a button.

We've updated the link at https://keybase.io/#account-reset. You may need to clear your cache to see the new copy (Ctrl-Shift-R). Thanks for the report.
In any case, you should be able to start a reset by upgrading your app to Keybase 4.7 and trying to log in.

Working, thanks!