[Issue]: rocprofv2 --kernel-trace doesn't output all dispatches

Problem Description
rocprofv2 --kernel-trace doesn't output entire trace. I searched for known limitations (seconds of trace data, number of kernels) but couldn't find anything published.
Repro script:
rocprofv2_issue_repr.txt
The script launches 400 kernels but only a fraction of them are recorded in the output, and the number varies with each invocation of rocprofv2.
Operating System
Ubuntu 22.04.5 LTS (Jammy Jellyfish)
CPU
AMD EPYC 9454 48-Core Processor
GPU
AMD Instinct MI300X
ROCm Version
ROCm 6.2.3
ROCm Component
rocprofiler
Steps to Reproduce

Rename rocprofv2_issue_repr.txt to rocprofv2_issue_repr.py.
rocprofv2 --plugin file --kernel-trace -o output python rocprofv2_issue_repr.py
results_output.csv doesn't contain the full 400 kernels dispatched.

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support
No response
Additional Information
Used docker container based on
FROM rocm/pytorch:rocm6.2.3_ubuntu22.04_py3.10_pytorch_release_2.3.0

We are no longer developing rocprofv2. The internal design of rocprofiler v2 was extremely problematic and we came to the conclusion that we need to scrap it. We re-designed the profiling library from scratch and built a new rocprofv3 on top of it in ROCm 6.2: rocprofiler-sdk. The new profiling library and rocprofv3 are far more stable, reliable, and better tested.

I see; thanks.


Update path-to-regexp Dependency to Resolve Security Vulnerability

Environment

Operating System: Windows_NT
Node Version:     v22.3.0
Nuxt Version:     3.13.1
CLI Version:      3.13.1
Nitro Version:    2.9.7
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      compatibilityDate, devtools, vite, modules
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
Steps to Reproduce:

Install @nuxtjs/tailwindcss in a Nuxt project.
Run npm audit.
Observe the vulnerability warning related to path-to-regexp

Describe the bug
I’m encountering a security vulnerability related to the path-to-regexp package. I have identified that the version of path-to-regexp used in the @nuxtjs/tailwindcss package is affected by a high-severity security issue. Here are the details:
Affected Package: path-to-regexp
Vulnerable Versions: < 0.1.10, >= 0.2.0, < 1.9.0, >= 4.0.0, < 8.0.0, >= 2.0.0, < 3.3.0
Patched Version: 8.0.0
Additional context
The @nuxtjs/tailwindcss package includes a dependency on tailwind-config-viewer, which in turn relies on @koa/router. The @koa/router package depends on an outdated version of path-to-regexp, which has a known vulnerability.
When running npm audit, the following warning is shown:
path-to-regexp  4.0.0 - 7.2.0
Severity: high
path-to-regexp outputs backtracking regular expressions - https://github.com/advisories/GHSA-9wv6-86v2-598j

Additional Info
I’ve tried using the overrides field in my package.json to force the update to 8.0.0
"overrides": {
    "@koa/router": {
      "path-to-regexp": "8.0.0"
    },
    "@nuxtjs/tailwindcss": {
      "tailwind-config-viewer": "*"
    }
  }

but this led to runtime errors as shown:
ERROR  [unhandledRejection] pathToRegexp is not a function
Logs
No response

I just saw that an issue for this is also opened at @koa/router #186

This is annoying 🙁 - there's a fair few upstream dependencies from tailwind-config-viewer we may want to address..
Can you test with nightly now? 🙂


Corrected misspelling

Protection again port scanning was in the doc - changed to protection against port scanning

@derekschauland : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Typo fix verified.


More Span and ReadOnlySpan

Description of Change
I have migrated many methods that previously required Arrays to use Spans instead. Additionally, a handful of methods that were previously string-only and already had the potential to be substituted by ReadOnlySpan were also converted to spans.
Some methods that previously did not use spans warranted keeping non-span overloads due to specific advantages or assumptions, such as the lack of needing to make defensive copies or the fact that strings are so versatile.
Some methods could not be migrated from array/string to span because the C++ requires that they be null-terminated. This could be solved by copying the contents of the span into a rented array and filling the rest of the array with null, however I wanted to discuss this change before making it.
The next changes aren't strictly related to converting to spans, but I figured they were related enough to include them here. If not, I can move them to a new PR.
I changed a few return new T[0] to return Array.Empty<T> () to reduce pointless allocations. As far as I can tell, this does not change the behaviour of dereferencing a pointer to the array.
I also changed the algorithm of implicit operator SKRuntimeEffectUniform (float[][] value) to make allocations linearly associated with the length of value rather than using a variable length list.
Lastly, I believe I fixed 4 memory leaks in SKCanvas.DrawVertices, swapped out 3 SKTypeFace.ToFont calls to SKTypeFace.GetFont in SKTypeFace.GetGlyphs, and fixed a potential(?) nullptr dereference in SKPath.GetPoints. If any changed behaviour occurs in those methods as a result, that might have been my fault.

Bugs Fixed

Related to #2616

API Changes

[x]  SKCanvas.cs
[x]  SKCodec.cs
[x]  SKColorFilter.cs
[x]  SKColorSpace.cs
[x]  SKColorSpaceStructs.cs
[x]  SKData.cs
[x]  SKFont.cs
[x]  SKMaskFilter.cs
[x]  SKMatrix.cs
[x]  SKMatrix44.cs

Removed some redundant null checks

[x]  SKPMColor.cs
[x]  SKPath.cs
[x]  SKPathEffect.cs
[x]  SKRoundRect.cs

Removed some redundant null checks

[x]  SKRuntimeEffect.cs
[x]  SKShader.cs
[x]  SKStream.cs
[x]  SKString.cs
[x]  SKTypeface.cs
[x]  SKVertices.cs
[x]  Util.cs

Swapped new T[0] for Array.Empty<T> ()

[x] SKShaper

Swapped new T[0] for Array.Empty<T> ()

Behavioral Changes
None.

Required skia PR
None.

PR Checklist

[ ] Has tests (if omitted, state reason in description)
[x] Rebased on top of main at time of PR
[x] Merged related skia PRs
[x] Changes adhere to coding standard
[ ] Updated documentation

I'll make some tests later.

Since the CI didn't run, here's a screenshot of the test results from my IDE. Was a bit of a pain to get it working since its setup for azure pipelines.

@mattleibow What steps are needed to get this PR merged into dev/reduce-arrays, then dev/reduce-arrays into main?

This would be fantastic to include especially for rendering partial arrays like on the SKCanvas.DrawPoints method.  Is the only reason this is stalled due to the numerous changes on the main or is there a more fundamental reason?

Thanks for the response! I'll get working on the requested changes.

Could you rebase and rather add overloads.

I presume this means this PR will supersede #2617?

I also added a few extra comments to things that I saw maybe should not be changed in this PR.

Yeah, I'm not sure what I was thinking with some of the changes either. It probably had something to do with the changes being authored at 4am 😅

All tests currently still pass

In SKShaper, I would like to redirect public Result Shape(string text, float xOffset, float yOffset, SKFont font) to the span overload for consistency, however the string overload currently uses Buffer.AddUtf8 which only accepts string/byte[]/span<byte>. Because of this, the span overload currently uses Buffer.AddUtf16, which produces a different (but technically more correct) cluster sequence when shaped by harfbuzz.
Because this is a breaking change, I do not want to make the call in this PR, but I would like to start a discussion on whether it can be done in order to maintain output parity between the string and span overloads.


chore: check dev dependencies

This is a bsupport request
Problem
Some of the dependencies were moved from devDependencies to dependencies after new linter rule was introduced.
https://github.com/waku-org/js-waku/pull/1111
https://github.com/waku-org/js-waku/pull/1111/files#r1080568044
Proposed Solutions
Need organise them properly.

Note that more urgently,  the dependency @waku/peer-exchange > @libp2p/interface-peer-discovery-compliance-tests should be removed as it impose a usage of NodeJS 18 that creates an error at installation.
▶ nvm use 16
Now using node v16.17.0 (npm v8.19.3)

▶ npm i @waku/core
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package<EMAIL_ADDRESS>npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.17.0', npm: '8.19.3' }
npm WARN EBADENGINE }
npm WARN deprecated<EMAIL_ADDRESS>Please use @jridgewell/sourcemap-codec instead

added 1625 packages, and audited 1836 packages in 3m

324 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

This one @libp2p/interface-peer-discovery-compliance-tests is definitely not used at all so I removed it. As for the logs that you shared - I don't see any error, it seems as just a warning so everything should work. I was not able to see any errors in node versions 16 - 19.
Can you clarify what you meant, @fryorcraken?

Removing the dep quoted should be good enough to remove the warn :+1:


import_undici.setGlobalDispatcher is not a function.

Before you report a bug ...

[x] I have checked that I am on the latest version of discord-player-youtubei
[x] I have checked existing issues to see if this is a duplicate report

Description of the bug

I register this extractor but got error:

27581 | var meta_url = import_meta.url;
27582 | var is_cjs = !meta_url;
27583 | var __dirname__ = is_cjs ? __dirname : import_path.default.dirname((0, import_url.fileURLToPath)(meta_url));
27584 | var { homepage, version, bugs } = { "homepage": "https://github.com/LuanRT/YouTube.js#readme", "version": "10.5.0", "bugs": { "url": "https://github.com/LuanRT/YouTube.js/issues" } };
27585 | var repo_url = homepage == null ? void 0 : homepage.split("#")[0];
27586 | (0, import_undici.setGlobalDispatcher)(new import_undici.Agent({
                          ^
TypeError: import_undici.setGlobalDispatcher is not a function. (In 'import_undici.setGlobalDispatcher(new import_undici.Agent({
    connect: {
      timeout: 60000
    }
  }))', 'import_undici.setGlobalDispatcher' is undefined)
      at E:\disbot-v2\node_modules\youtubei.js\bundle\node.cjs:27586:19
      at E:\disbot-v2\node_modules\discord-player-youtubei\dist\index.js:45:24

Here is my code:

  await player.extractors.register(YoutubeiExtractor, {
    authentication: oauthTokens,
    streamOptions: {
      useClient: "ANDROID",
    },
  });

Steps to reproduce

Just do like previous step
Versioning
discord-player: 6.7.1
node.js: latest

I have only tested the extractor on NodeJS LTS and haven't on the latest. This seems to be related to undici being undefined.

Could you try running the command npm install undici and see if that fixes it

I am closing this issue due to inactivity. Will reopen if needed.


Add dds config file parser

Codecov Report
Base: 43.09% // Head: 43.01% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (66d17f7) compared to base (0a144a1).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   43.09%   43.01%   -0.08%
==========================================
  Files         119      119
  Lines       35490    35558      +68
==========================================
+ Hits        15293    15294       +1
- Misses      20197    20264      +67

Impacted Files
Coverage Δ

src/supplemental/nanolib/conf.c
0.00% <ø> (ø)

src/supplemental/nanolib/conf_ver2.c
0.00% <0.00%> (ø)

src/core/timer.c
92.20% <0.00%> (-5.20%)
:arrow_down:

src/supplemental/http/http_client.c
24.78% <0.00%> (-2.18%)
:arrow_down:

src/platform/posix/posix_tcpconn.c
75.00% <0.00%> (-2.16%)
:arrow_down:

src/core/list.c
84.61% <0.00%> (-1.29%)
:arrow_down:

src/sp/transport/inproc/inproc.c
79.16% <0.00%> (-0.76%)
:arrow_down:

src/supplemental/http/http_conn.c
70.14% <0.00%> (-0.57%)
:arrow_down:

src/core/stats.c
81.70% <0.00%> (-0.43%)
:arrow_down:

src/supplemental/websocket/websocket.c
62.75% <0.00%> (-0.15%)
:arrow_down:

... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[DOCFIX] Release Notes 2.6.0

What changes are proposed in this pull request?
add release notes
Why are the changes needed?
bring release notes to docs
Does this PR introduce any user facing changes?
n/a

alluxio-bot, merge this please


[Impeller] Provide an API for loading FragmentPrograms at runtime (and tooling support for producing them).

Use case
We would like to be able to dynamically load shaders at runtime like https://www.shadertoy.com or https://www.alma.sh/. Currently FragmentProgram only has a static method for loading assets, which seems a bit limiting as it is just shader bytecode that is being put into the bundle. For instance, web implements this as such:
 @override
  Future<ui.FragmentProgram> createFragmentProgram(String assetKey) {
    if (_programs.containsKey(assetKey)) {
      return _programs[assetKey]!;
    }
    return _programs[assetKey] = assetManager.load(assetKey).then((ByteData data) {
      return CkFragmentProgram.fromBytes(assetKey, data.buffer.asUint8List());
    });
  }

Proposal
The functionality already exists behind the scenes, so I just suggest it becomes part of the top level FragmentProgram api:
For instance this already exists:
static Future<CkFragmentProgram> fromBytes(String name, Uint8List data)

This only exists in the Skia backend, because it ships a shader compiler. We'd like to remove this shader compiler eventually with Impeller to reduce code size. We do not plan to add features that require us to retain a shader compiler indefinitely.

@jonahwilliams I think you misunderstand the request. I am requesting a method not for compiling the C code for the shader. I am requesting a method for loading either a SPIRV shader (which can definitely be converted at runtime both in web or impeller), or the same platform specific binary data that the compilers are outputting. The request is for runtime loading of shaders not runtime compiling of shaders.

SPIRV would only be supported on a Vulkan backend though. On a metal backend you need to load a metal shader, and on an openGL backend you need to load GLSL. The only way to support consuming arbitrary shaders at runtime is package a runtime compiler.
We could support an API that simply accepted the binary format that Flutter expects, which today is a blob containing shader code for a particular platform along with uniform metadata.

@jonahwilliams yeah that's what I'm requesting, the ability to load them at runtime. Compilation is out of scope for this request. It's not too hard to run SPIRV-cross somewhere and get the output for the target platform, just need some kind of hook to be able to load a runtime asset and a definition somewhere of what the format should be for each platform.

impellerc already produces the format the engine needs, but its not easily usable and the format is currently unstable. We could expose this functionality with caveats that future versions of Flutter may break the feature, or we could stabilize the format. There are likely more caveats

+1 I would also like this feature!
Our app renders midi music & we want want to support custom "themes" uploaded at runtime i.e. fully custom shaders

For anyone else that encounters this problem, a workaround is to use a platform webview & webgl.
Not ideal, but it works for my use case.

@chipweinberger maybe if you just need to render a shader, but so good if you need it to be able to interact with the rest of the canvas.

impellerc already produces the format the engine needs, but its not easily usable and the format is currently unstable. We could expose this functionality with caveats that future versions of Flutter may break the feature, or we could stabilize the format. There are likely more caveats

Hi @jonahwilliams  When exactly are you going to do this? This is exactly what I need now, even if the format may change in the future, we can already begin to develop this direction.

I have no plans to work on this in the near future (hence it is unassigned and low priority). This isn't something that we can reasonably work on until we're closer to done with the Vulkan backend for Android.

I have no plans to work on this in the near future (hence it is unassigned and low priority). This isn't something that we can reasonably work on until we're closer to done with the Vulkan backend for Android.

It's a pity :(
@jonahwilliams  Can you tell us about this task in a little more detail, Please, in case someone would like to do this? Can you tell where to look, what is ahead, and where to start? I understand that the question is endlessly noob, but maybe in the community there will be a person with suitable skills or someone will want to acquire such skills ;)

I can't really scope out the work for the problem without spending a substantial amount of time on it .... which would mean that I'm not working on higher priority projects

Can you tell us about this task in a little more detail, Please, in case someone would like to do this? Can you tell where to look, what is ahead, and where to start? I understand that the question is endlessly noob, but maybe in the community there will be a person with suitable skills or someone will want to acquire such skills ;)

Don't think it's gon be that easy, it's more like creating a new language and a compiler / transpiler. But yeah could create one.
What would be best is if flutter exposes support to load Vulkan, OpenGL and metal shaders separately. Then community can pick it up. @jonahwilliams is it possible ?


Related work

https://www.dvrpc.org/webmaps/sidewalk-gaps/
https://dvrpc.github.io/network-routing/

https://ntnuopen.ntnu.no/ntnu-xmlui/handle/11250/3151985

https://kauevestena.github.io/opensidewalkmap_beta/


Replace custom sqlite dbms with prisma

Integrating Prisma ORM to replace the custom sqlite dbms to improve developer experience.
resolves #237

Ready to merge:

Update remote CF instance
Dry run on test instance + migrate & deploy
Announce migration


SideBar documentation has invalid links to API Doc and PassThrough Doc

The links to the API Doc and PassThrough Doc in the documentation for the SideBar component are not working and display a 404 page.

Hi, this issue has been resolved in the latest updates.


Command for toggling mutability

I noticed an old feature request for rust-mode.

It would be better to find a solution that can also be used by rust-mode, ideally without adding dependencies.

I copied the solution from reddit and added the command rustic-toggle-mutability. But I think it would be nice if it was possible to change the mutability when the cursor is not on the line of the variable.


GDScript: Add CONFUSABLE_CAPTURE_REASSIGNMENT warning

Resolves #93070 (plus we should document it properly).
See also godotengine/godot-proposals#8558.

This is not a bug fix, but I think it would be nice to add the warning in 4.3, since this behavior is quite confusing while the change is simple and low risk.

@Mickeon What exactly causes you concern? Is the problem in the wording or terminology? Can you suggest a better option?

It's the wording. The warning's name sounds correct, but it's a bit hard to understand. "Confusable", but why? It's somewhat broad. An assignment can be "confusing" for a few other reasons too.
Nowhere in the description it is stated that this is explicitly for lambdas, too.
I have no other better suggestions at the moment. I just know that because this is a very specific warning, it needs a very specific name (potentially just mentioning lambdas/callables directly?).

Nowhere in the description it is stated that this is explicitly for lambdas, too.

You are right, I forgot to add this to the Project Settings description, although it is present in the warning message: Reassigning lambda capture does not modify the outer local variable "%s".

I agree that it could use mentioning lambdas at least in the description, and maybe in the warning's name (but that will start being long).

I thought about CONFUSABLE_LAMBDA_CAPTURE_REASSIGNMENT, but then that would be the longest warning code.

Begrudgingly we cannot have warning names that span the width of your monitor.

Thanks!


Add support for the 68533 image format

At a first glance, everything seems to work as expected. :-)
Also updated build files.
Closes #137.

Very sorry for the late reply!

but isn't there a new 32bit format number, too?

Unfortunately, I don't have more details about the image format numbers, maybe @marceltaeumel could help?

Also, it looks like you accidentally checked in .gitpod.yml and .nvmrc

If you don't like them, I can remove them again ... but tbh they make the setup easier, at least for me 😅

but isn't there a new 32bit format number, too?

Unfortunately, I don't have more details about the image format numbers, maybe @marceltaeumel could help?

I found out the new 32-bit format number with mt's help - 7033 -, but unfortunately, the VM seems unable to parse this image format (Uncaught RangeError: Invalid typed array length: 25439843 from readBits()). I'm afraid I don't understand enough to fix this. :(
(Btw, I think that Smalltalk image imageFormatVersion seems to output nonsense in SqueakJS, or is the fallback code wrong?)

FYI - The image format numbers are documented in the package named "ImageFormat" which can be loaded from the VMMaker repository at source.squeak.org. This is a stand-alone package with no dependencies on VMMaker itself, so you can load it into any Squeak image. Take a look at the class comments, utility methods, and unit tests to see how the numbering system works.

Note also that for both the 32-bit and 64-bit image, you can clear one bit in the image format number (as read from the disk file) to get the image format number that is currently recognized:
7033 bitClear: 2r1000000000 ==> 6521
68533 bitClear: 2r1000000000 ==> 68021
Since we know that the SqueakJS VM supports multiple bytecode sets (Sista), then it may be that all that is needed here is to clear the bit after reading it from the image file. The only complexity is that we need to remember that bit setting so we can write it back out to disk with the bit set properly. In the compiled VMs, the setting is maintained in an instance variable in the interpreter.

Possibly useful references:
In class ImageFormat, I started with five historical image format numbers:
ImageFormat baseVersionNumbers ==> #(6502 6504 68000 68002 68004)
hasClosures and wordSize need to be derived from these five numbers (not from a bit test). The other things are simple bit tests that are the same for 32-bit and 64-bit images. The logic is in ImageFormat>>fromInteger:
To illustrate:
7033 bitAt: 10 put: 0 ==> 6521
6521 bitAt: 5 put: 0 ==> 6505
6505 bitAt: 1 put: 0 ==> 6504
68533 bitAt: 10 put: 0 ==> 68021
68021 bitAt: 5 put: 0 ==> 68005
68005 bitAt: 1 put: 0 ==> 68004

@codefrau this is untested and I am not a Javascript pern but I think that the image format reading might work like the following. Note that the multipleByteCodeSetsActive variable is useful only if we also implement the #primitiveMultipleBytecodeSetsActive primitive in the interpreter. This is of no immediate interest for SqueakJS but I added the variable to show how it would be set if it was needed.
    // read version and determine endianness
    var baseVersions = [6502, 6504, 68000, 68002, 68004],
        baseVersionMask = 0x119EE,
        version = 0,
        fileHeaderSize = 0;
    while (true) {  // try all four endianness + header combos
        littleEndian = !littleEndian;
        pos = fileHeaderSize;
        version = readWord();
        if (baseVersions.indexOf(version & baseVersionMask) >= 0) break;
        if (!littleEndian) fileHeaderSize += 512;
        if (fileHeaderSize > 512) throw Error("bad image version");
    };
    this.version = version;
    var nativeFloats = version & 1;
    this.hasClosures = [6502, 68000].indexOf(version) < 0;
    this.isSpur = version & 16;
    var multipleByteCodeSetsActive = version & 256; // probably not needed(?)
    var is64Bit = version >= 68000;

merged


feat: Support microseconds in the Atom / RFC 3339 / ISO 8601 format

This commit adds default support for microseconds in the RFC 3339 format.
The references to the “Atom” format have been updated to RFC 3339 which is identical to the Atom format, but uses a reference that is not PHP-specific.

Failures appear to be unrelated and probably depend on the ICU version. It's a little odd that the error code appears to be U_ZERO_ERROR which indicates that no error happened. Unfortunately I'm unable to reproduce this locally.

Test failures are a PHP regression: php/php-src#12020

Hi @TimWolla, thanks!
I'd like more input on the reasons why you think this particular format should be available. I have to be honest, I did chose to accept DATE_ATOM format by default for no real reason, mostly because from what I saw it was often used in other popular projects (can't even remember which ones).
Is there some kind of general approving on the RFC 3339 format in the PHP/web/software development community?

Awesome, thanks for the detailed explanation!

@TimWolla I can't push to the repository because it is from the WoltLab org; could you rebase on master?

 Now done.

Thanks!


Add snippet to enable/disable HTML page scrolling

My first PR as part of #hacktoberfest.
Two simple JS helper functions to enable/disable HTML page scrolling.

Thanks for contributing. However, your PR doesn't follow our contribution guidelines correctly and it doesn't provide enough value for the average reader. Closing due to that.

Hi Trinity,
Thanks for reviewing my PR.
This was my first contribution and I thought I'm following the guidelines. Can you please let me know the specifics of where this fell short so that I can improve my subsequent contributions?
Thanks


The leaderboard is missing in https://paperswithcode.com/sota/speech-recognition-on-common-voice-7-0

Since it gets removed by the officials, we close this issue for now.


Support

mj-text align property should support "justify" value

It does actually:
https://github.com/SebastianStehle/mjml-net/blob/main/Mjml.Net/Components/Body/TextComponent.cs#L17
https://github.com/SebastianStehle/mjml-net/blob/4acfa01f57244a1627e07d25e9249c9a2f3ff560/Mjml.Net/AttributeTypes.cs#L9


DateTime Kind not set properly upon account retrieval from EF repository

Migrated from IdentityServer/IdentityServer3.MembershipReboot#37
A sample demonstrating the issue is available here
When a user account is retrieved from an EF based repository the "Kind" property of the account is not set (Kind = "Unspecified") which can lead to unexpected behavior downstream - an offset may be applied to a time already in UTC. "Kind" is set properly as soon as the record is saved or modified.
The root cause is that EF doesn't allow you to specify a default Kind for DateTime. This has been discussed multiple times on SO, e.g., here, here, here.
Copying from the previous issue report:
Options to remedy are essentially:

Switch to DateTimeOffset from DateTime (this is being discussed separately here brockallen/BrockAllen.MembershipReboot#388)
Modify the accessor of DateTime properties to set the Kind property
Modify the dbContext to respect a new attribute for datetime kind on account properties
Modify the dbContext to enforce a UTC datetime kind on all datetime values retrieved from the DB

All of these could have side effects depending on how people are using DateTime values. (1) is a breaking change, (2) and (3) could affect people overriding the base Created/Updated/etc. properties, (4) could cause unexpected behavior for people who have extended RelationalUserAccount with custom DateTime properties that are for some reason not persisted in UTC.
Ideal resolution will probably be either (3) or (4) depending on feedback here.

This fell off my radar but I noticed it in my queue. @brockallen - any preference on which path to take? I'm happy to submit a PR but since there are side effects to every option would like your feedback first.

I think I prefer (4).


To-do

Allow for typeref tokens in expressions to call the ProcessAccess() method.
Implement compilation of calls to static methods.
Hopefully figure out why Clang is failing to compile sizeof().

Updated the README as it is severely out of date.
Start the wiki!

Add support for the newline character and singular characters in general.

Regex.Unescape the newline chars so that they work.

Add support for attributes.

Make sure the function call compiling doesn't load the values.

Allow pass by ref.

Implement callbacks and anonymous functions/lambdas.

Something may be wrong with the load keyword when used with a string. Fix it.

Use SExt when building a cast to a signed integer.

Make e+ an operator that multiplies the left operand by 10 to the power of the right operand. Essentially a shortcut for left * (10 ^ right)

PEDMAS is broken again, all operations are stealing from the left.

Checklist!

Interfaces
Inheritance
Prepending a namespace before a function or struct for clarity
"Good" enums
Properties (see this previous comment)
Thread panicking
Improved array instantiation
if value is #SomeType someTypeVal { }
Enumerators? for val in list?
GC (or ref counting? or ownership?)
DLL linking
All the related core lib stuff


Filesystem access abstraction layer

CumulusCI should provide some pluggable mechanism for interacting with the filesystem instead of directly using the os module.  Tasks should be changed to use the abstracted methods to access the filesystem.
Why?

Ability to run cumulusci tasks and flows against a repo stored somewhere other than the local filesystem like perhaps in Amazon S3
Makes cumulusci portable to web apps

I just pushed a branch over on my fork where salesforce_api/metadata.py uses StringIO in place of TemporaryFile (for unrelated poking around reasons): https://github.com/cdcarter/CumulusCI/commit/3a303c19fe4b4040a942c428a5e5e7099f07dfb9.
Not sure if this is in line with what you're thinking at all or helpful?

A few things today from a chat with Jason about this feature:

Probably makes sense for BaseTask to add self.fs or self.workspace which would be the definitive API for task authors to access the filesystem.
Probably modules/APIs should be written to handle all files in-memory, only tasks should touch/be aware of the filesystem.


feat: update gogoproto to v1.4.11 and golang.org/x/exp to latest

Closes: #XXX
What is the purpose of the change
I'm looking to try out new traces:
https://go.dev/blog/execution-traces-2024
That requires a newer version of exp package
We force replace it here due to an API break in gogoproto.
The new gogoproto tag already contains the fix. As a result, I propose bumping it.
Testing and Verifying
I will run a node with this change to ensure no state-breaks
Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?
[ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[ ] N/A

TODO: If we decide to merge this, cosmos SDK PR should be merged first and dependency retagged from branch

OK deps updated to point to SDK main. Tested this for a while on v24 against state breaks


pdf viewer errors in chrome

I have a pdf file which has some pages with different page size/format (A4/letter/B5 pictures). When I'm printing it in pdf viewer in chrome, I find each page size/format will be change to the the first page size/format. This will squeeze or stretch the page (pictures).
OS: windows 7 x64
chrome v44/v45 x64/x86

Link to PDF? See https://github.com/mozilla/pdf.js/blob/master/CONTRIBUTING.md

I've tested some pdf files (made from jpg pictures),  each file with different page size/format can reproduce the bug.
I also find pdf.js v1.0 do not has the bug.

example
link to pdf
http://ge.tt/7pCBPHO2/v/0
print preview for the second page
http://ge.tt/3teKQHO2/v/0

@lszhu If "pdf.js v1.0 do not have the bug", then this bug is most likely caused by #6462. That PR resolved a problem with page size, but due to the lack of support for targetting specific pages via CSS, pages with different sizes are scaled to fit on a single page.
The console will contain a warning when the page sizes are incorrect. Perhaps we should not try to unify the page size when we detect that the PDF pages have different page sizes? The relevant ode is here: https://github.com/mozilla/pdf.js/blob/f06aa6a3802ef6fb6c8919ef3de49bcfe774cb51/web/viewer.js#L1107-L1133
If I prevent the stylesheet from being inserted, the images are not rescaled, but three pages are printed, which is also incorrect (if you want to test it yourself, type document.body.appendChild=function(e) { console.log('would have appended', e); }; in the console and try to print; the stylesheet won't be appended, which brings PDF.js back to the pre-#6462 state).
The best way to get rid of this bug is to use named pages (as you can see in the comments in our source code), but Chrome doesn't support that yet.

Shall be addressed by #7677


dates in search results table

If a person has years only in their lifespan this is shown as either "-07-01" or "-07-02".

this makes it nearly impossible to match duplicate birth dates. better would be to show only the year

sorry, this was not expressed properly. so as far as i'm aware there are two fields, date-iso and date-written.
if date-written is present i would

<sortdate hidden="true">{date-iso}</sortdate> + date-written (before the part in <…>)

if date written is empty
date-iso

as the sorting is done server side unlike in e.g. schnitzler-briefe your suggested solution does not work here. But for sorting you can always toggle the additional colum start_date and sort using this e.g. https://pmb.acdh.oeaw.ac.at/apis/entities/entity/person/list/?name=Mildenburg&columns=start_date&sort=start_date
but let's discuss this IRL


allow Shift+Click via listring

Allows a player to transfer items between inventories by using Shift+Click.
Tested with minetest-5.4.1

fixes https://github.com/minetest-mods/crafting_bench/issues/6


GPU support?

Hi!
This is not an issue, but I wanted to contact you to ask you something. The repository is a great job!! it works super nice and is very easy to implement in almost every script! Do you have any plans for giving GPU support?
Thanks!

I probably won't get to that for another couple of weeks, so if you can implement it, it'd be much appreciated.

Btw the repository is still quite unstable -- so make sure you take care before upgrading to new versions if you have a version that's working.

Awesome, I also need GPU support!

Any updates?


Control Sidebar not opening on Single Page Application

Hello,
I've been trying to create a spa app using react, and used admin lte as my main template. When I'm about to use the Control Sidebar, it shows some weirdness in it. On the first load of the app, it will work properly, but then when I switch to other page using react-router, and goes back into the page where control sidebar is implemented, it's not working. Please help, thanks in advance

I don't know, how react works. In ember.js you need to run $.AdminLTE.controlSidebar.activate(); after adding control-sidebar in page.

I have met the same problem when using AdminLTE with ui-router in AngularJS.

Use this
example
in the code you put something like
in header:

`

In component

mostratAside(){
        getAdminLTE().controlSidebar.activate('click');
        console.log('click');

    }

I hope you understand me

Due to some neglect in my part, many issues weren't addressed for some time. Some of these issues are no longer relevant since a solution might have been found. Therefore, we decided to close all issues that are over a month old. However, if the issue still persists and you'd like help, then by all means repost your issue and we will consider it again. In the mean time, we will close this post.
Thanks for your understanding and we apologize for any inconvenience <3.

I'm having the same problem working with an Angular4 application...


img Html tag and LaTeX code not compiled properly

Hello,
I forked your repo but when editing it, img Html tags and LaTeX code are not compiled properly and appear as text, see this page: https://aymeric75.github.io/nas_page
I cannot find the reason why this is happening, do you have any idea ?
Thanks a lot

This project is no longer maintained and has been discontinued. No further updates or support will be provided. Feel free to fork the repository and make any necessary changes on your own.


Cookie issue

Hi, love this project! Super cool and useful. I'm trying to implement it but having some issues using cookies.
After logging in and being issued a cookie, every protected route returns a 401:  "detail": "Unauthorized"
I've checked and:

my only auth_backends is CookieAuthentication

my SECRET variable is linked

and cookies are attached to the headers of my responses in the browser. Currently, using Insomnia REST to test my API which automatically attaches/manages cookies.

Is there something else I could be missing?

@roshmath can you say what the fix was?

I believe the resolution may have been setting cookies_secure to False as that's what resolved it for me.

Yes, you may have to set cookie_secure to False in local development to make it work. However, I highly recommend to make it an environment variable setting so that it's enabled in production. This way, the cookie is only sent over HTTPS connections.
See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie


Don't round values in Thermostat internal state

Since all values coming out of the Thermostat component pass though the
_convert_for_display() method (which handles any necessary rounding),
there is no need to round values that only exist in the internal state
of the thermostat device. It serves no purpose and risks rounding
errors/precision loss.

:+1: :dolphin:


Add support for GitHub Copilot to generate commit messages

Could you please add support for GitHub Copilot to generate commit messages.
langchain4j should since the latest version support the GitHub model.
Thank you very much for the cool project.

Hey @hemeroc,
thanks for opening the issue.
Support for GitHub models has been added with https://github.com/Blarc/ai-commits-intellij-plugin/commit/8e62ce91dd169068d0852ec28f5dfa07426efac2.


Change required to false by default

@chadzink Yeah the default should have always been false. Setting it as a default to true and requiring fields broke forms. Most newer browsers force fields with the require attr to have the field filled out before handling a submit event.

That PR had review done on it with multiple changes requested (I requested changes, but missed the impact of required: true by default), but I think we need to be more careful when we are introducing defaults into existing components.

Interestingly enough, every other component had required: false instead of true, only the input component was set to that.


number field should produce numbers

now it can produce a string too

I'm sorry, I'm not going to merge a PR for one-way-controls that interpret the values going in/out the inputs. If you want to do this, you can do this perfectly well in the update action.

The interesting thing here is that when using the up/down button of a number field in your browser, the value will update from 1 to "2" (when incrementing).
From reading the source I see I can pass an action into sanitizeInput, which seems the way to go.
Thanks!


How to use injectReducer width version4.0

Description
upgrade to v4.0，used Component/PureComponent width injectReducer, change the props but page is not render.
Has anyone ever encountered this problem? How to solve it
Steps to reproduce

create component and reducer
use injectReducer add reducer to component
change props

Expected behavior
https://github.com/react-boilerplate/react-boilerplate/issues/2715#issue-481143442
Screenshots
Versions

React-Boilerplate: 4.0.0
Node/NPM: 11.2.0/6.4.1
Browser: Chrome

Hi. It would be better if you could add some portions of your code so the problem becomes more obvious to notice.
But anyway, I noticed that when you generate a container with reducer and saga, it automatically does this:
import { useInjectSaga } from 'utils/injectSaga';
import { useInjectReducer } from 'utils/injectReducer';

yet this throws an error and I realized that if I change it to:
import injectSaga from 'utils/injectSaga';
import injectReducer from 'utils/injectReducer';

It solves my problem. So first check if you are doing what I did (guess you already have...). Then update your issue with corresponding code and I'll try to help you with updated info.

@erfan226   code is here   https://github.com/react-boilerplate/react-boilerplate/issues/2720#issue-481413501
code same as you

Alright. Then test this. Instead of using reselect for states, do a mapStateToProps as below:
export function mapStateToProps(state) {
  return {
    loginInfo: state.login.yourstate,
  };
}

@erfan226   sorry it's my mistake，  reducer name error

@erfan226 You're having trouble with the saga and reducer injection hooks? Any specific reason you're switching back to the old HOC API?

@julienben Yeah, I don't exactly remember the errors I was getting, but I couldn't use them with a class. That's the first reason. So do I need to use functions instead of class to make them work?

Yes, React Hooks can't work inside a Class component. If you're writing Class components, you need to use the HOCs. That's why we left them inside.

@julienben I see. I guess I'll be alright then :)
Thanks!


This fixes #57

When modifying default tg the new one need to be created for listener be able to use it and terraform can destroy the old one later

Hey again @egarbi . I'm wondering if this actually fixes the problem in #57 . Imagining a create_before_destroy scenario here, I'm wondering if name conflicts between the old and new target groups also raise errors. If you've tested your branch and making changes to the target group works, I'll go ahead with the test and merge.

@brandoconnor  you're right, this only fix the case when name changes, all other attributes will fail with:
aws_lb_target_group.main: Error creating LB Target Group: DuplicateTargetGroupName: A target group with the same name 'default-uat' exists, but with different settings

@brandoconnor I would say this is better than nothing, With this, you can change at least name without this you can change nothing. I can figure now a permanent solution. Don't know mate, you're the expert here. It's up to you. Thanks for this module.

The change is appreciated, I just think we need to be clear in the docs about the caveat and how to do a workaround.
I've vetted the change and added some extra bits to the docs and tests to incorporate it. Merging now.


Add support for .webp files

The bot should be able to successfully process a .webp file and return the resized .png

Hello, great project. I would like to be assigned this issue  please

Hi @B-Stanley, do you need any help with this issue?
If you aim to complete the pull request in time for Hacktoberfest you have a few days left

Hi @B-Stanley, as explained here, the ticket will be reassigned due to inactivity.


Skip flux status check if image tag hasn't changed but gitops has

Reproduce using the following steps:

Commit to master for service
CI / CD runs fine
Tag service
CI / CD runs fine
Update gitops repo (change CD reference tag for example)
Manually run CD
Push validation will go through
Image tag won't be changed
flux-status-cli will check for status of the latest gitops commit which will never be updated by flux-status

Maybe can be solved using either the latest commit of the env folder (dev/) or the latest commit of the service yaml (dev/service.yaml)

Fixed by https://github.com/XenitAB/azure-devops-templates/pull/16


[BugFix] Fix incorrect error message when create routine load failed

Currently, when a routine load job is created, the FE requests to BE connected to the Kafka broker. However, if the user specified a wrong broker address, BE will wait a very long time to realize the problem (related to librdkafka's implementation), because BE will wait a very long time, FE will call the BE's RPC interface time out, and FE will inform the user that the RPC communication failed, rather than the wrong Kafka broker address. This PR avoids this issue by deleting the logic of connecting the Kafa broker when a routine load task is created. If the Kafka broker address is incorrect, the user can run the show routine load command to obtain the information.
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)


Updating message in threads for new Assistant view

I am not seeing updates being applied using chat.update Web API method when using the Slack Assistant view.
Reproducible in:
The slack_bolt version
django-slack==5.19.0
slack_bolt==1.21.1
slack_sdk==3.33.1

Python runtime version
Python 3.11.6
OS info
ProductName:            macOS
ProductVersion:         15.0.1
BuildVersion:           24A348
Darwin Kernel Version 24.0.0: Tue Sep 24 23:39:07 PDT 2024; root:xnu-11215.1.12~1/RELEASE_ARM64_T6000

Steps to reproduce:

Enable assistant_view for Slack App
Initialize Slack SDK client
Call chat_update method using either slack_message["ts"] or slack_message["thread_ts"] of the message returned from the Slack API.

            client.chat_update(
                channel=channel, ts=slack_message["thread_ts"]
            )

Expected result:
SPECTACULAR FAILURE... or updating of the message.
Actual result:
Message is not being updated, no exception is raised, and Slack API returns a HTTP 200

Hi @kennym, thanks for asking the question. The channel_id and thread_ts are used for specifying an assistant thread, which means you cannot use thread_ts for updating a specific message within an assistant thread.

slack_message["ts"]

The "ts" is usually usable for chat.update API calls, but I'm not sure how the "slack_message" data is received. If you could provide a bit more detail, such as the entire app.event listener (or assistant middleware code if you're using it), we might be able to help you debug your code or identify a potential bug on our SDK side.

but I'm not sure how the "slack_message" data is received
Sorry, slack_message would be the JSON we get back from the message.im event via the Slack Events API, so the data about the Slack message.

I've tried using the chat.update Web API with the ts params which previously worked when not using the new Assistant feature for updating a message, but that stopped working. I've also tried using the thread_ts attribute for use with the chat.update API but that also doesn't work.
Do you have an example on how I could update a message when using the assistant feature?

I don't think we can share a simple example code for it. When your app receives a message event within app.event("message") / app.message event listener, the message should posted by a human user, rather than the app's bot user. If your app attempts to update the message using the bot token, it won’t succeed because the bot token lacks permission to update messages from other users. If your app have ignoring_self_events_enabled: False option when initializing it, your app can receive your app's bot user messages as well and chat.update should work work in such cases.
For building an assistant app, we highly recommend using Assistant middleware class to set up your listeners: https://tools.slack.dev/bolt-python/concepts/assistant The middleware does many things for you. If you have a certain reason to continue implementing app.event / app.message for assistant threads, reviewing these listener codes may be beneficial: https://github.com/slack-samples/bolt-python-assistant-template/tree/main/listeners/events
Lastly, I understand you may not be able to share your actual code, but if you could provide some simplified code that reproduces the issue, we'd be happy to assist you further.

This is an example of an error ☝

ok, here I get with a valid ts:

this only happens with the assistant view feature enabled.

ok, I found the problem.
We were using the conversations.history for fetching messages in a channel, but with the assistant view enabled that didn't return the messages we neeed.
I switched to conversations.replies and that fixed our problem immediately.

ok, I found the problem.
We were using the conversations.history for fetching messages in a channel, but with the assistant view enabled that didn't return the messages we neeed.
I switched to conversations.replies, providing the ts with the valued of the thread and that got us back the correct messages we could update.


[Usability] Confusion over "Model" vs "Device Type"

When you create a new device, Netbox prompts you for "Manufacturer" and "Model".
However it is non-obvious how to create a "Model". After some head scratching, it turns out that actually you need to create a "Device Type"
This could be made clearer by using the same name consistently throughout the interface, or at least giving a hint:
Manufacturer         [Apple      ]
Model (device type)  [           ]

Also: if you have not created any device types, this stops you creating a device. So another approach would be to display a message if you select it, in place of an empty drop-down list:
Manufacturer    [Apple      ]
Model           No device types yet created for Apple

(or this could be an option list with one greyed-out member)

already fixed. Did you pull the latest version and run ./upgrade.sh?

You guys are too quick for me :-)
The upgrade went without a problem, except the running manage.py died:
usage: manage.py runserver [-h] [--version] [-v {0,1,2,3}]
                           [--settings SETTINGS] [--pythonpath PYTHONPATH]
                           [--traceback] [--no-color] [--ipv6] [--nothreading]
                           [--noreload]
                           [addrport]
manage.py runserver: error: unrecognized arguments: --insecure

But oddly, I was able to restart it with the --insecure option just fine, despite what the error message said.
BTW: I have just done a demo of netbox at the Rwanda Network Operators Group network monitoring and management workshop. Thank you for the great work!


Warning with out-of-the-box config

Bug Report

OS: W10
TSLint version: 4.4.2
TypeScript version: 2.1.5
Running TSLint via: npm script: tslint \"./*/src/**/*.ts\" \"./*/src/**/*.tsx\" --exclude \"./**/node_modules/**/*.ts\" \"./**/node_modules/**/*.tsx\"

TypeScript code being linted
not relevant

with tslint.json configuration: tslint -i
Actual behavior
One print out of:
no-unused-variable is deprecated. Use the tsc compiler options --noUnusedParameters and --noUnusedLocals instead.

Multiple print outs of:
Could not find implementations for the following rules specified in the configuration:
    label-undefined
    no-duplicate-key
    no-unreachable
Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed.
If TSLint was recently upgraded, you may have old rules configured which need to be cleaned up.

Expected behavior
The rules dosen't exist in tslint.json so the warning should not be there. no-unused-variable is not used either.

Can you check if you used a global version of tslint to initialize tslint.json? The tslint -i CLI uses this default config, which has been appropriately updated as rules have been deprecated: https://github.com/palantir/tslint/blob/dc7c47344c15c11513dc1253ed14bab259edd3ce/src/configuration.ts#L43. I think you might've used an older version of the CLI there.

This is the first use of tslint on this computer that I can remember of and I haven't installed it globally, I run it through npm scripts (tslint -i as well).
This is the tslint and tsconfig I'm using. There is some small changes done by me, like disabling semicolons. But the rules it's complaining about is not there.

This issue went away when I changed the script to "lint": "tslint \"./*/src/**/*.ts?(x)\" --exclude \"./**/node_modules/**/*.ts?(x)\"".


check_bounds in tests/runtests can be written more compactly

This is a very minor stylistic point but the check_bounds function in test/runtests.jl
        function check_bounds(xl, x, xu)
            flag = true
            for (lᵢ, xᵢ, uᵢ) in zip(xl, x, xu)
                flag &= lᵢ ≤ xᵢ ≤ uᵢ
            end
            return flag
        end

could be written
any(xl .≤ x .≤ xu)

These are equivalent except that the any version will short-circuit as soon as it finds a bounds violation.  In other words, it is equivalent to
function check_bounds(xl, x, xu)
    for (l, x, u) in zip(xl, x, xu)
        l ≤ x ≤ u || return false
    end
    return true
end

Perhaps more important is that zip doesn't fail if the lengths of xl, x, and xu don't all match; it uses the shortest length.  The all version throws DimensionMismatch in such a case.
julia> collect(zip(ones(4), zeros(3)))
3-element Vector{Tuple{Float64, Float64}}:
 (1.0, 0.0)
 (1.0, 0.0)
 (1.0, 0.0)

julia> all(zeros(4) .≤ rand(4) .≤ ones(3))
ERROR: DimensionMismatch: arrays could not be broadcast to a common size; got a dimension with lengths 4 and 3

any(xl .≤ x .≤ xu)

I much prefer this style.

You mean:
all(xl .≤ x .≤ xu)

not any(xl .≤ x .≤ xu).
You have to realize that:

all(xl .≤ x .≤ xu) implies creating, at least, one temporary array while check_bounds avoids that.
check_bounds , which is supposed to return true, avoids branching to allow for loop-vectorization. This is not the case of all, any, etc.
check_bounds can be modified to check the sizes.

Nevertheless, such optimizations are irrelevant for test code and I have modified check_bounds as suggested in commit 2c756f3203ee5870725d5aad0002a4ce121be6da. Thanks for the suggestion.


Fixes warnings from flake8 on top level *.py files

This resolves two warnings from flake8 on the top level *.py files.

What this really is, is showing you how the collaboration work flow through pull requests looks like on Github. Read up about fast-forward merges and how to merge this changeset back into master on the command line (don't just simply click the "merge" button :P)

:+1: :)


PolygonShape Creates Invalid Convex Hull From Vertices

The code refactoring done in PR #7 to the gift wrapping algorithm for creating a convex hull is incorrect. The previous code properly implemented the gift wrapping algorithm and correctly generated a valid convex hull. The refactored code does not properly implement the gift wrapping algorithm. To demonstrate the error of the refactored code, consider this set of vertices to define a polygon:
var vertices = [
    Vector2(-10, 20),
    Vector2(-10, 0),
    Vector2(0, -30),
    Vector2(10, 0),
    Vector2(10, 10),
  ];

final shape = PolygonShape()..set(vertices);

The  correct convex hull output from this set of vertices from the gift wrapping algorithm is (and was from the old code):
    Vector2(10, 0),
    Vector2(10, 10),
    Vector2(-10, 20),
    Vector2(-10, 0),
    Vector2(0, -30),

But the output from the new refactored code is an invalid polygon that crosses over itself:
    Vector2(10, 0),
    Vector2(-10, 0),
    Vector2(0, -30),
    Vector2(10, 10),
    Vector2(-10, 20),

The incorrect refactored code is in forge2d-0.7.2 > lib > src > collision > shapes > polygon_shape.dart beginning at line 90:
    final hull = <Vector2>[rightMostPoint];
    for (final point1 in points) {
      var currentPoint = hull.last;
      for (final point2 in points) {
        if (currentPoint == hull.last) {
          currentPoint = point2;
          continue;
        }

        final r = currentPoint.clone()..sub(point1);
        final v = point2.clone()..sub(point1);
        final c = r.cross(v);
        if (c < 0.0) {
          currentPoint = point2;
        }

        // Collinearity check
        if (c == 0.0 && v.length2 > r.length2) {
          currentPoint = point2;
        }
      }

      if (!hull.contains(currentPoint)) {
        hull.add(currentPoint);
      }
    }

Not only is this code incorrect, but it also changes the complexity of the gift wrapping algorithm from O(nh) where n is the number of vertices and h is the number of vertices on the hull, to O(nn).
I'd like to offer this fix for consideration as a correct implementation of the gift wrapping algorithm:
    final hull = <Vector2>[rightMostPoint];
    var pointOnHull = rightMostPoint;
    do {
      // Set first point in the set as the initial candidate for the
      // next point on the convex hull.
      var endPoint = points[0];

      // Test the candidate point against all points in the set to find
      // the next convex hull point.
      for (final point in points) {
        // If the candidate point is current last point on the convex
        // hull update the candidate point to the current point and continue
        // checking against the remaining points.
        if (endPoint == pointOnHull) {
          endPoint = point;
          continue;
        }

        // Use the cross product of the vectors from the current convex hull
        // point to the candidate point and the current test point to see if
        // the test point is changes the winding to CW. Update the candidate
        // point when the winding changes.
        final r = endPoint.clone()..sub(pointOnHull);
        final v = point.clone()..sub(pointOnHull);
        final c = r.cross(v);
        if (c < 0.0) {
          endPoint = point;
        }

        // Collinearity check
        if (c == 0.0 && v.length2 > r.length2) {
          endPoint = point;
        }
      }

      // Set the end point candidate as the new current convex hull point.
      pointOnHull = endPoint;
      if (!hull.contains(pointOnHull)) {
        hull.add(pointOnHull);
      }
    } while (pointOnHull != hull.first);

Interesting, please submit this as a PR and it'll be easier to evaluate, at first glance it definitely looks like you are correct.
Are there only some hulls that get a bad representation? Since the current examples are still working.

Hi @spydon, I did as you requested and have submitted PR #25 with my proposed fix for the gift wrapping algorithm.

@spydon I have verified this bug has been fixed and can be closed.

Thanks!


Hashable should take type index into account

Hashing a variant should take the type index / .which() into account in addition to the underlying hash

https://github.com/mapbox/variant/blob/02bd1ac4c07e6db9fe0f01267853e43b41637b74/include/mapbox/variant.hpp#L1002-L1011
https://github.com/mapbox/variant/blob/02bd1ac4c07e6db9fe0f01267853e43b41637b74/include/mapbox/variant.hpp#L536-L544

Why? Because of the edge case where the underlying hash is the same but the type index is not.

Why is it the problem? There are hash collisions anyways. After matching the hashes of two values any algorithm which uses hashes should to compare for equality. Variants with different active alternatives are not equal. Runtime overhead imposed by hash-combining of the value's hash and of the the (excessive) hash of its index is permanent otherwise. It is hardly desirable.

I sure the probability of hash(A) == hash(B) is the same as probability of combine(hash(A), hash(index(A))) == combine(hash(B), hash(index(B))). Say decltype(A) == int and decltype(B) == char, hash is identity for integral types and hash combiner is xor. Then for variant< A, B >'s comparison variant{A{2}} vs variant{B{1}}: 1 ^ 2 == 2 ^ 1.

I open this ticket mainly because I read the updates on
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0088r3.html

hash<variant> can now return different values than hash (and it should - presumably it should take the index() into account).

and
http://en.cppreference.com/w/cpp/utility/variant/hash

Unlike std::hashstd::optional, hash of a variant does not typically equal the hash of the contained value; this makes it possible to distinguish std::variant<int, int> holding the same value as different alternatives.

the Boost.Variant impl. does the same, too.

Anyways hash combining every time for any alternative type is permanent runtime overhead. But std::variant< T, T > is hardly useful. Why there should be different hash values for first and second occurence of a T in the alternative type list? What is the rationale behind this?


Typo in TuningsImpl.h

lib/tuning-library/include/TuningsImpl.h
line 148 change
12 note even temprament
to
12 note even temperament

Moved this issue to tuning-library


ModuleNotFoundError: No module named 'FedML'

After running this: !python experiments/centralized/moleculenet/molecule_classification_multilabel.py
Getting this Error Message:
Traceback (most recent call last):
File "experiments/centralized/moleculenet/molecule_classification_multilabel.py", line 11, in
from data_preprocessing.molecule.data_loader import get_dataloader, get_data
File "/content/drive/My Drive/Colab Notebooks/FedGraphNN/data_preprocessing/molecule/data_loader.py", line 12, in
from FedML.fedml_core.non_iid_partition.noniid_partition import partition_class_samples_with_dirichlet_distribution
ModuleNotFoundError: No module named 'FedML'

From the error msg, I assume you are referring to some other repo (rather than FedProx)?


fix: picking settingsConfig from ApiEditorContext instead of props

Description

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!IMPORTANT]
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/12046538850
Commit: 91523c74ae50b5294e3fe66cc131b7c04f50b62e
Workflow: PR Automation test suite
Tags: @tag.All
Spec: ``
Wed, 27 Nov 2024 08:34:35 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

New Features

Enhanced the CommonEditorForm component to accept settingsConfig directly from props for improved data management.
Introduced logging mechanisms in the CommonEditorForm and ActionSettings components to aid debugging during tests.

Refactor

Updated the way settingsConfig is accessed, removing it from context in favor of prop-based sourcing.
Modified the test specifications in the Cypress limited tests to include new entries for "Abort Action" and "API MultiPart."

/ci-test-limit

/ci-test-limit

/ci-test-limit

/ci-test-limit-count run_count=5 runId=12047325773

/ci-test-limit-count run_count=5 runId=12046542345

/ci-test-limit-count run_count=5 runId=12046542345

/ci-test-limit

/ci-test-limit-count run_count=10 runId=12050373379

/ci-test-limit-count run_count=10

/ci-test-limit-count run_count=10

/ci-test-limit-count run_count=10

/ci-test-limit-count run_count=10

/ci-test-limit-count run_count=10


Is possible run casdoor as a standard oauth 2.0 server?

Is possible run casdoor as a standard oauth 2.0 server?

@LeonDevLifeLog Casdoor has fully supported OAuth 2.0 and OIDC now. The server side is this repo. The client SDKs can be found at: https://github.com/casdoor .
What system/clients do you need Casdoor to talk to? What scenario do you use Casdoor in? Maybe we can help you do a pre-check.

I saw lots of casdoor sdk.if some other program languages don't have casdoor sdk,is standard oauth client library compatible with casdoor server?

i want use it as a standard Oauth2.0 server. and compatible with other Oauth2.0 client library.

@LeonDevLifeLog which "standard oauth client library" will you use? better with a GitHub link. We may help test with it for you.

I saw lots of casdoor sdk.if some other program languages don't have casdoor sdk,is standard oauth client library compatible with casdoor server?

@LeonDevLifeLog what language do you use? if we already provide the SDK for your language, we recommend using our client SDKs, as it may provide additional functionalities than the OAuth standard. But using a standard OAuth client is also fully supported.

I am in research stage,i want to know the compatibility. i will open an issue if some problem occur when i using it.


Make ApplicantScreenNotification sticky to the header

Release Type: Non-breaking changes
Fixes https://x-team-internal.atlassian.net/browse/XP-3532
Description

ApplicantScreen's HeaderBar is sticky to the top
The Notification is sticky under the HeaderBar
The Notification shows up for 5 seconds, and then disappear
Extra: the with and side paddings for Jobs Dashboard components got fixed

Checklist

[x] set yourself as an assignee
[x] set appropriate labels for a PR (In Review or In Progress depending on its status)
[x] move respective JIRA issue to the PEER REVIEW column
[x] make sure your code lints (npm run lint)
[x] Flow typechecks passed (npm run flow)
[x] component's documentation (.stories.js file) is changed or added accordingly to reflect any new or updated use cases and/or debug cases
[x] once finished with all the changes, you run npm run build command and committed changed files to the branch
[x] manually tested the app by running it in several different browsers (Firefox, Chrome, Opera, Safari, MS IE/Edge, etc.) and checked nothing is broken and operates as expected!

Steps to Test or Reproduce
Storybook

Check the ApplicantScreenNotification stories: http://localhost:9001/?path=/story/ui-components-applicantscreennotification--basic-usage
Check a story with the full composition of a Job Page: http://localhost:9001/?path=/story/screens-and-layouts-jobspagelayout-debug--job-details-page-applied

XP-Registration

Make sure to copy XP-UI bundle files into XP-Reg site
Go to Jobs Dashboard and click on any job
In a Job page (e.g. http://localhost:8001/applicant/649a71060eed2beea2e5559858912ca9/jobs/133 - use valid applicant token and valid job ID) hit to "Apply for this position"
Observe the Successful notification popping up and then dismissing after 5 seconds
You can Withdraw the job application and apply again to see the notification appear again
You can also click in the right-side X icon to hide the notification
When reloading the page when applied to the job, the notification should not be seen

Impacted Areas in Application

src/components/ui/ApplicantScreen.js (adjusted space for sticky HeaderBar)
src/components/ui/ApplicantScreenNotification.js (applied show/hide animation, added sticky position, added hide effect after 5 seconds, and included hide button)
src/components/ui/HeaderBar.js (made sticky to the top and adjusted responsive width and side paddings)
src/components/ui/JobsPageLayout.js (adjusted responsive width and side paddings)
src/components/ui/JobsPageLayout.stories.js (updated showcase to include notification)
src/components/ui/WelcomeHero.js (adjusted responsive width and side paddings)

Screenshots
See it in effect at XP-Registration:

Check the layout width and side spacings fixes:

Travis is failing due to the errors I can't replicate locally. Complaining about missing snazzy dependency which is available in package.json file 🤔

I don't understand why Travis is failing... 🤔

I don't understand why Travis is failing... 🤔

Me neither. I sg=hared the reason above though https://github.com/x-team/xp-ui/pull/502#issuecomment-594590667 But makes no sense. If it fails on develop branch as well, we'll need to remove snazyy formatting option from  package.json file to get it resolved.


docs: Make word 'Client' inline with other references

Signed-off-by: Rishabh Bohra<EMAIL_ADDRESS>

Hi @celestehorgan @sftim :wave:
Can you have a look at this minor PR?


Variable substitution in rewrite rules

Title: Variable substitution in rewrite rules
Description:
Today it's possible to use regexp to match parts of the incoming path and re-write using these matches.
There are also situations where you want to include other parts of the request into the re-write rule, e.g. the value of a header or a metadata that has been picked-up.
A concrete example, is when proxying to a backend service which has a rest-based API which includes a customer id as part of the path, like /rest-resource/customer-id/whatever, but the customer-id might be part of an Authorization header or JWT token on the incoming request.
Ideally we would be able to use the same variables as used in the access-log format in all the re-write rules, prefix_rewrite, regexp_rewrite, redirect, ...

That is probably possible. Though Lua scripting adds computing overhead and latency and should only be needed for non standard things IMO. I would definitely not put this feature in that bucket, but it seems not to get immediate traction so maybe my use case is the outlier, wanting to rewrite the path to include a user is picked up from the authenticated user, or actually a substring of the username


merging  changes

hey zhewen, I've tried to merge mine and your work. The reason I wanted to use the hw key instead of the Node class on it's own being a node in the graph, is because I was having difficulty with parsing fpgaconvnet nodes, as there were some duplicate nodes, and networkx DiGraph couldn't handle it. So instead I would like to use unique strings for the nodes in the graph, and have the hardware as an attribute of the node.
Also, I moved your validate function into the Node and Optimiser classes, so we can use them in other backends, rather than duplicating them.
Finally, I think you should move the parser and FinnNodeWrapper into the main repo, and then call those classes and functions from it. but that's up to you

Hi Alex, I have moved the parser and the wrapper to the same repo. Can you merge these changes at that repo?


This integration does not work

In step 11 of the wiki - Connecting to Home Assistant | Seeed Studio Wiki 2, I can’t get Groove Vision AI V2 to be found by Homeassistant. Looking at the EMQX Logs, I notice that the board connects with MQTT. But in step by step, I can’t make the connection. Timeout error occurs.
The system does not automatically find my device, and manual configuration is required. In this case, when filling out the SETUP MQTT SERVER form with my server information, I cannot connect through setup.
MQTT connection timeout
EMQX - Connection Info
|Status|Connected|
<EMAIL_ADDRESS>|Client ID| grove_vision_ai_v2
|Username| myuser
|Protocol| MQTT v3.1.1|
|IP Address| myGrooveIpAddress:57773|
|Keepalive| 15|
|Clean Session|true|
|Bridge|false|
|Connected At|2024-05-11 13:22:39|
Session Info
|Session Expiry Interval|0|
|Created At|2024-05-11 13:22:39|
|Heap Size|2586 bytes|
|Subscriptions|1/infinity|
|Message Queue|0/1000View Message|
|Inflight|0/32View Message|
|QoS 2 Message Receive Queue|0/100|
Used the mqtt2uart example and get wifi and mqtt connected. EQMX detects the board, but the integration does not.
Also when SenseCraft extension try to integrate my Groove Vision AI V2, the name header start with grove_vision_ai_we2_uniqueid and not grove_vision_ai_v2_uniqueid.

Already solved，firmware has updated the mqtt id to grove_vision_ai_v2

v1.1.3 has fixed this bug


Plots.jl+pyplot() interacts badly with PNGFiles.jl

using Plots
using FileIO
pyplot() # remove this line and the example works fine
FileIO.load("DSC_999.png")

gives me
Errors encountered while loading "C:\\Users\\jaakkor2\\Work\\Julia\\DSC_999.png".
All errors:
===========================================
ReadOnlyMemoryError()
===========================================
ArgumentError: Package ImageMagick not found in current path:
- Run `import Pkg; Pkg.add("ImageMagick")` to install the ImageMagick package.

===========================================

Fatal error:
ERROR: ReadOnlyMemoryError()
Stacktrace:
 [1] handle_error(::ReadOnlyMemoryError, ::File{DataFormat{:PNG}}) at C:\Users\jaakkor2\.julia\packages\FileIO\wN5rD\src\error_handling.jl:82
 [2] handle_exceptions(::Array{Any,1}, ::String) at C:\Users\jaakkor2\.julia\packages\FileIO\wN5rD\src\error_handling.jl:77
 [3] load(::FileIO.Formatted; options::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}) at C:\Users\jaakkor2\.julia\packages\FileIO\wN5rD\src\loadsave.jl:207
 [4] load at C:\Users\jaakkor2\.julia\packages\FileIO\wN5rD\src\loadsave.jl:184 [inlined]
 [5] #load#14 at C:\Users\jaakkor2\.julia\packages\FileIO\wN5rD\src\loadsave.jl:133 [inlined]
 [6] load(::String) at C:\Users\jaakkor2\.julia\packages\FileIO\wN5rD\src\loadsave.jl:133
 [7] top-level scope at REPL[4]:1

I do not have ImageMagick.jl installed, but I do have
. Plots.jl v1.6.6
. FileIO v1.4.3
. ImageIO.jl v0.3.0
. PNGFiles v0.3.1
Without the call pyplot() the example works fine.
In issue https://github.com/JuliaIO/FileIO.jl/issues/275 it was guided to open an issue here.

Hmm, I can't reproduce the problem using a test image from Wikimedia, having the same versions of mentioned libs:
julia> using Plots, FileIO
julia> pyplot()
Plots.PyPlotBackend()

julia> FileIO.load(download("https://upload.wikimedia.org/wikipedia/commons/6/6a/PNG_Test.png"))
3920×3120 Array{RGB{N0f8},2} with eltype RGB{FixedPointNumbers.Normed{UInt8,8}}:
 RGB{N0f8}(0.0,0.0,0.0)  RGB{N0f8}(0.0,0.0,0.0)  …  RGB{N0f8}(0.09,0.443,0.906)
 RGB{N0f8}(0.0,0.0,0.0)  RGB{N0f8}(0.0,0.0,0.0)     RGB{N0f8}(0.725,0.796,1.0)
 RGB{N0f8}(0.0,0.0,0.0)  RGB{N0f8}(0.0,0.0,0.0)     RGB{N0f8}(0.725,0.796,1.0)
 RGB{N0f8}(0.0,0.0,0.0)  RGB{N0f8}(0.0,0.0,0.0)     RGB{N0f8}(0.725,0.796,1.0)
 RGB{N0f8}(0.0,0.0,0.0)  RGB{N0f8}(0.0,0.0,0.0)     RGB{N0f8}(0.725,0.796,1.0)

What version of julia are you using?
julia> versioninfo()
Julia Version 1.5.0
Commit 96786e22cc (2020-08-01 23:44 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-9.0.1 (ORCJIT, skylake)
Environment:
  JULIA_PATH = /home/drvi/src/julia-1.5.0/bin
  JULIA_VERSION = 1.5.0

I too cannot reproduce this issue on Linux.  The issue arises on Windows
julia> versioninfo()
Julia Version 1.5.2
Commit 539f3ce943 (2020-09-23 23:17 UTC)
Platform Info:
  OS: Windows (x86_64-w64-mingw32)
  CPU: Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-9.0.1 (ORCJIT, skylake)
Environment:
  JULIA_EDITOR = "C:\Program Files\Sublime Text 3\sublime_text.exe"
  JULIA_NUM_THREADS = 4

Could you try directly using the PNGFiles loader? It should give a nicer stacktrace.
using PNGFiles
PNGFiles.load("path")

This works directly
julia> using PNGFiles
julia> PNGFiles.load("DSC_999.png")
1024×768 Array{Gray{N0f8},2} with eltype ColorTypes.Gray{FixedPointNumbers.Normed{UInt8,8}}:
 Gray{N0f8}(0.471)  Gray{N0f8}(0.698)  Gray{N0f8}(0.059)  …  Gray{N0f8}(0.714)  Gray{N0f8}(0.435)  Gray{N0f8}(0.565)
 Gray{N0f8}(0.612)  Gray{N0f8}(0.792)  Gray{N0f8}(0.118)     Gray{N0f8}(0.392)  Gray{N0f8}(0.8)    Gray{N0f8}(0.78)
...

and this as well
julia> using Plots
julia> using PNGFiles
julia> pyplot()
Plots.PyPlotBackend()
julia> PNGFiles.load("DSC_999.png")
1024×768 Array{Gray{N0f8},2} with eltype Gray{FixedPointNumbers.Normed{UInt8,8}}:
 Gray{N0f8}(0.471)  Gray{N0f8}(0.698)  Gray{N0f8}(0.059)  …  Gray{N0f8}(0.714)  Gray{N0f8}(0.435)  Gray{N0f8}(0.565)
 Gray{N0f8}(0.612)  Gray{N0f8}(0.792)  Gray{N0f8}(0.118)     Gray{N0f8}(0.392)  Gray{N0f8}(0.8)    Gray{N0f8}(0.78)
 Gray{N0f8}(0.0)    Gray{N0f8}(0.667)  Gray{N0f8}(0.71)      Gray{N0f8}(0.004)  Gray{N0f8}(0.125)  Gray{N0f8}(0.263)
 ...

I initially thought somehow FileIO gets confused, and I opened an issue there originally.

How about ImageIO?
using ImageIO
using FileIO: File, DataFormat
ImageIO.load(File{DataFormat{:PNG}}("DSC_999.png"))

This works
julia> using ImageIO

julia> using FileIO: File, DataFormat

julia> ImageIO.load(File{DataFormat{:PNG}}("DSC_999.png"))
1024×768 Array{Gray{N0f8},2} with eltype ColorTypes.Gray{FixedPointNumbers.Normed{UInt8,8}}:
 Gray{N0f8}(0.471)  Gray{N0f8}(0.698)  Gray{N0f8}(0.059)  …  Gray{N0f8}(0.714)  Gray{N0f8}(0.435)  Gray{N0f8}(0.565)
 Gray{N0f8}(0.612)  Gray{N0f8}(0.792)  Gray{N0f8}(0.118)     Gray{N0f8}(0.392)  Gray{N0f8}(0.8)    Gray{N0f8}(0.78)
..

This does not work
julia> using Plots

julia> using ImageIO

julia> using FileIO: File, DataFormat

julia> pyplot()
Plots.PyPlotBackend()

julia> ImageIO.load(File{DataFormat{:PNG}}("DSC_999.png"))
ERROR: ReadOnlyMemoryError()
Stacktrace:
 [1] png_read_info at C:\Users\jaakkor2\.julia\packages\PNGFiles\Sgsmw\gen\libpng\libpng_api.jl:96 [inlined]
 [2] _load(::Ptr{Nothing}, ::Ptr{Nothing}; gamma::Nothing, expand_paletted::Bool) at C:\Users\jaakkor2\.julia\packages\PNGFiles\Sgsmw\src\io.jl:59
 [3] load(::String; gamma::Nothing, expand_paletted::Bool) at C:\Users\jaakkor2\.julia\packages\PNGFiles\Sgsmw\src\io.jl:28
 [4] load(::String) at C:\Users\jaakkor2\.julia\packages\PNGFiles\Sgsmw\src\io.jl:23
 [5] #invokelatest#1 at .\essentials.jl:710 [inlined]
 [6] invokelatest(::Any, ::Any) at .\essentials.jl:709
 [7] load(::File{DataFormat{:PNG}}; kwargs::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}) at C:\Users\jaakkor2\.julia\packages\ImageIO\DOpZl\src\ImageIO.jl:13
 [8] load(::File{DataFormat{:PNG}}) at C:\Users\jaakkor2\.julia\packages\ImageIO\DOpZl\src\ImageIO.jl:9
 [9] top-level scope at REPL[6]:1

ImageIO lazily loads PNGFiles, so my guess is that there's some lib clash between Plots/PyPlot & PNGFiles, and the load ordering matters on windows.. or something like that.
Does the same happen without loading the PyPlot backend?

Thinking about load order, what about these:
using Plots
using ImageIO
using FileIO: File, DataFormat
using PNGFiles
pyplot()
ImageIO.load(File{DataFormat{:PNG}}("DSC_999.png"))

using PNGFiles
using Plots
using ImageIO
using FileIO: File, DataFormat
pyplot()
ImageIO.load(File{DataFormat{:PNG}}("DSC_999.png"))

Ok, I can reproduce this in Windows with julia 1.5.2
Loading PNGFiles before switching to pyplot() "fixes" it.
julia> using Plots, FileIO

julia> using PNGFiles

julia> pyplot()
Plots.PyPlotBackend()

julia> FileIO.load(download("https://upload.wikimedia.org/wikipedia/commons/6/6a/PNG_Test.png"))
3920×3120 Array{RGB{N0f8},2} with eltype RGB{FixedPointNumbers.Normed{UInt8,8}}:

Both matplotlib and PNGFiles use the same version of libpnb, 1.6.37, but perhaps the python version has some other build settings that messes up our library usage
https://github.com/JuliaPackaging/Yggdrasil/blob/b0f35b382d770a7fa672b850623915aade5c24c2/L/libpng/build_tarballs.jl#L6

Ok.. so after some manual testing, it seems that julia doesn't like using the libpng16 that PyPlots loads (maybe because it was compiled with msvc), and in <1.6 julia, the jll's load the dlls and provide just the dll name, so julia is grabbing the one that's loaded first, which happens to be the pyplot libpng16.
So before julia 1.6, the fix is to load PNGFiles before PyPlot.
In 1.6 jll's will link to libs at specific paths using the new jllwrappers mechanics, so this should be fixed on 1.6
Thanks to @giordano for the help debugging this

Thats some impressive detective work, thanks @ianshmean @giordano !

I believe there's nothing that needs to be fixed in this package so I'll just close this one.


e2pg: provide command flag for listing available integrations

./e2pg -list-integrations
erc1155
erc721
zora
seaport

No longer needed with declarative integrations and the new dashboard UI.


Train always goes maxspeed

BkCommonLib version: 1.14.4-v1
TrainCarts version: 1.14.4-v1
Spigot version: 1.14.4

Problem or bug:
Train always goes the max speed and cannot slow it down unless changing the max speed. Can't make a drop with a gradual gain in speed. Also always has high energy in /train info
Expected behaviour:
Have the train stay the same speed even if max speed is increased to over its current.
Steps to reproduce:

Spawn in train
[train]
spawn
mmm
Push train into station
[train]
station
3
continue
set maxspeed to 0.1 (to recreate a chainlift)
[train]
property
maxspeed
0.1
Raise maxspeed to let train gradually gain speed downhill
[!train] (does not work without the '!')
property
maxspeed
1

Stations always launch the train at high energy, either reduce the energy launched by stations in the config or manually launch the trains to a lower energy state.

Works perfectly now, thanks.


Make FileSystem dependency explicit througout (more).

This is part 14 of a broken down version of the #140101 refactor.
This is an extension of part 8 (#146008), which had omitted removing the filesystem dependency in the SkiaGoldClient class.
This only makes one dependency explicit. Further PRs will do the same for other dependencies, until these APIs have no hidden dependencies.
This particular change attempts to be minimal. I made no effort to keep the order of parameters reasonable here. I have a TODO to do a refactor sweep later that does nothing but reorder arguments/parameters/fields to be consistent.

test-exempt: code refactor with no semantic change


Decouple node package specs from pageflow.backgroundMedia

Pass backgroundMedia as part of options in boot instead.

Coverage remained the same at 99.205% when pulling 96d26e73e310cc37f25fec36258382a0d15ebfa7 on tf:node-package-spec-fixes into 9c18436a228a33e330f2fb7a2c3ecc3ed6543742 on codevise:master.


Investigate how to send Envoy access logs to external data store like a SEIM

Please describe the Improvement and/or Feature Request

Scope (please mark with X where applicable)

New Functionality          [X]
Install                    [ ]
SMI Traffic Access Policy  [ ]
SMI Traffic Specs Policy   [ ]
SMI Traffic Split Policy   [ ]
Permissive Traffic Policy  [ ]
Ingress                    [ ]
Egress                     [ ]
Envoy Control Plane        [X]
CLI Tool                   [ ]
Metrics                    [ ]
Certificate Management     [ ]
Sidecar Injection          [ ]
Logging                    [ ]
Debugging                  [ ]
Tests                      [ ]
CI System                  [ ]
Demo                       [ ]
Project Release            [ ]

Possible use cases
Currently Envoy access logs can be viewed on a per pod basis using the command "kubectl logs  -n  -c envoy [options]". The more useful need for collecting Envoy access logs is to have to ability to correlate traffic events and have long-term availability to the logs for possible forensic analysis.
User Story - As a SecOps user, I would like the ability to configure OSM to send Envoy access logs in the mesh to an external data store (SEIM), so I can replay traffic events in needed for further analysis.

We should use this chance to leverage OpenTelemetry support:  https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/access_loggers/open_telemetry/v3/logs_service.proto

Previously, we used FluentBit for this. You can run it as a sidecar to stream logs to an external data store.
The FluentBit configuration can be tweaked to parse and forward access logs.

Yeah, the advantage of the OTel approach is that it's not specific to fluentbit and it occurs directly in the Envoy proxy, so you prevent the Yet-Another-Sidecar problem

Yeah, the advantage of the OTel approach is that it's not specific to fluentbit and it occurs directly in the Envoy proxy, so you prevent the Yet-Another-Sidecar problem

That does seem like a more integrated solution with Envoy that would be preferable.

I'm in agreement with using OTel to make this happen.


Improve package equality check and repr

We need to be a bit more stricter with how we compare packages as prior to this we would check two packages,  foo-1.0.0 with source_reference=x and  foo-1.0.0 with source_reference=y as the same. Which can lead to some unexpected issues at poetry runtime and incorrect validation in poetry's test suites as well.

@sdispater any concerns on this one?


BUGFIX incorrect chrome detection

Current coverage is 66.66% (diff: 0.00%)

Merging #111 into master will not change coverage

@@             master       #111   diff @@
==========================================
  Files             4          4
  Lines           240        240
  Methods          24         24
  Messages          0          0
  Branches          0          0
==========================================
  Hits            160        160
  Misses           80         80
  Partials          0          0

Powered by Codecov. Last update 9e9b74d...01625ab


debug: ANT_HOME in windows-2019 GH action

done test and finalize solution in https://github.com/adoptium/temurin-build/pull/2954


Data Pipeline Template Link pulls a 404

LInk: https://github.com/os-climate/data-pipeline-template pulls a 404 and is located on this page>https://github.com/os-climate/os_c_data_commons/blob/main/os-c-data-commons-developer-guide.md

@mbogoevici do we have a new theory as to what a common pipeline template starting point should look like for the Data Mesh?


QUIC: Acknowledge the retransmitted INITIAL frame

The retransmitted initial frame is not acknowledged when handshake is not complete.

This may be related to #4905 and things may changed, because we currently send only 3 packets on a non-validated path and the limitation was replaced with a new limitation based on transferred data size.

Closing as we are dropping our own QUIC implementation.


Sendmail security enhancement from Symphony 2.6 should be included in 2.7

15dc8eb5311db0e1e5b83301f58954401471acdf should be included in 2.7.x as well.
Unfortunately the branches seem to have moved away from each other. @nitriques: Are you planning a rebase? (In this case there is no need to post issues like this.)

Are you planning a rebase?

Yup, see #2643

All of 2.6.x will be included in 2.7.0


meta/sql: fix doSyncDirStat does not update existed dir stats

close #3704
Currently, the doSyncDirStat of SQL engine won't update existed dir stats, while other engines will.

@Hexilee please add a unit test to cover this case.

@Hexilee please add a unit test to cover this case.

It may be difficult to cover this case in unit tests because I have no good idea to stop the bg process doFlushDirStat, we can only interrupt it by obtain m.dirStatsLock, which rely on type assertion in base_test.
@zhoucheng361 will cover this case in e2e tests.


Command line execution to add this check to a DevOps pipeline

Is your feature request related to a problem? Please describe.
No
Describe the desired outcome
If possible, it would bring a great impact if we could run this check on a CI/CD pipeline for a Windows/Web application, if possible.
Describe alternatives you've considered
So far, I don't see any alternatives for achieving this during a DevOps pipeline.
Additional context
Adding this inclusive concern to the DevOps story would bring such great impact to everyone in the world. I'd be happy to contribute if you need a hand.

Hi @ricardoserradas
Thanks for your interest on Accessibility Insights for Web.
We use axe-core as our scan engine to find accessibility issues on web pages. You can use axe-cli in order to run axe from the command line.


Windows Compatibility

Feature request
Tried to get this working on windows but ultimately ran into dead ends running the make files. I'm guessing windows just isn't supported yet. If anyone has gotten this to run on windows, please let me know.
Motivation
Possible lack of Windows compatibility
Your contribution
No

Hey @TheLocalLab, correct, LoRAX only supports Linux today. Though I believe it may be possible to run on Windows using WSL, but I am not familiar enough with it to say for certain.


code gen function usable across exercises

When I wrote the template-based data converter for gigasecond, I realized that much of it was not specific to gigasecond and could be reused.  Custom-set turned out to be able to use most of this code without change.  This PR collects the common code into a package that can be used across exercises.
The other exercise with json test data currently is clock.  It was the first generator I wrote and doesn't use templates.  If this PR is accepted, a good test of it will be to replace the clock generation code with a template and a call to this new package.
None of this affects what the solver sees btw.  It's all for the xgo developer.

This looks great!


ISPN-13922 Fix SslTest on Windows

https://issues.redhat.com/browse/ISPN-13922

No, those were fixed in https://github.com/infinispan/infinispan/pull/10186

I see! Thanks @tristantarrant


Adds support for subdirectories when reading modules

Should fix #663 #540. Needs testing but wanted some guidance on what the test cases should be and where they should go to suit the project. All existing tests are green.

Nice! I would say look at the node-tests. A single test to check that a nested module was loaded would be a great start

@jrhe We're working on tidying up old issues / PRs.  Do you think you'll be able to come back to this or should we close this PR for now?

Can you close it for now? I don't think I'll have time any time soon.
On 22 September 2016 at 06:27, David Baker<EMAIL_ADDRESS>wrote:

@jrhe https://github.com/jrhe We're working on tidying up old issues /
PRs. Do you think you'll be able to come back to this or should we close
this PR for now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/samselikoff/ember-cli-mirage/pull/780#issuecomment-248815884,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD2g-bYbHTerlu0bcMqCir0B_i1UQiG3ks5qshGkgaJpZM4I4qCx
.

Will do 👍


chore: bdd-nh-1586825846 to 0.0.1

chore: Promote bdd-nh-1586825846 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Make sure container fails if python initiated build fails

This fixes #204

Works as intended as shown here: https://dev.azure.com/mbrobbel/fletcher/_build/results?buildId=1030&view=logs&j=7c46b5d0-54f2-5dcd-1ac8-525bb0d96798


Double click event triggers only once

Hi. I noticed that the double click event seems to only ever be triggered once.
Here's a minimal example to reproduce: you should see "double_click" printed to the console the first time you double click but not for any subsequent double clicks.
from wgpu.gui.auto import WgpuCanvas, run
import pygfx as gfx

canvas = WgpuCanvas()
renderer = gfx.renderers.WgpuRenderer(canvas)
scene = gfx.Scene()
camera = gfx.OrthographicCamera()
controller = gfx.PanZoomController(camera, register_events=renderer)

def animate():
    renderer.render(scene, camera)
    canvas.request_draw()

def trigger(event):
    print(event.type)

if __name__ == "__main__":
    renderer.add_event_handler(trigger, "double_click")
    canvas.request_draw(animate)
    run()

Tried with both pygfx 0.2.0 and current main.

This issue seems to be caused by the misalignment of the time_stamp unit when converting wgpu-py events to pygfx events.
The time_stamp unit for wgpu-py events is in seconds, while for pygfx, it's in milliseconds.
https://github.com/pygfx/pygfx/blob/87decd72d9bd3eec2c73f0fa709cd5cbe4b41093/pygfx/renderers/wgpu/engine/renderer.py#L812-L815
Adding this code before this should solve the problem:
event["time_stamp"] = event["time_stamp"] * 1000
Or just:
del event["time_stamp"]

Wow, I had not realized the pygfx timestamp is in ms ... I'd be in favor to change that to seconds. This is Python, not Qt or JS.


fix: clang-tidy using private macos headers

- What I did

Corrected any headers starting with "sys/"
Disabled the aggressive clang-tidy rule

- How I did it
- How to verify it
- Description for the changelog
fix: clang-tidy using private macos headers

I should not have merged that... mobile conceals the tests... I need to restore headers for waitpid


new 'hashicorp/aws' version (> v5.0.0) cause the incompatible issue for version that defined inside [../sources/aft-customizations-common/templates/customizations_pipeline/versions.tf]

Bug Description
'hashicorp/aws' v5.0.0 was released at the end of May [https://github.com/hashicorp/terraform-provider-aws/releases], which cause the incompatible issue for version that defined inside [../sources/aft-customizations-common/templates/customizations_pipeline/versions.tf]
e.g. https://github.com/aws-ia/terraform-aws-control_tower_account_factory/blob/1.4.2/sources/aft-customizations-common/templates/customizations_pipeline/versions.tf
terraform {
  required_version = ">= 0.15.1"

  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = ">= 4.9.0"
    }
  }
}

So when 'terraform init', it will trying to Install the newest 'hashicorp/aws' version, log from the codebuild log:
[Container] 2023/06/06 16:29:50 Running command terraform init

Initializing the backend...

Successfully configured the backend "s3"! Terraform will automatically
use this backend unless the backend configuration changes.

Initializing provider plugins...
- Finding hashicorp/aws versions matching ">= 4.9.0"...
- Installing hashicorp/aws v5.1.0...
- Installed hashicorp/aws v5.1.0 (signed by HashiCorp)

Which cause the below error whilen doing 'terraform apply'
[Container] 2023/06/06 16:29:54 Running command terraform apply -var="account_id=$VENDED_ACCOUNT_ID" --auto-approve
╷
│ Error: Unsupported argument
│
│   on aft-providers.tf line 7, in provider "aws":
│    7:   shared_credentials_file = "~/.aws/credentials"
│
│ An argument named "shared_credentials_file" is not expected here. Did you
│ mean "shared_credentials_files"?

To temperary fix the issue, we change the 'versions.tf' file after in our local repo which is from the [../sources/aft-customizations-common/templates/customizations_pipeline/versions.tf] as below (e.g. https://github.com/aws-ia/terraform-aws-control_tower_account_factory/blob/1.4.2/sources/aft-customizations-common/templates/customizations_pipeline/versions.tf)
terraform {
  required_version = ">= 0.15.1"

  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = ">= 4.9.0 <5.0.0"     <<<<<----- HERE
    }
  }
}

Question

Can we confirm that this is a potential bug this will be take care in the future release?
I noticed that for 'versions.tf' inside the [../sources/aft-customizations-common/templates/customizations_pipeline/versions.tf], beside the main branch, all the Tags version (e.g. 1.4.2) are all defined  version = ">= 4.x.0" without mentioned "<5.0.0", so may I also know if the fixed of 'versions.tf' will also take care previous Tags version's 'versions.tf' please?

Thanks

Hey @UlaJiang thanks for reporting this. Can you provide the AFT version you have deployed?
I've looked at the latest source code for that provider file and I see that it properly lists the argument as shared_credentials_files
As for the < 5.0.0 version restraint, I've gone ahead and created a backlog to address that with the team.

Hi @balltrev Thanks for your quick reply.
The Tag version that thrown the error is 1.4.2, from the provider file of this version I can see that shared_credentials_file instead of shared_credentials_files, which got a s missing in the end. From the AWS Provider I can also confirm that the environment variables is shared_credentials_files (with s).
One interesting bahavior we observe is after we apply the version = ">= 4.9.0 <5.0.0" in versions.tf, and reapply the Tag 1.4.2 buildspecs yaml file, we are able to avoid the above error An argument named "shared_credentials_file" is not expected here. Can you please help us understand better on this behavvior please? Thanks.

You've called out the reason for failure in the v1.4.2 deployment; due to the lack of ,< 5.0.0 in the version constraint, AFT at runtime updates to a version of the hashicorp/aws provider that does not support shared_credentials_file argument. Adding the constraint fixes this issue.
Our recommended solution here is to upgrade to the latest version of AFT, as it resolves several issues, and will not require you to fork the package to modify version.tf files.

Resolving due to inactivity; please open a new issue if you continue to experience this issue on the latest version of AFT.


needs release with PR#6

flake8-todo is part of plone/plone.recipe.codeanalysis, esp. the 'recommended' part.
I just experienced a lot of test failures, as flake8-todo is unable to import pep8, which is not declared as a dependency.
and hey, pycodestyle is the new pep8
see schlamar/flake8-todo/pull/6

Should be fixed now, please give feedback. Thanks.

Works. Thank You!


Animated GIF playback

Suggestion for new feature: It would be great if the sensehat could play 8x8 animated gif files.

Would this work for you?
https://github.com/topshed/RPi_8x8GridDraw


how to construct the project

I have seen someone use 'yarn vite-app...', but its directory structure is not the same as yours

the project structure inspired by another electron + vue/vite template (template here) - with some changes
you can easily create electron app using yarn create @vitejs/app my-vue-app --template vue
after you create the app, add electron builder package to project dependencies and you configure it in package.json to include the vue built files (from dist directory) and electron specific file (same as i did here)