Select common compilers across machines?

Do we stick with gfortran 6.3 or can we get gfortran 8? to work (on all machines)
Which version of ifort is available on cori (cheyenne has 16, 17, 18 all x.0.1 and 16.0.3)
Cray ftn version? (not on Cheyenne obviously)

Unfortunately, a developer committed a patch to the GCC trunk just before the 8.1.0 release that broke lots of coarray features.  Fortunately, the developer also posted a patch that solves the problem, but the patch didn't hit the GCC trunk until after the release.  I recommend Soren start with the 6.4.0, which I've already verified is working and which will give him some confidence in the code and knowledge of how to run it.  Then I recommend jumping to the current GCC trunk (9.0.0), which has the aforementioned patch.
Just FYI, if anyone wants to sue GCC 8.1.0, I recommend building it with the OpenCoarrays installer using something like
./install.sh --package gcc --install-version 8.1.0 --disable-bootstrap --num-threads 4 --yes-to-all

The installer will patch 8.1.0 before building it. Also, for anyone who uses the homebrew package manager, we're working on getting it to apply the patch automatically too.

Does the current master branch of opencoarrays ( bdff1d1274e982368052a6cdf704c69c0e1a8678 ) support this?  I'll see if I can get this to install on cheyenne and run with mpich and/or MPT

By "support this", are you asking whether it patches GCC 8.1.0?  If so, yes.

Yes, and hopefully works for most tests, even some of the multi-dimensional array tests (even if it doesn’t pass your comprehensive test yet)
I’d like to go ahead and try this version with coarray_icar if there is some chance it will work.

I just checked my build and it was with the gcc-8-branch branch. It was also with a version of an OpenCoarray's branch that is essentially the same one that eventually made it into the master branch. So I think using GCC 9 and OpenCoarray's master branch should work.

Sounds good, to install the trunk, use something like
./install.sh -p gcc -b trunk -z -j 4 -y -i "${HOME}/opt/gnu/8.1.0"

Currently Cori has Intel v18 Update 2, and Cray Fortran 8.6.5.

Does cori also have gfortran?

Yep. If you load the PrgEnv-gnu module then you get:
friesen@cori04:~> module avail gcc

------------------------------ /opt/modulefiles -------------------------------
gcc/4.9.3          gcc/6.1.0          gcc/7.1.0(default) gcc/7.3.0
gcc/5.3.0          gcc/6.3.0          gcc/7.2.0


add the newest revision name

I added the process that confirms the newest revision-name

sorry, will update soon


Add an 'n' in window.dox

A tiny docs fix.

Thank you for this 'n'. It may be tiny but that doesn't make it less welcome.


Merge firestore-master to master

The release-6.0.0 branch has been cut, so this branch has outlived its purpose.

LGTM but I guess we need to merge this from the command-line to keep the commit history?

Done.


Add a checker to confirm physical optimizer rules will keep the physical plan schema immutable

Which issue does this PR close?

Closes #4299.
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@jackwener @andygrove @alamb


Container handler

Overview

container handling implementation:
we are going to monitor any new containers and collect realtime information for filter the SBOM

@rcohencyberarmor can you rebase now that your other PR has merged?

This was not rebased well.

Please open a new branch from the main branch.


[tiles] Add "data version" of tiles

for regular block tiles, add the data version where the tiles will have a "tile-data" div that holds csv data & in the case of ranking tile, will also have the svg data.

Note: Disaster Event type tiles will need a little more work

thanks for the reviews!


Sam Package support for AWS::AppSync::FunctionConfiguration

Describe your idea/feature/enhancement
sam package command should support uploading local files to S3 bucket and replacing with s3 path for following properties of "AWS::AppSync::FunctionConfiguration":
RequestMappingTemplateS3Location
ResponseMappingTemplateS3Location
Proposal
Add support, especially since  RequestMappingTemplateS3Location, ResponseMappingTemplateS3Location of "AWS::AppSync::Resolver"  are already supported.
Things to consider:

Will this require any updates to the SAM Spec
No

Additional Details

Released in v0.18.0. Closing


Audio Recording and Playback doesn't work on Ubuntu 18.04 LTS

Describe the bug

After a fresh installation, recording MP3 audio message doesn't work. Tested on All major browsers. The video recording works instead.
To Reproduce
Steps to reproduce the behavior:

Go to the audio message icon.
Click on the micro sign
the recording starts
You get an empty audio file

Expected behavior
Your voice message recorded.
Server Versions
Ubuntu 18.04  LTS
Nginx Reverse Proxy with Letsencrypt

Is this issue related to Android App? Becuase if not, you posted this issue to the wrong repository.

Hi @lorek123  yes indeed that was a mistake.  I appologize.


Feature Request: Declare new restorable state from pyscript

It is currently possible to declare new state from pyscript very easily like some_domain.abc = 'def', even if some_domain or some_domain.abc does not yet exist.
This is very helpful for scripts that want to define their own state. However these states are not automatically persisted when home assistant restarts. A workaround is for the user to manually precreate a input_text.abc helper then manipulating that from pyscript.
However this is rather inconvenient because for every state variable the user has to perform some manual tasks.
So it would be nice if it was somehow possible to define restorable states from pyscript.

Not the Author of pyscript, just a fan... but...
I want this too. Unfortunately, it's quite hard to do it "right".
For binary_sensor and sensor, it's not incredibly hard, since they only set values, and never receive service calls. However, for each domain, pyscript would have to do some setup tasks. And unless pyscript just provided the actual Home Assistant Entity Object to your script to manipulate, it'd also have to provide some convenience functions for setting values.
For switch, light, climate and such, the same is true as above, except these also receive service calls. Which means you'd either have to listen for all the appropriate events, or pyscript would have to provide more convenience functions for this.
For non-standard domains (like your example some_domain) they'd have to be catered to similarly to binary_sensor, but in a different way.
Directly setting the state (state.set('binary_sensor.test', 'on')) gets the job done, but it's rogue in Home Assistant ecosystem. If there's already an entity with that entity_id, it's overwritten. You can't rename the entity in the UI. The state isn't restored on restart.
I wrote a proof-of-concept custom_component to allow setting and restoring arbitrary states in Home Assistant. It has the same caveats as state.set(), with the exception that it DOES restore state. But if you overwrite an existing entity_id, not only will it overwrite it, it'll restore that overwrite on Home Assistant restart.
You're welcome to check it out: hass-setter
I don't actually use this, though it does the bare minimum of what you're asking for. Once installed, in pyscript you could use it like this:
setter.set(entity_id='binary_sensor.test', state='on', attributes={'friendly_name':'Test'})

Perhaps @craigbarratt can find a better way around these limitations, presuming this feature is considered "in-scope" for pyscript.

Perhaps limiting this request to the pyscript domain would make more sense. My goal is for pyscript scripts to be able to store (and persist) state for internal use.
It is currently also possible to do pyscript.some_state = 'abc', so if it would be possible to persist such values that would be great. I now understand that expanding this capability to arbitrary domains is likely undesirable.

See commented on PR #48 .


Implement OP 7

Handle opcode 7: Reconnect (You should attempt to reconnect and resume immediately.)

Fixed in 35c03e3ab36944d1ff6cdf87ca4299e30bfb65ec


Add support for multi dimensional layers

Support multiple sets of layers in an app host in order to allow better division of modules

Are ['INFRA', 'COMMON']  and ['COMMON', 'INFRA'] interchangeable?
I mean, in entry points and API keys, will the developers have to put the layers in the right order?


fix: Fix the scripts for up to date environments

change the spire-agent regex in (6) to include all versions
change the name of the workload containers as they were not loaded
precise the shebang of the python2 script patch.py

Hi. Thank you for your contribution.
Unfortunately, in my environment, your proposed changes do not work.
When the scripts run docker-compose -f docker-compose.yml build in the istio-spire/deployment/web-echo directory, the docker images that are created are:
webecho_echo:latest and webecho_web:latest
I assume that in your environment this command created web-echo_echo:latest and web-echo_web:latest images?
A possible solution is to rename the web-echo directory to a name without a hyphen or an underscore. I expect this would result in a more consistent behavior across different environments.

Hi, sorry I didn't know about this behavior. I fixed the folder name and its references in scripts.
Thank you for the review


Add an MSRV policy

Changes seperated by commits:

Update github actions to more recent versions (node 12 is being deprecated)
Add an MSRV policy as discussed in #39 and test MSRV in CI. We can't set rust-version in the Cargo.toml since that requires Rust 1.56, so instead I used the metadata field which is read by cargo msrv
Updated the Changelog based on the commit history of this project since v1.0

Thanks!


move the version field in front of the packet number in the long header

Fixes #960.
This was recently changed in the IETF draft.

Codecov Report

Merging #961 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #961   +/-   ##
=======================================
  Coverage   90.78%   90.78%
=======================================
  Files          99       99
  Lines        6543     6543
=======================================
  Hits         5940     5940
  Misses        388      388
  Partials      215      215

Impacted Files
Coverage Δ

internal/wire/ietf_header.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccd91a3...f440a65. Read the comment docs.


Fix parentheses for MSVC -- triggers compiler warnings

CC @mlindgren

Confirmed via local build that this fixes the warnings for me


Make Endpoint class public to allow custom routing

I'm attempting to replace the discovery endpoint and possibly the endpoint router in an effort to provide a solution similar to his Azure AD solution where tenant is a URL parameter.
I'm running into a challenge, though, with the fact the IdentityServer4.Hosting.Endpoint class is internal - in order to replace the "Discovery" endpoint, I have to either do some interesting reflection (so I can look in the IServiceCollection and find the Endpoint singleton that's already been registered) or craft my own IIdentityServerBuilder before calling services.AddIdentityServer(). This is because registration order of the endpoints appears to matter - the first one found in the service collection that matches the path is used, and that is always the default one rather than mine.
I also want to try introducing some route template support into a custom IEndpointRouter but, again, I can't get to the list of registered Endpoint objects very easily because Endpoint is internal.
Any way Endpoint can be made public before the final 2.0 release?

Somewhat related, though I can open a different issue if desired: The EndpointRouter specifically has a test to ensure the first registered route mapping is used, which effectively also ensures no one can override any of the default routes since the conforming DI container behavior is to return the IEnumerable<T> in the order of registration. I think in .NET Core this should be finds the last registered mapping so overrides are possible.

Looks like @brockallen had an unanswered comment on 1364 wondering if routes should be replaceable. I think so, and it'd be easy enough to do that.
Technically a custom IEndpointRouter could bypass use of any existing registered Endpoint objects and re-register everything in a custom way to do it, but it'd be nice to be able to get the same effect with less work.

It occurred to me this morning that depending on the order of the IEnumerable<Endpoint> is actually a subtle gotcha. The Microsoft conforming container has a specific behavior, other containers have tried to adapt to that behavior, but it's not really guaranteed. There's a big Microsoft.Extensions.DependencyInjection issue about that I can dredge up if you want to read one of the longest issues EVAR.
Point being, it would be good to have the ability to specify an Order for each endpoint if there's the ability to add endpoints. The ASP.NET Core stuff was too far along to do that in some cases, but they agreed that's the more accurate way to go. That would also stop folks from having to Insert into the IServiceCollection or whatever - just add a new Endpoint with a lower Order.
It makes me wonder if Endpoint should actually be more like this:
public abstract class Endpoint
{
  public string Id { get; set; }
  public int Order { get; set; }
  public Type Handler { get; set; }
  public abstract bool Match(HttpContext context);
}

public class PathEndpoint
{
  public PathString Path { get; set; }
  public override bool Match(HttpContext context)
  {
     return context.Request.Path.StartsWithSegments(this.Path);
  }
}

With something like that, not only could one handle ordering correctly, you could also change the logic for path matching from outside the EndpointRouter so extensions wouldn't necessarily need a whole custom router.
BUT! This drifts a bit from the original request. I can live with a simple public Endpoint and still work around everything else.

Done, thanks

@tillig I've been using a fork in order to be able to use an extra url segment in all of the endpoint urls. This issue makes me think maybe it is now possible to do that without forking. I wonder if you could elaborate on how to do it to help me out?
pretty much just like that article you linked, I want to be able to use urls like
domain/tenantsegment/therestoftheidserverendpointpath

where the tenantsegment is how I resolve the tenant. Are you doing something like that? and if so any pointers on how to achieve it would be greatly appreciated

@joeaudette Read through PR #1576 for a walkthrough with code of what I'm doing.

@tillig many thanks! that looks promising for my needs, I will give it a try in my solution.

@tillig do you happen to have a full example in one of your repos? Possibly updated for current versions of IS4? :) trying to wrap my head around some of what you have happening, but there are missing pieces that I'm not quite sure what's going on there. thank you!

I don't have anything I can make public other than what I've provided, sorry.

@tillig no worries. Maybe you can just clarify a few things?

What is TransparentObject in AddMultitenantRouting()?
With the changes made do you still require PathEndpoint?
IdentityServerEndpointType. Was this yours, or did IS4 change something?

Thanks for any clarification :)

Sorry, it's been two years since this code, I'm not on that project anymore, and I'm on vacation for the next two weeks. I hate to say it, but what's here in this thread is all I can do for you.


Does envoy provide a mechanism to observe configuration changes?

I'm doing something similar to Istio, using Iptable to intercept HTTP requests and envoy to handle the traffic. I use xDS to connect envoy to our own service registry. When a new service is registered, new cDS and rds will be generated and sent to envoy.
Just doing this still does not work properly, because it also needs to generate DNS records. I found that DNS Filter can do this, but it is currently under development. Therefore, I am going to develop a module to watch the envoy cluster configuration and generate a DNS record for each cluster.
So, my question is whether envoy provides a watch mechanism so that I can perceive that the cluster configuration of envoy has changed. If not, I can only use polling to check whether changes have occurred.

Probably need more detail. Who is the watch mechanism used by? Some extensions inside of Envoy, some external process?
How do you plan on regenerating the DNS filter config?
Envoy itself will watch for xDS changes either via gRPC or filesytem (inotify).


Small test fixes (C++)

-- changing to use ULL in test numbers so this compiles on all platforms
-- updating a couple of test-cases/comments to bring inline with Java

LGTM! I assume you ran tests :)
Please merge if you agree that we can push to master again.

Yes built and ran :)


attribute list in guidelines

At the moment the guidelines provide a list of attribute classes. This is good, but quite unintuitive if for users not into ODD modelling. An alphabetical list of attribute names (maybe with indication of the class they are part of) would be a very good addition.

You mean like the third row at http://music-encoding.org/documentation/3.0.0/caption/ (or any other element)?

Am 24.01.2017 um 16:10 schrieb Benjamin W. Bohl<EMAIL_ADDRESS>At the moment the guidelines provide a list of attribute classes. This is good, but quite unintuitive if for users not into ODD modelling. An alphabetical list of attribute names (maybe with indication of the class they are part of) would be a very good addition.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I mean as an alternative to http://music-encoding.org/documentation/3.0.0/atts/
Which is good to have but both misleading in its name URL "…/atts/" and the link labels on music-encoding ("Attributes") but actually is (as stated in the page heading) "Attribute classes".
See for example:
http://www.tei-c.org/release/doc/tei-p5-doc/en/html/REF-ATTS.html


Building off 3.6 branch

Hello,
Using:
Rabbit: rabbitmq-server-3.6.1
Consul: Consul v0.6.3
After building the rabbitmq-3.6 branch for rabbitmq-autocluster i am running against the following issues:
INFO REPORT==== 3-Mar-2016::22:40:13 ===
autocluster: GET http://<IP_ADDRESS>:8500/v1/health/service/rabbitmq?passing
=INFO REPORT==== 3-Mar-2016::22:40:13 ===
autocluster: Response: [{error,
{failed_connect,
[{to_address,{"<IP_ADDRESS>",8500}},
{inet,[inet],eacces}]}}]
=ERROR REPORT==== 3-Mar-2016::22:40:13 ===
autocluster: HTTP Error {failed_connect,
[{to_address,{"<IP_ADDRESS>",8500}},
{inet,[inet],eacces}]}
=ERROR REPORT==== 3-Mar-2016::22:40:13 ===
autocluster: Could not fetch node list from autocluster_consul: {failed_connect,
[{to_address,
{"<IP_ADDRESS>",
8500}},
{inet,
[inet],
eacces}]}
=INFO REPORT==== 3-Mar-2016::22:46:14 ===
autocluster: GET http://<IP_ADDRESS>:8500/v1/agent/check/pass/service%3Arabbitmq
=INFO REPORT==== 3-Mar-2016::22:46:14 ===
autocluster: Response: [{error,
{failed_connect,
[{to_address,{"<IP_ADDRESS>",8500}},
{inet,[inet],eacces}]}}]
=ERROR REPORT==== 3-Mar-2016::22:46:14 ===
autocluster: HTTP Error {failed_connect,
[{to_address,{"<IP_ADDRESS>",8500}},
{inet,[inet],eacces}]}
=ERROR REPORT==== 3-Mar-2016::22:46:14 ===
autocluster: Error updating Consul health check: {failed_connect,
[{to_address,
{"<IP_ADDRESS>",8500}},
{inet,[inet],eacces}]}
I have disabled iptables, changed the host to point to localhost, as well as the real ip of the host, and no dice. Any thoughts or assistance would be greatly appreciated.
I built using:
rabbitmq-public-umbrella stable branch
make co
make BRANCH=rabbitmq_v3_6_1
cd rabbitmq-autocluster/
git checkout rabbitmq-3.6
make
make dist
This dropped a autocluster-%%VER%%.ez file in my plugins dir which i then used in the /usr/lib/rabbitmq/lib/rabbitmq_server-3.6.1/plugins/ directory
{autocluster, [
{consul_host, '<IP_ADDRESS>'},
{consul_port, 8500}
]}

In case anyone else runs into this, this was caused by selinux, which is in enforcing mode on my infrastructure, so, to get past this:
sudo cat /var/log/audit/audit.log | grep beam | grep denied | audit2allow -M rabbitmq_autocluster
sudo semodule -i rabbitmq_autocluster.pp
This will allow denied items to be permitted through.


[POC] Color system

Preview: https://deploy-preview-29495--material-ui.netlify.app/joy/

[ ] I have followed (at least) the PR section of the contributing guide.

The opacity approach is KO. This PR can be closed.


feat(highlight): automatic $sce html trusting.

WARNING: drops 1.0.x compatibility.
It may possibly be written in a manner that preserves 1.0.x compatibility using injector interface internally (checking if $sce exists) but I'm not sure it's necessary

This PR seems to be obsolete. Moreover UI.Utils modules was split in individuals repositories. If still valid, please consider re-submitting on the dedicated repository.
See the README for details.


Helm chart privateRegistryScanSecretsNames should allow for multiple secrets in same namespace

https://github.com/aquasecurity/trivy-operator/blob/eb495d1fd5cd5303e4b5fbc0b95a15e8d58603ef/deploy/helm/values.yaml#L93
This won't work if we need more than one secret per namespace unless it accepts an array as value. This might be the case - if so, close this

suggested solution is to extend the privateRegistryScanSecretsNames to accept key to multi value comma separated.
example: {"myNamespace":"cred1,cred2,cred3"}


[Request] Update Paperless NG to Paperless NGX

Which addon?
Paperless NG
Is your feature request related to a problem? Please describe.
Paperless NG has been deprecated. Under the new name Paperless NGX (https://github.com/paperless-ngx/paperless-ngx) the development will be continued.
Until now there is no add-on for HassIO.
Describe the solution you'd like
It would be great to have a new/updated add-on for the new Paperless NGX.

Hi, thanks. Currently linuxserver has not updated its image (https://github.com/linuxserver/docker-paperless-ngx), when they will have done that I'll switch to paperless-ngx

Hi, paperless NGX is up! Just update the addon and it will install the new version. Please let me know if there is any breaking change as I don't use the addon myself. Enjoy!

Thanks! When  I tried to install, I got an error:
Head "https://ghcr.io/v2/linuxserver/paperless-ngx/manifests/arm32v7-latest": unauthorized

Argh - it's so fresh they haven't updated their ghcr permissions yet. I'll use the docker one, please wait 5 min, refresh and it should be good


[$100 Bounty] Add Support for 23 Ford Escape Refresh (CAN-FD, Q4 Harness)

2023 Ford Escape Hybrid AWD (CAN-FD & Q4 Harness)
Q&A/Info about this PR
Why did I create a new model rather than just adding the fingerprint to the MK4 Escape?
Although the 2023 Ford escape is still considered generation 4, the refresh was the complete overhaul of the systems electronics. It is now using CAN-FD rather than CAN unlike the 2020-2022 (see this wikipedia entry).
Other than fingerprints and values, what else did I use to get this to work?

Change The Panda Branch: The stock panda sub module does not allow the 3X to recognize the car. In order for the 3X recognize the car, I had to change the panda sub module to the branch isotp-canfd-support. See https://github.com/commaai/panda/pull/1524 for more info on this.
Comment out dashcamOnly from selfdrive/car/ford/interface.py: Currently all Q4 harnesses are not supported from my understanding. Commenting out this reference allows stock openpilot to see the car.

What did the physical install look like? Quite Involved (2-3 Hours)
This install is not for the faint of heart. It is time consuming and a little risky (due to having to disconnect airbag seatbelt tensioner wire which is the yellow plug in the photo below). But the risks can be mitigated (disconnecting the negative terminal whenever you are working with anything electrical or touching the airbag system). If you are handy, know your way around cars/electrical, and willing to put in the effort, it is very doable.
First off, the #ford channel in the comma.ai discord server is very helpful so if you haven't joined it already, do that now. Also, it is very necessary to get a 72 hour access to the service manual as you will need to remove lots of trim panel pieces.
🚨 You will need to temporarily remove the rear seatbelt (which is integrated into the airbag system so best practice is to remove power from the car during the install) 🚨
Remove the 13mm bolt that is grounded to the chassis to the left (DO NOT REMOVE THE SCREW FROM THE TERMINAL... THE TERMINAL BOLT WILL EASILY BREAK and a replacement is ~$150 USD)
For 2023, Ford relocated the Image Processing Module (IPMA) from the rear view mirror trim area to just under the right trunk window... behind the trim. The below image includes the Q4 harness:

As a result of this, third-party parts are needed to install with the increased distance (These are NOT affiliate links):

Monoprice SlimRun Cat6 20ft: The ethernet cable that comes included is not long enough. I use these cables all the time at work and selected this one specifically because the slim cable is easy to route behind the bottom door-sill trim panel pieces from the OBD2 port to the harness in the trunk area.
USB-C Extension: The USB-C cable that comes included is not long enough. To get the USB-C connection to the 3X from the harness in the trunk area, you will need an extender, good news is that the distance is perfect if you are running along the headliner to the rear view mirror. Once run, use the right-angle cable that came in the box to plug into the 3X.

You will need tools:

Trim Panel Removal Tools (never use metal to pry off a trim panel piece, make sure they're plastic)
7mm Socket
10mm Socket
13mm Socket
T25 Torx Screwdriver
Gloves (Trunk weather seal has "goo")

Trim Panels removed/moved slightly:

Driver-Side lower door-sill trim: To tuck the cat6 cable
Trunk bottom trim pieces: To access IPMA
Right Lower Loadspace Trim: To access IPMA
Right Upper Loadspace Trim: To access IPMA & run USB-C to headliner
B-Pillar Trim: To run USB-C behind headliner
Rear-View Mirror Trim: To run USB-C cable to 3X on windshield

For more on the install, see this discord thread
What's next?

Testing, Testing, Testing: More testing is needed as I've noticed some "Controls Lagging" & "Controls Mismatch" Errors. Nothing that I found dangerous but annoying and usually require a reboot of the device
Collaboration: I will admit that I am not a CAN network expert and not a well-versed python dev so please feel free to pick my brain, request logs, & send code snippets to test.

Comma Checklist

[ ] added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
[x] test route added to routes.py
[ ] route with openpilot:
[ ] route with stock system:
[x] car harness used: Ford Q4

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.
PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.


serve-mp4.js TypeError at end of normal video playback

castnow\utils\serve-mp4.js:22
    var chunksize = (part.end - part.start) + 1;
                       ^
TypeError: Cannot read property 'end' of undefined
    at module.exports (castnow\utils\serve-mp4.js:22:24)
    at Object.fn (castnow\plugins\localfile.js:48:5)
    at loop (castnow\node_modules\router\index.js:43:11)
    at Server.route (castnow\node_modules\router\index.js:50:3)
    at emitTwo (events.js:87:13)
    at Server.emit (events.js:172:7)
    at HTTPParser.parserOnIncoming [as onIncoming] (_http_server.js:527:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:88:23)

This appeared when the 2 hour video was almost done with playback. No playlist involved, just one video. Never paused or seeked, either. The Chromecast timed out with the last few seconds of video stuck on screen.
It seems to be related to range-parser.

It would seem that the chromecast is sending some http request to the castnow host. The http request that is sent probably don´t have the byte range header. So the request is probably asking for something other than a video stream.
If you´re able to, please run a network sniffer or the debug mode on your chromecast to see the requests sent, and see if you can recreate that exact problem. And please provide the request log etc.
Try it with the same file.


Update default calibration

This PR updates the default calibration for the OG-USA model.  Changes include:

A fix to macro_params.py, which corrects double counting of social security payments when determining the $\alpha_G$ parameter.  As a result, $\alpha_G$ is significantly larger.
Changes default start year to 2025
Updates AIME breakpoints for 2024 values
Rounds numbers to 2-4 digits, depending on the parameter.

Codecov Report
Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.29%. Comparing base (e4655db) to head (14666f9).
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   75.41%   75.29%   -0.12%
==========================================
  Files          11       11
  Lines         850      850
==========================================
- Hits          641      640       -1
- Misses        209      210       +1

Flag
Coverage Δ

unittests
75.29% <88.88%> (-0.12%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

ogusa/calibrate.py
37.41% <ø> (ø)

ogusa/macro_params.py
100.00% <ø> (ø)

ogusa/get_micro_data.py
96.82% <88.88%> (-1.54%)
:arrow_down:

... and 1 file with indirect coverage changes

@jdebacker. I just have the one question about updating values in the ogusa_default_parameters.json instead of updating them in the sample run script. The current status of this PR is good to go, but I think I would prefer moving those changes to the ogusa_default_parameters.json file. Let me know what you think, and I'll merge this.

@rickecon Thanks for the review.  I just made the suggested changes.

@jdebacker. This looks great. Merging.


SpectacularAI WARN: missing key frame in pose trail, skipping VIO constraint

Hello,
When I run the mapping tool, I sometimes get this message
warning: Lost tracking!
SpectacularAI WARN: missing key frame in pose trail, skipping VIO constraint
What does it mean exactly ? How could I avoid these ? It seems it disturb the mapping process.
Running on Windows 11
Dataset from IOS Spectacular Rec, Iphone 12Pro

Our iOS parameters are currently a bit flaky and this will be improved in future SDK releases. The "lost tracking" message means that the system encountered and internal SLAM failure / reset and failed to produce a good reconstruction for this reason. You can ignore the other (internal) warning.
You may try again with different parameters (e.g., with a --mono command-line parameter for sai-cli process) or, if all else fails, try another recording. Avoiding fast movements, shooting objects at a very close distance and low lighting increase the risk of this happening.

Thanks a lot for these details.


Add "where" option to the counter_culture method

We already have this cool feature implemented in https://github.com/magnusvk/counter_culture/pull/250, which allows us to do this:
Product.counter_culture_fix_counts(only: :category, where: { categories: { category_type: 'awesome' } })
# will fix counts only for the categories with category_type 'awesome'

So, it would be awesome to also have this where option on the counter_culture method, so we could define counters like this:
class Product < ActiveRecord::Base
  belongs_to :category, column_name: 'products_count'
  counter_culture :category, where: { categories: { category_type: 'regular' } }
end

This is useful in cases when some categories actually relate to a different products type:
class SpecialProduct < ActiveRecord::Base
  belongs_to :category, column_name: 'products_count'
  counter_culture :category, where: { categories: { category_type: 'special' } }
end

So what would we gain from it? Now we would be able to simply call counter_culture_fix_counts with everything already configured, like this:
Product.counter_culture_fix_counts(only: :category)
SpecialProduct.counter_culture_fix_counts(only: :category)

Conclusion
And now I realized that it's probably not worth it, I was a bit confused when I was creating this issue. :sweat_smile:
What do you think, is it worth it?

I think you can accomplish what you're looking for with conditional counter caches.


[Bug] Orgs should be ordered in the order in a user was invited to them on the home page

Steps

Create 2 accounts
Create an organization in the second account with a name starting with A
Invite the user from the first account
The organization that the user was invited to should show up at the bottom of the list but instead shows up at a random location

@Nikhil-Nandagopal Can I take a look?

I have the environment up and running, could I take this issue?

OK; I've reproduced the issue. This is soooo much easier to spot with a second org. At first it was hard to see the problematic sorting, but I think I see it now. Please confirm attached screenshot.
(Please note, I'm not waiting for confirmation, I'm just hoping you can yell at me if I've misidentified.)

OK, I have a code change that I think will work, but I can't figure out how to get the React to run in conjunction with the docker-compose.yml really quick. Is there a trick to running the local server? I don't see anything in any of the README.md's.

Hi guys, thank you for your participation, I'm assigning this to @shinnlok since he claimed for it first.
@manchicken we have quite a few other issues open. You can have a look at our Contribution Guide to get the code running

@Nikhil-Nandagopal Oh, man, I'm sorry @shinnlok, I didn't see that.
I'll take a peek elsewhere, many thanks.


Add all our RNA specific visualisations

I added the PS viewer in https://github.com/bgruening/galaxy-rna-workbench/pull/37
The RNA 2D structure viewer should be already included and is upstream.
https://github.com/galaxyproject/galaxy/pull/2875#issuecomment-252439928
@bagnacan can you maybe test the visualization and make some screenshots with a short description.

Should be included now.


[Docs]translate clickhousefile,phoenix,rabbitmq,starrocks sink doc into chinese

[Docs]translate clickhousefile,phoenix,rabbitmq,starrocks sink doc into chinese

Purpose of this pull request

translate clickhousefile,phoenix,rabbitmq,starrocks sink doc into chinese
Does this PR introduce any user-facing change?
yes. just translate clickhousefile,phoenix ,rabbitmq , starrocks  sink english doc into chinese.
How was this patch tested?

Check list

[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

cc @zhilinli123


Mute output from cf set-env to hide credentials

Trello https://trello.com/c/eBl3yUUT/27-jenkins-credentials-shown-in-plain-text-in-job-scripts-and-logs#
NB: not tested yet (to avoid strain on prod API)

As we weren't able to test this today we should check the output of the console log for this job once it has run after merging, just to make sure it did what we wanted!

Thinking about it, is there a reason why we use cf set-env here instead of setting the env variables in the manifest? We're using python scripts to generate the post data and to generate the manifest, why not put them together in Python? (Then we could... write a test for it? 🙀)

Yeah! That's a much better way!


Application published with ReadyToRun not launching after updating nuget packages from 0.10.3 to 0.10.6

I installed Avalonia extension to Visual Studio 2019 and created project with Avalonia template. Publishing with ReadyToRun was working well. But then I noticed that there is an update from version 0.10.3 to 0.10.6. After updating nuget packages publishing with ReadyToRun still works, but the application won't start. If I downgrade nuget packages to 0.10.3 all becomes normal again.

It works perfectly for me.
Can you share any logs from your application (try catch in Main() usually has some info) or from the OS (event viewer in windows or console in macos)?

Application: AvaloniaApplication2.exe
CoreCLR Version: 5.0.721.25508
.NET Version: 5.0.7
Description: The process was terminated due to an unhandled exception.
Exception Info: System.IO.FileLoadException: Could not load file or assembly 'Avalonia.Controls, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=c8d484a7012f9a8b'. The located assembly's manifest definition does not match the assembly reference. (0x80131040)
File name: 'Avalonia.Controls, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=c8d484a7012f9a8b'
at AvaloniaApplication2.Program.Main(String[] args)

Do you publish it as a single file (PublishSingleFile)?

I tried both publishing with PublishSingleFile and without it
Here is my project: https://1drv.ms/u/s!AoJ4Bx_49cOvlgI_6i8oRJlTPh1g?e=bqiJnq
published files are in \bin\Release\net5.0\publish folder

Seems like a duplicate of https://github.com/AvaloniaUI/Avalonia/issues/4543
I have no idea why it's a problem. Not sure if Avalonia is related.

Just for case, I tried to build your project, and removing "obj" folder did help me.

Oh... I forgot that sometimes deleting obj folder solves problems. Thanks, after deleting obj folder and building everything works

Closing it for now, because it doesn't seems as a problem in Avalonia.
Otherwise ping me to reopen it.


Disable ML inference events capture by default.

This PR disables machine_learning.inference_events_value.enabled by default.

Codecov Report

Merging #924 (247cbb4) into develop-scikitlearn (3465cdd) will not change coverage.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           develop-scikitlearn     #924   +/-   ##
====================================================
  Coverage                81.75%   81.75%
====================================================
  Files                      190      190
  Lines                    19581    19581
  Branches                  3401     3401
====================================================
  Hits                     16008    16008
  Misses                    2590     2590
  Partials                   983      983

Files Changed
Coverage Δ

newrelic/core/config.py
94.21% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Image Optimization: Does MPS optimize  images?

Hey everyone,
I did some tests and read the docs (and even digged through the code a litte) but I'm still not sure so I thought I ask for clarification:
Does MPS actually optimize images in
<picture>
  <source srcset="" />
</picture>

or does it just optimize images within ?
Thanks in advance!

I have same question, found that only  images were optimized by the mod, it seems does not optimize <source srcset> images.

Hi
In the next release maybe you can configure
pagespeed AddUrlValuedAttribute source srcset srcsetimage
Is in a previous state as PR #1929

hi @Lofesa ,
but the mentioned PR does not solve the problem. Do you have any information about when picture tags will be supported?
I think the problem could be solved if someone marks the source-tag as an image, depending on the parent element , at line:
https://github.com/apache/incubator-pagespeed-mod/blob/b3349ab11b9a6345f589fba244fcfbc11af69a5a/net/instaweb/rewriter/resource_tag_scanner.cc#L162

Hi @FalkoHilbert
The PR is intended to solve the data-srcset issue, not to add the picture element.
I have no tried, cause I don´t use picture elements in my site, but with
pagespeed AddUrlValuedAttribute source srcset srcsetimage
pagespeed AddUrlValuedAttribute source data-srcset srcsetimage
pagespeed AddUrlValuedAttribute source data-src image
pagespeed AddUrlValuedAttribute source src image

must work if you use these combinations if you only use picture, but if you use audio or video this can´t be used, cause it uses source src.
As far as I know adding the picture element is not planned, people that works in the module are in other things.
Any chance you make a proposal PR for this?

Example output:
<picture>
  <source srcset="[omitted]/images/[unique-image-id]/[seo-friendly-filename].jpeg" media="(min-width: 1800px)">
  <source srcset="[omitted]/images/[unique-image-id]/[seo-friendly-filename].jpeg" media="(min-width: 1500px)">
  <source srcset="[omitted]/images/[unique-image-id]/[seo-friendly-filename].jpeg" media="(min-width: 1200px)">
  <source srcset="[omitted]/images/[unique-image-id]/[seo-friendly-filename].jpeg" media="(min-width: 900px)">
  <source srcset="[omitted]/images/[unique-image-id]/[seo-friendly-filename].jpeg" media="(min-width: 600px)">
  <source srcset="[omitted]/images/[unique-image-id]/[seo-friendly-filename].jpeg" media="(min-width: 300px)">
  <source srcset="[omitted]/images/[unique-image-id]/[seo-friendly-filename].jpeg" media="(min-width: 0px)">

</picture>

We have implemented a component that creates a lot of different sizes based on a predefined combination and the image given in the backend (Includes cropping, masks, focal points). The user can make a lot of decisions for each individual image in our backend.
 AFAIK scrset and sizes only give the browser hints as to what you want and the browser decides what it really wants to show.
The images are also only generated on the server if they are requested by the browser in that specific size, so we didn't want to implement a serverside recompression since we would duplicate what MPS already does.
What we want MPS to do (and which it does really well for "regular" img tags) is to recompress/change the format (if the browser supports it) of the "final" images. Or insert them as base64 into the source code if possible ... all the good stuff that already happens in a lot of places. Now, we just need it for the sources within the image. ;)
I havn't had the time yet to try your AddUrlValuedAttribute configuration. Maybe this already solves our usecase.

Have you enabled pagespeed in this site?
Are the <img src= rewrited? both, the img element in picture and in noscript.
Pagespeed identifies images with <img src
In the source element, srcset are not true srcset, cause it have only 1 image, so maybe you can try the AddUrlValuedAttribute source srcset image: .


A11y_TrydotNetWebsite_Screen Reader: Narrator is not reading left/right brackets present in code section

GitHubTags:#A11ySev2;#A11yTCS;#A11yWCAG2.1;#DesktopWeb;#.NET Websites;#Win10;#P2-TrydotNetWebsite-Aug21;#WCAG1.3.1;#Info and Relationships;#FTP:#P2-WCP;#Screen Reader;#Narrator
Actual Result:
Narrator is not reading left/right brackets present in code section.
Expected Result:
Narrator should read all left/right brackets present in code section.
Environment Details:
Application Name: TrydotNetWebsite
Standard Violated: WCAG1.3.1
Note:
No issues with NVDA.
Repro Steps:
1.Hit the URL https://try.dot.net
2.Tab till curly brackets.
3.Verify whether narrator is reading left/right brackets present in code or not.
User Impact
Screen Reader users will face difficulty in navigation if Narrator is not reading left/right brackets present in code section.

https://learn.microsoft.com/en-us/dotnet/csharp/tour-of-csharp/tutorials/hello-world?tutorial-step=1&WT.mc_id=-blog-scottha
issue still reproduces
@terrimorton

#Closed;
Verified the issue in below environment. Issue is fixed hence closing the bug.
https://learn.microsoft.com/en-us/dotnet/csharp/tour-of-csharp/tutorials/hello-world?tutorial-step=1&WT.mc_id=-blog-scottha
https://github.com/user-attachments/assets/5bf76c17-05a4-458c-b3c9-829fc595b911


the Lean language server could not connect

I'm sorry to bother you.I opened the vscode software, but the Lean language server could not connect successfully. Because the area is restricted. I use a proxy to access the Internet and configure the proxy address on the vscode client. But it still appears that the Lean language server cannot be successfully connected. What should I do?

Hi @whsm , thanks for the question! According to the description, it seems that your difficulty connecting to Lean is not an issue specific to Lean Copilot. If that is the case, you might want to ask directly in the Lean4 repo for help from a broader community. Hope this helps!

I understand and thank you very much for your reply.


Error pops up on all API requests when using Colab.

Expected Behavior
Functioning as usual.
Actual Behavior
Blockage of all functionality.
Steps to Reproduce
Happens even on a clean install in Colab.
Debug Logs
10:56:58.475 [Error] [WebAPI] Error handling API request '/API/InstallConfirmWS': Invalid request method: GET

Other
Happened with my install in drive whenever I clicked generate and pops up again when I try to do a clean install in session storage without mounting drive. I have uninstalled my drive install and attempted to reinstall it (and obviously failed) in attempt to fix the problem so unfortunately I can't provide proper debug logs as I can't access the "server" menu

I think there might be a cloudflared bug? That looks like it's not properly forwarding websockets

Yep, it was cloudflared. There was a new release yesterday that messed everything up. Downgraded to the previous one and it let me click install.

ooh, nice - I pushed a change to the default to use the prior version

you typed the link incorrectly (i blame github and their unstandardized link system) #203


[missing-operators] adding missing prefix and postfix operators

Prevents errors in Swiftz like these

Operadics does not cover the sections in Swiftx, of which • used to be a member.  That feature was shuffled into Swiftz then removed (checkout swift-develop and grep for it.  It's really and truly gone).


Add Windows-like Iterator that returns static-sized tuple elements instead of slices.

The Windows iterator in the std lib returns its values as slices of elements.
This makes it unpleasant to work with since pattern matching and borrowing of slices is more restricted than (for example) for tuples.
Besides that a tuple-based Windows iterator should not involve runtime overhead and should make it possible to make compile time assumptions about the correctness of the implementation. For example, it can be checked at compiletime if accesses to iterator elements are "out-of-bounds".
E.g.:
    let primes = &[2, 3, 5, 7, 11, 13, 17, ...];
    for (fst, snd) in primes.iter().windows(2) {
        println!("({}, {})", fst, snd);
    }

Needs to take into account that integer parameters like 2 are runtime information and tuple arity is type-level compile time information. Would work fine with a type-level kind of parameterization, either .windows2() or .windows::<Pair>() and so on.

Ah dang. You are right, I haven't thought about that. Maybe with the typenum crate one could work around this until associated constants land in Rust, if ever?

I don't think typenum supports tuples, or is the solution we want? We can do something simpler with traits. Should look at other cases like .combinations() as well as windows.

I do not know exactly how he did it, but in Crate: Generic Array the owner uses typenum::uint in order to create a generic statically sized array. This could be used in a similar way to create an easy-to-use windows(N) iterator that can have tuples (compile-time-constant size types) as iterator elements. =)
ArrayLength is where the magic happens according to the owner of the generic-array crate.

They use an interesting trick where they just make a struct of the correct size. Instead of [T; 4] they have struct { struct { T, T }, struct { T, T } }.

I was looking for this today and sort of hoped that it would be
let primes = &[2, 3, 5, 7, 11, 13, 17, ...];
for (fst, snd) in iwindow!(primes.iter(), 2) {
    println!("({}, {})", fst, snd);
}

Like in #151, I think  for (fst, snd) in primes.tuple_windows() can become a reality soon.


IndexError: list index out of range

Traceback (most recent call last):
File "data_util/process_data.py", line 110, in
tmp_img = cv2.imread(os.path.join(ori_imgs_dir, str(valid_img_ids[0])+'.jpg'))
IndexError: list index out of range
Please, could you help me handle this one also?

Hi, please follow and finish the prerequisites before running the process data script.

Hello, I have finished prerequisites mentioned in your instructions, However, I also meet this problem. What's the problem and how to solve it?  Thank you in advane!

Hello, I have finished the prerequisites you mentioned in the instructions. However, I also meet this problem. Could you please tell me how to fix it? Thank you in advance!

Hello, I have finished the prerequisites you mentioned in the instructions. However, I also meet this problem. Could you please tell me how to fix it? Thank you in advance!

It's because that the landmarks detection step (step 2) didn't succeed. You can check this part by making sure there are *.jpg (generated from step 1) in the ori_imgs folder and then running 'python data_util/process_data.py --id=$1 --step=2' to see what happens.

There are images with 'jpg' format in the ori_imgs folder , however,  after I run the code 'python data_util/process_data.py --id=$1 --step=2', it just printed 'no video'

There are images with 'jpg' format in the ori_imgs folder , however, after I run the code 'python data_util/process_data.py --id=$1 --step=2', it just printed 'no video'

Hi, here the $1 means the id name, Obama for example.

There are images with 'jpg' format in the ori_imgs folder , however, after I run the code 'python data_util/process_data.py --id=$1 --step=2', it just printed 'no video'

Hi, here the $1 means the id name, Obama for example.

Thanks. After doing it I have got this error:

I changed
https://github.com/YudongGuo/AD-NeRF/blob/9fdcd7e1352aa74e26baa8e60c862f9fbd7933bf/data_util/process_data.py#L95 to
face_alignment.LandmarksType.TWO_D, flip_input=False) and it worked.


Clarify instructions on saving object properties

Further closes #6298, as per discussion on said issue.

Looks good :+1:


Track Views in SwiftUI

I’m trying to use CleverTap to create a funnel for my SwiftUI app, but the way SwiftUI works with regard to how onAppear behaves, makes that very challenging.
Ideally, CleverTap would provide SwiftUI support similar to Firebase, where you just decorate your view with some metadata, and it's automatically tracked as an event when that view appears:
struct ContentView: View {
  var body: some View {
    Text("Hello, world!")
       // Logging screen name with class and a custom parameter.
      .analyticsScreen(name: "main_content",
                       class: "ContentView",
                       extraParameters: ["my_custom_param": 5])

      // OR Logging screen name only, class and extra parameters are optional.
      .analyticsScreen(name: "main_content")
  }
}

This is my current naive integration of CleverTap using SwiftUI:
UserProfile().onAppear {
    CleverTap.sharedInstance()?.recordEvent("User Profile Viewed")
}

However, ^ this doesn’t actually work in practice, because SwiftUI will execute the onAppear callback many times, at unexpected times, and out of order with how the views actually appear to the user.
It seems the correct way of doing analytics with SwiftUI apps is to swizzle UIKit’s viewDidAppear, which is a more reliable way of know what view is actually presented to the user, and then giving developers a nice API using SwiftUI to decorate their views with the appropriate metadata.

@moubry excellent point. We will be adding this to our development/release cycle 👍

@moubry
We have added docs on steps to track screen views in swiftUI: https://developer.clevertap.com/docs/advanced-options-ios#track-screen-views-in-swiftui
Also you can refer our sample app for the implementation part: https://github.com/CleverTap/clevertap-ios-sdk/blob/master/SwiftUIStarter/SwiftUIStarter/CTViewModifier.swift
Thanks.


Solution: Make them part of Mortium's own draculin faction so the kill squads from Ruins of Mortium are not hostile to the draculins.
I like the idea of Mortium sending kill squads for me using their own people, but those people should not be hostile to them.

Definitely agree. This wanted faction needs some better spawns as well.

This should be done now as of v0.3.2.


twister: support segger real-time-transfer (rtt) for serial_pty

Add initial support for RTT (Segger Real-time Transfer) for reading console messages with twister when testing with hardware.

[!NOTE]
This support should be considered experimental as transfer speed, buffering, buffer size, and buffer count are all tuneable parameters that can vary per-platform and debug adapter. Physical UARTs or other higher-speed I/O interfaces are certainly still the primary means of capturing test output from twister when connected to hardware.

Tested with:
twister -p nucleo_l496zg --device-testing --flash-before --west-runner openocd --west-flash --device-serial-pty rtt -T samples/hello_world

cat twister-out/nucleo_l496zg_stm32l496xx/samples/hello_world/sample.basic.helloworld/handler.log
*** Booting Zephyr OS build v4.0.0-749-gc9e567da3747 ***
Hello World! nucleo_l496zg/stm32l496xx

This change set also includes updates to jlink and openocd west runners to add an --rtt-quiet option. The new option suppresses the stdout and stderr of subprocesses (e.g. JLinkRTTLogger or openocd), which is the expectation for --device-serial-pty scripts. By suppressing unnecessary output, we can leverage west rtt in an automatically generated shell script (as opposed to importing or duplicating more python code in twister).
Currently, the only other RTT-capable west runner is pyocd.
Additionally, the DeviceHandler.handle() method of handler.py is a bit tricky to work with; I was unsuccessful in making separate methods for _do_flash() and _do_serial() portions of the operation. That would have simplified the --flash-before logic. Python was throwing exceptions claiming that code was attempting to adjust objects shared between processes without synchronization. At some point, the handle() method should probably be refactored, but it was considered beyond what was necessary for the first draft of this PR.

@topisani - it would be great if you could try this out as well.

Oh wow - the bot made a lot of review requests 😅

switched to using the already-resolved runner variable instead of pulling it out of self.options.west_runner exclusively, since the --hardware-map option can also be used to provide the runner

replaced self.rtt_port = rtt_quiet with self.rtt_quiet = rtt_quiet in jlink.py


document selector is just strings

I can't register for a pattern etc

I'm trying to add language server support for various flavours of YAML files: Spring Boot application properties YAML, Cloud Foundry application deployment manifest YAML etc. Each of these different flavours of YAML should get its own validation/reconciling, content assist, hovers etc.
The only way to accomplish this is pass documentSelector parameter with DocumentFilter object that has a pattern property such that i can at least provide differrent YAML support for different YAML file names. LanguageClientOptions only accepts string|string[] :-(
Should be relatively straight-forward to make LanguageClient support documentSelector with DocumentFilter values... In fact all features are supported already except for doc changes synchronization code.
Any chance this can be fixed soon?

A started to work on this in master.

This got addressed in 3.0.x


Remove binary-specific functions from tile.h

https://github.com/bespoke-silicon-group/bsg_f1/blob/45a6bc160f40c3f392d220f7be77c8bc8a0cd64f/cl_manycore/libraries/bsg_manycore_tile.h#L155
Since these are relevant to CUDA-Lite, I think they would be better to maintain in the cuda files.
tile.h just abstracts the configuration of a tile, and to me, it feels weird to have functions that require a CUDA binary.
@max-ruttenberg, Your thoughts?

I don't know... set_origin_registers seems reasonable to have in it's current header. In general, I'm all for having a few small header files with descriptive names than one monolithic header. The functions for setting symbol values in the program seem pretty CUDA specific? @bornaehsani Do only CUDA programs have those symbols in the binary?

Oops, I meant the functions like:
https://github.com/bespoke-silicon-group/bsg_f1/blob/45a6bc160f40c3f392d220f7be77c8bc8a0cd64f/cl_manycore/libraries/bsg_manycore_tile.h#L174
(Which @max-ruttenberg correctly referenced)

Addressed in PR #275 .


AnimationController FPS mismatch between forward and repeat on some devices

Hi.
I'm creating a simple AnimationController using
_animCtrl = AnimationController(vsync: this, duration: Duration(milliseconds: 500));
_anim = Tween(begin: Offset(-x, 0.0), end: Offset(x, 0.0))
.animate(CurvedAnimation(parent: _animCtrl, curve: Curves.easeIn));
And using in a SlideTransition for a simple horizontal movement of a small colored container.
The animation is triggered by a button that calls _animCtrl.reset() and then _animCtrl.forward(from: 0);
This works perfectly on a samsung S9 and on an iphone 11
But when testing on a xiaomi phone I observe a strange behavior
If instead of using _animCtrl.forward() I use _animCtrl.repeat(), the animation works perfectly and smoothly.
If I keep using forward(), the timing is way off. I need to set a Duration of more than 5000 miliseconds in the controller creation to see anything. Any value below that is too fast and often results in only the first and last values produced by the controller.
It's as if, on xiaomi, the timer/ticker used when using forward is different than the timer used when using repeat().
For now, the only way I could find to solve this issue is by always doing a repeat and listening to value events on the controller, stopping the controller when reaching the end. Not an elegant solution but it works.
Is there indeed a difference in how forward and repeat are implemented regarding how they read the internal phone clock?
Flutter doctor output:
[✓] Flutter (Channel stable, 2.0.6, on Microsoft Windows [Version 10.0.19042.928], locale en-US)
• Flutter version 2.0.6 at C:\somepath
• Framework revision 1d9032c7e1 (3 days ago), 2021-04-29 17:37:58 -0700
• Engine revision 05e680e202
• Dart version 2.12.3
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at C:\Users\UUUUUU\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.2
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[✓] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[✓] Android Studio (version 4.1.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[✓] VS Code, 64-bit edition (version 1.55.0)
• VS Code at C:\Program Files\Microsoft VS Code
• Flutter extension version 3.21.0
[✓] Connected device (2 available)
• Redmi Note 7 (mobile) • XXXXXXX • android-arm64  • Android 10 (API 29)
• Chrome (web)          • chrome  • web-javascript • Google Chrome 90.0.4430.93
• No issues found!

Hi @itamardo
Can you please provide a minimal complete reproducible code sample?
A visual example of what you described would help identify the issue better in this case.
Thank you

Thanks @pedromassangocode but I just solved the issue. Quite simple, I probably missed this somewhere in the docs.
Looking at the forward() code implementation in animation_conmtroller.dart I saw this code piece:
TickerFuture _animateToInternal(double target, { Duration? duration, Curve curve = Curves.linear }) {     double scale = 1.0;     if (SemanticsBinding.instance!.disableAnimations) {       switch (animationBehavior) {         case AnimationBehavior.normal:           // Since the framework cannot handle zero duration animations, we run it at 5% of the normal           // duration to limit most animations to a single frame.           // TODO(jonahwilliams): determine a better process for setting duration.           scale = 0.05;           break;         case AnimationBehavior.preserve:           break;       }     }
which made me realize that my xiaomi is probably just configured to disable animations, and that 0.05 scale sounds a match to what I observed.
the solution, therefore, was to add animationbehavior to the controller creation like so:
_animCtrl = AnimationController(vsync: this,
animationBehavior: AnimationBehavior.preserve,
duration: Duration(milliseconds: 500));
thanks


Add username's file

created a branch, created a file and made a commit, and opened a pull request

I'm unsure how to resolve a conflick


Kwxm/spec/no flat for bls

This updates the specifcation to reflect the changes made in #5663, where we removed direct serialisation of the BLS12-31 G1 and G2 element types.  The main changes are in Note 4 on pages 38-39 and Section C.3.4 on pages 55-56.  There's a bit of repetition, but I thought that would probably make it more obvious what was going on.  I'll follow this up shortly with a separate PR to add the concrete syntax for lists/pairs/data.
Rendered version: plutus-core-specification.pdf

I'll just merge this: it's not very complicated and the reviewers are on holiday.


fix filename

I modified filename.
bechmark_test.go -> be"n"chmark_test.go
Note:
If the patch is merged, we need to use --follow option to see older commit.
$ git log --follow benchmark_test.go

LGTM ! Thanks !


Improve documentation on deploying custom TinyWebDB

Reported on the forum: Google has deprecated the GAE toolkit for deploying apps and preferring that people use the Google Cloud Platform CLI. We should update the instructions to this preferred method.

@ellelili2025 I know you were working on this. Do you have a status update? See also this note from the community site: https://community.appinventor.mit.edu/t/problem-with-tinywebdb/1369/5?u=ewpatton

@ewpatton I already had a pull request ready for review

PR is at appinventor.mit.edu/gb/mit-cml/website/pull/23

@ewpatton PR has been updated with python 3.


Clearer documentation on the asset library / git master file difference & plugin update procedure

I just downloaded 1.4 and 1.3 for windows and linux and in the zip file I found a Qodot executable.
As far I understand you do not even have to have separated OS downloads.
P.S. I tried to download master but for some reason the folders outside of the dir addon are not included and master requires them. If you need textures like the standard one in the plugin keep it in the addon dir.
Great job by the way, thanks.

Looks like that I was wrong. The addon is in src download.

Yeah, it's set up that way to keep the core addon light and make sure the asset library distribution isn't bloated with example content (scenes, textures, etc) that the user may not need.
I'll make this more clear in the documentation, and add a note about deleting the plugin before updating- a few users have been tripped up by that now.

This is done:
https://github.com/ShiftyAxel/Qodot/wiki/Installation


Multi-OS images via manifest property

I would like to present a proposal to provide multi-OS images via manifest. We had a chat regarding this but I would like to register this request here, on the place where it should be.
Expected Behavior
It would be nice to be able to reference images without having to specify OS relationship in the tag. That would dramatically simplify the usage of the images for us, partners, customers, and end-users.
We would be able to run the following commands independently on OS host (let's say WinServer 2016 or WinServer 2019 etc.):
docker pull mcr.microsoft.com/businesscentral/onprem:2004-w1
docker pull mcr.microsoft.com/businesscentral/onprem:2004-dk
docker pull mcr.microsoft.com/businesscentral/onprem:2004-cu1-dk

Actual Behavior
Today we have to consider what OS we are going to use (which might be uncertain if we run some sort of orchestrated environment - e. g. Docker Swarm cluster with multiple nodes on different versions of OS):

WinServer 2016:

docker pull mcr.microsoft.com/businesscentral/onprem:2004-w1-ltsc2016
docker pull mcr.microsoft.com/businesscentral/onprem:2004-dk-ltsc2016
docker pull mcr.microsoft.com/businesscentral/onprem:2004-cu1-dk-ltsc2016

WinServer 2016 alternative (which isn't very OK from my perspective - the tag should be mandatory if the image is for a specific OS version only):

  docker pull mcr.microsoft.com/businesscentral/onprem:2004-w1
  docker pull mcr.microsoft.com/businesscentral/onprem:2004-dk
  docker pull mcr.microsoft.com/businesscentral/onprem:2004-cu1-dk

WinServer 2019:

docker pull mcr.microsoft.com/businesscentral/onprem:2004-w1-ltsc2019
docker pull mcr.microsoft.com/businesscentral/onprem:2004-dk-ltsc2019
docker pull mcr.microsoft.com/businesscentral/onprem:2004-cu1-dk-ltsc2019

Motivations

Generally, a radical simplification when working with images (tags). We might focus only on relevant aspects related to NAV/BC releases (major, cu, country etc.).
This is especially needed in order to be able to work properly with multiple OS without any additional logic being added (which isn't necessary IMO).

Details

My suggestion is based on multi-arch approach existing for a long time in Docker.
There is a possibility to use it also to distinguish between OS versions, not only to identify platforms. More can be found e. g. here - multi-win-version-aspnet.
A demonstration of how do the image tags look like can be seen here - multi-win-version-aspnet/tags.
The best is that the cost is very low (almost nothing).
It's easy to create a manifest. The only problem is that the command itself is still hidden in experimental features:

https://docs.docker.com/engine/reference/commandline/manifest/
https://github.com/docker/cli/pull/1355
I was able to create manifest in a few seconds but I can't (of course) upload it to your repo :):

docker manifest create mcr.microsoft.com/businesscentral/onprem:1910-es-multi mcr.microsoft.com/businesscentral/onprem:1910-es-ltsc2016 mcr.microsoft.com/businesscentral/onprem:1910-es-ltsc2019

And the content is:
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 8342,
         "digest": "sha256:c11670cea7a9263b706a2bc0869a992c1e15cbb37b7526e6dd9792aa3742c75f",
         "platform": {
            "architecture": "amd64",
            "os": "windows",
            "os.version": "10.0.14393.3443"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 8342,
         "digest": "sha256:ea5ad7a924d90ea51f94bc87721ac9e01201943cebef029e307a8b9589474722",
         "platform": {
            "architecture": "amd64",
            "os": "windows",
            "os.version": "10.0.17763.973"
         }
      }
   ]
}

The downside I can see is the fact we can't use no-ltsc tag as this means to use LTSC2016 today. We would need to use e. g. -multi postfix instead to use automatic assignation.

  docker pull mcr.microsoft.com/businesscentral/onprem:2004-w1-multi
  docker pull mcr.microsoft.com/businesscentral/onprem:2004-dk-multi
  docker pull mcr.microsoft.com/businesscentral/onprem:2004-cu1-dk-multi

Thanks for this suggestion - I will definitely have a look at this.

Hello @freddydk, please, have you been able to check this issue?

Not yet - within the next 1-2 weeks hopefully

OK, thanks.

An example

I tag MS images as our internal images and push to the registries (acr). This is where experimental features features must be enabled for Docker CLI.
Then I create manifest and push it to the registries.
Since then I can reference only the manifest (it's like a tag) from different OS versions (used process isolation only).

One "common image", scheduled two replicas. The first one created on DockerHost01 which is hosted by WinServer2016 and the second one on DockerHost03 which is running on WinServer2019:

Hello @freddydk. Please, do you have any plans for this topic? We use this approach very successfully (OS version transparent) so I could tell it's a very nice and important improvement (at least for us but I believe anyone could benefit from it).
As I mentioned somewhere above, for us the biggest "trouble" here is the fact we need to re-tag your images and push them to our repo (registries) in order to be able to create multi-os manifest (it's not possible for foreign images).
I believe, for you (Microsoft) it will be very easy to add this multi-os manifest and this would save us a lot of data (or anyone else willing to use the same approach). And also for you, there is no harm, it's just an additional piece of info so it shouldn't break down the existing stuff.

Closing the case as it's been there for a very long time and no activity.


release 1.12.0

Description
Prepare release 1.12.0
Checklist

[x] My changes follow the contributing guidelines of this project.
[x] I have performed a self-review of my code.
[x] I have made corresponding changes to the documentation.
[x] I have added tests that prove my fix is effective or that my changes work.
[x] New and existing unit tests pass locally with my changes.

Coverage remained the same at 95.132% when pulling 01d8cadf0077e66db3862ac08cc4ae8409cdce0f on release/1.12.0 into 9a8b0e007f4ad4e647c3a9c02b4ff8ea7128ee0b on main.


Error if image in list name

Getting error while loading boards if there is an image (icon) in any of the lists name
OperationalError: (1366, "Incorrect string value: '\\xF0\\x9F\\x93\\xB1' for column 'name' at row 1")

Hi Mudasir
I'm going to take a look as soon as I can.
Thank you for the report.

Hi Mudasir.
I was not aware that Trello allowed images in list names. Are you using a powerup?

I tried fixing it with a hacky way by adding a custom Save method in Lists model under app/board and doing self.name.decode('utf-8').

I think that you need to set your columns in your DBMS to utf8_general_ci. Are you using other encoding in your columns?

I'm closing this issue because there was no activity for more than 3 months.


python realchecker.py not working

python: can't open file 'realchecker.py': [Errno 2] No such file or directory

lol dude

lol dude


Some Reddit videos fail to download

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
Ireland
Provide a description that is worded well enough to be understood
Most Reddit videos work fine, but some don't. At a quick glance, the commonality is that it's a GIF image which Reddit has converted to video themselves. This video actually was very easy to download in the browser, because it's a normal  tag with a normal src attribute, which seems to point directly to an MP4 file. I didn't try that initially, because yt-dlp usually works better for Reddit videos.
Note: The example I've got is NSFW. Sorry about that.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-Uv', 'https://www.reddit.com/r/gayporndaily/comments/137xou6/anyone_has_seen_this_recently_the_transition_is/']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds [a9f85670d] (zip)
[debug] Python 3.12.3 (CPython x86_64 64bit) - Linux-6.8.0-48-generic-x86_64-with-glibc2.39 (OpenSSL 3.0.13 30 Jan 2024, glibc 2.39)
[debug] exe versions: ffmpeg 6.1.1 (setts), ffprobe 6.1.1
[debug] Optional libraries: Cryptodome-3.20.0, certifi-2023.11.17, requests-2.31.0, secretstorage-3.3.3, sqlite3-3.45.1, urllib3-2.0.7
[debug] Proxy map: {}
[debug] Request Handlers: urllib
[debug] Loaded 1838 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp-nightly-builds/releases/latest
[debug] Downloading _update_spec from https://github.com/yt-dlp/yt-dlp-nightly-builds/releases/latest/download/_update_spec
[debug] Downloading SHA2-256SUMS from https://github.com/yt-dlp/yt-dlp-nightly-builds/releases/download/2<IP_ADDRESS>010/SHA2-256SUMS
Current version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds
Current Build Hash: 6540c6e222318a85a7f254e6871a0d473b00411aa4f2bb734565dae9be405c7e
Updating to<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds ...
[debug] Downloading yt-dlp from https://github.com/yt-dlp/yt-dlp-nightly-builds/releases/download/2<IP_ADDRESS>010/yt-dlp
Updated yt-dlp to<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds
[debug] Restarting: python3 /usr/local/bin/yt-dlp -Uv https://www.reddit.com/r/gayporndaily/comments/137xou6/anyone_has_seen_this_recently_the_transition_is/
[debug] Command-line config: ['-Uv', 'https://www.reddit.com/r/gayporndaily/comments/137xou6/anyone_has_seen_this_recently_the_transition_is/']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds [d8fb34908] (zip)
[debug] Python 3.12.3 (CPython x86_64 64bit) - Linux-6.8.0-48-generic-x86_64-with-glibc2.39 (OpenSSL 3.0.13 30 Jan 2024, glibc 2.39)
[debug] exe versions: ffmpeg 6.1.1 (setts), ffprobe 6.1.1
[debug] Optional libraries: Cryptodome-3.20.0, certifi-2023.11.17, requests-2.31.0, secretstorage-3.3.3, sqlite3-3.45.1, urllib3-2.0.7
[debug] Proxy map: {}
[debug] Request Handlers: urllib
[debug] Loaded 1837 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp-nightly-builds/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds)
[Reddit] Extracting URL: https://www.reddit.com/r/gayporndaily/comments/137xou6/anyone_has_seen_this_recently_the_transition_is/
[Reddit] 137xou6: Downloading JSON metadata
[generic] Extracting URL: https://i.redd.it/q7x461z6twxa1.gif
[generic] q7x461z6twxa1: Downloading webpage
[redirect] Following redirect to https://www.reddit.com/media?url=https%3A%2F%2Fi.redd.it%2Fq7x461z6twxa1.gif&rdt=33670
[generic] Extracting URL: https://www.reddit.com/media?url=https%3A%2F%2Fi.redd.it%2Fq7x461z6twxa1.gif&rdt=33670
[generic] media?url=https://i.redd.it/q7x461z6twxa1: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] media?url=https://i.redd.it/q7x461z6twxa1: Extracting information
[debug] Looking for embeds
ERROR: Unsupported URL: https://www.reddit.com/media?url=https%3A%2F%2Fi.redd.it%2Fq7x461z6twxa1.gif&rdt=33670
Traceback (most recent call last):
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1624, in wrapper
    return func(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1759, in __extract_info
    ie_result = ie.extract(url)
                ^^^^^^^^^^^^^^^
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 742, in extract
    ie_result = self._real_extract(url)
                ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/generic.py", line 2553, in _real_extract
    raise UnsupportedError(url)
yt_dlp.utils.UnsupportedError: Unsupported URL: https://www.reddit.com/media?url=https%3A%2F%2Fi.redd.it%2Fq7x461z6twxa1.gif&rdt=33670

I should have checked the preview before posting.
I was trying to say that the video turned out to be easy to download in the browser, because it's a normal <video> tag with a normal src attribute pointing to an MP4 file, so the browser's context menu allows downloading. I didn't try that initially, because most Reddit videos are not like this, and yt-dlp is usually the easiest way to download them.


[Question] Is there a way to use the manual :show option with automatic closing?

The Popper is nice, simple and works well. However I'm now using it in a project that requires manual opening of the Popper while retaining the automatic closing (especially the click outside) functionality.
When I use the sample code for manually opening the click out side doesn't work anymore. Reviewing your code showed that using the 'show' flag puts the component in manual mode. I tried to trick by setting the show = null in the onOpen event, but that results in a lot of warnings on the onMount and onBeforeMount.
TLDR: Can I retain automatic closing with manual showing?

This is related to #43, I need to look into refactoring so that you can have both manual and dynamic modes at the same time.

Great it has your attention, let me know if I can be of any assistance

I came here to create the same issue.
I looked into the src code and it would already help if you export useClickAway so that we can close the popper manually.


Modifying flow of getDeploymentIps to fetch IPs from ApiServer

To introduce resiliency in bind/unbind during bosh outage, we store deployment IPs (which are needed during bind/unbind) in etcd. (Separate PR for this coming once https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/426 merges).

This PR adds modifications in getDeploymentIps flow to utilize entries in etcd. Now the flow in getDeploymentIps will be local_cache --> etcd --> bosh.

Failures while getting/updating resource from/to etcd can be ignored to not alter the flow of parent operation as IPs could still be obtained from bosh.

Added "DO_NOT_MERGE" because PR for adding deployment IPs in deployment resource while create/update is not raised. Its unsafe to include flow without that information.

Pull Request Test Coverage Report for Build 1856

34 of 34 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.05%) to 88.17%

Files with Coverage Reduction
New Missed Lines
%

broker/lib/fabrik/DBManager.js
1
98.86%

Totals

Change from base Build 1844:
0.05%

Covered Lines:
8042

Relevant Lines:
8829

💛  - Coveralls


[C++] Fix documentation on Newly Added Methods on ExecPlan

Describe the bug, including details regarding any error messages, version, and platform.
We see the following error in the CIs : https://github.com/apache/arrow/pull/33623#issuecomment-1381326714
/arrow/cpp/src/arrow/compute/exec/exec_plan.h:427: error: The following parameter of arrow::compute::DeclarationToTable(Declaration declaration, bool use_threads=true, MemoryPool *memory_pool=default_memory_pool(), FunctionRegistry *function_registry=NULLPTR) is not documented:
  parameter 'declaration' (warning treated as error, aborting now)

Component(s)
C++

take

I am removing my assignment, since I am mostly maintaining Arrow Java.


Bug: typo error when creating a model using php spark make:model

Describe the bug
The command line php spark make:model creates a Model File with the propertie $useSoftDelete in singular, when the correct way is in the plural, like this:
$useSoftDeletes
Because of this, that feature does not work when deleting records.
CodeIgniter 4 version
4.1.1
Expected behavior, and steps to reproduce if appropriate
$useSoftDeletes
Context

OS: [e.g. Windows 10]
Web server [e.g. 2.4.46]
PHP version [e.g. 7.3.21]

It seems already fixed in latest develop https://github.com/codeigniter4/CodeIgniter4/pull/4319


cleanup for orphaned volumes of cinder csi

Discussed in https://github.com/theopenlab/openlab/issues/746
This PR runs a job periodically to remove orphaned volumes created by
cinder csi. Post cleanup jobs directly on the real test jobs are not
robust enough in cases of e.g. timeouts or random crashes.

@bzhaoopenstack please take a look at this one. This need a zuul restart as well IMO


Fix updating deps for mercurial

/cc @sttts
missing piece from https://github.com/openshift/library-go/pull/219

/lgtm


Code blocks are not rendered correctly

See http://learndiscourse.org/install-a-plugin/
Newlines in the code block are collapsed. Something is different in how the markdown is converted on Discourse vs Jekyll.

CSS needs something like white-space: pre;. And Kramdown might not handle syntax highlighting in fenced code blocks?

Fixed but still needs syntax highlighting and some styling though.


[WIP] feat(iroh-net): PCP/NAT-PMP

Description
Implement probing and mapping for PCP/NAT-PMP
Notes & open questions
TBD
Change checklist

[ ] Self-review.
[ ] Documentation updates if relevant.
[ ] Tests if relevant.

I'm going to split this PR in four because it's way too big. After splitting the first one and doing the work of splitting the second one found a bug, so definitely this split helps with doing proper reviews


remove fastembed

This PR removes Fastembed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.13%. Comparing base (2d8e5a2) to head (7169701).
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   74.36%   74.13%   -0.23%
==========================================
  Files          32       31       -1
  Lines        1728     1678      -50
==========================================
- Hits         1285     1244      -41
+ Misses        443      434       -9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ci: use GitHub only release

Description
A Maven release does not work here as the pom.xml is incomplete and the release always fails. We don't want to push the template file to Maven.
A new repository using this template runs the .github/update_workflows.sh which copies the correct files.
Verification
None
Checklist

[x] My code follows the style guidelines of the project
[x] I have performed a self-review of my own code

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


UI Tests - Tests with Vega Capsule

Once Vega capsule has been integrated additional tests can be added.
Linked to: #47
Some of these include:

Validating specific blocks
Validating transactions

Transaction details
Transaction content
Return JSON

Full E2E tests for transactions currently blocked until #523 is completed


Set up CDN for media

Static files are currently being served by whitenoise directly from heroku. There are good instructions for getting set up with Amazon's CloudFront there.
We should also consider setting up CloudFront on top of the S3 bucket for uploaded media. To do that we'll need to compress all S3 files with gzip and CloudFront can handle the Accept-Encoding header.

Static and uploaded media is being served by AWS CloudFront using the domain hub-media.aashe.org.
See it in action on this page:
http://hub.aashe.org/browse/outreachmaterial/12281/State-of-Sustainability-10-Things-to-Know-About-Colorado-State-University


Error on build Laravel App On Gitlab runner

I have this error when deploy my app on Gitlab runner.
I don't know what happening and how to fix this error.
$ echo $SERVICE_ACCOUNT > /tmp/$CI_PIPELINE_ID.json
$ gcloud auth activate-service-account --key-file /tmp/$CI_PIPELINE_ID.json
Activated service account credentials for<EMAIL_ADDRESS>$ gcloud --quiet --project $PROJECT_ID app deploy app-staging.yaml --version $CI_JOB_ID
Services to deploy:
descriptor:      [/builds/quilp/dashboard-bi/app-staging.yaml]
source:          [/builds/quilp/dashboard-bi]
target project:  [dw-ghn]
target service:  [dashboard-staging]
target version:  [39753]
target url:      [https://dashboard-staging-dot-dw-ghn.appspot.com]
Beginning deployment of service [dashboard-staging]...
#============================================================#
#= Uploading 1 file to Google Cloud Storage                 =#
#============================================================#
File upload done.
Updating service [dashboard-staging]...
...............................................................................................................................................................................................................................................................................failed.
ERROR: (gcloud.app.deploy) Error Response: [9] Cloud build 8e6ed0b0-c44d-439b-b00e-c598c648d4a3 status: FAILURE.
Build error details: {"error":{"errorType":"BuildError","canonicalCode":"INVALID_ARGUMENT","errorId":"3FDF33BB","errorMessage":"INFO     FTL version php-v0.17.0\nINFO     Beginning FTL build for php\nINFO     FTL arg passed: exposed_ports None\nINFO     FTL arg passed: cache_repository asia.gcr.io/dw-ghn/app-engine-tmp/build-cache/ttl-7d\nINFO     FTL arg passed: tar_base_image_path None\nINFO     FTL arg passed: export_cache_stats False\nINFO     FTL arg passed: builder_output_path ""\nINFO     FTL arg passed: name asia.gcr.io/dw-ghn/app-engine-tmp/app/ttl-2h:5578b807-4c92-4502-8471-30621a91c96b\nINFO     FTL arg passed: ttl 168\nINFO     FTL arg passed: global_cache False\nINFO     FTL arg passed: cache True\nINFO     FTL arg passed: upload True\nINFO     FTL arg passed: sh_c_prefix False\nINFO     FTL arg passed: fail_on_error True\nINFO     FTL arg passed: base asia.gcr.io/gae-runtimes/php72:php72_20191020_7_2_23_RC00\nINFO     FTL arg passed: output_path None\nINFO     FTL arg passed: cache_key_version v0.17.0\nINFO     FTL arg passed: cache_salt \nINFO     FTL arg passed: directory /workspace\nINFO     FTL arg passed: entrypoint None\nINFO     FTL arg passed: additional_directory /.googleconfig\nINFO     FTL arg passed: destination_path /srv\nINFO     FTL arg passed: verbosity NOTSET\nINFO     starting: full build\nINFO     starting: builder initialization\nINFO     Loading Docker credentials for repository 'asia.gcr.io/gae-runtimes/php72:php72_20191020_7_2_23_RC00'\nINFO     Loading Docker credentials for repository 'asia.gcr.io/dw-ghn/app-engine-tmp/app/ttl-2h:5578b807-4c92-4502-8471-30621a91c96b'\nINFO     builder initialization took 0 seconds\nINFO     starting: build process for FTL image\nINFO     starting: rm_vendor_dir\nINFO     rm_vendor_dir rm -rf /workspace/vendor\nINFO     rm_vendor_dir stdout:\n\nINFO     rm_vendor_dir took 0 seconds\nINFO     descriptor_contents:\n{\n    "_readme": [\n        "This file locks the dependencies of your project to a known state",\n        "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",\n        "This file is @generated automatically"\n    ],\n    "content-hash": "f079fd857eddf700675808511c67fb4d",\n    "packages": [\n        {\n            "name": "dnoegel/php-xdg-base-dir",\n            "version": "0.1",\n            "source": {\n                "type": "git",\n                "url": "https://github.com/dnoegel/php-xdg-base-dir.git\",\n                "reference": "265b8593498b997dc2d31e75b89f053b5cc9621a"\n            },\n            "dist": {\n                "type": "zip",\n                "url": "https://api.github.com/repos/dnoegel/php-xdg-base-dir/zipball/265b8593498b997dc2d31e75b89f053b5cc9621a\",\n                "reference": "265b8593498b997dc2d31e75b89f053b5cc9621a",\n                "shasum": ""\n            },\n            "require": {\n                "php": "\u003e=5.3.2"\n            },\n            "require-dev": {\n                "phpunit/phpunit": "@stable"\n            },\n            "type": "project",\n            "autoload": {\n                "psr-4": {\n                    "XdgBaseDir\\": "src/"\n                }\n            },\n            "notification-url": "https://packagist.org/downloads/\",\n            "license": [\n                "MIT"\n            ],\n            "description": "implementation of xdg base directory specification for php",\n            "time": "2014-10-24T07:27:01+00:00"\n        },\n        {\n            "name": "doctrine/inflector",\n            "version": "v1.3.0",\n            "source": {\n                "type": "git",\n                "url": "https://github.com/doctrine/inflector.git\",\n                "reference": "5527a48b7313d15261292c149e55e26eae771b0a"\n            },\n            "dist": {\n                "type": "zip",\n                "url": "https://api.github.com/repos/doctrine/inflector/zipball/5527a48b7313d15261292c149e55e26eae771b0a\",\n         .
Check the build log for errors: https://console.cloud.google.com/gcr/builds/8e6ed0b0-c44d-439b-b00e-c598c648d4a3?project=1001942818469
Running after script...
$ rm /tmp/$CI_PIPELINE_ID.json
ERROR: Job failed: exit code 1

Hello @theboy412 ! Thank you for submitting this. Can you provide a little more context? Looking at the error message, nothing stands out as an obvious issue. Sharing your composer.json and app-staging.yaml would help, for starters.

Your error is No such file or directory: '""/output'
For some reason or another, laravel is trying to write to a directory /output, which doesn't exist. This needs to either be configured to be a different directory, or you can try creating that directory.

I am having a similar error, judging by the part of the build log. At least it also ends in No such file or directory: '""/output'. Closer inspection of the Cloud Build log shows this:
INFO     composer_install composer install --no-dev --no-progress --no-suggest --no-interaction
INFO     `composer_install` stdout:

   Google\Cloud\Core\Exception\BadRequestException  : {
  "error": {
    "code": 400,
    "message": "Invalid bucket name: '.appspot.com'",
    "errors": [
      {
        "message": "Invalid bucket name: '.appspot.com'",
        "domain": "global",
        "reason": "invalid"
      }
    ]
  }
}

  at /workspace/vendor/google/cloud-core/src/RequestWrapper.php:362
    358|                 $exception = Exception\ServiceException::class;
    359|                 break;
    360|         }
    361|
  > 362|         return new $exception($this->getExceptionMessage($ex), $ex->getCode(), $ex);
    363|     }
    364|
    365|     /**
    366|      * Gets the exception message.

  Exception trace:

  1   Google\Cloud\Core\RequestWrapper::convertToGoogleException(Object(GuzzleHttp\Exception\ClientException))
      /workspace/vendor/google/cloud-core/src/RequestWrapper.php:206

  2   Google\Cloud\Core\RequestWrapper::send(Object(GuzzleHttp\Psr7\Request), [])
      /workspace/vendor/google/cloud-core/src/RestTrait.php:94

  Please use the argument -v to see more details.

It seems that somehow the default project bucket is not found (Invalid bucket name: '.appspot.com'). Maybe the project id is not set in the environment of the Cloud Builder, but this should be available always.
My app.yaml contains:
  APP_STORAGE: /tmp
  APP_SERVICES_CACHE: /tmp/services.php
  APP_PACKAGES_CACHE: /tmp/packages.php
  APP_CONFIG_CACHE: /tmp/config.php
  APP_ROUTES_CACHE: /tmp/routes.php
  VIEW_COMPILED_PATH: /tmp

My composer requirements are
        "fideloper/proxy": "^4.2",
        "google/cloud-error-reporting": "^0.14.5",
        "google/cloud-logging": "^1.16",
        "google/cloud-storage": "^1.10",
        "google/cloud-tasks": "^1.3",
        "google/cloud-vision": "^0.22.5",
        "laravel/framework": "^6.3",
        "superbalist/laravel-google-cloud-storage": "^2.2"

I'm running into this exact same issue with CircleCI, so it has nothing to do with the CI/CD and is some issue with deployment.

For me the error seems to have something to do with php artisan package:discover — if I remove this from the post-autoload-dump then the build works (mind you, this breaks Laravel).

@JasonTheAdams dit you point all the paths to /tmp in your app.yaml?
  APP_STORAGE: /tmp
  APP_SERVICES_CACHE: /tmp/services.php
  APP_PACKAGES_CACHE: /tmp/packages.php
  APP_CONFIG_CACHE: /tmp/config.php
  APP_ROUTES_CACHE: /tmp/routes.php
  VIEW_COMPILED_PATH: /tmp

Deploying now is a multistage proces:

gcloud app deploy --no-promote
if the build fails (in my case due to the invalid bucket name):
2.1. remove the line "@php artisan package:discover --ansi" in composer.json
2.2. deploy again gcloud app deploy --no-promote
2.3. undo the removal in composer.json
2.4. gcloud app deploy
else promote the version (in the console)

Hardly optimal, but I have not found a better way. I have also not found why "@php artisan package:discover --ansi" has any impact on the bucket name... I am also not sure which bucket this should be, have not tested yet whether setting the --bucket flag will help. Perhaps @bshaffer knows this?


ENH: Artifact/Visualization.save() appends file extension automatically

Artifact/Visualization.save() now automatically appends the correct file extension (.qza/.qzv) if not present in the filepath that is saved to. A warning is no longer issued if the filepath doesn't have the correct extension. .save() returns the filepath that is saved to.

This looks great @jairideout! Can you open issues to update the interfaces, too (q2cli and studio)? Thanks!

Thanks @thermokarst! I created issues for the interfaces:
https://github.com/qiime2/q2cli/issues/59
https://github.com/qiime2/qiime-studio/issues/77


The Ubuntu20.04 startup Mattermost-Desktop failed

When I start mattermost-Desktop, Has been "ERROR: network_service_instance_impl. Cc (978)] Network service crashed, restarting the service." ERROR page, the program cannot be started

@lovechoudoufu Are you running the application as root? There's an issue running sandboxed Electron applications under root.

Yes, thank you