How can you see the source with the tracing extension?

I see the following code is intended to record the redacted GraphQL query, which is great!
https://github.com/async-graphql/async-graphql/blob/7162bf8aa4601daf07dd510bfe119087f43d8b29/src/extensions/tracing.rs#L84-L100
How can I actually see it?
Currently I'm just using a basic tracing_subscriber::fmt::Layer. I don't see the span at all. I believe this subscriber only outputs events (including current metadata from their spans), not span start/end. There's no event in this span after source is recorded, and probably none before either (unless next creates one).
    // Send formatted tracing messages to stdout, respecting RUST_LOG.
    let subscriber = tracing_subscriber::registry().with(
        tracing_subscriber::fmt::Layer::new()
            .with_filter(tracing_subscriber::EnvFilter::from_default_env()),
    );
    tracing::subscriber::set_global_default(subscriber).map_err(|e| err!(Unknown, source(e)))?;

But even if I were using something else, I'm not sure I'd see it, given that tracing::span::Span::record says the following:

Note: The fields associated with a span are part of its Metadata. The Metadata describing a particular span is constructed statically when the span is created and cannot be extended later to add new fields. Therefore, you cannot record a value for a field that was not specified when the span was created:

So does this work at all? I suspect not and think it needs at least a source = tracinglib::field::Empty added to the span! for some subscriber that pays attention to span start/end (probably the opentelemetry one? I'll likely add that before long) to do anything with it. But I think tracing_subscriber::fmt::Layer use (or similar log output) is common, and I wonder if it'd be better to do an info! with the source.

I believe [tracing_subscriber::fmt] only outputs events (including current metadata from their spans), not span start/end.

Ahh, you can change this by throwing in e.g. .with_span_events(FmtSpan::ACTIVE). If you do so, you see the exit event with no source:
2022-12-08T20:12:35.144034Z  INFO request{method=POST uri=/graphql version=HTTP/1.1}:request:parse: async_graphql::graphql: enter
2022-12-08T20:12:35.145340Z  INFO request{method=POST uri=/graphql version=HTTP/1.1}:request:parse: async_graphql::graphql: exit

If you add source = tracinglib::field::Empty to the span! invocation above, it looks better:
2022-12-08T20:14:54.362175Z  INFO request{method=POST uri=/graphql version=HTTP/1.1}:request:parse: async_graphql::graphql: enter
2022-12-08T20:14:54.363740Z  INFO request{method=POST uri=/graphql version=HTTP/1.1}:request:parse{source="..."}: async_graphql::graphql: exit

so yeah, this is broken currently. It at least needs that change.
I think .with_span_events is global (the filter applies, but there's not a distinct one from events) and quite noisy. IMHO, it'd be better to log an event with the source than require the caller enable this.

While I'm here talking about this extension: the fields spans are also pretty spammy:

The path is quite redundant when it's nested deeply; it's nicer to just have each child span show the segment name rather than the complete path, e.g.:

        let span = if !info.is_for_introspection {
            Some(match info.path_node.segment {
                QueryPathSegment::Index(index) => info_span!("field", index),
                QueryPathSegment::Name(name) => info_span!("field", name),
            })
        } else {
            None
        };

If a deeply nested field returns error, you see the same error at every level. It'd be nice to log it right away with the path to the closest nullable span, then have the ones through that stop if they start with it. But AFAICT, with the current interface, you'd need to keep track of all the nullable fields ahead of time (by looking for a ! at the end of the type name). It'd be nice to only mutate a context object when an error actually happens, but there you don't have access to the types of all the ancestors.


A11y_AzureDataStudio_Connect to a SQL Server_Usability: Screen Reader is not announcing the status of a server is connected successfully or not

GitHub Tags:
#A11yUsable; #A11yTCS; #A11ySev2; #DesktopApp; #BM-AzureDataStudio-Win32-Feb2022; #Azure Data Studio; #WCAG4.1.3; #Win32; #AINotInScope; #Status Messages; #Narrator;
Environment Details:
Windows Version :Windows 11 Enterprise
Application name :Azure Data studio
Repro Steps:
1.Turn on Narrator
2. Launch Azure Data Studio.
3. Select the Connections icon (if not already selected) from left bar.
4. Hover over the 'Servers' header and select the 'New Connection' icon.
5. Provide server and windows authentication details, then click 'Connect'.
6. Validate in left menu that server has been successfully connected.
7. Verify status messages after the server is connected successfully is announced by narrator or not .
Note:
Similar issues can be observed in the following in the following:

Delete.
Conformation.

Actual Result:
Screen Reader is not announcing the status of a server is connected successfully or not.
Expected Result:
Screen Reader should be announced the status of a server is connected successfully .
Attachment:

Accessibility issue for extensions should be filled in the repository of the extension. Once that is done the extension author should investigate and file an issue in VS Code using proper description of our components. Thanks!


Make width of CMS modal dialog popus configurable

Description
On opening a plugin in the structure editor, all modal dialog popups are rendered 850 pixels wide.
This hard-coded setting may not be suitable for everybody. I therefore made it configurable.
Related resources
No issue provided.
Checklist

[x] I have opened this pull request against develop
[x] I have updated the CHANGELOG.rst
[x] I have added or modified the tests when changing logic

since it just is an additional configuration settings, I'm using the current test with their defaults.

@jrief can you help rebasing to resolve conflicts so we can merge this?


[Feature request]

Platforms
Android
Description
AssetEntity.latlngAsync always return zero for video,  ExifInterface just support images format. If location is needed, MediaMetadataRetriever should be used.
Why
I want extract location for video.

AI Summary: The user requests a feature to extract location data from videos on Android, as the current AssetEntity.latlngAsync method only works for images.


#33636 New feature / Added ModelBulkProcessMixin for convinient bulk create/update and min…

Added ModelBulkProcessMixin for convinient bulk create/update and minimize memory usage.
`        """
class BulkyModel(models.Model, ModelBulkProcessMixin):
id = models.BigAutoField(primary_key=True)
name = models.CharField(max_length=10, null=False)
    With ModelBulkProcessMixin , We could minimize memory usage.
    Without ModelBulkProcessMixin, We shold maintain bulk array size up to 100_000
    or manually maintain arraysize up to batch_size like 10_000

    if len(chunked_list)>10_000:
        Model.objects.bulk_create(chunked_list)

    and check remain in list again at the end.

    if len(chunked_list)>0:
        Model.objects.bulk_create(chunked_list)
    """

    names = [f"name-{num}" for num in range(100_000)]

    with BulkyModel.gen_bulk_create(batch_size=10_000) as bulk:
        for name in names:
            bulk.add(BulkyModel(name=name))

    self.assertEqual(100_000, BulkyModel.objects.all().count())`

sorry test failed.


Added a renderingContext field for valueGetter functions

This allows different cell contents depending on where the value is rendered. As an example, I can render some HTML with a link displaying the table online and plain text for exporting to CSV.

I had this very same requirement and I didn't see any other way to achieve the goal. I tested it also in my project and it works as expected.

hi @gastonelhordoy, thanks for the PR, if i understand you correctly, then i don't agree with the implementation.
the valueGetter is responsible for returning the value.
for rendering, that's where the cellRenderer comes into play.
so what i would expect, is your valueGetter to return a raw value (not formatted in any way) which gets used in csv. if you want it rendered a certain way in your grid, then you should use cellRenderer.
or maybe i misunderstood something, happy to have you explain if i did :)
thanks,

Hey @ceolter, thanks for pointing me out to the cellRenderer feature, somehow I completely overlooked it. Since that's exactly what I was looking for, I'm discarding this PR.
Cheers


Duality of XXXXResponse StatusCode and CosmosExceptions

A number of SDK calls return a 'response' object. And it isn't explicitly clear from the documentation of the call when or if the response object should be (also) used to check the success/failure of a request or if the lack of an exception is the sole indication of success.
e.g. Container's DeleteContainerAsync returns a ContainerResponse.
ContainerResponse has a number of fields with no description (can this be fixed please?).
Once such field is the StatusCode property. One might assume you should check the http status of the request
But then there's also mention of CosmosException which could be thrown, but only mentions one status code 404 - what if there's a different error - will it be in the exception or the container response? Is it a case of the table is missing other status codes?
Can the documentation make a distinction please?
Peaking at the code, It might be as simple as improving the 'return' doc to say the ContainerResponse is only returned for success http status codes / Rewording the CosmosException description so we understand that is is only thrown if the http status code does't indicate success

Hi @Camios,
Please check out the new exception documentation. The status code on the response is used for very success scenarios. For example CreateIfNotExists will allow you to determine if it the resource was created or if it already existed.

I added more documentation in PR #1638


Ubuntu 20.04 - 20221012 release

Description
Some of the github actions I have in my repository that with run-on ubuntu-latest started to pick up the newer runner version: 20221012.
and it started to fail the bash command step which has no problem when it uses runner version of 20221002.
Below is the log from the "setup job" step:
Current runner version: '2.298.2'
Operating System
Ubuntu
20.04.5
LTS
Runner Image
Image: ubuntu-20.04
Version: 20221012.1
Included Software: https://github.com/actions/runner-images/blob/ubuntu20/20221012.1/images/linux/Ubuntu2004-Readme.md
Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu20%2F20221012.1
Both "Included Software" and "Image Release" links don't work.
Looks like this PR was never merged but the branch was deleted? https://github.com/actions/runner-images/pull/6394
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 18.04
[X] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Image: ubuntu-20.04
Version: 20221002.2
Is it regression?
yes
Expected behavior
I expect the "Included Software" and "Image Release" links to be working so I can see what was actually included in the new runner version release.
Actual behavior
Github action - setup job is picking up the Ubuntu 20.04 - 20221002.2 however I can't find the release docs
Repro steps

Trigger any github action with the runs-on configuration with ubuntu-latest, see if the runner version picks up Ubuntu 20.04 - 20221002.2.
Try access the "Included Software" and "Image Release" links from the setup job step.

Same for us, we have some python scripts what run smoothly with version 20221002 but failed with version 20221012

Hey @AnnaMChoi-CD.
We will take a look at it.

This also hit our workflows and resulted in a terraform version mismatch between 20221002.2 and 20221012.1 (terraform versions 1.3.1 and 1.3.2 respectively).

We also see issues with 20221012.1. Exact same git commit was ok on 20221002.2 just 12h ago.
We have strange issues with maven-jib-plugin in  java build:
Error:  Failed to execute goal com.google.cloud.tools:jib-maven-plugin:3.3.0:build (default-cli) on project dpost-engine: loader constraint violation: when resolving method 'org.apache.commons.compress.compressors.CompressorInputStream org.apache.commons.compress.compressors.CompressorStreamFactory.createCompressorInputStream(java.io.InputStream)' the class loader org.codehaus.plexus.classworlds.realm.ClassRealm @4438b862 of the current class, com/google/cloud/tools/jib/cache/CacheStorageWriter, and the class loader org.codehaus.plexus.classworlds.realm.ClassRealm @5b12012e for the method's defining class, org/apache/commons/compress/compressors/CompressorStreamFactory, have different Class objects for the type org/apache/commons/compress/compressors/CompressorInputStream used in the signature (com.google.cloud.tools.jib.cache.CacheStorageWriter is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @4438b862, parent loader 'bootstrap'; org.apache.commons.compress.compressors.CompressorStreamFactory is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @5b12012e, parent loader 'bootstrap') -> [Help 1]

Having some issues with the new image as well, different version of Azure CLI it seems between 20221002.2 and 20221012.1, and we can't really "fix" the code that calls the CLI as we don't know which version of the runner image we'll get.
Interesting part also is that it seems that this version doesn't officially exists https://github.com/actions/runner-images/releases/tag/ubuntu20%2F20221012.1

The Ubuntu 20.04 - 20221012 release was cancelled, the https://github.com/actions/runner-images/pull/6433 new image is on track.


ADVI needs refactoring and unit tests

To be overhauled in a pull request.

@dustinvtran This should be two (or more) issues: (1) specific refactoring(s) and (2) unit tests.  For the latter, list what's necessary.


fix(parser): fix additional char being consumed in JSXText

In its current implementation, the first char of a JSXText will be lost.

How did you find this? Can I know what you are working on with oxc 😁
You can remove the test by the way. It's all good if cargo coverage passes.

I was trying oxc lint on some random projects. Actually I found this bug when I was debugging another bug.

Thank you for the contribution @yesmeck !


browser-sync 关闭 logSnippet

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fixing issue 731 & 408

+1

Does this fix #725 too?

Hey guys, what is the status on this? Looks like the pull request was never approved. Are you running this code with success?

This seems to be about sharding and multinode setups?


Event Listener and Report output incorrect or nunit2 test runs

When I'm running nunit2 tests using the nunit v2 framework driver - the console outputs the correct number of passes and failures, but the XML sent to both the Event Listener and the xml result output is incorrect.
For example:
I have 3 tests which output:
Test Run Summary
Overall result: Failed
Test Count: 3, Passed: 1, Failed: 2, Warnings: 0, Inconclusive: 0, Skipped: 0
Failed Tests - Failures: 1, Errors: 1, Invalid: 0
The TestResults.xml file reports:
<test-run id="2" testcasecount="3" result="Failed" total="3" passed="0" failed="0" inconclusive="0" skipped="0" asserts="0" engine-version="<IP_ADDRESS>" clr-version="4.0.30319.42000" start-time="2017-07-19 12:06:05Z" end-time="2017-07-19 12:09:15Z" duration="190.467029">

The Event Listener XML is the same:
<test-run id="2" testcasecount="3" result="Failed" total="3" passed="0" failed="0" inconclusive="0" skipped="0" asserts="0" engine-version="<IP_ADDRESS>" clr-version="4.0.30319.42000" start-time="2017-07-18 14:12:58Z" end-time="2017-07-18 14:16:08Z" duration="190.485957">

Interestingly, if I use the legacy nunit2 report format, the TestResults.xml file outputs correctly:
<test-results name="D:\MS\test-apps\Xamarin.NUnit2.Tests\bin\Debug\Xamarin.NUnit2.Tests.dll" total="3" errors="1" failures="1" not-run="0" inconclusive="0" ignored="0" skipped="0" invalid="0" date="2017-07-19" time="12:44:44">

Let me know if this issue is better placed in the main nunit3 repo - I'll have a dig about in the code and see if I can work out what's going on.

I edited your description so your XML displays.

Looking at the filename in your last example, I gather these are xamarin tests. If that's the case, the NUnit engine (and hence the console runner) would not know how to run them. Can you clarify how you are running the tests?

These are just standard tests (I'm working at Xamarin hence the namespace). For example:
        [Test]
        public void SimpleSuccessTest()
        {
            Console.WriteLine("SimpleSuccessTest BEFORE WAIT:: " + DateTime.Now.ToString("yyyy-MM-dd hh:mm:ss"));

            Thread.Sleep(10000);

            Console.WriteLine("SimpleSuccessTest AFTER WAIT:: " + DateTime.Now.ToString("yyyy-MM-dd hh:mm:ss"));

            Assert.IsTrue(true);
        }

I'm running the tests using the console:
nunit3-console "D:\\MS\\test-apps\\Xamarin.NUnit2.Tests\\bin\\Debug\\Xamarin.NUnit2.Tests.dll"  --workers=0 --process=Single

The results are interesting. The nunit2 format output is actually created from the nunit3 output. The nunit3 output is generated by the extension from the v2 object model. That suggests an error in creating the nunit3 output followed by a compensating error in reformatting to nunit2. Like a perfect storm of errors.

Interesting - so the correct data must be in there somewhere :) Sounds like it's just not getting mapped correctly.

I ran into the same problems and decided to look at the code.
I fixed it in my fork here but I am not too sure if it does what it should do because I'm not that familiar with all the States of NUnit.
Feedback would be appreciated!

Thanks for the advice!
I didn't really find a way to get access to the TestStatus component so I at least used the same logic to determine the state here. The only way I found was via TestContext.Result.State. But I could not find a way to get a TestContext.
But now that I know that there is a place to get this information from I would rather find a proper way.
Any advice?

AH! Apologies... I forgot you are dealing with a V2 ResultState, which is nothing but an enum. In NUnit 3, that becomes a class with Status, Label and Site properties.
I think you should handle them consistent with how we translate to NUnit 3 result states in the GetTranslatedResultState method. I think you have done that with the sole exception of NotRunnable, which NUnit 3 treats as failed.
It would also be cool if you could avoid recursing through all the children four times and do it just once, but I don't see that as essential to the PR.


add ' private ' value in the doc for EndpointConfiguration in serverless api

for serverless api resource , please add in the doc that " private " is also a vaue supported to:
Current doc:
SAM support for creating Private API
EndpointConfiguration	string	Specify the type of endpoint for API endpoint. Value is either REGIONAL or EDGE.

This is correct according to the AWS docs: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apigateway-restapi-endpointconfiguration.html
Thank you for bringing this up!

@pabloperfer care to make a PR? 🙏

This is going out in our next release: 1.7.0. Closing issue.


Unit-test framework?

I had a short look into the unit-test code.
Seems like no specific unit-test framework (like GTEST or any other) has been used.
There is extra code written for use-cases like:
1)Selecting/Running sub-tests of a main test
2)Running tests parallelly
3)Filtering tests
Any particular reason for this? As having a framework like GTEST or any other would ease the above use-cases

The library is C.  I've not found a good C unit test library.  Suggestions?

I think we can still use GTEST (even though it makes more sense logically to use GTEST for testing C++ code)

Anything used by OpenSSL would also need to be portable to the full set of platforms that OpenSSL supports, which severly limits the field of candidates.  (Note that, e.g., cmake is not usable for a build system since it does not support VMS.)

OpenSSL can't use C++.  It needs to build for platforms where this doesn't exist.  They'd still want to run the unit tests.

Alright.
I guess i'm convinced.


Add AWS Bedrock Integration

Start with this example that they have and replace the components with Vanna components:
https://github.com/aws-samples/amazon-bedrock-workshop/blob/main/06_CodeGeneration/01_sql_query_generate_w_bedrock.ipynb

@zainhoda the amazon-bedrock-workshop link does not exist anymore. Any idea how I can still get bedrock to work with Vanna?

Start with this example that they have and replace the components with Vanna components:
https://github.com/aws-samples/amazon-bedrock-workshop/blob/main/06_CodeGeneration/01_sql_query_generate_w_bedrock.ipynb

The link is broken, maybe refer to another old branch:
https://github.com/aws-samples/amazon-bedrock-workshop/blob/upgrade-embeddings/06_CodeGeneration/01_sql_query_generate_w_bedrock.ipynb


Fix dialog messages

This change is

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

support/src/main/java/edu/byu/support/activity/ByuActivity.java, line 149 at r1 (raw file):

	public void showProgressDialog(boolean cancelable) {
		showProgressDialog("Loading...", cancelable);

Call through

Comments from Reviewable

Review status: 3 of 4 files reviewed at latest revision, 1 unresolved discussion.

support/src/main/java/edu/byu/support/activity/ByuActivity.java, line 149 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Call through

Done.

Comments from Reviewable

Review status: 3 of 4 files reviewed at latest revision, 1 unresolved discussion.

support/src/main/java/edu/byu/support/activity/ByuActivity.java, line 149 at r1 (raw file):
Previously, poolguy (Seth Donaldson) wrote…
Done.

Well sort of.. I did a PSF instead

Comments from Reviewable

Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Mimic Browser Behavior when deciding to follow redirects.

As far as I know, not all of the 300-399 http response codes needs to have a redirect. But looking at the code, I found you are redirecting everything in 300-399. Please look at the following url to have a reference:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html

We are redirecting when the response

has a status code of 300-309
and
has a location header.

From your link:

If the server has a preferred choice of representation, it SHOULD include the specific URI for that representation in the Location field; user agents MAY use the Location field value for automatic redirection

What we are not taking into account is that we should probably only be redirecting for GET and HEAD methods.

If the [301 | 302 | 307] status code is received in response to a request other than GET or HEAD, the user agent MUST NOT automatically redirect the request unless it can be confirmed by the user, since this might change the conditions under which the request was issued.

When correcting this, it's probably advisable to include the addition of a alwaysFollow flag that will ignore the above spec and continue operating as before. (perhaps the alwaysFollow flag should initially default to true for backwards compatibility).

This is going to be addressed eventually. See #19.

I've started the creation of a test suite that logs the redirect behavior across browsers.
See: https://github.com/jamestalmage/browser-redirect-test

Rather than following what browsers happen to do, let's stick to the HTTP specification, which is what browsers and servers should follow anyway.


supporting streams without a fixed length

for example, I have a radio station or other live stream that produces bytes continuously, until it closes. there's no pre-determined stream length in this case.
I believe it should be possible to do this, since range-stream supports streams that stay open, and range-parser is able to parse HTTP Range request headers that lack an end byte position.
Would you be open to a PR for this?

btw thanks for a great module! I've scoured npm for multiple http range request middlewares and this is probably the best one I've found so far.


Hide full path in directory view / better directory view support.

I think musikcube is a great alternative to many other terminal-based music players, however, I'd like to see better support for the directory view, since currently, for someone who only sorts their music by filename and directory-placement, it is not handy to work with / look at.

I would like that in directory view, every file's name is trimmed down to its actual filename instead of displaying the full path to it. I.e.: /path/to/my/song/song.mp3 -> song.mp3. I only want to see the song's name by looking at its filename, and since the path is always the full path (starting from root on Linux), it is hard to read and often times doesn't even fit in the column when the terminal is too small.
Similarly, I would like to see that the unknown album flag atop every directory is replaced with that directory's name (also not full path). [unknown album] -> [<name of directory>]
Essentially, within directory view, musikcube could try to interpret directories as "albums" and filenames as "titles" while simply omitting any missing metadata

Again I would very much like to see musikcube support users who don't use any mp3tags for sorting their music as sadly only few music players do so.

I would emphasize this. When you have a large library of music files (mine is more then 30GB) a folder based view is the only one usable because the files come always from different sources and have always different (another word for "bad") quality in their meta data.
musikcube allows the directory view (d command) in the left most pane which ensures there a consistent list of items (artists) as I configured it directly in my directory structure. But when I use it the right pane still shows meta data based informations. In my case this looks like this:

Not bad in the normal case of consistent meta data.
But when you don't have consistent meta data it gets weird. On top of my list is a large section where the album is unknown:

Why is the album unknown? I have a very sophisticated directory structure, of course containing albums. If the directory tree would be used for display the albums would be visible very well.
I also have a lot of classical music. When you have such works in your library it is a typical case that you have the same piece in different versions because of different orchestras and different conductors. I distinguish this in my directory tree. But meta data came some day from CDDB or whatever other database into these files - I have no clue what any guy entered there 15 years before and in which language. Indeed I had the case several times that I had a 2CD-set of a symphony and one CD had English meta data, the other one had German or French meta data, but both contained the same recording made on the same day with the same orchestra and the same conductor. So it happens normally (!) that important informations are missing or wrong or equal making it hard to distinguish your existent recordings.
Bad and/or indistinguishable meta data lead to situations like here:

I have four different recordings of Mahler's 10th symphony, so I have four tracks with track number 1, four tracks with track number 2 and so on - how should I distinguish these tracks? All of my files are well separated and ordered on my disk but here they are merged together because their meta data have a very bad quality which is typical for classical recordings.
I suggest to use generally directory and file informations when the user decides to use the directory view. The user should then see what he has in his directories, with the same hierarchical structure, meta data should then be ignored.
Note: a predefined directory tree is not needed at all, musikcube can handle what it finds on the disk. The sub directory structures can differ from artist to artist. The top most level must not even be the artists, it could be genres or whatever, this doesn't matter. Every directory is just a "caption" which can contain more directories and files, every file is a "track", the user knows what it is. The user knows why he arranged his music this way, he will be able to navigate there.

Addition: Because of the unknown structure of the directory tree Android Players like SicMu or Lisna use just a one dimensional unified list of folders and files which is indeed very handy.

I was about to ask for the same thing.
And btw if you just change the file extension using the mv command. For instance, if you have a file named song.webm and you rename it to song.mp3 with mv song.webm song.mp3, MusikCube will still play it! I was surprised because the mv command doesn't actually change the file contents; it just changes the name. Pretty handy, right?
It works with some formats, but not all. For example, it played a renamed WebM file just fine. I hope it will save you the time of converting.


Update ARM Builds for Minecraft

I know this has been brought up before, but it looks like the raspberrypi tag isn't updated anymore. There are some really powerful ARM SBCs capable of running lots of Minecraft servers, and this image seems really well thought out. It would be nice if it was supported again.

I just tried to build the Dockerfile in master on my Odroid N2 and it built just fine. The images just need to be build on Docker Hub and this is already perfect :)
I uploaded it here for now: https://hub.docker.com/r/njha/minecraft

Actually just kidding, the 3 binaries: restify, rcon-cli, and mc-server-runner don't have aarch64 either. Gah.

Okay I got it to work. Here's what needs to be done.

Add "arm64" to targets in goreleaser for all three projects. (Can I suggest replacing "arm" with "arm64"? I don't think there are many (if any) non-arm64 ARM CPUs capable of running a Minecraft server that well anyway...)
Build and release.
???
Profit.

@nikhiljha thanks for doing the research on arm64 viability. Yeah, running the server on raspberrypi has proven to be pretty much unusable; however, I'll add the arm64 build rather than replace just so I can keep that option open. (Besides raspberrypi is what I have on my desk here to test with :) )
I'm going to keep a checklist here as I update the dependencies:

[ ] restify
[ ] rcon-cli
[ ] mc-server-runner

It works! Deployed in docker swarm as usual with no issues.

Now my remaining challenge is blending the balena (formerly resin) cross-build support into the Dockerfile since Docker Hub builds via x86.

@nikhiljha can you now test out the newly tagged image itzg/minecraft-server:aarch64 ?

It doesn't seem to actually be aarch64?
no suitable node (unsupported platform on 2 nodes)

Well, the base image is definitely aarch64, but I’ll do some experimenting with my raspberry pi with a similar base image from balena

FWIW all I had to do to get it to build (from an aarch64 platform, so not as hard as cross-compiling for sure) was docker build https://github.com/itzg/dockerfiles.git#master:minecraft-server --build-arg ARCH=arm64.
Resulting image is at njha/minecraft:arm

I discovered manifest lists are a way to explicitly associate tags with their respective architecture. Can you now try itzg/minecraft-server:multiarch on your arm64 system? I also fixed ARCH in the tag aarch64 that is referenced by the manifest.

/start-minecraftFinalSetup: line 119: /usr/local/bin/mc-server-runner: No error information,
/start-minecraftFinalSetup: line 119: /usr/local/bin/mc-server-runner: cannot execute binary file: Exec format error

The image is correct but the binaries are wrong.

Can you try one more time @nikhiljha ? I re-pushed the multiarch label/manifest with the proper aarch64 sha.

# A fatal error has been detected by the Java Runtime Environment:,
#,
#  Internal Error (assembler_aarch64.hpp:1156), pid=38, tid=0x0000007f7d747aa0,
#  guarantee(Rs != Rn && Rs != Rt) failed: unpredictable instruction,
# JRE version: OpenJDK Runtime Environment (8.0_212-b04) (build 1.8.0_212-b04),
# Derivative: IcedTea 3.12.0,
# Java VM: OpenJDK 64-Bit Server VM (25.212-b04 mixed mode linux-aarch64 compressed oops),
# Distribution: Custom build (Sat May  4 17:44:26 UTC 2019),
# Core dump written. Default location: /data/core or core.38,
# An error report file with more information is saved as:,
# /data/hs_err_pid38.log

File: /data/hs_err_pid38.log
Still no :( It starts the Minecraft server and then this immediately happens. I'm pretty sure it's not a Minecraft/Paper issue because the image I built from this dockerfile works fine.
I can try with another aarch64 board at some point but...

Thanks for trying that out (again). There must be something different about the base openjdk image for aarch64 on alpine than me using the alpine image as the base and then adding the openjdk package. Maybe this is an excuse for me to buy an Odroid N2 board :)

...for now, I'll gladly point people to the image you pushed

Just to add a little here. I was looking into an easy way to get a minecraft server on my Raspberry Pi 3 Model B+ which has docker running.
I tried building like @nikhiljha with:
docker build https://github.com/itzg/dockerfiles.git#master:minecraft-server --build-arg ARCH=arm64 --tag minecraft-server

The build succeeds, but when I try to run, it gives an error:
docker run --rm -p 25565:25565 -e EULA=true --name mc minecraft-server
...
/start-minecraftFinalSetup: line 119: /usr/local/bin/mc-server-runner: cannot execute binary file: Exec format error
/start-minecraftFinalSetup: line 119: /usr/local/bin/mc-server-runner: No error information

Also, if I try to run the image built by @nikhiljha I get this:
docker run --rm -p 25565:25565 -e EULA=true --name mc njha/minecraft:arm
Unable to find image 'njha/minecraft:arm' locally
arm: Pulling from njha/minecraft
...
Digest: sha256:aaec8b9402999acfa9ac914d0ee3ce0f3141716b8aa1d689c40d0d4c56769a62
Status: Downloaded newer image for njha/minecraft:arm
standard_init_linux.go:207: exec user process caused "exec format error"

The special label “multiarch” now contains RaspberryPi 3 support...but I gave up after an hour of waiting for the server itself to generate the initial spawn area :(

...to clarify the tagged image is itzg/minecraft-server:multiarch, but the arm64 reference isn't working yet.

@shaun-blake I suspect you're running an armhf image instead of an aarch64 (also known as arm64) image on your Raspberry Pi. The Pi 3 CPU does support arm64 but the default image that you get on raspberrypi.org is armhf.

Thanks to both of you, @itzg and @nikhiljha. That explains why my previous attempts didn't work. The multiarch tag did work for me, it just took too long. I didn't actually get it started.  I gave it a few hours and it never logged anything past:

[22:07:12] [Server thread/INFO]: Reloading ResourceManager: Default

The docker stats showed the cpu usage at around 300% constantly so I'm going to guess it just doesn't have resources to run it. I guess I'll have to run it on something else.

Thanks to both of you, @itzg and @nikhiljha. That explains why my previous attempts didn't work. The multiarch tag did work for me, it just took too long. I didn't actually get it started. I gave it a few hours and it never logged anything past:

[22:07:12] [Server thread/INFO]: Reloading ResourceManager: Default

The docker stats showed the cpu usage at around 300% constantly so I'm going to guess it just doesn't have resources to run it. I guess I'll have to run it on something else.

Latest minecraft server (1.14 and 1.14.1) lag very hard on any device, just running on a scaleway server with 100% utilization with no users on, is on Minecraft side not on this repo's

Updated njha/minecraft:arm to work with 1.14.1 Paper. (Built the latest version of this repository.)

Still not work on Raspberry Pi. ver: 1.15.1
My device is Raspberry Pi 4, use the tag 'rpi3', but stuck on Reloading ResourceManager: Default,
when I run it with normal shell, it is ok. I guess maybe armhf problem, but I don't kown how to build a new image,

@tengshan2008 my apologies, I am still waiting for the new docker build mechanism to make it easier to create multi-architecture images.
For now, to build the image on your Raspberry Pi, make sure you have git and docker installed and run:
git clone https://github.com/itzg/docker-minecraft-server.git
cd docker-minecraft-server
docker build -t itzg/minecraft-server .

Raspberry Pi 4
I follow your steps build new image, but it is failed, when I change AACH to armv7, build success.
Run this new image, it still stuck on Reloading ResourceManager: Default, and CPU used 300%.
By the way. When I changed memory, max is 2000M, I can't set over 2G.
Waiting for you plan for raspberry pi.

@tengshan2008 I’m so sorry, I forgot about the ARCH build arg needing to be altered. Skimming back through some of the previous comments on this issue I think you’re running into similar hardware/OS distro limitations as others.

Hello, I am also attempting to get this running on a Raspberry Pi 4.  I tried the above, cloning the repository and building the docker image.  However, I am unsuccessful and continue running into this error during the build.
Step 13/25 : RUN easy-add --var os=${TARGETOS} --var arch=${TARGETARCH}${TARGETVARIANT}   --var version=1.2.0 --var app=restify --file restify   --from https://github.com/itzg/{{.app}}/releases/download/{{.version}}/{{.app}}_{{.version}}_{{.os}}_{{.arch}}.tar.gz  ---> Running in f2bace4cc54a /usr/bin/easy-add: line 1: syntax error: unterminated quoted string
The command I am running is
docker build -t itzg/minecraft-server .
and I've even tried
docker build -t itzg/minecraft-server --build-arg ARCH=armv7 .
Am I doing something incorrectly (I am new to docker, so this is very possible)?

Ah, I forgot to update this issue with a few important details on the multi-architecture front:

The Dockerfile now uses BuildKit compliant build args: TARGETOS, TARGETARCH, and TARGETVARIANT which would have the values "linux", "arm", and "v7" respectively for RaspberryPi
There is now a multiarch branch which uses a Debian/AdoptOpenJDK base image to leverage the very latest Java 8. I found issues on aarch64 that required that newer JVM
There is already an tagged image itzg/minecraft-server:multiarch which is fully multi-arch supported and will run as-is on RaspberryPi, aarch64 based systems, and regular x64

...however, I found that only very old versions of the server (about 1.7 ish) perform acceptably on RaspberryPi. Apparently the server code is just not optimized for that platform :(

I can confirm itzg/minecraft-server:multiarch works on Linux pinebookpro 5.6.0-2-MANJARO-ARM #1 SMP Thu Apr 2 21:13:13 CEST 2020 aarch64 GNU/Linux flawlessly.

I was able to get itzg/minecraft-server:armv7 running on my Raspberry Pi 4, but not itzg/minecraft-server:multiarch, nor itzg/minecraft-server:aarch64
For reference, I am running the latest Raspbian 64 bit builds.
Uname from inside the pod:
root@minecraft-c99554dc9-dnvsq:/data# uname -a
Linux minecraft-c99554dc9-dnvsq 5.4.40-v8+ #1316 SMP PREEMPT Tue May 12 13:17:34 BST 2020 aarch64 aarch64 aarch64 GNU/Linux
Uname from the node:
pi@raspberrypi:~ $ uname -a
Linux raspberrypi 5.4.40-v8+ #1316 SMP PREEMPT Tue May 12 13:17:34 BST 2020 aarch64 GNU/Linux
The multiarch build consistently gives "exec format error":
pi@Lenovo-Laptop:~$ kubectl logs -n minecraft minecraft-795dd97bc-grjs8
standard_init_linux.go:211: exec user process caused "exec format error"
pi@Lenovo-Laptop:~$ kubectl describe -n minecraft pod minecraft-795dd97bc-grjs8 | grep image
Normal   Pulled     13s (x4 over 56s)  kubelet, kslave2   Container image "itzg/minecraft-server:multiarch" already present on machine
The aarch64 consistently crashes the JVM after a little while:
pi@Lenovo-Laptop:~$ kubectl logs -f -n minecraft minecraft-7656fd55d7-ssbdn
usermod: no changes
Changing ownership of /data to 1000 ...
chown: /data/server.properties: Read-only file system
chown: /data/permissions.json: Read-only file system
chown: /data/whitelist.json: Read-only file system
Running as uid=1000 gid=1000 with /data as 'drwxrwxrwt    2 1000     1000           120 May 20 00:45 /data'
Checking version information.
Checking type information.
Downloading minecraft_server.1.15.2.jar ...
server.properties already created, skipping
Checking for JSON files.
Copying any mods over...
Setting initial memory to 1G and max to 1G
Starting the Minecraft server...
...
[00:46:40] [Server thread/INFO]: Loaded 6 recipes
[00:46:43] [Server thread/INFO]: Loaded 825 advancements

A fatal error has been detected by the Java Runtime Environment:

Internal Error (assembler_aarch64.hpp:1156), pid=50, tid=0x0000007f7040aab0
guarantee(Rs != Rn && Rs != Rt) failed: unpredictable instruction

JRE version: OpenJDK Runtime Environment (8.0_212-b04) (build 1.8.0_212-b04)
Java VM: OpenJDK 64-Bit Server VM (25.212-b04 mixed mode linux-aarch64 compressed oops)
Derivative: IcedTea 3.12.0
Distribution: Custom build (Thu May  9 18:09:31 UTC 2019)
Core dump written. Default location: /data/core or core.50
Any ideas? Not sure what I'm doing wrong..

The aarch64 crash seems similar to https://github.com/itzg/docker-minecraft-server/issues/316#issuecomment-489497213.

The aarch64 crash seems similar to #316 (comment).

I agree.  It seems there are two different issues potentially:

The multi arch build is either incorrect, or not being interpreted correctly on certain environments (e.g. my environment k3s/RPi4/Raspbian)
The aarch64 build crashing on k3s/raspbian/raspberry pi 4 (my environment and @nikhiljha )

Not sure if the maintainer prefers forking into two issues so leaving it here for now :)

Same problem Here, Running from Portainer on Coreelec / Odroid N2
Running as uid=1000 gid=1000 with /data as 'drwxrwxrwx    7 1000     1000          1024 May 20 21:22 /data'
Checking version information.
ecking type information.
server.properties already created, skipping
Checking for JSON files.
Copying any mods over...
Setting initial memory to 1G and max to 1G
Starting the Minecraft server...
[21:25:08] [main/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[21:25:08] [main/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[21:25:08] [main/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[21:25:08] [main/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[21:25:08] [main/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[21:25:09] [Server thread/INFO]: Starting minecraft server version 1.15.2
[21:25:09] [Server thread/INFO]: Loading properties
[21:25:09] [Server thread/INFO]: Default game type: SURVIVAL
[21:25:09] [Server thread/INFO]: Generating keypair
[21:25:09] [Server thread/INFO]: Starting Minecraft server on *:25565
[21:25:10] [Server thread/INFO]: Using default channel type
[21:25:11] [Server thread/INFO]: Preparing level "world"
[21:25:11] [Server thread/INFO]: Found new data pack vanilla, loading it automatically
[21:25:11] [Server thread/INFO]: Reloading ResourceManager: Default
[21:25:17] [Server thread/INFO]: Loaded 6 recipes
[21:25:19] [Server thread/INFO]: Loaded 825 advancements
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (assembler_aarch64.hpp:1156), pid=40, tid=0x0000007f98a48ab0
#  guarantee(Rs != Rn && Rs != Rt) failed: unpredictable instruction
#
# JRE version: OpenJDK Runtime Environment (8.0_212-b04) (build 1.8.0_212-b04)
# Java VM: OpenJDK 64-Bit Server VM (25.212-b04 mixed mode linux-aarch64 compressed oops)
# Derivative: IcedTea 3.12.0
# Distribution: Custom build (Thu May  9 18:09:31 UTC 2019)
# Core dump written. Default location: /data/core or core.40
#
# An error report file with more information is saved as:
# /data/hs_err_pid40.log
#
# Compiler replay data is saved as:
# /data/replay_pid40.log
#
# If you would like to submit a bug report, please include
# instructions on how to reproduce the bug and visit:
#   https://icedtea.classpath.org/bugzilla
#
2020/05/20 21:25:25 Done```

@pschonmann Oh hey, another person using an ODroid N2 :)
Apparently this is because the image is using an older version of the openjdk image...
FROM openjdk:8u212-jre-alpine

This issue https://github.com/openhab/openhab-docker/issues/233 is running the same version of openjdk and is apparently fixed in newer releases. I've switched to x86_64 for Minecraft (since I now need to handle 40+ players) so I can't test atm.
Can you give rebuilding the image with a newer version a shot? Just replace the line above with
FROM openjdk:8u252-jre-alpine

Also, I'm using OpenJ9 now instead of Hotspot. The object cache does wonders for performance (at the cost of some disk space). Might be worth looking into switching to the j9 docker image :)

Gah, https://github.com/itzg/docker-minecraft-server/pull/536#issuecomment-631758474

Yeah, I should at least make the same base image switch I did for armv7 in the aarch64 branch too.

Oops, didn’t notice your PR yet. Looking at that instead...

The latest itzg/minecraft-server:multiarch image tag is now using Java 1.8.0_252 for arm64 (aka aarch64), armv7 (aka 32-bit RaspberryPi 3 B+ and newer), and amd64 (aka good ol' 64-bit Intel/AMD).
FYI it is now maintained in the multiarch branch and built for all three platforms using buildx/BuildKit.

@pschonmann, can you re-pull the multiarch tag and see if that fixes your Odroid N2 setup? I have verified on an AWS EC2 a1.medium instance.

Yeap, its working

I am going to close this issue since I feel very satisfied that the multiarch branch along with buildx/BuildKit builds finally produces usable images on all three processor architectures.


Removed udfore + all the remaining gotos.

Codecov Report

Merging #69 (ec1e1fb) into main (2d73459) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   61.67%   61.67%
=======================================
  Files          82       82
  Lines        2990     2990
=======================================
  Hits         1844     1844
  Misses       1146     1146

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d73459...ec1e1fb. Read the comment docs.


Screenshot Chat Text

When taking a screenshot, the game tells you Saved screenshot as ... in the chat, where the file name links to the file on your computer. Would it be possible to replace this file link with a link that brings you to the Screenshot Manager directly?

It is an interesting idea, however I'm not sure everyone would like this behaviour, so it will probably be toggleable in the mod config if I implement it.

Implemented in Screenshot Viewer 1.2.0


Local Checkout UI Extension: Cannot read properties of undefined (reading 'networkAccess')

On the CLI version 3.16.1, if you try and run the default scaffolded/generated extension using yarn dev, then click to preview your extension you will get the following error on the checkout page:

vendors~app.latest.en.e5376343c5580b97aa7a.js:2 TypeError: Cannot read properties of undefined (reading 'networkAccess')
    at app.latest.en.280faa0996ccd0490853.js:1:183003
    at Array.map (<anonymous>)
    at app.latest.en.280faa0996ccd0490853.js:1:182862

This error only occurs in the new Node version of the server. If we revert to using the Go code, it works without error.
This is likely related to https://github.com/Shopify/cli/pull/563.

Looks like my fix uncovered a different issue, the behaviour shouldn't be different between Node and Go and we shouldn't add capabilities by default. As a workaround you can add the capabilities to your extension toml file.


Parse playlists

In the wild m3u(8) files exist also as playlists. The major difference between playlist and HLS is #EXT-X-TARGETDURATION as playlist does not contain them. Here is example of playlist file from Wikipedia:
#EXTM3U

#EXTINF:123, Sample artist - Sample title
C:\Documents and Settings\I\My Music\Sample.mp3

#EXTINF:321,Example Artist - Example title
C:\Documents and Settings\I\My Music\Greatest Hits\Example.ogg

Currently the only change that is needed this to work is adding #EXT-X-TARGETDURATION:500000000 on second line of file. And the file can be parsed and regenerated. So I propose setting #EXT-X-TARGETDURATION as optional, if it exist we can assume it is HLS file, else it is playlist file.
For fine polishing when playlist is determined, all HLS M3U extensions would be disabled, so they cannot be accidentally parsed or generated.

Thank you for sharing your idea.
(I'm not sure but) it sounds that it's not so difficult to support wild m3u(8) files. However, as the name suggests, this crate is for HLS m3u8 files.
To keep the implementation/design simple and reduce maintenance costs, I think it's better not to support wild m3u(8) in this crate.
(Besides, there are crates for m3u and m3u8. I have not used those though)
BTW, @Luro02 is the current leading developer of this crate. So if he likes the direction, I'm willing to adopt that.

It has been such a long time since I went through the m3u8 spec. We had a number of issues in the past that were caused by me misinterpreting the spec.

The EXT-X-TARGETDURATION tag is REQUIRED.

https://datatracker.ietf.org/doc/html/rfc8216#section-<IP_ADDRESS>
Seems to suggest that this field must always be present?

Trying to support any possible malformed input, seems to be a bad idea, because there are infinitely many ways to create broken files and people should not rely on it.
I think having a way to completely disable verification seems to be a useful feature to have, because sometimes you have malformed files and it is not that relevant if the file is valid.
The current crate design makes it difficult to implement disabling the verification completely.
For example like you said the target duration field is currently not an Option. If one were to make it optional, every user of this crate would have to add unwrap to every use of the field, which looks kinda bad and introduces unnecessary panic handling for something that could never happen.
The solution for this is to take advantage of the way this file-format is designed (streaming line based file format, I would say?) and introduce some kind of iterator based parser.
Here is an example of how this could look like (this is a markdown parser):
https://docs.rs/pulldown-cmark
The benefit of this approach is that it does not need allocations and can be implemented in such a way that one can easily disable verifying everything or just a few things.
The foundation for this parsing is already present here:
https://github.com/sile/hls_m3u8/blob/master/src/line.rs
Sadly I am currently very busy and have no time to implement this myself.

Thanks for your comment!

The solution for this is to ... introduce some kind of iterator based parser.

Sounds interesting.
Unfortunately, I also don't have time to try to implement it.


Update gmail connector sample

Code is not upto date,
https://github.com/ballerinalang/connectors/blob/master/gmail/samples/gmail/GmailConnector_test.bal
e.g. string statusCode = (string)http:getStatusCode(gmailResponse); -> string statusCode = http:getStatusCode(gmailResponse);

We have changed Gmail Connector


Update developer guide - Target user profile, Value proposition, User story

fixes #27

Codecov Report

Merging #34 (a4ca666) into master (b5d4026) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #34   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d4026...a4ca666. Read the comment docs.


Fixing 846 without tests.

Fixing "Optimizing: -nan%... #846" https://github.com/googlecartographer/cartographer/issues/846.
The issue was triggered in a multithreaded execution, when all nodes were processed, but the working queue was still non empty (having other kind of jobs).
Unfortunately I failed to reproduce the bug in tests, so no new tests were added.

@wally-the-cartographer merge

Merge requested by authorized user pifon2a. Merge queue now has a length of 2.

@wally-the-cartographer merge

@wally-the-cartographer merge

Error: exit status 128
Log:
=> handle work item: PR 1183 on googlecartographer/cartographer.
 => Switching to branch master.
 $ git reset --hard HEAD [data/cartographer]
HEAD is now at 691ec21a Merge branch 'master' into pr_1177
 $ git clean -fd [data/cartographer]
 $ git checkout master [data/cartographer]
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
 $ git pull [data/cartographer]
Already up to date.
 => Checking out sotnik-github/cartographer_bug_846 as local branch pr_1183.
 $ git remote add sotnik-github git@github.com:sotnik-github/cartographer.git [data/cartographer]
fatal: remote sotnik-github already exists.
 $ git fetch sotnik-github [data/cartographer]
 $ git branch --track pr_1183 sotnik-github/cartographer_bug_846 [data/cartographer]
fatal: A branch named 'pr_1183' already exists.

@wally-the-cartographer merge

Merge requested by authorized user pifon2a. Merge queue now has a length of 1.


Follow the established exception handling convention.

The general established behaviours in BuildStep is to simply let the
caller handle the exception, possibly with exception chaining to add
more context.
What the code does right now is to simply swallow the stack trace part
of the exception, which is often the most crucial, especially for
unanticipated exceptions (in this context, there's no checked exceptions
thrown.)
See issues like https://github.com/jenkinsci/slack-plugin/issues/595
where this behaviour makes it painful for users (and maintainers) to
troubleshoot what's going on.

Also:
Thank you for this contribution! It is much appreciated.
Are you doing it as a part of the Jenkins UI/UX Hackfest? If so, please consider reporting this contribution here so that we could facilitate reviews and share the story 👍


Feature : Add accordions

Could you please add accordions in this query builder  for nodes ?
It will be more user friendly if you are adding this feature too.

Added in 0.4.0.


SVN to Git Cheat Sheet 1.0.0 preparation

Prepares final Markdown content and addresses adjustments mentioned here.
Rendered

:tada:


Focus ring helper and utilities

Adds new global Sass variables for :focus styling
Reassigns $input-btn-focus-* variables to new global variables (come v6, we'll simplify these variables)
Adds focus styles to all navigation styles (including base .nav, .nav-pills, and .nav-tabs)

Closes #32357.
Live previews

https://deploy-preview-33125--twbs-bootstrap.netlify.app/docs/5.2/helpers/focus-ring/
https://deploy-preview-33125--twbs-bootstrap.netlify.app/docs/5.2/components/navs-tabs/

Loving the way you did this.
Couldn't we jump on the opportunity to improve our overall focus styles, regarding non-text contrasts? @MartijnCuppens's suggestion in #29422 (comment) using two solid shadows (also pretty much what's done in Boosted, however using outline) — and followed by some references in my own next comment in that thread — would be quite easy to implement and apply everywhere with this new focus variables superset, wouldn't it?
Might also wait for another PR, but IMHO it'd make a lot of sense.

I'm all for having a consistent focus style, but wouldn't this be considered a breaking change for some people?
I mean, we've seen numerous times people asking how to drop focus styles because they probably don't know that they shouldn't, unless they provide some kind of replacement.

Well, this is another consideration that's unrelated to the kind of focus styles we set.
Dropping the focus styles while ensuring accessibility requires :focus-visible, and even if we don't implement it as of now my latest PR using the polyfill might be given as an example for such questions.
However depending on how we'd like to implement a new focus style, we need caution to prevent BC. That might not be possible, didn't try that much.

Taking off Beta 3—let's discuss further and figure out a plan :).

Oh and we already had this discussion, obviously 😅

Thanks @ffoodd! Going to wait for v5.3.0 for this—want to see where I can build this into our other components with additional CSS variables.

@julien-deramond Tried resurrecting this one—still needs a bit of work to apply the updated focus shadow to other components. Maybe that could wait until later though, like in v6, and we just have an extra helper/utilities for now?

This has been revamped with the latest commits, so the title has been updated to reflect that.

Adds a new .focus-ring helper. It's a helper and not a utility since it sets two separate properties (outline and box-shadow).
Adds new global :root focus CSS variables and Sass variables that work in tandem on the helper and components. I'd like to add the CSS variable versions to existing components, but I think that'd cause some issues. So that'll be a v6 thing.
Adds new .focus-ring-{color} utilities to modify the color of the ring.

Originally I had some offset stuff in there, but that's too clever right now with box-shadows. Come v6, I expect to replace this with a focus ring utility as soon as Safari ships support for rounded corners on outline.


search or pull my own docker images from other docker client get 404 error

I am running docker-registry on my own server, pull images from docker
hub, re-tag image, push to local
container all work fine. But search or pull images from other docker
client always fail.
The docker registry server log is:
<IP_ADDRESS> - - [19/May/2015:08:24:27 +0000] "GET
/v1/search?q=hello-world HTTP/1.1" 404 19 "" "docker/1.5.0 go/go1.3.3
kernel/3.8.13-55.1.6.el7uek.x86_64 os/linux arch/amd64"
Any idea?
Thanks,
Leon

Hi!
If you are reporting a new issue, PLEASE make sure that does not have any duplicates already open.
We would like to take this time to remind you of the information we need to debug the problem you are seeing. This is an automated response so if this ticket is not about a bug, do not fret.
If you fail to provide this information within 7 days, we will close this because we cannot debug your issue. We can reopen whenever the information is provided.
Thank you.
Please see:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues
Description of problem:

`docker version`:

`docker info`:

`uname -a`:

Environment details (AWS, VirtualBox, physical, etc.):

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual Results:

Expected Results:

Additional info:

#ENEEDMOREINFO

wonleing,
In those other client run (docker login) and enter your docker credentials. See if that helps. Feel free to close the ticket once the issue has been resolve.

[root@localhost ~]# docker login
Username: wonleing
Password:
Email<EMAIL_ADDRESS>FATA[0007] Error response from daemon: 404 page not found

that was the situation of my docker client.
my docker-registry server can do docker login correctly. But what i want to do is connect directly from the docker client to my registry server, without any connection to the official Docker Hub.
I am actually want to build my own hub, a very simple one

I found the problem. each time I restart "docker run -p 5000:5000 secure_registry", I have to push the image again! Or the pull will report a 404 error.
Isn't it a bug?!

@wonleing A docker run is creating a new container and then starting it.
To start a stopped container, use docker start <container id/name>
Closing.


Cassava Leaf Disease Classification

Pull Request for ML-Crate 💡
Issue Title:

Info about the related issue (Aim of the project) :
Name:  Keshav Arora
GitHub ID:  CoderOMaster
Idenitfy yourself:  JWOC Mentee

Closes: #issue number that will be closed through this PR 506
Describe the add-ons or changes you've made 📃
Give a clear description of what have you added or modifications made
Type of change ☑
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested? ⚙
Describe how it has been tested
Describe how have you verified the changes made
Checklist: ☑

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[x] I have added things that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

@abhisheks008 I hv already linked kaggle database in readme file though.Should I rename link.txt anyways?

@abhisheks008 I hv already linked kaggle database in readme file though.Should I rename link.txt anyways?

Yes

@abhisheks008 I have done all changes required.Please assign appropriate difficulty as per our previous discussion and approve the merge request.
Thank You


Migrate existing adapter scripts to this repo as GitHub actions

Moved existing adapter scripts here.
Brief
I turned existing workflow steps into one single multi-step composite action.
This way the adapter workflow yml needs to only use one action (e.g. smoke-test) which itself contains all the steps, which can be modified in the future without changes to the adapter repos.
The scripts folder was copy-pasted from the adapter repos without modifications.
The 3 actions ymls were mostly copy-pasted from their corresponding adapter workflows, although needed a few modifications. Mainly:

Added description, updated name, etc.
Specified a bash shell for some steps that did not require it when running on a workflow.
Updated the path to the local scripts using ${{ github.action_path }}. The scripts do not exist in the same path as before since the action is not located in the current path anymore.

Testing
I tested these changes with the reference adapter, creating a test branch, and running all the actions. I tested the release action by first removing the steps to push to CocoaPods and create the GitHub release.
One thing to note is, due to the adapter workflows now containing one single composite action, the output isn't as nice: we don't get those green checks for each step:

We do get all the output and if something fails we get the logs with the failure reason in red.
Next steps
In separate PRs I will add a step to update file headers, and smoke test and release workflows for this repo.
Also I am about to create PRs for all adapters to use the new actions.

Reopened PR, since I had to force push some changes to main to test the new allow-warnings input, which auto-closed my original PR https://github.com/ChartBoost/chartboost-mediation-ios-actions/pull/3/files#diff-2ff5f698469e2745ba08aa4728337db919d45a58d382f6840a06d0a951b596d5


Record User stamp

Make sure https://github.com/ministryofjustice/prison-visits-2/pull/1701 is merged first
CHANGES:
Sends the current staff user's email to NOMIS API when booking a visit.

@TobyRet @KPobeeNorris I've reopened the PR against master here https://github.com/ministryofjustice/prison-visits-2/pull/1723
so I'm closing this


This model's maximum context length is 4097 tokens, however you requested 4124 tokens (124 in your prompt; 4000 for the completion). Please reduce your prompt; or completion length.",   type: 'invalid_request_error',

very nice example.
it throws an This model's maximum context length is 4097 tokens, however you requested 4124 tokens (124 in your prompt; 4000 for the completion). Please reduce your prompt; or completion length.",
type: 'invalid_request_error',
i have enough amount on my account, how could this be resolved?
It is for a code example. so i cannot paste longer code examples then just this small amount?

It's OpenAI limit. You can't call api with more than 4000 tokens.
Implemented ChatGPT (GPT3.5) version in static html version. and It seems much better and can pass much more tokens.
Will implement this feature in react too when I have time.
https://github.com/ioanmo226/chatgpt-web-application


Mesasurement Spike and stays High

So I finally got a around to wiring everything to the Pit, and since I have a lot in the pit, Main pump and back up pump I was get bad readings because I have limited open space.
So I took a 3" PVC pipe and mount the HC-SR04 sensor in the pipe pointing strait down.
It sits about 25" from the bottom of the pit. Things where working great for about 1 week. The range with the water is about 5" to 8". I have it set to read ever 2 mins.  All of sudden I started to get reading of 22". The CSV file would have 7.5 7.6 then jump to 22" and stay like that. Some times it would go back down for a few reads.
Has anybody ever encountered that before? The version I am running is from an install back at the end of 2018.  I swapped out the sensor as I purchased a 5 pack and it did the same think but this time it start about 4 mins after putting on the new sensor
Second question since I am using a version from 2018 would love to use some of the new features you added. How do I go about to get the latest code for the program on the PI?  DO I just run sudo pip3 install -U raspisump
THanks

I have had similar issues.  I used a 4 inch PVC myself, and it is very likely to be one of 2 things.
1 - there is some kind of debris that has floated up with the water, and stuck to the inside of the PVC.  If it is this, you can clean the pipe out fully, then put something simple like a pair of old pantyhose or something over the bottom end of the PVC.
2 - It can ALSO just be water droplets.  This only happened to me once, when I had a power outage that caused the water to get higher in the pipe then normal.   For this, just clean the inside of the pipe.  I have not had to, but I would think if it is just water droplets, you could use something like rain-X on the inside of the pipe to keep the water from beading up.
Essentially, when doing it in a pipe, the sensor is much more sensitive than you think it should be :-)   That is at least what I found out.

i am using a 2" pvc pipe and have not had any spikes.  Same sensor as last year.

Thanks for the advice. I cleaned up pipe and removes some debris at the bottom so far so good. going to have to come up with a way to keep the pipe more closed off but let the water run through it


Ensure that cloud.redhat.com address is not wired in the code

Ensure that cloud.redhat.com address is not wired in the code

cloud.redhat.com address is not used anywhere in this repository.


Meta quotes removed upon rebuilding rule

Noticed this today while playing this this library. Upon parsing and rebuilding a rule, the double quotes are removed in values within the meta section.
Example code:
import plyara
ply = plyara.Plyara()

rule = """rule garbageRule
{
	meta:
		author = "Josh Grunzweig"

	strings:
		$garbage = "hi world"

	condition:
		any of them
}"""
p = ply.parse_string(rule)
print(repr(p))
print(ply.rebuild_yara_rule(p[0]))

Output:
[{'condition_terms': ['any', 'of', 'them'], 'raw_strings': 'strings:\n\t\t$garbage = "hi world"\n\n\t', 'raw_condition': 'condition:\n\t\tany of them\n', 'raw_meta': 'meta:\n\t\tauthor = "Josh Grunzweig"\n\n\t', 'rule_name': 'garbageRule', 'stop_line': 11, 'start_line': 1, 'strings': [{'name': '$garbage', 'value': '"hi world"'}], 'metadata': {'author': 'Josh Grunzweig'}}]
rule garbageRule {

	meta:
		author = Josh Grunzweig

	strings:
		$garbage = "hi world"

	condition:
		any of them
}

The unit test also appears to fail on this particular item:
======================================================================
FAIL: test_rebuild_yara_rule_metadata (__main__.TestStaticMethods)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/unit_tests.py", line 82, in test_rebuild_yara_rule_metadata
    self.assertTrue('string_value = "TEST STRING"' in unparsed)
AssertionError: False is not true
----------------------------------------------------------------------

Pseudo false alarm. Functionality doesn't work on the pip install, but works correctly in master when building manually.

This is odd, master should be the same as the latest version in pip, 1.2.6. If it hasn't been overwritten by your local install, could you grab the version you were using? And what Python version are you running?
pip freeze | grep plyara
python -V

I can't reproduce that test failure on the latest 2 versions under Python 2.7.
$ git checkout v1.2.5
Note: checking out 'v1.2.5'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 5cf3725 Bump version to v1.2.5
$ nosetests
...................................
----------------------------------------------------------------------
Ran 35 tests in 1.274s

OK
$ git checkout v1.2.6
Note: checking out 'v1.2.6'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at d231d38 Bump version to v1.2.6
$ nosetests
...................................
----------------------------------------------------------------------
Ran 35 tests in 1.264s

OK

Checking my logs, I think I understand what happened. I installed it a couple of months back and was running 1.2.3, however, I forgot I had done this. When I did a pip install earlier today it simply said I had the requirements met (I didn't realize until just now) and carried on. I just did a quick check and 1.2.6 is in fact installing via pip.
So, tl;dr everything is good, but I made a mistake on my part.

Ah, makes sense. :) Thanks for looking into it.


LDAP query returns "empty result" while same query with ldapsearch works

Our (munged) config:
[ldap]
type = activedirectory
uri = ldaps://server01.domain.local:636/
base = dc=domain,dc=local
binduser = DOMAIN\zabbix_ldap
bindpass = <the_pass>
groups = Company Employees

[ad]
filtergroup = (&(objectClass=group)(name=%s))
filteruser = (objectClass=user)(objectCategory=Person)
filterdisabled = (!(userAccountControl:1.2.840.1135<IP_ADDRESS>3:=2))
filtermemberof = (memberOf:1.2.840.1135<IP_ADDRESS>1:=%s)
groupattribute = member
userattribute = sAMAccountName

When I use ldapsearch to query server01.domain.local using the filters as shown above, I get the list of users and groups that I expect (although I don't seem to be able to combine e.g. filteruser and filtermemberof, so I expect those matches are done in code?). Therefore I expect (hope) that the config I'm supplying is correct.
When I run zabbix-ldap-sync in verbose mode, I see:
[ldaps connection success omited]

** ld 0x1d770b0 Connections:
* host: server01.domain.local  port: 636  (default)
  refcnt: 2  status: Connected
  last used: Tue Apr  2 16:46:11 2019

** ld 0x1d770b0 Outstanding Requests:
 * msgid 1,  origid 1, status InProgress
   outstanding referrals 0, parent count 0
  ld 0x1d770b0 request count 1 (abandoned 0)
** ld 0x1d770b0 Response Queue:
   Empty
  ld 0x1d770b0 response count 0
ldap_chkResponseList ld 0x1d770b0 msgid 1 all 1
ldap_chkResponseList returns ld 0x1d770b0 NULL
ldap_int_select
read1msg: ld 0x1d770b0 msgid 1 all 1
read1msg: ld 0x1d770b0 msgid 1 message type bind
read1msg: ld 0x1d770b0 0 new referrals
read1msg:  mark request completed, ld 0x1d770b0 msgid 1
request done: ld 0x1d770b0 msgid 1
res_errno: 0, res_error: <>, res_matched: <>
ldap_free_request (origid 1, msgid 1)
ldap_parse_result
ldap_msgfree

Since I'm not that good at Python.. At which step can I add a "print" to see the query that is used?

Added debug statement https://github.com/zabbix-tooling/zabbix-ldap-sync/commit/0a73b046c2bcfb623f1eb68e649853c3502fc72e
Please reopen this issue if the problem reappears.


added JavaScript folder

Still getting a feel for pull requests. Also, I'm curious what type of algorithms you're looking for. Any/All?

The folder is going to need a file inside of it before it shows up.
perhaps string reversal or your favorite algorithm?

I see that my changes have automatically showed up here - that was a little unexpected because I had only committed to my own fork (or so I thought). Forgive my ignorance on this workflow. This is all new to me.


ICU-766 Fix go back from deleted permalink

Summary
Passing the last known location before clicking on a permalink so if the post was actually deleted we can go back to the last known location.
Ticket Link
https://mattermost.atlassian.net/browse/ICU-766
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

@crspeller cause this is a bug fix wanted for 4.7


add app template, change context, add tests

Pull Request Test Coverage Report for Build 26

6 of 19 (31.58%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+7.06%) to 44.783%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

template.go
2
6
33.33%

context.go
4
13
30.77%

Totals

Change from base Build 24:
7.06%

Covered Lines:
279

Relevant Lines:
623

💛  - Coveralls

Pull Request Test Coverage Report for Build 26

6 of 19 (31.58%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+7.06%) to 44.783%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

template.go
2
6
33.33%

context.go
4
13
30.77%

Totals

Change from base Build 24:
7.06%

Covered Lines:
279

Relevant Lines:
623

💛  - Coveralls


[WIP] Update the prod API to use the indexes with production events

Plus some changes to how we configure them to reduce repetition, and enforce the v1/v2 patterns.

This broke the API (see #2328) so don’t merge it yet!

Closing as outdated.


Chore/jenkins refactor

Summary
SUMMARY_GOES_HERE
Full changelog

[Implement ...]
[Add related tests]
...

Issues resolved
Fix #XXX

will reopen


Update sql-writer-service.md

Update to be explicit that "elevated" = "sysadmin".

@rwestMSFT
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

I'm going to refresh the article and include this change. Thanks, @PhilB-MSFT.


bug: healthcheck bug

Issue description
when press test，error log appear occasionally.

Environment

apisix version (cmd: apisix version):1.2
OS:centos7.4

Can you provide reproduction steps?

what about use the 1.3 or the master version?

step:

i have not test other versions.
step:
1、add route:
{"host":"www.test.com","filter_func":"function(vars) return string.len(vars['binary_remote_addr']) == 4  end","vars":[["server_port","==","80"]],"upstream":{"retries":3,"nodes":{"<IP_ADDRESS>:80":1},"hash_on":"vars","checks":{"active":{"unhealthy":{"http_failures":2,"tcp_failures":2,"interval":1,"timeouts":3},"timeout":1,"https_verify_certificate":true,"http_path":"/healthcheck","healthy":{"interval":2,"successes":1},"req_headers":["User-Agent: curl/7.29.0"],"type":"http","host":"healthcheck.com","concurrency":10}},"type":"roundrobin"},"priority":3,"uri":"*"}
2、modify www.test.com hosts to apisix server ip,press test with wrk for several times.
wrk -t 16 -c 400 -d 30 --latency http://www.test.com/test
then error log appeard sometimes.

please update your version first. I remember we have fixed such a bug.

@wwd5613 any news?

@wwd5613 old issue, please reopen this issue if you still have this issue with latest APISIX version


Refactor request/response logging

Use TraceLayer by tower library, instead of using custom middleware for logging.

Not possible to use TraceLayer to print request and response, explained here


Feature request: Tray icon should blink if new PM received

My Setup

My OS name and version: Windows 7 64.bit
My current app version: 2.8.0

[x] I have tested with the latest application version
[x] I can simulate the issue easily

Description

Current Behavior

If you receive a PM, the tray icon is changed to red icon with an unread number indicator.
Expected Behavior

It would be helpful, that in case of new PM the tray icon is blinking. Either as default or as option.

I tested this on Windows 7, and it seems to work as expected, unless you are talking about something else?
Do you have any settings enabled to disable notifications for direct messages?

You talk about the app Icon. I mean the tray icon. In our installation, many people overlook a new PM.

@johntq I don't think its possible to make the tray icon blink on windows. We could potentially change the colour if that would help?

Hmm. Another idea: It is possible to have an option wich can set the tool tip timout to endless or open the main window in case of new PM?

Why you cant make the icon blink?
If you can change image - you can "blink"
Just change images

I will explain the motivation behind my request.
Our company is evaluating the transition from Jabber protocol based client to Rocket.Chat.
Now we are in the testing phase. Many participant have reported, that noone notice a new PM. Some percent of our Instant Messaging are real time information, such as come over or pizza is arrived. Meanwhile, some have starved to death because they have not noticed their PM.
For us it is very important that you can notice new PM better.

I have a similar issue/feature request. We have users also missing PMs because they miss the few seconds that the pop-up notification appears. Ideally, I would like it if the pop-up notification of a new message stays on the screen until clicked or dismissed. I have seen this with other IM clients, do you think this would be possible to add to Rocket.Chat?

isn't the same issue as https://github.com/RocketChat/Rocket.Chat.Electron/issues/487? If so, we can close one of them!
@geekgonecrazy

It looks like the same. Important: I am talking about the tray icon, not the task bar icon.

sure! the other issue is also about the tray icon :smile:

I'm in the process of reviewing your app for our organization.  Having the Tray Icon blink when a message arrives is a key feature for our member experience.  leaving the app open on the task bar is not an option for us at this time.   Am I correct that no one is working on this feature or am I missing the setting in preferences?

I made a very simple change to implement a blinking tray icon:
https://github.com/RocketChat/Rocket.Chat.Electron/compare/develop...iplabs:feature/blinking-tray-icon
When an alert tray icon is to be displayed then it blinks (Toggling between normal tray icon and the requested alert tray icon every 500ms). When a non-alert tray icon (normal or unread) is displayed then it does not blink.
Works pretty well here but I'm not sure if it is ready for a pull request yet, because there are some open questions:

Is it ok to hardcode the blinking because everyone will benefit from it? Or is it better to make it configurable?
If it must be configurable then what is the correct place for the new config? Server-side like the "Unread Tray Icon Alert" config? Or client-side like the "Toggle Menu Bar" setting?
I only changed the behaviour for Windows/Linux but what about OSX? Do Mac users need a blinking icon? Or is the OSX-builtin message counter on the app icon already notifying enough?

If you want to try the blinking without compiling your own client then you can locate the app.asar file in your Rocket.Chat installation, unpack it somewhere, patch the unpacked content with blink.diff.txt, repack the asar file and replace the original one with it.

When you click the close button on the windows bar after that icon does not turn orange.

but, when click em close button of program

If you want to try the blinking without compiling your own client then you can locate the app.asar file in your Rocket.Chat installation, unpack it somewhere, patch the unpacked content with blink.diff.txt, repack the asar file and replace the original one with it.

Seems like this patch no longer works with the current Rocket.Chat 2.15.3 as the code looks like it's been refactored at some point.   Did you ever update your patch for this latest version?

this should be must have feature!!

this should be must have feature!!

I was trying to resolve this issue so, when I  tried to check for the issue, I found that when ever so one gets a notification , there's no change in the tray icon , so after looking upon the notification folder , I found out that tray icons must be integrated with the notification folder. This is the possible solution that I can come with.

Hey There,
This issue is already present in the current version of Rocket Chat ( 3.8.9 ), both flashframe and dockbounce works if any PM comes to the app.
Kindly update to the latest version & consider closing the issue.
Thanks! 😊

Hello, we will be tracking the blinking icon feature request here: https://github.com/RocketChat/Rocket.Chat.Electron/issues/2525
I will be closing this issue because there are duplicated ones.


RFC004: Team page implementation according to Mock

Description
Per the mock design, we must create the team and individual page components on the monlamai website.
Completion Criteria
Updated website with team page route listing out all the team members and individual page for details of a team member.
Implementation Plan

create a team page route
List all the members using a team component.
team detail page with individual route

SubTasks

[x] Create a team page route
[x] team page component
[x] create bo & en team data json
[x] individual member route with details
[ ] Upload the team headshot to s3 and use s3 link on the team page
[x] update team data

@tentamdin refer the mock update and make require changes

[ ] localization in team n individual page
[ ] Update breadcrumb


[Profile] Overflowing profile name creates unnecessary white space

Title
[Profile] Overflowing profile name creates unnecessary white space
Platform / OS
Windows 10
Browser
Chrome
Description
Creating a lengthy profile name will display an overflowing text and unnecessary white space
Steps to Reproduce

Log in to your account
Edit your profile name with a lengthy text and save
Notice the overflowing text and white space at the right side of the page

Expected Behavior
No overflowing text and unnecessary white space due to lengthy profile names. Name should be wrap or make a maximum character input for names.
Additional Info

Branch: aa964f7da50b7866b12349886397c6c413a4c3a3
dev Build: https://circleci.com/gh/sleepbusorg/sleepbus.org/170

happens on

[ ] my profile page

[ ] my donations page

won't fix


Integrate Yorkie UI PoC into CodePair project for testing

Description:
We are currently developing a new CodePair project with additional features such as Workspace and AI Assistant integrated into the existing collaborative Markdown editor.
We are currently using Material UI (mui) for the project since we are unsure when the Yorkie UI PoC will be available.
To better understand the feasibility and functionality of the Yorkie UI PoC, we would like to integrate it into the CodePair project and perform testing before considering its implementation in the Yorkie PaaS dashboard or website.
Why:
By integrating the Yorkie UI PoC into the CodePair project, we can evaluate its performance and capabilities in a real-world testing environment. This will help us make informed decisions about its potential integration into our other projects.

Since yorkie-ui is specialized for the PaaS, CodePair will use a different design system.


GEP2257 Duration parsing

Per GEP 2257, adding duration utils for implementing GEP2257 duration format
What type of PR is this?
/kind feature
(not sure if this is the right kind for this 😅 )

What this PR does / why we need it:
Per GEP 2257 Duration formatting's next step to graduation is implementing parsers. Helping out with this push to standard channel 👍
Which issue(s) this PR fixes:

Fixes #
Related PRs:

https://github.com/kube-rs/gateway-api-rs/pull/45
https://github.com/kubernetes-client/python/pull/2261

Does this PR introduce a user-facing change?:

NONE

cc: @kflynn

/approve
Nice work!

Thanks @xtineskim!
/lgtm
/approve


Update dependencies: ckeditor5-dev-webpack-plugin, ckeditor__ckeditor5-core, swc-loader

What are the relevant tickets?
No tickets
Dependency Dashboard: https://github.com/mitodl/ocw-studio/issues/1787
Description (What does it do?)
@ckeditor/ckeditor5-dev-webpack-plugin, @types/ckeditor__ckeditor5-core are deprecated dependencies. This PR removes @types/ckeditor__ckeditor5-core because it is now part of ckeditor5-core dependency. And migrates to using @ckeditor/ckeditor5-dev-translations over @ckeditor/ckeditor5-dev-webpack-plugin.
Also updates swc-loader.
Screenshots (if appropriate):

[ ] Desktop screenshots
[ ] Mobile width screenshots

How can this be tested?

Additional Context

This PR will be continued on my next Renovate day / or on priority depending on workload (whichever comes sooner)


Add jenkinsfile for getDependency build

Resolves https://github.com/AdoptOpenJDK/openjdk-tests/issues/689
Signed-off-by: Mesbah Alam<EMAIL_ADDRESS>

Contend of test.getDependency as was in job configuration:
timeout(time: 1, unit: 'HOURS') {
    stage ('Get Dependencies') {
        node ('master') {
            timestamps {
                try {
                    cleanWs()
                    sh 'wget https://raw.githubusercontent.com/eclipse/openj9/master/test/TestConfig/scripts/tools/getDependencies.pl'
                    sh 'perl ./getDependencies.pl -path . -task default -os os.linux'
                    archiveArtifacts '*.jar, *.zip'
                } finally {
                    cleanWs()
                }
            }
        }
    }
}

Content of systemtest.getDepedency as was in job configuration:
timeout(time: 8, unit: 'HOURS') {
    stage ('Get SystemTest Dependencies') {
        node ('master') {
            timestamps {
                try {
                    cleanWs()
                    sh 'curl -OLJks  "https://api.adoptopenjdk.net/v2/binary/nightly/openjdk8?openjdk_impl=hotspot&os=linux&arch=x64&release=latest&type=jdk"'
                    sh 'mkdir ${WORKSPACE}/j2sdk-image'
                    sh 'tar -xzf OpenJDK8U-jdk_x64_linux_hotspot*.gz -C ${WORKSPACE}/j2sdk-image --strip-components 1'
                    sh '${WORKSPACE}/j2sdk-image/jre/bin/java -version'
                    sh 'git clone git://github.com/AdoptOpenJDK/openjdk-systemtest'
                    sh 'ant -f ./openjdk-systemtest/openjdk.test.mauve/build.xml -Djava.home=${WORKSPACE}/j2sdk-image/jre -Dprereqs_root=${WORKSPACE}/systemtest_prereqs'
                    archiveArtifacts '**/systemtest_prereqs/mauve/mauve.jar'
                } finally {
                    cleanWs()
                }
            }
        }
    }
}

Note: this PR combines the content of job configuration of both test.getDependency and 'systemtest.getDependencyand puts them into a single Jenkinsfile - differentiated by a job parameter calledBUILD_TYPE` -- set in the jobs -- with default value "systemtest" for systemtest.getDependency, and "test" for test.getDependency.

PR tested by
test.getDependency : https://ci.adoptopenjdk.net/view/all/job/test.getDependency/157/
systemtest.getDependency: https://ci.adoptopenjdk.net/view/all/job/systemtest.getDependency/57/


Ability to generated specified number of sentences

A function to generate 'x' number of sentences as specified by the user.

Implemented in 3a5f95064dd4b3e7588a1cdedcfb3c145d44c3ba.


to remove the overlapping in iskcon event page

Before creating an issue, go through all open/closed issues to avoid getting your issue/suggestion marked as duplicate##
Issue and Steps to Reproduce:
Screenshots:
Expected:
Actual:
Additional Details:

Hello ma'am i have noticed an error in the iskcon event page .there is overlapping of the card and the footer section.
this can be easily resolved using basic html and css.
please assign me this under gssoc'24 contribution.

I want this this more attractive without such a problems like overlapping and extra size on right and i want shadow along with blur the background when showing event list , I want to work on this project kindly assign me this project.


Convert SessionDriver to a conformable protocol

This moves all of the logic for storing session information into a type that conforms to SessionDriver. An application can update the session driver at the start of their application by calling Session.driver = [YourSessionDriverType](). The Session class is refactored some to delegate value fetching & updating, and session destruction to the SessionDriver. Session identifiers have also been moved over to the SessionDriver class so driver writers can decide how best to determine key their sessions.

This looks good. Do we have any tests for Session currently?

@tannernelson We don't, I was planning on adding some after this got in though :)

@tannernelson clear to merge?

:shipit: it's got my vote

Had to update the branch. Once travis passes let's merge this.


Improve build-artifact to print mvn error to stderr

What changes are proposed in this pull request?
Redirect the err output to stderr, just like how we redirect to stdout

alluxio-bot, merge this please


Retrieval Redundancy Level not set (defaults to PARANOID)

Context
2.1.0-rc2 (and probably 2.0.* as well)
Summary
See #4693 for details, but tracking that down found that SetLevelInContext is never invoked by the /bytes api therefore when the joiner invokes GetLevelFromContext, it gets the default value of 4 or PARANOID.
Expected behavior
If the Swarm-Redundancy-Strategy is specified on /bytes, then I would expect it to be honored by the joiner.
Actual behavior
My hacked logs (see here  prove that the joiner is using rLevel = 4.
Steps to reproduce
Add your own logs, retrieve something with the /bytes API specifying Swarm-Redundancy-Strategy and verify that it doesn't get to the joiner.   Or just grep the source code for SetLevelInContext and GetLevelInContext.  The file pipeline invokes the former, but that isn't invoked for the root chunk.
Possible solution
Have the API invoke SetLevelInContext before creating the joiner.

In actual fact, it appears that the API doesn't have a way to specify the retrieval redundancy level, but only the strategy for prefetching and/or changing that strategy to a fallback.
This is decidedly bad IMHO.