Fixed CI builds for RabbitMQ

Added missing components (libevent and openssl) so our CI can handle RabbitMQ builds of AMS.
It will require a rebuild of containers.

How come the tests pass without changing the containers?

I did not change the containers, I just updated the Dockerfile. I built them locally on my side to make sure it works.

Can you add the tests in this PR? This change is dependent on the tests you want to add. What we should see is that the containerized tests fail, and (hopefully) succeed when the I build/upload the new containers and re-run the workflows.

Hum good point, the tests are in another PR. I will merge both PRs.

Are you adding also a gitlab test?

Are you adding also a gitlab test?

Yes I would like to, I have to check how to do that.

Are you adding also a gitlab test?

Yes I would like to, I have to check how to do that.

Check the script ci-build-test.sh under scripts/gitlab. Gitlab CI invokes this script. You can add a function to call where you run the rmq tests.

@lpottier  what is the status of this. I can see that AMSlib cannot establish a connection with the server. Are we missing container changes?

@koparasy I am working on it but the debugging has proven to be difficult. The Python tools using Pika are able to connect to the RabbitMQ container from the GitHub runner but the AMSlib fails to connect to RabbitMQ. This only happen in the GitHub runner, it works everywhere else (using the same container on LC machine etc).
I think its due to something when we connect to the service in the AMSlib specifically when the RabbitMQ service we connect to has no TLS enabled (so SSL is not needed). I am trying a few things to confirm that.


Data sampling proto

Remove PBD id filter from the SampleDataRequest; it was creating too much complexity for too little value.
Also rename request/response field names to match other instructions.
Task https://github.com/apache/beam/issues/25064

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Nothing is using this proto, so should be a safe change


Playwright testing

Description

[x] Playwright testing
[ ] stretch: automate startup of backend
[x] prepare some sample data  (see jobs LoadAll)

Resourcing
We intend to implement this task

Candidates for UI Testing checklist for Waltz
(Based off our manual testing)
Applications

[ ] Add / remove tag
[ ] Add / remove alias

[ ] verify searchable

[ ] edit app (desc, rating, phase etc)

Bookmarks

[ ] add / remove / edit
[ ] search / filter

Involvement

[ ] add / remove / edit

[ ] ensure user_selectable flag is respected

[ ] search / filter

Attestations

[ ] on demand

[ ] attest measurables
[ ] attest logical flows
[ ] attest physical flows
[ ] update permissions to add/remove attestation capability

[ ] via run

[ ] run creation
[ ] attest measurables
[ ] attest logicals
[ ] attest physicals

Measurables

[ ] add/remove/edit ratings

[ ] add/update comments
[ ] add decomm/revoke decomm
[ ] add/remove replacement apps
[ ] add/remove allocations
[ ] check little icon overlays are indicating decomm/replacements/allocations

[ ] roll-ups
[ ] inferred relationships

Technology

[ ] displays app level data
[ ] can search for servers
[ ] rolls-up
[ ] exportable via aggregate pages

Flows
UI tests for Logical, Physical flows and Lineage

[ ] Create logical flow
[ ] Create physical flow
[ ] Export Logicals  (agg/app)
[ ] Export Physicals (agg/app)
[ ] Create lineage
[ ] Edit lineage
[ ] Delete lineage
[ ] Add newly created physical to existing lineage
[ ] Delete logical flow which has physical flows already, should be prevented
[ ] Delete physical flow which is already used in lineage, should be prevented
[ ] Create a flow classification rule, check the logical flow view is updated with new rating/color
[ ]  Export data type list csv/xlsx and svg

App Groups

[ ] create/update group & desc
[ ] set public / private
[ ] check searchable
[ ] add / remove apps
[ ] add / remove CI's
[ ] add / remove OU's

[ ] associated apps added
[ ] associated CI's added

[ ] share group
[ ] subscribe / unsubscribe

Surveys

[ ] Issue runs
[ ] Issue individual surveys
[ ] Reassign recipients and owners
[ ] Can submit / approve / withdraw / reject / reopen surveys
[ ] Predicates work
[ ] Can export surveys (For a run, for individual responses)
[ ] Create/Edit templates and questions
[ ] Activate / Mark Obsolete or Draft

Assessments

[ ] Create/Update/Delete ratings
[ ] Bulk update ratings
[ ] Bulk export
[ ] Permissions are respected

Entity Relationships

[ ] Create/update/delete relations
[ ] Export ?

Admin

[ ] grant/remove user roles
[ ] add custom role
[ ] create/update/remove actor
[ ] Create/update/delete rating scheme
[ ] Create/update/delete assessment
[ ] Hierarchy rebuilds
[ ] Reassign recipients
[ ] Orphans
[ ] EUDA Promotion
[ ] Static Panels

[ ] include section help footer

[ ] create/edit actors

See java based impl on #6444

Tips:
highlight
locator.evaluate("d => d.style.border = '2px solid red'");

Example of doc support:


fix: Add -P flag for earhtly CI runner

It is needed to pass -P flag to earthly during tests running to fix the following issue https://github.com/input-output-hk/catalyst-ci/actions/runs/6733556300/job/18302659923

Let's modify this so that the test target is always given the -P flag. This will require changing a few things:

The run.yml workflow will need an input added for passing earthly flags. This input needs to then be fed into the flags input for the run action..
The ci.yml workflow will then need to be updated to pass the -P flag to the new input added above during the test step.

@jmgilman seems it is ready all check passed. You can check for this commit https://github.com/input-output-hk/catalyst-ci/pull/75/commits/3036b963e48c0d60f0f2bdff607f590226f9449f.


feature request: 'smart pasting' and/or 'pre_paste_hook' option.

I couldn't find a better place to suggest this since this plugin aims to replace the default bindings, creating a separate plugin would be a hassle. Consider this simple file ('*' represents the cursor position):
text1
text2
text3

text4
text5
text6

text7
text8
*ext9

AFAIK, there's no easy way to move the last paragraph to the top or vice versa with the correct position of empty lines. Here are some solutions I've considered:

dapggP: leaves empty line at the top and no empty line between the pasted paragraph and the following one.
dipggP: leaves an empty line at the bottom and no empty line between the pasted paragraph and the following one.

Please note:

While I could manually add or remove the empty lines, it's inconvenient.
Similar patterns arise with other objects, like moving the last word to the start of the line.
This is different from swapping.
I could create my own custom lua function to handle these cases. However, I can't see how to integrate it correctly with this plugin, and at the very least, it would be a clumsy solution. For example, I don't see a good interaction with the paste textobject.

So i thought this plugin could implement one or both of these solutions:

Handle these special cases without changing any register content and include options to enable or disable this behavior. The algorithm seems straightforward to me, a similar procedure would apply for words, just replacing lines by spaces:

Check if the text to be pasted contains a empty line at the end/start.
Check if we are at the start or end of the buffer.
Put and remove an empty line after/before the paragraph.

Add a simple pre_paste_hook option, customizable with a function that receives the text to be pasted and the type of pasting as input.

Let me know what you think!

Hi!
Thanks for this feedback.
There is already something like a pre_paste_hook, it's called wrappers (it's something like "middlewares").
I never took the time to document this but this is what I use to create Special put mappings.
You can see here how to register mappings with wrapper and here how to create a wrapper.
Let me know if this feature allows you to create your hook ;)


Mark functional interfaces in Functions

This is cosmetic but aligns all interfaces since one was already marked with @FunctionalInterface.
Fixes #191

Thanks!


Convert BasicStationEventScheduler to Use TimeSpans and DataFields

About the PR

I've edited the BasicStationEventScheduler gamerule to use TimeSpans, simply marking when the event will trigger and comparing it to the time instead of counting down, and to allow for modifying when events happen in the YAML rather than using hard coded values.
Why / Balance

This was changed as we wish to alter the values downstream, and don't want to alter the hard coded ones.
It only affects game balance if the server in question wishes it to.
Technical details

Instead of using hard coded numbers for randomizing when the next event will occur, the values are stored in the Component with a Datafield. Furthermore, the values are all stored as TimeSpans rather than floats, clarifying their usage (minutes, seconds, etc.). The next event's time is stored as an absolute time that it will trigger at, rather than as a countdown. It is than compared to the current time every update rather than the system counting it down (accumulator style)
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

The floats used in BasicStationEventSchedulerSystem and its Component have been replaced with TimeSpans. Simply using TimeSpan.TotalSeconds will easily fix this if anything else is using them.
No changelog required.

Do similar to the ramping event scheduler

Are you coming back to this? Most of the changes were already done in #29320 by now, but the conversion to use TimeSpans would still be needed.

Please comment in case you wish to continue working on this. I will reopen the PR then.


Add YodaStyleFixer.

Be formatted in yoda style (or not), code should.
This fixer can be configured to:

make code Yoda style, or:
make code no longer Yoda style, or:
don't run the fixer if you don't care

Fixer can be configured to change compare statements:

equal: == and !== (<>)
identical: === and !==
less_and_greater: <=, >=, < and >

You can combine any of the operator groups, if you don't like any of the groups don't run the fixer.
Default:
Fix to Yoda style for operators equal and identical.
Replaces;
https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2212
https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/701

Nice branch name ^^

👍 for the fixer, and 👍 for leaving less_and_greater out of the default config

What is left here is to decide to add more configuration options for setting which kind of comparisons should be fixed. Based on previous discussions it seems some people would like to target no-vars like (array(2)) and self::MY_CONST while other don't. Like to get some feedback so this fixer can finished :)

@SpacePossum thanks for pointing to this PR, I tried to search for "yoda" and "cond" with no luck and thought YodaConditionFixer was renamed to something less predictable.
Why Yoda-style is default one in AutomateEverything era? Most of experienced programmers have got some professional deformation and read null === $something better than $something === null?

The rationale behind the defaults in this project (and this PR) are based on:

current CS in the project
expected most used values

I added the options to prevent discussion about what is best and why. With the options everyone can use the fixer as wanted. So lets see what options are missing, what bugs are left in this PR or where other improvements can be made here.

Please rebase

Any updates on this? Should just conflicts and build be fixed or is there more to this? Thank you!

rebased
@hkdobrev there are a few cases still failing (related to array destruction) and some tests are missing for new PHP syntax features (fixer was written before PHP 7 launched).
Please let me know if you can help out finishing this :)  (or anybody else, all help is welcome here)

Sadly, tests are failing

all green... cause... the test that was failing was because the expected and output were swapped...
: D
Anyway, what is left is test cases for all the new syntax stuff PHP7 and up provided.
Therefor I would ask all people here to come up with nice test cases :)

TODO: test on mulitple repo's to see if all good

@SpacePossum Symfony follows yoda, could you please test it on that repo?

https://github.com/SpacePossum/symfony/pull/1
:tada:

I found a bug :(
related to https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2446#discussion_r136873586
working on it

all done.. I hope

both fabbot and Travis failures are false-negatives, sadly

wow, now we get broken pipe on 5.6? wtf?

Thank you @SpacePossum.

Nice work!

@keradus shouldn't this fixer be part of Symfony rule set?

@kubawerlos , yoda style is part of Symfony styleguide indeed. Yet, yoda could be understand very differently, that is why we have configuration options here (yet not all different understanding of yoda is covered by options, there are many edge understanding of this rule).
Shall this fixer (configured somehow) be part of Symfony ruleset? Yes, as soon as Symfony as a group would be willing to have it - either directly (by sending a PR that would change a ruleset) or indirectly (by accepting https://github.com/symfony/symfony/pull/24123 )

I don't understand the configuration options...
yoda_style [@Symfony]

Write conditions in Yoda style or not based on configuration.

Configuration options:

equal (bool, null): change equal (==, !=) statements; defaults to true
identical (bool, null): change identical (===, !==) statements; defaults to true
less_and_greater (bool, null): change less and greater than (<, <=, >, >=) statements; defaults to null

They all say: "Change X (if true) or not (if false)". Apparently that's not right. According to the 1st post in this ticket, it does something like:
true = Force to yoda style.
false = Force to non-yoda style.
null = Do nothing.
The docs need a little rewrite, perhaps?

Hi.
Feel free to raise PR with description improvement :+1:

@keradus Hi. Alright! https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3070 :-)

Hi!
If this PR is closed, why it's mentioned as part of the latest release instead of #3070?
I mean, I got confused reading the release's description :dizzy_face:

@devdrops it was merged manually via https://github.com/FriendsOfPHP/PHP-CS-Fixer/commit/73fddc63275df7298d409a2e957c8fd688af1227.


Mudassir014patch 01

Corrected some issues at https://docs.microsoft.com/en-us/aspnet/core/fundamentals/logging/?view=aspnetcore-6.0#configure-logging to correctly bridge the content and the preceding JSON.
Took reference from https://docs.microsoft.com/en-us/dotnet/core/extensions/logging?tabs=command-line#configure-logging

The similar section at https://docs.microsoft.com/en-us/dotnet/core/extensions/logging?tabs=command-line#configure-logging has some additional information as well. Let me know if I should add that as well.

Hi @mudassir014. Thanks for taking the time to open a PR.
The section you've changed describes the appsettings.Development.json file generated by the templates, which includes the Microsoft.AspNetCore property. As the section is intended to be an explanation of the template-generated configuration, I think we should leave the explanation as-is.

Having said that, I think the current explanation suggests that the Microsoft category exists in the preceding JSON, but it doesn't. @Rick-Anderson Should we do something about that?

Thanks again @mudassir014. I think this latest version looks good, but I'll wait for @Rick-Anderson to review it before considering a merge.

@mudassir014 really nice fix. Keep them coming.
Be sure to check out your name as a contributor about the 3rd of next month on the What's new page in the Community contributors section at the bottom.

@Rick-Anderson Will do.
@Rick-Anderson @serpent5 Thank you for everything. :)


building for Windows 10 store failed because of file within DiskSpaceLibrary

When submitting to the Windows store, my app did not pass one specific test:

How do I empty the resources file? Or does somebody know whats going on here?

Hi,
I think the problem is caused by the file DiskSpaceLibrary.rd.xml. Can you try to rebuild winmd file without this file?

Sorry, I never got back around to testing this solution. Will try building for production.

To close!


Remove application folder from repository

Please remove any pre-compiled addins from the repository.

Done

verified.


preservation_statement in dataset is insufficiently described

preservation_statement needs a better explanation. What is supposed to be stated here?

This is kind of a catch-all field for human-readable narrative on anything that has to do with digital preservation. For, example: "Tell us why you believe your data must be kept for 100 years". I hope this helps.


env var to disable sso signup

Hi, would you consider an env-var-enabled enhancement that allows SSO login for existing accounts, but disables SSO signup? Atm if you login with Google and a user does not exist it creates a user and logs them in.
eg AUTH_PROVIDER_SIGNUP_ENABLED (true by default)

I think this is a good idea.
In the meantime, you can use the AUTH_ACCESS_CONTROL_* env vars to block/allow emails to sign up.


AssertionError in the results.py (ultralytics)

I am trying to work with your YOLOv8 CAM; however, I am getting an AssertionError in BaseTensor class in the results.py line 32.
Initially, the problem originates from this line:
grayscale_cam = cam(rgb_img)[0, :, :]
It does predict the class correctly:
224x224 golden_retriever 0.41, Labrador_retriever 0.30, Great_Pyrenees 0.09, kuvasz 0.04, cocker_spaniel 0.03, 2.4ms Speed: 1.0ms preprocess, 2.4ms inference, 0.0ms postprocess per image at shape (1, 3, 224, 224)
that comes from here:
ultralytics\yolo\engine\results.py", line 32, in __init__     assert isinstance(data, (torch.Tensor, np.ndarray))

It seems that the model does predict the classes correctly and the data in this class is a tensor/numpy array the first 3 times, but then it becomes a single digit, so it no longer is a tensor or a numpy array. This is outside of your code, but I was wondering if you have encountered anything like this before.
I also tried to convert the image to tensor as it was introduced here:
transform = transforms.ToTensor()
tensor = transform(img).unsqueeze(0)
grayscale_cam = cam(tensor)[0, :, :]

but no success.

Hey! Thanks for your inputs in this. It is a hacky solution indeed. I will see if there's a better way for this. Till then you can use the method you've suggested.

This seems like an issue for the new version of ultralytics. I will try to fix it, but till then I recommend you to use ultralytics-8.0.107 or below if you want to use the package.


Yogesh/multi crypto no vrf

Description

Use HeaderCrypto to separately parametrise HeaderBody
The ledger Era is only bound to standard Crypto
The consensus protocol is parametrised by Crypto and HeaderCrypto

Note that

Only ouroboros-consensus-protocol is compiled
ouroboros-consenus-cardano libarry is WIP, and only Block.hs is
changed to reflect the fact that it is possible to use a separate
HeaderCrypto for an era (and define the the cardano eras) parametrized
by different crypto version. Each version reflecting a unique
combination of standard Crypto and Header Crypto.

This repo is compiled against ledger branch (see
https://github.com/input-output-hk/cardano-ledger/pull/3262). You might
have to change cabal.project to compile against git repository
Checklist

Branch

[ ] Commit sequence broadly makes sense
[ ] Commits have useful messages
[ ] The documentation has been properly updated
[ ] New tests are added if needed and existing tests are updated
[ ] If this branch changes Consensus and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
[ ] If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
[ ] If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.

Pull Request

[ ] Self-reviewed the diff
[ ] Useful pull request description at least containing the following information:

What does this PR change?
Why these changes were needed?
How does this affect downstream repositories and/or end-users?
Which ticket does this PR close (if any)? If it does, is it linked?

[ ] Reviewer requested

Routine cleanup of stale PRs targeting Consensus components (which nowadays live in https://github.com/IntersectMBO/ouroboros-consensus).
No work is lost, see https://stackoverflow.com/a/17954767.


Any plans migrating to React 18+?

Is your feature request related to a problem? Please describe.
Migration to React 18.
Describe the solution you'd like
A plan on whether React 18 migration should attempted.
I've spent the past day trying to migrate Player to React 18 myself in a fork. There are a few old and outdated dependencies currently being used. I imagine there would be substantial effort to continue this migration.
It seems like a few of these outdated dependencies are from the docs site, whilst the main ones attached to Player itself are React, React-DOM and Typescript (As my current depth of changes have found anyway) - which is also quite an undertaking.
As other projects by the community proceed to use newer versions of React, the peer dependencies attached to Player will just cause Node install errors.
Are there any thoughts on this and any worries / concerns?
Cheers!

Most of our major refactors (including the update to<EMAIL_ADDRESS>are staged on the bazel-6 branch https://github.com/player-ui/player/pull/252
There were some pretty major changes to our builds (we may also go straight to bazel 7 now), in addition to updating all of the dependencies across the project to the latest. We're still waiting on a few other updates (android & jvm builds, etc) in order to get canary builds out to start testing, but we are working towards releasing support for react@18 soon.

Most of our major refactors (including the update to react@18) are staged on the bazel-6 branch #252
There were some pretty major changes to our builds (we may also go straight to bazel 7 now), in addition to updating all of the dependencies across the project to the latest. We're still waiting on a few other updates (android & jvm builds, etc) in order to get canary builds out to start testing, but we are working towards releasing support for react@18 soon.

Appreciate the quick response. Glad to hear!
I'll keep an eye out for those canary versions :)


 This PR fix that.
Checklist:

[X] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.
[X] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Is there an github issue connected? Please describe what problem we're addressing and why this fixes it.

@MartinHjelmare If two instances of Airly integration are added, only the second one will be properly initialized at HA startup. First AirlyData object of config_entry will be removed from hass.data[DOMAIN][DATA_CLIENT] due this. This PR moves
hass.data[DOMAIN] = {}
hass.data[DOMAIN][DATA_CLIENT] = {}

to the right place: async_setup function.

Failed tests are unrelated and have already been fixed on dev branch.


How can I access to validator in interceptor?

Hello, I'm a noob in js and vue, I'm trying to add dynamically errors to validator from the server
if(status === 422) {
  var errors = error.response.data.errors
  for (var field in errors) {
    var field = errors[field]
    for (var i = field.length - 1; i >= 0; i--) {
      var current_message = field[i]
      this.app.$validator.errors.add(field, current_message)
    }
  }
}

This is the bad line => this.app.$validator.errors.add(field, current_message)
This interceptor is in a module, not in a vue component.
Please don't judge me :( I don't know how to make it work.
Thanks for your attention.

It depends where your snippet is located, if you can create a small dummy example that would be great.
Assuming your snippet is located in a Vue method, you can access it on this directly.
export default {
 // ... component code
 methods: {
    submit () {
      // Whatever
      if(status === 422) {
        var errors = error.response.data.errors
        for (var field in errors) {
          var field = errors[field]
          for (var i = field.length - 1; i >= 0; i--) {
            var current_message = field[i]
            this.$validator.errors.add(field, current_message)
         }
      }
    }
    }
  }
}

This works in a Vue component, but I need make it works in an interceptor.
This is validator-client.js
`import Vue from 'vue';
import VeeValidate, { Validator } from 'vee-validate';
import { availableLanguagesForValidation } from '../utils/constants'
Object.keys(availableLanguagesForValidation).forEach(function (key) {
var value = availableLanguagesForValidation[key]
var current_item = require(vee-validate/dist/locale/${value})
Validator.localize(key, current_item);
});
const { locale } = window.config
const config = {
errorBagName: 'errorsClient', // change if property conflicts
fieldsBagName: 'fields',
delay: 0,
locale: 'es',
dictionary: null,
strict: true,
classes: false,
classNames: {
touched: 'touched', // the control has been blurred
untouched: 'untouched', // the control hasn't been blurred
valid: 'valid', // model is valid
invalid: 'invalid', // model is invalid
pristine: 'pristine', // control has not been interacted with
dirty: 'dirty' // control has been interacted with
},
events: 'input|blur',
inject: true,
validity: false,
aria: true
};
Vue.use(VeeValidate, config);
`
And I have another file named axios-interceptor.js. I want to make it works in this file. So, Do I need to import "$validator"?

If you can access your component from the interceptor then you are good to go, but if not then I don't think its possible.

Do you know how can I Access the component? :(

There is no universal way, it depends on how your app is structured. For example for http requests I create a mixin for my components.
const httpMixin = {
  beforeCreate () {
    this.$http= axios.create({
       // axios config
     });
      this.$http.interceptors.response.use(response => {
          console.log(this.$validator); // 'this' is the component.
         // Do something with response data
        return response;
      }, function (error) {
        // Do something with response error
       return Promise.reject(error);
    });
  }
};

Using mixins, Vue plugin API makes it easier to access components or other contexts to create utility objects for you components.
PS: axios is the http module.

Hey, I made a mixin, but this.$validator is undefined :(
const axiosMixin = {
  created () {
    axios.interceptors.response.use(response => {
      //return response;
    }, function (error) {
      if(error.response.status === 422) {
        console.log('mixin de brian')
        var errors = error.response.data.errors
        for (var name in errors) {
          var field = errors[name]
          for (var i = field.length - 1; i >= 0; i--) {
            var current_message = field[i]
            console.log(current_message)
            console.log(this.errorsClient)
            console.log(this.$validator)
            this.$validator.errors.add(name, current_message)
          }
        }
      }
      return Promise.reject(error);
    });
  }
};

export default axiosMixin```

@logaretm How are you doing?
This question I do think is still open.
How I can access the this.$validator that is related with a vue component in an external js file?
I do have an helper (js file) in which I define an axios interceptor for the response. I am able to access the routes or the store without using this.$, but I cannot access the validator.
If I create anew instance of the validator (validator = new Validator()), I clearly don't have access to the component instance. The idea is to move the error catching in the interceptor, so also the validation.
I checked the mixin solution but it doesn't really work, without repetition of it in different components.
Do you have some suggestions on how access this.$validator inside of an axios interceptor located in an external file in relation with the component?


Implement python per_rpc_creds interop test.

With the new Metadata API, it should now be possible to do this properly.
Original meta-bug: #3842

Actually, it would be good to have this for 0.12 release, so we can make sure the per-rpc creds functionality works well againts other languages.

Remilestoned to 2016/02/15 more for "I believe this is doable now and if it isn't we should find out now" than any other reason.

Remilestoned because we didn't get around to it. -.-'


Update to Node 0.6 API

Dropped a return value that wasn't checked and was always the same.

Thanks for the pull request, I was just thinking about updating my package.json earlier today.

Sadly, I didn't look beyond getting it to compile, so there's still more to do.


Update root.md to use get_response_synthesizer expected type.

Description
As in the title, the type for the kwarg response_mode expected an object of type ResponseMode, so I have updated the doc accordingly.
Fixes # (issue)
Type of Change
Documentation update.
How Has This Been Tested?
I have run this code locally, and the type checker doesn't complain any more.

Hmm, right, but strings also work (i.e. ResponseMode.COMPACT == "compact")
But, we can merge this anyways 👍🏻


Documentation update: empty dependency version strings will no longer be accepted when pushing packages to nuget.org

The task is to document the behavioral change in how we validate package dependency version ranges.
Page affected:
https://docs.microsoft.com/en-us/nuget/create-packages/dependency-versions#version-ranges
Moving forward, nuget.org will be strict and no longer accept packages defining dependencies with an empty version range.
The change to reject empty dependency version ranges is in line with the recommendation as per the docs, which now will be enforced.

For consistent behavior, it's recommended to always specify a version or version range for package dependencies.

Current docs state:

If no version is specified for a dependency, NuGet behaves as follows:
NuGet v2.7.2 and earlier: The latest package version will be used
NuGet v2.8 and later: The lowest package version will be used

I think we should modify this and add:

NuGet v2.8 to v4.1.0: The lowest package version will be used
NuGet v4.3.0 and above: no longer supported and considered an invalid dependency version range

The above of course assumes that NuGet v4.3.0 aligns behavior for pack :) (tracked by https://github.com/NuGet/Home/issues/4985)

In addition to the above future client-behavior change, we should also point out that nuget.org behavior changes as part of deployment https://github.com/NuGet/NuGetGallery/issues/3718.
From then on, the gallery will be more strict and reject packages with invalid dependency version range declarations.

Client pack behavior change is likely only to be part of v4.3.0, so that docs change can wait a little.
Server side change will go live this sprint.
Suggested addition (feel free to reword):

The nuget.org web site no longer accepts packages that declare dependency versions with an empty version range.
By enforcing our earlier recommendation, the nuget.org package validation became a bit more strict, and both service and client became a bit less subject to potential errors caused by illegal dependency version ranges.


Screen input directory for new infohash matches.

When trying to find torrents, crops can now tell whether a torrent with an infohash corresponding to a different destination is present in the source directory. This means that there's a lot of savings in API requests after the first time running the program.
After both of the pull requests that I've made get merged I will clean up the flow control, etc.

I will make the output directory check use an infohash dict as well.

@resu-detcader Just letting you know I'm working on a fork of crops with several updates/enhancements if you're interested: https://github.com/moleculekayak/fertilizer
I've integrated changes similar to what you've proposed here in https://github.com/moleculekayak/fertilizer/pull/3


Make wireless

I have a JY-MCU bluetooth module that's fairly trivial to configure.

I have an Arduino Mega that we can use for this. We'll need the extra oomph. I will add this to my project board and bring the Mega down with me after break.

Great. We'll definitely need it down the road.

JY-MCU module up and working. Wired data connection no longer needed. Power currently provided by a rechargeable lithium backpack.

I have packed this. I am also bringing down an arduino Due, which should be even more capable to handle the throughput. I also have a bunch of other sensors and hardware that we could use.


Add Kyro Network

Fixed.

@GrowlyX What's up with this PR?

@GrowlyX What's up with this PR?

@GrowlyX What's up with this PR?


same issue #161 coverage warning "no data was collected" issue Create issue Issue #161

Originally reported by Anonymous

the error raise "coverage warning "no data was collected"   because .pyx file are not analysed by coverage.py.
I do not understand why it's not working
I used in setup.py file for compilation
define_macros=[('CYTHON_TRACE', '1'), ('CYTHON_TRACE_NOGIL','1')],
compiler_directives={'embedsignature': True, 'linetrace': True,
Do I miss something

Bitbucket: https://bitbucket.org/ned/coveragepy/issue/653

The reporter on this is unavailable so there's probably no need to keep this issue open. FTR this might've been an instance of the Cython coverage plugin bug: https://github.com/cython/cython/pull/3648.


CLOUD - mobile view menu icon removed

Need to remove menu icon from mobile view

as we don't have navbar secition there yet.

done at staging
https://www2.cloud.threefold.io/


Frontend: Footer Component #7

Description
This PR is for the Footer React component .This Footer will displayed in all pages with same options to link these pages About us, Contact us , Creating new user account and email.
Fixes # 7
How to test?
By running this command "npm run dev" you can test the file.
Please provide a short summary how your changes can be tested?
Checklist

[x] I have performed a self-review of my own code
[x] I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
[x] I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
[x] I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
[x] This PR is ready to be merged and not breaking any other functionality

Footer in Ipad size looking good but if we align the logo to the left like other elements it will looks better
and the same in mobile size "i can not see the logo and elements needs to be in column"

Good Job @santhoshboinapally  💪🏻

Hi @santhoshboinapally !
What is the reason to delete src/client/containers/Home/Home.js 😀 ?

Hi @h09shais actually those files I have to commit with another branch, so I removed them and created another PullRequest.


An opinion

Your syntax theme, gosh! Been looking all over for a theme to fall in love with, and then I found yours!
When typing in my .css-file
I think that the ".selected" and ":hover" should have some other color than the standard.
For example:
nav a.selected, nav a:hover {
color: #32673f;
}
Hope you can consider this, so I can continue to brag about the color scheme. :happy

It sounds good. I've updated the syntax.


Backfill alerts for smokey loop features

https://trello.com/c/D2Yt6TrG/251-audit-tests-in-the-smokey-repo
Depends on: https://github.com/alphagov/smokey/pull/886 - where we start
running search_api.feature in Integration.
Please review commit by commit.

@ChrisBAshton thanks for the review!
I've deployed this on a branch to Integration to verify the two new alerts work ✅. The "publisher" one looks like it might be flakey, but that's just a reason to push forward so that the problem is more visible.
I don't have access to check Staging or Production:

For Staging I would verify that a new alert exists for "search_api" Smokey loop and is "OK".
For Production I would just check some existing alerts are still there and are as "OK" as they were before.

Would you like to merge and deploy this all the way?


HugePages <> memory_target

My installations are creating databases with memory_target which means that Oracle is unable to use HugePages, which is fine in small environments with less processes.
The current way for setting the hugepages in percent of RAM is not a good idea, because it is hard to define a good limit in systems with big memory. I prefer a solution with a fixed value of number of hugepages or a memory size which will be calculated to the right number of pages.
Any wish how we could solve this? I could implement it but like to know how it should be implemented in ansible-oracle.
The last step is the correction for real usage of HugePages while creating the database which is a 2nd part of this problem.

I don't really see the problem with this (or maybe I dont understand what you mean).
Does it matter if you specify HP as a percentage of RAM or set it as a fixed size? You still need to do the hugepages/sga math and will end up with the same number of HP.
And defining a limit on systems with big memory is something you still have to do, regardless of if you calculate by percent or not.
If I say "use 256GB" for hugepages or "50% of 512GB" for hugepages, they're both the same thing and the number of hugepages will be the same.
However, if you really want to add the possibility to configure HP by actual memory size, I'd create a variable that defines whether HP should be calculated as a percentage or as a fixed size.
configure_hugepages: true/false
configure_hugepages_by: memory/percentage (with percentage as the default, as it is today)
percent_hugepages:
size_in_gb_hugepages:
And then in the calculation use a jinja if/else to use the correct variable.

1st part is the configuration of HugePages. Most of our DBAs are known with the calculation and feel a little bit irritated to use the calculation based on a percentage of the physical memory.
I could implement that, because I like to have it. :-)
The 2nd part - the more important one - is using the HugePages in DBCA. As long as you use 'memory_target <> 0' Oracle is unable to use HugePages on Linux. You must use memory_target=0 and pga_aggregate_target and sga_target for the memory sizing of the instance.

yeah, ok. Just different approaches ;-)
I'm definitely not against having an alternate way of setting hugepages (I just want to make sure they're used ;-) ), so go ahead.

That is a dbca issue, it doesn't honor using anything else than memory_*  when using a reponsefile. It doesn't matter that you explicitly set it to NOT use memory_* (like I do in the dbca templates) , it just does it anyway.
I even had a SR opened, but it didn't really go anywhere.
I've been thinking about not using the responsefiles (just using the bare dbca command with all its switches as it seems to accept more init-parameters than using a responsefile) but I haven't been irritated enough yet ;-) Instead I've got a few modules (oracle_parameter/oracle_user/oracle_tablespace etc) that I use as part of the installation and set the parameters I need and create the users/tablespaces etc with that. So in the end, it's been easier to just use the responsefile for the initial creation and then use the modules for post-creation tasks.

The modules are in the ansible-oracle-modules repo.

I am linking this issue to #7, because I did already a lot of stuff for creating the database from sql scripts. This is requirred, when a limitted number of options are needed in the data dictionary with multitenant option - hopefully Oracle change this in 12.2.
There is no other way then using sql scripts atm. So we could go this way for all installations and have a solution for this problem with hugepages.
The idea with the post sql with addional modules is really cool and working.

I had some time over, so as of 44a3cf3f9860f1d6c895e4e8c0edb0557021c55c it is now possible to set the huge page config as an amount of RAM in GB, not just by a percentage.


Avoid top-level with in lib/tests/misc.nix

Description of changes
Using with at a top-level scope is an anti-pattern. The tracking issue is #208242. This is a pure refactor: there is no functional change contained in this PR.
I used the refactor strategy that looks for the uses of names coming from lib. I skipped this file initially because I wanted to take special care not to regress the tests.
Related:

https://github.com/NixOS/nixpkgs/pull/295020

Things done

[x] Tested, as applicable:

[x] nix-instantiate --strict --eval lib/tests/misc.nix

[x] Fits CONTRIBUTING.md.

We don't have a good alternative other than making roughly 5% of the file a gigantic list?

The other alternative that is strictly more readable than the status quo are qualified names (lib.thing). We discussed this on one of the other related PRs. @Infinisil opted to go ahead with this pattern, and given that's slightly more performant, and that the qualified calls require more nuanced discussion and more involved code changes to keep the character noise low, I think, while not optimal, it's sensible to proceed and fix forward. I'd also argue that setting an example for allowing net-positive changes without too much fuzz is valuable psychologically and helps retain and attract contributors, and from those graduate more maintainers.

We don't have a good alternative other than making roughly 5% of the file a gigantic list?

This file, due to being a test of lib, isn't really representative of most users, who want one to ten things from lib. The list is also saying that the test likely could be split up into multiple files in order to be more specific about the things it's testing -- as the name suggests, misc is everything.
But yeah. While there are other ways of styling this code to not be so incredibly vertical, I think this is a net win across the entire codebase, if a little longer in this file specifically. Note that the other way avoid with is to change every use site (so thing turns into lib.thing), which would changed close to 90% of this file.


Add Openvino embedding support

This PR is used to support both HF and BGE embeddings with openvino

lgtm, any other comments @eaidova @AlexKoff88?


Multi GPU - Attempt to call field 'GPU'

I get the following error when I try to use the multi GPU
when i use GPU 0,1
/home/ubuntu/torch/install/bin/luajit: neural-style/neural_style.lua:403: attempt to call field 'GPU' (a nil value)
stack traceback:
neural-style/neural_style.lua:403: in function 'setup_multi_gpu'
neural-style/neural_style.lua:153: in function 'main'
neural-style/neural_style.lua:604: in main chunk
[C]: in function 'dofile'
...untu/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:145: in main chunk
[C]: at 0x00406670
when i use GPU 0,1,2,3
/home/ubuntu/torch/install/bin/luajit: neural-style/neural_style.lua:372: attempt to get length of local 'gpu_splits' (a nil value)
stack traceback:
neural-style/neural_style.lua:372: in function 'setup_multi_gpu'
neural-style/neural_style.lua:153: in function 'main'
neural-style/neural_style.lua:604: in main chunk
[C]: in function 'dofile'
...untu/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:145: in main chunk
[C]: at 0x00406670

Update the core torch packages:
luarocks install torch
luarocks install cutorch
luarocks install nn
luarocks install cunn

this did the thing. youre the best

Yep this fixed the issue for me too. Only problem is now I'm inspired to buy a second Titan X.


Laravel Mix keeps rebuilding in development container

So just spend this whole day fixing this issue on my machine 😢  Thought I might give you guys the solution if anybody is facing the same issue.
Because of something, my ghost container was having issues with the files in the .git folder of this project. The solution was for me to overwrite it with a non-existing folder with the following addition on the docker-compose.yml file:
    volumes:
      - .git:/var/lib/ghost/content/themes/liebling/.git:Z
      - ./..:/var/lib/ghost/content/themes/liebling:Z
      - ./ghost.db:/var/lib/ghost/content/data/ghost.db:Z

I think I'm having this same issue, but this fix didn't help me. Am I supposed to replace that with the volumes that were already in the docker-compose file ? It didn't help

You can test if you have the same issue easily by running
docker-compose up

in the src folder. Does the container start up successfully, without any warning / error logs?

docker.errors.DockerException: Error while fetching server API version: (2, 'CreateFile', 'The system cannot find the file specified.')
[14964] Failed to execute script docker-compose

It also says when i run the docker-watch that I'm trying to send a windows file to a linux container and that it may perform bad. And it says that the Windows Home can only run the WSL 2 backend

Please first try to run that command without changing the docker-compose file. Also, I seem to have misunderstood why my solution was working. I have a .git folder in my src folder.

This is what i get with the normal docker-compose file:
Recreating ghost ... done
Attaching to ghost
ghost    | [2020-10-14 09:49:15] INFO Ghost is running in development...
ghost    | [2020-10-14 09:49:15] INFO Listening on: <IP_ADDRESS>:2368
ghost    | [2020-10-14 09:49:15] INFO Url configured as: http://localhost:2368/
ghost    | [2020-10-14 09:49:15] INFO Ctrl+C to shut down
ghost    | [2020-10-14 09:49:15] INFO Ghost boot 5.156s

Your container seems to be working. I'm sorry but you seem to have a different issue than mine.

Ok, so, i just figured out i can access the /ghost (the admin page) , but i cant acess the normal :3000 port.
Maybe because the WSL2 only gives me backend ? I don't know


TypeChecker.fromName does not work with built-in dart packages

Describe the bug
The type check utility _NamedChecker returned by TypeChecker.fromName('name', packageName: 'package') assumes that packageName is the name of a package addressable with a package: URL. When using the isExactly(element) comparison, element.library.identifier is compared against 'package:$packageName/'.
This behavior prohibits the type checking of Types from built-in dart packages, as their identifiers start with dart:.
To Reproduce
This lint rule should detect File.open() invocations. Currently, it does not work as I would expect.
const _fileChecker = TypeChecker.fromName('File', packageName: 'dart:io');

class FileOpen extends DartLintRule {
  FileOpen() : super(code: _code);

  static const _code = LintCode(
    name: 'file_open_invocation',
    problemMessage: 'File open method invocations are bad!',
    errorSeverity: ErrorSeverity.ERROR,
  );

  @override
  void run(CustomLintResolver resolver, ErrorReporter reporter, CustomLintContext context) {
    context.registry.addMethodInvocation((node) {
      var type = node.realTarget?.staticType;
      if (type == null) return;
      if (!_fileChecker.isExactlyType(type)) return;
      if (node.methodName.name != 'open') return;
      reporter.atNode(node, _code);
    });
  }
}

Expected behavior
I expect _NamedChecker.isExactly to have extra handling for packageNames starting with dart:. In these cases, no string modification should take place to compare library identifiers.
I'm open to feedback if I understood something wrong here, it is my first time using custom_lint.

It's low priority for me. Feel free to make a pr :)


Update Orderbook Websocket

This is an implementation wich results in user not needing to mess around with the websocket.
He just needs to store object and lateron call .get_current_book

I prefer the changes made in #272 -- if you have additional performance gains here, please merge to the current master branch.


[Live Share] Remove VSLS from supported scheme list

Since making PR #28, we've added support to Visual Studio Live Share which allows language services to be remoted from the host (i.e. the developer that shared) to all of their guests. In order to optimize for the scenario where the host and guest both have the Code Spell Checker extension installed, we only want the host's to be generating diagnostics, since it would have full access to the project. Therefore, this PR undoes #28, in order to provide a better Live Share experience. Apologies for the churn!

Coverage remained the same at 98.164% when pulling dab65146c3339e011818aa0d9b95c508e00fa235 on lostintangent:patch-1 into 796361ac227d7eb36ac0274f26a7917bac9861ec on Jason3S:master.


Produce adequate returncode

GoPaddy can operate on a single or multiple inputs during one execution. In latter case, if one input produced error, GoPaddy issues a warning to the standard error and continues with processing the next input value. In this case there’s no way to properly reflect those errors in process return code, which is set to 0.
However, if there’s just one input value, and processing fails, the return code should be set to non-zero value.
This way we can inform the caller about failure. This feature is useful in tool chaining, where GoPaddy is called with a single input value every time.

Fixed in https://github.com/glebarez/GoPaddy/commit/86f4a598f9802f20bd09a5963fcd7195991f7c58


Add support for enabling kernel modules

Garden’s filesystem plugin shed requires aufs. The shed plugin modprobes aufs normally when used.
When garden is run inside a container, the plugin cannot modprobe so we’d like the host VM to already have aufs enabled. This is for use in our CI.

@cppforlife any thoughts on this?

+1 We on cf-networking would like this too. We have the need to enable ifb on our concourse workers.


Verify TLS server side operation

Verify, and implement if necessary, that TLS server side is functional.

Already worked with #8814.


[Help]Using Google Fonts with Elegant

[x] I am using latest production release of Elegant

I am trying to use Google fonts with elegant, but I am not sure how I would modify the HTML header in base.html to add the Google Fonts in the  section.
You recommend not changing the templates code as it is a maintainability nightmare which I agree with. What would the best way to do this?
Is overriding a template possible? Such as overriding base.html so that I can just add my customizations have that be taken as the new base.
Kindly let me know.
Thanks in advance.

Elegant already has a Google font. See the code here.
You can use custom.css to override it.
Can you tell me why you want to change the font?

Thank you @talha131  for your reply.
My friend is moving over his site from another platform and likes your theme but he is very particular about fonts and typography.
He wishes to use the Noto Serif font and I wanted to know how I would go about it. Usually, I would have to add the link rel attribute of a Google Font to the  of the document to be able to use it.
But does your theme download whatever font the user wants to use just by changing the custom CSS without specifying a specific link rel? Please tell me how this works and demystify me.
Lastly, I have a question about overriding templates. Let us say I wanted to be able to order the links on the navigation bar in a particular way and need to add some jinja code. I do not want to go into your theme's template and do this, instead, I would like to specify my own base.html and make the theme use that. How would I go about this?
I am newbie to Pelican and am just trying to help a friend out with his website and learning as I am going along.
Cheers.

But does your theme download whatever font the user wants to use just by changing the custom CSS without specifying a specific link rel? Please tell me how this works and demystify me.

You do not need to modify <head> to get Google font. You can import the fonts in CSS.
https://stackoverflow.com/a/14676665/177116

Let us say I wanted to be able to order the links on the navigation bar in a particular way

We plan to add this feature in our next major release. https://github.com/Pelican-Elegant/elegant/issues/139


Add cluster_name variable to avoid -cluster name suffix

what

Added cluster_name variable to allow naming without -cluster suffix

why

If migrating to this module the cluster name may not end with -cluster and it's neccessary to override the name of the resource.

references

Closes #171

Looks good to me. Let's get one last review from a couple others before merging it.
cc @Nuru @aknysh

/test all


TypeError: Cannot read property 'length' of undefined

I do get this error fairly often:
$ ember s
Livereload server on http://localhost:49153
The Broccoli Plugin: [broccoli-typescript-compiler] failed with:
TypeError: Cannot read property 'length' of undefined
    at createSourceFile (/path/to/my/project/node_modules/typescript/lib/typescript.js:15396:109)
    at parseSourceFileWorker (/path/to/my/project/node_modules/typescript/lib/typescript.js:15328:26)
    at Object.parseSourceFile (/path/to/my/project/node_modules/typescript/lib/typescript.js:15277:26)
    at Object.createSourceFile (/path/to/my/project/node_modules/typescript/lib/typescript.js:15131:29)
    at SourceCache.getSourceFile (/path/to/my/project/node_modules/broccoli-typescript-compiler/dist/plugin.js:98:43)
    at Object.getSourceFile (/path/to/my/project/node_modules/broccoli-typescript-compiler/dist/plugin.js:300:85)
    at findSourceFile (/path/to/my/project/node_modules/typescript/lib/typescript.js:67716:29)
    at processSourceFile (/path/to/my/project/node_modules/typescript/lib/typescript.js:67647:27)
    at /path/to/my/project/node_modules/typescript/lib/typescript.js:67757:17
    at Object.forEach (/path/to/my/project/node_modules/typescript/lib/typescript.js:1443:30)
    at processReferencedFiles (/path/to/my/project/node_modules/typescript/lib/typescript.js:67755:16)
    at findSourceFile (/path/to/my/project/node_modules/typescript/lib/typescript.js:67740:21)
    at processSourceFile (/path/to/my/project/node_modules/typescript/lib/typescript.js:67647:27)
    at processRootFile (/path/to/my/project/node_modules/typescript/lib/typescript.js:67535:13)
    at Object.createProgram (/path/to/my/project/node_modules/typescript/lib/typescript.js:66845:21)
    at Compiler.createProgram (/path/to/my/project/node_modules/broccoli-typescript-compiler/dist/plugin.js:236:22)

The broccoli plugin was instantiated at:
    at TypeScript.Plugin (/path/to/my/project/node_modules/broccoli-plugin/index.js:7:31)
    at new TypeScript (/path/to/my/project/node_modules/broccoli-typescript-compiler/dist/plugin.js:324:27)
    at typescript (/path/to/my/project/node_modules/broccoli-typescript-compiler/index.js:28:10)
    at TypeScriptPreprocessor.toTree (/path/to/my/project/node_modules/ember-cli-typescript/lib/typescript-preprocessor.js:96:7)
    at /path/to/my/project/node_modules/ember-cli-preprocess-registry/preprocessors.js:180:26
    at Array.forEach (native)
    at processPlugins (/path/to/my/project/node_modules/ember-cli-preprocess-registry/preprocessors.js:178:11)
    at module.exports.preprocessJs (/path/to/my/project/node_modules/ember-cli-preprocess-registry/preprocessors.js:171:10)
    at EmberApp.appAndDependencies (/path/to/my/project/node_modules/ember-cli/lib/broccoli/ember-app.js:1110:27)
    at EmberApp.javascript (/path/to/my/project/node_modules/ember-cli/lib/broccoli/ember-app.js:1225:30)
    at EmberApp.toArray (/path/to/my/project/node_modules/ember-cli/lib/broccoli/ember-app.js:1662:12)
    at EmberApp.toTree (/path/to/my/project/node_modules/ember-cli/lib/broccoli/ember-app.js:1684:38)
    at module.exports (/path/to/my/project/ember-cli-build.js:29:13)
    at Builder.setupBroccoliBuilder (/path/to/my/project/node_modules/ember-cli/lib/models/builder.js:56:19)
    at new Builder (/path/to/my/project/node_modules/ember-cli/lib/models/builder.js:30:10)
    at ServeTask.run (/path/to/my/project/node_modules/ember-cli/lib/tasks/serve.js:24:55)

I'm trying to use typescript, however this pops up now and then. Here is what I do to solve this:

rm -rf tmp/
rm -rf node_modules/ && yarn install
yarn remove ember-cli-typescript ember install ember-cli-typescript

If it pops up too often, I cancel on typescript and keep it deinstalled (however, yes, I'm really trying to use it)

@gossi I noticed this error today as well. I have a fresh install of ember-cli-typescript and am running<EMAIL_ADDRESS>on Windows with Node v6.11.0.
Are you running on MacOS, Windows, Linux? What version of Node.js, and ember-cli?

@gossi just curious do use use lib in your .tsconfig? e.g. lib: ["2017", "dom"] for some reason I used this to support Array.includes but once I removed that from my config. (And converted to .indexOf instead.) I no longer had this error.

My configuration:

No lib
target: ES2017
ember-cli: 2.13
node: v7
platform: macOS

@gossi also, what versions of TypeScript and ember-cli-typescript are you using? I'll try to dig into this sometime in the next couple weeks (though getting some motion on our typings story is a higher priority at present).

The version that was present at may 19th ;) Should be v0.4.0 and that typescript version that comes with it. I can test it again next week, ping me in slack.

Heh, saw the same error today while doing an upgrade. I'm even more strongly incentivized to track this down.

Initial investigation is… perplexing. For me, it's throwing this error on a TypeScript-internal file: /lib.dom.d.ts, pulled in via the lib argument in the tsconfig.json file. 😬 Will update more later as I'm able to track it down further.

I believe that a new version from the latest broccoli-typescript-compiler will solve this – will wait to see when that publishes, but initial work locally looks like that might do the trick.

@gossi @pixelhandler please try it with the latest version on this branch:
"ember-cli-typescript": "https://github.com/emberwatch/ember-cli-typescript.git#b740a89d1f42461f4f59ec97d37bdd6608003337",

Update: @gossi and @pixelhandler I fixed another bug on that branch this morning; maybe try the head of that branch instead:
"ember-cli-typescript": "https://github.com/emberwatch/ember-cli-typescript.git#b6c1a6f1e6dc9e8a0ef493f6a284df4f2d90e2ca

@chriskrycho I tried out the above branch and ran a build. twice in a row I had a cleanup error:
Cleanup error.
ENOTEMPTY: directory not empty, rmdir 'C:\...pathtorepo....\tmp\broccoli_merge_trees-output_path-siW7acsK.tmp'

Running Windows 10, Node v6.11

@chriskrycho I tried out the above branch and ran a build. twice in a row I had a cleanup error:
Cleanup error.
ENOTEMPTY: directory not empty, rmdir 'C:\...pathtorepo....\tmp\broccoli_merge_trees-output_path-siW7acsK.tmp'

The build did work, was only a cleanup error.
Running Windows 10, Node v6.11

This should be resolved in the 1.0 beta. Please test with "ember-cli-typescript": "next" and let me know if it recurs.


Added implementation for calculating number of lines added and removed

Added modification_counter function in interactive_viewer.ml that will provide added and removed line count, also updated formatting as per contribution document.
fix for issue: https://github.com/panglesd/diffcessible/issues/17
Sample output:

@Julow and @panglesd

Oh, and two more comments:

It would be nice to handle the "plural": "1 addition", but "3 additions", and similarly "1 removal" but "5 removals"!
You will need to rebase your PR on top of master since there is some unfortunate PR (due to ocamlformat...)

I have addressed all the above comments and had a little trouble with the latest code hence the delay.
Do let me know if you have more comments.
Also, the updated UI screenshot of the implementations is below

Hi @panglesd, let me know what you think.

@panglesd, Could you please take a look at the updates I made based on your suggestions? I've made several changes to improve the clarity and consistency of the function names. I would appreciate your feedback on the adjustments. Thank you

That's better! There are still some things I'd like to improve. Functions that "add" something should take an accumulator (the number of additions/removal) and add the contribution of a line/hunk to this accumulator. So, for instance, the function defined line 66 is an "add" function and its name is right. However, the functions defined line 65 and 74 are not an "add" functions. They could be turned into "add" functions by giving an accumulator to add the contributions to. I believe you do want to add the accumulator to the function line 65, but maybe only rename the function line 65, eg to additions_and_removal!

@panglesd, Would you prefer to rename add_hunk to something like accumulate_count or combine_hunks_counts to better reflect its purpose?

@Julow & @panglesd, Could you please look at the updates I made based on your suggestions? Thank you and I would appreciate your feedback on the adjustments.

Thank you @Julow & @panglesd for merging the PR, @panglesd, for your detailed explanations and guidance throughout the process. Your insights were invaluable in understanding the concepts better. I appreciate your support and look forward to continuing to learn from @Julow and you.


Add CI to current Github repo

As a developer
I need to add Continuous Integration to the current GitHub repo
So that I can automate code testing and do not introduce new errors to current codebase
Details and Assumptions
The repository currently does not have any CI pipeline.
We're using GitHub Actions as our CI tool.
The CI pipeline should run tests on every pull request and push to main/master branch.


Python precommit flaky: Failed to read inputs in the data plane

This error is affecting several different portable Python tests.
apache_beam.runners.portability.fn_api_runner.fn_runner_test.FnApiRunnerTestWithGrpcAndMultiWorkers.(test_sdf_default_truncate_when_unbounded|test_flatten) [1][2] flaked with error "Failed to read inputs in the data plane." because of GRPC exception "broken pipe". Later there is an exception "Channel closed prematurely."
https://ci-beam.apache.org/job/beam_PreCommit_Python_Phrase/2476/testReport/junit/apache_beam.runners.portability.fn_api_runner.fn_runner_test/FnApiRunnerTestWithGrpcAndMultiWorkers/test_flatten_3/
Imported from Jira BEAM-12322. Original Jira may contain additional context.
Reported by: ibzib.

.take-issue

.close-issue

seems a duplicate of https://github.com/apache/beam/issues/21104.

It looks like different specific tests are failing, though in the same class. Definitely could be related. Also interesting that Pablo managed to repro those by running the whole class. I'll give that a shot and see if it repros any of these.


Add Top Emitters region to regions dropdown

This PR adds the Top Emitters option to the regions in Historical Emissions
Note: As this is a non-backend region it is needed to add all the countries along with the TOP region

Thank you for the comment. Fixed and conflicts too. Merging...


Fix QuotesCache caching quoted symbol definitions with incorrect owners

Previously we would always cache and reuse unpickled trees, which was a problem for quoted code which included symbol definitions. In those cases, even if those quotes were being created within another context (which should dictate owners of symbol definitions), it would be ignored, and previous potentially incorrect symbol definitions would be reused.
Now we include the quote symbol owner while caching, which is only taken into account if the quoted code contains a symbol definition.
Fixes #20471

Superseded by #21932, a way simpler (and faster!) idea for a fix (thank you @hamzaremmal for the suggestion!)


:expressionless: few small design changes

:rocket: deployed to http://profiles-pr-82.dev.c2s.nhschoices.net

@st3v3nhunt few small changes I went through with @alex-colbeck yesterday. Review, Merge, etc. please


test(DCOS-12816): Create an app with service address

This PR adds a system test for creating an app with service address.
To run the test:
docker run -it --rm --ipc=host \
    -v `pwd`:/dcos-ui \
    -e CLUSTER_URL=$openCluster \
    mesosphere/dcos-ui dcos-system-test-driver --only "apps"  \
    ./system-tests/driver-config/cluster.sh

Checklist

[x] Did you add a JIRA issue in a commit message or as part of the branch name?
[ ] Did you add new unit tests?
[ ] Did you add new integration tests?
[ ] If this is a regression, did you write a test to catch this in the future?

This failed for me :(
✘ Services Applications should create an app with service address

Run integration tests

After running I had 5 failing tests but none of them are yours.

I'm seeing the same as @weblancaster, so this is good to go!


Remove version: taers232c.GAMADV-XTD3 version 6.80.02

This version is older than what has been set in max-versions-to-keep by the publisher.
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/taers232c/GAMADV-XTD3/releases/download/v6.80.02/gamadv-xtd3-6.80.02-windows-x86_64.msi
OK
(Automated message - build 913)


Udf support

Some sample queries:

one to one event transform(select/ordering/no aggregation)
SELECT to_hour(localTimeConverter(trip_time, city_name)) as local_hour, trip_id, city_name FROM mytable WHERE drvier_id = "xxxx" order by local_hour DESC limit 1000

Aggregation only
// Get max/min trip duration for a driver
SELECT to_hours(max(trip_end_ts - trip_start_ts)), to_minutes(min(trip_end_ts - trip_start_ts)) FROM mytable where drvier_id = "xxxx"

Aggregation group by
SELECT sum(trip_fare), to_hour(convert_to_local_time(trip_time, city_name)) as local_hour, city_name FROM mytable group by by to_hour(convert_to_local_time(trip_time, city_name)), city_name

javascript based udf for runtime quick validation

Thank you @fx19880617 for requesting for UDF support in Pinot. I am currently exploring the idea of supporting what I'd like to call Transform operators, and feel that supporting UDF's would fit well within the idea of transforms. I am sharing my initial idea in a design doc that I started writing. Let's use this thread to shape up & refine the idea, and discuss how UDF's fit into it.

Very impressive write up @mayankshriv !
Overall looks good to me, have two points here:

Will function be able to take multiple constants as parameters? like convert_from_timezone_to(ts, 'UTC', 'PDT') ? The reason is antlr parsed column name to IDENTIFIER and constant(string/numbers) to literal.
This may causing backward compatible issue for PQL query parser.

Also I think the semantics of "select func(...) AS some_func ..." need to be support in this case to make results naming more meaningful.

+1 to support aliasing. This as can be done independently of UDF support
right? Probably better to do that first before starting on UDF.
On Wed, Sep 28, 2016 at 2:21 PM, Xiang Fu<EMAIL_ADDRESS>wrote:

Very impressive write up @mayankshriv https://github.com/mayankshriv !
Overall looks good to me, have two points here:

Will function be able to take multiple constants as parameters? like
convert_from_timezone_to(ts, 'UTC', 'PDT') ? The reason is antlr parsed
column name to IDENTIFIER and constant(string/numbers) to literal.
This may causing backward compatible issue for PQL query parser.

Also I think the semantics of "select func(...) AS some_func ..."
need to be support in this case to make results naming more meaningful.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/linkedin/pinot/issues/552#issuecomment-250304631, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAz7Z04u2pdUMOuUIZIihqrxXliF_4wVks5qutptgaJpZM4J-bAx
.


feik

feik (from English fake) is very commonly used ('ak di feik'). Should we add it?

should be helpful. :-)
On Wed, Oct 19, 2022 at 10:02 AM John Bent @.***> wrote:

feik (from English fake) is very commonly used ('ak di feik'). Should we
add it?
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/360, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF2DJJGUPC5JF4MLYKPHQU3WEASQ3ANCNFSM6AAAAAARJKOGCQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

AUTOPARSE feik -o E -b fake v.t. fake. --feik n.

How do we know that this verb is transitive? Maybe it is, but I am just curious. Also, maybe add “feign injury or other condition” to the translation?

Hmm. You're right. It's intransitive.
https://www.grammarly.com/blog/transitive-and-intransitive-verbs/?gbraid=0AAAAADkCrf92-Ga1ZWwG6q9XsGcu77wCm&gbraid=0AAAAADkCrf92-Ga1ZWwG6q9XsGcu77wCm&gclid=CjwKCAjwwL6aBhBlEiwADycBIOU4n5rGmRwpJ5K0IJn2FnRd_UybevUFx6vToVXeV0PfSs9Z5sR9qBoC9YsQAvD_BwE&gclsrc=aw.ds
It can take an object so I thought that made it trans. But trans means not that it can but rather that it must. So it's intransitive.

I might be misremembering, but I seem to remember Josephs writing about transitive verbs having implied direct object even if not expressed.  Lol

So maybe it is trans then. If I say, “I’m just faking,” then there is an
implied object.  I’m faking someone.
On Wed, Oct 19, 2022 at 6:42 PM ChrisPerrette @.***>
wrote:

I might be misremembering, but I seem to remember Josephs writing about
transitive verbs having implied direct object even if not expressed.  Lol
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/360#issuecomment-1284743525,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPT2PTJPY6PCKCHYHYLQ7TWECIQNANCNFSM6AAAAAARJKOGCQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Maybe one definition is just faking intransitively (playing around), and another is faking transitively (faking something or someone).

AUTOPARSE
w -o E -b fake feik v.t. fake (something or someone); feign (a feeling, state, or injury). --feik n.

AUTOPARSE successfully AUTOPARSED; closing issue

AUTOPARSE successfully AUTOPARSED; closing issue


Customize layer control position and solve bug-changing layer

Hello I'm using the leaflet with directive to make the google map and I have a problem to position the control layers I researched a lot and found the map.zoomControl.setPosition code ('bottomleft'); positioning the zoom control more get nothing to do the same with the layers and I am with this view with the code below (screen 1) and how I want to stay in (screen 2)
Another problem is that the control is over the issue bar that is solved when I add the class class = "has-header" in  </ leaflet> but when I click to change the map to satellite it negates that class and returns to run out of the top margin (screen 3)
I thank those who could help follows the code below;

MapController.js

angular.extend($scope, {
                center: {
                    lat:mylat,
                    lng:mylng,
                    zoom: 14
                },
                layers: {
                    baselayers: {
			   googleRoadmap: {
                            name: 'Map',
                            layerType: 'ROADMAP',
                            type: 'google'
                        },
                        googleHybrid: {
	                        name: 'Satelite',
	                        layerType: 'HYBRID',
	                        type: 'google'
	                    }
                    },
					options: {
					position: 'bottomleft'
				}
                },
				markers: [],
				events: {}
			});

		  leafletData.getMap().then(function(map) {
		   map.zoomControl.setPosition('bottomleft');
		   //control position - allowed: 'topleft', 'topright', 'bottomleft', 'bottomright'
		  });

Map.html
<ion-view title="Map" ng-controller="MapController" id="map" can-swipe-back="false">

	<ion-nav-bar class="bar-positive">
      <ion-nav-back-button>
      </ion-nav-back-button>
    </ion-nav-bar>

	<ion-nav-buttons side="left">
    <button menu-toggle="left" class="button button-icon icon ion-navicon"></button>
	</ion-nav-buttons>

    <ion-nav-buttons side="right">
    <button ng-click="locate();" class="button button-icon2 icon ln-magnifier ico-ajst"></button>
	</ion-nav-buttons>

	<leaflet lf-center="center"  layers="layers" markers="markers" width="100%" height="100%" class="has-header"></leaflet>

	 <ion-tabs class="tabs-icon-top tabs-positive">

        <ion-tab title="locate" icon="ln-locate" ng-click="locate();">
          <ion-nav-view name="about-tab"></ion-nav-view>
        </ion-tab>

      </ion-tabs>

</ion-view>

Hey, thanks for using Leaflet! However, this is a place to report Leaflet issues, not to request support for your app. Please try asking on StackOverflow — you are more likely to find help there.

Hello thank you, but doubts that reported refer to the bug when changing the map layer and the question of changing the options of layers buttons not found in any place and believed they were questions pertaining to the leaflet, more fine mourner thanks for return, I will turn to StackOverflow.

I managed to solve with some css below:
.leaflet-control-container {
display: block;
}
.leaflet-control-zoom {
left: 5px;
top: 50px;
}
.leaflet-control-layers {
left: 5px;
top: 50px;
}
.leaflet-touch .leaflet-control-attribution {
display: none;
}


fix(NODE-3770): Filter type uses WithId on the schema

Description
What is changing?
This is changing the internal definition of the Filter type to always apply WithId to the given TSchema.
FYI: I had to remove the old unused union schema unit tests, because it was throwing a TS error. I've reached out to @nbbeeken on another PR and he confirmed that we can remove those test assertions: https://github.com/mongodb/node-mongodb-native/pull/2972#issuecomment-964329383
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Closes https://jira.mongodb.org/browse/NODE-3770
See discussion in https://github.com/mongodb/node-mongodb-native/pull/3044
Double check the following

[x] Ran npm run check:lint script
[x] Self-review completed using the steps outlined here
[x] PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
[x] Changes are covered by tests
[ ] New TODOs have a related JIRA ticket

@dariakp Can I please get any feedback on this PR?
I'd love if we can push this through soon, since the change introduced in 4.2.0 in the find Filter type is not consistent with the rest of the find* methods.

@avaly Sorry for the delay, most of the team was out last week for the U.S. Thanksgiving holiday. We should be able to get this reviewed this week. Thanks for your patience!

How do I use the WithoutID option?  I use strings, not ObjectIDs.  I cannot upgrade to this version now because it breaks my code everywhere.

There is a bug in the typings.  When using the OptionalId to have it automatically use InferIdType, it is still making me use ObjectId.  It will not pick up that my _id is a string
export interface LogMethodLatencyModel {
_id?: string;
__v?: number;
createdAt?: Date;
updatedAt?: Date;
date_start: Date;
date_end?: Date;
latency_ms: number;
method: string;
}
(method) Collection.deleteOne(filter?: Filter<Pick<LogMethodLatencyModel, "__v" | "createdAt" | "updatedAt" | "date_start" | "date_end" | "latency_ms" | "method"> & {
_id?: ObjectId;
}>, options?: FindOneAndDeleteOptions, bypassLogs?: boolean): Promise<...>

@xonuzofa Hi there, thanks for reaching out. When specifying your own _id type in the collection model, you should not make it optional, because if you insert an object without specifying the _id, MongoDB will create an ObjectID type _id on your behalf, leading to an inconsistent schema in your database. The problem you are seeing is due to the way the types for the _id are currently reconciled, and you should not run into this issue if you specify the _id as required in your model.

``Even when I change this:
export interface LogMethodLatencyModel {
_id: string;
__v?: number;
createdAt?: Date;
updatedAt?: Date;
date_start: Date;
date_end?: Date;
latency_ms: number;
method: string;
}
I have a helper method here:
`
findById(id: string, options?: FindOptions): Promise {
return new Promise((resolve, reject) => {
ResolveIOServer.getMainDB().collection(this.collectionName).findOne({_id: id}, options).then(res => {
resolve(res);
}, err => {
console.log(new Date(), 'Error Find By Id', this.collectionName, {_id: id}, options, err);
reject(err);
});
});
}
`
It gives me an error here for _id being a string and not an ObjectId:
No overload matches this call.
Overload 1 of 11, '(filter: Filter, options?: FindOptions): Promise', gave the following error.
Type 'string' is not assignable to type 'Condition'.
Overload 2 of 11, '(filter: Filter, options?: FindOptions, callback?: Callback): void', gave the following error.
Type 'string' is not assignable to type 'Condition'.ts(2769)
mongodb.d.ts(5858, 5): The expected type comes from property '_id' which is declared here on type 'Filter'
mongodb.d.ts(5858, 5): The expected type comes from property '_id' which is declared here on type 'Filter'

@xonuzofa It doesn't look like your helper method actually populates your intended schema type through the generic. Here are some examples from our typescript definition tests that demonstrate a custom _id with find: findX.test-d.ts.
If you need further help with your specific use case, I recommend asking in our community forums, as we try to limit github discussions to active PRs for driver bugs and feature requests.


Error 500: after clearing the cache, the file proxy-classes.php takes a very long time to be generated

PHP Version
8.1
Shopware Version
<IP_ADDRESS>
Actual behaviour
After clearing the cache, the cache is rebuilt and on the first hit I get an error 500 with this error message:
Warning: fileperms(): stat failed for /var/cache/prod_h40f9912f8090a2e172a415c87693344d/ContainerWfZmin9/proxy-classes.php

The file does no exists and after few seconds or couple of reloads the file is generated and everything works again.
After deactivating frosh tools it works as expected
Expected behaviour
The file is present at the first hit and the cache will be rebuilt without error 500.
Steps to Reproduce?
Hard to say.
It is working on the same server on production environment with the same settings.
On another staging environment it is not working.
e are using the latest 6.4 compatible frosh tools version

That sounds a lot like opcache is the trigger.
See warning for opcache.enable_file_override: https://developer.shopware.com/docs/guides/hosting/performance/performance-tweaks#php-config-tweaks


add common packages to tagging-status.yml

Adds several commonly-used packages and classes to tagging-status.yml without commenting on their status. If any are too obscure to be included please let me know.

I think that this list should be pretty much comprehensive: with nothing being excluded as simply because it is "too obscure".

I think that this list should be pretty much comprehensive: with nothing being excluded simply because it is "too obscure".

I do a have a different opinion on this. While I agree that it is good to have an overview on the status of the whole universe of LaTeX packages with respect to tagging support, it is equally important (and in my opinion even more so) to have a curated set of packages, that cover most requirements that documents can have and do this with (reasonable) mature implementations. This set of packages is the the group that should be covered first because one has to balance available resources with a project result that brings a lot of benefits in most situation.
Of course, any such group is a biased selection, so it shouldn't be taken as something that can't be augmented. However, if we add every package and  end up with 5000+ CTAN packages out of which initially more than 4500 have no known status and only a few of them are then likely to get one, then it obsources both what is necessary to address as well as to actually schedule work in a sensible way.
This is why I added and focused on just the packages covered by TLC3 (i.e. around), because TLC3 is the result of evaluating all packages in CTAN not that long ago(biased for sure) for importance, coverage, and quality in the respective space.
In my opinion that (plus a few more ) is the set the project should focus on initially and what we should also strongly suggest as a good basis for usage by users.  This should be crosschecked and augmented by, say ,the usage found across arXiv.org (recent 5 years say).
This is why I'm not sure that it is a good idea to simply start adding further packages if there is not an explicit request for that package, just because it happens to be on CTAN.

@FrankMittelbach I fully agree that it is not desirable to include every possible CTAN package. I've tried to make sure the packages I've added to the list in #214 are all ones I've seen "in the wild", i.e. in questions/answers on TeX-SX or in my own experience in other people's real documents (mostly math documents). But I recognize your points and I think #216 is a good solution.


fix: model weight updates with automatic_optimization=False in mixed precision training

What does this PR do?
Fixes an issue where model weights were not being properly updated when using automatic_optimization=False with mixed precision training (16-mixed precision). The core issues were:

Improper gradient scaling/unscaling in the AMP plugin
Missing validation of gradient values before optimizer steps
Lack of proper error handling for repeated unscale operations

The changes include:

Enhanced AMP plugin implementation with proper gradient scaling workflow
Added explicit gradient unscaling before optimizer steps
Improved error handling for edge cases
Added warning when gradients become NaN/inf during training

Fixes #20215

Before submitting

[x] Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20460.org.readthedocs.build/en/20460/

Great contribution! Looks solid, will review today

something must have happened when submitting the PR, changes need to go in here
https://github.com/Lightning-AI/pytorch-lightning/blob/master/src/lightning/pytorch/plugins/precision/amp.py#L67
but they appear as a stand-alone file. I can help incorporate if you allow me to push to your fork

@iamarunbrahma looking at the signature for optimizer_step from, are you working off a pre-2.0 version of PyTorch Lightning? optimizer_idx was removed before 2.0.0 in https://github.com/Lightning-AI/pytorch-lightning/pull/16539

ok the more I look at this the more puzzled I am, can you clarify the code in the PR @iamarunbrahma, how it fits with the plugin optimizer_step and how it solves the original issue?

BTW the title is contradicting the issue: the issue describes something happening with automatic_optimization=True, not False. I'm closing this one.


zip does not include all files

I have the following config which won't include some directories in the zip file, even though I don't use any excludes.
in the workspace directory I can see that these ones exist, but once the archive is built and transferred to s3, they don't anymore.
Config attached:

The dirs are:
storage
bootstrap/cache
There might be more, but who knows. This is very weird.

Any help debugging this is appreciated.

Ok so the missing dirs list is actually bigger than that, I have around 20 dirs that are being ignored.
All of them have one thing in common: they are empty dirs.
This is a major bug since the application will not run if said dirs are not existing.

This appears to be a bug in the way DirScanner.Glob handles what to include/exclude out of the archive:
https://github.com/awslabs/aws-codedeploy-plugin/blob/master/src/main/java/com/amazonaws/codedeploy/AWSCodeDeployPublisher.java#L360 (based on a similar issue in another Jenkins plugin - https://github.com/jenkinsci/jenkins-clone-workspace-scm-plugin/pull/12)
One workaround here for you until we can get the behavior fixed that might be possible if these folders are not needed at build time and only needed at deploy / runtime would be to have a AfterInstall script that creates the empty directories. However, I agree we should fix this within the plugin itself.

Thanks for the reply @Jmcfar, that's exactly what I ended up doing, creating the dirs in AfterInstall.

we have similar issue, we generate a cache before deploying that code and some of the folders get created empty cause we just need them to exist, but they don't get in the zip file.
Was any solution found other than creating them again in AfterInstall hook?

@kirsley sorry but no, it worked for me using the workaround and I left it like that.


I cannot reduce the results on yc2. Can you share some parameters?

Hello, it is me too. I can reduce the results in your paper MART on anet.
But the results on yc2 is CIDEr 23.46, not 35.74, Meteor 15.1, not 15.9 and the BLEU@4 is 6.88, not 8.
Can you share some parameters different from the anet, which is beneficial for yc2 to a 30+ CIDEr?
Thanks very much.

Hi @lingshi0606,
As far as I remember, I used the default hyper-parameters in the train.py and train.sh files. (In train.sh, you can see dataset specific hyper-parameters for yc2.)
I am not sure why your results much lower. Is this result consistent across different random seeds?
Best,
Jie

Hi @lingshi0606,
As far as I remember, I used the default hyper-parameters in the train.py and train.sh files. (In train.sh, you can see dataset specific hyper-parameters for yc2.)
I am not sure why your results much lower. Is this result consistent across different random seeds?
Best,
Jie


The Lexer/Parser does not preserve whitespaces trim?

Hi, :slightly_smiling_face:
I started to write a Prettier plugin for Twig files and I decided to use Twing for parsing Twig syntax.
For example, it should prettify the following code:
{%  block my_block   %}
    hello
{%- endblock   -%}

to something like this:
{% block my_block %}
    hello
{%- endblock -%}

However I'm facing an issue with whitespaces trim (e.g.: {%- for trimming whistespace on the left).
Given the following Twig code:
{% block my_block %}
    hello
{%- endblock -%}

When running the Lexer (twing.tokenize(source)), it output:
 TwingTokenStream {
      current: 0,
      tokens:
       [
         // `{% block my_block %}`
         TwingToken { type: 1, value: null, lineno: 1, columnno: 1 },
         TwingToken { type: 5, value: 'block', lineno: 1, columnno: 4 },
         TwingToken { type: 5, value: 'my_block', lineno: 1, columnno: 10 },
         TwingToken { type: 3, value: null, lineno: 1, columnno: 18 },
         TwingToken { type: 0, value: '    hello', lineno: 2, columnno: 1 },

         // the `{%- endblock -%}`
         TwingToken { type: 1, value: null, lineno: 3, columnno: 1 },
         TwingToken { type: 5, value: 'endblock', lineno: 3, columnno: 5 },
         TwingToken { type: 3, value: null, lineno: 3, columnno: 13 },

         // eof
         TwingToken { type: -1, value: null, lineno: 4, columnno: 1 } ],
      source:
       TwingSource {
         code: '{% block my_block %}\n    hello\n{%- endblock -%}\n',
         name: 'vars.twig',
         path: '/home/kocal/Dev/prettier-plugin-twig/tests/vars/vars.twig' } }

So as you can see there is no diff between {% and {%-..
I can't take the {%- from a end-user Twig template and modify it to {%. :disappointed:
And of course there is the same problem for the parser (since it uses the previous tokens):
    TwingNodeModule {
      name: 'vars.twig',
      nodes:
       Map {
         'body' => TwingNodeBody {
         name: 'vars.twig',
         nodes:
          Map {
            0 => TwingNodeBlockReference {
            name: 'vars.twig',
            nodes: Map {},
            attributes: Map { 'name' => 'my_block' },
            lineno: 1,
            columnno: 4,
            tag: 'block',
            type: 'block_reference',
            TwingNodeOutputInterfaceImpl: [Circular] } },
         attributes: Map {},
         lineno: 0,
         columnno: 0,
         tag: null,
         type: 'body' },
         'blocks' => TwingNode {
         name: 'vars.twig',
         nodes:
          Map {
            'my_block' => TwingNodeBody {
            name: 'vars.twig',
            nodes:
             Map {
               0 => TwingNodeBlock {
               name: 'vars.twig',
               nodes:
                Map {
                  'body' => TwingNodeText {
                  name: 'vars.twig',
                  nodes: Map {},
                  attributes: Map { 'data' => '    hello' },
                  lineno: 2,
                  columnno: 1,
                  tag: null,
                  type: 'text',
                  TwingNodeOutputInterfaceImpl: [Circular] } },
               attributes: Map { 'name' => 'my_block' },
               lineno: 1,
               columnno: 4,
               tag: null,
               type: 'block' } },
            attributes: Map {},
            lineno: 1,
            columnno: 0,
            tag: null,
            type: 'body' } },
         attributes: Map {},
         lineno: 0,
         columnno: 0,
         tag: null,
         type: null },
         'macros' => TwingNode {
         name: 'vars.twig',
         nodes: Map {},
         attributes: Map {},
         lineno: 0,
         columnno: 0,
         tag: null,
         type: null },
         'traits' => TwingNode {
         name: 'vars.twig',
         nodes: Map {},
         attributes: Map {},
         lineno: 0,
         columnno: 0,
         tag: null,
         type: null },
         'display_start' => TwingNode {
         name: 'vars.twig',
         nodes: Map {},
         attributes: Map {},
         lineno: 0,
         columnno: 0,
         tag: null,
         type: null },
         'display_end' => TwingNode {
         name: 'vars.twig',
         nodes: Map {},
         attributes: Map {},
         lineno: 0,
         columnno: 0,
         tag: null,
         type: null },
         'constructor_start' => TwingNode {
         name: 'vars.twig',
         nodes: Map {},
         attributes: Map {},
         lineno: 0,
         columnno: 0,
         tag: null,
         type: null },
         'constructor_end' => TwingNode {
         name: 'vars.twig',
         nodes: Map {},
         attributes: Map {},
         lineno: 0,
         columnno: 0,
         tag: null,
         type: null },
         'class_end' => TwingNode {
         name: 'vars.twig',
         nodes: Map {},
         attributes: Map {},
         lineno: 0,
         columnno: 0,
         tag: null,
         type: null } },
      attributes: Map { 'index' => null, 'embedded_templates' => [] },
      lineno: 1,
      columnno: 1,
      tag: null,
      type: 'module',
      source:
       TwingSource {
         code: '{% block my_block %}\n    hello\n{%- endblock -%}\n',
         name: 'vars.twig',
         path: '/home/kocal/Dev/prettier-plugin-twig/tests/vars/vars.twig' },
      tokens: [] }

Is there a way to preserve - references?
Maybe adding a new property on TwingToken class? :thinking:
And also update the parser to use the new property?
Thanks! :)

Or maybe create two new kind of token:

TRIM_LEFT_WHITESPACES_TOKEN
TRIM_RIGHT_WHITESPACES_TOKEN

? 🤔

Hi @Kocal,
It should be feasible to add a property to the Token class.
But I'm wondering why you would want to remove the whitespace control modifier ({%- and -%}). They have an impact on the final rendering. For example:
{% block foo %}FOO {% endblock %}BAR
Would render "FOO BAR" while:
{% block foo %}FOO {%- endblock %}BAR
Would render "FOOBAR".
Removing those modifiers would lead to an unexpected rendering. What do you think? Did I missed your point?

Hey, thanks for the quick response.
I think you misunderstood (or I wasn't clear), but I want to keep whitespace control modifier.
Prettier is working this way:

take the source code
parse it into an AST
use the AST for printing a source code

In my case if the end-user writes {%-, I won't find any instances of whitespace control modifier in the parsed AST (and so I can't print it back).
So let's go for a property 😊

Oh, yes, sorry, It's quite clear now.

Oh, I've just some found something:

I tried to see what is happening with the interactive playground (#331 :eyes:), and apparently using {{- or -}} is actually triming prev/next TwingnNodeText values :confused:

I don't think this is the good behavior, but maybe Twig does this?
IMO whitespace control should be used only at printing, not when creating the AST.
What do you think?

Hi @Kocal,
I'm closing this issue in favor of #348. The lexer is lossy and this needs to be addressed. This will create some breaking changes (because tokens will be added and the final AST will be quite different from the current one).

Hi @ericmorand,
Well it's a good news, thanks you! :)

My approach is to have the lexer provide a CST instead of an AST. The parser would know what to do with the CST to only grab what it needs. But for people that want to implement linters or prettifiers, having a CST is a godsend.
So, the idea is that every single piece of data that appears on a template source code is available on the CST: whitespaces, new lines, punctuations, whitespace controls...
Recreating the source from the CST will be lossless and trivial (just a toString call or something would recreated the sources - identical to the original or updated if some tokens have been updated).

So, the idea is that every single piece of data that appears on a template source code is available on the CST: whitespaces, new lines, punctuations, whitespace controls...

That would be awesome! :heart_eyes:
So, should we close #326?

Hi @Kocal , I created a standalone Lexer that will be used by Twing 3 and should fit your needs:
https://www.npmjs.com/package/twig-lexer
It is lossless.
Not that it is still not in V1.0.0 so the API is subject to change. The reason is that I'd like to gather some feedback about it before freezing it for good. So if you feel like using it, don't hesitate to (obsviously) open issues but also provide feeback about the API itself (for example the token names).

Hi @ericmorand, that's really a great news! :tada:
A big thank you for your work, I will try it ASAP! :)