An assertion is thrown if the exception was thrown in the callback that create a provider.

When any exception is thrown inside the call back that create a provider, a wrong assertion and stack trace are thrown with the following:
════════ Exception caught by widgets library ═══════════════════════════════════
The following assertion was thrown building Builder:
Got a stack frame from package:stack_trace, where a vm or web frame was expected. This can happen if FlutterError.demangleStackTrace was not set in an environment that propagates non-standard stack traces to the framework, such as during tests.
'package:flutter/src/foundation/stack_frame.dart':
stack_frame.dart:1
Failed assertion: line 192 pos 7: 'line != '===== asynchronous gap ===========================''

and bunch of other assertion are thrown too.
════════ Exception caught by widgets library ═══════════════════════════════════
'package:flutter/src/widgets/framework.dart': Failed assertion: line 4692 pos 14: 'owner!._debugCurrentBuildTarget == this': is not true.
framework.dart:4692
════════════════════════════════════════════════════════════════════════════════

To Reproduce
Try to throw any exception when creating a provider.
final countProvider = StateProvider<int>((ref) {
  throw 'test';
  return 0;
});

Here is a full example to run:
import 'package:flutter/material.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart';

final countProvider = StateProvider<int>((ref) {
  throw 'sad';
  return 0;
});

void main() {
  runApp(ProviderScope(child: const MyApp()));
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends ConsumerStatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  ConsumerState<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends ConsumerState<MyHomePage> {
  void _incrementCounter() =>
      ref.read(countProvider.notifier).update((state) => state + 1);

  @override
  Widget build(BuildContext context) {
    final count = ref.watch(countProvider);
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$count',
              style: Theme.of(context).textTheme.headlineMedium,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ),
    );
  }
}

and a flutter doctor report:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.7.3, on macOS 13.2 22D49 darwin-arm64, locale
    en-EG)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
[✓] Chrome - develop for the web
[✓] Android Studio
[✓] VS Code (version 1.75.1)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

• No issues found!

I encounter this problem as well

This report looks similar to #1874 , as I think it better to integrate these issues,
but I actually cannot judge if these are redundant or not.


Automated Package Upgrade

:tada: This PR is included in version 12.4.166 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


FEATURE REQUEST: Allow --output

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm requesting a feature unrelated to a specific site
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2023.07.06 (update instructions) or later (specify commit)
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
I would like to do this:
yt-dlp -o ~/Videos/ https://www.youtube.com/watch?v=QaeRj-ApktY

Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
But what I get is this:
[youtube] Extracting URL: https://www.youtube.com/watch?v=QaeRj-ApktY
[youtube] QaeRj-ApktY: Downloading webpage
[youtube] QaeRj-ApktY: Downloading ios player API JSON
[youtube] QaeRj-ApktY: Downloading android player API JSON
[youtube] QaeRj-ApktY: Downloading m3u8 information
[info] QaeRj-ApktY: Downloading 1 format(s): 134+139
[download] Destination: /home/user/Videos/.mp4.f134.mp4
[download] 100% of   96.46MiB in 00:01:15 at 1.28MiB/s
[download] Destination: /home/user/Videos/.mp4.f139.m4a
[download] 100% of   31.09MiB in 00:00:21 at 1.46MiB/s
[Merger] Merging formats into "/home/dolf/Videos/_unsorted/.mp4"
ERROR: Postprocessing: file:/home/user/Videos/.mp4.temp: Invalid argument

the functionality you want already exists as the -P/--paths option

That's counter intuitive, to be honest.

As a user I expect --output to specify where to download files in (as all the other programs do). But the current option should be rather named as --template.

Or at least would be nice to have a reference to --paths in manual for --output, so that people like me, who get used to other namings, are not lost.

But my proposal will be to just merge --paths & --output, and just leave the later.

would be nice to have a reference to --paths in manual for --output

Not a bad idea IMO

But my proposal will be to just merge --paths & --output, and just leave the later.

You can specify path in --output, you just also have to specify output template/filename

Or at least would be nice to have a reference to --paths in manual for --output, so that people like me, who get used to other namings, are not lost.

Already there. From OUTPUT TEMPLATE:

The -o option is used to indicate a template for the output file names while -P option is used to specify the path each type of file should be saved to.

But my proposal will be to just merge --paths & --output, and just leave the later.

That is ambiguous. If you do C:\xxx, do you want a file named xxx in C:\, or a file inside C:\xxx? The options will be kept separate

That is ambiguous. If you do C:\xxx, do you want a file named xxx in C:\, or a file inside C:\xxx?

No, it's not ambiguous. If the directory C:\xxx exists we create a file with a default template C:\xxx\%(title)s.%(ext)s. On the other hand, if C:\xxx doesn't exist or a file, we create it, possibly asking for a permission to overwrite.

The options will be kept separate

Then I'd propose to rename them to be inline with other software out there:
--output → --template
--paths → --output

They cannot be renamed due to compatibility. --output could at most get an alias with --template, but I even doubt that


Calling Windows.this.close() causes a segmentation fault

As the title suggests, calling Windows.this.close() causes a segmentation fault. I'm able to produce this behavior in both scapp and usciterjs.
To Reproduce
Steps to reproduce the behavior:

Open a file containing a script that calls Window.this.close() like this:

<html>
  <head>
      <title>Testing</title>
      <script>
          document.$("#crash").on("click", function() {
              Window.this.close();
          })
        </script>
  </head>
  <body>
    <button#crash>Click me</button>
  </body>
</html>

Click the button
Sciter crashes

Expected behavior
The window should close gracefully
Video
https://user-images.githubusercontent.com/19616756/124041431-d254d080-d9d4-11eb-8706-3d8e8ebb77e7.mp4
Desktop:

OS: macOS 11.4
Sciter Version: <IP_ADDRESS>

Fixed in <IP_ADDRESS>


Add page.debug properties

To determine whether the app is running in debug or release mode.

Can you check local_connection.py line 41.
"platform" comes twice.


Error while starting my app - (library "libviro_renderer.so" not found)

Requirements:
Please go through this checklist before opening a new issue

[x] Review the documentation
[x] Search for existing issues in: viromedia/viro & ViroCommunity/viro
[x] Use the latest ViroReact release

Environment
Please provide the following information about your environment:

Development OS:  Windows
Device OS & Version: Andoid API 30
Version: ViroReact version - 2.21.1 and React Native version  - 0.63.1
Device(s): What device(s) are you are seeing the issue on (i.e. iPhone X, Samsung Note 8, etc) PIXEL_3_XL emulator

Description
I'm getting the following error when trying to start my app, even after following all the steps as mentioned in the starter kit.
E/AndroidRuntime: FATAL EXCEPTION: create_react_context
Process: com.test.viro, PID: 4598
java.lang.UnsatisfiedLinkError: dlopen failed: library "libviro_renderer.so" not found
at java.lang.Runtime.loadLibrary0(Runtime.java:1087)
at java.lang.Runtime.loadLibrary0(Runtime.java:1008)
at java.lang.System.loadLibrary(System.java:1664)
at com.viromedia.bridge.module.MaterialManager.(MaterialManager.java:58)
at com.viromedia.bridge.ReactViroPackage.createNativeModules(ReactViroPackage.java:111)
at com.facebook.react.ReactPackageHelper.getNativeModuleIterator(ReactPackageHelper.java:42)
at com.facebook.react.NativeModuleRegistryBuilder.processPackage(NativeModuleRegistryBuilder.java:42)
at com.facebook.react.ReactInstanceManager.processPackage(ReactInstanceManager.java:1347)
at com.facebook.react.ReactInstanceManager.processPackages(ReactInstanceManager.java:1318)
at com.facebook.react.ReactInstanceManager.createReactContext(ReactInstanceManager.java:1225)
at com.facebook.react.ReactInstanceManager.access$1100(ReactInstanceManager.java:131)
at com.facebook.react.ReactInstanceManager$5.run(ReactInstanceManager.java:1016)
at java.lang.Thread.run(Thread.java:923).
Reproducible Demo
Let us know how to reproduce the issue. Include a code sample, screen capture, video recording. The more information you provide, the better we can support you.

Found the issue, it doesn't work on my emulator but it works fine on the physical device.


Add missing documentation for Skeleton3D methods

Update get/set for pose position/rotation/scale

Thanks!


"made with myst" link is broken

Describe the bug
context
The book theme has a sidebar/footer item that "Made with MyST" it links to the url: https://myst-tools.org/made-with-myst but that link is broken.
expectation
I expected a page to load.

Reproduce the bug

click on "Made with MyST" on a myst website

List your environment
No response

This now redirects to a tutorial!


add Ubuntu2404 support

MS released image for Ubuntu2404 - testing deployments so keep it in draft until verified

Just did a successful build of a Ubuntu 2404 image to shared gallery.

Thank you for this, I just merged it!


Problem with usage of Minified version of React ?

I'm getting this weird error :

Uncaught Invariant Violation: Minified React error #130; visit http://facebook.github.io/react/docs/error-decoder.html?invariant=130&args[]=object&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings.

i just configured my bin with React/React-Dom 15.3.2 Reat-Tap-Event and Material-UI 0.16.1

i figured it is a side-effect from a missing babel-core to devDependencies ...
should be solved with Update depLoaders with babel-core


PMID:31276301

abolished protein localization to plasma membrane at cell division site during mitotic interphase
abolished protein localization to plasma membrane at cell division site during mitotic M-phase
abolished protein localization to medial cortex during during mitotic interphase
abolished protein localization to medial cortex during during mitotic M-phase
mislocalized protein distributed in cell cortex during interphase
mislocalized protein distributed in cell cortex during mitotic M-phase
normal protein localization to cell division site	during mitotc anaphase
decreased cytoplasmic microtubule depolymerization at plus end at cell tip

decreased cytoplasmic microtubule depolymerization at plus end at cell tip
synonym decreased microtubule catastrophe

abolished protein localization to plasma membrane at cell division site during mitotic interphase FYPO:0007175
abolished protein localization to plasma membrane at cell division site during mitosis FYPO:0007176
abolished protein localization to medial cortex during mitotic interphase FYPO:0007177
abolished protein localization to medial cortex during mitosis FYPO:0007178
mislocalized protein distributed in cell cortex during mitotic interphase FYPO:0007179
mislocalized protein distributed in cell cortex during mitosis FYPO:0007180
normal protein localization to cell division site during anaphase FYPO:0007181
decreased cytoplasmic microtubule depolymerization at plus end at cell tip FYPO:0007182
edit file: 8a95bc89b3f32f0d0962ebfc06b46f1998441fd3
release: 12fe516bbf65388b14137de4caf4313c9f31259e


Deleted unused file

Removed unused file.

Please double check. I believe it is used today, e.g. two space for indent. It is picked up by visual studio code automagically. :)

Please double check. I believe it is used today, e.g. two space for indent. It is picked up by visual studio code automagically. :)

I just checked. Without this file, my VSCode is still able to format the code the way, I think it should be fine.


Check out the Flexirest fork

Given that this project doesn't seem to be maintained by Which and I no longer have access to commit to the repository, I've now forked it to be github.com/andyjeffries/flexirest.
I've maintained version numbers from ActiveRestClient so it should be as simple as a Gemfile update with the new name.
I'm happy accepting issues over at my repository, I'll reply here if I see any - but any fixes by me will only go to my new forked gem.

If the owners of ActiveRestClient are definitely no longer interested in maintaining the gem, please put a large prominent note in the README.md file pointing them to my gem instead.  Thanks.

https://github.com/andyjeffries/flexirest


Question: Benchmark tests

Hello,
as I'm currently in the process of porting RoaringBitmaps to C#, I'm also porting those real data tests.
While my implementation has the same output cardinality as the unit tests, I can't really follow the time results of those tests.
For example:
  <testcase name="test[dataset=census-income, type=roaring, immutable=false]" classname="org.roaringbitmap.realdata.RealDataBenchmarkOrTest" time="1.469"/>
  <testcase name="test[dataset=census-income, type=roaring, immutable=true]" classname="org.roaringbitmap.realdata.RealDataBenchmarkOrTest" time="3.822"/>

The values appear to be too high, do they include the ZIP file part (loading and parsing the census data) or are there multiple iterations to the actual test. It uses JMH, which should handle all that warmup etc. stuff, but as I haven't done any Java work for over ten years I do not really know how e.g. the @Benchmark attribute works.
Are there any real performance benchmarks against the real data, which only handle the actual bitwise operations?

@Tornhoof
Interesting project. Will you make it public?
I think that @gssiyankai  wrote our current real-data tests. Maybe he can comment.
I am not sure why you say that the numbers are "too high". What happens, say, when benchmarking the intersection (and) is that we take the 200 bitmaps (most datasets have 200 bitmaps, some have more) and we compute 199 successive intersections. So the number returned will be the sum of 199 intersections, say.

Yes I will make it public as soon as I clean it up and find out how to use GIT with Visual Studio. I guess this weekend.
Apparently the testcase output snippet was cut from my previous comment.
For example:
Doing 200 consecutive Ors on the census-income dataset takes ~1.5s (or ~3.5 for the immutable version). In my current version the same benchmark (without the time for reading the zip) takes ~3ms.
This is a factor 1000 for the immutable version. If i take the zip reading into account my version also takes around 3s. That's why I'm confused what the real-data benchmark is actually doing.

@Tornhoof
No, the benchmarks do not account for the time required to extract the data from the zip files. When the tests run, they run on pre-prepared data in memory.
Because we test not just one library, but several of them, and we compare the results, we have good confidence that Roaring is not particularly slow. In fact, as you may observe, it does quite well (which is the point of these tests).
So you are saying that you are 500 times faster in C#. My first guess is that you are not measuring what you think you are measuring.
It is hard to tell in the abstract, but when you run your benchmark, do you check the output to make sure that the computations are done, and done correctly? A common problem with benchmarks is that the computations are optimized away or simply not done properly.
Possibly one could compare against an alternative like EWAH? https://github.com/lemire/csharpewah

I solved it and it's a problem of PEBCAK.
I simply didn't pipe the jmh output into a file, so the only data I could find were those unit tests for the benchmarks and those were the wrong ones. Now after running the benchmark.jar manually and piping the output I actually see all that JMH output :)
So a valid comparison would be now:
Java: 3012,222 ±(99.9%) 16,152 us/op [Average]
C#: 3213,093 us
My version is currently immutable (as in defined by C# , which means private constructors, readonly fields etc.) and has no RLE encoding.
Sorry again for the confusion and thanks for the help.

@Tornhoof
Keep us posted on the evolution of your project.

@lemire
As previously announced, I pushed my version to https://github.com/Tornhoof/RoaringBitmap
It includes the basic bitwise operators and enough unit tests to cover them, including your realdata tests.
Notably serialization is currently missing.
As for performance, my version is 10-20% slower than your current Java implementation using a microbenchmark system similar to JMH.

@Tornhoof
Great stuff!


use json as the interchange medium.

CSV is a pain to parse, and is not future-proof.

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   68.71%   68.71%
=======================================
  Files          23       23
  Lines         975      975
=======================================
  Hits          670      670
  Misses        305      305

Impacted Files
Coverage Δ

starfish/starfish.py
92.12% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8600969...5fdb1d6. Read the comment docs.


add cmcstl2

I've followed this guide
step by step carefully. [Yes]

I've tested this package remotely and have excluded all broken builds.
Here is the links to the Travis/AppVeyor with status "All passed":

https://ci.appveyor.com/project/dvirtz/hunter/builds/23545480
https://travis-ci.org/dvirtz/hunter/builds/514796795

I have submitted CI configs to https://github.com/ingenue/hunter targeting pkg.template branch,
see this merged pull request https://github.com/ingenue/hunter/pull/351

Testing:

https://ci.appveyor.com/project/ingenue/hunter/builds/23546603
https://travis-ci.org/ingenue/hunter/builds/514818340?utm_source=github_status&utm_medium=notification

Thanks

Uploading:

https://ci.appveyor.com/project/ingenue/hunter/builds/23546689
https://travis-ci.org/ingenue/hunter/builds/514819801?utm_source=github_status&utm_medium=notification

Released: https://github.com/ruslo/hunter/releases/tag/v0.23.148


Update dependencies to current versions and introduce Arrow

Looking to integrate Kestrel into a project using Arrow, I was confused to notice that it declared its own Either and partial application helpers. So I updated it to use Arrow and updated other dependencies.
With Java version support before 17 running out, I also took the liberty of updating it to 17.
Afterwards I also started to use NonEmptySet and NonEmptyList and introduced BookmarkName to replace plain String for identifying bookmarks (s.a. https://arrow-kt.io/learn/design/domain-modeling/)
Sorry for dumping such a huge changeset on you - let me know if I should restructure it in any way.

Sorry about the big delay getting back to you on this one. We love all the version bumps, but after some internal discussion, we decided we'd prefer not to introduce arrow as it's an extra thing for people to learn. If people wish to use arrow, they can easily write a thin adapter layer that can convert between our home-rolled stuff with arrow-based aggregates (non-empty list, either etc.). Again, sorry for the delay on this one


Automator: update proxy@master in istio/istio@master

Generated by Automator - 2023-05-25T21:44:00+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
12b43ba8f6283b53a7b64a5d3555e78912a94d5a
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
632c2b2e55b2620bc5251537994369582da9999d
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
632c2b2e55b2620bc5251537994369582da9999d
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
632c2b2e55b2620bc5251537994369582da9999d
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
632c2b2e55b2620bc5251537994369582da9999d
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-ambient
It passed once, and failed once. A number of aborts.

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
632c2b2e55b2620bc5251537994369582da9999d
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Looks like we have a consistent failure:
--- FAIL: TestL7Telemetry (34.95s)
    --- FAIL: TestL7Telemetry/from_"captured"_to_"waypoint" (32.50s)

open a ticket to track it?


Instructions Link on how to build Geometric refinement project is invalid

In the readme you mention a link to a instruction on how to build the Geometric refinement part on Linux.
However the link provided isn't valid anymore - the page is not found.
Could you please update the link or the readme with the instructions on how to compile under Linux?
Thanks a lot!

hi, you can refer here:
https://github.com/Mingyu-Zheng/mingyu-zheng.github.io/blob/master/_posts/geometric-modeling/2023-2-12-「CAD实体建模」ComplexGen几何优化配置.md
On Wed, May 29, 2024 at 4:32 PM ngrob @.***> wrote:

In the readme you mention a link to a instruction on how to build the
Geometric refinement part on Linux.
However the link provided isn't valid anymore - the page is not found.
Could you please update the link or the readme with the instructions on
how to compile under Linux?
Thanks a lot!
—
Reply to this email directly, view it on GitHub
https://github.com/guohaoxiang/ComplexGen/issues/17, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHCYIE2LGNLXRISBJFX26ETZEWHABAVCNFSM6AAAAABION62NOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZDENZQGYYDQOI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thank you very much for the fast response. Very helpful!


Suggest search doesn't look in autosave files

Results become cluttered, easy to open backup instead of active, etc.

good idea. done.


AnimatedSprite should support FrameObject[]

Error received
Uncaught Invariant Violation: AnimatedSprite texture needs to be typeof `PIXI.Texture

Documentation: https://pixijs.download/dev/docs/PIXI.AnimatedSprite.html#constructor
An AnimatedSprite can accept either a list of Texture of a list of FrameObject
Please remove the invariant error when calling <AnimatedSprite textures={frameObjectList} />
Thanks!

Fixed, strangely PIXI.AnimatedSprite.FrameObject does not exist.. so instead I check for the owner properties to be valid

Thank you !


Conditionally exclude code non armv7-compatible

For projects with deployment target < iOS 13

Hi, I'm afraid I don't understand what this would be useful for.
As far as I understand, the minimum iOS version for SwiftUI is 13.0, which supports the iPhone 6S/6S+/SE and later.
The last iPhone with armv7 architecture is the iPhone 5/5C, which isn't supported anyway.

Hi, I'm afraid I don't understand what this would be useful for.
As far as I understand, the minimum iOS version for SwiftUI is 13.0, which supports the iPhone 6S/6S+/SE and later. The last iPhone with armv7 architecture is the iPhone 5/5C, which isn't supported anyway.

Yes, this PR is not about using the library for older devices, but about being able to include the library on projects with older target iOS versions where the library is selectively used when iOS > 13.

@rivera-ernesto I'm afraid I've had to bump minimum iOS version to 13 in order to have proper CI coverage for iOS 13-16 (#185). Targeting <13 was causing strange nonsensical errors on @available attributes. Hopefully by now iOS 13 should be an acceptable minimum target OS for most developers.


403 forbidden response when extracting info on a remote server

I have a python server on heroku, and I put youtube-dl there to allow Android client achieve media url of videos. But in contrast of when extracting a url locally on my pc, when doing it on the server it returns a url that is not valid for the end user (It says 403 status forbidden).
I guess it has to do with that maybe the url is generated such as it allowed only from the machine that asked for it, but is there any way through this?

For some sites (like youtube) the url may only work on the same computer and/or with specific http headers. You can try using the http_headers field from the json output (-j option`).


Jupyter compatible

Jupyter changes the layout of modules. This commit tries to default to this structure, and failing so it tries importing the older IPython modules.

Worked for me using the jupyter pkg from conda. Thanks!


Added Navbar in Feedback Page

Title and Issue number

Title :Added missing Navbar on the feedback page
Issue No. :#469
Code Stack :
Close #469

the Navbar was missing in the feedback section  and unable to navigate back so , itis important to add Navbar to feedback page also
Describe the solution you'd like

Describe alternatives you've considered

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have gone through the  contributing.md file before contributing

Additional context (Mandatory )
Are you contributing under any Open-source programme?
Gssoc24(girscript summer of code)
original page : without Navbar on Rating page

After updating

Hey @apu52
I have created new PR with resolved Conflict.
Now its Ok

Hi @apu52
I have review it , I saw that the Login page itself has this issue.
when I click login from home page then also getting same error.
for this can I create new issue or solve in this issue only?

Hi @apu52 I have review it , I saw that the Login page itself has this issue. when I click login from home page then also getting same error. for this can I create new issue or solve in this issue only?

I have also rechecked it . there is some problem in this PR . SO , I would like to suggest you to make a complete new PR by closing this PR & by making all the necessary changes

hello @apu52
I have resolved the conflict here itself
please merge this pr
I will do the work on another issue aswell

for login page I will do it in another PR
because that will be another issue
Kindly please merge this PR

hello @apu52 I have resolved the conflict here itself please merge this pr
I will do the work on another issue aswell

I can see now there is also a problem in the footer portion , testimonial section now in this PR. So I am closing this PR now .
Make a new PR by making a new branch in your forked repo & push all the changes there.


build_packages: fix default torcx output root

In 9fba5789f95bf79a393c5e35cb2346d3900e29ba we introduced  --torcx_output_root as an optional command line parameter and had it default to ${DEFAULT_BUILD_ROOT}, inadvertently  diverging from the previous default, which was ${DEFAULT_BUILD_ROOT}/torcx.
This change sets the correct default root ${DEFAULT_BUILD_ROOT}/torcx to bring build_packages back into alignment with build_image (as well as the lower level build_torcx_store).
This change should be cherry-picked into the release branches flatcar-3033, flatcar-3066, and into the upcoming Alpha release branch.

Merged + cherry-picked for flatcar-3033, flatcar-3066.


Support ioctl

so we can use lsattr to list the predefine flags on files in JuiceFS, also use chattr to change that.
For the flags, we may want to support: append only (a), no atime  updates  (A), compressed  (c),   immutable (i),  secure deletion (s),  and undeletable (u)
See the man page of chattr, lsattr and ioctl ioctl_list for details.

ltp test: setxattr03, need support for immutable and appendonly flags

Hi, I am interested in this issue, can you give me more detailed information?

What is the problem that this issue is expected to solve?
What is the final functionality to be achieved?
Do I need to submit a Proposal?

ioctl is a syscall to update a predefined flag on a file/dir, we need to do the following:

support ioctl operation from FUSE
persistent the flags in meta engine
Add API to update the flags for meta engine
For every flag, other related operations should respect it. for example, for a file with immutable flag, we should not modify it.

How 's the current progress? If nobody involves in this support, I'd like to make some contributions.

How 's the current progress? If nobody involves in this support, I'd like to make some contributions.

This issue is free for you to take!

@DMwangnima Update the description, feel free to take this.

Copy that~

@davies Now juicefs uses RawFileSystem interface given by go-fuse, but go-fuse doesn't support ioctl even encoding or decoding datum from ioctl syscall.

So do I need to make a PR to go-fuse to implement ioctl or make a fork form go-fuse just for juicefs?

We can fork it, add ioctl, use the fork in JuiceFS, then upstream it later.


Issue 165 implement multitype hyperparameter

Implementation of multitype hyperparameter

Codecov Report

Merging #168 into master will decrease coverage by 8.22%.
The diff coverage is 75.52%.

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   96.11%   87.89%   -8.23%
==========================================
  Files          36       40       +4
  Lines         669     1115     +446
==========================================
+ Hits          643      980     +337
- Misses         26      135     +109

Impacted Files
Coverage Δ

btb/tuning/hyperparams/multitype.py
0% <0%> (ø)

btb/selection/uniform.py
100% <100%> (ø)
:arrow_up:

btb/benchmark/challenges/rosenbrock.py
100% <100%> (ø)
:arrow_up:

btb/benchmark/challenges/census.py
100% <100%> (ø)

btb/tuning/hyperparams/base.py
95.23% <100%> (+4.91%)
:arrow_up:

btb/benchmark/tuners/btb.py
100% <100%> (+100%)
:arrow_up:

btb/benchmark/challenges/bohachevsky.py
100% <100%> (ø)
:arrow_up:

btb/benchmark/challenges/__init__.py
100% <100%> (ø)
:arrow_up:

btb/benchmark/challenges/boston.py
100% <100%> (ø)

btb/tuning/metamodels/gaussian_process.py
100% <100%> (ø)
:arrow_up:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7268dc7...4fd0296. Read the comment docs.


drivers: sensor: bme280: use int math in decode q31 conv

Fix decoder to use integer math when converting readings to Q31. Clang format files.
Fixes #77295

Finally getting reasonable numbers:
*** Booting Zephyr OS build v3.7.0-2432-g9992127cf326 ***
Found device "bme280@77", getting sensor data
temp: 23.99975; press: 100.816406; humidity: 48.260742
temp: 23.99975; press: 100.816406; humidity: 48.238281
temp: 23.109985; press: 100.820312; humidity: 48.283203
temp: 23.109985; press: 100.820312; humidity: 48.405273
temp: 23.119995; press: 100.820312; humidity: 48.649414

Please split clang-format run into separate commit.

@teburd @yperess Sorry, just did that. I could've sworn I did it with the first push, but somehow I squashed the commits... anyways it's done now.


Update how-to-connect-modify-group-writeback.md

There were white-spaces after each `  char what prohibits the script to behave as a script. This is tested and confirmed.

Learn Build status updates of commit d274b3e:
:bulb: Validation status: suggestions

File
Status
Preview URL
Details

articles/active-directory/hybrid/how-to-connect-modify-group-writeback.md
:bulb:Suggestion

Details

articles/active-directory/hybrid/how-to-connect-modify-group-writeback.md

Line 46, Column 28: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /graph/api/resources/directorysetting?view=graph-rest-beta
Line 54, Column 26: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /graph/api/group-update?tabs=http&view=graph-rest-beta

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@billmath
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Enabling now flag for remaining operations

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading
whitespace from that line:
NOTE: contains only concrete changes that had I pushed as of now will push remaining changes shortly

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind code-refactoring

What does does this PR do / why we need it:
Enable use of now flag for url create / delete and config set and unset options
Which issue(s) this PR fixes:
fixes #1595
Fixes #?
Fixes
How to test changes / Special notes to the reviewer:

https://github.com/openshift/odo/issues/2485 no way to tell if set/unset pushed to cluster or not at the moment

/retest

Interesting it is failing on licenses wwhrd check -q but everything else is going good so far. But I am not adding anything related to licenses

/retest

/test v4.1-integration-e2e-benchmark

/retest

/retest

@mohammedzee1000 any update on this PR?

please address the comments on the PR as well @mohammedzee1000

Working on it.

/retest

This looks like it is flaking
/retest

Cluster error
/retest

What type of PR is this?
Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading
whitespace from that line:
NOTE: contains only concrete changes that had I pushed as of now will push remaining changes shortly
/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind code-refactoring
What does does this PR do / why we need it:
Enable use of now flag for url create / delete and config set and unset options
Which issue(s) this PR fixes:
fixes #1595
Fixes #?
Fixes
How to test changes / Special notes to the reviewer:

@mzee1000 can you please cleanup the pr description.

done

/remove-kind api-change

/approve


Deleting rooms

Hello, we are planning to use a single Comingle link for the whole semester.

Is this advisable?
If so, is there a way to truly delete rooms, or can we only archive them?  We would like to spontaneously create rooms, but don't want to deal with accumulated junk rooms throughout the semester.

Thanks!

A single link for the whole semester is my plan as well. Of course, this is the first semester we're trying it, so we'll see how it goes...
There currently isn't a way to permanently delete rooms, only archive. (If you're running your own server, you could do it with manual database operations.) I might add this once we have authentication, but I don't view it as a priority. Perhaps you could give your motivation for permanent deletion?

Perhaps you could give your motivation for permanent deletion?

I was going to say it looks cluttered and hinders access to the Create Room button, but then I realized the list can be collapsed from the top, so it looks like that's a good workaround for now.  Thanks for the explanation

Yeah, the archived rooms are actually collapsed by default. A user has to intentionally go digging there if they want an old room. (The motivation is that a student might want to revisit an old topic, including its state. Also to enable staff to recover an accidentally archived room.)
Also, the Create Room button is always visible, even if a lot of rooms are showing.

@hanryhu Admins can now delete rooms and tabs! Send me email if you need the meeting secret for your existing meeting.


Added nav-bar

Please provide the description of the task you have been assigned and mention thee route where you have randered the component (Don't use the landing page route) and make sure you attach the screenshot of the component you have built..!! We appreciate your efforts but these requirements should be achieved inorder to merge your PR..!!

Please provide the description of the task you have been assigned and mention thee route where you have randered the component (Don't use the landing page route) and make sure you attach the screenshot of the component you have built..!! We appreciate your efforts but these requirements should be achieved inorder to merge your PR..!!

Sure I will do the same

Good job!

Your component is good and looks decent. But it's not responsive and the toggle button is also not working. Fix those and raise another PR

Sure I will do it asap

Ok I will make all the changes as you have suggested and will raise a new pr .


Passport.js x Botkit

Hi, anyone has a working code for passport.js integration (Facebook login) ?
I can't save the user's permissioned data using botkit-storage-mongo (no Mongoose).
Any help is highly appreciated
EDIT: the point here is simple data fetching (email, user id, etc.) from facebook login

Yo,
Can you share more details about your use case ? This is a Bot or juste a web app ?


insight can't fetch history (or even balance) for addresses with large number of transactions

Insight times out when trying to fetch ransaction history for address with large number of transactions, such as a satoshi dice address.
  http://live.insight.is/api/txs?address=1dice9wVtrKZTBbAZqz1XiTmboYyvpD3t
  ( TIMES OUT )

FWIW, obelisk blockchain database from unsystem (accessed via sx below) can fetch the balance but also times out on history.
root@ffob:/deploy# time sx balance 1dice9wVtrKZTBbAZqz1XiTmboYyvpD3t
Address: 1dice9wVtrKZTBbAZqz1XiTmboYyvpD3t
Paid balance:    18241421
Pending balance: 18241421
Total received:<PHONE_NUMBER>034
Blockchain.info blockchain database seems to be able to fetch all infos, paginated of course.
https://blockchain.info/address/1dice9wVtrKZTBbAZqz1XiTmboYyvpD3t
Possibly fixing this is as simple as adding pagination to insight / insight api. Possibly it also requires caching balance somewhere.
I know that counterparty uses insight for its block explorer. If it also uses insight for its transaction engine, I suppose this might actually be causing problems. I don't think that's the case, but I think it might be worth a sanity check.

This should be improved, and addressed, with the v0.3.0 branch with the related insight-api v0.3.0 and bitcore-node.

This has been improved in the latest master branch. However there are areas that could also use improvements: https://github.com/bitpay/bitcore-node/issues/354


TOMOYO - the alternative to SElinux?!

There's really little information about it, but Android kernel can be hardened with Tomoyo Linux.
Android sources list Tomoyo under Common Android Kernel Tree, Security Folder.
I have TOMOYO (a security module for system analisys and protection) installed on CentOS and I can tell that's really powerful. I hope someone running android gives Tomoyo a try, as some modded kernels contain it.

Tomoyo Linux is a Mandatory Access Configuration that acts at the kernel level. Some similar security modules are SELinux, Apparmor or Smack.
Particularly, Tomoyo Linux can authorize:

TCP/IP networking operations based on IPv4/v6 addresses and port numbers.

It is well supported on Arch Linux and can be implemented on other distros as Chakra Linux.

I think this also should mentioned and discussed internal with Google. Android itself uses SeDalvik (Android <5) / ART with SELinux since Android 4.3+. The government also uses SELinux (for a reason) instead of grpsecurity or appamor. Since I don't much about TOMOYO I can't really answer on this.
I'm simply not qualified enough to say what's 'the best' but could you explain why you want to replace SELinux with TOMOYO?! Otherwise this only can be mentioned as 'alternative' to the current implemented solution.

Yes, as an alternative option. I'll look at the Android custom image ROM building community: https://forum.xda-developers.com/

SELinux, Tomoyo, AppArmor, grsecurity & Smack - all of those systems rely on setting up a catalogue of rules. Those rules define finer-grained access policies for files and system resources and thus provide increased security.
While Tomoyo, grsecurity and AppAmor are based on restricting file based rules, there weaker than SeLinux or Smack because such systems are working based on file paths (pathnames) which identify the files in the rules.
Advantage is that you can have cleaner and more understandable policy specified in the single place, and you don't have complications of xattrs spreading over whole filesystem. Think ability, I say, which is important. Disadvantage is that some implementations are not able to handle hardlinking or rename in easy for users way. However, Tomoyo not answers all questions.
https://www.cyberciti.biz/tips/selinux-vs-apparmor-vs-grsecurity.html
So I'm gonna close this, because SELinux is totally fine, the real alternative would be (imho) only AppAmor and this has especially on mobile devices still problems, which overall means there is only SeLinux left.


feat: add dineshba/tf-summarize

https://github.com/aquaproj/aqua-registry/pull/6441 dineshba/tf-summarize: A command-line utility to print the summary of the terraform plan
$ aqua g -i dineshba/tf-summarize

How to confirm if this package works well
Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.
Command and output
$ tf-summerize --help
Usage of /Users/yuya-koda/.local/share/aquaproj-aqua/pkgs/github_release/github.com/dineshba/tf-summarize/v0.2.2/tf-summarize_darwin_amd64.zip/tf-summarize [args] [tf-plan.json|tfplan]

  -draw
        [Optional, used only with -tree or -separate-tree] draw trees instead of plain tree
  -md
        [Optional, used only with table view] output table as markdown
  -out string
        [Optional] write output to file
  -separate-tree
        [Optional] print changes in tree format for add/delete/change/recreate changes
  -tree
        [Optional] print changes in tree format
  -v    print version

If files such as configuration file are needed, please share them.

Run terraform plan

$ terraform plan -out=tfplan
...
No changes. Your infrastructure matches the configuration.

Run tf-summerize

$ tf-summerize tfplan
+--------+------+
| CHANGE | NAME |
+--------+------+
+--------+------+

Reference

README

https://github.com/dineshba/tf-summarize#usage

Thanks!

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.60.0


[Feature Request] Command/Binding for yanking the contents of a message.

When copying the contents of a message, other bits of the UI get in the way. There should be a binding such as y for yanking messages.

I am willing to make a PR for this.

If you press yy that should yank the plaintext message body. You can use a count to include multiple messages.

If you want a single key, Y should do the same thing.

Oh, sorry. I was not aware that it exists already.

No worries! It looks like I never documented this. I filed an issue at ulyssa/iamb.chat#15 to do so.


Add a 'Preserve Aspect Ratio' checkbox to Properties panel

Closes #919
Also properties panel updates are now centred around the pivot.

Hi, I tested Preserve aspect ratio at https://editor.graphite.rs/
but it doesn't have any effect: when dragging a shape by lateral/up/down markers, it's still resized only on 1 dimension, instead of keeping aspect ratio.

You have to hold Shift. This checkbox only affects the Scale and Dimensions properties.

Thanks for clarification, I see now.


migrate http://mne-tools.github.io to http://mne.tools

@mne-tools/contributors I bought last week the domain name http://mne.tools
what do you think about migrating http://mne-tools.github.io to http://mne.tools ?
it just means adding a CNAME to github repo. Nothing should be changed regarding how we deploy website etc.

Sounds good

i like it too

Cool! The old URL will redirect?
On June 16, 2019 1:45:04 PM AKDT, Teon L Brooks<EMAIL_ADDRESS>wrote:

i like it too

yes It will redirect

awesome !

Closing because this has been working for a while.


[incubator/logstash] update to logstash version 6.3.2

What this PR does / why we need it: updates logstash to version 6.3.2**
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/assign @foxish

@davidkarlsen
sure, done :-)

/lgtm
/ok-to-test

/lgtm


Connect To API

In this milestone of my Bookstore App, I achieved the following:

Used fetch with createAsyncThunk to make API calls.
Fetched book list from Bookstore API on Books page load.
Changed my existing Action Creators, so they return functions.
Made changes by using API.
Made sure there were no linter errors.
Used correct Gitflow.
Documented my work in a professional way.

Hello @andersonlebon 👋🏼 ,
Thank you for taking out time to review and approve this pull request. 💯


Binary data in QR codes on iOS

Hi
I'm using QR codes to transfer binary data. This does generally work if the encoding is set to ISO8859-1 in the QR code and the code reading library respects this (not all do).
Using barcode_scan on Android, the returned string is an exact binary copy of the QR code and the bytes can be accessed with .codeUnits which is perfect.
On iOS however, the returned string is truncated at the first null byte as if at some point it is being treated as a 'C' string where 0x00 terminates the string.
The current git master branch behaves the same.
It's not a normal use case I know but it would be great if the behaviour was the same on iOS as Android.
I'm happy to look into the source code but could do with some pointers about where to look. Also, I have no idea how to debug the calls into the iOS code from AndroidStudio...
Any help would be much appreciated !

In case it helps anybody else, the binary data is available, at least in iOS 11 or later but not in the normal stringValue of the scanned code.
void startScan() in Classes/BarcodeScannerViewController.m needs to be modified if the full QR code is to be returned.
In older ios versions, the data may be available but it is probably a bad idea to access it this way.
There seems to be a 4 byte header and 20 bytes extra at the end. I've stripped off the header but left the 20 bytes at the end.
By the way, I know C but not ObjectiveC so excuse any messiness...
- (void)startScan {
    NSError *error;
    [self.scanner startScanningWithResultBlock:^(NSArray<AVMetadataMachineReadableCodeObject *> *codes) {
        [self.scanner stopScanning];
         AVMetadataMachineReadableCodeObject *code = codes.firstObject;
        if (code) {
            char buffer[4096];
            NSData *data;
            if (@available(iOS 11.0, *)) {
                CIQRCodeDescriptor *test1 = (CIQRCodeDescriptor*)code.descriptor;
                data = test1.errorCorrectedPayload;
                [data getBytes:buffer range:NSMakeRange(0, data.length)];
                // Skip the first 4 bytes and the data starts there...
            } else {
                // Fallback on earlier versions. Not sure I can test this...
                AVMetadataMachineReadableCodeObject *test2;
                data = [test2 valueForKeyPath:@"_internal.basicDescriptor"][@"BarcodeRawData"];  // ios8, 9, 10. Dodgy.
                [data getBytes:buffer range:NSMakeRange(0, data.length)];
            }
            //[self.delegate barcodeScannerViewController:self didScanBarcodeWithResult:code.stringValue];      // Original return value.
            NSString* myString = [[NSString alloc] initWithBytes:(buffer + 4) length:(data.length - 4) encoding:NSISOLatin1StringEncoding];
            [self.delegate barcodeScannerViewController:self didScanBarcodeWithResult:myString];
            [self dismissViewControllerAnimated:NO completion:nil];
        }
    } error:&error];
}

Can you please provide an QR code which contains data with causes the problem?

No problem - see attached PNG.
With version 3.0.0 barcode.rawContent.codeUnits gives :
Android : [120, 218, 237, 210, 61, 106, 2, 81, 16, 0, 224, 183, 26, 127, 42, 211, 164, 22, 47, 176, 242, 246, 41, 145, 180, 166, 73, 44, 9......(length 194 bytes)
IOS :  = [120, 218, 237, 210, 61, 106, 2, 81, 16] (length 9 bytes).
Mine is a pretty unusual use case so thanks for looking at it anyway.


One-Bit Adam is not compatible with Zero 2?

One-Bit Adam with Zero 1 works fine
But Zero2 run error:
File "/data/miniconda3/envs/env-3.6.8/lib/python3.6/site-packages/deepspeed/runtime/zero/stage2.py", line 1570, in has_overflow_partitioned_grads_serial
File "/data/miniconda3/envs/env-3.6.8/lib/python3.6/site-packages/deepspeed/runtime/zero/stage2.py", line 1577, in has_overflow
for j, grad in enumerate(self.averaged_gradients[i]):
 TypeError: 'NoneType' object is not iterable

We don’t have full support for composing 1-bit with zero-*. Zero 2 which partitions gradients especially would have difficulties here since 1-bit handles gradients in a different way than zero.

@jeffra adding to this.. I am curious to know if 1-bit + zero-* support is in your work plan? if so any estimate of the timeline (weeks, months?) Also curious to know how much of an effort it is to enable this? Thanks,

Closing this issue as it is stale.


Added functionallity on the inputs so that it can match another field…

Added functionallity on the inputs so that it can match another field as a validation, for example when it is needed to compare email fields or pasword validations.
Example:

Coverage remained the same at 97.753% when pulling 10d7490c9053a4cc81502909bafa1d101e779e11 on GerardoHP:master into d42eb6ee55918372230d88beb970432219e5c6d6 on unosquare:master.

Great commit. I'll merge it but I'll try to figure out if it's possible to access to the parent component to retrieve the sibling field and not use the document.getElementsByName because we are planning to move to components and DOM manipulation should not included.


Different time zone of messages from one mail service

Hello. I receive messages of the same day, and the date of the message is in different time zones. Can you set the conversion globally?
Code to Reproduce
My code is big, I'll make a snippet to point exactly to the place where the problem is
$getMessage = $folder->query()->since('29.11.2021');
foreach($getMessage as $mail){
   dump($mail->getDate()->toDate()->toDateTime()->getTimestamp());//here is the problem
}

Expected behavior
Time zone setting to which all dates will always be converted.
Desktop / Server (please complete the following information):

OS: Windows 10
PHP: 7.4.21
Version: v2.7.2
Provider: ukr.net

Hi @byhaskell ,
thanks for the excellent question. I believe all unix timestamps are based on UTC - I've tested my hypothesis with this little sniped:
use Carbon\Carbon;

$date = Carbon::now();
var_dump($date->timestamp, $date->format("d.m.Y H:i:s"), $date->getTimezone()->getName());

$date->setTimezone('America/Los_Angeles');
var_dump($date->timestamp, $date->format("d.m.Y H:i:s"), $date->getTimezone()->getName());

..which returns:
int(1638214225)
string(19) "29.11.2021 19:30:25"
string(3) "UTC"
int(1638214225)
string(19) "29.11.2021 11:30:25"
string(19) "America/Los_Angeles"

If you want to implement some custom magic, you could utilize a custom MessageMask:
class CustomMessageMask extends \Webklex\PHPIMAP\Support\Masks\MessageMask {

    /**
     * New custom method which can be called through a mask
     * @return string
     */
    public function Date(){
        return $this->date->toDate()->setTimezone('America/Los_Angeles');
    }
}

/** @var \Webklex\PHPIMAP\Client $client */
$client->connect();
$client->setDefaultMessageMask(CustomMessageMask::class);

/** @var \Webklex\PHPIMAP\Folder $folder */
$folder = $client->getFolder("INBOX");

/** @var \Webklex\PHPIMAP\Folder $folder */
$folder->query()->all()->limit(1)->get()->each(function($message){
    /** @var \Webklex\PHPIMAP\Message $message */
    var_dump($message->mask()->Date()->format("Y-m-d H:i:s"));
});

Additional references:

https://www.php-imap.com/api/mask
https://www.php-imap.com/configuration/masks
https://github.com/Webklex/php-imap/blob/master/src/config/imap.php#L219

Best regards,

@Webklex  Thank you, very cool approach to solving the problem, your solution clearly has a good future.


Fix makeMockable usage in documentation

The Template Haskell API functions were changed to use Type instead of Name in cdsmith/HMock@c92244661b18338e9c65c9531c50051b023da287 but not all of the documentation was updated.  This change fixes examples for both makeMockable and makeMockableWithOptions in the documentation.

Thanks!


Fix lighthouse link

Thank you!!
On Wed, 10 Oct 2018 at 6:20 pm, Yutaro Mori<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/ethereum/eth2.0-specs/pull/63
Commit Summary

Fix lighthouse link

File Changes

M specs/simple-serialize.md
https://github.com/ethereum/eth2.0-specs/pull/63/files#diff-0 (2)

Patch Links:

https://github.com/ethereum/eth2.0-specs/pull/63.patch
https://github.com/ethereum/eth2.0-specs/pull/63.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ethereum/eth2.0-specs/pull/63, or mute the thread
https://github.com/notifications/unsubscribe-auth/AGWiNPx7BrhSUlAvK-2gxHvl_oUMMPAYks5ujZ_OgaJpZM4XUt6B
.


New package: CIFTI v1.0.0

Registering package: CIFTI
Repository: https://github.com/myersm0/CIFTI.jl
Created by: @myersm0
Version: v1.0.0
Commit: bc8578f8d8fd84d6c20b47e31c47c18fcdc92004
Reviewed by: @myersm0
Reference: https://github.com/myersm0/CIFTI.jl/issues/4
Description:  A Julia package for reading CIFTI files for surface-space neuroimaging data

I'm trying to register a package and I got a naming conflict. Pull request is here. I propose to call my package CIFTI.jl, after the CIFTI filetype that it is designed to support. The package with a similar name that conflicted with mine is NIfTI.jl, which is for a related but different filetype. Therefore the similarity in names is appropriate.

Bumping this. My package name CIFTI.jl adheres to the requirements I believe: "6. Packages that wrap external libraries or programs should be named after those libraries or programs." Thanks in advance.

[noblock]
@myersm0 I'm unclear on what "JuliaRegistrator deployed to stopwatch 5 days ago" means, it seems it's because of submission #4 above, not this open PR (it should have taken 3 days).
FYI: Your package will become 9999 or 10,000 depending on when this gets unblocked. Please don't consider unblocking Cifti.jl lower case just to be number 10,000 :)


[firebase_auth/invalid-verification-code] On Firebase phone auth

my app is crashed when the user types the wrong pin code.
[firebase_auth/invalid-verification-code] The sms verification code used to create the phone auth credential is invalid. Please resend the verification code sms and be sure use the verification code provided by the user.

This is expected behaviour, you need to catch this error and handle it in the UI yourself.

This is expected behaviour, you need to catch this error and handle it in the UI yourself.

@Ehesp I already caught. but app is crashed. please don't close a bug without any solutions

Please follow the issue template with full reproduction code and someone will be able to help.

@Ehesp 😂


Error loading audio URL in Mac OS Catalina and Safari 15

I think it is the same issue related to this.
Description

It happens on Safari 15(156<IP_ADDRESS>.4, 15612) on macOS Catalina 10.15.7（19H1417）. Not happens on Safari 12 and Mojave, or Safari 15 and Big Sur.
It happens always.
Dev Console says "Error loading audio url: foobar.m4a" and "Unhandled Promise Rejection: EncodingError: Decoding failed".

Steps to Reproduce

Fork "Flappy Bird" project from https://playcanvas.com/explore/featured and launch it on Safari 15 on Catalina.

Originally posted by @oyapiro in https://github.com/playcanvas/engine/issues/3511#issuecomment-926590250

I've been unable to reproduce this issue on Big Sur and Safari 15. Even tried a VPN to Japan to see if that was the issue and no success in reproducing the issue


Gallery view

Includes ordering of filters and updates to the widget itself.

Coverage decreased (-1.0%) to 90.966% when pulling 5f0e7d2c9c060d66931311d0c07bb1c631f88f69 on gallery-view into eb6c0ceb33c42912d646b9c44e0a817f5807bd0e on master.

Coverage increased (+3.2%) to 95.099% when pulling bec8c6963dd9c0958c4b7c894f484dd84e776519 on gallery-view into eb6c0ceb33c42912d646b9c44e0a817f5807bd0e on master.


Upgrade zipkin-repoter 3.4.0

Motivation:
sofaboot support 3.3.2 failed：https://github.com/sofastack/sofa-boot/pull/1335
The reason is that sofa tracer is not compatible with zipkin repoter.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.

Summary by CodeRabbit

New Features

Upgraded the zipkin-reporter dependency to version 3.4.0, which may introduce new features and improvements to tracing capabilities.

Bug Fixes

Adjusted imports in the Zipkin integration components to align with the latest library structure, potentially improving functionality and stability in tracing operations.

https://github.com/sofastack/sofa-tracer/pull/534


Links are not opened in another tab/window

Hi. I upgraded from 0.5.12 to 0.6.1 and links in html bodies are no longer opening in new windows. I noticed that, in moving /messages/:id.html code from web.rb to web/application.rb, the following two lines are gone.
  # Rewrite body to open links in a new window
  body.gsub! /<a\s+/, '<a target="_blank" '

Are they really missing? Or is this being done somewhere else now?
Thanks!

They are being done in decoration and this should be fixed.


Update readme instructions to 0.12.0

Tried to install phoenix_slime on new project but was confused by deps errors with version from README.
Here is a fix :)

Thank you thank you @KernelMadness 😁


remove "_uncheckedWhitelist" in code_generator

From @jmesserly on August 25, 2016 16:43
see my comment here:
https://github.com/dart-lang/dev_compiler/blob/f39c13e0837e3a884c4309ec18cf36a9d7620dd6/lib/src/compiler/code_generator.dart#L5272
This whitelist is hugely problematic. In addition to the soundness problem it is totally unmaintainable to be hard coding file and method names from a web framework in a compiler. What if they refactor their code? I empathize that we may have hit a tough problem, but this can't be the right solution.
Copied from original issue: dart-lang/dev_compiler#629

From @jmesserly on August 25, 2016 16:43
thanks to @vsmenon for reminding me to file an issue on this

Waiting on typed ng.dart templates to remove this whitelist.

This is waiting for the new AngularDart code generator, so should be moved to 1.24. Do you agree, @vsmenon ?

Yes, moved it.

This seems unlike for 1.24, given that AngularDart hasn't yet switched to the new code generator. Thoughts?

We should experiment with how far off we are internally, but yes, won't be in time for 1.24.

https://codereview.chromium.org/2928483002/


Add2App for Flutter Web

Add2App for Flutter Web
Use case
If you have an existing web app, a large-scale project, written in a JavaScript-based framework, it would be very useful to be able to add some components to that web app using Flutter. This way, the same Flutter component could be added to an existing native Android and iOS app + the existing web app.
Current situation
Currently, Flutter makes it very hard to add a module to an existing HTML-based project; the only possible solution seems to be <iframe>s.
Proposal
Provide a way that allows attaching a Flutter module to HTML elements.

Duplicate of #32329


Figure out how to set/get migration network details for a VMware host in the API

The hosts table has columns for Network, Bandwidth and MTU, and there is an operation to set the selected network for a host. @jortel do you know how/where we would get/set this data in the API? Currently I see how to get the networks on each host, but no notion of a "selected migration network" and no Bandwidth or MTU values.
Relevant mockups:

Closing this issue in favor of #138.


How should we treat a BuildRun?

Idea:
This is coming from an internal bug we found in our continuous tests. At the moment a BuildRun can be mark as completed during specific scenarios, but it can happen that at some point later, the BuildRun controller reconciles again and the pod runs to completion.
In the above scenario a BuildRun Status will be in a failed state, while the container image was successfully build.
In order to address the above, we have been discussing on how we should treat a BuildRun in general. Our idea is that a BuildRun is:

A one-try shot and either it starts successfully or not.

which makes sense because we are aiming to run something till Completion. If the above is the case, we will need to ensure this expectation matches the code implementation, in order to avoid the above scenario.

Keeping this one open for a while. The general idea so far is to follow a

One-try shot approach

where a BuildRun cannot change its state after the CompletionTime is set.
The above is coming from https://github.com/shipwright-io/build/issues/551

I would like to broaden the scope of this issue a little bit:
In the BuildRun controller we have the problematic updateBuildRunErrorStatus function which sets the completionTime and the error details. But, we actually use it for two different kind of errors:

User-originated errors like a Build or ServiceAccount referenced in the BuildRun that does not exist.
System-originated errors like a failure to create a TaskRun (I just had a network timeout from the Tekton validating webhook)

While for user-originated errors, I propose to make the BuildRun a one-time shot = we set the BuildRun error details, we also set its completionTime and then the controller MUST NOT return an error so that no further retries happen. What we should consider in this context is to prohibit end user's from updating a BuildRun. We want them to create a new one, as such I do not see any use case to allow them to do an update operation at all one a BuildRun.
For system-originated errors where we do intend to do a retry, we imo either should stop to update the BuildRun status at all (and only return the error to trigger the retry) or we set a temporary failure without a completionTime that we remove once the retry succeeded.
--
Also a little bit related to my comment in Fix missing BuildRun Conditions updates on errors #548. Fyi @xiujuan95

FYI whatever traction that might exist for retry in Tekton is centered around this TEP:  https://github.com/tektoncd/community/pull/239
Evidently there is some retry support at the PipelineTask level that I at least was previously unaware of.  A quote from that TEP:  PipelineTask can be rerun after failure when user specifies retries in PipelineTask
And found this:  https://github.com/tektoncd/pipeline/blob/master/pkg/apis/pipeline/v1beta1/pipeline_types.go#L137
Granted it seems orthogonal since shipwright does not leverage PIpelineTask.
But another "monitor upstream Tekton in this space" element for this one perhaps.

I would like to broaden the scope of this issue a little bit:
In the BuildRun controller we have the problematic updateBuildRunErrorStatus function which sets the completionTime and the error details. But, we actually use it for two different kind of errors:
1. User-originated errors like a Build or ServiceAccount referenced in the BuildRun that does not exist.

2. System-originated errors like a failure to create a TaskRun (I just had a network timeout from the Tekton validating webhook)

While for user-originated errors, I propose to make the BuildRun a one-time shot = we set the BuildRun error details, we also set its completionTime and then the controller MUST NOT return an error so that no further retries happen. What we should consider in this context is to prohibit end user's from updating a BuildRun. We want them to create a new one, as such I do not see any use case to allow them to do an update operation at all one a BuildRun.
For system-originated errors where we do intend to do a retry, we imo either should stop to update the BuildRun status at all (and only return the error to trigger the retry) or we set a temporary failure without a completionTime that we remove once the retry succeeded.
--
Also a little bit related to my comment in Fix missing BuildRun Conditions updates on errors #548. Fyi @xiujuan95

I agree with the user vs. system error distinction and that we should allow the controller's behavior to vary based on that @SaschaSchwarze0

We want them to create a new one, as such I do not see any use case to allow them to do an update operation at all one a BuildRun. EDIT: once we want to do something like cancel, we will likely still need to allow updating a BuildRun.

Agree - I envision cancel being implemented by setting the cancelled field on the BuildRun spec, and ignoring or rejecting other changes. A validating admission webhook could help here, but IMO is not necessary for minimum viability.

For system-originated errors where we do intend to do a retry, we imo either should stop to update the BuildRun status at all (and only return the error to trigger the retry) or we set a temporary failure without a completionTime that we remove once the retry succeeded.

My preference is to just not update the status and retry the reconciliation. The caveat being that if we reach a reconciliation retry limit, then we should update the status with an error message.

Good comments @adambkaplan and @gabemontero. Had a call with @qu1queee just an hour ago on this as well. I think we are totally on the same page here.
Just one question on the following @adambkaplan

The caveat being that if we reach a reconciliation retry limit, then we should update the status with an error message.

More than half a year ago we also discussed a scenario in a community meeting or issue (I think it was related to the build-secret relationship at that time which has been handled with a different implementation in the meantime). How would one implement a way to detect that for the same reconciliation request, one is in a retry loop that is already ongoing for n1 retries or n2 minutes?

How would one implement a way to detect that for the same reconciliation request, one is in a retry loop that is already ongoing for n1 retries or n2 minutes?

Hrm, it seems there is no direct way to say "stop reconciling after X failed attempts". However, in reviewing other issues reported on controller-runtime it seems that if the reconciler returns Requeue: true or we return an error, an exponential backoff is used to ensure there is no hot looping [1]. This takes care of my concerns regarding perpetual retries - hopefully if we are doing this due to a bug we have sufficient logs to surface the issue, and the exponential backoff ensures that we don't swamp the controller with bad retries.
[1] https://github.com/kubernetes-sigs/controller-runtime/issues/808

How would one implement a way to detect that for the same reconciliation request, one is in a retry loop that is already ongoing for n1 retries or n2 minutes?

Hrm, it seems there is no direct way to say "stop reconciling after X failed attempts". However, in reviewing other issues reported on controller-runtime it seems that if the reconciler returns Requeue: true or we return an error, an exponential backoff is used to ensure there is no hot looping [1]. This takes care of my concerns regarding perpetual retries - hopefully if we are doing this due to a bug we have sufficient logs to surface the issue, and the exponential backoff ensures that we don't swamp the controller with bad retries.
[1] kubernetes-sigs/controller-runtime#808

Okay, we are on the same page then. Thanks for clarifying.

I will provide a PR to address this issue and also to address this enhancement https://github.com/shipwright-io/build/pull/548#discussion_r568574410. I´m assigning this issue to me in the meantime.

I think this should not yet have been closed.

FYI, I´m already working on this one.

This was tackle via https://github.com/shipwright-io/build/pull/641


Improve Cache test coverage

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.92%. Comparing base (832516b) to head (a93d70f).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #292      +/-   ##
============================================
+ Coverage     65.89%   65.92%   +0.02%
+ Complexity      369      368       -1
============================================
  Files            27       27
  Lines          1214     1212       -2
============================================
- Hits            800      799       -1
+ Misses          414      413       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: Attempted implemented graceful shutdown

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
Note: If you are opening a pull request against a legacy branch, PLEASE BE AWARE that we generally won't accept these except for things like important security fixes, and only for a limited time.

@jjm340 Thanks for opening a PR. I think I can see some ways we can simplify this, but my main concern is that it might be considered a breaking change. I'd say "let me talk to the team on Thursday" except it's going to be US Thanksgiving :) so many of them will be out. Anyhow, I'll get back to you.

@jjm340 Thanks for opening a PR. I think I can see some ways we can simplify this, but my main concern is that it might be considered a breaking change. I'd say "let me talk to the team on Thursday" except it's going to be US Thanksgiving :) so many of them will be out. Anyhow, I'll get back to you.

@feywind Thanks!! I had the same thought about this being a breaking change and a colleague and I discussed putting this behind an option flag, but wanted feedback from Google on that. I believe one side effect is that if this approach is used and a message is neither ACKed or NACKed, then the promise would never resolve and keep the consumer open indefinitely.

I'll probably be picking this up again soon - the delay was because there was a fair amount of discussion about the way this should be implemented, and that is wrapping up now.

@feywind I was wondering if I should be fix my conflicts and attempt to put this behind a setting or is this being worked on by the team?


Make API error expectations compiler-checkable.

Follow-on from https://github.com/input-output-hk/cardano-wallet/pull/3824 (ADP-2269).
Summary
This PR replaces expectErrorCode, which creates expectations based on string comparisons, with expectErrorInfo, which creates expectations based on ApiErrorInfo objects.
This has two advantages:

expectation expressions can be checked statically by the compiler.
it's possible to express richer expectations based on internal fields of errors (not all errors are just simple values -- some have nested records), using combinators provided by hspec.

Context
In our test suite we test at least two kinds of mapping:

The mapping between API types and their serialised JSON representations: for all API types, the JSON encoding should be consistent with the OpenAPI specification, and the round trip property (decode . encode == id) should hold for all values.
The mapping from (API call, inputs, state) to API response values: i.e, that API calls return the responses we expect, given appropriate inputs and the current (implicit) wallet state.

Up until now, the approach we've used in cardano-wallet is to separate the above two concerns into different test suites, i.e., to:

test expectations about our JSON serialisation logic in specialised tests for just that purpose (JSON golden round trip tests and the test suite for the OpenAPI spec).
within other test suites (such as the integration test suite), assume the correctness of our JSON serialisation logic, and express expectations in terms of ordinary (decoded) Haskell values.

API errors have, up until now, been a sort of exception to this separation of concerns, because until recently we didn't have a good way to create structured errors.
But since merging #3557, which provides support for structured errors and the accompanying decodeErrorInfo function, we've gradually been converting expectations about API errors to use the same style as we use for ordinary values returned by the API, which is to express expectations in terms of ordinary Haskell expressions, and to avoid writing expectations in terms of hard-coded strings.
For example, for ordinary (non-error) API responses, we typically write expectations like this:
https://github.com/input-output-hk/cardano-wallet/blob/7af6d54d21443146320eab04452eefb75b3d553e/lib/wallet/integration/src/Test/Integration/Scenario/API/Shelley/Transactions.hs#L297-L299

I thought you might object 😄 https://github.com/input-output-hk/cardano-wallet/pull/3836#discussion_r1162892317
I have no strong opinion, but perhaps slightly in favour of this PR for consistency with other expectations, and with goldens for ApiErrorInfo already existing. I'll let others comment though.

it could lead to a situation when serialized form of the ApiErrorInfo (utf8 encoded string) doesn't match what is in the openapi.yaml spec but still roundtrips.

I would agree that there are two mappings that we want to check:

The mapping between ApiErrorInfo and JSON: i.e., that the serialized form of each error matches our expectations: i.e., that it is the same as the swagger file, and that (decode . encode == id).

The mapping from (API call, inputs) to ApiErrorInfo objects: i.e, that API calls return the errors we expect, given appropriate inputs.

I would argue that the first mapping is already adequately tested by our JSON roundtrip and golden tests. For example:
https://github.com/input-output-hk/cardano-wallet/blob/b40d9ff99de4bd321bf460874d6dace6c17edafc/lib/wallet/test/data/Cardano/Wallet/Api/ApiError.json#L330-L333
Moreover, the JSON serialisation is consistent: it's just a snake case representation of the constructor. If we really wanted to, we could write a test that loops exhaustively through all of the constructors and checks that the representation is identical to the representation in the swagger file. (Perhaps we should do this.)
If we were to use string comparisons for all of our integration test assertions about API errors, we would effectively be repeating ourselves w.r.t. to testing the JSON serialization. When we do need to update the error types (for whatever reason), it makes the integration test suite harder to update as the compiler will not help to find all the places that need to be updated.
Furthermore, we often want to test expectations about the contents of errors: not all errors constructors are simple values that can be checked with a string comparison, some of them have nested fields inside. Should the integration test suite also be expected to test the serialized representations of error field names?

as it could lead to a situation when serialized form of the ApiErrorInfo (utf8 encoded string) doesn't match what is in the openapi.yaml spec but still roundtrips.

Having string comparisons in the integration tests does not protect us against this.
Suppose that someone changes TransactionIsTooBig to TransactionTooLarge. They update the JSON golden files, and then diligently search for all instances of "transaction_is_too_big" in the integration tests, replacing them with "transaction_too_large", but they forget to update swagger.yaml. In this situation, our test suite will still pass.

bors r+

bors r+

I and @jonathanknowles had a chat about this issue and we came to the following agreement:
Using API types in the integration test suite assuming JSON serialization is tested elsewhere is the current practice and should be continued (we called this status quo a local optimum).
Theoretically it should be possible to make integration tests 100% independent of types defined and used by the application (a global optimum) by code-generating such types from the Open API spec, however, practically there are reasons to believe that such code-generation is not available out of the box in Haskell ecosystem and also could lead to a weaker types, due to the expressiveness power of the openapi schema. We'd like not to embark on this codegen endeavor  before there is evidence that work needed is adequate. Search for such evidence could be done as a hackaton-like experiment separately.


Support binary files for backends, fixes #1407

In cases when we need to provide binary output of backend it is important to set that flag, otherwise writing of \n will produce system specific EOL, causing creation of invalid file.

I think these other backends that need changing too:

regular AIGER
protobuf


Add GitHub Project To Blog Post Text

We should add a link to the GitHub project for the release in the blog post text

And release notes


postTransform would be more useful with schema information

Description
The postTransform option is handed the ts types as they're generated from each OpenAPI schema member in transformSchemaObject.
However, although there is a 1:1 mapping between calls to the postTransform, and OpenAPI schema members, postTransform has no access to the OpenAPI schema object associated with the generated ts node.
I think postTransform would be more useful if it gave access to the schema node, and it should be added to the options argument, passed to postTransform, along with path and ctx.
Checklist

[x] I’m willing to open a PR (see CONTRIBUTING.md)

I was able to reach the schema node a bit indirectly. Rather than change the postTransform signature or modify the TransformNodeOptions, I reached the schema node by resolving the path, already present on the TransformNodeOptions.
postTransform(type: ts.TypeNode, options: openapiTS.TransformNodeOptions): ts.TypeNode {
  const schema = options.path ?
    options.ctx.resolve<openapiTS.ReferenceObject | openapiTS.SchemaObject>(options.path) :
    undefined;

  if (
    schema &&
    !("$ref" in schema) &&
    Object.hasOwn(schema, "x-my-custom-property")
  ) {
    return ts.factory.createUnionTypeNode(…);
  }

  return type;
}

It was still a bit of a chore to discover this path, but since all the necessary pieces seem to be present, perhaps this issue should be closed.

Ha that’s clever! But agreed we could make this easier. We’d accept adding anything onto options (e.g. options.schema). Thanks for suggesting!


add the perf option to benchmark runner.

This PR adds the perf option to the benchmark runner. Note that it only works on Linux.

Thanks, but this looks far too specific, maybe this would be better handled by a Python script in /scripts? Calls to system() and exec() are pretty evil IMHO.

Thanks, but this looks far too specific, maybe this would be better handled by a Python script in /scripts? Calls to system() and exec() are pretty evil IMHO.

Having slept on this i think the best solution is to add a flag to benchmark_runner that just outputs the time range of the hot run query part. That can then be used to subset the perf output, also in a script for example.

Having slept on this i think the best solution is to add a flag to benchmark_runner that just outputs the time range of the hot run query part. That can then be used to subset the perf output, also in a script for example.

@azimafroozeh closing this PR, feel free to open another along the lines we discussed.


Fix infinite requeue for Role/Policy with null description

Fixes https://github.com/aws-controllers-k8s/community/issues/1919
Fixes https://github.com/aws-controllers-k8s/community/issues/1772
Fixes https://github.com/aws-controllers-k8s/community/issues/1610
Fixes https://github.com/aws-controllers-k8s/community/issues/1490
Fixes https://github.com/aws-controllers-k8s/community/issues/2000
Fixes https://github.com/aws-controllers-k8s/community/issues/1939
Fixes https://github.com/aws-controllers-k8s/community/issues/1932
Currently, the controller requeues infinitely if a Role or Policy resource
is created with a null (empty string) description. This issue stems from the
late initialization process used to populate fields defaulted by the AWS API.
For CreateRole and CreatePolicy APIs, AWS accept a Description field but
fails to return it. This disrupts the controller's runtime logic causing
unnecessary infinite requeues and preventing resources from being marked
Synced
While a fix could target code-gen and runtime, this is a unique behavior
specific to IAM APIs. As a temporary solution, we disable late initialization
for the Description field and avoid unpopulating it after a Create call
This commit fixes the infinite requeue bug for Roles and Policies with null
descriptions and adds e2e tests to prevent regressions
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/test all

/unhold

/lgtm


Issue in ubuntu versions 16.04 and above.

Looks like the package uses libpng12-0 as a dependency in ubuntu machines. But libpng12-0 is not available in versions greater than 16.04 . Since new pprojects are deployed in 18.04LTS and 20.04 LTS the compression does not work as they have a libping version more than 12. The module throws the error "error while loading shared libraries: libpng12.so.0: cannot open shared object file: No such file or directory" . Please fix this

I may have the same problem as you. I'm running well on my Debian 9 and I've got a bug on Debian 10
( node:29023 ) UnhandledPromiseRejectionWarning: Error: Command failed with EPIPE: /root/imgHubServer/node_ modules/mozjpeg/vendor/cjpeg -quality 30
write EPIPE
my libpng is
libpng16-16/testing,now 1.6.37-3 amd64 [installed,automatic]

I may have the same problem as you. I'm running well on my Debian 9 and I've got a bug on Debian 10
( node:29023 ) UnhandledPromiseRejectionWarning: Error: Command failed with EPIPE: /root/imgHubServer/node_ modules/mozjpeg/vendor/cjpeg -quality 30
write EPIPE
my libpng is
libpng16-16/testing,now 1.6.37-3 amd64 [installed,automatic]


Circular dependency

Am I the only one who gets this error when building?
Circular dependency: ../../node_modules/graphql-request/dist/index.js -> ../../node_modules/graphql-request/dist/graphql-ws.js -> ../../node_modules/graphql-request/dist/index.js

What tool are you using that leads to this error?

There is middleware now https://github.com/jasonkuhrt/graphql-request/blob/main/examples/other-middleware.ts.

FYI this is likely Rollup emitting this warning.

I see this is coming from our ws module. Speaking of that @jonkoops there's a lot of duplication in that module from some other ws library. It would be nice to ditch all that if possible, but I haven't investigated recently.

Yeah, perhaps this is something we can get to for the next version. I am going to try and get all the open bugs resolved as best I can, then we should take a moment and decide if we want to make some API changes and improvements before the major release.