Workload spreading across failure domains (fix pod anti-affinity performance problem)

Description
As a user, I want to be able to spread workloads to multiple clusters spread across multiple failure domains to improve my application uptime.
(Note: This is just one use case for pod affinity/anti-affinity.)
Progress Tracker

[ ] Before Alpha

[x] Write and maintain draft quality doc: This feature was implemented in 1.3, before the features repo process existed. It was disabled by default due to performance issues, which are now fixed in 1.4.
[x] Design Approval

[x] Design Proposal.  https://github.com/kubernetes/kubernetes/blob/master/docs/design/podaffinity.md
[x] Initial API review (if API).  Maybe same PR as design doc. kubernetes/kubernetes#18265

Any code that changes an API (/pkg/apis/...)
cc @kubernetes/api

[x] Identify shepherd (your SIG lead and/or<EMAIL_ADDRESS>will be able to help you). My Shepherd is: @davidopp

A shepherd is an individual who will help acquaint you with the process of getting your feature into the repo, identify reviewers and provide feedback on the feature. They are not (necessarily) the code reviewer of the feature, or tech lead for the area.
The shepherd is not responsible for showing up to Kubernetes-PM meetings and/or communicating if the feature is on-track to make the release goals. That is still your responsibility.

[ ] Identify secondary/backup contact point. My Secondary Contact Point is<EMAIL_ADDRESS>(and/or GH Handle)

[ ] Write (code + tests + docs) then get them merged.  kubernetes/kubernetes#28952 kubernetes/kubernetes#29109 kubernetes/kubernetes#29379 kubernetes/kubernetes#29539

[x] Code needs to be disabled by default.   Accessed via alpha annotation.
[x] Minimal testing
[ ] Minimal docs

cc @kubernetes/docs on docs PR
cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
New apis: Glossary Section Item in the docs repo: kubernetes/kubernetes.github.io

[ ] Update release notes

[ ] Before Beta

[ ] Testing is sufficient for beta
[ ] User docs with tutorials
- Updated walkthrough / tutorial in the docs repo: kubernetes/kubernetes.github.io
- cc @kubernetes/docs on docs PR
- cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
[ ] Thorough API review

cc @kubernetes/api

[ ] Before Stable

[ ] docs/proposals/foo.md moved to docs/design/foo.md
- cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
[ ] Soak, load testing
[ ] detailed user docs and examples

cc @kubernetes/docs
cc @kubernetes/feature-reviewers on this issue to get approval before checking this off

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT
More advice:
Design

Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

Use as many PRs as you need.  Write tests in the same or different PRs, as is convenient for you.
As each PR is merged, add a comment to this issue referencing the PRs.  Code goes in the http://github.com/kubernetes/kubernetes repository,
and sometimes http://github.com/kubernetes/contrib, or other repos.
When you are done with the code, apply the "code-complete" label.
When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
testing.  They won't do detailed code review: that already happened when your PRs were reviewed.
When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

[ ] Write user docs and get them merged in.
User docs go into http://github.com/kubernetes/kubernetes.github.io.
When the feature has user docs, please add a comment mentioning @kubernetes/docs.
When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.

I believe that this is the affinity performance improvement work that @davidopp and @wojtek-t ? are working on.  Reassigning.

@aronchick Ooh. I don't seem to have permission to assign issues on this repo.  Can someone grant me permission?  @erictune might know what's going on here, because I think this repo was his idea.

@davidopp @wojtek-t folks, which SIG is responsible for this feature?

SIG Scheduling

(since it is primarily a new scheduling feature -- it just happens that the last bit of work that had to be done was making the performance acceptable to enable it, which @wojtek-t just finished)

@davidopp says done.

Updated check-list. Only docs remains for alpha in 1.4.

@davidopp @wojtek-t Please update the docs in https://github.com/kubernetes/kubernetes.github.io, and then add PR numbers and check the docs box in the issue description

Ping.  Any update on docs?

@davidopp @wojtek-t Another ping on docs. Any PRs you can point me to?

This is
https://github.com/kubernetes/kubernetes.github.io/pull/1148

@davidopp has the feature development been finished? If not, it would be better to reopen the issue and mark it with non-1.4 milestone.

This is finished. It maybe should have never been filed as a feature; the real feature is #60 and this is just one use case for it (and one piece of the work to bringing it to GA).

@davidopp thank you for explanation, I've been confused a bit about closing the feature in "Alpha" status.


CORS errors attempting to generate signature input

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://o52ky0nc31.execute-api.ca-central-1.amazonaws.com/dev/input. (Reason: header ‘components-type’ is not allowed according to header ‘Access-Control-Allow-Headers’ from CORS preflight response).

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://o52ky0nc31.execute-api.ca-central-1.amazonaws.com/dev/input. (Reason: CORS request did not succeed). Status code: (null).

Uncaught (in promise) TypeError: NetworkError when attempting to fetch resource.

Fixed in new frontend code.


Limit Implementation

Limit Implementation Steps:

Add parser functionality

Updated parser_visitor.py to process the limit clause (visitor just returns the number in the statement i.e 3 as a ConstantValueExpression)
Updated select_statement.py to include limit count
Test case in test/parser/test_parser.py

Create a logical plan

Created a LogicalLimit operator in optimizer/operators.py
Call the LogicalLimit operator in optimzer/statement_to_opr_convertor.py when creating the logical plan
Test case in test/optimizer/test_statement_to_opr_convertor.py

Create a physical plan

Updated optimizer/plan_generator.py to consider Limit as a Seq Scan node type
Created a limit physical plan in planner/limit_plan.py. This just receives the information of the limit count from the logical plan and constructs a physical version of it
Updated optimizer/generators/seq_scan_generator.py to construct the physical LimitPlan after receiving a LogicalLimit plan
Test cases in test/optimizer/generators/test_seq_scan_generator.py and test/optimizer/test_plan_generator.py

Create an executor

Created executor/limit_executor.py which actually processes how the engine will limit the number of rows returned
Update the plan executor in executor/plan_executor.py to call the LimitExecutor upon processing a LimitPlan created in the previous step
Test cases in test/executor/test_limit_executor.py

Add integration tests

Added integration tests to test end to end system for limit in test/integration_tests/test_select_executor.py

@xzdandy Can you please verify the changes to the limit_executor.py? Rest LGTM.
I changed the implementation. The limit operator shouldn't be treated as a pipeline breaker. So I return as soon as get the required tuples.

@xzdandy Can you please verify the changes to the limit_executor.py? Rest LGTM.
I changed the implementation. The limit operator shouldn't be treated as a pipeline breaker. So I return as soon as get the required tuples.

The rest looks good to me.

The rest looks good to me.


android scroll question

Hi
thanks ionic, my project use ionic,feel very great. boss feeling is very great in ios.
but
I have a question for android performance.
I want to disabled scroll ,use system default scroll. in android environment.
specific
css style no use position absolute ....
So that we can solve the android poor performance under the situation, hope to be able to provide the corresponding configuration.
We can distinguish between android and IOS. Some optimization configuration.
thanks !

Thanks for opening an issue with us! Since this is more of a question you will be able to get a better answer over at our forum (https://forum.ionicframework.com/) or our slack channel (http://ionicworldwide.herokuapp.com/). Thanks again!


Slider has bugs

This repo: https://svelte.dev/repl/5258e80d41a2467b994fdcb516385bf5?version=3.46.4
https://svelte.dev/repl/5258e80d41a2467b994fdcb516385bf5?version=3.46.4
demonstrates that the slider stretches infinitely to right hand side and on the left hand side, it becomes "NaN".

You can also see in the last slider that when the min value is set to 0.1, it doesn't even work.

I have been tripped up by this behavior before as well. Maybe components that deal with numbers could be made more resilient and try to auto convert these props? E.g. using +prop
REPL example


add two projects

let me know if you think the two projects are relevant.

Thanks. I will merge them.
There is a new project from Feifei's group should be mentioned. http://<IP_ADDRESS>/abs/1609.05143.
I will include this also later.

Probably I will start a new section for these two work. They don't quite fit into the tools.


Add privateassets=all to Blazor.Build usages

We recommend using this package with PrivateAssets=all everywhere to
make sure that the MSBuild files brought in by this package aren't
applied to transitively.
When that happens, the Blazor.Build MSBuild files will take over the
Razor functionality for other projects, which breaks MVC's view
compilation functionality.
This is part of a fix for #1216.

It already is the equivalent behavior which I think is why we struggled to find the issue. PackageReference is transitive, including a bunch of loose MSBuild files is not.


hideMobileKeyboard not working

Describe the bug
<DatesRangeInput
  ...
  hideMobileKeyboard
/>

hideMobileKeyboard does not work on my device with the following browsers:

Device: Android 9 OnePlus 5T
Opera 54.1.2672.49808
Chrome 78.0.3904.90

Expected behavior
Soft keyboard should not show if hideMobileKeyboard is applied.
Screenshots

Dependencies versions
Provide version numbers of following packages:

semantic-ui-react 0.87.3
semantic-ui-calendar-react 0.15.3

Closing this. It seems the issue was in our implementation of the input field.


Add experiment tracker

Codecov Report
Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (16925d3) 92.33% compared to head (f69f896) 92.47%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   92.33%   92.47%   +0.14%
==========================================
  Files          35       38       +3
  Lines        1461     1569     +108
==========================================
+ Hits         1349     1451     +102
- Misses        112      118       +6

Flag
Coverage Δ

pytest
92.47% <93.33%> (+0.14%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

bluecast/blueprints/cast.py
84.35% <100.00%> (+0.35%)
:arrow_up:

bluecast/config/training_config.py
100.00% <100.00%> (ø)

bluecast/tests/test_cast.py
100.00% <100.00%> (ø)

bluecast/tests/test_cast_cv.py
100.00% <100.00%> (ø)

bluecast/tests/test_experiment_tracker.py
100.00% <100.00%> (ø)

bluecast/tests/test_shap_explanations.py
100.00% <ø> (ø)

bluecast/blueprints/cast_cv.py
63.73% <66.66%> (+0.20%)
:arrow_up:

bluecast/config/base_classes.py
81.81% <81.81%> (ø)

bluecast/experimentation/tracking.py
94.28% <94.28%> (ø)

bluecast/ml_modelling/xgboost.py
88.88% <87.50%> (+0.98%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Error thrown when no dependency is found

Hello.
I'm using this in order to update lists of dependencies inside a few readmes. If the project has no dependency, it will throw this error.
TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at default (file:///usr/local/lib/node_modules/license-report/node_modules/tablemark/dist/index.js:12:25)
    at formatAsMarkdown (file:///usr/local/lib/node_modules/license-report/lib/getFormatter.js:109:9)
    at file:///usr/local/lib/node_modules/license-report/index.js:59:17

I would expect it to just show nothing.

Fixed with pr #127.

Thank you.


Some files no sounds in preview.

Description
Some files no sounds in preview.
Steps To Reproduce
1 select the file attached.
https://github.com/files-community/Files/assets/11383698/237e84b6-ed07-4047-86f8-71e3cb0255a3
2 play it in preview window
no sound.
Requirements
Fix it please
Files Version
<IP_ADDRESS>
Windows Version
10.0.22631.3737
Log File
debug.log

Thanks for the feedback!
Could you let us know:

Type of the video
Where did you download or produce?
If this issue is still present in preview version https://files.community/download

@0x5bfa v3.5.0 is the latest version.

Type of the video?
mp4 video. I have uploaded it.
the video play has sound in Chrome and other players.
I think you should find out why this kind of video has no sound in the preview window.

I believe the issue is with Windows not supporting the Opus audio codec natively, that's why it doesn't play audio in preview pane, Same thing for Windows Media player.

Files uses the same media player as the Windows Media player, so that would help confirm.

Just converted the video to use mp3 audio codec and audio plays. I think this can be closed as not supported by Windows.

Does it work in VLC? Theoretically we can support the shell preview for VLC if that'll help.

It does in VLC, probably any external media player

@kaifeng80, it turns out this scenario isn’t natively supported by Windows, and therefore won’t work in Files either. However, you might find the QuickLook integration helpful, as it includes support for many non-native file formats. You can learn more about it on our documentation site https://files.community/docs/features/integrations.


Foreign key fields fixed to work in group by reports

In the case of group by report all the database columns are added to the values() call. This way Django will join the foreign table and return the values from related models, also.

Thank you @jrutila! That's great!


cmd/go: data race when running test with coverprofile

What version of Go are you using (go version)?

$ go version
go version devel go1.20-1888875182 Sun Oct 2 15:42:47 2022 +0700 linux/amd64

Does this issue reproduce with the latest release?
No.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/home/ms/go/bin"
GOCACHE="/home/ms/.cache/go-build"
GOENV="/home/ms/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/ms/go/pkg/mod"
GONOPROXY="github.com/tokenomy"
GONOSUMDB="github.com/tokenomy"
GOOS="linux"
GOPATH="/home/ms/go"
GOPRIVATE="github.com/tokenomy"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/ms/opt/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/ms/opt/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="devel go1.20-2807afbac6 Sun Oct 2 15:42:47 2022 +0700"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="0"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3580077936=/tmp/go-build -gno-record-gcc-switches"

What did you do?
I run go test with -race and -coverprofile at the same time on github.com/shuLhan/share and the test are FAIL with data race.
$ CGO_ENABLED=1 go test -failfast -race -count=1 -coverprofile=cover.out ./...
...
==================
WARNING: DATA RACE
Read at 0x000001e5f04c by main goroutine:
  internal/coverage/encodecounter.(*CoverageDataWriter).writeCounters.func2()
      /home/ms/opt/go/src/internal/coverage/encodecounter/encode.go:261 +0x11c
  runtime/coverage.(*emitState).VisitFuncs()
      /home/ms/opt/go/src/runtime/coverage/emit.go:539 +0x6bc
  internal/coverage/encodecounter.(*CoverageDataWriter).writeCounters()
      /home/ms/opt/go/src/internal/coverage/encodecounter/encode.go:268 +0x16f
  internal/coverage/encodecounter.(*CoverageDataWriter).AppendSegment()
      /home/ms/opt/go/src/internal/coverage/encodecounter/encode.go:175 +0x8ea
  internal/coverage/encodecounter.(*CoverageDataWriter).Write()
      /home/ms/opt/go/src/internal/coverage/encodecounter/encode.go:71 +0x97
  runtime/coverage.(*emitState).emitCounterDataFile()
      /home/ms/opt/go/src/runtime/coverage/emit.go:573 +0x91
  runtime/coverage.emitCounterDataToDirectory()
      /home/ms/opt/go/src/runtime/coverage/emit.go:322 +0x310
  runtime/coverage.processCoverTestDir()
      /home/ms/opt/go/src/runtime/coverage/testsupport.go:39 +0x1c4
  main.coverTearDown()
      _testmain.go:179 +0x159
  testing.coverReport2()
      /home/ms/opt/go/src/testing/newcover.go:37 +0xcb
  testing.coverReport()
      /home/ms/opt/go/src/testing/cover.go:83 +0xc74
  testing.(*M).writeProfiles()
      /home/ms/opt/go/src/testing/testing.go:2053 +0xc6f
  testing.(*M).after.func1()
      /home/ms/opt/go/src/testing/testing.go:1987 +0x30
  sync.(*Once).doSlow()
      /home/ms/opt/go/src/sync/once.go:74 +0x101
  sync.(*Once).Do()
      /home/ms/opt/go/src/sync/once.go:65 +0x46
  testing.(*M).after()
      /home/ms/opt/go/src/testing/testing.go:1986 +0x55
  testing.(*M).Run.func4()
      /home/ms/opt/go/src/testing/testing.go:1761 +0x39
  runtime.deferreturn()
      /home/ms/opt/go/src/runtime/panic.go:476 +0x32
  testing.(*M).Run()
      /home/ms/opt/go/src/testing/testing.go:1771 +0xbb3
  github.com/shuLhan/share/lib/dns.TestMain()
      /home/ms/go/src/github.com/shuLhan/share/lib/dns/dns_test.go:63 +0x5db
  main.main()
      _testmain.go:192 +0x33d

Previous write at 0x000001e5f04c by goroutine 9:
  sync/atomic.AddInt32()
      /home/ms/opt/go/src/runtime/race_amd64.s:281 +0xb
  sync/atomic.AddUint32()
      <autogenerated>:1 +0x1a
  github.com/shuLhan/share/lib/dns.(*Server).processRequest()
      /home/ms/go/src/github.com/shuLhan/share/lib/dns/server.go:593 +0xc67
  github.com/shuLhan/share/lib/dns.(*Server).ListenAndServe.func1()
      /home/ms/go/src/github.com/shuLhan/share/lib/dns/server.go:187 +0x39

Goroutine 9 (running) created at:
  github.com/shuLhan/share/lib/dns.(*Server).ListenAndServe()
      /home/ms/go/src/github.com/shuLhan/share/lib/dns/server.go:187 +0xe6
  github.com/shuLhan/share/lib/dns.TestMain.func1()
      /home/ms/go/src/github.com/shuLhan/share/lib/dns/dns_test.go:54 +0x44
==================
...

There are many lines like that with the same pattern.
In the above snippet, the lib/dns/dns_test.go:63 point this code [1],
os.Exit(m.Run())
inside the TestMain. So it does not make sense if the data race is in my code.
A quick bisect point to this commit [2].
I run the test using GOEXPERIMENT=coverageredesign flag using Go tip commit 53773a5d08
$ go version
go version devel go1.20-53773a5d08 Wed Sep 28 11:50:58 2022 +0000 linux/amd64

Without GOEXPERIMENT flag,
$ CGO_ENABLED=1 go test -race -coverprofile=cover.out ./lib/dns
ok      github.com/shuLhan/share/lib/dns        0.707s  coverage: 56.8% of statements

With GOEXPERIMENT=coverageredesign flag,
$ GOEXPERIMENT=coverageredesign CGO_ENABLED=1 go test -race ./lib/dns
ok      github.com/shuLhan/share/lib/dns        0.683s

$ GOEXPERIMENT=coverageredesign CGO_ENABLED=1 go test -race -coverprofile=cover.out ./lib/dns
dns.Server: listening for DNS over TLS at <IP_ADDRESS>:18053
dns.Server: listening for DNS over TCP at <IP_ADDRESS>:5300
dns.Server: listening for DNS over UDP at <IP_ADDRESS>:5300
dns.Server: listening for DNS over HTTPS at <IP_ADDRESS>:8443
dns: invalid IP address "localhost"
dns: invalid name server URI "://<IP_ADDRESS>"
dns: invalid IP address "localhost:53"
dns: invalid IP address "localhost:53"
PASS
==================
WARNING: DATA RACE
Read at 0x000001e5f04c by main goroutine:
  internal/coverage/encodecounter.(*CoverageDataWriter).writeCounters.func2()
      /home/ms/opt/go/src/internal/coverage/encodecounter/encode.go:261 +0x11c
  runtime/coverage.(*emitState).VisitFuncs()
      /home/ms/opt/go/src/runtime/coverage/emit.go:539 +0x6bc
  internal/coverage/encodecounter.(*CoverageDataWriter).writeCounters()
      /home/ms/opt/go/src/internal/coverage/encodecounter/encode.go:268 +0x16f
...

[1] https://github.com/shuLhan/share/blob/61720a183756bdf5a8af45e7d75116ce7ef188e0/lib/dns/dns_test.go#L63
[2] https://go.googlesource.com/go/+/53773a5d0892be4489b4d5e91bbc8ae61000ada7^!/
What did you expect to see?
All test running succesfully.
What did you see instead?
Some test are FAIL-ed due to data race but point to code that are not relevant (in this case the race is inside TestMain function).

This appears to be caused by a goroutine leaked by a test racing with the coverage instrumentation writing out the counters associated with that goroutine.
The testing package does not prohibit goroutine leaks, so this is a bug in the coverage instrumentation. (Perhaps it can be resolved by changing encodecounter to use atomic reads?)
The leaked goroutine is started here:
https://github.com/shuLhan/share/blob/61720a183756bdf5a8af45e7d75116ce7ef188e0/lib/dns/server.go#L187

Thanks, I'll take a look.

This is an interesting bug, since coverage counters are (in theory) supposed to be specially marked as such, and should be "invisible" to the race detector. The fact that you're seeing this problem is an indication that something is going wrong with this process.... more investigation needed.

OK, the code added to the compiler intended to defeat the race detector instrumentation for coverage counters looks like it only applies to direct reads and writes, as opposed to those done via atomic read/write clls (where we don't have an option of turning things off). I'll rework the counter emit code to use atomics as well.


Switch to yaml for config options

User config options in the home folder should use yaml format.

See #219, this has been cancelled. We might still do something like this for "theme" files that can be applied from Lua, but all configuration will be continued to be done through Lua.


Fixes suzuki-0000/SKPhotoBrowser#8 - Double tapping scaled UIImage

UIImages can have a scale value not equal to 1.  If you use the normal SKPhoto loading, this isn't a problem because the NSURLSession gets NSData, which is converted to a UIImage resulting in a scale of 1, regardless of the image.  However, some 3rd party libraries will give back a different scale & image size, so the zooming needs to adjust.

Sorry hang on...still broken somehow.  Investigating now...

@suzuki-0000 ok this should work properly now.  I based the fix on:   http://www.raywenderlich.com/10518/how-to-use-uiscrollview-to-scroll-and-zoom-content

great. thank you for your PR!


Add from_reader method

Like serde_json, it will be nice if we have from_reader.
If we don't have one...
use std::fs::File;
use std::io::Read;

let mut file = File.open(path)?;
let mut content = String::new();
file.read_to_string(&mut content)?;
let some_struct: SomeStruct = toml::from_str(&content)?;

But if we have one...
use std::fs::File;

let file = File.open(path)?;
let some_struct: SomeStruct = toml::from_reader(&file)?;

I'm just beginner of rust, so I don't have enough ability to make it myself and make a pull request. But if anyone can make, codes will be cleaner like above.

Thanks for the report! Right now there's no actual underlying method of doing this other than just reading it entirely to a string, but having that done in a helper function seems fine to me!

What would we do about the error from read_to_string? We can't just add Io(io::Error) to toml::de::ErrorKind because Clone isn't implemented for io::Error.

I think it's probably ok to throw it in something like an Arc to make it clone-able

@alexcrichton
Any update on this?

Maintenance of this crate has moved to the https://github.com/toml-rs/toml repo.  As a heads up, we plan to move toml to be on top of toml_edit, see https://github.com/toml-rs/toml/issues/340.
Closing this out.  If this is still a problem, feel free to recreate this issue in the new repo.


STAR-580 replace polymorphic calls with a switch

The original description:
In profiling JMH workload ReadWide a bottleneck has been identified
in the compareTo call made for AbstractType subclasses. The
comparison code seem overtly generic. For the numerical types in
particular, it is better to specialize.
This ported commit replaces polymorphic 'compare' calls with a
switch. A single entry point for comparison has been created -
AbstractType.compare.
Primitive types were extracted to a separate subgroup with
static calls.

Closing without merging. See the discussion in STAR-580.


Not collecting all span evidence available

Hi all,
I'm trying to run svclone on the output of an in-house variant calling algorithm which doesn't have the most precise breakends. So for example, in the following DUP, the breakends defined by the SV caller are at 19158010 (pos1) and 19167044 (pos2). When I run svclone on this I get that there is 1 spanning call. Even when I set the "wobble" threshold to 1000, I still get only 1 spanning call.
On the other hand, if I redefine the breakpoints to 19158400 (pos1) and 19167140 (pos2), which is a lot more precise, svclone gives me 14 spanning calls and thus 14 support.
Most of the variant calls from my caller are not precise, they have 500 - 1000 bp discrepancies on both ends. I would like svclone to take account of that. Was the "wobble" threshold in the config not the right parameter to change for this? If not, how should I account for this?
Image of variant below in IGV as well as sv input file for sv clone.

The threshold (wobble) parameter was intended for small variation in soft-clip read boundaries. The issue with the spanning read count in this case is that your spanning reads will fail to point towards the break (as the breakpoint will be behind the respective read). It does make sense however that the spanning read count could take into account the threshold. I have added a commit to the dev branch (https://github.com/mcmero/SVclone/commit/53c89af206aeae44f2f4fb38ba07baff8e870ef9) that handles this. Can you test it out and see if it solves your issue?

The issue still remains unfortunately. With the original breakends, I still get only 1 supporting call when I set the wobble threshold to 1000.

There are two things I observed. I edited the code in count.py on my side temporarily to this:
`
def is_supporting_spanning_pair(read,mate,bp1,bp2,inserts,max_ins,threshold):
pos1 = (bp1['start'] + bp1['end']) / 2
pos2 = (bp2['start'] + bp2['end']) / 2
#ensure this isn't just a regular old spanning pair
if read['chrom']==mate['chrom']:
    if read['ref_start']<mate['ref_start']:
        if mate['ref_start']-read['ref_end'] < max_ins: return False
    else:
        if read['ref_start']-mate['ref_end'] < max_ins: return False

#check read orientation
#spanning reads should always point towards the break
if not points_towards_break(read,pos1,threshold) or not points_towards_break(mate,pos2,threshold):
    return False

ins_dist1 = get_bp_dist(read,pos1)
ins_dist2 = get_bp_dist(mate,pos2)

return True # skipping the rest of this function

if is_supporting_split_read_lenient(read,pos1,threshold):
    if not is_below_sc_threshold(mate,threshold):
        #only allow one soft-clip
        return False
    if abs(ins_dist1)+abs(ins_dist2) < max_ins:
        return True
elif is_supporting_split_read_lenient(mate,pos2,threshold):
    if not is_below_sc_threshold(read,threshold):
        return False
    if abs(ins_dist1)+abs(ins_dist2) < max_ins:
        return True
else:
    if ins_dist1>=-threshold and ins_dist2>=-threshold and abs(ins_dist1)+abs(ins_dist2) < max_ins:
        return True

return False

def get_spanning_counts(reproc,rc,bp1,bp2,inserts,min_ins,max_ins,threshold):
pos1 = (bp1['start'] + bp1['end']) / 2
pos2 = (bp2['start'] + bp2['end']) / 2
reproc = np.sort(reproc,axis=0,order=['query_name','ref_start'])
reproc = np.unique(reproc) #remove dups
anomalous = np.empty([0,len(dtypes.read_dtype)],dtype=dtypes.read_dtype)
span_bp1 = np.empty([0,len(dtypes.read_dtype)],dtype=dtypes.read_dtype)
span_bp2 = np.empty([0,len(dtypes.read_dtype)],dtype=dtypes.read_dtype)

counts_0 = 0
counts_1 = 0
counts_2 = 0
counts_3 = 0
for idx,x in enumerate(reproc):
    if idx+1 >= len(reproc):
        break
    if reproc[idx+1]['query_name'] != reproc[idx]['query_name']:
        #not paired
        continue
    mate = np.array(reproc[idx+1],copy=True)
    r1 = np.array(x,copy=True)
    r2 = np.array(mate,copy=True)
    #if read corresponds to bp2 and mate to bp1, switch their order
    if (bp1['chrom']!=bp2['chrom'] and r1['chrom']==bp2['chrom']) or \
        (pos1 > pos2 and bp1['chrom']==bp2['chrom']):
        r1 = mate
        r2 = np.array(x,copy=True)
    counts_0 += 1
    if is_supporting_spanning_pair(r1,r2,bp1,bp2,inserts,max_ins,threshold):
        counts_1 += 1
        if bp1['dir'] in ['+','-'] and bp2['dir'] in ['-','+']:
            counts_2 += 1
            if validate_spanning_orientation(bp1,bp2,r1,r2):
                counts_3 += 1
                span_bp1 = np.append(span_bp1,r1)
                span_bp2 = np.append(span_bp2,r2)
                rc['spanning'] = rc['spanning']+1
            else:
                anomalous = np.append(anomalous,r1)
                anomalous = np.append(anomalous,r2)
    else:
        anomalous = np.append(anomalous,r1)
        anomalous = np.append(anomalous,r2)
print(counts_0, counts_1,counts_2,counts_3)
return rc,span_bp1,span_bp2,anomalous

`
When I set the threshold to 6, the statement "print(counts_0, counts_1,counts_2,counts_3)" gives (139, 4, 4, 1).
When I set the threshold to 150, the statement gives (253, 11, 11, 1)
When I set the threshold to 1000, the statement gives (625, 14, 14, 1).
Does this give some insights on how I can change the code to fit our use?

Thanks for the info. This would suggest that the validate_spanning_orientation function doesn't take into account the threshold. Would it be possible for you to share a bam file with the reads from this SV so that I can test this?

Sorry for getting back late on this, the bam file I'm using is from seqc2 consortium, here: https://www.ncbi.nlm.nih.gov/sra/SRX4728475[accn

Sorry for the late reply. I've had another look at this and have added some code to the e2b8566 dev commit that would likely handle spanning reads from "wobbly" breaks. However, I would recommend recalibrating your SV calls instead to be as accurate as possible. SVclone was designed to handle only small deviations in breakpoint locations, and large deviations will likely lead to inaccurate results or bugs.


Fix bug about set a default date for the situation that user does not give any default value

Fix bug about datetimepicker, crashed when current input element don't
has a valid date and current date is earlier then min param or later
then max param

可以更新一下这个 PR 吗，我会考虑合并到 dev 分支的

Fix bug about set a default date for the situation that user does not give any default value


Analyzer: implementing package spec proposal (.packages)

Tracking issue for implementing the package spec proposal.
Main issue: https://github.com/dart-lang/dart_enhancement_proposals/issues/5
Proposal: https://github.com/lrhn/dep-pkgspec/blob/master/DEP-pkgspec.md

So, the dartanalyzer works if you pass --packages path/to/.packages.
Next up: automatically find .packages
cc @pq

Just tested a dartanalyzer from 1.12-dev.5.2
Auto-discovery worked!
I also renamed pubspec.lock and pubspec.yaml and auto-discovery still worked!
Passing in --packages to dartanalyzer worked!
What remains for this task?
cc @stereotype441 @bwilkerson

Result from discussion:

@stereotype441 will work to land a patch that makes sdk_ext + .packages work
@sethladd and @devoncarew will turn on appveyor for analyzer_cli

cc @danrubel

Howdy!
@stereotype441 and @pq how do we look here? Are you comfortable with the auto-discovery logic here?

:+1: I think we're good to go for this cut.
As discussed we have some integration tests to back-fill but that's a larger issue.


Fix power_replenishment and realtime_current_in for WD1

homeassistant.exceptions.HomeAssistantError: Entity sensor.649e3170ff79_power_replenishment cannot be added as the entity category is set to config

Have you tested this? I'm not sure if class can be set as string and not as enum.

Yes, only tested on 2024.4.0b7, didn’t see any errors and works fine.
I agree with changing it to enum. I wrote it as a string just because this file does not import any HA constants.

OK, Thanks!

https://github.com/AlexxIT/XiaomiGateway3/releases/tag/v4.0.2


Blockscout verifier

Codecov Report

Merging #319 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   96.84%   96.87%   +0.02%
==========================================
  Files          79       80       +1
  Lines        3111     3140      +29
  Branches       20       20
==========================================
+ Hits         3013     3042      +29
  Misses         95       95
  Partials        3        3

Impacted Files
Coverage Δ

packages/etherlime-lib/src/deployer/deployer.ts
96.00% <100.00%> (ø)

...kages/etherlime/cli-commands/verifier/urlConfig.js
100.00% <100.00%> (ø)

...ckages/etherlime/cli-commands/verifier/verifier.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af9dfa...77337ae. Read the comment docs.


Add Pest 3.0 support

yaz plz fren

@kblais I was wondering that - I held off mainly because Pest3 has no breaking changes.
..and maybe a little laziness, lets be honest 😁


fix typo

from 'futher' to 'further'

I'm not a native English speaker, maybe there is a word 'futher', but I can't find it by Google.
If I'm Wrong, forget about me

CI: https://ci.nodejs.org/job/http-parser-test/14/


range slider?

hi
does it work for the input type range?

Of course.
You can get the slider by two ways. An example is shown below:
{
  "type": "object",
  "properties": {
    "age1": {
      "type": "number",
      "ui": {
        "widgetConfig": {
          "type": "range"
        }
      }
    },
    "age2": {
      "type": "number",
      "ui": {
        "widget": "slider"
      }
    }
  }
}

Note: use  type:range widget config of input widget, you need to add a class for it to display properly

.el-input__inner[type=range] {
    -webkit-appearance: slider-horizontal;
}

I strongly recommend you to use the slider widget


[GH-33] Require events value are not emtpy upon a subscription save

Summary
This PR checks that a required dropdown event has at non-empty array and applies that check for the events dropdown.
Ticket Link
fixes #33

@jfrerich This change does prevent the save. however, no validation message appears when events are left empty. This is a bit confusing because the UI just looks non-responsive.
Ideally this would show the text This field is required. the way the other ones do when the're missing.

@DHaussermann, can you double-check the message is not showing?  When I click Save Subscription with empty events, I see the message appear.

@jfrerich - This is strange. I am not seeing this text. I seem to get a JS error in the browser console.

Redeployed this
Tried refreshing and clearing cache
Tested in browser and desktop
Occurs on add and edit

@jfrerich  any thoughts on why we aren't seeing the same thing here? Should we connect or Zoom to see if we can sort it out?

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   29.48%   29.48%
=======================================
  Files           8        8
  Lines         234      234
=======================================
  Hits           69       69
  Misses        153      153
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05cc4cf...23de01a. Read the comment docs.

@DHaussermann. Thanks for catching edge case.  For future reference, the select modal value is different when removing all events individually vs clearing all of them with the X in the RHS of the select box.
value = [] when clicking large X on RHS
value = null when remove each event individually.
This is ready for another review.


Explain the installation in the operations manual

Explain the installation in the operations manual
We need to explain the process of installation in the operations manual.

[ ] Installation of Rancher (with the terraform script)
[ ] Installation of Monitoring
[ ] Installation of Longhorn
[ ] Installation of JupyterHub

Section added.


Fix hooks docs

Fixes the example code referenced in the documentation for hooks (part 1 & part 2).
Fixes #645.

Wonderful. Thanks!


Confused about colours.

I am a noobie to UraniumUI but love how simple it makes styling.  I have a question, I am confused about colours.  I was expecting the controls to be using the Material colours (purples), but I seem to be getting green colours?
In my MauProgram I have UseUraniumUI and UseUraniumUIMaterial, and in my app.xml I have
'''
<ResourceDictionary.MergedDictionaries>

<material:ColorResource />

<material:StyleResource />
</ResourceDictionary.MergedDictionaries>
'''
And my color.xml in the styles folder is empty, all original colours commented out.
What am I missing to start using the Material styling (styles and colours)?
Thanks

Yeah, we are aware of the restrictive usage of styles. (see #241)
I'm currently working on a feature that makes style customization much easier for v2.4, but unfortunately, the only solution in the current version is replacing entire style files in your project:
https://enisn-projects.io/docs/en/uranium/latest/themes/material/ColorsAndStyles#replacing-resources

ok, understand.  Happy to hear it's not my fault this time. ;-)
Will have a play and override the colours until a solution is released.
Thanks

You can try the new approach after #272
https://enisn-projects.io/docs/en/uranium/2.4/themes/material/ColorsAndStyles#merging-resources
It's much more flexible after v2.4.0-pre.2


Do you use OPUS CODEC for Echo Dot 2nd?

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

It's not an issue, but a question.
What is the expected behavior?

I want to know whether you are using the OPUS codec or not.
What behavior are you observing?

I captured TCP packets from both my device which is based on AVS Device SDK v1.6 and Echo Dot 2nd on the same network environment.
And I analyzed those packets using the Wireshark.
It says that Echo Dot's uploading data size is 3 or 4 times bigger than mine.
Through above, I guess that the Echo Dot 2nd is using OPUS CODEC. (In AIP's source code, you support both LPCM and OPUS.)
Can you confirm it ?
If not, can you explain why this phenomenon occurs.
Provide the steps to reproduce the issue, if applicable:

Start tcpdump on a AP where EchoDot is connected to.
Play simple dialog like "Alexa, Good morning"
After answering, stop tcpdump and analyze its dump.

Tell us about your environment:

What version of the AVS Device SDK are you using?
  <x.y.z>

1.6.0
Tell us what hardware you're using:

[ ] Desktop / Laptop
[ ] Raspberry Pi
[O] Other - tell us more: Generic Linux based, ARMv7 Custom SoC

Tell us about your OS (Type & version):

[O] Linux. Build rootfs using Buildroot. Kernel's version is 3.10.x.
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

@tifler The current supported audio codecs and containers are listed here: https://developer.amazon.com/docs/alexa-voice-service/recommended-media-support.html
Echo Dot does support OPUS, but not sure if that is what is leading to the difference here.

@anu-mathur Thanks for your reply.
I think the link you attached might be audio requirements for playback not capture maybe.
You may refer to the site below for capture audio format.
https://developer.amazon.com/docs/alexa-voice-service/speechrecognizer.html#recognize.
In order to show the actual situation, I brought some pics here.
Here are two captured image from the Wireshark. First one is for Echo Dot 2nd, and last one is for mine.
(They were captured by saying "Alexa, Good morning" once at the same time.)

[Echo Dot's uploading sequence number pattern]
In the case of Echo Dot, it sends a few 1360 bytes packets in the beginning of the session, and then sends 437 bytes packets interactively. Total uploaded size is about 48000 bytes.

[My device's uploading sequence number pattern]
I the case of mine, it sends mostly 1360 bytes packets in the whole session, and the sending style is a kind of burst transmission(not interactive). Total uploaded size is about 210000 bytes.
Is there anyone who can explain the reason why ?
Thanks for your time.

@tifler I see what you are saying. The SDK does not support capture / upload in OPUS yet. And that is why you are seeing the difference. We do have it on our roadmap, and will update on GitHub when we start supporting it.

@anu-mathur Thanks for your reply and clarifications. I hope to see your release note for it soon. Have nice day.


Dev -> Prod

:tada: This PR is included in version 1.28.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ci: initial goreleaser

WIP GoReleaser addition, does not include GitHub Action for release or container builds.

[ ] Container builds need to be determined and added
[ ] Addition of packaging for DEB and RPM will need to be determined (most likely we will need to add completion scripts)

@taigrr Requesting review to see if this looks good for initial releases or if there are further comments and changes that we might want to make.


Admin Router: Prevent reusing tcp sockets by AR's cache code [1.11]

High-level description
This is a backport of https://github.com/dcos/dcos/pull/2511 to 1.11. Check it for more details.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS-21451 debug and fix for SOAK-68

Related PRs:
EE PR:
1.11 PR: https://github.com/dcos/dcos/pull/2511

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label Ready for review

@mesosphere-mergebot override-status  teamcity/dcos/test/azure/arm https://jira.mesosphere.com/browse/DCOS_OSS-1463

@mesosphere-mergebot override-status teamcity/dcos/test/azure/arm https://jira.mesosphere.com/browse/DCOS_OSS-1463

@mesosphere-mergebot override-status teamcity/dcos/test/azure/arm https://jira.mesosphere.com/browse/DCOS_OSS-2115


emulated_hue + Google Home room assignments change after restart

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.35.2
Python release (python3 --version):
3.5.2
Component/platform:
emulated_hue
Description of problem:
Sometimes after restarting the emulated_hue components linked to Google Home will lose their room assignments.
Expected:
Room assignments should preserve across restarts.
Problem-relevant configuration.yaml entries and steps to reproduce:
In my configuration.yaml I have:
emulated_hue:
  type: google_home
  listen_port: 80
  expose_by_default: false

Then in my customize.yaml I have:
    light.living_room_lamp_1:
      emulated_hue: true
    light.living_room_lamp_2:
      emulated_hue: true
    light.bedroom_lamp_1:
      emulated_hue: true
    light.bedroom_lamp_2:
      emulated_hue: true
    light.bedroom_lamp_3:
      emulated_hue: true

Additional info:
I can't tell exactly what causes this to happen. I'm not sure if restarting Home Assistant is enough or if it requires a reboot of the machine it's running on. I also think it sometimes completely messes up the link so that a living room light might actually turn on/off a bedroom light. I'll do some more testing when I can and report back.

https://community.home-assistant.io/t/google-home-and-emulated-hue/7920


Release/v4.1.0

READY FOR REVIEW
Summary

Remove and revert remove conditional on days timer (#390)
DS-448: Upgrade node v20 and npm packages (#389)
Update endowed positions dataset 01-10-24 (#393)

Review By (Date)

Retro

Criticality

High. Rush order.

Review Tasks
Setup tasks and/or behavior to test

Review the functionality that went out and comment on the appropriateness.

@forrestglick

Thank you.


[DISCUSS] Vision for Knative Sources

I'll start tracking here work for Knative sources. Here I'd like to discuss the vision for the future.
Apart from what we've today, I'd like to expand the features offered in the Knative area in two directions.

OOB Sources

This is the continuation of the work done so far. We can currently create sources corresponding to Camel components, but there's only one definition of source called CamelSource that can be customized using different URIs and properties.
This effort will continue with generating automatically specific CamelSource definitions per component, that can be used OOB by people that don't know anything about Camel. E.g. we'll create a CamelKafkaSource definition, a CamelTelegramSource definition, and so on.
Those sources will be translated into a CamelSource under the hood. This means that the current Camel Knative controller will be turned into a "meta-controller".

Camel K Sources

There are many use cases that are not solved by the first kind of sources. Those include sources that may need multiple interactions with enterprise systems and custom transformations before being able to push events to a Knative endpoint.
For those use cases, I'm working on adding support for generic Camel K integrations to be used as CamelSource (https://github.com/nicolaferraro/eventing-sources/blob/camel-k-2/contrib/camel/samples/source_camel_k.yaml).
As long term evolution of this approach, I'd like to see the possibility to create CamelKSource definitions using the kamel CLI.
As we do now kamel run it.groovy to run an integration, we may want to add a similar command like kamel create source it.groovy to generate a Knative-compatible source definition.
A knative source definition can be installed in a cluster and acts as a integration template. Once people fill-in the required properties, the corresponding source can be executed by Camel K.
The long term scenario should be something like:

I've some systems for which I want to provide a connector for Knative
I create the connector to my system using Camel K
I generate the resources that bind Knative to my system using kamel
Users can deploy those resources to Kubernetes and just use them
If my system is interesting for others, I can also publish my connector to a marketplace (it can be OperatorHub)

Only developers need to know Camel K, users of a connector can just use it.

@nicolaferraro can we close this one ?


Collaborative signer: App is crashing when we add a collaborative signer by mock flow.

https://github.com/bithyve/bitcoin-keeper/assets/62699947/6695ba63-8604-4e28-8999-fd7ad26b52f6

disabled mock flow for all soft/assisted keys

Verified this issue on keeper app v 1.1.11(295)


docs: assemble 에 대한 문서화를 진행합니다

Overview

fix #58

한국
영문

PR Checklist

[x] I read and included theses actions below

I have read the Contributing Guide
I have written documents and tests, if needed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.82%. Comparing base (08adfc9) to head (f5ec1fb).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   99.82%   99.82%
=======================================
  Files          29       29
  Lines         584      584
  Branches      141      141
=======================================
  Hits          583      583
  Misses          1        1


Update Go Version to 1.22.4

Bumps Go version across Beam to 1.22.4 as per https://github.com/apache/beam/blob/master/contributor-docs/release-guide.md#update-go-version-used-for-container-builds

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @lostluck
I think this should update everything? Totally down to hold this until after the 2.58.0 cut if you have a plan in mind for updating the Go version later

The go version change that needs more care is updating the minimum version in the module, but this is seperable. Thanks!

Yes I was specifically targeting the infra version, I'll leave determining the minimum Go version for the SDK to you


Ethan: Watch limousinenassar.com

Ethan requests the watch of the watch_keyword limousinenassar\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Jeff Schaller in Charcoal HQ

limousinenassar\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.


Zoom on deck plans

Apple's reviewer seemed to think that it should be possible zoom on the deck plans page.

Turns out I do have code in there to do something here, I guess it's just not working to their satisfaction...

Not really clear what they want.

Oh maybe it's because it doesn't stick to the anchor point.


[No QA] Move reproduction steps above expected/actual results in issue template

Details
The E.cash issue template has been bothering me for a while, the new ordering just makes a lot more sense:

What you did
What you expected to happen
What actually happened

Instead of what we have now, which is more like:

What you expected to happen
What actually happened
Oh yeah, what did you do to make this unexpected thing happen?

Fixed Issues
n/a
Tests
Make a new issue and verify that the changes in the template take effect.
QA Steps
None.
Tested On
n/a – GitHub only.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Verified this worked ✅

🚀 Deployed to staging in version: 1.0.68-5🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production in version: 1.0.73-3🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


feat: add new secrets in Uldum expansion

This PR adds 2 new secrets from Uldum and script to get all secrets and its classes.

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   85.31%   85.31%
=======================================
  Files          19       19
  Lines         320      320
  Branches       52       52
=======================================
  Hits          273      273
  Misses         32       32
  Partials       15       15

Impacted Files
Coverage Δ

src/data/secrets.ts
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf2f4f...3b3d454. Read the comment docs.


Add basic tests for coverage remapping

related to #26 .
This PR adds basic integration test for coverage remapping result processor, tests basic flows from reading config to generating coverage.

Looks like the build failed because of a system specific path separator

Oops, updated PR for path separator issue.

@Igmat I was thinking of bumping the version and publishing these last few changes to npm. Would that be alright?

closes #26

@kulshekhar, yes, sure 😄  I thought about doing same thing!


capistranorb.com 404'ing

The entire site seems to be down

+1

Noted issue for the doc site is here: https://github.com/capistrano/capistrano.github.io/issues/132


Update quiz styles

I updated the version of bootstrap used by the quiz so now it's the same as the rest of the site. I also added the banner image to the top and changed the way quiz feedback looks. You can see the changes by going to the /quizzes tab and clicking on the quizzes.

This looks good, and will be ready to merge once the conflict is fixed.


Spring data rest Expected response != Actual response

Version: 2.7.0
Spring fox seems to be expecting a different returned object for the hateoas resources than what is really returned.
Example:
Expected:
{
  "embedded": [
    {
      "active": true,
      "name": "string",
      "language": "string"
    }
  ],
  "links": [
    {
      "href": "string",
      "rel": "string",
      "templated": true
    }
  ]
}

actual:
{
  "_embedded": {
    "people": [
      {
        "name": "Billy bob",
        "active": true,
        "language": "en"
    ]
  },
  "_links": {
    "self": {
      "href": "http://localhost:9000/api/people{?page,size,sort}",
      "templated": true
    },
    "profile": {
      "href": "http://localhost:9000/api/profile/people"
    }
  },
  "page": {
    "size":<PHONE_NUMBER>,
    "total_elements": 1,
    "total_pages": 1,
    "number": 0
  }
}

Note:

embedded vs _embedded
links vs _links
_embedded as an object containing resources names that are arrays
No paging information, optional maybe?

Let me think about a good solution for this...

Closing of duplicate of #1927


[BUG] 使用客户端后服务器IP会被拉黑

Checks

[x] I confirm that I have searched existing issues and couldn't find a similar bug.
[x] I have read the documentation carefully and it couldn't resolved my problem.

Describe the bug
使用客户端后服务器IP会被拉黑，网页版会显示正在尝试连接，只有Andord的copilot客户端正常。
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
使用syqt客户端，随便问一个问题，比如你好，接着网页版就不能用了，无限重连，大概1-2天后就好了
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS and Version: [e.g. Windows 10] windows 11
SydneyQt Version: [e.g. v2.2.2]2.5.0

Additional context
Add any other context about the problem here.

https://github.com/juzeon/SydneyQt?tab=readme-ov-file#wss-reverse-proxy


Reworked Inputs Example

Hey, I know that this isn't the project convention, but I figured it would be a good idea to rework the scripts (this being the first) to follow the GDScript Style convention. I also added the available signals and hopefully made the outputs a bit clearer.
If it would be better to return to using CONSTANT_CASE, I can rework the script accordingly, but I think making those changes would ultimately be for the better.

Removed Unused Variables
snake_case to name functions and variables
Added load_scene signal to Loading class
Passed function as callable in signal connect function
Added Steam Input Type Dictionary
Assigned variable to the Output label to improve readability
Added input_device_connected, input_device_disconnected, and input_configuration_loaded signal handling

Oh there was also this error in Inputs.gd
Line 36:Cannot assign a value of type Steam.InputType to variable "TYPE" with specified type String.


Native dependencies

Geode Version
v2.0.0
Description
Add mod.json or whatever option for native dependencies. Just adding them as file resources doesnt work because it wont be in the correct directory.
Issues
Maybe have it split per platform?

implemented in acd9bd78840eab114096d738218e918b3080f0d5


Warning when disconnecting

Every time I try to disconnect from the Eyeserver it seems to work but the log gives a warning:
LogTemp: Warning: EyeServer: disconnect may have failed
Full log trace looks like:
LogTemp: Display: EyeServer: starting EyeLinkServer
LogTemp: Display: EyeServer: connecting
LogTemp: Display: EyeServer: starting recording without EDF
LogTemp: Display: EyeServer: stopping recording without EDF
LogTemp: Display: EyeServer: stopping recording without EDF
LogTemp: Display: EyeServer: stopping recording without EDF
LogTemp: Display: EyeServer: stopping recording without EDF
LogTemp: Display: EyeServer: stopping recording without EDF
LogTemp: Display: EyeServer: disconnecting
LogTemp: Warning: EyeServer: disconnect may have failed
LogTemp: Display: EyeServer: stopping EyeLinkServer process

Just noticed I get the same thing for the DaqServer too....

It's due to trying to the DisconnectNamedPipe(hPipe) failing, which seems actually not to be necessary when we're only connecting to the client side of the pipe:
https://docs.microsoft.com/en-us/windows/win32/ipc/named-pipe-client
@joschaschmiedt Can you confirm that it's fine for me to delete this line?

It's due to trying to the DisconnectNamedPipe(hPipe) failing, which seems actually not to be necessary when we're only connecting to the client side of the pipe:
https://docs.microsoft.com/en-us/windows/win32/ipc/named-pipe-client
@joschaschmiedt Can you confirm that it's fine for me to delete this line?

Yep, you're totally right. DisconnectNamedPipe is a function used by the server, not the client. Closing the handle is sufficient.


Add option to download with tags

https://github.com/hydrusnetwork/hydrus offers a way to scrape a given directory for images periodically.
Optionally it can pick up a text file containing the image tags, alongside the image, and import those as well.
ie. if you have an image called myImage.png, you could also put a corresponding text file called myImage.png.txt which holds the image's tags.
I think it would be very convenient to have an option which also stores the tags as described above.

Option's disabled by default.

Didn't even see that one. Thanks for having it implemented ahead of time then.

Thanks!


Update clang-format config file for version 9

Goes together with https://github.com/STEllAR-GROUP/docker_build_env/pull/19. Brace wrapping after case labels can be kept as it is with a new option but I don't see any obvious options to avoid the other formatting changes. They look like something that should've been applied with clang-format-8 anyway.

Thanks!

Question : Other projects have had trouble with clang-format when rules change from one version to another (and are no longer supported or incompatible or have different effects) - do we have confidence that clang format rules and version support are now stable enough that we can upgrade at will, or should we stick with clang-format-x for everyone (until we know better?).

Question : Other projects have had trouble with clang-format when rules change from one version to another (and are no longer supported or incompatible or have different effects) - do we have confidence that clang format rules and version support are now stable enough that we can upgrade at will, or should we stick with clang-format-x for everyone (until we know better?).

I'd say we stick with a version until we explicitly update the version, as in this case. The update from 8 to 9 lead to one type of formatting change that could be covered by updating the config file, and a couple of other minor changes that I considered small enough to warrant an update. For the time being we require clang-format-9 even after clang-format-10 is out.

For the time being (i.e. with this PR) we require clang-format-9 even after clang-format-10 is out.
Correct me if I'm wrong, but doesn't the CI use clang-format-8 currently? (I installed that on my system because the errors I saw on CircleCI had clang-format-8 mentioned somewhere).

For the time being (i.e. with this PR) we require clang-format-9 even after clang-format-10 is out.

Correct me if I'm wrong, but doesn't the CI use clang-format-8 currently? (I installed that on my system because the errors I saw on CircleCI had clang-format-8 mentioned somewhere).

It uses 9 now (I updated the docker image to Ubuntu 19.10 which comes with clang 9 and associated tools, and most importantly a newer CMake). A stricter clang-tidy-9 is why the CircleCI builds are failing at the moment.

I forgot to change clang-format-8 in the CircleCI config file... I've just pushed that. If CircleCI agrees with the formatting changes I'll merge this.


chore: enable coi on desktop

Fixes https://github.com/microsoft/vscode/issues/186614

what does this actually improve in VS Code

It allows the use of shared array buffers. There is already a use case for webviews https://github.com/microsoft/vscode/issues/116715 and maybe the editor could benefit as well if needed. /cc @jrieken if there are other scenarios I missed.

how can we make sure the new argument is not causing regressions

The argument only has impact on the initial speculative render process created to warm up render process creation, before this change the speculative process was being discarded because it was created too early and the intiial process lock null does not satisfy the new origin that will be committed into it after navigating to the workbench origin vscode-file://vscode-app. With this change we are slightly delaying the speculative process creation until after the network request has been sent and trace results show that we no longer incur the cost of discarding the render process when coi is enabled. Basically this tries to align the process timeline in both COI enabled and disabled scenarios.
We can confirm any regression from the startup metrics https://github.com/microsoft/vscode/issues/187030

should we give this a month of insiders coverage or is it crucial to have now

I don't feel it is risky that it needs another month of insiders. It would be good to try this in endgame week and any regression in startup we can revert this change and re-evaluate.

@deepak1556 are we actually relying on the speculative renderer process or benefiting from it today?


Ignore differences in CSV .status.conditions in unit tests.

This should address the cause of a common flake.

/lgtm

/retest

/retest


Strategy Room Ship List: Bring back totals

ah, i kinda missed the info for ships total fp, tp, level, hp and etc. since i keep comparing it to my friend for fun - originally from #253

How about the average for all ships?

Yes, I also think average of all ships makes more sense than just adding up together.

Why not both?

I have no objection to have both but it is just the problem of where to put the stats and the toggle button.


RelationalDiagnostics: Naming inconsistencies

I'm working on a DiagnosticListener approach in #7939 and noticed some inconsistencies in RelationalDiagnostics.cs:

ConnectionError is incorrect, nameof(ConnectionClosed) (repeated)should benameof(ConnectionError)`. I've submitted PR #8000 to correct this.

public const string ConnectionClosed = NamePrefix + nameof(ConnectionClosed);
public const string ConnectionError = NamePrefix + nameof(ConnectionClosed);

"TransactionRolledBack" isn't title cased:

public const string TransactionRolledback = NamePrefix + nameof(TransactionRolledback);

^ this should have a capital B to be consistent with all other events. in the class, e.g.
public const string TransactionRolledBack = NamePrefix + nameof(TransactionRolledBack);

1 is an obvious bug (unless I'm nuts) and causing active harm re-firing the closed event on errors, not just closes. While there's a workaround of using the exception arg on the close listener and seeing if it's null, this is both a) not ensure to be reliable, and b) just plain wrong.
2 is minor, but a breaking change to listeners all the same. At the same time, I can't find anyone even using this yet (or someone would have noticed these things?) - should we fix it properly now?
See https://github.com/aspnet/EntityFramework/issues/7939#issuecomment-288206394 for additional concerns I have about the stability of these APIs. Since everyone is (as far as I know) copying these strings because they are internally restricted, there's no scenario fixed by a simple recompile. Issues like this would be better served in the event names were exposed and compilationally reliable.

@NickCraver Thanks for the PR for 1. We would also take a PR for 2, since we can take reasonable breaking changes in the 2.0 release. Would you be willing to send a PR?

I think this has all been taken care of with @ajcvickers rework of this area.


Add tests for submit misbehavior

https://github.com/cosmos/ibc/blob/master/spec/client/ics-007-tendermint-client/README.md#misbehaviour
Test that the light clients are frozen when relayers submit misbehavior, for a situation such as if two headers could be considered valid for the same height

Test exists in Relayer (https://github.com/cosmos/relayer/pull/1121), closing ticket.


Errors with GPose?

The new toggle to make profiles only apply to yourself doesn't carry over into gpose.  I turned this setting on because it was being applied to my retainer in my yard, but entering gpose makes my scaling turn off.  The only way it carries over is if I turn the isolation toggle off so I have my scaling but so does my retainer.

#159


Rotation of layout

General information

SDK/Library version:
Android Version and Device:

Issue description

When device rotates, overlay layout does not.

Same thing happens to me. After orientation change, the overlay is gone.


Add maven plugin to project

Here I've been trying to add this plugin to a project, but it didn't seem to work, what repository definition is missing, or is there something in the configurations that I am missing. The PR is here https://github.com/arrow-kt/Arrow-Maven-Template/pull/17
There is a similar setup here using Gradle, which works fine
Any feedback or help is welcome 🙏🏾

Hi!
This project is hosted on GitHub packages: https://github.com/Dyescape/kotlin-maven-symbol-processing/packages/1096299
There is a page from GitHub about how to set up packages here, however the system is pretty terrible, as it does not allow anonymous access, so every user would have to configure an access token in their settings.xml.
There is an entire thread about very many people wanting anonymous access to open source packages here, sadly I have given up hope this will ever happen: https://github.community/t/download-from-github-package-registry-without-authentication/14407/147
Given that this packages now seems to be used by some people we'll look into just publishing it to maven central (or perhaps a public JFrog repo) later today, I'll update you later!

Thanks @fxshlein :D

@i-walker The latest release is now available in maven-central! 🎉
Sites like mvnrepository.com or search.maven.org will apparently take up to four hours to also reflect this, but maven should already be able to resolve the artifact:
https://repo1.maven.org/maven2/com/dyescape/kotlin-maven-symbol-processing/1.2

awesome Thanks ☺🙌🏾🙌🏾
Good to be closed now

No problem! Glad to help 🙂


Update icons

tACK https://github.com/Groestlcoin/grs-rpc-explorer/pull/1/commits/ce64ea53108c02c68fc72d1ff8c5757c49cb49a7


VM Create and Launch

This PR adds basic VM support.
You can download a VM image and create a VM instance on a dir pool by doing:
lxc init ubuntu:18.04 c1 --vm -s mydirpool -p vmdefault

Or launch an empty one for PXE boot:
lxc init c1 --vm -s mydirpool -p vmdefault --empty

The vmdefault profile needs to have cloud init config to create a login user and password.

Testsuite passed

Testsuite passed

Testsuite passed

@stgraber this is ready for review now, features that are working:

VM create from image
VM start
VM console (using screen, not yet re-done that part)
Config driver generation and mounting (including adding lxd-agent if presence on the host system)
VM delete
VM update (needs more validation but you can edit config, profiles etc)
NIC bridge support

@stgraber I also have a question around disk size and whether we need to re-size the filesystem from the unpacked image to use the space allocated in the sparse image?

Testsuite passed

Testsuite passed

Testsuite passed

Testsuite passed

Testsuite passed

Testsuite passed

Testsuite passed


Cosmetic refactor on merge join supported types

Summary: Cosmetic refactor on merge join supported types
Differential Revision: D59252668

Cc: @JkSelf @PHILO-HE


Periodically perform readiness checks for issuers

Describe the bug:
This is a follow-up for https://github.com/cert-manager/cert-manager/issues/5154
This PR adds a "readiness" check for Venafi Issuers https://github.com/cert-manager/cert-manager/pull/5185
Currently this will only happen when issuers related secrets are created and edited, and the issuer-controller reconciles.
We want to perform this check periodically, and similar checks for other issuer types.
More context for other issuers:

https://kubernetes.slack.com/archives/CDEQJ0Q8M/p1653307652090249

Expected behaviour:
Issuers should periodically perform readiness/health checks and update the Ready status accordingly.
Example scenarios are network problems (like connecting to TPP or Vault) and access token expiration.
/kind bug

The linked comment on Slack assumes that the check will be performed (also) in one of the certificates controller, probably before creating a CertificateRequest, not just issuers as else there could be a race condition between the certificates controllers triggering issuance and failing because of a temporary error and the issuers controller setting the issuer's ready condition to false


Update labels to match gorkem/app-labels recommendations

This updates labels to match  https://github.com/gorkem/app-labels/blob/master/labels-annotation-for-openshift.adoc and also to match how those labels are used in OpenShift devconsole.
This is to ensure that components created by odo are correctly displayed in devconsole topology view.
This breaks compatibility with older odo versions!
Release notes will need to include a warning about this.
Components that are already pushed to the cluster using older odo versions will not work. User needs to delete a component from the cluster and push it again.
fixes #599

/retest

The current  view in the developer console.

Not sure why backend has the OpenShift logo. It is Java component the DeploymentConfig has the following labels:
  labels:
    app: wildwest
    app.kubernetes.io/instance: backend
    app.kubernetes.io/name: java
    app.kubernetes.io/part-of: wildwest
    app.openshift.io/runtime-version: "8"

@sbose78  do you know why might that be?

@kadel I tried doing an Import from Git with the Java s2i image and I see the same. So we can ignore that.

ping @cdrage

looks good to me.
/lgtm