App crash on calling getAllInboxMessages()

Describe the bug
App crashes observed when calling getAllInboxMessages()
Stack Trace

Crashed: com.apple.root.background-qos
0  libobjc.A.dylib                0x1bb049474 objc_msgSend + 20
1  CoreData                       0x1acb5ebfc _PFFaultHandlerFulfillFault + 3016
2  CoreData                       0x1acb5d69c _PFFaultHandlerLookupRow + 856
3  CoreData                       0x1acb5f3d4 _PF_FulfillDeferredFault + 248
4  CoreData                       0x1acb77c44 _pvfk_header + 108
5  CoreData                       0x1acb74934 _sharedIMPL_pvfk_core + 28
6  CoreData                       0x1acb69374 _PF_Handler_Public_GetProperty + 224
7  Foundation                     0x1a7e88f0c -[NSFunctionExpression expressionValueWithObject:context:] + 680
8  Foundation                     0x1a7e88b88 -[NSComparisonPredicate evaluateWithObject:substitutionVariables:] + 212
9  Foundation                     0x1a7f8d9cc filterObjectsUsingPredicate + 268
10 Foundation                     0x1a7ecb010 -[NSOrderedSet(NSPredicateSupport) filteredOrderedSetUsingPredicate:] + 212
11 APP                        0x100b139e0 -[CTInboxController unreadMessages] + 160 (CTInboxController.m:160)
12 APP                        0x100ad49ec -[CleverTap getUnreadInboxMessages] + 4111 (CleverTap.m:4111)
13 APP                        0x100db6ec8 CleverTapInbox.getAllInboxMessages() +<PHONE_NUMBER>
14 APP                        0x100db6194 closure #1 in CleverTapDatasource.getUnreadMessageCount() + 43 (CleverTapDataSource.swift:43)
15 APP                        0x100db63cc partial apply for thunk for @escaping @callee_guaranteed () -> (@unowned Int, @error @owned Error) +<PHONE_NUMBER> (:4318176204)
16 APP                        0x101908804 closure #1 in OS_dispatch_queue.async(:group:qos:flags:execute:) + 167 (Promise.swift:167)
17 APP                        0x1004cb088 thunk for @escaping @callee_guaranteed () -> () +<PHONE_NUMBER> (:4308824200)
18 libdispatch.dylib              0x1a68b275c _dispatch_block_async_invoke2 + 104
19 libdispatch.dylib              0x1a6903280 _dispatch_client_callout + 16
20 libdispatch.dylib              0x1a68b5074 _dispatch_root_queue_drain + 688
21 libdispatch.dylib              0x1a68b5704 _dispatch_worker_thread2 + 124
22 libsystem_pthread.dylib        0x1ef4ed568 _pthread_wqthread + 212
23 libsystem_pthread.dylib        0x1ef4f0874 start_wqthread + 8

Currently we haven't been able to reproduce this, but we are observing many crash reports on firebase for the same.
As of now this issue has 181 crash events affecting 180 users

Thanks for filing this issue with the details and stack trace. We are looking into it and tracking it internally.

We have given a rigorous try to this and unable to replicate it. My hypothesis is that the crash is happening because of some race condition, modifying inbox data on multiple threads.
Given the specifics, we've added a fix in our development branch to mitigate the crashes. The release with the change is expected to go out in a day or two.

we updated to 3.9.4 still facing the issue

Latest stack trace
Crashed: com.apple.root.background-qos
0  libobjc.A.dylib                0x1b76ae154 objc_msgSend + 20
1  Foundation                     0x1a4b72774 -[NSFunctionExpression expressionValueWithObject:context:] + 676
2  Foundation                     0x1a4b723f4 -[NSComparisonPredicate evaluateWithObject:substitutionVariables:] + 212
3  Foundation                     0x1a4c77300 filterObjectsUsingPredicate + 260
4  Foundation                     0x1a4bb48a8 -[NSOrderedSet(NSPredicateSupport) filteredOrderedSetUsingPredicate:] + 204
5  App                        0x104c2ef5c -[CTInboxController unreadMessages] + 161 (CTInboxController.m:161)
6  App                        0x104bff1fc -[CleverTap getUnreadInboxMessages] + 4020 (CleverTap.m:4020)
7  App                        0x104ec18d0 CleverTapInbox.getAllInboxMessages() +<PHONE_NUMBER>
8  App                        0x104ec0ba8 closure #1 in CleverTapDatasource.getUnreadMessageCount() + 43 (CleverTapDataSource.swift:43)
9  App                        0x104ec0de0 partial apply for thunk for @escaping @callee_guaranteed () -> (@unowned Int, @error @owned Error) +<PHONE_NUMBER> (:4345908704)
10 App                        0x105a35158 closure #1 in OS_dispatch_queue.async(:group:qos:flags:execute:) + 167 (Promise.swift:167)
11 App                        0x1045ba7fc thunk for @escaping @callee_guaranteed () -> () +<PHONE_NUMBER> (:4336445436)
12 libdispatch.dylib              0x1a3592b34 _dispatch_block_async_invoke2 + 104
13 libdispatch.dylib              0x1a35b0298 _dispatch_client_callout + 16
14 libdispatch.dylib              0x1a35953f0 _dispatch_root_queue_drain + 644
15 libdispatch.dylib              0x1a3595a5c _dispatch_worker_thread2 + 108
16 libsystem_pthread.dylib        0x1ebdc5580 _pthread_wqthread + 212
17 libsystem_pthread.dylib        0x1ebdc886c start_wqthread + 8

Sorry about that, I will have another look at this in order to mitigate it in the coming release.


Add #[allow(unreachable_code)] to drop(x) in tests/run-pass/generator.rs

The test starts to trigger this warning (I guess it's caused by rust-lang/rust#85556). The warning seems correct, but the unreachable code in that test also seems reasonable.

Makes sense, thanks!
@bors r+

:pushpin: Commit 33a67c6b33e91b5de01b9421a59a2f92233643a0 has been approved by RalfJung

:hourglass: Testing commit 33a67c6b33e91b5de01b9421a59a2f92233643a0 with merge 08ca5606ab0ad1c0502ab4c001964d1ba46c1baa...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 08ca5606ab0ad1c0502ab4c001964d1ba46c1baa to master...


Chart is disappearing when the Angular Router is called

#Hi the below canvas is added in a separate html file (dashboard.html)

         <canvas id="chart-area" />

dashboard.html is added to the main html (home.html) page by using the ng-view as below
`

`
The chart is disappearing when the below hyperlink is clicked from the main page (home.html)
Expand Menu
please let me know how could i resolve this issue ?
Regards,
Vikas P

@vksonpdl i think you'll get a better answer to this on stack overflow

@etimberg  I has a search in StackOverFLow but my bad i could not get the resolution. DO you have any URL for this ?


Plugin crashes and can no longer find dependencies

Just started using the plugin for mode than a single-file project. I have a very simple project with an .fsproj file. The only dependency is Avalonia.
Around every 5 minutes the plugin crashes and a lot of errors are shown. In particular it can suddenly no longer find the dependencies.
Currently I cannot say what triggers the problem. It seems to happen when I do two things at the same time, e.g. safe a file and hover my mouse over an identifier to see the type. Please let me know if I can somehow collect more information.
Here is the log (with shortened file paths):
[15:48:38 INFO ] Logging to output at level INFO. If you want detailed messages, try level DEBUG.
[15:48:40 INFO ] listening notification on /notify started
[15:48:40 INFO ] listening notification on /notifyWorkspace started
[15:48:40 ERROR] Cannot execute unusedDeclarations, File '.../Blub.fs' not parsed
[15:48:40 ERROR] Cannot execute lint, File '.../Blub.fs' not parsed
[15:48:40 ERROR] Cannot execute unusedOpens, File '.../Blub.fs' not parsed
[15:48:40 ERROR] Cannot execute simplifiedNames, File '.../Blub.fs' not parsed
[15:54:44 ERROR] Cannot execute methods, Could not find ident at this location
[15:56:33 ERROR] Cannot execute finddeclaration, Could not find ident at this location
[15:57:10 ERROR] Cannot execute finddeclaration, Could not find declaration
[15:57:10 ERROR] Cannot execute finddeclaration, Could not find declaration
[15:59:37 ERROR] Cannot execute helptext, No help text available for symbol 'member'
[15:59:39 ERROR] RES (600) <- {completion} ERROR in 46 ms: {"{}"}, Data=undefined
[15:59:55 ERROR] Cannot execute finddeclaration, Could not find declaration
[16:01:31 ERROR] Cannot execute namespaces, Position is out of range
[16:01:31 ERROR] Cannot execute namespaces, Position is out of range
[16:01:32 ERROR] Cannot execute namespaces, Position is out of range
[16:01:32 ERROR] Cannot execute namespaces, Position is out of range
[16:01:33 ERROR] RES (928) <- {completion} ERROR in 17 ms: {"{}"}, Data=undefined
[16:01:37 ERROR] Cannot execute namespaces, Position is out of range
[16:01:37 ERROR] Cannot execute namespaces, Position is out of range
[16:01:38 ERROR] Cannot execute namespaces, Position is out of range
[16:01:38 ERROR] Cannot execute namespaces, Position is out of range
[16:01:39 ERROR] Cannot execute namespaces, Position is out of range
[16:01:40 ERROR] Cannot execute namespaces, Position is out of range
[16:01:40 ERROR] Cannot execute namespaces, Position is out of range
[16:01:41 ERROR] Cannot execute namespaces, Position is out of range
[16:01:41 ERROR] Cannot execute namespaces, Position is out of range
[16:01:42 ERROR] Cannot execute namespaces, Position is out of range
[16:01:42 ERROR] Cannot execute namespaces, Position is out of range
[16:02:35 ERROR] RES (1222) <- {finddeclaration} ERROR in 1049 ms: {stack: Error: socket hang up
	at createHangUpError (_http_client.js:331:15)
	at Socket.socketOnEnd (_http_client.js:423:23)
	at emitNone (events.js:111:20)
	at Socket.emit (events.js:208:7)
	at endReadableNT (_stream_readable.js:1056:12)
	at _combinedTickCallback (internal/process/next_tick.js:138:11)
	at process._tickCallback (internal/process/next_tick.js:180:9), message: socket hang up, code: ECONNRESET, config: [object Object], request: [object Object], response: undefined} Data=undefined
[16:02:35 INFO ] FSAC killed by outside event, restarting
[16:02:35 ERROR] RES (1224) <- {finddeclaration} ERROR in 2 ms: {stack: Error: connect ECONNREFUSED <IP_ADDRESS>:8844
	at Object._errnoException (util.js:1024:11)
	at _exceptionWithHostPort (util.js:1046:20)
	at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1182:14), message: connect ECONNREFUSED <IP_ADDRESS>:8844, code: ECONNREFUSED, errno: ECONNREFUSED, syscall: connect, address: <IP_ADDRESS>, port: 8844, config: [object Object], request: [object Object], response: undefined} Data=undefined
[16:02:36 ERROR] RES (1225) <- {parse} ERROR in 1 ms: {stack: Error: connect ECONNREFUSED <IP_ADDRESS>:8844
	at Object._errnoException (util.js:1024:11)
	at _exceptionWithHostPort (util.js:1046:20)
	at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1182:14), message: connect ECONNREFUSED <IP_ADDRESS>:8844, code: ECONNREFUSED, errno: ECONNREFUSED, syscall: connect, address: <IP_ADDRESS>, port: 8844, config: [object Object], request: [object Object], response: undefined} Data=undefined
[16:02:36 ERROR] RES (1226) <- {parse} ERROR in 2 ms: {stack: Error: connect ECONNREFUSED <IP_ADDRESS>:8844
	at Object._errnoException (util.js:1024:11)
	at _exceptionWithHostPort (util.js:1046:20)
	at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1182:14), message: connect ECONNREFUSED <IP_ADDRESS>:8844, code: ECONNREFUSED, errno: ECONNREFUSED, syscall: connect, address: <IP_ADDRESS>, port: 8844, config: [object Object], request: [object Object], response: undefined} Data=undefined
[16:02:36 ERROR] Cannot execute finddeclaration, File '.../Blub.fs' not parsed
[16:02:36 ERROR] Cannot execute signature, File '.../Blub.fs' not parsed
[16:02:36 ERROR] Cannot execute recordStubGenerator, File '.../Blub.fs' not parsed
[16:02:36 ERROR] Cannot execute finddeclaration, File '.../Blub.fs' not parsed
[16:02:37 ERROR] Cannot execute tooltip, File '.../Blub.fs' not parsed
[16:02:37 ERROR] Cannot execute finddeclaration, File '.../Blub.fs' not parsed
[16:02:37 ERROR] Cannot execute finddeclaration, File '.../Blub.fs' not parsed
[16:02:37 ERROR] Cannot execute signature, File '.../Blub.fs' not parsed
[16:02:37 ERROR] Cannot execute recordStubGenerator, File '.../Blub.fs' not parsed
[16:02:38 ERROR] Cannot execute tooltip, File '.../Blub.fs' not parsed
[16:02:40 ERROR] Cannot execute finddeclaration, File '.../Blub.fs' not parsed
[16:02:40 ERROR] Cannot execute finddeclaration, File '.../Blub.fs' not parsed
[16:02:40 ERROR] Cannot execute tooltip, File '.../Blub.fs' not parsed
[16:02:42 ERROR] Cannot execute finddeclaration, File '.../Blub.fs' not parsed
[16:02:42 ERROR] Cannot execute finddeclaration, File '.../Blub.fs' not parsed
[16:02:43 ERROR] Cannot execute symboluse, File '.../Blub.fs' not parsed
[16:02:43 ERROR] Cannot execute finddeclaration, File '.../Blub.fs' not parsed
[16:02:43 ERROR] Cannot execute finddeclaration, File '.../Blub.fs' not parsed
[16:02:43 ERROR] Cannot execute signature, File '.../Blub.fs' not parsed
[16:02:43 ERROR] Cannot execute recordStubGenerator, File '.../Blub.fs' not parsed
[16:02:45 ERROR] Cannot execute tooltip, File '.../Blub.fs' not parsed
[16:02:46 ERROR] Cannot execute tooltip, File '.../Blub.fs' not parsed
[16:02:48 ERROR] Cannot execute symboluse, File '.../Blub.fs' not parsed
[16:02:49 ERROR] Cannot execute signature, File '.../Blub.fs' not parsed
[16:02:49 ERROR] Cannot execute recordStubGenerator, File '.../Blub.fs' not parsed

Versions: Ionide-fsharp version 3.25.3, Ubuntu 16.04, dotnet 2.1.401, mono <IP_ADDRESS>, fsharpc 4.1.

I have now enabled logging in the user settings and with logging it seems to happen less often. Here is an extended log: plugin.log
Errors start in line 281.

I tried clearing the cache and removing the obj folder, but the bug still occurs. Is there anything I can do to collect more information so that this problem can be fixed?

This time it wrote something to the F# Language Service (server) log, which might be helpful:
ionide.log

This is probably outdated due to Ionide 4.0 changes


golang-http-80-xieweicarl2018 to v0.0.1

Promote golang-http-80-xieweicarl2018 to version v0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @xieweicarl2018. Thanks for your PR.
I'm waiting for a q13117god member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test this

@xieweicarl2018: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

/test this

@xieweicarl2018: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@xieweicarl2018: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

/ok-to-test

/approve


upstream bug in python-frontmatter 0.4 is crashing new installs

we will need to adjust our code to handle that change.
cc @eyeseast

What's the error you're getting?
Sent from my iPhone

On Mar 7, 2017, at 9:51 PM, Ben Welsh<EMAIL_ADDRESS>wrote:
we will need to adjust our code to handle that change.
cc @eyeseast
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

  File "manage.py", line 8, in <module>
    execute_from_command_line(sys.argv)
  File "/Users/ryanbmarx/ctbigbuilder/lib/python2.7/site-packages/django/core/management/__init__.py", line 367, in execute_from_command_line
    utility.execute()
  File "/Users/ryanbmarx/ctbigbuilder/lib/python2.7/site-packages/django/core/management/__init__.py", line 359, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/Users/ryanbmarx/ctbigbuilder/lib/python2.7/site-packages/django/core/management/base.py", line 294, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/Users/ryanbmarx/ctbigbuilder/lib/python2.7/site-packages/django/core/management/base.py", line 345, in execute
    output = self.handle(*args, **options)
  File "/Users/ryanbmarx/ctbigbuilder/lib/python2.7/site-packages/bigbuild/management/commands/createpage.py", line 70, in handle
    self.create_page_directory(page)
  File "/Users/ryanbmarx/ctbigbuilder/repo/config/toolbox/management/commands/createpage.py", line 51, in create_page_directory
    dark=self.dark,
  File "/Users/ryanbmarx/ctbigbuilder/lib/python2.7/site-packages/bigbuild/models/pages.py", line 70, in create_directory
    self.write_frontmatter()
  File "/Users/ryanbmarx/ctbigbuilder/lib/python2.7/site-packages/bigbuild/models/pages.py", line 95, in write_frontmatter
    frontmatter.dump(self, path or self.frontmatter_path)
  File "/Users/ryanbmarx/ctbigbuilder/lib/python2.7/site-packages/frontmatter/__init__.py", line 153, in dump
    content = dumps(post, handler, **kwargs).encode(encoding)
  File "/Users/ryanbmarx/ctbigbuilder/lib/python2.7/site-packages/frontmatter/__init__.py", line 183, in dumps
    handler = post.handler or YAMLHandler()
AttributeError: 'Page' object has no attribute 'handler'```

I'm guessing it's post.handler.

Thought that might be the case. I can push a fix that'll make it smoother.
The other you can and probably should do is explicitly set a handler, whether it's YAMLHandler or something else.

Okie dokie. No problem. I've been thinking of rewriting my frontmatter system inside a Django serializer so maybe this is the time. FWIW, the bug does signal you may have lost a chunk of backward compatibility with your upgrade. Might be worth flipping up the big digit on the next version number.

Yeah, was wondering about if it's time for a bigger version.
Here's a PR that fixes the issue: https://github.com/eyeseast/python-frontmatter/pull/34

Thank you.

New release pushed and published as v0.4.1. This should actually preserve backwards compatibility, at least as far as what I outlined in the original readme. Let me know if you run into other issues.


enable wide-mode and horizontal scrolling for tables

Sometimes it's difficult to fit all data into a 900px-wide table without awkward line breaks. Wider monitors can easily handle the display of a wider table.
Regular screens could be accommodated with a horizontal scrollbar, although it is acknowledged that the UX could suffer in that case.

thanks!


users files are in the root directory (in the wrong folder).

rearrange users files
move from root path to -> profiles folder path

can i take this issue? (my first contribution)


not support uint/uint64?

not support uint/uint64?

Thanks for your issue. I have added unsigned integer data type support.


[HUDI-391] Rename module name from hudi-bench to hudi-test-suite

What is the purpose of the pull request
Rename module name from hudi-bench to hudi-test-suite
Brief change log

Rename module name from hudi-bench to hudi-test-suite

Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@n3nash Can you review this PR?

LGTM to me, couple of things to do before merging :

Can you do a search of hudi-bench string in the module and make sure no comments are lingering that have this.
The diff somehow doesn't show the module name change, I'm guessing that's just github and you've already made that ?

@n3nash

LGTM to me, couple of things to do before merging :

Can you do a search of hudi-bench string in the module and make sure no comments are lingering that have this.

Yes, I have searched hudi-bench keyword and replaced all of them, there is nothing left.

The diff somehow doesn't show the module name change, I'm guessing that's just github and you've already made that ?

Yes. I have renamed all of them, after merging, you can not find anything if you search bench keyword.


fix error message -> buildUponDefaultConfig instead of buildOnDefaultConfig

when migrating detekt version, I came thru this error and the field name is likely wrong.

done, just a quick heads up, detektFormat ran but didn't format anything, so I did manually.


[x86] Test instruction is not handled correctly

A test instruction is not handled correctly when both operands are the same. For example,
test eax, eax
jle short 0xABCDEF

Should be checking if eax > 0, but instead it outputs as eax > eax.

Fixed by #64


Since version 1.0.0 I can't get params from JQuery requests

Hi,
My code works fine with v0.3.0 and JQuery v2.2.3 but since last falcon update I can't get params from POST/PUT/PATCH/DELETE requests.
Here is my Javascript code:
$.ajax({
        async:true,
        dataType:'json',
        type:method,
        url:'api/' + resource,
        data:data,
});

And my Falcon code:
def process_request(self, req, resp):
  print req.query_string
  print req.params

Both print return empty strings with any request except if method is GET.
What I'm doing wrong?
Thanks in advance!

Hi @jf86. This may be a consequence of a breaking change in 1.0.0 where Falcon will no longer automatically parse, by default, requests that have the content type “application/x-www-form-urlencoded”. There is an option to re-enable it:
app = falcon.API()
app.req_options.auto_parse_form_urlencoded = True

See also: https://falcon.readthedocs.io/en/stable/changes/1.0.0.html#breaking-changes
If this is indeed the problem, I'll see if we can document this in the FAQ. Just let me know!

It works now! Thanks


Update README.md

Explains how to get from the SQL Server SKU name to the SqlServerVersion enum.
Resolves #86

Replaced by #89


[ts-sdk] Normalize Sui Address in more places

Description
Describe the changes or additions included in this PR.
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Current dependencies on/for this PR:

main

PR #9715   👈

This comment was auto-generated by Graphite.


Updating documentation for readability and adding a Spanish translation to the README.md file

This pull request includes the following three commits in an attempt to slightly improve the documentation:

Updated README.md for better readability
Added Spanish translation of README.md to make the project more accessible
Minor proofreading to BuildInstructions.md to fix small errors

Accidentally had a mishap, oops. It should be fixed by now


fix: pgsql驱动打开连接时并没有使用Namespace配置切换schema

Codecov Report
Patch coverage has no change and project coverage change: -0.02 :warning:

Comparison is base (15d88c2) 79.99% compared to head (d428bee) 79.97%.

:exclamation: Current head d428bee differs from pull request most recent head 13e0513. Consider uploading reports for the commit 13e0513 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2481      +/-   ##
==========================================
- Coverage   79.99%   79.97%   -0.02%
==========================================
  Files         599      599
  Lines       49786    49789       +3
==========================================
- Hits        39824    39821       -3
- Misses       8007     8010       +3
- Partials     1955     1958       +3

Flag
Coverage Δ

go-1.15-386
80.03% <0.00%> (-0.01%)
:arrow_down:

go-1.15-amd64
79.99% <0.00%> (-0.02%)
:arrow_down:

go-1.16-386
79.99% <0.00%> (-0.03%)
:arrow_down:

go-1.16-amd64
80.02% <0.00%> (+<0.01%)
:arrow_up:

go-1.17-386
80.04% <0.00%> (+0.04%)
:arrow_up:

go-1.17-amd64
79.99% <0.00%> (-0.01%)
:arrow_down:

go-1.18-386
79.93% <0.00%> (-0.01%)
:arrow_down:

go-1.18-amd64
79.91% <0.00%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

contrib/drivers/pgsql/pgsql.go
62.66% <0.00%> (-0.64%)
:arrow_down:

os/gfsnotify/gfsnotify_watcher_loop.go
83.19% <0.00%> (-2.53%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


using gulp-nodemon instead of nodemon binary

Thank you! Looks really good :) I left one quick question and it's ready to merge.

https://github.com/JacksonGariety/gulp-nodemon/issues number of issues is scary

@steida And what about using nodemon via require? Seems working for me.
gulp.task('server-nodemon', function(){
  require('nodemon')('./src/server')
});

What's wrong with current approach? Feel free to reopen.

It doesn't work on Windows.

Awesome comment. Now all I have to do is enable my time machine, and travel to your place and check what console shown to you.
What doesn't work? I tested it under Windows 10, Node4, npm2, clean checkout.

Check last commit please.

I would like to note that this issue has been created 24 days ago and @ViliamKopecky comment was referring to its original causes (it was you who said the problem was nodemon path) :)
Anyway, since your commit fixed that with different workaround, this issue is no longer present.

@steida Alright, this works :) But may I ask, why do you prefer this way - requiring the module seems clearer to me...

Maybe it is, but I prefer own process, because gulp-nodemon has a lot of issues. And, gulp wrappers are hit or miss, aka brittle as hell.

but he required nodemon module directly, not via gulp-nodemon. https://github.com/este/este/pull/502#issuecomment-148046323

But the last proposal doesn't use a gulp wrapper. It's just nodemon used via require with the same arguments as the child process.
shell.task(path.normalize('node_modules/.bin/nodemon src/server'));

// vs

require('nodemon')('src/server');

Hmm, sorry I overlooked it. Do you use it regularly? It's safe?


specifying a custom device crashes the merge

Specifying a device (e.g. .\.venv\Scripts\python.exe .\SD_rebasin_merge.py --model_a .\standard_models\mix_in_1 --model_b .\standard_models\mix_in_2 --output .\standard_models\mixed --device cuda ) crashes the script:
Traceback (most recent call last):
  File ".\SD_rebasin_merge.py", line 23, in <module>
    final_permutation = weight_matching(permutation_spec, state_a, state_b)
  File ".\weight_matching.py", line 796, in weight_matching
    w_b = get_permuted_param(ps, perm, wk, params_b, except_axis=axis)
  File ".\weight_matching.py", line 773, in get_permuted_param
    w = torch.index_select(w, axis, perm[p].int())
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu! (when checking argument for argument index in method wrapper__index_select)

I should note that I can't fully test this, as I am far from having enough VRAM to do the full merge on GPU. When running on CPU, it seems to peak at over 60GB of memory.


Desktop UI Flow - Java Applications

As Java Applications are  unsupported  preview UI Flow for Desktops in  Power Automate , does this applies only to preview state or even in GA also ?
As we currently looking  PowerAutomate with Desktop UI as RPA solution ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d024a2c8-e958-e643-93f5-95cf8637fb2c
Version Independent ID: 9f9028ac-88ef-bf06-0dd8-77729edd84e8
Content: Learn to create desktop UI flows - Power Automate
Content Source: articles/ui-flows/create-desktop.md
Service: flow
GitHub Login: @MSFTMan
Microsoft Alias: DeonHe

“Thanks for your feedback. For product-related feedback/questions, visit https://powerusers.microsoft.com/t5/Power-Automate-Ideas/idb-p/MPAIdeas.
Closing this issue.


wrap filed rev of BulkEntityResult using Option

Some normal results of API _bulk_docs can not be deserialization to BulkEntityResult
Description
some items in the return jsArray of _bulk_docs may not contain filed rev, this lead to a spray json error
Related issue and scope

[x] I opened an issue to propose and discuss this change (#3511)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[x] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[x] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

@jiangpengcheng can you elaborate on when the result would not contain a rev in normal operation?

Per the issue you opened (thanks for that!): Shall we properly deserialize this as an "error" iff the rev is missing and print the details? It's an error after all.

@markusthoemmes
if there is an error field in some documents, these documents will be converted to either DocumentConflictException or PutException(both inherited from ArtifactStoreException), while normal documents will be converted to DocInfo:
    //line 143-163 on whisk/core/database/CouchDbRestStore.scala
    val f = client.putDocs(ds).map {
      _ match {
        case Right(response) =>
          transid.finished(this, start, s"'$dbName' completed $count documents")

          response.convertTo[Seq[BulkEntityResult]].map { singleResult =>
            singleResult.error
              .map {
                case "conflict" => Left(DocumentConflictException("conflict on 'bulk_put'"))
                case e          => Left(PutException(s"Unexpected $e: ${singleResult.reason.getOrElse("")} on 'bulk_put'"))
              }
              .getOrElse {
                Right(singleResult.toDocInfo)
              }
          }

        case Left(code) =>
          transid.failed(this, start, s"'$dbName' failed to put documents, http status: '${code}'", ErrorLevel)
          throw new Exception("Unexpected http response code: " + code)
      }
    }

I think this logic is good enough
or do you mean deserialize  the whole BulkEntityResult as an error?

Ah, sorry, missed that! LGTM then!

PG5 207 🚀


Modular

Adjust the code structure for easy installation and execution.

Hello @alienzj,
I have been meaning to fix the code structure into the modular format since last year, but I didn't have time to go through it. Thank you very much for putting this PR. I will review it during the weekend and merge it.


FI-1474: Improve wait messages

This branch improves the g10 suite's wait messages. WIP because this branch will require:

a new core release which includes https://github.com/inferno-framework/inferno-core/pull/211
a new SMART test kit release which includes https://github.com/inferno-framework/smart-app-launch-test-kit/pull/25

Screenshots of the updated wait messages:

Yeah, the EHR launch message isn't changed here, so we can update that in the SMART test kit separately.


VS Code Penumbra Dark Contrast ++ No Color contrast in settings with dropdowns or input fields.

When using any of the penumbra themes, they do not have any contrast between dropdowns or input fields in the VS code settings as seen in image attached. The second screenshot will be with another theme GitHub Dark Default. Ideally These fields would have contrast. I'm not sure if this is a bug or if this was intentional. If it was intentional I am curious as to why?
Penumbra Dark Contrast ++

GitHub Dark Default Theme

Also I would like to add that files included in a .gitignore file are not greyed out like they are with other themes.  Shifting through other themes it would appear this is probably an easy fix, as the text color you use for the explorer is the same for all fonts I would guess.
Penumbra
GitHub Dark

Also is there some kind of documentation where it VS Code tells you what each color controls? I would be more than happy to take a look at this and try to fix it myself and submit a pull request, when I get it done.


email failing to send to certain email addresses

Hello
we believe we have all of our DNS records setup based on the settings within Postal Mail under Domains.
I'm trying to send emails to certain addresses which are failing.
We first get a soft fail and then when we try and send it again, we get a hard fail.
Does anyone have any ideas why some emails fail to send.
Here is the error message we get.
450 4.1.8<EMAIL_ADDRESS>Sender address rejected: Domain not found
Time: 0.11s
Support Ref: JK0OQO8M

Hello, I checked my SPF record in Postal and my DNS and I have TXT record set as
mailtest.justin.ca- v=spf1 a mx include:spf.mailtest.justin.ca ~all
when I run tests on https://www.mail-tester.com it says, You do not have a SPF record, please add the following one to your domain psrp.mailtest.justin.ca:
v=spf1 a mx ip4:<IP_ADDRESS> ~all
Would this be causing the issue why some of my email addresses are not receiving my emails

Domain not found means that the subdomain doesn't exist in a CNAME or A record form.
psrp suggests that the return path for the domain name you have set up is not present. Have a look here and note you will need several different types of record for your return path domain:
https://github.com/atech/postal/wiki/Domains-&-DNS-Configuration
The Domains tab in your Postal should tell you if the return path is correct and ready.

willpower232.
Thank you for the response. When I set up Postal Mail I followed the instructions under the Domains tab to setup my DNS records. I didn't use the Domains & DNS - Configuration documentation as I didn't know it existed.
Having said that, the information under the Domains Tab (which all show good for me) don't match what the records show in the Domains & DNS - Configuration documentation. Fox example, no where in the Domains & DNS - Configuration documentation does it show to setup a CNAME record, but under Domains Tab it says it there. Also, in the Domains & DNS - Configuration documentation, it says to create rp.mail.yourdomain.com.      IN    A     <IP_ADDRESS> this is not specified under the Domains Tab.
I guess my question to you is, do I create the exact number of DNS records identified in the Domains & DNS - Configuration documentation exactly as they are listed? This would mean I would have 11 entries?
Also do I need to add the  IPv6 address stuff?
I currently only have 4 DNS records which I created based on the instructions on the Domains Tab

I ran the test again from mail-tester.com and here is what it showed for an issue. Under my Domain Tab, everything is green. I can send emails to some addresses and not others. I did run the test like you indicated above.
We check if the server you are sending from is authenticated
-1
[SPF] psrp.mailtest.justin.ca does not allow your server <IP_ADDRESS> to use<EMAIL_ADDRESS>Sender Policy Framework (SPF) is an email validation system designed to prevent email spam by detecting email spoofing, a common vulnerability, by verifying sender IP addresses.
You do not have a SPF record, please add the following one to your domain psrp.mailtest.justin.ca:
v=spf1 a mx ip4:<IP_ADDRESS> ~all
The Name Server handling the domain name psrp.mailtest.justin.ca is rp.mailtest.justin.ca.
Need guidance? View guides for each host.
Verification details:
dig +short TXT psrp.mailtest.justin.ca :
rp.mailtest.justin.ca.
dig +short TXT @rp.mailtest.justin.ca. psrp.mailtest.justin.ca :
spfquery --scope mfrom --id<EMAIL_ADDRESS>--ip <IP_ADDRESS> --helo-id mailtest.justin.ca :
none
psrp.mailtest.justin.ca: No applicable sender policy available
psrp.mailtest.justin.ca: No applicable sender policy available
Received-SPF: none (psrp.mailtest.justin.ca: No applicable sender policy available) receiver=ns303428.ip-94-23-206.eu; identity=mailfrom<EMAIL_ADDRESS>helo=mailtest.justin.ca; client-ip=<IP_ADDRESS>

Postal requires a number of records to function appropriately and these are set in postal.yml.
You may have set them but not actually created them? https://github.com/atech/postal/blob/master/config/postal.defaults.yml#L84-L91

@willpower232
I will check my settings in postal.yml
Since everything is green under my Domains Tab, does this mean I likely have my DNS setup properly?
Are you suggesting I have some thing not configured properly in my postal.yml file based on the issue identify by mail-tester.com?
I feel like I'm just missing something very simple. I will post my DNS settings in postal.yml tomorrow when I can log into my server.
Thanks for your replies.

@djmuttart I have the same issue, did you manage to fix it?


Fix collection card title

Adjusted height of images and moved titles below the images. Changed titles to not span more than one line and readded the border line between the titles and actions. Should probably do a little more work on the sizing of the images.

:+1:  :shipit:


Customizable loading view with lazyrender

Till now there is no posibility to add a custom loading view in addition with the lazyrender prop...

see pull request #16

merged.... thanks :+1:


Prevent disabled aliases from showing up in help

+1 for this release, but ideally this filtering should happen in the backend, don't you think?

No, frankly, I don't think so. As I said earlier, we don't filter disabled actions or rules on backend, why should we do that for aliases. It's not like we will have a thousands of them disabled and it will became a question of traffic. Sorting them client side would allow to show them with some additional flag for the purpose of discovering and enabling them right from chat without switching context.

Because when someone disabled an alias, they explicitly don't want it to work—and potentially to be exposed at all, even to a bot. I don't insist though, see your point.

they explicitly don't want it to work

that's an opinion

That's why I don't insist. :) Wanted to start a discussion and get another opinion rather than actually change something.

The filter should not be implicit. Infact  hubot-stackstorm can query only for those aliases that are enabled. If that filter is not supported then this is a valid choice as it is client responsibility to ignore a disabled alias. In some contexts there is value in viewing disabled aliases e.g. CLI.
/aliases?enabled=True.

Sorry @manasdk, not working for me. We'll refactor it next time.
$ http https://<IP_ADDRESS>:443/api/v1/actionalias\?enabled\=true\&x-auth-token\=19badad7716743098a03496df63e2cea --verify no
HTTP/1.1 200 OK
Access-Control-Allow-Headers: Content-Type,Authorization,X-Auth-Token,St2-Api-Key,X-Request-ID
Access-Control-Allow-Methods: GET,POST,PUT,DELETE,OPTIONS
Access-Control-Allow-Origin: *
Access-Control-Expose-Headers: Content-Type,X-Limit,X-Total-Count,X-Request-ID
Connection: keep-alive
Content-Length: 4242
Content-Type: application/json; charset=UTF-8
Date: Fri, 04 Dec 2015 08:27:05 GMT
Front-End-Https: on
Server: nginx/1.4.6 (Ubuntu)
X-Content-Type-Options: nosniff
X-Request-ID: 2189a0c5-700c-4494-84fd-3038ab05ea16
X-Total-Count: 12

[
    {
        "ack": {
            "format": "requesting..."
        },
        "action_ref": "core.http",
        "description": "Make http GET request",
        "enabled": false,
        "formats": [
            "http get {{ url }}"
        ],
        "id": "566131eb1c3d9a189f3b2d31",
        "name": "get",
        "pack": "chatops",
        "ref": "chatops.get",
        "result": {
            "format": "done, here it is: {{ execution.result.body }}"
        },
        "uid": "action:chatops:get"
    },
    {
        "ack": {},
        "action_ref": "hubot.branch",
        "description": "Show the currently deployed hubot branch",
        "enabled": true,
        "formats": [
            "hubot branch",
            "hubot branch on {{hosts}}"
        ],
        "id": "566132681c3d9a1e92409472",
        "name": "hubot_branch",
        "pack": "hubot",
        "ref": "hubot.hubot_branch",
...

Sorry @manasdk, not working for me. We'll refactor it next time.

Thanks for trying. I will fix the backend APIs.


OpenAPI formats not supported?

I'm a bit confused regarding schema formats.
According to the Swagger OpenAPI 3.0 page, formats such as int32, byte etc are supported by OpenAPI 3.0:

However, I cannot find these in the OpenAPI 3.0 schema itself at github.
Anyway, whenever my definitions make use of format for schemas, I get warnings from openapi-backend. Consider the following:
paths:
  /foo:
    post:
      operationId: foo
      requestBody:
        content:
          application/json:
            schema:
              type: object
              properties:
                foo:
                  type: integer
                  format: int32
                bar:
                  type: string
                  format: byte

Making a request to this operation renders this:
unknown format "int32" ignored in schema at path #/properties/requestBody/properties/foo
unknown format "byte" ignored in schema at path #/properties/requestBody/properties/bar

Should these formats be supported or ignored?

These formats should definitely be supported.
We should use ajv.addFormat to add the special OpenAPI formats here:
https://github.com/anttiviljami/openapi-backend/blob/master/src/validation.ts#L379
Anyone want to take a stab at this?

Thanks. I can have a go at it!


e2e tests that timeout do not return failure code

When a test such as uperf's host network test times out I expect to see a failure code as the result of the script  however it is returning 0 meaning a successful completion of the test.
Example
[2021-12-01, 05:25:28 EST] {subprocess.py:89} INFO - ripsaw-cli:ripsaw.clients.k8s:INFO :: BENCHMARK	UUID					STATE
[2021-12-01, 05:25:28 EST] {subprocess.py:89} INFO - ripsaw-cli:ripsaw.clients.k8s:INFO :: uperf-benchmark-hostnet-network-1	Not Assigned Yet
[2021-12-01, 05:25:37 EST] {subprocess.py:89} INFO - ripsaw-cli:ripsaw.clients.k8s:INFO :: uperf-benchmark-hostnet-network-1	18a763ca-0e2f-4a97-a845-b9b6713dd317
[2021-12-01, 05:25:39 EST] {subprocess.py:89} INFO - ripsaw-cli:ripsaw.clients.k8s:INFO :: uperf-benchmark-hostnet-network-1	18a763ca-0e2f-4a97-a845-b9b6713dd317	Building
[2021-12-01, 05:25:44 EST] {subprocess.py:89} INFO - ripsaw-cli:ripsaw.clients.k8s:INFO :: uperf-benchmark-hostnet-network-1	18a763ca-0e2f-4a97-a845-b9b6713dd317	Starting Servers
[2021-12-01, 05:26:27 EST] {subprocess.py:89} INFO - ripsaw-cli:ripsaw.clients.k8s:INFO :: uperf-benchmark-hostnet-network-1	18a763ca-0e2f-4a97-a845-b9b6713dd317	Starting Clients
[2021-12-01, 05:26:38 EST] {subprocess.py:89} INFO - ripsaw-cli:ripsaw.clients.k8s:INFO :: uperf-benchmark-hostnet-network-1	18a763ca-0e2f-4a97-a845-b9b6713dd317	Waiting for Clients
[2021-12-01, 05:27:00 EST] {subprocess.py:89} INFO - ripsaw-cli:ripsaw.clients.k8s:INFO :: uperf-benchmark-hostnet-network-1	18a763ca-0e2f-4a97-a845-b9b6713dd317	Clients Running
[2021-12-01, 05:27:08 EST] {subprocess.py:89} INFO - ripsaw-cli:ripsaw.clients.k8s:INFO :: uperf-benchmark-hostnet-network-1	18a763ca-0e2f-4a97-a845-b9b6713dd317	Set Running
[2021-12-01, 07:14:43 EST] {subprocess.py:89} INFO - ripsaw-cli:ripsaw.clients.k8s:INFO :: uperf-benchmark-hostnet-network-1	18a763ca-0e2f-4a97-a845-b9b6713dd317	Run Next Set
[2021-12-01, 07:14:50 EST] {subprocess.py:89} INFO - ripsaw-cli:ripsaw.clients.k8s:INFO :: uperf-benchmark-hostnet-network-1	18a763ca-0e2f-4a97-a845-b9b6713dd317	Running
[2021-12-01, 07:14:59 EST] {subprocess.py:89} INFO - ripsaw-cli:ripsaw.clients.k8s:INFO :: uperf-benchmark-hostnet-network-1	18a763ca-0e2f-4a97-a845-b9b6713dd317	Cleanup
[2021-12-01, 07:15:11 EST] {subprocess.py:89} INFO - ripsaw-cli:ripsaw.clients.k8s:INFO :: uperf-benchmark-hostnet-network-1	18a763ca-0e2f-4a97-a845-b9b6713dd317	Complete
[2021-12-01, 07:15:12 EST] {subprocess.py:89} INFO - ripsaw-cli:ripsaw.clients.k8s:INFO :: uperf-benchmark-hostnet-network-1 with uuid 18a763ca-0e2f-4a97-a845-b9b6713dd317 has reached the desired state Complete

In the example above the steps between "Set Running" and "Run Next Set" take roughly 2 hours which is the default timeout interval of the job.
This results in us having CI jobs that complete and "pass" even though they should throw an error code.

cc @morenod

After some digging the real culprit here is https://github.com/cloud-bulldozer/benchmark-wrapper/issues/399 . Closing this in lieu of that issue.


Fix dtype inference during gradient norm computation

What does this PR do?
Fixes https://github.com/Lightning-AI/lightning/issues/14020
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[n/a] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @borda @akihironitta

The proposed changes won't fix the mentioned bug, as the line
total_norm = torch.tensor(list(norms.values())).norm(norm_type)
(line 49 in src/pytorch_lightning/utilities/grads.py) causes the issue because the
torch.tensor
forces an intermediate typecast (to torch.float32).

As mentioned in https://github.com/Lightning-AI/lightning/issues/14020, there is a type interference needed for 'max_dtype', i.e. a type to which all norms can be typecast without becoming infinite.

@fshart The issue is that list(norms.values()) was a list of primitive floats after calling .item() on their respective tensors, so when creating the "total" tensor, PyTorch would typecast to float32. However, with this patch, we defer the .item() call to the end so the dtype is correctly kept as float64 for the total norm computation.
If I'm missing something, could you come up with a failing test using the changes in this branch?

@carmocca I stand corrected. The MWE from the original issue works with bugfix.


Cannot access "sign off on x responses"

Description
Accessing sign off on responses leads to page not found

URL being sent to: https://7b326hq3bwxyh2tym7gc23dwcm0tmzog.lambda-url.ca-central-1.on.aws/en//en/form-builder/responses/clpsy56bk000mvq83k8pyyrxa
Steps to reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Details

Browser: Chrome
Operating system: Mac
Environment: Preview
Language: English
Viewport: (screen size, zoom level, pixel ratio...)
Output: (form ID, link, JSON form file...)

Expected behaviour
A clear and concise description of what's expected instead.
Screenshots or videos
Visual proof to help explain the problem.
Additional context
Any other information about the problem here.

Is this on staging or the app router ?

app router

Added the app router label

dupe of https://github.com/cds-snc/platform-forms-client/issues/3170


updated dependencies

Updated:

next to v13.4.0
tailwindcss to v3.3.2
contentful-import to v8.5.50
eslint to v8.39.0
eslint-config-next to v13.4.0
postcss to v8.4.23

Task linked: RND-2459 Update and test new Nextjs version for Contentful Starters


Hawkhai | New 'Bookshelf' page

https://blog.hawkhai.com/blog/2017/01/04/bookshelf
Happy new year to all! To the bookworms out there, I’ve added a new page in the site called Bookshelf, a list of all the books I’ve read so far. If you have ...

abc test


Copy unique_id handlers for events

When event emitters were being copied they did not copy the dictionary of unique ids which affected registering handlers with unique ids. This pull request fixes that issue and renames _unique_id_cache to _unique_id_handlers to make it explicit that it is not a cache as opposed to a different representation of the handlers registered with respect to their unique id.
Fixes https://github.com/boto/botocore/issues/465
cc @jamesls @danielgtaylor

Coverage increased (+0.0%) to 94.51% when pulling bd5774a0f1e38d520ad56427e2e530c0e4e8c84f on kyleknap:client-events into 6a63e1884ad12e87479f454affbba5d5863c7f32 on boto:develop.

Coverage increased (+0.0%) to 94.51% when pulling bd5774a0f1e38d520ad56427e2e530c0e4e8c84f on kyleknap:client-events into 6a63e1884ad12e87479f454affbba5d5863c7f32 on boto:develop.

:shipit:


In 331_fine_tune_SAM_mito.ipynb, the class SAMDataset(Dataset) needs to be adjusted to have 3 bands to go into the processor

The demo no longer works.
Change this line in the class SAMDataset(Dataset)
    # prepare image and prompt for the model     inputs = self.processor(image, input_boxes=[[prompt]], return_tensors="pt")
to
    # prepare image and prompt for the model     inputs = self.processor(np.stack((image,)*3, axis=-1), input_boxes=[[prompt]], return_tensors="pt")

Thanks man!

I spent a week trying to figure this out. Thanks for the solution!

Thanks man~~

Still having issues

ERROR:"setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (2,) + inhomogeneous part"


Connecting to TinkerPop In-memory graph loaded into gremlin-server locally

I loaded an in-memory graph on gremlin-server as per the steps in https://kelvinlawrence.net/book/Gremlin-Graph-Guide.html#servertinkergraph.
Now, I want to explore the graph using graph explorer. But the connection is not being established when I am giving endpoint URL as http://localhost:8182. I tried various variants of the URL but was not able to succeed.
I pulled the image using the command
docker build --build-arg host=<IP_ADDRESS> -t graph-explorer .
I started the container with the command
docker run -dit -p 5173:5173 --name graphexp graph-explorer
Can you please help if I'm missing something?

curl "http://localhost:8182/?gremlin=g.V().count()" gives
{"requestId":"15fbd49b-3aa9-4071-9f3d-af7d77e87977","status":{"message":"","code":200,"attributes":{"@type":"g:Map","@value":[]}},"result":{"data":{"@type":"g:List","@value":[{"@type":"g:Int64","@value":3619}]},"meta":{"@type":"g:Map","@value":[]}}}%
Also, I had an updated the config to WsAndHttpChannelizer. Below is the config I was using.
host: localhost
port: 8182
evaluationTimeout: 30000
channelizer: org.apache.tinkerpop.gremlin.server.channel.WsAndHttpChannelizer
graphs: {
  graph: conf/tinkergraph-empty.properties}
scriptEngines: {
  gremlin-groovy: {
    plugins: { org.apache.tinkerpop.gremlin.server.jsr223.GremlinServerGremlinPlugin: {},
               org.apache.tinkerpop.gremlin.tinkergraph.jsr223.TinkerGraphGremlinPlugin: {},
               org.apache.tinkerpop.gremlin.jsr223.ImportGremlinPlugin: {classImports: [java.lang.Math], methodImports: [java.lang.Math#*]},
               org.apache.tinkerpop.gremlin.jsr223.ScriptFileGremlinPlugin: {files: [scripts/air-routes.groovy]}}}}
serializers:
  - { className: org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV3d0, config: { ioRegistries: [org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3d0] }}        # application/json
  - { className: org.apache.tinkerpop.gremlin.driver.ser.GraphBinaryMessageSerializerV1 }                                                                                # application/vnd.graphbinary-v1.0
  - { className: org.apache.tinkerpop.gremlin.driver.ser.GraphBinaryMessageSerializerV1, config: { serializeResultToString: true }}                                                                 # application/vnd.graphbinary-v1.0-stringd
processors:
  - { className: org.apache.tinkerpop.gremlin.server.op.session.SessionOpProcessor, config: { sessionTimeout: 28800000 }}
  - { className: org.apache.tinkerpop.gremlin.server.op.traversal.TraversalOpProcessor, config: { cacheExpirationTime: 600000, cacheMaxSize: 1000 }}
metrics: {
  consoleReporter: {enabled: true, interval: 180000},
  csvReporter: {enabled: true, interval: 180000, fileName: /tmp/gremlin-server-metrics.csv},
  jmxReporter: {enabled: true},
  slf4jReporter: {enabled: true, interval: 180000}}
strictTransactionManagement: false
idleConnectionTimeout: 0
keepAliveInterval: 0
maxInitialLineLength: 4096
maxHeaderSize: 8192
maxChunkSize: 8192
maxContentLength: 10485760
maxAccumulationBufferComponents: 1024
resultIterationBatchSize: 64
writeBufferLowWaterMark: 32768
writeBufferHighWaterMark: 65536
ssl: {
  enabled: false}

Below is the connection UI. I was still not able to establish the connection.

There are a couple of other things that you'll need to change in Gremlin Server to get this to work.  Primarily, graph-explorer needs Gremlin Server to return each vertex and edge with all properties.  By default, the Tinkergraph settings apply a ReferenceElementStrategy which only returns the related vertex or edge IDs and labels.
In the /scripts/empty-sample.groovy file, change the last line in the file from:
globals << [g : traversal().withEmbedded(graph).withStrategies(ReferenceElementStrategy)]
to
globals << [g : traversal().withEmbedded(graph).withStrategies()]
Because graph explorer was primarily built to support Neptune, you may also want to go ahead and change the ID managers in Gremlin Server to mimic Neptune behavior of support both numerics and strings for IDs.
Within /conf/tinkergraph-empty.properties change the following from:
gremlin.tinkergraph.vertexIdManager=LONG
to
gremlin.tinkergraph.vertexIdManager=ANY

I am also having a similar issue when running gremlin-server inside a docker container. No matter what I tried (setting both containers to the same network, using localhost etc.) I couldn't manage to connect to the gremlin-server using graph-explorer even after using the above configuration.

Taking Graph Explorer out of the mix for the moment, if you open a browser and go to http://localhost:8182 you should get a response of "no gremlin script supplied".  That would validate that Gremlin Server is running properly and ready for requests.
Once you've validated that, then try using Graph Explorer to connect to Gremlin Server.  If you're still having issues, please supply the browser console logs (from your browser's developer tools) here of any error messages that you are getting when using Graph Explorer.

Here is the screenshot of the server running in a docker container that I can access from my computer.

Here is what happens when I try to connect to this Gremlin server with graph-explorer running inside a docker container.
If I run graph-explorer locally without a docker container after cloning the repository (the server runs as http instead of https):
cd packages/graph-explorer
npm install
npm start

I can connect to the Gremlin server

but when I try to send a node to explorer I get this error when I open Graph Explorer.

I don't know why the node ids show up as javascript objects

This is the code I use to add vertices to my graph:
node1 = (
    g.addV("label1")
    .property("name", "Node1")
    .property("description", "First node")
    .property("Node number", 1)
)
node1.next()

node2 = (
    g.addV("label1")
    .property("name", "Node2")
    .property("description", "Second node")
    .property("Node number", 2)
)
node2.next()

On the first issue with running both Gremlin Server and Graph Explorer in separate containers.  It almost sounds like the default network has changed in your configuration to use a host network versus a bridge network.  You may want to ensure that you're using a bridge network, or just create a dedicated bridge network for both containers:
docker network create -d bridge <network_name>

then when launching both Gremlin Server and Graph Explorer containers:
docker run -dit --rm -p <port mappings> --name <container-name> --network <network-name> <image>

That would also have the benefit of allowing you to use Docker name services to access your containers, as the default bridge network in docker has that disabled.
On the second issue, you've encountered a bug.  I ran into this recently, I just need to create an Issue for it.  But when you have non-string IDs, the results in GraphSON get returned differently (they include the data type information).  Hence the return of an Object versus just the string value for the IDs.


Get raw markup of current page

Not a bug as such, but when I call:
$page_markup = $this->getSession()->getPage()->getContent();
I notice this isn't exactly the same as the raw markup I receive if I load the page using a browser or a CURL client, for example some attributes in tags will be in a different order, for example:
$page_markup = <link rel="canonical" href="http://www.example.com/" />
Calling from browser = <link href="http://www.example.com/" rel="canonical" />

Is there a way to get the exact markup that was returned by the loading of the page?
I am using Behat 2.x, Selenium, and Firefox.

Mink gets this directly from the driver so it may be a concern of the specific selenium driver.
I think because we're just asking the browser for the markup, you'll get the browser's DOM tree. You could try using the goutte driver as that just does HTTP requests from PHP to fetch the page.

Cheers @ciaranmcnulty I'd thought about switching drivers but have found Selenium better to handle javascript based functionality. Anyway, I tried using:
$this->getSession()->getPage()->getOuterHtml()
Which worked better but there are still some changes from the original request, for example the closing slash on tags such as  don't exist.
I think either I'll find a way to intercept the HTTP request made, or I could always fire off a new CURL request to the current URL.

Anyway, closing this as it is not an issue in Behat. Your questions are related to Mink.


feat: update golang-github-tmc-grpc-websocket-proxy to 0.0_git20200427.3cfed13

proxy to upgrade grpc-gateway streaming endpoints to use websockets
Issue: https://github.com/linuxdeepin/developer-center/issues/3965
Log: update repo

/test all

/test


Can Not Download the weights in the link

MambaIR_guassian25
MambaIR_guassian50

Hi, we have updated the download link of these two models, thanks for your reminder!


Xcode v15.3< :: Undefined symbol: __mh_execute_header

I'm getting this error after upgrading to Xcode 15.3 on my secondary machine. Xcode 15.2 works fine on my Primary rig. Just out of curiosity I then upgraded Mac OS to Sequoia (v15.0) and Xcode to v16.0 to try and future proof my build. However, I am still getting the same error.
I created a new React-Native Application, built to device just fine with base react-native code. I then implemented v1.0.10 of this amazing React-Unity package and i'm still getting the error:
Undefined symbol: __mh_execute_header
I then took to the Unity project and searched for "__mh_execute_header" and found it in the UnityFramework.h file. I'm trying to wrap my head around this now, to see if I can refactor or make sure this method is found but I still wanted to reach out to the community as the latest OS updates are rolled out yesterday.
So this code reference is in the UnityFramework.framework/Header/UnityFramework.h that gets generated via building the Unity exported Xcode project > UnityFramework that gets exported to the Products directory in that same Unity Xcode project. Hoping there is some flags I can enable in Unity that may help.
Anyone else running into this?

Running into the exact same issue. It looks like its due to a change in how the linking works and Unity as a library, found this:
https://stackoverflow.com/questions/78932936/undefined-symbols-for-architecture-arm64-mh-execute-header-unity-as-a-lib

Running into the exact same issue. It looks like its due to a change in how the linking works and Unity as a library, found this:
https://stackoverflow.com/questions/78932936/undefined-symbols-for-architecture-arm64-mh-execute-header-unity-as-a-lib

Thank you for sharing. Did the code change mentioned in the post resolve this for you? I gave my self the night off. But now I'm considering trying it.

in RNUnityView.mm
replace &_mh_execute_header with &_mh_dylib_header
Based on this info
https://developer.apple.com/forums/thread/760227
This fixed the issue for me.

did a fork and pull request:
https://github.com/azesmway/react-native-unity/pull/133
if you want to use it before it is merged just put
    "@azesmway/react-native-unity": "jb-san/react-native-unity",

in your package.json

Thank you both! Tested and confirmed working with a fresh build. This is the best I'm going to sleep all week. Cheers gents! Code on! 🦾🦾🦾

Closing this issue as this is resolved via @jb-san 's PR #133
kind regards

@jb-san  I did another fresh built early this morning, got this error. Took a  nap, made another fresh react-native project, added your forked packaged. and still getting this error. Did you see this at all? By Chance do I need to update another reference? I'm a but baffled as to how I got a fresh build to work once but after that it's been another story. I apologize for reaching out to bother you after confirming it was working but I figured best to lean on the community during a transitional period like this.

Here is the boilerplate code I was hoping to get working:
https://drive.google.com/file/d/1Kl8Mwbd39i77sKXPOm1B_bX1HK7GCtPO/view?usp=sharing
Should have backed up my working project from early this morning but given it was a fresh build I figured I had nothing to worry about :( All these years of development have taught me nothing I see :P

I forgot I did this at some point. Seems like we need need to update the reference here:
Update line 17 in > unity>builds>ios>UnityFramework.framework>Headers>UnityFramework.h
OLD - Broken: extern const struct mach_header_64  __mh_execute_header;
NEW - Working: extern const struct mach_header_64 _mh_dylib_header;
I guess in my dreams I was hoping this reference would be generated after the RNUnityView.mm file update. But per my testing again with written steps, we still need to update this reference.
I hope this helps someone that was stuck like me. I also hope we can get this updated so the refeence is correct after we generate UnityFramework.framework.
Ill keep this open again for a bit longer just to make sure all is well before closing.

Im seeing the same error when trying to do production builds, what version of unity are you using ?

I think the Unity Framework part is depending on the unity version. after updating to 2022.3.47, no change was needed in UnityFramework. its fine on release mode bug debug mode has the error. So i did a conditional fix.

I updated unity to 2022.3.47 LTS as my UnityFramework was mismatching yours. There is a discrepancy in behavior between development (debug) mode and release mode.
In this version of unity, no change was needed to UnityFramework.h. and I applied a conditional fix to the RNUnityView depending on the scheme.

Disclaimer, i have no idea what I'm doing, so this might just be a stopgap until a more proper solution comes along

@jb-san im running Unity 2022.3.46f1
I saw ver x.x.47 came out before I shut it down yesterday. After battling Xcode and rebuilding my rig from scratch. I was too nervous to try and upgrade my project again after just upgraded from 2021 to 2022.3.46f1.
I have release builds working with Unity 2022.3.46, Xcode 16.0 on Mac OS 15.0 not on my Intel and silicon machine.
The trick for me, is you have to update that UnityFramework.h file AFTER you build/generate the UnityFramework.
Here is a subset of my notes for that step.
Update line 17 in > unity>builds>ios>UnityFramework.framework>Headers>UnityFramwork.h
=> extern const struct mach_header_64 _mh_dylib_header;
I hope this helps! I might try a brand new project in a unity 2022.3.47f1 and report back. I also wanted to read the change long and see if they had to do anything related to the iOS or Xcode changes.

Disclaimer, i have no idea what I'm doing, so this might just be a stopgap until a more proper solution comes along

Are your builds working?
Please share if you are running into errors. We are in this together. I think your conditional logic is fine. The issue for me was still at the UnityFramework.framework generation level. It was still referencing the __mh_execute_header on line 17 of the unity>builds>ios>UnityFramework.framework>Headers>UnityFramwork.h
I update the line to
extern const struct mach_header_64 _mh_dylib_header;

Remove/Rebuild pods
Clean Xcode project
Rebuild project

Also! Make sure you have the Unity.tsx in your project or your Unity app will crash loop.

I got through the FlipperType errors in Release builds by adding adding a user Defined variable in my Xcode workspace under built settings:

This works with my PodFile like so:
flipper_config = ENV['NO_FLIPPER'] == "1" ? FlipperConfiguration.disabled : FlipperConfiguration.enabled
Now I get to 99.999% of my Release build and I crash with the "Undefined symbol: __mh_dylib_header" at this point, I'm curious if I revert the dylib changes will I get the same error but for __mh_execute_header like we did previously.

Update -> Debug and Release builds ar WORKINGGG!
The latest update to the PR that does the conditional logic for debug or release builds fixed this issue for me. I don't even have to go back and edit the UnityFramework.framework file like I did prior to the latest PR revision. Here are my test checkout as follows:
Intel (2017 iMac Pro)

New Project -> 100/100 (Debug/Release) working
Existing Project -> 0/0 (Debug/Release) Not working

Silicon (2022 M2 Air)

New Project -> 100/100 (Debug/Release) working
Existing Project -> 100/100 (Debug/Release) working

Not bad at all! I'm so very greatful for the community support with this project and bug in particular. I don't mind the Intel issues as much, the goes is to move my project to Arm architecture anyway.


Update WebApiConfig.cs

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Thanks -- much appreciated! Accepted as 56204b9165fbcde35690c030c29f2a04b443c117


CLOUD-54161 itest fix for rest error handling

@doktoric pls review

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2269/


Problematic call location for DoChange

in TBCBaseEditor.SetSelectedTextEmpty the DoChange is invoked from withing the undo block, which means that user code in OnChange can trigger various issues because the editor is in an intermediate state (found it because merely accessing Lines[] triggered an AV in an edge case).
Two possible solutions:

move all DoChange to outside of internal manipulation sections (but there are many of them, SetSelectedTextEmpty is not an isolated case)
do not call OnChange from DoChange, but defer it to an asynchronous call, once the internal manipulations have ended

I agree, I have also come across this.

For the moment I am rerouting the OnXxxChange events through TTimers, as a poor man's asynchronous mechanism :)

Fixed.


Key duplicates

So, I have pretty extensive menus, and one or two of them are so large that two menu items get assigned the same key.  That's quite a bit of a problem, but I only noticed some time during debugging something else. I understand you can't provide sensible choices (or different choices at all) for all menu sizes, but could you maybe throw an error if that happens so it gets noticed?

I'll double check. The default behavior was to pick any unassigned key. The range of possibilities would be around 80 entries.
It should never repeat. What should happen instead is that the first missing key would be nil, thus erroring.
I'll investigate further and I think this calls up for setting a test infrastructure to avoid regressions.


fix: cloneDeep tab

close #4158

Summary by CodeRabbit

New Features

Introduced a new dependency, es-toolkit, enhancing functionality related to ES module handling and utility functions.

Improvements

Simplified the cloneTab function for improved reliability and conciseness, leveraging the new es-toolkit for deep cloning of route objects.

I think the issue is caused by setTabTitle
https://github.com/vbenjs/vue-vben-admin/blob/e2d9d08ced7d8812e4cee88c3c2a0edc6623e733/packages/stores/src/modules/tabbar.ts#L350-L360
and It seems that multiple components setTabTitle modify the same address
https://github.com/vbenjs/vue-vben-admin/blob/e2d9d08ced7d8812e4cee88c3c2a0edc6623e733/playground/src/views/demos/features/tabs/tab-detail.vue#L16
Do you think I should use cloneDeep in @vben-core/shared to fix it?

I think the issue is caused by setTabTitle
https://github.com/vbenjs/vue-vben-admin/blob/e2d9d08ced7d8812e4cee88c3c2a0edc6623e733/packages/stores/src/modules/tabbar.ts#L350-L360
and It seems that multiple components setTabTitle modify the same address
https://github.com/vbenjs/vue-vben-admin/blob/e2d9d08ced7d8812e4cee88c3c2a0edc6623e733/playground/src/views/demos/features/tabs/tab-detail.vue#L16
Do you think I should use cloneDeep in @vben-core/shared to fix it?

您可以仔细观察下，path路径在详情页面中是不相同的，所以这里是不会出现问题的，我也有调试过，始终没发现问题出现在哪里。。

I found that a deep copy of meta.newTabTitle is enough.
/cc @vince292007


openstack: Update openstack topic to follow the common template

Update openstack README to follow the common template:

File location: https://github.com/tungbq/devops-basic/blob/main/topics/openstack/README.md
Templated location https://github.com/tungbq/devops-basic/blob/main/templates/TOPIC_TEMPLATE.md
Similar task with #418

Done via #442


references to former app properties that are now dynamically loaded are all broken

The variables names in the html files in eureka-webapp were not updated to match the variable names now used.

A related issue is that only the modes are actually loaded into the webapp, not the links nor the registration properties.


Ignore calls to PowerFlex for host revocation when host is null

Signed-off-by: Marcus Sorensen<EMAIL_ADDRESS>Description
This PR Fixes #6739 (for PowerFlex/ScaleIO only, Datera still needs to be addressed), which can occur if the last host the VM ran on is deleted from CloudStack. At the point the VM is deleted, cloudstack attempts to make a final call to revoke access to volumes, passing the last host the VM ran on. If this host is gone, we get an error and are unable to delete the VM.
It's possible that there may be a more holistic fix to this by identifying all of the places where revokeAccess() is called and checking for null host. It's possible other storage plugins don't even need host information to revoke access to volumes and may need this call to revoke. Therefore I'm only applying this fix to the ScaleIOPrimaryDataStoreDriver to skip revoking access when there is no host to revoke access for, and this should protect us as well when a new part of the code tries to use revokeAccess() in the future.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?
Tested in a local branch against PowerFlex primary storage, and with internal testing environments. Repeated steps outlined in #6739. We also had quite a few VMs that would not delete before this change was put into place, which cleaned up successfully afterward.

@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4300

@blueorangutan test

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4368

@blueorangutan test

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan test

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-5080)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45093 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6742-t5080-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers
Failure
466.35
test_vpc_redundant.py


drivers: usb_dc_sam: kill a coverity warning

Coverity complains that packet_len can get assigned a negative value if
usb_dc_ep_mps() returns an error. This is correct, however it only
happens if the endpoint address is invalid, and in that case the value
is not used as the endpoint address is also validated in
usb_dc_ep_write().
Fix the issue by moving the assignment after the endpoint address
validation and by accessing the value directly instead of getting it
through usb_dc_ep_mps().
Fixes #11481
Signed-off-by: Aurelien Jarno<EMAIL_ADDRESS>

Codecov Report

Merging #11517 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11517   +/-   ##
=======================================
  Coverage   48.37%   48.37%
=======================================
  Files         270      270
  Lines       42088    42088
  Branches    10133    10133
=======================================
  Hits        20358    20358
  Misses      17653    17653
  Partials     4077     4077

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e275ae5...d72277a. Read the comment docs.


Unbinned Analysis Fails Due to Wrong evfile (in master branch commit 2af1f67993c0f0cf2f3d41bb8498e68797d74e69)

I've spent the past week, off and on, trying to figure out this issue. Finally figured it out after I figured out well enough how enrico works (in particular the workflow of the code). So doing unbinned analysis, I would consistently (tried multiple times with 3FGL J0001.2-0748, and once with PG 1553 per Rodrigo Nemmen's enrico tutorial (https://github.com/rsnemmen/Fermi-LAT-tutorial)) receive the following error:
RuntimeError: Event::diffuseResponse:
Diffuse component p8r2_source_v6__galdiffmodel does not have an associated diffuse response.
I tracked the issue down to the wrong evfile being passed to UnbinnedObs in fitmaker.py. The original evfile given was self.obs.eventfile. But this passed the *Evt.fits file to UnbinnedObs. The correct file to pass is *MkTime.fits. So self.obs.mktimefile needed to be passed. (for reference: this is on line 100 of fitmaker.py)
Upon changing this (and recompiling fitmaker.py for completeness), the unbinned analysis was able to finish without any errors (some warnings due to low TS, but that was expected due to the small time range I was testing).
Just thought I would create an issue to document the problem and solution. I would create a pull request if I could, but obviously don't have the permissions. So I figured I'd make the information available to the devs.
Edit: To be clear, Rodrigo Nemmen's tutorial does not use unbinned likelihood. I just used the same source since it made for a second source to test, and I already knew that it (along with 3FGL J0001.2-0748) worked with binned likelihood with enrico.

Hi
thanks for this. Please create a pull request to fix this bug
thanks again
best
david

You're welcome. I created a pull request (just forgot I hadn't added a fork to my account earlier).
Adam


[WIP] reorganize documentation

:white_check_mark: Build AElf <IP_ADDRESS>9 completed (commit https://github.com/AElfProject/AElf/commit/5b0717ab78 by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>3 completed (commit https://github.com/AElfProject/AElf/commit/aadefda43f by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>5 completed (commit https://github.com/AElfProject/AElf/commit/e277e3c6a0 by @samfrb)

:x: Build AElf <IP_ADDRESS>4 failed (commit https://github.com/AElfProject/AElf/commit/a3675ca04f by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>9 completed (commit https://github.com/AElfProject/AElf/commit/2dac7d3166 by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>3 completed (commit https://github.com/AElfProject/AElf/commit/015b438ac0 by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>7 completed (commit https://github.com/AElfProject/AElf/commit/8371ebb229 by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>2 completed (commit https://github.com/AElfProject/AElf/commit/0991629d41 by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>4 completed (commit https://github.com/AElfProject/AElf/commit/5bf8c98b70 by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>7 completed (commit https://github.com/AElfProject/AElf/commit/08da85aa93 by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>6 completed (commit https://github.com/AElfProject/AElf/commit/2c80301e7f by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>0 completed (commit https://github.com/AElfProject/AElf/commit/c8c4596137 by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>6 completed (commit https://github.com/AElfProject/AElf/commit/6ed45ba251 by @samfrb)

:x: Build AElf <IP_ADDRESS>8 failed (commit https://github.com/AElfProject/AElf/commit/ad72389f2b by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>6 completed (commit https://github.com/AElfProject/AElf/commit/f857078e41 by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>7 completed (commit https://github.com/AElfProject/AElf/commit/ef5b5fdacf by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>8 completed (commit https://github.com/AElfProject/AElf/commit/70efbb26cd by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>3 completed (commit https://github.com/AElfProject/AElf/commit/56912df237 by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>5 completed (commit https://github.com/AElfProject/AElf/commit/cb19a65319 by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>1 completed (commit https://github.com/AElfProject/AElf/commit/4864fb5a4e by @samfrb)

:white_check_mark: Build AElf <IP_ADDRESS>7 completed (commit https://github.com/AElfProject/AElf/commit/2894c721d4 by @samfrb)


Download cred-alert-cli from GitHub instead of S3.

We're not doing any active development on cred-alert, just tidying up a bit.

Merged.


Regarding Class-wise forgetting

Hello, I would like to ask a question regarding Class-wise forgetting. There is a significant difference between the results I obtained and those described in the paper. Can you help me out and tell me what the problem is?
python -u main_forget.py --seed=1 --gpu 0 --data ./datasets/cifar10 --dataset cifar10 --save_dir './_results/cifat10' --mask ./omp/cifar10/1model_SA_best.pth.tar --print_freq=10 --unlearn FT --class_to_replace 0 --unlearn_epochs 10 --unlearn_lr 0.01

I have replied this issue via email as follows.
"Thank you for your interest in our paper. Based on the information provided, it’s difficult for me to determine the issue and help debug what’s happening.
There is, however, an existing issue where the results shown in https://github.com/OPTML-Group/Unlearn-Sparse/issues/4 have been successfully reproduced those results. You might want to check that for reference.
Could you please provide more details about the specific commands you ran? Since there is a large variance in class forgetting, it’s important to try running the process multiple times. Also, could you clarify how you obtained the sparse model?"
Since there hasn’t been a follow-up response via email, I’ll go ahead and close this issue for now. If you have further questions, feel free to reopen it or create a new one.


Error in Raffle.test.js

1> Error: call revert exception; VM Exception while processing transaction: reverted with panic code 17
This error is for
it("returns false if enough time hasn't passed", async () => {
                  await raffle.enterRaffle({ value: raffleEntranceFee })
                  await network.provider.send("evm_increaseTime", [interval.toNumber() - 10]) // use a higher number here if this test fails
                  await network.provider.request({ method: "evm_mine", params: [] })
                  const { upkeepNeeded } = await raffle.callStatic.checkUpkeep([])
                  assert(!upkeepNeeded.toNumber())
              })

2> Timeout Error in "picks a winner, resets, and sends money"
it("picks a winner, resets, and sends money", async () => {
                  const additionalEntrances = 3 // to test
                  const startingIndex = 1
                  const accounts = await ethers.getSigners()
                  for (let i = startingIndex; i < startingIndex + additionalEntrances; i++) {
                      raffle = raffle.connect(accounts[i])
                      await raffle.enterRaffle({ value: raffleEntranceFee })
                  }

                  const startingTimeStamp = await raffle.getLastTimeStamp() // stores starting timestamp (before we fire our event)

                  // This will be more important for our staging tests...
                  await new Promise(async (resolve, reject) => {
                      raffle.once("WinnerPicked", async () => {
                          // event listener for WinnerPicked
                          log("WinnerPicked event fired!")
                          // assert throws an error if it fails, so we need to wrap
                          // it in a try/catch so that the promise returns event
                          // if it fails.

                          // Now lets get the ending values...
                          const recentWinner = await raffle.getRecentWinner()
                          log(recentWinner)
                          const raffleState = await raffle.getRaffleState()
                          const winnerBalance = await accounts[3].getBalance()
                          const endingTimeStamp = await raffle.getLastTimeStamp()
                          await expect(raffle.getPlayer(0)).to.be.reverted
                          // Comparisons to check if our ending values are correct:
                          assert.equal(recentWinner.toString(), accounts[3].address)
                          assert.equal(raffleState, 0)
                          assert.equal(
                              winnerBalance.toString(),
                              startingBalance // startingBalance + ( (raffleEntranceFee * additionalEntrances) + raffleEntranceFee )
                                  .add(
                                      raffleEntranceFee
                                          .mul(additionalEntrances)
                                          .add(raffleEntranceFee)
                                  )
                                  .toString()
                          )
                          assert(endingTimeStamp > startingTimeStamp)
                          resolve() // if try passes, resolves the promise
                      })

                      // kicking off the event by mocking the chainlink keepers and vrf coordinator
                      const tx = await raffle.performUpkeep("0x")
                      const txReceipt = await tx.wait(1)
                      const startingBalance = await accounts[3].getBalance()
                      await vrfCoordinatorV2Mock.fulfillRandomWords(
                          txReceipt.events[1].args.requestId,
                          raffle.address
                      )
                  })
              })

I think there is some problem in this part because while debugging my program was stopping here
await vrfCoordinatorV2Mock.fulfillRandomWords(
                          txReceipt.events[1].args.requestId,
                          raffle.address
                      )

Hey Nikhil
I've just quickly tested this, have a see if these work for you:

I don't think you need to convert your upkeepNeeded assert, try it without toNumber() so it looks like this: assert(!upkeepNeeded).

You don't appear to have wrapped the promise in the try catch, I've commented mine out to test and it does work so it's only a suggestion!

Let us know how you get on ...

Is this resolved, can this issue now be closed?

Thanks @RyanPaulGannon, I'm going to close this for now.


[Request for help] Splitting out the example status bar - what's needed?

Hey @koekeishiya, @dominiklohmann, et al 👋
I'd really like to get started writing a stand alone bar for everyone to use along side yabai.
As expressed in various places, several times - for reasons I completely understand and agree with - it's clear the status bar is not a point of development focus.
I'm opening this issue in hopes that someone may be willing to help guide me on getting at least the current example status bar split out into its own codebase and building on its own.
I'm not familiar with C at all (but have always wanted to dabble, so this is a good chance), and so far my efforts are falling short.
Once the bar is split out, I'll be looking to introduce extensibility and other features.
Many thanks in advance for any help anyone is willing to give 🙏

https://github.com/somdoron/spacebar

Ah! Excellent! Thanks @johnallen3d - I'll close this off then

I took a quick look at the referenced bar and it inherits a lot of structure from yabai that is unnecessary. This is simply my opinion, but I think it is better to start from scratch and use the code from yabai as a reference when needed. I also think it should be fairly sufficient to rely on the signal and query system for the information you need from yabai, at least this is what I would do.
Some rough outlines as to what this process would look like; how I'd do it anyway:

Get a window up and running, and clear the screen. See src/bar.c bar_create for reference.
Ability to connect, send, and receive information from yabai. See src/yabai.c client_send_message for reference.
Draw sample information retrieved from socket calls in step2. to the screen. See src/bar.c bar_refresh for reference.
Implement some way that lets other applications notify your bar (in the future, specific modules) to refresh, for integration with the yabai signal system.
Put it all together.
Start working on modules (configuration, layout management, partial updating, etc).

The owner of spacebar, @somdoron, replied to me about his plan for this project. And he said he currently has not enough time to develop it further (like modularizing it). Ref: https://github.com/somdoron/spacebar/issues/5#issuecomment-615206497
Hope people who are familiar with macOS API and C could make contribution to it. :P

@koekeishiya Coincidentally almost exactly a year later; I just got started on a re-write of (soon-to-be-renamed) spacebar.
Based off your guidance above - which I appreciate and align with - I was wondering: does yabai emit events on its socket?
Forgive me if that's a naive question, I'm only really now getting my hands dirty with some of the event stuff.
In writing this new bar, one of the improvements I wanted to make was to rely on yabai for notification of specific events, like space changes, window focus change, display focus change, etc. Such that I wouldn't have to implement these event loops in the new bar. I was hoping I might be able to "subscribe" to event messages on yabai's socket, to which the bar could react with callbacks.


Suggestion: Sounding enchant applied to weapon detects mobs instead of ores

I was thinking it would be useful for finding caves and spawners if you could apply Sounding to a sword or axe. It would work just like it does on a pickaxe only it'd show you mobs instead. It'd work on passive mobs too, but not non-mob entities like minecarts.

This issue was moved to Azanor/thaumcraft-suggestions#156


Invalid Syntax in securityLevels

The file beaconConfigurationSchema.yaml contains invalid OpenAPI syntax in it's default value.
Existing Syntax:
securityLevels:
    description: All access levels supported by the Beacon. Any combination is
      valid, as every option would apply to different parts of the Beacon.
    type: array
    items:
      enum:
        - PUBLIC
        - REGISTERED
        - CONTROLLED
      default:
        - CONTROLLED

Corrected Syntax:
The default value should be defined at the same level as the other properties under securityLevels:
securityLevels:
  description: All access levels supported by the Beacon. Any combination is
    valid, as every option would apply to different parts of the Beacon.
  type: array
  items:
    type: string
    enum:
      - PUBLIC
      - REGISTERED
      - CONTROLLED
  default:
    - CONTROLLED

Reference:
OpenAPI Specification - Describing Parameters - Default Parameter Values
Note:
After fixing the .yaml files, the .json should be fixed as well by running the schema conversion script located in the bin folder.

Seems fine to me.  PR, please

+1

Again too fast with the +1. It is a mix of both changes:

the default parameter is at the root level of the object as @datsirul pointed out (it is not a default for the items...)
as @redmitry points out the default should be an array of one or more of the ENUM values
it is correct in the JSON version which emphasizes the correct way to do the code editing as @datsirul always adds to his issues (+1):

Note: After fixing the .yaml files, the .json should be fixed as well by running the schema conversion script located in the bin folder.

    type: array
    default:
      - - CONTROLLED
    items:
      enum:
        - PUBLIC
        - REGISTERED
        - CONTROLLED

I've reviewed the syntax again and it seem that these two options are valid and similar:
        default:
          - CONTROLLED

        default: [CONTROLLED]

And after running the beacon yamler, both of them outputted the expected json default array with one value.
When using this syntax - - CONTROLLED it generated  an array of an array: "default": [["CONTROLLED"]].
I'll create a PR with - CONTROLLED to keep a cohesive structure with the rest of the code.

@datsirul Oh well, yes. I got confused by @redmitry ╮(╯▽╰)╭ because this was the issue in another discussion (the lists of lists in examples where this would be the case). Fixed my comment above.


[MM-20139] Use typed mattermost-redux library to add typings to Jira plugin's redux store

Summary
MM-20139-Use typed mattermost-redux library to add typings to Jira plugin's redux store
Ticket Link
https://mattermost.atlassian.net/browse/MM-20139
Fixes #428

Thanks @AGMETEOR.  This is looking great. You had mentioned in the Issue this is was a draft PR.  Is this ready for final review?

@jfrerich it's ready for review

@AGMETEOR, did you bump the mattermost-redux version locally?  When I clone, mattermost-redux version is "version": "github:mattermost/mattermost-redux#40e5bd5a18daa919c62a06b360aa27f2e6ed3e13" in package-lock.json.  This is causing linting errors because that version is still JS, not TS? cc: @mickmister

@jfrerich I didn't change the mattermost-redux version. I do remember getting TS warnings about mattermost-redux not having an index.d.ts

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

@AGMETEOR @jfrerich wasn't sure what the next step here is :)

@jfrerich Type checking for imports from mattermost-redux are working in my IDE after upgrading the mattermost-redux dependency, and running npm install in the webapp dir. The dependency should be updated to point to the latest commit on master for the mattermost-redux repo.
@AGMETEOR One last request on this refactor. Can you adjust the index.ts files in the components dir to have the following signatures?
const mapStateToProps = (state: GlobalState) => {
and
mapDispatchToProps(dispatch: Dispatch<GenericAction>) {
where Dispatch is imported from redux
Can you also convert the index.js files to index.ts and do the same there? This is one of the areas where the power of the typed store really comes in handy. Let me know if you run into any issues with it.
Thanks for the great work on this @AGMETEOR!

@jfrerich Type checking for imports from mattermost-redux are working in my IDE after upgrading the mattermost-redux dependency, and running npm install in the webapp dir. The dependency should be updated to point to the latest commit on master for the mattermost-redux repo.
@AGMETEOR One last request on this refactor. Can you adjust the index.ts files in the components dir to have the following signatures?
const mapStateToProps = (state: GlobalState) => {
and
mapDispatchToProps(dispatch: Dispatch<GenericAction>) {
where Dispatch is imported from redux
Can you also convert the index.js files to index.ts and do the same there? This is one of the areas where the power of the typed store really comes in handy. Let me know if you run into any issues with it.
Thanks for the great work on this @AGMETEOR!

@mickmister worked in this. There're some files in components that are not yet ported to TypeScript. I would like to run a campaign to convert each file to TS issue by issue. What do you think?

@AGMETEOR, did you bump the mattermost-redux version locally? When I clone, mattermost-redux version is "version": "github:mattermost/mattermost-redux#40e5bd5a18daa919c62a06b360aa27f2e6ed3e13" in package-lock.json. This is causing linting errors because that version is still JS, not TS? cc: @mickmister

@jfrerich bumped the mattermost-redux version to use latest commit on the mattermost-redux repo.

I would like to run a campaign to convert each file to TS issue by issue. What do you think?

:+1: :+1: :+1: @AGMETEOR That sounds great!! Please announce that you want to do so in the Contributors channel, and mention that the tickets will go in the Jira plugin repo specifically. I would also post in the Jira plugin channel so it is seen by the Integrations team.
Thanks for the great idea @AGMETEOR, and laying down the foundation with your work on the plugin!! We are happy to help with any questions you may have with the process.

Codecov Report

Merging #461 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   34.84%   34.84%
=======================================
  Files          36       36
  Lines        4276     4276
=======================================
  Hits         1490     1490
  Misses       2645     2645
  Partials      141      141

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13ae05...7f020fb. Read the comment docs.

Hi @AGMETEOR ,
I think I see an issue with this change.
There seems to be an issue with Allow users to attach and create Jira issues in Mattermost
When you 1st upgrade the option does not work on desktop. You then have to disable and re-enable the flag (with plugin restart) to make the option work on desktop.
Steps:

Ensure creation via UI is enabled
Upgrade to build from this branch
Login to the server from the desktop client
Open the post menu on a a post
Observed:
A. The Jira items are missing
B. /jira create is also non functional
Login to the server in chrome, note the Jira options are visible as expected
Disable the flag and re-enable it
Observed: flag is working on desktop now

Can you  please see if you can repro this?

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

Hey @AGMETEOR - I know it has been a while. Are you interested continuing to work on this pull request? Looks like it's close. cc @jfrerich