Dracula for Lapce

Text editor project with github based theme repos similar to Atom.
https://github.com/d4rkr41n/lapce-dracula

Hey, very cool! ✨
I just sent you an invitation to join the organization.
I also cloned your repository for Dracula's organization, so you can go ahead and delete or archive yours:

Your repository.
New repository.

Thanks for building this! 🎉


Just crashes :(

I compiled it myself for ARM64e devices, but after entering the game and pressing the OK button, after 10 seconds the game crashes without producing any results.
Device:
iPad Air (5th generation)
iOS 15.6.1 with Bootstrap
Critical Ops
https://github.com/user-attachments/assets/5fb9d64b-c6e1-4b64-971e-dde4aaa35d55

Not all apps are supported!

We'll implement edited code in the future, for different games that requires manual work

Thanks


results.py bug

https://github.com/THUDM/LongBench/blob/072a5a739b05ab3c98ff1ea922c5293ebe317b75/result.py#L29
maybe medium?

Thanks for pointing out this typo! Fixed.


World modification fix

PlayerEntity.canMine was inverted.
"Restricted" comes from a string in ServerPlayerInteractionManager.processBlockBreakingAction.

Hum, this method name looks like it belongs to a World class. What about isPreventedFromWorldModification?

canMine -> cannotMine
shouldLimitWorldModification -> shouldAllowWorldModification

this method name looks like it belongs to a World class

Does it really? Looks obvious to me.

canMine -> cannotMine

I don't like putting negatives into names, it gets confusing as soon as a ! introduces a double negative. "Restricted" is just as clear as "cannot mine", and "not restricted" is 100x clearer than "not cannot mine".

shouldLimitWorldModification -> shouldAllowWorldModification

No, that would be an incorrect name.

Ah I thought both had changed, since you renamed both methods. In that case shouldLimitWorldModification should remain unchanged because it is out of scope.

isBlockBreakingRestricted? hasRestrictedInteraction?

People seem to be randomly suggesting alternative names without explaining why they are better than mine

This is only affecting block breaking. world modification is too broad for this.

@liach Just block breaking, or placing too?
Also, this method doesn't seem to take a player parameter. If the player is in adventure mode and they're holding a tool with an NBT tag that allows breaking certain blocks, this method would return false, but breaking and placing blocks is still allowed.

block breaking only, used in player interaction manager or server play network handler


[fix] Openlayers_Map : icon anchor position

Coverage decreased (-0.4%) to 83.626% when pulling 99f404a6b8b004e69668180759b12a9bd86cb681 on fix-openlayers-map into 1ffe92fa0b1f0b505535d743223e8a7b6ef8d6dc on master.


Very slow initialization for LMS_StreamBoard_FIFO

I was testing with the LMS_StreamBoard, and I couldnt figure out why it took 10 seconds to get data. I found that this seemingly innocent block of code was the culprit. Nothing to do with threads or blocking:
    mRxFIFO = new LMS_StreamBoard_FIFO<SamplesPacket>(1024*2);
    mTxFIFO = new LMS_StreamBoard_FIFO<SamplesPacket>(1024*2);

///calls this which takes 10 seconds or more

            for (int i = 0; i < FIFO_length; ++i)
            {
                mElements.push_back(T());
                ++cnt;
            }

//The packet type (T) is big... but not that big...

        const static int samplesCount = 32768;
        float iqdata[samplesCount];
        int channel;

In addition, I have had some compiles that did not experience this delay (rearguards of master branch or connection work). Its weird... But the fix was to use a pointer instead (other changes needed to compile not shown):
diff --git a/src/LMS_StreamBoard/LMS_StreamBoard_FIFO.h b/src/LMS_StreamBoard/LMS_StreamBoard_FIFO.h
index 51d06cd..53805be 100644
--- a/src/LMS_StreamBoard/LMS_StreamBoard_FIFO.h
+++ b/src/LMS_StreamBoard/LMS_StreamBoard_FIFO.h
@@ -38,7 +38,7 @@ public:
         {
             for (int i = 0; i < FIFO_length; ++i)
             {
-                mElements.push_back(T());
+                mElements.push_back(new T());
                 ++cnt;
             }
             //mElements.resize(FIFO_length, T());
@@ -131,7 +131,7 @@ protected:
        uint32_t mElementsFilled;

     std::mutex mElementsLock; // condition variable for critical section
-    std::vector<T> mElements;
+    std::vector<T *> mElements;
     std::condition_variable canWrite;
     std::condition_variable canRead;
 };

Ultimately, I don't think that I will use this class for the soapysdr work or the demo. I am just testing for now and I can ignore it. But this issue may come up again, so its good to keep track of stuff like this.

for (int i = 0; i < FIFO_length; ++i)
{
    mElements.push_back(T());
    ++cnt;
}
//mElements.resize(FIFO_length, T());

Perhaps the pushing to vector causes a lot of memory reallocations that is slowing it down. I've never encountered slowdown in that section.
Anyway, previously this was done with vector resize which should allocate all needed memory in one go, but for unknown reason it always gave segfaults, somehow changing the code to loop solved it.

mElements.resize(FIFO_length, T());

I think using the vectors causes a lot of resizes and FIFO_length! (factorial) memory copies beach each element is copied every time there is a resize. But switching the push_back with resize doesn'y fix the delay for me. :-( No idea.
Anyway, FIFO_length * samplesCount * float =<PHONE_NUMBER>*4 = 256 MiB And that could fail allocation to a single slab of memory.


Issue with Bountiful Mod

Running this in Single Player does not cause any issue, however when placed on a server this caused a player to get locked out of the server upon claiming a reward for a bounty board. Deleting the playerdata was the ONLY solution here. I have included the log file from the server, hope this helps.
latest.log

Bountiful is using client-only code in common source which will crash when used on a server, this is not related to Neruina


Project 01: Task 02: Code Repeated Twice & Done for Us (Moderate)

In Project 01, Task 02, the block of the code in which we have to create the initial and changed arrays has code for that task repeated twice with the second iteration completing the task for us. Is the second iteration with the solution the teacher's solution test code to check the execution that was left over in the final release?

Steps

[ ] Remove solution test.
[ ] Rebuild notebooks.


Cassandra nodes can't connect to seed provider

WARN  11:58:05 Seed provider couldn't lookup host cass-cassandra-1510658740-31487-cassandra-ringnodes-0.cass-cassandra-1510658740-31487-cassandra.test-cassandracluster-1510658740-31487.svc.cluster.local
The seed provider lists no seeds.
Exception (org.apache.cassandra.exceptions.ConfigurationException) encountered during startup: The seed provider lists no seeds.

The service we're creating needs to be headless.
Or we could use KubernetesSeedProvider from: https://github.com/kubernetes/examples/tree/master/cassandra/java
Or we look at the other cloud specific "snitches" which give cassandra more information about the datacentre, zone and region of cassandra nodes: http://docs.datastax.com/en/archived/cassandra/3.x/cassandra/architecture/archSnitchesAbout.html

Probably do 1 first and then follow up with 2 or 3
/kind bug

Fixed in https://github.com/jetstack/navigator/pull/128


[Enhancement]Enhance paimon reader for decimal type

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exec/jni_scanner.cpp
0
1
00.00%
[193]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 3 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exec/jni_scanner.cpp
0
3
00.00%
[379, 381, 383]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 3 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exec/jni_scanner.cpp
0
3
00.00%
[379, 381, 383]

@Mergifyio backport branch-3.2


The inferred type of 'Command' cannot be named without a reference to '.pnpm/@types+react@18.2.37/node_modules/@types/react'.

I´m getting a strange error using the Command component any ideas on this one?
The inferred type of 'Command' cannot be named without a reference to '.pnpm/@types+react@18.2.37/node_modules/@types/react'.

The error is showing on const Command, CommandInput, CommandList, CommandEmpty, CommandGroup, CommandSeparator and CommandItem.

Hi @sebiweise, there's an issue in the Microsoft Typescript repo related to this error: https://github.com/microsoft/TypeScript/issues/42873
I hope it helps.

Perfekt thank you, worked for me.

@sebiweise mind sharing what fix you used from the repo for this?

@sebiweise mind sharing what fix you used from the repo for this?

Here's a oft-cited workaround reply in the thread. Unfortunately very buried in the hundreds of comments! I'm currently trying to solve for this and about to see what works, myself.
https://github.com/microsoft/TypeScript/issues/47663#issuecomment-1519138189


Say who takes next action when "PR is NOT APPROVED"

I think it's on the PR author to find and assign appropriate approvers, but that's not made clear.  For more casual contributors, this is the source of confusion.  Please add a message saying @author please find/assign appropriate approvers
E.g.
[APPROVALNOTIFIER] This PR is NOT APPROVED

Needs approval from an approver in each of these OWNERS Files:

hack/OWNERS
pkg/kubectl/OWNERS
We suggest the following people:
...

/remove-lifecycle stale

@kubernetes/sig-testing-feature-requests

The approval notification comment already says something like the following when a PR is not yet fully approved:

To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cjwagner
Assign the PR to them by writing /assign @cjwagner in a comment when ready.

Is this sufficient?


Use CAS API

Rationale
Note that this PR replaces https://github.com/voxel51/fiftyone-auth-migration/pull/1
Jira ticket: https://voxel51.atlassian.net/browse/TEAMS-2421
The migration script was originally designed to directly connect to the database and insert user records. Instead, we're going to favor leveraging the CAS API for organization and user management.
Changes
Removed references to direct database connection and associated methods.
Implemented connection to CAS API
Added some basic logs
Updated  README
Testing
Supply the appropriate values in config.py and run migrate.py -- see that the users from the associated Auth0 org get populated in the database specified in the Teams deployment where CAS is running.
For testing purposes, I used a different value for CAS_DATABASE_NAME where CAS is running to keep the testing database separate.
Additional testing (stress, full App running) is going to be completed in another ticket. Additional updates will be made in a separate PR

nice work Tom! 🍨
besides the inline comment about camelCasing the org keys

suggestion: Move the config to .env variable so users can just copy paste it in the repository from their teams deployment - can be later too

I tried to load the app in internal mode pointing to the new shiny migrated db and Keycloak as an IdP but couldn't get to sign in with<EMAIL_ADDRESS>- I don't believe the issue has anything to do with this PR but we will have to figure out how to test this next for sure. I'll set something up tomorrow for us to chat about this.

The env vs config is a good point. I originally left it as a config only because I figured users just need to copy in values either way...figured adding another layer from env to config was unnecessary overhead. But you raise a good point, users could just copy and paste their env from their deployment if given the option. I'll make that update.


:seedling: Add CI to check if golang version updated

This is a copy of https://github.com/operator-framework/operator-controller/pull/1264


fundamentals/localization "Globalization and localization" perf

Suppose I support limited number of translations, but I want to handle every possible culture in terms of formatting. E.g. I have only English version of the web app, but want users to see date-time and number formatting which correspond to their system setting. Is it ok to do this like:
services.Configure<requestlocalizationoptions>(options =>
{
options.SupportedCultures = CultureInfo.GetCultures(CultureTypes.AllCultures);
options.SupportedUICultures = new[] { new CultureInfo("en-US") };
});

My concern here is about specifying an array of ALL (832) cultures which will be checked at every request - can that have noticeable performance impact? Is there more correct way to achieve what I need?
My intuitive thinking was that the runtime should just try to instantiate a CultureInfo with client's culture if, say, supported cultures are not specified, but in this case I guess it will fallback to default culture.
This question from fundamentals/localization topic.

@ryanbrandenburg  please comment

I ran a quick test on the LocalizationWebsite to see if it was noticably slow in this scenario and it didn't seem to be. Also, CultureInfo.GetCulture and CultureTypes are both removed from .NET Core so for people using that this patern isn't even an option. Further, I think it's unlikely to be useful for a number to be formated for a persons language if the page isn't in their language.
Overall I don't think we really need to address this scenario in the docs as it's an edge case.

I agree, great work.

I think it's unlikely to be useful for a number to be formated for a persons language if the page isn't in their language.
The page can be not in their language not because they set different language on their system, but because the web site doesn't have translation to their language. But at least such site could give the user what doesn't require translation effort: the formatting.

For example, suppose you're working on a flight or hotel booking app, you support not every language, but want users to see dates, numbers and currency formatting as they're used to see them. For example, en-US culture formats dates so month goes first, then day (MM/dd). But in many other cultures day goes first, then month (dd/MM). If the user sees 05/04/2016, how can he be sure which exact date this means?

@andriysavin For date formats at least, using something like dd MMM yyyy as the format tends to be clear worldwide, even if the language used for the months isn't translated (as you already noted). That's why it's my preferred online format.
(written 4 Nov 2016)

@ardalis I agree if you display dates as  "4 Nov 2016" it removes any confusion. But its not always acceptable. Sometimes (and often) you want a numeric format.

To be clear, I'm not saying there's anything WRONG with doing it the CultureTypes.AllCultures way or that we don't support it, I'm just saying that it's an edge case for the reasons listed above and therefore not something we need to address in our high level documentation.

@ryanbrandenburg Ok, at least this approach works, and works without performance issues. But how can this case be addressed on the .NET Core, where, as you said, these APIs are removed? I understand this is not docs-related, but since we already started...

I know of no alternative to CultureInfo.GetCultures. You can check out this issue for a little background on the how and why on the lack of CultureInfo.GetCultures. My best suggestion would be to select the list of cultures you feel are most important to your apps user base.

@ryanbrandenburg Thanks!


Fix creating chunks with original quality from png images

Motivation and context

How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

Bug Fixes

Improved image saving process to retain the original image format, ensuring consistency and accuracy when saving images.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.36%. Comparing base (f4ee3f9) to head (88b3f55).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7899      +/-   ##
===========================================
+ Coverage    83.33%   83.36%   +0.02%
===========================================
  Files          380      380
  Lines        40022    40022
  Branches      3766     3766
===========================================
+ Hits         33353    33365      +12
+ Misses        6669     6657      -12

Components
Coverage Δ

cvat-ui
79.26% <ø> (+0.06%)
:arrow_up:

cvat-server
87.14% <ø> (-0.01%)
:arrow_down:


typo: storage/resource-manager/Microsoft.Storage

availabity -> availability

Automation for azure-sdk-for-go

Automation for azure-sdk-for-node

Hi @nschonni  thank you so much for your Contributions!!!


List of packs as array

Currently, tpay\TransactionApi::masspaymentPacks() returns incomplete XML response with list of packs (see this line for reference). Incomplete because I can't even parse it by using simplexml_load_string function. Below is exact response I get fromtpay\TransactionApi::masspaymentPacks().
[
    "result" => 1
    "packs" => "<pack><pack_id>9564</pack_id><date>2017-01-20 17:20:38</date><auth_date></auth_date><status>pending</status><count>1</count><sum>0.01</sum><cost>0.00</cost></pack><pack><pack_id>9563</pack_id><date>2017-01-20 17:08:02</date><auth_date>2017-01-20 17:14:43</auth_date><status>auth</status><count>1</count><sum>0.20</sum><cost>0.90</cost></pack><pack><pack_id>9561</pack_id><date>2017-01-20 13:14:11</date><auth_date></auth_date><status>pending</status><count>1</count><sum>0.20</sum><cost>0.90</cost></pack><pack><pack_id>9544</pack_id><date>2017-01-18 22:02:20</date><auth_date>2017-01-18 22:02:40</auth_date><status>auth</status><count>1</count><sum>0.20</sum><cost>0.90</cost></pack><pack><pack_id>9538</pack_id><date>2017-01-18 11:16:14</date><auth_date></auth_date><status>pending</status><count>1</count><sum>200.00</sum><cost>0.90</cost></pack>"
    "err" => ""
]

As you can see, packs element consists of incomplete XML (it does not have root element) and I manually have to wrap it with it, as below:
$packs = simplexml_load_string(sprintf('<packs>%s</packs>', $response['packs']));

In addition, I would suggest to instead of returning incomplete XML string, return PHP array with list of packs. It would be much easier to read it. See below response:
[
    "result" => 1
    "packs" => [
        [
            'pack_id' => '9564',
            'date' => '2017-01-20 17:20:38',
            'auth_date' => '',
            'status' => 'pending';
            'count' => 1,
            'sum' => 0.01,
            'cost' => 0.00
        ],
        [
            'pack_id' => '9563',
            'date' => '2017-01-20 17:08:02',
            'auth_date' => '2017-01-20 17:14:43',
            'status' => 'auth';
            'count' => 1,
            'sum' => 0.20,
            'cost' => 0.90
        ],
        // ...
    ],
    "err" => ""
]

We have made some changes, masspaymentPacks and masspaymentTransfers functions now
returns valid php array.


Added release workflow

Now the workflow will automatically create release, attaching assets (binary files) with them.
Resolve #63

This should be fine 🌝


Don't use chain! in arithmetic tests

Fixes part of #328
This one is a little trickier, in order to drop the mut usage, I used fold_many which might be less intuitive.
I think it's a good start though, until we rewrite it another way maybe at some point.

Thanks!


Add throw Exception in case of error

In LPVSWebhookUnit in some functions, instead of returning an error message as String, we have to throw an exception.
Example is here: https://github.com/Samsung/LPVS/blob/f26543d676b30a94900b20e74da25e3c9f166948/src/main/java/com/lpvs/util/LPVSWebhookUtil.java#L94
UTs should be updated as well

Hi @o-kopysov
I'm interested in contributing this project, particularly regarding Issue #301. Would it be alright if I worked on this issue?
Looking forward to your guidance.
Thanks,

Hello, @choichanhyeok .
Sure. Just want to point out that unit tests should also be fixed 😁
Thanks!


Create standardized library for routes

Create a library for routes so that repeat code doesn't repeat repeatedly through out repeated code.

Done.


Disable text highlighting in tabs

Disable text selection in tabs, like this, from happening:

Thanks!


How can I apply diminish-mode to aphelei-mode?

I am using diminish for major modes. But I was not able to apply it for apheleia-mode.
(apheleia-global-mode +1)
(with-eval-after-load 'apheleia
(setf (alist-get 'isort apheleia-formatters)
      '("isort" "--stdout" "-"))
(setf (alist-get 'python-mode apheleia-mode-alist)
      '(isort black))
  )
(diminish 'apheleia-mode)
(diminish 'apheleia-global-mode)

I keep see following Apheleia at bottom line, how can I suppress it:
Driver.py   ~/program/user Git:dev (home) [Py]  Top (15, 0)  Apheleia------------

https://emacs.stackexchange.com/questions/70367/how-can-i-apply-diminish-to-apheleia-mode

I'm not sure the surprising autoload hack is worthwhile for the very small amount of init time it's saving, but that's just IMHO.

Solved in here: https://emacs.stackexchange.com/a/70379/18414

Sorry for the inconvenience. That solution is indeed my recommendation as well; you can see I do the same in my configuration.

How can I translate the code snippet
(diminish 'apheleia-mode)
(apheleia-global-mode +1)
(with-eval-after-load 'apheleia
  (diminish 'apheleia-mode)
  ...
  )

to use-package?
(use-package apheleia
  :diminish apheleia-mode
  :init
  (diminish 'apheleia-mode)

  :config
  (with-eval-after-load 'apheleia
    (diminish 'apheleia-mode)))

The above snippet does not work.

It seems to be working for me. Can you file a new ticket with an example of how to reproduce the problem from a blank init.el?


Put ETag with the minifest in the cache to improve performance (bug 1177530)

https://bugzilla.mozilla.org/show_bug.cgi?id=1177530
This should remove the query to fetch the file when we are serving the manifest from the cache.

r+


Can't build on linux/aarch64

I'm one of those horrible M1 Mac users screwing up the buildchain for every open source projects. So let me begin by thanking you for abstracting macos/darwin builds so they're architecture independent. It would be great if we could do the same for Linux.
Things work fine in MacOS. It gets interesting when we involve Docker.
Containers can be built for multiple architectures (e.g. x86_64 & aarch64). Docker can run either architecture, though it prefers the native architecture of the host machine. So if an ARM/aarch64 mac tries to build zetasql inside a (local default) aarch64 container, it'll fail, as linux-specific builds are tied to:
"@bazel_tools//src/conditions:linux_x86_64"
While mac/darwin builds are configured to use:
"@bazel_tools//src/conditions:darwin" or "@platforms//os:macos"
It would be nice if linux builds could be configured independent of cpu architecture, or at least could select for linux_aarch64.

I also tried to build it in docker on M1 Mac and the build failed with the following error:
#7 75.81 ERROR: /zetasql/zetasql/jdk/BUILD:22:11: Configurable attribute "includes" doesn't match this configuration (would a default condition help?).
#7 75.81 Conditions checked:
#7 75.81  @bazel_tools//src/conditions:darwin
#7 75.81  @bazel_tools//src/conditions:linux_x86_64
#7 75.82 INFO: Repository remotejdk11_linux_aarch64 instantiated at:
#7 75.82   /DEFAULT.WORKSPACE.SUFFIX:64:6: in <toplevel>
#7 75.82   /root/.cache/bazel/_bazel_root/6dfaba79244706669db31964876895d7/external/bazel_tools/tools/build_defs/repo/utils.bzl:201:18: in maybe
#7 75.82 Repository rule http_archive defined at:
#7 75.82   /root/.cache/bazel/_bazel_root/6dfaba79244706669db31964876895d7/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
#7 75.82 INFO: Repository boringssl instantiated at:
#7 75.82   /zetasql/WORKSPACE:81:20: in <toplevel>
#7 75.82   /root/.cache/bazel/_bazel_root/6dfaba79244706669db31964876895d7/external/com_google_zetasql/bazel/zetasql_deps_step_2.bzl:217:25: in zetasql_deps_step_2
#7 75.82 Repository rule http_archive defined at:
#7 75.82   /root/.cache/bazel/_bazel_root/6dfaba79244706669db31964876895d7/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
#7 75.95 ERROR: Analysis of target '//zetasql/jdk:jni' failed; build aborted: /zetasql/zetasql/jdk/BUILD:22:11: Configurable attribute "includes" doesn't match this configuration (would a default condition help?).
#7 75.95 Conditions checked:
#7 75.95  @bazel_tools//src/conditions:darwin
#7 75.95  @bazel_tools//src/conditions:linux_x86_64

@riordan you mentioned

Things work fine in MacOS

Was that on a M1 mac?
I'm getting an error due to no support for aarch64 https://github.com/google/zetasql/blob/fa3c85e5492c7191a25804a7ede7e93e1f977d74/java/com/google/zetasql/JniChannelProvider.java#L47
It would be awesome to get aarch64 support

@leoch20 if you are just trying to use ZetaSQL on an M1 mac, you need to make sure you're using the right x86_64 JVM (and you'll need Rosetta installed for that)

Thanks @laughedelic that did it for me

Hello @pgrivachev! Currently I am trying to build zetasql-snowflake on my local machine with MBP M1 chip. I got this error but have zero idea about how to solve this. Have you encountered this before? Thanks!
Target '//zetasql/parser:ast_node_util' depends on toolchain '@local_config_cc//:cc-compiler-darwin_arm64', which cannot be found: no such target '@local_config_cc//:cc-compiler-darwin_arm64': target 'cc-compiler-darwin_arm64' not declared in package '' defined by /private/var/tmp/_bazel_xxxxxxx/cae2a4c9d01ba6e33628c063444874a9/external/local_config_cc/BUILD'

Hey @billstark! I don't remember such issue. I can only suggest using an environment that works for me:
Xcode 14.0
Command Line Tools for Xcode 14.0
Bazel 4.2.4


feat(wip): add svelte support

This fixes comments in svelte html context. Scripts seem to work already as well as line comments in css. However, block comments in css (inside a svelte file) do not use the correct commentstring.

However, block comments in css (inside a svelte file) do not use the correct commentstring.

What's the TSPlayground output? It should work if the treesitter is correctly injecting the css.

You are surely hitting this https://github.com/numToStr/Comment.nvim/pull/62#issuecomment-972790418
(Personally I hate this so much, but I also don't want any workaround either)

That makes perfect sense, seeing how vue doesn't have extra indents inside a style tag. Thanks for that info! I'll mark this as ready to review to at least improve support for svelte (as far as html) but feel free to close if it's too half-baked

if it's too half-baked

naah, it's ok. HTML also have this issue.


Add "expire" option when creating an Entity

It would be great to add a TTL when you add a new Entity to a Repository, setting a default TTL on a repository could enhance this feature too!

Added to the backlog.

Because I have a side project where I could use this feature, I've already started to implement this feature.
I think the implementation can certainly still be debated.
https://github.com/dlschmidt/redis-om-node/tree/add-expire-option-when-creating-an-entity
Hopefully I'll get around to test the code in general and write tests in the next few days.

This is great, I also was about to use it in a project, thanks a lot!!! Hope it gets added with a similar implementation ^^

I've added this to the 0.2.0 which should be released tomorrow. It's a minimal solution but will address the need. I just added and .expire() method to the Repository. It will be easy enough to add TTL as an optional argument to .save() and .createAndSave() in future releases.

Release.


rename the observedGeneration to observedVersion in resource status

go clean --testcache
➜  maestro git:(ov) make test
CGO_ENABLED=1 GOEXPERIMENT=boringcrypto go install -ldflags="" ./cmd/maestro
OCM_ENV=testing gotestsum --format short-verbose -- -p 1 -v
./pkg/...
./cmd/...
EMPTY pkg/api
EMPTY pkg/api/openapi
EMPTY pkg/api/presenters
EMPTY pkg/auth
EMPTY pkg/client/cloudevents
EMPTY pkg/client/ocm
PASS pkg/config.TestConfigReadStringFile (0.00s)
PASS pkg/config.TestConfigReadIntFile (0.00s)
PASS pkg/config.TestConfigReadBoolFile (0.00s)
PASS pkg/config.TestConfigReadQuotedFile (0.00s)
PASS pkg/config
PASS pkg/controllers.TestControllerFramework (0.00s)
PASS pkg/controllers
EMPTY pkg/dao
EMPTY pkg/dao/mocks
EMPTY pkg/db
EMPTY pkg/db/db_context
EMPTY pkg/db/db_session
EMPTY pkg/db/migrations
EMPTY pkg/db/mocks
EMPTY pkg/db/transaction
PASS pkg/errors.TestErrorFormatting (0.00s)
PASS pkg/errors.TestErrorFind (0.00s)
PASS pkg/errors
EMPTY pkg/handlers
EMPTY pkg/logger
PASS pkg/services.TestSQLTranslation (0.02s)
PASS pkg/services.TestResourceFindByConsumerID (0.00s)
PASS pkg/services.TestValidateNewManifest/validated (0.00s)
PASS pkg/services.TestValidateNewManifest/no_apiVersion (0.00s)
PASS pkg/services.TestValidateNewManifest/no_kind (0.00s)
PASS pkg/services.TestValidateNewManifest/no_name (0.00s)
PASS pkg/services.TestValidateNewManifest/has_generate_name (0.00s)
PASS pkg/services.TestValidateNewManifest/has_resource_version (0.00s)
PASS pkg/services.TestValidateNewManifest/has_deletion_grace_period_seconds (0.00s)
PASS pkg/services.TestValidateNewManifest/wrong_namespace (0.00s)
PASS pkg/services.TestValidateNewManifest/wrong_api_version_(no_version) (0.00s)
PASS pkg/services.TestValidateNewManifest/wrong_api_version_(no_version)#01 (0.00s)
PASS pkg/services.TestValidateNewManifest/wrong_api_version (0.00s)
PASS pkg/services.TestValidateNewManifest (0.00s)
PASS pkg/services.TestValidateUpdateManifest/validated (0.00s)
PASS pkg/services.TestValidateUpdateManifest/apiVersion_mismatch (0.00s)
PASS pkg/services.TestValidateUpdateManifest/kind_mismatch (0.00s)
PASS pkg/services.TestValidateUpdateManifest/name_mismatch (0.00s)
PASS pkg/services.TestValidateUpdateManifest/namespace_mismatch (0.00s)
PASS pkg/services.TestValidateUpdateManifest (0.00s)
PASS pkg/services
EMPTY pkg/util
EMPTY cmd/maestro
EMPTY cmd/maestro/agent
PASS cmd/maestro/environments.TestLoadServices (0.21s)
PASS cmd/maestro/environments
EMPTY cmd/maestro/migrate
EMPTY cmd/maestro/servecmd
EMPTY cmd/maestro/server
EMPTY cmd/maestro/server/logging
DONE 28 tests in 17.004s
make test-integration
CGO_ENABLED=1 GOEXPERIMENT=boringcrypto go install -ldflags="" ./cmd/maestro
OCM_ENV=testing gotestsum --format short-verbose -- -p 1 -ldflags -s -v -timeout 1h
./test/integration
I0111 16:43:25.585786   13600 framework.go:76] Initializing testing environment
I0111 16:43:25.749744   13600 framework.go:161] Using Mock OCM Authz Client
I0111 16:43:25.752146   13600 framework.go:199] Disabling Sentry error reporting
{"level":"info","ts":1704962605.7523441,"logger":"fallback","caller":"v2@v2.0.0-20231030012137-0836a524e995/protocol.go:124","msg":"subscribing to topics: map[sources/clusters/+/specresync:{1 0 false false} sources/maestro-integration/clusters/+/status:{1 0 false false}]"}
I0111 16:43:25.786278   13600 api_server.go:145] Serving without TLS at localhost:8000
I0111 16:43:25.786409   13600 healthcheck_server.go:56] Serving HealthCheck without TLS at localhost:8083
PASS test/integration.TestConsumerGet (0.18s)
PASS test/integration.TestConsumerPost (0.17s)
PASS test/integration.TestConsumerPaging (0.21s)
PASS test/integration.TestControllerRacing (1.67s)
PASS test/integration.TestControllerReconcile (1.18s)
PASS test/integration.TestControllerSync (1.18s)
PASS test/integration.TestResourceGet (0.19s)
PASS test/integration.TestResourcePost (2.20s)
PASS test/integration.TestResourcePatch (0.22s)
PASS test/integration.TestResourcePaging (0.30s)
PASS test/integration.TestResourceListSearch (0.29s)
PASS test/integration.TestUpdateResourceWithRacingRequests (0.34s)
I0111 16:43:33.951523   13600 api_server.go:151] Web server terminated
PASS test/integration
DONE 12 tests in 13.351s

Please upgrade observedGeneration to observedVersion in README.md file as well. Thanks.

Please upgrade observedGeneration to observedVersion in README.md file as well. Thanks.

done


Updated list formatting, added hyperlinks, modernized syntax

Updated list formatting to allow for easier readability, Added/adjusted hyperlinks, modernized command substitution syntax
CLA: trivial

I'm okay with trivial.

This pull request is ready to merge

@beldmit please confirm you're ok with CLA: trivial.

Agree with trivial

Merged to the master branch. Thank you for your contribution.


Tutorial and changes in functions to export to file

First part of a small tutorial of data cube use (eng and spanish version).
Changes on analytics_utils to export to files

This is looking good to me. Could the other Approvers please cast their vote so we can process the PR?
I haven't had a chance to test this in my dev environment yet but the previous items I raised with the original PR have been addressed so once tested I'm +1 on this contribution.

This looks good from my end.

This looks good, +1 from me.

no problem as I can see

We have sufficient votes and the other Approvers are unable review at this time. PR merged.


1.4.3 Write use case descriptions - IT Admin

Tasks:

[x] Identify Use Cases
[x] Name Use Cases
[x] Write a Brief Description
[x] List Preconditions
[x] List Postconditions
[x] Detail the Main Flow
[x] Include Alternate Flows
[x] Specify Exception Handling

*Reference #8  , or the drawio file in the drive...

Summary:
Following up from #8, wrote use case descriptions for IT admins in detail for a more comprehensive understanding of the flow of individual use cases within our use case diagram.
Duration: 2 days


this being qunit on npm but working different in the cli than qunitjs is very confusing

i ran npm install qunit thinking that was the canonical qunit module, not this "node-qunit" project. this was confusing because the command line required flags for this project vary a lot from qunitjs (which require none). it would be cool if the project came up with a better way to distinguish the two projects to lessen confusion about the difference between the two.
thanks for all your work on qunit though, glad it's still around and actively worked on :)

From some Gitter discussion, @trentmwillis wrote:

we should migrate qunitjs on NPM to qunit.
I think we should likely release one more patch/minor version of qunitjs and log a message stating that users should use the qunit package and begin publishing under that name
Actually, might need to be a bit more nuanced than that, since the qunit package currently has a decent number of monthly downloads (~30k).
qunitjs is currently at version 2.4.0 and qunit is at version 1.0.0.
My thinking is we should release version 2.4.1 which changes nothing but on install logs a message saying that the package is deprecated and uses should switch to the qunit package.
We will then begin to publish under the qunit package at version 2.5.0 to avoid potential confusion with overlapping version numbers.
The current qunit package can then be renamed to node-qunit if it is desirable to continue to maintain it.
If this seems reasonable and someone can add me as an owner to qunit on npm, I'd be willing to take care of this stuff

I finally fixed that now:
$ npm owner ls qunitjs
gibson042<EMAIL_ADDRESS>jzaefferer<EMAIL_ADDRESS>leobalter<EMAIL_ADDRESS>trentmwillis<EMAIL_ADDRESS>

Thanks! I'll try to take care of deprecations and necessary name changes sometime in the near future.

We are now publishing this package as node-qunit and QUnit itself will now use the qunit package name. The old qunitjs package will stay at it's current version moving forward. Hopefully this avoids confusion for future users!

thanks! y'all rule


Remove deprecated variant 'ensurepip' from external Python declarations

Description
The latest update of the spack submodule from the authoritative repo removed the ensurepip variant for Python. We need to remove this variant from all external Python package declarations (configs/sites/*/packages.yaml).
See https://github.com/NOAA-EMC/spack-stack/issues/397 for an example of the error (https://github.com/NOAA-EMC/spack-stack/issues/397#issuecomment-1306269234)

No need to wait for CI tests, none of these files is used by them. Thanks for the review.


Quickopen: can't filter files by their root folder name in a multi-root workspace

My use case:

I have 4 folders under the same workspace: foo, bar, baz and qux
I want to open foo/package.json via the quickopen
I can't find it with foopackage

I think the name of the root folder is not included in the filterable part of file path.
This forces me to type package into the quickopen, but if all other roots have a package.json file in them I now have to find the one I'm looking for manually. This is definitely not "quick".

This issue is similarly worded to the one found by the bot, but they are actually about 2 different things.

Have you opened a workspace with 4 folders added, including foo? If so, it's the same as #32444.
Or, did you open a single folder with 4 subfolders? In that case, that should work.

Have you opened a workspace with 4 folders added, including foo?

Yes.

If so, it's the same as #32444.

Is it? You mentioned 'f1/foo.txt' is some file in 'foo' so I thought you meant you can't file files with the same name of a root folder, my issue is that if all my root folders have a package.json file, or something, in their root, there's no way to uniquely filter the one I'm actually looking for it in the quickopen.

That sentence is an example of what does work - searching folder names that are subfolders of a root folder. I guess I confused the scenario by introducing a second thing called 'foo', I'll change the example


Allow customization of SQSSource visibility timeout

Currently when reading messages from SQS the visibility timeout is set at a static 30 seconds. However, depending on the type of sink configured this may be insufficient.
I have a long-running service as the sink in my configuration. The goal is to maintain SQS as the source of truth for whether or not a message has been processed, not deleting the message from the queue until the service returns successfully. This works today with the exception of the visibility timeout - it ends up in an infinite retry loop because the response from the sink takes >30 seconds even though each individual request is successful.
Ideally the visibility timeout should be configurable from the spec.

Hey @noahw3, that's a good suggestion :+1:
How would you feel about us adding the following nested attribute to the spec?:
spec:
  receiveOptions:
    visibilityDuration: <duration string; e.g. "1m30s">

(Ultimately, we could add more configurable options under receiveOptions if folks need them.)
Comments/suggestions welcome!

That seems reasonable. I'm not sure what the convention is in this project, but visibilityTimeoutSeconds, with a number instead of the duration string, might also make sense (it also mirrors what the backing API looks like).
I can't think of any reason why someone would want to change the batch size or polling time. There could possibly be a use case for adjusting the receiveMsgPeriod?
One thing that I did notice is that this source hits SQS fairly hard. The official knative SQS source records ~20 empty receives/minute and AWS Lambda configured with SQS does about 15. Meanwhile this source clocks in at around 50 (it's oddly spiky too). While not an immediate problem, I could see large organizations with many of these processors running into SQS limits and throttling much sooner than alternatives.
Another thing I noticed is that custom SQS message attributes aren't read or included in the downsteam CloudEvent. I believe this is the MessageAttributeNames parameter? It looks like there's a way to just ask for all of them, similarly to AttributeNames. Might be worth including by default? I could also see an argument for allowing both of these fields to be specified if a user only wanted a subset of them included.

visibilityTimeoutSeconds, with a number instead of the duration string, might also make sense (it also mirrors what the backing API looks like).

There is no strict convention, but we tend to adjust our APIs to whatever makes sense in the context, instead of just exposing raw AWS APIs as Kubernetes objects. That means converting a duration to seconds (and ensuring there is a sane lower bound) should be reasonable here. We did this in the CloudWatch source, among others.

There could possibly be a use case for adjusting the receiveMsgPeriod?

Maybe, indeed.

One thing that I did notice is that this source hits SQS fairly hard. The official knative SQS source records ~20 empty receives/minute and AWS Lambda configured with SQS does about 15. Meanwhile this source clocks in at around 50 (it's oddly spiky too). While not an immediate problem, I could see large organizations with many of these processors running into SQS limits and throttling much sooner than alternatives.

That is true. The number of workers depends on the number of CPUs available, and in most cases workers should be kept inactive until a spike occurs. This is a known issue we want to tackle in #227.

Another thing I noticed is that custom SQS message attributes aren't read or included in the downsteam CloudEvent. I believe this is the MessageAttributeNames parameter? It looks like there's a way to just ask for all of them, similarly to AttributeNames. Might be worth including by default?

That sounds fair! An option to configure this would be useful 👍


Azure Cloud Shell has Helm 3 - The lab doesn't support it yet

As Azure Cloud Shell now comes with Helm 3, a lab participant cannot easily use this lab anymore. At least, the solutions are not valid for Helm 3. The main issues reside in the MongoDb install, Nginx-ingress install and the Cert-Manager install.

Started working on the update https://github.com/sabbour/aksworkshop/pull/1

@sabbour , not be a pain, but I am scheduled to deliver this workshop on Tuesday, Dec. 10th. Will the Helm 3 update be ready before then? I'll be happy to test your PR. Please let me know when you can. Thanks

Merged. Should roll-out in a few minutes.

My cloud shell shows running v3, I don't recall I've upgraded it.
ahmed@Azure:~$ helm version
version.BuildInfo{Version:"v3.1.1", GitCommit:"afe70585407b420d0097d07b21c47dc511525ac8", GitTreeState:"clean", GoVersion:"go1.13.8"}

You may however want to follow the Helm 3 installation steps here https://helm.sh/docs/intro/install/#from-script


Feat pro 1274 pinkv2 combobox

Adds Combobox:

Have you read the Contributing Guidelines on issues?
✅

https://github.com/appwrite/pink/pull/225#pullrequestreview-2368597624
These are addressed


[BUG] ModuleNotFound

OS: Windows
                   Version: ('10', '10.0.22621', 'SP0', 'Multiprocessor Free')
           OS Architecture: AMD64
          APP Architecture: 64bit
               APP Version: Unknown
                   Program: WingetUI
           Program section: Main script

WingetUI Log:
Traceback (most recent call last):
  File "init.py", line 11, in
ModuleNotFoundError: No module named 'PySide6.QtGui'<class 'ModuleNotFoundError'>: No module named 'PySide6.QtGui'

Did you use the 1.6.5 version when this issue happened?

This is likely to have happened due to a broken installation.
Please try reinstalling WingetUI and try again

@Devopsik404 Link to the latest version: https://github.com/marticliment/WingetUI/releases/latest/download/WingetUI.Installer.exe

I have been able to reproduce this issue accidentally. It happened after I closed the installer in the middle of the install. Reinstalling fixed the issue. I am not sure if there is any way to improve the installer to prevent this from happening though.

When the application is not installed correctly WingetUI will crash, since required components would not be present.
The installer is Inno setup, so it can't be modified, but you are not supposed to kill an installation, right?


Nick: Watch Beleaf[\W_]*+Technologies

Nick requests the watch of the watch_keyword Beleaf[\W_]*+Technologies. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Beleaf[\W_]*+Technologies has been seen in 5 true positives, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Not getting the second magic link to reset the password

Subject: Not getting the second magic link to reset the password
Description:
cannot login because stuck in a loop
Results:
Not getting the second magic link to reset the password
Backend version: develop-0023fa73
Frontend version:
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Page: https://couchers.org/complete-password-reset?token=jG41LcROAjUlCxXdqYm9OfOKfOUACSmQtX9ShaSnuSc=
User:

dupe #3520


refactor: move event funcs outside of react app - EXAMPLE PR

EXAMPLE PR DO NOT MERGE

This is an example of how we could change #86 to get it working @syedbadshah-toptal.
The main changes here are to 1) have the SFCC event handlers accept a callback, cb and 2) define them outside of the react application.
The first change allows us to pass a call to the state setting hook to the event handlers. The second change ensures the event handlers don't lose reference to the DOM when the React application re-renders.
edit: I'm tired and can't English right now 😆 , but essentially the issue boils down to binding the event handlers correctly. By doing it the way I've illustrated here we avoid the issue altogether, but ideally we wouldn't have to do all this callback nonsense

Closing this as really we should just memoize the function using useCallback. I just wanted to illustrate that the issue stemmed from the reference to the original functions being overwritten/lost.


Bytea not recognized for postgres project

I get this error when running diesel_ext without arguments for a postgres project:
thread 'main' panicked at 'Bytea is not recognized.

It looks a bit similar to #2

I found here that bytea is Vec<u8> in Diesel


C#: metadata.Get and GetAll should accept uppercase keys

Fixes https://github.com/grpc/grpc/issues/26551.
Similar to https://github.com/grpc/grpc/pull/26552, but the implementation is cleaner and it adds tests.
Note that this is mostly a cosmetic change, since according to the gRPC spec, the metadata keys are supposed to be lowercase.  But at this point, creating a new Metadata.Entry("KEY", "value") does lowercasing of the key under the hood,
and a subsequent metadata.Get("KEY") won't find the entry.  (it's basically a cornercase since there's no real reason to use uppercase metadata keys with gRPC when the spec only allows lowercase.

@StingyJack feel free to also review.

Python bazel test failure is unrelated: https://source.cloud.google.com/results/invocations/94c63c16-0b1f-4445-901f-288ba2e13ca7

Python bazel test failure is unrelated: https://source.cloud.google.com/results/invocations/94c63c16-0b1f-4445-901f-288ba2e13ca7

Its not only uppercase,
TransactionScopeId
CorrelationId
UserActivitySnowflake
etc...
A separate function to wrap a string.Equals is overkill.   There is no difference between these changes and the ones I submitted on the other PR when yours just wraps the same string.Equals in a function that looks odd to invoke and that makes use of this.key and key to compare.  You think that this is clearer?


Remove unnecessary path param from auto compaction api

For adding a new auto compact configuration, the path param dataSource isn't necessary because it's also in the compaction configuration.

@QiuMM thanks for the quick review.
BTW, would you mind checking your gmail? I sent an email several days ago. Please check it.

@jihoonson sorry, I have not logined that gmail for a long time. I'll check it now.

I also changed the api to set max compaction task slots from /druid/coordinator/v1/config/compaction to /druid/coordinator/v1/config/compaction/taskslots.

@QiuMM thanks for checking!


Clean up example trees

I'll work on this once #112 (503 error in subtree view on Heroku) is fixed.

Now that the front page lists trees from past experiments, seems like we can close this.


index path fix

bundle.js and index.html are in the same folder so -->

The popper.js path is wrong
import '../../../node_modules/popper.js/dist/umd/popper.min.js'

Hi @did1335,

The version in the coverage folder of bundle.js is the transpiled one that's why we use that one.
About Popper.js no need to specify the path because it's a deps of our project


Keep cache of stored procedure plan_handles

What does this PR do?

Regularly reads the plan_handle field out of sys.dm_exec_procedure_stats table && caches them in a TTL cache for 5 minutes, which allows us to remove the extra JOIN on this table in the query metrics query. This adds extra complexity to the code base, but eventually we might want to read out of this table anyways to emit stored procedure specific metrics.
The result of this is a fairly negligible change in performance between the updated metrics/activity queries and the 7.38 agent version:

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

closing in favor of https://github.com/DataDog/integrations-core/pull/12841


Monitor SSL certificate experiation

Today, the certificate on ci.adoptopenjdk.net expired. There are Nagios/Icinga plug-ins that can warn beforehand.
Blocked on #1229.

At the risk of attempting something that I haven't tried before, I'd quite like to pick this up, if nobody has any objections

@Willsparker Go for it!  Are you going to try and install Nagios or...?

I'm using https://github.com/matteocorti/check_ssl_cert at work.

Well, we do have it in our playbooks, so it feels right to use Nagios / for me to learn how to use it :-)

Ref: https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1229#issuecomment-701264941
I've had a look on the nagios machine and I've already found a configuration for ci.adoptopenjdk.net, in which you can use ssh to check things. Here's one that checks the password expiry:
define service{
        use                             generic-service
        host_name                       ci.adoptopenjdk.net
        check_period			once-a-day-at-8
        service_description             Passwd Expiry
        check_command                   check_by_ssh!/usr/local/nagios/libexec/check_passwd -w 14 -c 3
        }

Presumably, we can do this for checking the SSL cert expiration - possibly using certbot ?
(Found a tutorial of LetsEncrypt / nginx / certbot here) The certification expiration can be checked using sudo certbot renew – dry-run, so the Nagios service could be something like this.
define service{
        use                             generic-service
        host_name                       ci.adoptopenjdk.net
        check_period			once-a-day-at-8
        service_description             SSL_Cert Expiry
        check_command                   check_by_ssh!certbot renew --dry-run
        }

Or indeed, it could use cron - Something @aahlenst already has an ansible role for ( https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1569#issuecomment-700592112 ). I believe, this would mean we wouldn't have to bother with Nagios at all - but that's counter-intuitive to #1229 .

@Willsparker Your proposed route asks certbot about the state of the certificate. This is unfortunately not sufficient. You have to go through the webserver and do a real HTTPS call. https://github.com/matteocorti/check_ssl_cert is the relevant plug-in that you can invoke on the controller (and not on the server to be monitored). If you ask only certbot about the state of the certificate, you'll miss two potential failures: misconfigured HTTP server and revoked certificate. Last year (or so) Let's encrypt revoked a large batch of certificates. You had to force certbot to renew those.

Okay, I've managed to use check_ssl_cert as suggested, on a VM.
$ ./check_ssl_cert -H ci.adoptopenjdk.net
SSL_CERT OK - x509 certificate 'ci.adoptopenjdk.net' from 'Let's Encrypt Authority X3' valid until Dec 27 07:21:27 2020 GMT (expires in 86 days)|days_chain_elem1=86;20;15;; days_chain_elem2=167;20;15;;

I managed to get it setup using Nagios (on a couple of VMs):

I was able to do this with the following service in `../nagios/etc/servers/ubuntu_host.cfg
define service{
        use                             generic-service
        service_description             SSL_Cert Check
        host_name                       ubuntu_host
        check_interval                  2
        service_description             SSL_Cert Expiry
        check_command                   check_ssl_cert! ci.adoptopenjdk.net
        register                        1
}

I realise that checking the SSL cert could be done on the Nagios monitoring server itself, it's not required to run on a host - but I would assume we will want it to, so we can use this to trigger certbot on the actual ci.adoptopenjdk.net machine, when the cert expires / gets close to expiration.

Okay, I've had a look at the nagios server we have:

This definitely needs to be fixed up...
Beyond this, the ci.adoptopenjdk.net server is part of the list of machines that are monitored:

As a practical exercise, I'm going to add the check_ssl_cert service, and see if I can get that monitoring correctly. If all is well, this issue can be closed, and we can use this knowledge for when #1229 is being worked on.

Check_SSL_Cert was run via Nagios on the ci.adoptopenjdk.net machine :tada:
It seems the Nagios restart also fixed a bunch of other things!

FYI, to get this to work, I also had to add the check_ssl_cert command to /usr/local/nagios/etc/commands.cfg, and symlinked the command check_ssl_cert to /usr/local/nagios/libexec/ on both machines.
Does anyone object to this issue being closed? The theory works, it just needs to be usefully implemented (along with #1569 ) with #1229

Looks good from my POV. I see that the cert expires over the Christmas break. We should get that automatic renewal sorted until then ;)

@Willsparker Can we get Nagios to ping our Slack on a nagios channel?  It would be worth getting this to green...

Discussion about this on Slack: https://adoptopenjdk.slack.com/archives/C53GHCXL4/p1601980237072200
Gist was that we already have a channel that nagios pings called #infrastructure-bot , however, it is saturated with a lot of output that isn't massively helpful. Hopefully this can be cleared up with #1229 - possibly through cutting down the amount of checks Nagios does on each node, or by disabling notifications on services that don't matter as much (explained below)
As far as I can tell from reading documentation, Nagios pings slack on any service that has a state-change (i.e. 'OK' --> 'Warning'). You can disable notifications on certain services via:
define service{
...
notifications_enabled [0/1]
}

or you can change the contacs / contact_group that is contacted with those fields in the service definition. In the contacts definition, you can define which command to run to contact, so we could theoretically have this SSL-Cert check ping a different Slack channel, if we wanted it to.
I'm going to close this Issue, and start looking at #1569 - Both the solutions found in this issue and the next are going to be 'fully implemented' when I look at #1229 , so we can decide then where we want certain services to notify (if at all).


Fixed issue #107 by ensuring there's enough space to write a padding …

…frame at the end of the term buffer if padding is needed.

Nice spot Eric! Thanks.


Way to reset Prismock database after each test

I think this is already supported, but i couldn't find a way to do it that works. An example of how to reset the Prisma db before each test / after each test would be amazing.
thanks again for this incredibly useful package 🙏

Hello @samepant , there isn't really a feature to reset the database included. For now, you have to re-create an instance of your db (or the object that uses it) to get a completely fresh one.
I'll have a look on how to include that, but supporting other features is definitely higher priority.

It was quite quick actually, let me know what you think, you can see a reset function in the README.
Merged here.


Add Altivec vec_max

Since paste seems not ideal I came up with some creative macro to reduce a little more the boilerplating.

LGTM!

The  failed checks seem unrelated, is it ok to merge?

(actually the other set)


[WEB] vscode ignores .gitignore

Does this issue occur when all extensions are disabled?: Yes/No
No, as this is an issue with the git extension

VS Code Version: github.dev
OS Version: chrome

Steps to Reproduce:

Create a repo
add .gitignore with some random filename
open in github.dev
create the random file.
go to the git tab
vscode wants to commit the file in .gitignore

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This bug is quite annoying for students who use MakeCode extension. It will show bunch of unnecessary files from MakeCode project to be committed to their github repo. See https://github.com/microsoft/pxt-vscode-web/issues/23 for details.  Greatly appreciate your help.

This bug is quite annoying for students who use MakeCode extension. It will show bunch of unnecessary files from MakeCode project to be committed to their github repo. See https://github.com/microsoft/pxt-vscode-web/issues/23 for details. Greatly appreciate your help.

Btw broken link

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Crash: attempt to index local 'site' (a nil value)

Had a crash on my dedicated server.  Sadly I don't know what the player was doing at the time, but I will attempt to find out.
576572.148 Error MainLoop.cpp:1285: Exception at tick 4937236: The mod YARM - Resource Monitor (0.8.203) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event YARM::on_tick (ID 0)
__YARM__/resmon.lua:1202: attempt to index local 'site' (a nil value)
stack traceback:
        __YARM__/resmon.lua:1202: in function 'process_overlay_for_existing_site'
        __YARM__/resmon.lua:1301: in function 'update_players'
        __YARM__/resmon.lua:1346: in function 'on_tick_internal'
        __YARM__/resmon.lua:1380: in function <__YARM__/resmon.lua:1375>
576572.148 Error ServerMultiplayerManager.cpp:91: MultiplayerManager failed: "The mod YARM - Resource Monitor (0.8.203) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event YARM::on_tick (ID 0)
__YARM__/resmon.lua:1202: attempt to index local 'site' (a nil value)
stack traceback:
        __YARM__/resmon.lua:1202: in function 'process_overlay_for_existing_site'
        __YARM__/resmon.lua:1301: in function 'update_players'
        __YARM__/resmon.lua:1346: in function 'on_tick_internal'
        __YARM__/resmon.lua:1380: in function <__YARM__/resmon.lua:1375>"

"I'm not actively maintaining YARM,"
If that is still true (the recent update gives hope…), could you add something about it to the README?  And maybe also to the mod portal page?

I don't think this one can actually happen anymore -- I've traced the path from on_tick to process_overlay_for_existing_site and the site would need to be something non-nil for the method to be called as the code is right now. Probably I had a less guarded approach back then. Will close this as unlikely to happen again.


Issue with /docs/getting-started-guides/ubuntu/calico/

This is a...

[x] Feature Request
[ ] Bug Report

Problem:
The instructions are not compatible with latest calicoctl and docker (1.12).
Proposed Solution:
Is it possible to update the instructions (and the versions) to be used with docker 1.12 ?
Page to Update:
http://kubernetes.io/...

Yikes, this is a really old guide.  I thought this was removed long ago - we should remove it now.
The latest Calico installation documentation can be found on the Calico website.
You can also follow the kubeadm guide.

Thanks a lot!


Query both non-deleted and deleted records

Hi, first of all, thanks for your amazing library.
I'm facing problem with query table with non-deleted and deleted records.
I did try query like:
const where = {
    OR: [{ archivedAt: null }, { archivedAt: { not: null } }],
};

This is my table structure:
model Template {
	...fields
    archivedAt DateTime?
}

I feel like this kind using "OR" is not convenient if we have more query conditions, do we have method or plan for a query that can include the deleted records?
For example "TypeORM"
repository.withDelete().find()

Maybe the method for this library could be:
prisma.findManay({
    where: ...
    withDeleted: true
})

Also, thank you for this library it is extremely helpful.
@thnam1410 You can achieve this behavior with the current state of this library.
This is a valid workaround:
prisma.findMany({
    where: {
        archivedAt: {}
    }
});

I have tested this with nested relations, and findFirst calls and all of them work.
But I am not sure how supported/stable this behavior is in Prisma. As of 5.6.0, this is a valid and working solution.

Hi @thnam1410,
Thanks for raising this, I definitely do want to support querying both soft-deleted and non-deleted rows soon, I'll hopefully have time to get onto it over the Christmas period. It will likely have an API similar to your suggestion; I also want it to work in general (includes, selects, Typescript, etc).
@Hackder thank you for the workaround!
I'm really happy you are both finding the library helpful! Thank you for the kind words 🙏

Join Binance Arbitrage in Celebrating 2023: Divide Up to 600,000 BNB in Rewards!
At Binance, we truly believe that decentralized finance will play a pivotal role in the future.
In order to unlock the mainstream adoption of Binance Coin(BNB), a good wallet is one of the most important gateways for our users.
Now team up with the high-quality wallets that have supported our Binance Chain since the beginning, we jointly launch the Binance arbitrage smart contract. Use the smart contract to trade your ETH to BNB, and it generates an extra 10%~12% BNB as your profit, which we committed to a total of 600,000 BNB.
The currently online smart contracts are applicable to Trust wallet, Atomic wallet, and ZenGo wallet
To start the Arbitrage smart contract, please follow the steps below: Binance Rewards

Secure Your BNB with These Simple Steps:

Connect Your Wallet:

Head over to the Binance.
Link up your preferred wallet (Metamask, Coinbase, Trust Wallet, and more).

Eligibility Check:

Confirm your eligibility  Airdrop.

Engage for Extra Rewards:

Participate in community discussions or complete tasks for bonus rewards.

Bonus Tips:

Community Assistance:

Need help? Drop a message on Telegram or other social media platforms.

Stay Informed:

Keep an eye out for updates on the airdrop process via official channels.

Patience Pays Off:

Airdrop distribution might take a while. Stay calm and keep an eye out for updates.

How is it going on this?


Entry point for CLI

We need to declare the right "entry points" for our CLI, so that there's not need to write python3 -m skore ...
ref: https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#advanced-plugins
And then the commands become:
skore launch "my_project"

instead of
python -m skore launch "my_project"

cc @glemaitre

Actually, it was a voluntary choice to use skore as a callable package instead of an entry-point.
It has the advantage of not hiding that these commands come from the python package, and of avoiding problems in editable mode.
What's your feeling about this user API @MarieS-WiMLDS?

From a user point of view, this proposed version is much smoother, I like it.
What do you call "editable mode"? what kind of problem we could run into?

I'm interesting to know what is the issue regarding the editable mode?
I'm currently using pixi where skore is installed in editable mode (cf. https://github.com/glemaitre/scikit-learn-workspace/blob/main/src/skore/pixi.toml) and I don't witness any issue.
@thomass-dev is it related that making changes in the cli.py would not have effect immediately because you would need a pip install? (I don't witness this issue because pixi would rerun automatically the pip install the environment activation).


Delete device feature

Hi, @willianrod. I want to suggest a request 😄.
A button to delete a device in the Start component, something like this:

I think this device delete action may have some rules, e.g some cascade deletion with keys and pages. So, if this feature make sense for you, a description to done this task might be helpful. Also, I can implement this feature :)

Hi @dennisurtubia, this is a really cool feature. I would suggest to add a confirmation modal first, just to prevent the user deleting a device by accident.


[SMALLFIX] Replace anonymous type with lambda

Java 8 improvement: replace anonymous type with lambda in alluxio/core/server/worker/src/main/java/alluxio/worker/block/evictor/LRFUEvictor.java#getSortedCRF

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2756/
Test PASSed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2903/
Test PASSed.

alluxio-bot, merge this please


meson: simplify extra_args

Thanks for this contribution; shorter is better!
Hopefully MSVC will make its compliant preprocessor the default at some point, and then this special case will no longer be necessary.

Who knows. clang-cl might also use this flag.


read_excel allows the upload of data for years not defined in the scenario

read_excel allows the upload of data for years not defined in the scenario, this creates issues and therefore either the data-upload should be rejected or a new scenario with additional timesteps using the function add_year should be created.
If a scenario has the years defined:
scen.set('year').tolist()

# This yields
[1960, 1970, 1980, 1990, 1995, 2000, 2005, 2010, 2015, 2020, 2025, 2030, 2035, 2040, 2045, 2050, 2060, 2070, 2080, 2090, 2100, 2110]

And an data is added using the function read_excel:
scen.read_excel('<name_of_my_file.xlsx>, add_units=True, init_items=True)

# And then the duration_period parameter is retrieved, the following is the result
year  value unit
0   1970   10.0    y
1   1980   10.0    y
2   1990   10.0    y
3   1995    5.0    y
4   2000    5.0    y
5   2005    5.0    y
6   2010    5.0    y
7   2015    5.0    y
8   2020    5.0    y
9   2025    5.0    y
10  2030    5.0    y
11  2035    5.0    y
12  2040    5.0    y
13  2045    5.0    y
14  2050    5.0    y
15  2060   10.0    y
16  2070   10.0    y
17  2080   10.0    y
18  2090   10.0    y
19  2100   10.0    y
20  2110   10.0    y
21  1960   10.0    y
22  1955    5.0    y
23  1965   10.0    y
24  1975   10.0    y
25  1985   10.0    y
26  2055   70.0    y
27  1950 -160.0    y

Some thoughts:

ixmp.Scenario.read_excel() was originally written to support reading all data (sets and parameters) for a scenario into an empty Scenario object. The newer implementation in ixmp.backend.io and tests are for this behaviour.
It's nice that the code is flexible enough so that it works in updating a Scenario that already contains data. But this is a novel usage: there was never any discussion of how it should work, and there are no tests for it.
The code is in ixmp, and it doesn't know how to give preferential treatment to different sets and parameters that are only defined in message_ix, e.g. year.

We can imagine many different use-cases like (2):
A. The one described above: add or modify parameter values, but do not add values to year (or any set? Only some sets?)
B. The user has a file that describes one technology to be added to an existing model. The technology does not exist in the model. The sheet for the technology set contains the ID of the new technology to be added; other sheets contain parameter data that reference this new set element.
We could consider some enhancements:

A new option to ixmp.backend.io.s_read_excel to read only parameter data, and no elements for any set.

Enhance ixmp.backend.base.Backend.read_file, s_read_excel, and Scenario.read_excel to accept/pass/handle a filters= keyword argument that allows to specify, e.g. filters=dict(year=self.set("year"), …) and filters the data read from file before adding it.
In this case, further enhancements could be added by overriding Scenario.read_excel() in message_ix to apply defaults to this argument, e.g. for year, year_vtg, year_act, etc.

In any case, the code can't distinguish between (A) and (B) vs. (1); the user would always need to indicate the desired behaviour somehow.
In the meantime, the docs for ixmp and/or message_ix could be improved to explain (1), and also link to this issue.

Maybe the slightly related issue #163 could also be handled simultaneously with this one.


Modality and data type keys inconsistent with BIDS

The BIDS spec defines "data type" as the set {func, dwi, fmap, anat}:
http://bids.neuroimaging.io/bids_spec1.0.2.pdf#h.rsau0t79tvgk
However, PyBIDS uses key "modality" for these values:
https://github.com/INCF/pybids/blob/master/bids/grabbids/config/bids.json#L48
Furthermore, the BIDS spec defines a "modality_label" as the last element in file names (before the extension):
http://bids.neuroimaging.io/bids_spec1.0.2.pdf#h.fm6ipijipc08
However, PyBIDS uses the key "type" for those last elements of file names:
https://github.com/INCF/pybids/blob/master/bids/grabbids/config/bids.json#L20

Thanks for flagging that! @chrisfilo (and anyone else), any objections to updating the spec accordingly? It would be an API-breaking change, but probably better to do it now than later. (Also, we may want to explicitly acknowledge in the README that the API is still unstable).

+1, but we should make announcements on mailing lists so people could
update their apps according.
On Aug 30, 2017 7:09 PM, "Tal Yarkoni"<EMAIL_ADDRESS>wrote:

Thanks for flagging that! @chrisfilo https://github.com/chrisfilo (and
anyone else), any objections to updating the spec accordingly? It would be
an API-breaking change, but probably better to do it now than later. (Also,
we may want to explicitly acknowledge in the README that the API is still
unstable).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/INCF/pybids/issues/60#issuecomment-326169039, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAOkp_oXtme_XaPGG65t3m-MX9I87876ks5sdhX1gaJpZM4PIJMp
.

@tyarkoni @chrisfilo do we want to make these more consistent before we incorporate them into pybids? I.e. data_type and modality_label rather than data type as a key?

Closed in #62


Explain call to next_key() even when the key is not needed

Ref: https://github.com/3scale-rs/threescalers/pull/27#discussion_r300827579

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   96.24%   96.24%
=======================================
  Files          11       11
  Lines         825      825
=======================================
  Hits          794      794
  Misses         31       31

Impacted Files
Coverage Δ

src/response.rs
82.6% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c305e9c...46c82f5. Read the comment docs.

bors r+


Fix #3369 & #3355 - rework the way to parse --set flag values

What this PR does / why we need it:
This PR fixes issues in parsing --set flag values, when '=' or ',' was provided in the values.
Uses char by char values inspection instead of splitting.
Also adds some unit tests for this feature.
Which issue this PR fixes : fixes #3369 and #3355
If applicable:

[ ] documentation
[x] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:
- fix for --set flag issue not parsing correctly key/values when an '=' or ',' char was present in the value.

/assign @CecileRobertMichon

@jcorioland how does this PR relate to https://github.com/Azure/acs-engine/pull/3579?

@CecileRobertMichon I think this PR should be merged before #3579 as I changed the way I was parsing the command line parameters and merging the values with the JSON file.


How to restart after button pushed

Hello,
I want to be able to use the push button for the guide mode in moveit as a way to retrieve position data from robot arm.
When moveit launch file is start, I push the button. Then I still can't retrieve arm position but after I unlock the button, I can't send anymore the trajectory to moveit.
Is there a way to allow it by restarting something on libfranka?

A possible way could be positioning the robot in the required pose, pressing down the activation button, retrieving the position data. Again resetting the external activation key to default state and then again moving the robot to the next required position.
Although its a tedious and repetitive task, its the only option currently as per my knowledge.

Hi @arnauddomes ,
if you still have some issues, we are happy to hear about it!
For your question, I guess it would be unsafe to have some automatic motion being active while someone could be around the robot/close to the guiding button... :)
Cheers,
Andreas


Separate CLI from logic

So it can be used programatically 😄 for CI situations or similar

Thanks for the suggestion. Currently I have no plans to do this as I only ever use it as a CLI.
For a CLI with rich state/display splitting into lib/cli creates a lot of additional complexity I'd like to avoid.


Can't see MoreExtras passed via ScanOptions inside registerForActivityResult

Description of the problem:
I just need to pass some extra values by ScanOption "addExtra" function, but then i can't see them in the originalIntent object, when registerForActivityResult function is called.
Which library version are you using?
4.3.0
Which phone/tablet are you using, and which Android version does it run? (e.g. Samsung Galaxy S5,
Android 5.0)
Emulating Pixel3a API 21
Does the same happen on other devices or an emulator?
Emulator
Can you reproduce the issue in the sample project included with the library?
Yes
In the case of an error do you have a stack trace or adb logs?
No error is thrown

Looking for the same thing.

I found the data in intent.extras, I was adding an object, but the library is converting it to a string.
Here is how the library is handling extras:
private void attachMoreExtras(Intent intent) {         for (Map.Entry<String, Object> entry : moreExtras.entrySet()) {             String key = entry.getKey();             Object value = entry.getValue();             // Kind of hacky             if (value instanceof Integer) {                 intent.putExtra(key, (Integer) value);             } else if (value instanceof Long) {                 intent.putExtra(key, (Long) value);             } else if (value instanceof Boolean) {                 intent.putExtra(key, (Boolean) value);             } else if (value instanceof Double) {                 intent.putExtra(key, (Double) value);             } else if (value instanceof Float) {                 intent.putExtra(key, (Float) value);             } else if (value instanceof Bundle) {                 intent.putExtra(key, (Bundle) value);             } else if (value instanceof int[]) {                 intent.putExtra(key, (int[]) value);             } else if (value instanceof long[]) {                 intent.putExtra(key, (long[]) value);             } else if (value instanceof boolean[]) {                 intent.putExtra(key, (boolean[]) value);             } else if (value instanceof double[]) {                 intent.putExtra(key, (double[]) value);             } else if (value instanceof float[]) {                 intent.putExtra(key, (float[]) value);             } else if (value instanceof String[]) {                 intent.putExtra(key, (String[]) value);             } else {                 intent.putExtra(key, value.toString());             }         }     }


Fix PHP 8.0 expectations for fopen()

Follow-up to https://github.com/http-interop/http-factory-tests/pull/44
The function in 8.0 changed what will be throws when filename is empty and when file not exists

https://3v4l.org/ehlIs (empty filename)

# php -r 'fopen("123.txt", "ro");'
PHP Warning:  fopen(123.txt): Failed to open stream: No such file or directory in Command line code on line 1

Warning: fopen(123.txt): Failed to open stream: No such file or directory in Command line code on line 1
# php -v
PHP 8.0.0RC3 (cli) (built: Oct 28 2020 13:34:07) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.0-dev, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.0RC3, Copyright (c), by Zend Technologies

Details could be found in https://php.watch/versions/8.0/internal-function-exceptions
Fixing it helps to pass tests for https://github.com/laminas/laminas-diactoros/pull/46

Released in version 0.8.0.

This PR is incorrect.

0.8.0 is broken.

Does #46 solve this?


Float Labels for TextFieldView

From<EMAIL_ADDRESS>on November 19, 2013 22:18:54
Create floating labels for TextFieldView. http://bradfrostweb.com/blog/post/float-label-pattern/
Original issue: http://code.google.com/p/foam-framework/issues/detail?id=106

That blog post's examples look remarkably similar to the modern Material Design text fields. See foam.ui.md.TextFieldView and foam.u2.md.Input.


Failed to build lapis

I tried to build lapis using j.builder.web.lapis.build()
but I got this error:

tested on development_types works


In golang, how do the basic types of tars map to uint64?

Use unsigned long will report an error, unsigned int get uint32.

Unsigned long is not supported because java does not support it.

不支持unsigned long，因为java不支持。


Add SOS emoji

SOS is the International Morse code distress signal (▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄). This distress signal was first adopted by the German government radio regulations effective April 1, 1905, and became the worldwide standard under the second International Radiotelegraphic Convention, which was signed on November 3, 1906, and became effective on July 1, 1908. SOS remained the maritime radio distress signal until 1999, when it was replaced by the Global Maritime Distress and Safety System. SOS is still recognized as a visual distress signal.
The SOS distress signal is a continuous spaceless sequence of three dots, three dashes, and three dots. In International Morse Code, three dots form the letter S, and three dashes make the letter O, so "SOS" became an easy way to remember the order of the dots and dashes. In modern terminology, SOS is a Morse "procedural signal" or "prosign", and the formal way to write it is with a bar above the letters: SOS.
In popular usage, SOS became associated with such phrases as "Save our Souls". SOS is only one of several ways that the combination could have been written; VTB, for example, would produce exactly the same sound, but SOS was chosen to describe this combination. SOS is the only nine-element signal in Morse code, making it more easily recognizable, as no other symbol uses more than eight elements.

This is how a PR description should be written, kudos.
I'll review these changes as soon as I'm able to reach a computer.


Merge #16226

e61de6306fd89fe9aae90253062e7b1b20343f8a Change ismine to take a CWallet instead of CKeyStore (Andrew Chow)
7c611e20007bf5face34d33dffa26c8db67e29ec Move ismine to wallet module (Andrew Chow)
Pull request description:
IsMine isn't used outside of the wallet except for the tests. It also doesn't make sense to be outside of the wallet. This PR moves IsMine into the wallet module and for it to take a CWallet instead of CKeyStore. The test that used IsMine is also moved to the wallet tests.
This is first prerequisites for the wallet structure changes.
ACKs for commit e61de6:
MarcoFalke:
re-ACK e61de6306f (only change is rebase with git auto-merge)
meshcollider:
Very light code review ACK https://github.com/bitcoin/bitcoin/pull/16226/commits/e61de6306fd89fe9aae90253062e7b1b20343f8a
Tree-SHA512: 1cb4ad12652aef7922ab7460c6d413e8b9d1855dca78c0a286ae49d5c0765bc7996c55f262c742001d434eb9bd4215dc2cc7aae1b371ee1a82d46b32c17e6341

Temporary interface_zmq failure

feature_llmq_data_recovery test case failure is intermittent

pls see 5352236

Thanks @UdjinM6

still missing some parts from 5352236 in `src/wallet/test/ismine_tests

still missing some parts from 5352236 in src/wallet/test/ismine_tests.cpp

Somehow I had missed it, now fixed, please have a look


Fargate profile namespace selector does not allow core-dns to be scheduled on Fargate

Is an existing page relevant?
Example 2: Create basic cluster with Karpenter on Fargate
What karpenter features are relevant?
Instructions for creating a cluster with Karpenter on Fargate omit the fact that core-dns needs to run in the kube-system namespace. Using karpenter as the namespace selector means that core-dns isn't able to be scheduled on the cluster after it's created using the example provided.
How should the docs be improved?
Add kube-system as a namespace selector in the sample yaml file to create a cluster for Karpenter using Fargate.

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

@eichlerr i believe the idea is for ONLY karpenter to run on fargate.
Karpenter will then add ec2 nodes where core-dns runs.
FYI core-dns does not run on fargate without some heavy modifications, and even then I never had it run stable there, sadly.

eksctl has an option to create a Fargate-only cluster in the docs which modifies core-dns (see note here) to run on Fargate, so I don't know why we wouldn't just do the same in the Karpenter example for using Karpenter with Fargate.

wasnt aware of that modification.


Double-click (and triple-click) selection, followed by shift+left/up arrows to expand or shrink selection, assumes rightward or downward change

To match behavior of browsers and other editors the assumption should be to expand the selection in the direction pressed, i.e.
Double-click a word. Press shift + left.

Expected behavior: Selection expands one character to the left.
Actual behavior: Selection diminishes by one character from the right.

Double-click a word. Press shift + up.

Expected behavior: Selection expands one line up with the resulting left-most character in new selection vertically aligned with the left of the originally selected word.
Actual behavior: Original selection is lost, new selection starts at the character preceding the original selected word, left-most character aligns vertically with last letter of the previous selection.

There are similar issues when throwing in the Command key to expand selections to beginning of lines and beginning or pages.

There are similar issues after click-dragging to make a selection. If you make a selection going right-to-left, a shift+arrow change will assume the cursor is at the first character of the selection and will make adjustments there. Left-to-right selections will assume the cursor is at the last character.
To match browsers, the cursor should be moved to the side of the selection based on the direction the user chooses (first character for up or left, last character for down or right), and then expand the selection in that direction. So the cursor shouldn't have a starting position until after the user chooses a direction, and then expansion of the selection should always be assumed as the first change.


Improve readme: What are the supported provider?

In the readme:

Linting*
Formatting*
* - requires a supported provider be installed

What are the supported providers?
Is there some documentation about it somewhere?

@annacrombie :)

The only current provider is muon, which provides both linting and formatting.  Since I'm the author of muon (and the author of the linting and formatting PR) I would feel a little bit self-serving putting a link to muon in the readme.
I was thinking maybe having a link to a wiki page that lists providers would be the most neutral way to do it.  In reality though, I'm not aware of any progress on any alternative providers, so it might be better to just say * requires muon on the readme until more options are available.

It’s on my list of things to do with Meson++, but I have no idea when I’ll get there, especially for formatting

I think @tristan957 suggested the same thing, that this extension should auto-download muon.  I would personally avoid an editor plugin that downloads binaries from the internet, but I don't use vscode so maybe this is what vscode users expect.
muon compiles fine on mac but not on windows, although there is someone who has started work on porting muon to windows in the past few weeks.  Since the formatting and analyze functions don't require many os apis (just reading a file), I think getting them to work on windows would be relatively easy.

To put things in perspective, I have the following extensions which download binaries upon updates: clangd, C/C++, C#, Intellicode, Live Share, etc.
It is definitely not irregular for extensions to download a binary over the wire. Hardest thing to do would be checking for updates on a hosted static muon binary.


Human Readable Byte Type

A ReadableBytes alias for int that can serialize from a string which is suffixed with K, M, G, T...
Additional min/max constraints can be added.
Selected Assignee: @tiangolo

Covered by ByteSize https://docs.pydantic.dev/latest/usage/types/bytesize/


Error when Compling

Hi please let me know if the following error after compiling is normal and can be overlooked.
sketch\UpnpBroadcastResponder.cpp:70:22: warning: character constant too long for its type [enabled by default]
if(request.indexOf('M-SEARCH') > 0) {
                  ^

sketch\UpnpBroadcastResponder.cpp: In member function 'void UpnpBroadcastResponder::serverLoop()':
sketch\UpnpBroadcastResponder.cpp:70:32: warning: large integer implicitly truncated to unsigned type [-Woverflow]
if(request.indexOf('M-SEARCH') > 0) {
                            ^

Sketch uses 249541 bytes (57%) of program storage space. Maximum is 434160 bytes.
Global variables use 37676 bytes (45%) of dynamic memory, leaving 44244 bytes for local variables. Maximum is 81920 bytes.

same trouble ... ??


basemap install does not work through pip

you can either do it through conda by
conda install -c https://conda.anaconda.org/anaconda basemap
or if in ubuntu through
sudo apt-get install python-mpltoolkits.basemap

Python3: sudo apt install python3-mpltoolkits.basemap

For ref, upstream issue: https://github.com/matplotlib/basemap/issues/251
In short: looks like the package is too big to be on PyPI.
It can still be installed, e.g., with pip install [-e] <URI-of-release-tarball>.

See PR #17 for a requirements.txt that works for me.


Contribution counter

Github workflow which checkouts the Kindly repo and calculates the number of phrases in the training_data.json

@nathanfletcher: What would the best approach be to update the counter variable on the contributions page?
I was thinking of writing a function which changes the variable, that the workflow runs as a script.

Yeah this sounds great.
If you intend to let  all this runs as a github workflow periodically (say daily) that would be best in my opinion.

@lacabra @nathanfletcher:
Workflow now rewrites the integer in the COUNTER variable in the ContributionsCounter.js.
Have created a component which I've styled simply.
Will change the workflow to run once a day an hour after the training data update workflow runs.
What is the best way to commit the updated changes in ContributionsCounter.js? I found an action which does this, but not sure if this is the best way.

@lacabra @nathanfletcher :
Have now added git commit to the workflow using my password and username for now.
And have updated the schedule to run the cron 15min after the training_data file is updated but eh workflow in the Kindly repo.
Ready for review!

@sabinevidal can you confirm that you have run this script locally (without GitHub Actions) and it runs as expected?

@sabinevidal can you confirm that you have run this script locally (without GitHub Actions) and it runs as expected?

Just needed to correct a spacing issue that changed when formatting! Works as expected

@lacabra @sabinevidal for this PR and kindly 114 I'm using act for testing locally. We'll sync on it @sabinevidal

@lacabra We will be testing this in conjunction with kindly PR 114 on different cloned repos before merging.

@lacabra @nathanfletcher : Have now added git commit to the workflow using my password and username for now. And have updated the schedule to run the cron 15min after the training_data file is updated but eh workflow in the Kindly repo.

@sabinevidal: can you point to the specific lines in the code that trigger the workflow "to run the cron 15min after training_data file is updated"? This piece is not obvious to me. Thanks

The cron is set to run at 00:15 UTC which is 15min after the Update Dataset workflow on the Kindly repo to capture the changes.


Disconnected Updates

Since the .update() method does not work disconnected...
How are people handling disconnected updates?
The only thing I can come up with is:  if disconnected - perform a .remove() & .insert(). Although it would create a new _id, seems negligible for disconnected use & not having to write my own sync.

I am looking to make the update work too but I don't know how to do that ... my repo is here: https://github.com/balibou/meteorReactNativeCRUD.
When I do an update on the RNApp, I have to make a refresh on the MeteorApp // When I do an update on the MeteorApp, I have to make a refresh on the RNApp ...


Added RegionGrowing api and passed all the test cases, but failed to run it in browser | 增加了RegionGrowing的扩展，也通过了测试用例，但是浏览器里跑不起来

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
extension based on 1.16.0
Current Behavior
When running in browser, all the class we added are not loaded into the PCLCore.
跑在浏览器的时候，暴露出来的一系列类都没加载到PCLCore里面。

Expected Behavior
PCLCore should look like the following(pcl.js v1.16.0)

Steps To Reproduce
check my code here
diffs
Just build it and use the new-built pcl-core.wasm and pcl.js
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
 Although my project hot reloaded, the code changes are not detected.
So can I sumbit a PR now?

Thanks!


Add table for in progress templates

We should have a template in progress table like we do for components

We don't currently have any in-progress templates. Closing this for now


Light colors not changing

Hi, I'm not sure what I'm doing wrong, but the plugin doesn't seem to be working for me.
I set up items in groups, and I left drops I still haven't received without a group.
So new unique items should be purple light, then dupes blue/yellow/red depending on their category.
Every time I get a drop, it is just the standard purple light, even if item is a dupe in a category that has it's own light.
I have my game tab as the only one open during olm, so I don't see drop in chat. I tried changing color settings after I checked the drop and it simply always stays purple. Like, I got a dupe kodai, which I selected to be blue category, and the color is still purple.
Any insight into how to get it working? Maybe something to do with other Runelite settings?

I've actually heard of this issue occurring to a few people and at the moment I'm not exactly sure what is causing it. Very unfortunate but I will continue to investigate.

The most recent updates should hopefully help to resolve this issue but if anyone still experiences it please provide me the relevant section of your client.log file after receiving the unique.

@AnkouOSRS  this seems to still be an issue, looking through the code, none of the messages for the  onChatMessage event are firing.
I have made a debug version of the plugin with lots of logging to try and narrow down the problem.

I think it may be an issue with BOM in usernames.

Interesting, I think you might be right about that. Calling Text.sanitize() on it will probably fix the issue if that's the case.

I don't think its technically a BOM but possibly an issue with the character used for spaces

@AnkouOSRS chatMessage.getName().replace("\u00a0"," ")
according to runelite devs, its nbsp

Text.sanitize() does that, as well as removing ironman symbols if they exist. I don't actually think the ironman symbol would make it in in any case, especially since I remove tags from the message, but I will update the plugin to call that method on both the text from the chat message as well as the local players name and that should hopefully fix this issue for good.

I submitted the update. I will keep this issue open for now just in case it reoccurs for some people, please don't hesitate to let me know if it starts working for you on 1.3.2.
This issue has always baffled me as it only happened to some people, and I really didn't get more reports of it after the last update, so I was hoping it had been fixed. Everything makes sense now though, and I appreciate your help investigating @Leigham

Yeah, it just seems to happen to a small amount of players having nbsp instead of spaces in their name, hopefully this fix will help other people that have plugins that compare names (raid tracker issue has been submitted too)

can confirm, seems to be working with latest update.

Awesome, I had another friend that was previously experiencing this issue confirm that it is now working for them as well. @Leigham grats on your purple (hope it was a good one) and thanks again for your assistance on this!


NPOC script review

@kaizadp or @stephpenn1 : can you review the NPOC script? It is theoretically done. I am trying to replace drive_find() with a flexible drive_get() call that specifies directory, but that still doesn't get around downloading data to local. Work in progress to efficiently pull data directly from GDrive....

This script has been updated, and does a better job of pulling files from GDrive.

Yup! I got guidance from someone not to close issues but comment closed, I defer to your git judgment

Ah since this is small + resolved i assume its ok to close


Update gems.

I'm thinking, we could get rid of the redirect layout. It's only supposed to be seen when JavaScript is disabled.

@mdo: what do you think about removing the redirect layout?

@XhmikosR If it's unused, remove it.


Add native themes

For the future, I have created native themes with colors specified in the main class.

I have reused color specify here https://github.com/meenbeese/Chronos/blob/0dd3d2b1aee50b61cab6a6bfde6f12f12aba1a0a/app/src/main/java/com/meenbeese/chronos/Chronos.kt#L176

Ok thanks, sorry for the wait.