Eliminate double-free in realloc'd memory

If memio->memory is freed, then there is a double-free error since that pointer was either already freed in the realloc call, or it is the same pointer as newmen and should not be freed.   The documentation of realloc(3) states:
If the area pointed to was moved, a free(ptr) is done.

I'm not sure why I haven't hit this before, but I had a couple of my tests start throwing double-free errors and valgrind confirmed that the pointer had already been freed at the point of the realloc call.

@gsjaardema I did the same thing, but disabled a different test.
What is failing for me is dap4_test/test_remote.sh (see issue #1220).

That is probably the one I intended to disable also…
..Greg
From: Ed Hartnett<EMAIL_ADDRESS>Reply-To: Unidata/netcdf-c<EMAIL_ADDRESS>Date: Wednesday, November 21, 2018 at 10:38 AM
To: Unidata/netcdf-c<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [Unidata/netcdf-c] Eliminate double-free in realloc'd memory (#1219)
@gsjaardemahttps://github.com/gsjaardema I did the same thing, but disabled a different test.
What is failing for me is dap4_test/test_remote.sh (see issue #1220https://github.com/Unidata/netcdf-c/issues/1220).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/Unidata/netcdf-c/pull/1219#issuecomment-440751778, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AL2vRRdgo5jm3x8sut3iOstnUV2sY266ks5uxY-kgaJpZM4YsCox.

Odd that I did not see this as part of
pr https://github.com/Unidata/netcdf-c/pull/1202

Can  I see one of your test cases that causes the double free?

The problem is that using -fsanitize with gcc, I see no such errors.
So, the problem is related to the program you are using.

I see the following:
s1018191:build(master)> gcc -fsanitize=address -o test-realloc -g test-realloc.c
s1018191:build(master)> ./test-realloc
=================================================================
==98893==ERROR: AddressSanitizer: attempting double-free on 0x614000000040 in thread T0:
    #0 0x107ac310d in wrap_free (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x5710d)
    #1 0x10740aee2 in main test-realloc.c:10
    #2 0x7fff5ba98014 in start (libdyld.dylib:x86_64+0x1014)

0x614000000040 is located 0 bytes inside of 400-byte region [0x614000000040,0x6140000001d0)
freed by thread T0 here:
    #0 0x107ac32d7 in wrap_realloc (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x572d7)
    #1 0x10740aed2 in main test-realloc.c:8
    #2 0x7fff5ba98014 in start (libdyld.dylib:x86_64+0x1014)

previously allocated by thread T0 here:
    #0 0x107ac2f53 in wrap_malloc (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x56f53)
    #1 0x10740aeb3 in main test-realloc.c:5
    #2 0x7fff5ba98014 in start (libdyld.dylib:x86_64+0x1014)

SUMMARY: AddressSanitizer: double-free (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x5710d) in wrap_free
==98893==ABORTING

Which shows the same issue that valgrind shows.  I also get the following even without sanitize:
s1018191:build(master)> gcc -o test-realloc -g test-realloc.c
s1018191:build(master)> ./test-realloc
test-realloc(123,0x7fff944de380) malloc: *** error for object 0x7ffd32c02950: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug
Abort trap: 6

I know this isn't NetCDF code, but it (I think) follows the same execution path as the NetCDF memio code.  It also matches the documentation of realloc as best I can see -- the free is not allowed since the memory has already been freed by realloc.

Could this issue be related to this (from docs/inmemory.md)?

If the NC_MEMIO_LOCKED flag is not set, then
the netcdf library will take control of the incoming memory.
This means that the user should not make any attempt to free
or even read the incoming memory block in this case.

If NC_MEMIO_LOCKED is set, then the reallocate is not called so that isn’t the issue.  Also, the memory freeing is inside netcdf code and has nothing to do with the client doing anything to the memory.

To make sure I understand, you are saying that your code does not set NC_MEMIO_LOCKED?
Correct?

Yes

Note that a run of ctest with or without -fsanitize will not catch any errors since the code in question is not covered by any of the existing NetCDF tests.  I added an abort() right after the realloc call and the test suite still passes.   This is in memio_pad_length
There is another realloc call earlier in the file and that one is called ( in memio_open) since if I add an abort(), it will cause four tests to fail.  It is also of note that this realloc does not do the calls to free and there are no memory leaks.
So, in summary, I think the pull request (without the test disables) is valid and should be applied.  Based on valgrind, -fsanitize, and the man page for realloc, and the other use of realloc in the same file, the memory should not be freed.

The reason that the code in question is not being tested is that the file that is being created for the in_memory test is smaller than the initial size of memory allocated in memio_create.  Due to matching the pagesize, the memory is allocated at 4096 bytes.  The size of the file is only 300 bytes, so the realloc is never called.
If we make a larger file by changing #define DIM1_LEN 800 in nc_test/tst_inmemory.c, then the resulting file will be larger than 4096 bytes and then memio_pad_length will be called and you should get a memory failure.
If the PR is then applied, the test will pass.


Strange blinking line in box-layout waveform

Description

When the audio plays in the multi-media search results a strange line can be seen blinking as it moves along the length of the waveform.
Reproduction

Search for any term.
Play the box audio in the multi-media search results.
See the line.

Screenshots

https://user-images.githubusercontent.com/16580576/182108069-c6310312-f681-4a9c-b702-e8ed3b791457.mov
Environment

Device: MacBook Pro
OS: macOS 12.5 Monterey
Browser: Firefox
Version: 103

Additional context

As this moves along the length of the waveform with the time, it might somehow be related to the progress bar.
Resolution

[ ] 🙋 I would be interested in resolving this bug.

Hi @dhruvkb ,
I am a student who needs to contribute to an OpenSource project in my coursework, so I was wondering if you can assign this to me.
This issue seems to be a good initiation of my journey towards contribution to FOSS projects.
Can you please assign this to me?

Sure @shishirgupta07, go ahead. If you need help feel free to comment here or send a message in the #openverse channel in the Making WordPress Slack workspace.
On a side note and just out of curiosity, which institute are you from?

@dhruvkb Thanks for assigning me , I'm from BITS Pilani.


Pr/1

Please answer these questions before submitting a pull request

Why submit this pull request?

[ ] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.

8.2.0

8.2.0新版本


Fix netty close when init count is 0

What is the purpose of the change
When netty client connect failed at init, org.apache.dubbo.remoting.transport.netty4.NettyConnectionClient.ConnectionListener#operationComplete will check connection is used. But NettyConnectionClient has not been initialized and count has not been set.
Fix https://github.com/apache/dubbo/issues/12658
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

@EarthChen @icodening PTAL


Support for instance norm and bilinear upsample

I have a model with bilinear upsample and instance norm layers. It seems the latest pip package does not currently support these layers. How can i build/install latest code and and convert the same model to keras format?
modnet_old.zip

Hi, you can clone this repo and install it with all the last changes. Also, I want to add that we support instance norm layer, but we don't support bilinear upsample (only nearest).

Hi, you can clone this repo and install it with all the last changes. Also, I want to add that we support instance norm layer, but we don't support bilinear upsample (only nearest).


adding test case for gNMI telemetry for interface ipv6 addreses, report SLAAC assigned link local address - Test Plan Dev

test case for SLAAC assigned link local ip address (319161961)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 52.141%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1668

Relevant Lines:
3199

💛  - Coveralls


braces for case look totally ignored and not treated as anonymous_constructs

When reporting an issue (bug) please provide the following information:
The PHP version you are using ($ php -v):
PHP 7.1.19
PHP CS Fixer version you are using ($ php-cs-fixer -V):
PHP CS Fixer 2.16.1
The command you use to run PHP CS Fixer:
php-cs-fixer fix .
If applicable, please provide minimum samples of PHP code (as plain text, not screenshots):

before running PHP CS Fixer (no changes):

    case 'deleteattachment':
    {
        DeleteAttachment($_ARG['id']);
        $result=1;
        break;
    }
    case 'addimage': {
            break;
        }
    case 'getimage': {
            $result = 1;
            break;
        }

with the changes you expected instead:

    case 'deleteattachment':
    {
        DeleteAttachment($_ARG['id']);
        $result=1;
        break;
    }
    case 'addimage':
    {
        break;
    }
    case 'getimage':
    {
        $result = 1;
        break;
    }

or
    case 'deleteattachment': {
        DeleteAttachment($_ARG['id']);
        $result=1;
        break;
    }
    case 'addimage': {
        break;
    }
    case 'getimage': {
        $result = 1;
        break;
    }

but not a mix of them.
Regards,

Hi and thanks for reporting.
The issue you describe is the same as https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/776 as such I'm closing this report as duplicate.


Tests for Gradient Descent

In order to find the coefficients that optimize the likelihood we do the following:

This ultimately gives us the following formula we can use to maximize the gradient in k-space and determine the coefficient:

We therefore need tests that will support the code that ultimately solves this equation

Just to be clear, we want a test that verifies that the gradient of the likelihood is computed correctly? Or we want to test that the descent converges?

Previously considered only the correct calculation use case.  I am interested if you have an idea on how to test for algorithm convergence as well.

In that case, I changed the name of the ticket as it will only test the Likelihood Gradient calculation.
Testing convergence should be a matter of running a series of N descent steps and seeing if the values are converging or diverging. However, I think this would be overkill since you can tell if the descent is working if the classifier itself works. No need to test both, assuming we test that all the component calculations are correct.


Auto disable volunteer that didn't respond on the last X call

send an sms asking him if he wants to be kept in the call, if no answer in 24h or no, disable him

Nope it won't work.

for example, in tonight's communication (asking for volunteer's availability next week), there are no "Unavailable" answer.  Thus, nobody reply.

inbound answers are not free anymore (it's 0.005ct/answer), thus it's better to not force volunteers to answer.

Ok, so it would be nice to have a statistics module for each structure to explore how people respond (or not respond), to disable some.
see :
https://github.com/redcall-io/app/issues/360


Update pages related to adapters for new adapters

Contributions

[X] I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates
https://docs.getdbt.com/docs/community-adapters
What part(s) of the page would you like to see updated?
One example is that the new Microsoft adapters aren't listed. There may be others.
Additional information
No response

thanks for opening this up @alison985 ! I'm going to loop in @dataders for some insight here. Anders, please let me now if we can help with this!

we've reworked the adapters pages and have two categories of adapters: 'trusted' and 'community'. the  Microsoft adapters are listed under 'trusted adapters': https://docs.getdbt.com/docs/trusted-adapters.
closing this issue as it's been addressed, however let me know if you feel it hasn't and we'll re-open it up. thank you, Alison!


Warn about underscored names in Docker Compose doc

Release Playbook

[ ] Rebase against master
[ ] Code review
[ ] Merge into master
[ ] Verify changes at http://site-staging.convox.com
[ ] Promote release on site-production in the convox/production Rack

Fixes #244


Don't show tooltip for string literals

Doesn't help in any way, and is annoying with large doc strings.

Or maybe just trim the string aggressively - there's some value in the "str"/"bytes"/"unicode" suffix, but not in the content.

I would argue this is a BUG as it makes editing large doc strings extremely difficult to near impossible.

Upgrading to a bug because of the report at https://developercommunity.visualstudio.com/content/problem/109893/python-tooltip-when-hovering-long-string-overlap-m.html


Update validations.py

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

#8894


Add basic auth

Add basic auth with fixed, dummy credentials to all webservices that need authentication

Added BasicAuth and JWT Authentication with 2 new API endpoints:
To get a new JWT token as the response do BasicAuth here:
http://api.col.plus/user/login
To see the full ColUser visit here with a valid JWT token:
http://api.col.plus/user/me
JWT Authentication is done only via the Bearer token in the Authorization header.
A newly logged in user is stored in the postgres database which also keeps track of last col logins and the IdentityService uses a cache to quickly lookup a full user.
Delegating authentication and user retrieval from GBIF still to be done.


Can't remote debug: global.self throws error

Current Behavior
When running in remote debugger using the IOS simulator the browser chokes on
haul-cli/src/utils/polyfillEnvironment.js
global.self = global

Commenting out this line fixes it, and seems to work in simulator
The error looks like this.
TypeError: Cannot assign to read only property 'self' of object '#<DedicatedWorkerGlobalScope>'
    at Object.<anonymous> (polyfillEnvironment.js:32)

Also wrapping in a try/catch seems to work also.
Expected Behavior
Expect remote debugging to work.
Haul Configuration (webpack.haul.js)
default haul configuration
Your Environment

software
version

Haul
"^0.5.0",

react-native
"0.44.0",

node
6.10.2

npm or yarn
yarn

chrome
57.0.2987.133

Also checking if global.self exists before assigning seems to work, which is probably the safest thing to do.  Guessing this a change in chrome version issue.

Ya this was a totally hacky way to get React Native to behave. Without this in place, it was causing fetch due to some really strange timing issue.
I haven't re-evaluated this in 0.44.x, but it was failing in 0.43.x and 0.42.x.
Does symbolication work for you if you handle that line safely?

Ahh "symbolication" not sure what you mean,and once I do I am gonna use that word like 3 times today.

It's a sweet word!
So you know with React Native's redbox screen of death that shows when an error happens?  Well, RN goes back to the packager to resolve the source map to the "real" line of code.  They call that symbolication (I guess).
So, if you force an error to happen:
render () { boom() }
You'll see a stack trace.  Then a moment later (hopefully), the filename will turn into something you recognize.

This has been fixed in https://github.com/callstack-io/haul/commit/ae73662fce4c5e41ac78d0d5ee5d6a16fb8b1c2b and will be released shortly.


Add a spam example to the unacceptable list

GitHub points users to the code of conduct when they are blocked, but we don't mention spamming explicitly in the list.
We get a fair bit of spammy comment activity on our repositories (e.g.), and I can update our own COC but this seems relevant to any Google project on GitHub so I am proposing the change here.

Thanks Mark! I like this addition but I think we should narrow it to "Sending spam or other unsolicited commercial messages" because "non-productive commentary" is too broad. I believe people recognize spam when they see it but would have reasonable disagreement about what's "non-productive" (e.g. sending memes, community in-jokes, etc.)

Done. LMKWYT.


添加多个目标，http连接就会报错

报错：
Max retries exceeded with url: / (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f702037e7f0>, 'Connection to tianshangdx.link.wulin2.cn timed out. (connect timeout=30)'))"

连接超时，不用管


Add AWS arguments to generate-script commands

The PR mainly adds --aws-bucket-name to gei generate-script command in order to support AWS S3 archive upload as an alternative to Azure Storage. Additionally the --azure-storage-connection-string option was removed from the gei generate-script command since it is considered a security risk to include any secrets in the generated script.

[x] Did you write/update appropriate tests
[x] Release notes updated (if appropriate)
[x] Appropriate logging output
[ ] Issue linked
[x] Docs updated (or issue created)

@tambling 👋🏻 I know that there is at least one customer blocked by this. Do you think you'll have a chance to move this PR forward this week? Or would it be worth handing it off to someone else?

@ArinGhazarian is working on this now 🙏🏻
Fixes https://github.com/github/gh-gei/issues/690.

Can you add a release note and link the issue


Fix Log Level Discrepancies

This patch fixes the way the log levels are handled upon creating a new libStorage client or server. The default level remains WARN (unless the environment variable LIBSTORAGE_DEBUG=true).
When LIBSTORAGE_DEBUG=true the log level is set to DEBUG and both HTTP request and response logging are enabled.

Codecov Report

Merging #521 into master will increase coverage by 0.11%.
The diff coverage is 57.14%.

@@            Coverage Diff            @@
##           master    #521      +/-   ##
=========================================
+ Coverage   27.99%   28.1%   +0.11%
=========================================
  Files          33      33
  Lines        1997    2010      +13
=========================================
+ Hits          559     565       +6
- Misses       1379    1384       +5
- Partials       59      61       +2

Impacted Files
Coverage Δ

api/context/context_keys.go
65.38% <25%> (-10.13%)
:arrow_down:

api/context/context.go
30.73% <76.92%> (+2.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c9d72...402b88e. Read the comment docs.


example R: replace connection.h with common.h

[x] update 2021-04-21.web - https://github.com/ldorau/2021-04-21.web/pull/28

This change is

Thanks for involving me in this repo. Sadly I think that was a mistake.  You wanted osalyk and not osa. I have not worked in C in almost 20 years. lol


Sequential workflow - Clarification the invoke response to return Adaptive Cards

[Enter feedback here]
Hello guys,
I'm trying to use the sequential workflow on MS Teams.
It was ok when I hit the submit button from the MS Teams, the function onAdaptiveCardInvoke was called. But after returning an adaptive card that is supposed to replace the current one, I got the error:

I'm not sure if I passed the wrong value for the adaptive card, it would be nice if typescript/javascript example is provided. Thanks in advance.
This is the code from the bot
    protected async onAdaptiveCardInvoke(
        context: TurnContext,
        invokeValue: AdaptiveCardInvokeValue
    ): Promise<AdaptiveCardInvokeResponse> {
        return Promise.resolve({
          statusCode: 200,
          type: "application/vnd.microsoft.card.adaptive",
          value: {
             $schema: "http://adaptivecards.io/schemas/adaptive-card.json",
             type: "AdaptiveCard",
             version: "1.0",
             body: [
                 {
                    type: "TextBlock",
                    text: "Default text input"
                 }
             ],
             actions: [
                 {
                    type: "Action.Submit",
                    title: "OK"
                 }
             ]
           }
        });
    }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b8d58187-8610-ee88-adec-7f7f8b9e0024
Version Independent ID: e622f158-9095-da93-4379-26d23fe419bf
Content: Sequential Workflows - Teams
Content Source: msteams-platform/task-modules-and-cards/cards/Universal-actions-for-adaptive-cards/Sequential-Workflows.md
Product: msteams
GitHub Login: @surbhigupta12
Microsoft Alias: lajanuar

After several tries, it's working if I try with
    protected async onAdaptiveCardInvoke(
        context: TurnContext,
        invokeValue: AdaptiveCardInvokeValue
    ): Promise<AdaptiveCardInvokeResponse> {
        return Promise.resolve({
          statusCode: 200,
          type: "dadasdasdasda",
          value: {
            type: "application/vnd.microsoft.card.adaptive",
            value: require('./cardFactory/card.json')
          }
        });
    }

AdaptiveCardInvokeResponse requires type

But it is weird that inside the library, it ignores the value of type

Should improve the docs that the value should contain type and the card?


Works great locally but blows up on hosted site :(

Hi,
The tour works great locally, however when I deploy it to a hosted site, it blows up here. Any ideas or suggestions ?
Tour.prototype._getState = function(key) {
var keyName, value;
if (this._options.storage) {
keyName = "" + this.options.name + "" + key;
value = this._options.storage.getItem(keyName); <---- Uncaught TypeError: undefined is not a function
} else {
if (this._state != null) {
value = this._state[key];
}
}

This can happen if you pass a boolean to 'storage' in the global options json.


camerad: add CameraConfig struct for initializing CameraState in constructor

This PR refactors the initialization of CameraState by consolidating scattered initialization code from various places into a single CameraConfig struct.
Changes:

Created CameraConfig struct to encapsulate all camera configuration parameters.
Simplified the CameraState initialization list by using the CameraConfig struct.
Refactored functions to reduce the number of parameters

@adeebshihadeh is there an issue with this PR?


embed: associate peer serve() listener with corresponding peer

I tried to test this with unix sockets but there's an unrelated bootstrap bug. After fixing that, the failure doesn't seem to appear for unix sockets (why, I don't know), so the e2e test uses tcp.


Add meta viewport

I’m not sure how well this works, also how long this will take to show up, I’m assuming Alex manually has to put this on the site

Thanks for the patch. Yeah, so far I've to manually sync, but I'll serve from GH pages after Q1's update.


Demo Site breaks on refresh

Go to the demo
Visit Prompt
Refresh

Thanks @imanpalsingh for reporting issue here.
This was because of missing redirect file for static page.  This is now fixed.


Deprecate metal due to recent MTLCompilerService limitations

See: #937
The metal HAL on recent versions of macOS fail to compile due to new limitations on the number of temporary registers allowed in a given function. There doesn't seem to be any easy/low cost way to fix the code generator for eval_check, so our best option at this time is to deprecate Metal support and hope that:

Apple raises the limitation in a future macOS release
New zirgen compiler will be able to produce a more structured function that doesn't require so many outstanding registers at any given time.

https://developer.apple.com/forums/thread/712889

AFAIK, this failure occurs on M1 and M2. It seems to work if you happen to have an older version of the Metal compiler. We have a caching system that attempts to avoid long compile times, but this cache might make it seem that things are working even on newer versions.

Metal seems to be working in latest macOS again.

That is good news!


apoc.refactor.mergeNodes choose the result properties randomly

 Issue by PeterKazmirsky
Tuesday Feb 19, 2019 at 15:58 GMT
Originally opened as https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/1107

Guidelines
Imagine that I have user cluster consisting of user ids from different data sources and all users are connected to one Root node. In case that user cluster contains more than one Root node I want to merge this Root nodes to one. For finding the Root nodes in cluster I am using apoc.path.subgraphNodes and the resulting Root nodes I am sending to apoc.refactor.mergeNodes to merge them to one Root node. I also set properties to procedure: mergeRels:true, properties:'overwrite'
Actual Behavior
I cannot influence in what order roots get into procedure apoc.refactor.mergeNodes, so after merging the result Root node and his relationships properties will have random properties.
Expected Behavior
I would like you to consider to add feature to apoc.refactor.mergeNodes where I can tell for example that for merging property "count" choose highest one. Or for "date" property choose latest one.
Thank you.
Versions
Neo4j 3.5.2
Apoc library <IP_ADDRESS>

 Comment by jexp
Tuesday Feb 19, 2019 at 18:16 GMT

MergeNodes uses collection order
You can use apoc.coll.sort to sort by a key you like

 Comment by PeterKazmirsky
Wednesday Feb 20, 2019 at 07:46 GMT

Thanks. But what about relationships. I recently created ticket where I asked to overwrite properties in relationships in procedure mergeNodes. And now I would like to sort properties of relationships and choose the proper one before merging. Is there any solution for that as well ?

 Comment by vga91
Thursday Jun 24, 2021 at 15:06 GMT

With a simple dataset like:
create (r:Root), (r2:Root) with r, r2
create (r2)<-[:MyRel {prop: "prop1"}]-(n1:User{value:'node1'})-[:MyRel {prop: "prop11"}]->(r)
create (r2)<-[:MyRel {prop: "prop2"}]-(n2:User{value:'node2'})-[:MyRel {prop: "prop22"}]->(r)
create (r2)<-[:MyRel {prop: "prop3"}]-(n3:User{value:'node3'})-[:MyRel {prop: "prop33"}]->(r)

This could be solved in this way:
Match (r:Root)
with collect(r) as nodes    // I CAN ORDER NODES HERE
CALL apoc.refactor.mergeNodes(nodes, {properties:'overwrite'}) YIELD node // NO mergeRels:true
WITH node
match (node)-[r]-(user:User)
with user, collect(r) as rels   // I CAN ORDER RELS HERE
call apoc.refactor.mergeRelationships(rels, {properties: 'DISCARD'}) yield rel return rel
// with {properties: 'DISCARD'} we choose the first in order of appearance, otherwise the last


AzureML Web Service Code Needs Update

consumeDataFrame is deprecated, it looks like you need to use endpoints() somehow though I can't figure out what my web service service ID is.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4b50cbe1-2295-0b76-2b09-15395b969151
Version Independent ID: 2ba93dae-de6b-bc82-3f19-4ec3bfe7961b
Content: Data science with the Linux Data Science Virtual Machine on Azure
Content Source: articles/machine-learning/data-science-virtual-machine/linux-dsvm-walkthrough.md
Service: machine-learning
GitHub Login: @gopitk
Microsoft Alias: gokuma

@SheridanLGrant  Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.
@gopitk Hi, this is a doc-enhancement issue, can you please check it and update the document as necessary? Thanks.

@SheridanLGrant - Yes. The R interface has changed. We will update the code snippet in the article shortly.

@SheridanLGrant The document has been fixed now, please check it. We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


when deployer is Job, if job failed it will be recreated multiple time before it gets failed status

I think we should not


How to build docker 1.13 on FreeBSD 11?

I can't seem to find any information on this. The docker-freebsd port is unmaintained since 2015 and running make.sh on the git clone fails with:
---> Making bundle: binary-client (in bundles/1.13.1/binary-client)
Building: bundles/1.13.1/binary-client/docker-1.13.1
Created binary: bundles/1.13.1/binary-client/docker-1.13.1

---> Making bundle: binary-daemon (in bundles/1.13.1/binary-daemon)
Building: bundles/1.13.1/binary-daemon/dockerd-1.13.1
.gopath/src/github.com/docker/docker/vendor/github.com/docker/libnetwork/drivers/bridge/bridge.go:22:2: no buildable Go source files in /home/marbury/Projects/Cloned/docker/.gopath/src/github.com/docker/docker/vendor/github.com/docker/libnetwork/ns

But since some people use docker with FreeBSD I assume there is a way to run it?
I need some support here, please
Thanks so much

dockerd is not supported on FreeBSD.
@justincormack Do you know anyone trying to support FreeBSD?

The port was never upstreamed, so it cannot be built from this repository.
There is some interest in restarting a port, maybe we should create an
issue to track this.
On 26 Feb 2017 20:00, "Akihiro Suda"<EMAIL_ADDRESS>wrote:

dockerd is not supported on FreeBSD.
@justincormack https://github.com/justincormack Do you know anyone
trying to support FreeBSD?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/issues/31303#issuecomment-282622954,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdcPPUm9IX0uO7MK9mS5aDGwXiOPjT0ks5rgkp6gaJpZM4MKcZD
.

Well this is unfortunate. Back in late 2015 there have been numerous news on tech blogs going like this: "Docker now officially supported on FreeBSD" which got my hopes up. But since I didn't use it back then I just memorized it as nice info. Now I have seen that there is just this one port from @kvasdopil that was made in 7/15 as a (as it seems) one time thing. Which makes this kind of a useless endeavour. As I have seen a "FreeBSD" build icon (even though it is disabled) and some Issue entries regarding FreeBSD, I was just thinking that it might work anyway, if I just compiled it for myself. Dang

The current build is just for a Freebsd client.
On 27 Feb 2017 08:06, "Stefan Wendler"<EMAIL_ADDRESS>wrote:

Well this is unfortunate. Back in late 2015 there have been numerous news
on tech blogs going like this: "Docker now officially supported on FreeBSD"
which got my hopes up. But since I didn't use it back then I just memorized
it as nice info. Now I have seen that there is just this one port from
@kvasdopil https://github.com/kvasdopil that was made in 7/15 as a (as
it seems) one time thing. Which makes this kind of a useless endeavour. As
I have seen a "FreeBSD" build icon (even though it is disabled) and some
Issue entries regarding FreeBSD, I was just thinking that it might work
anyway, if I just compiled it for myself. Dang
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/issues/31303#issuecomment-282764159,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdcPHXV15nH5g7jwRvLoWD4og3q2Ds9ks5rgvSRgaJpZM4MKcZD
.

Just my experiments with Freebsd 11.
$go version
go version go1.8 freebsd/amd64
$cd /tmp
$git clone git://github.com/docker/docker.git
$cd docker
$./hack/make.sh
...
Building: bundles/17.04.0-dev/binary-daemon/dockerd-17.04.0-dev
.gopath/src/github.com/docker/docker/vendor/github.com/docker/libnetwork/drivers/bridge/bridge.go:22:2: no buildable Go source files in /tmp/docker/.gopath/src/github.com/docker/docker/vendor/github.com/docker/libnetwork/ns
$cp /tmp/docker/vendor/github.com/docker/libnetwork/ns/init_linux.go /tmp/docker/vendor/github.com/docker/libnetwork/ns/init_freebsd.go
$./hack/make.sh
...
.gopath/src/github.com/docker/docker/vendor/github.com/docker/libnetwork/ns/init_freebsd.go:67: undefined: syscall.Gettid
.gopath/src/github.com/docker/docker/vendor/github.com/docker/libnetwork/ns/init_freebsd.go:77: undefined: syscall.NETLINK_ROUTE
.gopath/src/github.com/docker/docker/vendor/github.com/docker/libnetwork/ns/init_freebsd.go:84: undefined: syscall.NETLINK_XFRM
.gopath/src/github.com/docker/docker/vendor/github.com/docker/libnetwork/ns/init_freebsd.go:99: undefined: syscall.AF_NETLINK
.gopath/src/github.com/docker/docker/vendor/github.com/docker/libnetwork/ns/init_freebsd.go:99: undefined: syscall.NETLINK_XFRM
Does syscall.Gettid, syscall.NETLINK_ROUTE, syscall.NETLINK_XFRM, syscall.AF_NETLINK, syscall.NETLINK_XFRM not exist for Freebsd?
So, I did move it all from init_freebsd.go for testing only!
$cat /tmp/docker/vendor/github.com/docker/libnetwork/ns/init_freebsd.go
package ns
import (
)
$./hack/make.sh
$ls -l /tmp/docker/bundles/17.04.0-dev/binary-client/docker-17.04.0-dev
-rwxr-xr-x  1 root  wheel  12386457  8 марта 16:22 /tmp/docker/bundles/17.04.0-dev/binary-client/docker-17.04.0-dev

Test with syscall.Gettid, syscall.NETLINK_ROUTE, syscall.NETLINK_XFRM, syscall.AF_NETLINK, syscall.NETLINK_XFRM.
$cat syscall.go
package main
import "syscall"
func main() {
_ = syscall.AF_NETLINK
}
$GOOS=freebsd GOARCH=amd64 go build syscall.go
./syscall.go:6: undefined: syscall.AF_NETLINK
$GOOS=linux GOARCH=amd64 go build syscall.go
no errors

Before porting dockerd you would need to port run c.
Also, before porting runc you would need to revise the OCI spec as well.

I'll go ahead and close this issue, because compiling for FreeBSD won't work currently (without someone working on porting it), but feel free to continue the conversation


support echo=true and logprobs in openai api when logprobs=1 in lm-evaluation-harness

Sglang service can't match lm-evaluation-harness, because lm-evaluation-harness set echo=True and logprobs=1 in openai client api: https://github.com/EleutherAI/lm-evaluation-harness/blob/bd80a6c0099ee207e70f4943117739a817eccc0b/lm_eval/models/openai_completions.py#L55
This pr solved it, I can run lm-evaluation-harness with SGLang service now.

Thanks for the contribution. unit-test-backend-part-2 failed. Can you take a look and fix it?
You can run a test case like this: https://github.com/sgl-project/sglang/tree/main/test#test-backend-runtime

Thanks for the contribution. unit-test-backend-part-2 failed. Can you take a look and fix it?
You can run a test case like this: https://github.com/sgl-project/sglang/tree/main/test#test-backend-runtime

Wolved now.

When echo=True and request.logprobs>0, logprob_start_len is 0, so the first token's logprob would be None. Just skip the assert when echo=True.


RSS feed (combined) generation also in feed formats (RSS2/ATOM)

Hi and congratulations on your effort and idea!
I would like to ask for an idea/implementation regarding the combined list of RSS feeds. Is it possible to combine RSS feeds (the results of the generated html page maybe?) to a new "unified"-RSS-feed (in ATOM/RSS2), so that it can also be able to be used in other services (eg Feedburner, IFTTT, Ms Flow or others) or implementations? It can be optional via a set of configuration variables or something similar... (also built-in on the template page as a reference if it is configured as active)
I am not sure how easy it can be, or if that is even the scope of this set of scripts, it could be nice to suggest it, for a future work maybe...
Thank you!

Thanks! There already is a machine readable output in json format but that's not adhering to a standard feed format and the output is not a flat list yet. So in the short term, if you are comfortable with some json parsing, IFTTT and Ms Flow could already consume the generated output.
You can also use http://www.rssmix.com/ to achieve the same goal.
Would either option meet your requirement?

Thank you for the fast reply! Sure, I would try to seek for some implementations and do some further testing!
Congrats again and keep up the good work! 👍

Converted to a discussion. See #12


Duplicate code suggestions on some items

Vue - Official extension or vue-tsc version
2.1.10
VSCode version

Vue version
3.4.30
TypeScript version

System Info
System:
    OS: Linux 6.11 Arch Linux
    CPU: (20) x64 13th Gen Intel(R) Core(TM) i5-13600K
    Memory: 25.63 GB / 31.11 GB
    Container: Yes
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 23.1.0 - /usr/bin/node
    Yarn: 1.22.22 - /usr/bin/yarn
    npm: 10.9.0 - /usr/bin/npm
    pnpm: 9.12.3 - /usr/bin/pnpm

package.json dependencies
"dependencies": {
        "pinia": "^2.2.2"
    },
    "devDependencies": {
        "@vitejs/plugin-vue": "^5.0.5",
        "@vue/eslint-config-prettier": "^9.0.0",
        "autoprefixer": "^10.4.20",
        "postcss": "^8.4.45",
        "tailwindcss": "^3.4.10",
        "vite": "^5.3.1",
        "vue": "^3.4.30"
    }

Steps to reproduce
When trying to auto-import anything from vue, I get two autocompletion items, with only the second one actually importing it if needed.

What is expected?
Only the second completion item, the one that also auto-imports.
What is actually happening?
I get two autocompletion items, and the one without auto-import is the default.
Link to minimal reproduction
No response
Any additional comments?
I am using neovim and the hyprid mode

i also have this problem. extension version is v2.1.10

Make sure that you has enabled the hybrid mode. The following is my configuration, it has no problem. (same version v2.1.10)
I have pretty much the same config

@Tobls I have tested all the config methods which listed on readme, the duplicate result only appear on Non-Hybrid mode 2th.
I assume you are using nvim-lspconfig and had installed ts, vue server. Following below steps:

put below code in test.lua
nvim -u test.lua ./src/App.vue
typing import { ref } from 'v and press <C-x><C-o>
observe competion list

./test.lua:
vim.cmd('packadd nvim-lspconfig')

require('lspconfig').ts_ls.setup({
    init_options = {
        plugins = {
            {
                name = '@vue/typescript-plugin',
                location = '/path/to/vue-language-server',
                languages = {'vue'},
            },
        },
    },
    filetypes = { "javascript", "vue", },
})

require('lspconfig').volar.setup({
    init_options = {
        typescript = {
            tsdk = '/path/to/tsdk'
        }
    }
})

@Tobls I have tested all the config methods which listed on readme, the duplicate result only appear on Non-Hybrid mode 2th.
I assume you are using nvim-lspconfig and had installed ts, vue server. Following below steps:
1. put below code in test.lua

2. `mkdir -p ~/.config/nvim/pack/bucket/opt && cd  ~/.config/nvim/pack/bucket/opt`

3. `git clone "https://github.com/neovim/nvim-lspconfig"`

4. `nvim -u test.lua ./src/App.vue`

5. typing `import { ref } from 'v` and press `<C-x><C-o>`

6. observe competion list

./test.lua:
vim.cmd('packadd nvim-lspconfig')

require('lspconfig').ts_ls.setup({
    init_options = {
        plugins = {
            {
                name = '@vue/typescript-plugin',
                location = '/path/to/vue-language-server',
                languages = {'vue'},
            },
        },
    },
    filetypes = { "javascript", "vue", },
})

require('lspconfig').volar.setup({
    init_options = {
        typescript = {
            tsdk = '/path/to/tsdk'
        }
    }
})

I have exactly this configuration, but still get duplicate suggestions.

Since one ref is function(value: any): any I don't think it's related to the lsp config at all, the above config looks good to me. My gut feel this caused by typescript declaration. Can you share a minimal reproduction?

Since one ref is function(value: any): any I don't think it's related to the lsp config at all, the above config looks good to me. My gut feel this caused by typescript declaration. Can you share a minimal reproduction?

Sure, these are the relevant nvim plugins in the configurations I use (With lazy as a plugin manager):
LSPconfig:
  return {
      "neovim/nvim-lspconfig",
      event = { "BufReadPre", "BufNewFile" },
      dependencies = {
          "hrsh7th/cmp-nvim-lsp"
      },
      config = function()
          local lspconfig = require("lspconfig")
          local cmp_nvim_lsp = require("cmp_nvim_lsp")

          local keymap = vim.keymap
          local opts = { noremap = true, silent = true }
          local on_attach = function(client, bufnr)
              opts.buffer = bufnr
              opts.desc = "Show LSP references"
              keymap.set("n", "<leader>gu", "<cmd>Telescope lsp_references<CR>", opts) -- show definition, references
          end

          -- used to enable autocompletion (assign to every lsp server config)
          local capabilities = cmp_nvim_lsp.default_capabilities()

          local mason_registry = require("mason-registry")
          local vue_language_server_path = mason_registry.get_package('vue-language-server'):get_install_path() .. '/node_modules/@vue/language-server'
          lspconfig["ts_ls"].setup({
              capabilities = capabilities,
              on_attach = on_attach,
              init_options = {
                  plugins = {
                      {
                          name = "@vue/typescript-plugin",
                          location = vue_language_server_path,
                          languages = { "javascript", "typescript", "vue" },
                      },
                  }
              },
              filetypes = {
                  "javascript",
                  "typescript",
                  "vue",
              },
          })

          lspconfig["volar"].setup({
              capabilities = capabilities,
              on_attach = on_attach,
          })
      end
  }

Mason:
return {
    "williamboman/mason.nvim",
    dependencies = {
        "williamboman/mason-lspconfig.nvim",
    },
    config = function()
        local mason = require("mason")
        local mason_lspconfig = require("mason-lspconfig")

        mason.setup({})

        mason_lspconfig.setup({
            ensure_installed = {
                "ts_ls",
                "volar",
            },
            automatic_installation = true
        })
    end,
}

CMP:

return {
"hrsh7th/nvim-cmp",
event = "InsertEnter",
config = function()
local cmp = require("cmp")
    cmp.setup({
        completion = {
            completeopt = "menu,menuone,preview,noselect",
        },
        sources = cmp.config.sources({
            { name = "nvim_lsp" }
        }),
    })
end

}

I mean a typescript project reproduction, and you can also try to create a brand new project with create-vite if that does not have the duplicated lsp completion items, can future confirm your neovim config is fine.


Hactoberfest merge file

Added a hactoberfest file so that other files not get affected.

That's good


Is there a way to change maxConnections size?

is it always fixed to a certain value? or can it depend on a condition? what is the max value?

Yes, it is fixed now. It also has no max value


Symbol for subscribe port flips based on location

Issue and tracking information
I added a subscribe port to a component. Then I dragged it to a new location and the symbol inverted. This is reproduceable.
In the 2 pictures below, you can the port symbol inverts when clicking the up/down arrow button once.

Developer's time Estimated effort to fix (hours):
Developer's Actual time spent on fix (hours)
Issue reporter to provide a detailed description of the issue in the space below

Fixed and merged to Papyrus branch.

Tested and verified on our end. This issue can be closed, thanks @ysroh !


[Bug]: Storybook imports extra unnecessary files

Describe the bug
Storybook imports random files when used with @storybook/addon-react-native-web.
This causes the build to fail.
An example repository can be found here and the failing build here.
You can see the error is:
ERROR in ./node_modules/react-native/Libraries/StyleSheet/processColor.js 1:442-497
Module not found: Error: Can't resolve './PlatformColorValueTypes' in '/home/runner/work/storybook-test/storybook-test/node_modules/react-native/Libraries/StyleSheet'
<EMAIL_ADDRESS>1:715-772
<EMAIL_ADDRESS>1:930-950
<EMAIL_ADDRESS>1:1524-1542
 @ ./node_modules/react-native-progress/Circle.js 1:1329-1367
 @ ./node_modules/react-native-progress/index.js 1:631-650
 @ ./src/components/ImageProgress/ImageProgress.tsx 1:105-137
 @ ./src/ lazy ^\.\/.*$ namespace object ./components/ImageProgress/ImageProgress.tsx ./components/ImageProgress/ImageProgress
 @ ./storybook-stories.js 1:567-597
 @ ./storybook-config-entry.js 1:158-191 1:983-1115

This is a typical transpilation error that you see with react-native-web - but the <ImageProgress /> component is not being imported in to any of the stories (of which there is only one: https://github.com/ChrisEdson/storybook-test/blob/main/src/components/ui/DesignSystemHeadlineFive.stories.tsx).
I'm really confused by this. The stories property in main.js only specifies stories to be included:
stories: ["../src/**/*.stories.@(js|jsx|ts|tsx)"],
To Reproduce
https://github.com/ChrisEdson/storybook-test
System
Storybook Environment Info:

  System:
    OS: macOS 14.0
    CPU: (8) arm64 Apple M1 Pro
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.5.1 - ~/.nvm/versions/node/v20.5.1/bin/node
    npm: 9.8.0 - ~/.nvm/versions/node/v20.5.1/bin/npm <----- active
  Browsers:
    Chrome: 119.0.6045.159
    Safari: 17.0
  npmPackages:
    @storybook/addon-react-native-web: 0.0.21 => 0.0.21
    @storybook/react: ^7.5.3 => 7.5.3
    @storybook/react-webpack5: ^7.5.3 => 7.5.3
    storybook: ^7.5.3 => 7.5.3

Documenting here, as it took me ages to get this working on my project, and it might help someone trying just to get the integration off the ground until this gets fixed.
My use-case is simple, I want to start adding stories little by little in a very well-established project, full of dependencies.
Trying to follow the README got me here, as I had hundreds of Module not found: Error: Can't resolve [...] errors.
I only have a single Button.stories.tsx file, which doesn't import nothing but:
import { View } from 'react-native';
import type { Meta, StoryObj } from '@storybook/react';
import { MyButton } from './Button';

(it's the boilerplate example generated by storybook/react-native)
Manually importing the stories gets rid of the errors - which seems to indicate the issue lies in the lazy loading:
import type { StorybookConfig } from '@storybook/react-webpack5';

const config: StorybookConfig = {
  stories: [
    // Got rid of these:
    // '../src/**/*.mdx',
    // '../src/**/*.stories.@(js|jsx|mjs|ts|tsx)',

    // Added the story manually
    '../src/components/Button/Button.stories.tsx',
  ],
  // the rest remains the same...
};

export default config;

I am also having the same issue here. Storybook is importing all of my other components that are not even imported in the stories. Causing so many issues.. on top of that, the example linked in the repo from dannyhw/expo-storybook-starter for react-native-web also doesn't seem to work for me.
I have to install @storybook/addon-styling-webpack for some reason to make it work..


API for devs

title

Hello @RgtArRr,
Could you elaborate a bit on this feature? What API methods or functionality do you need?
Maintaining a public API is time consuming, would additional commands (i.e. that will work with command blocks) be enough for what you're trying to achieve?

Hello @RgtArRr,
Could you elaborate a bit on this feature? What API methods or functionality do you need?
Maintaining a public API is time consuming, would additional commands (i.e. that will work with command blocks) be enough for what you're trying to achieve?

programmatically placing images in air with custom rotation, and allowing image loading programmatically, and destruction. i'd imagine.

Closing due to inactivity.


add a new ami logo

What does this PR do?

Add a new logo for the ami imaging javascript toolkit

Description of Task to be completed?

Add png and svg logos

Any background context you want to provide?

Awesome! I like it! Can you also provide

a logo with the icon on left and text on right?
just "ami" with the "i" replaced by the logo
logo on left + ami on right (not written medical imaging JS toolkit)
a version of the logo just with borders (not filled content)

@NicolasRannou Done just check the assets folder for the updated logos

Awesome, one (easy to fix I hope) thing, the font is not the same everywhere, I really liked the one you used in the first message of this PR.
Which font is it BTW?
Should be good to go after that!

It is actually the same its called "ubuntu" https://design.ubuntu.com/font/

@tibetegya checkout this one for instance: https://github.com/FNNDSC/ami/blob/88d347f2216f591463f8f474822b07417d9fc86d/assets/ami_logo_plus_text.svg
The font seems different -
I like to have the ubuntu font, great for open source project :)

Its the same. Just small

Thanks!


Shift to Meta inheritance to fix ordering

The ordering setting of the CandidateContest, BallotMeasureContest and RetentionContest parent is not being inherited due to the issue described here in the Django documentation. I've tried to correct it.

Coverage remained the same at 99.0% when pulling 1d6fe636cc88cb073c284e1995046059152e06bd on palewire:patch-3 into 18419d3495584657b775114f9b0eb61746fe2d3f on opencivicdata:master.

Coverage decreased (-0.3%) to 98.727% when pulling ea708c6cf24abe265cdd38ec558fe2265bfa048c on palewire:patch-3 into 18419d3495584657b775114f9b0eb61746fe2d3f on opencivicdata:master.

Coverage remained the same at 99.0% when pulling ea708c6cf24abe265cdd38ec558fe2265bfa048c on palewire:patch-3 into 18419d3495584657b775114f9b0eb61746fe2d3f on opencivicdata:master.


Prisma generate to use custom schema file name in output folder

Bug description
I have a schema file named as schema_Test.prisma (which looks like the following)
generator client {
  provider        = "prisma-client-js"
  output          = "./Test"
  binaryTargets   = ["native", "windows"]
}

datasource db {
  provider = "sqlserver"
  url      = env("DATABASE_URL")
}

When I run prisma generate --schema=./prisma/Test/schema_Test.prisma, it generates prisma files as expected under the Test output folder. However, it creates a schema.prisma inside the output folder instead of schema_Test.prisma file that I specify.
The reason this is an issue, is because I'm using webpack to bundle the application and deploy to production, and the bundled script keeps looking for schema.prisma at the root folder once I deploy the application instead of schema_Test.prisma.
In scenarios when people use 2 databases, they might have database1.prisma and database2.prisma. Since the option to provide the custom name is given in the configuration, wouldn't it make more sense to use the schema file name specified using --schema instead of the default schema.prisma under the generated output folder?
By using custom names inside the generated output folder, folks can easily use the bundlers (like webpack) and simply have both database1.prisma and database2.prisma (with 2 different schema file names, as opposed to schema.prisma, which will only allow connection to a single database at a time after bundling).
How to reproduce

Create a custom schema file say schema_Test.prisma and specify an output folder
Run prisma generate --schema=./prisma/Test/schema_Test.prisma
Prisma generates content inside ./prisma/Test, however, there is a schema.prisma file instead of schema_Test.prisma file that gets mentioned with --schema flag.

Expected behavior
The expected behavior would be to use the name of the schema file that is specified instead of using the default schema.prisma.
Prisma information

// Add your schema.prisma
generator client {
  provider        = "prisma-client-js"
  output          = "./Test"
  binaryTargets   = ["native", "windows"]
}

datasource db {
  provider = "sqlserver"
  url      = env("DATABASE_URL")
}

Environment & setup

OS: Windows
Database: SQL server
Node.js version: 16.15.1 (npm: 8.11.0)

Prisma Version
4.11.0

We are having a similar issue where we have several different databases, each with their own schema in the context of serverless using ESBuild to bundle a handler.
ESBuild bundles up everything into one index.js file, and in theory the schema files should be copied into the bundle and live next to the index.js file. If the schema is named schema.prisma for all the databases, they overwrite each other and only one client is usable.
I would like the client generator to honor the renamed schema.prisma file so that it can be named something like [database].prisma so that the bundler copies unique schema files to the bundle and when the database specific prisma client needs it, it loads the right schema.

It looks like the prisma client looks for the schema in two locations "__dirname/schema.prisma" and "process.cwd()/client. Both of these are hard coded making it difficult to leverage a naming convention.
For instance, as mentioned above, the schema could be named [database name].schema. But, another convention could be instead of "client" the directory could be called "[database name]-client" or something like that. In both cases, two different clients could live in the same bundle.
As it stands, two clients can't be instantiated in one bundle when one index.js file is generated that holds all the code.

It appears that the most recent prisma cli and client do handle bundling in a way that allows esbuild-serverless to work.
A change can be made in the generateClient.ts code to preserve the name of the schema file (around line 357):
  const schemaName = schemaPath?.split('/').pop() || 'schema.prisma'
  const schemaTargetPath = path.join(outputDir, schemaName)

  if (schemaPath !== schemaTargetPath) {
    await fs.copyFile(schemaPath, schemaTargetPath)
  }

In cases where the name is to be preserved, this might be a welcome change. The change does appear to work even with the name being preserved and not "schema.prisma".
In my case, It appears that upgrading from 4.11.1 to 5.9.1 fixes the bundling issue that we are having without having to preserve a unique name.


Making gunicorn log level configurable

Currently, log_level for gunicorn is set to WARNING by default and it cannot be changed using a variable context. This new code chunk allows us to do that.

+1


Fixed the bug of same multiple connection

see issue #17747

5.3 is closed for bug fixes now. Please send to 5.4 if still relevant on that branch.

It hasn't been 6 months since 5.3 was released.

This would be a breaking change, however.

so how to fix this problem with a best solution?


Update fake backend and fake provider to use versioned interface

Summary
As was reported in #6280 the algorithms path doesn't work on minimal
examples of the Backend and Jobs interface and instead only works in
practice on ibmq, aer, or basic aer backends. Part of the reason for
this was that all the testing of algorithms is done exclusively on those
providers and there wasn't a minimal example to test against that
doesn't have legacy overhead (like qobj, etc). This commit updates the
fake providers and fake backends to use the latest version of the
provider, backend, and job interfaces and to be strictly compatible (ie
no qobj support). Besides exercising the new interface version it also
enables us to test the eventual fix for #6280 when it's available.
Details and comments

The code looks good. However, FakeBackend is widely used (even in Qiskit textbook and tutorials), so dropping Qobj support without warning is a bit risky. It certainly shouldn't be in a patch release even though it's "fake".

The code looks good. However, FakeBackend is widely used (even in Qiskit textbook and tutorials), so dropping Qobj support without warning is a bit risky. It certainly shouldn't be in a patch release even though it's "fake".

I wasn't proposing this to be backported or included in a patch release, I agree this isn't valid for that. The tension here is that there actually isn't any backend available for local testing that doesn't reject qobj currently, which only makes issues like #6280 more likely. This felt like the right place to do it since these are the test backends.
It's also worth noting that we do run the tutorials here and none of them failed with this. The textbook might be a different, but I believe they're still using execute which will be seamless. It honestly would be quite odd if the textbook or tutorials were manually constructing a qobjs.

When I searched for qiskit textbook fake, this was the second result: https://qiskit.org/textbook/ch-appendix/qiskit.html which does use qobj. But if you don't plan on making this a patch release then there should be plenty of time for the textbook to be updated.


SWATShare apps linked to the  generic Model Instance resource type

This app should be linked to the specific Model Instance resource type: SWAT Model Instance resource type only. As an example, for the Model Instance resource: https://alpha.hydroshare.org/resource/12d195906f2c41918cb24e11a5c3ab60/, there is a tab called "open with.." that has a drop list contains the SWATShare apps (see below)

Also the "web apps" that contains all the SWATShare apps should show only for the SWAT Model Instance resource (see below)

@mohamedmorsy
It was caused by partially matching the supported res type names with other res types names.
In this particular failing case, "ModelInstance" was mistakenly considered to match with "SWATModelInstance" because the common text "ModelInstance" in both.
Thanks for reporting this.

@mohamedmorsy  The bug should be fixed on www. Will you double check and close this issue? thanks

I checked the issue and it has been solved on www


fix fragment when used with extended schema

This refactors some of Validator to fix an issue with validating a
fragment of an extended schema against a json object. The problem is
that while navigating through the schema, we are using the configured
:version option as the validator for each partial schema. This is an
issue because if the root of the schema declares a $schema, that
information is lost in the traversal.
The refactor does two things. Firstly, it does not write back into
@options[:version] and it stops using it outside of the constructor
entirely. The only place that should know about this is the initialized
schema, and from that point on, the canonical validator should be the
schema object's validator since it makes a decision about which to use
in its constructor. So we can reduce complexity by using that validator
in the :validate_schema option branch.
The other place that used :version is the schema_from_fragment
method, which is where the bug exists. What we're doing here, instead of
dealing with schemas and hashes during the iterator, is pulling the
schema object out, digging through it using the fragments, and then
wrapping the result in a schema using the base_schema's validator.
Tests have been included that demonstrate the problem.

So what you're saying is that if we validate against a fragment, we should use the version from the base schema. That makes sense. However, I think your test is invalid - I think odd-a should have type: "object"?

I don't know if type: "object" is specifically necessary, and the other tests in the file do not have it. I am happy to add it if you think it is important. As it stands now, the test should fall without the patch and passes with it.

I'll take a deeper look at this shortly. I think the essence of what you're
doing is right.


cabana/cameraview: Scale the glViewPort by devicePixelRatio()

Fix for an issue I ran into using Cabana on a "hidpi" Linux system with Wayland+Plasma (Qt 5.15.9) where devicePixelRatio() != 1.0 and the video doesn't take up the full widget area.
Screenshot of the demo route showing the issue:

On the recommended Ubuntu 20.04 install I wasn't able to reproduce. It seems devicePixelRatio() is equal to 1.0 there even with scaling at 200% or 300%. It might be different if "Fractional Scaling" is enabled in GNOME (I couldn't make that option work in my test WM for some reason.)
I was going to enable this just for Linux, but it appears to also be recommended for Retina macOS:

However, in OpenGL pixels are always device pixels. For example, geometry passed to glViewport() needs to be scaled by devicePixelRatio().

So I've turned it on unconditionally, with the assumption that on many systems devicePixelRatio() == 1.0 so it won't change anything. I don't have a Mac or WSL system to verify if this either fixes or creates any issues there, though.
Thanks for developing Cabana and the comma.ai ecosystem, I really like this tool!

Failing benchmark seems to be fully unrelated, but I don't seem to have permission to retry the job.

Ah good fix! I was running into this on MacOS as well. See https://github.com/commaai/openpilot/discussions/26091#discussioncomment-5646096

Is everything still ok if you force a ratio with eg QT_SCALE_FACTOR=1 on a high-dpi display?

Just tried it out on Wayland and X11 (Ubuntu 20.04) and it seems to work as expected, the UI widgets all scale up or down in size and the video draws correctly in the available area.

Did you test the openpilot ui as well?

Sorry, I did not... actually I don't own any comma.ai hardware, nor an Nvidia graphics card to run the simulator. My interest is using Cabana to analyse some different CAN logs for a totally different purpose.

You can test the openpilot ui (selfdrive/ui/ui) on replay as well! No need for a simulator.

current state on macOS:
macOS hidpi display (m1 MBP) QT_SCALE_FACTOR=1.0 ./tools/cabana/cabana --demo - too small to be usable

macOS hidpi display (m1 MBP) QT_SCALE_FACTOR=0.5 ./tools/cabana/cabana --demo - usable


Add list Layout Mode

Please add the list view mode in layout mode which only displays the filename without the details. This will allow a display on several columns. Like in Windows 10 Explorer.

Merging with #2509

@jlbrd thank you for your patience, I'm excited to share that a List View layout will be included in the next release.


not picking up mobileraker.conf

I have the mobileraker_companion installed.
Looking at the moonraker.log it doesn't look like its finding my customer mobileracker.conf I have tried it in the
~/ and
~/printer_data
installed with Kiauh
I have forced logins and trusted clients on so I added change the url
and add my api key to
moonraker_api_key:
but according to moonraker.logs it its still looking at the local ip and not sending a api key

Can you upload the mobileraker.log file?

You can close, finally put it in the mobileraker_companion directory and I got it working. I also have mine behind a proxy so had to use wss:/// that seem to make it work


Include SortBundleNewestFirst on manager interface

Description of changes:
Include some methods on Manager interface to be used in eks-anywhere codebase.

/cc @ewollesen


WEEK2CHALLENGE jerin_jacob

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Are you sure you got the name of the script file right? :-)

Thanks for that. The executable scripts should not have file extensions.
Will change that.
On Thu, Oct 21, 2021 at 10:32 PM DJ Adams @.***> wrote:

Are you sure you got the name of the script file right? :-)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SAP-samples/devtoberfest-2021/pull/152#issuecomment-948568923,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGHUFYUCOYINAW3IJC2V2KLUIAB7FANCNFSM5GFUF7WA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


BoltDB encryption support

Need to figure out a way to optionally encrypt data stored in boltdb. This may be possible through the boltdb library already, otherwise we will need to figure some other means out.

With #16 this is no longer needed.


Create a visual interface for advanced search filtering

What
Backend readiness

[ ] https://github.com/openfoodfacts/openfoodfacts-dart/pull/313
[ ] Original form on the web for any remaining reverse engineering: https://world.openfoodfacts.org/cgi/search.pl?graph=1
[ ] https://github.com/openfoodfacts/openfoodfacts-dart/issues/523
[ ] https://github.com/openfoodfacts/openfoodfacts-dart/issues/530
[ ] https://github.com/openfoodfacts/openfoodfacts-dart/issues/539
[ ] https://github.com/openfoodfacts/openfoodfacts-dart/issues/515
[ ] #2785

UI approach

Rather than the sophisticated mockups inspired by the GitHub advanced search or anything else, I propose we duplicate the advanced search form of the web version as a first step, to get something working as quickly as we can, focusing on the basics
https://world.openfoodfacts.org/cgi/search.pl?graph=1

Components

[ ] (Advanced search) Create a visual interface for filtering by keyword
[ ] (Advanced search) Create a visual interface for filtering by facet/criteria

[ ] Add autocomplete modal for facet/criteria type
[ ] Add operand: "contains/does not contain"
[ ] Add autocomplete for facet/criteria value field
[ ] Add/Remove additional criteria
[ ]

[ ] (Advanced search) Create a visual interface for filtering by nutrient

[ ] Add autocomplete for nutrients
[ ] Add operands for nutrients

[ ] name="nutriment_compare_0" id="nutriment_compare_0
[ ] lt <
[ ] lte ≤
[ ] gt >
[ ] gte ≥
[ ] eq =

[ ] Add numeric input for nutrient value
[ ]

[ ] Filter by Ingredients

[ ] Additives Without  With  Indifferent
[ ] Ingredients from palm oil Without  With  Indifferent
[ ] Ingredients that may be from palm oil Without  With  Indifferent
[ ] Ingredients from or that may be from palm oil Without  With  Indifferent
[ ]

[ ] (Advanced search) Add "Results in a list of products"

[ ] Add sorting options

[ ] sort_by" id="sort_by
[ ] unique_scans_n Popularity
[ ] product_name Product name
[ ] created_t Add date
[ ] last_modified_t Edit date
[ ] completeness Completeness

[ ] (Advanced search) Add "Results on a graph"

[ ] The graph will show only products for which displayed values are known.
[ ] Graph title
[ ] Select what you want to graph on the horizontal axis to obtain a histogram, or select two axis to get a cloud of products (scatter plot).
[ ] Add a dropdown/select modal for Horizontal axis
[ ] Add a dropdown/select modal for Vertical axis
[ ] Add a toggle to use a different colour for "Organic" products
[ ] Add a toggle to use a different colour for "Fair trade" products
[ ] Add a toggle to use a different colour for "With sweeteners" products
[ ] Add a toggle to "Use nutrition grades colours" products

[ ] (Advanced search) Results on a map

[ ] Add map title
[ ] Add hint to what you need to map (origins of ingredients ? packager codes ?)
[ ] Find a rendering engine able to plot many points
[ ] Plot points on a map
[ ] Add tappable markers that open the product on tap

[ ] (Advanced search) Download results

[ ] Add note "Download results in XLSX or CSV format. Please note that for performance reasons, you can download up to 10.000 results only."
[ ] XLSX format - Excel or LibreOffice input type="radio" name="format" value="xlsx" id="format_xlsx" checked=""
[ ] CSV format - Character set: Unicode (UTF-8) - Separator: tabulation (tab) input type="radio" name="format" value="csv" id="format_csv"

Old mockups

Initial mockups on Figma

Part of

#991

@monsieurtanuki initial search to leverage https://github.com/openfoodfacts/openfoodfacts-dart/pull/313

Or we could stick to the Web UI as a first iteration, potentially in a separate view from the current search first

Bumping to P1

For that I need more active reviews in off-dart, like

https://github.com/openfoodfacts/openfoodfacts-dart/pull/522
https://github.com/openfoodfacts/openfoodfacts-dart/pull/525
https://github.com/openfoodfacts/openfoodfacts-dart/pull/527
https://github.com/openfoodfacts/openfoodfacts-dart/pull/532
https://github.com/openfoodfacts/openfoodfacts-dart/pull/533
https://github.com/openfoodfacts/openfoodfacts-dart/pull/534

Lot to do lately, now more active again, if you need a quick review feel free to ping me on them 😄

For the record, I just lost 30 min of edits on this issue 😿

@monsieurtanuki @M123-dev @g123k I have reworked the "Advanced Search" description, splitting it into tasks, with a new UI approach.
Rather than the sophisticated mockups inspired by the GitHub advanced search or anything else, I propose we duplicate the advanced search form of the web version as a first step, to get something working as quickly as we can, focusing on the basics

@teolemon I'm currently glued in the "background task + refresh" issue. I can put it on the shelf and work rather on the advanced search if needed.
My main question is: from where in the UX/UI do we reach the advanced search page?

#2785 added to the description
I was thinking of an experimental screen first, and then binding that to the main search as a refinement button ?
Can we split that into parts for Hacktoberfest ?

@teolemon If I sum up, that would mean, in parallel:

creating a new "advanced search" page in dev mode

populate that page with whatever UI you want
including a "Go!" button, that in a first approach will just sum up the query by printing all parameters (no actual execution)

checking that we are able to deal with each parameter on the off-dart side as search query parameters

Then, link all the UI inputs with search query parameters.
Then, code the actual "Go!" action.
And some day, code #2785 - we don't really need it now for dev level purposes, except that the cache will look surprising without it (temporary solution: manually refresh your page when it's labelled as "cached x minutes ago").


Utilize OpenJDK8 for Alpine OS

SonarScanner CLI - Linux contains an embedded JRE which is incompatible with Alpine OS distributions due to incompatible c libraries; consequently, force Alpine OS builds to install OpenJDK8 JRE to bypass issues with the packaged AdaptOpenJDK 11 supplied by Sonar.

please use the andrewrothstein.openjdk role if u want to control the version of openjdk that's installed


code completion does not work after go and defer

Auto completion does not work for these two patterns
go x.[cursor]
defer x.[cursor]

@yunabe - I dug the code a little deep this time and figured the function parseCallExpr in parser.go expects the statement (which comes after the go keyword) to be always an ast.CallExpr object. If it is not, it logs the error (by calling parser.error) and returns a nil.  The callers - parseGoStmt and parseDeferStmt functions return ast.BadStmt.
When the parsed statements get walked in the function completeTargetFromAST (in complete.go), the ast.BadStmt gets ignored there by resulting in an empty completion.
One possible solution to this is to log the error (by calling parser.error) and return a valid ast.ExprStmt instead of an ast.BadStmt.
If the user types a statement in the REPL like go bytes.Com and hits enter, the fix would ensure the code doesn't go to the compilation stage and still print the same error (function must be invoked in go statement). However, if the user types the same and hits tab, it would auto-complete.
Please let me know if you have a fix in mind for this.

Ok. I will send a PR to remove go and defer keywords in Complete.


question: should the lua filter log whether or not responses will be hooked when missing function envoy_on_...?

I get these log messages showing up

"envoy_on_request() function not found. Lua filter will not hook requests."

and I wanted to bring forward the question as to whether they should be an INFO level log message, or debug?
They seem somewhat noisy - my thinking is that most people who configure a lua filter are not surprised if they aren't hooking into either the request or response, in the cases where they only want to handle one. So what is the purpose behind this message?
Should it perhaps be a warning if BOTH functions are missing, but otherwise debug?
Secondarily, if someone was to add function envoy_on_response(_) end into all their lua filters in order to suppress this log message, does that incur any overheads when envoy is running? Does it then cause the lua filter to hook into the request/response, do nothing, and then continue?
Let me know your thoughts.
https://github.com/envoyproxy/envoy/blob/main/source/extensions/filters/http/lua/lua_filter.cc#L223-L230

I think the idea behind the log message is for cases where you didn't realize you didn't hook the function, for example if you had a typo in the name of the function.
Possibly a better fix might be to provide configuration for whether the two functions are defined or not, and throw an error if it is supposed to be present and is not. But it would probably be reasonable to change those messages to debug-level unless they're both missing, as you suggest.

I agree with the better fix 👍🏼 putting this in configuration with sane defaults make sense.
Does this structure and naming seem sensible:
message Lua {
  LogMissingHooks log_missing_hooks = 2;

  enum LogMissingHooks {
    LOG_NONE = 0;
    LOG_MISSING_REQUEST_HOOK = 1;
    LOG_MISSING_RESPONSE_HOOK = 2;
    LOG_BOTH_HOOKS = 3;
    LOG_ANY_MISSING = 4;
  }
}

If so, I will try to find some time to open a PR for this

I think just having two boolean settings would be simpler.
But this is probably overkill for this. I'd just change it to a debug-level message for both of these, unless neither is defined and then log them at info/warn level.


0.7 Release

This PR has a bunch more bug fixes and some pretty critical security fixes

[x] Lock down cookie (#132)
[x] Add unit tests for cookie options
[x] can now use default redirect routes with a custom handler (#121)
[x] Add middleware tests for successfulLogin
[x] Add middleware tests for failedLogin
[x] Prevent emitting auth service events (#126)
[x] Add tests to make sure auth service events are not fired
[x] RestrictToOwner hook needs to throw an error (#128)
[x] RestrictToRoles hook needs to throw an error (#127)
[x] OAuth user profile should be updated (#124)
[x] All hooks should support internal usage passthrough (#138)
[x] Clear cookie on logout (#122)
[ ] Update docs, examples and generator
[x] de-auth socket on logout (#136)
[x] get logout integration tests working
[x] Move to bcryptjs instead of native brcrypt
[x] Removes ability to authenticate with the cookie that is used to transmit the JWT to the client

Ok this is good to go! Just need to merge some docs PRs and update the generator to use the restrictToAuthenticated hook.

This isn't actually broken it just depends on https://github.com/feathersjs/feathers-hooks/pull/64.


Allow destroy to work regardless of links

During a deploy, links may not be present

Signed-off-by: Matthew Sykes<EMAIL_ADDRESS>

Thanks @fraenkel
I'm not very familiar with the warden test coverage, would it be reasonable to add a test for this case?

Nope... the problem occurs in the warden_ctl script which drives destroy prior to actually starting warden.

I guess you could argue that all destroys should work regardless and so we could run all the destroys when containers do not exist.


Style: Implement lintr

Issue
Closes #40
Description
The details are also up for discussion, but I believe it is necessary to define how the code should be written, so we can keep it clean, consistent and easily understandable. We can automate this process and make sure the code always adheres to the rules by utilizing lintr.
For setup in IDE, please follow this guide.
For Rstudio, in addition I personally recommend checking the Provide R style diagnostics in the Tools -> Global Options -> Code -> Diagnostics. This will display all linter issues within the editor.
For VSCode, I personally recommend installing Error Lens extension for better highlighting.
Definition of Done

[x] basic configuration for lintr implemented
[ ] details of lintr rules discussed and implemented in configuration
[ ] current codebase adheres to applied guidelines

Things to discuss regarding the details of implementation:

Style guide -> is there any style guide we want to adhere to? The standard is tidyverse guide, but we can change things to adhere to our preferences (I am not a fan of couple of rules included), as long as we are consistant.
Line length -> I have bumped it from 80 to 100 due to personal preference. I think even going to 120 is fine.
Assignment -> we can either use = or <- for variable assignment, using both is messy. Tidyverse guide suggests <-, I personally dislike it and prefer =. We can do whatever, as long as we are being consistant.

@js3110 Please check again, I have just resolved merge conflicts, should be fine now.

@js3110 I have fixed issues with AUC_mins and slope_manual_NCA_data, as well as download. Plots are displaying now. Please let me know how it looks to you, thank you for your help!

@js3110
I have pushed fixes to the things you have mentioned - seems to work as expected now. Please let me know if you find anything else.


Thank you very much for you work

Thank you for neovide, I really love it!
This is the editor I wanted so much, it's just a missing piece of the puzzle for me!
Animations are awesome, it's just a piece of inspiration for me!

Comments like this are what keep me working on it. Thank you so much.


How To Handling Exception..

I want Handling Exception. for example "Error: Invalid playlist Id"
Api was not thrown Exception. So i don't Handling Exception
help me !!

help me !!

Please read https://github.com/thelinmichael/spotify-web-api-java/blob/master/CONTRIBUTING.md#your-questions. I'm going to close this issue in three days in case you have no more details to share that would allow to help.

I found it thank you!


C# Installation

It’s not about proof; it’s about faith. Faith is what gives life shape and meaning. :100: :+1:


[WIP] Add tests for stripe

Not completed yet. But good for a review.

Thanks @hackerkid !
I'd actually like to split this into two kinds of tests:

Unit tests just testing the zilencer.lib.stripe module
A simple end-to-end test that the billing page works

That way it should be easier to look at the Stripe tests and understand what they're saying; and also the tests of the Stripe integration won't have to change every time we revise how the billing page presents things.
I think the main thing to do to get us there from this version is to take your test_add_card, and cut out the parts where it talks to the view, in favor of calling the zilencer.lib.stripe functions instead. So e.g.
def test_add_card(self, ...):
    self.assertFalse(Customer.objects.filter(realm=self.realm))

    # no login needed
    # instead of `self.client_post("/billing", ...):
    num_cards = save_stripe_token(self.user, "token")
    # no assert_in_success_response needed -- just the fact that `save_stripe_token` didn't raise an exception

    # now check mocks, etc., the same way

Similarly, we can unit-test catch_stripe_errors without involving the details of save_stripe_token -- just directly raise some exceptions (one CardError, one other StripeError, one non-StripeError) and assert how they're covered. After all, your "bad_token" logic is basically just doing that anyway. :-)

@gnprice Updated :)

Thanks @hackerkid ! This looks great -- merged.
I added some small style fixups as 3fba90f6c; take a look at that commit.


[HOLD for payment 2023-12-29] [$500] Request - When editing the IOU, the "Future Dates" are still locked

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.12-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Access staging.new.expensify.com
Sign into a valid account
Click on + > Request > Complete the manual request to any user (Note that HERE you can edit the "Date" to any future date as this is now expected and WAD)
After completing the request click on the IOU twice to get to the "Edit" screen.
Click on the "Date" in the IOU section to edit the date (The issue is here)

Expected Result:
User expects that if it is now intended that the user can send requests for Future dates, that he/she is able to edit future dates in this section as well
Actual Result:
In the edit IOU page, the user is unable to edit for future dates, the dates are locked
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/91bbf30c-2441-4371-b616-fe0d4e280ee3
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01720f5c1caaa419d3
Upwork Job ID:<PHONE_NUMBER>322834432
Last Price Increase: 2023-12-13
Automatic offers:

jjcoffee | Reviewer | 28060237
DylanDylann | Contributor | 28060239

Proposal
Please re-state the problem that we are trying to solve in this issue.
Request - When editing the IOU, the "Future Dates" are still locked
What is the root cause of that problem?
max date is now
https://github.com/Expensify/App/blob/958c4312e6713e9ad76174a5f3c95e02dbf21576/src/pages/EditRequestCreatedPage.js#L37-L42
What changes do you think we should make in order to solve the problem?
make max date after 20 years as done in other places

Proposal
Please re-state the problem that we are trying to solve in this issue.
In the edit IOU page, the user is unable to edit for future dates, the dates are locked
What is the root cause of that problem?
In the edit date page, we are setting max date is now
https://github.com/Expensify/App/blob/b950c1eae5535abd5e733a5f9eeecd1bd42b8464/src/pages/EditRequestCreatedPage.js#L41
In the create date page, we are setting max date after 1 year
https://github.com/Expensify/App/blob/b950c1eae5535abd5e733a5f9eeecd1bd42b8464/src/pages/iou/request/step/IOURequestStepDate.js#L74
It seems we don't allow editing dates to the future date in the request money flow. This difference is caused by this PR I am not sure why in this PR we allow editing date to the future date
Note that in the old component
https://github.com/Expensify/App/blob/b950c1eae5535abd5e733a5f9eeecd1bd42b8464/src/pages/iou/MoneyRequestDatePage.js#L106
we also don't allow setting date to the future date
What changes do you think we should make in order to solve the problem?
https://github.com/Expensify/App/blob/b950c1eae5535abd5e733a5f9eeecd1bd42b8464/src/pages/iou/request/step/IOURequestStepDate.js#L74
In here we should update maxDate is now
What alternative solutions did you explore? (Optional)
NA

Very similar proposals that both do the job, but I appreciate the extra attention to detail in @DylanDylann's proposal, particularly adding minDate too and the idea of DRYing up the code by adding a global variable. So let's go with @DylanDylann's proposal!
:ribbon::eyes::ribbon: C+ reviewed

Hello @jjcoffee
i have introduced the minDate as well in my solution so the “core” change is the same ( which is changing the dates) and mine was posted before it .. so please can you have another look.
Thanks

Thanks for the advice I’ll consider that in my future proposals .. but as you said the two proposals are very similar that means we should go with the one posted first
Lets see what @tylerkaraszewski thinks

@jjcoffee The PR is ready for review https://github.com/Expensify/App/pull/33148

Here is the payment summary:

External issue reporter - N/A
Contributor that fixed the issue @DylanDylann $500
Contributor+ that helped on the issue and/or PR @jjcoffee $500

Upwork Job: https://www.upwork.com/jobs/~01720f5c1caaa419d3
Extra Notes regarding payment: Heads up, I'm OOO until January 4, but I will log in on Friday, December 29 to complete this payment process pending no regression. I've confirmed that @jjcoffee and @DylanDylann are a pending hire, so all set here for the payment date.
@jjcoffee please complete the checklist when you can, thanks!

Closing - Thank you everyone for your patience here. I've completed the payment process in Upwork and closed this job.
Happy New Year!
@jjcoffee - please complete the checklist when you get a chance, thanks!

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/28618
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28618/files#r1439418407
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Click on + > Request > Complete the manual request to any user (Note that HERE you can edit the "Date" to any future date as this is now expected and WAD)
After completing the request click on the IOU twice to get to the "Edit" screen.
Click on the "Date" in the IOU section to edit the date
Verify that we can select a date in the future

Do we agree 👍 or 👎


Use a common thread local queue for enqueued celery tasks

What ever happened with this? It seemed like it was very important to what you were doing.

@brianjgeiger it is merged/deployed in feature/admin-app-prod. But yeah I totally agree that this should be included in the next release.

This code was added in https://github.com/CenterForOpenScience/osf.io/commit/9c2729cf6d48667b3585cf05b4d7b332baf648e9


Add support for factory-based Flask initialization

Flask application can be created with create_app factory. This way is preferable if we don't want to initalize the web server when invoking filabel from CL. With this change we can test programs written using any of the two approaches.

330f5e6c994456ca9

Thank you!


In ipython-kernel, EasyKernel.replyTo creates incomplete KernelInfoReply

My first attempt at a custom kernel crashes with the following message:
[W 14:48:28.660 NotebookApp] 404 GET /nbextensions/widgets/notebook/js/extension.js?v=20160528144808 (::1) 1.56ms referer=http://localhost:8888/notebooks/PropLogic1.ipynb
KernelInfoRequest {header = MessageHeader {identifiers = ["\NUL\244\176\220Q"], parentHeader = Nothing, metadata = fromList [], messageId = UUID {uuidToString = "bb214027-fa68-4dbb-80ed-e0948a7b8156"}, sessionId = UUID {uuidToString = "76434A610DBA44D38763C4952471163C"}, username = "kahl", msgType = KernelInfoRequestMessage}}
ICalcCheck: src/IHaskell/IPython/EasyKernel.hs:(160,5)-(165,7): Missing field in record construction protocolVersion

Trying to hunt this down, I find that the definition of IHaskell.IPython.EasyKernel.replyTo contains:
replyTo config _ _ KernelInfoRequest{} replyHeader =
  return
    KernelInfoReply
      { header = replyHeader
      , languageInfo = kernelLanguageInfo config
      , implementation = "ipython-kernel.EasyKernel"
      , implementationVersion = "0.0"
      }

But in IHaskell.IPython.Types, the relevant part of data Message is:
             -- | A response to a KernelInfoRequest.
               KernelInfoReply
                 { header :: MessageHeader
                 , protocolVersion :: String -- ^ current protocol version, major and minor
                 , banner :: String -- ^ Kernel information description e.g. (IHaskell <IP_ADDRESS> GHC 7.10.2)
                 , implementation :: String -- ^ e.g. IHaskell
                 , implementationVersion :: String -- ^ The version of the implementation
                 , languageInfo :: LanguageInfo
                 }

Now banner looks like something that should probably be populated from the KernelConfig or LanguageInfo, but, being new to IPython/Jupyter, I have no idea what protocolVersion should be.

protocolVersion specifies the version of the messaging specification being used by the kernel. I think IHaskell uses the value "5.0" for it,
banner is a string shown as a one line description of the kernel in some places.

On Sat, May 28, 2016 at 06:45:51PM -0700, Sumit Sahrawat wrote:

protocolVersion specifies the version of the messaging specification being used by the kernel. I think IHaskell uses the value "5.0" for it,
banner is a string shown as a one line description of the kernel in some places.

In my opinion, EasyKernel should either produce these, or provide an interface for supplying them.

The commit 4ea7977460d9cb22eaaea6576734cecf4868c7ed looks mostly right (the previous one not).
Thank you!
The documentation of kernelProtocolVersion,
         -- | The version of the messaging specification used by the kernel

presumably is a specification from the Jupyter/IPython side? Could there perhaps be a link that helps an EasyKernel user find out which version to use?
Does it really make sense to have
       , implementation = "ipython-kernel.EasyKernel"
       , implementationVersion = "0.0"

constant? There could be vastly different kernels generated from EasyKernel, and I would consider these the implementations...
If yes: Is there any relation between the "0.0" here, and the ipython-kernel version number <IP_ADDRESS>?
I would have taken implementationVersion to be the version of my implementation, which is what
 , implementationVersion :: String -- ^ The version of the implementation

in the documentation of KernelInfoReply in IHaskell/IPython/Types.hs appears to suggest.
While you are at it: I found the documentation of languageCodeMirrorMode not only unsatisfactory (what is this meant to be?), but also confusing, since it mentions null, linked to Data.Foldable, instead of the string "null".
What is languageFileExtension used for? In the case of IHaskell, I don't think it can be saying that an IHaskell notebook is a .hs file, so this also deserves more documentation.
(The languageVersion documentation is missing an “e.g.,”.)
Seen in 72ccad9b08c028911c96e153cca100d0bcb5a71b: The documentation of banner, now split over two lines, looks even more cryptic than before. Are the parentheses intended to be part of the “e.g.” example? Or is the content of the parentheses intended to be two examples? Since the type of banner is String, having strings as examples would be more precise.

If yes: Is there any relation between the "0.0" here, and the ipython-kernel version number <IP_ADDRESS>?

No, nope.
I'm not sure about the questions you've raised. Only @gibiansky can say more about that.
Those changes are meant to satisfy the formatting specification (enforced by hindent). I agree that it could be made clearer by using quotes to specify a String.

@WolframKahl To answer some of the questions:

kernelProtocolVersion: The Jupyter project versions their protocols, but newer frontends can talk to older kernels. So if our kernel serves protocol 4.0, the Jupyter frontend can potentially automatically convert it to version 5.0 on its side; however, it needs to know what protocol the kernel expects. That is what this kernelProtocolVersion is. I believe we support 4.0 and most of 5.0 (they overlap greatly so I'm actually not 100% sure).
implementation and implementationVersion could definitely be made configurable.
languageFileExtension is the file extension that will be appended when you 'Save As'. It makes less sense in Haskell, because an IHaskell notebook not necessarily a valid .hs file; in Python though any notebook can be converted to a script.
languageCodeMirrorMode is the mode that will be set for the CodeMirror editor in the notebook view. You are right that null should not link to Data.Foldable.

Let me know if you have any more questions – and let's keep this issue open so that we can fix all these confusing points.
I have been away from IHaskell for a while but soon should have time to return and do some cleanup and maintenance.

(Sorry, didn't mean to close it.)


Make fields with prose statements support markdown

There are statements in the controls descriptions and guidance areas where markdown is not supported which can make it hard to read. Convert prose statements in the guidance and descriptions of controls into markdown.
This is came from issue https://github.com/EasyDynamics/oscal-react-library/pull/546

Following shows that the formatting is changed to have a new line before and after all of the orange placeholder texts. Content remains the same however the markdown in prose has been addressed

Here is the summary of the big fixes from this issue in the Editor

Above, Guidance button linking, Middle: Guidance descriptions without placeholder text Bottom: Bold and Italics

To fix some issues with history, this is being redone in #559


Develop/edit project

testing template for project section

👷 Deploy Preview for sit-cybersecurity processing.

Name
Link

🔨 Latest commit
7c49435943d341baafa4d9785355b74c0a4ab2ce

🔍 Latest deploy log
https://app.netlify.com/sites/sit-cybersecurity/deploys/64780b6ddddbee0008d874ec


LastSpawned entity output returns null

When using the contraption spawner:
LastSpawned = (null) regardless of whether an entity has been spawned from the contraption spawner or not

I'm curious as to what it's actually supposed to output. An array of entities?

Where it creates the output it says it's an entity, though I don't see any actual code for where it triggers or sets the output


Update CLOUD_PROVIDER for new valid options

Ref https://github.com/elastic/apm/issues/289

Also refs #822

:green_heart: Build Succeeded

Expand to view the summary

Build stats

Build Cause: [Pull request #878 opened]

Start Time: 2020-07-01T15:27:53.900+0000

Duration: 27 min 40 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
10672

Skipped
7953

Total
18625


:construction: apply tutorial from flutter github to migrate

Hi!
We're having some issues with the image cropper plugin as its made with the new Android Flutter Plugin system whereas we're currently still using the old one.
I have follow the steps on migrating as indicated here, but we have 2 custom plugins, the Share plugin and the ImageConvertor plugin we need to migrate in order for the app to work again. The instructions for this are here https://flutter.dev/docs/development/packages-and-plugins/plugin-api-migration .

Taking a look at this now.