Feature Request: Create Brewfile with minimal set of formulae/casks

A growing trend in package managers (like pipenv or npm) is to produce a specification with both the minimal set of packages (ones that were installed explicitily), as well as a complete set of packages that also include dependencies (for a deterministic build).
Bringing this feature to brew has been discussed before in issues #246 and #236 , and there was a desire to implement it at some point when possible/feasible. I was wondering if this is still something that is of interest to bring to brew?
As a sidenote, I must admit, the use cases are definitely niche. For example, adding a Brewfile to your dotfiles repo, but in those use cases, it would be nice to have a minimal specification of required packages instead of one that includes everything. Currently, the workaround is to either maintain your own set of packages (in some script or file), or to parse the output brew leaves and brew list --casks to produce your own Brewfile. Both workarounds are hacky, and the latter is unreliable.

I don't think anything as changed in this space since those issues were closed and I'm still onboard with @MikeMcQuaid's comments around only keeping the top level packages in the Brewfile for the problems mentioned.
As it stands, Homebrew doesn't guarantee a deterministic run in any form so if that is a goal, you're looking at the wrong tool.

I don't think anything as changed in this space since those issues were closed and I'm still onboard with @MikeMcQuaid's comments around only keeping the top level packages in the Brewfile for the problems mentioned.
As it stands, Homebrew doesn't guarantee a deterministic run in any form so if that is a goal, you're looking at the wrong tool.

as well as a complete set of packages that also include dependencies (for a deterministic build).

The closest thing we have to a deterministic build is the Brewfile.lock.json file that's output.

For example, adding a Brewfile to your dotfiles repo, but in those use cases, it would be nice to have a minimal specification of required packages instead of one that includes everything.

It doesn't include everything. brew bundle dump --force doesn't install packages that were just installed as dependencies.
As a result: this is all pretty much implemented as much as it can be.

as well as a complete set of packages that also include dependencies (for a deterministic build).

The closest thing we have to a deterministic build is the Brewfile.lock.json file that's output.

For example, adding a Brewfile to your dotfiles repo, but in those use cases, it would be nice to have a minimal specification of required packages instead of one that includes everything.

It doesn't include everything. brew bundle dump --force doesn't install packages that were just installed as dependencies.
As a result: this is all pretty much implemented as much as it can be.

I don't think anything as changed in this space since those issues were closed

It doesn't include everything. brew bundle dump --force doesn't install packages that were just installed as dependencies.

@jacobbednarz @MikeMcQuaid Are y'all sure about this? Did something recently change?
I recently started seeing dependencies I didn't install in my brewfile (even though I'm using brew bundle dump --force). I don't know if maybe I did something, but I came here to file this same request (not knowing the history of it).

I don't think anything as changed in this space since those issues were closed

It doesn't include everything. brew bundle dump --force doesn't install packages that were just installed as dependencies.

@jacobbednarz @MikeMcQuaid Are y'all sure about this? Did something recently change?
I recently started seeing dependencies I didn't install in my brewfile (even though I'm using brew bundle dump --force). I don't know if maybe I did something, but I came here to file this same request (not knowing the history of it).

I'm not very familiar with bundle, so please forgive me if this is the wrong approach, but when I run git bisect and brew bundle dump, it looks to me like this commit might have introduced a regression.
Before that commit, running brew bundle dump does not show dependencies. But starting with that commit (running on the same system), I get the dependencies in my brewfile.

I'm not very familiar with bundle, so please forgive me if this is the wrong approach, but when I run git bisect and brew bundle dump, it looks to me like this commit might have introduced a regression.
Before that commit, running brew bundle dump does not show dependencies. But starting with that commit (running on the same system), I get the dependencies in my brewfile.

Actually, that might be a red herring above. The change below fixes the behavior for me, so my guess is there's an upstream problem in homebrew where everything has installed_on_request as true.
diff --git a/lib/bundle/brew_dumper.rb b/lib/bundle/brew_dumper.rb
index e07bfe1..97754e4 100644
--- a/lib/bundle/brew_dumper.rb
+++ b/lib/bundle/brew_dumper.rb
@@ -24,7 +24,7 @@ module Bundle

     def dump(describe: false, no_restart: false)
       requested_formula = formulae.select do |f|
-        f[:installed_on_request?] || !f[:installed_as_dependency?]
+        !f[:installed_as_dependency?]
       end
       requested_formula.map do |f|
         brewline = ""

Anyway, I'm not a ruby dev, so I don't have time to stumble through the homebrew code to continue hunting this down. Hope this has been useful!

Actually, that might be a red herring above. The change below fixes the behavior for me, so my guess is there's an upstream problem in homebrew where everything has installed_on_request as true.
diff --git a/lib/bundle/brew_dumper.rb b/lib/bundle/brew_dumper.rb
index e07bfe1..97754e4 100644
--- a/lib/bundle/brew_dumper.rb
+++ b/lib/bundle/brew_dumper.rb
@@ -24,7 +24,7 @@ module Bundle

     def dump(describe: false, no_restart: false)
       requested_formula = formulae.select do |f|
-        f[:installed_on_request?] || !f[:installed_as_dependency?]
+        !f[:installed_as_dependency?]
       end
       requested_formula.map do |f|
         brewline = ""

Anyway, I'm not a ruby dev, so I don't have time to stumble through the homebrew code to continue hunting this down. Hope this has been useful!

Are y'all sure about this?

Yes.

Did something recently change?

No.

Are y'all sure about this?

Yes.

Did something recently change?

No.

Are y'all sure about this?

Yes.

Did something recently change?

No.

Cool.
Anything about the other stuff I said?

Are y'all sure about this?

Yes.

Did something recently change?

No.

Cool.
Anything about the other stuff I said?

@wren If you have a reproducible bug report: we can investigate it. Otherwise: nothing to add really, sorry.

@wren If you have a reproducible bug report: we can investigate it. Otherwise: nothing to add really, sorry.

@jaymody @wren I just noticed an edge case (I have on idea how long it's been there) where dependencies could be incorrectly marked as "installed on request" in their Tab (which is what brew bundle reads from). This should be fixed by https://github.com/Homebrew/brew/pull/10681 (but would require reinstalling everything not listed in brew leaves after it's merged).


Adds Nutanix and VMware as valid words

Hopefully I have done this correctly :crossed_fingers:

Opps! We should have added the fixture in the corresponding file. Every rule has a corresponding fixture, eg., .vale/styles/RedHat/Spelling.yml >>>  .vale/fixtures/RedHat/Spelling/testvalid.adoc
Fixed in https://github.com/redhat-documentation/vale-at-red-hat/pull/546


Add irrigator (ggq) to switch, on/off functionality for climate devices with no modes

Only supports on/off as that's currently all the api gives us.  It would be good if the API could allow switching on/off of individual zones and Start A/B/C similar to how the irrigator appears in the TuyaSmart app

This will probably fix #78, #149, #197, #208, #249 & #357


Issue and Pull Request Templates

Summary
Includes default templates for bugs, feature requests, and pull requests. The hope is that this will make it easier for both internal and external contributors to participate in development, make it easier to organize issues/PRs in GitHub. These were adapted from Report a Cybercrime and CPP Disability projects.
Other references:

Trello

Test instructions
Unfortunately, this can't be tested until merged, but is low impact to do so.
For issues:

Go to this repo
Go to the Issues tab
Click New issue
See the available templates
Choose one
File a new issue
The appropriate labels should be added

For a PR:

Go to this repo
Create a branch with a change
Go to the Pull requests tab
Click New pull request
See boilerplate text

Help requested
Would appreciate a reviewer to see if the text is clear and helpful in the templates.
Unresolved questions
If these templates are acceptable, I'll merge and then get them translated into French.

We should really have these templates translated @jeffmaher. They look great though.. Definitely should push these up into our default template library.

We should really have these templates translated @jeffmaher. They look great though.. Definitely should push these up into our default template library.

Totally agree on both counts!

Adding a note here that French translation is in progress. Earliest will be EOD tomorrow, latest is end of day Tuesday.


✨ Add github action to push on master merge

Signed-off-by: Vince Prignano<EMAIL_ADDRESS>

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

nice one, very clean with just the make commands

/lgtm

/hold cancel


Links to API docs in guides and Babylon101

It would be helpful to have links to the corresponding API class documentation within guides and other documentation.
For example in https://babylonjsguide.github.io/basics/Cameras#arc-rotate-camera which describes the use of the Arc Rotate Camera there should be a reference to https://doc.babylonjs.com/api/classes/babylon.arcrotatecamera where one can get further information about the properties and methods of the camera.
The same is in https://doc.babylonjs.com/babylon101/cameras#arc-rotate-camera. There should also be a link to the API.
In the other direction on the API page itself a link to the guide would be helpful because the API page is often the first result when googling for ArcRotateCamera and it would be nice to find the information as fast as possible.
I would like to help you with placing those links, what should I do?

That's a good idea!
You can directly updates the .md for the guides in this repo. To get the link back from the API you need to add a @see tag in the code like here: https://github.com/BabylonJS/Babylon.js/blob/da661ef2153e10b0e424c6f93792159b53a0a47f/src/Animations/easing.ts#L6

Closing as merged


Webpart not loading

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.
Category

[ ] Question
[ ] Typo
[#] Bug
[ ] Enhancement / Suggestion
[ ] Additional article idea

Expected or Desired Behavior
Helloworld webpart should load on page load.
Observed Behavior
Getting error
[SPWebPartErrorCode.ScriptLoadError]:: Unable to load web part WebPart.HelloWorldWebPart.g_9d4eabe5_f55d_4675_9373_1c44b7ca5f39,Error: ***Failed to component "7af95477-fc6b-412e-a4b8-24bd46566bf2" (HelloWorldWebPart). Original error: Error loading https://component-id.invalid/7af95477-fc6b-412e-a4b8-24bd46566bf2_0.0.1 script resources due to: undefined. CALLSTACK:: Error at t [as constructor] (https://spoprod-a.akamaihd.net/files/sp-client-prod-npmx_2017-01-02.009/sp-loader_en-us_529d543c5cdfae3136128abb7f516ada.js:60:15897) at new t (https://spoprod-a.akamaihd.net/files/sp-client-prod-npmx_2017-01-02.009/sp-webpart-base_en-us_cc837bf83be14d559d8c0d7bfe1bc34f.js:47:21831) at Function.t.create (https://spoprod-a.akamaihd.net/files/sp-client-prod-npmx_2017-01-02.009/sp-webpart-base_en-us_cc837bf83be14d559d8c0d7bfe1bc34f.js:47:22244) at https://spoprod-a.akamaihd.net/files/sp-client-prod-npmx_2017-01-02.009/sp-webpart-base_en-us_cc837bf83be14d559d8c0d7bfe1bc34f.js:48:206
Steps to Reproduce
Create a new Webpart
Gulp Bundle --ship
Gulp package-solution --ship
Webpart is working on workbench but after package and deploying to any site getting above error. The same part of code was working till yesterday in Test tenant and issue was only till dev tenant but now it stopped working in all of our tenants(devs and test).
Checked issue #340 as well. But is there any way we can fix error in the webparts which is there already instead creating a new fresh webpart and migrating old webparts.
 Can you please run gulp serve and try your scenario? My guess is that you uploaded the package without uploading your scripts to a CDN and you are not running gulp serve.

RC0 has rolled to all farms.  The reference to sp-client-base at 0.5.1 shows that you are still using the drop6 code.  View the release notes here - https://github.com/SharePoint/sp-dev-docs/wiki/Release-Notes-RC0


type error

Thanks for your codes,I am running vistechnique.py,meeting the error:TypeError: create_info() got an unexpected keyword argument 'montage',I think it may be python version problem ,did you meet the problem?

"The file "VisTechnique.py" has been tested on library mne v0.18 and v0.19.2. It works perfectly for v0.18, while there will be some Deprecation Warnings for v0.19.2."
Can I know what version of mne do you use?

Thanks for your codes,I am running vistechnique.py,meeting the error:TypeError: create_info() got an unexpected keyword argument 'montage',I think it may be python version problem ,did you meet the problem?

Thanks for your reply,I have just solve the problem by changing the "montage = 'standard_1020"and"montage=montage" to"info.set_montage('standard_1020')",it works well. Thank you again!

"The file "VisTechnique.py" has been tested on library mne v0.18 and v0.19.2. It works perfectly for v0.18, while there will be some Deprecation Warnings for v0.19.2."
Can I know what version of mne do you use?
From: DIFFI1 @.>
Sent: Monday, 26 September 2022 9:50 am
To: cuijiancorbin/EEG-based-Cross-Subject-Driver-Drowsiness-Recognition-with-an-Interpretable-CNN @.>
Cc: Subscribed @.***>
Subject: [cuijiancorbin/EEG-based-Cross-Subject-Driver-Drowsiness-Recognition-with-an-Interpretable-CNN] type error (Issue #1)
Thanks for your codes,I am running vistechnique.py,meeting the error:TypeError: create_info() got an unexpected keyword argument 'montage',I think it may be python version problem ,did you meet the problem?
—
Reply to this email directly, view it on GitHub https://github.com/cuijiancorbin/EEG-based-Cross-Subject-Driver-Drowsiness-Recognition-with-an-Interpretable-CNN/issues/1 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCCPVFUGQEMOVOHEZNV26TWAD6M5ANCNFSM6AAAAAAQVLCAPA .
You are receiving this because you are subscribed to this thread.  https://github.com/notifications/beacon/ADCCPVH4FBRIGCLM6DIFNFTWAD6M5A5CNFSM6AAAAAAQVLCAPCWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFFEOANQ.gif Message ID: @.*** @.***> >


Integration ffmpeg 7.0 Windows

Hello
I try the same modification that ffmpeg 6.1.1 ffmpegPath=https://git.ffmpeg.org/ffmpeg.git#tag=n7.0 with no error of compilation
but at final libvvenc is not include.
Thanks for all.

It is very clearly stated which versions this works with.
See

https://github.com/fraunhoferhhi/vvenc/issues/367
https://github.com/fraunhoferhhi/vvenc/issues/361


tools: fix diagnostics error when default terminal width <= 80

Since I'm not familiar with Python language, I strongly recommend Python Master here to review this, thanks.

Thanks a lot for your fix.


Make Bulk.toString() actually return a string

Before this change it returns an object, which seems confusing.

This PR breaks the tests a bit

I've updated the test.  Hopefully that will fix it.

Still no luck with the pull request. Tests are failing. You can run npm test locally to see if code style conforms to standard code style.

Updated


nous-hermes2 stops generating output in the middle of a sentence

Hello,
After a while of chatting with the nous-hermes2, around 4-10 questions, it stops generating output randomly mid-sentence. I have tried other models such as dolphin-mistral and openhermes, but I have not experienced similar behavior, however these are smaller models.
I cannot see any suspicious output from the logs.
Could this be an issue of VRAM on the GPU?  (Only 8GB)
However, I see that there is never more than 6.8 GB allocated.
Anyone that might have a clue?

Hi @aktersnurra sorry about this. This is hard to troubleshoot.
Does the new recently released Nous Hermes 2 Pro 7B still have this problem? Someone has built a modelfile that you can use to import the model yourself or upload it to Ollama.com:
https://github.com/maxtheman/hermes-pro/blob/main/modelfile
Tagging @teknium1 for visibility and help.

Are you using mixtral 8x7b or mistral 7b?

Hello,
After a while of chatting with the nous-hermes2, around 4-10 questions, it stops generating output randomly mid-sentence. I have tried other models such as dolphin-mistral and openhermes, but I have not experienced similar behavior, however these are smaller models.
I cannot see any suspicious output from the logs.
Could this be an issue of VRAM on the GPU? (Only 8GB)
However, I see that there is never more than 6.8 GB allocated.
Anyone that might have a clue?

Are you using mixtral 8x7b or mistral 7b?

Hello,
After a while of chatting with the nous-hermes2, around 4-10 questions, it stops generating output randomly mid-sentence. I have tried other models such as dolphin-mistral and openhermes, but I have not experienced similar behavior, however these are smaller models.
I cannot see any suspicious output from the logs.
Could this be an issue of VRAM on the GPU? (Only 8GB)
However, I see that there is never more than 6.8 GB allocated.
Anyone that might have a clue?

I am using the 11b:latest version.

Hi @aktersnurra sorry about this. This is hard to troubleshoot.
Does the new recently released Nous Hermes 2 Pro 7B still have this problem? Someone has built a modelfile that you can use to import the model yourself or upload it to Ollama.com:
https://github.com/maxtheman/hermes-pro/blob/main/modelfile
Tagging @teknium1 for visibility and help.

Thanks, I'll test this out and see if this model displays similar behavior or not.

If you're still having trouble with the model, please upgrade to the latest ollama to see if that clears it up.   If not, let us know and I'll reopen the issue.


Introduce hasFeatureAtPixel

This PR is based on #3065.
#3065 implements hit-detection for WebGL, but unfortunately the performance is not good enough to do hit-detection on mousemove (if you have many features). This is because we are calling drawElements for every feature, which is expensive.
For mousemove you are usually not interested in the actual features that forEachFeatureAtPixel provides, you just want to know if there is a feature or not, so that you can change the mouse pointer. So in this case you can draw all features at "once" (or to be precise: per texture group) for the hit-detection, and then check if there is a feature or not.
That's why we introduced a hasFeatureAtPixel method, which simply returns true if there is a feature at the given pixel. For WebGL this function is very fast, for 50000 features it takes less than 20ms (on my system).
Example usage:
$(map.getViewport()).on('mousemove', function(evt) {
  var pixel = map.getEventPixel(evt.originalEvent);
  var hit = map.hasFeatureAtPixel(pixel);
  map.getTarget().style.cursor = hit ? 'pointer' : '';
});

Example: icon-sprite-webgl.html

I like the idea of hasFeatureAtPixel. I think it would make sense to have a basic (albeit inefficient) implementation for all renderers (instead of having the Canvas and DOM implementations return false). It could simply use forEachFeatureAtPixel until a more efficient implementation is written.

In fact, the hasFeatureAtPixel implementation in ol.renderer.Map calls forEachFeatureAtPixel. So there is a default implementation that also works for canvas and DOM.

I think it would make sense instead to update this example to use the new hasFeatureAtPixel method (assuming it works for all renderers).

Good point!

I've just added a pretty minor comment, otherwise looks very good to me.

I just made a comment that @tschaub already made regarding the name opt_this2. This is minor.
Otherwise it looks very good to me. It's good to merge to me.

Thanks for reviewing!


French translation of Table of contents is incorrect

French translation for Table of contents incorrect in: fr.xml (org.dita.pdf2)
Observed in Dita OT ver 2.1.0 and earlier.
My localization vendor says that the following two French localized entries are incorrect:
variable id="Table of Contents": Sommaire
variable id="Contents button title": Sommaire
Expected:
variable id="Table of Contents": Table des matières
variable id="Contents button title": Table des matières
I did check Bing online translator:
Sommaire = Summary
Table des matières = Table of Contents

The common string file xsl\common\strings-fr-fr.xml uses the suggested text:
   <str name="Contents">Table des matières</str>

Checking around with the help of a colleague, it looks like Sommaire is used for some books but is not terribly common, seems to be more like a high-level TOC. I think it's better to use the suggested text Table des matières, which also means our different transforms will pick up the same term.

Corrected to the suggested text for our 2.2 release. Oddly, the suggested text was already used in comments in the file about TOC values, so I'm not sure why it was changed for the actual translated text.


Diff in days returning float

Description of the Issue and Steps to Reproduce:
OK (diff == 1)
moment([2018, 10, 02]).diff(moment([2018, 10, 01]), 'days')
return 1

NOK (diff == 0)
moment([2018, 10, 05]).diff(moment([2018, 10, 04]), 'days')
return 0

With true param:
moment([2018, 10, 05]).diff(moment([2018, 10, 04]), 'days', true)
return 0.9583333333333334

I'm going to have to round off the return of the diff function (in days)?
Sorry for my english.
Environment:
Examples: Chrome 49 on OSX, Internet Explorer 10 on Windows 7, Node.JS 4.4.4 on Ubuntu 16.0.4
Chrome 68 / Node.JS 10.4.0 /  Ubuntu 16.04.2*
Mon Oct 22 2018 13:54:48 GMT-0300 (Brasilia Standard Time)
10/22/2018, 1:54:48 PM
180
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36
2.19.2

Sorry for my english too lol.
Can't reproduce this error:
moment([2018, 10, 05]).diff(moment([2018, 10, 04]), 'days')
return 0

In my try it returns 1.

Hello, I too cannot reproduce this error.
`const moments = require("../moment/moment");
moments([2018, 10, 05]).diff(moments([2018, 10, 04]), 'days');
return 1;
moments([2018, 10, 05]).diff(moments([2018, 10, 04]), 'days', true);
return 1;
`

Please re-open if you still have issues.


Test wheels on all platforms

We currently only test wheels on windows and linux-x86_64. We should test wheels on all platforms, at least during release.
Note that reusable_test_wheels.yml is currently broken (no python 3.8 for arm).

How can it be broken but the CI is not red?


Clarify the Multiple Database Modules documentation using Databinding and Java

DBFlow Version: 4.1.1
Issue Kind: Feature
I suggest you to specify in the Multiple Database Modules for users who are using databinding in Java, to use these instructions
javaCompileOptions {
            annotationProcessorOptions {
                arguments = [ targetModuleName : 'SomeUniqueModuleName' ]
            }
        }

instead of
apt {
    arguments {
        targetModuleName 'SomeUniqueModuleName'
    }
}

since using this link as suggested in that page simply break the databinding feature due to annotationProcessor conflicts.
It took me a while to understand that.

Hi @AngeloAvv ,
I have been trying to get Multiple Module configuration to work, with absolutely no success.
Seems like you got it. Can I please see your configuration on the SomeUniqueModuleName, and the SubModule which implemented the SomeUniqueModuleName.
Thank you!

Thank you! I will update it here: https://dbflow.gitbook.io/dbflow/usage2/advanced-usage/multiplemodules


Install Dependencies of a project

As sfpowerkit is being deprecated in favour of sfpowerscripts as one cli that encompasses all the use cases. sfpowerscripts need a standalone command that brings functionality equivalent to  sfpowerkit's package : dependencies : install  . This will allow scenarios where a pipeline or user has to update dependencies without using prepare, validate or release commands.
The command would use the same underlying code used by other sfpowerscripts command to install dependencies during release etc.

This has been delivered


Bunch of improvements

New visuals for the sailboat in the header. It now overflows the header
and has a slight animation on page load. This is only on larger screens.
The animation is just an experiment, if it's annoying I'll nuke it.

The TOC now highlights the currently displayed portion of the current page.
As you scroll through the doc, the selected entry updates accordingly.

Add previous/next page links in every doc page. These used to be present only in
blog posts, but they're useful everywhere.

Fix a few off-by-one formatting errors that stemed from using a mixed of
min-width and max-width throughout the stylesheet. This caused some strange
formatting to happen at specific window widths. Now, we're consistently using
min-width and everything lines up properly.

Improved footer formatting so it looks better on mobile.

Only display the TOC on XL screens, otherwise it wraps too much.
Screens smaller than XL now all get the inlined TOC instead.

Add support for pages to request that the TOC be generated inline instead of in a sidebar.
This is useful for pages that have headings which cause too much wrapping in the TOC,
such as the Troubleshooting Guide.

Add some blank space between an inlined TOC and the main text so that things don't look
so crowded, especially when printing.

Inline the sailboat SVG into each page. This avoids a network roundtrip and allows the
SVG to be controlled with the same CSS as everything else.

Eliminate a huge amount of redundancy in the four main layout filew for the site.
They now share a single primary.html include file which carries most of the weight. This
will avoid having to constantly make the same change in four different files.

Improve the generated HTML for FIGURE elements which makes
things better for screen readers.

Simplify the HTML & CSS for the footer.

Staging: https://geeknoid.github.io/istio.github.io/

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
Assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

It all looks good except for the animation on the sailboat on page load: IMO it's fairly annoying. I really dislike anything shifting on the page after load, and I don't think that the animation is highlighting anything important (i.e. by making it move we're visually signalling that it's important, but really it's just the logo).

Animation nuked...
Thanks.


core-domain the data type of attributes field in DeviceObject is not generic "object"

In the original data model design, the data type of attributes field in DeviceObject is a generic "object".
In the current source code, it is map[string]string, which restrict the extension capability of data model.
https://github.com/edgexfoundry/edgex-go/blob/master/core/domain/models/deviceobject.go
Different kinds of device resource might need different kinds of attributes.
map[string]string means the attribute value can only be string type.  For example, if any of attribute is an array, the following error will occur:
unmarshal errors:
line 85: cannot unmarshal !!seq into string

@cloudxxx8 Is there a specific test case where you came across this issue? Golang doesn't have an object type in the same manner as Java. If you have a specific use case, we can look at it to try and devise a solution.

@tsconn23
We are using different kinds of devices and protocols, and they all have different attributes.  We need the capability to extend the domain model to fit the variety of IoT requirement.  The attribute might numeric type, an array, or another object.  I believe lots of users will encounter the same issue.
In order to set it as generic object in golong, we can simply use map[string]interface{} to replace map[string]string

@tsconn23
In Device and DeviceProfile domain model, we have already used interface{} for location and objects field
https://github.com/edgexfoundry/edgex-go/blob/master/core/domain/models/device.go
https://github.com/edgexfoundry/edgex-go/blob/master/core/domain/models/deviceprofile.go

@cloudxxx8 Since you have an approach and know how to duplicate the error condition, do you want to make that code change, test it and then submit a PR? Sounds like a 1 line change.

ok, please assign this issue to me.
I will run the unit test and black box test to make sure it works fine before creating the pull request

@tsconn23
please help review the change, thanks
https://github.com/edgexfoundry/edgex-go/pull/275

Merged. Thanks.


:bug: GuildMember.permissions does not take account of owner

Describe the bug
GuildMember.permissions should return all permissions if the member is the owner
Steps to Reproduce
1. add a `return ctx.author.permissions` in a command
2. if the member doesn't have any role, it will return 0

Relevant console output
0
Pincer Version used
git

Closed due to depreciation, thank you for your effort ♥


load_stats: fix race condition.

This PR avoids a situation in which we were losing track of data plane requests as follow:

Management server asks Envoy to track load stats for cluster Foo in a LoadStatsResponse for a 10s
period. Envoy resets stats for Foo.
After the 10s timer, Envoy responds with Foo's stats, resetting them.
Management server asks Envoy to track load stats for cluster Foo in a LoadStatsResponse for a 10s
period. Envoy resets stats for Foo.
After the 10s timer, Envoy responds with Foo's stats, resetting them.

Between 2 and 3, any stats for Foo requests that arrive were previously unaccounted for. We resolve
this (in a relatively backward compatible way) by not making any protocol changes except to require
Envoy to not reset stats for already tracked clusters.
If we were to design LRS from scratch to avoid this, there are better approaches, e.g. making it a
periodic reporting service rather than request-response, but we probably already have a bunch of
existing users of LRS and don't want to break them.
Rist Level: Low
Testing: Modified load_stats_integration_test.
Signed-off-by: Harvey Tuch<EMAIL_ADDRESS>

Planning on adding a per-cluster measure time interval to this as well, to support a feedback loop for the management server.

This is now ready for review.

@kyessenov can you take a first pass?


Dynamically switching between tree data view and normal view is not working

I want to dynamically decide to show tree data view or normal view
so, I am passing parentChildData property dynamically as below
 const parentChildData = (row: any, rows: any) =>rows.find((a: any) => a.id === row.parentId);\
<MaterialTable ..props, parentChildData={showTreeView ? parentChildData : undefined} />
I see that it is not working
Here is the sandbox link
CodeSandbox
Steps to Reproduce -

Go to the sandbox link
Select/Unselect checkbox for "show tree view"
See that it is not showing tree data view

Hi @oze4 , any thoughts on this?

Sorry, just saw this - I've been missing for a little, I apologize.
Let me take a look at this and I will get back to you.


fix(registry): only print one 199 warning

Ref: https://github.com/zkat/pacote/commit/2f8c201a5d0284f6c2d67a17e55f7ee24c87876b#commitcomment-22440649

thanks! 👍


HMR support broken

For some reason every time the parent component is HMR updated, vue-pdf-embed refuses to load the document. As if it has a memory that it already loaded it, but hasn't actually.
To reproduce just make a one line script change, white space works. Vite will then HMR your component and the pdf will not load, despite having a valid URL.
My workaround is to use an objectUrl as source...
const fetchRes = await fetch(this.source)
const pdfBlob = await fetchRes.blob()
this.pdfObjectUrl = window.URL.createObjectURL(pdfBlob) // src

Reproduction

Hi @FossPrime,
Sorry, it's not clear from the description what exactly is wrong. Could you please rephrase it?

Hi @FossPrime,
Sorry, it's not clear from the description what exactly is wrong. Could you please rephrase it?

It's harder to develop because any hot module reloading events break the component. This only affects the developer experience, not the end user running vite build output.

I couldn't reproduce it in the Stackblitz project you provided (nothing breaks on changes)

This should be resolved after several memory usage optimizations and switching to Vite
Please try v2.0.0 and reopen the issue if needed


Export all data points if no aggregation is chosen

We should allow Views to operate without any aggregation and make them report all the collected measurements collected on the export path.
This might be also good enough to support gauges and user can decide the stats.Record rate themselves if they don't want every available metric not being reported.

We decided not to implement this behavior given it might bloat the memory very quickly. We have a different abstraction layer coming up to support gauges.


if/else/each keywords

A form of the if keyword is being requested here: https://github.com/mustache/spec/pull/22
And similarly a form of the each keyword here: https://github.com/mustache/spec/pull/23
@janl made a request for an easier else too: http://writing.jan.io/mustache-2.0.html
I think obscuring the meaning of something that actually means each down to a one symbol: , is stupid and not the hard to read and learn.
@wesen, is there any reason you want short symbols instead of real keywords?
This should be part of Mustache 2.0.
Handlebars also has with and unless keywords, which we could consider.

I also would like to see an explicit "if" syntax, like @wesen mentioned in https://github.com/mustache/spec/issues/55#issuecomment-9936333.
I would enhance the syntax like so:
{{?products}}
Product names:
{{#products}}{{name}}{{/products}}
{{^products}}
No products.
{{/products}}


Adding sparse histogram support

This PR will add following function for sparse histograms

[x] rate()
[x] increase()
[x] delta()

Issues: https://github.com/thanos-community/promql-engine/issues/149

Looks like we're good for now, we can add support for sum and histogram_x functions in followup PRs.


Added connection type check back

This fixes #673 and enables the use of alternative drivers such as sqlite for unit tests.

Can you give me an example use case why this would be useful?

When running unit tests I set sqlite as a global database driver to run tests in memory. This means that newBaseQueryBuilder gets called with an sqlite instance. Since Jenssegers\Mongodb\Query\Builder only accepts a Jenssegers\Mongodb\Connection all tests fail with the following exception:
Argument 1 passed to Jenssegers\Mongodb\Query\Builder::__construct() must be an instance of Jenssegers\Mongodb\Connection, instance of lluminate\Database\SQLiteConnection given, called in /[...]/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Model.php on line 519

With this check, the code falls back to the default Illuminate\Database\Query\Builder and you are able to run the tests with the sqlite driver.
Obviously not the most beautiful solution, but without the check is is pretty hard to use in memory tests.
You know of a better solution to this problem?

I'm not sure if the model would even work if you would give it an SQLiteConnection.


feat(tutorial): complete step 4 - Boeblingen

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

@lakeside76 Looks amazing 🔝! I've recorded your completion of step 4.


Details for training few-shot detectors on FSC 147 dataset.

Thank you for elaborating a comprehensive dataset and a well-designed class-agnostic counting model. We are particular interested in some details on training Few-shot detectors on FSC 147 dataset.
As you have mentioned in the paper, FR few-shot detector and FSOD few-shot detector are trained on FSC 147 dataset for comparison. As the training of detector requires bounding box annotations, did you annotated all bounding boxes on the training set, or swapping the task head of detectors to density map regressors?
We are currently testing few-shot detectors on FSC 147 dataset. We want to follow your settings. It could not be better if you can release the training code for few-shot detectors.
Thanks again for such a fundamental and solid work.

Hey,
Thanks for your interest in our work. For training the few-shot detectors, we propagate the bounding boxes from the exemplars to the dot annotated examples, i.e. we first compute the average bounding box size from the exemplar bounding boxes for an image, and place this average bounding box around the rest of the dot annotated instances (which do not have bounding box annotation) in the image.
Currently we aren't planning on releasing the code for the baseline approaches in our paper, but we would be happy to answer any of your queries about them.

Thank you so much for your reply! You have solved my issues.


UnicodeTranslatorFromDescriptor can return nil

Hi,
In the doc of UnicodeTranslatorFromDescriptor it says:

// If an error occurs reading the descriptor, the returned function is valid
// but does not perform any rune translation.

But if the pdf is in error it return nil if f.err != nil { return }  which panic if we use this nil function of course.
Is it a mistake ?

Good catch, @flibustenet. Corrected in ef5029596657de75a312ed095fd29ec7aacee058

I had a bug report at 17:20, 20 minutes after i could see from where it come thanks to clearness of Go and 2 hours after you corrected it on the other side of the ocean for all the community. It's amazing.
Thanks

Your identification of the problematic code made the solution easy!
Wonderful pictures of bicycling through France. Delightful.


#207 rollup compaction simplified

Description
A simplified approach to multi-block files and the rollup compaction #207. It is not a full solution, but an initial attempt to use multi-block files for indexing and queries. Replication is out of scope.

This PR is closed because of incorrect target branch. The correct PR is #225


No module named 'cryptography' error

Hi! Your project looks very interesting but I can't get it to run on my machine. I have installed everything you've said in the instructions and I have added python's cryptography package through pip, but it still gives me:
~/DEDSEC_PTZ_STRM_EXPLOIT$ sudo ./dedsec_ptz_strm Traceback (most recent call last):   File "/exec/68747470733a2f2f692e696d6775722e636f6d2f6a76654d44416a2e706e67", line 2, in <module>   File "<string>", line 3, in <module> ModuleNotFoundError: No module named 'cryptography'
Could you help me out as to why it's not able to find that module?

this code use python3.11


add carthage support

hey @thii, I saw you reverted this merge, what happened?

@AndrewSB Sorry for not checking it carefully before merging.

Ahh, I'm sorry about that. I'm going to create a new pull request, I'll make sure the tests are passing (would love your input if they're not)

working on this in #21


Missing addProtocol method fot custom protocols, Protomaps / pmtiles support

Motivation
At the moment, we have a frontend integration with Protomaps vector tiles, that have a full support of Maplibre GL:
https://protomaps.com/docs/frontends/maplibre
Inside our Mobile application, we use Maplibre as tool for rendering maps, but we don't have a chance to render same vector tiles since this custom protocol is not supported out of the box, and there's no way to add it.
Implementation
Expectations is to have the same addProtocol method to provide a loadFn for custom tile servers like pmtiles.
import * as pmtiles from "pmtiles";

let protocol = new pmtiles.Protocol();
maplibregl.addProtocol("pmtiles",protocol.tile);

If there's any known workaround to provide support for custom protocol using the existing Maplibre API,
I'd appreciate any directions / advices.

Hi @punov
I didn't got deep into it, but if I understand it right the addProtocol method in maplibre-gl-js is used to override with javascript code the tiles fetching when using a specific protocol in source url.
As this maplibre-react-native lib is a wrapper on top of maplibre-gl-native - and not maplibre-gl-js, fetching the tiles is made at the native level, and you won't be able to customize it with javascript code.
I'm unsure if it may be customized at the android / iOS level (with java/objectiveC or kotlin/swift hooks) or if it requires to go deeper at the C++ level.

@jthiard thanks for your answer, after going through the source code, I have the same understanding.
I'm ok to customize the native code to support it, but at the moment I struggle finding the proper hook for tileserver fetch operations.
addProtocol method is as simple as calling the function to fetch the data according to current coordinates and zoom level,
so getting closer to the function that executes it in native code is a step #1 for me.

@punov You'll be looking for functionality around here:
https://github.com/maplibre/maplibre-gl-native/tree/main/src/mbgl/storage
Most likely an adaptation of https://github.com/maplibre/maplibre-gl-native/blob/main/src/mbgl/storage/http_file_source.hpp and https://github.com/maplibre/maplibre-gl-native/blob/main/platform/default/src/mbgl/storage/http_file_source.cpp with some of https://github.com/maplibre/maplibre-gl-native/blob/main/platform/default/src/mbgl/storage/file_source_manager.cpp.
It's a bit of a mess, but generally you can register handlers for types of files, and there's a default FileSourceManager normally invoked. You'll need to create your own and pass it through via ResourceOptions: https://github.com/maplibre/maplibre-gl-native/blob/main/src/mbgl/map/map.cpp#L29.
Does this help point you in the right directly?

Is there any progress on this? Or some instructions on how to do it?

It's currently beeing worked at the MapLibre Native side https://github.com/maplibre/maplibre-native/pull/2882.

Is there any plan in the near/distant future to have an addProtocol functionality like it is implemented for the "maplibre-gl"?

AFAIK there is nobody working on addProtocol, you can try implementing something like this as described by https://github.com/maplibre/maplibre-react-native/issues/28#issuecomment-1419505405 – but I can't yet imagine a clean way where this would be supported by MapLibre RN.
PMTiles support is much more likely, once it's available in MapLibre Native.

Wouldn't addProtocol be required to support an api_key on styleJSON?
What about the maplibre-contour plugin which uses addProtocol under the covers to accomplish the terrain layers from a raster-dem?

My solution meanwhile :
Thank you use dom
"use dom";

import maplibregl from "maplibre-gl";
import { Protocol } from "pmtiles";
import layers from "protomaps-themes-base";
import { useEffect } from "react";
import { Map } from "react-map-gl";
import { View } from "react-native";
import { useColorScheme } from "~/utils/useColorScheme";

export default function MapViewWeb() {
  const { colorScheme } = useColorScheme();
  useEffect(() => {
    let protocol = new Protocol();
    maplibregl.addProtocol("pmtiles", protocol.tile);
    return () => {
      maplibregl.removeProtocol("pmtiles");
    };
  }, []);

  return (
    <Map
      attributionControl={false}
      style={{ width: "100vw", height: "100vh" }}
      mapStyle={{
        glyphs:
          "https://protomaps.github.io/basemaps-assets/fonts/{fontstack}/{range}.pbf",
        sprite:
          "https://api.protomaps.com/styles/v4/light/en.json?key=NON_COMMERCIAL_USE_KEY",
        version: 8,
        sources: {
          sample: {
            type: "vector",
            url: "pmtiles://https://world.pmtiles",
          },
        },
        layers: layers(
          "sample",
          colorScheme,
          "en"
        ) as mapboxgl.LayerSpecification[],
      }}
      mapLib={maplibregl as any}
    />
  );
}


Make kubecofig-in-cluster use certificate provided by apiserver

Make it tiny bit cert rotation friendlier

This break local (kubectl) use of the kubeconfig as far as I understand.

Why? This changes kubeconfig file used by kube-proxy

Why? This changes kubeconfig file used by kube-proxy
Sorry, my fault. :/

coreosbot test this please
lgtm

@redbaron can you please rebase this one?

coreosbot run e2e

@ericchiang you have to be firm with coreosbot, no please :P

Really I think your format was also allowed, it just can't have the lgtm at the end.

Ping?


help IOS version check

Currently how can i check my current app version? when i am trying through DeviceInfo.getVersion() its retrieve the build version.

DeviceInfo is a separate package. Please see the README on how to use this package.

Well based on the readme:
string currentVersion: version to check against, defaults to the currently installed version
Where can i find more info regarding the "currently installed version"? Ios have internal build version, and appStore version, the library check the device version (based build version i guess..) against the appStore version, and it can cause mismatch


Update colliderscope web UI with graphicle 0.3

Dependency issues as the API for graphicle changed between versions 0.2 and 0.3. Additionally, can make use of the graphicle.select.clusters() function.
Maybe add some unit tests that periodically run, to ensure the integration of these packages is consistent.

Fixed the dependency issues. Closing, but may open a new issue for the more advanced graphicle clustering under the hood.


[INVALID] Windows binary

Dear Eduardo,
Could you be so kind to generate .exe for the rest of us who are merely users w/o compiler?

@sergeevabc Unfortunately, I don't have a windows to do this. It only requires gcc. Maybe someone can do it with a virtual machine or a windows.
However, I'm not sure it works on windows. It may work on modern terminals inspired by unix systems

I've made a binary on my GitHub repo ports-linux
Perhaps @posva could link to it in his README.md
Cheers

Hmm, someone reported a binary to try in February, but it's already gone, alas.


Mint heading style

the heading should look like this

in dark mode it could have the same fill as the background (no gradient) - while having stroke and the typical dropshadow

figma: https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=142%3A1572&mode=design&t=GKkayTA5Y8dTj3H1-1

👋


Internal keys in JobParameters#getExtras()

Javadoc says:
/** The optional set of user-supplied extras associated with this Job. */

JobParameters.java#L58
When I call that method from my JobService I see lots of unrelated keys:
{com.firebase.jobdispatcher.tag=INCOMING,
 com.firebase.jobdispatcher.trigger_type=1

etc.
These keys should probably be filtered out before the job is passed to the service, or else be documented (BundleProtocol is package-private).

In April 2019 we announced that Firebase Job Dispatcher would be deprecated today, April 7th 2020.  For this reason we are going to close all open issues and archive the repository.  We will also stop supporting FJD for new app installations (such as those targeting sdk versions greater than Android Q).  Existing apps that rely on FJD should continue to function as usual.
While we will no longer work on FJD, we encourage you to migrate to Work Manager which is a superior tool and fully supported by the Android team.
Thank you for taking the time to try the library and provide this feedback.  We sincerely appreciate your effort and we apologize for not addressing it in time.


add missing include to platform headers

Current coverage is 64.72% (diff: 100%)

Merging #666 into master will increase coverage by 0.27%

@@             master       #666   diff @@
==========================================
  Files            99         99
  Lines         14442      14442
  Methods        1980       1979     -1
  Messages          0          0
  Branches       1699       1699
==========================================
+ Hits           9308       9347    +39
+ Misses         4605       4572    -33
+ Partials        529        523     -6

Powered by Codecov. Last update 1d310dc...1122742


Role and permisions needed to deploy BKPR on AKS

What role type and permissions needed to deploy BKPR on AKS?

Closed by using the pre release


mypy complains about new azure-storage-blob package

...that was released yesterday (https://pypi.org/project/azure-storage-blob/12.9.0/).
Copied from CI log:
/opt/hostedtoolcache/Python/3.8.11/x64/lib/python3.8/site-packages/azure/storage/blob/_serialize.py:129: error: Type signature has too many arguments  [syntax]
/opt/hostedtoolcache/Python/3.8.11/x64/lib/python3.8/site-packages/azure/storage/blob/_blob_client.py:1407: error: Type signature has too few arguments  [syntax]
/opt/hostedtoolcache/Python/3.8.11/x64/lib/python3.8/site-packages/azure/storage/blob/aio/_blob_client_async.py:808: error: Type signature has too few arguments  [syntax]
webviz_config/_deployment/azure_cli.py:244: error: "ContainerClient" has no attribute "__aenter__"  [attr-defined]
webviz_config/_deployment/azure_cli.py:244: error: "ContainerClient" has no attribute "__aexit__"  [attr-defined]

Created https://github.com/Azure/azure-sdk-for-python/issues/20771.


User Membership for CDCgov

What type of help do you need?

[ ] Question
[ ] New Repo
[ ] Delete Repo
[X] User Membership (please make sure new members are familiar with the CDC open practices and set up their profile with name and org info to help people collaborate with them)
[ ] Other

Please describe how you'd like us to help.
Hello, I am a member of the Tech enablement team, and I need access to CDCGov repos in order to work on tickets like https://cdc-dexops.atlassian.net/browse/HL7-2362 and https://cdc-dexops.atlassian.net/browse/HL7-2365

@boris-ning-usds I appreciate it sir, thank you.


! Can not assign task for remote "Account Type"

Hi!
We use LDAP, first login event created account in kanboard. Then I tried to assign task for such user? but in list I dont see such users, only my account and local accounts(that were created in "user management" menu).
Thanks

And in "Project management" console, I cannot to edit list of members :(

My fault. I'd created private project...


⚠ Bofrost.at has degraded performance

In 2d1ddbe, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1079 ms

Resolved: Bofrost.at performance has improved in 2bf3ae3.


Changes for qurt SITL and other minor qurt fixes

Qurt build configuration fixes
Moved LED functions from simulator to src/drivers/boards/sitl
so it can also be used from QuRT when not running simulator.
This is needed for HIL.
Fixed parameter type in uorb_priority
Signed-off-by: Mark Charlebois<EMAIL_ADDRESS>Reverted rate limiting deletion
Signed-off-by: Mark Charlebois<EMAIL_ADDRESS>

Still needs work / has Travis breakage.

@mcharleb Could you look at the Travis breakage?

@mcharleb I'm closing this now, since it didn't move.


[improve][pip] PIP-339: Introducing the --log-topic Option for Pulsar Sinks and Sources

PIP-339: Introducing the --log-topic Option for Pulsar Sinks and Sources

Motivation
Make Pulsar Sinks and Sources able to send logs to a Pulsar topic.
Modifications

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[ ] doc-not-needed
[x] doc-complete

Matching PR in forked repository
PR in forked repository:

PIP-338 is already taken by #22039

Please update the vote thread


The newly inserted row and columns inherit the size.

Description
The newly inserted row and columns inherit the size.
Steps to reproduce

Resize row/column.
Insert row/column on that resized row/column.

Demo

https://jsfiddle.net/aninde/yoqm209f/
Your environment

Vue wrapper version: 4.1.1
Handsontable version: 7.4.2
Browser Name and version: Firefox 78
Operating System: macOS Catalina 10.15.6

This issue will fixed with v8 of Handsontable. Works on curently tested version https://jsfiddle.net/aninde/7tnybgeu/

Closing as a duplicate.


Add Changelog, docs and tests to source tarball

Same as timothycrosley/isort#531 which does no longer work, as now
poetry seems to be used for building the packages

Codecov Report

Merging #1266 into develop will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop     #1266   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           34        34
  Lines         2133      2133
=========================================
  Hits          2133      2133

Thank you!

@sebix unfourtantely, I had to revert this. It looks like adding extra files is not quite as straight forward with poetry as I would have assumed. See: https://github.com/timothycrosley/isort/issues/1285. Which I confirmed locally, all the included files ended up just littering the root of my sitepackages. I couldn't easily figure out a good way around it, and the state of the issues on Poetry's issue tracker around it didn't give me much hope

@sebix unfourtantely, I had to revert this. It looks like adding extra files is not quite as straight forward with poetry as I would have assumed. See: #1285. Which I confirmed locally, all the included files ended up just littering the root of my sitepackages. I couldn't easily figure out a good way around it, and the state of the issues on Poetry's issue tracker around it didn't give me much hope

Ok, too bad that this is not - easily - possible with poetry. The files should have just ended up in the sdist tarball. Sorry for the inconvenience.

No problem at all! I appreciate you drawing my attention to the issue! I've reopened https://github.com/timothycrosley/isort/issues/463

Adding python files (tests) in sdist only is possible -> https://python-poetry.org/docs/pyproject/#packages and #1313
Adding static files (docs) in sdist is currently not possible -> https://github.com/python-poetry/poetry/issues/1338


Check Sprint field in PRs

When conform-pr GitHub Action checks some pull request, it should fail if the Sprint field (in all projects where it exists) is empty or has a value that is not the "current" one.

@ronaudinho Wanna take this one? See https://github.com/FerretDB/github-actions/pull/109#issuecomment-1287666604

yes sure, already working on it, will PR soonish @AlekSi


Simplify update script

lake update already updates the cache, right?

I don't think so.

I'm investigating it. I'll let you know. Thanks for your contribution anyway.

I thought this is what
https://github.com/leanprover-community/mathlib4/blob/a54be302d6fd476755ef0d77c2e4b3a7768e9c9c/lakefile.lean#L151-L176
is for

Yes, you're right. Merged.


[CLOVER V7] Audio distortion

After upgrade my clover to v7 last few days, i just found out that audio is distorted so i can't hear musician's voice anymore. I solved this problem by downgrade AppleALC from 1.3.9 to 1.3.6, which you had in previous version.

Oh oh . I will talk with audio kext developer .

Fixed in V8


Change keyword Nextjs -> NextJS

Uniforms the "NextJSRoutesOptions" and "Nextjs" keywords, which are the options types of the function "writeNextjsRoutes". This makes the flow of reading code smooth.
I'm sorry if the phrase is not unified due to the function name convention and the type declaration convention.

Looks great, thanks @po4tion


[Bug] [Connector-V1-Spark-Hbase] Exception caused by compatibility with hadoop3.x

…lity with hadoop3.x

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

close #3209

Hi, @hailin0 PTAL, seem like transform ci not passed.


Using setPosition in onDidChangeModelContent has no effect

I want to make some content replacement. But setPosition  inside doesn't work
Here is a simple example, please point out the problem
this.editor = window.editor = monaco.editor.create(
        document.querySelector("#editor-wrap"), {
        value: "",
        theme: "vs-dark",
        automaticLayout: true,
        language: "javascript",
        fontSize: 12,
        minimap: {
            enabled: false,
        },
        wordWrap: "on",
        mouseWheelZoom: true,
        "bracketPairColorization.enabled": true
    });

editor.onDidChangeModelContent(function (event) {
    // event.isUndoing = ctrl + z
    // event.isRedoing = ctrl + y

    if (event.isUndoing || event.isRedoing || !event.changes[0].text) {
        return;
    }

    const changes = event.changes[0];
    const {
        range
    } = changes;

    if (changes.text == "123") {
        changes.text += "456";

        range.endColumn += changes.text.length;
        editor.executeEdits("", [changes]);

        editor.setPosition({
            lineNumber: range.startLineNumber,
            column: range.endColumn + 3,
        });
    }
});

I'm sorry it doesn't seem to be working, but with so many requests that we get here and in the VS Code issue tracker, we just cannot provide the support we would like to offer.
You can try asking your question on stackoverflow.
That said, if you can track down your issue to a specific problem of the Monaco editor, we are more than welcoming a PR by the community! Please use the bug-report issue template to report the issue.
Thanks for your understanding!

@hubgit Thank you for your answer

@GirlDebug Did you create a question on SO? I'm running into the same issue and want to know whether you received an answer that solved the issue. I searched SO, but couldn't find any related question.

So I have set up the monaco dev env locally and walked through the code until _emitStateChangedIfNecessary. All the parameters that are used to create an instance of CursorStateChangedEvent when eventsCollector.emitOutgoingEvent is called seem to be correct. oldSelections contains the old position, and selections contains the new position. But I struggle to understand the event emitter. Not sure where to go on from now. Do you have any tips?
Also adding @alexdima to this thread as you have done most of the changes in the past to cursort.ts and all related files. Maybe you have an idea or can give me a hint on the event emitter?


Fix TextField auto-sizing remaining too small and cropping text.

Before this patch, sometimes one would need to actually set the width to textWidth to get a proper sized textfield after setting text:
label.text  = str;
label.width = label.textWidth;

By moving width and height calculation responsibility to TextEngine.getLineMeasurements() this workaround is no longer required.

However I'm not completely sure this works in all cases as intended :)
Are there any TextField behaviour tests?

That is the intended behavior unless you set tf.autoSize. Does that property work?

Looks like I wasn't clear in the code sample:
Before this patch, with autoSize set to anything other than NONE it won't actually always change size.

Thanks! I made a few minor changes, let me know, guys, if you see differences in how autoSize behaves (for example, when and whether it allows increased size -- I thought it normally only reduced size?)

Looks good, thanks for the improvements!


D4 - Lessons Learned

In retrospective, describe what your team learned during this first release and what you are planning to change for the second release.
Grading criteria (2 points): Adequate reflection about problems and solutions, clear description with adequate use of language.

assignment was turned in so I am closing the issue


Implement pnpm workspaces and TurboRepo for parallel builds and dependency management. Define dependencies and scripts in the root package.json and individual packages (server and client). Ensure the workspace setup is working properly with pnpm-workspace.yaml.

Task Overview:
Set up pnpm workspaces and TurboRepo in the monorepo to enable parallel builds and efficient dependency management. This involves configuring the root package.json, individual package.json files for the backend (server) and frontend (client), and ensuring that pnpm-workspace.yaml is set up properly to manage dependencies across projects.

SMART Criteria
Specific 🎯:
Implement pnpm workspaces and TurboRepo by:

Defining dependencies and scripts in the root package.json to handle shared dev dependencies and workspace scripts.
Setting up individual package.json files in the /server and /client packages with project-specific dependencies.
Configuring pnpm-workspace.yaml to ensure both the server and client are recognized as part of the workspace.
Setting up TurboRepo with turbo.json to enable parallel builds for both backend and frontend.

Measurable 📏:
Success will be measured by:

The correct setup of pnpm workspaces and TurboRepo, with dependencies shared between packages.
TurboRepo successfully executing parallel builds across the /server and /client packages.
No dependency conflicts between the server and client projects.

Achievable 🚀:
This task is achievable using pnpm and TurboRepo, which are widely supported tools for managing monorepos and optimizing builds. With proper configuration, the workspace can be set up to handle both shared dependencies and parallel execution.
Relevant 🎯:
Implementing pnpm workspaces and TurboRepo is critical to optimizing builds, managing dependencies efficiently, and enabling the monorepo to scale easily across multiple projects.
Time-bound ⏳:
This task should be completed in 3 days, ensuring that the workspace and build processes are fully operational.

Subtasks 📝

[ ] Set up the root package.json to define shared dependencies (e.g., ESLint, Prettier) and global scripts (e.g., build, lint, format).
[ ] Configure pnpm-workspace.yaml to include /packages/server and /packages/client as workspace packages.
[ ] Add individual package.json files to /server and /client, defining their specific dependencies and scripts.
[ ] Set up TurboRepo by adding turbo.json in the root directory, enabling parallel builds for both backend and frontend.
[ ] Test the workspace setup by running shared scripts (build, lint, format) across both projects, ensuring that pnpm handles dependency resolution correctly and TurboRepo optimizes the build process.

Acceptance Criteria ✅

[ ] pnpm-workspace.yaml is correctly set up, and dependencies are shared across the server and client projects without conflicts.
[ ] TurboRepo successfully runs parallel builds for both backend and frontend projects.
[ ] Developers confirm that dependency management and build processes are working smoothly across the monorepo.

Additional Notes 🗒
Ensure that the pnpm workspace setup can handle future packages, allowing for easy scaling and the addition of new projects without breaking the existing structure.

@girl-loves-coding  Seems like most of this is done by @c0rtexR ?
https://github.com/softflow24/data-river/blob/main/package.json#L5
https://github.com/softflow24/data-river/blob/main/pnpm-workspace.yaml

this is done in dev


Improve the per release version management

We have a few files with release version identifiers, some of these are not consistently managed (we only sometimes change the version identifiers). Review the references, and document what needs to be managed on each release of the operator.

We've documented the release process in the Wiki, which includes where and when to change the identifiers.


bumping activesupport/model dependencies

We need update Rails version to >= <IP_ADDRESS> on Authorizer and the specified version is blocking the update.

@bmfreitas i will close this PR as we managed to work with rails current version on api. Thanks!


Make and implement a custom 404 Error page #152

Overview
This PR fixes or fixes part of #152
This PR does the following: Created a error 404 page to resolve the issue #152
Proof that changes are correct
https://github.com/BitByte-TPC/alumni/assets/154520239/9f7d9f74-71e3-4e07-bce4-720f6dee8e7a
This screen recording shows that when the user try to visit any undefined route they see an custom error 404 page.
Thank you.
Fixes #152

@Vaibhavsahu2810 Try to improve responsive a bit more.

@SamakshAgarwal1112 successfully implemented all the changes.
Thank you

@Vaibhavsahu2810 The 404 heading is floating to the right on larger screens. Try to keep it in the middle.

@SamakshAgarwal1112 successfully improved the responsiveness for larger screens
Thank you


spec: use wording remove instead of delete

Use notation remove instead of notation delete. The reason is:
"Delete and remove are defined quite similarly, but the main difference between them is that delete means erase (i.e. rendered nonexistent or nonrecoverable), while remove connotes take away and set aside (but kept in existence)."
The signing key is still in existence after being removed from the signing key list, so notation remove is better.
Signed-off-by: Yi Zha<EMAIL_ADDRESS>

@shizhMSFT , @yizha1  - Does the same logic hold for "Certificate" add/delete or add/remove ?  I think customers will look for parity in how "Certificate" add/delete and "Key" add/delete operations works.

@shizhMSFT , @yizha1 - Does the same logic hold for "Certificate" add/delete or add/remove ? I think customers will look for parity in how "Certificate" add/delete and "Key" add/delete operations works.

I think remove vs delete makes sense, in Linux rm (remove) means delete, also for key remove will remove the reference of the signature from the list. Will we have delete in future if this is a security concern ? not sure about that.
For certificate I am not sure if we have the concept of remove, it is always delete right ?

@shizhMSFT , @yizha1 - Does the same logic hold for "Certificate" add/delete or add/remove ? I think customers will look for parity in how "Certificate" add/delete and "Key" add/delete operations works.

I think remove vs delete makes sense, in Linux rm (remove) means delete, also for key remove will remove the reference of the signature from the list. Will we have delete in future if this is a security concern ? not sure about that. For certificate I am not sure if we have the concept of remove, it is always delete right ?

For certificate added to trust store,  the command notation cert delete always delete it.

Use notation remove instead of notation delete. The reason is:
"Delete and remove are defined quite similarly, but the main difference between them is that delete means erase (i.e. rendered nonexistent or nonrecoverable), while remove connotes take away and set aside (but kept in existence)."
The signing key is still in existence after being removed from the signing key list, so notation remove is better.

We have same issue with remove, in linux rm means removing files i.e. actually deleting file from disk. Also this brings up another question, how will this command(delete or remove) work with local keys, when we support singing with local keys? Could they be interpreted by user as deleting the keys from the disk? If so than this would be an security issue.

We didn't support local key yet, we can come up with the solution later. It is described in the key spec before this PR that the current design for notation key is to manage the signing key list, not the lifecycle of the signing key. So once you remove the key from the signing key list, it is still in existence. This is the truth for remote key. We didn't delete it from the key vault.

Close this PR as discussed. Keep notation key delete command, and remove alias rm


Update gjk.c

The pseudo-code from Wikipedia, shows that the d should be the result of negate(a) in order to search towards the origin for convergence, not that it matters.

Thx!