OONI Run v2 refactor

Align OONI Run v2 to the original specification.
Includes:

Switch to using postgresql for supporting OONI Run v2 descriptors
Always returning the full models when fetching and listing
Use SQLAlchemy with alembic to handle database migrations
Upgrade to SQLAlchemy 2.x so that we can benefit from proper typing support
Fix some bugs in the existing implementation

@DecFox confirmed that he has reviewed this branch until https://github.com/ooni/backend/pull/805/commits/f0c4bfcfd46085f72b337fdfabfe152702785993. I am going to proceed with landing this.
@DecFox if you have some comments about the rest of the review feel free to drop another comment here so I can address it as future work.

I will manually squash the git history to make it easier to look at the changeset later.

@DecFox I rewrote the git history so it's easier to tell what's going on. The last commit you have viewed as all been squashed into https://github.com/ooni/backend/commit/d2aa0af7f3e36385831868363fefc710de49b323, so all the new stuff is just this commit: https://github.com/ooni/backend/commit/c3f522530b2151aebb8fc6ec2363143f05364098.
I am closing this PR as merged.


OSx resizing

So my friend's using OSX and is having a problem, this happened when he tried to resize it. This is a picture of the entire client, could somebody help me?
http://prntscr.com/jgukzu/direct

He probably locked window size by accident


feat: deflate64 decompression (encode) support

Closes #237
Because I could not find deflate64 compression implementation, this only adds encode support for deflate64

Using a modified example, I couldn't get the test file to decompress.
 › cargo run --example zstd_gzip --features="tokio,zstd,gzip,deflate64" < examples/deflate64.zip
    Finished dev [unoptimized + debuginfo] target(s) in 0.05s
     Running `/Users/rob/.cargo/target-shared/debug/examples/zstd_gzip`
Error: Custom { kind: InvalidData, error: "invalid data" }

The deflate64.zip file in dotnet assets is an ZIP file with entry compressed with deflate64, not a valid defalte64 stream.
So, passing the zip file itself to the decoder will cause an error.
On the test in my crate, I manually parsed the zip file header with binary editor and I'm using their knowledge of offset and length of deflate64 stream in the zip file.
https://github.com/anatawa12/deflate64-rs/blob/64349cd3982ce8b88117447c4036853a5e07e64d/tests/stream.rs#L4-L5

Ahh I see, well I'm just trying to validate the implementation before approving. Can you suggest something?

As I did before, you can extract deflate64 stream from zip file manually.
As far as I know, there are no raw deflate64 compressor tool so I think this is only way for  now.

Verified the functionality as you showed in the deflate64 repo.


Stop using the github-app-token image

The quay.io/redhat-appstudio/github-app-token image is highly suspect.

It is a copy of quay.io/chmouel/github-app-token - an image in a
personal namespace with unclear origins and content.
It has not been updated for 4 years.
It has 175 critical vlunerabilities according to quay.io.

Update the update-infra-deployments task to no longer depend on anything this
image provides and replace it with a generic python image.

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/test

/retest

Seems to work

created https://github.com/redhat-appstudio/infra-deployments/pull/4525 successfully
updated it successfully upon retest

/test

/retest


Updates to workType labels

No more "E-sound" :crying_cat_face:
https://github.com/wellcometrust/platform/issues/3863

https://github.com/wellcometrust/platform/issues/3863

@jamesgorrie this is ready for review again, cheers!


Add missing metrics

As per @douwekiela's suggestion, we should find the blind spots that we have in terms of missing metrics, especially from domains like speech recognition and computer vision.
Suggestions are welcome below!

We should probably look into GAN metrics as well, like Kernel Inception Distance (KID), Inception Score (IS) and Fréchet Inception Distance (FID)

How about RL metrics? e.g. https://analyticsindiamag.com/metrics-for-reinforcement-learning/

Computer vision metrics:
[SSIM[(https://en.wikipedia.org/wiki/Structural_similarity)
PSNR
There are various object detection metrics implemented by Tensorflow

Also listed a few libraries in #11 e.g. NetworkX for graph metrics.


feat: summary email should recurring weekly

Fixes #3
This PR will automatically send all summary emails periodically.
Changes

Add a queue system (Bull package), depends on Redis for storage

How it works
A special job, which will run periodically, will fetch all unique email address, and push them in the mailer queue (1 email = 1 job)
A processor will poll the mailer queue, and process all the jobs (build the email template + send it)
How to test

Install Redis
curl 'http://localhost:3000/send/all-summary?token=YOUR_TOKEN' (Same token as the other send test requests)

CAUTION: This will send the summary report email to all verified emails in the database
More improvements
In the future, we can also

move the subscribe mail sending to the queue. ( PR #36 )
implements a more robust shutdown function, so that when restarting the app (new deploy, etc...) while there are working jobs, do not crash them.
optionally, add a UI (https://www.npmjs.com/package/bull#uis) to monitor the queues status
add rate limiting on the queue, to not trigger throttling on sendgrid side_ (I don't think we will hit the current 10k/requests per second limit)
add logs about failed jobs (ideally, we should disable the email if they start bouncing)

Also, should we skip the email where there are no proposals ? Or should we rework the email UI and inform them that there is just no activity ?

@wa0x6e How is Redis being used? I dont see it anywhere in the code

Redis is used by Bull, the queue system, as its database

I see, then we will need a way to define a Redis connection uri cuz it will be a cloud db.

@Todmy We should always try to test changes, utACK should be used in last resort.


Reset sync_known_lib_num when closing a connection - develop

Change Description

Reset sync_known_lib_num on closing connection to optimize syncing
When closing connection a connection we should no longer consider its view of LIB since we are no longer connected to that peer. This PR updates sync_known_lib_num with highest of known peers when a connection is closed.
Fixed some cases where net_plugin kept trying to re-connect on fatal conditions (like chain is a differ chain (chain_id))

Change Type
Select ONE:

[ ] Documentation

[x] Stability bug fix

[ ] Other

[ ] Other - special case

Testing Changes
Select ANY that apply:

[x] New Tests

[ ] Existing Tests

[ ] Test Framework

[ ] CI System

[ ] Other

Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

https://github.com/EOSIO/eos/pull/10653


Added accept attribute to generated file input

Accept attribute was not being handled in the file input directive.

As LumX has ben completly reworked, I unfortunatly need to close your PR. Thanks for contributing. This feature can still be a good enhancement, maybe you can take a look to the new LumX version ? ;-)


🐛 [Jacket] Not starting

Which addon?

Addon name : Jackett NAS
Addon version : 0.20.2236

Describe the bug
Addon is not started after installation.
The only page I found relevant is https://community.home-assistant.io/t/exec-fatal-unable-to-exec-bashio-no-such-file-or-directory/214752
To Reproduce

Install addone
Start addone
Open Log tab
See error log

Full addon log
exec: fatal: unable to exec bashio: No such file or directory
Full addon config
PGID: 0
PUID: 0

System
Home Assistant 2022.10.5
Supervisor 2022.10.2
Frontend 20221010.0
Raspbian on Rasberry Pi 4B

Hi, that's because if you don't use HAos it sometime occurs. Normally I have a script to prevent that, I'll check it

Could you please post your log when starting? Bashio should be installed at that moment in your configuration based on script 00-aaa_dockerfile_backup.sh

@alexbelgium this is the only line in Log tab of the addon:

and the only one in the Logs screen in Settings>System

and the only one log in Supervisor section:
22-11-14 10:34:32 INFO (SyncWorker_3) [supervisor.docker.addon] Starting Docker add-on db21ed7f/armv7-addon-jackett_nas with version 0.20.2236

Thanks, really strange it starts fine for me. Actually once this supervisor PR is deployed (I suppose in version 2022-11) I will provide pre-build images that will avoid this : https://github.com/home-assistant/supervisor/issues/3414#event-7732125083

thanks @alexbelgium. hope that will work
btw have you checked line ending symbols in the scripts?

What I don't understand is that the entrypoint should be though the s6 supervisor. On my system, I see the init scripts executing long before it comes to my own script containing bashio... How would you suggest that I look for line ending symbols? Thanks

I was thinking if your sh scripts have incorrect line endings, but just checked - they are already in Unix format

Hi, could you please refresh the repo and try installing again

@alexbelgium unfirtunatelly issue still remains. with same log

OK, solved and tested!

Or too much enthusiasm. On which supervisor version are you?

hey @alexbelgium thanks
I have now Supervisor 2022.11.2 and looks like addon now works fine!

Double great news, thanks! The supervisor version means I can start deploying pre built versions. Have a nice day


Add PDFSam

Requesting a new app ✨
If you are requesting a new app to be added to deb-get please complete the
following section, only one app per issue please.

[x] I have checked that this app does not already have a pending request and has not previously been declined.
App Name: pdfsam
Download URL: https://github.com/torakiki/pdfsam/releases/download/v4.3.4/pdfsam_4.3.4-1_amd64.deb
Website URL: https://pdfsam.org
App Summary: Split, merge, rotate, mix and extract pages from PDF files with PDFsam Basic, free and open source, at home or at work. Your PDF documents stay private on your computer, no need to upload them to a third party service.

This package is already in Ubuntu repositories, is it still eligible?

4.2.12 in the LTS vs 5.0.3 direct from upstream. I'd think that complies with https://github.com/wimpysworld/deb-get/blob/main/01-main/CONTRIBUTING.md#what-is-acceptable .


fd_make_release fails

fd_make_release() fails and exits when it cycles to 'fd_soil_respiration()` the error seems to come on the step that assigns the timestamp variable.

My suspicion is that it seems to be failing on columns that are in the original data sets, but are removed before data from that function is output ...e.g. the dateTime column that is used to make the timestamp column. dateTime is not in the final output data, ergo not in the metadata table.


PERF: broadcast_apply_full_axis can be implemented to compute caches in some cases

not actual

I think we could compute caches not only when keep_partitioning=False, but also when keep_partitioining=True so I would prefer to keep this issue open.


Repository Access

Hello,
I created a pull yesterday to give access to this repository to our supplier Kainos and still cannot see them added to the same so I am creating another pull.
The previous pull did not return any error so I am not sure what is the problem here.

Hi @federicostaianojustice1 . Turns out the module was missing the ".tf" suffix. I've fixed that with #288. Just merging that in.


Sdk automl text entity extractio notebook

This PR contains a small fix(changing colab link, github link and adding vertex AI logo) to sdk_automl_text_entity_extraction_online.ipynb notebook

[x] Use the notebook template as a starting point.
[x] Follow the style and grammar rules outlined in the above notebook template.
[x] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
[x] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
[ ] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
[x] This notebook has been added to the CODEOWNERS file under # Official Notebooks section, pointing to the author or the author's team.
[x] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

/gcbrun

/gcbrun

all comments resolved

ready for review

/gcbrun

@sudarshan-SpringML Please fix PR title. It's not clear if it's a small edit or a whole new notebook from the title.

/gcbrun


How does the max_cost works?

Hi,
I have a question about the max_cost argument in the AsyncCache. When I set it to 2 and insert 2 item each have 1 cost, then one of the item is missing. Maybe I misinterpret something here. Code:
use stretto::AsyncCache;

#[tokio::main]
async fn main() {
    let c = AsyncCache::new(20, 2, tokio::spawn).unwrap();
    c.insert(1, 2, 1).await;
    c.insert(2, 3, 1).await;

    c.wait().await.unwrap();

    c.get(&1).unwrap(); // Get a panic
}

There is an internal_cost that will auto-add for each item if you do not set ignore_internal_cost to true when building the cache. See https://github.com/al8n/stretto#ignore_internal_cost.


Authentication and Authorization support

Gotta limit who can do what

Closing as Admin GUI has auth as of v4.5.0.   See https://github.com/JeffersonLab/jaws/issues/17 for adding access controls more broadly to Kafka.


Error at init when running on Windows ARM

When running a Windows x64 binary on Windows ARM, I get this error during startup:
panic: regexp: Compile(`[_\p{L}][_\p{L}\p{N}]*$`): error parsing regexp: invalid character class range: `\p{L}`

goroutine 1 [running]:
regexp.MustCompile({0x7ff66897b52c, 0x17})
	/opt/homebrew/Cellar/go/1.22.3/libexec/src/regexp/regexp.go:317 +0xb4
github.com/google/go-cmp/cmp/internal/function.init()
	/Users/anacrolix/go/pkg/mod/github.com/google/go-cmp@v0.6.0/cmp/internal/function/func.go:68 +0x7c

It's very possible this is an upstream issue with golang/go, but I thought I'd start here.

Hi, thanks for reporting the issue, but this is almost certainly a upstream issue.

Okay I think it's safe to say the issue is upstream. Thanks!


Add support for where_object and where_object_changes with JSON and JSONB columns

The tests pass for me locally. Not sure what's going on with Travis.

Hmm.. I just upgraded to Postgres 9.4 on my local system and ran the test suite and saw the same errors that Travis is returning so I'll see if I can do some hacking to figure out what's up. Thanks for the pull request, let me know if you have any ideas regarding the invalid token errors.

Thanks a lot for the pull request! This is super helpful. I was able to get all the tests to pass on Travis and even added some additional tests for good measure surrounding the column types.
It turns out that ActiveRecord 3.x doesn't support JSON column types for PostgreSQL, and JSONB column types are only supported on ActiveRecord 4.2+.

Nice! Glad you got it to pass on Travis.

Any plans on merging this PR into master?

Any plans on merging this PR into master?

The commits are already in master.  See, e.g. https://github.com/airblade/paper_trail/commit/a98d88cb309707bab2790550ce6c56c08185822b
GH doesn't make it easy to tell they're already in master, does it :)

Thanks Jared, I did not bother to look in the actual file, and you're right, GH did not indicate that it was merged in


Add comments

@puffnfresh Does this look ok?

No preference. Parametricity does a really good job of describing most of the functions exactly, doctests would be pretty useful, though.

Parametricity does a really good job of describing most of the functions exactly

For those who understand parametricity, I'd agree, but I think some comments could help beginners. I would add some code examples but I haven't fully understood the usefulness of the class yet.

doctests would be pretty useful, though.

Agreed.

Comments look good to me, perhaps the only thing I'd suggest is being clearer what is meant by the left or right side (like "the This value or left side of a Both" or something like that. Sorry, I didn't notice this PR when I made the updates the other day.

Bump for rebase? :smiley:


debian/control: Build-Depend on cmake

Without this a build is failed on the Launchpad CI for PPA.
With the cmake the package was built and available here
https://code.launchpad.net/~stokito/+archive/ubuntu/openwrt
CC @aparcar

Awesome! Thanks for taking care of it. How should I coordinate updates in the future? Is a maintainer actively watching this repo?

But don't you need something to link against? A -dev package alone will just provide headers (and in some cases supplemental static .a library variants) - so in order to actually use a library for development you need both the -dev package to provide headers and unversioned .so symlinks (and possibly supplemental debug symbols)  as well as the actual binary package to provide the versioned .so shared objects to link against.
Or did I misunderstand something here?


id is deprecated in Neo4j version 5. Pydantic raises ValidationError when using from_orm to read a neomodel object.

Problem:
Updating to neo4j v5 introduce an error when using from_orm function of pydantic schemas.
E   pydantic.error_wrappers.ValidationError: 1 validation error for FlavorRead
E   __root__
E     id is deprecated in Neo4j version 5, please migrate to element_id. If you use the id in a Cypher query, replace id() by elementId(). (type=value_error)

So we are stuck to v4.8.10.
Possible solution:
Edit the BaseNodeRead classes with:
@classmethod
def from_orm(cls, obj: Any) -> 'BaseNodeRead':
    # `obj` is the orm model instance
    if hasattr(obj, 'id'):
        obj._id = obj.id
    return super().from_orm(obj)

Notes:
Currently this solution is not complete because there are errors with the id() function of neomodel. It tries to cast UUIDs into int and fails:
@property
def id(self):
      try:
>           return int(self.element_id_property)
E           ValueError: invalid literal for int() with base 10: '4:e75330b3-2c27-4f25-8b0f-5a8dafbe1df2:74'

Monitor if neomodel developers resolve this behavior in newer versions of neomodel (last used is 5.2.0). Optionally, evaluate to open an Issue or a PR on neomodel to resolve the problem.

This problem was caused by @root_validators executing a dictionary expansion on the object. Since those @root_validators applied only some checks on specific attributes independently on parent attribute values, they have been substituted with @validator("*") to apply data conversions to all attributes requiring them and avoid to execute a dict expansion when not needed.


Cannot call function on custom Resource (Nonexistent function)

Godot version:
master a3501c096f32506bf2262e36a302bf65f4ad0f4a
OS/device including version:
Linux
Issue description:
I can't call a function on a custom loaded resource.
MyResource.gd
extends Resource

export(int) var value = 42

func twice():
    return value * 2

SaveLoad.gd
tool
extends EditorScript

const MyResource = preload("res://MyResource.gd")

func _run():
    var my_resource = MyResource.new()
    print(my_resource.twice())
    ResourceSaver.save("res://my_resource.tres", my_resource)
    var my_resource_loaded = ResourceLoader.load("res://my_resource.tres")
    print(my_resource_loaded.value)
    print(my_resource_loaded.twice())

Output
84
42
 res://SaveLoad.gd:12 - Invalid call. Nonexistent function 'twice' in base 'Resource (MyResource.gd)'.

Steps to reproduce:
Run SaveLoad.gd.
Minimal reproduction project:
resource-issue.zip

Seems like even doing this is enough to trigger the bug:
# ...
func _run():
    var my_resource = Resource.new()
    my_resource.script = MyResource
    print(my_resource.twice()) # --> Invalid call

I believe the problem is with all script-inherited classes, i have a script inheriting from spatial in an EditorScript and the issue also occures there.

@bojidar-bg
After some poking around i think more accurate description of this issue is that objects instanced in EditorScript's _run do not have their script class set?
Not sure how to word it but calling get_class() returns string with base type.

Ahh, try putting in a tool-mode script. It likely be from the fact that non-tool scripts get instanced as placeholders when setting them in the editor.
If that is the case, the bug is that the real script gets instanced when calling MyResource.new().

Hi guys,
I discover this bug myself awhile ago when creating plugin for my game.
So, here i'm gonna add some detail to this bug:

Aside from functions you cannot access normal variable too. By normal variable, i mean is class variable that you dont export, so the only thing that can be accessed from loaded resource is exported variables.
This also happen in plugin script. It's very annoying that my Custom Resource cannot be accessed in my plugin, even when It can be accessed on game runtime.
OK, that's what i discover today.
Hope it can help to fix this bug.

@earlroxas13 Did you try making the resource script a tool script?

@bojidar-bg I just tried putting tool in my Custom Resource script, and now all the errors is gone. :)
So making the resource a tool script, is it what it should be or is it just a temporary solution/workaround?

It is the way it is supposed to be. Non-tool scripts should be unusable in the editor.
That being said, their exported variables should be usable even when not set as tool scripts.

So this is not a bug. https://github.com/godotengine/godot/issues/23456#issuecomment-501611267 says that you can access exported variables, which is correct. Non-exported variables are part of script internal logic and they can't be accessed in non-tool mode in the editor. Closing.


Add support for Json file. Add support for converting string to Font.

It will be very convenient if SwiftTheme can support the conversion operation from String to UIFont,
like this:
// swift
label.theme_font = "PingFangSC-Regular,16"

And usually we use the json file as the configuration file, so I just made it.

抱歉 有些疏漏没有检查到.. 我重新提交了下

👍，我已经合并，并释放一个新版本


tokio v1

Hey,
here is another attempt at updating tokio to v1.
Some remarks:

I needed to enable the "rt-multi-thread" feature. Otherwise the tcp server would just block and nothing happens.
I replaced tokio-serial with serial-io, a custom fork I made based on mio-serial and tokio-serial. It basically just adds tokio v1 support via a feature flag instead of splitting it into different crates. Also all other dependencies have been updated. I checked this PR and made sure that I fixed this.
serialport-rs changed its interface to a builder pattern, which is why the API of serial-io is slightly different.
I renamed Serial to AsyncSerial, because the regular Serial in serial-io has no tokio support. I'm not sure, if I should change the name.
I have only tested the TCP async stuff.

Changelog:

update tokio to v1
update bytes to v1
update tokio-util to v0.6
replace tokio-serial with serial-io
add sync rtu client example
replace example cfg flags with cargo toml required features

closes #71 and #72

Hello !
We would need this for our work @enexflow. Let us know if there is anything we can do to help this getting merged :)
@flosse

It looks like Windows support for tokio based serial stuff can be worked on once https://github.com/tokio-rs/tokio/pull/3760 is merged. This would be needed for Modbus RTU. I suppose Windows support should not be dropped from tokio-modbus, thus merging is blocked

Hello !  tokio-rs/tokio#3760  was merged and released.
Is there something else that is blocking ?

@Tarnadas I just got the required PR for Windows compatibility into tokio-serial (https://github.com/berkowski/tokio-serial/commit/693e7ee12a368a077fb033e3b434986f4a2d1f4a), with a follow-up PR likely to be merged soon (https://github.com/berkowski/tokio-serial/pull/41)
I expect this to be released as tokio-serial 4.4.0
Could you already restructure your PR around that version of tokio-serial?
This would give us an updated tokio-modbus just in time when the tokio-serial update is on crates.io.


How can I  config the "ignored-headers" like zuul?

I wan't to change to gateway from zuul.
There's a configuratiton in my zuul project:
  ignored-headers: Access-Control-Allow-Credentials, Access-Control-Allow-Origin, Access-Control-Allow-Methods

How can I  config the "ignored-headers" like zuul?

You could use Remove Request Headers Filter to leave the headers out of downstream requests and  Remove Response Headers Filter to drop them from downstream responses. Will this be helpful?

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Fix psu status metric and large fw scrape time

https://github.com/Comcast/fishymetrics/commit/a01680e23f4dcbda567dcc2d91c10612a32fb40b

Capture PSU bay number at start to avoid duplicate entry.
Ignore PSU status if not installed or absent.

https://github.com/Comcast/fishymetrics/commit/ce2c30f5c9eefbaec34790d0c7381d0238de01b0

To avoid higher scrape time, limit firmware metric collection if the count of firmware endpoints are less than 75.

@ibrahimkk-moideen Please link issues to PRs


Data modification and nesting

Hi,
I have been using vis-timeline for a while and want to switch to Apache ECharts. I am following the custom Gantt chart example and have a few questions as follows:

Is it possible to have user modify an individual data point (say a task with a specific start time and duration) by using the mouse to move them along the timeline and also to modify its duration?
Is it possible to nest the group on the left axis?
Is it possible to add overlays to the individual items on the chart, eg, to add circles to indicate status?
Is it possible to dynamically change the timezone (allow users to change it say, from GMT to local) via a drop-down context menu?

Cheers,
Vlad

Your questions are about a specific chart and this a website repo.
Chart bugs/features are discussed in Issues. If posting there, please follow Official posting guidelines below.

The issue list is reserved exclusively for bug reports and feature requests.
For usage questions, please use the following resources:

Read the docs
Find in examples
Look for / ask questions on Stack Overflow

Another good resource is website makeapie.cn with many code examples.


[minimal issue- missing packages] Pesq and tensorboard missing from requirements.txt

I guess the requirement.txt file is missing the below packages:

pesq
tensorboard

Could we add them to avoid errors?
Thanks

Hi @sangeet2020 both packages are handled by recipes via extra_requirements.txt or extra_dependencies.txt files to be installed with pip depending on which recipe is targeted. The reason is that not all recipes need these two packages for their minimal set-up. Unarguably, you are right in pointing out we should avoid errors. After glancing through recipes using pesq, not all of them have the package listed in such txt files for pip - some mention it in their readme files. This needs cleaning up and perhaps regular sanity checks.
@mravanelli @pplantinga how about extending recipe checks for their module imports & requirements?

Seems reasonable. Thanks for clearing that up.


Fix opencage reverse issue

This should fix the problem. #313

👍 Thanks @nyejon for the contributions


If the template file for the containers has been updated, rerender

Lets say someone edits their template file, we should be able to start that and the Containerfile, and see which one is newer, and if the template has been modified more recently, we should rerender (also have a flag on build to skip rendering)

Added, waiting to release.


added timeout to ReadPipe

After debugging problem with occasional program hang every now and then and also troubles with detecting reboot i checked and found out that ReadPipe was stalling without reset, so i added timeout of 1sec and every problem (at least) that i've encountered has gone away and i was able to unlock bootloader

Thanks. I can see how there could be an issue here however I do have some concerns with the patch here:
The pipe policy should not be reset after a read or write op, here it is set everytime a read is called. This does not look ideal to me.
It is possible some transfers are done that would require more than a second to be performed, leading to potential corruptions depending on the payload size here.
The original value isnt retrieved either and I am not too sure if the default is infinite.
I think it would be better suited to call the policy api here outside of that class where it is more needed. (In the consumers of read pipe for example or at another location)
Issue may also occur with writing not just reading.

it's a crude and quick fix i understand, to be more in-place solution it should be set when timeout is crucial for data receiving and then set back to 0, maybe later when i'll have more time to look into code i'll implement that.
Interesting that for Qualcomm routines there is timeout set before read calls, but not for lumia

As I expected originally as well, a default timeout is also already set to 5 seconds: https://github.com/ReneLergner/WPinternals/blob/83c09bdc81c798db5e98bb813284d3b0b928fa62/WPinternals/WinUSBNet/USBDevice.cs#L234
My key issues here remain, the timeout should not be set like this in the read function, that's really not ideal and is going to lead to further problems that are going to be hard to debug. Plus the policy set call here would set it for all operations not just reading.
A public api already exists for this and should be used instead outside of the class.
Above link also references the intended way to set such policy, I would prefer seeing this being used to avoid further border issues here.
We also need to understand if the issue we're trying to fix here really is linked to a missing timeout and not something else. It could be just an async problem at play.

Ok so while I do understand the risks, I can vouch for this PR as it does fix my problem.

This PR will automatically be closed and will not be merged in a week due to inactivity and no consensus on fixes.


@electron-forge/plugin-vite can no longer build main module as ESM (breaking config change)

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
0.7.5
Electron version
32.1.1
Operating system
Windows 11
Last known working Electron Forge version
0.7.4
Expected behavior
I started with a template from 0.7.4 and I configured vite to output ESM like so (I don't remember whether it was the default back then or not):
  const config: UserConfig = {
    build: {
      lib:
        forgeConfigSelf?.entry != null
          ? {
              // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
              entry: forgeConfigSelf.entry,
              fileName: () => "[name].mjs",
              formats: ["es"],
            }
          : false,
      rollupOptions: {
        external,
      },
    },
[…]

I expect ESM only output and a working build.
Actual behavior
vite outputs both ESM and CJS to the same file whereas they sometimes contain artifacts of each other due to differing file lengths.
The build console output of electron-forge start points in this direction, too:
✓ 1324 modules transformed.
rendering chunks (1)...
computing gzip size (0)...
computing gzip size (1)...
.vite/build/main.mjs  2,771.45 kB │ gzip: 697.16 kB │ map: 5,514.09 kB
rendering chunks (2)...
computing gzip size (2)...
.vite/build/main.mjs  2,771.42 kB │ gzip: 697.13 kB │ map: 5,513.99 kB

However, final proof can be obtained by
-              fileName: () => "[name].mjs",
+              fileName: (format) => `[name].${format}.js`,

and indeed I my build directory contains:
-a--- 2920546 main.cjs.js
-a--- 5529438 main.cjs.js.map
-a--- 2920578 main.es.js
-a--- 5529531 main.es.js.map

Steps to reproduce
See expected behaviour.
Additional information
I use a few vite ESM-only APIs (like import.meta.glob()) and therefore cannot switch to CJS.

Users upgrading from any past version of Forge to 7.5.0 should now not experience breaking config changes.

I noted that you dropped compatibility guarantees, but I thought that this would qualify as a breaking config change.
I highly suspect that other vite array-options can't be overwritten as well.

Hi @ioV9x! Thanks for the report. From my initial read, I think this is a valid bug and we should take a look.

After many hours, I have managed to get ESM compilation working based on electron-vite-samples found in https://github.com/electron/forge/pull/3572.

@Denyol please double check your logs. In my case the ESM and CJS builds race and I suspect that you just were lucky that the ESM build won the race.

@Denyol please double check your logs. In my case the ESM and CJS builds race and I suspect that you just were lucky that the ESM build won the race.

That is strange, I was experiencing some builds failing due to compiling as CJS, trying again and it works seemingly randomly. Please point me in the direction of where I could find build logs.

We did not make any changes to the build format.
7.4.0
https://github.com/electron/forge/blob/v7.4.0/packages/template/vite/tmpl/vite.main.config.mjs#L17-L21

https://github.com/electron/forge/blob/v7.4.0/packages/template/vite/tmpl/vite.main.config.mjs#L17-L21
7.5.0

https://github.com/electron/forge/blob/v7.5.0/packages/plugin/vite/src/config/vite.main.config.ts#L10-L14

@caoxiemeihao as I stated in the opening post: I started with a template from 0.7.4 and I reconfigured vite to output ESM instead of CJS. The issue is not that a default or the template has changed, but that I can no longer override the default.
Btw. GitHub shows a code preview for referenced code if (and only if) you reference it via the commit hash (this is what the copy perma-link context menu action does), i.e. you would need to change the link like so:
-https://github.com/electron/forge/blob/v7.4.0/packages/template/vite/tmpl/vite.main.config.mjs#L17-L21
+https://github.com/electron/forge/blob/d3d47b2bc53be13609b5ff4d858275ce74bff819/packages/template/vite/tmpl/vite.main.config.mjs#L17-L21

https://github.com/electron/forge/blob/7574b364901ec429220dbe7076184585a99529a5/packages/plugin/vite/src/Config.ts#L3-L17
@caoxiemeihao Whether to make the entry optional, all the configuration of the vite build part is placed in vite.config.ts


How to set up the adversarial training?

Hi, I just tried to have the cyclic-adv-s545 model play against the latest 28b model. However, it doesn't seem to work very well. And I would like to do some fine tuning on my own. I just saw some scripts under kubernetes folder, but I don't really know how to make it run locally, so  is there any instructions on setting up the iterative adversarial training on a local machine?  By the way are there some more recent models? Thanks! @AdamGleave @tomtseng @ed1d1a8d

Right, I don't expect cyclic-adv-s545m to work well against 28b since KataGo has been adversarially trained against cyclic positions from cyclic-adv-s545m, though I would guess that if you spent several hundred GPU-days fine-tuning that you could get an attack against 28b.
I added some more detailed instructions in the README now and uploaded adversaries to Google Drive. I should note the scale of these experiments is a bit high (several hundred GPU-days) so if you don't have access to several GPUs you might find it hard to make much training progress.


Create a "Backwards incompatible changes" section in the Release note

Hi all,
since we have some breaking changes in 5.7.4 it would be nice to identify them clearly (and list them all) in the Release Note of the archive.
At least with this addon/theme devs would be aware of it.
@aembler, @KorvinSzanto Could we have that?

Additionally, it would be nice to have "deprecation plan" somewhere to explain what will be discarded in next releases as well (things such as Loader etc...).
A nice example of CMS Release note built that way is Django:
https://docs.djangoproject.com/en/1.8/releases/1.8/#backwards-incompatible-changes-in-1-8

Another example... Facebook Platform Upgrade Guide
https://developers.facebook.com/docs/apps/upgrading

Yes this seems like a good addition, especially given the action URL update that you brought to our attention over the weekend

This is been added internally and will be a part of the release notes once I update them for 5.7.4

Well, I did not see that section in the 5.7.4.* releases :/

We actually removed all our non-compatible 5.7.4 changes in favor of 5.7.5, and instead released 5.7.4 with a comprehensive pre-update check mechanism; going forward, when you attempt to install an update to concrete5 by placing it in the updates/ directory, it will query our server about the update you're trying to install, and send you information about it, including whether you need to update to an interim version first, whether certain add-ons you have are known to be incompatible, and even whether certain overrides you have are known to be a problem.

Not quite actually, editor_config was removed from elements in 5.7.4 which broke a legacy package I'm still porting. Used to work with 5.7.3. Not a big deal, but initializing redactor with editor_config doesn't work anymore..

Well, I kind of waited to see something in 5.7.4 or 5.7.5 about that, but did not see any section like this in the release note…
A bit of a let down I would say :/


Is org.kframework.main.AbstractKModule dead code?

I'm trying to find my way around the injection system and stumbled upon it. The project compiles without it.

The class needs to be updated to support more of the KORE injection-points, but it's still used by the OCAML backend and should not be deleted.

Thanks!


How load Loar from Hugging Face ?

My Colab has very limited runtime, So I used Kaggle to train Lora and uploaded it to Huggingface, then Colab load Lora form Huggingface
model.save_pretrained("/kaggle/working/outputs")  # Local saving
tokenizer.save_pretrained("/kaggle/working/outputs")

But when i use Colab prompt "Should have a model_type key in its config. json" , so i add "model_type": "llama" to config.json. then prompt "Your session crashed after using all available ROM."  What step did I do wrong?
from transformers import AutoModel, AutoTokenizer

model_name = "temp123/lora_model"
tokenizer = AutoTokenizer.from_pretrained(model_name)
model = AutoModel.from_pretrained(model_name)

Oh you need to use model.push_to_hub and not model.save_pretrained

Oh you need to use model.push_to_hub and not model.save_pretrained

I downloaded it from Kaggle and manually uploaded it to Huggingface , The problem I am currently facing is that the RAM will overflow due to "model = AutoModel.from_pretrained(model_name)"

Even if colab has enough running time, the disk will be full. I think text-generation-webui -> .gguf+ Lora is the fastest solution at the moment. 😅
main: quantize time = 221050.45 ms
main:    total time = 221050.45 ms
Unsloth: Conversion completed! Output location: ./model-unsloth.Q8_0.gguf
Unsloth: Merging 4bit and LoRA weights to 16bit...
Unsloth: Will use up to 6.72 out of 12.67 RAM for saving.
100%|██████████| 32/32 [00:48<00:00,  1.50s/it]
Unsloth: Saving tokenizer... Done.
Unsloth: Saving model... This might take 5 minutes for Llama-7b...
Unsloth: Saving a442509097/tempMode/pytorch_model-00001-of-00004.bin...
Unsloth: Saving a442509097/tempMode/pytorch_model-00002-of-00004.bin...
Unsloth: Merging 4bit and LoRA weights to 16bit...
Unsloth: Will use up to 6.36 out of 12.67 RAM for saving.
  0%|          | 0/32 [00:01<?, ?it/s]
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
[/usr/local/lib/python3.10/dist-packages/torch/serialization.py](https://localhost:8080/#) in save(obj, f, pickle_module, pickle_protocol, _use_new_zipfile_serialization, _disable_byteorder_record)
    627         with _open_zipfile_writer(f) as opened_zipfile:
--> 628             _save(obj, opened_zipfile, pickle_module, pickle_protocol, _disable_byteorder_record)
    629             return

15 frames
RuntimeError: [enforce fail at inline_container.cc:764] . PytorchStreamWriter failed writing file data/22: file write failed

During handling of the above exception, another exception occurred:

RuntimeError                              Traceback (most recent call last)
RuntimeError: [enforce fail at inline_container.cc:595] . unexpected pos 704676160 vs 704676048

During handling of the above exception, another exception occurred:

RuntimeError                              Traceback (most recent call last)
RuntimeError: [enforce fail at inline_container.cc:764] . PytorchStreamWriter failed writing file data/0: file write failed

During handling of the above exception, another exception occurred:

RuntimeError                              Traceback (most recent call last)
[/usr/local/lib/python3.10/dist-packages/torch/serialization.py](https://localhost:8080/#) in __exit__(self, *args)
    473
    474     def __exit__(self, *args) -> None:
--> 475         self.file_like.write_end_of_file()
    476         if self.file_stream is not None:
    477             self.file_stream.close()

RuntimeError: [enforce fail at inline_container.cc:595] . unexpected pos 576 vs 470

Wait even Colab runs out of disk space? Ye GGUF LoRA can work if that helps


MultiSelect checkbox spacing and checked icon problem

The checkbox on the Multiselect has no spacing with the option label, and the checked state icon isn't aligned correctly.
Tested with both Lara and Wind presets, no other custom CSS.
<MultiSelect :options="userOptions" v-model="shareUsers" placeholder="Select Users" 				optionLabel="label" optionValue="value" />

from main.js
app.use(PrimeVue, {
	unstyled: true,
	pt: Lara,
});

style.css
@tailwind base;
@tailwind components;
@tailwind utilities;

// :root colors etc

Hi, if you are using PrimeVue 3.47.x, this issue was from the core changes. These are fixed now.
You can check here for the issue and the release ⬇
https://github.com/primefaces/primevue-tailwind/issues/89
https://github.com/primefaces/primevue-tailwind/releases/tag/0.6.0


docker start Failed

@clcc2019 Could you provide /usr/lib/systemd/system/docker.service or /lib/systemd/system/docker.service?

/usr/lib/systemd/system/docker.service

@clcc2019 type lsb_release -a and dockerd to see what will happen.

dockerd
@justadogistaken

lsb_release

@clcc2019 I have a same linux vm, and no such errors occurred.  I found some solutions, could you follow the following approaches and see if it works?

rm -rf /var/lib/docker (will delete images) -> systemctl daemon-reload -> systemctl restart docker.
check on the host machine please with sysctl vm.overcommit_memory if memory overcommitment is enabled and set the value to 1 with sysctl vm.overcommit_memory=1 if not

@clcc2019 I have a same linux vm, and no such errors occurred. I found some solutions, could you follow the following approaches and see if it works?

rm -rf /var/lib/docker (will delete images) -> systemctl daemon-reload -> systemctl restart docker.
check on the host machine please with sysctl vm.overcommit_memory if memory overcommitment is enabled and set the value to 1 with sysctl vm.overcommit_memory=1 if not

I think it is caused by the files in the /etc/docker directory

@clcc2019 this issue fixed now? I will close this issue now if you already have this issue, reopen it


add support for DOCKER_API_VERSION

Fixes #13. The latest version of alpine now has docker 1.11, which supports the DOCKER_API_VERSION environment variable. This change makes that value default to 1.20 (for backwards compatibility), and allows it to be overridden to other versions.
I've tested this on a couple of different docker versions. The default API version (1.20) seems to work fine on a docker 1.11.1 host system, and overriding it to the latest API version (1.23) also works.
Unfortunately, it doesn't seem to quite work for docker 1.7.1 on the host system (API version 1.19). I don't have access to other systems to test, but would be curious if it works on docker 1.8 systems.

@aripringle was there a specific reason to select API version 1.20 as the default instead of 1.21 (Docker 1.9.0+) which supports the docker volume command? We'd like to change the default API version to 1.21 if possible
Best,
Mikael

Hi @mikljohansson, thanks for the merge. The only reason I set the default API version was to attempt backwards compatibility with the previous build of this project. Otherwise I think it's fine to default to the latest version, or omit the ENV directive altogether so docker uses its default (but could still be overridden of course)


Add script for CBMA unittests and fix tests

Jira-Id: SECO-7805

test_certificate_handler.py fix was copied from MS3.0 and test_secure_socket.py change was made based on the secure_socket implementation.


New State Boundry Map dor ladakh and jammu kashmir

Can You publish new JK and Ladakh State boundries?

The covid19india portal has the data with new boundaries in topojson format
https://github.com/covid19india/covid19india-react/tree/master/public/maps

Can You publish new JK and Ladakh State boundries?

I've raised the PR - you can find the geoJSON there #9

The boundary is not correct for J&K and Ladakh region.
may be helpful
https://data.humdata.org/dataset/geoboundaries-admin-boundaries-for-india

Can You publish Ladakh State Topology JSON for district.


[Question] Can Env.render take arguments?

Question
This line suggests that it is possible to pass [keyword] arguments to the gym.Env.render method.
https://github.com/Farama-Foundation/Gymnasium/blob/b4caf9df16e1f428a8b35c07455a9b8ebe8dfae9/gymnasium/wrappers/pixel_observation.py#L199
Which seems not to be consistent with how gym.Env is implemented in core.
https://github.com/Farama-Foundation/Gymnasium/blob/d46ff0e129072163d0aba6736f1b7eb0581cce8d/gymnasium/core.py#L146
Am I right?

It used to be the case that env.render() would take arguments, but we changed it a few releases ago. Now you set it with env = gym.make(..., render_mode="rgb_array"), and call env.render() without any arguments. The code you mentioned hasn't been properly updated since, although technically speaking I guess it doesn't really break anything.

Thanks for the clarification. Then the then render_kwargs args in the constructor is inoperative right?

I've just seen https://github.com/Farama-Foundation/Gymnasium/pull/301#issuecomment-1409499303. Should we consider PixelObservationWrapper as deprecated then? I read in your roadmap #12  "Release v0.29.0 as an intermediate version with experimental functional, new wrappers and vectors to root". Does it mean that PixelObservationWrapper is going to be replaced by experimental.wrappers.PixelObservationv0 in 0.29?

The roadmap needs to be updated for a new release in the next week not listed on the roadmap so it will replace PixelObservationWrapper in v0.31


grounding demo

Could offer a grounding demo?

Thank you for your interest in our work. Our model currently does not support grounding; however, it can achieve grounding if grounding data is added into the training dataset. Additionally, Florence-VL can inherit the capabilities of Florence-2 with appropriately curated training data.


Draft reimplementation of several GenoCAT examples

CNVkit: https://cnvkit.readthedocs.io/en/stable/plots.html

GIVE: http://genocat.tools/tools/give.html

CNVkit: https://cnvkit.readthedocs.io/en/stable/plots.html

GIVE: http://genocat.tools/tools/give.html

Eventually, use aggregated data for the performance.

Eventually, use aggregated data for the performance.

Some tools presented at TVCG.

Gremlin: http://compbio.cs.brown.edu/projects/gremlin/

O'Brien et al. Gremlin: an interactive visualization model for analyzing genomic rearrangements. TVCG 2010

MizBee: http://www.cs.utah.edu/~miriah/mizbee/Overview.html

Data: http://www.cs.utah.edu/~miriah/mizbee/Executables_files/fish.txt
Meyer et al. MizBee: a multiscale synteny browser. TVCG 2019

Variant View: https://www.cs.ubc.ca/labs/imager/tr/2013/VariantView/

Ferstay et al. Variant view: visualizing sequence variants in their gene context. TVCG 2013

PhenoBlocks (Not genomic): https://www.autodesk.com/research/publications/phenoblocks-phenotype-comparison-visualizations

Michael et al. TVCG 2016

Vials: Visualizing Alternative Splicing of Genes

Strobelt et al. TVCG 2016

Some tools presented at TVCG.

Gremlin: http://compbio.cs.brown.edu/projects/gremlin/

O'Brien et al. Gremlin: an interactive visualization model for analyzing genomic rearrangements. TVCG 2010

MizBee: http://www.cs.utah.edu/~miriah/mizbee/Overview.html

Data: http://www.cs.utah.edu/~miriah/mizbee/Executables_files/fish.txt
Meyer et al. MizBee: a multiscale synteny browser. TVCG 2019

Variant View: https://www.cs.ubc.ca/labs/imager/tr/2013/VariantView/

Ferstay et al. Variant view: visualizing sequence variants in their gene context. TVCG 2013

PhenoBlocks (Not genomic): https://www.autodesk.com/research/publications/phenoblocks-phenotype-comparison-visualizations

Michael et al. TVCG 2016

Vials: Visualizing Alternative Splicing of Genes

Strobelt et al. TVCG 2016


Unable to startup the IS 5.11 With Oracle Rac DB[19c]

Describe the issue:

Unable to startup the IS 5.11 With Oracle Rac DB [19c], due to getting following error traces
[2024-06-25 16:30:02,511] [] ERROR {org.wso2.carbon.identity.scim.common.internal.SCIMCommonComponent} - Error occurred while setting SCIM attributes for the Admin org.wso2.carbon.user.core.UserStoreException: Error in adding SCIM metadata to the admin in tenant domain: carbon.super
How to reproduce:

is.docs.wso2.com/en/latest/deploy/configure/databases/carbon-database/change-to-oracle-rac
Expected behavior:

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

This issue is occurring because there are some missing entries in the IDN_CLAIM and IDN_CLAIM_MAPPING tables. Further investigation is needed to determine why these entries were not added during the server startup.
A possible cause could be the connection being terminated abruptly due to the slowness of the database instance itself.

We have fixed the startup issues with Oracle Rac in IS 7.0.0 with this effort [1][2]
[1] "Testing Oracle Rac with IS 7.0.0"
[2] https://github.com/wso2/product-is/issues/20493

Need to double check whether this is fixed for the IS 5.11.0
cc: @shanggeeth

Closing this as we have fixed this in the master branch https://github.com/wso2/carbon-identity-framework/pull/5796


Document how to install updatecli through homebrew

Summary
The steps required to install the application via Homebrew (on Mac OSX systems( should be explained as it is now available.

Solved with pull request #151


Fix docker-compose

Description
This PR changes the docker compose to make it possible to scale down the ui properly

this PR was closed due to an alternative fix made by @sir-hassan


Pre Trained models release

Feature

Can you release a pre-trained model for every architecture you release?
Motivation

It is obvious that your library is becoming the standard framework for 3D object detection and it will be beneficial for the community if you can release the pre-trained models

Feature
Can you release a pre-trained model for every architecture you release?
Motivation
It is obvious that your library is becoming the standard framework for 3D object detection and it will be beneficial for the community if you can release the pre-trained models

hii @mzahran001 please do reply if you have the pretrained model

https://github.com/poodarchu/Det3D/blob/master/examples/cbgs/README.md
I've already released pre-trained model long time ago.


Unexpected matching in Polish format in Globalize

Polish (pl) for the format (yLLL) has the following issue -
Given that M and L has a small distance from each other, I would expect the format to be "LLL y". However, for Polish I am seeing unexpected results
These are the results I am seeing with Globalize

yMMM (01 Jan 2017) -> 01.2017
yLLL (01 Jan 2017) -> sty.2017

While ICU4j has the results as -

yLLL (01 Jan 2017) -> sty 2017

For yMMM, we are getting the closest result as yM -> "MM.y". This is already pretty strange considering the data has "yMMM" -> "LLL y".
Now, yLLL is matching to yM and then replacing MM with LLL (which is totally strange).
See the code sample below -
//Setup
const Globalize = require('globalize');
Globalize.load( require( "cldr-data" ).entireSupplemental() );
Globalize.load( require( "cldr-data" ).entireMainFor('pl') );
Globalize.locale('pl');

const formatterOptions = {
  skeleton: 'yLLL',
};

// Create a localized formatter.
const f = Globalize.dateFormatter(formatterOptions);

// Format a localized date
const localDate = f(new Date(2017,00,01));

// Setup en-US data
Globalize.load( require( "cldr-data" ).entireMainFor('en') );
Globalize.locale('en-US');

// Create an english formatter
const f2 = Globalize.dateFormatter(formatterOptions);
const englishDate = f2(new Date(2017,00,01));

console.log(localDate);
// sty.2017

console.log(englishDate);
// Jan 2017

A workaround that worked was to explicitly provide yLLL as a format so that I avoid the matching code altogether and concat this with the CLDR data.


Not able to filter patients using tags

New tags can be added to a patient but selecting a tag does not do anything to the patients list

tags do not refresh as well when you add one.
I've also seen this error when adding a tag, but can't reproduce it now. including anyways in case that rings a bell.
core.umd.js?e2a5:2843 Error: Failed to execute 'close' on 'HTMLDialogElement': The element does not have an 'open' attribute, and therefore cannot be closed.
    at HTMLButtonElement.eval (eval at 1192 (http://localhost:3000/app.js:197:2), <anonymous>:216:20)
    at ZoneDelegate.invokeTask (eval at <anonymous> (http://localhost:3000/polyfills.js:3239:2), <anonymous>:265:35)
    at Object.onInvokeTask (eval at <anonymous> (http://localhost:3000/vendor.js:101:2), <anonymous>:5966:41)
    at ZoneDelegate.invokeTask (eval at <anonymous> (http://localhost:3000/polyfills.js:3239:2), <anonymous>:264:40)
    at Zone.runTask (eval at <anonymous> (http://localhost:3000/polyfills.js:3239:2), <anonymous>:154:47)
    at HTMLButtonElement.ZoneTask.invoke (eval at <anonymous> (http://localhost:3000/polyfills.js:3239:2), <anonymous>:335:33)
  -------------   Elapsed: 1404 ms; At: Wed Feb 15 2017 11:22:30 GMT+0100 (CET)   -------------
    at Object.onScheduleTask (eval at <anonymous> (http://localhost:3000/polyfills.js:3245:2), <anonymous>:83:18)
    at ZoneDelegate.scheduleTask (eval at <anonymous> (http://localhost:3000/polyfills.js:3239:2), <anonymous>:242:49)
    at Zone.scheduleEventTask (eval at <anonymous> (http://localhost:3000/polyfills.js:3239:2), <anonymous>:174:39)
    at zoneAwareAddListener (eval at <anonymous> (http://localhost:3000/polyfills.js:3239:2), <anonymous>:824:14)
    at HTMLButtonElement.addEventListener (eval at createNamedFn (eval at <anonymous> (http://localhost:3000/polyfills.js:3239:2)), <anonymous>:3:43)
    at PatientsComponent.addTag (eval at 1192 (http://localhost:3000/app.js:197:2), <anonymous>:214:39)

This repository is now archived and no longer maintained. Closing old issues.


Install JDK 8 using DEB package for Linux

Currently JDK 8 for the Java 8 devcontainer is installed through a 3rd-party package manager.
The Eclipse Temurin project ships DEB packages for Debian and can be easily installed that way.
https://adoptium.net/blog/2021/12/eclipse-temurin-linux-installers-available/

Hi 👋
Currently, we install JDK 8 with the Java Feature (which installs it via SDKMAN from 'Temurin' repository - see here)
Won't installing JDK 8 by following the instructions from https://adoptium.net/blog/2021/12/eclipse-temurin-linux-installers-available/ provide similar results?


Can't capture exceptions from connectAwait

The way  StompClient.connectAwait is implemented doesn't seem correct to me because it doesn allow to capture the exception awaitResult might throw.
When connecting you might not be able to connect for various reasons, that can be handled. The way it is implemented now connectAwait returns StompClientConnection or it swallows exceptions?
This WON"T work:
        try {
            stompClient.connectAwait()
        } catch( e: Exception) {
            println(e)
        }

So if I can't connect then what? I get an exception on the main event loop? This is what i see
io.vertx.core.impl.NoStackTraceThrowable: CONNECTED frame not receive in time
I think awaitConnect should really be more like this:
    val connectionResult = awaitEvent<AsyncResult<StompClientConnection>> {
            stompClient.connect(it)
        }

please correct me if I am wrong.

Never mind this works just gotta catch Throwable


Mmakes e.g. % log <IP_ADDRESS> on internal txn

Not going to mark this for 8.x, because technically it's not compatible

[approve ci autest]

Going to close this, and just leave it as '0'.


Pre-built entities not supported when adding a remote skill

Describe the bug
Adding a remote skill that uses pre-built entity an error is presented indicating that pre-built entities are not supported.

Version
Version:  1.4.0-nightly.237101.f01cb52
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
Expected behavior
Pre-built entities should be supported.
cc @darrenj

This is a problem. Orchestrator's configuration on the LU syntax is driving the parser. Orchestrator does not support pre-built entities.
I assume your skill uses LUIS, which does. So we have a mismatch. cc @darrenj

Seems like we need to be smart about the root dialog's recognizer config, if root dialog is using "orchestrator", we will use certain lu parser config, if not, we will use default lu parser config(for LUIS), is that right?

@boydc2014 @luhan2017 Not sure if this is the same issue, but I also get an error when adding an entity in the create trigger dialog (my bot is using the default recognizer).

@VanyLaw is your PR covers the above scenario?


update controller-gen version

Issue #, if available: https://github.com/aws-controllers-k8s/code-generator/pull/135
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This file already exists in code-generator: https://github.com/aws-controllers-k8s/code-generator/blob/main/scripts/install-controller-gen.sh
Would you mind actually just deleting this, instead?

done

/lgtm


urlebird.com failed with error 503

Error message: Unexpected response from upstream. cUrl error:  (0) PHP error:
Query string: action=display&bridge=Urlebird&query=%40russianlanguagefamily&format=Atom
Version: dev.2021-04-25

Works fine for me

May be my network fails? I really don't know but when I checked the website and tried all the process to generate the feed link again, it displayed the same error as in my feed reader in firefox

HTTP 503 (Service Unavailable)
Maintenance perhaps? Bridge is working fine.


Fix text overflow in drowdown

The overflowing text should be ended in an ellipsis

Move the ellipsis styling to match the [data-szn-select--options--option] elements

Fixed in e8b384dc369fd5afb56288d68a8e3272b1631185


Update Part 3 Step 13

While demo-ing this, there was a concern that Freeze Frame data was not being validated.  It wasn't validated because the engine speed was not available, and the engine speed figures into the validation of the data.


Handling Dash (-) in Locale URL

Introduction:
Next.js 13 has introduced a plethora of features, making it one of the go-to frameworks for React developers. One of its standout features is its native support for internationalization. However, during our application development, we've encountered a minor hiccup related to the representation of locales in URLs.

Detailed Description of the Issue:
Upon implementation of the internationalization package, it was noticed that there's a potential limitation or bug in the way the package handles locales in the URL that contain a dash (-).

Working scenario: When using a simple locale without a dash, such as 'uz', the package works seamlessly. The URL http://localhost:3000/uz/ is parsed correctly, and the application responds with the expected localized content.
Problem scenario: Issues arise when using a locale with a dash, like 'uz-latin'. The URL http://localhost:3000/uz-latin/ does not behave as anticipated. Instead of recognizing 'uz-latin' as a single locale, it seems to misinterpret the structure.

Impact on Development:
For languages or regions that utilize a dash in their locale representation (e.g., en-US, zh-Hant), this could be a significant roadblock. It restricts the flexibility and the standard nomenclature for locale identifiers.

Potential Solutions/Workarounds:

URL Encoding: We can encode the dash in the URL. This might trick the parser into reading it as a single locale.
Custom Middleware: Introduce a middleware function that intercepts requests and modifies the dash-containing locale to another identifiable string before it reaches the Next.js parser.
Feedback Loop: This report serves as a means to inform the GitHub community and Next.js maintainers about the issue. With feedback, we can expect a fix in subsequent releases.

I'm not able to reproduce the problem, see: https://codesandbox.io/p/sandbox/next-international-app-router-forked-gwhv5q?file=%2Fapp%2F[locale]%2Fpage.tsx%3A1%2C1

Instead of recognizing 'uz-latin' as a single locale, it seems to misinterpret the structure.

What do you mean by this?


Can't "provide" reactive data property whose type is String or Number

Version
2.7.14
Reproduction link
stackblitz.com
Steps to reproduce
Click the button in the page.
What is expected?
"testNumber" in the Inner component is added after clicking the button.
What is actually happening?
I have provided "testNumber " in the Outer component, but I can't inject "testNumber " as reactive data in the Inner component.

I found when I provided reactive data whose type is Object, the injected data is reactive in the Inner component.So I will fix this problem by providing Object data consisting of a cluster of data.

After removing element-ui, the error doesn't appear. You should maybe report the bug there.

Thanks for your replay, the error still exists after removing element-ui, stackblitz link, but I can provide "this"(parent instance), then refer "this.testNumber" to get the injected reactive data.

There is still no warning, before or after updating your dependencies.
BTW, it's normal for the number not to be reactive you can find more in docs

I found the explanation in the doc untill just now! Thank you, bro, you are so kind!


[DO NOT MERGE] Traits lifecycle

Some experiment about traits life-cycle  see #268

Maybe we should find a way to configure the trait from the profile.
I.e. instead of if profile == 'x' in the trait, maybe better instantiating the trait with a specific property when choosing the profile. Wdyt?

I do agree.


Exchange client/server Implementation

Description
Exchange existing Server/Client Mechanics with what's available from digiflow.record where it went just yesterday.
This greatly improves the amount of unchecked code.

done


Adding Feature:  wrapper for awesomplete

I tried this code and it doesn't seem to be working right.  It is appending a comma after the selected value.  Is that the intention?
Also, add a demo and documentation.

@rbecheras can you update your request?

@ckosloski ok I'm sorry, I will.. I added it to my todo list now.

@rbecheras any update on this?


add rewarded video mediation

adcolony integration still a little bit hackish

Hi, I'm checking on this now... Looks really nice 👍
Have you by chance have something for the iOS? I'm considering merging this PR and adding gradle support for android so it works on OpenFL 4.1+ as well.
Also, do you know if the connectors are something we can distribute inside the extension or if we should link them from the android-sdk repository?

mediation connectors? I think we can distribute it inside the extension, but it will need extra care if the connectors get updated, we should update the distribution as well

I'm trying to merge this request, but I've noticed that AdColonyAdapter is kind of mandatory for this implementation (as com.jirbo.adcolony.AdColonyAdapter is directly used on AdMobEx.java and adcolony-mediation is forced on project.properties).
I wonder if there's a way of making this optional...
Anyway, I've opened a new branch named "mediation" where I've merged this changes. I hope we can soon add what's missing so we can merge it on main and release it un haxelib :)
So far I guess this is the only missing steps:

Support for gradle on connectors
iOS Implementation
Some way of dynamically adding AdColonyAdapter and other adapters only when needed).


Difference from 'dotnet build'

When should we use 'dotnet msbuild' as opposed to 'dotnet build'?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a9083568-6c58-1c1b-0062-10632e61a88d
Version Independent ID: a1d47471-9482-9f69-f11e-3424e62383f6
Content: dotnet msbuild command - .NET Core CLI
Content Source: docs/core/tools/dotnet-msbuild.md
Product: dotnet-core
GitHub Login: @mairaw
Microsoft Alias: mairaw

I ran into an issue where a build dependency loaded a Custom Assembly with a Custom Build Task in a .dll  This .dll depended on .net 4.0.  Using "dotnet build"  the build would fail to load System 4.0.0.
Using msbuild works, so I'd assume dotnet msbuild would work the same as MsBuild.
https://github.com/dotnet/standard/issues/328
https://github.com/Azure/azure-functions-vs-build-sdk/issues/160
Seems the MSBuild version used by dotnet build is "lightweight" or "scaled back" as it can't load external assemblies..

It is not clear whether "dotnet.exe msbuild" restores (downloads) dependencies like "dotnet.exe build" does?

@livarcocc @KathleenDollard @dsplaisted what can we add to the dotnet msbuild topic to make it more clear the distinction between dotnet build and dotnet msbuild? My understanding is that dotnet msbuild gives you the same capabilities as MSBuild, but you can also pass MSBuild parameters to dotnet build as well, right? I think the topic would benefit from having more information about the difference between the two commands.

dotnet build is basically the same as dotnet msbuild -restore -target:Build.

then what do both of them exist for?

@verbaloid Most of the time if you want to build your project you want to run dotnet build.  If you have a specific target you want to run (without running the build target), you probably want to use dotnet msbuild.  Basically dotnet build is the common case, but dotnet msbuild gives you more control.

thank you - now it is much more clear - can someone also update both microsoft dotnet build and msbuild pages by this guidance

dotnet build will always run the Build target.
So if you want to only run the MyTarget target, you should do dotnet msbuild -target:MyTarget.  You could also do dotnet build -target:MyTarget, but that would then run both MyTarget and the Build target.

Gotcha! Thanks @dsplaisted.


<EMAIL_ADDRESS>

This module is useless on Linux OS ;)
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":"0.8.x || 0.10.x"} (current: {"node":"0.12.0","npm":"2.7.1"})
npm ERR! Linux 3.19.2-1-MANJARO
npm ERR! argv "/usr/bin/node" "/usr/sbin/npm" "install"
npm ERR! node v0.12.0
npm ERR! npm  v2.7.1
npm ERR! code EBADPLATFORM

npm ERR! notsup Unsupported
npm ERR! notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm ERR! notsup Valid OS:    darwin
npm ERR! notsup Valid Arch:  any
npm ERR! notsup Actual OS:   linux
npm ERR! notsup Actual Arch: x64

Indeed, you need to be on darwin to be able to pack the OS X app. Are you suggesting anything?

Yep you can play with optionalDependencies in package.json (i think)
It should work like that :
+## os
+
+You can specify which operating systems your
+module will run on:
+
+    "os" : [ "darwin", "linux" ]
+
+You can also blacklist instead of whitelist operating systems,
+just prepend the blacklisted os with a '!':
+
+    "os" : [ "!win32" ]
+
+The host operating system is determined by `process.platform`
+
+It is allowed to both blacklist, and whitelist, although there isn't any
+good reason to do this.
+
+## cpu
+
+If your code only runs on certain cpu architectures,
+you can specify which ones.
+
+    "cpu" : [ "x64", "ia32" ]
+
+Like the `os` option, you can also blacklist architectures:
+
+    "cpu" : [ "!arm", "!mips" ]
+
+The host architecture is determined by `process.arch`
+

From https://docs.npmjs.com/files/package.json
optionalDependencies

If a dependency can be used, but you would like npm to proceed if it cannot be found or fails to
install, then you may put it in the optionalDependencies object. This is a map of package name to
version or url, just like the dependencies object. The difference is that build failures do not cause
installation to fail.

It is still your program's responsibility to handle the lack of the dependency. For example, something like this:

try {
  var foo = require('foo')
  var fooVersion = require('foo/package.json').version
} catch (er) {
  foo = null
}
if ( notGoodFooVersion(fooVersion) ) {
  foo = null
}

// .. then later in your program ..

if (foo) {
  foo.doFooThings()
}
Entries in optionalDependencies will override entries of the same name in dependencies, so it's usually best to only put in one place.

I see. I did not know where that log was from. I will move it to optional. Thanks for reporting this!


any Lua version?

Hi @skaae Do we have a Lua version for the recurrent spatial transformer network?

Hi
I dont have one.


EventWaitHandle names clarification

https://docs.microsoft.com/en-us/dotnet/api/system.threading.eventwaithandle.-ctor?view=netcore-3.1
Please describe Global\ and Local\ prefixes usable in named EventWaitHandle construction and specify which is default (Local\ one?) and that \ is reserver character.
This information could be shared with other named synchronization types.
Thank you

This issue was moved to dotnet/dotnet-api-docs#4865


Fix bounding sphere transformations

This follows #291.
Use GlobalTransform instead of LocalTransform for computing transformed bounding spheres. This takes the full transformation from local to world into account and properly deals with hierarchies of parents and children.

Unfortunately I can't merge this in yet as it contains #291. If you're able to perhaps just rebase on main with only get_bounding_sphere, I'll merge this in ASAP

If "Remove Transform..." is causing problems it should revert cleanly.

So is this correct? Why? Or more exactly, how can we know that all points inside the bounding sphere in local space are contained in this new sphere when transformed into world space?
If this holds:
$$|p_{local} - c_{local}| \le r_{local}$$
then we want this to hold:
$$|p_{world} - c_{world}| \le r_{world}$$
These are related by a transformation that may contain rotation, translation and scale, aka an affine transformation:
$$p_{world} = T_{world \leftarrow local} * p_{local}$$
We pick the new sphere center as the transformed center of the bounding sphere in local space:
$$c_{world} = T_{world \leftarrow local} * c_{local}$$
Because the sphere center is transformed in the same way as the points, a point at the center of the sphere in local space will also be in the center of the new sphere when transformed into world space.
So what about other points? We can simplify the problem by removing the translational part of the transformation because of how the new center is chosen. This leaves us with rotation and scale. This is the upper left 3x3 part of the 4x4 transformation matrix.
$$p_{world} = T_{world \leftarrow local} * p_{local} = L_{world \leftarrow local} * p_{local} + t_{world \leftarrow local}$$
$$p_{world} - c_{world}  = (L_{world \leftarrow local} * p_{local} + t_{world \leftarrow local}) -(L_{world \leftarrow local} * c_{local} + t_{world \leftarrow local})$$
$$p_{world} - c_{world}  = L_{world \leftarrow local} * (p_{local} - c_{local})$$
Let's insert that into the inequality that we want to hold:
$$|p_{world} - c_{world}| \le r_{world}$$
$$|L_{world \leftarrow local} * (p_{local} - c_{local})| \le r_{world}$$
Now we bring out the sledge hammer of linear algebra: The Singular Value Decomposition (SVD). Every matrix can be written as a product of three special matrices: rotation, axis aligned scale, and rotation. This is super useful for proving stuff because these special matrices have lots of special properties that can be used. If we would do this to the linear part of the transformation, we get:
$$L_{world \leftarrow local} = UDV'$$
$$|UDV' * (p_{local} - c_{local})| \le r_{world}$$
U and V are rotation matrices. Their columns all have unit length and are orthogonal to each other, same goes for their rows. Their transpose is also their inverse. The matrix D contains the scale and is a diagonal matrix. Multiplication with a diagonal matrix scales the rows if applied from the left or scales the columns if applied from the right.
Rotating a vector does not change its length so if we pick the new radius as the local radius times the biggest element in the diagonal matrix D, we will get a new sphere in world space that is big enough.
$$|UDV' * (p_{local} - c_{local})| \le max(D) * |p_{local} - c_{local}| = max(D) * r_{local}$$
$$r_{world} = max(D) * r_{local}$$
Ok, great! But that is not what the code says.
Admittedly, it does not. It scales the radius by the magnitude of the largest column of the linear part of the transformation matrix. However, if the scaling is axis aligned in local space, the matrix V will be an identity matrix representing zero rotation and we are left with $UD$. Multiplying on the right with a diagonal matrix scales the columns. The columns have unit length to start with. This means that the code works as long as the scale is uniform or axis aligned in local space. If this is not the case, it may underestimate the radius.


support string as an allowed pkey type.

I'm dealing with an api that uses strings (sometimes UUIDs, sometimes not) as primary keys.
I'd like to be able to model this in kallax.
Is there a specific reason that pk is limited to int64, UUID and ULID types?

Strings should not be used as primary keys in any relational database. I'm sorry if you have to deal with a setup like that, but we should not encourage this kind of bad design.

Thank you for considering.  I'll work around it somehow.


How to modify the start time of background music

hey，inlife！
Thank you for your help yesterday, I have solved that problem.
now，I have a new question：
use nexrender, How to modify the entry time of music，I hope that music will start playing from the 30th second！

well you have a few options

try to use expressions to achieve that (via https://github.com/inlife/nexrender#data-items)
try to use AE scripting to achieve that (via https://github.com/inlife/nexrender#script-items)
add a pre-render action that will use ffmpeg to create a clipped version of your original track (a bit overkill)

well you have a few options

try to use expressions to achieve that (via https://github.com/inlife/nexrender#data-items)
try to use AE scripting to achieve that (via https://github.com/inlife/nexrender#script-items)
add a pre-render action that will use ffmpeg to create a clipped version of your original track (a bit overkill)

thank you ,I try to use experessions
{       "type": "data",       "layerName": "tk.mp3",       "property": "displayStartTime",       "value": -350     },
and
{       "type": "data",       "layerName": "tk.mp3",       "property": "startTime",       "value": -350     },
used "displayStartTime" and "startTime", but none of them worked as I wanted.  can you give me some hints?

if you wish to set expression, you need to provide expression instead of value
and also make sure those properties actually do exist in the layer

if you wish to set an expression, you need to provide expression instead of value
and also make sure those properties actually do exist in the layer
Thank you for your reply，
Like 'Source Text', where can I see other property?

thanks，It seems that it can't be solved by `expressions'.


Rebuild to fix pygobject import of Gtk

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf are you fine with this? Or would you prefer to pin glib across conda-forge to 2.66.0 first?

Will merge this one in for now. We can bump it in pinning later.


[Extensibility Bug] Table 5050 "OnBeforeIsUpdateNeeded" - IsUpdateNeeded

Hello,
Its about Table Contact 5050
Sinds some versions there has been a fix around the xcontact record, the xrec is not reliable through modify via code.
This is fixed in the base application

but the check IsUpdateNeeded does not make use of the ContactBeforeModify, this way the check in IsUpdateNeeded is faulty.
and The event Publiser in IsUpdateNeeded

OnBeforeIsUpdateNeeded does also not make use of the new xrec (ContactBeforeModify), so our own fields that we check also come out false (because xcontact is not different from the contact) the ContactBeforeModify contains the truth.
So its a event parameter change request, but its very possible also a bug because the IsUpdateNeeded wil not function well on modify called by code.
suggested solution:

awaiting your answer

See also the BC14 code
Here the the same check is done, but the Xrec itself is beeing used for the find.

So in BC14 the IsUpdateNeeded in table 5050 works fine, but sinds the ContactBeforeModify, it does not work on modify through code.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Replace uses of df.append with pd.concat

Fixes #1493
Replaces uses of deprecated df.append function with pd.concat

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


use t.TempDir instead of ioutil.TempDir in unit tests

Signed-off-by: ianwoolf<EMAIL_ADDRESS>Updates #9594

I think there's just one last thing: the os import needs to be removed.
# github.com/prometheus/prometheus/promql [github.com/prometheus/prometheus/promql.test]
promql/engine_test.go:19:2: imported and not used: "os"

I think there's just one last thing: the os import needs to be removed.
# github.com/prometheus/prometheus/promql [github.com/prometheus/prometheus/promql.test]
promql/engine_test.go:19:2: imported and not used: "os"

OK, so I think I've figured out why test_windows keeps failing with the following error: testing.go:967: TempDir RemoveAll cleanup: remove C:\Users\circleci\AppData\Local\Temp\TestQueryConcurrency3635900781\001\queries.active: The process cannot access the file because it is being used by another process. This error happens because the query logger is still using the active query file when the temporary directory is removed. That file should be closed before the temporary directory is removed, and we do stop the query engine (which should close the file), just using a defer statement. That worked before this change when the temporary directory was also removed using a defer statement. But now, t.TempDir removes the directory using a cleanup function, which is called before the deferred functions are. Therefore, the directory is attempted to be removed before the query engine is closed, causing the error.
In order to fix this, these two deferred functions should be registered as cleanup functions instead:
https://github.com/ianwoolf/prometheus/blob/4ae36a0575b4a4bc243862231a0cf4e613d7970c/promql/engine_test.go#L53
https://github.com/ianwoolf/prometheus/blob/4ae36a0575b4a4bc243862231a0cf4e613d7970c/promql/engine_test.go#L58
(I don't think this one's actually necessary but we might as well)
That should fix it.

OK, so I think I've figured out why test_windows keeps failing with the following error: testing.go:967: TempDir RemoveAll cleanup: remove C:\Users\circleci\AppData\Local\Temp\TestQueryConcurrency3635900781\001\queries.active: The process cannot access the file because it is being used by another process. This error happens because the query logger is still using the active query file when the temporary directory is removed. That file should be closed before the temporary directory is removed, and we do stop the query engine (which should close the file), just using a defer statement. That worked before this change when the temporary directory was also removed using a defer statement. But now, t.TempDir removes the directory using a cleanup function, which is called before the deferred functions are. Therefore, the directory is attempted to be removed before the query engine is closed, causing the error.
In order to fix this, these two deferred functions should be registered as cleanup functions instead:
https://github.com/ianwoolf/prometheus/blob/4ae36a0575b4a4bc243862231a0cf4e613d7970c/promql/engine_test.go#L53
https://github.com/ianwoolf/prometheus/blob/4ae36a0575b4a4bc243862231a0cf4e613d7970c/promql/engine_test.go#L58 (I don't think this one's actually necessary but we might as well)
That should fix it.

3ks.   i will work on it.

OK, so I think I've figured out why test_windows keeps failing with the following error: testing.go:967: TempDir RemoveAll cleanup: remove C:\Users\circleci\AppData\Local\Temp\TestQueryConcurrency3635900781\001\queries.active: The process cannot access the file because it is being used by another process. This error happens because the query logger is still using the active query file when the temporary directory is removed. That file should be closed before the temporary directory is removed, and we do stop the query engine (which should close the file), just using a defer statement. That worked before this change when the temporary directory was also removed using a defer statement. But now, t.TempDir removes the directory using a cleanup function, which is called before the deferred functions are. Therefore, the directory is attempted to be removed before the query engine is closed, causing the error.
In order to fix this, these two deferred functions should be registered as cleanup functions instead:
https://github.com/ianwoolf/prometheus/blob/4ae36a0575b4a4bc243862231a0cf4e613d7970c/promql/engine_test.go#L53
https://github.com/ianwoolf/prometheus/blob/4ae36a0575b4a4bc243862231a0cf4e613d7970c/promql/engine_test.go#L58 (I don't think this one's actually necessary but we might as well)
That should fix it.

intresting...   i updated code,  register the defer as t.CleanUp functioins. But it didn't work, the windows test fail again.
So i found a windows and just run go test ./... under the directory promql, the test is fail. But it did pass on my mac. And i check the directory C:\Users\86136\AppData\Local\Temp\TestQ* of my windows, i get
Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        2022/2/27      0:12                TestQueryConcurrency18368351
d-----        2022/2/27      0:16                TestQueryConcurrency2333167212
d-----        2022/2/26     23:59                TestQueryConcurrency2363779818
d-----        2022/2/27      0:44                TestQueryConcurrency3202761245

seems these temp directories were not deleted. i don't know why? did i miss something or it was caused by somethinf of windows?

cc @ianwoolf can you please rebase this pull request? Thanks!

Discussed in the bug scrub; apologies we dropped the ball in July.  This still looks worthwhile, however at the last CI run Windows tests failed and something needs a DCO signed-off line.
@ianwoolf could you add the signed-off, rebase again and we can try to figure out the Windows test?

I think this PR can now be safely closed, since after rebasing on main and fixing conflicts, there are no changes left.

Thanks!


Community growth metrics from last 6 months and since inception

Screenshot of dapr community growth metrics from the last 6 months, and since project inception

No longer needed


Release 0.1.1

I released 0.1.0 just now in order for the PyPI project to be created, so I could create an API token for it (#15).
Also use setuptools-scm for versioning: this allow us to publish using tags to the repository.
I plan to release 0.1.1 just to test the workflow works.

@joshuadavidthomas what's your PyPI username?

Same as my GH username


Implement Exit in libtock_unittest, and add functionality for testing Exit calls.

Calling Exit on a fake kernel will cause the test process to exit.
I wanted to make Exit unwind, but that would make it impossible to test error handling in Allow implementations. In particular, the critical Drop implementation in #338 cannot be tested if Exit unwinds, as unwinding past the destructor would immediately cause undefined behavior.
In order to make code that calls Exit testable, I added an exit_test function (in the exit_test module). exit_test spawns a new process to run test code that should exit, and verifies the test code does call Exit.
exit_test is not usable under Miri, so I added a non-Miri test invocation to make test. This caused two issues:

It started executing doc tests, and some of our doc tests are broken. I ignored the doc tests for now.
Some sort of interaction occurred between cargo test and cargo miri that caused errors related to incorrect or outdated JSON. These occurred in procedural macro crates, which Miri doesn't support, so I disabled Miri on those crates.

bors r+ (ready to merge per the updated libtock-rs review policy)


Multiplexing does not work on 1.0.0-snapshot.0 release

When I tried to use https://gcsweb.istio.io/gcs/istio-prerelease/daily-build/release-1.0.0-snapshot.0-20180622-17-43/ to verify multiplexing feature, it does not work.
After some investigation, I found it's because pilot is not generating correct LDS Envoy configuration in that release version.

Check the build SHA, based on manifest.xml, it's 765445e938ac3b3088a6edecce7b4b17925dcba0 for istio/istio.
I checked out release-1.0.0-snapshot.0 and sync up to that commit, rebuild the pilot Docker image and locally build a Docker image, push it to gcr.io/jianfeih-test/pilot:0622-rebuild-a.
I modify the istio-pilot deployment YAML to use the locally build image.
Then the multiplexing feature works. Pilot generates the correct configuration.

Based on that, I suspect that Docker image is not built correctly for that release.

@incfly did you add any test for the feature? if so, could you check why https://github.com/istio-releases/daily-release/pull/677 passes?

I do add a test for the feature, it's part of the circle ci, e2e-pilot-noauth-v1alpha3 test. That test indeed pass.
Let me recreate a refresh env to reproduce the verification.

We recut the release so this becomes obsolete.


Frame locators

Add support for frame locators which were released in Playwright 1.17!

@avo I can't manually add reviewers, so mentioning you this way 🙂

FYI @Widen/testers group.


[packages/cli] Create email client figma

when running jsxm serve the jsx cli starts a server that has the function of simulating an email client. it should have the functions of:

send a e-mail (request e-mail and password of the sender and e-mail of the recipient)
List all templates
Go to a tamplate page (and request all variables that the template need)

the idea is to create a gmail-like interface, but this may change over time.
So in this issue we should develop the figma of this email client with the functions listed above. right after that we must open issues to create each screen or functionality of this email client.
the link to this figma should be placed as a comment on this issue and should also be included in the cli readme. (that's why I recommend doing this other one first)

figma: https://www.figma.com/file/hL1IjKPp9kwke9QT6XyokW/jsx-mail-client?node-id=2%3A1654


fix: wait for operations to complete before deleting clients

Fixes #913
Implemented the 2nd suggestion. I think it makes more sense to allow for existing operations to complete before calling terminate. In the user's repro it would be strange to have close() throw an error.

Do I read it correctly, that after resolving the Promise returned by terminate(), there might be still some actions pending? This is not an expected behavior, as it would again break some of the use cases for which this method was introduced in the first place. A correct behavior would be to wait for all of the pending operations to complete before resolving terminate().

We are debating between letting terminate() "hang" until all listeners are disconnected or terminating all active listeners with errors. Having user feedback here would be valuable.

In the original report you can see that listeners are actually disconnected before terminate is called. It's just that disconnecting the listener is exposed as a synchronous operation, whereas it's actually not.
I'd say that ideally disconnect of a listener should in that case also return a Promise, so you can shut down everything gracefully.
If this API change is not acceptable, what I'd expect is:

When listeners were disconnected (synchronously) before calling terminate(), wait for all of the background operations to complete before resolving the Promise.
When some of the listeners were not disconnected (synchronously) before calling terminate(), return a rejected Promise along the lines of "All listeners must be disconnected before terminating the client.".

Why? Because if you forget to disconnect some listeners and wait for terminate(), it will never resolve and debugging this issue might be hard. If you, on the other hand, terminate listeners with errors, you don't give developers a chance to shutdown the client gracefully.

@thebrianchen What @merlinnot suggested sounds sane to me. So, on terminate() we error if there are any active listeners. If there are no active listens, we block until all other operations complete (including listener disconnects, RunQuery processing and any outstanding writes).


Is it possible to add the internal temperature sensor support?

not esp32 has support for it https://docs.espressif.com/projects/esp-idf/en/stable/esp32c3/api-reference/peripherals/temp_sensor.html
Twin issue for the esp-idf-hal crate https://github.com/esp-rs/esp-idf-hal/issues/333

It's for sure possible, a PR would be most welcome :).

I'd need lots of guidance first, I do not know enough of the esp-idf and esp-hal to commit to it yet ^^;

Just some notes/thoughts.  For anyone wanting to implement.  Might make a good "beginner" task, since turning on is just a few bit flips, and you just read the lowest byte and follow a set algorithm.
T(°C) = 0.4386 ∗ VALUE–27.88 ∗ offset–20.52
Basic low-level bit-flipping and definitions for the TSENSor are here:
esp-pacs/esp32c3/src/apb_saradc/tsens_ctrl.rs
esp-pacs/esp32c3/src/apb_saradc/tsens_ctrl2.rs
Hardware ports/memory are already defined in:
esp-pacs/esp32c3/svd/esp32c3.base.svd
Would need to add the "tsens" peripheral here, I think
esp-hal/esp-hal/src/system.rs
and possibly here?  Not sure:
esp-hal/esp-hal/src/analog/adc/riscv.rs
Would it be better to add the higher level implementation here, since it's connected to the ADC peripheral?  But then it might get "hidden" and hard to find.
esp-hal/esp-hal/src/analog/adc/esp32.rs
Or would it be better to implement this in
esp-hal/esp-hal/src/analog/tsens/esp32.rs


Feature - Keybinding Help

To test the Pull Request: press the questionmark to the bottom left and open/close the Keybinding Help.

These keybindings are inputs for a specific sketch, (FullSerialControl.ino I think) are we sure we want to put dedicated help for that? The goal of smce-gd is to allow people to make their own sketches so hardcoding help for a single sketch is a bit odd.


⚠ ClamAV has degraded performance

In 748fbbc, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 428 ms

Resolved: ClamAV performance has improved in 06d398c.


New app fails with Invalid null operation: "null gt null".

Here's an example app https://github.com/MattMSumner/test-sus-2.
Visiting http://localhost:3000/high_scores produces:

Commenting out https://github.com/MattMSumner/test-sus-2/blob/master/app/assets/stylesheets/base/_typography.scss#L15 "fixes" the issue.

Seems like https://github.com/MattMSumner/test-sus-2 is working for other but https://github.com/MattMSumner/test-sus is an example where I've upgraded sprockets and this doesn't work. I get the following error:

Does this still happen on latest release? Thank you!

cc @MattMSumner. Thank you!

I assume #802 addressed this issue. Thanks!


feat: Add release please to handle releases

This PR

Add the release please action to handle release versioning
Related Issues

Notes

Follow-up Tasks

How to test

It's also worth mentioning that Release Please works off semantic commits. Most of the repos use a PR title validator and perform squash merges. I'm happy to help set that up if you're interested.

It's also worth mentioning that Release Please works off semantic commits. Most of the repos use a PR title validator and perform squash merges. I'm happy to help set that up if you're interested.

I believe this has already been set up here https://github.com/open-feature/python-sdk/blob/main/.github/workflows/lint-pr.yml


Detail page should handle missing data gracefully

The detail page currently errors out on regions with incomplete data. There should be "No data" states for each of the <Section*> components for when the backend API has returned a result but had no data for that metric.
The backend response may have nulls or empty arrays for some properties, or the properties may not even be present. All of those cases should be considered "No data". 0 shouldn't be treated as "No data".
Test cases

497979799 is a good test. It's a valid backend response with nothing besides a title.
402041039 is another good test. It and the other regions with a grey fill on the map only have partial data.

Mockups

Figma mockup of a region with all data missing

All charts get the same grey rectangle with centered "No data" text:

Everything else just gets the text "No data":

Resolved by #265.


Fix build failure for importing NSUInteger as Int instead of the previously tested ok UInt

fixes rdar://problem/30899471

@swift-ci please test and merge

@jrose-apple Why would the previous PR build and test ok with the failure? It seems rather fishy.

Terrible reasons. I tried to stir up interest to fix this but there didn't seem to be any takers.

You may be able to avoid this in the future by adding [system] to Foundation's module map, so that it'll be treated as a system module no matter where you import it from.

Do I need to add [system] to the shim module map?

...ah. Well, drat.. Can you make a PR for that?

for adding [system] to the module map like this?
module _SwiftCoreFoundationOverlayShims [system] {
  header "CoreFoundationOverlayShims.h"
}

module _SwiftFoundationOverlayShims [system] {
  header "FoundationOverlayShims.h"
}

@swift-ci please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - afcd4103dd3e82749b00187f29834475b662c9d9
Test requested by - @phausler

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - afcd4103dd3e82749b00187f29834475b662c9d9
Test requested by - @phausler

No, to change the importer to always import shims as system modules. The only reason we didn't was to catch warnings, but we can add a test that just uses -Wsystem-headers.

so you are saying instead that I should change them to be:
#define SHIMS_INCLUDE_FLAG "-isystem"

unconditionally no matter if it is NDEBUG or not?

Yes, I think that's the right thing to do going forward.

so to be clear; the [system] change is inappropriate and should not be done then?

@swift-ci please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 7d516026d6cc6dea182f9570cc3bbe33fe1a7d96
Test requested by - @phausler

@swift-ci please test and merge

@phausler I think the OS X platform build failed again. The UI is just a bit messed up I believe. See:
https://ci.swift.org/job/swift-PR-osx/5888/
It looks like it is testing your latest commit and it failed.

@swift-ci please test and merge

Started by upstream project Swift Test and Merge build number 1566
originally caused by:
GitHub pull request #7979 of commit 125ef78a518e340a0bd6226bc6ecabfe478002fc, no merge conflicts.

that is the wrong sha1; it should be 00f3908c9cfe4c059ed3e97d0b5da71218165352
yet again another failure by the CI not picking up the right commits

the latest build is showing a build of 00f3908c9cfe4c059ed3e97d0b5da71218165352 which is correct
however this is now failing due to something that looks like something completely different?
/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/swift/validation-test/compiler_crashers/28697-anonymous-namespace-findcapturedvars-checktype-swift-type-swift-sourceloc.swift:9:1: error: top-level statement cannot begin with a closure expression
09:58:04 {{extension{init(UInt=_=1 + 1 as?Int?Int){var f=nil?Int
09:58:04 ^

@jrose-apple should I just revert this whole ball of wax?

It's possible we have a non-deterministic test. We should really try to get this in because it's blocking all our no-asserts builds. Let's just merge by hand once we pass a test.
@swift-ci Please smoke test macOS

(I blame Past Me for leaving this trap in there.)

@jrose-apple I can force the merge even with tests failing if you think that's the right thing to do.

It passed the smoke tests, so no force needed.
Thanks, Philippe!