Fix bugs in Strutil::parse_string that would fail for escaped quotes

Two subtle bugs in Strutil::parse_string:

Toggling whether we are in an escape code based on the first
character in the original string, rather than the next character to
scan.  Big oops!

Not realizing that a second backslash in a row should clear the
flag (i.e. \\ does not leave you in an escaped state).

I beefed up the unit tests, looking at the example I added should
explain the edge case where this crops up -- a double-quoted string
with embedded \" within it, if you catch my drift. Just look at the
unit test, it explains better than I can do here. It's very hard to
talk and write (and reason correctly) about escaped strings with
embedded quotes!

LGTM

LGBTQ :)
/Z

The hardest part of this was constructing the test -- it was really hard to reason about the right numbers of backslashes in different places to express in C++ the string that was causing the trouble.

Can we have this in a 1.10.8 perchance?

Oh... just realizing this is in OIIO code not OSL code... well...  is it in a release?

There were some escaping fixes in OIIO, and some in OSL. Both are needed, but I incorporated the important OIIO fix into OSL itself (inside an ifdef OIIO is older than...), in case you aren't able to upgrade both. :-)
Both are currently backported to their respective RB-?.? branches, but have not yet have official tagged releases (which I usually do on the first of the month). If it's really important for you to have a tagged release before then (like, if you have an imminent ship deadline and are only allowed to use tagged releases of dependencies), let me know and I can do it for you now.

Omg no, I'm not in THAT much of a hurry./ZOn Nov 20, 2019 17:32, Larry Gritz<EMAIL_ADDRESS>wrote:There were some escaping fixes in OIIO, and some in OSL. Both are needed, but I incorporated the important OIIO fix into OSL itself (inside an ifdef OIIO is older than...), in case you aren't able to upgrade both. :-)
Both are currently backported to their respective RB-?.? branches, but have not yet have official tagged releases (which I usually do on the first of the month). If it's really important for you to have a tagged release before then (like, if you have an imminent ship deadline and are only allowed to use tagged releases of dependencies), let me know and I can do it for you now.
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.


GitHub repo creation not working on mac OS

It fails with error:
error: unknown switch `U' usage: git remote add []   -f, --fetch fetch the remote branches --tags import all tags and associated objects when fetching or do not fetch any tag at all (--no-tags) -t, --track  branch(es) to track -m, --master  master branch --mirror[=(push|fetch)] set up remote as a mirror to push to or fetch from

Thanks for pointing it out. The issue has been fixed now.


ARROW-17521: [Python] Add python bindings for NamedTableProvider for Substrait consumer

This PR includes a basic version to use NamedTable feature in Substrait. The idea is to provide the flexibility to write Python tests with in-memory PyArrow tables.

cc @westonpace @richita

@westonpace one doubt is handling multiple names in the provider. Assume we get multiple tables, how should we generate the output?

@westonpace one doubt is handling multiple names in the provider. Assume we get multiple tables, how should we generate the output?

Each call to the function should return a single table.
If multiple names are provided then they form a single combined name.  I'm not really sure why it is structured that way but I think the idea is a that tablenames are often namespaces, for example ["sales", "orders"] is a single table sales.orders and not two different tables.
A provider function is free to know about as many tables as it wants but it can only return one table each call.

@westonpace any more thoughts on this one? Should we add more tests?

cc @westonpace the failing CI is fixed here: https://github.com/apache/arrow/pull/14113

This is a nice improvement!
I am wondering one thing: why does the function take a list of names, instead of a single name?
I understand from https://github.com/apache/arrow/pull/14024#issuecomment-1236472120 that this is because the name can potentially be a list of names indicating some nested schema.
But for the simple case of single names, having a function that just gets a string and returns a table would be simpler to implement. And for example that would allow to actually implement this easily with a mapping (eg table_provide={"table1": table1, "table2: table2}.get)
Would it be an option to call the function with a single string, in case of length 1 list?

This is a nice improvement!
I am wondering one thing: why does the function take a list of names, instead of a single name?
I understand from #14024 (comment) that this is because the name can potentially be a list of names indicating some nested schema.
But for the simple case of single names, having a function that just gets a string and returns a table would be simpler to implement. And for example that would allow to actually implement this easily with a mapping (eg table_provide={"table1": table1, "table2: table2}.get)
Would it be an option to call the function with a single string, in case of length 1 list?

Good point. Probably we can create a Cython level wrapper for this.


Adds PanZoomMouseWheelTool

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
New PanZoomMouseWheelTool that orchestrates PanTool and ZoomMouseWheel together

What is the current behavior? (You can also link to an open issue here)
N/A

What is the new behavior (if this is a feature change)?
N/A

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
N/A

@dlwire Done! I've removed the contributions commit and renamed the file/tool.


DataError /admin/login/

Hi, i have a problem in production mode
DataError: invalid input syntax for type inet: "b''"
LINE 1: ...estamp", "path") VALUES<EMAIL_ADDRESS>'b'''''::i...
                                                             ^

  File "django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)
DataError: invalid input syntax for type inet: "b''"
LINE 1: ...estamp", "path") VALUES<EMAIL_ADDRESS>'b'''''::i...
                                                             ^

  File "django/core/handlers/exception.py", line 39, in inner
    response = get_response(request)
  File "django/core/handlers/base.py", line 249, in _legacy_get_response
    response = self._get_response(request)
  File "django/core/handlers/base.py", line 187, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "django/views/generic/base.py", line 68, in view
    return self.dispatch(request, *args, **kwargs)
  File "admin_honeypot/views.py", line 27, in dispatch
    return super(AdminHoneypot, self).dispatch(request, *args, **kwargs)
  File "django/views/generic/base.py", line 88, in dispatch
    return handler(request, *args, **kwargs)
  File "django/views/generic/edit.py", line 185, in post
    return self.form_invalid(form)
  File "admin_honeypot/views.py", line 51, in form_invalid
    path=self.request.get_full_path(),
  File "django/db/models/manager.py", line 85, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "django/db/models/query.py", line 399, in create
    obj.save(force_insert=True, using=self.db)
  File "django/db/models/base.py", line 796, in save
    force_update=force_update, update_fields=update_fields)
  File "django/db/models/base.py", line 824, in save_base
    updated = self._save_table(raw, cls, force_insert, force_update, using, update_fields)
  File "django/db/models/base.py", line 908, in _save_table
    result = self._do_insert(cls._base_manager, using, fields, update_pk, raw)
  File "django/db/models/base.py", line 947, in _do_insert
    using=using, raw=raw)
  File "django/db/models/manager.py", line 85, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "django/db/models/query.py", line 1045, in _insert
    return query.get_compiler(using=using).execute_sql(return_id)
  File "django/db/models/sql/compiler.py", line 1054, in execute_sql
    cursor.execute(sql, params)
  File "raven/contrib/django/client.py", line 114, in execute
    return real_execute(self, sql, params)
  File "django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)
  File "django/db/utils.py", line 94, in __exit__
    six.reraise(dj_exc_type, dj_exc_value, traceback)
  File "django/utils/six.py", line 685, in reraise
    raise value.with_traceback(tb)
  File "django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)

@jfajardo what version are you using?

Closing since I haven't heard back.


Adding Adaptive SpecAugment

#236 Hi! Me and @cornliu have implemented Adaptive SpecAugment for downstream tasks (ASR & CTC) and pretrain tasks by modifying  several files.

@ShampooWang @cornliu Thanks! This is sufficient for tomorrow's project deadline (we do not have to merge this by tomorrow).
It will be nice to have some comparison results on using "spec aug" v.s. "adaptive spec aug" for tomorrow's presentation. Great work!

@leo19941227 Can you check if modifying these config files are appropriate for the launched SUPERB v1 challenge? Or we can do a separate config file, without modifying the original configs.

Thanks @ShampooWang @cornliu and @andi611!
I find that this PR will change the default behavior of ASR and SNIPS to use adaptive specaug. I think it will be nice we make sure the new configs have the exactly same behavior compared to the original config.

We change the adaptive default value from true to false in the yaml file. It may let the new configs have the same behavior with the old one.

@leo19941227 and @andi611 May I ask which version of time wrapping did class TimeWarp follow from? I assumed that your implementation followed from the original version or the second version, whose author provided a specific formula. Although two versions are equivalent, I'm just afraid that if your class TimeWarp followed from other versions of time wrapping, and unfortunately it is not equivalent to the versions as I mentioned above, then maybe we should modify class TimeWarp.

We follow the ESPnet experience where they find a few large masks are better than lots of small masks.
https://github.com/espnet/espnet/blob/master/egs2/librispeech/asr1/conf/tuning/train_asr_conformer6_n_fft512_hop_length256.yaml

We follow the ESPnet implementation here: https://espnet.github.io/espnet/_modules/espnet2/layers/time_warp.html
I think we can always provide new classes to support different implementations instead of modifying the existing one.
Also, I am curious about how much this difference affect the final performance. It will be nice to run some experiments.

I found that ESPnet's implementation of SpecAugment followed from this paper, which followed from the original version as I mentioned above, so it is equivalent to the second version, my main reference. Also, I also found that the author of SpecAugment have mentioned that "Time warping contributes, but is not a major factor in improving performance", "Time warping,
being the most expensive as well as the least influential of the
augmentations discussed in this work.". In conclusion, I think we don't have to modify class TimeWarp.

However, I am also curious about the possibility of some differences, so I am willing to provide a new class of TimeWarp, an implementation of my main reference, but I think this implementation is more appropriate to be requested in a new PR

Sure! Please go ahead. I look forward to the new PR.
Please also consider to add some results (ablation tables) for the newly added functions in the PR page. Thanks!

Sorry for my delay, it took me 5-6 days to run over 200k stpes, and the learning curves are presented in this picture.

We found some interest results. First, the training loss of Adaptive SpecAugment was way more higher than the default. Second, Adaptive SpecAugment needs more steps to converge. Last but not least, the wer of the default on dev-clean is 23.28(which is differ from 23.18 mentioned in your paper. Do I have to run more steps or adjust some hyper-parameters to achieve?), and  the wer of the Adaptive SpecAugment on dev-clean is 23.3. I think the performance was effected by the small size of mask windows, and I infer that if we take more steps in training or adjust some hyper parameters, Adaptive SpecAugment will outperform the SpecAugment.

After my evaluation, I decided to not change pretrain's SpecAugment to adpative, so I change the pretrain part to your original version, or you can just block the merging of any file changes under s3prl/s3prl/pretrain/spec_augment/ For downstream parts, I think it is ready to be merged, if everything is ok, I will close this PR.

Hi @ShampooWang ,
For the 0.1 WER difference, I think it is not significant, especially when CTC loss implemented in PyTorch is essentially non-deterministic by default. (You can make it deterministic by sacrificing the training speed)
Hence, even with the exactly same seed, you can't get the exactly same result.
According to my experience, this difference is acceptable.
If you are interested in what is the outcome of more training steps, you don't need to re-train it.
You can simply load the checkpoint back and continuing the training by overriding the total_steps.
Specifically:
python3 run_downstream.py -e `your_last_checkpoint.ckpt` -o config.runner.total_steps=300000

Then, the training will continue for the extra 100k steps, and the all the artifacts will appear in the same expdir you previously assign (you can also override this by -o args.expdir=newpath), including the new Tensorboard event file. Then, you can see the training curves grow from where it stopped, which is 200k steps. Just in case you are interested.
May I ask about you plan on closing the PR? Do you wish to merge this PR or open another PR for the adaptive-specaugment?

Very appreciate to your recommendation! I was wondering how to run more steps but not rerun the whole experiment. Since I am a novice, I misconstrue the function of "closing PR", what I really wish is to merge this PR and end this topic.

Hi @ShampooWang and @cornliu ,
Thanks for the contribution. LGTM!
I am merging this.


[firefox] Selection changes in aren't reflected in text fields

While editing a text field in the gallery app, use the keyboard arrow keys to move the cursor. Notice that the cursor doesn't move in the text field.

The PR is in.

This is not working. TextField is working at the beginning, but once it loses focus, like tapping on button, then textfield doesn't work anymore.

@AresVampire I tested now with flutter, it worked for me on Firefox and Chrome:
[✓] Flutter (Channel unknown, 1.21.0-10.0.pre.176, on Mac OS X 10.15.4 19E287, locale en-US)
• Flutter version 1.21.0-10.0.pre.176 at /Users/nurhan/development/flutter
• Framework revision 4954a46ff0 (5 days ago), 2020-08-19 14:44:56 -0700
• Engine revision<PHONE_NUMBER>
• Dart version 2.10.0 (build 2.10.0-45.0.dev)
Can you please open another issue, share flutter doctor output and sample code? Also please note down the browsers (or platforms) you observe the issue.


Refactor System.Drawing out of the project

As of .Net 7 System.Drawing isn't supported by MSFT on Linux any more. Would be good to remove all references to System.Drawing and replace with something like ImageSharp.

@Webreaper
Good idea but ImageSharp just changed license.
I would like to replace with SkiaSharp.
What do you think?
BTW, I have no time to work on OSS working now.
Sorry.

ImageSharp's licence will be fine for most people - it's free for anyone whose organisation is pulling less than $1mm revenue.
But yes, Skiasharp would also be fine for this. Both are pretty equivalent for the basic task of pulling out bitmap bits to process for face detection etc.

This issue is related to https://github.com/takuya-takeuchi/FaceRecognitionDotNet/issues/223

ToBitmap method will use DlibDotNet.Extensions.Drawing.
Create FaceRecognitionDotNet.Extensions.Drawing and provide ToBitmap by using DlibDotNet.Extensions.Drawing.

Has there been any progress on this issue?

Has the development done on this issue?


Restrictions on register

With the current implementation if you call register with an invalid function name, the call silently works without any warnings or errors. Ex. register("", &42), register("0foo", &42), register("фоо", &42).
Would make sense to throw an error, if name does not match [a-zA-Z_$][a-zA-Z0-9_$]* for easier debugging.

Another thing I've noticed, is that calling register with a name of an already existing function does not register the new function, with just a warning debug message shown. While I see the point, why we wouldn't want to allow overriding standard functions, this could cause backward-compatibility issues, if any new standard functions will be added. Ex. if there will be a document in the wild with register("product", &@[0] * @[1]) included in the form and a product function is added in the standard later, it will start failing.

this could cause backward-compatibility issues, if any new standard functions will be added

Two possible solutions:

Allow standard functions to be overridden
Advise users to use domain-specific name for custom functions.  e.g. 'acmeProduct()'

preference?

If it was up to me, I would go with (1).
And, potentially, have something like "standard function names do not begin with _ (or $, not sure), so prefer such names, if possible". Might also have a potential side effect, that it will be easier to spot user-defined functions.
I was thinking, that a likely use case for register would be to extract common expression parts under a short readable name, which goes against (2) somewhat.

I think I will also restrict the name construction to: /[_a-zA-Z][_a-zA-Z0-9$]*/.  i.e. a subset of identifier

We talked this over internally, and propose that we solve this by:

Do not allow overrides on existing functions
require registered functions to follow a naming pattern where they begin with an underscore

agreed


Error reporting

Vulcanize is failing silently for me, it would be nice if there was at least a --verbose flag to produce errors.

Please check with vulcanize 1.4.3. There was a silent error on cyclic dependencies.

I was working on 0.5, I will just close and reopen if I run into the problem after I migrate to 0.9.


RViz2 Freezing with Autoware - Ubuntu 22 VM on Apple Silicon

Your environment

OS Version: Ubuntu 22.04 (on UTM Apple Silicon)
ROS Distro: Humble
RViz, Qt, OGRE, OpenGl version as printed by rviz:(see launch.log file at the end)

If source build, which git commit? (?) Followed the Default ROS2 installation (I think this is where I installed RViz), als using the latest Autoware Source Installation
System locale, i.e. the output of echo "$LANG $LC_NUMERIC": en_US.UTF-8
Before reporting a rendering issue, try running RViz with LANG=C rviz!

Rviz2 works find with an empty configuration. However, when following the Autoware Planning Simulation instructions, The centre display freezes the second time I try to interact with the 3D space:
https://github.com/user-attachments/assets/3ae6de2e-c1e9-4745-bc8b-fe9da17ee063
$HOME/.ros/log output:  launch.log

Hello @dtonda8,
In this particular scenario, it would be great to isolate the cause of the issue since at the moment there are many confounding variables including an older version of ROS 2, 3rd Party extensions to ROS 2 (Autoware), the fact that this is all running within a VM, and lastly given that the VM itself is running on a tier-3 support OS for ROS 2.
It would greatly help if you could ascertain the following:

Whether the version of RViz using within Autoware is exactly the same as what's in this repo (humble branch) without any patches applied. If there are any modifications, please share the diff here.
If the issue can be reproduced with ROS 2 Rolling version of RViz on a Tier-1 OS outside of any VM, ie, this repo built from source off the latest rolling branch on Ubuntu 24.04. And specifically outside of Autoware. A simple self contained reproducible scenario would be excellent.
Does running the above Autoware demo with ROS 2 Rolling make the problem go away?

Answering these would help us understand whether this is really a problem in RViz, Autoware, VM environment etc.
Personally I use RViz (ROS 2 Iron built from source) on M1 Mac running MacOS Sonoma 14.5 without any issues (No VM and not tested with Autoware).


File Not Found Error: [Errno 2]

试着运行 给定的example ，报错
File Not Found Error: [Errno 2] File C:\ProgramData\Anaconda3\lib\site-packages\flowrisk-0.2.3-py3.7.egg\flowrisk\examples\data\CBIO_2018_11_22.csv does not exist

hey please try again
i just updated it to support 3.8


Build(deps-dev): Bump @types/jest from 27.4.1 to 27.5.0 (#3438)

Pull request opened by the merge tool on behalf of #3438

Merged in a5e3e01a52297822003db25767119f1f27bedddc


docs: update Sphinx's API documentation

Closes #220

@tromai any idea why we get these warnings while running make docs?

This is a known issue and we have a ticket for it - https://github.com/oracle-samples/macaron/issues/84.


Fix CCMA extractor

Before submitting a pull request make sure you have:

[X] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[X] Searched the bugtracker for similar pull requests
[X] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[X] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[X] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Fixing two bugs present in CCMA extractor.

Incorrect timestamp:

For some reason, provided UTC timestamp does not comply ISO8601, as its format is YYYY-DD-MM instead of expected YYYY-MM-DD.
This is made evident in the also provided "text" field of emission date object. Example:
    "data_emissio": {
                "text": "14/05/2002�21:39",
                "utc": "2002-14-05T21:39:28+0200"
    }

Multiple subtitles support (#24347)

The extractor used to raise an exception when attempting the download of a URL featuring multiple subtitle languages.
Behavior of the subtitols field is:

When a single language is available, the field is the expected dict.

When multiple languages are available, a list of dict is provided.

A test is added with an URL featuring multiple subtitles, to ensure no exception is raised during extraction.

please merge

please merge

True, it's been more than one month this has been here. Same for #24347. Is anything in particular missing/blocking it from being merged, @dstftw ?


Lost focus on tag adding

Hello,
I have a Multiselect component :
<Multiselect     v-model="datas.name.data"     mode="tags"     :search="true"     :searchable="true"     :placeholder="datas.name.placeholder"     @open="filteredName"     :options="datas.name.items"     track-by="value"     class="custom-tags-input no-caret"     :limit="limit"     :loading="loadingName"     :disabled="loadingName"     :showOptions="datas.name.showOptions"     @search-change="optionsDisplay"     @close="onCloseDrugname"     :strict="false" />
On my local machine, once I select an option on autocomplete, the focus stay on the input. But on my staging environment, it's not (same version of the code in both environment). I have to click again on the input to get the focus.
Do you know what can be at the origin of this bug ?
Thank you for your help.
Jérémy

Thanks for reporting @bouffekai  - fixed in 2.3.0. Now every time you select an option while having search the focus should be placed back to the input.


1.9.8 Crash on server in FIPS mode

Error:
fips.c(152): OpenSSL internal error, assertion failed: FATAL FIPS SELFTEST FAILURE
PhantomJS has crashed. Please read the crash reporting guide at https://github.com/ariya/phantomjs/wiki/Crash-Reporting and file a bug report at https://github.com/ariya/phantomjs/issues/new with the crash dump file attached: /tmp/6a6322a9-47b7-4f86-24429c4a-72de7e1c.dmp
Aborted
GDB backtrace:
fips.c(152): OpenSSL internal error, assertion failed: FATAL FIPS SELFTEST FAILURE

Program received signal SIGABRT, Aborted.
0x00002aaaabf6cfc5 in raise () from /lib64/libc.so.6
(gdb) backtrace
#0  0x00002aaaabf6cfc5 in raise () from /lib64/libc.so.6
#1  0x00002aaaabf6ea70 in abort () from /lib64/libc.so.6
#2  0x00002aaaafb9714f in OpenSSLDie () from /usr/lib64/libcrypto.so
#3  0x00002aaaafb99d91 in EVP_DigestUpdate () from /usr/lib64/libcrypto.so
#4  0x00002aaaafb9c898 in ?? () from /usr/lib64/libcrypto.so
#5  0x00002aaaafb9dba1 in RAND_poll () from /usr/lib64/libcrypto.so
#6  0x00002aaaafb9c64b in ?? () from /usr/lib64/libcrypto.so
#7  0x0000000001b9b57f in QSslSocketPrivate::ensureLibraryLoaded () at ssl/qsslsocket_openssl.cpp:543
#8  0x0000000001b9b679 in QSslSocketPrivate::supportsSsl () at ssl/qsslsocket_openssl.cpp:521
#9  0x0000000001b940a9 in QSslSocket::supportsSsl () at ssl/qsslsocket.cpp:1598
#10 0x0000000000427d85 in main (argc=1, argv=0x7fffffffe858, envp=0x7fffffffe868) at main.cpp:110

Work Around:
Need to prevent from running  q_RAND_status(),
// Initialize OpenSSL's random seed.
        if (!q_RAND_status()) {

just return true before any of that.....
Dont know what ramifications are to this, but it runs and works after this change.
diff --git a/src/qt/src/network/ssl/qsslsocket_openssl.cpp b/src/qt/src/network/ssl/qsslsocket_openssl.cpp
index b7ca290..e0a5a3f 100644
--- a/src/qt/src/network/ssl/qsslsocket_openssl.cpp
+++ b/src/qt/src/network/ssl/qsslsocket_openssl.cpp
@@ -523,6 +523,7 @@ bool QSslSocketPrivate::supportsSsl()

 bool QSslSocketPrivate::ensureLibraryLoaded()
 {
+    return true;
     if (!q_resolveOpenSslSymbols())
         return false;

Rebuilt from source after this. Worked fine.
Mini-dump:
Operating system: Linux
                  0.0.0 Linux 2.6.18-400.1.1.el5 #1 SMP Sun Dec 14 06:01:17 EST 2014 x86_64
CPU: amd64
     family 6 model 37 stepping 1
     24 CPUs

Crash reason:  SIGABRT
Crash address: 0x2b8006e2000076cc

Thread 0 (crashed)
 0  libc-2.5.so + 0x2ffc5
    rbx = 0x00007fff2b238850   r12 = 0x00007fff2b238950
    r13 = 0x00007fff2b238980   r14 = 0x00002b2f6a9816a0
    r15 = 0x00007fff2b238950   rip = 0x00002b2f66adcfc5
    rsp = 0x00007fff2b2387a8   rbp = 0x00002b2f6702ae90
    Found by: given as instruction pointer in context
 1  libc-2.5.so + 0x31a6f
    rip = 0x00002b2f66adea70   rsp = 0x00007fff2b2387b0
    Found by: stack scanning
 2  libc-2.5.so + 0x35385f
    rip = 0x00002b2f66e00860   rsp = 0x00007fff2b2387c0
    Found by: stack scanning
 3  libc-2.5.so + 0xe88c6
    rip = 0x00002b2f66b958c7   rsp = 0x00007fff2b2387f0
    Found by: stack scanning
 4  libc-2.5.so + 0x67d7
    rip = 0x00002b2f66ab37d8   rsp = 0x00007fff2b238808
    Found by: stack scanning
 5  libcrypto.so.0.9.8e + 0xd614e
    rip = 0x00002b2f6a70714f   rsp = 0x00007fff2b2388f0
    Found by: stack scanning
 6  libcrypto.so.0.9.8e + 0xd8d90
    rip = 0x00002b2f6a709d91   rsp = 0x00007fff2b238900
    Found by: stack scanning
 7  libcrypto.so.0.9.8e + 0xdb897
    rip = 0x00002b2f6a70c898   rsp = 0x00007fff2b238920
    Found by: stack scanning
 8  libcrypto.so.0.9.8e + 0x32fd9f
    rip = 0x00002b2f6a960da0   rsp = 0x00007fff2b238958
    Found by: stack scanning
 9  libcrypto.so.0.9.8e + 0xdcba0
    rip = 0x00002b2f6a70dba1   rsp = 0x00007fff2b2389e0
    Found by: stack scanning
10  libcrypto.so.0.9.8e + 0x3308a7
    rip = 0x00002b2f6a9618a8   rsp = 0x00007fff2b238a10
    Found by: stack scanning

Loaded modules:
0x00400000 - 0x0268dfff  phantomjs-linux  ???  (main)
0x2b2f6561b000 - 0x2b2f65636fff  ld-2.5.so  ???
0x2b2f65839000 - 0x2b2f65abcfff  libfreetype.so.6.3.10  ???
0x2b2f65abd000 - 0x2b2f65ceffff  libfontconfig.so.1.1.0  ???
0x2b2f65cf1000 - 0x2b2f65ef4fff  libdl-2.5.so  ???
0x2b2f65ef6000 - 0x2b2f660fefff  librt-2.5.so  ???
0x2b2f660ff000 - 0x2b2f66316fff  libpthread-2.5.so  ???
0x2b2f6631b000 - 0x2b2f66608fff  libstdc++.so.6.0.8  ???
0x2b2f6661c000 - 0x2b2f6689efff  libm-2.5.so  ???
0x2b2f6689f000 - 0x2b2f66aacfff  libgcc_s-4.1.2-20080825.so.1  ???
0x2b2f66aad000 - 0x2b2f66e00fff  libc-2.5.so  ???
0x2b2f66e07000 - 0x2b2f67029fff  libexpat.so.0.5.0  ???
0x2b2f6702c000 - 0x2b2f6a5f7fff  locale-archive  ???
0x2b2f6a5f8000 - 0x2b2f6a5fefff  beeeeb3dfe132a8a0633a017c99ce0c0-x86-64.cache-2  ???
0x2b2f6a5ff000 - 0x2b2f6a609fff  e19de935dec46bbf3ed114ee4965548a-x86-64.cache-2  ???
0x2b2f6a60a000 - 0x2b2f6a60cfff  e3ead4b767b8819993a6fa3ae306afa9-x86-64.cache-2  ???
0x2b2f6a60d000 - 0x2b2f6a610fff  b67b32625a2bb51b023d3814a918f351-x86-64.cache-2  ???
0x2b2f6a611000 - 0x2b2f6a618fff  b79f3aaa7d385a141ab53ec885cc22a8-x86-64.cache-2  ???
0x2b2f6a619000 - 0x2b2f6a61afff  87f5e051180a7a75f16eb6fe7dbd3749-x86-64.cache-2  ???
0x2b2f6a631000 - 0x2b2f6a97dfff  libcrypto.so.0.9.8e  ???
0x2b2f6a982000 - 0x2b2f6ab95fff  libz.so.1.2.3  ???
0x2b2f6ab96000 - 0x2b2f6ade3fff  libssl.so.0.9.8e  ???
0x2b2f6ade4000 - 0x2b2f6b011fff  libgssapi_krb5.so.2.2  ???
0x2b2f6b012000 - 0x2b2f6b2a6fff  libkrb5.so.3.3  ???
0x2b2f6b2a7000 - 0x2b2f6b4a8fff  libcom_err.so.2.1  ???
0x2b2f6b4a9000 - 0x2b2f6b6cdfff  libk5crypto.so.3.1  ???
0x2b2f6b6ce000 - 0x2b2f6b8d5fff  libkrb5support.so.0.1  ???
0x2b2f6b8d6000 - 0x2b2f6bad7fff  libkeyutils-1.2.so  ???
0x2b2f6bad8000 - 0x2b2f6bceafff  libresolv-2.5.so  ???
0x2b2f6bced000 - 0x2b2f6bf03fff  libselinux.so.1  ???
0x2b2f6bf05000 - 0x2b2f6c140fff  libsepol.so.1  ???
0x7fff2b3bd000 - 0x7fff2b3bffff  linux-gate.so  ???

Please upgrade to PhantomJS 2.0. 1.9.x is no longer supported, and known to have many crasher bugs that are fixed in 2.0.


Handle error about file size, when file does not exists

Error: Unable to retrieve the file_size for file at location: .

Hi @ExsyDev
Can you please elaborate on this issue ? or give a minimal setup to reproduce this ?
The entity checks for the existence of the file in the file system before attempting to retrieve any metadata relating to it.
Thanks

Hi @ExsyDev
Can you please elaborate on this issue ? or give a minimal setup to reproduce this ? The entity checks for the existence of the file in the file system before attempting to retrieve any metadata relating to it. Thanks

When file already uplodaed, and after removed, then we can see this error on index page of resource.

Please, would you be able to provide a minimum set up to reproduce this ?
Currently we check if the file exists before doing any operations at https://github.com/oneduo/nova-file-manager/pull/175/files#diff-72f4fd3cf2a3b01ecb2cf2ca503f9333c70a64a761cdf900f101787c2df426a0R49
If the file was deleted outside of the tool, we show an error stating the file was deleted.


Publishing to self_topic_root/reload no longer works

Describe the Bug
I added a new sensor today, and after modifying sensors.yaml to change the name and device class, tried publishing to wyzesense2mqtt/reload... But that just makes the container stop working. During this process, I was tailing the container log (docker logs -f wyzesense2mqtt), and nothing happened after the reload message was received, including any further state updates from the sensors. Restarting the container restored regular behavior.
Steps To Reproduce
Steps to reproduce the behavior:

Publish a message to self_topic_root/reload

Expected Behavior
Publishing a reload message should... reload the sensors 😅
Additional Context
The last bit of my log, and then nothing happened after this:
Sending PUBLISH (d0, q2, r1, m12685), 'b'wyzesense2mqtt/77C006C8'', ... (239 bytes)
Received PUBREC (Mid: 12685)
Sending PUBREL (Mid: 12685)
Received PUBCOMP (Mid: 12685)
State event data: [2021-09-20 17:15:40][77C00CE1]AlarmEvent: sensor_type=motionv2, state=active, battery=98, signal=72
{'event': 'alarm', 'available': True, 'mac': '77C00CE1', 'device_class': 'motion', 'last_seen':<PHONE_NUMBER>.093, 'last_seen_iso': '2021-09-20T17:15:40.093000', 'signal_strength': -72, 'battery': 98, 'name': 'Back Porch Motion', 'state': 1}
Sending PUBLISH (d0, q2, r1, m12686), 'b'wyzesense2mqtt/77C00CE1'', ... (238 bytes)
Received PUBREC (Mid: 12686)
Sending PUBREL (Mid: 12686)
Received PUBCOMP (Mid: 12686)
Received PUBLISH (d0, q0, r0, m0), 'wyzesense2mqtt/reload', ...  (0 bytes)
In on_message_reload:
Reading sensors configuration...

@drinfernoo Can you check to ensure the formatting on your sensors.yaml file is correct? Though I would expect this to print an error...hmm.
Try adding the following before 181
if (SENSORS is None):
        LOGGER.error(f"Failed to load sensors.yaml.")

Adding those lines, and then publishing to wyzesense2mqtt/reload... allowed the reload to work. Maybe the issue I was experiencing was a fluke, but it seemed like it would happen every time 🤔
Those lines shouldn't have affected the behavior of the script, from what I can tell... though there are a few lines lower that might fail if SENSORS is None:
https://github.com/raetha/wyzesense2mqtt/blob/944f9165a5346352ddd8300ca87a8ba68be42f4d/wyzesense2mqtt/wyzesense2mqtt.py#L181
https://github.com/raetha/wyzesense2mqtt/blob/944f9165a5346352ddd8300ca87a8ba68be42f4d/wyzesense2mqtt/wyzesense2mqtt.py#L206
But as you mentioned, I would think these would give an error.
My sensors.yaml is definitely formatted correctly... or none of my sensors would work at all 😉

I still have this odd behavior... wondering what we can do to fix this 🤔


Fluid Entity Imports not working

I have cloned the project, imported into IntelliJ IDEA 2019.1.
The project syncs correctly, but the imports for fluid entity aren't working and show as can't resolve symbol?
import com.artemis.E;
import com.artemis.FluidIteratingSystem;
Java 1.8
I haven't changed anything in the project.

The maven plugin generates the files you need. IntelliJ won't trigger the plugin by itself. Workaround is running maven compile on core module from the IntelliJ maven panel whenever you change component classes. IntellIJ should pick up the generated files immediately without having to reimport.

Thank you, all working now


typo: Lenght -> Length

:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/mr-azure-312.md
:warning:Warning
View
Details

mixed-reality-docs/mr-azure-312.md

Line 47: [Warning] Illegal link: Windows 10 Fall Creators Update (or later) with Developer mode enabled -- missing bookmark. The file install-the-tools.md doesn't contain a bookmark named installation-checklist-for-immersive-headsets.
Line 48: [Warning] Illegal link: The latest Windows 10 SDK -- missing bookmark. The file install-the-tools.md doesn't contain a bookmark named installation-checklist-for-immersive-headsets.
Line 49: [Warning] Illegal link: Unity 2017.4 -- missing bookmark. The file install-the-tools.md doesn't contain a bookmark named installation-checklist-for-immersive-headsets.
Line 50: [Warning] Illegal link: Visual Studio 2017 -- missing bookmark. The file install-the-tools.md doesn't contain a bookmark named installation-checklist-for-immersive-headsets.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks for all your contributions @nschonni!


Add string to exe for testing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 72.84%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
212

Relevant Lines:
291

💛  - Coveralls


lr_finder documentation

📚 Documentation
It seems to me that the documentation of the lr_finder is ambiguous. It states

It is recommended to not pick the learning rate that achieves the lowest loss, but instead something in the middle of the sharpest downward slope (red point).

However, in the image the red dot is not on the sharpest slope. The sharpest slope is between 10^-2 and 10^-1.
So either this is a mistake (or ambiguity) in the documentation, or the implementation picks the lr based on the wrong slope. (In my own work I have found that the lr_finder underestimates the best lr value.)
cc @borda

it specifies the sharpest downward slope.. so looks correct to me.

The sharpest slope is between 10^-2 and 10^-1.

this is the sharpest upward slope.

 :-)


weave attach --rewrite-hosts sporadically fails

There seems to be some race condition with the the implementation of weave attach --rewrite-hosts in the following system configuration:

Ubuntu xenial Linux 4.4
Weave 1.7.2
Docker 1.12 (both Ubuntu docker.io=1.12.1-0ubuntu13~16.04.1 and upstream docker-engine=1.12.2-0~xenial)

Storage Driver: overlay

The weave attach --rewrite-hosts operation will sometimes succeed, and sometimes fail with an error:
Error response from daemon: Driver overlay failed to remove root filesystem cc8482b244b5066b1d42f3a4e7a4352abba5bb79f431a2620806b993934f8938: remove /var/lib/docker/overlay/ea588807154a1a3b04c5ff3db248f9055695fca5fe21df8341e40b11104fff90/merged/sbin: directory not empty

This causes the container to remain detached from weave (no ethwe interface), and leaves large numbers of dead weaveexec containers in docker ps -a.
This happens fairly consistently for me on a three-node cluster of DigitalIOcean nodes using their ubuntu-16-04-x64 image, leaving the majority of containers detached.
More detailed debugging shows that this errors happens in rewrite_etc_hosts():
+ docker run --rm --net=none -e WEAVE_CIDR=none --privileged -v /var/lib/docker/containers/2b39aafa954c370e4f950cac2ed4114197809d77c254570bcebf10281736dc05:/container --entrypoint=sh weaveworks/weaveexec:1.7.2 -c echo '# created by Weave - BEGIN ... > /container/hosts && rm -f /container/hosts && echo '# created by Weave - BEGIN ... END' > /container/hosts
time="2016-10-25T13:46:50Z" level=fatal msg="Error response from daemon: Driver overlay failed to remove root filesystem e58b019d3e9bd44580e01607422cff527275621243046e25263844117ef90522: remove /var/lib/docker/overlay/96cf34987cc5b1c9d07de939c33726d7364f4e0927a5d9a51083349b5e81f02b/merged/sbin: directory not empty"

It's not exactly the same error, but this may be related to sharing mounts between namespaces: https://github.com/docker/docker/issues/26372

This error is returned from the kernel when trying to remove container rw layers and/or the container config root... typically due to mounts leaked into other namespaces.

BTW it seems like the --rewrite-hosts is not the only case that's failing with this error, even the top-level weaveexec container that we're running is failing with that error when deleting it via the Docker API:
Oct 26 11:36:17 terom-xenial-node3 docker[4970]: Docker::Error::ServerError: Driver overlay failed to remove root filesystem 8a39ea400ec0b919edda8e3786097a5b257569f07c0ae57aaac672072cbc763b: remove /var/lib/docker/overlay/55fbeb6a0a0845fffed1d4fb380f5f417c63a779fd6d4f9b9c0a064927288348/merged/sbin: directory not empty
Oct 26 11:36:17 terom-xenial-node3 docker[4970]:         /usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/connection.rb:50:in `rescue in request'
Oct 26 11:36:17 terom-xenial-node3 docker[4970]:         /usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/connection.rb:38:in `request'
Oct 26 11:36:17 terom-xenial-node3 docker[4970]:         /usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/connection.rb:65:in `block (2 levels) in <class:Connection>'
Oct 26 11:36:17 terom-xenial-node3 docker[4970]:         /usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/container.rb:213:in `remove'
Oct 26 11:36:17 terom-xenial-node3 docker[4970]:         /app/lib/kontena/network_adapters/weave.rb:191:in `exec'
Oct 26 11:36:17 terom-xenial-node3 docker[4970]:         /app/lib/kontena/network_adapters/weave.rb:244:in `connect_peers'
Oct 26 11:36:17 terom-xenial-node3 docker[4970]:         /app/lib/kontena/network_adapters/weave.rb:232:in `start'

This error happens when using the DELETE /containers/... API - adding in ?force=1 silences it, but leaves the dead Docker container/overlayfs mounts hanging around on the system.
Not entirely sure how the Docker Engine implementation works, but looking at the overlayfs mount point in question after the fact looks weird:
$ ls -la /var/lib/docker/overlay/55fbeb6a0a0845fffed1d4fb380f5f417c63a779fd6d4f9b9c0a064927288348/merged/
total 0
$ ls -la /var/lib/docker/overlay/55fbeb6a0a0845fffed1d4fb380f5f417c63a779fd6d4f9b9c0a064927288348/merged/sbin
total 2424
drwxr-xr-x  2 root root   4096 Oct 24 12:07 .
drwxr-xr-x  1 root root      0 Oct 26 11:36 ..
lrwxrwxrwx  1 root root     12 Sep 22 23:30 acpid -> /bin/busybox
lrwxrwxrwx  1 root root     12 Sep 22 23:30 adjtimex -> /bin/busybox
-rwxr-xr-x  7 root root  43872 Jun 17 16:40 agetty
-rwxr-xr-x 15 root root 202240 May 27 09:25 apk
lrwxrwxrwx  1 root root     12 Sep 22 23:30 arp -> /bin/busybox
...

The sbin subdir in question is missing from the the top-level mountpoint?

@SpComb thanks!

Original report via Slack: https://weaveworks.slack.com/archives/weave-users/p1477404926002570

This has also started to happen recently on my CoreOS Beta 1235.2.0 vagrant node, when using the default Docker overlayfs volume driver.

@SpComb I tried to replicate your symptoms: I created a CoreOS 1235.2.0 node via Vagrant, and then ran a bunch of containers attached to Weave Net, using both weave run and the Weave Proxy.  I did not observe any errors.
Any ideas how I can get closer to the set-up you are using?

Did you specifically test with attach --rewrite-hosts? I need that flag to repro this, it doesn't happen without it.
Other than that I'm not at all sure. It happens fairly consistently (30-50%) on those nodes where it does happen, but it doesn't happen on all nodes. It must be some Docker overlayfs driver that is specifically tickled by how weave's --rewrite-hosts is implemented.
I'll try wiping out /var/lib/docker and see if it continues.

Did you specifically test with attach --rewrite-hosts?

That is what the Proxy does by default.  However I went back and ran a bunch of those too, and did not observe any error messages.

I'm not sure yet how, but somehow it seems that cAdvisor messes things up and causes weave attach also to fail. If I run plain weave on CoreOS 1235.2.0 everything seems to work ok. But when I start cAdvisor, things get messed up like @SpComb has reported. (I'm also from team Kontena :))
docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v /:/host --net host --pid host --privileged weaveworks/weaveexec:1.7.2 launch-router --ipalloc-range '' --password foobar

docker run -d --name redis redis

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v /:/host --net host --pid host --privileged weaveworks/weaveexec:1.7.2 attach <IP_ADDRESS>/16 --rewrite-hosts 1757647bf879

Everything works as expected.
But now when I launch cAdvisor using:
docker run -d -v /:/host:rw --net host --pid host --privileged --name cadvisor kontena/cadvisor:0.23.2 --docker_only --listen_ip=<IP_ADDRESS> --port=8989 --storage_duration=2m --housekeeping_interval=30s

And after that run the attach again:
docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v /:/host --net host --pid host --privileged weaveworks/weaveexec:1.7.2 attach <IP_ADDRESS>/16 --rewrite-hosts 1757647bf879
time="2016-12-16T09:13:32Z" level=fatal msg="Error response from daemon: Driver overlay failed to remove root filesystem 5af457e9a86b3f14a20aec4627a2f140d669ca1c2fd20b54300c3802a702a247: remove /var/lib/docker/overlay/0e101f21de8757d705dd68b8549a0f83a49eb8b180a32a37345833292deb3d9d/merged/media: directory not empty"

I get this pretty much 100% on attach now.
If I run the attach without --rewrite-hosts everything works as expected.
Any idea why and how cAdvisor messes this up?

My sense is it has to do with recursive mounts - all the Docker files are under /var/lib/docker/containers, so when you bind-mount / under there the kernel gets confused.
See some previous investigations (with different symptoms, but all involving cAdvisor)

@SpComb Was cAdvisor running when you experienced the problem?
@SpComb / @jnummelin Once you have experienced it again, could you run sudo lsof $TROUBLE_PATH from the host as it is described here?

@SpComb Was cAdvisor running when you experienced the problem?

Yes, it was. I should have already known better to include cAdvisor in this issue when reporting it, it's related to all of these mountns shenanigans.

@brb
core@jussi-weave-test ~ $ docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v /:/host --net host --pid host --privileged weaveworks/weaveexec:1.7.2 attach <IP_ADDRESS>/16 --rewrite-hosts 1757647bf879
time="2016-12-19T09:53:18Z" level=fatal msg="Error response from daemon: Driver overlay failed to remove root filesystem 0f87393df1875a6221c52320784d13316abb6967697c9b2b7df3a3ac30dcc006: remove /var/lib/docker/overlay/f2670ec17ce1cbaed1f4f783d9fd725005c713a7c5fd924729fb6a68dfcdd1f6/merged/media: directory not empty"
core@jussi-weave-test ~ $ sudo lsof /var/lib/docker/overlay/f2670ec17ce1cbaed1f4f783d9fd725005c713a7c5fd924729fb6a68dfcdd1f6/merged/media
core@jussi-weave-test ~ $  sudo ls -lah /var/lib/docker/overlay/f2670ec17ce1cbaed1f4f783d9fd725005c713a7c5fd924729fb6a68dfcdd1f6/merged/media
total 40K
drwxr-xr-x. 5 root root 4.0K Dec 16 08:51 .
drwxr-xr-x. 1 root root    0 Dec 19 09:53 ..
drwxr-xr-x. 2 root root 4.0K Sep 22 23:30 cdrom
drwxr-xr-x. 2 root root 4.0K Sep 22 23:30 floppy
drwxr-xr-x. 2 root root 4.0K Sep 22 23:30 usb

lsof doesn't report anything to be hanging on that path but it's really not empty either. :/
If you want to debug further, it's really easy to reproduce with the steps in my previous comment. Or I can do some further digging also if needed.

I'm closing this.
If you still experience the problem, please re-open it. Thanks.


Already exported a member named 'Activity'. Consider explicitly re-exporting to resolve the ambiguity.

Hi, when I run my bot (typescript) I get this error from your package:
node_modules/oceanic.js/dist/lib/types/index.d.ts:9:1 - error TS2308: Module "./gateway" has already exported a member named 'Activity'. Consider explicitly re-exporting to resolve the ambiguity.

9 export * from "./guilds";
  ~~~~~~~~~~~~~~~~~~~~~~~~~

Found 1 error in node_modules/oceanic.js/dist/lib/types/index.d.ts:9

That's been patched (https://github.com/OceanicJS/Oceanic/commit/c1c435f6d55559fdfaa0da2f3bd665ad9fc29120)
However this has not been released yet, so you might have to use the dev branch if you need it now, or wait for Donovan to release the next version.


Checkpoints on the Hugging Face Hub?

Hey @abb128 - congrats on this great project. It was super interesting reading how you tackled the problem of a fixed context length for Whisper!
I'm very excited to try the model in the Transformers library. However, I noticed that neither the Whisper cpp nor Transformers weights are not published on the Hugging Face Hub. Would you be open to pushing your weights to the Hugging Face Hub, in order to:

Increase the visibility of your work through a Hub presence
Reduce the barrier of entry to using your checkpoints, by enabling anyone in the community to load your model with two lines of code:

from transformers import WhisperForConditionalGeneration

model = WhisperForConditionalGeneration.from_pretrained("your-username/your-model-name")

It's super easy to push the Transformers weights to the Hub with one line of code:
from transformers import WhisperForConditionalGeneration

model = WhisperForConditionalGeneration.from_pretrained("./local/path/to/checkpoint")
model.push_to_hub("your-model-name")

For the Whisper cpp weights, you can follow this guide. You can also then draft a pretty model card that explains how to use the model, e.g. in the style of distil-large-v3.

We've uploaded checkpoints to our HF: https://huggingface.co/futo-org


Change translational dither frequency

Based on conversations at the Project & Community Workshop 2018, it was agreed that we'd like to not dither in between visits to the same field in the same night for better calibrations. This calls for less frequent translational dithers than per visit, as are currently implemented as descDithers. Rotational dithers frequency (after every filter change) is okay for now.
In an attempt to address this, the translational dithers need to be changed to perNight dithers. #3, #5

@rbiswas4 yes, you're right. We dont have to dither only once per night but very rarely does a field get visited more than twice in a given night. Also, per night translational dithers would bring an added benefit of being more comparable to altSched which changes its HEALPix gridding every night.
For LSS systematics, more frequent dithers are the best but there's merit to not dithering in between pairs and there isn't much gain in varying dithers during the night (we looked at two variant of nightly dithers in our paper: perNight and FieldPerNight which lead to comparable effectiveness).

@humnaawan Great ... so one translational dither per night at the same point is an efficient implementation keeping everyone happy.
In terms of rotational dithers, I thought we had agreed that things would not change within a pair of visits. But if they change after a filter change this could happen. That is the other thing I was worried about.

Right, we'd ideally want to not do rotational dithers in the between pairs either but that'd require a bit of work, especially since there has been only one implementation of rotational dithers.
Since rotational dithers are still largely under investigation, I am unsure of whether the overhead of implementing a "clever" rotational dither strategy is justified right now, especially since even for the one implementation that we have right now,  we do not have any quantitative study of the effectiveness of the dithers. I am interested in exploring this but have a few things that have priority.
@egawiser thoughts? I am not sure who else I should be tagging.

I think the issue of rotational dithering is more complicated, because asking visit pairs to be observed at the same orientation is actually a request for a rotational dither, although often modest, to be performed to make that happen.  But I agree that this will be what is desired for visit pairs, and since we're pushing for visit pairs to occur in different filters, making large rotational dithers at each filter change no longer sounds like a great approach.  For a quick improvement, we could try adopting a single random rotational position (RotTelPos) at the beginning of each night and reverting to it after each filter change that night and investigate if that produces sufficiently uniform distributions of the two rotation angles for Weak Lensing systematics to be reduced acceptably.  But when there's time to put some real thought into this, it would be great to try to code up a requirement that the 2nd observation of a field in a filter that night be performed at the same RotSkyPos value as the 1st one (that's what we want to cover the same regions of the field on the same chips, and that will automatically create some variation in RotTelPos, so it's only RotSkyPos whose distribution might become less uniform this way).


Investigate memory, performance and bundle size impact when caching basic schema objects

This is related to the following conversation with @sebmck on X: https://twitter.com/sebmck/status/1787193342876418218
Here is a code example: https://gist.github.com/sebmck/26ade0d73de7daee729a0848d5d2c41f

I have done some preliminary research. Caching schema objects probably improves memory usage, but also reduces the performance of creating a schema object. A simple first benchmark showed that creating a schema object with a simple caching strategy reduces the runtime performance by more than 2x and with a more advanced caching strategy using a Map reduces the runtime performance by more than 10x. Frankly, it is not clear to me why a simple caching strategy is not faster. Since caching also increases the bundle size of a schema, it is not clear if it is worth it. I mark this issue as "wontfix" for now, but further investigation is needed for a final conclusion. Feel free to do some benchmarks of your own if you are reading this and share your results.


More otel metrics

"interaction" counter, by projectId
"request" counter, by projectId
"requestInteractions" gauge, by projectId

Repository interaction metrics were added in #5474


Revert window ignore → closes #369

Reverts https://github.com/stevearc/aerial.nvim/commit/51a07949abf169b4cad30e14c165ac1ec0ce4e6f
Closes: #369

This means that the behavior would go back to not opening Aerial at all if you toggle it in the Neotree buffer. Is that a better situation than this one?
Another thing to look into: if you want aerial to stick to the right edge of your editor, you can set the options
require("aerial").setup({
  layout = {
    default_direction = "right",
    placement = "edge",
  }
})

Would that solve your issue?

@stevearc That solution works fine steve thank you:
How I've tested

I've added your options as

      layout = {
        min_width = 28,
        default_direction = "right",
        placement = "edge",
      },

Happy day scenario
I've focused neotree and opened aerial

It opens in the correct position, and once I click the code, aerial is populated correctly

Bad day scenario
It is still possible to fuck the UI when performing obscure actions such as

Open aerial
Open neotree (the cursor is on neotree now)
Then try to open aerial again → That spawns a second aerial, instead of toggling the current one.

This is already better, but maybe I would still revert, or check that out. Up to you.

If I repeat that I can spawn infinite aerials

@Zeioth Try setting the attach_mode as well
require("aerial").setup({
  layout = {
    default_direction = "right",
    placement = "edge",
  },
  attach_mode = "global"
})

I had it already. Full config:
{
    "stevearc/aerial.nvim",
    event = "VeryLazy",
    opts = {
      ignore = {
        buftypes = { "nofile" },
      },
      filter_kind = { -- Symbols that will appear on the tree
        -- "Class",
        "Constructor",
        "Enum",
        "Function",
        "Interface",
        -- "Module",
        "Method",
        -- "Struct",
      },
      open_automatic = false, -- Open if the buffer is compatible
      autojump = true,
      link_folds_to_tree = false,
      link_tree_to_folds = false,
      attach_mode = "global",
      backends = { "lsp", "treesitter", "markdown", "man" },
      disable_max_lines = vim.g.big_file.lines,
      disable_max_size = vim.g.big_file.size,
      layout = {
        min_width = 28,
        default_direction = "right",
        placement = "edge",
      },
      show_guides = true,
      guides = {
        mid_item = "├ ",
        last_item = "└ ",
        nested_top = "│ ",
        whitespace = "  ",
      },
      keymaps = {
        ["[y"] = "actions.prev",
        ["]y"] = "actions.next",
        ["[Y"] = "actions.prev_up",
        ["]Y"] = "actions.next_up",
        ["{"] = false,
        ["}"] = false,
        ["[["] = false,
        ["]]"] = false,
      },
    },
    config = function(_, opts)
      require("aerial").setup(opts)
      -- HACK: The first time you opened aerial on a session, close all folds.
      vim.api.nvim_create_autocmd("FileType", {
        desc = "Aerial: The first time its open on a session, close all folds.",
        callback = function()
          local is_aerial = vim.bo.filetype == "aerial"
          local is_ufo_available = require("base.utils").is_available("nvim-ufo")
          if is_ufo_available and is_aerial and vim.g.new_aerial_session == nil then
            vim.g.new_aerial_session = false
            require("aerial").tree_set_collapse_level(0, 0)
          end
        end,
      })
    end
  },

@Zeioth I believe I've fixed the issue with multiple aerial windows opening when attach_mode = "global". I think this was the last bug in this scenario, so I'm closing this PR (it seems unlikely that we would want to revert this change anyway). If there are still problems, feel free to continue the discussion on the linked issue or create a new issue


What are you wondering about?

Great project, we are very interesting in using it.  What are the best practices for distributing the public key to end users so they can verify your images?  Thank you!

There's no simple answer here! That's the hard part of signatures :) It comes down to your exact threat model and where your users are. Fulcio-based keyless signatures simplify this because you don't have to worry about key management, you can just tell your users which email addresses should be used.


Admin tool: Change entry authorship

Change authorship of an entry (eg. someone incorrectly enters a case as a method, I re-enter the method as a case, I then change the author on the case from me to the original submitter)
Per #672

@scottofletcher you just need to be able to edit the original author, right? not the author of the most recent changes? Working on the UI for this tool now.

Also, do you need to be able to edit authorship for each version when we implement versioning? Thx!

@jesicarson ideally we'd be able to edit the original author, the date of submission, the date of most recent changes, and the author of those changes. if you can only do the first two for now, that's fine but we'll need the other two down the road. As far as versioning goes, I don't forsee a need to edit the authorship/date of an individual version unless, that is, we make it possible to have multiple authors credited for submitting and changing a case. In that instance, I could see someone like Julien requesting some versions be attributed to both him and his student or RA. I'm also thinking about versioning as it relates to translations - is the original author of, say, an English version, automatically become the original author of the automated translation(s)?

oh another question: when we implement versioning it's just going to show the xyz history, right? Like if a case was edited ten times by ten different people between 2011 and 2017 on .net, that's going to get wiped out, right? the only versions to display on xyz will be the original submission and recent edits (probably by me, lucy, or ethan) on xyz?

That’s correct.

Functional and visual options for review.

admins see an "edit authorship" button in the form, which they have to click to reveal fields, ie:

after edit authorship is clicked, admins see a publish button specifically for authorship info, ie:
A.

B.
C.

fields are automatically included as part of the form for admins (no edit authorship button needed)
authorship changes publish along with any other form changes using the regular publish buttons (no extra publish button needed)

Leaning towards 3 & 4, with visual option B or C (without extra buttons).

@jesicarson I like 1&2 - I'm afraid of changing things that don't need to be changed so having that separate step of clicking 'Edit Authorship' is nice.

@jesicarson I'd be fine if it published when the case is published - ie. I would be on the reader view, click edit, be able to edit the author/date only if I then click 'edit authorship', continue to fill out any of the other fields needing editing, and then hit publish at the bottom of the page
One small change: can we move away from the words 'authorship'? Sorry, I know it doesn't seem important but I think we really need to shift our mentality away from the ownership that comes with the word 'author' (and it's impossible to do so if our rhetoric keeps enforcing it).
Could it be 'Edit Submission History' or 'Edit Submission Details'?

Ok makes sense, thanks Scott.

@dethe this is good to go. .ai file here if needed.
"Edit Submission Details" button visible to admins only.

Clicking "Edit Submission Details" turns the first submitted by author and date into fields.

This design may need to be updated because admins will also access "edit form text" and "translate form text" directly via forms (so can access when quick subbing a new article, AND when editing existing articles).
Description: 3 buttons OR 1 drop down menu (ie: “admin options” drop down) will appear on forms show up for admins, including - 1) “edit submission details” (on previously published articles, but not new articles), 2) “edit form text” and 3) “translate/localize form text”. And, when the admin selects edit/translate form text, the “warning not published” message should pop up with the option to publish and continue to edit/translate the form or cancel and return to editing the article.

Updated design - drop down instead of single button (see #900)


Unable to retrieve image details or access container console after update of Docker to v27.1.1

Before you start please confirm the following.

[X] Yes, I've searched similar issues on GitHub.
[X] Yes, I've checked whether this issue is covered in the Portainer documentation or knowledge base.

Problem Description
Inability to see image information and to use container consoles.
Expected Behavior
Image info is accessible and container consoles are functional.
Actual Behavior
Clicking on an image causes the error message "Error Unable to retrieve image details" and clicking on container consoles also produce this same error.
Steps to Reproduce

SSH into host server
apt update && apt upgrade
(Update updates docker-ce alongside any dependencies)

Portainer logs or screenshots
No response
Portainer version
2.19.5
Portainer Edition
Community Edition (CE)
Platform and Version
Docker 27.1.1
OS and Architecture
Ubuntu 22.04
Browser
No response
What command did you use to deploy Portainer?
  default:
  proxy:
    name: proxy
    ipam:
      driver: default
      config:
        - subnet: <IP_ADDRESS>/24

services:
  portainer:
    image: portainer/portainer-ce:latest
    container_name: Portainer
    env_file:
      - .env
    hostname: portainer
    restart: unless-stopped
    environment:
      - PUID=$PUID
      - PGID=$PGID
      - TZ=$TZ
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock:ro
      - ./config:/config
    ports:
      - 9000:9000
    networks:
      - proxy
    security_opt:
      - no-new-privileges:true
    logging:
      options:
        max-size: "10m"
        max-file: "5"
    labels:
      - "com.centurylinklabs.watchtower.enable=true"

Additional Information
Return of https://github.com/portainer/portainer/issues/11436?

Closed as duplicate of #11436 . As indicated in that thread, including at the top of the original post:

Portainer 2.20.3 has now been released, which includes a fix for these issues under Docker 26 and above. We recommend updating to 2.20.3 if you need to use Docker 26 or above.


multi-lingual support

As an end user,
I need the descriptions (metadata) for objects to display accurately no matter what language or script they are in,
so that important information about the objects isn't lost because it can't display properly.
[LB - I'm not sure from the issues list what was meant by multi-lingual support so I wrote it focusing on display, rather than searching.]

Closing, duplicate of #93.


Is it possible to disable the ViewPage while in zoom?

Hi, I would like to know if you can help me.
I have a ViewPager working with the PhotoView, but I would like to disable the ViewPager Scroll while the PhotoView is in the zoom mode.
Could you please show me the path?
Thanks in advance.

Even i have the same problem please help me @chrisbanes

Yes it is possible
You should make custom ViewPager and ovveride canScroll functions like this
`
class ImageViewerViewPager @JvmOverloads constructor(context: Context, attrs: AttributeSet? = null)
: IllegalArgumentExceptionInterceptorViewPager (context, attrs) {
/*
* if current image is zoomed then view pager doesn't make scroll
*  (but it seems strange for me that it return trues in this case)
* */
override fun canScroll(v: View, checkV: Boolean, dx: Int, x: Int, y: Int): Boolean {
    val currentView = findViewWithTag<PhotoView>(currentItem)
    return if (currentView.scale > currentView.minimumScale) {
        true
    } else {
        return super.canScroll(v, checkV, dx, x, y)
    }
}

}`


[Bug]:  Installing Telegram bot moonraker from Kiauh

What happened and in what context?
Error installing Telegram bot moonraker from Kiauh
If needed, paste the relevant bot log contents here.

If needed, paste the relevant bot journal contents here.
No response
What branch does this occur on?
master
Reports only on latest master or development branches!

[X] I have updated to latest development/master version before submitting the bug

I also encountered this bug last week, had to run the install.sh myself to finalize the install.


Fix many to many relationships to retrieve instances of the throughTarget

When retrieving a field using "many to many" relationship, it results into an array of target Model Instance.
However, it does not include attributes from the intermediary target.

In this case, the relationship may not fit well, it should be possible to:

retrieve an association of an association
define a condition on a reference:

var Photo = ziti.define('photo', {
    path: ziti.String,
    width: ziti.Int,
    height: ziti.Int,
    user: ziti.ForeignKey('User')
});

var User = ziti.define('User', {
    username: ziti.String,
    photos: [ Photo ]
});

User.at({ id: 42, photos: { width: 32, height: 32 } })
// SELECT * FROM `user` `User` LEFT JOIN `photo` `photos` ON `photos`.`user_id` = `User`.`id` AND `photos`.`width` = 32 AND `photos`.`height` = 32


Bugfix/i1435

Parameters of type gdb.Raw do not require special treatment.
see #1435

@danvinhe 有冲突请解决一下。

Codecov Report

Merging #1438 (f901f19) into master (5e7b0c9) will decrease coverage by 0.47%.
The diff coverage is 0.00%.

:exclamation: Current head f901f19 differs from pull request most recent head 12fe41e. Consider uploading reports for the commit 12fe41e to get more accurate results

@@            Coverage Diff             @@
##           master    #1438      +/-   ##
==========================================
- Coverage   69.75%   69.27%   -0.48%
==========================================
  Files         402      381      -21
  Lines       38842    37933     -909
==========================================
- Hits        27093    26277     -816
+ Misses      10006    10005       -1
+ Partials     1743     1651      -92

Flag
Coverage Δ

go-1.14
69.19% <0.00%> (-0.51%)
:arrow_down:

go-1.15
69.21% <0.00%> (-0.47%)
:arrow_down:

go-1.16
69.24% <0.00%> (-0.45%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

database/gdb/gdb_func.go
83.63% <0.00%> (-4.27%)
:arrow_down:

net/ghttp/ghttp_client.go
11.49% <0.00%> (-88.51%)
:arrow_down:

util/gutil/gutil_dump.go
41.17% <0.00%> (-47.03%)
:arrow_down:

container/gvar/gvar_struct.go
16.66% <0.00%> (-33.34%)
:arrow_down:

database/gredis/gredis_config.go
40.54% <0.00%> (-32.05%)
:arrow_down:

database/gdb/gdb_model_option.go
71.42% <0.00%> (-28.58%)
:arrow_down:

internal/structs/structs_field.go
39.47% <0.00%> (-18.07%)
:arrow_down:

net/ghttp/ghttp_server_config_mess.go
50.00% <0.00%> (-16.67%)
:arrow_down:

util/gconv/gconv_scan.go
74.54% <0.00%> (-13.15%)
:arrow_down:

os/gcmd/gcmd.go
73.58% <0.00%> (-12.69%)
:arrow_down:

... and 151 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e7b0c9...12fe41e. Read the comment docs.


Load user flags

Not sure about other builds, but the Fedora one does not load user flags provided in $HOME/.config/chromium-flags.conf.
I tried to use $XDG_CONFIG_HOME, but looks like the default environment does not set it.

The functionality you mentioned is Arch specific per https://wiki.archlinux.org/title/chromium#Making_flags_persistent. If you'd like to replicate that in the starter script here (which is from Fedora chromium package), please at least complete the logic used in foutrelis/chromium-launcher/blob/master/launcher.c.

It's better call it ungoogled-chromium than chromium to avoid confusion if someone also installed chromium I think, otherwise it looks good to me.

What do you think about moving the file to .config/ungoogled-chromium/ and name it flags.conf, like Vivaldi does?

Yeah that can also work, as there is no standard folder between distributions for now. Just in case, @networkException does arch version also use the launcher from arch's chromium package? Did you change the path for conf file?

Yep that also uses the launcher but I haven't changed the path, I guess keeping the "arch default" provides the best user experience when switching from normal to ungoogled

Interesting point. Then I will keep the name as chromium too to keep it consistent.


[BUG] ...

Describe the bug
The Total Monthly Goals on the Budget page is showing $0.00

To Reproduce
Steps to reproduce the behavior:

Go to budget's page
Click on nothing
Look to the right column
See error

Expected behavior
It should calculate my total budget goals per month
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: OSX
Browser: Chrome
Toolkit Version: idk?

Setting Export
Please replace the text below with your exported Toolkit settings. You can export these by going to the Toolkit Options page, click the Import/Export Settings button at the bottom left and copying the text in the modal which appears.
[{"key":"AccountsDisplayDensity","value":"0"},{"key":"AccountsEmphasizedOutflows","value":false},{"key":"AccountsStripedRows","value":false},{"key":"AutoDistributeSplits","value":false},{"key":"AutoEnableRunningBalance","value":true},{"key":"AutomaticallyMarkAsCleared","value":false},{"key":"BetterScrollbars","value":"0"},{"key":"BottomNotificationBar","value":false},{"key":"BudgetCategoryFeatures","value":true},{"key":"BudgetProgressBars","value":"0"},{"key":"BudgetQuickSwitch","value":false},{"key":"BudgetSpendingGoal","value":false},{"key":"BulkManagePayees","value":false},{"key":"CalendarFirstDay","value":"0"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"0"},{"key":"CategorySoloMode","value":"0"},{"key":"ChangeEnterBehavior","value":true},{"key":"ChangeMemoEnterBehavior","value":false},{"key":"CheckCreditBalances","value":false},{"key":"CheckNumbers","value":false},{"key":"ClearSelection","value":false},{"key":"CollapseSideMenu","value":false},{"key":"ColourBlindMode","value":false},{"key":"CompactIncomeVsExpense","value":true},{"key":"ConfirmKeyboardCancelationOfTransactionChanges","value":false},{"key":"CreditCardEmoji","value":false},{"key":"CurrentMonthIndicator","value":true},{"key":"CustomFlagNames","value":false},{"key":"DateOfMoney","value":false},{"key":"DaysOfBuffering","value":true},{"key":"DaysOfBufferingDate","value":false},{"key":"DaysOfBufferingHistoryLookup","value":"6"},{"key":"DeselectTransactionsOnSave","value":false},{"key":"DisableToolkit","value":false},{"key":"DisplayTargetGoalAmount","value":"3"},{"key":"DisplayTotalMonthlyGoals","value":true},{"key":"DisplayUpcomingAmount","value":false},{"key":"EasyTransactionApproval","value":false},{"key":"EditAccountButton","value":"0"},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"EnterToMove","value":false},{"key":"FilterCategories","value":true},{"key":"GoalIndicator","value":true},{"key":"GoalWarningColor","value":true},{"key":"GoogleFontsSelector","value":"0"},{"key":"HideAccountBalancesType","value":"0"},{"key":"HideAgeOfMoney","value":false},{"key":"HideClosedAccounts","value":false},{"key":"HideHelp","value":true},{"key":"HideReferralBanner","value":true},{"key":"HideTotalAvailable","value":false},{"key":"HighlightNegatives","value":false},{"key":"ImportNotification","value":"0"},{"key":"IncomeFromLastMonth","value":"0"},{"key":"IncomeVsExpenseHoverHighlight","value":true},{"key":"LargerClickableIcons","value":false},{"key":"LinkToInflows","value":false},{"key":"MonthlyNotesPopupWidth","value":"0"},{"key":"NavDisplayDensity","value":"0"},{"key":"NotesAsMarkdown","value":false},{"key":"POSStyleCurrencyEntryMode","value":false},{"key":"Pacing","value":"0"},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":"0"},{"key":"QuickBudgetWarning","value":false},{"key":"ReconciledTextColor","value":"0"},{"key":"RemovePositiveHighlight","value":false},{"key":"RemoveZeroCategories","value":false},{"key":"ResizeInspector","value":false},{"key":"ResizeSidebar","value":true},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"0"},{"key":"RowsHeight","value":"0"},{"key":"RunningBalance","value":"1"},{"key":"SeamlessBudgetHeader","value":false},{"key":"SetMultipleFlags","value":false},{"key":"ShowCategoryBalance","value":false},{"key":"SpareChange","value":false},{"key":"SplitTransactionAutoAdjust","value":false},{"key":"SquareNegativeMode","value":false},{"key":"StealingFromFuture","value":true},{"key":"StripedBudgetRows","value":false},{"key":"SwapClearedFlagged","value":false},{"key":"TargetBalanceWarning","value":false},{"key":"ToBeBudgetedWarning","value":false},{"key":"ToggleMasterCategories","value":false},{"key":"ToggleSplits","value":false},{"key":"ToggleTransactionFilters","value":"1"},{"key":"ToolkitReports","value":true},{"key":"TransactionGridFeatures","value":true},{"key":"ViewZeroAsEmpty","value":true},{"key":"l10n","value":"0"}]

I am experiencing the same issue.
Toolkit version 2.22.1
Seems to have arrived with the latest official YNAB update.

I am experiencing the same issue. Shows $0.00
Toolkit version 2.22.1

Same issue!

Same issue here!

I am having the same issue.

I just got around to looking at this today and I'm not experiencing this issue. Are you guys still seeing this?

Yeah, all of mine still say $0.00.

I just got around to looking at this today and I'm not experiencing this issue. Are you guys still seeing this?

Yes! It is still showing $0.00

Error is still showing.
Initially I wasn't able to see Total Monthly Goals, it was simply blank.
I went to Options > Advanced, Disable Toolkit for YNAB, saved settings, refreshed browser and Total Monthly Goals did pop up, but it is zeroed out.
Toolkit for YNAB: v2.22.1
Chrome: Version 81.0.4044.138 (Official Build) (64-bit)

Ah, I was able to figure this out. I'll have it in the release later today!


fix: set gap-name default to execute-api

Changes

Update default value to gap-name to execute-api. I believe this should almost always be execute-api except for certain crib use-cases?

Testing
Discovered this error when trying using setup-gap@main for a new workflow.
ERRO[0003] error proxying request                        message="{\"message\":\"Credential should be scoped to correct service: 'execute-api'. \"}" request="POST https://<redacted>.execute-api.us-west-2.amazonaws.com/primary/<endpoint>" status_code=403

https://github.com/awslabs/aws-sigv4-proxy?tab=readme-ov-file#configuration

Flag (or short form)
Type
Description
Default

name
String
AWS Service to sign for
None

do we need to fix the test?

It's unrelated to this change. I've message henry about it.


Add Chronosphere provider

Description
This pull request adds the Chronosphere Pulumi provider to the package list.
Adding a new package?
If this pull request adds a new package:

[ ] The package's schema URL in this PR is correct.
[ ] The package metadata file, if present, contains:

[ ] a supported category (one of Cloud, Infrastructure, Network, Database, Monitoring, or Utility).
[ ] a valid plugin download URL. See Publish Your Package.
[ ] a description that explains what the package does.
[ ] a valid logo URL that points to a PNG whose dimensions conform to the others in this repo (e.g., 100x100).

[ ] The package repo contains an Overview doc (/docs/_index.md) that includes:

[ ] a brief explanation of what the package is and what it does.
[ ] at least one representative example in all supported languages.
[ ] a front-matter property for the layout set to package.

[ ] The package repo contains an Installation and Configuration doc (/docs/installation-configuration.md) that includes:

[ ] links to SDKs in all supported languages.
[ ] a copyable command for installing the resource plugin if necessary.
[ ] an example of configuring the provider with pulumi config set.
[ ] an example of configuring the provider with environment variables.

[ ] The repository has:

[ ] a version tag prefixed with v that corresponds with a valid GitHub release and published package SDKs

[ ] A CODEOWNER has reviewed the PR.
[ ] A member of the @pulumi/docs team has reviewed all documentation.

Thanks for the submission @aschepis! We'll get this reviewed quick as we can.

@cnunciato thank you! I have been working with @ringods and Tej on this


UI: drag-and-drop folders

Use the non-standard Javascript File System API to drag-and-drop folders:
https://developers.google.com/web/updates/2012/07/Drag-and-drop-a-folder-onto-Chrome-now-available?hl=en
https://developer.mozilla.org/en-US/docs/Web/API/File_System_API
http://www.html5rocks.com/en/tutorials/file/filesystem/
Only Chrome, though: http://caniuse.com/#feat=filesystem

cc @dotMR

Duplicate of #54


Document the configuration of the docker-compose file better

explain the command line and it's syntax → flags should be added (with “” and comma inbetween)
mention examples of having more config flags
how to change config after deploying the database → docker restart vs docker down/up

Please add the Docker compose card: https://github.com/memgraph/documentation/pull/691#discussion_r1567171159

Pelase add the Docker compose for env: https://github.com/memgraph/documentation/pull/691/files#diff-3d9eed09cb1145f8eca058ea41ee667ced86663f6d04c5a291f19f278cbc7474R367


feat: Convert Clipboard image to png

fixes #872
Alternatively, we can request pasteboard to make this change. Their Mac mac and Linux native codes are already converting image buffer to png.
pasteboard's bmp seems to discard alpha channel, so transparency is already lost.
Even with this limitation, I would guess this already covers most use cases
Screenshot:

I have only tested this change on Windows, but don't expect this to be an issue with any other platform
Apologies for the half-baked PR. I have never used flutter/dart before and thus don't know best practices.
Feel free to clean up this patch as needed.

Nice!


oElement not set _hidePicker

In _hidePicker the oElement variable is not defined and also the afterHide function is not working because of this reason.
...
var oElement = dtPickerObj.dataObject.oInputElement;
...
fixes the problem temporarly for me.
Thx for your work, nice DateTime picker.
Greets
re1d1

Hi,
Thanks for reporting Error.


Fix Drawer navigator not opening same register_id page [enhance PR 2326]

IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #[issue number] or Closes #[issue number]
Engineer Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[x] I have added any strings visible on UI components to the strings.xml file
[x] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app

Code Reviewer Checklist

[ ] I have verified Unit tests have been written for any new feature(s) and edge cases
[ ] I have verified any strings visible on UI components are in the strings.xml file
[ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
[ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
[ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@pld I realized when you navigated using drawer navigator to screens, the navController.currentDestination?.id is always the same. This PR fixes that


Fix threading bug in EnqueueableEnumerator.MoveNext

Description
With the enumerator in blocking mode (backtesting), MoveNext was returning true while Current was being set to null.
Related Issue
Closes #2018
Motivation and Context
This was causing a NullReferenceException in SubscriptionSynchronizer.Sync.
Requires Documentation Change
No.
How Has This Been Tested?
Local and cloud backtests with the algorithm included in #2018
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/ect)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description or feature-<issue#>-<description>

One last comment here, is there enough data in the open source for a regression test? Maybe in preparation for when we're running regression against our full data set we can add the test algorithm anyway. I have some plans for supporting local regression tests using the open source data and a full suite of regression tests to be run by the CI process -- these threading cases are definitely good to put down, even if they would pass intermittently with the bug present (obviously passing all the time when the bug is resolved).


[Bug] *.tid files without a defined Type have it forced to text/vnd.tiddlywiki

I saw a change about loading MIME types, but I think this had an unintended halo bug where tiddlers of *.tid without a defined Type get it auto-set to "text/vnd.tiddlywiki". Just wondering if that was inteded?

I am running (check any that apply, put an x inside the [ ] to check a box, like this: [x]):

[x] Windows
[ ] OSX
[ ] Linux
[ ] Other

and using

[x] The nodejs version
[ ] The single file executable

Before posting I read issue guidelines and:

[x] I am using the newest version
[x] The answer to my question isn't listed in the documentation or this isn't
a question
[x] This is not a duplicate issue
[x] I have not done anything that required me to set acceptance to
I Will Not Get Tech Support For This

I haven't been able to get this behaviour, it isn't intended behaviour.

Yeah, I'm not seeing this either any more. Closed. Will reopen if it pops back up.


Conversation Follow-ups

Hey! I am building a virtual assistant in python and wanted to add contextual awareness to it. For eg:-
Me: Who painted Mona Lisa
Assistant: Leonardo de Vinci
Me: When was he born?
Assistant: 1475
Can you please explain how symbl could help me in this situation? Which endpoint do I use?

Hello!
Symbl analyze natural human conversation, It doesn't provide conversational flows.
If you need any help related to Symbl's API, you can join our slack community.
https://bit.ly/symbldotai-slack


fix: update architecture diagram

Fixes RVT-4055
Changes

#1521  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

revised figma

left a few couple comments.
let's add an architecture diagram page under advanced > internal in the docs too. you can link directly to the architecture image file from the readme so we don't have to dupe it.
nit: let's use png export since it's lossless.

Do we need it to be lossess? Its also a massive image file

@NathanFlurry revised again

left a few couple comments.
let's add an architecture diagram page under advanced > internal in the docs too. you can link directly to the architecture image file from the readme so we don't have to dupe it.
nit: let's use png export since it's lossless.

Do we need it to be lossess? Its also a massive image file

My export was 404 kb. PNG is really good at compression.


fix(cirriculum) - remove console.log(data) from step 9 and above for the leaderboard project

Checklist:

[X] I have read and followed the contribution guidelines.
[X] I have read and followed the how to open a pull request guide.
[X] My pull request targets the main branch of freeCodeCamp.
[X] I have tested these changes either locally on my machine, or GitPod.

Closes #52746

Everything seems to be in order?

It looks like you are failing one of the automated tests for detecting upcoming changes.
Looking at the error message it currently says this

Check challenges
Check challenges (english)
learn-asynchronous-programming-by-building-an-fcc-forum-leaderboard
Step 11
Check tests against solutions
Solution 1 must pass the tests:
Check next step for solution!
Test text: You should call showLatestPosts() at the end of your try block.
AssertionError: expected '\n\n  …' to match /\sconsole.log(data);?\sshowLatestPosts(.);??\s/
at eval (eval at  (http://<IP_ADDRESS>:8080/js/frame-runner-8a3afd40d57f4f0aee85.js:2:101998), :1:8)
at HTMLDocument. (http://<IP_ADDRESS>:8080/js/frame-runner-8a3afd40d57f4f0aee85.js:2:101998)
at l (http://<IP_ADDRESS>:8080/js/frame-runner-8a3afd40d57f4f0aee85.js:2:35726)
at c (http://<IP_ADDRESS>:8080/js/frame-runner-8a3afd40d57f4f0aee85.js:2:36028)

You will want to double check that step 11's tests match up with step 12's solution.
You can check this locally by running the following command
 FCC_BLOCK='Learn Asynchronous Programming by Building an fCC Forum Leaderboard' pnpm run test:curriculum

Also, it looks like you are failing some of the translation automated checks.
Pulling in the latest changes from main should resolve that because that bug was fixed a few days ago.

All of the tests pass now.

@a2937, looks good to me, the single line is omitted from relevant files and the tests are passing.

@a2937 looks good, the single line is omitted in related files and the tests are passing as well


Blog: tags not working

Tags are not working on the Production Site.
URL: https://stories.mplus.org.hk/en/blog
Browsers: all
Platforms: all

This is a known issue--will resolve when full site is available.


R&D on Jhipster tools and stack

Research on jhipster tool and its capabilities

Good to read article for pro's and cons of jhipster:
https://www.north-47.com/knowledge-base/jhipster-is-it-worth-it/
Alternative to jhipster:
Spring io initializer and Dropwizard are few alternative for code bootstrapping still it doesnt provide these many features and prototype creation as done by jhipster


Lower Minimum SDK

Is your feature request related to a problem? Please describe.
Current minimum SDK is set to API 21. For example my app supports back to API 19. I can't use this library :(
Describe the solution you'd like
Support lower API versions.

@Fabi755 I've tried to cover all the backward compatibility cases and released a 0.4.0 version in #61.
implementation "codes.side:andcolorpicker:0.4.0"
Feel free to report any new issues and feature requests!


Mark PSP deprecated in the docs

See https://github.com/kubernetes/kubernetes/pull/97171

lgtm (but not signing off since I'm not active)
Thanks @tallclair!  Good to see the new proposals the sig was discussing to replace PSP.

Question for website maintainers - should this go in the v1.21 branch? Since the deprecation is already committed, I think it's valuable to indicate that the deprecation is coming sooner rather than later. I suppose it could technically still be rolled back, but I think that's extremely unlikely.

Question for website maintainers - should this go in the v1.21 branch? Since the deprecation is already committed, I think it's valuable to indicate that the deprecation is coming sooner rather than later. I suppose it could technically still be rolled back, but I think that's extremely unlikely.

Hi @tallclair .
When was the feature deprecated (after v1.20.0)?
I suggest to create this change in the dev-1.21 branch.

Done: https://github.com/kubernetes/website/pull/26581


Make lite working on FreeBSD

This PR makes lite working on FreeBSD, by fixing up build.sh and add proper path detection support on FreeBSD.
Note that I use realpath on FreeBSD. realpath is also available under Linux, but only when _DEFAULT_SOURCE is defined. I'm not going to change path detection on Linux, as it seems to work and you probably had a good reason to use /proc directly.
I didn't change build_release.sh, as I'm not using it at all. I leave it up to you to change it if you so desire.

@rxi Hi, I've just updated this PR as there was a conflict in src/main.c
I was wondering if you had any remarks on this patch. How can I make sure this gets merged? Is it something you want to merge?
Thanks.

Sorry about the delay! I haven't had a chance to grab this and look through it properly, from an initial skim I was a bit confused by use of the restrict keyword; It feels in minor conflict with the existing code base as it isn't used throughout -- if it isn't essential it might be better if it were removed.
Overall I have a little bit of scepticism as this feels like it closely mimics the original path detection lite used (you'll have to look back at the initial commit) which unfortunately didn't work properly, (I believe, if you launched lite from a shell script -- I may be remembering this wrong) though I acknowledge things may be different on BSD. Otherwise BSD support isn't a feature I'm opposed to, I just have to find the time to test the changes myself.

I've removed the usage of restrict and made it more in line with your code style. It wasn't essential. Thanks.
As for the usage of realpath in the past, I've looked at ba86b58b and from what I can tell ARGS[1] was used as is; no realpath lookup was performed. That may have caused some issues you had before. I've tested lite with some shell script wrappers using my patch and the executable directory is detected properly each time.

@rxi: Did you have any chance yet to review this pull request properly? You said you wanted to test this before you merge it.
How can I help so this pull request gets merged? :-)
Thanks

+1
Just tried the patch on FreeBSD, and now lite works well. Did not encounter any problems so far.
Taking a quick look at the proposed changes, they seem reasonable to me.


ImageBitmap

We're using this issue to track the pending content merge.

@jeffposnick - can we close this?


Update MixProject dependencies list [:absinthe]

In practice, this builds the tutorial as an absinthe 1.6 project upon a fresh Phoenix 1.5.9 project generation, and formats the project with mix format. All the queries listed in the absinthe tutorial resolve as they ever did.

If this is helpful, I’m happy to make the associated changes in the absinthe tutorial. They’d be almost entirely formatting changes, and very simple to make.


Raw pointer properties don't seem to work

I'm trying to register a class with raw pointer properties (i.e. no smart pointer stuff) and RTTR (0.9.5) does not seem to handle it correctly. The issue seems to be that pointers are being assigned by value. This manifests itself in two different ways:

Setting a value on a pointer property whose current value is null will sometimes crash, but when it doesn't crash won't assign anything at all.
A pointer property of a type whose assignment operator is inaccessible will not compile at all.

Both are pretty unexpected, but looking at the code this seems to be by design, which seems pretty odd. I'm building on Windows using VS2015, for x64 bit.
Minimal repro case:
struct Pointee
{
public:
	// If you uncomment this line the code will no longer compile. If you leave it commented, the code will compile but crash
	//Pointee& operator=(const Pointee&) = delete;
};

struct ClassWithPointer
{
public:
	Pointee* mPointee = nullptr;
};

RTTR_REGISTRATION
{
	using namespace rttr;

	registration::class_<Pointee>("Pointee")
					.constructor<>();

	registration::class_<ClassWithPointer>("ClassWithPointer")
					.constructor<>()(policy::ctor::as_raw_ptr)
					.property("mPointee", &ClassWithPointer::mPointee);
}

// Main loop
int main(int argc, char *argv[])
{
	rttr::type obj_type = rttr::type::get<ClassWithPointer>();
	ClassWithPointer* obj = obj_type.create().get_value<ClassWithPointer*>();

        // This line will either crash, or if it doesn't crash, the mPointee member will still be null
	obj_type.get_property("mPointee").set_value(*obj, new Pointee());
}

Am I doing something obviously wrong?

I've done a test using the latest version of RTTR (master) and that has the same issue.

I found the reason for this issue, but I have to think about how to fix it now easily.
btw. You should not use raw pointers  :wink:

I've investigated a bit more and I've found a fix. I'm not sure if it's okay with you, but I'll make it locally so I can continue.
So, the problem seems to be that there's two uses of pointers in RTTR:

Where you're binding a property by pointer, through the policy::prop::bind_as_ptr policy
When you're actually binding a raw pointer property

In the first case, we don't actually want to update the pointer itself, rather we want to update the value of thing the pointer points to, which explains the current copy behavior when setting pointers. In this case, the pointer should logically be considered a const pointer to a non-const object, even though it's not.
In the second case, we do want to update the pointer itself; the pointer is the value.
So, the fix I've made is as follows. First, I've modified the current specialization of property_accessor<T*> to consider the pointer const:
template<typename T>
struct property_accessor<T const*>
{
    static bool set_value(T* prop, argument& arg)
    {
        *prop = *arg.get_value<T*>();
        return true;
    }
};

This allows us to select the correct specialization to use, depending on the desired behaviour.
Next, I've updated property_wrapper for the return_as_ptr, set_as_ptr specializations, in order to maintain the current behavior in case 1:
property_wrapper_member_object.h line 161 becomes:
return property_accessor<A const*>::set_value(&(ptr->*m_acc), arg);
and property_wrapper_object.h line 151 becomes:
return property_accessor<C const*>::set_value(m_accessor, arg);
(note the addition of the const in the template selection)
This change allows the 'regular' specialization of property_wrapper to select use the non-specialized version of property_accessor, which has the correct behavior for raw pointers.
This seems to work for me and all unit tests still pass. Do you think this could be a good way to fix it?
I'll use raw pointers if I want to :sunglasses:

In working with pointers more, we've noticed that support for pointers just seems broken in general. At the very least, polymorphic pointer assignment (assign pointer-to-derived-type to pointer-of-base-type) and pointer comparison don't work. There may be other issues with pointers we just haven't run into yet.
We have local fixes for both of them. Should I open new bugs for these things or is it OK for this bug to serve as an assortment of pointer problems?

@rovarma
Sorry for delay I was in vacation.
I am impressed how good you found yourself in the code base.  :thumbsup:
Do you want to become a developer for RTTR?
The following specialization is made to be used only for the property policy bind_as_ptr
But it is also used for normal pointers, which is wrong.
template<typename T>
struct property_accessor<T*>
{
    static bool set_value(T* prop, argument& arg)
    {
        *prop = *arg.get_value<T*>();
        return true;
    }
};

Your specialization with the const Template argument, should not be necessary,
Just the normal implementation should be called:
template<typename T>
struct property_accessor
{
    static bool set_value(T& prop, argument& arg)
    {
        prop = arg.get_value<T>();
        return true;
    }
};

So I need to make the specialization only be called with the policy.
That's why I wonder, how your adding of const expression make it working.
Yes, please report any bugs you found and when you found one, open up a new issue for every bug.

No problem. Hope you had a good holiday.
The reason why the specialization is called even without the policy is because in the regular property_wrapper, in the case of a pointer, typename A will be of type Type*. So the compiler selects the T* specialization of property_accessor, because it is a better (more specialized) match than the normal, unspecialized, template.
Changing the specialization from T* to T const* fixes it, because now the normal template is a better match, since the type being used to call it is of type T*, not of T const*, and calling the T const* specialization would therefore require type conversion. If we're fixing it in this way, we then need to update the bind_as_ptr policy cases to use const so that they still use the T* specialization.
Of course, if the intent is really that the T* specialization is only called in the policy case, another way to fix it could be to remove the specialization entirely and simply introduce a new property_accessor type that is called instead (or somehow specialize on policy?).
I'll leave it up to you to decide which fix you prefer :)


[push-voting-power] Ethereum Push Notification Service ($PUSH) Governance: Custom strategy for voting

Changes proposed in this pull request:

Adding a new strategy for PUSH governance
This strategy weighs the vote using:

Amount of $PUSH delegated to user
Amount of $PUSH staked in Push staking pool
Amount of $PUSH-LP staked in LP staking pool

The voting power is calculated in terms of $PUSH, so $PUSH-LP tokens are converted to $PUSH using on chain data from Uniswap-V2 Router, WETH and USDT token contracts.

@ChaituVR, thanks for recommending the improvement!
I've made the changes, we can proceed further

@ChaituVR Any more changes needed from our side.
I made the changes, but I'm not sure why it isn't merging automatically