[Feature]: TextInput supports 'enableClear'

What problem does this feature solve?
When using TextInput, if enter very long text, must either long press the delete button to delete or select all text before deleting.
If there has a clear button, like Select, it would improve the user experience.
What does the proposed API look like?
For TextInput, add enableClear prop.
NumberInput does not support enableClear prop.
The api:
export type TextInputProps  = Omit<BaseInputProps, "stepper" | "makeInputClassName"> & {
  ...
  enableClear?: boolean;
  ...
}

The ui:
Normal:

With Error:

With Disabled:

Shall I try on this issue?

can i try this issue?

c.f. #769


Fix extension installed check for already migrated DB schema

Closes #183

@cevian would this test catch that? Checking the flag after second migration:
https://github.com/timescale/timescale-prometheus/pull/186/files#diff-84dae51ce95be25c580ac1f2b9adc643R45
Not really sure what test we could do except that.


[GLUTEN-3962][VL] Respect parsed attribute name and remove column name validate logic

What changes were proposed in this pull request?
Respect parsed attribute name from Spark, sum(a) is a valid attr name in Spark.
Remove column name validate logic safely since SparkTokenizer already added.
(Fixes: #3962)
How was this patch tested?
added UT.

Spark33 allow read parquet column with special characters but Spark32 does not....  details see https://github.com/apache/spark/pull/35229

@PHILO-HE @rui-mo @ulysses-you please help review, thank you!

cc @waitinfuture please help rerun failed ci job, thank you!

@PHILO-HE @ulysses-you @rui-mo any more comments?

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_3963_time.csv
log/native_master_12_12_2023_8c6f1643e_time.csv
difference
percentage

q1
33.89
33.75
-0.140
99.59%

q2
27.48
24.88
-2.595
90.56%

q3
37.58
37.71
0.124
100.33%

q4
39.51
37.86
-1.656
95.81%

q5
72.23
72.83
0.599
100.83%

q6
7.02
7.05
0.029
100.41%

q7
83.96
86.50
2.538
103.02%

q8
87.97
86.24
-1.726
98.04%

q9
126.84
125.50
-1.339
98.94%

q10
45.71
44.68
-1.026
97.76%

q11
20.94
20.21
-0.726
96.53%

q12
27.39
25.06
-2.326
91.51%

q13
46.81
46.58
-0.234
99.50%

q14
15.61
19.99
4.382
128.08%

q15
29.11
27.55
-1.566
94.62%

q16
15.49
15.86
0.367
102.37%

q17
103.03
103.27
0.238
100.23%

q18
150.83
151.33
0.502
100.33%

q19
12.83
13.89
1.060
108.26%

q20
26.96
28.68
1.729
106.41%

q21
226.18
229.12
2.941
101.30%

q22
14.05
13.95
-0.093
99.34%

total
1251.41
1252.49
1.083
100.09%


Dcos: Update nacos-example readme file.

Backgorund
In the nacos 2.2.x version, the authentication function was added, causing most users to have errors such as user not found or login failed when upgrading to the nacos 2.2.x version. I think it is necessary to update the readme document to add This part of the content.
Now nacos-example has three examples, and each example module has a readme file. I think they need to be uniformly placed in the nacos-example directory to reduce the cost of maintaining documents.
Reference
https://nacos.io/zh-cn/blog/announcement-token-secret-key.html
https://nacos.io/zh-cn/docs/auth.html

If updates are needed, please assign them to me. @ruansheng8

Please, also update the documentation on our official website

Please, also update the documentation on our official website

got it.

mark!


Upgrading laravel5-angular-material-starter pack

What would you suggest as the easiest way to upgrade an existing repo based on laravel5-angular-material-starter v2.10.* and adding the improvements made in v3.0?
There are many improvements that I'd like to integrate into my project but I'd rather not have to do it all manually :)

Hi @edbentinck
Would you be able to describe more about the existing functionality in your 2.10 app?

Are you using the response macro provided? (response()->success() and response()->error())

Because I think these are the 2 main breaking changes..
So depending on your answers, it might be much easier for you to start with a fresh installation and copying your previous files (Just like you'd do when upgrading from Laravel 4.3 to 5.0)

Hmm, I think you could be right. I think it probably would be easier to go with a fresh install.
I hadn't made too many changes to the fresh install of 2.10, but I notice that since then there are a number of alterations to the standard Laravel (and Angular) install dotted around the app, so it might be too much hassle to manually upgrade. Unless of course you wanted to create an Upgrade Guide, like (the one offered by Laravel](https://laravel.com/docs/master/upgrade#upgrade-5.2.0), but probably not worth it ;)
Thanks for the info and keep up the great work!

@edbentinck it's already there :smile:
https://laravel-angular.readme.io/docs/upgrade-guide
But it recommends you do it with a fresh installation.. it's going to be even faster for you, since you're upgrading from 2.10

Ohh! :sweat_smile: My bad, I didn't spot that!
That's awesome!

No worries :smile:
Feel free to report any issues that you face along the way - or anything that you deem unclear


Fix text about classifier position

Closes #3454

Mobile will work the same as desktop - as it is based off resolution rather than device :)


[Suggestion] Add the logs for saving the blob changes in File Explorer

OS: All
Build Version: 20190818.1
Regression: Not a Regression
Repro Steps:

Enable "Azure Storage: Enable View in File Explorer" in User Setting.
Drill down from one storage account --> "Blob Containers" node -->Expand one blob container --> Click "Open in File Explorer...".
Create a new file--> Edit this file--> 'Ctrl+S' to save this change.
Check the logs for this process.

Suggestion:
Add the logs for this process in notification or output panel.
Actual:
"Save blob..." progress bar flashes and there is no log in notification or output panel after this process finished.
More info:
This issue also reproduces for File Shares.

It works as intended. Closing this.


IGNITE-2708

fixed IGNITE-2708 by check the state of spi when GridManager start it.

Ryan, please close the PR.
I have merged this to master. Thanks for your contribution!


Use nightly changelog theme

It seems like we are stuck with the VERSION macro.
The best solution I found is to overwrite temporarily it with NIGHTLY_VERSION, however this depends on https://github.com/dlang/tools/pull/221
To make it "stable" (aka without the nightly information), the easiest way is to set BUILD_NIGHTLY=0

Awesome!

OK, LGTM and leaving this for @MartinNowak to review as it affects the release process.
Just name the changlog _pre.d will build a pre-release changlog.

-> renamed to changelog/${NEXT_VERSION}_pre.dd for the default generation (nightly).
There's also a changelog/${NEXT_VERSION}.dd target, which can be used by to generate the "release version" of the changelog (without "to be released", nightlies download link, ...).
As we now have two different files I added the _pre files to the .gitignore, s.t. a default build of dlang.org doesn't generate any "new files".

Always using stable seems incorrect when the purpose of this target is trying to build the changelog for dmd/druntime/phobos PRs.

I have changed it, s.t. for the _pre changelog files upstream/master is used instead.
Due to the new DIFFABLE Makefile variable this doesn't matter on DAutoTest anyways.

@MartinNowak If you're happy with these could you please merge them? Thanks!

THX


strange results - 1 var time series

Hi @davidhallac .
I am trying your algorithm on 1 dimensional finanical tiem series but im getting very strange results. Has it got to do with the parameters?
from TICC_solver import TICC
import numpy as np
import sys
import yfinance as yf
import numpy as np
import matplotlib.pyplot as plt
import pandas as pd

data = yf.download("^GSPC", start="2016-01-01", end="2020-12-30")

dd=data['Close']
d=dd.to_numpy()

np.savetxt("foo.txt", d, delimiter=",")

ticc = TICC(window_size=30, number_of_clusters=3, lambda_parameter=11e-2, beta=600, maxIters=5, threshold=2e-1,
              write_out_file=False, prefix_string="output_folder/", num_proc=1)
(cluster_assignment, cluster_MRFs) = ticc.fit(input_file='foo.csv')

print(cluster_assignment)
np.savetxt('Results.txt', cluster_assignment, fmt='%d', delimiter=',')

%matplotlib inline
import matplotlib.pyplot as plt
import datetime
import numpy as np

plt.plot(data['Close'])
plt.show()
plt.plot(cluster_assignment)
plt.show()

The above code gives the below.

Hi Did you get these results from windows machine.. I have problems while running in windows machine. I believe it to be because of multiprocessing. looking forward for suggestions..


Inbox pattern for pubsub in Dapr

/area runtime
Overview
Hi guys. Maybe Dapr could provide an outbox & inbox infrastructure since any distributed app development framework needs it to make sure domain events are published and subscribed.
This issue only discusses inbox, I will continue to think about the inbox later and create a new issue for it. Please also see the Outbox pattern for pubsub in Dapr.
Why the Inbox Pattern?

Taking a long time to process a message subscribed from pubsub may overburden or block the bus.
Can we ACK first and then progress the message? No, because maybe it will fail or the app crashes during the progress. The progressing result is entirely unknown.
A Possible Design
So the inbox pattern will help:

Why Not the Inbox Use the Same Database and Transaction with Business Data?
We can see the inbox processor of the ABP framework puts the inbox table to business databases and uses a shared transaction, but if tenants have their private DBs and DbContext uses different databases, there will be a large number of databases that need to be monitored, which we cannot predict.
So what if the processing succeeded but the app didn't call back to the inbox? (maybe the app crashes during the progress) I expect the inbox will push to the app again later. The inbox provides At-least-Once delivery, and apps should be ready to get duplicate messages since the idempotent is important.
References
https://github.com/dotnetcore/CAP
https://event-driven.io/en/outbox_inbox_patterns_and_delivery_guarantees_explained/
https://www.youtube.com/watch?v=ebyR5RPKciw
https://microservices.io/patterns/communication-style/idempotent-consumer.html

Here I believe that you are suggesting implementing local transactions between the message and the user application for which the message was destined. In the event of an application failure the can application recover and can read the original message again which it applies to its state in a transaction way. Is that your intent?

Hi @msfussell, thanks for your reply.
What I want is to add an infrastructure between pubsub and apps:
producer app -> outbox -> pubsub
pubsub -> inbox -> consumer app
The outbox pattern ensures that the related messages (domain events or more) will eventually be published after the app completes a DB transaction.
The inbox pattern receives messages from pubsub and ack quickly. It will be good for concurrency of pubsub, to retry a failed processing, and to deal with a final failed processing.

message queues implementing local transactions between the message and the user application

In a word, the outbox is using transactions of an app, but the inbox does not.
For the outbox pattern, we can use local transactions to ensure consistency. After completing a DB transaction, the business data was updated, and the domain event messages were also inserted into the inbox table.
For the inbox pattern, it receives messages from pubsub and ack quickly. And then, the inbox sequential delivers them to the app. After a handler processes a message (transaction is complete), it tells the inbox to set the result of the message processing. The event handlers of the app may need a DB transaction, but the inbox does not.

@gdlcf88 I'm not sure if I agree with the statement "... since any distributed app development framework needs it to make sure domain events are published and subscribed."
What I'm concerned with the proposed approach are the following (IMHO):

You "replace" one point of failure with another (broker replaced by database)
Effectively now there are two points of failure, which seems like fighting fire with fire
Haven't checked but intuitively I'm assuming that database write performance would be lagging far behind any message broker (indexing, 2pc, ability to handle concurrent connections, r/w locks)
Read of append log like tables is not something relational databases excel in (therefore it needs TSDBs probably)
For high throughput systems, the backing database size is going to grow wildly so database maintenance would become an issue
For inboxing - polling a database by many clients might become an issue. Using CDC requires the ability to handle the CDC payload which differs by db-engine. Using CDC systems to pull the messages introduces another complexity (e.g. Debzium uses Kafka which becomes a recursive dependency cycle over an MQ)

Hi @amimimor ,
First of all inbox is an optional in pubsub, it is not required.

The failure point is not a replacement relationship, inbox does not address the failure risk of MQ.
Inbox's db failure risk needs to be borne additionally, this is true, but inbox's requirement objectively needs to be solved unless there is a better alternative.
inbox database write time will not exceed expectations, the event model itself has time overhead, event publishing, transmission, reception, processing all need time, simple inbox write does not exceed expectations.
tsdb should be available as a storage implementation of inbox, but not required.
Agree, database maintenance is an additional cost for this pattern, even difficult to do automatically, but in the future can look forward to a powerful dashboard.
Sorry. I don't know much about CDC.

Hi @amimimor ,
First of all inbox is an optional in pubsub, it is not required.

The failure point is not a replacement relationship, inbox does not address the failure risk of MQ.
Inbox's db failure risk needs to be borne additionally, this is true, but inbox's requirement objectively needs to be solved unless there is a better alternative.
Inbox database write time will not exceed expectations, the event model itself has time overhead, event publishing, transmission, reception, processing all need time, simple inbox write does not exceed expectations.
tsdb should be available as a storage implementation of inbox, but not required.
Agree, database maintenance is an additional cost for this pattern, even difficult to do automatically, but in the future can look forward to a powerful dashboard.
Sorry. I don't know much about CDC.

Another problem I found in the inbox implementation of the ABP framework is that Any handler throwing block the whole inbox queue. Then we tried to fix it in this PR, but Mr.Kalkan reminded us of one thing:

It is not acceptable to skip an event and continue to publish/consume the next one. Event publish/consume order can be important in some cases.

DDD may have higher requirements for the Outbox & Inbox pattern. How do we design it for Dapr?

ping?

See https://github.com/dapr/dapr/issues/4233#issuecomment-1145650624

Hi @yaron2, I hope this issue can keep open until the Dapr team has a clear intention.


update electron

The current semvar allows the latest minor and patch versions to be installed.
https://docs.npmjs.com/getting-started/semantic-versioning#semver-for-consumers
Try running npm update and you will update all local deps to latest patch/minor

In accordance to this, its better to control exactly what version of electron your using.
https://github.com/electron/electron/blob/master/docs/tutorial/electron-versioning.md
If you are using electron or electron-prebuilt, we recommend that you set a fixed version number (1.1.0 instead of ^1.1.0) to ensure that all upgrades of Electron are a manual operation made by you, the developer.

I see. Makes sense.

Thanks!

:smile:!


[TTNN Dialect] Convert to_memory_config from DPS to non-DPS op

The op should be converted to match actual implementation in ttnn library.

Reopening issue. I had to revert this commit since it broke main for silicon tests with the following error signature
Traceback (most recent call last):
  File "/opt/ttmlir-toolchain/venv/bin/ttrt", line 8, in <module>
    sys.exit(main())
  File "/opt/ttmlir-toolchain/venv/lib/python3.10/site-packages/ttrt/__init__.py", line 42, in main
    request_api()
  File "/opt/ttmlir-toolchain/venv/lib/python3.10/site-packages/ttrt/common/api.py", line 940, in __call__
    self.execute()
  File "/opt/ttmlir-toolchain/venv/lib/python3.10/site-packages/ttrt/common/api.py", line 905, in execute
    _execute(self.ttnn_binaries)
  File "/opt/ttmlir-toolchain/venv/lib/python3.10/site-packages/ttrt/common/api.py", line 864, in _execute
    event = ttrt.runtime.submit(
IndexError: _Map_base::at

Please see ttrt docs on how to run test cases for n150 + n300 systems. We are working in the background on getting CI up and running for this.
fyi @jnie-TT

@svuckovicTT I took a look at this. It seems like the final toMemoryConfig op that moves the output to host is getting an invalid input_id that does not exist in the live_tensors map in runtime. That's why we are getting a map::base at error.
I narrowed it down to this:
  auto input = cache.getOrCreate(op.getInput(), tensorValueToFlatbuffer,
                                 kHostAllocatedAddress, kHostAllocatedSize);

in TTNNToFlatbuffer.cpp. getOrCreate here should be able to retrieve the input from the flatbuffer cache (this getInput() should reference the output of the previous op). However, for some reason it cannot find the input and creates a new one instead. This new input is completely detached from the execution graph because it's not linked to the output of any previous operation.
For example, looking at this MLIR snippet:
    %0 = "ttnn.open_device"() <{device_ids = [0, 1]}> : () -> !tt.device<<#tt.grid<7x8, (d0, d1) -> (0, d0, d1)>, [0]>>
    %1 = "ttnn.to_memory_config"(%arg0) : (tensor<64x128xf32, #layout>) -> tensor<64x128xf32, #layout2>
    %2 = "ttnn.empty"(%0) : (!tt.device<<#tt.grid<7x8, (d0, d1) -> (0, d0, d1)>, [0]>>) -> tensor<64x128xf32, #layout2>
    %3 = "ttnn.relu"(%1, %2) <{operandSegmentSizes = array<i32: 1, 1>}> : (tensor<64x128xf32, #layout2>, tensor<64x128xf32, #layout2>) -> tensor<64x128xf32, #layout2>
    %4 = "ttnn.to_memory_config"(%3) : (tensor<64x128xf32, #layout2>) -> tensor<64x128xf32, #layout1>
    "ttnn.close_device"(%0) : (!tt.device<<#tt.grid<7x8, (d0, d1) -> (0, d0, d1)>, [0]>>) -> ()
    return %4 : tensor<64x128xf32, #layout1>

%3 inputted into the to_memory_config operation should be the output of the ttnn.relu op. However, op.getInput() returns a value that's different from the output of the relu op, and thus a new RankedTensor is created with a globa_id that doesn't previously exist

Ah, that's too bad. There's some discussion on that topic here: https://github.com/tenstorrent/tt-mlir/issues/435
I'll give it a think today.

Fixed via #437.


Kroach/oasis 1621 analyze

OASIS-1621 Fix potential objective-c-sdk bugs identified by the
Apple Xcode static analyzer aka Product > Analyze .
This pull request eliminates all 40 potential bugs identified by Analyze
except for 1 potential bug in JSONModel-iOS code which is not under
Optimizely's control .
TEST:
Xcode Analyze + 2 demo apps + 10 test suites

EXPLANATION OF THE ONE TEST FAILURE
It's the iOS Universal framework again.  The log gets too long on Jenkins/Travis.
Locally on our own Mac, if we build OptimizelySDKiOS-Universal and
OptimizelySDKiOSUniversal we get "Build Succeeded" .  If we run the
OptimizelySDKiOSUniversalTests locally on our own Mac we get:
Test Case '-[OptimizelySDKiOSUniversalTests testiOSSDKInitializedWithOverrides]' passed (0.013 seconds).
Test Suite 'OptimizelySDKiOSUniversalTests' passed at 2017-08-01 17:42:49.408.
Executed 1 test, with 0 failures (0 unexpected) in 0.013 (0.015) seconds
Test Suite 'OptimizelySDKiOSUniversalTests.xctest' passed at 2017-08-01 17:42:49.408.
Executed 1 test, with 0 failures (0 unexpected) in 0.013 (0.016) seconds
Test Suite 'All tests' passed at 2017-08-01 17:42:49.409.
Executed 1 test, with 0 failures (0 unexpected) in 0.013 (0.017) seconds


Dark mode

This plugin does not work properly in dark mode

@sergio-gomez :
First, install them properly. After that, go to "Language" then "User defined language" tabs. In the new window change "User language" to "julia".
There are two main problems here.
In the below tabs (I mean "Folder & default" and "Keywords list" etc.) open "styler" for anyone that filled. In the "styler" window change black color to any color you like, in the "Foreground" part. Then, fill the "Transparent" checkbox for "background color".
After that, restart Notepad++.

@VOLCANIC-9:
Thanks for the recommendation, it is cumbersome but works. Anyway, I do not see the difference between this solution and just defining a new language by copy&paste of the provided XML file, adjusting all the colors by hand. Sincerely, I was expecting an updated version of the current style that handles correctly Light and Dark modes, or the addition of a new "Julia Dark Mode" style. I understand that nobody is using NP++ to edit Julia, thus this is not a priority nor a real community need, but I thought that posting this issue could trigger the developers to have a look at it.

A basic template for Notepad ++ Julia Dark Mode
copy file to C:\Users<<user_name>>\AppData\Roaming\Notepad++\userDefineLangs
convert extension txt to xml
Julia_Npp_Dark.txt


[Type tokens] Inconsistent naming on website

Need to fix naming convention of type tokens on the website and a couple missing ones (Typography tabs)

Expressive
Headings
lg: expressive-heading-05 might be calling what expressive-heading-06 is?
I think the heading-05 should be:
Size: 32px/2rem
Line-height:40px / 2.5 rem
Weight: 400 / Regular
Letter-spacing: 0px
need to include:
expressive-heading-06
expressive-heading-07
Paragraphs and quotes and Display

these do not have the word expressive in the token name in the most up to date elements package, except for expressive-paragraph-01. If we want to change these to have the word expressive in front of them, we will need to change that in code.

should be:
quotation-01
quotation-02
display-01
display-02
display-03
display-04

Thanks @laurenmrice and @tw15egan! Moved to the website repo. @tw15egan Please let us know if you think this is a dup of #1852.

Well the thing I am confused about is that the actual names of the tokens on the elements site, for the quotes and displays don't have expressive in front of them. https://carbon-elements.netlify.com/type/examples/preview/

What would the values be for expressive-heading-05 through expressive-heading-07? Each one of these has defined steps, so we'd need to add in the values for each step like so
In regards to the second point, I added in the expressive to take care of the last point in this issue: https://github.com/carbon-design-system/carbon-website/issues/1583. If these tokens do not exist, should we revert those changes, or update the type tokens?

After taking a look at the type repo, it seems like they have always been just quotation-01 etc...
https://github.com/carbon-design-system/carbon/blob/master/packages/type/src/styles.js#L246

I also don't see expressive-heading-07 in the netlify example 🤔

Hey @laurenmrice

good call on the names -- I missed that and you're right, only headings have "expressive" in them.
should be:
quotation-01
quotation-02
display-01
display-02
display-03
display-04

But in the .json file, we actually don't have and $expressive-heading-06 & 07
Those were only added to product because they're fixed. $Expressive-heading-05 actually grows through those sizes at breakpoints and then the Displays take over.
If we want to add those sizes for expressive headings... we're going to start running into the Display values.
Also, hmmm for some reason that orphaned "Heading" is still sitting there

That fix still hasn't been merged (https://github.com/carbon-design-system/carbon-website/pull/1860), but I'll make another PR for the other updates


Connection to Connect API not possible via HTTP (IllegalStateException)

Describe the bug
The initial situation is the same as described in issue #323
So I want to reach the Connect API via HTTP (and not via HTTPS). Accordingly, I do not have any of the entries in my config (ssl.keystore.location etc.) that were added with commit df237ec0411be37f7fa16c9c48eed3cf6c2e0369.
I get the following exception:
Exception in thread "main" java.lang.IllegalStateException: KeyManagerFactoryImpl is not initialized
        at java.base/sun.security.ssl.KeyManagerFactoryImpl.engineGetKeyManagers(Unknown Source)
        at java.base/javax.net.ssl.KeyManagerFactory.getKeyManagers(Unknown Source)
        at com.purbon.kafka.topology.clients.JulieHttpClient.configureHttpOrHttpsClient(JulieHttpClient.java:100)
        at com.purbon.kafka.topology.clients.JulieHttpClient.<init>(JulieHttpClient.java:49)
        at com.purbon.kafka.topology.api.connect.KConnectApiClient.<init>(KConnectApiClient.java:24)
        at com.purbon.kafka.topology.JulieOps.lambda$configureKConnectArtefactManager$0(JulieOps.java:178)
        at java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown Source)
        at java.base/java.util.HashMap$EntrySpliterator.forEachRemaining(Unknown Source)
        at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
        at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(Unknown Source)
        at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
        at java.base/java.util.stream.ReferencePipeline.collect(Unknown Source)
        at com.purbon.kafka.topology.JulieOps.configureKConnectArtefactManager(JulieOps.java:179)
        at com.purbon.kafka.topology.JulieOps.build(JulieOps.java:157)
        at com.purbon.kafka.topology.JulieOps.build(JulieOps.java:81)
        at com.purbon.kafka.topology.CommandLineInterface.processTopology(CommandLineInterface.java:206)
        at com.purbon.kafka.topology.CommandLineInterface.run(CommandLineInterface.java:156)
        at com.purbon.kafka.topology.CommandLineInterface.main(CommandLineInterface.java:146)

I suspect that it is because a config is always included in the following code section (ssl and not ssl config entries).
https://github.com/kafka-ops/julie/blob/df237ec0411be37f7fa16c9c48eed3cf6c2e0369/src/main/java/com/purbon/kafka/topology/JulieOps.java#L172-L177
https://github.com/kafka-ops/julie/blob/df237ec0411be37f7fa16c9c48eed3cf6c2e0369/src/main/java/com/purbon/kafka/topology/api/connect/KConnectApiClient.java#L23-L25
https://github.com/kafka-ops/julie/blob/df237ec0411be37f7fa16c9c48eed3cf6c2e0369/src/main/java/com/purbon/kafka/topology/clients/JulieHttpClient.java#L48-L52
Therefore, an HTTPS client is always configured in configureHttpOrHttpsClient, which then probably fails because of the missing config entries or something else.
https://github.com/kafka-ops/julie/blob/df237ec0411be37f7fa16c9c48eed3cf6c2e0369/src/main/java/com/purbon/kafka/topology/clients/JulieHttpClient.java#L66-L69
(By the way: Thanks for all of your work.  I appreciate a ton. This should be fixed with #327

I plan to release 3.0 rather soon, so any testing effort is very much appreciated ;-)


Improve path handling on Windows

This PR fixes a few issues that occur on Windows hosts with regards to path handling.
Primarily, it addresses an issue this role erroneously deleted all the managed service files it creates in the Delete not declared services [Windows] task. The source of this problem was mixing POSIX-style and Windows-style paths, so that the file matching condition would always fail and cause the files to be deleted. This PR introduces some special Windows-only tasks that use win_stat to convert our internal Unix-style paths to Windows-style paths, which match those discovered by the win_find module.
Normally, the Molecule idempotency test would have caught this error, but as Molecule testing on Windows is basically impossible (:crying_cat_face:), it seems to have slipped through the cracks.
This PR also includes similar path conversion tasks when creating the Windows service, and also fixes a bug where a Windows handler was erroneously called from a task with become: true (probably this one), which caused an error on Ansible since become isn't supported in PowerShell, at least not without extra properties.

FYI, I have rebased this branch, squashed, and resolved all merge conflicts.

Ping @bbaassssiiee

Please resolve the conflicts (rebase is not possible now)

@bbaassssiiee Done!

@bbaassssiiee Thanks for the merge!


Make iOS touch interactions feel more native

Right now everything feels webby and not native. We can improve this with a few things:

Make the -webkit-tap-highlight transparent.
Handle touchstart as click or use the touchstart trick as seen e.g. in LeadLine.
Fix animation jitters.

@adamschwartz,
This one was something else! 😅
It seems fixed position elements and iOS Safari don't play well. The fix involved switching to a position absolute container for small screens and a few viewport tricks. The heaviest part of these fixes is the tracking of the body's scroll state. Safari loses this when setting overflow hidden on the html element. Unfortunately this seems to be the patch that satisfies the collection of jitteriness and behavior bugs we've encountered.
The commit that closes this issue addresses all but the touchstart click feature. I've tried the feature on a dev server with mixed success.
If the user scrolls the search list with their finger over a entry, it will momentarily highlight.
If the highlight occurs during a transition between screens, It's often accompanied by a slow down.
Cheers

I’ll admit the ticket wasn’t well-defined, but we’re not out of the woods just yet. Looks like the animation jitters are better but there’s still the other two bullets.


[Bug] Error: Provider produced inconsistent result after apply

Describe the bug
Summary of the issue
On terraform apply a machine catalog is created but an error is thrown.
"Error: Provider produced inconsistent result after apply.  When applying changes to citrix_machine_catalog.DaaSMachineCatalog, provider "provider["registry.terraform.io/citrix/citrix"]" produced an unexpected new value: .provisioning_scheme: inconsistent values for  sensitive attribute. This is a bug in the provider, which should be reported in the provider's own issue tracker."
Versions
Terraform v1.7.5
on windows_amd64

provider registry.terraform.io/citrix/citrix v1.0.1
provider registry.terraform.io/hashicorp/azurerm v4.0.1

DaaS
Log File
citrix-provider-issue.txt

Apply and destroy commands seem to work as expected.

Thanks for reporting the issue and attaching the logs. Looking at the logs it seems you are using Azure image gallery on a shared subscription. There is a bug in v1.0.1 with shared subscription: #117
We'll have a fix in our next release which should be out soon!

This should be fixed now, please let us know on #117 if there's still a problem.


BTC to RUNE shows invalid pair

Overview
Users trying to trade BTC into RUNE using ThorChain are unable to continue due to an "invalid trade pair"
Recreation Steps:

Go to the trade page
Input BTC to RUNE trade
Notice a red "invalid trade pair" button

References and additional details
N/A
Acceptance Criteria
Users should be able to trade BTC into RUNE.
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

closed by https://github.com/shapeshift/web/pull/3926


Add tag to git settings within the flux provider

Similar to how the provider supports specifying a branch, allow for a tag to be specified:
provider "flux" {
  kubernetes = {
    ...
  }
  git = {
    url = "some_url"
    tag = "1.0.0"
    ssh = {
      username    = "git"
      private_key = tls_private_key.flux.private_key_pem
    }
  }
}

The issue with the current resource is that it applies the manifests and commits them to the repository. Could you explain your use case why you would need this?

Hi @phillebaba sorry I missed your response from March - In our production clusters, we have flux syncing with a tag from a git repo, not a branch. We accomplished this in the "legacy" terraform setup by specifying a tag in the flux_sync data source. There is not way to currently do this in the new terraform resource flux_bootstrap_git. It seems to me that the flux provider specification is defining where flux should watch to sync from, and therefore we would need a tag parameter defined there. If there is another way to accomplish this - please let me know.

The issue is that the new resource is not only bootstrapping the cluster but also committing the files to the Git repository. Meaning that the commit hash is is syncing from is fluid. If support for a tag were to be added the tag would have to be moved every time the resource makes a change in git. I don't see why you could just not use the resource as is and have it sync from the main branch?

Creating extra GitRepos after bootstrap is not in scope for Flux TF provider. Use the Helm TF Provider with https://artifacthub.io/packages/helm/fluxcd-community/flux2-sync

@phillebaba we can't just have it sync from main because we safeguard our code release to production with a tag - i have to imagine that this is a common use case among flux users

@stefanprodan do you have a recommended install pattern documented somewhere?
Is the recommended approach to use this resource to bootstrap the cluster & and only use the gitrepo that is created to maintain the flux resources itself?

I do not know of any documentation for the CLI bootstrap that would solve this. The goal of the provider is to support the same features that the CLI does for the bootstrap feature. Anything that false outside of that would be very difficult for us to support.

@stefanprodan do you have a recommended install pattern documented somewhere?
Is the recommended approach to use this resource to bootstrap the cluster & and only use the gitrepo that is created to maintain the flux resources itself?

Hi Jamie,
Terraform bootstrap resource is an IaC equivalent of this - https://fluxcd.io/flux/installation/bootstrap/generic-git-server/#ssh-private-key
as it will update Git repository in specified branch with GitOps ToolKit (gotk) manifests (similar to this content

https://github.com/fluxcd/flux2-kustomize-helm-example/tree/main/clusters/staging/flux-system ) - tags just won't work.

Once flux-system namespace manifests will be configured and FluxCD controllers running - you are free to extend the configuration with Kustomisations and GitRepository resources stored in same folder you specified in the path parameter of flux_bootstrap_git Terraform resource, see docs here https://fluxcd.io/flux/guides/repository-structure/#repository-structure-2 and good examples provided here : https://github.com/fluxcd/flux2-kustomize-helm-example/tree/main/clusters/staging

@stefanprodan I feel like this issue can be closed.


"Cache-Control: public, max-age=0" is set by default

Hello,
I am using this module for a while and I encountered the following problem. I cannot remove the Cache-Control header. It is always set by default to some value. I noticed that this behaviour comes from:
if (!res.getHeader('Cache-Control')) {
  res.setHeader('Cache-Control', 'public, max-age=' + Math.floor(this._maxage / 1000));
}

I managed to make a work-around with the "on-headers" module, mentioned in issue https://github.com/expressjs/serve-static/issues/5 which looks like this:
var onHeaders = require('on-headers');
onHeaders(function() {
  this.removeHeader('Cache-Control');
}

But this approach looks pretty sketchy. So the question is  why can't this be configured somewhere in the options, because after researching Apache and Nginx I saw that they don't add the Cache-Control header by default and I want to accomplish that behaviour. Besides it looks like the right approach to me because after looking at the HTTP1.1 spec I found:

Unless specifically constrained by a cache-control (section 14.9)
directive, a caching system MAY always store a successful response
(see section 13.8) as a cache entry, MAY return it without validation
if it is fresh, and MAY return it after successful validation.

So, it seems that is up to the Content Delivery Networks (Akamai, etc) to decide whether something is cachable by default. So is there a reason for forcing the Cache-Control by default in this module?

But this approach looks pretty sketchy. So the question is why can't this be configured somewhere in the options, because after researching Apache and Nginx I saw that they don't add the Cache-Control header by default and I want to accomplish that behavior.

Hi @SVasilev, sorry no one else has dropped by! The current way does work, yes. Not sure what is "sketchy" about it, though. But we can certainly add a better API to prevent this module from setting a Cache-Control header.

So is there a reason for forcing the Cache-Control by default in this module?

The reason it is there by default is because the default behavior is extremely undefined. Your assest may or may not get cached by an intermediate, it may or may not get cached by the end user, and even then, who knows how long it will be cached for? Different CDNs, web browsers, etc. have different default rules, since there is no specification that outlines any default rules. By always providing a Cache-Control you take almost all the gues work out of it. Apache & nginx are more bare-bones than this module is out-of-the-box, so it makes sense that we provide more features out-of-the-box here.
I would hightly recommend you re-consider not sending a Cache-Control, because you'll no lnger have any idea what is caching your assets and for how long.
Regardless we can make a better API to turn off the header :)

Hi and thanks for replying. It is sketchy because the "on-headers" module relies on Node.js implementation which may change anytime. Would you be interested in a pull request to provide option to control the Cache-Control behavior?

It is sketchy because the "on-headers" module relies on Node.js implementation which may change anytime.

Pretty much everything "relies on Node.js implementation which may change at anytime", so i.m.o that's not a good reason. Besides, that module is part of an organization of folks working to ensure that if something does break, it is quickly fixed, and all it really does is replace res.writeHead, which is a public API (https://nodejs.org/api/http.html#http_response_writehead_statuscode_statusmessage_headers) in a stable API.
This module, on the other-hand, relies to on-finished, which is one that truly uses un-documented APIs and is very likely to break on Node.js changes. If that is your concern, I would not use this module.

Would you be interested in a pull request to provide option to control the Cache-Control behavior?

I would be, absolutely! I have been thinking about this, and would have actually made the change already, but cannot think of a good API that does not have options that exclude one another. For a higher chance of getting a PR accepted, you may want to discuss what you're thinking the API for send would be with your change first :)

Approach 1:
If maxAge property has a value of -1, then Cache-Control header is not set.
This does not look very intuitive but still a possible solution.
Approach 2:
Add another property: "cacheControl" with type boolean. By default it is true.
If set to true the Cache-Control header won't be set, maxAge property is ignored if present.

Thanks! Approach 1 is not backwards compatible, as we currently accept, without error, negative numbers and just treat it like 0.
The other two looks like you didn't see the requirement:

a good API that does not have options that exclude one another.

We could do approach 3, without the backwards compatibility part, in the next major, which should come out dome time this year. Or maybe just in the next major have maxAge accept null which does not output the header?

@dougwilson what does "one another" refer to in your statement "a good API that does not have options that exclude one another"?
We are used to using false for instructing "don't use", null will feel odd and inconsistent.
How about modifying approach 3 to this:

Cache-Control is disabled by default
It is turned on by setting the desired value to the cacheControl property in the options object.

?

Hi @hacksparrow, it means you don't have an API where you have { option1: true, option2: 'my value can be literally anything since it is ignored when option1 is true' }.
The Cache-Control didn't used to exist a long time ago in Express. It was added because it is absolutely terrible practice not to have it, and it's what makes this module more feature rich than simply using native Node.js APIs to serve your files up. This was added from dozens of requests, and one since request in over 3 years won't just make the default go away like that. Maybe if there are dozens of people clamoring to make it go away, just like there were to get it added, I would reconsider, but that is not the case here.
Either having this header by default is not hurting anyone, people just deal with it, or worse: it is genuinely useful to have & people love it and one person is about to bring this crashing down back to the era of issues.

So, in conclusion should I start implementing approach 3 without the backwards compatibility part?

@SVasilev at this stage, it will be difficult to make changes to the API. You could continue using on-headers.

For the time being, we'll simply be adding a cacheControl option that is a Boolean you can set to false to not send this header. The maxAge option will be ignored until we implement a better API and deprecate that option.


Use passed algo when importing private key

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 I'm seeing the same failure locally as what travis reports.

This failure might depend on the Chrome version and not on this code change. I'll merge this now, thanks for the contribution!


Verifying bots?

I was wondering if the library has any way or plans to incorporate functionality of validating bots? Some of the bots (e.g. Google Bot and Bing Bot) offer a way to ensure that client is really the bot itself and not someone changing their UA.
This functionality will be very useful when doing some SEO optimizations (e.g. disabling dynamic pagination for bots or allowing them to see more results at once).

One way to achieve this would be to perform a reverse DNS lookup of the client's IP address and see if the result is a known domain for the given bot user agent.  This could be slow (although you could of course cache the results), and still doesn't 100% guarantee that an IP address hasn't been tampered with (although the overall 'bot confidence' would be a lot higher).
Practically speaking (using your example above), is it the end of the world if a UA has been manipulated?

I would see that as an option, like "strict verify", not as a default. Caching results should be a requirement I think, since when you have IP it shouldn't change. This will eliminate problem with missconfigured resolver in host OS.
Speaking about tampering with IP it's as trusted as DNS is. If you cannot trust DNS on your server you have a bigger issue I think :)
It's not end of the world, however it poses more business risk. For trusted bots we can whitelist some restrictions which are put in place to prevent abuse (e.g. captcha for extensive page visits which looks automated).

The strict mode makes sense - I also take your point on the DNS server ;-)
If the lookup functionality is hidden behind an interface, then adding specific DNS servers, caching or even an in-memory dictionary (for testing) would be quite trivial. I maintain the C# port of this library, so I'll see if I can find time to add it there in the next few days and back-port it here - unless you have some php ready to roll :-)

I cobbled something together, but I'm not sure how useful it's going to be.  For the larger bots like googlebot and bingbot, the lookup approach will work well, but for some of the lesser known ones (like Zauba, which runs on AWS), the reverse lookup is going to be misleading.
This may be ok for a strict mode (since it's. well. strict!) - but if the use case is for preventing abuse, then throttling may be a better solution...

We've discussed IP checking in the past but came to the conclusion this is not something we would like to maintain in this repository. Although, a good implementation of verifying the larger bots like you mention in the first post would be worth a look at. Am open to PRs on that.
Wouldn't mind seeing your cobbled together code @gplumb perhaps you could stick it on a PR as a starting point to discuss this further 👍


Add enviroment validation at server startup phase

What problem does this PR solve?

Validate the Python version should >= 3.11
Download nltk data

Type of change

[x] New Feature (non-breaking change which adds functionality)
[x] Refactoring

CI is blocked. https://github.com/infiniflow/ragflow/actions/runs/11815605841/job/32917109032


[DO-NOT-MERGE] GHA Windows failure in drools

Enable the issue

Re-investigating https://github.com/apache/incubator-kie-issues/issues/684

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

for pull request checks
Please add comment: Jenkins retest this

for a specific pull request check
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests

for a full downstream build

for jenkins job: please add comment: Jenkins run fdb
for github actions job: add the label run_fdb

a compile downstream build please  add comment: Jenkins run cdb

an upstream build please add comment: Jenkins run upstream

for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch

for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch

for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main

for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main

for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts

for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts

for native checks
Run native checks
Please add comment: Jenkins run native

for a specific native check
Run native checks
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native

for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts

for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Reproduced the error
2023-11-27T03:01:52.3028049Z [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project drools-decisiontables: Error while storing the mojo status: Input length = 1 -> [Help 1]
2023-11-27T03:01:52.3030138Z org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project drools-decisiontables: Error while storing the mojo status
...
2023-11-27T03:01:52.3078236Z Caused by: java.nio.charset.UnmappableCharacterException: Input length = 1
2023-11-27T03:01:52.3078889Z     at java.nio.charset.CoderResult.throwException (CoderResult.java:275)

@mariofusco Please merge this PR, thanks!


[Doc] Update readme links due to repo move

What is the purpose of this pull request (PR)?
Repo move
Any background context to help the reviewer?
Was this PR tested and how?
Does this PR resolve an open issue (reference issue #)?
Fixes issue or JIRA tasks:

More Questions:

Does the knowledge base need an update?

Does this PR add or change dependencies?

Does this PR change or fork the blockchain

Sorry closed your commit as I hadn't noticed you moved the entire repo.

Closing again as I have reopened the Silk Network repo


Folder name "aux" causes problems on Windows

Hi Guys,
Is it possible to rename the folder name "aux" to another name instead? It causes some problem on Windows OS during git operation. Thanks a lot!
There is similar problem found in other repo, see here for an example: https://github.com/swcarpentry/DEPRECATED-bc/pull/464/files

Done, let me know if it still does not work


Edit Glossary.md

Ok. The only thing I have a question about then is why the word Flow is
capitalized.
On Tue, Jan 3, 2023, 12:18 PM Erik Sapir @.***> wrote:

@.**** commented on this pull request.
In docs/glossary.md
https://github.com/trywilco/wilco-docs/pull/42#discussion_r1060444099:

+- FlowNode: A step or a trigger that is recognized as a series of actions and conditions.
+- Flow: A series of FlowNodes

Thanks for the suggestions!
Actually the original definition is the correct one. a FlowNode is an
element in a larger Flow that is executed when a step starts or when a
trigger associated with the step is recognized. We don't really use Flow
as a term throughout the docs.
—
Reply to this email directly, view it on GitHub
https://github.com/trywilco/wilco-docs/pull/42#pullrequestreview-1234340428,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO2GVZATT2IEBANZBCPGUBDWQP4ILANCNFSM6AAAAAATPQVJIM
.
You are receiving this because you authored the thread.Message ID:
@.***>


fix codelyzer linting

These rules can't be used for now. See https://github.com/ng-be/app-ng-be-org/issues/5#issuecomment-252502047 for more info.

seems to be fixed :p
https://github.com/mgechev/codelyzer/issues/107


Invalid HTML is generated when inline HTML tags are nested

Repro
Save the following content as input.md.

Foo

Then run
cargo run input.md

Expected behavior
I expected the following HTML output:

Foo

Actual behavior
Actually the following broken HTML output was generated:

Foo

Events
Events emitted by the Markdown parser was:
$ cargo run -- -e input.md
0..13: Start(Paragraph)
0..6: InlineHtml(Borrowed(""))
6..12: InlineHtml(Borrowed(""))
0..13: End(Paragraph)
14..18: Start(Paragraph)
14..17: Text(Borrowed("Foo"))
14..18: End(Paragraph)
19..34: Start(Paragraph)
19..26: InlineHtml(Borrowed(""))
26..33: InlineHtml(Borrowed(""))
19..34: End(Paragraph)
EOF

Additional information
When removing outer , it works as intended because the  and  lines are parsed as HtmlBlock.

Foo

Environment

Rust: 1.78
pulldown-cmark: 8713a415b04cdb0b7980a9a17c0ed0df0b36395e

Although it may be confusing, this is intentional behavior in the spec. A tag on a line by itself followed by a blank line is considered an HTML block (see clause 7). The bare  and  is treated as two separate block HTMLs.  When you have two , that is treated as inline raw HTML. Those are treated as being within a paragraph. After the blank line, that ends the paragraph, thus causing the close tag.

@ehuss Thank you for the point. I read the spec and understood that this is intended behavior.
Though I understood the parser works correctly, I wonder the HTML generator needs to be fixed not to output a broken HTML code. I believe this can be done by:

Adding missing closing tags
Remove closing tags without opening tags

If we apply these rules to the example above,

Foo

this code is generated. Though it would not be an expected output, it is still not broken as HTML.

I think cleaning up the HTML is out of scope for pulldown-cmark. It is very hard to do correctly, and the default HTML renderer's output is tested against the CommonMark spec.
You could use a separate library for this, such as html5ever.

I tried ammonia and it turned the broken HTML output into a valid HTML source. I'll adopt it. And I understood that this was out of scope of this crate. Thank you for the clarification.


Auto-detect existed models to avoid duplicate download (manually refresh is terrible)

I copy the models to another directory due to some issue, then reinstall Runner.
When restoring the models directory, the runner can't detect the change.

👌

fixed in v1.3.5


fix(float-field): should work with codegen

:tada: This PR is included in version 1.32.12 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Logo Idea

Coverage remained the same at 96.081% when pulling d2d69cc0144bc7dc765a02c7fb2b115f7bb48106 on malimichael:master into e1a4c539d1fc29cfaae11175f53aff3f648b3d4f on Vincit:master.


Cannot specify NWB file at command line

Minor issue: when attempting to open the GUI at the command line by providing a file path string, the user is still prompted to choose a file. Works fine once you select a file in the GUI.
For specificity, here is the exact command:
python ecog_vis.py '/path/to/data/EC125_B22.nwb'

@jrliu95 thank you for pointing that out.
Just corrected it, it should be working now!


Deprecate LocationLayerPlugin

Refs https://github.com/mapbox/mapbox-gl-native/pull/12786.
This ticket tracks deprecation of the LocationLayerPlugin that will happen when the LocationComponent is released in the Maps SDK v6.6.0.

/cc: @mapbox/maps-android @lilykaiser @chloekraw

will happen when the LocationComponent is released in the Maps SDK

May I suggest we call it LocationManager to match the naming we use on iOS?

By looking at the iOS docs, it seems the actual name for this type of functionality is MGLUserLocationAnnotationView. If so, UserLocationAnnotation (or simply LocationAnnotation) probably is a better name which improves consistency across platforms but I'm open to other options.

Browsing through that doc it looks like in the iOS world the MGLUserLocationAnnotationView is just a view. The camera tracking and location management functionality seem to be embedded into the map. What we are proposing is something that exposes all of those things separately from the map, but since there already is a concept of LocationManager on iOS which has an equivalent in LocationEngine on Android I opted for LocationComponent to indicate that all methods used to display and manipulate the location are enclosed in the component.
At this point, I'd propose sticking with the name, but that's still up for debate.

For future reference and for folks looking for functionality similar to the one provided by the Location Layer Plugin: we've integrated this API into our core Maps SDK and this is now available without requiring any additional plugins. Up to date documentation is available here: https://www.mapbox.com/android-docs/maps/overview/location-component/


README: add a project status

Aww, too bad. :( I really liked the simplicity compared to other solutions. But I also ran into problems, so I guess it's the right call, given the missing progress.


Footer enhancement

The footer right now is very simple and the elements are aligned on the left , I would like to enhance the footer and therefore make it look more better.
Therefore i request the project admin @singodiyashubham87 to assign me this issue and label under GSSOC.
Thanks in advance!

Hello @aaryaparadkar
Provide a screenshot of what will you enhance.

I would like to enhance this footer by properly aligning and make it look more visually appealing.

Hey @soumya-maheshwari @singodiyashubham87 I have already worked on this issue, I can fix this easily, please assign this to me.

Hi @singodiyashubham87 !! I could enhance the footer design in a very user appealing way, plz do assign me with this issue!!

@aggrhythm Under which program do you want to work on the issue GSSOC or SSOC?
@Tanishka023 @BhumikaRahwani This issue was raised by Rytham, So I can't assign someone else until she is ready to resolve the issue.

@aggrhythm Assigned you the issue, Best of Luck :)

@Tanishka023 @BhumikaRahwani Kindly explore other issues.

I would like to design footer in better way, I will allign the icons in better way, Please assign me this issue under GSSOC'24.

hello, please assign this issue to me under GSSOC'24.


[fix] Revert st back to ecstatic.

Revert "[fix] update st"
Revert "[minor] Made options.index and options.dot configurable in static plugin"
Revert "[fix] Update 'st' with using passthrough option"
Revert "[fix] Fix undefined 'url' for static plugin"
Revert "[minor] Rename 'ecstatic' plugin as 'static'"
Revert "[minor] Use isaac's st instead of ecstatic"

Closing this due to age. This project is formally deprecated. Will be adding a notice soon.


Export type definitions + add schema to root project dir

Codecov Report

Merging #3 into master will increase coverage by <.01%.
The diff coverage is 95%.

@@            Coverage Diff            @@
##           master      #3      +/-   ##
=========================================
+ Coverage    99.4%   99.4%   +<.01%
=========================================
  Files          80      81       +1
  Lines         840     844       +4
  Branches       10      10
=========================================
+ Hits          835     839       +4
  Misses          4       4
  Partials        1       1

Impacted Files
Coverage Δ

src/index.ts
100% <100%> (+4.76%)
:white_check_mark:

src/wp-graphql.ts
94.73% <94.73%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2875f8...727ef2d. Read the comment docs.


Add docker useful alias

Docker is a tool that can be used to build applications, provide standardized environments for development, testing and production, isolate dependencies, and more. More and more people are using docker as their daily testing or develop. Add more alias help to save time to type commands.

@ColinHuang This needs to be rebased, and plugins/docker/_docker should be removed from the PR, since it has been updated in #5060.

This is outdated since I submit PR almost two years ago.


Fix dockerfile link in generating-a-provider doc

Description of your changes
The link for Dockerfile code example in docs/generating-a-provider.md points to a non-existent file (Changed in this commit ). Changed the link to point to the correct file and code section.
I have:

[x] Read and followed Crossplane's [contribution process].
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

Thank you for the fix @tomkingchen. Could I ask you to please sign the CLA before I can merge this PR: https://cla.upbound.io/upbound/upjet


NamedTemporaryFile error in windows

The bug
NamedTemporaryFile usage results with "PermissionError: [Errno 13] Permission denied:" error.
To Reproduce
Steps to reproduce the behavior:

Run tests in Windows 11.

Environment

Windows 11
Python Version: tried with 3.8 and 3.11

Windows user names with blank spaces create a problem since the Windows path is converted to something else in the way. I will create a Temp folder directly before the user folder, as C:/Temp if the OS is Windows.
rdflib library has a bug for which I created an issue.


Add CMAKE_INSTALL_PREFIX to noble github workflow

🦟 Bug fix
Summary
Update the installation prefix path so that the INTEGRATION_log_system test is able to find the installed files.
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

CI is green. Merging this into the 8 -> main forward port PR.


Made clear we only test on Linux.

🚀 Pull Request
Description
Updated the documentation to make clear that the testing we do is based on Linux (and not Windows or macOS).
I'm leaning to not create a what's news for this minor change.  If you think otherwise please comment.

Consult Iris pull request check list

I'm leaning to not create a what's news for this minor change. If you think otherwise please comment.

I certainly wouldn't insist on it. It's something I personally like to do since I find it informative to see just how many iterative changes we make between releases, and I hope that it makes users realise how hard we work even if we haven't addressed a particular concern of theirs.


etcd: try put again when ch had closed

Hello,
can you provide more information about the problem that solve your PR?

@ldez etcd lease will expire when there is a problem with the network or etcd server that more than keepalive ttl.
the ch will close when keepalive had a problem, maybe it's better to try to put until the network or etcd server is ok

1.put(key, value, opt.keepalive=true) to etcd
2. kill etcd server
3. wait for 30s
4. start etcd server
problem:
5. the key will not exist in the etcd server
expect:
5 the (key, value) will put again in etcd server

@ldez should i provide more information?

I think it's not the right solution to implement a naive retry.
The topic needs to be dug more.
Hello,
We changed the core system of Valkeyrie: now the stores have dedicated repositories.
The new repository for etcdv3: https://github.com/kvtools/etcdv3
I recommend creating an issue about the topic in this repository.

@ldez

@ldez
thank you for your reply
but if the keepalive channel is closed the key will expired later
the put caller need run a new more goroutine to check the key is expired


chore: Bump Sentry Cocoa SDK version to 7.21.0

This version introduces fixes to false positives of OutOfMemory errors in simulators:
Fixes: #15
Related: https://github.com/getsentry/sentry-cocoa/pull/1970

See https://github.com/getsentry/team-mobile/issues/7#issuecomment-1194475274
Maybe @vaind can help us to automate that :)


Added ADU model file.

Thank you for contributing to the IoT Plug and Play Models repository
:memo: Please review this checklist before submission

[ ] :eyes: The models submitted in this PR follow the DTDL Naming Guidelines for contributing to this repository.
[ ] 🕵I have validated the models locally using the dmr-client command line tool.
[ ] ❗ I understand once the PR is approved, the models are considered immutable: any edits will require to submit new files.
[ ] ✨ When creating a new top level dtmi:namespace, I have completed the PR Info Template below.

:zap: PR validation steps are described in the tools Wiki.
PR Info Template
When submitting models to the repository we ask that you provide as much of the following meta information around your models and related devices as possible. This info will be used to improve the IoT Plug and Play ecosystem.
👇: Please replace the markdown comment examples with your own values.
Company Info

Info identifying your company (if applicable).

IoT Plug and Play Device Info

Info identifying your device.

Model Submission Goals

Info related to broader submission goals.

Code Owners & Reserved Names

Indicates GitHub alias entries to be added to the repo CODEOWNERS for the incoming model namespace. The codeowner is expected to be involved in subsequent DTDL model submissions against the same namespace.

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact<EMAIL_ADDRESS>with any additional questions or comments.

Hey @bo-ms, this repo does not allow edits to existing models, to add the ADU interface you should update the version (including the @id and filename) to 3.

Hi @rido-min I just added version 3 to support adu, please check again, thanks. https://github.com/Azure/iot-plugandplay-models/pull/463


added program code to mitxpro staging courses table

What are the relevant tickets?
https://github.com/mitodl/hq/issues/2425
Description (What does it do?)
The program code field(program_code) has been added to the mixpro courses staging table(stg__mitxpro__app__postgres__courses_course). This field is used by finance for reporting purposes and should be added to Tableau eventually to facilitate self-service reporting for that team.
How can this be tested?
dbt build --select +stg__mitxpro__app__postgres__courses_course

I've optimized it to 4 lines so I'm going to merge it


[Fabric] Permissions data for user was not loaded during the pre-login stage

Description

When you try to join a Fabric server through BungeeCord/Waterfall using FabricProxy, LuckPerms does not allow that login because player's data couldn't be loaded during the pre-login stage.

Reproduction steps

Create a Fabric and a BungeeCord/Velocity server
Put FabricProxy (only on Fabric server) and LuckPerms as mods
Try to log in to the server and you'll see the error in the console.

Expected behaviour

A successful login was expected.
Environment details

Server type/version: Fabric running version 1.16.5 loader 0.11.1 and using Fabric API 0.30.0
FabricProxy version: v1.4.6
LuckPerms version: v5.2.99

Startup log and login try
Any other relevant details

I have also tested this using online-mode and Velocity and the same error occurs. I also saw similar closed issues but didn't help. I'm using everything up to date.
Also tested with FabricProxy-Lite (1.0.1)

Please try again using LP v5.2.100 or newer (https://luckperms.net/download) & ensure debug-logins is set to true in the LP config.
If the issue still occurs, please could you provide console/log output again :)

Hello!
I won't be able to test it until tonight, sorry for that. I'll answer you as soon as I can.
Thanks for your quick answer!

Hi again.
I have tested LP v5.2.101 on BungeeCord but the issue wasn't fixed. Here you have the console output.
[21:56:39] [Server thread/INFO]: Kikisito[/<IP_ADDRESS>:55490] logged in with entity id 217 at (253.5, 70.0, -156.5)
[21:56:39] [Server thread/INFO]: Processing login for 31c7be0d-89fc-401e-9d16-bafca8739984 - Kikisito
[21:56:39] [Server thread/WARN]: User 31c7be0d-89fc-401e-9d16-bafca8739984 - Kikisito doesn't currently have data pre-loaded - denying login.
[21:56:39] [Server thread/INFO]: Kikisito joined the game
[21:56:39] [Server thread/INFO]: Kikisito lost connection: [LP] Permissions data for your user was not loaded during the pre-login stage - unable to continue. Please try again later. If you are a server admin, please check the console for any errors.
[21:56:39] [Server thread/INFO]: Kikisito left the game

If you're not seeing a log message saying "Processing pre-login..." then Fabric's ServerLoginConnectionEvents.QUERY_START event is not being fired.
This not not an issue that can be caused by LuckPerms itself, and is either an issue with Fabric or another mod.
Sorry, not much more I can do to help.

Hi again.
Thanks for your answer. I've been still trying to see what was happening for this and switched again to Velocity. I forgot to test the build using this proxy before (i'm really sorry for that), and the console output is different.
[18:48:07] [Server thread/INFO]: Processing pre-login (sync phase) for 859a0db5-6499-3552-96ea-c8543a67ff75 - Kikisito
[18:48:07] [ForkJoinPool-4-worker-59/INFO]: Processing pre-login (async phase) for 859a0db5-6499-3552-96ea-c8543a67ff75 - Kikisito
[18:48:07] [Server thread/INFO]: Kikisito[/<IP_ADDRESS>:62988] logged in with entity id 188 at (253.5, 70.0, -156.5)
[18:48:07] [Server thread/INFO]: Processing login for 31c7be0d-89fc-401e-9d16-bafca8739984 - Kikisito
[18:48:07] [Server thread/WARN]: User 31c7be0d-89fc-401e-9d16-bafca8739984 - Kikisito doesn't currently have data pre-loaded - denying login.
[18:48:07] [Server thread/INFO]: Kikisito joined the game
[18:48:07] [Server thread/INFO]: Kikisito lost connection: [LP] Permissions data for your user was not loaded during the pre-login stage - unable to continue. Please try again later. If you are a server admin, please check the console for any errors.
[18:48:07] [Server thread/INFO]: Kikisito left the game

When using Velocity, the event seems to be fired as some log messages regarding pre-login are shown. Should I report this to Velocity?

@lucko we're seeing exactly the same thing with velocity+fabric

As you can see from the log, the pre-login event is being called with the UUID 859a0db5-6499-3552-96ea-c8543a67ff75 (looks like the offline mode UUID) and the login event with 31c7be0d-89fc-401e-9d16-bafca8739984 (looks like an online mode one!).
Both UUIDs should be the online one - this is most likely an issue with the mod which is providing Velocity support.

Thanks again for answering and for your help. I'll report this to the author of FabricProxy as it seems the issue comes from here. Have a nice day.

This issue has been solved with the last version of FabricProxy-Lite (https://github.com/OKTW-Network/FabricProxy-Lite/issues/1). I leave the link here if somebody needs info about this.


run in background after closing the window?

No description provided.

I tested on Debian 12 and NO. After clicking on the close icon, it is completely closed.

What about :
https://github.com/getlantern/systray

What about : https://github.com/getlantern/systray

It's incompatible with Wails to due to some weird linking issues.


simplify logic

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage increased (+1.03%) to 84.906%

Files with Coverage Reduction
New Missed Lines
%

src/contractions.jl
8
85.19%

Totals

Change from base Build<PHONE_NUMBER>:
1.03%

Covered Lines:
270

Relevant Lines:
318

💛  - Coveralls


Running cops in parallel

As we add more and more checks the performance naturally regresses a bit. Luckily the things we're doing are pretty parallelizable - we can simply split the cops into 3 groups, run them in 3 threads and just merge the results in the end. Even though Ruby's threading is not exactly its strong suite I still think we might be able to get some benefit out of this.
JRuby is inching closer to supporting Ripper(https://gist.github.com/enebo/4548938) and there the performance boost should be even bigger.
This issue is here mostly for discussion purposes. If anyone has the time to run a few simple experiments with basic parallelization and share the results that'd be great.

Any chance of reopening this? One of my projects has ~2300 files. It takes around 2 minutes to run Rubocop currently with our configuration on my 2.6 GHz Intel Core i7 Macbook Pro, and only using one out of 8 cores seems suboptimial.

Is there any interest in revisiting this? Our codebase has around 1,600 files to check, and writing a quick script to split the file list into several groups and check each group in a separate process roughly halves the time it takes to check our codebase (1m30s down to 45s).

@jcoglan What about the caching mechanism introduced in v0.34.2? Doesn't that solve your problem?

@jonas054 Yes, I've tried that now and it makes a huge difference. Thanks :)

Any chance of revisiting this decision?
$ rubocop --version
0.44.1
$ rubocop -L | time xargs -P`sysctl -n hw.ncpu` -n250 rubocop -a
...
      221.84 real      1473.85 user        21.34 sys
$ rubocop -L | time xargs -P`sysctl -n hw.ncpu` -n250 rubocop -a
...
      216.42 real      1469.30 user        20.55 sys
$ time rubocop -a
...

real    11m57.188s
user    11m43.502s
sys     0m11.112s

On our codebase it only takes 3.5 minutes to run 8x in parallel but it takes 12 minutes to do it serially. I'm sure with inbuilt support for parallelizing it can get even better.

Adding built-in support for parallel execution requires a lot of changes. If this wasn't the case we would have done it by now. :-) Frankly, I doubt we'll every get there - I'm certainly not eager to work on this myself.


Right-clicking injected text caused funny selection

don't use edit context
have injected text like ghost text or inlay hint
right click on them
the element gets weirdly selected (not the editor selection but like a native dom selection)

https://github.com/user-attachments/assets/85f2396b-97c3-48ba-8e82-b9e6eb866f21

I ran npx @vscode/vscode-bisect and it reports that all Insiders builds are bad. I then ran it with npx @vscode/vscode-bisect --releasedOnly and it also reports that all Insiders builds are bad. I don't know what's going on, but I don't think this regressed recently.


Encode speedup, yajl_string_encode runtime cut from 150 ms to 100 ms

I've done some profiling of an application of mine that uses yajl, and yajl_string_encode was consistently the most cpu intensive part of yajl.  These 2 commits cut the total time spent in and below yajl_string_encode from ~150 milliseconds to ~100 milliseconds or so.

this is beautiful!  I'll give it a profile.

great! let me know if you see any issues or have any questions

merged into the 2.1.0 branch.  I expect to release this week.  Notice 52c559dafce0e9f5b9b54e1dfe893bd3bd9d4873 - I added a synthetic in-tree benchmark for serialization and this confirms your performance improvement.
Nice work, and thank you.

oh the benchmark is quite nice.  thank you for the great library


deps: Upgrade packages (flutter pub upgrade)

I ran flutter pub upgrade, then updated the CocoaPods lockfiles. This required some fiddling; ultimately the commands were:
( cd ios && pod update sqlite3 )
( cd macos && pod update sqlite3 )
flutter build ios --config-only
flutter build macos --config-only

Without the pod update commands, there was a misleading error message claiming the problem was that one pod required a higher minimum deployment target than another. Much like in 0dbc0c06d.
I also ran flutter pub upgrade --major-versions, but it didn't make any changes.

Tested on my iPhone and the office Android device, and things seemed fine.

Thanks for taking care of this! LGTM; merging.


[Feature request]: Add support for setting video type store to NAS

Describe the solution you'd like
Add support for setting the video type to store to NAS as shown in the Eufy app:

(Example from T8400 but it applies to other Eufy cameras with RTSP support)

@bropat FYI, I can try working on this if you point me in the right direction. As you know, it’s something the app allows today.

How is this different than enabling rtsp?

@fuatakgun Once you have RTSP enabled, you can select how it behaves as you can see in the screenshot: either stream when an event happens or stream 24/7. Options vary based on the camera you have, but the screen is available for all cameras supporting RTSP.

i see, i have checked this screen in detailed for battery operated cameras and they don't support continues stream. I thought it is the only option, understood now, thanks

@fabianluque
Has already been implemented in the next version.

Thanks @bropat! Really appreciate your work and effort!


minor fix typo in build.sh

Proposed changes
Introduced from #20740
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Release Google.Cloud.Run.V2 version 2.12.0

Changes in this release:
New features

Support manual instance count in Cloud Run for manual scaling feature (commit aa9150c)

Created release for Google.Cloud.Run.V2-2.12.0


KAFKA-2990: add explicit ConcurrentMap type annotation to fix NoSuchMethodError in Pool

In my opinion, this is not a bug. There is no guarantee that compiling with 1.8 will work when executed with 1.7. Having said that, it's a tiny change and could be justified on its own merits (ie expose the interface, not the implementation). So LGTM.

LGTM

Can you fix the PR title though? There is no cast in your code, just a type annotation (casts are unsafe, type annotation are not).

@ijuma I saw these errors when running ducktape tests, so if we're not supporting it, then we should make sure that ducktape vms use 1.8 jdk when running tests.

@hachikuji, you're supposed  to compile Kafka with Java 7 (and you can run with both 7 and 8, 8 recommended).

@hachikuji @ijuma This is something that we check in build.sh in muckrake, but which I don't think is validated anywhere for kafka tests because we just assume the version built in the checked out copy will work, but the VMs install JDK7.
We should probably add validation of of the build version of java somewhere. I think 7/8 issues have happened a few times. I just always stick to the minimum Java version supported, which also prevents accidental use of newer libraries during development, but I know not everyone likes doing that. Another option is building separately within each VM, but that's annoyingly expensive. Beyond having some preflight check for tests to check java version, I'm not sure there's a great solution.

Adding a check sounds good to me. I think people often don't do it because they're not aware that it can cause issues.

If Java 7 is needed to build, then we should document that requirement. We also have checks in the gradle file which are specific to Java 8 (doclint in particular), so it's not unreasonable for users to assume it's supported.

@hachikuji Filed https://github.com/apache/kafka/pull/677 for the documentation side. Regarding the Java 8 doclint code in Gradle, we do have a Java 8 build in Jenkins, but it both compiles and runs with Java 8 (this helps ensure that our code also compiles with Java 8 making it easy to move to that version when the time comes).

By the way, this will no longer be an issue when Java 9 is released in 2017:
http://openjdk.java.net/jeps/247
;)


issues when i try to train my own model using train_softmax.py

When I try to train my own model using 5000000 pictures, my host memory(not GPU) is 8GB and it's  not enough to train,right? The errors are as follows:

What should I do?

Thanks in advance and Thanks to @davidsandberg for his effort.

Modify the “gpu_memory_fraction” argument to a smaller one, such as 0.4

Hi,
Assuming that it works fine for smaller datasets you can try to reduce the memory footprint by removing train_set variable, but it needs to be done after the line
        image_list, label_list = facenet.get_image_paths_and_labels(train_set)

and it should be something like
        del train_set

Hi,
It works fine for smaller datasets, I have tried. As you say, Instead of using train_set, I build a txt file to put my path of all the pictures. Then I use python to read the txt file to get the image_list and label_list. In this way, I still met errors like above. @davidsandberg  Thank U, what can I do?
Thank U @mingfengwuye  , the reason isn't lack of gpu memory. It's host memory(8 GB).

Hi,@recordcode ,i'm intereted in your question
If i want to test one image,and the result will cirle out the faces in the image and label his or her name beside the bounding boxes,so how to run this code to train my own model and  how to modify this code to accomplish my goal?
Thanks,very much!

Closed due to inactivity. Reopen if needed.


Prefer cfg_if

It's a bit opinionated, but I'm hoping the end result is cleaner and more maintainable. The PR includes a bunch of doc comment changes as well, as all this was stripped out of the init rework branch and I think it doesn't matter when a bunch of newlines land.

For the record, the spark for this PR came from noticing #[cfg(esp32)] and #[cfg(not(esp32))] pairs in the embassy examples. If we have to introduce a third variant there, it will devolve quickly into a mess. We're already using cfg_if in multiple places, and while at a lot of places the options are equivalent, I think we should suggest one for consistency, and it doesn't hurt if the suggested option is, in some cases, more maintainable :)


[FEATURE] Add support to Convex pool

Convex pool - get pool information and one account's position in it.

credmark-dev run convex-fi.earned -b 15045117 -j -i {address:0x5291fBB0ee9F51225f0928Ff6a83108c86327636}

{
    "slug": "convex-fi.earned",
    "version": "0.0",
    "chainId": 1,
    "blockNumber": 15045117,
    "output": {
        "earnings": [
            {
                "lp_token": {
                    "address": "0xc4ad29ba4b3c580e6d59105fff484999997675ff"
                },
                "balance":<PHONE_NUMBER>19529326442,
                "earned":<PHONE_NUMBER>660249639976,
                "rewards": 0,
                "reward_token": "0xD533a949740bb3306d119CC777fa900bA034cd52",
                "user_reward_per_token_paid":<PHONE_NUMBER>1891796877
            }
        ]
    },


fix: 1.3.0 introduces a breaking change (fixes #51)

it allows:
impot {cookie} from 'cookie_js'
or
import cookie from 'cookie_js'

friendly ping @florian

friendly ping @florian

Thanks!
As what version would you release this though? The current version is 1.4.0.

Thanks!
As what version would you release this though? The current version is 1.4.0.

as suggested in https://github.com/florian/cookie.js/issues/51#issuecomment-538392247
you can release a patch(1.4.1), and deprecate 1.3.0~1.4.0

as suggested in https://github.com/florian/cookie.js/issues/51#issuecomment-538392247
you can release a patch(1.4.1), and deprecate 1.3.0~1.4.0

Sounds good. Thanks! :)

Sounds good. Thanks! :)

I just reverted the changes. It seems like this breaks the UMD build:
$ npm run-script build
$ npm test

Do you know what the problem here might be? It seems like adding this one additional export somehow messes the UMD build up.

I just reverted the changes. It seems like this breaks the UMD build:
$ npm run-script build
$ npm test

Do you know what the problem here might be? It seems like adding this one additional export somehow messes the UMD build up.

emm... adding this will break cjs/umd users.
var cookie = require('cookie_js').default;

a workaround would be adding another entry for esm.

emm... adding this will break cjs/umd users.
var cookie = require('cookie_js').default;

a workaround would be adding another entry for esm.


Integrate crypto-mnemonic

Since the wallet will also provide mnemonic recovery backup phrases - we should implement a command line version too using the crypto-mnemonic library which is compatible with the javascript version we will use

low priority

ditching this


Review and enhance tracing support for currency service (C++)

The following is a list of requirements that we need to evaluate before declaring v1 for trace telemetry. These requirements are across the entire application; Not all services will meet all requirements. Determine the relevant features for this service.

[x] Automatic Instrumentation is being used where appropriate.
[x] Library instrumentation is being used if automatic instrumentation is unavailable.
[ ] Services extend automatic instrumentation.

[ ] New attributes/events attached to existing spans.
[ ] New spans are being created from existing spans.

[x] Automatic and Manual Context Propagation are being demonstrated.
[x] Telemetry is not being sampled upfront.
[x] Telemetry is not being filtered upfront.
[ ] Baggage is being set and read appropriately (i.e., baggage must be explicitly set as attributes on spans)
[ ] Update the centralized tracing doc

Referencing: https://github.com/open-telemetry/opentelemetry-demo-webstore/issues/42
Service: https://github.com/open-telemetry/opentelemetry-demo-webstore/blob/main/src/currencyservice/README.md
C++ dependent on this item: https://github.com/open-telemetry/opentelemetry-demo-webstore/issues/36

@DebajitDas  - Do you have plans to take this further?

Please note that opentelemetry-cpp contains recent changes that have some impact on the C++ demo here.
SDK builders
[TRACE SDK] Add trace sdk builders (#1393) https://github.com/open-telemetry/opentelemetry-cpp/pull/1471
This change provides a new set of API to use to configure the SDK.
Code similar to:
auto exporter = std::unique_ptr<opentelemetry::sdk::trace::SpanExporter>(
      new opentelemetry::exporter::otlp::OtlpGrpcExporter(opts));

creates issues with shared libraries, and is to be avoided.
Instead, please use:
auto exporter = opentelemetry::exporter::otlp::OtlpGrpcExporterFactory::Create(opts);

and likewise for all SDK configuration.
Semantic conventions
[SEMANTIC CONVENTIONS] Upgrade to version 1.12.0 https://github.com/open-telemetry/opentelemetry-cpp/pull/873
Code like:
{OTEL_GET_TRACE_ATTR(AttrRpcSystem), "grpc"},

is better replaced by:
{SemanticConventions::RPC_SYSTEM, "grpc"},

New release to come
These two changes are unreleased, with opentelemetry-cpp 1.5.0 coming soon.
We appreciate if the opentelemetry-demo code can show case the best practices,
because the code will serve as an example for many people to build from.
Regards,
-- Marc

@DebajitDas - Do you have plans to take this further?

Yes @lalitb, I will be looking into this. I am assigning it to myself

@cartersocha - Can you assign this to @DebajitDas please? Thanks.

Adding my comments on the feature list in the description

Automatic Instrumentation is being used where appropriate. : Nothing to be done as automatic instrumentation is not available for C++
Library instrumentation is being used if automatic instrumentation is unavailable. : Nothing to be done as automatic instrumentation is not available for C++
Services extend automatic instrumentation.  : Nothing to be done as automatic instrumentation is not available for C++
New attributes/events attached to existing spans. : Demonstrate Span::AddEvent and Span::SetAttribute by adding new(random) events and attributes ( if not done already).
New spans are being created from existing spans. : This is already implemented, as we create a new span from the span-context coming from the client using trace-propagation.
Automatic and Manual Context Propagation are being demonstrated.: Nothing to be done as Manual Context propagation is already implemented. Automatic Context Propagation is not available.
Telemetry is not being sampled upfront.: Nothing to be done as sampling is not done in code.
Telemetry is not being filtered upfront.: Nothing to to be done as filtering is not done in code.
Baggage is being set and read appropriately (i.e., baggage must be explicitly set as attributes on spans): Baggage needs to be read from the request header, and set as Span attributes (Example to read the baggage - https://github.com/open-telemetry/opentelemetry-cpp/blob/78551fbb535e2381fcdc6a1585b32f4999b43794/api/test/baggage/baggage_test.cc#L83)
Update the centralized tracing doc - Need to link relevant sections from otel-cpp documentation (https://opentelemetry-cpp.readthedocs.io/en/latest/)

Also, there are couple of comments from @marcalff  to be handled -

Use SDK builders for SDK configuration - Refer to the updated tracer_common.h here - https://github.com/open-telemetry/opentelemetry-cpp/blob/main/examples/grpc/tracer_common.h
Semantic Conventions - The usage has been updated in the latest otel-cpp, refer to server.cc for grpc here - https://github.com/open-telemetry/opentelemetry-cpp/blob/main/examples/grpc/server.cc

updated @lalitb. For baggage we're waiting for the new frontend to be merged then that will start the baggage process.
Seems like the only other missing piece besides baggage & documentation updates is: " Demonstrate Span::AddEvent and Span::SetAttribute by adding new(random) events and attributes ( if not done already).??

Seems like the only other missing piece besides baggage & documentation updates is: " Demonstrate Span::AddEvent and Span::SetAttribute by adding new(random) events and attributes ( if not done already).??

Yes, that's correct, apart from the two changes I mentioned separately.


⚠ Bofrost.be has degraded performance

In 48e9d4a, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2855 ms

Resolved: Bofrost.be performance has improved in 0653247.


Persisted/Replicated index

See https://github.com/ARK-Builders/ARK-Navigator/issues/142 for the context.
TL;DR: At the moment, index is built for any "root" folder and stored in memory.
Would be cool to cache it, so we wouldn't recalculate resource ids for unchanged files.
If we put the cache into our .ark folder, then our cache gets synced to other devices.
Smart write may be needed.
Let's fix .ark/index path for it.

This is the only part of the storage which is not user-defined and allowed to be lost.

Reminder: .ark folder is our "persisted and replicated storage" which gets synced to all other devices using Syncthing. Later, we might implement our own sync mechanism.


Z-index should be re-calculated for already opened modals

I suppose the problem is with how i am using materialize, but i am using modals like how activities are used in Android, so for example i have a modal that opens a user profile, on the user's profile i open another modal, say that user's posts, then i click on the user's name in that user posts modal, the user modal, which should now appear, does not, because the z-index is not recalculated. I could modify the z-index, but that would destroy the whole architecture for the modals.
I don't know what the disadvantages of re-calculating the z-index each time a modal is opened would be.
Here is how i am using modals (the whole screen is a single div with a modal class in each of these pictures):

Is there anyway you could recreate the problem in a simple codepen? I'm not sure exactly what the problem is. We support nesting modals

@acburst I fixed my problem by overwriting all of Materialize's z-index calculations and modal openings.
Steps to reproduce this issue:
1- Create a modal with the id #modal1
2- Inside of #modal1, create a modal-trigger for another modal, say #modal2.
3- After you go to #modal2 with #modal1's modal-trigger, #modal1 is still opened but its z-index is smaller than #modal2's so it is not visible.
4- Now if you have a modal-trigger for #modal1 inside of #modal2, when you click it, nothing happens, because the z-index is not recalculated (since Materialize thinks #modal1 is already open so the methods just return or something).
So basically, create a modal, go to another modal with a button from that initial modal, and then inside of that second modal try to go back to the first modal using another button, the initial modal, which logically should appear, does not.

@acburst currently on a deadline so i can't spare any time to reproduce the issue with a Codepen, i created this issue out of desperation, but i fixed it myself after 6 hours of continuous work. What i did was i created  a stack for the modals and a custom z-index counter, so on a modal-trigger being clicked, i checked if it was already opened and if it was, i updated its z-index so it was on top, and i use that same stack on the modals being closed, so everything is working alright so far.

@acburst  If this already has a solution, please inform me because i don't want to mingle with your defaults.

@acburst  Okay, here is another issue i want to ask you about since you appear to be active in this library's issues section.
Is it mandatory for the select inputs to be recreated over and over again each time you re-initialize them, does this behavior persist in the newer versions of Materialize ? say i initialized a select input, so now everything is great, however i copy the HTML of the div containing it to another div, and now the select inputs, and their UL elements, generated by Materialize, will be copied as well (visible the source code), however those won't be actually shown anymore when i click their select input elements. I have to re-initialize them, and if i do that, then i end up with duplicate select inputs.
So is there a solution for this or do i have to remove the already-generated UL elements manually before re-initializing.
Sorry for the too-many questions, i feel like i am demanding too much of this library and i am using it for   something it was not meant to do (a mobile-app, virtually). And i did end up having to do the most things Materialize was supposed to do for me myself, like the tabs, even their animations didn't work as expected when they were added dynamically, that is the only issue with this library, it is not as dynamic as it should be. Perhaps  you guys could work on that.

@acburst Concerning my last question (the one about select inputs), i just re-checked the documentation, you already have a function for destroying selects, thanks!!!! Will try that out and check if it is what i need.

@acburst Code to reproduce the second bug (i am using the latest release, Materialize v0.99.0):
HTML:
`

Female
Male
Other

`
Javascript:
$(document).ready(function(){ $("select").material_select();	 var old_html = $("div").html(); $("div").html(""); $("div").html(old_html);	// at this point, the old material_select has a buggy effect, where the select dropdown is rendered, but clicking it does not show the UL element. $("select").material_select("destroy");	// Naturally, the solution that would cross one's mind at this point would be to destroy and re-initialize the select. However, "destroy" does not destroy the select element that we described above, material_select will work, and therefore we end up with duplicates. $("select").material_select();		 });

Copying generated html like this is not recommended. It will cause the references to be unloaded so the event handlers no longer work. Instead you should try destroying the select before you copy and overwrite the HTML or just remove the HTML and build the initial select from scratch and initialize that.

Closed due inactivity. Feel free to reopen it, if it's still necessary.


DOCUMENTATION(issue#32)

ADDED DOCUMENTATION TO DIFFERENTIATE QUESTIONS BASED ON THERE CATEGORY.

Great @kamalsritha


Remove ARM support for the time being

This is causing release issues with GoReleaser's build

Pull Request Test Coverage Report for Build 574989254

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.669%

Totals

Change from base Build 574960410:
0.0%

Covered Lines:
594

Relevant Lines:
785

💛  - Coveralls