[sdl2-mixer] Fix dynamic loading when building static library

Since sdl2 uses LoadLibrary / dlopen to open the feature library, we should always use dynamic suffixes to build.
Add dynamic load as a feature.

Related:
https://github.com/microsoft/vcpkg/commit/df484b0e5a504aa341b767223b530325995fbffd#commitcomment-36414770
#9333.
Note: all features test pass with following triplets:

x86-windows
x64-windows
x64-linux

@edo9300 @tannergooding @Vultraz @timautry @Vermeille Are these changes correct? Could you test it?
Thanks.

@JackBoosY @Vultraz @vermeille
I can only vouch for x64-windows, compiles/links and seems to run correctly with a few debug/release programs I've written. I don't use x86 nor the x64 static triplets, so I have not tested them, maybe some of the others have these triplets installed.
Thank you very much for all the hard work.

Would it be possible to add a feature to static link the sound backends instead of loading them dynamically?

@kevinlul @timautry I've set dynamic loading as a feature, could you test it?
Thanks.

Both static loading and dynamic loading now work on Windows. Tested on x86-windows-static. I assume the dll files aren't automatically copied as part of MSBuild because they are compiled on x86-windows when using dynamic loading?

@kevinlul I disabled dynamic loading when building static library. Could you re-test it?
Thanks.

Is that necessary? There might be a use case for mixer itself to be static linked but not the backends. If it's possible then there's no need to remove it.

@kevinlul Sadly, vcpkg cannot determine the type of a certain port has been built. So here according to the inheritance relationship, by default all plugins are the same build type as sdl2-mixer (both dynamic or both static).

/azp run

/azp run

/azp run

/azp run

For some reason I'm having trouble building a dynamic sdl2-mixer[libvorbis] lib, either 32 or 64 bit. A static build works fine :(
[23/24] cmd.exe /C "cd . && C:\Users\exodi\Documents\vcpkg\downloads\tools\cmake-3.14.0-windows\cmake-3.14.0-win32-x86\bin\cmake.exe -E vs_link_dll --intdir=CMakeFiles\SDL2_mixer.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100183~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100183~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~3\2019\COMMUN~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\link.exe  CMakeFiles\SDL2_mixer.dir\effect_position.c.obj CMakeFiles\SDL2_mixer.dir\effect_stereoreverse.c.obj CMakeFiles\SDL2_mixer.dir\effects_internal.c.obj CMakeFiles\SDL2_mixer.dir\load_aiff.c.obj CMakeFiles\SDL2_mixer.dir\load_voc.c.obj CMakeFiles\SDL2_mixer.dir\mixer.c.obj CMakeFiles\SDL2_mixer.dir\music.c.obj CMakeFiles\SDL2_mixer.dir\music_cmd.c.obj CMakeFiles\SDL2_mixer.dir\music_flac.c.obj CMakeFiles\SDL2_mixer.dir\music_fluidsynth.c.obj CMakeFiles\SDL2_mixer.dir\music_mad.c.obj CMakeFiles\SDL2_mixer.dir\music_mikmod.c.obj CMakeFiles\SDL2_mixer.dir\music_modplug.c.obj CMakeFiles\SDL2_mixer.dir\music_mpg123.c.obj CMakeFiles\SDL2_mixer.dir\music_ogg.c.obj CMakeFiles\SDL2_mixer.dir\music_opus.c.obj CMakeFiles\SDL2_mixer.dir\music_timidity.c.obj CMakeFiles\SDL2_mixer.dir\music_wav.c.obj CMakeFiles\SDL2_mixer.dir\version.rc.res CMakeFiles\SDL2_mixer.dir\music_nativemidi.c.obj CMakeFiles\SDL2_mixer.dir\native_midi\native_midi_common.c.obj CMakeFiles\SDL2_mixer.dir\native_midi\native_midi_win32.c.obj  /out:SDL2_mixer.dll /implib:SDL2_mixer.lib /pdb:SDL2_mixer.pdb /dll /version:0.0 /machine:x64 /debug /INCREMENTAL  C:\Users\exodi\Documents\vcpkg\installed\x64-windows\debug\lib\SDL2d.lib Winmm.lib user32.lib gdi32.lib winmm.lib imm32.lib ole32.lib oleaut32.lib version.lib uuid.lib advapi32.lib setupapi.lib shell32.lib dinput8.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib  && cd ."
FAILED: SDL2_mixer.dll SDL2_mixer.lib
cmd.exe /C "cd . && C:\Users\exodi\Documents\vcpkg\downloads\tools\cmake-3.14.0-windows\cmake-3.14.0-win32-x86\bin\cmake.exe -E vs_link_dll --intdir=CMakeFiles\SDL2_mixer.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100183~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100183~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~3\2019\COMMUN~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\link.exe  CMakeFiles\SDL2_mixer.dir\effect_position.c.obj CMakeFiles\SDL2_mixer.dir\effect_stereoreverse.c.obj CMakeFiles\SDL2_mixer.dir\effects_internal.c.obj CMakeFiles\SDL2_mixer.dir\load_aiff.c.obj CMakeFiles\SDL2_mixer.dir\load_voc.c.obj CMakeFiles\SDL2_mixer.dir\mixer.c.obj CMakeFiles\SDL2_mixer.dir\music.c.obj CMakeFiles\SDL2_mixer.dir\music_cmd.c.obj CMakeFiles\SDL2_mixer.dir\music_flac.c.obj CMakeFiles\SDL2_mixer.dir\music_fluidsynth.c.obj CMakeFiles\SDL2_mixer.dir\music_mad.c.obj CMakeFiles\SDL2_mixer.dir\music_mikmod.c.obj CMakeFiles\SDL2_mixer.dir\music_modplug.c.obj CMakeFiles\SDL2_mixer.dir\music_mpg123.c.obj CMakeFiles\SDL2_mixer.dir\music_ogg.c.obj CMakeFiles\SDL2_mixer.dir\music_opus.c.obj CMakeFiles\SDL2_mixer.dir\music_timidity.c.obj CMakeFiles\SDL2_mixer.dir\music_wav.c.obj CMakeFiles\SDL2_mixer.dir\version.rc.res CMakeFiles\SDL2_mixer.dir\music_nativemidi.c.obj CMakeFiles\SDL2_mixer.dir\native_midi\native_midi_common.c.obj CMakeFiles\SDL2_mixer.dir\native_midi\native_midi_win32.c.obj  /out:SDL2_mixer.dll /implib:SDL2_mixer.lib /pdb:SDL2_mixer.pdb /dll /version:0.0 /machine:x64 /debug /INCREMENTAL  C:\Users\exodi\Documents\vcpkg\installed\x64-windows\debug\lib\SDL2d.lib Winmm.lib user32.lib gdi32.lib winmm.lib imm32.lib ole32.lib oleaut32.lib version.lib uuid.lib advapi32.lib setupapi.lib shell32.lib dinput8.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib  && cd ."
  All rights reserved.

   Creating library SDL2_mixer.lib and object SDL2_mixer.exp
music_ogg.c.obj : error LNK2019: unresolved external symbol ov_clear referenced in function OGG_Load
music_ogg.c.obj : error LNK2019: unresolved external symbol ov_open_callbacks referenced in function OGG_Load
music_ogg.c.obj : error LNK2019: unresolved external symbol ov_pcm_total referenced in function OGG_Load
music_ogg.c.obj : error LNK2019: unresolved external symbol ov_pcm_seek referenced in function OGG_Load
music_ogg.c.obj : error LNK2019: unresolved external symbol ov_time_seek referenced in function OGG_Load
music_ogg.c.obj : error LNK2019: unresolved external symbol ov_pcm_tell referenced in function OGG_Load
music_ogg.c.obj : error LNK2019: unresolved external symbol ov_info referenced in function OGG_Load
music_ogg.c.obj : error LNK2019: unresolved external symbol ov_comment referenced in function OGG_Load
music_ogg.c.obj : error LNK2019: unresolved external symbol ov_read referenced in function OGG_Load
SDL2_mixer.dll : fatal error LNK1120: 9 unresolved externals
ninja: build stopped: subcommand failed.

@Vultraz Can you open a new issue?
Thanks.

@Vultraz  - did you try:
.\vcpkg.exe install sdl2-mixer[dynamic-load,libvorbis]:x64-windows ?
I had a similar issue #9828 during an upgrade run and was able to install all the package when adding the dynamic-load feature.

@timautry that worked! Thanks 😃

You are most welcome!

Yes. Thank you!!!


[EPIC]:  Connection status in OCM UI

Epic Description
Currently OCM UI doesn't show connection status in its own UI. It shows up as part of ManagedClusterAddOn status. It is not very intuitive for user to know which cluster connections are in connecting or error states. With topology view available in OCM 2.6, it should be used to display multicluster connection information to user.
Refer https://github.com/submariner-io/enhancements/issues/88
Acceptance Criteria

Definition of Done (Checklist)

[ ] Code complete
[ ] Relevant metrics added
[ ] The acceptance criteria met
[ ] Unit/e2e test added & pass
[ ] CI jobs pass
[ ] Deployed using cloud-prepare+subctl
[ ] Deployed using ACM/OCM addon
[ ] Deploy using Helm
[ ] Deployed on supported platforms (for e.g kind, OCP on AWS, OCP on GCP)
[ ] Run subctl verify, diagnose and gather
[ ] Uninstall
[ ] Documentation added
[ ] Release notes added

Work Items

[ ] OCM - Add Connection Status to UI

[ ] Add ConnectionStatus CRD or such a field to SubmarinerConfig Status in submariner addon.
[ ] https://github.com/stolostron/backlog/issues/19294

Dependencies
This requires topology view to be available in OCM UI. Also requires some design discussions with UI team on how to model ConnectionStatus CRD so it can be used by UI in a scaleable way.

Closing for now. Revisit when we have more clarity on what needs to be done in submariner.


Clean Up API

It seems like there is a lot of work being done to ensure that the package is backward compatible. This seems a little odd to me and has led to weird API decisions. Some methods are chain-able via this, some return promises, and some use a node style callback. I believe we should decide on a consistent way of doing things and bump to the version to 1.0.0 since we will probably be breaking some things along the way.
Another thing we should look at is how we pass arguments. Currently it can be variable and leads to many situation where we would have to make a major release(SemVer). Some other PRs and Issues discuss passing an options object instead. I think this would be the better way to go and would allow us to iterate quicker without breaking the API.

@edi9999

yes I agree with you.
The API should be coherent.
I think all methods returning something asynchronously should use Promises.
For option parameters, at least for boolean parameters, and probably for all, we should use an options object to set the parameters, makes sense.

I propose every function now takes a options object even if they only have 1 arg.

supports adding more options to any function in the future without breaking changes
when done will be a breaking change
simplifies the code a lot

We should also continue to support chaining as much as possible. So code like this should work.
Jimp.read('some-image.png')
	.resize(100, 100)
	.write('some-image-medium.png')
	.resize(25, 25)
	.write('some-image-small.png');

Functions that take node-style-callbacks that should return promises:
* Jimp.contructor(options) => Promise #308 #445
* each if branch can resolve to keys on the object
* Jimp.loadFont
* Jimp.prototype.write #232 #90 #374
Take callback but don't need to (nothing async is done). So we can just remove the callback. They will either return a value or this depending on current implmentation:
* Jimp.rgbaToInt
* Jimp.intToRGBA
* Jimp.prototype.deflateLevel
* Jimp.prototype.deflateStrategy
* Jimp.prototype.filterType
* Jimp.prototype.rgba
* Jimp.prototype.getPixelIndex
* Jimp.prototype.getPixelColor
* Jimp.prototype.setPixelColor
* Jimp.prototype.hash
* Jimp.prototype.blit
* Jimp.prototype.mask
* Jimp.prototype.composite
* Jimp.prototype.brightness
* Jimp.prototype.contrast
* Jimp.prototype.posterize
* Jimp.prototype.flip
* Jimp.prototype.gaussian
* Jimp.prototype.blur
* Jimp.prototype.convolution
* Jimp.prototype.opacity
* Jimp.prototype.fade
* Jimp.prototype.resize
* Jimp.prototype.cover
* Jimp.prototype.contain
* Jimp.prototype.scale
* Jimp.prototype.scaleToFit
* Jimp.prototype.pixelate
* Jimp.prototype.convolute
* Jimp.prototype.rotate
* Jimp.prototype.displace
* Jimp.prototype.color
* Jimp.prototype.print
* Jimp.prototype.getBuffer (used to have async stuff but now is totally sync) #90 #374
* Jimp.prototype.getBase64 (see above, can be sync now) #374
Related Issues to be closed:

#220 Synchronous fallback. we should export sync versions of async function like read and write.
#153 Look at switching image processing libraries to async
#408 #347 #286 Proper error reject

@edi9999 thoughts?

Should every method just return a promise? might make the desired syntax hard


libraryPath

Gifski.Create(@"C:\Test\gifski.dll"
what is this and how can i make I work?

You need to compile this:
https://github.com/ImageOptim/gifski

or there is any other solution to use it without that dll file?

It's a wrapper around gifski's API, so no.


Issuer SM stores aries cred offer instead of libindy offer

Issuer state machine stores generic Aries Credential Offer message, rather than specific libindy offer structure.
Libindy offer structure is needed to issue indy credential, hence upon issuance, libindy structure is retrieved from Aries Cred Offer attachment - it's assumed the attachment is libindy offer.

This is one of small steps towards decoupling Aries FSM layer and libindy.
Signed-off-by: Patrik Stas<EMAIL_ADDRESS>

Codecov Report

Merging #419 (a22a770) into main (b368b60) will decrease coverage by 16.84%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##             main     #419       +/-   ##
===========================================
- Coverage   66.36%   49.52%   -16.85%
===========================================
  Files         151      134       -17
  Lines       13919    11490     -2429
  Branches     2714     2247      -467
===========================================
- Hits         9237     5690     -3547
- Misses       2490     4418     +1928
+ Partials     2192     1382      -810

Flag
Coverage Δ

integration-aries-vcx
?

unittests-agency-client
?

unittests-aries-vcx
49.52% <80.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

..._vcx/src/handlers/issuance/issuer/state_machine.rs
66.54% <66.66%> (-4.81%)
:arrow_down:

...vcx/src/handlers/issuance/issuer/states/initial.rs
88.88% <100.00%> (ø)

.../src/handlers/issuance/issuer/states/offer_sent.rs
64.70% <100.00%> (ø)

...ndlers/issuance/issuer/states/proposal_received.rs
94.73% <100.00%> (ø)

...dlers/issuance/issuer/states/requested_received.rs
70.58% <100.00%> (ø)

...ndlers/proof_presentation/prover/states/initial.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

aries_vcx/tests/utils/devsetup_agent.rs
0.00% <0.00%> (-77.54%)
:arrow_down:

aries_vcx/tests/test_integration.rs
6.04% <0.00%> (-76.43%)
:arrow_down:

aries_vcx/src/libindy/utils/anoncreds.rs
8.81% <0.00%> (-67.41%)
:arrow_down:

...x/src/handlers/proof_presentation/prover/prover.rs
15.66% <0.00%> (-62.01%)
:arrow_down:

... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b368b60...a22a770. Read the comment docs.


Merge the Docs repository with the main Nimble project

Currently we have a Nimble repo and a seperate Docs repo for GitBuilding. The docs should really be in the same repo as the source as it breaks many GitBuilding features if they are not.

thanks @julianstirling. Wakoma/docs was mainly for the Lokal project.  All nimble docs will be here: https://github.com/Wakoma/nimble/tree/master/doc


feat: support for empty file names

The function with an empty name .mcfunction is currently not supported by beet atm.
This PR fixes this issue by modifying the code where the extensions of a file are calculated (in beet/library/utils.py).
Q/A

Where does the problem come from ? : In the python pathlib, the first suffix is skip if the filename start with a dot

Why is it a problem ? : Because minecraft loads these functions as usual, and other datapackers rely on this behavior.

Arf, I apologize for leaving your issue unanswered for so long! I remember that back when I first saw the issue, I thought that allowing empty names could cause problems in other places because beet plugins often just assume that the name can't be empty. I wanted to look into it more in depth but eventually I just forgot and never got back to you.
I still don't have a clear answer though. I've always felt like Mojang doesn't even know that empty names are allowed. If it was never intended, they could very well make it an error the moment they realize and a bunch of packs would break. It just seems like a bug that's bound to be fixed sooner or later so I generally avoid relying on it.
But it's true that as a build tool, beet should strictly conform to game's behavior. I'll have to look through a couple plugins to see if additional changes are required to take into account empty names.

Yeah it always seemed very hacky to me to use empty filenames, just writing function namespace: feels weird, but people are using it.
Do i have to push the files in test/snapshots/** to make the test pass ?


Unable go back in HA mobile app.

Hi,
When I click into the One drive back from the add-on screen. I am not able to go back to the home screen.
Thanks

I have the same issue. After navigating away from the companion app and then re-opening it, the back button does not work and I'm stuck in the onedrive backup screen. Force closing the app doesn't work either as it just opens onedrive backup again with the broken button and no way to get back to the home screens.

Is this iOS or Android ? I'm running Android but have not been able to recreate this.
Could you share the exact steps that cause this ?

iOS 17.2.1 iPhone 15 pro.
It's a weird one as I can't seem to reproduce it now. After reinstalling the onedrive backup addon, I was on the page - the normal hamburger icon was replaced with a back arrow which didn't do anything. I had to remove and reinstall HA app to get back to the rest of the app. I'll let you know if I see it again but maybe something to do with the reinstall.


Bugfix in ps6000RapidBlockExample.py - TimeUnits must be array

Fixes #.
The function ps6000GetValuesTriggerTimeOffsetBulk64 takes, according to the specification/programming manual

timeUnits, an array of integers. The array must be long enough to hold the number of requested times [...]

However, it was not an array in the ps6000RapidBlockExample.py, line 272. If you do not fix this, you get a segfault.
Changes proposed in this pull request:

change datatype of TimeUnits to (ctypes.c_int16*10)() instead of  ctypes.c_char()

We don't take pull requests on our repositories. If you have an issue with the repository please contact<EMAIL_ADDRESS>


libelf: fix NLS on NetBSD and Darwin

Motivation for this change
libelf wants to use gencat on Darwin, but Darwin's gencat is disabled.  So until that's fixed, borrow NetBSD's gencat for Darwin as well.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Okay, on Darwin it fails with an infinite recursion, so let's focus on just NetBSD.  But anybody who was motivated to fix it on Darwin in future could use this approach if they wanted to figure out how to break that dependency cycle.


winget list is missing 'Available' column

Brief description of your issue
winget v1.5.2201
winget is missing 'Available' column, the column disappeared between two restarts
Steps to reproduce
run winget list
Expected behavior
expected to see column 'Available'
Actual behavior
winget list does not return column 'Available', colums 'Name', 'Id', 'Version' and 'Source' are returned
Environment
winget v1.5.2201

Available only shows up if there are upgrades available to install. What is the output of winget upgrade

Available only shows up if there are upgrades available to install. What is the output of winget upgrade

Related to Winget list dont show available version #3420
Related to Missing Available column from winget list  #3219
Duplicate of “winget list” don't get "Available" column #1618
Duplicate of winget list does not show column with available update any more #2396

winget upgrade shows "11 upgrades available." with visible "Available" column
winget list - column "Available" not visible


Review button modal

fixes issue #232 enable the review button to show the modal of the course proposal information and allow approve them
location: http:///manageServiceLearning

@BrianRamsay, you can take a look now!


After completing a checkout, button doesn't respond to clicks

Hi folks,
After going through a full checkout, clicking the button no longer brings up the dialog.
I see it making a request to the hermes logger but that's it.
Any ideas? Using it with the React component.

Hi @georgiosd -- did you see the checklist for submitting an issue? Without those details it's pretty difficult to replicate bugs. Thanks!

Apologies. I thought it would a straight-forward answer but I guess it's not. Here I go :)
Code excerpts:
const PayPalButton = paypal.Button.driver('react', { React, ReactDOM });

<PayPalButton
                                    env={this.state.paypalMode}
                                    locale={'en_US'}
                                    style={ { size: 'responsive', color: 'gold', shape: 'rect' } }
                                    commit={true}
                                    validate={validate}
                                    onClick={gotoValidationStep}
                                    payment={createPayment}
                                    onAuthorize={executePayment}
                                    onCancel={cancelPayment} />

Version:
"paypal-checkout": "^4.0.84",

Description:

I click checkout, go through a full checkout, all works OK
I click checkout again, button does nothing

No error messages in console. I just see the requests to the hermes logger.
This is on Chrome latest. Haven't tried on anything else.
I am happy to give a link to a staging server where you can try this but I wouldn't like to post that publicly.

Hi,
"paypal-checkout": "^4.0.84",
If you do an npm ls paypal-checkout what version do you get? Can you please make sure you're on at least 4.0.110

I upgraded to .110 and now I'm getting the window cleanup error @ https://github.com/paypal/paypal-checkout/issues/404
I will see if I can work around it to determine if the original problem persists.

I didn't find any workarounds that are not affected by #404. I will close this until #404 is fixed and will reopen if the problem persists.


Rename LEGUP_ROOT_DIR to SHLS_ROOT_DIR

We should delay merging this PR until we have released 2023.2.

I think merging into dev is fine. Our customer would use main?

Is dev merged into master for 2023.1?
After dev is merged for 2023.1, we can definitely merge this commit into dev.


Preserve License Comments

How can I keep JavaScript/CSS comments prefixed by /*! or /** or contains @license in the block? Editing the options parameters in UglifyJS/CSS instance from the source did not change anything.

Sorry for the delay - this certainly seems possible in UglifyJS as I think they have a feature for that. I'm not sure about cleancss though. I'll see if I can get around to adding that option in the UI soon.

{
  compress: { … },
  output: {
    …
    …
    comments: /@license|@preserve|^[!*]/
  }
}

It should now be possible with brackets-minifier v3.0.0 to preserve comments (licences or otherwise) by passing the appropriate options with https://github.com/abagshaw/brackets-minifier#minifier-options


idea for lazy flatMap

I fixed the formatting and provided an idea for implementing flatMap in a lazy fashion.

Thanks for the PR, Matthias!
Other Wicket devs seems to liked the idea of having those methods in IModel, so thanks for formatting the code too! :-)
This #flatMap() impl looks good to me!
Please add the checks for null to set/getObject and I'll merge it!

Awesome! Should hopefully be fine now!
Thanks again for being so open to the ideas!


The RPC document has not been updated for a long time!

The RPC Address https://eosio.github.io/eos/group__eosiorpc.html

You can check out the most updated version here https://developers.eos.io/eosio-nodeos/reference


Added softlayer lookup helpers to the common package. Get datacenter …

…by name implemented. Unit tests completed as well

General comment, what do you think of emulating terraform and creating a helpers package to put this in on softlayer-go

@renier I agree with both comments. Updating now

...or just call the file helpers.go... seeing that the common package was already being used to put utilities in.


api_docs: Update the docs for the POST /messages response.

CZO Discussion
Changes include:

Explicitly mention that the new visibility policy is still sent as user_topic event.
Adds a link as a way to understand the meaning of the enum values '2' and '3'.

Docs

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

This is good, but I did a broader round of edits on top of this to make the overall parameter documentation read a bit more cleanly. Thanks @prakhar1144!


Repeat tween from shows error

A bug in the API:

Phaser version(s):2.10.3
Live example:Codepen
What should happen:The sprite goes from (100,0) to (0,0) twice.
What happens instead:The sprite goes to (0,0) to (100,0) twice.

The origin position of sprite is (0,0),then i use tween from (100,0).First time it runs right,but repeat animation is 'tween to' instead of  'tween from'

https://codepen.io/samme/pen/jxMJWp

Thks reply.But i am still confused.In your code,The animation is from x:0 to x:400.Why the repeat change the  start and end,from x:400 to x:0?

TweenData#start swaps the start and end values. I'm not sure why yet.
For now try to use Tween#from instead if you want to use repeats.

Uh...You mean use Tween#to?  I use Tween#from just like from x:0 to x:400 in demo it always reserve the path in repeat. I just want to make the sprite always move from x:0 to x:400.But i dont know how to make it works with Tween#from. :(


(RVV-B0011) Exported function returning value of unexported type

Description
An exported function or method returning a value of an unexported type may be frustrating to use.
Occurrences
There is 1 occurrence of this issue in the repository.
See all occurrences on DeepSource → deepsource.io/gh/MindHunter86/aniliSeeder/issue/RVV-B0011/occurrences/

8724b791f2b0e4b7073877e953dfc79d62ebc3e6


Build static file server into build project.

Instead of requiring it to be run externally via a Python script.

Fixed in https://github.com/http4s/http4s-dom/commit/5c8117fe32ba062949bb7ebde90bb52104423798.


Fixed typos and grammatical errors in documentation

Closes #54
Corrected typos and improved grammar in documentation files for better readability and consistency.

Hi! My pull request is ready for review and merge. Thank you!

Thank you for the contribution!


change label namespace

Change nfd label to nfd.alpha.kubernetes.io according to Kubernetes Community #300 when in alpha phase.
How about we change nfd namespace according to nfd available phase like below:

alpha

nfd.alpha.kubernetes.io

beta

nfd.beta.kubernetes.io

GA(graduate from incubator)

nfd.kubernetes.io

/cc @balajismaniam @ConnorDoyle @davidopp

I can get to this pose v1.8

I'm not totally convinced that we need to evolve the alpha names, but the pattern for beta and GA proposed here look great. Could you start a tracking issue for graduation to beta that includes the beta naming scheme? Then we can get momentum moving towards graduating this repo.
cc @balajismaniam for another opinion here

@ConnorDoyle @balajismaniam @dchen1107
The reason for using nfd as the subdomain name as kubernetes.io in alpha, beta and GA is mainly:

more smaller and at the same time it is also clear that it represents node-feature-discovery. Smaller labels is more friendly to ETCD.
the unification of alpha, beta and GA is mainly to keep the subdomain clearly targeted for node-feature-discovery. Maybe it is just a placeholder for alpha.

I also suggest we  add node-feature-discovery labels to the well-known kubernetes labels when we make an agreement on this.

I guess my concern is adding unnecessary label churn beyond what's required by alpha => beta and beta => ga. On board with picking up the convention upon move to beta. I don't think it's worthwhile to rev the naming scheme before that.

Could you start a tracking issue for graduation to beta that includes the beta naming scheme? Then we can get momentum moving towards graduating this repo.

Will fire an issue to track the jobs we need to do for a beta release later.

@ConnorDoyle I have added an issue #74 and list something i think we need to do before we reach beta release. PTAL.

I agree with @ConnorDoyle. We should not change label namespaces before graduating to beta. Moreover, moving to kubernetes.io namespace might require discussion with the community. I like the label conventions mentioned for beta and GA.

@balajismaniam Agree on moving to kubernetes.io namespace might require discussion with the community.. What about send an email to kubernetes-sig-node and cc sponsor @dchen1107 and champion @davidopp .

Closing this for now. Let's wait till beta to change this.


Highlight Touch Tool

I am getting the following error when I activate highlightTouch:
ERROR Error: element not enabled
All other tools work fine with mouse or touch and highlight works for mouse.
case ToolType.HighLight: {
                cornerstoneTools.highlight.enable(dicomElement);
                cornerstoneTools.highlight.activate(dicomElement, 1);
                cornerstoneTools.highlightTouch.activate(dicomElement);
                break;
            }

@jewettdiane can you create a small reproduction in CodePen or JSFiddle that demonstrates this error/issue?

Highlight Touch Error
enabledElements.js:163 Uncaught Error: element not enabled
at Module.getEnabledElement (VM919 cornerstone.js:2397)
at u (VM921 cornerstoneTools.min.js:2)
at t.getToolState (VM921 cornerstoneTools.min.js:2)
at Object.f [as createNewMeasurement] (VM921 cornerstoneTools.min.js:2)
at VM921 cornerstoneTools.min.js:2
at HTMLDivElement.t (VM921 cornerstoneTools.min.js:2)
at t.default (VM921 cornerstoneTools.min.js:2)
at VM921 cornerstoneTools.min.js:2

The error is being thrown in the tool's createNewMeasurement method. When the MouseEvent is passed to it, it uses mouseEventData.event.currentTarget. This same value is null when touch calls createNewMeasurement with TouchEvent
The TouchEvent has a event.srcElement and event.target would need to be used when creating a measurement for a TouchEvent

This likely will not get patched in version 2. If you want to spearhead the effort, feel free to comment, and I can re-open this issue for 6-months or until the PR is merged (whichever happens first).
Your best bet is to give version 3 a go. If this issue exists in v3, create a new issue. If the tool was removed in v3, consider creating a 3rd Party Tool and have it listed in our 3rd Party Tool directory.


vCard 4.0

Are there plans to support vCard 4.0? It is published in 2011, so it is already rather old even though not a lot of clients support it yet. The new CardBook extension for Thunderbird does though.
https://tools.ietf.org/html/rfc6350

Absolutely. Then lets hope someone with the skills and time wants to help and put the effort in. Thank you.

I just had a quick look at https://github.com/eventable/vobject/blob/master/vobject/vcard.py
The source is not that big and it seems not every vcard section is implemented. I might be wrong with that assumption. Do you think the implementation of v4 requires a lot of changes? It might be quite simple to add/remove a few attributes.

Here is an overview of the most important changes:
https://tools.ietf.org/html/rfc6350#appendix-A
Does not look too heavy.

@nicohood cool, if you think it’s worth implementing, give it a shot and I’d be happy to review your PR!

Currently I only use the library for reading the vcards, and its also possible to read v4 cards. So that is good so far. It may be worth to implement the grouping options. But I am not sure if I am going to use those. :)

@wpercy, I desperately need it as Radicale depends on it, and etesync-dav depends on that. So I may take a jab at it very soon.
I've already skimmed the code a few times, but before I jump head first into this rabbit hole, I'd love to get some more information from you as you know the code best.
I think the main issue with vCard 4 support is that it subtly changes the format. Here's a short summary of the changes with some examples: https://github.com/mangstadt/ez-vcard/wiki/Version-differences
So for example, this:
<EMAIL_ADDRESS>
would change to:
<EMAIL_ADDRESS>
Is this something that's controllable from the definitions/behaviour files, or is this too much of a breaking change and I would need to change some the core parts of vobject too?
How about automatically using the correct definitions based on the vobject version? Is that easily doable?
Got any pitfalls/things I should keep in mind when doing this?
I'm sorry for asking all of these questions. I'm happy to invest the time into implementing this if it's actually doable, I just don't want to jump in and waste my time only to realise I need to break everything in order to add vcard v4 support.
Thanks!

No apologies necessary! I appreciate you grabbing a sponge and helping out here. I definitely think it's doable - I would say the biggest thing is trying to maintain backwards-compatibility with vCard versions 2.1 and 3.0 so we don't break any existing implementations.
I think we should be able to do this purely from a definitions/behavior standpoint, but will do some digging later today and try to update here.

Thanks for your comments, and looking forward to seeing your updates.
As for maintaining backwards-compatibility: the test suite seems exhaustive, is it safe to assume that if the suite passes I haven't broken anything? :innocent:

I would say that's a safe assumption, but I'll be sure to test it pretty exhaustively myself once you've submitted a PR.

I think we should be able to do this purely from a definitions/behavior standpoint, but will do some digging later today and try to update here.

Hey, did you get around to looking into it by any chance?

I finally got around to looking deeper into this, notes for myself (and anyone else who wants to help):

Seems like it's indeed possible to just create a new behaviour file.
The biggest compatibility issue between this library and vcard 4.0 is with PHOTO which supports data URIs and therefore contains a colon (probably not an issue) and a semicolon (is an issue for the current code) - though this seems to be very easy to fix.
Since this library isn't strict when parsing, vcard 4.0 seems to be mostly compatible with the current vcard 3.0 implementation.

@wpercy, is it possible to please reopen this ticket so we have one place to consolidate notes and progress? I can keep my notes locally, but I'd rather have people see that progress is being made and maybe pitch in with some help/feedback.

Thanks.

@tasn

but I'd rather have people see that progress is being made and maybe pitch in with some help/feedback.

I know you've posted re: v4 support here, in Radicale proj, and on your EteSync proj.
Have you moved fwd on resolving this?  If so, where's best place to follow?

@pgnd, it's split by nature, as both vobject and Radicale lack v4 support (and I can sometimes implement workarounds in EteSync directly).
So here is the place to follow if you care about vObject specifically, and EteSync is the place to follow if you care about EteSync.
As for an update on this issue: I've investigated a bit how vObject deals with the PHOTO field. It looks like it should be very easy to at least fix this one (as a first step for v4 support), though it'll also come with figuring out how to implement multiple behaviours for vCard (v3 and v4).
So in short: I have nothing really new to add here, but I am making (slow) progress.

Not sure how complete this is, but here's an example codebase that handles both 3 and 4: https://github.com/enesser/vCards-js/blob/master/lib/vCardFormatter.js
Will at least provide insights about the differences.

(Un)fortunately, the specification of RDAP protocol has decided on jCard v4.0 (JSON vCard serialization) as their contact information storage format.
I found no decent implementation of RDAP data parsing for python so I've started on that. I will want to use vobject to store the vCard data so I guess I'm joining you guys on this task.


Create null versions of the metric types and a NullMetricRegistry that builds them

The purpose of this change is to allow users to code against the base metric types and registry but have the flexibility to swap in null implementations of the counters. It enables a usage pattern like:
class Foo {
    private final MetricRegistry registry;

    Foo(MetricRegistry registry) {
        this.registry = registry;
    }

    Foo() {
        this(new NullMetricRegistry());
    }

    public void someFunction() {
        registry.meter("someFunctionCalled").mark();
    }
}

A client of Foo can pass in a MetricRegistry if it wants metrics collected, but it also doesn't have to use or be aware of Foo's use of metrics at all.

Is this test flaky? After I saw this failure I set up Travis on my fork. It failed, too but on jdk8 instead of 7. A few more runs with no code changes and it succeeded.
https://travis-ci.org/Intropy/metrics

I like the idea, however this PR introduces new protected methods and changes a private method to protected, which I can't do for a minor release.  I'd consider it for 3.2, however v3.2.0 will more than likely be the final v3 release, and I don't want to expand the scope.
Would you consider applying this change to the v4.0 branch?  Two notes, 1) it will take a little bit of work to adapt it to that branch, as file and package names have changed, and MetricName was introduced, 2) I want to include a capability in v4 to override how metrics are created, and while this looks like a good first step, the implementation might be wholly unrecognizable by the time v4 is released.
Thanks!

Sure, I'm willing to apply it on the v4.0 branch. I want to make sure of what you're saying with "the implementation might be wholly unrecognizable by the time v4 is released", though. Are you suggesting reworking it and applying it to v4.0 as v4.0 currently stands but that the implementation may be drastically changed as v4.0 evolves? Or are you saying that I should wait because if I build it for the current state of v4.0 then before the pull goes through the organization is likely to change significantly enough to require a second rewrite?
Also a note on why I closed and reopened since in retrospect it might have looked like I was pinging you. I think there may be some flakiness on the ScheduledReporterTest. I had consistent success locally before I put in the pull request, but on Travis it sometimes succeeds and sometimes fails. The first pull request resulted in a failure (https://travis-ci.org/dropwizard/metrics/jobs/123204697). Closing and reopening triggered Travis to run it again (https://travis-ci.org/dropwizard/metrics/builds/124043581).

The former, rework the patch to v4 as it is currently and then it will evolve along with that release.
That's not typically the test I have problems with, but its not surprising as it is time sensitive. I think that if you authenticate with Travis it will allow you to rerun a build without closing/reopening the PR. Also feel free to @ mention me to request that I rerun it.


Start translating docs into English

Includes #5. This PR separates the Chinese and English language documentation.
Starts translation of the Chinese files into English using Google translate.
The .rst files are source files that are compiled into HTML.
make html should be called in the docs/en/ directory.

Greetings @username223
You should consider seeing #12 and building on top of that instead, since the docs there are completely translated into English
Thanks!

@muscache Cool, thanks.
Are you building on top of @Newbytee improvements to the doc process?

Closed in favor of pine64/ble602-docs#1 .


Sync Prow commits from the test-infra repo

Extract Prow commit history from test-infra up to 1/14/2024 and merge them to the Prow repo.
Script to reproduce this PR:
git clone https://github.com/kubernetes/test-infra.git
cd test-infra
git-filter-repo --path prow/
# $YOUR_PROW_FORK is your forked repo for https://github.com/kubernetes-sigs/prow
git remote add target $YOUR_PROW_FORK
git fetch target
# move to the target/main branch
git checkout target/main
git switch -c tmp
# merge the local master branch
git merge master --allow-unrelated-histories
git push --set-upstream target tmp

/assign: @listx @cjwagner @airbornepony

/lgtm
/hold
Below are some comments for improvement for the next time we need to do this again.
I think your script can be improved like this:
# Clone old repo. Let's call it $old_prow.
git clone https://github.com/kubernetes/test-infra.git
# Strip down master branch of $old_prow to only have commits that touch the the /prow directory.
cd test-infra
git-filter-repo --path prow

# Navigate to your local clone of https://github.com/kubernetes-sigs/prow.
# Let's call this $new_prow.
cd $new_prow
# Check out a new "sync" branch that we want to create a PR from.
git branch sync origin/main
git checkout sync

# Import commits from old_prow/master into "sync" inside $new_prow.
git remote add old_prow $old_prow
git fetch old_prow
git merge old_prow/master

This way, the merge commit will have the self-descriptive text Merge remote-tracking branch 'old_prow/master' into sync instead of the PR here which has just Merge branch 'master' into HEAD which is a bit confusing because it's not clear which master branch we are talking about.
It would be even better if you could convert the above into a real bash script and check it into this repo for record-keeping. Then you could just run the script instead of doing things manually.
Aside: it looks like the --allow-unrelated-histories flag is not required, at least on the Git version I am using <IP_ADDRESS>1.gb435a96ce8-goog.

/lgtm /hold
Below are some comments for improvement for the next time we need to do this again.
I think your script can be improved like this:
# Clone old repo. Let's call it $old_prow.
git clone https://github.com/kubernetes/test-infra.git
# Strip down master branch of $old_prow to only have commits that touch the the /prow directory.
cd test-infra
git-filter-repo --path prow

# Navigate to your local clone of https://github.com/kubernetes-sigs/prow.
# Let's call this $new_prow.
cd $new_prow
# Check out a new "sync" branch that we want to create a PR from.
git branch sync origin/main
git checkout sync

# Import commits from old_prow/master into "sync" inside $new_prow.
git remote add old_prow $old_prow
git fetch old_prow
git merge old_prow/master

This way, the merge commit will have the self-descriptive text Merge remote-tracking branch 'old_prow/master' into sync instead of the PR here which has just Merge branch 'master' into HEAD which is a bit confusing because it's not clear which master branch we are talking about.
It would be even better if you could convert the above into a real bash script and check it into this repo for record-keeping. Then you could just run the script instead of doing things manually.
Aside: it looks like the --allow-unrelated-histories flag is not required, at least on the Git version I am using <IP_ADDRESS>1.gb435a96ce8-goog.

But in this script, we are not actually using the local copy of the $old_prow.

But in this script, we are not actually using the local copy of the $old_prow.

We are using it, right? See last 3 lines of the script.

/unhold

But in this script, we are not actually using the local copy of the $old_prow.

We are using it, right? See last 3 lines of the script.

When I tried to run the last command of your version, I got this merge: old_prow/master - not something we can merge.

@timwangmusic Here's a new script called sync-prow.sh I wrote which is the same as the old one. It could be that your version of Git is too old, or perhaps you were using a dirty repo. I ran the script and it works without problems.
#!/usr/bin/env bash

set -euo pipefail

old_prow="$PWD/test-infra"
new_prow="$PWD/prow"

# Clone old prow.
if [[ ! -d "$old_prow" ]]; then
    git clone https://github.com/kubernetes/test-infra.git
fi
# Strip down master branch of $old_prow to only have commits that touch the the /prow directory.
pushd $old_prow
git-filter-repo --path prow
popd

# Clone new prow.
if [[ ! -d "$new_prow" ]]; then
    git clone https://github.com/kubernetes-sigs/prow
fi
cd $new_prow
# Check out a new "sync" branch that we want to create a PR from.
git branch sync origin/main
git checkout sync

# Import commits from old_prow/master into "sync" inside $new_prow.
git remote add old_prow $old_prow
git fetch old_prow
git merge old_prow/master

and running it gives me:
 $ ./sync-prow.sh
~/ztmp/test-infra ~/ztmp
Parsed 15720 commits
New history written in 3.30 seconds; now repacking/cleaning...
Repacking your repo and cleaning out old unneeded objects
HEAD is now at ba098cda6 Merge pull request #31671 from airbornepony/resultstore-config-cleanup
Enumerating objects: 102266, done.
Counting objects: 100% (102266/102266), done.
Delta compression using up to 48 threads
Compressing objects: 100% (25132/25132), done.
Writing objects: 100% (102266/102266), done.
Total 102266 (delta 62738), reused 102266 (delta 62738), pack-reused 0 (from 0)
Completely finished after 4.48 seconds.
~/ztmp
Cloning into 'prow'...
remote: Enumerating objects: 103201, done.
remote: Counting objects: 100% (3132/3132), done.
remote: Compressing objects: 100% (583/583), done.
remote: Total 103201 (delta 2451), reused 2873 (delta 2404), pack-reused 100069
Receiving objects: 100% (103201/103201), 35.15 MiB | 20.92 MiB/s, done.
Resolving deltas: 100% (62990/62990), done.
branch 'sync' set up to track 'origin/main'.
Switched to branch 'sync'
Your branch is up to date with 'origin/main'.
remote: Enumerating objects: 168, done.
remote: Counting objects: 100% (146/146), done.
remote: Compressing objects: 100% (41/41), done.
remote: Total 81 (delta 48), reused 58 (delta 25), pack-reused 0 (from 0)
Unpacking objects: 100% (81/81), 13.28 KiB | 424.00 KiB/s, done.
From /usr/local/google/home/linusa/ztmp/test-infra
 * [new branch]          master     -> old_prow/master
hint: Waiting for your editor to close the file... t
nil
Merge made by the 'ort' strategy.
 prow/apis/prowjobs/v1/types.go                    |  23 ++++++++-----------
 prow/apis/prowjobs/v1/zz_generated.deepcopy.go    |  26 ++++-----------------
 prow/cmd/sinker/main.go                           | 149 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 prow/cmd/sinker/main_test.go                      | 113 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 prow/config/config.go                             |  14 ++++++++---
 prow/config/config_test.go                        | 123 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 prow/config/prow-config-documented.yaml           |   6 +++++
 prow/crier/controller.go                          |   4 +++-
 prow/crier/reporters/resultstore/reporter.go      |   4 ----
 prow/crier/reporters/resultstore/reporter_test.go |  32 --------------------------
 prow/pjutil/pjutil.go                             |   3 +++
 prow/pjutil/pjutil_test.go                        |   6 +++++
 prow/pod-utils/clone/clone.go                     |  19 ++++++++++++---
 prow/pod-utils/clone/clone_test.go                |  36 +++++++++++++++++++++++++++++
 prow/tide/github.go                               |   9 ++++----
 15 files changed, 486 insertions(+), 81 deletions(-)

When it executed the last command, I was dropped into my editor to compose the commit message for the merge commit, so the script requires human interaction.


test_dummy_data_hierarchy is failing

This happens after setting granular=True by default in Semiology.

the test in Class TestDummyDataDummyDictionary fails because of the change in default behaviour
The tests in Class TestDummyDataHierarchyReversal fail because of the same issue. Can ignore for now until I update the assertions - won't have time yet

alternative: change default behaviour back

I thought the default behaviour is the one that ensures a reliable output.

yes so let's just leave it and I will fix later

c161a1d498f4108dbd2d6e91f3d5366035b154a8


Exception: Invalid PBX project

Hello,
I'm currently tying to integrate your Unity package in my iOS game (I'm using Unity 5.4.2p1). But I cannot pass the XCode build phase...
I took for instance the unity "messaging" quickstart example, and followed precisely the informations of the readme file to build it. However, when I hit the build button and wait for the unity build to complete, at the very end of the build Unity logs this message
Exception: Invalid PBX project (parsing line 0) UnityEditor.iOS.Xcode.PBX.Parser.ParseTree () (at /Users/builduser/buildslave/unity/build/PlatformDependent/iPhonePlayer/Extensions/XCode/PBX/Parser.cs:114) UnityEditor.iOS.Xcode.PBXProjectData.ParseContent (System.String content) (at /Users/builduser/buildslave/unity/build/PlatformDependent/iPhonePlayer/Extensions/XCode/PBXProjectData.cs:451) UnityEditor.iOS.Xcode.PBXProjectData.ReadFromStream (System.IO.TextReader sr) (at /Users/builduser/buildslave/unity/build/PlatformDependent/iPhonePlayer/Extensions/XCode/PBXProjectData.cs:458) UnityEditor.iOS.Xcode.PBXProject.ReadFromStream (System.IO.TextReader sr) (at /Users/builduser/buildslave/unity/build/PlatformDependent/iPhonePlayer/Extensions/XCode/PBXProject.cs:868) UnityEditor.iOS.Xcode.PBXProject.ReadFromString (System.String src) (at /Users/builduser/buildslave/unity/build/PlatformDependent/iPhonePlayer/Extensions/XCode/PBXProject.cs:863) Google.IOSResolver.UpdateProjectDeps (BuildTarget buildTarget, System.String pathToBuiltProject) Google.IOSResolver.OnPostProcessUpdateProjectDeps (BuildTarget buildTarget, System.String pathToBuiltProject) UnityEditor.HostView:OnGUI()
If I try to continue to follow the build instructions on the resulting XCode project (adding the UserNotification.framework to the list of dependencies, enabling the push notification service,...), at the link phase, XCode fails with the following link errors:
Undefined symbols for architecture arm64:  "_OBJC_CLASS_$_FIROptions", referenced from:      objc-class-ref in libApp.a(app_ios_c76c7d869e568a9b561ea55e25a7dcc0.o)  "_OBJC_CLASS_$_FIRInstanceID", referenced from:      objc-class-ref in libMessaging.a(messaging_0d72481c6b9f9d4c5456dcb81aa103f1.o)  "_OBJC_CLASS_$_FIRApp", referenced from:      objc-class-ref in libApp.a(app_ios_c76c7d869e568a9b561ea55e25a7dcc0.o)  "_OBJC_CLASS_$_FIRMessaging", referenced from:      objc-class-ref in libMessaging.a(messaging_0d72481c6b9f9d4c5456dcb81aa103f1.o)  "_kFIRInstanceIDTokenRefreshNotification", referenced from:      ____ZN8firebase9messaging17NotifyListenerSetEPNS0_8ListenerE_block_invoke in libMessaging.a(messaging_0d72481c6b9f9d4c5456dcb81aa103f1.o) ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 (use -v to see invocation)
What can I do? I already checked and "pod --version" outputs 1.1.1.
Thanks!

Exception: Invalid PBX project (parsing line 0) UnityEditor.iOS.Xcode.PBX.Parser.ParseTree
This sounds like https://github.com/firebase/quickstart-unity/issues/13 see https://github.com/CocoaPods/CocoaPods/issues/1275 where the Xcode project is rewritten as an xml file rather than a old-style plist (which is supported by the Unity Xcode API).
First thing to check is the format of the Xcode project, if it's an XML file it's probably worth reinstalling Cocoapods to make sure you really have the right version when it's executed by our plugin.  Failing that, it may be worth looking at the other plugins used by your game, it's possible another plugin is changing the Xcode project format.
Cheers,
Stewart

Hello,
Thank you for the fast answer. I "brew unlink cocoapods", "brew update" then "brew install cocoapods" and it installed version 1.2.0 (instead of 1.1.1). The PBX error disappeared of Unity for subsequent builds.
This resolved the issue :)


[Hotfix] Json Linker can get db_path properly when use UUID id

close #429

NoDataWarn because dynamo_liker can't put None in a single put + NoIdWarn because the key is to return None when searching for "invalid id" and tell the index that the id is invalid.


options

this tool should has options of minify.

@da0ka can you describe that in details? I'm not sure which options may be needed (I've used the minifier for 10 years and never got such need). I'm also a bit confused about how to divide options between regular mode and babel mode (ECMAScript 2020). Do you think to give different options for both minifiers is a good idea?

UglifyJS 3 and babel-minify has many options. but can't change it on test page.
your idea is good.


empty line after bullet list triggers second expansion page

take the following card with recall: header:
### What's crackin'?

it's about to:
- go down
- blow up

and then another sentence

When this card is shown in training, the first press on the spacebar shows the first line and the bullet point list. The last sentence is only shown after a second press on the spacebar. Any chance I can show the whole card with one press on the spacebar?

Hi. This one is easy. Simply put a single space on the blank line.
Please note: You need to disable the files.trimTrailingWhitespace setting in VSCode, otherwise the space will get removed upon saving the file.

Thanks for the tip! I also looked around and a simple html comment in the empty line works as well, so files.trimTrailingWhitespace may stay enabled


Minor clean-up to improve legibility

Minor clean-up to improve legibility and consistency.

@AzureMentor : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@AzureMentor Thanks for the edits. The PR is ready to merge. Publishing in this repository is suspended until Tuesday, March 2. Merging will resume Tuesday, and we'll merge this approved pull request at that time. Thanks.

Thanks, @ktoliver.  Have a great weekend! 😊

Thanks @AzureMentor


[F4 - Input parameters]

Description

Work performed on backend for API controller, routes and lib.
Frontend setup to take Input parameter and POST to backend.
Merges complete with main to update current branch with updated main.

Trello

Link: https://trello.com/c/6ywnX3hQ/59-f4-input-parameters-5

Please remove those unneeded codes, then feel free to merge it.


feat: Add support for passing args and environment vars to terraform_validate

I set out to allow support for passing environment variables and arguments to terraform_validate in order to address: https://github.com/pre-commit/pre-commit/issues/758#issuecomment-608113130
I noticed passing multiple arguments to the terraform_tflint hook did not work as documented for two reasons:

documentation examples missing required '--' prefix for args
for loop in main would overwrite $args, thus passing only the last specified "args" item

I resolved this issue for terraform_tflint and carried this pattern into terraform_validate
Added/corrected readme documentation for two affected hooks.

Closing in favor of https://github.com/antonbabenko/pre-commit-terraform/pull/125 as the implementation appears to be superior.


Add files via upload

@ahmedyahia219 This domain does not belong to a university, nor to a college. I have to close the request without merging. Please ensure that you are familiar with this repository rules located at the bottom of this page before submitting a new request.


mympd: 18.0.0 -> 18.1.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/jcorporation/myMPD/releases.
meta.description for mympd is: Standalone and mobile friendly web mpd client with a tiny footprint and advanced features
meta.homepage for mympd is: https://jcorporation.github.io/myMPD
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS

[!CAUTION]
A test defined in passthru.tests did not pass.

found 18.1.2 with grep in /nix/store/b2zzmip401jm2hsg8hhcv8qd5kdg1zqh-mympd-18.1.2
found 18.1.2 in filename of file in /nix/store/b2zzmip401jm2hsg8hhcv8qd5kdg1zqh-mympd-18.1.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

mympd

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/b2zzmip401jm2hsg8hhcv8qd5kdg1zqh-mympd-18.1.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mympd https://github.com/r-ryantm/nixpkgs/archive/014c9b3c3425aae970df0a15419d9e6d0f6ade62.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/014c9b3c3425aae970df0a15419d9e6d0f6ade62#mympd

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/b2zzmip401jm2hsg8hhcv8qd5kdg1zqh-mympd-18.1.2
ls -la /nix/store/b2zzmip401jm2hsg8hhcv8qd5kdg1zqh-mympd-18.1.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

mympd

Maintainer pings
cc @doronbehar for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

A test defined in passthru.tests did not pass.

I was able to build its test :O

A test defined in passthru.tests did not pass.

I was able to build its test :O

ofborg too built these successfully. Would have been nice of r-ryantm would have shared more logs with us ..


interpolation to 4D pressure

@JulioTBacmeister I'm struggling with doing this efficiently.  At some point you posted in our chat what you were doing but I've lost the chat history.  Can you let me know what you're doing to interpolate onto a 4-dimensional pressure efficiently?  Thanks

I'm not really worrying about efficiency at this point, but here is what I'm doing

conservative horizontal remapping from ERA5 to CAM grid using ESMFpy
follwed by 1D interpolation in the vertical using scipy's interpolate package. i.e., e.g.,
"from scipy import interpolate as intr"

My performance numbers - interpolating ERA5 with 6 times X 5 variables (T,q,u,v,w) to an ne30pg3 L58 CAM grid - are these:
Reading all ERA5 variables ~160 seconds
Vertical interpolation ~140 seconds
other processing ~120 seconds
I'm hoping eventually we can exploit the "embarrassing parallelism" of the vertical interpolation using DASK. But as I said I am not worried about efficiency at this point - I just want something that works correctly and that I understand
My codes are here if you want to have a look:
/glade/work/juliob/myPythonTools/NudgingDataPrep/

Ok, thanks.  So at the moment you're just doing a straightforward extrapolation when the CAM lowest model level is below the ERA5 lowest model level?  I was finding that GeoCAT interp_hybrid_to_pressure function was essentially unusable.  I don't know how long it was taking to do 6 times x 5 variables because I didn't let it get there.  I got too impatient.  Perhaps I'll follow your approach using interp1d and try add the extrapolation based on lapse rate feature.  @brianpm - does that sound like a reasonable approach to you?  Or do you think ncremap would be better, as we talked about yesterday.

Right, I just use scipy's fill_value='extrapolate' mode.  BTW I am using quadratic vertical interpolation for T.


Access HttpContext in IImageService

Hi Jim,
Currently I am trying to use ImageProcessor in an EPiServer project, where I need to access HttpContext inside IImageService, is there any chance I can do it?
Regards,
Hieu.

Hi @chrno1209
Sorry, I thought I'd answered this. You can probably get away with HttpContext.Current.
Cheers
James

Hi @JimBobSquarePants ,
I did try to access HttpContext.Current but it's always NULL, that's why I dropped a question here :).
Thanks.

Odd. I see in the linked issue you were able to access it in the HttpModule instead. 👍

Yes, but anyway we can close this ticket :)


Remove the logger.Message ContainerID field

- What I did
Based on conversations in https://github.com/docker/docker/issues/20726, I was looking at teaching the json-logs log reader logic to populate the ContainerID field in Messages that it was sending back to the LogWatcher, and noticed that the only code that ever read the field was test code.  Based on that, I'm proposing removing the field.
- How I did it
Delete, delete, delete.
- How to verify it
Confirm that logic that writes to logs in the log drivers is unaffected because it doesn't read the container ID from Message structures, and that the logs handler doesn't read them, either.
- Description for the changelog
(none)

Running a container with --log-opt tag="{ .ContainerID }}"  still works with this, so seems to all still work indeed :smile:

It's funny. LGTM

LGTM


Ability to call .any_actions, similar to .target_actions

Most streams provide a convenience method on the object so you don't have to import the function from actstream.models. However, the any_stream doesn't. Could this possibly be provided?
>>> object.any_actions.all()

unfortunately those handy helpers are GenericRelatedObjectManagers and django sets them up internally when using GenericRelations. there are only 3 (actor/target/object) which are setup so you will have to use those or use the any_stream helper function.


Question regarding generate positive pair sentences

Great works!  If I wanna using SimCSE in the doc query match scenario could this method work? The query contains more words than 'doc'.

Hi tianyu,
after I read the trained train.py I found the code where you do the  'positive pair' embedding.
My question is what if in a sceneraio where I have pair datasets(s1,s2) could I still can generate 'positive pair'.? My understanding is that I need to change the following code to four columns [s1 , s1, s2 , s2]. Is that right? Looking forward for your reply.
if len(column_names) == 2:
# Pair datasets
sent0_cname = column_names[0]
sent1_cname = column_names[1]
elif len(column_names) == 3:
# Pair datasets with hard negatives
sent0_cname = column_names[0]
sent1_cname = column_names[1]
sent2_cname = column_names[2]
elif len(column_names) == 1:
# Unsupervised datasets
sent0_cname = column_names[0]
sent1_cname = column_names[0]
else:
raise NotImplementedError

Hi,
You can definitely use this for doc-query match (though you may want to adjust the max sequence length for your documents might be composed of much more words. I didn't quite get your second question. If you use a pair dataset (which I think so fo r doc-query match), you should be able to directly use the #pair datasets part of data processing code.

Thanks tianyu! My understanding is that if I already have a pair datasets then simCSE will not be much helpful, for I do not need to generate similar representation. And since I do not have a hard negative sentence( in this paper z3) I can not use the loss  in equation 5. Is that right? Sorry to bother you again,

You're right. However, you can also use similar loss functions for your pair dataset with dual-encoders (which is the case in many doc-query retrieval models).

Thanks!


create rust.rs

wont actually run because it's not main.rs; but renaming it works.

Thank you for contribution. It works great!


No export on Stickyfill

Hi. I got this error message using Stickyfill with React(typescript)
Module '"/stickyfilljs/types/index"' has no default export.
I tried to add export function forceSticky(): void into '"/stickyfilljs/types/index.d.ts"' but it didn't work
Can you help me with this problem please?

@JuryHa I know it's been some time now since you asked this question, but have you tried
import * as Stickyfill from "stickyfilljs"; OR just adding "allowSyntheticDefaultImports": true to your tsconfig.json?


Does it support DCN V2? Or shall we add it as custom ops?

Hello, have you implemented the custom ops for deformable convolution?
Could you please share it? Thanks a lot!


Bump appc/spec and update discovery

This is simply #485 plus bumping the spec.
#; rkt  trust --prefix coreos.com/etcd
Prefix: "coreos.com/etcd"
Key: "https://coreos.com/dist/pubkeys/aci-pubkeys.gpg"
GPG key fingerprint is: 8B86 DE38 890D DB72 9186  7B02 5210 BD88 8818 2190
	CoreOS ACI Builder<EMAIL_ADDRESS>Are you sure you want to trust this key (yes/no)? yes
Trusting "https://coreos.com/dist/pubkeys/aci-pubkeys.gpg" for prefix "coreos.com/etcd".
Added key for prefix "coreos.com/etcd" at "/etc/rkt/trustedkeys/prefix.d/coreos.com/etcd/8b86de38890ddb7291867b025210bd8888182190"


Add autoprefixer post-processor and browserlist config file

It’s no longer best practice for pre-processors like Sass to handle
prefixing. Instead, a post-processor is better suited for this task and
allows you to write much cleaner Sass (no more @include for
prefixes!).
Autoprefixer is a robust, well-maintained tool to post-process
prefixes.
Autoprefixer ties into the "Can I use" database and allows you to
specify the exact browser support you need, per project. This is quite
powerful, yet painless.
We successfully experimented it in our last couple projects.

:+1:


Hide insternal type

Pull Request Test Coverage Report for Build 45

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 44:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls


Auto-correct dead guides links caused by shifts in what 'latest' points to

There are several points in an extension's lifecycle when its guide link might be invalid, and it's not the extension's "fault".

An extension has been newly released, but isn't in a platform release yet, so only main/guides links work, not the preferred guides links. See, for example, https://github.com/quarkusio/quarkus/issues/31148.
An extension isn't available in the latest release of a platform, but is still available in earlier releases. Links with latest in them will be broken by the new release. For example, https://camel.apache.org/camel-quarkus/latest/reference/extensions/smallrye-reactive-messaging.html stopped existing when the Camel Quarkus 3 release was done.

The root problem is a mismatch in the release cadence of the documentation web pages and the individual extensions. As discussed in https://github.com/quarkusio/quarkus/issues/31148 and https://github.com/quarkusio/extensions/issues/155, it's not practical to change guide links in extensions on the exact same cadence as the web pages change. Instead, we can do some pragmatic adjustments to links:

If a link doesn't exist in guides but does exist in latest/guides, link to that
If a link doesn't exist in latest but does exist in an earlier version, link to that

I resolved this for the extensions page with #196. However, @maxandersen points out that this doesn't help any of the other consumers of the registry, so we should port this change to the central registry.
Implementation
I think this needs to be done either as a nightly job, or as a transparent rewrite before serving data on endpoints. It needs URL lookups, which can be slow, so a nightly job might be best.
We can't do it on upload, because that doesn't catch the case where an external link changes 'after' the extension has been released.
We should rewrite the guides link to a correct one, not just drop it.
Deprecated extensions
There's a third case where extensions may have dead links, which is that they're deprecated.
In the extensions UI, I auto-hide dead links in deprecated extensions, so we could consider porting that change, too.
(Sometimes  an extension has been deprecated, but no release with deprecated status was made. Since the extension is deprecated, the docs pages have been taken down. It would be a lot of effort to do a special release of the extension just to update the status. We have added the ability to patch extensions in the registry to add a deprecated status. See, for example,  https://github.com/quarkusio/quarkus-extension-catalog/pull/52.)

We may want to make a more significant change as part of this work item.
@maxandersen points out "we really need to find another way for extensions to point to docs beyond "latest" if we can't keep urls working. actually even if we can keep it and the link is there...its not the right one for older extensions."
And I added "I think the ideal state is that in the source control the guides link is fairly generic (specify a domain, specify a page name) and then in the registry it's mapped to one which is specific for that version.
At the moment we don't see the problem tooo badly because we only expose the latest extension, so a 'latest' link is ok, most of the time (but not always). At some point we'll start exposing other versions and then the guides links will be wrong for the older ones."


Upload hfuzz_workspace in case the fuzzer fails

In order to debug the fuzzer locally, once has to load the crash
file in the debugger. As such, we upload the whole fuzzer workspace
as an artefact so it can be downloaded from the CI job.
Fixes #52.

Getting this one in now in case the fuzzer fails again on another PR.


harmonize "Code for" and "Code from"

There are 175 occurrences of "Code for" e.g.
https://github.com/bkamins/JuliaForDataAnalysis/blob/7e9aea96912798be222f2078e4b82fb137b3ac51/ch02.jl#L5
and 20 occurrences of "Code from" e.g.
https://github.com/bkamins/JuliaForDataAnalysis/blob/7e9aea96912798be222f2078e4b82fb137b3ac51/ch01.jl#L5
Is that intended? Shall I provide a PR or do you fix it yourself if this is not intended?

I wanted to use "code from" for sections and "code for" for other types of references. Given your suggestion I have synchronized everything as "code for". Thank you!


Rewrite breaks insert into statement

INSERT INTO `user` (`id`, 'faker.Person.Name()' AS `username`)

It looks like rewritemap is applied too early

or getColumnsForSelect returns a struct with two functions then getRewritedColumns, getColumns

Both solutions are legit, the second one may be a bit cleaner but will increase (slightly) the memory footprint.
If you want to open a PR :heart:, go for the one you feel would be the best :slightly_smiling_face:

I am struggling with the current tests. They fail weird 😅


Motion-list: Prevent wrong display in motion-list

Current behaviour:
It is possible that the UI of a motion does not load correctly for the motion-list
Reproduction:
in a meeting:

create a motion
select something in recommendation
navigate to the motion-block overview
reload page
navigate back to the motion-list
UI is wrong
reload page in motion-list to get the wanted UI

wrong UI:

Correct UI:

Wanted behaviour:
The correct UI should always be displayed

Where is the difference between good and wrong ui?

@reiterl there is not only more space in between the state (zugelassen) and the recommendation (Annahme), in the wrong Ui there is also no margin between the recommendation and the end of the row

@reiterl  I added steps 2 to 6 to explain how to activate the recommendations

This issue was solved by #2924


fix: feedback widget design changes

updated the widget to be added to the footer
updated designs

Checklist
I have:

[ ] run the content through Grammarly
[ ] linked to sample apps when relevant
[ ] added the meta description for each page in the PR
[ ] minimized the callouts and added only when necessary
[ ] added the queryString parameter to the Tabs (if used)
[ ] masked PII in images. For example, login credentials, account details, and more
[ ] added images only when necessary
[ ] deleted the images that are no longer used for the updated pages in the PR
[ ] followed the image file naming convention while renaming or adding new images. (Use lowercase letters, dashes between words, and be as descriptive as possible)
[ ] used the <figure/> tag instead of a markdown representation for images
[ ] added the <figcaption/> tag to add a caption to the image
[ ] added the alt attribute in the <img/> tag
[ ] verified and updated the cross-references or created redirect rules for the changed or removed content
[ ] reviewed and applied the style changes for UI formatting. For example, Bold the UI elements(Buttons on screen) used in the doc.

Icon Button missing the states, Default, Hover, Active, Focus.
Icon button as a whole is not have cursor to Pointer. Only the icon is having currently.
Heading: "Was this page helpful?"
color: var(--colors-ui-content-heading-section-heading, #364252);
font-family: SF Pro Display;
font-size: 20px;
font-style: normal;
font-weight: 500;
line-height: 125%;

Icon Button missing the states, Default, Hover, Active, Focus. Icon button as a whole is not have cursor to Pointer. Only the icon is having currently.
Heading: "Was this page helpful?"
color: var(--colors-ui-content-heading-section-heading, #364252); font-family: SF Pro Display; font-size: 20px; font-style: normal; font-weight: 500; line-height: 125%;

We are using the font family that is used across doc pages.
I'll fix the cursor for the icon button.

Icon Button missing the states, Default, Hover, Active, Focus. Icon button as a whole is not have cursor to Pointer. Only the icon is having currently.
Heading: "Was this page helpful?"
color: var(--colors-ui-content-heading-section-heading, #364252); font-family: SF Pro Display; font-size: 20px; font-style: normal; font-weight: 500; line-height: 125%;

We are using the font family that is used across doc pages.
I'll fix the cursor for the icon button.

Added hover styles. The active or clicked states will not be visible as a thank you message is shown to the users.

@jnikhila This looks good!

Please approve the PR. @vasanthappsmith


Remove -u (update deps) paramter that is breaking :GlowInstall

When doing go get -u github.com/charmbracelet/glow GO is attempting to update the named packages
and their dependencies and this is causing the build to fail due to breaking changes.
This PR removes the -u parameter and ensures we only get and build known working deps.
Tested on Apple OS X and Linux

This should help address issue #8

@ellisonleao could you please review this?

Thanks for the PR @medoix but i am making another install method for glow in #8 following the install instructions in the main repo

Thanks @ellisonleao, the steps in #8 do work manually but this change gets it to work automatically for me using Packers run = ':GlowInstall' command


Update README.md

Have you read the Contributing Guidelines ?
Yes, I have read the Contributing Guidelines.
Description
This pull request includes the README file for the "Explore Business Analytics" project using the superstore.csv dataset. The README provides an overview of the project, details about the dataset, objectives, potential business problems to explore, tools that can be used, and examples of dashboards. Additionally, it includes guidelines on getting started with the analysis and potential insights that can be derived.
The motivation for this change is to provide clear, comprehensive documentation that will guide contributors and users through the process of exploring business analytics with the provided dataset. It aims to ensure that the project is accessible, understandable, and useful for those interested in business analytics.
Fixes #1087

Checklist

[ x ] I've read the contribution guidelines.
[ x ] I've checked the issue list before deciding what to submit.
[ x ] I've edited the README.md and link to my code.

Related Issues or Pull Requests
This PR focuses on enhancing the project documentation to facilitate better understanding and usability for contributors and users.

I have done some changes please do review it and let me know. If it requires anymore changes. I also want to mention about the label 'level0' tag as there is no 'level0' mentioned in the program.
Thank you.


[FEA] ORC Predicate pushdown for Nested fields

Apache Spark added support for ORC predicate pushdown for Nested fields in https://issues.apache.org/jira/browse/SPARK-25557.  We should look if it's worth to update the code in OrcFilters.scala esp method isSearchableType.

Could anyone share how to test this feature ?
According to the comment , we probably only need to add tests for this.

I suggest looking at the tests in the Spark issue.

I suggest looking at the tests in the Spark issue.

Thanks, and yes, I did something similar to the Spark tests.


Cilium integration with OpenStack Kuryr

Proposal / RFE
Is your feature request related to a problem?
No
Describe the solution you'd like
Provide a possibility to run Cilium on top of OpenStack Kuryr (https://github.com/openstack/kuryr-kubernetes), in the similar way as it's possible to run Cilium on top of Flannel.
Action items:
Initial:

[ ] Provide dev environment with devstack (as a patch to Vagrant configuration, similar to https://github.com/cilium/cilium/blob/master/contrib/flannel/run-flannel.diff)
[ ] Add .conflist configuration file which will refer to Kuryr and
[ ] Add handler for Kuryr's CNI configuration in plugins/cilium-cni/cilium-cni.go

Things to research

[ ] How to handle load balancing - shall we integrate with OpenStack Octavia?

I respectfully submit that this issue should not be closed as stale. In lieu of closure, I would appreciate a clear communication if implementation is not currently planned.

This issue was first filed in 2019 and there are zero reactions to the issue until last month. I doubt that anyone is planning something. That said, if someone wants to make a feature proposal that will improve integration with OpenStack Kuryr then I would encourage posting such a proposal in this issue.
That said, without clear signal about interest in this proposal it will go stale over time regardless, so I don't see a strong reason to keep it open. We can reopen it again as and when there is community interest in contributing changes to improve integration with OpenStack Kuryr.


Add link in Github repo description

https://docs.getaurora.dev/ should be displayed here.

Done.

I will close the issue since this id one.


event admin should be able  add new challenges to event.

Deleting a challenge from event does not make sense actually, since there might be some teams which are solved and some not, and deleting that challenge will create confusion across teams. Therefore it is better to have only add challenge option.
Event administrators will be able to add challenges through webclient and all labs will include that particular challenge

#648
It requires to have big scale testing.


error message

I will run tutorials_beginner/agent_fingpt_forecaster.ipynb
import autogen
but error message say:
ModuleNotFoundError: No module named 'openai.lib._parsing'

#The issue has been resolved.
The newly released version of PyAuto from yesterday might be a bit unstable, so I resolved the problem by using the older version 0.4.
https://pypi.org/project/pyautogen/


Timestamp-like strings lose quote

What steps did you take:
When I provide a string but contains timestamp, after templating with Ytt this strings lose the quote.
This would be valid, but yaml parsers handle this as a date not a string and convet it like Mon Sep 20 12:00:00 CEST 2021.
This happens even I turn on strict yaml, according to rule "requires strings with colon to be explicitly quoted"
template.yaml:
exampleTimestamp: "2023-01-01T07:00:00"
ytt -f template.yaml
ytt -f template.yaml -s
What happened:
exampleTimestamp: 2023-01-01T07:00:00
What did you expect:
exampleTimestamp: "2023-01-01T07:00:00"
Environment:

ytt version (use ytt --version): ytt version 0.47.0
OS (e.g. from /etc/os-release):
ProductName:		macOS
ProductVersion:		14.2.1
BuildVersion:		23C71

Vote on this request
👍 "I would like to see this addressed as soon as possible"

checking...

@deblaci
I think your timestamp format is not correct (either it needs a timezone or a space between date and time).
Which is the other yaml parser your are using which is parsing the unquoted string as timestamp?
 % cat timestamp.yaml
canonicalts: "2023-01-01T07:00:00.1Z"
canonicalts1: 2023-01-01T07:00:00.1Z
iso8601ts: "2023-01-01T07:00:00Z"
iso8601ts1: 2023-01-01T07:00:00Z
withspacets: "2023-01-01 07:00:00"
withspacets1: 2023-01-01 07:00:00

 % ytt -f timestamp.yaml
canonicalts: "2023-01-01T07:00:00.1Z"
canonicalts1: "2023-01-01T07:00:00.1Z"
iso8601ts: "2023-01-01T07:00:00Z"
iso8601ts1: "2023-01-01T07:00:00Z"
withspacets: "2023-01-01 07:00:00"
withspacets1: "2023-01-01 07:00:00"

and currently ytt cannot force quotes see https://kubernetes.slack.com/archives/CH8KCCKA5/p1688043220329239 and https://kubernetes.slack.com/archives/CH8KCCKA5/p1668521528903319.

@prembhaskal
Thanks for checking.
According to (https://yaml.org/type/timestamp.html), "2023-01-01T07:00:00" seems to be valid. I tried the regex.
But If I would agree with the above timestamp is wrong, the above timestamp needs to be considered as a String.
Shouldn't Ytt generate a strict yaml in strict mode?
When I use Ytt in Strict mode, I give strict input yaml then I will get a non-strict yaml, since "exampleTimestamp: - 2023-01-01T07:00:00" is not a strict yaml without quote. (https://carvel.dev/ytt/docs/v0.46.x/strict/)

ytt: Error: Unmarshaling YAML template 'temp-yaml': • yaml:
Strict parsing:
Strings with colon must be explicitly quoted: • '2023-01-01T07:00:00'

I tried to parse the yaml with Groovy:
import org-yaml.snakeyaml.Yaml
new Yaml(). load(yamlContent)
With Jenkins readYaml has same result

@deblaci so strict yaml is only for parsing.
mainly we use strictdecoder of yaml library to achieve this. there is no encoder for strict output generation.

Upstream does not have this feature.
We will try and find cycles to patch upstream.


Provide a Global Cache for popular Frameworks

While there's already a local and a shared cache option available, both of these are not particularly useful when installing dependencies (the first time) on a CI. CI build times can be very long (especially on first run) for dependencies. While some might opt to configure their shared cache on the CI as well, this can be a hassle dependending on the service used for the shared cache.
A global cache could be tackled in various ways:

Everybody using Accio worldwide could opt to upload any build products to the global cache. Advantages: High availability of frameworks. Disadvantages: Security concerns and too much space taken by build products.
Only GitHub Open Source frameworks with at least 100 stars and only versioned releases could be uploaded by everyone using Accio to the global cache. Advantages: Relatively high availability of frameworks & managable space taken by build products. Disadvantages: Security concerns.
A CI/Backend is provided specifically for building products and each instance of Accio can ask it to build a specific Open Source project – only versioned releases and at least 100 stars needed so it's actuallly built. Advantages: Better security (depending on CI/backend), relatively high availability of frameworks & managable space taken. Disadvantages: Framework availability delayed, costs for CI/backend.

These are the ways I think this could be tackled. I personally prefer point 3 most since XcodeGhost could always happen again and I don't want to be responsible for malware. I'm also very open to other ideas from the community – this will probably not be tackled until I feel we have found the best possible way dealing with a global cache.
Although I have only CI builds as a use case this feature was mainly designed for, I'm pretty sure that if we provide this feature, some developers will always use it regardless of any security concerns of warnings we might mention in the README.

Closing this, as Accio is now deprecated.


[NP-3341] Use ProxySlot on WizardSection isAvailable

I'll merge, but I think there must be an underlying bug that is preventing a simpler solution from working. Please schedule some time with me to debug.

I'll merge, but I think there must be an underlying bug that is preventing a simpler solution from working. Please schedule some time with me to debug.


NumPy 2.0 support

Problem description
NumPy 2.0 is coming out soon ( https://github.com/numpy/numpy/issues/24300 ). NumPy 2.0.0rc1 packages for conda & wheels came out a month ago ( https://github.com/numpy/numpy/issues/24300#issuecomment-2030603395 )
Feature description
NumPy has put out a migration guide. More details are in the release notes
If TensorFlow make use of NumPy's C API (and produces wheels that use it), having a release of TensorFlow with wheels built against NumPy 2.0.0rc1 would be helpful to ensure NumPy 1 & 2 compatible wheels (as wheels built against NumPy 1 won't be compatible with NumPy 2). More details in this NumPy 2 ABI doc
Also would recommend incorporating NumPy 2 in TensorFlow's CI
Also as NumPy is tracking ecosystem support for NumPy 2.0, it would be helpful to share TensorFlow's current support status in issue (with any plans): https://github.com/numpy/numpy/issues/26191
Additional information
There has been some discussion about TensorFlow's NumPy 2 plans here: https://github.com/numpy/numpy/issues/26191#issuecomment-2078401952
Also the Keras team is interested in this question as they depend on TensorFlow: https://github.com/keras-team/keras/issues/19691#issuecomment-2103062310
Lastly was unable to find an existing issue by searching or asking AI. So went ahead and opened this. If there's an existing one, happy to close and follow that
cc @MichaelHudgins @jakevdp @rgommers (for vis)

Am curious if anyone has had a chance to look into this. No worries if not
It is worth noting that NumPy is planning to release 2.0 on June 16th: https://github.com/numpy/numpy/issues/24300#issuecomment-2125643448

Sorry for the late reply, TF is working on the upgrade but it may not make the upcoming branchcut to ensure all cases around datatype promotion are handled correctly.  @kanglant is working on the upgrade and ensuring test owners verify updates.  We will give another status update by Friday on if it will make the 2.17 branchcut and when it can be expected in the nightly branch.

Thanks Michael! 🙏
No worries
Are Kanglan's changes in a PR? Or could they be added to one? Maybe members of the community could help review 🙂
FWIW did see these merged PRs:

https://github.com/tensorflow/tensorflow/pull/63317
https://github.com/tensorflow/tensorflow/pull/67852
https://github.com/tensorflow/tensorflow/pull/67864
https://github.com/tensorflow/tensorflow/pull/68271

Are there any others?

No other PRs right now that i think are ready yet.
I can say that at this point it looks like we will not make the target of next week's branchcut.  We need to verify if any of the fixes or modifications cause api level changes given TF's API compatibility guidelines.  We will target to get it into nightly as soon as we can.  We will look to use this issue to give regular updates until have made the 2.0 upgrade.

Would recommend that any released packages (wheels or otherwise) have an upper bound to disallow NumPy 2
Mentioning this as NumPy is planning to release on June 16th: https://github.com/numpy/numpy/issues/24300#issuecomment-2125643448

Upper bounds will just cause solvers like pip to select older versions of tensorflow without the bound.

Am aware that is true of Conda, but does the pip solver also have this behavior? Are there examples of this?

Ahh, yes, if nothing causes a backtrack, it does work. It can still backtrack in some cases and produce unhelpful solves, but by default it would help to have the limit. The simple case of pip install tensorflow will be broken tomorrow without a limit.

It won't be broken - TensorFlow has always used upper bounds for all of its dependencies AFAIK. I am pretty sure there are no versions of TensorFlow for Python 3.9-3.12 that depend on an unpinned numpy.

Yeah, tensorflow v2.16.1 had the following requirements (with caps on numpy < 2.0 introduced in https://github.com/tensorflow/tensorflow/commit/92b81403305ddba765d3fb9a64bae8f52bf90dfd on 2023-10-16)
https://github.com/tensorflow/tensorflow/blob/5bc9d26649cca274750ad3625bd93422617eed4b/tensorflow/tools/pip_package/setup.py#L85-L126

Unfortunately, the team won't upgrade any TF below 2.16, now that the process for 2.17 started and the builds for the last patch release on 2.16 have been triggered (it used to be that patches were given for a full year, now it's just one patch on the next release and that's all :shrug: )

Yeah that's all totally reasonable. 👍 I hope it didn't come across like I was hoping for anything to get back ported.

No, it's all good. In the old system, 2.14 and 2.13 would still have been updated to had the upper bound.

As long as the latest one has a bound, that’ll fix most cases. Weird backsolves will happen if someone requires >=2, but that isn’t possible to fix without NumPy 2 support, so it’ll just be a slightly stranger error message, which is totally fine I think.

Kind ping on this front.

We will target to get it into nightly as soon as we can. We will look to use this issue to give regular updates until have made the 2.0 upgrade.

I think there is still the fact that setup.py declares that 2.0 isn't supported:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/pip_package/setup.py#L88
Has the full test suite been run with success? Maybe we can start to use the new-style pinning?

There is some work on this front, see #72883

Sorry for the late reply. We're conducting thorough internal testing and expect to provide an update within the next few weeks.

hello, any news on this ?

Hi @jschueller , we've addressed most of the compatibility issues with NumPy 2, and you can expect TensorFlow nightly wheels compiled against NumPy 2 within the next week. 🎉

will it be announced somewhere when Tensorflow works with Numpy 2?  I upgraded to Python 3.12.5 because another plugin that I use did an upgrade and only works with Numpy 2 and higher.  So when I then install tensorflow it automatically uninstalls my Numpy 2.1 version and installs 1.26. So I  took down uninstalled Tensorflow for the time being. Of course I can still use my Python 3.8.5 version but I run my Python code from another program that requires Numpy 2 or higher.
Where will it be announced when Tensorflow has been upgraded to work with Numpy 2.0 and higher? Thanks

Most likely in this issue

is there a specific PR or commits we can backport on 2.17 for numpy 2 support ?

I think that's not possible. The development process results in individual commits to main branch and not all of them are tagged with the feature they are working towards.
I think the number of changes is quite significant, so you would have to cherrypick quite a large number of commits if you want to go that way and hope that the compilation process won't fail. If possible, wait a little bit, 2.18 is around the corner and might have numpy 2 by default.

fair enough, do you know the release schedule for 2.18 ?

I estimate (not on the team) that branch cut would happen by the end of this month and then in around at most a month there will be a final release. Definitely before Thanksgiving (end of Nov)

ok, thanks

A quick update: TensorFlow nightly wheels are now compiled with NumPy 2.0, starting with the latest release 2.18.0.dev20240919!

did not yet work for me. I did: pip install tf-nightly==2.18.0.dev20240919
but seems it is installing 2.17
Installing collected packages: numpy, tb-nightly, keras-nightly, tf-nightly-intel, tf-nightly
Attempting uninstall: numpy
Found existing installation: numpy 2.1.1
Uninstalling numpy-2.1.1:
Successfully uninstalled numpy-2.1.1
WARNING: Failed to remove contents in a temporary directory 'C:\Users\win 10\AppData\Local\Programs\Python\Python312\Lib\site-packages~~mpy'.
You can safely remove it manually.
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
tensorflow-intel 2.17.0 requires numpy<2.0.0,>=1.26.0; python_version >= "3.12", but you have numpy 2.0.2 which is incompatible.
Successfully installed keras-nightly-3.5.0.dev2024092003 numpy-2.0.2 tb-nightly-2.18.0a20240919 tf-nightly-2.18.0.dev20240919 tf-nightly-intel-2.18.0.dev20240919

Oh, that's because on Windows you also need tensorflow-intel, which is a separate package, developed by a TF collaborator: https://blog.tensorflow.org/2022/09/announcing-tensorflow-official-build-collaborators.html

ok thanks so I guess some more waiting. I think I will revert back to Python 3.8.5 for the time being

I think if you try with the linux version under WSL (or on a Linux host) it would work. It's just some Mac versions and the Windows one that are no longer done by Google.

i work on Windows. The program I use runs on windows. From that program I can use Python via a plugin. That plugin has been upgraded to work only with Numpy 2.0 and higher.  So that would require me to run Python 3.9 or higher and Numpy 2.0 or higher.  The reason I run Python from that program is because I have all my data in that program.
But I also still have the old plugin that works with Numpy below 2.0 and Python 3.8. So it is no big deal. I just use the old plugin and change my Path in the Environment settings back to 3.8.
So you are saying that on Windows I will have problems using Tensorflow from now on? Or will this be fixed at some point.

Will likely be fixed at some point once the companies doing the other builds update their builds.

@dutchy54321 I am sympathetic to your cause, but this isn't the place to have the discussion on windows support from the official tensorflow releases.
I think it may be more appropriate to read on in https://github.com/tensorflow/tensorflow/issues/59918
(PS. I am just an other user working to help on the integration front)

@dutchy54321 I am sympathetic to your cause, but this isn't the place to have the discussion on windows support from the official tensorflow releases.
I think it may be more appropriate to read on in #59918
(PS. I am just an other user working to help on the integration front)

I do not understand. I use tensorflow. I updated Python and a plugin I use. Then I had problems installing tensorflow after I installed the latest Numpy version. Then after searching I ended up in this thread. Does it matter which operating system I use?

Does it matter which operating system I use?

Unfortunately, yes. Google TF team can only provide support for Linux TF.

TensorFlow 2.18.0 supports numpy 2. Can this Issue can be closed?
python -m venv ./tf-numpy2
source ./tf-numpy2/bin/activate
python --version
## Python 3.10.15
python -m pip install --prefer-binary numpy==2 tensorflow-cpu
pip list | grep -e numpy -e tensorflow
## numpy                        2.0.0
## tensorflow_cpu               2.18.0
## tensorflow-io-gcs-filesystem 0.37.1
python -c "import tensorflow as tf; print(tf.add(1, 2).numpy())"
## 3
python -c "import tensorflow as tf; print(tf.constant('Hello, TensorFlow').numpy())"
## b'Hello, TensorFlow'

thanks for the reminder


Fix publishing of the documentation

In GitLab by @Manangka on Oct 18, 2023, 17:00

mentioned in commit 53b957ccbc2c7da2629a243f6455beb9577b46a3


[Autocomplete] Support for nested options arrays

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example: https://codesandbox.io/s/autocomplete-nested-array-48y3y0
Steps:

Create an options array which is a nested array
use renderOption to create the HTML for the nested array to show
start typing in the text field box to search for relevant key value

Current behavior 😯
What I  am trying to achieve here is the autocomplete that I have created, for that I want the search to work when someone starts typing. Instead No Options starts showing up.
I have tried using getOptionLabel as well, but that has not helped.
Expected behavior 🤔
Ideally when I start typing the matching string values should start showing up.
Context 🔦
Since the live list can be quite long, hence search behaviour is required, without it the user will keep on scrolling, taking a lot of time what the user is trying to find.
Your environment 🌎
No response

The Autocomplete component doesn't currently support tree-like options.
You can possibly hack something together with the help of the filterOptions prop, which lets you define your own filtering logic. Note that the solution in its current shape is not accessible (keyboard navigation doesn't work).

I'm closing as "won't fix". This looks like a generic question on how to use https://mui.com/material-ui/react-autocomplete/#grouped
It's also a  bit related to https://github.com/mui/mui-x/issues/514 but different.