platformio可以使用这个库吗

我用arduino IDE 开发，编译有点慢，想转到vscode。platformio里也有一个esp32_display_panel库，发现不同步的，用不了。platformio可以使用这个库吗？

抱歉，这个库目前还未在 platformio 上使用过，我会抽空尝试一下。

[env:ESP-LCD]
platform =<EMAIL_ADDRESS>board = ESP-LCD
framework = arduino
platform_packages =
	platformio/framework-arduinoespressif32@https://github.com/espressif/arduino-esp32.git
	platformio/framework-arduinoespressif32-libs@https://github.com/espressif/esp32-arduino-libs.git#idf-release/v5.1
upload_speed = 921600
monitor_speed = 115200
build_flags =
	-DBOARD_HAS_PSRAM
	-DLV_CONF_INCLUDE_SIMPLE
	-DDISABLE_ALL_LIBRARY_WARNINGS
	-DARDUINO_USB_CDC_ON_BOOT=1
	-DCORE_DEBUG_LEVEL=1
	-DLV_LVGL_H_INCLUDE_SIMPLE
	-I src
	-D VN=1
	-D ESP32S3=1
lib_deps =
	https://github.com/esp-arduino-libs/ESP32_Display_Panel.git
	https://github.com/esp-arduino-libs/ESP32_IO_Expander.git
    https://github.com/lvgl/lvgl.git#release/v8.3

Please try following the above configuration.

Thanks a lot @Lzw655, this would mean a lot,
Hello @isthaison Congrats And Thanks a lot for letting us know that at least efforts to make the library work on platformio are not always futile...
I am using PlatfformIo to drive RGB LCD 3 wire spi DataPins(15)
According to your Comment
https://github.com/esp-arduino-libs/ESP32_Display_Panel/issues/19#issuecomment-2134217055
have modified my platform.ini file
hope its correct
platform.ini.txt
Project Dependancies
dependencies.txt
This is main.cpp directing to just one One Lvgl Task
main.txt
Here is the task defined
DEVICE_LVGL_V8.txt
Library Specific
ESP_Panel_Board_Custom.txt
ESP_Panel_Conf.txt
here is the compile log  to further understand...
PlatformIO Test log
<EMAIL_ADDRESS>

Hi @isthaison,
Thank you for testing it. I checked your ESP_Panel_Board_Custom.txt file and the macro ESP_PANEL_USE_CUSTOM_BOARD  should be set to 1 which is 0 now. Please change it and try again.

@Lzw655  You tagged the wrong person 👯
@hrituraj-rohariya

Oh, that's embarrassing... 😂

🤣🤣🤣

Hi @isthaison,
Thank you for testing it. I checked your ESP_Panel_Board_Custom.txt file and the macro ESP_PANEL_USE_CUSTOM_BOARD  should be set to 1 which is 0 now. Please change it and try again.

Hello @Lzw655  i have defined the ESP_PANEL_USE_CUSTOM_BOARD to 1in ESP_Config.h file...and have  included the file in ESP_Panel_Board_Custom.h
Its a Macro and its working from  there too...

[env:ESP-LCD]
platform =<EMAIL_ADDRESS>board = ESP-LCD
framework = arduino
platform_packages =
	platformio/framework-arduinoespressif32@https://github.com/espressif/arduino-esp32.git
	platformio/framework-arduinoespressif32-libs@https://github.com/espressif/esp32-arduino-libs.git#idf-release/v5.1
upload_speed = 921600
monitor_speed = 115200
build_flags =
	-DBOARD_HAS_PSRAM
	-DLV_CONF_INCLUDE_SIMPLE
	-DDISABLE_ALL_LIBRARY_WARNINGS
	-DARDUINO_USB_CDC_ON_BOOT=1
	-DCORE_DEBUG_LEVEL=1
	-DLV_LVGL_H_INCLUDE_SIMPLE
	-I src
	-D VN=1
	-D ESP32S3=1
lib_deps =
	https://github.com/esp-arduino-libs/ESP32_Display_Panel.git
	https://github.com/esp-arduino-libs/ESP32_IO_Expander.git
    https://github.com/lvgl/lvgl.git#release/v8.3

Please try following the above configuration.

[env:ESP-LCD]
platform =<EMAIL_ADDRESS>board = ESP-LCD
framework = arduino
platform_packages =
	platformio/framework-arduinoespressif32@https://github.com/espressif/arduino-esp32.git
	platformio/framework-arduinoespressif32-libs@https://github.com/espressif/esp32-arduino-libs.git#idf-release/v5.1
upload_speed = 921600
monitor_speed = 115200
build_flags =
	-DBOARD_HAS_PSRAM
	-DLV_CONF_INCLUDE_SIMPLE
	-DDISABLE_ALL_LIBRARY_WARNINGS
	-DARDUINO_USB_CDC_ON_BOOT=1
	-DCORE_DEBUG_LEVEL=1
	-DLV_LVGL_H_INCLUDE_SIMPLE
	-I src
	-D VN=1
	-D ESP32S3=1
lib_deps =
	https://github.com/esp-arduino-libs/ESP32_Display_Panel.git
	https://github.com/esp-arduino-libs/ESP32_IO_Expander.git
    https://github.com/lvgl/lvgl.git#release/v8.3

Please try following the above configuration.

Hello @isthaison, I was just wondering where to find the installed library after adding them through ini file? Could not find them either in the lib or libdeps folder

there are include on folder .pio
Nguyễn Thái Sơn
Vào Th 7, 8 thg 6, 2024 lúc 08:28 3OF26-The-Great @.***>
đã viết:

[env:ESP-LCD]
platform = @.***
board = ESP-LCD
framework = arduino
platform_packages =
@.://github.com/espressif/arduino-esp32.git
@.://github.com/espressif/esp32-arduino-libs.git#idf-release/v5.1
upload_speed = 921600
monitor_speed = 115200
build_flags =
-DBOARD_HAS_PSRAM
-DLV_CONF_INCLUDE_SIMPLE
-DDISABLE_ALL_LIBRARY_WARNINGS
-DARDUINO_USB_CDC_ON_BOOT=1
-DCORE_DEBUG_LEVEL=1
-DLV_LVGL_H_INCLUDE_SIMPLE
-I src
-D VN=1
-D ESP32S3=1
lib_deps =
https://github.com/esp-arduino-libs/ESP32_Display_Panel.git
https://github.com/esp-arduino-libs/ESP32_IO_Expander.git
https://github.com/lvgl/lvgl.git#release/v8.3
Please try following the above configuration.
[env:ESP-LCD]
platform = @.***
board = ESP-LCD
framework = arduino
platform_packages =
@.://github.com/espressif/arduino-esp32.git
@.://github.com/espressif/esp32-arduino-libs.git#idf-release/v5.1
upload_speed = 921600
monitor_speed = 115200
build_flags =
-DBOARD_HAS_PSRAM
-DLV_CONF_INCLUDE_SIMPLE
-DDISABLE_ALL_LIBRARY_WARNINGS
-DARDUINO_USB_CDC_ON_BOOT=1
-DCORE_DEBUG_LEVEL=1
-DLV_LVGL_H_INCLUDE_SIMPLE
-I src
-D VN=1
-D ESP32S3=1
lib_deps =
https://github.com/esp-arduino-libs/ESP32_Display_Panel.git
https://github.com/esp-arduino-libs/ESP32_IO_Expander.git
https://github.com/lvgl/lvgl.git#release/v8.3
Please try following the above configuration.
Hello @isthaison https://github.com/isthaison, I was just wondering
where to find the installed library after adding them through ini file?
Could not find them either in the lib or libdeps folder
—
Reply to this email directly, view it on GitHub
https://github.com/esp-arduino-libs/ESP32_Display_Panel/issues/19#issuecomment-2155744585,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNPU6UFYXNXNGTZC35ER6LZGJM4XAVCNFSM6AAAAABFWNHP52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJVG42DINJYGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

there are include on folder .pio Nguyễn Thái Sơn Vào Th 7, 8 thg 6, 2024 lúc 08:28 3OF26-The-Great @.> đã viết:
…
[env:ESP-LCD] platform = @. board = ESP-LCD framework = arduino platform_packages = @.://github.com/espressif/arduino-esp32.git @.://github.com/espressif/esp32-arduino-libs.git#idf-release/v5.1 upload_speed = 921600 monitor_speed = 115200 build_flags = -DBOARD_HAS_PSRAM -DLV_CONF_INCLUDE_SIMPLE -DDISABLE_ALL_LIBRARY_WARNINGS -DARDUINO_USB_CDC_ON_BOOT=1 -DCORE_DEBUG_LEVEL=1 -DLV_LVGL_H_INCLUDE_SIMPLE -I src -D VN=1 -D ESP32S3=1 lib_deps = https://github.com/esp-arduino-libs/ESP32_Display_Panel.git https://github.com/esp-arduino-libs/ESP32_IO_Expander.git https://github.com/lvgl/lvgl.git#release/v8.3 Please try following the above configuration. [env:ESP-LCD] platform = @.*** board = ESP-LCD framework = arduino platform_packages = @.://github.com/espressif/arduino-esp32.git @.://github.com/espressif/esp32-arduino-libs.git#idf-release/v5.1 upload_speed = 921600 monitor_speed = 115200 build_flags = -DBOARD_HAS_PSRAM -DLV_CONF_INCLUDE_SIMPLE -DDISABLE_ALL_LIBRARY_WARNINGS -DARDUINO_USB_CDC_ON_BOOT=1 -DCORE_DEBUG_LEVEL=1 -DLV_LVGL_H_INCLUDE_SIMPLE -I src -D VN=1 -D ESP32S3=1 lib_deps = https://github.com/esp-arduino-libs/ESP32_Display_Panel.git https://github.com/esp-arduino-libs/ESP32_IO_Expander.git https://github.com/lvgl/lvgl.git#release/v8.3 Please try following the above configuration. Hello @isthaison https://github.com/isthaison, I was just wondering where to find the installed library after adding them through ini file? Could not find them either in the lib or libdeps folder — Reply to this email directly, view it on GitHub <#19 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFNPU6UFYXNXNGTZC35ER6LZGJM4XAVCNFSM6AAAAABFWNHP52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJVG42DINJYGU . You are receiving this because you were mentioned.Message ID: @.***>

Thanks mate, it appeared after I restart the vs code, but I have one problems is once I add
these two lines:
platform_packages =
platformio/framework-arduinoespressif32@https://github.com/espressif/arduino-esp32.git
platformio/framework-arduinoespressif32-libs@https://github.com/espressif/esp32-arduino-libs.git#idf-release/v5.1
it always gives me an error that says:
Error! Failed to extract upstream toolchainconfigurations:
Bad package version esp-12.2.0_20230208

Duplicated with #47

Hi @lowino,
你好，这个库刚刚合入了一个在 PlatformIO 上使用的示例，可以看看是否符合你的需求。

https://github.com/esp-arduino-libs/ESP32_Display_Panel?tab=readme-ov-file#how-to-fix-screen-drift-issue-when-driving-rgb-lcd-with-esp32-s3. They should handle several devices like here, C:\Users~.platformio. it also launches like arduino

I see you are using a package from platformio that is supporting it. it does not support arduino-esp32 v3.x.x yet. Please follow the instructions I have suggested above.

That finally works,  thanks!

编译通过 。感谢 @isthaison @Lzw655
在编译时，当使用Adafruit的板子进行编译时，会出现与toolchain相关的错误，这可能是由于esp32更新到6.X版本产生的问题。使用其他板子进行编译则未出现此问题，这个信息可能对遇到类似情况的开发者有所帮助。


Update ro.coffee

It had to be done! Sorry it took so long... Life happend...

Hello, @flowabuse! Thank you for contributing. Could you sign our CLA so that I can merge your pull request?

@nwinter, can you merge?

Wow, you did the whole thing in one go! Amazing! Thank you so much!
Not that there really needs to be a next time, since you did it all :) – but if you do translate any more, you can also uncomment each line by removing the # at the beginning like I just did in 339aaa0.


added the serializer for Answer model

Issue: 13
Short description of what this resolves:

Added the serializer for Answer model

Changes proposed in this pull request and/or Screenshots of changes:

removed the default option from answer model with Foreign key

can you add a code example of the serialised data
That would be great

That will do . Thank You 😊


Add support for scalaz-deriving

This is a tiny addition of a file scalaz-deriving.conf to the circe-generic module.
With this file, it is possible to use scalaz-deriving for derivation of circe Encoder and Decoder instances.
The code would look similar to the following:
import io.circe.{ Decoder, Encoder }

import scalaz._
import Scalaz._

// Derive circe Decoder/Encoder as well as scalaz Equal/Show
@deriving(Decoder, Encoder, Equal, Show)
final case class Foo(
  a: String,
  b: Int,
  c: List[String]
)

I understand that this is basically what circe's semi-automatic derivation does (and as a matter of fact, that is exactly what is used).
It would, however, be nice to support scalaz-deriving to have circe support a framework that can be used to derive instances beyond just circe itself.
Given the minimal impact this has (adding one file to the resources of the generic module), I hope this PR will be considered.

Codecov Report

Merging #913 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #913      +/-   ##
=========================================
+ Coverage   85.52%   85.6%   +0.08%
=========================================
  Files          76      76
  Lines        2459    2459
  Branches      157     157
=========================================
+ Hits         2103    2105       +2
+ Misses        356     354       -2

Impacted Files
Coverage Δ

...les/core/shared/src/main/scala/io/circe/Json.scala
78.84% <0%> (-0.65%)
:arrow_down:

...re/shared/src/main/scala/io/circe/KeyDecoder.scala
97.29% <0%> (+2.7%)
:arrow_up:

...rc/main/scala/io/circe/shapes/SizedInstances.scala
92.85% <0%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc4050...d486345. Read the comment docs.

Sure, this looks good to me, but could we change the Encoder to ObjectEncoder (a subtype that statically tracks the fact that the encode produces a JSON object, and the return type of deriveEncoder)?

That is a good idea, I made the change.


User override for default terminate action "stop" or "disconnect" in the debug toolbar

Currently, the default action is based on the launch configuration request, "launch" or "attach".  However, in some instances, one or the other may be more appropriate. I would like an additional parameter in the launch configurations to allow the user to override the default.
Something like:
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Attach to .NET Functions",
            "type": "coreclr",
            "request": "attach",
            "defaultTerminateAction": "stop",
            "processId": "${command:azureFunctions.pickProcess}"
        }
    ]
}

For example, in an Azure Functions project, the launch request is "attach" which results in the default action being "disconnect". However, it is much more likely in this scenario to want to stop the process (which is launched by vsCode despite the request being "attach").

This is basically the same as #130180 but that thread is closed and locked.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


Feature Request: PHP Supplementation

NOTABUG
I've got some great ideas for non-integrative PHP support. However, given that Foundation for Sites is a front-end library, would it be "incompatible" to add such support?
Here's the experiment I've been tinkering with:
https://github.com/paxperscientiam/foundation-sites/tree/composer-package
After cloning, just run ./test.sh from the ./php-test directory.

Add PHP support for what exactly, adding the classes/additional HTML that the JS adds? Some of that is determined dynamically from user events or resolution/view port size.
Doesn't seem practical if that's the case. Plus Foundation is server-side language agnostic. This seems like it would be better as a standalone PHP library/package that should be agnostic of PHP frameworks as well.

Hi @Knight-Yoshi , thanks for commenting.
As suggested, the package I have in mind would be supplemental as opposed to interchangeable.
One idea that I am keen on is dynamically generated grids / galleries.
For example:
 $menu = new Menu();

  $menu->align("expanded")
    ->orient("vertical");

  $menu->setLinks([
    "home" => "/home",
      "cartography" => "/ca",
      "logos" => "/ld",
      "concepts" => [
        "british" => "#",
          "american" => [
            "NY" => "#"
          ]
      ],
      "projects" => "/dp",
      "original" => "/oi",
      "univision" => "/uv",
      "united-nations" => "/united-nations",
      "about" => "/am",
      "dropdown1" => [
        "one" => "#",
          "two" => "#",
          "three" => "#"
      ],
      "dropdown2" => [
        "A" => "#",
          "B" => "#",
          "C" => [
            "X" => "#",
              "Y" => "#"
          ]
      ]
  ]);
  echo $menu->getHTML();

Now, I'm just trying to gauge interest. It may make more sense to do this work independently. In fact, as you suggest, anything server-side related wouldn't jive with Foundation's front-end focus.
Hmmmm.

This is really more project-specific cases. These should be done in your project as either a widget or in a view. For instance, the framework I'm using has a Nav widget, but it uses Bootstrap. So, I made a PHP Menu widget for my project that's used to generate dynamic, Foundation-compatible menus.
However, it's not something that belongs in the Foundation project itself since it's dependent on the framework I use and my table structure.

I made a PHP Menu widget for my project that's used to generate dynamic, Foundation-compatible menus

Have you made that code available?

However, it's not something that belongs in the Foundation project....

Yeah, I agree. Thanks.

I have not. It's specific to the Yii2 framework and my table structure; i.e. requires an Active Record object - so it can't do static arrays. It's not something that's really able to be shared because of how tightly coupled it is with the framework and tables. :|


Integration with Nuget package manager

Build integration for the Nuget package manager
This would be for .net apps

looking at this a little more and it may require a c# swig module be developed


Tech Article says first draft of standard is available at thedigitalstandard.org

The following tech article at this link: http://indianexpress.com/article/technology/tech-news-technology/consumer-reports-to-consider-data-security-as-part-of-product-reviews-4560275/?utm_source=March+13%2C+2017+Newsletter+%232A&utm_campaign=March+13%2C+2017+Newsletter+%232A&utm_medium=email
states that the first draft of the standard is available at thedigitalstandard.org.  But, I cannot find a draft of the standard to review and comment on.  Where is the first draft of the standard?  I'd be interested in reviewing it and commenting on it.

Most likely they're referring to: https://www.thedigitalstandard.org/the-standard

Went to https;//www.thedigitalstandard.org/the-standard, prior to writing me previous comment.  There is no standard there.  Just an explanation of what I'd refer to as "the mission."  Is there a first draft of the standard available, or is it still early days?

Hi Jeff,
Not sure what you're seeing at that link. Should be a long spreadsheet.
The Standard consists of a number of criteria, presenting consumer
expectation of behaviour. Those are followed by the indicators and test
procedures, which are and we expect to be under development for a while.
Our goal is to have a set of indicators and procedures developed for a
large number of product and service verticals. Ie, the processes to apply
the Standard to arrive at a test result. That's what we -- and a number of
partners -- are up to now.
Thanks,
G.
On Mar 14, 2017 9:49 AM, "JeffSchutt"<EMAIL_ADDRESS>wrote:

Went to https;//www.thedigitalstandard.org/the-standard, prior to writing
me previous comment. There is no standard there. Just an explanation of
what I'd refer to as "the mission." Is there a first draft of the standard
available, or is it still early days?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/TheDigitalStandard/TheDigitalStandard/issues/12#issuecomment-286426280,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEdrvc87gmG8YkToE-viqLFh8uRXNfv0ks5rlprwgaJpZM4MclKC
.

Hello G:
Thanks.  Hmmh.  Not seeing the spreadsheet from Taiwan and via my work computer.  Will try again with VPN.  If I can get to the information, I’ll ask some people at my company, who are interested in this.  I’m hopeful that we’ll have some interesting comments to share with you.
Sincerely,
Jeff Schutt
Vice-President
Global Engineering
Intertek
Taiwan Mobile: +886 (0) 903288535
From: taliesan<EMAIL_ADDRESS>Sent: Tuesday, March 14, 2017 10:25 PM
To: TheDigitalStandard/TheDigitalStandard
Cc: Jeff Schutt Intertek; Author
Subject: Re: [TheDigitalStandard/TheDigitalStandard] Tech Article says first draft of standard is available at thedigitalstandard.org (#12)
Hi Jeff,
Not sure what you're seeing at that link. Should be a long spreadsheet.
The Standard consists of a number of criteria, presenting consumer
expectation of behaviour. Those are followed by the indicators and test
procedures, which are and we expect to be under development for a while.
Our goal is to have a set of indicators and procedures developed for a
large number of product and service verticals. Ie, the processes to apply
the Standard to arrive at a test result. That's what we -- and a number of
partners -- are up to now.
Thanks,
G.
On Mar 14, 2017 9:49 AM, "JeffSchutt" <notifications<EMAIL_ADDRESS>wrote:

Went to https;//www.thedigitalstandard.org/the-standard, prior to writing
me previous comment. There is no standard there. Just an explanation of
what I'd refer to as "the mission." Is there a first draft of the standard
available, or is it still early days?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/TheDigitalStandard/TheDigitalStandard/issues/12#issuecomment-286426280,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEdrvc87gmG8YkToE-viqLFh8uRXNfv0ks5rlprwgaJpZM4MclKC
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/TheDigitalStandard/TheDigitalStandard/issues/12#issuecomment-286436927, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZL9BGFCeyVmwdLS7xGCkB6gOJNpv5Nqks5rlqM1gaJpZM4MclKC.
Total Quality. Assured.

CONFIDENTIALITY NOTICE
This email may contain confidential or privileged information, if you are not the intended recipient, or the person responsible for delivering the message to the intended recipient then please notify us by return email immediately. Should you have received this email in error then you should not copy this for any purpose nor disclose its contents to any other person.
Except where explicitly agreed otherwise in writing, all work and services performed by Intertek is subject to our Standard Terms and Conditions of Services which can be obtained at our website: http://www.intertek.com.cn/disclaimer.html. Acting as supplier of Intertek means you agree to be bound by our Code of Ethics at http://www.intertek.com/investors/governance/. If that is not your intention please kindly advise Intertek in advance.


10 of the most annoying UI/UX mistakes to avoid while crafting your products

Proposed title of article
10 of the most annoying UI/UX mistakes to avoid while crafting your products
Introduction paragraph (2-3 paragraphs):
The user interface(UI) plays a major role in how a user interacts with your products. From mobile apps, to web apps, to desktop applications, there are tiny details that make it hard or easy for a user to be served by your product. No matter how good your product logic is, the user only interacts with the UI. Good UI/UX practices allow users to spend more time using your product, it increases the chances of the user recommending the product to their colleagues, while bad practices do the exact opposite.
There are some details which when put into consideration, can improve your products' effectiveness. When neglected, they can be the only thing that made your awesome startup fail.
In this article, we look at 10 of the most annoying UI/UX mistakes to avoid while crafting your products.
Key takeaways:
We will touch on:

Images and image quality
Text and the reading area
Actions and notification
Proper layouts
Color palletes
Buttons
Clickability and clickable areas
Inconsistency in design
Fonts
Data validation

References:
N/A

@wanjirualice6194
Good afternoon and thank you for submitting your topic suggestion.
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

@wanjirualice6194
Sounds like a helpful topic - lets please be sure it add value beyond what is in the official docs and what is covered in other blog sites.
Please be sure to double check that it does not overlap with any existing EngEd articles or incoming topic suggestions (if you haven't already) to avoid any potential article closure, please reference any relevant EngEd articles in yours. - Approved

Closed #3088 via #3408


fix: freeze built-in modes to prevent grammars altering them

Technically this would be a breaking change for any BADLY behaved 3rd grammars that were taking advantage of this loophole before... That doesn't really both me a lot (since I'm assuming it's a small number or zere).  I'm also not convinced we need a MAJOR release for this.
If you don't think we can accept this kind of breakage in a minor release then I suppose my preference would be to isolate the compile steps so that we just refuse to compile poor grammars and keep working with the good grammars.
This was on my list of things to do eventually, but wasn't planning on getting to it until later.

Technically this would be a breaking change for any BADLY behaved 3rd grammars that were taking advantage of this loophole before... That doesn't really both me a lot (since I'm assuming it's a small number or maybe zero). I'm also not convinced we need a MAJOR release for this.

Well, let's keep the breaking changes (potential or not) for major releases.

If you don't think we can accept this kind of potential breakage in a minor release then I suppose my preference would be to isolate the compile steps so that we just refuse to compile poor grammars and keep working with the good grammars. (although that's also a -slightly- breaking change, depending on your definition of breaking)

Are we in a hurry? Why not just wait for some time with this PR until the next major release?

Are we in a hurry? Why not just wait for some time with this PR until the next major release?

Well, I tend to have had poor experiences with long-lived PRs in general.  There are git strategies to make dealing with such things easier, but still I've always found it's best to get things finished up and committed, when possible.
Also, technically right now any language grammar loaded can break ALL the other grammars by subverting their rules (either on purpose or on accident).  Seems kind of bad.
How do you feel about my suggestion if I just go ahead and add a catch so that any 3rd party languages behaving poorly get "disabled" (with a console error) but all other languages continue working just fine?  Would that be a let us get this merged now vs later?

How do you feel about my suggestion if I just go ahead and add a catch so that any 3rd party languages behaving poorly get "disabled" (with a console error) but all other languages continue working just fine?

I think it returns us back to #2276, because you don't want an error to get swallowed when developing new grammar.
As I can see in #2273, there are quite a few breaking changes for v10. Maybe these changes worth a separate branch?

I think it returns us back to #2276, because you don't want an error to get swallowed when developing new grammar.

Yes, I'm fine with making that a requirement here.  But if we make that a thing, do you think this is safe to go in and the default "production" mode would then be that broken languages (which there might not even be any!) are just disabled, while other grammars continue to work just time.

As I can see in #2273, there are quite a few breaking changes for v10. Maybe these changes worth a separate branch?

After 9.17 I'll probably make a 9_STABLE branch or similar and then master will become the 10 branch.

Yes, I'm fine with making that a requirement here. But if we make that a thing, do you think this is safe to go in and the default "production" mode would then be that broken languages (which there might not even be any!) are just disabled, while other grammars continue to work just time.

I think it's OK in this case.

@egor-rogov Merging this now that #2286 has hit.

@egor-rogov Merging this now that #2286 has hit.

Yep.


README examples on usage references wrong binary name

The examples for usage references incorrect binary name. grpc_health_probe should be changed to grpc-health-probe in README to keep naming consistent with module and repository.
Repro steps:
go get github.com/grpc-ecosystem/grpc-health-probe

grpc_health_probe -addr=localhost:50051

command not found: grpc_health_probe

This works:
grpc_health_probe -addr=localhost:50051

That's not the recommended installation method.


BUG -- myLocationoverlay.enableMyLocation();

myLocationoverlay.enableMyLocation();
is not working, as this is not showing the person icon to my current location.
compile 'org.osmdroid:osmdroid-android:5.6.5'

is GPS on? application and user level permissions?


Create PULL_REQUEST_TEMPLATE.md

copied bps pr template over

@IshDeshpa @Cam0Cow pls merge 🙏🙏🧎🏾♂

There's definitely some edits we need to make first.

See https://github.com/lhr-solar/Embedded-Sharepoint/issues/23. Move this to the sharepoint and add an issue template.

See https://github.com/lhr-solar/Embedded-Sharepoint/issues/23. Move this to the sharepoint and add an issue template.

Can we even have them in the sharepoint and still have GH pick it up as a template, I thought it had to be in the root dir


How to add Application Name / Route Info

Greetings ,
Thankyou for the nice work you did to drain logs to slack from cloud foundry , it worked for me with some minor changes to pattern match. However I would like to know how to add application host name / Route info from  cloud foundry application to the logs. When I configure your app like it was defined , i get the message from your  app in the following format .
<14>1 2016-01-12T22:44:27.961158+00:00 loggregator 39026d61-9a58-4446-924e-a40a88d71c38 [App/0] - - [WARNING ] SRVE8093W: The servlet class name is null for the servlet named [javax.ws.rs.core.Application] so the request cannot be handled
I would like to get the app name so that is help the team to understand from which app this error was created.
Thankyou
Kumar.

I don't work on this project anymore (nor anything in Cloud Foundry, or IBM), so ... can't really provide much help.
Looking at the code/README again, perhaps you could try changing the URL of the log drain to not just include the channel, but also the app in question.  You'd need to create a new user-provided service for each app.  You can then get the app name and channel from a slightly more elaborate bit of parsing the request path.


Where should i put the .siddhiext file in a maven project when writing an custom extension function?

That will be automatically generated when you are building the extension.
Try building https://github.com/wso2-extensions/siddhi-execution-math and see.


Update to amethyst 0.12

bors r+

We have bors now? neat
bors r+

I'm too dumb to know what that means.

Have you tried checking here?

/shrug
Doesn't seem to have the logs as to what timed out :/


Remove M1/M2 part from FAQ

macOS M1/M2 is Tier 1: https://julialang.org/downloads/#supported_platforms so this PR removes the part from the FAQ about it being Tier 2.
(I also haven't encountered any issues with M1/M2 specifically, so I think it's on par in terms of reliability as the other platforms)

Great thanks! Also it's good to know it works ok on these chips now - indeed I haven't had any bug reports specific to that for a long time.


ci(test): add unit test output report

PR Checklist

[ ] Unit Tests have been added for new changes
[ ] API tests have been updated if applicable
[ ] All commented code has been removed
[ ] If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

Codecov Report

Merging #489 (4d8dc72) into main (3bac229) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #489   +/-   ##
=======================================
  Coverage   49.43%   49.43%
=======================================
  Files          52       52
  Lines        3688     3688
  Branches      681      681
=======================================
  Hits         1823     1823
  Misses       1695     1695
  Partials      170      170

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bac229...4d8dc72. Read the comment docs.


Allow storage plugins to get storage/volume stats without sending commands to hosts

Description
This PR allows the rest of the storage plugins to implement and use the storage/volume statistics directly instead of sending cmd to hosts, not only ScaleIO. With this change, we check if the plugin could provide storage/volume statistics.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ X] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

[ ] Major
[ X] Minor

How Has This Been Tested?
OS - CentOS7
hypervisor - KVM
branch - master
primary storage - NFS, StorPool
manually tested

ping @slavkap can you please fix the conflicts. thanks.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 802

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-1579)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37857 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t1579-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

We need test matrix on this
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 1234

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1262

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1285

@blueorangutan test matrix

@sureshanaparti a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-2086)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36665 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t2086-xenserver-71.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-2087)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40377 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t2087-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-2088)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42490 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t2088-vmware-65u2.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_03_live_migrate_VM_with_two_data_disks
Error
61.75
test_vm_life_cycle.py

@blueorangutan test centos7 vmware-67u3

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

Trillian test result (tid-2105)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40667 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t2105-vmware-67u3.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_03_live_migrate_VM_with_two_data_disks
Error
59.68
test_vm_life_cycle.py

@slavkap can you check the test failure, it is consistent with VMware hypervisor.

Hi @sureshanaparti, @rhtyd, sorry for not answering, but I needed a break and took a few days off. Unfortunately, I cannot find the problem with the test. The stack trace shows a null pointer exception at line 6508:

2021-09-17 12:32:31,667 ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-105:ctx-2c8348f6 job-2321) (logid:5537f2da) Unexpected exception while executing org.apache.cloudstack.api.command.admin.vm.MigrateVirtualMachineWithVolumeCmd
java.lang.NullPointerException
at com.cloud.vm.UserVmManagerImpl.getVolumePoolMappingForMigrateVmWithStorage(UserVmManagerImpl.java:6508)
at com.cloud.vm.UserVmManagerImpl.migrateVirtualMachineWithVolume(UserVmManagerImpl.java:6576)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

but this leads to commented part in the code of method moveVMToUser not getVolumePoolMappingForMigrateVmWithStorage :
  6462	    public UserVm moveVMToUser(final AssignVMCmd cmd) throws ResourceAllocationException, ConcurrentOperationException, ResourceUnavailableException, InsufficientCapacityException {
  6463	        // VERIFICATIONS and VALIDATIONS
  6464
  6465	        // VV 1: verify the two users
  6466	        Account caller = CallContext.current().getCallingAccount();
  6467	        if (!_accountMgr.isRootAdmin(caller.getId())
  6468	                && !_accountMgr.isDomainAdmin(caller.getId())) { // only
  6469	            // root
  6470	            // admin
  6471	            // can
  6472	            // assign
  6473	            // VMs
  6474	            throw new InvalidParameterValueException("Only domain admins are allowed to assign VMs and not " + caller.getType());
  6475	        }
  6476
  6477	        // get and check the valid VM
  6478	        final UserVmVO vm = _vmDao.findById(cmd.getVmId());
  6479	        if (vm == null) {
  6480	            throw new InvalidParameterValueException("There is no vm by that id " + cmd.getVmId());
  6481	        } else if (vm.getState() == State.Running) { // VV 3: check if vm is
  6482	            // running
  6483	            if (s_logger.isDebugEnabled()) {
  6484	                s_logger.debug("VM is Running, unable to move the vm " + vm);
  6485	            }
  6486	            InvalidParameterValueException ex = new InvalidParameterValueException("VM is Running, unable to move the vm with specified vmId");
  6487	            ex.addProxyObject(vm.getUuid(), "vmId");
  6488	            throw ex;
  6489	        }
  6490
  6491	        final Account oldAccount = _accountService.getActiveAccountById(vm.getAccountId());
  6492	        if (oldAccount == null) {
  6493	            throw new InvalidParameterValueException("Invalid account for VM " + vm.getAccountId() + " in domain.");
  6494	        }
  6495	        final Account newAccount = _accountMgr.finalizeOwner(caller, cmd.getAccountName(), cmd.getDomainId(), cmd.getProjectId());
  6496	        if (newAccount == null) {
  6497	            throw new InvalidParameterValueException("Invalid accountid=" + cmd.getAccountName() + " in domain " + cmd.getDomainId());
  6498	        }
  6499
  6500	        if (newAccount.getState() == Account.State.disabled) {
  6501	            throw new InvalidParameterValueException("The new account owner " + cmd.getAccountName() + " is disabled.");
  6502	        }
  6503
  6504	        if (cmd.getProjectId() != null && cmd.getDomainId() == null) {
  6505	            throw new InvalidParameterValueException("Please provide a valid domain ID; cannot assign VM to a project if domain ID is NULL.");
  6506	        }
  6507
  6508	        //check caller has access to both the old and new account
  6509	        _accountMgr.checkAccess(caller, null, true, oldAccount);

re-triggering tests to check the error.
@blueorangutan test centos7 vmware-67u3

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

Trillian test result (tid-2180)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41509 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t2180-vmware-67u3.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_03_live_migrate_VM_with_two_data_disks
Error
61.44
test_vm_life_cycle.py

ping @slavkap test failure is consistent, please check.

Ping @slavkap (I'll kick another test matrix round, but still pl have a look)
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 1406

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1412

Trillian test result (tid-2227)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31594 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4826-t2227-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File


chore(*): Upgrade to Jasmine 2.4

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore
What is the current behavior? (You can also link to an open issue here)
All tests run with Jasmine 1.3
What is the new behavior (if this is a feature change)?
All tests run with Jasmine 2.4
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

[X] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)

Other information:
Highlights:
in Jasmine, this is no longer jasmine.Spec. Removed the tests that check this.
New mechanism to run async tests as Jasmine 2 removed runs, waits and waitsFor
The functions iit, ddescribe and tthey were renamed fit, fdescribe and fthey
as the originals came from Karma, Karma no longer bundles Jasmine and the new function
name comes from Jasmine
7e916455b36dc9ca4d4afc1e44cade90006d00e3 was partially reverted. Kept the test, remove the code changes

This PR is big and given that it changes many files, can get easily rotten, so it would be ideal if this can be reviewed fast.

There is a pending task to upgrade grunt-ddescribe-iit to support for fit, fdescribe and fthey

I do not have access to IE9, can someone check why there is an error when running tests:modules ?

@lgalfaso The complete log shows an error for FIrefox in tests:modules:
Firefox 43.0.0 (Linux 0.0.0) ERROR
  Error: [ng:btstrpd] App Already Bootstrapped with this Element '<div ng-app="">'
  http://errors.angularjs.org/1.5.1-build.20899+sha.0082806/ng/btstrpd?p0=%26lt%3Bdiv%20ng-app%3D%22%22%26gt%3B
  at /home/travis/build/angular/angular.js/build/angular.js:68
.................
Firefox 43.0.0 (Linux 0.0.0): Executed 17 of 713 ERROR (0.126 secs / 0.027 secs)

IE 9 is fine:
IE 9.0.0 (Windows 7 0.0.0): Executed 713 of 713 SUCCESS (2.888 secs / 2.348 secs)

Why was https://github.com/lgalfaso/angular.js/commit/7e916455b36dc9ca4d4afc1e44cade90006d00e3 reverted? Because we don't support these browsers?

Why was lgalfaso@7e91645 reverted? Because we don't support these browsers?

Jasmine 2.4 toEqual checks that actual and expected are of the same type. 7e91645 changes the type of what is thrown.

Ok, thanks. Can you add that explanation to the commit message?

@lgalfaso can you confirm that after the change to the angular mock module tests still work on PhantomJS and Safari 7?  This is the only part that affects people outside of this project so it would be good to make sure we are not breaking anything.

Reverted the changes on angular.mocks.js, made the changes on loaderSpec.js, fixed the issue with Firefox and now the test are back to green.
PTAL

Since we now move to jasmine 2.4, I think we should also change the docs to recommend jasmine 2.4 instead of 1.3, espepcially here: https://github.com/angular/angular.js/blob/a4e60cb6970d8b6fa9e0af4b9f881ee3ba7fdc99/docs/content/guide/unit-testing.ngdoc and https://github.com/angular/angular.js/blob/a4e60cb6970d8b6fa9e0af4b9f881ee3ba7fdc99/docs/content/guide/e2e-testing.ngdoc The unit tests in the guide don't actually run, so they have to be checked for correctness with jasmine 2.4. @lgalfaso do you want to make these changes? I can also do it if you want.

Updated the docs, did not run the tests in the guide, but in theory it
should be possible for users to use the version from Jasmine that they like
the most.
On Tue, Mar 15, 2016 at 1:43 PM, Martin Staffa<EMAIL_ADDRESS>wrote:

Since we now move to jasmine 2.4, I think we should also change the docs
to recommend jasmine 2.4 instead of 1.3, espepcially here:
https://github.com/angular/angular.js/blob/a4e60cb6970d8b6fa9e0af4b9f881ee3ba7fdc99/docs/content/guide/unit-testing.ngdoc
and
https://github.com/angular/angular.js/blob/a4e60cb6970d8b6fa9e0af4b9f881ee3ba7fdc99/docs/content/guide/e2e-testing.ngdoc
The unit tests in the guide don't actually run, so they have to be checked
for correctness with jasmine 2.4. @lgalfaso https://github.com/lgalfaso
do you want to make these changes? I can also do it if you want.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/angular/angular.js/pull/14226#issuecomment-196802458


add license headers

some files missing license headers

I think it would be  better  to rewrite some demo from scratch.


Dehumidifier is no longer being provided b the frigidaire integration

Good Afternoon,
I just added this integration  - which worked perfectly to identify what Frigidaire devices are on my network. Unfortunately once I added the integration and my dehumidifier popped up - I received this warning
"This entity is no longer being provided by the frigidaire integration. If the entity is no longer in use, delete it in settings."
I left it for about an hour to see if it just took some time to receive info/controls from the dehumidifier, but the dehumidifier entity remains as unavailable.
I will mention - I noticed I needed to install a new frigidaire app recently - wondering if this integration only uses the previous version of the app?

Can you confirm that you are on the latest version of the integration?

Yes - I downloaded from the files

Sorry - did not mean to close - fat fingered

Same experience here.  Had issues a month ago and needed the new version of this plug-in/add-on, which worked.
I then installed the new app on my iPhone and added the dehumidifier, and noticed this plugin no longer saw my dehumidifier.  I then reinstalled the old iPhone app, removed the dehumidifier from both new and old, and added it only to new.  Now then I check either the old iPhone app or the Home Assistant plugin, it says no devices found after logging in.
Maybe after the first change that broke this program, Frigidaire moved something else and store their "new" devices differently?

Unfortunately I only have air conditioners and not dehumidifiers so I'm unable to test or reproduce this
Frigidaire has changed a lot of things on their end without any rhyme or reason, so a change on their side is the likely culprit

Mine is still working

Hi - can someone please point me to instructions on how to install this integration within HA?  I actually want to use it with my dehumidifer 😄


Make the agent systemd services compatible with systemd<=229

What does this PR do?
StartLimitInterval was renamed StartLimitIntervalSec and move from
[Service] to [Unit] in systemd 230.  Since Ubuntu 16.04 ship systemd
229 we have to use the old variable name. StartLimitInterval is still
supported by systemd>=230 but no longer documented.
Motivation
StartLimitIntervalSec will be ignored and generate warning in systemd logs with version <=229.

Codecov Report

Merging #2821 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2821      +/-   ##
==========================================
- Coverage   57.24%   57.18%   -0.07%
==========================================
  Files         387      386       -1
  Lines       24803    24786      -17
==========================================
- Hits        14199    14174      -25
- Misses       9664     9673       +9
+ Partials      940      939       -1

Impacted Files
Coverage Δ

pkg/logs/input/docker/tailer.go
11.59% <0%> (-8.55%)
:arrow_down:

pkg/metadata/host/host_tags.go
76.66% <0%> (-3.34%)
:arrow_down:

pkg/collector/runner/runner.go
67.01% <0%> (-1.41%)
:arrow_down:

pkg/logs/input/docker/since.go
100% <0%> (ø)
:arrow_up:

pkg/logs/input/docker/reader.go

pkg/logs/client/connection_manager.go
48.27% <0%> (+3.44%)
:arrow_up:

pkg/logs/input/listener/tailer.go
90% <0%> (+4%)
:arrow_up:

Codecov Report

Merging #2821 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2821      +/-   ##
==========================================
- Coverage   57.24%   57.18%   -0.07%
==========================================
  Files         387      386       -1
  Lines       24803    24786      -17
==========================================
- Hits        14199    14174      -25
- Misses       9664     9673       +9
+ Partials      940      939       -1

Impacted Files
Coverage Δ

pkg/logs/input/docker/tailer.go
11.59% <0%> (-8.55%)
:arrow_down:

pkg/metadata/host/host_tags.go
76.66% <0%> (-3.34%)
:arrow_down:

pkg/collector/runner/runner.go
67.01% <0%> (-1.41%)
:arrow_down:

pkg/logs/input/docker/since.go
100% <0%> (ø)
:arrow_up:

pkg/logs/input/docker/reader.go

pkg/logs/client/connection_manager.go
48.27% <0%> (+3.44%)
:arrow_up:

pkg/logs/input/listener/tailer.go
90% <0%> (+4%)
:arrow_up:

Shouldn't it be the same for StartLimitBurst ? (systemd 229 manpage http://manpages.ubuntu.com/manpages/xenial/man5/systemd.unit.5.html )
Maybe no warning were generated for this field?


Custom FormData instance

How can I feed my own FormData instance?
If it's not yet possible, I think that formData : new FormData() should work (it doesn't for now). Passing the FormData instance as parameter of the .form([form]) api call send it urlencoded.

What do you mean by custom FormData instance? Is the multipart/form-data documentation of any help?

Not really; I'd like to create myself the FormData instance. For example:
var formData = new FormData( );
formData.append( 'foo', new Buffer( [ ] ), { filename : 'foo.bin' } );

request( { formData : formData, ... } );

What's the difference between your example and this one:
var formData = {
  foo: {
    value: new Buffer( [ ] ),
    options: { filename : 'foo.bin' }
  }
}

request( { formData : formData } );

I haven't seen that it was possible to specify the filename using an option object - it solves my use case.
However, from a API point of view, I still think it would be better to be able to pass a custom FormData instance, if possible : it doesn't really make sense that the formData instance doesn't actually support FormData.
Anyway, this issue can be closed as far as I'm concerned. Thanks!

From an API point of view we wanted to be able to pass FormData options directly to request, without knowing the internal details of the implementation.
The FormData module is just an implementation detail that eventually may change in future, where the input options format is what the request's formData implementation expects.
I'm glad it works for you @arcanis . I'm closing this.


Feature request: migrate:reset

I frequently change my migrations in my application since it has no production data to maintain yet.  I'd like to be able to quickly reset it(rollback all and then migrate latest) instead of running rollback until all of the migrations have rolled back to the base migration, then running migrate latest.

Hey there,
I'm working on the rewrite of migrations (https://github.com/knex/arctic)
I'm willing to consider this but I'm not sure about it quite yet. Are you primarily using this locally? If so wouldn't a script to drop the DB, create it, and then migrate to the latest be a better solution?

It would certainly work.  I'll throw one together.  I was just thinking that it's probably a common enough use case to get put in the lib, but I defer to your judgement.  Maybe a migrate:rollback --all would help as well.  This library has been absolutely outstanding.  Thanks for all the hard work!

Totally with you on an --all flag for migrations. The current API basically just supports latest and rollback but I'm looking to offer much finer control. Will keep you posted.

@bendrucker What's the status of arctic?

@bendrucker Is Arctic going to happen soon?

wouldn't a script to drop the DB, create it, and then migrate to the latest be a better solution?

I ran into multiple issues doing this locally with Postgres such as the difficulty of running commands via the CLI, system permissions, db permissions, etc. I did manage to get it to work, but then realized I wanted to run the script both from the CLI and before tests, including re-running migrations and eventually seeds, so I examined the source of Migrate and camp up with this simple routine:
var migrate = knex.migrate;

// Force unlock in case of bad state
migrate.forceFreeMigrationsLock()

// Get completed migrations
.then(function(){
  return migrate._listCompleted();
})

// Rollback migrations
.then(function(completedMigrations){
  return migrate._waterfallBatch(0, completedMigrations, 'down');
})

// Migrate to latest
.then(function(){
  return migrate.latest();
});

It should be fairly simple to turn that into a reset() method in Migrate.

That's an improvement over what I do to clean before my tests, which is just
	knex.migrate.rollback(dbConf).then ->
		console.log('rolled back database')
		knex.migrate.latest(dbConf).then ->
			console.log('migrated database')
			done()

@bendrucker would justincy's code be accepted in a pull request?

I updated the code example to add completedMigrations.reverse() when bringing down migrations because they're returned in order of creation.

I wrote knex-migrate that has this feature (named knex-migrate redo).

I used this code to solve this problem:
      .then(() => migrate.currentVersion(knexConfig.migrations))
      .then((migration) => (migration !== 'none' ? migrate.rollback(knexConfig.migrations).then(rollbackAllMigrations) : Promise.resolve()));
    return Promise.try(rollbackAllMigrations);```

It doesn't use internal methods and allows you to pass in config.

It looks like this got added and the issue can be closed: #3187
Pinging @kibertoad, since you merged that PR and probably have the permissions to do this

@mmarvick Thanks for the heads-up!


SourceFolder accepted values doesn't include DiscoveryHoldsItems

While the page specifically says that DiscoveryHoldsItems is a valid value in the text explaining what the values will return, the accepted values section only includes "DeletedItems | RecoverableItems | PurgedItems".

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 21b1cd9d-df2e-d4d6-52e2-d3fbdfb9db9f
Version Independent ID: e675173d-290a-dee0-62a4-5485cf3d2570
Content: Restore-RecoverableItems (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Restore-RecoverableItems.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@WillMartin58, I confirmed that DeletedItems, RecoverableItems, and PurgedItems are valid values in on-premises Exchange Server and the cloud, while DiscoveryHoldsItems is valid only in the cloud.
That Accepted values: YAML property for a parameter is interesting, but shouldn't be the definitive word on acceptable values (that's what the description is for). Out of 14,000+ parameters in Exchange-related cmdlets, only 48 have a value for that property. Some of that has to do with the age of the cmdlet/parameter and when it was documented (old = we didn't used to pick up that value, even if it was available).
Anyway, I cleaned up the SourceFolder description in Get-RecoverableItems and Restore-RecoverableITems, and I removed the Accepted values: property from the YAML block.
Thanks for the feedback.
Closing


Remove Helm v2 from Ingress Nginx tutorial

I think the later versions of cert-manager don't support Helm v2 so we may want to clean up the Ingress Nginx tutorial https://cert-manager.io/docs/tutorials/acme/ingress/

I suspect a pull request on https://github.com/cert-manager/website/blob/master/content/en/docs/tutorials/acme/nginx-ingress.md would make this issue progress better.


Make timezone in "strict_date_time" format optional

Description
Changes "strict_date_time" format to make the timezone optional. For example, 2024-06-01T13:38:18.280 was not previously allowed, only 2024-06-01T13:38:18.280Z or 2024-06-01T13:38:18.280Z+00:00. If there's no timezone, it defaults to UTC. This is useful as Python's isoformat() can output times like this, and they are ISO 8601 compliant.
Adds UT. Also tested manually with the mapping:
"timestamp":    {
    "type" : "date",
    "format":"strict_date_time"
}

and indexing two documents, one with timestamp "2023-01-01T14:14:14Z" and one with "2023-01-01T14:14:14". In the existing code, the second one failed with RequestError(400, 'mapper_parsing_exception', "failed to parse field [timestamp] of type [date] in document with id '2'. Preview of field's value: '2023-02-02T14:14:14'").
After this change, both are accepted.
Related Issues
Resolves https://github.com/opensearch-project/OpenSearch/issues/16673
Check List

[x] Functionality includes testing.
[x] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I wanted to follow up on @peteralfonsi comment (and thanks @peteralfonsi for the PR!).   I know that strict_date_time is not the same as ISO8601, but instead is more defined by what OpenSearch project defines it.  It's interesting to see that various date format standards all have, well, many flavours ;-).
I'm collecting different flavours of ISO8601 in this thread: https://bsky.app/profile/dep4b.bsky.social/post/3lbadp742pk26 ;-)


Standardize formatting of manifests/y/Yubico/YubikeyManager/1.2.0

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


remove outdated copy of Python batch sample

Purpose
This is a copy of the original version of the sample for the v2 batch API. It is superseded by the sample for the v3 API; the sample should only be in one place.
Pull Request Type
What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Content is referred to from the docs pages.


Move drawables to "drawable-nodpi" instead of "drawable" to get correct bitmap sizes

Hi,
in demo your bitmaps in memory are astronomically huge as they are in "drawable" folder, which is "drawable-mdpi" and if you run it on modern xxxhdpi phone, you will get multiplier * 4 (i think) of each dimension, there fore each bitmap is 16times bigger in memory (124mb+ bitmaps)

I will think about it, thanks!

经过测试，在 480dpi 的手机（屏幕尺寸 1080x1920，华为，api 24）上，解析出来的 bitmap 的大小是 3240x5760，将 1080p 的图片放入 drawable-xxhdpi 目录下则为正常大小 1080x1920。可以考虑将图片放入不同的 drawable 目录。


@depfu[bot] rebase doesn't work

Github autocomplete suggests to use @depfu[bot]:

But it seems like @depfu[bot] rebase don't work, while @depfu rebase does work. It would be nice that @depfu[bot] rebase also work as it is confusing with the autocomplete. :wink:

Thanks for the feedback @Ana06!
I've added support for that now, so it should work! Github behaves a bit strange, I haven't quite figured out when it actually puts @depfu[bot] into the autocomplete, it's not always there.

Thanks @theflow! :cupid: It seems to work :wink:


EINVAL: invalid argument, open '/code/node_modules/node-sass/package.json'

Failure upon running the npm install command within a freshly cloned project.

NPM version (npm -v): 6.4.1
Node version (node -v): v8.12.0
Node Process (node -p process.versions):

{ http_parser: '2.8.0',
  node: '8.12.0',
  v8: '6.2.414.66',
  uv: '1.19.2',
  zlib: '1.2.11',
  ares: '1.10.1-DEV',
  modules: '57',
  nghttp2: '1.32.0',
  napi: '3',
  openssl: '1.0.2p',
  icu: '60.1',
  unicode: '10.0',
  cldr: '32.0',
  tz: '2017c' }

Node Platform (node -p process.platform): linux
Node architecture (node -p process.arch): x64
node-sass version (node -p "require('node-sass').info"): Not applicable (never successfully installed.)
npm node-sass versions (npm ls node-sass after trying to run npm install):

root:/code# npm ls node-sass
<EMAIL_ADDRESS>/code
`--<EMAIL_ADDRESS>  `-- UNMET DEPENDENCY<EMAIL_ADDRESS>
npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>

My experience is as follows (I can post additional info of my project, if required.)
Side-notes:

node-sass fails to install within my ubuntu-16.04 based docker image (microsoft/vsts-agent) and this environment is what this issue concerns.
node-sass successfully installs on my windows host machine. My windows environment has same major versions of my docker container's environment (node + npm) and the project's source is the same on windows as what I am trying to developer against in the docker container.

root:/code# npm install
npm WARN (deprecated warnings)

><EMAIL_ADDRESS>install /code/node_modules/uws
> node-gyp rebuild > build_log.txt 2>&1 || exit 0

><EMAIL_ADDRESS>install /code/node_modules/node-sass
> node scripts/install.js

fs.js:646
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^

Error: EINVAL: invalid argument, open '/code/node_modules/node-sass/package.json'
    at Object.fs.openSync (fs.js:646:18)
    at Object.fs.readFileSync (fs.js:551:33)
    at Object.Module._extensions..json (module.js:670:20)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/code/node_modules/node-sass/lib/extensions.js:7:9)
    at Module._compile (module.js:653:30)

npm WARN (rollback warnings here)
npm WARN (peer dependency warnings here)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node scripts/install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-10-23T17_41_19_761Z-debug.log

root:/code#

(Related to #2515 submitted a few days ago.)

2 things pop out, but might not be related.

Your running as root, and root has issues with NPM https://github.com/sass/node-sass/blob/master/TROUBLESHOOTING.md#linux
Not a Docker expert, but there might be something off with your workspace mappings that's preventing the install from writing to the mapped partition.

@METACEO
sudo apt install nodejs-legacy
Then try installing npm

I have the same error in the same environment (@METACEO : I guess you run docker on Windows ?), and indeed it seems to be related to how the directories in the container are mapped on the host.
If I move package.json to another directory within the container that is not mapped on the host (say /tmp/), the npm install just goes fine.
It used to work quite recently so I guess some dependency changed its behavior in the meantime.
It seems there is no such problem with yarn, so I'll temporarily switch away from npm.

@gwenl yea, docker on windows, I haven't yet had the time to answer @nschonni questions, but I was wanting to try exactly what you suggested (relocating out of a mapped directory and installing the project there.) I'll try yarn as well.

I am seeing this with another project of mine (something that does not have node-sass as a dependency.) @gwenl I tried what you suggested and copied my project to another folder within my container and I no longer encounter any errors. This looks to be a windows <-> docker issue regarding mounted volumes. @nschonni - I believe it is safe to close this issue as it looks to be unrelated of node-sass.

In fact, @gwenl, the accepted answer here is what is now working for me: https://stackoverflow.com/questions/29181032/add-a-volume-to-docker-but-exclude-a-sub-folder
It seems for me that the synchronization between my Windows host and Linux container was mixing a lot up.

If you want to have subdirectories ignored by docker-compose but persistent, you can do the following in docker-compose.yml:
volumes:
  node_modules:
services:
  server:
    volumes:
      - .:/app
      - node_modules:/app/node_modules

This will mount your current directory as a shared volume, but mount a persistent docker volume in place of your local node_modules directory. This is similar to the answer by kernix, but this will allow node_modules to persist between docker-compose up runs, which is likely the desired behavior.

I had the extact issue yesterday.
I have a windows 10 environment with docker running.
I created an SPFX project using yeoman and after the scaffolding it gave out the same error.
I run the command yarn and it all went well.

Hello,
I have a Windows 10 with docker and I use the following workaround. Into the docker, in my home I create a directory, for example /node_modules.
Them in my mapped directory within windows and linux(into the docker) I make a symbolic link within the directory I created before an "node_modules". Something like
ln -s
ln -s /home/my_project/node_modules /var/www/html/my_project/node_modules
Them, into my project I call the
npm install
With this solution, the node-sass install with no problem.
I'm not an expert but I think the problem was the mapping within the windows and linux and the way that npm installs with links this package.
Best regards

I have exactly the same issue that I can reproduce as follow:
Context
Windows 10, WSL
$ uname -a
Linux nowox-pc 4.4.0-17134-Microsoft #471-Microsoft Fri Dec 07 20:04:00 PST 2018
x86_64 x86_64 x86_64 GNU/Linux

$ docker --version
Docker version 18.09.1-beta1, build d3184b7

Minimal project
Only one package.json
$ tree
.
+-- package.json

0 directories, 1 file

$ cat package.json
{
  "devDependencies": {
    "node-sass": "^4.9.2",
    "sass-loader": "^7.0.3"
  }
}

Failure on npm install
$ docker run -itv $(pwd -P):/app -w=/app node npm install

><EMAIL_ADDRESS>install /app/node_modules/node-sass
> node scripts/install.js

fs.js:121
    throw err;
    ^

Error: EINVAL: invalid argument, open '/app/node_modules/node-sass/package.json'
    at Object.openSync (fs.js:450:3)
    at Object.readFileSync (fs.js:350:35)
    at Object.Module._extensions..json (internal/modules/cjs/loader.js:738:20)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
    at Function.Module._load (internal/modules/cjs/loader.js:552:3)
    at Module.require (internal/modules/cjs/loader.js:657:17)
    at require (internal/modules/cjs/helpers.js:22:18)
    at Object.<anonymous> (/app/node_modules/node-sass/lib/extensions.js:7:9)
    at Module._compile (internal/modules/cjs/loader.js:721:30)

In fact, @gwenl, the accepted answer here is what is now working for me: https://stackoverflow.com/questions/29181032/add-a-volume-to-docker-but-exclude-a-sub-folder
It seems for me that the synchronization between my Windows host and Linux container was mixing a lot up.

If you want to have subdirectories ignored by docker-compose but persistent, you can do the following in docker-compose.yml:
volumes:
  node_modules:
services:
  server:
    volumes:
      - .:/app
      - node_modules:/app/node_modules

This will mount your current directory as a shared volume, but mount a persistent docker volume in place of your local node_modules directory. This is similar to the answer by kernix, but this will allow node_modules to persist between docker-compose up runs, which is likely the desired behavior.

Hi @METACEO ,
This solution works for me. But when we run "npm run watch" for compiling js / css not work.
Do you have a solution for it? Thanks in advance.

@nahdonivr - I don't know what exactly your watch script is doing, but my team is running ng serve which also watches for changes in ts/scss/html and it has been working fine. Curious, what errors are you getting?

@METACEO watch script ("npm run watch") runs command repeatedly and watches the js/css changes and output. I am using Laravel 5.6 and React 16. The solution you have given solves the error "Error: EINVAL: invalid argument, open '/code/node_modules/node-sass/package.json".
I am using docker on window 10, installed same version of node in my docker container.

I had the same error. Using yarn instead of npm helped.
But after running this command it has also working with npm:
npm install --save-dev  --unsafe-perm node-sass
Found this answer on Stackoverflow

Have issue(s) been filed in the appropriate repositories so that I can track them? Can we reference those issues so others, like me, that stumble here can find the appropriate issues?

Source: @shawmanz32na's comment
@shawmanz32na were you able to find related issues in the respective repositories?
Just got bit by this today, and am hoping to actually track the appropriate issue(s).

@virtuoushub Nope, no news here. I'm still hoping for a response from someone on this project, perhaps @nschonni.

I'm closing this thread as it isn't an issue with node-sass, and there have been solutions above to general SO answers on this


[Bugfix] Fix unable to load more multimodal models

This PR fixes more models broken by #10205
I have also added tests for check that each model can be initialized using dummy format.

After overriding the HF config with
{
        "num_layers": 1,
        "num_hidden_layers": 1,
        "num_experts": 2,
        "num_experts_per_tok": 2,
        "num_local_experts": 2,
}

I can even load Snowflake/snowflake-arctic-instruct model (originally with 479B parameters) in a single A10.

The tests pass locally now!


Generate shorter replication group Ids

Redis Replication Group Ids are limited to 16 characters in Elasticache which is really short when including the environment name in the Id (for example 'production-' is 11 characters)
Remove the limit by generating non-human readable Ids and storing the actual name in the description
Also a little bit of cleanup by renaming some functions

How does this affect discovery?

disco_elasticache.py list will print the actual name and the Route53 domain will have the real name too. This only affects how the cache appears in the amazon console where the real name is now in the description field.

How much of a refactoring will it take when we add memcache? The current code looks like its tightly coupled with redis. Are the changes incompatible with memcache?

It will require a lot of changes to implement memcache. Boto and AWS use different calls for Redis and Memcached. The entire "Replication Group" concept doesn't even exist in Memcache

I would have prefered to have the abstraction built in now, so we dont have to go through the code again and figure out what needs to be refactored. In the interest of keeping things moving :+1: . Good job on the workaround for 16 character id restriction.

version bump. :+1:


:sagan-site:generateGitProperties FAILED

I used git clone https://github.com/git/git  , the problem is still there , help please?
D:\Programming\Java\Eclipse workspace\sagan-master\sagan-master>gradle generateGitProperties --info
Starting Build
Settings evaluated using settings file 'D:\Programming\Java\Eclipse workspace\sagan-master\sagan-master\settings.gradle'.
Projects loaded. Root project using build file 'D:\Programming\Java\Eclipse workspace\sagan-master\sagan-master\build.gradle'.
Included projects: [root project 'sagan', project ':sagan-client', project ':sagan-common', project ':sagan-indexer', project ':sagan-site']
Evaluating root project 'sagan' using build file 'D:\Programming\Java\Eclipse workspace\sagan-master\sagan-master\build.gradle'.
Applying dependency management to configuration 'archives' in project 'sagan-site'
Applying dependency management to configuration 'compile' in project 'sagan-site'
Applying dependency management to configuration 'compileClasspath' in project 'sagan-site'
Applying dependency management to configuration 'compileOnly' in project 'sagan-site'
Applying dependency management to configuration 'default' in project 'sagan-site'
Applying dependency management to configuration 'runtime' in project 'sagan-site'
Applying dependency management to configuration 'testCompile' in project 'sagan-site'
Applying dependency management to configuration 'testCompileClasspath' in project 'sagan-site'
Applying dependency management to configuration 'testCompileOnly' in project 'sagan-site'
Applying dependency management to configuration 'testRuntime' in project 'sagan-site'
Applying dependency management to configuration 'archives' in project 'sagan-indexer'
Applying dependency management to configuration 'compile' in project 'sagan-indexer'
Applying dependency management to configuration 'compileClasspath' in project 'sagan-indexer'
Applying dependency management to configuration 'compileOnly' in project 'sagan-indexer'
Applying dependency management to configuration 'default' in project 'sagan-indexer'
Applying dependency management to configuration 'runtime' in project 'sagan-indexer'
Applying dependency management to configuration 'testCompile' in project 'sagan-indexer'
Applying dependency management to configuration 'testCompileClasspath' in project 'sagan-indexer'
Applying dependency management to configuration 'testCompileOnly' in project 'sagan-indexer'
Applying dependency management to configuration 'testRuntime' in project 'sagan-indexer'
Applying dependency management to configuration 'archives' in project 'sagan-common'
Applying dependency management to configuration 'compile' in project 'sagan-common'
Applying dependency management to configuration 'compileClasspath' in project 'sagan-common'
Applying dependency management to configuration 'compileOnly' in project 'sagan-common'
Applying dependency management to configuration 'default' in project 'sagan-common'
Applying dependency management to configuration 'runtime' in project 'sagan-common'
Applying dependency management to configuration 'testCompile' in project 'sagan-common'
Applying dependency management to configuration 'testCompileClasspath' in project 'sagan-common'
Applying dependency management to configuration 'testCompileOnly' in project 'sagan-common'
Applying dependency management to configuration 'testRuntime' in project 'sagan-common'
Applying dependency management to configuration 'integTestCompile' in project 'sagan-site'
Applying dependency management to configuration 'integTestRuntime' in project 'sagan-site'
Applying dependency management to configuration 'integTestCompileOnly' in project 'sagan-site'
Applying dependency management to configuration 'integTestCompileClasspath' in project 'sagan-site'
Applying dependency management to configuration 'integTestCompile' in project 'sagan-indexer'
Applying dependency management to configuration 'integTestRuntime' in project 'sagan-indexer'
Applying dependency management to configuration 'integTestCompileOnly' in project 'sagan-indexer'
Applying dependency management to configuration 'integTestCompileClasspath' in project 'sagan-indexer'
Evaluating project ':sagan-client' using build file 'D:\Programming\Java\Eclipse workspace\sagan-master\sagan-master\sagan-client\build.gradle'.
Evaluating project ':sagan-common' using build file 'D:\Programming\Java\Eclipse workspace\sagan-master\sagan-master\sagan-common\build.gradle'.
Applying dependency management to configuration 'testUtilCompile' in project 'sagan-common'
Applying dependency management to configuration 'testUtilRuntime' in project 'sagan-common'
Applying dependency management to configuration 'testUtilCompileOnly' in project 'sagan-common'
Applying dependency management to configuration 'testUtilCompileClasspath' in project 'sagan-common'
Evaluating project ':sagan-indexer' using build file 'D:\Programming\Java\Eclipse workspace\sagan-master\sagan-master\sagan-indexer\build.gradle'.
Configuring agent
Evaluating project ':sagan-site' using build file 'D:\Programming\Java\Eclipse workspace\sagan-master\sagan-master\sagan-site\build.gradle'.
Applying dependency management to configuration 'asciidoctor' in project 'sagan-site'
[Asciidoctor] asciidoctorj: <IP_ADDRESS>
[Asciidoctor] asciidoctorj-groovy-dsl: 1.0.0.preview2
Configuring agent
All projects evaluated.
Selected primary task 'generateGitProperties' from project :
Tasks to be executed: [task ':sagan-site:generateGitProperties']
:sagan-site:generateGitProperties (Thread[main,5,main]) started.
:sagan-site:generateGitProperties
Executing task ':sagan-site:generateGitProperties' (up-to-date check took 0.0 secs) due to:
Task has not declared any outputs.
:sagan-site:generateGitProperties FAILED
:sagan-site:generateGitProperties (Thread[main,5,main]) completed. Took 0.218 secs.

We couldn't reproduce the issue and we've significantly changed the build since. I'm closing this issue now.


Update README.md

Details
Remove ADO Extension link to improve clarity of onboarding
Motivation

Context

Pull request checklist

[ ] Addresses an existing issue: Fixes #0000
[ ] Added relevant unit test for your changes. (yarn test)
[ ] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
[ ] Ran precheckin (yarn precheckin)
[ ] Described how this PR impacts both the ADO extension and the GitHub action

Codecov Report

Merging #1255 (0390b51) into main (63ec506) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1255   +/-   ##
=======================================
  Coverage   90.94%   90.94%
=======================================
  Files          62       62
  Lines        1579     1579
  Branches      197      197
=======================================
  Hits         1436     1436
  Misses        143      143

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


1 and 2 point extra point scores.

I probably missed this, and I am sorry if I did... but this year the NFL Rule changes allow BOTH Offensive and Defensive 1 point Safetys on a extra point kick (previously was only Offense). I also know that a safety on a kick has never happened to date.  And they now allow a two point conversion to be returned for a 2 point (safety??) score . At least a 2 point score of some type.  What are the codes for these?  The two point score by the def could be a regular safety but what about the 1 point safetys??? All I found was this:
# I'm not sure how to classify these...

# 96: Extra point - safety
# If there is a fumble on an extra point attempt, and the loose ball goes
# into the endzone from impetus provided by the defensive team, and
# becomes dead in the endzone, the offense is awarded 1 point.

# 99: 2  point rush - safety
# See "Extra point - safety".

# 100: 2  point pass - safety
# See "Extra point - safety".

What are the codes for these?

I don't know.

We might have to just wait until it actually happens.

OK. I can live with that… I expect someone will notice it and then we will know.  I will post if I see one.
From: Andrew Gallant<EMAIL_ADDRESS>Sent: Friday, October 16, 2015 3:55 AM
To: BurntSushi/nflgame
Cc: rjhaz
Subject: Re: [nflgame] 1 and 2 point extra point scores. (#166)
We might have to just wait until it actually happens.
—
Reply to this email directly or view it on GitHub https://github.com/BurntSushi/nflgame/issues/166#issuecomment-148682396 .  https://github.com/notifications/beacon/ACPnt5sh2jbyawOjqtGGxrbSsEz2KvGmks5o8M8YgaJpZM4GP8Nn.gif

Not sure if anyone else noticed, but this finally happened last week in CAR @ NO<PHONE_NUMBER> play 1987:
(CAR, NO 15, Q2) G.Gano extra point is Blocked (K.Williams), Center-J.Jansen, Holder-B.Nortman. DEFENSIVE TWO-POINT ATTEMPT. S.Anthony recovered the blocked kick. ATTEMPT SUCCEEDS.

JSON data
"1987":
{
	"sp":1,
	"qtr":2,
	"down":0,
	"time":"01:55",
	"yrdln":"NO 15",
	"ydstogo":0,
	"ydsnet":74,
	"posteam":"CAR",
	"desc":"G.Gano extra point is Blocked (K.Williams), Center-J.Jansen, Holder-B.Nortman. DEFENSIVE TWO-POINT ATTEMPT. S.Anthony recovered the blocked kick. ATTEMPT SUCCEEDS.",
	"note":"XPB",
	"players":
	{
		"00-0022073":[
		{
			"sequence":2,
			"clubcode":"NO",
			"playerName":"K.Williams",
			"statId":87,
			"yards":0
		}],
		"00-0032102":[
		{
			"sequence":3,
			"clubcode":"NO",
			"playerName":"S.Anthony",
			"statId":403,
			"yards":0},
		{
			"sequence":4,
			"clubcode":"NO",
			"playerName":"S.Anthony",
			"statId":404,
			"yards":0
		}],
		"00-0026858":[
		{
			"sequence":1,
			"clubcode":"CAR",
			"playerName":"G.Gano",
			"statId":74,
			"yards":0
		}]

	}
}


Songs sometimes end too early

On a few charts the results screen can show up even though there are still squares heading towards the outside, off the top of my head I recall it happening with this song's normal.

Duplicate of #48
Fixed in #56
Going to be released in 1.07


DEPS: remove requirements-dppy.txt

Description
Follow up to recent changes removing dpctl from build requirements

/intelci: run


“Manual Override” detects false movements.

What version of Adaptive Cover are you using?
1.4.3
What version of Home Assistant are you using?
2024.8.2
Checklist

[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
Hello.
I have configured the integration in two models of Zigbee switch for Roller blinds. In one model it works fine, but in the other specific model I can't get the “Manual Override” to work properly.
I was reading a similar case (187) https://github.com/basbruss/adaptive-cover/issues/187 but I have tried several combinations both by checking the checkbox “Ignore intermediate positions during manual override (opening and closing)”.
Or setting “Manual override threshold” either one or the other or both. But I can't get it to work well for these blinds.
Is there anything I can do or test to try to find the problem?
Thank you very much
Reproduction steps
Configuration:
(For this example both options are deactivated, but activating one or the other, the behavior is still not as expected.)

16:50: Integration is enabled. The shutter automatically goes down to the calculated position 100% => 34% The integration detects a manual override which is not correct, “Manual Override”: “Running”.

16:51: The manual reset is forced and the status “Manual Override” becomes “Not running”.

(Waiting period)
16:55: After 4 minutes without moving the blind, a false manual override is detected again. Manual Override: “Running”.

(Waiting period) 5min are waited which is the time set as “Duration of manual override”.
17:10: Wait more than 5min but Manual Override: never goes to “Not running” and the integration stops automatically controlling the blind in this state.
At 17:08 there was a quick change of state but in the same second it went back to “Running” again.

Diagnostics dump
home-assistant_adaptive_cover_2024-08-18T15-12-02.917Z.log

Hello.
I was testing more in depth trying to discard things and try from a simple configuration without any customization.
And I have detected that the own calculations made by the integration and displayed in the “Cover Position” field, even if it doesn't move the blind, trigger the “Manual Override” mode.
I will try to deepen more this weekend in the logs but I am a little lost in why this behavior if the blind does not get to move neither automatically by the integration nor manually.
I just need to configure these particular blinds, the rest of the blinds are apparently working fine.
Any tip or help is appreciated because I have already tried all the combinations and options that the integration allows.
Thank you very much for your help.

I have the same issue with 1.4.3 and HA 2024.7.4

@SirSheik
From what I can see in the provided logs your cover integration sends an additional event that differs x% from the wanted position after the position is already reached by a earlier event.
2024-08-18 16:44:06.052 DEBUG (MainThread) [custom_components.adaptive_cover.const] Wait for target: {'cover.entrada_persiana': True}
2024-08-18 16:44:06.052 DEBUG (MainThread) [custom_components.adaptive_cover.const] Updating data
2024-08-18 16:44:06.052 DEBUG (MainThread) [custom_components.adaptive_cover.const] Calculated position: 35
2024-08-18 16:44:06.053 DEBUG (MainThread) [custom_components.adaptive_cover.const] Cover state change handled
2024-08-18 16:44:06.252 DEBUG (MainThread) [custom_components.adaptive_cover] Finished fetching adaptive_cover data in 1.205 seconds (success: True)
2024-08-18 16:44:06.252 DEBUG (MainThread) [custom_components.adaptive_cover] Finished fetching adaptive_cover data in 1.214 seconds (success: True)
2024-08-18 16:44:06.253 DEBUG (MainThread) [custom_components.adaptive_cover.const] Cover state change
2024-08-18 16:44:06.253 DEBUG (MainThread) [custom_components.adaptive_cover.const] Processing state change event: StateChangedData(entity_id='cover.entrada_persiana', old_state=<state cover.entrada_persiana=open; current_position=36, backlight_mode=low, calibration=OFF, calibration_time=15.3, indicator_mode=off, last_seen=2024-08-18T16:44:05+02:00, linkquality=127, motor_reversal=OFF, moving=STOP, position=36, device_class=shutter, friendly_name=Entrada, supported_features=15 @ 2024-08-18T16:41:30.891264+02:00>, new_state=<state cover.entrada_persiana=open; current_position=35, backlight_mode=low, calibration=OFF, calibration_time=15.3, indicator_mode=off, last_seen=2024-08-18T16:44:05+02:00, linkquality=127, motor_reversal=OFF, moving=STOP, position=35, device_class=shutter, friendly_name=Entrada, supported_features=15 @ 2024-08-18T16:41:30.891264+02:00>)
2024-08-18 16:44:06.253 DEBUG (MainThread) [custom_components.adaptive_cover.const] Position 35 reached for cover.entrada_persiana
2024-08-18 16:44:06.253 DEBUG (MainThread) [custom_components.adaptive_cover.const] Wait for target: {'cover.entrada_persiana': False}
2024-08-18 16:44:06.253 DEBUG (MainThread) [custom_components.adaptive_cover.const] Updating data
2024-08-18 16:44:06.253 DEBUG (MainThread) [custom_components.adaptive_cover.const] Calculated position: 35
2024-08-18 16:44:06.254 DEBUG (MainThread) [custom_components.adaptive_cover.const] Cover state change handled
2024-08-18 16:44:06.284 DEBUG (MainThread) [custom_components.adaptive_cover] Finished fetching adaptive_cover data in 0.232 seconds (success: True)
2024-08-18 16:44:06.285 DEBUG (MainThread) [custom_components.adaptive_cover.const] Cover state change
2024-08-18 16:44:06.285 DEBUG (MainThread) [custom_components.adaptive_cover.const] Processing state change event: StateChangedData(entity_id='cover.entrada_persiana', old_state=<state cover.entrada_persiana=open; current_position=35, backlight_mode=low, calibration=OFF, calibration_time=15.3, indicator_mode=off, last_seen=2024-08-18T16:44:05+02:00, linkquality=127, motor_reversal=OFF, moving=STOP, position=35, device_class=shutter, friendly_name=Entrada, supported_features=15 @ 2024-08-18T16:41:30.891264+02:00>, new_state=<state cover.entrada_persiana=closing; current_position=36, backlight_mode=low, calibration=OFF, calibration_time=15.3, indicator_mode=off, last_seen=2024-08-18T16:44:05+02:00, linkquality=127, motor_reversal=OFF, moving=DOWN, position=36, device_class=shutter, friendly_name=Entrada, supported_features=15 @ 2024-08-18T16:44:06.255618+02:00>)
2024-08-18 16:44:06.285 DEBUG (MainThread) [custom_components.adaptive_cover.const] Wait for target: {'cover.entrada_persiana': False}
2024-08-18 16:44:06.285 DEBUG (MainThread) [custom_components.adaptive_cover.const] Updating data
2024-08-18 16:44:06.285 DEBUG (MainThread) [custom_components.adaptive_cover.const] Calculated position: 35
2024-08-18 16:44:06.285 DEBUG (MainThread) [custom_components.adaptive_cover.const] Set manual control for cover.entrada_persiana, for at least 900.0 seconds, reset_allowed: False
2024-08-18 16:44:06.286 DEBUG (MainThread) [custom_components.adaptive_cover.const] Updating last updated to 2024-08-18 14:44:06.255618+00:00 for cover.entrada_persiana. Allow reset:False
2024-08-18 16:44:06.286 DEBUG (MainThread) [custom_components.adaptive_cover.const] Cover state change handled
2024-08-18 16:44:06.288 DEBUG (MainThread) [custom_components.adaptive_cover.const] Cover state change

So, in the logs, the system is waiting for the event where your cover reaches 35%, which does happen. But then, just 0.03 seconds later, there’s an event showing the cover changed to 36%. This triggers the manual override detection. Setting the manual override threshold to a larger value could help resolve this for you.

@Kejszijo Please add debug logs and diagnostics.
Although it can look as similar issue, it can be something different based on the integrations/covers you use. Stating you have the same issue without that information is not enough to be able to solve your issue 😉

@SirSheik From what I can see in the provided logs your cover integration sends an additional event that differs x% from the wanted position after the position is already reached by a earlier event. [Por lo que puedo ver en los registros proporcionados, la integración de su cobertura envía un evento adicional que difiere un x% de la posición deseada después de que un evento anterior ya haya alcanzado la posición.]
2024-08-18 16:44:06.052 DEBUG (MainThread) [custom_components.adaptive_cover.const] Wait for target: {'cover.entrada_persiana': True}
2024-08-18 16:44:06.052 DEBUG (MainThread) [custom_components.adaptive_cover.const] Updating data
2024-08-18 16:44:06.052 DEBUG (MainThread) [custom_components.adaptive_cover.const] Calculated position: 35
2024-08-18 16:44:06.053 DEBUG (MainThread) [custom_components.adaptive_cover.const] Cover state change handled
2024-08-18 16:44:06.252 DEBUG (MainThread) [custom_components.adaptive_cover] Finished fetching adaptive_cover data in 1.205 seconds (success: True)
2024-08-18 16:44:06.252 DEBUG (MainThread) [custom_components.adaptive_cover] Finished fetching adaptive_cover data in 1.214 seconds (success: True)
2024-08-18 16:44:06.253 DEBUG (MainThread) [custom_components.adaptive_cover.const] Cover state change
2024-08-18 16:44:06.253 DEBUG (MainThread) [custom_components.adaptive_cover.const] Processing state change event: StateChangedData(entity_id='cover.entrada_persiana', old_state=<state cover.entrada_persiana=open; current_position=36, backlight_mode=low, calibration=OFF, calibration_time=15.3, indicator_mode=off, last_seen=2024-08-18T16:44:05+02:00, linkquality=127, motor_reversal=OFF, moving=STOP, position=36, device_class=shutter, friendly_name=Entrada, supported_features=15 @ 2024-08-18T16:41:30.891264+02:00>, new_state=<state cover.entrada_persiana=open; current_position=35, backlight_mode=low, calibration=OFF, calibration_time=15.3, indicator_mode=off, last_seen=2024-08-18T16:44:05+02:00, linkquality=127, motor_reversal=OFF, moving=STOP, position=35, device_class=shutter, friendly_name=Entrada, supported_features=15 @ 2024-08-18T16:41:30.891264+02:00>)
2024-08-18 16:44:06.253 DEBUG (MainThread) [custom_components.adaptive_cover.const] Position 35 reached for cover.entrada_persiana
2024-08-18 16:44:06.253 DEBUG (MainThread) [custom_components.adaptive_cover.const] Wait for target: {'cover.entrada_persiana': False}
2024-08-18 16:44:06.253 DEBUG (MainThread) [custom_components.adaptive_cover.const] Updating data
2024-08-18 16:44:06.253 DEBUG (MainThread) [custom_components.adaptive_cover.const] Calculated position: 35
2024-08-18 16:44:06.254 DEBUG (MainThread) [custom_components.adaptive_cover.const] Cover state change handled
2024-08-18 16:44:06.284 DEBUG (MainThread) [custom_components.adaptive_cover] Finished fetching adaptive_cover data in 0.232 seconds (success: True)
2024-08-18 16:44:06.285 DEBUG (MainThread) [custom_components.adaptive_cover.const] Cover state change
2024-08-18 16:44:06.285 DEBUG (MainThread) [custom_components.adaptive_cover.const] Processing state change event: StateChangedData(entity_id='cover.entrada_persiana', old_state=<state cover.entrada_persiana=open; current_position=35, backlight_mode=low, calibration=OFF, calibration_time=15.3, indicator_mode=off, last_seen=2024-08-18T16:44:05+02:00, linkquality=127, motor_reversal=OFF, moving=STOP, position=35, device_class=shutter, friendly_name=Entrada, supported_features=15 @ 2024-08-18T16:41:30.891264+02:00>, new_state=<state cover.entrada_persiana=closing; current_position=36, backlight_mode=low, calibration=OFF, calibration_time=15.3, indicator_mode=off, last_seen=2024-08-18T16:44:05+02:00, linkquality=127, motor_reversal=OFF, moving=DOWN, position=36, device_class=shutter, friendly_name=Entrada, supported_features=15 @ 2024-08-18T16:44:06.255618+02:00>)
2024-08-18 16:44:06.285 DEBUG (MainThread) [custom_components.adaptive_cover.const] Wait for target: {'cover.entrada_persiana': False}
2024-08-18 16:44:06.285 DEBUG (MainThread) [custom_components.adaptive_cover.const] Updating data
2024-08-18 16:44:06.285 DEBUG (MainThread) [custom_components.adaptive_cover.const] Calculated position: 35
2024-08-18 16:44:06.285 DEBUG (MainThread) [custom_components.adaptive_cover.const] Set manual control for cover.entrada_persiana, for at least 900.0 seconds, reset_allowed: False
2024-08-18 16:44:06.286 DEBUG (MainThread) [custom_components.adaptive_cover.const] Updating last updated to 2024-08-18 14:44:06.255618+00:00 for cover.entrada_persiana. Allow reset:False
2024-08-18 16:44:06.286 DEBUG (MainThread) [custom_components.adaptive_cover.const] Cover state change handled
2024-08-18 16:44:06.288 DEBUG (MainThread) [custom_components.adaptive_cover.const] Cover state change

So, in the logs, the system is waiting for the event where your cover reaches 35%, which does happen. [Entonces, en los registros, el sistema está esperando el evento en el que su cobertura alcance el 35%, lo cual sucede.] But then, just 0.03 seconds later, there’s an event showing the cover changed to 36%. [Pero luego, solo 0,03 segundos después, hay un evento que muestra que la cobertura cambió al 36%.] This triggers the manual override detection. [Esto activa la detección de anulación manual.] Setting the manual override threshold to a larger value could help resolve this for you. [Establecer el umbral de anulación manual en un valor mayor podría ayudarle a resolver este problema.]

Hello.
Yes I have also tried to set “Manual override threshold” to 10% but although the situation improves the behavior is not as expected.
With this change the integration does not detect false positives of movement during automatic operation, but after a manual movement, it never leaves the “Running” state again.
This afternoon if you wish I can send you again the logs with this change, since this window only receives sun in the afternoon.
Thank you very much for your time and help.

Hello @basbruss
I did the change you mentioned and set the threshold to 10%.

According to the integration the calculated position should be 48%.

But as you can see the shutter has not moved in 4h and is still in the initial position 95%.

This is because at some point the integration detected a false manual movement, although the blind has not moved either manually or automatically and since then has not left that state and has been like that for 40 min.

I attach again the logs for a few minutes. I have deleted logs that were not from the integration to facilitate your review.
home-assistant_adaptive_cover_2024-08-22T15-57-40.668Z.log
Can you imagine what could be happening to detect these false manual movements and worst of all, never get out of this “Running” state?
Thank you very much for your time, I really appreciate your help.

Have you found a solution to this? finding the exact same thing here.
Blinds were wide open with sun glaring through the window and found manual override was turned on for 7 of 9 blinds.
I pressed the reset button which made them go to their correct position, but manual override turned right back on.

It almost seems as if large changes even if triggered by the integration are triggering the manual override.

Have you found a solution to this? finding the exact same thing here.
Blinds were wide open with sun glaring through the window and found manual override was turned on for 7 of 9 blinds. I pressed the reset button which made them go to their correct position, but manual override turned right back on.

It almost seems as if large changes even if triggered by the integration are triggering the manual override.
EDIT: I had to fine tune the settings on one of my blinds. Had a minimum sun elevation of 10%, but the sun was at 9% which caused the blinds to be fully open and the sun glaring straight in the window. So I made the adjustment to minimum sun elevation down to 5%. I toggled the main control switch and turned it off and back on. The integration kicked in and started to lower the blinds and I watched the manual override turn itself on.
So it is definitely detecting large changes caused by the integration and enabling manual override.

Hello.
I have not made any progress, I was reviewing the logs in depth, but with the information they show and knowing how it is implemented at the code level, I was not able to identify the problem.
Finally I have been forced to disable the manual mode and implement it temporarily in Node-Red.
I don't know if @basbruss  could give us some light on this issue.
Thank you very much for your help.

Finally I have been forced to disable the manual mode and implement it temporarily in Node-Red.

I've done the same