Start notification server

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email<EMAIL_ADDRESS>to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to<EMAIL_ADDRESS>and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information

Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Codecov Report
Base: 32.19% // Head: 32.19% // No change to project coverage :thumbsup:

Coverage data is based on head (59d02e4) compared to base (5bd9716).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage   32.19%   32.19%
=======================================
  Files         131      131
  Lines       14158    14158
  Branches     4114     4114
=======================================
  Hits         4558     4558
  Misses       9506     9506
  Partials       94       94

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Permission error

Hello,
While trying to exxport DMARC report on a dockerized container, I'm getting the error below.
=========
INFO:     Waiting for application startup.
INFO:     ASGI 'lifespan' protocol appears unsupported.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:9797 (Press CTRL+C to quit)
Error during IMAP queue polling.
Traceback (most recent call last):
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/imap_queue.py", line 59, in _consume
async for uid, msg in client.fetch(1, msg_count):
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/imap_queue.py", line 125, in fetch
match = mail_header_regex.match(line)
TypeError: cannot use a string pattern on a bytes-like object
INFO:     <IP_ADDRESS>:35308 - "GET /metrics HTTP/1.1" 200 OK
INFO:     Shutting down
Traceback (most recent call last):
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/app.py", line 79, in run
self._save_metrics()
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/app.py", line 88, in _save_metrics
self.metrics_persister.save(metrics)
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/metrics_persister.py", line 55, in save
with open(self.path, "w") as f:
PermissionError: [Errno 13] Permission denied: '/var/lib/dmarc-metrics-exporter/metrics.db'
===========

Hello,
I've fixed this error, but currently I'm encountering the error mentioned below
ImportError: ('UID MOVE', 'NO', [b'Client tried to access nonexistent namespace. (Mailbox name should probably be prefixed with: INBOX.) (0.001 + 0.000 secs).'])

Please provide the following additional information:

Python version
dmarc-metrics-exporter version
full stack trace of the error

Please take a look at the details mentioned below
Python 2.7.17 (Host machine)
Python 3.7.12 (Dmarc-exporter container)
dmarc-metrics-exporter:0.4.1 - Dmarc-exporter version
The one mentioned below is the error I'm encountering while running it
===========
Traceback (most recent call last):
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/imap_queue.py", line 68, in _consume
await client.uid_move(uid, self.folders.done)
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/imap_queue.py", line 154, in uid_move
self._client.uid("move", str(uid), destination),
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/imap_queue.py", line 102, in _check
raise ImportError(command, res, data)
ImportError: ('UID MOVE', 'NO', [b'Client tried to access nonexistent namespace. (Mailbox name should probably be prefixed with: INBOX.) (0.001 + 0.000 secs).'])
Error during IMAP queue polling.
Traceback (most recent call last):
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/app.py", line 96, in run
self._save_metrics()
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/app.py", line 105, in _save_metrics
self.metrics_persister.save(metrics)
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/metrics_persister.py", line 55, in save
with open(self.path, "w", encoding="utf-8") as f:
PermissionError: [Errno 13] Permission denied: '/var/lib/dmarc-metrics-exporter/metrics.db'
===========
I've connected my email account in BlueHost with it and it seem to fetch the report. However, it just fetches the last mail in the inbox but not the other ones. Also, this particular error is seen in the docker logs.

Why does it fetch the report from the very first mail only?
I've around 10 mails with DMARC reports arrived on my inbox. Is there any way fetch all those mail report at once?

Are you using the default folders configuration? From the error reported by the server it seems, the folder names might need to be prefixed with INBOX., e.g.:
{
    "folders": {
        "done": "INBOX.Archive",
        "error": "INBOX.Invalid"
    }
}

Can you also check whether those folders actually exist in the mailbox? They should be created automatically by dmarc-metrics-exporter, though.
There's also a permission error. You need to ensure that /var/lib/dmarc-metrics-exporter/metrics.db is writable.

Why does it fetch the report from the very first mail only?

I suppose that because it fails to move the message out of the inbox, no further messages are processed.

Are you using the default folders configuration?

Yes, I was using the default folders. I'll try switching to the ones you've mentioned in the example. And yes, Archive folder is already available in the mailbox.
Regarding the metrics.db, I was not able to view this particular file under the path (/var/lib/dmarc-metrics-exporter/) in container. Should I create a file named metrics.db in the host machine and map it to the container?
I was under the impression that this metrics.db will be automatically created once the container is online. However, it wasn't available. Please let me know your opinion on this.

I tried changing the folder names to tone mentioned below and the container is not being started now.
},
"folders": {
    "inbox": "Inbox",
    "done" : "Inbox.archive",
    "error": "Inbox.Invalid"

Please take a look at the error seen in the docker logs.
Traceback (most recent call last):
File "/usr/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/usr/local/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/main.py", line 5, in
main(sys.argv[1:])
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/app.py", line 56, in main
asyncio.run(app.run())
File "/usr/local/lib/python3.7/asyncio/runners.py", line 43, in run
return loop.run_until_complete(main)
File "/usr/local/lib/python3.7/asyncio/base_events.py", line 587, in run_until_complete
return future.result()
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/app.py", line 89, in run
self.exporter = self.exporter_cls(self.metrics_persister.load())
File "/venv/lib/python3.7/site-packages/dmarc_metrics_exporter/metrics_persister.py", line 50, in load
return JSONSerializer.deserialize(DmarcMetricsCollection, json.load(f))
File "/usr/local/lib/python3.7/json/init.py", line 296, in load
parse_constant=parse_constant, object_pairs_hook=object_pairs_hook, **kw)
File "/usr/local/lib/python3.7/json/init.py", line 348, in loads
return _default_decoder.decode(s)
File "/usr/local/lib/python3.7/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/local/lib/python3.7/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Sorry, I'm a bit confused on this step. While creating the container, should we create a file named metrics.db under the path /var/lib/dmarc-metrics-exporter in our host machine and map it to the container?
I'm using Roundcube as the mail client, under that we won't be to create the folder with special characters. I believe due to that reason the folder names such Inbox.archive is not being created and the read mails aren't moved to it. Is there any workaround for that?

Sorry, I'm a bit confused on this step. While creating the container, should we create a file named metrics.db under the path /var/lib/dmarc-metrics-exporter in our host machine and map it to the container?

The file should be created by dmarc-metrics-exporter. But you likely want to map it from the host machine into the container, so that it is persisted between restarts of the container.

I'm using Roundcube as the mail client

The mail client should be irrelevant. The IMAP server might be a problem, though.

I believe due to that reason the folder names such Inbox.archive is not being created and the read mails aren't moved to it. Is there any workaround for that?

You can configure any folder names you like if they work for you. However, the defaults don't contain special characters, and in one of the previous stack traces the server said "Client tried to access nonexistent namespace. (Mailbox name should probably be prefixed with: INBOX."

Closing this as stale, feel free to reopen if you still have problems.


Put the Language button at the top of page for easy changing

Because most of the time it is through Google search to jump to the document page, sometimes Chinese, sometimes English, but most of the Chinese machine translation is difficult to read, but there are some exceptions.
So I basically decide whether to jump to an English page depending on the quality of translation, but every time I must scroll to the bottom of the page to click Language button or modify the URL from en-us to zh-cn.
So I hope to be able to put the button at the top of the page or to fixed in a certain position floating like the sidebar. Include all Microsoft Docs not only Asp.Net Core will be better. Thanks.

Hello @GreatFireWall ... Provide that feedback to the general Microsoft.Docs repo ...
https://github.com/MicrosoftDocs/feedback/issues


v0.8.5_09: Blank pop-up is displayed on clicking “Color” icon twice.

SEVERITY:  Major
MODULE:  Bubble Chart
Platform:

Windows 7 / Chrome 48.0
Windows 7 / Firefox  42.0

RELEASE: v0.8.5
STEPS TO REPRODUCE:

Navigate to the URL : http://static.gapminderdev.org/vizabi/release/v0.8.5/preview/bubblechart.html
“Bubble Chart” page will be loaded.
Click on “Landscape” view button.
Click on “Color” icon and pop-up is appeared.
Click Ok.
Again click on “Color” icon.
Note that blank pop-up is display on the screen.

ACTUAL RESULTS:
Blank pop-up is displayed on clicking “Color” icon twice.
EXPECTED RESULTS:
Blank pop-up should not display on clicking “Color” icon twice.
SCREENSHOT:

thanks @dab2000


⚠ Samsung has degraded performance

In d0795c0, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2260 ms

Resolved: Samsung performance has improved in e9754cd.


Uploading kcov output to coveralls.io results in 0% coverage

Output of coveralls --service=github debug:

Missing .coveralls.yml file. Using only env variables.
Testing coveralls-python...
{"source_files": [], "git": {"branch": "extra-branch", "head": {"id": "7033f4e955cf6ed278372a093cb2887094f6e229", "author_name": "Dinko Pehar", "author_email"<EMAIL_ADDRESS>"committer_name": "Dinko Pehar", "committer_email"<EMAIL_ADDRESS>"message": "Final"}, "remotes": [{"name": "origin", "url": "git@github.com:pentest115/stumpy_png.git"}]}, "service_name": "github", "config_file": ".coveragerc", "base_dir": ""}
==
Reporting 0 files
==

Hello.
I'm trying to find a way to upload coverage data to coveralls.io . Currently, what I do, is build a binary for Crystal lang and use kcov coverage tool to generate coverage report.
   ϗ kcov --clean --include-path=$(pwd)/src $(pwd)/coverage ./specs                         [7033f4e]
Run options: --seed 14170 --parallel 1

..........

Finished in 00:00:00.012737299, 78.50958040633262 runs/s

10 tests, 0 failures, 0 errors, 0 skips

coverage.zip
I uploaded a zip file which you can browse covered code.

I'm having difficulties uploading to coveralls.io using coveralls command. It states that there is 0% coverage, but from kcov output we see that is not the case.
Can you help me resolve this one ?

Hi @dinko-pehar -- I'm not personally familiar with the kcov command (or the Crystal language in general!), but you can find the instructions for integrating other tools in our docs here.
The general rule is to have the external tools (eg. kcov here) produce a JSON file which can then by merged in to the coveralls results via: coveralls --merge=my-coverage.json.

Unfortunately, reports created by kcov can't be uploaded to coveralls.io . kcov is a great tool and it generates many reports, but coveralls.io only supports lcov reports. I didn't managed to convert any format to lcov. So I switched to codecov.io . You can close issue if you want.

Ah, sorry to hear that. It looks like it might be possible to convert from kcov to lcov data, but I wasn't able to find an existing project to handle that case; looks like something that would need to be built explicitly to handle this case.
Thanks for the report either way, I'll clean up our docs accordingly to make sure it's called out that we can only support lcov data at this time.


Added CONTRIBUTING.md

I don't think we need to capitalize all uses of git throughout the codebase - I pretty much only see git used lowercase. In the future I won't adopt this convention, and we really should not be nitpicking over stuff like that.
I applied the fixes only to avoid silly bikeshedding, even though I disagree on most of the suggestions


BUG: flatlist item separator components

Item separator components in a FlatList are not being rendered correctly
React Native version: react-native: 0.45.1
Platform: iOS

Why was this closed? I have the same problem.

The issue did not meet the minimum requirements set forth in the guidelines.


Produce external_deps archive with naclsdk ported to python3

Produce external_deps archive with naclsdk ported to python3. I only tested with linux.

Can we fix the CI and update the CI to work with python3 to verify this change?

We just need to upload the to-be-next archive zip and restart the CI task.

So what I did is that I extracted current deps archives, applied the patch, and repackaged. It builds on all systems.

After some additional patching the produced binaries seem to work on my machine. Nice job!

I imported the patch to have all packages using tar.xz format from #713.
I also implemented the deps-<system>-<arch>-<compiler>_<version>.<ext> format. Note that I added a deps- prefix because it makes easy to manage files this way (for example one can do rm deps-*.tar.xz).
I uploaded ready-to-use packages. I haven't built them myself, what I did is that I used version 6 packages, renamed the folders, applied the python3 patch for naclsdk, and packafed as tar.xz.
If people can try to build the game by hand that would be appreciated, as it looks like @slipher caught some problems the CI didn't.

Tried to build NaCl on Mac and didn't get past the configuration stage. From the CMake sub-invocation for NaCl it tried to download deps from https://dl.unvanquished.net/deps/deps--i686-default_7.tar.xz.

I fail to understand how that can happen. 😲

Tried to build NaCl on Mac and didn't get past the configuration stage. From the CMake sub-invocation for NaCl it tried to download deps from https://dl.unvanquished.net/deps/deps--i686-default_7.tar.xz.

I fail to understand how that can happen. astonished

I also got this on Linux, after multiple successful attempts:
Downloading dependencies from 'https://dl.unvanquished.net/deps/deps--i686-default_7.tar.xz'
-- [download 0% complete]
CMake Error at daemon/CMakeLists.txt:458 (message):
  Error downloading
  'https://dl.unvanquished.net/deps/deps--i686-default_7.tar.xz':

That doesn't make sense.

Minimal testing and looking suggests that it work (Linux / NixOS / python2 only). LGTM

I get the bogus deps URL when starting from an empty build dir, configuring with BUILD_GAME_NACL=1 and immediately attempting to build the nacl-vms target.

I get the bogus deps URL on Mac when starting from an empty build dir, configuring with BUILD_GAME_NACL=1 and immediately attempting to build the nacl-vms target.

When this happen, NACL is set.
I did:
if (WIN32)
    set(DEPS_SYSTEM windows)
elseif (APPLE)
    set(DEPS_SYSTEM macos)
elseif (LINUX)
    set(DEPS_SYSTEM linux)
elseif (NACL)
    set(DEPS_SYSTEM nacl)
endif()

And I got:
  Error downloading
  'https://dl.unvanquished.net/deps/nacl-i686-default_7.tar.xz':

Looks like the way it works now is that the parent cmake instance sets -DDEPS_DIR=xxx and the child instance carefully avoids overwriting this variable in the nacl case.
(Which is not quite right btw; it means that building nacl won't work in a cross-compile build. If you want you could take this opportunity to determine the host system architecture in the nacl case and download the deps for that :stuck_out_tongue:)

(Which is not quite right btw; it means that building nacl won't work in a cross-compile build. If you want you could take this opportunity to determine the host system architecture in the nacl case and download the deps for that stuck_out_tongue)

I don't really understand that. Anyway I'm surprised the code worked before… How did it worked before?

As I said it's the -DDEPS_DIR=${DEPS_DIR} flag to the child cmake invocation in DaemonGame.cmake. It stopped working because you started to always write the value of DEPS_DIR, instead of leaving it untouched when NACL is on.

As I said it's the -DDEPS_DIR=${DEPS_DIR} flag to the child cmake invocation in DaemonGame.cmake. It stopped working because you started to always write the value of DEPS_DIR, instead of leaving it untouched when NACL is on.

Ah right, there was no NACL mention but no if for it so since DEPS_DIR was unset the download code was ignored.
So I assume the added if (NACL) test is the correct way to do it.

@slipher look at my latest commit, it makes separate <system>-<arch>-pnacl packages.
The 7a version is temporary (will be 7 if it works).

I give up for now for splitting the archives. It looks like it uncovers bugs like looking for system lua when building nexe and things like that.
So I removed the commit that split the archives and such effort would be done later (way later), I don't have time to investigate archive splitting more right now.
I'm considering this ready if it builds.

I guess you'll need to squash the commits (other than the .deb one) to make all commits buildable?

I don't like squashing but yes, we better want to have commits buildable, so I squashed?

The nacl patch could have gone into its own commit if you put the Python cmake changes into the squashed commit, since I made it work with Python 2.
LGTM

Right, I did that as I prefer that.
I made sure to move the DEPS_VERSION incrementing to the commit changing the archive name and format.

I mean the stuff that looks for Python 2/3 instead of Python 2 needs to be in (or after) the big commit.

@slipher, here is what I did:
Except the commit removing the support for the old nacl deb which is just cleaning-up things,

first commit introduce the code to produce python2/3 compatible deps archive;
second commit use the new deps archive (with python2/3 compatibility) and other changes (name, format…);
third commit enable the ability to use python3.

I think it's now ready for merging! 🙂

The commit for enabling Python 3 says that I am the author which is not right.
Otherwise LGTM

🎉


Arabic localized app, shows calender with persian numbers

set the calendar locale to be "ar", you will see the numbers of days shown are in Persian numbers, we need to show Arabic letters

private val ARABIC_DIGITS = charArrayOf(
        '0' + 1584,
        '1' + 1584,
        '2' + 1584,
        '3' + 1584,
        '4' + 1584,
        '5' + 1584,
        '6' + 1584,
        '7' + 1584,
        '8' + 1584,
        '9' + 1584
)

You can use these in your languageUtils file and check if the language name is "ar" or else
that gonna fix it

Hi @MohamedEmish,
Thank you for reporting the issue, I will fix it soon.

Please update the version of primecalendar to 1.3.1. The issue has been solved.

Hi Amin
I upgraded the library but the issue still there
I tried to contribute to the library but i couldn't push a branch with the
fix, so please fix it and keep me updated
thanks
On Mon, Nov 30, 2020 at 11:39 AM Amin Hassani<EMAIL_ADDRESS>wrote:

Reopened #38 https://github.com/aminography/PrimeDatePicker/issues/38.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aminography/PrimeDatePicker/issues/38#event-4050979317,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJWPJHYJRU7DQE6FJ4AH2ADSSNR3JANCNFSM4UGWNPOQ
.

Sorry for that.
Now it is fixed.
Update to:
dependencies {
    implementation 'com.aminography:primedatepicker:3.2.2'
    implementation 'com.aminography:primecalendar:1.3.2'
}

Fixed, Thank you
we can close it now


Allow specification of container WorkingDir in tasks

Allow for the setting of workingdirs at the task level
This closes https://github.com/runabol/tork/issues/361, and allows for tasks to set the correct workingdir for a container (it is currently ignored for shell runtimes)- this helps avoid things like cd /foo in commands; it also has the side effect of creating directories under certain circumstances.
Additionally, this PR contains an updated swagger.json to include the new task field; this command doesn't seem to have been run for a couple of changes and so it has pulled in some other changes.
Happy to remove that change and open a new PR if needed.
Edit to add: I haven't updated input.Task to include a working dir because I want to wait and see whether I should make that available in yaml; I also don't know where the docs live so I can document public interfaces like the yaml file

Hang on, something doesn't look right. Closing; will reopen

I hadn't realised that the task.Clone() function used hardcoded fields and so I wasn't seeing what I expected. Updated, reopened

Great work! Couple of points:

What happens if the user specifies both workingdir and files? one option is to use it in favor of the default /tork workdir.
Can we have the property named workdir instead of workingdir so it's a little more concise?
Go ahead and add the property to input.Task as well.

Yeah no worries, I'll tackle this afternoon.
With regards to the points:

I umm'd and ahh'd about this- I didn't want to break the contract that files would be stored in /tork whether or not a working directory was set or not, especially since/tork has the stdout file (which I neither fully understand enough to change, nor want to store in a directory I'm loading to/from disk)- I want to take direction on this, since you know this project better than absolutely anyone, but I suspect this requires some thought.
I didn't want to confuse things between the workdir variable and the WorkingDir value set in the container.Config struct; I also think they might solve different problems, but I'm not sure I understand what Tasks.Files does or where it's used
Yep, will do!

That's a fair point. We probably want to keep stdout internal and out of the way of the user. For additional context, files are just a convenient means to create files in the /tork workdir, that you can then refer to from the run script:

name: Get the post
image: python:3
files:
  script.py: |
    import requests
    url = "https://jsonplaceholder.typicode.com/posts/1"
    response = requests.get(url)
    data = response.json()
    print(data['title'])
run: |
  pip install requests
  python script.py > $TORK_OUTPUT

Possibly, what we're looking at here is having two directories: one internal for Tork itself to have the stdout and entrypoint files and another "userspace" working directory.

I think that since Tork isn't bound to Docker as a runtime environment (it supports Shell runtime for example and in the future could potentially support other runtimes like WASM, mircovms or what not) we don't have to have direct mapping between Docker's API and the Task API. Even Docker itself is a little confusing since the Dockerfile directive is WORKDIR but their API is WorkingDir. In all honestly, the difference is minor, but I figure that since workdir describes what it means unambiguously there's no need to spell it out further.

Perfect!
I'll respond to the second point first, since it's simplest: great point, works for me! Workdir it is. (To solidify the lack of consistency across everything even more, os/exec.Cmd just calls it Dir 🙄 )
Otherwise, how does this design sound?

By default, workdir for the docker runtime is something like /userspace, or /work or something (we can't set it to whatever the default working dir of a container is, or we risk blatting away scripts and files already in there I think)
Otherwise, it can be set in a task definition

Then we have mostly the same flow as you had before- if files are set, add them to whatever workdir is, based on the above and always set the container working dir. Otherwise only set the container working dir if workdir != DefaultWorkdir

Yea, that sounds great. We just need to make sure that files are written to the workdir since the user will be using relative paths in their run script. For the workdir name we could probably use /tork/workdir so everything is kept nicely in one folder hierarchy.

I'm not hugely happy with my solution here, but if you think I'm just being unduly harsh on myself then merge away!
Otherwise I'll tackle tomorrow morning, I'm off down the pub for the football instead.
Essentially: shifting Files into a subdirectory (either /tork/workspace or user specified) meant revisiting the tar writer. Of course, if the workdir is under /tork still then great: you only need to prepend that path to filenames in the tar. If not, you need two tars.
The combinatrices started getting confusing, so I wrote it to always produce two tars. It's slightly less efficient, but not hugely.
If that's an issue then I'll come back to this

This looks right on first glance. Will take a better look on the weekend. I'm moving tomorrow, so will definitely try and look after I'm settled in a bit.

Cool, no worries - there's absolutely no rush on any of this, It Works On My Fork ™  and that's more than good enough for me to continue doing what I'm doing!

Cool, no worries - there's absolutely no rush on any of this, It Works On My Fork ™  and that's more than good enough for me to continue doing what I'm doing!

Actually, it's a good job we didn't merge. Just tried this on another machine and got a weird error where the entrypoint file didn't exist.
Turns out that I was trying to be a bit clever by passing an *os.File about, rather than closing and re-opening like the original implementation did. But actually, in certain environments/ OSes at least, doing this flushes waiting writes to disk that might not have been flushed yet. And reading from a file doesn't take that cache into account on all platforms (think of it like READ UNCOMMITTED in the sql spec, and how this is ignored in postgres).
So for now I've done the close/ reopen.
I did draft a change to not bother about disks at all, and pass a bytes.Buffer around, but I have no idea how much memory tork instances might have (it might be a tiny 256mb instance talking to a remote docker host for all I have) and how large an entrypoint/ Files could be and so writing to disks and letting go handle seeking seemed smarter than sticking it all in RAM.
(Plus I've found that commenting out the line to delete the archives after creation was really helpful to see what had been written to disk to debug writing archives and didn't want to lose that option again)

Superseded by https://github.com/runabol/tork/pull/368


RuntimeError: Optimal parameters not found: Number of calls to function has reached maxfev = 800.

When I fit the exponential function, my data X from [0-1],Y from [0,1086];
The fitting function is:
def func(x, a, b, c):
return a * np.exp(-b * x) + c
Then raise RuntimeError, why?

These sorts of usage questions are best asked on Stackoverflow.


RFM - DMDE - DM Disk Editor and Data Recovery Software

Checklist

[x] The package I am requesting does not already exist on https://chocolatey.org/packages;
[x] There is no open issue for this package;
[x] The issue title starts 'RFP - ';
[x] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL : https://dmde.com/
Direct download URL for the software / installer : https://dmde.com/download.html
Software summary / short description:

DMDE is a powerful software for data searching, editing, and recovery on disks. It may recover directory structure and files in some complicated cases through the use of special algorithms when other software can't help. The software is listed, reviewed, and awarded in magazines and catalogs.
DMDE has a number of freeware features such as disk editor, simple partition manager (e.g. allows partition undeleting), a tool to create disk images and clones, RAID constructor, file recovery from the current panel. Paid editions support file and directory recovery without the restriction, DMDE Professional Edition has additional features to recover data for clients
(...)
DMDE is portable and runs just after extracting.

Changed to RFM due to package existing.
Package was submitted in 2014, currently failing, is unlisted and author have removed github repository. Assuming it is no longer being maintained.
https://chocolatey.org/packages/dmde

Status: In progress

Waiting to be added as maintainer (request already sent to Chocolatey contact-site admins).
Updated package ready to be published: https://github.com/chtof/chocolatey-packages/tree/master/automatic/dmde

Status: Review
https://chocolatey.org/packages/dmde

Status: Published
https://chocolatey.org/packages/dmde
Can be closed.


iceberg source: support nested types

not supported in upstream: https://github.com/apache/iceberg-rust/blob/8a3de4e66fd9672c216985f11044168a325a9177/crates/iceberg/src/scan.rs#L229-L236
https://github.com/apache/iceberg-rust/issues/405

fixed in #18498


C-x c hangs

Closing lem has some problem:
tron$ lem
^[[A

^C
debugger invoked on a SB-SYS:INTERACTIVE-INTERRUPT @9FFFAC88BCB in thread
#<THREAD tid=255416 "main thread" RUNNING {1104CC00A3}>:
  Interactive interrupt at #x9FFFAC88BCB.

Type HELP for debugger help, or (SB-EXT:EXIT) to exit from SBCL.

restarts (invokable by number or by possibly-abbreviated name):
  0: [CONTINUE] Return from SB-UNIX:SIGINT.
  1: [ABORT   ] Exit from the current thread.

("bogus stack frame")

The editor window goes away but it seems not to shutdown properly.

Remark: closing lem using "close" / the X symbol of the McClim window kills the lem process as expected.


Is there an option to hide version messages whenever there is a change?

Every time there is a change, a version message is always displayed. is there a way to hide it?
Message to hide
Using ts-node version 8.10.2, typescript version 3.9.7
Screenshot

Right, made shown only on the first start.

Right, made shown only on the first start.

Sorry, but why does this message appear every time a file is changed? (I use --respawn option)

Did you updated to the latest?

Did you updated to the latest?

Oh the problem is fixed in 1.0.0-pre.58 version. Thank you very much.


Implement Local-First

We address the local-first mechanic through ServiceWorker
Description

When user accesses one of the pages, we will install a ServiceWorker. At the same time, the worker will actively try to cache all necessary links - including other html pages, all internal scripts, all vendor scripts (e.g. markdown renderer and nanostores), and css files. In this way, when user wants to navigate to other pages it'll pull straight from the worker so user will be able to freely use the journal app even without internet connection (the initial request requires internet connectivity, of course)
Related Issue
Closes #13

How Has This Been Tested?

Launch test server
Go to any of HTML pages
Check installed service worker, and see requests that were being sent from the service worker
Refresh the page, you can see the html pages, scripts, and css styles have been cached by the ServiceWorker.

Checklist

[x] All automated tests have been passed locally (unit / e2e / linter / coverage)
[x] New unit and E2E tests have been added to address the changes made
[x] Manual testing has been performed according to the provided instructions
[x] Code follows team's coding style, convention and standards
[x] Documentation has been updated to reflect relevant changes (if applicable)

Screenshots (if applicable):

Closed as a better version is implemented in #72


ShaderMask on Web moves incorrectly with window size

Steps to Reproduce

Create a new flutter project.
Update the main.dart files as follows:
(the only change is in the build function)

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        // This is the theme of your application.
        //
        // Try running your application with "flutter run". You'll see the
        // application has a blue toolbar. Then, without quitting the app, try
        // changing the primarySwatch below to Colors.green and then invoke
        // "hot reload" (press "r" in the console where you ran "flutter run",
        // or simply save your changes to "hot reload" in a Flutter IDE).
        // Notice that the counter didn't reset back to zero; the application
        // is not restarted.
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  // This widget is the home page of your application. It is stateful, meaning
  // that it has a State object (defined below) that contains fields that affect
  // how it looks.

  // This class is the configuration for the state. It holds the values (in this
  // case the title) provided by the parent (in this case the App widget) and
  // used by the build method of the State. Fields in a Widget subclass are
  // always marked "final".

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      // This call to setState tells the Flutter framework that something has
      // changed in this State, which causes it to rerun the build method below
      // so that the display can reflect the updated values. If we changed
      // _counter without calling setState(), then the build method would not be
      // called again, and so nothing would appear to happen.
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    // This method is rerun every time setState is called, for instance as done
    // by the _incrementCounter method above.
    //
    // The Flutter framework has been optimized to make rerunning build methods
    // fast, so that you can just rebuild anything that needs updating rather
    // than having to individually change instances of widgets.
    return Scaffold(
        appBar: AppBar(
          // Here we take the value from the MyHomePage object that was created by
          // the App.build method, and use it to set our appbar title.
          title: Text(widget.title),
        ),
        body: Center(
          // Center is a layout widget. It takes a single child and positions it
          // in the middle of the parent.
          child: ShaderMask(
              blendMode: BlendMode.srcATop,
              shaderCallback: (Rect bounds) {
                return LinearGradient(
                  colors: [Colors.orange, Colors.yellow],
                ).createShader(bounds);
              },
              child: Image.asset('assets/image.jpg')),
        ) // This trailing comma makes auto-formatting nicer for build methods.
        );
  }
}

Run the code on web (incorrect output) and android (correct output)

Expected results: (Android)

Huge Picture

Actual results: (Web)

Huge Picture

Logs
flutter run --web-hostname=<IP_ADDRESS> --web-port=35734 --verbose
[  +77 ms] executing: [C:\Users\Mehul\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +76 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 2f05751973f3ddfb5462f5ff4136c573ba4f39c9
[   +1 ms] executing: [C:\Users\Mehul\flutter/] git tag --points-at 2f05751973f3ddfb5462f5ff4136c573ba4f39c9
[  +57 ms] Exit code 0 from: git tag --points-at 2f05751973f3ddfb5462f5ff4136c573ba4f39c9
[   +2 ms] executing: [C:\Users\Mehul\flutter/] git describe --match *.*.* --long --tags 2f05751973f3ddfb5462f5ff4136c573ba4f39c9
[  +76 ms] Exit code 0 from: git describe --match *.*.* --long --tags 2f05751973f3ddfb5462f5ff4136c573ba4f39c9
[   +1 ms] 2.1.0-12.0.pre-233-g2f05751973
[   +6 ms] executing: [C:\Users\Mehul\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +51 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[   +1 ms] origin/master
[        ] executing: [C:\Users\Mehul\flutter/] git ls-remote --get-url origin
[  +45 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[ +126 ms] executing: [C:\Users\Mehul\flutter/] git rev-parse --abbrev-ref HEAD
[  +49 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] master
[  +80 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +3 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +55 ms] executing: C:\Users\Mehul\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l
[  +55 ms] List of devices attached
[   +8 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +3 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +75 ms] Multiple devices found:
[  +32 ms] Chrome (web) • chrome • web-javascript • Google Chrome 89.0.4389.90
[   +2 ms] Edge (web)   • edge   • web-javascript • Microsoft Edge 89.0.774.57
[   +2 ms] [1]: Chrome (chrome)
[        ] [2]: Edge (edge)
[   +2 ms] Please choose one (To quit, press "q/Q")
[        ] :
[+1269 ms] 1
[  +12 ms] Skipping pub get: version match.
[ +105 ms] Generating C:\Users\Mehul\GithubProjects\flutter_app\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[  +69 ms] Launching lib\main.dart on Chrome in debug mode...
[  +96 ms] Updating assets
[  +74 ms] Manifest contained wildcard assets. Inserting missing file into build graph to force rerun. for more information see #56466.
[   +4 ms] Waiting for connection from debug service on Chrome...
[  +87 ms] <- reset
[   +5 ms] C:\Users\Mehul\flutter\bin\cache\dart-sdk\bin\dart.exe --disable-dart-dev C:\Users\Mehul\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root C:\Users\Mehul\flutter\bin\cache\flutter_web_sdk/ --incremental
--target=dartdevc --debugger-module-names --experimental-emit-debug-metadata -DFLUTTER_WEB_AUTO_DETECT=true --output-dill C:\Users\Mehul\AppData\Local\Temp\flutter_tools.c3fdcde9\flutter_tool.1fb946a2\app.dill --libraries-spec
file:///C:/Users/Mehul/flutter/bin/cache/flutter_web_sdk/libraries.json --packages C:\Users\Mehul\GithubProjects\flutter_app\.dart_tool\package_config.json -Ddart.vm.profile=false -Ddart.vm.product=false --enable-asserts --track-widget-creation --filesystem-root
C:\Users\Mehul\AppData\Local\Temp\flutter_tools.c3fdcde9\flutter_tools.88f622f4 --filesystem-scheme org-dartlang-app --initialize-from-dill build\c7922d95bf4a2462b75c84a97c312edb.cache.dill.track.dill --platform
file:///C:/Users/Mehul/flutter/bin/cache/flutter_web_sdk/kernel/flutter_ddc_sdk.dill --no-sound-null-safety
[  +19 ms] <- compile org-dartlang-app:/web_entrypoint.dart
[+14731 ms] Waiting for connection from debug service on Chrome... (completed in 14.8s)
[   +2 ms] Synced 29.4MB.
[   +1 ms] <- accept
[        ] Caching compiled dill
[ +312 ms] [CHROME]:
[   +2 ms] [CHROME]:DevTools listening on ws://<IP_ADDRESS>:58890/devtools/browser/84657961-864e-4f53-9769-472f954d2b37
[+1228 ms] DwdsInjector: Received request for entrypoint at http://<IP_ADDRESS>:35734/main_module.bootstrap.js
[   +5 ms] MetadataProvider: Loading debug metadata...
[  +12 ms] MetadataProvider: Loaded debug metadata (no sound null safety)
[   +6 ms] DwdsInjector: Injected debugging metadata for entrypoint at http://<IP_ADDRESS>:35734/main_module.bootstrap.js
[+5580 ms] ChromeProxyService: Initializing expression compiler for main_module.bootstrap.js with sound null safety: false
[ +388 ms] DevHandler: Debug service listening on ws://<IP_ADDRESS>:58924/NmysHaB3WBw=/ws

[   +9 ms] Debug service listening on ws://<IP_ADDRESS>:58924/NmysHaB3WBw=/ws
[        ] Running with unsound null safety
[   +1 ms] For more information see https://dart.dev/null-safety/unsound-null-safety
[   +3 ms]   To hot restart changes while running, press "r" or "R".
[   +1 ms] For a more detailed help message, press "h". To quit, press "q".

flutter analyze
Analyzing flutter_app...

   info - The value of the field '_counter' isn't used - lib\main.dart:49:7 - unused_field
   info - The declaration '_incrementCounter' isn't referenced - lib\main.dart:51:8 - unused_element

2 issues found. (ran in 1.6s)

flutter doctor -v
[√] Flutter (Channel master, 2.1.0-13.0.pre.233, on Microsoft Windows [Version 10.0.19042.867], locale en-IN)
    • Flutter version 2.1.0-13.0.pre.233 at C:\Users\Mehul\flutter
    • Framework revision 2f05751973 (57 minutes ago), 2021-03-24 02:57:01 -0700
    • Engine revision d59a01d2d3
    • Dart version 2.13.0 (build 2.13.0-150.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Mehul\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 89.0.4389.90
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 89.0.774.57

• No issues found!

I've tried this on beta as well as dev and see the exact same behaviour

Hi @Silver-Fullbuster
Thanks for filing the issue, I can reproduce the issue using canvaskit,  shadermask moves when resizing the window.

preview

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        // This is the theme of your application.
        //
        // Try running your application with "flutter run". You'll see the
        // application has a blue toolbar. Then, without quitting the app, try
        // changing the primarySwatch below to Colors.green and then invoke
        // "hot reload" (press "r" in the console where you ran "flutter run",
        // or simply save your changes to "hot reload" in a Flutter IDE).
        // Notice that the counter didn't reset back to zero; the application
        // is not restarted.
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  // This widget is the home page of your application. It is stateful, meaning
  // that it has a State object (defined below) that contains fields that affect
  // how it looks.

  // This class is the configuration for the state. It holds the values (in this
  // case the title) provided by the parent (in this case the App widget) and
  // used by the build method of the State. Fields in a Widget subclass are
  // always marked "final".

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      // This call to setState tells the Flutter framework that something has
      // changed in this State, which causes it to rerun the build method below
      // so that the display can reflect the updated values. If we changed
      // _counter without calling setState(), then the build method would not be
      // called again, and so nothing would appear to happen.
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    // This method is rerun every time setState is called, for instance as done
    // by the _incrementCounter method above.
    //
    // The Flutter framework has been optimized to make rerunning build methods
    // fast, so that you can just rebuild anything that needs updating rather
    // than having to individually change instances of widgets.
    return Scaffold(
        appBar: AppBar(
          // Here we take the value from the MyHomePage object that was created by
          // the App.build method, and use it to set our appbar title.
          title: Text(widget.title),
        ),
        body: Center(
          // Center is a layout widget. It takes a single child and positions it
          // in the middle of the parent.
          child: ShaderMask(
              blendMode: BlendMode.srcATop,
              shaderCallback: (Rect bounds) {
                return LinearGradient(
                  colors: [Colors.orange, Colors.yellow],
                ).createShader(bounds);
              },
              child: Image.asset('assets/dash.png')),
        ) // This trailing comma makes auto-formatting nicer for build methods.
        );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 2.1.0-13.0.pre.233, on macOS 11.2.3 20D91 darwin-x64, locale en-GB)
    • Flutter version 2.1.0-13.0.pre.233 at /Users/tahatesser/Code/flutter_master
    • Framework revision 2f05751973 (4 hours ago), 2021-03-24 02:57:01 -0700
    • Engine revision d59a01d2d3
    • Dart version 2.13.0 (build 2.13.0-150.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.54.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.20.0

[✓] Connected device (3 available)
    • Redmi K20 Pro (mobile) • def0ad20 • android-arm64  • Android 10 (API 29)
    • macOS (desktop)        • macos    • darwin-x64     • macOS 11.2.3 20D91 darwin-x64
    • Chrome (web)           • chrome   • web-javascript • Google Chrome 89.0.4389.90

• No issues found!

Related https://github.com/flutter/flutter/issues/44152

The HTML renderer works correctly, that's incidentally also the workaround I'm using till the issue gets fixed
Definitely, here's a GIF that shows the incorrect behaviour

GIF![KNN0U534vv](https://user-images.githubusercontent.com/22327220/113255045-fa089f80-92e4-11eb-96b4-f4b42d09522f.gif)

@yellowgraysu
Please file a new issue with all the details

@TahaTesser Ok I open a new one: #84254


[ML-44] [PIP] Rework examples for validation

What changes were proposed in this pull request?
Closes #44

Wait for oneCCL to release new 2021.2 version and retest again.


Optimize recursive expansion

I have a dataset with about 200 nodes, which is rather deep rather than flat.
With the old code, it takes around 20 seconds to 'expandAll'. With this improvement it takes less than a second.
By profiling it turns out that most of the time was spent in the `expandSomeNodes' method. This is because the method traces up to the root for every node in the tree - making it an exponential time operation.
With this change, expansion goes only once from the selected node up the tree, and from the selected node downward.

Thanks, I don't know when but at some point I'll take a detailed look at it and will see if I can integrate new solution

Sure thing. It's certainly not perfect - I was just trying to make the website I was building work with that data set. For example I don't think the call to expandParents on line 1255 is necessary. You can see it working here if you like: https://zenmarrow.com/LineageChart.html
Thank you for a wonderful js lib.

(this comment has nothing to do with the issue mentioned)
@sje397 how did you go about changing the line colours of the links? I've been looking but they all appear hardcoded. I'm looking for a way to save me having to fork and modify the code (though I'll go that route if necessary). Sorry to hijack the issue...

@dlgoodchild take a look at this issue, this is a relevant one
https://github.com/bumbeishvili/org-chart/issues/208

Thanks @bumbeishvili I just came across that and so deleted my comment/question. Typical, to come across it seconds after posting. You were pretty fast there though!

@sje397 thanks for the pointer.
I found an underlying issue and made the change.  Tested it for  500 nodes ( Hierarchy level was also linear 500 level deep). And result was instantaneous expand, so hoping it will be the same for you

It will be included in v3 version of the org chart, which I'll release soon


Clear warnings

second one requires mui update https://github.com/mui-org/material-ui/issues/19769


Setting up more than 16 Virtual Functions

I am setting up virtual functions as described in the documentation for Mellanox Connect X7 series. I want to create 24 Virtual function for the network adapter. But when try to setup the sriov_numfs param it gives out an error. I tried doing this
echo 0 > /sys/class/net/enp2s0f0/device/sriov_numvfs
echo 24 > /sys/class/net/enp2s0f0/device/sriov_numvfs
There is a maxvfs file in the same directory which has the value 16. When I try to create 16 VFS it succeeds but I am unable to edit that file as it is read-only file.
Can someone please help.
Thanks

This is not related to the sriov-network-device-plugin but please take a look on the mstconfig from MLX and see what is the max number of virtual functions the hardware supports

Thanks. Closing the issue.


The content does not match latest VS Blazor template

"Bootstrap Blazor" section describes the following for Blazor WebAssembly app,

The specific component to render is configured in the app's Startup.Configure method with a corresponding CSS selector indicating where the component should be rendered.

Sadly the latest Blazor WebAssembly template shipped with VS2019 16.7.1 no longer creates such as Startup.cs file. The logic has been incorporated into Main in Program.cs instead.
Therefore, this must be revised to avoid confusion.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f5831959-ac2f-ee91-f8c0-733901c76cf8
Version Independent ID: 6248210d-e21c-2c4c-9972-8c981c1c521b
Content: Project structure for Blazor apps
Content Source: docs/architecture/blazor-for-web-forms-developers/project-structure.md
Product: dotnet-architecture
Technology: blazor
GitHub Login: @danroth27
Microsoft Alias: daroth

Sending email to @danroth27

This content has already been updated to align with the .NET 5 version for the Blazor templates.


Easy packages for Thermo Analysis

So for lammps, the default is to read out your data to a log file with information about setting up each simulation run, and then writing out the specified thermo data for each interval (currently, I'm writing out step, temp, press, total energy, kinetic energy, potential energy, and density information). These files take a bit of parsing to grab the correct data for checking something like equilibration. Ryan DeFever has a really nice utility called Lammps Thermo that makes this process really simple.
I know gromacs has a similar package that is extremely useful Panedr.
Panedr is available on conda-forge it looks like, but Lammps Thermo has to be pip installed from a git clone. If possible, I would like to add both of these packages to the environment.yml file.

I see that panedr has been added for gromacs use. For the lammps stuff, we've managed to write out directly to more easily parsed log.txt files. So no need to add lammps thermo to the environment.yml. Closing this issue now.


once-if

Should use transclusion instead of letting child elements/directive compiled/rendered.
Had several tests, in the following situation:

both directive still get compiled even though their priority is lower. I suppose the the $element.remove() is queued after the compilation of other directives

try  once-wait-for="param1"
i wold like to ask is there option like this  once-wait-for="param1, param2, etc"?

+1
I see compiled directive child too..

Can confirm, this is still an issue. Today it works more like onceShow - but still not even quite.


Source?

Hi, interesting paper! What are your plans in open sourcing the code?

Please take a look at branches. You can find source code.


Intruptions for intent

I'm trying to allow interruption only for Particular intent how can I mention the only intent interruption
I have tried the below but it's not working

@KoradaRajesh see the Interruptions sample for correct use of Allow Interruptions. You can't specify an exact intent.

I found some intents are getting added into Luis but I didn't get those intents in the dialog folder and there are no triggers as well


[google_maps_flutter_android] Convert <PlatformTile, TileOverlay> to Pigeon

Child task of https://github.com/flutter/flutter/issues/117907
Example pull request https://github.com/flutter/packages/pull/7207
Inital code pointer
https://github.com/flutter/packages/blob/82e8d1eecb4518a28083d7c10bd677d06574f9e6/packages/google_maps_flutter/google_maps_flutter_android/pigeons/messages.dart#L33-L121

PlatformTile appears to already be typesafe. If I am not mistaken, this issue can be restricted to just updating TileOverlay.


Cherry-pick PR #7819 into release-1.1: [dep] bump generic-array to 0.12.4

This cherry-pick was triggerd by a request on #7819
Please review the diff to ensure there are not any unexpected changes.

Justification and breaking nature (who does it affect? validators, full nodes, tooling, operators, AOS, etc.)
This is not a breaking change.
generic-array v0.12.3 is one of the transitive deps and is flagged in https://rustsec.org/advisories/RUSTSEC-2020-0146.html.  The fix is back ported to v0.12.4.  List of crates are affected: diem-writeset-generator, backup-service, debug-interface, json-rpc, faucet.

Comprehensive test results that demonstrate the fix working and not breaking existing workflows.
Tests include cargo audit + CI.

Why we must have it for V1 launch.
Two reasons. One is to address the RUSTSEC.  The other is to maintain the SNR of the audit alerts so that they are actionable.

What workarounds and alternative we have if we do not push the PR.
If we don't update this transitive dep, the alternative would be to update the indirect deps or wait for their fixes; they include: headers, pest_meta.

/canary

:sunny: Canary successful

Update is not needed, after discussion with @zekun000 that arr! is not used.


Update isValidName regex to fix ISSUE-12

https://github.com/RemiRigal/Yape/issues/12
Regex was taken from https://stackoverflow.com/a/3824105

bump

Thank you for your contribution @joshuajcoronado ! Unfortunately, as the options page has been refactored this is no longer compatible with the current state of the extension. However I've taken your changes into consideration, so thanks again.


feat(chat): add attach link functionality (Issue #785)

Description:
Add attach link functionality
Issues:

Issue #785

UI changes

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review

/deploy-review

/deploy-review


[Feature-Request] Add options to avoid installing some dependencies with Hunter

Start with the why:
I am trying to integrated depthai-core in an existing C++ code base in which many dependencies (such as opencv and pcl) are managed via the conda package manager, installing packages from conda-forge. In this context, I would like to minimize the chance of packages installed by conda to conflict with packages installed via Hunter. As discussed in https://github.com/luxonis/depthai-core/issues/411, just setting HUNTER_ENABLE to OFF is not an option, as some dependencies are patched to work correctly with depthai-core, so you can't use the stock version. However, I would like to be able to use the conda version of dependencies that should work out of the box and I already used in the rest of the codebase, such as nlohmann_json, bzip2, spdlog and jsoncpp
Move to the what:
I would like to have a set of granular options to specify if hunter_add_package should be called or not for a package. Currently there is HUNTER_ENABLE to enable/disable hunter_add_package for all packages, but this can't work for the reason described in the previous section.
Move to the how:
My idea was to have options such as DEPTHAI_USE_EXTERNAL_<pkgname> for each pkgname . These variable will be mark_as_advanced and set to FALSE by default, to not interfere with existing workflow. If a given  DEPTHAI_USE_EXTERNAL_<pkgname> option will be enabled, hunter_add_package(<pkgname>) will not be called, and the "normal" find_package(<pkgname>) will be used instead.

I will be happy to work on a PR for this proposal, but I wanted first to check with maintainers if this is something you would be open to.

Hi @traversaro
Thanks for bringing this up - and yes, it is something that I do view would be beneficial.
I lean towards Hunter actually, as it seems like the best place where this would be managed (& properly propagated to subdependencies as well)
See the (original) proposal: https://github.com/cpp-pm/hunter/issues/557

I will be happy to work on a PR for this proposal, but I wanted first to check with maintainers if this is something you would be open to.

We'd be very open for this - so if its in form of Hunter, we'd gladly switch to that build of Hunter with this functionality in.

WRT the depthai-ros - there is a branch, ros-release which "locally" already makes an attempt at handling this for nlohmann_json (but note, its just change on DAI level - if there was a dependency that was still under Hunter and it relied on the disabled nlohmann json, it would still be pulled, as it doesn't propagate - which is why I brought up the change in Hunter instead)

Thanks for the quick reply! I see the point of transitive hunter dependencies, however in https://github.com/cpp-pm/hunter/issues/557 it does not seem that upstream is really interested in that feature, or to have Hunter interact with any other package manager from what I understand.
To be completely honest, I never used Hunter, so clearly for me it is tricky to estimate the effort to actually get a fully fledged feature in Hunter itself, and I am not sure I will be able to look into that in the near future. On the other side, I see why you would like to have this in Hunter and not as local options in depthai-core.

@traversaro

however in https://github.com/cpp-pm/hunter/issues/557 it does not seem that upstream is really interested in that feature, or to have Hunter interact with any other package manager from what I understand.

I don't think they'd be against it per-se. Also, it functions similarly to HUNTER_ENABLE=OFF, but specifically.
IMO the approach would be much simpler going from Hunter side than from DAI side and we can rely on this fork of Hunter directly.
Let me know if you'll happen to check it out - would be interesting for a couple of integration paths (Yocto, ROS, ...)

I don't think they'd be against it per-se.

To keep it simple I just asked it in https://github.com/cpp-pm/hunter/issues/557#issuecomment-2110378565 .

To keep it simple I just asked this to the mantainers

Even better! Thanks!

@traversaro any updates from the Hunter's side of approach? If you fork works as expected, we could potentially utilize that as well, if upstream won't be too fast on merging

Sorry for the radio silence. As mentioned in https://github.com/cpp-pm/hunter/issues/557#issuecomment-2112591832, I tried to impement the feature in way that handled corrected caching, but after spending a few hours on this, I  could not find a solution, probably also due to my limited knowledge of Hunter's internals. Instead, I quickly implemented the solution with a modification of depthai-core side, and it has been working fine (see https://github.com/traversaro/depthai-core/commit/649841af39b166f4b35f41f916e9c8d384442d7b), so I am currently using that as a local patch.


Warning of downloading cedict_ts.u8 should disappear if I have cedict_ts.u8 in my vault root.

I think this Waring should disappear if I already have cedict_ts.u8 in my vault root.

@JohnsonLee-debug
Thanks for your feedback 👍

@JohnsonLee-debug
Released in v8.0.0-beta1 🚀
If you use BRAT, please confirm it. If not, please wait to release it as official, v8.0.0.

@JohnsonLee-debug
Released in v8.0.0 🚀


Update the 404 link for NETStandard.Library source

Details
Update the link to NETStandard.Library source which is now in https://github.com/dotnet/standard/blob/master/netstandard/pkg/targets/NETStandard.Library.targets

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

The old file contained a list of packages that are part of the metapackage, which is what I think made it useful. What is the point of linking to the new file? I don't see one, so I think the link should be removed.

@svick That's a very good point.
@ericstj Can you comment on that point above? Is there a better place where the link should be re-directed?

@Nirmal4G suggested this link (https://github.com/dotnet/standard/blob/master/netstandard/pkg/NETStandard.Library.dependencies.props) on a PR that was closed this morning since I'm working on this same topic. Should that be the new target?

@mairaw That would be the correct link.
@lamLeX Do you want to update the target on this PR? If not, we'll make the edit and accept the PR with the updated target.

@svick is correct. Most of the links for NETStardard has been moved to dotnet/standard repo. Since I couldn't find the original, I thought the new link I proposed is the correct one as it has the same name.
@BillWagner: Is https://github.com/dotnet/standard/blob/master/netstandard/pkg/NETStandard.Library.dependencies.props correct? If so, I could update my target on this PR.

@lamLeX Yes, you have the correct target in the above comment. Thank you again.

Thank you for the updates.
I'll merge this as soon as the build finishes.

Thank all for helping me.
Contributing is a way I learn new thing.


feat(render): merge keybindings in UI

This PR updates the keybindings view in the "hints" section in lazy home.
Activation keys for plugins are now iterated in sorted order (by keys) and
common prefixes, if present, are shown instead of all the individual
keybindings.
Given a config like this:
return {
    {
        'rcarriga/nvim-notify',
        lazy = true,
        keys = {
            { "<leader>N",  desc = "+notifications" },
            { "<leader>Ny", "<Cmd>Notifications<CR>", desc = "history (plain)" },
            { "<leader>Nd", function() require("notify").dismiss() end, desc = "dismiss" },
            { "<leader>Np", function() require("notify").pending() end, desc = "show pending" },
        },
    },
}

The UI entry in the Not Loaded plugins now looks like this:
   ○ nvim-notify  <leader>N

instead of previously:
   ○ nvim-notify  <leader>Nd  <leader>Np  <leader>N  <leader>Ny

As a side-effect, this ensures that, even if no "common prefix" exists, keys
are always shown in sorted order.
Additional remarks
Compound keybindings
I assume that the current implementation fails when "Ctrl"-based keybindings
are mixed with anything that has "C" as a prefix, for example. I'm not sure
about the exact notation of Ctrl-/Alt-keybindings in nvim because I never use
them, but a quick test with this setup:
        keys = {
            { "<leader>C",  desc = "+notifications" },
            { "<leader>Cy", "<Cmd>Notifications<CR>", desc = "history (plain)" },
            { "<leader>C-d", function() require("notify").dismiss() end, desc = "dismiss" },
            { "<leader>Cp", function() require("notify").pending() end, desc = "show pending" },
        },

shortens the whole group to <leader>C in the UI, where it should probably
show <leader>C <leader>C-d instead. In a similar fashion, I assume that a
scenario like this fails as well:
        keys = {
            -- Plain "C" with plain "-"
            { "<leader>C-",  desc = "+notifications" },
            { "<leader>C-y", "<Cmd>Notifications<CR>", desc = "history (plain)" },
            { "<leader>C-d", function() require("notify").dismiss() end, desc = "dismiss" },
            { "<leader>C-p", function() require("notify").pending() end, desc = "show pending" },
        },

although I'm unsure whether this is a realistic scenario to consider here. Is
there something like an iterator over individual/compound keys in the raw data?
Or do I have to check whether C-? is part of a compound binding myself? If
so, do you know of any other compound bindings I should be aware of?
which-key integration
Users of which-key will probably not benefit from this change. That is
because keybinding groups must be registered in which-key directly (so the
"group"-prefix is picked up correctly), so lazy doesn't know about them. Since
keybindings can only be performed once, we cannot just "copy" the which-key
group assignment into lazy just for the UI.
I've opened a PR for which-key that solves this inconvenience, in case
you're interested.

Rebased onto latest main.

I'm not a fan of this. Thank you anyway though!


Overflow feature needed for hybrid heat pump

With the modeling of hybrid heat pumps as three nodes (see https://github.com/quintel/etengine/issues/791) we run into the following issue.
The combi-boiler part of the HHP is connected to both the collector and to the HP part as shown here:

The reason for this: when the HP part cannot fulfil its part of the demand anymore, the combi boiler should fulfil that demand.
The converters in the space heating and hot water section of the ETM are demand driven meaning that they scale their FLH to match the demand (keeping number_of_units and capacity fixed). Currently, the FLH can surpass their physical limit of 8760 hours per year without the ETM batting an eyelid. This means that the demand would never 'overflow' into the combi-boiler part of the HHP.
@antw would it be possible to make demand 'flow over' when the FLH of a converter reach 8760?
If this is difficult, we might reconsider to model the HHP as one converter but this would require both the efficiency and the inputs of carriers to depend on the demand (which sounds like more work in ETE to me).

Including @dennisschoenmakers @jorisberkhout @AlexanderWirtz

Is it time to revive the infamous 'flex_max' feature?

Is it time to revive the infamous 'flex_max' feature?

Interesting suggestion! Perhaps that is easier in the end...
Using a 'cap' on the HP edge, the situation could be described as follows:

I am not sure if we can have both the 'fixed' q_1 and _q2 and the 'overflow' happening correctly though. @antw what do you think about all this?

@antw would it be possible to make demand 'flow over' when the FLH of a converter reach 8760?

We could probably add the option to hard-limit a demand-driven converter to 8760 hours without much difficulty. Do you think that would be enough to solve the problem?

I am not sure if we can have both the 'fixed' q_1 and _q2 and the 'overflow' happening correctly though. > @antw what do you think about all this?

With flex-max, it is possible to assign a priority to edges to force one to be given preference over another. I don't think that solves the problem though as there is still the question of what to do with the overflow.

Thanks @antw for your feedback. After discussing this with @dennisschoenmakers I'm closing this issue as we decided to keep the shares fixed and ignore the 'overflow' feature for now.


Next step

Sort by priority

- [ ] write a guidance for starter
- [ ] replace vim-vsnip with its successor LuaSnip

Huge thanks for a great job on config! I love it so much!

Could you consider making it easier to configure which plugins need to be loaded always or move settings for conditional load to the top level (custom.lua or init.lua), loading gitsigns+fugitive+flog when nvim is opened is something I can't fix myself.
Also it would be nice to have all keymaps in init.lua or custom.lua, including plugin related ones so it's easier to adopt and change if necessary and it will bring more order to config.
Same goes to plugin repo's, one place to rule them all is the most straightforward and easy to adopt way of managing them.
Sorry if I misunderstood concept and use your config in a wrong way.

[ ] Replace packer with lazy.nvim (For lockfile support)
[ ] Replace "setup in init.lua" init mechanism with injection (For gitignore and project local settings)
[ ] Merge plugins key mapping/configuration
[ ] Split lspconfig setup by filetype (Rust/Scala are setup by their corresponding plugin, also deno doesn't use eslint, we need more specific control.)


Classlist add not working

timerText.classList.add("redText");
is not working and i get an error

the keydown function works
the classList also does not autocomplete

You’re using getElementsByClassname() to get the timerText
https://developer.mozilla.org/en-US/docs/Web/API/Document/getElementsByClassName
Note that that method returns an array of nodes (getElementS plural).
And there is no classList property on an array of elements.

If you see errors like this use console.log(value) to check that the value isn’t null or some other unexpected thing.

It works now thanks
youre right it returns an array


switch dspa resource not found err to debug

This will now follow the debug log level when set via zap logging options
this will avoid the spam of:
"DSPA resource was not found, assuming it was recently deleted, nothing to do here"

log messages in the info level here https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/config/base/params.env#L22
and as described here

/lgtm

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-727
An OCP cluster where you are logged in as cluster admin is required.
To use this image run the following:
cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/727/head
git checkout -b pullrequest 77421e93583b55e64cdcfbcb88b3931258645eed
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-727"

More instructions here on how to deploy and test a Data Science Pipelines Application.


inject

The problem is that this script should be executed before anything else. But as you can see in the repro project, if I'm trying to access window.config in a Plugin, I get undefined.
This is because some of the application code is run before the config.js script is injected in the .
There should be a way to run this script before anything else in the page.
Note: This issue is related to "client side only" projects (ssr: false), setting ssr: true solves this issue.
Additional context
No response
Logs
No response

This was implemented in https://github.com/nuxt/framework/pull/8975.


Edit transaction and add link in the index.html

add a page of edit_transation.js, I have tested the sign_up and edit transaction already, though I made up some data which is needed for just running the test, It worked. but still, need to find a place to implement it.
also, have changed some bit of errors in the transation.js file.

Fixed up the merge conflicts, it should now work. Pulling in the commits


Don't enforce prettier config by default in create-svelte

Describe the problem
npm create svelte creates the following prettier file:
{
	"useTabs": true,
	"singleQuote": true,
	"trailingComma": "none",
	"printWidth": 100,
	"plugins": ["prettier-plugin-svelte"],
	"overrides": [{ "files": "*.svelte", "options": { "parser": "svelte" } }]
}

Why enforce useTabs, singleQuote, trailingComma and printWidth? Prettier is designed to be opinionated and be the same across all projects. Options are there because of history, not to abuse them.

Prettier has a few options because of history. But we won’t add more of them.
- https://prettier.io/docs/en/option-philosophy

FYI, "trailingComma": "none" is a straight bad practice because it increases amount of diffs, so I would recommend removing at least that one.

Describe the proposed solution
Replace prettier config with:
{
  "plugins": ["prettier-plugin-svelte"],
  "overrides": [{ "files": "*.svelte", "options": { "parser": "svelte" } }]
}

Alternatives considered
No response
Importance
nice to have
Additional Information
No response

You can have ugly code or ugly diffs. We chose ugly diffs :shrug: I don't think I setup this prettier config, but I do agree with it. Users can change it if desired. There's nothing that we can do there that will make everyone happy. These defaults align with Svelte's coding style


Predicting: Usage of Package in Readme still up to date?

Hi, I would like to predict the model on a dataset. Here is what I tried, I thought it was supposed to work according to the readme:
x = rand(10)
y = 3*x .+1
ln = linregress(x,y)
LinearRegression.LinearRegressor{Vector{Float64}}(true, [2.9999999999999996, 0.9999999999999991])

Now I try to predict the model on a set of points:
ln(1:0.1:10)
ERROR: DimensionMismatch: first array has length 91 which does not match the length of the second, 1.
Stacktrace:
 [1] dot(x::StepRangeLen{…}, y::SubArray{…})
   @ LinearAlgebra ~/.julia/juliaup/julia-1.11.1+0.x64.linux.gnu/share/julia/stdlib/v1.11/LinearAlgebra/src/generic.jl:889
 [2] *
   @ ~/.julia/juliaup/julia-1.11.1+0.x64.linux.gnu/share/julia/stdlib/v1.11/LinearAlgebra/src/adjtrans.jl:478 [inlined]
 [3] (::LinearRegression.LinearRegressor{…})(x::StepRangeLen{…})
   @ LinearRegression ~/.julia/packages/LinearRegression/hggkt/src/linreg.jl:56
 [4] top-level scope
   @ REPL[44]:1
Some type information was truncated. Use `show(err)` to see complete types.

Is this how it is supposed to be done according to the readme or did I misunderstand it?

Hi, I have to admit I might not have thought through well enough how to use it in the scalar case (1-dimensional input) ... The code generally assumes that it's higher-dimensional input, so a matrix is interpreted as multiple covariates for multiple input points, whereas a vector is interpreted as multiple covariates for a single input point, not as a single covariate for multiple input points. To predict for multiple points, you need to pass in a matrix; in your case, an $N \times 1$ matrix. E.g. as follows:
ln(reshape(1:0.1:10, :, 1))

Okay, thanks a lot. Do you think it would make sense to support this use case?
It would only be a line of code overloading the function for vectors and I think its quite common to do linear regressions on 1D data.

The challenge is how to distinguish between "vector = a single data point with multiple covariates" and "vector = multiple data points with a single covariate each"... (e.g. KernelFunctions.jl exports ColVecs and RowVecs, but that seems too heavy a dependency for this package.) How would you suggest to support both ?


Long player names overflow poorly on user dropdown

From the forum:

when the profile name is pretty big,the name is being shown over "profile".

Probably just need some CSS to truncate that text to one line.

Do we need to truncate the name to one line, or adjust the background so as to clearly classify name from options

picture1 will be a nice option, but i am not sure as to truncating the name to one line will be the same or not

Oh yeah, we could just make it taller, duh. That would be good.

If the name scrolls on mouseover,would it be a usability problem?

Scrolls on mouseover? Not sure what that would look like; I'd have to see it.


The hyperswarm js library cannot find the other nodes in a nixos test.

Describe the bug
The hyperswarm js library cannot find the other nodes in a nixos test.
To Reproduce
Steps to reproduce the behavior:

git clone https://github.com/pasqui23/hackerchat
nix-build test.nix -A t.driver
./result/bin/nixos-run-vms
In the qemu terminals spawned run hackerchat

Expected behavior
In each terminal hackerchat,using hyperswarm,would find the other nodes and print
✅  Your network is hole-punchable!
🎉 new friend 0!

Screenshots

Additional context
hyperswarm is a node.js library to build p2p applications and hackerchat is a trivial chat app built on top.
To note that npx hackerchat work normally with a true NixOS laptop connected to the internet.
Also pinging to the other vms works with the ip address inserted manually
Metadata

system: "x86_64-linux"
host os: Linux 5.5.13, NixOS, 20.09pre218613.ae6bdcc5358 (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.4pre20200220_4a4521f
channels(root): "nixos-20.09pre218613.ae6bdcc5358, home-manager"
channels(paki): ""
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/the-hyperswarm-js-library-cannot-find-the-other-nodes-in-a-nixos-test/6617/1

Of note that adding a node with coturn enabled in the network still does not work
https://nixos.org/nixos/options.html#coturn.enable

Did you open up the firewall on your nodes? Looking at the source code hackerchat requires port 31337 to be open.

Still relevant.In fact I encounter the same problem with hyperswarm-web

Cannot check this again


Add become: yes to server.yml example in README.md (closes MWDelaney/trellis-backup#1)

Add become: yes to server.yml example in README.md.
Closes #1 .

Wait, is this deprecated in favor of https://github.com/guilro/trellis-backup-role?


Error in the code

I am getting the following error !!!
/data/anaconda3/lib/libicui18n.so.58: undefined reference to<EMAIL_ADDRESS>/data/anaconda3/lib/libicui18n.so.58: undefined reference to `operator delete(void*, unsigned<EMAIL_ADDRESS>collect2: error: ld returned 1 exit status
make[3]: *** [example] Error 1
make[3]: Leaving directory `/data/yaser/yaser_testing/cpp_code/edge-drawing/build'
make[2]: *** [CMakeFiles/example.dir/all] Error 2
make[2]: Leaving directory `/data/yaser/yaser_testing/cpp_code/edge-drawing/build'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/data/yaser/yaser_testing/cpp_code/edge-drawing/build'
make: *** [all] Error 2

Thanks in advance !!!

This error should come from compiler, please refer to https://github.com/ContinuumIO/anaconda-issues/issues/5191


Wrap signalfxagent receiver config validation errors

More details: https://github.com/signalfx/splunk-otel-collector/pull/151#discussion_r591589886

Closing as inactive.


Adding "Show Next Statement" (as in classic Visual Studio) to Debug toolbar

I'm starting to develop (C++) with VSCode on Linux, having long time experience with "classic" Visual Studio.

VSCode Debug toolbar is very similar to standard VS one, but, in my opinion, one mandatory button is missed there: this is "Show Next Statement".
I see, that exactly this feature was already suggested, but for some strange reason ("not in scope of the project") was closed:
https://github.com/Microsoft/vscode/issues/4993
Really, when you debug complicated code, you are walking along the file (with breakpoint) and between different files. And ability to return to the breakpoint location is very helpful !

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Modify test_learn_all to test all registered recommenders.

Fix config_class declaration position.
Test all registered recommender class.

Codecov Report

Merging #78 (dbf1b05) into main (66804e5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   95.36%   95.38%   +0.02%
==========================================
  Files          68       68
  Lines        3558     3557       -1
==========================================
  Hits         3393     3393
+ Misses        165      164       -1


"The page isn’t redirecting properly" when searching on DDG

Description

Using the extension breaks duckduckgo.com, resulting in "The page isn’t redirecting properly" on every search.
When disabling the extension the search works as normal.
Steps to Reproduce

Have DuckDuckGo Privacy Essentials enabled
Search on duckduckgo.com

Expected behavior:
Showing search results
Actual behavior:
Error messsage:
The page isn’t redirecting properly

LibreWolf has detected that the server is redirecting the request for this address in a way that will never complete.

This problem can sometimes be caused by disabling or refusing to accept cookies.

Versions

Extension: 2023.9.1
Browser: LibreWolf 117.0.1-1
OS: Linux

Additional Information

Extension debugging console screenshot when searching on ddg:

Experiencing the same issue in Firefox 117.0.1 on Windows 11.

Same here. Your extension breaks using your own search...

Thanks for bringing this to our attention. This is a conflict with some Adblocking extensions, which are trying to remove a URL parameter that our extension adds to search queries. The rule in question is in the "Adguard URL Tracking protection" filter list, and they have already updated their list to remove the entry: https://github.com/AdguardTeam/AdguardFilters/issues/161751#issuecomment-1732554154. That comment contains a workaround to fix the problem with your adblocker until the updated filter list is available.


[FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner

What is the purpose of the change
In CheckpointBarrierUnaligner#processCancellationBarrier and CheckpointBarrierUnaligner#processEndOfPartition, we only considered the pending checkpoint triggered by #processBarrier from task thread to abort it.
Actually the checkpoint might also be triggered by #notifyBarrierReceived from netty thread in race condition, so we should also handle properly to abort it.
Brief change log

Refactor to rename CheckpointBarrierUnaligner#releaseBlocksAndResetBarriers
Fix the process of CheckpointBarrierUnaligner#processEndOfPartition to abort checkpoint properly
Fix the process of CheckpointBarrierUnaligner#processCancellationBarrier to abort checkpoint properly

Verifying this change

Added new unit test CheckpointBarrierUnalignerTest#testProcessCancellationBarrierWitchPendingCheckpoint
Added new unit test CheckpointBarrierUnalignerTest#testProcessCancellationBarrierWitchPendingCheckpoint2
Added new unit test CheckpointBarrierUnalignerTest#testEndOfStreamWithPendingCheckpoint

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks for review @pnowojski ! I appended two hotfix commits and a fixup commit for solving the issue of AlternatingCheckpointBarrierHandler. We can further discuss the other issues then.

@flinkbot run azure

FYI: Actually I also planned to get ride of ThreadSafeUnaligner#storeNewBuffers variable after refactoring the related processes a bit in this PR. Since the semantic of this state is hard to understand and we can also get ride of numberOfInputChannelsPerGate argument to simplify this class as a result.
It is almost done on my local but brought some unexpected other failures, i am not sure whether have time to further focus on it. Let's see then.

@flinkbot run azure

Thanks for the review @AHeise .
I have arranged the commit messages for the final version. Could you double check whether there are any pending concerns now?

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure


markup5ever aborts in build.rs

Repro:
git clone https://github.com/servo/html5ever --depth 1 && \
    cd html5ever/markup5ever && \
    cargo_cf build

It seems to crash in write_to(&mut generated) (grep it) when string cache string-cache calls AtomType::to_tokens in the body of write_to.
I don't know how to get the backtrace since it just aborts.
It works correctly with normal cargo.

Thanks for the issue. Markup5ever uses proc_macro2 in it's build script, which tries to detect if it s running inside a proc macro or not by invoking a function that panics when not run inside a proc macro. cg_clif doesn't support catching panics and thus aborts. This should have been fixed in https://github.com/dtolnay/proc-macro2/pull/300, but it seems that I made a mistake with the #[cfg]. Opened https://github.com/dtolnay/proc-macro2/pull/303 with a confirmed fix.
Duplicate of https://github.com/bjorn3/rustc_codegen_cranelift/issues/1101

This should be fixed now as of proc-macro 1.0.33.


admin-bro-blog submodule not found

The
git clone --recurse-submodules https://github.com/SoftwareBrothers/admin-bro-dev

command in the docs currently fails because the admin-bro-dev submodule no longer exists:
Cloning into '/home/anthony/dev/law-compare/admin-bro-dev/admin-bro-blog'...
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:SoftwareBrothers/admin-bro-blog.git' into submodule path '/home/anthony/dev/law-compare/admin-bro-dev/admin-bro-blog' failed
Failed to clone 'admin-bro-blog' a second time, aborting

Blog is our private repository currently. @ariansobczak-rst has recently updated this repository, could you try to set it up now? If you're still having issues please reopen.


hot_spring

Hi,
According to the wiki : https://wiki.openstreetmap.org/wiki/Tag:natural%3Dhot_spring, a hot spring may be on a node or on an area : the picture on the right shows for example the hot_spring lake of Grand Prismatic in Yellowstone National Park.
But in iD, when we add the tags natural=hot_spring to an area, we have a warning message saying that this tag is only for nodes.
Could you fix that ?
Best regards

This seems to have been changed from area to point in https://github.com/openstreetmap/iD/commit/1c3928160f68734aedadf977b723c833e8b19791
(perhaps by mistake, as the wiki page has had both since it was created.)

Thanks for your work
Best regards


vicon computer's ip/hostname

What is vicon computer? How to get the IP address of vicon computer？

Go to the host device network settings. You should be able to find it there.


Disable ledger state option

https://github.com/input-output-hk/cardano-db-sync/issues/905
Still requires testing and documentation
Also ports Add option to disable cache from a previous pr to avoid conflicts.

This was superceded by another PR.


IEventNotifier [Bug]

I have return type of method string and making exception:
Exception MSG:
An exception of type 'System.InvalidOperationException' occurred in System.Core.dll but was not handled in user code

Additional information: Sequence contains no elements
File: DefaultOrchardEventNotifier
Method: GetGenericMethod
Parameters:
Type = {Name = "Enumerable" FullName = "System.Linq.Enumerable"}
name = OfType
genericArgTypes = {System.Type[0]}
argTypes[1] = {Name = "IEnumerable" FullName = "System.Collections.IEnumerable"} at 0 index
returnType = {Name = "IEnumerable1" FullName = "System.Collections.Generic.IEnumerable1"}

Werid.... Im am going to swap out the DI to make things a bit easier, so the events module might change slightly


List extension mismatches

List all extension mismatches found in a file.
Figure out a way to do this nicely.

I think that we're doing about all we can right now for extension mismatches.


Separate manual tests from CI tests

Problem

Manual tests should not be triggered by CI.

Change overview

Creates a separate list in chip-tool for manual tests.
Generates ZAP code.

Testing

Generated code
Compiled code
Ran chip-tool tests list
Ran chip-tool tests list-manual

/rebase

Fast tracking testing improvements.


Add opts.Env to proc.Environment for task runner.

This should fix the issue we have with the terminal width environment
var not being forwarded / set.
Although I have not tested yet.
modified:   runner.go

@hamiltop this PR crashes, could you help me form a valid fix? Here are some references.

https://github.com/remind101/empire/blob/internal-v2/runner.go#L22-L67
https://github.com/remind101/empire/blob/master/runner.go#L72-L82


Add descriptive error messages for when parentheses are omitted on decorators

fixes #1359

Checklist:

[x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[ ] Add or update relevant docs, in the docs folder and in code.
[x] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[ ] Add .. versionchanged:: entries in any relevant code docs.
[x] Run pre-commit hooks and fix any issues.
[x] Run pytest and tox, no tests failed.

Maintainers, I'm not sure if this change needs any docs updates?

Wouldn't it be better if the decorators were smart enough to work even without parentheses, ie if there's exactly one positional argument and that argument is a callable, assume it's the decorated function...

I go back and forth on that pattern. Right now I'm on the side of "there should be one way to do things". Even if we can detect it, better to tell everyone to do something consistently. I'd have to look at the mypy docs, but I have a feeling the "decorator or factory" pattern makes typing more complicated too.

I know pytest does it for example, but no idea if they use type hints..

https://github.com/pytest-dev/pytest/blob/main/src/_pytest/fixtures.py#L1239-L1272

@angus-lherrou if you're up for it, want to implement this dual option instead of showing an error? If not, we can merge this then make another issue about supporting plain decorators.

My first thought was actually the same, but I spent some time trying to implement the optional parentheses and it just wasn't working the way I was hoping it would. I can take a look at how pytest implements it and take another crack at it.

@davidism I figured it out! When I tried before I didn't realize that I needed to call the inner function before returning it if the decorator isn't called at the invocation site.

I suppose it would be good to add this new capability in the documentation somewhere