Replace v1 e2e_mixer make target with v2

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ostromart
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: baodongli
Assign the PR to them by writing /assign @baodongli in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ostromart: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
17ab9ab2da2b026d4766420570301efa799f34bf
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
17ab9ab2da2b026d4766420570301efa799f34bf
link
/test istio-unit-tests

prow/istio-presubmit.sh
17ab9ab2da2b026d4766420570301efa799f34bf
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Fixes https://github.com/istio/istio/issues/6372.

/retest

/test e2e-suite-rbac-no_auth
/test e2e-suite-rbac-auth
/test e2e-cluster_wide-auth

@ostromart: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-simple

prow/e2e-suite-rbac-auth.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-suite-rbac-no_auth
/test e2e-suite-rbac-auth
/test e2e-cluster_wide-auth

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-simple

prow/e2e-suite-rbac-auth.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-cluster_wide-auth

prow/istio-pilot-e2e.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-suite-rbac-no_auth
/test e2e-suite-rbac-auth
/test e2e-cluster_wide-auth

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-suite-rbac-no_auth

prow/e2e-cluster_wide-auth.sh
a8af4c42c58d1dd6456a062efb7f0cb3e3bba4c2
link
/test e2e-cluster_wide-auth

prow/istio-pilot-e2e.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-simple

prow/e2e-suite-rbac-auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-simple

prow/e2e-suite-rbac-auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-suite-rbac-auth

prow/e2e-cluster_wide-auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-simple

prow/e2e-suite-rbac-auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-suite-rbac-auth

prow/e2e-cluster_wide-auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-suite-rbac-no_auth

prow/istio-pilot-e2e.sh
9375ac4ed2709dd47435fae101bbd35ef9b48272
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-simple

prow/e2e-suite-rbac-auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-suite-rbac-auth

prow/e2e-cluster_wide-auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-suite-rbac-no_auth

prow/istio-pilot-e2e.sh
9375ac4ed2709dd47435fae101bbd35ef9b48272
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
9375ac4ed2709dd47435fae101bbd35ef9b48272
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-suite-rbac-auth

prow/e2e-cluster_wide-auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-suite-rbac-no_auth

prow/istio-pilot-e2e.sh
9375ac4ed2709dd47435fae101bbd35ef9b48272
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
9375ac4ed2709dd47435fae101bbd35ef9b48272
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
9375ac4ed2709dd47435fae101bbd35ef9b48272
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hklai, ostromart
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [hklai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-suite-rbac-auth

prow/e2e-cluster_wide-auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-suite-rbac-no_auth

prow/e2e-bookInfoTests.sh
9375ac4ed2709dd47435fae101bbd35ef9b48272
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
9375ac4ed2709dd47435fae101bbd35ef9b48272
link
/test e2e-simple

prow/istio-pilot-e2e.sh
9375ac4ed2709dd47435fae101bbd35ef9b48272
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-suite-rbac-auth

prow/e2e-cluster_wide-auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
171bd242b22d4e777bb6cb6dc6e59e6669f43bb6
link
/test e2e-suite-rbac-no_auth

prow/e2e-simpleTests.sh
9375ac4ed2709dd47435fae101bbd35ef9b48272
link
/test e2e-simple

prow/istio-pilot-e2e.sh
9375ac4ed2709dd47435fae101bbd35ef9b48272
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
9375ac4ed2709dd47435fae101bbd35ef9b48272
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


options definition added to callApi() method

ReqParams type was missing "options" field.

@erayalakese Thanks for the support.


kminion_end_to_end_messages_acked_total not reported

kminion_end_to_end_commits_total
kminion_end_to_end_messages_acked_total
kminion_end_to_end_commit_latency_seconds_bucket
I see these metrics in the docs, but I don't think it's reported but it's not reported when I run kminion. Can someone confirm?

I see the first is actually...
kminion_end_to_end_offset_commits_total, but is not reflected as this in the docs..


fix the main song div size

the centered div is not fixed. it is changing as per the song's name. so that the previous, next, and play/pause button is not in a fixed position.

fix this one.

Hi @samratghosh291  ,
Is it possible to assign this issue to me? I believe I can help in addressing the problem and working towards a solution.
Looking forward to your response.
Best regards,
Ezhill Ragesh

I have fixed this issue in my recent PR #58 .

@ezhillragesh  i happy to see your interest.
But we have been assigning the issues on first come first serve basis.
So it is not possible to assign you in this issue but you can raise another new issue and asking for assigning you.
Thank you.


Very different values with WES data

Hello,
I tried to use seGMM on WES data mapped on hg19. Capture kit is Twist (www.twistbioscience.com)
The values obtained with seGMM are very different from the reference file 1000G.WES.txt.
The sex determination does not work as seGMM reports only female with X. Example:
sample_A900      0.180791        0.0252986       0.00143012      17.6898 0.12    Female  X
One possibility would be to create a new reference file based on many samples.
How many samples would be required to generate a new reference file?
The other possibility is that the values are not correct.
Could you please comment about this?
Thank you
sampleid	XH	Xmap	Ymap	XYratio	SRY
sample_A561	0.551688	0.0480034	0.000174466	275.145	0.02
sample_A573	0.579632	0.047957	0.000159149	301.334	0.02
sample_A640	0.162483	0.0249835	0.00145839	17.1309	0.15
sample_A641	0.603061	0.0475572	0.000179481	264.971	0.02
sample_A642	0.178988	0.0249668	0.00149554	16.6942	0.15
sample_A644	0.175031	0.0247872	0.00150849	16.4318	0.16
sample_A648	0.184823	0.0248933	0.00151391	16.4431	0.14
sample_A656	0.141264	0.0248336	0.00148154	16.762	0.14
sample_A657	0.698686	0.047548	0.000157188	302.491	0.01
sample_A658	0.176712	0.024932	0.00149047	16.7276	0.14
sample_A659	0.168956	0.0289115	0.00210318	13.7466	0.18
sample_A669	0.186164	0.0250368	0.00134935	18.5547	0.13
sample_A676	0.713023	0.0475422	0.000169815	279.965	0.02
sample_A680	0.602988	0.0475499	0.000165187	287.855	0.01

Hi,
In seGMM paper, the 1000G WES data were downloaded from http://ftp.1000genomes.ebi.ac.uk/vol1/ftp/phase3/data/. You can find a summary .index file which included the path stored the exome data in http://ftp.1000genomes.ebi.ac.uk/vol1/ftp/phase3/20130502.phase3.exome.alignment.index.  We collected the Xmap, Ymap, XYratio and SRY features from the downloaded bam files.
By the way, for the 1000 exon data, they used a union of two different pull-down lists: NimbleGen EZ_exome v1 and Agilent sure select v2. The targets of these data can be found in ftp://ftp.1000genomes.ebi.ac.uk/vol1/ftp/technical/reference/exome_pull_down_targets/20130108.exome.targets.bed.  To calculated XH, we download the ALL.chrX.phase3_shapeit2_mvncall_integrated_v5a.20130502.genotypes.vcf.gz and extracted SNPs located in the targeted regions in X chromosome.
I see that the XH and SRY values are varied between the 1000G.WES.txt and your data.  The difference in XH value may due to differences in data processing methods. But the SRY value looks strange. I would ask are all the samples you included female?
If you want to generate a new reference file, I suggest you should have at least 100 samples. And the ratio of male to female samples in the reference file should ideally be balanced.
Also, it looks like the features can clearly separate female and male samples in your data. I recommend that you can run seGMM without include reference data.
Thanks!

Thanks for your reply.
Following your comment about the SRY, I checked the files:

mosdepth.summary.txt

chrom   length  bases   mean    min     max
Y       59373566        6682845 0.11    0       1035
Y_region        614     31604   51.47   0       72
total   59373566        6682845 0.11    0       1035
total_region    614     31604   51.47   0       72

SRY.txt

Sample   0.11

Should it be the Y_region  that is extracted from mosdepth.summary.txt?

Yes! We have fixed this bug in the newest version of seGMM.
Please update seGMM through conda or PIP.
Thanks

Still the same problem with mosdepth.summary.txt
Looking at the commits, I could not find where and when the code was modified.
(I don't use pip/conda for seGMM)

We have updated the main.py file and seGMM.r file in the GitHub page. Please find the modified code.
Thanks!


Add a way to observe getCart

I'd like a way to observe & be able to modify the cart after getCart call, in my case, in order to inject a custom discount.

Looks good, any chance you'd also be able to update https://github.com/concrete5-community-store/community_store_event_example with this new event?
And maybe the doco?  https://github.com/concrete5-community-store/community_store/blob/master/docs/developers/events.md


MarkDownFile not accepting absolute file path anymore

Describe the bug
With "Modify tests to fix flakiness" MarkDownFile.init() has been modified to use os.getcwd() as base directory.
This makes it impossible to specify an absolute path via MdUtils.create_md_file().
To Reproduce
md_file = mdutils.MdUtils(file_name="<absolute file path>", title="My title")
md_file.create_md_file()

leads to
FileNotFoundError: [Errno 2] No such file or directory: '<current directory>/<absolute file path>'

Expected behavior
MD file is created with given absolute file_name.
Desktop (please complete the following information):

OS: Ubuntu
Version 22.04

Thanks for reporting the issue I'll check for the problem, I recommend to downgrade to 1.4.0 version.

I got the same issue. Downgrading to 1.4.0 solves this temporarily.


Regex replace with New-line (\n) or Tab (\t)

Cannot regex replace with new-line (\n) or tab (\t).
Example:

Apple, Orange, Melon

Search: ,
Replace with: \n\t$&

Has there been any more work on this issue? I'm trying to choose an editor for my students to use and the ability to search/replace across multiple lines is a make-or-break deal for me. Any workarounds?

@brentonstrine brackets still can't do that. try atom or sublime text instead.

@fibric I actually came to Brackets because sublime was too expensive for students and Atom is too buggy (I get error messages and crashes constantly). The search/replace functionality on Atom is not very good right now, but it's better than Brackets at this point. It seems pretty inexcusable for a text editor to have terrible search/replace when it comes to multiple lines or multiple files.

@brentonstrine http://limetext.org/

Cool looking project, definitely not ready for beginners yet though. I'll follow it with interest, thanks.

+1

There is a PR https://github.com/adobe/brackets/pull/11614

Any updates ?

I need to replace a deliminator with a line break! lets get this going!

+1

+1

+1

+1

+1

"grep" it is

+1

+1

+1

+1

+1

+1

+1 !!!!!

It's funny that @mqklin is downvoting every commenter without providing any argument...

I'm going to lock this discussion soon if there will be more +1 comments.
They add only noise and they create notifications for all people subscribed to this issue.
Please, use the github reactions on the first comment.

@mqklin I added my +1 comment at a time when GitHub did not have reactions on comments. Then they added reactions, and I gave my thumbs-up too. Your thumbs-down is unnecessary.
@ficristo I think an update or discussion of the feature would be warranted, this has been sitting around for a long time and it's a pretty basic feature in a lot of editors.

@awwright I totally agree this is a foundamental feature.
As I mentioned before, https://github.com/adobe/brackets/pull/11614 should fix this issue, but I think having https://github.com/adobe/brackets/pull/13152 would make more sense.
I don't know the status of that nor what are, in general, the priorities of Adobe.
The only advice I can really give you is to switch to another editor. Personally, for the little I used, I like VSCode.

@valioDOTch

It's funny that @mqklin is downvoting every commenter without providing any argument...
That's incurable

As for \n \t \r like in Nodepad++, neither VCode, nor Brackets, and Sublime could beat it.

How can they call it self a code edit if these simple commands \n \r \ t and many others dont work or are not available in search/find/replace???

I have been using TextPad & Notepad++ for a long time and I think it should be a basic feature for a powerful editor. This thread is started in 2014 and still in 2017, it's not supported. :(

+1

I gave Brackets a fair shot but the lack of this feature is unbearable.  Back to sublime I guess.

I agree with @gregmcinnes
Brackets is unsuitable for any experienced developer.
Just move on to something else.
Unsubscribing from this 3 year old thread.

Uninstall('Brackets');

This is pretty basic.  Leaving Brackets for an editor that works better.....

I also uninstalled brackets on mac, I installed VS Code instead. You can replace with /n with regex search.
In windows I used to use NotePad++, but VS Code is superior to everything and open source/free.

how in the world is this still an outstanding issue?

5 years now, wow

This is a serious request for Mac users which are working with larger text files for formating/parsing

Bye bye brackets

It should be noted that escapable chars in general should be considered where possible (like \r or rarer chars).
maybe a backslash should always be interpreted as start of an escape in the replacement field, too, not just the search field.
Because consistency is good.
And here's hoping something is going to happen at all. 🤞

Welcome to 2020. I was loving this over Sublime Text until I tried to do a mass replace for line breaks... How is this not a thing?!

Moving from Brackets back to Visual Studio Code... This issue is 6 years old.

I really loved Brackets.. had to uninstall this just because this feature is not present :(

I tried Brackets because it was recommended as an alternative to Notepad++ on the Mac, specifically because I needed to find and replace a string with an added newline.  Brackets is not an alternative to Notepad++ without this feature.  I am uninstalling Brackets now.  Installing it was a waste of time.  Sorry to go.

There is a really easy way to do this in Brackets that I don't see mentioned here.  Use "Find and select" in the "Find" menu to find whatever your delimiter is.  Then you'll have all of them selected at once, so just press enter to replace them all with a newline.  Then just press escape to exit multi-cursor mode and go back to normal editing.

@pabrown1975...  Yes, that will work in that one specific instance.  But the lacking functionality that the rest of us are complaining about is that a newline '\n' cannot be included as part of the 'Find' string.  I need to match a string including a newline and replace it with a string that may or may not also include a newline, like I could in Notepad++ in Windows.  I have moved on to Sublime Text on the Mac.  Works fine.

Seems related to https://github.com/adobe/brackets/issues/5499
Strange how you cannot replace the text "\n" or "\n\t" with actual carriage returns or tab characters.

After 6 Yeahrs, please, change this issue to high priority.
I my opinion a must have and deal braker functionality.
Meanwhile any other dev-editor included this basic feature.

6 long years, and this issue is still lying there..
Unbelievable !!
This is definitly a deal breaker for me. Need to find an alternative to Brackets now..

I recommend the editor with the name "sublime"
On Wed, Nov 4, 2020, 10:48 PM raghubedi2004<EMAIL_ADDRESS>wrote:

6 long years, and this issue is still lying there..
Unbelievable !!
This is definitly a deal breaker for me. Need to find an alternative to
Brackets now..
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/adobe/brackets/issues/8093#issuecomment-722139134,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABOBXGBVKU5DMY2FCOESRKDSOIVCJANCNFSM4AQKTIRQ
.

Will this be fixed?

Will this be fixed?

This issue still exists now in 2021.
It is impossible to use a regex replacement and have the replace be a newline, as given in the example at the top of this thread.
Is there a particular reason this issue is difficult to tackle? Why would a newline be different from any other character in a text file?

This issue still exists now in 2021.
It is impossible to use a regex replacement and have the replace be a newline, as given in the example at the top of this thread.
Is there a particular reason this issue is difficult to tackle? Why would a newline be different from any other character in a text file?

Sad to see this limitation :(

On September 1, 2021, Adobe will end support for Brackets. If you would like to continue using, maintaining, and improving Brackets, you may fork the project on GitHub. Through Adobe’s partnership with Microsoft, we encourage users to migrate to Visual Studio Code, Microsoft’s free code editor built on open source. (http://brackets.io/)


Drop support for VTK v8

PyVista v0.39.0 will be released by 1 May and will drop support for VTK v8. We have one minor change to make to be compatible with the to-be-released package.

Such a nice number for a PR.

Interestingly, I think we have been fooled by the cache action:
https://github.com/pyansys/pymapdl/actions/runs/4742338804/jobs/8420894534?pr=1995#step:13:14502


Creating RAG Database

Describe the bug
When the RAG database is created, it does not connect to the system. First, the front end needs to switch between the databases a few time before the new one can be used.
Expected behavior
The new RAG database should be connected and searchable immediately upon creation
Additional context
I wonder if this is related at all to the pop up that appears from the browser to show that the system has had the DB changed

Solution Need to wait a few seconds for the database to be set. Just go slowly


Compass calibration & tilt compensation

Compass data is hard iron calibrated.
Soft iron calibration still to do.
Tilt compensation seems to work now

Tilt compensation seems to work.
Soft iron calibration not needed for now.


Creating dialogflow follow-up intent doesn't create context

Environment details

OS: macOS High Sierra (10.13.6)
Java version: 8
google-cloud-java version(s): google-cloud-dialogflow 0.67.0-alpha

Steps to reproduce

Create an intent through the api
Create a follow-up intent with the previous intent as a parent i.e using builder.setParentFollowupIntentName

External references such as API reference guides used
Have not seen a guide showing how to create follow-up intents via the API
Any additional information below
I may not be understanding how follow-up intents are intended to work through the API. When creating a follow-up intent through the API - the UI shows the correct relationship:

However, the output and input context fields are empty for both the parent and child. Creating a follow-up through the UI automatically establishes this context, but the API does not.
The image above was produced by creating 2 intents, and calling intentBuilder.setParentFollowupIntentName(parentName) on the second intent during creation.
Is this a bug? Is extra information in the request required to establish the context for both?
Many thanks for the library and help 😄

I was able to sort the issue. Maybe some documentation would help (I would be happy to aid in this endeavor if I'm pointed in the right direction 😄 ).
I did not realize that a context name can have a session id of - when adding an output context to an intent creation.
After adding output and input context names that have a session id of - everything seems to be working correctly. If it is helpful to anyone else that may stumble upon this - using ContextName.of(project-id, "-", "my-context-id") resolves the issue.


Javscript error Foundation 6.4 (MVC)

Hello,
I've added foundation 6.4 to my mvc application. I've deleted bootstrap and change the _layout.cshtml (menu) to a foundation menu. Some of the style component are loaded, but not the one initiated with js.
When I inspect the site I see this error:
foundation.js:11621 Uncaught TypeError: WEBPACK_IMPORTED_MODULE_1__home_deployer_sites_node_foundation_customizer_node_foundation_customizer_foundation_sites_js_foundation_core.a.addToJQuery is not a function
at Object. (foundation.js:11621)
at webpack_require (foundation.js:20)
at module.exports (foundation.js:66)
at foundation.js:69
(anonymous)	@	foundation.js:11621
webpack_require	@	foundation.js:20
module.exports	@	foundation.js:66
(anonymous)	@	foundation.js:69
How to reproduce this bug:

Create MVC application in Visual studio (not core)
Add the foundation files to the BundleConfig.cs
change _Layout.cshtml to foundation menu
Include Jquery in the head of _Layout.cshtml
run the code

What should happen:
Foundation style should be applied
What happened instead:
Jquery Error and style is not fully loaded
Browser(s) and Device(s) tested on:
Chrome, Windows 10
Foundation Version(s) you are using:
6.4.0 zip from the site with js and css files
Test case link:
https://github.com/ferronsw/FoundationMVC

Hi @ferronsw, thanks for the report!
I think this is related to a bug that was fixed in the 6.4.1 patch release that went out last Friday. I realized upon your filing the report that the downloader had not been updated properly, so I just updated it - can you try redownloading with Foundation 6.4.1 and see if the error persists?

Hi @kball,
I've found the 6.4.1 version on cdnjs, but i'm glad it's now also available on the site.
Thanks for the information!
p.s. 6.4.1 fixed the problem.

Excellent, thanks for following up @ferronsw


Fix leak/exception and links becoming bricked within the terminal

This PR fixes the long standing issue where links suddenly break in the terminal (#184046) as well as a few leak issues, one of which could trigger an exception which would likely cause other problems.
I reproduced the primary issue by using the following code on the exthost side to simulate an extension registering and disposing a single link provider:
let i = 0;
setInterval(() => {
	const id = ++i;
	console.log(`LINKS: register new (${id})`);
	const d = this.registerLinkProvider({
		handleTerminalLink(link) {
			return null!;
		},
		provideTerminalLinks(context, token) {
			return [];
		},
	});
	setTimeout(() => {
		console.log(`LINKS: dispose old (${id})`);
		d.dispose();
	}, 5000);
}, 10000);

This is why the issue was so hard to reproduce in OSS since it happened when extensions did something that was somewhat unexpected. After putting this in place it became clear that the problem was related to the clunky re-creation of TerminalLinkManager when the extension host disposes of all of its link providers here:
https://github.com/microsoft/vscode/blob/ef40932ae9d63f86aa6e863f59921797a7e7f73e/src/vs/workbench/contrib/terminalContrib/links/browser/terminal.links.contribution.ts#L73-L76
Going deeper I found that xterm.js is holding onto disposed link adapters that were registered here:
https://github.com/microsoft/vscode/blob/ef40932ae9d63f86aa6e863f59921797a7e7f73e/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkManager.ts#L351
https://github.com/microsoft/vscode/blob/ef40932ae9d63f86aa6e863f59921797a7e7f73e/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkManager.ts#L360
So that fix was a matter of correctly disposing them when the link manager was replaced.
The TerminalLinkManager disposal is still in place and I noticed that when that happens it causes links to disappear, so it could be related to another issue where link underlines flicker. This is deferred though as this PR is complicated enough and that would need a new upstream API.
Fixes #184046
Fixes #203437

ughhhh thank you!!!


Convert KgNodeSearchResultsPage to use mui-datatables

Currently getting a 400 error when trying to page, bad GraphQL query.
Needs to be integration tested.
Please look at BenchmarkSubmissionsPage for an example of MuiTables with pagination. Note the comment about loading within the MuiTables render. You don't want to reload the whole frame and then do MuiTables. That may require some refactoring to work with the history stuff.


Don't install application for pep8 test

Coverage remained the same at 48.02% when pulling 1fd9d5d37cd753a8b7a7071e01438191f8c6cc74 on skip_install into 3e9e3386193d6a19831e2f4a6eb165c54cc1e8f9 on feature/scheduler-checks-during-fetching.


Add initial PromCon 2016 site.

@fabxc @beorn7 @brian-brazil @grobie
This is ready for a look, but please don't merge yet without further coordination.

50% zoom screenshot of entire page:

@RichiH in case you're interested as well.

This ignores the existence of PromCon 1. sniff

@beorn7 :'( I know, but mentioning it here would only serve to confuse people.

I'd put it in as the second.

@brian-brazil The second conference? PromCon 1 was pretty unofficial and more of a tiny developer meetup. I don't think it makes sense to put it in the same category of event...

"PromCon16 is happening" can stand without mentioning if it's the first; that would simply leave the question open. If anyone asks, it's always possible to say "it's the second one, but the first one for the public".

I think "first" makes sense in this context, and hopefully helps to generate excitement to join. Anyways, we can always keep it as an inside joke that we were at the "real" first PromCon.

Anyways, we can always keep it as an inside joke that we were at the "real" first PromCon.

You can, we can't sniff

What about using promcon.io? Might help in twitter etc. where only the first part of a URL is visible.

@grobie Yeah, I was considering promcon.io or promcon.org as well - though, it would make sense to have a whole separate website then? I could still copy the design of prometheus.io, but without all the other menu items? That would be the fastest way to get there, at least, since we really should start the CFP soon...
Also, what do people think about the suggested closing date for the CFP (April 30). Too short, or ok?

It leaves almost 1.5 months, which sounds fine given the rather limited scope.

Cool, my thinking as well.

Closing in favor of separate site at promcon.io.


error runing plugin

Hi!
Today, i installed napari and then this plugin (from this plugin menu). After the installation sucecced, i go to the plugin menu and click on  the vollseg-napari button and get the following error:
Failed to import command at 'vollseg_napari._dock_widget:plugin_wrapper_vollseg': No module named 'magicgui.events'

Hi,
Since vollseg napari uses magicgui to create the widgets you would need to have magic gui installed in the anaconda environment where you are launching Napari from. You can install magic gui in that environment using pip install magicgui, see the package here. Hope this solves your issue.

I think the problem is that the library is not compatible with magicgui 0.4.0, as it removes the events.py  file that is being used here.
I found this migration guide.
As stated there:
Existing code using callbacks with a single positional argument will continue to receive a single Event object (and a
warning will be shown, until v0.4.0 where it will become an error).

Ah indeed I can reproduce the error you are getting with the magic gui 0.4.0, am updating my code now to migrate to being compatible with the new version.

Hello, I released new versions of vollseg and vollseg-napari, pip install the new versions and see if you are able to run it now?

It's working!!!!!
Thank you so much!


Document postgresql upgrade

Fixes https://github.com/NixOS/nixpkgs/issues/7454. Rendered:

cc @martinetd @domenkozar @Shados @wizeman are wording/upgrade method instructions clear?

I tried the instructions and it did work, thanks!
The only thing is that I was puzzled by the involvement of nixos containers. It took me a long time to understand that they are only there to work around the fact that the postgresql module only allows one postgresql cluster at once.

@Ma27 @martinetd This being a doc PR that doesn't appear to include wrong information, and nixos being in a state where any doc is better than no doc, I'm merging and backporting -- would be happy if you sent in PR's with the improvements you listed, though :)

Backported in 55b0101dfff..5d671c7c3cc

Damn it, I guess I just forgot about this (next time, feel free to remind me), sorry!
I actually tried this out a while ago and the migration went perfectly fine, so merging is fine.
Thanks a lot for taking care of this @danbst @Ekleog !


Incorrect test count summary with ScalaTest 3.0.5/Scala.js 0.6.22

I am programmatically generating tests based on data using an overridden nestedSuites. Here is a simplified example:
package com.araxis.muve.web.test

import org.scalatest.FunSuite

class Test extends FunSuite {

  case class TestCase(expectedResult: Boolean, description: String)

  val testCases =
    List(TestCase(true, "Test should be true."), TestCase(false, "Test should be false."))

  override def nestedSuites: Vector[FunSuite] = {
    val suites = for { tc <- testCases } yield
      new FunSuite {
        override def suiteName = s"${tc.description}"

        test("Assert test case is true") {
          assert(tc.expectedResult === true)
        }
      }

    suites.toVector
  }
}

This approach works as expected when the tests are run with the JVM. It also works fine with ScalaTest 3.0.4 and Scala.js 0.6.21. With ScalaTest 3.0.5 and Scala.js 0.6.22, however, the tests run correctly, but the result summary always shows a total of 0 tests run (at least, when using the Node JS environment to run the tests).
Here is the output from running the above test suite under sbt 1.1.1 with ScalaTest 3.0.5 and Scala.js 0.6.22 (note both the incorrect Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0 line and the No tests were executed. message):
[IJ]root> mwJS/testOnly com.araxis.muve.web.test.Test
[info] Compiling 1 Scala source to C:\Hg\MW\js\target\scala-2.12\classes ...
[info] Done compiling.
[info] Fast optimizing C:\Hg\MW\js\target\scala-2.12\mw-test-fastopt.js
[info] Test should be true.:
[info] - Assert test case is true
[info] Test should be false.:
[info] - Assert test case is true *** FAILED ***
[info]   false did not equal true (Test.scala:18)
[info] Run completed in 71 milliseconds.
[info] Total number of tests run: 0
[info] Suites: completed 0, aborted 0
[info] Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0
[info] No tests were executed.
[error] Failed tests:
[error]         com.araxis.muve.web.test.Test
[error] (mwJS / Test / testOnly) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 25 s, completed 28 Feb 2018, 16:38:45
[IJ]root>

For completeness, here is the same run, but with ScalaTest 3.0.4 and Scala.js 0.6.21 (note the correct test-count summary and the *** 1 TEST FAILED *** message):
[IJ]root> mwJS/testOnly com.araxis.muve.web.test.Test
[info] Compiling 1 Scala source to C:\Hg\MW\js\target\scala-2.12\classes ...
[info] Done compiling.
[info] Fast optimizing C:\Hg\MW\js\target\scala-2.12\mw-test-fastopt.js
[info] Test should be true.:
[info] - Assert test case is true
[info] Test should be false.:
[info] - Assert test case is true *** FAILED ***
[info]   false did not equal true (Test.scala:18)
[info] Run completed in 11 seconds, 492 milliseconds.
[info] Total number of tests run: 2
[info] Suites: completed 3, aborted 0
[info] Tests: succeeded 1, failed 1, canceled 0, ignored 0, pending 0
[info] *** 1 TEST FAILED ***
[error] Failed tests:
[error]         com.araxis.muve.web.test.Test
[error] (mwJS / Test / testOnly) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 20 s, completed 28 Feb 2018, 16:42:16
[IJ]root>

One further observation. If I add the option below to the .jsSettings for my sbt crossProject, the previously working ScalaTest 3.0.4/Scala.js 0.6.21 test run will fail in exactly the same way as it does with ScalaTest 3.0.5/Scala.js 0.6.22 without this option. Perhaps something has recently changed with ScalaTest or Scala.js in this area?
scalaJSSemantics ~= {
      // don’t leak class names; see http://bit.ly/2HwSOqj
      _.withRuntimeClassNameMapper(RuntimeClassNameMapper.discardAll())
    }

Can confirm it.
Scala: 2.12.5
Scalatest: 3.0.5
Scala.js: 0.6.22
Test.scala:
package testingTest
import org.scalatest.AsyncFeatureSpec
class MySpec extends AsyncFeatureSpec {
  feature("Feature 1") {
    scenario("Scenario 1 should fail") {
      fail("Not implemented yet")
    }
    scenario("Scenario 2 should pass") {
      assert(true)
    }
  }
}

Out:
[info] MySpec:
[info] Feature: Feature 1
[info] - Scenario: Scenario 1 should fail *** FAILED ***
[info]   Not implemented yet (MySpec.scala:9)
[info] - Scenario: Scenario 2 should pass
[info] Run completed in 112 milliseconds.
[info] Total number of tests run: 0
[info] Suites: completed 0, aborted 0
[info] Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0
[info] No tests were executed.
[error] Failed tests:
[error] 	testingTest.MySpec
[error] (Test / testOnly) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 9 s, completed Mar 26, 2018 4:42:20 PM
1. Waiting for source changes... (press enter to interrupt)

Starting Scala.js 0.6.22 (or precisely starting at scala-js/scala-js@22a8d7dc52669c537154f21519752a8b6680a174), the test adapter started executing tasks bound to the master runner.
This surfaces a latent bug in ScalaTest's Scala.js runner: Test counts are only ever updated via messages to the master runner. However, if a task is created on the master, notifyServer is set to None and no summary message is sent. As a result, tasks executed on the JS VM hosting the master runner do not contribute to summary count.

Hi all, thanks for the investigation, highly appreciated, I am working a fix now.

fyi I submitted a PR to fix this problem:
https://github.com/scalatest/scalatest/pull/1371


Cannot disable istio on kserve-controller-manager

/kind bug
What steps did you take and what happened:
Setting up a fresh Kserve installation - configured Knative and Kserve with Kourier as documented, unfortunately I'm unable to create an ISVC since the kserve controller manager is failing:
k get configmap/inferenceservice-config -o yaml -n kserve | yq .data.ingress
{
    "disableIstioVirtualHost": true,
    "ingressGateway" : "knative-serving/knative-ingress-gateway",
    "ingressService" : "istio-ingressgateway.istio-system.svc.cluster.local",
    "localGateway" : "knative-serving/knative-local-gateway",
    "localGatewayService" : "knative-local-gateway.istio-system.svc.cluster.local",
    "ingressDomain"  : "example.com",
    "ingressClassName" : "kourier.ingress.networking.knative.dev",
    "domainTemplate": "{{ .Name }}-{{ .Namespace }}.{{ .IngressDomain }}",
    "urlScheme": "http"
}

I've also changed the "ingressClassName" from istio to courier, it's not documented but I found that in the test source code. After creating a sample ISVC it does not get created, as the manager is failing:
{"level":"error","ts":1675418081.218336,"logger":"controller-runtime.source","msg":"if kind is a CRD, it should be installed before calling Start","kind":"VirtualService.networking.istio.io","error":"no matches for kind \"VirtualService\" in version \"networking.istio.io/v1alpha3\"","stacktrace":"k8s.io/apimachinery/pkg/util/wait.poll\n\t/go/pkg/mod/k8s.io/apimachinery@v0.22.3/pkg/util/wait/wait.go:591\nk8s.io/apimachinery/pkg/util/wait.PollImmediateUntilWithContext\n\t/go/pkg/mod/k8s.io/apimachinery@v0.22.3/pkg/util/wait/wait.go:542\nsigs.k8s.io/controller-runtime/pkg/source.(*Kind).Start.func1\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.2/pkg/source/source.go:131"}

I've rollouted the manager as documented after updating the configmap via kubectl rollout restart deployment kserve-controller-manager -n kserve
The startup log clearly indicated that the variable disableIstioVirtualService is not taken into account:
{"level":"info","ts":1675418042.2556174,"logger":"entrypoint","msg":"Setting up KServe v1beta1 scheme"}
{"level":"info","ts":1675418042.9156327,"logger":"entrypoint","msg":"Setting up Knative scheme"}
{"level":"info","ts":1675418042.9159184,"logger":"entrypoint","msg":"Setting up Istio schemes"}
{"level":"info","ts":1675418042.9163115,"logger":"entrypoint","msg":"Setting up core scheme"}

Source code for manager.go:
	if deployConfig.DefaultDeploymentMode == string(constants.Serverless) {
		log.Info("Setting up Knative scheme")
		if err := knservingv1.AddToScheme(mgr.GetScheme()); err != nil {
			log.Error(err, "unable to add Knative APIs to scheme")
			os.Exit(1)
		}
		if ingressConfig.DisableIstioVirtualHost == false {
			log.Info("Setting up Istio schemes")
			if err := v1alpha3.AddToScheme(mgr.GetScheme()); err != nil {
				log.Error(err, "unable to add Istio v1alpha3 APIs to scheme")
				os.Exit(1)
			}
		}
	}

I've also just noticed that the inferenceservice-config configmap is not mounted to the controller-manager deployment, so perhaps that is the root cause:
Name:                   kserve-controller-manager
Namespace:              kserve
CreationTimestamp:      Fri, 03 Feb 2023 10:29:51 +0100
Labels:                 control-plane=kserve-controller-manager
                        controller-tools.k8s.io=1.0
Annotations:            deployment.kubernetes.io/revision: 5
Selector:               control-plane=kserve-controller-manager,controller-tools.k8s.io=1.0
Replicas:               1 desired | 1 updated | 1 total | 0 available | 1 unavailable
StrategyType:           RollingUpdate
MinReadySeconds:        0
RollingUpdateStrategy:  25% max unavailable, 25% max surge
Pod Template:
  Labels:           control-plane=kserve-controller-manager
                    controller-tools.k8s.io=1.0
  Annotations:      kubectl.kubernetes.io/default-container: manager
                    kubectl.kubernetes.io/restartedAt: 2023-02-03T10:49:05+01:00
  Service Account:  kserve-controller-manager
  Containers:
   manager:
    Image:      kserve/kserve-controller:v0.9.0
    Port:       9443/TCP
    Host Port:  0/TCP
    Command:
      /manager
    Args:
      --metrics-addr=<IP_ADDRESS>:8080
      --leader-elect
    Limits:
      cpu:     100m
      memory:  300Mi
    Requests:
      cpu:     100m
      memory:  200Mi
    Environment:
      POD_NAMESPACE:   (v1:metadata.namespace)
      SECRET_NAME:    kserve-webhook-server-cert
    Mounts:
      /tmp/k8s-webhook-server/serving-certs from cert (ro)
   kube-rbac-proxy:
    Image:      gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0
    Port:       8443/TCP
    Host Port:  0/TCP
    Args:
      --secure-listen-address=<IP_ADDRESS>:8443
      --upstream=http://<IP_ADDRESS>:8080/
      --logtostderr=true
      --v=10
    Environment:  <none>
    Mounts:       <none>
  Volumes:
   cert:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  kserve-webhook-server-cert
    Optional:    false
Conditions:
  Type           Status  Reason
  ----           ------  ------
  Progressing    True    NewReplicaSetAvailable
  Available      False   MinimumReplicasUnavailable
OldReplicaSets:  <none>
NewReplicaSet:   kserve-controller-manager-65d9f95467 (1/1 replicas created)
Events:
  Type    Reason             Age   From                   Message
  ----    ------             ----  ----                   -------
  Normal  ScalingReplicaSet  33m   deployment-controller  Scaled up replica set kserve-controller-manager-866557d974 to 1
  Normal  ScalingReplicaSet  28m   deployment-controller  Scaled up replica set kserve-controller-manager-566544ff55 to 1
  Normal  ScalingReplicaSet  28m   deployment-controller  Scaled down replica set kserve-controller-manager-866557d974 to 0
  Normal  ScalingReplicaSet  25m   deployment-controller  Scaled up replica set kserve-controller-manager-6d7f968f86 to 1

What did you expect to happen:
ISVC with Kourier gets created successfully
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Istio Version: N/A
Knative Version: 1.8.1
KServe Version: 0.9.0
Kubeflow version: N/A
Cloud Environment: Linode
Minikube/Kind version: N/A
Kubernetes version: (use kubectl version): 1.24.8
OS (e.g. from /etc/os-release):  Mac OS Catalina

On a side note - how can I join your Slack? I'm building a product on top of Kserve and I'd love to get more involved

@lmyslinski You need kserve 0.10 to enable this option.

@yuzisun Thanks, I'll check it out - somehow I missed the fact that0.10.0 shipped. As for Slack - I get an error X doesn’t have an account on this workspace when trying to join, so I'm afraid it's not available for public signup

This problem is indeed gone in 0.10 - there are other issues but that's for a different time, thanks for help


WIP: Begin remote work.

I realized that syncprompt is created inside of the execute command. Talk to me in the office and I'll give you a rundown.
https://github.com/freeformsystems/cli-input/pull/8


Don't Merge! PR real time test for source branch full build

Docs Build status updates of commit a02affb:
:clock10: Pending: waiting for processors (29 builds ahead of you)
:warning: Docs Build is busy, currently there are 29 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit a02affb:
:clock10: Full build: the average full build time is 7 min(s) 17 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit a02affb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Shorthand syntax for updating context

Right now, the context updater function behaves almost like a reducer: it gives you the current context and you have to immutably return the next context.
It would be nice if it merging syntax like the old React's component-based setState.

Hey @cassiozen, I somewhat got your point, we want to work on this syntax https://github.com/cassiozen/useStateMachine/blob/main/examples/fetch/index.tsx#L37, right? Can you give an example for old React's component-based setState?

@chavda-bhavik  I think the idea is to expect a partial update return from the updater and internally merge that with the current reducer context:
These lines https://github.com/cassiozen/useStateMachine/blob/main/src/index.tsx#L65 :
  const nextContext = event.updater(state.context);
  if (config.verbose) log('Context update from %o to %o', state.context, nextContext);

Would be:
  const partialContextUpdate = event.updater(state.context);
  const nextContext = {...state.context, ...partialContextUpdate};
  if (config.verbose) log('Context update from %o to %o', state.context, nextContext);

I think the object merge is safe from prototype pollution by the TS compiler, and it is transpiled to Object.assign, which is pretty fast.
event.updater would return a Partial<Context> and we may need to assert (or cast, really bad stuff) the merging of state.context with partialContextUpdate as a full Context update. Though, my instinct tells me that the compiler is going to infer that nextContent is a full Context.

Just one note: We're only using the TS Compiler to emit declarations. Babel is doing .ts and .tsx file transformations, including stripping the type annotations.


Refactor Interpreter environment to use stk_env.

Small refactor to introduce the stack_env to the interpreter environment. Also renamed Environment to InterpreterState.
Otherwise not too exciting.

closing in favor or #576 which doesn't have a mangled rebase.


Create a new field for spatial envelopes

This field will be needed for spatial relevancy searching and can only be a rectangular bounding box in the ENVELOPE() format.

See https://github.com/geoblacklight/geoblacklight/issues/1158

Per https://github.com/geoblacklight/geoblacklight/issues/1158, the decision is to name the field dcat_bbox based on the dcat specification with a required format of "ENVELOPE(-79.750232,-71.750494,44.999963,40.499893)"

With the addition of the 3rd field, I wonder if we want to update the application's label for Spatial Extent. Since this is now a complex geometry field, maybe that label is not accurate.  Here is the simplest option:

geometry locn_geometry
bbox dcat_bbox
centroid dcat_centroid

This makes sense to me. Perhaps "Bounding Box" or "Envelope" instead of "Bbox"?

Done see (https://opengeometadata.org/docs/aardvarkSchema/bounding-box/)


how to use it

when i run ./bluepill -a ./Sample.app -s ./SampleAppTestScheme.xcscheme -o ./output/
it replay me -bash: ./bluepill: is a directory

After cloning it, you need to build it by running:
cd bluepill
./build.sh

Then you'll find a built bluepill binary inside the build directory.

The library should have this information honestly.

close this as fixed in #23


Add GeneratedKeyContext to

Pull Request Test Coverage Report for Build 2218

75 of 92 (81.52%)  changed or added relevant lines in 19 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 58.13%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingTableMetaDataDecorator.java
0
1
0.0%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingStatement.java
10
11
90.91%

shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java
0
1
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/statement/dml/InsertStatementContext.java
1
2
50.0%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java
11
13
84.62%

shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/segment/insert/keygen/engine/GeneratedKeyContextEngine.java
10
12
83.33%

sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/engine/InsertClauseShardingConditionEngine.java
6
15
40.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java
2
80.0%

Totals

Change from base Build 10493:
0.02%

Covered Lines:
11891

Relevant Lines:
20456

💛  - Coveralls


Wrong statics for J012157

Listed statics : J244, N110
Correct statics imo : J244, Z060 (Nullsec, not listed in the dropdown menu)

Here is everything I scanned down. Only 3 wormholes so far, including a K162 which is leading to a C4 having a C1 static  : this system

Thanks for your reporting! Unfortunately I can´t reproduce this on my official installation v.1.3.0
Is this a self hosted installation?

Yup, self hosted, may be not the lastest version
2017-12-10 20:26 GMT+01:00 Mark Friedrich<EMAIL_ADDRESS>
Thanks for your reporting! Unfortunately I can´t reproduce this on my
official installation v.1.3.0
Is this a self hosted installation?
[image: test]
https://user-images.githubusercontent.com/9299033/33808526-4be76a58-dde8-11e7-9706-d5c05840a4f9.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/exodus4d/pathfinder/issues/541#issuecomment-350574455,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFT-grpJOpriAXxSEfXajxrNHm3-JaBOks5s_DBsgaJpZM4P-6a_
.


Pull request with type [UPDATE] for user [philjorgensen] and object type [Script] - titled [Odometer]

Automated pull request from the Endpoint Configuration Manager Community hub.

I don't see any changes here beside a line being deleted, do you wanted to do other changes and published this by mistake?

In case you missed my comment in Pull #83, I wanted to see if there's a way to rename the Script without having to re-submit.  If that's not possible, how can I remove the original from the hub?  I appreciate your help Ioan.

I don't see any changes here beside a line being deleted, do you wanted to do other changes and published this by mistake?

In case you missed my comment in Pull #83, I wanted to see if there's a way to rename the Script without having to re-submit.  If that's not possible, how can I remove the original from the hub?  I appreciate your help Ioan.

I'm not sure if you can do that. I don't what the backend is but with git there's no easy way of doing that according to my limited understanding of GIT

I don't see any changes here beside a line being deleted, do you wanted to do other changes and published this by mistake?

In case you missed my comment in Pull #83, I wanted to see if there's a way to rename the Script without having to re-submit.  If that's not possible, how can I remove the original from the hub?  I appreciate your help Ioan.

About removing a pull request.
I'm not sure if you can do that. I don't what the backend is but with git there's no easy way of doing that according to my limited understanding of GIT
What you can do is load your committed branch, edit your original script and publish a new commit. I don't know if that will change the name in Community Hub though.
I would also like to know if it's possible to remove a submission.

Ioan, I think I did the rename right.  I'm still learning Git as well!

Approved, also have a look at variable and parameter naming conventions. The rest seems fine.


Added patch files for DCOS reservation label offer filtering.

High-level description
This is a backport of the fix for D2IQ-68800 (84988e82f02):
In DC/OS, Marathon and SDK use reservation labels to mark the
reservations that they created and to prevent other frameworks
from using them. However, some frameworks (e.g. Spark, Jenkins)
do not check the labels and can use reservations created by
Marathon / SDK. See D2IQ-68800 for an example.
The patch applied to mesos strips reservations that belong to
another framework, using the framework id label convention. Longer
term, we would want to just use framework specific reservations for
this, see MESOS-7651.
Corresponding DC/OS tickets (required)

D2IQ-68800 Frameworks can interfere with Marathon pods by launching tasks on "Marathon's" resources reserved to their role.

@mesosphere-mergebot label do not merge - should go after 2.1 GA


Add filtering by manufacturer

We should add an ability to show all results from devices of a certain manufacturer.
It's a firebase limitation that you can't search for several values at once.

Parent issue:

https://github.com/mlcommons/mobile_app_open/issues/490

Closing this in favor of https://github.com/mlcommons/mobile_app_open/issues/641


Why not calculate the loss per batch?

Hi, guys,
I am learning about Deformable-DETR these days, and I am curious about the implementation of HungarianMatcher,

Why match the bboxes per batch, as TORCH.CDIST provide the function to calculate the distances per batch, so the outputs["pred_boxes"].flatten(0, 1) seems unnecessary.
Matching the bboxes regardless of the batch index seems unreasonable, (or maybe I don't really understand the intrinsic nature of your implementation?)

Any answer or idea will be appreciated!

I think I found the answer.
Since the number of labels can vary in each batch, we cannot stack them as a tensor. (This is the reason why they concatenate them.)
If you want to avoid this, you have to iterate computation per batch.

I think I found the answer.
Since the number of labels can vary in each batch, we cannot stack them as a tensor. (This is the reason why they concatenate them.)
If you want to avoid this, you have to iterate computation per batch.


Struggling to install ember-cli version of ember-leaflet

Hi,
When I run 'ember install ember-leaflet' I get the following error:
404 Not Found: ember-leaflet
Error: 404 Not Found: ember-leaflet

Is there anything that I can do to fix this?

To install the ember-cli-es6 branch of this project, please use the following:
$ ember install gabesmed/ember-leaflet#ember-cli-es6

Great.. That worked prefectly.
Thanks so much


sysexits.h error

gcc -I. -o converter-sample.o -c converter-sample.c
converter-sample.c:18:48: fatal error: sysexits.h: No such file or directory
 #include <sysexits.h> /* for EX_* exit codes */
                                                ^
compilation terminated.
make: *** [Makefile:76: converter-sample.o] Error 1

What compiler are you using? Looks to be something like mingw or cygwin. I'd recommend finding sysexits.h online somewhere and just copying it to your include folder. Should resolve it.


How to build/export $error.svelte / 404 page with adapter-static ?

After running npm run build with adapter-static I hoped that the $error.svelte page would be generated as well. When statically hosted and whenever a non-existent route is hit, Sveltkit would redirect to the 404.html page.
With Sapper we just added to package.json a couple of lines
"build:export": "sapper export --entry \"/ /404\"",
"postexport": "mv __sapper__/export/404/index.html __sapper__/export/404.html"

I wonder how it is done with Sveltekit. Thanks

This is highly related to https://github.com/sveltejs/kit/issues/754 and possibly a duplicate of that issue

This is highly related to #754 and possibly a duplicate of that issue

Thanks for pointing it out. I believe it is a duplicate indeed. Hopefully, the fallback feature will be implemented soon.

And what about /404 for non-SPA? Unless I misunderstand it completely, providing a fallback will disable SSR, whereas Sapper would simply render and write an additional page. Can this somehow be replicated?

And what about /404 for non-SPA? Unless I misunderstand it completely, providing a fallback will disable SSR, whereas Sapper would simply render and write an additional page. Can the latter somehow be replicated?

This is a good question. After yesterday release of   "@sveltejs/adapter-node": "next" and reading the docs, I came to a conclusion that this is not a viable solution for SSR where a simple one extra 404.html page is needed. Is there a way we could reopen this bug?

I think it'd be better to file a new issue about that


Test 5 - Demo

Resource
Path
severity
rule_id
Description

aws_security_group_rule.my-rule1
/github/workspace/main.tf
CRITICAL
AVD-AWS-0107
An ingress security group rule allows traffic from /0.

aws_security_group_rule.my-rule2
/github/workspace/main.tf
CRITICAL
AVD-AWS-0107
An ingress security group rule allows traffic from /0.

aws_s3_bucket.my-bucket-test1
/github/workspace/test1.tf
HIGH
AVD-AWS-0086
S3 Access block should block public ACL

aws_s3_bucket.my-bucket
/github/workspace/main.tf
HIGH
AVD-AWS-0086
S3 Access block should block public ACL

aws_s3_bucket.my-bucket-test1
/github/workspace/test1.tf
HIGH
AVD-AWS-0087
S3 Access block should block public policy

aws_s3_bucket.my-bucket
/github/workspace/main.tf
HIGH
AVD-AWS-0087
S3 Access block should block public policy

aws_s3_bucket.my-bucket-test1
/github/workspace/test1.tf
HIGH
AVD-AWS-0088
Unencrypted S3 bucket.

aws_s3_bucket.my-bucket
/github/workspace/main.tf
HIGH
AVD-AWS-0088
Unencrypted S3 bucket.

aws_s3_bucket.my-bucket-test1
/github/workspace/test1.tf
HIGH
AVD-AWS-0132
S3 encryption should use Customer Managed Keys

aws_s3_bucket.my-bucket
/github/workspace/main.tf
HIGH
AVD-AWS-0132
S3 encryption should use Customer Managed Keys

aws_s3_bucket.my-bucket-test1
/github/workspace/test1.tf
HIGH
AVD-AWS-0091
S3 Access Block should Ignore Public Acl

aws_s3_bucket.my-bucket
/github/workspace/main.tf
HIGH
AVD-AWS-0091
S3 Access Block should Ignore Public Acl

aws_s3_bucket.my-bucket-test1
/github/workspace/test1.tf
HIGH
AVD-AWS-0093
S3 Access block should restrict public bucket to limit access

aws_s3_bucket.my-bucket
/github/workspace/main.tf
HIGH
AVD-AWS-0093
S3 Access block should restrict public bucket to limit access

aws_s3_bucket.my-bucket-test1
/github/workspace/test1.tf
MEDIUM
AVD-AWS-0089
S3 Bucket does not have logging enabled.

aws_s3_bucket.my-bucket
/github/workspace/main.tf
MEDIUM
AVD-AWS-0089
S3 Bucket does not have logging enabled.

aws_s3_bucket.my-bucket-test1
/github/workspace/test1.tf
MEDIUM
AVD-AWS-0090
S3 Data should be versioned

aws_s3_bucket.my-bucket
/github/workspace/main.tf
MEDIUM
AVD-AWS-0090
S3 Data should be versioned

aws_security_group_rule.my-rule1
/github/workspace/main.tf
LOW
AVD-AWS-0124
Missing description for security group rule.

aws_security_group_rule.my-rule2
/github/workspace/main.tf
LOW
AVD-AWS-0124
Missing description for security group rule.

aws_s3_bucket.my-bucket-test1
/github/workspace/test1.tf
LOW
AVD-AWS-0094
S3 buckets should each define an aws_s3_bucket_public_access_block

aws_s3_bucket.my-bucket
/github/workspace/main.tf
LOW
AVD-AWS-0094
S3 buckets should each define an aws_s3_bucket_public_access_block

Resource

A

B

Resource

A

B

Resource

A

B

aaaa

aaaa

aaaa

aaaa

aaaaaaa1212a

aaaa

Resource

A

Resource

A

B


[chip dv] Implement 2 rv_dm tests

In this PR, two of the pending RV_DM tests are implemented.

chip_rv_dm_access_after_hw_reset, tracked in #15796.
chip_rv_dm_ndm_reset_req_when_ibex_halted tracked in #14149

There are other related commits to other parts of the codebase to support the test development.

Merging - happy to address any more review feedback in future PRs.


Install firefox and phantom

How can I install firefox and phantomjs using the same configuration?
Thanks
Nitin

Follow the config options from https://github.com/vvo/selenium-standalone

I found config for firefox but still not able to find anything for phantomjs. I tried to use same pattern as others drivers  are getting installed but no success

it would  be best to open an issue on the linked project, this is just a wrapper for it, I'm also not seeing anything in their documentation, although phantomjs shouldn't require an additional driver, it should just be started in webdriver mode and you should use the webdriver port. I'm not seeing any examples.


how to link?

The Links is Saying No

How to Fix It?

Duplicate of #96

Man I Don't Understand.
Just How to Fix it??

Use the installer mentioned in that issue.


Cannot apply cart lines change while useBuyerJourneyIntercept is 'block'

Please list the package(s) involved in the issue, and include the version you are using
@shopify/checkout-ui-extensions-react v0.24.0
Describe the bug
I am building a custom app for a client of mine. Here is the use case:
The site is a marketplace in which the site is taking a commission on each sale.
We are usign a custom app + checkout ui extension to compute the commission based on the cart content:

Customer arrives on the checkout
CartLines are sent to our app backend
App backend creates and publishes the commission (created as a digital product) and returns the product JSON
Checkout UI extension gets the JSON as a response and applies it to the cart using useApplyCartLinesChange()

Of course I do not want the customers to be able to go any further in their checkout flow during the computing process.
However when blocking the buyer journey useApplyCartLinesChange fails with a generic error (that made it so hard to debug):
{type: 'error', message: 'Could not apply line item changes'}.
Steps to reproduce the behavior:
To reproduce the issue, you can implement something like this:
enum FetchingState {
  Waiting = 'waiting',
  ShouldLoad = 'should_load',
  Loading = 'loading',
  Loaded = 'loaded',
  Error = 'error',
}

// ...
const [fetchingState, setFetchingState] = useState<FetchingState>(
  FetchingState.Waiting
);
const applyCartLinesChange = useApplyCartLinesChange();
const canBlockProgress = useExtensionCapability("block_progress");

// ...

useEffect(() => {
  const createAndAddCommissionProductToCart = async () => {
    const application = await applyCartLinesChange({
      type: "addCartLine",
      merchandiseId: "YOUR_VARIANT_ID_HERE",
      quantity: 1,
    });
  };

  if (fetchingState === FetchingState.ShouldLoad) {
    setFetchingState(FetchingState.Loading);

    // This will fail since the buyer journey === 'block'
    createAndAddCommissionProductToCart();
  }
}, [fetchingState]);

// ...

if (canBlockProgress) {
  useBuyerJourneyIntercept(() => {
    /**
     * Should be:
     * if (fetchingState !== FetchingState.Loaded)
     * but currently impossible because of the issue I am describing
     */
    if (fetchingState === FetchingState.Error) {
      return {
        behavior: 'block',
        reason: InvalidResultReason.CommissionFetchingIssue,
        perform: () => {
          setShowBlockingBanner(true);
        },
      };
    }

    return {
      behavior: 'allow',
      perform: () => {
        setShowBlockingBanner(false);
      },
    };
  });
}

Expected behavior
Basically I would like to be able to block buyer journey and still be able to process some cart updates behind the scenes.
At the moment my use case described above is impossible, and if a customer goes fast enough to proceed his order, he might be able to complete his order whithout being charged a commission.

Hi @aurelienbobenrieth. Thanks for taking the time to report a bug. Could you provide a concise, runnable version of extension code that reproduces the bug?
I can't run the code above because it's missing some variables. Also, it looks like you commented out the code that actually triggers the bug?

/**
* Should be:
* if (fetchingState !== FetchingState.Loaded)
* but currently impossible because of the issue I am describing
*/

I verified that simple blocking is working in production with this extension (below). There could be a timing issue that I don't fully understand, though.

Example code
import { useState } from "react";
import {
  render,
  Banner,
  useExtensionCapability,
  useBuyerJourneyIntercept,
} from "@shopify/checkout-ui-extensions-react";

render("Checkout::Dynamic::Render", () => <App />);

function App() {
  const [bannerText, setBannerText] = useState<null | string>(null);
  const canBlockProgress = useExtensionCapability("block_progress");

  useBuyerJourneyIntercept(() => {
    if (!canBlockProgress) {
      setBannerText(
        "This extension is not allowed to block checkout progress. Make sure `block_progress = true` in [capabilities]"
      );
      return { behavior: "allow" };
    }
    return {
      behavior: "block",
      reason: "example reason",
      perform: () => {
        setBannerText("An extension is blocking checkout progress");
      },
    };
  });

  if (bannerText) {
    return <Banner status="critical">{bannerText}</Banner>;
  }

  return <Banner>The extension is not blocking checkout</Banner>;
}

@misha-reyzlin-shopify Great news! Thank you very much!


[BUG] Calendar won't show in modal

The table and everything seems to be generated, but it won't show up.

Had similar issue. Fixed it by initialising the modal before the calendar, i.e:
$('#mymodal').modal();
...and then:
$('#mycalendar').calendar({youroptionshere});
Hope this helps.


NoneType object has no attribute settings

Description
NOTE: # ( Describe the problem you're encountering. )
[TIP]:  # ( Do NOT share sensitive information, whether personal, proprietary, or otherwise! )
This broke our production build. Not every, but lots of requests failed due to newrelic framework_graphql
AttributeError: 'NoneType' object has no attribute 'settings'
File "promise/promise.py", line 87, in try_catch
return (handler(*args, **kwargs), None)
File "graphql/execution/executor.py", line 127, in promise_executor
return execute_operation(exe_context, exe_context.operation, root_value)
File "newrelic/hooks/framework_graphql.py", line 108, in wrap_execute_operation
settings = transaction.settings
Expected Behavior
NOTE: # ( Tell us what you expected to happen. )
It doesn't crash :)
Troubleshooting or NR Diag results
NOTE: # ( Provide any other relevant log data. )
[TIP]:  # ( Scrub logs and diagnostic information for sensitive information )
Steps to Reproduce
NOTE: # ( Please be as specific as possible. )
[TIP]:  # ( Link a sample application that demonstrates the issue. )
Any graphql query
Your Environment
[TIP]:  # ( Include as many relevant details about your environment as possible including the running version of New Relic software and any relevant configurations. )
newrelic 8.7.1 (This did NOT happen on 8.7.0)
graphene 2.1.6
Additional context
[TIP]:  # ( Add any other context about the problem here. For example, relevant community posts or support tickets. )
I know We're on an old version of graphene,  but still, one would hope patch version upgrades don't have breaking changes 🤣

Hello @erry-takumi, sorry about that. I've opened a PR to guard that settings lookup to prevent this. If you back down to 8.7.0 for the time being you shouldn't see any issues. We'll put a patch version out to address this as soon as we can.


Derive parameter name of desctructured parameter from JSDoc comment

Search Terms
__namedParameters, destructured parameter,  @param
Problem
TypeDoc sets the name of any destructured parameters to "__namedParameters", even when a name is given in the JSDoc comment. This also results in the description of this parameter (and any child properties) in the JSDoc comment being ignored.
This relates to the "@param dot syntax" that is currently under consideration in TSDoc. TypeDoc already supports the dot syntax for parameters with names (i.e. when they are not being destructured), but it doesn't work for the more common scenario where the parameter is destructured inline.
For example, with this code snippet, all descriptions are rendered correctly:
/**
 * Concatenate strings 'a' and 'b'
 *
 * @param options - The options.
 * @param options.a - The 'a' string.
 * @param options.b - The 'b' string.
 */
function concatAB(options: { a: string, b: string }) {
  const { a, b } = options;
  return a + b;
}

But in this example, the @param tags end up being ignored because TypeDoc doesn't understand that the options param is the descructured parameter:
/**
 * Concatenate strings 'a' and 'b'
 *
 * @param options - The options.
 * @param options.a - The 'a' string.
 * @param options.b - The 'b' string.
 */
function concatAB({ a: string, b: string }) {
  return a + b;
}

Suggested Solution
We could set the name of the parameter to the name given in the JSDoc comment. This would also ensure the descriptions are correctly matched up. This relies upon the assumption that the JSDoc @param tags are present for all parameters, and that they are correctly ordered, so we can add a check to ensure this replacement only occurs if this appears to be the case (or maybe we can make this configurable?).
I am unaware of what other similar tools do in this circumstance.
I'd be happy to do this in a plugin instead, but I'm not sure that it would be possible. This relies upon the parsed comment, so it can't be triggered by the EVENT_CREATE_SIGNATURE, EVENT_CREATE_DECLARATION, or EVENT_CREATE_TYPE_PARAMETER event, because how would we be certain the comment was resolved by then? I think it would need to be done during the "resolve" phase, which is when the information in the parsed comment gets incorporated into the signature at the moment. So we could do this in a plugin that gets triggered by the beginning of the resolve phase, but that would be challenging without duplicating the functionality of addCommentToSignatures, or somehow guaranteeing that the plugin gets run before that function.

I've created a draft PR to better explain how this could be done (#1704). It doesn't have tests yet, but it does pass all existing tests. If you think this is worth pursuing further, I can update the PR to include better test coverage.

I like this idea - it matches how VSCode recognizes comments, and is fairly intuitive to use.

Great! I've just updated the PR with tests and marked it as ready for review.


Unhandled exception when loading map that has Image layers

"An unhandled exception of type 'System.ArgumentNullException' occurred in System.Xml.Linq.dll
Additional information: Value cannot be null."
Occurs when i try to load a tiled map that has ImageLayers, if I remove the image layer from the map everything loads just fine.
Part of stacktrace (error occurs on TmxMap ctor):
at System.Xml.Linq.XAttribute.op_Explicit(XAttribute attribute)
at TiledSharp.TmxImageLayer..ctor(XElement xImageLayer, String tmxDir)
at TiledSharp.TmxMap..ctor(String filename)

After downloading the source code to use instead of the NuGet package so I could fix the error everything worked.
II guess the NuGet version has to be updated.

Thanks for letting me know.  I didn't realise that anyone was even using that nuget version.
I'm on a work trip this week, but I'll try to get it updated soon.
Thanks again!

I've just updated the NuGet package, hopefully it's working fine.


[Doc Improvement][Update Tools and SDK revamp for Visual Studio] (#66…

…42) (#6643)

.

.

Update debug-teams-app-visual-studio.md

.

Update debug-teams-app-visual-studio.md

Co-authored-by: v-ksar<EMAIL_ADDRESS>

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
6
link
:white_check_mark:

msteams-platform/toolkit/VS-TeamsFx-preview-and-customize-app-manifest.md
100
1
link
:white_check_mark:

msteams-platform/toolkit/create-new-teams-app-for-Visual-Studio.md
100
2
link
:white_check_mark:

msteams-platform/toolkit/debug-teams-app-visual-studio.md
98
5
link
:white_check_mark:

msteams-platform/toolkit/deploy-teams-app.md
98
2
link
:white_check_mark:

msteams-platform/toolkit/provision-cloud-resources.md
97
30
link
:white_check_mark:

msteams-platform/toolkit/teams-toolkit-overview-visual-studio.md
95
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 52a11f7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/toolkit/create-new-teams-app-for-Visual-Studio.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/debug-teams-app-visual-studio.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/deploy-teams-app.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/provision-cloud-resources.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/teams-toolkit-overview-visual-studio.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/VS-TeamsFx-preview-and-customize-app-manifest.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Batch Size Greater Than 1 Causes "Error, not all required dimensions specified" in Custom TensorRT Implementation

Description:
I am working on a custom model using a class I named HypNet, which is based on the original YoloV8 implementation and utilizes TensorRT for inference. The model's input dimensions are reshaped to [40, 1, 1280]. When I attempt to run the model with a batch size of 2 (or any batch size greater than 1), I encounter the following error:

terminate called after throwing an instance of 'std::runtime_error'
what():  Error, not all required dimensions specified.

However, if I set both optBatchSize and batchSize to 1, the error does not occur, and I can successfully obtain results.
Initialization with Batch Size 2 (Error Occurs):
HypNet::HypNet(const std::string& onnxModelPath, const HypNetConfig& config)
    : CLASS_NAMES(config.classNames) {
    Options options;
    options.optBatchSize = 2;
    options.maxBatchSize = 2;
    options.precision = config.precision;
    options.calibrationDataDirectoryPath = config.calibrationDataDirectory;

    if (options.precision == Precision::INT8 && options.calibrationDataDirectoryPath.empty()) {
        throw std::runtime_error("Error: Must supply calibration data path for INT8 calibration");
    }

    m_trtEngine = std::make_unique<Engine<float>>(options);
    auto succ = m_trtEngine->buildLoadNetwork(onnxModelPath, SUB_VALS, DIV_VALS, NORMALIZE);
    if (!succ) {
        throw std::runtime_error("Error: Unable to build or load the TensorRT engine.");
    }
}

std::vector<std::vector<cv::cuda::GpuMat>> HypNet::preprocess(const std::string& lineFilePath) {
    const int batchSize = 2;
    cv::Mat line = loadLine(lineFilePath);
    cv::Mat reshaped_line = line.reshape(40, {1, 1280});
    cv::cuda::GpuMat gpuImg;
    gpuImg.upload(reshaped_line);
    std::vector<cv::cuda::GpuMat> batchInput;
    batchInput.reserve(batchSize);

    for (int i = 0; i < batchSize; ++i) {
        batchInput.push_back(gpuImg.clone());
    }

    std::vector<std::vector<cv::cuda::GpuMat>> inputs{std::move(batchInput)};
    return inputs;
}

Initialization with Batch Size 1 (Works as Expected):
    HypNet::HypNet(const std::string& onnxModelPath, const HypNetConfig& config)
        : CLASS_NAMES(config.classNames) {
        Options options;
        options.optBatchSize = 1;
        options.maxBatchSize = 1;
        options.precision = config.precision;
        options.calibrationDataDirectoryPath = config.calibrationDataDirectory;

        if (options.precision == Precision::INT8 && options.calibrationDataDirectoryPath.empty()) {
            throw std::runtime_error("Error: Must supply calibration data path for INT8 calibration");
        }

        m_trtEngine = std::make_unique<Engine<float>>(options);
        auto succ = m_trtEngine->buildLoadNetwork(onnxModelPath, SUB_VALS, DIV_VALS, NORMALIZE);
        if (!succ) {
            throw std::runtime_error("Error: Unable to build or load the TensorRT engine.");
        }
    }

Additional Information:
Expected Output: When using a batch size of 2, I expect the output to be in the format of [2, 6, 1280].
Current Setup:
Repository Version: 5.0 (for the implementation of TensorRT)
Custom Model Input Dimensions: [40, 1, 1280]
I have removed the cv::cuda::split(batchInput[img], input_channels); line from engine.h because my model has 40 channels.
By doing this, I simulate having multiple batches:
    for (int i = 0; i < batchSize; ++i) {
        batchInput.push_back(gpuImg.clone());
    }

model.zip

Can you confirm that it works as expected if you export the ONNX model with a fixed batch_size of 2?

Can you confirm that it works as expected if you export the ONNX model with a fixed batch_size of 2?

Now the model inference is happening, but there is an error calling by the following line in engine.cpp:
 if (input.size() != 1 || input[0].size() != 1)

The program terminates with the following error message:
terminate called after throwing an instance of 'std::logic_error'
what():  The feature vector has incorrect dimensions!

This occurs when applying the transformOutput function.
`std::vector HypNet::detectObjects(std::string lineFilePath) {
int batchSize = 2;
auto input = preprocess(lineFilePath);
std::vector<std::vector<std::vector>> featureVectors;
double totalInferenceTimeMs = 0.0;
// Simulate running inference on x lines
for (int i = 0; i < 1; ++i) {
    // Start measuring time
    auto start = std::chrono::high_resolution_clock::now();

    auto succ = m_trtEngine->runInference(input, featureVectors);

    // Stop measuring time
    auto end = std::chrono::high_resolution_clock::now();

    // Calculate the duration for this inference
    std::chrono::duration<double> duration = end - start;
    double inferenceTimeMs = duration.count() * 1000.0;
    totalInferenceTimeMs += inferenceTimeMs;

    if (!succ) {
        throw std::runtime_error("Error: Unable to run inference on line " + std::to_string(i + 1));
    }
}
qDebug() << "Total inference time: " << totalInferenceTimeMs << " ms";

auto outputDims = m_trtEngine->getOutputDims();

qDebug() << "Output dimensions: ";
for (const auto& dim : outputDims) {
    qDebug() << dim.d[0] << "x" << dim.d[1] << "x" << dim.d[2] << "x" << dim.d[3];
}

if (outputDims.size() != 1 || outputDims[0].d[0] != batchSize || outputDims[0].d[2] != 1 || outputDims[0].d[3] != 1280) {
    throw std::runtime_error("Error: Unexpected output dimensions.");
}

std::vector<float> featureVector;
Engine<float>::transformOutput(featureVectors, featureVector);

std::vector<std::vector<int>> all_predicted_classes(batchSize, std::vector<int>(1280));

for (int b = 0; b < batchSize; ++b) {
    for (int i = 0; i < 1280; ++i) {
        float max_val = featureVectors[b][0][i]; // Start with the first class
        int max_idx = 0;
        for (int j = 1; j < 6; ++j) { // Iterate over the 6 classes
            if (featureVectors[b][0][j * 1280 + i] > max_val) {
                max_val = featureVectors[b][0][j * 1280 + i];
                max_idx = j;
            }
        }
        all_predicted_classes[b][i] = max_idx;
    }
}

std::vector<Object> detectedObjects;

return detectedObjects;

}
`

It seems that the issue might be related to how the input tensor shapes are set during inference. By modifying the lines around L72 in the following way:
m_context->setInputShape(m_IOTensorNames[i].c_str(),
                                 inputDims);

to
int inputIndex = m_engine->getBindingIndex(m_IOTensorNames[i].c_str());

if (!m_engine->bindingIsInput(inputIndex)) {
       spdlog::error("Binding {} is not an input!", inputIndex);
       return false;
}

// Set the binding dimensions for the input
if (!m_context->setBindingDimensions(inputIndex, inputDims)) {
      spdlog::error("Failed to set binding dimensions for input {}", inputIndex);
      return false;
}

I get featureVectors of shape 2x1x7680, which can be reshaped to 2x6x1280. I believe this is the output shape you’re expecting.
I'm not entirely sure yet why this change works differently from the previous implementation, but I’ll look into it further. Could you please try this on your end and see if it resolves the issue?

I tried make like  this
        nvinfer1::Dims4 inputDims = {batchSize, dims.d[0], dims.d[1], dims.d[2]};
        m_context->setInputShape(m_IOTensorNames[i].c_str(),
                                 inputDims); // Define the batch size
        int inputIndex = m_engine->getBindingIndex(m_IOTensorNames[i].c_str());

        if (!m_engine->bindingIsInput(inputIndex)) {
            std::cout << "Binding {} is not an input!", inputIndex;
            return false;
        }

        // Set the binding dimensions for the input
        if (!m_context->setBindingDimensions(inputIndex, inputDims)) {
            std::cout << "Failed to set binding dimensions for input {}", inputIndex;
            return false;
        }

or
        nvinfer1::Dims4 inputDims = {batchSize, dims.d[0], dims.d[1], dims.d[2]};
        int inputIndex = m_engine->getBindingIndex(m_IOTensorNames[i].c_str());

        if (!m_engine->bindingIsInput(inputIndex)) {
            std::cout << "Binding {} is not an input!", inputIndex;
            return false;
        }

        // Set the binding dimensions for the input
        if (!m_context->setBindingDimensions(inputIndex, inputDims)) {
            std::cout << "Failed to set binding dimensions for input {}", inputIndex;
            return false;
        }
        m_context->setInputShape(m_IOTensorNames[i].c_str(),
                                 inputDims); // Define the batch size

but no effect for me

The code on the i-80 branch includes these changes, resulting in the following output:
./build/run_inference_benchmark --onnx_model ./models/model.onnx
[2024-08-26 11:39:34.462] [warning] LOG_LEVEL environment variable not set. Using default log level (info).
[2024-08-26 11:39:34.478] [info] Engine name: model.engine.Orin.fp16.2.2
[2024-08-26 11:39:34.478] [info] Searching for engine file with name: ./model.engine.Orin.fp16.2.2
[2024-08-26 11:39:34.478] [info] Engine found, not regenerating...
[2024-08-26 11:39:34.478] [info] Loading TensorRT engine file at path: ./model.engine.Orin.fp16.2.2
[2024-08-26 11:39:34.556] [info] Loaded engine size: 11 MiB
[2024-08-26 11:39:34.583] [info] [MemUsageChange] TensorRT-managed allocation in engine deserialization: CPU +0, GPU +10, now: CPU 0, GPU 10 (MiB)
[2024-08-26 11:39:34.584] [info] [MemUsageChange] TensorRT-managed allocation in IExecutionContext creation: CPU +0, GPU +3, now: CPU 0, GPU 13 (MiB)
[2024-08-26 11:39:34.594] [info] Attempting to reshape the matrix to have 40 channels, 1 height, and 1280 width
[2024-08-26 11:39:34.594] [info] Reshaped desired matrix to have 40 channels, 1 height, and 1280 width
[2024-08-26 11:39:34.594] [info] Warming up the network...
[2024-08-26 11:39:34.870] [info] Feature vectors shape: 2x1x7680
[2024-08-26 11:39:34.870] [info] Running benchmarks (1000 iterations)...
[2024-08-26 11:39:36.693] [info] Benchmarking complete!
[2024-08-26 11:39:36.693] [info] ======================
[2024-08-26 11:39:36.693] [info] Avg time per sample:
[2024-08-26 11:39:36.693] [info] Avg time per sample: 0.9115 ms
[2024-08-26 11:39:36.693] [info] Batch size: 2
[2024-08-26 11:39:36.693] [info] ======================

[2024-08-26 11:39:36.693] [info] Batch 0, output 0
[2024-08-26 11:39:36.693] [info] 4.476562 4.285156 4.230469 4.371094 4.699219 4.828125 4.921875 4.167969 4.406250 4.726562 ...
[2024-08-26 11:39:36.693] [info] Batch 1, output 0
[2024-08-26 11:39:36.693] [info] 4.476562 4.285156 4.230469 4.371094 4.699219 4.828125 4.921875 4.167969 4.406250 4.726562 ...

Does this give the results you're expecting?

No result that i expected(

Didn't you mention that the output should be (batch_size, 6, 1, 1280)? In the case on branch i-80 the batch_size is set to 2.

In the example above I ran it with your original model with dynamic batch size.

Total inference time:  26.1466  ms
Output dimensions:
-1 x 6 x 1 x 1280
terminate called after throwing an instance of 'std::runtime_error'
what():  Error: Unexpected output dimensions.

https://github.com/pavelgrigoriev/tensorrt-cpp-api/tree/main my code structure

I’m not sure why it’s not working with your structure. I’ll keep the i-80 branch active for now in case you want to use it for debugging. It’s set up with dynamic batch size for the model you provided.

I’m not sure why it’s not working with your structure. I’ll keep the i-80 branch active for now in case you want to use it for debugging. It’s set up with dynamic batch size for the model you provided.

Okey, thank you very much anyway!


make compile fails due to trying to pulling non-existing branch of apache/camel-quarkus repo

Describe the bug
BUILD_LIST=external make compile fails when checking out https://github.com/apache/camel-quarkus.git. The camel-quarkus repo doesn't have the master branch but main. I think they renamed it at some point.
     [exec] Step 18/22 : RUN git clone https://github.com/apache/camel-quarkus.git
     [exec]  ---> Running in 443a9032a830
     [exec] Cloning into 'camel-quarkus'...
     [exec] Removing intermediate container 443a9032a830
     [exec]  ---> 063ff5e61422
     [exec] Step 19/22 : WORKDIR /camel-quarkus/
     [exec]  ---> Running in 6aedff57e11b
     [exec] Removing intermediate container 6aedff57e11b
     [exec]  ---> 91cc446a13f1
     [exec] Step 20/22 : RUN git checkout $CAMEL_TAG
     [exec]  ---> Running in a25c978c718f
     [exec] error: pathspec 'master' did not match any file(s) known to git
     [exec] The command '/bin/sh -c git checkout $CAMEL_TAG' returned a non-zero code: 1
     [exec]

BUILD FAILED
.../aqa-tests/TKG/scripts/build_test.xml:76: The following error occurred while executing this line:
.../aqa-tests/external/build.xml:42: The following error occurred while executing this line:
.../aqa-tests/external/camel/build.xml:25: The following error occurred while executing this line:
.../aqa-tests/external/build.xml:87: exec returned: 1

To Reproduce
export BUILD_LIST=external

git clone https://github.com/adoptium/aqa-tests.git
cd aqa-tests
./get.sh
cd TKG
make compile

Note we intend to eventually read from the test.properties file, but for now still read from common_functions.sh, so to fix this issue, updates needed at:
https://github.com/adoptium/aqa-tests/blob/master/external/common_functions.sh#L189
and
https://github.com/adoptium/aqa-tests/blob/master/external/camel/test.properties#L5
Also note if you want to run a particular external test, set BUILD_LIST=external/camel or which ever test you want to run in that directory, otherwise we try to compile ALL tests in the external directory, which takes a very long time.

could i work on this?

Yes please @unnati914 !

Thanks for the explanation. That helps.
Another error while trying to run all the "external" tests. Is AdoptOpenJDK not being tested daily with "external" tests? I can understand that these tests can be flaky and will probably need constant maintenance, but I am surprised that there are multiple broken tests, meaning that they are probably not being utilized for AdoptOpenJDK 11 at least. Or, is it that running "external" tests are not really worth it?
This time, it's with the scala test. It tries to download https://piccolo.link/sbt-1.2.8.tgz, which redirects to https://sbt-downloads.cdnedge.bluemix.net/.... But the host address is not resolvable.
     [echo] Executing external.sh --build --dir scala --tag nightly --version 11 --impl hotspot
...
     [exec] Step 12/25 : RUN wget --no-check-certificate --no-cookies https://piccolo.link/sbt-${SBT_VERSION}.tgz 	&& wget --no-check-certificate --no-cookies https://piccolo.link/sbt-${SBT_VERSION}.tgz.asc 	&& curl "https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x2EE0EA64E40A89B84B2DF73499E82A75642AC823" | gpg --import 	&& gpg --verify sbt-${SBT_VERSION}.tgz.asc sbt-${SBT_VERSION}.tgz 	&& tar -zvxf sbt-${SBT_VERSION}.tgz -C /opt/ 	&& rm -f sbt-${SBT_VERSION}.tgz 	&& rm -f sbt-${SBT_VERSION}.tgz.asc
     [exec]  ---> Running in 91d663720ab0
     [exec] --2021-07-15 21:08:12--  https://piccolo.link/sbt-1.2.8.tgz
     [exec] Resolving piccolo.link (piccolo.link)... <IP_ADDRESS>, <IP_ADDRESS>
     [exec] Connecting to piccolo.link (piccolo.link)|<IP_ADDRESS>|:443... connected.
     [exec] HTTP request sent, awaiting response... 301 Moved Permanently
     [exec] Location: https://sbt-downloads.cdnedge.bluemix.net/releases/v1.2.8/sbt-1.2.8.tgz [following]
     [exec] --2021-07-15 21:08:13--  https://sbt-downloads.cdnedge.bluemix.net/releases/v1.2.8/sbt-1.2.8.tgz
     [exec] Resolving sbt-downloads.cdnedge.bluemix.net (sbt-downloads.cdnedge.bluemix.net)... failed: Name or service not known.
     [exec] wget: unable to resolve host address ‘sbt-downloads.cdnedge.bluemix.net’

Another question: I'm still interested in running all "external" tests with BUILD_LIST=external make compile, which also tries the external_custom test. This particular test is not a self-contained one but is like a hook/template/helper for anyone to run a custom test against an arbitrary repo, right?

we are in the process of overhauling the external tests, so have turned off daily builds... the overhaul is being done under a summer project under the Outreachy program (1 intern working on it).  If you have an interest and are willing to help us lift them up faster, that would be wonderful!  Otherwise, the plan is to continue to work on them for the remainder of the summer term to see if we can get to a sane state again.
external_custom is the WIP target being worked on under the Outreachy project, please see an overview here: https://github.com/adoptium/aqa-tests/wiki/Outreachy-Simplify-and-Gamify-External-Tests-Project:-Tweetest

I could help if i can :)

Yes please help @unnati914 - I have assigned this issue to you, please create a PR if you have the time and interest.

hi what could configure from this issue is.. that while cloning the repo i have to mention the branch name..  is there anything else i need to do?

All you need to do for this issue is to create a PR with the change to the branch name in the 2 files as described in https://github.com/adoptium/aqa-tests/issues/2738#issuecomment-880274081.
Once you create a PR, the reviewers will run a test to see that the test works.  You can also try to run the test locally following the instructions in https://github.com/adoptium/aqa-tests/tree/master/external/camel#running-external-camel-tests-locally, but that is not a requirement in order to provide a fix.

Hi @smlambert. I am an Outreachy applicant. Is it okay for me to work on this?

Closed as this has been resolved by a couple of updates