Performance degradation when training with jsonl manifests (i.e. DynamicBucketingSampler)

Create a issue here to discuss this problem.
I re-ran the pruned_transducer_stateless4 baseline with DynamicBucketingSampler, the results are as follows:

setup
greedy_search
fast_beam_search
modified_beam_search
comments

Trained with jsonl manifests
2.93 & 6.61
2.99 & 6.55
3.17 & 6.78
--epoch 25 --avg 15 tensorboard

Baseline, trained with json manifests (by zengwei)
2.69 & 6.64
2.66 & 6.6
2.62 & 6.57
--epoch 30 --avg 6 details, tensorboard

I conducted another two experiments:
(1) Use json manifests and BucketingSampler (i.e. to reproduce the original baseline)
(2) shuffle the jsonl manifests globally and use DynamicBucketingSampler.
shuffle command
 gunzip -c jsonl.gz | shuf | gzip -c  > new_jsonl.gz

The results are :

setup
greedy_search
fast_beam_search
modified_beam_search
comments

json + BucketingSampler
2.64 & 6.35
2.66 & 6.26
2.59 & 6.17
--epoch 25 --avg 11

shuf jsonl + DynamicBucketingSampler
2.66 & 6.34
2.74 & 6.33
2.65 & 6.27
--epoch 25 --avg 7

I ran another experiment using global shuffled jsonl, the shuffle command is:
cat clean-100.jsonl clean-360.jsonl other-500.jsonl | shuf | gzip -c > libri-960.jsonl.gz

Summarize all my experiments below:

setup
greedy_search
fast_beam_search
modified_beam_search
comments

Earlier baseline, json + BucketingSampler (by zengwei)
2.69 & 6.64
2.66 & 6.6
2.62 & 6.57
--epoch 30 --avg 6

json + BucketingSampler
2.64 & 6.35
2.66 & 6.26
2.59 & 6.17
--epoch 25 --avg 11

jsonl + DynamicBucketingSampler
2.93 & 6.61
2.99 & 6.55
3.17 & 6.78
--epoch 25 --avg 15

shuffled jsonl + DynamicBucketingSampler
2.66 & 6.34
2.74 & 6.33
2.65 & 6.27
--epoch 25 --avg 7

global shuffled jsonl + DynamicBucketingSampler
2.68 & 6.39
2.69 & 6.33
2.69 & 6.43
--epoch 25 --avg 9

Thanks, this is very interesting. I'm surprised that you are seeing a degradation with global shuffled vs locally shuffled` version (test-other WER on modified_beam_search 6.43 vs 6.27), it's small but large enough to think it could be non-random. But I would have expected the globally shuffled version to work better.
I was considering developing the streaming shuffling further in Lhotse to improve the sampler randomness, but maybe it's not needed.

Here are the results I have using the master code.
It is trained WITHOUT pre-shuffling.

decoding method
test-clean
test-other
comment

greedy search
2.69
6.45
--epoch 30, --avg 8, --use-averaged-model true

It does not indicate that results using jsonl with dynamic bucketing sampler are worse than that of using json with bucketing sampler.
Post the results from the first comment below for easy reference

Training command:
export CUDA_VISIBLE_DEVICES="2,3,4,5,6,7"

./pruned_transducer_stateless4/train.py \
  --world-size 6 \
  --num-epochs 30 \
  --start-epoch 1 \
  --exp-dir pruned_transducer_stateless4/exp \
  --full-libri 1 \
  --max-duration 300 \
  --save-every-n 8000 \
  --keep-last-k 20 \
  --average-period 100

Decoding command
for epoch in 30; do
  for avg in 6 7 8 9 10 11; do
    ./pruned_transducer_stateless4/decode.py \
        --epoch $epoch \
        --avg $avg \
        --use-averaged-model 1 \
        --exp-dir ./pruned_transducer_stateless4/exp \
        --max-duration 600 \
        --decoding-method greedy_search
  done
done

Note: The training command is identical with the one listed in
https://github.com/k2-fsa/icefall/blob/master/egs/librispeech/ASR/RESULTS.md#librispeech-bpe-training-results-pruned-stateless-transducer-4


CCSD with custom Hamiltonian and mo_energies

As far as I understand, inside CCSD there is always a recalculation of the SCF and the energies of the molecular orbitals, which are necessary to perform CCSD cycles (denominator calculations). I would like to bypass the SCF calculations inside CCSD again by simply sending the already known result to the input
mf = scf.RHF(mol)
mf.mo_coeff = C_new
mf.mo_energy = E_new
mf.e_tot = E_tot_new  --> let say  C_new,  E_new and E_tot_new are calculated by another program
--> Below I define custom hamiltonian:
mf.get_hcore = lambda *args: F_new
mf.get_ovlp  = lambda *args: S_new
mf._eri      = ao2mo.restore(1, eri_new, mol.nao)
--> If I now do mf.kernel() I get new C'_new, E'_new and  E'_tot_new which differs from C_new, E_new and  E_tot_new but I want to avoid this.
--> Perform the CCSD calculation using the new mean-field object
mycc = cc.RCCSD(mf, frozen = None, mo_coeff = C_new, mo_occ = mf.mo_occ) --> just in case, I’m once again sending new coefficients to the arguments, but not new mo_energies E_new since there is no corresponding attributes (and it seems that CCSD just calculates them inside starting new SCF cycle which as I said above gives incorrect E'_new for my particular case)
mycc.kernel()
In other words, I just want to run RCCSD with predefined parameters, without any recalculation inside. Maybe it's possible to somehow assign new values to variables globally?

It doesn't do an entire SCF iteration; just one Fock build and sets mo_energy to the diagonal elements. I don't think it changes the MO coefficients or the SCF total energy. I think the member function you want to interdict is ao2mo:
class myCCSD (mycc.__class__):
    def ao2mo (self, mo_coeff=None):
        eris = super ().ao2mo (mo_coeff=mo_coeff)
        eris.mo_energy = my_mo_energy
        return eris
from pyscf import lib
my_patched_cc = lib.view (mycc, myCCSD)
my_patched_cc.kernel ()


TypeScript improvements for IDEs

This PR will:

enable generating typings files in /dist
set the main property of package.json to ./dist/BunqJSClient.js
set the types property of package.json to ./dist/BunqJSClient.d.ts and removes the typings as they are interchangeable.
prevent committing build files to git by adding /dist to .gitignore, this prevents cluttering commits with build files
prevent publishing source files to npm by adding /src to .npmignore this keeps download size while installing the package low
moves @types/* dependencies to devDependencies because they are only needed during development

Thanks 👍 I have some basic Typescript experience but setting up the  types correctly was giving me a ton of issues when I tried it early on.

This should enable support for auto complete in VSCode and other editors.
You may also want to move @babel/* to devDependencies. As far as I know they also only needed for building.

Will you publish to npm or should I install from the repo for now?

I'll publish it now 👍

I think you forgot to build before publishing

Should be good now on 0.35.2, it looks like the npmignore file also needs to include a bunch of the files/folders listed in the gitignore file.


Does not compile on Linux due to missing modules

Expected Behavior
game-scanner should build on Linux with no issues.
Current Behavior
There are missing modules and other implementations (due to the use of cfg os-gating) that are not available on Linux:
error[E0583]: file not found for module `utils`
  --> /home/philpax/.cargo/registry/src/github.com-1ecc6299db9ec823/game-scanner-1.1.2/src/epicgames/mod.rs:14:1
   |
14 | mod utils;
   | ^^^^^^^^^^
   |
   = help: to create the module `utils`, create file "/home/philpax/.cargo/registry/src/github.com-1ecc6299db9ec823/game-scanner-1.1.2/src/epicgames/utils.rs" or "/home/philpax/.cargo/registry/src/github.com-1ecc6299db9ec823/game-scanner-1.1.2/src/epicgames/utils/mod.rs"

error[E0583]: file not found for module `utils`
  --> /home/philpax/.cargo/registry/src/github.com-1ecc6299db9ec823/game-scanner-1.1.2/src/gog/mod.rs:10:1
   |
10 | mod utils;
   | ^^^^^^^^^^
   |
   = help: to create the module `utils`, create file "/home/philpax/.cargo/registry/src/github.com-1ecc6299db9ec823/game-scanner-1.1.2/src/gog/utils.rs" or "/home/philpax/.cargo/registry/src/github.com-1ecc6299db9ec823/game-scanner-1.1.2/src/gog/utils/mod.rs"

(so on and so forth, there's more errors like this)
Possible Solution
Implement the relevant utils for Linux, or disable these modules on Linux.
Steps to Reproduce (for bugs)
Try to build game-scanner by itself, or as a dependency, on x86-64 Linux.
Context
Was just testing my existing code on Linux and noticed this. Not at all an issue - going to be running in Wine anyway - but I figured it was worth calling out. For now, I'm only including game-scanner on Windows as a workaround.
Your Environment

Version used: 1.1.2
Operating System and version: Arch Linux, HEAD all packages

@philpax fixed on v1.1.3

Awesome, nice work with both issues! 🎉


Using Telemetry - track event -> Fails to start bot

Version: 1.3.0
When using the Telemetry - track event action the bot fails to start (both a fresh bot and one with custom runtime) throwing the error:
Unhandled exception. System.Exception: hrempower.dialog error: Type Microsoft.TelemetryTrackEvent not registered in factory. ---> System.ArgumentException: Type Microsoft.TelemetryTrackEvent not registered in factory

Known issue: https://github.com/microsoft/BotFramework-Composer/issues/4305 https://github.com/microsoft/BotFramework-Composer/issues/5400
Workaround:
Change
"$kind": "Microsoft.TelemetryTrackEvent",
To
"$kind": "Microsoft.TelemetryTrackEventAction"
This should have been fixed though: https://github.com/microsoft/botbuilder-dotnet/pull/4778
@luhan2017 Any insight?

Known issue: https://github.com/microsoft/BotFramework-Composer/issues/4305 https://github.com/microsoft/BotFramework-Composer/issues/5400
Workaround:
Change
"$kind": "Microsoft.TelemetryTrackEvent",
To
"$kind": "Microsoft.TelemetryTrackEventAction"
This should have been fixed though: https://github.com/microsoft/botbuilder-dotnet/pull/4778
@luhan2017 Any insight?

Sorry didn't read the comment fully. This is not included in 4.11.0.

Sorry didn't read the comment fully. This is not included in 4.11.0.

@dmvtech ahh, I searched for an issue first, but see the other ones are closed already? For next time, when are bugs actually closed?

@dmvtech ahh, I searched for an issue first, but see the other ones are closed already? For next time, when are bugs actually closed?

@cxbuilders I'll defer to @cwhitten
But I think the issues opened in this repo were closed as the issue was found to be in the dotnet library and bug opened there for tracking alone.

@cxbuilders I'll defer to @cwhitten
But I think the issues opened in this repo were closed as the issue was found to be in the dotnet library and bug opened there for tracking alone.


Add an additional method

Promise lacks an unified operation method
Core:
Promise.prototype.unified = function (callback) {
  this.then(
    data => {callback(true, data)},
    data => {callback(false, data)}
  )
}

Use:
let promise = new Promise(function(resolve, reject) {
  if (false){
    setTimeout(() => resolve('success'), 1000)
  } else {
    setTimeout(() => reject('error'), 1000)
  }
})

promise.unified((state, data) => {
  const msg = state ? 'operation successful' : 'operation failed'
  console.log(
    state,
    data,
    msg
  )
})

If it was before, then it should be done:
let promise = new Promise(function(resolve, reject) {
  if (false){
    setTimeout(() => resolve('success'), 1000)
  } else {
    setTimeout(() => reject('error'), 1000)
  }
})

promise.then((data) => {
  console.log(
    state: true,
    data: data,
    msg: 'operation successful'
  )
}).catch((data) => {
  console.log(
    state: false,
    data: data,
    msg: 'operation failed'
  )
})

It is less coordinated to do this, I think it would be better to add the unified method

if resolve and reject handle almost the same. I think this is very necessary. Because it can simplify a lot of unnecessary code.
Translation for Google. It may not be very well worded. Please forgive me.


Improve coverage of Hash schemas

I'd like to refactor the code in #134 to reduce the massive duplication but the coverage doesn't seem to be great. I'm going to try to add tests and kill dead code in this PR first so that the subsequent refactor is less painful

I'm not sure how to test the behavior provided by Class here: https://github.com/dry-rb/dry-types/blob/fix/hash_schema-coverage/lib/dry/types/hash.rb#L10

Alrighty the hash schemas are now 100% mutation covered.

@solnic options preservation resolved

Looks like there are conflicts with master

@solnic Fixing

@solnic rebased


Introduce ReadPasswordWithContext

Introduced the ReadPasswordWithContext function that allows to read a password from the terminal with support for cancellation. This is a suggestion to address https://github.com/golang/go/issues/31180.
This is a work-in-progress PR for collecting the first feedback. Please do not merge!

Hey there, this PR is an attempt to resolve https://github.com/golang/go/issues/31180. The current state is notready but I'd like to collect the first feedback, if this the idea is in principle worth following up and if someone has a bett
er approach to resolve the issue.
Two notes on this PR:

The Windows version does not work currently and I'm stuck there. The used f := os.NewFile(uintptr(h), "stdin") construct is not closeable and AFAICS does Windows not support nonblocking IO access to the terminal. Any suggestion on how
to unblock this is more than welcome
The Unix reader works by nonblocking UI and polling, which is not ideal. If anyone has an idea for an alternative approach ...


add child process to nuxt generate

Inspired from https://github.com/nuxt/nuxt.js/issues/746
as one thread process can reference this
https://github.com/nuxt/nuxt.js/pull/748
tested on my 8T cpu 500 routes
with default html minify
60.4s -> 23s
without html minify
31.8s -> 12.7s

child_process is working fine on my computer .
but seems like integration to nuxt.js project and pass the test is not easy .
maybe I need more study can do this.
now is great day for prepare release nuxt.js 1.0  🎉
I don't want let this bother anyone  😆
anyway , multi-thread generate is really charming .

It was actually a good idea @ausir0726 !
The problem was this line: https://github.com/nuxt/nuxt.js/pull/751/files#diff-68a0d308439cd684654928d794824375R106
Let's say a user defined a script "gen" which run "nuxt generate", when launching nuxt generate, it will fail since npm run generate does not exists.

But I believe that this feature could be a Nuxt.js module :+1:
Something like nuxt-generate-cluster


Issue #295: Add 'Absorb Merged Packages' to 'ZDL Tools' popup

new eclipse command
new command handler implementation
new eclipse menu contribution
most business logic is in AbsorbMergedPackagesWorker.java
separate worker allows for re-use in older Eclipse 'action sets'

Fixed by #304


AsyncFtpClient is disposed off before other methods can execute

FTP Server OS: Unix / Windows / Embedded
FTP Server Type: Vsftpd / glFTPd / BFTPd / ProFTPD / Pure-FTPd / IBM CS FTP (z/OS, OS/400) / Windows CE / Windows Server IIS / Vax / VMS / OpenVMS / Tandem / HP NonStop
Client Computer OS: Windows / Ubuntu / Debian / Linux Mint / Arch Linux
FluentFTP Version: ?
Framework: .NET 2 / 3.5 / 4 / 5 / 6 / 7 / 8 / UWP / Xamarin / Mono
<write details about your bug report / feature request here>
Logs :

<paste VERBOSE logs here>

Used:
C# 12 .Net 8.07
Unix FTP server.

Hallo Robin,
Thanks for your reaction.
Herewith a minimal sample to illustrate/reproduce the problem.
I am a little bit puzzled about this hopefully there is a simple explanation what I am doing wrong or don’t understand.
Tools used

Windows 11 pro build 22631.4037
Visual Studio 2022 version: 17.11.1
C# 12
.Net 8.07 -> Winforms application <-
FluentFTP ver 49.0.1 and 51.0.0
Host FTP server linux

--------------------------------------------------- Minimal source code  sample ----------------------------------------------------------------
The source code that is not returning to the caller (FluentFTP ver: 51.0.0) but is running fine with FluentFTP ver: 49.0.1
// ==============================  Caller ================================
private async void Form1_Load(object sender, EventArgs e)
{
var ftpClient = new FTPClientAsync(host, userName, password);
  if (await ftpClient.LoggedInAsync())
  {
        var a = 1; // This line is executed in the debugger(FluentFTP ver: 49.0.1) This line is never executed (FluentFTP ver: 51.0.0)
  }
  else
  {
        var b = 1; // This line is never executed in the debugger (FluentFTP ver: 49.0.1) because login credentials are OK

  }

}
// ==============================  CLASS ================================
using FluentFTP;   // Implement FluentFTP (reason: starting with ".Net version 9.0" support for FtpWebRequest will be dropped
namespace FTPTest;
public class FTPClientAsync(string hostIP, string userName, string password)
{
private readonly string hostIP = hostIP;
private readonly string userName = userName;
private readonly string passWord = password;
  public async Task<bool> LoggedInAsync()
  {
        var token = new CancellationToken();
        using var ftp = new AsyncFtpClient(this.hostIP, this.userName, this.passWord);
        await ftp.Connect(token);

        if (ftp.IsConnected)
        {
              return true;   // This line is executed in de debugger but no return to the caller (FluentFTP ver: 49.0.1 and FluentFTP ver: 51.0.0)

        }
        else
        {
              return false;
        };
  }

}
Kind Regards
Gijs Wassink
From: FanDjango @.>
Sent: dinsdag 20 augustus 2024 20:03
To: robinrodricks/FluentFTP @.>
Cc: Gijs Wassink @.>; Author @.>
Subject: Re: [robinrodricks/FluentFTP] After update to 5.1 Async methods does not return to the caller (same source code) (Issue #1634)
Async methods does not return to the caller
Due to information overload from your issue description, I am unable to help you.
—
Reply to this email directly, view it on GitHubhttps://github.com/robinrodricks/FluentFTP/issues/1634#issuecomment-2299438007, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALWRO3UJAGIGYWPW6GGW2I3ZSOADNAVCNFSM6AAAAABMZ2FGKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJZGQZTQMBQG4.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Hallo Robin,
Thanks for your reaction.
Sorry I made a mistake in the previous e-mail please discard.
Herewith a minimal sample to illustrate/reproduce the problem.
I am a little bit puzzled about this hopefully there is a simple explanation what I am doing wrong or don’t understand.
Tools used

Windows 11 pro build 22631.4037
Visual Studio 2022 version: 17.11.1
C# 12
.Net 8.07 -> Winforms application <-
FluentFTP ver 49.0.1 and 51.0.0
Host FTP server linux

--------------------------------------------------- Minimal source code  sample ----------------------------------------------------------------
The source code that is not returning to the caller (FluentFTP ver: 51.0.0) but is running fine with FluentFTP ver: 49.0.1
// ==============================  Caller ================================
private async void Form1_Load(object sender, EventArgs e)
{
var ftpClient = new FTPClientAsync(host, userName, password);
  if (await ftpClient.LoggedInAsync())
  {
        var a = 1; // This line is executed in the debugger(FluentFTP ver: 49.0.1) This line is never executed (FluentFTP ver: 51.0.0)
  }
  else
  {
        var b = 1; // This line is never executed in the debugger (FluentFTP ver: 49.0.1) because login credentials are OK

  }

}
// ==============================  CLASS ================================
using FluentFTP;   // Implement FluentFTP (reason: starting with ".Net version 9.0" support for FtpWebRequest will be dropped
namespace FTPTest;
public class FTPClientAsync(string hostIP, string userName, string password)
{
private readonly string hostIP = hostIP;
private readonly string userName = userName;
private readonly string passWord = password;
  public async Task<bool> LoggedInAsync()
  {
        var token = new CancellationToken();
        using var ftp = new AsyncFtpClient(this.hostIP, this.userName, this.passWord);
        await ftp.Connect(token)<ftp://ftp.Connect(token)>;

        if (ftp.IsConnected<ftp://ftp.IsConnected>)
        {
              return true;   // This line is executed in de debugger but no return to the caller (FluentFTP ver: 51.0.0)

        }
        else
        {
              return false;
        };
  }

}
Kind Regards
Gijs Wassink
From: FanDjango<EMAIL_ADDRESS>Sent: dinsdag 20 augustus 2024 20:03
To: robinrodricks/FluentFTP<EMAIL_ADDRESS>Cc: Gijs Wassink<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [robinrodricks/FluentFTP] After update to 5.1 Async methods does not return to the caller (same source code) (Issue #1634)
Async methods does not return to the caller
Due to information overload from your issue description, I am unable to help you.
—
Reply to this email directly, view it on GitHubhttps://github.com/robinrodricks/FluentFTP/issues/1634#issuecomment-2299438007, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALWRO3UJAGIGYWPW6GGW2I3ZSOADNAVCNFSM6AAAAABMZ2FGKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJZGQZTQMBQG4.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

It just hangs? How long did you wait? Can you post a verbose log?

With version: 49.01 it return within a second with 51.0.0 I wait more than 30 seconds.
Sent from Outlook for iOShttps://aka.ms/o0ukef

From: FanDjango @.>
Sent: Tuesday, August 20, 2024 10:48:01 PM
To: robinrodricks/FluentFTP @.>
Cc: Gijs Wassink @.>; Author @.>
Subject: Re: [robinrodricks/FluentFTP] After update to 5.1 Async methods does not return to the caller (same source code) (Issue #1634)
It just hangs? How long did you wait? Can you post a verbose log?
—
Reply to this email directly, view it on GitHubhttps://github.com/robinrodricks/FluentFTP/issues/1634#issuecomment-2299737015, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALWRO3TMVSEAWWWB27KZUVTZSOTQDAVCNFSM6AAAAABMZ2FGKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJZG4ZTOMBRGU.
You are receiving this because you authored the thread.Message ID: @.***>

Ok, I would like a log, verbose, from the PWD command to the end. I want to see the dispose/close async logic...

Note that your
 using var ftp = new AsyncFtpClient(this.hostIP, this.userName, this.passWord);
client gets disposed as part of the return. Which means it gets closed, connection disconnected.

If it worked before, it was because much of the async disconnect/close/dispose logic ran as sync and not async.
We will find out more tomorrow.

public async Task<bool> LoggedInAsync()
{
	var token = new CancellationToken();

------>	using var ftp = new AsyncFtpClient(this.hostIP, this.userName, this.passWord);
await ftp.Connect(token);
	if (ftp.IsConnected)
	{
		return true;   // This line is executed but no return to the caller
	}
	else
	{
		return false;
	};
}

Correct: If I remove the ------> using then it returns normal (no hanging)

Well, I think what is happening, is that the real intensive cleanup of sync/async close/disconnect/dispose is showing up "unclean" code (in FluentFTP, "mis"used in users code) - so you are unfortunately a victim.
If you now look at the log, you will see that after the return, there is no more client, no more connection, no nothing for you to continue working with (if that is your intent).

Also, with .NET 8, you would use:
await using(...............) {

}

public async Task LoggedInAsync()
{
var token = new CancellationToken();
await using var ftp = new AsyncFtpClient(this.hostIP, this.userName, this.passWord);
await ftp.Connect(token);
if (ftp.IsConnected)
{
	return true;   // This line is executed but no return to the caller
}
else
{
	return false;
};

}
I think this is also working-:)
With this knowledge I will now implement the other methods I have.
Thank you very much for the support is a great help.

Look, I cannot reproduce it. I tried this:
		static void My_SmallUploadBytes_Test() {
			bool b = My_SmallUploadBytes_Test1Async().GetAwaiter().GetResult();   <---- I get bool b returned no problem
		}

		static async Task<bool> My_SmallUploadBytes_Test1Async() {
			using var client = new AsyncFtpClient("ftps", "bla", "blabla");
			client.Config.EncryptionMode = FtpEncryptionMode.Explicit;
			client.Config.DataConnectionType = FtpDataConnectionType.PASV;
			client.Config.DownloadDataType = FtpDataType.Binary;
			client.Config.ValidateAnyCertificate = true;
			client.Config.Noop = true;
			client.Config.NoopInterval = 750;
			client.Config.NoopTestConnectivity = false;

			client.Config.Navigate = FtpNavigate.SemiAuto;

			await client.Connect();

			if (client.IsConnected) {
				Console.WriteLine("HERE THE RETURN STATEMENT IS executed");
				return true;
			}
			else {
				return false;
			}
		}

Even without the await for the using.
>         Connect(False)
Status:   FluentFTP <IP_ADDRESS>(.NET 5.0) AsyncFtpClient
Status:   Connecting(async) AsyncFtpClient.FtpSocketStream(control) IP #1 = ***:21
Status:   Waiting for a response
Response: 220 ProFTPD Server (Debian) [::ffff:<IP_ADDRESS>] [739118,57d]
Status:   Detected FTP server: ProFTPD
Command:  AUTH TLS
Status:   Waiting for response to: AUTH TLS
Response: 234 AUTH TLS successful [2ms]
Status:   FTPS authentication successful, lib = .NET SslStream, cipher suite = Tls12 (Aes256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, 44550, 255) [95ms]
Command:  USER ***
Status:   Waiting for response to: USER ***
Response: 331 Password required for *** [2ms]
Command:  PASS ***
Status:   Waiting for response to: PASS ***
Response: 230 User *** logged in [42ms]
Command:  PBSZ 0
Status:   Waiting for response to: PBSZ 0
Response: 200 PBSZ 0 successful [<1ms]
Command:  PROT P
Status:   Waiting for response to: PROT P
Response: 200 Protection set to Private [1ms]
Command:  FEAT
Status:   Waiting for response to: FEAT
Response: 211-Features:
Response: AUTH TLS
Response: CCC
Response: CLNT
Response: CSID
Response: EPRT
Response: EPSV
Response: HASH CRC32;MD5;SHA-1*;SHA-256;SHA-512;
Response: HOST
Response: LANG en-US.UTF-8*;en-US
Response: MD5
Response: MDTM
Response: MFF modify;UNIX.group;UNIX.mode;
Response: MFMT
Response: MLST modify*;perm*;size*;type*;unique*;UNIX.group*;UNIX.groupname*;UNIX.mode*;UNIX.owner*;UNIX.ownername*;
Response: PBSZ
Response: PROT
Response: RANG STREAM
Response: REST STREAM
Response: SITE COPY
Response: SITE MKDIR
Response: SITE RMDIR
Response: SITE SYMLINK
Response: SITE UTIME
Response: SIZE
Response: SSCN
Response: TVFS
Response: UTF8
Response: XCRC
Response: XMD5
Response: XSHA
Response: XSHA1
Response: XSHA256
Response: XSHA512
Response: 211 End [5ms]
Status:   Text encoding: System.Text.UTF8Encoding+UTF8EncodingSealed
Command:  OPTS UTF8 ON
Status:   Waiting for response to: OPTS UTF8 ON
Response: 200 UTF8 set to on [<1ms]
Command:  SYST
Status:   Waiting for response to: SYST
Response: 215 UNIX Type: L8 [<1ms]
Status:   Active ServerHandler is: ProFTPD
Status:   Listing parser set to: Machine
Command:  PWD
Status:   Waiting for response to: PWD
Response: 257 "/home/mike" is the current directory [<1ms]
Status:   NoopDaemon enabled
>         Dispose()
Status:   NoopDaemon(AsyncFtpClient) is initialized, NoopInterval = 1000ms
HERE THE RETURN STATEMENT IS executed
Status:   Warning: sync dispose called for AsyncFtpClient object
>         DisposeAsync()
Status:   Disposing(async) AsyncFtpClient
>         Disconnect()
Command:  QUIT
Status:   Waiting for response to: QUIT
Response: 221 Goodbye. [1ms]
Status:   NoopDaemon disabled
Status:   Disposing(async) AsyncFtpClient.FtpSocketStream(control)
Status:   Disposing(async) AsyncFtpClient.FtpSocketStream(control) (redundant)
Status:   Waiting for Daemon termination(AsyncFtpClient)
Status:   NoopDaemon terminated
Status:   Daemon terminated

See this message: Status:   Warning: sync dispose called for AsyncFtpClient object? This will not happen if you add the await in front of the using. But it still returns fine even without the await.
If you want to debug this further, since you are using an intermediate class, you NEED to console.writeln(...) some messages and also have the FluentFTP log going to console also. You want to look at the sequence of events and especially the "disposing" stuff at the end.

I use a Winforms app not a console app. Is that a crucial difference?
Sent from Outlook for iOShttps://aka.ms/o0ukef

From: FanDjango @.>
Sent: Wednesday, August 21, 2024 3:50:52 PM
To: robinrodricks/FluentFTP @.>
Cc: Gijs Wassink @.>; Author @.>
Subject: Re: [robinrodricks/FluentFTP] After update to 5.1 Async methods does not return to the caller (same source code) (Issue #1634)
Look, I cannot reproduce it. I tried this:
            static void My_SmallUploadBytes_Test() {
                    bool b = My_SmallUploadBytes_Test1Async().GetAwaiter().GetResult();   <---- I get bool b returned no problem
            }

            static async Task<bool> My_SmallUploadBytes_Test1Async() {
                    using var client = new AsyncFtpClient("ftps", "bla", "blabla");
                    client.Config.EncryptionMode = FtpEncryptionMode.Explicit;
                    client.Config.DataConnectionType = FtpDataConnectionType.PASV;
                    client.Config.DownloadDataType = FtpDataType.Binary;
                    client.Config.ValidateAnyCertificate = true;
                    client.Config.Noop = true;
                    client.Config.NoopInterval = 750;
                    client.Config.NoopTestConnectivity = false;

                    client.Config.Navigate = FtpNavigate.SemiAuto;

                    await client.Connect();

                    if (client.IsConnected) {
                            Console.WriteLine("HERE THE RETURN STATEMENT IS executed");
                            return true;
                    }
                    else {
                            return false;
                    }
            }

Even without the await for the using.

    Connect(False)

Status:   FluentFTP <IP_ADDRESS>(.NET 5.0) AsyncFtpClient
Status:   Connecting(async) AsyncFtpClient.FtpSocketStream(control) IP #1 = :21
Status:   Waiting for a response
Response: 220 ProFTPD Server (Debian) [::ffff:<IP_ADDRESS>] [739118,57d]
Status:   Detected FTP server: ProFTPD
Command:  AUTH TLS
Status:   Waiting for response to: AUTH TLS
Response: 234 AUTH TLS successful [2ms]
Status:   FTPS authentication successful, lib = .NET SslStream, cipher suite = Tls12 (Aes256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, 44550, 255) [95ms]
Command:  USER ***
Status:   Waiting for response to: USER ***
Response: 331 Password required for *** [2ms]
Command:  PASS ***
Status:   Waiting for response to: PASS ***
Response: 230 User *** logged in [42ms]
Command:  PBSZ 0
Status:   Waiting for response to: PBSZ 0
Response: 200 PBSZ 0 successful [<1ms]
Command:  PROT P
Status:   Waiting for response to: PROT P
Response: 200 Protection set to Private [1ms]
Command:  FEAT
Status:   Waiting for response to: FEAT
Response: 211-Features:
Response: AUTH TLS
Response: CCC
Response: CLNT
Response: CSID
Response: EPRT
Response: EPSV
Response: HASH CRC32;MD5;SHA-1;SHA-256;SHA-512;
Response: HOST
Response: LANG en-US.UTF-8;en-US
Response: MD5
Response: MDTM
Response: MFF modify;UNIX.group;UNIX.mode;
Response: MFMT
Response: MLST modify;perm*;size*;type*;unique*;UNIX.group*;UNIX.groupname*;UNIX.mode*;UNIX.owner*;UNIX.ownername*;
Response: PBSZ
Response: PROT
Response: RANG STREAM
Response: REST STREAM
Response: SITE COPY
Response: SITE MKDIR
Response: SITE RMDIR
Response: SITE SYMLINK
Response: SITE UTIME
Response: SIZE
Response: SSCN
Response: TVFS
Response: UTF8
Response: XCRC
Response: XMD5
Response: XSHA
Response: XSHA1
Response: XSHA256
Response: XSHA512
Response: 211 End [5ms]
Status:   Text encoding: System.Text.UTF8Encoding+UTF8EncodingSealed
Command:  OPTS UTF8 ON
Status:   Waiting for response to: OPTS UTF8 ON
Response: 200 UTF8 set to on [<1ms]
Command:  SYST
Status:   Waiting for response to: SYST
Response: 215 UNIX Type: L8 [<1ms]
Status:   Active ServerHandler is: ProFTPD
Status:   Listing parser set to: Machine
Command:  PWD
Status:   Waiting for response to: PWD
Response: 257 "/home/mike" is the current directory [<1ms]
Status:   NoopDaemon enabled

    Dispose()

Status:   NoopDaemon(AsyncFtpClient) is initialized, NoopInterval = 1000ms
HERE THE RETURN STATEMENT IS executed
Status:   Warning: sync dispose called for AsyncFtpClient object

    DisposeAsync()

Status:   Disposing(async) AsyncFtpClient

    Disconnect()

Command:  QUIT
Status:   Waiting for response to: QUIT
Response: 221 Goodbye. [1ms]
Status:   NoopDaemon disabled
Status:   Disposing(async) AsyncFtpClient.FtpSocketStream(control)
Status:   Disposing(async) AsyncFtpClient.FtpSocketStream(control) (redundant)
Status:   Waiting for Daemon termination(AsyncFtpClient)
Status:   NoopDaemon terminated
Status:   Daemon terminated
See this message: Status: Warning: sync dispose called for AsyncFtpClient object? This will not happen if you add the await in front of the using. But it still returns fine even without the await.
If you want to debug this further, since you are using an intermediate class, you NEED to console.writeln(...) some messages and also have the FluentFTP log going to console also. You want to look at the sequence of events and especially the "disposing" stuff at the end.
—
Reply to this email directly, view it on GitHubhttps://github.com/robinrodricks/FluentFTP/issues/1634#issuecomment-2302110203, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALWRO3QVCS5CJPBAWUDYSUTZSSLLZAVCNFSM6AAAAABMZ2FGKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBSGEYTAMRQGM.
You are receiving this because you authored the thread.Message ID: @.***>

Try this create a new Winform app target .Net 8.07
Make the Form_Load event like this. Run the app in debug mode and it will HANG
private  async void Form1_Load(object sender, EventArgs e)
{
using var ftp = new AsyncFtpClient(this.hostIP, this.userName, this.password);
await ftp.Connect();
}
This will execute normal no HANGING
private  async void Form1_Load(object sender, EventArgs e)
{
await using var ftp = new AsyncFtpClient(this.hostIP, this.userName, this.password);
await ftp.Connect();
}

I think what's happening in your HANGING example above, is that the AsyncFtpClient is getting disposed before any subsequent operations can occur. So you will need to use await using or else keep a ref to the AsyncFtpClient so it does not get disposed off so quickly.

I am fine to use await in front of the using it solves my problem 😉
Sent from Outlook for iOShttps://aka.ms/o0ukef

From: Robin Rodricks @.>
Sent: Wednesday, August 21, 2024 6:53:17 PM
To: robinrodricks/FluentFTP @.>
Cc: Gijs Wassink @.>; Author @.>
Subject: Re: [robinrodricks/FluentFTP] After update to 5.1 Async methods does not return to the caller (same source code) (Issue #1634)
I think what's happening in your HANGING example above, is that the AsyncFtpClient is getting disposed before any subsequent operations can occur. So you will need to use await using or else keep a ref to the AsyncFtpClient so it does not get disposed off so quickly.
—
Reply to this email directly, view it on GitHubhttps://github.com/robinrodricks/FluentFTP/issues/1634#issuecomment-2302547739, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALWRO3XS2UAPUIKOKIN5YHDZSTAX3AVCNFSM6AAAAABMZ2FGKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBSGU2DONZTHE.
You are receiving this because you authored the thread.Message ID: @.***>

@GW-Lab Good one, I'll try that and investigate, especially on .NET versions that do not yet support "await using".

@robinrodricks And it used to work pre V51, because async dispose was effectively sync, which other users complained about.

So, there was a problem in the dispose code.
@robinrodricks There was a problem in the dispose code. Your explanation end my explanations were wrong. The hang has to do with GetAwaiter().GetResult() on the GUI thread.
The source:
private async void Form1_Load(object sender, EventArgs e)
{
using var ftp = new AsyncFtpClient(this.hostIP, this.userName, this.password);
await ftp.Connect();
}

in a WinForms App will hang exactly on the SYNC dispose of the ASYNC client:
DisposeAsync()..ConfigureAwait(false).GetAwaiter().GetResult(); is a NOGO.

By using "await" this bad code is effectively bypassed, nice workaround. **BUT: This is not available to .NET Framework 4.6.2 and 4.7.2. So... needed fixing.

Good to know.

Thanks for fixing this issue.
When will the fix public available?

@GW-Lab Currently difficult to say. A few things are being worked on at this moment.

@GW-Lab Fix released as Nuget V51.1.0, FYI

Thank you for fixing
Gijs
Sent from Outlook for iOShttps://aka.ms/o0ukef

From: FanDjango @.>
Sent: Friday, September 13, 2024 8:44:45 PM
To: robinrodricks/FluentFTP @.>
Cc: Gijs Wassink @.>; Mention @.>
Subject: Re: [robinrodricks/FluentFTP] AsyncFtpClient is disposed off before other methods can execute (Issue #1634)
@GW-Labhttps://github.com/GW-Lab Fix released as Nuget V51.1.0, FYI
—
Reply to this email directly, view it on GitHubhttps://github.com/robinrodricks/FluentFTP/issues/1634#issuecomment-2349865824, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALWRO3VKJJLPVY5QDYTNIZLZWMXB3AVCNFSM6AAAAABMZ2FGKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBZHA3DKOBSGQ.
You are receiving this because you were mentioned.Message ID: @.***>


Is there a way to run two instances of vite at the same time

I want to develop some react PWAs that all communicate with a single existing web api platform. I would like to build 2 completely separate PWAs that are deployed alongside the current website / apis
I would like to know if this use case is supported in any way?

Hi @james-whittington1. SPAs and PWAs don't need this kind of library. You could use the official templates for SPAs or use the Microsoft.AspNetCore.SpaServices.Extensions for a custom setup.
And if I understood correctly, you want to have two PWAs in a single project? If that's the case I don't think it can be possible. You'd need three projects instead: the API and your two PWAs.

That does sound very obvious now that I think about it.
Let me outline my application a little better though, so that you could better understand what I am hoping to do.
Current platform:
.net core CMS (Umbraco) that is serving a website rendered with razer pages.
The cms has the ability to bind mulitple top level domains, and route these to "sites" (effectivly a page/document created at the root of the content tree, that then has a domain name added to it)
The CMS also has a content delivery api that can be used to fetch content from the CMS as json.
New feature development:
The client wants to host several tools and calculators on this site that should support offline use (hence PWAs).
Ideally I was hoping to run them all from the same project and load the dev environment transparently but I am getting the feeling that this is not a good idea.
Thank you for your time :)

Are you looking for multi-page-app?


[RFE] save button codeLens for the diagnostic rules

Add a codeLens to the diagnostic rules to save the file.
Saving the file should automatically reload it and apply the changes to all the apps and refresh the view

configured in v1.0.0


Urgent Help Please - Task sequence not working with new 4.2.0 ps1 script

Hi All
I am currently testing the latest 4.2.0 ps1 script as I am building new 21H2 images, however the task sequence continuously fails with the script and also does not create the ApplyDriverLog to see what it is failing on.
I have run the script in DebugMode on the same machine being imaged, and the script runs without any errors and also matches a driver package from our SCCM repository.
I have the below parameters set in the task sequence (endpoint replaced with our site server):
-BareMetal -Endpoint "xyz.ac.uk" -TargetOSName "Windows 10" -TargetOSVersion "21H2"
I initially have the driver tool as a nested task sequence in the main task sequences, but I have also tried without but same results.
SCCM produces a very vague log but from there all I can see is the script does start to run but completes with exit code 1 (error), which is odd as it runs fine in debug.
Any ideas on what could be going wrong or things I could check?
Urgent help please as need to roll out 21H2 to over 2000 machines.
Thanks!

I've got this same issue.  I've tried it both ways with single and double quotes, and I cannot figure it out.  Any luck?

Came across this also yesterday when updating on our end. For reference, the use of single quotes for run powershell step is mentioned in the MECM doco - https://docs.microsoft.com/en-us/mem/configmgr/osd/understand/task-sequence-steps#BKMK_RunPowerShellScript

The single quotes were part of my issue.  The other part was I didn't have WinPE-Dot3Svc in my boot image.  Here's the components I have in mine (not just for MDM but also for some other tools) and I was able to get MDM to work:
WinPE-DismCmdlets
WinPE-Dot3Svc
WinPE-HTA
WinPE-StorageWMI
WinPE-NetFx
WinPE-PowerShell
I haven't been able to find this referenced in the MDM documentation anywhere, as to what Optional Components should be in our boot images to make it work.  Am I missing something?

I don’t think we had to add anything extra from what we were already using, it has been a while since we first set it up though.
If I remember I’ll check what we have enabled in our boot image on Monday. The definite thing you would need is the winpe-powershell.


fix Pylance error in teardown_appcontext

https://github.com/Ar-Kareem/pdf-mobile-integration/blob/bc630edb346fdad8945e535a5978e25d14409904/backend/app/base/appSetup.py#L121
Pylance showing error:
Argument of type "(_: BaseException | None) -> None" cannot be assigned to parameter "f" of type "TeardownCallable" in function "teardown_appcontext"
  Type "(_: BaseException | None) -> None" cannot be assigned to type "TeardownCallable"
    Function return type "None" is incompatible with type "Response"
      Type "None" cannot be assigned to type "Response"PylancereportGeneralTypeIssues

The lambda apperantly show return a Response object whatever that is, should search what teardown_appcontext accepts as input and how that might change the behaviour


Fix package paths for OSX and Ubuntu.

Fixes #477
cc @Eilon @mikeharder @mlorbetske

What is the customer impact of this change?  Why do the tests fail sometimes (but not always) without this change?

There should be no customer impact because of this.
Without this change, I have noticed that the package created on OSX has the templates included in a flat directory structure as

instead of being like this:

On windows the package paths are fine with the existing includes.

@Eilon or @muratg: What do you think of this change for Preview1?

@prafullbhosale: Can you clarify how there is no customer impact?  If there's no customer impact to these test failures, why are the tests being run at all?

Can you clarify how there is no customer impact?

Let me rephrase, if we build and publish packages on the nuget feeds only from windows, there is no impact as the packages generated on windows with or without this change are the same.
This looks to me like an inconsistency in pack behavior in windows vs OSX.
The tests that are failing are E2E tests that use newly generated packages from the specific build. On OSX, the packages without this change had an incorrect layout of template files. (see above screenshots).
To be absolutely clear, there will be a customer impact without this change. It will be seen if the user builds the repo on mac and uses the packages generated from that build.

Spoke with @Eilon offline on this.
Will merge this and file another bug to investigate why this started to break recently.


wrong index of inter-ocular in pose_reconstruction_error?

Hi shrubb, good to see you again.
In pose_reconstruction_error ,
the landmark distance is normalized by inter-ocular distance.
pose_reconstruction_error compute_pose_identity_error.py,
def pose_reconstruction_error(gt_landmarks, our_landmarks, apply_optimal_alignment=False):
    assert gt_landmarks.shape == (len(IDENTITIES), NUM_VIDEO_FRAMES, 68, 2)
    assert our_landmarks.shape == gt_landmarks.shape

........

    interocular = np.linalg.norm(gt_landmarks[:, :, 36] - gt_landmarks[:, :, 45],
axis=-1).clip(min=1e-2)
    normalized_distances = np.linalg.norm(gt_landmarks - our_landmarks, axis=-1) / interocular[:, :, None]
    return normalized_distances.mean()

but, according to the landmark index,

I think the distance between (index 36 - index 45) is not inter-ocular distance.
maybe (index 39 - index 42) i guess??

Your index starts from 1, which is wrong. The correct index (check the MEAN_FACE variable) starts from 0 and is

I totally made a poor mistake LOL.....
thank you shurrb


Predictive Maintenance Equipment Instruments

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : Predictive Maintenance Equipment Instrument
:red_circle: Aim : To check the maintenance of Equipment in Instrument Power Plant
:red_circle: Dataset :
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name : Neal Gandhi
GitHub Profile Link : https://github.com/ldneal
Participant ID (If not, then put NA) : Contributor
Approach for this Project : Own SSOC
What is your participant role? (Mention the Open Source Program name. Eg. HRSoC, GSSoC, GSOC etc.)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Sir I want to be work in this project would you assign me

You are already assigned to an issue. Please complete that one first.

Ok Sir

@abhisheks008 If this issue is still available, I would like to work on it.
Since there is no dataset associated with this issue, I suggest this one: Predictive Maintenance Dataset (AI4I 2020)
Full name: Siddhant Tiwari
GitHub profile link: https://github.com/siddhant4ds
Participant ID: sid4ds (Devfolio), sid4ds (Discord)
Participant role: SSOC-3 Contributor
Approach:

EDA and preprocessing of the dataset to make it usable for different ML models
Models implemented - linear models, SVM, RandomForest, Gradient Boosting trees (XGBoost, LightGBM), Neural networks (MLP)
After all models are implemented, try ensembling methods like weighted-averaging and hill-climbing to improve performance.
Will try SOTA/experimental models like TabPFN.

Assigned @siddhant4ds


I have a one question.

Do you have a any plan about build your AI using OpenCL?
I heard that you can build the OpenCL version using tensorflow-cl.
I hope that the OpenCL version will be distributed with the Windows version.
Thx.

I have no plan to develop with OpenCL, but am preparing for the Windows version with CUDA.
Of course, anyone is free to develop AQ using OpenCL.


Jc/fixcatch

This PR addresses the issue that can cause two isolate crashers: trying to send a 500 response after a response has already been sent and logging after closing a response doesn't crash in strange circumstances.

👍


Backend Support for Label-Specific Grouping

Done with https://github.com/ChrizZz110/temporal_graph_explorer/pull/6


Add launch and build task for VS Code

This allows building and running by hitting F5 in VS Code (Windows only for now).

Thanks for the contribution!


feat: update min gas prices on arabica/mocha

Matches https://github.com/cosmos/chain-registry/pull/3239

Is this meant to remain is draft state? Or is it ready now?

yep! for now. I'd like to make sure this is live on Mocha before making the change cc @YazzyYaz

ready to review now @JeremyParish69. thank you, as always!


Ledger intergration

looking for some code to nit pick to challenge my self to add to Cosmverse. :)

f0bad9d2f774494944e7d8fbad4d010ea6e139cd can resolve this.

@giansalex fixed this issue


[Video] Refactor HLS logic

Gets rid of the second effect.
Test Plan
Same as https://github.com/bluesky-social/social-app/pull/5430.
I have not actually tested myself properly.

https://social-app-pr-5468.onrender.com/profile/phantasmajones.net/post/3l4tkpes56w22 works for me (it loops properly and the quality is good).


Add support for precision for TIMESTAMP W/TZ in Postgresql type mapping

Relates to https://github.com/prestosql/presto/pull/4570

AC

@findepi I reworked testing towards what we discussed


Application flush

Improves flushing of application/container.
Reduces memory usage in tests by several percent.

Please send to master. :)


[hotfix][task] Add task name to BufferDebloater logging

This is a simple hotfix improving debug logs for BufferDebloater
Verifying this change
No changes in tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks for the review, test failures are unrelated with pre-existing tickets. Merging.


Create ExecutionTimeSelectionSort.c

Added=>Algo=>SelectionSort=>ExecutionTimeSelectionSort
Assigned Issue Number ?
#1472
Language Opted ?
C
Number of files added or updated ?
1
Name of these files ?
Algorithm => Sort_Algorithm => Selection_Sort => ExecutionTimeSelectionSort.c
Checklist

[x] I've read the contribution guidelines.
[x] I've referred the correct issue number.
[x] I've fill up this entire template correctly.

Invalid PR :warning:

Invalid PR ⚠

why??


add platform folder

Codecov Report

Merging #333 (c927bdb) into main (39e611b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #333   +/-   ##
=======================================
  Coverage   71.57%   71.57%
=======================================
  Files         180      180
  Lines        7255     7255
  Branches      548      548
=======================================
  Hits         5193     5193
  Misses       1930     1930
  Partials      132      132

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e611b...c927bdb. Read the comment docs.


Bug: I noticed that Obsidian was freezing on the trait text.

[ X ] I have verified that I am on the latest version of the Linter

Describe the Bug
I was using Obsidian and noticed that my app kept freezing. I started by disabling all plugins and found that the freezing was caused by the Linter plugin. I also found that this happened all the time under certain circumstances.
How to Reproduce
Steps to reproduce the behavior:

Example to reproduce issue with
---
tags: []
title: Bug Reproduce
date created: 2023-10-28T02:29:30
date modified: 2023-10-28T02:30:36
---
- Hi. This is a note to reproduce the bug.
- There must be at least one bullet point.

- Add an empty line and write one or more bullet points again like this.
- Then run the linter plugin and the Obsidian app should freeze.

Expected Behavior
In short, your Obsidian app will freeze.
Device

[x] Desktop: Silicon mac
[ ] Mobile (I haven't tried it on mobile.)

Could you prived your data.json, @wangyu92 ? I know there are some situations that the Linter does not handle the best.

Hey @wangyu92 , could you provide your data.json? Without it, I may not be able to address this potential issue.

I am guessing this is caused by the Linter not using workers to Lint files. However without your data.json @wangyu92 , I will not be able to look into exactly what is causing the problem since I cannot reproduce locally with just the info provided.

I really sorry for too late reply. I upload data.json file.
data.json

Sorry about the delay in responding. Could you try out the following main.zip by unzipping its contents and copying the main.js file to <vault_base>/.obsidian/plugins/obsidian-linter? This could have been related to the Live Preview issues since I see that you are using live preview.
Here is the main.zip:
main.zip
If you are not able to test it manually, the change for Live Preview should go out with the next release.


Update workshopper-adventure to v4.2.x

See issue #16 for more details on workshopper-adventure interface changes.

Essentially, this:
workshopper({
    name        : 'learn-sass'
  , title       : 'Learn SASS'
  , exerciseDir : path.join(__dirname, 'exercises')
  , appDir      : __dirname
  , languages   : ['en', 'it', 'pt-br']
})

turns to:
workshopper({
    name        : 'learn-sass'
  , title       : 'Learn SASS'
  , exerciseDir : path.join(__dirname, 'exercises')
  , appDir      : __dirname
  , languages   : ['en', 'it', 'pt-br']
}).execute()

Further changes:

Switch to binary executable under bin/ (see learnyounode)
Use workshopper-adventure-test to run tests
Integrate with Travis CI

Also: you can remove the name from the specification object (it will be automatically loaded from the package.json)

Cool, will do.

Done with #29.


Support OAuth authentication for Big Query

Description
Support OAuth authentication for Big Query
Related Issue(s)
closes #420
Breaking Change?
None
Checklist

[ ] I have made corresponding changes to the documentation (if required)
[X] I have added tests that prove my fix is effective or that my feature works

@jlaneve The tests are failing with:
[2023-08-02 09:29:21,675] {graph.py:185} INFO - Skipping line:   Env var required but not provided: 'POSTGRES_HOST'

This PR does not alter anything related to POSTGRES_HOST. I can see the same issue in another PR's check as well.
I can see the errors when I run the tests against the main branch on my local as well 😞
Are you aware of a test bug of some sorts that has creeped in and if there is a PR already in the work for the same?
Thanks!

@jlaneve The tests are failing with:
[2023-08-02 09:29:21,675] {graph.py:185} INFO - Skipping line:   Env var required but not provided: 'POSTGRES_HOST'

This PR does not alter anything related to POSTGRES_HOST. I can see the same issue in another PR's check as well. I can see the errors when I run the tests against the main branch on my local as well 😞
Are you aware of a test bug of some sorts that has creeped in and if there is a PR already in the work for the same?
I hope I am missing something obvious 😢
Thanks!

Unfortunately this is a known issue when there are PRs from forked repos because CI secrets don’t get set. As long as the unit tests and pre-commit checks pass, we can merge this! It looks like there’s just one minor issue with the pre-commit checks - one of the lines is too long


ARROW-11466: [Go][Flight] adding Basic Auth handling for go flight client and server

Adding support for more header based authentication in Flight server and clients.

Base64 encoded username/password auth
Bearertoken receiving and population of context metadata
Unit tests

I'm just gonna tag the ppl i've interacted with before / have gotten merged by before in order to get some attention on this.
@wesm @xhochy @sbinet
Thanks!


Fixed issue with fragments being dirty after store.push

Refs #164
Closes #165

Thank you!!! I tried this patch out and it does fix our bug. :beers:

I couldn't believe 14 days had passed since your PR... sorry about that. Thanks for submitting the failing test, you're my hero :dolphin:
I need to fix CI before I merge this, which is failing because bower is installing ED v2.2.0, which introduced incompatibilities.

I couldn't believe 14 days had passed since your PR... sorry about that.

No worries at all! I know that goes :).


[Query]  “Raise Account Send Limit” option is not displayed when user navigates to “Help” screen from Hamburger menu.

Frequency: 100%
Repro on build version: App store build V1.21.0, Test flight Build V1.21.0, V1.20.4, Android Internal Build V1.21.0, Android Play store Build V1.20.4
Repro on devices: Redmi Note 8 (9.0), iPhone 12 (15), Redmi Note 8 (10.0), iPhone XR (14.4.2)
Pre-condition:

User must have installed the app and completed onboarding flow.
User must be on home screen.

Repro Steps:

Tap & open Hamburger menu from Home screen.
Tap on “Help” option from hamburger menu & Observe

Current Behavior: “Raise Account Send Limit” option is not displayed when user navigates to “Help” screen from Hamburger menu.
Expected Behavior:“Raise Account Send Limit” option must be displayed when user navigates to “Help” screen from Hamburger menu.
Impact: Bad user experience.

The daily transaction limit in the help menu has been removed by https://github.com/valora-inc/wallet/pull/1315.

Thankx for confirmation:)

https://valora.testquality.com defect D651.


[Scroll] MatSelect Options scroll over other elements.

Reproduction
Steps to reproduce:

Visit https://material.angular.io/components/select/examples
Click on a select (the options dialog should open)

Scroll your screen with the mousewheel outside of the options without clicking
Options schould stay visible while screen scrolls

Expected Behavior
Options close once the Select Element is out of the ViewPort and should most definetly not overlay other components.
I feel like there should be a trigger that checks whether the select field should be visible i.e. is in viewport and not overlayed by another component and close the options in that case.
Actual Behavior
Options stay open and even block the header.
Environment

Angular: 8.2.
CDK/Material: MatSelect
Browser(s): Chrome, Internet Explorer 10, Edge
Operating System (e.g. Windows, macOS, Ubuntu): Windows 10

This behaviour looks quite ugly in my app and I am struggling to come up with a clean and performance friendly solution to my problem, since I don't really want to flood my app with .getBoundingClientRect() calls.
Any advice?

(revisiting older issues as part of a triaging fix-it)
@BantramFidian by default MatSelect disabled page scroll while open. How are you making the page scroll here?

Closing because this issue has been inactive for 2 weeks or more after follow up was requested.


Security Policy reporting strategy is insecure

https://github.com/Synergile/Synergile/blob/df03328c3ec560d5bd782bf362f2feee339ca3ed/SECURITY.md#L8
Creating a new issue is publicly visible, which isn't ideal for security vulnerabilities. As an alternative, we could leverage the support email by adding an alias to use for security reporting; filtering rules can be added using the "To" line to separate & flag security reports.

If one of our collabs would like to fix this, go ahead.
Good ideas by the way @wakfi

Just to comment on this here for the record, we could have it sent to us privately in a discord message, or through an email kind of thing unless we want it to be on github completely?

Security policy was changed to email method, this issue is no longer relevant

This issue has not been closed as a new policy has not been merged


Laravel 10.x Shift

This pull request includes the changes for upgrading to Laravel 10.x. Feel free to commit any additional changes to the shift-110368 branch.
Before merging, you need to:

Checkout the shift-110368 branch
Review all pull request comments for additional changes
Run composer update (if the scripts fail, add --no-scripts)
Clear any config, route, or view cache
Thoroughly test your application (no tests?, no CI?)

If you need help with your upgrade, check out the Human Shifts.

:information_source: Laravel 10 now verifies hashed values were created by the same hashing algorithm. If your application has hashed values created by different hashing algorithms, you may set the verify option to false in your hashing configuration. For more details, you may review the original PR.

:information_source: Shift updated your dependencies for Laravel 10. While many of the popular packages are reviewed, you may have to update additional packages in order for your application to be compatible with Laravel 10. Watch dealing with dependencies for tips on handling any Composer issues.
The following dependencies were updated by a major version and may have their own changes. You may check their changelog for any additional upgrade steps.

[ ] graham-campbell/github
[ ] laravel/ui

:warning: Shift upgraded your configuration files by defaulting them and merging your true customizations. These include values which are not changeable through core ENV variables.
You should review this commit for additional customizations or opportunities to use new ENV variables. If you have a lot of customizations, you may undo this commit with git revert 854fb420 and make the config file changes manually.

:information_source: Shift detected your application has a test suite. To make verifying the upgrade easier, Shift did not upgrade your testing dependencies for PHPUnit 10. Once you have completed your upgrade, you may run the PHPUnit 10 Shift for free to upgrade your test suite to PHPUnit 10 separately.

:information_source: Laravel renamed the password_resets table to password_reset_tokens. While an optional change, Shift detected you have a migration for this table and created a migration to rename it as well as updated the reference in your config/auth.php file. You should check for any additional references to this table and run php artisan migrate to complete your upgrade.

:information_source: Now with type hints in your code, defining types within PHP DocBlocks is redundant. Laravel has removed all of the @param and @return tags from its DocBlocks where types are defined with PHP. Similarly, Shift removed these tags from any DocBlock where the code now has equivalent type hints.

:information_source: Laravel 10 added PHP type hints to all user-land code included in a new Laravel application. In an effort to modernize your code, Shift added type hints to any method which is used by Laravel.

:information_source: All of the underlying Symfony components used by Laravel have been upgraded to Symfony 6.2. Shift detected references to Symfony classes within your application. These are most likely type hints and can safely be ignored. However, if you experience issues relating to Symfony, you should review the Symfony change log for any additional changes.

:information_source: Shift understands developers have different preferences when it comes to type hints. All of Shift's automation is done in nice, atomic commits. This makes it easier to undo any of the changes Shift makes.
If you wish to undo the changes relating to type hints, you may run:

git revert f3a5be79 to revert the DocBlock changes.
git revert 3487f52a to revert the type hints added from DocBlocks.
git revert 2cb837e4 to revert the type hints added for Laravel 10.

:information_source: The app/Models folder was reintroduced in Laravel 8. This was an optional change. Laravel and the artisan commands will automatically detect if you are using the app/Models folder or not.
If you wish to modernize your application to use the app/Models folder, you may run the Namespace Models Shift for free.

:information_source: Laravel began using Vite to build frontend assets in Laravel 9.19. While you may continue to use Laravel Mix, it is no longer the default. If you wish to modernize your application to use Vite, you may run the Vite Converter for free.

:warning: Laravel 10 requires Composer 2.2 or higher. You should verify the Composer version in your environments by running composer --version to ensure it meets this new requirement. If necessary, run composer self-update to update Composer.


How do I use a local LLVM installation?

Hi,
I've been trying to build TensorFlow with my local LLVM installation. I figured I have to choose N when I run ./configure:
Do you wish to download a fresh release of clang? (Experimental) [y/N]: n

I also tried setting the environment variable manually for the build:
TF_DOWNLOAD_CLANG="0" bazel build ...

However the build is still pulling llvm-project as an external dependency. Is using a local LLVM installation not supported? What do I need to do? Could you please give me the steps I need to take as I am new to Bazel or refer me to a resource?

@daravi,
Please provide details about what platform you are using (operating system, architecture). Also include your TensorFlow version. Also, did you compile from source or install a binary?
Make sure you also include the exact command if possible to produce the output included in your test case. If you are unclear what to include see the issue template displayed in the Github new issue template.
We ask for this in the issue submission template, because it is really difficult to help without that information. Thanks!


Intel® Modin Vs. Pandas Performance sample readme update

Existing Sample Changes
Description
Made minor changes to some formatting. Updated some branding. Added category to sample. Corrected notebook name in the readme to match the name in the sample. Changed OS and hardware information based on AI release notes - https://www.intel.com/content/www/us/en/developer/articles/system-requirements/intel-oneapi-ai-analytics-toolkit-system-requirements.html.
Fixes Issue#
External Dependencies
N/A
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[x] Documentation

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] VSCode

Adding @jimmytwei for notices.


Prompt doesn't show up

I followed the instructions and turned on the accessibility in privacy and security. The circular button shows up in my Xcode, but there's no prompt on the right of the button.
https://ibb.co/c3yh8hP

Please make sure the GitHub Copilot status is OK. If it's not, it's likely that your GitHub Copilot subscription is not valid.

It looks good here

Does the command Get Suggestions work for you?
Did you turn on Real-time suggestions in the host app?
If so, do you see any animation around the circular button when you stop typing? Don't press enter or arrow keys because they will cancel real-time suggestions.
If not, open Console.app and filter logs from CopilotForXcodeExtensionService, do you see any log with content Prefetch suggestions. when you stop typing?

Experiencing the same issue


Adjust weight in hermetic.md

Hermetic execution is an experimental feature and should not be at the top of the list in the website sidebar navigation.

Changes
Adjusts the weight property of hermetic.md from 10 to 1650, bringing it from the top of the website sidebar navigation to a point below core concepts.
/kind documentation
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[:no_good_man:] Docs included if any changes are user facing
[:no_good_man:] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes
NONE

/assign @jerop

/ok-to-test
/lgtm
Thanks!

/retest

/test pull-tekton-pipeline-build-tests

/test pull-tekton-pipeline-build-tests

/test pull-tekton-pipeline-integration-tests

/kind documentation

/test pull-tekton-pipeline-alpha-integration-tests


Good way to calculate number of days between two dates?

I wish there was a way to do something like:
(dateA - dateB).days
to get the number of days between two dates.

+1

Confirmed for v 4.0.
See https://github.com/malcommac/SwiftDate/issues/233


Add temple/compile function

This exposes the same temple templating functionality as a function that takes a template string.
This allows on-the-fly templating without creating a template file.

Looks pretty good, but should probably include the where parameter of temple/create as well.

@bakpakin what do you think would be appropriate - the current file?

@bakpakin added dyn :current-file to the params.


"docker service update" awkward for updating command arguments

It looks like if I want to update a service's command from echo abc def to echo abc xyz, I need to run docker service update servicename --arg abc --arg xyz. Inserting --arg before each argument doesn't feel right - if I have a command with lots of args, this is going to be really cumbersome and look weird. Could this be done with positional arguments at the end of the command like docker service create?
cc @vieux @dnephin

It would probably be better to do it with a single quoted string, but then we need to shlex to split it into the slice in the client.

Maybe this is already handled by the engine, I'll try it out.

Let's do this: docker service update --image myimage --replicas 3 myservice ls -l for updating arguments
And if you want to reset arguments you do: docker service update --image myimage --replicas 3 myservice ""

cc @sfsmithcha

PR with these changes is #24195

@dnephin @aaronlehmann after discussing with Solomon and others, we'd prefer the original --args with shlex. I can't find the PR now.

I suggest we close #24195 then

I've updated #24195 with the shlex implementation


GET /transactions/txn_id

This PR include the changes needed to create a GET request for /transactions/$txn_id

Closing this because these changes are included in https://github.com/RelationalAI/rai-sdk-python/pull/61


Leader line duplicates itself when used with Plain Draggable

Hello,
I'm trying to use the leader line with PlainDraggable, but on drag, the line gets duplicated. The duplicated line refreshes the position correctly, the first stays static.

The code:
`
requirejs(["node_modules/leader-line/leader-line.min", "node_modules/plain-draggable/plain-draggable.min"], function () {
"use strict"
var elStart = document.getElementById('start')
, elEnd = document.getElementById('end')
, line1
, draggable;
draggable = new PlainDraggable(
    elEnd,
    {
        onMove: function () {
            line1.position();
            line1.dash = true;
        },
        onDragEnd: function () {
            line1.dash = false;
        }
    }
);

draggable = new PlainDraggable(
    elStart,
    {
        onMove: function () {
            line1.position();
            line1.dash = true;
        },
        onDragEnd: function () {
            line1.dash = false;
        }
    }
);

line1 = new LeaderLine(
    elStart,
    elEnd
);

});
`
The version:
Leader-line: 1.0.5
Plain-draggable: 2.5.14
Am I missing something in the code?
Thank you

Hi @brunoMachado92, thank you for the comment.
I copied your code and tried it, then it seems to work fine.
https://jsfiddle.net/peg1a7cq/
I think that another part of your code that was not indicated by you has a bug, the initialize-function was called twice.

No reply came, then this abandoned issue is closed.


No data source to select in the mapping manager

Protege-5.0.0-beta-24
Ontop OBDA Protégé plugin 1.17.1
I'm referring to 'Ontop Mappings' tab.
The connection parameters in the 'Datasource manager' tab seem to be correct : the test connection returns "Connection is OK".
https://www.youtube.com/watch?v=KHtlARfex4c
When I watched the demo (even though it's a different version), I noticed at 10 minutes and 50 seconds that Mariano was selecting a datasource that I couldn't with my version.

Hi, we have removed the option of data-source selection in the latest version.
The reason is that Ontop does not really support query answering over multiple data-sources by itself.
If you have more than one datasource there, the protege-plugin cannot work properly.
The drop list there caused many confusions.
The change was made in issue #89

Thanks a lot !

The reason I was looking for a data source selection is because when I try to create a mapping, there's a warning telling me to select a data source to proceed.

Hi, this is bug that we already known and will be solved in the next version of ontop.
In the meanwhile to avoid the problem, after you have set the datasource values in Datasource manager, click on "Test connection", before moving to the mapping manager.

I tested the connection and it was OK.

You need to follow this step (only for the first time in which you create a datasource)
Open Protege, load your ontology if you already have it or create a new ontology, go to ontop mapping, create the datasource, click on "Test connection", move to mapping manager to create a new mapping.

Thank you !


[awaitable example] Keep alive procesing is broken

I took one of your examples to show the problem and ask for the right solution.
So, we have session procesing loop with keep-alive handling. Suppose that one request comes with the header "Connection: keep-alive".  Then keep_alive flag sets to true. Due do try {} construction we get into an endless cycle of exceptions (if the client does not make another request with the cancellation of "Connection: close"). This is a resource leak.
What is the main reason? All async_* functions return immediately. So, I want to find solution that will hold async_read[_headers] operation for N secons and if bytes/headers do not arrive, I want to receive an error and terminate the session processing.
I hope I have described problem in sufficient detail and clearly :)

What is the main reason? All async_* functions return immediately.

What do you mean by that? What do you mean by client cancellation?
There is indeed a bug in that the catch block should have a break statement if it's end of stream, to break the loop.

What do you mean by that? What do you mean by client cancellation?

I will try to explain in more detail
We have keep_alive == true, after that we respond to client using async_write and go to the second iteration of for(;;) loop. Then we have the async_read function called, which throws an end_of_stream exception. And it happens endlessly.

There is indeed a bug in that the catch block should have a break statement if it's end of stream, to break the loop.

It's not that simple. If we do this, there will be no point in processing keep-alive.  Because on the second iteration for(;;) it's not a fact that we will receive another request from the client.

Why is it not that simple? End of stream should break the for-loop and close the connection.

If we do this, then our keep-alive session will probably last even less than one millisecond :)

end of stream means that the remote closed the connection, you cannot "keep alive" after that.


[Bug]-[2800]:CRUD happens even with Read-Only access in MYSQL

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Update, delete functionality are working even if the datasource is authorized only for Read access.
Steps To Reproduce

Create a Datasource of MYSQL with  Read Only Access
Try to update or delete using mysql query
Observe the table got updated in Read-only access

Environment
Production
Version
Cloud

same happens for postgres too
6m usage: 1000+2500 = 3500
applying 20% requirement: 700
Stats

Stat
Values

Reach
3500

Effort (months)
0.5

Stats

Stat
Values

Reach
3500

Effort (months)
0.25

@rohan-arthur @ajinkyakulkarni not everyone will need read only mode so I'm lowering the reach

It seems the issue exists with MySQL but not Postgres. Attaching the usage in Postgres:
https://user-images.githubusercontent.com/1757421/180231770-bc581357-8a7f-4256-8d4d-e7b7347d45de.mov

Observations and RCA on this issue

Easy way to set this up:

Create datasource from our notion page, ensure that it is marked read only
run query to get the total count: SELECT COUNT(*) FROM a;
run query to add a new row: INSERT INTO a (PersonID, LastName, attendence, salary, joiningdate, logindateandtime, gross) VALUES (12, 'new person', true, 100, '2024-01-01', '2024-01-02T08:00:00Z', 2);
repeat the step to run query to get the total count: SELECT COUNT(*) FROM a;

You will see that the count is incremented by 1

This looks like a bigger problem where we are taking the read only/read write input from user through datasource config form but we are not using this mode to configure the correct connection.
As mentioned in this notion doc, only postgres and redshift has this functionality implemented, for others (mysql, mssql and mongoDB) it's not there.
I checked the r2dbc-mariadb documentation to see if we have any way to configure this mode, it looks like we don't
The only immediate solution we have here is to remove this connection mode property from datasource form, so there is no confusion on whether we can configure this access or not and it will always connect with all permissions (as it is today)
Moving this to bugs with medium efforts, we can discuss and conclude what approach we want to take
CC: @rohan-arthur @sumitsum

@sneha122 in that case it seems like a smaller problem and we should just remove the UI element :)

@Nikhil-Nandagopal Yes that's a good preventive solution for now, till we figure out the connection mode for mysql. Will pick this up in upcoming sprint, Thanks!


Write regexp filter to highlight Globant

Request: Write regxep focused on tests updated by Globant
Short description:

Current state:

No view into Globant

Desired state:

A view into seeing Globant productivity
A easier view for others to model / search

Tasks:

[ ]  List generated (scripted would be great, manual works too)

[ ]  Generate regexp for the list for use with existing APISnoop urls
OR if the list is quite long, or the regexp won't work, then

[ ]  Create branch with updated code to tag tests as globant work based on their list

/cc @mgdevstack @brahmaroutu

I have list of Issue numbers handy where we have added contributions but I'm not sure how easy it would be to show on APISnoop specially when we look for, By which % API coverage has been improved and different areas of contribution.
https://github.com/issues?utf8=✓&q=involves%3Apontiyaraja+involves%3Amgdevstack+involves%3Aglobervinodhn+archived%3Afalse+sort%3Aupdated-desc

Thanks for the search @mgdevstack
We'll use this to verify our ongoing work working with querying github issues, PRs, and the board.


added note about backing up old license key

#5102

Ref. previous PR: #5276 (for editing details)

I'll make some edits for style and clarity here when I get a free minute.

@Dansimp The PR has been approved by Matthew and can be merged. Thanks.


Can support ruff formatter

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Does super linter also support ruff formatting? I guess it doesn't.
Expected Behavior
.
Anything else?
No response

Hi @adhadse !
Do you mean Ruff ? If so, yes, it's already supported.

So, by default super linter runs linter as well as formatter?

It runs Ruff with the following command: https://github.com/super-linter/super-linter/blob/c46346c7743f7ce191073a49d90a1fa7b3d11996/lib/functions/linterCommands.sh#L108
Is it what you're looking for, or something else?

It runs Ruff with the following command: https://github.com/super-linter/super-linter/blob/c46346c7743f7ce191073a49d90a1fa7b3d11996/lib/functions/linterCommands.sh#L108
Is it what you're looking for, or something else?

Ruff can be used as a linter, as done in this line, but also as a black-like formatter with "ruff format". It is essentially the same as black, but with certain known deviations between the two, explained in their docs. It makes it such that in one of my projects, both can't be used together, as both ruff format and black overwrite each others changes on certain lines.

It runs Ruff with the following command:
https://github.com/super-linter/super-linter/blob/c46346c7743f7ce191073a49d90a1fa7b3d11996/lib/functions/linterCommands.sh#L108
Is it what you're looking for, or something else?

So ruff has both the functionality, linting as well as formatting as explained echoix. As you pointed out super linter currently just runs the linter but not the formatter.
I'll have to configure GitHub Actions to run the formatter separately.

Ah, got it. Shouldn't be to hard to implement considering that we already have Ruff installed.
The process is described here: https://github.com/super-linter/super-linter/blob/main/docs/add-new-linter.md
Feel free to send a PR, we'll happily review it.

@ferrarimarco by the way, I was wondering how does it fits into the "Super-linter" to include a "formatter" as well. Is that anticipated or out of requirements for Super linter to ONLY lint check?

@ferrarimarco by the way, I was wondering how does it fits into the "Super-linter" to include a "formatter" as well. Is that anticipated or out of requirements for Super linter to ONLY lint check?

This is not an issue because Super-linter includes several formatters already.
Out of curiosity: it seems that Ruff is positioning its formatter as a drop-in replacement for Black. Is there a specific use case for which using Black directly (Black is already included in Super-linter) is not suitable? This will be useful to understand if we need special care to implement this feature.


Uncommenting m4+rf macro cause loosing all signals in Waveform

Hi,
If I uncomment the m4+rf macro in the starting point code and compile the project then no signal will be visible in Waveform anymore with the exception of clk and rst (so I lost every signal that I had before).
The TLV version line is this:
\m4_TLV_version 1d: tl-x.org
Details
If I have this simple PC logic code:

then I see this Waveform after compilatioin:

When I uncomment the m4+rf macro line like this:

then after compilation I get this Waveform:

Br,
David

Click on the "+" before "TLV".
On Sun, Apr 16, 2023 at 11:44 AM DavidTurny @.***>
wrote:

Hi,
If I uncomment the m4+rf macro in the starting point code
https://makerchip.com/sandbox?code_url=https:%2F%2Fraw.githubusercontent.com%2Fstevehoover%2FLF-Building-a-RISC-V-CPU-Core%2Fmaster%2Frisc-v_shell.tlv
and compile the project then no signal will be visible in Waveform anymore
with the exception of clk and rst (so I lost every signal that I had
before).
The TLV version line is this:
\m4_TLV_version 1d: tl-x.org
Details
If I have this simple PC logic code:
[image: kép]
https://user-images.githubusercontent.com/114754950/232323855-624fda49-25fb-4c22-9849-a125feffcd8f.png
then I see this Waveform after compilatioin:
[image: kép]
https://user-images.githubusercontent.com/114754950/232323898-f1045b9b-3e4e-4eec-9095-fedcea2d5e5f.png
When I uncomment the m4+rf macro line like this:
[image: kép]
https://user-images.githubusercontent.com/114754950/232323953-a60b8bfb-abd2-448a-87a1-8649e0c3dac1.png
then after compilation I get this Waveform:
[image: kép]
https://user-images.githubusercontent.com/114754950/232323982-d1c02347-e0e7-43f0-8209-a17f7afff6ae.png
Br,
David
—
Reply to this email directly, view it on GitHub
https://github.com/stevehoover/LF-Building-a-RISC-V-CPU-Core/issues/4,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACWHLECT6Z5IW55SRMGBEGTXBQHXTANCNFSM6AAAAAAXAGINJI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

:D Thank you.


Revert "Add "getting started" documentation"

Revert early merge

Get requested changes from last pr, I can then handle the additional requesting and finally approve @bqqbarbhg


Placement: reduce verbosity of a debug log

When running placement with debug logs, line Process Raft state command: nothing happened... is getting logged every 10s, causing a lot of unnecessary noise that makes debugging harder.

/ok-to-test

we had a ticker only for logging?

Looks like that was the case, yes

/ok-to-test


Footnotes have excessive margins

I don't know if I'm doing something wrong with my markup, but footnotes have very large spacing compared to their size.
6. **remote:** Remove old key from ``~/.ssh/authorized_keys``.
7. **client:** Delete old key files.

.. [1] https://wiki.mozilla.org/Security/Guidelines/OpenSSH#OpenSSH_client
.. [2] https://wiki.mozilla.org/Security/Guidelines/OpenSSH#OpenSSH_server

Produces
  …

remote: Remove old key from ~/.ssh/authorized_keys.

client: Delete old key files.

  …

  …

Which under sphinx-rtd-theme looks like this:

Ran into the same issue today and could 'quick-fix' it by removing/(wrap comments around)
margin-bottom: 24px;.
of the css class
.wy-table-responsive
I'm pretty sure this is not the best way of handling this so it would be great if any of the devs could chime in and do a proper fix.

Yes, thanks. I'm not sure if other elements might be affected by this though (not that I saw any), as the developers probably have their reasons for this margin. I hope they give this a second look, as I understand too little of the theme to justify submitting a pull request.

I think the problem is that each footnote (same for citations) is turned into a table with a single row, instead of a table with multiple rows. Since this is done by docutils, it can not be easily changed from Sphinx or the html theme.
Each table is wrapped in a div to make it responsive, which has a non-zero margin-bottom, which is the cause of this spacing.
I have a possible workaround, will file a PR


Support array-based parameters for ExecuteNonQuery and ExecuteScalar at DbConnectionExtension.

This is implemented already at ExecuteReaderInternal as a requested by a team member. But it is good to support such feature in Scalar and NonQuery methods.

The method ExecuteNonQuery cannot be supported, however, the method ExecuteScalar must be supported. Fixes has been applied and checked-in to the main branch. Will be a part of build greater than v1.6.4.


Fix Bad #L line in spec callback

This solves the first of the three problems enumerated in #391 and should make the spec file writer immediately usable.

ugh i hate it when I have a typo in my git commit title line. am I fussy enough to fix it?

attn @dan

Great. Thanks again for digging into this.

I would normally advocate for testing this on a beamline before merging it in, but since the spec callback is broken in master anyway, I suppose this can't really make it any worse! crosses fingers

I'll swing by CHX and give it a try early tomorrow.

 Would you try updating bluesky (in an hour or so, when the new build becomes available) and let us know if this works?

@danielballan I just update bluesky, but get errors:
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
/home/xf11id/.ipython/profile_collection/startup/00-startup.py in <module>()
      8 from bluesky import qt_kicker
      9 qt_kicker.install_qt_kicker()
---> 10 from databroker import DataBroker as db, get_events, get_images, get_table, get_fields, restream, process
     11
     12 from epics import caput, caget

ImportError: cannot import name 'restream'
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
/home/xf11id/.ipython/profile_collection/startup/30-user.py in <module>()
      2 from ophyd import EpicsMotor
      3 from epics import caput
----> 4 from filestore import RawHandler
      5
      6 class ReversedEpicsMotor(EpicsMotor):

ImportError: cannot import name 'RawHandler'
/home/xf11id/conda_envs/collection/lib/python3.5/site-packages/filestore/retrieve.py:15: UserWarning: Do not import filestore.retrieve, import filestore.api instead

It looks like you have downgraded the databroker and/or filestore.

I just did conda update bluesky
I will try to update databroker and/or filestore.

Can you copy the output from the original conda update bluesky?

(collection)xf11id@xf11id-ws1:~$ conda update bluesky
Fetching package metadata: ....
Solving package specifications: ......................................................................................................
Package plan for installation in environment /home/xf11id/conda_envs/collection:

The following packages will be UPDATED:

    tzlocal:         1.1.2-py35_1                  --> 1.1.2-py35_0

The following packages will be DOWNGRADED:

    bluesky:         0.4.3-py35_1                  --> 0.4.0rc2.post9-9_g425d932_py35
    channelarchiver: <IP_ADDRESS>-py35_1                --> 0.0.5.post6-6_gfac126f_npNonepy35
    databroker:      0.3.3-py35_0                  --> 0.3.1.post15-15_g786344a_py35
    doct:            1.0.1-py35_0                  --> 1.0.0.post4-py35_0
    filestore:       0.2.3-py35_0                  --> 0.2.2.post5-5_g3bc4a5f_py35
    matplotlib:      1.5.1.post61-61_g513da02_py35 --> 1.5.1-np110py35_0
    metadatastore:   0.3.2-py35_0                  --> 0.3.1-py35_0
    readline:        6.2.5-1                       --> 6.2-12
    tifffile:        0.7.0-np110py35_1             --> 0.3.1-np110py35_0

Proceed ([y]/n)? y

Unlinking packages ...
[      COMPLETE      ]|##############################################################################################################| 100%
Linking packages ...
[      COMPLETE      ]|##############################################################################################################| 100%
(collection)xf11id@xf11id-ws1:~$ ./collection

@danielballan
(collection)xf11id@xf11id-ws1:~$ conda update filestore
Fetching package metadata: ....
# All requested packages already installed.
# packages in environment at /home/xf11id/conda_envs/collection:
#
filestore                 0.2.2.post5     5_g3bc4a5f_py35    https://pergamon.cs.nsls2.local:8443/conda/nsls2/linux-64/filestore-0.2.2.post5-5_g3bc4a5f_py35.tar.bz2
(collection)xf11id@xf11id-ws1:~$ conda update databroker
Fetching package metadata: ....
# All requested packages already installed.
# packages in environment at /home/xf11id/conda_envs/collection:
#
databroker                0.3.1.post15    15_g786344a_py35    https://pergamon.cs.nsls2.local:8443/conda/nsls2/linux-64/databroker-0.3.1.post15-15_g786344a_py35.tar.bz2
(collection)xf11id@xf11id-ws1:~$

It seems like that databroker and filestore are the latest version.

Right, so I take it you see how that command downgraded a ton of packages?  In the future, you can avoid this by doing conda update <package> --no-deps which will only affect . In this case, conda update bluesky --no-deps would have avoided this.  Also please ask questions if you are unsure of something!

what is in your .condarc?

I can see how that is confusing, but please read the log you just posted above. See how databroker and others were downgraded?
The reason is that the "default" channel (nsls2) is conservative and thus out of date to what you guys are doing. So, because you did not provide the argument -c nsls2-dev, conda downgraded.

I'll leave it to you @ericdill  -- thanks.

Here's what you need to do @yugangzhang ...
conda update collection -c nsls2-tag
then
conda update bluesky -c nsls2-dev

@danielballan  and @ericdill  I saw the degradation problem.
@ericdill there is nothing in vi ~/.condarc, I guess we should make the default not so conservative to degrade the packages.
@ericdill
Error: package 'collection' is not installed in /home/xf11id/conda_envs/collection

but i have
(collection)xf11id@xf11id-ws1:~$ conda info -e
# conda environments:
#
collection            *  /home/xf11id/conda_envs/collection
collection2              /home/xf11id/conda_envs/collection2
analysis                 /opt/conda_envs/analysis
root                     /opt/conda

Ok, then just do conda install collection -c nsls2-tag

collection, in this case, is [this metapackage] (https://github.com/NSLS-II/auto-build-tagged-recipes/blob/master/pyall/collection-2016_01/meta.yaml), not the conda environment

I guess we should make the default not so conservative to degrade the packages.

Agreed. Remind me and we can recalibrate this next time I visit.

@ericdill and @danielballan  thanks! all the degraded packages are updated.
I just did a scan in collection, it works.

Great. Let us know when you can about whether pymca is reading the SPEC files happily now.

I just looked at speck file in pymca for the latest scan. It plots correctly. Great!

Just because I'm paranoid, can you copy the contents of the spec file for the last scan into this PR?

79293
79294
79295 #S 12841 dscan diff_yh -0.01 0.01 (3,)
79296 #D 2016-03-21 17:15:11.681528
79297 #T -1 (Seconds)
79298 #P0 -inf -inf -inf -inf
79299 #N 8
79300 #L diff_yh    Epoch  Seconds  xray_eye3_stats1_total  xray_eye3_stats2_total  xray_eye3_stats3_total  xray_eye3_stats4_total  xray_ey      e3_stats5_total
79301 -8.90554<PHONE_NUMBER>.5054994 -1 20871.0 2778.0 245921.0 19694.0 11684401.0
79302 -8.89708<PHONE_NUMBER>.0270674 -1 20720.0 2837.0 247094.0 19949.0 11703664.0
79303 -8.890540000000001<PHONE_NUMBER>.153153 -1 20787.0 2791.0 246239.0 19672.0 11683347.0
79304 -8.883780000000002<PHONE_NUMBER>.4058714 -1 20676.0 2785.0 245269.0 19810.0 11683735.0

Perfect. Thanks.


Support Snack web-preview for Shadow Props example

This should be merged after #2474
Follow up to #2474
This add support for Snack web preview to the Shadow Props example

How

Use @react-native-community/slider which supports web
Enable web platform for example

Hi @IjzerenHein,
as stated in https://github.com/facebook/react-native-website/pull/2474#pullrequestreview-584289041, the goal of React Native documentation is to describe the build-in APIs and components as close, and as detailed, as possible.
The web preview is just a helper tool in the website case, nice thing to have, but if there are any problems or issue with this preview, it should be disabled.
Besides that, web is an out-of-tree platform , it's developed independently of React Native. It would be hard to handle all the discrepancies and minor issues in the examples. Users looking for the detailed documentation and examples should visit the platform docs, available at:

https://necolas.github.io/react-native-web/docs/

It's sad, but I had to close this PR too, but thank you for the work you put in in there.

@Simek Coming back to this issue. As using an out of branch package is a no go, what is the way forward for these examples? The RN Slider API is considered deprecated, but it is still used in some examples.

@IjzerenHein There are several APIs which are deprecated for the few releases, but cannot be removed from the core right now due FB internal usage of this libraries, and it's nothing more we can do in this matter:

https://github.com/facebook/react-native/issues/23313

Generally users which have the issues with Slider or want an extended functionality should use one of community packages (as the note on the Slider page says.
The docs will use Slider in examples until it's a part core, and when it will be removed examples should be rewritten (to use other core APIs, the community/3rd part packages should not be a part of the documentation.

@Simek Okay noted, thanks for the reply. As the web-preview is currently not working because of the Slider issue, should we disable the web-platform for these examples?

@Simek Okay noted, thanks for the reply. As the web-preview is currently not working because of the Slider issue, should we disable the web-platform for these examples?

Yup, if there are issues on the web, I think that disabling web examples it's the best what we can do right now, sice web is an out-of-tree platform.

Okay sound good. I'll create a PR for it later this week 👍

See https://github.com/facebook/react-native-website/pull/2656


Correct default values of model filenames in demo scripts

related issue https://github.com/opencv/opencv_zoo/issues/10

cc @kaingwade @zihaomu

@fengyuentau Thank you for your mention. https://github.com/opencv/opencv_zoo/issues/10#issuecomment-957132129
I think that there is a concern. Because, the filename of pretrained model has date(e.g. face_detection_yunet_2021sep.onnx).
So, you will need to modify demo scripts when you update model.

@atinfinity I think that's not a big problem since models won't be updated quite frequently.