Compilation failed: int param minValue with negative int

Bicep v0.3.1
Compilation failed with error message: The value must be a compile-time constant.(BCP032)
Code to reproduce the behavior:
param timeOffset int {
  minValue: -12 // The value must be a compile-time constant.(BCP032)
  maxValue: 12
}

Probably dupe of https://github.com/Azure/bicep/issues/1730

No, this has a different root cause.
Negative numbers are modeled in the AST as a unary minus operator acting on a positive integer literal and the compile-time constant check is treating any unary operator as a non-constant. We need to modify the CTC check to treat the unary minus operator as a constant and fix any follow-on problems introduced by that (in code gen or validation code).


Migration to AWS Amplify Gen 2

Migration to AWS Amplify Gen 2

Migrate 'amplify add api' to use Gen 2 backend in-build data
Migrate 'amplify add custom' to use Gen 2 Custom CDK Construct
Pass GraphQL API ID from Step 1 to be a dependency for Step 2 and simplify the code
Change frontend code to call amplify-data client to trigger AppSync API using mutations.

Merged into main


litmus-portal(language): Add support for multi-language

Signed-off-by: Chandan Kumar<EMAIL_ADDRESS>
Proposed changes
This commit will add the support for localizing the text in the translation file.

This will helps in adding support for multilanguage.
This is done by a framework called, more info here: https://react.i18next.com/

fixed issue: https://github.com/litmuschaos/litmus/issues/1949
Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[x] New feature (non-breaking change which adds functionality)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the commit for DCO to be passed.
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have added necessary documentation (if appropriate)

Looks good for me
@S-ayanide @arkajyotiMukherjee Is this PR good to merge?

/preview 15


Incompatible with AWS Lambda due to >250MB in dependencies

Has anyone else attempted to use this package in an AWS lambda function, only to find that this package and its dependencies result in a deployment package larger than the AWS limit of 250MB?
It seems like pandas + pyarrow + numpy are the main culprits of this.
❯ python -m virtualenv .venv
...
❯ source .venv/bin/activate
...
❯ python3 -m pip install 'databricks-sql-connector==2.6.0'
...
❯ du -sh .venv/lib/python3.8/site-packages
297M	.venv/lib/python3.8/site-packages

You're not alone in this. We would like to prune the overall package size. It should be easy enough to remove the pandas dependency. But we depend on arrow, which also requires numpy. It's not clear to me how we can work around that.

I know this is not a solution, but I also went through this rabbit hole while trying to make it work with Lambdas.
One solution is using Docker images on Lambda: https://docs.aws.amazon.com/lambda/latest/dg/images-create.html
Keep in mind that the larger the image the longer the cold start will be on the Lambda, which kinda defeats the purpose, but it is a valid solution for running code that bundles to more than 250Mb.
Ended up going with docker on ECS but you can make it work on Lambda.

Just coming across this same issue now. I'd hoped that there was a public Lambda layer built with all this in it already (which is how I get round this with Datadog) but seems not 😢
Looks like ECS for me...

Just coming across this same issue now. I'd hoped that there was a public Lambda layer built with all this in it already (which is how I get round this with Datadog) but seems not 😢
Looks like ECS for me...

The 250MB limit includes lambda layers, so either Docker image on lambda or ECS.

Just wanted to see if this is still a focus on the Databricks end?
We currently have a large number of ETL pipelines where part of the processing happens in AWS Lambda. The fact that the installed source of this package is too large excludes us from writing the our Delta Lake using AWS Lambda.
The workarounds (such as using a docker image) are viable but very annoying and inefficient. Our build process is twice is along and much more complex compared to using a 'simple' AWS function.

I'm not working on this connector anymore. But I've learned some things since I wrote this comment which I might as well record here, in case they help someone:
This connector fetches results from Databricks in Apache Arrow format. Arrow is a column-based binary format that is very efficient across the wire when compared to alternatives like JSON or CSV. This saves you network bandwidth if you are pulling millions of rows per-query. And if your Python application already works with Arrow tables (pandas supports this) then you can get those directly using the _arrow() fetch methods, avoiding the CPU-time of deserializing the results.
If your application doesn't use Arrow tables, the results must be deserialized from Arrow → Python built-in types. Deserialization is tricky because, if not done correctly, numeric results can lose precision.
An additional complicating factor is that larger result sets are sent in batches that must be re-assembled by the connector.
Databricks SQL Connector uses pyarrow to stitch together Arrow batches and to deserialize them on-demand. pyarrow and its dependencies constitute the bulk of the installed size. Without pyarrow the package would drop below 100MB.
The basic approach to making pyarrow optional is to replace what pyarrow does for free:

Optionally fetch results in a format other than Arrow
Implement a mechanism to stitch partial results into a complete result
Implement deserialization logic for converting to Python built-in types

Item 3 is no small task, which is why this effort could take some time.

Thanks @susodapop for providing some more insight on why this is a big change!

@MichaelAnckaert @icj217 (cc: @gopalldb @yunbodeng-db ) We have recently implemented the the split for the databricks-sql-python, to have an complete version and to have an non pyarrow based databricks-sql-connector-core ( smaller package ). We would want to know the update on this issue


Inputwindows

Code für die Max Input Windows und Sinus fits

Hi Kay,
very beautiful.
Please update the documentation to follow numpy docstring conventions:
http://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_numpy.html
https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt
That would be great.
Otherwise they will also not work well with the generated html documentation.


Custom class injections

Hi,
Very nice and useful plugin! In the project I am using the plugin, I have the case to call the modal a couple of times to confirm user actions. One of the dialogs is to confirm delete and another one is to save. So to have difference for confirmations I am overriding button colors (red on delete, green on save). The problem in this is that I have to inject different classes for styling (or

It would be implemented asap.. Very useful. Thanks

That's exactly my use case as well and I was going to add that feature next, and possibly (if owner agrees) do a pull request.
My idea was to add an option that can add additional cssClasses to different parts of the dialog. For instance the okButton or cancel-button.
Something like (on top of my head)
options: {
    cssClasses: {
         okButton: 'green-class',
         cancelButton: 'gray-class',
         title: 'my-custom-header-class'
    }
}

With that solution your use case would also be covered, correct?

Also a very good idea, highly customisable. But downside with injecting single classes on single elements is to have create single css classes for each / single element. Adding only one custom class on the parent and overriding child elements thru that class is kinda simple to implement I guess. Maybe even for theming whole dialog.
But I think having chance to both options would be really nice.
Btw thank you for the fast response @Godofbrowser :)

@hjortzen that's equally a very good idea. But would mean too much configuration whereas a single css class can handle this and more.

You're welcome @elibolonur :)

@hjortzen I think we should go with the single customClass option for now. Unless maybe there's a more specific use case.
Would you still be interested in sending a PR for this? cos as aways, PRs are welcome for our little plugin :)

My use case is probably a little different.
To be very specific; my need is to add 'blue' to the list of classes in okButton.
Because in our portal we have a lot of styling already done to buttons which is condensed into the 'blue, red, yellow, gray' classes. This is not styling we wish to repeat.
Also, we'd like to be able to change the heading size (h6) to something that complies better within our portal (h2 or h3), but that is outside the scope of being able to add css classes to components. But related in a way since our styling is done on h2 and h3 and we do not wish to repeat that styling for this specific dialog.
Anyway, I'll start on something regarding the adding of CSS classes and see if I can come up with something. Using filters the DOM wouldn't get too cluttered either. We'll see!

Potential solution added on this pull request #26 I guess its solving both hjortzen and my issue. Makes styling pretty flexible also :)


GKundu

Test Pull Request

Please use your City Tech email.

On Feb 4, 2015, at 17:15, GKundu<EMAIL_ADDRESS>wrote:
Test Pull Request
You can view, comment on, or merge this pull request online at:
https://github.com/cst1201-d644/lab1/pull/9 https://github.com/cst1201-d644/lab1/pull/9
Commit Summary
Replace Author Name
File Changes
M Lab1/src/lab1/Pay.java https://github.com/cst1201-d644/lab1/pull/9/files#diff-0 (3)
M Lab1/src/lab1/SalesTax.java https://github.com/cst1201-d644/lab1/pull/9/files#diff-1 (3)
Patch Links:
https://github.com/cst1201-d644/lab1/pull/9.patch https://github.com/cst1201-d644/lab1/pull/9.patch
https://github.com/cst1201-d644/lab1/pull/9.diff https://github.com/cst1201-d644/lab1/pull/9.diff
—
Reply to this email directly or view it on GitHub https://github.com/cst1201-d644/lab1/pull/9.

Submitting Lab1 For Grade .


Is there a way to monitor vGPU with DCGM?

DCGM exporter is not picking the pods that are using vGPU, making it hard to to track utilization of the pods.
is there any workaround to monitor GPU utilization with vGPU?
is there a way to get the mapping between the vGPU and the actual GPU IDs?

Hello and thanks for your issue, unfortunately we are not compatible with DCGM, but we have our own monitor system, please refer to this repo: https://github.com/4paradigm/k8s-vgpu-scheduler


ffsend: v0.2.50 -> v0.2.51

Motivation for this change
https://github.com/timvisee/ffsend/releases/tag/v0.2.51
This release has very minor changes. It's just some updates to the shell completions, plus rust crate dependency updates.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

LGTM, tested and working

@GrahamcOfBorg build ffsend


refactoring of connections state

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report
Attention: Patch coverage is 41.46341% with 72 lines in your changes missing coverage. Please review.

Project coverage is 41.13%. Comparing base (1a85c10) to head (0628d5d).

Files
Patch %
Lines

internal/balancer/balancer.go
49.18%
24 Missing and 7 partials :warning:

internal/conn/pool.go
0.00%
28 Missing :warning:

internal/conn/conn.go
36.36%
7 Missing :warning:

internal/conn/grpc_client_stream.go
0.00%
2 Missing :warning:

internal/xerrors/retryable.go
0.00%
1 Missing and 1 partial :warning:

driver.go
0.00%
1 Missing :warning:

internal/xsync/map.go
75.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
- Coverage   41.71%   41.13%   -0.59%
==========================================
  Files         348      348
  Lines       35104    29544    -5560
==========================================
- Hits        14645    12154    -2491
+ Misses      19980    16899    -3081
- Partials      479      491      +12

Flag
Coverage Δ

go-1.20.x
42.99% <41.46%> (-0.60%)
:arrow_down:

go-1.21.x
42.95% <41.46%> (-0.63%)
:arrow_down:

go-1.22.x
41.07% <41.46%> (-0.63%)
:arrow_down:

macOS
42.97% <41.46%> (+1.74%)
:arrow_up:

ubuntu
41.12% <41.46%> (-0.11%)
:arrow_down:

unit
41.13% <41.46%> (-0.59%)
:arrow_down:

windows
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Bug]: Invalid recovery for Regex general unicode category

Description
public function main() {
    string:RegExp a = re `\p{Lz}`;
}

for the above code Ballerina parser recover as
public function main() {
    string:RegExp a = re `\p{L MISSING[}] MISSING[\ INVALID[z]] MISSING[\ INVALID[}]]`;
}

But after the MISSING[}], MISSING[\ INVALID[z]] should not be occurred. Because z is valid after the \p{L}.
Steps to Reproduce
No response
Affected Version(s)
No response
OS, DB, other environment details and versions
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Had a discussion with @rdulmina and came to a conclusion that, this issue is fixed with https://github.com/ballerina-platform/ballerina-lang/pull/40479


fix: Only set GrantType once (#353)

This fixes an issue where, when using the device authorization flow, the
grant type would be set twice. Some OPs don't accept this, and fail when
polling.
With this fix the grant type is only set once, which will make some OPs
happy again.
This fix is in the main branch but is missing in the next branch.
Fixes #352

Thanks! I was intending to merge main into next soon, but got hold up with other work, so apologies. Meanwhile lets merge this to get you on your way :)


320159 fixes part 1

Partial fix to lower DoS possibilities. It does not fix all the issues though, but it makes things better and should not break anything.
Ref: https://hackerone.com/reports/320159
Extracted from my private repo.

@3rd-Eden I believe this specific fix is independent from uap-core, is trivial, and could be merged as is =).

@3rd-Eden Is there an expected release date for this fix?

Is this fix released?


Fix #16

Add a check to ensure that the classes registered are not abstract and that the commands extend the base Command class (see #16).
Edit: tested with the standard edition

Thanks!


Discord deckboard does not update

Deckboard continues to indicate that there is an update. No matter how hard I try to update, it won't update to the latest version.

I have also tried downloading the package manually and overwriting it, but it still says it is version 1.1.2 and that I need to update.

Yeah, this is annoying

This is still an issue. Not only in the Deckboard itself, but even downloading from here, it still displays as being 1.1.2 saying I need to update, regardless of how many times I try. The functions are not working either. All I've tried so far is mute/unmuting myself, but it doesn't register at all.

Yep same thing here, I tried to compile it myself to see if it would change anything, but no.

Same issue, even manual installation of pre-compiled. I am not familiar enough with JavaScript to attempt to compile myself but I did notice that between version 1.1.0 and 1.1.2, extension.yml changed from
repository: "https://github.com/aislandener/discord-deckboard"
to
repository: "https://github.com/osmancitci/discord-deckboard"
for a version 1.1.1 which isn't in this repo but is located at osmancitci
I wonder if because 1.1.2 doesn't exist at osmancitci/discord-deckboard if this line needs to be changed back to aislandener/discord-deckboard for the Deckboard application to actually find the update?

any news?

@FernandoFuvio when I edit that binary file, I find four instances of 1.1.2 but when I change them and restart Deckboard, it shows as uninstalled in the extensions.

Did you use Notepad++ to replace the text or another application like Windows Notepad?

I used VSCode Find & Replace

I used VSCode Find & Replace

Maybe it changed coding format or something. Try replacing using Notepad++. Here worked fine.

You can edit the 'asar' file in Notepad++ and replace everywhere that is "1.1.2" to "1.1.3". Restart Deckboard and it stops asking to update. The 'asar' file is in C:\Users\youruser\deckboard\extensions

This does not notify you of the update, but you are still using internally version 1.1.2.

You can edit the 'asar' file in Notepad++ and replace everywhere that is "1.1.2" to "1.1.3". Restart Deckboard and it stops asking to update. The 'asar' file is in C:\Users\youruser\deckboard\extensions

This does not notify you of the update, but you are still using internally version 1.1.2.

No, the issue is that the developer forgot to update the internal info of the version in v1.1.3.
You are in version 1.1.3, but it show in Deckboard that you're in 1.1.2 because that's what it says in 1.1.3 asar.

Well, I don't see the changes in version 1.1.3 reflected in that packaging. Toggle Microphone option with icon change

Well, I don't see the changes in version 1.1.3 reflected in that packaging. Toggle Microphone option with icon change

Hmmm.
Here you can see the changes. Maybe we can implement on the asar:
https://github.com/aislandener/discord-deckboard/compare/v1.1.2...v1.1.3

Well, I don't see the changes in version 1.1.3 reflected in that packaging. Toggle Microphone option with icon change

Hmmm.
Here you can see the changes. Maybe we can implement on the asar: v1.1.2...v1.1.3
I tried to compile the main branch version and when I try to add the .asar file the deckboard program does not detect it.

Well, I don't see the changes in version 1.1.3 reflected in that packaging. Toggle Microphone option with icon change

Hmmm.
Here you can see the changes. Maybe we can implement on the asar: v1.1.2...v1.1.3

I tried to compile the main branch version and when I try to add the .asar file the deckboard program does not detect it.

have you tried removing the extension and installing directly from store? the version values come from this: https://github.com/rivafarabi/deckboard-extensions/blob/master/extensions/discord-deckboard.yml and the version seems alright


feat: update to eye v4.6.0

feat: update to eye v4.6.0

:tada: This PR is included in version 5.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v5.6.0

Your semantic-release bot :package::rocket:


[FEATURE] Expanded Biography tab

Just a suggestion to have Biography + Appearance moved to a separate tab, and give it a few more fields such as DOB/DOD/Apparent Age/Hair/Eyes/Height/Weight such as on MrGone's sheets.

One important thing to note is there's no field for Generation on the current sheets.

There isa Generation field, as soon as you fill in the Clan field. Then, all the necessary fields appear on the description tab.


Check getting started files for broken links - Issue 18568

Hi @aelisecarey!
Thanks for wanting to contribute to Bootstrap by sending this pull request!
Unfortunately, your pull request seems to have some problems:

The CNAME file should never be modified.
Changes must be made to the original Sass or Less source code file(s), not just the compiled CSS file(s).
Changes must be made to the original JS source code file(s), not just the generated concatenated JS file(s).

You'll need to fix these mistakes and revise your pull request before we can proceed further.
Once you've fixed these problems, you can either ask the maintainers to re-open this pull request, or you can create a new pull request.
Thanks!
(Please note that this is a fully automated comment.)

@aelisecarey I think you meant to open your pull request against the v4-dev branch instead of the master branch.


Can't see latest release version on Functions Core Tools install page

It's important to see the latest release of the tool and the specific latest version number in the install instructions.  This helps you know if you need the latest version.
Please compare to python, npm, docker and a number of other CLI home & download pages that make this super clear.
It's interesting even as you follow the links it's hard to land on the github releases to figure out for yourself that a version is the latest.
Expected: Latest 4.0.5210
Note, we also have way too many links and paragraphs on this page, including equally prominent links to 1.x-3.x versions which are unsupported.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b2646ad4-34b7-fc5e-dcc9-d53a061df394
Version Independent ID: bbff4fda-24e4-2b62-24b9-94cda5f53bed
Content: Work with Azure Functions Core Tools
Content Source: articles/azure-functions/functions-run-local.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@shreyabatra4

#assign:ggailey777

@paulyuk
Thanks for your feedback! We will investigate and update as appropriate.

@paulyuk the linked PR contains a bunch of updates to the Core Tools article. I don't know of a good way to surface the most recent version of Core Tools available in this doc and keep it up-to-date. We should take that discussion offline.

I see no fix here for the issue I raised.  Could you help me understand?

#please-reopen


Created Roadmapsynopsis.md

Synopsis for what each milestone entails.

@Alisha-Rashid and @rahmatzeb, please go through this synopsis to enhance your understanding of our new programs and milestones. Also, I updated descriptions of all the milestones so check out that as well.
Thanks.

@Aini-Bashir . Okay, got it...


Syntax error shown on f-string

Issue Type: syntax error
Syntax error with f-string in any version of Python :(
Extension version: 2019.10.44104
VS Code version: Code 1.40.1 (8795a9889db74563ddd43eb0a897a2384129a619, 2019-11-13T16:47:44.719Z)
OS version: Darwin x64 17.7.0
Expected behaviour
f-string
Actual behaviour
I get a SyntaxError: invalid syntax on my f-strings.
Steps to reproduce:
I am new to coding and VSCode. I checked different Python versions from VSCode menu - 3.8, 3.6(f-string should work with these versions as far as I know) and different code examples but all I get is a syntax error.
It's probably something related to VSCode configuration, I am note quite experienced on it yet.

Thanks for the bug report, but unfortunately we need some more information from you in order to triage this issue appropriately. Please edit your opening comment by providing a filled-in copy of our issue template. Once you are done please leave a comment to that effect.

Also, please give an example of an f-string that is giving you errors.

This is breaking on me, too. The f-string syntax is a shortcut for format strings. Here are some examples:
a='foo'
print(f"The string variable a contains: {a}")
Basically, it's almost identical to:
print("The string variable a contains: {a}".format(a=a))
In f-strings, the stuff in the brackets can be a python expression, so, may be hard to detect properly.  And, this works anywhere: message=f"Credentials:{pk} not found"
https://docs.python.org/3.7/tutorial/inputoutput.html

Please ignore the squigglies under the print itself. That's from having too many newlines, so I could take the screenshot more easily. The squigglies under the f-string show the issue.

This should be fixed now. Please file a separate bug if you continue to see this.


[5.0] Changed implementation of offsetGet in Request

Currently the offsetGet() implementation in Illuminate\Http\Request only looks for indexes in input(). This causes a problem when you're dispatching a command using Illuminate\Foundation\Bus\DispatchesCommands::dispatchFrom() because offsetExists() in Request uses the all() method rather than just the input() method.
This means that with the current implementation, a file upload from a request will be dispatched to a command with a null value rather than as an UploadedFile. The fix I propose will solve this problem by looking for the index in the all() method instead of just looking using input().

Was there a problem with the old implementation?

I'm sorry - I hit enter by mistake before finishing the description. I'll have this sorted in 5 mins...

The description is fixed now BTW - hope it all makes sense...

This looks like a change in behavior if the specified key doesn't exist. To me it look like it would have returned null before but now it will throw an error.

I've added in a check to make sure that the offset exists and now if it doesn't, it returns null like it does in the existing implementation.

I recon this would be better suited targeted at 5.1 rather than 5.0. What do you think @taylorotwell?

This would be a really useful feature for me because I like to handle file uploads with commands - if it comes in in 5.1 then that would be great :)

Please send this to 5.1.


Punctuation error on the landing page (footer section)

Which task do you want to work on?
Punctuation error on the landing page (Footer section)
Expected behaviour
"completing one minute survey!"
Actual behaviour
"completing one minute survey. !"
What needs to be done?
Remove the full stop and leave only the exclamation mark.
Who want to work on this issue?
Jolade (Outreachy Applicant)

Currently working on it @BatoolMM

Issue fixed @BatoolMM , awaiting your review
Thank you.

@Jolah1 Can I also join you in this task?

@Jolah1 Can I also join you in this task?

@GuddyTech i would love to but the issue has already been fixed in #141
Thank You.


Error: redirect url is missing state or code query parameters

Description
Describe your issue here.
I try to implemnt OAuth for my slack bot using bolt library, and I configuted my redirect URl as https://[my-domain]/slack/oauth_redirect, however I always got the same error as screenshot.
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[x] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
package version: 3.4.0
Browser: Chrome
node version: v14.16.0
Attachments:
My code follwoing throught bolt example, I am using firebase as database

When I install my app to other worksapce, this error happen.

Logs, screenshots, screencast, sample project, funny gif, etc.

Hi @qaz6209031! Are you attempting to install the application from the App Configuration? If so, you actually want install from the /slack/install endpoint. In your case, https://[my-domain]/slack/install (assuming the duplicate 'slack' in the URI you provided above was a typo).
Bolt creates this route for you behind the scenes and is where you'll find an Add to Slack button for your app to perform direct installs.
Let us know if that resolves the issue! 🙂

Hello @misscoded, thanks for responding, I was downloading from /slack/install end point and still have this issue.
The worse part is, sometimes it works and sometimes it gave me the above error. But I didn't change my code at all. Anyway it works now.

Hm, that's definitely unexpected behavior. Well, since you've indicated that it's working now, I'm going to close this issue, but if you encounter any further problems, don't hesitate to open a new issue and we'll help sort it out!


Move grunt tools to devDependencies?

Grunt and related plugins increase the t2-cli size from 13Mb to 24Mb. Can we move them to the devDependency section of our package.json?

They always have been. https://github.com/tessel/t2-cli/blob/master/package.json#L33-L43

Not figuratively, literally: https://github.com/tessel/t2-cli/commit/d84cd349deae75ab16af975514890505ac409303

My mistake!


[blog] Fix broken link to purchase MUI X Pro

See https://mui.com/blog/mui-x-sep-2024-price-update/#effective-date to reproduce the issue, it links to https://mui.com/store/items/mui-x-pro-q3-2024/. It has been broken for a week or so? Since the plan is live, we don't need this anymore.
By the way, I'm confused about the state of the products in https://store-wp.mui.com/wp-admin/edit.php?s&post_status=all&post_type=product&action=-1&product_cat=mui-x&product_type&stock_status&filter_action=Filter&paged=1&action2=-1. It looks like we have a bit of cleanup to do. If we happen to change the URL slugs, we will need to add 404 as old emails have been sent with the older URLs. Otherwise, I saw nothing broken, it seems to just be about a couple of draft products that seem a bit orphan.

It has been broken for a week or so? Since the plan is live, we don't need this anymore.

Once the plan is published, we should have added a redirect to the new link. For now, I've pushed a fix for this (https://github.com/mui/mui-private/pull/578), so the link should work

By the way, I'm confused about the state of the products

Yes, I'm also a bit confused because we have a few custom products that I'm not sure where they are used. There are a few drafts that I don't know if we can delete.
Probably we should make a document about price changes, add corresponding products from the WP, and give them clearer naming (e.g. agree on some convenience about naming, e.g. {Product} {ProductPlan} ({Term}) - {User-friendly description}.)

There are a few drafts that I don't know if we can delete.

@hasdfa Yeah, ok, we looked at it, those are not used, moved to the trash.

Merging this one, I think it's a simple one. We don't want to have to maintain this link in the future.


JSON file too big ?

Expected behavior
Try to upload a big JSON file (~20 MB, ~), full data uploaded in Firestore
Actual behavior
Got an error :
{ Error: 4 DEADLINE_EXCEEDED: Deadline Exceeded ... }
in client.js:64:15
in client.js:583:15
But i also got the "All done" message ... Strange
Is this a limit because of the size of the file or the time it takes to upload ?
Steps to reproduce the behavior

I've had this happen on large exports before. It happens when exceeding the quota for reads/writes in a given collection (see Firestore Quotas). On the export side, I catch the error, wait 1 second, then continue with the collection gathering.
On the import side, for some reason, I haven't seen that yet, but it makes sense that one would run into the same sort of limits. Out of curiosity, did all the data get imported, or were you missing some items? You might want to try running an export of the imported data and compare that to the original export to see if the files match. Let me know what you find out.

Can't replicate. If this is still an issue, please send me some sample data to {github<EMAIL_ADDRESS>

i've bumped into this exact thing today. i was uploading a subcollection with tonnes of documents and this happened.


client/service/metrics: Rework metric HELP texts

Adjust system related metric HELP texts, most notably:
       cpu_usage_percentage: register(Gauge::new(
-          "cpu_usage_percentage", "Node CPU usage",
+          "cpu_usage_percentage", "Process CPU usage, percentage per core summed over all cores",
       )?, registry)?,

With the above in mind the HighCPUUsage alert is useless as it does not include the number of cores the machine has. I will tackle that in a follow up pull-request.

bot merge


Avoid out of bound deoptimization

Hello!
We're using big.js in my current project and during performance investigation I've noticed that parse function is not optimized by v8:
$ node --trace-deopt perf/bigtime plus 10000 40

...
[deoptimizing (DEOPT eager): begin 0x56f390ee551 <JS Function parse (SharedFunctionInfo 0x29bdc58eaf01)> (opt #176) @26, FP to SP delta: 96, caller sp: 0x7ffe6414b770]
            ;;; deoptimize at </opt/sws/big.js/big.js:212:23>, out of bounds
  reading input frame parse => node=438, args=3, height=4; inputs:
      0: 0x56f390ee551 ; [fp - 16] 0x56f390ee551 <JS Function parse (SharedFunctionInfo 0x29bdc58eaf01)>
      1: 0x38684f02241 ; [fp + 32] 0x38684f02241 <undefined>
      2: 0xca5b39ee609 ; [fp + 24] 0xca5b39ee609 <a Big with map 0x453956506a1>
      3: 0xdca67660c89 ; rbx 0xdca67660c89 <String[1]: 0>
      4: 0x56f390cad01 ; [fp - 24] 0x56f390cad01 <FixedArray[18]>
      5: 1 ; rdx
      6: 1 ; rax
      7: 0x38684f02241 ; (literal 1) 0x38684f02241 <undefined>
  translating frame parse => node=438, height=24
    0x7ffe6414b768: [top + 72] <- 0x38684f02241 ;  0x38684f02241 <undefined>  (input #1)
    0x7ffe6414b760: [top + 64] <- 0xca5b39ee609 ;  0xca5b39ee609 <a Big with map 0x453956506a1>  (input #2)
    0x7ffe6414b758: [top + 56] <- 0xdca67660c89 ;  0xdca67660c89 <String[1]: 0>  (input #3)
    -------------------------
    0x7ffe6414b750: [top + 48] <- 0x7b375eab140 ;  caller's pc
    0x7ffe6414b748: [top + 40] <- 0x7ffe6414b788 ;  caller's fp
    0x7ffe6414b740: [top + 32] <- 0x56f390cad01 ;  context    0x56f390cad01 <FixedArray[18]>  (input #4)
    0x7ffe6414b738: [top + 24] <- 0x56f390ee551 ;  function    0x56f390ee551 <JS Function parse (SharedFunctionInfo 0x29bdc58eaf01)>  (input #0)
    -------------------------
    0x7ffe6414b730: [top + 16] <- 0x100000000 ;  1  (input #5)
    0x7ffe6414b728: [top + 8] <- 0x100000000 ;  1  (input #6)
    0x7ffe6414b720: [top + 0] <- 0x38684f02241 ;  0x38684f02241 <undefined>  (input #7)
[deoptimizing (eager): end 0x56f390ee551 <JS Function parse (SharedFunctionInfo 0x29bdc58eaf01)> @26 => node=438, pc=0x7b375ea645d, caller sp=0x7ffe6414b770, state=NO_REGISTERS, took 0.195 ms]
[removing optimized code for: parse]

It happens because of out of bound index access.
With the fix on my machine perf test works ~25% faster. Tested on v8: v4.8.4, v6.9.5, v7.7.3, v8.2.1 .
Hope it helps :)

Interesting.
Thanks, Vera.


CRA template imodeljs

These changes have been added for create react app template for imodeljs based app. It demonstrates the minimum setup for opening an iModel and viewing its graphics in a viewport with basic viewing tools.
For testing this use the following command from the directory where you want the create react app code to be generated.
npx create-react-app my-app-name --template file:<path_of_the_cra-template-imodeljs_folder> --scripts-version @bentley/react-scripts
my-app-name is the name of the create react app that gets generated.
Once the code gets generated, run the create react app and you should be able to open the imodel in browser.

@calebmshafer what is the use case for this as opposed to the existing itwin viewer cra template? Won't this confuse consumers even further? I thought the goal was to limit the amount of "getting started" methods

@kckst8, you're right, the default way we'll show in the Getting Started guides will be the itwin-viewer due to the lower barrier to entry, ease of use, and by default uses all of our iTwin Platform Services. The purpose of this template is for someone that,

Needs to customize the base application further than we want to allow overriding the twin-viewer
Doesn't want, or can't, to use our iTwin Services
Wants an example that you can easily extract the React pieces from it.

There's some work to do to make this one easier, but it would give some an idea of what they need to implement.

closing this due to the focus on the itwin viewer CRA templates instead.


Preliminary configuration integration to support deployment of Unity UI

The JSON file included in this PR will change, but we needed to add something so that we may begin iterating over as we learn and work through configuration details.
I hope the information contained in this configuration is sufficient for us to begin iterating over our UI Deployments via marketplace.

Woooo go Anil!

On 13 Mar 2024, at 16:48, Anil Natha @.***> wrote:
The JSON file included in this PR will change, but we needed to add something so that we may begin iterating over as we learn and work through configuration details.
I hope the information contained in this configuration is sufficient for us to begin iterating over our UI Deployments via marketplace.
You can view, comment on, or merge this pull request online at:
https://github.com/unity-sds/unity-marketplace/pull/5
Commit Summary
b6439e3 https://github.com/unity-sds/unity-marketplace/pull/5/commits/b6439e3cf7a4c495ecc6e26e316d6f9d7b6b1c4c Preliminary integration of configuration to support deployment of Unity UI application via Marketplace.
File Changes (1 file https://github.com/unity-sds/unity-marketplace/pull/5/files)
A applications/unity-ui/0.1/metadata.json https://github.com/unity-sds/unity-marketplace/pull/5/files#diff-fa50259cd88698e544f95d9af5cd84f8570a5d406c0308363fda9dd9eaf291fc (36)
Patch Links:
https://github.com/unity-sds/unity-marketplace/pull/5.patch
https://github.com/unity-sds/unity-marketplace/pull/5.diff
—
Reply to this email directly, view it on GitHub https://github.com/unity-sds/unity-marketplace/pull/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZI6HWDWYABEAYTSLI5XTYYB7PTAVCNFSM6AAAAABEURDQSOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4DINBXGE4TMMA.
You are receiving this because you are subscribed to this thread.


Sound Font not Loaded ¿why?

Hi Aurelius,
This library is awesome. Thanks for share it :-)
I'm testing how to use SoundFonts, but I can't load it, I don't know if I'm doing bad

Thanks in advance

You need to call fetchPresets: on the AKSoundFont object to trigger the actual loading of the data.

Thanks for your rapid response :-)
But I get the same

You should check the value of the loaded property from within the block you give to fetchPresets:, it's quite likely it hasn't actually finished doing the loading by the time you reach your print statement.
Also double check that your sf2 file is actually being included in your target so it will be copied with your binary.

fetchPresets callback is never called
soundFont.fetchPresets { soundFont in
    print("My font: \(soundFont)") // never is called
}

Yeah, the sf2 file is member of the target

I've made a repository https://github.com/carlosypunto/SoundFonts, could you check it?
Thanks in advance

I think it might actually be simply that AudioKit hasn't been properly initialized first, likely Csound is not able to load the file yet...

@megastep how I initialize AudioKit correctly?

Mostly you could start by creating an instrument, you can look at AudioKitDemo for some examples of that.
   _instrument = [[AKMidiInstrument alloc] init];
    _instrument.instrumentNumber = 1;
    [AKOrchestra addInstrument:_instrument];

Works!! Thank a lot


AttributeError: module 'inspect' has no attribute 'getargspec'. Did you mean: 'getargs'?

When I use compute_metric.py to evaluate the generation results, the console noted "no module named pyext." I installed it using pip and got the following error:
Collecting pyext
  Using cached pyext-0.7.tar.gz (7.8 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [9 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "...\AppData\Local\Temp\pip-install-exx9gznl\pyext_28002897deae467da164cbba24ad8613\setup.py", line 6, in <module>
          import pyext
        File "...\AppData\Local\Temp\pip-install-exx9gznl\pyext_28002897deae467da164cbba24ad8613\pyext.py", line 117, in <module>
          oargspec = inspect.getargspec
                     ^^^^^^^^^^^^^^^^^^
      AttributeError: module 'inspect' has no attribute 'getargspec'. Did you mean: 'getargs'?
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

After searching online, I found out that this is a Python bug and I'm using Python 3.11 to support OpenAI's models.
Upon further investigation, it appears that this issue doesn't exist in Python 3.8, so I downgraded the Python version to 3.8.
Moreover, Someone mentioned that the problem may be resolved in the second quarter of 2024: https://community.privacyidea.org/t/python-3-11-support/3115/2
I suggest providing some detailed environment setting on the guide page.

OK, thanks for your advice!


660: nicer error about choices sheet when extension omitted in select_.._from_file

Closes #660
Why is this the best possible solution? Were any other approaches considered?
Previously, an error about a missing sheet name may be thrown, e.g.  if the form didn't contain any regular choices. This change explicitly checks for file extension, in order to show a nicer error message. The existing constants, aliases, and validation pattern are used.
What are the regression risks?
I think this is just an enhancement, since the old behaviour was confusing, and in both cases an error is raised.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No it's already documented in the template, just an easy mistake to make

Before submitting this PR, please make sure you have:

[x] included test cases for core behavior and edge cases in tests
[x] run nosetests and verified all tests pass
[x] run black pyxform tests to format code
[x] verified that any code or assets from external sources are properly credited in comments

Yay, @lindsay-stevens out here making my life so much better! (And hopefully that of other users, too 😊)

Just got this error again, such a big improvement!


chore: first version of basic image carousel

Test URLs:

Before: https://main--helix-block-collection--adobe.hlx.page/block-collection/carousel
After: https://carousel--helix-block-collection--adobe.hlx.page/block-collection/carousel

Finally someone courageous enough to tackle the carousel! :-)
My only feedback on the current code would be: we know that for each project, we'll have different requirements, i.e. either write one from scratch or extend this one. To make the second option easier, I think it is important that in the source code (JS + CSS), we can easily identify which code is responsible for what: if I need to customise the arrows or the bullets, I know easily which code to adjust.


Unable to run cifar10_multi_gpu_train as is in TensorFlow master

Ubuntu 14.04
commit used: a154b6a7826760f30e368e84f51048218002d376
Simply changed num_gpus to 2. I have 2 GPUs. A 1060 and 970. Shows this error:
ValueError: Variable tower_1/tower_1/conv1/weight_loss/avg/biased does not exist, or was not created with tf.get_variable(). Did you mean to set reuse=None in VarScope?

Please can you provide all of the information requested in the issues template.

@prb12, @jkschin This is a duplicate of #5652

Ok - closing as dup of #5652


Add example links to devtools API pages.

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Due to the structure of the devtools API pages the examples macro isn't populating them with related web extension examples.
Add links to the examples on the devtools pages.

devtools.inspectedWindow and devtools.panels now include a "Example extension" section listing devtools-panels.


Revert "zh-translation: update pod-security-policy.md (#17333)"

Reverts kubernetes/website#20033
This one was accidentally merged. Should be reverted.

/lgtm


Rename source directory and improve CMake

We have renamed mavlink_vehicles directory in order to avoid annoying
repetition of names in paths. This is noted for example in cmake projects that
include this one as a subdirectory (as gazebo-sitl).
Also, cmake has been simplified and had its readability improved,
cmake_minimum_required has been properly checked and a special attention has
been given to avoid unnecessary compiler flags for different targets.
Signed-off-by: Guilherme Campos Camargo<EMAIL_ADDRESS>

LGTM


chore: Remove mockdb as it isn't working anyway

Output from a fresh Appsmith CE container:

To confirm again, the list of database doesn't include anything:

/test sanity

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9541763632
Commit: 87f2b15a152bfc488773059a159ac79ad3785f1c
Cypress dashboard url: Click here!

@sharat87 Shouldnt mockdb.appsmith.com on self hosted instances redirect to the local Postgres instance?

@mohanarpit, that was removed in https://github.com/appsmithorg/appsmith/pull/28998.


Add ability to shutdown TorCtrl after processing queue contents

Current behavior is to interrupt all currently queued jobs whenever shutdown or halt signal are enqeued. Need an option for not doing that, but to add it to the queue like any other command.

Need to think about this as it may require an API design change for TorCmd.Signal.Halt and TorCmd.Signal.Shutdown, which also may propagate to Action.StopDaemon

Not a necessity. Not happening.


[Suggestion] Minimize to tray?

Saw some work as been started on allowing tray minimization. Currently using nativefier for WhatsApp and would love to be able to have it close to the tray when I click the X instead of having it instantly get killed.
As a side-suggestion: any way to hide/toggle/remove the window border? Maybe a toggle of some sort that only makes it show up when you press Alt.

Yup, some work has gone into the tray minimization but is not complete yet. What do you mean by hiding the window border?

Hi. Sorry if this was already closed. Is the tray feature working? When I forked the project It didn't seem to have it, unless I missed some option or anything else.

Nope, it isnt working. It's abit complicated to get to to work cross-platform, and because there are some bugs in the way the icon is set I wish to fix that before adding the tray feature.

Oh, that explains it. When I first tried the application the one thing that bothered me was this, so I forked it and started working on the tray feature (I didn't experience much problems with the icon since I used a hardcoded path). The only matter is that it's tested on Windows only, I don't have much knowledge about IOS and Linux. However, I saw that someone already made a pull request with the feature so I think I'll wait for when It's done.
Thanks for the response.

Hello. Sorry to bother again. Two questions:

What are the complications/specifics to be taken into account for each platform?
What are these bugs with the icon?

I've been working on this feature (at least to use it privately). But before making a pull request I'd like to check if these things are considered/working.
I could test it on windows 10 and worked fine.
Thanks.

Hi there! Some work has already gone into the dock in #110 but I've unmerged it because of some issues with the icon not being done properly, and that fix has a few bugs for OSX and Windows.
I can't really remember the specifics, but off the top of my head, I know that there are some logical bugs on Windows; the icon for the .exe is not set, problems with .ico files, etc. I want to make sure that such logical errors are fixed before I add in the dock function, and I'll probably have time to work on this next week during my break.

Welp. Had I gotten a month earlier my pull request would have been useful. I'll se if I can find these bugs. If I can work them out I'll make a pull request.


add an option to opt out of USE_TYPO_METRICS

Added useTypoMetrics options to set REGULAR to fsSelection.
https://docs.microsoft.com/en-us/typography/opentype/spec/os2#fsselection
Use cases
We use custom icon fonts generated thanks to svg2ttf in Flutter project.
Flutter renders extra ascent when Use Typo Metrics is enabled. useTypoMetrics options will solve this problem.
https://github.com/fontello/svg2ttf/issues/95#issuecomment-631370838

@puzrin
Could you review please :pray:

closed this for personal reasons

@puzrin
Could you review please :pray:

Could you use fork for a while? I'm still busy with extremely urgent fixes on my project, which made all this stuff possible.

related
https://github.com/flutter/flutter/issues/98909

@puzrin
Could you please review this PR?
We are looking forward to this option!

I encountered the same problem when generating an icon font for a Flutter app.
I avoided the issue without changing the Use Typo Metrics flag. (Tested on Android and iOS) Based on some experimenting, the problem appears to disappear if the OS/2 sTypoLineGap is set to 0. Based on my understanding, this won't cause any problem as we use this for icons, not real fonts,
I monkey-patched the Font "class" using the following snippet based on the actual implementation and it seems to be working just fine.
import * as sfnt from "svg2ttf/lib/sfnt.js";
// ...
Object.defineProperty(sfnt.Font.prototype, "int_lineGap", { value: 0 });

This bypasses the built-in 9% of font ascent minus descent calculation.
I suggest adding a lingGap parameter to the options object. (SVG font face does not define a similar param.)


Hashlist name constrain error handling

Howdy,
When entering in a hashlist with a name that is 4 characters or below, e.g "flop" an error is generated:
{
    "message": "Key: 'HashlistCreateRequestDTO.Name' Error:Field validation for 'Name' failed on the 'min' tag"
}

This is fine, however it isnt clearly communicated to the front end:

Which makes it a little hard to diagnose whats wrong.
Version: v0.1.0
Thanks!

Error handling for the Wizard steps has been moved to the new toast error handlers now in commit 10866334d6725f21bec78141474bc952be50d999.
However I will leave this issue open with the following TODOs before we can finally close it:

[ ] Ensure the new toast error handling is used for all API requests, so errors are more obvious
[ ] Ensure the UI enforces all the same constraints as the backend, so these errors don't happen in the first place.
[ ] Write a custom error message format that is more friendly than what go-playground/validator gives us. For example, something like "'Name' needs to be a minimum of 4 characters" would be far better.


feat: add custom headers support

Summary
Added support for passing headers option down to contentful-management. I also added -H/--header option to the CLI.
A similar option/flag will be added to other related libraries as well (e.g. contentful/contentful-export#562).
Motivation and Context
To enable users to pass custom HTTP headers. This is especially useful when trying out alpha features.

I think it would be good to also add headers to list of known args for the built-in cli https://github.com/contentful/contentful-migration/blob/master/src/bin/usage-params.ts
Although contentful-migration is part of contentful-cli, it'd be great to have the same set of cli args for single command cli.
This is also relevant for import/export

I was under the impression these were deprecated. I added support for the CLI option in this PR and will do the same in contentful-export/import


[WIP] Add GBS device with trainable probabilities

WIP
This PR is an implementation of the prototyping PR https://github.com/PennyLaneAI/pennylane-sf/pull/40.

[ch570]


Figure out a better hover title

I'm going to think about this:
Ideas:

[ ] Keyboard Input
[ ] Keyboard Text
[ ] Keyboard Font
[ ] Keyboard Input Element

import random
list=["Keyboard Input", "Keyboard Text", "Keyboard Font", "Keyboard Input Element"]
print(random.choice(list))

Done:
I will use Keyboard Input!
Congrats Keyboard Input! You won! :)


update-infomer v0.5.0 build failure

Crate name
update-infomer
Build failure link
https://docs.rs/crate/update-informer/0.5.0/builds/531236
Additional details
Issues:

https://github.com/briansmith/ring/issues/1469
https://github.com/rust-lang/rust/issues/95267

The problem in the last 1.61.0-nightly (2022-03-23) build, because 1.61.0-nightly (2022-03-22) works fine.

The same problem https://github.com/rust-lang/docs.rs/issues/1705.

@mgrachev sorry for the delay here, I see that https://github.com/rust-lang/rust/issues/95267 is closed now.
Can you give it a try with nightly and ping me if it works? then I can requeue your build.

I've just tried and everything works.

I just enqueued a new build for this release (see https://docs.rs/releases/queue ).
Since it takes some time until it's done it would be awesome if you could close this issue when it works. Thanks!

I don't see any changes.

Looks like syphar copied the spelling mistake from the issue title when queueing. I've now scraped all our recent failures with this error and queued them up at low priority, I see that update-informer 0.5.0 is definitely in there (and I've bumped its priority above the others).

The problem was solved. Thanks a lot 💚


Fix being unable to fetch LLVM 9.0 on Mac OS

The name of the LLVM tar changed from "clang+llvm-{llvm_version}-x86_64-apple-darwin.tar.xz" to "clang+llvm-{llvm_version}-x86_64-darwin-apple.tar.xz" with LLVM 9.0.0.

Thank you for the PR. I will submit another commit to switch our default tested version to be 9.0.0.


Spike: Audit Endpoints

Goal
Endpoints are in a bit of an unknown state. Some endpoints are unused, some have requirements that are not used. This is a spike to test each endpoint and/or identify the current state of the endpoint. Please create a markdown document and specify in a table each Endpoint, the State, and any Action necessary.
If necessary, open a ticket for any issues regarding that particular endpoint. Do NOT fix any issues.
Checklist

[ ] All 56 endpoints documented in a markdown file in the teams repo
[ ] All endpoints checked

Note: This should be an iterative spike, don't wait until the end to fill in the table

[ ] Tickets created

Timebox
Some of these are very simple, some are complex. 56 endpoints, roughly 15 minutes per endpoint average.... lets call this timebox 3 working days to account for ticket creation and a little breathing room.
Out of Scope

No fixes! Create tickets with the problem, allow the person working it to identify solutions.

@mjones-oddball @tabinda-syed @k-macmillan perhaps we could prioritize this ticket? It looks like some of the unittests that are being fixed for the Flask upgrade are actually unused by the service anymore (for example, Users are created in the portal now and now via our API endpoints). Once we have an audit, we can determine what needs to be removed from the repo. Thoughts?

@cris-oddball @k-macmillan Should we maybe break it down into... Ticket 1) Documenting the 56 endpoints in an md file and having the team update the chart for endpoints we regularly use and know are in use Ticket 2) Reviewing the list with strike against which features have been added to portal so far and what's up next to determine if all functionality for these things has been FULLY absorbed by portal or not and flagging these endpoint and their status 3) Testing remaining endpoints, maybe we break this up - depends on the size of the list after 1 & 2 are done.

It's unfortunate we hadn't done this work before the upgrade.
I think the suggested breakdown makes it more manageable but I think Ticket 1 and 2 should be combined. Ticket 2 should be an hour with Strike and it can be done concurrently after the initial table has been made.
I like the idea of testing them being a separate ticket! It is a big unknown so to try and point it now would be difficult.

@tabinda-syed Could you check with Zack and see if he's amenable to sharing ownership of a ticket that has both Notify and Strike labels on it? So Notify would create the doc with the list of endpoints and Strike would then review and update the doc with feedback on the endpoints affected by portal work.

@mjones-oddball The Strike board doesn't pull from this repo, so we'll create a ticket to review this doc on the Strike board and will keep an eye out for this one as it gets done. If Notify can pick up this ticket during the first week of the sprint, Strike will plan to pick up the corresponding review ticket during the second week.
FYI, @zlaw

Spoke with Tabinda offline - we can recreate in vanotify-team repo which is shared if that works.

@cris-oddball Since you raised a concern about needing this - is it ok if we break down/refine this sprint with the intention of seeing if part 1 can happen on both notify/strike the following sprint? CC @zlaw @tabinda-syed @k-macmillan

@mjones-oddball sounds good.


Change HeifError base class from BaseException to Exception

The python document recommends using Exception instead of BaseException.

The built-in exception classes can be subclassed to define new exceptions; programmers are encouraged to derive new exceptions from the Exception class or one of its subclasses, and not from BaseException. More information on defining exceptions is available in the Python Tutorial under User-defined Exceptions.

https://docs.python.org/3/library/exceptions.html

This can be a breaking change if users try-except with BaseException to catch HeifError.
I'm not a daily python coder so I don't know BaseException is popular one but as document doesn't recommend, the impact probably be small.


[CARBONDATA-1060]Query statistics issue in case of multiple blocklet and block

Query statistics issue in case of multiple blocklet and multiple block

Build Success with Spark 1.6.2, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2051/

Keep the jira id to title

LGTM


feat: Make split panel visible when collapsed at the bottom also in new toolbar layout

Description
Issue: AWSUI-60031
Now the split panel in the new toolbar layout behaves the same as in the old layout when it is displayed at the bottom:

When collapsed:

it does not completely disappear but instead the header and the open button keep being visible overlaying the bottom part of the content
the focus moves to the split panel's own open button instead of the toolbar's split panel trigger

The findSplitPanelOpenButton test util will return the open button in the split panel and not the toolbar split panel trigger

How has this been tested?

Manually on dev pages
Adapted existing tests
Ran through my pipeline, got an expected diff
Dry run<PHONE_NUMBER>)

Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness

Changes include appropriate documentation updates.
Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
Changes do not include unsupported browser features, see CONTRIBUTING.md.
Changes were manually tested for accessibility, see accessibility guidelines.

Security

If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

Changes are covered with new/existing unit tests?
Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This change broke split panel slide in animation.
It works fine in the mainline and does not on your PR preview build: https://d21d5uik3ws71m.cloudfront.net/components/783ac3514ee5eb19adb067e5c023a114f456691e/dev-pages/index.html#/light/app-layout/with-split-panel?appLayoutToolbar=true

This change broke split panel slide in animation.

Thanks for noticing! This was addressed in the latest commit (c074481).


'list lilypond' and 'search lilypond' commands lock up

lyp list lilypond and lyp search lilypond commands lockup for a few minutes on my machine, before proceeding. Tried some other commands, work fine.
Versions:

lyp: 1.3.8
ruby: 2.4.1 via rbenv
OS: Mac OS 10.13.3 (High Sierra)

To help me pinpoint the problem, try running the following two commands and let me know which of them hangs:
ruby -r lyp -e "p Lyp::Lilypond.list(system_only: true)"

ruby -r lyp -e "p Lyp::Lilypond.list(lyp_only: true)"

Hi @ciconia, the first one hangs. Thanks!

I suspect you have one or more versions installed on your system (not by lyp) that have not been "primed".
When listing the currently installed "system" Lilyponds, lyp runs each version it found with a special .ly file it uses to detect both the version and the location for data files for that particular version of Lilypond (this information is used mainly when installing fonts).
Some versions of Lilypond take quite a while to run the first time (because they generate font cache files I think). I know there was at least one recent version (of the 2.19 unstable strain) that had a problem with the cache and used to regenerate it each time it was run, which lead to it appearing to be hung.
You can get a list of all the installed lilyponds on your system by running which -a lilypond (this will also include the lyp-provided lilypond wrapper script). You can then try to run each one with a short sample file and see which of them hangs. If it hangs repeatedly, you can remove it if you wish.
Let me know if you found the culprit. At the moment I do not believe there's anything wrong with the detection code in lyp, which, again, is necessary for its correct functioning.

Hi @ciconia , I have verified that I don't have any lilyponds on the path except for one installed by lyp (I didn't ask lyp to install lilypond) and when I try to run it, it hangs:
$ gem uninstall lyp
Remove executables:
	lyp, lilypond

in addition to the gem? [Yn]  y
Removing lyp
Removing lilypond
Successfully uninstalled lyp-1.3.8
$ rbenv rehash
$ which -a lilypond
$ gem install lyp
Fetching: lyp-1.3.8.gem (100%)
Successfully installed lyp-1.3.8
Parsing documentation for lyp-1.3.8
Installing ri documentation for lyp-1.3.8
Done installing documentation for lyp after 0 seconds
1 gem installed
$ lilypond
# Gets stuck

I have a version not on the path as part of LilyPond-Mac OS app install, and that one works fine.

BTW, I am running under https://github.com/rbenv/rbenv -- could this be related?

Hi @ciconia, any suggestions?

Sorry for the late reply. I guess this does have something to do with rbenv. I don't have any experience with it. I use rvm on all my machines. I'll try to look more into this, but it will probably take some time as I'm currently very busy with other stuff.


Use wp_prepare_attachment_for_js hook to rewrite image URLs when CDN is enabled

On the official support forum, one user reported that images loaded via JavaScript generated by the Beaver Builder plugin do not get pulled from CDN.
According to the plugin authors, they're using wp_prepare_attachment_for_js() prior to generating JS files containing image URLs. Many slideshow plugins appear to use this function to load images dynamically, so this issue affects more than just Beaver Builder users.
I suggest applying a filter on wp_prepare_attachment_for_js() that rewrites image URLs to use the CDN when that setting is enabled. Some things to consider:

The filter would have to take into account the Custom File List and other rules regarding files/paths that are allowed to be rewritten
The filter would have to run prior to concatenation/minification of JS files, so that the filtered JS is included in the minified output

I'm probably missing something, but welcome your thoughts and feedback on this.

Yea that sounds like the right plan for sure.
Right now i'm distracted assisting someone else with what appears to be a very ancient bug in w3tc (re: posts/pages set into drafts/pending review) so i am just hunting it down and fixing it.
Kimberly :octocat:

Hi @andreslucero  ... I think i fixed it.  I haven't PR'ed it yet though  Can you give this a try: https://github.com/szepeviktor/w3-total-cache-fixed/commit/55429de5192fab0a97c12e626b46a476a1c6d847


Issue with Manage Images

Hi, awesome plugin.
The issue I am having is when when trying to insert an image via the browser button, I expect to see a list of images but I see an empty modal window.
Looking into the request in chromes network panel, I can see I get a 404 error when a request is made to "/nova-vendor/froala-field/image-manager?resource=articles&field=content"

Did you enable attachments functionality as described in this section?
https://github.com/froala/nova-froala-field#attachments-usage

Yes I have. Including the migrations.

Could you please show me your content field declaration in Nova resource?

Froala::make('Content')->withFiles('public'),

Are you creating or updating resource? Maybe you routes are cached and /nova-vendor/froala-field/image-manager not applied. I have tried on creating and updating pages, it works fine.

My routes isn't cached. I cleared them just in case they were.
I am Using Nova 2 and Laravel 5.8.
I know it reaches FroalaImageManagerController@index
Doing a bit of digging
The function that throws the 404 is $request->newResource();
Going into that the line is abort_if(is_null($resource), 404); that is the actual thing that throws the exception.
This is in line 51 of InteractsWithResources.php. I can see that $resource is null when I dump that variable

Not file example, project example, to give me ability to reproduce the issue.

I've invited you to a github repository that you can clone and see the issue.

I have found an issue. According to the latest Nova updates, logic of resource retrieve was changed, as a result it broken image-manager functionality. I will be fix it soon. Thanks for your report!

Fixed in 2.2.0

Hello,
I have also problem with Image Manager functionality.
I have set up attachments and seem to be working correctly (uploading is done as expected), however when I click on the "Browse" button to bring up the image manager, the modal is empty:

On my "Network" tab in debug tools, I am getting "Status 200 OK" when hitting image-manager?field=body, but the response is just an empty [].
Using Nova 2.0 and Laravel 5.8.27.
Thank you,
Ilias

Turns out, it is the following if statement in AttachedImagesList.php that causes images not to appear.
if (! app()->runningUnitTests() and ! @getimagesize($Storage->url($file))) {
    continue;
}

Is there a reason this exists?
Thanks,
Ilias

This condition checks whether the file is an image. So if it's not, it will not appear.
Which files not passes this check in your case?

I am getting the following warning:

"getimagesize(): php_network_getaddresses: getaddrinfo failed: Temporary failure in name resolution"

Note that I have not made any modifications in PHP configuration or so, it is all Laravel Homestead's default settings.
Maybe there is another way to check for the file type?
In PHP manual it states the following:

Do not use getimagesize() to check that a given file is a valid image. Use a purpose-built solution such as the Fileinfo extension instead.

Yes, I know about this note, but other solutions can't work with remote images, for example stored on s3 disk.

Hello,
I have also problem with Image Manager functionality.
I have set up attachments and seem to be working correctly (uploading is done as expected), however when I click on the "Browse" button to bring up the image manager, the modal is empty:

On my "Network" tab in debug tools, I am getting "Status 200 OK" when hitting image-manager?field=body, but the response is just an empty [].
Using Nova 2.0 and Laravel 5.8.27.
Thank you,
Ilias

I met the same situation , Do you guys come up any idea to solve abt that ?

Try to find an issue with getimagesize in your PHP interpreter.

Just an idea. Check if the driver is local and if so use path instead
if (config('filesystems.disks.aalund.driver') == 'local') {
        $path = $Storage->path($file);
    } else {
        $path = $Storage->url($file);
    }

    if (! app()->runningUnitTests() and ! @getimagesize($path)) {
        continue;
    }


Get rid of ComponentContainer

I think it would be better to move most of the class' logic to the parent Container class.

Nope. It's here to stay. At least for the time being. 💪


Composer package registry "dev-main"/"dev-master" package version

Feature Description
The built-in Composer package registry needs the automatically generated "dev-main"/"dev-master" version that points to the current main/master/[whatever we choose to call it] branch of a repository like we get on Packagist:

Screenshots
No response

The packages in the registry don't have a link to a repository. They are just uploaded archives with the source code.

A bit older question, but is this not supported yet? I have a package that I version with semver and that works fine, if I don't push tag, it fallbacks to version=dev-main, but putting the package to composer?version=dev-main or even "dev" will fail with error {"status":400,"message":"package version is invalid"}


Minor wording change in error message for Try().peek(Consumer, Consumer)

Codecov Report

Merging #2661 (9667cab) into master (a09f8cc) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #2661   +/-   ##
=========================================
  Coverage     92.87%   92.87%
  Complexity     5370     5370
=========================================
  Files            89       89
  Lines         12790    12790
  Branches       1620     1620
=========================================
  Hits          11879    11879
  Misses          722      722
  Partials        189      189

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/io/vavr/control/Try.java
96.46% <0.00%> (ø)
103.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a09f8cc...9667cab. Read the comment docs.


update

Summary

Ticket Link

Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] read and understood our Contributing Guidelines
[ ] completed Mattermost Contributor Agreement
[ ] executed npm run lint:js for proper code formatting
[ ] Run E2E tests by adding label Run Desktop E2E Tests

Device Information
This PR was tested on:
Screenshots

Release Note

Hello @offsoc,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.


Update travis resiliency

Coverage decreased (-9.09%) to 82.931% when pulling 5c1fb135799875a6e16360bcf10f7609f438a80a on travis into 07df250849f471fb5930674b9f280e577f0d52c3 on master.


Update aws-sdk-go library to latest release

From version 1.0.5 to version 1.15.74.
Simply because the old version was really old - December 2015.

@bboreham Is this still a WIP or it's ready for review?
I could take a look if I get more context about which parts of Scope (if any) should be affected :)


Hello，Daughter of the Void（Kai’Sa）BUG

#350 Daughter of the Void（Kai’Sa）After death, it becomes transparent and the character cannot be displayed, can you fix this bug?

#338

#338

谢谢

13.5.2修復了嗎


Create a dataflow between ViewModel and View

Hi raf, here you can see the dataflow that we were talking about.
This way the only thing that fragment is do is observing viewModel and passing user interaction, so no logic in the view itself.
ofc this can done using a single observable too, we can talk about that later after you reviewed this one :D

Thank you for your suggestions, I just pushed an update in both View and ViewModel.


(MJWWHL) - Wheel of Fame - crashes on entry

Unhandled exception. System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'Unable to locate FFFF:02F9')
at MBBSEmu.Memory.MemoryCore.GetWord(UInt16 segment, UInt16 offset)
at MBBSEmu.CPU.CpuCore.GetOperandValueUInt16(OpKind opKind, EnumOperandType operandType)
at MBBSEmu.CPU.CpuCore.Tick()
at MBBSEmu.HostProcess.ExecutionUnits.ExecutionUnit.Execute(IntPtr16 entryPoint, UInt16 channelNumber, Boolean simulateCallFar, Boolean bypassState, Queue1 initialStackValues, UInt16 initialStackPointer)    at MBBSEmu.Module.MbbsModule.Execute(IntPtr16 entryPoint, UInt16 channelNumber, Boolean simulateCallFar, Boolean bypassSetState, Queue1 initialStackValues, UInt16 initialStackPointer)
at MBBSEmu.HostProcess.MbbsHost.WorkerThread()
at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.ThreadHelper.ThreadStart()

Wheel of Fame appears to support RIP graphics.
To detect if the user is using RIP graphics, it checks int clingo to get the index of the language the user is using (for MBBSEmu, this will always be 0) and then looks up that index in struct lingo **languages;
Property for MAJORBBS.761 (int clingo) needs to be created with a value of 0. Additionally, MAJORBBS.762 struct lingo **languages; needs to be implemented. From the disassembly, it appears the first value in the lingo struct is a char* to the language string. Setting this value to ansi should instruct the module to continue operation in ANSI mode.


doc: added an account of the overall experience and included a link t…

…o the essence document #38

LGTM


A collision is not detected if starting in a collision state

Actually, I think I was confusing this with another issue.

Correction: this is still an issue, but only in simulation mode. Hardware mode is fine.


fixed unique constraints

Resolves #32 .
I had thought about this when I was initially creating it, and for the longest time tried to use UniqueConstraint from the django.db.models  module and it kept failing to makethemigration.
Now with a fresh mind I have realized that UniqueContraint is only for django 2.2+ and we are on 2.15 :'(
Should we upgrade? Benefits include more functionality. Possibly breaks our app lol

I think we should upgrade

Agree with Will


L.tileLayer issues when zoomReverse and detectRetina are true

I'm not sure it's a bug. When zoomReverse and detectRetina are true, the adjusted zoomOffset may be wrong. Go to line 2458(Leaflet 0.7.3) and add check
if (options.detectRetina && L.Browser.retina && options.maxZoom > 0) {

	options.tileSize = Math.floor(options.tileSize / 2);
	options.zoomOffset++;

	if (options.minZoom > 0) {
		options.minZoom--;
	}
	this.options.maxZoom--;
}

change to this
if (options.detectRetina && L.Browser.retina && options.maxZoom > 0) {

	options.tileSize = Math.floor(options.tileSize / 2);
	if (!options.zoomReverse) {
		options.zoomOffset++;
	}

	if (options.minZoom > 0) {
		options.minZoom--;
	}
	this.options.maxZoom--;
}

It seems works fine.

Does it work in master?

I just test this codes with master, it seems also works fine.

OK, safe to close then.

Sorry, I mean the problem is also in master. If zoomReverse and detectRetina both set true in L.tileLayer options, map didn't show the tileLayer. But if go to line 31(TileLayer.js) and change
https://github.com/Leaflet/Leaflet/blob/master/src/layer/tile/TileLayer.js#L31
options.zoomOffset++;

http://jsfiddle.net/lamperder/ghz3j3y6/1/
to
if (!options.zoomReverse) {
    options.zoomOffset++;
}

http://jsfiddle.net/lamperder/q4puoke7/
My English isn't very good, please don't mind.


Loxodon: Trunk change

Is your feature request related to a problem? Please describe.
I think it'd be a really funny and cool thing to make the feature for Trunk on the Loxodon just be a reskinned additional Unarmed Strike using its icon image.  Cause in the features description it says you can use it to make an unarmed strike.  Right now its just a basic passive feature with a description.
Describe the solution you'd like
Just Clone your typical character imported Unarmed Strike and slap the passive feature's description onto it.
Describe alternatives you've considered
N/a
Additional context
https://www.dndbeyond.com/races/67607-loxodon#LoxodonTraits

Nice!


RAM power consumption

Hi

CodeCarbon version: 2.3
Python version: 3.9
Operating System: Windows

As far as I learned from documentation, codecarbone estimates ram power consumption based on a rule of thumb:
"RAM
CodeCarbon uses a 3 Watts for 8 BG ratio source . This mesure is not satisfying and if ever you have an idea how to enhance it please do not hesitate to contribute." So, codecarbone doesn't measure power consumption of ram directly.
If one install Intel® Power Gadget, there is panel showing specifically ram power. Given the fact that codecarbon uses Intel® Power Gadget in background, my question is why codecarbon relies on the rule of thumb above for ram power consumption and why codecarbon doesn't use Intel® Power Gadget for ramp power consumption.
Thank you so much

Hello,
Thanks for pointing this out. It seems that it depends on the CPU (or chipset ?) you are using, but it will be a great improvement.
The reason we did not do it is just a lack of contributor to the project.
If you want to contribute on this I will be happy to help you.
For the record, here is the code we use for CPU with Intel® Power Gadget : https://github.com/mlco2/codecarbon/blob/9a840204eda830735e8817e708a7b4d90d0f7bff/codecarbon/external/hardware.py#L172

Thank you for your reply. You're referring to a good point that does the ram power consumption depend on cpu or not. I've been investigating .....

Another example of RAM estimation problem: I'm running my code on a cluster and CodeCarbon see the total RAM of the cluster, and all the CPU:
[codecarbon INFO @ 08:18:04]   CodeCarbon version: 2.3.1
[codecarbon INFO @ 08:18:04]   Available RAM : 1007.352 GB
[codecarbon INFO @ 08:18:04]   CPU count: 104
[codecarbon INFO @ 08:18:04]   CPU model: Intel(R) Xeon(R) Gold 5320 CPU @ 2.20GHz
[codecarbon INFO @ 08:18:04]   GPU count: 1
[codecarbon INFO @ 08:18:04]   GPU model: 1 x NVIDIA A2

So the estimations give 377W for RAM and 59W for GPU while training a model:
------------------------
[codecarbon INFO @ 08:24:24] Energy consumed for RAM : 0.039332 kWh. RAM Power :<PHONE_NUMBER>0769653 W
[codecarbon DEBUG @ 08:24:24] RAM : 377.76 W during 14.99 s [measurement time: 0.0005]
[codecarbon INFO @ 08:24:24] Energy consumed for all GPUs : 0.006199 kWh. Total GPU Power : 59.644690577283775 W
[codecarbon DEBUG @ 08:24:24] GPU : 59.64 W during 14.99 s [measurement time: 0.0027]
[codecarbon INFO @ 08:24:24] Energy consumed for all CPUs : 0.009636 kWh. Total CPU Power : 92.5 W
[codecarbon DEBUG @ 08:24:24] CPU : 92.50 W during 15.00 s [measurement time: 0.0001]
[codecarbon INFO @ 08:24:24] 0.055167 kWh of electricity used since the beginning.
[codecarbon DEBUG @ 08:24:24] last_duration=14.994339942932129
------------------------

A way to have info on ram units : sudo lshw -C memory -short | grep DIMM
Sample output:
/0/37/0                                    memory         8GiB DIMM DDR4 Synchrone Unbuffered (Unregistered) 2400 MHz (0,4 ns)
/0/37/1                                    memory         8GiB DIMM DDR4 Synchrone Unbuffered (Unregistered) 2400 MHz (0,4 ns)
/0/37/2                                    memory         8GiB DIMM DDR4 Synchrone Unbuffered (Unregistered) 2400 MHz (0,4 ns)
/0/37/3                                    memory         8GiB DIMM DDR4 Synchrone Unbuffered (Unregistered) 2400 MHz (0,4 ns)

CodeCarbon rely on a metric from Crucial that said :

you want to allocate around 3 watts of power for every 8GB of DDR3 or DDR4 memory.

Now they say:

Maximum 5 watts per module for standard consumer memory

An nice article of Boavizta on the subject https://boavizta.org/en/blog/estimer-la-consommation-electrique-d-un-serveur-dedie says that RAPL could be use to monitor RAM power, that will be better in supported configuration.

We will have a look to this in #717 . It means we have to find a way to count the number of module.
I will close this issue. Please comment in #717 if you want to add something else.


cloud-print-connector: 1.11 -> 1.16

Motivation for this change
cc @Hodapp87
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build cloud-print-connector


Note for bid_scheme lowercase sensivity

while testing I figured that we can only use the lowercase name for bid_scheme, it did not work with camelCase or UPPERCASE

I fixed this issue in another PR.
Thanks for the cooperation.


#98: Pass $refs to resolvers

This allows resolvers to understand more of
the context around what they are resolving.
Ex. $refs._root$Ref.path indicates
the file being dereferenced.

Pull Request Test Coverage Report for Build 335

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.9%) to 92.877%

Totals

Change from base Build 331:
-0.9%

Covered Lines:
665

Relevant Lines:
702

💛  - Coveralls

Pull Request Test Coverage Report for Build 335

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.732%

Totals

Change from base Build 331:
0.0%

Covered Lines:
668

Relevant Lines:
702

💛  - Coveralls

Pull Request Test Coverage Report for Build 335

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.9%) to 92.877%

Totals

Change from base Build 331:
-0.9%

Covered Lines:
665

Relevant Lines:
702

💛  - Coveralls

Pull Request Test Coverage Report for Build 335

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.732%

Totals

Change from base Build 331:
0.0%

Covered Lines:
668

Relevant Lines:
702

💛  - Coveralls

Sorry this took me so long to merge.  Thank you for the work!


Updated linter and .clang-format for ROS2

Some of the style guidelines have changed for ROS2, and since we want to keep a consistent style throughout ROSflight, I'm updating the firmware as well.
Lately, the existing format linter has also been disagreeing with the changes made by the fix_code_style.sh script, which has been pretty annoying. So this updates the action item to use a newer version as well, fixing the issue.

F1 and F4 builds are currently broken, but are going to be removed shortly and replaced with a working build.


Update package.json to fix nan error

Removes the nan error.
../../nan/nan_maybe_43_inl.h:112:15: error: no member named 'ForceSet' in 'v8::Object'
  return obj->ForceSet(isolate->GetCurrentContext(), key, value, attribs);

@crazywolf132 which version of Node/Electron are you seeing this error on?

Hahahaha, i cant even remember what project this was for. It was that long ago i moved on.

It should have been the latest of both though.
But i remember it was another module causing it. The only fix was to update this module to the latest Nan.
It was even discussed on a stack overflow if i remember correctly. They were saying to go into this module and edit its package.json, so others wouldn't freak out. So i thought why not just push the fix to you guys.
Then no one has to mess around with anything.

We are now on 0.24, so should be safe to close.