Work with matches to have attribute determining if match is part of tournament

This task involves communicating with the Matches team to determine how to differentiate a match in a tournament versus a match outside of one. Some aspects that could uniquely define a tournament match could be a win condition and a live chat that is recorded after the game is concluded.

Communication with the Matches team went well. They left their comments regarding how they're implementing matches in this Wiki link. In short, they view our current ERD as a "super-lobby" in which several Lobby entities are initialized when a Tournament object is initialized. They suggest that "In this way, we can create an easy integration of the matches and tournaments functionality: just plug matches in, through the creation of this lobby." So I believe that is the approach we are going with, but if this turns out to be problematic in the future, we can always go back and change it. I'm closing this issue for now since both teams seem to agree on how that integration will occur, but if we need to revisit this thought process we can always reopen this issue.

Issue Score: Excellent
Comments:
Going to give this a minor rating, as most of the work was done from the matches front. Good work regardless documenting your progress on this issue!


Worker crashes when there is an error deserializing the handler

# Note: this delegator has a __getobj__ method but no __setobj__
class TestClass < Delegator
  def initialize obj
    @obj = obj
  end

  def __getobj__
    @obj
  end
end

Kernel.delay.puts(TestClass.new('foo'))
Delayed::Worker.new.work_off
# => NotImplementedError: need to define `__setobj__'
#    from /Users/afn/.rvm/rubies/ruby-2.3.0/lib/ruby/2.3.0/delegate.rb:168:in `__setobj__'

I would expect the worker to flag the job as errored and continue on, rather than crashing.
Will follow up shortly with a PR.

Closing stale


[SPARK-42790][SQL] Abstract the excluded method for better test for JDBC docker tests.

What changes were proposed in this pull request?
Currently, The JDBC V2 test cases create a lot of method that tests some syntax or function. It is very easy missing the test cases if developer forget to call it.
This PR let all the JDBC V2 could execute these tests by default. If one database doesn't support the related syntax of function, developer have to add the name of this test case to excluded list. We can ensure that use cases are tested.
Why are the changes needed?
This PR abstract the excluded method for better test for JDBC docker tests.
Does this PR introduce any user-facing change?
'No'.
Just related to tests.
How was this patch tested?
Just related to tests.

ping @huaxingao cc @cloud-fan

Merged to master

@srowen Thank you! @cloud-fan @huaxingao Thank you too!


How can I access non-static functions and variables in FunkinLua using HScript

What is your question?
I seem to be having a problem where I can't access functions and variables contained in FunkinLua without the static keyword. This is a problem since I'm trying to access some of the shader related variables contained within said file, such as public var runtimeShaders and initLuaShader, through HScript.
However when doing this a lua trace error appears saying something along the lines of "Null Function/Null Function Pointer", but this only seems to happen with non static variables.
Snippet that works:
function onCreate()
        addHaxeLibrary('FunkinLua', 'psychlua')
        runHaxeCode([[
                FunkinLua.luaTrace('luaTrace is a static function ftr', false, false, 0xFFFFFFFF);
        ]])
end

Snippet that DOESN'T work
function onCreate()
        addHaxeLibrary('FunkinLua', 'psychlua')
        runHaxeCode([[
                // initLuaShader is a standard non-static function ftr
                FunkinLua.initLuaShader('shader');
        ]])
end

This wouldn't be as confusing if I couldn't access non static variables from other states, such as, well, PlayState.
Any help on how to fix this or even why this happens would be greatly appreciated.

parentLua

it works!
thanks man, you have no idea how much this helps me :)


Some Automation Tasks for Safari break terminate my workflow  if no Safari Window open

"Current Safari Tab", "Safari Tab List" or "Close Current Safari Tab" break when used against Safari with no window open. I suggest a reasonable output in these cases like empty list or empty string, so I do not have to make extra test before using such tasks.
To reproduce:

Build simple worklflow with Automation Task Current Safari Tab" piped into Debug.

Run with several Safari Windows open:

[16:42:41.309] test[Keyword] Processing complete
[16:42:41.314] test[Keyword] Passing output '' to Automation Task
[16:42:41.315] test[Automation Task] Running task 'Current Safari Tab' with no arguments
[16:42:41.863] test[Automation Task] Processing complete
[16:42:41.867] test[Automation Task] Passing output 'https://github.com/alfredapp/automation-tasks/issues/9' to Debug

Now Close all Windows and run again:

[16:42:41.868] test[Debug] 'https://github.com/alfredapp/automation-tasks/issues/9', {}
[16:43:41.341] test[Keyword] Processing complete
[16:43:41.342] test[Keyword] Passing output '' to Automation Task
[16:43:41.344] test[Automation Task] Running task 'Current Safari Tab' with no arguments
[16:43:41.520] ERROR: test[Automation Task] Task Error: No windows found.

Task Error terminates my workflow!
Compare with this the next test case:

Quit Safari and run again:

[16:44:07.126] test[Keyword] Processing complete
[16:44:07.128] test[Keyword] Passing output '' to Automation Task
[16:44:07.129] test[Automation Task] Running task 'Current Safari Tab' with no arguments
[16:44:09.999] test[Automation Task] Processing complete
[16:44:10.004] test[Automation Task] Passing output '<null>' to Debug
[16:44:10.006] test[Debug] '<null>', {}

Here the task returns a reasonable output, that is ok.

Alfred 5.1.4 and Automation Tasks 2023.8
Safari 17.2 and macOS 13.6.3 (22G436)

I’m rethinking the approach here. While in some cases it makes sense to continue even if nothing is found (closing current tab), in others (getting current tab) it does make sense to stop, because otherwise the workflow may not do what is expected and those people will need to do their own check afterwards.
Could you expand on your real use case, so I have more data to think with?

My real use case is a little helper to switch to a new Private/Public/Profile window:
The workflow starts with a List Filter where I choose the desired window type.
If Safari is the front app, it passes the URL of the frontmost tab, close this tab and pipe the URL to open it in a new created window of the desired type. Otherwise the workflow finally opens an empty window.
 So I had to implement this functionality myself with a run script:
on run argv
  tell application "Safari"
	if (count of windows) > 0 then
		set ct to current tab of window 1
		set theURL to URL of ct
		tell ct to close
		return theURL
	end if
  end tell
  return "*no window*"
end run

I think the automation tasks should only throw an exception if a situation has arisen that cannot be handled by the workflow in a meaningful way. It is sufficient if the documentation for a task describes the output in such edge cases, example "Output: URL of closed tab or empty string if no tab exists."

Both cases are valid and should be supported. Just released 2023.9.
In the Browser Automation Tasks you can now find an Allow empty result when no windows are open. It also does more checks (e.g. if the browser is not running) if that box is unticked. For your use case you want to turn the checkbox on, but I’ve made it off by default to also better support workflows made before this update.


Updated the MVC tutorial for React 16

I had issues that many others have had with getting the server rendering of this tutorial to work out of the box. I came to realize that it was a discrepancy in the version of React being used on the client versus in the NuGet package. NuGet was using the latest, version 16, but the client side code all referenced version 15. All sorts of confusion and chaos ensued.
This is a major change but it boils down to a shift over to ES6 classes instead of the older React.createClass() method. I tested as I went along, so the code should all work. I did not update screenshots. I think any reasonably seasoned .NET developer will skip over those details anyway. I am not a seasoned .NET developer, and I had no issues with that side of things.
I also added a note at the bottom explaining how server-side rendering can suffer from this version drift issue. Hopefully that will save people hours of debugging and frustration.

@dustinsoftware Happy to help! I've just started using React.NET for a project I'm working on, so I'll definitely take a look.

I just noticed after merging this that the .NET Core docs didn't get updated at all... will need to port these changes over.

Yeah it's unfortunate that there's a division between the .NET Core and 'classic' .NET Framework and they can get out of sync. Maybe we can pull out shared stuff into separate .md files and include them in both pages.


Calling print or to_pandas function on dataframe with objects in index causes exception

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): MacOS 10.15.7
Modin version (modin.__version__): <IP_ADDRESS>+25.g544de0d9
Python version: Python 3.8.5
Code we can use to reproduce:

import modin.pandas as pd
class MyObject(object):
     def __init__(self, obj):
         self.obj = obj

df = pd.DataFrame({"a": [1,2]}, index=[MyObject(None),MyObject(None)])
print(df)

or
df = pd.DataFrame({"a": [1,2]}, index=[MyObject(None),MyObject(None)])
df._to_pandas()

Describe the problem

Only tested on Ray backend so far.
The to_pandas function throws an exception if the dataframe has objects in its index. The print function will also throw this exception because it calls the to_pandas function when creating a repr pandas dataframe to print.
modin/pandas/base.py:168
return self.iloc[indexer]._query_compiler.to_pandas()
modin/engines/base/frame/data.py:1889
df = self._frame_mgr_cls.to_pandas(self._partitions)
The to_pandas function retrieves the objects in the partition objects, which result in different memory addresses for the objects in the pandas dataframe compared to the modin dataframe.
modin/engines/base/frame/partition_manager.py:427
retrieved_objects = [[obj.to_pandas() for obj in part] for part in partitions]
After the partitions are converted to a pandas dataframes, the following code checks that the axes i.e. row index and column index of the pandas dataframe and modin dataframe match. However, since the objects in the index have different memory addresses, the axes are not equal.
modin/engines/base/frame/data.py:1897
ErrorMessage.catch_bugs_and_request_email(
    not df.axes[axis].equals(self.axes[axis]),
    f"Internal and external indices on axis {axis} do not match.",
)

Example Comparison
df.axes
[Index([<__main__.MyObject object at 0x37362dc10>, <__main__.MyObject object at 0x373699070>], dtype='object'), Index(['a'], dtype='object')]

vs.
self.axes
[Index([<__main__.MyObject object at 0x1172be310>, <__main__.MyObject object at 0x1172be280>], dtype='object'), Index(['a'], dtype='object')]

Source code / logs

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/richard/Documents/CS262/modin/modin/pandas/base.py", line 2614, in __str__
    return repr(self)
  File "/Users/richard/Documents/CS262/modin/modin/pandas/dataframe.py", line 182, in __repr__
    result = repr(self._build_repr_df(num_rows, num_cols))
  File "/Users/richard/Documents/CS262/modin/modin/pandas/base.py", line 168, in _build_repr_df
    return self.iloc[indexer]._query_compiler.to_pandas()
  File "/Users/richard/Documents/CS262/modin/modin/backends/pandas/query_compiler.py", line 199, in to_pandas
    return self._modin_frame.to_pandas()
  File "/Users/richard/Documents/CS262/modin/modin/engines/base/frame/data.py", line 1897, in to_pandas
    ErrorMessage.catch_bugs_and_request_email(
  File "/Users/richard/Documents/CS262/modin/modin/error_message.py", line 60, in catch_bugs_and_request_email
    raise Exception(
Exception: Internal Error. Please email<EMAIL_ADDRESS>with the traceback and command that caused this error.
Internal and external indices on axis 0 do not match.

Related, setting the index to a column with objects does not work as expected.
Code
import modin.pandas as pd
class MyObject(object):
    def __init__(self, obj):
        self.obj = obj
df = pd.DataFrame({"a": [1,2,], "b":[MyObject(None),MyObject(None)]})
print(df)
df.set_index("b")
print(df)

Output
   a                                          b
0  1  <__main__.MyObject object at 0x3785d23a0>
1  2  <__main__.MyObject object at 0x37afa5160>
   a                                          b
0  1  <__main__.MyObject object at 0x37aef4850>
1  2  <__main__.MyObject object at 0x37aef4f70>

I am able to reproduce this bug on the latest master.


API:List Sample Code

From https://www.mediawiki.org/wiki/User:Martyav/Sandbox/API:Lists
There's currently one sample:

get_max_revisions_w_content_and_backlinks, based on the original request on the current API:List page, demonstrates how to combine a list query with a prop query in the same request

I removed another sample (get_25) because it's too similar to the get category members sample already in the repo. However, the page I am working on contains both samples, because there is value in demonstrating how to do a simple query, and also in demonstrating how to make requests that use both prop and list queries

@martyav Thanks for submitting the pull request! I've left you a comment here. What are your thoughts?

I hear you. I thought the example was a bit complicated myself, and agree that it could be better placed as a sample in a tutorial ("How to compose complex queries"?). I can close the pull request and remove the example section on the page.


Low bank angle in KML replays

Describe the bug
When having imported a Generic KML with track data, the bank angle of the aircraft seems insufficient, as if SkyDolly isn't looking ahead enough in the kml data points to realize if the turn is indeed through a larger heading (necessitating a greater amount of roll to be commanded).
Expected behavior
When aircraft are making large heading changes (be it level flight or not) the bank angle being greater would better enable formation keeping of anyone trying to fly formation with that kml aircraft.
Application version:
only tested on versions up to v0.16.3
Additional context
The idea of downloading kml aircraft tracks and then using them in the sim to fly with has super potential but aside the inevitable jittery movement the bigger issue for me is the insufficient roll angle to match the turns being made. Cheerz

Hello,
Thank you for raising this issue!
Yes, the current bank angle calculation is merely a "placeholder" and currently based on the assumption that the maximum bank angle of an A320 type of aircraft would be 25 degrees.
I definitively want to improve this, also refer to discussion that evolved out of another issue here:
https://github.com/till213/SkyDolly/issues/135#issuecomment-2093559761
In fact, I intend to improve various other aspects of the "flight augmentation" for imported flights:

Equidistant spline curve parameterisation
Configurable "events" (such as gears/flaps/... up/down, perhaps based on selectable "aircraft profiles")
Properly calculated bank angle (based on current estimated velocity and curve radius, given GPS positions with timestamps)
More "straight" (less curvy, due to spline interpolation) flight paths, specificaly for "sparsely sampled paths"
And most importantly: proper alignment (probably with some "interactive wizard dialog") onto the ground


Added contributor.first/lastName

fixes https://github.com/frictionlessdata/specs/issues/852

Rationale
Please take a look at https://github.com/frictionlessdata/specs/issues/852. Personally, I'm not sure about this change but if we think about Data Package as just a language (or definition table) we create for humans/machines to communicate with each other than standardising two additional properties which obviously make sense is a logical move.

Thanks! To exemplify with a use case: we have introduced this properties for biodiversity datasets, to allow generating a citation as Lastname F, Lastname F ... (see https://github.com/gbif/ipt/issues/2087#issuecomment-1883249674). We currently have to work around title being required, but that is resolved in https://github.com/frictionlessdata/datapackage/pull/7 and is no longer required in frictionless v2.
Adopting this PR will as @roll writes "standardis[e] two additional properties", rather than communities inventing them.

If the use case is to generate citations that the data model should be aligned with citation data (or applications will need to reinvent citation generators). The most common citation generator and data model is CSL. It's data model for contributor names is described here and internals as JSON Schema here. So in the best case there is support of name fields:

family - surname minus any particles and suffixes
given - given names, either full (“John Edward”) or initialized (“J. E.”)
suffix - name suffix, e.g. “Jr.” in “John Smith Jr.” and “III” in “Bill Gates III”
non-dropping-particle - name particles that are not dropped when only the surname is shown (“van” in the Dutch surname “van Gogh”) but which may be treated separately from the family name, e.g. for sorting
dropping-particle - name particles that are dropped when only the surname is shown (“van” in “Ludwig van Beethoven”, which becomes “Beethoven”, or “von” in “Alexander von Humboldt”, which becomes “Humboldt”)

As simplicity is preferred and suffix, non-dropping-particle and dropping-particle can be detected automatically to some degree, I'd say it is enough to support given and family by these names. The title field should be kept, it maps to CSL name field literal to be used as exemplified here.

If the use case is to generate citations that the data model should be aligned with citation data (or applications will need to reinvent citation generators).

Well said, @nichtich , I strongly agree.

@khusmann does this address your comment at frictionlessdata/specs#852 (comment)?

@peterdesmet yes, it does! I fully support this now.

Thanks @nichtich! It's been updated -- does it look OK now?

I prefer last name over family name, after all, not everyone has a family name at all. Other cultures have other practises, and where I can I have personally switched to asking for a single "username" in forms. In this case ,this isn't very practical, but I still believe we should avoid using Family over Last.
https://softwareforgood.com/why-you-should-stop-asking-for-first-and-last-names-on-forms/
https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/
Names are really complicated!

I personally don't know what the most inclusive way is to represent names, other than the single name which we already have (but that is problematic for citations).

The EML standard uses givenName, surName
The currently referenced citeproc-js uses given, family
Wikipedia uses surname (canonical for Last name or Family name) and given name
Bibtex uses a single author field, parsing is done on comma
...

I'm fine with an alternative where we don't add 2 new fields, but rather provide formatting rules for the existing name (cf. bibtex)

BTW I would take into account, that datapackage.json is still a machine-focused communication format so I would say that it's not that important how we exactly name properties if it provides desired functionality. So if it's contributor.lastName in JSON it doesn't mean that it must be Last Name in e.g. UI

I'm fine with an alternative where we don't add 2 new fields, but rather provide formatting rules for the existing title

Parsing and formatting names is a form of art but not relevant to this specification. All we need to do is provide a way to store a common subset of name information. Existing standards suggest three fields (given and family=surname if available and applicable, title otherwise) is a good solution.

I've updated back to first/lastName but using more broad BibTeX definition. It now mention both first / given and last / family terms and exact name of the properties are not so important, imho. Also, added a recommendation to follow their guidance for title.

@roll Great! I've made some suggestions to the wording, to align with what's already there.

@pschumm
@ezwelty
@pwalsh
@nichtich
Can you please take a look

I have a few thoughts on this. As others have noted, title is the only universal way of representing a person's name. If a more granular model is needed for generating citations:

I would NOT name the properties firstName, lastName.
I would NOT suggest people muck up title to match some formatting convention.
I would approve either one of:

Add two new properties givenName, familyName
Add a single citationName in Bibtext format
... where in either case, use of title is encouraged to make explicit name order and secondary name parts.

My reasoning below.
Citation conventions require the family name (aka surname), which is not the last name in notable cases (examples below).

Most modern Chinese names begin with a single-symbol family name followed by the given name. As a result of the last name assumption, Chinese authors are sometimes cited by their given name.
In most Spanish-speaking countries, most people have two family names, with the first often taking precedence. So for example Guillermo Cobos Campos should in Bibtex format be cited as "Cobos Campos, Guillermo" or "Cobos, Guillermo", but certainly not "Campos, Guillermo Cobos" (as is frequently found).

At the WGMS, where we work with scientists from all over the world, we store their full name (equivalent to title), and the part of their name (it must be a subset of their full name) that should be treated as the family name when citation formats require a distinction. This allows us to support either order of given and family name, names without family names, etc with just two fields. A similar approach that would more robustly deal with suffixes, non-dropping-particles and dropping-particles would be to have a full name (title: 'John Smith Jr.') and a full citation name in Bibtex format (citation: 'Smith, John Jr.').
Note that even CSL doesn't have an attribute to specify given-family name order (some software tries to infer this using hacks, e.g.  based on the script of the name); the only way to achieve this is with their literal, aka our title.

FWIW, I find @ezwelty's argument(s) above pretty convincing, and now agree that either givenName and familyName or citationName is the way to go. I don't have a strong preference between these.

@ezwelty thanks for clarifying. I think the citation field is the best approach then: it is flexible and clearly communicates that the purpose is for citations. Some questions/suggestions

Definition: citation: Name of the contributor in BibTex author format for use in citations.
Name: Should this property be called citation (quite broad), author (maybe confusing with a role), bibtex, or bibtexAuthor?
Use: I'm guessing that not providing this property doesn't directly mean that the contributor should not be included in a citation?

Examples
[
  {
    "title": "John Smith Jr.",
    "citation": "Smith, Jr, John" <- Suffix in 2nd place
  },
  {
    "title": "Guillermo Cobos Campos",
    "citation": "Cobos Campos, G"
  },
  {
    "title": "Monitoring, understanding and forecasting global biomass flows of aerial migrants (GloBAM)",
    "citation": "{GloBAM project}" <- Wrapped in {}
  }
]

I oppose building on top of BibTeX instead of CSL and I oppose adding another field with already same semantics as title we already have. As summarized above CSL can be stripped to one field for the full name (we already have title, so this should be fixed) and two fields for parts of the name.

If I'm the blocker I'll capitulate.
I propose we reopen this discussion when we come across a user story that doesn't fit in the CSL derived definitions.

@peterdesmet @PietrH
Thanks a lot for making it work! I've updated the PR
@ezwelty @pschumm
Please take a look if it's ok now

ACCEPTED by WG (6/9)

@roll Looks good. My only additional suggestion would be to mention, when linking to the CSL docs, to follow their guidance on where to put suffixes and particles, since we don't include dedicated fields for those.


Clear Signature having no ending tails tags -----END PGP SIGNED MESSAGE-----

Hello Team,
We are using BC APIs for clear signature use case, and we found the document is signed but the ending tail tags are missing:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
When you send an encrypted email with ProtonMail, your message is automatically protected with PGP encryption. What is PGP? This article explains the tech behind our security promise.
### NO ENDING TAGS ####
-----BEGIN PGP SIGNATURE-----
Version: BCPG v1.64
iHcEAREIAB8FAmCY/HEYHFNlcnZlcjFTaWduS2V5IHNpZ24ga2V5AAoJENE0ewDQ
ghkcHsgBAKMTtOkKTtxEcOCu4h10RUcKrTiYvkp4Bjfl71QuOwQsAP9nHUpVinht
V/6mHFKuz3nVMfBmKX1V0txXij5PrdGQxg==
=F/Rp
-----END PGP SIGNATURE-----
Is it an expected behavior or it's a bug that the stream is not flushing the chunks of data?
Although when I verify the same document its working fine. Need help

@dghgit can you please help

There's no ending tag - see RFC 4880, Section 7. https://datatracker.ietf.org/doc/html/rfc4880#section-7 There has never been one (a bit odd I know, but that's the way they did it...)


Your on-premises environment is federated with Azure AD.

The "Pre-Requisites" state that you need to be Federated for Azure MFA to work with ADFS.
But if you Follow all the Step in an Non-Federated(Managed) environment this also works.
Is the Documentation wrong or are there situations that this is Not-supported or functionality would not work?
If this is unsupported it might be an reason for us to move to federated from an managed state.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f333e8cb-c046-ee06-d33d-d7dc8e8af695
Version Independent ID: 10838695-f60e-42a7-b0e8-eed7820fd333
Content: Configure AD FS 2016 and Azure MFA
Content Source: WindowsServerDocs/identity/ad-fs/operations/configure-ad-fs-and-azure-mfa.md
Product: windows-server
Technology: ad-fs
GitHub Login: @billmath
Microsoft Alias: billmath

Asked Premier support to follow up on this feedback and the answer is that it is supported in both states (Managed and federated).
Could the documentation be updated?
TicketId:<PHONE_NUMBER>03189

#assign:IngridAtMicrosoft

Thank you for submitting this issue.  Unfortunately, due to high volumes I was unable to respond to this in a timely manner.  At this point, I am going to close this due to it's age and the possibility that it may have been addressed.  If this is still a problem, please consider submitting a new issue.  Thank you.
#please-close


feat[cartesian]: add extra_link_args for flexible support of various compiler build

add one more environment GT4PY_EXTRA_LINK_ARGS for flexible support of various compiler build (this contribution is not copyrightable as it's a trivial change)
<type>:
    - build: Changes that affect the build system or external dependencies
    - ci: Changes to our CI configuration files and scripts
    - style: Changes that do not affect the meaning of the code
    - test: Adding missing tests or correcting existing tests

<scope>: cartesian
# ONLY if changes are limited to a specific subsytem

PR Description:
add one more environment GT4PY_EXTRA_LINK_ARGS for flexible support of various compiler build

Requirements

[ ] All fixes and/or new features come with corresponding tests.
[ ] Important design decisions have been documented in the approriate ADR inside the docs/development/ADRs/ folder.

If this PR contains code authored by new contributors please make sure:

[ ] All the authors are covered by a valid contributor assignment agreement provided to ETH Zurich and signed by the employer if needed.
[ ] The PR contains an updated version of the AUTHORS.md file adding the names of all the new contributors.

Thank you for the contribution!

Could you please fix formatting, by using pre-commit. See https://github.com/GridTools/gt4py/blob/main/CONTRIBUTING.md.
Please also confirm (by a comment in this PR) that this contribution is not copyrightable as it's a trivial change. We don't need you to sign the CAA in that case.

thanks, I had thought there is workflow test before PR, but I didn't find it. yeah, I will follow these workflows for my new PR

the code pattern check here is interesting, we usually only check the code style, here is the output,
-extra_link_args: List[str] = (

list(GT4PY_EXTRA_LINK_ARGS.split(" ")) if GT4PY_EXTRA_LINK_ARGS else []
-)
+extra_link_args: List[str] = list(GT4PY_EXTRA_LINK_ARGS.split(" ")) if GT4PY_EXTRA_LINK_ARGS else []

however it is fine for extra_compile_args.

Can you write a short note here regarding this:

Please also confirm (by a comment in this PR) that this contribution is not copyrightable as it's a trivial change. We don't need you to sign the CAA in that case.

Can you write a short note here regarding this:

Please also confirm (by a comment in this PR) that this contribution is not copyrightable as it's a trivial change. We don't need you to sign the CAA in that case.

yes, I did


Feature request: Set exit node

https://headscale.net/exit-node/#on-the-node

Any features are dependent on the headscale API supporting it.

Based on a look through the newest doco, it looks like the exit node feature is just an extension of routes, which is already an existing feature. There is no way for the server to create routes that aren't advertised by the exit node so there's nothing for the UI to do.


Issue with Handling Range (4XX) in Response Status Codes

Description
When attempting to use ranges like 1XX, 2XX, etc., in the response status codes, the contract fails to load with the following error message: Could not load /Users/path_to_contract/Contract.yaml: For input string: "4XX"
Steps to reproduce
Contract file

openapi: 3.0.1
info:
title: Sample API
version: 1.0.0
paths:
/sample-endpoint:
get:
summary: Get Sample Data
description: Retrieve sample data from the API.
responses:
'4XX':
description: Client Error
content:
application/json:
schema:
type: object
properties:
message:
type: string
example:
message: An error occurred on the client side.

Expected behavior
specmatic stub or specmatic test works fine with such open API(3.0.1) specification
Additional context
stacktrace shows java.lang.NumberFormatException: For input string: "4XX".
OpenApiSpecification.kt

status = if (status == "default") 1000 else status.toInt()

The code is assuming that the response status code will be either "default" or an integer value and breaks when range ("4XX") is passed.

@premnaththirumalaisamy Thanks for reporting the issue.
I agree that Specmatic should not be throwing NumberFormatException  in this case. We will look into it.
However from an API design point of view having a generic 4xx may not convey the API behaviour with sufficient clarity to the API consumers. We generally recommend going with specific error codes because that way you can qualify each response better. If the intent here is to reduce duplication of error response schema, that could be solved by extracting it to component/schemas section and referenced. Please let me know if I am missing something.
Also, as you may have seen in some of our examples, Specmatic can correlate the examples across request and responses to generate tests. Having a non-specific error code such as 4xx means it is not possible to map various input possibilities with the specific error outcomes such as 422, 404, etc.

Thank you for your response. I completely understand and agree to your point about using specific error codes for better clarity in API behavior. However, in this particular situation, I'm working with an existing codebase where making modifications to the API design is not feasible due to various constraints.
Also any specific reason as to why .yml file extension is not supported ? All the contracts in the current codebase are defined with type yml.

@premnaththirumalaisamy Thanks for sharing your context. Just a suggestion, changing the response codes to more specific version may not entail API design change. Please do correct me if I am wrong.
However, we will take a look how we can handle the non-specific error codes such as '4xx' better.
About .yml file, no specific reason. This is a good catch and quite an easy fix too. Can you please log a separate issue for this?

https://github.com/znsio/specmatic/issues/697

Thanks @premnaththirumalaisamy

Hi @premnaththirumalaisamy, we've updated Specmatic to show a more meaningful error when a non numerical (such as 2xx, 4xx, etc) is seen in the specification. Hope this helps.
Please feel free to reopen this if you have any followup questions.


feat: add tests for the EVM target

What ❔

Uses test_case to run tests for both targets.
Prohibits usage of the upstream solc.
Removes file extension checks for disassembler. Now only hexadecimal strings are supported.

Checklist

[x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[x] Tests for the changes have been added / updated.
[x] Documentation comments have been added / updated.
[x] Code has been formatted via cargo fmt and checked with cargo clippy.

@antonbaliasnikov for some reason code coverage is not reported. What could be the issue?

@antonbaliasnikov for some reason code coverage is not reported. What could be the issue?

Hey, it looks like some discrepancies between .profraw files generated by Rust and llvm-cov tool. I'll take a look.


[ROS2 Foxy] Unable to build from master

Hello,
I've got an OS1 running firmware 2.4 that's connected to an Nvidia Jetson Xavier NX. I'm attempting to build from source cloned off of the master branch, but every time I build, I resulted in the following error:
Starting >>> ouster_msgs
Finished <<< ouster_msgs [2.34s]
Starting >>> ros2_ouster
--- stderr: ros2_ouster
CMake Error at /usr/lib/aarch64-linux-gnu/cmake/pcl/PCLConfig.cmake:62 (message):
  common is required but boost was not found
Call Stack (most recent call first):
  /usr/lib/aarch64-linux-gnu/cmake/pcl/PCLConfig.cmake:367 (pcl_report_not_found)
  /usr/lib/aarch64-linux-gnu/cmake/pcl/PCLConfig.cmake:551 (find_external_library)
  CMakeLists.txt:23 (find_package)

Failed   <<< ros2_ouster [5.93s, exited with code 1]

Summary: 1 package finished [8.93s]
  1 package failed: ros2_ouster
  1 package had stderr output: ros2_ouster

I followed the same procedures on another computer, and the build was successful, which leads me to believe that I do have a dependency error. After confirming with rosdep install --from-paths src within the ros2_ouster directory, I still result in the same error. After searching the issues within this repository, I referenced #111 thinking I'm missing the PointCloud Library (PCL), but it seems the issue goes deeper. I wonder if there's an issue with the architecture of the Jetson - which uses ARM64 as opposed to x86_64.
Would I be able to receive guidance on if there's something I can do the CMakeLists.txt file to support ARM64?

It may be possible some of your dependencies are not binaries on ARM or arent working with the right versions

Steve,
I'm grateful for your lightning-fast response. I've figured that could also be the case. NVIDIA Jetsons have a tendency to have proprietary versions of the same libraries that come baked into their images, so I'm intending on trying to remake a new image for my Jetson and try recompiling from source.
For reference, is there a list of dependencies I can look at to make sure I've got all my ducks in a row?

The package.xml file would be it! You can cross reference any non-ros-named keys in the ros/rosdistro repo for your particular distribution for urls to source (if nonobvious)

Sweet! I'll let you know of any updates. Hopefully, it'll be one that allows me to close this ticket. 👍

Hi there,
So I flashed the Jetson once again and pulled from master once again. Now, it looks like it can detect boost within the common for PCLConfig; however, upon a new build attempt, I result with a new error, shown below:
Starting >>> ouster_msgs
Finished <<< ouster_msgs [2.53s]
Starting >>> ros2_ouster
[Processing: ros2_ouster]
--- stderr: ros2_ouster
In file included from /home/jackal/ros2_ouster_drivers/ros2_ouster/src/sensor_tins.cpp:19:
/home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/sensor_tins.hpp:18:10: fatal error: tins/packet.h: No such file or directory
   18 | #include <tins/packet.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/ouster_driver_core.dir/build.make:115: CMakeFiles/ouster_driver_core.dir/src/sensor_tins.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /home/jackal/ros2_ouster_drivers/ros2_ouster/src/driver_types.cpp:20:
/home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/sensor_tins.hpp:18:10: fatal error: tins/packet.h: No such file or directory
   18 | #include <tins/packet.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/ouster_driver_core.dir/build.make:63: CMakeFiles/ouster_driver_core.dir/src/driver_types.cpp.o] Error 1
In file included from /home/jackal/ros2_ouster_drivers/ros2_ouster/src/ouster_driver.cpp:28:
/home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/sensor_tins.hpp:18:10: fatal error: tins/packet.h: No such file or directory
   18 | #include <tins/packet.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/ouster_driver_core.dir/build.make:76: CMakeFiles/ouster_driver_core.dir/src/ouster_driver.cpp.o] Error 1
In file included from /home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/processors/image_processor.hpp:26,
                 from /home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/processors/processor_factories.hpp:23,
                 from /home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/sensor.hpp:21,
                 from /home/jackal/ros2_ouster_drivers/ros2_ouster/src/sensor.cpp:20:
/home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/conversions.hpp:194:26: error: ‘PointCloud2’ in namespace ‘sensor_msgs::msg’ does not name a type
  194 | inline sensor_msgs::msg::PointCloud2 toMsg(
      |                          ^~~~~~~~~~~
In file included from /home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/processors/processor_factories.hpp:25,
                 from /home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/sensor.hpp:21,
                 from /home/jackal/ros2_ouster_drivers/ros2_ouster/src/sensor.cpp:20:
/home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/processors/pointcloud_processor.hpp: In member function ‘virtual bool sensor::PointcloudProcessor::process(const uint8_t*, uint64_t)’:
/home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/processors/pointcloud_processor.hpp:117:28: error: no matching function for call to ‘toMsg(pcl::PointCloud<ouster_ros::Point>&, std::chrono::nanoseconds, std::string&, const uint64_t&)’
  117 |         _frame, override_ts));
      |                            ^
In file included from /home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/processors/image_processor.hpp:26,
                 from /home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/processors/processor_factories.hpp:23,
                 from /home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/sensor.hpp:21,
                 from /home/jackal/ros2_ouster_drivers/ros2_ouster/src/sensor.cpp:20:
/home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/conversions.hpp:84:35: note: candidate: ‘ouster_msgs::msg::Metadata ros2_ouster::toMsg(const ros2_ouster::Metadata&)’
   84 | inline ouster_msgs::msg::Metadata toMsg(const ros2_ouster::Metadata & mdata)
      |                                   ^~~~~
/home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/conversions.hpp:84:35: note:   candidate expects 1 argument, 4 provided
/home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/conversions.hpp:104:45: note: candidate: ‘geometry_msgs::msg::TransformStamped ros2_ouster::toMsg(const Eigen::Matrix<double, 4, 4, 2>&, const string&, const string&, const rclcpp::Time&)’
  104 | inline geometry_msgs::msg::TransformStamped toMsg(
      |                                             ^~~~~
/home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/conversions.hpp:105:57: note:   no known conversion for argument 1 from ‘pcl::PointCloud<ouster_ros::Point>’ to ‘const Eigen::Matrix<double, 4, 4, 2>&’
  105 |   const Eigen::Matrix<double, 4, 4, Eigen::DontAlign> & mat, const std::string & frame,
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
/home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/conversions.hpp:135:30: note: candidate: ‘sensor_msgs::msg::Imu ros2_ouster::toMsg(const uint8_t*, const string&, const ouster::sensor::packet_format&, uint64_t)’
  135 | inline sensor_msgs::msg::Imu toMsg(
      |                              ^~~~~
/home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/conversions.hpp:136:19: note:   no known conversion for argument 1 from ‘pcl::PointCloud<ouster_ros::Point>’ to ‘const uint8_t*’ {aka ‘const unsigned char*’}
  136 |   const uint8_t * buf,
      |   ~~~~~~~~~~~~~~~~^~~
/home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/conversions.hpp:210:36: note: candidate: ‘sensor_msgs::msg::LaserScan ros2_ouster::toMsg(ouster::LidarScan, std::chrono::nanoseconds, const string&, const ouster::sensor::sensor_info&, uint8_t, uint64_t)’
  210 | inline sensor_msgs::msg::LaserScan toMsg(
      |                                    ^~~~~
/home/jackal/ros2_ouster_drivers/ros2_ouster/include/ros2_ouster/conversions.hpp:210:36: note:   candidate expects 6 arguments, 4 provided
make[2]: *** [CMakeFiles/ouster_driver_core.dir/build.make:102: CMakeFiles/ouster_driver_core.dir/src/sensor.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:115: CMakeFiles/ouster_driver_core.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
---
Failed   <<< ros2_ouster [48.5s, exited with code 2]

Summary: 1 package finished [51.9s]
  1 package failed: ros2_ouster
  1 package had stderr output: ros2_ouster

At first, I thought maybe my Pointcloud Library isn't installed, but when running `find / -iname libpcl, they appear in the expected directories:
/usr/share/doc/libpcl-io1.10
/usr/share/doc/libpcl-conversions-dev
/usr/share/doc/libpcl-visualization1.10
/usr/share/doc/libpcl-tracking1.10
/usr/share/doc/libpcl-segmentation1.10
/usr/share/doc/libpcl-stereo1.10
/usr/share/doc/libpcl-msgs-dev
/usr/share/doc/libpcl-dev
/usr/share/doc/libpcl-sample-consensus1.10
/usr/share/doc/libpcl-octree1.10
/usr/share/doc/libpcl-ml1.10
/usr/share/doc/libpcl-features1.10
/usr/share/doc/libpcl-recognition1.10
/usr/share/doc/libpcl-apps1.10
/usr/share/doc/libpcl-registration1.10
/usr/share/doc/libpcl-outofcore1.10
/usr/share/doc/libpcl-filters1.10
/usr/share/doc/libpcl-surface1.10
/usr/share/doc/libpcl-kdtree1.10
/usr/share/doc/libpcl-people1.10
/usr/share/doc/libpcl-search1.10
/usr/share/doc/libpcl-common1.10
/usr/share/doc/libpcl-keypoints1.10
/usr/lib/aarch64-linux-gnu/libpcl_apps.so
/usr/lib/aarch64-linux-gnu/libpcl_keypoints.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_io_ply.so
/usr/lib/aarch64-linux-gnu/libpcl_visualization.so
/usr/lib/aarch64-linux-gnu/libpcl_keypoints.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_sample_consensus.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_visualization.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_outofcore.so
/usr/lib/aarch64-linux-gnu/libpcl_tracking.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_stereo.so
/usr/lib/aarch64-linux-gnu/libpcl_recognition.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_common.so
/usr/lib/aarch64-linux-gnu/libpcl_people.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_surface.so
/usr/lib/aarch64-linux-gnu/libpcl_ml.so
/usr/lib/aarch64-linux-gnu/libpcl_common.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_filters.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_features.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_search.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_features.so
/usr/lib/aarch64-linux-gnu/libpcl_ml.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_ml.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_registration.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_apps.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_outofcore.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_stereo.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_octree.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_surface.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_recognition.so
/usr/lib/aarch64-linux-gnu/libpcl_sample_consensus.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_people.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_filters.so
/usr/lib/aarch64-linux-gnu/libpcl_kdtree.so
/usr/lib/aarch64-linux-gnu/libpcl_io_ply.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_segmentation.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_visualization.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_segmentation.so
/usr/lib/aarch64-linux-gnu/libpcl_tracking.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_octree.so
/usr/lib/aarch64-linux-gnu/libpcl_outofcore.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_io.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_registration.so
/usr/lib/aarch64-linux-gnu/libpcl_kdtree.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_io_ply.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_filters.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_stereo.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_search.so
/usr/lib/aarch64-linux-gnu/libpcl_io.so
/usr/lib/aarch64-linux-gnu/libpcl_io.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_kdtree.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_keypoints.so
/usr/lib/aarch64-linux-gnu/libpcl_segmentation.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_people.so
/usr/lib/aarch64-linux-gnu/libpcl_recognition.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_surface.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_apps.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_octree.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_sample_consensus.so
/usr/lib/aarch64-linux-gnu/libpcl_features.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_registration.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_common.so.1.10.0
/usr/lib/aarch64-linux-gnu/libpcl_search.so.1.10
/usr/lib/aarch64-linux-gnu/libpcl_tracking.so

Any help on this would be greatly appreciated - my brain has been wracked all night on this now with the PCLConfig error no longer being present.

It's fixed!
Apparently, rosdep install doesn't seem to pick up ros--pcl-ros and ros-version--conversions as requisite dependencies to build the ros2_ouster package, resulting in this error. Installing them respectively resolved the problem, and I now have a completely built package.
I'll be closing this issue now. Thanks!

Briefly opening this because I found a surefire way of resolving the error shown about PCLConfig.
When rebuilding after a config change, I ran into the error again. I went through the PCLConfig.cmake file because now, at this point, the error falls entirely on PCLConfig being unable to find boost.
In the cmake file, there's a set() for finding boost with the environment variable NO_BOOST_CMAKE. Here's the snippet:
# Disable the config mode of find_package(Boost)
  set(Boost_NO_BOOST_CMAKE ON)
  find_package(Boost 1.55.0 ${QUIET_} COMPONENTS system filesystem date_time iostreams)

My solution was to just outright remove that set(), and disable the ${QUIET_} within find_package. Suddenly, it worked. Here's the code I replaced:
  # Disable the config mode of find_package(Boost)
  find_package(Boost 1.55.0 COMPONENTS system filesystem date_time iostreams)

Addmittedly, not sure why this works, but as they say in software engineering: if it works, don't question it. In case someone else has this problem with their Jetson, they should try this and hopefully it'll work.


gradle missing

Steps to reproduce
fork, clone and Import project in android studio
Expected behaviour
android studio can build it
Actual behaviour
Gradle seems to be missing.
message is: Migrate Project to Gradle?
This project does not use the Gradle build system. We recommend that you migrate to using the Gradle build system.
Would you like to work on the issue?
How do i fix it?

Please share a screenshot of what actual error message are you getting?
Also, googling it will help. Because, everyone else seems to be able to build the project successfully on Android studio.

I have fixed it now, however it seems that the project dosent build with Gradle 4.6. I downgraded to 4.5 and the then it worked


Traceable Consistent 'Docker' messages for automated testing, QE, debugging

Currently there seems to be at least two ways to handle error messages:
fmt.Errorf (std golang error handler)
utils.Errorf (part of docker/utils/utils.go )
(are there more?)
There are two issues I'd like to discuss:

Consistent use and policy over which gets used where - currently it seems as if utils.Errorf is used in conjunction with utils.Debugf, i.e. used for debugging code rather than production system use. (?) fmt.Errorf gets used for logging errors in normal non-debug (production) env.

When lots of infrastructure and applications are logging to stdout/stderr the ability to identify where a message is originating from quickly, e.g. docker, is important. Especially in automated QE and CI/CD environments.  So is there a simple way we can prefix Docker msgs with "Docker" or "docker" and then "Error" etc. ?
 Docker-Error:

I can see this might become more important as Docker gets used more and more in CI/CD envs.
That's the best way I can word these issues. Perhaps others have strong more articulate  arguments.
William

I think this is really up to whatever is capturing the logs to tag the log messages to something that makes sense for that installation.
On ubuntu upstart is picking up the logs, on systemd journald is (and tags by service).
utils.Error is not around anymore and all logging is being done by logrus.
I think we can close this?


feat(CircleProgressBar): added xs | s sizes

PR includes

[x] Feature

Related issues
Resolve #1137
Related issues https://github.com/taskany-inc/issues/issues/2778
QA Instructions, Screenshots, Recordings

/canary

/canary


 There's stuff we can google on how to fix this but it's definitely important.

It seems that this just isn't a real problem. You can copy out just the EXE and it seems to run fine. We'll need to make sure users install .NET framework 4.6.1.


Allow us to call setUserInfo without completely wiping all previously set properties set by addUserProperties

Feature description
My use case is that I have independent sources for where some of my attributes come, and where my ID comes from. Whenever each one of those change, I used to call Datadog.getInstance().addUserProperties().
Now I wanted to start using setUserInfo to set my ID, only to realize that this then simply clears (here) the previously set attributes.
Proposed solution
I would need one of the two options:

Provide a way to grab the existing attributes, so that I can grab them, and then call setUserProperties(id, ..., grabbedAttributes) to set the ID and re-set the attributes too
Provide a way for me to set the user info without clearing the extra properties as a hidden side-effect

Other relevant information
No response

Hi @StylianosGakis ,
thanks a lot for opening a feature request, we included that in our internal tracker and we will try and address this in our roadmap.


Weird boxes in some ItemList dialogs

Godot version
Godot v4.2.rc1 - Pop!_OS 22.04 LTS - X11 - Vulkan (Forward+) - integrated Intel(R) Graphics (ADL GT2) () - 12th Gen Intel(R) Core(TM) i5-1235U (12 Threads)
System information
Godot v4.2.rc1 - Pop!_OS 22.04 LTS - X11 - Vulkan (Forward+) - integrated Intel(R) Graphics (ADL GT2) () - 12th Gen Intel(R) Core(TM) i5-1235U (12 Threads)
Issue description
I get random boxes in the UI of multiple dialogs.

Steps to reproduce
Go to these dialogs - connections dialog and quick open dialog
Minimal reproduction project
N/A

There's no change in behavior from them, for clarity, it's just a visual glitch.

I believe, that this is tracked in #74115

Cool, this is an issue I started getting very recently for these dialogs.

Not the same, that issue is for the compatibility renderer, seems to have spread to the Vulkan renderer as well

WAIT no, it's on the Compatibility renderer. I'll fix this.

Duplicate of https://github.com/godotengine/godot/issues/74115


Create data directory hierarchy if not present

Hello, and thank you for sharing and maintaining such a valuable project.  I'm just getting started by way of legis-graph and intend to become a frequent user and hopefully a helpful contributor.
I've setup a fresh installation and Python 2.7 virtual environment.  As a heads up for potential future congress users, I ran into an SSL handshake issue sourced to scrapelib which prevents execution of the fdsys task (and likely others).  That issue and workaround is detailed here.
Currently, I'm attempting to ./run bills --congress=115 and the task fails because there is no data hierarchy in the filesystem yet.  mkdir -p data/115 and a subsequent os.listdir call will fail because there are no bill types.  This is easy enough to workaround with some knowledge of the expected hierarchy, but it seems like something we could also easily fix.
I see there's a mkdir_p function in utils.py we could reuse - is there a good central place in the codebase to anticipate this edge case?  I'd be happy to put together a pull request with a little guidance.
Thanks again for this very useful project!

Hmm, after messing around a bit more I'm starting to feel like I'm missing an important step between ./run fdsys --collections=BILLSTATUS and ./run bills.  It looks to me like the bills task is expecting a bootstrapped dataset to already exist in the data hierarchy, but I don't see any mention of how to achieve that in the README or the wiki.

Re-opening, didn't mean to close the issue.

@gregoryfoster I filed a quick PR to fix the issue you identified: https://github.com/unitedstates/congress/pull/202
However, the bills task is defunct and unused. It was designed for thomas.gov, which is now :skull: in favor of congress.gov. The fdsys task is active, and would be easier for @JoshData to speak to, as he has it up in production.

Thanks, @konklone, for the quick fix.  It does take care of creating the data hierarchy through a specified Congress.
I'm a little puzzled and honestly a little distressed to hear that the bills task is regarded as defunct, as that shines a different light on GovTrack's announcement that they'll no longer support bulk data access after the 2017 summer recess.  Is this project winding down?

No no no, I re-wrote the bills task last year to convert the new official bill XML (from fdsys) into the existing JSON data format. Since GovTrack relies on the JSON format and I don't have the capacity to re-write GovTrack's importer to use the fdsys XML directly, I'm still invested in keeping the bills task running.

The mkdir issue probably stemmed from my rewrite last year, btw. Sorry about breaking it on clean directories (which I never test on).

Whew, glad to hear, @JoshData!
Returning to the original edge case of an absent and now clean data hierarchy - should I open a separate issue to tackle a clean load scenario?  Meaning: while PR #202 avoids the os.listdir errors, the bills task as written doesn't take any action on a clean directory as it's compiling the list of bill types and bill IDs from an empty data hierarchy.  That seems like a more substantial chunk of work that would require traversing the fdsys sitemap metadata files (or is there an easier route?).
Let me know if you want me to open a separate issue.  And if you can sketch an outline of what needs to be done, I'd be happy to contribute a PR.

Apologies for confusing the issue! And I can verify what @gregoryfoster says -- #202 fixes the errors, but it still doesn't cause the bills task to do anything, it just stops with some messages about fetching 0 bills. I couldn't figure out why that was, and mistook the lack of network requests to mean it'd been retired.

Hello,
I came to this issue report after attempting to run a clean installation of this scrapper and got the error: "No such file or directory: 'data'"
This issue and #202 seems to be related to my error even though it is over 2 years old and still Open.  #202 says "This fixes #201 by using mkdir_p as necessary when examining data paths on disk.", but without any specific directions on how or where that fix should be applied.
After reading the last 2 comments here, I have to ask if this scrapper is still being maintained? If so, where can I find directions on how to fix this issue? Thanks.

Hi.
At GovTrack we use this project extensively.
Unfortunately we don't have the resources to fix problems that we're not experiencing ourselves, though. This repository was created at a time when multiple well-funded organizations (besides us) we're investing in creating a shared data ecosystem for legislative data, but now some of those organizations effectively don't exist anymore.

Thanks for you quick response.
I started a project several years ago with GovTrack (GT) bulk data. When I came back to it last year the GT data was no longer online. I found parts of it on ProPublica and elsewhere but some parts I can’t find, like the set of Amendments.
I will spend some time over the next few days trying to figure this scraper out. If it can produce what I’m looking for I will post the fix. I might even try to fork it to Python3 since Python2 is due to be obsolete next year.

@jox58 Can I ask specifically which scraper you're running that it doesn't create a data directory?

You are right. My mistake for not reading the instructions carefully. I did a ./run bills without first ./run govinfo --bulkdata=BILLSTATUS


GUACAMOLE-204: Implement CAS Single Sign On Support

This pull request implements support for the Apereo CAS Single Sign On system.

Fixed a couple of issues with the initial pull request, including re-enabling Apache RAT in the pom.xml file, and removing unnecessary files from the base of the extension.

Is there any documentation you can point to for CAS which could help put this PR into context?

Here's the base documentation for CAS:
https://apereo.github.io/cas/4.2.x/index.html
If you're looking for specifics on the protocol, here is the protocol documentation:
https://apereo.github.io/cas/4.2.x/protocol/CAS-Protocol.html
And here's the github link for the java-specific implementation of the CAS client.  It has lots of information on parameters and what gets passed back and forth between client and server.
https://github.com/apereo/java-cas-client

Thanks for the info, Nick! This helps a lot. I'll take a look in a bit.

Hey @necouchman - I'm picking this review back up finally, so stand by for further feedback. I plan to take a look over #122 again, soon, to help troubleshoot the issues you mentioned with the bouncycastle lib, but please kick me if I don't make good on that. I've been losing track of both of these.
In other news, I believe your Apache ID / account, etc. has gone through successfully, so please reset author on your commits to<EMAIL_ADDRESS>when you get a chance.

Sounds good, Mike - thanks.  I haven't had much time lately to work on it, but if you any feedback or changes I'll try to respond and make those.
And, yes, I got all my Apache account stuff squared away, so should be good to go there - thanks!
-Nick
On Thursday, March 16, 2017 9:57 PM, Mike Jumper<EMAIL_ADDRESS>wrote:

Hey @necouchman - I'm picking this review back up finally, so stand by for further feedback. I plan to take a look over #122 again, soon, to help troubleshoot the issues you mentioned with the bouncycastle lib, but please kick me if I don't make good on that. I've been losing track of both of these.In other news, I believe your Apache ID / account, etc. has gone through successfully, so please reset author on your commits to<EMAIL_ADDRESS>when you get a chance.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Okay, pinging on this one - any further issues/comments on this?

Thanks for the ping - taking a look now.

OK - done with first round of reviewing.
As a side note: now would be a good time to reset the author of your existing commits here such that they all use your Apache email address. You can edit your GitHub info such that it's associated with your GitHub account along with all the other emails you use, but your commits against Guacamole should use the Apache one.

Thanks, Mike.  I've corrected most of the stuff, and have changed my commit e-mail address for this repo.

Any further issues with these changes?

I've corrected most of the stuff, and have changed my commit e-mail address for this repo.

You'll still need to reset the author of the past commits, though, as changing the email address for the repository only affects commits going forward.

Any further issues with these changes?

I'll take another look now, but off the top of my head:
I don't see the licenses, etc. for known dependencies common with other extensions (like Guice), their transitive dependencies, and the CAS library dependency and its transitive dependencies. Those will need to be added just as with the other extensions before we can bring this into the main codebase.

I don't see the licenses, etc. for known dependencies common with other extensions (like Guice), their ?
transitive dependencies, and the CAS library dependency and its transitive dependencies. Those will need to be added just as with the other extensions before we can bring this into the main codebase.

I've gone through the dependencies and added the licenses.  I did want to ask how far down the chain I need to chase dependencies and add licenses - for example, cas depends on log4j, which depends on several base Java libraries (see in the Compile Dependencies on this page: https://mvnrepository.com/artifact/log4j/log4j/1.2.15 ) - do I need to run those down, as well?  That's fine if I do, just want to verify before I go to the trouble.
Also, to this point I've been chasing down these dependencies just by going through the Maven POM files for each of them and looking at the dependencies.  Is there a better way to do this?  Or is it just a manual process?

Also, to this point I've been chasing down these dependencies just by going through the Maven POM files for each of them and looking at the dependencies. Is there a better way to do this?

Thankfully, yes. You can use the dependency:list goal:
 mvn dependency:list -DincludeScope=runtime

That will produce a list of all runtime dependencies, including transitive dependencies, which are what end up exploded inside the extension.
Beware that you can't necessarily trust the license information in a dependency's pom, nor can you look to the project's current source or website (projects sometimes change licenses). Once the dependencies are known, the tricky part is tracking down the source of each (at the specific point in time of the version being used) and determining the license used.

I've gone through the dependencies and added the licenses. I did want to ask how far down the chain I need to chase dependencies and add licenses - for example, cas depends on log4j, which depends on several base Java libraries (see in the Compile Dependencies on this page: https://mvnrepository.com/artifact/log4j/log4j/1.2.15 ) - do I need to run those down, as well?

Yep. Anything which is ultimately bundled with the extension (and thus will be distributed in the .tar.gz included with each release) needs to be tracked down. The exception to this would be things which we will not bundle ourselves (like the WIP RADIUS extension, as we recently figured out), but the preference is definitely to be able to bundle.

OK - I've reread through these changes, and tentatively I think they're fine. I think we're good to move forward once we find a way to clean up that JavaScript:
https://github.com/necouchman/incubator-guacamole-client/blob/3ebe96a8688338d8c7fbf2cdf89ef34d0f107702/extensions/guacamole-auth-cas/src/main/resources/casIndexTicket.js#L28-L40
I'll try installing CAS and this extension myself, and tinker with the above. Perhaps a solution will present itself, or perhaps the main webapp can be modified to clean up its own URLs after the redirect.

I ran the Maven dependency list plugin myself to check the dependencies, licenses, etc. The following are the only dependencies that would end up bundled:
[INFO]    com.google.inject.extensions:guice-multibindings:jar:3.0:compile
[INFO]    javax.inject:javax.inject:jar:1:compile
[INFO]    com.google.inject:guice:jar:3.0:compile
[INFO]    org.jasig.cas.client:cas-client-core:jar:3.4.1:compile
[INFO]    aopalliance:aopalliance:jar:1.0:compile
[INFO]    org.slf4j:slf4j-api:jar:1.7.7:compile

Of the above, SLF4J is actually already included in the Guacamole webapp. We should exclude it from inclusion in the extension (declare it as provided in the pom.xml), to avoid conflicts and to make life easier.
I'll comment on the above specifically in another review.

Okay, cleaned up licensing stuff, updated years, and updated versions.  Let me know if you come up with something for the JavaScript issue or have a direction you want me to run.  Also let me know if I should rebase the entire extesion on the 0.9.12-incubating code base.

I think I finally have a clean solution to the Angular parameter issues. I've written a script which reformats the URL when the page is loaded if query parameters are present in a location where Angular will not see them:
mike-jumper/incubator-guacamole-client@be2a40657448a93033f319e7ba9389551454bd5e
Let me know if the above solves the problem for you, and I'll open a pull request for that improvement.

Also let me know if I should rebase the entire extesion on the 0.9.12-incubating code base.

Yes, definitely. Things won't build properly otherwise.

Really sorry for the delay in getting back to this - my day job has been really busy these days and haven't had much of a chance to work on this.
With the change, above, the CAS authentication extension works fine and redirects correctly, so I think you can go ahead and do a pull request for that.
Now I have to dig into the corner of my brain where the rebase knowledge went and rebase this extension on the current version...I think master is up to 0.9.13, now??

Okay, extension has been rebased to current master, and I've removed the extension-specific URL parameter rewriting in anticipation of your commit going through.  Once you do push that through I'll rebase it once more with that commit, and this issue should be taken care of.

Really sorry for the delay in getting back to this - my day job has been really busy these days and haven't had much of a chance to work on this.

No worries.

With the change, above, the CAS authentication extension works fine and redirects correctly, so I think you can go ahead and do a pull request for that.

Excellent - will do.

Now I have to dig into the corner of my brain where the rebase knowledge went and rebase this extension on the current version...I think master is up to 0.9.13, now??

The version number on master is still 0.9.12-incubating, though we should probably finalize scope and bump versions soon.

This has been rebased to the master with the recent commit for URL parameters.  Any other concerns for this PR?  Anything else that needs work before it gets committed?

Looks good to me! Brace for merge...

the redirect_url is in the guacamole config file, but it is not convenient, the best way is that always auto redirect to the url which user access before, i hope you can improve that.

the redirect_url is in the guacamole config file, but it is not convenient, the best way is that always auto redirect to the url which user access before, i hope you can improve that.

Yes, I know that it is sub-optimal - I need to do some testing to see if there's any way to accomplish this without explicitly specifying the redirect URL.  When I get a chance, I'll try some things out.  I don't know when that will be.

If the redirect URL is not explicitly specified by the administrator, and is instead detected client-side or through inspecting the HTTP request, would that not open us up to redirect-based attacks, potentially allowing malicious sites to steal the CAS token?
https://www.owasp.org/index.php/Unvalidated_Redirects_and_Forwards_Cheat_Sheet

If the redirect URL is not explicitly specified by the administrator, and is instead detected client-side or through inspecting the HTTP request, would that not open us up to redirect-based attacks, potentially allowing malicious sites to steal the CAS token?

Yeah, definitely need to carefully consider that and avoid introducing security holes...
Looking at that page, however, it looks like most of the examples of "dangerous" redirects are ones based on things like GET parameters and the like - things that could be easily spoofed by altering the URL or accepting user input.  It seems like if we calculate the URL of the Guacamole application, from within the Java code (inside the servlet), it should avoid most, if not all, of the pitfalls listed on that page, correct?
Security issues aside, I've run into problems actually coming up with the correct URL for the web application, particularly when Tomcat is behind a reverse proxy, like Apache or Nginx, so I need to make sure I can get that to work reliably in all cases.

It seems like if we calculate the URL of the Guacamole application, from within the Java code (inside the servlet), it should avoid most, if not all, of the pitfalls listed on that page, correct?

Yes - if the default value for the redirect URI is calculated purely from server-side values (not the HTTP request, nor generated client-side), I think this should be safe.
As you say, though, it's likely impossible to determine the correct value for deployments of guac behind reverse proxies.

Hello how i can get Guacamole working with CAS for SAML authentication?

@saydulk Three things:

This is not a support forum.  If you have questions or need help, please use the mailing list: http://guacamole.apache.org/support/
If you're using CAS, why not use CAS natively instead of SAML?  There's already a CAS authentication module: http://guacamole.apache.org/doc/gug/cas-auth.html
This PR is still a work-in-progress - it has not been completed/approved/merged, so SAML support is not present, yet, in Guacamole.


UUID instead of Email and Helm instead of Upper case letter.

Updated it to have a cleaner looking UUID but have it copy the UUID without dashes.


feat: push lam image to the embedded cluster registry

pushes the lam image to the embedde cluster registry.

@ajp-io Here is a recording of the change on the user feedback during installation. You might want to skip to 5 minutes. In case you didn't notice it: there is a new step called "Pushing embedded cluster images". Let me know what you think.

Ideally this would be part of "Pushing embedded cluster artifacts." We've already gotten feedback that there is too much low-level detail in the output for basic non-Kubernetes end-users (what's Velero, what's Embedded Cluster, etc.), so I'd like to minimize how many additional lines we put in there. And since images are artifacts, it would be great to fit this into that message and just have the counter increment once more for this image.

Ideally this would be part of "Pushing embedded cluster artifacts." We've already gotten feedback that there is too much low-level detail in the output for basic non-Kubernetes end-users (what's Velero, what's Embedded Cluster, etc.), so I'd like to minimize how many additional lines we put in there. And since images are artifacts, it would be great to fit this into that message and just have the counter increment once more for this image.

Hmmm, I think on this case we want to change the Kots output to include the image as part of the artifacts. Let me see how we can get it done there then.

After https://github.com/replicatedhq/kots/pull/4703 this became obsolete. Closing.


Are the test sets for USPTO-MIT and USPTO-FULL datasets same as in the baselines?

Hi!
Awesome work and really good results!
I noticed you use a different preprocessing procedure than some of the compared works for USPTO-MIT and USPTO-FULL datasets. For example, USPTO-MIT in the LocalRetro paper has 479 035 reactions, while in your work, it has 482 132 reactions. Similarly, USPTO-FULL in the GLN paper has 1 013 118 reactions, while in your work, it has 960 198 reactions.
My question is, does this preprocessing also affect the test set on which you evaluate your method? Namely: is the evaluation set exactly the same as in the compared methods? If not, the results might be a bit skewed.

Nice question. The preprocessing is a little different compared to the works you mentioned.
Just like the Augmented Transformer did, we add a extra procedure to remove invalid reactions that contain
no products or just a single ion as reactants, and it also affect the test set. You can find this preprocessing procedure in our paper and code both. The proportion of this kind of reactions is about 4% in USPTO-FULL.
The accuracies can be recalculated for the test set by assuming that our model failed for all 4% of excluded reactions, which may lead to about 2% decrease of top-1 accuracy.
And its sorry that it's not clear to me why LocalRetro has more data than ours.

Thank you for your response! I work on retrosynthesis models and noticed, by reading different papers and code, that there are many different data preprocessing, and even accuracy comparison methods, used in different publications. This makes me suspicious of the exact Top K scores that are reported. I think this issue is something that is worth working on for the community.


Fix for issue 1174

This avoids the problems mentioned in #1174 by removing our target on the Interactive Pop Gesture at viewDidDisappear-time
It avoid regressing to the problems documented in #257 by capturing the UIGestureRecognizer (as weak) at the time we addTarget. This allow us to remember on whom we should removeTarget.
I will have a separate commit to add a 2-level navigation-controller push to the Demo project (PR #1176), but that is not directly related to #1174 nor #257

Awesome. Thanks @walsh2000 !

@jessesquires
I was sure I saw a message from you asking that the property accesses go through accessors, but I don't see that comment anywhere anymore, but I made the changes.
Note, that I was following what appeared to be the pattern for "_jsq_isObserving" (see jsq_removeObservers)

Also, if I caused this Travis failure, I am not sure how. :smiling_imp:

@walsh2000 - no worries. looks like an issue with xctool. I just changed the script to use xcodebuild. if you sync with develop it should be ok

@jessesquires
Out of curiosity, what is the timetable for 7.1.2?

@walsh2000 - lol -- ASAP! I wanted to do it last weekend, but didn't have a chance. Hopefully this week. :smile:

Hey @walsh2000 - there was one regression here. see 875eab6.
The pop gesture must be removed in viewWillDisappear:. Otherwise, the following will happen:

Drag to back
Stop ~half-way to allow VC to snap back (i.e., you stay on the message view, you don't pop the VC)
The keyboard will remain up and the toolbar will hide behind it

Please let me know if 875eab6 causes problems. :smile:

Oh well, after testing with #1176 there's no crash, so... :tada: I guess we're good?

@jessesquires
Regarding 875eab6 & the regression.
I've stepped through the regression.
The app gets a series of keyboard frame changes (hiding then reappearing).
In the didHide we set toolbarBottomLayoutGuide to 0.
The subsequent keyboardDidChangeFrame has the right rectangle to place the inputToolbar in the right spot. However, we do not process the message before the inputToolbar is not first responder
    if (![self.inputToolbar.contentView.textView isFirstResponder] && self.toolbarBottomLayoutGuide.constant == 0.0f) {
        return;
    }

If we make the inputToolbar's text view the first responder on Cancelled/Ended, then the toolbar does not get lost behind the keyboard.

875eab6 effectively reverts #1175, so I found a solution for both #1174 & which does not introduce the inputToolbar regression. PR #1189


dateformat does't work on latest firefox.

for example. I am currently in EDT.
the utc timestamp =<PHONE_NUMBER>000
d = new Date(utc) gives me
Date 2014-03-09T09:00:00.000Z
d.format('T') gives EST which is wrong.
d.format('T') should give EDT.

@MHL3060 does the issue still persist in the latest Firefox version, also, what version have u tried it in?

Sorry. I haven't tried. We don't support Firefox anymore.

I have tried it in Firefox 54.0.1, seems to work fine after the ceb72c6 commit.


Examples should reflect newer Microsoft.Azure.Cosmos.Table namespace

The examples should reference this newer space rather than the older WindowsAzure table library, especially since everything else references it. Microsoft.Azure.Cosmos.Table has full support for Storage Account Tables now as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6d35c032-eae7-ac4b-2ad3-32fd0cd2318f
Version Independent ID: 92b0a972-eabe-8048-36b1-a1cefb3acf43
Content: Azure Table storage bindings for Azure Functions
Content Source: articles/azure-functions/functions-bindings-storage-table.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@JustinGrote Thanks for the question! We will review and get back to you!

@JustinGrote Looks like the storage extension itself uses WindowsAzure.Storage.
There is a work item that tracks updating to the new libraries - Azure/azure-webjobs-sdk#2177
The docs would be updating once the new libraries are being used.

@JustinGrote Just following up here... Hope my previous comment clears things up.

It does thank you.
On Tue, Jul 16, 2019, 6:30 AM Pramod Valavala<EMAIL_ADDRESS>wrote:

@JustinGrote https://github.com/JustinGrote Just following up here...
Hope my previous comment clears things up.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/35063?email_source=notifications&email_token=ADUNKUXVDL5L2O2FVGRHKQLP7XENRA5CNFSM4ICTTA3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2A3EGI#issuecomment-511816217,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADUNKUXRFETL7RUAN52F44DP7XENRANCNFSM4ICTTA3A
.

@JustinGrote Glad we could help! The docs should get updated along with the migration to the newer libraries.
Since there is no doc update required at the moment, we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


RP2040, i2c : wrong clock frequency

Describe the bug
SCL clock frequency generated do not correspond to DT clock-frequency definition:
&i2c1 {
	status = "okay";
	pinctrl-0 = < &i2c1_default >;
	pinctrl-names = "default";
	clock-frequency = <I2C_BITRATE_STANDARD>;
...

I2C_BITRATE_STANDARD is suppose to be 100kHz, but i measured 124kHz :

Which make a huge difference.
I investigate first using i2c logs and i found that hcnt and lcnt are wrong:
[00:00:00.005,000] <dbg> i2c_dw: i2c_dw_isr: I2C: interrupt received
[00:00:00.005,000] <dbg> i2c_dw: i2c_dw_setup: I2C: host configured as Master Device
[00:00:00.005,000] <dbg> i2c_dw: i2c_dw_setup: I2C: speed set to STANDARD
[00:00:00.005,000] <dbg> i2c_dw: i2c_dw_setup: I2C: lcnt = 500
[00:00:00.005,000] <dbg> i2c_dw: i2c_dw_setup: I2C: hcnt = 400
[00:00:00.005,000] <dbg> i2c_dw: i2c_dw_isr: I2C: interrupt received

Here is how lcnt and hcnt are defined :
#define I2C_STD_HCNT            (CONFIG_I2C_DW_CLOCK_SPEED * 4)
#define I2C_STD_LCNT            (CONFIG_I2C_DW_CLOCK_SPEED * 5)

Which is by default :
config I2C_DW_CLOCK_SPEED
    default 100

The clock-frequency defined in device tree is not used by the driver.
Target: RP2040
To Reproduce
Can be reproduce with any program that use RP2040 as i2c controller and measure i2c frequency.
Expected behavior
clock-frequency property is used to compute SCL frequency.
Impact
Wrong scl signal frequency.
Environment (please complete the following information):

OS: Ubuntu 22
Toolchain Zephyr SDK
Commit sha : 07c6af3b8c35c1e49186578ca61a25c76e2fb308

Additional context
Link of the conversation with @yonsch in discord for infos.

@andrei-edward-popa this should be fixed in/after #52901

@yonsch can you please take a look again here. It seems the PR mentioned above is stale? Is there any other way this can be fixed?

@yonsch can you please take a look again here. It seems the PR mentioned above is stale? Is there any other way this can be fixed?

@nashif Fixed here: #58814


OpenRSD + PiVPN = Amazing Web Interface :D

OpenRSD is now out of beta. Can a dev check it out?
https://github.com/mitchellurgero/openrsd
Has a LOT of features for Raspbian based OS's.(Including a web interface for PiVPN scripts / commands)

ok... There is a lot I like here.
High level thoughts, post your responses:

what is your goal here?  Would you like to see me offer this as part of the pivpn installer?  IE ask the user if they would like to add a GUI to their pi?

If I did that I'd probably want to turn on the managment interface of the openvpn server so you could interact with those commands as well: https://openvpn.net/index.php/open-source/documentation/miscellaneous/79-management-interface.html
Not all of them but things like 'hold' 'version' 'kill (connected clients)' 'status' etc i could see being useful, etc.

Would like PiVPN to be its own heading, like Dashboard, Basic Config, Advanced Config, PiVPN Management, Power Options etc.
the PiVPN Management would only show if you detect PiVPN is installed, this way those using the UI without PiVPN don't see unnecessary headings.

thoughts? Feedback?

I like the idea, however OpenRSD is a separate project, and I wanted to just state that it has a couple basic functions for PiVPN (I will take those out if you want, thought it was a cool feature).
If we did team up and worked on both projects together (Or I can make a completely new interface for PiVPN, completely separate from OpenRSD), then I could move PiVPN to its own Navbar item.
email me if you'd like<EMAIL_ADDRESS>(It forwards to my personal, not putting that here though :) )

No I wasn't implying to take them out.  Keep them in and add more, up to you.
I didn't want to work on it, just use as is.  Just maybe keep a fork of it here that has PiVPN on its own navbar item and adds as much as it can to the pivpn.  It'd still be separate as it can be the last thing this installer asks the user, whether or not they want to install a gui that shows them cpu/mem etc of their pi and also has some pivpn commands built in.  Would be nice.

I agree, Well I can move PiVPN to it's own navbar item, then if you want to add it as an install-able option :) otherwise, you can link in the README if wanted. :D

Personally, I prefer projects that have a focused, refined use case. Here, PiVPN is a great little script that gets your Raspberry Pi up and running as an OpenVPN server. Easy.
Adding a web GUI/interface to that interaction is a value add, but I would prefer it separate from the project/script that sets up the server.

So you'd prefer a separate curl command vs at the end of the pivpn install it just asks if you want to install a gui, y/n?

Well install is simple and can be scripted, just a git clone of the openrsd repo + changing the user and group of the apache server to run as pi.
It should be a separate script too, so I agree with @arikalfus on that aspect, Like discussed before, maybe just putting it in the readme would be enough. Or I can fork OpenRSD and rebuild it specifically for PiVPN in a new project.
So, @0-kaladin, let me know and I can do that.

@0-kaladin Personally I would prefer a separate command. However, the aim of your project is to provide a benefit in an easy, one-off way to potentially non-technical users. I believe that's your goal, correct? There's an argument to be made that, in that case, make it as simple as possible and bundle it into the script. Another curl command is another confusing step to someone that doesn't understand all of this.
But keeping them separate lets you work on them as two distinct projects, which you could argue they are. The script and the GUI. And you could share a command at pivpn.io that just concats the second curl | bash sequence for the GUI, so to a non-technical user it's still just one "command" they're running.

Well someone let me know I can fork OpenRSD and strip it down to just PiVPN GUI.

But I would prefer to leave it as is because of all the features it offers.

Let me clearly lay out what I'd want to do to avoid confusion.
You leave your project as-is.  Develop it with features/fixes as you see fit (quite obviously).
I fork it over here in the pivpn organization.  As you add features or changes either I merge them in where wanted, or add you as a member to this org so you can do yourself.
As a separate repo here in pivpn org a few things can happen.

you can selectively choose if a feature goes into openrsd the separate project or the one that gets installed with pivpn.
I can make the changes I'd like, which off the top of my head, for the pivpn install I'd use nginx, change the url to be like pivpn-ui, offer htaccess auth if the user wants, etc.  basically because i'd script the install i'd change the things on the system (not really the src) to support pivpn stuff more.
as a separate fork its easy to install with a separate curl from the pivpn installer.

but I def don't want you to fork to strip down to just pivpn, those other features will be handy for pivpn users as well, to see their cpu mem etc.

With the authentication mech I wrote it really only supports the PAM-auth I did (With custom binary to authenticate against the /etc/passwd file in Raspbian) But you are more than welcome to fork and do what you like :) If you want to fork, here are the files that are ABSOLUTELY required for the PiVPN feature to work in the web interface:
/dlnd_profile.php
/index.php (Edit funciton body() to your needs.)
/logout.php
/page.php (Remove everything except openvpn stuff. This does the dynamic loading of page(s))
/app/auth_log
/app/blocked_ip
/app/bin/chkpasswd
/app/auth.php
/app/funcitons-orsd.js
/app/functions.php
/app/logs.php (Used as a general sudo cat <filename> function (Reads the profile files for PiVPN)
/app/profile-revoke.php
/app/profile.php
/bower_components
/css
/dist
/img
/js
/less
/pages/openvpn.php (Displays all the stats, profiles, etc to the user)

If I missed something, I'll add later, otherwise I can just fork to pivpn-gui make the modifications to make it PiVPN only, then give you ownership?

So how do we install the gui >?
But nothing.
How to install

Please visit pivpn.io for more information.

cd /var/www/html
git clone https://github.com/mitchellurgero/pivpn-gui

Hi Mitchell
I installing the pivpn gui  but show the following error:
remote: Repository not found.
fatal: repository 'https://github.com/mitchellurgero/pivpn-gui/' not found

Please go read the repo. It explains why it's not found...

@0-kaladin Personally I would prefer a separate command. However, the aim of your project is to provide a benefit in an easy, one-off way to potentially non-technical users. I believe that's your goal, correct? There's an argument to be made that, in that case, make it as simple as possible and bun1dle it into the script. Another curl command is another confusing step to someone that doesn't understand all of this.
But keeping them separate lets you work on them as two distinct projects, which you could argue they are. The script and the GUI. And you could share a command at pivpn.io that just concats the second curl | bash sequence for the GUI, so to a non-technical user it's still just one "command" they're running.

As a "non-technical" newbie to Raspberry Pi who enjoyed setting up an OpenVPN personal server recently, I would very much welcome this idea. I wish the installer could include an option for installing a web UI/dashboard to monitor and manage the connections to and traffic through my server. Thanks for your great work!


Adjusting text for intro, adding roadmap & planning files

I've made a fair number of revisions to the text/organization of some of the intro files. Part of the thinking here is that we need to cater to several audiences and not everyone is going to want all the technical details. For instance, many readers are just going to want to get to the examples/recipes and use this as a bit of a cookbook for how to implement media on their site. Whereas others are hopefully going to want to get more involved in contributing. I will add more revisions in the coming days/weeks and hopefully help to get an initial version of the guide done.

Thank you! This looks awesome. I left few minor comments.

Thanks for the review/comments. I just corrected each of the issues.

Do you want me to squash the commits, or keep them separate for review purposes?

Yup, squash and rebase against master would be great. There is one (minor) thing left.