Opening directory with spaces and trailing slash opens invalid file

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
If you attempt to open a directory using a path with spaces in it, and include the trailing \, Atom opens to the parent directory with an empty "file" of the directory name with a " on the end.
Steps to Reproduce

Have a directory with a directory that has spaces in the name as one of it's parent folders.

For example: C:\foo bar\foo

From the CLI (cmd.exe or PowerShell) attempt to open the folder with a trailing slash in the command.

For example: atom 'C:\Temp\foo bar\foo\'

Note that Atom has opened the parent folder, with the desired folder name open as a "file" with an " on the end.

For example: Atom open to C:\foo bar with an empty "file" of foo" open.

Expected behavior:
Atom opens the desired folder, regardless of whether there was a trailing \ on the path.
Actual behavior:
Atom opens the parent folder, with an empty file named after the desired folder with a " on the end open.

The window on the left is the behavior of the first command, the window on the right is the second command (and the expected behavior).
Reproduces how often:
100% of the time.
Versions
Tested on Windows 10 x64 on:
Atom    : 1.17.0-beta5
Electron: 1.3.15
Chrome  : 52.0.2743.82
Node    : 6.5.0

Also tested on:
Atom    : 1.18.0-dev-fb9fd2fbf
Electron: 1.3.15
Chrome  : 52.0.2743.82
Node    : 6.5.0

(A build based on https://github.com/atom/atom/pull/14372/commits/fb9fd2fbfcf2f6fa07f43efcde20d4ee109df6a4)
Additional Information
I tested the following variations...
Working:

Anything that doesn't have the \, or doesn't have a space in any parent folder

Failing under both PowerShell and old fashioned cmd.exe:

PS C:\Temp> atom '.\foo bar\foo\'
PS C:\Temp> atom 'C:\Temp\foo bar\foo\'
PS C:\Temp> atom "C:\Temp\foo bar\foo\"

I tried reproducing this on macOS and couldn't. It may be specific to Windows. @ungb can you reproduce this?

Whoops, one bit of information I forgot to include:
If the shell is in the directory with the space in the name (or a directory under it), opening the folder doesn't reproduce this. The only reproduces when the folder with a space in it's name is in the path sent to Atom.
For example, this has no issues:
C:\Temp\foo bar> atom '.\foo\'

@Arcanemagus my Windows VM failed me in this particular case (had trouble launching Atom from PowerShell and cmd), can you still reproduce this one?

I find that removing the quotes on the whole path and providing just the directory with the spaces inside escaped double quotes like so works fine on windows 10:
atom C:\Temp\/"Foo Bar/"\foo


The contributing link on the repository readme is broken.

That link is broken.

I've fixed it. Sorry for the inconvenience.


Document Implementation Limitations

We should be explicit about the limitations of our implementation.  In particular, the use of Javascript Number type basically means we're limited to ~53-bits of integer.  There are probably other limitations worth noting around things like Decimal as well.

See release notes.  Closing.


Provide alternative to mixin

Mixins don't work with React components written as ES6 classes.
Let's provide something that will work like a superclass, higher order component, or ES7 decorator.

Did you ever solve this issue?
I am still too new to solve this myself, but I am going to try none the less using https://github.com/timbur/react-mixin-decorator
What are your thoughts?

@motebotic That seems like a reasonable solution. Is that something you can use easily in your own project without requiring changes in react-rethinkdb? If you have to go through any hoops to get it working, it'd be great if you could write it up here so we can have it documented for other users.
I haven't yet decided how to provide an official alternative to mixin. One of the big downsides to me with react-mixin-decorator's approach is that it creates a higher-order component. While that works fine in most cases, it violates the principle of least surprise, because the decorated component actually becomes the HOC in practice. So if you decorate a component like UserList, and then render that somewhere as <UserList ref="mylist" />, then this.refs.mylist will return the HOC instead of the UserList instance.
I don't know the full ramifications of this, but I'm hoping best practices will emerge (or maybe they already have?)

I've successfully used the mixins as decorators by using the babel-plugin-transform-decorators-legacy plugin.
The helper:
import { BaseMixin } from 'react-rethinkdb';

const Rethinkable = sessionGetter => component => {
  const proto = BaseMixin.call(component.prototype, sessionGetter);
  const unmount = proto.componentWillUnmount;

  proto.componentDidMount = function () {
    this._isMounted = true;
  };

  proto.componentWillUnmount = function () {
    this._isMounted = false;
    unmount.call(this);
  };

  for (let key in proto) {
    const _proto = component.prototype[key];
    component.prototype[key] = function () {
      proto[key].call(this);
      if (_proto) {
        _proto.call(this);
      }
    }
  }
};

export default Rethinkable;

Usage:
import React, { Component } from 'react';
import { r, QueryRequest } from 'react-rethinkdb';
import Rethinkable from '../helpers/rethinkable';

const session = component => component.props[name];

@Rethinkable(session)
class App extends Component {

  observe (props, state) {
    return {
      turtles: new QueryRequest({
        query: r.table('turtles'),
        changes: true
      })
    };
  }

  render () {
    return (

        {this.data.turtles.value().map(turtle => (

{turtle.name}

        ))}

    );
  }
}

Only thing needed modification in the codebase is https://github.com/mikemintz/react-rethinkdb/blob/master/src/util.js#L21 and needs to support checking for component._isMounted gracefully like this:
export const updateComponent = component => {
  // Check for document because of this bug:
  // https://github.com/facebook/react/issues/3620
  if ((component._isMounted || component.isMounted()) && typeof document !== 'undefined') {
    component.forceUpdate();
  }
};

It doesn't brake the old method and should't be too much overhead.
https://facebook.github.io/react/blog/2015/12/16/ismounted-antipattern.html

That seems pretty cool! Maybe since it seems like isMounted() might get deprecated anyway, we should first patch the mixin so it sets _isMounted in componentDidMount and componentWillUnmount, and then modify updateComponent to use only _isMounted kind of like you suggest.
Then with that in place, we can add your decorator as a mixin-alternative.

@mikemintz Any plans or news regarding implementing something like this anytime soon?

@birkir does the decorator functionality work for you now that https://github.com/mikemintz/react-rethinkdb/pull/31 is merged? Maybe we could add your decorator code as well if you're ok with that, so that other people can use the decorator easily.

@birkir this seems like a nice solution.  I can't quite get it to work; I get an error:
Uncaught Error: Mixin in  does not have Session
from this line:
proto[key].call(this, ...args);
Also, notice that my component.props[name] is null.
Can you perhaps push a full working example to a branch of your fork?  Thanks : )

I duplicated the "tutorial" example in my fork, and applied your code it as I understand it:
https://github.com/harlantwood/react-rethinkdb/commit/6ee091475e0865eaaaeaf9c00bf7a21da718c87c
I get the same error in the browser console: Uncaught Error: Mixin in does not have Session.
Am I doing something wrong?  Or does the react-rethink codebase need further modifications?

BTW, I tried up updating all dependencies (including react) to their latest versions; behavior was unchanged.

can someone give me working example for ES6 of this module ???
as my project is completely built in react ES6 and i am unable to use this with..
if any one has any working example of react-rethinkdb pls, provide me


Need a Hue Phillips plugin

Hello
I have just started to try to write a new plugin for Phillips's hue blub.
https://github.com/gilbsfr24/qlcplus/tree/gilbsfr24-Hue-Patch/plugins/hue
But I have negative values in the function HUEController::sendDmx  in the QByteArray &dmxData
I want to understand why?
I Had built (only) the plugin with the right version of QT. I see the plug on interfaces tab.
Now I am starting to  try with a rebuild of all the project, I will see
Have you allready meet this kind of problem?

So, you've opened an issue in the QLC+ project for a plugin that's not even upstream.
Have you read the GitHub template message where it says to start a forum thread instead of writing here ?
You could have had your answer which is: DMX data is unsigned, while QByteArray data is signed. So you need to cast to uchar.
I've had a quick look at your branch. Apart for wrong files you committed, I will not accept non-Apache 2.0 sources, so you need to find a way to exclude the libhue sources.

Sorry I will close this issue, and the next time I will write in the forum.
Thank you for the explantation of unsigned char. I can now go further with my branch.
The libHue is not needed but it was in my directory (and my project too) when I comited my source, I have to correct and re-commit.
Next step for this branch, is to add "discovery bridge", and the 2 channels mode.
Rds


Icons size demo display broken

Seems like something has been broken on the icon page.
The display for the sizes icons is incorrect.
It's seems like we now need to add the Font Awesome size helpers too.
It's what is done on Bulma docs now
Code taken from Font Awesome website:
 fa-lg
 fa-2x
 fa-3x
 fa-4x
 fa-5x

I don't know why it's was working before. Perhaps something to do with preact switch but would be a strange behaviour as it have nothing to do with the CSS...

Perhaps this can be an opportunity to implement wrapper for Font Awesome helpers class like fa-spin, fa-2x. Or at least a record to get intellisense and not use strings :)
If someone want to give it a try I can give some guidance.

Hi Maxime
I'd like to help on this issue!
Édouard

@EdouardM
I would do something like that:
In the FontAwesome.fs file
// FontAwesome.fs

// Create a Classes modules like we do for Fulma.Extensions which map the Font Awesome classes values.
module Classes =
    // Example for the Sizes
    module Sizes =
        let [<Literal>] FaLarge = "fa-lg"
        let [<Literal>] Fa3x = "fa-2x"
        let [<Literal>] Fa2x = "fa-3x"

// Create the Types module which serve as an internal DSL
module Types =

    type ISize =
      | FaLarge
      | Fa2x
      | Fa3x

    let ofSize =
        function
        | FaLarge -> Classes.Sizes.FaLarge
        | Fa2x -> Classes.Sizes.Fa2x
        | Fa3x -> Classes.Sizes.Fa3x

    type Options =
       { Icon : string option
         Size : string option }

       static member Empty =
         { Icon = None
           Size = None }

    type Option =
      | Icon of IFontAwesomeIcon
      | Size of ISize

let inline faIcon (options: Fulma.Elements.Icon.Types.Option list) (faOptions : Option list) =
    let parseOptions (result : Options) option =
        match option with
        | Size size -> { result with Size = ofSize size |> Some }
        | Icon faIcon -> { result with Icon = unbox<string> faIcon |> Some } // For F# compiler to consider the faIcon as a string

    let opts = options |> List.fold parseOptions Options.Empty

    icon options
        [ i [ classBaseList "fa" [ opts.Icon.Value, opts.Icon.IsSome
                              opts.Size.Value, opts.Size.IsSome ] ] [ ] ]

// Usage sample would be
Icon.faIcon [ Icon.isLarge ]
    [ Fa.Icon Fa.Slideshare
      Fa.faLarge ]

The code I gave you has not been tested it's "pseudo-code" to give you the general direction. But I think the *Usage sample" is the target we are aiming for this feature.
@evilz  Do you agree with my usage proposition ?

The code I gave above should works except if the user want to stack the icons.

We will need a custom helper like Icon.faStack to let the users write is custom children here.

I also had the same issue in my app. I think Bulma requires fa-lg, etc. because it now supports other icons beyond Font Awesome.  Apparently before, when only FA was supported, was not needed but I couldn't make it work by reverting the Bulma version to 0.5.2 or 0.5.1.

I couldn't make it work by reverting the Bulma version to 0.5.2 or 0.5.1.

I tried too and failed too. That's really strange.
And yes it's probably due to the support of the new icon sets

Hello Maxime,
I've implemented the Fa Size Option by following your guidance.
It is working but I noticed that the options Icon.isSmall, Icon.isMedium, Icon.isLarge are completely ignored. I think they should be replaced by Fa Size
I'll continue to work on this tonight.
Bye,
Edouard

What do you mean by ignored ? They are needed to set the size of the icon container (the span element)

You are right on the Icon size they should not be replaced.
I continued to work on the issue now I have size and rotation of icons OK. I am on the stacked icon part.
I'll keep you posted when this is done.


OpenJDK CRaC support

Is your feature request related to a problem?
AWS announced support of snapstart in AWS Lambda based on Java runtime.
It looks like this support based on OpenJDK CRaC, with ability to specify before/after context restore hooks, reference:
https://aws.amazon.com/blogs/compute/reducing-java-cold-starts-on-aws-lambda-functions-with-snapstart/
https://docs.aws.amazon.com/lambda/latest/dg/snapstart.html#snapstart-compatibility
However if java agent attached before snapshot created, I think it will lead to incorrect results (as least sending APM data with same instance metadata).
Describe the solution you'd like
Ideally, we would like to bytebuddy instrumentation happen before snapshot is took.
In afterRestore method, java agent should be able re update only necessary instance specific information
Describe alternatives you've considered
Attaching agent in afterRestore hook, however it returns back initialisation latency
Additional context
Implementing and providing CRaC restore hook may be useful not only for AWS Lambda application, but for any java application using CRaC project.

I completed some testing with enabled SnapStart and want to provide some information, which should help with implementation.
Setup:

use official configuration instructions and add two layers to enable java agent.
enable snapstart and publish java version

I see, after invoking function, trace data in Elasticsearch.
However, service.node.name field was not reported and in Kibana instance was shown as "<unknown>".
There is a difference in environment variables when function started from SnapStart, AWS_LAMBDA_LOG_STREAM_NAME is not populated, and ServiceFactory does not fill node name in method augmentServiceForAWSLambda.
I've opened an issue on AWS java lib, let see if its expected:
https://github.com/aws/aws-lambda-java-libs/issues/402
Note:
If AWS_LAMBDA_LOG_STREAM_NAME won't be available for SnapStart functions, we can provide a fallback implementation based on ephemeralId, e.g.:
private static String generateNodeName(String ephemeralId) {
    DateTimeFormatter dtf = DateTimeFormatter.ofPattern("yyyy/MM/dd");
    LocalDate localDate = LocalDate.now();

    String version = "[" + PrivilegedActionUtils.getEnv("AWS_LAMBDA_FUNCTION_VERSION") + "]";

    return dtf.format(localDate) + "/" + version + ephemeralId.replaceAll("-", "");
  }

Moving forward with implementation, I think we need to register a crac listener to refresh tracer MetaData and ephemeralId.
One thing to mention, that CRaC resource listener is not called, if listener loaded from ShadedClassLoader, and it looks like this listener should be in system classloader.
Since we support several options of attaching java agent, I do not know exact place to put the listener.
Additionally, may be it makes sense to not attempt to register the listener if CRaS is not in a classpath.
For investigation purposes, assuming we are in AgentMain class, next implementation works:
public class AgentMain {

  private static final ApmResource resource = new ApmResource();

  static {
    Core.getGlobalContext().register(resource);
  }

  .....

  private static void awaitMetaData() {
    try {
      Class.forName("co.elastic.apm.agent.bci.ElasticApmAgent", true, agentClassLoader())
          .getMethod("awaitMetaData")
          .invoke(null);
    } catch (Exception ex) {
      ...
    }
  }

  private static void reloadAgent() {
    try {
      Class.forName("co.elastic.apm.agent.bci.ElasticApmAgent", true, agentClassLoader())
          .getMethod("updateMetaData")
          .invoke(null);
    } catch (Exception ex) {
      ...
    }
  }

  static class ApmResource implements Resource {

    @Override
    public void beforeCheckpoint(Context<? extends Resource> context) throws Exception {
      SystemStandardOutputLogger.stdOutInfo("Before checkpoint hook started");

      AgentMain.awaitMetaData();

      SystemStandardOutputLogger.stdOutInfo("Before checkpoint hook finished");
    }

    @Override
    public void afterRestore(Context<? extends Resource> context) throws Exception {
      SystemStandardOutputLogger.stdOutInfo("After snapshot hook started");

      AgentMain.reloadAgent();

      SystemStandardOutputLogger.stdOutInfo("After snapshot hook finished");
    }
  }

}

beforeCheckpoint
Whenever SnapSpart snapshot is created, lambda instance initialized, but without request invocation.
Which leads to metadata future (when snapshot is taken) never complete, due to the fact that AbstractLambdaTransactionHelper.completeMetaData is never called.
Even if this metadata is not needed after restore, I think it make sense to complete it or cancel before snapshot is taken.
afterRestore
During snapshot restore, we need to generate new ephemeralId and recreate MetadataFuture, and propagate changes down to DslJsonSerializer.
DslJsonSerializer attempts to cache serialized version of metadata, so either serializer may be recreated or internal serializer cache needs to be invalidated.
Artyom.

@ArtyomGabeev Thanks a lot for this wonderful input! I am sure it will be very useful once we get to it.
We do intend to consider this as a priority for our next development cycle, although we cannot provide any estimation as to if and when.

@eyalkoren , I've opened a PR with initial snapshot implementation.
However, I've got a reply from AWS that neither AWS_LAMBDA_LOG_STREAM_NAME or context.getLogStreamName won't be populated for SnapStart enabled functions - https://github.com/aws/aws-lambda-java-libs/issues/402 .
I do not know, if Kibana product have some special handling of AWS lambda APM data and if it relies on the format of configured_name from service.node field.
In initial proposal, I suggest to simulate and generate similar node name, but right now I think we do not need to tie if possible instance name to log group name at all.
If we need just to distinguish lambda instance, mb pair of lambda version + ephemeral id is enough, but this is a breaking change, if we going to change it for all AWS Lambdas.
Another option I'm considering is to introduce a property, which will be a strategy for lambda instance naming.
By default we should, we should still try to use AWS_LAMBDA_LOG_STREAM_NAME env variable, but we may allow another one, which will use auto generated name.
Appreciate any feedback,
Thanks!

@ArtyomGabeev thanks for the elaborated explanation, you can extend https://github.com/elastic/apm-agent-java/pull/3036#discussion_r1118115144 to include all this info as well.
Unfortunately, we cannot allocate time for this right now, even if it is only about reviewing and making such decisions. However, since we are interested in that, we will review and try to prioritize it for our next dev cycle. The fact that you proposed an implementation and all this useful feedback definitely increases the chances for it to get in, even though we cannot guarantee that.

I've updated PR for 1.38.0 base and can do rebase if needed.
I have couple of questions:

Looks like RequestStreamHandlerInstrumentation and RequestHandlerInstrumentation does not work when lambda handler extends any other class with overloading, where handleRequest is overriden in parent, e.g:

GenericHandler (has handleRequest with signature matching the byte buddy spec)
MyHandler extends GenericHandler (has handleRequest overloaded).
Is there a way to make byte buddy work with methods defined in parent classes as well?
Usecase: StreamHandler where der/ser logic are implemented in abstract class.

That's one interesting, AWS Lambda snapstart does not invoke handler method during snapshot. Event if I try to warmup all classes, there is one instrumentation which does not - RequestHandlerInstrumentation/RequestStreamHandlerInstrumentation.

It adds additional latency on startup, current workaround I'm using is registering crac listener and invoking lambda handler with simulated AWS context.
I do not think there is an easy solution for this problem, mb I can just document how warm-up before coordinated snapshot lambda handler.
Thanks,
Artyom

Has there been any progress into integrating support for CraC lately?

hoping to get back to this next week, happy to have another review of the PR if anyone wants to add their input


Update boost setup

Description

Updated the Setup.sh script to define the boost version in one place and use it appropriately in all other places
Upgraded the boost version to 1.68.0 as 1.67.0 has been reported to have build issues
Fixes #875, #881

Where has this been tested?

Platform(s): Ubuntu 16.04
Python version(s): 3.6, 2.7
Unreal Engine version(s):

This change is

The Boost 1.68.0 release may have some issues with the IO extensions (see here). This has been already fixed in Boost's master. It seems to be an issue for PythonAPI's JPEG/ PNG/ TIFF extensions (as reported by the CI error in https://travis-ci.org/carla-simulator/carla/jobs/452018876).
The issue is due to : error: use of undeclared identifier 'bits8' in Boost 1.68 image IO.
I see 3 options:

Wait for Boost release 1.69.0 to be available
Build off of Boost's master
Patch the Boost headers by adding:

namespace boost { namespace gil {
typedef uint8_t  bits8;
typedef uint16_t bits16;
typedef uint32_t bits32;
typedef int8_t   bits8s;
typedef int16_t  bits16s;
typedef int32_t  bits32s;
typedef float32_t bits32f;
}}

to /usr/include/boost/gil/extension/io/tiff_io.hpp, /usr/include/boost/gil/extension/io/png_io_private.hpp and /usr/include/boost/gil/extension/io/jpeg_io_private.hpp

Boost 1.69 beta is out, maybe we can start testing and see if it also fixes #949.

Building with Boost 1.69 Beta goes fine for me locally. But, I do not think it is a good idea to build this master branch against the beta release.  What do you think?
For #949 , I have pushed an update that may satisfy Travis.
Once we have the Boost 1.69.0 release, these issues will likely be resolved.


feat: Dark Theme

Changes:

Add dark theme
Add new theme properties
Update a number of components to use the new theme properties
Add the ability to toggle the theme from the drawer
Add the ability to deep merge themes instead of one-level merge
Remove react-native-drawer package
Add lodash.merge

Dark theme compatible components

FAB
Card
CheckBox
GridView
Paper
RadioButton
SearchBar
DawerItem
DrawerSection
The rest of the component involved non-trivial logic to apply the colors so it's better if their authors update them to avoid any breaking changes.

Screenshots

I have some comments about the screenshots:

Drawer focus item probably should have different color? White?
All icons should be 100% white (not that grey from Search)

For the other stuff, it looks very good (didn't check all code).

I don't think paper is a good name for the theme property. The name is tied to a very specific component and the property is not specific to that component.

@satya164 Okay, then suggest another name 😄


MLTable and Azure ML Datasets

Hi,
I am trying to register a dataset with azure ml studio. I have my MLTable artifact on the azure blob store (access level: container).
I am able to load the MLTable with:
url = https://<account_name>.blob.core.windows.net/<container_name>/path
tbl = mltable.load(uri=url)
df = tbl.to_pandas_dataframe()

However, if I try to register this dataset with:
my_data = Data(
    path=url,
    type=AssetTypes.MLTABLE,
    description="test",
    name="test-mltable",
)

ml_client.data.create_or_update(my_data)

I get the error
Invalid URL 'https:/<account_name>.blob.core.windows.net/<container_name>/<path>/MLTable': No host supplied

There is a missing / in the URL of the error message which might be a problem?
Thanks,

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 23d04020-3ab4-b2f2-558f-e90cdb1c1ea3
Version Independent ID: 5ee94e1d-c95d-6def-dfbb-f31979170ed5
Content: azure.ai.ml.entities.Data class
Content Source: docs-ref-autogen/azure-ai-ml/azure.ai.ml.entities.Data.yml
Service: machine-learning
GitHub Login: @lmazuel
Microsoft Alias: lmazuel

Hi @adrianomartinelli - Thanks for your bug report! Tagging the right people to take care of this.

@azureml-github - can you take a look at this?

@adrianomartinelli This error is a non blocking one. You should still be able to successfully create your data asset.
This error occurs while validating MLTable schema and hence is supposed to non blocking which skips validation and creates the data asset.
As for fixing the issue for validation(url problem you noticed) , the fix is in a PR and will be fixed as part of next release.


mypy error in views

error message:
app/users/views.py:41: error: Argument 1 to "get_errors_dict" has incompatible type "List[ErrorDict]"; expected "List[Dict[Any, Any]]"  [arg-type]

ref:
users.views.create_organization_submit

maybe linked to services.utils.get_errors_dict input type

You could try to change the type here https://github.com/vincentporte/fastapi_sqlachemy2_async/blob/38aada06c883a3f57045fd148561d535fce38400/app/services/utils.py#L3
With ErrorDict = Dict[Any, Any]
If it doesn't work change the type here https://github.com/vincentporte/fastapi_sqlachemy2_async/blob/38aada06c883a3f57045fd148561d535fce38400/app/services/utils.py#L6
With
def get_errors_dict(errors: List[Dict[Any, Any]]) -> dict:


WIP: Filter found ctags by the type/kind

Especially when working with the linux kernel, ctags output often has dozens of entries and so far in vim there are no means to easily filter them by type (e.g. structure name or other types as specified in http://ctags.sourceforge.net/FORMAT). This (lack of) behavior is annoying, and targeted for improvement in the runtime/doc/todo.txt
Introducing a filter that will by default retain the old practice of displaying everything, but will only show a specific type of ctags records after a mapped letter is pressed on the keyboard.
To test the patch, do (for example):

Set up ctags as you would normally do and open a source code file
Put the cursor on a structure name somewhere
Press g ] or otherwise enter the mode where you see a list of tags
Press s to only see your structure's definition
*) If there are more than one screen worth of entries, you'd need to exit the more mode with q before the filter starts accepting keypresses. more will return upon refreshing the filter if necessary.
*) Press s again to clear the filter
Hit Enter to go to the entry number prompt

This patch only deals with one (my) user case so far, but I'm looking to expand it, hence the WIP prefix. Please help me by defining other cases here, if they are deemed necessary.
Please make your diff ignore whitespaces as these commits includes many indentation changes.

Codecov Report

Merging #2871 into master will decrease coverage by 0.01%.
The diff coverage is 56.3%.

@@            Coverage Diff             @@
##           master    #2871      +/-   ##
==========================================
- Coverage   75.44%   75.43%   -0.02%
==========================================
  Files          92       92
  Lines      134831   134842      +11
==========================================
- Hits       101724   101718       -6
- Misses      33107    33124      +17

Impacted Files
Coverage Δ

src/tag.c
72.39% <56.3%> (-0.02%)
:arrow_down:

src/term.c
59.62% <0%> (-0.21%)
:arrow_down:

src/message.c
74.59% <0%> (-0.2%)
:arrow_down:

src/if_xcmdsrv.c
84.53% <0%> (-0.18%)
:arrow_down:

src/window.c
81.89% <0%> (-0.1%)
:arrow_down:

src/ex_cmds2.c
78.58% <0%> (-0.1%)
:arrow_down:

src/gui_gtk_x11.c
47.68% <0%> (-0.05%)
:arrow_down:

src/channel.c
83.1% <0%> (-0.04%)
:arrow_down:

src/if_py_both.h
76.59% <0%> (ø)
:arrow_up:

src/eval.c
81.48% <0%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606cb8b...5de039e. Read the comment docs.

Especially when working with the linux kernel, ctags output often has dozens of entries and so far in vim there are no means to easily filter them by type (e.g. structure name or other types as specified in http://ctags.sourceforge.net/FORMAT). This (lack of) behavior is annoying, and targeted for improvement in the runtime/doc/todo.txt
Introducing a filter that will by default retain the old practice of displaying everything, but will only show a specific type of ctags records after a mapped letter is pressed on the keyboard.
To test the patch, do (for example):

Set up ctags as you would normally do and open a source code file
Put the cursor on a structure name somewhere
Press g ] or otherwise enter the mode where you see a list of tags
Press s to only see your structure's definition
*) If there are more than one screen worth of entries, you'd need to exit the more mode with q before the filter starts accepting keypresses. more will return upon refreshing the filter if necessary.
*) Press s again to clear the filter
Hit Enter to go to the entry number prompt

This patch only deals with one (my) user case so far, but I'm looking to expand it, hence the WIP prefix. Please help me by defining other cases here, if they are deemed necessary.
Please make your diff ignore whitespaces as these commits includes many indentation changes.

Hmm, filtering tags after listing them is rather limited.  I mostly use
autocomplete.
How about using something like:
:tag s/tagname

Where "s/" means of type "s" (struct).  Then I can do:
:tag s/tag<Tab>

To only complete structs.
Is "/" never used in an actual tag name?  An alternative is to separate
with a space:
:tag s tag<Tab>

For filtering the list, this assumes the type is always a single
character. Is that really true?
--
Vim is like Emacs without all the typing.  (John "Johann" Spetz)
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Well, in the ctags source the tag kind is denoted by a single "kind letter":
typedef struct sKindOption {
        boolean enabled;          /* are tags for kind enabled? */
        int letter;               /* kind letter */
        const char* name;         /* kind name */
        const char* description;  /* displayed in --help output */
} kindOption;

Moreover, I'm not sure whether there are languages that call for more than [26 letters + 10 numbers] kinds of tags, so everything will probably stay this way...
I'm pushing the commit with :tag <tagkind> <tagname> support. It would also be possible to use / as a separator. Please take a look!

Looked at this again, sorry it took so long.
The place to check for a match is around "First try matching with the pattern literally".
We do need to support multi-character kind names.
I do think to use something like {kind}/{tagname} is useful.  This can also be used in other places.
Not sure if a slash is the best character for separating the kind from the tagname.

Yeah, I've been tinkering around with the thing on my own, and {kind}/{tagname} seems very comfortable - at least for the C/C++/python mix.
Honestly don't understand the case for multi-character kind names, but this oughtn't be much more difficult to do.
I'll update the PR in a couple weeks :)

(Just idea of extension of this: to add possibility to sort tags by type, when "-- More --" or "Type number and  (empty cancels):" invites for key press)

this is "WIP" for more than a year, therefore closing.


Windows – Color not working

Hi
Using windows environment
try to use --help, got this errors, just right before filename appeared=
The system cannot find the path specified.
The system cannot find the path specified.
The system cannot find the path specified.

Yes, 3 in a row.
Thanks

This happens when executing "tput" to get the width of the terminal in Terminal.php line 51 ff.
    private static function tput($default, $param = 'cols')     {         $test = exec('tput ' . $param . ' 2>/dev/null');         if (empty($test))             return $default;         $result = intval(exec('tput ' . $param));         return empty($result) ? $default : $result;     }
It would be more optimal if at first the os is detected with the PHP_OS constant and check for the first 3 characters = "WIN".
Even for Linux environments it could be optimal to execute "which tput" at first to see if it's there and accessible.
For Win Environments I think there is not an optimal way to get the width. I think it's best to execute "MODE CON:" as this is available in every Windows installation (I think even since MS-DOS 3.3 :) )
The returned string gives console parameters like the width, lines and so on. But the output is language dependent. So in my German installation something like:
`
Status von Gerät CON:
Zeilen:          300
Spalten:         99
Wiederholrate:   31
Verzögerungszeit:1
Codepage:        850

`
So you'd have to maybe regex to get the second line after "-----".

I think the tput function could be optimized like the following. It's working good in my environment.
    private static function tput($default, $param = 'cols')
    {
    	if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN')
    		return $default;
    	$path = trim(shell_exec('which tput'));
    	if (empty($path))
    		return $default;
        $test = exec('tput ' . $param . ' 2>/dev/null');
        if (empty($test))
            return $default;
        $result = intval(exec('tput ' . $param));
        return empty($result) ? $default : $result;
    }

Maybe you can import the changes...


Import selected layers button should be disabled when selecting a new LoD

In the Layer Loader, in Layers tab, you select for example the Feature type "Building". Then you select a LoD, and then you can pick from the list of available layers which to import.
If you change the LoD, the import button should be disabled till you select again a layer.

Solved in upcoming 0.8.7


drivers: modem: sara-r4: fix APN setting for U2 modem

usage of AT+UPSD command per UBX-17003787(R15) command reference is:
AT+UPSD=<profile_id>, <param_tag>, <param_val>
For AT+UPSD=0, 1, "": we are setting value to MCCMNO, which
is technically incorrect.  <param_tag> of 1 means:
1: APN - <param_val> defines the APN text string, e.g.
"apn.provider.com"; the maximum length is 99. The factory-programmed
value is an empty string.
Let's use APN here instead.  This fixes a +CME ERROR: 113 when
connecting with U2 modem.
Fixes: https://github.com/zephyrproject-rtos/zephyr/issues/22689
Signed-off-by: Michael Scott<EMAIL_ADDRESS>

@WilliamGFish @hwilmers @gpaquet85 @weinholtendian Please take a quick look.


Update playbooks.md

Described testing changes with branches

removed section about opt-out as it seems to be irrelevant now / contained in user docs too.

go it, thx!


More ticker fixes

Wouldn't consider it a critical bug since this property is really just for convenience anyway, but ticker.FPS was being calculated horribly wrong.
Outside of that... just a bunch more documentation, including examples in ticker/index.js docs.

Didn't even think about it like that :(
Now I want to change it to TARGET_FRAMES_PER_MS
On Tue, Apr 21, 2015 at 7:24 AM, Chad Engler<EMAIL_ADDRESS>wrote:

Merged #1689 https://github.com/GoodBoyDigital/pixi.js/pull/1689.
—
Reply to this email directly or view it on GitHub
https://github.com/GoodBoyDigital/pixi.js/pull/1689#event-286262391.


Contact priologic

Sorry for opening this in gh, I tried e-mailing @priologic through the contact@ address on your site and getting an error... whats the best way to contact?  I'd like to discuss some possible project using easyrtc which may involve some consulting or your enterprise version...
thks

Hi,
To reach Doug, our CEO, you can use<EMAIL_ADDRESS>Eric.


GSoC Account Setup Branch Review

Just opening this so I can provide early feedback.

@philipwhiuk Thanks for your review!!
A trouble I met is that according to rfc6186, there is no way to detect what is used as a user identifier when contacting to the mail server. We must use the full email address first, if it fails, then fall back to using the "local-part" extracted from the email address. To achieve this, code in AccountSetupCheckSettings need to be modified. Considering that the whole workflow will be rewritten in the future, I just use email address as user identifier, and plan to implement this fully when the new workflow is ready.

This whole thing is a perfect candidate for test-driven development, since most of the logic can be kept in pure functions: create mock responses for the dns/http queries, write tests for the parsing methods that check the expected output, then implement the methods.
The techniques should also be kept in separate classes, implementing a common findProviderInfo interface. They can then be tied together by a class that depends on those specific techniques and just runs them in some order.

@Valodim Thanks for your review! What's the advantage of creating separate classes rather than different methods in just one class?

I implemented autodiscover. But due to the lack of documents, there may be something incorrect in my implementation. For example I don't know exactly what will happen if DomainRequired is "on".
I also write tests for three mechanisms. The idea of test-driven development is really helpful. I found some bugs by tests and fixed them.

rewrite some UI. Still need do more and integrate auto configuration with settings checking

Just integrated autoconfiguration and the new UI. The Travis CI failed because test about new UI should be updated, will fix it in this branch soon.

@philipwhiuk I'm working on xoauth2 based on your code :) Thanks for your amazing work.
I'm using my own debug.keystore to register on Google API Console, so that everyone except me can't use this feature now. It's inconvenient to review. Do you have any advice on it? :)

Unfortunately not. The actual Google API key thing was something I never got fully working. I think I authorised my device to use it regardless in the end (which I never really worked out how you revoked...) Once we push it it'll have to use a keystore provided by cketti I expect.

@philipwhiuk I have made oauth 2.0 without dependency on Android account system working. It seems keystore does not need to be matched any more.

Please do a rebase on current master when convenient :)

the autoconfig currently only tries the mail address as login name. I think it's common to have only the local part of the address (before the @) used as a login name, so that should be tried as well.
Also, when a server is found and authentication fails, that should be correctly handled, telling the user that their password was wrong.

Please fix tests, and rebase this on current master :+1:

I'm going to close this review (it's rather long and will be even more confusing post-rebase) - create a new one for the rebased version.

@philipwhiuk has anybody created a new version of this pull request? I'd really like to avoid the Google Security Alert errors when K-9 Mail happens to check for email when I'm not on WiFi. Thanks :)


⚠ 366.ru has degraded performance

In 3df99ce, 366.ru (https://366.ru) experienced degraded performance:

HTTP code: 200
Response time: 5588 ms

Resolved: 366.ru performance has improved in 22e982a.


SetterIf Annotation Processor

generate new subclass of @SetterIf data class

see https://github.com/trydofor/professional-nevermore

notice if the preview contains Keywords, otherwise mute


Import commonly used visualizations by default

Summary
From an usability point of view, it should be easier to use the circuit_drawer and plot_histogram functions.  Especially given that they are used in the very first intro notebook.
Details and comments
This PR makes the circuit_drawer and plot_histogram functions available at import.

should this be done for plot_histogram as well?

Sure.  It is in the most basic tutorial.

I had to wrap the imports in a try because our travis builds do not build Python correctly for matplotlib osx backend.

@ajavadia please take a look

Looks good to me. Don't know if it's something that merits a changelog.


Bump org mgt version

$Subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/2670731150


Waiting for atleast 2 mongo pods to come up after scaling down to 0 and scaling backup to 3 again

What this PR does / why we need it:
As of now , we are waiting for min 1 mongo pod to come up, and then verifying restore status
We need to wait for atleast 2 mongo pod to come up to meet the quorum.
Which issue(s) this PR fixes (optional)
Closes #https://purestorage.atlassian.net/browse/PB-7163
Special notes for your reviewer:

Is this change tested?

Is this change tested?

https://jenkins.pwx.dev.purestorage.com/job/portworx-backup/job/system-tests/job/byoc/job/px-backup-on-demand-system-test-byoc/5235/consoleFull


[Bug]: Two checksums for the same image - upload via upload wizard and commons app

Summary
The same image can be uploaded twice to Commons, once using the Upload Wizard and once using the commons app (duplicate). Presumably, different checksums are created depending on the upload tool.
Steps to reproduce

Upload via Upload Wizard
Upload the same image (other file name) with commons app

Expected behaviour
Upload Wizard or Commons App inform me that there is a duplicate
Actual behaviour
See:
Category:Two checksums for the same image - upload via upload wizard and commons app.screenshots
https://commons.wikimedia.org/wiki/Category:Two_checksums_for_the_same_image_-_upload_via_upload_wizard_and_commons_app.screenshots
Device name
Google Pixel 7 Pro
Android version
Android 14
Commons app version
5.0.2~05ffd123e
Device logs
No response
Screen-shots
See:
Category:Two checksums for the same image - upload via upload wizard and commons app.screenshots
https://commons.wikimedia.org/wiki/Category:Two_checksums_for_the_same_image_-_upload_via_upload_wizard_and_commons_app.screenshots
Would you like to work on the issue?
None

See also: https://github.com/commons-app/apps-android-commons/issues/5798

See also: https://commons.wikimedia.org/wiki/Commons:Village_pump/Proposals/Archive/2022/07#Duplikat-Erkennung:_Commons_Hochlade-Assistent_und_Commons-App

Anyone willing to try and fix this bug?
Ideally, the Commons app should check whether any of these two checksums get a match using the Wikimedia server's search API:

The checksum of the image that the user is about to upload.
The checksum of the image that the user is about to upload after applying the user's configured EXIF anonymizations.

I want to try :hand:

Thanks Parneet!
First, would you mind posting here a link to the code that checks whether an image is already on Commons or not? :-)

https://github.com/commons-app/apps-android-commons/blob/64fd10d00e8ba5bd220db32740247c6b00e3cd8e/app/src/main/java/fr/free/nrw/commons/media/MediaClient.kt#L51
This above is used through some logic in UploadPresenter
This PR #5570 did remove a piece that I suspect might be the issue, can't say for sure..

Great find!
Now you will have to call that function a second time, with the SHA of the original file (before EXIF modification).

Just to confirm, we just want the checksum that app generates to be same with web's upload wizard one, so it can properly prompt the user that this is a duplicate?. And this has nothing do with blocking duplicate uploads? (BTW is it allowed to upload duplicates?)

The website does not modify files, so the checksum of a file uploaded via the website is the same as the original file's checksum.
The API does not prevent uploading duplicates, but the app should do whatever it can to prevent this from happening.

Thanks! I found the issue, basically when checking for duplication before upload the checksum that is generated is different from the web one generates. Also, when the actual upload happens checksum is again generated but this time it matches with the web one. Difference was we pass two different android.net.Uri instances in these two cases, I'm gonna find the why and make the changes.

Now you will have to call that function a second time, with the SHA of the original file (before EXIF modification).

And where is the first time we should be calling this function?


Update tests for latest SDK and fix bug in validator return types

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

@tjprescott, will you be reviewing this PR?

@tjprescott Can you please merge these changes. Thanks.


Fix some typos

I'm not going to merge this because the publisher asked for k-means to be formatted in exactly that way, but thanks for reporting the other typos

Fair enough; but, regarding the dashes in k-means, you mean? I only added those to make sure it was consistent across the notebook, so if they are not supposed to be there at all, you may want to remove them the other places (or maybe the inconsistency is what the editor asked for?)
In any case, you're welcome; I enjoyed the material and it has already become a staple for day-to-day lookups here.


Also check sql for task/directory

We have some cases of task emails not being sent on finish. If the persister runs between the task finish and email send, we won't find the task/directory and won't send the email. This updates the smtp mailer to fall back to the sql data if present

🚢


Error on calling print on Android 8

Hi.
First, thanks a lot for your great work.
I'm trying to use your plugin in a Vue/Capacitor app (Android) but, when I call the print method, like this:
let page = document.getElementById('ticket')

window.cordova.plugins.printer.print(page, 'Document.html')

, I'm getting this error:
E/AndroidRuntime: FATAL EXCEPTION: main
    java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.lastIndexOf(int)' on a null object reference
        at de.appplant.cordova.plugin.printer.Printer.loadContent(Printer.java:209)
        at de.appplant.cordova.plugin.printer.Printer.access$500(Printer.java:64)
        at de.appplant.cordova.plugin.printer.Printer$3.run(Printer.java:181)
        at android.os.Handler.handleCallback(Handler.java:790)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6626)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:811)

Also tried to get dev version working without success. Could anyone kindly help? Thanks in advance!

If you use the dev branch, please see the readme. The way you pass the arguments worked in the past, but not now anymore.

I couldn't manage to get the dev branch to work. I'm using the v0.7.3.

Whats the issue?

I couldn't manage to get the dev branch to work.

E/AndroidRuntime: FATAL EXCEPTION: main
    java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.lastIndexOf(int)' on a null object reference
        at de.appplant.cordova.plugin.printer.Printer.loadContent(Printer.java:209)
        at de.appplant.cordova.plugin.printer.Printer.access$500(Printer.java:64)
        at de.appplant.cordova.plugin.printer.Printer$3.run(Printer.java:181)
        at android.os.Handler.handleCallback(Handler.java:790)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6626)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:811)

I've cloned from dev, installed with npm (because my app isn't a Cordova app) from clone and, when trying to build in Android Studio, a lot of errors came. Started with a "lambda expression is not supported at this language level 7" (what I managed to solve) but, every try to build, new errors were rised and insisted with the v0.7.3 what got me the error in first post.

Terrible sorry. I was trying print a HTML fragment with an image. Realized that I was doind it wrong. After create a page to display the content needed and pass this url to plugin, worked like a charm in v0.7.3.
Thanks and appologies for this and again thank you for your work!
PS: I've closed this issue.


added services section

@2024-SANDHYA For resolving Issue #2 I have added 'services' section to the website. Currently the front side of the card is blank. I have put one empty img tag for each card. Add respective images in that. Also I have named all the services as 'Service' for now, and content as lorem ipsum.
https://suyogkokaje.github.io/Dust-Road-Co-Changes/
You can view the service section in the above website for demo.

Hello @2024-SANDHYA please have a look.

Okay. I will work on it.

First cards will be in this state

and after we hover on them they will appear on screen with proper animation like  this

I will change the colour scheme according to our website, but is this design good? @2024-SANDHYA

First cards will be in this state

and after we hover on them they will appear on screen with proper animation like this

I will change the colour scheme according to our website, but is this design good? @2024-SANDHYA

No. Something like this :

Cool. Thanks

Hello @2024-SANDHYA I have made the suggested changes.  Please have a look.

Hello @2024-SANDHYA I have made the suggested changes. Please have a look.

It's looking very bad, leave it.


Allow anonimous users

Previously, there was an empty string for an int non null column.

:clap:

Hi @hmert glad to see that you are active.
I have a question. The inbox is made for the person sending the feedback, or admin, or both?

Hi @amcastror, the inbox is for the admin user. But maybe we should provide a page for the feedback person.


Viewmodel cache wtf?

Caches would probably be gone due to https://github.com/ractivejs/ractive/pull/1740 but just wondering when are viewmodel caches cached and updated? Basically, the component is just this, pretty straightforward:
computed: {
  shouldNotificationOpen: function(){
    debugger; // 2
    var a = this.get('a');
    var b = this.get('b');
    var c = this.get('c');
    return a && (b || c);
  }
},
oninit: function(){
  ExternalData.listen(function(){
    debugger; //1
    this.set({
      a: ExternalData.getA(),
      b: ExternalData.getB(),
      c: ExternalData.getC(),
    });
    debugger; //3
  });
}

Updating the data with different values, it should be simple enough to reason out that the computed will run and will update its value (and re-render whatever uses it). Shown in the sample, the debugger;s will run in the said order. However...
In some cases, the second debugger; will not run at all. After hours of tracing through Ractive, it appears that doesn't run the computation because the value is somehow cached. The code will not run through here: https://github.com/ractivejs/ractive/blob/v0.6.1/ractive.js#L13490
So back to the question:

What causes it to cache the value
When does it cache a value
When does it update the value
What are workarounds to prevent it from being cached.

Knowing when these happen and why would put me in the right direction.

Are you seeing it not rerun the computation function when it fact should rerun it based on changed data?

@martypdx Yup, the second debugger (the one in the computed value) doesn't run at all after set. It doesn't pass here https://github.com/ractivejs/ractive/blob/v0.6.1/ractive.js#L13490 but here instead https://github.com/ractivejs/ractive/blob/v0.6.1/ractive.js#L13505

@fskreuz Here's a fiddle that emulates what it looks like you're trying to do: http://jsfiddle.net/os9uh73q/. Seems to work, but maybe I don't have the right combination of value changes. Can you try with same values as is happening in your case?
As to the broader question on caching, in current code it prevents unnecessary refetching of data, if nothing has changed. On a set operation, the cache will be cleared for that item plus any upstream, downstream and computational dependencies. Computations have an additional layer of checking input value changes explicitly before recalculating. There haven't been any known issues, so if you've found a bug we should correct.

Caches would probably be gone due to #1740

Yes and no. I've used the same pattern of "marking" the data node graph as dirty when a change happens. Currently there is no explicit caching, I took it out to focus on the core functionality and to see where would be the best place to put it in. At this point I think it will be added back in for two reasons:
The first is that there is a cost in refetching the data value if the value is deeply nested, for example getting dop of foo.bar.qux.dip.dop requires walking accessors all the way down: foo[bar][qux][dip][dop]. It's only a small gain, but it may be more more significant when you consider adaptors. But probably the bigger reason is:
Know if a value has "really" changed and don't notify dependants if it hasn't. Imagine foo is { one: 'bar', two: 'qux' } and gets set to { one: 'bop', two: 'qux' }. foo.two hasn't changed but unless we know the prior value we can't make that determination.
Currently this comparison happens partially in the viewmodel via cached but primarily in the virtualDOM objects for the purpose of not making unnecessary DOM changes.  And maybe it should just stay there, but it may make sense to pull this comparison closer to the data and not send the notification out at all (though that would require changing the virtualDOM objects to pull the value whereas now it is pushed).
And if we get it to reliably not over-notify in the viewmodel, we could possibly eliminate the guard checking on computations.

Will just close this for now and investigate why it's happening. Most likely not a Ractive bug, but if it is... :trollface:


Add a flag to swap direction in selectors

When you work on projects that's primarily RTL and you depend on stylesheets from different vendors who code for LTR use mainly, you'll face a small confusing issue in selectors that have hardcoded direction in them like rtl, left, right etc. because when you convert the stylesheets to RTL those selectors will have an opposite effect of they appear to do. This issue might not be important for projects that is mainly LTR but in the other way it counts.
Let's take for example one of the common bootstrap classes that show this problem:
.pull-right {
    float: right
}

will be converted to
.pull-right {
    float: left
}

As you can see, it's a bit confusing when used in html markup with RTL as the primary direction.
What I'm proposing here is to allow changing directions in selectors as an option or two like swapLtrRtlInSelector and swapLeftRightInSelector that are disabled by default.

From the initial description it sounds like you're under the impression that pull-left would be flipped, but not pull-right. However, selectors are preserved  in CSSJanus regardless of which directionality they are about.
As such, @noflip seems appropiate.
Changing directionality within the selectors seems undesirable as this would require a matching change in HTML content - which we want to avoid, by design.
If you do wish these kinds of rules to be flipped, the content to be affected, and the class names to make sense, I'd recommend renaming the classes to something more semantic by using directionality-neutral terms like "start" or "end".
This also matches how other CSS properties work internally. Such as the native default for text-align (which is start, not left), with a matching value of end for the opposite direction. See also the flex-start and flex-end values for the justify-content property from the CSS Flexbox features. These features work in different directions (left-to-right and right-to-left, but also top-to-bottom).


Describe content & publishing API and schemas

As a new joiner, it's quite hard to find all of the different aspects of the
content store in one place. This is an attempt to touch upon all of the key
parts, from reading & writing to the content store, to conforming to schemas,
to querying the content store for content that has no 'path' (something that
isn't very clear is a thing in the first place, it not being written anywhere).
This also tidies up the use of markdown links, making them alphabetical etc.

I wonder if this documentation is better placed in the README.md for Content Store and then we can embed it using ExternalDoc.fetch, similar to what was done for the side by side docs.

Hmm, I like the idea 👍is it bad that it pulls in things like license information? I guess not!


Adds all .rst files to build.

Closes #56 .
This is a merge request from this bugfix branch into the 2.2-branch. I will then release a 2.2.1 version from the 2.2-branch, which will include CHANGELOG.rst in the sdist, solving #56.
I'll create this as a draft and think about it for a while. Please comment if you have any comments or concerns about this approach.

I'll fix pipelines when we actually need to backport functionality and tests needs to run.

I'll fix pipelines when we actually need to backport functionality and tests needs to run.


Convert match

WIP : Unification implemented and all of Match.hs up to but not including matchIdea which is where the porting effort needs to be resumed from.

Nice. Will merge once CI passes.

Thanks!


[KubernetesManifestV1] Add input param that allows usage of the cluster admin credentials

Task name: KubernetesManifestV1
Description: Add input param that allows usage of the cluster admin credentials
Documentation changes required: (Y/N) Y
Added unit tests: (Y/N) N
Attached related issue: (Y/N) #18253
Checklist:

[X] Task version was bumped - please check instruction how to do it
[X] Checked that applied changes work as expected

@ozanovus could you please review this since you've been the person who initially created this task?

Thanks for bringing in this topic @viktar-kaliada .
I've updated your task's version and pulled latest changes from master. After tests are completed, we can merge this.

/azp run


Feature/671/add guard

Description
This PR does the following:

Attaches Fractal, VetoGuard, VetoVoting to a gnosis safe
There are 4 noble paths - Root Gnosis, Sub Gnosis, Root Usul, Sub Usul
Updated contract addresses

Notes

Issue / Notion doc (if applicable)

Testing

Screenshots (if applicable)

Why was votesTokenMasterCopy changed to votesMasterCopy everywhere?

I am not sure -- this was not m

hit enter too quick. Updates look good to me! lol

I think we should be a little more explicit with the variable naming, more like:
multisigVetoGuard
usulVetoGuard
multisigVetoVoting
erc20VetoVoting


Apply RTC_CENTER from tile data to GLB

The b3dmToGlb and i3dmToGlb operations until now only extracted the GLB payload from the tile data. The resulting GLB did not take into account any RTC_CENTER that may have been defined in the feature table of the input data.
This PR changes that: When there is an RTC_CENTER in the feature table, then this will cause new root nodes to be inserted into the GLB, which have the RTC_CENTER as their translation (taking the y-up-to-z-up transform into account).
Some details to be decided:
1. Should applying the RTC_CENTER always be done?
The b3dmToGlb and i3dmToGlb can either be used as content stages in a pipeline, or used as "standalone" commands from the command line. I currently assume that the RTC_CENTER should always be applied, but wonder whether someone might want an option to only extract the GLB, without applying the RTC_CENTER. Something like this could be offered with an option, e.g. by having a -applyRtc=true/false command line option that is true by default...
2. Should applying the RTC_CENTER also be done when extracting the (multiple) GLBs from a CMPT?
The cmptToGlb command line operation takes one CMPT, and extracts all GLBs (recursively through other CMPTs or I3DMs or B3DMs). I assume that the results should also include the RTC_CENTER for now.

I think it's fine if RTC_CENTER is applied by default, with an option to override that. Same for inner cmpt contents as well.

There is no option to not apply it right now, but I can add that.
(Converting to draft for now)

After some internal discussion, we decided to not apply the RTC_CENTER to the GLB data by default.
The reasoning is that the b3dmToGlb command should primarily extract the data, as it is. (It will still perform an attempt to upgrade from glTF 1.0 to glTF 2.0. But for glTF 2.0 assets, the asset should be extracted in an "unmodified" form)
There are many things that could go beyond just extracting the data, and integrating the RTC_CENTER into the GLB would be only one of them. So this should be covered, together with maaaany other things, with the generalized upgrade. Specifically: There will probably be a convertB3dmToGlb function that does ~"the things that go beyond extracting the data" (and what that is, exactly, still has to be sorted out...)


iOS crash on Init()

I am having trouble with await _tesseractApi.Init(“eng”);
I have tried everything but this silently kills the app.
In the Application output there is only one line that may reference the issue: actual_tessdata_num_entries_ <= TESSDATA_NUM_ENTRIES:Error:Assert failed:in file tessdatamanager.cpp, line 53
The file is definitely added: <BundleResource Include="Resources\tessdata\eng.traineddata" />

So I think the blog post link to download the files might have changed, or there needs to be more explanation on what files you need to download. I downloaded just the eng.traineddata file but turns out you need all of these: https://github.com/halkar/Tesseract.Xamarin/tree/master/Tesseract.Forms.Test/tessdata

Yes, you need all eng.* files.


Deploying to Hololens 2 might need different settings (when deploying over wifi)

"Configure Visual Studio for HoloLens by selecting the Master or Release configuration, the ARM64 architecture, and Device as target" <- this only works when your Hololens is connected to your PC via USB AND you are also able to access it via the device portal by opening https://<IP_ADDRESS>:10080 in your browser.
However, this (for some reason) often does not work (I, for example currently get the following error: SSL_ERROR_RX_RECORD_TOO_LONG in firefox).
If your Hololens 2 is paired to your PC AND you can access it via the device portal by opening its real network address in your browser, then you can deploy over wifi, but with different settings. Hence, I suggest adding the following text tot he tutorial:
"To deploy over wifi, configure Visual Studio for HoloLens by selecting the Master or Release configuration, the ARM64 architecture, and Remote Machine as target. Then go to Project -> Properties -> Configuration Properties -> Debugging. Make sure Configuration is set to Release and Platform to ARM64. Then, in the dropdown Debugger to launch: select Remote Machine and add the real network address of your Hololens as Machine Name.
I also suggest adding an image like this one (feel free to use this).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 62d386bb-3f93-d434-e7b3-28c58ea673e9
Version Independent ID: a1a9b02f-66a0-feb0-7a08-9a8d2cf398d1
Content: Getting started tutorials - 2. Initializing your project and deploying your first application - Mixed Reality
Content Source: mixed-reality-docs/mr-learning-base-02.md
Product: mixed-reality
Technology: mr-dev
GitHub Login: @jessemcculloch
Microsoft Alias: jemccull

@hferrone The suggested text is accurate and informative, can we include it? I also think the image is very helpful.

Absolutely, this is going up in an update tonight!


Request for new

Describe The Bug
Requesting support for the Levoit EverestAir model
Expected behavior
N/a
Logs
N/a
Plugin Config
Plugin Config
{
"name": "Levoit Air Purifiers",
"email": "",
"password": "",
"_bridge": {
"username": "0E:A8:70:B3:CB:90",
"port": 43561
},
"platform": "LevoitAirPurifiers"
}
Plugin Version
2.0
Homebridge Version
4.52.1
Node.js Version
16
NPM Version
6.4
Operating System
windows 11

Dublicate of #47 and don't have the unit to can add support


Enhancement: Change OPENAI_REVERSE_PROXY to only expect a network host / port.

Contact Details
No response
What features would you like to see added?
Thanks so much for this great project. There aren't many working front ends like yours let alone with all these great features. I do have a question, similar to the comment below on how best to point LibreChat at my localai container. It's already pretty much working, but I was wondering how feasible this change below might be.
I don't know how dumb an idea this might be, but is it possible to alter the code so that OPENAI_REVERSE_PROXY is not expected to provide any api paths /v1 /v1/chat/completions, and those are just presumed? I'm guessing the path is built in for other use cases I'm not aware of, but in the event it's not, it would make integrating with localai fully automatic.
More details
https://github.com/danny-avila/LibreChat/issues/403#issuecomment-1567226622
In the comment above, you point out how to hard code the models in the event that you are running your own reverse proxy (or using the OPENAI_REVERSE_PROXY env as a way to access local llms like via localai).
If I set
OPENAI_REVERSE_PROXY: http://host.docker.internal:8070/v1

Librechat will grab the model list from localai without issue from /v1/models, but will fail to post to /v1 because that's not the right end point.
If I set
OPENAI_REVERSE_PROXY: http://host.docker.internal:8070/v1/chat/completions

Then my posts go through and I can chat with the localai models, but only if I've hard coded them ahead of time.
Which components are impacted by your request?
No response
Pictures
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I notice the CHATGPT_REVERSE_PROXY in some of the documentation so I tried
CHATGPT_REVERSE_PROXY: http://host.docker.internal:8070/v1
OPENAI_REVERSE_PROXY: http://host.docker.internal:8070/v1/chat/completions

Just to see what would happen, and it polled the models as expect and was able to post chats as expected. This gets me where I wanted to be.

Hi, thanks for using LibreChat! This is related to #1026 except the point about fetching models. What endpoint is it for LocalAI to fetch models? I can try setting it up today to test

Actually I'm a little confused here. It should be fetching models correctly with this:
OPENAI_REVERSE_PROXY: http://host.docker.internal:8070/v1/chat/completions

I'm testing LocalAI in a minute

In local ai, I see the models @ http://localai:port/v1/models

I think I know what's going on. I'm not gonna dive deep into LocalAI setup but basically, you can only start posting to models out-of-the-box if they can receive a messages payload, which I believe you need some template to format the JSON messages.
I think without a template, the payload will need to receive a single text prompt, which makes it work:

Note I am using OPENAI_REVERSE_PROXY with the OpenAI endpoint, I am now able to post messages in this endpoint while also being able to select models:

I remember being able to use LocalAI no problem without forcing the prompt payload, but I must've been using a model that has OpenAI formatting out-of-the-box

Relevant LocalAI docs: https://localai.io/advanced/index.html
For now, as a quick patch, I can add an environment variable to force the prompt payload, but to make the UI setup more flexible, I can make this an option on the frontend soon

Actually, i just realized this is happening due to calling /v1/completions and not /v1/chat/completions, idk why I set my reverse proxy without chat lol
In any case, calling /chat/completions needs a template or the LLM will just continue your response

I will add an option to check for /completions and force the prompt in this case, also allowing the user to force prompt with .env var

Thanks for looking into this so quickly! I'll have to check this out.


Updated code command in bash (OS X) not working

I recently updated to the new version of code (0.10.10) on OS X, and I was asked to remove an existing code alias I had set up in bash. I did so by modifying my .bashrc and then allowed code to apply its own. But the new one doesn't work after restarting code and bash:
$ code
  File "<string>", line 1
    import os,sys; print os.path.realpath(sys.argv[1])
                          ^
SyntaxError: invalid syntax
/usr/local/bin/code: line 10: ./MacOS/Electron: No such file or directory

Duplicate of #3790
Workaround: open /Applications/Visual Studio Code.app/Contents/Resources/app/bin/code and change python to /usr/bin/python.


🧑💻: complete Code of Conduct todo in README

I am uncertain if there's more to do for the Code of Conduct @Marviel, if so, I'm happy to close this pull request.

Thanks for using the indicator :)


Invalid check in CheckedFile.cpp readPhysicalPage

In PR #22 - CheckedFile.cpp:
bufView_->read(page_buffer, physicalPageSize);
size_t result = physicalPageSize;

if ( result < 0 || static_cast<size_t>(result) != physicalPageSize )
{
    throw E57_EXCEPTION2(E57_ERROR_READ_FAILED, "fileName=" + fileName_ + " result=" + toString(result));
}

physicalPageSize is a constant, so result isn't a result.
(Also checking a size_t for < 0 is meaningless.)
@jean-noelp What did you mean here?

You're right, this test doesn't make sense anymore.

What if the seek right before this code fails?
Then it will set the buffer's cursorStream_ to the size of the buffer and read will start reading there...

If the seek fails, an exception will be throwed in lseek64 at the line 478.

...right.

I understand.
If you want to have explicit exceptions, I suggest you to mention throwable functions like this:
https://en.cppreference.com/w/cpp/language/except_spec

Thanks. I would prefer to go the other way and get rid of them entirely, but I'm not that invested in this code :-)


hSet command return type on node-redis: 4.0.0-rc3

Hi folks,
I noticed that when I declare the hSet command, the return type seems to be Promise<string>, however, the official Redis command docs here https://redis.io/commands/hset mention that the return type of the HSET command is an Integer Reply.
I experimented with the hSet command a bit and the return type seems to be effectively a number, which matches the number of fields that were set and matches the docs above.
My question is: Should the declared return type be updated to match the actual return type, or could it be that I'm doing something wrong?
How to reproduce:
const value = await client.hSet('key', {'field1': 'value1'});
TypeScript infers value being a string
Thanks beforehand! 🙏
Environment:

TypeScript Version: 4.4.4
Node.js Version: 16.12 | 17.0.1
Redis Server Version: 6.2.6
Node Redis Version: 4.0.0-rc3
Platform: Mac OS 10.14.6

Wow, that was fast, trick or treat! 🎃 thanks!


bug: Getting Gesture To Work with Swiping Up and Down

Bug Report
Ionic version:
[x] 4.x
Current behavior:
using gesture api, the swipe up event is being intercepted before gesture function
Expected behavior:
same behavior as swiping left to right
Steps to reproduce:

Related code:
https://codesandbox.io/s/ionic-react-gesture-7s6yd
Other information:
https://forum.ionicframework.com/t/getting-gesture-to-work-with-swiping-up-and-down/188439
Ionic info:

Ionic:

   Ionic CLI       : 6.6.0 (/Users/aaronksaunders/.nvm/versions/node/v13.5.0/lib/node_modules/@ionic/cli)
   Ionic Framework : @ionic/react 5.0.7

Capacitor:

   Capacitor CLI   : 2.0.1
   @capacitor/core : 2.0.1

Utility:

   cordova-res (update available: 0.14.0) : 0.11.0
   native-run                             : 1.0.0

System:

   NodeJS : v13.5.0 (/Users/aaronksaunders/.nvm/versions/node/v13.5.0/bin/node)
   npm    : 6.14.1
   OS     : macOS Catalina```

Thanks for the issue. Gestures default to listening only on the x-axis. Since you want to be able to swipe up and down, you should set direction: "y" when creating your gesture.

apologies... will do a better job reviewing documentation in future

No worries! Glad it's working now.


closes # 235

Added the feature of editing and deleting tasks using the voice command button.

great work
also try to edit data and priority by voice

sure ..will do so


WPF Support for Push Notifications

Describe the solution you'd like
Push Notifications for WPF applications
Describe alternatives you've considered
Currently use PubNub.
Additional context
Currently we use PubNub for WPF and App Center for our Xamarin Forms app, but would be great to use App Center for both. I think this would be a massive boost for Microsoft Developers also, for a good way to implement Push Notifications for all applications.

Thanks @winnieli1208, shame it's not in any short term plans because I think it would be a great addition, scheduled in a call so can discuss then.

@winnieli1 - I would personally like to have push notifications similar to UWP. We are starting to use it for UWP, but have applications we cannot port away from WPF. It would be nice if the users that use our WPF app on Windows 10, could get a notification for whatever reason we send out similar to that of UWP. I would also assume with .NET Core 3.0's amazing release including WPF, you may find more users that will potentially want this feature.

@james1301 @NLI-KelbyHunt Thank you very much for your feedback on App Center Push. We announced yesterday in a blog post that we’re retiring the Push service later this year and recommending customers transition to Azure Notification Hubs instead. The good news is that the same team operates both App Center Push and Azure Notification Hubs, so all customer feedback and feature requests have been transferred to the Azure Notification Hubs roadmap.

@jwargo is there a link to a feature request for Azure Notification Hubs?

@james1301 https://feedback.azure.com/forums/218849-notification-hubs


Question: Does hstring create a copy when constructing from a wchar_t?

In C++/CX, creating a Platform::String^ from wchar_t* would always create a copy since WinRT strings are immutable and are reference counted. Is this the same with C++/WinRT's hstring type or does it do something similar to Platform::StringReference?

C++/WinRT automatically uses string references (that don't copy) for string input parameters whenever possible. You can explore the implementation here:
https://github.com/microsoft/cppwinrt/blob/master/strings/base_string_input.h
Note that this is done in such a way that callers don't have to think about this optimization. You should never try to force it by using the winrt::param types directly.


Only first overlay element is being rendered

Is there an existing issue for this?

[X] I have searched the existing issues.

Is this issue related to iced?

[X] My hardware is compatible and my graphics drivers are up-to-date.

What happened?
When trying to add multiple overlay elements, it renders the only first. I took a Floating Button example and got this bug. I also tried to implement my own overlay container but got the same result. For the second overlay even doesn't call an overlay function and the layout isn't being calculated.
Iced version is 0.5, but it can't be chosen from the version dropdown list.
Screenshot:

The code:
use iced::widget::Row;
use iced::{
    widget::{Button, Column, Container},
    Element, Length, Sandbox, Settings,
};

use iced_aw::floating_element::{Anchor, FloatingElement};
use iced_aw::Badge;

fn main() -> iced::Result {
    FloatingElementExample::run(Settings::default())
}

#[derive(Debug, Clone)]
enum Message {
    ButtonPressed,
}

struct FloatingElementExample {
    lines: Vec<String>,
}

impl Sandbox for FloatingElementExample {
    type Message = Message;

    fn new() -> Self {
        FloatingElementExample { lines: Vec::new() }
    }

    fn title(&self) -> String {
        String::from("FloatingButton example")
    }

    fn update(&mut self, message: Message) {
        match message {
            Message::ButtonPressed => self.lines.push("This is a newly added line.".into()),
        }
    }

    fn view(&self) -> Element<Message> {
        let row = Row::new()
            .spacing(8)
            .push(
                FloatingElement::new(
                    Button::new("Underlay1").on_press(Message::ButtonPressed),
                    || Badge::new("Ovr1").into(),
                )
                .anchor(Anchor::NorthEast),
            )
            .push(
                FloatingElement::new(
                    Button::new("Underlay2").on_press(Message::ButtonPressed),
                    || Badge::new("Ovr2").into(),
                )
                .anchor(Anchor::NorthEast),
            );

        Container::new(Column::new().push(row))
            .width(Length::Fill)
            .height(Length::Fill)
            .padding(10)
            .center_x()
            .center_y()
            .into()
    }
}

What is the expected behavior?
I expect the all overlay elements to be rendered
Version
0.4
Operative System
Windows
Do you have any log output?
No response

I'm hitting this issue too on iced 0.5.0, iced_native 0.7.0. A quick scan of the iced_native source and I think I can maybe see the problem.
In the implementation of Widget::Overlay for Row there's a call to overlay::from_children, but looking at the source of overlay::from_children, that function's description is "Obtains the first overlay [Element] found in the given children."
This is my first time looking at iced source, so I might be missing something. Would someone who knows this area be able to sanity-check that?

I think @hecrj wrote this code and could probably clue us in.

Iced only supports one at the current moment

In case it helps anyone else, they way I worked around this was to use renderer.with_layer in my custom widget's draw function.
`
    if layout.bounds().contains(cursor_position) {
        renderer.with_layer(layout.bounds(), |r| {
            self.my_overlay.as_widget().draw(
                &state.children[1],
                r,
                theme,
                style,
                layout_children.next().unwrap(),
                cursor_position,
                viewport,
            );
        });
    }
}

`


Space after method name depending on wether it's declared or called

Is there a way to achieve the following?
export default class SomeClass {
  constructor () {
    // no space before parentheses
    this.doStuff();
  }

  // with space before parentheses
  doStuff () {
  }
}

As far as I can see it's either on or off for all.

I recommend opening a bug with https://github.com/beautify-web/js-beautify/issues
I have just updated Pretty Diff so that this is the native behavior.


feat: support for Lock-Trait

Closing to prevent outdated semantic-release commits from polluting the main branch


Fixed // FIX ME and some fixes of 'night'

Thanks for the patch! Could you also fix the tests that this change broke, as a sanity check?
The failing tests can be seen at the Travis CI link above, or here: https://travis-ci.org/darkskyapp/forecast-io-translations/builds/314975537

Tests should be fine now :)

Looks good, thanks! I'll get this merged in and it'll go live on the API during our next deploy.


The UI does not work

When I visit http://<IP_ADDRESS>:9980/ type API password and press button "Set" I'm getting an error:
"Unexpected token '<', "<!DOCTYPE "... is not valid JSON" - in chromium
"JSON.parse: unexpected character at line 1 column 1 of the JSON data" - in firefox

The UI is just a placeholder. renterd is not ready for general users yet.


drawing of text selection menu looks wrong on iOS

On iOS, when you tap on a text field, you get a segmented menu with commands for basic text options like copy, paste, and select all. This menu is rendered rendered as white on black with rounded corners and white lines to separate the segments. There is also a small downward chevron pointing at the text. The vertical white lines cut through this chevron, which is otherwise fully connected to the menu.

On Flutter, the vertical white lines stop at the chevron and the chevron is also disconnected from the menu. The horizontal gap is not quite as large as the vertical lines, which causes it to look rather "fake" (honestly, had the gaps all been the same size, I might not have noticed?...), the white lines aren't thick enough to be white (and so are being rendered as grey), and they don't cut through the chevron.

(It is also worth noting it is rather difficult to get this menu on iOS into a position where it cuts a line into the chevron location at all: Apple seems to be going out of their way to make that not happen ;P.)
The font weight also seems to be a bit different? This could be related to the discussion on #22572.
The color if you select an item (by tapping and holding for a second) is definitely a much darker grey.
(I think this component is a TextSelectionToolbar? FWIW: I'm not claiming this issue is at all priority for me, but I noticed it and I figured I could document it so that if someone ever had a chance to look at it it would be clear what was going on; and the gaps with the chevron do make the menu feel really fake.)
[✓] Flutter (Channel beta, v0.11.10, on Mac OS X 10.14 18A391, locale en-US)
    • Flutter version 0.11.10 at /Users/saurik/bin/flutter-0.9.4~b
    • Framework revision c27c4a265e (17 hours ago), 2018-11-26 17:07:24 -0500
    • Engine revision eebc6a5895
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/saurik/Library/Android/sdk
    • Android NDK at /Users/saurik/Library/Android/sdk/ndk-bundle
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.0, Build version 10A255
    • ios-deploy 2.0.0
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 29.1.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[✓] VS Code (version 1.28.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.19.0

[✓] Connected device (1 available)
    • Jay’s iPhone • [redacted] • ios • iOS 12.0

• No issues found!

#11274 looks related

To go further on what Apple seems to be doing with the position of the menu based on the behavior I'm seeing: they seem to figure out what buttons they can fit to figure out the width of the menu they want to render, and then if they have the room to do so they move the menu left/right to avoid cutting a white line through the chevron (and so the only way you can get it to actually do that is to end up in a state where the buttons it wants to render happen to be about the same width as the screen, so it will not have any leeway to move the toolbar to avoid the chevron cut).
Oh, and Flutter doesn't even seem to be rendering the chevron to point at the selected text... so you end up in situations where there what looks to be a toolbar floating over to the side pointing at something entirely unrelated to what you were trying to edit ;P. Instead, the chevron is always just pointing down from the middle of the toolbar. Even when there is room for everything, Flutter has the chevron pointing further to the left than it should be (but I think that is already documented as another issue? I can't find it now, though; it might be that I'm confusing it with another issue).

https://github.com/flutter/flutter/issues/22576 might be related

Hi @saurik
I can't reproduce this in the current dev and stable channel.

Closing this as probably fixed. Please comment below and I will reopen it.

 Complete sample code
import 'package:flutter/material.dart';

void main() => runApp(TextDemo());

class TextDemo extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
        title: 'Text Wrap Demo',
        theme: ThemeData(
          primarySwatch: Colors.deepOrange,
        ),
        home: Scaffold(
          body: Center(
            child: TextField(),
          ),
        ),
    );
  }
}

 flutter doctor -v
[✓] Flutter (Channel dev, 1.21.0-1.0.pre, on Mac OS X 10.15.5 19F101, locale
    en-AO)
    • Flutter version 1.21.0-1.0.pre at /Users/pedro/dev/SDKs/flutter_dev
    • Framework revision f25bd9c55c (9 days ago), 2020-07-14 20:26:01 -0400
    • Engine revision 99c2b3a245
    • Dart version 2.9.0 (build 2.9.0-21.0.dev 20bf2fcf56)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/pedro/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Users/pedro/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/193.6514223/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✗] Chrome - develop for the web (Cannot find Chrome executable at
    /Applications/Google Chrome.app/Contents/MacOS/google-chrome-unsafe)
    ! /Applications/Google Chrome.app/Contents/MacOS/google-chrome-unsafe is not
      executable.

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] Android Studio (version 4.0)
    • Android Studio at /Users/pedro/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/193.6514223/Android
      Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.1

[✓] Connected device (3 available)
    • AOSP on IA Emulator (mobile) • emulator-5554 • android-x86    • Android 9
      (API 28) (emulator)
    • macOS (desktop)              • macos         • darwin-x64     • Mac OS X
      10.15.5 19F101
    • Web Server (web)             • web-server    • web-javascript • Flutter
      Tools

! Doctor found issues in 1 category.


Color not changing

When I apply a color using right click and selecting a color, it displays a message:
---tab updated---
but no color is actually applied.

Same here
Windows 11, WSL
Tabs color:
Version: 0.1.34
VSCode:
Version: 1.85.1 (user setup)
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
Date: 2023-12-13T09:49:37.021Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621

@pep248 please share you vs code version and os

@OzakIOne the extension fails to activate on WSL follow this issue here #3

@OzakIOne the extension fails to activate on WSL follow this issue here #3

I tried this setting and it didn't change anything, still behaves the same as before

@pep248 please share you vs code version and os

Version: 1.85.1 (user setup)
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
Date: 2023-12-13T09:49:37.021Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621

@OzakIOne the extension fails to activate on WSL follow this issue here #3

I tried this setting and it didn't change anything, still behaves the same as before

Same here

the WSL issue remains unresolved. Please stay updated on its status by monitoring it here #3


[Android/Samung Skin ONLY] pressing camera on the chat list to send a picture, then attempting to send taken picture to a chat no longer works.

picture does not load into chat, and there is no send button

fixed


RestartNode: use /dev/shm for temp.file instead of /tmp

/tmp is not guaranteed to reside on tmpfs-type file system,
it is part of rootfs on multiple distros (CentOS, Ubuntu etc).
Resolves #325

First version of this PR is trivial replace of path in 5 locations (4 code, 1 comment).
Idea: what about using single definition and use it as variable.

/run (https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch03s15.html) is probably a better place. It's guaranteed to exist and not hold data from a previous boot. /dev/shm isn't standardized.

ok, I will change to /run. I have habit myself to use /dev/shm as it's writable by user, while /run is not. But in current case that does not matter as file is created by root, right.

Olev Kartau<EMAIL_ADDRESS>writes:

But in current case that does not matter as file is created by root,
right.

Correct.

actually, not by current code as CI faithfully notices:
touch: cannot touch '/run/delete-me': Permission denied
ssh helper scripts make login as user=clear and current code does not prepend sudo, so we run those commands as user. And /tmp was easier as it is user-writable.
We need to prepend sudo if we want to use /run

Olev Kartau<EMAIL_ADDRESS>writes:

actually, not by current code as CI faithfully notices:
touch: cannot touch '/run/delete-me': Permission denied
ssh helper scripts make login as user=clear and current code does not prepend sudo, so we run those commands as user. And /tmp was easier as it is user-writable.
We need to prepend sudo if we want to use /run

Right, let's do that.


Remove 'core' from endpoint/message/schema specs

I left the "CE Registry" stuff in the "endpoint" spec for now until we figure out where to put it. The main purpose of this PR is to get rid of the "core" stuff in each spec so people don't get confused.

Approved on the 4/4 call


Add support for querying relationship data

Add support for querying relationships using resolvers.

If I have
type Comment {
  description: String!
  userId: ID!
}

Is there a way to get the user in a graphql comment query like this?
{
  findAllComments {
    description
    user {
      name
    }
}

When I tried...
type Comment {
  description: String!
  user: User!
}

...it added user.commentId which is the inverse of what I intended.

Is there a way to get the user in a graphql comment query like this?
{
  findAllComments {
    description
    user {
      name
    }
}

Do I need to create a Comment: User resolver?

We are missing this and only creating user: Comment resolver. Need to the other way too. Thanks @richcorbs

@richcorbs Issue #209 is tracking this. Closing this.


Upgrade promtail

This PR:

adds/changes/removes etc

Checklist

[x] Update changelog in CHANGELOG.md.
[x] Make sure values.yaml and values.schema.json are valid.

@marieroque this is not a draft anymore


Adds only the main page :(

Hello!
Sait https://www.indiamed.biz
Adds only the 1 main page :(
What could be the problem? What am I doing?

All your links start with // instead of https://. While this isn't incorrect per the web specification AFAIK, I don't see why you would do such a thing as I'm pretty certain that my parser isn't the only thing that it's breaking.


PyMem_Malloc Allocator

I have run into a few issues with a similar allocator to the one added in #23 and wanted to warn you about them so you can decide to either remove it or fix it.

PyMem_(Malloc|Free) requires the GIL.
As of 3.6, interpreter shutdown causes memory allocated with PyMem_Malloc to be freed.

The issue with 1 is that it makes it hard to release the gil because any internal allocations will require the gil and it is not obvious to a consumer what can allocate.
The issue with 2 is that if you store an object at global scope whose destructor invokes PyMem_Free you will get a double free or other failure because the memory was already released.
For my application I have just switched to PyMem_Raw(Malloc|Calloc|Free) but those are wrappers around malloc|calloc|free with slightly different NULL and 0 handling. I feel bad for adding this without sufficient testing and I hope you haven't had too many issues because of this.

Hi,
Thanks for this heads up! No problem for adding this, we were at very early stage and experienced a lot of directions. We have changed our approach and now we wrap the PyArray_Object instead of a raw pointer that would communicate with python through an allocator, so we don't have this issue anymore.


can not install correctly

Hello，
Can you tell me where did you use your code covid_flights_dag.py and covid_flights_etl.py? I can not use your app with the reference you write in the README. Can you tell me more details to install your app? Thank you very much!
best regards!
GXQ

And if the Setup is only to upload the data to the S3 bucket?


Incorrect faucet links and related errors

Based on an error reported by Luke | MXC in Discord, the faucet address listed in the tutorial returns a 302 temporary redirect that doesn't process using json_pp.
Command I used:
curl -X POST "https://sidecar.staging.car/v1/debug/faucet?address=ST3MJ5JT7KH58ZB54JKEEW7E7XX4JPVKAK8RWSMG0" | json_pp

Error received:
malformed JSON string, neither array, object, number, string or atom, at character offset 0 (before "Temporary Redirect. ...") at /usr/bin/json_pp line 45.

Actual response without json_pp:
Temporary Redirect. Redirecting to ../faucets/stx?address=ST3MJ5JT7KH58ZB54JKEEW7E7XX4JPVKAK8RWSMG0

Since this is similar to the commands I've used with the BTC faucet, I tried hitting the redirect URL directly and still received an error:
curl -X POST "https://sidecar.staging.blockstack.xyz/sidecar/v1/faucets/stx?address=ST3MJ5JT7KH58ZB54JKEEW7E7XX4JPVKAK8RWSMG0" | json_pp

{
   "errorTag" : "1ef50427-cca4-440d-bc8a-5806c0a889b0",
   "stack" : "FetchError: request to http://stacks-node-follower.staging-argon.svc.cluster.local:20443/v2/fees/transfer failed, reason: connect ECONNREFUSED <IP_ADDRESS>:20443\n    at ClientRequest.<anonymous> (/app/node_modules/node-fetch/lib/index.js:1455:11)\n    at ClientRequest.emit (events.js:315:20)\n    at Socket.socketErrorListener (_http_client.js:432:9)\n    at Socket.emit (events.js:315:20)\n    at emitErrorNT (internal/streams/destroy.js:84:8)\n    at processTicksAndRejections (internal/process/task_queues.js:84:21)",
   "error" : "FetchError: request to http://stacks-node-follower.staging-argon.svc.cluster.local:20443/v2/fees/transfer failed, reason: connect ECONNREFUSED <IP_ADDRESS>:20443"
}

In the interim, I discovered that I can obtain Testnet STX tokens for a specific address by requesting it from https://testnet.blockstack.org/faucet, after following these steps: https://docs.blockstack.org/core/smart/cli-wallet-quickstart.html#getting-tokens

this was fixed now


refactor: add dependencies option

What kind of change does this PR introduce?
refactor

Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Not yet, will update docs after all refactor.
Summary
refactor schema, move dev and peerDependencies to dependencies option.

Does this PR introduce a breaking change?
Yes, dev and peerDependencies were removed in favor of dependencies.dev and dependencies.peer

Other information
No

Thanks


Add a sniff to detect git merge conflict resolution text

There's a pending PR by @david-binda for the VIP standards at https://github.com/Automattic/VIP-Coding-Standards/pull/126 that tries to detect conflict resolution text in files, e.g.
<?php
function is_prime( $n ) {
<<<<<<< HEAD
	if ( 2 === $n  ) {
		return true;
	}
=======
	if ( $n % 2 === 0 ) {
		return false;
	}
>>>>>>> branch-a
}

It might be worth merging into WPCS rather than VIPCS given its platform agnostic nature.
If the PR is good as is I can adjust the namespaces etc and create a PR to put the sniff in the WordPress ruleset, perhaps under WhiteSpace?

This might be even useful further upstream.

There is already a PR (by me) open for a sniff to do just this in PHPCS upstream: https://github.com/squizlabs/PHP_CodeSniffer/pull/1724

FYI: The upstream PR has been merged. Also see #1500.