[benchmark] Add benchmark for [AnyHashable: Any] with String keys

We don't have adequate benchmark coverage for AnyHashable. This PR adds a couple of benchmarks for the most important usecase, [AnyHashable: Any] with String keys. (An undecorated NSDictionary gets imported as such into Swift.)

@swift-ci please smoke test

@swift-ci please benchmark

Build comment file:
Performance: -O

TEST
MIN
MAX
MEAN
MAX_RSS

Added

DictionaryOfAnyHashableStrings_insert
5207
5553
5326
—

DictionaryOfAnyHashableStrings_lookup
3898
3955
3919
—

Performance: -Osize

TEST
MIN
MAX
MEAN
MAX_RSS

Added

DictionaryOfAnyHashableStrings_insert
6804
7104
6905
—

DictionaryOfAnyHashableStrings_lookup
4421
4526
4457
—

Performance: -Onone

TEST
MIN
MAX
MEAN
MAX_RSS

Added

DictionaryOfAnyHashableStrings_insert
7579
7782
7657
—

DictionaryOfAnyHashableStrings_lookup
4687
4730
4705
—

How to read the data
The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

FAIL: test_dsym (lldbsuite.test.lldbtest.TestSwiftPrivateVarReplInC)
FAIL: test_dwarf (lldbsuite.test.lldbtest.TestSwiftPrivateVarReplInC)

Hm; these failures are unrelated.

@swift-ci test

@swift-ci smoke test os x platform

@swift-ci smoke test linux platform

@lorentey Since these are new benchmarks, would you mind if I lowered the base workload on them by a factor of 10 and used the CamelCase naming convention, when I make this change? (DictionaryOfAnyHashableStringsInsert, DictionaryOfAnyHashableStringsLookup)

Feel free to change the iteration multiplier!
Please don't change the names, though -- the underscore visually separates the data structure from the operation, and merging the two components together will make it harder for me to find the particular result I'm interested in. Is there a technical reason to require camel case?

Benchmark names aren't APIs.
If anything, I'd actually prefer to name microbenchmarks directly after the member signature they test. E.g., I'd name the lookup test here something like [AnyHashable: Any].subscript(String) getter. But this may be a minority opinion. :)


Occasionally an already loaded image goes through HttpClient to load again

Hi, firstly thanks for 2.1.5 it has sped up things a lot.
I have an issue to report I've noticed before but haven't tried to find out what's going on yet. Basically this is the scenario, and note it doesn't happen all the time.

Images are loaded in a ListView (Xamarin Forms app here, testing on iOS atm)
When I click an item in the ListView, that same image is shown on the next page (detail page).
Occasionally a HTTP hit is requested to load that already downloaded image again. If I have lots of images in the ListView still loading images (or another network call is happening), there is no network thread immediately available to show that image (which is already downloaded, but sometimes FFImageLoading hits the HttpClient again).
When there is a free network thread, the image loads up, or if I go back to the ListView and then back to the detail page.

Reason I noticed a network call is sometimes (not always) made on an already downloaded image, is because authentication is needed to download my images, and I was debugging some auth stuff in my custom HttpClient, and watched this happen.
Thanks

Awesome debugging info @michaeldimoudis 👍
We will look into it

I'll close this one as here https://github.com/luberda-molinet/FFImageLoading/issues/326 are more details for the same issue.


Sync separately for each flavour of VS Code

Syncing user data should not overlap for eg, insiders should not sync with stable they should be syncing separately.

We concluded to support syncing across products (insiders, stable, web...). Recommendation for separating is to use separate accounts.


[Feature Request] A question

What is your enhancement?
Hi Team, I have a question. I am a beginner Developer and I want to use your theme in my code. I want to sell my code on codecanyon after install your theme, If my code is approved on codecanyon, I will buy you premium themes. So can I use it or not?

This is not an issue. Issues are for problems with the code.
The answer you are looking for is on the creative-tim website under "licenses".


Abide "has_many ..., primary_key" overrides in relation searches.

This will use the primary_key specified in the has_many relationship if it is defined. Otherwise, it will fall back to using the model's primary key.
This would fix https://github.com/wvanbergen/scoped_search/issues/197
I welcome feedback on this change. I'm not thrilled with the coercion of the field.relation symbol to string in the reflections lookup. And the &.options is defensive, no idea if the options hash is always defined or not, or there is a way that the field.relation wouldn't be listed in the reflections.
Anyhow, at least this is a starting point to discuss the feature.

The changes look fine. Could we get a test for it?

I'd love to provide one, but ran into difficulties with this project's test
suite, something having to do with postgres dependencies that I don't have,
and haven't had time to track down. Also, I have no familiarity with rspec.
Given the ticket and the toy example I hope I've given enough context that
someone more familiar with this project might craft a test for it with
relative ease.
On Tue, Aug 4, 2020 at 10:12 AM Adam Růžička<EMAIL_ADDRESS>wrote:

The changes look fine. Could we get a test for it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wvanbergen/scoped_search/pull/198#issuecomment-668620873,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAONGMWONOA4JBONFM4GQDR7AJOBANCNFSM4POCVHPQ
.

Would you mind pulling this in https://github.com/andynu/scoped_search/pull/1 ?

I;ll deal with the failing tests tomorrow

I opened https://github.com/wvanbergen/scoped_search/pull/199 to handle the failing tests, thank you for your contribution @andynu !


Updating k8s deps to v1.31

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Takes care of #3340, #3337, and #3336
Does this PR introduce a user-facing change?:
Updates Kubernetes dependencies to v1.31

/lgtm


unstable results

Describe the bug
I try to migrate naive-ui test from jest to vitest
now I can run pnpm test for every single component and won't get error
but If i run pnpm test  for the whole project will get V8 error
#
# Fatal error in , line 0
# Check failed: result.second.
#
#
#
#FailureMessage Object: 000000F96E0FE360
 1: 00007FF687FE7B7F v8::internal::CodeObjectRegistry::~CodeObjectRegistry+114079
 2: 00007FF687F025AF std::basic_ostream<char,std::char_traits<char> >::operator<<+65023
 3: 00007FF688BE2772 V8_Fatal+162
 4: 00007FF68864DAED v8::internal::BackingStore::Reallocate+637
 5: 00007FF688897269 v8::ArrayBuffer::GetBackingStore+137
 6: 00007FF687E33C6D std::vector<v8::internal::compiler::MoveOperands * ptr64,v8::internal::ZoneAllocator<v8::internal::compiler::MoveOperands * ptr64> >::empty+92797
 7: 00007FF687F9021E v8::internal::Malloced::operator delete+5118
 8: 00007FF688865C76 v8::internal::Builtins::code_handle+172790
 9: 00007FF688865869 v8::internal::Builtins::code_handle+171753
10: 00007FF688865B2C v8::internal::Builtins::code_handle+172460
11: 00007FF688865990 v8::internal::Builtins::code_handle+172048
12: 00007FF688939091 v8::internal::SetupIsolateDelegate::SetupHeap+494673
13: 000002836E23AE4B

if I run pnpm test:update for the whole project it won't get error

on my friend m1 pro max mbp run all test for the project it sometimes pass sometimes  V8 error
the results is so Inconsistent.
I think there are something wrong with tiny pool.
and on the ci It will report a error
Serialized Error: {
  "errors": [
    [AssertionError: expected "spy" to be called at least once],
  ],
}

https://github.com/TuSimple/naive-ui/runs/7710271807?check_suite_focus=true
It's too confusing so I try to looking for help.
Reproduction
https://github.com/Sepush/naive-ui/tree/vi
System Info
System:
    OS: Windows 10 10.0.19045
    CPU: (8) x64 Intel(R) Core(TM) i7-4720HQ CPU @ 2.60GHz
    Memory: 833.58 MB / 7.89 GB
  Binaries:
    Node: 16.14.0 - ~\AppData\Local\fnm_multishells\6948_1659584657685\node.EXE
    Yarn: 1.22.15 - ~\AppData\Local\fnm_multishells\6948_1659584657685\yarn.CMD
    npm: 8.3.1 - ~\AppData\Local\fnm_multishells\6948_1659584657685\npm.CMD
  Browsers:
    Chrome: 103.0.5060.134
    Edge: Spartan (44.19041.1266.0), Chromium (103.0.1264.77)
  npmPackages:
    vitest: ^0.20.3 => 0.20.3

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Duplicate of https://github.com/vitest-dev/vitest/issues/1191

Duplicate of #1191

for the crash it's duplicate.
but how about the error have in ci but did not happen when I run test for every single component on my computer.
It made me unable to debug for this.

@sheremet-va I use node 18.7.0 on my computer It works all test pass
but on the ci still get an error and did not figure out Which test file test case failed
It's hard to debug I think this is something need improve
https://github.com/TuSimple/naive-ui/runs/7710763851?check_suite_focus=true

but on the ci still get an error and did not figure out Which test file test case failed

Next version will show full stack trace.


Example is missing type information

Hello!
The provided example is missing any type information from function arguments. The documentation also doesn't provide any type declaration examples.
What is the purpose of using TypeScript without specifying the types? 🤔

@slavafomin PR with improvement is welcome


【Advise】get app version

I knew tidevice can replace parts of libimobiledevice now,but I wish I can get app version by tidevice.
ideviceinstaller can get CFBundleIdentifier CFBundleShortVersionString and CFBundleVersion
I wish I can use command to get them,look like
tidevice applist --json

tidevice appinfo com.apple.Preferences --json

thanks!


python310Packages.scmrepo: 0.1.1 -> 0.1.2

Description of changes
https://github.com/iterative/scmrepo/releases/tag/0.1.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 196914 run on x86_64-linux 1

4 packages built:

dvc
dvc-with-remotes
python310Packages.scmrepo
python39Packages.scmrepo


Make open_browser take AsRef, add open_path function

Since open_browser is the underlying implementation of open, I think making it provide an AsRef<OsStr> interface is acceptable (per the previous PR). However, open by default will only take AsRef<str>, while the new function, open_path, will only accept AsRef<Path>.
With regards to tests, is there anything in particular you would like to see? Would it be appropriate to add a simple test file and have all supported systems try to open this file?

Closing this without merge, for the following reasons:

I'd already mentioned earlier in #35 that the APIs cannot be based on OsStr. They have to based on str, as we can guarantee conversion from str to OsStr, but not vice versa. This PR does not adhere to that request.
While I was open to adding an open_path earlier, I realise upon thinking more deeply that the behaviour is going to be inconsistent. In some situations with the default browser, this will open up a file browsing application instead of the browser. As such, I'd like to wait for more feedback on it from the users before taking a call on it, as making future modifications to public facing APIs is a nightmare.
My current thought on AsRef after a bunch of research, is to not include it, and keep it as &str. I've documented the reasons here


Add support for multiple adapters

Fixes #76

@percyfal great job! Would it be possible to add an option for the users to choose between Illumina and Nextera (I guess those are the most common)? I remove Nextera adapters with Cutadapt like this:
cutadapt -a CTGTCTCTTATA --minimum-length 30 -o BC-0302374998.raw__raw_reads.merged.trimmed.fastq.gz BC-0302374998.raw__raw_reads.merged.fastq.gz -j 80

Could there be a mix of adapters in a project? One way of doing this could be to add boolean configuration options for illumina and nextera, e.g. illumina_adapter and nextera_adapter, and let the list defined above be a list of whatever adapter sequences the user wants to supply to the workflow. How does that sound?

Yes, this sounds good! I would set "illumina_adapter" by default and mention it in the documentation and give the users an option to switch to "nextera_adapter" if they want, or add their own adapter sequences

@LeandroRitter Ok I updated the PR. Now adapters are defined in the adapters configuration section, with the following defaults:
adapters:
  illumina: true
  nextera: false
  custom: []

Custom adapters can be defined in adapters:custom. I was hesitant to organize it this way because it is an inconsistent mix of booleans and a list of strings; what do you think? Please make sure to read the update docs to verify you understand what I mean.


DBZ-6762 Add "validate filters" endpoint/s for connector-specific Connect REST Extensions

closes to https://issues.redhat.com/browse/DBZ-6762

My overall feeling is that we are creating yet another layer of validation (although I do see the difference compared to what we have -- the UI needs the validation result of our config fields to be exposed).  Maybe we should take a step back and consolidate the validation before we start exposing it to the UI

Another point for mongo specifically. Mongo is dynamic by nature. Collection doesn't have to exists before it's written to (so non existing collection is existentially equal to an empty collection). Though I'm note sure if I understand the code properly in order to know how relevant this is.

@rk3rn3r Thanks for the PR. It is a good start. I've one major comment though. I sense a really strong overlap with *SnapshotChangeEventSource classes. In both cases you are bilding and filtering the same set of tables (in fact not fully as the snapshot event source can add additional filtering). So maybe in that case should not be the logic merged and maybe moved to JdbcConnection? I suppose the same is for MongoDB. In that case (even if it was mentioned by @jcechace above there is potentional for removal) I'd say that MongoDbConnection could provide the same service?

@jcechace

the UI needs the validation result of our config fields to be exposed

What do you mean with our validation result?  The REST extension only calls Connector#validate() for the related connector (the REST extension does not have its own validation). Still, it needs to bring the results into a structured format that can be consistently returned to the UI / REST caller. That's what the classes in io.debezium.rest package in debezium-core are meant for. Those are the data models used to represent the schema for the UI endpoint. I think it's a good idea to decouple those models from the implementation like TableId. wdyt?
Should that package for models io.debezium.rest be renamed to io.debezium.rest.models to make it clearer?

@jcechace

the UI needs the validation result of our config fields to be exposed

What do you mean with our validation result? The REST extension only calls Connector#validate() for the related connector (the REST extension does not have its own validation). Still, it needs to bring the results into a structured format that can be consistently returned to the UI / REST caller. That's what the classes in io.debezium.rest package in debezium-core are meant for. Those are the data models used to represent the schema for the UI endpoint. I think it's a good idea to decouple those models from the implementation like TableId. wdyt? Should that package for models io.debezium.rest be renamed to io.debezium.rest.models to make it clearer?

Sorry for not being clear (had a bit of a hard time wrapping my head around it)... Yes, I more or less meant what you described. So it does make sense!
My point was that maybe we should provide more universal validation "framework"/api and use its bits where needed -- it seems a bit disintegrated at the moment. However that is definitively something which we can revisit in the future and something I might be wrong about as it's mostly based on feelings and impressions.

@jcechace

My point was that maybe we should provide more universal validation "framework"/api and use its bits where needed

Maybe we need something like this sooner or later for Debezium Server if we are going to replace usage of Kafka's ConfigDef and the related validation. I would then use whatever comes here eventually. I would personally not do this here. What do other think? Do we need a task for Debezium Server and should we add a comment to this one to reuse it here? Did you had plans for such a thing @jpechane  @Naros ? How should we proceed with that?

@jcechace

My point was that maybe we should provide more universal validation "framework"/api and use its bits where needed

Maybe we need something like this sooner or later for Debezium Server if we are going to replace usage of Kafka's ConfigDef and the related validation. I would then use whatever comes here eventually. I would personally not do this here. What do other think? Do we need a task for Debezium Server and should we add a comment to this one to reuse it here? Did you had plans for such a thing @jpechane @Naros ? How should we proceed with that?

Definitively agree. It is not something to be done as part of this PR.

Maybe we need something like this sooner or later for Debezium Server if we are going to replace usage of Kafka's ConfigDef and the related validation. I would then use whatever comes here eventually. I would personally not do this here. What do other think? Do we need a task for Debezium Server and should we add a comment to this one to reuse it here? Did you had plans for such a thing @jpechane @Naros ? How should we proceed with that?

This entire validation hook is very rigid, particularly if we want to avoid constructing any connector config object in that method.  For databases like Oracle and MySQL, there are particular details from the connector's configuration beyond just the username, password, host, and port details that are mandatory to create a connection, and trying to strike the right balance here feels extremely limiting with our current class design.
For example, in MySQL, I need to construct a ConnectorAdapter to get the correct implementation of the new AbstractConnectorConnection class that the validation should use; this requires looking at a plethora of the configuration values and constructing the adapter hierarchy that makes these bits accessible. Creating the adapter also means building other objects the connector uses to deviate behavior between MySQL, MariaDB, and their related drivers.
I'm unsure of the right path forward in this context. Still, we need to be flexible here to allow for adequate design patterns required for such connectors to keep the overall code for connection management clean and avoid multiple code paths that could lead to inconsistencies.

@Naros regarding your last comment: Did you maybe miss a detail about the validation? The new code does no new / custom validation it only calls Connector#validate(), the rest is entirely left to the related connector class instance.
Your concerns about the connection, I think with the previous agreement to file a Jira to include the filtering code inside the connector implementations will solve the issue mid-term. Short-term I assume a MySqlConnectorConfig/MySqlConnection (and etc for the other connectors) does the required things depending on the provided config and acts more like a builder for concrete Config-/Connection-classes for MariaDB, etc. I think we are talking about a kind of internal API for those *ConnectorConfig/*Connection classes that's defined by the current implementation and could evolve from there?

Did you maybe miss a detail about the validation? The new code does no new / custom validation it only calls Connector#validate(), the rest is entirely left to the related connector class instance.

I was referring more to our discussion I believe in the weekly meeting where we discussed the regex concerns with that the various connector config classes validate and my understanding was you didn't want to construct something like a MySqlConnectorConfig in the validate method for that reason; perhaps I misunderstood the conversation?

Another point, why not instead of bending the current implementation with that ConnectorAdapter, why not creating separate connector classes (and maybe modules) that have shared parent classes (or better compose with a class that provides the shared code)?

I believe that would have been a much larger and disruptive change over the adapter pattern, and I wanted to avoid any potential risks to the MySQL implementation.  I also believe that the adapter pattern provides a much clearer picture for code deviations.  For example, even the new AbstractConnectorConnection class I made was way more disruptive than I wanted, but it was unfortunately necessary.  I believe what you're asking would have been more along that scale.
And if I were to be honest, I rarely see massive refactors end well.  You end up being a bull in a china shop, everything stays broken for extended periods of time and you can't do any type of test-driven design with that methodology.  That may work for others, but in my experience it's not the safe route when you want to preserve compatibility.

@jpechane @jcechace I applied the changes that we discussed. I hope that addresses most of your concerns.
I will now finish the conditions for the Oracle DB container image types together with @Naros in a quick call now and I hope that we then can merge the PR soon?

I tested the Oracle REST Extension tests with the -xs and the -noncdb containers too and all tests were green locally.

/packit test

/packit test

@rk3rn3r Applied, thanks


Updating the types used for volumes,networks and more

This should fix the unmarshal issue reported
https://github.com/rancher/migration-tools/issues/6

@rawmind0 @alena1108 can you review


60: Add error logic for delimiter

The parsing of date and version will not fail given a wrong delimiter, and it will display an error in the case of of using the wrong character
fixes: #60

@z-merge it


Recognize cookies set by redirect

When a redirect response arrives, the browser will recognize
Set-Cookie headers the same as any other request/response. This PR
enables the Redirector to correctly follow the cookie hand-offs.
I encountered this situation out in the wild. This PR, as-is, seems to
fix the issue. I haven't bothered to find the relevant spec.

Ah, there's still a problem with this — the cookies set by redirects still aren't set in the final response object. Gonna need a bit more work

A bit of sleuthing shows this behavior is implemented by all major browsers, so it seems like we should support it: https://blog.dubbelboer.com/2012/11/25/302-cookie.html

Looks like some unrelated rubocop failures. I thought we had rubocop pinned to prevent that...

@tarcieri This is ready now, as far as I'm concerned. Let me know if anything needs fixing

@tkellogg some rubocop failures

I think these are fixed by the rubocop update?

Aah nope, oh well. #718 fixes them

I have some plans of removing redirector as is, and introducing session object instead. Session will be a http client wrapper that will hold cookies. This PR has these lines:
      # I wish we could just do @response.cookes = cookie_jar
      cookie_jar.each do |cookie|
        @response.cookies.add(cookie)
      end

I believe this is wrong and comes from the idea of using redirector as a session. The response should not hold cookie jar of previous requests.

A Session type to encapsulate this state would be great. See also #306.


Add support for user, workdir, and env docker parameters

Changes proposed in this PR

Add support for workdir, env, and docker parameters

Why are we making these changes?
Increase support for the existing mesos API

Will merge when green


Cache results

@standaniels, thanks for this but I think we should try and make caching optional/configurable?
Also, I just remember the caching on Laravel 4.2 version and one problem I encounter is that the results/count does not update when a new record was inserted. When using cache, then we should also add some code to unset it somewhere. Maybe we can try something like:
$datatables->of($model)
  ->cache('datatable.key', 'duration')
  ->make();

This way we can unset the cache since we know the key to use and caching will only be triggered when cache method was called. This will also help us avoid a possible breaking changes. Thanks!

Thanks for your feedback! You're right, I haven't thought of that because our CMS already clears the cache when modifying models. Making caching optional is also a great idea.
Will be continued... :)

Please re-submit PR if possible. Thanks!

Hello, if it interests you I tried to make a custom EloquentEngine for caching queries 👍
https://github.com/curunoir/rememberabledatatables
I inspired myself from Dwight Watson package : https://github.com/dwightwatson/rememberable


Remove deprecation warnings from Ruby 2.7 when running rspec

@jeppester A quick search turned up no reported issues in those gems regarding keyword parameters. So maybe we are using them in the wrong way.

@jeppester A quick search turned up no reported issues in those gems regarding keyword parameters. So maybe we are using them in the wrong way.

The latest gem updates in main seems to have cleared the warnings.

The latest gem updates in main seems to have cleared the warnings.

Great! :+1:


Is there an api related to canvasToPixel and pixelToCanvas?

Is there an api related to canvasToPixel and pixelToCanvas?

There is a imageToWorld and reverse, and viewports keep the canvasToWorld and reverse as well

Thank you. Because of your answer, my problem has been solved.


docs: add next verse

Steps 4 to 6 don't seem to work anymore, or I'm just blind lol

Ahoy, @p3rception!
Thank you for bringing this up. It seems that in order to assign reviewers (steps 4-6 in the YOLO guide), you need to have Collaborator permissions. The invitation has already been sent to you, please try again after joining. Also, any help in improving the guide is appreciated.
Welcome aboard! 🚢

Thank you mate, it worked now. Maybe the detail of being Collaborator should be added to the README to avoid confusion in the future!


drivers: gpio: nrf5: Add support for port P1 in nRF52840 SoC

Added support for GPIO Port P1 in nRF52840 SoC.
Signed-off-by: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>

@mike-scott @carlescufi @anangl tested button sample on nRF52840 (pin 11 with "GPIO_0" and "GPIO_1").

I understand there are some review comments that need to be addressed, however, tested this patch w/ analyzer hooked up to 6 different pins.   Works as expected w/ P1 GPIOs.

@mike-scott Thank you for testing (just not able to get back to this PR due to other priorities), is this in any way blocking you?

@cvinayak: not blocking me.  Take your time with this. :)

No idea how I got 3 comments that were the same at the end of this review :/

LGTM. Just some minor comments.

@anangl addressed your two comments.


Restore context more cleanly.

see individual commits

closing, because on linux, h_free on a node causes a crash.
will see if I can fix halloc and if not, will just let the node leak for now.

Closing per last comment, and we're going to try a different approach.


feat(weave): Add NotDiamond integration

This PR added to resolve CI checks.
See original PR:
https://github.com/wandb/weave/pull/2544

Branch acompa/a9-nd-weave has been updated - if tests don't run on #2544 you can pull that branch into here again.

Ok unit tests look good, now running the examples e2e.
I'm getting this error when running the first step in your readme:
API error: 401. Could not find valid API key
ND API error. Falling back to default provider=openai/gpt-4o.

It seems to happen even when I don't import weave.  I'm doing pip install --upgrade  notdiamond[create]

Ok unit tests look good, now running the examples e2e @acompa
I'm getting this error when running the first step in your readme:
API error: 401. Could not find valid API key
ND API error. Falling back to default provider=openai/gpt-4o.

It seems to happen even when I don't import weave.  I'm doing pip install --upgrade  notdiamond[create]

Ok unit tests look good, now running the examples e2e @acompa
I'm getting this error when running the first step in your readme:
API error: 401. Could not find valid API key
ND API error. Falling back to default provider=openai/gpt-4o.

It seems to happen even when I don't import weave. I'm doing pip install --upgrade notdiamond[create]

I noticed you created a Not Diamond API key today - are you also setting it in your environment as NOTDIAMOND_API_KEY? I didn't document this step, update incoming.

Yes, I tried setting:

os.environ
Using the .env
Passing NotDiamond(api_key="sk...")

Yes, I tried setting:

os.environ
Using the .env
Passing NotDiamond(api_key="sk...")

I just confirmed that this worked in two fresh Python interpreters with

os.environ + client = NotDiamond(), and
client = NotDiamond(api_key='sk...')

Note that I had to set the env var before importing notdiamond - we have a silly bug that only checks the env when you've imported the module, and not at any point after.
Can you please try again with a fresh interpreter and virtualenv, and lmk?

Yep, same thing:
I'm doing:
uv venv -p 3.12 notdiamond
source notdiamond/bin/activate
uv pip install notdiamond -e ~/repos/weave
python script.py

# script.py
import os

os.environ["NOTDIAMOND_API_KEY"] = "sk-..."

from notdiamond import NotDiamond

client = NotDiamond()
session_id, provider = client.chat.completions.model_select(
    messages=[
        {"role": "system", "content": "You are a helpful assistant."},
        {"role": "user", "content": "Concisely explain merge sort."},
    ],
    model=["openai/gpt-4o", "anthropic/claude-3-5-sonnet-20240620"],
)

I've run this again locally and have been unable to reproduce. After creating the uv env and running the script I receive a recommendation; when I delete the API key from my script I see
API error: 401. Could not find valid API key
ND API error. Falling back to default provider=openai/gpt-4o.
Best model: openai/gpt-4o
Session ID: NO-SESSION-ID

which is our standard SDK behavior for an invalid API key.
On Friday afternoon I published a new version of the package which resolved a dependency issue, and that might've caused the error you encountered. Could you please try one more time by installing notdiamond==0.3.20?

Ok, seems to be working for me now.  Adding comments as I go

@acompa ok overall looks good.  I think with a few polish edits mentioned above, we should be good to merge!  Thanks again for your contrib!

Thanks for your review @andrewtruong!
In the original PR, I've added a helper method to obtain EvaluationResults from an Evaluation, since (I believe - not certain!) no instance methods would actually return these rows. For example, I can pair up prompts with answers and scores from the eval rows to help users train their own custom routers with Not Diamond.
Happy to remove this change or pull it into a separate PR if you'd prefer. I haven't auto-traced the new method, either, so that tests do not need to change, but if you'd prefer tracing then I'd only have to update the call items in

tests/trace/test_evaluations.py::test_basic_evaluation and
tests/trace/test_evaluations.py::test_evaluation_data_topology

cc @jamie-rasmussen for viz before merging

@acompa all in this PR is fine, just make sure that:

The value props for the examples are clear
The examples work and are tested

Please cleanup the cassettes to reduce unneeded captured network traffic

Thanks @tssweeney. I bootstrapped my tests from your integration docs before your team recently updated the contribution guidelines. Happy to adjust these cassettes.
I don't see a vcr_config defined anywhere, so I reused (and slightly edited) the pytest-recording decorator in your Langchain tests:
@pytest.mark.vcr(
    filter_headers=["authorization"],
    allowed_hosts=["api.wandb.ai", "localhost", "trace.wandb.ai"],
)
def test_notdiamond_quickstart(
    client: WeaveClient,
) -> None:
    ...

But this seems to capture calls to api.wandb.ai anyway?

Working on fixes for both linting and py3.9 failures now, will update #2544 shortly.

I've fixed the py3.9 failures on a9-nd-weave but cannot reproduce the lint failures locally.

@acompa looks like your test_train_router is failing on py310-12.  Does pass for you locally with nox -e "tests-3.12(shard='notdiamond')" (and 3.10, 3.11)?

@acompa looks like your test_train_router is failing on py310-12. Does it pass for you locally with nox -e "tests-3.12(shard='notdiamond')" (and 3.10, 3.11)?

Thanks @andrewtruong. I was caught out by an issue related to this. The default request header Accept-Encoding changed from py3.9 to py3.10+, and pytest-recording would save different responses. If I rewrote cassettes using py3.9, these py3.10+ tests would fail. Vice versa, too.
I've fixed this by adding decode_compressed_responses=True to pytest.mark.vcr. If you encounter this across other Weave tests, enabling this setting at the project level might help.

Thanks, looks good!  @tssweeney are you good with the changes here?


[Bug] Scrollbar not visible on ohif viewer

Describe the Bug
The studies viewer in the OHIF Viewer is displaying an empty scrollbar and failing to load studies properly.
Steps to Reproduce
Steps to Reproduce:
Access the studies viewer section.
Observe the scrollbar area.
Note how studies are loading or failing to load.

The current behavior
The scrollbar appears empty, and studies are not loading as expected.
The expected behavior
The scrollbar should display relevant content and studies should load dcm files.
OS
windows
Node version
NA
Browser
chrome, edge

What is your server, this might be related to the thumbnails not appearing that is discussed in the FAQ https://docs.ohif.org/faq#viewer-opens-but-does-not-show-any-thumbnails

It happens on Azure Dicom Service. We are using DicomWeb to integrate Ohifv3. Ohifv2 is working fine.
Disabling wildcard in app.config.js worked. Thanks a lot

@alphacentauridigital yay


Memory leaks after initializing this extension

Tested with Slicer 4.10.1:
When this extension is installed, simply starting Slicer which initializes the extension and then immediately closing Slicer results in the following leaks:
vtkDebugLeaks has detected LEAKS!
Class "vtkMatrix3x3" has 1 instance still around.
Class "vtkMatrix4x4" has 1 instance still around.
Class "vtkDoubleArray" has 1 instance still around.
Class "class vtkBuffer<double>" has 1 instance still around.

These are the members of vtkMRMLVideoCameraNode
I will investigate. They are set to nullptr on ~vtkMRMLVideoCameraNode()  but perhaps there's a dangling reference to a vtkMRMLVideoCameraNode

Potentially in ~qMRMLVideoCameraIntrinsicsWidget adding a set null

Nope...

Building debug :(

Yep, those pesky leaks! Thanks for looking into it

I have no idea....

@adamrankin If you suspect https://github.com/VASST/SlicerVideoCameras/commit/a3f6bc07242d6d10076231ae278af38dbd3c54f9 will also work on Slicer 4.10.1 and not just Slicer Nightly, can you push the commit to your "4.10" branch in this repo?


Improve JsonPath performance

We're now evaluating JSON Path in our product. These commits begin work on improving the performance in path parsing and some of the basic queries (I've not started on expressions just yet). This follows the same general strategies in my other commits:

Reduce allocations
Reduce string allocations
Remove hot-path LINQ queries

Only one behavioral change of note would be in parsing exponents: I now allow '+' along with '-' for the sign character (for correctness).

Also for your review: https://github.com/sixlettervariables/Manatee.Json/pull/1
That PR builds upon this PR and adds unary negation support to JSON Path expressions. I had to change the parser to use the Shunting-yard Algorithm to translate the infix expressions into the expression tree. Also, constant values with a negation operation are folded into negated constants rather than remain as negation operation nodes.

With both PR's applied:
// * Summary *

BenchmarkDotNet=v0.10.11, OS=Windows 7 SP1 (6.1.7601.0)
Processor=Intel Xeon CPU E5-2620 v3 2.40GHzIntel Xeon CPU E5-2620 v3 2.40GHz, ProcessorCount=24
Frequency=2338369 Hz, Resolution=427.6485 ns, Timer=TSC
  [Host]     : .NET Framework 4.7 (CLR 4.0.30319.42000), 64bit RyuJIT-v4.7.2114.0
  DefaultJob : .NET Framework 4.7 (CLR 4.0.30319.42000), 64bit RyuJIT-v4.7.2114.0

                     Method |      Mean |     Error |    StdDev |   Gen 0 |  Gen 1 | Allocated |
--------------------------- |----------:|----------:|----------:|--------:|-------:|----------:|
             JsonPathParser | 174.60 us | 4.8220 us | 14.220 us |  5.1270 |      - |  32.26 KB |
    JsonPathParser_Evaluate | 130.00 us | 5.0740 us | 14.800 us | 22.9492 |      - | 142.49 KB |
          NewJsonPathParser |  50.02 us | 1.5675 us |  4.622 us |  2.2583 | 0.0610 |  14.28 KB |
 NewJsonPathParser_Evaluate |  26.64 us | 0.8311 us |  2.438 us |  1.8311 |      - |  11.42 KB |

Approximate 3.5x speedup for parsing, and 2.26x reduction in memory allocated.
Approximate 4.9x speedup for evaluation, and 12.5x reduction in memory allocated.

@sixlettervariables thanks.  Please go ahead and merge that other one into this, and I'll pull them both into the branch.
I'm continually impressed by the improvements just by unLINQing everything.  I thought it was supposed to be just as fast.

I've merged in my work to support unary minus. It does fix the ambiguity with subtraction. I added some unit tests to cover those cases.

As for LINQ and speed, it certainly can be. However, once a LINQ statement ends up on the hot path, sometimes the lambda allocations can really pull down the performance. My preference usually is to start with LINQ and back them out when profiling indicates it is the bottleneck.

I noticed in ConstantBooleanExpressionParser it no longer accounts for invalid values that start with 't'/'f' (e.g. trut or falsf).


How to implement shuffle and repeatmode functionality with this example

Hi,
  How do you get exoplayer object from service to set repeatmode and shuffle functionality.

You don't. You use the transport controls to do it. For example: transportControls.setRepeatMode(PlaybackStateCompat.REPEAT_MODE_ALL)
If you use this project, you can see how that works.

Do ExoPlayer automatically handles repeatMode and shuffleMode with help of MediaSessionConnector ?

Yes it does. It's passed through the MediaSessionConnector and handled by the class DefaultPlaybackController. There it just sets Player.setRepeatMode and Player.setShuffleModeEnabled respectively. (So it depends on setting up a Timeline in ExoPlayer.)

Then how UI will be updated , ie. how i can show Currently Shuffle mode is enabled or disabled ?


opt normalize column name of output file

when do export to output file, normalize column name.
For example

SELECT 1 > 2 INTO OUTFILE "..."

the column name of 1 > 2 will be __greater_than_0

run buildall


[Fix Request] Having an Invalid smallImageKey causes both the largeImage and smallImage to not display

While working on an App including DiscordRPC, I noticed that with an Invalid Key for the Small Image, itll fail to display the large and small Image, when It should only cause the Small Image to stop working.
Referenced Issue: https://github.com/MinnDevelopment/java-discord-rpc/issues/26

ACK on this issue. Don't have an ETA for a fix as this is below other things in priority, but I'll see if I can do something quick or if this is more involved 👍

Good news! Just merged a fix for this. Should roll to various clients within a day or two. An invalid small image key should no longer block the large image.
Note that if you send a bad large image, artwork will not display, as the small image will have nothing to anchor to.

Thanks so much :)


Spacebar acting as page down instead of space.

In every browser I use this extension on, I cannot use the spacebar. Even the official bing search website. The extension continues this issue. It seems like when the page is loading up either in the extension or otherwise, focus has it's priority set to default as the page instead of the chatbox- no amount of clicking changes that. Chrome, Brave, Opera, Vivali, Edge- every one.

Do you mean you cannot use the space bar? I can use the space bar, as shown in the image.


Question | Improvement

Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

[x] I have read the wiki page and cheat sheet, but there is no information I need.
[x] I have searched in existing issues, but did not find a same one.
[ ] I want to report a problem instead of asking a question. It'd better to use kingfisher tag in Stack Overflow to ask a question.

Issue Description
According to WWDC 2018 Session 416

Start or keep using UIGraphicsImageRenderer instead of UIGraphicsBeginImageContextWithOptions since iOS 10 due to couple of reasons
UIImage is expensive for sizing and to resizing, recommended use downsampling

For the first one, there may be a chance to re-implement func draw(cgImage: CGImage?, to size: CGSize, draw: ()->()) -> Image in Image.swift
As the second. I saw many complain about Kingfisher could be cause crash when deal with large image. If we use downsampling to load large image's thumbnail directly, instead of decode whole image then resize to target size, it may reduce those situations. Should be complete by changing implementation of ResizingImageProcessor 's process function when generate image using raw data.
These are just my thoughts, correct me if I was wrong.

@cuzv Yes, thanks for the suggestion.
There are quite a few of legacy code in Kingfisher and there is indeed a lot of space to improve. Currently, Kingfisher supports from iOS 8.0. We may have to drop it and 9.0 if you want to adapt to UIGraphicsImageRenderer. We could use some compilation condition to support both, but it also causes some inconsistency between iOS versions, which is not quite desired now. Maybe we could consider to drop iOS 8 and 9 after iOS 12 comes out!
For the downsampling with ImageIO, I totally agree that we could reimplement the ResizingImageProcessor to save memory. Any chance to give a PR for it? Since I am not quite easy to find some time for this. :[ (But feel free to say no!)
Thanks!

@onevcat Thanks for your reply.
I'm so glad you agree with me. Would love to support downsampling feature when it's ready.

We just finished adding a downsampling step to our Kingfisher render pipeline in order to save memory (also inspired by some of the sessions from WWDC). In doing so, we were able to keep our app's memory usage below an acceptable threshold consistently when viewing many large images.
However, it did require a bit more customization than expected, since you need to try and prevent Kingfisher from ever allocating a full image buffer for large images (as that image buffer's memory footprint is exactly what we're trying to avoid) , and by default Kingfisher will do this on both when an image is downloaded and when it is serialized from the disk cache. Caching was also a bit of an issue, since we never want to fully serialize and cache the original image as a UIImage - instead, we only want to cache downsampled versions of the original image.
In any case, getting it to work involved using a custom ImageProcessor both in the render phase and also in a custom CacheSerializer, and also using separate caches for original files (on disk) and downsampled images (in memory). The final option set looks like this:
// will render the image downsampled to the given dimension
let dimension = max(size.width, size.height)
let cacheSerializer = DownsamplingImageCacheSerializer(dimension)

let options: KingfisherOptionsInfo =  [
    .targetCache(memoryCache),
    .originalCache(originalCache),
    .cacheOriginalImage,
    .cacheSerializer(cacheSerializer),
    .processor(cacheSerializer.pipeline) // share the render pipeline from the serializer
]

I'd be happy to try and contribute some of this work back into Kingfisher, but I'm not quite sure how to slot it into the library, since our implementation is more like a custom configuration of the library, and not something that would lend itself to a single custom type or processing step. @onevcat any thoughts or suggestions on that? Let me know if I'm missing some obvious step that would have made this work a bit easier! Also, thanks for making the library so open to customization 👍

@worthbak
Wow, great work!
It make sense that you need some additional steps to make it work. However, I have a question on the cache side, especially the necessity of separating targetCache and originalCache.
If you set .cacheOriginalImage on, Kingfisher will in fact cache both the downsampled one by the processor, as well as the original one. But as you said, "since we never want to fully serialize and cache the original image as a UIImage - instead, we only want to cache downsampled versions of the original image". So maybe we don't want/need the .cacheOriginalImage at all? Otherwise it would make Kingfisher to store the original image.
And it is a bit strange to me to pass a cacheSerializer.pipeline as a processor. I think it would be more reasonable to be a DownsamplingImageProcessor instead, and the sharing part of downsampling cache serializer and processor could be extracted to a third type like DownsamplingPipline or so.
If we could understand whether indeed we need separated caches or not, we could decide whether we need to provide a "bundled option" for downsampling. It would make it easier for users who want to adopt it, instead of creating the correct options following documentation.

@onevcat thanks for the feedback! The main reason we want to try and cache the original image is that, for our purposes, we download a large original, and then reuse that image in various places / sizes in our app. So it’s not quite good enough to only cache the downsampled versions, since we’d have to fetch the original over and over.
One detail I didn’t mention was the limits we set on the caches - we try to lock the originals cache to only store on-disk (so that it only deals in Data, not UIImage), and lock the memory cache (for downsampled images) to memory only:
ImageCache.memoryCache.maxMemoryCost = 20 * 1024 * 1024
ImageCache.memoryCache.maxDiskCacheSize = 1

ImageCache.originalCache.maxMemoryCost = 1
ImageCache.originalCache.maxDiskCacheSize = 100 * 1024 * 1024

The desired effect here is to a) ensure that the originals are always cached (as Data), and b) try to never make a UIImage from the original data. While this seems to work ok, a better solution might be to add a .cacheOnlyData option to ImageCache, wherein it would only stick the Data blobs for the original images into the memory or disk cache, but still keep them around for serialization into a downsampled version. Instead of locking the originals cache to disk-only, it would just know to only store Data in memory or on disk. Does that make sense?
As far as the cache serializer goes, that makes sense, and is kinda what we’re doing already - we need to ensure that the original image being serialized from the disk cache goes directly into its downsampled form, and not into its full-res form. As such, we simply share the downsampling code from the processor, which for us meant sharing the pipeline code (and only initializing one pipeline). Open to suggestions on that front.
If you like that .cacheOnlyData option I mentioned, I can get to work on a PR for that - IIRC, the NSCache used by ImageCache is typed as AnyObject, so it shouldn’t be a ton of work (no need for a separate managed cache or anything). Let me know!
Sent with GitHawk

@worthbak Any chance you could share the updates you did to include the new downsampling suggestions from Apple into Kingfisher? Starting that process now on my project and would be awesome to see what has been done before.

Downsampling processor was implemented in Kingfisher 5. The UIGraphicsImageRenderer requires more work and there is a plan for it in the future.
And now, ImageCache has a method to accept store raw data to disk.
Since most of the discussion was done, and the left things are on my ToDo list, I close this issue for now.


[Backport - Newton] MaaS: Add Service Checks for Swift Processes

Adds service checks for Swift processes.
Connects rcbops/u-suk-dev#1215
Also cherry-picks 7543e70

recheck_ceph
22:06:16  failed: [jrancp-81-10374] (item={u'cinder_vg_name': u'cinder-volumes', u'group': u'cinder_volume', u'name': u'cinder_vg_check'}) => {"item": {"cinder_vg_name": "cinder-volumes", "group": "cinder_volume", "name": "cinder_vg_check"}, "msg": "Failed to connect to the host via ssh.", "unreachable": true}


CtD: Not showing bipartite network

From Ctd activity today in a workshop. Using data downloaded from here http://bit.ly/creativedatarestaurants  into an Excel sheet and uploaded to CtD. It only shows communities and not bipartite nature of data. perhaps not a bug and it's because the data is not super interconnected but worth investigating

This is not showing bipartite graph because the data was not interconnected


Add trigger extras install option

For frameworks we don't directly support here (yet), this provides users with an option to install all trigger dependencies only. This will allow consumers to use vulnpy.trigger modules directly without installing any particular framework dependencies.

OSSAR needs to update its set-env. This shouldn't block the merge:
https://github.com/github/ossar-action/issues/16


[Saya] Configuration file

Saya was introduced in this #1495.
As Saya will grow, the configuration will become more complex as Saya have those components:

Data availability layers, where a node URL + some custom configuration may apply.
Prover configuration.
Verifier and settlement layer configuration.

This issues aims at providing an alternative solution to initialize Saya with bunch of CLI arguments.
The format for this file may be JSON, inspired from what was done for the genesis file of Katana.
{
  "data_availability": {
    "celestia": {
      "node_url": "https://...",
      "auth_token": "ecYk....",
      "namespace": "mynm",
    }
  },
  "prover": {
    "sharp": {
      "service_url": "https://....",
      "token": "....",
    }
  },
}

To enable the use of this configuration file, an option should be added in the Saya binary bin/saya/args.

@glihm please assign this issue to me. Thanks.

@glihm I think we can close this. Thanks for your help on the PR and feedback.


Generate tasks.json taxonomy from huggingface_hub

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Ok recomputed the json file, this should be ready to review now! @lhoestq

Note: the generated JSON from hf/hub-docs can be found in the output of a GitHub Action run on that repo, for instance in https://github.com/huggingface/hub-docs/runs/6006686983?check_suite_focus=true
(click on "Run export-tasks script")

Should we not add the tasks with hideInDatasets?

thanks to the both of you!


Next execution address should be highlighted

The next address to be executed should be highlighted white.  Past implementations were highlighting the previously executed address but this is incorrect.  Imaging the situation when you are debugging code in an IDE.  The debugger will highlight the line of code which is about to be executed, not the line of code that has just been executed.
Currently I don't think this is possible to implement as the next execution address is not provided from the  core library so we will probably need to introduce a new message to cater for this....

A NEXT_EXECUTION message is published by the core library each step to indicate the next address to be executed and the executing warrior id (and data).  We should be able to use this information to highlight the correct cell.

Should be resolved by #248

Agreed, resolved


Error installing the custom plugins

Summary
I tried to install the custom plugins https://docs.konghq.com/hub/revolution_systems/upstream-auth-basic/
But when implementing to route it return Not Found
Steps To Reproduce

Install the plugin luarocks install kong-plugin-upstream-auth-basic

Configure kong.conf file
custom_plugins = .upstream-auth-basic

Restart Kong

Enabling Plugin on Route

curl -X POST http://kong:8001/routes/{route}/plugins \
    --data "name=upstream-auth-basic"  \
    --data "config.username=admin" \
    --data "config.password=admin"

Additional Details & Logs
Returned:
{"message":"Not found"}

Kong version ($ kong version)
Kong debug-level startup logs ($ kong start --vv)
Kong error logs (<KONG_PREFIX>/logs/error.log)
Kong configuration (the output of a GET request to Kong's Admin port - see
https://docs.konghq.com/latest/admin-api/#retrieve-node-information)
Operating system

That's an old plugin, judging from the compatible versions.
in recent versions custom_plugins changed to plugins; see https://github.com/Kong/kong/blob/master/kong.conf.default#L75
add plugins=bundled,upstream-auth-basic instead

Hi @Tieske , Thanks for the updated documents for kong.conf file it's work smoothly.. But finally I used the Request Transformer Based on my question here #5899
Thanks,


Add a Dockerfile and fix relative path

Adding a Dockerfile for easier server setup

Handles all the dependencies
Can be pulled directly from Dockerhub or built locally

Fix path require. This breaks the docker build because the original
require looks up the path to ./server which impies that you're running
it out of the repo. In the case of Docker, the server code is running in
it's own directory, which won't be named 'server'

Example of running docker:
docker run -p 53:53/udp -it --rm mpercival/dnscat2 ruby ./dnscat2.rb foo.org
or building from source
cd dnscat2/server
docker build -t dnscat2 .
docker run -p 53:53/udp -it --rm dnscat2 ruby ./dnscat2.rb foo.org

This would also simplify #78


HelloDirectML crashed

Hi,
When change this line from
    dml::Expression output = dml::Identity(input);

to some thing like this
    dml::Expression output = dml::Identity(input)+dml::Identity(input);

and compiled with USE_DMLX, the executable will crash with device removed error. How does this happen? Many thanks!

This is not a crash. The sample code simply throws when directml fails with an error code. The subsequent device removal is not a hardware device removal but a part of an unhandled exception unwind when the app exits on failure.
What causes directml to fail is that the operator initializer receives a buffer binding for a temporary resource that it doesn't need. The change in the graph causes that situation to happen, and to accommodate it, the sample will need to change the way it binds a temporary resource at initialize accordingly. Also note that the change introduces an additional graph input, while both inputs still point to the same input index 0, which could also cause an unexpected result.

Hi @wchao1115 I've tried this file This time the executable does not abort. But the output tensor is all 0, not the expected 3.24.

Hi @wchao1115 I've tried this file. This time the executable does not abort. But the output tensor is all 0, not the expected 3.24.

This is what I meant by Also note that the change introduces an additional graph input, while both inputs still point to the same input index 0, which could also cause an unexpected result.
The PR doesn't aim to make this sample suitable for any graph you throw at it. It just tightens the binding logic for the operator initializer. If you change the graph, you need to examine the subsequent binding logic to accommodate the new graph.


Reference Window + References

References are short audio clips that contain a bird vocalization / audio event segment

Such as the audio being produced from Jacob's 2d cross correlation pipeline

Create a window that contains serval Reference elements. Each reference element is a wavesurfer tool that basically queries the backend for all the needed audio files (which for point of reference, is going to be a random clip I hardcode until I actually make a full backend system for it). It doesn't need regions, only to play an audio clip and possibly display the spectrogram
The window basically creates serval references and it hangs out on the side

An really rough draft for what I am envisioning

refrence code here: https://github.com/UCSD-E4E/Pyrenote/tree/refrence-audio


Replace unmaintained uglify-es with terser

Resolves #69
/cc @stefanpenner @rwjblue @fabiosantoscode @boris-petrov

is this a minor version release? or..

yes, I'd say so. from what I understand it should be fully compatible.


IPsec VTI interface name is linked to IKE Phase 1 Description, Interface settings not operable

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[-] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[-] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
For IPsec VTI ("routed") interfaces, the interface name/descrption can't be edited in the usual place (the name just jumps back to the previous one upon save). Instead, the name is linked to the Descriton field in the IKE2 Phase 1.
To Reproduce
Steps to reproduce the behavior:

Try to rename the interface/description of a "routed" VTI interface

Expected behavior
The description field to work in the interace edit form.
Describe alternatives you considered
Change the descrption in the Phase 1 edit form.
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 21.7-amd64
FreeBSD 12.1-RELEASE-p19-HBSD
OpenSSL 1.1.1k 25 Mar 2021

The description is used as interface label, renaming might cause errors. Better to delete the P1 and set it up again

Can't confirm deleting is needed, as changing the description in the P1 works fine here. It is at the interface level where it becomes confusing, just at UI level. At this point I think greying out the description on VTI interfaces while adding a note about this inheritance from P1 is a perfectly good solution to this.


Fix cirq.Circuit._has_unitary_ false positives

Was returning True when there were non-unitary non-measurement operations in the circuit
Also did some reformating
Now using cirq.decompose to extract unitary gates from circuits

Automerge done.


api: Migrate /update-subscription-settings response value.

Migrates the /update-subscription-settings api endpoint to the ignored_parameters_unsupported model, which is also currently used by /update-settings and update-realm-user-settings-defaults.
Previously the /update-subscription-settings endpoint returned a copy of the data object sent in the request. This change is a step towards preparing for an eventual migration to have all endpoints return an ignored_parameters_unsupported block.
Fixes #15307. Follow-up from #20332.
Questions for reviewers:

There are now 3 views (realm.py, user_settings.py and streams.py with almost identical code for generating the ignored parameters. Keeping in mind that there's an eventual plan to have an ignored parameters block returned in all endpoints, does it make sense to write/have a function that these 3 views (and potentially more) can import / share? If so, where would that best be located?

Unlike the other endpoints using the ignored parameters model, this endpoint takes an object array as it's sole parameter. Does it make sense to have this endpoint function more like other updates to settings? Having the stream_id and property as parameters?

Testing plan: Added a test to test_subs.py to confirm that the ignored_parameters_unsupported is returned if and when the supported parameter is also in the request. Manually tested in dev environment confirming the response as expected in the network tab of dev tools.

There are now 3 views (realm.py, user_settings.py and streams.py with almost identical code for generating the ignored parameters. Keeping in mind that there's an eventual plan to have an ignored parameters block returned in all endpoints, does it make sense to write/have a function that these 3 views (and potentially more) can import / share? If so, where would that best be located?

This is probably a good discussion topic for #backend; I think it needs a bit of discussion.  Ideally the middleware or json_success type methods would take care of this, but there's a bundle of complexity around how json_success doesn't receive the HttpRequest object that it'd need to add this itself, and it returns an HttpResponse response that is already not easily mutable/extensible.  I suspect the right fix will be to change the signature to json_success(request, ...), so that the code for this can live inside json_success and have access to the data we attach to the HttpRequest object (technically the associated RequestNotes object that we get from the request) in zerver/lib/request.py about which fields we've used.
I'll start a thread.

Started: https://chat.zulip.org/#narrow/stream/3-backend/topic/ignored_parameters_unsupported/near/1286694

I posted one comment; otherwise this change lgtm.
On the object array question: I think the answer is yes but it may be a bit of a migration to get there.  I think it's useful to have a way to do a bulk update, and it's OK to leave this endpoint as a legacy mechanism for that.
I also notice we have a different endpoint that has the URL structure one would expect for a more normal Zulip interface for patching an object, the second item here:
    rest_path("users/me/subscriptions/properties", POST=update_subscription_properties_backend),
    rest_path("users/me/subscriptions/<int:stream_id>", PATCH=update_subscriptions_property),

It appears to be undocumented and not used by clients, so I think the right path forward is to first fix its API which has a property/value pair that it receives (and doesn't directly validate the types for) rather than supporting changing multiple fields of an object at the same time like our other settings endpoints:
@has_request_variables
def update_subscriptions_property(
    request: HttpRequest,
    user_profile: UserProfile,
    stream_id: int = REQ(json_validator=check_int),
    property: str = REQ(),
    value: str = REQ(),
) -> HttpResponse:
    subscription_data = [{"property": property, "stream_id": stream_id, "value": value}]
    return update_subscription_properties_backend(
        request, user_profile, subscription_data=subscription_data
    )

And then once we've changed that (and documented it), we can work on shifting clients away from the update_subscription_properties_backend endpoint, relabel it to have _bulk in its name in the documentation, etc.
Does that seem like a good path forward?

I saw the PATCH=update_subscriptions_property endpoint when I was looking through the codebase for this PR and wondered about whether it was used or not. I think your plan makes a lot of sense.
And I'll keep an eye on the backend discussion thread. I did notice in zerver/lib/request.py there is an ignored_parameters set in the RequestNotes class. But it doesn't seem like anything has been done with it yet.

These are the same thing -- if you read the block of code we just copied here, what it does is read RequestNotes and copy the values from that to ignored_parameters_unsupported in the response.
(For background, RequestNotes is a class that has a 1:1 mapping with HttpRequest objects that is basically our way to add additional state associated with Django HttpRequest without forking or monkey-patching Django).  I hope the comments in the RequestNotes class definition file explain how it works if you're curious -- if they aren't clear, we should figure out a way to extend them to fix that :).

Merged after a few tweaks to the API documentation phrasing.  In particular, I got worried that the "Changes" entry was a bit misleading, so I added a changelog for which places we've added this field to responses.

We may want to do something else but that's kinda pending a decision on how we want to encode this sort of thing in a shared parameter description.  And realistically, our next goals should probably be (1) to do the refactor that'd make it possible to have all endpoints include this feature, and (2) to work to replace this endpoint with an improved version of update_subscriptions_property.
Thanks @laurynmm!


Disabling showing deleted cookies does not hide number instantly

Describe the Bug/Feature
When I deactivate the corresponding option, this number still stays there…

…until I reload a tab. Then this tab does not have this number anymore. However, I have to reload all tabs to hide it in all tabs, …
Steps for anyone to reproduce the bug

Open some tags.
Change setting.
Save.
Switch to another tab. –> number still there

Your settings

OS/version: Linux
Browser/version: Firefox 55
Cookie AutoDelete version: 1.4.0

Don't think this should be automatically done since some people have 500+ and reloading ALL of them would be annoying. Also you don't want to automatically reload if the user has a tab with filled forms.

Indeed, don't reload. Just change the icon. :smiley:

Still, it's not feasible to just loop through through all the tabs to do simple things.
I looked into this and I would have to call

browser.tabs.query() - which from my understanding does a loop internally to get all the tabs
browserAction.setBadgeText() - for all those tabs in another loop

Okay, so what is preventing you from doing that?
I think it would be a mayor limitation if WebExtensions cannot do this, so I think it is certainly possible in some way or other.

Performance for people with so many tabs. (Down the line this may be a non issue but for right now since not everyone is in e10s mode, it still a concern)
https://www.reddit.com/r/firefox/comments/6ud1vt/a_simple_extension_is_not_so_simple/
Another thing is uBlock Origin doesn't do "automatic actions" either like in Show the number of blocked requests on the icon or when you change actions in the popup, it doesn't automatically reload.

Okay, that sounds good, because with Firefox 57 you can then fix this issue, as at the latest e10s is activated there.

Can't you update it just for the current tab? And when the tab is switched, you may update it for the "new" one, too.

It would probably cause unnecessary "checking" every time you switch tabs.


PVox Weapon Pickup Sound Bug

As stated before but is fixed, with another bug, it allows manual pick up which was fixed previous but a new issue has occured. The weapon pickup sound made by PVox is made when walking over a tool or weapon.

What branch are you on? And do you have any other add ons that are not manual pickup, that you think could conflicting? That's super weird and I'll look at it. Do send a link to whatever addon you're having issues with

If you want to look at my collection to see what addons I have, here.  I currently play on the x86-64 branch, and I dont think I dont have any conflicts with PVox as of now.

I currently can not reproduce this bug in my game.

Does this just happen with the base game and "Manual Pickup" active?

UPDATE I have been able to reproduce the bug and am working on a fix now.

Fixed! Thanks for reporting.

What was it that caused it?

It was an entire compatibility issue within PVox. When checking for pickups (in the player's area) VManip Manual Pickup would deny the request, but PVox still saw it as a valid run therefore it still tried to play the pickup_weapon action. The fix was to instead run the hook once before running the PVox one, and checking if there's nothing trying to deny the pickup. _1 is the variable which prevents the PVox hook from running infinitely.
https://github.com/kdgonz7/ImmPVox/blob/09e3757f8975348946cd35399ced7fe45babfc2d/lua/autorun/playervox.lua#L1211-L1218

(It says PlayerCanPickupItem, but same applies to weapons. This fix also added item pickup sounds)


Enhanced weekly and monthly views to show small details based on resource colors.

More clarity to be provided.

No further action needed.


Set cifmw_update_containers_edpm_image_url for NFV VA

As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] README in the role
[x] Content of the docs/source is reflecting the changes

recheck

/lgtm
/approve
Tested downstream on nfv job.


FTP setting

Please add info on the "FTP state" dropdown menu available under Platform settings.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e25899c-1ed8-7cfc-2c37-73bb010a87f0
Version Independent ID: 8b366c42-43f8-d5eb-b619-b356e75a9916
Content: Configure apps in the portal - Azure App Service
Content Source: articles/app-service/configure-common.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

At least a link to here:
https://docs.microsoft.com/en-us/azure/app-service/deploy-ftp#enforce-ftps

@dcbrown16 , I wanted to understand more on this request. Are you looking for information on FTP state like FTPS etc. in the documentation?

@DashleenBhandari-MSFT
This doc has the following section describing the Platform settings, but it doesn't mention the "FTP state" setting at all.
"Platform settings: Lets you configure settings for the hosting platform, including: "...
This document should go over all of the possible settings, including "FTP state".

@dcbrown16 , ok noted. I will check and update the documentation.

@dcbrown16 , We will be including this change in the document and this should be completed by next week. Please let me know if I can close the issue for now.

@DashleenBhandari-MSFT sure, thanks for checking this!


Add FanRadiator from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of kunedo, to add FanRadiator to CKAN.
Mod details:
name = /mod/2020/FanRadiator
author = kunedo
abstract = Radiator with animation and sound.
license = GNU GPL
Homepage =
description = FAN RADIATOR
Radiator with animation and sound.
Please direct questions about this pull request to kunedo.

This was added in #6871.


Can this be used with Next.Js

Is it possible to use mdx-deck with next.js?  Or is this a stand alone project?

mdx-deck is tied heavily into Gatsby. In fact, if you look at packages/mdx-deck/index.js, it's just exporting @mdx-deck/gatsby-plugin:
https://github.com/jxnblk/mdx-deck/blob/08b1ca4673cd448a3552e9f003bdd4bda2c80268/packages/mdx-deck/index.js#L4


Components

Make components that will be in use for every page based on the guide for both computer and mobile
When you start on one of these componants, you can make the componant into an separate issue(click the issue tag in the top right corner of the section) and assign yourself to the new issue

[ ] #27 - Katarina
Logo: Edugate should have a logo that reflects academic themes (e.g., books, graduation cap, etc.) and conveys professionalism. It should be simple, modern, and scalable.
Icons: Use clean, minimalist icons for navigation, actions, and user roles (e.g., a book icon for results, a person icon for profile). Keep the icons monochrome to match the primary color palette and ensure they are easily recognizable.

[ ] #33
Structure: A sticky top bar with the logo on the left, followed by page links (Home, Results, Profile, etc.), and a profile dropdown on the right.
Hover Effects: Underline animation with the primary color on hover.
Active State: Bold text with a thicker underline in the primary color.

[ ] #34
Sections: Home, Results Management, User Management, School Management, Settings, and Logout.
Icons: Each section should have a matching icon for visual clarity.
Expand/Collapse: Include an option to collapse the sidebar on smaller screens.

[x] #28
Primary Button:
Background: #4CAF50 (primary color)
Text: White (#FFFFFF)
Hover: Darker shade of primary (#388E3C)
Border Radius: 6px
Padding: 10px 20px
Secondary Button:
Outline style with secondary color border (#2196F3) and text
Hover: Light secondary color background (#BBDEFB)
Alert Button (for delete actions):
Background: Accent color (#FF5722)
Text: White
Hover: Darker shade of accent color (#E64A19)

[ ] #35
Controls for tables, such as results or user lists, for better navigation across large datasets.
Style: Primary color for active pages, gray for inactive.

[ ] #36
Show loading animations where there are delayed results or data fetching.
Spinner: Uses primary color for smooth, modern animation.
Progress Bar: Linear, in primary color with a light gray background.

the link directly to style guide:
https://github.com/kristinatonnessen/edu-gate-norway-spruce/blob/develop/docs/Style-Guide.md

When you are done with your issue, please check off your paragraph, and the last one to check off theirs can move the issue over to "in review" 😄 @Foadosman @Janicke92 @KatRan2104 @Anne-Zwift @barumski

I'm still a bit confused. On the stylesheet it's not mentioned anything about borders on the primary or alert buttons.
It's only mentioned "outlined" border on the secondary button. Altså the border radius is only mentioned on the primary button.
I did what the scrum master and QA suggested and added border and border radius on all of them.
Please tell me if something should be changed.


Opening file for writing should have mode="w" or "w+"

Hi
If i am not mistaken, this very repository contains python tesstrain package that is installed via pip install tesstrain. If not, please disregard this issue.
I have installed tesstrain==0.1.2 and have an issue running the command, namely
FileNotFoundError: [Errno 2] No such file or directory: 'path/to/output_dir/eng.training_files.txt
This is due to this line: https://github.com/stefan6419846/tesstrain_package/blob/main/tesstrain/generate.py#L379
 with open(lstm_list, encoding="utf-8", newline="\n") as fd:
        fd.write("\n".join(dir_listing))

as can be seen, here the output file is opened for reading only, which is the default mode for opening files (https://docs.python.org/3.10/library/functions.html#open).
In the other repository, this line uses correct mode correct: https://github.com/tesseract-ocr/tesstrain/blob/main/src/tesstrain/generate.py#L375
with pathlib.Path(lstm_list).open(mode="w", encoding="utf-8", newline="\n") as f:
        f.write("\n".join(dir_listing))

Can it be fixed and published to pypy?
It would be nice to sync two repositories: this one and what is in https://github.com/tesseract-ocr/tesstrain/src or delete one of them to remove confusion.

thanks in advance!
BR, Nikolai

Thanks for the report. When I removed the useless cast to a pathlib.Path, I apparently missed the mode parameter. Unfortunately, I did not yet feel the urge to add corresponding unit/integration tests which most likely would have caught this.

If i am not mistaken, this very repository contains python tesstrain package that is installed via pip install tesstrain.

This is correct.

Can it be fixed and published to pypy?

I have pushed a fix and will try to push the package to PyPI tomorrow as well. In the meantime, version 0.1.1 (only tagged on PyPI) should work as well, except that it has no type hints.

It would be nice to sync two repositories: this one and what is in https://github.com/tesseract-ocr/tesstrain/src or delete one of them to remove confusion.

As mentioned in the About section, my repository basically contains a standalone copy/fork of the original code. I converted the standalone code to a real package back then as I wanted to use the training code as a library - this is what you will find in the upstream repository as well. As some of the supporting tools for OCR tend to not receive much love/support, I decided to publish a package myself I was already maintaining internally anyway and speed up incorporating fixes/improvements. For now, no one appeared to really care about it.

Hi Stefan,
Thanks for the prompt reply and fix!


ZookeeperCuratorLockProvider and lockAtLeastFor property

Property lockAtLeastFor is not supported by ZookeeperCuratorLockProvider. This is not so clear and explicit in the documentation!
Could be useful to highlight this in the README.md file.
But.. is there any chance to have this feature available also for Zookeeper?
Is there any problem or technical reason why it is not implemented?
Thanks

Hi, thanks for feedback. I have updated the documentation. I'd like to implement the feature, but I do not know how yet. Will  think about it.

This should do it https://github.com/lukas-krecan/ShedLock/pull/141

Released as 2.5.0


typo

Select spps to target specific services by your policy.
should be:
Select apps to target specific services by your policy.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 625bb1b2-81fd-9804-c0b5-3cd2904decd9
Version Independent ID: e4468b05-200e-24ae-75e9-29fb2b3a6ddc
Content: What are conditions in Azure Active Directory conditional access?
Content Source: articles/active-directory/conditional-access/conditions.md
Service: active-directory
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@benpaul4u
Thanks for the feedback! We are currently investigating and will update you shortly.

@benpaul4u The PR for the fix has been created and it will be merged soon. Thanks again for pointing this out, I am closing the issue based on this update, please let us know if there is something else that we can help you with.


Update to use ES6 module syntax

Support webpack, rollup, and code splitting.

[ ] assets
[ ] core
[ ] gameLoop
[ ] keyboard
[ ] plugin
[ ] pointer
[ ] pool
[ ] quadtree
[ ] sprite
[ ] spriteSheet
[ ] store
[ ] tileEngine

I'd like to help out with this, but haven't done this stuff before. Perhaps you could get one done and I can use it to mimic on some others.

Sounds great. The main problem is I've been trying to learn how tree shaking works. As the code is now, it's not very tree shakable so you get the entire library when you do some things. Things like adding event listeners on keyboard and pointer events in the main scope cause lots of problems.
The only thing I've been able to find is moving those things to their own functions that either the user has to call, like an init function but for keyboard, pointer, assets, etc., or doing some creative code refactoring to make sure those things are auto inited when the user calls the standard functions. So when a user calls the bind or pressed functions of keyboard, the keyboard events are setup at that point instead of before (which means the first call will always fail since there's no events set up).
I'm not really excited about either of these options but I'm not really finding anything else that can be done to make the code tree shaking friendly (which is mostly the entire reason to move to es6 module imports IMO).

Alright, so I think I found a compromise that will work (or will have to work). I've pushed my current workings to the es6Modules branch. I have currently done:

animation
core
events
gameLoop
keys

If you look at keys.js, I have to export the init function that adds the event listeners. Anyone who imports any function from that file will just have call the init function themselves since I can't find any way to to do it for them while still removing it from tree shaking if it's not imported.
import { initKeys, pressed } from 'kontra'

initKeys();
if (pressed('a'), () => {
  // a key pressed
});

However, in kontra.defaults.js, I add the init function to the kontra object, and then can test to see i that function exists inside the main init function of core.js, and if it does I can call it there. That will auto init the keyboard listener for anyone who imports the entire library or downloads the generated output of the entire library.
import kontra from 'kontra';

kontra.init();  // this will also call the keys init function now

My Guidelines so far
The general approach I'm currently taking is to extract all the objects (keys, assets, pointer, etc.) and just make them export their functions. Then inside kontra.defaults.js construct the objects with their functions to maintain the current API. That way you can import just the functions needed from those files and let tree shaking remove the rest.
I've also tried to make all the constructor functions (sprite, animation, vector, etc.) Classes where it makes sense. There are some things (like the gameLoop) where the amount of private variables would just bloat the code with so many this references that it's noticeably smaller to leave it as is. For any Class, I've exported the factory function wrapper (so you don't have to call new) and added the Class as the prototype to the function.
Lastly, I have a test file in examples/test.js that I run rollup on and edit as I go to see how the output out.js looks. This lets me test things and make sure I'm not doing something that breaks tree shaking. Mostly what I've found is that accessing any global object/function, chaining functions, or using any imported variables/functions at the top scope will cause a side effect and break tree shaking. That's why in assets.js the canUse object was turned into a function since it needed access to a global Audio call and chained the result.
Anyway, that's a lot to take in and this is still a lot of trial and error. Hopefully this works for the rest of the code.

As I work with the pointer code, I'm wondering if I should flatten the kontra object so there are no keys, pointer, etc. sub-objects. The reason for this is that the functions exported by both of these don't make much sense out of context. Pointer has pressed, onUp, onDown, over, trackanduntrack. Keys has pressed, bind, and unbind. These functions aren't very clear what they are doing out of the context of the keysandpointer` objects if you were to import them by themselves
// what exactly is onDown and over doing? hard to know without the `pointer` context from before
import { onDown, over } from 'kontra';

This would mean I would move the pointer and keys context to the function names themselves and just have them be off the kontra object directly. This gives two advantages that I see:

There is 1:1 parity between function name and kontra function. Instead of having kontra.keys.pressed be one function but keyPressed be the function you have to import, it would just always be keyPressed.
The exported function names make more sense when imported. onDown isn't very specific but onPointerDown is.

I already have to rename the two pressed functions to be keyPressed and pointerPressed, so I might as well do the same for the rest of the functions.

You might not have noticed that this change makes binding "space" doesn't work any more, now it's " ".

Ya... I wanted to use event.code so it'd be space but it's not widely supported. We could go back to keycodes, but the building up of it would have to move to the init function as well (can't loop over the object and add properties in the main scope)

keys doesn't seem so hard, couldn't you give it an let initialized = false variable and on the first line of bindKeys and keyPressed add if (!initialized) initKeys()

Is it possible to put a on('init', initKeys()) somewhere, like pointer used to do.

https://github.com/straker/kontra/pull/66 works for me.


Typescript Errors

I see a typescript warning on 'field' and 'props' for the following:
               <Field name="owner" validate={required('Please enter your name.')}>             {(field, props) => (
I tried setting to the following but still get an error:
field:FieldStore, props:FieldElementProps
What am I doing wrong?
Thanks

Does required<string>('Please enter your name.') fix it?

It is the 's child function that throws Typscript warnings:
field:FieldStore, props:FieldElementProps

I need more of your code or a reproduction on Stackblitz. What framework are you using?

Feel free to create a reproduction using this template: https://stackblitz.com/edit/modular-forms-solid?file=src%2Froutes%2Flogin.tsx

I'll have to investigate further since some components do not show the Typescript warning, but some do.  It may have to do with the <Form element being in a separate component instead of in the same component as the <Field elements.  I have a component to render the start of the <Form, and then another component which renders the <Field components.


Separate CSS for Recommend page

Related Issue
Css for Book Recommended Page written in separate file
Fixes:  #1493
Description

Type of PR

[x] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
Checklist:

[x] I have made this change from my own.
[x] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@Maheshwari-Love please resolve the conflicts

@RitiChandak conflicts resolved


Crash in instance_eval and instance_exec

The following input demonstrates a crash:
instance_eval { super &0 }

This issue was reported by https://hackerone.com/d4nny
I noticed that the following also crashes:
instance_exec { super &0 }

And the following don't behave as expected. In MRI they result in "super called outside of method" but in MRuby the results are different:
$ bin/mirb
mirb - Embeddable Interactive Ruby Shell

> instance_eval { super 0 }
(mirb):1: expected String (TypeError)
> instance_exec { super 0 }
(mirb):2: no block given (ArgumentError)

Will be fixed.  instance_eval can take a string argument where instance_exec cannot. That's the reason they raise different exceptions.


[iOS]In some cases, some font sytle are different from others in Chinese

My users in my app report some strange cases within some unknown situations some font styles of some Chinese characters are different from others. Unfortunately, I haven't reproduced step.
Here are some features I have found so far.

Only a few Chinese characters have problems in sentences.
Restart  cellphone maybe recover (not 100% recover).
Use the ios system keyboard.

the font of characters '来'  is different from others.

the font of characters '歉'  is different from others.
But when the user restarted the phone or a few days later problem recovered automatically.

Hello @xiaoxiaowesley. Can you provide a minimal, reproducible example and the output of flutter doctor -v?

flutter doctor -v?

flutter doctor -v
[✓] Flutter (Channel unknown, 2.5.4-0.0.pre.52, on macOS 12.3.1 21E258
darwin-x64, locale zh-Hans-CN)
• Flutter version 2.5.4-0.0.pre.52 at
/Users/xiaoxiang/Documents/code/flutter/flutter253
• Upstream repository unknown
• Framework revision fb193e8f35 (2 个月前), 2022-03-23 14:24:20 +0800
• Engine revision d175d70d28
• Dart version 2.14.4
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at /Users/xiaoxiang/Library/Android/sdk
• Platform android-31, build-tools 31.0.0
• ANDROID_HOME = /Users/xiaoxiang/Library/Android/sdk
• Java binary at: /Applications/Android
Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
1.8.0_242-release-1644-b3-6915495)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 13.3.1, Build version 13E500a
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 4.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build
1.8.0_242-release-1644-b3-6915495)
[✓] IntelliJ IDEA Ultimate Edition (version 2020.1)
• IntelliJ at /Applications/IntelliJ IDEA.app
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
[✓] VS Code (version 1.67.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.40.0
[✓] Connected device (3 available)
• RoyChan 的 iPhone (mobile) • 9f4880651c05ea08146eeb2d66408def76cdceee • ios
• iOS 14.3 18C66
• iPhone (mobile)           • 00008020-000954E136A1002E                • ios
• iOS 14.6 18F72
• Chrome (web)              • chrome                                   •
web-javascript • Google Chrome 102.0.5005.61
! Error: RoyChan 的 iPhone is busy: Fetching debug symbols for RoyChan 的
iPhone. Xcode will continue when RoyChan 的 iPhone is finished. (code -10)

Hello @xiaoxiaowesley. Can you provide a minimal, reproducible example and the output of flutter doctor -v?

Sorry for that I can't reproduce it because It's reported from my user. I was wondering if anyone in the community had a similar problem.

Hello @xiaoxiaowesley. I've noticed that you're running an older version of Flutter Channel unknown, 2.5.4-0.0.pre.52. Please upgrade to the latest version and confirm if the behavior persists.
If it does, we would need a reproducible sample, without which we cannot really proceed. It could be specific to exact text or a device and without a reproducible example, we won't be able to understand the issue.


New version: CUDA_Runtime_jll v0.2.0+0

Autogenerated JLL package registration

Registering JLL package CUDA_Runtime_jll.jl
Repository: https://github.com/JuliaBinaryWrappers/CUDA_Runtime_jll.jl
Version: v0.2.0+0
Commit: e827464e4798018619ad34f11e5b3a27bbbf57cc
Revision on Yggdrasil: https://github.com/JuliaPackaging/Yggdrasil/commit/f91719b5c1a2d681ca1a7b9507b013ebe874f9d3
Created by: @maleadt

┌ Error: Dependency "CUDA_Driver" does not have a compat entry that has an upper bound
└ @ RegistryCI.AutoMerge ~/.julia/packages/RegistryCI/78Rh8/src/AutoMerge/guidelines.jl:134

┌ Info: If this is a JLL package, only deps are Pkg, Libdl, and other JLL packages
│   meets_this_guideline = false
└   message = "JLL packages are only allowed to depend on Pkg, Libdl, Artifacts, JLLWrappers, LazyArtifacts, TOML, MPIPreferences and other JLL packages"

Wait, why? That's so arbitrary...


resolves #37 limits the script to only accessing the current document

resolves #37

@evbacher  Could you please confirm that this is correct?

Ok thanks I will try to publish the addon later tonight (UTC +2)

@evbacher It should be OK. For the record, the publishing process is very confusing and not straightforward at all!
Could you please confirm that the new version is published? It should be version 15.
Thanks.

I installed your addon and the new permission is in effect. Thanks!
I agree -- the new publishing process took me a while to figure out too. Once you get the URL to the G Suite Marketplace (https://console.cloud.google.com/apis/api/appsmarket-component.googleapis.com/overview) then add your project ID, you can update the description with the Publish item, and the version with the Configuration item.

Excellent news!
Indeed, once you get that URL it's OK 👍


Main.storyboard: error: IB Designables: Failed to render and update auto layout status for ViewController (BYZ-38-t0r): dlopen(SkyFloatingLabelTextField.framework, 1): no suitable image found.  Did find: 	SkyFloatingLabelTextField.framework: required code signature missing for 'SkyFloatingLabelTextField.framework'

Report
Firstly I want to give you appreciate for this awesome package but I got some issue while using this.I have Install this package through cocoapods and it's working fine on simulator but the problem begins with xcode preview builder.After adding any input to SkyFloatingLabelTextField, the preview builder is working off and give an error.

Xcode Version is 9.2 (9C40b)

Hey @ajoykarmakar459 please see #201


Exception is always raised when running liminal <cmd>

https://github.com/dynotx/liminal-orm/blob/c8e4c7267810deaea237961600b946b1720115f6/liminal/cli/cli.py#L221-L232
I always see the above exception raised unless I run liminal --help, liminal -h, liminal init or liminal <cmd> -h/--help.
For example:
❯ liminal generate-files test-tenant test-path
Starting Liminal CLI...
['/Users/mwelsh/benchliminal/.venv/bin/liminal', 'generate-files', 'test-tenant', 'test-path']
Traceback (most recent call last):
  File "/Users/mwelsh/benchliminal/.venv/bin/liminal", line 5, in <module>
    from liminal.cli.cli import app
  File "/Users/mwelsh/benchliminal/.venv/lib/python3.10/site-packages/liminal/cli/cli.py", line 230, in <module>
    raise Exception(
Exception: No liminal/env.py file found. Run `liminal init` or check your directory.

For what it's worth, liminal/env.py does exist, but I don't think that execption is really relevant to the if/else logic:
if sys.argv[1:] and not sys.argv[1]:
    # this always evals to false

Hey mark, thanks for raising an issue! This was an oversight on my part and has been resolved in the PR linked above. I've released v1.0.1 patch so if you install that, you should be good to go.
Reach out to me or raise another issue if you run into anything else or you have any other questions! I'll be making sure to smooth out the wrinkles for our first couple users.

thanks! It's fixed now. I appreciate the timely response


Moving on from .Net Standard

From testing, it appears that updating to System.Text.Json v7 will require that I drop support for .Net Core 3.1.
I don't expect this will be a problem for most of my users as .Net Core 3.1 is end-of-life anyway, but I feel it deserves notification and a major version bump in the libraries.
This will come... eventually.

Hello.
I just tried using this library in a .NET 7 project, and it pulled in System.Text.Json 7.0.0 with no apparent issues.
Unless there are specific reasons I don't think a forced upgrade is strictly required.

Some further discussions in #532 revealed that it might be time to move on from .Net Standard.  I need feedback from users.
This would probably apply to the entire suite.

I now have a branch with everything working for net6.0.
Might try to multi-target with net8.0 later, but very happy this is working for now.

This .Net 7 Regex stuff would be nice to have.
https://devblogs.microsoft.com/dotnet/regular-expression-improvements-in-dotnet-7/#stringsyntaxattribute-regex


Overloading etherscan with API calls / caching not working

Hi there,
This package has become a huge bottleneck in our app due to the repeated lookups for an address. I don't believe the caching is actually working in the latest version of this package? Every render of a Davatar it fires off hundreds if not thousands of requests to getUrl.js. Any insights?

I'll take a look at this, for some reason I haven't been receiving notifications from github so just saw this!

What version is this on?


EDU-726 Include multitrack-media plugin in list

Closes https://educandu.atlassian.net/browse/EDU-726
(Also switched around the table and interactive-media plugins, so that we'll have all the fancy media plugins at the end)

Closes https://educandu.atlassian.net/browse/EDU-726
(Also switched around the table and interactive-media plugins, so that we'll have all the fancy media plugins at the end)

:+1: