Label prefix is hardcoded to label., creating two schemes

Description
As shown in this line, the New Relic infrastructure agent is hard coded to prepend label. to all tag keys reported from the agent to NRO. This does not seem to be configurable in any way.
In situations such as applications running on ECS where the infrastructure agent is running on the ECS host, this causes AWS tags to be consumed as label.tagkey. All modern AWS cloud integrations consume tag metadata by prepending tags. to tag keys.
This means that when filtering resources in NRO, there are two schemes: tags.tagkey and label.tagkey. NRQL queries need to be overly verbose to compensate, i.e. WHERE (tags.tagkey1 = "x" OR label.tagkey1 = "x") AND ...
The only way I can see currently to fix this would be to fork newrelic/infrastructure-agent and change the label prefix to tags. then re-compile the agent. This seems excessive.
Expected Behavior
Label prefix is a configurable value for the infrastructure agent. This would allow us to align the label prefix with that of the modern cloud infrastructure integrations.
Steps to Reproduce
Design flaw, not a bug.
Your Environment

AWS CloudWatch metrics stream integration
AWS CloudWatch api polling integration for non-streaming supported services
Tags originate in AWS and APM agents
Many applications are Serverless Framework, requiring tagging to originate in AWS then propagate to New Relic from the cloud infrastructure integrations
Some applications run on ECS clusters with the infrastructure agent installed

Additional context

https://discuss.newrelic.com/t/can-we-configure-the-infrastructure-agent-prefix/191331
https://discuss.newrelic.com/t/aws-difference-between-label-tags-and-tag-tags-where-do-each-come-from/191323

Hi,
We consolidated multiple channels that were used to file Feature Requests (FRs). In the spirit of improving the visibility of FRs, we believe it's best for them to be submitted through the New Relic Issue Tracker. This single tool will enable better aggregation of FRs and improve our ability to synthesize requests and provide better value to our users. You can see and vote for other FRs submitted by all users.
Please provide a link to this GitHub issue when submitting your feature request.
Thanks!


wrong way to send embeds

You are using the old way to send embeds. I'm not sure how you forgot about this one area but everyone makes mistakes :D

You were doing
interaction.reply(embed)

when its suppose to be
interaction.reply({embeds: [embed]})

This should fix #94

Thanks!


[feat] Show in finder/explorer

Describe the problem
The shell.open API can be used to open local files (in their respective app) or opening a directory in the finder/explorer-equivalent. In addition to this, I need to "show in finder", i.e. open a directory with a set of files/directories selected.
Describe the solution you'd like
At a minimum, a function that accepts one file or directory and opens its containing directory with that file/dir selected. Ideally, multiple files can be provided, but I think this may be harder to do cross-platform.
Alternatives considered
No response
Additional context
If API additions are difficult, I'm also interested in workarounds.

So the main problem here indeed is cross-platform support. Linux is basically ruled out, since xdg-open doesn't support it, we could read the user's preferred explorer app and compare it with a predefined list and spawn them directly.
On the other hand, windows and macos support is fairly easy:
// These are rust commands, not tauri ones btw
// Windows
Command::new( "explorer" )
        .args(["/select,", "\"path\\to\\file\\""]) // The comma after select is not a typo
        .spawn()
        .unwrap();
// Alternatively there is a win32 api for this iirc which needs to be used for longer file paths i think.

// macOS
Command::new( "open" )
        .args(["-R", "path/to/file"]) // i don't have a mac so not 100% sure
        .spawn()
        .unwrap();

All that said, i think this would be better suited in a tauri plugin, especially because of linux.

Thanks @FabianLars . Your solution would work even with the JS shell API as well right? I can try these out, and with a fallback (see below) this should work OK for linux as well.

All that said, i think this would be better suited in a tauri plugin

IIUC there's a broader discussion about small core (with an extensive plugin system) vs big functional core, which I will not weigh in on here :) Just for reference, here's some prior art that could be good to know:
Electron has a shell.showItemInFolder(fullPath) API, a quick-n-dirty github search shows 5-15k results, so it does at the very least appear popular.
Here's their Linux version:
https://github.com/electron/electron/blob/31c2b5703a75a5ff2bf0e68f472d9002fe866bfb/shell/common/platform_util_linux.cc#L68
So I guess the answer is it works, but not with a command only.
However, they have a sensible fallback (just open the directory without selecting anything). For my case, this fallback is certainly better than omitting the feature altogether.

Your solution would work even with the JS shell API as well right?

Hopefully, yes.

IIUC there's a broader discussion about small core (with an extensive plugin system) vs big functional core

Well, i don't want to dig in that discussion either (although generally i think it makes sense to not integrate everything into the core), but for me the main selling point of plugins is that it can be implemented regardless of tauri's release cycle and feature-freeze.

Here's their Linux version:

Ah yeah, totally forgot about the dbus option (probably cause we don't use that anywhere yet), but of course this is a little bit more complicated 🤷

We use dbus indirectly in the notifications via notify-rust.

A viable workaround command for Linux is dbus-send, which uses D-Bus as highlighted before to do the trick:
dbus-send --session --dest=org.freedesktop.FileManager1 --type=method_call /org/freedesktop/FileManager1 org.freedesktop.FileManager1.ShowItems array:string:"file:///path/to/file" string:""

This command was suggested by Eduardo Trápani at this Stack Exchange question.

https://gitlab.freedesktop.org/dbus/dbus/-/issues/76 there's even a patch to allow the change! I do wonder how chromium does it. I tried to dig into their code base months ago and stopped as soon as I found out dbus was used in someway.

Okay I wrote a generalized Tauri command (Rust 1.58+) with some leeway on Linux.

The Code
use std::fs;
use std::fs::metadata;
use std::path::PathBuf;
use std::process::Command;

#[tauri::command]
fn show_in_folder(path: String) {
  #[cfg(target_os = "windows")]
  {

    Command::new("explorer")
        .args(["/select,", &path]) // The comma after select is not a typo
        .spawn()
        .unwrap();
  }

  #[cfg(target_os = "linux")]
  {
    if path.contains(",") {
      // see https://gitlab.freedesktop.org/dbus/dbus/-/issues/76
      let new_path = match metadata(&path).unwrap().is_dir() {
        true => path,
        false => {
          let mut path2 = PathBuf::from(path);
          path2.pop();
          path2.into_os_string().into_string().unwrap()
        }
      };
      Command::new("xdg-open")
          .arg(&new_path)
          .spawn()
          .unwrap();
    } else {
      Command::new("dbus-send")
          .args(["--session", "--dest=org.freedesktop.FileManager1", "--type=method_call",
                "/org/freedesktop/FileManager1", "org.freedesktop.FileManager1.ShowItems",
                format!("array:string:\"file://{path}\"").as_str(), "string:\"\""])
          .spawn()
          .unwrap();
    }
  }

  #[cfg(target_os = "macos")]
  {
    Command::new("open")
        .args(["-R", &path])
        .spawn()
        .unwrap();
  }
}

I've used this command multiple times with my music player and not once has it expanded the navigation panel. The github desktop implementation however always expands the navigation panel.

@elibroftw, when I try to compile your code, I get the following error:
error: cannot find macro __cmd__OTHER_CMDS in this scope
.invoke_handler(tauri::generate_handler![OTHER_CMDS, show_in_folder]);
Any ideas?

@aleph1 Remove OTHER_CMDS. This was just to show that this is where your own commands would be registered too.

Electron implements it in C++ with DBus for Linux.
https://github.com/electron/electron/blob/main/shell/common/platform_util_linux.cc#L71
My solution fails on Linux Mint for some reason (adds /home/$USER before my path).
I'm going to try to port as best as I can and create a PR or something to the Tauri shell API. Make DX and UX better.

2024 Update.
I encountered an error using Command::new on Linux Mint, so here is the implementation via the dbus crate.
I'm going to try to create a PR to the Tauri shell API during reading week. The DX and UX can be better for everyone.
Cargo.toml
util_commands.rs
main.rs
JavaScript Usage
English OS localization strings I'm using in frontend. Looking for thoughts
"revealFile_win32": "Show in File Explorer",
"revealFile_darwin": "Reveal in Finder",
"revealFile_linux": "Show in folder",

  .method_call(
        "org.freedesktop.FileManager1",
        "ShowItems",
        (vec![path], ""),
      )

should be
       .method_call(
               "org.freedesktop.FileManager1",
               "ShowItems",
               (vec![format!("file://{}", path)], ""),
           )

I used to use file:// but still yet to find a case where it works with file:// but not without. I'll change it though.


deferred load breaks under unforked SDK + serialized compiliation

Here is a repro:
a.dart
import 'b.dart' deferred as b;

main() => b.loadLibrary().then((_) => b.foo());

b.dart
class A<T> {
  final String key;
  const A(this.key);
}

const a1 = const A<String>('key1');
const a2 = const A<List<int>>('key2');

foo() {
  print(a1);
  print(a2);
  print(a1 == a2);
}

single-step compile:
dart2js --out=out.js --platform-binaries=$SDK/out/ReleaseX64NNBD/ a.dart

Will generate both the definition and references to C_A and C_A0 in out.js_1.part.js.
serialized-step compile:
dart2js --out=1.dill --platform-binaries=$SDK/out/ReleaseX64NNBD/ --cfe-only a.dart
dart2js --out=2.dill --write-data=2.data --platform-binaries=$SDK//out/ReleaseX64NNBD/ 1.dill
dart2js --out=out.js --read-data=2.data --platform-binaries=$SDK/out/ReleaseX64NNBD/ 2.dill

Will generate the definitions in out.js_1.part.js, but the references in out.js (main unit).

@fishythefish - I wont have much time to investigate today during the day - would you be able to look into it?

Sure, I'll give it a shot.

Adding --enable-experiment=non-nullable to the third command eliminates the difference.
I surmise that 2.dill no longer feature-detects to the correct settings.
We could also store setting in the data.

:facepalm: - thanks @rakudrama, here is the fix https://dart-review.googlesource.com/c/sdk/+/147344

fixed in fb11d6399c7742333ab3ea9abe6d8ac88466dc4b


problems with running az list on Linux

I've just upgraded the az and it seems to be having problems with listing the VMs in DevTest Lab:
azure-cli                         2.41.0
Describe the bug
Command Name
az vm list
Errors:
The command failed with an unexpected error. Here is the traceback:
'ComputeManagementClientConfiguration' object has no attribute 'api_version'
Traceback (most recent call last):
  File "/opt/az/lib/python3.10/site-packages/knack/cli.py", line 233, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 663, in execute
    raise ex
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 697, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 333, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
    return op(**command_args)
  File "/opt/az/lib/python3.10/site-packages/azure/cli/command_modules/vm/custom.py", line 1381, in list_vm
    return list(vm_list)
  File "/opt/az/lib/python3.10/site-packages/azure/core/paging.py", line 129, in __next__
    return next(self._page_iterator)
  File "/opt/az/lib/python3.10/site-packages/azure/core/paging.py", line 76, in __next__
    self._response = self._get_next(self.continuation_token)
  File "/opt/az/lib/python3.10/site-packages/azure/mgmt/compute/v2022_08_01/operations/_virtual_machines_operations.py", line 2254, in get_next
    request = prepare_request(next_link)
  File "/opt/az/lib/python3.10/site-packages/azure/mgmt/compute/v2022_08_01/operations/_virtual_machines_operations.py", line 2239, in prepare_request
    _next_request_params["api-version"] = self._config.api_version
AttributeError: 'ComputeManagementClientConfiguration' object has no attribute 'api_version'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az vm list

Expected Behavior
Environment Summary
Linux-5.15.0-41-generic-x86_64-with-glibc2.35, Ubuntu 22.04.1 LTS
Python 3.10.5
Installer: DEB

azure-cli 2.41.0

Extensions:
azure-devops 0.22.0

Dependencies:
msal 1.20.0b1
azure-mgmt-resource 21.1.0b1

Additional Context

Since it is repeated with issue https://github.com/Azure/azure-cli/issues/24187, so I will close the issue first. We will focus on issue https://github.com/Azure/azure-cli/issues/24187 for discussion


Support word boundaries \b

Suggested by @spacemonaut here (and a Stack Overflow reference)
Really good idea.

Have you checked that MySQL regex supports this?

@ArtOfCode- Sure. It's suggested by doppelgreener and the message is here.

@iBug Have you verified that it works locally on an MS dump?

@thesecretmaster It works on live MS, but I don't have the environment to test locally.

Alright, I've testing and it works. This is good to merge, except maybe we want to think about our approach to hacking PCRE into default mysql regex.


[Quilt] 1.19.2 serverside deserialisation client crash.

Fish of thieves seems to be making me crash on my server (1.19.2) with this error.
it's a pretty destructive bug for anyone on 1.19.2

https://paste.atlauncher.com/view/77643770-fad9-413e-84a6-6db1c1452cb0
Loader: quilt/fabric
Mc: 1.19.2
Mod ver: latest 1.19.2

Are you really sure about that? I don't see any log that related to FoT.

Yeah, the moment i removed fish of thieves it stopped crashing on server side.

Can you zip entire logs folder? So I can check them all.

here's the logs of the client i used that crashed before. We moved forward a bit so i can't remember the date, but if i recall, it didn't mention much
logs.zip

Oh, I see you are using Quilt to play with FoT. I don't think my mod is playable on Quilt.

that's a shame, considering it's made to be compatable with fabric mods. You basically have the only fish mod. Oh well, guess i'm at an impass.

Yeah I know it's just a fish mod. But if you know how to do minecraft modding just port it yourself.
I'll leave this open until I have time to learn how to modding on Quilt.

i did some investigating, i figured out it was a server issue causing this one problem. I don't think it was fish of theives, due to it happening elsewhere. it's just hard to test server side only issues, this crash stopped after removing FoT, but started again elsewhere.


3 SILOptimizer tests are failing on Ubuntu 20.04 AArch64

Failed Tests (3):
Swift(linux-aarch64) :: SILOptimizer/addr_escape_info.sil
Swift(linux-aarch64) :: SILOptimizer/escape_info.sil
Swift(linux-aarch64) :: SILOptimizer/ranges.sil
https://ci.swift.org/job/oss-swift-package-ubuntu-20_04-aarch64/440/console
consoleText-2.txt

rdar://92963081

This was fixed by https://github.com/apple/swift/pull/59839.


feat: add docs

Signed-off-by: morrieinmaas<EMAIL_ADDRESS>@TimoGlastra Any feedback welcome.

Anything you think should be mentioned or explained more explicitly/in more detail?
Anything missing altogether?
Any changes to structuring (eg /docs folder not ok or files not ok)?
Any other feedback.

Thanks for all the (quick0 feedback. Especially the spell checker plugin (^^ - was about time).
I'll have a go at resolving it now

@TimoGlastra Updated as discussed last week. Feel free to leave comments if anything is still missing or you want changes

@lohanspies any feedback welcome


Question - how to install?

Hello,
I am running airflow from a docker containers.
I have installed on the base image the plugin. That means that it should be available on all the containers (worker, scheduler, webserver, ..)
pip install airflow-ecr-plugin

I have also added the dag in the dags/ folder
I tried to put setup.py in the plugins/ then I tried to put it in the dags/ folder.
I constantly get that error:
Broken DAG: [/opt/airflow/dags/refreshECRtokens.py] Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/opt/airflow/dags/refreshECRtokens.py", line 4, in <module>
    from airflow.operators import aws_ecr
ImportError: cannot import name 'aws_ecr'

Please help by pointing how to install it that plugin.

Ah. In that case, can you try using the operator directly?
It should import like any other python package.
import airflow
from airflow_ecr_plugin import operators

REFRESH_ECR_TOKEN_DAG = airflow.DAG(...)

operators.RefreshEcrDockerConnectionOperator(
    task_id=<task_id>,
    ecr_docker_conn_id=<docker_conn_id>,
    ecr_region=<ecr_region>,
    aws_conn_id=<aws_conn_id>,
    dag=REFRESH_ECR_TOKEN_DAG,
)


added workflow as per issue #62

Fixes #62
@Swarnendu0123 please review and merge this PR
Also, please add labels and assign me this PR
Thank you!

You shouldn't mention mentainors aggressively.

@Swarnendu0123 I am sorry will keep in mind next time

Thanks!


Bonnie v2.1 VSAC Refactor

Light refactoring of to make use of new VSACAPI class in bonnie_bundler. Primarily refactors the way ticket granting ticket is stored in the session for reuse.
~❗ Currently points to corresponding bonnie_bundler branch. This should be reverted after bonnie_bundler PR is merged.~

[x] Gemfile fixed before merge.

Pull requests into Bonnie require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[x] This pull request describes why these changes were made.
[x] This PR is into the correct branch.
[x] JIRA ticket for this PR: https://jira.mitre.org/browse/BONNIE-1339
[x] JIRA ticket links to this PR
[x] Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
[x] If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced. N/A
[x] Tests are included and test edge cases
[x] Tests have been run locally and pass (remember to update Gemfile when applicable)
[x] Code coverage has not gone down and all code touched or added is covered.

In rare situations, this may not be possible or applicable to a PR. In those situations:

Note why this could not be done or is not applicable here: N/A
Add TODOs in the code noting that it requires a test N/A
Add a JIRA task to add the test and link it here:  N/A
Before - 1567 / 1784 LOC (87.84%) covered.
After -  1579 / 1791 LOC (88.16%) covered.

[x] Automated regression test(s) pass N/A Does not affect calculation.

If JIRA tests were used to supplement or replace automated tests: N/A

[x] JIRA test links: N/A
[x] Justification for using JIRA tests: N/A
[x] JIRA tests have been added to sprint N/A

Reviewer 1:
Name:

[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases
[x] You have tried to break the code

If JIRA tests were used to supplement or replace automated tests: N/A

[x] JIRA tests have been run and pass N/A
[x] You agree with the justification for use of JIRA tests or have provided input on why you disagree N/A

Reviewer 2:
Name: @losborne

[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases
[x] You have tried to break the code

If JIRA tests were used to supplement or replace automated tests: N/A

[x] JIRA tests have been run and pass N/A
[x] You agree with the justification for use of JIRA tests or have provided input on why you disagree N/A

Gemfile has been sorted for merge to point to latest bonnie_bundler bonnie-v2.1. Only failing travis errors are loofah and rails sanitizer.


Redshift add early startup option, rewrite to use toINI and add more options

Motivation for this change
This adds an earlyStartup option, which allows to start redshift before the graphical interface is up.
While doing this, I realized that this can be done a lot simpler using toINI.
This is meant to solve #57961

For the author, reviewers, and committers: this PR was scanned and appears to add a use of the deprecated types.string, which emits a warning as of #66346. Before merging, please change this to another type, possibly:

types.str for a single string where merging does not make sense, or cannot work
types.lines for multi-line configuration or scripts where merging is possible
types.listOf types.str for a mergeable list of strings

I think we can close this for https://github.com/NixOS/nixpkgs/pull/50979, which is being worked on again and overall more finished


[Meta Schedule][M3b] Runner

This PR is part of the meta schedule project (#8473) that adds the
asynchronous program runner interface, as well as a reference
implementation of RPCRunner. LocalRunner will be implemented with
PopenPool executor in a follow-up PR.
Co-authored-by: Xiyou Zhou<EMAIL_ADDRESS>Co-authored-by: Bohan Hou<EMAIL_ADDRESS>Co-authored-by: Ruihang Lai<EMAIL_ADDRESS>Co-authored-by: Hongyi Jin<EMAIL_ADDRESS>Co-authored-by: Wuwei Lin<EMAIL_ADDRESS>Co-authored-by: Siyuan Feng<EMAIL_ADDRESS>

The PR is ready for review! CC @comaniac @Laurawly @jcf94 @mbrookhart


Update parameters with recent changes

Summary
Changed description to hint more of the current possibilities while hopefully remaining to the point.
Updated descriptions of some of the parameters that seemed misleading or not descriptive enough.
Fixes https://github.com/dotnet/docs/issues/15524

The docs content validation fails with a warning that points to a page that is 404. https://aka.ms/LocaleSpecificLinks Please advice on how to fix.

Awesome thanks! 👏


Using Binoculars Does Not Slow

Description

You can run around as a far seeing scout without any silly drawbacks to having your eyes focused on it.

This is intended. They don't slow you in CM-13 either.


jets: adds new, optimizes existing tree-math jets

Building on urbit/urbit#6592, this PR adds jets for +pin and +hub. Additionally, it fixes some unsafe c3_w -> u3_atom conversions and optimizes +peg and +mas.
This is a draft PR as further testing of these changes is still needed.
/cc @eamsden

If urbit/urbit#6819 is ever restored, 2d696e3bf570e3b7b442dc73fea601e2f50649c7 should be reverted.

I've updated u3i_slab_from() to correctly mask off any unwanted bits from the most significant word when asked to truncate its input atom.  All prior call sites used at least the exact word-length of the input atom, so the old behavior was correct in all those cases. But it the API was riskier than needed (and my local work around for it was wrong).
I've corrected the +mas jet, and added some trivial tests to sanity-check the boundary condition.


Failing CI steps on PRs from forks (azure install and live tests)

We currently have a process where forks from PRs run two steps in our CI pipeline that require access to repo secrets to run properly. These show up on failing tests in the PR, which can be confusing.
For example, see this recent PR:
https://github.com/drivendataorg/cloudpathlib/actions/runs/3751066339
A few options:

Don't run these tests on PRs from forks. Downside is that this means external contributions don't have live tests or azure install run against them.
Skip these tests on PRs from forks, and only allow PRs from forks into a separate "staging" branch. Require that merges into master come from a local branch. Normal flow is that contributor PRs are pulled into staging if their tests pass and then into master if stating CI run comes back clean.
Add a manual trigger for these steps, which we may be able to run on forks (not really sure if this is possible or not)
Keep as is with failing tests that are a reminder to merge into a repo-local branch and create a PR that will run all the tests.

The procedure described in this article sounds promising: https://dev.to/petrsvihlik/using-environment-protection-rules-to-secure-secrets-when-building-external-forks-with-pullrequesttarget-hci

This looks super helpful

Just took a look at this again and summarizing some learnings:
In December 2021, GitHub added the new workflow trigger pull_request_target. This is just like a normal pull_request trigger except that it runs in the context of the base branch (main/master on the upstream repo) instead of the merge commit (the fork), and by doing so both has access to secrets and to a GITHUB_TOKEN with repository write permissions.
This means it's easily technically possible to run our live tests against a fork PR: use the pull_request_target trigger, and check out the PR's head commit. However, this is very insecure as it gives the fork an opportunity to do a script injection attack with elevated privileges.
There are various ways that people suggest hardening this.

GitHub themselves wrote a blog post suggesting that we condition the job on a label that maintainers manually apply to the PR. Maintainers should only apply the label after reviewing the code.

This feels like it has an obvious weakness, which is: what happens if the fork commits malicious code after the label was applied?

This other blog post suggests conditioning the job on the permissions or identity of the actor that triggered the workflow. This means that a workflow run triggered by a commit by the external contributor would not pass the condition, while a rerun triggered by a maintainer would.
The 2022 blog post I linked earlier suggests using environment protection rules to secure the job. You can create an environment within which to run the job, and then you can require that jobs for that environment require a manual approval from someone in a configurable group.

Overall, using pull_request_target feels somewhat fraught, but the environment protection approach seems to me like the best way of actually implementing it with some security.


Workspace path is set when pasted in

Need to make sure that the workspace path only changes when save it pressed. Right now, pasting a new path saves it.

This was fixed.


Rename Interests to Interest

Closes #993

Since this touches (almost) all files a quick review would be nice.


Filtering System does not work

Dup steps:

Click filter
type in "rocket league"
Click ok
Hit new streamer
error messages show up in console

Workin on it! standby.

Wonderful just thought Id let you know

Okay this should be working well. Got a little overzealous with my path allowlisting in nginx. This is pretty basic search; it's just searching for the string in the game name. I may need to tweak it depending on performance since I'm kind of abusing redis in this regard but should work for now.
Note that it also works for thumbnails 🙂

What do you mean it also works for thumbnails?
Great work though, looks like it works like a charm!

If you have entered a filter term, future thumbnail refreshes ("Get more
thumbnails") will use the filter, or at least show you as many matching
thumbs as it can if there aren't enough to fill out the box.
On Tue, Mar 30, 2021, 6:14 PM Benny Yamagata Jr. @.***>
wrote:

What do you mean it also works for thumbnails?
Great work though, looks like it works like a charm!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/jkingsman/Nobody.live/issues/8#issuecomment-810680862,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASBTQ542FLPDJELDIIVXCDTGJZQNANCNFSM42DGW7ZA
.


"Fehler bei der Zertifikatsabfrage" with PCR test

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[x] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[x] Bug is not already reported in another issue

Technical details

Device name: OnePlus 8T
Android version: 11
App version: 2.14.1

Describe the bug
Since a retrieval problem (cause 2001) two weeks ago, I can no longer retrieve a certificate for a PCR test. The test result is displayed, but the certificate cannot be generated: "Fehler bei der Zertifikatsabfrage". When clicking on "Nochmal versuchen" a TestCertificateException is thrown.  I have already tried it with several tests.
Steps to reproduce the issue

de.rki.coronawarnapp.covidcertificate.common.exception.TestCertificateException: DCC Components request failed with error 202: DCC pending. de.rki.coronawarnapp.covidcertificate.common.exception.TestCertificateException: DCC Components request failed with error 202: DCC pending. 	at de.rki.coronawarnapp.covidcertificate.test.core.server.TestCertificateServer$requestCertificateForTest$2.invokeSuspend(TestCertificateServer.kt:50) 	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:3) 	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:18) 	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:1) 	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:10

Internal Tracking ID: EXPOSUREAPP-1351

Are you sure that the testing center which has done the test is able to issue DCCs?

Yes, before that it always worked.

Good evening @speedhammy,
Thanks for the detailed report. Could you provide us details of the test center? Thanks.
Best wishes, DS

Corona-Warn-App Open Source Team

It is the test center Johannes Wesling Klinikum Minden.
Am Mo., 20. Dez. 2021 um 20:51 Uhr schrieb dsarkar @.***

:

Good evening @speedhammy https://github.com/speedhammy,
Thanks for the detailed report. Could you provide us details of the test
center? Thanks.
Best wishes, DS
Corona-Warn-App Open Source Team
—
Reply to this email directly, view it on GitHub
https://github.com/corona-warn-app/cwa-app-android/issues/4596#issuecomment-998222677,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW7Y5NWFSNTEILFWPYDVNGDUR6CKJANCNFSM5KOLAVQQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

It is the test center Johannes Wesling Klinikum Minden.

@speedhammy Thanks for the feedback.

Internal Tracking ID: EXPOSUREAPP-1351

noticed the issue with test the first time on the 5th of december, called the Hotline on the 6th of December, but they said, that there where issues. in these Days, so i give them time, but is is still a Issue there
Testcenter ist the Muhelenkreiskliniken AoeR - POC is no Issue, just PCR
I use the IOS App,

@Taeufer
Please add your comment to this iOS issue: https://github.com/corona-warn-app/cwa-app-ios/issues/3256

Same with the lastest 2.15.1. (2)

@Taeufer Thanks for the report. Internal Tracking-ID: EXPOSUREBACK-1351

some results from my personal research:

CWA is aksing for forename, surname and birthdate if the user requests certificate
if this data does not exists on the dcc server, the user gets 202 in the cwa

So your testcenter does not deliver forename, surname and birthdate in a second request to the dcc server.
Hope this helps for further reconstruction.

@tomuench Thanks for your feedback. We will forward this to the internal ticket.

Corona-Warn-App Open Source Team

CWA is not asking for forename and surname
The dcc is requested when the test center provide a negative test result normally after 2 seconds the dcc should be available.
If this is not the case the app retry once and then show the information 202 and the recommendation the user should retry later

CWA requests certificate from the dcc server. The request is stored and a third party software has to answer the request with forename, surname and birth-date. After that the certificate is generated. Now the CWA can show the certificate.
This are currently my informations.

This is not the case for PCR test.

Should be fixed, Provider restated a Service which is related to the QR-Cert generation

@Taeufer thanks for the feedback. You mean restarted, and that's it?

@dsarkar thats what their support send me as answer, may there is a deeper explaining, but at my technical understanding is this plausible answer. We got about 3-4k on PCR per day at the moment, and about a 7500-9000 POC per day, and I guess not that mutch register this in the CWA, or just "visit" the Status-Site, and don´t use the Certificate-Site in the CWA.

Thanks. Now it works.

@Taeufer @speedhammy ok. thanks for the info.


enable using filesystem from a UNC location

The problem is while validating the path, it splits \\server\share\folder by the backslash so the root is just \ and the path ends up being \server\share\folder which isn't valid.  Fix is on Windows to add extra slash if the root is \
Fix https://github.com/PowerShell/PowerShell/issues/4990

I don't like the change being outside of the filesystemprovider, let me see if I can rework this.

@SteveL-MSFT yeah, it would be the best if we can fix the GetParentPath to take into account UNC paths.

@daxian-dbw GetParentPath gets called repeatedly to validate the entire path from leaf to root.  I think putting the fix in NormalizePath() may be better.

@iSazonov I've noticed that the providers get called a lot.  Perhaps GetParentPath() is the right place even thought that gets called a lot as well, but we only need to make it a UNC path again if it's at the root.

I wonder why we have to call NormalizePath method so many times on the same path? Maybe we can fix this?

@iSazonov I created https://github.com/PowerShell/PowerShell/issues/5002 as the perf work item

@anmenaga  Please update your review.

@anmenaga  ping...


Verbose flag for checkpointer

Mind if we add the changes suggested in #357 here?

This PR was supposed to be small but tests will probably take a while to run (my fault they're backed up) so feel free to add onto it.
It would be very nice to access diagnostics and output writers by name.

@ali-ramadhan , the changes in #357 are minor: just some refactoring to permit more flexible interaction with the JLD2OutputWriter constructor. I'll push them in.


SAK-29890 Fix the bug by removing duplicates when getting the list of…

When a TA is granted multiple permission rules that provide overlap for a given category, the category's items are duplicated in the TA's view.
E.g., TA is granted "View" access to ALL categories in the Gradebook, but "Grade" access to only 1 category (let's call it "Homework"). When the TA views the GB, they will see all of the items in "Homework" twice. One instance of the "Homework" items are not editable (bc of the "View" permissions), while the other is editable (bc of the "Edit" permissions).
Investigation
The bug is a long standing one in GradebookService.getViewableAssignmentsForCurrentUser.
Under the above settings, the assignment list is duplicated.
This is because the checks will satisfy BOTH:
if (getGradebookPermissionService().getPermissionForUserForAllAssignment(gradebook.getId(), userUid)) { 	 assignmentsToReturn = getAssignments(gradebookUid);  }
and the following iteration of assignments within categories, which then adds more assignments to the assignmentsToReturn variable.
This is proven by stepping through this method with a debugger from access of both Gradebook and GradebookNG, and a watch on assignmentsToReturn. If there are two assignments, it will end up with 4.
Gradebook must be then removing duplicates.

Branch build not from this it seems.


Function argument with object rest spread generates wrong type error

TypeScript Version:  2.9.1-insiders.20180525

Search Terms: argument rest spread object
Code
const f = (options: { foo?: number }) => { };
let o: {
    foo?: number;
    bar?: string
} = {};
f(o); // ok
f({ ...o }); // error: bar does not exist in type { foo?: number }.
f({ ...o, foo: 5 }); // same error. this is the use case.
let p = { ...o };
f(p); // ok
f(p = { ...o, foo: 5 }); // also ok

Expected behavior:
{...o} has the same type as o and should be interchangeable as function argument.
Actual behavior:
Incorrect error is generated.
Playground Link:
Playground
Related Issues:

@sandersn please apply the appropriate label to this issue :

Duplicate of #19775
Probably won't be fixed until we have exact types, because people who don't want excess property errors currently have two workarounds (a [deprecated] compiler flag and extract-local), but people who do want excess property errors would have no way to cause them if this bug is fixed.

Thanks a lot and sorry I couldn't find the duplicate. For anyone else landing here, some workarounds are:
const f = <O extends { foo?: number }>(options: O) => { };

OR
const f = (options: { foo?: number }) => { };
const ignoreExcess = <T>(arg: T) => arg;
let o: {
    foo?: number;
    bar?: string
} = {};
f(ignoreExcess({ ...o, foo: 5 })); // ok

You can also do
const f = (options: { foo?: number }) => { };
let o: {
    foo?: number;
    bar?: string
} = {};
const ignoreExcess = { ...o, foo: 5 };
f(ignoreExcess); // ok

Which is probably cheaper at runtime, depending on how much the VM tries to optimise.


Change Config vs Env precedence

Fixes #126
Base branch is metal, changes will be part of the new metal-cli.
This PR gives METAL_AUTH_TOKEN precedence over token set in ~/.config/equinix/metal.yaml. Previously, the environment variable was only used if no config value was set.
PACKET_TOKEN support is dropped.
Viper is used to fetch environment variables and config file variables.  These changes come from #90 and will allow for a cleaner PR to solve #54.

I'm merging this now and deferring deeper review to #128.


"This site can’t be reached" for all the apps running as container

for ex.. I am running jenkins as container, it shows default port 8080 is open but when I click on that (URL) it says site can't be reached.
facing same for wordpress application(port 80 is open but can't launch app)!
Am I missing something here ? I can see containers are running.

should be fixed now


ToggleButton animation

Hi,
i have noticed that the ToggleButton widget do not change background color on toggle. After verify that the button effectively work and that it is only a visual bug, i found that on theme files the "toggle-button" theme (used on ToggleButton widget) is missing on both light and dark theme. I have simply copied the button theme and renamed it to "toggle-button" since, as i remember, the ToggleButton widget had the same theme as the Button widget (this should be a regression because i remember that it worked a week ago).
Thanks for the attention,
Have a nice day

Thank you. The ToggleButzon should use also the button style, it think it was forgotten. There is also the selected state. Could you adjust it?

Thank you.


License file's copyright is stuck in 2015

Update it to reflect libpog_query's active status.
P.S. I am incorporating portions of the library into another open source project (more on that later) and I noticed that the copyright in the license hasn't been updated in a while.

@yrashk Thanks for the contribution! You're right that it'd technically be more correct to list the years here. Let me actually update this to reflect our company name, since its more correct nowadays, as its no longer just me (e.g. last release was driven by @msepga)

FWIW: https://stackoverflow.com/questions/2390230

FWIW: https://stackoverflow.com/questions/2390230

Thanks for pointing that out - I think for libpg_query in particular we can follow what the Postgres project does (and in fact, we should reflect their copyright years correctly), see their annual copyright notice update: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=fdaba0a2d749bff497313b584f86855a1440d43e
See https://github.com/pganalyze/libpg_query/pull/175 which does just that.

Fixed via #175


Structure recognition output is not satisfying for some tables

Hi @bsmock, The output of structure recognition is not up to the mark for some of the tables, we have. Could you please suggest us a way to train the model. We have data in abundance.


Check for tracing variables before logging info statements

[trickle] No significant performance differences

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,980,683      Total (>)      1,980,675

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,811,759      Total (<)     10,811,761

 No significant differences in binary sizes

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,980,695      Total (>)      1,980,675

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,811,772      Total (>)     10,811,764

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

This message was intended to be logged for all clients, not just when the client_channel tracer is enabled.  It reflects a possible misconfiguration and is something users may want to know about.

@markdroth should that be switched to GPR_ERROR then?

I don't think it needs to be.  It's a possible misconfiguration, not a definite one.

@markdroth Why is that a possible one?

Because some environments may intentionally configure something like round_robin via the service config with the intention that it will be used only when the resolver does not return any balancer addresses.

Makes sense. Closing the PR.


Rewrite part of httpd to simplify some code.

This change also removes a warning. It's interesting
how often warnings point out code that's not idiomatic,
or can be rewritten to make it simpler and clearer.
Signed-off-by: Dan Cross<EMAIL_ADDRESS>

While not an unappealing idea, I'm not sure I want to ping my hopes and dreams on Go at the moment....


[mds-*] support build on install

In order to use mds-core as a library, the importing module needs access to mds-core build artifacts under dist for each package.  But those build artifacts are not published anywhere at this time.
Short of publishing mds-core to a package registry, this PR implements the solution of using a prepare script to tell the importing library to build mds-core on install and put the build artifacts into node_modules/mds-core alongside the src.
In addition, a files include is used to workaround a yarn bug in which the prepare lifecycle script is not run for a git hosted dependency.
https://github.com/yarnpkg/yarn/issues/5235#issuecomment-490019287
PR Checklist

[ ] simple searchable title - [mds-db] Add PG env var, [config] Fix eslint config
[ ] briefly describe the changes in this PR
[ ] mark as draft if should not be merged
[ ] write tests for all new functionality

Impacts

[ ] Provider
[ ] Agency
[ ] Audit
[ ] Policy
[ ] Compliance

Can one of the admins verify this patch?


make sure one can load Cypress NPM module

Seems when using globally installed Cypress in cypress/included images, we cannot simply do require('cypress') since the global node modules is installed in the unexpected location

This was resolved by adding the global location to the require path. it was needed for 10.0.0


Update AboutUs with Leo's info

Just some nits about the AboutUs page and individual page.
Please feel free to make the quick changes and ping me so I can resolve the merge conflicts and merge.


Fix active navigation item default

This PR fixes a bug in the PageHeaderNavigationDropdown component when it can't find an active tab.
Checklist

[ ] Did you add a JIRA issue in a commit message or as part of the branch name?
[ ] Did you add new unit tests?
[ ] Did you add new integration tests?
[ ] If this is a regression, did you write a test to catch this in the future?

:shipit: once tests pass!

Integration and Unit tests pass locally

Integration tests:

Unit tests:


added warning dialog for modules not supporting CityGML ADEs

good ideas.
just one question: Is it necessary to add the condition "at least one of the registered ADEs is supported by the Importer/Exporter" for puping up the warning dialog? I think no.

No, it is not necessary. The warning could also just pop up whenever ADEs are registered in the database.
I just thought it would be consistent with the CityGML exporter. Even if ADEs are registered, the CityGML exporter would ignore them unless a corresponding ADE extension is installed.

Now ready for review


Update the Pkg in build.zig to build on master

If you do not want this change would you be happy to create a new branch where zlog builds on master, like next or dev or something?
I think for some reason the std.build.Pkg struct was changed and the .path field became .source, and it would be nice to have a beta branch if you prefer to support stable Zig.

Perfectly happy to make that change :)
Thanks for the PR!


Compiled under msvc 2019?

Under win8, msvc2019, no clang, got error with template:
impl_device.cpp 186
return CommandList{ManagedPtr{impl->command_list_recyclable_list.recycle_or_create_new(this->make_weak(), info).release()}};
in these function : impl->command_list_recyclable_list.recycle_or_create_new(this->make_weak(), info).release()

this error fixed by commenting out -> std::unique_ptr<RecyclableT> in impl_recyclable_list.hpp#22
auto recycle_or_create_new(ManagedWeakPtr device_impl, auto const & info) // -> std::unique_ptr<RecyclableT>

very interesting. I don't know what the reason for this would be. I will check if I can repro here on Win11 with Visual Studio

Another thing to note is that I'm pretty sure VS2019 comes with clang.

Could you provide the exact error mvsc generates?

In Visual Studio 2019, I actually am surprised you were able to get that far with regards to the CMake. We're actually using some features that are technically from CMake version 3.21, which is just barely newer than the one provided from Visual Studio 2019. Is there a reason you're not using Visual Studio 2022?

Could you provide the exact error mvsc generates?

daxa\src\impl_device.cpp(186,121): error C2228: expression to the left of ".release" must represent a class, struct, or union
daxa\src\impl_device.cpp(186,121): message : type: std::unique_ptr<_Ty,std::default_delete<_Ty>>
if change it to
auto a = impl->command_list_recyclable_list.recycle_or_create_new(this->make_weak(), info);
return CommandList{ManagedPtr{a.release()}};

got
daxa\src\impl_device.cpp(186,99): error C2514: "std::unique_ptr<_Ty,std::default_delete<_Ty>>": Cannot create class template.
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3415): message : see declaration "std::unique_ptr<_Ty,std ::default_delete<_Ty>>"
Windows 8, x64; SDK 8.1, or SDK 10.0.18362.0; VS2019 v142; /std:c++lastest

In Visual Studio 2019, I actually am surprised you were able to get that far with regards to the CMake. We're actually using some features that are technically from CMake version 3.21, which is just barely newer than the one provided from Visual Studio 2019. Is there a reason you're not using Visual Studio 2022?

Yes, everything seems to work in 2019. The new one is always harder, and why if everything works. And yes, they take up a lot of space. )

I will close this issue as the part of code in question has been removed in a rescent refactoring.


CKEditor: Uses malformed URLs

Describe the bug
On trying to load additional ressources  wrong urls are used.
Environment:

PF Version: 10.0
JSF + version: Mojarra 2.3.14.SP02
Affected browsers: Firefox, Chrome, probably all

To Reproduce

Go to the showcase: https://www.primefaces.org/showcase-ext/sections/ckEditor/basicUsage.jsf
Start developer tools - network
Reload the side with Ctrl+F5
See gets to:

https://www.primefaces.org/showcase-ext/javax.faces.resource/ckeditor/plugins/tableselection/.jsf?ln=primefaces-extensions&v=10.0.0styles/tableselection.css
https://www.primefaces.org/showcase-ext/javax.faces.resource/ckeditor/plugins/dialog/.jsf?ln=primefaces-extensions&v=10.0.0styles/dialog.css
https://www.primefaces.org/showcase-ext/javax.faces.resource/ckeditor/plugins/copyformatting/.jsf?ln=primefaces-extensions&v=10.0.0styles/copyformatting.css

Gets should go to:

https://www.primefaces.org/showcase-ext/javax.faces.resource/ckeditor/plugins/tableselection/styles/tableselection.css.jsf?ln=primefaces-extensions&v=10.0.0
https://www.primefaces.org/showcase-ext/javax.faces.resource/ckeditor/plugins/dialog/styles/dialog.css.jsf?ln=primefaces-extensions&v=10.0.0
https://www.primefaces.org/showcase-ext/javax.faces.resource/ckeditor/plugins/copyformatting/styles/copyformatting.css.jsf?ln=primefaces-extensions&v=10.0.0

We have set the responce header X-Content-Type-Options="nosniff". So I get errors in the browser console.
Only out of curiosity: With my local application I see the &e=10.0.0 parameter on every request. The showcases uses most of the time only v=10.0.0 without e=10.0.0. I did not understand what the reason for this different.

i will take a look

Ahh its weird that they give 200OK with response content empty.  I would have expected 404's?

Thanks for reporting this is fixed for 10.0.1

@melloware Thank you for the fast fix. Is there already a timetable for 10.0.1?

I can probably do 10.0.1 anytime.  @jepsar is there anything else you want to get in to 10.0.1?

I can probably do 10.0.1 anytime. @jepsar is there anything else you want to get in to 10.0.1?

Small change in the light switch js.. coming up

@melloware Do not hurry with a new release because of me.
I did copy the new ckeditor.js and smiley.js to my application. The failure with styles/dialog.css is gone. But I still get the failures for

styles/tableselection.css
styles/copyformatting.css

Is there anything else I have to do?

I did some digging.
The hrefs inside the iframe are correct, for instance: http://localhost:8080/intern/javax.faces.resource/ckeditor/plugins/copyformatting/styles/copyformatting.css?ln=primefaces-extensions&v=10.0.0&e=10.0.0
But the CSS files are also included to the surrounding side. There the href is wrong: http://localhost:8080/intern/javax.faces.resource/ckeditor/plugins/copyformatting/?ln=primefaces-extensions&v=10.0.0&e=10.0.0styles/copyformatting.css.

There are another two references that do not use CKEDITOR.getURL on lines 862, 863 and 1294, 1295. These are splitt by a line break so the RegExp in the RessourceModifier does not match.
@melloware Thanks again for the fast fix.

Ahhh OK I have had to fix that resource modifier before.  Let me look.

OK now its really fixed.  Both those URL's are now resolving.

@melloware I know, I did say you don ot need to hurry because of me. But meanwhile I would appreciate a 10.0.1 release of primefaces-extension. Could you do a new release during the next week or so?

I would wait for https://github.com/primefaces-extensions/primefaces-extensions/issues/372 and then do a release

Thanks, that's very nice.

Yep right after @blutorange fixes the Monaco editor destroy issue i will push a 10.0.1 release.

@OBreidenbach 10.0.1 is now in Maven Central.

Thank you.


Missing BasicAuth in API requests

Requests send from DeviceMgr have no basicAuthCredentials provided, which gives UNAUTHORIZED error.
"method" : "POST",
  "body" : "{\"Password\":\"admin\",\"UserName\":\"admin\"}",
  "url" : "/redfish/v1/SessionService/Sessions/",
  "headers" : {
    "User-Agent" : "Go-http-client/1.1",
    "Connection" : "close",
    "Host" : "<IP_ADDRESS>:8888",
    "Accept-Encoding" : "gzip",
    "Content-Length" : "39"
  },
  "queryParams" : { },
  "queryString" : null,
  "basicAuthCredentials" : null,
  "json" : {
    "Password" : "admin",
    "UserName" : "admin"
  },
  "expandLevels" : 1,
  "expandType" : "NONE"
}, response: {
  "code" : "UNAUTHORIZED",
  "body" : "",
  "headers" : {
    "WWW-Authenticate" : [ "Basic realm=\"BMC Simulator\"" ]
  },
  "location" : null,
  "json" : { }
}

Now, it does not support HTTP Basic-Authetication. You could use the HTTP Token-Based to perform your test.

Jason, how was the fix added?  It should have been done via a pull request.

Edgecore will fix this by early next week.

The issue is resolved.


Messaging (1.0.0-alpha.1) -> Staging

Description

Added AJO messaging RN package
Updated the AEPSampleApp to demonstrate the integration of messaging package

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@shtomar-adb Can you change the PR name to something like Edge (1.0.0-alpha.1) -> staging? If we have a new version to be released, we'd better have the version number in the PR name.

We need to add a .gitignore file in this directory
https://github.com/adobe/aepsdk-react-native/tree/messaging/packages/messaging


Conversion metric for requesting

We would like to measure the journey of someone requesting an item. To do this, we will need to have a conversion metric when someone successfully makes a request.
This is separate from internal reporting on requesting.

Metrics required are in ticket https://github.com/wellcomecollection/wellcomecollection.org/issues/6787. These requirements are based on the user journey set out in Notion.
@alicerichmond @DominiqueMarshall, could you add anything I've missed?

@jamesgorrie metrics have been revised in this ticket to include when user pre-registers for a library account and depending on whether online registration in place, confirmation of library account.

Closing in favour of that ticket then


PHPUnit: working directory not found

Hi. I don't seem to be able to run PHPUnit for whatever reason. I tried to specified PHP executable paths but it still doesn't work. PHPUnit is installed as global and is in the PATH. Any idea where I'm doing something wrong?

Alright, it was just a problem with config file missing. Solved.

The way the plugin finds the config file is it takes the current file path and then traveres back to the root directory looking for either phpunit.xml or phpunit.xml.dist, in that order. When it finds that configuration file it considers that the project root. from there it works pretty much like cd-ing into that directory on the terminal and running phpunit.
Most projects have already have a phpunit.xml.dist configuration file in the project root directory so generally things work straight out of the box without having to change any settings.

Makes sense. I'm just new to PHPUnit, and of course after having looked for a solution for an hour, I posted the issue and found right away. Thanks!


Each extension should be presented its own merged schema

Right now there's just a global schema in cloak that gets presented to all the actions. The goal is for this to instead be per-action: the schema an action sees should consist of just its own direct dependencies. A few reasons this is desirable:

The cloak server can handle more than one client at a time
Less situations in which namespace conflicts arise; easier to add support for dealing with that
Actions that rely on different implementations of the same schema can coexist in the same DAG

We also should consider using this as an initial, very primitive security mechanism for preventing arbitrary extensions from reading arbitrary host resources (like dirs and env vars). We can just never expose those APIs to extensions. We'll need more than than in the long term, but that's probably the simplest place to start.

This is technically true now that dagger-in-dagger results in the creation of a new session. More adjustments will be needed when we revisit extensions but this issue isn't relevant anymore


Nextcloud chart add OWNERS for further contribution

Can we add me in the OWNERS file? The chart-PR from me was just approved (see #10922 ) but I missed creating an OWNERS file directly.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign unguiculus

/ok-to-test
/lgtm


Error installing packages

After reading your posts, I'm experimenting with webR in node.js. However, when trying to use your package to install R packages, it raise an error:
$ Rscript ./node_modules/webrtools/r/install.R dplyr
Skipping install of 'webrtools' from a github remote, the SHA1 (063164d4) has not changed since last install.
  Use `force = TRUE` to force installation
Error in contrib.url(repos, type) :
  trying to use CRAN without setting a mirror
Calls: <Anonymous> ... <Anonymous> -> <Anonymous> -> unique -> contrib.url
Ejecución interrumpida

I'm working on Windows 11 and R 4.3.2.
Let me know if I can help anyhow.

Closed via #2


Refactor: reuse single_node mode for playground and standalone

Add a profile for playground.
Add a profile for standalone mode.
Cloud needs to use the new standalone profile.
Docs need to be updated to use the new playground profile via single_node.
Docker needs to use the new standalone profile.

What about the naming? I quite like --preset in-memory/local-disk (or --profile) proposed here https://github.com/risingwavelabs/risingwave/pull/14951#pullrequestreview-1861839079.
And maybe we can reuse standalone as the command name? (just like implement the map_opts feature directly on top of old standalone mode.

What about the naming? I quite like --preset in-memory/local-disk (or --profile) proposed here #14951 (review).

Yes, profile.

And maybe we can reuse standalone as the command name? (just like implement the map_opts feature directly on top of old standalone mode.

Yes, after we deprecate standalone, we can use single-node as an alias, and rename it to standalone.

Yes, profile.

I mean the profiles' names. e.g., I like in-memory better than playground 🥺

Yes, profile.

I mean the profiles' names. e.g., I like in-memory better than playground 🥺

Yes, I prefer:

in-memory (playground)
persistent (single-node)

For standalone mode, can just choose either and supply extra-args for further configuration.

We may remove playground mode in the future. Users who want to take a try of RW can just use single-node mode.
Discussing here https://risingwave-labs.slack.com/archives/C05TXGYUL6N/p1708578235388599?thread_ts=1707372310.943919&cid=C05TXGYUL6N


RPC call 'active_tasks' returns a wrong result

Hello.
I'm using RPC calls from go to erlang node (I'm writing an erlang prometheus exporter) and I do the following RPC call:
On erlang node:
(demo@MBP-Alexandr)12> erlang:statistics(active_tasks).
[0,0,0,1,0,0,0,0,0,0,0,0,0]

As we can see it is the list.
So now I expect the same result when I do RPC call from golang to this erlang node:
activeTasks, err = process.CallRPCWithTimeout(8, node, "erlang", "statistics", etf.Atom("active_tasks"))

But I receive the following result:

Could you say there is a workaround for this? I tested and found that almost all lists are returned in the same way.

Thanks for the good question. RPC call returns the correct value. String in Erlang is the same as a regular list of numbers with values in range 0..255. It means passing through the encoder Erlang VM treats that value as a string.
let me show you how it looks under the hood. here is your example
(demo1@<IP_ADDRESS>)2> T = erlang:statistics(active_tasks).
[0,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0|...]
(demo1@<IP_ADDRESS>)3> term_to_binary(T).
<<131,107,0,65,0,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,
  0,0,0,0,...>>
(demo1@<IP_ADDRESS>)4>

As you may notice, the binary value has the second byte = 107 - this is a string (https://erlang.org/doc/apps/erts/erl_ext_dist.html#string_ext). That's why you see 'string' value on your side (etf.Term, to be specific, which is interface{} actually).
How to work with this kind of data. First of all, you should make a real string value from etf.Term and cast it to the []byte after all.
// we should make sure that activeTask is a string
if activeTaskStr, isString := activeTask.(string); isString {
    // and here just treat this value as a []byte
   fmt.Printf("active task: %#v\n", []byte(activeTaskStr))
}

@halturin Thank you very much for the clarification

@halturin
I can't figure out how I can receive the result as [0,0,0,1,0,0,0,0,0,0,0,0,0] (for example as string or as int slice).
What do I need to do with []byte?

var b []byte
activeTasks, err := process.CallRPCWithTimeout(8, node, "erlang", "statistics", etf.Atom("active_tasks"))
// activeTasks has etf.Term type, which is redefined type of interface{}.
// You should try to transform it to the 'string' type this way:
if activeTaskStr, isString := activeTasks.(string); isString { // make a string from an interface{} type
    b = []byte(activeTaskStr) // cast given 'string' to the []byte type
    fmt.Printf("active task: %#v\n", b )
}

Sorry for my stupidity ^^ but I got the following result:
active task: []byte{0x0, 0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}

So how I can cast this to a slice or just to string as [0,0,0,1,0,0,0,0,0,0,0,0,0]? :)

Not sure if I follow the question. The problem is in the way of printing?

No. The problem is how to use it.
I want to make a slice from this values.
I mean slice of integers 0,0,0,1...

why do you think it isn't?
active task: []byte{0x0, 0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}
this is exactly what are you want. you can access to the random element within this list of bytes like
https://play.golang.org/p/Q8FYd18qY30

import (
	"fmt"
)

func main() {
	fmt.Println("Hello, playground")
	active_task:= []byte{0x0, 0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}
	fmt.Printf("active task: %#v\n", active_task)
	b4 := active_task[4]
	fmt.Printf("active task: %#v\n", b4)
	b4_7 := active_task[4:7]
	fmt.Printf("active task: %#v\n", b4_7)
}

output
Hello, playground
active task: []byte{0x0, 0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}
active task: 0x1
active task: []byte{0x1, 0x0, 0x0}

I would recommend you to read a book about this beautiful language. Its super easy to learn, but you definitely should read at least one of them just to get to know basic stuff.

Here is useful information about the slices http://devs.cloudimmunity.com/gotchas-and-common-mistakes-in-go-golang/index.html#array_func_args

Yeah, I understand how I can use it to print bytes... But I want to use them as integers like they look in erlang.
I mean when I run this command in an erlang node I receive the following result:
[0,0,0,1,0,0,0,0,0,0,0,0,0]

It is like a list of integers.
So I want to receive the same result on go. Something like this:
intSlice := make([]int, 0)
...
some code
...
fmt.Printf("%v", intSlice[0])  # == 0
fmt.Printf("%v", intSlice[3])  # == 1

Golang is a strongly typed language. You can't treat the list of numbers the same way as it can be done in Erlang. In Golang, 'byte' is an alias for the uint8.
I'm sorry, but this is not a good place to learn Golang. I see the gap in terms of understanding the fundamental stuff in Golang.

Okay, thank you.


Having Chronos listen on a specific interface

Is it possible to have Chronos listen on a specific interface (rather than <IP_ADDRESS>)? Currently, as set up, chronos is available publicly, we would just like to have Chronos to listen on a private ip rather than setting up authentication.
I see Chaos added the flag --http_address recently (mesosphere/chaos@a1afff8019e3251b2b6c3423dbe4c58fb6eabf76) - is getting a chronos build with this option as simple as editing the pom.xml?

+1, this options doesn't work

Hello everyone! Is there any update on this?
Thanks.


Adding application/vnd.ms-excel to accepted file types for importing

Description
Firefox looks to be detecting the CSV files as "application/vnd.ms-excel" and not text/csv, et al. Adding this mime type to CanImportRecords.php solves this issue for Firefox users.
Visual changes

Functional changes

[x] Code style has been fixed by running the composer cs command.
[x] Changes have been tested to not break existing functionality.
[x] Documentation is up-to-date.

I agree that if Excel is outputting CSVs with this type, then we should support it. But I am worried that it will open the input up to users also uploading .xls with the same type?

I agree that if Excel is outputting CSVs with this type, then we should support it. But I am worried that it will open the input up to users also uploading .xls with the same type?

Excel formatted files from the 97-2008 era (.xls) are recognised as the same mime-type so yes, there is a percentage chance of that occurring. Modern Excel files (.xlsx) return as application/vnd.openxmlformats-officedocument.spreadsheetml.sheet. Perhaps a secondary check to exclude file extensions of type .xls?
The PhpSpreadsheet package allows for the reading/importing of xls/xlsx files, but switching over to that library that would also mean changing the underlying processes within the import/export of files.

Not interested in changing the underlying process as it would slow the import process down a lot, currently it is very lean
What's the best way to implement the extension check?

I'd say the fastest would be using the builtin pathinfo function supplied with the PATHINFO_EXTENSION option - this would yield just the extension from the file.
$ext = pathinfo($filename, PATHINFO_EXTENSION);

Please add and test ->rule('extensions:csv') and ensure that only .csv files can be uploaded and not .xls

Please add and test ->rule('extensions:csv') and ensure that only .csv files can be uploaded and not .xls

In the CanImportRecords.php file? I'm not sure where to add what you're asking...

Does it work on the FileUpload?

The PhpSpreadsheet package allows for the reading/importing of xls/xlsx files, but switching over to that library that would also mean changing the underlying processes within the import/export of files.

@notscottsmith Filament currently uses openspout/openspout which also supports Excel files anyway.

Only for exports, not imports. It would change the underlying process and make it slower

openspout/openspout does support reading and writing Excel files.
Yes, but Filament's import action is limited to CSVs only.
I already asked in Discord a few days ago, why there is no Excel import. You clearly have your reasons.
But, why would an Excel import be slower, compared to a CSV import? And does it really matter? The import would be processed in background as a queue job anyway. So there would be no direct effect on the user experience.

We do not use OpenSpout for reading CSVs, we use league/csv.
The time/memory consuming part is reading the Excel file row by row and dispatching jobs. The rest is the same. That part is very performant with CSVs as each record is on a new line. Excel exports will never be able to match the efficiency of CSV ones and it could result in a lot of expectations being placed on the system that the core team does not have the resources to deal with right now. I'd need to see some very strong numbers to consider supporting it.

Please add and test ->rule('extensions:csv') and ensure that only .csv files can be uploaded and not .xls

I've made this change on a local repo and it half-works.
For uploading a .csv via Firefox, it now works as expected.
.xls files can still be uploaded and it allowed you to select a column. It contains garbled data.

However, once you press submit you're given a validation error that your file must have the .csv extension.

Context
Additionally, I was able to gather some extra context about the edge case and why it happens. Windows stores file Content-Types within the registry, and these are used to check what software should open a file. If one has MS Office / Excel installed, the Content-Type for .csv files is changed from text/csv to application/vnd.ms-excel.
From here, browsers differ from how they gather MIME Type. Seemingly, chromium based browsers have their own built-in checks and gather that .csv files are of type text/csv. However, Firefox (which uses Gecko) simply uses the Content-Type within the registry that in this case ends up being application/vnd.ms-excel.

Thanks for the investigation @aSeriousDeveloper, I've made those changes to this PR myself so let's see how it goes

After updating, the aforementioned validation error "The file field must have one of the following extensions: csv" persists.

This seems because the file extension of the uploaded CSV gets changed to .txt in the TemporaryUploadedFile.
I found some discussions in the livewire project: Proposal for Enhanced File Extension Detection Using getClientOriginalExtension()
Would it be an option to add txt to the rule?

@giodi please PR that addition


Custom Floating Filter for Angular 2

Is there any option for Custom Floating Filter for Angular 2.
Please explain how to integrate the same.
Regards,
Mayank Jindal

Hi
Please dont raise support requests here.
You can use the floatingFilterComponentFramework property for this


Update docs on how to pass schema for newer BuckleScript releases.

It would be great to add from which version it's a correct way to pass additional arguments :)

Sure. Although that information is just as apt to fall out date :-)

@baransu I've added some additional context to the PR. Please let me know what you think.

Ok for me, but I have no power here :/


[6.0] Merge changes from main

Cherry-pick the following PRs to release/6.0:

https://github.com/apple/sourcekit-lsp/pull/1148
https://github.com/apple/sourcekit-lsp/pull/1156
https://github.com/apple/sourcekit-lsp/pull/1146

@swift-ci Please test

@swift-ci Please test

https://github.com/apple/indexstore-db/pull/186
@swift-ci Please test


[Bug]: Table tooltip overflows when scrolling

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Table tooltip overflows when scrolling
Steps To Reproduce

Add chart drilldown building block
Hover over a cell of a selected row and scroll
Observe the overflow

Public Sample App
No response
Environment
Production
Severity
Low (Cosmetic UI issues)
Issue video log
https://www.loom.com/share/86f5cd3d014641e6a569fd8719090f17
Version
cloud

Tooltip is working fine
-Video Link ->https://www.loom.com/share/95450b4049394e3989a3d367c082a904?sid=55e179fb-a3bf-43a1-82a2-4a1acd10aad7


Build error when using lib

I tried using the lib by adding to my project deps, and got this error

Ran cargo add osmpbfreader
Cargo.toml now has osmpbfreader = "0.16.0" under [dependencies]
When running cargo build, I got:

error[E0433]: failed to resolve: could not find `Codegen` in `protobuf_codegen_pure`
  --> /Users/myname/.cargo/registry/src/index.crates.io-6f17d22bba15001f/osmpbfreader-0.16.0/build.rs:16:28
   |
16 |     protobuf_codegen_pure::Codegen::new()
   |                            ^^^^^^^ could not find `Codegen` in `protobuf_codegen_pure`

After adding this dep, I could get it work:

cargo add protobuf-codegen-pure
Cargo.toml now has protobuf-codegen-pure = "2.28.0" under [dependencies]
When running cargo build it works

Could thie dependency missing from the lib?

I can't reproduce. I suppose it was a bug in the protobuf crate that is now fixed. If you have a scenario to reproduce, feel free to reopen.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1452

Questions ?
Please refer to the Backport tool documentation


Remove thyme dependency

This PR extracts a (somewhat) minimal subset of features from the thyme package that are used in Pact.
For compatibility and performance, the internal representation of time is Int64 microseconds, which matches the previously used representation of the thyme package and also Pact's notion of time.
For parsing and formatting the respective functions from the "official" time package are used and formatting is adjusted to match the behavior of the Pact Language Specification (which was based on a private fork of thyme).
The API of the module Pact.Types.Time tries to be minimal while still providing a consistent and easy to use set of features.
Additional Tests:

[x] chainweb mainnet history replay (done with a rebased version of this branch on pact-3.7)
[x] check benchmarks

Relevant benchmarks from #868:
benchmarking pures/(time "1970-01-01T00:00:00Z")
time                 3.568 μs   (3.501 μs .. 3.651 μs)

benchmarking time
time                 38.83 μs   (34.79 μs .. 41.47 μs)

Relevant benchmarks from #868:
benchmarking pures/(time "1970-01-01T00:00:00Z")
time                 3.568 μs   (3.501 μs .. 3.651 μs)

benchmarking time
time                 38.83 μs   (34.79 μs .. 41.47 μs)

(results are from this build)
Here are the results from this build of this PR:
benchmarking pures/(time "1970-01-01T00:00:00Z")
time                 13.89 μs   (13.81 μs .. 14.02 μs)

benchmarking time
time                 27.22 μs   (19.37 μs .. 32.38 μs)

Both builds are travis-ci linux builds with AMD64 BUILD=stack ARGS="-j1" Z3VERSION="4.8.7"

Just completed a full mainnet Pact history replay with a version of the PR rebased on pact-3.7.

benchmarking pures/(time "1970-01-01T00:00:00Z")
time                 13.89 μs   (13.81 μs .. 14.02 μs)

Hmm this is significantly worse. Maybe re-run the travis build (re-run both?) to see if this was some kind of anomaly?
I compared other pures benchmarks and they were very similar, so this is troubling.
Of course, the other benchmark is the reverse. However, it may not be as useful and represents a radically different approach. It runs an entire pact repl test -- that way I felt it would exhaustively cover time parsing cases. But it is way less "atomic" than the other benchmarks.

It is expected that parsing of time is slower than with thyme. Calculations on time values may be faster or equal to thyme.
I think, the question is how much of a difference it makes in the context of all txs. In chainweb Pact txs execute in the order of milli seconds. So it would depend on how frequent the operation of parsing times is.

The most recent version of this PR includes a port of the time parsing and formatting code from the thyme package.


Is "user responsible for paying" always going to be a new party added to the case?

Currently the only options are in the users list and we set the value to a string.  Just wanted to make sure that is correct.

No, we should have the ability to add others!
For my own reference, if the party is in the current filing the XML needs to look like this:
<ecf:FilingPartyID>
<nc:IdentificationID>Party1</nc:IdentificationID>
<nc:IdentificationCategoryText>REFERENCE</nc:IdentificationCategoryText>
</ecf:FilingPartyID>

Where "Party1" is the XML id on that CaseParticipant.
And if they are already a part of the case, it needs to look like this:
<ecf:FilingPartyID>
<nc:IdentificationID>037BAEC1-F6E8-43ED-A102-B8C5E76748EC</nc:IdentificationID>
<nc:IdentificationCategoryText>IDENTIFICATION</nc:IdentificationCategoryText>
</ecf:FilingPartyID>

Where the ID is the EFM identifier of the case participant, which we can get from the GetCase call or a GetFiling call for the previous filing.

See #125

This may be mostly resolved by the work in #134, @BryceStevenWilley. I'll leave to you to decide when it's ready to close though


Make the integration backend the default when running locally

Split the local dev config files into two:

application.conf: This is the default, and is the one that will be used when you run sbt run. It connects to the integration backend. You still need to set the AUTH_SECRET and IDENTITY_POOL_ID environment variables, because they're not safe to store in the config file.
application.local-full-stack.conf: This can be selected if you run sbt  -Dconfig.file=conf/application.local-full-stack.conf run, and will connect to the local Keycloak, API, etc.

Looks like the build is failing for this branch: https://jenkins.tdr-management.nationalarchives.gov.uk/job/TDR Transfer Front End Test/job/local-dev/1/console
The unit tests are failing.

Thanks for pointing that out! 😳 Fixed by adding a placeholder cognito.identitypool value to the test application.conf.


Adds !empty check before json_decode

What does this PR do?
Adds a check to see if ns user is null and if so, do not try to json_decode to prevent error:
if (!empty($northstar_user_info->error)) {
        $error = sprintf("Error fetching Northstar user data, uid=%d: '%s'", $id, $northstar_user_info->error);
        watchdog_exception('northstar', new Exception($error));
      } else {
        cache_set('northstar_user_info_' . $id, $northstar_user_info, 'cache_northstar_user_info', REQUEST_TIME + 60*60*24);
}

How should this be manually tested?
endpoint: /api/v1/reportbacks.json?load_user=true should return user info. and not break. Works on local - tested by hard coding $northstar_user_info == NULL before new check and it by passed this correctly, return null for all user info in the api response. How do we test if this works with staging without merging?
Right now, the request to ns to get user information remains the same as what's in this code, so we know that it's successfully getting user info. on staging.
What are the relevant tickets?
#5408

@weerd I'm getting this error:
Notice: Undefined index: data in Reportback->build() (line 168 of /var/www/dev.dosomething.org/lib/modules/dosomething/dosomething_reportback/includes/Reportback.php).

which refers to this line:
$northstar_user = (object) @$northstar_user['data'][0];
I'm not sure why it's saying that it's an undefined index and I looked it up on google - if I add an isset() in front of it or null !== like many things suggest, it no longer returns the correct data. I know it's probably not great practice to use the @ operator but this is the only way I could get the notices to disappear in the logs. Is this the best solution to use?

wait - just checked to test again and looks like it isn't work now because of the rebase - hold off on checking this please and I'll keep you updated! Sorry! @weerd

@weerd okay now back in business! All should be working fine now. Just unsure about the comment above with the @ operator. Also, for some reason, dosomething_helpers_isset wasn't working correctly so changed it to a ternary operator. Let me know your thoughts!

@weerd for some reason, dosomething_helpers_isset(); was causing the notices in the logs. I swapped it out for just a regular isset(); check with a ternary operator and seemed to get rid of the notices! Now the logs are clear and correct data is returned!

I looked into it, and it's how the dosomething_helpers_isset() is used. If it's an object you are passing through to it, you need to also specify the $key for it :)

@weerd tested reportback-items endpoint as well and everything is working with no errors in the logs!

yaaaas!

@weerd thank you! Made those two changes and tested again - still works! :)

Awesome-sauce! :dancer:
Merge it! :+1:

:tada: :tada: :tada: BEST DAY OF MY LIFE!


Fixed Cached Functional Tests

🗣 Description
Fixed the Functional Testing test plans that originally had the original naming convention, RunCached, to be aligned with the new non-generic cmdlet name, ScubaCached

💭 Motivation and context
Cached Functional Tests were failing, with this fix, they should pass.
Closes #1239

🧪 Testing
Run the Cached Functional Tests

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] PR targets the correct parent branch (e.g., main or release-name) for merge.
[x] Changes are limited to a single goal - eschew scope creep!
[x] Changes are sized such that they do not touch excessive number of files.
[x] All future TODOs are captured in issues, which are referenced in code comments.
[x] These code changes follow the ScubaGear content style guide.
[x] Related issues these changes resolve are linked preferably via closing keywords.
[x] All relevant type-of-change labels added.
[x] All relevant project fields are set.
[x] All relevant repo and/or project documentation updated to reflect these changes.
[x] Unit tests added/updated to cover PowerShell and Rego changes.
[x] Functional tests added/updated to cover PowerShell and Rego changes.
[x] All relevant functional tests passed.
[x] All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

[ ] PR passed smoke test check.

[ ] Feature branch has been rebased against changes from parent branch, as needed
Use Rebase branch button below or use this reference to rebase from the command line.

[ ] Resolved all merge conflicts on branch

[ ] Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

[ ] Feature branch deleted after merge to clean up repository.
[ ] Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

For this PR to be approved, I would like to see screenshot evidence of successful execution of all the affected test plans against all tenant types. Keep in mind that for AAD you will be executing two types per tenant. One vanilla and one variant (either G3 or G5).

@nanda-katikaneni this should be ready to be merged


If a response is declared without location, it will no longer render

          Since location is optional, the default was 'belowStimulus'. This line change breaks that behavior and if a response is declared without location, it will no longer render

Originally posted by @JackWilb in https://github.com/revisit-studies/study/pull/104#discussion_r1194379659

This is not true, it defaults to belowStimulus still


BloggerApp: Add forms

BloggerApp: Add forms
In this branch, I have done the following;
✅ added a form to enable users create new posts
✅ added a form to enable users add comments to posts
✅ added a feature to enable users like posts
✅ fix linter errors

@SajjadAhmad14 I have fixed all the issues. All the tests are passing now.
And I have request another review. Will the new review I have requested come to you. If it will then please check and review as its been 4 hours since I requested.


Copy does not work at all in the Firefox browser

Steps to Reproduce

Open Ketcher in Firefox
Copy any structure on canvas and paste (In Firefox)
Copy any structure on canvas in Firefox and paste in Chrome

Actual behavior
Copy does not work at all in the Firefox browser ( This works in older versions of Firefox but doesn't work in the new one Version 128 )
Expected behavior
Copy works in the Firefox browser. Users can copy and paste within Firefox, and they can also copy in Firefox and paste into Chrome.
Desktop (please complete the following information):

OS: Windows 11
Browser Firefox
Version 128

Ketcher version
[Version 2.23.0-rc.3]
#187943968

Moved to 2.24 rc2 since fix already created

Tested. Bug fixed.
https://github.com/user-attachments/assets/a9e76ae9-af46-4f9c-8ba9-7bc8e4cdc3e5
Desktop:

OS: Windows 11
Browser Firefox
Version 129.0.1(64-bit)

Ketcher version
[Version 2.24.0-rc.2]
Indigo version
[Version 1.23.0-rc.2]


Unable to load project with cell object

When I save and reload a project with an object with manually marked cells I get the following error:
Traceback (most recent call last):   File "C:\Users\Matthias\Documents\Neurophys-INSERM\herbs_git\herbs\herbsgui.py", line 5555, in load_project_called     self.load_project(p_dict)   File "C:\Users\Matthias\Documents\Neurophys-INSERM\herbs_git\herbs\herbsgui.py", line 5429, in load_project     self.set_hist_layer_to_hist_view(da_link, layer_data['2d_data'][i])   File "C:\Users\Matthias\Documents\Neurophys-INSERM\herbs_git\herbs\herbsgui.py", line 5131, in set_hist_layer_to_hist_view     self.image_view.img_stacks.image_dict[layer_link].setData(   File "C:\Users\Matthias\anaconda3\envs\conda_herbs\lib\site-packages\pyqtgraph\graphicsItems\ScatterPlotItem.py", line 499, in setData     self.addPoints(*args, **kargs)   File "C:\Users\Matthias\anaconda3\envs\conda_herbs\lib\site-packages\pyqtgraph\graphicsItems\ScatterPlotItem.py", line 601, in addPoints     setMethod(kargs[k], update=False, dataSet=newData, mask=kargs.get('mask', None))   File "C:\Users\Matthias\anaconda3\envs\conda_herbs\lib\site-packages\pyqtgraph\graphicsItems\ScatterPlotItem.py", line 725, in setSymbol     raise Exception("Number of symbols does not match number of points (%d != %d)" % (len(symbols), len(dataSet))) Exception: Number of symbols does not match number of points (0 != 5)

just update code on GitHub, did finishing all testing. The logic for cells is a bit strange I think (hmmm, I think I am not the best coder), When users click on Histological image window, the cell count increases, and a hidden vector (say it is named A) contains the corresponding symbols for cell points in Histological image window also increases. When transferring cells into atlas window, the A is cleared and the actual values of the the corresponding symbols for cell points transferred to a hidden vector (say B) for atlas window. When make a cell piece, B is cleared again. This part of code has been modified so many times, the 1st version is that, when make a piece, the corresponding layer is deleted automatically. In this way, empty A and B will not generate any problem. But.. There was a request wants to keep all layers even after transferring and making pieces. Then the old saving and loading cell projects will leads to the error you got. I modify the code, and will write more on this in the tutorial later. Let me know if anything goes wrong.

You are right. Before data['data'] was a concatenated ndarray of all pieces. Now after modifying the un-merging, data['data'] is a list of all pieces data. so should first concatenate all list together and then take len. Will change it later.

fixed total count.

Thanks, while you are at it, you maybe can push self.object_3d_list = object_data['object_3d_list'] on line 5523 in herbsgui.py behind the if object_data is not None:. Prevents errors when loading projects without objects.

Sure. Thanks! Will do it after dinner 😄

在 2022年11月23日，15:52，Matthias Dipper-Wawra @.***> 写道：

Thanks, while you are at it, you maybe can push self.object_3d_list = object_data['object_3d_list'] on line 5523 in herbsgui.py behind the if object_data is not None:. Prevents errors when loading projects without objects.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.

Bon appétit :)


rocm-runtime is still using gcc, is about to become broken by gcc13

Heads up: even though it tries to overrideCC with clang, our rocm-runtime expression still uses gcc for a ton of stuff.
Try changing default-gcc-version in pkgs/top-level/all-packages.nix to 13 and you'll see the breakage.  I'm about to merge

https://github.com/NixOS/nixpkgs/pull/268097

which does this, and it's going to break rocmPackages.  I tried to fix it, but the problem is very deep: you guys think you're using only clang, but in fact you're not.
Wanted to give you a heads-up.
cc: @lovesegfault @Madouura  @Flakebi

I recommend you guys merge a PR which pins rocmPackages to gcc12Stdenv wherever you aren't really using llvm/clang.  I tried to do this, but it's far from clear where this needs to be done.

you guys think you're using only clang, but in fact you're not.

Unfortunately, I'm aware. I was working on making rocmPackages use only libc/libcxx/etc, but it's rather WIP.

I tried to do this, but it's far from clear where this needs to be done.

It's likely all the way to the root - ROCm LLVM. It has a GCC backend which is used.
Any chance you could give me the error log for rocm-runtime so I don't have to rebuild ROCm LLVM and a bunch of other stuff?

Unfortunately, I'm aware.

Ah, that's actually somewhat of a relief.  At least the problem is known.
Log is attached.  I'm happy to test fixes; I have plenty of compute.  After the new year I will be working on making the buildfarm available to other projects; you'll be on the shortlist if you're interested.
8q1vy1pyk4079vjq3pfqkjmffdvksif2-rocm-llvm-runtimes-5.7.1.drv.log.gz

Also if you need to get my attention I hang out in #tvl on irc.hackint.org.  It's bridged to Matrix.

8q1vy1pyk4079vjq3pfqkjmffdvksif2-rocm-llvm-runtimes-5.7.1.drv.log.gz

Okay, this is rocm-llvm-runtimes, not rocm-runtime. This might be a slightly easier fix then.

I'm happy to test fixes; I have plenty of compute. After the new year I will be working on making the buildfarm available to other projects; you'll be on the shortlist if you're interested.

I appreciate that, when I put the PR through I might request that you do a nixpkgs-review, possibly a few times if the dependency hell is really bad.


Make insertion records available

[x] sync repo with s3
[ ] add fn for fetching from session
[ ] retroactively create records for missing sessions

This was premature - we haven't fully figured out the processing prior to upload yet,
See https://github.com/AllenInstitute/npc_lims/issues/5


Add MQTT trigger and tests

closes https://github.com/spinkube/containerd-shim-spin/issues/111
This should be merged first and then ideally a release of the trigger cut: https://github.com/spinkube/spin-trigger-mqtt/pull/29
Adds an MQTT test which contains a deployment for an MQTT broker and a spin app that is triggered by the the broker.

@Mossaka have you seen these build errors before?

Looks like it's failing trying to find OpenSSL:
  -- The C compiler identification is GNU 9.2.0
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Check for working C compiler: /usr/local/bin/x86_64-linux-musl-gcc - skipped
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- CMake version: 3.23.1
  -- CMake system name: Linux
  -- Timestamp is 2024-07-31T18:11:49Z
  -- Configuring incomplete, errors occurred!
  See also "/target/x86_64-unknown-linux-musl/release/build/paho-mqtt-sys-2d67149a03469667/out/build/CMakeFiles/CMakeOutput.log".

  --- stderr
  fatal: not a git repository (or any parent up to mount point /home/runner)
  Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
  CMake Error at /usr/local/share/cmake-3.23/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
    Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
    system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY
    OPENSSL_INCLUDE_DIR)
  Call Stack (most recent call first):
    /usr/local/share/cmake-3.23/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
    /usr/local/share/cmake-3.23/Modules/FindOpenSSL.cmake:578 (find_package_handle_standard_args)
    src/CMakeLists.txt:194 (find_package)

  thread 'main' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.50/src/lib.rs:1098:5:

  command did not execute successfully, got: exit status: 1

@devigned yeah it has to do with how the paho-mqtt lib pulls in openssl. I am adding in their workaroud now: https://github.com/eclipse/paho.mqtt.rust?tab=readme-ov-file#fully-static-builds-with-musl

@rajatjindal thank you! that got me past the build errors.

After many iterations on the e2e test configuration we are all green 🎉
@devigned @Mossaka @jsturtevant this is ready for a final review


refactored some array tests to table driven style

closes gavv#351
Refactored the subtests in:

TestArray_ConsistsOf
TestArray_Contains
TestArray_ContainsAll
TestArray_ContainsAny
TestArray_ContainsOnly
TestArray_HasValue

to use a table-driven style.
Let me know if you want me to make any changes or add anything :)

Coverage: 95.68%. Remained the same when pulling 04627e6da8bfb567c15e5f57334905fdc2843f02 on frankweate:master into a90f095eb7e501c3ba6a960a2eaeb1d557e33e82 on gavv:master.

I added your requested changes! Let me know if there is anything else for me to add or change :)

Thanks for update!
I've pushed a small follow-up commit with the some cosmetic fixes 24ba8e147e828f157247ff1d3da68f5fa999ee29

fixed formatting in some tests to be similar to the other tests
renamed testArray to array (we usually use such names in other tests) and reordered fields (first goes array, then value)
minor issues


Support Early Stop Mechanism

Allow the trainer to stop the training if the metrics can not be improved further.

Please have a look at the solution in https://github.com/Sujit-O/pykg2vec/pull/111. Thanks!

related to #111, "patience" added to the trainer so it will stop the training process if the loss has not been decreasing for consecutive times.

I add the idea of the interval which I learned from this paper.
http://proceedings.mlr.press/v48/trouillon16.pdf

Interesting interval-based checking. Does that mean if the loss keeps increasing, the later saved model will have higher loss? Or the model will be only saved with the best weights?

it doesn't store the best weights for now. But the idea in the paper is that they check the MRR per 50 epochs and if it stops becoming better then the training process stops.

Oh cool. Probably the continuous increasing in MRR should not happen on a well-designed model and general enough training sets. It would be nice to have a mechanism for trouble-shooting that.

the design of the evaluator has changed to single-process, so it is easier to pass the metric back to trainier.py and judge for early stop mechanism.

Hi, @louisccc. Got a new PR https://github.com/Sujit-O/pykg2vec/pull/121.

new PR should close this issue. #126


OR statement in dbal

http://prntscr.com/9sfe2m causes
Spiral\Database\Exceptions\BuilderException: Nested conditions should have defined operator. in C:\OpenServer\domains\spiral.empty\vendor\spiral\components\source\Spiral\Database\Builders\Prototypes\AbstractWhere.php at line 310

wrong statement, nested OR has to be with @ prefix. @OR


[docs] Remove incomplete section

Remove the incomplete "Heroku" section from the Docs

Visual demonstration
Before:

After:

Please follow the the contributing guide on how to create great pull requests.

Since it's really minor I'd consider not merging this as this is removed in my docs work https://github.com/mui/mui-toolpad/pull/859 - anyways, merging this shouldn't create big conflict if we want to proceed


2.13.0-RC1 branch from ashawley/scala-xml

Want to test updates to scala-xml for 2.13.0-RC1.
This fork also includes the current changes on master.

oh wait... it's late, I should go to bed... you probably wanted this tested before merge?

well, green in quick local test, [info] Project scala-xml-------------------: SUCCESS (project rebuilt ok)
Jenkins will tell us whether any downstream breakage results

Thanks!  Merge works for me if it works for you...


Bump to v2.10.0

cc @brancz
Not be merged immediately as 2.10.0 is the brand new version and I need to test that https://github.com/prometheus/prometheus/pull/5582 didn't break the alerting console. Other than that, there should some nice performance improvements compared to v2.7.2 that is the previously shipped version.

/hold

/lgtm

Alert console seems to be ok:

Nice!

/hold cancel

/lgtm


Fix error-prone warnings and multiple cleanups based on static analysis for CassandraIO

Simple PR to fix a good chunk of warnings of error-prone and IntelliJ's static analysis.
Apart of these there are two minor method refactorings.

Thanks Pablo!


chore(ListItem): Set correct icon propTypes

<ListItem> keeps show warning during unit test regarding icon PropTypes not correct.
This PR set correct collection of PropTypes to cover them all.

🗜 👏