modelize_property: Promote refine-type to an error

Signed-off-by: Jean-Christophe Beaupré<EMAIL_ADDRESS>

If I recall correctly, the old mnit is abusing this (and the origin of the false-error). Did you try do compile and execute mnit_dino for instance?

Not on my computer (because of dependencies). But, Jenkins did: http://gresil.org/jenkins/job/CI_github/4762/testReport/cmd/mnit_dino/make/

Seems OK then. Good riddance!
+1

Maybe wait about @xymus or @Morriar as they might use that in some of their home projects.

I run a search to be sure (find . -iname '*.nit' -exec grep -Pazl 'redef( extern| abstract)? (interface|class)[^\n]*(\n\t[^\n]*)*redef type' '{}' +). Excluding tests, I only find the following 2 cases (that are not actually virtual type refinements and don’t trigger the error):

Addition of a superclass immediatly followed by the overriding of a virtual type of this superclass. Example: redef class A super Comparable; redef type OTHER: A…
In the same module, introduction of a virtual type in a superclass, then overriding of this virtual type in all subclasses. Example: APropDef::MPROPDEF in modelize_class


CAMEL-11497- add pipeline onFallback and pollEnrich eips docs

Great work.

I can see your help about the issue. Thank you, too.


Cannot mock require'd module

I'm having a tough time understanding how to mock a module of mine. Here's what I'm doing. Any help would be great!
Here's the project structure. (screen shot) http://bad-request.fourq.io/162J051f181q
test/lib/routes/link-player.js
var Helpers = require('../../helpers');
var mockery = require('mockery-next');
var request = require('supertest');
var Immutable = require('immutable');
var database;
var app;
require('sinon-as-promised')(Promise);

suite('Route - Link Player', function() {

  function err(error, message) {
    return {error: [error], message: message};
  }

  setup(function() {
    console.log('CALLED FIRST');
    database = Helpers.database();
    mockery.registerMock('../database', function() {return database;});
    app = require('../../../lib/app');
    mockery.enable({useCleanCache: true});
  });

  teardown(function() {
    mockery.disable();
  });

  test('should return bad request when provider id is unknown', function(done) {
    database.getItem = function() {
      return function(data, cb) {
        console.log('!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!');
        cb(null, null);
      };
    };

    request(app).post('/link-players')
      .set('authorization', Helpers.fakeAuthorizationHeader())
      .send({provider: {id: 'test', metadata: {deviceID: '1', username: 'username'}}})
      .expect(400, err(status[400], 'Provider unknown'))
      .end(function(err) {
        mockery.deregisterMock('../database');
        done(err);
      });
  });
});

lib/middleware/attach-database.js (console.log here never prints out the mocked module, always the original)
console.log('CALLED SECOND');
var database = require('../database');
var xtend = require('xtend');

module.exports = function attachDatabase(options) {
  return function middleware(req, res, next) {
    options = options == null ? {} : options;
    var token = (req.player != null && req.player.accessToken != null) ? req.player.accessToken : null;
    if (token != null) {
      options = xtend(options, {sessionToken: token});
    }
    req.db = database(options);
    console.log(JSON.stringify(req.db));
    next();
  };
};

lib/database.js (this is the module I'm trying to mock)
var AWS = require('aws-sdk');
var config = require('config');
var xtend = require('xtend');

console.log('CALLED THIRD');

module.exports = function(options) {
  return new AWS.DynamoDB(xtend(options == null ? {} : options, config.get('Amazon.DynamoDB')));
};

EDIT: cspotcode fixed paths to match the screenshot

I updated the setup code with the same results
  setup(function() {
    console.log('CALLED FIRST');
    database = Helpers.database();
    mockery.registerMock('../../../lib/database', function() {return database;});
    app = require('../../../lib/app');
    mockery.enable({useCleanCache: true});
  });

Looks like you're requiring lib/app.js before enabling mockery.

Thanks for all the helps. The issue ended up being a few of things.

I needed to remove {useCleanCache: true}
I needed to move mockery.enable() above the call to app = require('../../../lib/app')
I also needed to fix the require path to be relevant to the test file

For anyone who reads this in the future:
Removing useCleanCache was necessary due to #6, which I fixed today.  I personally like using useCleanCache: true because it makes mockery's behavior easier to think about: once it's enabled, require has an empty cache and everything will be re-executed when required.  Once it's disabled, the old cache is restored.


coffeescript template refactory

coffeescript template refactory
by default coffeescript always returns the last line/variable, so there is no need to use the ~return~ keyword, there is no need for ";" also.

Thank you for your contribution!
I'm not using coffeescript, thus I do really appreciate your effort on this!

No problem!


Update .travis.yml

Problem:
Docs did not deploy for v10.1 because the cut command in the deploy script resulted in an incorrectly formatted version number (v10.).
Solution:
I updated the cut command to result in a correctly-formatted string (e.g., v10.1).

Can one of the admins verify this patch?


Simplified for loop for some image manipulation functions

The image manipulation functions ImageColorInvert, ImageColorBrightness, ImageColorReplace, and ImageColorTint all used a nested for loop with some math to index the 1d array of pixels.
These loops could be simplified to a single loop with a counter. I think this is not only more readable, but it has also shown some slight speed increases for very large images. My numbers below using the diff of time.h's clock function for a 7096 x 10031 image:
before:
brightness 0.932933
replace 0.910925
tint 1.116619
invert 0.785766

after:
brightness 0.784316
replace 0.782897
tint 0.934186
invert 0.699755

@Minnowo Nice improvement! Thank you very much!


Misleading error when using read_xxx functions with invalid URLs

I get ERROR:  Function `read_csv(TEXT)` only works with Duckdb execution. when using read_csv (along with the actual error as a warning):
y=# SELECT * from read_csv('https://www.data.gouv.fr/fr/datasets/r/6d186965-f41b-41f3-9b23-88241cc6890c') as (n int);
WARNING:  (DuckDB) HTTP Error: Unable to connect to URL "https://www.data.gouv.fr/fr/datasets/r/6d186965-f41b-41f3-9b23-88241cc6890c": 404 (Not Found)
ERROR:  Function `read_csv(TEXT)` only works with Duckdb execution.
CONTEXT:  PL/pgSQL function read_csv(text) line 3 at RAISE

I would expect the WARNING to be the ERROR and the ERROR to not show.

Once we merge #123 we can use/cache the NeedsDuckdbExecution function and fail with an ERROR instead of WARNING when execution in DuckDB fails. i.e. for queries where NeedsDuckdbExecution returns true there's no point in retrying the query in postgres.


Bug in Windows Forms Apps (.Net 6)

To demonstrate this error, I created a new Windows Forms App with a text box and a button.   After pressing the button the text in the text box is sent using InputSimulatorEx after a 5 Second delay like this:
public partial class Form1 : Form
{
    public Form1()
    {
        InitializeComponent();
    }
    private void btn_send_Click(object sender, EventArgs e)
    {
        Thread.Sleep(5000);
        var text = tb_text.Text;
        InputSimulator sim = new();
        sim.Keyboard.TextEntry(text);
    }
}

Start the app and open a notepad.exe Window to display the text.   Press the button and make notepad the active window.
Single characters work fine, but if my text is longer , only the first few characters of the text appear.   If I start typing in the notepad window the rest of the text shows up.  (Sometimes if I wait long enough it appears too.)
The text appears to be stuck inside a buffer, which somehow needs to be nudged to start pushing out letters again.
Is there a way to do this?   I tried calling SendKeys.Flush() after the TextEntry, but it didn't help.

Answering my own question...
It seems to work if you put a small sleep in between characters.  Like this:
private void btn_send_Click(object sender, EventArgs e)
{
    Thread.Sleep(5000);
    var text = tb_text.Text;
    InputSimulator sim = new();
    foreach (var c in text)
    {
        sim.Keyboard.TextEntry(c);
        sim.Keyboard.Sleep(1);
    }
}


Registering custom dataset

I am trying to train on my own custom dataset, but there seems to be an issue when trying to register the dataset for detectron2. I have already written files in the det/yolox/data/datasets folder, the /ref folder, added it to the dataset_factory.py file and wrote a config file for the dataset.
The error I get looks like this:
[0329_144020 det.yolox.engine.yolox_setup@121]: Full config saved to /home/faps/GDRNPP_pose_est/pose_est_gdrnpp/output/yolox/bop_pbr/yolox_x_640_augCozyAAEhsv_ranger_30_epochs_Stator_test/config.yaml
[0329_144020 det.yolox.engine.yolox_setup@125]: seed: -1
[0329_144020 d2.utils.env@41]: Using a generated random seed 21122847
[0329_144020 det.yolox.engine.yolox_setup@146]: Used mmcv backend: cv2
[0329_204020@Stator_test:411] DBG register dataset: Stator_train
ERROR [0329_144020 d2.engine.launch@84]: An error has been caught in function 'launch', process 'MainProcess' (430301), thread 'MainThread'<PHONE_NUMBER>54048):
Traceback (most recent call last):

  File "./det/yolox/tools/main_yolox.py", line 77, in <module>
    args=(args,),
          -> Namespace(config_file='configs/yolox/bop_pbr/yolox_x_640_augCozyAAEhsv_ranger_30_epochs_Stator_test.py', dist_url='tcp://127....

> File "/home/faps/anaconda3/envs/GDRNPP/lib/python3.7/site-packages/detectron2/engine/launch.py", line 84, in launch
    main_func(*args)
    |          -> (Namespace(config_file='configs/yolox/bop_pbr/yolox_x_640_augCozyAAEhsv_ranger_30_epochs_Stator_test.py', dist_url='tcp://127...
    -> <function main at 0x7f4852409440>

  File "./det/yolox/tools/main_yolox.py", line 50, in main
    cfg = setup(args)
          |     -> Namespace(config_file='configs/yolox/bop_pbr/yolox_x_640_augCozyAAEhsv_ranger_30_epochs_Stator_test.py', dist_url='tcp://127....
          -> <function setup at 0x7f49782177a0>

  File "./det/yolox/tools/main_yolox.py", line 43, in setup
    register_datasets_in_cfg(cfg)
    |                        -> {'train': {'output_dir': '/home/faps/GDRNPP_pose_est/pose_est_gdrnpp/output/yolox/bop_pbr/yolox_x_640_augCozyAAEhsv_ranger_30...
    -> <function register_datasets_in_cfg at 0x7f4852400680>

  File "/home/faps/GDRNPP_pose_est/pose_est_gdrnpp/det/yolox/tools/../../../det/yolox/data/datasets/dataset_factory.py", line 106, in register_datasets_in_cfg
    assert "DATA_CFG" in cfg and name in cfg.DATA_CFG, "no cfg.DATA_CFG.{}".format(name)
                         |       |       |                                         -> 'Stator_test'
                         |       |       -> {'train': {'output_dir': '/home/faps/GDRNPP_pose_est/pose_est_gdrnpp/output/yolox/bop_pbr/yolox_x_640_augCozyAAEhsv_ranger_30...
                         |       -> 'Stator_test'
                         -> {'train': {'output_dir': '/home/faps/GDRNPP_pose_est/pose_est_gdrnpp/output/yolox/bop_pbr/yolox_x_640_augCozyAAEhsv_ranger_30...

AssertionError: no cfg.DATA_CFG.Stator_test

Is there a step I am missing to register the dataset?
Thank you for your help!

Hello, I also encountered the same problem, how did you solve it? @Martin9797

@Yuan-TS If you haven't figured it out already, I have gotten past this error by doing a few things.

Add a file to the ref folder for your dataset, I just called mine custom.py. I copied over one of the other datasets ref files and replaced the info with my datasets info. also add this file to init.py in ref
In core/gdrn_modeling/datasets I copied one of the dataset files here, and again switched out all the info with my datasets info
in core/gdrn_modelling/datasets at the top of dataset_factor.py import my new custom dataset file created in 2, and add the name to _DSET_MOD_NAMES


Made Faq display

Fixed issue #430

Before faq page were hidden by contact us form, I have fixed it

YES


Option for change default response

Hello, I know that when I send request for not existing endpoint so I gain 400 Bad request error response.
But what to do when I want to have some another default response? For example 404 Not found?
Exists some option which can change what DeepfakeHTTP return when the endpoint doesn't exists?

Hi!
I think I will add a command-line option, for custom status code when the request is not found.
Thanks!
P.S.
By the way, I added a special option for JSON soft comparison (like you wanted):
 "customers": {
        "123": {"fname": "John", "lname": "Doe", "email"<EMAIL_ADDRESS><EMAIL_ADDRESS>        "456": {"fname": "Lora", "lname": "Corban", "email"<EMAIL_ADDRESS><EMAIL_ADDRESS>        "789": {"fname": "Ted", "lname": "Brown", "email"<EMAIL_ADDRESS>    }

 "customers": {
        "456": {"email"<EMAIL_ADDRESS><EMAIL_ADDRESS>"fname": "Lora", "lname": "Corban",},
        "123": {"fname": "John", "lname": "Doe", "email"<EMAIL_ADDRESS><EMAIL_ADDRESS>        "789": {"fname": "Ted", "lname": "Brown", "email"<EMAIL_ADDRESS>    }

will be interpreted as equals.
This feature (soft JSON comparison) will be present in the nearest release.

Oh thank you very much. ;-)

release v1.0.15 contains the features described above.

Are you not using semantic versioning? https://semver.org
MAJOR.MINOR.PATCH for versioning of your application?
If this new things are features and not only bugs so it should be increased MINOR number in your version instead of PATCH.
So new version should be v1.1.0 or not?

I didn't know about that :(
From the next version I will switch to this versioning system.
Thanks for the tip!

implemented in v1.0,15


Sort messages via file containers

This should make the internals a bit cleaner, and it has no performance regressions at all

Alright, the implementation is done. Also fixed some bugs that were introduced by recent PRs


Arbitrary param on the route forces me to inform this same param on the test

Hi guys,
given that I have a route like this:
get "/bla", to: "bla#index", some_arbitrary_param: "AA"

Then I have to specify some_arbitrary_param on my spec, like this:
get :index, some_arbitrary_param: "AA"

If I don't specify, I get the following error:
Failure/Error: get :index
     ActionController::UrlGenerationError:
       No route matches {:action=>"index", :controller=>"bla"}
     # /Users/me/.rvm/gems/ruby-2.3.1@rspec-test-project/gems/actionpack-4.2.0/lib/action_dispatch/journey/formatter.rb:46:in `generate'
     # /Users/me/.rvm/gems/ruby-2.3.1@rspec-test-project/gems/actionpack-4.2.0/lib/action_dispatch/routing/route_set.rb:710:in `generate'
     # /Users/me/.rvm/gems/ruby-2.3.1@rspec-test-project/gems/actionpack-4.2.0/lib/action_dispatch/routing/route_set.rb:741:in `generate'
     # /Users/me/.rvm/gems/ruby-2.3.1@rspec-test-project/gems/actionpack-4.2.0/lib/action_dispatch/routing/route_set.rb:736:in `generate_extras'
     # /Users/me/.rvm/gems/ruby-2.3.1@rspec-test-project/gems/actionpack-4.2.0/lib/action_dispatch/routing/route_set.rb:731:in `extra_keys'
     # /Users/me/.rvm/gems/ruby-2.3.1@rspec-test-project/gems/actionpack-4.2.0/lib/action_controller/test_case.rb:205:in `assign_parameters'
     # /Users/me/.rvm/gems/ruby-2.3.1@rspec-test-project/gems/actionpack-4.2.0/lib/action_controller/test_case.rb:616:in `process'
     # /Users/me/.rvm/gems/ruby-2.3.1@rspec-test-project/gems/actionpack-4.2.0/lib/action_controller/test_case.rb:65:in `process'
     # /Users/me/.rvm/gems/ruby-2.3.1@rspec-test-project/gems/actionpack-4.2.0/lib/action_controller/test_case.rb:505:in `get'

The weird thing is that I have access to this arbitrary parameter if I request on my browser, but when it comes to the test, I have to specify it as a parameter.
Do you guys have any idea about why do I have to pass it as a param?

This is a routing resolution issue upstream in Rails, please ask them.


Update cache implementation and remove logic for rbac update

Signed-off-by: Jian Qiu<EMAIL_ADDRESS>

/assign @skeeey

/lgtm

refer to https://github.com/stolostron/backlog/issues/18840


Issue with textInput

<TextInput
placeholder="Comments"
multiline={true}
value={TextValue}
onChangeText={value => setTextValue(value)}
/>

inside ScrollView is not working it just get closed on every tap on the keyboard i have tried different approaches but failed to get the inputs...
automaticallyAdjustContentInsets={true}
keyboardShouldPersistTaps="handled"
keyboardDismissMode="none"

I have tried this options but it doesn't work

and I came to know that this error is occuring due to state updating in onchangetext in your scrollview kindly provide any solution or alternate for it....

hi @wHat0 ,
Can you create a Repo for me to debug to support for you?

Hey Hope you are doing great. Here is the Repo for you.
[https://github.com/wHat0/StateInNestedScrollView]

Hey Hope you are doing great. Here is the Repo for you.
[https://github.com/wHat0/StateInNestedScrollView]

Got it working, ListHeaderComponent={xxx} instead of ListHeaderComponent={() => <>{xxx}} do the trick for me

i am facing the same issue anyone have any solution ?

Yes their are two solution

1st one is instead of
using              onChangeText={(value) => setTextValue(value)}
use             onChangeText={ setTextValue}

Other is to make a separate component of TextInput with its view and get the value from their.

i am facing the same issue anyone have any solution ?

Yes their are two solution
1st one is instead of
using onChangeText={(value) => setTextValue(value)}
use onChangeText={ setTextValue}

Other is to make a separate component of TextInput with its view and get the value from their.

I am also

i am facing the same issue anyone have any solution ?

Yes their are two solution
1st one is instead of
using onChangeText={(value) => setTextValue(value)}
use onChangeText={ setTextValue}

Other is to make a separate component of TextInput with its view and get the value from their.

I am facing this issue as well, could you be more specific on how you solved it? Thanks in advance


Tests fail when not using bundle

disclaimer: I'm not a Ruby expert :smiley:
Just checked out the source code from the repository, switch to the v2.3.3 tag and tried running the tests using my distro's gems (Fedora 36), the first problem I found was:
An error occurred while loading ./spec/cli_spec.rb.
Failure/Error:
  it 'should convert the chronicles example', cli: true, visual: true, unless: (Gem.loaded_specs['rouge'].version < (Gem::Version.new '2.1.0') && !Gem.loaded_specs['rouge'].nil?), &(proc do
    out, err, res = run_command asciidoctor_pdf_bin, '-D', output_dir, (example_file 'chronicles-example.adoc')
    (expect res.exitstatus).to be 0
    (expect out).to be_empty
    (expect err).to be_empty
    reference_file = File.absolute_path example_file 'chronicles-example.pdf'
    (expect output_file 'chronicles-example.pdf').to visually_match reference_file
  end)

NoMethodError:
  undefined method `version' for nil:NilClass

      it 'should convert the chronicles example', cli: true, visual: true, unless: (Gem.loaded_specs['rouge'].version < (Gem::Version.new '2.1.0') && !Gem.loaded_specs['rouge'].nil?), &(proc do
                                                                                ^^^^^^^^
# ./spec/cli_spec.rb:102:in `block (2 levels) in <top (required)>'
# ./spec/cli_spec.rb:92:in `block in <top (required)>'
# ./spec/cli_spec.rb:5:in `<top (required)>'
Run options: include {:cli=>true}

It would seem rouge is not loaded even though is present in the system, I believe bundle is loading the gems it downloads, but anyway, I think this could be handle by either requiring rouge in the spec helpers or checking for the case whether Gem.loaded_specs returns nil. Something along these lines:
diff --git a/spec/cli_spec.rb b/spec/cli_spec.rb
index fe661ccb..8d3f67b8 100644
--- a/spec/cli_spec.rb
+++ b/spec/cli_spec.rb
@@ -99,7 +99,7 @@
       (expect output_file 'basic-example.pdf').to visually_match reference_file
     end

-    it 'should convert the chronicles example', cli: true, visual: true, unless: Gem.loaded_specs['rouge'].version < (Gem::Version.new '2.1.0'), &(proc do
+    it 'should convert the chronicles example', cli: true, visual: true, unless: (!Gem.loaded_specs['rouge'].nil? and Gem.loaded_specs['rouge'].version < (Gem::Version.new '2.1.0')), &(proc do
       out, err, res = run_command asciidoctor_pdf_bin, '-D', output_dir, (example_file 'chronicles-example.adoc')
       (expect res.exitstatus).to be 0
       (expect out).to be_empty

After adding this small workaround, I found that the cli test set was failing, I'm assuming bundle does something else here, like installing (or simulating the installation) of the gem from source code.
So I decided to disable running the cli examples,  but found that the first one, the one in the Packaging context doesn't include the flag cli: true
  context 'Packaging' do
    it 'should install bin script named asciidoctor-pdf' do
      bin_script = (Pathname.new Gem.bindir) / 'asciidoctor-pdf'
      bin_script = Pathname.new Gem.bin_path 'asciidoctor-pdf', 'asciidoctor-pdf' unless bin_script.exist?
      (expect bin_script).to exist
    end
  end

Shouldn't this one also be include in the set cli ? it'd be helpful so it would be skipped by adding -t ~cli.
I'm willing to provide PRs, with some guidance :wink:
Thanks!

This project is set up to use Bundler for development. I'm not interested it in working a different way (as it's already hard enough to keep all the tests passing on every version and platform of Ruby we support).
The instructions in https://github.com/asciidoctor/asciidoctor-pdf/blob/main/CONTRIBUTING-CODE.adoc explain how to set up the project to run the tests. If something in those instructions aren't working, I'm happy to update them.

Hey @mojavelinux thank you for your reply, I understand your point about bundler. About the Packaging test, does it make sense to add it to the group cli ?

Shouldn't this one also be include in the set cli ? it'd be helpful so it would be skipped by adding -t ~cli.

The "cli" flag is intended for tests that invoke the CLI (using run_command). Technically, this test is only checking that it's there.

The gems that are required to run the test suite are listed in Gemfile. Specifying them in the gemspec does not give us enough flexibility for matrix testing. But it doesn't make them optional. And rouge is one of those gems listed.
However, I can see that it would be nice to be able to run the test suite without rouge installed, like we do with pygments.rb. So I'll set it up the same way so it's not required.

It should now be possible to run the tests without using bundle if you install then necessary prerequisite packages listed here: https://github.com/asciidoctor/asciidoctor-pdf/blob/main/CONTRIBUTING-CODE.adoc#prerequisites


Restrict access to APIs for requests that uses token "name": "authorization_code"

Restrict access to APIs for requests that uses token "name": "authorization_code"

@PavelVesnin - with token M2RhcHEvc3BTaVdqZGZDNEk4cUlLdz09 (expired to 2017/12/28, token name = authorization_code) am successful call APIs. Need restrict.
test curl get legal_entity - now return 200
curl -X GET \   https://dev.ehealth.world/api/legal_entities \   -H 'api-key: Z09EWXlGTkZnT05saVVZT0RBWDhudz09' \   -H 'authorization: Bearer M2RhcHEvc3BTaVdqZGZDNEk4cUlLdz09' \   -H 'cache-control: no-cache' \   -H 'postman-token: 1e43c228-d184-693b-b22b-c1d1ca5175ca'

@EdwardVoloshin deployed

Tested successful manually with postman for 2 cases: 2FA enable & 2FA disable.


Remove docker caching from CI

Similar to in our Rails and Nest templates, this seems to slow CI down, so it's probably quicker not to use a cache
The branch this commit is on was originally branched off renovate/node-20.x for the purpose of comparison. CI had been run on that branch multiple times, but the "Run actions/cache@v3" step couldn't find a matching cache for whatever reason. It spends almost three minutes building that cache at the end of each test CI job run. The first run of this branch was - expectedly - about three minutes quicker than the reference branch (6m13s vs 3m25s)
https://github.com/dxw/rails-template/commit/1f78864444f22c4ae4372a7a584fda1e55dba88f
https://github.com/dxw/nest-template/commit/75890e11aad58773fdd0330b2796391fba5bfac7

@renovate stop queue jumping!


Add MutatingWebhookConfiguration and ValidatingWebhookConfiguration t…

…o default Map.yaml

Ping @hickeyma Can you please review this PR ?

Ping @hickeyma Can you please review this PR ?

Closing as APIs are not part of the Helm install order list and APIs can be added if needed using the API Mapping file.


Font family picker

Design

All good. Only one small thing is for the mobile version,
Can we please have the black stroke for active status as well? Thank you!

Is this blank area a bit big?
@Shan-29

Is this blank area a bit big? @Shan-29

@agnuschan This one should be fine since all the open boxes for the style tool are the same size, so let's just keep them consistent : )


Sematic Issue Xcode 13

Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description
Please provide a clear and concise description of what the bug is. Include screenshots if needed.
Please test using the latest React Native release to make sure your issue has not already been fixed: https://reactnative.dev/docs/upgrading.html
Created a fresh new project using  npx react-native init myproject and opened the myproject.xcworkspace in Xcode 13. While Swift Conversion to Swift 5 I get Semantic Issue in RCT-Folly as follow: Typedef redefinition with different types ('uint8_t' (aka 'unsigned char') vs 'enum clockid_t') inside Time.h file
React Native version:
Run react-native info in your terminal and copy the results here.
System:     OS: macOS 12.0     CPU: (8) x64 Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz     Memory: 45.39 MB / 8.00 GB     Shell: 5.8 - /bin/zsh   Binaries:     Node: 15.14.0 - ~/.nvm/versions/node/v15.14.0/bin/node     Yarn: 1.23.0-20200928.1349 - ~/.yarn/bin/yarn     npm: 7.7.6 - ~/.nvm/versions/node/v15.14.0/bin/npm     Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman   Managers:     CocoaPods: 1.11.2 - /usr/local/bin/pod   SDKs:     iOS SDK:       Platforms: iOS 15.0, DriverKit 20.4, macOS 11.3, tvOS 15.0, watchOS 8.0     Android SDK:       API Levels: 28, 29, 30       Build Tools: 28.0.3, 29.0.2, 29.0.3, 30.0.2, 30.0.3       Android NDK: Not Found   IDEs:     Android Studio: Not Found     Xcode: 13.0/13A233 - /usr/bin/xcodebuild   Languages:     Java: 15.0.1 - /usr/bin/javac   npmPackages:     @react-native-community/cli: Not Found     react: 17.0.2 => 17.0.2      react-native: 0.66.0 => 0.66.0      react-native-macos: Not Found   npmGlobalPackages:     *react-native*: Not Found
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

npx react-native init myproject
open myproject.xcworkspace in Xcode 13 and start the conversion to Swift 5

Expected Results
Describe what you expected to happen.
Convert the project
Snack, code example, screenshot, or link to a repository:
Please provide a Snack (https://snack.expo.io/), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
You may provide a screenshot of the application if you think it is relevant to your bug report.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

@zoolle Thanks for filing this. I am seeing this as well. Curious if you're aware of how to prevent this from happening?
Is swift 5 conversion necessary or can be disabled through flags?
Thanks

@zoolle Xcode 13.1 is about to get released to support ios 15.1 although does not guarantee this will work.
FYI I am not bothering with changing everything (including appdelegate, etc) into swift although that is documented at this point.

 Thank you for the solution!


WAL file-name sanitization

We should probably allow only [a-zA-Z0-9], special-case convert / to -, and escape everything else via URL encoding.
E.g., go allows null bytes in strings, dots, etc.

It was resolved in the initial PR #648 by removing . and \u0000.


Gamepads without a native map incorrectly handled on MacOS

As reported by @diesellaws via Discord, on MacOS, gamepads without a native/inbuilt mapping are being handled incorrectly.
I should be able to author a patch myself but in case Juju gets to it first.. ;-]

Kill https://github.com/JujuAdams/Input/blob/dev/scripts/__input_gamepad_find_in_sdl2_database/__input_gamepad_find_in_sdl2_database.gml#L120-L125

Flag inbuilt mapping (gamepad_get_mapping(index) != "") && (gamepad_get_mapping(index) != "no mapping") here (before wiping)
https://github.com/JujuAdams/Input/blob/dev/scripts/__input_class_gamepad/__input_class_gamepad.gml#L113

Skip this fix if no inbuilt mapping
https://github.com/JujuAdams/Input/blob/dev/scripts/__input_class_gamepad/__input_class_gamepad.gml#L134-L139

I can't remember why we're doing this? Maybe left over from when we were feeling more cautious about our ability to appropriately clear GM's internal mapping
👍
GameMaker... I swear...

bonk https://github.com/JujuAdams/Input/commit/b2aed4816163bb7a074be5ba360763c463e707c0

Confirmed fix in https://github.com/JujuAdams/Input/commit/b2aed4816163bb7a074be5ba360763c463e707c0


get rid of compile.Custom and turn TypeSplitter and FieldCutter into Zed query operators

In Zed commit dc82704, I've verified the first take at the explode operator that was introduced in the linked PR. Using the example from #2221, we can break the values out into separate records as long as we specify by and a type name.
$ echo '{responders:|[<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>]|}' | zq -z 'explode responders by ip' -
{value:<IP_ADDRESS>}
{value:<IP_ADDRESS>}
{value:<IP_ADDRESS>}
{value:<IP_ADDRESS>}
{value:<IP_ADDRESS>}
{value:<IP_ADDRESS>}
{value:<IP_ADDRESS>}
{value:<IP_ADDRESS>}

Further enhancements to explode will be tracked in #2221.
Thanks @mccanne!


Set-CsPhoneNumberAssignment: Request Error, Status: NotFound

In accordance to Microsoft's announcement to retire some Skype/Teams cmdlets for phone configuration sometime in April 2022, we started testing the soon-to-be-used cmdlets, but encountered similar errors as mentioned in #8875. The affected user account is licensed and can be retrieved by its SIP address with other cmdlets successfully, e.g. Get-CsOnlineUser or Get-CsOnlineVoiceUser.
Differing from the linked issue, we can't find any typos in the cmdlet's parameter values. In addition, calling the same cmdlet with another SIP address, but keeping other parameter values, works as expected.
The affected user account was licensed for about half an hour on the first try and about two hours on the last try, which usually provided enough time between licensing and follow-up when using the Set-CsUser cmdlet.
Microsoft.Teams.ConfigAPI.Cmdlets.internal\Set-CsPhoneNumberAssignment : The server responded with a Request Error, Status: NotFound
At C:\Program Files\WindowsPowerShell\Modules\MicrosoftTeams\3.1.1\net472\custom\PsExt\Set-CsPhoneNumberAssignment.ps1:41 char:9
+         Microsoft.Teams.ConfigAPI.Cmdlets.internal\Set-CsPhoneNumberA ...
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: ({ Identity = wa...iceEnabled =  }:<>f__AnonymousType82`5) [Set-CsPhoneNumberAssignment_Set], UndeclaredResponseException
    + FullyQualifiedErrorId : NotFound,Microsoft.Teams.ConfigAPI.Cmdlets.Generated.Cmdlets.SetCsPhoneNumberAssignment_Set

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6b911670-8e3f-f86a-90ac-bde691d49e8c
Version Independent ID: 4b1d9835-8e81-d04b-57ec-12a537dbeaeb
Content: Set-CsPhoneNumberAssignment (MicrosoftTeamsPowerShell)
Content Source: teams/teams-ps/teams/Set-CsPhoneNumberAssignment.md
Service: teams-powershell
GitHub Login: @JensTrier
Microsoft Alias: jenstr

@DMoenks thanks for the feedback. Please send me the actual failing cmdlet with the user and the parameters offline at jens.trier AT microsoft.com and I'll have a look.

@JensTrier
Details were provided by email, in addition to results from running Get-CsOnlineVoiceUser for the same user account for comparison

The source of the error was identified in system traces after providing additional details and is currently being investigated. As this error message only occurs semi-sporadically, the issue is closed.

I am having this issue now as well - this was working just 2 weeks ago.
Microsoft.Teams.ConfigAPI.Cmdlets.internal\Set-CsPhoneNumberAssignment : The server responded with a Request Error,
Status: NotFound
At C:\Program
Files\WindowsPowerShell\Modules\MicrosoftTeams\3.1.1\net472\custom\PsExt\Set-CsPhoneNumberAssignment.ps1:41 char:9

    Microsoft.Teams.ConfigAPI.Cmdlets.internal\Set-CsPhoneNumberA ...

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : InvalidOperation: ({ Identity = te...iceEnabled =  }:<>f__AnonymousType82`5) [Set-CsPhon
eNumberAssignment_Set], UndeclaredResponseException
FullyQualifiedErrorId : NotFound,Microsoft.Teams.ConfigAPI.Cmdlets.Generated.Cmdlets.SetCsPhoneNumberAssignment_
Set


GPS coordinates

Hi, I've realised that all GPS coordinates (latitude, longitude) in the gps_post_process.csv files seem to be somewhere around 0.764, -1.387, which is somewhere in the middle of the ocean. Once you plot them however, the trajectory looks just like the ones described in the website. I assume that these coordinates must have their reference coordinate, and describes how far away they are from that point. Can I ask where the origin might be please?

They're in radians.


TOOLS mode fails on retries

[X] This is actually a bug report.
[X] I am not getting good LLM Results
[ ] I have tried asking for help in the community on discord or discussions and have not received a response.
[ ] I have tried searching the documentation and have not found an answer.

What Model are you using?

[X] gpt-3.5-turbo
[X] gpt-4-turbo
[X] gpt-4
[X] Other (please specify)

Describe the bug
Retries in default TOOLS mode returns null
To Reproduce
I have used an example from the docs but updated to pydantic v2:
client = instructor.from_openai(OpenAI(), mode=instructor.Mode.TOOLS)

class UserDetail(BaseModel):
    name: str
    age: int

    @field_validator("name")
    @classmethod
    def name_must_be_uppercase(cls, name):
        if name.islower():
            raise ValueError("name must be uppercase")
        return name

response = client.chat.completions.create(
    model="gpt-3.5-turbo",
    response_model=UserDetail,
    messages=[
        {"role": "user", "content": "Extract `jason is 12`"},
    ],
    max_retries=2,
)

print(response.model_dump_json(indent=2))

returns:
OpenAI returns null and this raises an error of Invalid JSON
Expected behavior
When using JSON mode, things work as expected and I get
{
    "name": "JASON",
    "age": 12
}

Screenshots
Taken from Langsmith tracing:
TOOLS mode:

JSON mode:

Interesting, I wonder if GPT-3.5 is regressing.
can you try
    @field_validator("name")
    @classmethod
    def name_must_be_uppercase(cls, name):
        if name.islower():
            raise ValueError("name must be uppercase, please correct this")
        return name

i.e., just prompting the error message to be a little bit more explicit in fixing the response.

 Use the tool again but modify the name argument to 'JASON'.")
        return name

response = client.chat.completions.create(
    model="gpt-3.5-turbo-1106",
    response_model=UserDetail,
    temperature=0.01,
    messages=[
        {"role": "user", "content": "Extract `jason is 12`"},
    ],
    max_retries=2,
)

I might try making the instruction come from a "user" rather than a "tool" role, but use TOOL mode.
What are the down sides to JSON mode btw? If this works better for me?

OK a small experiment suggests that passing the validation error back manually as a "user" role works better, when still using TOOLS mode.
    response = None
    max_retries = 2
    for i in range(max_retries):
        try:
            print(messages)
            response = await client.chat.completions.create(
                model=model,
                temperature=temperature,
                messages=messages.copy(),
                response_model=response_model,
                max_retries=0
            )
            break
        except InstructorRetryException as e:
            completion: ChatCompletion = e.last_completion
            if client.mode == instructor.Mode.TOOLS:
                response_json = completion.choices[0].message.tool_calls[0].function.arguments
            else:
                response_json = completion.choices[0].message.content
            messages.append({
                "role": "assistant",
                "content": response_json
            })
            messages.append({
                "role": "user",
                "content": str(e)
            })
    if response is None:
        response = response_model.model_validate_json(response_json)

    return response

if you have a moment can you check if our message in retry.py is use or assistant? im surprised maybe we need to improve the prompts.

For mode.TOOLS you use the tool role to pass back the validation error. This is the obvious choice I think.
I wonder if the models are fine tuned to just summarise the function output rather than expecting errors.


OriginClassResolver not properly works in rtl direction.

OriginClassResolver not properly works in rtl direction.

Hi @mohammadhosseinmoradi, Do you mean when you set direction: rtl; in CSS?

Hi, when set direction: rtl; directly in html tag for whole document.
this change works great:
export default function originClassResolvers(placement: Placement | "center") {
  switch (placement) {
    case "top":
      return "origin-bottom";
    case "bottom":
      return "origin-top";
    case "left":
      return "ltr:origin-right rtl:origin-left";
    case "right":
      return "ltr:origin-left rtl:origin-right";
    case "top-start":
    case "right-end":
      return "ltr:origin-bottom-left rtl:origin-bottom-right";
    case "top-end":
    case "left-end":
      return "ltr:origin-bottom-right rtl:origin-bottom-left";
    case "right-start":
    case "bottom-start":
      return "ltr:origin-top-left rtl:origin-top-right";
    case "left-start":
    case "bottom-end":
      return "ltr:origin-top-right rtl:origin-top-left";
    default:
      return "origin-center";
  }
}

export const tailwindcssOriginSafelist = [
  "origin-bottom",
  "origin-top",
  "ltr:origin-right rtl:origin-left",
  "ltr:origin-left rtl:origin-right",
  "ltr:origin-bottom-left rtl:origin-bottom-right",
  "ltr:origin-bottom-right rtl:origin-bottom-left",
  "ltr:origin-top-left rtl:origin-top-right",
  "ltr:origin-top-right rtl:origin-top-left",
];

Thanks for report, I using above your code into the PR #82 and add your is co-author.


Add an ability to pass a dask client to MDIOReader

@markspec thinks that it might be a useful idea to have the ability to pass a Client to MDIOReader.

Not sure if this makes sense. The client is used at the Dask Distributed .compute() or .persist() calls which is a downstream application than MDIO. MDIO makes no such calls it only returns lazy arrays.
@markspec can you elaborate?

@tasansal, makes sense.  Let's close.


l10n get() not as a promise

is there an option to have this not as a promise?

No, we don't have such an option. It is recommended that you use the asynchronous version since it was part of larger changes in #8394. It you really need this to be a synchronous process, you should implement that yourself.

It you really need this to be a synchronous process, you should implement that yourself.

I'm not sure if that could even work, since the l10n files are purposely loaded asynchronously; hence the l10n data cannot be assumed to be immediately available.


New version: PhysiologyAnalysis v0.6.6

Registering package: PhysiologyAnalysis
Repository: https://github.com/mattar13/PhysiologyAnalysis.jl
Created by: @mattar13
Version: v0.6.6
Commit: 3e4ed7fa3b129176047577020f5b0180c7a1e4f1
Reviewed by: @mattar13
Reference: https://github.com/mattar13/PhysiologyAnalysis.jl/commit/3e4ed7fa3b129176047577020f5b0180c7a1e4f1#commitcomment-121201596
Description: Julia package for opening and analyzing electrophysiological data

@JuliaRegistrator register


Update readme.md for docker-compose

Add the following to the yaml, specified in the readme.md
container_name: trailarr
restart: unless-stopped

:tada: This issue has been resolved in version 3.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add packaging specification information

Proposal to get Helm chart to 1.0

While I understand its purpose I think this proposal can bring confusion. E.g. who will decide if a dependency can be not stable? E.g. I see npm packages as a packaging/deployment for JS instrumentation and I do not think we want to go stable before OTLP exporter goes stable.
How about describing that dependencies MUST be stable + a list of exceptions.

While I understand its purpose I think this proposal can bring confusion. E.g. who will decide if a dependency can be not stable? E.g. I see npm packages as a packaging/deployment for JS instrumentation and I do not think we want to go stable before OTLP exporter goes stable.
How about describing that dependencies MUST be stable + a list of exceptions.

I am trying to try a distinction between dependencies and components, but they are similar. My point here is that GDI packaging repositories may go stable independently from binaries they contain. Right now, this applies to Helm, Operator, Ansible, Puppet, and Heroku.


NoSuchMethodError after entering prompt

Thanks for this cool dart command line app for ChatGPT. Unfortunately, I'm getting the error below after I enter a prompt.
I installed the app and entered my API key when prompted. When I run the command:
$ ❯ dart run bin/terminalgpt.dart
I see a welcome message followed by "What would you like to ask tGPT?". When I enter a prompt ("how do i install flutter on Macos") I see:
Input:How do I install flutter on Macos

Chat History: 0
✓ Calling OpenAI API... (0.2s)

Error calling the OpenAI API: NoSuchMethodError: The method '[]' was called on null.
Receiver: null
Tried calling: [](0)

MacOS Ventura 13.0.1
Dart SDK version: 2.19.2 (stable) (Tue Feb 7 18:37:17 2023 +0000) on "macos_x64"

hey thanx for submitting the issue.
I was able to reproduce the issue on my side. On my side it was due to invalid api key. Try updating your api key through following comand,
> tgpt -u

I also updated some error handling around the code, so actual issues that caused this error should be shown properly now in terminal. Make sure to pull latest updates first.

Let me know if that helps, else I'm active rn so you can respond here with your results.

btw, any suggestions from ur side to improve this would be helpful. I've plans to add search feature to look up previous chat history but not sure if that would be something suited for teminal experience.

Excellent! Got an informative error message (I think I must have gotten the API from a non-paid account):
Error occured: Exception: {message: You exceeded your current quota, please check your plan and billing details.,
type: insufficient_quota, param: null, code: null}

Awesome! Glad that helped🙌


Avoid --find-links in wheel jobs

Description
Contributes to https://github.com/rapidsai/build-planning/issues/69.
Proposes a stricter pattern for passing a libkvikio wheel from the wheel-build-cpp job that produced it into the wheel-build-python job wanting to use it (as a build dependency of kvikio). This change improves the likelihood that issues with the libkivkio wheels will be caught in CI.
Notes for Reviewers
See https://github.com/rapidsai/rmm/pull/1586 and https://github.com/rapidsai/build-planning/issues/69#issuecomment-2174556118 for details on how I tested this approach.
I didn't propose this on #369 because I hadn't quite finished testing the approach yet. But I do think we should do this for all of the C++ wheels (https://github.com/rapidsai/build-planning/issues/33).

/merge


unable to reference hyperlinks for files

Hi. i am referencing files running on network shares
example
report1 [[click here|file://\<IP_ADDRESS>\reports\report 1.pdf]]
(even if rename it and remove the spaces; still doesn't work
or if i reference a locally stored file like so:
Click here [[Report|file://C:\Downloads\Report.pdf]] to see the latest report.
always fail.
i am only able to reference http links but i need to reference files.
is there a way i can achieve this.
(please note, if i run the wiki as a flat file without going through the web server, i don't have an issue. only when i run on the server using the EXE provided here)
hope i have given you enough information
thanks a lot

I am running on windows. Sorry should have mentioned it earlier.

Due to differences in how opening a single html file and using a server work Bob (and the normal tiddlywiki node server) doesn't have the same access to the file system that an html wiki has.
There is some documentation in control panel -> Bob Settings -> Bob documentation -> Serving files, you can see the tiddler here also: https://github.com/OokTech/TW5-Bob/blob/master/Documentation/Serving Files.tid
The documentation needs some work, but the main thing is you have to set the root folder that is being served and then things inside that folder are available. But this isn't accessing your file system directly, it is accessing it through a server, so the files are served on urls.


Update License tab with name OPNcell

License tab references pre-release name.

The release name has been changed from Cellular to OPNcell, in the License tab


fix(base.scss): enable -moz-focus-inner on buttons

We disabled -moz-focus-inner for a reason a while back, but I can't recall what the reason was. I removed that CSS and tested in Firefox and everything looks OK to me. Please give everything a good look and focus on buttons and make sure nothing breaks :)
fixes https://github.com/patternfly/patternfly-next/issues/1023

Deploy preview for pf-next ready!
Built with commit 8850ccbcf80eedba549562f21d757b748ec4287c
https://deploy-preview-1377--pf-next.netlify.com


Add instructions for Windows installation

The instructions focus on the installation using the Windows Subsystem Linux.

I just encountered a crash of the node, I am unsure if this is due to WSL or would be happening on a normal Linux system as well, did give the information to the other devs, we will eventually look into it.

I just encountered a crash of the node, I am unsure if this is due to WSL or would be happening on a normal Linux system as well, did give the information to the other devs, we will eventually look into it.

I ran into multiple issues which I'm in the process of dissecting. Unsure whether that's Windows specific.

I updated the PR as requested.

I didn't tested it on Windows. Only the ubuntu bash script.

@dincho @thepiwo Any other feedback?

@dincho I incorporated your feedback.

@dincho I incorporated your feedback.

Thanks you got 👍 from me.

@thepiwo @dincho How can the CI builds be triggered? They are shown as required.

@thepiwo @dincho How can the CI builds be triggered? They are shown as required.

Don't worry. I don't think the changes needs the automated testing.


Revert "[Pipenv] Python package dependency handling: with bugfixes and stricter package control"

Reverts axa-group/Parsr#270

What happened (I mean, why was the revert needed) ?

What happened (I mean, why was the revert needed) ?

Our CI is not working properly with pipenv.
We will fix it soon.


The secrets and client certificates section should be removed and instead reference Azure.Identity

[Enter feedback here]
An API that calls another API in azure should use ManagedIdentity, anything else is disingenuous according to the Azure.Identity team/package.
Please remove these references and put down a realistic example of API calling API via managed identity.
The example here would appear not to be best practice.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2fc5b4a3-0d85-102b-8b4c-8dfdd664b2d8
Version Independent ID: 13086ddd-1cf0-a8ca-46f2-588e59734122
Content: Configure a web API that calls web APIs - Microsoft Entra
Content Source: articles/active-directory/develop/scenario-web-api-call-api-app-configuration.md
Service: active-directory
Sub-service: develop
GitHub Login: @jmprieur
Microsoft Alias: jmprieur

@jackawatts

do you have the link/reference to the statement from the Azure.Identity team/package? I would like to review it?
how would you use Managed identity to call a downstream web API on behalf of the user?

Hi @jmprieur

do you have the link/reference to the statement from the Azure.Identity team/package? I would like to review it?
https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/overview-for-developers?tabs=portal%2Cdotnet

specifically:

Azure resources with managed identities support always provide an option to specify a managed identity to connect to Azure resources that support Azure Active directory authentication. Managed identities support makes it unnecessary for developers to manage credentials in code. Managed identities are the recommended authentication option when working with Azure resources that support them. Read an overview of managed identities.

how would you use Managed Identity to call a downstream web API on behalf of the user?
When using Managed Identity API1 would be calling API2 on behalf of itself.  The consumer of API1 would be irrelevant (ie just a concern of API 1 not API 2)

To be specific, the documentation at least from an MI perspective seems to indicate it can be used to access AzureSQL, KeyVault and a number of other services.  It appears the GraphAPI was relatively recently added and in that case we would be calling Graph as API1 (in the example above) just like those other cases, eg KeyVault etc.
Just as sometimes as there is a requirement to access a secret from KeyVault not on behalf of the user, it could be imagined that a developer might want to call an Azure Function or App Service as itself.  (I believe API Management may have some precedent for that?)  but something as heavy duty as API management is not required, and instead just 1 or more automated processes accessing backend APIs as itself?

Closing as managed identity is only useful for the client credentials flow (Daemon apps), that is, in this case web APIs calling downstream web APIs on behalf of themselves. We'll add MSI to the daemon scenario.
This is still useful to have certificates or client secrets or client assertions to call downstream web APIs on behalf of a user.

#please-close


Change loader component to not use Math.random

Loader component causes issues when its rendered server side. See here https://github.com/vegaprotocol/frontend-monorepo/pull/507#discussion_r896528340

Reopened, because there is still some things to improve: let's have one static version with no re-rendes in interval basics on css animation only


/* */ Comments in source Sass files are not closed correctly

/* */ Comment statements in source Sass files are not closed correctly in the output CSS when output-style is either 'compact' or 'compressed'
OS: Windows
CLI:
node-sass style/scss/main.scss style/css/main.css --source-map true --output-style compact

The following Sass:
/**
 * Comment
 */
.foo
{
  display:block;
}

Outputs the following CSS:
/** This is global comment before a class statement /
.foo { display: block; }

/*# sourceMappingURL=main.css.map */

Please note the missing * before the closing / of the comment in the CSS.

Apologies. Output CSS should read:
/** Comment /
.foo { display: block; }

/*# sourceMappingURL=main.css.map */

This has been fixed in Libsass 3.2.0 (https://github.com/sass/libsass/pull/1137) and will be<EMAIL_ADDRESS>

Brilliant - any idea when<EMAIL_ADDRESS>will be available?

Ideally this week. There are some outstanding PRs and issues that need to be resolved first.

Fixed in 3.0.0.


nuxt generate static calls asyncData with firebase serve

First off, thanks @danielroe for the PR to close issue #9734.
I fired up the repro that I shared and it worked for the edge cases with "&", and while serving via npx nuxt serve works, but on using firebase on my main app to serve firebase serve, still calls asyncData after the pages are generated - same issue #9734 for brand names with "&".
Versions

nuxt-edge: 2.16.0-27184333.6f94b1f9

Reproduction
https://github.com/gabrielsze/nuxtStaticTest
Steps to reproduce

run npm run generate
Instead of immediately serving via npx nuxt serve, do a firebase init, create a dummy firebase project, and once the firebase setup is done, run firebase serve
fire up localhost:5000
console log happens for Mixed Grill & Greens and The Coffee Bean & Tea Leaf

What is Expected?

asyncData should not be called on the client-side
nuxt-edge should have fixed this case in PR #9739

What is actually happening?

asyncData is console logging on generated pages when using firebase serve for routes with "&".

We are approaching the Nuxt 2 EOL date (June 30, 2024) - see this article for more information. This is advance warning that I'm going to close this issue then, as it's currently marked as a Nuxt 2 related bug.
If it's a critical or security issue, please do comment and let me know, in case it is possible to address it before the EOL date.
If it's a an issue you think is relevant for Nuxt 3, please feel free to open a fresh issue (or just comment here so I can update labels, etc.). 🙏
Thank you for your understanding and for your contribution to Nuxt. ❤

It's the day, at last. Nuxt 2 is now marked end-of-life.
My apologies we never got round to resolving this bug in the 2.x branch, but we do have to draw a line somewhere. Again, if you think this is still relevant for Nuxt going forward, please feel free to open a fresh issue (or just comment here so I can update labels, etc.). 🙏


is the newest version can use in play 2.2.6?

Hey @caoguangyao,
No. The current versions is not compatible with Play 2.2.6. This is the compatibility matrix:
https://github.com/edulify/play-hikaricp.edulify.com#versions
Thanks.


variants: Introduce a digital-pins array to define digital pin

The d0-gpios node format makes it difficult to handle
digital pin configuration from DTS macros.
Introduce the simple array digital-pins instead of g0-gpios to define digital pin
to GPIO port and pin mapping.

Hi, Thanks alot for this PR! The idea here does help in making the code a lot more manageable by using arrays rather than hard coded vairables for each gpio, however build seems to fail :
-- Found devicetree overlay: /home/dhruva/zephyrproject/zephyr/../modules/lib/Arduino-Zephyr-API/variants/arduino_nano_33_iot/arduino_nano_33_iot.overlay
unit address and first address in 'reg' (0x6a) don't match for /soc/sercom@42001800/atecc608a@15
unit address and first address in 'reg' (0xa) don't match for /soc/adc@42004000/channel@10
unit address and first address in 'reg' (0xb) don't match for /soc/adc@42004000/channel@11
unit address and first address in 'reg' (0x12) don't match for /soc/adc@42004000/channel@18
unit address and first address in 'reg' (0x13) don't match for /soc/adc@42004000/channel@19

and also a lot of DT expansion errors that are likely due to some syntax issues. Kindly fix this

I created PR #63.

Hi, Thanks alot for this PR! The idea here does help in making the code a lot more manageable by using arrays rather than hard coded vairables for each gpio, however build seems to fail :
-- Found devicetree overlay: /home/dhruva/zephyrproject/zephyr/../modules/lib/Arduino-Zephyr-API/variants/arduino_nano_33_iot/arduino_nano_33_iot.overlay
unit address and first address in 'reg' (0x6a) don't match for /soc/sercom@42001800/atecc608a@15
unit address and first address in 'reg' (0xa) don't match for /soc/adc@42004000/channel@10
unit address and first address in 'reg' (0xb) don't match for /soc/adc@42004000/channel@11
unit address and first address in 'reg' (0x12) don't match for /soc/adc@42004000/channel@18
unit address and first address in 'reg' (0x13) don't match for /soc/adc@42004000/channel@19

and also a lot of DT expansion errors that are likely due to some syntax issues. Kindly fix this

I created PR #63.

The issue is not only in nano 33 iot but others as well like ble and ble sense:
zephyr/devicetree.h:82:17: error: 'DT_N_S_zephyr_user' was not declared in this scope; did you mean 'DT_N_S_zephyr_user_ORD'?
   82 | #define DT_ROOT DT_N
      |                 ^~~~

Can you try building for each variant locally and check once?

The issue is not only in nano 33 iot but others as well like ble and ble sense:

I couldn't reproduce this issue.
Could you tell me using version and command line?

The issue is not only in nano 33 iot but others as well like ble and ble sense:

I couldn't reproduce this issue with ble and ble sense. Could you tell me using version and command line?

I'm using zephyr sdk 0.15  and using the command:
west build -p -b arduino_nano_33_ble_sense samples/blinky_arduino
ditto same command works on my local main branch so I doubt that this could be an issue related to my zephyr version or wrong command.
Is there some config you have enabled that I maybe missing or some uncommitted changes?

My bad, I had an unclean zephyr repo.
I cleaned up my local and it seems to work ok for nano ble and sense

and I see the errors all over again, can you check?

This PR is require fdea3c9a  change.
I think it should better to track latest develpmenent branch if this repository plans to be a part of zephyrrtos.

@DhruvaG2000
https://github.com/zephyrproject-rtos/gsoc-2022-arduino-core/pull/63#issuecomment-1282454907
Done.

Sorry for the delay, Works on hardware too. merging, Thanks!


Trader-Registration is visible on Trader-List that has no trader results, even if loggend in

The text of the button should be correct or the button should not be visible at all

Test scenario 1:

GIVEN:                  user ist not logged in.
ACT:                      try to find some traders in the desert
EXPECTATION:    in trader overview, you should see the registration button.

Test scenario 2:

GIVEN:                   trader ist logged in
ACT:                       try to find some traders in the desert
EXPECTATION:     in trader overview, you should not see the registration button!


Roll engine b7dd1cdce95a..62acd7a4422f (1 commits)

https://github.com/flutter/engine/compare/b7dd1cdce95a...62acd7a4422f
git log b7dd1cdce95aa5c097ee4f80fb65204e90a2e280..62acd7a4422f725bb6f9c68d1ce64e51110c5015 --no-merges --oneline
62acd7a44 Roll src/third_party/skia d8f79a27b06b..e2439cc929f9 (11 commits) (flutter/engine#9465)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/4947230486691840

Commit queue failed; closing this roll.


Rclone Browser inserting extra folder name in Destination path

Hi,
When I select a source folder to sync to a particular remote folder, an extra /[folder name] is inserted in the Destination path. See the attached screenshot below

Am I doing something wrong ?
Thanks.
Howard

The idea is that you need to select parent folder in remote when uploading folder. So it behaves exactly the same when you select files to upload.
So if you select "local/a.txt" file, and "remote:dst/WebReceipts" folder, it will upload a.txt file to "dst/WebReceipts/a.txt". For folder it would be same - if you select "local/WebReceipts" folder to upload to "remote:dst/WebReceipts", then it will put it inside - to "dst/WebReceipts/WebReceipts".
You need to select only "dst" folder, when uploading folders. Basically always select parent folder where you want to upload file or folder.
If I would made "local/WebReceipts" folder to be uploaded to "dst/WebReceipts". Then you would not be able to select in GUI to upload to /WebReceipts folder if it doesn't exsit. Because destination would look like "remote:" or "remote:/" and it would put contents of "local/WebReceipt/*" inside "/" root folder.

I understand this now. I did not understand this when I first started with Rclone. I think most users might do what I did.
After the initial configuration, I started by creating two folders: laptop and laptopcrypt. In Google Drive, I saw these two empty folders.
I then created a Crypt, designating laptopcrypt as its Parent Folder.
Let's say I then decide to create three folders in laptopcrypt in order to "replicate" certain named folders I have on my laptop, the contents of which I want to encrypt and upload. I then have, as an example:

laptop
laptopcrypt
|
---Folder X
|
---Folder Y
|
---Folder Z

I then 1) select Folder X in Rclone Browser, and 2)  navigate to and select Folder X on my laptop.
Now I will end up with: /laptopcrypt/Folder X/Folder X
The first Folder X in this hierarchy [path] is superfluous.

In this way, a first-time user may not easily understand how to avoid creating the superfluous Folder X, etc.

Now, you say above:
"If I would made "local/WebReceipts" folder to be uploaded to "dst/WebReceipts". Then you would not be able to select in GUI to upload to /WebReceipts folder if it doesn't exsit. Because destination would look like "remote:" or "remote:/" and it would put contents of "local/WebReceipt/*" inside "/" root folder."
Is it not the case that if I select local/WebReceipts folder on my laptop, and that folder does not yet exist in the / folder, then Rclone will first create it, and then upload the contents into it ?
Howard

Yes, it will create /WebReceipts if it does not exit.
If you select folder remote "/dst/W" and then locally select "local/A", I will upload it to "remote/W/A" (creating new one if it doesn't exist yet). If you would select remote "/" and then localy "local/A" I'll upload it to "/A".

This surprised me the first time, too.
Using OP's example, I now remove the added WebReceipts part before running the command because the folder on my remote destination is actually called _WebReceipts (and, obviously, I don't want _WebReceipts/WebReceipts).
The confusing part is that—for me—it is not the expected behavior. With rclone you do
rclone copy /Users/howardm/WebReceipts googledrive:laptop/_WebReceipts

and rclone does not create a _WebReceipts/WebReceipts folder. And indeed, rCloneBrowser calls
rclone copy /Users/howardm/WebReceipts googledrive:laptop/_WebReceipts/WebReceipts

Would adding another checkbox that toggles thig behavior be too much work?

Adding new checkbox is not much work. But maintaining it is. And having more cluttered UI it never a good UI.
Actually if you start from scratch, then this works exactly as you expect. Imagine empty remote. Only place to upload is root /. So you select /, and then press "Upload" and select local/WebReceipts folder. UI will show that it will go to /WebReceipts and that's exactly what you usually want.

Hi,
Isn't some of the confusion here (well, at least my initial confusion) because of these statements at rclone.org:

For copy

Note that it is always the contents of the directory that is synced, not the directory so when source:path is a directory, it’s the contents of source:path that are copied, not the directory name and contents.

If dest:path doesn’t exist, it is created and the source:path contents go there.

And

If you are familiar with rsync, rclone always works as if you had written a trailing / - meaning “copy the contents of this directory”. This applies to all commands and whether you are talking about the source or destination.

And
For sync

It is always the contents of the directory that is synced, not the directory so when source:path is a directory, it’s the contents of source:path that are copied, not the directory name and contents. See extended explanation in the copy command above if unsure.

If dest:path doesn’t exist, it is created and the source:path contents go there.

So a user of Rclone Browser will need to understand this. Perhaps this will have to be "explained" somehow in the UI or instructions.
Howard

Agreed. I will need to improve this in UI.
I was thinking to add text below Source and Destination fields. When you select it, then it will have something like "This will copy src/folderA into remote:dst/whatever/folderA" or similar.

Hi,
Here is something to consider:
These are two scenarios when a user is working with a directory- not a file(s)— and has stipulated the Copy command.
Scenario one:
The user has selected the root directory of Destination and is uploading the contents of a Source directory CVs not previously created.

Note the message displayed.
Scenario two: The user has selected an existent directory in Destination and is uploading the contents of a Source directory into it.

Note: the extra directory in the Destination path should not be created, and a different message displayed.
What do you think ? Is my understanding of Rclone and current Rclone Browser correct ?
Is this doable from a coding perspective ?
Howard

Let's say that you have selected googledrive:laptop/WebReceipts folder in GUI, and then locally you select /Users/howardm/FooBar. Do you want to upload folder FooBar to googledrive:laptop/WebReceipts (so you will have (googledrive:laptop/WebReceipts/FooBar)? Or do you want to contents of FooBar inside googledrive:laptop/WebReceipts folder (like in your 2nd screenshot)? If latter, how do I upload FooBar inside WebReceipts? There is not hing to select in GUI, because FooBar doesn't exist yet. So you will need to type it manually in Destination field. This is the reason why it automatically appends folder name of source to destination field.

Let's say that you have selected googledrive:laptop/WebReceipts folder in GUI, and then locally you select /Users/howardm/FooBar. Do you want to upload folder FooBar to googledrive:laptop/WebReceipts (so you will have (googledrive:laptop/WebReceipts/FooBar)?

Ah, no. Because I'm primarily using Google Drive for backups, I want /Users/howardm/FooBar to go into laptop as a separate directory.

Or do you want to contents of FooBar inside googledrive:laptop/WebReceipts folder (like in your 2nd screenshot)?

No.    :-)
O.K., here are two methods— the first incorrect; the second correct— for my purpose here:

My first inclination— because I was syncing the WebReceipts folder after I had changed (added; deleted) files within over time— was to immediately select the WebReceipts folder. That's the mistake, right ?
Now that I think I understand Rclone and Rclone Browser, the present UI is just fine  :-)
You may perhaps want to consider adding basic instructions and a few examples in a README or an enclosed INSTRUCTIONS file in your installation package.
Cheers.


TypeError: Object ’ has no method 'equals'

Since approximatly https://github.com/substack/quote-stream/commit/d628f907e0e7e88e040e4cd3f818f9b60943ade5, I have been geting the following error:
/pipeline/build/node_modules/brfs/node_modules/quote-stream/index.js:70
                if (rawBuf.equals(multiByteBuffers.lineSeparator)) {
                           ^
TypeError: Object ’ has no method 'equals'
    at DestroyableTransform.write [as _transform] (/pipeline/build/node_modules/brfs/node_modules/quote-stream/index.js:70:28)
    at DestroyableTransform.Transform._read (/pipeline/build/node_modules/brfs/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:172:10)
    at DestroyableTransform.Transform._write (/pipeline/build/node_modules/brfs/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:160:12)
    at doWrite (/pipeline/build/node_modules/brfs/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:326:12)
    at writeOrBuffer (/pipeline/build/node_modules/brfs/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:312:5)
    at DestroyableTransform.Writable.write (/pipeline/build/node_modules/brfs/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:239:11)
    at write (_stream_readable.js:602:24)
    at flow (_stream_readable.js:611:7)
    at ReadStream.pipeOnReadable (_stream_readable.js:643:5)
    at ReadStream.emit (events.js:92:17)
    at emitReadable_ (_stream_readable.js:427:10)
    at emitReadable (_stream_readable.js:423:5)
    at readableAddChunk (_stream_readable.js:166:9)
    at ReadStream.Readable.push (_stream_readable.js:128:10)
    at onread (fs.js:1575:12)
    at Object.wrapper [as oncomplete] (fs.js:466:17)

Seems the apostrophe in this string is the culprit: player’s

getting the same error here with a different string:
....node_modules/brfs/node_modules/quote-stream/index.js:70
                if (rawBuf.equals(multiByteBuffers.lineSeparator)) {
                           ^
TypeError: Object ╳ has no method 'equals'
    at DestroyableTransform.write [as _transform] (....node_modules/brfs/node_modules/quote-stream/index.js:70:28)
    at DestroyableTransform.Transform._read (....node_modules/brfs/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:172:10)
    at DestroyableTransform.Transform._write (....node_modules/brfs/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:160:12)
    at doWrite (....node_modules/brfs/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:326:12)
    at writeOrBuffer (....node_modules/brfs/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:312:5)
    at DestroyableTransform.Writable.write (....node_modules/brfs/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:239:11)
    at write (_stream_readable.js:602:24)
    at flow (_stream_readable.js:611:7)
    at ReadStream.pipeOnReadable (_stream_readable.js:643:5)
    at ReadStream.emit (events.js:92:17)
    at emitReadable_ (_stream_readable.js:427:10)
    at emitReadable (_stream_readable.js:423:5)
    at readableAddChunk (_stream_readable.js:166:9)
    at ReadStream.Readable.push (_stream_readable.js:128:10)
    at onread (fs.js:1575:12)
    at callback (....node_modules/qfnode/node_modules/watchify/node_modules/chokidar/node_modules/readdirp/node_modules/graceful-fs/polyfills.js:207:17)
    at Object.wrapper [as oncomplete] (fs.js:466:17)

did an clean update of my npm packages this morning.

seems to be coming for a brfs sync read to do somehting like this:
var template = fs.readFileSync(__dirname + '/../ractive/explore-matrix-timeseries.html', 'utf8');

when the file contains some utf8 character (tried with ╳, ○)

I am fairly certain this is a node version issue, as rawBuf is a node buffer.  I am running v0.10.xx and there is no Buffer.equals method.
Solution is revert to brfs 1.4.0 or upgrade node.

fixed in 1.0.2

Thanks!


add create_witness and create_committee_member support to governance plugin

Add this 2 commands very similar one with the other. After 1 is done the other is pretty much the same with some small modifications.
Trying to cover all the commands in https://github.com/bitshares/bitshares-core/wiki/private-testnet and with those 2 added we will only need propose_parameter_change to complete.

done at https://github.com/bitshares/gwallet/commit/faef1437956f96cb6bcfbbff4fdec64284200cca


[Event Request] codeunit 426 "Payment Tolerance Management" - OnPutCustPmtTolAmountAfterCalcRemainingAmount

Describe the request
Hello, can you please add a new Event OnPutCustPmtTolAmountAfterCalcRemainingAmount in codeunit 426 "Payment Tolerance Management"?
    local procedure PutCustPmtTolAmount(CustledgEntry: Record "Cust. Ledger Entry"; Amount: Decimal; AppliedAmount: Decimal; CustEntryApplID: Code[50])
    var
.
.
.
        AcceptedTolAmount := Amount + AppliedAmount;
        Number := AppliedCustLedgEntry.Count();

        if AppliedCustLedgEntry.FindSet(true) then
            repeat
                AppliedCustLedgEntry.CalcFields("Remaining Amount");
                OnPutCustPmtTolAmountAfterCalcRemainingAmount(AppliedCustLedgEntry);
                AppliedCustLedgerEntry2 := AppliedCustLedgEntry;
                if AppliedCustLedgEntry."Currency Code" = '' then begin
                    Currency.Init();
                    Currency.Code := '';
                    Currency.InitRoundingPrecision();
                end else
                    if AppliedCustLedgEntry."Currency Code" <> Currency.Code then
                        Currency.Get(AppliedCustLedgEntry."Currency Code");
                if Number <> 1 then begin
                    AppliedCustLedgEntry.CalcFields(Amount);
                    if CustledgEntry."Currency Code" <> AppliedCustLedgEntry."Currency Code" then
                        AppliedCustLedgEntry.Amount :=
                          CurrExchRate.ExchangeAmount(
                            AppliedCustLedgEntry.Amount,
                            AppliedCustLedgEntry."Currency Code",
                            CustledgEntry."Currency Code", CustledgEntry."Posting Date");

    [IntegrationEvent(false, false)]
    local procedure OnPutCustPmtTolAmountAfterCalcRemainingAmount(var CustLedgerEntry: Record "Cust. Ledger Entry")
    begin
    end;

Additional context
We have additional values to calculate the Remaining Amount and need to recalculate it for it's further uses.
Internal work item: AB#546864

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 24468.


Basic JavaScript value serialization

This is an initial implementation of JS value serialization which will be needed to provide JS parameters with log.entryAdded events. To enable us to support deep (i.e. maxDepth > 1) serialization of objects without round-tripping, I've implemented a helper script that does the work on the page itself. This is inspired by ChromeDriver classic's design which is described in https://source.chromium.org/chromium/chromium/src/+/main:chrome/test/chromedriver/docs/run_javascript.md
The new helper script can be found in src/bidiMapper/scripts. The first time it runs, it creates a Serializer that has a map of weak references to objects. At the moment, only basic serialization is implemented. Serialization for objects (including recursion) should be fairly easy to add in follow-up changes.
Most of the rest of the change is plumbing for the PROTO.page.evaluate command to enable test coverage for the serialization script. Notable changes include fixing a race condition during mapper initialization where the BrowsingContextProcessor was missing some attachedToTarget events, and passing CdpClients to Contexts so they can be used for sending Runtime.evaluate calls.

@googlebot I consent.

@googlebot I consent.

LGTM


[Question] What is the payload file content type used for?

What is the payload file content used for in an MSIX, and is it important that the type uses the most accurate value (e.g. image/jpeg for a JPEG, rather than application/octet-stream)?

Thank you for your question. Payload files are all the files specific to your application that are in the msix package, whatever files you need to run your application - javascript files, image files etc.
When the MSIX package is created via makemsix or makeappx we have an internal map that correlates the file extension to its content type and default compression option. For makemsix this is the map https://github.com/microsoft/msix-packaging/blob/c8af99506ffd0c1513fad39cdadfac281723c3e3/src/msix/pack/ContentType.cpp
If you create your MSIX via the AppxPackaging APIs, you can specify your preferred content type and compression option. It doesn't have a huge impact, but we recommend using the most accurate value as possible.

Thanks for the response @anarvekar-msft . We're using the packaging APIs, so I guess my confusion comes from having to specify both a content type and a compression option to IAppxPackageWriter::AddPayloadFile.
Looking at
https://github.com/microsoft/msix-packaging/blob/c8af99506ffd0c1513fad39cdadfac281723c3e3/src/msix/pack/AppxPackageWriter.cpp#L162
I can see several checks for if (contentType != nullptr), so I think we should be fine to pass a nullptr for the contentType param of AddPayloadFile, despite the docs not listing it as an optional param. That would avoid us also having a similar map of filename extension to content type (in order to pass the "correct" content type through to AddPayloadFile). Is that OK?


Lowercase all identifiers

Proposed fix to lowercase all identifier tokens during parsing.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Julio Martinez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


TS writer: fix duplicate data when using multiple chunks

Public-Facing Changes
Fixed a bug in the TypeScript Mcap0Writer where message data would be duplicated between chunks, resulting in quadratic growth.

😮


NIFI-7468 Updated SSLSocketChannel to support TLS 1.3

Description of PR
NIFI-7468 Resolves several issues with SSLSocketChannel handshake processing in order to work with TLS 1.3.
SSLSocketChannel includes custom handling of javax.net.ssl.SSLEngine, which did not respond properly to Post-Handshake Messages in TLS 1.3, described in RFC 8446 Section 4.6.  The SSLSocketChannel.connect() method was clearing stream and application buffers after completing the TLS handshake, resulting in the loss of Post-Handshake messages as well as network packets.  This loss of data resulted in exceptions such Tag mismatch under both TLS 1.2 and TLS 1.3 when using AES-GCM cipher suites.
The SSLSocketChannelSender.close() method was also closing the connected SocketChannel, resulting in SSLSocketChannel being unable to process TLS close notify messages.
NIFI-7468 introduces a private ChannelStatus enum and convenience logging methods to support detailed logging at the TRACE level when necessary.  Logs and exception messages now include both the remote address and remote port number to improve troubleshooting options.
The new SSLSocketChannelTest leverages a TLS server and client using the Netty framework to verify expected behavior for both TLS 1.2 and 1.3.  Unit testing and runtime testing of TLS 1.3 requires either Java 11, or a version of Java 8 with update 272 or higher.
These changes address issues with several processors, including as ListenTCP and PutTCP, as well as Distributed Cache Clients running with TLS.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically main)?

[X] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[X] Have you written or updated unit tests to verify your changes?
[X] Have you verified that the full build is successful on JDK 8?
[X] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Tested with PutTCP/ListenTCP, works smoothly with TLSv1.3. I feel the updated code is more readable, and the trace log statements are a great addition for any future gotchas. I don't have any issues with the code, so I'm a +1.

Thanks for the review and verification @gresockj!

@gresockj Did you test using Java 8 or 11 (or both)?

@gresockj Did you test using Java 8 or 11 (or both)?

Only 11.  I'll try 8 tomorrow

Will test this out

+1, changes look good. I tested this in a 2 node secure cluster with a S2S and PostHTTP and ListenHTTP using RestrictedSSLContext for TLS 1.2 and TLS 1.3 using Java 8 (Zulu  1.8.0_292-b10) and Java 11 (11.0.10+9-LTS) at run time. Also tested PutTCP/ListenTCP with TLS 1.3  and Java 11 (11.0.10+9-LTS).

@exceptionfactory did you say the DistributedMapCacheClient should benefit from this fix?  I just tried a flow with DetectDuplicate using DistributedMapCacheClient configured with a RestrictedSSLContext on TLS 1.3 (Java 11.0.11+9-LTS), and got the following exception:
2021-06-17 06:23:21,952 ERROR [Timer-Driven Process Thread-5] o.a.n.p.standard.DetectDuplicate DetectDuplicate[id=197ce08d-017a-1000-0000-0000344cdf04] Unable to communicate with cache when processing StandardFlowFileRecord[uuid=86078a69-0508-4ef6-897d-35a54a4daf1c,claim=StandardContentClaim [resourceClaim=StandardResourceClaim[id=1623925229794-1, container=default, section=1], offset=74372, length=4],offset=0,name=86078a69-0508-4ef6-897d-35a54a4daf1c,size=4] due to javax.net.ssl.SSLException: Tag mismatch!: javax.net.ssl.SSLException: Tag mismatch!
javax.net.ssl.SSLException: Tag mismatch!
        at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:133)
        at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:349)
        at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:292)
        at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:287)
        at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:122)
        at java.base/sun.security.ssl.SSLEngineImpl.decode(SSLEngineImpl.java:681)
        at java.base/sun.security.ssl.SSLEngineImpl.readRecord(SSLEngineImpl.java:636)
        at java.base/sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:454)
        at java.base/sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:433)
        at java.base/javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:637)
        at org.apache.nifi.remote.io.socket.ssl.SSLSocketChannel.unwrap(SSLSocketChannel.java:662)
        at org.apache.nifi.remote.io.socket.ssl.SSLSocketChannel.read(SSLSocketChannel.java:371)
        at org.apache.nifi.remote.io.socket.ssl.SSLSocketChannelInputStream.read(SSLSocketChannelInputStream.java:46)
        at java.base/java.io.BufferedInputStream.fill(BufferedInputStream.java:252)
        at java.base/java.io.BufferedInputStream.read(BufferedInputStream.java:271)
        at java.base/java.io.FilterInputStream.read(FilterInputStream.java:83)
        at org.apache.nifi.distributed.cache.protocol.ProtocolHandshake.initiateVersionNegotiation(ProtocolHandshake.java:83)
        at org.apache.nifi.distributed.cache.protocol.ProtocolHandshake.initiateHandshake(ProtocolHandshake.java:57)
        at org.apache.nifi.distributed.cache.client.DistributedMapCacheClientService.leaseCommsSession(DistributedMapCacheClientService.java:426)
        at org.apache.nifi.distributed.cache.client.DistributedMapCacheClientService.withCommsSession(DistributedMapCacheClientService.java:489)
        at org.apache.nifi.distributed.cache.client.DistributedMapCacheClientService.getAndPutIfAbsent(DistributedMapCacheClientService.java:172)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
        at org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:105)
        at com.sun.proxy.$Proxy175.getAndPutIfAbsent(Unknown Source)
        at org.apache.nifi.processors.standard.DetectDuplicate.onTrigger(DetectDuplicate.java:183)
        at org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
        at org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1180)
        at org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:214)
        at org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:103)
        at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
        at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
        at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: javax.crypto.AEADBadTagException: Tag mismatch!
        at java.base/com.sun.crypto.provider.GaloisCounterMode.decryptFinal(GaloisCounterMode.java:623)
        at java.base/com.sun.crypto.provider.CipherCore.finalNoPadding(CipherCore.java:1116)
        at java.base/com.sun.crypto.provider.CipherCore.fillOutputBuffer(CipherCore.java:1053)
        at java.base/com.sun.crypto.provider.CipherCore.doFinal(CipherCore.java:941)
        at java.base/com.sun.crypto.provider.AESCipher.engineDoFinal(AESCipher.java:491)
        at java.base/javax.crypto.CipherSpi.bufferCrypt(CipherSpi.java:779)
        at java.base/javax.crypto.CipherSpi.engineDoFinal(CipherSpi.java:730)
        at java.base/javax.crypto.Cipher.doFinal(Cipher.java:2497)
        at java.base/sun.security.ssl.SSLCipher$T13GcmReadCipherGenerator$GcmReadCipher.decrypt(SSLCipher.java:1929)
        at java.base/sun.security.ssl.SSLEngineInputRecord.decodeInputRecord(SSLEngineInputRecord.java:240)
        at java.base/sun.security.ssl.SSLEngineInputRecord.decode(SSLEngineInputRecord.java:197)
        at java.base/sun.security.ssl.SSLEngineInputRecord.decode(SSLEngineInputRecord.java:160)
        at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:110)
        ... 35 common frames omitted

This only occurred once at the very beginning of processing ~100,000 flow files, and with a retry, it was successful.

@gresockj The DistributedMapCacheClientService depends on SSLSocketChannel as seen in the stack trace, so it should also work with TLS 1.3.
Thanks for noting that problem, the updated read() method was incorrect and was not returning a single byte, which ProtocolHandshake.initiateVersionNegotiation() uses to determine status.
I corrected the SSLSocketChannel.read() method and updated one of the unit test methods to exercise the method as well as the read(byte[]) method.

Thanks for the update, @exceptionfactory! This appears to have resolved the issue.

Thanks for confirming the read method changes @gresockj.
@thenatog do you have any additional feedback?

Tested again, nothing more from me. Merging.


Final preparations before 1.0 release

This is the first part of final preparations before 1.0 release
This PR:

adds json_encode function to utils, and allows sending Decimals via .server functions
refactors addrequest to maximize code sharing between btc.py and bch.py
Fixes a bug in decimal conversion when amount is None
Adds new AmountType type, which is Union[int, str, Decimal] - it is used in all amount or fee arguments
In sync code, fallbacks to main event loop if no event loop is found in current thread
Upgrades atomic tipbot example to pyrogram 1.0 and latest SDK changes

Things to also consider changing:

Maybe addrequest and getrequest should be renamed to follow PEP8 and other function conventions, as release 1.0 is breaking anyway

Retrying codecov


Separate themes for separate windows

VSCode Version: 1.5.3
OS Version: Windows 10 Anniversary Update

Symptom
Changing the theme in one VSCode window changes the theme for all open windows.
Steps to Reproduce

Open two or more Visual Studio Code windows (keyboard: CTRL + SHIFT + N)
Change the VSCode theme in one of the windows
Notice that all of the windows change colors

Expected Behavior
Only the current window's theme changes, when changing the theme.
Cheers,
Trevor Sullivan
Docker Captain
Microsoft MVP: Cloud & Data Center Management
https://trevorsullivan.net
https://twitter.com/pcgeek86

#7358 will allow for changing the theme per workspace/folder.

Did this feature not make into a current release?  I'm not seeing the capability.  If is can someone point me to it?  If it's not can it get added to the feature list?
Thank you.
Scott

I'd like to see this too please!

+1
Use case:
1 - When opening different versions of a directory in two different VSCode instances it is easy to lose track of where you are sense VSCode appearances are identical.
2 - Changing the color theme of one instance helps visually remind user where he is at.

https://github.com/Microsoft/vscode/issues/7358#issuecomment-281312985 says it can be configured using Workspace Settings.  At least in the Mac version, access this by a drop-down for User Settings \ Workspace Settings in the top right of the settings page.

Under User Settings select Workspace Settings from the dropdown in the top right hand corner of the screen. Then you can use the key "workbench.colorTheme" to change the theme for that window.


{monitor}az monitor diagnostic-settings: Migrate from codegen V2

Related command

az monitor diagnostic-settings
Description

Using codegen V2 to migrate az monitor diagnostic-settings related cmds.
Testing Guide

History Notes

[monitor] az monitor diagnostic-settings: migrate show, delete, list cmds

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

closed https://github.com/Azure/azure-cli/issues/24438

monitor


Design note dialog buttons

Unstack
Delete note
Consider:

Change order of notes (up/down)
Change first note of stack

Part of #1817


On the user "Bots" page, the should only see bots made by themselves.

Right now users see all bots.
This will probably require a new GraphQL query which filters by user.

Go here for the bots page:

Gr... After trying it out, I think there's been a miscommunication. The story title isn't that great.
Users should be able to see the bots of all users. However, on a user's page, only that user's bots should be shown. So when I go to "Bob23"s page, I should see all of "Bob23's" bots. Previously, this page would show all of the bots by all users, which was just a bug.

Ok, going to fix it


[atip][xwalk-3579] Fix typo in web.py

Impacted TCs num(approved): New 0, Update 1, Delete 0
Unit test Platform: Andriod
Unit test result summary: Pass 1, Fail 0, Blocked 0

@cicili Could you please help review?

LGTM


identical semantics  in different locations（相同的语义在不同位置）

How to handle the case of two identical semantics in different locations？（如何处理两个在不同位置的相同的语义呢？）

VLMaps currently doesn't support instance segmentation so it doesn't distinguish ambiguous goals (e.g. two chairs might share the same semantic labels). In theory, we can apply clustering to separate points with the same labels but we haven't implemented that.


.Net: Function calling to call only one function at a time (parallel_tool_calls = false)

I'm using function calling to call a sequence of native functions. The exact sequence is important but the implemented behavior is the default behavior (if I'm not wrong) and this is implementing parallel_tool_calls = true.
I'm wondering if we can have this property in OpenAIPromptExecutionSettings class. Ideally something like this:
OpenAIPromptExecutionSettings
{
  ParallelToolCalls = false,
  ToolCallBehavior = ...
}

the implemented behavior is the default behavior (if I'm not wrong) and this is implementing parallel_tool_calls = true.

You're correct.
cc: @SergeyMenshykh, for clarity, this is referring to:
https://platform.openai.com/docs/guides/function-calling
"Parallel function calling can be disabled by passing parallel_tool_calls: false in the request. The model will only call one function at a time when parallel function calling is disabled."

I have encountered an issue where it seems i am giving OpenAI a number of similar functions, and it chokes while trying to call them (500 response... mostly...). When curling, if i pass parallel_tool_calls = false, it responds fine with the first function call. I went looking for a way to pass this through SK, and found this ticket saying it's not available yet, so kept looking.
I then came across Extension Data that at least as how i read the docco, indicates that it allows exactly what's wanted, arbitrary other kvps to be passed along to the llm.

Extra properties that may be included in the serialized execution settings

Except it doesn't.
CreateChatCompletionsOptions does not copy it into the ChatCompletionsOptions, which are what gets passed into the serialization for the request. It only seems to actually be used to add diagnostic tags .
Did i entirely misinterpret the docco?

Related issue - https://github.com/Azure/azure-sdk-for-net/issues/45719


Typed Properties are only available in PHP 7.4

The class MultiStepForm uses typed properties which only became available in PHP 7.4. As far as I can tell the composer.json file states compatibility with php: ^7.1.3.
Probably the easiest way to "fix" the issue is to change the compatibility.

I must have forgot to set that appropriately.  I'll address this issue in the next release which should be out in the next few days.  I'll close this issue as soon as it's released so you'll be notified.
Thanks for the heads up.


requirements: Upgrade Django to 4.1

django[argon2]: 4.0.7 → 4.1.2
django-stubs: typeddjango/django-stubs@9bd8aed1e19f9da2c7d3a2879367a40847b57dea → typeddjango/django-stubs@41deee4ec678544b0f2cbb6f3ea54a3a8151109c
django-stubs-ext: typeddjango/django-stubs@9bd8aed1e19f9da2c7d3a2879367a40847b57dea → typeddjango/django-stubs@41deee4ec678544b0f2cbb6f3ea54a3a8151109c
mypy: 0.971 → 0.982

I think we haven't desupported a postgres version since moving to the postgres version not being pinned to the OS version; how do we want to handle the case that an installation has postgres 10 currently while trying to upgrade to this release?
One option could be to have the upgrade tool check if they have a postgres version <= 10 in zulip.conf, and if so, abort and tell the user to upgrade postgres first. (I guess that won't work if you have a remote postgres server; that we'll need to document for the release notes).
Another option could be to run upgrade-postgres for them in that case, under the theory that you're also doing a major upgrade process...

I think we haven't desupported a postgres version since moving to the postgres version not being pinned to the OS version;

We sorta have, in that you could have a remote PostgreSQL server. (I collected a table of relevant versions at #backend > postgres 10 EOL.)
Also missing are instructions for upgrading PostgreSQL for docker-zulip.
Anyway, that question is one of the reasons this is still draft, along with waiting for the Django 4.1.2 release scheduled on Tuesday so we don’t have to pull it from Git. It might be worthwhile to test this on chat.zulip.org until then.

Doing a chat.zulip.org deployment with this now makes sense to me; will do so.

Also missing are instructions for upgrading PostgreSQL for docker-zulip.

Actually, we basically explain this at https://github.com/zulip/docker-zulip#upgrading-from-the-old-galexrtdocker-zulip. The instructions want some tweaks, but should be good enough that IMO we can merge this and polish the documentation later.

Merged, thanks @andersk!