Use a third-party Sendgrid API library

There exists a gem for integrating with Sendgrid's API: sendgrid_toolkit. So let's not rewrite it.
For the existing API integration, this PR represents just a slight improvement in terseness, but it provides a good basis for adding new actions.
SendgridHelper is now SendgridApi, a thin layer that preserves the existing interface whilst using sendgrid_toolkit underneath. This is a minimal change in terms of testing and interface, but we should now be confident enough that we only test that we're using the sendgrid_toolkit API correctly in future.

LGTM.. nice one :+1:


Add Sitemap

add a sitemap to my website for a better SEO

https://discord.com/channels/713647066802421792/1237801933419581523


Too much installed on remote clusters, esp. RBAC resources

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities
To ask questions about how to use Istio, please visit https://discuss.istio.io)
Bug description
The external control plane setup instructions are intended to install as little as possible on the remote cluster (or config cluster), i.e., only what is needed.
In Istio 1.10 the installation on a remote "non-config" cluster installed only the MutatingWebhookConfiguration and nothing else. Since 1.10, however a number of RBAC resources, and the validating webhook have been moved from the base to the istio-dicovery charts. As a result a number of additional resources are now being installed when running the same command:
istioctl install profile=external =>

  MutatingWebhookConfiguration: istio-sidecar-injector-external-istiod
  ServiceAccount: istiod
  Role: istiod
  RoleBinding: istiod
  ClusterRole: istio-reader-clusterrole-external-istiod
  ClusterRole: istiod-clusterrole-external-istiod
  ClusterRoleBinding: istio-reader-clusterrole-external-istiod
  ClusterRoleBinding: istiod-clusterrole-external-istiod
  ValidatingWebhookConfiguration: istio-external-istiod

Some of these resources (e.g., ValidatingWebhookConfiguration) are not needed, period. Others are questionable, and some are also installed by the istioctl x create-remote-secret command, which in addition to creating the remote secret on the control plane cluster, has the side-effect of also creating some of these same resources on the remote cluster:
istioctl x create-remote-secret =>

  ServiceAccount: istio-reader-service-account
  ClusterRole: istio-reader-clusterrole-external-istiod
  ClusterRole: istiod-clusterrole-external-istiod
  ClusterRoleBinding: istio-reader-clusterrole-external-istiod
  ClusterRoleBinding: istiod-clusterrole-external-istiod

On a remote "config" cluster we additionally enable the base component, mostly to enable the Istio CRDs, but are also getting many additional resources, some of which may not all be necessary:
istioctl install profile=external --set components.base.enabled=true (config cluster)

  MutatingWebhookConfiguration: istio-sidecar-injector-external-istiod
  ValidatingWebhookConfiguration: istio-external-istiod
  ValidatingWebhookConfiguration: istiod-external-istiod
  ServiceAccount: istio-reader-service-account
  ServiceAccount: istiod
  ServiceAccount: istiod-service-account
  ClusterRole: istio-reader-clusterrole-external-istiod
  ClusterRole: istio-reader-external-istiod
  ClusterRole: istiod-clusterrole-external-istiod
  ClusterRole: istiod-external-istiod
  ClusterRoleBinding: istio-reader-clusterrole-external-istiod
  ClusterRoleBinding: istio-reader-external-istiod
  ClusterRoleBinding: istiod-clusterrole-external-istiod
  ClusterRoleBinding: istiod-external-istiod
  ConfigMap: istio
  Role: istiod
  Role: istiod-external-istiod
  RoleBinding: istiod
  RoleBinding: istiod-external-istiod
  CustomResourceDefinition: authorizationpolicies.security.istio.io
  CustomResourceDefinition: destinationrules.networking.istio.io
  ...
  CustomResourceDefinition: workloadgroups.networking.istio.io

So the questions are:

Which resources are needed?
How to supress unnecessary charts (e.g., everything but the MutatingWebhookConfiguration in the non-config cluster)?
Should istioctl x create-remote-secret install RBAC resources in the remote cluster, or should that be done by the install?

[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
How was Istio installed?
Environment where the bug was observed (cloud vendor, OS, etc)
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

Context on create-remote-secret behavior: https://github.com/istio/istio/pull/28059

Thanks @stevenctl for the context. I think the reason for creating the resources on the remote cluster may not apply anymore. Now that we install the ingressgatewaymay in a separate later step on remote clusters (using gateway injection), I think it will work fine to just install the the remote cluster first (includes the needed reader service account) and then do the create-remote-secret after that.

After discussing at the last envinronment WG call, I believe these are what should be installed on remote clusters using an external istiod:

install on non-config remote cluster

MutatingWebhookConfiguration: istio-sidecar-injector-<ns>
ServiceAccount: istio-reader-service-account
ClusterRole: istio-reader-clusterrole-<ns>
ClusterRoleBinding: istio-reader-clusterrole-<ns>

install on config cluster

MutatingWebhookConfiguration: istio-sidecar-injector-<ns>
ServiceAccount: istio-reader-service-account
ClusterRole: istio-reader-clusterrole-<ns>
ClusterRoleBinding: istio-reader-clusterrole-<ns>

ValidatingWebhookConfiguration: istio-<ns>
ServiceAccount: istiod
Role: istiod
RoleBinding: istiod
ClusterRole: istiod-clusterrole-<ns>
ClusterRoleBinding: istiod-clusterrole-<ns>

CustomResourceDefinition: authorizationpolicies.security.istio.io
CustomResourceDefinition: destinationrules.networking.istio.io
...
CustomResourceDefinition: workloadgroups.networking.istio.io

istioctl create-remote-secret

<none> # installs no RBAC resources on remote cluster

I think you need the sidecar injector configmap in control plane cluster as well.
I am also not sure why you need the roles:
ServiceAccount: istiod
Role: istiod
RoleBinding: istiod
ClusterRole: istiod-clusterrole-<ns>
ClusterRoleBinding: istiod-clusterrole-<ns>

On the config cluster? Are we creating a kubeconfig that is using that service account somehow? If so it makes sense, I just wasn't sure since we do it a bit differently

@howardjohn

I think you need the sidecar injector configmap in control plane cluster as well.

We don't need it because istiod volume mounts the one on the control plane cluster.

then why is the istio configmap needed? I would expect both or neither?
On Fri, Jun 18, 2021, 1:30 PM Frank Budinsky @.***>
wrote:

@howardjohn https://github.com/howardjohn
I think you need the sidecar injector configmap in control plane cluster
as well.
We don't need it because istiod volume mounts the one on the control plane
cluster.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/33455#issuecomment-864259012, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXJ2ATUXH2BP7PEBF53TTOUFBANCNFSM46YAXJ4Q
.

then why is the istio configmap needed? I would expect both or neither?

The istio configmap is needed because the control plane install is using SHARED_MESH_CONFIG to separate the user-settable values.
Notice that istiod is configured to use the locally mounted istio configmap and the SHARED_MESH_CONFIG environment variable is set to istio. This instructs istiod to merge the values set by the mesh admin in the config cluster’s configmap with the values in the local configmap set by the mesh operator, here, which will take precedence if there are any conflicts
Do you think that both configmaps should be installed on the config cluster, and then it's up to the control plane configuration to use one, both, or neither?

Ah I see. My expectation was when user runs it, they get not configmap in config cluster. If they want to modify settings, they create the configmap with whatever settings they want.
That is what we will do for our product, but one difference is that users don't run istioctl install at all on the remote, so it doesn't make sense to use it to configure the configmap. If they are already using it then maybe it does make sense to just set it as part of istioctl install in the meshConfig section. However, we may want to default to an empty configmap instead of the current settings? Ideally we do that for normal single cluster install actually (with defaults in golang code)

@howardjohn
Both the istio and istio-sidecar-injector configmap charts appear to have a .Values.global.use/supress guard, so I think that adding both to the config cluster charts makes sense. Then, depending on how the external istiod is configured, users can choose to enable or disable one or both of the configmaps on the remote cluster. Maximum flexibility, WDYT?

@howardjohn Is there a way that I can config my istio template to not generated these RBAC e.g. ServiceAccount: istio-reader-service-account?


Feature/geode 7727 1

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[*] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[*] Is your initial contribution a single, squashed commit?

[*] Does gradlew build run cleanly?

[*] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

I have couple questions about this PR. The original JIRA says:

The connection is left hanging (CLOSE-WAIT state). The peers are then unable to establish proper P2P communication later.

Can you clarify what "unable to establish proper P2P communication later" means? If this is the actual bug, it would be nice to write a test that demonstrates how peers later cannot establish communications.
The test included with PR doesn't seem to test this case. It starts a locator and 3 servers. It then uses a test utility to "crash" the 3 servers. It then checks a connection count statistic, but it stops there.
In addition, by crashing the 3 servers, the test is actually causing the locator to detect a network partition and shut itself down. So the test is actually testing a connection count on an object that is no longer really valid or in use.
From my understanding, the connection should already get cleaned up when the peer crashes or closes the connection by a couple of mechanisms:

The writer thread may detect that the connection is closed and clean things up
The membership system will notice a departed member and trigger cleanup of all of the connections to that member.

If there is a bug where we have problems connecting later, maybe it might involve fixing a problem with one of the above mechanisms? By introducing a third way to clean up the connection it seems like we might be introducing more possibilities for race conditions in maintaining the connection state.

Just to describe faulty scenario. In our network configuration, we have proxy between sites. So if some proxy resets connections, sender side will not detect that, because sender thread is terminated after handshake is finished. And there will be no reestablishing of connection, since sender do not know that connection is released.

In our network configuration, we have proxy between sites.

This PR is changing peer-to-peer connections, not client server or WAN connections. Do you have a proxy between peers? Asking because I see other PRs related to WAN proxies.

And there will be no reestablishing of connection, since sender do not know that connection is released.

This is what I'm not quite sure I understand here. I believe when a thread tries to send on this closed P2P socket, it should get an exception and retry, recreating the connection. This seems like what we need to be testing as part of this change - is there actually a problem sending another message if a proxy between the peers closes the socket?

Yes you are right. Proxy is between peers, and after proxy resets connections,  sender connection hangs in CLOSE-WAIT state. After that when sending any message over that connection, there is no exception. So our fix was to detect closing of sender connection.

I thought I would try to write the kind of test I was talking about so I could see this bug reproduce. It did reproduce the issue you described - https://github.com/Nordix/geode/pull/5.
I'm still looking into whether this is going to cause any race conditions, I'm a little worried that the Connection is left in a state of READING during this time, when the writer threads are also modifying the state.

Thanks


Payments UI

Still need to integrate get-fees into the transfer flow and add docs for the admin-payments protocol.


Intermittently getting fatal error: bulkBarrierPreWrite: unaligned arguments

Issue
Intermittently getting "fatal error: bulkBarrierPreWrite: unaligned arguments"
fatal error: bulkBarrierPreWrite: unaligned arguments

goroutine 25 [running]:
runtime.throw({0x198cc6f?, 0x0?})
        C:/Program Files/Go/src/runtime/panic.go:1047 +0x65 fp=0xc0007d2a20 sp=0xc0007d29f0 pc=0xb39225
runtime.bulkBarrierPreWrite(0xc0007d2ab8?, 0x4b?, 0xc000015040?)
        C:/Program Files/Go/src/runtime/mbitmap.go:582 +0x46b fp=0xc0007d2a90 sp=0xc0007d2a20 pc=0xb1578b
runtime.typedmemmove(0x19289a0, 0x1ecb6c70ed2, 0xc0007d2b78)
        C:/Program Files/Go/src/runtime/mbarrier.go:162 +0x45 fp=0xc0007d2ac8 sp=0xc0007d2a90 pc=0xb148e5
inet.af/wf.toFilter0(0xc0001752c0?, 0xc000675ec0, 0xc00072e001?)
        C:/Users/muru/go/pkg/mod/inet.af/wf@v0.0.0-20221017222439-36129f591884/compose.go:104 +0x30c fp=0xc0007d2c58 sp=0xc0007d2ac8 pc=0x16b510c
inet.af/wf.(*Session).AddRule(0xc000282900, 0xc000675ec0)
        C:/Users/muru/go/pkg/mod/inet.af/wf@v0.0.0-20221017222439-36129f591884/firewall.go:691 +0xcb fp=0xc0007d2cf0 sp=0xc0007d2c58 pc=0x16ba48b

When
While calling this function
Go Version
Tried 1.18. 1.19, 1.20
Occurence Frequency
Very random. Couldnt find a pattern.

version is "windows server 2019 data center" and architecture is amd64

Also tried in windows 11 pro / amd64

did it resolved?

I tried to modify the compose. go file line 103-104 by replacing
	ret := (*fwpmFilter0)(a.Alloc(unsafe.Sizeof(fwpmFilter0{})))
	*ret = fwpmFilter0{

with
   //ret := (*fwpmFilter0)(a.Alloc(unsafe.Sizeof(fwpmFilter0{})))
   ret := &fwpmFilter0{

After modifying, I tested it several times and it works fine .
However, I do not know if this modification has any other negative effects because I do not understand the specific meaning of the original code.

I tried to modify the compose. go file line 103-104 by replacing
	ret := (*fwpmFilter0)(a.Alloc(unsafe.Sizeof(fwpmFilter0{})))
	*ret = fwpmFilter0{

with
   //ret := (*fwpmFilter0)(a.Alloc(unsafe.Sizeof(fwpmFilter0{})))
   ret := &fwpmFilter0{

After modifying, I tested it several times and it works fine . However, I do not know if this modification has any other negative effects because I do not understand the specific meaning of the original code.

i did you modification cause i've also find this annoying bug but its giving me this error.
go\src\inet.af\wf\compose.go:104:9: fwpmFilter0 can't be allocated in Go; it is incomplete (or unallocatable) using golang 1.18


Remove dev dep imports in production code run [GitHubIssues GitHubSearch]

Fixes #2876 with @paulmelnikow's suggestion
Moved imports of ServiceTester and createServiceTester to a separate file so that dev dependencies are not imported by service classes

Warnings

:warning:
Lots 'o changes. Skipping diff-based checks.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @calebcartwright!

:book:

Thanks for contributing to our documentation. We :heart: our documentarians!

  Generated by :no_entry_sign: dangerJS against 9a39a16d50c385453c9fc45df16d939dd8e690e7

1299 Tests Passed, 26 Failed so looks like this is working (at least for the majority of the tests). I'm sure some of those 26 failures are the same service tests that have been failing (Resharper, TeamCity, etc.) but going to peruse the others

I'm updating the PR title to only re-run the failed tests that were not already failing in our daily-test runs

And now the only test failing is GithubIssues GitHub open issues by label including slash charactr (raw) [ which is a known issue that will be fixed in #2936, removing test runs from PR title


no implicit conversion of nil into String

(master =)$ brew cask install vagrant
==> Downloading https://dl.bintray.com/mitchellh/vagrant/vagrant_1.7.2.dmg
Already downloaded: /Library/Caches/Homebrew/vagrant-1.7.2.dmg
Error: no implicit conversion of nil into String
Please report this bug:
    https://github.com/caskroom/homebrew-cask/issues
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/digest.rb:44:in `initialize'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/digest.rb:44:in `open'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/digest.rb:44:in `file'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/digest.rb:29:in `file'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/download.rb:41:in `block in _check_sums'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/download.rb:39:in `each'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/download.rb:39:in `_check_sums'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/download.rb:32:in `perform'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/installer.rb:72:in `download'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/installer.rb:49:in `install'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/cli/install.rb:20:in `block in install_casks'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/cli/install.rb:17:in `each'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/cli/install.rb:17:in `install_casks'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/cli/install.rb:6:in `run'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/cli.rb:81:in `run_command'
/usr/local/Cellar/brew-cask/0.46.0/rubylib/cask/cli.rb:121:in `process'
/usr/local/bin/brew-cask.rb:42:in `<top (required)>'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Library/brew.rb:58:in `require?'
/usr/local/Library/brew.rb:141:in `<main>'

Heyo I know you! :grinning:
An upgrade should sort this out for ya:
brew update && brew upgrade brew-cask && brew cleanup && brew cask cleanup

The latest version of brew cask recommends this action on errors so it should be clearer in the future. :+1:

Hey Paul!
Thanks for the hint. It worked :)
On Wed, Feb 25, 2015 at 11:32 AM, Paul Hinze<EMAIL_ADDRESS>wrote:

Heyo I know you! [image: :grinning:]
An upgrade should sort this out for ya:
brew update && brew upgrade brew-cask && brew cleanup && brew cask cleanup
The latest version of brew cask recommends this action on errors so it
should be clearer in the future. [image: :+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/caskroom/homebrew-cask/issues/9769#issuecomment-76025270
.

Hooray!


Improve title of multi diff editor

Today's title of the multi diff editor is just "Changes" which isn't meaningful. How about "N files"

Fixed by #198769
Titles are now called Git: Changes (35 files) / Git: Staged Changes (2 files) to align with the SCM sections Staged Changes / Changes.


Pcm 1167

Main files that were changed:

session-manager
softphone-handler

Still need to:

write tests
write docs (for new events, LineAppearance of 1, Migration strategies, upgrade to v7, new interfaces/types, etc)
clean up docs (like softphone.md)


Properly right location preference

Sorry evidently when I fixed #433 I made a copy/paste error.

thnx


discovery: aws/ec2 unit tests

In it's current form this is a very minimalistic implementation of the unit test "framework" for the aws discovery. It unit tests a very short function only which makes only one call to the AWS API. So it is a good demo and people can check the logic and the implementation and possibly start a discussion.
If it passes the scrutiny then I - or any other volunteer - can implement the other, more useful tests in this or in a different PR.
Please note that my Golang knowledge is very-very basic so there could be basic issues in the code itself. I am happy to learn and improve my skills on this domain.
Related to #14310.

Thank you for this PR. This is great!
I placed some comments. The comment about table driven development is a nice to have.

@simonpasquier I applied the changes you requested.
I usually prefer to use semi-random test data to avoid any accidental assumptions from the human side. The semi-random means that I always pay attention to make the generated data distinguishable from each other (wherever is possible). During a failed test people can see what "fields" are failed, not just two random strings. In this case I added a separate prefix for every different kind of AWS resource ID.
Of course if the consensus is to use static data then I will rewrite according to that. Earlier I planned to migrate ec2.go to the AWS SDK v2 (it uses the obsolete v1 right now) but strictly after there are tests to verify the results.

Let's give this a try.


DFP for interstitials support ?

We need to show interstitial ads, that use/are directed to DFP. Is that possible with the current release? I could only seem to find DFP for banner ads in the documentation here but wanted to double check.

I believe you can just use the AdMobInterstitial for DFP ad units, since the DFP specific classes extend from the admob classes., Although support for app events and custom rendered interstitials is currently lacking, since those require use of the admob classes.


Add a few security companies

Char49, Multicert, Dognaedis, Layer8, Cybersafe and S21sec

Thanks @vpereira01! :+1: :+1: :+1:


Adds the new timer API

This implements the new timer API so that the following is possible:
import { Duration, ic, TimerId, Update } from 'azle';

export function set_timers(delay: Duration): Update<[TimerId, TimerId, TimerId]> {
    const functionTimerId = ic.set_timer(delay, callback);
    const inlineTimerId = ic.set_timer(delay, () => {
        console.log('inline callback called');
    });
    const repeatingTimer = ic.set_timer_interval(delay, callback);

    return [functionTimerId, inlineTimerId, repeatingTimer];
}

export function clear_timer(timer_id: TimerId): Update<void> {
    ic.clear_timer(timer_id);
    console.log(`timer ${timer_id} cancelled`);
}

function callback(): void {
    console.log('callback called');
}

Note
Inline callbacks are supported and function callbacks are not required to be exported externally as canister methods.

One more thing that we should address, let's test out JS closures and just make sure that state is captured appropriately. In case we forget, let's do this in Kybra as well.

One more thing that we should address, let's test out JS closures and just make sure that state is captured appropriately. In case we forget, let's do this in Kybra as well.

:+1: I've updated the test to have a closure that captures a value like in Kybra.


Adding Site Daily Metrics code

Added SiteDailyMetrics model, serializer, filter, view and tests
"Cleanliness" in testing issue: retrieving 'values' for a query set retain the date time.datetime and date time.date objects in the resulting values, therefore I converted the serialized dates to a datetime or date object to compare in the tests (see test_site_daily_metrics_view.py and test_serializers.py
I know there is a clean solution in Django 2.0 and documented that in test_serializers.py
Just to note, I'm not going for exhaustive testing at this point, really just to get a well rounded base for the different parts of the code to make additional test writing much faster
And hey! We've now got only 15 files in this review. Down 5 from last review!
Also note that this branch is to merge into john/user-index, which is to merge into develop. This is because I'm chaining the branches to avoid extra work in duplicating support code

@johnbaldwin There are conflicts in the merge (devsite/requirements.txt).  Please resolve and push again.

Codecov Report

Merging #12 into develop will increase coverage by 0.49%.
The diff coverage is 94.08%.

@@             Coverage Diff             @@
##           develop      #12      +/-   ##
===========================================
+ Coverage    93.03%   93.52%   +0.49%
===========================================
  Files           20       23       +3
  Lines          287      479     +192
===========================================
+ Hits           267      448     +181
- Misses          20       31      +11

Impacted Files
Coverage Δ

edx_figures/admin.py
0% <0%> (ø)
:arrow_up:

edx_figures/urls.py
0% <0%> (ø)
:arrow_up:

tests/test_models.py
100% <100%> (ø)

tests/views/test_user_index_view.py
100% <100%> (ø)
:arrow_up:

tests/views/test_site_daily_metrics_view.py
100% <100%> (ø)

edx_figures/migrations/0001_initial.py
100% <100%> (ø)

edx_figures/views.py
93.93% <100%> (+0.18%)
:arrow_up:

tests/factories.py
94% <100%> (+1.5%)
:arrow_up:

tests/test_filters.py
100% <100%> (ø)
:arrow_up:

devsite/devsite/test_settings.py
100% <100%> (ø)
:arrow_up:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f071aae...51e8e07. Read the comment docs.

@bryanlandia I addressed the conflicts


hoogle files are generated correctly with ghc 7.10.1, hipbot builds correctly

I've tested the Hoogle files are built correctly locally and was able to use the new withHoogle to get a working local Hoogle instance running. No reason we should continue to not generate them by default.
https://github.com/purefn/hipbot/issues/1 has been fixed for quite a while now as well.

cc @peti

Merged into staging in 3dd96b1a2ca5c7ac8ce9e1613852aa9ded43e6c1.


Try to resolve merge conflicts in content

There are merge conflicts in these files, which causes content not shown as expected on published pages.
We created this pull request to fix above issue and unblock v3 migration.

Docs Build status updates of commit 7495c71:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/skills/design-principles.md
:white_check_mark:Succeeded
View

docs/skills/get-user-profile-context.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


crashing after fresh install

Hi,
I had followed the step by step explanation, but I'm getting an error when trying to send a message.
ErrorException in Manager.php line 77:
Missing argument 1 for Illuminate\Support\Manager::createDriver(), called in D:\vendor\laravel\framework\src\Illuminate\Support\Manager.php on line 88 and defined
in Manager.php line 77
at HandleExceptions->handleError(2, 'Missing argument 1 for Illuminate\\Support\\Manager::createDriver(), called in D:\\vendor\\laravel\\framework\\src\\Illuminate\\Support\\Manager.php on line 88 and defined', 'D:\\vendor\\laravel\\framework\\src\\Illuminate\\Support\\Manager.php', 77, array('this' => object(FCMManager))) in Manager.php line 77
at Manager->createDriver() in Manager.php line 88
at Manager->createDriver(null) in Manager.php line 63
at Manager->driver() in FCMServiceProvider.php line 27
at FCMServiceProvider->LaravelFCM\{closure}(object(Application), array()) in Container.php line 716
at Container->build(object(Closure)) in Container.php line 598
at Container->resolve('fcm.client') in Container.php line 567
at Container->make('fcm.client') in Application.php line 708
at Application->make('fcm.client') in Container.php line 1139
at Container->offsetGet('fcm.client') in FCMServiceProvider.php line 38
at FCMServiceProvider->LaravelFCM\{closure}(object(Application), array()) in Container.php line 716
at Container->build(object(Closure)) in Container.php line 598
at Container->resolve('fcm.sender') in Container.php line 567
at Container->make('fcm.sender') in Application.php line 708
at Application->make('fcm.sender') in Container.php line 1139
at Container->offsetGet('fcm.sender') in Facade.php line 159
at Facade::resolveFacadeInstance('fcm.sender') in Facade.php line 128
at Facade::getFacadeRoot() in Facade.php line 215
at Facade::__callStatic('sendTo', array(array('dFQwbIxI3J0:APA91bFzXpm4atxUHhtAYvZLfZsx78kCI711'), object(Options), object(PayloadNotification), object(PayloadData))) in ApiController.php line 190
at FCM::sendTo(array('dFQwbIxI3J0:Ch6HGrkAqe6p0ra969kjBa_HzdqAsgfi67EMbLI711'), object(Options), object(PayloadNotification), object(PayloadData)) in ApiController.php line 190
at ApiController::sendMessageToToken(object(Collection), 'Testing') in ApiController.php line 166
at ApiController->alertTeacherForDelay('15')
at call_user_func_array(array(object(ApiController), 'alertTeacherForDelay'), array('min' => '15')) in Controller.php line 55
at Controller->callAction('alertTeacherForDelay', array('min' => '15')) in ControllerDispatcher.php line 44
at ControllerDispatcher->dispatch(object(Route), object(ApiController), 'alertTeacherForDelay') in Route.php line 204
at Route->runController() in Route.php line 160

Any idea what I'm doing wrong? Or is this a real bug?
PS: I already cleaned the cache in all the possible ways that I found in the internet and still no luck.
Thanks,
Joao

Hello have you done an artisan publish command ?

Hi,
Yep, I had made the "php artisan vendor:publish".
To be honest, I rechecked twice all the commands that were wrote in the readme.md
I even tried to understand the problem, that appears to be because the variable $app is undefined. But I cannot understand from where this is coming from.
sorry, I'm new to laravel, but I already installed few packages and didn't have this issue before.
Can I check any file to verify if I installed it correctly?
Thanks,
Joao

It could be that you haven't done the php artisan vendor:publish before the registration of the serviceprovider (LaravelFCM\FCMServiceProvider::class ) in the app.php file.
please try again php artisan vendor:publish with LaravelFCM\FCMServiceProvider::classregistered in your config/app-php file.
Please give me a feedback if it's working or not
PS: Please check if in config folder you have a fcm.php file.
Best regards

Sorry, but didn't work (Same error):
here is the result of the vendor:publish command:
D:\>php artisan vendor:publish
Copied Directory [\vendor\laravel\framework\src\Illuminate\Notifications\resources\views] To [\resources\views\vendor\notifications]
Copied Directory [\vendor\laravel\framework\src\Illuminate\Pagination\resources\views] To [\resources\views\vendor\pagination]
Copied Directory [\vendor\laravel\passport\resources\views] To [\resources\views\vendor\passport]
Copied Directory [\vendor\laravel\passport\resources\assets\js\components] To [\resources\assets\js\components\passport]
Copied Directory [\vendor\laravel\framework\src\Illuminate\Mail\resources\views] To [\resources\views\vendor\mail]
Publishing complete.

I can also confirm that the fcm.php file is in the config folder:
return [
    'driver' => env('FCM_PROTOCOL', 'http'),
    'log_enabled' => true,

    'http' => [
        'server_key' => env('FCM_SERVER_KEY', 'Your FCM server key'),
        'sender_id' => env('FCM_SENDER_ID', 'Your sender id'),
        'server_send_url' => 'https://fcm.googleapis.com/fcm/send',
        'server_group_url' => 'https://android.googleapis.com/gcm/notification',
        'timeout' => 30.0, // in second
    ],
];

I did add the serviceprovider in the app.php file (Before calling the vendor:publish):
....
        /*
         * Package Service Providers...
         */
        Laravel\Tinker\TinkerServiceProvider::class,
        Laravel\Passport\PassportServiceProvider::class,

        /*
         * Application Service Providers...
         */
        App\Providers\AppServiceProvider::class,
        App\Providers\AuthServiceProvider::class,
        // App\Providers\BroadcastServiceProvider::class,
        App\Providers\EventServiceProvider::class,
        App\Providers\RouteServiceProvider::class,

        LaravelFCM\FCMServiceProvider::class,
    ],

and also:
....
        'URL' => Illuminate\Support\Facades\URL::class,
        'Validator' => Illuminate\Support\Facades\Validator::class,
        'View' => Illuminate\Support\Facades\View::class,
        'FCM'      => LaravelFCM\Facades\FCM::class,
        'FCMGroup' => LaravelFCM\Facades\FCMGroup::class, // Optional
    ],

Finally, the ONLY thing that I thought that was weird is that my bootstrap\app.php file doesn't contain anything similar of what the LUMEN part was saying. I actually never opened this file before. But I still added the lines to this file. Then, I did notice that the aliases didn't work in my code, but I just added the full path to get it running (Still crashing, but not complaining that the FCM was not found).
My bootstrap\app.php
<?php

/*
|--------------------------------------------------------------------------
| Create The Application
|--------------------------------------------------------------------------
|
| The first thing we will do is create a new Laravel application instance
| which serves as the "glue" for all the components of Laravel, and is
| the IoC container for the system binding all of the various parts.
|
*/

$app = new Illuminate\Foundation\Application(
    realpath(__DIR__.'/../')
);

/*
|--------------------------------------------------------------------------
| Bind Important Interfaces
|--------------------------------------------------------------------------
|
| Next, we need to bind some important interfaces into the container so
| we will be able to resolve them when needed. The kernels serve the
| incoming requests to this application from both the web and CLI.
|
*/

$app->singleton(
    Illuminate\Contracts\Http\Kernel::class,
    App\Http\Kernel::class
);

$app->singleton(
    Illuminate\Contracts\Console\Kernel::class,
    App\Console\Kernel::class
);

$app->singleton(
    Illuminate\Contracts\Debug\ExceptionHandler::class,
    App\Exceptions\Handler::class
);

$app->register(LaravelFCM\FCMServiceProvider::class);

class_alias(\LaravelFCM\Facades\FCM::class, 'FCM');
class_alias(\LaravelFCM\Facades\FCMGroup::class, 'FCMGroup');

/*
|--------------------------------------------------------------------------
| Return The Application
|--------------------------------------------------------------------------
|
| This script returns the application instance. The instance is given to
| the calling script so we can separate the building of the instances
| from the actual running of the application and sending responses.
|
*/

return $app;

And, in my file, I'm using:
use LaravelFCM\Facades\FCM;
use LaravelFCM\Message\OptionsBuilder;
use LaravelFCM\Message\PayloadDataBuilder;
use LaravelFCM\Message\PayloadNotificationBuilder;

and this is the entire method:
public static function sendMessageToToken($users, $message) {
        $tokens = [];
        foreach ($users as $user) {
            foreach ($user->fcmTokens as $token)
                $tokens[] = $token;
        }
        $tokens[] = "dFQwbIxI3J0:APA91bFzXpm4atxAYvZLfZsx78kCI711";

        $optionBuiler = new OptionsBuilder();
        $optionBuiler->setTimeToLive(60*20);

        $notificationBuilder = new PayloadNotificationBuilder('AgendaF1');
        $notificationBuilder->setBody($message)->setSound('default');

        $dataBuilder = new PayloadDataBuilder();
        $dataBuilder->addData(['a_data' => 'my_data']);

        $option = $optionBuiler->build();
        $notification = $notificationBuilder->build();
        $data = $dataBuilder->build();

        $downstreamResponse = FCM::sendTo($tokens, $option, $notification, $data);

        return $downstreamResponse->numberSuccess();

//        $downstreamResponse->numberFailure();
//        $downstreamResponse->numberModification();
//
////return Array - you must remove all this tokens in your database
//        $downstreamResponse->tokensToDelete();
//
////return Array (key : oldToken, value : new token - you must change the token in your database )
//        $downstreamResponse->tokensToModify();
    }

I believe that this is all the files that I changed. Any idea what is wrong?  How can I force a republish, just to be sure?

It's strange. It's look like a issue with the config file.
Can you try to remove all files and the package in vendor/brozot/then reinstall it with composer, remove also the config/fcm.php
make a vendor:publish command.
you can also remove the content added in your boostrap/app.phpyou need to add this line only if you use Lumen.
Thank you

Just tried what you said.
Got the same error.
Could be related to the laravel version? I'm using the: Laravel Framework 5.4.19

I have tried also with Laravel 5.4.19 and it works for me.
I have release a new version 1.2.4.
In this version the command vendor:publish is optional.
Can you try to update the package
thank you

Hey,
Thanks for the changes, apparently this fixed the initial issue.
Now I'm getting a new one:
RequestException in CurlFactory.php line 187:
cURL error 60: SSL certificate problem: unable to get local issuer certificate (see http://curl.haxx.se/libcurl/c/libcurl-errors.html)
in CurlFactory.php line 187
at CurlFactory::createRejection(object(EasyHandle), array('errno' => 60, 'error' => 'SSL certificate problem: unable to get local issuer certificate', 'url' => 'https://fcm.googleapis.com/fcm/send', 'content_type' => null, 'http_code' => 0, 'header_size' => 0, 'request_size' => 0, 'filetime' => -1, 'ssl_verify_result' => 20, 'redirect_count' => 0, 'total_time' => 0.188, 'namelookup_time' => 0.063, 'connect_time' => 0.078, 'pretransfer_time' => 0, 'size_upload' => 0, 'size_download' => 0, 'speed_download' => 0, 'speed_upload' => 0, 'download_content_length' => -1, 'upload_content_length' => -1, 'starttransfer_time' => 0, 'redirect_time' => 0, 'redirect_url' => '', 'primary_ip' => '<IP_ADDRESS>', 'certinfo' => array(), 'primary_port' => 443, 'local_ip' => '<IP_ADDRESS>', 'local_port' => 58176)) in CurlFactory.php line 150
at CurlFactory::finishError(object(CurlHandler), object(EasyHandle), object(CurlFactory)) in CurlFactory.php line 103
at CurlFactory::finish(object(CurlHandler), object(EasyHandle), object(CurlFactory)) in CurlHandler.php line 43
at CurlHandler->__invoke(object(Request), array('synchronous' => true, 'timeout' => 30, 'handler' => object(HandlerStack), 'allow_redirects' => array('max' => 5, 'protocols' => array('http', 'https'), 'strict' => false, 'referer' => false, 'track_redirects' => false), 'http_errors' => true, 'decode_content' => true, 'verify' => true, 'cookies' => false)) in Proxy.php line 28
at Proxy::GuzzleHttp\Handler\{closure}(object(Request), array('synchronous' => true, 'timeout' => 30, 'handler' => object(HandlerStack), 'allow_redirects' => array('max' => 5, 'protocols' => array('http', 'https'), 'strict' => false, 'referer' => false, 'track_redirects' => false), 'http_errors' => true, 'decode_content' => true, 'verify' => true, 'cookies' => false)) in Proxy.php line 51
at Proxy::GuzzleHttp\Handler\{closure}(object(Request), array('synchronous' => true, 'timeout' => 30, 'handler' => object(HandlerStack), 'allow_redirects' => array('max' => 5, 'protocols' => array('http', 'https'), 'strict' => false, 'referer' => false, 'track_redirects' => false), 'http_errors' => true, 'decode_content' => true, 'verify' => true, 'cookies' => false)) in PrepareBodyMiddleware.php line 72
at PrepareBodyMiddleware->__invoke(object(Request), array('synchronous' => true, 'timeout' => 30, 'handler' => object(HandlerStack), 'allow_redirects' => array('max' => 5, 'protocols' => array('http', 'https'), 'strict' => false, 'referer' => false, 'track_redirects' => false), 'http_errors' => true, 'decode_content' => true, 'verify' => true, 'cookies' => false)) in Middleware.php line 30
at Middleware::GuzzleHttp\{closure}(object(Request), array('synchronous' => true, 'timeout' => 30, 'handler' => object(HandlerStack), 'allow_redirects' => array('max' => 5, 'protocols' => array('http', 'https'), 'strict' => false, 'referer' => false, 'track_redirects' => false), 'http_errors' =>

I will investigate this error as well. If I found something I will let you know.

Hey,
Great news!!!! It worked!
I found the solution for the last problem here(I'm using a localhost php and mysql installations):
link here
I will copy here the solution (It was not me that wrote it, it's the person in the link above):

Go to http://curl.haxx.se/ca/cacert.pem and download the pem file and save in your php installation directory ( make sure while saving it retains the extension and not saved as a text file )
Now, open your php.ini file, scroll to the bottom and add the following line:
[cURL]
curl.cainfo="D:\xampp\php\cacert.pem"
Replace D:\xampp\php\cacert.pem with the actual path.
Courtesy: http://stackoverflow.com/questions/17478283/paypal-access-ssl-certificate-unable-to-get-local-issuer-certificate


Fix misleading type name in schema basics docs

Description
The docs refer to PostAndMediaInput which is nowhere to be found on that page. From context it looks like it should be replaced with AddBookInput from the example above.
Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[x] Documentation

Issues Fixed or Closed by This PR

Checklist

[ ] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Thanks for contributing to Strawberry! 🎉 You've been invited to join
the Strawberry GraphQL organisation 😊
You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67
And don't forget to join our discord server: https://strawberry.rocks/discord 🔥


Installer shows extra blank lines on Windows 7

When I run rustup-init.exe on my Windows 7 system, there are a number of extra blank lines:

Between "This path will then be added to your PATH environment variable by modifying the" and "HKEY_CURRENT_USER/Environment/PATH registry key."
Between "You can uninstall at any time with rustup self uninstall and these changes will" and "be reverted."
...

It appears that if a character (including a space) is written to the last column, a blank link will be displayed.

@kraai rustup wraps at the 80 character limit, but your terminal is size to 79 characters wide, resulting in double wrapping (the windows terminal since about windows 7 acts as a virtual "infinitely wide" terminal which is then wrapped to the current terminal width).
There's currently no portable way to determine the terminal width from rust, but if there were we could use that as the margin size instead.

@Diggsey I'm pretty sure the window is 80 characters wide: "Future applications will automatically have the correct environment, but you may" is 80 characters and it's shown on exactly one line.
Since I think this is the default Command Prompt window width, it may be worth handling a little better.

Ah yes, it seems like cmd wraps on the 80th character rather than waiting until the 81st character. We should be able to just change the margin to 79 characters to fix the problem.


Updates to match ember-cli-qunit 0.2.0 and 0.3.0 changes.

@dgeb - This will still need a quick sanity check/run-through to confirm (no tests and I don't use it normally so can't smoke test easily).
This should make us fully compatible with<EMAIL_ADDRESS>

Looks to be working well - thanks @rwjblue!
Just published v0.3.1 :shipit:


How to configure cachet queue in docker

Hey guys,
I am new to cachet and I am trying to set up cachet queue in docker for making my application faster when there are multiple subscribers for sending email. According to the document
"Cachet uses a queue to send Configuring Mail and Beacons without slowing down the rest of the application. This can be setup in a variety of ways."
I have not found any document for doing this. Can someone help in figuring this out. I set up my status page with queue as Database
Thanks,
Vignesh

Perhaps add a redis node and set it to redis? Otherwise database should work.


Export swagger definition doesn't work

Hello There,
The export swagger definition doesn't work for me. It throws an error : "java.lang.exception: Selected APIs must contain at least one endpoint". This happens though i select all the possible end points.
Swagger Plug In Version - 2.5.1
Ready API Version - 1.9.0
Steps to reproduce:

Select a project from the project tab in ready API
Right click on the project
Select "Export Swagger"
"Select all" API option
Select target folder
Leave the API version as-is i.e. 1.0
Set some base path https://example/
Select Swagger version 2.0
Select Format yaml.
Hit ok.

Result: It throws an error : "java.lang.exception: Selected APIs must contain at least one endpoint"

Hi!
you need to make sure that the REST API has an endpoint defined; before exporting to Swagger please select your API in the project view and then make sure the Endpoints tab on the right contains at least one endpoint as shown in the below image:

Hope this helps!
/Ole


Made 0.15.x compatible

Hi,
I tried to make this mod 0.15.x compatible. I tested with 0.15.21 and it works as expected.
I don't know why max_health is not allowed to be less than 1 any more. But I thought 1 is a good value.
The locales do not work with spaces between values and equal sign. I don't know if this was a problem before 0.15.
Hoping to hear from you soon,
trigrab

I haven't seen, that there are already pull request with the exact same changes. So I'm closing this one.


Problem with worker.py?

I'm getting this message whenever I try to run worker.py

Traceback (most recent call last):
File "worker.py", line 383, in
spawn_workers(workers, status_bar=args.status_bar)
File "worker.py", line 317, in spawn_workers
start_worker(worker_no, points[worker_no])
File "worker.py", line 305, in start_worker
points=points
File "worker.py", line 82, in init
center = self.points[0]
IndexError: list index out of range

this indicates a worker has 0 points - can you check your config?
and in case you dont find anything please copy paste your map_start, map_end and grid variables here

It turned out the problem was with my grid. Tweaked it and it seems to be working as it should now. Thanks!


Fix header issues exposed by :generate_multiple_pod_projects

Fix #3796

Fix imports in Private headers.
Stop referencing an internal typedef from a private header.

@paulb777 Would you like to try to update our tests to catch such issues?

@maksymmalyhin Good idea! Created #3804


cant build vtk-9 with qt6 on toss4

Describe the bug
A clear and concise description of what the bug is.
CMake Error at /usr/workspace/wsa/visit/visit/thirdparty_shared/3.4.1/toss4/qt/6.4.2/linux-x86_64_gcc-10.3/lib/cmake/Qt6Gui/Qt6QSvgIconPluginConfig.cmake:51 (include):
  include could not find requested file:

    /usr/workspace/wsa/visit/visit/thirdparty_shared/3.4.1/toss4/qt/6.4.2/linux-x86_64_gcc-10.3/lib/cmake/Qt6Gui/Qt6QSvgIconPluginTargets.cmake
Call Stack (most recent call first):
  /usr/workspace/wsa/visit/visit/thirdparty_shared/3.4.1/toss4/qt/6.4.2/linux-x86_64_gcc-10.3/lib/cmake/Qt6/QtPublicPluginHelpers.cmake:439 (include)
  /usr/workspace/wsa/visit/visit/thirdparty_shared/3.4.1/toss4/qt/6.4.2/linux-x86_64_gcc-10.3/lib/cmake/Qt6Gui/Qt6GuiPlugins.cmake:5 (__qt_internal_include_plugin_packages)
  /usr/workspace/wsa/visit/visit/thirdparty_shared/3.4.1/toss4/qt/6.4.2/linux-x86_64_gcc-10.3/lib/cmake/Qt6Gui/Qt6GuiConfig.cmake:123 (include)
  /usr/workspace/wsa/visit/visit/thirdparty_shared/3.4.1/toss4/cmake/3.24.3/linux-x86_64_gcc-10.3/share/cmake-3.24/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
  /usr/workspace/wsa/visit/visit/thirdparty_shared/3.4.1/toss4/qt/6.4.2/linux-x86_64_gcc-10.3/lib/cmake/Qt6/QtPublicDependencyHelpers.cmake:108 (find_dependency)
  /usr/workspace/wsa/visit/visit/thirdparty_shared/3.4.1/toss4/qt/6.4.2/linux-x86_64_gcc-10.3/lib/cmake/Qt6OpenGL/Qt6OpenGLDependencies.cmake:39 (_qt_internal_find_qt_dependencies)
  /usr/workspace/wsa/visit/visit/thirdparty_shared/3.4.1/toss4/qt/6.4.2/linux-x86_64_gcc-10.3/lib/cmake/Qt6OpenGL/Qt6OpenGLConfig.cmake:40 (include)
  /usr/workspace/wsa/visit/visit/thirdparty_shared/3.4.1/toss4/qt/6.4.2/linux-x86_64_gcc-10.3/lib/cmake/Qt6/Qt6Config.cmake:157 (find_package)
  CMake/vtkModule.cmake:4572 (find_package)
  GUISupport/Qt/CMakeLists.txt:43 (vtk_module_find_package)

CMake Error at /usr/workspace/wsa/visit/visit/thirdparty_shared/3.4.1/toss4/qt/6.4.2/linux-x86_64_gcc-10.3/lib/cmake/Qt6Gui/Qt6QSvgIconPluginConfig.cmake:52 (include):
  include could not find requested file:

    /usr/workspace/wsa/visit/visit/thirdparty_shared/3.4.1/toss4/qt/6.4.2/linux-x86_64_gcc-10.3/lib/cmake/Qt6Gui/Qt6QSvgIconPluginAdditionalTargetInfo.cmake

What is your invocation to build_visit?  I have built vtk  9 and qt 6 many times on toss4 successfully.


Update Outdated GCP getting started guide[skip ci]

the plugin version is out of date in the GCP getting started guide,
update the plugin&xgboost jars versions and remove some configs
fix #5186

build

build


Improve Test Coverage

Describe the PR
Improve Test Coverage
Relation issue
None.
Additional context
Since property.go and schema.go seems to be done i don't see why not have 100% coverage.

Codecov Report

Merging #448 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   82.62%   82.69%   +0.06%
==========================================
  Files           7        7
  Lines        1456     1456
==========================================
+ Hits         1203     1204       +1
+ Misses        143      142       -1
  Partials      110      110

Impacted Files
Coverage Δ

parser.go
80.76% <100%> (ø)
:arrow_up:

property.go
100% <0%> (+1.53%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52091f1...5ef8270. Read the comment docs.


Adds iso-based and container-based providers

working on #2 ...
It moves all the provisioners in the minikube codebase, to minikube-machine, removing the need of a minikube's provisioner package.
Just a copy/paste at the moment. I opened this early so we can perhaps discuss some aspects of it.

I moved all the relevant /pkg/provision code here, and copied a piece of of pkg/minikube/assets/vm_assets.go to make it work. At the moment, a couple of files depend on minikube itself.. this hints me of a couple of questions:

Can minikube-machine have minikube as a dependency?
How much code in minikube we can move into minikube-machine?

can we move things like pkg/minikube/assets into minikube-machine?
like "everything related to machine interactions"...

Moving the container (KIC) based drivers is probably going to be a lot of work since they are entangled in minikube.
It might make sense to leave them in the minikube code base, and only do hypervisor drivers (updating libmachine)

Moving the container (KIC) based drivers is probably going to be a lot of work since they are entangled in minikube.
It might make sense to leave them in the minikube code base, and only do hypervisor drivers (updating libmachine)

Agreed that moving the KIC driver seems like a lot of work.
As mentioned in the previous comment, I'd like to try to move drivers in libmachine, but it still isn't clear to me how to do it:

Like for example kvm: somebody with permissions in this organization has to fork github.com/dhiltgen/docker-machine-kvm, the we make the changes to make it look more like minikube's kvm driver? Wouldn't be simpler to just copypaste the kvm from minikube?

We're maintaining those drivers as forks? So that whenever someone changes something upstream, we're updating our fork and making minikube-machine depend on the fork?


Dirichlet-multinomial density and (P)RNGs

[ ] density

[ ] dirichlet_multinomial_log function
[ ] distribution tests
[ ] model instantiation tests
[ ] doc for manual
[ ] (optional) example for manual in programming section;  perhaps a new chapter on overdispersion

[ ] PRNG

[ ] dirichlet_multinomial_rng function
[ ] distribution and PRNG tests
[ ] doc for manual
[ ] model instantiation tests

This issue was moved to stan-dev/math#54


Merge upstream ?

Hello will it merge upstream soon? thanks

https://github.com/WaterfallMC/Waterfall/commit/1932de511ce06e736312740be8b243a9197ec996


how to change smtp to PHP mail()

I can't get the smtp working and it's very slow to detect smtp. The PHP mail() works fine.
I want to change smtp to PHP mail(). Which files should I edit? Which codes in these files should I change?

It looks PHPMailer will send email using PHP's mail() function, just change "mail_server_type" to anything else but "smtp".


gvoice app doesn't  login

for me everything the gvoice CLI seems to be broke, and cannot login.
Traceback (most recent call last):
File "/usr/bin/gvoice", line 80, in
login()
File "/usr/bin/gvoice", line 50, in login
voice.login(options.email,options.passwd)
File "/usr/local/lib/python2.7/dist-packages/googlevoice/voice.py", line 73, in login
service = re.search(r"name="service" type="hidden" value="(.+)"", content).group(1)
AttributeError: 'NoneType' object has no attribute 'group'
anyone else having this problem?

Same issues here. I'll try and take a look at it tonight.

Same issues here. I'll try and take a look at it tonight.

Thanks, I really depend on that program a lot,
and appreciate any effort you make!
Regards, Dallas E. Legan II /<EMAIL_ADDRESS>/<EMAIL_ADDRESS>http://isthereanotherquestion.blogspot.com

"Tekeli-li! Tekeli-li!"
- "At the Mountains of Madness", H.P.
Lovecraft

This message was sent using Endymion MailMan.
http://www.endymion.com/products/mailman/

Got a chance to take a look, it looks like you may have an outdated version. That line should be:
galx = re.search(r"type=\"hidden\"\s+name=\"GALX\"\s+value=\"(.+)\"", content).group(1)
Can you update the version and try again?

Got a chance to take a look, it looks like you may have an outdated version. That line
should be:

content).group(1)```

Can you update the version and try again?

Reply to this email directly or view it on GitHub:
https://github.com/pettazz/pygooglevoice/issues/18#issuecomment-173074073

I'll try to soon.
I'm busy right now, but the gvoice sample app is very important to
me.
Thanks for your efforts!
Regards, Dallas E. Legan II /<EMAIL_ADDRESS>/<EMAIL_ADDRESS>http://isthereanotherquestion.blogspot.com

"Tekeli-li! Tekeli-li!"
- "At the Mountains of Madness", H.P.
Lovecraft

This message was sent using Endymion MailMan.
http://www.endymion.com/products/mailman/

Got a chance to take a look, it looks like you may have an outdated version. That line should be:
galx = re.search(r"type=\"hidden\"\s+name=\"GALX\"\s+value=\"(.+)\"", content).group(1)
Can you update the version and try again?

finally found some time to upgrade python and re-install,
seems to be working fine.
Thanks, and appreciate your patience!
Regards, Dallas E. Legan II /<EMAIL_ADDRESS>/<EMAIL_ADDRESS>http://isthereanotherquestion.blogspot.com

"Tekeli-li! Tekeli-li!"
- "At the Mountains of Madness", H.P. Lovecraft

I'm getting the error when I try to log in. I've even abled "less secure apps" to log in through https://support.google.com/accounts/answer/6010255. I don't have two-factor turned on.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "googlevoice/voice.py", line 95, in login
    raise LoginError
googlevoice.util.LoginError

Any ideas on why this might be happening for some accounts?

@aaronshim try using a web browser (lynx for example) to login to Google Voice on the server you are running the script. It could be Google not allowing the login from the server that's in a different location than normal account logins.
Something to try!

That was it! Unfortunately, even after whitelisting my SSH box on my Google
account, the fraud detection algorithm still hasn't learned it yet, so I
resorted to running my script on my local machine with a recognized IP.
On Feb 17, 2016 3:54 PM, "illgitthat"<EMAIL_ADDRESS>wrote:

@aaronshim
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_aaronshim&d=AwMCaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=Wgb1nhs7KKOFu_j5cr8lzxZcuFCTFWe9WJxXhqiNNOk&m=MYYeIcQ09mOUOo64R5rTrPW_JJIZ00kUr3Jl71nagAI&s=SEpl2t_ZEOOLOVr-c318PsMQSwo_3ZbirCNZ42QuAZM&e=
try using a web browser (lynx for example) to login to Google Voice on the
server you are running the script. It could be Google not allowing the
login from the server that's in a different location than normal account
logins.
Something to try!
—
Reply to this email directly or view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_pettazz_pygooglevoice_issues_18-23issuecomment-2D185398220&d=AwMCaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=Wgb1nhs7KKOFu_j5cr8lzxZcuFCTFWe9WJxXhqiNNOk&m=MYYeIcQ09mOUOo64R5rTrPW_JJIZ00kUr3Jl71nagAI&s=GVY6iKZwstPQEP_2D6fVvCmPO5oVOfBnptlioWIUi9g&e=
.

See #27 issue solved when you log into your google voice account then browse to the following page
https://accounts.google.com/DisplayUnlockCaptcha

Allow access to your Google account
As a security precaution, Google may require you to complete this additional step when signing into a new device or application.
To allow access, click the Continue button below.

@twbarber I have the most recent version from github and am still getting the AttributeError referenced above:
File "/var/www/site/venv/lib/python2.7/site-packages/googlevoice/voice.py", line 75, in login
  galx = re.search(r"type=\"hidden\"\s+name=\"GALX\"\s+value=\"(.+)\"", content).group(1)
AttributeError: 'NoneType' object has no attribute 'group'

You can see I'm using a virtualenv, but I see no reason why that should matter here.

I submitted a pull request to fix this a few days ago.  Google has stopped providing the galx field.  So the cure is (a) delete the line you quoted (line 75), and (b) two lines later, in the do_page call, remove 'GALX': galx.


Make name of the "sealed-secrets-controller" configurable

Command

[ ] archive
[ ] check-image-updates
[ ] delete
[ ] deploy
[ ] diff
[ ] downscale
[ ] helm-pull
[ ] helm-update
[ ] list-images
[ ] list-targets
[ ] poke-images
[ ] prune
[ ] render
[X] seal
[ ] validate
[ ] version

Who are you?
Make name of the "sealed-secrets-controller" configurable
What do you want to do?
https://github.com/kluctl/kluctl/blob/main/cmd/kluctl/commands/cmd_seal.go#L53
https://github.com/kluctl/kluctl/blob/main/pkg/seal/fetch_cert.go#L19
The name of the sealed secrets controller could be different depending on the deployment. sealed-secrets-controller is just the default:
from: https://github.com/bitnami-labs/sealed-secrets#controller

Why do you need that?
In my local deployment the selead secrets controller is simply called "sealed secrets".

could be something like
kluctl seal --controller-name sealed-secrets -t dev
as well and part of the config
secretsConfig:
  controller-name: sealed-secrets
  secretSets:
    - name: dev
      vars:
        - file: .secrets-dev.yaml
    - name: test
      vars:
        - file: .secrets-test.yaml

I just found out that this is already configurable:
type GlobalSealedSecretsConfig struct {
	Bootstrap      *bool   `yaml:"bootstrap,omitempty"`
	Namespace      *string `yaml:"namespace,omitempty"`
	ControllerName *string `yaml:"controllerName,omitempty"`
}

in .kluctl.yml
secretsConfig:
  sealedSecrets:
    namespace: simple
    controllerName: sealed-secrets-controller


cannot reboot xavier devkit

Hi,
Does anyone have issues with rebooting xavier devkits?
Mine, zeus-l4t-r32.3.1, doesn't and I see some i2c errors in terminal
[  202.536205] tegra-i2c c250000.i2c: pio timed out addr: 0x1a tlen:28 rlen:4
[  202.536345] tegra-i2c c250000.i2c: --- register dump for debugging ----
[  202.536453] tegra-i2c c250000.i2c: I2C_CNFG - 0x22c00
[  202.536540] tegra-i2c c250000.i2c: I2C_PACKET_TRANSFER_STATUS - 0x10001
[  202.536645] tegra-i2c c250000.i2c: I2C_FIFO_CONTROL - 0x0
[  202.536752] tegra-i2c c250000.i2c: I2C_FIFO_STATUS - 0x800080
[  202.536856] tegra-i2c c250000.i2c: I2C_MST_FIFO_CONTROL - 0x70000
[  202.536954] tegra-i2c c250000.i2c: I2C_MST_FIFO_STATUS - 0x7c0000
[  202.537058] tegra-i2c c250000.i2c: I2C_MST_PACKET_TRANSFER_CNT - 0x0
[  202.537160] tegra-i2c c250000.i2c: I2C_INT_MASK - 0x7d
[  202.537243] tegra-i2c c250000.i2c: I2C_INT_STATUS - 0x2
[  202.537328] tegra-i2c c250000.i2c: i2c transfer timed out addr: 0x1a

it might eventually reboot after some minutes.
I use force reboot which should be ~instant.
Thanks
-Damien

That looks like I2C address 7-001A.   The default device tree configures an RT5659 audio codec at that address, but I don't think it actually comes with the dev kit.  Do you have something connected to I2C bus 7, or have you maybe configured in some ALSA audio that's trying to use that codec?  By default the layer only configures in HDMI audio, so it shouldn't normally be a problem.

I have to look more into it.
I am testing a bare devkit and no additional device on bus 7.
I'm not implicitly including alsa but maybe some Qt package or someone else does.
Ultimately I don't need audio at all so I'll disable it completely.

@madisongh Is there a way to disable those unused I2C addressed? I have the same issue but with some other port
[   93.049308] tegra-i2c 7000c700.i2c: --- register dump for debugging ----
[   93.056026] tegra-i2c 7000c700.i2c: I2C_CNFG - 0x22c00
[   93.061184] tegra-i2c 7000c700.i2c: I2C_PACKET_TRANSFER_STATUS - 0x10001
[   93.068378] tegra-i2c 7000c700.i2c: I2C_FIFO_CONTROL - 0x1c
[   93.073989] tegra-i2c 7000c700.i2c: I2C_FIFO_STATUS - 0x800040
[   93.080616] tegra-i2c 7000c700.i2c: I2C_INT_MASK - 0x6c
[   93.085927] tegra-i2c 7000c700.i2c: I2C_INT_STATUS - 0x2
[   93.091370] tegra-i2c 7000c700.i2c: i2c transfer timed out addr: 0x50
[  103.282783] tegra-i2c 7000c700.i2c: rx dma timeout txlen:28 rxlen:128

@przemyslaw-chwiala You'd need to modify the device tree and disable the node so the driver doesn't try probing the device.

@lfdmn I assume you got this straightened out, so am closing.


Failed to connect to my-release-mariadb:3306 after 36 tries

Describe the bug
The wordpress pod cannot connect to the maria-db pod on a new helm/kubernetes setup with the chart stable/wordpress
Log entry in the WordPress Pod: Failed to connect to my-release-mariadb:3306 after 36 tries
Note: I also checked some other closed bug reports in this regard, but they refer to older releases and should be fixed yet.
Version of Helm and Kubernetes:
helm version:
Client: &version.Version{SemVer:"v2.13.1", GitCommit:"618447cbf203d147601b4b9bd7f8c37a5d39fbb4", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.13.1", GitCommit:"618447cbf203d147601b4b9bd7f8c37a5d39fbb4", GitTreeState:"clean"}
kubectl verion:
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-19T22:15:46Z", GoVersion:"go1.12.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:02:58Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}
Which chart:
stable/wordpress
What happened:
WordPress Pod cannot connect to Maria DB
kubectl logs my-release-wordpress-7dd7bdbd4d-z5xqz
mysql-c INFO  Trying to connect to MySQL server
Error executing 'postInstallation': Failed to connect to my-release-mariadb:3306 after 36 tries
After some time the wordpress pod switches its state from Running to CrashLoopBackOff
What you expected to happen:
Running
How to reproduce it (as minimally and precisely as possible):
Just use a default, clean installation:
helm install --name my-release stable/wordpress
Then wait and access the log of the wordpress pod
Anything else we need to know:
I am running minikube on a mac

Hi @RobertoDonPedro
What version of the WordPress chart are you using? Have you updated the repository recently?
$ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Skip local chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈ Happy Helming!⎈

I was unable to reproduce the issue on Minikube on MacOS using the latest chart:
$ helm install --name my-release stable/wordpress
...
$ kubectl get pods
NAME                                    READY   STATUS    RESTARTS   AGE
my-release-mariadb-0                    1/1     Running   0          2m12s
my-release-wordpress-7dd7bdbd4d-jj2xw   1/1     Running   0          2m12s
$ kubectl logs $(kubectl get pods -l app=my-release-wordpress -o jsonpath='{.items[0].metadata.name}')

Welcome to the Bitnami wordpress container
Subscribe to project updates by watching https://github.com/bitnami/bitnami-docker-wordpress
Submit issues and feature requests at https://github.com/bitnami/bitnami-docker-wordpress/issues

WARN  ==> You set the environment variable ALLOW_EMPTY_PASSWORD=yes. For safety reasons, do not use this flag in a production environment.
nami    INFO  Initializing apache
apache  INFO  ==> Patching httpoxy...
apache  INFO  ==> Configuring dummy certificates...
nami    INFO  apache successfully initialized
nami    INFO  Initializing php
nami    INFO  php successfully initialized
nami    INFO  Initializing mysql-client
nami    INFO  mysql-client successfully initialized
nami    INFO  Initializing libphp
nami    INFO  libphp successfully initialized
nami    INFO  Initializing wordpress
mysql-c INFO  Trying to connect to MySQL server
mysql-c INFO  Found MySQL server listening at my-release-mariadb:3306
mysql-c INFO  MySQL server listening and working at my-release-mariadb:3306
wordpre INFO
wordpre INFO  ########################################################################
wordpre INFO   Installation parameters for wordpress:
wordpre INFO     First Name: FirstName
wordpre INFO     Last Name: LastName
wordpre INFO     Username: user
wordpre INFO     Password: **********
wordpre INFO     Email<EMAIL_ADDRESS>wordpre INFO     Blog Name: User's Blog!
wordpre INFO     Table Prefix: wp_
wordpre INFO   (Passwords are not shown for security reasons)
wordpre INFO  ########################################################################
wordpre INFO
nami    INFO  wordpress successfully initialized
INFO  ==> Starting wordpress...

Did the associated MariaDB chart reached a healthy status?

Hi, I did the same like you, but wp cannot connect.
Neither the wp nor the mariadb chart enter Ready state. First both are running, then wp is failing then maria db is failing. Please see the details below:
Roberts-iMac:~ robert$ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Skip local chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈ Happy Helming!⎈

Roberts-iMac:~ robert$ helm install --name my-release stable/wordpress
Roberts-iMac:~ robert$ kubectl get pods
NAME                                    READY   STATUS    RESTARTS   AGE
my-release-mariadb-0                    0/1     Running   5          14m
my-release-wordpress-7dd7bdbd4d-bkxk2   0/1     Running   6          14m

Roberts-iMac:~ robert$ kubectl logs $(kubectl get pods -l app=my-release-wordpress -o jsonpath='{.items[0].metadata.name}')

Welcome to the Bitnami wordpress container
Subscribe to project updates by watching https://github.com/bitnami/bitnami-docker-wordpress
Submit issues and feature requests at https://github.com/bitnami/bitnami-docker-wordpress/issues

WARN  ==> You set the environment variable ALLOW_EMPTY_PASSWORD=yes. For safety reasons, do not use this flag in a production environment.
nami    INFO  Initializing apache
apache  INFO  ==> Reconfiguring PID file location...
apache  INFO  ==> Configuring dummy certificates...
nami    INFO  apache successfully initialized
nami    INFO  Initializing php
nami    INFO  php successfully initialized
nami    INFO  Initializing mysql-client
nami    INFO  mysql-client successfully initialized
nami    INFO  Initializing libphp
nami    INFO  libphp successfully initialized
nami    INFO  Initializing wordpress
mysql-c INFO  Trying to connect to MySQL server
Error executing 'postInstallation': Failed to connect to my-release-mariadb:3306 after 36 tries

Roberts-iMac:~ robert$ kubectl get pods
NAME                                    READY   STATUS             RESTARTS   AGE
my-release-mariadb-0                    0/1     CrashLoopBackOff   6          17m
my-release-wordpress-7dd7bdbd4d-bkxk2   0/1     CrashLoopBackOff   6          17m

Roberts-iMac:~ robert$ kubectl logs my-release-mariadb-0

Welcome to the Bitnami mariadb container
Subscribe to project updates by watching https://github.com/bitnami/bitnami-docker-mariadb
Submit issues and feature requests at https://github.com/bitnami/bitnami-docker-mariadb/issues
Send us your feedback at<EMAIL_ADDRESS>
INFO  ==> ** Starting MariaDB setup **
INFO  ==> Validating settings in MYSQL_*/MARIADB_* env vars..
INFO  ==> Initializing mariadb database...
INFO  ==> Persisted data detected. Restoring...
INFO  ==> Stopping mariadb...
INFO  ==> ** MariaDB setup finished! **

INFO  ==> ** Starting MariaDB **
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] /opt/bitnami/mariadb/sbin/mysqld (mysqld 10.1.39-MariaDB) starting as process 1 ...
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] InnoDB: innodb_empty_free_list_algorithm has been changed to legacy because of small buffer pool size. In order to use backoff, increase buffer pool at least up to 20MB.

2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] InnoDB: Using mutexes to ref count buffer pool pages
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] InnoDB: The InnoDB memory heap is disabled
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] InnoDB: Mutexes and rw_locks use GCC atomic builtins
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] InnoDB: GCC builtin __atomic_thread_fence() is used for memory barrier
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] InnoDB: Compressed tables use zlib 1.2.8
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] InnoDB: Using Linux native AIO
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] InnoDB: Using SSE crc32 instructions
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] InnoDB: Initializing buffer pool, size = 128.0M
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] InnoDB: Completed initialization of buffer pool
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] InnoDB: Highest supported file format is Barracuda.
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] InnoDB: 128 rollback segment(s) are active.
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] InnoDB: Waiting for purge to start
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] InnoDB:  Percona XtraDB (http://www.percona.com) 5.6.43-84.3 started; log sequence number 2574477
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] Plugin 'FEEDBACK' is disabled.
2019-05-14 14:01:31<PHONE_NUMBER>07712 [Note] InnoDB: Dumping buffer pool(s) not yet started
2019-05-14 14:01:31<PHONE_NUMBER>57248 [Note] Server socket created on IP: '<IP_ADDRESS>'.
2019-05-14 14:01:32<PHONE_NUMBER>57248 [Warning] 'proxies_priv' entry '@% root@my-release-mariadb-0' ignored in --skip-name-resolve mode.
2019-05-14 14:01:32<PHONE_NUMBER>57248 [Note] /opt/bitnami/mariadb/sbin/mysqld: ready for connections.
Version: '10.1.39-MariaDB'  socket: '/opt/bitnami/mariadb/tmp/mysql.sock'  port: 3306  Source distribution
2019-05-14 14:03:57<PHONE_NUMBER>09248 [Note] /opt/bitnami/mariadb/sbin/mysqld: Normal shutdown
2019-05-14 14:03:57<PHONE_NUMBER>09248 [Note] Event Scheduler: Purging the queue. 0 events
2019-05-14 14:03:57<PHONE_NUMBER>24576 [Note] InnoDB: FTS optimize thread exiting.
2019-05-14 14:03:57<PHONE_NUMBER>09248 [Note] InnoDB: Starting shutdown...
2019-05-14 14:03:58<PHONE_NUMBER>09248 [Note] InnoDB: Waiting for page_cleaner to finish flushing of buffer pool
2019-05-14 14:03:59<PHONE_NUMBER>09248 [Note] InnoDB: Shutdown completed; log sequence number 2574487
2019-05-14 14:03:59<PHONE_NUMBER>09248 [Note] /opt/bitnami/mariadb/sbin/mysqld: Shutdown complete

Hi @RobertoDonPedro
For some reason, your MariaDB database is receiving a shutdown signal, see:`
2019-05-14 14:03:57<PHONE_NUMBER>09248 [Note] /opt/bitnami/mariadb/sbin/mysqld: Normal shutdown

That's probably related with readiness/liveness probes failing and it's very likely to be related with using the wrong database password on those probes.
Could it be possible you're installing the chart with the same name you'd done in a previous release? There could be existing PVCs that were not deleted from previous releases.
I'd delete the chart, check and delete the PVCs that are not necessary, and install again the chart.

Initially I have tried it with passwords like described in the readme
helm install --name my-release \
  --set wordpressUsername=admin,wordpressPassword=password,mariadb.mariadbRootPassword=secretpassword \
    stable/wordpress

This did not work. Maybe the parameter in this readme sample is not correct and it should be mariadb.rootUser.password instead of mariadb.mariadbRootPassword?
However I deleted it again with helm del --purge my-release and installed it again without passwords by helm install --name my-release stable/wordpress, but with the same negative results.
I did not assume, that helm del --purge my-release would leave the PVs and PVCs intact. So now I checked this and indeed the old pvs were still active.
According to your advise I deleted the old PVCs and PVs, built it from scratch and now it works.
However, now there is a new problem, how can I get the Wordpress URL?  The install output says:
NOTES:
1. Get the WordPress URL:

  NOTE: It may take a few minutes for the LoadBalancer IP to be available.
        Watch the status with: 'kubectl get svc --namespace default -w my-release-wordpress'
  export SERVICE_IP=$(kubectl get svc --namespace default my-release-wordpress --template "{{ range (index .status.loadBalancer.ingress 0) }}{{.}}{{ end }}")
  echo "WordPress URL: http://$SERVICE_IP/"
  echo "WordPress Admin URL: http://$SERVICE_IP/admin"

2. Login with the following credentials to see your blog

If I run this statement as advised above
export SERVICE_IP=$(kubectl get svc --namespace default my-release-wordpress --template "{{ range (index .status.loadBalancer.ingress 0) }}{{.}}{{ end }}")
then I get the following error:
error: error executing template "{{ range (index .status.loadBalancer.ingress 0) }}{{.}}{{ end }}": template: output:1:10: executing "output" at <index .status.loadBalancer.ingress 0>: error calling index: index of untyped nil
How need this statement to be changed so that it works with the default install commands in your readme file?

I did not assume, that helm del --purge my-release would leave the PVs and PVCs intact. So now I checked this and indeed the old pvs were still active.

That's the problem, Helm doesn't delete the PVCs since they're dynamically created by the statefulset. That's why you need to look for the PVCs and delete them manually.
$ kubectl get pvc
$ kubectl delete pvc xxx yyy zzz

This is a known bug and it's already reported. See https://github.com/helm/helm/issues/5156

However, now there is a new problem, how can I get the Wordpress URL? The install output says:

The problem is that you installed the chart with service.type=LoadBalancer. That kind of service is not supported on Minikube, you should use service.type=ClusterIP instead.

This is a known bug and it's already reported. See helm/helm#5156

I  commented on that directly in  #helm/helm#5156

The problem is that you installed the chart with service.type=LoadBalancer. That kind of service is not supported on Minikube, you should use service.type=ClusterIP instead.

For better initial UX I would expect the readme sample to work even minikube out of the box
However, now I tried it with service.type=ClusterIP:
helm install --name my-release   --set wordpressUsername=admin,wordpressPassword=password,mariadb.mariadbRootPassword=secretpassword,service.type=ClusterIP stable/wordpress
but when I try to access the URL I get connection refused with curl (and in the browser)
Roberts-iMac:~ robert$ curl http://<IP_ADDRESS>:8080/
curl: (7) Failed to connect to <IP_ADDRESS> port 8080: Connection refused

Finally the port forwarding was missing:
kubectl port-forward --namespace default svc/my-release-wordpress 8080:80
Now it works 👍 .
However, if I may I would like to propose to adapt the readme file (or the default configuration) for a better "first time helm experience".

Hi @RobertoDonPedro
I'm glad you could get it working!!! Please feel free to make a PR including the adaptions you consider necessary to improve the first experience.

Finally the port forwarding was missing:
kubectl port-forward --namespace default svc/my-release-wordpress 8080:80
Now it works 👍 .
However, if I may I would like to propose to adapt the readme file (or the default configuration) for a better "first time helm experience".

This is not solution, this is workaround.


Blockchain: refactor References

// References returns a map with input prevHash as key (util.Uint256)
// and transaction output as value from a transaction t.
// @TODO: unfortunately we couldn't attach this method to the Transaction struct in the
// transaction package because of a import cycle problem. Perhaps we should think to re-design
// the code base to avoid this situation.
func (bc *Blockchain) References(t *transaction.Transaction) map[util.Uint256]*transaction.Output {

Refs. #244.

Actually I don't think it should be Transaction method, because it obviously depends more on blockchain state than transaction itself. Anyway, Neo 3.0 doesn't have anything like that and for Neo 2.0 this solution is good enough, thus closing the issue.


[bug]: Issue templates using [ ] are used by GitHub for tracking task completion

Steps to reproduce
Creating an Issue that has the "agree to code of conduct" sets a "[x]" in the Issue comment. GitHub uses the [ ] to list actions and tasks completed.
Expected result
The [ ] shouldn't be used in Issues, because of the way GitHub uses them.
Actual result (the bug)
So maybe instead of the [ ] we can say "By creating this issue, you agree to follow the code of conduct (link here)" or something similar. A "participation is agreement" default setting.
Optional: Relevant log output
No response
Severity/Priority
None
Contact Details
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Linked to #120.
@lwjohnst86 was this issue solely about removing the code of conduct checkbox or more generally on using the boxes in our issue templates?


feat：add change validator cli

Codecov Report

Merging #180 (a660afb) into main (f823d7a) will decrease coverage by 3.16%.
The diff coverage is n/a.

:exclamation: Current head a660afb differs from pull request most recent head ef4207f. Consider uploading reports for the commit ef4207f to get more accurate results

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   41.08%   37.92%   -3.17%
==========================================
  Files          23       17       -6
  Lines        1969     1743     -226
  Branches       48        0      -48
==========================================
- Hits          809      661     -148
+ Misses       1160     1082      -78

Impacted Files
Coverage Δ

...es/eth-contracts/contracts/libraries/SafeERC20.sol

...ules/eth-contracts/contracts/libraries/Address.sol

...th-contracts/contracts/libraries/MultisigUtils.sol

...ain-modules/eth-contracts/contracts/test/ERC20.sol

...les/eth-contracts/contracts/libraries/SafeMath.sol

...in-modules/eth-contracts/contracts/ForceBridge.sol

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f823d7a...ef4207f. Read the comment docs.

https://github.com/nervosnetwork/michi-internal/issues/422#issuecomment-886316928


Work-in-progess: Add an option to highlight a subset of qubits in cirq.Heatmap

These are the first few changes. Next, I will focus on adding some new tests. This is still a WIP

Update: I am very close to completing the bit with edge_colors logic. The only issue I am faced with is, the state of the list I look in is:
[(cirq.GridQubit(0, 5),), (cirq.GridQubit(8, 1),), (cirq.GridQubit(7, 0),), (cirq.GridQubit(13, 5),), (cirq.GridQubit(1, 6),), (cirq.GridQubit(3, 2),), (cirq.GridQubit(2, 8),)]

and this prevents the detection of a clear qubit in the form (if we were looking for it for example) cirq.GridQubit(0, 5)

I believe I only have tests left (for Heatmaps, next is TwoQubitInteractionHeatmap). There is a heatmaps.py in the examples folder that I can run but I don't see any plots. Also, a Jupyter notebook only gives me ValueError: Received invalid argument(s): selected_qubits while all tests in heatmap_test.py pass (except test_annotation_map).

Apologies for the delay. I was working on this from time to time and I have trouble testing. It seems that I might have made a mistake in the setup and now my tests do not detect any changes I have made in heatmaps.py If you have any advice let me know how to fix it, otherwise I will keep looking


upload.sh does not upload the mime-types

upload.sh does not upload the mime-types

Solved, will be part of release 0.2.0. Thanks.


yaml manifest fix

Fix for broken yaml manifest navigation
Description
The homePage is not set and graphql query for homePage returns null, so navigating to site gets blank page.

When homePage / root url is undefined or '/' it will fetch the first available page in the nav as home page.
Related Issue

Motivation and Context

Required to support yaml manifest file.
How Has This Been Tested?
Tested locally in develop and build

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Code looks good but can you add a test where the homepage is not specified?

@macdonst added test for the missing homepage, anything else pending here before we merge?


⚠ Nebulance has degraded performance

In 1b57a0b, Nebulance ($NBL) experienced degraded performance:

HTTP code: 200
Response time: 2743 ms

Resolved: Nebulance performance has improved in 3ab3ae5 after 6 minutes.


Tools = > Sweep Private Key Icon greyed

Hello
I am trying to sweep a private key into Sparrow wallet but it seems the icon is greyed in the section Tools
= > Sweep Private Key Icon greyed
thanks a lot

Sweep Private Key is greyed out while disconnected. Have you checked your server configuration?

Thank you for your reply Sebastian.
Yes if online I am able to connect to Emzy Server and the field is not greyed...
However I do not mean to do that but rather the setting below instead so as to minimize attack surface.
The setting is on 2 desktops and no hardware wallets come into play.
1/ DESKTOP 1 HOT WALLET . being Sparrow WATCH ONLY wallet via the Public Key Xpub or Zpub taken from the air gapped Desktop 2 . This Hot Wallet is meant to be connected to Emzy Server or Bitcoin Core via a PSBT file.
2/ DESKTOP 2 COLD WALLET.  being Sparrow Air Gapped Wallet dedicated to Signing PSBT files that are later fed into Desktop 1 for spending.
I would like to import or rather SWEEP a paper wallet into Desktop 2 that is NEVER connected to internet.
In this case the field is greyed and I am not allowed to do this... contrary to ELECTRUM wallets set in TAILS
I hope it is clear for you
thanks for helping
Regards

The reason Sparrow requires you to be connected is because it needs to search for UTXOs connected to the private key you enter. It can then construct a transaction with these UTXOs as inputs, allowing Sparrow to sweep those funds into the provided address by broadcasting the constructed transaction.
It would also technically be possible to retrieve the UTXOs from the public key derived from the private key (which would be a new feature) but I'm not sure that Electrum supports that?

Hi Craigraw
If you run the link below
https://www.youtube.com/watch?v=ixnTZDZ0-yk
Crypto Guide explains in depth what I need at the following time frames + you can see enclosed the set up.
5 minutes 00 sec for the air gapped device or a laptop.
thank you

I understand the use case. Unfortunately, Sparrow does not support wallets with single keys, which are required to support this use case. Supporting single key wallets would add significant complexity to the codebase, which I don't feel is justified by their relatively rare use these days.
The functionality to sweep a private key does not create a wallet, but rather finds any available UTXOs from the connected server, signs them with the private key and broadcasts the resulting transaction. Since all funds associated with a private key get immediately spent using this tool, the risk of entering the private key into an internet connected computer is certainly reduced (although not I'll grant completely eliminated).

Closing this off as unsupported.


proposal: text/template, html/template: add LookupFunc, LookupOption methods

It is possible using only exported symbols to write a type-checker for templates. There is just one missing piece: to check a function call like {{len .}}, the checker needs the function signature, but there is no way to retrieve that from a Template.
To work around this, I copied the information for built-ins from text/template, and I must ask the user to pass to my checker whatever FuncMaps they used when parsing the template. The first solution is brittle and the second unpleasant.
All that is missing is the method Template.LookupFunc(name string) interface{}. It would behave much like the unexported findFunction function in text/template/funcs.go, but it would return the unreflected function value or nil if the name was undefined.
I propose it be added to both text/template.Template and html/template.Template.

Actually, there is another bit of info that needs to be exposed: the options set with Template.Option. A LookupOption(name string) string on Template would also be useful.

LookupFunc would be convenient (although for user functions it can be done with reflection). However, the types of the built-in functions are unavailable.

I'm not entirely sure these are general enough to warrant the complexity they would require us to support.
I'm also not entirely sure that the functions can't be changed after type-checking and before execution.
It seems like any kind of type-checking will stop being able to do anything as soon as there is an interface{}, right?

I'd settle for making the built-in template functions visible. I don't understand the comment about interface{}. If the call is t.Execute(x), then t.Check(xx) ought to work fine as long as reflect.TypeOf(xx) == reflect.Type(x). Type checking just needs to check that the fields and methods used in the template exist on the argument.
My use case is in the debug server started by gopls. It stopped working when some underlying data structures were refactored. There's no way to detect that in unit tests presently, but t.Check() could go in debug_test.go, and would discover that the templates could no longer execute because of type errors.

It seems like any kind of type-checking will stop being able to do anything as soon as there is an interface{}, right?

I think this means that if you pass a value of
type homePage struct {
    Name string
    Details interface{}
}

to the type-checker, then You can check {{.Name}} but not {{.Details.Foo}}.
That's correct, and in fact that happens in the pkgsite templates. But in that case we usually call an associated template:
{{if ....}}
    {{template "versions" .Details}}
{{end}}

and "versions" does assume a specific type. So I just call Check on t.Lookup("versions") with that type.

It is possible to get user-defined func maps via reflection, and I've made that change. But it makes the code depend on implementation details. For instance, for html/template I need reflect.ValueOf(*t).FieldByName("text").Elem().FieldByName("parseFuncs").

I'm also not entirely sure that the functions can't be changed after type-checking and before execution.

They can. You can also pass a different dot type to Execute than the one you pass to Check. I'm not sure I understand your point. I think you're arguing that this sort of checker isn't very useful because it can be fooled, but in practice one would write tests to avoid that as much as possible—for instance, by defining the FuncMap in a global and referencing it in the tests.

The difficult part about this issue is that committing to public API is forever, and we don't really know whether we want to commit to this. But I also don't want to stand in the way of you building a useful tool and exploring the space of possible changes. For example it might be that the right long-term API is not LookupFunc and LookupOption but instead adding your Check to the template package, where it will have access to internals. I don't know.
It sounds like if you've got a way to not be blocked, by using reflection, that might be the right answer for now, and then we don't have to decide whether to add LookupFunc and LookupOption more generally.

I'm not blocked by this issue.

adding your Check to the template package

Should I file a separate proposal for that, or co-opt this one?

Please file a different proposal once you have some experience using it and think all the wrinkles are ironed out. Thanks!
Will treat this one as retracted.

Please file a different proposal once you have some experience using it and think all the wrinkles are ironed out. Thanks!
Will treat this one as retracted.

No change in consensus, so declined.
— rsc for the proposal review group

No change in consensus, so declined.
— rsc for the proposal review group


URI cleanup of non-path components

My previous branch fixed URI cleanup for path components. This branch extends that fix to address Issue #429, which requires URI cleanup for the query part of the URI.
I have added comprehensive tests for the sanitisation of the query part of the URI, and rearranged the call to utils.requote_path so that it is now applied to the whole URI after it is constructed, and not just the path. Note that this required that all URI components be converted to UTF-8 before the URI is reconstructed (since the URI is now sanitised after reconstruction). I have renamed utils.requote_path to requote_uri to reflect its new role.

This is fantastic. Thanks a ton. I really appreciate this.

:cake:


Document keyword "polling_interval" in client if any LRO

:keyword polling_interval: Default waiting time between two polls for LRO operations if no Retry-After header is present.
:param_type polling_interval: int

To be in the client, if there is any LRO (to avoid confusion if there is not). Multi-api client as well.

Solves https://github.com/Azure/azure-sdk-for-python/issues/1120


Incorrect Transform/Rotation Operator calculation

https://github.com/crosire/scripthookvdotnet/blob/df616621cba98e01e62661e4e80f3d22927d1b54/source/scripting/Math/Quaternion.cs#L720

fixed in PR #775


Clarify Sticky Session guidance

Would be great to be very specific on this page about ARR Affinity (sticky session) guidance for Blazor Server applications leveraging Azure SignalR.
Although this document makes it very specific, the ASP.Net Core documentation states otherwise and is generally confusing:
https://docs.microsoft.com/en-us/aspnet/core/signalr/scale?view=aspnetcore-5.0
Not sure if this comment should be directed at the product group supporting this page, but want to make sure the docs across both ASP.Net Core + this specific doc are clear/consistent

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9b20b470-161a-8723-b66d-c0c1804874f0
Version Independent ID: 2712f7a2-90e7-0012-f7d9-f3a7e7e345d7
Content: Host and deploy ASP.NET Core Blazor Server
Content Source: aspnetcore/blazor/host-and-deploy/server.md
Product: aspnet-core
Technology: aspnetcore-hostdeploy
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @runtimeware ... In that case ... i.e., "the ASP.Net Core documentation states otherwise and is generally confusing" ... open the issue from the bottom of that page using it's This page feedback button+form. These two topics map to different maintainers for most work items, and the metadata attached to that issue will ping that author to take a look.
If this topic (Host and deploy ASP.NET Core Blazor Server) has one or more specific problems, then let me know what those problems are. I'll re-open this issue to work on it. Please be specific. I'm 🏃🏃🏃🏃⛰⛏😅 on many issues as far as the 👁 can see ... well into 2022 at this point. It's easier/quicker for me to work out doc updates when the dev can report the exact problem.
They'll probably say the same thing for the other topic. You'll probably need to tell them how that topic is confusing in your opening remarks.


Fix NiceHash for ERGO

Checked works thx Konstantin35

This change is not compatible with many miners and won't be merged in this form. If this was conditional for Nicehash only, that might be a different story.

in which case would it be incompatible?

in which case would it be incompatible?

Miner apps expect diff = 1

Could you just make the change apply only when Nicehash is detected?

Any update on this?

yes, there is a solution, it takes time

Implemented in 48c4fe91608cc37884cb3c9846afb3a2b14305d6.


Cross-build for Scala.js 1.0/0.6

Adresses #43
Blocks https://github.com/scopt/scopt/pull/280
Blocked by https://github.com/typelevel/scalacheck/issues/629
💥 Dropped legacy ScalaCheck 1.13.5 integration since ScalaCheck 1.13.5 is unlikely to be published for Scala.js 1.0, and Cats ecosystem have already moved on.
https://github.com/monix/minitest/pull/51#issuecomment-589557719

ScalaCheck 1.14.3 is available for Scala.js 1.0, so I think you just need to bump that version number

@SethTisue
Thanks !!
Oh, but legacy scalacheck for Scala 2.11 is not published for Scala.js
https://github.com/monix/minitest/blob/cb8c0ef5964b91e9970996bf768ec3d6cf3e5ace/build.sbt#L229-L232

Oh, but legacy scalacheck 1.13.5 for Scala <2.12 is not published for Scala.js 1.0

Right. I don't think it ever will be.

In case you can't configure the build, it might be time to drop the ScalaCheck 1.13.5 integration, now that Cats and its ecosystem have finally moved on.
People can just copy/paste that trait.

OK,, dropped legacy ScalaCheck integration.

On 21 Feb 2020, at 12:32, TATSUNO Yasuhiro wrote:

OK,, dropped legacy ScalaCheck integration.

👍 we'll need a version bump too, will take care of that on release.


change much  231029_2350

👷 Deploy Preview for yzm0518 processing.

Name
Link

🔨 Latest commit
71f3eb6edb61bd36543f3196fc155d0efeae26a0

🔍 Latest deploy log
https://app.netlify.com/sites/yzm0518/deploys/653e7fb7b1461900086cbeb6


Numerous changes

This pull request makes 4 changes:

Fix bug when running in bun (see https://github.com/oven-sh/bun/issues/4217)
Add support for function expressions, including arrow functions
Add support for 'optional' params, wrapping the param name with square brackets where applicable, as per the docs
Remove obsolete params from JSDoc (i.e. params that may no longer exist for the function)

Please let me know if you would prefer seperate PRs (if there's reasonable likelihood they'll be merged)
This fork (with these changes) can be used with the @jackcannon/ts-to-jsdoc public npm module

Nice work, I wish we had some Playground to quickly test PR's like this one...

These look great, thanks a lot! It might be a few days before I can get to taking a closer look and merging, but everything does check out at first glance. (PS: that Bun/Node difference is really interesting, thanks for taking notice of that!)

Looks good to merge, I would just appreciate if you could split up your changes into individual PRs — just to keep things neat!

Great! Will close this and open some smaller PRs