Issue #458: Make SendGrid permissions management easy

I've hardcoded the values in as expressed in the issue, and the dynamic __call special method will determine if the group permissions exist before adding them to the scopes collection.
You can ignore the examples php file if you'd like.
I won't sign the CLA as it stands because it violates the spirit of the Github CLA and hacktoberfest, but maybe this work can help you moving forward!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you @mookman288!
We greatly appreciate your contribution and would love to learn what specifically is bothering you about our CLA. If you prefer to discuss privately, please reach out at<EMAIL_ADDRESS>With Best Regards,
Elmer

@thinkingserious It is my personal opinion that all of this seems to go against the spirit of open source:

you agree that we may register a copyright in any contribution and exercise all ownership rights associated with it; and
you agree that neither of us has any duty to consult with, obtain the consent of, pay or render an accounting to the other for any use or distribution of any contribution.

make, have made, use, sell, offer to sell, import, transfer and otherwise practice any contribution in whole or in part, alone or in combination with or included in the project or any product, work, or materials arising out of the project; and

And as comparison to the GitHub CLA:
https://cla.github.com/agreement
I believe there's a distinct difference in legalese and intent here. Unfortunately I wasn't aware of these specific lines until after I had completed the work. I hope that sheds light on my view.

@mookman288 [I am not a lawyer and just giving my opinion here] I totally understand the hesitation. We decided a while ago to follow in the footsteps of many companies who are trying to protect the contributors to their open source repositories and themselves when contributing or accepting contributions from the community.
As the person responsible for trying to provide a great experience for developers in our open source and user communities, I hope that the wording we have in our CLA can be seen as a positive and not a negative.

@mookman288,
Thank you for taking the time to elaborate.
In thanks for the work you did complete, we would like to offer you some swag. Just simply fill out this form. Thanks!
With Best Regards,
Elmer


Moving Car Game

Assign me this
creating a game featured with jumping, and moving a car using HTML, CSS and javascript

@ishikagoyal02 Hey! i want to work in this issue


Improve metadata annotations

It's great to have winmd metadata available 🎉 but a few type annotations are missing.
IDStorageFactory::SetDebugFlags::flags should be DSTORAGE_DEBUG. And IDStorageQueue has non-optional output pointers, that don't seem to be properly represented in the metadata and cause windows-rs to generate a by-mutable-reference getter rather than allocating and returning the object.
All of that is solved with the following mapping.
--memberRemap
IDStorageFactory::SetDebugFlags::flags=[AssociatedEnum("DSTORAGE_DEBUG")]
IDStorageQueue::RetrieveErrorRecord::record=[RetVal]
IDStorageQueue::Query::info=[RetVal]

https://github.com/Tsukisoft/direct-storage-rs/commit/6a7f8c5d7e8b744bcf6f744ae661f8018528b6bf

Note that when generating custom metadata (link above), the #defines from dstorageerr.h disappear. Were these mapped manually as enum constants when Microsoft generated the published .winmd?
There's a request to push the headers to this repo somewhere for convenient access, can the same be done for the (supposedly minimal) .csproj and emitter.settings.rsp (and other filtes) related to the .winmd build so that users can repro a similar file and contribute improvements like the ones suggested in the OP?


stm32cubemx: 6.10.0 -> 6.11.1

Description of changes
Updates stm32cubemx to version 6.11.1
This pull request additionally fixes
error: assertion '(((! ((args) ? pname)) || (! ((args) ? version))) -> ((args) ? name))' failed at /nix/store/pbizjdnmd8qxy4hyfk8wzvc4f8x47hyk-source/pkgs/build-support/build-fhsenv-bubblewrap/default.nix:29:1
when trying to nix run github:NixOS/nixpkgs#stm32cubemx
Resolves #306978

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I tested some things which have failed in previous builds:
Logging in: Works
Creating a new project: It seems the window doesn't render. I just get a white window. Can anyone else check if this is the same for them?

Tested creating new project:

Ran:

NIXPKGS_ALLOW_UNFREE=1 nix run --impure 'github:checooh/nixpkgs/update-stm32cubemx#stm32cubemx'

Pressed "File-New project..." in the main menu.
After dowloading some files, the "New Project" window opened. In "MCU/MPU Selector" entered "STM32F103C8T6" and selected it from the "MCUs/MPUs List" by double-clicking.
The main window has opened. Entered "Project Manager", entered project name "test", pressed "GENERATE CODE".
The program has required me to log in (turned out, I wasn't already), where I have observed some strange behavior - I had to click password field twice to move cursor to it, and also I wasn't able to click "Remember me". After moving the window, and clicking again, it finally worked. The code generated OK.
Closed the program and repeated all of the above to test, whether it's all working when I'm already logged in. Everything worked OK.

I have to note, that my installation (and subsequently, the contents of ~/.stm32cubemx directory) of stm32cubemx is very fresh, so maybe it has some effect on the functionality.

Hmmm.
These are the logs around when I open the New Project window:
Error: Failed to open Wayland display, fallback to X11. WAYLAND_DISPLAY='wayland-1' DISPLAY=':0'
Apr 27, 2024 7:06:18 PM java.util.prefs.FileSystemPreferences checkLockFile0ErrorCode
WARNING: Could not lock System prefs. Unix error code 32679.
Apr 27, 2024 7:06:18 PM java.util.prefs.FileSystemPreferences syncWorld
WARNING: Couldn't flush system prefs: java.util.prefs.BackingStoreException: Couldn't get file lock.
Apr 27, 2024 7:06:48 PM java.util.prefs.FileSystemPreferences checkLockFile0ErrorCode
WARNING: Could not lock System prefs. Unix error code 32679.
Apr 27, 2024 7:06:48 PM java.util.prefs.FileSystemPreferences syncWorld
WARNING: Couldn't flush system prefs: java.util.prefs.BackingStoreException: Couldn't get file lock.
Apr 27, 2024 7:07:18 PM java.util.prefs.FileSystemPreferences checkLockFile0ErrorCode
WARNING: Could not lock System prefs. Unix error code 32679.
Apr 27, 2024 7:07:18 PM java.util.prefs.FileSystemPreferences syncWorld
WARNING: Couldn't flush system prefs: java.util.prefs.BackingStoreException: Couldn't get file lock.

Do you also see these repeating messages?
Is your system wayland or xorg? I tried forcing xwayland and got the same result, a white screen, but if I click randomly, it seems to open links, which is pretty interesting.

dig stmicroelectronics.d3.sc.omtrdc.net
stmicroelectronics.d3.sc.omtrdc.net. 1 IN HINFO "This query has been locally blocked" "by dnscrypt-proxy"

Truly amazing.

Do you also see these repeating messages?

I have no message about wayland (not a single word in the entire console output), but I do have the "WARNING: Could not lock System prefs." repeating message.

Is your system wayland or xorg?
I've got wayland, plasma6, sddm and intel graphics.


how to choose HuBERT pretrained checkpoint

What is your question?
I try to reproduce the results with 100h finetune data. But my final results is not so good, wer of test-clean/test-other=8.2300 / 17.3509
training details
First iteration
100 clusters with mfcc feature, follow hubert_base_librispeech.yaml config, trained with 6 gpus
training loss and correct rate
250k step: loss_m_0=3.329, correct_m_0=0.364995, correct_u_0=0.0493537
400k step: loss_m_0=3.144, correct_m_0=0.38992, correct_u_0=0.0888545
it's obvious that 400k's result better than 250k step, should I choose 400k step checkpoint or continue training for more step?
Second iteration
500 clusters with 6 layer transformer feature(use the 250k step checkpoint as described in the paper), trained with 8 gpus
training loss and correct rate
250k step: loss_m_0=3.712, correct_m_0=0.382826, correct_u_0=0.635071
400k step: loss_m_0=3.422, correct_m_0=0.417456, correct_u_0=0.662054
is loss_m_0=3.422 good enough?
Finetune
follow base_10h.yaml, trained with 8 gpus, stop at 216000 updates(epoch 600)
Decode
viterbi decode, select the 100k step(280 epoch) checkpoint, wer result is test-clean/test-other=8.2300 / 17.3509

What have you tried?
What's your environment?

fairseq Version : 0.12.1
PyTorch Version : 1.10.0
OS (e.g., Linux):
How you installed fairseq (pip, source): source
Build command you used (if compiling from source):
Python version: 3.8
CUDA/cuDNN version:
GPU models and configuration:
Any other relevant information:

Hi,
what is the final loss value when you are in finetune(10h data).
Looking forward to your reply, thank you.

test-clean

how about you loss in the final finetune step?


polymorphic_allocator doesn't seem to work with device_memory_resource

The following doesn't compile
    {
      thrust::device_memory_resource memres;
      thrust::mr::polymorphic_adaptor_resource<void *> adaptor(&memres);
      typedef thrust::mr::polymorphic_allocator<double, void *> Alloc;
      Alloc alloc(&adaptor);

      do_stuff_with_vector<thrust::host_vector<double, Alloc>>(alloc);
    }

Nor does
    {
      thrust::device_memory_resource memres;
      thrust::mr::polymorphic_adaptor_resource<
          thrust::device_memory_resource::pointer>
          adaptor(&memres);
      typedef thrust::mr::polymorphic_allocator<
          double, thrust::device_memory_resource::pointer>
          Alloc;
      Alloc alloc(&adaptor);

      do_stuff_with_vector<thrust::host_vector<double, Alloc>>(alloc);
    }

Do they belong to the same design space?
Took a look at
template<typename Pointer = void *>
class polymorphic_adaptor_resource THRUST_FINAL : public memory_resource<Pointer>
{
public:
    polymorphic_adaptor_resource(memory_resource<Pointer> * t) : upstream_resource(t)
    {
    }

    virtual void * do_allocate(std::size_t bytes, std::size_t alignment) THRUST_OVERRIDE
    {
        return upstream_resource->allocate(bytes, alignment);
    }

Inheriting from memory_resource<Pointer> doesn't look right, because void* do_allocate can fail to override Pointer do_allocate from the base
thrust/mr/polymorphic_adaptor.h(34): error: return type is not identical to nor covariant with return type "thrust::cuda_cub::pointer<void>" of overridden virtual function "thrust::mr::memory_resource<Pointer>::do_allocate [with Pointer=thrust::cuda_cub::pointer<void>]"

Let's say it's memory_resource<void*>, then void* do_allocate expects Pointer to be convertible to void* -- not the case for tagged pointers, so thrust::device_memory_resource doesn't work.
thrust/mr/polymorphic_adaptor.h(41): error: no suitable constructor exists to convert from "void *" to "thrust::cuda_cub::pointer<void>"
          detected during instantiation of "void thrust::mr::polymorphic_adaptor_resource<Pointer>::do_deallocate(void *, size_t, size_t) [with Pointer=thrust::cuda_cub::pointer<void>]"

I'm not familiar with the design, so correct me if I'm wrong.  I merely want a pmr vector that can decide to use device memory or managed memory at runtime.
PS: in the changelog it says thrust::mr::polymorphic_allocator<T>, but actually it is thrust::mr::polymorphic_allocator<T, Pointer>, and I couldn't make it work with std::vector in MSVC
std::vector<double, thrust::mr::polymorphic_allocator<double, void*>> v;

2017\Community\VC\Tools\MSVC\14.16.27023\include\xutility(323): error: no instance of constructor "thrust::mr::allocator<T, MR>::allocator [with T=double, MR=thrust::mr::polymorphic_adaptor_resource<void *>]" matches the argument list
          detected during:
            instantiation of "std::_Compressed_pair<_Ty1, _Ty2, false>::_Compressed_pair(std::_Zero_then_variadic_args_t, _Other2 &&...) [with _Ty1=std::_Rebind_alloc_t<thrust::mr::polymorphic_allocator<double, void *>, double>, _Ty2=std::_Vector_val<std::conditional_t<true, std::_Simple_types<double>, std::_Vec_iter_types<double, size_t, ptrdiff_t, double *, const double *, double &, const double &>>>, _Other2=<>]"
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\vector(422): here
            instantiation of "std::_Vector_alloc<_Alloc_types>::_Vector_alloc() [with _Alloc_types=std::_Vec_base_types<double, thrust::mr::polymorphic_allocator<double, void *>>]"
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\vector(651): here
            instantiation of "std::vector<_Ty, _Alloc>::vector() [with _Ty=double, _Alloc=thrust::mr::polymorphic_allocator<double, void *>]"
mr_basic.cu(54): here

D'oh! That is indeed wrong. You've correctly identified the issue.
The polymorphic adapter has been included more as a proof of concept, to show that you can still achieve the std::pmr polymorphic semantics even in a design that expects to not make virtual calls (at least at the top level). the void*s in its definition should have, in fact, been Pointers.
I'll try to get a fix out to master soon, and it should land in the CUDA toolkit the next time we do a proper release.
Re your PS: if that is the line of code you're trying to compile, then it won't, because the polymorphic adapter isn't default constructible.
Btw., glad to see that someone is experimenting with the new toys :)

I see.  std::pmr::polymorphic_allocator is default constructible though... but I could have read the error message more carefully :) Thanks for working on this.

The standard equivalent always knows what global resource to construct itself from, since there's just one. Since the Thrust version of this interface is more statically typed, it's harder to do that sensibly. The default-constructible allocator type that Thrust provides is called stateless_resource_allocator, which in a hindsight is a rather bad name and we'll probably want to rename it one day.
The original issue you've reported should be fixed on master now; I don't yet know what release of the CUDA Toolkit the fix will ship in.


Defer client hooks import to allow using env in them

ref #8464
Need some insight on this commit, without it, all the tests start failing at random because it can't find the selector that's set on hydration, no matter what the timeout is. Although it seems like the wrong location to put it in.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

It's weird indeed that this makes things fail, don't have a good idea why just from looking at it - before this change, it was loaded even earlier (eagerly inside client.js).
@dominikg you had ideas about some init hook that blocks starting the client until for example the language is determined. Would the timing of "create and init client -> run hooks -> hydrate and start router" be wrong for this use case?

going to close this in favour of #8957, which is finally inching towards being shippable, after a detour that involved learning more than i ever thought i'd need to know about the behaviour of preload and modulepreload links


Vulnerability in serve-static that just got a fix

Hi,
I have vulnerabilities scan as part of my CI/CD process.
I'm getting this vulnerability report on your latest package (4.20.0):

I went to the serve-static github and just saw that they published a fix for this exact vulnerability 1 hour ago.
Will it be possible for you to publish a new patch version that will include this fix?
Thanks,
Ori Panush.

Yes. Working on it.

https://github.com/expressjs/express/releases/tag/4.21.0

Its still reported in 4.21.0 the new version "1.16.2" of serve-static is vulnerable @wesleytodd


Forum migration tracking issue

[WIP]
Forum needs to move from trident to tribune, encompassing both our own tweaks & other changes to prepare for an upgrade to PHP 7.4 then PHP 8.0 in early summer. This is a tracking issue for tasks involved since it's not trivial.
Sandbox

[x] set up sandbox subdomain on tribune (@petecoper)
[x] get migration snapshot of files + db from trident (@petecoper)
[ ] reconfigure snapshot for sandbox domain on tribune  (@petecoper)

[ ] list line items here

[ ] apply modifications and benchmark database upgrade process on tribune (perhaps off peak if intensive action) (@philwareham)
[ ] sanity check front- and admin-side for any snagging on tribune  (@philwareham)
[ ] sign off sandboxing process (@philwareham)

Preflight

[ ] decide schedule for migration (@petecooper & @philwareham)
[ ] communicate to forum & socials (@petecooper or @philwareham)
[ ] set forum A and AAAA records to minimum TTL (@petecooper or @philwareham)

Launch

[ ] check full backup from trident schedule (@petecooper)
[ ] set forum on trident to maintenance mode (@petecooper)
[ ] full backup locally (@petecooper)
[ ] repoint DNS to tribune (@petecooper)
[ ] get new TLS (@petecooper)
[ ] restore backup to tribune (@petecooper)
[ ] create, run and check full backup from tribune (@petecooper)
[ ] run database upgrade script(s) (@philwareham)
[ ] run and check full backup from tribune (@petecooper)
[ ] disable maintenance mode on tribune (@petecooper or @philwareham)
[ ] communicate to forum & socials (@petecooper or @philwareham)

Inflight
Day of

[ ] monitor resource usage (@petecooper)
[ ] monitor socials (@petecooper or @philwareham)

+3 days

[ ] get archive snapshot of final trident  (@petecooper)

Looks like a plan. Shout when ready for my tasks.

I'm still getting a brick wall when moving to another domain, so I need to investigate why that's happening. Will be in touch.

We're good. Closing.


ref is called before element is ready in DOM, or is it by design ?

Describe the bug
like,

 console.log(element.parentElement)}>

It will always be null, as it isn't in the DOM yet.
However if we want to do sth at the moment the given element is in DOM,  exp getBoundingClientRect, it can be annoying.
In some cases this can be done by using onMount instead, as in #1217, however ref can be much easier sometime, or you may have to use both.
It won't be surprising if this behavior is by design, but is there a "recommended practice" for this usage ?
Your Example Website or App
not yet
Steps to Reproduce the Bug or Issue
just the code above.
Expected behavior
I hope there is a way to make it non null.
Screenshots or Videos
No response
Platform

OS: NA
Browser: any
Version: 1.5.9

Additional context
No response

Yeah refs are assigned element creation time. No need to do another pass. We usually point people to use them with onMount or createEffect. Those run after everything has been attached.

So the recommended practice is to store the ref somewhere (into a signal or store maybe), and do the logic in a onMount or createEffect.
Is it possible to omit the onMount part somehow, so the code can be easier to read ?

It compiles to just calling the provided function. So this is asking if the framework can insert onMount because Solid otherwise doesn't touch these nodes again. The current behavior would break in this case as ref's are present to be part of rendering.


tf.feature_column.shared_embeddings cannot be saved

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): NO
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): OSX 10.15.5
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.2.0-rc4-8-g2b96f3662b 2.2.0
Python version: 3.7.4
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: CPU only
GPU model and memory: CPU only

Describe the current behavior

Describe the expected behavior
should save the model successfully
Standalone code to reproduce the issue
import tensorflow as tf
from tensorflow import feature_column
tf.compat.v1.disable_eager_execution()

# Define categorical colunm for our text feature, which is preprocessed into sequence of tokens
text_column = feature_column.sequence_categorical_column_with_vocabulary_list(key='text', vocabulary_list=list(['asd', 'asdf']))

max_length = 6
sequence_feature_layer_inputs = {}
sequence_feature_layer_inputs['text'] = tf.keras.Input(
    shape=(max_length,), name='text', dtype=tf.string)

text_embedding = feature_column.shared_embeddings([text_column], dimension=64)

# below is ok to save
# text_embedding = feature_column.embedding_column(text_column, dimension=8)

# Define SequenceFeatures layer to pass feature_columns into Keras model
sequence_feature_layer = tf.keras.experimental.SequenceFeatures(text_embedding)

# note here that SequenceFeatures layer produce tuple of two tensors as output. We need just first to pass next.
sequence_feature_layer_outputs, _ = sequence_feature_layer(
    sequence_feature_layer_inputs)
x = tf.keras.layers.Conv1D(8, 4)(sequence_feature_layer_outputs)
x = tf.keras.layers.MaxPooling1D(2)(x)
x = tf.keras.layers.Dense(256, activation='relu')(x)
x = tf.keras.layers.Dropout(0.2)(x)
x = tf.keras.layers.GlobalAveragePooling1D()(x)
# This example supposes binary classification, as labels are 0 or 1
x = tf.keras.layers.Dense(1, activation='sigmoid')(x)

model = tf.keras.models.Model(
    inputs=[v for v in sequence_feature_layer_inputs.values()], outputs=x)

model.summary()

# This example supposes binary classification, as labels are 0 or 1
model.compile(optimizer='adam',
              loss='binary_crossentropy',
              metrics=['accuracy']
              #run_eagerly=True
              )

model.save('model.h5')

@haifengkao
I am able to replicate the issue faced, please find the gist here.

Yes, I can replicate on my computer as well. I feel that the whole feature column stuff are underdeveloped.
Will this issue be solved?

Any updates on this? Been a while and issue persists for me as well.

Use Keras Preprocessing Layers instead of feature columns

I'm using the TensorFlow Ranking  library, which is dependent on feature_columns as input to transform the features into a format suitable for Learn to Rank modeling. Since feature_columns have not been deprecated, I would hope this bug would be fixed.

@tanzhenyu, I'm using the TensorFlow Ranking  library, which is dependent on feature_columns as input to transform the features into a format suitable for Learn to Rank modeling. Since feature_columns have not been deprecated, I would hope this bug would be fixed.

@ramakumar1729 Has TFR's support for KPL been opened sourced?

@davidcereal have you been able to find a solution?

@VikashPeddakota999, unfortunately not yet.

Was able to reproduce the issue in TF 2.5 version. Please find the gist here.Thanks!

Was able to reproduce the issue in TF 2.5 version. Please find the gist here.Thanks!
If you only want to use shared_embedding, you checkout my gist, I do a copy of yours and modify it
https://colab.research.google.com/gist/austinzh/361f7758b56dfa41b538c9b0c16feeb5/untitled86.ipynb

Hi, Could you please migrate from feature column to keras preprocessing, feature column will be deprecated going forward.
For more details refer Migrate tf.feature_columns to Keras preprocessing layers
Also, refer the list of API's fate under feature column here https://www.tensorflow.org/api_docs/python/tf/feature_column?version=nightly


Check the requirement for protoc in the ubi8-rust-builder

Check the requirement for protoc in the ubi8-rust-builder
protoc was added in #167 to the ubi8-rust-builder image.
It must be checked

if protoc is still required,
if the hard-coded protoc version should be parameterized,
if the protoc version should be updated,
if the SBOM must be adapted, and
if the upgrade of the protoc version should be added to the release steps.

I'm not seeing any changes so far in https://github.com/tokio-rs/prost/releases between v0.11.0 and v0.12.3 around the dependency on protoc.

And if it is still needed it should be documented why it's added to the UBI8 builder

if the SBOM must be adapted

I'd say "yes, if we do bundle stuff like the rustc version". FWIW, I'm not seeing rustc either in https://sboms.stackable.tech/sbom/secret-operator/905b575a458feb459b3e3dbe6a2bcd70372c8054f6f0a65526b5a91a418e0799 at least. @dervoeti is this intentional?

if the upgrade of the protoc version should be added to the release steps.

Arguably yes, but https://github.com/stackabletech/documentation/blob/314adc4e638a2f16fedf854b63f4c853080e023e/modules/ROOT/pages/release-guide.adoc doesn't seem to cover regular dependency updates either.

if the hard-coded protoc version should be parameterized,

Only really useful IMO if we want to support multiple ubi8-rust branches in parallel.

This is Waiting for Review, but I'm unsure what exactly I should review. Everything said sounds correct to me.

@sbernauer:
The review would be:

Reviewing https://github.com/stackabletech/docker-images/pull/615 (already done by @lfrancke)
Checking that my rationale for no-opping the rest makes sense (https://github.com/stackabletech/docker-images/issues/541#issuecomment-2047469199)

I think you rationales make sense in general.
However, I added protoc to the release-bump-versions list
Also, WDYT of bumping rustc 21.5 -> 26.1 right now with a PR?

Created https://github.com/stackabletech/docker-images/pull/624 for the bump

I personally would say LGTM, this can be closed


Reduce number of disabled DCHECKs

This limits the scope of disabled DCHECKs to just a handful of (still fairly sizable) parts of libchromiumcontent, where Electron currently experiences DCHECK failures.
I'm introducing a build-time flag ELECTRON_NO_DCHECK which, when defined, disables DCHECK.
The following GN targets have the flag applied:

base:base
content/browser:browser
content/child:child
device/geolocation:geolocation
net:net
third_party/WebKit/Source/core/loader:loader
third_party/WebKit/Source/platform:platform
ui/base:base
url:url

Additionally these files have debug checks explicitly commented out:

content/browser/frame_host/render_frame_host_impl.cc
ppapi/host/ppapi_host.cc
storage/browser/quota/client_usage_tracker.cc
third_party/WebKit/Source/platform/wtf/ThreadRestrictionVerifier.h
ui/latency/latency_histogram_macros.h

P.S.: I'm also sneaking in removal of one obsolete patch file.
PR to Electron: electron/electron#11271

"Removed obsolete 022-libgtkui.patch" seems to be unrelated to DCHECK, maybe it would make sense to remove it in a separate pr?

Probably we should try to build Electron and run its tests using libcc built from this branch.

The following GN targets have the flag applied:
base:base

it kinda scares me that we have the very basic stuff broken =/

it kinda scares me that we have the very basic stuff broken =/

It was broken before, too. This patch is part of what we discussed last week about nibbling away at this, enabling and fixing the DCHECKS in smaller chunks

@ckerr sure
I was trying to say that before we knew that some stuff is broken, but now we know that the very base stuff is broken.

Are we waiting for other approvals or can we merge now?
I really want this change in the Ch62 branch.

Let us first run the test suite, in case there is more stuff to disable with this.

I have created https://github.com/electron/electron/pull/11271 to start working with this, I think we might want to disable dchecks in v8. Current fails on dcheck in url target.

I quickly checked the failure
[6975:1127/210918.696407:FATAL:url_util.cc(490)] Check failed: !scheme_registries_locked. Trying to add a scheme after the lists have been locked.
I will disable DCHECK for the relevant GN target, but the problem is in how protocol.registerStandardSchemes is implemented. It will need to be refactored or removed to fix this properly. Schemes need to be added in AtomContentClient::AddAdditionalSchemes and nowhere else.

I will disable DCHECK for the relevant GN target, but the problem is in how protocol.registerStandardSchemes is implemented. It will need to be refactored or removed to fix this properly. Schemes need to be added in AtomContentClient::AddAdditionalSchemes and nowhere else.

@alespergl Can you create a task to fix it please?

https://github.com/electron/electron/issues/11273

btw, maybe it would make sense to rebase this branch onto the latest master
to get Jumbo build enabled, it could speed up the builds.

The reported failure was this one in ThreadRestrictionVerifier.h. That's why I disabled it. The DCHECKs you are referring to don't seem to be failing (so far). Let's see if we can get to a state where there are no DCHECK failures in tests and then work backwards from there.

@alespergl
-  DCHECK_NE(-1, idr) << " path: " << path;
+  // DCHECK_NE(-1, idr) << " path: " << path;

I don't think that we can simply ignore it =/
"chrome://resources/..." is Chromium internal "protocol" to access shared resources like libraries, fonts, images, etc. from internal pages. If we get a request to load some Polymer stuff (used on most internal pages of Chromium), it means we somehow load very unexpected pages.
I created an issue for Electron electron/electron#11289.

We can't ignore any of these. Nevertheless, we have been doing that so far. :)
Thanks for creating that issue, at least this one will hopefully be fixed soon.

We should probably update libcc reference in the electron/electron#11271 and merge it.

No worries, I'll do that when the merged commit is built. ❄


Parse error on xlink:href attribute

Current behavior
Parsing fails for files containing <use xlink:href="#slack-tile">
Expected behavior
Parsing works.
Steps to reproduce
Run linting for a file containing <use xlink:href="#slack-tile">

Thank you for your bug report! We're currently working on fixing it.

Release 0.0.4 has been published with the fix (#204) for the bug

Release 0.0.4 may have breaking changes to prior versions. We're sorry for the inconvenience


Is FileDialog complete?

I don't see a scenario where ChosenPath or I.chosenPath is ever set, so at the very least it appears non-functional for folder dialogs. I don't see a way to use it that doesn't involve changing code.

I made this simple change in my own branch but needs more review.
https://github.com/0x0ade/ImGuiCS/commit/40171191edd37d398b0e9671ab112935accd7f6a

I've never finished porting the C++ FileDialog to C#. Any changes are welcome :)


Migrate about package to etch

Closes https://github.com/atom/about/issues/9
Refs https://github.com/atom/etch/issues/28
This PR rewrites the about package to use etch! 🎉 ✨  Virtual DOM-ifying everything vastly simplifies the update logic of the UI, which should make things  much more maintainable, robust, and performant. This particular rewrite was a warm-up for tackling an etch rewrite of a much more complex core package in the future. 😈
TODO

[x] Remove jQuery
[x] Rewrite main as JS
[x] Fix SVG attributes in AtomLogo
[x] Figure out how to make standard stop complaining about "non-standard" JSX attributes
[x] Rewrite specs as JS? (might save for another PR)
[x] Clean up specs
[x] Extract model setup out of main to separate View Model
[ ] Document all the things

👀 @atom/feedback

Overall this looks really great. Awesome job! I'll try to give some more in-depth feedback later on.
I have one question though; any particular reason for using /** @babel */ instead of 'use babel' that we use elsewhere?

@mnquintana You may want to take a look at my updated soft-wrap-indicator package to see how I built the specs in JS.

@lee-dohm Ah thanks! I was intentionally trying to change the specs as little as possible – I liked that these were behavioral (/integration / acceptance) tests rather than unit tests, and leaving them largely alone meant that I could safely refactor without having to rewrite them all as unit tests (since units can change, especially during a big rewrite, I thought keeping behavior tests constant would be more valuable).
@thomasjo No real reason, but I think /** @babel */ looks better with the /** @jsx etch.dom */ pragma you have to add for JSX compilation support with etch.

Alright! I think this is ready for review now 👀 @atom/feedback @BinaryMuse
Are we still using AtomDoc for inline code documentation?

@nathansobo What would you think about adding some of your style recommendations here to a new JS section in the style guide? Would be good to have a reference now that we're writing more stuff in JS.

@thomasjo /** @babel */ is intended to supplant use babel.
@mnquintana Adding to the style guide would be fine. This code looks great modulo my comments if someone other than Machiste can provide independent confirmation that things work.

@nathansobo I think I've addressed everything now!
@atom/feedback Mind taking this for a spin? I'm thinking the easiest way to manually test this might be to download an old release from https://github.com/atom/atom/releases, apm link <this-package>, and then start the old release to make sure the update flow works as expected.

Just gave this a spin and seems to be working. Thanks @mnquintana for doing this! I look forward to the day when all the SpacePen is out of our system. We're on step closer thanks to your efforts. :heart:

👏  🚿  🛀  👏


r.Status().Update(ctx,object) is taking time

Question
What did you do?
I have a custom resource whose status I update twice, I have made sure these updates do not cause another reconcile by -> WithEventFilter(ignoreStatusUpdate()) in Setup manager.
    connected := r.checkABCConnection(abcR, abcObj, ctx)
if connected {
	setupLog.Info("ABC Present, moving to next step")
	r.getUpdatedABCObject(ctx, req)  // I'm getting the updated object before going forward to next step where I'll
                                                                       update the status object again
	//get other info and patch status
	r.checkABCOtherInfoConnected(abcRc, abcObj, ctx)
}
r.getUpdatedABCObject(ctx, req)

Get Updated Object Code
func (r *Reconciler)getUpdatedABCObject(ctx context.Context, req ctrl.Request) {
err = r.Get(ctx, req.NamespacedName, abcObj)
if err != nil {
	setupLog.Error(err, "Error fetching updated Object of ABC")
}

}
Updating status codes
func (r *Reconciler) updateStatus(abcObj *infraiov1.Abc, ctx context.Context, status string) { 	abcObj.Status.Status = status  	err := r.Status().Update(ctx, abcObj) // Update Func 	if err != nil { 		setupLog.Error(err, "Error: Updating Status") 	} }
func (r *Reconciler) updateOtherInfoStatus(abcObj *infraiov1.Abc, ctx context.Context, otherInfo map[string]string) { 	abcObj.Status.OtherInfo = otherInfo //update printer column 	err = r.Status().Update(ctx, abcObj) 	if err != nil { 		setupLog.Error(err, "Error: Updating Other Info Status") 	} }
Abc_types.go file (Status object)
// OdimStatus defines the observed state of Odim //+kubebuilder:validation:XPreserveUnknownFields type OdimStatus struct { 	Status  string            json:"status,omitempty"	OtherInfo map[string]stringjson:"other,omitempty"}
What did you expect to see?
Proper working of operator with status updates without throwing any error for status updates.
What did you see instead? Under which circumstances?
Sporadically witnessing error like :
2022-07-14T08:51:06Z    ERROR   ABC  Error: Updating OtherInfo Status   {"error": "Operation cannot be fulfilled on abc.infra.io.my.domain \"abc\": the object has been modified; please apply your changes to the latest version and try again"} github.com/abc-operator/controllers.(*Reconciler).updateOtherInfoStatus
This error is not supposed to come since I am getting the updated Object before I go to the OtherInfo step
Workaround I did:
I added some sleep in the update funcs like:
func (r *Reconciler) updateStatus(abcObj *infraiov1.Abc, ctx context.Context, status string) { 	abcObj.Status.Status = status  	err := r.Status().Update(ctx, abcObj) // Update Func 	if err != nil { 		setupLog.Error(err, "Error: Updating Status") 	} 	sleep(10) //10sec }
func (r *Reconciler) updateOtherInfoStatus(abcObj *infraiov1.Abc, ctx context.Context, otherInfo map[string]string) { 	abcObj.Status.OtherInfo = otherInfo //update printer column 	err = r.Status().Update(ctx, abcObj) 	if err != nil { 		setupLog.Error(err, "Error: Updating Other Info Status") 	} 	sleep(10) }
And with this I see that the object is up to date before the next step is taken.
So is this the expected behaviour of Update()? will it take some time? if so how many seconds?
$ go version (if language is Go)
go version go1.17.8 linux/amd64
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.0", GitCommit:"4ce5a8954017644c5420bae81d72b09b735c21f0", GitTreeState:"clean", BuildDate:"2022-05-03T13:46:05Z", GoVersion:"go1.18.1", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.4
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.5", GitCommit:"aea7bbadd2fc0cd689de94a54e5b7b758869d691", GitTreeState:"clean", BuildDate:"2021-09-15T21:04:16Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"linux/amd64"}

Hi @varshaprasad96 ,
This is not impacting the reconcile func.
The update takes place after throwing that error.. when I do "kubectl get abc", I see the updated status there
But the problem is... in the code, the updated Object is not fetched when I encounter that Error, and this is causing problem in the next step, as it is dependent on the previous update.
And considering the resource version that changes for each update, that is taken care by kubernetes only right?
So from our side, we should face this problem, Right?

Hi @kavyamani596,
When we use the client in the controller we are getting the state of the resource on the cluster at that moment. After that, if you update the resource OR the ks8 api ( see that has fields that are updated automatically by the API ) or another process/users to do so the state of the resource on the cluster is no longer the same.
I mean that, if we try to update a resource and the data/state that we have does not matches with the state of it when you send another update ( i.e the generation/resourceVersion will no longer the same since k8s updated them) the error the object has been modified; will be faced.
Therefore, I'd recommend before you do any new updates you fetch the resource again. Todo the check and the changes then update. If the update fails you are probably returning the error which will make the whole reconcile runs again and that can take more time ( spend unnecessary resources )
I hope that makes sense and that the above info help you out.
NIT: Less important: Also, your example/snippet code makes it not clear why you are updating the same resource twice. Could you not improve this code to have only 1 update.
In this way, it seems sorted out. If not, please let us know why not and what more is missing here for we happy you out.
c/c @varshaprasad96

hi @camilamacedo86
Yes I have done that step.
I think you missed to notice that..
    setupLog.Info("ABC Present, moving to next step")
r.getUpdatedABCObject(ctx, req)  **// I'm getting the updated object before going forward to next step where I'll
                                                                   update the status object again**
//get other info and patch status
r.checkABCOtherInfoConnected(abcRc, abcObj, ctx)

So we have a use case where the 2nd  update needs to happen after the first, hence we cannot change that sequence.

Hi @kavyamani596,
You say that you are I'm getting the updated object before going forward to next step where I'l update the status object again and still facing  "Error: Updating Other Info Status".
So, did you troubleshoot it to know when you fetch the resource you have the changes ?
You might be trying to retrieve the data before it actually is performed on the cluster side. It is not because you call the client.update that is done.
Here r.getUpdatedABCObject(ctx, req) are you checking if an error was faced and if that was accomplished? Did you try to add a sleep before retrieving the data and do the second update to see if then it will be acctually getting the latest state on the cluster?
Did you check if on the cluster you have other Operators or processes which are watching this resource and doing changes to it?

Hello @camilamacedo86 ,
a) So, did you troubleshoot it to know when you fetch the resource you have the changes ?
You might be trying to retrieve the data before it actually is performed on the cluster side. It is not because you call the client.update that is done
Yes, I did add a print log to check the object before proceeding, and there I was able to catch that this update issue is happening,
So when I added Print log before calling r.getUpdatedABCObject(ctx, req), the status would sometimes be updated and sometimes not..
b) Here r.getUpdatedABCObject(ctx, req) are you checking if an error was faced and if that was accomplished? Did you try to add a sleep before retrieving the data and do the second update to see if then it will be acctually getting the latest state on the cluster?
Get Updated Object Code
func (r *Reconciler)getUpdatedABCObject(ctx context.Context, req ctrl.Request) {
err = r.Get(ctx, req.NamespacedName, abcObj)
if err != nil {
setupLog.Error(err, "Error fetching updated Object of ABC")   --> checking this here... I never got this log
}
I added sleep when I after I did the update,
As soon as update is done, next step is called, so you can think that it is happening before getting of the updated object
func (r *Reconciler) updateStatus(abcObj *infraiov1.Abc, ctx context.Context, status string) {
 abcObj.Status.Status = status
 err := r.Status().Update(ctx, abcObj) // Update Func
 if err != nil {
  setupLog.Error(err, "Error: Updating Status")
  } sleep(10) //10sec  --> Here
  }

c) Did you check if on the cluster you have other Operators or processes which are watching this resource and doing changes to it?
yes, Currently we have only one operator in our cluster and this is it.


cageAHRS at full speed does not level.

Stratux version: v1.4r5
Stratux config: dual SDR, GPS yes (u-blox 7 GNSS), AHRS yes, battery: USB cable to cigarette lighter (ships power).
EFB app and version: Kwik EFIS and Kwik DMAP. EFB platform: Android 4.4.2. EFB hardware: Nexus 7 Tablet and Samsung Galaxy S2.
Description of your issue:  cageAHRS.
I am having some difficulty with implementing cageAHRS. The code seems to level the Stratux AHRS when I single step through it with the debugger, but when run at full speed there seems to be no effect.
Any ideas?
'
//
// Stratux "level" attitude display. Submit a blank POST to this URL.
//
public static void cageAhrs()
{
    Log.d("bugbug ", "cageAhrs");
    return postHttp("http://<IP_ADDRESS>/cageAHRS");
}

//
// Stratux sensor calibration. Submit a blank POST to this URL.
//
private String calibrateAhrs()
{
    return postHttp("http://<IP_ADDRESS>/calibrateAHRS");
}

private String getHttp(String addr)
{
    return doHttp(addr, "GET");
}

private static String postHttp(String addr)
{
    return doHttp(addr, "POST");
}

private static String doHttp(String addr, String method)
{
    URL url;
    StringBuffer response = new StringBuffer();
    try {
        url = new URL(addr);
    }
    catch (MalformedURLException e) {
        throw new IllegalArgumentException("invalid url");
    }

    HttpURLConnection conn = null;
    try {
        conn = (HttpURLConnection) url.openConnection();
        conn.setDoOutput(false);
        conn.setDoInput(true);
        conn.setUseCaches(false);
        conn.setRequestMethod(method); //"GET"
        conn.setRequestProperty("Content-Type", "application/x-www-form-urlencoded;charset=UTF-8");

        // handle the response
        int status = conn.getResponseCode();
        if (status != 200) {
            throw new IOException("Post failed with error code " + status);
        }
        else {
            BufferedReader in = new BufferedReader(new InputStreamReader(conn.getInputStream()));
            String inputLine;
            while ((inputLine = in.readLine()) != null) {
                response.append(inputLine);
            }
            in.close();
        }
    }
    catch (Exception e) {
        e.printStackTrace();
    }
    finally {
        if (conn != null) {
            conn.disconnect();
        }
        //Here is your json in string format
        String responseJSON = response.toString();
        return responseJSON;
    }
}

'

This appears to be an issue with either my development environment and/or the devices. It seems to work fine on another machine/devices.


Minor: minor perf test with new indexes in stage

This week I will trickle a few optimisations I have collected over the past few weeks ... culminating in a custom django migration. This specific commit has very minor code change which will take advantage of some test indexes currently set on stage which we want to measure there first.

LGTM


Fix IAM role assignment

⚠ need to apply this first: https://github.com/highwingio/concourse/pull/266 ⚠
Certain targets cannot take IAM roles. Attempting to assign causes an error in the resource creation.
The easiest fix I can find is simply to split up the two resource types that can take roles and those that can't. The way we merge these two groups currently doesn't allow us to easily parse the target type in a single rule.
Specs are kinda weird on this one, but it does detect properly. Unfortunately because the target depends on the actual IAM role creation, we can't detect post-apply values, But it does validate if the role is set to something at all.

@ianbender i found the problem: https://github.com/highwingio/concourse/pull/266


optimisation: Do some η-reductions

We take advantage of the previously introduced concept of "arities"
to determine when this optimisation is sound. Arity represents
how many arguments can be passed before the term is no longer in WHNF.
We can't η-reduce when the wrapping lambda has a higher arity, as
that would mean e.g. \x y z -> f x y z where f = \_ -> perror would be
optimised into \_ -> perror which has different behaviour.
 It doesn't have to be this restricted,
but then we'd need per-level tracking of variable usage by terms, which is
certainly possible (and also useful for automatic hoisting / CSE) but not
something I'm going to do in this commit.
Fixes #32

Note: This will mean that the following holds:
f = phoistAcyclic $ plam $ \x y -> _

g x y = f # x # y

f' = plam $ \x y -> g x y

f' ≡ f

Since @TotallyNotChase is off, I'll merge this, as there is no one else to test this new version with real code AFAIK.


Fix usage message in nix-prefetch-git

The comment related to the deepClone and no-deepClone options was
misleading as these options have no relation with submodules, but on the
the depth in git clone --depth n.

Good catch, thanks!


Audio Desync on Videos with VFR FrameRateMode if the "Original" and actual framerate differ

https://www.reddit.com/r/staxrip/comments/9tzo32/1900_audio_desync_on_videos_with_vfr/
Desktop (please complete the following information):

OS: Windows 10 Build 1803 x64
Version: 1.9

Audio is Copy/Mux'd btw

If there a delay needed for the audio it's handled by Mediainfo, if Mediainfo doesn't state there a delay StaxRip doesn't create delay for the audio.
Mediainfo 18.08 should not be used due to the bugs.

I dont see any information about Delays either with 18.0.0 or the MediaInfo directly in StaxRip <IP_ADDRESS>

Also its not typically a "delay" its more like it linearly grows in delay. as in at very start delay of 0, and by the end there would be maybe half a second delay.
sometimes its weirder and would be half a second delay up to the middle of the video, then starts slowly going back to no delay at the end of the video.
Both of these sources are loaded with FFVideoSource (automatic used) and are "MPEG1/2" but I believe they are MPEG2 as they are sourced from old DVD's

What I have noticed as mentioned in the reddit post is the difference in Framerate to original framerate, if I were to encode inside of Handbrake it would work fine. Odd enough, handbrake's source actually says its 23.98 (24000/1001*10 rounded up) so its probably working off "Original Frame Rate" rather than "Frame Rate", perhaps there's a way to properly do this with StaxRip? I know of the filters but which one is the better of them, there's many variants.

I added another example of when it DIDNT de-sync: https://www.reddit.com/r/staxrip/comments/9tzo32/1900_audio_desync_on_videos_with_vfr/
So this kinda confirms it should be encoding by "Original frame rate" over "Frame rate" if it exists.

If there no data about the delays then StaxRip has no way of knowing about it. HandBrake uses FFMPEG probe for there system to detect delays.
You also need to be careful on the filters you use if they affect the audio/FR or not. I know one effects the audio and it doesn't correct the audio in the process and ms delay has to be recalculated.
I think there something else going on, Since I have zero reports of audio desync.
I would avoid VFR, it's 100% useless and dumb to use in the first place. I have no idea why Handbrake added that in the first place. It does nothing but create problems. If anything it makes the video look worse then better.
Video rate could drop all the way down to 15fps if you use VFR.

Again as I mentioned, you basically just need to read fps on "Original frame rate" Tag instead of "Frame rate" tag if the source is VFR and if that tag exists. Also ive done all these tests with no filters only "Source".
Also again im not trying to encode to VFR, just sources that are already VFR are what cause this, if I could avoid I would but I cant.

It's a problem with MediaInfo some one else if having issues with VFR and reporting incorrect data: https://github.com/MediaArea/MediaInfo/issues/293
Once that gets corrected you shouldn't have any issues. In the mean time download and use an older version (Pre 18.08 builds).
You can also add AssumeFPS(24000, 1001)
If your using Vapoursynth you can unspec everything & Re-Spec it to proper video data.
Example:
clip = core.resize.Point(clip, matrix_in_s="unspec",range_s="limited")
clip = core.std.AssumeFPS(clip, fpsnum = int(%media_info_video:FrameRate% * 1001), fpsden = 1001)
clip = core.std.SetFrameProp(clip=clip, prop="_ColorRange", intval=1)
fpsden can be 1001 or 1000.
FYI, I'm pretty sure num value of 23976 is improper value, I've never come cross such a value. It's always 240000/1001. There so many different values for framerate it could be one of those rare cases.

It took Mediainfo close to a year to get HDR color corrected in the tool, Which I first reported to them in November 2017. It was only fixed a months or to ago. Who knows when this bug along with all the other bugs I've found in Mediainfo to be addressed.
I've reported all them, atlease they are aware of them.

Also handbrake didnt do shit, I said I used handbrake to convert the VFR source to CFR as it uses "Original frame rate". So just use Original frame rate on StaxRip and your good.

Do you mean install an older copy of it or put an older copy of it in StaxRip Directory? I really dont think its to do with MakeMKV, also when I did AssumeFPS it did in fact work better but since it wasnt the EXACT "Original frame rate" to the closest value possible, it was still off, but not near as much.

I really dont think you understand the actual issue here.
MediaInfo, Handbrake, FFMPEG, e.t.c have nothing to do with this.
If I were to AssumeFPS to the exact number of "Original frame rate" this issue does not occur, but it has to literally be bang on to the closest decimals.
If I dont, it will use "Frame rate" (Not "Original frame rate") resulting in it using lets say 24 fps instead of 24001/1001 (23.976) resulting in the issue.

For files that are variable frame rate but reporting constant you need to change the time codes for the orginal files video track before running staxrip.
fix audio sync when video track is variable frames
working fix
get the time codes the for the video and audio tracks where tc0 is TRACK1 and tc1 is TRACK2
"D:\staxrip\Apps\MKVToolNix\mkvextract.exe" timecodes_v2 "D:\badsyncefilename.mkv" 0:"D:\batch\filename_tc0.txt" 1:"D:\batch\filename_tc1.txt"
write a new file with frame rate
"D:\staxrip\Apps\MKVToolNix\mkvmerge.exe" --timecodes 0:"D:\batch\filename_tc0.txt" -o "D:\output_fixed_sync_filename.mkv" "D:\badsyncefilename.mkv" --ui-language en
when merging --timecodes 0:"TIMECODE_0.txt" must be at the begining or it will not take effect.
verify by checking the media info and the videos frame rate should change to variable from constant.
Now run staxrip on the new file you created and it should work.

I really dont think you understand the actual issue here.
MediaInfo, Handbrake, FFMPEG, e.t.c have nothing to do with this.
If I were to AssumeFPS to the exact number of "Original frame rate" this issue does not occur, but it has to literally be bang on to the closest decimals.
If I dont, it will use "Frame rate" (Not "Original frame rate") resulting in it using lets say 24 fps instead of 24001/1001 (23.976) resulting in the issue.

Where do you think all the Video data gets pulled From? MediaInfo. This isn't a StaxRip issue by any means.


Potentially relevant papers

Tsutsui 2022, "Minimal CMIP Emulator (MCE v1.2): a new simplified method for probabilistic climate projections" https://gmd.copernicus.org/articles/15/951/2022/

Added a "potentially useful papers" section to SFD doc


Remove duplicate gemspec

The cocaine gem is defined in same gemspec.
The issue occurs error by recent bundler gem.

@shioyama Please review if you have chance :star2:
You can see result of testing when merge this.
Before https://magnum.travis-ci.com/degica/basecamp2/builds/13887253
After https://magnum.travis-ci.com/degica/basecamp2/builds/13888400

Thanks!


runtime: crashes on Android O

Android O has a seccomp filter.
Unfortunately it disallows use of open and epoll_wait, which are used by the Go runtime. Fortunately, it allows for openat and epoll_pwait, which map directly to the former ones by passing them the right arguments.
So far as I can see, these support open and epoll_wait:

https://android.googlesource.com/platform/bionic/+/master/libc/seccomp/arm_app_policy.cpp
https://android.googlesource.com/platform/bionic/+/master/libc/seccomp/mips_app_policy.cpp
https://android.googlesource.com/platform/bionic/+/master/libc/seccomp/x86_app_policy.cpp

So far as I can see, these support openat and epoll_pwait:

https://android.googlesource.com/platform/bionic/+/master/libc/seccomp/arm64_app_policy.cpp
https://android.googlesource.com/platform/bionic/+/master/libc/seccomp/mips64_app_policy.cpp
https://android.googlesource.com/platform/bionic/+/master/libc/seccomp/x86_64_app_policy.cpp

In other words, 64-bit architectures are affected. ARM64 was already fixed. This CL fixes the remaining two architectures: https://go-review.googlesource.com/c/go/+/92895

Marking for 1.9.5, but note that this is also not fixed in 1.10.  We need some way to get a sense of whether the patches will work on a range of systems; likely they will but some experience is needed.  Probably best to commit them after 1.10 branches, and then consider backports to 1.10.1 and 1.9.5.

@ianlancetaylor This should probably be reopened until https://github.com/golang/go/commit/04e6ae6bc3ac9739568b0f1225ee5e2d53cba919 is backported to 1.9 and 1.10 branches.

CL 92895 OK for Go 1.10.1

Looks like we should also include CL 100877 and 100878 in 1.10.1.

Done.


Internal server error when using invalid X-API-KEY encoding

PDA version
0.4.0
Python version
3.11
Steps to Reproduce

Submit an invalid UTF-8 encoded X-API-KEY

Expected Behavior
Log message stating that the X-API-KEY is invalid
Observed Behavior
Exception raised and "Internal Server Error" returned.
File "/app/powerdnsadmin/decorators.py", line 462, in decorated_function
     apikey_val = str(base64.b64decode(auth_header), 'utf-8')
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb5 in position 0: invalid start byte

Resolved by PR 1479.


pre shared keys

Hi,
This is a PR in a serie of 6 PRs, as it was asked to split https://github.com/freifunkMUC/wg-access-server/pull/294 up into multiple PRs.
Serie:

feature/bring-your-own-public-key
feature/remove-all-devices-for-user
feature/purge-inactive-devices
feature/health-check
hygiene/put-common-auth-logic-into-func
(THIS PR) feature/pre-shared-keys

Dependency
This PR depends on https://github.com/freifunkMUC/wg-embed/pull/15 and its version has to be updated before this PR can be merged.
Feature:
This feature extends the wg-access-server, enabling a user to use wireguards pre-shared secret feature.
This adds a new form input to "Add Device":

@fbuetler can you update the version accordingly as the PR has been merged?

Hm npm install triggers no change locally 🤔

#0 3.070 npm ERR! npm ci can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.

Hm npm install triggers no change locally 🤔

#0 3.070 npm ERR! npm ci can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.

Can you try to rebase your changes again on master/main?

@fbuetler can you rebase your changes again? After that we can merge your PR


Add methods to create Pageables from a list of pages

Currently, we have a method to create a single page but not pageable. It would simplify mocking if we provided those as well.

We have one, it's being updated as part of the PR. I'll add a bit more text to it

/azp run net - core - ci


Adds method to generate a UUID

I needed the same thing as in #42 so here is a PR.
This should avoid to litter the application code with calls to Uuid::uuid1() in case later on there is an opportunity to switch to UUID v4 for instance.

Model::generateUuid() generates a Uuid in binary form (ready for use as the ->uuid attribute)
Model::generateUuid(true) generates a Uuid in string form (ready for use as the ->uuid_text attribute)

Tests are provided too.

Because in some cases you want the string representation of the UUID and not the binary version. So it allows to skip the string conversion method that would otherwise need to be added.
By default it returns something ready to be used in the column though.

Right. However, if you'd want a textual UUID, you can always generate one with the Ramsey package, I don't see a real need for this package to be concerned with generating those textual UUIDs 🤔

Package is using uuid v1 internally, but nothing prevents from making this configurable to use v4 or something else.
So the end user would only have a single entry point to get uuids in whichever version the package is using internally.
This is could be useful when writing tests too.
Could be another function however if it is just the parameter that bothers you.
Like generateUuidText for instance

I'm just not sure if it should be this package's concern. Could you give an example on how it'll improve writing tests?

It is just a convenient shortcut.
$textualUuid = MyModel::generateUuid(true);
// ....
$this->assertEquals("/my-model/$textualUuid", $url);

vs
$textualUuid = MyModel::decodeUuid(MyModel::generateUuid());
// ....
$this->assertEquals("/my-model/$textualUuid", $url);

As I said, this is not a must, this is just a nice convenient shortcut offered to the user. (just like Laravel helpers : str_xxx VS Str::xxx)

Yeah, I'd drop it for now. Feel free to make the needed changes, I'll merge this afterwards.

Done ;)

@vpratfr could you take a look at the conflicts? I'd like to merge this one :) (sorry for the delay)

Hi,
I don't have much time currently to work on this. However, a quick look at the conflict shows that it should take around 2s for you to resolve it when merging (looks like the test before mine got renamed + updated and git got confused by that). Else I can do that most probably next week (if not, that will be post holiday, end of August). Sorry.

No problem, I understand!

Should be fine now. All tests green.

Thanks, what's up with the changes to the README?

Just updated the README to remove references to the deprecated trait (which anyway is empty now). Hence no need to have that in the docs I guess.

Right, but it has nothing to do with this PR, right? Also the : void return type on the suffix method shouldn't belong in this PR. Sorry for the inconvenience, I know it's meant for the best; but we prefer to keep PRs concise and to the point.

Reverted them

@vpratfr are you done with the needed changes for this PR to have it merged or you might resubmit ?

Should all be good.

Awesome, thanks!


Use Docker to run tests in Travis

I've implemented a way of using travis and docker to run tests.
It can be simplified more but I wanted to show you this approach to know if it's worth spending more time working on it.
It spins up two Docker containers: one for mysql 8 and another one for matomo 3.5.
In the mysql container a dump of the matomo database is copied.
In the matomo container a basic configuration file is copied.
The tests are then executed against localhost:8080.
WDYT?

Is there any active maintainer? @brendoncrawford ?
Tests do not pass but at least now we know why :)
https://travis-ci.org/matomo-org/piwik-python-api/jobs/407984974

Hi @PabloCastellano
Unfortunately there currently is not an active maintainer.
Would you maybe be interested?
See also https://github.com/matomo-org/piwik-python-api/issues/19
And a new PR with ongoing improvements has been opened at https://github.com/matomo-org/piwik-python-api/pull/24
Thanks,


Update the document

Document section about receiving notifications in application is obsolete. Notifications from FCM are received now by extending FirebaseMessagingService. See this link for more info.

untargeted

@gtgray thanks for reaching out. If you still have issues just let us know.


Error when npm i -g azure-functions-core-tools@3 --unsafe-perm true

Does this occur consistently?
Repro steps:

npm i -g azure-functions-core-tools@3

Action: azureFunctions.installOrUpdateFuncCoreTools
Error type: Error
Error Message: Failed to run "npm" command. Check output window for more details.
Version: 0.22.1
OS: win32
OS Release: 10.0.18362
Product: Visual Studio Code
Product Version: 1.45.1
Language: en

Call Stack
Object.<anonymous> extension.bundle.js:1:133816
fulfilled extension.bundle.js:1:132699
processTicksAndRejections task_queues.js:85:5

npm ERR! EEXIST: file already exists,

@khlynet check the output window - that should help you fix the error. If not, copy the full logs here


kctrl dev command doesn't work on GKE cluster

kctrl dev command doesn't work on GKE cluster

@rohitagg2020 this is resolved in the previous release right?

Fixed: https://github.com/vmware-tanzu/carvel-kapp-controller/pull/885


Update linear-gauge.ts

Move gauge initialisation into ngAfterViewInit due to Angular 9 changes

Sorry needs further testing


Some review changes

Hey! Wanted to say thanks again for showing interest in the project.
I went ahead and did a cursory review of the feature gate PR and ran into a few issues that I think should be resolved. The biggest issue is that tests don't work depending on what feature flags are available. I went ahead and gated a lot of those, but there are still some cases where warnings are thrown that could probably be cleaned up more.
I also tried to change some heif/avif specific imports but ended up running into trouble with them. I think I'm going to pull those out.
Besides these things, I think it might be worthwhile to at least make sure the tests work fine regardless of what features are enabled. It's sort of tedious to go through testing one feature at a time but it is important for people who may disable one feature and run into a compilation issue.

Right, I ran tests to be sure, but forgot testing feature flags :smile:
I think you can make changes to my PR on your repo directly, but like this is fine too.


TypeError: Cannot read property 'switchToFrame' of undefined

Getting the same error

If I am not wrong this error is happening because https://github.com/segmentio/nightmare is now using electron instead of Phantomjs and 'switchToFrame' is a Phantomjs method.

I think this is outdated now.


mention vscode, atom is dying

Just a minor README change, atom will be outdated soon.

fine with me


Update Pull Request Template

What this PR does / why we need it:
Updating the Pull Request Template
Release note:

/retest
/lgtm


add implements of gcfg.Adapter using kubernetes configmap

Codecov Report
Base: 76.55% // Head: 76.55% // No change to project coverage :thumbsup:

Coverage data is based on head (fa999aa) compared to base (fa999aa).
 Consider uploading reports for the commit c115aa9 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           feature/v2.2.0    #2145   +/-   ##
===============================================
  Coverage           76.55%   76.55%
===============================================
  Files                 575      575
  Lines               47677    47677
===============================================
  Hits                36497    36497
  Misses               9195     9195
  Partials             1985     1985

Flag
Coverage Δ

go-1.16-amd64
76.55% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


🚀 [Feature] Profil Description from community server copy to login server

🚀 Feature
Copy existing Profil Description from Community Server to Login-Server by updating to next version.

only two people have something in there profile description, so I think we don't need importing that.


Patent terms disclosure incorrectly requires a patent number

Describe the issue
The fields of section V.A. of the "File a disclosure about your IPR related to a specific IETF contribution" filing page are marked as mandatory. And they are policed as such.
But they should only be mandatory if section V.A. applies. That is, as the text says, "For granted patents or published pending patent applications".
In some cases, the discloser wishes to grant license for any current or future IPR owned by the disclosing company. Here, they would not fill in section V, and would go straight to section VI
At the moment, this is preventing a specific company from entering the license terms below.
/If technology in this document is included in a standard
adopted by IETF and any claims of any FooCorp patents are
necessary for practicing the standard, any party will have
the right to use any such patent claims under reasonable,
non-discriminatory terms, with reciprocity, to implement and
fully comply with the standard./
/The reasonable non-discriminatory terms are:/
/If this standard is adopted, FooCorp will not assert any
patents owned or controlled by FooCorp against any party for
making, using, selling, importing or offering for sale a
product that implements the standard, provided, however that
FooCorp retains the right to assert its patents (including the
right to claim past royalties) against any party that
asserts a patent it owns or controls (either directly or
indirectly) against FooCorp or any of FooCorp's affiliates or
successors in title or against any products of FooCorp or any
products of any of FooCorp's affiliates either alone or in
combination with other products; and FooCorp retains the right
to assert its patents against any product or portion thereof
that is not necessary for compliance with the standard./
/Royalty-bearing licenses will be available to anyone who
prefers that option./
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

I think @AdrianFarrel is correct here. What should probably happen is that if one ticks the "Has patent pending" under V.B, the fields under V.A should stop being required.
(It may also make make sense to swap V.A and V.B, but that needs more discussion.)

Very belatedly weighing in here, a couple of thoughts:

Even unpublished provisional patent applications have application numbers, and the form does seem to contemplate "application numbers" in the "patent number" field. So, if there is a known patent application, my understanding is that there would be a number that could be provided. (The subsequent checkbox that informs about it being unpublished would be an indication that the application number won't be useful for looking anything up.) So maybe nothing is broken?
Adrian also may be raising a different issue though: what if a party wants to make a blanket royalty free disclosure, as described in RFC 8179 Section 5.4.3 -- i.e., without necessarily identifying particular patent details? I'd guess that the RFC drafters assumed that that this would be made via the General IPR Disclosure Form (https://datatracker.ietf.org/ipr/new-general/). But I see that this form doesn't provide a hook to specific draft documents, and looking through recent general disclosures, I don't see good examples of this being done. Still, I'd say that there is a mechanism to do the blanket RF disclosure via the general form.

So, maybe no bugs?

Weeeeeeeeeell, I dunno.
My cache has been thoroughly flushed, so I'm going back to try to recreate this.

It seems to me that V.A. has an explicit title. "For granted patents or published pending patent applications, please provide the following information:" So, either this title is wrong, or the information is not required in case of V.B. This is something of a minor issue, but will at least confuse the person trying to be helpful with a disclosure.

The main desire was to file a "blanket" disclosure against a specific piece of IETF work. Looking at https://datatracker.ietf.org/ipr/about/ there is only the option to go to https://datatracker.ietf.org/ipr/new-specific/ to "File a disclosure about your IPR related to a specific IETF contribution" (which is what I reported against) or to https://datatracker.ietf.org/ipr/new-general/ to "File an IPR disclosure that is not related to a specific IETF contribution". This second page is a blanket disclosure, but it is orthogonal. That is, it says "I have IPR and I'm disclosing it and the license terms, and that license is applicable to any and all IETF work." That's not what FooCorp was looking for - they wanted to be specific about the IETF work (RFCxxxx and draft-foocorp-fiddle) and grant license on any and all IPR they own (without having to list the numbers). Now, admittedly, they could carefully trawl their IPR database and list all IPR they own (relevant or not), but that seems painful and unnecessary.

Ciao,
Adrian

The general disclosure can identify specific ietf work in its free text - I think that's how it was envisioned to be used.
But I think what Adrian is hoping for is that the kind of statement he's describing becomes linked to specific documents in the datatracker (showing on their IPR search links).
To point out edges (this is not a concrete proposal for the way forward - just a strawman): allowing a checkbox that says "All IPR held by our organization" as an alternative to filling in the application numbers. Would such a thing ever get pushed?

First, on the point about whether the patent number field should be mandatory, I do think the fix could be as simple as striking the word "published" from the instruction line and expecting that disclosers will provide either a patent number or an application number, even for unpublished applications, with the V.B checkbox serving only as an indication that trying to look up the application won't get you much.
The knottier question is how to handle blanket RF disclosures. My general view is that we have a potentially fragile stasis around IPR (with some complex and controversial issues lurking around the edges of our model), and I worry about unintended consequences anytime we open up IPR issues, even seemingly-simple ones. I'd say: there is a mechanism to do blanket RF disclosures, as permitted by 8179, via the general disclosure form. Absent some compelling problem that necessitates change, I'm inclined to stick with the status quo.


Backport HHH-14315 + HHH-14323 + HHH-14370 + HHH-14371 + HHH-14372 to branch 5.4 - Upgrade to Gradle 6.7 and use toolchains for per-JDK builds

HHH-14372: Upgrade to Weld 3.1.5.Final in tests
HHH-14371: Add --add-opens options required for tests
HHH-14370: Add --add-opens options required for Gradle
HHH-14323: Backport HHH-13682 to 5.4: Generate Java 13/14 bytecode for tests when building with JDK13/14
HHH-14315: Upgrade to Gradle 6.7 and use toolchains for per-JDK builds

@yrodiere, who would be the appropriate reviewer? I'm not familiar with why these changes were made in master, so I don't feel comfortable reviewing myself.

@yrodiere, who would be the appropriate reviewer? I'm not familiar with why these changes were made in master, so I don't feel comfortable reviewing myself.

Hi @gbadner, and happy new year! No problem, Sanne was involved in this from the start, I'll ask him for a review. I just noticed something doesn't work on JDK15 though, so I'll try and fix that first.

Hi @gbadner, and happy new year! No problem, Sanne was involved in this from the start, I'll ask him for a review. I just noticed something doesn't work on JDK15 though, so I'll try and fix that first.

@Sanne I think we can merge this into 5.4:

Interested third parties confirmed that they can handle Gradle 6.7.
I checked that the build passes on JDK15 and JDK16
I created Jenkins jobs for JDK15 and JDK16

@Sanne I think we can merge this into 5.4:

Interested third parties confirmed that they can handle Gradle 6.7.
I checked that the build passes on JDK15 and JDK16
I created Jenkins jobs for JDK15 and JDK16

very nice! thanks
I'll run one last check locally..

very nice! thanks
I'll run one last check locally..


doc: Convert natural deduction to MathML

Motivation for this change
I suppose this will read much nicer to people accustomed to graphical structure of proofs and such.
Do we want something like this? We would either need to convert it to some other format since Chrome apparently does not like MathML.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is really awesome! Chrome dropped support for MathML quite intentionally, which really is a bummer.

I like this, can it be updated to work with the markdown rewrites?

Still important to me. The ascii natural deduction is awkward IMO.

Yeah I like this a lot too.


Can sifter and microplugin be placed on CDN?

Sorry if I misunderstood the documentation, but isn't sifter and microplugin needed when using selectize with requirejs?  I looked for then on cndjs and they are not there.  Otherwise I can bundle them locally.  Thanks.

Going to close this issue as I was operating under false info.  Standalone has what I need.


Add integration tests to KVStore

Description
This adds integration tests to the KVStore
Related Issue
Fixes # 155: https://github.com/liftedinit/many-framework/issues/155
Screenshots (if applicable)
Before:

After:

Checklist:

[x] I have read and followed the CONTRIBUTING guidelines for this project.
[x] I have added or updated tests and they pass.
[x] I have added or updated documentation and it is accurate.
[x] I have noted any breaking changes in this module or downstream modules.

Thanks for this! Some comments

You need to make sure your code is correctly formatted using
cargo fmt --all -- --check
You need to make sure all Lints are respected using
cargo clippy --all-targets --all-features -- -D clippy::all -D clippy::print_stderr

else the CI will fail.
Every time you call Setup::new(), a new empty database is created. Because of this, your tests don't do what you think they do. You need to check the content of the return value and make sure it makes sense.

Thanks for the support. I realise they were not useful tests rather than just code covering without validation. I believe they are better now.


Suggested change of wording in menu item(s)

I'm learning the capabilities of your plugin and think it absolutely excellent. Thanks for your work!
I've got a suggestion for a change in a menu item.
For example, on the Daily Notes configuration page, the dropdown menu beside "Open Note" includes the option "Adjusten to the active note". Instead of "Adjusten" the word should be "Adjacent".
I hope this helps!

thx for correction, will change it in next release


I started a wiki. Any objections

Does anyone have any objections to me starting a wiki on this project?  I wanted to add a section for projects that are using OpenCFP to add a link and didn't have a good place to do that.  It seems like the only place to do that is in the README but it really looks like the README is getting too huge.
ps. I don't have a lot of experience with Github wikis. Do people have to send pull requests, etc, or can we make the access more broad for the wiki?

In settings there is an option so either collaborators or everyone can edit. There are no pull requests but there is version control of sorts (more like revisions).

ok. i would support letting everyone edit the wiki. unfortunately i don't think I have access to the settings for this project.

Yeah you can clone the wiki for a project from:
git@github.com:opencfp/opencfp.wiki.git.
No pull requests so unless you do anything else (which I'll describe
below), it comes down to shipping patches or "manual" pull requests via
email request, IRC or something.
For the projects at work where we want to open our wiki up to collaborators
within our Enterprise deployment of GitHub, we create an orphan branch on
the project repository called gh-wiki or something more clever. That
becomes the effective wiki commit history and folks can send PRs to that
branch. We then have automation sync gh-wiki to the actual internal wiki
repository. I bet you could do something similar, but abuse TravisCI to do
the work of syncing merged PRs to gh-wiki to it's actual repository on
GitHub :).
All that said, don't want to get in the weeds too much and distract the
conversation. I find with a lot of wikis that the information becomes stale
and unused if it's not in the direct pathway of development. That said, if
there WERE such a wiki, I would want to move a majority of what's in the
README into that and just leave like, "Hey, this is OpenCFP. It's a thing.
Here's how to install it and here's a lot more good information [link]." At
least this way, we could have more room above the cut for Grumpy propaganda
imagery.
On Mon, Nov 23, 2015 at 2:52 PM, Peter Meth<EMAIL_ADDRESS>wrote:

ok. i would support letting everyone edit the wiki. unfortunately i don't
think I have access to the settings for this project.
—
Reply to this email directly or view it on GitHub
https://github.com/opencfp/opencfp/issues/267#issuecomment-159044569.

--
Dustin Wheeler
Web Application Developer
College of Engineering, ITECS
North Carolina State University
Raleigh, NC 27695, x5-9786
<EMAIL_ADDRESS>Find my office with Google Maps:
http://go.ncsu.edu/find-dustin

gh-docs might be an appropriate branch name in this case as we'd be declaring the wiki as the official source of truth for all documentation (I would imagine) and start moving things there.

Hey @pmeth @chartjes, if you're interested, I've found an interesting way to be able to accept PR to a wiki using GitHub and Travis CI. You can see an example PR at the example repository https://github.com/mdwheele/wikidocs-example/pull/3. I can elaborate on this more if it's something we think we'd be able to take advantage of. Otherwise, was just an idea I ported from our work environment / GitHub Enterprise.
Workflow is pretty much the same. Send pull requests from topic branches on forks to gh-wiki. Travis is configured to deploy push events to a specific branch (gh-wiki). The deployment process involves giving Travis a deploy key to be able to push to the .wiki.git repository for a given project. Deploy script authenticates to GitHub via SSH and force pushes changes from origin/gh-wiki to gh-wiki/master.
The idea is that once you put something like this in place, you don't touch the actual GitHub wiki anymore just as you wouldn't touch any deploy target in another system.

I have no objections
On Tue, Nov 24, 2015, at 09:20 PM, Dustin Wheeler wrote:

Hey @pmeth[1] @chartjes[2], if you're interested, I've found an
interesting way to be able to accept PR to a wiki using GitHub and
Travis CI. You can see an example PR at the example repository mdwheele/wikidocs-
example#3[3]. I can elaborate on this more if it's something we think
we'd be able to take advantage of. Otherwise, was just an idea I
ported from our work environment / GitHub Enterprise.

Workflow is pretty much the same. Send pull requests from topic
branches on forks to gh-wiki. Travis is configured to deploy push
events to a specific branch (gh-wiki). The deployment process involves
giving Travis a deploy key to be able to push to the .wiki.git
repository for a given project. Deploy script authenticates to GitHub
via SSH and force pushes changes from origin/gh-wiki to gh-
wiki/master.

The idea is that once you put something like this in place, you don't
touch the actual GitHub wiki anymore just as you wouldn't touch any
deploy target in another system.

— Reply to this email directly or view it on GitHub[4].

Links:

https://github.com/pmeth
https://github.com/chartjes
https://github.com/mdwheele/wikidocs-example/pull/3
https://github.com/opencfp/opencfp/issues/267#issuecomment-159466792

Closed, wiki exists. Let's make sure we start using it.


Pip install not working

My system info:
Python 3.4.0 (v3.4.0:04f714765c13, Mar 16 2014, 19:25:23) [MSC v.1600 64 bit (AM D64)] on win32

Got this error after command "pip install mitmproxy":
Downloading/unpacking mitmproxy
  Running setup.py (path:C:\Users\[EXCLUDED]\AppData\Local\Temp\pip_build_[EXCLUDED]\mit
mproxy\setup.py) egg_info for package mitmproxy
    Traceback (most recent call last):
      File "<string>", line 17, in <module>
      File "C:\Users\isaiah\AppData\Local\Temp\pip_build_isaiah\mitmproxy\setup.
py", line 74, in <module>
        long_description = file(os.path.join(pdir(), "README.txt")).read()
    NameError: name 'file' is not defined
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "<string>", line 17, in <module>

  File "C:\Users\[EXCLUDED]\AppData\Local\Temp\pip_build_[EXCLUDED]\mitmproxy\setup.py",
 line 74, in <module>

    long_description = file(os.path.join(pdir(), "README.txt")).read()

NameError: name 'file' is not defined

----------------------------------------
Cleaning up...
Command python setup.py egg_info failed with error code 1 in C:\Users\[EXCLUDED]\App
Data\Local\Temp\pip_build_[EXCLUDED]\mitmproxy
Storing debug log for failure in C:\Users\[EXCLUDED]\pip\pip.log

Hi Max (mhils)
I was just reading your comment about mitmproxy only being supported up to Python 2.7. I was wondering whether this was still the case, or if it had been updated to support the latest Python release?


fix(uninstall): prompt for confirmation

Addresses #177

This is ready for review again.

@sgoings fixed


Question about comments retreived from reddit.getSubmission

I use reddit.getSubmission to retrieve comments for a given submission. On the retrieved comment nodes, if I try to node.getComment().getVote() I see the below issue

07-31 19:53:22.828 13684-14031/com.dreamcast.redditr E/JOBS: error while executing job com.dreamcast.redditr.ipc.GetComments@8953d98
java.lang.NullPointerException: Attempt to invoke virtual method 'boolean com.fasterxml.jackson.databind.JsonNode.isNull()' on a null object reference
at net.dean.jraw.models.RedditObject._getVote(RedditObject.java:55)
at net.dean.jraw.models.PublicContribution.getVote(PublicContribution.java:70)

Are these comments somehow now populated fully. What I need is a way to find out with comments have been voted on by the logged in user..

Can you post the relevant code snippet?

There you go
public void onRun() throws Throwable {
Log.d(TAG,"onRun" + mSubmission.getSubmission().getId() + mSubmission.getSubmission().getTitle());
//        CommentStream stream = new CommentStream(AuthenticationManager.get().getRedditClient());
CommentNode rootNode = AuthenticationManager.get().getRedditClient().getSubmission(mSubmission.getId()).getComments();
    ArrayList<RComment> comments =prepareTree(rootNode);
    Log.d(TAG,"Preparing from " + rootNode.getTotalSize() + " to " + comments.size());
    App.getInstance().getDataModel().commentsFetched(comments,mSubmission.getSubmission().getId());
}

Can you also provide the code that throws the NPE?

Oops.. there you go
// node.getComment().getVote()) generates the exception

private ArrayList<RComment> prepareTree(CommentNode node) {
        ArrayList<RComment> commentArrayList = new ArrayList<RComment>();
        commentArrayList.clear();
        if(node != null)
        {
            RComment cur_comment = new RComment();
            cur_comment.setDepth(node.getDepth());
            cur_comment.setBody(node.getComment().getBody());
            cur_comment.setNode(node);
            cur_comment.setVoteDirection(node.getComment().getVote());
            if(cur_comment.getDepth() !=0)
            {
                commentArrayList.add(cur_comment);
            }

            Iterable<CommentNode> iter = node.getChildren();
            if(node.getImmediateSize() > 0)
            {
                for (CommentNode childnode : iter)
                {
                    ArrayList<RComment> childArrayList = prepareTree(childnode);
                    for (RComment child : childArrayList) {
                        if(child.getDepth() == (cur_comment.getDepth() +1))
                            cur_comment.addChild(child);
                    }
                    commentArrayList.addAll(childArrayList);
                }
            }
        }
        return commentArrayList;
    }

Please read the CommentNode class documentation.

Each CommentNode has a depth, a Comment instance, and zero or more CommentNode children. Depth is defined as the level at which the comment exists. For example, a top-level reply has a depth of 1, a reply to that comment has a depth of 2, and so on.

At the root of every comment tree there is a single root node, which represents the submission the comments belong to. This node will have a depth of 0 and its children will be top-level replies to the submission.

When you call prepareTree for the first time, node is the root node. The root node's Comment has no body or vote, or anything else you'd expect a normal Comment to have. That's why on the first iteration of prepareTree a NPE is thrown when you call node.getComment().getVote().
You can check if a CommentNode is a root node with node.getDepth() == 0
See also the class definition for RootComment

That did it. Tested, works.. Thanks a ton. Closing


PostHog ApiKey is hardcoded

I have checked the following:

[X] I use the newest version of bruno.
[X] I've searched existing issues and found nothing related to my issue.

Describe the bug
Looking in the code I found that you store PostHog ApiKey in code in the files:
packages/bruno-app/src/providers/App/useTelemetry.js
packages/bruno-app/src/components/Sidebar/GoldenEdition/index.js
Not sure if such key is still valid but surely it shouldn't be there in clear text
.bru file to reproduce the bug
No response
Screenshots/Live demo link

Hey @zioalex, thank you for being security conscious and creating this issue. However, the posthogApiKey is a public key, which means keeping the key open in the codebase is fine.

Hi Sanjai, what do you mean that it is a public key?.
Can you please explain it?
It is used to send the Telemetrics to Posthog
On Wed, 4 Sept 2024, 10:22 Sanjai Kumar, @.***> wrote:

Hey @zioalex https://github.com/zioalex, thank you for being security
conscious and creating this issue. However, the posthogApiKey is a public
key, which means keeping the key open in the codebase is fine.
—
Reply to this email directly, view it on GitHub
https://github.com/usebruno/bruno/issues/3023#issuecomment-2328222988,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA3NM4CQZOUH3GOQH76FGD3ZU27MDAVCNFSM6AAAAABNTWOVR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRYGIZDEOJYHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

even if it's a public api key , should be injected from secret in your build process ? Anyone could send you fake metrics with this right ?
Why was the response deleted ?

Fixed in https://github.com/usebruno/bruno/pull/3490


[question / FR]

Are there any plans to have built in internalization so multi language sites can be build on apostrophe? This for me is kind of last missing puzzle piece for this CMS.

Yes, see:
https://github.com/punkave/apostrophe-workflow/tree/2.x
For the state of play in this rapidly evolving project. You can already get
hold of it and experiment.
On Fri, Jun 9, 2017 at 8:01 AM, trsh<EMAIL_ADDRESS>wrote:

Are there any plans to have built in internalization so multi language
sites can be build on apostrophe? This for me is kind of last missing
puzzle piece for this CMS.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/punkave/apostrophe/issues/904, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB9fYN-8GuxAtteCEiA0_yK6BW82ynbks5sCTQrgaJpZM4N1Q20
.

--
*THOMAS BOUTELL, *SUPPORT LEAD
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com


unity3d: Switch to unity hub

Motivation for this change
#65229
Let's switch to unity hub so people can manage different versions of unity.
Seems like we don't need the old package anymore.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Unity Hub works on NixOS with appimage-run. It's what I've been using.

Unity Hub works on NixOS with appimage-run. It's what I've been using.

That sounds interesting. Maybe we could make a wrapper package instead of this.

cc @jb55

Can you change the title of the PR to something more meaningful?

Unity Hub on Linux is the recommended way to launch Unity itself, which is compiled for Ubuntu (not an appimage). I have an FHS env for this at https://github.com/leo60228/dotfiles/blob/master/unityenv.nix (ignore the hack in runScript).

appimage-run also caches data in the user's HOME directory. It'd probably make more sense to do it in the build.

cc @jb55
I don't really use this package anymore, sorry. Feel free to remove my
maintainership as an additional commit.

I don't really use this package anymore, sorry. Feel free to remove my maintainership as an additional commit. @jb55

Seems like you already removed yourself in commit 94c3b33

appimage-run also caches data in the user's HOME directory. It'd probably make more sense to do it in the build. @leo60228

I don't quite follow what you mean by this. It would be helpful if you could elaborate a bit more.

There's a folder in ~/.cache/appimage-run/ for every appimage you run, and it's relatively large (~50MB).

https://github.com/NixOS/nixpkgs/issues/59830
I want to compile a WebGL project. There is currently a problem with Emscripten embedded in Unity. Do you happen to know how to fix it?
Thanks. g,.g

(mkDerivation rec{
pname = "unity-hub";
version = "master";
src = fetchurl {
url = "https://public-cdn.cloud.unity3d.com/hub/prod/UnityHub.AppImage";
sha256 = "1ckgva0bywi4wg480qfqgm69nic0v99hsgdk47mfzc26sqzzwkaz";
};
dontUnpack = true;
dontBuild = true;
installPhase = ''
mkdir -p $out/bin
mkdir -p $out/share
cp $src $out/share/UnityHub.AppImage
cat << EOF > "$out/bin/unityhub"
#!${runtimeShell}
${appimage-run}/bin/appimage-run $out/share/UnityHub.AppImage
EOF
chmod +x $out/bin/unityhub $out/share/UnityHub.AppImage
'';
})

can't execute (AppImage) and stop.

lib.makeLibraryPath [
nss nspr expat libxcb libXScrnSaver pciutils libpciaccess #xorg
libglvnd
cairo libdrm wayland  wayland-protocols  openssl libffi
libomxil-bellagio libva-minimal libva flex libelf libvdpau
mesa mesa_glu
vaapiIntel libvdpau-va-gl vaapiVdpau intel-ocl
# add houdini-18
...
I'd like to houdini-18.

is this pr blocked on only webgl?

I recommend unity3d.tar.xz but not hub. because, hub is problem webgl modules.

I couldn't get this to work. First I updated the AppImage link to the newest one on their site, but then when I tried to run it with appimage-run, it doesn't seem to do anything.

I had to use Unity for a class, I haven't touched it in a while.

ubuntu 에서도 같은 문제로 포기하고,
windows 10 으로 넘어왔습니다.

What is the status of this?

I decided to put unityhub in a separate package in case someone still wants to use the other one.
It works great. @PlumpMath Compiling a WebGL project seems to work as well, but i had to copy the  template files to the build folder manually. Other than that, it seems like it's ready to merge @veprbl.

I have a problem with unity-hub.
What is your version of nixos? I'm 19.09-stable.
I have a problem with my nixos, so I am working in the window.
@tesq0
I'll try again later.
thanks.

looks like the binary needs to be renamed from unityhub-2.2.2 to unityhub.

I rolled back my change to the name. It works for me either way (I don't have licenses to test much, though).
Still, the issue with the absence of a stable download is a major one. We might have to remove unityhub from nixpkgs because of that.

surely there's an alternative to removing it. packaging is more help than just "here is a download url", it saves every single person who wants to use unityhub (there will be a lot, its what unity is transitioning to) to figuring out quirks, dependencies, etc

It works well thanks to everybody. happy new ear do,.ob~*


There no license information in project

Hi @livelyPeng ,
Could you please add license file to this project? Same with https://github.com/livelyPeng/pl-table/blob/master/LICENSE
Or is there any reason of this missing?
Thanks & Best regards,
Twister

@twister229 ok,  it has been added！！！！！！

@livelyPeng thank you very much!