App restarts when wallpaper is applied [Android 12+]

app reopen after updating wallpaper android 12

This is due to Material You config changes which happen in stock Android 12. There are already some open issues on Google Bug Tracker. And this is an OS issue and not an issue with this package.
Some links for reference -

https://stackoverflow.com/a/69789526
https://issuetracker.google.com/issues/199995249?pli=1
https://commonsware.com/blog/2021/10/31/android-12-wallpaper-changes-recreate-activities.html

Will be closing this issue.

Yes i guess might be happened due to os. But can we fix that?
On Sun, Aug 7, 2022, 9:08 PM Akshay Maurya @.***> wrote:

Closed #9 https://github.com/codenameakshay/async_wallpaper/issues/9 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/codenameakshay/async_wallpaper/issues/9#event-7142378351,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANCZ6NRMYSQ6OZNANTC437TVX7J7LANCNFSM552QRBQQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yes i guess might be happened due to os. But can we fix that?
On Sun, Aug 7, 2022, 9:08 PM Akshay Maurya @.***> wrote:

Closed #9 https://github.com/codenameakshay/async_wallpaper/issues/9 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/codenameakshay/async_wallpaper/issues/9#event-7142378351,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANCZ6NRMYSQ6OZNANTC437TVX7J7LANCNFSM552QRBQQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

As I mentioned, this issue is still open with Google, and you cannot stop the activity restart as it is a non-traditional config change. Please refer to the links to know more.

You can maintain state in your app by using RestorationManager in Flutter.
Example app code changes - #47


Using on modern browsers while not breaking non-supported browsers

Hi there, I know that Ally.js doesn't support IE9 and below (currently) but could you advise how I could safely use this on a project that supports IE8 without it causing an blocking error?
The following worked in removing errors from IE9 but IE8 still gets this error: expected identifier, string or number
var IE9 = ($('.lt-ie10').length) ? true : false;

if (!IE9) {
    // Ally.js doesn't support IE9 yet
    var ally = require('ally.js');
}

This is obviously pretty crude, if you have a clever workaround it would be much appreciated. The project uses Browserify and Babel.
Many thanks

Ally is going to support IE9 with the next official release. You can try using 1.1.0-beta.4 for now.
As for IE8 I have not yet investigated what we could/should do. I hoped adding html5-shiv would solve most of the problems, but I haven't actually tried running ally.js on IE8.

Depending on the tool you're using to resolve that require('ally.js') the code may end up in the built file anyway - and that's what's tripping IE8, I assume.

I hoped adding html5-shiv would solve most of the problems […]

of course I meant the es5-shim.
I just had a quick look at intern and found that the test framework would not run on IE8.
As for simply loading but not using the library on IE8, I've found a few instances where SVGElement is accessed, which is unknown to IE8 and thus throws errors. After fixing those and loading es5-shim and es5-sham.js, I'm getting an error-free load of the page:
<!--[if lt IE 9]>
  <script src="node_modules/es5-shim/es5-shim.js"></script>
  <script src="node_modules/es5-shim/es5-sham.js"></script>
<![endif]-->
<script src="dist/ally.dist.js"></script>
<script>console.log('loaded');</script>

I have not verified functional integrity, because the test framework won't run on IE8 - which would be the next step for #71

It turns out that IE8 is no longer supported by the test framework. There used to be a separate version supporting older IE, but in light of Microsoft officially ending support for IE8 they ended support as well.
To be honest, I have no intention of fully supporting IE8. If it were as simple as supporting IE9 was, I'd bite the bullet and add support. But it's not. IE8 is way too far behind. I'm not yet sure how I want to proceed with this.

This is obviously pretty crude, if you have a clever workaround it would be much appreciated. The project uses Browserify and Babel.

Did you configure anything so that you'd get ES3 code, or are you loading the es5-shim in that project?

Thanks for such a detailed response!
First off, I wouldn't expect you to support IE8, it's a shame I have to for this project.
I do have the es5-shim (and sham) on this project. It seems that, if I run Ally through Babel (I had to turn compact to false to stop getting a file size error). I can remove the error from IE8. That's great but I could do without having to run a file of that size through Babel, plus, I'm unsure of the implications of turning that compact setting off.
I'm leaning towards maybe just injecting the script if it's not IE8.
    if (window.ally === undefined) {
        $('body').append('<script src="/js/src/plugins/ally.min.js"></script>');
    }

This seems to work ok, do you see an issue with that approach?

I must have had errors in my code as I'm still getting the SVGElement issue in IE8 that you mentioned. So IE9 support is in the beta but the IE8 fix is in master?

So IE9 support is in the beta but the IE8 fix is in master?

correct.

If that's correct, I'm happy to extract and build it myself.

You may want to try ally.js.tar.gz build 404 first. (just note that the file is not going to be available forever)

I just tried the minified file in build 404 and I'm getting an error in IE8
Object doesn't support this property or method
from this line...
return y = c["default"](), document.addEventListener("shadow-focus", o, !0), document.documentElement.addEventListener(v, o, !0), document.documentElement.addEventListener(g, o, !0), h = m["default"](), o({ type: "initial" }), { used: a, current: u, lock: i };

Should I try the manual extraction instead?

Object doesn't support this property or method

are you executing the code in IE8? Because that shouldn't work anyway.
loading ally.min.js (and es5-shim and es5-sham) I get
Message: Expected identifier, string or number
Line: 2
Char: 811
Code: 0
URI: http://test.dev/ally-ie8/node_modules/ally.js/ally.min.js

and that points to {default:e}. And I just realized we're running uglify with --screw-ie8, so yay…

Should I try the manual extraction instead?

sure, give it a go.

It's getting Bablified and ShimShamed (new word!) so that's weird.
I tried doing build from the pre-release and got this...
npm ERR! Failed at the<EMAIL_ADDRESS>build script 'npm-run-all --sequential build:pre --parallel build:umd build:common build:amd --sequential build:post build:archive'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the ally.js package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm-run-all --sequential build:pre --parallel build:umd build:common build:amd --sequential build:post build:archive

npm v3.4.1
node v4.2.1
Any ideas?

I tried doing build from the pre-release and got this...

what do you mean by pre-relase? Are you referring to Releasing ally.js?
npm run clean
npm run build

I'm running node v4.2.2 so that should be fine. But I'm on npm v2.14.7 - maybe that's a problem?

I mean, I was using this 1.1.0-beta.4 pre-release build as my starting point.
Npm version could be an issue, not sure. I'm not super clued-up on npm stuff.

Hi @rodneyrehm, after updating to v.1.1.0 I'm still getting Object doesn't support this method or property in IE8 on this line
var t=document.createElementNS("http://www.w3.org/2000/svg","svg");"classList"in t&&!window.QUnit||Object.defineProperty(SVGElement.prototype,"classList",{get:function(){return"string"==typeof this.className?new e(this,"className"):"string"==typeof this.className.baseVal?new e(this.className,"baseVal"):void 0}})}(),"undefined"!=typeof window&&(window.DOMTokenList=e),e})}

Any ideas?

Looks like domtokenlist-shim is the problem here. I've created jwilsson/domtokenlist#16 to fix that.

Thanks!

I notice that your domtokenlist-shim fix was merged in, do you need to update your fork?

Sorry for the delay. I've pulled that IE8 fix into the fork. I didn't do this right away because I was working on something to replace domtokenlist-shim with, but then life happened. Anyway, the fix is in but now BrowserStack is acting up again. hoping to resolve this over the weekend…

Hey no worries at all! I really appreciate you looking into this.
I tried downloading master and building the files and I'm still getting the error. Not sure if there is something else I needed to do.

 I pulled in the fix to my fork, but did not update the distributables…
I've fixed the thing in build 538.

Grabbed the ally.min.js file from build 538, loads of changes but I'm still getting that error.

This is getting ridiculous. Apparently I didn't update all the distributables of domtokenlist-shim… the build 539 contains all the changes and I've verified loading that file (with es5-shim) in IE8.

Heh no worries! Unfortunately, I'm getting a different error now. Same error message Object doesn't support... but now from this.
return y=d["default"](),document.addEventListener("shadow-focus",r,!0),document.documentElement.addEventListener(v,r,!0),document.documentElement.addEventListener(g,r,!0),h=m["default"](),r({type:"initial"}),{used:a,current:o,lock:i}}Object.defineProperty(n,"__esModule",{value:!0}),e("domtokenlist-shim/dist/domtokenlist-polyfill-umd");

Just to clarify, I'm using the ally.min.js file from the build folder you last sent. I have both these scripts on the page...
<script src="http://cdnjs.cloudflare.com/ajax/libs/es5-shim/4.5.8/es5-shim.min.js"></script>
<script src="http://cdnjs.cloudflare.com/ajax/libs/es5-shim/4.5.8/es5-sham.min.js"></script>

...and I am running the full file through Babel (although I've tried it without Babel and I get the same error).

Can you check if ally-ie8 works for you? As far as I see I tested against es5-shim 4.5.7.

Ok we're getting closer! That works fine, I also tested in my environment using the exact same scripts you are using and it works fine.
If I add part of the script I'm using, the error appears...
var handle = ally.style.focusSource();
handle.current(); // 'key', 'pointer', 'script'

Hope that helps

Ha! ally.js will load in IE8, but it will not execute. The idea is that you don't have to serve different files to IE8 than to all the other browsers. But actually using ally.js in IE8 is not possible and will not be possible. You'll have to add escape hatches to your code so that in IE8 ally is not used.

Aaaaah of course! My mistake, I was thinking (wrongly) that I would be able to use it without escaping for IE8. Added those in and everything is fine.
Thank you so much for nutting this out with me, you've gone above and beyond the call of duty to help me out and I really appreciate it.


Walker always starts at 0,0

Expected Behavior
Walk around the location set in the config.json
Actual Behavior
The walker always starts at 0,0
I can not figure out how to make sure i2f(self.api._position_lng) returns another value then 0. (probably a very simple solution but I am a noob)
Steps to Reproduce
Other Information
OS:
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)

Post your config.json file please

{
"auth_service": "google",
"username": "******",
"password": "",
"location": "52.1400000, 06.1200000",
"gmapkey": "",
"max_steps": 5,
"mode": "all",
"walk": 4.16,
"debug": false,
"test": false,
"initial_transfer": 50,
"location_cache": true,
"distance_unit": "km",
"item_filter": "101,102,103,104",
"evolve_all": "ALL"
}
The walker will walk towards the set location but starts at 0,0 so it will have to walk for days before arriving...

remove the space in the comma, and delete cache location json file.
You should stop using master branch and use dev branch, it's better and more fixed.

Thanks so much, that solved the problem. :)

close ticket


Error when configuring a JDBC User Store as a primary user store

Description
The following error gets logged in the terminal when trying to configure a JDBC User Store as a primary user store
Steps to Reproduce
Follow the instructions in the document Configuring a JDBC User Store
Affected Component
APIM
Version
4.x.x
Environment Details (with versions)
OS - macOS Ventura(Version 13.0)
Java Version - 17
Relevant Log Output
java.lang.reflect.InvocationTargetException
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.wso2.carbon.bootstrap.Bootstrap.loadClass(Bootstrap.java:69)
	at org.wso2.carbon.bootstrap.Bootstrap.main(Bootstrap.java:51)
Caused by: java.lang.StackOverflowError
	at net.consensys.cava.toml.MutableTomlTable.keyPathSet(MutableTomlTable.java:71)
	at net.consensys.cava.toml.MutableTomlTable.lambda$keyPathSet$1(MutableTomlTable.java:80)
	at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:273)
	at java.base/java.util.HashMap$EntrySpliterator.forEachRemaining(HashMap.java:1850)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at net.consensys.cava.toml.MutableTomlTable.keyPathSet(MutableTomlTable.java:92)
	at net.consensys.cava.toml.MutableTomlTable.lambda$keyPathSet$1(MutableTomlTable.java:80)

.........................
.........................

Related Issues
No response
Suggested Labels
No response

@thisaltennakoon can you share the deployment.toml configurations that you added? Seems there is a parsing error in the configurations.

Closing this issue as this has occurred due to misconfiguration done by me in the deployment.toml when doing testing.


Migrate kustomize setup to kustomize v5

Description
The KLM is currently setup with kustomize v4. 5.0.0 was released which introduces a lot of breaking changes. To stick to the latest changes, features and fixes we should think of upgrading to latest kustomize version.
Example breaking changes which at least affect this project:

Dropped patchesStrategicMerge. Please use patches instead
Dropped patchesJson6902. Please use patches instead
Dropped vars. Please use replacements instead.

Unfortunately, the new patches do not work as patchesJson6902 did before. I.e. in kubebuilder v4 the render order of the kustomizations have been the following:

patches
global patches (i.e. namespace: kcp-system)
json patches

The following kustomization:
namespace: GLOBAL-system

patches:
  - patch: |-
      - op: replace
        path: /metadata/namespace
        value: OLD-namespace
    target:
      group: networking.istio.io
      version: v1beta1
      kind: Gateway
      name: watcher-gateway

patchesJson6902:
  - patch: |-
      - op: replace
        path: /metadata/namespace
        value: JSON-namespace
    target:
      group: networking.istio.io
      version: v1beta1
      kind: Gateway
      name: watcher-gateway

Would have the following output:
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: klm-watcher-serving-cert
  namespace: JSON-system
spec:
  <...>

Since JSON patches have been deprecated, the render order is the following:

patches
global patches (i.e. namespace: kcp-system)

Means the kustomization above, would render to the following with v5 using only patches:
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: klm-watcher-serving-cert
  namespace: GLOBAL-system
spec:
  <...>

This means, it is no longer possible to have a namespace set and applying to all resources and overwriting it on single specific resources to a different value. Means we need a patch for each resources to set its namespace specifically, which results in at least one patch for each resource. → Way more patches and kustomization we need to take care of (huge effort atm).
Maybe there will be a solution given by kustomize, since we will not the only one run into this problem.
Here  is the official example form kustomize, maybe they update it with a corresponding example.
ACs:

[ ] Adapt all patches to work with kustomize 5.x.x

[ ] Run local watcher setup (https://github.com/kyma-project/lifecycle-manager/blob/646e049c3ce5b5a5d1fa3f24549662994f9a017d/docs/developer/watcher-local-test.md#L1)

#Update
With Kustomize v5.0.3, although have deprecation warning, the final output yaml is same as what generated by v4
DEV Notes
The controller tools should upgrade to the latest version, and regenerate manifests, so that CRD not contains creationTimestamp: null
CONTROLLER_TOOLS_VERSION ?= v0.13.0

Using this technique we can work around the limitations of internal transformers ordering of kustomize, as mentioned by @jeremyharisch :

patches
global patches (i.e. namespace: kcp-system)
json patches

If we configure namespace transformer to only apply namespace value to the objects that don't have a namespace set, we may:

drop the namespace from all our custom objects or set it to kcp-system.
then we patch some of them to have a different namespace, like istio-system
then the configured namespace transformer, that comes after our patches are applied sets the "global" namespace to, for example, kcp-system

Note: kustomize v5.x does support the deprecated features. These features are defined in the v1beta1 Kustomization API and we're supposed to migrate to the new v1 API, where the deprecated features do not exist.
The first PR that bumps the kustomize version and migrates patches configurations is ready for review.


how to config for postgresql?

how to config for postgresql?

@qqqzhch take a look at the examples repository

@simov  thanks

No problem, let me know if you have other issues, closing.


Download link on embedded view

I'm not sure if this is the correct place for it, but anyway:
It would be great if the next iteration of the viewer had a download link in the embedded view of the document, so any reader could download the file directly. At the moment you need to make it fullscreen and then find the link, so is not easy to find.
Example:

@martgnz I originally failed to list it in #10 (and the mockup doesn't show it), but I'd envisioned putting the download link in the dismissable sidebar panel. Doesn't seem like something people need access to often enough to warrant primary placement. (Arguably, neither does the permalink.) What do you think?

I'm not sure. From my experience working with DocumentCloud on a newsroom a lot of the people who comment want access to the original document, and at least in the actual UI, the link is difficult to find.
In the actual interface the link is hidden beyond a fullscreen icon, so you don't expect to find the source there.
If in this case the sidebar is easily reachable and contains multiple options. I would say yes, put it there.
But I guess that everything that makes even easier to the reader to find the original document has a strong value, not only in the perspective of number of users that will download the document, but regarding the transparency of the newsroom with their readers.
What I think that it's an error is to do same as in the actual UI. To make difficult to find the link to the PDF and to hide it in a complicated menu. Is the download link placed in the actual sidebar preview so we can test it?

Is the download link placed in the actual sidebar preview so we can test it?

Not yet. When I've written the panel, I'll put a note in here.
I plan to make it easily discoverable, but without the "don't bother with the viewer, just download the original" implication of too-primary placement.

Ok, I will test it once is done.
That's nice. If you already know this I guess that it's going to be easier than in the actual viewer ;)


Make react-draggable agnostic of the HTML structure position

This is related to #56
Let's have a look at the ReactBootstrap and Bootstrap Modals side by side. I have updated the repository to include a Bootstrap example also https://github.com/cosminnicula/ReactBootstrapModalDraggable
1.Bootstrap -> this works
<Draggable handle=".modal-header">

				...

</Draggable>

2.ReactBootstrap -> this does not work
<Draggable handle=".modal-header">
	<Modal>
		...
	</Modal>
</Draggable>

Under the hood, <Modal /> generates the same HTML mark-up as 1.
Questions:
a) Since 2. is equivalent to 1. in terms of HTML mark-up, why <Dragglable /> would not work with 2. ? (not asking technical details, but rather as a client of the library)
b) If <Draggable /> wants to cover more use cases, it has to be more flexible in terms where in the HTML structure needs to be included. E.g. if ReactBootstrap, or any other component decides not to expose a renderer function or a custom component, then <Draggable /> cannot be used. A solution would be for <Draggable /> to be agnostic of the HTML structure position and rely only on the handle property. Is this make sense?
Would :heart: to see these two questions addressed!

The difference is that they are not equivalent in terms of how they are actually translated into markup.
As I explained earlier, the  does not directly translate to:

...

See the source - there is a backdrop and more.
This is likely not possible to without defining some sort of className filter and having react-draggable actually traverse its child's tree in order to determine an injection point. If you would like to tackle that, please be my guest.

Have a look at the React Bootstrap Modal code here http://bit.ly/1dgkDmn. You can see at line 68 that rendering the backdrop is optional, so we can leave this behind.
Regarding the "className filter", isn't this what the handle property should do: traverse its child's tree and determine an injection point based on the selector specified? If so, then there must be another reason why this is not working. And that's why I'm addressing this here. I haven't got the time to look at a possible solution, but it would be great if there would be a solve for this.
What I'm trying to point out here is that react-draggable would probably be used more often in composition with another React component like React Bootstrap Modal or others (example 2), than with static content (example 1).

I agree with cosminnicula. Fixing this relatively small issue would have a big impact on the usability of this component. As of right now I find myself making wrapper html elements for my React components if I want them to be draggable, which bloats my jsx and obfuscates the true purpose of my React components.
<Draggable>

    <MyReactComponent />

</Draggable>

The above is my workaround, and is pretty clearly suboptimal.

It's not a small or simple issue and there isn't a simple way to fix it because we don't know what the top level of a child component will export. I welcome any contributions.

Is it possible to use https://facebook.github.io/react/docs/top-level-api.html#react.finddomnode on componentDidMount to point the Draggable component to the top-level dom node? Currently it seems that you want a solution that can access the top-level DOM element before it's rendered. Whether that is possible I don't know, but I don't think it's absolutely necessary.
Have you thought about and/or explored options that allow the DOM to be rendered first? If so, why have those avenues been ruled out?

Accessing the top-level DOM node is not the problem. In the case of the bootstrap modal element, the top-level element is a wrapper that contains the modal itself and the backdrop. <Draggable> has no way to know this. Remember that in React, we must define our children declaratively, and we can only do so via props. If the component we're wrapping does not expose the requisite functionality via props, the best we can do is wrap it in a
 and apply styles to that.
Selecting the draggable target with a CSS selector is not going to be easy without direct DOM munging, which is not how React is meant to be used and goes against the spirit of this component. At that point, it's no better than simply using something like jQuery-UI or any of the dozens of other draggable wrappers around the internet.

Maybe I'm confused because there are actually two issues at play here:

What you are saying, if I'm not mistaken, is that the actual Draggable item might be inside another React component at an arbitrary depth, and the Draggable library has no way of knowing this without traversing the DOM with a css selector. This makes sense, and I understand why you might be opposed to supporting this.
The issue I thought this thread was about was the fact that the Draggable component does not work at all if a React Component is the direct child of it. For instance,

<Draggable>
  <MyReactComponent />
</Draggable>

will not work for me--the component does not fire events and has no semblance of being draggable. But
<Draggable>

    <MyReactComponent />

</Draggable>

does work, because Draggable is able to attach itself to the div wrapper. At the least, I would expect the first code snippet to make the top-level DOM element draggable, but that does not happen.
Sorry if I'm being dense, and you are in fact addressing both issues, but I'm not sure if you are at the moment.

It is exactly that - both issues are the same, in that <Draggable> has little to no knowledge of its child. What is directly below the <Draggable> needs to be an element that we can manipulate the style of. If your component doesn't accept a style prop (and <Draggable> has no way of knowing if it does), then the style will be lost and your element won't be draggable. Rather than always insert a  (which may not be correct, especially if your component accepts a style prop, we rely on the user to know what is best.

Hmmm, I see now why implementing it the way it is now is the most flexible approach. I still am not quite satisfied with the current implementation, however, as I find it confusing that the Draggable component does not work around a non-DOM React component. Could it be detected whether the child element is a React DOM element, and then a wrapper element used in the case it isn't? If the user wishes to create their own wrapper, they could still do so, and the component would work no matter its children.
Do you think that this is a problem worthy of solving?
P.S. Whether this issue actually results in a fix or not, though, this behavior should be documented in the README so that future users of the library don't go through this headache.

There is no way I know of to detect if the child will actually respect
the style prop or not.
If you think the README needs updating, please write documentation that
you think would help you and submit it as a PR.
On 7/28/15 5:31 PM, jmuerle wrote:

Hmmm, I see now why implementing it the way it is now is the most
flexible approach. I still am not quite satisfied with the current
implementation, however, as I find it confusing that the Draggable
component does not work around a non-DOM React component. Could it be
detected whether the child element is a React DOM element, and then a
wrapper element used in the case it isn't? If the user wishes to
create their own wrapper, they could still do so, and the component
would work no matter its children.
Do you think that this is a problem worthy of solving?
P.S. Whether this issue actually results in a fix or not, though, this
behavior should be documented in the README so that future users of
the library don't go through this headache.
—
Reply to this email directly or view it on GitHub
https://github.com/mzabriskie/react-draggable/issues/57#issuecomment-125771353.


[resolves #1274] Add WildFly-Camel CDI quickstart

ok to test

ok to test

add to whitelist

[merge]


fix(dts): Wrong type for svg handling in .d.ts. close #15262

Brief Information
This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

What does this PR do?

Wrong type for svg handling
Fixed issues

Details
Before: What was the problem?
export type GeoSVGSourceInput = 'string' | Document | SVGElement;
After: How is it fixed in this PR?

export type GeoSVGSourceInput = string | Document | SVGElement;
Misc

[ ] The API has been changed (apache/echarts-doc#xxx).
[ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs
NA.
Others
Merging options

[ ] Please squash the commits into a single one when merge.

Other information

after build types result:


build(client,build-tools): Upgrade biome to 1.9.3

Upgrade biome to 1.9.3.
Notable changes:

CSS files are now formatted.
Extra parens are added in statements where the order of operations may be confusing.

How do we get to Biome v2? https://github.com/biomejs/biome-vscode/issues/261 is really starting to bother me again.


Tab is treated as 8 spaces

Bug in source code:
https://github.com/tree-sitter/tree-sitter-python/blob/24b530ca158d2782ea9046e756057a412e16b52f/src/scanner.cc#L242
Minimal example: test-indent.txt
> tree-sitter parse ../test-indent.txt
(module [0, 0] - [3, 0]
  (function_definition [0, 0] - [2, 39]
    name: (identifier [0, 4] - [0, 9])
    parameters: (parameters [0, 9] - [0, 11])
    body: (block [1, 8] - [2, 39]
      (expression_statement [1, 8] - [1, 49]
        (call [1, 8] - [1, 49]
          function: (identifier [1, 8] - [1, 13])
          arguments: (argument_list [1, 13] - [1, 49]
            (string [1, 14] - [1, 48]))))
      (expression_statement [2, 1] - [2, 39]
        (call [2, 1] - [2, 39]
          function: (identifier [2, 1] - [2, 6])
          arguments: (argument_list [2, 6] - [2, 39]
            (string [2, 7] - [2, 38])))))))

Python 3 disallow mixed use of spaces and tabs for indentation, so I think the above file should not give a valid result.

sure but it's useful for good error recovery

softtabstop for Python is usually 2 or 4.
Afterall, this is a trivial bug

Well tab being 8 spaces is sorta the universal default


Introduce support for OS-specific standard cache directories

This cleans up the home directories of users and helps making sure that
Coursier's cache is not accidentically backed up by applications or OS
functionality.
The precedence is as follows:

existing $COURSIER_CACHE environment variable
existing coursier.cache Java property
existing ~/.coursier/
existing operating system specific standards:

Linux:   $XDG_CACHE_HOME/coursier, with fallback to ~/.cache/coursier
Windows: {SpecialFolder.LocalApplicationData}/cache/Coursier
macOS:   $HOME/Library/Caches/Coursier

@soc Shouldn't dataDir used here, instead of cacheDir? XDG base directory spec says that the cache dir is for "non-essential data files", where dataDir is for "user specific data files". I feel like the latter would be a better match (the "cache" of coursier consists of data files, but I wouldn't say they're "non-essential").

About the precedence, I think the last two points should be permuted, like

if OS specific dir for coursier exists, use it,
else if ~/.coursier exists, use it,
else, if none exists, fallback to OS specific dir.

@alexarchambault

Shouldn't dataDir used here, instead of cacheDir?

No, not in this case. There is no platform-independent way to avoid moving GBs of cached files across the network (only Windows supports the distinction with roaming vs. local application data). Cache is the right folder, because it perfectly fits the distinction of "the only thing users see after deleting the cache is that some things take more time".
On the other hand, packages that are published locally should go into the dataDir, as they are likely not recoverable from the online repositories.
This way, users have the huge benefit of being able to delete their caches without losing their locally published artifacts, and have their locally published artifacts synced across machines without dragging GBs of cached artifacts along with them.

About the precedence

Makes sense, I can change that.

Ok, let's go for cacheDir then. (That's right that it makes no sense to somehow sync / save the cache dir of coursier, so it's better there.)
 It's better to put the cache in a sub dir of the cacheDir returned by directories (to separate it from other things that could be kept in cacheDir), and I can't think of a better name (and v1 is shorter than e.g. downloads).

@soc Merging, thanks for having pushed for that!

@alexarchambault It has been a pleasure!
Did you have any chance yet to verify that the paths chosen by directories work fine on Winows? (Mac, too, but I have less concerns there, because the solution to derive the directories is substantially less complex than Window's "let's tell the JVM to tell the OS to run a new process, run PowerShell in that process and then call functions from .NET").

@soc The Windows CI didn't complain, I'm guessing things work fine there.

@soc Where cache files land on Windows 10 (in a free VM):

@alexarchambault This agrees with http://doc.qt.io/qt-5/qstandardpaths.html, but I would love to know how they came up with this path in the first place. Can't find anything in the Microsoft documentation.


Add "Work on your first Project" section to onboarding task list

The issue template should contain:

[ ] A task for the buddy to identify a first project for the new engineer to work on. The buddy will lead this project, and the new engineer will participate.
[ ] A task for the new engineer to read some linked-to documentation about breaking down larger tasks at the project level
[ ] A task for the new engineer to read some linked-to documentation about cycle development
[ ] A task for the new engineer to re-read our engineering values again (and the task list should explain why they're being asked to read these values yet again: what parts of the values apply to how we do projects)
[ ] A task for the new engineer to read some linked-to documentation about where work comes from
[ ] A task for the new engineer to read some linked-to documentation about initiatives & projects
[ ] A task for the new engineer to read some linked-to documentation about tracking outcomes
[ ] A task for the new engineer to read some linked-to documentation about what to do during downtime/being blocked
[ ] A task for the new engineer to check off once their first project cycle has ended

Does your solution solve the right problem? from the Intercom blog is an excellent post that I think we might want to get engineers to read at this stage

Relevant Google doc: https://docs.google.com/spreadsheets/d/1SaiBNBUjcz0RCC0oMp_ozXUeZUolpEaRucxOGmwGXm4/edit#gid=0


Artifactory environment parameters changed to variables

Artifactory environment parameters changed to variables, this will make easier to build the libraries setting the values to local or remote Artifactory repositories.

Thanks for starting this work @IOhacker . Please will you like to create a ticket on Fineract CN JIRA to track this feature?
https://issues.apache.org/jira/browse/FINCN

I have created this PR https://issues.apache.org/jira/browse/FINCN-349
Regards
Victor Romero


Unsupported event type for jvm method check_class_file_load_hook

async profiler version
$ ./bin/asprof -v
Async-profiler 3.0 built on Jan 20 2024

trace check_class_file_load_hook
$ ./bin/asprof -e check_class_file_load_hook -d 60 8657
[ERROR] Unsupported event type

gdb says it has this func:
(gdb) i functions check_class_file_load_hook
All functions matching regular expression "check_class_file_load_hook":

File /openjdk/src/hotspot/share/classfile/klassFactory.cpp:
static ClassFileStream *check_class_file_load_hook(ClassFileStream*, Symbol*, ClassLoaderData*, Handle, JvmtiCachedClassFileData**, JavaThread*);

nm output
$ nm /openjdk/build/linux-x86_64-server-slowdebug/jdk/lib/server/libjvm.so | grep check_class_file_load_hook
0000000000d94166 t _ZL26check_class_file_load_hookP15ClassFileStreamP6SymbolP15ClassLoaderData6HandlePP24JvmtiCachedClassFileDataP10JavaThread

jvm source code:

static ClassFileStream* check_class_file_load_hook(ClassFileStream* stream,
                                                   Symbol* name,
                                                   ClassLoaderData* loader_data,
                                                   Handle protection_domain,
                                                   JvmtiCachedClassFileData** cached_class_file,
                                                   TRAPS) {

As you've found with nm, the full (unmangled) symbol name is
_ZL26check_class_file_load_hookP15ClassFileStreamP6SymbolP15ClassLoaderData6HandlePP24JvmtiCachedClassFileDataP10JavaThread

If you use this one with -e, it should work.
You don't need to specify the full name though: a prefix with a star should do the trick:
-e '_ZL26check_class_file_load_hook*'

Async-profiler does not mangle C++ function names automatically, except for simple cases like G1CollectedHeap::humongous_obj_allocate

It works! Appreciate.


PY: ivp

We don't have a Julia version of the ivp module

Moving this to v0.3 milestone

going to be working on this over the next couple weeks unless someone else has already done this and hasn't marked this issue as closed

@rawls238 that would be great.
No one is currently assigned and the work has not been done yet.

@spencerlyon2 awesome! I'll start working on this then

Started doing this but got distracted by other stuff...hopefully will have this done sometime in the next couple weeks

No problem.
Thanks for the update.


Getting started resources?

Hi!
loving how the project is looking! It’s looking real promising!
Wanted to ask if you’re planning to create some resources on how to use it?
Thanks!

Hi there!
Thank you for your interests!
Since this is a hobby-project and I've a day to day Job and family, unfortunately I don't have much time to work on this. Currently my focus is on shifting this API to Kotlin multiplatform project to also support other systems in the future. I already did that with implementations for the JVM.  You can find it here: https://github.com/AndreasHefti/flyko-lib
I plan to port also the README and documentation from this project to the new project as soon as possible and go on with the documentation as I find time to do so.
There are some examples within the test environment, either as unit-tests (https://github.com/AndreasHefti/flyKo/tree/master/src/test/com/inari/firefly) or integration-tests: (https://github.com/AndreasHefti/flyKo/tree/master/src/test/examples). There you can find some explaining code snippets.
Last year a published a self made game (Boulder Dash clone) that is built on top of this framework. You can find it here, if you are interested in. The game code is not public yet but if it helps I can make it public.
Cheers
Andrevv


how can I run ./scripts/vis.sh

please tell example of arguments.
i can't understand '--det' & '--output'

I just ran via full command line.  I couldn't run  shell script.

same question !!
scripts/vis.sh asks me for arguments : det and image

@kspook were you able to find out how to run it ??

@kspook were you able to find out how to run it ??

I mistyped. There was no problem.
Now I can't remember what I typed wrong

I was ablt to run it this way :
scripts/vis.sh ~/dataset/ICDAR2015/Challenge4/test1  ~/conv3_3/test/icdar2015_test/model.ckpt-38055/txt
--det is the path for dataset and --output is path for the output


'No web user found for domain' error when trying to follow at 'fed.brid.gy/bsky/{custom_domain}'

I'm trying to follow my bsky-to-fedi bridgy account that uses a custom domain with a mastodon account.
It uses a custom domain but it is not run there.

When I click the follow button, an error shows up complaining it hasn't found a web user.
But it shouldn't be, right? Why is it going through the domain? I'm not sure what I am doing wrong.

As a workaround, you should be able to search for<EMAIL_ADDRESS>while logged into Mastodon to find the account.

As a workaround, you should be able to search for<EMAIL_ADDRESS>while logged into Mastodon to find the account.

Thanks, this works to let me discover and follow the account. But now, the request to follow is just stuck on pending.

That could be #1135. The spam filter is currently too strict regarding just following an account.
If that is the issue, I think you can retry once once the Mastodon account fulfils the requirements.

Sorry for the trouble @mistrk7! The web UI is brittle and parts of it like this still don't support Bluesky yet. I'll see if this is a quick fix.

Well possibly but like @Tamschi has said, I've made the mastodon account fit the requirements, but i'm still getting the pending error so it's still not allowing it. I suppose the account age another factor as well (made yesterday).
Otherwise could someone follow it so that posts show up on mastodon, if i'm correct in how that works? Thanks for your help.

Right, age is another factor: https://fed.brid.gy/docs#troubleshooting

^ Fixed the web remote follow UI, should be deployed in 10-15m. Thanks again for reporting @mistrk7!


Fix DML with constraints on abstract types

Some constraints are inforced by adding a CTE that does the check.
When an a constraint was defined on an abstract type, we were trying
and failing to generate this check for the abstract type as well.
This PR removes this check for all abstract object types.
Closes #6419

I tracked down the source of the failure I mentioned. One key thing was that it did work when it was a multi prop. I looked at the code generated for multi props, and the obvious difference was that the else~ CTEs for multi props were applying any overlay, while the single ones weren't. This is bad, because the data we are checking for conflicts is the newly added data; we need to use an overlay!
Then I did a quick search to see where process_update_conflicts was called from, and the relevant buggy code turned out to be immediately above it: https://github.com/edgedb/edgedb/blob/master/edb/pgsql/compiler/dml.py#L424-L446
When we add an overlay to our map of overlays, we register it as being an overlay for all of its ancestor types, too. (Since it adds things to or modifies those ancestor types).
When we do updates, though, we skip adding overlays for all the descendants to the overlay map for the base type of the update; this is because updates generate a union_cte that unions all of the different subtype updates together, and so we use that as the overlay for the update base type, instead of having a separate overlay for each subtype.
But because https://github.com/edgedb/edgedb/pull/6135 skipped generating an update for the abstract base, it isn't in dml_ctes, so that union_cte nevers get added as an overlay!
Does that make sense?

I does somewhat make sense. It's a lot and I can try to explain it back to you on Tuesday, as a practice :D
So:

We don't have to check the constraints for abstract types - even for catching exclusive constraints between different subtypes. My fix is correct.
My fix and your investigation uncovered similar bug for single properties, which I'll fix now.


Custom Theme sometimes doesn't load on a fresh start of VSC

VSCode Version: 1.22
OS Version: Windows 10 / Mac
This happens randomly when I open the editor. I'm using the Material Theme here https://github.com/equinusocio/vsc-material-theme which sometimes doesn't load when I open the editor. And when this happens I have to perform a lot of steps to get it back.
Is there a way I can debug what's causing this?
Steps to Reproduce:

Open VS Code
The current theme is not Material theme anymore, but instead the default VS Code theme
When I switch to any other theme nothing happens for a few seconds after which I see this
https://i.imgur.com/R3LugOh.png , only then after reloading, I can see the new theme applied.
I then have to repeat the last step again to get back Material Theme

Does this issue occur when all extensions are disabled?: Cannot reproduce without extensions.

Cross post https://github.com/equinusocio/vsc-material-theme/issues/158

@atif089 can you check when this happens if maybe other UI state is lost. We store the colors in a local storage and maybe that one is broken and does not persist from time to time.

@atif089 Make sure when you activate a theme the settings file is closed in all vsc windows.
Anyway, i will release a major update next days that should fix any issue of this kind, activating all the theme variants through vsc and no more through a custom menu.

Closing as the material theme pushed a fix (see https://github.com/equinusocio/vsc-material-theme/issues/158#issuecomment-383674153)


Remove unused Key and IsResourceNotFound from LocalizedHtmlString

In addition, this type should not be exposed in IHtmlLocalizer. The Html() methods there should return IHtmlContent.

See also similar aspnet/Localization#158 issue.


Categories crash when the network is low or unexistant

Hi @teolemon, can it be related with #677 ?

@teolemon  One of the typical way to solve this is to display another layout which asks the user to try again after network becomes available(like browsers) .
Would you like have such a iimplementation?


FAQ is outdated or not clear on sizes of floating point numbers

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
using go version go1.7 linux/amd64
What operating system and processor architecture are you using (go env)?
What did you do?
https://play.golang.org/p/CF7xy52g2B
What did you expect to see?
float32   4: 40000000
float32   4: 40c90fdb
complex64   8:<PHONE_NUMBER>400000
(https://play.golang.org/p/OvRuleLGR5)
https://golang.org/doc/faq#q_int_sizes states
On the other hand, floating-point scalars and complex numbers are always sized: float32, complex64,
etc., because programmers should be aware of precision when using floating-point numbers. The
default size of a floating-point constant is float64.
What did you see instead?
float64   8:<PHONE_NUMBER>000000
float64   8: 401921fb54442d18
complex128  16:<PHONE_NUMBER>0000004008000000000000

I fail to detect what the perceived problem is. The default type of a floating point constant is specified to be float64, which is what the code produces when no specific type is provided.

I don't see a bug here.  Please comment if you disagree.

"floating-point scalars and complex numbers are always sized: float32, complex64"
How is this possible if constants are float64? How can you create a scalar float value without
a) specifying the type with var, or b) using a constant with :=?
After playing with it, I discovered that there are no float or complex basic types, and I understand why. Ah Ha! That's what the FAQ is saying. I missed the ", etc." OK, for me, the confusion would not have occurred with the following wording:

On the other hand, there is no float or complex type: you must always choose a size. Programmers should always be aware of precision when using floating point numbers. The default size of a floating point constant is float64, so foo := 3.0 will create foo with type float64 and bar := 3+2i will create bar with type complex128. If you want float32 or complex64, you will have to explicitly say so. e.g. var f1 float32.
I would suggest making this a separate paragraph from the int part that precedes it.

BTW: I would make a PR, but I haven't found the repo for the web site.

The web site content is in the doc directory of the go repository.

Constants in Go are untyped.
Change to the FAQ are done as changes to the file doc/go_faq.html following the directions at https://golang.org/doc/contribute.html

Yes, constants are untyped, but if you say whatever := constant then whatever is definitely typed.
https://go-review.googlesource.com/27998
Wow. That is a lot of work to make a simple change. But the second change will be easier.


CartJS.Data.toggle is using undefined function on un-check

Looks like when a checkbox with data-cart-toggle is being un-checked, the function called is CartJS.Core.removeAll(id) which doesn't exist. Should it be CartJS.Core.removeItemById(id) instead? https://github.com/discolabs/cartjs/blob/master/dist/cart.js#L435

Thanks for the report @gmlnchv! You were absolutely right. I've pushed a fix for this in release v0.2.6, which is now available on npm and bower.
Cheers!

Nice one, @gavinballard, thank you!


feat: add websocket support utils, and app handling

depends on https://github.com/unjs/listhen/pull/128
adds websocket support by giving a few helpers, highlighted here. This can be added at the top of an event handler, and its a web socket serevr ready to do with all handling logic in your hand.

if (isWebSocketEvent(event)) {
      const wsEvent = toWebSocketEvent(event);
      if (wsEvent.type === "connection") {
        wsEvent.connection.send("pong");
      } else if (wsEvent.type === "message") {
        console.log("got", new TextDecoder().decode(wsEvent.message));
      }
    }
    if (isWebSocketUpgradeRequest(event)) {
      return upgradeWebSocket(event);
    }

@pi0 is there any chance to merge this PR

Thanks for PR. ws is a Node.js dependency and we aim for cross platfom/runtime. Closing for triage.


fix wrong variable name

:tada: This PR is included in version 3.0.15 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Count with Totals

Would it be possible to add the ability to include totals to an outputted pivottable that was using counts?  For example, if I were to start with a data block like this assigned to $CSVData.
Construction Batch Schedule Status
------------------ ---------------
-1                 Past
-1                 Past
-1                 Past
-1                 Past
1                  Past
1                  Past
1                  Past
1                  Past
1                  Past
1                  Past
1                  Past
1                  Past
1                  Past
1                  Past
1                  Past
3                  Current
3                  Current
3                  Current
3                  Current
3                  Current
3                  Current
3                  Current
3                  Current
3                  Current
3                  Current
3                  Current
3                  Current
4                  Current
4                  Current
4                  Current
4                  Current
4                  Current
4                  Current
4                  Current
4                  Current
4                  Current
4                  Current
4                  Current
4                  Current
5                  Future
5                  Future
5                  Future
5                  Future
5                  Future
5                  Future
5                  Future
5                  Future
5                  Future
5                  Future
5                  Future
5                  Future
6                  Future
6                  Future
6                  Future
6                  Future
6                  Future
6                  Future
6                  Future
6                  Future
6                  Future
6                  Future
6                  Future
6                  Future
7                  Future
7                  Future
7                  Future
7                  Future
7                  Future
7                  Future
7                  Future
7                  Future
7                  Future
7                  Future
7                  Future
7                  Future
8                  Future
8                  Future
8                  Future
8                  Future
8                  Future
8                  Future
8                  Future
8                  Future
8                  Future
8                  Future
8                  Future
8                  Future
8                  Future
9                  Future
9                  Future
9                  Future
9                  Future
9                  Future
9                  Future
9                  Future
9                  Future
9                  Future
9                  Future
9                  Future
9                  Future
10                 Future
10                 Future
10                 Future
10                 Future
10                 Future
10                 Future
10                 Future
10                 Future
10                 Future
10                 Future
10                 Future
10                 Future
11                 Future
11                 Future
11                 Future

And use the command New-PSPivotTable $CSVData -yProperty "Construction Batch" -xLabel "Schedule Status" -Count it returns this.
Construction Batch CURRENT FUTURE PAST
------------------ ------- ------ ----
-1                       0      0    4
1                        0      0   11
3                       12      0    0
4                       12      0    0
5                        0     12    0
6                        0     12    0
7                        0     12    0
8                        0     13    0
9                        0     12    0
10                       0     12    0
11                       0      3    0

And I would like for it to return the totals along the perimeter so it would read like this.
Construction Batch CURRENT FUTURE PAST TOTAL
------------------ ------- ------ ---- -----
-1                       0      0    4     4
1                        0      0   11    11
3                       12      0    0    12
4                       12      0    0    12
5                        0     12    0    12
6                        0     12    0    12
7                        0     12    0    12
8                        0     13    0    13
9                        0     12    0    12
10                       0     12    0    12
11                       0      3    0     3
TOTAL                   24     76   15   115

My end goal is to replicate something I have online that looks like this.

I have not looked at this project in quite a while so I don't know off the top of my head. I can look into this when my travel schedule slows down.

Another option you might want to look at, since you are working with data as you would in Excel is to install the PSExcel module from the PowerShell gallery.
install-module psexcel

You can generate all sorts of Excel data and files even if you don't have Excel installed. You can learn more on the project's Github repo https://github.com/dfinke/ImportExcel

Yeah I have played with that and it is super strong but the boss wants embedded html reports and I'm not so sure that module can accomplish that the way I have been able to with yours. I could be wrong though, need to look through that module's docs more.


Support IPFS records in DNS Builder

IPFS addresses can be placed in DNS TXT records.  We should provide a specialized GUI for these TXT records in the DNS Builder; it will look basically the same as what we do for Tor addresses.
This issue is solely for IPFS addresses, not IPNS addresses.

Addressed here: https://github.com/namecoin/electrum-nmc/pull/372


Pull requests_config.yml

Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!

[ ] There's a clear use-case for this code change
[ ] Commit message has a short title & references relevant issues
[ ] The build will pass (run yarn test and yarn lint)

More info can be found by clicking the "guidelines for contributing" link above.
_config.yml
#I am surprised myself. I'm just getting to know this apps.
Security vulnerabilities in the environment of another application.
Jekyll vs Cayenne for Ghost.
The scanner suggests: Possible to merge.
Fixes #

#11982

[![Test https://github.com/Somnamboo/Ghost-reflex/actions/runs/314142244

@Somnamboo please read Ghost's contributor's guide. Any changes/features should have prior discussion on forum or GH issues before PR submission.


Remove the rbi/ dir to fix an issue with the Sorbet LSP.

The proper solution to this is to fix it in Sorbet with https://github.com/sorbet/sorbet/pull/2730, but until then I'd like to have a new release of sorbet-coerce so I can still use the Sorbet VS Code extension. We can revert this commit as soon as it's fixed in Sorbet :)
cc: @donaldong @manhhung741

Hi @connorshea, thanks for looking into this!
We need to have this rbi file to pretend to be a generic type when performing static type checking -- that's how we're able to pass the test cases in spec/sorbet_test_cases.rb. Using the auto-generated rbi files (i.e. from srb rbi gems) won't be sufficient for this purpose.
Unless we have another way to ship this file with this gem (and will be pick up by srb tc), I think we still need this rbi file...

so I can still use the Sorbet VS Code extension

Can we use <path to your sorbet-static gem>/libexec/sorbet --lsp as a workaround?

Closing this PR for now. Hopefully, this can be fixed soon in new sorbet-versions.


Set external signer for requests payload

close #373

My mistake, reverted changes via git reset and after made push -f instead of push. After that 397 became closed


Configurable InvokedMethodListener

Closes #1892
Provides a config parameter using which
IInvokedMethodListener invocation for SKIPPED
tests can be controlled.
Note:
This PR also changes #1777 behavior.
As per #1777 “org.testng.ITestListener#onTestStart()”
invocation for “skipped” methods was configuration
driven [JVM arg controlled].
But it turns out that the same is not true for
“org.testng.IConfigurationListener#beforeConfiguration”
which is literally the onStart() for a configuration
method. the beforeConfiguration() is called all the time.
So now to ensure that there’s behavior parity
between both configuration and test methods, the
onTestStart() is now NO LONGER configuration driven
and will get invoked all the time even for SKIPPED
@Tests.
Fixes #1892 .
Did you remember to?

[X] Add test case(s)
[X] Update CHANGES.txt

We encourage pull requests that:

Add new features to TestNG (or)
Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Based on a previous email from @cbeust I am merging this PR since @juherr has approved this PR


Which version of Caffe do you use for training?

Hi, interesting work. I want to know which version of Caffe you use for training. And could you give a detail on how to train the resnet model?

I used a normal Caffe cloned back in May (should be hash e79bc8f1f6df4db3a293ef057b7ca5299c01074a)
The training is described in the paper as well as in the proto files for the solver and network definition. I adapted the solver and definition files a bit for publication, but the logs contain all the original parameters used in training.
Do you have any specific questions?

Thank you. I just want to make sure the version of Caffe because I tried to learn new models but not failed. Thank you.


Can't open a console with rails master

@jorgemanrubia I wanted to try to bypass the protection after the latest improvements, but I can't even open a console due to a weird ActiveRecord error:
Unnamed, why are you using this console today?
testing...
Traceback (most recent call last):
	32: from bin/rails:5:in `<main>'
	31: from bin/rails:5:in `require'
	30: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/commands.rb:18:in `<top (required)>'
	29: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/command.rb:48:in `invoke'
	28: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/command/base.rb:87:in `perform'
	27: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/thor-1.1.0/lib/thor.rb:392:in `dispatch'
	26: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/thor-1.1.0/lib/thor/invocation.rb:127:in `invoke_command'
	25: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/thor-1.1.0/lib/thor/command.rb:27:in `run'
	24: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/commands/console/console_command.rb:102:in `perform'
	23: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/commands/console/console_command.rb:19:in `start'
	22: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/commands/console/console_command.rb:19:in `new'
	21: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/commands/console/console_command.rb:35:in `initialize'
	20: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/engine.rb:449:in `load_console'
	19: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/application.rb:522:in `run_console_blocks'
	18: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/engine/railties.rb:15:in `each'
	17: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/engine/railties.rb:15:in `each'
	16: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/application.rb:522:in `block in run_console_blocks'
	15: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/railtie.rb:250:in `run_console_blocks'
	14: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/railtie.rb:275:in `each_registered_block'
	13: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/railtie.rb:275:in `each'
	12: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/railties/lib/rails/railtie.rb:250:in `block in run_console_blocks'
	11: from /Users/gregmolnar/Git/console1984/lib/console1984/engine.rb:24:in `block in <class:Engine>'
	10: from /Users/gregmolnar/Git/console1984/lib/console1984/supervisor.rb:25:in `start'
	 9: from /Users/gregmolnar/Git/console1984/lib/console1984/supervisor.rb:51:in `start_session'
	 8: from /Users/gregmolnar/Git/console1984/lib/console1984/sessions_logger/database.rb:8:in `start_session'
	 7: from /Users/gregmolnar/Git/console1984/lib/console1984/sessions_logger/database.rb:53:in `silence_logging'
	 6: from /Users/gregmolnar/Git/console1984/lib/console1984/sessions_logger/database.rb:9:in `block in start_session'
	 5: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/activerecord/lib/active_record/querying.rb:22:in `find_or_create_by!'
	 4: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/activerecord/lib/active_record/relation.rb:182:in `find_or_create_by!'
	 3: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/activerecord/lib/active_record/relation/finder_methods.rb:81:in `find_by'
	 2: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/activerecord/lib/active_record/relation/query_methods.rb:715:in `where'
	 1: from /Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/activerecord/lib/active_record/relation/query_methods.rb:720:in `where!'
/Users/gregmolnar/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/bundler/gems/rails-a692e63bf400/activerecord/lib/active_record/relation/query_methods.rb:124:in `where_clause': uninitialized constant ActiveRecord::QueryMethods::Relation (NameError)
Did you mean?  ActiveRecord::Relation

If I remove the console1984 from my Gemfile, ActiveRecord works as expected. Do you have any idea what causes this?

Hey @gregmolnar,
This is weird. We are using current version in production without problem but I can reproduce in the gem "dummy" test app. I still need to figure out root cause, but I just pushed a patch that should fix the issue.
Could you try the gem directly from git and confirm it now works for you?
gem "console1984", git: "https://github.com/basecamp/console1984.git"

Thanks!

It works now, thanks for the quick response!

Great thanks @gregmolnar. I'll keep this open to remember I need to release a new version with this for RubyGems. Will do today!

Released 0.1.13 with the patch for this one.


Fix missing username on dashboard context switch navbar

Fix missing username on dashboard context switch navbar
Introduced by https://github.com/go-gitea/gitea/pull/13649

Codecov Report

Merging #13959 (19e4e07) into master (1837e64) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #13959      +/-   ##
==========================================
- Coverage   42.25%   42.12%   -0.13%
==========================================
  Files         710      710
  Lines       77226    77228       +2
==========================================
- Hits        32628    32530      -98
- Misses      39235    39346     +111
+ Partials     5363     5352      -11

Impacted Files
Coverage Δ

services/wiki/wiki.go
57.94% <0.00%> (-0.61%)
:arrow_down:

modules/notification/ui/ui.go
84.72% <0.00%> (-11.12%)
:arrow_down:

models/issue_comment.go
45.46% <0.00%> (-7.26%)
:arrow_down:

modules/queue/unique_queue_channel.go
58.06% <0.00%> (-6.46%)
:arrow_down:

modules/notification/mail/mail.go
33.33% <0.00%> (-5.75%)
:arrow_down:

modules/git/commit.go
49.67% <0.00%> (-3.95%)
:arrow_down:

modules/notification/base/null.go
74.28% <0.00%> (-2.86%)
:arrow_down:

modules/notification/notification.go
83.92% <0.00%> (-2.68%)
:arrow_down:

modules/charset/charset.go
68.53% <0.00%> (-2.25%)
:arrow_down:

services/gitdiff/gitdiff.go
69.05% <0.00%> (-1.94%)
:arrow_down:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e9a3d...19e4e07. Read the comment docs.


bugdown: Mention cleanup.

This PR refactors some of the pain points that the addition of the recent name|id syntax for mentions introduced in the codebase, as well as fixes a flaky test caused by the incorrect assumptions used to generate the data structure when fetching possibly mentioned users from the database.
Testing Plan:
Updated the existing tests where necessary. This should fix the flake that @showell pointed out yesterday in: https://chat.zulip.org/#narrow/stream/9-issues/topic/mention.20ids

I merged the first commit.  Please split the second into first a commit that just renames the function, and then a second that does stuff; it's too hard to read.

@timabbott this is ready for another review. I added two comments where the code changes felt a little less obvious and have split the renaming into its separate commit.

The commit structure still wasn't clear.  I decided to show you the right structure, and split out e4946dd182851326928c8936b3eb8f83eca30b7b (with which the following commit is now readable).
I've merged all but the last commit, however, I don't understand why the last commit is correct or desirable.  Can you fix its commit message to explain that?  Thanks @aero31aero!

Since we have a get_user_by_id, renaming get_user to get_user_by_name made sense. The important part is the warning comment in the function, however. This warning should have been there earlier as well, since historically, it always just returned one user only even if multiple users would have matched.

Oh, I see, I didn't realize it was a pure rename (since we have other functions called get_user, I had been assuming you were changing what was being called).  In the future, use "Rename ...", not "Refactor ..." when the only change is renaming things.
Merged, thanks @aero31aero!


chore: Remove default parameter of AbruptStreamTerminationException

Motivation:
The default parameter should not be there, I was influenced by the MaterializationException

The MaterializationException is unused ,maybe we should deprecated it?

@mdedetrich The change is against a newly added code yesterday , so let me just merge it?

@mdedetrich The change is against a newly added code yesterday , so let me just merge it?

Ah okay, sure then go ahead

LGTM


_goto_cartesian_interpolation incompatibility

_goto_cartesian_interpolation cannot be used along with other goto functions or goal_position.
If we send a command with _goto_cartesian_interpolation, and then ask for reachy.r_arm.wrist.pitch.goal_position = 0, all the right arm moves to its last goto or goal_position position.

Finally, using the functions are not compatible with the use of goto_from_matrix. Let's suggest another function for interpolations


Can't access build items past 100

When all of the Valkea and Clutter items are added to one build menu, players on my server cannot access any build items past 100.

This is an Auga bug. It is adding a scrollbar but not updating how pieces are selected. This means Auga can only have 91 pieces per tab like in vanilla.


[API/Console] Removed configuration keeps getting re-added to values repo

With more and more concurrent users using Otomi at the client, we are encountering the issue where configuration that has been deleted (in this case the Vault unseal config), keeps being re-introduced to the values repo while deploying other changes. This issue persists even after API and Console pods are killed.
For instance:

Vault unseal config is deleted in values
Drone pipeline runs
API and console pods are killed
User makes a change in Console (e.g. adding a secret)
Clicks deploy changes
Deleted Vault unseal config is re-introduced to values
Vault service is interrupted as we're not yet ready to deploy this configuration, config must be removed once again and Vault pod killed

I have asked the DevOps team to clear their browser cache, but observed the same thing happen to a user who opened Otomi in a private window, so we're stumped. It's still possible that the browser cache was at fault as I can't be sure if he opened the window before or after the API and Console pods were killed. Regardless, with more and more concurrent users it will be impossible to ensure everyone has cleared their browser cache in sync, and that a contaminated state won't make its way back to the API.
Below is a screenshot of a 3 user collision, with relevant commits highlighted:

Hi @staticvoid255, are you aware that when you do manual commits of values that you are then responsible for restarting otomi-api? Otherwise the next person will overwrite your changes

Example: I see you committed "remove vult seal config" and wonder if you restarted (and thus re-inflated the api with your changes) after that

Example: I see you committed "remove vault seal config" and wonder if you restarted (and thus re-inflated the api with your changes) after that

Yes, every time

We will investigate it and try to reproduce locally.

@srodenhuis this is where we initially encountered the issue and can confirm API and Console were restarted between changes

This will be fixed in #925


guides: clicking a LHS block (but not its text) changes background and adds tick but does not execute

Should be fixed now


verify-attestation should support --platform argument

Per my understanding, the use of SBOMs was deprecated and should be replaced by attestations. However, the verification of multiarch image attestations can be highly misleading for the end user. Comparison:
SBOMs:
cosign download sbom registry/repo/image:tag

This multiarch image does not have an SBOM attached at the index level.
Try using --platform with one of the following architectures:
linux/amd64, linux/arm64, linux/ppc64le

Error: no SBOM found attached to image index

attestations:
cosign verify-attestation registry/repo/image:tag

Error: no matching attestations:

I see two issues with this:

The user is not notified that attestations exist for the arch images
The user cannot specify the architecture whose attestation they want to get (with SBOMs this was possible with --platform argument)

The only way to get a multiarch image attestation is to specify the image via digest (if that even occurs to a user, since no hint was given). I don't think it's reasonable to expect this from the end users.

@querti, last time I checked, there isn't a lot of guidance on what to do with Image Indexes, aka multi-arch images. I've explored this in the past and one of the approaches that seems reasonable is to attach multiple SBOMs to the Image Index.
Signing and attesting both Image Indexes and Image Manifests seems to be the most compatible option since an Image Index is eventually resolved to an Image Manifest upon usage. This allows verification at different points, for example.
It is probably a good idea to improve the error message when a signature/attestation is not found and the image reference is to an Image Index, like the download sbom command does. That sounds like useful information to users.


Jan2023 bug bash

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

25 of 27 (92.59%)  changed or added relevant lines in 9 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.09%) to 80.503%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/DevOpsMetrics.Core/DataAccess/PullRequestsDA.cs
2
4
50.0%

Files with Coverage Reduction
New Missed Lines
%

src/DevOpsMetrics.Core/DataAccess/LeadTimeForChangesDA.cs
3
73.94%

src/DevOpsMetrics.Core/Models/Common/Build.cs
3
90.77%

Totals

Change from base Build<PHONE_NUMBER>:
0.09%

Covered Lines:
2563

Relevant Lines:
3136

💛  - Coveralls


integration not found in automation trigger

hi, I was trying your example automation but there is something wrong with the code:
    trigger:       - platform: geo_location         source: "ingv_centro_nazionale_terremoti"
the trigger is not recognized... source "ingv..." says INTEGRATION NOT FOUND.
Did you have some suggestion?
card and all other things works perfectly!

Hello.  This is a custom component, it must be installed manually or via HACS.  In the documentation I see that I have not entered how to install the component😝 Do you use HACS?

Caio you did a grat job, also without that missed up in documentation!
I installed the component in HACS (via the GUI) and edited the config file manually as your instructions and examples.
I already written down the geolocation:
`# INGV TERREMOTI LOCATION
geo_location:

platform: ingv_centro_nazionale_terremoti
radius: 100
minimum_magnitude: 2.0`

and inserted the zone "geoalarm" in the gui (also tried in the config.yaml... but not both at the same time, obviously).
I don't know if the problem is due to a newer version of HA or something else, anyway, I saw in the automation visual editor that the trigger platform "GEO_LOCATION" don't exist (anymore maybe?).
Se vuoi possiamo parlarne in italiano per una miglior comprensione, felice di aiutarti per quel che posso
Francesco

Ciao Caio, yes I installed via HACS gui (clicked on "install").
Custom card works flawlessly (with your code and tried also with my code to match my personalization) but in automation there is the error on trigger "Integration not found".
Se vuoi possiamo continuare in italiano, felice di aiutarti il piu' possibile

sorry Caio, that was a "fake" issue: a problem on spotify integration made all those errors on automation.
Thanks!


23 FMC single is marked as world record

Thanks for the report, looks like #145 reoccurring, I will look into this in the near future :)


Bug/bundling errors swallowed

Reproduces #266. To fix, emit error from the watchify bundle.

I'm not sure about this. This makes the bundle stream emit errors twice. The tests should be failing for you.

You're right, this is mainly confusion on my part. I never realized errors were meant to be handled in the bundle() callback. Closing.


Shared photos not working on Monterey

Error exporting photo (50098B3B-5442-47AA-8F8C-B0BF0270965E: IMG_6467.HEIC) as "location": Invalid photo id: 50098B3B-5442-47AA-8F8C-B0BF0270965E (_photoinfo_export.py: 1343)
Get this error even though all pictures are loaded into the library.

What's the full command line you're using with osxphotos?

osxphotos export --download-missing --directory {folder_album} --not-shared --deleted "export_location"
I started doing the not-shared to see if it had to do with any of the share libraries, but that wasn't it.

Are you getting lots of these errors or only a few?
I think this is because --download-missing doesn't work with deleted files and you're also using --deleted.  What should happen in this case is all other photos will be exported but those in the trash and are missing will not be exported and will produce this error.  Photos does not sync the actual image from iCloud for photos in the trash so osxphotos cannot export these.  Photos recently deleted on the local machine will still be available in the trash and those can be exported.
Try this:
osxphotos query --json --uuid 50098B3B-5442-47AA-8F8C-B0BF0270965E
And look for the value that says "intrash": true or "intrash": false.  My guess is it'll say "intrash": true for that particular photo.

I'll give that a look after the export.  Yes I'm getting many of those.  Should I run an export with the --download-missing and then an update export with --deleted

Just looking at this point.  There is only one photo in the Recently Deleted spot in photos

I'll give that a look after the export. Yes I'm getting many of those. Should I run an export with the --download-missing and then an update export with --deleted

That might work if indeed the issue is deleted photos. But if you only have one deleted photo it might be something else.  Try the export with the --use-photokit flag with your current options which uses a different code path for missing photos.  It's usually more robust than just using --download-missing by itself which defaults to AppleScript.

Just so I'm clear try my export as given to you with --use-photokit instead of --download-missing.  Should I leave the --deleted out

Just so I'm clear try my export as given to you with --use-photokit instead of --download-missing. Should I leave the --deleted out

I would try this:
osxphotos export --download-missing --use-photokit --directory {folder_album} --not-shared --deleted "export_location" --update
Using --use-photokit with --download-missing causes osxphotos to use PhotoKit (a native macOS code framework) instead of AppleScript to download missing photos from iCloud.  The addition of --update will cause osxphotos to only export photos not previously exported to save time.

Ran an update export without the --not-shared and got this error message:   Same number of missing
Error exporting photo (093B5199-93D5-4925-9F2C-60FABED78500: 6F39365D-16BB-48F1-B440-24B849CCDFC9.JPG) as 6F39365D-16BB-48F1-B440-24B849CCDFC9.JPG: expected str, bytes or os.PathLike object, not NoneType

ran an update without the --not-shared and without the --download-missing
Got less errors this time, but of this type
Error exporting photo (08DE40C8-A47A-427F-95D6-15430C6FEE80: IMG_6470.HEIC) as IMG_6470.HEIC: expected str, bytes or os.PathLike object, not NoneType

also seeing this error.  I'm confident this relates to photos in the sharing library
Error exporting photo (ECBEEA11-AF25-41B4-B63C-763F76B330C8: 6E81D59F-8A6D-4A1F-BF97-319F5FAB9507.mp4) as "export dest" couldn’t be copied to “export-folder” because an item with the same name already exists." UserInfo={NSSourceFilePathErrorKey="file location", NSUserStringVariant=(
Copy
), NSDestinationFilePath="export location", NSFilePath="export dest", NSUnderlyingError=0x600003e843f0 {Error Domain=NSPOSIXErrorDomain Code=17 "File exists"}} (_photoinfo_export.py: 1274)

Error exporting photo (ECBEEA11-AF25-41B4-B63C-763F76B330C8: 6E81D59F-8A6D-4A1F-BF97-319F5FAB9507.mp4) as "export dest" couldn’t be copied to “export-folder” because an item with the same name already exists." UserInfo={NSSourceFilePathErrorKey="file location", NSUserStringVariant=(
Copy
), NSDestinationFilePath="export location", NSFilePath="export dest", NSUnderlyingError=0x600003e843f0 {Error Domain=NSPOSIXErrorDomain Code=17 "File exists"}} (_photoinfo_export.py: 1274)

This error occurs if there's a name collision in the export folder (osxphotos tries to export two photos with the same name to the same folder) though in most cases, osxphotos should try to increment the file name, e.g. add (1), (2) etc to the name.  Not sure why it's not happening in your case so possibly a bug.
It would be helpful to have some more debugging info on the particular photos that are causing these errors so I can see if there's something in common with them.  The long alpha-numeric string that shows up in each of these error messages (e.g. ECBEEA11-AF25-41B4-B63C-763F76B330C8) is the unique ID (UUID) by which Photos tracks the photo.  Using that, osxphotos can extract additional info about the photo.
Could you try the following command:
osxphotos debug-dump --dump photos --uuid 50098B3B-5442-47AA-8F8C-B0BF0270965E --uuid ECBEEA11-AF25-41B4-B63C-763F76B330C8 --uuid 08DE40C8-A47A-427F-95D6-15430C6FEE80 --uuid 093B5199-93D5-4925-9F2C-60FABED78500 > debug.txt
and post the output here.  I recommend you inspect the debug.txt file first as it may contain information you consider private -- e.g. names of people in photos, place names etc.  This command dumps all the raw info that osxphotos knows about the photos with those particular UUIDs.

Here is the debug_dump
I have a hunch that this problem deals with photos shared with me that I haven't saved officially yet.
Opening database:
Done; took 10.91 seconds
_dbphotos['50098B3B-5442-47AA-8F8C-B0BF0270965E']:
{'UTI': 'public.heic',
'UTI_original': None,
'UTI_raw': None,
'_uuid': '50098B3B-5442-47AA-8F8C-B0BF0270965E',
'added_date': datetime.datetime(2021, 10, 30, 22, 56, 53, 162543),
'adjustmentFormatID': None,
'adjustmentUuid': None,
'albums': [],
'alt_master_uuid': None,
'burst': False,
'burstPickType': 0,
'burstUUID': None,
'cloudAssetGUID': None,
'cloudAvailable': None,
'cloudLibraryState': None,
'cloudLocalState': None,
'cloudStatus': None,
'cloudbatchpublishdate': None,
'cloudownerhashedpersonid': None,
'countryCode': None,
'customRenderedValue': 10,
'datastore_subtype': None,
'depth_state': 0,
'directory': '5',
'extendedDescription': None,
'favorite': 0,
'filename': '50098B3B-5442-47AA-8F8C-B0BF0270965E.heic',
'fok_import_session': None,
'hasAdjustments': 0,
'hasAlbums': 0,
'hasKeywords': 0,
'hasPersons': 0,
'has_raw': False,
'hdr': False,
'height': 4032,
'hidden': 0,
'imageDate': datetime.datetime(2021, 10, 30, 22, 54, 42, 702000, tzinfo=datetime.timezone(datetime.timedelta(days=-1, seconds=72000))),
'imageDate_timestamp': 657341682.702,
'imageTimeZoneOffsetSeconds': -14400,
'import_session': None,
'import_uuid': None,
'incloud': None,
'intrash': False,
'isMissing': 0,
'isreference': False,
'keywords': [],
'lastmodifieddate': None,
'lastmodifieddate_timestamp': None,
'latitude': 39.57212,
'live_photo': True,
'localAvailability': 1,
'longitude': -86.1652,
'masterFingerprint': None,
'masterUuid': None,
'modelID': None,
'momentID': 912,
'name': None,
'non_raw_master_uuid': None,
'orientation': 6,
'originalFilename': 'IMG_6467.HEIC',
'original_filesize': 1640000,
'original_height': 4032,
'original_orientation': 6,
'original_resource_choice': 0,
'original_width': 3024,
'panorama': False,
'persons': [],
'pk': 8969,
'placeIDs': None,
'placeNames': None,
'portrait': False,
'raw_data_length': None,
'raw_info': None,
'raw_is_original': False,
'raw_master_uuid': None,
'remoteAvailability': 0,
'resource_type': None,
'reverse_geolocation': None,
'saved_asset_type': 12,
'screenshot': False,
'selfie': False,
'shared': False,
'slow_mo': False,
'subtype': 2,
'time_lapse': False,
'trasheddate': None,
'trasheddate_timestamp': None,
'type': 0,
'visibility_state': 0,
'visible': True,
'width': 3024}
_dbphotos['ECBEEA11-AF25-41B4-B63C-763F76B330C8']:
Did not find uuid ECBEEA11-AF25-41B4-B63C-763F76B330C8 in _dbphotos
_dbphotos['08DE40C8-A47A-427F-95D6-15430C6FEE80']:
{'UTI': 'public.heic',
'UTI_original': None,
'UTI_raw': None,
'_uuid': '08DE40C8-A47A-427F-95D6-15430C6FEE80',
'added_date': datetime.datetime(2021, 10, 30, 22, 56, 53, 162543),
'adjustmentFormatID': None,
'adjustmentUuid': None,
'albums': [],
'alt_master_uuid': None,
'burst': False,
'burstPickType': 0,
'burstUUID': None,
'cloudAssetGUID': None,
'cloudAvailable': None,
'cloudLibraryState': None,
'cloudLocalState': None,
'cloudStatus': None,
'cloudbatchpublishdate': None,
'cloudownerhashedpersonid': None,
'countryCode': None,
'customRenderedValue': 10,
'datastore_subtype': None,
'depth_state': 0,
'directory': '0',
'extendedDescription': None,
'favorite': 0,
'filename': '08DE40C8-A47A-427F-95D6-15430C6FEE80.heic',
'fok_import_session': None,
'hasAdjustments': 0,
'hasAlbums': 0,
'hasKeywords': 0,
'hasPersons': 0,
'has_raw': False,
'hdr': False,
'height': 4032,
'hidden': 0,
'imageDate': datetime.datetime(2021, 10, 30, 22, 55, 12, 935000, tzinfo=datetime.timezone(datetime.timedelta(days=-1, seconds=72000))),
'imageDate_timestamp': 657341712.935,
'imageTimeZoneOffsetSeconds': -14400,
'import_session': None,
'import_uuid': None,
'incloud': None,
'intrash': False,
'isMissing': 0,
'isreference': False,
'keywords': [],
'lastmodifieddate': None,
'lastmodifieddate_timestamp': None,
'latitude': 39.572095,
'live_photo': True,
'localAvailability': 1,
'longitude': -86.1651695,
'masterFingerprint': None,
'masterUuid': None,
'modelID': None,
'momentID': 912,
'name': None,
'non_raw_master_uuid': None,
'orientation': 6,
'originalFilename': 'IMG_6470.HEIC',
'original_filesize': 1693560,
'original_height': 4032,
'original_orientation': 6,
'original_resource_choice': 0,
'original_width': 3024,
'panorama': False,
'persons': [],
'pk': 8866,
'placeIDs': None,
'placeNames': None,
'portrait': False,
'raw_data_length': None,
'raw_info': None,
'raw_is_original': False,
'raw_master_uuid': None,
'remoteAvailability': 0,
'resource_type': None,
'reverse_geolocation': None,
'saved_asset_type': 12,
'screenshot': False,
'selfie': False,
'shared': False,
'slow_mo': False,
'subtype': 2,
'time_lapse': False,
'trasheddate': None,
'trasheddate_timestamp': None,
'type': 0,
'visibility_state': 0,
'visible': True,
'width': 3024}
_dbphotos['093B5199-93D5-4925-9F2C-60FABED78500']:
Did not find uuid 093B5199-93D5-4925-9F2C-60FABED78500 in _dbphotos

I'll look through this later and see if I can find any hints.  You can inspect the actual photos in case that gives you any clues.  Try this:
osxphotos repl
Then in the interactive session that opens up, type
photo = get_photo("50098B3B-5442-47AA-8F8C-B0BF0270965E")
spotlight(photo)

That will open photos and show the photo in question for that UUID.

I have a hunch that this problem deals with photos shared with me that I haven't saved officially yet.

Those should be skipped with the --not-shared flag

Running the interactive sessions gave me an Attribute Error:  'NoneType' object has no attribute 'uuid'

importing all of my shared photos (there were only 58) seemed to fix the problem with both deleted and download-missing and without the not-shared option.

spoke too soon getting this error
Error exporting photo (764BEDEB-F19A-4A29-A283-3848E0455935: 6E81D59F-8A6D-4A1F-BF97-319F5FAB9507.mp4) as "location": Error Domain=NSCocoaErrorDomain Code=516 "“764BEDEB-F19A-4A29-A283-3848E0455935.medium.MP4” couldn’t be copied to “private location” because an item with the same name already exists." UserInfo={NSSourceFilePathErrorKey="private location Photo Library.photoslibrary/scopes/cloudsharing/data/1078045304/EE0E98FF-E25B-41D1-8344-DD8C254A0841/764BEDEB-F19A-4A29-A283-3848E0455935.medium.MP4, NSUserStringVariant=(
Copy
),  (_photoinfo_export.py: 1274)

Running the interactive sessions gave me an Attribute Error: 'NoneType' object has no attribute 'uuid'

That means the UUID can't be found in the database which is weird as I copied it from one of your error messages.
It might be worth trying to repair the library (launch Photos while holding down Command+Option) but I'd make sure to have a backup before doing this. The repair process rebuilds the photos database.

Repaired the library.  Had to turn off and then turn on the shared albums in preferences to get them to load.
Getting 1274 errors.  All photos getting errors are photos in a shared album.

As far as I can tell at this point it looks like osxphotos is not correctly identifying shared photos (photos in shared albums) on Monterey. I don't have a Mac capable of running Monterey so I can't test this at the moment.  Could you try the interactive session again with one or two of the UUIDs that are causing errors (osxphotos repl) then
photo = get_photo("UUID here")
photo.shared

photo.shared should print True but if it prints nothing it means osxphotos doesn't recognize this as a shared photo. I'll dig into the database to see if I can figure out which of the Monterey changes could be causing this.

The several that I checked recognized as true.

The several that I checked recognized as true.

So at least some of the shared photos are being recognized.
Besides the errors for what you suspect are shared photos are the rest of your photos being successfully exported?

@all-contributors add @neebah  for bug

@all-contributors add @alandefreitas for bug

I have at least one photo that shows up with shared = False:
[...]
description: null
title: null
keywords: []
albums: []
persons: []
path: null
ismissing: false
hasadjustments: false
external_edit: false
favorite: false
hidden: false
latitude: //...
longitude: //...
path_edited: null
shared: false
isphoto: true
ismovie: false
uti: public.jpeg
burst: false
live_photo: true
path_live_photo: null
iscloudasset: false
incloud: null
date_modified: null
portrait: false
screenshot: false
slow_mo: false
time_lapse: false
hdr: false
selfie: true
panorama: false
has_raw: false
uti_raw: null
path_raw: null
[...]
intrash: false
[...]

Looking in Photos.app for photos taken at this exact time I see that it has the characteristic From XYZ at the top of the image.
Are there any outputs I could provide that would be helpful to debug?

Perhaps I spoke too soon - repairing the Photos database resolved my issue.


Tool sometimes doesn't send commands

Interesting behavior, tool appears to be waiting for something? Perhaps we should print out a debug message every second or so when waiting for the console log file to be created: https://discord.com/channels/716525494421553243/718612821973401650/734728505916391474

Closing this issue as I've only heard of it happening to one person (in the discord link above). That user never reported back of it happening again after additional debug messages were added, so I'm not sure what else can be done to resolve this right now.


Refactor TreeData 💯

Refactor TreeData children into multiple files.
Move custom like and adoption hooks from TreeAdoptionLike.js to queries.js.
Simplify creation of data tables in <TreeLocation>, <TreeMoreInfo> and <TreeHeader>.
Enable pressing esc or clicking outside the tree editing modal to close it.
Rename treedata_utilities.js to treeDataUtils.js.
Don't export putData, as it's no longer used directly outside of queries.js.
Support passing a default options object to createUseQuery().

This should be merged after #99.
Should these commits be squashed, first?

There are TreeHeader and TreeInfo components in both addtree/ and treedata/, but they appear unrelated.  I didn't add any of those.  I just added a simple component to spit out rows of key/value pairs instead of having lots of repeated code.


Error: Building package parson:x64-windows failed with: BUILD_FAILED

Your script told me to create an issue so here I am.  :-)
Running on Windows 10, this command from the instructions at ... https://docs.microsoft.com/en-us/azure/iot-edge/how-to-visual-studio-develop-module ...
vcpkg.exe install azure-iot-sdk-c:x64-windows
... after having built vcpkg.exe, this is the output I received ...
The following packages will be built and installed:

azure-c-shared-utility[core]:x64-windows
azure-iot-sdk-c[core]:x64-windows
azure-macro-utils-c[core]:x64-windows
azure-uamqp-c[core]:x64-windows
azure-uhttp-c[core]:x64-windows
azure-umqtt-c[core]:x64-windows
parson[core]:x64-windows
umock-c[core]:x64-windows
Additional packages (*) will be modified to complete this operation.
Starting package 1/8: parson:x64-windows
Building package parson[core]:x64-windows...
parson only supports static linkage
-- Using cached C:/Repos/vcpkg/downloads/kgabis-parson-33e5519d0ae68784c91c92af2f48a5b07dc14490.tar.gz
-- Using source at C:/Repos/vcpkg/buildtrees/parson/src/b07dc14490-fe9872edbc
-- Configuring x64-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
Command failed: ninja -v
Working Directory: C:/Repos/vcpkg/buildtrees/parson/x64-windows-rel/vcpkg-parallel-configure
Error code: 1
See logs for more information:
C:\Repos\vcpkg\buildtrees\parson\config-x64-windows-out.log

Call Stack (most recent call first):
scripts/cmake/vcpkg_configure_cmake.cmake:295 (vcpkg_execute_required_process)
ports/parson/portfile.cmake:18 (vcpkg_configure_cmake)
scripts/ports.cmake:94 (include)
Error: Building package parson:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: parson:x64-windows
Vcpkg version: 2020.01.17-nohash
Additionally, attach any relevant sections from the log files above.
Log file mentioned above attached.
config-x64-windows-out.log
Apologies but this is all a black box to me and basically, it's listed as a pre-requisite to in the URL I provided above.  If there's anything else you need from me, I'm more than happy to provide it.

@brad-dixon, you can try https://github.com/microsoft/vcpkg/issues/9554#issuecomment-571059914, please reopen this issue if it still be a problem for you.


Euroc dataset format

Question: What is the coordinate convention for cameras in Euroc dataset?
For example, for kitti the paper clearly says Camera: x = right, y = down, z = forward

Coordinate frame is determined by the VIO system, so for Kimera we use that system.


Add secure redis

PR Checklist
Please check if your PR fulfills the following requirements:

[X] The commit message follows our guidelines: https://wiki.edgexfoundry.org/display/FA/Contributor's+Guide
[ ] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
Redis can only be used without authentication
Issue Number: #2449
What is the new behavior?
Redis can be used with authentication
Does this PR introduce a breaking change?

[ ] Yes
[X] No

Are there any specific instructions or things that should be known prior to reviewing?
This is tightly coupled to
developer-scripts PR#248
go-mod-bootstrap PR#68
Other information

I have no idea why the PR is showing I changed 97 files. I changed/added
.gitignore
Makefile
SECURITY.md
cmd/core-command/res/configuration.toml
cmd/core-data/res/configuration.toml
cmd/core-metadata/res/configuration.toml
cmd/security-file-token-provider/res/token-config.json
cmd/security-secrets-setup/README.md
cmd/security-secretstore-read/Attribution.txt
cmd/security-secretstore-read/README.md
cmd/security-secretstore-read/main.go
cmd/security-secretstore-read/res/configuration.toml
cmd/security-secretstore-setup/Dockerfile
cmd/security-secretstore-setup/README.md
cmd/security-secretstore-setup/entrypoint.sh
cmd/support-logging/res/configuration.toml
cmd/support-notifications/res/configuration.toml
cmd/support-scheduler/res/configuration.toml
go.mod
internal/pkg/bootstrap/handlers/database/database.go
internal/security/secretread/config.go
internal/security/secretread/constants.go
internal/security/secretread/init.go
internal/security/secretstore/init.go

Done reviewing for now.  Will wait for up-to-date docker-compose and do a system-level test next.

Codecov Report

Merging #2497 into master will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2497      +/-   ##
==========================================
+ Coverage   38.82%   38.91%   +0.08%
==========================================
  Files         145      145
  Lines       12781    12724      -57
==========================================
- Hits         4962     4951      -11
+ Misses       7539     7500      -39
+ Partials      280      273       -7

Impacted Files
Coverage Δ

internal/security/secretstore/init.go
3.92% <0.00%> (-2.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b2e4d9...5316c95. Read the comment docs.

@tingyuz  Would like some help testing.... Pull down this branch, run a make docker, then pull down the redis security enable docker-compose files, change the :master images to :master-dev (for the ones built by edgex-go) and give it a shot.

I am having some trouble to bring the core services successfully. After running the modified docker-compose file I noticed the core services ( coredata/matedata/command etc) were running a bit then just quit. Some timing related issues here.

@tingyuz Please share a log from one of the microservices that is quiting.

@tingyuz Please share a log from one of the microservices that is quiting.

My mistake - I haven't updated the consul images for weeks which caused the failure. Just updated to the latest version and it is working as expected.

@andresrinivasan  Merging is blocked.
[2020-04-22T19:01:52.567Z] go: extracting golang.org/x/text v0.3.2
[2020-04-22T19:01:53.654Z] ./bin/test-attribution-txt.sh
[2020-04-22T19:01:56.414Z] An attribution for github.com/go-redis/redis/v7 is missing from in cmd/security-secretstore-read Attribution.txt, please add
[2020-04-22T19:01:58.456Z] make: *** [test] Error 1