Add checks for glyph sets being complete and up to date

In Alexei's https://github.com/google/fonts/pull/556 (and discussion here) he rejigged the Cyrillic glyph sets. Therefore we should have some FB checks to ensure that the TTFs we are onboarding are using the latest glyphsets, since we'll want to know about it to bring them all up to date in the future.

Surely this should apply to all our charsets and not just Cyrillic?

This should be done soon so moved to 0.2.0
If this is to be be done with pyfontaine, that means updating pyfontaine to use the stuff @graphicore is doing on the glyph set definitions in the /google/fonts repo...

In this issue description, where you say "(and discussion here) " the link seems broken:
https://groups.google.com/forum/#!msgid/googlefonts-discuss/CADUrt2EuXciPtRvxV4HojXCYeym7gpthHBKVdLoueVyaL6-wng%2540mail.gmail.com
@davelab6 can you please check that URL and possibly provide a good one so that I can read the referenced discussion?

The closest I could find by searching Alexei's postings to the google-fonts-discuss mailing list was his "Font Quality Improvement Project — Alexei's Worklog" but that's hundreds of messages...
@davelab6 could you perhaps pinpoint exactly where is the relevant discussion in the mailing list?

(or maybe @alexeiva himself could help here as well :-D)

The latest discussion on glyphsets is here:
https://github.com/google/fonts/pull/685#discussion_r105740288
Lasse has updated the documentation and unified filter list vs nam files
consistency.
On Mar 23, 2017 02:41, "Felipe Corrêa da Silva Sanches" <
<EMAIL_ADDRESS>wrote:

(or maybe @alexeiva https://github.com/alexeiva himself could help here
as well :-D)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/googlefonts/fontbakery/issues/1189#issuecomment-288573353,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AP3Q6X21Dk8iwSZQ2Pf81mUpkf7-JoCdks5robGogaJpZM4LScxB
.

@felipesanches  to read the *.nam files you should use def codepointsInNamelist which returns a set of all unicode codepoints (as integers) in the Namelist and its includes (dont use unique_glyphs = False
To get all unicodes from a font you can have a look at def namelist_from_font Where the most subtle information is that not all cmap are Unicode encoded, hence: if not cmap.isUnicode(): continue.
For your kind of tests it may be helpful to know which Glyphsets should be supported by a font, I don't know where you would get that information from.

I have ported the Google Fonts Glyphsets definitions from https://github.com/google/fonts/tree/master/tools/encodings/GF Glyph Sets into pyfontaine so that it can be used to check glyph coverage status on fontbakery checks.
This is the pull request with the port:
https://github.com/davelab6/pyfontaine/pull/93
While doing so, I removed the old gwf_* glyphsets since I presume they are now deprecated. If that's not the case, I can bring them back.
These are the glyphsets that I ported into pyfontaine:
google_cyrillic_historical            Google Fonts: Cyrillic Historical
google_cyrillic_plus                  Google Fonts: Cyrillic Plus
google_cyrillic_plus_locl             Google Fonts: Cyrillic Plus (Localized Forms)
google_cyrillic_pro                   Google Fonts: Cyrillic Pro
google_greek_ancient_musical_symbols  Google Fonts: Greek Ancient Musical Symbols
google_greek_archaic                  Google Fonts: Greek Archaic
google_greek_coptic                   Google Fonts: Greek Coptic
google_greek_core                     Google Fonts: Greek Core
google_greek_expert                   Google Fonts: Greek Expert
google_greek_plus                     Google Fonts: Greek Plus
google_greek_pro                      Google Fonts: Greek Pro
google_latin_core                     Google Fonts: Latin Core
google_latin_expert                   Google Fonts: Latin Expert
google_latin_plus                     Google Fonts: Latin Plus
google_latin_plus_optional            Google Fonts: Latin Plus (Optional Glyphs)
google_latin_pro                      Google Fonts: Latin Pro
google_latin_pro_optional             Google Fonts: Latin Pro (Optional Glyphs)

And these are the remaining gwf_* glyphsets that I did not remove because they do not have glyph-list (*.nam) files on google/fonts git repo yet:
gwf_arabic         Google arabic
gwf_extras         Google extras
gwf_vietnamese     Google vietnamese

Once we merge that into pyfontaine, I'll be writing specific checks in fontbakery to error if a given family fails to provide all glyphs from a PLUS glyphset and checks that spit out only WARNINGS if a family fails to implement glyphs from EXPERT/PRO sets.
I think that's the expected behaviour based on the following statement available on https://github.com/google/fonts/blob/master/tools/encodings/GF Glyph Sets/README.md :
"Three levels of glyph sets were developed in June 2016 as a new baseline standard for fonts in the Google Fonts library. Exising fonts in the library can be upgraded to these as part of a drive towards new quality standards. All new fonts submitted to the library must now support the Plus level as a minumum requirement."
Attached is an example of pyfontaine being used to check the Google Fonts Greek Pro glyph coverage of Rubik Bold (it scores at 87%).
cheers,
Felipe

Work on this issue is currently blocked by a pending pull request on the upstream pyfontaine repo: davelab6/pyfontaine#93 Who can merge that? It that only you, @davelab6 ?

Merged


Create property that determines if external IDs are shown inside location details modal

What
Add support for showExternalIDs
How
Create a new parameter for showExternalIDs
Add the parameter to the webcomponent.js
Handle the parameter and check if it's a boolean
If it is set to true then externalIDs will be shown inside location details modal, otherwise it is not visible

@matbmapspeople You have to update the Directions.jsx file as well on line 290, LocationDetails.jsx file on line 209 and ListItemLocation.jsx file on line 65. All these places use the showExternalDs prop.

Ready for re-review @andreeaceachir142

I fixed the issues @andreeaceachir142


Update smapOne Connector

Update the smapOne Connector to reflect changes in our API

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[ ] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[ ] I attest that the connector works and I verified by deploying and testing all the operations.
[ ] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[ ] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[ ] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[ ] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[ ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[ ] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[ ] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

Hi,
yes, i can confirm, that this change will not affect any existing users. According to our logs the now required fields are used on every request. This matches the expectation, as it makes no sense to leave them empty for the action you can do with it.
The changed path is also changed on purpose, as it gives better resource usage on our side.


Sensitive data is exposed using azure classic provider

What happened?
When I initialize the Azure classic provider with Azure sensitive data i.e. client id/client secret to deploy some Azure resources, the sensitive data is not encrypted in the Pulumi stack and there it's exposed in plain text.
We have used Azure Classic instead of Azure native library because of this bug described here:
https://github.com/pulumi/pulumi-azure-native/issues/684
Can be this solved with another version of Azure Classic provider as the Azure Native is built or what's your recommendation to mitigate this high-security issue?
If there is not an easy fix to solve this, can you provide me some references about how to migrate from Azure Classic to Azure Native v1 and then to Azure Native v2  WITHOUT deleting the existing resources deployed in a production environment?
Example
The invoked object for Azure Classic provider:

Azure Classic provider implementation:

Here, the sensitive data is NOT encrypted in pulumi stack.
I would expect to be implemented in the same way as the below
Azure Native provider implementation:

Here, the sensitive data is encrypted in pulumi stack.
Output of pulumi about
The id and secret of the client are exposed in plain text in the Pulumi stack for the Azure Classic Provider input.
Additional context
For azure native v1 to v2 migration, we have this documentation:
https://www.pulumi.com/registry/packages/azure-native/from-v1-to-v2/
What about Classic to Native migration? It this possible?
BR, Gabriel
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Thanks so much for reporting @GabiSoare indeed it appears that the auth-related fields are not marked as secret which can expose users to unnecessary risk. Correcting this oversight in #1686.
As to classic to native migration we have some documentation in https://www.pulumi.com/registry/packages/azure-native/from-classic/ but it is far from an automated process at the moment.


Transferring some functions here

The two functions that load from GAMBLR.results need to exist in this repo so they work properly when run without a MAF input.

I realized this has some conflicts with Master that should be resolved. Stay tuned.


feat(ranking): only boost actually exact matches

Some examples where the previous filter worked better:
places -> places.js is a better first match than places, but the other results are fairly relevant (except the babel one)
Places only exact match works better

react (removes re-act and reactjs which are bad packages)
bootstrap (removes unpopular bootstrapjs package)

You can check these changes out in the npm-search_old index where I've tried out the change
cc @MartinKolarik

There's a couple queries from https://github.com/algolia/npm-search/pull/194 (the original PR) which have worse results now:

reactnative (doesn't show the actual react-native package, as it's not actually as popular as tools that are used in emotion etc.)
react native

I don't really see a solution for that though. React native is popular as a concept, but less popular than tools used everywhere that happen to have react native support, especially as the match is also in the name.
The other

Overall this is probably better than before (and I know it's easier), but I didn't want to go this route because the number of legit packages that use .js in their name isn't actually so small and some of them are even among the most popular projects at jsDelivr. From the top 100 packages: hls.js, popper.js, video.js, instantsearch.js, videojs-vtt.js, ua-parser-js, autocomplete.js, chart.js, mescroll.js, mux.js and I can think of quite a few off the top of my head too.

I see, I didn't think a reindex was the right solution here, as that takes a really long time, but I wonder if some combination of popular / popularName and alternativeNames could be used 🤔 We indeed still want to rank those "obvious" packages right ahead of a very similar one without the .js (that could be second position)

Yes, I'd be ok if you always got the exact match first and then the other version second, even if the second was the better one, but this change makes it a lot worse for the case where .js is the correct one, particularly when the name also makes sense as a keyword, e.g.:

Indeed, I mixed up the naming. Still, does that mean we'll need a reindex?

I can’t think of a solution without reindex for now


[SPARK-22700][ML] Bucketizer.transform incorrectly drops row containing NaN

What changes were proposed in this pull request?
only drops the rows containing NaN in the input columns
How was this patch tested?
existing tests and added tests

Test build #84481 has started for PR 19894 at commit 01604c7.

Test build #84481 has finished for PR 19894 at commit 01604c7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84481/
Test FAILed.

Test build #84485 has started for PR 19894 at commit eaebedb.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84485/
Test PASSed.

ping @MLnick ?

LGTM. Good fix.

LGTM thanks! Merged to master

I'm going to backport this to 2.2 since it's a correctness bug.


Discussion: Unable to link with react native push notification

I was trying to import push notification library for my project.
I first run react-native link react-native-push-notification after installing the package from npm, there wasn't any message shown. Followed by running the command, react-native link. Screenshot below is the error message - Cannot read property 'pbxprojPath' that I encountered.

So I referred to the solution provided in React Native issues page.Then I run react-native upgrade and here it gives me another error message.

Here is my react-native version.

I have solved this by doing it in real device but not expo emulator.


Collection expressions should be supported

Input:
public sealed class Fruit
{
    public List<string> Colors { get; init; } = [];
}

Expected behavior:
This should work, but using collection expressions breaks CSharpier. The file will not be formatted.

Are you on an older version? Collection expressions support was added in at least 0.26, possibly somewhat supported before that.

Oh... I was updating my global install, but not the project-level install 🤦♂. Working now, thanks!

Oh... I was updating my global install, but not the project-level install 🤦♂. Working now, thanks!

No problem! My co-worker ran into something related last week, apparently dotnet-csharpier will run the global install and dotnet csharpier will run the local install, and those versions were mismatched on his system.


Env vars to change the custom config file name.

fixes #102

This is amazing and brings a tear to my eye. Nice work!

Looking at it now, I kind of feel the env names are not consistent and verbose.
How about changing then like:
APP_NGINX_ADDITIONAL_CONF -> NGINX_CONF_INCLUDE
APP_NGINX_CONF -> NGINX_CONF_OVERRIDE
APP_PHP_FPM_CONF -> PHP_FPM_CONF_OVERRIDE
APP_PHP_INI -> PHP_INI_OVERRIDE
APP_SUPERVISORD_CONF -> SUPERVISORD_CONF_ADDITION
?

That way, the envvar represents what they are.
For example, in the future it's easy to add SUPERVISORD_CONF_OVERRIDE which is a complete replacement of the main supervisord config.

Ahh, I think I like this. But what's the difference between ADDITION and INCLUDE here?
On another note, I actually need the supervisord override and not the addition.
On another another note, the PATH declaration does not seem to be picking up ${PHP_DIR}/bin, and I'm not sure why, as it's clearly defined here

Ahh, I think I like this. But what's the difference between ADDITION and INCLUDE here?
INCLUDE is included into the main config file
ADDITION is a file that will be read additionally to the main config file

On another note, I actually need the supervisord override and not the addition.
Little bit questionable to support that case with this image (user can easily hit their feet).

On another another note, the PATH declaration does not seem to be picking up ${PHP_DIR}/bin, and I'm not sure why, as it's clearly defined here

Probably it's because it's reset by bash (/etc/profile)?

I think it would be best to just keep it simple and have the supervisord be an override. Unless there's another way to not run php-fpm.

You can configure php-fpm to run only small amount of instances, or zero.

If you're referring to process.max, a value of zero denotes an unlimited amount.

pm = ondemand
then there will be no processes until they are needed

I doubt that will stop nginx from listening on port 8080

In most cases, use nginx for health check

OK, LGTM! I think this will work.

Do we want the copying/moving of these files to happen in entrypoint.sh? It seems like this would be better off in the docker image. I assume this has to be done in entrypoint.sh because of the environment variables.

AFAIK, this is the only way right now, but I'm open to other optoins.

We chatted offline. Maybe we can introduce SUPERVISORD_CONF_OVERRIDE.

FYI, this change is released on gcr.io/php-mvm-a/php-nginx as well as gcr.io/google_appengine/php with a release tag r20160606.

This change breaks custom module requirements for composer installations which are run way before entrypoint is ever executed.
I suggest to add the app dir back to conf-scan. Otherwise we raise an additional hurdle requiring the user to COPY the custom ini to the scan dir through the dockerfile (which would make this change superfluous.

I figured I'd illustrate this a bit:

composer.json has a platform requirement on ext-gd
image is built and there is NO way to add the gd module to any of the inis, because the first composer execution is an ONBUILD one where only the inis from the initial image build are present
build fails since composer install fails

Correction: There is no way to ever add modules at the needed point in time. I proposed #109 to re-add the ini scan.

Sorry for the breakage. Merged and building the image for upload.

No worries - thanks for the quick merges!


Cannot open 0-conf channel on testnet3

Hi. Is the guide still valid for LND 0.18.3? Getting same errors with bos and lncli:
$ bos open 027d5678e06b2c7f322464a6e18eeec7dfa6e4c90584d9794e5b9c6c850d9c14a3 \
--type private-trusted  \
--avoid-broadcast  \
--set-fee-rate 1 \
--amount 10000000

opening_to:
  - 027d5678e06b2c7f322464a6e18eeec7dfa6e4c90584d9794e5b9c6c850d9c14a3: 0.10000000

err:
  - 503
  - UnexpectedErrorOpeningChannels
  -
    err:
      message: 2 UNKNOWN: remote canceled funding, possibly timed out: received funding error from 027d5678e06b2c7f322464a6e18eeec7dfa6e4c90584d9794e5b9c6c850d9c14a3: chan_id=941a6231dfc9097c87400adc2f0fa2b8e7f58fbaf8fa11d7361ae443bddc7c09, err=channel rejected

$ lncli openchannel --node_key 027d5678e06b2c7f322464a6e18eeec7dfa6e4c90584d9794e5b9c6c850d9c14a3 --zero_conf --local_amt 10000000 --channel_type "anchors"
[lncli] rpc error: code = Unknown desc = received funding error from 027d5678e06b2c7f322464a6e18eeec7dfa6e4c90584d9794e5b9c6c850d9c14a3: chan_id=b70951835a1ef71005e3f2f11270bd357a7e327eaf75ead941580d40cdd68035, err=channel rejected

Receiving node log:
2024-12-04 15:57:20.799 [INF] FNDG: Cancelling funding reservation for node_key=020ed4ea09c56c3e398190ae5ac60504fe4e56d6989d49e2f7845f14608c546854, chan_id=b70951835a1ef71005e3f2f11270bd357a7e327eaf75ead941580d40cdd68035
2024-12-04 15:57:20.799 [ERR] FNDG: unable to cancel reservation: no active reservations for peer(020ed4ea09c56c3e398190ae5ac60504fe4e56d6989d49e2f7845f14608c546854)

Blixt Wallet has a built-in channel acceptor. If you want to run this setup on two nodes, one has to run this acceptor on its own. For example with bos like: bos inbound-channel-rules --trust-funding-from PUBKEY

Yes, this works. Maybe add it to the guide so I don't forget next time?

Maybe, although I think the use case for zero conf non-broadcasted channel is mobile wallets connecting to personal routing node.

it has a good use case now on testnet3 for not wasting sats on channels


Add support for blob upload

Fixes #29502
Our endpoint is not Github compatible.
https://docs.github.com/en/rest/releases/assets?apiVersion=2022-11-28#upload-a-release-asset

Ready for review after adding a test.


Checking for unsafe function overloads

(This attempts to provide a solution for a more general version of #13223. I wanted to separate the two issues as the title of #13223 doesn't successfully describe the more general case addressed here)
This is still somewhat of a work in progress, I still need to validate this correctly addresses all scenarios, including all cases where there are there multiple overloaded parameters.
Consider this function:
function example(s: "Hello"): number;
function example(s: string): boolean;
function example(s: string): number | boolean {
	if (s === "Hello")
		return 54;
	else if (typeof s === "string")
		return true;
	else
		throw new TypeError("The given argument is not a string");
}

Superficially, it may seem like this function signature successfully describes and enforces the relationship between the parameter types and return types of the function at runtime. However, maybe surprisingly, it turns out this isn't really the case in practice:
Consider this secondary function:
function example2(a: string) {
	return example(a);
}

Now let's call the secondary function:
let result = example2("Hello");

The inferred type of result is boolean, however its actual value at runtime is 54, which is not of type boolean.
Why did this happen? Why did the compiler get it wrong?
Because Typescript uses erasable types, it cannot positively determine if a should be bound to the literal type "Hello" during design time. Relying on type annotations alone the compiler cannot disambiguate between the particular string "Hello" and any other string.
Proposal
Add a compiler switch such as --noUnsafeFunctionOverloads that would disallow function overloads that satisfy the following three conditions:

One parameter overload type is a supertype of a second one.
At least one of the parameters or the return type of the more general overload is not a supertype of the corresponding parameter or return type of the more specific overload.
The more specific overload is positioned before the more general one (edit: it seems like currently the compiler doesn't care about ordering in this case, so maybe this requirement isn't really necessary).

For illustration here's a different example where enabling the option would not cause a compilation error:
function example(s: "Hello"): 54;
function example(s: string): number;
function example(s: string): number {
	if (s === "Hello")
		return 54;
	else if (typeof s === "string")
		return Math.random();
	else
		throw new TypeError("The given argument is not a string");
}

Since number is a supertype of 54, the function would still yield a valid return type (number) even if the argument passed to s is annotated as string but has the value "Hello" at runtime.
However, this example would fail type-checking, as the second parameter in the second overload is not a supertype of the second parameter in the first overload:
function example(a: "Hello", b: boolean): boolean;
function example(a: string, b: number): boolean;
function example(a: string, b: boolean | number): boolean{
	if (a === "Hello") {
		callSomeFunctionThatExpectsBoolean(b);
		return true;
	} else if (typeof a === "string") {
		callSomeFunctionThatExpectsNumber(b);
		return false;
	}
	else
		throw new TypeError("The first argument must be a string");
}

Another alternative is to implicitly convert the more general parameter type to a subtraction type that excludes the more specific parameter type(s), so the implicit signature would be changed to:
function example(s: "Hello"): number;
function example(s: string - "Hello"): boolean;
function example(s: string): number | boolean {
	if (s === "Hello")
		return 54;
	else if (typeof s === "string")
		return true;
	else
		throw new TypeError("The given argument is not a string");
}

Now a caller must prove to the compiler that the argument doesn't match the literal type "Hello" before it is passed to the function. The resulting code may be a bit "strange" looking though:
function example2(a: string) {
	if (a === "Hello")
		return example(a); // `a` is narrowed to "Hello"
        else
		return example(a); // `a` is narrowed to the subtraction type `string - "Hello"`
}

I don't believe this solution is practical, though, because some types may be very difficult or computationally expensive to guard on (think about arrays of complex objects etc.).
This solution is also possible to do manually even with the suggested compiler flag enabled, so I maybe that could be one of the recommended methods to achieve the desired effect without risking type inference "disasters".

Another alternative is to implicitly convert the more general parameter type to a subtraction type that excludes the more specific parameter type(s), so the implicit signature would be changed to:
function example(s: "Hello"): number;
function example(s: string - "Hello"): boolean;
function example(s: string): number | boolean {
	if (s === "Hello")
		return 54;
	else if (typeof s === "string")
		return true;
	else
		throw new TypeError("The given argument is not a string");
}

Now a caller must prove to the compiler that the argument doesn't match the literal type "Hello" before it is passed to the function. The resulting code may be a bit "strange" looking though:
function example2(a: string) {
	if (a === "Hello")
		return example(a); // `a` is narrowed to "Hello"
        else
		return example(a); // `a` is narrowed to the subtraction type `string - "Hello"`
}

I don't believe this solution is practical, though, because some types may be very difficult or computationally expensive to guard on (think about arrays of complex objects etc.).
This solution is also possible to do manually even with the suggested compiler flag enabled, so I maybe that could be one of the recommended methods to achieve the desired effect without risking type inference "disasters".

There doesn't seem to be much evidence that people are regularly making mistakes here in a way that we could reliably detect without introducing false positives. But the real problem is that any implementation here is going to be at least O(n^2) on the number of signatures, and there are many .d.ts files which have literally dozens of signatures per function. The cost and complexity of checking for "correctness" in overloads every time when the errors are so rare to begin with doesn't seem worth it.

@RyanCavanaugh
Hi, I think as a general advice I would suggest to the TypeScript team to never disregard issues that directly undermine the effectiveness of having a type checker in the first. This is not even an issue about "soundness", it is a case where the compiler would "deliberately" infer an incorrect type that in practice only serve to confuse the user and there is nothing they can do about it (consider the typing may be received from a declaration file they don't feel confident enough to change).
The proposal was to have this under an option. Whoever would enable that option should accept the performance implications of using it. It's a conscious choice.
If I were designing a language, I would personally never feel I need to "wait" until I have "evidence" until I need to address some case where my compiler was deliberately inferring a wrong type. I would immediately correct the problem. Compilers should be seen as "theorem provers", not "recommendation engines". I'm sorry but I don't find the way this was handled reasonable, considering the potential magnitude of the problem. I think you should leave these types of issues open, until, say, it might be considered for TypeScript 4.0 or something like that, along with other similar cases.

Thanks for the feedback on this point. We have an overall complexity "budget" and need to spend that budget wisely. Things which produce minimal gains to produce gains, but the question is whether or not the complexity invested to produce those gains pays for itself more than some other activity would. It's easy to think of things in terms of pure cost, but with a finite amount of complexity humans can handle, we have to think about them in terms of opportunity cost -- even under a flag, we have extra code to deal with, slightly less performance (it really does all add up), and yet one more question to ask ourselves ("How would X feature work under flags Y, Z, and Q?)" when considering new features.
Regarding leaving issues open, the "closed" bit is just a color on a webpage and should be treated as such. You can feel however you want about it, but we require the ability to make decisions and indicate the results of those decisions. The decision here is "We're not doing this anytime soon". We've communicated that decision by closing the issue. This doesn't mean you can't comment here, or point out areas where the feature would deliver more value than we thought it would, or engage in other ways. The decision has been made for now not to do this and it'd be a disservice to anyone coming across the issue to think that it was on the table for the near future.


Small code font improvement for Windows users

"Courier New" looks weird on Windows, Consolas is definitely more natural

Any chance to share a screenshot? The diff. I don't own a PC 😭

Courier New

Consolas

PS examples from here https://react-hook-form.com/advanced-usage#ControlledmixedwithUncontrolledComponents

Oh wow thank you!


Ambient theme

https://www.freesound.org/people/suonho/sounds/3158/

Code library.. Super easy. :)
The Snack Sound Toolkit can play wav, au and mp3 files.
s = Sound()
s.read('sound.wav')
s.play()
http://www.speech.kth.se/snack/


Windows Version

Hello,
Is there a way to run this utility on Windows? It will be great to have this for windows too.

Yes, run the tool on Windows platform.
Thank you, I missed completely the downloads.
You should update the README to point in that direction for windows users.
Thanks again.


Install version 3.2 from mongodb.org repo

Hi!
This PR allows to install latest stable MongoDB version 3.2.

updated repo file
updated mongod.conf.j2 template
explicitly set that RHEL/CentOS distro family is supported

Tested on Ambari <IP_ADDRESS>.
Thank you!

@vutny : Thank you for your contribution.


Great! your Token. i want change Expires

i want change this in option. please.
public Func Expires = () => DateTime.UtcNow.AddMinutes(15);

Hi @touchduck
You can do this overriding this Func in the middleware configuration:
.UseJwtSimpleServer(options =>
                {
                    options.IssuerSigningKey = "yoursigninkey";
                    options.Expires = () => DateTime.UtcNow.AddMinutes(60);
                });

Regards!

Yeah @touchduck. That public Func is the default time given by the library. You can override with your own time :)

wow, great! i can do it. 👍


Fix/handle take in batch updates

Hello,
The goal of this PR is to sanitize TOP statements that appear when using Take() in the query. This is to avoid copying over the the 'TOP' clause during the selection of the 'value part' of the commandSql.
Note: this is already in place in the EF5 and EF6 code paths, I simply copied this over to EFCORE.

Hello @nascimentod ,
Just to let you know that the latest version now contains your pull.
Thank again for letting us know.
Best Regards,
Jon


[suggestion/idea]: would it be better to base not on stdenv but on one that is based on llvm/clang?

@paveloom
Great to see this in nixpkgs!
I just wanted to test-drive codon and noticed the derivation is based on stdenv, which AFAIK depends on gcc etc, which is arguably not needed. If this derivation would instead be based on llvm/clang it would probably not only avoid unnecessary deps but at the same time avoid hard-coded/manual setting of DCMAKE_... (not 100% sure though)?
I'm doing something similar for a mkShell here which could probably work the same for mkDerivation?

Hello there!
I am using LLVM's stdenv, as can be seen here:
https://github.com/NixOS/nixpkgs/blob/805ff35106cde011000c1ea0be3c9f94054b6ef8/pkgs/top-level/all-packages.nix#L14513-L14515
You're probably right that the DCMAKE flags for the compiler aren't necessary, though.

@paveloom Ah, of course, thanks for the enlightenment!
It's actually best like that as I now understand, because it allows for custom overrides on the package level which otherwise wouldn't work...
Also I noticed that they use a heavily patched llvm anyway, so significant parts of the llvm sdenv can't be used anyway.
Cheers, closing...
/close


MS Power Platform with GitHub

Hi there!
From this article (https://docs.microsoft.com/en-us/azure/architecture/solution-ideas/articles/azure-devops-continuous-integration-for-power-platform), it seems MS is promoting managing MS Power apps lifecycle using Azure DevOps (Azure git repo, azure pipelines, etc.) Could you clarify or elaborate the position of Power Apps lifecycle with GitHub as well?
From organization point of view, we are trying to simplify our development lifecycle tools portfolio (including both no/low code and code environment) to be more efficient. It is difficult to govern and support multiple ALMs at the enterprise level, and not to mention that users need to jump between the systems and manage integration or transformation.
thanks!
Lu Wang

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4968f751-e9d6-6a37-c650-908531992510
Version Independent ID: f9bf0889-546c-eb18-cfa5-72b42fae1fea
Content: CI/CD for Microsoft Power Platform - Azure Solution Ideas
Content Source: docs/solution-ideas/articles/azure-devops-continuous-integration-for-power-platform.yml
Service: architecture-center
Sub-service: solution-idea
GitHub Login: @sarahparkes
Microsoft Alias: meparkes

@luwangshell Thanks for the feedback! We are currently investigating and will update you shortly.

Hi @luwangshell
Sorry for the delay.
The document is a solution idea, and is not intended to cover all scenarios.
You could use GitHub actions and GitHub repository
I will close the ticket, but feel free to open a new one if you still have concerns.
#please-close


HeaderMap error: Undefined Behavior: trying to retag from _  for Unique permission

In https://github.com/hyperium/hyper/pull/3375 we ran into the following error:
error: Undefined Behavior: trying to retag from <1400070> for Unique permission at alloc405811[0x28], but that tag only grants SharedReadOnly permission for this location
    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/http-0.2.10/src/header/map.rs:2111:35
     |
2111 |         let entry = unsafe { &mut (*self.map).entries[self.entry] };
     |                                   ^^^^^^^^^^^^^^^^^^^
     |                                   |
     |                                   trying to retag from <1400070> for Unique permission at alloc405811[0x28], but that tag only grants SharedReadOnly permission for this location
     |                                   this error occurs as part of retag at alloc405811[0x28..0x40]
     |
     = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental
     = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information
help: <1400070> was created by a SharedReadOnly retag at offsets [0x0..0x60]
    --> src/proto/h1/role.rs:1524:26
     |

It was observed that this error is not occurring in v0.2.9.
I reproduced the error with this test in test/header_map.rs:
#[test]
fn repro_retag_error() {
    let mut headers = HeaderMap::new();
    headers.insert(
        HeaderName::from_static("chunky-trailer"),
        HeaderValue::from_static("header data"),
    );

    let _foo = &headers.iter().next();
}

I did a git bisect and identified the error:
$ git bisect start
$ git bisect good v0.2.9
$ git bisect bad v0.2.10
$ git bisect run sh -c 'RUSTFLAGS=-Adropping_copy_types MIRIFLAGS="-Zmiri-disable-isolation" cargo +nightly miri test chunked_with_title_case_headers'

...

78e3d37563b0fe83886abffdcd8569117d45fee9 is the first bad commit
commit 78e3d37563b0fe83886abffdcd8569117d45fee9
Author: Discord9<EMAIL_ADDRESS>Date:   Thu Jul 13 18:29:29 2023 +0800

    make miri happy

 src/header/map.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
bisect found first bad commit

The above change was introduced in https://github.com/hyperium/http/pull/616
Note: I had to specifyRUSTFLAGS=-Adropping_copy_types to avoid the following errors when building v0.2.9 on rustc 1.75.0-nightly (75b064d26 2023-11-01):
error: calls to `std::mem::drop` with a value that implements `Copy` does nothing
    --> src/header/map.rs:1155:17
     |
1155 |                 drop(danger); // Make lint happy
     |                 ^^^^^------^
     |                      |
     |                      argument has type `bool`
     |
     = note: use `let _ = ...` to ignore the expression or result
note: the lint level is defined here
    --> src/lib.rs:161:9
     |
161  | #![deny(warnings, missing_docs, missing_debug_implementations)]
     |         ^^^^^^^^
     = note: `#[deny(dropping_copy_types)]` implied by `#[deny(warnings)]`

error: calls to `std::mem::drop` with a value that implements `Copy` does nothing
    --> src/header/map.rs:1258:17
     |
1258 |                 drop(danger);
     |                 ^^^^^------^
     |                      |
     |                      argument has type `bool`
     |
     = note: use `let _ = ...` to ignore the expression or result

error: could not compile `http` (lib) due to 2 previous errors

Weird. So a revert is good enough?

I believe so. Playing with this more, miri added some additional information:
help: <122902> was created by a SharedReadOnly retag at offsets [0x0..0x60]
    --> /Code/http/src/header/map.rs:815:22
     |
815  |                 map: self as *const _ as *mut _,
     |                      ^^^^

Which is here:
https://github.com/hyperium/http/blob/f5f31f0651774a5d68f2d5051b70e0bd0ccae577/src/header/map.rs#L815
I think the issue with 78e3d37563b0fe83886abffdcd8569117d45fee9 is:

HeaderMap::iter converts &HeaderMap<T> to *mut HeaderMap<T>
IterMut::next_unsafe uses that *mut HeaderMap<T> to pull out a&mut Bucket<T>

Thus, we have a &mut from something that was originally & and that is undefined behavior.

Closes in #642


onRuntimeInitialized is never called

Hello Chris (@chafey),
Not sure if you can help me, because if I am not mistaken you have not yet published this package on npm.  But instead I have installed the @cornerstonejs/codec-charls which points to your repository...
But hopefully you can still see what I am doing wrong.
When I do this:
const charlsJs = require('@cornerstonejs/codec-charls');
charlsJs.onRuntimeInitialized = async _ => {
   // My custom code
}

Then the onRuntimeInitialized is never called :-(
P.S. I am using NodeJs version v12.19.0.
Thanks in advance !!!
Bart Butenaers

Ok, seemed that the require statements returns a function, so I had to add () to call it:
const charlsJs = require('@cornerstonejs/codec-charls')();

So that is solved.
But stuck again...  When I call this:
decoder.decode();

Then I get the exception that I should pass 0 arguments to this function, instead of 0 arguments.  So not sure what that is about.  That exception is raised here:

Thanks!

Hi Bart - I don’t know off the top of my head, did you try out the node example in this repo:
https://github.com/chafey/charls-js/blob/master/test/node/index.js

Hey Chris,
Thanks for your fast response!
Yes indeed I used that example to start with this library:
// ' buffer' contains my jpeg encoded image
var decoder = new charlsJs.JpegLSDecoder();
var decoderBuffer = decoder.getEncodedBuffer(buffer.length);
decoderBuffer.set(buffer);
decoder.decode();

I have debugged this over and over and over again, but don't see what I am doing wrong.
The decode method expects zero parameters:

And I pass zero arguments,  I still i keep getting that error...
Moreover I am getting nuts: since arguments length is 0, how on earth can I arrive within the if(arguments.length !== 0) condition.  Don't see what is wrong...

Any update on this issue?  One possible cause of this is the node version you are using.  I just ran it on my mac using Node v16.3.0:
√ node (master) % npm run test

<EMAIL_ADDRESS>test
node index.js

Decode of ../fixtures/jls/CT1.JLS took 5.369811 ms
frameInfo =  { width: 512, height: 512, bitsPerSample: 16, componentCount: 1 }
decoded length =  524288
Decode of ../fixtures/jls/CT2.JLS took 5.340883 ms
frameInfo =  { width: 512, height: 512, bitsPerSample: 16, componentCount: 1 }
decoded length =  524288
Decode of ../../extern/charls/test/lena8b.jls took 6.267212000000001 ms
frameInfo =  { width: 512, height: 512, bitsPerSample: 8, componentCount: 1 }
decoded length =  262144
Encode of ../fixtures/raw/CT2.RAW took 6.631587000000001 ms
encoded length= 115504
√ node (master) % node --version
v16.13.0

Hi @chafey,
Sorry for the delay.  Long (unplanned) hours this week at work.
Yes indeed your test works fine here:

And the speed is quite impressive!!
So it won't be my older NodeJs version I assume.
But of course I tested your repo, which I downloaded via a git clone.
However I need an npm package (which I can use as a dependency), so I need to get it working via the '@cornerstonejs/codec-charls package.
I will need to do some more tests.  Will keep you updated.
If you have any other tips or things that I could try, don't hesitate to let me know.  All help is welcome!

I don't know what is different about the cornerstonejs/codec-charls package (it was based on this repo but I didn't create it) - did you try posting an issue there?  If you can't get it to working, you can always use git submodule to reference this repo

The weird thing is that the npm module shows links to your repository:

So I thought that your perhaps somehow were working together...
And I also assumed that he just published your repo, without any changes.
Because when I do this:
require.resolve('@cornerstonejs/codec-charls')

I get this result:
<EMAIL_ADDRESS>So it seemed to me that he used the same charlsjs.js file as in your example above.
But perhaps not...

That is weird - I am guessing just an error when they copied the code over.  I was certainly aware of the effort but did not work on it

Ok I have tried to narrow down the problem a bit more.

I download this example image (which I had choosen randomly last week) to a file.

I change your index.js test to load this file:
decode('C:\\temp\\Team_Queerala.jpg');

Then I run your example:
node --trace_uncaught C:\Users\Gebruiker\charls-js\test\node\index.js

Which shows the decoding exception (which is a number?):
5671952
Thrown at:
    at C:\Users\Gebruiker\charls-js\dist\charlsjs.js:1:1852
    at emit (events.js:314:20)
    at internal/process/execution.js:165:25

I don't see anything wrong with that jpeg image.  Hopefully it makes more sense to you...

This library is for decoding JPEG-LS images.  The image you linked is JPEG baseline (different).  What are you trying to do...?

Oh what a mistake then ;-(
To be honest, I have never thought about the fact that there are multiple types of jpegs...
I am a contributor for the open source Node-RED IOT dataflow framework.
Would like to create two nodes (as you can see in the screenshots in this discussion): one for decoding jpeg images from IP camera's, and another one for encoding jpeg images.
Pure javascript is too slow, and nativie libraries give a lot of build headaches on various platforms.  So wanted to try whether wasm was fast enough...

Apologies for the confusion, and for wasting your precious time!!!
I will close this issue and look for another library.
Thanks a lot and keep up the good work!!


Is sigmoid classifier suitable for multi-classification(num of categories > 1000 in LVIS) problems？

Since you are based on the sigmoid classifier, I am curious if your detection results on LVIS will have many false positives in the same location but with different categories. The reason why I ask this is that, I used to train one-stage detector on datasets similar with LVIS (which is long tailed logo dataset, with 352 categories), however, I get many FP with different categories at the same location. I'm wondering if you have encountered the same situation. Thanks!

And I think it may be due to the use of sigmoid classifier which consists of multiple independent binary classifiers. It may be not suitable for multi-classification(num of categories > 1000). Of course this is just my conjecture, any advice is welcome...

Hi @Icecream-blue-sky , thanks for your good question~
Actually, the false positive problem is not specific to the sigmoid loss. Since the NMS in the modern detection framework is class-related, objects of different categories at the same location will not suppress each other. This problem is also in the softmax loss, although there is strong competition between different categories in the loss design. What's more, there are indeed many categories that are semantically similar. like mirrors and rear mirrors, dresses and costumes... I presume your task has a similar problem, because different logos may do not look much different.
To conquer this problem, on the one hand, you could apply the class-agnostic NMS to your detection result during the inference phase to filter out some low confidence boxes. And on the other hand, adding a larger penalty term for false positives during training is also a good option.

Thanks for your kind advice! Now I think part of the reason is the imbalance of training data(long tailed) in each category, which makes it difficult for rare classifiers to classify accurately. Maybe adding EFL loss would help, what do you think?


Conditionally execute backlight module

I typically have a laptop connected to an external monitor and disable the laptop's display. When I do this the backlight module shows 0% as expected but it would be nice to have an option to disable displaying this module if the output is disabled. Maybe something like exec-if?
I don't know if this is something that has already been discussed, I couldn't find it easily. Hopefully this may be of interest to others too.

This is a nice idea, and should be generic to other modules :)

I've had a go at working on this in #394


Can't find _custom.scss file

I have installed bootstrap using the bower install however, I have failed to find the _custom.scss file.  I am using a mac latest OS. help is needed can you please help ?

you have to create this file on your own

@kooltechboy bower is no longer supported, use either  npm

Hi, i am a newbie here.. I created the file and then override the variables but it didn't make any change in my page.
What am i missing here ?
Help me out plz.


Astro is not detected

Platform
Which platform does the bug apply to?

WebExtension (Google Chrome)

Describe the bug
Technology is not detected by the browser extension.
To Reproduce
Steps to reproduce the behaviour:

Go to Astro website
Click on Wappalyzer button
Technology is not detected.

Expected behaviour
Technology is detected.
Additional context
Astro was introduced in v6.9.14 by #5504.
If I understand it correctly, the detection is implemented by the href attribute pattern.
I dare to recommend seconding it with the class attribute pattern as it was in the original new technology request.
astro-[\d\w]{8,}

Hey @sklar updated, thanks!!!


Is the pretrained mae encoder weights available ?

in config:
"mae_checkpoint": "mae_models/mae_pretrain_vit_large_full.pth"
in udop_dual:
self.vision_encoder = mae_model(config.mae_version, config.mae_checkpoint, config.image_size, config.vocab_size,
config.max_2d_position_embeddings)

But I found no  pretiraned weights for mae encoder. Is the pretrained mae encoder weights available  now?
Thank you!

The MAE checkpoint is together with the transformer weights included in the checkpoint.
if you want the original MAE weights you can download it from the original MAE codebase.

In the transformer weights, for mae, there are only weights for patch_embed and special_vis_token (and pos_embed), but not the blocks. And in the forward method, you indeed only use patch_embed to encode the patches.
Do you not use the full mae like in udop_dual? This simple projection carries all the information for font, line spacing, color etc etc?


Add optional statistics collection

You can now pass props if you want to collector starts, it's disabled by default.

Much better now. Merged


Display problem with hdmi

I have a raspberry pi 2
When I connect my pi to hdmi, it works fine until I start up emulationstation. When I do, I see the choose and nothing else. It becomes a problem because I cannot use the interface.
However, when I set the resolution to 800x600 it works fine, but only uses a small fraction of the screen.
What is going on?

Just edit the config.txt file, and comment the line
hdmi_drive=2
with a # :
#hdmi_drive=2
This works for me.


ci: fix shell bashisms issue

Signed-off-by: Julien Bouyoud<EMAIL_ADDRESS>

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

v1.1.0
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

v1.1.0
GitHub release

Your semantic-release bot :package::rocket:


[Performance]: Process affinity to CPU cores with multiple sockets support

Motivation

Setting process affinity to designated cpu ids, to avoid unwanted process migrations (cost high in case of multiple sockets)
Modifications
Assign specific process to designated cores, handle multiple sockets, and HT (hyper threading: 1 Physical core runs as 2 logical cores)
Online benchmarking shows notable improvement (request rate: 4/8/16) on MI300X system with dual socket CPUs.

Checklist

[+] Format your code according to the Contributor Guide.
[+] Add unit tests as outlined in the Contributor Guide.
[+] Update documentation as needed, including docstrings or example tutorials.

We have multiple threads, not sure whether we need to call them all. also call it here
https://github.com/sgl-project/sglang/blob/55842eb81a782da7e522ec0210c3fa1f3f74dc0a/python/sglang/srt/managers/tp_worker_overlap_thread.py#L90

We don't need to call this per thread, currently we look forward to binding at process level. :)


[BUG] "Boost ends in" attribute missing

With the heating starting to go back on in my house I noticed a bug since before the summer.
The attribute "Boost ends in" is no longer present for the boost entities:

As you can see I use a conditional card to show remaining boost time if a zone is boosted but now it reports "unknown".
Is it possible to get this attribure re-added or is there an otehr solution?

+1, I also have the same issue..really frustrating, the attribute is supposed to be part of the sensor.home_boost but it’s no longer there

Fixed in 2022.10.0
Thanks so much dev


Add MX record support.

Add support for MX records, by extending msg.Service, with a Mail boolean field. Add 2-line explanation to the README.

@bketelsen ack/nack or comments. Do you agree with the Mail boolean on msg.Service or do we need something better/else?

LGTM


Merge latest updates - [closed]

In GitLab by @wknet123 on Mar 15, 2018, 08:27
Merges dev-devops -> dev-devops

In GitLab by @wknet123 on Nov 13, 2019, 10:38
the API Server Coverage is  %   UI Coverage is 38.11%   check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:38
the API Server Coverage is  %   UI Coverage is 38.11%   check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:38
the it is failed check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:38
the it is failed check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:38
the API Server Coverage is  %   UI Coverage is 38.11%   check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:38
the it is failed check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:38
closed


Release version0.37.0 of sqlparser-rs

Follow on to https://github.com/sqlparser-rs/sqlparser-rs/issues/905
Filing a ticket here to track the work of a release (mostly so others can follow along)
Target Release Date: Approximately 2023-08-23
Release instructions: https://github.com/sqlparser-rs/sqlparser-rs/blob/main/docs/releasing.md
Steps:

[ ] Make a PR to update CHANGELOG.md
[ ] run cargo release
[ ] verify the new release is on crates.io
[ ] Make ticket for next release:

@alamb, would it be possible to have releases on git as well? I think the need to move to the CHANGELOG, instead of just going to the release, is a little contraintuitive.
Maybe just copying the changelog for that release. What do you think?

@alamb, would it be possible to have releases on git as well? I think the need to move to the CHANGELOG, instead of just going to the release, is a little contraintuitive.

Hi @AugustoFKL - what do you mean by "have releases on git as well" ?
Part of the current release process makes tags for each specific release, like:  https://github.com/sqlparser-rs/sqlparser-rs/releases/tag/v0.36.1 -- does that help your usecaes?

Checklist complete and new version is live on crates.io: https://crates.io/crates/sqlparser/0.37.0 ✅


TypeError: init() takes at least 2 arguments (1 given)

I have built the gunpowder image using docker first. When I try to run a sample, such as https://github.com/funkey/gunpowder/blob/master/examples/cremi/request_batch.py, I get a bug:
root@28d57bb6feec:/userhome/huangwei/mala/mala/cremi# python request_batch.py
DEBUG:gunpowder.array:Registering array key RAW
DEBUG:gunpowder.array:Registering array key GT_LABELS
DEBUG:gunpowder.array:Registering array key GT_LABELS_2
DEBUG:gunpowder.array:Registering array key GT_LABELS_4
DEBUG:gunpowder.array:Registering array key GT_IGNORE
DEBUG:gunpowder.array:Registering array key GT_AFFINITIES
DEBUG:gunpowder.array:Registering array key GT_BOUNDARY
DEBUG:gunpowder.array:Registering array key GT_BOUNDARY_GRADIENT
DEBUG:gunpowder.array:Registering array key GT_BOUNDARY_DISTANCE
DEBUG:gunpowder.array:Registering array key LOSS_SCALE
DEBUG:gunpowder.array:Registering array key ALPHA_MASK
Traceback (most recent call last):
File "request_batch.py", line 148, in
train()
File "request_batch.py", line 50, in train
for sample in ['sample_A_20160501.hdf','sample_B_20160501.hdf','sample_C_20160501.hdf']
File "request_batch.py", line 50, in
for sample in ['sample_A_20160501.hdf','sample_B_20160501.hdf','sample_C_20160501.hdf']
TypeError: init() takes at least 2 arguments (1 given)
I don't understand it and don't know how to deal with it.
I guess it could go wrong in Normalize() function or RandomLocation() function.
I'd like you to tell me the some solution. Thank you very much.

My guess is that your docker container contains a more recent version of gunpowder than what the example was written for. Please have a look at the example in the current release-v1.0 development branch.

This example is outdated by now. We wrote new tutorials, one of them showing how to set up a simple pipeline step-by-step. I hope you will find it useful.


you cant /give to spectators

while on spectators, if someone does /give on you, you get nothing.
it would make sense if spectators had fixed inventory, but that's not the case, spectators can modify their inventory as they wish (grabbing blocks from the creative menu) but the cannont get them via / give

/give is an OP command

@CaptainElliott The error is command.give.notFound in red, not a permissions issue.

I don't understand, could you show a screenshot?

@CaptainElliott My apologies, just realised that this only happens due to 1.8 id compatibility. This error is given iff the numerical ID is given as opposed to the minecraft:<blockname> .
If a numerical ID is given, this error occurs:

As Mojang has depreciated support for item IDs in 1.8, this is not an actual issue (Just a usage error)
Good night!

Closing because @Pablete1234 didn't use the command correctly.

i did not use the command wrongly, just try:
/give Pablete1234 stone 1
and i get nothing if i'm on spectator, but if i have joined the game i do get the item

Works fine for me. What does it say in the chat when you do `/give Pablete1234 minecraft:stone 1?

it says given 1 stone to pablete1234, but i don't get the item

Can we see both a screenshot of /cardinal -v and what happens after using the command?

i'll do it when i go back home later

hang on, your using a 1.7 port on your server right?
https://oc.tc/forums/posts/552571eb5f35b9737b0027cf

nope, i'm testing on 1.8

maybe when i tested this (original post) it wasnt fixed yet and maybe it is now (for 1.8 version), i'll test it when i get home

tested it and seems to be fine now (even on the 1.7 port), maybe it was broken when i first tested in a older version

i found what the problem is, and this needs to be reopened.
the bukkit give command (/bukkit:give) does work fine
mojang give command(/minecraft:give) does not work
for whatever the reason is, minecraft give is not working, and i do prefer using minecraft give because you can set nbt tags.

Why do you need to give items? Is the issue with Cardinal or SportBukkit?

when i have joined a team i can /give perfectly fine, it's just while on observers, it says "[item] given to [player]" but you actually don't get the item

Very strange. When coding Cardinal modules from a separate plugin, I had similar results. I tried to give an item to the player, but it was usually a ghost item and disappeared when I clicked on it.

I think this is not fixed and should be reopened, or should i create a new issue being more specific on "minecraft:give" and not /give by itself?

I assume in order to reproduce it:

The command executor, "Giver", has to be in observers, and is an Operator on the server.
The receiver, "Recipient", has to be in observers. There is no difference between permission levels.
There is no need for the match to be running.
If the Giver executes /minecraft:give <player> <item> [count] [data] [dataTag] with all valid tags, the Recipient does not receive the item.

In my testing,
using /minecraft:give SungMatt minecraft:potion 1 16421 {CustomPotionEffects:[1:{Id:6,Amplifier:6,Duration:6}]} , with the Giver being "SungMatt" and the Recipient being "SungMatt"
The Recipient is able to receive the proper item (Splash Potion of Healing, with a custom effect of "Instant Health potion.potency.6"), with its data tags.
Do tell us what command you are using, and the full method and prerequisites to reproduce this bug.
Tested in CardinalPGM version 18a0ea8

join my server, whine on observers:
/give [your name] stone
nothing happens
on commands.yml i have an alias for "give (any arguments)" ->minecraft:give (any arguments)
ps: while playing (joining a team different than observers) works fine

@Pablete1234 Hmm, I'm unable to recreate the issue. Video

This isn't fixed :v

i thought it was fixed but ok

@TiTo-418 @Pablete1234 Could you please verify if the bug is still a bug, or it is just incorrect usage? I am unable to recreate this bug, as I have said in the comment I made 2 months ago. Giving us a video would help, as none of us seem to be able to recreate this. Thanks.

Also, make sure this isn't an issue of "ghost items".

Sorry, it is fixed now, my bad

when the issue was first created was not incorrect usage, the command gave back "ok message", so it   was not the command being wrongly executed.
i still think it maybe was related to inventory not  updating properly (ghost items), but it was also alot of times just items not appearing after /give.
i think it's fixed by now, closing again,


MQTT

Hi,
Thanks again for a nice program.
I've run into an issue combining the wifi-manager with MQTT. If I use a the MQTT app (task) separately (stand alone) it is able to publish messages okay to a remote host.  However, if I use MQTT app (task) with wifi-manager, the MQTT app is not able to connect to the remote host to publish messages.  I've gone through the wifi-manager code, and tested different options.  So far I've not found a solution to why the MQTT app will not work along aside the wifi-manager.
I have been able to use the wifi-manager to select an access point and store the access point credentials to NVM.  Then on a reboot, I check to see if there are access points credential in the NVM, If there are, I used those credentials to attached to the access point and start the MQTT app.  I don't start the wifi-manager up in this case.  This configuration works okay.
  Do you have any recommendations on combining wifi-manager with MQTT?
Thanks,
Robert

Robert,
I suggest you try something that needs to resolve a hostname without using
MQTT and see if that works. I have issues resolving DNS when the ESP32 is
in AP or AP/ST mode.
This may not have anything to do with the wifi manager code and more to do
with DNS resolution on the ESP32.
Just a thought.
On Mar 15, 2018 12:46 AM, "reshuler"<EMAIL_ADDRESS>wrote:

Hi,
Thanks again for a nice program.
I've run into an issue combining the wifi-manager with MQTT. If I use a
the MQTT app (task) separately (stand alone) it is able to publish messages
okay to a remote host. However, if I use MQTT app (task) with wifi-manager,
the MQTT app is not able to connect to the remote host to publish messages.
I've gone through the wifi-manager code, and tested different options. So
far I've not found a solution to why the MQTT app will not work along aside
the wifi-manager.
I have been able to use the wifi-manager to select an access point and
store the access point credentials to NVM. Then on a reboot, I check to see
if there are access points credential in the NVM, If there are, I used
those credentials to attached to the access point and start the MQTT app. I
don't start the wifi-manager up in this case. This configuration works okay.
 Do you have any recommendations on combining
wifi-manager with MQTT?
Thanks,
Robert
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tonyp7/esp32-wifi-manager/issues/6, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAPNARcwkYV8vX7PyJHwzGIsy6LE-Az8ks5teg46gaJpZM4Srog1
.

Got it. Good suggestion.  I’ll let you know what I’m able to do.
I seen issues around DNS before with the ESP32.
Thanks,
Robert

Hi Robert,
Could you care to share your code? I'm not sure I could see where the wifi manager could interact with MQTT!
Thanks

Any feedback about this problem ? I have a project and I got an error when implemting MQTT with wifi manager. It is E (21301) MQTT_CLIENT: Error transport connect

Hi @reshuler were able to resolve it ? Please let me know. I am also having same issue.

I modified this project and ble2mqtt to be ESP-components and use them together to relay data to MQTT broker. You can check the code and submodules out [here] (https://github.com/ojousima/ojousima.esp32_blegw.c) if you're interested, I've not had problems with MQTT.

Hi @ojousima  I tried with your code but still mqtt fails with same error. I tried with different networks and also local mqtt broker I had tried but no luck


Neovim does not refresh UI after iTerm go to fullscreen

@lvht open this issue in neovim team

Open iTerm, and start NeoVim. Then, maxmize iTerm, but NeoVim didn't redraw the tui.

My NeoVim's version is 0.1.1 under Mac OS X EI.

My os is ubuntu ,also get the same issue.
https://github.com/neovim/neovim/issues/3929

I've seen this as well, though this could be a neovim issue.
https://github.com/neovim/neovim/issues/3929#issuecomment-169018201
Closing for now until it get's resolved on neovim side.


Test Herkulex observation getter

It seems that the method to receive observation does not properly work. Need more testing.

Servomotors id were not correctly assigned on robot. Fixed!


Module 1.1 Assignment

Given what you have learned about Git, why would you want to use Git in your classroom?

For practical reasons


PostgreSQL: character varying instead of varchar(n)

I use ent to implement my small project and I have pretty small entity defined as follows:
type Merchant struct {
	ent.Schema
}

func (Merchant) Fields() []ent.Field {
	return []ent.Field{
		field.UUID("id", uuid.UUID{}).Default(uuid.New),
		field.String("name").MaxLen(128).NotEmpty(),
		field.Text("description").Nillable(),
		field.String("primary_email").MaxLen(254).NotEmpty(),
		field.String("secondary_email").MaxLen(254).Nillable(),
		field.String("primary_number").MaxLen(16).NotEmpty(),
		field.String("secondary_number").MaxLen(16).Nillable(),
		field.UUID("tenant", uuid.UUID{}).Immutable().Unique(),
		field.Bool("active").Default(true),
	}
}

func (Merchant) Edges() []ent.Edge {
	return nil
}

Next step is to generate migration file from this definition, so I run command:
- go run -mod=mod ariga.io/atlas/cmd/atlas migrate diff initial --dir "file://migrations" --to "ent://internal/ent/schema" --dev-url "docker://postgres/latest/migrations?search_path=public"

So I get the following output in migration file:
-- Create "merchants" table
CREATE TABLE "merchants" ("id" uuid NOT NULL, "name" character varying NOT NULL, "description" text NOT NULL, "primary_email" character varying NOT NULL, "secondary_email" character varying NOT NULL, "primary_number" character varying NOT NULL, "secondary_number" character varying NOT NULL, "tenant" uuid NOT NULL, "active" boolean NOT NULL DEFAULT true, PRIMARY KEY ("id"));
-- Create index "merchants_tenant_key" to table: "merchants"
CREATE UNIQUE INDEX "merchants_tenant_key" ON "merchants" ("tenant");

I want to point out on fields which were defined as field.String and have MaxLen validator. I see in migration file that it is defined as "character varying", but I assume since there is concrete number of characters limitation, it can be defined as character varying(n) or varchar(n).
As as workaround I can add SchemaType:
field.String("name").MaxLen(128).NotEmpty().SchemaType(map[string]string{dialect.Postgres: "varchar(128)"})

So, now it gonna be declared as character varying(128).
Can you, please, share some insights if such behavior of omitting varchar length has been done intentionally, so we must specify SchemaType explicitly or migration generation can be improved with length restriction?

Hey @umalmyha 👋
This behavior was intentional for the reason I mentioned in https://github.com/ent/ent/issues/2712#issuecomment-1173081735.:

The reason we didn't implement it in PostgreSQL is because it does not improve performance. See:

However, in case you really need it, we can add support for it in Atlas. The patch is really simple, so you're welcome to contribute it or one of the team can handle this. See

The SchemaType can be a workaround for this, but we continue the discussion on https://github.com/ent/ent/issues/2712 if you dislike the default behavior. Thanks 🙏


No database selected

Describe the bug
Hi I've just set up a brand new project using db init and dbt-mysql. I've setup my profiles.yaml and checked that dbt debug connects to my database properly and returns no errors.
When I run dbt run, I get the following error

How do I specify the database in dbt?

Still totally stuck on this, below is a copy of my profiles.yml
puddle:
  target: dev
  outputs:
    dev:
      type: mysql5
      server: localhost
      port: 3306  # optional
      database: puddle
      dbname: puddle
      schema: puddle
      username: test
      password: test
      driver: MySQL ODBC 8.0 ANSI Driver
    prod:
      type: mysql5
      server: [server/host]
      port: [port]  # optional
      database: [schema] # optional, should be same as schema
      schema: [schema]
      username: [username]
      password: [password]
      driver: MySQL ODBC 8.0 ANSI Driver

I've tried adding database/target_database to dbt_project.yml and schema.yml, and in the config of the model

@hugh-nguyen
You need to use ref() or source() inside your model:
For exemple in your case, you need to transform this query:
select *
from source_data

into something like:
select *
from {{ source('database', 'table') }}

When you will run this model, dbt will compile the model and the SQL output will be something like:
select *
from `database`.`table`

I also had the same problem. Eventually I realized that I was using a non-MySQL function inside my model. Once I changed that, it worked. I think the error message is misleading

https://stackoverflow.com/questions/74001834/dbt-1046-3d000-no-database-selected
Please see this solution! Maybe there should be some clarification for it.
@dbeatty


Added Connect Four Game

Description
Connect Four is a 6 * 7 grid-based two-player game. In this game, the player wins if he/she fills any four consecutive rows, columns, or diagonal cells.
Fixes #37
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@kiruba-r11 please also send a video or gif

https://user-images.githubusercontent.com/76843281/126035348-7bbc39d9-ef71-42ee-a8ee-03fa59b3a24f.mov

Great work @kiruba-r11

@arpit456jain u can merge it

@ankitapuri Thanks a lot!. This really motivates me.


Read from imported file ?

Q
A

Version
7.2.0

Question
The Reader's createFromPath function expects a filepath but if I am trying to read an imported file I do not have a path. Wondering how do I read from a imported file (input of type 'file') Do I use createFromString instead?
Checks before submitting

[x ] Be sure that there isn't already an issue about this. See: Issues list
[ x] Be sure that there isn't already a pull request about this. See: Pull requests
[ x] I have read, search and not found the information on the documentation website.
[ x] I have read, search and not found the information on PHP related forums and/or websites.
[x ] This issue is about 1 question around the package with no business or domain specific logic related to a specific situation.
[ x] The question has a descriptive title. For example:  "Can I use the library with compressed CSV documents ?".

@brandonbeschta thanks for using the library. What do you mean by import file can't you just use createFromString ?

I have a simple form that uses a input element with the type 'file' and would like to read it's contents. However on second thought yes I could just create a reader from the file contents. Thank you !


Update dependencies

Landed in https://github.com/metarhia/config/commit/faa8c2ca09c7eca8bc08a5625f3f8054b89533d3 and https://github.com/metarhia/config/commit/4871039d359a74aed0d7c2d72e873390ea4a26d6


Adds ToC and data section to README

Jackson, if this is roughly on the right track, I'd suggest you can add the versioning links later...just wanted to get a draft of this out there.

PTAL


Added nlog config file for important areas only and moved trace logs to debug level

@noescape00 ffs all in one commit? 😄

ffs all in one commit?

Yup. Replaced using regular expression.


Help!

When I do the installation of tailscale on openwrt, after getting to "opkg install libustream-openssl ca-bundle kmod-tun", I get the following message:
Multiple packages that provide the same name (libgcc1 and libgcc1) are marked as HOLD or PREFER. use the latest.
The package libustream-openssl20201210 (2022-01-16-868fd881-1), installed in the root directory, is up to date.
The package ca-bundle (20211016-1) installed in the root directory is up to date.
The package kmod-tun (5.15.46-1), installed in the root directory, is up to date.
Collected errors.

pkg_hash_check_unresolved: cannot find dependency kernel (= 5.10.131-1-cf749d8daf0bdc1e420cbc608ee57b33) for kmod-tun

Please, how should I fix it?
Thank you very much!

Looks to be an issue with OpenWRT, please check the FAQ
https://openwrt.org/faq/cannot_satisfy_dependencies


From where this combo data will be loaded. Please share the keyword for those master data.

Just checkout the Lookup data table for this.


match rule does not exist

I am trying to use the match rule to validate my http headers. I am using koa-validation 0.1.9, and node version 7.8.0
Here is how I used koa-validation in my code:
`this.app.use(function* (next) {
yield this.validateHeaders({
'content-type': { required: [], match: ['application/json'] },
accept:         { required: [], match: ['application/json'] },
});
  if (this.validationErrors) {
    this.status = 422;
    this.body = this.validationErrors;
  } else {
    this.status = 201;
    this.body = { created: true };
  }
});

`
However, when I send the following request, i got an error saying the match rule does not exist.
{ method: 'GET',   url: '/event/v1/ping',   header:     { 'cache-control': 'no-cache',      'postman-token': 'a64c568b-f549-4b85-901a-9f41502f5021',      'content-type': 'application/json',      accept: 'application/json',      'user-agent': 'PostmanRuntime/3.0.11-hotfix.2',      host: 'localhost:6080',      'accept-encoding': 'gzip, deflate',      connection: 'keep-alive' } }
I am wondering if I did something wrong or this is a bug. Thanks.

i could be wrong but it seems there is no match rule indeed, @srinivasiyer can you verify this? Thanks.


Problem to access the Public Health Insurance	Dataset

[Dataset]
Public Health Insurance dataset
[Question/Issue]
When using get_dataset("acspubcov"), I get a Pandas ParserError (see screenshot).
[Links to relevant documentation]
If applicable, provide links to any documentation you are following to access the data.
[Screenshots]

[Steps to reproduce]
Just try to get Public Health Insurance dataset with get_dataset("acspubcov").
[Steps to reproduce]
If applicable, describe steps to reproduce this issue.

Hi, I got the same problem. Has it settled? Could you please provide your solutions if it is settled, thank you very much!


update Changelog

Hey guys,
could you please update changelog regularly with every release. It's really a couple of minutes for you, but it's a huge deal for everyone who uses this package, because they don't need to scroll commit history in order to find out what changed.
Thanks

Could you please add a merge request to update it to the current state?
Then I will try to update it from now on.

@jantimon I can try, but since I'm not a regular contributor I'm not sure if I'll do it right

Cool I guess people would love you for it :+1:

@jantimon done. I hope I didn't miss anything


fix: Improve date and time picker

Changes in this PR
Calendar

There was a bug with the button for going backwards in months, I couldn't find a fix so I made it always visible now.
Fix for light theme. The disabled (past days) were not distinguishable from enabled (current and futures days). And I also added a not allowed cursor for disabled days.
The current day is now indicated by a primary ring
The The currently selected date in now pre-selected when you open the calendar

Before
After

Time

The time selector wasn't using the correct input so it was possible to enter invalid times. Fixed by using input with type time
The time input will now adjust to the browsers localization settings, f.e english is with AM PM and German is 24h
When clicking the clock icon it will open a dropdown with time sliders (great for mobile)
Time input is overall much easier

Before
After

How to test and review this PR?
Go to https://bafybeicfdfu7bzkoii6gbp564hudaptmhv334yxha4mnoiokad4vmaqfbu.on.fleek.co/#/fabien.eth/create/1

I think we should add cursor pointer to the clock icon and for values inside time picker, also text cursor for text in time

On my mobile, it looks like this:

Down arrow is close to the border


Fix Open Finding inconsistent Behaviour

Fix issue #1143
funny enough I only added a single word to fix this. as you can see in my commit.
If this is not what is expected do let me know.

I am really having issues understanding how git squash / rebase can help me in reducing commits showing in history.
would really appreciate any better explanation on how to do that properly.

you should submit PR in dev branch.

oh damn....
didn't see that...


Kibana Dashboard is not displayed on first time launch

Expected Behavior
Launching the Kibana dashboard should always display the dashboard
Actual Behavior
On first launch, it displays the discover / query page instead

Steps to Reproduce the Problem

Specifications

Version:
Platform:

problem is how redirect works from the content designer
content designer link to kibana:https://*****.us-east-1.es.amazonaws.com/_plugin/kibana/#/dashboard/Default?_g=()
url you are redirected to if you are not logged in already:https://.auth.us-east-1.amazoncognito.com/login?response_type=code&client_id=&redirect_uri=https://***.us-east-1.es.amazonaws.com/_plugin/kibana/app/kibana&state=7a050f95-ee5a-4532-a813-b179487d53ab&scope=openid+email
if you had to login you end up here:https://.us-east-1.es.amazonaws.com/_plugin/kibana/app/kibana?code=&state=***#/discover?_g=()&_a=(columns:!(_source),index:qna-dev-dev-master-39,interval:auto,query:'',sort:!(_score,desc))
if you did not have to log in you go here:https://**.us-east-1.es.amazonaws.com/_plugin/kibana/app/kibana#/dashboard/Default?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:now%2Fw,mode:quick,to:now%2Fw))&_a=(filters:!(),options:(darkTheme:!f),panels:!((col:9,id:Client-types,panelIndex:3,row:1,size_x:4,size_y:4,type:visualization),(col:1,id:Requests,panelIndex:4,row:1,size_x:8,size_y:4,type:visualization),(col:1,id:Incorrect-feedback-wordcloud,panelIndex:5,row:9,size_x:6,size_y:3,type:visualization),(col:7,id:Correct-feedback-wordcloud,panelIndex:6,row:9,size_x:6,size_y:3,type:visualization),(col:1,id:Logged-Utterances,panelIndex:7,row:5,size_x:12,size_y:4,type:visualization)),query:(query_string:(analyze_wildcard:!t,query:'')),title:Default,uiState:())
so problem is our link path get overriden if we have to login, we could make our own login url for kibana that has the correct redirect, but this would require the user to login/select-sign-in-as everytime they go to kibana.


When I ask a longer question, the output is arbitrary

What is the issue?
When I ask longer questions, it's about 15K or so. And I've set enough tokens: /set parameter num_ctx 4096. The model outputs a combination of numbers and symbols. Why?

What did you expect to see?
The model outputs normally
Steps to reproduce
ollama run qwen14:latest
Are there any recent changes that introduced the issue?
No response
OS
Linux
Architecture
x86
Platform
No response
Ollama version
0.1.27
GPU
Nvidia
GPU info
4090 * 2
CPU
No response
Other software
No response

me too

me too

我发现当我在命令行配置【/set parameter num_ctx 4096】 或者在api调用中添加num_ctx 参数时，都会报这个错误，不确定是用法不对，还是这个参数有问题。  不用这个参数就行了。我从结果看上去，即便是用默认值，好像也是没有做截断的(不确定)。


new argon2 release

Please vendor argon2 20161029 (1c4fc41f81f358283755eea88d4ecd05e43b7fd3). Have a look at the changelog to see what's new.

Will do before next release.  Currently waiting for virtualenv To be fixed for Python 3.6 and warnings.


BHBC-781: Database model updates

Overview
Links to jira tickets
Only a subset of https://quartech.atlassian.net/browse/BHBC-781
This PR contains the following changes
Add new migration to include the most recent db model changes from Charlie, relating to the project funding data.
Moved the contents of one of the seeds into the migration it was originally a part of. This aligns better with what seeding should be used for.

The seeds should only contain ephemeral information that is needed locally to make the app work and/or to pre-populate it with some test data so that it doesn't start up completely empty, and not core persistent data like code table values.

This PR contains the following types of changes

[x] New feature (change which adds functionality)
[ ] Enhancement (improvements to existing functionality)
[ ] Bug fix (change which fixes an issue)
[x] Misc cleanup / Refactoring / Documentation
[ ] Version change

Checklist
A list of items that are good to consider when making any changes.
Note: this list is not exhaustive, and not all items are always applicable.
General

[x] I have performed a self-review of my own code

Code

[ ] New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
[ ] I have avoided duplicating code when possible, moving re-usable pieces into functions
[ ] I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
[ ] My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
[ ] My code changes account for null/undefined values and handle errors appropriately
[ ] My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

[ ] My code follows the established style conventions
[ ] My code uses native material-ui components/icons/conventions when possible

Documentation

[ ] I have commented my code sufficiently, such that an unfamiliar developer could understand my code
[ ] I have added/updated README's and related documentation, as needed

Tests

[ ] I have added/updated unit tests for any code I've added/updated
[ ] I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

[ ] I have run the linter and fixed any issues, as needed
See the lint commands in package.json
[ ] I have run the formatter and fixed any issues, as needed
See the format commands in package.json

SonarCloud

[ ] I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

How Has This Been Tested?
Locally in docker.

As part of updating that past migration (to better align the usage of seeds), I will need to blow away dev before this gets merged (or after, but more convenient to do it first).  So if you review this and approve, don't merge it for me.


Change usage example for statically allocated heap

The linker needs to know how big the heap is, otherwise, it could place some of the global variables in the heap region.
This commit changes the example code to do that.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.
Please see the contribution instructions for more information.

cortex-m-rt's heap_start() is guaranteed to return a heap start address that's after all other allocated objects (after .bss, .data, and .uninit sections); you can see how that's done in the linker script. So, I don't think there's a possibility for the compiler to place some static objects in the heap region.
However, nothing prevents the user specifying a heap that's too large, whereas your example will ensure the heap space is statically allocated and known about by the linker, which I think is basically better in every way. Probably heap_start() in cortex-m could even be removed; I don't know when it would ever make sense to use that instead of statically allocating a heap like this. Perhaps if the heap size is unbounded and you want to let it grow upwards and just hope it never hits the stack, but that seems pretty foolish...
Could you update the example to move use core::mem::MaybeUninit out of the function and with the other use statements, though? And it might be worth adding a comment to explain that you're statically reserving some memory for the heap.
If anyone else @rust-embedded/cortex-m has thoughts about this please shout out though... I think it's mostly just that MaybeUninit and Rust's general concept of uninitialised memory was much less well developed when this was first written.

I think this also comes from the classic UNIX approach of  "heap goes up, stack comes down" and you use the "sbrk" (Stack Break) syscall to move the dividing line between them.
If we don't have that flexibility, then yes, the heap might as well be a static.


Add Repology badge to README.md

Summary
A way for users to see what downstream repositories carry liquid-dsp
Proposed design
The full badge looks like so:

but since it take up a lot of room it can be simply added as a single badge such as:

That's pretty slick. Thanks! Added to the README.


Listing details: Automatic scrolling when loading the listing detail view

Issue

[ ] 1. When I click on a listing further down the home page, I noticed it automatically scrolls me to the same position on the listing detail page. Check out the video below.

https://user-images.githubusercontent.com/13066886/107991792-2e6e0980-6f8c-11eb-991f-e89ce4ccb248.mov

Ok maybe we need a scroll to top function. https://reactrouter.com/web/guides/scroll-restoration

I'm not seeing this in Chrome. Are you using Safari @morebrownies ?

I was using Chrome

I'm not seeing it happen on Chrome anymore...


Question: handleInvocation: prioritizes earliest stubs rather than latest

Question
Is it an intentional design choice that OCMockObject chooses the first stub that was setup on a mock object, rather than the latest?
Example
This decision means that it is not possible to override a stub. For example:
id mock = [OCMockObject mockForClass:[MyObject class]];
[[[mock stub] andReturnValue:@YES] enabled]; // This stub always has highest priority
XCTAssertTrue(mock.enabled, @"It starts off enabled");
[[[mock stub] andReturnValue:@NO] enabled]; // -> Stub is correctly added to last position in list of recorders
XCTAssertTrue(mock.enabled, @"It changes to disabled"); // --> Fails because list of recorders is consulted in first-in-first-out order, and the for loop breaks on the first stub

While overriding stubs may be a smell, I think it is potentially useful, especially as a quick hack for overriding complex, shared test setup code.
Fix
Happy to propose a fix unless people oppose it. I would suggest either:

a "breaking"[1] change that inverts the priority order; or,
adding a new method to OCMockObject called stubWithPriority that adds the given stub to the beginning of the list of recorders.

[1]: Although this would technically change existing behavior, there is no proper usage of the library today where stub order matters.
Thanks!
cc/ @intelliot
See also: https://github.com/erikdoe/ocmock/commit/526197249c6b4efc87b8898ed717f496d568f829

Please see the discussion on issue #103. A bit of time has passed since, but I'm still planning to add quantifiers to OCMock. This has the advantage that it wouldn't be a breaking change and it would sidestep the thorny issue of overriding stubs.

Thanks for the quick response :cactus:
Can you go into a bit more depth on what quantifier syntax will look like?
At first blush, this solution goes against my expectations about which implementation details are relevant to my test. I might stub a method in my shared setup code that is invoked once in one test case but twice in another.
What is your opinion on the backwards compatible solution of adding a new method overrideStub, which adds a new stub on the beginning of the list of recorders?
[id mock = [OCMockObject mockForClass:[MyObject class]];
[[[mock stub] andReturnValue:@YES] enabled];
[[[mock overrideStub] andReturnValue:@NO] enabled];
XCTAssertTrue(mock.enabled, @"It changes to disabled"); // --> Fails because list of recorders is consulted in first-in-first-out order, and the for loop breaks on the first stub

As discussed in #103, stub matching gets a bit hairy, but this would ignore those details and work as if the overrideStub were added to the mock prior to the other call to stub.

Please see the discussion on issue #103. A bit of time has passed since, but I'm still planning to add quantifiers to OCMock.

Are there still plans to do this?

Sort of. I created a proposal in #302 last year and asked for feedback. There wasn't much so this hasn't been my highest priority. Might look into it again when I have some time over the summer.

So, finally, finally, quantifiers have made it into a released version of OCMock. That's the good news. The bad news is that they won't help with this issue. Currently I see no way to get the behaviour you'd prefer without a massive breaking change. So, unfortunately, I'll close this as won't fix. Sorry.


Fix typos in README.md

+1, thank you

@dustinhiatt-wf

It looks like Travis is failing because of a race condition somewhere in trie/ctrie. Interesting stack trace, but it can't be related to this PR.
IMO this is safe to merge.

+1


Sometimes basket is empty until logout and login again

We are suffering from a rarely occurring error causing the customer to be unable to manage his basket. It may be somehow domain specific. Maybe someone does have an idea where to search for a solution.
Issue Summary
After adding some Items to the basket, the price and item count is shown correctly, but after navigating to the basket, it shows that it's empty and the Basket button has 0 items and 0€ as price.
When navigating to another page, the basket button is displayed correctly.
We did not touch the Basket middleware.
The only thing we did is to submit the basket through ajax and updating the items and price at the button.
from oscar.apps.basket.views import BasketAddView
from django.http import JsonResponse
from custom.views import DynamicDataView

class BasketAddView(BasketAddView):

    def get_dynamic_data_context(self, request, *args, **kwargs):
        return DynamicDataView().get_context_data(request, *args, **kwargs)

    def post(self, request, *args, **kwargs):
        normal_response = super().post(request, *args, **kwargs)
        if request.POST.get('ajax') == 'true':
            context = self.get_dynamic_data_context(request, *args, **kwargs)
            return JsonResponse(context)
        return normal_response

class DynamicDataView(View):
    """ This returns various data that can be updated with Jquery ajax """

    def get_context_data(self, request, *args, **kwargs):
        """
        This Context is also loaded from the Page-wide processor and
        from apps.customer.wishlists.views import WishlistToggleProduct
        """
        context = {}
        basket = request.basket

        context['basket_value'] = basket.total_incl_tax

        context['basket_upcs'] = list(
            request.basket.lines.values_list('product__upc', flat=True)
        )
        context['basket_items'] = len(context['basket_upcs'])

        if request.user.is_authenticated:
            wishlists = request.user.wishlists.filter(name='Standard')
            if wishlists:
                wishlist = wishlists.first()
                wishlist_lines = wishlist.lines.values_list('product__upc', flat=True)
                context['wishlist_upcs'] = list(wishlist_lines)
                context['wishlist_items'] = len(context['wishlist_upcs'])
        return context

    def get(self, request, *args, **kwargs):
        context = self.get_context_data(request, *args, **kwargs)
        return JsonResponse(context)

Steps to Reproduce
I could not find, what is triggering this error.
We currently suspect that this somehow happens when you add several items to the catalog with a new basket (in our case via AJAX) and switch to the basket view very quickly.
Technical details

Python version: 3.7.3
Django version: 3.2.5
Oscar version: 3.1

It isn't possible for us to replicate this issue.


After a short time using text to speech, it just stops talking.

This has been going on since the time that the plugin was removed for a few days from the plugin hub months ago.
After using text to speech for 5mins-hour it just stops talking.

I have the same problem... would be nice to get this reliably working.

I noticed the recently added "AltTool"-field in the plugin, and I can see from the source code that if it contains the text "Brian5" and the chosen voice is Susan, it uses a different function and source for the TTS, and this version doesn't have the issue of the TTS stopping working after a while (or the other issue I've been experiencing, with the game freezing before each line of dialogue). Unfortunately it currently always uses the same voice called "Brian".

@LucyLikesYourFace could you provide a screenshot of the plugin settings or is everything default


Interest Becoming a Maintainer

Hi There,
My team has been using this project and would love to start contributing to it on a regular basis.  We use SF we like what you have here.  We recently submitted a pull request and have not got a response on it yet.  If you have become too busy to focus on this project or if you are no longer interested in doing so, we'd be happy to take over maintaining it for you.  If you are interested, please let me know.  We will commit to being responsive and working with the community to continue the great work you started.

Great!  What would be the best way for us to send you the ideas we have on how to move things forward?  Should we just submit PRs with explanations on why we think the changes are good?  Do you want us to send you what ideas we have?  We need to move fast on this and we want to do what we can to work best with you.  If you are interested in what we have done as an organization in open source, you can check out http://www.AngularPlayground.it.  If you are interested, we'd like to put a similar effort into this project complete with a site and docs.  Let me know what you think.

Sounds very good! I propose we go with PR's for a short while and when it works out, I'll add you as collaborators.
Definitely curious to hear your ideas.

That sounds good!
We like the changes you made and think thery're great.  We will continue to work on it and submit PRs ffor your approval.  One thing we have been wondering is if we are missing something on the Actor Broker part of the project.  It seems like it is inferior to the service broker and we were wondering if we were missing why it is useful.  If it is in fact inferior, we were wondering if you'd be open to dropping it from the project to further simplify it making it more focused, easier to learn and easier to use.  If we are missing something, we'd love to understand it more.  Any feedback on this you could provide would be awesome.
THanks again!

About the BrokerActor, I completely agree. In fact, let's mark it as Obsolete straight away.

While we're at it, we can deprecate the entire Interfaces library as well.

That is great.  I love the idea of keeping it as focused and simple as possible.  Let's make it amazing at doing what it does one way.  Thank you.  We'll continue to work at it and submit PRs.

Dana is now a collaborator, so I think this can be closed. Please reopen if needed.

Hey There,
I have been meaning to write you again.  I was wondering if you'd be up to working this project at a higher level.  We plan to continue a sustained effort on it over time.  We'd like to create a website, put up documentation, and promote the project and hopefully make it more known and used.  Here are a couple of our other projects:
http://AngularPlayground.it
http://service-fabric-distributed-cache.socreate.it
We'd love to bring this project into the fold.  Would you be open to discussing that?

Yes I am, it sounds great. Let's do it!

Would you be willing to make the organization SoCreate a project owner on the project? We'd add Dana, Jami Lurock or Chief of Software, Brian Treese our Chief of UX, and I as admin's on the project.  We'd still of course be collaborating with you and doing PR's through you if you prefer that.  What are your thoughts on this?