Subscriber is not called for nested fragments :-(

What can I do with it? Callback is called only when system asks for permissions. Other results are not reported.

Hi @egslava
I don't know if I understood you correctly, so please correct me if I'm wrong.
Do you mean that when using nested fragments -and only nested fragments- the subscriber observable will only be consume the item when the system asks for permissions?

Hi @VictorAlbertos
I made some animation + demo project. Please, see it:
https://github.com/egslava/bug-report-rx-paparazzo-nested-fragments

What a great feedback ;)
Thanks, as soon as possible I'll clone your repo and I'll try to fix it.

Sorry, gif was a bit cutted off, so I uploaded original demo video to youtube.
https://youtu.be/s1RlfkxKKpw
Perhaps, do you have any ETA (day/week/month)? :-( Just need to know - if I need to fix it by workaround or I can just do some other tasks instead?

The bug is fixed.
I've done a pull request to your project upgrading the rxpaparazzo version, and as long I can tell, it works just fine.
Let me know ;)

Very-very thanks! :-) Great! :-) Thank you! Amazing lib! Good luck! :-)

Thanks :) I'm closing this issues.


Feature.sps

Added vertexFunction and positionFunction properties : you can now modify your SPS mesh at creation time for ever and set it as non updatable if you don't need to update it afterwards
Some little fixes

yei :-)


Beginner question.

Hi there,
Followed the instructions, but this is what I got at the end:
C:\WorkTmp\react-redux-cesium-testing-demo>npm run dev

<EMAIL_ADDRESS>dev C:\WorkTmp\react-redux-cesium-testing-demo
cross-env NODE_ENV=development node devServer.js

Listening at http://localhost:3000
webpack built 46de09b66803c0958f28 in 920ms
Hash: 46de09b66803c0958f28
Time: 920ms
chunk    {0} app.js (app) 8.13 kB [rendered]
ERROR in ./src/index.js
Module build failed: TypeError: Path must be a string. Received undefined
at assertPath (path.js:7:11)
at Object.dirname (path.js:695:5)
at C:\WorkTmp\react-redux-cesium-testing-demo\node_modules\babel-core\lib\transformation\file\options\option-manager.js:374:36
at C:\WorkTmp\react-redux-cesium-testing-demo\node_modules\babel-core\lib\transformation\file\options\option-manager.js:396:22
at Array.map (native)
at OptionManager.resolvePresets (C:\WorkTmp\react-redux-cesium-testing-demo\node_modules\babel-core\lib\transformation\file\options\option-manager.js:385:20)
at OptionManager.mergePresets (C:\WorkTmp\react-redux-cesium-testing-demo\node_modules\babel-core\lib\transformation\file\options\option-manager.js:369:10)
at OptionManager.mergeOptions (C:\WorkTmp\react-redux-cesium-testing-demo\node_modules\babel-core\lib\transformation\file\options\option-manager.js:328:14)
at C:\WorkTmp\react-redux-cesium-testing-demo\node_modules\babel-core\lib\transformation\file\options\option-manager.js:370:14
at C:\WorkTmp\react-redux-cesium-testing-demo\node_modules\babel-core\lib\transformation\file\options\option-manager.js:390:24
at Array.map (native)
at OptionManager.resolvePresets (C:\WorkTmp\react-redux-cesium-testing-demo\node_modules\babel-core\lib\transformation\file\options\option-manager.js:385:20)
at OptionManager.mergePresets (C:\WorkTmp\react-redux-cesium-testing-demo\node_modules\babel-core\lib\transformation\file\options\option-manager.js:369:10)
at OptionManager.mergeOptions (C:\WorkTmp\react-redux-cesium-testing-demo\node_modules\babel-core\lib\transformation\file\options\option-manager.js:328:14)
at OptionManager.addConfig (C:\WorkTmp\react-redux-cesium-testing-demo\node_modules\babel-core\lib\transformation\file\options\option-manager.js:234:10)
at OptionManager.findConfigs (C:\WorkTmp\react-redux-cesium-testing-demo\node_modules\babel-core\lib\transformation\file\options\option-manager.js:434:16)
@ multi app
Child html-webpack-plugin for "index.html":
chunk    {0} index.html 412 kB [rendered]
webpack: bundle is now VALID.
What's wrong?
Thanks a lot,
Alex

Appears to be https://github.com/webpack/webpack/issues/2463 .  Basically, something about babel-core does not work under Node 6+, but only under Node 5.  Upgrading babel-core to 6.10.4+ is supposed to fix the issue.
FYI, I'm currently working on a blog post that will show how to use Cesium in a Webpack-based application, with a newer sample project as an example.  Keep an eye on http://blog.isquaredsoftware.com/ - I hope to publish the post by next week.
Also, out of curiosity: how did you find this repo?

Hi Mark,
Thanks for the prompt response. Actually, I was looking for some guidance
on how to put cesiumjs and a react on one page (+ using redux, to make it
right). I'm a novice to all this stuff and your blog kinda has it all...
I'd like to use a cesiumjs instead of deprecated GE plugin (in some of our
applications) and in the web based solution ( http://vod-aws.impleotv.com/
) instead of leaflet.
So, from what I understand (and I don't understand much :-) it is better
just to split a page and keep cesium in a DOM while all the rest to
implement using react..
Thanks,
Alex
On Thu, Mar 2, 2017 at 6:38 PM, Mark Erikson<EMAIL_ADDRESS>wrote:

Appears to be webpack/webpack#2463
https://github.com/webpack/webpack/issues/2463 . Basically, something
about babel-core does not work under Node 6+, but only under Node 5.
Upgrading babel-core to 6.10.4+ is supposed to fix the issue.
FYI, I'm currently working on a blog post that will show how to use Cesium
in a Webpack-based application, with a newer sample project as an example.
Keep an eye on http://blog.isquaredsoftware.com/ - I hope to publish the
post by next week.
Also, out of curiosity: how did you find this repo?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/markerikson/react-redux-cesium-testing-demo/issues/5#issuecomment-283706106,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJHeYVegMeC9nMcQ9-m5sYTobFNTtUudks5rhvCZgaJpZM4MQn7h
.

Gotcha.  Well, if you gimme just a few more days, you'll have a lot more information on the topic available :)
And yeah, what I'm going to demonstrate in more depth is how to:

Initialize and show Cesium at a basic level in a Webpack-based app
Control Cesium's behavior using React components (rendering billboards+labels+polylines, mouse interaction, camera control)
Advanced Webpack configuration to enable code splitting and delay-loading Cesium

And as promised, I just published a 2-part post on "Declaratively Rendering Earth in 3D: Using Cesium with React and Webpack".  Part 1 covers basic Cesium+Webpack setup and build optimization with DllPlugin. Part 2 shows declarative React components that wrap imperative APIs:
http://blog.isquaredsoftware.com/2017/03/declarative-earth-part-1-cesium-webpack/
http://blog.isquaredsoftware.com/2017/03/declarative-earth-part-2-cesium-react/


multicast: add CLIs to configure multicast bpf maps

Change
This change adds cilium-dbg commands to manage multicast BPF maps.
Following commands are added
- cilium-dbg bpf multicast group list
- cilium-dbg bpf multicast group add <group>
- cilium-dbg bpf multicast group delete <group>
- cilium-dbg bpf multicast subscriber list <group|all>
- cilium-dbg bpf multicast subscriber add <group> <subscriber>
- cilium-dbg bpf multicast subscriber delete <group> <subscriber>

This is follow up of https://github.com/cilium/cilium/pull/29469
Enabling Multicast
Users can configure multicast maps sub-system to enable multicast connectivity in the cluster. Following configuration will be required to achieve this.

Enable multicast using cilium-cli
cilium config set multicast-enabled true
-- This will result in cilium pod restart.
-- Cilium MUST be configured in vxlan tunnel mode.

For each cilium pod, configure desired multicast groups.
cilium-dbg multicast group add <group IP>

Configure group subscriber map to add all nodes (except self) as remote subscribers.
cilium-dbg multicast subscriber add <groupIP> <SubscriberIP>
-- Cilium node internal IP can be found using kubectl get ciliumnodes.cilium.io command.
-- Use internal IPs as subscriber IPs.
-- Omit self node IP from adding as subscriber.

After doing this, multicast receiver pods can send out IGMP join and multicast sender pods can start sending multicast stream.
multicast: add CLIs to manage multicast BPF maps

/test

Clustermesh CI failure : https://github.com/cilium/cilium/issues/30251

Ginkgo Test 1.29_f06-agent-policy-basic failure : https://github.com/cilium/cilium/issues/31147

Thanks @lambdanis  for the review. I fixed the rendering problem and example sections. Please have another look whenever you get a chance 🙏

/test

ci-ginkgo failure - https://github.com/cilium/cilium/issues/31147

Thanks @derailed for detailed review 🙏 . I dry'd most of the repeatable code. There are couple of comments which I am not sure if I understand correctly. Pls have a look whenever you get a chance.

/test

Ingress Conformance test failure : https://github.com/cilium/cilium/issues/30281

/test


project addition : HTML, CSS, JS #825

Adding new project to the list: #825
I want to add a new project to the list

please add issue number

Adding the issue number - #825

Adding the issue number - #825

this is your PR number please add issue number otherwise your PR might be closed

Added! #841


bypass NcML non-classic model abort and turn into a warning

I am working with a bunch of GOES-R ABI satellite imagery which uses a non-classic NcML schema which trips an abort in ncdump when generating XML metadata output for versions greater than netcdf-4.1.3.  To facilitate an update I have added a command line switch which bypasses the abort code when attempting to dump non-classic model NcML data, and turns it into a warning.  This can be verified by downloading any GOES-R ABI imagery and running "ncdump -x " using both version 4.1.3 and anything newer.
I am requesting that this patch be reviewed for inclusion as others may be interested in dumping XML metadata from the GOES-R satellite imagery using newer versions of NetCDF.
Please note, that I have spot checked the XML output for imagery using an offline version of netcdf-4.7.3 containing this modification against what is generated on the Ground System using netcdf-4.1.3 and found them to be consistent.  I will be reviewing the NcML documentation to see if the schema will trigger any known bugs, but any changes at that level will take a very long time to update.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.John (EBo) David seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Sorry for the delay.  Since this is related to things I/we are doing at work I had to ask permission to sign the licensing document.  BTW, I actually asked permission before the original submission, but did not know the details of the licensing before submitting.
Anyway, they do not care about the changes I submitted, or even doing what is asked to change the -Z to a -Xx, etc., but normally this kind of work is done by a different group we work with.  My bosses boss is concerned me starting down a slippery slope and that something that I do impacts the other groups or is seen as a conflict of interest.  As such I have been asked to write an internal bug report / white paper detailing the issues and seeing who wants to do what internally before committing resources upstream...  So, I should be able to get permission to sign the licensing agreement to hand over that code I have submitted, but I may have some pushback getting permission to make the -Xx change even if it is on my own time.
I do not mind advocating to sign the licence and be allowed make the -Xx change, but before I push that rock up the hill, what are the chances this would be accepted?
Once again, sorry for the delay.

Hello @ebo, I too apologize for the delay; recent events have overtaken us, as I'm sure you can imagine.  I think this would be a good change and certainly a PR we would accept.  @DennisHeimbigner , any thoughts?

non-classic NcML schema which trips an abort in ncdump when generating XML
It should not abort; that is our error. But I have no problem
with this change.

@ebo another workaround to ncdump's XML output for non-classic files is ncks --xml in.nc.

On Mar 31 2021 7:11 AM, Charlie Zender wrote:

@ebo another workaround to ncdump's XML output for non-classic
files is ncks --xml in.nc.

Thank you.  I will have to check to see if that will work for us, but I
doubt it as NCO is not installed on the ground system, and I am not sure
if we can get that installed without a very long review process.  It
might be easier to get the netcdf version updated to one that includes
the patch.
Thanks again for the information, and if there is a problem upgrading
netcdf then I can look into having NCO installed.
EBo --

as a note, I thought I already signed the CLA a year ago.  It took a bit of back and forth, but they allowed me to submit this, but limited my further involvement.  Was some fix added, and if so what release or version was it included?

I am not sure I understand this problem. Is that the file is netcdf-4, but does not
use any netcdf-4 specific features -- in effect it is a netcdf-4 classic file?


Show frame id in the bookmark list

It would be nice to see a frame id in the bookmark list to quickly understand what parts of the timeline bookmarks represent.

What do you mean by a frame id? Also you can put any text on your bookmark so you can also describe there what function is inside. You can copy the current fn name to the clip board by hitting Ctrl+F

That's the number of the frame in the timeline.

 I call frame to  the function frame, which are all the entries inside a function call. That make sense. I'll add it.


Unable to use this package in development

There should be compatibility with the development process. Right now the port is hardcoded, for example, to 80 or 443.

closing this issue in favor of https://github.com/eea/volto-middleware-vh/issues/6


Implement models for DCPR

The DCPR component requires some additional database models. These must implement the information schema depicted in the System Architecture Design document (see section 3.2 Inbound DCPR requests)
Implement these models taking into account the best practices for writing CKAN extensions

Superseeded by #68, #69, #70


Bugfix for copy crafting recipes feature

I wonder why nobody already reported it, but no item wear or metadata is keeped when moving items to crafting grid.
Leads to repaired tools and lost item metadata.

the unified inventory mod has the same bug l think

thanks


⚠ Bofrost.lu has degraded performance

In faf1174, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1515 ms

Resolved: Bofrost.lu performance has improved in 2fbbfc7 after 20 minutes.


Do we have any function to just display which slide is currently displayed

Clear and concise description of the problem
I am using 11.0.5 with the vue.
I am trying to track which slide is shown to the user using google analytics and sending custom event to GA to know all slides are shown to the users. However sometimes one a particular slidechange event will send this event twice. This gave me some wrong information about if a particular user is already revealed to the user and how many times it's being reveled to the user. Probably because loop = true.
Suggested solution
Should we have any event which will let me know which slide is shown with index? It doesn't matter loop=true or not we just want to know which one is revealed to the user.
Alternative
Or on change event if there is option or flag so I don't need to send the event to GA not for tracking?
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Would you like to open a PR for this feature?

[X] I'm willing to open a PR

Do you want to ask a question? Are you looking for support? Stack Overflow or Swiper Discussions is the best places for getting support

Please, don't use GitHub issues for questions


Make it easier to init Firestore with GoogleCredentials

Currently, the FirestoreDb class can only be initialized with application default credentials. If I want to specify a service account explicitly, I have to use a more low-level API:
using Google.Cloud.Firestore.V1;
using Google.Apis.Auth.OAuth2;
using Grpc.Auth;
using Grpc.Core;

// Load a service account explicitly
var serviceAcct = GoogleCredential.FromFile("path/to/serviceAcct.json");
Channel channel = new Channel(
           FirestoreClient.DefaultEndpoint.Host, FirestoreClient.DefaultEndpoint.Port,
           serviceAcct.ToChannelCredentials());
FirestoreClient client = FirestoreClient.Create(channel);

FirestoreDb db = FirestoreDb.Create(project, client);

Some other GCP clients provide an API that accepts both a project ID and a GoogleCredential to make this flow easier. See BigQuery API for example.
Following this pattern, please provide a FirestoreDb.Create(string, GoogleCredential) overload to make this type of initialization easier.

As mentioned in #2349, it's now a lot easier to do this (just adding the info here because this is the first issue shown in Google when searching for C# Firestore Client auth). Check out https://googleapis.github.io/google-cloud-dotnet/docs/faq.html#how-can-i-use-non-default-credentials-for-grpc-based-apis


[bug] Error: Your test suite must contain at least one test.

Test runner cannot generate test case from my story. The story rendered with no problems in Storybook, but when I run test-storybook, I get:
 FAIL   browser: chromium  .../MyComponent/stories.jsx
  ● Test suite failed to run

    Your test suite must contain at least one test.

      at onResult (node_modules/@storybook/test-runner/node_modules/@jest/core/build/TestScheduler.js:172:18)
      at node_modules/@storybook/test-runner/node_modules/@jest/core/build/TestScheduler.js:300:17
      at node_modules/emittery/index.js:311:13
          at Array.map (<anonymous>)
      at Emittery.emit (node_modules/emittery/index.js:309:23)

Sources
.../MyComponent/stories.jsx:
import { expect } from '@storybook/jest';

const MyComponent = () => 'hello world';

export default {
  title: 'MyComponent',
  component: MyComponent,
};

export const MyStory = {
  play: async () => {
    expect(42).toBe(42);
  },
};

test-runner-jest.config.js:
const { getJestConfig } = require('@storybook/test-runner');

const config = getJestConfig();
config.testMatch = ['<rootDir>/**/MyComponent/stories.jsx']

module.exports = config;

System
System:
    OS: macOS 13.5.2
    CPU: (10) arm64 Apple M1 Pro
  Binaries:
    Node: 18.17.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.6.7 - /usr/local/bin/npm
  Browsers:
    Chrome: 117.0.5938.149
    Safari: 16.6
  npmPackages:
    @storybook/addon-actions: ^7.4.0 => 7.4.1
    @storybook/addon-essentials: ^7.4.0 => 7.4.1
    @storybook/addon-interactions: ^7.4.0 => 7.4.1
    @storybook/addon-knobs: ^7.0.2 => 7.0.2
    @storybook/addon-links: ^7.4.0 => 7.4.1
    @storybook/addon-viewport: ^7.4.0 => 7.4.1
    @storybook/jest: 0.2.1 => 0.2.1
    @storybook/nextjs: ^7.4.0 => 7.4.1
    @storybook/react: ^7.4.0 => 7.4.1
    @storybook/test-runner: 0.13.0 => 0.13.0
    @storybook/testing-library: 0.2.0 => 0.2.0

Here is what I have found in jest cache:
db5cd9409e7f083b8ae7f94af011077a
"use strict";

Object.defineProperty(exports, "__esModule", {
  value: true
});
exports.default = exports.MyStory = void 0;
var _jest = require("@storybook/jest");
const MyComponent = () => 'hello world';
var _default = exports.default = {
  title: 'MyComponent',
  component: MyComponent
};
const MyStory = exports.MyStory = {
  play: async () => {
    (0, _jest.expect)(42).toBe(42);
  }
};
//# sourceMappingURL=data:application/json; ...

there is no any jest spefiic calls in here, so looks like indeed, the code is transformed but not for test running.

Turns out it was naming problem. The playwright transformer from the default config is applied only when your stories has *.stories.jsx not stories.js name
 '^.+\\.stories\\.[jt]sx?$'<EMAIL_ADDRESS>


Sliding slowly when the image is too large

Which OS ?
Version
Which versions are you using:

react-native-swiper v1.5.13?
react-native v0.5.6

export default class ImageSwiper extends PureComponent {
static defaultProps = {
images: {}
}
 render() {
     return (
           <Swiper
             removeClippedSubviews={true}
             pagingEnabled={true}
             dotColor='white'
             loop={false}
             paginationStyle={{bottom: 10}}
             index={this.props.images.index}
             >
             {this.renderImages()}
           </Swiper>
     );
 }

Can u solve this problem ? @LT13S


Does the crawler search for all component classes or just the first one?

When I search for m-card__topic it returns zero results but I know the homepage has topic cards.

Is this happening because it's logging m-card and ignoring the subsequent m-card__topic class?

Unfortunately it does look like we only store the first class, confirming by looking in the database at what components we store for the homepage:
sqlite> select components from cfgov where path = '/';
["a-btn","a-link","a-overlay","a-tagline","a-text-input","m-btn-inside-input","m-card","m-global-banner","m-global-eyebrow","m-global-header-cta","m-global-search","m-hero","m-info-unit","m-list","m-notification","m-social-media","o-card-group","o-footer","o-footer-middle-left","o-footer-middle-right","o-footer-post","o-form","o-header","o-info-unit-group","o-mega-menu","o-well"]

The relevant code is in this getComponents function, which uses this regex: /(?:(?:class=")|\s)((?:o|m|a)-[^_"__\s]*)/g. According to https://regex101.com/r/iLlDG9/3 this works for "m-card m-card-foo" but not "m-card m-card__topic", so something to do with the underscores.
If I change this to /(?:(?:class=")|\s)((?:o|m|a)-[^"\s]*)/g, this works better -- see https://regex101.com/r/LmkmUd/1.
PR opened at #22.


wallt connet not wrk at vercel why?

try adding your PROJECT ID under vercel's env variables
project > settings > environment variables


Embedding layer

models.py imports Embedding on line 4, but it never seems to be used. Instead, the code to get word embeddings is this:
wemb = TimeDistributed(Dense(output_dim=self.embed_size,
                             input_dim=self.vocab_size,
                             W_regularizer=l2(self.l2reg)),
                       name="w_embed")(text_mask)

If I understand this correctly, the Dense layer takes a one-hot vector as input, and learns to output embeddings for each word. I think this could be rewritten as:
wemb = TimeDistributed(Embedding(output_dim=self.embed_size,
                                 input_dim=self.vocab_size + 2,
                                 mask_zero=True,
                                 W_regularizer=l2(self.l2reg)),
                       name="w_embed")(text_mask)

Or, slightly more verbose:
embedding_layer = Embedding(output_dim=self.embed_size,
                            input_dim=self.vocab_size + 2,
                            mask_zero=True,
                            W_regularizer=l2(self.l2reg))
wemb = TimeDistributed(embedding_layer, name="w_embed")(text_mask)

But seeing as the code once made use of Embedding and then it was dropped again, I'm a bit suspicious. Was there a reason for this layer to be replaced with Dense?
(Embeddings also have a dropout keyword argument. So I guess the drop_wemb could be removed as well, if we pass self.dropin as a keyword argument. That would make the code more concise.)

Also, I set mask_zero to True here, but the Dense layer doesn't seem to care about the padding value. The effect of this, I guess, is that the model right now doesn't mask out the embedding for the padding. Is that an issue?
The Keras docs say this about the Embedding layer's mask_zero argument:
mask_zero: Whether or not the input value 0 is a special "padding" value that should be masked out. This is useful for recurrent layers which may take variable length input. If this is True then all subsequent layers in the model need to support masking or an exception will be raised. If mask_zero is set to True, as a consequence, index 0 cannot be used in the vocabulary (input_dim should equal |vocabulary| + 2).

I think that the Embedding layer did not exist when we first wrote this code.
If you can get the Embedding layer to work, then please submit a pull request.

I tried to implement the change, but it didn't work. I don't think I understand the model as it is right now. Here's the relevant code:
    def buildKerasModel(self, use_sourcelang=False, use_image=True):
        '''
        Define the exact structure of your model here. We create an image
        description generation model by merging the VGG image features with
        a word embedding model, with an RNN over the sequences.
        '''
        logger.info('Building Keras model...')

        text_input = Input(shape=(self.max_t, self.vocab_size), name='text')
        text_mask = Masking(mask_value=0., name='text_mask')(text_input)

        # Word embeddings
        wemb = TimeDistributed(Dense(output_dim=self.embed_size,
                                      input_dim=self.vocab_size,
                                      W_regularizer=l2(self.l2reg)),
                                      name="w_embed")(text_mask)
        drop_wemb = Dropout(self.dropin, name="wemb_drop")(wemb)

        # Embed -> Hidden
        emb_to_hidden = TimeDistributed(Dense(output_dim=self.hidden_size,
                                      input_dim=self.vocab_size,
                                      W_regularizer=l2(self.l2reg)),
                                      name='wemb_to_hidden')(drop_wemb)

I have no idea what emb_to_hidden does, or why it even works. Here's why:

I assume that w_embed takes a one-hot vector and produces an embedding.
I assume that wemb_drop then randomly drops a proportion (self.dropin) of the values during training, so as to make the model more robust.
I assume that wemb_to_hidden connects the embedding layer to the hidden layer.

But then why is the input dimension for the last layer equal to self.vocab_size? Shouldn't that be the same as embed_size? I just tried this out, and the model still works.
Also, the documentation for Embedding says the following:

Turn positive integers (indexes) into dense vectors of fixed size. eg. [[4], [20]] -> [[0.25, 0.1], [0.6, -0.2]]
This layer can only be used as the first layer in a model.

So it can only work on a sequence, whereas the Dense layer works on a single one-hot vector. Also, the documentation says that the difference between Dense and Embedding is that the latter does not have bias terms. That also means: fewer parameters. This seems like a desirable property, so I'd really like to get this to work. (Otherwise, we could just keep using the Dense layer.)
Embedding could also simplify the code:

It takes care of masking, so we don't need the Masking layer.
It takes care of dropout, so we don't need the dropout layer.
It works on sequences out of the box, so I don't think it needs to be wrapped by TimeDistributed.

Here's what I tried:
        text_input = Input(shape=(self.max_t, self.vocab_size), name='text')

        # Word embeddings
        wemb = Embedding(output_dim=self.embed_size,
                         input_dim=self.vocab_size,
                         W_regularizer=l2(self.l2reg),
                         mask_zero=True,
                         name="w_embed")(text_input)

        drop_wemb = Dropout(self.dropin, name="wemb_drop")(wemb)
        emb_to_hidden = TimeDistributed(Dense(output_dim=self.hidden_size,
                                      input_dim=self.vocab_size,
                                      W_regularizer=l2(self.l2reg)),
                                      name='wemb_to_hidden')(drop_wemb)

This results in an error: Exception: Input 0 is incompatible with layer wemb_to_hidden: expected ndim=3, found ndim=4. I think this has something to do with the way TimeDistributed and batching work, but I don't understand what's going on.

I think the problem is that applying a TimeDistributed over the Embedding
layer is producing a rank=4 tensor. The Embedding layer already returns a
rank=3 tensor (batch size, length, features) so you don't need a
TimeDistributed over that.
You might have found a bug with the input to emb_to_hidden having an input
dimensionality of vocab_size. I don't understand why that works either.
On Mon, 25 Sep 2017 at 17:31 Emiel van Miltenburg<EMAIL_ADDRESS>wrote:

I tried to implement the change, but it didn't work. I don't think I
understand the model as it is right now. Here's the relevant code:
def buildKerasModel(self, use_sourcelang=False, use_image=True):
    '''        Define the exact structure of your model here. We create an image        description generation model by merging the VGG image features with        a word embedding model, with an RNN over the sequences.        '''
    logger.info('Building Keras model...')

    text_input = Input(shape=(self.max_t, self.vocab_size), name='text')
    text_mask = Masking(mask_value=0., name='text_mask')(text_input)

    # Word embeddings

    wemb = TimeDistributed(Dense(output_dim=self.embed_size,
                                  input_dim=self.vocab_size,
                                  W_regularizer=l2(self.l2reg)),
                                  name="w_embed"

)(text_mask)
drop_wemb = Dropout(self.dropin, name="wemb_drop")(wemb)
    # Embed -> Hidden
    emb_to_hidden = TimeDistributed(Dense(output_dim=self.hidden_size,
                                  input_dim=self.vocab_size,
                                  W_regularizer=l2(self.l2reg)),
                                  name='wemb_to_hidden')(drop_wemb)

I have no idea what emb_to_hidden does, or why it even works. Here's why:

I assume that w_embed takes a one-hot vector and produces an
embedding.
I assume that wemb_drop then randomly drops a proportion (self.dropin)
of the values during training, so as to make the model more robust.
I assume that wemb_to_hidden connects the embedding layer to the
hidden layer.

But then why is the input dimension for the last layer equal to
self.vocab_size? Shouldn't that be the same as embed_size? I just tried
this out, and the model still works.
Also, the documentation for Embedding says the following:
Turn positive integers (indexes) into dense vectors of fixed size. eg.
[[4], [20]] -> [[0.25, 0.1], [0.6, -0.2]]
This layer can only be used as the first layer in a model.
So it can only work on a sequence, whereas the Dense layer works on a
single one-hot vector. Also, the documentation says that the difference
between Dense and Embedding is that the latter does not have bias terms.
That also means: fewer parameters. This seems like a desirable property, so
I'd really like to get this to work. (Otherwise, we could just keep using
the Dense layer.)
Embedding could also simplify the code:

It takes care of masking, so we don't need the Masking layer.
It takes care of dropout, so we don't need the dropout layer.
It works on sequences out of the box, so I don't think it needs to
be wrapped by TimeDistributed.

Here's what I tried:
    text_input = Input(shape=(self.max_t, self.vocab_size), name='text')

    # Word embeddings
    wemb = Embedding(output_dim=self.embed_size,
                     input_dim=self.vocab_size,
                     W_regularizer=l2(self.l2reg),
                     mask_zero=True,
                     name="w_embed")(text_input)

    drop_wemb = Dropout(self.dropin, name="wemb_drop")(wemb)
    emb_to_hidden = TimeDistributed(Dense(output_dim=self.hidden_size,
                                  input_dim=self.vocab_size,
                                  W_regularizer=l2(self.l2reg)),
                                  name='wemb_to_hidden')(drop_wemb)

This results in an error: Exception: Input 0 is incompatible with layer
wemb_to_hidden: expected ndim=3, found ndim=4. I think this has something
to do with the way TimeDistributed and batching work, but I don't
understand what's going on.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/elliottd/GroundedTranslation/issues/29#issuecomment-331937695,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABWqf4zC22L9lAAunmRRYY8pQHKB-p3Iks5sl9VngaJpZM4Phsw_
.

So I tried to do what we discussed earlier (remove TimeDistributed and use the Embedding directly), but it still gives the same error: Exception: Input 0 is incompatible with layer rnn: expected ndim=3, found ndim=4. Here's the relevant code:
    text_input = Input(shape=(self.max_t, self.vocab_size), name='text')

    # Word embeddings
    wemb = Embedding(output_dim=self.embed_size,
                     input_dim=self.vocab_size,
                     input_length=self.max_t,
                     W_regularizer=l2(self.l2reg),
                     mask_zero=True,
                     name="w_embed")(text_input)

The LSTM part:
        logger.info("Building an LSTM")
        rnn = InitialisableLSTM(output_dim=self.hidden_size,
                  input_dim=self.hidden_size,
                  return_sequences=True,
                  W_regularizer=l2(self.l2reg),
                  U_regularizer=l2(self.l2reg),
                  name='rnn')([wemb, rnn_initialisation])# was ([emb_to_hidden, rnn_initialisation])

I'm using hidden_size=300 for the time being, but ideally this would be customizable as well. That would require another layer between Embedding and InitialisableLSTM.

A Keras tutorial
says the input to an embedding layer should be 2D. Is our text input
already 3D?
If it is already 3D, you'll need to change the data generator to yield
appropriate 2D inputs.
Perhaps the tutorial from above can offer some useful guidance.
On Tue, 31 Oct 2017, 12:44 Emiel van Miltenburg<EMAIL_ADDRESS>wrote:

So I tried to do what we discussed earlier (remove TimeDistributed and use
the Embedding directly), but it still gives the same error: Exception:
Input 0 is incompatible with layer rnn: expected ndim=3, found ndim=4.
Here's the relevant code:
text_input = Input(shape=(self.max_t, self.vocab_size), name='text')

# Word embeddings
wemb = Embedding(output_dim=self.

embed_size,
input_dim=self.vocab_size,
input_length=self.max_t,
W_regularizer=l2(self.l2reg),
mask_zero=True,
name="w_embed")(text_input)
The LSTM part:
    logger.info("Building an LSTM")
    rnn = InitialisableLSTM(output_dim=self.hidden_size,
              input_dim=self.hidden_size,
              return_sequences=True,
              W_regularizer=l2(self.l2reg),
              U_regularizer=l2(self.l2reg),
              name='rnn')([wemb, rnn_initialisation])# was ([emb_to_hidden, rnn_initialisation])

I'm using hidden_size=300 for the time being, but ideally this would be
customizable as well. That would require another layer between Embedding
and InitialisableLSTM.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/elliottd/GroundedTranslation/issues/29#issuecomment-340750939,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABWqf7wQCGBOCyjj8k1TI2N6-FQvA3_aks5sxxYqgaJpZM4Phsw_
.

I would say it is 2D, or at least the code says it is. Or am I misunderstanding the shape-argument?
    text_input = Input(shape=(self.max_t, self.vocab_size), name='text')
    text_mask = Masking(mask_value=0., name='text_mask')(text_input)

I'll just use this thread for notes of things that I don't understand.
Why does format_sequence skip tokens that don't exceed the UNK threshold? That results in ungrammatical descriptions like "I saw the yesterday" which are used to train the system. I can imagine that having an UNK token does help with the quality of the descriptions because at least the system is aware that there should be SOME word in there.

I think that replicates some other implementations that discarded the tokens completely. It probably makes more sense to add an UNK token to the vocabulary and use the UNK threshold to substitute the tokens.

Also, it's easier for me to track these different issues if you create different issues. I might forget that we discussed the format_sequence and UNK token in this thread about the Embedding layer.

Ok, I opened #31 for this.

I'm not sure how to initialize the output layers. Or at least: I don't know what to do with the size of the hidden layer. Here's the current code:
        # Recurrent layer
        if self.gru:
            logger.info("Building a GRU")
            rnn = InitialisableGRU(output_dim=self.hidden_size,
                      input_dim=self.hidden_size,
                      return_sequences=True,
                      W_regularizer=l2(self.l2reg),
                      U_regularizer=l2(self.l2reg),
                      name='rnn')([emb_to_hidden, rnn_initialisation])
        else:
            logger.info("Building an LSTM")
            rnn = InitialisableLSTM(output_dim=self.hidden_size,
                      input_dim=self.hidden_size,
                      return_sequences=True,
                      W_regularizer=l2(self.l2reg),
                      U_regularizer=l2(self.l2reg),
                      name='rnn')([emb_to_hidden, rnn_initialisation])

        output = TimeDistributed(Dense(output_dim=self.vocab_size,
                                       input_dim=self.hidden_size,
                                       W_regularizer=l2(self.l2reg),
                                       activation='softmax'),
name='output')(rnn)

Because the output layer has self.hidden_size as its input_dim, we can't put embeddings.T there as the weights because the dimensions don't line up. Two options:

Make the LSTM/RNN output dimensions the same as self.embed_size, so that the output layer has self.embed_size as its input dimensions.
Add another TimeDistributed(Dense(...)) in between the LSTM/RNN and the current output layer to map the self.hidden_size to self.embed_size. Then we can make the output layer have the correct dimensions.

I think you want option 2. See Lior and Wolf 2017 for some more details on tying the embeddings.


feat(cuda): support selecting specific cuda version

Hello.
I use this repo to build machine learning projects .
This PR suggests that users explicitly specify the CUDA version, becase a part of python packages require it.
Please consider it.

Looks good to me! Thank you!


Build error: Eigen/src/Core/arch/CUDA/PacketMathHalf.h(45): error: identifier "__half2half2" is undefined

I'm getting the following errors when I try to build TensorFlow:
external/eigen_archive/unsupported/Eigen/CXX11/../../../Eigen/src/Core/arch/CUDA/PacketMathHalf.h(45): error: identifier "__half2half2" is undefined                                                                                [136/14011]
external/eigen_archive/unsupported/Eigen/CXX11/../../../Eigen/src/Core/arch/CUDA/PacketMathHalf.h(53): error: identifier "__halves2half2" is undefined
external/eigen_archive/unsupported/Eigen/CXX11/../../../Eigen/src/Core/arch/CUDA/PacketMathHalf.h(57): error: identifier "__halves2half2" is undefined
external/eigen_archive/unsupported/Eigen/CXX11/../../../Eigen/src/Core/arch/CUDA/PacketMathHalf.h(65): error: identifier "__low2half" is undefined
external/eigen_archive/unsupported/Eigen/CXX11/../../../Eigen/src/Core/arch/CUDA/PacketMathHalf.h(66): error: identifier "__high2half" is undefined
external/eigen_archive/unsupported/Eigen/CXX11/../../../Eigen/src/Core/arch/CUDA/PacketMathHalf.h(81): error: identifier "__halves2half2" is undefined
external/eigen_archive/unsupported/Eigen/CXX11/../../../Eigen/src/Core/arch/CUDA/PacketMathHalf.h(88): error: identifier "__halves2half2" is undefined

What related GitHub issues or StackOverflow threads have you found by searching the web for your problem?
Nothing.
Environment info
Operating System:
Ubuntu 14.04.1
gcc-4.8.4
bazel 0.3.2
TensorFlow: Master 6f7cf60a4158a6d
Installed version of CUDA and cuDNN:
(please attach the output of ls -l /path/to/cuda/lib/libcud*):
cuda: 7.5
cudnn: 5.1.5
 ❯ ls -lh /usr/local/cuda-7.5/lib64/libcud*
-rw-r--r-- 1 root root 316K Aug  7  2015 /usr/local/cuda-7.5/lib64/libcudadevrt.a
lrwxrwxrwx 1 root root   16 Aug  7  2015 /usr/local/cuda-7.5/lib64/libcudart.so -> libcudart.so.7.5
lrwxrwxrwx 1 root root   18 Aug  7  2015 /usr/local/cuda-7.5/lib64/libcudart.so.7.5 -> libcudart.so.7.5.7
-rwxr-xr-x 1 root root 375K Aug  7  2015 /usr/local/cuda-7.5/lib64/libcudart.so.7.5.7
-rw-r--r-- 1 root root 704K Aug  7  2015 /usr/local/cuda-7.5/lib64/libcudart_static.a
 ❯ ls -lh /usr/local/cudnn-5.1/lib64
lrwxrwxrwx 1 root root  13 Oct 21 18:33 libcudnn.so -> libcudnn.so.5
lrwxrwxrwx 1 root root  17 Oct 21 18:33 libcudnn.so.5 -> libcudnn.so.5.1.5
-r-xr-xr-x 1 root root 76M Oct 21 18:33 libcudnn.so.5.1.5
-r-xr-xr-x 1 root root 67M Oct 21 18:33 libcudnn_static.a

If installed from binary pip package, provide:

A link to the pip package you installed:
The output from python -c "import tensorflow; print(tensorflow.__version__)".

If installed from source, provide

The commit hash (git rev-parse HEAD)
6f7cf60a4158a6d7861dc1b41a6446b575153a2e
The output of bazel version

Build label: 0.3.2
Build target: bazel-out/local-fastbuild/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Fri Oct 7 17:25:10 2016<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

If possible, provide a minimal reproducible example (We usually don't have time to read hundreds of lines of your code)
What other attempted solutions have you tried?
Logs or other output that would be helpful
(If logs are large, please upload as attachment or provide link).

Maybe @benoitsteiner might help.

 ❯ grep half2half2 /usr/local/cuda-7.5/include/cuda_fp16.h -2

__CUDA_FP16_DECL__ __half __high2half(const __half2 h);
__CUDA_FP16_DECL__ __half2 __halves2half2(const __half l, const __half h);
__CUDA_FP16_DECL__ __half2 __half2half2(const __half lh);
__CUDA_FP16_DECL__ __half2 __floats2half2_rn(const float f1, const float f2);
__CUDA_FP16_DECL__ __half2 __float22half2_rn(const float2 f);
--
   return val;
}
__CUDA_FP16_DECL__ __half2 __half2half2(const __half lh)
{
   __half2 val;

Same on 0.11 branch.

@gokceneraslan: it looks like bazel is picking up an older version of CUDA that doesn't support fp16. Do you have cuda 7.0 (or older) installed in  /usr/local/cuda by any chance ?

No, I have only cuda 7.5 installed. In bazel cache, I can also see that it picks up the right cuda:
 ❯ pwd
.../.bazel-cache/107ff11f0584ee207e19ea91624e574d/external/local_config_cuda/cuda
 ❯ ls
bin  extras  include  lib64  nvvm  BUILD  build_defs.bzl  cuda_config.h  platform.bzl
 ❯ ls -alh include/cuda_fp16.h
lrwxrwxrwx 1 user users 39 Nov  1 10:20 include/cuda_fp16.h -> /usr/local/cuda-7.5/include/cuda_fp16.h
 ❯ grep half2half2 include/cuda_fp16.h -2
__CUDA_FP16_DECL__ __half __high2half(const __half2 h);
__CUDA_FP16_DECL__ __half2 __halves2half2(const __half l, const __half h);
__CUDA_FP16_DECL__ __half2 __half2half2(const __half lh);
__CUDA_FP16_DECL__ __half2 __floats2half2_rn(const float f1, const float f2);
__CUDA_FP16_DECL__ __half2 __float22half2_rn(const float2 f);
--
   return val;
}
__CUDA_FP16_DECL__ __half2 __half2half2(const __half lh)
{
   __half2 val;

@gokceneraslan Which .cc file(s) trigger these error messages ?

I think contrib/rnn/kernels/gru_ops_gpu.cu.cc. The output is as follows:
INFO: From Compiling tensorflow/contrib/rnn/kernels/gru_ops_gpu.cu.cc:
nvcc warning : option '--relaxed-constexpr' has been deprecated and replaced by option '--expt-relaxed-constexpr'.
nvcc warning : option '--relaxed-constexpr' has been deprecated and replaced by option '--expt-relaxed-constexpr'.
external/eigen_archive/unsupported/Eigen/CXX11/../../../Eigen/src/Core/arch/CUDA/PacketMathHalf.h(45):error: identifier "__half2half2" is undefined

external/eigen_archive/unsupported/Eigen/CXX11/../../../Eigen/src/Core/arch/CUDA/PacketMathHalf.h(53):error: identifier "__halves2half2" is undefined

... (several of these error messages)

external/eigen_archive/unsupported/Eigen/CXX11/../../../Eigen/src/Core/arch/CUDA/TypeCasting.h(100): error: identifier "__floats2half2_rn" is undefined

71 errors detected in the compilation of "/tmp/user/tmpxft_00002ecc_00000000-10_gru_ops_gpu.cu.compute_52.cpp1.ii".
ERROR: /users/user/Code/tensorflow/tensorflow/contrib/rnn/BUILD:73:1: output 'tensorflow/contrib/rnn/_objs/python/ops/_gru_ops_gpu/tensorflow/contrib/rnn/kernels/gru_ops_gpu.cu.pic.o' was not created.
ERROR: /users/user/Code/tensorflow/tensorflow/contrib/rnn/BUILD:73:1: not all outputs were created.
Target //tensorflow/tools/pip_package:build_pip_package failed to build
ERROR: /users/user/Code/tensorflow/tensorflow/tools/pip_package/BUILD:23:1 not all outputs were created.
INFO: Elapsed time: 12.422s, Critical Path: 11.16s

Sometimes another cc file triggers the error, like tensorflow/core/kernels/depthtospace_op_gpu.cu.cc

@gokceneraslan I can't reproduce the issue locally, so it's kind of a shot in the dark, but can you check if https://github.com/tensorflow/tensorflow/commit/0b730a0d9351a89bf0abff8b18ff382f4559d239 fixed the issue ?

No, it didn't fix it. But it seems there is something weird about my setup, because I also cannot reproduce it on another machine with same CUDA and cudnn.

Thanks for the update. I'm closing this issue.


[Pure K8S] Make Kubernetes supports CIFS

We may use Persistent Volume for Pure K8S based PAI as PAI default storage.
Current we use Samba to build AAD based storage, but CIFS is not supported by Kubernetes.
So we need to use plugin to let kubernetes support CIFS.

We do not use persistent volume currently, will investigate it later.


Master detail crud operation form creation difficulties .

Developers are getting very difficulties to create master detail crud operation in MVC
with detail table inline editing and bind with detailmodel.
So many customization and javascripting are required to complete the goal.
I have googled regarding this but still not getting satisfactory result.
If mentined feature or tag helper  available in mvc, it will be more fruitful and easy.
Thanks =D

Do you have a specific request or are you just asking for us to make it easier?

I am just requesting to development community to add feature or tag helper for master detail crud with inline editing table.

Scaffolding will at least give you support for CRUD operations. Check out https://docs.asp.net/en/latest/tutorials/first-mvc-app/index.html to get started.


Update drug_train_data_updated.csv

now this file can be opened properly in excel.

We're archiving this repo, please see https://github.com/IBM/monitor-wml-model-with-watson-openscale as an alternative


Asking to fill the password anytime

What version of Wallet are you using?
0.0.1
Steps to Reproduce

Expected Behavior
when you want to confirm a transaction it always asks for a password, that's very annoying in my opinion.
Actual Behavior
please remove this feature just once asking for a password.

Closing in favor of: https://github.com/FuelLabs/fuels-wallet/issues/244


where the setting that close the self-starting when the computer startup

where the setting that close the self-starting when the computer startup

Hi @xiguazhiPrince. AFAIK, we do not have such an option. Could you please tell me how you managed to achieve this? Thank.


Implementing permanent/persistent cookies in MSAL

Unable to set persistent/permanent cookie in MSAL 4.x
To Reproduce
Steps to reproduce the behavior:

Using this version of ASP.NET Core '2.2' and MSAL 4.2.1
Run this code
'services.AddAuthentication(AzureADDefaults.AuthenticationScheme)
.AddAzureAD(options => configuration.Bind("AzureAd", options))
.AddCookie(options =>
{
options.Events.OnSigningIn = (context) =>
{
context.CookieOptions.Expires =
DateTimeOffset.UtcNow.AddDays(10);
return Task.CompletedTask;
};
});'
Application generates session cookie for authentication

Expected behavior
Permanent/persistent should be generated instead of session cookie
Screenshots
NA
Additional context
We are in the process of upgrading ADAL to MSAL for stability reasons. We could set persistent cookie in ADAL using below code:
services.AddAuthentication(sharedOptions =>
{
sharedOptions.DefaultScheme = CookieAuthenticationDefaults.AuthenticationScheme;
sharedOptions.DefaultChallengeScheme = OpenIdConnectDefaults.AuthenticationScheme;
})
.AddAzureAd()
.AddCookie(options =>
{
options.Events.OnSigningIn = (context) =>
{
context.CookieOptions.Expires = DateTimeOffset.UtcNow.AddDays(_settings.CookieExpiryInDays);
return Task.CompletedTask;
};
});
Created an issue under MSAL repo as well (link below) but MS identity team suggested issue inside cookie middleware and asked to create issue here as well.
https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/issues/1340

We don't use MSAL so you're in the right place. You can't set the cookie options like this, it doesn't work as you've discovered. Instead you need to set the options on the Cookie middleware, with those you can either do sliding expiration or have a fixed timespan after which it vanishes, which appears to be what you want. By default it's 14 days.

Thanks @blowdart...will check and revert back

The referenced article explains on how to set the cookie options by implementing SignInAsync which is part of the RemoteAuthenticationHandler  class (line 140). You can modify the passed AuthenticationProperties by implementing the OnTicketReceivedHandler:
OnTicketReceived = context =>
{
    context.Properties.IsPersistent = true;
    context.Properties.ExpiresUtc = DateTimeOffset.UtcNow.AddDays(7);

    return Task.FromResult(0);
}

Thanks a lot @dennisbappert. It worked.


Macros: Augmenting a constructor doesn't copy over the default values.

Hello!
Consider the following code:
@override
FutureOr<void> buildDefinitionForClass(ClassDeclaration clazz, TypeDefinitionBuilder builder) async{
  final constructor = await builder.constructorsOf(clazz);

  final builder2 = await builder.buildConstructor(constructor.first.identifier);

  builder2.augment();
}

Then, given:
@Macro()
class DataClass {
  DataClass({this.b = 42});
...
}

This will generate:
augment class DataClass {
  augment DataClass({prefix0.int b, });
}

This generated code will fail, because the augmented constructor lacks a default value.

That looks correct. The augmentation itself should copy the default value (an augmenting function or constructor cannot declare a new default value, only the original declaration can declare the default values, as currently specified).
If the code doesn't work, then it's  the augmentation implementation that doesn't do what it should.

Interesting. Because at the moment, the augmenting constructor can define default values just fine.
We can generate augment DataClass(int a, {int b = 42}) and have no error.


[Feature Request] Add support for the sharpshooter feat

Would it be possible to add support for the Sharpshooter feat so that it ignores 1/2 and 3/4 cover for ranged attacks? I have a player in my game that has this feat, which makes the automatic mode inaccurate.

This is already included in Helpers 😃 . Check your special traits, about halfway down there is a checkbox for ignoring cover. As seen below.


chore: fix script to check code format

Signed-off-by: lowzj<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #714 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   47.43%   47.43%
=======================================
  Files         109      109
  Lines        6287     6287
=======================================
  Hits         2982     2982
  Misses       3072     3072
  Partials      233      233

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db52750...ddfcaf4. Read the comment docs.

LGTM.


spring-cloud-starter-azure-appconfiguration-config does not work with spring boot 2.4.0

AppConfig does not bootstrap in spring boot 2.4.0

@J4cku Hi, we know about the issue. We are working on a new release that will work with Spring Boot 2.4.0. We don't have an ETA at the moment but will update this issue with updates.

@J4cku 1.3.0 has been released and supports Spring Boot 2.4 https://mvnrepository.com/artifact/com.microsoft.azure/spring-cloud-azure-appconfiguration-config/1.3.0


Wireshark reports corrupted Frame Check Sequence for Mimas A7

Wireshark is reporting incorrect frame check sequence when using Gigabit Ethernet on Mimas A7.

RGMII interface is being used.
Autonegotiation succeeds at 1G
Mimas A7 tries to respond to ARP requests (or maybe broadcasts on its own) as seen in the screenshot below, but wireshark reports FCS as incorrect. Is it a severe issue or should not affect normal functioning?
Pings are failing.
Bootloader also requests for firmware (boot.bin) as shown in the screenshot below, but again the checksum is incorrect.

@enjoy-digital @mithro Any ideas what could be going wrong here? Maybe issues with RGMII signal delays? Problem is I don't have a spare USB-Serial module to attach a litescope to and probe the RGMII signals. The only USB-Serial interface on MimasA7 is being used for firmware/bootloader console.

I'm planning to debug it via Etherbone target + Litescope without CPU, so that I wouldn't need to use the only UART for console, instead I will use it for Litescope samples extraction. BTW is there any reason Etherbone target for Nexys_video uses 140 MHz sys clock? Should the sys clock frequency be >= 125 MHz (or some other reason), or is it just any random value?

@enjoy-digital Thanks! I'll take a look. Currently I'm trying to set up a litescope + etherbone design.
Apologies for not mentioning the code. It is here as part of the pull request: https://github.com/timvideos/HDMI2USB-litex-firmware/pull/447/commits/1dd165e8967e3b6f26087a24435f9e016c32917c

@enjoy-digital Did you mean for me to try with different phase values for the rx-clk (here: https://github.com/enjoy-digital/liteeth/blob/master/liteeth/phy/s7rgmii.py#L133) ?

You can try the etherbone design first and see what you get when you ping the board.
Then you can try to adjust the phase if it's not working.
If it's not working, i think it will be easier for you to debug with the CPU:

enable debug here: https://github.com/enjoy-digital/litex/blob/master/litex/soc/software/libnet/microudp.c#L13
disable hardware preamble/crc: https://github.com/enjoy-digital/liteeth/blob/master/liteeth/core/mac/init.py#L11 (this will allow you to see exactly with microudp traces what it should transmit and what it receives.)

@enjoy-digital Thanks for the great tips! The interesting thing is that etherbone design seems to be responding to pings. Here is the VCD dump for Ping request and response.
dump.zip

Maybe something is wrong with the TCP/IP stack. I'll try with enabling debug on uIP.

@enjoy-digital Sure, I'll try with enabling debug in microudp. I tried with serialboot till now. I'll try with tftp as per your recommendation. Pings were failing but I could see ARP and TFTP firmware request packets from boards in wireshark.
Thank you so much for all the help and great tips! It's been real life-saver! :)

@enjoy-digital It's working. Very weird. Last night I tried everything to get it working but it didn't. After following your structured steps for debugging it is now working without any issues and modifications! Thank you so much for your help! :)
Current Status

TFTP boot is working
Pings working
Telnet console is working

One more question: How do I use the etherbone interface of HDMI2USB firmware? I tried to use Litex server, which failed to read/write memory. Upon looking into the code, I found 2 interesting things, 1. Etherbone on HDMI2USB is implemented purely on software (which I was not expecting at all, ingenious idea!), 2. It uses TCP protocol, but Litex Server uses UDP protocol, so it wasn't working.
So, how do we actually use it? Is there any TCP client for Etherbone? cc: @mithro

I think it should simply work by doing in your script: wb = RemoteClient("<IP_ADDRESS>") :)
(just maybe also verify the port)

OMG, LOL. Indeed it works. Thanks @enjoy-digital ! :)
Closing this issue.


Add Adex Peru Institute

@LuiggiMontenegro Thank you for your patience while waiting for a review and processing your request. Pull request merged.

Thank you so much @philipto


Cloudformation six.moves.urllib_parse import error (probably should be six.moves.urllib.parse)

I am getting the following error while trying to use the cloudformation mock on Python 2.7 on Mac OS X Yosemite:
File "/Library/Python/2.7/site-packages/moto/cloudformation/responses.py", line 4, in <module>
    from six.moves.urllib_parse import urlparse
ImportError: cannot import name urlparse

On my own test code if I import from six.moves.urllib.parse (dot instead of underscore), it will work fine.

Thank you!


IE11 compatibility mode IE7 hashchange not work

I guess IE8+ compatibility mode IE7 also does not work.
The reason is that IE11 running in IE7 compatibility mode reports true for 'onhashchange' in window, even though the event isn't supported.

At first glance this looks to be an issue with IE11 and not backbone's handling of onhashchange.  Is it not?

Nah, it's because IE11 is bad at pretending to be IE7, which doesn't have onhashchange. We could add a Modernizer like test?

I can make a PR.


(fix) Remove hover menu obstruction when rename functionality is trig…

…gered

Coverage remained the same at 92.885% when pulling 792190d4f0133ff89ae22a0f0a071a92814102d5 on feature-socialmedia into 4ee700fc0a589ec8e1ae842e5c482432b2a7eb39 on develop.


replace concat of hook and index with hook qualifiers

https://github.com/Ticketfly/ember-hook#qualifiers

Make sure to use qualifier for index and selection.


Work on search and select tag while user types to add his tag

so when screeler typing to add a tag, there is not proposals list. what you have to do here is to hit the API (by passing already type string)  when screeler is typing to add a tag, to get the list of existing tags which match the string send to the API endpoint and propose it to screeler as drop down or collapse and he will be able to add a tag on tap it in the list.

i think this issue should be closed yeah?


validation-tests: define the MSVC runtime to use

This variable is needed to run the validation test suite on Windows.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please smoke test and merge


shortcut viewer for powertoys shortcuts

Description of the new feature / enhancement
A shortcut viewer, like "Shortcut Guide", but for the powertoys shortcuts
Scenario when this would be used?
When not remembering the potentially dozen or more shortcuts powertoys can introduce
Supporting information
No response

Hello and thanks for your message. When you click on the PT icon in the sys-tray, a fly-out will appear with clickable buttons. At the moment, it shows the hotkeys in a tooltip, but I have the idea to make them visible under the name.


How to donate you?

Thank you so much for really great project. I learnt a lot from your code.  Some newest pattern were difficult to understand but everything what you prepared is awesome. How can we donate you? :-)

@kmiskiewicz thanks for your kind words. Happy to hear that. :)
If you wanted to donate, I have just created a donation button from paypal at the bottom of this project's main page.
Thanks.

Done 👍

Thanks, appreciate that 👍


githubs-ssh-key-fingerprints should link to rest/meta

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints
What part(s) of the article would you like to see updated?
It might make sense to link to https://docs.github.com/en/rest/meta#get-github-meta-information and explain that it's related to ssh_key_fingerprints
Additional information
SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8 (RSA)
SHA256:p2QAMXNIC1TJYWeIOttrVc98/R1BUFWu3/LiyKgUfQM (ECDSA)
SHA256:+DiY3wvvV6TuJJhbpZisF/zLDA0zPMSvHdkr4UvCOqU (Ed25519)

  "ssh_key_fingerprints": {
    "SHA256_RSA": "nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8",
    "SHA256_DSA": "br9IjFspm1vxR3iA35FWE+4VTyz1hYVLIE2t1/CeyWQ",
    "SHA256_ECDSA": "p2QAMXNIC1TJYWeIOttrVc98/R1BUFWu3/LiyKgUfQM",
    "SHA256_ED25519": "+DiY3wvvV6TuJJhbpZisF/zLDA0zPMSvHdkr4UvCOqU"
  },

@jsoref Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

Thanks for this issue! You are anyone else is welcome to add this link to the docs.

T

K


Update Driver Sample Files for Patch 1.10.2

Description
Update Driver Sample Files for Patch 1.10.2
GitHub Issues
List the GitHub issues impacted by this PR:

GitHub Issue #

https://github.com/dell/csm/issues/1280

Checklist:

[x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[x] I have verified that new and existing unit tests pass locally with my changes
[x] I have not allowed coverage numbers to degenerate
[x] I have maintained at least 90% code coverage
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have maintained backward compatibility

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

[x] Test A
[ ] Test B

That was the scenario before but now we will be doing it in the same PR.


darwin: don't include cf-private in framework dependencies

Motivation for this change
Using cf-private can cause problems, it's better to include it
explicitly in places where it's actually required.
Fixes #49781
NOTE: this will break some things, a bit more testing is required.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Attempted: SDL, SDL2
Partial log (click to expand)
patching script interpreter paths in /nix/store/1706f3s31i1m72xycjg4lnjvwh10l2a2-SDL2-2.0.8
checking for references to /build in /nix/store/1706f3s31i1m72xycjg4lnjvwh10l2a2-SDL2-2.0.8...
shrinking RPATHs of ELF executables and libraries in /nix/store/5w0jysabsm92jbr93d2a0a4zv8amwp1h-SDL2-2.0.8-dev
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5w0jysabsm92jbr93d2a0a4zv8amwp1h-SDL2-2.0.8-dev/lib  /nix/store/5w0jysabsm92jbr93d2a0a4zv8amwp1h-SDL2-2.0.8-dev/bin
patching script interpreter paths in /nix/store/5w0jysabsm92jbr93d2a0a4zv8amwp1h-SDL2-2.0.8-dev
/nix/store/5w0jysabsm92jbr93d2a0a4zv8amwp1h-SDL2-2.0.8-dev/bin/sdl2-config: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/5w0jysabsm92jbr93d2a0a4zv8amwp1h-SDL2-2.0.8-dev...
/nix/store/ldqanhma1j9i73vscxif35hzgq2lk9k6-SDL-1.2.15
/nix/store/1706f3s31i1m72xycjg4lnjvwh10l2a2-SDL2-2.0.8

Success on x86_64-darwin (full log)
Attempted: SDL, SDL2
Partial log (click to expand)
/nix/store/8fyy3q8w783n63k8q2kxs5hb73p3lzyn-SDL-1.2.15/lib/libSDL-1.2.0.dylib: fixing dylib
/nix/store/8fyy3q8w783n63k8q2kxs5hb73p3lzyn-SDL-1.2.15/lib/libSDL-1.2.0.dylib: fixing dylib
/nix/store/8fyy3q8w783n63k8q2kxs5hb73p3lzyn-SDL-1.2.15/lib/libSDL-1.2.0.dylib: fixing dylib
gzipping man pages under /nix/store/kpiicihqqj7dy19ln4kkbrph7wrys5hc-SDL-1.2.15-dev/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kpiicihqqj7dy19ln4kkbrph7wrys5hc-SDL-1.2.15-dev/lib  /nix/store/kpiicihqqj7dy19ln4kkbrph7wrys5hc-SDL-1.2.15-dev/bin
patching script interpreter paths in /nix/store/kpiicihqqj7dy19ln4kkbrph7wrys5hc-SDL-1.2.15-dev
/nix/store/kpiicihqqj7dy19ln4kkbrph7wrys5hc-SDL-1.2.15-dev/bin/sdl-config: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/8fyy3q8w783n63k8q2kxs5hb73p3lzyn-SDL-1.2.15
/nix/store/qr49x1mndr48qayr6j9x9wm7l082qwg2-SDL2-2.0.8

Success on aarch64-linux (full log)
Attempted: SDL, SDL2, atomicparsley
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7vih3zfzylrzb37zdb3i6f6sh6hypdjd-atomicparsley-0.9.6
shrinking /nix/store/7vih3zfzylrzb37zdb3i6f6sh6hypdjd-atomicparsley-0.9.6/bin/AtomicParsley
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7vih3zfzylrzb37zdb3i6f6sh6hypdjd-atomicparsley-0.9.6/bin
patching script interpreter paths in /nix/store/7vih3zfzylrzb37zdb3i6f6sh6hypdjd-atomicparsley-0.9.6
checking for references to /build in /nix/store/7vih3zfzylrzb37zdb3i6f6sh6hypdjd-atomicparsley-0.9.6...
/nix/store/ldqanhma1j9i73vscxif35hzgq2lk9k6-SDL-1.2.15
/nix/store/1706f3s31i1m72xycjg4lnjvwh10l2a2-SDL2-2.0.8
/nix/store/7vih3zfzylrzb37zdb3i6f6sh6hypdjd-atomicparsley-0.9.6

Success on x86_64-linux (full log)
Attempted: SDL, SDL2, atomicparsley
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n2j1k002bvvj1vkzm1aapjxad61aaspr-atomicparsley-0.9.6
shrinking /nix/store/n2j1k002bvvj1vkzm1aapjxad61aaspr-atomicparsley-0.9.6/bin/AtomicParsley
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n2j1k002bvvj1vkzm1aapjxad61aaspr-atomicparsley-0.9.6/bin
patching script interpreter paths in /nix/store/n2j1k002bvvj1vkzm1aapjxad61aaspr-atomicparsley-0.9.6
checking for references to /build in /nix/store/n2j1k002bvvj1vkzm1aapjxad61aaspr-atomicparsley-0.9.6...
/nix/store/w6ayvanz3bjnydyqsnmdpgckq5a5hqz4-SDL-1.2.15
/nix/store/w5g8gcivvvi9binhmy6i34gi5b9g48yn-SDL2-2.0.8
/nix/store/n2j1k002bvvj1vkzm1aapjxad61aaspr-atomicparsley-0.9.6

Success on x86_64-darwin (full log)
Attempted: SDL, SDL2, atomicparsley
Partial log (click to expand)
/nix/store/8fyy3q8w783n63k8q2kxs5hb73p3lzyn-SDL-1.2.15/lib/libSDL-1.2.0.dylib: fixing dylib
/nix/store/8fyy3q8w783n63k8q2kxs5hb73p3lzyn-SDL-1.2.15/lib/libSDL-1.2.0.dylib: fixing dylib
gzipping man pages under /nix/store/kpiicihqqj7dy19ln4kkbrph7wrys5hc-SDL-1.2.15-dev/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kpiicihqqj7dy19ln4kkbrph7wrys5hc-SDL-1.2.15-dev/lib  /nix/store/kpiicihqqj7dy19ln4kkbrph7wrys5hc-SDL-1.2.15-dev/bin
patching script interpreter paths in /nix/store/kpiicihqqj7dy19ln4kkbrph7wrys5hc-SDL-1.2.15-dev
/nix/store/kpiicihqqj7dy19ln4kkbrph7wrys5hc-SDL-1.2.15-dev/bin/sdl-config: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/8fyy3q8w783n63k8q2kxs5hb73p3lzyn-SDL-1.2.15
/nix/store/qr49x1mndr48qayr6j9x9wm7l082qwg2-SDL2-2.0.8
/nix/store/n3vmdnxpla19ljl7h33g13hvnlqwqlww-atomicparsley-0.9.6

Success on aarch64-linux (full log)
Attempted: SDL, SDL2, atomicparsley, vim
The following builds were skipped because they don't evaluate on aarch64-linux: pinentry_mac
Partial log (click to expand)
to ~/.config/nixpkgs/config.nix.

these paths will be fetched (6.36 MiB download, 30.54 MiB unpacked):
  /nix/store/004qkskyals3hc6yy6y6c6wvi0vxzvcb-vim-8.1.0490
copying path '/nix/store/004qkskyals3hc6yy6y6c6wvi0vxzvcb-vim-8.1.0490' from 'https://cache.nixos.org'...
/nix/store/ldqanhma1j9i73vscxif35hzgq2lk9k6-SDL-1.2.15
/nix/store/1706f3s31i1m72xycjg4lnjvwh10l2a2-SDL2-2.0.8
/nix/store/7vih3zfzylrzb37zdb3i6f6sh6hypdjd-atomicparsley-0.9.6
/nix/store/004qkskyals3hc6yy6y6c6wvi0vxzvcb-vim-8.1.0490

Success on x86_64-darwin (full log)
Attempted: SDL, SDL2, atomicparsley, pinentry_mac, vim
Partial log (click to expand)
basename: invalid option -- 'w'
Try 'basename --help' for more information.
/nix/store/31h560p5ia8wv2lkp026lar8mpkdbm21-vim-8.1.0490/share/vim/vim81/tools/ref: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/31h560p5ia8wv2lkp026lar8mpkdbm21-vim-8.1.0490/share/vim/vim81/tools/vimm: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/31h560p5ia8wv2lkp026lar8mpkdbm21-vim-8.1.0490/share/vim/vim81/tools/vimspell.sh: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/8fyy3q8w783n63k8q2kxs5hb73p3lzyn-SDL-1.2.15
/nix/store/qr49x1mndr48qayr6j9x9wm7l082qwg2-SDL2-2.0.8
/nix/store/n3vmdnxpla19ljl7h33g13hvnlqwqlww-atomicparsley-0.9.6
/nix/store/2ip8n4f0r8rxaylq0ca4z21l7dlml948-pinentry-mac-0.9.4
/nix/store/31h560p5ia8wv2lkp026lar8mpkdbm21-vim-8.1.0490

Success on x86_64-linux (full log)
Attempted: SDL, SDL2, atomicparsley, vim
The following builds were skipped because they don't evaluate on x86_64-linux: pinentry_mac
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/p3q7il15fakcgmmql0df0ywrg1lrqknr-SDL2-2.0.8-dev
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p3q7il15fakcgmmql0df0ywrg1lrqknr-SDL2-2.0.8-dev/lib  /nix/store/p3q7il15fakcgmmql0df0ywrg1lrqknr-SDL2-2.0.8-dev/bin
patching script interpreter paths in /nix/store/p3q7il15fakcgmmql0df0ywrg1lrqknr-SDL2-2.0.8-dev
/nix/store/p3q7il15fakcgmmql0df0ywrg1lrqknr-SDL2-2.0.8-dev/bin/sdl2-config: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/p3q7il15fakcgmmql0df0ywrg1lrqknr-SDL2-2.0.8-dev...
/nix/store/w6ayvanz3bjnydyqsnmdpgckq5a5hqz4-SDL-1.2.15
/nix/store/w5g8gcivvvi9binhmy6i34gi5b9g48yn-SDL2-2.0.8
/nix/store/n2j1k002bvvj1vkzm1aapjxad61aaspr-atomicparsley-0.9.6
/nix/store/2p3nfi1xhiy4l3j6mw01zpyy5qjjvw7i-vim-8.1.0490

Success on aarch64-linux (full log)
Attempted: SDL, SDL2, atomicparsley, vim
The following builds were skipped because they don't evaluate on aarch64-linux: contacts, pinentry_mac
Partial log (click to expand)

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

/nix/store/ldqanhma1j9i73vscxif35hzgq2lk9k6-SDL-1.2.15
/nix/store/1706f3s31i1m72xycjg4lnjvwh10l2a2-SDL2-2.0.8
/nix/store/7vih3zfzylrzb37zdb3i6f6sh6hypdjd-atomicparsley-0.9.6
/nix/store/004qkskyals3hc6yy6y6c6wvi0vxzvcb-vim-8.1.0490

Success on x86_64-darwin (full log)
Attempted: SDL, SDL2, atomicparsley, contacts, pinentry_mac, vim
Partial log (click to expand)
post-installation fixup
strip is /nix/store/jicg9d0a282yzcig82308jf016iy4qk7-Toolchains/XcodeDefault.xctoolchain/bin/strip
stripping (with command strip and flags -S) in /nix/store/3b58rj8srw94gqfx4lcjsrmv18vy8v97-contacts-1.1a-3/bin
patching script interpreter paths in /nix/store/3b58rj8srw94gqfx4lcjsrmv18vy8v97-contacts-1.1a-3
/nix/store/8fyy3q8w783n63k8q2kxs5hb73p3lzyn-SDL-1.2.15
/nix/store/qr49x1mndr48qayr6j9x9wm7l082qwg2-SDL2-2.0.8
/nix/store/n3vmdnxpla19ljl7h33g13hvnlqwqlww-atomicparsley-0.9.6
/nix/store/3b58rj8srw94gqfx4lcjsrmv18vy8v97-contacts-1.1a-3
/nix/store/2ip8n4f0r8rxaylq0ca4z21l7dlml948-pinentry-mac-0.9.4
/nix/store/31h560p5ia8wv2lkp026lar8mpkdbm21-vim-8.1.0490

Success on x86_64-linux (full log)
Attempted: SDL, SDL2, atomicparsley, vim
The following builds were skipped because they don't evaluate on x86_64-linux: contacts, pinentry_mac
Partial log (click to expand)

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

/nix/store/w6ayvanz3bjnydyqsnmdpgckq5a5hqz4-SDL-1.2.15
/nix/store/w5g8gcivvvi9binhmy6i34gi5b9g48yn-SDL2-2.0.8
/nix/store/n2j1k002bvvj1vkzm1aapjxad61aaspr-atomicparsley-0.9.6
/nix/store/2p3nfi1xhiy4l3j6mw01zpyy5qjjvw7i-vim-8.1.0490

Success on x86_64-linux (full log)
Attempted: SDL, SDL2, atomicparsley, emacs, vim
The following builds were skipped because they don't evaluate on x86_64-linux: contacts, pinentry_mac
Partial log (click to expand)
copying path '/nix/store/ivmry7bh8ihiw1xqzzrb9fg1n2f5k5k0-m17n-lib-1.8.0' from 'https://cache.nixos.org'...
copying path '/nix/store/ar0k6fpylx2skacpj5ki45r6ni3q97vj-gdk-pixbuf-2.36.12' from 'https://cache.nixos.org'...
copying path '/nix/store/p4b0avnpcvvj6b108zba9j61fgir5b2k-gtk+3-3.22.30' from 'https://cache.nixos.org'...
copying path '/nix/store/x3kyz5r5xdnv9d7qqfpy6f750qshjp97-librsvg-2.42.4' from 'https://cache.nixos.org'...
copying path '/nix/store/4vcdiljhrsnl73yabsn56n0nprxf6g20-emacs-26.1' from 'https://cache.nixos.org'...
/nix/store/w6ayvanz3bjnydyqsnmdpgckq5a5hqz4-SDL-1.2.15
/nix/store/w5g8gcivvvi9binhmy6i34gi5b9g48yn-SDL2-2.0.8
/nix/store/n2j1k002bvvj1vkzm1aapjxad61aaspr-atomicparsley-0.9.6
/nix/store/4vcdiljhrsnl73yabsn56n0nprxf6g20-emacs-26.1
/nix/store/2p3nfi1xhiy4l3j6mw01zpyy5qjjvw7i-vim-8.1.0490

Success on x86_64-darwin (full log)
Attempted: SDL, SDL2, atomicparsley, contacts, emacs, pinentry_mac, vim
Partial log (click to expand)
stripping (with command strip and flags -S) in /nix/store/932r74r2m5yav4177bkl3nq69gj8jvfk-emacs-26.1/lib  /nix/store/932r74r2m5yav4177bkl3nq69gj8jvfk-emacs-26.1/libexec  /nix/store/932r74r2m5yav4177bkl3nq69gj8jvfk-emacs-26.1/bin
patching script interpreter paths in /nix/store/932r74r2m5yav4177bkl3nq69gj8jvfk-emacs-26.1
/nix/store/932r74r2m5yav4177bkl3nq69gj8jvfk-emacs-26.1/libexec/emacs/26.1/x86_64-apple-darwin16.3.0/rcs2log: interpreter directive changed from " /bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/8fyy3q8w783n63k8q2kxs5hb73p3lzyn-SDL-1.2.15
/nix/store/qr49x1mndr48qayr6j9x9wm7l082qwg2-SDL2-2.0.8
/nix/store/n3vmdnxpla19ljl7h33g13hvnlqwqlww-atomicparsley-0.9.6
/nix/store/3b58rj8srw94gqfx4lcjsrmv18vy8v97-contacts-1.1a-3
/nix/store/932r74r2m5yav4177bkl3nq69gj8jvfk-emacs-26.1
/nix/store/2ip8n4f0r8rxaylq0ca4z21l7dlml948-pinentry-mac-0.9.4
/nix/store/31h560p5ia8wv2lkp026lar8mpkdbm21-vim-8.1.0490

Success on aarch64-linux (full log)
Attempted: SDL, SDL2, atomicparsley, emacs, vim
The following builds were skipped because they don't evaluate on aarch64-linux: contacts, pinentry_mac
Partial log (click to expand)
shrinking /nix/store/nc277chky7jm7wajmns0b5s4g3vvl5lz-emacs-26.1/bin/.ctags-wrapped
shrinking /nix/store/nc277chky7jm7wajmns0b5s4g3vvl5lz-emacs-26.1/bin/.emacsclient-wrapped
shrinking /nix/store/nc277chky7jm7wajmns0b5s4g3vvl5lz-emacs-26.1/bin/.ebrowse-wrapped
shrinking /nix/store/nc277chky7jm7wajmns0b5s4g3vvl5lz-emacs-26.1/bin/.emacs-26.1-wrapped
gzipping man pages under /nix/store/nc277chky7jm7wajmns0b5s4g3vvl5lz-emacs-26.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nc277chky7jm7wajmns0b5s4g3vvl5lz-emacs-26.1/lib  /nix/store/nc277chky7jm7wajmns0b5s4g3vvl5lz-emacs-26.1/libexec  /nix/store/nc277chky7jm7wajmns0b5s4g3vvl5lz-emacs-26.1/bin
patching script interpreter paths in /nix/store/nc277chky7jm7wajmns0b5s4g3vvl5lz-emacs-26.1
/nix/store/nc277chky7jm7wajmns0b5s4g3vvl5lz-emacs-26.1/libexec/emacs/26.1/aarch64-unknown-linux-gnu/.rcs2log-wrapped: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/nc277chky7jm7wajmns0b5s4g3vvl5lz-emacs-26.1...

Success on x86_64-linux (full log)
Attempted: SDL, SDL2, atomicparsley, emacs, vim, xorg.xorgserver
The following builds were skipped because they don't evaluate on x86_64-linux: contacts, pinentry_mac, quartz-wm, xquartz
Partial log (click to expand)
patching script interpreter paths in /nix/store/l9k4dhdipc4zxmn2xqki97jidwvmk4jq-SDL2-2.0.9-dev
/nix/store/l9k4dhdipc4zxmn2xqki97jidwvmk4jq-SDL2-2.0.9-dev/bin/sdl2-config: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/l9k4dhdipc4zxmn2xqki97jidwvmk4jq-SDL2-2.0.9-dev...
copying path '/nix/store/4vcdiljhrsnl73yabsn56n0nprxf6g20-emacs-26.1' from 'https://cache.nixos.org'...
/nix/store/w6ayvanz3bjnydyqsnmdpgckq5a5hqz4-SDL-1.2.15
/nix/store/jlif2032zlf3r79a3fdrmgp3cqb16fqn-SDL2-2.0.9
/nix/store/n2j1k002bvvj1vkzm1aapjxad61aaspr-atomicparsley-0.9.6
/nix/store/4vcdiljhrsnl73yabsn56n0nprxf6g20-emacs-26.1
/nix/store/2p3nfi1xhiy4l3j6mw01zpyy5qjjvw7i-vim-8.1.0490
/nix/store/rx98jlf1vp4hmlpgjvpwqjcsnijz8nsg-xorg-server-1.19.6

Success on x86_64-darwin (full log)
Attempted: SDL, SDL2, atomicparsley, contacts, emacs, pinentry_mac, quartz-wm, vim, xorg.xorgserver, xquartz
Partial log (click to expand)
/nix/store/8fyy3q8w783n63k8q2kxs5hb73p3lzyn-SDL-1.2.15
/nix/store/d01ir5w0as1xc29zskgx0hrzlr4izwvb-SDL2-2.0.9
/nix/store/n3vmdnxpla19ljl7h33g13hvnlqwqlww-atomicparsley-0.9.6
/nix/store/3b58rj8srw94gqfx4lcjsrmv18vy8v97-contacts-1.1a-3
/nix/store/932r74r2m5yav4177bkl3nq69gj8jvfk-emacs-26.1
/nix/store/2ip8n4f0r8rxaylq0ca4z21l7dlml948-pinentry-mac-0.9.4
/nix/store/mnk9mx5s2p5rdrlzi4zmy9vvk5078znh-quartz-wm-1.3.1
/nix/store/31h560p5ia8wv2lkp026lar8mpkdbm21-vim-8.1.0490
/nix/store/03v0g1mw6fjzc9vwamdi86a00ipiy801-xorg-server-1.18.4
/nix/store/vf77j4vimcdg2vz5rjcsz45czm1gvg4i-xquartz-1.18.4

I think this is mostly ready now, I'll keep an eye on hydra.

Most of the regressions should be fixed. I'll try to look into adding the missing parts to https://github.com/apple/swift-corelibs-foundation, then we can get rid of those cf-private workarounds.


fix(docs): Updated README.md

Added "The Problem" and "The Solution" to README.MD
README.MD now has headers The Problem and The Solution with relevant information from the YouTube video "React Email Final Demo | Google Summer of Code 2022 | GSoC'22 | SCoRe Lab - Leopards Lab"

Ahhh! forgot to fix the yarn prettier issue. going to fix that now...

@Logan-kwan how you fix that yarn prettier issue, its showin me error

i tried to separate the paragraph i wrote using line breaks; i'm not sure if that solved the issue, though.


Make Simple use iceCheckingTimeout

Currently, UA uses a sensible default iceCheckingTimeout: 5000.
However, as Simple overrides sessionDescriptionHandlerFactoryOptions, it loses
this default value and as a result does not use any iceCheckingTimeout.
This also adds a test to check the default options used by Simple.

NOTE : the same issue affects any UA which is created with a sessionDescriptionHandlerFactoryOptions. An alternative fix would be to move the default iceCheckingTimeout inside WebRTC/SessionDescriptionHandler, and ask users to explicitly set iceCheckingTimeout to 0 if they want to disable it.
What's your preference Eric?

An alternative fix would be to move the default iceCheckingTimeout inside WebRTC/SessionDescriptionHandler, and ask users to explicitly set iceCheckingTimeout to 0 if they want to disable it.

That seems ideal here

In that case I think we can collapse peerConnectionOptions to {}:
https://github.com/onsip/SIP.js/blob/49c6ac45b673e9f8c490b8aa27041eb70ace8d48/src/UA.js#L935
rtcConfiguration is initialised to {} if absent:
https://github.com/onsip/SIP.js/blob/49c6ac45b673e9f8c490b8aa27041eb70ace8d48/src/WebRTC/SessionDescriptionHandler.js#L347
I haven't checked but we can possibly even remove peerConnectionOptions altogether, and possibly constraints too.

Woops, not good, I'm adding the option in the wrong place

OK, fixed, it now works as expected


commit squashing

Any reason why my contribution commits for (rust recipes) were squashed?  It no longer lists me as a contributor.

I do not know where it got lost, however I almost certainly personally made the change and I'd like to apologize.
I have removed the ability to squash in the github interface and rewritten our release process to use FF-only merges to prevent this and other issues.
We will be publishing our release process changes for transparency in the near future.


Linker failure: undefined reference to `adjtime'

Trying to work up a full NTP (not SNTP) implementation, which requires adjtime() to smoothly change the system clock.
I have a function prototype in time.h, but there doesn't appear to be a function definition anywhere.
I can probably write my own adjtime, but am I just missing how to include the definition?

Currently only gettimeofday and settimeofday are implemented. The most basic implementation of adjtime could fall back to settimeofday. Ideas on how to implement gradual adjustment specified by adjtime are welcome.

I need a smooth time adjustment for my application.
It looks like two reasonable approaches would be either:

Adjust the boot time register (potentially only upon calls to get_boot_time)

Add some additional logic to the frc_timer_isr() to periodically adjust the s_microseconds upon ticking.

I'm going to think about this some more, but I think the best bet may be to replace this line:
s_microseconds += FRC1_ISR_PERIOD_US;
in the ISR with something like this, conceptually:
s_microseconds += frc1_isr_period_adjust;
s_accumulated_offset += (frc1_isr_period_adjust - FRC1_ISR_PERIOD_US);
if( abs(s_accumulated_offset) > s_target_offset)  frc1_isr_period_adjust = FRC1_ISR_PERIOD_US;

So the adjtime function would set s_accumulated_offset to 0, and frc1_isr_period_adjust to some value, and then the isr would do the work.   Since this gets called every ~1.6 seconds and if we're targeting a Linux-like shift of about 85 seconds per second, that's typically +/- 20ms in each ISR call we're adding or removing.
Because the timestep happens only every 1.6 seconds, that could be hugely disruptive to time sensitive things, but would be OK in my application.

The mod to get_boot_time would need to store a start time, potentially a rate, and a total amount of time to adjust.   Upon each call, it would apply a proportional amount of the adjustment to the return value.   If the complete adjustment is done, it would adjust the boot_time registers to match the new base time.
This would have the advantage of being easily over-written by settimeofday, and not affect system_get_time.
It also has no overhead except that it slows down get_boot_time by the time needed to calculate the offset (while slewing).
I think I'm taking option 1 unless you see some particular danger in either of these approaches.   I'll post my solution, of course.

Keep in mind that s_microseconds variable is only used when both FRC1 and RTC timers are used for timekeeping. Adjustments to s_microseconds also don't carry over deep sleep. For this reason I think that adjusting boot time might be a better approach.

Good call on the deep sleep.   Here's my initial implementation, but is untested at the moment.  I'll issue as a PR once I have some basic testing.  Added adjtime function and modified get_boot_time
Presently ignoring the outdelta, in adjtime, but that would be fairly easy to add.
`// adjtime_start stores the start time of the slew
// adjtime_total is how many microseconds total to slew
// Maximum is 2^31 microseconds, or about 35 minutes.
// Typically 500,000 microseconds max for NTP
// Rate is the speed at which we add data.
// Unix typical rate is 85 seconds per second
// 6 = 64 seconds per second
// 7 = 128 seconds per second
static uint64_t adjtime_start = 0;
static int32_t adjtime_total = 0;
#define ADJTIME_RATE 7
// Adjtime takes two timeval structs
// delta is the tv to add or subtract from the clock
// outdelta is a way to find out where we are in the process (currently unsupported)
int adjtime(const struct timeval *delta, struct timeval *outdelta)
{
if(delta == NULL)
return 0;
if(llabs((delta.tv_sec * 1000000UL + delta.tv_usec)) > INT_MAX)
return -1;
adjtime_start = get_time_since_boot();
adjtime_total = (delta.tv_sec * 1000000UL + delta.tv_usec);
}
static uint64_t get_boot_time()
{
uint64_t result;
int64_t adjustment;
_lock_acquire(&s_boot_time_lock);
#ifdef WITH_RTC
result = ((uint64_t) REG_READ(RTC_BOOT_TIME_LOW_REG)) + (((uint64_t) REG_READ(RTC_BOOT_TIME_HIGH_REG)) << 32);
#else
result = s_boot_time;
#endif
_lock_release(&s_boot_time_lock);
if(adjtime_start > 0)
{
  adjustment = (get_time_since_boot() - adjtime_start) >> ADJTIME_RATE;
  if(adjtime_total < 0)
  {
    if(adjustment <= adjtime_total)
    {
      result = result + adjtime_total;
      set_boot_time(result);
      adjtime_start = 0;
    }
    else
    {
      result -= adjustment;
    }
  }
  else // if adjtime_total = 0 this also fires, but that's an infrequent case.
  {
    if(adjustment >= adjtime_total)
    {
      result = result + adjtime_total;
      set_boot_time(result);
      adjtime_start = 0;
    }
    else
    {
      result += adjustment;
    }
  }
}

return result;

}
#endif //defined(WITH_RTC) || defined(WITH_FRC1)
`

OK, Github desktop doesn't seem to want to issue the PR, maybe I'm doing it wrong.   Here's the block of changes, this is tested a bit but not totally thoroughly, so there may be corner problems:
#if defined(WITH_RTC) || defined(WITH_FRC1)
static void set_boot_time(uint64_t time_us)
{
    _lock_acquire(&s_boot_time_lock);
#ifdef WITH_RTC
    REG_WRITE(RTC_BOOT_TIME_LOW_REG, (uint32_t) (time_us & 0xffffffff));
    REG_WRITE(RTC_BOOT_TIME_HIGH_REG, (uint32_t) (time_us >> 32));
#else
    s_boot_time = time_us;
#endif
    _lock_release(&s_boot_time_lock);
}

static uint64_t get_time_since_boot(); // FIXME: Is there a better way to do this?

// adjtime_start stores the start time of the slew
// adjtime_total is how many microseconds total to slew
// Maximum is 2^31 microseconds, or about 35 minutes.
// Typically 500,000 microseconds max for NTP
// Rate is the speed at which we add data.
// Unix typical rate is 85 seconds per second
// 6 = 64 seconds per second
// 7 = 128 seconds per second
// Caveats:
// 1. time adjustment progress does not survive deep sleep, but a completed adjustment does.
// 2. keep time adjustments shortish, 35 minutes would take 74 hours to adjust.
static uint64_t adjtime_start = 0;
static int32_t adjtime_total = 0;
#define ADJTIME_RATE 7

// Adjtime takes two timeval structs
// delta is the tv to add or subtract from the clock
// outdelta is a way to find out where we are in the process (currently unsupported)
// Trivial example:
//
//    struct timeval delta;
//
//    delta.tv_sec = -1;
//    delta.tv_usec = 0;
//
//    adjtime(&delta,NULL);
// This removes 1 second from the clock.
//
int adjtime(const struct timeval *delta, struct timeval *outdelta)
{
  if(delta == NULL)
    return 0;

  if(llabs((delta->tv_sec * 1000000L + delta->tv_usec)) > INT_MAX)
    return -1;

  adjtime_start = get_time_since_boot();
  adjtime_total = (delta->tv_sec * 1000000L + delta->tv_usec);

  return 0;
}

static uint64_t get_boot_time()
{
    uint64_t result;
    int64_t adjustment;
    _lock_acquire(&s_boot_time_lock);
#ifdef WITH_RTC
    result = ((uint64_t) REG_READ(RTC_BOOT_TIME_LOW_REG)) + (((uint64_t) REG_READ(RTC_BOOT_TIME_HIGH_REG)) << 32);
#else
    result = s_boot_time;
#endif
    _lock_release(&s_boot_time_lock);

    if(adjtime_start > 0)
    {
      adjustment = (get_time_since_boot() - adjtime_start) >> ADJTIME_RATE;
      if(adjtime_total < 0)
      {
        if(adjustment >= -adjtime_total)
        {
          result = result + adjtime_total;
          set_boot_time(result);
          adjtime_start = 0;
        }
        else
        {
          result -= adjustment;
        }
      }
      else // if adjtime_total = 0 this also fires, but that's an infrequent case.
      {
        if(adjustment >= adjtime_total)
        {
          result = result + adjtime_total;
          set_boot_time(result);
          adjtime_start = 0;
        }
        else
        {
          result += adjustment;
        }
      }
    }

    return result;
}
#endif //defined(WITH_RTC) || defined(WITH_FRC1)

@benpeoples Hi, sorry to get back to you after so long. Does your issue still exist? Thanks.

@Alvin1Zhang This issue has been resolved!  It appears that this patch (written a little more cleanly and with more documentation) is now in time.c
Thank you!


Get translation strings from *.html

When using partial html templates translation command does not extract strings from *.html. This PR will fix it.

Great, thanks!


support deadletter config

Hello,
I hope to use ecschedule on my production workload, but DeadLetter Config parameters are not supported.
https://docs.aws.amazon.com/eventbridge/latest/userguide/eb-rule-dlq.html
Add support to DeadLetterConfig into Target Parameter.
I would appreciate your review.
Thank you.

Thank you! Released as v0.4.0. https://github.com/Songmu/ecschedule/releases/tag/v0.4.0

Thanks you!!


Generalize environment variables by adding a config file to simplify azure, and all other, special builds

Currently we have special conditionals, and a separate build process for the azure initiative. Instead of hard-coding all new environments in the ui, we would like to generalize and simplify this by having a dedicated config file that explicitly specifies the params of the environment it which the ui running. The config file will be part of the regular ui build:
/index.html
/x.x.x/build.js
/x.x.x/styles.css
/x.x.x/env.json <<<<<

The ui will load env.json at startup into a singleton available to the app, and the params will be accessed by the relevant code that needs them (aka connect() and fundAccount()). The minimum params known to be needed at this point are:
{
   webSocketURL: http://<IP_ADDRESS>:8546,
   gethNodeURL: http://<IP_ADDRESS>:8545,
   contracts: { object of all contract addresses },
   fundAccount: {
      address: DS2D...XDOI,
      amount: 5
   }
}

Using this strategy we can get rid of:

special azure build
process.env.*
search & replace of params
specialized conditionals hard-coded in connect() and fund()

complete in 2f64506c6c5ad8d26765cd05d348a8408f7a509b
@kevinday with this in place, you should be able to generate an env.json with azure-specific values during deployment.


Feat: delete mode for geojson editable layers

Pull Request Description
Issue
There is currently no way to delete features from a FeatureCollection via user interaction.
Solution
Introduce a DeleteMode class that extends GeoJsonEditMode. This mode will:

Handle user clicks to identify and remove the selected feature(s) from the FeatureCollection.
Trigger an onEdit callback to update the collection in the application state.

Implementation

delete-mode.ts: Implement the DeleteMode class.
delete-mode.test.ts: Add unit tests to ensure correct functionality.

This will enable users to manage their data more effectively by removing unwanted features.

https://visgl.github.io/deck.gl-community/docs/CONTRIBUTING#fixing-ci-issues