Rethink chains

Total restructure chains design.

[x] Support smart-scheduling. Pass only declares family on which it supposed to be executed. Scheduler will try to find best queue in the family
[x] Make link to be collection of passes instead of single pass. Passes are collected into link as long as they all are able to use associated resource in parallel.
Some links are limited to contain passes from only single queue. So they can perform resource ownership transfer.
[x] Find semaphores and barriers required.
[x] Optimize semaphores.
[x] Prepare structures for command recoding and submitting.

This change is

Reviewed 21 of 21 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 12 of 13 files at r2.
Review status: 19 of 20 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Looks OK code wise, but I have no idea how to actually use the crate since there are no examples :)

@Rhuagh I guess I need to add examples to all those new crates :smile:

Reviewed 3 of 24 files at r1, 3 of 13 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

src/collect.rs, line 20 at r3 (raw file):

/// Placeholder for synchronization type.
pub struct UnSynchronized;

This is a single word, so it should be Unsynchronized.

src/collect.rs, line 69 at r3 (raw file):

        // Find passes that are ready to be enqueued
        // E.g. All dependencies are enqueued.
        enqueued.sort();

Can this be done only once, before the loop?

src/collect.rs, line 85 at r3 (raw file):

                (fitness, qid, index)
            })
            .min()

I think I'm not having the whole picture here, because it seems to me you could just sort these. Or what exactly changes during this loop?

src/pass.rs, line 25 at r3 (raw file):

    /// Dependencies of the pass.
    /// Those are indices of other passes in array.
    pub dependencies: Vec<usize>,

If you keep these dependencies sorted, the comparison (all_there) could be O(n) by just comparing element for element.

Comments from Reviewable

I really like it :+1: :+1:

Reviewed 10 of 24 files at r1, 8 of 13 files at r2.
Review status: all files reviewed at latest revision, 11 unresolved discussions.

src/resource/mod.rs, line 27 at r3 (raw file):

/// Defines resource type.
/// Should be implemented for buffers and images.
pub trait Resource: Copy + Debug + Eq + Ord + Hash {

Why did you add all these bounds given that the implementors below don't even have values?

src/schedule/family.rs, line 42 at r3 (raw file):

    /// This function will panic if requested queue isn't part of this family.
    ///
    pub fn get_queue(&self, qid: QueueId) -> Option<&Queue<S>> {

queue

src/schedule/family.rs, line 53 at r3 (raw file):

    /// This function will panic if requested queue isn't part of this family.
    ///
    pub fn get_queue_mut(&mut self, qid: QueueId) -> Option<&mut Queue<S>> {

queue_mut

src/schedule/family.rs, line 79 at r3 (raw file):

    /// This function will panic if requested submit isn't part of this family.
    ///
    pub fn get_submit(&self, sid: SubmitId) -> Option<&Submit<S>> {

submission

src/schedule/family.rs, line 91 at r3 (raw file):

    /// This function will panic if requested submit isn't part of this family.
    ///
    pub fn get_submit_mut(&mut self, sid: SubmitId) -> Option<&mut Submit<S>> {

submission_mut

src/schedule/family.rs, line 98 at r3 (raw file):

}

impl<S> Index<QueueId> for Family<S> {

Not sure about adding multiple Index operators to the same type, contributes little to code readability.

src/schedule/submit.rs, line 42 at r3 (raw file):

/// This type corresponds to commands that should be recorded into single primary command buffer.
#[derive(Clone, Debug)]
pub struct Submit<S> {

Maybe Submission?

Comments from Reviewable

Review status: all files reviewed at latest revision, 11 unresolved discussions.

src/collect.rs, line 20 at r3 (raw file):
Previously, torkleyy (Thomas Schaller) wrote…
This is a single word, so it should be Unsynchronized.

I should teach my Visual Studio Code some English then :smile:
It marks Unsynchronized as grammar error.
Firefox does the same. Hmm...

src/collect.rs, line 69 at r3 (raw file):
Previously, torkleyy (Thomas Schaller) wrote…
Can this be done only once, before the loop?

Before the loop it is empty.
And here the mistake.
I forgot to push the index there for each scheduled pass :smile:

src/collect.rs, line 85 at r3 (raw file):
Previously, torkleyy (Thomas Schaller) wrote…
I think I'm not having the whole picture here, because it seems to me you could just sort these. Or what exactly changes during this loop?

Result of fitness depends on passes scheduled before. So it may change for each round of the loop.

src/pass.rs, line 25 at r3 (raw file):
Previously, torkleyy (Thomas Schaller) wrote…
If you keep these dependencies sorted, the comparison (all_there) could be O(n) by just comparing element for element.

That's why I sort enqueued! Probably I got distracted and forgot it at some point.

src/resource/mod.rs, line 27 at r3 (raw file):
Previously, torkleyy (Thomas Schaller) wrote…
Why did you add all these bounds given that the implementors below don't even have values?

To use derive for Id<R> and State<R>.
I know Derivative can handle this as well.

src/schedule/family.rs, line 98 at r3 (raw file):
Previously, torkleyy (Thomas Schaller) wrote…
Not sure about adding multiple Index operators to the same type, contributes little to code readability.

It removes many unwraps.

src/schedule/submit.rs, line 42 at r3 (raw file):
Previously, torkleyy (Thomas Schaller) wrote…
Maybe Submission?

Probably. Especially since this type now corresponds more to gfx_hal::queue::Submission more than to gfx_hal::command::Submit.

Comments from Reviewable

I hope it'll work :laughing:

Review status: all files reviewed at latest revision, 11 unresolved discussions.

Comments from Reviewable

Getters are still using nonstandard style (get_foo instead of foo), looks good otherwise.

Reviewed 2 of 14 files at r2, 3 of 12 files at r4.
Review status: 11 of 20 files reviewed at latest revision, 9 unresolved discussions.

src/collect.rs, line 20 at r3 (raw file):
Previously, omni-viral (Zakarum) wrote…
I should teach my Visual Studio Code some English then :smile:
It marks Unsynchronized as grammar error.
Firefox does the same. Hmm...

According to dictionary.com it's a valid word: http://www.dictionary.com/browse/unsynchronized

src/collect.rs, line 85 at r3 (raw file):
Previously, omni-viral (Zakarum) wrote…
Result of fitness depends on passes scheduled before. So it may change for each round of the loop.

OK, and yeah enqueued changes which I didn't know before.

src/collect.rs, line 109 at r4 (raw file):

}

fn all_there(all: &[PassId], there: &[PassId]) -> bool {

The optimization is still TODO here

src/resource/mod.rs, line 27 at r3 (raw file):
Previously, omni-viral (Zakarum) wrote…
To use derive for Id<R> and State<R>.
I know Derivative can handle this as well.

Hm, it's pretty confusing. I think derivative would indeed be better here. Maybe even a note above that this should be implemented for phantom types only.

Comments from Reviewable

It looks like the concerns I brought up on Gitter are resolved too. :D

Getters are still using nonstandard style (get_foo instead of foo)

Now they're not.

Review status: 11 of 20 files reviewed at latest revision, 8 unresolved discussions.

src/collect.rs, line 20 at r3 (raw file):
Previously, torkleyy (Thomas Schaller) wrote…
According to dictionary.com it's a valid word: http://www.dictionary.com/browse/unsynchronized

Done.

src/schedule/family.rs, line 42 at r3 (raw file):
Previously, torkleyy (Thomas Schaller) wrote…
queue

Done.

src/schedule/family.rs, line 53 at r3 (raw file):
Previously, torkleyy (Thomas Schaller) wrote…
queue_mut

Done.

Comments from Reviewable

Reviewed 1 of 14 files at r2, 9 of 12 files at r4.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable


Replace FormattingLogger with Flogger library [phab:D2256]

Created by schroederc at 2018-04-17 17:51:06:

zarko accepted this revision at 2018-04-17 17:54:39

schroederc wrote at 2018-04-17 17:55:35:
We need the Flogger Bazel targets to become visible

danielmoy-google commented inline (context lost during migration) at 2018-04-17 18:03:24:
Not strictly migration-related, but it is it worth emitting all these in a single log statement, instead of inside a loop (since the log I/O might be interleaved with other stuff then)?

danielmoy-google commented inline (context lost during migration) at 2018-04-17 18:03:24:
Probably wanna do this using .withCause() instead of passing the message directly

danielmoy-google commented inline (context lost during migration) at 2018-04-17 18:03:24:
(ditto down here)

jrtom commented inline (context lost during migration) at 2018-04-17 22:06:18:
How does this relate to this change?  I don't see any places we're using this, but maybe I'm missing something.

jrtom wrote at 2018-04-17 22:06:18:
This is awesome, I've been waiting for Flogger to get released for a long time.  :)
One high-level comment: do we need to be depending on the system_backend target?  I would think that the "api" target should suffice.
    "com_google_common_flogger//api",
    "com_google_common_flogger//api:system_backend",

(David Beaumont says: "Yes, the system backend is the bit that selects the backend. Make it a runtime dep on the binary. Not everyone needs it.")

schroederc wrote at 2018-04-20 20:02:16:
Update Flogger to usable version

schroederc commented inline (context lost during migration) at 2018-04-20 20:03:52:
It's a Flogger dependency.

schroederc commented inline (context lost during migration) at 2018-04-20 20:03:52:
I don't think so.  It'll be easy to isolate this log line from others and it's more of a pain to parse a log line that's the result of concatenation.

schroederc closed via commit 88c74aaa1b87163e2780e3b31b5e7c28e9910cd2 at 2018-04-20 20:04:54


User interaction

I love this project! Very well thought out and implemented. While working with the interactive samples, I could not tell if uservariable and slider are available for any pstricks code, or if they are hard-coded to only work with mouse ( for psline ) or psplot. i.e. Could I get users choice via html/javascript input to control location of psline?

currently it's tied to mouse... but this is a great point! I will document the code here in this issue best I can in attempt to help create a feature for this.
uservariable and userline
in the pspicture environment definition,  here are the touch/mouse movements in the source, producing userEvents:
https://github.com/pyramation/LaTeX2JS/blob/master/packages/latex2js-pstricks/src/lib/psgraph.js#L513-L530

userline:  https://github.com/pyramation/LaTeX2JS/blob/master/packages/latex2js-pstricks/src/lib/psgraph.js#L564
uservariable: https://github.com/pyramation/LaTeX2JS/blob/master/packages/latex2js-pstricks/src/lib/psgraph.js#L540

It basically just re-renders everything on each userEvent (touch/mouse movement)
slider
slider is really it's own component that gets injected:

react: https://github.com/pyramation/LaTeX2JS/blob/master/packages/latex2react/src/components/slider.js
html5: https://github.com/pyramation/LaTeX2JS/blob/master/packages/latex2html5/src/components/pspicture.js#L27

One application of having access to points in the pspicture could be that the user could modify it through the DOM interface. Another could be to create an animation where the variable changes based on a timer.


dashboard log animation slower than results

text in logMessageBox (animated) is slower than creation and viewing charts.
change logMessageBox to classic loading animation that is hidden when charts are visible?

Won't fix


Unclear if Serialization is Correct

Hello, I have integrated L8W8JWT into a project I am working on, and I do not believe I am seeing a properly encoded JWT (using https://jwt.io/):

Context: My project already has a version of mbedtls, but the version maintained is mbed TLS 2.27.0. Released: 2021-07-07. I have found a relatively old commit of L8W8JWT that targets mbedtls before the 3.0 migration and have been using that commit as the basis for my development.
From using jwt.io, the encoding inserts a backslash when it shouldn't. This appears to be the scope of https://github.com/GlitchedPolygons/l8w8jwt/issues/25, which was fixed in 2.1.5.
I bumped the tag of L8W8JWT to 2.1.6 and manually reverted encode/decode.c (to remain compatible w/ 2.27.0 mbedtls) as well as the relevant CMakeLists.txt. However, with both L8W8JWT versions, I am seeing this encoding output.
I don't believe neither mbedtls nor encode.c are relevant of converting data into an encoded JWT  (they are primarily used to sign the payload, correct?); it appears that the payload conversion functionality resides in chillbuff.h, claim.c, and base64.c.
Is there something else I'm missing, or is this how the encoding actually appears after everything is said and done?

Should have done a bit more due diligence on my part, my payloads were also failing when using the example encoding. Using a compile-time sizeof() includes the null terminator and messes up the encoding, while strlen does not 😉


Added webpack installation step to README

adding this installation step will eliminate possible confusion for gem users -> they won't miss installing webpack during initial setup

@beniutek merged, thanks!


After long wait, available token counter becomes negative

I noticed that, at least with some bandwidth configuration, when a long time passes between subsequent calls to Bucket.tryConsume(...), the available token counter becomes negative and Bucket.tryConsume(...) return false, while there should be lots of tokens available.
I guess this could be caused by an arithmetic overflow in executing line 136
        long divided = refillTokens * durationSinceLastRefillNanos + roundingError;
in private method io.github.bucket4j.BucketState.refill(int, Bandwidth, long, long).
To reproduce the problem, you can use the following test:
import java.time.Duration;

import org.junit.Test;

import io.github.bucket4j.Bandwidth;
import io.github.bucket4j.Bucket;
import io.github.bucket4j.Bucket4j;
import io.github.bucket4j.TimeMeter;

import static org.junit.Assert.assertTrue;

public class LongWaitTest {

    private final class TimeMeterWithArtificialDelay
            implements TimeMeter {
        private static final long serialVersionUID =<PHONE_NUMBER>74660314L;

        final long twelveHourNanos = 12 * 60 * 60 * 1_000_000_000L;
        private long delay = 0L;

        @Override
        public long currentTimeNanos() {
            return TimeMeter.SYSTEM_MILLISECONDS.currentTimeNanos() + delay;
        }

        void let12HoursPass() {
            delay = twelveHourNanos;
        }
    }

    @Test
    public void whenALongTimePassesThenAvailableTokensCounterBecomesNegative() throws InterruptedException {
        final Bandwidth limit1 = Bandwidth.simple(700000, Duration.ofHours(1));
        final Bandwidth limit2 = Bandwidth.simple(14500, Duration.ofMinutes(1));
        final Bandwidth limit3 = Bandwidth.simple(300, Duration.ofSeconds(1));
        final TimeMeterWithArtificialDelay customTimeMeter = new TimeMeterWithArtificialDelay();
        final Bucket bucket = Bucket4j.builder()
                .addLimit(limit1)
                .addLimit(limit2)
                .addLimit(limit3)
                .withCustomTimePrecision(customTimeMeter)
                .build();

        assertTrue(bucket.getAvailableTokens() > 0);
        assertTrue(bucket.tryConsume(1));

        customTimeMeter.let12HoursPass();

        assertTrue("Free tokens expected after long wait", bucket.getAvailableTokens() > 0);
        assertTrue("Free tokens expected after long wait", bucket.tryConsume(1));
    }

}

long divided = refillTokens * durationSinceLastRefillNanos + roundingError;

Yes, you properly detected the source of problem. I will release the fix in few days.

Which version do you use?

I am using bucket4j-core 2.1.0 and bucket4j-jcache 2.1.0.

Looks like with your limits bucket will work normally only for 1,3 hours between invokation
public static void main(String[] args) {
        double d = Long.MAX_VALUE;
        System.out.println(d  / (700000L * 1_000_0000_000L * 3600L));
    }

.
In this variant bucket will survive after 423 hours of inactivity:
final Bandwidth limit1 = Bandwidth.classic(700000, Refill.smooth(7, Duration.ofMillis(36)));
final Bandwidth limit2 = Bandwidth.classic(14500, Refill.smooth(15, Duration.ofMillis(60)));
final Bandwidth limit3 = Bandwidth.simple(300, Duration.ofSeconds(1));

@MichelePaterniti please use 2.1.1(or 3.0.2) version.

Thanks for the promptness of your fix.
It took us some time to integrate it and to run all tests and checks, but now it is in production and it is working fine.


fix: OerInputStream and OerOutputStream improvements

Hi,
I made a few changes to the OER input and output streams, and cleaned up some formatting that was causing checkstyle to complain.
For make reviewing somewhat sane I split the changes:
commit 4195244 - style + javadoc fixes exclusively.
commit 4fc0acc - OER stream fixes and tests.
All feedback appreciated.

@andrew-g-za: Build is green, so commit away!


Cosmetics in "Add schema"

Cosmetic stuff ..
When I don't have a schema and click "Add schema", then the default for file-name is "openFileDialog1"
When there is already a schema, the path and name is displayed, but it runs partially out of the edit-field on the left side.

Good bug with the "openFileDialog1", but I think your second point you are just seeing normal text field horizontal scrolling when the path is too long to fit given the size of the dialog.  You can resize the dialog, or scroll the field using mouse selection, or arrow keys when the field has keyboard focus.

"openFileDialog1" fixed in version <IP_ADDRESS>.

It's not caused by long paths - see here with a short path:
https://autode.sk/3oTopbL

Ah I see what you mean now, thanks for the video.  Yeah, I have no idea why the file open dialog is doing that.  It seems to be selecting 15 characters of the path.  It is suspicious that this is the same length of the name of the dialog "openfiledialog1".  But have no control over this dialog which is provided by WinForms and Microsoft Windows... If you find a solution I'll be happy to fix it.

"openFileDialog1" fixed in version <IP_ADDRESS>.
Does not work for me. If the list is completely empty and I select the first schema, I still get this string.


[1.2]  Creation/modification of group does not trigger reporting event on GroupKeyManagement cluster

Reproduction steps
Set up a wildcard subscribe to a node.  Add a group to the node. Note that adding a group alters GroupKeyManagement Attribute 1 -- GroupTable. Observe that no report was generated on the wildcard subscribe even though the attribute on the GroupKeyManagement cluster changed.
Because there is no reporting event on GroupKeyManagement attribute 1 it is not possible to monitor editing of groups.
Bug prevalence
always
GitHub hash of the SDK that was being used
fc2d829858c3f1597d8e5b7d8873d042fa584e04
Platform
core
Platform Version(s)
No response
Type
Common Cluster Logic
Anything else?
No response

@rcasallas-silabs @lpbeliveau-silabs Please take a look.


register() functions to return

return sipRegister and sipUnregister;

What are those values returned for? One should be able to call sipRegister and sipUnregister – I guess we should not provide direct access to the lower level API.


Mentions do not seem to work

Hi!
I'm trying to mention myself in slack messages sent. This do not seem to work for some reason. I've tried to different syntaxes, as suggested by: https://github.com/cloudfoundry-community/slack-notification-resource/issues/16
Maybe that only applies to <!here> and not <!username>?
Here's a super simple pipeline to reproduce the issue. Replace the username (unless your are also named olle) and the ((slack_webhook)) with your own unless you already happen to have that stored in a credential manager 😄
resource_types:
- name: slack-notification
  type: docker-image
  source:
    repository: cfcommunity/slack-notification-resource
    tag: latest
resources:
- name: slack
  type: slack-notification
  source:
    url: ((slack_webhook))
jobs:
- name: hello-world
  plan:
  - get: slack
  on_success:
    do:
    - put: slack
      params:
        text: "<!olle> *$BUILD_PIPELINE_NAME/$BUILD_JOB_NAME* succeded!"
    - put: slack
      params:
        text: "@olle *$BUILD_PIPELINE_NAME/$BUILD_JOB_NAME* succeded!"

Output in slack:

ugh. this is a slack thing, not a slack-notification-resource thing.
for future users trying to tag users instead of <!here>, you need your slack user ID:
https://api.slack.com/changelog/2017-09-the-one-about-usernames#undocumented_mentions
sorry bout this!


Adding details for Global Azure Bangalore

Adding details for Global Azure Bangalore

Hi @samikroy you're missing the md file. We need that to show information on the GlobalAzure.net website. I will wait your update.

Hi @samikroy any news?

Hi @samikroy any news?

Thank you @tiagocostapt . Could you please let me know if anything else is needed.


RDK-37628 Added IRustBridge interface

This commits adds interface required by RustBridge. Rust bridge was originally part of ThunderNanoServices but we want to make it part of rdkservices and for it to replace RustAdapter.
This relates to rdkservices pull request https://github.com/rdkcentral/rdkservices/pull/3331

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/ThunderInterfaces/210/rdkcentral/ThunderInterfaces

Commit: 382919ccb8b7e126cffda7324453173b1f489bb4

Report detail: gist

WARNING: A Blackduck scan failure has been waived
A prior failure has been upvoted

Upvote reason: R2

Commit: 382919ccb8b7e126cffda7324453173b1f489bb4

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closed due to inactivity, please restore if still needed.


WORKSPACE: Update Alpine images to version 3.16.3

What this PR does / why we need it:
The current images are too old to run on AMD Zen3 processors, so they are updated to the latest release 3.16.3.
Which issue(s) this PR fixes:
Fixes https://github.com/kubevirt/kubevirt/issues/8783
Release note:

None

/test pull-kubevirt-e2e-kind-1.23-sriov


Media: Ensure user feedback when inserting unsupported file types via WordPress media modal

Context

Summary
This ticket become a little larger, when I looked around a different uses of the media picker in editor. In short, the link ( elements) , poster (document), publisher logo ( document ), caption ( video ) and poster ( video ), did have any feedback / error handling if an incorrect file type was selected. Now a snack message is displayed in all these different cases with an error message that matches what you are doing.
Relevant Technical Choices

New PHP changes are required, so that a list of image types can be displayed.
Link icons, now only support valid image types and ignore SVGS.
Captions are now limited to VTT files and show an error message when an invalid one is selected.

To-do

Add some tests
Name variable and param names better.

User-facing changes

Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:
Test 1: Insert in compatibility file types for media dialog.

Ensure that transcoding feature flag is disabled.
Open the editor.
Click upload button.
Upload an incompatible file type, such as a .mov or .pdf file.
Wait for upload to complete.
Click insert into page.
See showbar message.

Test 2: Select poster / publish logo

Open the editor.
Click to open documents tab.
Click on edit icon for poster or publisher logo
Upload an incompatible file type, such as a .mov or .pdf file.
Wait for upload to complete.
Click select poster / publisher logo button
See showbar message.

Test 3: Select poster for video element

Open the editor.
Insert video into canvas ( either by uploading a new one or using an existing one, not important for this test ).
Click on edit icon for poster
Upload an incompatible file type, such as a .mov or .pdf file.
Wait for upload to complete.
Click select poster
See showbar message.

Test 4: Select caption file for video element

Open the editor.
Insert video into canvas ( either by uploading a new one or using an existing one, not important for this test ).
Click on upload captions button
Upload an incompatible file type, such as a .mov or .pdf file.
Wait for upload to complete.
Click select poster
See showbar message.

UAT

[ ] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #6756

Still needs QA instructions btw

QA details added.
@csossi Just a note for the future, the 4 tests I listed above are all the places currently that the media picker is used in the editor. Any we make tweaks to the behaviour of the media picker, please keep these tests in mind, as you may find bugs.

@spacedmonkey You'll need to add allowedImageMimeTypes and allowedImageFileTypes here to fix Karma tests:
https://github.com/google/web-stories-wp/blob/5ac7794a11a2aa8734b2b573540f7afcd5638b08/assets/src/edit-story/karma/fixture/fixture.js#L43-L65

A karma test in videoPoster.karma.js seems to be failing:
https://github.com/google/web-stories-wp/pull/6772/checks?check_run_id=2142657332#step:9:3330

A karma test in videoPoster.karma.js seems to be failing:

I am struggling to work out what this one is. I wonder if it is unrelated. This is the test that is failing. What is interesting is that reset via mouse that is failing, but in https://github.com/google/web-stories-wp/commit/587779e44822d5c60e96e00259c5ff68b9d28d6f @miina skipped the keyboard version of this test. I wonder if the mouse version of the test is now flakey as well.
@miina Can you give some more context on why this test was skipped?

Hmm useMediaPiicker displays the error message on if (Array.isArray(type) && !type.includes(mediaPickerEl.mime)) {
In the Karma test only url is mocked, but mime is missing:
https://github.com/google/web-stories-wp/blob/d872f46a817b094777ceb07109be5a234effbbd6/assets/src/edit-story/components/panels/design/poster/karma/videoPoster.karma.js#L47
Maybe it's because of that?
Could add it like this I suppose:
window.wp = {
  ...window.wp,
  media: () => ({
    state: () => ({
      get: () => ({
        first: () => ({
          toJSON: () => ({
            url: 'http://example.com/dummy.jpg',
            mime: 'image/jpeg',
          }),
        }),
      }),
    }),
    on: (type, callback) => callback(),
    once: (type, callback) => callback(),
    open: () => {},
  }),
};

@miina Can you give some more context on why this test was skipped?

Just because it was flaky and was stopping an unrelated PR getting merged by needing to rerun the Karma tests. It was occasionally failing in other PRs, too. Not sure about the mouse one being flaky -- that I haven't seen failing as far as I remember.

Hmm useMediaPiicker displays the error message on if (Array.isArray(type) && !type.includes(mediaPickerEl.mime))

Thanks for this find. I haven't done a lot of work on karma tests, so they were new to me. Thanks for the support.


Silence UI is unresponsive with 1000s of silences

For some reason, we ended up with 2000 silences, and that makes the silence UI quite unresponsive when typing in the filter input.
It's unclear to me what it is doing exactly as I don't think there is  any kind of auto-completion here.
The chrome profiler seems to say that the time is spent in "Update layer tree".
I suspect that it's slow mostly because all the silences are rendered in the page. Paginating the silences (and the alerts) would mostly solve that.

Interesting enough, I discussed the same issue with @w0rm recently. The same will be true if you find yourself in a situation with 1000s of alerts. In that situation, the UI is so unresponsive that it's very hard to enter a filter string to filter down the number of items displayed.
We need some kind of paging or, in the simplest case, a message like "3456 alerts in total, displayed alerts are incomplete, please enter a filter to reduce the number of returned results"

Out of curiosity, can you post your OS, system specs, and browser used when you experienced this? Checking your system's resource usage would also be interesting, to see if it's RAM or CPU issues.

Intel(R) Xeon(R) CPU E3-1271 v3 @ 3.60GHz with 32GB of memory.
When typing there is one core that 100% used.

@w0rm confirmed that typing into the filter bar with ~2000 silences definitely has a delay, anywhere between 500ms and 1500ms, when entering a character. The message is UpdateMatcherText.
Scrolling and clicking on filter labels is fast, it's just the chain of events kicked off by updating the matcher text bar.
I've been going through the rendering code trying to see what the problem is. It shouldn't be re-rendering any of the silences, but there's a lot of code that sorts the silences by status and state. I was hoping this code would no-op since the data going in hasn't changed.
The silences are in a stable order in memory, so I was trying to remove work in the rendering code (sorting silences by active/pending/expired, for example), and using Html.Lazy, but it's not improving.
Any ideas?
If you can't think of anything, the next step would be to try filtering on the backend. I'm guessing the filtering on the front end is what's maxing out the CPU.

@stuartnelson3 I think it's rendering that is slow. We need to add pagination.

And, because we're updating the filter UI, it forces a re-render on the entire page?

@stuartnelson3 yeah, each update of the model causes the rendering to be re-evaluated.

Ok, so it isn't possible to just re-render the div containing the filter bar, the whole page needs to be re-rendered? I thought that was part of this whole shadow-dom thing, where only the changed portions would be re-rendered.

@stuartnelson3 you can put lazy anywhere in the render tree. If a part of the model stays the same, === check would return true, and the subtree wouldn't be re-rendered

That's why I'm confused by the time spent rendering. If I put lazy here: https://github.com/prometheus/alertmanager/blob/master/ui/app/src/Views/SilenceList/Views.elm#L27
...my understanding is updating the filter bar shouldn't cause this list of silences to be rerendered, because the input isn't changing. But, the app is still slow when updating the filter bar when a tab with 2000 silences is displayed.
If I'm on a different tab, updating the filter bar performs normally. This leads me to believe that the tab is being rerendered on each update, but it shouldn't be.
Am I misunderstanding something?

You should extract  the following code into a renderSilences tab silences function:
case silences of
            Success sils ->
                silencesView (filterSilencesByState tab sils)

            Failure msg ->
                error msg

            _ ->
                loading

and then call it with Html.lazy2 renderSilences tab silences

That does make sense, I didn't realize I had to handle the entire case statement with lazy2.
Unfortunately, the result is the same. I agree that we should have pagination (after we start sending silences from the API in a stable order), but I still think lazy rendering should be working here. Maybe you'll give a minute this week to see what I'm doing wrong.
diff --git a/ui/app/src/Views/SilenceList/Views.elm b/ui/app/src/Views/SilenceList/Views.elm
index 962e96a..e8a389d 100644
--- a/ui/app/src/Views/SilenceList/Views.elm
+++ b/ui/app/src/Views/SilenceList/Views.elm
@@ -2,6 +2,7 @@ module Views.SilenceList.Views exposing (..)

 import Html exposing (..)
 import Html.Attributes exposing (..)
+import Html.Lazy exposing (..)
 import Views.SilenceList.Types exposing (SilenceListMsg(..), Model)
 import Views.SilenceList.SilenceView
 import Silences.Types exposing (Silence, State(..), stateToString)
@@ -22,16 +23,21 @@ view { filterBar, tab, silences } =
             ]
         , ul [ class "nav nav-tabs mb-4" ]
             (List.map (tabView tab) (groupSilencesByState (withDefault [] silences)))
-        , case silences of
-            Success sils ->
-                silencesView (filterSilencesByState tab sils)
+        , lazy2 renderSilences tab silences
+        ]

-            Failure msg ->
-                error msg

-            _ ->
-                loading
-        ]
+renderSilences : State -> ApiData (List Silence) -> Html Msg
+renderSilences tab silences =
+    case silences of
+        Success sils ->
+            silencesView (filterSilencesByState tab sils)
+
+        Failure msg ->
+            error msg
+
+        _ ->
+            loading

 tabView : State -> ( State, List a ) -> Html Msg

Using lazy2 actually made a thunk that it's not evaluated. There must smth else that causes the issue. Looks like smth is reevaluating the layout. I will have a look later this week.

IMHO limiting the number of silences displayed when there is no filter (and then, adding pagination) would probably be a better long term solution.

Agreed. Right now we don't have a stable order when returning silences, so pagination won't be useful until that is fixed. We also need to figure out how to handle pagination within the three separate tabs, since they are sorted into these buckets after being received from the API.

Could a first implementation just sort by date and display only 100 results by default (with a message saying that there are more, possibly a link to display all) ?

@w0rm any time to look at https://github.com/prometheus/alertmanager/issues/981#issuecomment-328357757 ?

@stuartnelson3 I’m on vacation now, so I got plenty of time, will have a look soon.


change asserts

asserts are mainly used for testing but in practice, they swallow up all the gas used for the transaction if it evaluates to false. You don't really want to use when you're validating user input for contract functions. It's much safer to use require as it refunds gas to user should sufficient conditions not be met.

no problem at all
On Thu, Dec 14, 2017 at 4:53 AM bkcninja<EMAIL_ADDRESS>wrote:

@bkcninja requested changes on this pull request.
In contracts/SafeMath.sol
https://github.com/acebusters/economy/pull/75#discussion_r156596119:

@@ -7,26 +7,29 @@ pragma solidity ^0.4.11;
*/
library SafeMath {
function mul(uint256 a, uint256 b) internal returns (uint256) {

require(a >= 0 && b >= 0)

Thanks for the Pull Request and we appreciate the help. 👍 Could you just
add the missing semi colon here and in lines 24, 30 and 31? :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/acebusters/economy/pull/75#pullrequestreview-83098079,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ad-I-qu2ezz6FXCXEQlAo1MKrZRZffDAks5tAP42gaJpZM4Q9ycs
.


Feature Request: LQI (Link Quality Indicator) State Card

For Zigbee2MQTT devices, you can enable the LQI statistics which can then be displayed in dashboards or custom cards. I'm wondering if you would be able to add a whole new custom dashboard card called "lqi-state-card" or something similar, which would display the LQI entities similar to the battery states, with gradient coloring depending on the LQI, sorting from bad to good signal, and an expandable menu just like in the battery-state-card.

I was able to get close using the existing card and some examples, but I'm a little stuck.
This is what I have right now:
type: custom:battery-state-card
secondary_info: "{last_changed}"
icon: "mdi:signal-cellular-{state|
    abs()|
    lessthan(64,outline)|
    lessthan(128,1)|
    lessthan(192,2)|
    greaterthan(192,3)
}"
colors:
  steps:
    - value: 64 # bad signal
      color: "#FF0000"
    - value: 128 # poor signal
      color: "#FFA500"
    - value: 192 # moderate signal
      color: "#FFFF00"
    - value: 255 # excellent signal
      color: "#00FF00"
  gradient: true
filter:
  include:
    - name: entity_id
      value: sensor.*_linkquality
  exclude:
    - name: entity_id
      value: binary_sensor.*
    - name: entity_id
      value: sensor.2312dra50g*
sort:
  - by: state
    desc: true
collapse: 8
bulk_rename:
  - from: " Linkquality"

In Zigbee2MQTT entities, the LQI goes from 255 (good) to 0 (bad).
The only problem I have is that I can't figure out how to provide the dynamic icons correctly. Right now, a device with an LQI of 120 will get displayed at 2 bars for some reason.
And the coloring doesn't work at all. Basically, I want to replicate the same coloring and icon behavior as the default values of this card for the battery status, just for the linkquality sensor instead of the battery one.
Can you help me with these two issues? (This would make an additional great example on the README.md of this project, adding to the RSSI section)

I fixed the Icon Problem with the use of between in addition to lessthan and greaterthan, but still no Luck on Colors at All ^^"
type: custom:battery-state-card
secondary_info: "{last_changed}"
icon: >-
  mdi:signal-cellular-{state| abs()| lessthan(64,outline)| between(64,128,1)|
  between(128,192,2)| greaterthan(191,3) }
value_override: "{state|abs()}"
unit: LQI
round: 0
colors:
  steps:
    - color: red
      value: 64
    - color: yellow
      value: 192
    - color: green
      value: 255
  gradient: true
filter:
  include:
    - name: entity_id
      value: sensor.*_linkquality
  exclude:
    - name: entity_id
      value: binary_sensor.*
    - name: entity_id
      value: sensor.2312dra50g*
sort:
  - by: state
    desc: false
collapse: 8
bulk_rename:
  - from: " Linkquality"
  - from: " Signal"
  - from: " strength"
  - from: " Rssi"
  - from: " numeric"


[ENG-5330] Dep-group: Django-*

Purpose

Сhanges purposed to update Django and related modules, with updates to django-bulk-update, django-celery-beat, and djangorestframework-csv;

Changes

Updated the django-bulk-update module by replacing  bulk_update module with a built-in .bulk_update;
Updated the versions of two modules django-celery-beat and djangorestframework-csv in requirements.txt;

QA Notes
Please make verification statements inspired by your code and what your code touches.

Verify
Verify

What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation

Side Effects

Ticket
https://openscience.atlassian.net/browse/ENG-5330

LGTM. Merged.


Firefox Support

Something happened with Firefox and now Tibialyzer won't work with it! Please fix soon <3

Does Firefox work for you or are you ignoring my suggestion to fix it?

Firefox still works fine for me. There have always been people having issues with the flash client. Because there are so many variables involved in the way the flash client functions it is simply too time consuming for me to chase after the bugs there.
The flash client support is mostly "if it works, great, otherwise, feel free to fix it yourself".


IDP Enable/Disable Options prompts a message when click on that and gets disappear quickly

Moved from: https://wso2.org/jira/browse/IDENTITY-7125 & https://wso2.org/jira/browse/IDENTITY-7138
Steps to recreate the issue

Run the IS 5.4.0 pack
Configure Facebook as an IDP from the management console
Go to Identity providers > List option
There is a Disable/Enable option for the created IDP
Click on the Disable/Enable option
A message will be displayed.

Expected Result
The message that gets prompted needed to be available for some time for the user to see and understand it
Actual Result
Prompting message get disappear within a short time

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


typo ?

one-stop --> one-step ?
A diverse, simple, and secure one-stop LLMOps platform
-->
A diverse, simple, and secure one-step LLMOps platform

no, it's correct description, one-stop means '一站式的' in Chinese :-)


Relation widget slow on initial load

Describe the bug
We're using the relations widget to select authors for articles. This was fine to begin with. However, as the number of authors increased the load time increased drastically.
From other issues I understand that each a request is sent for each file and those should be cached after the initial load. However, our authors typically open this widget once.
Number of authors in collection: ~200
To Reproduce
Assuming the collections exist and one of the collections have relation to another collection

Create a new item (or select an existing one)
Click the dropdown

Expected behavior
Faster load time. A couple of seconds for example.
A possible solution could be that the search functionally limited the number of requests.
Applicable Versions:

Netlify CMS version: 2.13.3
Browser version: Latest chrome and firefox

CMS configuration
collections:
    - name: post_javascript
      label: 'Post: JavaScript'
      folder: post/javascript
      create: true
      summary: '{{post_year}}/{{post_day}}: {{title}}'
      fields:
          - { label: 'Calendar', name: 'calendar', widget: 'hidden', default: 'javascript' }
          - {
                label: 'Year',
                name: 'post_year',
                widget: 'number',
                default: 2020,
                valueType: 'int',
                min: 2018,
                max: 2021,
            }
          - {
                label: 'Day',
                name: 'post_day',
                widget: 'number',
                default: 1,
                valueType: 'int',
                min: 1,
                max: 24,
            }
          - { name: title, label: Title }
          - { name: image, label: 'Link to image', required: false }
          - { name: ingress, label: 'Ingress', widget: markdown, required: false }
          - { name: description, label: 'SEO Description', widget: text, required: false }
          - { name: body, label: Body, widget: markdown }
          - name: links
            label: 'Relevant links'
            widget: list
            fields:
                - { name: title, label: Title }
                - { name: url, label: Url }
          - name: authors
            label: 'Authors'
            widget: list
            field:
                {
                    label: 'Author',
                    name: 'author',
                    widget: 'relation',
                    collection: 'authors',
                    searchFields: ['title'],
                    valueField: 'title',
                    displayFields: ['title'],
    - name: authors
      label: Authors
      folder: authors
      create: true
      fields:
          - { name: title, label: Name }
          - {
                name: socialMediaLink,
                label: 'Link to social media (twitter, linkedin etc.)',
                required: false,
            }
          - { name: 'company', label: 'Company', default: 'Bekk' }

Hi @sveinpg @banyudu @erezrokah,
We are experiencing similar issues with this widget and would also like the performance improved. This widget is very useful for connecting entries together, and I've seen several issues in this repo referencing it.
Thanks,
Taine

Related to #5920


[9.x] Adds password hash helper for Factories

What?
This small method will actually reuses the password hash to avoid creating it for each created model from the Factory. Should have major speedbumps when seeding 1.000+ models in a database. It uses password by default, and the application default hasher.
public function definition()
{
    return [
        'name' => $this->faker->name,
        'password' => $this->password(), // "password"
        // ...
    ];
}

How?
It saves the password (when called) into the Factory. This allows to hash a password only once when it makes/creates models.
TODO?
The UserFactory.php in laravel/laravel could be changed too to use the method instead of hard-coding the hash to bcrypt.
BC?
Just adding a method and a property.

How is this more performant than just using the hashed string like we do now?

I also think the current implementation is better from a security perspective. Of course, this should not be used in production but the hardcoded bcrypt hash stands out very clearly, whereas a password() helper, even with a very bad default password, might be missed in reviews.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

How is this more performant than just using the hashed string like we do now?

For users or apps with different password requirements. For example, you may change password for `123asdAS#" or something if your app requires strong passwords with numbers or else.
Another way is to Artisan Tinker -> hash your new default password -> copy the hash, but feels less intuitive that using a password and saving the same hash in Factories.
I could have named it as reuseHash('password') tho.


Beaver familiar

Beaver familiar:

Gives woodchopping effect to player that greatly increases wood break speed
Will chop down nearby trees when they grow from sapling into a tree (only works on fairly small trees)

Fantastic! Thank you so much :D
Not sure yet when I get around to merging it, but definitely looking forward to trying it out


Provide a official PPA or Snap package for ubuntu.

You build .deb packages but one has to manually download them and install them when a new version comes out. I think Atom not even tells you when that is. That makes no sense. You should provide a official Ubuntu package.

Duplicate of https://github.com/atom/atom/issues/2956


Add/remove topics to repository

Resolves #121 Command to update topics for AndcultureCode repositories
Adds the ability to add/remove topics for a single AndcultureCode repo or all of them at once. Relies on the same personal access token authentication that was already built in - I am assuming only those with permission to update our repo description, settings, etc. will be able to leverage these commands.
Updated the default behavior for the github command to require a flag before listing off any repositories, and fixed a bug where the [and-cli] prefix was lost in the output

[x] Related GitHub issue(s) linked in PR description
[x] Destination branch merged, built and tested with your changes
[x] Code formatted and follows best practices and patterns
[x] Code builds cleanly (no additional warnings or errors)
[x] Manually tested
[x] Automated tests are passing
[x] No decreases in automated test coverage
[x] Documentation updated (readme, docs, comments, etc.)
[x] Localization: No hard-coded error messages in code files (minimally in string constants)

Something is up with the tests - they look like they're timing out in the CI build. I'll dig into it

@brandongregoryscott I'll review this one for ya.


man git results not satisfactory

No pager defined
environment:
_TAG_REDIR_IN=txt
_TAG_REDIR_OUT=
_TAG_REDIR_ERR=txt
TERM=dumb

under TN3270 OMVS

@IgorTodorovskiIBM or @anthonygiorgio any thoughts on this? should i be checking for something in the converters?

@IgorTodorovskiIBM or @AnthonyGiorgio any thoughts on this? should i be checking for something in the converters?

TERM=dumb disables colors on my Mac's man, but does not seem to disable colors on the z/OS man. This could be an issue either with less or man.

doing the same for man sleep works better

Hm. I think I will need to add logic to keep it ASCII if running in a dumb terminal

So not really acceptable, but I found that if I redirect to a file, then the file is fine, e.g.
man man >out
head out

the output is fine (for me) coming in from OMVS
How big a deal is this for you @lbdyck ? Is your tool unable to use this man because of this?

the answer is that I could update my ispf application to direct the man page to file but that doesn't help the omvs user who issues the man command from the omvs command line.
also - try this man bash | less - it works mostly.    here it is - exit with q

also should _TAG_REDIR_OUT=  be null and TERM=dumb have to be specified - this came up in another issue related to GIT and if these are not defined this way then the git messages are corrupt git log -n 1

@IgorTodorovskiIBM with the latest drop this still doesn't work. Any thoughts on how/where we should improve TERM=dumb?

Checking on any updates on this issue - sample with man iconv

tried again today and same results under OMVS:


Partner unable to connect to customer's tenant via Connect-IPPSSession -DelegatedOrganization @customerdomain.com

Hello,
I'm trying to connect to the Compliance endpoint for one of my customers, however am unable to do so. Access to all other endpoints are working fine. Should partners be able to access customer's Compliance endpoint, and is there any documentation that I'm unable to find on this regard?

Thank you,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 945ab2ea-22ae-814f-8898-fe84b7f29870
Version Independent ID: 5383d152-988d-b1ee-4957-db5fb6213754
Content: Connect-IPPSSession (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Connect-IPPSSession.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@asdcristi, I don't think it works. The description of the DelegatedOrganization parameter says, "reserved for internal Microsoft use". For the definitive answer, you could open a support ticket and ask.
As a complete and utter shot in the dark, you could also try using the BypassMailboxAchoring switch in the command (by itself and together with DelegatedOrganization). But I don't expect it to work.

@asdcristi Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Can't open Live Server on Visual Studio Code

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ x] Other: <!-- Please describe: -->
```Hi community. I need some help with Live Server. I used to work fine with it but now (I don't know why)
 I get an error and I can't open the web pages using Live Server from Visual Studio Code. When I do right click
 and select "Open with Live Server" to visualize it on the browser I get this message: "Something is went wrong!
Please check into developer Console or report on GitHub". I am using the Live Server Extension.
Do you know what the problem is? I really appreciate any help. Thanks.

## Current behavior

<!-- Describe how the issue manifests. -->

## Expected behavior

<!-- Describe what the desired behavior would be. -->

## Environment

```html
Browser:

- [ ] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ x] Safari (desktop) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:

- Live Server: 5.7.9
- Platform:   MAC
- Visual Studio Code:  1.70.1 (UNIVERSAL)

Others

i'm also getting an error when trying to run the Open with Live Server command,

Live server 5.7.9
Platform: Windows
VS Code: 1.71.2

I downgraded the extension to version 5.7.8 and it now works.

I downgraded the extension to version 5.7.8 and it now works.

Did you downloaded from the visual studio code?

Delete the extension completely from your local storage and reinstall it


unittest for macos

Codecov Report

Merging #13 (ec62ef2) into master (8dd8069) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   76.70%   76.70%
=======================================
  Files          16       16
  Lines        1112     1112
=======================================
  Hits          853      853
  Misses        259      259

Flag
Coverage Δ

d4cca948-9d75-4a09-a88b-6dd974b8a250
76.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a21ca6e...ec62ef2. Read the comment docs.


Yammer connection error

Hi,
When I try to authenticate the Yammer connector I get the following error:
OAuth2 authorization flow failed for service 'Yammer'. OAuth 2 sign in failed to exchange code for access token. Client ID and secret sent in form body.. Response status code=Forbidden. Response body: Your network is not allowed to request an OAuth token for this Application Client ID and secret sent in Basic authorization header.. Response status code=NotFound. Response body: invalid client application
And yes, I have 3rd party apps allowed in the network settings...
Can you please help? I see multiple people having the same issue.
Thanks,
Daniel

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 32446a8e-a16c-8017-290e-d414e6d9a242
Version Independent ID: e4f45a16-0deb-2eb4-eca2-31bec804dc51
Content: Create a knowledge-based commnity in Yammer by using QnA Maker and Flow
Content Source: yammer/integrate-yammer-with-other-apps/knowledge-base-community-flow-qna-maker.md
Service: yammer
GitHub Login: @IrenePasternack
Microsoft Alias: v-irpast

I have the same issue

Hi mypil. I have created support ticket and will update you with the findings. Cheers!

Hi! Looks like the issue was resolved on MS Backend and it's working again.


.NET Core Support

It does not look like this library supports .net core:
Errors in .\Projects\coreclr-plist-test\project.json
    Package PListNet 2.0.3 is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Package PListNet 2.0.3 supports: portable-net45+win8+wp8+wpa81 (.NETPortable,Version=v0.0,Profile=Profile259)
    One or more packages are incompatible with .NETCoreApp,Version=v1.0.

Is there any plans for this?

I would love to but I am completely swamped at the moment. A PR would be greatly appreciated.

Hmm, I've done some initial exploring (https://github.com/nlowe/PList-Net/tree/iss/4-dotnet-core) and it seems pretty easy. If you switch entirely over to the new tooling you can cross-compile the library for dotnet core and net45 (what you currently target), which should allow projects targeting dotnet core and net45 to use the library.
I believe with new tooling updates this won't be needed (once everything moves to xproj or back to csproj from project.json). Unfortunately I'm still waiting for the legal team at my work to approve downloading and installing the newest tooling and SDK. Once I find out more I can open a formal PR.

Next version will be compiled for netstandard 1.0.


:ghost: Includes dep labels.

Reworked using the Label object.  The wildcard label in the rule contain a trailing = (Ex: konveyor.io/target=).   Comparing the parsed label will be more consistent.

Seems we agreed to address this issue with better seeded rules/labels instead of scraping/injecting for deps.  I'm not convinced is completely solves the problem.


Protection ratings on NL species

Within the NL species occurrence dataset, there are 3 levels of species:

normal
protected
highly protected (only seen in nature preserves)

How can we utilize this information

If we can classify species in such categories, in the machine learning / data analysis the more rare species can be considered more valuable. E.g. a highly protected species outside a known nature preserve can be a stronger signal of biodiversity increase (or a of a more favourable increase) than a higher abundance of 'normal' species.
However this might be complex to express in numbers and should  be done by domain experts. We can get back to it if there is sufficient time left in the project.


Just use css

After struggling with bugs via Stylus lang compiler (stalled or dead project), Jeet (dead project), Less css, a little Sass and reading around, I've come to the conclusion to just use css wherever possible.

Yes, the syntax can be ugly
Yes, it's pretty hard to remember sometimes
Yes, it's not perfect
Yes, preprocessors have gone a long way to pushing css forward

But, all this comes at a cost:

High cognitive load for (in my opinion) little gain
Complicated functions and cleverness seem simple on the surface, but obfuscate code
CSS is not Javascript and we should probably stop treating it so
I'm not a fan of Javascript and it seems ugly/confusing to me

I do understand a little Lisp and Python, so I'm not a complete philistine.
I've never had the want or motivation to learn JS.
I do like the way Elm lang is headed, and admire it's creator — but I'm not yet convinced injecting html with javascript is a hot idea either.
CSS has moved on and now includes some functionality preprocessors were trying to solve.

Packages, software, languages come and go — so be careful what you depend on.

One of the first books I read on web design was "Don't make me think" which is all about Keeping It Simple Stupid! At this point in my life, I have zero motivation to keep up with trends — the less time I spend on a computer, the better. Life is there to be enjoyed not obsessing over minutia.
The web moves in cycles like any trend, but it seems humans have a tendency to overcomplicate for the sake of "progress". Sometimes complexity is necessary, but more often than not, we can strip it out for a far more simple, sane, alternative.
Note to self: Anki will use css, html, minimal compiling, minimal code.


Vid 111 prebid requests reaching character limit

Type of change

[x] Bugfix
[ ] Feature
[ ] New bidder adapter
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Does this change affect user-facing APIs or examples documented on http://prebid.org?
[ ] Other

Description of change
reduce banner request params in case if url reached the limit

Prebid.js PR https://github.com/prebid/Prebid.js/pull/6549


[Android] Error on message long press.

Tested on 4.4.4, 4.1.1, 7.1.0

this may be auto resolved once we upgrade to react-native 0.44.0
https://stackoverflow.com/a/44100312/5612089

Yeah, I guess we can either downgrade the ActionSheet library or upgrade React Navigation.

@zulipbot claim


Added Spring Boot in Practice by Somnath Musib

Hi, I thought this title might be a great addition to your list of resources/videos/books. Thank you for your consideration.

Please read https://github.com/paragonie/awesome-appsec/blob/master/CONTRIBUTING.md for instructions on how to contribute.

You still haven't created the JSON file.


List literals

Is your feature request related to a problem?
For some annotations, we might want to specify a list of values. The same applies when hard-coding some data in a pipeline.
Desired solution
List literals using the well-known syntax from Python or JavaScript.
We might also remove variadic parameters then, which are harder to represent graphically than a single list parameter.
Possible alternatives (optional)
No response
Screenshots (optional)
No response
Additional Context (optional)
No response

:tada: This issue has been resolved in version 0.2.0 :tada:
The release is available on:

Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


C# Unable to cast custom class to internal class even if it inherits internal class if using Tool scripts

Tested versions

Reproducible in Godot 4.2 C#

System information
Godot v4.2.1.stable.mono - Windows 10.0.22000 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2050 (NVIDIA; <IP_ADDRESS>18) - 13th Gen Intel(R) Core(TM) i5-13420H (12 Threads)
Issue description
So my class TableContainer inherits VBoxContainer. I exported this class from a regular Control class (which is a [Tool] script). When I try to assign the node via editor I got this error:
 /root/godot/modules/mono/glue/GodotSharp/GodotSharp/Core/NativeInterop/ExceptionUtils.cs:112 - System.InvalidCastException: Unable to cast object of type 'Godot.VBoxContainer' to type 'exported_class'.
     at Control.RestoreGodotObjectData(GodotSerializationInfo info) in D:\...\Godot.SourceGenerators\Godot.SourceGenerators.ScriptSerializationGenerator\Control_ScriptSerialization.generated.cs:line 19
     at Godot.Bridge.CSharpInstanceBridge.DeserializeState(IntPtr godotObjectGCHandle, godot_dictionary* propertiesState, godot_dictionary* signalEventsState) in /root/godot/modules/mono/glue/GodotSharp/GodotSharp/Core/Bridge/CSharpInstanceBridge.cs:line 255

Which will work fine if I remove the [Tool] attribute from the Control class I made and works fine if i add it to the TableContainer class as well.
I'm not sure if this is intended behavior, but maybe if it is there should be a better error message explaining it.
(p.s. I needed it to be [Tool] because I'm writing editor plugin)
Steps to reproduce

Create empty project.
Create empty Control scene
Create another empty Control scene (TableContainer class)
Export the TableContainer class from the main Control scene
Add [Tool] to the main script
Set the value in editor
Error

Minimal reproduction project (MRP)
CSharpTestBed.zip

Hello. If I understand correctly, you're saying that, in a [Tool] context, the following works fine.
[Tool]
public partial class Foo : Control
{
  [Export]
  public Bar MyBar;
}

[Tool]
public partial class Bar : Control
{
}

But the following does not.
[Tool]
public partial class Foo : Control
{
  [Export]
  public Bar MyBar;
}

public partial class Bar : Control
{
}

If so, this is expected, as Bar would not be available in this context without using the [Tool] attribute.

Ah yes. That's exactly the case. Then it would be better to add more descriptive error messages for that i think. Because in the editor it's kinda vague. Anyways issue closed


Compiling issue ESP-AT Windows

Hi everyone. I have a problem compiling the ESP-AT project. I am following the steps from here https://docs.espressif.com/projects/esp-at/en/latest/esp32/Compile_and_Develop/How_to_clone_project_and_compile_it.html#esp-at-get-at-sdk for Windows. In the step 3 "python build.py install", I receive this error:
Ready to set up ESP-IDF tools..
ERROR: This script was called from a virtual environment, can not create a virtual environment again
A fatal error occurred: set up ESP-IDF python-env failed
I do not undestand why. Please I need help.
Best regards.

@Polyteres Could you please provide detailed logs after you cloned ESP-AT.

Yes, I have the same problem. But it looks like the subsequent steps are OK, and the firmware seems to be compiling OK.


test: i2s: skip some cases that do not support in NXP platform

user mode and state test are not support well in NXP platform
skip for now
Signed-off-by: Hake Huang<EMAIL_ADDRESS>

Can you explain further why these need to be skipped for NXP. Seems like the ifdef should be something not driver specific.

@galak please check the PR comments https://github.com/zephyrproject-rtos/zephyr/pull/32054


html with line breaks

I have run across a slight problem with marked when trying to render html with line breaks between the attributes:
<input type="text"
  name="email"
  value=""
  id="email-input"
  class="etc" />

I know this is not a normal use case but as far as I know it is valid html, I am willing to submit a patch if I can get some pointers on where/ how to modify this behavior.

Great! Thanks for jumping on it so quickly :)


(WIP)  "Offline Status" recipe

This recipe covers issue #5.  To Do:

[x] Cleanup event listeners once we notify the user the app is ready for offline
[x] Write intro text on index.html explaining what this recipe does
[x] Get rid of gross styling
[x] Make the example actually do something ?  :D
[x] Lint

OK, this should be ready for review!

Per @digitarald 's request, I've removed use of the Notification API and instead show a "toaster" notification.

What about showing the notification when the permission was already given, this would be an interesting workaround around randomly showing permission popups without context. The domain could have asked before to show notifications.


Subdirectory pages don't work on now dev with @now/next

If I serve a Next.js project using now dev and it contains directories within pages, all sub-pages throw 404 errors. The exact same configuration works correctly on Now proper, but not in the development environment.
For example, in the following setup:
pages/
  a/
    index.js
    b.js
  c.js
next.config.js
now.json

After running now dev, http://localhost:3000/c will load correctly but /a and /a/b will both 404.

Hello @PullJosh, could you share with us your now.json file please?

Here's a quick demo: https://github.com/PullJosh/next-subfolder-struggles
The site works great when hosted on Now, but some pages fail to load in now dev (at least for me on Windows 10).

Running into the exact same problem on Windows 10.
It will show the sites when navigating to them via the clientside along nextjs links. If I then refresh the page I will get a 404.

Hmmm, I can't seem to reproduce, on macOS at least. I'll try it on Windows when I get access to a box running it.

Looks great on your machine! 😛
For reference, here's that same setup on mine:

Ok so definitely related to Windows then (backslash vs. forward slash issue I'm assuming). We will fix this soon!

Any luck with this one?

This is also an issue for the new Next.js Api Route features. I can access mypage.come/api/hello when hosted with now. But I can't access it with now dev on localhost.


Optimize images

This change is

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: RDIL:x: ImgBotAppYou have signed the CLA already but the status is still pending? Let us recheck it.

@RDIL It doesn't matter. Thank you! BTW, I found you have made over 2k contributions last year, it is amazing!


InfluxDB metrics: support SNI for https endpoints

Do you want to request a feature or report a bug?
Feature
What did you expect to see?
SNI support for influxdb servers via https. The InfluxDB client does not pass a servername to the TLS config by default. As a result, the https transport is basically unusable except when you happen to have a dedicated ip address for your influxdb input.
I think it's safe to enable it by default for every https endpoint in https://github.com/containous/traefik/blob/a20a6636b4582e4e7b562fc01f64567775fc8a9a/pkg/metrics/influxdb.go
I tried with
tlsConfig := new(tls.Config)
tlsConfig.ServerName = w.config.Address

if w.config.Protocol == "http" {
    return influxdb.NewHTTPClient(influxdb.HTTPConfig{
        Addr:     w.config.Address,
        Username: w.config.Username,
        Password: w.config.Password,
        TLSConfig: tlsConfig,
    })
}

but ran into an unspecified tls: internal error (never touched Go before).

Yeah, it's kinda funny that of all pieces of software, Traefik wouldn't support SNI outbound :laughing:
I do run an influxdb behind traefik at home and ran into this issue when I wanted to collect metrics from a remote traefik running on my AWS...

That issue does not appear to be present in 2.2 any more.

I can confirm that pushing metrics to influxdb via https with SNI works as expected in 2.2.0.
Thanks!


fix: Create bootstrap VM on RHEL9 based KVM host

The virt-install command on RHEL9 KVM hosts requires a os-variant parameter.
Signed-off-by: Klaus Smolin<EMAIL_ADDRESS>

@smolin-de I vaguely remember us talking about this a while back, but I don't remember what conclusion we came to about it - could we change this to a variable instead of hard-coding the value?

@smolin-de I vaguely remember us talking about this a while back, but I don't remember what conclusion we came to about it - could we change this to a variable instead of hard-coding the value?

yes, we can have a variable.
I will create a new pull request.


evaluating HD wallet

Lib for creating HD addresses https://github.com/iotexproject/iotex-core/issues/1256

not a priority for now


⚠ Bofrost.de has degraded performance

In 3163281, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1089 ms

Resolved: Bofrost.de performance has improved in 5293752 after 7 minutes.


UNKNOWN: Unable to resolve dependencies in application

Fix issue #23 that you also encountered in the video https://www.youtube.com/watch?v=yF-_HGC7_XM at minute 33

The title can still be 'CODE RUB' than UNKNOWN. @hassanhabib your thoughts, please.

@ShriHumrudha && @stasnowak I would mark this as MAJOR FIX: Resolve Logging Broker Registration Issue.
There are three new types of effort that we haven't publicly introduced yet, but this is definitely a great opportunity to talk about those. So here goes:
There are three types of issues here that we need to categorize:

MINOR FIX: For issues that happen not so often and doesn't impact all requests across the app
MEDIUM FIX: For issues that impact few requests and happens often but not all requests across the app
MAJOR FIX: For issues that block all requests - a catastrophic issue that impacts all requests, all users all the time.

@stasnowak the one thing I'm not sure about though is your approach here. We usually just register AddLogging() and everything else just works. I am not sure what changed but the current approach is something I'd try to improve on.


Fix timeouts from very large raft messages

Rationale is in a comment in the diff explaining the two removed lines.
fixes https://github.com/moby/swarmkit/issues/3113

Fixes https://github.com/moby/swarmkit/issues/3113

Fixed a spelling issue.

PTAL @thaJeztah

Let me close/reopen to kick CI; GHA UI for some reason doesn't show "re-run" options 🤔

CI failing again, but I think it's a different test now. Let me post that failure in case it was not (yet) known as a flaky
2023/03/22 08:58:55 http: TLS handshake error from <IP_ADDRESS>:47198: remote error: tls: bad certificate
2023/03/22 08:58:55 http: TLS handshake error from <IP_ADDRESS>:40038: remote error: tls: bad certificate
2023/03/22 08:58:55 http: TLS handshake error from <IP_ADDRESS>:40042: remote error: tls: bad certificate
--- FAIL: TestListManagerNodes (23.68s)
    node_test.go:543:
        	Error Trace:	/go/src/github.com/docker/swarmkit/manager/controlapi/node_test.go:543
        	Error:      	Received unexpected error:
        	            	expected node 5 to be unreachable
        	            	polling failed
        	            	github.com/moby/swarmkit/v2/testutils.PollFuncWithTimeout
        	            		/go/src/github.com/docker/swarmkit/testutils/poll.go:28
        	            	github.com/moby/swarmkit/v2/testutils.PollFunc
        	            		/go/src/github.com/docker/swarmkit/testutils/poll.go:36
        	            	github.com/moby/swarmkit/v2/manager/controlapi.TestListManagerNodes
        	            		/go/src/github.com/docker/swarmkit/manager/controlapi/node_test.go:543
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1439
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1571
        	Test:       	TestListManagerNodes
    node_test.go:612:
        	Error Trace:	/go/src/github.com/docker/swarmkit/manager/controlapi/node_test.go:612
        	Error:      	Received unexpected error:
        	            	expected node 1 to be unreachable
        	            	polling failed
        	            	github.com/moby/swarmkit/v2/testutils.PollFuncWithTimeout
        	            		/go/src/github.com/docker/swarmkit/testutils/poll.go:28
        	            	github.com/moby/swarmkit/v2/testutils.PollFunc
        	            		/go/src/github.com/docker/swarmkit/testutils/poll.go:36
        	            	github.com/moby/swarmkit/v2/manager/controlapi.TestListManagerNodes
        	            		/go/src/github.com/docker/swarmkit/manager/controlapi/node_test.go:612
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1439
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1571
        	Test:       	TestListManagerNodes
FAIL

Can we kick CI again on this one?

Yeah, I can try it again; it kept failing 😔
Let me give it another go

This is still failing CI, but I believe the issue with this specific PR has been fixed by adding this watchdog timer thing. I need to spend some more time on the other issue, which I believe applies to all PRs right now.

@dperny looks like CI is happy now, except for a typo;
#21 67.98 manager/state/raft/transport/peer.go:269:25: `reciever` is a misspelling of `receiver` (misspell)
#21 67.98 			// there would be no reciever. We'd block here forever.
#21 67.98 			                     ^

Codecov Report

Merging #3122 (c963e16) into master (e28e8ba) will increase coverage by 61.71%.
The diff coverage is 94.00%.

@@             Coverage Diff             @@
##           master    #3122       +/-   ##
===========================================
+ Coverage        0   61.71%   +61.71%
===========================================
  Files           0      154      +154
  Lines           0    31120    +31120
===========================================
+ Hits            0    19207    +19207
- Misses          0    10369    +10369
- Partials        0     1544     +1544


[bug] GreenWave Multi-socket PowerNode 6 missing Watt meters for sockets 2-6

Version
Build/Run method

[X] Docker
[ ] PKG
[ ] Manually built (git clone - npm install - npm run build )

zwavejs2mqtt version: I'm not sure how to get this. I'm using zwavejs/zwavejs2mqtt:dev pulled on 12th Dec
Describe the bug
GreenWave Reality Inc. Multi-socket PowerNode (6 plugs) - Manufacturer ID=153, Product Type=3, Product ID=4 doesn't report Watt meter for sockets 2, 3, 4, 5 and 6.

OpenZWave stack and OpenHab ZWave bindings are able to get that information. For instance, from OpenZWave stack (using docker openzwave/ozwdaemon:latest) you can see that information:

I'm not sure if this is a zwavejs problem not recognizing all the device information or a HA discover issue. If further details are needed, please let me know.
Expected behavior
Watts meter for all the 6 plugs into device are expected

Closing, not a bug, sorry!
Added another Greenwave Powernode it shows W_metter objects properly. This one has older firmware (4.21) then the one not showing W_metters (4.28) but I didn't think it could make such difference.
So, I've tried Healing the node -> No success
Refreshing info node -> It did the trick. W_meter objects are now discovered.


Adding more nodes to an existing cluster build with Elastic Stack Azure Marketplace

Hello,
I have an elasticsearch cluster that was built a couple of years ago with the templates, however the specific configurations/templates are long gone and the cluster's configuration has since changed.
What approaches are available for adding nodes to this cluster? Can I create a new deployment to add nodes in? Do I need to manually create new VMs and join them to the cluster?
Thank you.

Hi @jwcw,
A way to add nodes to the cluster that should work irrespective of how the cluster was deployed (from Marketplace or from GitHub) is to create a new VM, deploy Elasticsearch on it, and add it to the cluster.
An existing node in the cluster should have the scripts used to deploy Elasticsearch onto it in the /var/lib/waagent/custom-script/download/0/ directory - it should be called elasticsearch-install.sh. In addition to the install script, this directory should also have a log of stdout and stderr when  the deployment scripts ran, which, in addition to the template's own log file /var/log/arm-install.log and a node's configuration file at /etc/elasticsearch/elasticsearch.yml, should be enough information to create a new VM with a new node. Further, the Azure portal should also have a log of the deployment history for the resource group into which the template was deployed, which should provide the input parameters provided (if they can't be determined from the log files of an existing node).


Fix MethodFinder to return topmost implementation of the virtual method

uses the topmost implementation of the virtual method

@jogibear9988
I merged to master, however I noticed that some unit tests fail.
I did fix it.


www.jmdns.org website is offline

Attempting to access the http://www.jmdns.org/ website yields a message that the domain is now reserved.

Thanks for noticing! I have changed the provider and today the domain name became reassigned. Should be fixed now!

Not fixed for me, at least not yet.

Now the domain redirects to this github repo. So previously valid URLs like http://www.jmdns.org/update-site/3.5.4/ are now 404.

So previously valid URLs like http://www.jmdns.org/update-site/3.5.4/ are now 404.

This was always a 404. But http://www.jmdns.org/update-site/3.5.4/content.jar resolves correctly, so the update sites should work as expected.


Split opencl glm function

Summary
Splits OpenCL implementation of normal_id_glm_lpdf() into a separate function. This fixes side effect of PR #1353.
Tests
New tests were added as CPU tests can't be reused on a function with different signature.
Side Effects
None.
Checklist

[x] Math issue #1319

[x] Copyright holder: Tadej Ciglarič (University of Ljubljana)
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

So in short you took the currently ifdefed implementation inside /prim to a separate file and presume that x and y are matrix_cl, which means that they cant be parameters. Anything else of note?

No, that is all.

Yay, auto formatting is back!


Rename tcod-sys to tcod_sys

In accordance with the new rules on naming crates.
This fixes the fact that currently, attempting to cargo update or cargo build on the latest rust fails.
It also lets us get rid of the quotes around:
// old
extern crate "tcod-sys" as ffi;

// new
extern crate tcod_sys as ffi;

@tomassedovic This is quite urgent as the library cannot be built on the latest Rust.
Fixes #127

Ooh, I didn't realise the change already landed. Thanks!

Not a problem! I think this should still work for publishing to crates.io seeing as we didn't rename the package, so it's probably worth releasing a new version.

On it.


feat: port CategoryTheory.Limits.Shapes.Reflexive

I don't remember seeing "unsupported infer kinds" before, but this thread helped:
https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Infer.20kinds.20are.20unsupported
Please check if I understood correctly

bors r+


Command Call Limit

What do these changes do?
Implements an optional mechanism to limit the number of same command calls.

Can specify a "global" limit or differing per-command limit
Maintains backward compatibility for users expecting no command call limitation

Are there changes in behavior for the user?
Nothing for existing users. Backward compatibility is maintained.
Related issue number
Closes #145
Checklist

[x] I think the code is well written
[x] Unit tests for the changes exist
[x] tox testenvs have been executed in the following environments:

[x] Windows 10 (via PyCharm tox runner): (ALL)
[x] Windows 10 (via PSCore 7.0.3): (ALL)
[x] Windows 10 (via Cygwin): qa,py36-{nocov,cov}
[x] Ubuntu 18.04 on WSL 1.0: (ALL) + pypy3-{nocov,cov,diffcov}
[x] Ubuntu 18.04 on VBox: (ALL) + pypy3-{nocov,cov,diffcov}
[x] Ubuntu 20.04 on VBox: (ALL) + pypy3-{nocov,cov,diffcov}
[x] FreeBSD 12.1 on VBox: (ALL) + pypy3-nocov

[x] Documentation reflects the changes
[x] Add a news fragment into the NEWS.rst file

This should probably also handle the number of erroneous commands, e.g. repeatedly sending BOGUS.

This should probably also handle the number of erroneous commands, e.g. repeatedly sending BOGUS.

This should probably also handle the number of erroneous commands, e.g. repeatedly sending BOGUS.

It's already built-in.
The "budget check" happens before the method search-and-invoke, so even bogus commands will be limited.

This should probably also handle the number of erroneous commands, e.g. repeatedly sending BOGUS.

It's already built-in.
The "budget check" happens before the method search-and-invoke, so even bogus commands will be limited.

Doing testing for latest changes + merges on my test systems:

[x] Windows 10 (via PyCharm tox runner): (ALL)
[ ] Windows 10 (via PSCore 7.1.0): (ALL)

This comment is undergoing editing

Doing testing for latest changes + merges on my test systems:

[x] Windows 10 (via PyCharm tox runner): (ALL)
[ ] Windows 10 (via PSCore 7.1.0): (ALL)

This comment is undergoing editing

If no objections within the next 2x24, I'll squamerge this PR.

If no objections within the next 2x24, I'll squamerge this PR.


Endpoint for wrapped ETH balance

We need an endpoint for retrieving the balance of wrapped ETH of an user. I am not sure though how the endpoint should be named. I think something like users/:userAddress/balances/:ethTokenAddress could be the most consistent regarding our existing endpoints. Or maybe even use users/:userAddress/balances and return an object? @berndbohmeier what do you think?

what about tokens/:tokenAdress/users/:userAddress/balance

To be consistent with networks/:networkAddress/users..
@dakingha69

ah yea /tokens/:tokenAddress/users/:userAddress/balance makes more sense. but then we should also add the address of the eth wrapper contract to the endpoint /tokens instead of /exchange/eth

Yes, but maybe also leave it there, because it is still a special token.


Introduce embedded-keycloak to the project

This PR adds a new module to the project that provides integration for Keycloak embedded.

[x] Add embedded-keycloak skeleton
[x] Add integration tests
[x] Implement Keycloak specific container
[x] Clarify if we need a dedicated status check class
[x] Clarify if we need the KeycloakTestOperations and what package manager to use on the Keycloak image
[x] Clarify want surrogate to use instead of keycoak-spring-boot-starter
[x] Update README
[x] Distinct test for vanilla/Spring usage

Fixes #183

I would be really grateful if this could be released soon, as I need it within my project…

@holgerstolzenberg could you please create issue and describe problem and expected outcome?


[PE-D][Tester D] Valid NRIC number results in error when adding a patient

When adding a patient, only NRIC that are already listed in the original data and from the error message (which is the same as user guide) considered as valid.
Other NRIC that should be valid will result in invalid NRIC exception.

Can try to review how NRIC is validated.

Labels: type.FunctionalityBug severity.High
original: julia-cp/ped#1

Documentation issue.
NRIC validation works as intended but users might think any number is valid.
Fix:
To give clearer instructions that it must be an actual NRIC.

Resolved in #174


tests/utils.go: Move or inline DeleteAlpineWithNonQEMUPermissions to the place where it is used

Is your feature request related to a problem? Please describe:
The function DeleteAlpineWithNonQEMUPermissions in tests/utils.go is only used in a single place, so it could be easily moved there.
Describe the solution you'd like:
Move or inline DeleteAlpineWithNonQEMUPermissions to the place where it is used. (tests/storage/storage.go)

/sig code-quality

/label good-first-issue

/assign


New Bookshelf Update Workflow

We will need a workflow to upload a list of barcodes to edit item records, to remove the temporary location, and possibly the temporary loan type. (This interface would be in MIS Reports)
*This data is should be retrieved from LDP if possible.

We need to find out what the CSV we are uploading will look like.

This work will be deferred until the release of Morning Glory


Fix Issue 15827 -  std.variant.Variant can not be initialized with some struct

https://issues.dlang.org/show_bug.cgi?id=15827

Needs test case and also Fix issue 15827 in the commit title

LGTM

OK. Will fix that on Monday.

LGTM, thanks!

Auto-merge toggled on


Housekeeping: Change MS MicrosoftDependencyResolver to require IKeyedServiceProvider in ctor

Please note although we can't commit to any timeline, priority will be given to those who are Contributors to the project.
If this is a question please ask on StackOverflow.
Is your feature request related to a problem? Please describe.
With #1075 to avoid a breaking change that would effectively drop NET6 early and cause a headache it was suggested to revisit how IKeyedServiceProvider logic works in the DI wrapper.
With #1075 it carries out an interface type check to see if it's using IKeyedServiceProvider.
Describe the solution you'd like
This can be simplified by changing the constructor to require IKeyedServiceProvider instead of IServiceProvider. The default implementation of ServiceProvider uses IKeyedServiceProvider as of net 8.
Then we can remove the if checks and the older contract internal class that's in there for net6.
Describe alternatives you've considered
Leave as is
Describe suggestions on how to achieve the feature
Additional context

technically we've already broken net6 package support as the framework is using v8 of packages


Feat/conditional fields

[ ] Add listeners to boolean and radio widgets.
[ ] Possibly add listener to checkbox widget
[ ] Possibly allow conditional group nesting
[ ] Prevent submission errors based on required fields currently hidden by conditionality.

@boutell If you have some time Thursday, would you take a look at my approach here?
It's limited to select fields triggering conditionals now, but the big thing to solve is going to be preventing form submission errors due to currently hidden fields. That includes the HTML required attributes.

So on the front end you show and hide, and on the back end you discard extra stuff.
I think you're going to have problems here, due to required properties like you said - both HTML5 attribute wise and actual business logic wise.

I can get around the required HTML attribute by adding disabled ☑ .

I think it would be better to actually prevent the validation of anything that is currently hidden by a conditional, as well as suppressing any required attribute.

I agree and looked at doing this. For some reason it was seeming too disruptive, but I'll look again.

General approach seems sound and can be extended to picking a field name via a nice dynamic select at some point.

Closing to write tests first.


Update gate.inverse() to return AnnotatedOperation

Summary
This PR adds a new argument annotated to all the "inverse" methods. This is a follow-up to #11433 (and should be rebased onto that).
Details and comments
Note that even though we have to update the interface of many standard gates that implement inverse, in practice inverses of standard gates are also standard gates, and we should always prefer these over an "inverse-annotated" operation. For instance, the inverse of the CX-gate is again the CX-gate, and the inverse of the S-gate is the Sdg-gate (and in addition all of these are singleton gates).
I believe that for the immediate release it makes sense to either include both this and #11433 together or to include neither. I have updated the priority to that of #11433.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 89.481%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
59544

Relevant Lines:
66544

💛  - Coveralls

Thanks! I have added the release notes and a few tests (somehow I forgot to do this either).
At the moment I can't think of a scenario where keeping an inverse SGate as an AnnotatedOperation instead of an SdgGate would be useful (though I get your point on potentially combining modifiers).
I was actually thinking earlier that we may want to have 3 different values for annotated:

Do not create AnnotatedOperation unless the operation does not make sense otherwise (e.g., control/inverse of an annotated operation)
Always create AnnotatedOperation
Choose whatever leads to simpler gates/circuits

We need 1 to preserve the existing behavior. We want 3 in practice. But I could not convince myself that we really need 2. So, not to over-complicate things, what's implemented right now has annotated=False corresponding to 1 and annotated=True corresponding to 3. I have tried to clarify this both in the release notes and in the documentation of Instruction.inverse(). What do you think?


⚠ Bofrost.fr has degraded performance

In 49b0444, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 834 ms

Resolved: Bofrost.fr performance has improved in 14d62de after 25 minutes.


fix: add flex to fix phone input layout #trivial

The type of this PR is: fix
Description
Phone inputs with titles layout was broken. We have a title in consignments flow. Opting for quick fix to use flex on the component because this is a launch blocker, but we probably want to fix the PhoneInput component so you don't have to.
Before

After

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Fix broken phone input layout in consignments flow - Brian

Android user-facing changes

Dev changes

This PR contains the following changes:

iOS user-facing changes (Fix broken phone input layout in consignments flow - Brian)

  Generated by :no_entry_sign: dangerJS against 4de0a25965dfc917972f1503a7b55e5544bb7aeb


Ocm docs

Referencing: #7564 and #7580
This PR adds documentation for the ocm service and fixes a environment variable name for an OCM setting.

@aduffeck I am wondering why there are changes in an unrealted file (docs/helpers/extended_vars.yaml). I guess that is unintentionally. In that case, you can drop the change to fix the conflict.

@mmattel good question, it definitely wasn't an intended change. I rebased against master again, the change is now gone.


Available on windows desktop ?

Hi, I'm trying to use this package as a desktop application, but I couldn't get it to work. However, I ran it in the mobile application. Then I saw that there is no web support in flutter 3, I wonder if it is not available for desktop applications at the moment?

In fact, this library does not use any native platform code and relies entirely on the implementation of the Flutter layer. Therefore, if the official Flutter perfectly adapts to all platforms, then it should work properly.


question:  Call lambdas on loops?

As the title says, I would like to call a lambda function on a loop variable. Is there a way to do so?
Here's a snippet of what I'm trying to accomplish:
{{#branches}}
final {{.}} = {{.}}ShellBranch();
{{/branches}}

But I would like to call the snakeCase() lambda over the loop variable {{.}}ShellBranch();

I just found out full syntax lambdas, which I think will solve my question


Make Spark work on 1.12.1

Added Spark configfile, setting user as root. Default user is nobody which prevents the spark service from starting. Also setting use_bootstrap_for_IP_detect which appears to be required top make spark work on AWS at least.

Thanks for this @m-dekkers and sorry it took so long to review!  I've been testing this as well and found that your changes are necessary (otherwise you see permissions errors due to the bind-mount of /mnt/mesos/sandbox and Spark running as nobody, I assume you hit the same?) as well as specifying an older version of Spark itself.
I'm creating a new folder for 1.12, but if you'd like to update your PR to include the following:
{
    "service": {
        "user": "root",
        "name": "spark",
        "use_bootstrap_for_IP_detect": true
    }
}

And that it needs to be launched with the following options:
dcos package install spark --options=configuration/spark.json --package-version=2.5.0-2.2.1

Then I'll get this merged and will include it in my update as well.


Handle POST submissions in addition to GET

The previous version of this driver only set a 'q' path in the GET variable if the REQUEST_METHOD was GET. This update also checks for POST submission and sets the same variables in the POST variable as would be set in the GET.

Thanks!


emoji: Make minor adjustments to emoji names list.

Automated message from Dropbox CLA bot
@rishig, it looks like you've already signed the Dropbox CLA. Thanks!

Merged, thanks @rishig!


Updated Notes for Anonymize and Mask Data custom step.

Please include answers to these questions as part of your pull request
In the GitHub webUI, use the Write tab to modify the Markdown text that is part of the pull request. For each question simply place an X inside the square brackets, [X], that represents your answer. Make sure there are no blanks inside the brackets, otherwise MarkDown doesn't render properly. Using the Preview tab while editing this form, you can see the formatted/rendered version of the message.

Q1: Confirm that you have the right to submit the code that is being contributed. Please consider the origin of your code and confirm you have the appropriate rights to make the submission subject to the Apache 2.0 license that applies to everything in this repository of custom steps. If so, follow the instructions for the Contributor Agreement (which is based on the industry-standard Developer Certificate of Origin (DCO)).

[X] Yes, I have the right to submit the contributed code on behalf of myself, my company, or any other owner of the code. I have also attached my signed copy of the DCO to this message.
[] No

Q2: Confirm that your contribution does not include any personally identifiable information (PII), for example, in any examples used in your README file.

[X] My contribution does NOT include PII data
[ ] My contribution includes PII data

Q3: Confirm your contribution does not include any encryption or other export-controlled technology.

[X] My contribution does NOT contain encryption or other export-controlled technology
[ ] My contribution includes encryption or other export-controlled technology

Thanks for adding a note to both README.md and About tab explaining that this functionality is now available by SAS-provided step Mask Data that can be found in the Transform Data group.

We'll still keep this step around for the time being as it might be useful for people that want to build something similar, so they do not need to start from scratch.
Took the library to make the following small changes for the step to better adhere to guidelines:

Added cleanup routine to remove SAS macros and SAS macro variables introduced by the step

Increased version number in About tab and readme.md

Updated change log

SAS Internal Due Diligence Review - COMPLETED on 19FEBAPR2024


NPM won't boot with version 1.10.1

Describe the bug
The script that applies the theme throws an error that stops docker from starting.
Theme Install Method (Don't skip)

Docker

Fix in #412

Thanks, I rebased to develop and merged it.

Thank you for implementing the fix so quickly.


Question: Use newer version of WebView2

I cannot even find which version of webview2 is coupled with the Windows App SDK but I need features included in newer release. Is there a way to use a newer version of WebView2 with Winui3?

We're currently using 1185, for the 1.3 release we'll update to the latest public version. At this time, the WebView2 version is coupled with the WinAppSDK version.