feat: Builder uses inference for deltas of nested DFGs

For both DFGBuilder::new, and the fn dfg_builder in builder trait Dataflow,

Rename the existing variant (that takes a FunctionType), adding a _ft suffix.
The old name now takes 2*TypeRow (in the case of dfg_builder, the input TypeRow is combined with the wires), and uses an ExtensionSet that is just TO_BE_INFERRED
Add a variant with an _endo suffix that does not require any output types to be specified (these are taken from the inputs).

The use of _endo/_ft, which seems like an adjective, as a suffix to dfg_builder may seem a little odd but (a) it's more consistent with new and (b) when searching through a list of methods, it's nice to have variants of the same concept together (alphabetically) rather than widely-distributed.
This finishes #640.
We can add similar .cfg_builder, etc., variants too, but I'm leaving that for another PR. These are sufficient to make the tests worsened by #1142 become "nice" again (as nice as they were, I argue). However I've left as is the many tests for which (pending #388) an empty ExtensionSet is correct; these will probably need changing when we fix #388 (next....)

On #1195, @ss2165 wrote:

Thoughts on builder interface:

Builders that infer extensions should be default, therefore they should have the short names (probably just the set of names we currently use with explicit deltas).
Explicit delta versions, if necessary, can have some standard naming convention (e.g. dfg_builder_delta)
Could a potential simplification be just to require FunctionType inputs wherever possible (rather than in_types + out_types) and then make the default extension set in FunctionType TO_BE_INFERRED. Then with_extension_delta on FunctionType would overwrite the default set? Are there uses of FunctionType where having the default extension set be empty is important?

On #1195, @ss2165 wrote:
Thoughts on builder interface:

Could a potential simplification be just to require FunctionType inputs wherever possible (rather than in_types + out_types) and then make the default extension set in FunctionType TO_BE_INFERRED. Then with_extension_delta on FunctionType would overwrite the default set? Are there uses of FunctionType where having the default extension set be empty is important?

On the latter - yes: every time a FunctionType is used inside a Type::new_function, say, or for a FuncDefn (which we don't infer, but I suppose could - just requires a more complex algorithm that builds a call graph and looks for cycles), or a FuncDecl (which we definitely can't infer). Also not for OpDef signatures...
Moreover whilst I agree that the builder should default to inference I'm less sure about Hugr's built directly without the builder. One thing we could do though would be

Rename FunctionType::new (i.e. empty-delta) to ::new_pure
Add FunctionType::new taking 2*TypeRow + ExtensionSet
Same for new_endo / new_pure_endo
Add FunctionType::new_inferred (or maybe a shorter name) taking 2*TypeRow (and setting TO_BE_INFERRED)
And ::new_inferred_endo

However whilst fine for directly-constructed Hugrs (inference is available at reduced cost but still slightly more than being explicit, which feels right) this still leaves the builder wanting.
I also thought about making the builder methods take not a FunctionType but an impl Into<FTSpec> (for some new type FTSpec) where we impl From<FunctionType> for FTSpec (providing all the existing interfaces from before this PR), but then we can also have impl From<(TypeRow, TypeRow)> for FTSpec (with extensions TO_BE_INFERRED) and impl From<TypeRow> for FTSpec (endomorphic TO_BE_INFERRED). However the problem with this is that we rely heavily (e.g. in FunctionType::new) on impl Into<TypeRow> with all sorts of handy conversions there (e.g. from a single Type or Vec<Type>) which we'd not be able to use. (I think the Rust foreign-trait impl rule prevents us from defining transitive conversions - we can't have impl <T: Into<TypeRow>> From<T> for FTSpec as we might like.)
Hence I think specific builder functions are the right way to go...

@ss2165 sending this your way because you looked at the original (#1195) from which this was split. Feel free to reassign....

Hmmm, I'm starting to think that having a new type BuilderFunctionTypeSpec (call it FTSpec or ContainerSpec or something maybe) with factory methods new_endo(impl Into<TypeRow>), new(impl Into<TypeRow>, impl Into<TypeRow>), new_fixed_exts(impl Into<TypeRow>, impl Into<TypeRow>, impl Into<ExtensionSet>), maybe alsonew_endo_fixed_exts might be the best way to go. (new_fixed_exts could also take a FunctionType but taking the three params will require less typing at use sites).
Roughly, we're gonna want to change the builder interface for DFGs, CFGs, and simple-basic-blocks, also non-simple basic blocks + Conditionals + TailLoops (these have an extra row of common inputs), that's gonna be a lot of new methods if we add _endo and _ft variants of each one...

Ok, redone with a couple of helper methods. I admit/agree that ft1 and ft2 are extremely terse names...but that is part of the point.... ;-).   (foo,) where foo is a row/type/etc. would be even shorter, but I've not gone there...(I honestly think I could be persuaded!)


WS features - App returns to the same WS settings page after toggling on a feature

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.51-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR https://github.com/Expensify/App/pull/37441
Action Performed:
Precondition:

User is an owner of Collect workspace
The Collect workspace has enabled categories

Go to staging.new.expensify.com
Go to workspace settings > Collect workspace
Go to More features
Toggle on any feature (toggle off first if there is disabled feature)
Return to previous page via device back navigation

Expected Result:
App will not return to the same page. App will return to workspace list
Actual Result:
App returns to the same workspace settings page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/cf0660ba-cd14-417b-9cbd-2a43560614b1
View all open jobs on GitHub

We think that this bug might be related to #wave-control
CC @Jason

@marcaaron  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Looks connected to https://github.com/Expensify/App/pull/37441 cc @mountiny @rezkiy37 @luacmartins
The above proposal looks like it will work. But maybe we are already looking into this?

This is not a blocker since the feature is still WIP and very few people have access to Collect workspaces on NewDot. cc @rezkiy37 can you work on a fix for this one as well?

Head up, just merged the ideal nav v2 so it might influence the solution a bit regarding routes

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

I've tested the bug. The bug is not replicable after the "Ideal Nav V2" merging. I tested on a real Android Device and macOS Chrome. Can you retest also, please?
cc @lanitochka17
https://github.com/Expensify/App/assets/57314631/6f314f56-5a93-4377-8d6e-5763e1683d94

However, I agree that the goBack looks better and natural. I would create a PR to use Navigation.goBack(ROUTES.WORKSPACE_INITIAL.getRoute(policyID));. When we deep-link to the "More features" page for the 1st time, it calls navigate with CONST.NAVIGATION.TYPE.FORCED_UP, but after the navigation history has been initiated and goBack works smoothly.
WDYT, @mountiny?
https://github.com/Expensify/App/assets/57314631/2c25d9e3-9a11-4f36-b79c-7150b91110be

One more thing I see is that the app uses a legacy route for the "More features" page.

@rezkiy37 The proposed changes sound good to me, can you make 2 PRs. Once to address the route and other to address the navigation.
thank you

@mountiny, I've opened PRs: https://github.com/Expensify/App/pull/38398, https://github.com/Expensify/App/pull/38396.

Thanks, merged the route one and @ishpaul777 got autoassigned to the other one, making this $250 as its quite easy change

Hi! reapplying the bug label as I will be OOO on the 26th March. I am back on April 2nd.

Hi @abekkala Just a note to say, I am OOO now until April 2nd, reassigning BZ team member to help while I am OOO.

@zanyrenney I'm going to be ooo as well. It's best practice to check the ooo calendar and reapply if needed.

PAYMENT SUMMARY FOR MAR 26

@rezkiy37 does not require payment (Contractor)
@ishpaul777 $250 automatic offer (Contributor)

@bfitzexpensify - @zanyrenney was the original assignment. She is going ooo.
I've provided the Payment summary above and reapplied the label. I verified that you were not currently on the ooo calendar for Mar 26
Thansk!

Just pending payment

All done!

Hey @ishpaul777 - looks like payment was issued March 27th for Expensify GH #38185 - Contributor - [$500] [Wave Collect] [More Features] WS features - App returns to the same WS settings page after toggling on a feature
Can you check that on your end?


[Issue 14052] Fixes use default KEY_SHARE ConsistentHashingStickyKeyConsumerSelector cause flaky-test

Fixes #14052
Master Issue: #14052
Motivation
See #14052
Modifications

Make producer start after the consumer.
Make random message key distribute eventually consistent.

Verifying this change

[x] Make sure that the change passes the CI checks.

Documentation

[x] no-need-doc

@lhotari  @Jason918  PTAL :)

Hi, @Jason918
I saw your comment and thought maybe we don't need to make changes.
So I will roll back the changes you left in the comments.

PTAL :-)

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks


Monitoring metric set size

Is your feature request related to a problem?
We're running into the default metric_set_limit (#2148, #2717) (probably due to many different transaction names). We can obviously increase the limit now based on a good guess, but it doesn't seem possible to examine the current metric set size.
We'd like to be able to monitor the metric set size to ensure we're well below the limit, but still keep the limit rather low to prevent explosion.
Describe the solution you'd like
It'd be great if we could add a micrometer gauge that monitors the metric set size, or if this becomes a built-in metric.
Describe alternatives you've considered
Raising the limit higher than necessary.

would periodically logging the value work for you?

Logging would be a good start, but my preferred way would be exposing the size either via the health metrics or via a public API, so I can create my own metric from that.


Update CONTRIBUTING.md

Which problem is this PR solving?

Short description of the changes

@NavneetKatiyar sorry, but I'm closing this PR without merging. It's not clear to me why you opened this one here, only to include two white spaces where it's not needed. Also, this is my working fork of the main repository: any changes should be submitted to jaegertracing/jaeger instead.


Command still hasn't been written into connection! Try to increase nettyThreads setting. Payload size in bytes: 0.

redis:
redisson:
server-mode: cluster_servers
threads: 16
netty-threads: 32
common-config:
common-cluster-config:
master-connection-minimum-idle-size: 32
master-connection-pool-size: 64
slave-connection-minimum-idle-size: 32
slave-connection-pool-size: 64
subscription-connection-minimum-idle-size: 8
subscription-connection-pool-size: 32

version：3.17.3

You need refer to this section https://github.com/redisson/redisson/wiki/16.-FAQ#q-what-is-the-cause-of-redistimeoutexception


Unsure if I am not seeing it, but is there a option for Typescript/React conversions?

For example converting all svg attributes such as "stroke-width" -> "strokeWidth".

You can try for this https://github.com/gregberge/svgr


Prepare for release 3.7.1

Pull Request Test Coverage Report for Build 225

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 224:
0.0%

Covered Lines:
399

Relevant Lines:
399

💛  - Coveralls


Phone calls can trigger immediate crash

I was trying to simulate starting a KrakenTalk phone call with a Javascript script by opening a websocket to the endpoint https://beta.twitarr.com/api/v3/phone/socket/initiate/DCB94249-4562-493D-964C-C3E733FBD5D3/to/46E2B505-FA66-4A4C-80EF-3BF5D253579F. The callID DCB94249-4562-493D-964C-C3E733FBD5D3 is a random UUID I generated. The userID 46E2B505-FA66-4A4C-80EF-3BF5D253579F is the sam user.
If Sam doesn't have a notification socket open (like if it's only logged in via the browser) then the app basically does nothing which is expected and produces the following logs:
[ INFO ] GET /api/v3/phone/socket/initiate/DCB94249-4562-493D-964C-C3E733FBD5D3/to/46E2B505-FA66-4A4C-80EF-3BF5D253579F -> 101 Switching Protocols [request-id: A73EACD1-186D-4825-B3CB-C24FC1D43EDB]
[ NOTICE ] Attempt to call user with no notification socket. [request-id: A73EACD1-186D-4825-B3CB-C24FC1D43EDB]

But if Sam is logged in via Tricordarr which opens a notification socket and the same call is made, the app immediately crashes:
[ INFO ] GET /api/v3/phone/socket/initiate/DCB94249-4562-493D-964C-C3E733FBD5D3/to/46E2B505-FA66-4A4C-80EF-3BF5D253579F -> 101 Switching Protocols [request-id: 03E58630-D14C-4AAD-A90C-BF8AC441B2DC]
[ NOTICE ] Creating phone socket. [request-id: 03E58630-D14C-4AAD-A90C-BF8AC441B2DC]
[ NOTICE ] Sending incoming phonecall to callee. [request-id: 03E58630-D14C-4AAD-A90C-BF8AC441B2DC]
[ NOTICE ] Sending incoming phonecall to callee. [request-id: 03E58630-D14C-4AAD-A90C-BF8AC441B2DC]
Received signal 4. Backtrace:
[ INFO ] GET /api/v3/notification/global -> 200 OK [request-id: 50B32616-134E-4603-A527-8E104788A120]
0x55c43126bdf2, Backtrace.(printBacktrace in _B82A8C0ED7C904841114FDF244F9E58E)(signal: Swift.Int32) -> () at /app/.build/checkouts/swift-backtrace/Sources/Backtrace/Backtrace.swift:80
0x55c43126c067, closure #1 (Swift.Int32) -> () in static Backtrace.Backtrace.install(signals: Swift.Array<Swift.Int32>) -> () at /app/.build/checkouts/swift-backtrace/Sources/Backtrace/Backtrace.swift:94
0x55c43126c067, @objc closure #1 (Swift.Int32) -> () in static Backtrace.Backtrace.install(signals: Swift.Array<Swift.Int32>) -> () at /app/<compiler-generated>:93
0x7fd2dc75751f
0x55c431c76310, Swift runtime failure: precondition failure at /app/<compiler-generated>:0
0x55c431c76310, function signature specialization <Arg[0] = Dead, Arg[1] = Dead> of (extension in NIOCore):NIOCore.EventLoop.preconditionInEventLoop(file: Swift.StaticString, line: Swift.UInt) -> () at /app/<compiler-generated>:0
0x55c431c76310, (extension in NIOCore):NIOCore.EventLoop.preconditionInEventLoop(file: Swift.StaticString, line: Swift.UInt) -> () at /app/<compiler-generated>:0
0x55c431c76310, generic specialization <@Sendable (WebSocketKit.WebSocket, NIOCore.ByteBuffer) -> ()> of NIOCore.NIOLoopBoundBox.value.setter : A at /app/<compiler-generated>:0
0x55c431c76310, WebSocketKit.WebSocket.onBinary((WebSocketKit.WebSocket, NIOCore.ByteBuffer) -> ()) -> () at /app/.build/checkouts/websocket-kit/Sources/WebSocketKit/WebSocket.swift:66
0x55c431e1bf81, (4) suspend resume partial function for swiftarr.PhonecallController.createPhoneSocket(Vapor.Request, WebSocketKit.WebSocket) async -> () at /app/Sources/swiftarr/Controllers/PhonecallController.swift:274
0x7fd2dd2a50cd
0x7fd2dd2a589b
0x7fd2ddde6773
0x7fd2ddde6521
0x7fd2dddf2001
0x7fd2dc7a9ac2
0x7fd2dc83a813
0xffffffffffffffff

The Android app reported a socket message came through matching what we expect, so whatever issue here is happening immediately after the call notification goes through.
I was able to reproduce this in the Beta, my personal instance, and locally. Analyzing the coredump yields:
* thread #1, name = 'swiftarr', stop reason = signal SIGILL: illegal operand
  * frame #0: 0x000056135ea49310 swiftarr`$s12WebSocketKit0aB0C8onBinaryyyyAC_7NIOCore10ByteBufferVtcF at <compiler-generated>:0
    frame #1: 0x000056135ebeef82 swiftarr`$s8swiftarr19PhonecallControllerV17createPhoneSocketyy5Vapor7RequestC_03WebF3Kit0iF0CtYaFTY3_ at PhonecallController.swift:274:6
    frame #2: 0x00007f321b3900ce

I thought maybe this was being triggered by having multiple NotificationSockets open. But it still died even when I had only one (logged the calleeNotificationSockets.count to be sure).

Oh. Pretty sure it's https://github.com/vapor/websocket-kit/issues/140

Workaround described in https://github.com/vapor/websocket-kit/issues/140 seems to be functioning!


🆕 Software Suggestion | Web Torrent Checker

Basic Information
Name: Web Rorrent Checker
Category: Torrenting
URL: https://checker.openwebtorrent.com/
Description
This service help the users to check for Number of Seeds and Peers for a Torrent or a Magnet Link before Downloading
Why I am making the suggestion
This would be great for Torrenting Users and also the project is Open-Source. Check it out here : https://github.com/alxhotel/webtorrent-checker
My connection with the software
I have no connection with Software just a user of the Service

[x] I will keep the issue up-to-date if something I have said changes or I remember a connection with the software.

I doubt this will get added since this seems more related to privacy in piracy (which I'm all for it) but it's not the focus of Privacy Tools. Cool project, though!


Default Codes issue

Click on Get DTC then Its not giving trouble code whether trouble code coming in live data. it gives OBD Command Failure.

Have you tried the latests version of the app? This should have been fixed in a previous PR.

Closing for now. Will re-open if there's proof this doesn't work.


Getting a PairingError: Error=BackOff while trying to pair

Analysis
I haven't been able to pair my device because of the error described below.
If I understand correctly the device asks for a backoff time before retrying to pair but the plugin retries 1 min after
It seems there's some logic to handle this case, but I'm not sure it is working because the following warning does not show up:
https://github.com/maxileith/homebridge-appletv-enhanced/blob/f0395a352571ded4c893ef3d2a15d3453379a261/src/appleTVEnhancedAccessory.ts#L1094
Expected Behavior
I'd expect the plugin to wait for the backoff time before retrying
Steps To Reproduce
I have just installed the plugin in tried to pair my Apple TV
Logs
[17/12/2023, 12:01:11] [Apple TV Enhanced] *** (****): stdout: 2023-12-17 12:01:11 ERROR [pyatv.scripts.atvremote]: Pairing failed
Traceback (most recent call last):
  File "/var/lib/homebridge/appletv-enhanced/.venv/lib/python3.9/site-packages/pyatv/support/__init__.py", line 71, in error_handler
    return await func(*args, **kwargs)
  File "/var/lib/homebridge/appletv-enhanced/.venv/lib/python3.9/site-packages/pyatv/protocols/companion/auth.py", line 63, in start_pairing
    pairing_data = _get_pairing_data(resp)
  File "/var/lib/homebridge/appletv-enhanced/.venv/lib/python3.9/site-packages/pyatv/protocols/companion/auth.py", line 33, in _get_pairing_data
    raise exceptions.AuthenticationError(stringify(tlv))
pyatv.exceptions.AuthenticationError: Error=BackOff, BackOff=1548s, SeqNo=M2

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/var/lib/homebridge/appletv-enhanced/.venv/lib/python3.9/site-packages/pyatv/scripts/atvremote.py", line 196, in pair
    await self._perform_pairing(pairing)
  File "/var/lib/homebridge/appletv-enhanced/.venv/lib/python3.9/site-packages/pyatv/scripts/atvremote.py", line 206, in _perform_pairing
    await pairing.begin()
  File "/var/lib/homebridge/appletv-enhanced/.venv/lib/python3.9/site-packages/pyatv/protocols/companion/pairing.py", line 47, in begin
    await error_handler(
  File "/var/lib/homebridge/appletv-enhanced/.venv/lib/python3.9/site-packages/pyatv/support/__init__.py", line 77, in error_handler
    raise fallback(str(ex)) from ex
pyatv.exceptions.PairingError: Error=BackOff, BackOff=1548s, SeqNo=M2

Configuration
{
            "mediaTypes": [
                "music",
                "video"
            ],
            "deviceStates": [
                "paused",
                "playing"
            ],
            "remoteKeysAsSwitch": [
                "turn_off",
                "turn_on"
            ],
            "customInputURIs": [],
            "discover": {
                "unicast": [],
                "blacklist": [],
                "multicast": true
            },
            "name": "Apple TV Enhanced",
            "avadaKedavraAppAmount": 15,
            "disableVolumeControlRemote": false,
            "forceVenvRecreate": false,
            "logLevel": 3,
            "platform": "AppleTVEnhanced"
        }

Environment

OS: raspberry 2
Homebridge: 1.7.0
Apple TV Enhanced: 0.7.0
Node: 20.10.0
npm: 10.2.3
Python: 3.9.2

Trying to pair an Apple TV 4K (gen 3)
Additional Context
No response

For additional context, I tried to turn off the plugin to wait for the backoff time and re-enabling it back, I now have the following error at first attempt: pyatv.exceptions.PairingError: Error=Authentication, SeqNo=M4
and then back looping to the pyatv.exceptions.AuthenticationError: Error=BackOff, BackOff=1548s, SeqNo=M2 errors

Please post the complete debug logs from the start of the plugin until the error occurs.

I have just recreated the bug, you were right. The problem should be fixed in v0.7.1-1. Could you please verify that?

Hi @maxileith yes I can confirm that it is working on 0.7.1-1
Thanks a lot!!


correct grammar

Summary

Ticket Link

Checklist

[ ] Telemetry updated
[ ] Gated by experimental feature flag
[ ] Unit tests updated

/check-cla


Knife is ignoring values in config.rb on Windows 10

Description
I've installed chefdk v3.2.30 on my Windows 10 laptop and have a chef server running in AWS. I created the following config.rb in both the current working directory (..chef\config.rb) and verified that it is being used when knife runs:
current_dir = File.dirname(__FILE__)
log_level                 :debug
log_location              STDOUT
node_name                 "chefadmin"
client_key                "#{current_dir}/chefadmin.pem"
chef_server_url           'https://ec2-52-87-185-47.compute-1.amazonaws.com/organizations/4thcoffee'
cookbook_path             ["#{current_dir}/../cookbooks"]

When I run knife ssl check it tries to connect to localhost however:
PS C:\Users\jsnider1\workspace\learn-chef> knife ssl check -V -V
INFO: Using configuration from C:/Users/jsnider1/workspace/learn-chef/.chef/config.rb
Connecting to host localhost:443
Traceback (most recent call last):
        13: from C:/opscode/chefdk/bin/knife:306:in `<main>'
        12: from C:/opscode/chefdk/bin/knife:306:in `load'
        11: from C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.4.56-universal-mingw32/bin/knife:24:in `<top (required)>'
        10: from C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.4.56-universal-mingw32/lib/chef/application/knife.rb:161:in `run'
         9: from C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.4.56-universal-mingw32/lib/chef/knife.rb:220:in `run'
         8: from C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.4.56-universal-mingw32/lib/chef/knife.rb:445:in `run_with_pretty_exceptions'
         7: from C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.4.56-universal-mingw32/lib/chef/local_mode.rb:44:in `with_server_connectivity'
         6: from C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.4.56-universal-mingw32/lib/chef/knife.rb:446:in `block in run_with_pretty_exceptions'
         5: from C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.4.56-universal-mingw32/lib/chef/knife/ssl_check.rb:249:in `run'
         4: from C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.4.56-universal-mingw32/lib/chef/knife/ssl_check.rb:130:in `verify_cert'
         3: from C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.4.56-universal-mingw32/lib/chef/knife/ssl_check.rb:80:in `verify_peer_socket'
         2: from C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.4.56-universal-mingw32/lib/chef/mixin/proxified_socket.rb:36:in `proxified_socket'
         1: from C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.4.56-universal-mingw32/lib/chef/mixin/proxified_socket.rb:36:in `new'
C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.4.56-universal-mingw32/lib/chef/mixin/proxified_socket.rb:36:in `initialize': No connection could be made because the target machine actively refused it. - connect(2) for "localhost" port 443 (Errno::ECONNREFUSED)

But if I supply the chef server URL as a command-line option it works:
PS C:\Users\jsnider1\workspace\learn-chef> knife ssl check -V -V -s https://ec2-52-87-185-47.compute-1.amazonaws.com/org
anizations/4thcoffee
INFO: Using configuration from C:/Users/jsnider1/workspace/learn-chef/.chef/config.rb
Connecting to host ec2-52-87-185-47.compute-1.amazonaws.com:443
Successfully verified certificates from `ec2-52-87-185-47.compute-1.amazonaws.com'

I have no way of supplying other configuration parameters (such as node_name) via the command-line however, so knife cookbook list and similar fail.
ChefDK Version
PS C:\Users\jsnider1\workspace\learn-chef> chef --version
Chef Development Kit Version: 3.2.30
chef-client version: 14.4.56
delivery version: master (6862f27aba89109a9630f0b6c6798efec56b4efe)
berks version: 7.0.6
kitchen version: 1.23.2
inspec version: 2.2.70

Platform Version
Windows 10
Replication Case
Create a chef server that is configured with a self signed cert that matches the FQDN and a config.rb configured for talking to it. Then try using knife without command-line options.
Stacktrace
Stacktrace included in description.
NOTE: CHEFDK BUGS ONLY
This issue tracker is for the code contained within this repo -- chefdk.

Server issues
Chef-client issues
Cookbook Issues (see the https://github.com/chef-cookbooks repos or search Supermarket or GitHub/Google)

Closing this out since we're no longer supporting DK. If you run into this issue with Workstation / knife 17 please open a new issue.


Tie Fighter 95 no mouse cursor.

Hello There !
I'm trying this on the Steam version (Remastered but is the win95 version), to see if the dreadful 3d hardware bug, that comes with the ddraw version they ship gets solved.
Only problem is, I got no mouse arrow using DDrawCompat. So can't even get to the actual 3d part of the game to test it out. Wondering what I could be doing wrong ? Game got updated recently also, and the ddraw that comes with, cursor works fine out of the fresh install. When in DDrawCompat mouse seems to work fine only in the overlay with shift+f11, but as I exit, back to no cursor.
Is there a config I'm missing out ? I looked for in the wiki page, but no luck
Thx again, great piece of app you got here !

I only have the GOG version, but it has the same issue. There is no cursor with native ddraw or dgVoodoo2 either, so I'm starting to think it's not a DDrawCompat issue. Maybe the default ddraw wrapper hacks in its own cursor somehow.
Anyway, I found a workaround on GOG forums: https://www.gog.com/forum/star_wars_xwing_and_tie_fighter_series/missing_cursor
The launcher is called TIESTART.EXE for me, and it has a Use Software Cursor setting under Advanced Options. You have to start the game through the launcher to make it work.
Alternatively, create a shortcut for TIE95.EXE with the /softwarecursor command line option, and start the game through that one.

I will tried it out ! worked like a charm ! Pretty much just added /softwarecursor into launch options on the proprieties menu ! Thx for the info ! and the great app !


Move logical_meter.grid_power to microgrid.grid.power

Now that we have a microgrid.grid object, we should publish metrics there, like we do with battery_pool.
Originally posted by @llucax in https://github.com/frequenz-floss/frequenz-sdk-python/pull/722#discussion_r1357871453

When changing, this needs also updating of the documentation including the code snippets on frequenz.com frontpage.

we should publish metrics there, like we do with battery_pool.

@daniel-zullo-frequenz can you go a little bit more in detail on this, such that I could potentially take that ticket over? :-)


Integrating MQT bench into red-queen

Add MQT benchmarks to Red Queen framework: This is part of QAMP Fall 2022 project. This pull request is meant to be a preliminary sanity check of the structure of the files and the method.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


err="pq: password authentication failed for user "postgres""

According to Getting started with Prometheus and TimescaleDB, when I start the prometheus_postgresql_adapter container, I get an error.
level=info ts=2019-04-18T06:46:39.906315481Z caller=log.go:25 config="&{remoteTimeout:30000000000 listenAddr::9201 telemetryPath:/metrics pgPrometheusConfig:{host:pg_prometheus port:5432 user:postgres password: database:postgres schema: sslMode:disable table:metrics copyTable: maxOpenConns:50 maxIdleConns:10 pgPrometheusNormalize:true pgPrometheusLogSamples:true pgPrometheusChunkInterval:43200000000000 useTimescaleDb:true dbConnectRetries:0 readOnly:false} logLevel:debug haGroupLockId:0 restElection:false prometheusTimeout:-1}"
level=info ts=2019-04-18T06:46:39.906416995Z caller=log.go:25 msg="host=pg_prometheus port=5432 user=postgres dbname=postgres password='' sslmode=disable connect_timeout=10"
level=error ts=2019-04-18T06:46:39.910818007Z caller=log.go:33 err="pq: password authentication failed for user "postgres""

Hmmm.... I wonder if that's due to different security setting in newest docker image. Can you specify what docker images were used?
Would be useful to try ssh-ing into pg_prometheus docker and try connecting to db from inside (in case db only allows connections from localhost)

thks! docker images are all the latest.
I solved the problem by added the following line to the pg_hba.conf configuration file:
host postgres postgres <IP_ADDRESS>/0 trust
The pg_hba.conf path is in "/var/lib/docker/volumes/docker mount path/_data"

@aioloszcy even that didn't work for mee :( any thing else to fix this ?
as a side note, if i create a separate db and pass its details to postgres-adapter, it is able to connect with that seamlessly..

Hi,
It worked after i restarted the container.
Here is what i did:

figure out where the pg_hba.conf is located:
sudo find   /var/lib/docker/volumes -name "pg_hba*"

I added the
host postgres postgres <IP_ADDRESS>/0 trust
just above 'host all all all md5' line

Then i restarted the pg_prometheus container:
docker restart

start the prometheus_postgresql_adapter  container, you may have to remove it first.


[OFFICIAL] Generated Issue: ErrorException

Summary:
it's unstable. Sometimes it works sometimes it throws a 500.
Steps to reproduce:
IDK, it's unstable. can't reproduce it 100% of the time.
It's just a GET request as seen below with one header:

Content-Type: application/json
send by the axios lib

Additional Details
Jikan Parser Version: 3.0.0.x-dev@151b2d4b200d2bff14089d871b7922f2c678b2b3
PHP: 8.0.14
Redis: Connected
Exception: ErrorException
Code: 0
Message: foreach() argument must be of type array|object, null given
Trace: /var/www/jikan-rest/app/Listeners/SourceHeartbeatListener.php on line 119
Request: GET /v4/anime?q=berserk

Interesting find. Not exactly sure what causes it to be null here:

foreach() argument must be of type array|object, null given

But I've added a check for it so hopefully, it shouldn't bother anymore. Feel free to re-open this issue or another one if it occurs again.


fix compilation error with base-4.8.*

This fixes the following compilation error with GHC-7.10 and base-4.8.*:
src/Data/Heap.hs:41:7:
    Ambiguous occurrence ‘null’
    It could refer to either ‘Data.Heap.null’,
                             defined at src/Data/Heap.hs:174:1
                          or ‘Data.Foldable.null’,
                             imported from ‘Data.Foldable’ at src/Data/Heap.hs:91:1-48
src/Data/Heap.hs:56:7:
    Ambiguous occurrence ‘traverse’
    It could refer to either ‘Data.Heap.traverse’,
                             defined at src/Data/Heap.hs:620:1
                          or ‘Traversable.traverse’,
                             imported from ‘Prelude’ at src/Data/Heap.hs:(81,1)-(86,5)
                             (and originally defined in ‘Data.Traversable’)

This was fixed in 8f20f683479171e16c8321deedaf8562607464c2.


Display git tag instead of commit id, if exists

Q
A

Bug fix?
No

New feature?
Yes

BC breaks?
No

Deprecations?
No

Fixed tickets
N/A

Nice.

Please, rebase. Now slack recipe is ready.


More UI changes or new UI by own

Thanks for very wonderful tool. I run the verdaccio on own server and use it. I need
add some features to UI to have better use for my team. Is there solution to add some components to UI (I mean big changes not for example logo,... ) or change the UI from scratch?

By the way, you can create your own UI from scratch, but it could be a hard work. @priscilawebdev can tell you if there is a way to customize UI without creating from scratch.
Also, you can fork UI and touch the parts you want to modify, but you have to follow License specified in repo 😉

Thanks for very wonderful tool. I run the verdaccio on own server and use it. I need
add some features to UI to have better use for my team. Is there solution to add some components to UI (I mean big changes not for example logo,... ) or change the UI from scratch?

It is not easy to extend, actually was not designed with such purpose rather to be bundled with webpack as the final step. The easier is to build your own, but as @sergiohgz mentioned, it is hard hard work for sure.
We rely a lot on React Context API, so, you might somehow replace modules with Webpack and build your own parts, we have tried to split the UI in several components, I'm just speaking louder without check whether is possible or not.
So I guess you would need to evaluate what is easier for you.

I'm closing this, feel free to keep discussing.

So, currently how much of the UI is customizable? I can see some config options here: https://verdaccio.org/docs/en/webui#configuration, is there anything apart from this that can be easily customized?

So, currently how much of the UI is customizable? I can see some config options here: https://verdaccio.org/docs/en/webui#configuration, is there anything apart from this that can be easily customized?

That + you can add custom endpoints (via plugins middleware) can be invoked from a README.


All 64-bit layers now wobbling...

All 64-bit layers are wobbling as of beta31. I need to do some regression tests tomorrow.
It's highly likely due to recent viewport changes.
Assigning to myself.

Still getting some pretty major wobbling on FP64 layers even on the latest dev branch

@contra Saddly, the 64-bit layers are not supported on 2013 MBP with NVIDIA GPUs from the beginning...because the machine is not available to buy and we could secure one to test... there are some unique peculiarity in mac version of nvidia driver.
I tested MBP with AMD and Intel GPUs, Linux and Windows with NVIDIA GPUs, the wobbling is not there as of today.

@shaojingli Any way I can help out with that? You can use my machine remotely to debug if you want.


Loading problem

Hi. I encountered an issue with my converted saves from Eu4 to Vic2. When I try to load any of the converted saves the game just crashes while on the phase Loading Database II. The funny thing is that sometimes this problem disappears and I can actually play the game with my converted saves. Is there any way to solve this problem? I tried reinstalling and installing Vic2 many times. I have the DLCs needed and Vic2 up to date.

This is being discussed quite a bit on the release thread: https://forum.paradoxplaza.com/forum/index.php?threads/eu4-to-vic2-converter-release-thread.973026
There's a hotfix that may help. If not, I believe a new release is not too far off that should remedy the problems.

Do I need to have Eu4 on the forum account too to see the thread?

You do.

Should be sorted by the new release.


window geometry for toggleable scratchpads not working.

Changing "-g", "120x34" to "-g", "120x34-40-40" in config.h does not change a scratchpad's position, it stays centered. Just launching st -g 80x21-40-40 with floating mode (mod+F) active works fine, a terminal window appears in bottom right corner.

that's because the scratchpad is supposed to be centered by default, there is a separate patch on top of the original scratchpad patch that remembers last saved position of each scratchpad


Implementation method of heatmap visualization (as shown in Figure 6 of the ARTrack paper).

Thanks for your art and solid work. I would like to inquire about how to implement heat map visualization for this autoregressive-based tracker, as shown in Figure 6 of the ARTrack paper. I would greatly appreciate it if you could provide the relevant source code.

So sorry for that i lost that code, but you can make it easy. When u inference in a sequence, you can save the cross-attention map of respective coordinate token and the search region, after that you can use the visulization tools such as: https://github.com/rentainhe/visualization/tree/master. I think you can contribute your tools in 2 hours.

Thank you for your reply.I have made it under your guidance !!


Color string according to Fonts and Colors setting

Currently, the previews seem to get their color from the default VS themes. Installing a custom one will not change the color of the string, making it mismatch the rest of the theme.
I propose two solutions:

Use the value for "String" in the Tools > Options > Environment > Fonts and Colors settings; or
Create a new value in those settings that defaults to whatever color "String" has.

It seems that the issue was a little different than I originally thought: if you change the theme in Visual Studio, the extension doesn't update the string to the new color. Restarting VS will turn the strings the correct color!

Note to self
For reference, see https://docs.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.platformui.vscolortheme.themechanged?redirectedfrom=MSDN&view=visualstudiosdk-2019

This functionality has been added to version 1.6 and is now available in the marketplace.
If this extension is useful to you please leave a review (this both encourages me and helps others find this extension.)
You can also help me continue to develop this and other tools by becoming a sponsor.


Cont3xt Vue3 TODO

[x] less empty space everywhere
[x] reduce size of buttons in navbar, make them fixed width, and change the colors

[ ] Menu bar font!! Why is it ST A TS? Stone age?
[x] Also buttons top of cards, except for the tags trash can that went on a bad diet

[ ] better indication of a search input? (the link group search has the happy little mag glass)
[ ] the itype pulldown next to link group search is missing a icon
[ ] Settings -> Integration disabled checkboxes don't show up or work?
[ ] Settings -> Linkgroups role picking doesn't seem to show on/off (might be all role picking is broken)
[ ] Users tab shows up in navbar even when not an userAdmin
[ ] Users tab and Create new view checkboxes and role picking broken too
[ ] Users/Stats tab table sorting chevrons missing
[ ] Users tab result count looks like leaving room for icon its a pull down but doesn't show it, also pagination missing but maybe it shows up when needed?
[ ] Andy is not a fan of text boxes having the same background of whats around, example Settings -> Integration, maybe just old
[ ] Horizontal centering of text/x in colorful boxes is off. examples: displayed tags, Users tab "Roles (i)",
[ ] History search bar help was more complete in old version "Search history by indicator, iType, or tags (case-sensitive)"
[ ] move away from font awesome
[ ] minimize bundle size
[x] remove dev console misinformation
[x] fix console warnings on startup
[ ] do we need concurrently lib?
[x] missing Arkime logo
[x] bulk queries are hideous
[ ] deployment error: Refused to apply style from 'https://.../mdi-font/css/materialdesignicons.min.css' because its MIME type ('text/html') is not a supported stylesheet MIME type, and strict MIME checking is enabled.

"maybe just old" 🤣

We don't need the concurrently library, but I do like it, so I'm keeping it. https://www.npmjs.com/package/concurrently
I tried running the npm run cont3xt:dev with & and not concurrently, and while it works, the concurrently output looks better and is easier to read.


Lint not correct for a switch/case with ternary operator

Pint Version
1.3.8
PHP Version
8.2.12
Description
Hello,
We encountered a bug when we lint a file containing a switch with a case with a ternary operator.
This is a example class before lauching pint
<?php

declare(strict_types=1);

namespace App;

class testPintClass
{
    public function test($foo): string
    {
        switch ($foo) {
            case 1:
            case 2:
                return 3 ? '2': '';
            case 3:
            case 4:
                return 'more';
        }
    }
}

Notice that there is no space between '2' and :.
This is the pint.json file
{
    "preset": "laravel",
    "rules": {
        "operator_linebreak": {
            "position": "beginning"
        }
    }
}

Launching pint
Result with Pint version 1.3.7 👍
    public function test($foo): string
    {
        switch ($foo) {
            case 1:
            case 2:
                return 3 ? '2' : '';
            case 3:
            case 4:
                return 'more';
        }
    }

The space between '2' and : is added
The code is 👍

Result with Pint version 1.3.8 ❌
    public function test($foo): string
    {
        switch ($foo) {
            case 1:
            case 2:
                return 3 ? '2' : '';
            case 3
            :case 4
            :return 'more';
        }
    }

The space between '2' and : is added
The code from :case 4 line is awful

More infos
This problem is not present when using preset symfony (but present with preset psr12)
I'm available to give more informations.
Steps To Reproduce
Everything is in the description.

Thank you, this seems more of an issue with PHP CS Fixer itself. Could you open an issue on their repo and provide them with a reproducible example using just PHP CS fixer? Thanks

The laravel preset is given by pint ? Where can I find the php-cs-fixer configuration for laravel preset.

 "operator_linebreak": {
            "position": "beginning"
        }

We don't create these rules. If your issue is with one of these it's best to provide a reproducible example for PHP CS Fixer.


ref(deisctl): clean up some parsing and error behavior

Note: ./deisctl will trigger a docopt error because it wasn't given any command line arguments. However, this error is empty, so go just prints an empty line. I think it looks better, but it is a slight change in behavior.  The advantage is that if docopt has an actual error, instead of throwing it away like we currently do we print it.
Before:
$ deisctl
Usage: deisctl [options] <command> [<args>...]
$

After:
$ deisctl
Usage: deisctl [options] <command> [<args>...]

$

Nice cleanup, though for now I wouldn't print the nil error. If we bump docopt and it prints an error message, we can update the code but for now let's keep it neat and pretty :)
The rest is covered by unit tests (including the --help flag stuff), so I'm confident that this won't break backwards compatibility. I'm assuming that docopt is already doing this for us?

@bacongobbler The problem is that docopt can return errors with text. It's just that the most common error (if no args are passed to deisctl docopt) docop throws an error of "".
I see these options:

Don't print docopt errors, which might mask some legitimate errors.
Print errors, but this prints the "" error of no arguments.
We check if the error is a null string and if it is don't print it.

We check if the error is a null string and if it is don't print it.

I like that idea. If docopt isn't giving us any information then there's nothing to report!

@bacongobbler Done!

Code LGTM.

code LGTM


recursive tag union with expect: entered unreachable code

app "first"
    packages { pf: "https://github.com/roc-lang/basic-cli/releases/download/0.3.2/tE4xS_zLdmmxmHwHih9kHWQ7fsXtJr7W7h3425-eZFk.tar.br" }
    imports [pf.Stdout]
    provides [main] to pf

Term : [
    Foo,
    Bar [A, B] Term,
]

f : Term -> Term
f = \term -> term

expect
    thing = Bar A Foo
    f thing == Foo

main =
    Stdout.line "hello"

$ cargo run test first.roc
    Finished dev [unoptimized + debuginfo] target(s) in 0.65s
     Running `/Users/ajainelson/prog/roc/roc/target/debug/roc test first.roc`
thread 'main' panicked at 'internal error: entered unreachable code: Something had a RecursivePointer layout, but instead of being a RecursionVar and having a known recursive layout, I found (Structure(TagUnion(UnionLabels { length: 2, labels_start: 130, values_start: 170, _marker: PhantomData<roc_module::ident::TagName> }, Openness(1636))), Loop(InLayout(20)))', /Users/ajainelson/prog/roc/roc/crates/repl_eval/src/eval.rs:672:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
$

And here's another similar example that produces a slightly different error:
app "second"
    packages { pf: "https://github.com/roc-lang/basic-cli/releases/download/0.3.2/tE4xS_zLdmmxmHwHih9kHWQ7fsXtJr7W7h3425-eZFk.tar.br" }
    imports [pf.Stdout]
    provides [main] to pf

Type : [A Type, B]

Term : [
    Foo,
    Bar Type Term,
    Baz Term,
]

f : Term -> Term
f = \term -> term

expect
    thing = Bar (A B) Foo
    f thing == Foo

main =
    Stdout.line "hello"

$ cargo run test second.roc
    Finished dev [unoptimized + debuginfo] target(s) in 0.56s
     Running `/Users/ajainelson/prog/roc/roc/target/debug/roc test second.roc`
thread 'main' panicked at 'internal error: entered unreachable code: any other variant would have a different layout', /Users/ajainelson/prog/roc/roc/crates/repl_eval/src/eval.rs:835:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
$

Roc version: built from source on ef05ec6906d17f6a9f181327950430ca89bb78bc

No longer panics. Now the expects just fail.
Output for cargo run test first.roc:
── EXPECT FAILED in first.roc ──────────────────────────────────────────────────

This expectation failed:

14│>  expect
15│>      thing = Bar A Foo
16│>      f thing == Foo

When it failed, these variables had these values:

thing : [
    Bar [
        A,
        B,
    ] a,
    Foo,
] as a
thing = Bar A Foo

1 failed and 0 passed in xxx ms.

Output for cargo run test second.roc:
── EXPECT FAILED in second.roc ─────────────────────────────────────────────────

This expectation failed:

17│>  expect
18│>      thing = Bar (A B) Foo
19│>      f thing == Foo

When it failed, these variables had these values:

thing : [
    Bar [
        A a,
        B,
    ] as a b,
    Baz b,
    Foo,
] as b
thing = Bar (A B) Foo

1 failed and 0 passed in xxx ms.

I don't think I was expecting those tests to pass; I was just expecting it not to panic. So I guess this is fixed!


Improve Minio examples documentation

Fixes #325 #326 #327

I don't re-run to check it yet, the text /lgtm. Thanks @andresmgot


Actual viewing of saved content/formatting of a procedure

Is your feature request related to a problem? Please describe.
When viewing the contents of a procedure on the sql server with sp_helptext, the content comes with a double line break, a different format than the one created and others characters. Even when viewing the text, it does not return in the format created.
Describe the solution you'd like
The return of the sp_helptext view comes in the same way as the procedure is created or updated.

Sorry for the long responce. I cannot reproduce it. As I see the result returns according procedure DDL.

Can you give additional details to reproduce?

there is no update on the issue for a long time.
If it is still actual for you - feel free to reopen it with an additional info


Aboutu the results graph

Hello, can you tell me hows to get the results graph？

Hi @paidaxing485 ,
Thanks for your attention. Do you mean the figure 3 in the paper? We drew the figure using the python package matplotlib.

@paidaxing485 ,
To get the quantitative results, please refer to this. To visualize the results, please refer to this code from mmsegmentation.


Reintroduce custom prompt

I highly recommend to reintroduce the custom prompt entry to the menu as "marking code" and then "writing in the chat" is a bad user experience and does not explain itself. Without reading related GitHub issues that you chanced the concept, there is no chance I would have figured this out.

Thank you for pointing it out!
I'll add the option back to the editor context menu.

Thanks a lot... I love your plugin. Keep on the good work.

@Jarrodsz This seems duplicate of https://github.com/carlrobertoh/CodeGPT/issues/100

@Jarrodsz I consider this a rude behaviour to hijack someone else issue - stop doing this!


fix(allocator)!: make Vec non-drop

oxc_allocator::Vec is intended for storing AST types in the arena. Vec is intended to be non-drop, because all AST types are non-drop. If they were not, it would be a memory leak, because those types will not have drop called on them when the allocator is dropped.
However, oxc_allocator::Vec is currently a wrapper around allocator_api2::vec::Vec, which is drop. That unintentionally makes oxc_allocator::Vec drop too.
This PR fixes this by wrapping the inner allocator_api2::vec::Vec in ManuallyDrop. This makes oxc_allocator::Vec non-drop.
The wider consequence of this change is that the compiler is now able to see that loads of other types which contain oxc_allocator::Vec are also non-drop. Once it can prove that, it can remove a load of code which handles dropping these types in the event of a panic. This probably also then allows it to make many further optimizations on that simplified code.
Strictly speaking, this PR is a breaking change. If oxc_allocator::Vec is abused to store drop types, then in some circumstances this change could produce a memory leak where there was none before. However, we've always been clear that only non-drop types should be stored in the arena, so such usage was always a bug.
#6622 fixes the only place in Oxc where we mistakenly stored non-drop types in Vec.
The change to oxc_prettier is because compiler can now deduce that Doc is non-drop, which causes clippy to raise a warning about using then instead of then_some.
As follow-up, we should:

Wrap other allocator_api2 types (e.g. IntoIter) in ManuallyDrop too, so compiler can prove they are non-drop too (or reimplement Vec ourselves - #6488).
Introduce static checks to prevent non-drop types being used in Box and Vec, to make memory leaks impossible, and detect them at compile time.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#6623  👈
#6622
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite

What does this all mean?

@Boshen I think this change is worthwhile. It's improving perf pretty much across the board, and #6626 demonstrates that it does not introduce any memory leaks within Oxc.
However, we should probably first check that Rolldown is not erroneously using Vec to store any drop types. I think that's doubtful, but if it was, this change would produce a memory leak in Rolldown. What's the easiest way to do that? Build Rolldown on top of #6626?
Alternatively, we could hold off merging this until we have static checks (like #6626, but more robust) that make it impossible to put Drop types into Box / Vec / the arena.

I'll test Rolldown after the next oxc release.

OK great. I think this can be merged then. I'll leave it to you to merge Boshen in case you want to check the code first.

Merge activity

Oct 19, 11:43 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


doc: update copyright date

Update copyright date to include 2021.
Signed-off-by: Ruth Fuchss<EMAIL_ADDRESS>

we have a PR already... https://github.com/zephyrproject-rtos/zephyr/pull/33496


Fix for Security Hub integration with custom region

If the findings are required to be sent to Security Hub, the resolveSecurityHubPreviousFails function is iterating through all regions, even if a region is set (with -r), and it throws the following error for all the regions where Security Hub is not enabled:
An error occurred (InvalidAccessException) when calling the GetFindings operation: Account xxxxxxxxxx is not subscribed to AWS Security Hub

Error parsing parameter '--findings': Expected: '=', received: 'EOF' for input:

^

 ERROR! Failed to send check output to AWS Security Hub

This pull request solves this issue by using only the selected region.

Hi @reka193, thanks for the heads up, however to filter by region and send findings to the proper region Security Hub you have to use -f region as mentioned in the documentation: https://github.com/toniblyx/prowler#security-hub-integration

Hi @toniblyx, thanks for the quick reply.
In my case, I would like to use prowler for cross-account checks in different regions and send the results to Security Hub.
If I use filtering for e.g. eu-centrail-1, I'm receiving an error for us-east-1 (I believe the first region in the list), unless I set up the region in the .aws/config file, which is not the best idea in this case.
Do you have any recommendations how it could be done?

Hi @toniblyx, thanks for the quick reply, my bad for using the wrong switch.
In my case, I would like to use prowler for cross-account checks in different regions and send the results to Security Hub.
But if I use filtering for e.g. eu-centrail-1, I'm receiving an error for us-east-1, unless I set up the region in the .aws/config file, which is not the best idea in this case.
An error occurred (AccessDeniedException) when calling the BatchImportFindings operation: User: arn:aws:sts::account:role/role/ProwlerAssessmentSession is not authorized to perform: securityhub:BatchImportFindings on resource: arn:aws:securityhub:us-east-1::product/prowler/prowler

 ERROR! Failed to send check output to AWS Security Hub

Do you have any recommendations how it could be done?

If I understand correctly you want to check many accounts and many regions and send all of them to the "same" Security Hub? In Security Hub (regardless Prowler), you have to send findings per region and per account to a master account where there will be everything centralized. Therefore, if you use Prowler integrated to Security Hub you have to scan each region per account and send findings to each region and account Security Hub, then Security Hub will send them to the master account. I hope that is more clear now.

Thanks, that I understand, I am trying to do it this way. In general, the problem I am facing now is independent from the cross-account usage.
As far as I got with the investigation, the problem is with the specific check that I was trying to run. In check15, the region is not passed to the textPass/textFail functions, which then runs sendToSecurityHub without the specified region.
Modifying check15 to the following seems to solve this problem, but correct me if I misunderstood something.
check15(){
  # "Ensure IAM password policy requires at least one uppercase letter (Scored)"
  COMMAND15=$($AWSCLI iam get-account-password-policy $PROFILE_OPT --region $REGION --output json --query 'PasswordPolicy.RequireUppercaseCharacters' 2> /dev/null) # must be true
  if [[ "$COMMAND15" == "true" ]];then
    textPass "Password Policy requires upper case" "$FILTERREGION"
  else
    textFail "Password Policy missing upper-case requirement" "$FILTERREGION"
  fi
}

check15 is part of the CIS AWS benchmark and that is included in Security Hub (you don´t need Prowler for that).

Thank you, I am aware of that. We wanted to run a selected number of checks using prowler, and e.g. extra7100 produces the same error which is not part of the CIS benchmark. (But in general any similar check which doesn't pass on the filtered region.)
It can also be fixed similarly by passing on the $FILTERREGION variable, but it is not part of this pull request anymore.

Since we are still planning to perform these checks using prowler, not the CIS benchmark (mainly to skip Config costs), would you have any recommendations to the above mentioned problem? Thank you!

It is planned to consolidate all checks using the same format as the ones in Extras, to make sure any check works the same way regardless if it comes from CIS or not, that is planned but not sure when it will be implemented. We can try for 2.5 but not sure. The idea is to include also the resource name or ID in the textFail and textPass as variable and leave it available for json, csv, json-asff, etc. that will help for auto-remediation triggers, etc.


Lock methods that iterate over the m_included_modules vector

Fixes #1956

Just for clarity, I actually got a different error before adding cc34116 because we were returning a copy of the vector. But since copying a vector would be similarly racy, I just lumped these two bug fixes together.


Incorrect rendering while resizing the table with lowest scroll position

A very small glitch:
https://www.youtube.com/watch?v=ohHOLLKWckY
Steps to reproduce.
Reduce the height of table
Scroll to the last row of the table
Increase the height of the table

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

Same issue here. Could reproduce by scrolling to the bottom, and then give the table a larger height.

same issue here. :/

The same issue.  Do you have any updates about fixing it?

I'm having the same issue. It's quite annoying.. any known workaround?

@ekros see #376

@safareli did this ever get merged? I don't think I have it in 0.6.4.  This is even worse if your table doesn't take up a full max screen browser.  If the window is smaller than max and you scroll to the bottom then resize/max screen, you can't even scroll anymore because the table thinks your visible area is too small to be scrollable so you can never get back to the top of the data.

@RJSchmertz We've fixed this in our fork, github.com/schrodinger/fixed-data-table-2

@RJSchmertz it' was not merged i just closed that as for me looks like this repo is not maintained + i'm not using it any more :D


Proposal: Separate release pipeline for core and contrib repositories.

Benefits:

Independent release pipeline: Possible to release contrib modules without waiting on core modules.
Easy to manage versions: No need to worry about version sync
Once API/SDK is stable will have less releases in core compared to contrib.

In order to avoid version confusions, we can include "contrib" name in all the packages under contrib repository like @opentelemetry/contrib-plugin-mysql.
It might look something like this:
"dependencies": {
    "@opentelemetry/api,": "0.7.0",
    "@opentelemetry/core,": "0.7.0",
    "@opentelemetry/tracing,": "0.7.0",
    "@opentelemetry/metrics": "0.7.0",
    ....
    "@opentelemetry/contrib-plugin-mysql": "0.6.2",
    "@opentelemetry/contrib-plugin-redis": "0.6.2",
    "@opentelemetry/contrib-propagator-jaeger": "0.6.2",
  }

This is just a rough idea, please add your suggestions.

I like this, but we need to be explicit somewhere about which SDK/API version is required for a specific plugin. Perhaps in the README. Adding contrib to package names is a good idea in my opinion.

@open-telemetry/javascript-approvers

Agree for both the naming and the split of versionning. @dyladan I think we would need to implement something in the code as no everyone read closely the readme and most likely just install the plugins. Could we add a error log if the API version doesn't match ?

we need to be explicit somewhere about which SDK/API version is required for a specific plugin.

Hmmm.. Should we do this for the latest release version or keep a history of the plugin versions?

We could try to completely decouple the plugins from the SDK, and have them only depend on the API. Then the API version code in the other PR would take care of this for us. Not sure how feasible this is.

@dyladan I agree, however we could have problem if a plugin use non-api method (ex: withAsync) :/

The plugin could always just do if (tracer instanceof otel.Tracer) to flag features which require our sdk.

I'll close this since we've done that since few months


overlap() return an empty object

Hi,
my issue is with overlap() function
my genomic regions are pyranges bed :
+--------------+-----------+-----------+------------+-----------+-----------+
| Chromosome   | Start     | End       | Name       | Score     | i         |
| (category)   | (int32)   | (int32)   | (object)   | (int64)   | (int64)   |
|--------------+-----------+-----------+------------+-----------+-----------|
| 1            | 10054     | 10182     | c1         | 0         | 0         |
| 1            | 10182     | 10310     | c2         | 0         | 1         |
| 1            | 10310     | 10438     | c3         | 0         | 2         |
| 1            | 10438     | 10566     | c4         | 0         | 3         |
| ...          | ...       | ...       | ...        | ...       | ...       |
| X            | 156030363 | 156030491 | c7432941   | 0         | 8182881   |
| X            | 156030491 | 156030619 | c7432942   | 0         | 8182882   |
| X            | 156030619 | 156030747 | c7432943   | 0         | 8182883   |
| X            | 156030747 | 156030875 | c7432944   | 0         | 8182884   |
+--------------+-----------+-----------+------------+-----------+-----------+
and the desired region to find overlaps with is query_ranges :
+--------------+-----------+-----------+
|   Chromosome |     Start |       End |
|   (category) |   (int32) |   (int32) |
|--------------+-----------+-----------|
|            1 |         0 |   1000000 |
+--------------+-----------+-----------+
when i do bed.overlap(query_ranges) i get -- . Same happens with intersect()
It really puzzles me. I checked the bed object and it does not have Nan values, both objects are PyRanges objects, there are clearly some regions in bed that could be found within chr1 from 0 to 1000000
Does anybody have any idea what is wrong?
Thanks!

Perhaps Chromosome is not exactly the same? Do you have spaces or tabs or something like that?
If not, please provide data to reproduce the error

Without a reproducible example I cannot help you unfortunately.
Feel free to reopen if you have a reproducible example.


[Bug]: MelonLoader v0.5.7 not using  dotnet 6 while being installed

All of the following criteria must be met

[X] All Requirements must be installed.
[X] Changed the title so that it doesn't just says "[Bug]: "
[X] I have searched the GitHub issues for my bug, even in the closed issues.

All of the following are optional to answer

[ ] Tried reinstalling the Game.
[X] Tried reinstalling MelonLoader.
[X] Tried restarting PC.
[ ] Was able to see the Start Screen.

Describe the issue.
I have all the dependency installed but when I try to run MelonLoader with mods, it won't launch.
Latest.log
Did you attach your log file?
Yes, I attached my log file to the text box above.

MelonLoader 0.5.7 don't support net6 mods


Doesn't render images when exported

The rendered images don't not show when the block is exported from logseq (HTML export and through the export pdf plugin). Maybe it is possible, but I haven't been able to do it. Otherwise, a really cool plugin, thank you!

what plugin do you use?

Do you mean for the export? For the pdf export, I use this one https://github.com/sawhney17/logseq-pdf-export

You may need to use "Print With Retained Formatting" to export to PDF. The first three templates use original markdown to export to PDF. Plugin-rendered content is not inlined in block content and is rendered by the plugin at runtime. I don’t know whether the PDF plugin supports asking the plugin to get content.

That sort of works, but in my case I only get one of the two pages printed (two pages in the pdf, but the second one is blank). Maybe this is not an issue with the draw.io plugin but the export options in Logseq?

yes, logseq need to give more effort to improve.


Ubuntu 20.04 Focal Fossa support missing

I tried to install NetBox on a machine that was upgraded to the latest Ubuntu (LTS) release, and ran into the problem that no OS-specific file such as vars/ubuntu-20.yml was found. So I made one, starting from the ubuntu-18 one. The only modification I made was replacing python3.6 with python3.8, as Focal comes with Python 3.8.  With this new file, I was able to provision a(n apparently) working NetBox installation on my Focal box.
I'm happy to submit a PR. Unfortunately I was unable so far to get Molecule to run the tests on my (Mac OS) development machine, even though I think I have installed all prerequisites.

See #91
The PR works, but causes tests across multiple distributions to fail under Travis CI, so it hasn't been merged. I haven't been able to figure out why...

Interesting. When I run my own branch through the pipeline, I see error messages of the form "unsupported pickle protocol: 5". That may be due to an incompatibility between Python 3.8 (which is what comes with Ubuntu 20.04) and earlier Python versions: Python 3.8 supports Pickle format 5, earlier versions of Python don't.
I don't know NetBox or the tests well enough to understand where this could become a problem.  I do note that in the NetBox source itself, pickle.HIGHEST_PROTOCOL (5 on Python 3.8, 4 on 3.6) is sometimes used to specify the serialization format instead pickle.DEFAULT_PROTOCOL (4 on Python 3.8). This might cause such interoperability issues.

I do note that in the NetBox source itself, pickle.HIGHEST_PROTOCOL (5 on Python 3.8, 4 on 3.6) is sometimes used to specify the serialization format instead of pickle.DEFAULT_PROTOCOL (4 on Python 3.8). This might cause such interoperability issues.

Sorry, correction: These mentions of pickle.HIGHEST_PROTOCOL aren't in NetBox itself, but rather in some libraries: django, cacheops, and rq.  I'll try to find out which of those (if any) might explain the test failures.

Yeah. For the record, tests for all distributions work fine on the default branch (there's a regular cron for it to check for breakages and the last build ran successfully 5 days ago). It's only when this definition is added that these pickle errors start occurring - which doesn't make sense to me because they should all be isolated from each other via the LXC containers.

Resolved via aforementioned PR.


BaseSettings with aliased fields conflicts at instantiation with field argument if an environment variable with alias name exists

Hello,
first of all, thanks for the awesome work you make with pydantic, this is fantastic library. If needed, I could contribute to push a fix for this bug, but I'll need some hints to find out what to modify since I am not familiar with the codebase.
Checks

[X] I added a descriptive title to this issue
[X] I have searched (google, github) for similar issues and couldn't find anything
[X] I have read and followed the docs and still think this is a bug

Bug
Environment
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
pydantic version: 1.8.2
pydantic compiled: True
   install path: C:\ProgramData\anaconda3\envs\kedro_sas\Lib\site-packages\pydantic
 python version: 3.7.10 (default, Feb 26 2021, 13:06:18) [MSC v.1916 64 bit (AMD64)]
       platform: Windows-10-10.0.18362-SP0
optional deps. installed: ['typing-extensions']

Description and setup
I have created a class which from BaseSettings with some aliased fields which refers to environment variables the settigns can be taken from. A minimal reproducible example is:
from pydantic import BaseSettings, Field
import os

class User(BaseSettings):
    username: str = Field(..., env="OS_USERNAME", alias="OS_USERNAME")
    password: str = Field(..., env="OS_PASSWORD", alias="OS_PASSWORD")

    class Config:
        extra = "forbid"  # extra keys are forbidden in the constructor
        allow_population_by_field_name = True  # you can use both "username" and "OS_USERNAME" (the alias) to populate the model

Bug example
With previous setup and as far as I understand pydantic, I should be able to create a User instance with all of the following ways:

CASE 1 (OK): no variable in env, populate with field

User(username="John", password="secret_password")
# works and returns: User(username="John", password="secret_password")

CASE 2 (OK) : password in env, populate with field

os.environ["OS_PASSWORD"]="secret_password_from_env"
User(username="John")
# works and returns: User(username='John', password='secret_password_from_env')

CASE 3 (OK) : password in env, populate with alias

os.environ["OS_PASSWORD"]="secret_password_from_env"
User(username="John", OS_PASSWORD="secret_password")
# works, provided argument has precedence over environment: User(username='John', password='secret_password')

CASE 4 (KO) : password in env, populate with field

os.environ["OS_PASSWORD"]="secret_password_from_env"
User(username="John", password="secret_password") # we use password (field) instead of OS_PASSWORD (alias) like in environment variable
# FAILS with:
# ValidationError: 1 validation error for User
# password
#   extra fields not permitted (type=value_error.extra)

# EXPECTED result identical to CASE 3:
# User(username='John', password='secret_password')

This looks like a bug, intutively it should behave like CASE 3, e.g. override the environment variable with the provided field. Even worse, this is the exact same code like CASE 1: CASE 1 works if no environment variable is provided, and failed if an environment variable exists which leads to very confusing and hard to debug behaviour.

I think there might be the same issue in BaseModel.
from pydantic import BaseModel
from typing import Optional

def to_camel(string: str) -> str:
    return "".join(part.capitalize() for part in string.split("_"))

class Strict(BaseModel):
    """Don't permit extra attributes in any object."""

    index: int
    col_type: Optional[str]

    class Config:  # NOQA: D106

        extra = "forbid"
        allow_population_by_field_name = True
        alias_generator = to_camel

if __name__ == "__main__":

    # This works okay
    print(Strict(index=1, col_type="float"))
    # index=1 col_type='float'

    print(Strict(index=1, colType="float"))
    # pydantic.error_wrappers.ValidationError: 1 validation error for Strict
    # colType
    #   extra fields not permitted (type=value_error.extra)

@Nicholas-Schaub Sorry if it's too late to be useful, but I think your issue is that your alias_generator = to_camel also capitalizes the first letter, so your code seems to run fine with
-    print(Strict(index=1, colType="float"))
+    print(Strict(index=1, ColType="float"))

The issue is still there for BaseSettings with an env var in 1.10.7. Here is how I reproduced:
import os

from pydantic import BaseSettings, Field

class Settings(BaseSettings):
    my_field = Field("default", env="MY_FIELD", alias="my_alias")
    class Config:
        allow_population_by_field_name = True

Settings(my_alias="custom")  # OK
Settings(my_field="custom")  # OK

os.environ["MY_FIELD"] = "potato"

Settings(my_alias="custom")  # OK
Settings(my_field="custom")
# Traceback (most recent call last):
#   File "<stdin>", line 1, in <module>
#   File "pydantic/env_settings.py", line 39, in pydantic.env_settings.BaseSettings.__init__
#   File "pydantic/main.py", line 341, in pydantic.main.BaseModel.__init__
# pydantic.error_wrappers.ValidationError: 1 validation error for Settings
# my_field
#   extra fields not permitted (type=value_error.extra)

del os.environ["MY_FIELD"]

@JosephMarinier I appreciate the feedback, but the alias generator is not the issue here.
I may have written the typo in the above example, but I have used this snake to camel converter in a variety of applications and it has always worked flawlessly.

I looked back at my code, and I definitely had a typo in the example I provided. This was what is should be:
def to_camel(string: str) -> str:
    """Convert snake_case to camelCase."""
    return "".join(
        part.capitalize() if i > 0 else part for i, part in enumerate(string.split("_"))
    )

I have not tried it out recently, so maybe this problem has been fixed. I have not tested it recently.

@Galileo-Galilei I think it's the correct behavior of pydantic.
In Case 4, User model will be initialized by
{'OS_PASSWORD': 'secret_password_from_env', 'username': 'John', 'password': 'secret_password'}

Also, you need to know that pydantic-settings now is a separate package and is in alpha state. you can install it by pip install pydantic-settings --pre and test it.
Here is your provided example in the issue in new pydantic-settings:
from pydantic import ConfigDict, Field
from pydantic_settings import BaseSettings

class User(BaseSettings):
    username: str = Field(validation_alias="OS_USERNAME")
    password: str = Field(validation_alias="OS_PASSWORD")

    model_config = ConfigDict(
        extra="forbid",  # extra keys are forbidden in the constructor
        populate_by_name=True,  # you can use both "username" and "OS_USERNAME" (the alias) to populate the model
    )


WIP Removing the lock table

Refs #212 (not sure it closes it yet)

Successful PR Checklist:

[ ] Tests

[ ] (not applicable?)

[ ] Documentation

[ ] (not applicable?)

[ ] Had a good time contributing?

@marco44 FYI, this is the code @ewjoachim and I are currently testing.

Closed in favor of #231


X11/Xlib.h: No such file or directory

This is a request to add libx11-dev as part of goreleaser-cross image
You can add Xlib.h to image by adding following dependency
apt install libx11-dev

Please take a look at following PR which addresses this issue
https://github.com/goreleaser/goreleaser-cross-toolchains/pull/2


self is not defined for discrete_diffusion_predict_fn()

In the function def discrete_diffusion_predict_fn(), self.device() is called, however the self is not defined in this function. Code snippet here, self.device() is giving the error:
if predict_x0:
        init_state = SamplingState(x, x, torch.tensor([num_steps], device=self.device))
    else:
        init_state = SamplingState(x, None, torch.tensor([num_steps], device=self.device))

I tried to pass in device as function arg and manipulate the devices of variables here and didn't make it.
Please provide an updated discrete_diffusion_predict_fn() that addresses this device inconsistency if possible.

I have the same issue. Could you solve it?


Phone QR reading doesnt work??????

Describe the bug
App just isnt readin the QR code via phone to connect android 13 app to windows PC
Seems to be a issue since last update. I've also uninstalled & reinstalled
To Reproduce
Just goin to the scan QR code section on android
Expected behavior
Should scan QR code
Maybe have letters/short text like how to add authorization codes to authorize/authy apps?

Works for me


Change detection performance

Set the component to changeDetection: ChangeDetectionStrategy.OnPush to increase performance

I could not understand whats exactly is that feature, maybe we should put it in v1.1.0 milestone else we will never finish v1.0.0. 😆
Also, let's keep an eye on performance and try to keep it fast as is, it's an awesome and killer feature against concurrents. 😉

Good point that's indeed something for 1.1


SPARK-4136. Under dynamic allocation, cancel outstanding executor requests when no longer needed

This takes advantage of the changes made in SPARK-4337 to cancel pending requests to YARN when they are no longer needed.
Each time the timer in ExecutorAllocationManager strikes, we compute maxNumNeededExecutors, the maximum number of executors we could fill with the current load.  This is calculated as the total number of running and pending tasks divided by the number of cores per executor.  If maxNumNeededExecutors is below the total number of running and pending executors, we call requestTotalExecutors(maxNumNeededExecutors) to let the cluster manager know that it should cancel any pending requests above this amount.  If not, maxNumNeededExecutors is just used as a bound in alongside the configured maxExecutors to limit the number of new requests.
The patch modifies the API exposed by ExecutorAllocationClient for requesting additional executors by moving from requestExecutors to requestTotalExecutors.  This makes the communication between the ExecutorAllocationManager and the YarnAllocator easier to reason about and removes some state that needed to be kept in the CoarseGrainedSchedulerBackend.  I think an argument can be made that this makes for a less attractive user-facing API in SparkContext, but I'm having trouble envisioning situations where a user would want to use either of these APIs.
This will likely break some tests, but I wanted to get feedback on the approach before adding tests and polishing.

Test build #25993 has started for   PR 4168 at commit 79763d9.

This patch merges cleanly.

Test build #25993 has finished for   PR 4168 at commit 79763d9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25993/
Test FAILed.

Test build #26168 has started for   PR 4168 at commit 9ba0e01.

This patch merges cleanly.

Test build #26168 has finished for   PR 4168 at commit 9ba0e01.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26168/
Test FAILed.

@sryza looks like the test failures are legit?

@sryza is this still WIP? Are we aiming for this to go into 1.3?

@andrewor14 it's no longer a WIP, and I am aiming for it for 1.3.  I just updated the title - sorry for the confusion.

retest this please

Test build #27073 has started for   PR 4168 at commit 9ba0e01.

This patch does not merge cleanly.

Test build #27077 has started for   PR 4168 at commit 16db9f4.

This patch merges cleanly.

Test build #27073 has finished for   PR 4168 at commit 9ba0e01.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27073/
Test FAILed.

@sryza Is the API change in ExecutorAllocationManager necessary for this change? The new API essentially pushes the responsibility of maintaining the number of executors that the application currently has to the user. If I as a Spark application want to incrementally add executors, then I must additionally keep track of the number of executors we currently have as we used to do in CoarseGrainedSchedulerBackend. I actually don't see a great use case for something like sc.setTotalExecutors because it kinda expects the user to know how many executors they think they should need, and this estimation is often difficult.
The rest of it looks fairly straightforward. My comments mostly have to do with variable naming.

Test build #27077 has finished for   PR 4168 at commit 16db9f4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27077/
Test FAILed.

Thanks for the review @andrewor14.  Updated patch coming soon.
Regarding the public API, what I'm contending is that we don't really have any idea whether or how people would use requestExecutors, so it's not worthwhile to add extra bookkeeping and complexity to support it.  I can't personally envision a realistic situation where I would want to use either requestExecutors or requestTotalExecutors.  Maybe it would be better to just remove the API until someone asks for it?  Unless you've come across uses for it?

Test build #27110 has started for   PR 4168 at commit aa01555.

This patch merges cleanly.

Test build #27110 has finished for   PR 4168 at commit aa01555.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27110/
Test FAILed.

Test build #27111 has started for   PR 4168 at commit b78806e.

This patch merges cleanly.

Hey @sryza we definitely need to keep the API because applications building on top of Spark may want to implement their own heuristics (e.g. Spark streaming may want to scale up and down based on the amount of receiver traffic, but not so much on whether there are tasks waiting to be scheduled).
By the way I had a chat with @pwendell about this offline. The other option is to just expose both if that makes implementing this patch easier. Even though it's only developer API there are probably already people experimenting with it, and we should make an effort to not break their code.

Test build #27111 has finished for   PR 4168 at commit b78806e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27111/
Test PASSed.

Test build #27129 has started for   PR 4168 at commit 985ffe7.

This patch merges cleanly.

@andrewor14 updated patch adds back requestExecutors and incorporates your other comments.
I also made some small changes to the way we update numExecutorsPending - it now gets rederived from the desired total executors and the number of running executors each time we change the desired total.  The result should be the same, but we make it clear that everything flows from the new total and avoid the possibility of bugs that accumulate junk in numExecutorsPending.

Test build #27129 has finished for   PR 4168 at commit 985ffe7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27129/
Test PASSed.

Test build #27138 has started for   PR 4168 at commit a19e6d2.

This patch merges cleanly.

Test build #27138 has finished for   PR 4168 at commit a19e6d2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27138/
Test PASSed.

@sryza I may be missing something but I don't understand why numPendingExecutors should be rederived from the user calling requestTotalExecutors every time. What exactly was the issue with decrementing it as we did before? Also I believe the current code is incorrect because the user (or us internally) may call either requestExecutor or requestTotalExecutors, and now we only reset it for the latter. If we were to do this we should do it in doRequestTotalExecutors instead.

@andrewor14 when I mentioned rederiving numPendingExecutors I was actually talking about the way we calculate the version of it that lives in ExecutorAllocationManager.  Sorry for being unclear here.  Taking out the code that decrements it in CoarseGrainedSchedulerBackend was just an accidental omission on my part when I added all that code back in.  I'll put this code back.
I don't have much opinion on where / how in the request executors methods in CoarseGrainedSchedulerBackend, numExecutorsPending should be updated.  Can't tell if you do either, but happy to change it if you do.

Test build #27168 has started for   PR 4168 at commit f80b7ec.

This patch merges cleanly.

Test build #27170 has started for   PR 4168 at commit 37ce77d.

This patch merges cleanly.

Test build #27170 has finished for   PR 4168 at commit 37ce77d.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27170/
Test FAILed.

Hey @sryza thanks for reiterating quickly on the reviews. I left 1 question but other than that this looks pretty close.

Test build #27168 has finished for   PR 4168 at commit f80b7ec.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class GetField(child: Expression, field: StructField, ordinal: Int) extends UnaryExpression

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27168/
Test PASSed.

(I only looked at the public API's, but those look fine to me now - there are none!)

Hey @sryza thanks a lot for fixing this. I will merge this into master and 1.3 after fixing the last batch of comments that I pointed out when I merge this.

Test build #27220 has started for   PR 4168 at commit 3cca880.

This patch merges cleanly.

Test build #27220 has finished for   PR 4168 at commit 3cca880.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27220/
Test FAILed.

@sryza looks like I narrowly missed your last commit. I have copied the changes there to this HOTFIX commit: b640c841fca92bb0bca77267db2965ff8f79586f


Error when we using order by and concat columns

There is an error when we using DB::raw('CONCAT(fname," ",lname) AS fullname')
and order by
the query error:
order by lname) AS fullname asc
Please fix it

It's working as per my tests.
$users = User::select(['id', 'email', 'created_at', 'updated_at'])
            ->addSelect(DB::raw('CONCAT(name," ",email) AS name'));

return Datatables::of($users)->make(true);


Store cilium chart for registry mirror in isovalent repository

Currently import-images stores the cilium chart under the registry of <registry-mirror>/cilium-chart, while the cilium image is stored under <registry-mirror>/isovalent/cilium. We should reuse the same isovalent repository instead of have the user have to create a separate repository called cilium-chart to decrease the number of repositories that have to be created.
We also seem to have different naming for other images, such as <registry-mirror>/l0g8r8j6/kubernetes-sigs/cluster-api/kubeadm-bootstrap-controller, so maybe we can use l0g8r8j6 as the common repository instead, or have a command that will create the necessary repositories for the user instead of creating them manually through these steps: https://anywhere.eks.amazonaws.com/docs/reference/clusterspec/registrymirror/#registry-configurations

We should reuse the same isovalent repository instead of have the user have to create a separate repository called cilium-chart

👍

so maybe we can use l0g8r8j6 as the common repository instead

that registry only gets used for dev, but a command creating necessary repos would be good

Resolving this issue in favor of #1783


GameObjects don't have x, y coordenates in typescript

Version

Phaser Version: 3.55.2
Operating system: Alpine / NodeJS
Browser: Chrome

Description
var ShiftPosition = function (items, x, y, direction, output)
doesn't have a strict typedef as to what the objects should be -- so, when it is used by Phaser.GameObjects.Group it works just fine. So far so good, right?
Example Test Code
Right. Except when you try to iterate the group the following way:
const children = this.bodyGroup.getChildren();
for(var i=0;i < children.length;i++) {
        var bodyFragment:any = children[children.length-1];
        console.log( new Phaser.Geom.Point(bodyFragment.x, bodyFragment.y); )
}

Additional Information
It wont behave nicely, unless bodyFragment is explicitly defined as an any, it wont explicitly inherit the Phaser.Physics.Matter.Components.Transform properties which are necessary in order to work. I don't know if there is a workaround for this at the moment, but it should be noted I am using the nodejs distribution for a vuejs project using typescript.

getChildren has a return type of @return {Phaser.GameObjects.GameObject[]} which is correct, and has x and y coords as you'd expect.
It cannot know anything more than this about what children are in the Group as they can be a mixture of all kinds of types, so it's up to you to cast them as you extract them based on your own rules, as only you know what types you've added to the Group.

https://github.com/photonstorm/phaser/blob/5c8ecbcf999e6f328d21884e877c9e5935d2d350/src/gameobjects/GameObject.js
Please confirm, they don't seem to have those properties.
A sprite however, does inherit the Phaser.GameObjects.Components.Transform properties for x, y, and other coordinates.


Bug: Yaml Block scalar content deleted after sort

Block Scalar are deleted after sort.
E.g.
---
name: John
husband: Tim
biography: |
  A very nice chap. A very nice chap. A very nice chap. A very nice chap. A very nice chap. A very nice chap. A very nice chap. A very nice chap.
---

become, after sort,
---
biography: |
husband: Tim
name: John
---

The content of the "biography" key has been deleted.
Device

[x] Desktop
[ ] Mobile (unknown)

Thanks for reporting this. This makes sense as something that has not been accounted for. I will need to look at the YAML block scalar and see what its syntax looks like to add it to how YAML values are pulled.

I am not finding a good definition for what getting a key looks like. It will take some time for me to determine what is going on here and how to best address it.


where can i find the folder of file attachment in dataverse, i create a power pages form with file attachment, i want to create a flow power automate to sent that file attachement to my mail when someone submit the form.

@mohamedafimto - We need an article link for reference. Please add the link to the article where you would expect to find this information.

No response from requestor to provide an article link. Closing issue.


Contradictory MSRV

Hi, I read in the main README.md:

This crate currently has an MSRV of Rust 1.63. Increasing the MSRV is considered a breaking change and thus requires a major version bump.

And I started getting this recently (when home decided to bump their MSRV):
$ cargo build
error: package `home v0.5.9` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.68.2
Either upgrade to rustc 1.70.0 or newer, or use
cargo update -p<EMAIL_ADDRESS>--precise ver
where `ver` is the latest version of `home` supporting rustc 1.68.2

I already saw a couple of MSRV debates in some other repositories. I don't have an opinion yet on the matter. However, README.md is now wrong de facto.
Now on opinions, at least I think 1.70.0 as MSRV for a crate such as home is slightly radical but I don't know what motivated this sudden change.
I had to use a < in my Cargo.toml, which apparently has been a huge controversy in bincode a couple of years ago. Anyway, this is not in the scope of which, but which is impacted by it because an external dependency broke the official MSRV.

We can't meaningfully control or guarantee the MSRV set by our dependencies unless we pin all of our dependencies. If the ecosystem as a whole does this, then crate developers will find that people aren't downloading their patch updates. Patch updates are an important part of how the ecosystem responds to critical bugs and security flaws. So it is my opinion that this sort of problem ought to be solved by the end user. If you require a specific version of home, then you should add that version to your own Cargo.toml using one of the alternate syntaxes for version specification. To solve this specific scenario, you should pin version 0.5.5
I'm open to discussion on this, but that is my initial impression of this situation.

To solve this specific scenario, you should pin version 0.5.5

This is exactly what I did. However, as you mentioned, that blocks security updates. I am considering reverting this change for that reason. That means MSRV, at best, indicates it is "possible" to make the crate compile but not necessarily with the default behaviour of Cargo which, in the absence of a lock file, will pick the latest available version of the dependencies.
Two problems remain:

The advertised MSRV (e.g. in your README.md) may look incorrect, the discussion shows that it depends on the point of view.
Ideally the advertised MSRV should be tested by CI. Question is how? The only answer I see, if the dependency is not pinned in Cargo.toml, is to pin the dependency in CI when testing MSRV.

Alternatively, nothing should be done, and MSRV should be considered only as an unverified claim. I am not entirely comfortable with this though.
Side note: implementing the suggestion about CI could help refining README.md in the sense that it does the minimum pinning to make the crate compile with MSRV.

Version 6.0.0 bumped the MSRV to 1.70. The README was updated accordingly, along with a notice that relaxed the portrayal of how strong the MSRV is. MSRV has been tested by CI for quite some time, however this won't catch upstream MSRV changes that were made after the PR was merged. That is how the original issue was able to occur.

I gave cargo's MSRV aware resolver a spin with which 5.0.0 and it seems to be working great. If you want to get in on this ahead of time you can use the command provided in this issue to generate a compatible lock file https://github.com/rust-lang/cargo/issues/13873


ElasticSearchSink with REST api

suro-pull-requests #142 FAILURE
Looks like there's a problem with this pull request

suro-pull-requests #143 SUCCESS
This pull request looks good

suro-pull-requests #144 FAILURE
Looks like there's a problem with this pull request

suro-pull-requests #145 SUCCESS
This pull request looks good

suro-pull-requests #146 FAILURE
Looks like there's a problem with this pull request

suro-pull-requests #147 SUCCESS
This pull request looks good

suro-pull-requests #148 FAILURE
Looks like there's a problem with this pull request

suro-pull-requests #149 SUCCESS
This pull request looks good


Rename package

It'd be better to move the package & artifact from documentfile_compat to simpler  dfc.

Competed via f7df133.


Add support for grouping list by associated model

There is no docs and tests. Also there is place for improvements. But currently I just want to ask if this option is useful. I use it to group my products by stores using same tabs as for scopes. Current usage:
class Product < ApplicationRecord
  belongs_to :store
end

class Store < ApplicationRecord
  has_many :producs
end

model.config Product do
  list do
    group_by { key: :store_id, model: Store }
  end
end

So if it's useful i will add docs/tests and do some refactoring. Suggestions are welcome.
P.S. Froala v2 update included :)

Creating custom action will be better choice to accomplish this, not extending index action.


Update manufacturing.md

A few minor spelling/grammatical fixes

@aidanplunkitt : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; thanks @aidanplunkitt


Update spec.selector in other k8s deployment resources

Description
Follow-up to https://github.com/microsoft/FluidFramework/pull/11330, where we missed updating a few k8s Deployment resources.

@hedasilv I did miss a few others 😄. All Deployments and StatefulSets are now updated. The corresponding Service objects seem to already have all the 3 tags in their selectors so I think that's it for these manifests.


davinci-resolve-studio: Automatically create license dir

Description of changes
Previously, extraPreBwrapCmds did not exist. Now that it does, we can use it. See message in commit fe45cd375a4b70fe761b188b77d81c4aabd85296 for context.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/davinci-resolve-studio-install-issues/37699/14