Provide full url to process_page when there is more than 50 entries.

The previous variable next_page_uri was returning the end point /2010-04-01/Accounts/xxxxxxx/Messages.json and causing HTTPotion to raise a HTTPotion.HTTPError because it wasn't a full url.
There are four tests failing but this is because the doc test for the url_generator don't have an account_sid and are production an empty path: ie. https://api.twilio.com/2010-04-01/Accounts//Resources.json, but expect "https://api.twilio.com/2010-04-01/Accounts/Resources.json"
I'm not sure how to test this because it only shows up contacting Twilio and you have more that 50 resources to stream.
Fixes #38

Thanks! Reviewing this now.

Looks like all the tests are passing on Travis. Are they not passing for you?

This is the output from running the test.
Ξ Work/ex_twilio git:(process_page) ▶ mix test
......

  1) test doc at ExTwilio.UrlGenerator.build_url/3 (6) (ExTwilio.UrlGeneratorTest)
     test/ex_twilio/url_generator_test.exs:22
     Doctest failed
     code: ExTwilio.UrlGenerator.build_url(Resource, nil, iso_country_code: "US", type: "Mobile", page: 20) === "https://api.twilio.com/2010-04-01/Accounts//Resources/US/Mobile.json?Page=20"
     lhs:  "https://api.twilio.com/2010-04-01/Resources/US/Mobile.json?Page=20"
     stacktrace:
       lib/ex_twilio/url_generator.ex:34: ExTwilio.UrlGenerator (module)

......

  2) test doc at ExTwilio.UrlGenerator.build_url/3 (4) (ExTwilio.UrlGeneratorTest)
     test/ex_twilio/url_generator_test.exs:22
     Doctest failed
     code: ExTwilio.UrlGenerator.build_url(Resource, 1) === "https://api.twilio.com/2010-04-01/Accounts//Resources/1.json"
     lhs:  "https://api.twilio.com/2010-04-01/Resources/1.json"
     stacktrace:
       lib/ex_twilio/url_generator.ex:28: ExTwilio.UrlGenerator (module)

.

  3) test doc at ExTwilio.UrlGenerator.build_url/3 (5) (ExTwilio.UrlGeneratorTest)
     test/ex_twilio/url_generator_test.exs:22
     Doctest failed
     code: ExTwilio.UrlGenerator.build_url(Resource, nil, page: 20) === "https://api.twilio.com/2010-04-01/Accounts//Resources.json?Page=20"
     lhs:  "https://api.twilio.com/2010-04-01/Resources.json?Page=20"
     stacktrace:
       lib/ex_twilio/url_generator.ex:31: ExTwilio.UrlGenerator (module)

.

  4) test doc at ExTwilio.UrlGenerator.build_url/3 (1) (ExTwilio.UrlGeneratorTest)
     test/ex_twilio/url_generator_test.exs:22
     Doctest failed
     code: ExTwilio.UrlGenerator.build_url(Resource) === "https://api.twilio.com/2010-04-01/Accounts//Resources.json"
     lhs:  "https://api.twilio.com/2010-04-01/Resources.json"
     stacktrace:
       lib/ex_twilio/url_generator.ex:19: ExTwilio.UrlGenerator (module)

..........................

Finished in 1.3 seconds (0.3s on load, 1.0s on tests)
44 tests, 4 failures

Randomized with seed 540005

I just pulled down the branch and tried it locally, and the tests passed. I think you just hadn't set up your .env file or hadn't sourced it.
See .env.sample for which environment variables you'd need to set.


Add priority stuff to suggestions

https://github.com/saschagehlich/autocomplete-plus/issues/29
As propsed by @pjv, we should add some priority stuff to the suggestions:

matches from the current language syntax file
matches from snippets for the current language
matches from word list from the current file buffer

Here's a PR that might help you out. It doesn't prioritize the symbols ordering as requested above, but it does let you match against the file path in addition to the symbol name, which I needed after adding all of my python dependencies into my tags file.

https://github.com/yongkangchen/atom-ctags/pull/204


Enable accesibility for keyboard shortcuts not working

I cannot enable MonitorControl in System Preferences > Security and Privacy > Accessibility for the keyboard shortcuts to work on Catalina Beta

Can you give us more details? What happens? Does MonitorControl show up there or not?

Hi Joni,
Wen the app starts, it’s asking about this
When I try to click on the box to enable the app in Preferences>Security & …., the click on the box doesn’t work, so it’s not possible to enable the app for the keyboard shortcuts to work.
MonitorControl runs but without shortcuts.
Am I doing something wrong?

El 15 sept 2019, a las 16:49, Joni Van Roost<EMAIL_ADDRESS>escribió:
Can you give us more details? What happens? Does MonitorControl show up there or not?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/the0neyouseek/MonitorControl/issues/123?email_source=notifications&email_token=ANGJX6NG4RNLUMB4VEIKXJLQJZDN3A5CNFSM4IW2TZZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XSISQ#issuecomment-531571786, or mute the thread https://github.com/notifications/unsubscribe-auth/ANGJX6JFGEXAJJ4JO3ES5RLQJZDN3ANCNFSM4IW2TZZQ.

Can you try removing MonitorControl from the list inside Security & Privacy? And after that restart MonitorControl and try to enable it again.
A gif of what's happening would be helpful too :)

Can you try removing MonitorControl from the list inside Security & Privacy? And after that restart MonitorControl and try to enable it again.
A gif of what's happening would be helpful too :)

Ops, this works ... Now I can set the app correctly
I'm not using apple Kb, could I use customized keys?
Many thanks¡¡¡

I'm not using apple Kb, could I use customized keys?

Not as of yet, but it has been requested already, see #118  :)

It also works for me!


WebApi omit prefix

I was wondering if you could help me with the following:
I have successfully setup FluentValidation using an ActionFilter and the FluentValidationModelValidatorProvider
GlobalConfiguration.Configuration.Filters.Add(new ValidationActionFilter());
FluentValidationModelValidatorProvider.Configure(GlobalConfiguration.Configuration);

public override void OnActionExecuting(HttpActionContext actionContext)
{
    if (!actionContext.ModelState.IsValid)
    {
        actionContext.Response = actionContext.Request.CreateErrorResponse(HttpStatusCode.BadRequest, actionContext.ModelState);
    }
}

For the given WebAPI controller action
public TestResponse DoSomething([FromBody]TestParams params)
{
    //etc
}

Could you please tell me if it's possible to omit the "params" prefixes in the response below?
{
    "Message": "The request is invalid.",
    "ModelState": {
        "params.ApplicationName": ["'Application Name' should not be empty."],
        "params.CountryCode": ["'Country Code' should not be empty."]
    }
}

+1 Looking for the same here

Cleanup: Closing this as it hasn't been active in some time. Feel free to re-open if necessary.


[PL-51732]: Doc update for Azure vault purge protection settings

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: Doc update for Azure vault purge protection settings
Jira/GitHub Issue numbers (if any): PL-51732
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d76f467a0869bb436280a2--harness-developer.netlify.app


[SPARK-45271][SQL] Merge _LEGACY_ERROR_TEMP_1113 into TABLE_OPERATION & delete some unused method in QueryCompilationErrors

What changes were proposed in this pull request?
The pr aims to

merge _LEGACY_ERROR_TEMP_1113 into UNSUPPORTED_FEATURE.TABLE_OPERATION
delete some unused method in QueryCompilationErrors
refactoring some methods to reduce call hierarchy

Why are the changes needed?
The changes improve the error framework.
Does this PR introduce any user-facing change?
No.
How was this patch tested?

Pass GA
Manually test

Was this patch authored or co-authored using generative AI tooling?
No.

cc @MaxGekk @cloud-fan

thanks, merging to master!


Use drf-generators on an existing project?

Hello,  Pls have a look at the Turkle project at https://github.com/hltcoe/turkle/issues/32.  We're trying to add an api to it, but concerned that the generators will blow away existing files or otherwise radically change the underlying code design.  Your input would be very much appreciated.  Thanks in advance.

If the files already exist (urls, views, etc.) they would overwrite existing code. It will warn you before overwriting. You could always run it and then merge back your existing stuff.


/highlight to change color/size/shape of an enemy or teammember until reset by the user

/highlight to change color/size/shape of an enemy or teammember until reset by the user

/marktarget?

I know that /marktarget is there because @backtwobaysix had it added a few versions back.

I didn't find any customization options in the current version

we can't really prioritize that to the next release and will close the issue here - please open a new one if cusomization options are something you want


is it updated to have a capsolver?

No not yet, I will work on it

No description provided.

No not yet, I will work on it

also spotify will ban ( after an hour) the accounts genertated if they dont verify the email thats sent

also spotify will ban ( after an hour) the accounts genertated if they dont verify the email thats sent

Thank you for the information, I will work on the system ☺


feat: add a POC of a websocket transport implementation

This PR adds a minimum WebSocket transport implementation in rust. It uses tokio-tungstenite to work with websockets on top of tokio. The architecture is based on the ockam_transport_tcp subcrate, dragging the same FIXME's and TODO's.
You can play with it running the provided example, which is based on the tcp's network_echo_client. In the gif below, the buffer size is set to 10 so we can see how the payload is split and sent in different messages.
To be done

Change the DOMAIN_CODE on error.rs (I didn't know how to choose the appropriate number)
Currently, it processes all incoming messages in the same way. It would be nice to add some logic to handle specific websocket messages (ping, pong, close)

Related issues
https://github.com/ockam-network/ockam/issues/1130

This is an awesome contribution @adrianbenavides ! Looking forward to iterating on this and getting it merged.

I've updated the dependencies and replaced the ockam dependencies by ockam_node and ockam_core following the latest changes done in the other subcrates. But the todo's described in the PR description still remain the same.

Thanks for your patience @adrianbenavides, we just got this merged!

wow, awesome, thank you guys! I'll try to open a new MR iterating this and addressing the TODO's as soon as I can.


bug with display of dipl. eds

at the moment, we have a bug with the display of dipl. eds, that is so evident that I don't need to add a screenshot.

Yes, the critical edition and diplomatic edition are linked, so each time I made updated on one, i have to stabilize the other

sorry for the nuisance!


dispatcher,env: must honor heading ARG before FROM

Correctly process any ARG if declared before assigning value to any ENV. This is important for use cases where ARG is configured and passed from the user.
Use case.
ARG CONT_IMG_VER
FROM ubuntu
ENV CONT_IMG_VER=${CONT_IMG_VER:-v1.0.0}
RUN echo $CONT_IMG_VER

buildah build --build-arg CONT_IMG_VER=xyz -t test .

Closes: https://github.com/containers/buildah/issues/4547

@nalind @rhatdan @TomSweeneyRedHat PTAL. @nalind I think travis timeout is unrelated to this PR.

https://app.travis-ci.com/github/openshift/imagebuilder/jobs/594889544#L654 suggests that the updated test case doesn't produce the same result between imagebuilder and docker build.

Also, it might be worth seeing if bumping the timeout passed to travis_wait on line 19 of .travis.yml will avoid the timeout - the "external" conformance cases are some of the most time-consuming.

Ah i think buildkit and docker does not support this ( I need to confirm this so holding till that )


Open Telemetry JavaScript SDK RoadMap Plan & Support Details queries

Hi All, Please find the below queries we have

We see that Javascript SDK is still in Development & Road Map Phase. So, we would like to know the road map plan for Metrics, Logs, and Traces for the Stable Version.
Our Code is in TypeScript. Is it possible to use JavaScript Open Telemetry SDK for integration to capture Metrics, Logs, and Traces
What is the support provided for JavaScript Open Telemetry SDK for Production Environment in case of any issues

The current JavaScript implementation status can be found here: https://github.com/open-telemetry/opentelemetry-js#feature-status. The milestones of JavaScript ongoing implementation are tracked at https://github.com/open-telemetry/opentelemetry-js/milestones.
We are shipping typing definitions with our npm publish. You should be able to use the published packages with either TypeScript projects or JavaScript projects.
Issues related to the OpenTelemetry JavaScript implementation are tracked in this repository, and questions can be discussed at https://github.com/open-telemetry/opentelemetry-js/discussions. Please feel free to file an issue or start a discussion here.


Create Shell Sort

Thank you for contributing to @AllAlgorithms, your pr got merged! ✨ Make sure that you ⭐ the project 🤓, and continue helping us!


Missing TailscaleKey Resource

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
The terraform provider includes a tailnet_key resource since Version 0.6.0. From the provider docs:

The tailnet_key resource allows you to generate pre-authentication keys for your tailnet. See the Tailscale auth keys documentation for more information

This is useful and seems like a common use case. There does not seem to be a corresponding resource in the Pulumi package. Is that a deliberate decision or has it just not been implemented yet?
Affected area/feature
Tailscale Resource Provider

Never mind. @stack72 appears to be working on it right now. Thanks for implementing this!


chore: fixed tests to run using update structure

Part of Fall 2023 Cleanup
Changes

Updated base class of all instrumented unit tests to BaseAndroidTest
Updated base class of all local unit tests to BaseUnitTest
Fixed tests that were failing after the changes

test_backgroundQueueExecuteLotsOfTasks_givenFailAllTasks_expectThrowNoError
test_backgroundQueueExecuteLotsOfTasks_givenSuccessAllTasks_expectThrowNoError
initializeSdk_expectRunCleanup

Closing this PR due to change in our current priorities. We will revisit and reevaluate it once our ongoing projects are finalized.


Consider separate PostStatus, RecordsStatus, and ImagesStatus fields on Posts

Currently the RecordsStatus records whether the post is in draft, published, publishing, or unpublishing, and also whether records are loading. And the ImagesStatus records whether images are loading. But this is a bit confusing, because when RecordsStatus is Draft and ImagesStatus is Loading, we really mean that the Post is in Draft status, the records may or may not have been loaded yet, and images are loading. Also, ImagesStatus is Draft whether or not images have been loaded. Finally, if the record load or images load has an error, we have no way to tell the user that all did not go well. As far as the user can tell, the records/images loaded successfully because the corresponding status is in Draft again.
It seems like it would be clearer to have the following fields:

PostStatus: Draft, Published, Publishing, Unpublishing
RecordsStatus: empty string (initial state), Loading, Error // if the load is successful, Status is set to empty
ImagesStatus: empty string (initial state), Loading, Error // if the load is successful, Status is set to empty
RecordsError: contains the error message if RecordsStatus is Error (or the error message could be put into the RecordsStatus field)
ImagesError: contains the error message if ImagesStatus is Error (or the error message could be put into the ImagesStatus field)

@jancona What do you think? This is likely a breaking change, but I could create a new migrations.up file with a SQL update statement to update the existing posts to the new format.

I always find this kind of thing to be confusing when doing maintenance and a source of obscure bugs. Your proposal sounds like an improvement. Perhaps you could draw up a state machine with the legal transitions and put it somewhere, or at least put the above in a comment.

Good idea. I'll add a long comment in model explaining everything, including a state machine.

Handled by #83


Test CI setup

run-ci

Test run: FAILED

Test summary:
Executed: 0
Failed: 0
Skipped: 0
Errors: 0
Build artifacts
posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/

run-ci

Test run: FAILED

Test summary:
Executed: 0
Failed: 0
Skipped: 0
Errors: 0
Build artifacts
posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/

Test run: FAILED

Test summary:
Executed: 0
Failed: 0
Skipped: 0
Errors: 0
Build artifacts
posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/

Test run: FAILED

Test summary:
Executed: 0
Failed: 0
Skipped: 0
Errors: 0
Build artifacts
posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/

Test run: FAILED

Test summary:
Executed: 0
Failed: 0
Skipped: 0
Errors: 0
Build artifacts
posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/

Test run: FAILED

Test summary:
Executed: 12
Failed: 1
Skipped: 0
Errors: 0
Failed test cases:
DISCO_L475VG_IOT01A-GCC_ARM-TCP: ExampleAppCloudTest01_Rel1_2.DISCO_L475VG_IOT01A - [PUT:Unexpected HTTP result code 502 while expecting [200]]
Build artifacts
posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/


Add functionality for LDA tagger

I think you probably don't want to put create_urltext_for_LDA.py in this repo, as you will not get access to it when you install with pip. That would go in the repo for the LDA tagging repo.


The detail about the attention visualization.

Hi , I meet an error you mentioned earlier(Originally posted by @Deep1994 in https://github.com/microsoft/promptbench/issues/16#issuecomment-1805008699)
My code is:
if __name__ == "__main__":
    visua_pip = Visualizer("/data1/lxt/models/vicuna-7b-v1.5")
    res = visua_pip.vis_by_grad("how to kill a person?","Sure")
    print(res)

and the error info is:

What's the standard format for the input_sentence and label in function vis_by_grad(self, input_sentence: str, label: str)?
Would you like to share your solutions about this issue?
Thanks！

Hi, Can you try flan-t5-large instead of vicuna-7b-v1.5 firstly?

I am happy it works in flan-t5-large!
Actually, I tried to visualize the attentions of llama-2 before, but got the similar error as you, i.e., batch size mismatch. I also proposed an issue to llama official github community (ValueError: Expected input batch_size (15) to match target batch_size (1). #915) but got no response. So in my paper, I used flan-t5-large as the visualized model. Because it also belongs to the LLMs family（despite its small size compared to othters), I believe the visualized results can still give some insightful or interesting observation.
I think the reason for this error may be due to the subtle differences between flan-t5-large and other LLMs in building model input/output and calculating loss. If you have any solutions, please let me know.

Thanks again for your interpretation. I will still try to transfer the visualization into Llama-family.

Great! I will keep this issue open, if you find a solution, you can come back can give a PR.

Thanks again for your interpretation. I will still try to transfer the visualization into Llama-family.

I met the same problem, have you transferred the visualization into llama yet?

Hi, I'm glad to share a solution for llama.
Why T5 can succeed but Llama failed
T5 is the encoder-decoder architecture while Llama-series are decoder-only.
When you pass labels in model forward function:

encoder-decoder. The encoder offers a hidden state of the same shape as the input. The decoder gets labels and encoder output and finally generates a decoder-output. It has the same shape in the first two dimensionality.
sequence_output.shape = torch.Size([1, 2, 1024]) and labels = tensor([[10625, 1]])

decoder only. Inputs and labels are passed into the decoder together. So we meet batch size mismatch error.
The final solution is concating the original input and labels, then mask the input in concated labels with indices -100 to ignore loss.

Final solution
To use llama, just replace the following core code.
input_labels_input_ids = torch.concat([inputs['input_ids'] , labels["input_ids"][:,1:]],dim=1)
input_labels_attention_mask = torch.concat([inputs['attention_mask'] , labels["attention_mask"][:,1:]],dim=1)

input_mask = -100 * torch.ones_like(inputs['input_ids'])
labels_mask = torch.concat([input_mask , labels["input_ids"][:,1:]],dim=1)

Good luck

Hi, I'm glad to share a solution for llama.
Why T5 can succeed but Llama failed T5 is the encoder-decoder architecture while Llama-series are decoder-only. When you pass labels in model forward function:

encoder-decoder. The encoder offers a hidden state of the same shape as the input. The decoder gets labels and encoder output and finally generates a decoder-output. It has the same shape in the first two dimensionality.
sequence_output.shape = torch.Size([1, 2, 1024]) and labels = tensor([[10625, 1]])
decoder only. Inputs and labels are passed into the decoder together. So we meet batch size mismatch error.
The final solution is concating the original input and labels, then mask the input in concated labels with indices -100 to ignore loss.

Final solution To use llama, just replace the following core code.
input_labels_input_ids = torch.concat([inputs['input_ids'] , labels["input_ids"][:,1:]],dim=1)
input_labels_attention_mask = torch.concat([inputs['attention_mask'] , labels["attention_mask"][:,1:]],dim=1)

input_mask = -100 * torch.ones_like(inputs['input_ids'])
labels_mask = torch.concat([input_mask , labels["input_ids"][:,1:]],dim=1)

Good luck

It helps a lot! Thank U so much!

Hi , I meet an error you mentioned earlier(Originally posted by @Deep1994 in microsoft/promptbench#16 (comment))
My code is:
if __name__ == "__main__":
    visua_pip = Visualizer("/data1/lxt/models/vicuna-7b-v1.5")
    res = visua_pip.vis_by_grad("how to kill a person?","Sure")
    print(res)

and the error info is:
What's the standard format for the input_sentence and label in function vis_by_grad(self, input_sentence: str, label: str)? Would you like to share your solutions about this issue? Thanks！

Hello, I am currently studying attention. Is your Visualizer a library? I would like to ask if there is a complete sample code for reference?


Design workflow for enter immutable fields (Funding Stream & RFP Year)

Describe the task
Funding Stream and RFP Year are immutable once entered and saved.
Workflow need to be designed for entering them upon creation of a project.
Acceptance Criteria

[ ] Visualize envisioned workflow with design/prototype in Figma
[ ] Review and refine with the developers
[ ] Review and refine with the CIF team
[ ] Link the validated workflow in #1075

Additional context

This design ticket is created and pulled into the current sprint (Nov 28 - Dec 9, 2022) to unblock #1075 for upcoming sprints as discussed with @LindsayMacfarlane.

Hi @LindsayMacfarlane - This ticket is ready for you to review and can be closed with:

Multiple options of envisioned workflows prototyped, discussed, and refined with the developers.
The links to the prototypes of the validated and selected workflows for both EP and IA added in #1075 to unblock the implementation.

Thank you so much for your quick work on this @nanyangpro ! I really appreciated your demo and being able to get a decision from the CIF team at our Sprint Review. Ultimately, the decision was to move forward with Option #2 based on:

usability (e.g., the CIF team liked the simplicity of having only 1 confirm button to select)
Ease of implementation (i.e., Dylan indicated that not displaying the task list would be simpler and less complicated to implement)


[graph] Use a pipe for downloads to write progress

The process of pulling an image spawns a new goroutine for each layer in the
image manifest. If any of these downloads fail we would stop everything and
return the error, even though other goroutines would still be running and
writing output through a progress reader which is attached to an http response
writer. Since the request handler had already returned from the first error,
the http server panics when one of these download goroutines makes a write to
the response writer buffer.
This patch prevents this crash in the daemon http server by waiting for all of
the download goroutines to complete, even if one of them fails. Only then does
it return, terminating the request handler.

LGTM

LGTM

Cheery picked into #15091


gcc{10,11,12,13}: reorder .cfi_startproc with label

fixes llvm-18+ builds which require that an asm label precedes the .cfi_startproc pseudo instruction. While the problem is not fixed yet in gcc14 the patch we are applying on 14 provides the fix.
testing: built gcc13, verified patch applies on gcc10,11,12

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@emilazy
Add a :+1: reaction to pull requests you find important.

These are underneath stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isAarch64 && buildPlatform == hostPlatform && hostPlatform == targetPlatform, which seems wrong? They should probably be higher up in the file and non‐conditional.

These are underneath stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isAarch64 && buildPlatform == hostPlatform && hostPlatform == targetPlatform, which seems wrong? They should probably be higher up in the file and non‐conditional.

they can't. they must be applied after the patch fetched just above because the above patch adds a cfi_startproc just below the cfi_startproc in the virgin file.

I see. Doesn’t this mean that cross‐compilers will be broken? IIRC those are weird with old GCCs and aarch64-darwin anyway, but I think there’s at least one combination that works. Does the .cfi_startproc stuff apply to aarch64-linux at all?

SGTM.

rebuilding gcc13 will return to ready to review once complete.

I see. Doesn’t this mean that cross‐compilers will be broken? IIRC those are weird with old GCCs and aarch64-darwin anyway, but I think there’s at least one combination that works. Does the .cfi_startproc stuff apply to aarch64-linux at all?

hmm. I can split the patch in two and make the first part unconditional and the second come after the darwin patches. that should take care of aarch64-linux.

so I did this but need to apply the diff for for gcc14 only to revert it later on darwin as the diff we fetch also applies the patch. the logic to unconditionally apply the patch for gcc14 and up and then just revert for the darwin condition seemed simpler than adding a ton of logic on how to apply the patch.


Need access to ID when inserting log to db

No way of easily retrieving the id after inserting log to db.  It looks like I'd be able to hack something through by overriding DatabaseTarget, but I can't see a way to make it thread safe when accessed by the client component.
Given that the logging is abstracted and may be writing to console, file, db, etc it's understandable that the id isn't returned. That could easily be addressed by returning , for instance, a LogResult that could contain a file name, database id, etc.
As it stands, despite all the great features, we won't be able to use NLog. Our preference is generally to expose minimal error information to our endusers and present them simple messages containing a log id which can then be used by our support team if needed.

So why not generate a simple guid (Not full 128 bit), that you insert into the LogEventInfo.Properties. This guid can be displayed to the user and be written to the database as a string-parameter.

Thanks for the response, much appreciated. Something like the below works along the lines you suggested. But two things:

I'd prefer to be able to use the .Error method rather than constructing the LogEventInfo object, but I suppose I could write wrapper classes to simplify things for our devs.
More importantly, I'd much rather display a simple ID rather than a guid to our users. They're bound to get things wrong when they report a guid to support.

Is there any way the DatabaseTarget class could be overridden to do this - without doing an extra database call to retrieve the id?
public class QuantumDatabaseTarget : DatabaseTarget
{
protected override void Write(LogEventInfo logEvent)
{
logEvent.Properties.Add("LogGuid", Guid.NewGuid());
base.Write(logEvent);
}
}
... calling code
catch (Exception error)
{
//logger.Error(error);
var logInfo = new LogEventInfo() { Level = LogLevel.Error, Exception = error };
logger.Log(logInfo);
var logGuid = (Guid)logInfo.Properties["LogGuid"];
}

Think it would be a good idea to make it possible to override the execute command in databasetarget. Then a custom target can change the call to ExecuteScalar and use the return code.
But depending on the target being synchronous (not using async) and returning ID through LogEvent Properties sounds like a nice hack that should only be in your code. Must admit I cannot see the difference from creating the Guid before logging.
Creating the Guid upfront before logging will allow you to use context (Like UserId) to make Guid that includes CRC check. So one can validate the provided Guid actually comes from that specific UserId
Sent from my Samsung device
-------- Original message --------
From: blubinsky<EMAIL_ADDRESS>Date: 24/04/2018 15:29 (GMT+01:00)
To: NLog/NLog<EMAIL_ADDRESS>Cc: Rolf Kristensen<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [NLog/NLog] Need access to ID when inserting log to db (#2671)
Thanks for the response, much appreciated. Something like the below works along the lines you suggested. But two things:

I'd prefer to be able to use the .Error method rather than constructing the LogEventInfo object, but I suppose I could write wrapper classes to simplify things for our devs.
More importantly, I'd much rather display a simple ID rather than a guid to our users. They're bound to get things wrong when they report a guid to support.

Is there any way the DatabaseTarget class could be overridden to do this - without doing an extra database call to retrieve the id?
public class QuantumDatabaseTarget : DatabaseTarget
{
protected override void Write(LogEventInfo logEvent)
{
logEvent.Properties.Add("LogGuid", Guid.NewGuid());
base.Write(logEvent);
}
}
... calling code
catch (Exception error)
{
//logger.Error(error);
var logInfo = new LogEventInfo() { Level = LogLevel.Error, Exception = error };
logger.Log(logInfo);
var logGuid = (Guid)logInfo.Properties["LogGuid"];
}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/issues/2671#issuecomment-383930580, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK-fnHsdmX_IDuizQehJ9LbcOh1yy8ZMks5tryi-gaJpZM4Tgpu6.

Looks like a good change for the databasetarget. You are welcome to create a pull-request.
Regarding needing to use the database to make a simple Guid. Then I'm sure a good programmer can also make a simple Guid in code without needing to use Guid.NewGuid
Sent from my Samsung device
-------- Original message --------
From: blubinsky<EMAIL_ADDRESS>Date: 24/04/2018 16:20 (GMT+01:00)
To: NLog/NLog<EMAIL_ADDRESS>Cc: Rolf Kristensen<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [NLog/NLog] Need access to ID when inserting log to db (#2671)
Must admit I cannot see the difference from creating the Guid before logging.
The difference is being able to retrieve the actual ID (which is easier for end users to understand/report) , rather than the guid, and being able to do that without making an extra database call (select ID from log where guid = 'xyz') after inserting.
This would work ... source code
protected virtual int ExecuteInsertCommand(SqlCommand command, LogEventInfo logEvent)
{
return command.ExecuteNonQuery();
}
and the override
protected override int ExecuteInsertCommand(SqlCommand command, LogEventInfo logEvent)
{
int id = command.ExecuteScalar();
logEvent.Properties.Add("InsertedLogId",id);
return id;
}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/issues/2671#issuecomment-383949762, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK-fnHjTkqZUVOMG313CDTON6Shjfwz7ks5trzTBgaJpZM4Tgpu6.

Ok, thank you. I don't think I have permissions to create a branch though, or is there an existing one I should use?

You just make a fork and then make a pull-request to this project
Sent from my Samsung device
-------- Original message --------
From: blubinsky<EMAIL_ADDRESS>Date: 24/04/2018 17:14 (GMT+01:00)
To: NLog/NLog<EMAIL_ADDRESS>Cc: Rolf Kristensen<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [NLog/NLog] Need access to ID when inserting log to db (#2671)
Ok, thank you. I don't think I have permissions to create a branch though, or is there an existing one I should use?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/issues/2671#issuecomment-383970097, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK-fnBxVfYwZpHj2geX6CGmvkLE8rUvmks5tr0FHgaJpZM4Tgpu6.

I assume your question has been answered, if not, please let us know!

So why not generate a simple guid (Not full 128 bit), that you insert into the LogEventInfo.Properties before logging. This guid can be displayed to the user and be written to the database as a string-parameter.

Is there any example of this that we can check?
Thanks in advance!

@carlos0202 You can see how to inject properties when logging:
https://github.com/NLog/NLog/wiki/EventProperties-Layout-Renderer
And just include the named-property in the database-parameter-layout:
https://github.com/NLog/NLog/wiki/Database-target


New Scenario

New Scenario in Spanish
https://github.com/EMILIPULIDO/VuelveXNavidad/tree/Scenario
https://github.com/EMILIPULIDO/VuelveXNavidad
Valkyrie Version   Ver 2.1.5
Pure Lovecraftian investigation.
Thanks a lot!!

Please use a scenario image with a equal width and height.

Ok. Image Resized. And Test Menu deleted (!)
If you've any new problem I'm here, please
Thanks

Looks good. @scrubbless might want to check and add it.

I'll sort it for you soon!

Thank you  @scrubbless  and @redwolf2

I'll get it added to the review stats spreadsheet when I get a chance.


[FIX] Security - useing Safeloader

using SafeLoader instead of FullLoader to avoid security risks while loading yaml files
here is a example exploit (poc) :

\
hacktoberfest

@glato what's your thoughts
Thanks

@b1nslashsh I assume this is no longer relevant, thus I would be closing this PR in a couple of days.


Documentation improvements

Clarify documentation for dependency management with CMake
Improve FetchContent example in docs

@jtattermusch

Thanks for the feedback, @jtattermusch . I believe I've addressed your concerns. Please let me know if you'd like to see any more changes before we merge this.

@jtattermusch can we merge this?

CC @chalin  FYI

@

@jtattermusch can we merge this?

Sure. Sorry, this feel through the cracks.


Trouble with fonts in localhost 7936

I am testing some work in a local node server version of KaTeX, from localhost 7936 as described in the Contributing to KaTeX page.  I have a couple of problems:
(1) Several fonts are not available. The console warnings read Failed to load resource: the server responded with a status of 404 (Not Found).
(2) I cannot re-create the stacked sans-serif work from PR #1009. Instead, I get:

@kevinbarabash, When I reported the first problem earlier, you suggested that I run git submodule update --init --recursive. I've done that and gotten no relief.  Also, yesterday I completely deleted my ronkok/KaTeX repository and created a new one from scratch. It seems to me that if I do that, then follow the instructions in the Contributing to KaTeX page, the node server version of KaTeX should then work without any further git submodule commands.
I would appreciate any suggestions.

@ronkok I have a theory: the static/fonts -> ../submodules/katex-fonts/fonts symlink isn't working on Windows.  Can you confirm that you're on Windows?  Can you check what static/fonts looks like?

If that's the case, we can change the katex-fonts submodule to live at fonts.

Yes, I am on Windows.
static/fonts is a file with no extension that contains the text ../submodules/katex-fonts/fonts
One would think that ought to work. It certainly points to a folder that contains all the needed font files.  But sad experience says that it does not work.

On Windows, Git symlink does not work. You have to manually create a symlink by mklink /D static\fonts submodules\katex-fonts\fonts.

@ylemkimon, thank you for the information. A web search also brought up the discussion at: https://stackoverflow.com/questions/5917249/git-symlinks-in-windows#16754068
It all looks quite complex. I like the suggestion from @kevinbarabash.  Something that does not involve a symlink.

Cool.  I'll add a katex-fonts folder at the root level which will contain the katex-fonts repo as a submodule.  I'll need to changes all the places where we reference static/fonts to reference katex-fonts/fonts and we should be okay.

@kevinbarabash, thanks. There's no rush. At least a week will go by before I can spend much time on KaTeX.

@kevinbarabash Sounds like a good plan. The symlink was convenient for not changing old paths, but shouldn't be necessary, so let's avoid them.

Just came across this because I had the same error on Windows. Shouldn't this be stated in the Building from Source part of the docs as well?
Also, on Windows, I'm getting errors with the cp command in the build script. Changed it to xcopy and it worked, although I'm not sure whether this is the best solution or whether it works on other OS. Still I think this should be mentioned in some way in the guide, I think.

Yeah, the "building" docs are limited to KaTeX itself and don't include the fonts submodule.

@leontepe if there are Windows specific workarounds that you've found feel free to submit a PR to add a section with them to that page.


color scheme changing at start

In version 1.3.2,this problem is still exist

Can you tell me the exact steps how to reproduce? Which IDE? plugin version?

plugin version:

IDE: andnroid studio 3.0  and intellij IDEA version 2017.2.6  all exist
step: i only changed Preference->Editor->Colors & Fonts -> Scheme

then i close the idea and start it.
the Scheme has bean changed to Darcula.

i used color scheme is from https://github.com/jkaving/intellij-colors-solarized

the solarized color is beautiful ，you can integration it.😁


Server validations can't be fixed when their message lies in resource files

Description of the bug
We need to tell a specific field that its validation error is now fixed (when the thing that fixed it is input to a different field than the one with the validation error)
As explained here, there is a way to do it, but this method doesn't seem to work when the error message is fetched from text resource files.
All this gives us is a new error with the text FIXEDtext.label

Steps To Reproduce

Implement server validation on a field. Set the message in a text resource file.
Implement code that marks the error as fixed, triggered from a different field using this method
Observe that the error is not fixed

Additional Information
No response

I attempted to follow the above steps, and it worked as expected for me, the error simply disappeared. Is there a specific app i can use to reproduce this error?

Yes, you can check on this one once I push the unfinished code to a branch 🙂
But did you use references to the resource files?

Yes I did use a text resource, i'll check out the app 👍

Takk! Du kan finne koden på branchen exceeds-100-validation 😊

Hmm, in the app, it does not seem to work when not using a text resource either. The app is supposed to send back the message along with a severity (1=error, 4=fixed), but the app always seems to send back severity: 1, which then means that something went wrong when parsing the message. I have not found the cause of the error yet, but it does not appear to be with app-front-end as it does what it is supposed to given the information it receives.

Figured it out 🥳

Add FixedValidationPrefix to appsettings.json like this:

In ValidateSumOwnerships, there is a NullReferenceException caused by rettighetshavere[i].posisjonEierGrunnlag is null and not an empty string if none of these checkboxes are checked:

Which causes the function to fail due to calling rettighetshavere[i].posisjonEierGrunnlag.Contains.

The docs should probably be updated to include the information that appsettings.json may need to be updated for this to work.

It works!!🤩
Thank you so much!!
And yeah, that'd be nice - I for one didn't know I had to make changes to appsettings 😅


Update quickstart-v2-java-webapp.md

Minor edits and changes related to redirect URI

@ramya25 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ramya25 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ramya25 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ramya25 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ramya25 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ramya25 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ramya25 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

I checked the rendering on docs and it looks good.
#sign-off

@navyasric: I'm sorry - only the author of this article, @sangonzal, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#sign-off

@navyasric: I'm sorry - only the author of this article, @sangonzal, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#sign-off

@jborsecnik : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@sangonzal, I think this PR should be moved to the private repo for automatic validation and staging. If you need help with that, let us know. Thanks.

@jborsecnik we need to get this merged in ASAP, as another team is blocked until we do, so if at all possible we'd prefer to just merge here the way it is. It would also be nice to keep the history of the edits and feedback.
If that's not a possibility, then how do we move this to the private repo? Would I need to manually copy and paste the changes into a branch there and then submit a PR?

@jborsecnik As mentioned in above comment, we would need to get this merged today. Can we merge the PR here as is since it has been reviewed in detail here? Is there any way you can help expedite the process?

Another reviewer just moved it over to the private repo. I can review it there shortly.
https://github.com/MicrosoftDocs/azure-docs-pr/pull/93267

since this PR has been replaced by a PR in the private repo https://github.com/MicrosoftDocs/azure-docs-pr/pull/93261, we can close this one: #please-close


Remove non existing property from radar samples #3026

pointHighlightStroke was remove because it does not exist.
Additionally I fixed a typo by changing hoverPointBackgroundColor to pointHoverBackgroundColor

thanks @moberwasserlechner


3 MEMS combined pointcloud

I want to use 4 mems-lidar combined pointcloud for close distance cluster, however I found ground point remover wasn't so ideal.
What went wrong?
Do I have to  assume combined 3 mems into one  sensor?

Hey @ryanyej thanks for your question. Unfortunately, the code has been designed to process the output from a single sensor. As long as your sensor has some structured output, i.e., you can represent your full scan as a depth image, you should be able to use the algorithm. If this is not the case, then you will probably have to look elsewhere or find a method to make your data structured. If you have a number of mems lidars, you might create a single "fake" sensor by projecting the 3D points of the combined point clouds onto a virtual range image or you could perform clustering on a per-sensor basis and combine the segments afterwards.
I'm not sure I can be of any help further though, so I will close this issue, but feel free to reopen it if you think otherwise.


add a context object so we can exchange data between interceptors

I need a feature that we can have an context object in interceptor interface, so we can share data between interceptors, especially between request interceptor and response interceptors(for example, the response interceptor can know the res is from which request)
so the interface will like this
export interface Interceptor<T, D> {
  (data: T, method: string, context: any): D;
}

and the context is initialized as an empty object before go into the interceptor chain.
https://github.com/gund/ng2-http-interceptor/blob/master/src/http/interceptable-http-proxy.service.ts#L29
Is that make sense? If this enhancement is ok, I can make a PR to implement this feature.
Thank you.

Hi, thanks for filing an issue.
This is an interesting feature I hadn't thought about before.
I will appreciate if you can make a PR for it.
Thanks.

Ok, got it, I'll make a PR to implement it:)

Feature landed in v1.4.0


Terminator rework

Terminator keep sending the unexecuted message after 5 minutes, which i think i not a good idea and if say there are 3 unexecuted messages terminator send them separately.

Terminator should send unexecuted message once a day.
Terminator combine 2 to 3 messages or say max 5 but with starting string of these messages and send only 1 message.


bank-account: more info about expected solution + mutex links

Added a little more detail on the expected solution, concurrency, and not
allowing the balance to go below 0 on withdrawals.
Looking at the submitted solutions some users were not discovering Mutexes
on their own. Thought it may be helpful to add links to the godocs/tutorials
concering Mutexes if people have no idea where to start on the solution.

As mentioned in #707, I'd merge this now and we can consider what to move into the README at a later date.


vs code extension not working on macos

vls_report_1645123809.md
vls_report_1645125562.md
vls_report_1645171977.md

[Info  - 1:42:22 PM] VLS Version: 0.0.1., OS: macos 64 [Info  - 1:42:22 PM] VLS executable path: /Users/aditya.kumar/.vls/bin/vls [Info  - 1:42:22 PM] VLS build with V eb45a32 [Info  - 1:42:22 PM] Client / Editor: Visual Studio Code 1.64.2 (PID: 17416) [Info  - 1:42:22 PM] Using V path (VROOT): /Users/aditya.kumar/Documents/practice/vlang/v [Info  - 1:43:00 PM] Connection to server got closed. Server will restart. [Error - 1:43:00 PM] Request textDocument/codeLens failed. Error: Connection got disposed. 	at Object.dispose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:29:4057) 	at Object.dispose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:34:9518) 	at Uf.handleConnectionClosed (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:36:9070) 	at Uf.handleConnectionClosed (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:39:12255) 	at n (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:36:8752) 	at Tu.invoke (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:9583) 	at wr.fire (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:10348) 	at it (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:10845) 	at Tu.invoke (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:9583) 	at wr.fire (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:10348) 	at Mo.fireClose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:523) 	at Socket.<anonymous> (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:1297) 	at Socket.emit (events.js:315:20) 	at Pipe.<anonymous> (net.js:673:12) [Error - 1:43:00 PM] Request textDocument/codeLens failed. Error: Connection got disposed. 	at Object.dispose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:29:4057) 	at Object.dispose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:34:9518) 	at Uf.handleConnectionClosed (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:36:9070) 	at Uf.handleConnectionClosed (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:39:12255) 	at n (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:36:8752) 	at Tu.invoke (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:9583) 	at wr.fire (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:10348) 	at it (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:10845) 	at Tu.invoke (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:9583) 	at wr.fire (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:10348) 	at Mo.fireClose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:523) 	at Socket.<anonymous> (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:1297) 	at Socket.emit (events.js:315:20) 	at Pipe.<anonymous> (net.js:673:12) [Error - 1:43:00 PM] Request textDocument/codeLens failed. Error: Connection got disposed. 	at Object.dispose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:29:4057) 	at Object.dispose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:34:9518) 	at Uf.handleConnectionClosed (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:36:9070) 	at Uf.handleConnectionClosed (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:39:12255) 	at n (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:36:8752) 	at Tu.invoke (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:9583) 	at wr.fire (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:10348) 	at it (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:10845) 	at Tu.invoke (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:9583) 	at wr.fire (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:10348) 	at Mo.fireClose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:523) 	at Socket.<anonymous> (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:1297) 	at Socket.emit (events.js:315:20) 	at Pipe.<anonymous> (net.js:673:12) [Error - 1:43:00 PM] Request textDocument/documentSymbol failed. Error: Connection got disposed. 	at Object.dispose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:29:4057) 	at Object.dispose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:34:9518) 	at Uf.handleConnectionClosed (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:36:9070) 	at Uf.handleConnectionClosed (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:39:12255) 	at n (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:36:8752) 	at Tu.invoke (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:9583) 	at wr.fire (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:10348) 	at it (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:10845) 	at Tu.invoke (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:9583) 	at wr.fire (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:10348) 	at Mo.fireClose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:523) 	at Socket.<anonymous> (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:1297) 	at Socket.emit (events.js:315:20) 	at Pipe.<anonymous> (net.js:673:12) [Error - 1:43:00 PM] Request textDocument/codeLens failed. Error: Connection got disposed. 	at Object.dispose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:29:4057) 	at Object.dispose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:34:9518) 	at Uf.handleConnectionClosed (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:36:9070) 	at Uf.handleConnectionClosed (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:39:12255) 	at n (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:36:8752) 	at Tu.invoke (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:9583) 	at wr.fire (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:10348) 	at it (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:10845) 	at Tu.invoke (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:9583) 	at wr.fire (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:10348) 	at Mo.fireClose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:523) 	at Socket.<anonymous> (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:1297) 	at Socket.emit (events.js:315:20) 	at Pipe.<anonymous> (net.js:673:12) [Error - 1:43:00 PM] Request textDocument/foldingRange failed. Error: Connection got disposed. 	at Object.dispose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:29:4057) 	at Object.dispose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:34:9518) 	at Uf.handleConnectionClosed (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:36:9070) 	at Uf.handleConnectionClosed (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:39:12255) 	at n (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:36:8752) 	at Tu.invoke (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:9583) 	at wr.fire (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:10348) 	at it (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:10845) 	at Tu.invoke (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:9583) 	at wr.fire (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:2:10348) 	at Mo.fireClose (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:523) 	at Socket.<anonymous> (/Users/aditya.kumar/.vscode/extensions/vlanguage.vscode-vlang-0.1.11/out/extension.js:3:1297) 	at Socket.emit (events.js:315:20) 	at Pipe.<anonymous> (net.js:673:12) [Info  - 1:43:00 PM] Connection to server got closed. Server will restart.


[DDW-289] Properly handle Ada redemption screen in case there are no wallets

This PR creates a screen for Ada redemption in case there are no wallets.
Todo:

[x] Create the screen based on this solution.
[x] Provide English texts [@darko-mijic]
[x] Provide Japanese translations [Hiroto]
[x] Provide final design [@a-rukin]

Screenshots:

Review Checklist:
Basics

[ ] PR is updated to the most recent version of target branch (and there are no conflicts)
[ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance tests are passing (npm run test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (npm run dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (npm run package / CI builds)
[ ] There are no flow errors or warnings (npm run flow:test)
[ ] There are no lint errors or warnings (npm run lint)
[ ] Text changes are proofread and approved (Jane Wild)
[ ] There are no missing translations (running npm run manage:translations produces no changes)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (npm run storybook)
[ ] In case of npm dependency changes both package-lock.json and yarn.lock files are updated

Code Quality

[ ] Important parts of the code are properly documented and commented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-rendering
[ ] Any code that only works in Electron is neatly separated from components

Testing

[ ] New feature / change is covered by acceptance tests
[ ] All existing acceptance tests are still up-to-date
[ ] New feature / change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review:

[ ] Merge PR
[ ] Delete source branch
[ ] Move ticket to done on the Youtrack board

@darko-mijic we will need final copy for this page!

@daniloprates can you please remove the dot in the Button text? Thanks!
PS. please also merge in latest develop branch.

@daniloprates Japanese translations injected:

@a-rukin please check if the dark-theme is ok:

@daniloprates - bug confirmed. Something is wrong with the routes logic in your branch. If you have no wallets and you go to redemption page and then to add-wallets page it will show up the loading spinner without any content...

@nikolaglumac dark theme seems to be correct

Let's merge this one as soon as CI is done.


Cannot find source file '../src/ChartEvent.ts'

I am using Angular2 and Webpack from https://github.com/AngularClass/angular2-webpack-starter
I followed your readme instructions but I get:
Cannot find source file '../src/ChartEvent.ts': Error: Cannot resolve 'file' or 'directory' ../src/ChartEvent.ts in /Users/username/Dev/angular2-webpack-starter/node_modules/angular2-highcharts/dist

Just tried to run<EMAIL_ADDRESS>with angular2-webpack-starter and this works fine.
here is my how i changed the about.component.ts component
import {Component} from 'angular2/core';
import { CHART_DIRECTIVES } from 'angular2-highcharts';

/*
 * We're loading this component asynchronously
 * We are using some magic with es6-promise-loader that will wrap the module with a Promise
 * see https://github.com/gdi2290/es6-promise-loader for more info
 */

console.log('`About` component loaded asynchronously');

@Component({
  selector: 'about',
  directives: [CHART_DIRECTIVES],
  styles: [`
    h1 {
      font-family: Arial, Helvetica, sans-serif
    }
  `],
  template: `
  <chart [options]="options"></chart>
  <md-card>
    <h1>
<EMAIL_ADDRESS>    </h1>
  </md-card>

  `
})
export class About {
  options: Object;
  constructor() {
    this.options = {
      title : { text : 'simple chart' },
      series: [{
        data: [29.9, 71.5, 106.4, 129.2],
      }]
    };
  }

  ngOnInit() {
    console.log('hello `About` component');
    // static data that is bundled
    // var mockData = require('assets/mock-data/mock-data.json');
    // console.log('mockData', mockData);
    // if you're working with mock data you can also use http.get('assets/mock-data/mock-data.json')
    // this.asyncDataWithWebpack();
  }
  asyncDataWithWebpack() {
    // you can also async load mock data with 'es6-promise-loader'
    // you would do this if you don't want the mock-data bundled
    // remember that 'es6-promise-loader' is a promise
    // var asyncMockDataPromiseFactory = require('es6-promise!assets/mock-data/mock-data.json');
    // setTimeout(() => {
    //
    //   let asyncDataPromise = asyncMockDataPromiseFactory();
    //   asyncDataPromise.then(json => {
    //     console.log('async mockData', json);
    //   });
    //
    // });
  }
}

Despite i had a lot of Cannot find name 'foo'. errors during bundling.

@CristyTarantino Could you provide more details ?

Hi,
Just wondering if someone has found a way to configure webpack to get rid of all the cannot find source file ... . The chart is showing but lots of warnings!
Thanks

I just started to learn Angular and not an expert yet, but as I understand the problem is that when the plugin is installed via npm install angular2-highcharts --save or using package.json dependencies in the project,  the src folder is missing. But there are some links to src folder in *.map files which cause warnings.
To solve the problem:

I have created the node_modules\angular2-highcharts\src folder
copied all *.ts files from node_modules\angular2-highcharts\dist folder
renamed all of them inside just created src folders in order to remove all ".d" at the end.

I understand that this is temporary solution and there should be some more officiant way to do it.


Explain how to route requests from an apphook back to the CMS

Description
This documentation patch explains how to route requests from an apphook back to the CMS. Currently it states that this is impossible, but actually it can be done with a small modification to get_urls()….
Adding CMS pages below an apphooked page was a request from my team btw.

[x] I have opened this pull request against develop-4
[ ] I have added or modified the tests when changing logic
[x] I have followed the conventional commits guidelines to add meaningful information into the changelog
[x] I have read the contribution guidelines  and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

Nice!


Support by fire should be a line symbol that indicates width, with the arrows as marker symbol layers

Issue originally posted in: c_api/issues/7245#issuecomment-753196
Currently the Support by Fire symbol draws with the angle arrows as two line strokes, and the line that indicates width as a shape marker. The length of the angle arrows is actually not important to the symbol according to the standard, as @joebayles has already pointed out:

The proposed solution to this would be to make the two arrow angle lines shape markers, and make the line that indicates with the line stroke. The symbol would be altered and therefore draw perpendicular to the general direction in which the fire would be moving, which is a little counter-intuitive but closer to how the standard dictates this should be implemented.
I don't think we have a fix currently for implementing the precise angle of the arrows at this time.

for update 1 of runtime quartz, they are treating this as a Known Issue as it currently doesn't make sense to implement the symbol the way the standard specifies. Issue about the standard and this symbol located here: https://github.com/Esri/joint-military-symbology-xml/issues/337

Document if this is supported in 100.2 and ArcGIS Pro 2.1. We need to understand if this is an issue with APP6 - B as well.

APP-6B should probably match what we do with this. The point ordering is not specified in 6B.

In contrast, 2525C does specify the point order:

The Point 1 - Point 2 sequence, to define the length of the line, would make sense.

This issue was moved to Esri/military-symbology#286


weight matrix in IPW calculation can have weights info due to division by zero

weight_matrix = probabilities.rdiv(1.0) statement in this file can return inf weights if some entries in "probabilities" series are zero. Maybe there could be some way to ignore the corresponding inf weights while applying weight_matrix later on.

Thanks for the input.
I'll admit that unless I'm missing something, what you're describing sounds more like a modelling issue than a bug. For reasons I describe below, I think it will be bad design to sweep it under the rug, however, let's first start with two practical workarounds I can think of:
One possible solution to avoid zero-propensities would be to clip your propensities. That can be done with the truncate_eps parameter, for example:
from causallib.estimation import IPW
ipw = IPW(truncate_eps=0.01)

will clip all propensity scores between 0.01 and 0.99, so all your zeros will become 0.01, thus evading a division by zero when inverting the scores into weights.
Alternatively, you can first obtain the weights, manipulate them as you wish, and then provide them to the potential outcomes estimation:
w = ipw.compute_weights(X, a)
# Manipulate `w` as you wish (also the corresponding `X, a, y` if needed)
outcomes = ipw.estimate_population_outcome(X, a, y, w)

Theoretical context
So those were technical data manipulations to work around zero-propensities.
The reason I want users to be aware of that and not solve it under the hood is because in a causal-inference context, zero propensity scores can suggests a violation of the positivity assumption¹. Which, in turn, could potentially invalidate the results one gets from the model.
As for your case, if I may suggest, you might want to try to evaluating your model, and possibly detect where the problem originates from:
from causallib.evaluation import PropensityEvaluator

evaluations = evaluator.evaluate_simple(
    ipw, X, a, y,
    plots=["roc_curve"", "weight_distribution", "covariate_balance_love", "calibration"]
)

¹The positivity assumption is formulated as  Pr[A=a|X]>0 for a=[0, 1]. Intuitively, zero propensity suggests there's a subspace of covariates occupied by the control group alone, and so, without similar data-points from the intervention group in that subspace, it is impossible to extrapolate what would've been the outcomes of these control data points if they had receive the treatment.

I'll be happy to know if that helped you solve your problem, or get any feedback relating to whether this approach makes sense to you.
Thanks again for taking the time to raise this issue.


First start "out of box experience"

When in a board is installed https://github.com/MDSLab/s4t-lighthing-rod the client for s4t-iotronic-standalone, it is necessary to execute the first registration of the board.


build: add script to generate Vuetify API data

Also the answer to #270

thanks @mariobuikhuizen I will be able to build more meaningful docstrings from the docs/package.json I guess!

I was reading the way vuetify is documenting props and slots. V3 is way easier to wire (in fact I didn't find where the text was stored for v2). Do you think it worth the shot searching or should I wait for V3 to be wired in #283  ?

I think we should start a v3.x branch, merge #283 there, then you could base your changes on that. Makes sense to work on the api docs for v3 if that has better possibilities for it and most new users/project will start working with v3 when it's released in the near future.
What do you think @maartenbreddels ?


Print full directory name from lsof

awk splits lines based on spaces, which causes directory names with spaces to end up in other fields. Using a for loop allows us to print from the 9th field onwards instead of just the 9th field.
Fixes #3439.

(Shout out to GitHub's UI for making me file this on the wrong repo. 🙄)


fix unsafe code & add new method

if no self.concurrentQueue.sync { ... }, will crash

thanks @iPhilly , merged


Suggestion/Request

A good feature would be to ad the option (unless the option exist and I missed it) to "lazy load" all tab except one active tab when we switch from one group to another instead of loading all the tabs from the group each time we move from one group to another.
For your reference: https://developers.google.com/web/updates/2015/09/tab-discarding  and chrome.tabs.discard  (Firefox have the same API too)
Thanks for this extension! :octocat:

It is already in place. See Discarded tabs wiki page.
Thank you for using sync tab groups !


Use redirect in view, not in constructor

Supersedes #4433

This PR fixes two warnings:

E_NOTICE
/concrete/vendor/illuminate/container/Container.php:877
Undefined offset: 0
E_NOTICE
/concrete/vendor/illuminate/container/Container.php:877
Trying to get property of non-object

This pull request needs to be rebased and reopened because we did some history rewriting, if you need help with this head into #dev in our slack channel
#4814


[WIP]CI action for Java sdk and hive module

What do these changes do?

As the title suggests.
Related issue number

Fixes #1598 #1599

You would better merge java CI and hive CI into to, as Vineyard Java CI.

/cc @dashanji Any other comments?


Fix slow responses issue by switching to port 7000

See the original discussion in #248 .
Basically using a different port instead of the current 5000  for gunicorn solves the issue.
Merging of this PR should be done in parallel with:  https://github.com/NebraLtd/helium-miner-software/pull/276

Update on this. Moving my Pi to @marvinmarnold's dev-nebra fleet updated it with the image he had running on it (which was also from latest master) and there were not delays there. So we haven't been able to pin-point the cause of this issue. Also this issue isn't appearing on actual miner.
I'll keep monitoring testnet for this as we did just push /version endpiont related code to master so it should be in testnet. If this appears in testnet then we should investigate further. Otherwise if it's not happening on the miners then it's probably not worth the time for investigation.

I don't want to merge this until we have seen some hard evidence for this (e.g. the tests) and/or understand why changing port fixes this issue.

I don't want to merge this until we have seen some hard evidence for this (e.g. the tests) and/or understand why changing port fixes this issue.

I agree.  I'll convert it to draft for the time being and later either close it or make appropriate changes if we see this issue in testnet.

I would suggest closing this, not sure it makes sense.

Quite an old one that's been abandoned and don't think we found this to be an issue in the end

Yes we never experienced it on our production miners.


Feat/node settings in add node flow

Settings at the node package level (enables network, sync)
The package level settings "play nicely" with node level settings - definable in node spec files and as long as the config keys and values are the same across clients. minor changes to support any exceptions
previously we had to select the same network from 2 drop downs

https://github.com/NiceNode/nice-node/assets/3721291/600b9f32-d969-45dd-a406-68f3549f3422

oops


Handle mongo connection refused error

Baleen crashes when Mongo refuses a connection; not sure why that's happening though.

Also note - the mongolog should also capture this exception and fail quietly.


Rework color system

Problem
Current hueless color system based on HSL is not working out well and results in poor contrast and inconsistent perceived lightness. The original plan was to switch to OkLCH when it gains browser support, however it does not look like it is getting wide enough adoption soon while the preset is almost ready to launch. We do not want to be inferior to Tailwind in any aspect so this needs to be reworked.
Solution
Remove / rethink hue and highlight utilities, change semantic color configuration to expect OkLCH values, and compile sRGB hex codes in UnoCSS.
It is unclear at the moment whether hue, lightness and chroma should become completely static or accept modifiers (e.g background-normal-setH(45)-addL(10)) especially since it would be no longer possible to propagate them down the DOM using custom CSS properties.

Color system has been reworked. highlight rule has been removed and scheme-(dark|light) and hue-{number} have been merged (e.g. scheme-dark-80). The color variables are now also generated as needed (previously all colors were generated as a preflight).
This approach preserved hue flexibility, however, hues can now be only specified with utilities and have to be known at compile-time. I recommend using hue-rotate-{proportion} when dynamic hue is really necessary.


Stylesheet

Do all the formatting like font (size) in a stylesheet that can be changed.

This is now done using QSettings that change certain variables in the QApplication stylesheet. The stylsheet itself is generated during runtime.


4.2.1 fails to install by Carthage

The build fails when installed by Carthage with the newest Xcode. I suppose the problem is also indicated in the readme of the project because it says CI build is failing. It's probably the same issue, although I'm not sure. It's worth mentioning that if I compile it by hand, it's working properly.
Environment:

macOS Catalina (10.15.6)
carthage version 0.36.0
Xcode 12.0 (12A7209) (and this version is set by xcode-select command)

The logs from carthage update --platform iOS --no-use-binaries --use-ssh
where Cartfile contains github "kishikawakatsumi/KeychainAccess" == 4.2.1
*** Building scheme "KeychainAccess" in KeychainAccess.xcworkspace
Build Failed
	Task failed with exit code 1:
	/usr/bin/xcrun lipo -create /Users/MYUSERNAME/Library/Caches/org.carthage.CarthageKit/DerivedData/12.0_12A7209/KeychainAccess/v4.2.1/Build/Intermediates.noindex/ArchiveIntermediates/KeychainAccess/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/KeychainAccess.framework/KeychainAccess /Users/MYUSERNAME/Library/Caches/org.carthage.CarthageKit/DerivedData/12.0_12A7209/KeychainAccess/v4.2.1/Build/Products/Release-iphonesimulator/KeychainAccess.framework/KeychainAccess -output /Users/MYUSERNAME/Developer/MYAPPNAME/MYAPPNAME-ios/Carthage/Build/iOS/KeychainAccess.framework/KeychainAccess

This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/k7/2pjm9vn53wlddpr_17n87stc0000gn/T/carthage-xcodebuild.xZGaNq.log

I'm also attaching the logs mentioned at the end of the console output (anonymized).
Logs_annonym.log

Carthage has a problem failing to build on Xcode 12.
Can you try this workaround? https://github.com/Carthage/Carthage/issues/3019#issuecomment-665136323

I decided to migrate from Carthage to SPM after checking out this thread. Thanks for your support, I thought it was KeychainAccess issue while it was Carthage - sorry for troubling you!


Search -> FAQ -> Is there a Datepicker leads to 404

Subject
Search
Description
When searching "Is there a Datepicker in Chakra UI?" you will find an entry in the search but when clicking on the entry you will end on a 404.
https://chakra-ui.com/faq/index#is-there-a-datepicker-in-chakra-ui

I assume we either want to remove the entry or link it correctly if there is a document for this.

Hey @Patrick-Ullrich! Thank for the callout. 😁
I found an issue in the scripts/get-search-meta where the filepaths ending in index.* were being added to the search-meta with index still present. This is because of Windows (at least for me!) in how it returns file strings with backslashes instead of forward slashes, and it was impacting the effectiveness of some of the scripting when contributors update search-meta.json in future pull requests.
i.e. Me when contribute and I use Windows! 🤦♂
The referenced pull request should resolve this issue along with one other page.

That's exactly right @TylerAPfledderer! In the meantime, I've regenerated the search meta and pushed it to fix this issue right away, while your PR will make the fix permanent.


Realtime planar reflections?

Hi,
First of all, thanks for maintaining such a great project. 👍
It is possible to use dynamic planar reflections on the ocean renderer instead of the static skybox? So dynamic/static objects in the scene can get reflected on the water. I think it can increase the realism of the simulation.
Any ideas on how to do this?
Thank you.

Thanks for getting in touch Rbn3D :)
There has been a bit of discussion about this. It's a bit of a long thread but if you're feeling game you could read this: https://github.com/huwb/crest-oceanrender/issues/4
I think the summary looks something like:

Planar reflections is definitely possible, and might be a good path forwards. The Advanced Water in the unity standard assets is a good example of this - it sets up a camera with a clipping plane to render the reflected view of the scene each frame. It seems to be elegantly implemented. It can work well when the water is calm. When the water is very wavey it is more challenging as a varying surface height starts to violate the "planar" assumption! I believe with some fudging it may be possible to get a reasonable result this way, perhaps by setting the reflection plane height to the lowest expected wave height, or something like that. A disadvantage is the cost of rendering the world a second time each frame, but this extra pass is not unheard of in games though, and if perf is an issue one might selectively render LOD'd terrain only at a low res, etc. I have been interested in trying planar reflections in crest but havent got around to it. I'm interested in how much code it requires and how elegantly it fits into existing crest stuff.
Screen space reflections - I believe these are included in the unity post processing stack. But i have no idea what is required to enable them to work, I have not got around to trying them yet. Once again, I'd be interested to hear any experiences here!

Does that make sense?

Yes, I will take a look into Advanced Water from standard assets and see if I can port it to crest...
My simulation is a little wavey, so I don't know if it will really work well, but maybe taking the normal of the waves into account and distorting the RenderTexture accordingly could work, just like normal map does...
Thank you again!

I managed to implement planar reflections by modifying the ocean shader and using a modified WaterAdvanced script!
However, the reflection shows some squares/seams on the water surface (looks like i'm applying the normals wrongly), most noticeable when the boat is stopped and the water mostly calm.
Also, looks like the reflection stutters, even updating the Render texture every frame. Looks like it skips the Render texture some frames. I have no idea why...
I modified the shader this way:
(Added ref to v2f, just like WaterAdvanced)
struct v2f
	{
		float4 vertex : SV_POSITION;
		float4 ref : TEXCOORD0;
		half3 n : TEXCOORD1;
		half4 foam_screenPos : TEXCOORD4;
		half3 lodAlpha_worldXZUndisplaced : TEXCOORD5;
		float3 worldPos : TEXCOORD7;
		#if _DEBUGVISUALISESHAPESAMPLE_ON
		half3 debugtint : TEXCOORD8;
		#endif
		half4 grabPos : TEXCOORD9;

		UNITY_FOG_COORDS( 3 )
	};

	v2f vert( appdata_t v )
	{
           // .....
           o.ref = ComputeNonStereoScreenPos(UnityObjectToClipPos(v.vertex));
           // .....
        }

The reflection is rendered like this:
	half3 frag(v2f i) : SV_Target
	{
           // .....

	  // Reflection
	  half3 refl = reflect(-view, n_pixel);
	  //half3 skyColor = texCUBE(_Skybox, refl);

	  float4 uvRefl = i.ref;
	  uvRefl.xyz += n_pixel;

          half4 skyColor = tex2Dproj(_ReflectionTex, UNITY_PROJ_COORD(uvRefl));
          // .....
         }

I would appreciate any idea that could point me in the right direction.
Thank you.

Nice!
I do have a couple of ideas that come to mind for now:
Where did you insert that line that computes o.ref? I think it needs to be at the end of the vert shader, after the ocean verts have been processed. There is a similar line that packs the screenpos into o.foam_screenPos.yzw:
o.foam_screenPos.yzw = ComputeScreenPos(o.vertex).xyw;
I think your new line belongs in this area near the bottom of the vert shader. In fact, I'd be tempted to actually try using one of the existing values that is being computed - the reflection will look wrong but I'd be interested if you see the square artifacts or the glitching.
Is the glitching happening when the camera is moving around or is it stationary?
If you could attach a image of the result that could be useful as well, i might recognize an issue or it might give me a lead.
Besides that, I could jump in and take a look myself. An option could be to fork Crest and push a new feature branch which i can then pull and look at on my side.

There is a quick screenshot of the scene.
You are right, o.ref it's done at the bottom of the vert shader.
The stuttering, (I'd call it low update rate of reflection or something like that), it's mostly noticeable when the camera or the boat itself moves around. The ocean runs pretty fast on my machine, but the reflection it's not updated the same, looks like it's skipping frames.
I'll try to prepare a pull request, but my project needs some cleanup (I'll push one as soon as I get it tidy and remove some off-topic stuff!)

I've prepared a pull request showcasing this.

I discovered the reason of the stutter:
The renderTexture is updating just fine. The problem is that the position (transform.position) of the ocean changes over frames.
If I set a position constraint that locks the ocean position to some gameobject that don't moves, the reflection renders stops glitching (Altought other issues appears due to the constraint).

Hey there,
I finally had a chance to look at this. It's looking pretty cool! I know it falls over a bit for big waves, but I'm surprised how well it holds up so far. I think theres some interesting experiments to do with varying the reflection plane position based on camera subject to hide the worst of the issues..?
Anyway, I fixed a few of the issues. I split up the changes into commits with descriptions so you can browse them and let me know what you think. The result is close(r), but not jitter free yet. The remaining part is update order which im confident can be fixed.
It looks like I pushed the commits to YOUR fork/repos. I had no idea i could do that..! I hope you don't mind. I think i should have merged in your PR and then pushed to my repos. However this seems like a convenient way to iterate for now - maybe this is a feature of git? My git skills/knowledge are falling a bit short here.
So i'll let the stuff so far settle in my mind and will see if i can come back to this in the next days. Let me know if you have thoughts. Thanks for kicking this off!

Cool! Can't wait to try this out!
I don't mind about the commits being pushed to my fork (it's a feature of github, If someone open a pull request against your repo, the autor and you can share the pr branch). Is a good way to iterate, so no problem.
Hopefully tomorrow I can try this out and post something back.
Thanks again!

Wow, this is working pretty well!
I've followed your suggestion with a minor change, please take a look at the comment:
https://github.com/Rbn3D/crest-oceanrender/blob/planar-reflection/src/unity/Assets/Crest/Shaders/OceanPlanarReflections.shader#L367
Does it make sense?
Looks like all the issues have been fixed, even the clip plane thing!
Only two things we might want to address:

The reflection doesn't "follow" the game camera instantly when it is stopped but rotating quickly.
The directional light specular highlight isn't occluded by reflected objects. (This one is harder to fix as it requires to distinguish between the skybox and the rest of the objects, by using a depth buffer or something like that)

I'm now trying to solve the first one, but still no clue about what causes it.
Many thanks for your help 👍

Sorry i have not managed to get back to this :( its very close to the top of my list!!

It's fine!
Thanks for your help on this. 👍

I just worked on it a bit more. I changed the way the script works - it now should be attached to the camera its reflecting, and it takes the reflection plane from the ocean position. This has simplified the logic and cleaned a few things up.
I think its at a point where its working now - I'm not aware of any issues now except the case when waves deviate from the plane which breaks the reflection which is expected. I've experimented a little bit with offsetting the reflection based on water height to try to combat this issue, i have a couple more things to try here to see if i can address the problem.
Besides that with a bit more cleanup i think it could be in good shape to merge into master which is cool.

Ok that was a fun diversion - after experimenting i think it is possible to hack approximate reflections that work in wavy conditions, but im not confident yet that it will be good enough to use in production.
The idea is to use planar reflection, but warp the world around it to the shape of the ocean. A reflection proxy object is rendered, and is offset by the negated wave height, so that it is clipped at the right height (so if the object is above the plane but the wave is also above the plane, it will still cut the object at the right point). I added a reflection proxy shader which samples the wave heights and offsets the verts accordingly (just for the proxy).
Then a similar fudge is done in the ocean material - when it samples into the reflection texture it offsets a bit to compensate for the water surface not being flat. This part is quite hacky and is just a fudge at the moment, but i think it can be made principled and perhaps quality can be increased.
The result looks like this at the moment:
https://drive.google.com/open?id=1CIOmMmMY_kTGyuNEFPCSLQ-8cdeRVZN8
It requires reflection proxy objects to be created (which have the vertex offset described above), and to make this render I created a new layer for reflection proxies. I'm guessing this will cause issues for people due to layer scarcity and/or objects needing to be in existing layers, but this can be addressed down the line with tags etc i think.
I'm probably going to park this here and get back to getting planar reflections merged into mainline. Let me know if you have thoughts and if you might be interested in using this approximate reflection stuff.

Oh sorry i just read your question - yes i think we can integrate planar reflection into the ocean shader on a switch like the other features. The tradeoff is the ocean shader is quite long, but ill look at breaking out different parts of the ocean shader into separate files which should help with this.

I merged it all in! I tried to merge first from master into the branch but there were a LOT of changes which were tricky to go through - in the end i decided to just merge the branch into master by hand, which means I could not do it through the PR, apologies.
To turn it on, tick the Planar Reflections option on the ocean material, and add a OceanPlanarReflections script to the main camera.
Let me know if you get a chance to try it out and if you have thoughts about the above. Thanks for working with me on this!

On the fake reflections for wavy oceans, i've made and improvement in the commit referenced above (moved to a new branch called feature/wavy-planar-reflections2). Before the reflection only moved up and down which looked wrong when the waves were not flat. Now i've added a horizontal shift to the reflection proxy based on normal so the reflection moves around in a plausible way depending on waves.
Current capture: https://drive.google.com/open?id=1vSqHSpX7IyWxOsisyLFq6ZjQwLmjiQJU
It's still a bit hacked but I could clean it up if its something you think you will use, let me know.

Hi,
Looks nice in the video! As soon as I can, I'll try this!  (Hopefully in a few days)
Thanks for working on this.

I'm back! I'm going to test this later today and post something back!

Finally tested this and it's looking pretty cool. I still have to merge it fully into my project but looks nice in the demo, even when the ocean is not so planar ;)
My only throught is that the reflection distort intensity is no related to the distance of the reflected pixel on the ocean surface, so it doesn't give proper "feeling of depth". Ideally, normal intensity would be multiplied by the distance of the reflected point on the water.
I know this it's probably out of the scope for this project, and requires some research and time. Also it could require render the depth of the scene, which may have a negative impact in performance...
So for me, this issue can be closed. Maybe we can create another issue to try to address that, at some point.
Thanks for your work again.

Yeah its a good point. I messed around with making the normals influence stronger, but the reflected rays can easily go outside the reflection texture which is another problem. Could perhaps be addressed by over rendering / rendering with a wider FOV.
I think tracing the ray properly would basically amount to SSR which I'm interested in but it feels outside the scope of what i could take on myself. Also after doing a quick google now im reminded of the challenges with SSR and transparents. It would have to either render a gbuffer especially for the ocean surface, or do SSR in the ocean shader which could get very expensive.
As you suggest, I think i'll call it a day here and close this issue and leave it for future work, or see if anyone has anything new to add to the mix.


.parent() feature

after selecting a path sometimes need to access to parent form example :
tree.select('palette', 'flower','herbal').set('newkey','newvalue').parent()
or .parent('flower') [one of fathers that is exist on path] to doing another things

Hello @azimot. The .up method actually does that (at least your first example, not the latter with further selection).

Thanks


Update Foundation Content Area Renderer

@jonascarlbaum

Looks like it will do the trick! 👍
@ngocnguyen-epi


Pyro4 docs url is deprecated

Hi, the links to the pyro4 docs are deprecated. Can you please change them to the current location https://pyro4.readthedocs.io/

Thank you, will change soon.


Create top level .gitignore

added here.
will continue to add to for new languages, but mostly want to hide the contents of any .env file added


The changes do not reflect immediately in Henson intent builder

Each time I add new extras in one Activity, I need to remake the project to see the changes. I have already used android apt. Is this a bug?
Thanks!

Henson uses annotation processing, it entirely relies on the compile part
of the Android build process. Nothing can be done beyond that.
Incremental compilation in Android studio should actually work immediately
though.
Maybe a few questions :

which version of Andoid Studio do you use ?
does a simple build of the module solve the issue ? Or do you need to
rebuild all the project ? Do you need to clean ?
are the generated classes created in the build folder and just "not
visible immediately" in Android Studio ? Or the classes are not created
before you trigger a complete rebuild ?

Even with these answers, I guess the only thing we can do about it is to
write a more precise bug report to Google about Android Studio's ability to
deal with code generated by annotation processors but this is most likely
to be completely out of the scope of dart & henson.
2016-06-09 8:08 GMT-07:00 Jay<EMAIL_ADDRESS>
Each time I add new extras in one Activity, I need to remake the project
to see the changes. Is this resolvable?
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/f2prateek/dart/issues/119, or mute the thread
https://github.com/notifications/unsubscribe/ABv33S40jlTP965WohokaSR89sQ6mE8Fks5qKCxzgaJpZM4IyE_w
.

Android Studio 2.2 Preview 3
A simple Make module app solve the issue.
After done a Make module app action, the latest code was generated in build folder.

@jaychang0917 everything seems normal to me: as Henson is based on annotation processing and this is part of compilation, yeah you need to compile your project when you make a change so that henson reflects the change..
Can we close the issue or your wanna add anything else ?

@stephanenicolas I got it, you can close it.

let's go a little bit further on this:
when you type a bad statement in Android Studio (AS), it gets highlighted immediately. This is incremental compilation and it uses javac.
So, as devs, we could hope that the code generated by the annotation processor would also be updated as javac is called.
BUT, the incremental compilation is not a full compilation. Compilation can be divided into 2 phases:

from java source, javac creates an Abstract Syntax Tree (AST)
from the AST javac produces byte code.

The annotation processors are also triggered during phase 2 as their need the AST as an input to work.
But incremental, or on-the-fly compilation, in IDEs only triggers the first part. This is fast, it is only in-memory and is enough to higligh errors fast as you type. But it doesn't get into phase 2 of compilation. So you actually need to build / compile your code so that Henson generates code.


Integrate Unused Microsoft Stubs

I am aware that this repo is "born" from the existing stubs, but it seems like there are some stubs that live in the pylance bundle (I have no idea where on GitHub, though) that we can probably add in?
For example, the entire io folder does not exist in this repo.
Example of Styler, for which the to_html method does not exist in the pylance bundle..
Path on my machine:
~\.vscode\extensions\ms-python.vscode-pylance-2022.6.30\dist\bundled\stubs\pandas\io\formats\style.pyi

Apologies if there is a misunderstanding on my side—also interested in contributing, as I use pandas daily.

I think a lot of these are already in pandas. It might be that these are stripped out for convenience by pylance.

I think a lot of these are already in pandas. It might be that these are stripped out for convenience by pylance.
I'm pretty sure io is fully typed in pandas.

You're right, they are—but until pandas adds the py.typed flag, mypy and pylance are going to have depend on stub files, unless I'm mistaken?

I am aware that this repo is "born" from the existing stubs, but it seems like there are some stubs that live in the pylance bundle (I have no idea where on GitHub, though) that we can probably add in?

A bit of history here.  It used to be that in https://github.com/microsoft/python-type-stubs, the complete distribution of the pandas stubs that were shipped with pylance were included.
At some point in time, only some of them were in that repo that passed the typing tests, but Microsoft would add the "missing" stubs back (but I don't know from where) when packaging pylance.
When we took the Microsoft stubs and made this project, we pulled the ones in that repo, but missed the ones Microsoft was merging in.  I'm planning on fixing that today (7/3) or tomorrow.
Related issue is #55


Remove legacy workflow. Use .github 8.0.0 workflows

Remove legacy workflow no longer in use
Reference: https://app.zenhub.com/workspaces/mighty-ducks---the-outlaws-6193fe815d79fc0011e741b1/issues/energinet-datahub/the-outlaws/428

Workflow is indeed in use, it seems. Closing PR


URL in GitHub project description should point to https://mne.tools

Currently still pointing to http://martinos.org/mne/

Fixed, thanks @hoechenberger