[WIP][K8S][2.4] Test K8s integration test

This is for testing branch-2.4 for Apache Spark 2.4.5 release.

Test build #116411 has started for PR 27154 at commit 36b722d.

Test build #116411 has finished for PR 27154 at commit 36b722d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116411/
Test PASSed.

Retest this please.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/21200/

Test build #116412 has started for PR 27154 at commit 36b722d.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/21200/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21200/
Test PASSed.

Test build #116412 has finished for PR 27154 at commit 36b722d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

The test passed and I close this test PR.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116412/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/21202/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/21202/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21202/
Test PASSed.


Question about sparse_hash::find_impl.

Hi there,
I'm using your tsl::sparse_map with its default settings (growth policy, etc) in the memory cache subsystem of our P2P proxy.
In the last two or three weeks I observed two times that one thread of the proxy was looping in some functionality consuming 100% CPU and when I provoked the process to print stacktrace it was in the
sparse_map::find function both times.
I'm still investigating if the bug is related to the tsl::sparse_map or to some other functionality from the upper levels. However, I was looking at sparse_hash::find_impl and I was wondering if it's possible for this function to loop forever in some edge case. For example, if every checked sparse_ibucket has some value but the keys are not equal to the searched key?
As I said we use the sparse_map with the default growth policy, which I think is power of two and with default search policy, which is linear, as far as I checked.
The count of the entries in the map reaches 262144 (this is the max allowed value) and then usually stays there minus 10-20-50 entries but it doesn't go beyond the set limit.
Regards,
Pavel.

Hello,
Thank you for the report.

For example, if every checked sparse_ibucket has some value but the keys are not equal to the searched key?

It should not be possible as the load_factor() should always be below 1.0 (the maximum max_load_factor() authorized is 0.95). But it could come from the deleted values, a map where all entries are either with a value or marked as deleted.
Do you call erase() on this map? It could be related to this bug. I have to check it when I have a bit more time.

Yes, I do call erase on the map.

Hello,
It could effectively come from a bug in the tsl:sparse_map. Sorry for the caused inconveniences.
I pushed a fix (and a test that reproduced the previous problem), warn me if it ever occurs again.
I'll probably also add this week-end a way to automatically shrink the map when the number of deleted buckets is too high compared to the number of free ones (kind of like min_load_factor()  of google::sparse_hash_map), as currently the find method will end-up to be linear with too much buckets marked as deleted.

Hi,
Thank you for the fast fix. I'm going to pull it and start using it today.
Should I close this issue or you'll close it at some point?
Pavel.

I'll close it. Don't hesitate to reopen it if the problem still occurs.


downloading forms a bad path

In some conditions, the URL passed to _download (in init.py) has the dl=1 GET parameter added which makes the download_target filename to be erroneously set as containing also that (eg: it ends up like "..... .cache\whisper\large-v2_ori.pth?dl=1")
A fix could be to:
from urllib.parse import urlparse
parsed_url = urlparse(url)
And then use parsed_url.path further.. such as instead of:
download_target = os.path.join(root, os.path.basename(url))
use
download_target = os.path.join(root, os.path.basename(parsed_url.path))

hi there,
Thanks for reporting this and proposing a solution.

In some conditions, the URL passed to _download (in init.py) has the dl=1 GET parameter added which makes the download_target filename to be erroneously set as containing also that (eg: it ends up like "..... .cache\whisper\large-v2_ori.pth?dl=1")

This is as expected, dl=1 for dropbox means direct download without going to its page. The download file will have dl=1 in its name. But I am wondering if that would cause a practical problem, e.g., the downloaded file is cannot found by the script?
https://github.com/YuanGongND/whisper-at/blob/58fa38b1a998445c66db9f1bf2541d6665c7239c/package/whisper-at/whisper_at/__init__.py#L190
I set a strict check when loading the model, so it should report an error if the model file isn't found.
-Yuan

It triggers an error indeed, not at the model load phase but when trying to validate the download_target path. On Windows, so that's why the ? character creates a problem.
I fixed it locally by the method described above, otherwise it wouldn't work for me. I didn't create a pull request, but could do that if it helps.

oh, I see. Thanks! I only tested on Ubuntu/mac.
Will fix the problem follow your proposal, and go through a quick test.
-Yuan

Fixed in whisper-at==0.4.0. Thanks again for reporting this.

Thank you for all the great work you did here. Who knows, maybe we can contribute or extend this sometime.


Reword creation and deletion of subnet options

What
Instead of using create and delete, use "override global" and "reset to global"
so its clear to the user what is happening.
Why
Our language about creating and deleting options for a subnet seem odd from a UX perspective
Notes
I realize this language has the potential to be controversial so i pulled it into its own PR. I think its worth a discussion as to wether we think this wording is better.

I understand the intent with the reword, but I think what it's missing is a link to / display of the global options when we talk about 'overriding' or 'resetting to'.
For example, on the show subnet page, I think it would be useful to show the global options when the subnet does not have its own options. Then it makes more sense in my mind having a button saying "Override global".
In the same vein, on the delete option page where you "Reset to global", I think we should display the global option that the subnet will revert to after they press the button. That would help the user understand what is happening when they click "Reset options"

Im gonna close this as we need to discuss further. We can reopen if we need to later.


"Dependencies could not be installed" error when installing the VS Live Share w/multiple windows open

Product and Version [VS/VSCode]: VS Code
OS Version [macOS/Windows]: Any (found on MacOS)
Live Share Extension Version:  0.2.163
Target Platform or Language [e.g. Node.js]:
Steps to Reproduce / Scenario:

Start Visual Studio Code and open multiple windows
Install the VS Live Share Extension
Reload

Expected: VS Live Share starts and share / sign in buttons available
Actual: Live Share does not initialize or a message appears stating that dependencies could not be installed. (e.g. Failed at stage: installPackages - Dependency download failed. Error: EEXIST: file already exist)
Workaround: Uninstall, close all windows, restart VS Code and install with only one window open and reload.

This issue has resurfaced. I'm on Mac High Sierra and tried the following:

reinstalling vs code
reinstall vs code insiders
deleteing every file on my system associate with vs code and vs code live share (such as the .vscode folder under ~/, and then installing a fresh copy of VS Code
I tried changing networks, including:

work network
work guest network
my home network
my phone's tether

No matter what, I always get the "dependencies could not be installed" message

@olivercodes Apologies for the delayed response but you'd replied to a closed issue so we missed it.
Is the issue you are running into when you have multiple windows open or in general? This particular issue is about multiple VS Code windows being open.  Are you behind a proxy by chance?

@chuxel Apologies, I should have opened a new issue. And yup, it was a proxy problem. Forgot I had changed my npm proxy settings when working with a private npm instance. Removed those settings and live share installed without issue.

@olivercodes Awesome!  Glad to hear it wasn't a regression!

@Chuxel  Apologies I should have just opened a new one. Figured it out a couple of days ago, and yes it was proxy related, I had been messing with my npm config proxies for some work stuff on our private npm, and forgot to unset them. Thanks for the reply :)

I have this issue but I'm behind a proxy.  What can I do?

Same here, Proxy, Microsoft Windows Server 2012 R2. Closing all windows does not help.

Same here, too. On OS X.

I'm having the same issue on macOS as well, but without proxies.

Have you all been hitting this issue due to having multiple windows open? Is the error message you're seeing Failed at stage: installPackages - Dependency download failed. Error: EEXIST: file already exist? Or are you simply seeing the first half -  Failed at stage: installPackages - Dependency download failed.?

I think I had multiple windows open.  Certainly multiple tabs,  I gave up  after a while.


"Fixes #128"

added contributors in readme.md file.
I have added contributors just before Contributing.
Fixes #128

hey @NandaniThakur, we actually want a list of images of those contributors . something like this :

please make changes accordingly : )

I have done the changes, please check it.


[PE-D][Tester B] Valid NRIC declared as Invalid

According to the formatting for Add, M1234567D should be a valid NRIC. However, the app does not allow such an NRIC to be added.
Upon additional testing, more valid NRIC are not allowed too.
Commands used include:
add n/bob ic/T0234567D
add n/bob ic/M1234567J
add n/bob ic/S2234567D
Only add n/bob ic/S1234567D was managed to be added.

Labels: type.FunctionalityBug severity.High
original: ReganChoy/ped#7

Documentation issue.
NRIC validation works as intended but users might think any number is valid.
Fix:
To give clearer instructions that it must be an actual NRIC.

Resolved in #174


[zh] Sync setup pages for container-runtimes.md

Sync with english version in 'Update container-runtimes.md (#27518)'

Signed-off-by: ydFu<EMAIL_ADDRESS>

Thanks.
/lgtm
/approve


Upload of filenames containing accents not working

I would think this problem is papermerge rather than the docker image so I am submitting the issue here
Description
I am living in France so many filenames use é, è, à etc as accented characters.
Files are not uploaded if the filename contains accented characters.
Is this related to the use of SQLite (default) or other?
Info:

OS: [e.g. Synology NAS DSM with Docker image]
Browser [chrome, firefox]
Database [SQLite]
Papermerge Version [1.5.0]

Hi @Goliath67, thank you for opening this issue.
Application definitely works with Russian cyrillic and I saw it managed to upload (on demo site) even filenames with Japanese characters - thus it sounds unlikely to have a problem specifically with french accented characters.
I would help to investigate your issue if you can mention filename or (even better) a sample of problematic file.

Hi,
I just tried uploading the file to the demo website and it does indeed work correctly!
So would it be a problem because of using SQLite (default install) rather than MariaDB?
Or is it a problem I should rather transfer to the docker image github page?

SQLite by default works with character UTF-8 encodings as expected (i.e. works with french é, è, à characters).
My suggestion is to open a bug to whatever docker image provider you use (or whomever packages Papermerge application for you).

OK Many thanks.

Same issue for German umlauts. File can be uploaded, but PDF rendering breaks.
https://github.com/linuxserver/docker-papermerge/issues/16#issuecomment-735427190

@l4rm4nd  is still the case? I saw that ticket was closed on linuxserver's side. It is ok to close the ticket here as well?

Seems to be fixed for Papermerge 1.5.5. Cannot reproduce the previous issues.

@l4rm4nd is still the case? I saw that ticket was closed on linuxserver's side. It is ok to close the ticket here as well?
imho this issue is related to docker packaging, has nothing to do with application code.

Seems to be fixed in Papermerge 1.5.5. Cannot reproduce the previous issues.

@l4rm4nd thanks!


[Overlay] Fix server side rendering

The componentDidMount method is not called when rendering server side.
Aim to fix https://github.com/callemall/material-ui/issues/2013.

@oliviertassinari: I think this is fine.

Alright, I'm merging this then. It should be fine now.

I'm still getting this error with a fresh install from npm
ReferenceError: document is not defined
[object
...node_modules\material-ui\lib\overlay.js:64:34

Surprising, the docs say for ComponentDidMount

Invoked once, only on the client (not on the server), immediately after the initial rendering

Are you using the master branch? Any workaround?

I've got a minimum of 13.1 in my package.json file "material-ui": "^0.13.1" and that is what is installed:
> npm list material-ui
<EMAIL_ADDRESS>D:\projects\rrum
└──<EMAIL_ADDRESS>
npm has 13.1 as the latest version. https://www.npmjs.com/package/material-ui

Yes, this PR isn't released yet. Still, you can make npm use the master branch.

Ok, thanks: npm documentation on how to use github urls for depdendencies


Add Example Sites to Wiki

@envygeeks Thoughts on adding a "Sites Using Jekyll Assets" to the Wiki? I've got an OSS example here: https://github.com/jhabdas/habd.as. And instructions on how to add this gem to allow peeps to hit PageSpeed 100 here: https://habd.as/pagespeed-100-with-jekyll-s3-and-cloudfront/#add-the-jekyll-assets-gem. LMK or just close.

Yeah I'm cool with that. Is the wiki open or do I need to open it?
On Fri, Feb 24, 2017, 2:06 PM Josh Habdas<EMAIL_ADDRESS>wrote:

@envygeeks https://github.com/envygeeks Thoughts on adding a "Sites
Using Jekyll Assets" to the Wiki? I've got an OSS example here:
https://github.com/jhabdas/habd.as. And instructions on how to add this
gem to allow peeps to hit PageSpeed 100 here:
https://habd.as/pagespeed-100-with-jekyll-s3-and-cloudfront/#add-the-jekyll-assets-gem.
LMK or just close.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jekyll/jekyll-assets/issues/364, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGFs3EeUQI8XeCiLHVO4OzxNet4DX6Iks5rfzg5gaJpZM4MLnym
.

Needs open

https://github.com/jekyll/jekyll-assets/wiki/Sites-Using-Jekyll-Assets


[fpv,prim] Generalise FPV parameter that constrains what actions a prim_count is asked for

This is all about avoiding some vacuous assertions that are reported in prim FPV tests. The first commit generalises a DecrNeverTrue parameter that I added recently and allows a user to specify exactly which actions are possible in the given instance.
The second commit uses the new PossibleActions parameter in the alert_handler's ping timer, where we have two different instances of prim_count which are used in two different ways.
The end result should be to improve the "pass rate" in the nightly prim FPV tests.

The force-push with a tidyup seems to fix things. The Kokoro build is still failing, but that's an unrelated ascon issue which is being fixed elsewhere.


[Feature] Renovate for npm dependences

Feature Description
Replace Dependabot with Renovate for nom dependencies to have a single PR for bulk updates instead of PR for each.

Additional Information
Changes under test over in the Treasury repo

https://github.com/windranger-io/windranger-treasury/pull/155

Also update the current version to match those in the Treasury

Completed.


Missing socket syscall events (connect, bind,...) with kmod when running 32bit executable

Describe the bug
I've been testing driver+libscap separately from sysdig and subscribed only to a subset of syscalls (not all of them like sysdig does). When a 32 bit executable is running, the events from socket syscalls are missing. I've made some research and found out that the problem is in driver/src/main.c's record_event_consumer() function. (Consider connect syscall as I've been testing with it mostly). Basically, the function receives events for connect, but on 32 bit system they appear as PPME_GENERIC_E/X and later on they're extended in parse_socketcall() function to PPME_SOCKET_CONNECT_E/X events. The problem is that PPME_GENERIC_E/X is not set in the events_mask, got rejected by test_bit() function and events couldn't get a chance to be parsed properly.
Tested it on Ubuntu 18.04 and CentOS 7.9

How to reproduce it
Compile simple 32 bit executable:

Install dependencies:

For Ubuntu 18.04: apt-get install libc6-dev-i386 && cd /usr/include && ln -s x86_64-linux-gnu/asm/ asm
For Centos 7.9: yum install -y glibc.i686 glibc-devel.i686 libgcc.i686

Build: gcc -m32 test_connect.c -o test_connect

Simple executable link (markdown in the ticket breaks)
Modify sysdig to subscribe only to connect syscall:

Modify the file in main sysdig repo userspace/sysdig/utils/sinsp_opener.cpp

Rebuild sysdig
Run it with sysdig evt.type=connect

Run 32 bit executable test_connect

Expected behaviour
Events for connect syscall should be parsed and appear in sysdig output

Screenshots

Compiled two versions of program, run them with modified sysdig. 32 bit version hasn't given any events, while 64 bit showed proper results

Environment

Falco version:
sysdig version 0.30.1
falco libs version: 0.9.1
scap version: 3.0.1+driver

System info:
Not sure, how to build falco utility

Cloud provider or hardware configuration:
VMWare virtual machines: Ubuntu 18.04 and CentOS 7.9

OS:

ubuntu$ cat /etc/os-release
NAME="Ubuntu"
VERSION="18.04.6 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.6 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

centos$ cat /etc/os-release
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"

CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"

Kernel:
Ubuntu 18.04: 5.4.0-137-generic # 154~18.04.1-Ubuntu SMP Tue Jan 10 16:58:20 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
CentOS 7.9: 3.10.0-1160.81.1.el7.x86_64 # 1 SMP Fri Dec 16 17:29:43 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Installation method:

From source
Additional context

Hi! 32bit support is a well known limitation of our eBPF drivers. There is a tracking issue here: #279 .
In this case, since you are talking about the kmod, it should work. Therefore this is actually a new bug.
Indeed, this should be fixed in master since we now use the syscall number to filter (and not the event type).
See it here: https://github.com/falcosecurity/libs/blob/master/driver/main.c#L1792
But, thanks to you, we actually found a small bug: the socketcall resolved syscalls were not tested against syscalls interesting set on kmod.
I am going to open a PR to fix this!

Hi @FedeDP. Could you please tell which sysdig version is going to include those updates with syscall mask and when it's going to be released?

So, i opened a new PR to improve kmod code around socketcall (and eventually became a bigger refactor indeed): https://github.com/falcosecurity/libs/pull/1046.
You can expect a new driver tag in time for Falco 0.35 (end of may); but, since sysdig OSS has a completely unrelated release time frame, the new release can happen at any time. My guess is that it will get released right after Falco 0.35, therefore you can expect a release with these fixes around June.

/milestone driver-backlog

I think this is now tracking the same issue as #279 right? We can close this one in favor of the other?
Also, note that i opened a PR to support ia32 syscalls in bpf drivers: #1196
We haven't got the bandwidth to properly review and test it during this release cycle, therefore the new feature will be part of the Falco release after the next one, ie: Falco 0.37.

Yep, i think we can close this one as solved too.

yeah i asked @therealbobo to check it on OSS sysdig before closing it :)

LGTM! I just checked and the socket 32-bit syscall events (connect, bind, socket, ...) with the kmod are correctly received by OSS sysdig 😄 cc @Andreagit97

/close

@FedeDP: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Building tests on Linux Mint gives undefined reference to<EMAIL_ADDRESS>

Expected Behavior
Trying to compile and run the dlib unit test suite
Current Behavior
cmake --build . --config Release will result in the following error:
Scanning dependencies of target webcam_face_pose_ex
[ 63%] Building CXX object examples/examples_build/CMakeFiles/webcam_face_pose_ex.dir/webcam_face_pose_ex.cpp.o
[ 63%] Linking CXX executable webcam_face_pose_ex
/home/user/anaconda3/lib/libpng16.so.16: undefined reference to<EMAIL_ADDRESS>collect2: error: ld returned 1 exit status
examples/examples_build/CMakeFiles/webcam_face_pose_ex.dir/build.make:149: recipe for target 'examples/examples_build/webcam_face_pose_ex' failed
make[2]: *** [examples/examples_build/webcam_face_pose_ex] Error 1
CMakeFiles/Makefile2:1510: recipe for target 'examples/examples_build/CMakeFiles/webcam_face_pose_ex.dir/all' failed
make[1]: *** [examples/examples_build/CMakeFiles/webcam_face_pose_ex.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2

CMake Warning at /home/user/Downloads/dlib-19.13/examples/CMakeLists.txt:153 (add_executable):
  Cannot generate a safe runtime search path for target webcam_face_pose_ex
  because files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so.1] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /home/user/anaconda3/lib
    runtime library [libsqlite3.so.0] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /home/user/anaconda3/lib

  Some of these libraries may not be found correctly.

Steps to Reproduce
cd dlib/test
mkdir build
cd build
cmake ..
cmake --build . --config Release
./dtest --runall

Version:
dlib-19.13

Where did you get dlib:
the download dlib option on the official page

Platform:
Distributor ID:	LinuxMint
Description:	Linux Mint 18 Sarah
Release:	18
Codename:	sarah

Compiler:
-- The C compiler identification is GNU 5.4.1
-- The CXX compiler identification is GNU 5.4.1

Cmake is telling you the problem. You put anaconda’s copies of these libraries in your path and it’s conflicting with the correct system copies. You shouldn’t be doing that.


Windows Defender SmartScreen flag

Windows Defender Smart Screen is wrongfully flagging the RuneLight Setup executable as a risky application.
I'm assuming, given the message and the fact that it can't find the Publisher (see attached), it's because you haven't written the author into the executable, or have otherwise failed to identify yourselves correctly.

May want to put this issue on the forefront as it almost turned me off from using it until I saw the massive Open Source community you guys have (non-techies who just want a good, free, safe client may not bother).

it will be removed when windows 10 see enought user using the program anyway so no need to sign it

I've been working on getting a signing certificate, so this might be alleviated in a while.

The cheapest available is from Comodo however I push you to check out this organisation -> http://www.cacert.org

A new launcher release 1.5.1 is available, and is signed with a valid code signing certificate. We think this will either fix this, or cause it to be fixed soon.


Plugin dialog requests

🚀 Feature

While working on napari/napari#5198, there were a few requests that were outside of the scope of the PR or were "nice to have" items.  I wanted to document them here so they are not lost.

[x] Align plugin name and summary in the installed plugins section.
[x] Use display name instead of package name. See https://github.com/napari/napari-plugin-manager/pull/32
[ ] Fix install spinner and move plugins to available/installed list when uninstalled/installed.  see: https://github.com/napari/napari/pull/5198#pullrequestreview-1189305476
[x]  refactor code, one example is cleaning up the code that toggles which widgets are visible or not:
https://github.com/napari/napari/pull/5198#discussion_r1028817033

The following Originally posted by @DragaDoncila in https://github.com/napari/napari/pull/5198#pullrequestreview-1223755876

[x] Align installation info,  Make a standard size?  ( I know this button adjusts by the sizes on the drop down menus held within.  Eliding may help here (see item below).

[x] Ensure author names are aligned. (maybe misaligned only with many authors and in the presence of an update button?)

[x] Ensure very long descriptions and author lists are not cut off.

[x] Elide version numbers when long.
When users have a plugin dev version installed the Installation info button & section is very long. We probably want to elide this

[x] Set height of each item.

        if item.widget.install_info_button.isExpanded():
            item.widget.setFixedHeight(int(height * SCALE))
        else:
            item.widget.setFixedHeight(int(height / SCALE))
        item.setSizeHint(item.widget.size())

see https://github.com/napari/napari/pull/5198#discussion_r1108801401

[x] set size of widget in settings.  see: https://github.com/napari/napari/pull/5198#discussion_r1108805490
[ ] #79
[x] #29. See https://github.com/napari/napari-plugin-manager/pull/45

Let's resume the work here @goanpeca.

@hiroalchem question, is your request gear towards the lineedit in the bottom of the dialog where you can type any package or drag and drop a tarball from the filesystem?
Do you mean to add extra channel besides conda-forge, is the case for plugins in the napari plugin ecosystem that they need extra channels besides conda forge?
Thanks!

I'll close this issue since most tasks have been addressed. The remaining ones have been converted to issues, namely:

https://github.com/napari/napari-plugin-manager/issues/78
https://github.com/napari/napari-plugin-manager/issues/79
https://github.com/napari/napari-plugin-manager/issues/80


feat: Implement paid drop

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Feature

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #8835
[ ] Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[ ] My fix has changed UI

Copilot Summary
copilot:summary
copilot:poem

release incoming 👀

@Jarsen136 enabled

There is a CORS issue related with the vercel screenshot service. Could you check it? @vikiival
related to https://github.com/kodadot/workers/issues/244

✅ tested /ahk/gallery/330-1

LGTM

@Jarsen136 coretime is active too, no need to mock

@Jarsen136 coretime is active too, no need to mock

No worry, I only mocked it on my localhost and made a screenshot.

can we set date accordingly?

can we set date accordingly?
proper mint phase since is not yet open

✅ Both of them were fixed

@Jarsen136 could you also fix artist twitter? its leading to https://twitter.com/pifragile_ instead of /pifragile

@Jarsen136 could you also fix artist twitter? its leading to https://twitter.com/pifragile_ instead of /pifragile

It's intended and it's from the description of the collection
https://canary.kodadot.xyz/ahp/collection/66

Coming from @JustLuuuu
Will fix

@prury its correct on canary

@prury its correct on canary

huh?

I guess it's 7pm UTC, 5pm UTC+2

we are utc, so it should be 5pm UTC no?

I commited date fix (from mobile 🫣) should be up on canary soon

@Jarsen136  image screenshot failing. is that normal ? I'm using coretime drop

Should not be failing

There is a CORS issue related with the vercel screenshot service. Could you check it? @vikiival
related to kodadot/workers#244

Did you encounter this CORS issue on localhost? @hassnian

@hassnian whats is the output of the fail?
White screen or same pic as collection

yep cors

@hassnian whats is the output of the fail?
White screen or same pic as collection

same pic

@vikiival can /claim return nftName and Image ?

CORS was fixed, works bit differently than on CFW

so some requests are dead in the que. They should spawn in matter of minutes (I disabled kusama last time)

@vikiival can /claim return nftName and Image ?

Name is returned,
image can be returned too if it is sent to /claim request cc @Jarsen136

@vikiival can /claim return nftName and Image ?

Name is returned, image can be returned too if it is sent to /claim request cc @Jarsen136

I have added the image parameter for the /claim request.

How about merging this PR now? Then we could go to check the following-up issue #8846 @vikiival @yangwao

LGTM to me,
Note for other:
except the stuff with who minted (but it is on my side.)


"Bind for <IP_ADDRESS>:443 failed: port is already allocated" with open port

Description
Calling docker-compose up -d results in Bind for <IP_ADDRESS>:443 failed: port is already allocated despite port 443 being open.
Steps to reproduce the issue:

Check that port 443 is open with lsof -i:443
Run docker-compose up -d
Receive error

Describe the results you received:

Creating network "devboxes_default" with the default driver
Creating web-server-2
Creating aperture-redis-dev
Creating web-server-1
Creating portal-dev
Creating admin-dev
ERROR: for portal  Cannot start service portal: driver failed programming external connectivity on endpoint portal-dev (94c99e552d7cf9db94a83aa10950abee859bf585f1e3f7901d78ef513a9367a2): Bind for <IP_ADDRESS>:443 failed: port is already allocated
ERROR: Encountered errors while bringing up the project.

Describe the results you expected:
No errors.
Additional information you deem important (e.g. issue happens only occasionally):
Persisted across reboot, and other services can bind to port 443.
jmaguire@Johns-MacBook-Pro-2 [09:59:51] [~/src/aperture/devboxes] [test-container *]
-> % sudo lsof -i:443 | grep LISTEN
jmaguire@Johns-MacBook-Pro-2 [09:59:49] [~/src/aperture/devboxes] [test-container *]
-> % sudo netstat -an | grep 443
tcp4       0      0  <IP_ADDRESS>.62739   <IP_ADDRESS>.443     CLOSE_WAIT
tcp4       0      0  <IP_ADDRESS>.62738   <IP_ADDRESS>.443      ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.62734   <IP_ADDRESS>.443        ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.62731   <IP_ADDRESS>.443      ESTABLISHED
tcp6       0      0  ::1.58443              *.*                    LISTEN
tcp4       0      0  *.58443                *.*                    LISTEN
tcp6       0      0  ::1.8443               *.*                    LISTEN
tcp4       0      0  *.8443                 *.*                    LISTEN
tcp4       0      0  <IP_ADDRESS>.62686   <IP_ADDRESS>.443      ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.62685   <IP_ADDRESS>.443      ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.62684   <IP_ADDRESS>.443      ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.62683   <IP_ADDRESS>.443      ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.62682   <IP_ADDRESS>.443      ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.62681   <IP_ADDRESS>.443      ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.62641   <IP_ADDRESS>.443     ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.62632   <IP_ADDRESS>.443      ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.62566   <IP_ADDRESS>.443     ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.62547   <IP_ADDRESS>.443      ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.62461   <IP_ADDRESS>.443      ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.61847   <IP_ADDRESS>.443     ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.61702   <IP_ADDRESS>.443        ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.61701   <IP_ADDRESS>.443        ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.61700   <IP_ADDRESS>.443        ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.61612   <IP_ADDRESS>.443      ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.61611   <IP_ADDRESS>.443      ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.61610   <IP_ADDRESS>.443       ESTABLISHED
tcp4       0      0  <IP_ADDRESS>.61500   <IP_ADDRESS>.443    ESTABLISHED
4eaa687e426444d9 stream      0      0                0 4eaa687e42644349                0                0 /var/run/mDNSResponder
4eaa687e42644349 stream      0      0                0 4eaa687e426444d9                0                0

Bind:
jmaguire@Johns-MacBook-Pro-2 [09:59:54] [~/src/aperture/devboxes] [test-container *]
-> % sudo nc -l -p 443
foobar

Connect:
jmaguire@Johns-MacBook-Pro-2 [10:00:47] [~]
-> % nc localhost 443
foobar
^C%

Output of docker version:
Client:
 Version:      17.03.1-ce
 API version:  1.27
 Go version:   go1.7.5
 Git commit:   c6d412e
 Built:        Tue Mar 28 00:40:02 2017
 OS/Arch:      darwin/amd64

Server:
 Version:      17.03.1-ce
 API version:  1.27 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   c6d412e
 Built:        Fri Mar 24 00:00:50 2017
 OS/Arch:      linux/amd64
 Experimental: true

Output of docker info:
Containers: 5
 Running: 4
 Paused: 0
 Stopped: 1
Images: 111
Server Version: 17.03.1-ce
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 94
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host ipvlan macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 4ab9917febca54791c5f071a9d1f404867857fcc
runc version: 54296cf40ad8143b62dbcaa1d90e520a2136ddfe
init version: N/A (expected: 949e6facb77383876aeff8a6944dde66b3089574)
Security Options:
 seccomp
  Profile: default
Kernel Version: 4.9.13-moby
Operating System: Alpine Linux v3.5
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 1.952 GiB
Name: moby
ID: 4LKB:SKZH:HLDI:4HCI:AYZ4:CRYH:23FP:3PNN:NWUV:H3EM:BQ2G:EU2H
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 49
 Goroutines: 52
 System Time: 2017-04-03T08:48:20.349192407Z
 EventsListeners: 1
Username: jmaguire
Registry: https://index.docker.io/v1/
Experimental: true
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Additional environment details (AWS, VirtualBox, physical, etc.):
Running on Docker for OS X.

Looks like this was due to a docker-compose override issue actually: https://github.com/docker/compose/issues/3675


Semantic-UI is Better than Bootstrap

Hi,
Im just proposing an enhancement, using Semantic-UI instead of Bootstrap.
I believe that Semantic UI will be the best font-end Framework. check out:
http://beta.semantic-ui.com
SUI v2.0 will be out soon, I think after 2 weeks (the creator said that).
so plz think about that

Dup of https://github.com/aspnet/Mvc/issues/2568.

Moving to https://github.com/aspnet/Tooling/issues/97 as this is really about what we ship in our project templates.


Expose set_changed() on ResMut and Mut

This new api stems from this discord conversation.
This exposes a public facing set_changed method on ResMut and Mut.
As a side note: ResMut and Mut have a lot of duplicated code, I have a PR I may put up later that refactors these commonalities into a trait.

As a side note: ResMut and Mut have a lot of duplicated code, I have a PR I may put up later that refactors these commonalities into a trait.

Yep! That was part of the inspiration behind #2189, which you may find useful.

bors r+


LLaMA-Adapter

There is a new adapter called LLaMA-Adapter, a lightweight adaption method for fine-tuning instruction-following LLaMA models fire, using 52K data provided by Stanford Alpaca.
Open source status

The model implementation is available in the github repo
The model weights are partially available: Variants of LLaMa are available, e.g. gpt4all GPTQ-for-LLaMa. The weights LLaMA-Adapter aren't available.
Authors of LLaMA-Adapter are @ZrrSkywalker @csuhan @lupantech

any updates related to this enhancement? I think llama adapter is really influential with more than 5k stars and such enhancement will be very useful/


The value -1 is outside the acceptable range of [0,2147483647], parameter name: value'

Visual Studio Community 2019 Version 16.2.0
When adding a new controller "Web API 2 Controller - Empty" I receive this error after naming the controller:
'The value -1 is outside the acceptable range of [0,2147483647], parameter name: value'
First, What does that mean?
Second, how do I fix this error?

Can you provide a bit more context around what you are doing and where you are seeing this error?

I essentially following the Autodesk Forge Tutorial and got to this step (https://learnforge.autodesk.io/#/oauth/2legged/net) in the process when I received the error.

Sorry I'm not familiar with this tutorial or how the error would relate to Indy Catalyst.  I haven't seen this error before.

Could you recommend me to someone that does?
I've scoured the help forums of both visual studio and github, and the only other one that mentions the same error as mine doesn't have a solution either.
I cannot create a web api controller without figuring out what this error even means.

Try asking the authors of the tutorial, I notice there is a link at the bottom of the page:
"Questions on this tutorial? Ask on Stackoverflow or email us"

Someone has already asked the same error question.
I've added mine to the pool of questions, but no one has solution for the other guy yet either.


Config loading does not work in exported projects in 1.7.8

Subj. Config does not get loaded and windows (e.g. native logger, expressions, history, etc.) are being opened automatically on start.
This seems to be the bug in 1.7.8. With 1.7.7 I don't have such problems
To Reproduce

Add v1.7.8 plugin to the project, export project and run *.console.exe to see errors
Console has parse errors reported for panku code
Project launches with panku windows opened and stacked in top-left one on top of the other

Expected behavior
No warnings, project loads without panku windows all opened.
Desktop (please complete the following information):

OS: Windows
Version: 1.7.8

Could you please provide more information about the reported errors? I'll give it a test later.

*.cfg files are not included by default in the export templates. I've had to manually add the default preset cfg file in the include_filter of my export config.

EditorExportPlugin is buggy, so it will be removed temporarily.
https://github.com/godotengine/godot/issues/73525

*.cfg files are not included by default in the export templates. I've had to manually add the default preset cfg file in the include_filter of my export config.

Are you saying that this file is not accessible in exported project by default?
const INITIAL_DEFAULT_CONFIG_FILE_PATH = "res://addons/panku_console/default_panku_config.cfg"


[JIRA-Ticket No.WC-14] Implement Home Page

This pull request is about implementation of homepage consisting of components such as navbar, course, and footer. In this page, I have provided the link to login and sign-up page too.
What
Why
Type of change
Please check the relevent option with x.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (if needed)
[ ] My changes generate no new warnings
[ ] I have tested on my Local Machine

Summary by CodeRabbit
Release Notes

New Features

Introduced multiple new components: ClientReview, Contact_us, Footer, ForgetPassword, Login, MostPopularCourse, RecentCourses, and RecommendedForYou.
Enhanced the home page layout with new sections for popular courses, recent courses, recommendations, client reviews, and a contact section.
Added a password recovery feature with a user-friendly interface.

Bug Fixes

Added custom spelling exception for "fname" in code spell checker settings.

Documentation

Updated data files to include course details for client reviews, recently viewed courses, and recommended courses.

Good good, also don't forget to add what and why. GL ⭐


package:flutter/src/painting/text_style.dart': Failed assertion: line 1254 pos 14: 'decorationDescription.isNotEmpty': is not true.

════════ Exception caught by Flutter framework ═════════════════════════════════
'package:flutter/src/painting/text_style.dart': Failed assertion: line 1254 pos 14: 'decorationDescription.isNotEmpty': is not true.
════════════════════════════════════════════════════════════════════════════════

I am getting the following error how do I solve this

Hi @umakanth-pendyala
Can you please provide your flutter doctor -v your flutter run --verbose and a complete reproducible minimal code sample
Thank you

I'm sorry I didn't inform this, the issue is solved. I messed with the text decoration inside the app. Yeah but now it's all good.Thank you

Hi @umakanth-pendyala
given your last message I feel safe to close this issue, if you disagree please write in the comments and I will reopen it.
Thank you

If anyone still gets this issue, make sure you are setting at least one of these three: decoration, decorationColor or decorationStyle if you are setting decorationThickness.
DebugFillProperties of TextStyle checks this:
if (decoration != null || decorationColor != null || decorationStyle != null || decorationThickness != null) {
and then assumes that some of the mentioned three properties are not null ands them to decorationDescription.
Later on, an assertion is made that decorationDescription is not empty, but it will be empty if you only set decorationThickness (not any of the remaining three).


Entering carbs on watch has got extremely slow

iPhone 14 pro max with iOS 17.0.3
Apple watch ultra 1 with watchOS 10.1.1
iAPS 2.2.7 dev build 56dfcea
Entering the carbs is ok but the wait for confirmation sometimes takes nearly a minute. I'm not bolusing (or displaying the bolus option), just entering carbs.

There any specific moment this happens or it always happens? I'm getting confirmation within two seconds, but I keep iOS and WatchOS (Series 9) up to date so running a bit different versions than you are.

No, not always but often.
I can't identify when it does and when it doesn't.


*-editorial class modifier is missing from the Pattern Library

Describe the bug
*-editorial class modifier is missing from the Pattern Library.  As a developer I'm looking to the existing reference to be able to understand how classes will/should be applied.  The editorial modifier is not there.
To Reproduce
Run the Pattern Library.
Expected behavior
All classes/modifiers that are part of Meta should have documentation/reference in a single location.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Linux
Browser: Chrome
Version: 72

Smartphone (please complete the following information):
n/a
Additional context

Turns out *-editorial margins work correctly but the font sizes are not. Working on this issue now..

Ha. Everything is actually working correctly.. I just need to update the user instructions. I forgot that I changed how the *-editorial classes are used.

Updating the user instructions now..

Issue resolved. Updated instructions for *-editorial classes are here.. https://github.com/universelabs/meta/blob/master/DOCUMENTATION.md#editorial.


Text Edit Mode: Resizing heading causes text selection if done right after adding

Bug Description
Under specific conditions, the text is selected when resizing in edit mode.
See the original report: https://github.com/google/web-stories-wp/issues/1801#issuecomment-658975910

Expected Behaviour
Text should never get selected when resizing in edit mode.

Steps to Reproduce

Add a heading
Type something to enter edit mode
Now resize from the bottom right corner.
See the text getting selected.

Screenshots

Additional Context

Plugin Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

I can't reproduce this, please reopen if this is still an issue.


on Safari, unload and beforeunload events can't make segment request

Having same issue as this person here . In short: Segment requests are async and Safari does not wait for async requests when unloading the page, so we lose events about our users. Only workaround is the Beacon API which is not supported by all browsers yet.
Has anyone else encountered this issue?

The requests must be async otherwise your users will have a poor customer experience. We've added persistent queues for this reason (https://github.com/segment-integrations/analytics.js-integration-segmentio/commit/aae60a40f8fae099cc58aba12141738abddcc909), this is currently being tested behind a flag.

So it's been tested with scenarios like I mentioned?
What's the easiest way to integrate it into our normal flow?

Is there a problem with using feature detection to see if Navigator.sendBeacon is available and defaulting to that and then falling back to XMLHttpRequest when its not there?

Sorry for the delay - we had considered doing that originally (https://github.com/segment-integrations/analytics.js-integration-segmentio/commit/2801ef5d45678c86579dfb9448ffa46449b4db54), but ultimately decided against it for various reasons.

If you'd like to beta test the retry queue functionality (the one in https://github.com/segment-integrations/analytics.js-integration-segmentio/commit/aae60a40f8fae099cc58aba12141738abddcc909), please reach out to our support team via http://segment.com/contact and they can get you setup.

@f2prateek Hi, I am looking to try the retry queue functionality, do I still need to contact the support team for this to be enabled? If so, I go to Contact Us -> Tech Support-> Technical Support, I see a contact form, but no where to input my contact info, how will the support contact me about my question, do I need to be logged in?

Sorry for the delay - we had considered doing that originally (segment-integrations/analytics.js-integration-segmentio@2801ef5), but ultimately decided against it for various reasons.

Hello @f2prateek I know it's been a long time since you left the comment, but if you still remember, can you help me understand what the reasons were for you to decide against sendBeacon?

@eunjae-lee This feature would be great to send a final message to segment that the app is closing.


Ben, may be change your video's title and thumbnail?

People can't tell what the video is about and think it's just another vscode extension. Just a totally rejectable suggestion.
it can be something like: "Dogehouse, the new Clubhouse? :O", maybe

yess

You have a point @nadirabbas


fix: Build returns non-zero exit code for failed builds.

This time I'm bringing even more conflicts on other branches 😭  Fixes #61

Looks good to me. Maybe one more set of eyes?


GlobeAwareDefaultPawn should only overwrite ECEF from Unreal when necessary.

Currently, GlobeAwareDefaultPawn uses a quick dirty way of surviving georeference changes which is to update the internal ECEF representation (_currentEcef) from the current Unreal position every frame in Tick. This is stored so that later, when the georeference changes, the recently updated _currentEcef can be used to calculate the new Unreal position in the new georeference.
This is fine when this pawn is the one being controlled, since the origin will always rebase to be near the pawn and the Unreal coordinates will be small and sufficiently accurate. However, when the pawn is stationary and far away from the origin, this system more than likely causes loss in precision which in worst case will be exactly as imprecise as Unreal's single-precision (with origin rebasing). This is in contrast to the CesiumGeoreferenceComponent which attempts to be very careful about when to update the internal ECEF representation.
The georeferencing of GlobeAwareDefaultPawn should be reworked eventually to minimize needlessly overwriting the internal ECEF representation in the cases where we can avoid it.

Referring to my question at https://github.com/CesiumGS/cesium-unreal/pull/459#discussion_r675639262 : Is it right that this could ~"more sensibly" be solved by overriding ApplyWorldOffset in the GlobeAwareDefaultPawn, and adding the new World offset to the current ECEF position?
(This sounds tricky, because... the position of the pawn somehow determines whether an origin rebasing is performed in the first place, raising a load of questions about "who is going to update what based on what". But if this sounds like a viable path, I'd give it a try...)


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
d3a341c -> 67f3ce5

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.35.3 -> v1.35.4

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.35.4
Compare Source
Bug Fixes

bug with stack arrays (#843) (4e09e9c)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This issue has been resolved in version 1.16.4 :tada:
The release is available on:

GitHub release
v1.16.4

Your semantic-release bot :package::rocket:


Fix sentry in worker

Configure sentry only for the first time.
Fixes RED-HAT-0P-2AV (I hope.)

1. `lazy_object_proxy` should become a dependency and installed in `files/install-deps*.yaml`. Maybe it's already indirectly pulled in by something else, still, might be better to be explicit.

It should be already there because of the packit. I'll check it once again.

2\. I'm not really familiar with lazy initialisation. Is there be any considerable performance impact with this?

Nothing I am aware of -- it only postpones the creation of an object until you need to use it. (No big magic.)

@csomh is the setup.cfg in packit enough?
https://github.com/packit-service/packit/blob/5fcddebb447a465e2c6deb64d9b5fd643fac2739/setup.cfg#L42

@csomh is the setup.cfg in packit enough?
https://github.com/packit-service/packit/blob/5fcddebb447a465e2c6deb64d9b5fd643fac2739/setup.cfg#L42

As this has become an explicit dependency for packit-service would be better to have it here, too. So that things don't break here, if it gets removed from packit.

As this has become an explicit dependency for packit-service would be better to have it here, too. So that things don't break here, if it gets removed from packit.

This is applicable to multiple packit dependencies -- do we really want all of them explicitly marked here as well? (The tests will tell us if we break that, won't they?)

As this has become an explicit dependency for packit-service would be better to have it here, too. So that things don't break here, if it gets removed from packit.

This is applicable to multiple packit dependencies -- do we really want all of them explicitly marked here as well? (The tests will tell us if we break that, won't they?)

packit-service and packit are two separate projects. Implicitly inheriting dependencies from a different project is bad, as it creates a tight coupling between the two.
Are we sure that the coverage of our tests is good enough to catch missing dependencies?
And yes, it's clear that many dependencies of packit-service are not explicitly stated as such. That can be fixed as part of a different effort. In this PR we should just make sure not to add yet another item to that list.

Are we sure that the coverage of our tests is good enough to catch missing dependencies?

If we import each file of the code in tests, then yes. (I think we do that.)
(I've added the dependency.)


Please remove akveo slack token from the travis file

Hey Guys, great project!
Just one thing, could you please remove the akveo slack token from the travis configuration here https://github.com/salonhelps/salon-cloud/blob/master/.travis.yml#L17 as we are getting notification into our slack channel for each of your travis build :)
Thanks for understanding.

Oop, DONE.


splice method should be listed in Array instead of List

https://github.com/rakudo/rakudo/blob/e0647c67a008184d15dc4d02dc7ea9a5675e20bf/src/core/List.pm#L59

Thanks.  Probably got overlooked in the post GLR doc cleanup


[BUG] No option to add video in Load Video Node

No option to add video
Screenshots

Hi, log please!

@Nuked88 Tried reinstalling, no error in the dependencies. It was successfully installed. But still, the node has no button to select/upload video. Is there any additional installation step apart from the ComfyUI Manager?

Hi! For some reason is not installing Timm, I need to reproduce the problem and then i'll let you know!

@Nuked88 I tried adding it to one of the requirement.txt and installing it. It's present in site-packages too but still its throwing same error.

Hi, I'm having the same problem

can you guys give me the list of all the custom node you have installed? I suspect that some other node is in conflict with mine

I have;
ComfyUI-Manager
ComfyUI-N-Nodes
comfyui_controlnet_aux
I am running in venv, i installed the requirements.txt of  ComfyUI-N-Nodes and comfyui_controlnet_aux manually into venv.
Log
** ComfyUI start up time: 2024-02-27 15:43:48.427001
Prestartup times for custom nodes:
0.0 seconds: /my_dev/big_ai_etc/imaging/ComfyUI/custom_nodes/ComfyUI-Manager
Total VRAM 11009 MB, total RAM 48088 MB
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 2080 Ti : cudaMallocAsync
VAE dtype: torch.float32
Using pytorch cross attention
Current version of packaging: 23.2
Version of cpuinfo: Version information not found
Current version of git: 3.1.42
Current version of moviepy: 1.0.3
Current version of cv2: 4.9.0
Current version of skbuild: 0.17.6
Version of typing: Version information not found
Current version of diskcache: 5.6.3
Current version of llama_cpp: 0.2.26+cu121
Current version of timm: 0.9.16
timm is already up-to-date with version 0.9.16
Loading: ComfyUI-Manager (V1.5.2)
ComfyUI Revision: 2025 [1e0fcc9a] | Released on '2024-02-27'
[comfyui_controlnet_aux] | INFO -> Using ckpts path: /my_dev/big_ai_etc/imaging/ComfyUI/custom_nodes/comfyui_controlnet_aux/ckpts
[comfyui_controlnet_aux] | INFO -> Using symlinks: False
[comfyui_controlnet_aux] | INFO -> Using ort providers: ['CUDAExecutionProvider', 'DirectMLExecutionProvider', 'OpenVINOExecutionProvider', 'ROCMExecutionProvider', 'CPUExecutionProvider', 'CoreMLExecutionProvider']
Import times for custom nodes:
0.0 seconds: /my_dev/big_ai_etc/imaging/ComfyUI/custom_nodes/ComfyUI-Manager
0.3 seconds: /my_dev/big_ai_etc/imaging/ComfyUI/custom_nodes/comfyui_controlnet_aux
0.7 seconds: /my_dev/big_ai_etc/imaging/ComfyUI/custom_nodes/ComfyUI-N-Nodes
Starting server
To see the GUI go to: http://<IP_ADDRESS>:8188
FETCH DATA from: /my_dev/big_ai_etc/imaging/ComfyUI/custom_nodes/ComfyUI-Manager/extension-node-map.json
Stopped server

No errors in browser F12 screen.
Firefox. Linux.
Same issue of no upload/video window as mentioned in OP.
What package/node is responsible for showing that 'control'?

Requirement already satisfied: timm in c:\users\kaila\appdata\roaming\python\python311\site-packages (0.9.16)

You know what's weird in this log?
This line:
Requirement already satisfied: timm in c:\users\kaila\appdata\roaming\python\python311\site-packages (0.9.16)
Why is the portable enviroment searching in your global enviroment? This is not happening to me even if i have the same enviroment as you! This is leading ComfyUI thinking that you have timm already installed in the portable enviroment but in reality is not. You can easily solve the problem by temporarily remove timm from your global enviroment and launching comfyui so timm should be correctly installed. (Then you can reinstall it in the global enviroment)
Btw this is really really weird because ComfyUI should't check in the global enviroment, maybe you have some custom node that is adding this "feature"?

I have; ComfyUI-Manager ComfyUI-N-Nodes comfyui_controlnet_aux
I am running in venv, i installed the requirements.txt of ComfyUI-N-Nodes and comfyui_controlnet_aux manually into venv.
Log
** ComfyUI start up time: 2024-02-27 15:43:48.427001
Prestartup times for custom nodes: 0.0 seconds: /my_dev/big_ai_etc/imaging/ComfyUI/custom_nodes/ComfyUI-Manager
Total VRAM 11009 MB, total RAM 48088 MB Set vram state to: NORMAL_VRAM Device: cuda:0 NVIDIA GeForce RTX 2080 Ti : cudaMallocAsync VAE dtype: torch.float32 Using pytorch cross attention Current version of packaging: 23.2 Version of cpuinfo: Version information not found Current version of git: 3.1.42 Current version of moviepy: 1.0.3 Current version of cv2: 4.9.0 Current version of skbuild: 0.17.6 Version of typing: Version information not found Current version of diskcache: 5.6.3 Current version of llama_cpp: 0.2.26+cu121 Current version of timm: 0.9.16 timm is already up-to-date with version 0.9.16
Loading: ComfyUI-Manager (V1.5.2)
ComfyUI Revision: 2025 [1e0fcc9a] | Released on '2024-02-27'
[comfyui_controlnet_aux] | INFO -> Using ckpts path: /my_dev/big_ai_etc/imaging/ComfyUI/custom_nodes/comfyui_controlnet_aux/ckpts [comfyui_controlnet_aux] | INFO -> Using symlinks: False [comfyui_controlnet_aux] | INFO -> Using ort providers: ['CUDAExecutionProvider', 'DirectMLExecutionProvider', 'OpenVINOExecutionProvider', 'ROCMExecutionProvider', 'CPUExecutionProvider', 'CoreMLExecutionProvider']
Import times for custom nodes: 0.0 seconds: /my_dev/big_ai_etc/imaging/ComfyUI/custom_nodes/ComfyUI-Manager 0.3 seconds: /my_dev/big_ai_etc/imaging/ComfyUI/custom_nodes/comfyui_controlnet_aux 0.7 seconds: /my_dev/big_ai_etc/imaging/ComfyUI/custom_nodes/ComfyUI-N-Nodes
Starting server
To see the GUI go to: http://<IP_ADDRESS>:8188 FETCH DATA from: /my_dev/big_ai_etc/imaging/ComfyUI/custom_nodes/ComfyUI-Manager/extension-node-map.json
Stopped server
No errors in browser F12 screen. Firefox. Linux. Same issue of no upload/video window as mentioned in OP.
What package/node is responsible for showing that 'control'?

is a JS ,but since you have only three node maybe is just a cache issues, had you already installed my node before this update?

namespace?

The last version of comfyui "dropped" the support"  to the way i was using to load the JS...
I didn't know that since it was working fine a week ago...

Ok i've pushed a fix, can you try now?

Ok i've pushed a fix, can you try now?

I updated, now I have the upload video, and it seems ok, doing a test video... at the end I'll let you know, Thank You!

Perfect!

Works for me.
Thank you.

Yes it works, thank you.


Fix a rare scenario of wrong GW listeners

Please provide a description of this PR:
In (rare) cases when a WorkloadEntry holds an address similar to another instance in the mesh, this causes the lookup for the workload labels to return incorrect labels.
For instance, if a WE has similar address as GW, when looking for the GW labels for building listeners the wrong labels set is returned which causes wrong listeners to be pushed.
This fix is sorting the registries to make the External registry to get lower priority in cases more than one registry has workload with the same address.
Resolves #44212

/test integ-ambient

@ymesika: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
7f0b65678b7b05fa27b949d192087dae34ce0972
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
7f0b65678b7b05fa27b949d192087dae34ce0972
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks. I verified that #43837 also fixes https://github.com/istio/istio/issues/44212.


Replace DTO's with scalar values in Commands

[ ] AddCartItemCommand
[ ] AddShipmentTrackingCodeCommand
[ ] BuyShipmentLabelCommand
[ ] CreateAttachmentForOrderItemCommand
[ ] CreateAttachmentForUserProductCommand
[ ] CreateImageForProductCommand
[ ] CreateImageForTagCommand
[ ] CreateOptionCommand
[ ] CreateOptionProductCommand
[ ] CreateOptionValueCommand
[ ] CreateOrderFromCartCommand
[ ] CreateProductCommand
[ ] CreateTagCommand
[ ] CreateUserCommand
[ ] SetCartFlatRateShipmentRateCommand
[ ] SetExternalShipmentRateCommand
[ ] UpdateOptionCommand
[ ] UpdateOptionProductCommand
[ ] UpdateOptionValueCommand
[ ] UpdateProductCommand
[ ] UpdateTagCommand

The primary focus is to replace EntityDTOs with scalar values. MoneyDTO, BillingAddressDTO, and a few others may have a valid reason to stay.

The primary focus is to replace EntityDTOs with scalar values. MoneyDTO, BillingAddressDTO, and a few others may have a valid reason to stay.


Added python3.6 version to supported versions list.

All tests passed on this configuration:
platform linux -- Python 3.6.2, pytest-3.0.7, py-1.4.34, pluggy-0.4.0

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks a lot!


Customize the authentication token in Windows artifact

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Make menu plugin can be configured by a functional config.

https://github.com/Saul-Mirone/milkdown/commit/e147d39dc3332b8e6612e353abb79722e5c10cc6


Add jumping to the first incomplete in forward journey

What is the context of this PR?
Describe what you have changed and why, link to other PRs or Issues as appropriate.
How to review
Describe the steps required to test the changes (include screenshots if appropriate).
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 Forward journey and jumping to the first incomplete (5 SP)


[5.1 04-24-2019] [code-completion] Avoid invalid member substitution for keypath dynamic lookup

Cherry-pick https://github.com/apple/swift/pull/24520 to swift-5.1-branch-04-24-2019
Reviewed by: @rintaro

When performing keypath dynamic member lookup, avoid substituting the base type in override detection and completion, as the base type of the lookup is not the base type of the member. For now, we just avoid the substitution entirely to fix potential crashes; in a future commit we will change to using the subscript return type and substituting with the base type of the subscript instead of the base type of the lookup.
rdar://50449788

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - df12c6513010265cdd8ae8ff2d13079560742b81

Build failed
Swift Test OS X Platform
Git Sha - df12c6513010265cdd8ae8ff2d13079560742b81

Please test with the following PRs:
https://github.com/apple/swift-lldb/pull/1543
@swift-ci please test


Set app state on history/prop changes

Description

Updates the state of the app UI when going back and forward in browser history.

Closes #135
QA steps

[ ] Change any setting other than map location
[ ] Go back and forth in history to confirm that both the app UI and behavior reflect the correct point in history

Author checklist
Create the PR

[x] Fill out PR template
[x] Make sure you've added a CHANGELOG entry under "Unreleased"
[x] Request a review
[ ] Make any requested changes and get approval

After approval

[ ] Merge any changes from main into your branch, resolve any conflicts
[ ] Squash & merge changes into main
[ ] Delete branch

I mention a (perhaps unintended) side effect in my comment below but it seems fine to me if it's okay with you.

I think the idea before was that this function only existed to clear the selected value once you move away from it. The way it works now means that if you wander around the map and somehow manage to match one of the options that will be selected for you. You can see that with the "zoomed out" scenario in the default config:

That makes sense to me. I feel ok about this as is too. Unless you're doing that specifically (hitting zoom in then zoom out, it's pretty rare to hit the exact spot that will change that value. I'd say if it proves confusing we can handle as followup since not differentiating those scenarios (read from hash vs panning around) is the easiest path here.


Error 137 while installing requirements

The GTN tutorial on viewing the site locally basically says that one should run

make create-env
make install

after installing Conda.
I have a fresh local clone of the repository. When running make create-env (step 1), an out of memory error occurs (error 137):

(base) user@hostname:~/Documents/galaxy-training-material$ make create-env
find: ‘_site/training-material’: No such file or directory
find: ‘_site/training-material///slides/*’: No such file or directory
find: ‘_site/training-material’: No such file or directory
if ~/.anaconda3/bin/conda env list | grep '^galaxy_training_material'; then
~/.anaconda3/bin/conda env update -f environment.yml;
else
~/.anaconda3/bin/conda env create -f environment.yml;
fi
Collecting package metadata (repodata.json): done
Solving environment: \ bash: line 4: 3332886 Killed                  ~/.anaconda3/bin/conda env create -f environment.yml
make: *** [Makefile:43: create-env] Error 137

The same happens when I try running make install (step 2) after creating the environment manually using mamba env create -f environment.yml:

(galaxy_training_material) user@hostname:~/Documents/galaxy-training-material$ make install
find: ‘_site/training-material’: No such file or directory
find: ‘_site/training-material///slides/*’: No such file or directory
find: ‘_site/training-material’: No such file or directory
if ~/.anaconda3/envs/galaxy_training_material/bin/conda env list | grep '^galaxy_training_material'; then
~/.anaconda3/envs/galaxy_training_material/bin/conda env update -f environment.yml;
else
~/.anaconda3/envs/galaxy_training_material/bin/conda env create -f environment.yml;
fi
Retrieving notices: ...working... done
Collecting package metadata (repodata.json): done
Solving environment: \ bash: line 4: 3341561 Killed                  ~/.anaconda3/envs/galaxy_training_material/bin/conda env create -f environment.yml

So how to install the requirements?

So in case someone else stumbles into this issue. Running make install --dry-run gave me the necessary hints to install the requirements manually:

gem update --no-document --system
ICONV_LIBS="-L~/.anaconda3/envs/galaxy_training_material/lib/ -liconv" gem install --no-document addressable:'2.5.2' jekyll jekyll-feed jekyll-redirect-from csl-styles awesome_bot html-proofer pkg-config kwalify bibtex-ruby citeproc-ruby fastimage
pushd ~/.anaconda3/envs/galaxy_training_material/share/rubygems/bin
ln -sf ../../../bin/ruby ruby

However, for some reason, running make serve-quick afterwards fails with the error

EnvironmentNameNotFound: Could not find conda environment: galaxy_training_material
You can list all discoverable environments with conda info --envs.

although I can see from conda info --envs that the environment is there.
So instead of using make serve-quick, one has to use:
mv Gemfile Gemfile.backup || true && \
mv Gemfile.lock Gemfile.lock.backup || true && \
jekyll serve --strict_front_matter -d _site/training-material --incremental --config _config.yml,_config-dev.yml -P 4000 -H <IP_ADDRESS> ""

However, I guess this is rather a workaround than a solution, so I'll leave this issue as open.

an out of memory error occurs (error 137):

how much memory is on your system? It make sense that conda requires too much, but there is essentially no possible workaround there other than "buy more RAM".
As for using a non-conda installation, yes, this works well. A number of us use RVM to manage multiple Ruby installations, and build it that way since conda can indeed be quite 'heavy'

how much memory is on your system? It make sense that conda requires too much, but there is essentially no possible workaround there other than "buy more RAM".

The system has 32 GiB of RAM. It‘s actually somewhat hard to believe that this isn’t supposed to be more than enough?

Oh, no, that is much more than enough. It should easily build with ~4GB. In that case I'm really not sure why conda is having an out of memory issue there, generally that should only affect small machines. https://github.com/conda/conda/issues/7614

fixed by #4511


Localizer static access

@ghost1372
I implemented static access and pushed a branch: feat-add-static-access. I'd like to have your opinion on this. You can see how to use it in the sample project.🙏

Closed by #24


Refactor Inlet's tests to be language-agnostic

Summary

This PR is a refactoring
It does the following:

Utilizes Google Test's type-parameterized tests to allow for tests of multiple reader types using the same test string

In anticipation of inlet::Reader implementations for JSON and YAML Inlet's tests have been refactored to be language-independent.  As Lua's functionality is a superset of JSON's/YAML's, the idea is to keep all tests written in Lua and write a minimal translation tool for the tests whose inputs correspond to valid YAML/JSON.  This mitigates the need to maintain hundreds of tests in different input languages and to make sure that their behavior is identical.
Tests covering features available in Lua but not in JSON/YAML (discontiguous arrays, for example) will remain Lua-specific.
Almost all of this PR is boilerplate changes to use type-parameterized tests - the main exception is tests that needed to be modified to fit the subset of Lua that corresponds to valid YAML.  The original tests were preserved and made to use a fixed (Lua) reader type.

Have you tried this with yaml/json files? Or is this just in anticipation of this working with yaml/json. (Obviously, this PR does not yet include the yaml/json stuff).

Yes, I have a mostly-complete YAML reader on a different branch


Added Leaflet.Path.Transform

Added Leaflet.Path.Transform for vector features rotation and scaling

Great :) thank you!

Looks good!


Add sqrt

There's an occasional need for
sqrt :: Natural -> Natural

The function would probably be best placed in plutus-numeric.

How should this be defined? Is it the floor of the square root?

Presumably. If you want the nearest root it's easy enough to compare if the next number up is a closer match.


implement association helper

Another feature I was happy to see in the roadmap as it's super useful :). Works with name override, traits and attribute overrrides.
I think traits / association handling may need some refactoring, the responsibilites are a bit split betweem the factory itself and the server and it's not really clear what should happen where (e.g. some attributes are deleted in factory, others in server). And the building / creating could be actually delegated to some other object so that there's no so much logic directly in the server. But that's probably out of the scope of this PR.

Awesome work.
I'm confused about the argument to association, for example kind: association('category'). What is category in this case, is it because the association on the original model is named differently from the model's type? Can't we introspect that?
Also, in the future, instead of using factory functions for objects let's use ES6 classes, to keep with the style of most of the other objects in Mirage.

What is category in this case, is it because the association on the original model is named differently from the model's type? Can't we introspect that?

Yeah, exactly, just like this example shows:
post: Model.extend({
  author: belongsTo(),
  kind: belongsTo('category')
})

so it would need to be:
kind: association('category')

I wanted to be explicit here and avoid extra coupling. We probably could introspect it, but that would require coupling to models - we currently can create / build new records without even registering the models, it's just  this.factoryFor(type) and we have a factory for given type without involing enything else. So not sure if it's worth doing. What do you think?

Hm, well the factory relationships were intended to be used with the ORM. I mean the ORM is what makes the relationship stuff possible at almost every level - the relationship methods on models, the serializer relationship lookups etc.  I don't think folks should be using association without using Models, this is not really supported.
I think the name of the association should be the named relationship on the model (kind here), I don't think the factory should take in type. Again if a model had even more information on that named relationship (inverse, polymorphic etc) the factory layer should not be concerned with this. It should just delegate to the ORM and say, "I want an associated kind for this model, whatever that may be."
Thoughts?

Well, I agree with that, but I think it mostly comes to down to the question if we want to couple factories to models. Currently factories are independent from the models and the ORM provides the further integration - factories just build / create some objects that are inserted to db. And we can actually create whatever we want with factories - it doesn't have to be a model. Not sure if it's a valid and/or intended use case for factories, but it's worth keeping in mind.
The association helper in current implementation is not literally for associations but rather embedded objects created by factories,  association is just a name that makes most sense here.
So for either case, there is some trade-off: coupling to models would be more cohesive probably, but it will mean less flexibility in the kinds of objects we can create. If the direction is to use factories only for models, I guess it would be a good idea to introduce some coupling and introspect info for association from models.

@samselikoff Thoughts?

I'd rather couple to models here. I think
Model.extend({
  author: belongsTo('user')
})

Factory.extend({
  author: association('user')
})

breaks the mental model for factories too much - author is a user, thats all it ever can be, so you shouldn't have to declare this type. I think factories should be thought of as corresponding to model attributes and relationships, and Mirage's flexibility in other areas has at times caused confusion about how the pieces should fit together.
There's a possibility we'll want association to take an arglist of traits, i.e. author: association('admin'). For now folks can just do this using afterCreate.
Also, if it comes up, we could always add a factory helper which does what your current version of association does.
So if you could rebase & introspect factory type based on the named attr, this should be good to merge! Thank you so much for your work and patience, let me know if you have any more thoughts.

Ok, if that's the clear intention then sure thing, I'll make it dependent on models, expect some new stuff today or tomorrow :).
Btw. it's already possible to pass the list of traits and overrides to association helper ;)

Btw. it's already possible to pass the list of traits and overrides to association helper ;)

you rule. 👊

@samselikoff Got some great news here, just check the code, it's pure magic now with models' introspection for getting some data about association :D
Can't wait to use it in some apps 💪

This is beyond the scope of this PR, but I think server could use some refactoring here, there's just too many implementation details and some stuff like building, creating etc. could just be delegated to some separate objects, how does it sound?

Definitely server can use refactoring, let's break it down so we can do it in small steps.
Is this ready?

Yeah, association helper is ready.
Server refactoring is for sure something for another PR, I guess I could give it a try this week.

💥
Thanks for all your work on this dude!

Awesome, some docs might be useful here, coming soon ;).


Admin Panel: Sort lecture selection dropdown alphabetically.

Affects file: /viewexamprotocol.php
In the detailed view of a protocol, the lectures of the "Assigned to Lectures" selection menu aren't sorted alphabetically.
One could use the same function as in upload.php or extract this function into a dao/system class.

Fixed in db0a2e95ceb4487853eb6943ea035ca993a5796c and removed side effects (better fix) in 55ca68854b2ca604205b8f7027b85a7950f7adee.


[feat] API to clear webview-managed data

Describe the problem
My application uses cookies/localStorage on the javascript side for various purposes.
I don't see a clear way to clear all the stuff stored by the Webview engine. I could have the javascript side clear these, but there are things that this side can't clear like disk cache, etc
Describe the solution you'd like
I want to put a native button like 'Logout' that clears all this data.
An API on app/app_handle that clears this data might make sense. Maybe it needs to be part of exit or relaunch?
Alternatives considered
I considered manually deleting some of the path_resolver() directories, but directories like /Users/pttamkin/Library/HTTPStorage/{pkg} and /Users/pttamkin/Library/WebKit/{pkg} aren't captured here. Also not sure I can delete these while my app is running?
Additional context
No response

I have this requirement too, for example user may want to switch to user another user to login to my app, and the authentication is done by using webview and authenticated data is stored in the cookie.
It seems we can do this by remove some data in app dir?

It seems we can do this by remove some data in app dir?

Yeah you could, but at least on Windows this should only reliable work when there is no webview open, as far as i know at least.
Anyway, in contrast to last time we talked about this API all webviews should now have built-in ways to clear the data so it should be possible now for us to implement this :)

Glad to hear that, it seems the javascript context can't be accessed directly from the tauri WebviewWindow object, if the API is not implemented now, do you know there is some way we can inject a tiny javascript to the webview to do that ? can initialization_script achieve that?
I do not know much above web programming, if there is an API to be released, I can delay a feature depend on this and implement when the API is released, thanks a lot.

Glad to hear that, it seems the javascript context can't be accessed directly from the tauri WebviewWindow object, if the API is not implemented now, do you know there is some way we can inject a tiny javascript to the webview to do that ? can initialization_script achieve that?

The API we're talking about here would need to be implemented in Rust (via the webview bindings) so we could add an api for it on the WebviewWindow object too (unless there are security concerns i don't have in mind right now)

/upstream tauri-apps/wry

Most likely you need to find the paths or folders where the files are stored, check different options for deleting them,
manually or by code, delete them in parts, etc.
Option 1: Deleting cache path, C:\Users\<username>\AppData\Roaming\<appname>\Cache, directly:
Option 2: which also clears the same C:\Users\<username>\AppData\Roaming\<appname>\Cache directory

You can also use native Rust code, which has access to the file system and deletes files and folders.
Based on the general description, mostly problems arise because You reference or use the cache while the program is running.

any updates on this?

hello??

Hi 👋


About Partial Zip

Hi!
Thank you for the great work! May I ask how to run the experiments for partial zip? Thanks so much!
Cheers,

Hi,
I'm so sorry for the lateness of response. I kept missing to get back to you. I really apologize.
Absolutely. Partial zipping involves specifying a node to "stop" zipping at, labeled "stop_at" in our repository. For instance, you can run a partial zipping experiment by replacing "21" with another number on line 100 of "/non_imnet_evaluation_scripts/zipit_concept_merging.py":
        {'stop_node': 21, 'params':{'a': .0001, 'b': .075}},

Here, the "stop_node" will set 21 to be the value of the 'stop_at" argument in line 70 of the same script.
For our ResNet models, you can run a partial zipping experiment by stopping at node 21 (i.e. zipping until layer 7/20), 42 (layer 13/20), 63 (layer 19/20), or None (full merge).
More generally however, you can run a partial zip operation by specifying the stop_at to be any node labeled with "PREFIX" or "POSTFIX" in the model graph, such that all computational flow up to that node goes through it (i.e., it does not lie on a residual branch). For ResNet these are exactly the nodes 21, 42, and 63 (can be seen by looking at the graph obtained by running the "graphs/resnet_graph.py" script).
Hope this helps - so sorry again for such a late response!
Please let me know if you have any more questions, and feel free to email me as well! I will respond significantly more promptly.

Hi @gstoica27
Thank you for your incredibly comprehensive and helpful responses! I deeply appreciate it. Also, thanks again for the fantastic work!
Cheers,
Yongcheng


Fix edit pins, fixes #34

Have you checked if this doesn't break the image upload? Kinda looks like the way we make a post request either breaks #34 or #47 (https://github.com/dirkgroenen/Pinterest-API-PHP/commit/17a2df0f84f8e22314df72873242bee60fa2edc9)

So there is a bug with configuration of pinterest's akamai cdn not handling Expect: Continue headers correctly.
When we're adding post parameters as array, curl automatically adds Content-Type: multipart/form-data and sends Expect: Continue header before sending actual payload. There is a chance that api.pinterest.com is resolved to Akamai CDN (other option is Fastly, which is fine). Akamai, probably misconfigured, responds with 100 Continue header, but looks like not proxy Expect header to upstream pinterest backend. Pinterest backend receives request with only headers (no body) and treats that as normal request and returns some data (like old pin content). This is received by curl. However, at that moment the body of request hits Akamai proxy, which assumes it is new request (keep alive) with malformed structure - no headers, etc. and responds back with 400 BAD_REQUEST.
You can see this issue yourself with command-line curl:

curl -X PATCH -H 'Authorization: Bearer token-XXX' -H 'Host: api.pinterest.com' --insecure 'https://<IP_ADDRESS>/v1/pins/XXXXXXXXXX4162698904/' -F "note=new_note_test2" --trace-ascii out.txt -v

note hardcoded Akamai IP in the url.
Curl in that case shows warning that response body contains extra data which exceeds Content-lenght expected from response headers:

Excess found in a non pipelined read: excess = 66, size = 267, maxdownload = 267, bytecount = 0

This is 400 response from Akamai. You can see it in out.txt at the very end.
So workaround for that is to force curl not to send Expect header at all. That seems to be working fine in all cases.
Hope that explains things.

Any updates here?

I'm sorry but it looks like I've fully missed these lasts comments and potential fix. @VShox kudos for your fix and for taking the effort to investigate this. I'll merge in the hope it fixes the issue, if not feel free to post a comment in here.

(Lovely how I just pressed the wrong button twice, as usual) :facepunch:


Investigate how to test Netlify Edge Functions

Reason/Context
We do have a Netlify Edge Function already in https://github.com/asyncapi/website/tree/master/netlify/edge-functions.
But there are no tests yet. We need to investigate how we can test that, since the runtime is Deno and there are some additions Netlify does on their runtime.

 I'm working on a Netlify function for the newsletter subscriptions so it will fit right in.

I can pick this up. I'm working on a Netlify function for the newsletter subscriptions so it will fit right in.

Awesome! Please feel free to ask any questions or request for help!

Hey @Shurtu-gal are you working on this issue? If not, I would like to work.

Yep still working. Would be glad to receive your opinions too.
Btw @smoya tried the method, turns out it only works for functions not edge ones as they run on Deno runtime.
Have posted this in forum too. I will try to find some new avenues also.

Yep still working. Would be glad to receive your opinions too. Btw @smoya tried the method, turns out it only works for functions not edge ones as they run on Deno runtime.
Have posted this in forum too. I will try to find some new avenues also.

Yeah they run in Deno, I can confirm this to you. But can't we just run the tests on Deno?

Yeah, cool will sift through the solutions and would see if can get a Deno test framework up and running. The puppeteer one can be the backup solution if nothing works.

Yeah, cool will sift through the solutions and would see if can get a Deno test framework up and running. The puppeteer one can be the backup solution if nothing works.

Anyway, I think we don't even need deno for that 🤔
Maybe we can just mock the Request and the Context params in a unit test. For the Request, it is an standard Fetch API Request object, and the context could be mocked based on Netlify docs: https://docs.netlify.com/edge-functions/api/
Does it make sense?

However, this can only work with the deployed Netlify link right?

Maybe we can just mock the Request and the Context params in a unit test.

However, this can only work with the deployed Netlify link right?

If we mock the Fetch API, no real request will be done.
Meaning we could just add some expectations on the calls the code does, like this call to fetch() or rather this call to context.next() and match request headers, URL, etc.

Done the work, you can check here :-
The sample PR :- https://github.com/ash17290/website/pull/1
Workflow in action :- https://github.com/ash17290/website/actions/workflows/netlify-edge-functions-test.yml
If its fine I will make a PR @smoya

Done the work, you can check here :-
The sample PR :- https://github.com/ash17290/website/pull/1
Workflow in action :- https://github.com/ash17290/website/actions/workflows/netlify-edge-functions-test.yml
If its fine I will make a PR @smoya

Nice! I will check asap. Most probably tomorrow. Hope that works to you.


Time-zone awareness for pt #1025

API change: time parameters are now expected to be ISO-8601 strings, like this: 2013-05-30T23:38:23.085Z, to be parsed into a java.time.Instant.

Note that this is not so clear a decision. When you query bahn.de or (especially) lufthansa.com, times always mean local times relative to where the trip starts, and how they would appear in the schedule.
However, we are aiming at a multi-modal "ground" route planner, so we resolve physics-time to schedule-time when we enter the pt-subgraph, and the rest of the world doesn't know about schedule-time.
Helping the user with finding out which time he/she probably means when doing a query is left for another layer.

When we do another query type - an explicit station-to-station query -, we can add an option to search by local time, because stations have an (authoritative) local time from gtfs.

BTW: why los angeles as timezone?

Well, because the gtfs-test-agency is there.


set working directory to the working directory of the target process

regarding the doc i thought this would be cool ... and it actually makes sens for me.

After revisiting this... I think it's a great idea, and it looks like --wd has been around for a while. So if you'll rebase it, I'll merge it!


KOGITO-3211 - SW update to latest spec and runtime updates

Signed-off-by: Tihomir Surdilovic<EMAIL_ADDRESS>Many thanks for submitting your Pull Request :heart:!
@ricardozanini
This PR aligns the kogito SW parsing with the latest of the specification
Updated parsing and generation code to work with the latest Switch state
Updated all examples and tests so the json and yaml use the latest spec definitions
I will do the associated PR for kogito-examples tomorrow.

Jenkins retest this please

@ricardozanini added the missing test for switch state where conditions define end of workflow.

Jenkins retest please

rebased
will do some more updates in additional pushes

Many thanks @tsurdilo please let me know when this is ready for review. So we can get back to the example.

@evacchi @cristianonicolai could you guys please take a second look? I believe we addressed your concerns.
It's worth mentioning that we will remove most of this code in favor of the sdk-java very soon.

Error not related:
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.9.1:yarn (yarn test) on project kogito-apps-ui-packages: Failed to run task: 'yarn run test --registry=https://repository.engineering.redhat.com/nexus/repository/registry.npmjs.org/' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]

Jenkins test please

jenkins test this please


feat(Button)!: use Typography variants

BREAKING CHANGE: rename variants

The only issue I found is that the as option in the storybook controls it's not working, but I've checked and it was already not working before, so no regression on this one.


Throw an error on undefined who

See #5

Coverage increased (+0.01%) to 98.5% when pulling c722d9a018a2317c2639fe9513b897e9c78811dc on MCProHosting:throw-on-undefined into 2d95676514de4a1851bd1d1dff05121d6ad6dcae on unshiftio:master.

Awesome thanks a lot for the pull request and the included test!

No problem!


when using i18n in combination with a referencing selectClass you get a JSON instead of a readable string

i.e. newsadmin:

create category with two languages
create article and select category
in CRUD list view you'll see JSON instead of a title in the default language('de')

this issue also effects frontend views when echoing the i18n vars

@martinpetrasch The frontend should not be affected if you are NOT using asArray().


Chart.yaml generated doesn't match template

It appears that the generated Chart.yaml is coming from helm, not from your template. If I create a foo chart, then the contents of Chart.yaml are
apiVersion: v1
description: A Helm chart for Kubernetes
name: foo
version: 0.1.0

The remainder of your templates though are included.
$ ls foo/
charts/            .helmignore        PERSISTENCE.md     requirements.yaml  values.yaml
Chart.yaml         Jenkinsfile        README.md          templates/
$ ls foo/templates/
certificate.yaml  daemonset.yaml   _helpers.tpl  NOTES.txt  role-binding.yaml  secret.yaml           service.yaml
configmap.yaml    deployment.yaml  job.yaml      pvc.yaml   role.yaml          service-account.yaml

Indeed. I haven't found a way to get around this limitation -- I usually just copy and paste it in. Perhaps we can open a bug in the upstream helm project?

Sounds like a good idea. There is no documentation that I could find on the
starter scaffolding feature. Yours and one other project are all I could
find as a sample to base my own efforts off of.
On Tue, Dec 5, 2017 at 7:24 AM, Andrew Howden<EMAIL_ADDRESS>wrote:

Indeed. I haven't found a way to get around this limitation -- I usually
just copy and paste it in. Perhaps we can open a bug in the upstream helm
project?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sitewards/helm-chart/issues/21#issuecomment-349318689,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbPrHiMUS7-Kjp6yhuExVUkt5saB-2gks5s9VICgaJpZM4Q1XtM
.

--
Ben Mathews


Does not start on spigot 1.20.4

Full log:
[16:34:15] [Server thread/INFO]: [SkipNight] Enabling SkipNight v1.8.0
[16:34:16] [Server thread/ERROR]: Error occurred while enabling SkipNight v1.8.0 (Is it up to date?)
net.mattlabs.skipnight.cloud.bukkit.BukkitCommandManager$BrigadierFailureException: Could not initialize Brigadier mappings. Reason: version too high ()
at net.mattlabs.skipnight.cloud.bukkit.BukkitCommandManager.registerBrigadier(BukkitCommandManager.java:346) ~[?:?]
at net.mattlabs.skipnight.cloud.paper.PaperCommandManager.registerBrigadier(PaperCommandManager.java:134) ~[?:?]
at net.mattlabs.skipnight.SkipNight.onEnable(SkipNight.java:112) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:266) ~[spigot-api-1.20.4-R0.1-SNAPSHOT.jar:?]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:342) ~[spigot-api-1.20.4-R0.1-SNAPSHOT.jar:?]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:480) ~[spigot-api-1.20.4-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.v1_20_R3.CraftServer.enablePlugin(CraftServer.java:541) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:4054-Spigot-e9ec548-619936d]
at org.bukkit.craftbukkit.v1_20_R3.CraftServer.enablePlugins(CraftServer.java:455) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:4054-Spigot-e9ec548-619936d]
at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:623) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:4054-Spigot-e9ec548-619936d]
at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:409) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:4054-Spigot-e9ec548-619936d]
at net.minecraft.server.dedicated.DedicatedServer.e(DedicatedServer.java:250) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:4054-Spigot-e9ec548-619936d]
at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1000) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:4054-Spigot-e9ec548-619936d]
at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:304) ~[spigot-1.20.4-R0.1-SNAPSHOT.jar:4054-Spigot-e9ec548-619936d]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
and then after the server had started the command does not load.

What version of Minecraft server are you running? Also is it Paper, Spigot, etc?

What version of Minecraft server are you running? Also is it Paper, Spigot, etc?

Spigot, 1.20.4.

This issue seems to be related to Cloud which is also being tracked in #38. Please check there for updates regarding Cloud v2.


Dynamic endpoints service subscription

Currently, the Discovery service needs to hard-code the API endpoints from the microservices that might subscribe to it.
Since this is not too user-friendly and doesn't decouple the Discovery from the microservice, I think it might be good to dynamicly publish the available endpoints at subscribe time.

We've already talked about this and thought it is a nice feature to have. However, since we just need a Discovery for basic microservice testing now, we will not work on this for the time being.

[ ] #31
[ ] #45