Missing Project Euler Challenges

Describe the bug
There are 30 missing challenges in the Project Euler section both locally and on freecodecamp.rocks:
[8, 9, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99]
I've tried running npm run clean, npm install, and reseeding the database, but the pages for the above challenges aren't built during npm run develop. The challenges aren't shown on the challenge map, and going directly to the URL (http://localhost:8000/learn/coding-interview-prep/project-euler/problem-8-largest-product-in-a-series) shows a 404 page.
One thing I noticed is that hot reloading a challenge causes the page to be built. Even without making any changes in the editor, if I save Problem 8, the challenge will be shown on the on the challenge map and you can navigate to the page. However, if I restart the server, the challenges will be missing until they're hot reloaded again.
The challenge IDs all seems to be unique, and match the ones listed in the Project Euler meta.json file.
Do you know what might be going on here @Bouncey, @raisedadead, and @ValeraS?

It seems to be happening because the curriculum stops being built once the last file has been read, rather than the last challenge inserted into the curriculum.
I'll dig a little deep and see if I can fix it.

@ojeytonwilliams, awesome! Thank you for looking into this.


Remove NRT decref in generators

As titled. Closes #8800

Closing as the hypothesis this was testing seems to have been disproved by the negative side-effects of removing this decref.


Add Dockerfile

installing node/npm can be avoided for those using Docker

Good idea. I'm not that confident in using Docker so any help would be very appreciated.

PR #45

You can set up some hooks to build automatically and publish on dockerhub.  Then people wouldn't need to build the image themselves.
https://docs.docker.com/docker-hub/builds/#create-an-automated-build

Resolved with #45


k8s拉取tis:4.0.1镜像失败

k8s部署tis-4.0.1时，出现镜像拉取报错，将配置中版本修改为4.0.0可正常拉取，以下时配置中拉取镜像url，和git中的tis-console配置文件一致。
 volumeMounts:
            - name: tis-config-volume
              mountPath: /opt/app/tis-uber/web-start/conf/tis-web-config/
            - name: tis-console-pvc
              mountPath: "/opt/data"
          image: registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1

不是，直接用kubectl apply -f ./tis-console.yaml命令执行的，docker pull可以成功。将版本换为tis-console:4.0.0也可以成功，4.0.1就不行。详细报错是这样：
  Normal   Scheduled         19m                   default-scheduler  Successfully assigned default/tis-console-pg8fc to k8s-node1   Warning  Failed            19m                   kubelet            Failed to pull image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to pull and unpack image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to resolve reference "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to do request: Head "https://registry.cn-hangzhou.aliyuncs.com/v2/tis/tis-console/manifests/4.0.1": dial tcp: lookup registry.cn-hangzhou.aliyuncs.com on [::1]:53: read udp [::1]:57102->[::1]:53: read: connection refused   Warning  Failed            19m                   kubelet            Failed to pull image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to pull and unpack image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to resolve reference "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to do request: Head "https://registry.cn-hangzhou.aliyuncs.com/v2/tis/tis-console/manifests/4.0.1": dial tcp: lookup registry.cn-hangzhou.aliyuncs.com on [::1]:53: read udp [::1]:58572->[::1]:53: read: connection refused   Warning  Failed            19m                   kubelet            Failed to pull image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to pull and unpack image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to resolve reference "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to do request: Head "https://registry.cn-hangzhou.aliyuncs.com/v2/tis/tis-console/manifests/4.0.1": dial tcp: lookup registry.cn-hangzhou.aliyuncs.com on [::1]:53: read udp [::1]:39716->[::1]:53: read: connection refused   Normal   Pulling           18m (x4 over 19m)     kubelet            Pulling image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1"   Warning  Failed            18m (x4 over 19m)     kubelet            Error: ErrImagePull   Warning  Failed            18m                   kubelet            Failed to pull image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to pull and unpack image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to resolve reference "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to do request: Head "https://registry.cn-hangzhou.aliyuncs.com/v2/tis/tis-console/manifests/4.0.1": dial tcp: lookup registry.cn-hangzhou.aliyuncs.com on [::1]:53: read udp [::1]:33787->[::1]:53: read: connection refused   Warning  Failed            18m (x6 over 19m)     kubelet            Error: ImagePullBackOff   Normal   BackOff           4m46s (x64 over 19m)  kubelet            Back-off pulling image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1"

failed to pull and unpack image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to resolve reference "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to do request: Head "https://registry.cn-hangzhou.aliyuncs.com/v2/tis/tis-console/manifests/4.0.1": dial tcp: lookup registry.cn-hangzhou.aliyuncs.com on [::1]:53: read udp [::1]:57102->[::1]:53: read: connection refused
Warning  Failed            19m                   kubelet            Failed to pull image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to pull and unpack image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to resolve reference "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to do request: Head "https://registry.cn-hangzhou.aliyuncs.com/v2/tis/tis-console/manifests/4.0.1": dial tcp: lookup registry.cn-hangzhou.aliyuncs.com on [::1]:53: read udp [::1]:58572->[::1]:53: read: connection refused
Warning  Failed            19m                   kubelet            Failed to pull image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to pull and unpack image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to resolve reference "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to do request: Head "https://registry.cn-hangzhou.aliyuncs.com/v2/tis/tis-console/manifests/4.0.1": dial tcp: lookup registry.cn-hangzhou.aliyuncs.com on [::1]:53: read udp [::1]:39716->[::1]:53: read: connection refused
Normal   Pulling           18m (x4 over 19m)     kubelet            Pulling image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1"
Warning  Failed            18m (x4 over 19m)     kubelet            Error: ErrImagePull
Warning  Failed            18m                   kubelet            Failed to pull image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to pull and unpack image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to resolve reference "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1": failed to do request: Head "https://registry.cn-hangzhou.aliyuncs.com/v2/tis/tis-console/manifests/4.0.1": dial tcp: lookup registry.cn-hangzhou.aliyuncs.com on [::1]:53: read udp [::1]:33787->[::1]:53: read: connection refused
Warning  Failed            18m (x6 over 19m)     kubelet            Error: ImagePullBackOff
Normal   BackOff           4m46s (x64 over 19m)  kubelet            Back-off pulling image "registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1"

我估计会不会是网络的问题，你可以试试先把registry.cn-hangzhou.aliyuncs.com/tis/tis-console:4.0.1 ，是否可以如下：

通过docker pull 到本地，
然后放到你自己的镜像仓库中，
再改一下tis-console.yaml 配置中的镜像路径，改成你的仓库地址，
最后再执行一下试试

好的，也只有先这样了，谢谢大佬

好的，也只有先这样了，谢谢大佬
你的k8s 是在什么环境中的？自建的？

好的，也只有先这样了，谢谢大佬

你的k8s 是在什么环境中的？自建的？

是的，自建的本地k8s环境


Avoid calling backtrace over $evm to prevent DRb-level mutex locks

Moves dynamic method building into DrbRemoteInvoker since it isn't
needed at all in MiqAeService.  Once in DrbRemoteInvoker, we can use
the dynamic preamble to inform the generated ruby method body of things
like the number of preamble lines and the name of the method for
backtrace filtering purposes.
@mkanoor Please review
Paired with @jrafanie on this one, which he originally noticed in #13104 .

Found a bug in the actual line count...need to write a test for it :)

In review with @mkanoor we found that nested methods will only have the first method's name because of where I put the method_name hook.  So marking as WIP til I fix that.

@jrafanie @mkanoor Updated with a ton of specs.

Merging, @mkanoor gave verbal approval to this change yesterday 👍

@mkanoor @Fryguy should this go back to euwe?  I don't think this is happening there but what do you think?

👍
@jrafanie lets wait a while and make sure QA doesn't find anything and then we can back port it


UInt64 cannot be negative

In ImageCache.swift
                let bytesToPurge = self.currentMemoryUsage - self.preferredMemoryUsageAfterPurge

This sentence may EXC_BREAKPOINT, because self.currentMemoryUsage may less then self.preferredMemoryUsageAfterPurge.
and bytesToPruge is UInt64 type inference by Swift.

Thanks for reporting @frogcjn!
I would say that if you end up seeing this error, then you have set up the memoryCapacity and the preferredMemoryUsageAfterPurge parameters incorrectly. To help guard against this moving forward, I've added a precondition to the ImageCache initializer in 0095691b to prevent you from accidentally making this mistake.
Thanks again. 🍻


Instructions for approvers - where do they appear?

In the Approvals sidebar there is a text area named "Instructions for approvers (optional)".
This is described as an "optional message" in the documentation, but it is not clear to me where this message appears. I would expect it to be in the e-mail sent to approvers, but it is not (as far as I can see).
Thanks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 624da995-5b05-bb05-0afc-c42a1ff5ab87
Version Independent ID: 3cf8daeb-8d99-845e-dfd8-d0be5f65182c
Content: Pipeline deployment approvals - Azure Pipelines
Content Source: docs/pipelines/process/approvals.md
Service: azure-devops-pipelines
Sub-service: azure-devops-pipelines-process
GitHub Login: @shashban
Microsoft Alias: shashban

@edwiles -- Ed, thank you for your feedback.  I am also unsure where those messages appear, that is, what happens during this pause:

When you run a pipeline, the execution of that run pauses before entering a stage that uses the environment. Users configured as approvers must review and approve or reject the deployment.

Please consider these resources:

Azure DevOps Services
Azure DevOps on Stack Overflow

@shashban -- Shashank, please look into this issue.

@WilliamAntonRohm Here's an example e-mail that is sent to the approvers during the pause you mention. The question I have is where does the text in the "instructions for approvers" box go, because it does not appear in this e-mail.

@edwiles Thank you for your feedback! The instructions are displayed in the UI prompt window, as shown in the screenshot below. I'll be making updates to this section shortly.


Feature/mm 37821 remove global header option

Summary
this PR aims to remove the "Global Header"-option from the account settings modal, since in the future it will be set from a feature flag instead.
Ticket Link
MM-37821
Release Note
NONE

Also just to correct the description:

since in the future it will be set from a feature flag instead.

It's already controlled by a feature flag today.

Haha. Sry! I should have written "since in the future it will be set solely from a feature flag instead."

@michelengelen @andrewbrown00 I removed myself as the reviewer on this PR as I wont be around next week.. for the life of me I cant get a test server up and running to review this one.

@michelengelen are you able to get the test server working on this PR? It shows up as a white screen for me.

@andrewbrown00 it wont spin up for me as well. I asked the SRE team for support in another ticket

@michelengelen looks like the test server was built successfully, but I just see a white screen when hitting the URL. Any thoughts?

I am sorry @andrewbrown00 , but i do not know what is happening here. the info from the console could mean the server is not starting up correctly, since the APIs are not reachable. @spirosoik is there currently a known issue that could be the cause for this?

I just noticed that the running server was initiated with CWS ... I will try to start one without it, just to be sure

@andrewbrown00 it is the same for a server without CWS ... I think we might need someone from the SRE team here to solve the issue.

Thanks for the update @michelengelen, let me know if the SRE team is able to resolve the issue and I'll review 🙂

Thanks for the update @michelengelen, let me know if the SRE team is able to resolve the issue and I'll review 🙂

Interestingly the PR #8571 is working just fine.

@michelengelen there's no any known issue but I will have a look to see what's going on.

@michelengelen a rebase and get latest master can help as it will get latest server changes too which may fix any issue

@michelengelen a rebase and get latest master can help as it will get latest server changes too which may fix any issue

I did merge the current master before trying to spin up a server, so that clearly did not help.

let me check @michelengelen

@michelengelen just retested everything seems ok

@spirosoik it is running, but we hit a white screen, as seen in the screenshots:

@michelengelen are we sure that it's not related with any change in app? seems that the endpoints get 401 and doesn't redirect back to login screen to me after a session expiration. I have the same but in the morning when I logged in was ok

@spirosoik could it be that it works for a couple of minutes and then somehow breaks after the session expires? I will try to set a server up and check immediately after it's gone up, ok?

@spirosoik It does not work with CWS and normal instances. Every time I want to view it i just get a white screen with the beforementioned console errors. I will try my last resort on this: creating a new branch with a new PR and see if it works there, ok?

@michelengelen give me a few minutes to have a look

@michelengelen I cross-checked the logs in server for this installation and I cannot see any error except
{"timestamp":"2021-08-18 19:25:08.383 Z","level":"info","msg":"\u001b[31merror\u001b[0m [2021-08-18 19:25:08.382 Z] Unable to clean up the sessions          \u001b[31merror\u001b[0m=\"no update allowed from focalboard, update it using mattermost\"","plugin_id":"focalboard","source":"plugin_stdout"}

I'm still seeing a white screen and no UI 😞

Closing in favor of #8645 ... spinwicks are working on that PR


Added test case for #1333 - uniqueKeys produces duplicate values with…

… virtual index

Completed in #1345


Add contributing guidelines

Contributing guidelines will help us keep the codebase clean and understandable for everyone.
This should also include a coding style guide.

Already added in master.


[material-ui] Blog template has broken image links

Steps to reproduce
Link to live example: https://mui.com/material-ui/getting-started/templates/blog/
Steps:

Go to https://mui.com/material-ui/getting-started/templates/blog/
Image is not displayed

Context
Unsplash random API is outdated, so we need to fix the images on blog themplate.

  Output from `npx @mui/envinfo` goes here.

Search keywords: material-ui, blog

@sanjay-mali @navedqb I'll leave this issue open since we still need to fix the broken images on the master branch. Let me know if one of you would like to open a PR for it, and I can assign it to you :)

Hi @navedqb, I would like to take on this issue and open a pull request to fix the broken images on the master branch. Please assign the issue to me, and I will start working on it immediately.Thank you!


Not Entirely Sure[BUG]

My friend's server receives this error when trying to boot up with dramatic doors.
@Inject(@At("INVOKE")) Shift.BY=2 on dramaticdoors.micins.json:OpenDoorsTaskMixin from mod dramaticdoors: :handler$bhm000$injectStartP1 exceeds the maxium allowed value: 0. Increase the value of maxShiftBy to suppress this warning

I should look into it. It doesn't crash the server, does it?

Turns out it wasn't anything mod related, it was on their side, apologies for this.


Open Realm when user first logs in so that data is prefetched

The Realm Objects will then be cached on the device so that subsequent queries are fast

 iOS - Open Realm when user first logs in so that data is prefetched

Closing this issue as it doesn't improve performance:

Hi Jason, I just wanted to check my observations on the effectiveness of pre-querying Realm. It’s appearing that all of the data is being synced to the app as soon as the user logs in (presumably for all documents that match the sync permissions set up in the Realm app for the Realm user). If I wait a while (after logging in) to open the first view that queries realm for the Objects then it finds and displays them immediately – if I don’t wait then the list is empty (here we’re not currently taking advantage of live queries as we straight away convert the resulting list of Objects to an array of View Models and so we won’t see any reports as they sync until the view is refreshed). If this is correct, then there’s no advantage in running a “pre-fetch” query, as that’s effectively done just by logging in?

jason.flax:  yes, there is no real advantage on running a pre-fetch query, since we start syncing on login


Fixed Contact Us Form Submit Button UI Breaking in Mobile View

Related Issue
[BUG]: Contact Us Form Submit Button UI Breaking in Mobile View #373
Description
This pull request addresses the issue of the submit button in the "Contact Us" form, where the button's content extends outside its boundaries in mobile view. The changes include updates to the button's styling to ensure proper containment of the text, maintaining a consistent appearance across various screen sizes.
Type of PR

[x] Bug fix : #373

Screenshots / Videos (if applicable)

Checklist:

[X] I have performed a self-review of my code
[X] I have read and followed the Contribution Guidelines.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

Additional Context
The updated styling ensures that the submit button maintains a professional appearance across different screen sizes, including mobile view. This fix helps improve the user experience when submitting inquiries via the Contact Us form.

Hi @skmirajulislam , I have raised another PR for the issue, kindly check. #440


Remove unnecessary adding "MAY" for the "multipleOr" expectation

Remove and regenerate tests. It should regenerate only metadata without tests

I should regerenerate tests on new data


ERROR:: connect account > payouts and transfer permissions not visible

no need to show to user for now


Can't submit token

Hey i've noticed an issue while trying to submit my token, it says ''Something's not right, please check your authtoken and try again''. I've done the ngrok authtoken and reseted the token various times while redoing the ngrok authtoken but it still keep displaying the same message. Anything you could recommend?
Maybe the token checker is still disabled?

I should have posted in the original release lmfao

If you are able to run the program and get it to work even with the popup message let me know. Please try to click one of the buttons and see if the control panel opens. I will try to release a first version of the new lightning program within 2 weeks.

@xicst1 I have a working prototype of the new version of lightning. If you would like to try it let me now.


Inner reads unexpected EOF

Hi there, I have some questions about this crate.

By reading the future code and the fact that my handler throws an error, because it reached unexpected EOF, it seems that this layer completely "empties" the request body, meaning any inner service cannot simply read the request body.
I am therefore confused, whether you have gotten this layer to work properly with a useful handler?
Next, when looking at the simple example with my mediocre axum knowledge, it seems that the FromRequest for Event wouldn't be used, since Event is wrapped in the JSON extractor. Do I misunderstand something there?

Thanks for developing this crate, it would be exactly what I need 😄

Hi @mTsBucy1,
Yes, you're completely right—I need to add a disclaimer to the README that this crate is currently not functioning as intended. The body gets emptied and not passed on to the inner handler.
I have not had time to come back and fix the issue yet unfortunately, and honestly wasn't expecting anyone to come across the crate and use it. I'll add a note to the README now and yank any crates.io versions until I have the time to come back and refactor.
Sorry for any confusion!

Alright, I've yanked the versions from crates.io.
@mTsBucy1, if you're interested in getting this working, the logic that needs to get updated is in this section: https://github.com/SebRollen/tower-github-webhook/blob/main/src/future.rs#L92-L120
Two ways I could think of fixing this issue:

Update the trait bounds for ReqBody to be Clone, and storing the inner body somewhere to pass on to the inner service
Reading the bytes from the body into some buffer stored inside ValidateGitHubWebhookFuture and rebuilding the body from that buffer before passing it to the inner service

Okay, that makes sense.
So found an example from axum here: https://github.com/tokio-rs/axum/blob/main/examples/consume-body-in-extractor-or-middleware/src/main.rs which talks about this problem. Their solution is essentially to collect into bytes first, which would be fairly straight forward to implement. However, your decision to implement your own future makes it a bit more complex.
I'm going to try this, but I'll also time limit myself, to not get sucked into a huge rabbit hole xD

Thanks for the link, will check that out.
If you're just looking for a quick solution for your use-case, I've used this middleware function before to do the same thing that this crate is attempting to do:
In middleware.rs
use crate::error::Error;
use crate::AppState;
use axum::{extract::State, http::Request, middleware::Next, response::Response};
use hmac::{Hmac, Mac};
use hyper::body::to_bytes;
use sha2::Sha256;

pub async fn verify_github_webhook(
    State(state): State<AppState>,
    request: Request<hyper::Body>,
    next: Next<hyper::Body>,
) -> Response {
    let (parts, body) = request.into_parts();
    let mut hmac =
        Hmac::<Sha256>::new_from_slice(state.github_settings().webhook_secret.as_bytes())
            .expect("HMAC can take key of any size");
    let signature = match parts.headers.get("x-hub-signature-256") {
        Some(sig) => {
            let sig = sig
                .as_bytes()
                .splitn(2, |x| x == &b'=')
                .nth(1)
                .expect("Unexpected format for GitHub signature");
            hex::decode(sig).expect("Unexpected format for GitHub signature")
        }
        None => return Error::unauthorized(),
    };
    let message = match to_bytes(body).await {
        Ok(bytes) => bytes,
        Err(_) => return Error::unauthorized(),
    };
    hmac.update(&message);
    if hmac.verify_slice(&signature).is_ok() {
        tracing::trace!("GitHub webhook verified");
        let request = Request::from_parts(parts, hyper::Body::from(message));
        next.run(request).await
    } else {
        tracing::warn!("GitHub webhook failed verification");
        Error::unauthorized()
    }
}

and then in my axum router:
Router::new()
        .route(
            "/events",
            post(handle_event).route_layer(middleware::from_fn_with_state(
                state,
                crate::middleware::verify_github_webhook,
            )),
        )

@mTsBucy1 had some time on a flight yesterday and was able to get this working, including fixing the example (you're right that the JSON extractor was not needed).
Thanks again for the report!


DEX-835 Node balances stream

Notable changes:

A new version of Matcher is not compatible with the previous! It was unreal to save compatibility;
Matcher requires two extensions on NODE: its own and balance updates;
Matcher collects balances from the stream on the server side, not on the extension;
NODE 1.2.14;

Config:

Added waves.dex.blockchain-updates-grpc to tune connection to Blockchain Updates Extension;

WebSockets:

Added a 100 millisecond delay before a connection closes to send the reason;

Matcher HTTP API: added "print" API method.
Added CombinedWavesBlockchainClient to fuse Blockchain Updates and Matcher extensions.
SpendableBalancesActor now only routes messages between balance source and address actors. It will be removed in the future. CombinedWavesBlockchainClient stores balances now.
Blockchain Updates Extension support in blockchainupdates packages:

Added BlockchainUpdatesClient, GrpcBlockchainEventsObserver;
Added BlockchainUpdatesStreamControl to have an ability to close or restart the strem, request a next event and etc;
Added Conversions for gRPC to domain conversions;
Added StatusTransitions, BlockchainStatus, StatusUpdate, WavesNodeEvent, WavesBlock, WavesBranch, WavesFork classes to update balances and fight forks and disconnects;
PessimisticPortfolios is moved from the Matcher Extension to the Matcher Server and totally reimplemented due to specifics of extensions;

Matcher Extension:

Added GetUtxEvents stream. The extension sends the whole state of UTX after a connection, then sends UtxAdded and UtxRemoved;
Added GetCurrentBlockInfo;
GetNodeAddress is removed, because we can determine the address using grpc-java classes;
GetRealTimeBalanceChanges is removed, because we receive these changes from the Blockchain Updates extension;
Added GetBalances to get separated regular balances and leases;
Classes are moved to the matcherext packages;
MatcherExtensionGrpcAsyncClient now calls to gRPC methods using the grpc-java function: channel.newCall to have an ability to tune a request and log the server where a response came from;

Build:

Packaging and creating artifacts changed to support two extensions (ExtensionPackaging, WavesNodeArtifactsPlugin, waves-ext/docker/dockerfile, etc);
quickCheckRaw now compiles all projects. root/compile didn't work for all aggregated modules;
sbt 1.4.3;
Added MatcherIOUtils.decompressTgz to decompress tgz archives.

Integration tests:

Better logs in containers;
When a test fails in a test suite, we do not log canceled tests;
We do not log calls of debug/print;
Better logging for exceptions;
Starting, failing and succeeded tests are printed via "print" method instead of container's shell to be more precise;
Stabilized tests suites: WsPingPongBaseSuite, TradersTestSuite;
New test suites: AutoCancelOrderTestSuite, BouncingBalancesTestSuite,
Added NoStackTraceCancelAfterFailure - use it instead of CancelAfterFailure to see less garbage in the logs;
Added to NodeApi: unconfirmedTransactionInfo, rollback, print;
Added a support of two extensions to toxics;
DexContainer: added a documentation, when to use api/asyncApi.

Updated a PR text. There are a lot of changes were made in DEX-956 :)


browser-stdout has an invalid license, which transitively makes mocha a problematic dependency

Prerequisites

[x] Checked that your issue hasn't already been filed by cross-referencing issues with the faq label

Description
mocha depends on the browser-stdout package, which is problematic, as it does not have proper licensing. It only mentions ICS in the package.json, but that's not satisfactory even by the license itself - see https://github.com/kumavis/browser-stdout/issues/3. The maintainer doesn't seem to be attentive to this problem - https://github.com/kumavis/browser-stdout/pull/4 This transitively makes mocha a problematic dependency as well.
Steps to Reproduce

Inspect the mocha dependency tree for incorrectly licensed packages. Every package should have a license name, full license text, and a copyright notice with a copyright holder.
Expected behavior: [What you expect to happen]
The mocha package depends only on packages with correct licensing.
Actual behavior: [What actually happens]
The browser-stdout package is in the dependency tree as a direct 1st level dependency, and it is not properly licensed. Just license name, but no full license text, no copyright notice with a copyright holder.
Reproduces how often: [What percentage of the time does it reproduce?]
100%
Versions
<EMAIL_ADDRESS>

@honzajavorek thanks for raising this issue. I'll follow up on this by friday if no one did until then.

@Bamieh Is there a way I can help?

@honzajavorek I reached out for Aaron on twitter. Hopefully he will be kind enough to give some time to merge the PR and solve this issue. Let's wait and see!

so sorry 😿
fixed in<EMAIL_ADDRESS>


Azure Eventhubs Sample Issue

Section Link

Result:

Reason:
The EventHubProducerClient client with the Interactive BrowserCredential can't create an instance of EventDataBatch.
@jongio for notification.

@JosueJoshua
Can you open up your browser's developer tools (typically accessed by pressing F12 in your browser) and check the console tab to see if an error is logged?
Did you replace the values in https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/eventhub/event-hubs/samples/browserSample/src/configuration.js with valid ones?

Hi @chradek , it's nothing in the console. And the values is valid.
When I click the send botton, it will pop up a new web page with id_token in its url, which wiil not be closed automatically.

@JosueJoshua

When I click the send botton, it will pop up a new web page with id_token in its url, which wiil not be closed automatically.

Are you referring to the login page here? If you look at the networking tab in your browser's dev tools, what errors are you getting from the requests?

@JosueJoshua

When I click the send botton, it will pop up a new web page with id_token in its url, which wiil not be closed automatically.

Are you referring to the login page here? If you look at the networking tab in your browser's dev tools, what errors are you getting from the requests?

@chradek
Yes, it's successful in login, then go to the reference page(localhost:8080, the content is the same as original page). One of the requests returned a status code of 101, as shown below:
Request URL: wss://my-eventhub-name.servicebus.windows.net/$servicebus/websocket
Request Method: GET
Status Code: 101 Switching Protocols
And others is all right.

@chradek
Yes, it's successful in login, then go to the reference page(localhost:8080, the content is the same as original page). One of the requests returned a status code of 101, as shown below:
Request URL: wss://my-eventhub-name.servicebus.windows.net/$servicebus/websocket
Request Method: GET
Status Code: 101 Switching Protocols
And others is all right.


find_column_type fix for snowflake dates

Updated find_column_type method to only map columns types to date if they contain data with valid Snowflake date formats
Added warehouse parameter to find_column_type method to differentiate column type mappings based on warehouse type (only affects dates)
Updated test and internal calls of find_column_type

Fixes #221

LGTM. Was thinking through the logic since it has been a while since I went through this stuff. Overall it looks good. thanks for updating the unit tests and adding in extras there.

Thanks for reviewing Faisal! Any idea how long the Whitesource checks tend to take? Can't merge until they are done.


data2vec: ValueError: Empty module name

I installed fairseq and soundfile, try the example codes at examples/data2vec/README.md,
python fairseq_cli/hydra_train.py -m --config-dir examples/data2vec/config/audio/pretraining --config-name base_librispeech task.data=./datas2/ common.user_dir=examples/data2vec/
## ./datas2 saved the train.tsv and valid.tsv generated by sourdfile

It raised the error:

Sorry to put this question at wrong position, and I moved it to https://github.com/pytorch/fairseq/issues/4150
The manager can delete this. Thanks.


WIP: Build Go CLI with Gradle Instead of Ant

Removes the build.xml
Updates the README to demonstrate build process with Gradle

@mdeuser, please review.

@dubeejw  - LGTM

@csantanapr - ready for merge.  Thanks!

title has WIP, assigned to me when is ready, it looks there is a minor comment from @rabbah to address

rebase and merged 79abce6f7c1b62a59907d685a312f016f11f1a4c


MongoDB and a Formatted Log Viewer

Love the bot!  Only ticket bot where all the settings I need are in the config, not the individual commands through Discord to set it up.  Nobody wants to !command to setup a bot.  Best feature is the ability to listen in Server A and address the User and the Issue in Server B, keeping all the BetterDiscord users out of my business.  The one, well two things, I think would take this particular bot to the next level would be independent database storage for logs, like MongoDB, and a formatted (html if you have to) log message viewer.
I'm in the discord Sir Black#0001, let me know if I can help contribute in any way.

This is good idea to add MongoDb support

This is good idea to add MongoDb support

The bot currently uses SQL internally, and as such it will not be possible to add MongoDB support without overhauling most of the database code that currently exists.
For a formatted log viewer, there are some plugins that do this currently in the works by some of our regulars on the support server! Visit there to track their progress: https://discord.gg/vRuhG9R

The bot currently uses SQL internally, and as such it will not be possible to add MongoDB support without overhauling most of the database code that currently exists.
For a formatted log viewer, there are some plugins that do this currently in the works by some of our regulars on the support server! Visit there to track their progress: https://discord.gg/vRuhG9R

On second thought, I'll leave this issue up as a general tracking issue for MongoDB support in the future!

On second thought, I'll leave this issue up as a general tracking issue for MongoDB support in the future!


chore(release): 1.6.0-rc.8

Version bump in package.json and package-lock.json for release 1.6.0-rc.8

:tada: This PR is included in version 1.6.0-rc.9 :tada:
The release is available on:

npm package (@rc dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


style sheet connection

A style sheet is linked with HTML and also removed the underline from anchor tags

Thank you


Calling Subscriptions from Clojure REPL

After doing some research I found that most of re-frame is now in .cljc (https://github.com/Day8/re-frame/blob/master/docs/FAQs/Why-CLJC.md). This was excited to hear this due to the fact that we can now test from the JVM now and not have to rely on a JV environment. However, when I tried exercising subscriptions in the REPL I came to the following issues.
1. Calling subscriptions that subscribe to other subscriptions and use their values for computations lead to an error message of invalid arity.
--- Subscription ---
; Subscription
(re-frame/reg-sub
 ::suggestions
 (fn [db [_ query]]
   (get-in db [:typeahead :suggestions])))

(re-frame/reg-sub
 ::query
 (fn [db [_ query]]
   (get-in db [:typeahead :query])))

(re-frame/reg-sub
 ::typeahead
 (fn [_ _]
   [(re-frame/subscribe [::query])
    (re-frame/subscribe [::suggestions])])
 (fn [[query suggestions] _]
   {:query query
    :suggestions suggestions}))

-- Error --
slm.components.typeahead.subscriptions=> (re-frame/subscribe [::typeahead])

Execution error (ArityException) at re-frame.subs/reg-sub$subs-handler-fn (subs.cljc:325).
Wrong number of args (1) passed to: slm.components.typeahead.subscriptions/eval28820/fn--28821

(let [typeahead @(re-frame/subscribe [::typeahead]                                         )]
                                    #_=>   typeahead)

Execution error (ArityException) at re-frame.subs/reg-sub$subs-handler-fn (subs.cljc:325).
Wrong number of args (1) passed to: slm.components.typeahead.subscriptions/eval27322/fn--27323

2. Can't extract values from subscriptions
; db
(def default-db
  {:name "olanext"})

; subscription
(re-frame/reg-sub
 ::name
 (fn [db _]
   (:name db)))

--- attempt to extract value ---
slm.components.typeahead.subscriptions=> (let [name @(re-frame/subscribe [::name])]
                                    #_=>   name)
nil

Is there any resolution to these issues?

Can't extract values from subscriptions

I think this is because you haven't put any data into the app-db yet. You can do this by running this in the REPL:
(re-frame/reg-event-db
 :initialize-db
 (fn [_ _] default-db))

(re-frame/dispatch [:initialize-db])

Calling subscriptions that subscribe to other subscriptions and use their values for computations lead to an error message of invalid arity.

I can reproduce the exception. I traced the exception to this line:
    (register-handler
      kind
      query-id
      (fn subs-handler-fn
        ([db query-vec]
         (let [subscriptions (inputs-fn query-vec)  ;; HERE

When the error happened, the query-vec was [:user/typeahead] and the inputs-fn was what's defined in the ::typeahead subscription:
(fn [_ _]
   [(re-frame/subscribe [::query])
    (re-frame/subscribe [::suggestions])])

I'm not sure why normal cases (when not tested in the REPL) we do not see this issue, and I'll try to figure it out. It'll be great to have some guidance from the maintainers.

Hi maintainers, I think the actions for this issue is to improve documentation. We can be clearer about writing signal functions and how to use layer 3 subscription in general.

Fixed in #541


azure stack support

Hi,
Have you ever tried adal on azure stack env? I have been using adal in azure stack env, trying to use service principal connecting to azure stack, while I always got below error:
2017/08/04 07:40:17 Error: azure.BearerAuthorizer#WithAuthorization: Failed to refresh the Token for request to https://adminmanagement.local.azurestack.external/subscriptions/a3368291-e427-41b0-b790-66b7be21017b/providers/Microsoft.Storage/checkNameAvailability?api-version=2015-06-15: StatusCode=0 -- Original Error: adal: Refresh request failed. Status Code = '400'
And then If I comment out below line in adal, it would proceed.

https://github.com/Azure/go-autorest/blob/master/autorest/adal/token.go#L373

Hello @andyzhangx !
Please submit a PR, PRs are always welcome :)

Hi @mcardosos , you mean comment out line 373? This issue only happens on azure stack, it does not happen on global azure, is it reasonable?

Well, the fix should work on both cases. Maybe there is another possible status code?

Closing this out for now, we're still working on our roadmap for supporting Azure Stack.

Do you have any info on the roadmap or on a fix ?


Using Firefox and Safari, jwt.verify raises Error.capturestacktrace is not a function

I've started testing my application outside of Chrome and started receiving the error regarding Error.capturestacktrace is not a function.
I have both the latest Firefox and Safari. The token verification works fine on the latest version of Chrome. This error occurs specifically after the token is expired and I attempt to verify it.
The token verification below is executed during specific route transitions on the client side. The  error caused prevents me from logging inside of the verification callback.
 jwt.verify(
      token,
      secret,
      function(err, verifiedJwt) {
        if (err) {
          if (
            err.name === "TokenExpiredError" ||
            err.name === "JsonWebTokenError"
            ) {
            next("/logout");
        }
      } else {
          //Refresh token if it is not expired
          store.dispatch("REFRESH_TOKEN", token);
        }
      }
  );

@ziluvatar : I've added a PR to ensure that captureStackTrace is truthy before attempting to call it.

@ziluvatar : I'm also curious if browser support is a thing for this project ... both this repo and jws specifically call out node, but there's no explicit statement in the README whether browsers are supported or not.

This project focus is NodeJS, nevertheless since the community seems to be using it for browsers, we balance the issue, the effort to maintain node vs browser and it makes sense.

PR was merged. It's on v8.1.0

Thanks!


Tooltip component to display content more than one line in new line (to display filed value in line by line)

Is your feature request related to a problem? Please describe
Tooltip component currently can't display text line by line (ie. no HTML content)
Describe the solution you'd like

Closing as this is duplicated by #1547


ENH: disjoint set data structure

What does this implement/fix?

This PR implements a disjoint set data structure (also known as union-find). The DisjointSet class implements two methods only: union and find. Union performs "union by size" and implements path compression only (not path halving or splitting).
~I have written it in cython in order to get good performance, so that it can also be used by other SciPy components in future.~ Edit: it is now a pure python implementation.
I have put it in sparse.csgraph based on @rgommers suggestion from the dev list:
Cluster, spatial and sparse all could make sense. If we foresee using this
internally in all those modules, I think we'd have to put it in `sparse` or
in `_lib`. The reason: no further dependencies between modules. cluster
already depends on spatial, and spatial depends on sparse.

Tests and documentation are included.

Build failures appear to be unrelated.

Anything else I should add to my checklist?

Checklist looks good. It is usually best to establish a broad consensus when new functionality is being added, so let's ask @tylerjereddy, @fuglede: you are sparse regulars with cython skills. Can I interest you in looking this PR over? Particular concerns of mine are:

Suitability for inclusion in sparse.csgraph
Have I done anything daft cython-wise.

@sethtroisi btw, thanks for the great review!

So right now this will expose the IndexError from numpy if you call find with an element equal to n or larger.  Is that the correct behavior, or should this produce some other error for this case?
Let's say that it turns out that my initial n was too small, should there be away to resize the DisjointSet i have without redoing whatever other calculation I had to do the first time?  I suppose that this might not be possible at all.  It does look like resizing the two arrays and updating n and nc should do it though.
I guess a V2 behavior could be to dynamically resize the arrays you're using like a C++ vector will do.  I.e. starting with a default size and then increasing it using some heuristic to keep the unused size bounded while keeping the correct or nearly correct big-O  behavior by limiting the reallocations.   I suppose this could also be implemented via dicts or c++ maps too.

So right now this will expose the IndexError from numpy if you call find with an element equal to n or larger. Is that the correct behavior, or should this produce some other error for this case?

That was my original intention in the initial commit. In the current commit the requirement to specify n up front has been removed. It is now a pure python implementation using dicts rather than an cython array-based implementation. For this PR I propose that we stick to the python implementation in order to hammer out the interface.

I suppose this could also be implemented via dicts or c++ maps too.

The class currently operates on integer node indices only. I think this is in line with the other functions in the csgraph module. It also means that it can be ported to C++ using maps instead of dicts in V2.

The python implementation linked in the original discussion of adding graph algorithms (2011) is in networkx is at https://github.com/networkx/networkx/blob/master/networkx/utils/union_find.py in case anyone is interested. Note that it merges by weight rather than height, both methods are efficient.

API-wise, if I read @rgommers' comment on the mailing list correctly, he considered having it live in sparse directly, as opposed to sparse.csgraph; this might simplify the dependency graph. (Unless sparse and sparse.csgraph are considered equivalent from a dependency point of view(?))

Also API-wise, but more of a remark than a question/comment: While I'm not going to argue that this one is relevant in its own right (from the dev list discussion, it certainly seems like you and others have plenty of use cases already, and NetworkX shipping its own implementation is a good sign as well), but at the same time, it seems like this one is likely to be duplicated for performance (e.g. when inlining is desirable), sort of like fixed-size stacks and queues generally are. For instance, I guess you don't envision replacing the logic in the existing Kruskal-based MST solver, or the existing connected_components?

Thanks for a great review @fuglede.

API-wise, if I read @rgommers' comment on the mailing list correctly, he considered having it live in sparse directly, as opposed to sparse.csgraph; this might simplify the dependency graph. (Unless sparse and sparse.csgraph are considered equivalent from a dependency point of view(?))

I'm very happy to move it. Shall we wait for him to weigh in or just do it?

... it seems like this one is likely to be duplicated for performance (e.g. when inlining is desirable), sort of like fixed-size stacks and queues generally are. For instance, I guess you don't envision replacing the logic in the existing Kruskal-based MST solver, or the existing connected_components?

You are correct. Here I'm aiming for a publicly-accessible implementation which is also fast enough for some less demanding internal use cases. An example I had in mind is a PR of mine (#11502) where I use a disjoint set. That PR is already too big and the addition of the disjoint set is a distraction.
The challenge in this PR has been to find a balance between a flexible implementation (as in networkx ) where any hashable object can be used as a node, and a faster implementation where only integers can be used as keys.

Shall we wait for him to weigh in or just do it?

I frankly can't claim to have enough of an overview to say what makes more sense.
Other than that, and the two minor inline comments on documentation and input type/range, LGTM!

The challenge in this PR has been to find a balance between [fast and flexible]

I tussled with that too, back in the day, and also ended up with integers. They aren't the most transparent from the interface side, but fast and easy to code. My guess is that a more flexible interface could be made on top of the integers with a translation layer from objects to integers if needed. So maybe a fast cython/c++ base class/functions with a python interface.

I may have mentioned that I also like to keep the set elements in a circular list, the links are easy to manage when merging, and the entire set can be traversed starting from any element in it.

Here is a link to my old *.pyx implementation https://gist.github.com/charris/62f2dadc0ab597196635e8803eab786a

After some thought I have revised the design so that any immutable object can be used as input. This was motivated by @fuglede's observation that this class will not be fast enough to replace inline code. In that light, restricting the input to integers feels like occupying a poor niche with neither optimal speed nor optimal flexibility.
In V2 I will rewrite in C++ backed by a python dict, and try to squeeze as much performance out as possible. I propose to save additional features for later PRs.

By "immutable", we really want "hashable", right? (Tuples are immutable, yet not necessarily hashable, and conversely, user defined types are hashable through id, yet not necessarily immutable.)
Just keeping C++ around for the traversal-related parts of the code sounds logical enough to me; and certainly a bit easier than having to wrestle hashes manually in calling code. For the C++ part, do you intend to use a hash map indexed by references to the Python objects, or something like that?

By "immutable", we really want "hashable", right?

Absolutely - good catch. I have updated the docstrings.

I have added an __iter__ method and changed the self._indices from a dict to an OrderedDict.
Before merging I want to add tie-breaking back in to the merge method. I plan to use order of insertion to break ties. I will get on this later.

the in operator seems to be linear (via __iter__?)

I have added a __contains__ method. The benchmark looks better now:
[ 66.67%] ··· sparse_csgraph_disjoint_set.Bench.time_contains                                                               ok
[ 66.67%] ··· ======= =========
                 n
              ------- ---------
                100    495±3ns
                1000   497±3ns
               10000   498±2ns
              ======= =========

@sethtroisi are there any other standard class methods we should implement?

Thanks for another great review @sethtroisi.
I have implemented the __len__ method and removed the n_elements attribute. I think this is the correct use of __len__, since it is intuitive that len(disjoint_set) == len(list(disjoint_set)).
The str method is a good suggestion. I will save it for later though.

My main remaining concern is where this class belongs. It feels out of place in sparse.csgraph and sparse, since it is not a sparse matrix class. cluster is where I feel it most naturally belongs, but I would like to be able to import it from spatial too. If we put it in _lib it isn't exposed publicly.
Is the solution to put it in _lib and expose it via cluster? I'm just guessing here, so suggestions from experienced hands are most welcome.

cluster is where I feel it most naturally belongs, but I would like to be able to import it from spatial

So you want to be able to import the same thing from both cluster and spatial? That would be a wee bit confusing, I'd say.

So you want to be able to import the same thing from both cluster and spatial?

I would like to put this class in cluster. Then, from (internal) code in spatial, I would like to be able to write from scipy.cluster import DisjointSet.

Then indeed, maybe put it into _lib, like you mentioned

I've reviewed several times and don't have any issues (just the future TODO for adding __str__, __bool__, and __eq__)
Happy to see this good in soon if we could get another LGTM.

I have moved the public interface to scipy.cluster.hierarchy. The class itself is in scipy._lib, so it will still be accessible to internal scipy code without introducing new dependencies.
Once this is green I am happy with it.

At the moment I think we just need a maintainer with sufficient "ownership" of scipy.cluster.hierarchy to approve this.

@pmla I'm new so not sure how to help get this committed; I'd personally fall back to pinging rgommers when I'm blocked.
If It would be helpful to summarize on the mailing list or something else I'm happy to do that.

Thanks for the review @fuglede. The bug you found was critical.

Depending on what is decided on support for python 3.6 in SciPy 1.6.0, we can replace the OrderedDict with a standard dict.

Hello, newbie here!
I had a question: Why don't we leverage multiprocessing while finding the parent of a node, in connected and merge methods? While computing parents of two very large, uncompressed, disjoint sets, we can benefit from multiprocessing.
We can get around the chance of race conditions by using appropriate node based locks.
There seems to be a very recent work related to this subject: https://arxiv.org/abs/2003.01203

API-wise, if I read @rgommers' comment on the mailing list correctly, he considered having it live in sparse directly, as opposed to sparse.csgraph; this might simplify the dependency graph.

I meant sparse.csgraph, that seemed to be the closest fit. It's very similar to code already present there; reading the Wikipedia page that's the reference in the docstring, that mentions minimum spanning tree of a graph and connected components (both of which we have in csgraph); finally there's discussion here about the equivalent being in NetworkX and the Wikipedia page mentions another equivalent in the Boost Graph Library.
So I'm slightly surprised by the choice for cluster.hierarchy. That said, I haven't reviewed this PR in detail - if reviewers agree that cluster is a good choice, I'm happy with that as well.

At the moment I think we just need a maintainer with sufficient "ownership" of scipy.cluster.hierarchy to approve this.

cluster doesn't really have a dedicated maintainer unfortunately. It's mostly been @nmayorov and me who have reviewed PRs for it.

@pmla you may want to rewrite the commit history. Or we can squash-merge.

Cluster makes sense to me, clustering is what I've always used the algorithm for, it provides the equivalence classes of an equivalence relationship,

@rgommers @charris Thanks for weighing in. Cluster it is. I will leave it in cluster.hierarchy since cluster.vq is not relevant here.
@sethtroisi would you like to merge this? A squash-merge has been recommended by Ralf.

@pmla Happy to merge this! Thanks for the work to make this better along the way.

Very nice! Could you add a release note for this in https://github.com/scipy/scipy/wiki/Release-note-entries-for-SciPy-1.6.0 @pmla?

@rgommers Yep. Done.


Inquiry about target platform requirements for windows

Hello,
I am interested in using this plugin for a project that targets Windows. Before I proceed, I would like to confirm the minimum supported version of the Windows SDK required by this plugin to ensure compatibility with my development environment and target Windows platforms.
I have checked the CMakeLists.txt and other documentation but could not find specific information regarding the Windows SDK version.
Could you please provide some guidance on the minimum Windows SDK version that is compatible with this plugin? This information will be very helpful for setting up my development environment correctly.
Thank you for your assistance and for the work you've put into this plugin.
Best regards

I think I didn't set any as such value for putting up a minimum sdk version


Add Built-In Support for Working with JWT

Describe the feature
JWT is a pretty common solution for working with microservice API's instead of using Sessions.  This allows for easier horizontal growth and for me, worked to solve multi-domain issues on Safari.
Additional context
The recommended solution for JWT is to place them in the header { "Authorization": "Bearer XABC...}.  First would be a convenience method on Ctx =>  ctx.getJwtToken()
If more integrated support is desired (which it may not, since it's adding some utility methods beyond the scope of a microservice), add some utility methods to create a JWT token and decode it.  I used the library JJWT to work with JWT.
JavalinJWT.createJwtToken(String secretKey, String id, String issuer, String subject)
JavalinJWT.decodeJwtToken(String secretKey, String jwtToken)
JavalinJWT.isValidToken(String secretKey, String jwtToken)

Would be good to have that built in but there's also a library:
https://github.com/kmehrunes/javalin-jwt
If it is added to Javalin you definitely also need to add it to the OpenAPIOptions otherwise Swagger will be unusable.
I currently use the library linked above and have the filthiest hack to fix my swagger doc :
fun hackSwaggerDoc(app: Javalin) {
    app.after("/api/swagger-docs") { ctx ->
        val resultString = ctx.resultString()!!.toString()
        val additionalComponent = """
            "security": [
                {"bearerAuth": []}
            ],
            "components": {
                "securitySchemes": {
                    "bearerAuth": {
                        "type": "http",
                        "scheme": "bearer",
                        "bearerFormat": "JWT"
                    }
                },
            """
        ctx.result(resultString.replace("\"components\":{", additionalComponent))
    }
}

Yikes!

I was able to adjust the Swagger documentation output to what I wanted by adding a schemaRequirement to an InitialConfigurationCreator and then a SecurityItem to each individual operation (not all of my operations need authorization).  This will allow you to test from within the Swagger docs and have the Authorization header sent to the server.
Thanks to @manuelhuber for your Kotlin code as it pointed me in the right direction I needed to figure this out.
Setup
SecurityScheme securityScheme = new SecurityScheme();
securityScheme.setType(SecurityScheme.Type.HTTP);
securityScheme.setScheme("bearer");
securityScheme.setBearerFormat("JWT");

InitialConfigurationCreator initialConfigurationCreator = () -> new OpenAPI()
        .info(new Info().version("1.0").description("My Application").title("My API Listing"))
        .schemaRequirement("BearerAuth", securityScheme);
OpenApiOptions openApiOptions = new OpenApiOptions(initialConfigurationCreator);
openApiOptions.path("/swagger-docs");
openApiOptions.swagger(new SwaggerOptions("/swagger").title("My Swagger Documentation"));

app = Javalin.create(config -> {
    config.defaultContentType = "application/json";
    config.registerPlugin(new OpenApiPlugin(openApiOptions));
    config.server(() -> {
        Server server = new Server();
        ...
   });
}).start();

Per Each Operation
OpenApiDocumentation getAccountDocumentation = OpenApiBuilder.document()
    .operation(openApiOperation -> {
        openApiOperation.description("Get current user account");
        openApiOperation.addSecurityItem(new SecurityRequirement().addList("BearerAuth"));
    })
    .json("200", AccountRESTResponse.class)
    .result("401")
    .result("404")
    .result("500");
...
app.get("/api/account", OpenApiBuilder.documented(getAccountDocumentation, APIController::getAccount));

Is there still interest in having something like this added?

If it was there, I’d use it. I assume a lot of people would need it given it’s the preferred authentication system for micro services, it’s surprising to me that no one else has asked for this or commented on my PR.
Mike A

On May 8, 2020, at 5:39 PM, David<EMAIL_ADDRESS>wrote:

Is there still interest in having something like this added?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yes. I was just about to clone the repo and add this myself lol - but searched for the issue lol
I prefer JWTs to regular sessions so having this would be really helpful
The following 4 functions would be a solid addition
ctx.getBearerToken
JavalinJWT.createJwtToken(String secretKey, String id, String issuer, String subject, Json claims)
JavalinJWT.decodeJwtToken(String secretKey, String jwtToken)
JavalinJWT.isValidToken(String secretKey, String jwtToken)

Okay, seems there's still interest in this. Feel free to create a PR.

@bluedevil2k I'd be willing to use my Java code, if someone is willing to convert it to Kotlin

You can submit a PR with Java code, that's not a problem!

@tipsy
Yes. I was just about to clone the repo and add this myself lol - but searched for the issue lol
I prefer JWTs to regular sessions so having this would be really helpful
The following 4 functions would be a solid addition
ctx.getBearerToken
JavalinJWT.createJwtToken(String secretKey, String issuer, String subject, Json claims)
JavalinJWT.decodeJwtToken(String secretKey, String jwtToken)
JavalinJWT.isValidToken(String secretKey, String jwtToken)

To me it seems that there is always the assumption that JWT are signed with HMAC.
But there are also others, like RSA, which are based on public and private keys. So this will require a key to validate. Then my question is, is JWK and JWKS also going to be supported? Which is really useful when you want to get a public key from an endpoint.
To further extend this, validating should also check which algorithms are allowed. Accepting all would be a bad idea, because you can then use algorithm none.
Bearer tokens can be anything, it doesn't necessarily mean they are JWT.
Adding this feature could be a nice addition in Javalin, however I am not sure how much you will gain from this. Creating an AccessManager where you can be really specific on how the token is used, makes in my opinion more sense.

There has been little interest in this (still no PR), and it is a bit outside of Javalin's scope. Most libraries (auth0, google) offer their own methods for this, and if not you can just pull in a dedicated JWT library. I'll close the issue.


fix: pass customLogger to loadConfigFromFile (fix #15824)

Description
This PR fixes #15824
Basically, it passes down the customLogger and clearScreen options from inline build config to loadConfigFromFile function where they can be utilized if read from file fails.
What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines, especially the Pull Request Guidelines.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Update the corresponding documentation if needed.
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

seems like one test flaked?
no related changes to the failed test.


Improve German translations.

Codecov Report

Merging #272 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #272   +/-   ##
=========================================
  Coverage     42.17%   42.17%
  Complexity     3463     3463
=========================================
  Files           546      546
  Lines         25242    25242
  Branches       2018     2018
=========================================
  Hits          10647    10647
  Misses        13877    13877
  Partials        718      718

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 457357b...5028e52. Read the comment docs.

Thank you very much for your contribution!
I have checked your pull request and think it is really worth to accept it, unfortunately I can't do it because the files you have updated are generated in the blockly project.  Therefore I have taken your changes to update the correct file here: https://github.com/OpenRoberta/blockly/commit/71fe81b2e3491992d34adae9c5db8fb5f2594715
feel free to send the next pull request against blockly/master. It would also be very helpful for us that you create an issue beforehand and discuss the workflow of contribution in one of our communication chanels described here https://github.com/OpenRoberta/openroberta-lab/wiki/Community
Thank you

As the changes are already included I will close this.


Drop the C Library interface

superjoe30 and I have talked about whether to keep maintaining or to drop the C Library interface. We both vote it should be dropped. This would enhance the interaction of the two components of the project and reduce a good deal of code that simply translates between C and C++ constructs.

I don't know why a C library interface would make sense, though a C++ one might.  Is the plan to drop the fact that it's in C, or to drop the idea of a library entirely?

Drop the whole library idea entirely

Done in cea90a6c1b360d10522dacc243b0da34776f3125


Update NuGet dependencies

This PR contains the following updates:

Package
Type
Update
Change

Microsoft.Build.Utilities.Core (source)
nuget
minor
17.7.2 -> 17.8.3

xunit
nuget
patch
2.6.1 -> 2.6.2

xunit.runner.visualstudio
nuget
patch
2.5.3 -> 2.5.4

Release Notes

dotnet/msbuild (Microsoft.Build.Utilities.Core)
v17.8.3
What's Changed

[automated] Merge branch 'vs17.7' => 'main' by @dotnet-maestro-bot in https://github.com/dotnet/msbuild/pull/8920
Version 17.8 by @rainersigwald in https://github.com/dotnet/msbuild/pull/8949
Update Strings.resx by @asklar in https://github.com/dotnet/msbuild/pull/8941
Remove redundant SourceBuildTrimNetFrameworkTargets property by @v-chayan in https://github.com/dotnet/msbuild/pull/8952
[main] Update dependencies from nuget/nuget.client by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/8869
Add WithoutMetadataValue by @JaynieBai in https://github.com/dotnet/msbuild/pull/8867
Fix /warnaserror false positive overall success by @rokonec in https://github.com/dotnet/msbuild/pull/8953
Bump StyleCop.Analyzers from 1.2.0-beta.435 to 1.2.0-beta.507 in /eng/dependabot by @dependabot in https://github.com/dotnet/msbuild/pull/8950
Fix ContinueOnError false positive by @rokonec in https://github.com/dotnet/msbuild/pull/8954
[main] Update dependencies from dotnet/roslyn by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/8955
Intrinsic arithmetic function overloads by @jrdodds in https://github.com/dotnet/msbuild/pull/8710
Try to fix the build error after reenabling static graph restore by @GangWang01 in https://github.com/dotnet/msbuild/pull/8960
Add more packages to Version.Details for source-build by @mthalman in https://github.com/dotnet/msbuild/pull/8940
Backward-compatibility with KeyValuePair<string, string> metadata items [#8864] by @jehhynes in https://github.com/dotnet/msbuild/pull/8870
ProcessExtensions: use BCL Process.Kill. by @tmds in https://github.com/dotnet/msbuild/pull/8968
Enable BinSkim scan in nightly validation by @MilenaHristova in https://github.com/dotnet/msbuild/pull/8976
Fix copy cancelation by @danmoseley in https://github.com/dotnet/msbuild/pull/8951
Send AssemblyLoadBuildEventArgs only for valid LoggingContext by @rokonec in https://github.com/dotnet/msbuild/pull/8944
[main] Update dependencies from nuget/nuget.client by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/8993
improve TaskItem hashcode by @danmoseley in https://github.com/dotnet/msbuild/pull/8988
[main] Update dependencies from dotnet/roslyn by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/8992
Expose static methods from System.OperatingSystem by @jrdodds in https://github.com/dotnet/msbuild/pull/8935
remove #if NEVER in hashset by @danmoseley in https://github.com/dotnet/msbuild/pull/8986
ResolveAssemblyReference CPU optimizations by @ladipro in https://github.com/dotnet/msbuild/pull/8916
Update TSA config by @JanKrivanek in https://github.com/dotnet/msbuild/pull/9004
Avoid boxing enum by @davkean in https://github.com/dotnet/msbuild/pull/9001
Unify casing for boolean true in targets by @rainersigwald in https://github.com/dotnet/msbuild/pull/9006
Switch TaskItemData exceptions by @rainersigwald in https://github.com/dotnet/msbuild/pull/9003
Moving from SHA1 to SHA256 for Hash task by @JanKrivanek in https://github.com/dotnet/msbuild/pull/8812
Add BaseOutputPath to XSD by @drewnoakes in https://github.com/dotnet/msbuild/pull/8994
Rename terminallogger docs and update with more details by @baronfel in https://github.com/dotnet/msbuild/pull/9010
[automated] Merge branch 'vs17.7' => 'main' by @dotnet-maestro-bot in https://github.com/dotnet/msbuild/pull/9023
Reënable static graph restore by @rainersigwald in https://github.com/dotnet/msbuild/pull/8856
cleanup ErrorUtilities by @danmoseley in https://github.com/dotnet/msbuild/pull/8990
TerminalLogger: Store output writer after setting it to UTF-8 by @rainersigwald in https://github.com/dotnet/msbuild/pull/9035
Revert "ResolveAssemblyReference CPU optimizations (#8916)" by @JaynieBai in https://github.com/dotnet/msbuild/pull/9037
Make TaskRegistry tasks ordering deterministic (FIFO) by @JanKrivanek in https://github.com/dotnet/msbuild/pull/8974
Fix TaskRegistry mutability by @JanKrivanek in https://github.com/dotnet/msbuild/pull/9032
Comment for #9035 by @rainersigwald in https://github.com/dotnet/msbuild/pull/9040
Reduce runtime for and allocations from BaseConsoleLogger.IndentString by @jdrobison in https://github.com/dotnet/msbuild/pull/8934
Update to Arcade 8 by @rainersigwald in https://github.com/dotnet/msbuild/pull/8672
Improving the log of CombineTargetFrameworkInfoProperties fails with not valid RootElementName by @JaynieBai in https://github.com/dotnet/msbuild/pull/9002
adjust XmlReader.Create to passed path with potentially invalid character by @YuliiaKovalova in https://github.com/dotnet/msbuild/pull/9028
[main] Update dependencies from dotnet/roslyn by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9045
System.Text.Json 7.0.3 by @rainersigwald in https://github.com/dotnet/msbuild/pull/9043
Improve waiting for the server is in use by the signal that a marker file is created by the build task by @GangWang01 in https://github.com/dotnet/msbuild/pull/8981
Rename liveLogger to be terminallogger by @GangWang01 in https://github.com/dotnet/msbuild/pull/9027
Optimize exclude computation on ItemGroupIntrinsicTask target call by @YuliiaKovalova in https://github.com/dotnet/msbuild/pull/9047
Add StringIntern for Item and Property Functions. by @yuehuang010 in https://github.com/dotnet/msbuild/pull/9024
[main] Update dependencies from dotnet/arcade dotnet/roslyn nuget/nuget.client by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9041
Update source build template, vs version and XCopyMSBuildVersion by @JaynieBai in https://github.com/dotnet/msbuild/pull/9064
Fixed the embedded file size record by @MichalPavlik in https://github.com/dotnet/msbuild/pull/9065
[vs17.7] adjust XmlReader.Create to passed path with potentially invalid character by @github-actions in https://github.com/dotnet/msbuild/pull/9067
Fix the System.Security.Cryptography.Pkcs secuity error by @JaynieBai in https://github.com/dotnet/msbuild/pull/9070
[automated] Merge branch 'vs17.7' => 'main' by @dotnet-maestro-bot in https://github.com/dotnet/msbuild/pull/9071
Bump Versions.props to 17.7.2 by @rokonec in https://github.com/dotnet/msbuild/pull/9072
Fix typo in ProjectCacheService.IsDesignTimeBuild leading to the value of BuildingProject not being checked by @dfederm in https://github.com/dotnet/msbuild/pull/9069
Error log the invalid the target name  by @JaynieBai in https://github.com/dotnet/msbuild/pull/9050
ResolveAssemblyReference CPU optimizations (redo) by @ladipro in https://github.com/dotnet/msbuild/pull/9044
[automated] Merge branch 'vs17.7' => 'main' by @dotnet-maestro-bot in https://github.com/dotnet/msbuild/pull/9073
[main] Update dependencies from dotnet/arcade by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9059
Skip TerminalLogger in context of dotnet test by @JanKrivanek in https://github.com/dotnet/msbuild/pull/9066
Add unit test for https://github.com/dotnet/msbuild/pull/8870 by @JaynieBai in https://github.com/dotnet/msbuild/pull/8961
fixes #8958  TerminalLogger in .NET 8.0.100-preview.6 issues audible alerts on iTerm2 by @vlada-shubina in https://github.com/dotnet/msbuild/pull/9060
TaskFactoryWrapper: guard against multi-threaded access to dictionaries by @jdrobison in https://github.com/dotnet/msbuild/pull/8928
Resource for invalid -tl value by @rainersigwald in https://github.com/dotnet/msbuild/pull/9078
Update invalid localized string by @JaynieBai in https://github.com/dotnet/msbuild/pull/9084
Terminal logger: Remove emojis and tweak warning/error colors by @ladipro in https://github.com/dotnet/msbuild/pull/9074
Do not register typelib in ComReferenceInfo by @rokonec in https://github.com/dotnet/msbuild/pull/9087
[main] Update dependencies from dotnet/arcade by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9086
[main] Update dependencies from dotnet/roslyn nuget/nuget.client by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9085
[main] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/8893
Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 8181267 by @dotnet-bot in https://github.com/dotnet/msbuild/pull/9088
Ban XmlReader overloads that take string by @rainersigwald in https://github.com/dotnet/msbuild/pull/9076
Remove unneeded supressions by @JanKrivanek in https://github.com/dotnet/msbuild/pull/9095
Bump up dotnet version to fix CG alerts by @GangWang01 in https://github.com/dotnet/msbuild/pull/9096
Task name class name error by @jrdodds in https://github.com/dotnet/msbuild/pull/8921
[automated] Merge branch 'vs17.7' => 'main' by @dotnet-maestro-bot in https://github.com/dotnet/msbuild/pull/9097
Misc fixes for /question build by @yuehuang010 in https://github.com/dotnet/msbuild/pull/8881
Remove sourcelink dependency by @NikolaMilosavljevic in https://github.com/dotnet/msbuild/pull/9105
[main] Update dependencies from dotnet/roslyn nuget/nuget.client by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9107
[main] Update dependencies from dotnet/arcade by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9108
Fix project configuration case-mismatch issue for solution-based graph builds by @dfederm in https://github.com/dotnet/msbuild/pull/9104
[main] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9112
Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 8218051 by @dotnet-bot in https://github.com/dotnet/msbuild/pull/9110
Deprecate binfmt in build event args by @rokonec in https://github.com/dotnet/msbuild/pull/8917
Removed tests containing TranslateDotNet by @maridematte in https://github.com/dotnet/msbuild/pull/9017
Remove the temporarily added build feed to 17.7 by @YuliiaKovalova in https://github.com/dotnet/msbuild/pull/9113
[main] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9114
Don't use TranslateDotNet in TaskParameter by @ladipro in https://github.com/dotnet/msbuild/pull/9111
[main] Update dependencies from dotnet/roslyn nuget/nuget.client by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9124
[main] Update dependencies from dotnet/arcade by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9125
Get eval results 2 by @Forgind in https://github.com/dotnet/msbuild/pull/8792
Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 8254766 by @dotnet-bot in https://github.com/dotnet/msbuild/pull/9123
[main] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9128
Remove ResolveAssemblyReferencesStateFile from GenerateBindingRedirects inputs by @ladipro in https://github.com/dotnet/msbuild/pull/8749
Terminal logger enablement by /tlp:default and related telemetry by @rokonec in https://github.com/dotnet/msbuild/pull/9119
Revert "Get eval results 2 - getProperty, getItem, getTargetResult (#… by @rainersigwald in https://github.com/dotnet/msbuild/pull/9136
Fixed typo in SolutionFile_Tests.cs by @icnocop in https://github.com/dotnet/msbuild/pull/9137
Removing dead code unit tests and BinFmt enablement by @JanKrivanek in https://github.com/dotnet/msbuild/pull/9126
[main] Update dependencies from dotnet/roslyn nuget/nuget.client by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9143
[main] Update dependencies from dotnet/arcade by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9144
Update Copy task to log full paths by @Youssef1313 in https://github.com/dotnet/msbuild/pull/9142
[main] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9151
Fix terminal logger working in combination with binary logger. by @AR-May in https://github.com/dotnet/msbuild/pull/9135
Expose Binlog reader API needed for sensitive data redacting by @JanKrivanek in https://github.com/dotnet/msbuild/pull/9132
Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 8300897 by @dotnet-bot in https://github.com/dotnet/msbuild/pull/9149
Fixing nowarn flakiness - warnings config is stored by compound key by @rokonec in https://github.com/dotnet/msbuild/pull/9162
Fixed code comment in SolutionFile.cs by @icnocop in https://github.com/dotnet/msbuild/pull/9157
Flow live version of System.Security.Permissions for source-build by @mthalman in https://github.com/dotnet/msbuild/pull/9158
Don't compile SDK pattern regexes on .NET Framework by @ladipro in https://github.com/dotnet/msbuild/pull/9173
Use ToolTask.TaskProcessTerminationTimeout correctly by @gpwen in https://github.com/dotnet/msbuild/pull/8546
Update dotnet runtime version by @JaynieBai in https://github.com/dotnet/msbuild/pull/9167
[main] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9171
Use more-permissive ValidBooleanFalse in Culture tasks by @rainersigwald in https://github.com/dotnet/msbuild/pull/9156
[automated] Merge branch 'vs17.7' => 'main' by @dotnet-maestro-bot in https://github.com/dotnet/msbuild/pull/9175
Add packages to Version.Details for source-build by @mthalman in https://github.com/dotnet/msbuild/pull/9172
Ignore pre-set env variables in TerminalLoggerConfiguration_Tests by @ladipro in https://github.com/dotnet/msbuild/pull/9145
[main] Update dependencies from dotnet/arcade by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9178
[main] Update dependencies from dotnet/roslyn nuget/nuget.client by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9177
Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 8322615 by @dotnet-bot in https://github.com/dotnet/msbuild/pull/9180
Add "cache add" functionality to project caching by @dfederm in https://github.com/dotnet/msbuild/pull/8726
Ship BuildXL assemblies in our VSIX by @rainersigwald in https://github.com/dotnet/msbuild/pull/9185
Bring back eval results by @Forgind in https://github.com/dotnet/msbuild/pull/9138
[main] Update dependencies from dotnet/source-build-reference-packages by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9182
Revert #8726 by @rainersigwald in https://github.com/dotnet/msbuild/pull/9188
[ClickOnce] Include content from None group for ClickOnce publishing by @sujitnayak in https://github.com/dotnet/msbuild/pull/9211
Fix console mode by @Forgind in https://github.com/dotnet/msbuild/pull/9094
Removed Security.Permission reference by @maridematte in https://github.com/dotnet/msbuild/pull/9055
[ClickOnce] Fix publishing of content items from child projects. by @sujitnayak in https://github.com/dotnet/msbuild/pull/9209
Demote MSB4120 importance by @rainersigwald in https://github.com/dotnet/msbuild/pull/9228
Fix SimpleErrorLoger Small refactor of SimpleErrorLoger by @rokonec in https://github.com/dotnet/msbuild/pull/9191
Add "cache add" functionality to project caching - Attempt 2 by @dfederm in https://github.com/dotnet/msbuild/pull/9214
Make the repo buildable with .NET 8 RC1 by @ladipro in https://github.com/dotnet/msbuild/pull/9234
Disable failing test and always dispose of TestEnvironment by @ladipro in https://github.com/dotnet/msbuild/pull/9244
Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 8418167 by @dotnet-bot in https://github.com/dotnet/msbuild/pull/9233
ProjectCache: Break away from UI thread for initialization to avoid VS hangs by @dfederm in https://github.com/dotnet/msbuild/pull/9236
Setting ReferenceOutputAssembly to falso on references to esproj by @joj in https://github.com/dotnet/msbuild/pull/9201
Fail with clear error message when reporting file accesses with unsupported arch by @dfederm in https://github.com/dotnet/msbuild/pull/9241
[main] Update dependencies from dotnet/roslyn nuget/nuget.client by @dotnet-maestro in https://github.com/dotnet/msbuild/pull/9205
Change Copy task LogDiagnostics Warning so it is suppressible by @rokonec in https://github.com/dotnet/msbuild/pull/9217
final branding for 17.8 by @YuliiaKovalova in https://github.com/dotnet/msbuild/pull/9251
Add escape hatch MSBUILDCOPYWITHOUTDELETE by @rainersigwald in https://github.com/dotnet/msbuild/pull/9257
Make BinFmt changewave dependent on BinFmt runtime enablement by @JanKrivanek in https://github.com/dotnet/msbuild/pull/9262
Translate FileAccessData in TaskHostTaskComplete by @rainersigwald in https://github.com/dotnet/msbuild/pull/9271
Remove unnecessary quotes in loc strings by @rainersigwald in https://github.com/dotnet/msbuild/pull/9284
Update Microsoft.BuildXL.Processes to 0.1.0-20230929.2 by @dfederm in https://github.com/dotnet/msbuild/pull/9292
[ClickOnce] Update how ClickOnce chooses to publish items from the None group and… by @sujitnayak in https://github.com/dotnet/msbuild/pull/9299
Stop touching GenerateBindingRedirects output by @rainersigwald in https://github.com/dotnet/msbuild/pull/9338
Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 8555984 by @dotnet-bot in https://github.com/dotnet/msbuild/pull/9344

New Contributors

@v-chayan made their first contribution in https://github.com/dotnet/msbuild/pull/8952
@mthalman made their first contribution in https://github.com/dotnet/msbuild/pull/8940
@jehhynes made their first contribution in https://github.com/dotnet/msbuild/pull/8870
@MilenaHristova made their first contribution in https://github.com/dotnet/msbuild/pull/8976
@baronfel made their first contribution in https://github.com/dotnet/msbuild/pull/9010
@icnocop made their first contribution in https://github.com/dotnet/msbuild/pull/9137
@joj made their first contribution in https://github.com/dotnet/msbuild/pull/9201

Full Changelog: https://github.com/dotnet/msbuild/compare/v17.7.1...v17.8.3

xunit/xunit (xunit)
v2.6.2
Compare Source

xunit/visualstudio.xunit (xunit.runner.visualstudio)
v2.5.4
Compare Source

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Add support for generated cluster objects

Problem

When dealing with cluster data (e.g in command requests or responses), there is no support today for handling complex types like lists/structs, with arbitrary nesting depth.
Cluster handling logic has to deal with TLV explicitly when formulating command responses, which is highly un-desirable.

Proposed Solution
In discussions with @bzbarsky-apple, agreed to an approach to:

Generate C++ 'cluster objects' that correspond minimally, to the following cluster elements:

Structs
Command requests & responses

Have Encode/Decode methods on those objects that permit conversion to/from TLV.
Objects contain native representations of the various data model types including ints, bools, strings, octstr, etc.

The agreed upon approach follows roughly that taken in the IM Prototype PR, with the following key changes:

All generated objects will be housed in a single CPP + H file.
Creation of a set of generic Encode(T&, TLVWriter&, uint64_t&) and Decode(T&, TLVReader&) methods that will encode/decode any type of T, from scalars and primitive types (that trampoline to their respective Put/Get methods in the TLVWriter/Reader objects, to complex objects that will in-turn, call code-generated Encode/Decode methods.
Fixes to the ListIterator class to correctly return status codes.
Removal of the 'table driven descriptor' based approach for now, and instead, generate actual code.

Next steps: Pivot the #8313 based on the above items.


Potential memory leak in DockerLoadBalancer

The _provisionedSlaves map could leave references to objects that are not cleaned up.

The new implementation resolves this bug.


XYZ-22: Check advanced permissions

Summary
Replace old (isSystemAdmin/isTeamAdmin) checks with the new permissions system
Ticket Link
XYZ-22
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Added or updated unit tests (required for all new features)
[x] Has server changes in the XYZ-37 branch of mattermost-server repo
[x] Has redux changes (mattermost/mattermost-redux#360)
[x] Touches critical sections of the codebase (permissions)

I'm not sure about the change of names. I completely agree with some of them (for example the canChange must be more explicit) but other cases are more "semantic to the context of the component", for example canViewSystemErrors, is very explicit for the component, when canManageSystem, is not so clear.

Finally, I changed everything except the canViewSystemErrors which I understand is more semantic in this case.

@jespino please could you rebase this against advanced-permissions-phase-1 branch, and then we can re-review and get it merged?

sure

OK, I merged the redux PR so we are ready to merge this one once it's rebased.

Rebase done :)


Lane crashlytics returns with error.

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

lane :beta do
  getCertificates
  getProvisioningProfile(bundleId: "XXX")
  buildApp(schemeName: "XXX")
  sendToCrashlytics()
end

private_lane :getCertificates do
  get_certificates(
    username: "XXX",
    team_id: "XXX",
    output_path: "fastlane/cert/"
  )
end

private_lane :getProvisioningProfile do |options|
  get_provisioning_profile(
    adhoc: true,
    app_identifier: options[:bundleId],
    username: "XXX",
    output_path: "fastlane/cert/"
  )
end

private_lane :buildApp do |options|
  build_app(
    scheme: options[:schemeName],
    clean: true,
    output_directory: "fastlane/ipa/",
    include_symbols: true,
    export_method: "ad-hoc",
    export_xcargs: "-allowProvisioningUpdates",
    silent: true
  )
end

private_lane :sendToCrashlytics do
  crashlytics(
    api_token: "XXX",
    build_secret: "XXX",
    emails: "tester1@abc.com,tester2<EMAIL_ADDRESS>  )
end

When I run bundle exec fastlane beta I get this error message on the very end of log (get_certificates, get_provisioning_profile, build_app pass without problems):
[19:08:29]: fastlane finished with errors
[!] 2018-12-03 19:08:07.725 submit Crashlytics: Crashlytics.framework/submit 1.4.0 (20)
2018-12-03 19:08:12.107 submit Crashlytics: Added Testers/Groups Successfully 200
2018-12-03 19:08:29.335 submit Crashlytics: Unable to submit build. Response code: 0
2018-12-03 19:08:29.356 submit Crashlytics: Failed to upload binary

It is strange because build will be successfully uploaded and all testers will be added. I can see it on the Fabric webpage. Why this lane finish with the error when it looks like it's working?
I found a few issues in this repo with similar problem but all of them was reloaded to older versions of Fastlane and Crashlytics. Also none of them described the behavior that build was sending out correctly despite the error messages. That's way I decided to start new issue.
I use Crashlytics via Cocoapods in the latest version: pod 'Crashlytics', '3.12.0'
Update 1
I have realized that build is visible on Fabric but it is not available to install.

Update 2
I run lane with --verbose flag.
This is calling under the hood.
./Pods/Crashlytics/submit [[API_TOKEN]] [[BUILD_SECRET]] -ipaPath '/Users/kamilharasimowicz/Documents/projects/XXX/fastlane/ipa/XXX.ipa' -emails 'tester1@abc.com,tester2<EMAIL_ADDRESS>-notifications YES -debug NO

Stacktrace
ERROR [2018-12-03 22:54:51.84]: fastlane finished with errors
Traceback (most recent call last):
	42: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:24:in `<main>'
	41: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:24:in `eval'
	40: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/bin/fastlane:23:in `<main>'
	39: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/bin/fastlane:23:in `load'
	38: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/bin/fastlane:23:in `<top (required)>'
	37: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/cli_tools_distributor.rb:108:in `take_off'
	36: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/commands_generator.rb:41:in `start'
	35: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/commands_generator.rb:333:in `run'
	34: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
	33: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
	32: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
	31: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
	30: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
	29: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/commands_generator.rb:108:in `block (2 levels) in run'
	28: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
	27: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/lane_manager.rb:56:in `cruise_lane'
	26: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/runner.rb:45:in `execute'
	25: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/runner.rb:45:in `chdir'
	24: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
	23: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/lane.rb:33:in `call'
	22: from Fastfile:9:in `block in parsing_binding'
	21: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/fast_file.rb:149:in `method_missing'
	20: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/runner.rb:146:in `trigger_action_by_name'
	19: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/runner.rb:204:in `try_switch_to_lane'
	18: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/lane.rb:33:in `call'
	17: from Fastfile:24:in `block in parsing_binding'
	16: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/fast_file.rb:149:in `method_missing'
	15: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/runner.rb:146:in `trigger_action_by_name'
	14: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/runner.rb:204:in `try_switch_to_lane'
	13: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/lane.rb:33:in `call'
	12: from Fastfile:81:in `block in parsing_binding'
	11: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/fast_file.rb:149:in `method_missing'
	10: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
	 9: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/runner.rb:227:in `execute_action'
	 8: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/runner.rb:227:in `chdir'
	 7: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/runner.rb:232:in `block in execute_action'
	 6: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/actions/actions_helper.rb:50:in `execute_action'
	 5: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/runner.rb:253:in `block (2 levels) in execute_action'
	 4: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/actions/crashlytics.rb:45:in `run'
	 3: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/helper/sh_helper.rb:78:in `sh_control_output'
	 2: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane/lib/fastlane/actions/crashlytics.rb:42:in `block in run'
	 1: from /Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane_core/lib/fastlane_core/ui/ui.rb:17:in `method_missing'
/Users/kamilharasimowicz/.rvm/gems/ruby-2.5.1/gems/fastlane-2.108.0/fastlane_core/lib/fastlane_core/ui/interface.rb:141:in `user_error!': [!] 2018-12-03 22:54:30.318 submit Crashlytics: Crashlytics.framework/submit 1.4.0 (20) (FastlaneCore::Interface::FastlaneError)
2018-12-03 22:54:34.452 submit Crashlytics: Added Testers/Groups Successfully 200
2018-12-03 22:54:51.808 submit Crashlytics: Unable to submit build. Response code: 0
2018-12-03 22:54:51.829 submit Crashlytics: Failed to upload binary

Environment

### Stack

Key
Value

OS
10.14.1

Ruby
2.5.1

Bundler?
true

Git
git version 2.17.2 (Apple Git-113)

Installation Source
~/.rvm/gems/ruby-2.5.1/bin/fastlane

Host
Mac OS X 10.14.1 (18B75)

Ruby Lib Dir
~/.rvm/rubies/ruby-2.5.1/lib

OpenSSL Version
OpenSSL 1.1.1a  20 Nov 2018

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
10.1

System Locale

Variable
Value

LANG
pl_PL.UTF-8
✅

LC_ALL

LANGUAGE

fastlane gems

Gem
Version
Update-Status

fastlane
2.108.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.2.0

executable-hooks
1.6.0

bundler-unload
1.0.2

rubygems-bundler
1.4.5

bundler
1.16.6

CFPropertyList
3.0.0

public_suffix
2.0.5

addressable
2.5.2

atomos
0.1.3

babosa
1.0.2

claide
1.0.2

colored
1.2

colored2
3.1.2

highline
1.7.10

commander-fastlane
4.4.6

declarative
0.0.10

declarative-option
0.1.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20180417

dotenv
2.5.0

emoji_regex
0.1.1

excon
0.62.0

multipart-post
2.0.0

faraday
0.15.4

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.12.2

fastimage
2.1.5

gh_inspector
1.1.3

jwt
2.1.0

memoist
0.16.0

multi_json
1.13.1

os
1.0.0

signet
0.11.0

googleauth
0.6.7

httpclient
2.8.3

mime-types-data
3.2018.0812

mime-types
3.2.2

uber
0.1.0

representable
3.0.4

retriable
3.1.2

google-api-client
0.23.9

json
2.1.0

mini_magick
4.5.1

multi_xml
0.6.0

plist
3.4.0

rubyzip
1.2.2

security
0.1.3

naturally
2.2.0

simctl
1.6.5

slack-notifier
2.3.2

terminal-notifier
1.8.0

unicode-display_width
1.4.0

terminal-table
1.8.0

tty-screen
0.6.5

tty-cursor
0.6.0

tty-spinner
0.9.0

word_wrap
1.0.0

nanaimo
0.2.6

xcodeproj
1.7.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.0

What happens if you execute the generated command manually on the command line?

I have the same problem. It worked until a few days ago and now my build is failing with the same error despite successful upload.

@janpio I have updated Fastlane to 2.111.0 and it works now.
@SimonSimya FYI


Only white page is loading

Describe the bug
The app is not loading and I only see a white page
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-dbpo1g
Steps to reproduce
Click on preview to see how the app is loading
Expected behavior
I am expecting it to load
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 129
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 73161845,
  "usedJSHeapSize": 69692185,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = agnirudrasikdar
Chat ID = 01bba3e8d909

Additional context
No response

Hi @agnirudrasikdar,
Appreciate the feedback here. We are tracking this issue: #1791. You can follow there for updates. If you continue to have this problem, posting the requested details on that issue page would be helpful. Thanks!