[11.x] Add whenNestedLoaded to ConditionallyLoadsAttributes trait

Dear sir
I have been created a method called whenNestedLoaded for the ConditionallyLoadsAttributes trait.
This method is used to retrieve a nested relationship if it has been loaded.
For example:
if user has a city and city has a country and we want to load the country of the user depending on the city and if no eager loading exists it will return a default value rather than creating a lazy load.
load the UserResource
UserResource::collection(User::query->with('city.country')->get());

use whenNestedLoaded inside the Resource
    public function toArray(Request $request): array
    {
        return [
            'id' => $this->id,
            'name' => $this->name,
            'country_name' => $this->whenNestedLoaded('city.country', fn() => $this->city->country->name, NULL),
        ];
    }

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@taylorotwell
I understand that you are saving the maintenance of the framework but my method is very small and helpful.
If you want to do the given example you will need to do that
    public function toArray(Request $request): array
    {
        return [
            'id' => $this->id,
            'name' => $this->name,
            'country_name' => $this->when(
                      $this->relationLoaded('city') &&
                      $this->city->relationLoaded('country'),
                     fn() => $this->city->country->name, NULL
             ),
        ];
    }

Addition to this example can be very complex for 3 or 4 levels so i think the method whenNestedLoaded will be very helpful to make a clean resource in this case.

Hi @taylorotwell
I understand that you are saving the maintenance of the framework but i asked to give my my method an attention since my method is very small and helpful.
For example if you want to implement the given example with the current version you will need to do that
    public function toArray(Request $request): array
    {
        return [
            'id' => $this->id,
            'name' => $this->name,
            'country_name' => $this->when(
                      $this->relationLoaded('city') &&
                      $this->city->relationLoaded('country'),
                     fn() => $this->city->country->name, NULL
             ),
        ];
    }

In addition to, this example is very simple and can be very complex for 3 or 4 relationship's levels so i think the method whenNestedLoaded will be very helpful to make a clean resource in this case.


Replace "first name" and "last name" fields with single field "name" for all the users of the system.Sweep:

Details
Replace "first name" and "last name" fields with single field "name" for all the users of the system.
Branch
No response

💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: None)

[!TIP]
I can email you when I complete this pull request if you set up your email here!

Actions (click)

[ ] ↻ Restart Sweep

I am currently looking into this ticket! I will update the progress of the ticket in this comment. I am currently searching through your code, looking for relevant snippets.

Step 1: 🔎 Searching
I'm searching for relevant snippets in your repository. If this is your first time using Sweep, I'm indexing your repository. You can monitor the progress using the progress dashboard

🎉 Latest improvements to Sweep:

New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To recreate the pull request edit the issue title or description.
Something wrong? Let us know.


[Airflow] UI Display for Periodic Job

Describe the feature

Show more meaningful info about periodic job
Describe the solution you'd like

show time interval of the periodic job
not show "unreached_event"

Describe alternatives you've considered

Additional context

@bgeng777, @jiangxin369, @wuchaochen, the implementation of periodic job should consider the SubGag, which could support periodic scheduling. IMO, the periodic scheduling for SubGag couldn't work for event bases scheduling.


feat: optimize ecosystem image perf

use react-tool-img https://github.com/wellyshen/react-cool-img for
placeholder support and lazy loading
use logos in ecosystem-list https://github.com/scroll-tech/ecosystem-list served by netlify
placeholder image generated using thumbhash https://evanw.github.io/thumbhash/

CORS issue not solved yet. Currently set to * https://github.com/scroll-tech/ecosystem-list/blob/main/netlify.toml#L10
I tried Netlify edge function but it never worked. Also there's no pay as you go for Netlify edge function and it's limited at 15m/month which means images will broken once we hit the limit.
alternative solutions are

no CORS (current behavior)
allow CORS for scroll.io only, this will break preview and develop sites, which uses (netlify.app)
add a backend service
use other services like Cloudflare worker or AWS lambda


Rename variables

I feel that the variable names are a little too open, and worry that they might conflict in my existing application either now or in the future. I'd like to proprose renaming the variables used within this plugin to avoid clashes.
I realise this is a breaking change, so would need to be included in a new major release.

Sorry for the delay. I am open to this idea. Just a couple things:

Update the package.json and any docs to reflect the current version, so if it gets published to NPM it will be known as a breaking change (eg. 2.0.1 iirc).
Also include the minified data so folks quickly downloading it from source will not get confused or tripped up.

Otherwise, LGTM 👍

@christabor
I've updated the package.json to be v2.0.1. I did run gulp but due to this been a simple change with variable names there were no changes to the outputted CSS file -- which was to be expected. I also see no reference to the variable names in any current documentation.

Should I close this?

Thanks!


Update harbor notes.txt

Issue:
The Notes section states "...you should be able to visit the Harbor portal at https://rancherserver.org..."
It should state the correct endpoint (/registry)
Solution:
Fix the rendering result of Notes.txt file and add line breaks
Related Issues:
https://github.com/rancher/rancher/issues/20735

@gitlawr PTAL, thanks.

LGTM

Stale PR and harbor has been moved out of system-charts.


Setup an instance of Discourse in order to discuss spec sections

On Monday  (krainboltgreene)	 steveklabnik: Is there a possible need for having a discussion board for jsonapi.org? I see error discussion popping up again, but no easy way to detail why the spec came to it's choices.
On Monday  (steveklabnik)	 krainboltgreene: there might be, yeah
On Monday  (krainboltgreene)	 steveklabnik: It'd particularly be nice to have a "See the discussion about this section [here]" bit for each spec section.
On Monday  (steveklabnik)	 hmmm
On Monday  (steveklabnik)	 yeah, that'd be kinda cool
On Monday  (krainboltgreene)	 I've not touched discussion software in quite a while, so should I make an issue for picking the appropriate one?
On Monday  (steveklabnik)	 i can't imagine we'd use anything but Discourse
On Monday  (krainboltgreene)	 Gotcha, alright.
On Monday  (steveklabnik)	 that said, an issue to actually deploy an instance sounds good

Here's a link for the unofficial heroku setup guide.

http://discuss.jsonapi.org/
configuration/update/announcements etc forthcoming.

:confetti_ball:


Implement votes endpoint

implements GET /votes?block_id={block_id} according to #830
(only review after #1026 is implemented)

[x] votes for blocks
[x] tests

Current coverage is 96.16% (diff: 100%)

Merging #1029 into master will increase coverage by 0.07%

@@             master      #1029   diff @@
==========================================
  Files            36         38     +2
  Lines          1787       1824    +37
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1717       1754    +37
  Misses           70         70
  Partials          0          0

Powered by Codecov. Last update b592786...5608a36


Welcome tour animation CPU usage high on Ubuntu 19.10

Super cool project, started playing around with it after hearing it mention on Linux Action News. However, I almost rejected the project out of hand because leaving the web page open pins one of my CPU cores at 100%. Looking into it I found that the welcome tour click-here animation caused the CPU spike (power user: I read man pages, I don't click bouncy animations).
Steps to reproduce:

Log in as a new user.
Idle at the web page (with one of the round animations showing)
Check top (brave wcpu 35%)

I see the issue on my laptop (Haswell laptop, Ubuntu 19.10, Brave and Firefox), but not on my desktop (Haswell desktop, Windows 8.1, Nvidia graphics, Chrome and Firefox).
Moving to another tab makes the CPU usage drop to normal.
Finishing the tour makes the CPU drop to normal.
Is this worth looking further into? I will test on some other systems and see how they respond, and report back here.

I was wondering why my zulip desktop app was causing my computers fans to spin high when there was nothing going on. I saw CPU usage at 20-35% on an 8th generation i7 which I thought was strange.
After going through the tutorials and restarting zulip it is back to low CPU Usage even when idle.
This was with a new account with zulip desktop app running on Windows 10 Pro 1903.

Still experiencing this issue exactly as described above on 5.3.0. Not sure where #13953 was released.


allow shipping changes in paypal component

The paypal component doesn't seem to allow shipping address/option configuration at this moment. Shipping address editing is disabled and there is no way to pass the required callback onShippingChange() as documented here:
https://developer.paypal.com/docs/checkout/integration-features/shipping-callback/#:~:text=The Shipping Change callback is,address they chose on PayPal.
is this something that can be added/customized someway? Any plan to add this like in other components for supporting express checkout using paypal address book?

Hi @fgiust, and thanks for reaching out.
Our integration with PayPal was built with the regular checkout flow as the main focus. Therefore, it's not possible to update an order after it was created. We could, of course, add the onShippingChange callback in our component, but it would only be useful to get the address details. It won't be possible to update the order. Would this still be beneficial for you knowing these limitations?
Let me know, cheers!

Hi @fgiust, and thanks for reaching out.
Our integration with PayPal was built with the regular checkout flow as the main focus. Therefore, it's not possible to update an order after it was created. We could, of course, add the onShippingChange callback in our component, but it would only be useful to get the address details. It won't be possible to update the order. Would this still be beneficial for you knowing these limitations?
Let me know, cheers!

Hi @pabloai,
clear. Well, that could be an useful starting point anyway, obviously the desired goal would be having the whole "express checkout" flow implemented :)
we are currently implementing the paypal express flow with adyen using the old integrations (paypal redirect and hpp), so I hope that what was actually feasible with not deprecated integrations would be migrated to the new one soon or later, this is a pretty common requirement nowaday... don't you see any way to implement it with smart buttons today, even with additional integrations using adyen services?

Hi @pabloai,
clear. Well, that could be an useful starting point anyway, obviously the desired goal would be having the whole "express checkout" flow implemented :)
we are currently implementing the paypal express flow with adyen using the old integrations (paypal redirect and hpp), so I hope that what was actually feasible with not deprecated integrations would be migrated to the new one soon or later, this is a pretty common requirement nowaday... don't you see any way to implement it with smart buttons today, even with additional integrations using adyen services?

@fgiust the onShippingChange event is available from v3.21.0.
That being said, we're not planning to support the Express Checkout flow for PayPal for now, so I'm closing this ticket.
Sorry for the inconveniences. Feel free to reach us out again in the future!


Download of the Exchange PowerShell module does not work using the new Microsoft Edge Version 80.0.355.1 dev (64-bit)

This document identifies that you must use Internet Explorer or Edge to download the Exchange PowerShell module. That is partially correct, but currently the download fails using the new Microsoft Edge browser.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 65e527db-a4c2-782e-5a5f-ad8b3159a977
Version Independent ID: f2de1272-5e37-c59f-fcb9-34fa66b0d268
Content: Connect to Exchange Online PowerShell using multi-factor authentication
Content Source: exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/mfa-connect-to-exchange-online-powershell.md
Service: exchange-online
GitHub Login: @chrisda
Microsoft Alias: chrisda

FYI, I just noticed you already answered this when another user called this out; however, the documentation remains the same, and this is confusing for the type of folk who would read this document. You're talking to IT pros who want to download a PowerShell module, and there's a good chance many of them may be using the Chromium-based Edge already -- it would be better if the docs were clear about which browser(s) are required to download the module.

@officedocsbot assign @yogkumgit

Hi @KirkMunro, thank you for your feedback.
For the time being "Edge browser" in docs.microsoft.com doesn't mean chromium-based version because it's still on Release Candidate state. Edge means EdgeHTML RTM version.
I will add some comment in the document.

@chrisda Please merge this PR #4547 Thanks.

@dariomws306 Thank you very much for the contribution and updating the documentation with PR. @KirkMunro  Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also


removed non transactional bus mode

Coverage increased (+1.9%) to 75.492% when pulling ac233b1c5df9ef9d21a7bf9adcbe034551e8876d on no_no_tx_mode into de202b15737034036110df6cf4212f926e76960f on v1.x.


Render the book images on Cart Page

Description

Help  in achieving the feat by helping @Omafovbe
Expected Behavior

This should be solved https://github.com/legendarykamal/Lets-go-shop/pull/37#issuecomment-1255736054
Screenshots

Environment:

Host OS:
Browser:

@legendarykamal I am testing the website and it shows images of all of the books in the cart. do you need to add more books on the home page? Can you please explain? Can I help with this issue?

@sabakhilji please refer this PR the changes need in that , https://github.com/legendarykamal/Lets-go-shop/pull/37#issuecomment-1255736054

@sabakhilji did you understand the issue well?

Hi, @legendarykamal sorry for the confusion I checked the issue and found that the book json image needs to render on the cart page. Right now the cart page is rendering images directly from files we need to find some way to render images from books .json on the cart page. Can I try to find a solution?

Yes sure do try.
On Mon, Sep 26, 2022, 2:14 AM sabakhilji @.***> wrote:

Hi, @legendarykamal https://github.com/legendarykamal sorry for the
confusion I checked the issue and found that the book json image needs to
render on the cart page. Right now the cart page is rendering images
directly from files we need to find some way to render images from books
.json on the cart page. Can I try to find a solution?
—
Reply to this email directly, view it on GitHub
https://github.com/legendarykamal/Lets-go-shop/issues/42#issuecomment-1257276078,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW33QNHQSUO7FOCWFT3IOR3WAC2TXANCNFSM6AAAAAAQTS375Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


Changed the decimal multiplying factor

so this library can allow numbers such as 14.1 and it still ends up as 14.10. Also added test.
We could not find any reason why this was not been done from the beginning?

probably missed that :cry: thanks for the PR I'll merge it ASAP

I did not do anything with version bumping, but Im not sure what is the right way it should be done with a PR and open source either.

i'll bump the version no prob.


Builder option to disable optional_string/required_string for a single input

I've set up Formtastic with the following options, in an effect to mimic something like the field setup described here (ie. mark fields as optional, rather than required):
  Formtastic::FormBuilder.optional_string = " (optional)"
  Formtastic::FormBuilder.required_string = ""

The only downside of this is that boolean fields always get the optional_string or required_string tacked on the end (see inputs/boolean.rb and inputs/base/labelling.rb). This can sometimes look odd with standalone boolean checkbox fields.
For example:
   File (optional): [ /Users/blah/baz/foo.jpg     ][Browse]

                    [x] Remove file? (optional)

My current workaround is to duplicate the builder and blank the optional_string config manually; this is unfortunately a bit of a hack:
  <%= f.inputs :for => :image do |builder| %>
    <% label_builder = builder.dup %>
    <% label_builder.optional_string = '' %>

    <!-- Regular (file upload) field, with a label displaying as "File (optional)" -->
    <% builder.input :file %>

    <!-- Checkbox field, displaying as: "[x] Remove this file?" -->
    <% label_builder.input :remove_file, :as => :boolean, :label => "Remove this file?"%>
  <% end %>

Maybe an :optional_string => false or similar passed in the builder.input line?
(If I'm doing it wrong I'd appreciate any suggestions as to how to resolve this.)

As useful as this would be, in order to progress I've needed to remove the values for optional_string and required_string completely.
The workaround I'm currently using is to surgically add the " (optional)" text with a CSS label.optional:after{ content: ' (optional)'; } style instead; it works in IE7+, so browser support isn't a problem.
(I'd love to have aria-required="true" for required elements, but that's a subject for another Issue.)


Requirements for Trade Calendar

Need to look into how to generate positive and negative test cases for dates and timestamps since it depends on which days are valid trade days.

We need a tag for data, which takes in account a calendar while generating possible values. The calendar can potentially just reference days of work, holidays and may also reference time for partial days. Indeed is good for us for partial trade days, but there can be other scenarios out there for partial days of work.
Potential options to think of:

Positive and negative generators as with the other tags
min / max here can have a different interpretation, since we can end up with different disjoint ranges of time. A calendar that covers Mon 11/16/15 to Fri 11/27/15 is really two valid ranges from 11/16 to 11/20 and 11/23 to 11/27. It also consists of three disjoint negative ranges.

@musinskj looking into this

@jeanmusinski looking into this

At its simplest, the trade calendar can be implemented using the java Calendar class which returns day of week. Using Calendar, we can implement 3 equivalence classes:

all days
weekdays
weekends

Additionally, using Calendar would enable specifying date ranges, which could be combined with weekdays and weekends.
A simple extension would be to introduce a date list which lists dates as YYY-mm-dd. This list can be used to specify omissions or inclusions.
A full blown implemetation should allow the specification of a trade calendar that is formated to DG specifications. The format may be something like:
(date (YYY-mm-dd), weekday(boolean), holiday(boolean),openTime(hh:mm:ss), closeTime(hh:mm:ss))


Document Mallet operator

Thanks @jridgewell, just a couple of things and this is good to go.

Updated.

Sweet thanks!


UI is not complete

UI is not complete, need more improvement .

Hey @Yashwanthreddy1789,
Could you add more details here ?


WIP: Add double Mach reflection elixir

Add an elixir for the Woodward and Colella double Mach reflection testcase. This also uses the supersonic outflow boundary condition so we could (potentially) move that boundary condition function into the src but for now everything lives in the new elixir.

I tried setting the AMR levels to all be the base size and force the coverage call to only take 1 time step but the time remains quite high (approximately 200s). @ranocha @sloede Is there anything else I should try to reduce the coverage cost? Or should I just set this test to also skip coverage?

I tried setting the AMR levels to all be the base size and force the coverage call to only take 1 time step but the time remains quite high (approximately 200s). @ranocha @sloede Is there anything else I should try to reduce the coverage cost? Or should I just set this test to also skip coverage?

My feeling is that it is probably just too expensive to do with coverage testing enabled. Thus I'd be OK to consider this as a "cauldron" and just test it for results, not coverage.

Yes, please skip_coverage

Sounds good. I will have this test skip_coverage and we will postponed moving the outflow BC till a later time when we have a smaller / simpler example that uses it.


Vue component template bug

Create a Vue template component:
<template>

     {{msg}}

</template>

As a result, the line {{msg}} disappears, although it does not refer to the name of the component.
<template>

</template>

Blueprint uses Handlebars internally, can you try something like:
https://stackoverflow.com/a/20570734

Yes, exactly, your advice helped to correct the error.
Thank you. The issue can be closed.


Including .css files with @import is non-standard behaviour which will be removed in future versions of LibSass.

I had this problem with normalize.css but it also happens with systemize using webpack+sass-loader
@import "systematize";

DEPRECATION WARNING on line 1, column 8 of stdin:
Including .css files with @import is non-standard behaviour which will be removed in future versions of LibSass.
Use a custom importer to maintain this behaviour. Check your implementations documentation on how to create a custom importer.

node-sass: 4.9.2
sass-loader: 7.0.3
webpack 4.15.1

Any suggestion? I'm pretty new on this world.

Hi, sorry, I didn't see this issue somehow.
With Webpack, you can use imports relative to the node_modules dir using the following syntax:
@import '~systematize/systematize'

The default file when you import systematize ('main' in package.json) is set to build/systematize.css, hence the warning.


Presenting clock time in player event values if m3u8 tag is present

Greetings,
Is there any way that I could easily take advantage of the presence of the #EXT-X-PROGRAM-DATE-TIME .m3u8 tag to make sure that my HLS playback is synced up to a timestamp in my UI?
In other words, video recorded at 10:00am EST would be able to playback and notify my JS layer to set the UI timestamp to 10:00 am?
Thanks in advance for any guidance.

Any update on the above would be greatly appreciated. Thanks!

@che-effe We'll explore this and see how feasible is to be implemented

I did in the meantime make a workaround for this by creating a js HLS manifest parser looking through the manifest for the program dates and exposing it through a public property.
**      * Populates programDates with an array of strings matching      * the ISO timestamp pattern      */     _dataParse: function(data) {       this.programDates = [];       var r = new RegExp(/(\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}).+/g);       this.programDates = data.match(r);     }
It works well enough for my needs.


how can i install messenger manually without composer update

Please tell me the files which i have to update manually with out composer install or update as composer update is breaking my application by upgrading other dependencies and laravel version. So i need it to install manually. Please tell me the files i have to update.

Create in your Laravel root directories named ./packages/laravel-messenger for example, then place all the files from this repository in it.
Let's imagine your Laravel root directory is /var/www/com/super-app. Then you'll have /var/www/com/super-app/packages/laravel-messenger/src where all the source files will be stored.

Add to your composer.json file autoload.psr-4 section new namespace:

"Cmgmyr\\Messenger\\": "packages/laravel-messenger/src/"

You'll have something like:
"autoload": {
        "classmap": [
            "database/seeds",
            "database/factories"
        ],
        "psr-4": {
            "App\\": "app/",
            "Cmgmyr\\Messenger\\": "packages/laravel-messenger/src/"
        }
    },

Execute composer dump command to index new namespace.

After this 3 simple steps you are ready to start configuration process.

But keep in mind, that composer.json from custom loaded packages wouldn't be used, then you need to register Cmgmyr\Messenger\MessengerServiceProvider in your ./config/app.php by yourself.

@hassanshuja If this is the case your current composer.json version constraints aren't right. A composer update/install command should NEVER break an installation/setup. If it does you have to be more precise with your versions. If a package doesn't use https://semver.org and you have ^5.3 for example you can specify the last working version like 5.3.7. This is also possible for packages that are required by another dependency as long as all version-constraints don't conflict. So until another package requires ^5.4 everything is fine.
These links should help you.
https://getcomposer.org/doc/03-cli.md#show
https://getcomposer.org/doc/03-cli.md#depends-why-
Why is a working composer.json this important?
Cause if your current setup is destroyed/unusable cause of whatever you will never get your app running.


sonobuoy quick mode seems to be broken in v0.56.6

What steps did you take and what happened:
I am using sonobuoy in my kubernetes pipeline. Today I updated sonobuoy from v0.56.0 to v0.56.6 and executed.
sonobuoy run --wait --mode quick --kubeconfig "$KUBECONFIG" --level panic
The sonobuoy pod is created in the sonobuoy namespace and the pod enters the running state but the run does not finish.
no log outputs with kubectl logs -n sonobuoy sonobuoy
Client-Side:
15:37:41 Waiting for the aggregator status to become Running.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Sonobuoy version: v0.56.6
Kubernetes version: (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.9", GitCommit:"9dd794e454ac32d97cde41ae10be801ae98f75df", GitTreeState:"clean", BuildDate:"2021-03-18T01:09:28Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes installer & version:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):

cat /etc/os-release
NAME="Ubuntu"
VERSION="18.04.5 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.5 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

Sonobuoy tarball (which contains * below)

I am also running
sonobuoy run --wait --kubeconfig "$KUBECONFIG" --mode=non-disruptive-conformance --sonobuoy-image "$PRIVATE_REG"/sonobuoy/sonobuoy:"$SONOBUOY_VERSION" --systemd-logs-image "$PRIVATE_REG"/sonobuoy/systemd-logs:v0.3 --kube-conformance-image "$PRIVATE_REG"/conformance:"$CLUSTER_VERSION" --e2e-repo-config "$E2E_REPO_CONFIG"
and
sonobuoy run --wait --kubeconfig "$KUBECONFIG" --mode=certified-conformance --sonobuoy-image "$PRIVATE_REG"/sonobuoy/sonobuoy:"$SONOBUOY_VERSION" --systemd-logs-image "$PRIVATE_REG"/sonobuoy/systemd-logs:v0.3 --kube-conformance-image "$PRIVATE_REG"/conformance:"$CLUSTER_VERSION" --e2e-repo-config "$E2E_REPO_CONFIG"
At the moment it looks like these are running as usual.

Can you give me the output of:
sonobuoy gen --wait --mode quick --kubeconfig "$KUBECONFIG" --level panic

I just confirmed that I can run quick mode with 56.6 and our CI runs the quick mode as well. Its not obvious what the issue would be if you can run other checks with it.
We obviously take it seriously when a problem can occur with the simplest of the commands though.

Hello @johnSchnake,
thank you for your quick response. The pipeline is running right now with conformance tests enabled. I will send you the output of the mentioned commands tomorrow at the latest. Regarding the Pulled Image, I can't imagine it 100% because the sonobuoy container goes into running status. So from the point of view of kubernetes everything seems to be fine.
For my pipeline it is not so tragic, because I use the quick mode only for a preflight-check in my logic... just thought, should it really be a bug in v0.56.6, then it could hit others too and that would not be nice :)

from the point of view of kubernetes everything seems to be fine.

I'm not positive thats the case; the output from the logs say its in the RUNNING state but there could be nuance to that potentially.
The fact that it never got to the next step of launching plugins and monitoring them means that it stalled out or was unable to update its status. Regardless, quick mode only changes the plugin values and nothing with the aggregator so the fact that the aggregator didnt give any more output points to some other general issue unrelated to e2e/quick mode.
If you can give me the output of gen as discussed above, but if you can repro the issue the most important thing would be the output of sonobuoy logs which will show me what the aggregator is doing. Using the --wait flag effectively keeps polling sonobuoy status but doesnt show all the logs.

Can you give me the output of:
sonobuoy gen --wait --mode quick --kubeconfig "$KUBECONFIG" --level panic

I just confirmed that I can run quick mode with 56.6 and our CI runs the quick mode as well. Its not obvious what the issue would be if you can run other checks with it.
We obviously take it seriously when a problem can occur with the simplest of the commands though.

Command
sonobuoy gen --wait --mode quick --kubeconfig "$KUBECONFIG" --level panic

Output
apiVersion: v1
kind: Namespace
metadata:
  name: sonobuoy
---
apiVersion: v1
kind: ServiceAccount
metadata:
  labels:
    component: sonobuoy
  name: sonobuoy-serviceaccount
  namespace: sonobuoy
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  labels:
    component: sonobuoy
    namespace: sonobuoy
  name: sonobuoy-serviceaccount-sonobuoy
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: sonobuoy-serviceaccount-sonobuoy
subjects:
- kind: ServiceAccount
  name: sonobuoy-serviceaccount
  namespace: sonobuoy
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  labels:
    component: sonobuoy
    namespace: sonobuoy
  name: sonobuoy-serviceaccount-sonobuoy
rules:
- apiGroups:
  - '*'
  resources:
  - '*'
  verbs:
  - '*'
- nonResourceURLs:
  - /metrics
  - /logs
  - /logs/*
  verbs:
  - get
---
apiVersion: v1
data:
  config.json: '{"Description":"DEFAULT","UUID":"","Version":"v0.56.6","ResultsDir":"/tmp/sonobuoy/results","Resources":null,"Filters":{"Namespaces":".*","LabelSelector":""},"Limits":{"PodLogs":{"Namespaces":"kube-system","SonobuoyNamespace":true,"FieldSelectors":[],"LabelSelector":"","Previous":false,"SinceSeconds":null,"SinceTime":null,"Timestamps":false,"TailLines":null,"LimitBytes":null}},"QPS":30,"Burst":50,"Server":{"bindaddress":"<IP_ADDRESS>","bindport":8080,"advertiseaddress":"","timeoutseconds":21600},"Plugins":null,"PluginSearchPath":["./plugins.d","/etc/sonobuoy/plugins.d","~/sonobuoy/plugins.d"],"Namespace":"sonobuoy","WorkerImage":"sonobuoy/sonobuoy:v0.56.6","ImagePullPolicy":"IfNotPresent","ImagePullSecrets":"","AggregatorPermissions":"clusterAdmin","ProgressUpdatesPort":"8099","SecurityContextMode":"nonroot"}'
kind: ConfigMap
metadata:
  labels:
    component: sonobuoy
  name: sonobuoy-config-cm
  namespace: sonobuoy
---
apiVersion: v1
data:
  plugin-0.yaml: |-
    podSpec:
      containers: []
      nodeSelector:
        kubernetes.io/os: linux
      restartPolicy: Never
      serviceAccountName: sonobuoy-serviceaccount
      tolerations:
      - effect: NoSchedule
        key: node-role.kubernetes.io/master
        operator: Exists
      - key: CriticalAddonsOnly
        operator: Exists
      - key: kubernetes.io/e2e-evict-taint-key
        operator: Exists
    sonobuoy-config:
      driver: Job
      plugin-name: e2e
      result-format: junit
    spec:
      command:
      - /run_e2e.sh
      env:
      - name: E2E_EXTRA_ARGS
        value: --progress-report-url=http://localhost:8099/progress
      - name: E2E_FOCUS
        value: Pods should be submitted and removed
      - name: E2E_PARALLEL
        value: "false"
      - name: E2E_USE_GO_RUNNER
        value: "true"
      - name: RESULTS_DIR
        value: /tmp/sonobuoy/results
      - name: SONOBUOY
        value: "true"
      - name: SONOBUOY_CONFIG_DIR
        value: /tmp/sonobuoy/config
      - name: SONOBUOY_K8S_VERSION
        value: v1.18.17
      - name: SONOBUOY_PROGRESS_PORT
        value: "8099"
      - name: SONOBUOY_RESULTS_DIR
        value: /tmp/sonobuoy/results
      image: k8s.gcr.io/conformance:v1.18.17
      imagePullPolicy: IfNotPresent
      name: e2e
      volumeMounts:
      - mountPath: /tmp/sonobuoy/results
        name: results
  plugin-1.yaml: |-
    podSpec:
      containers: []
      dnsPolicy: ClusterFirstWithHostNet
      hostIPC: true
      hostNetwork: true
      hostPID: true
      nodeSelector:
        kubernetes.io/os: linux
      serviceAccountName: sonobuoy-serviceaccount
      tolerations:
      - operator: Exists
      volumes:
      - hostPath:
          path: /
        name: root
    sonobuoy-config:
      driver: DaemonSet
      plugin-name: systemd-logs
      result-format: raw
    spec:
      command:
      - /bin/sh
      - -c
      - /get_systemd_logs.sh; while true; do echo "Plugin is complete. Sleeping indefinitely
        to avoid container exit and automatic restarts from Kubernetes"; sleep 3600; done
      env:
      - name: CHROOT_DIR
        value: /node
      - name: NODE_NAME
        valueFrom:
          fieldRef:
            fieldPath: spec.nodeName
      - name: RESULTS_DIR
        value: /tmp/sonobuoy/results
      - name: SONOBUOY
        value: "true"
      - name: SONOBUOY_CONFIG_DIR
        value: /tmp/sonobuoy/config
      - name: SONOBUOY_K8S_VERSION
        value: v1.18.17
      - name: SONOBUOY_PROGRESS_PORT
        value: "8099"
      - name: SONOBUOY_RESULTS_DIR
        value: /tmp/sonobuoy/results
      image: sonobuoy/systemd-logs:v0.4
      imagePullPolicy: IfNotPresent
      name: systemd-logs
      securityContext:
        privileged: true
      volumeMounts:
      - mountPath: /node
        name: root
      - mountPath: /tmp/sonobuoy/results
        name: results
kind: ConfigMap
metadata:
  labels:
    component: sonobuoy
  name: sonobuoy-plugins-cm
  namespace: sonobuoy
---
apiVersion: v1
kind: Pod
metadata:
  labels:
    component: sonobuoy
    sonobuoy-component: aggregator
    tier: analysis
  name: sonobuoy
  namespace: sonobuoy
spec:
  containers:
  - args:
    - aggregator
    - --no-exit
    - --level=panic
    - -v=0
    - --alsologtostderr
    command:
    - /sonobuoy
    env:
    - name: SONOBUOY_ADVERTISE_IP
      valueFrom:
        fieldRef:
          fieldPath: status.podIP
    image: sonobuoy/sonobuoy:v0.56.6
    imagePullPolicy: IfNotPresent
    name: kube-sonobuoy
    volumeMounts:
    - mountPath: /etc/sonobuoy
      name: sonobuoy-config-volume
    - mountPath: /plugins.d
      name: sonobuoy-plugins-volume
    - mountPath: /tmp/sonobuoy
      name: output-volume
  restartPolicy: Never
  securityContext:
    fsGroup: 2000
    runAsGroup: 3000
    runAsUser: 1000
  serviceAccountName: sonobuoy-serviceaccount
  tolerations:
  - key: kubernetes.io/e2e-evict-taint-key
    operator: Exists
  volumes:
  - configMap:
      name: sonobuoy-config-cm
    name: sonobuoy-config-volume
  - configMap:
      name: sonobuoy-plugins-cm
    name: sonobuoy-plugins-volume
  - emptyDir: {}
    name: output-volume
---
apiVersion: v1
kind: Service
metadata:
  labels:
    component: sonobuoy
    sonobuoy-component: aggregator
  name: sonobuoy-aggregator
  namespace: sonobuoy
spec:
  ports:
  - port: 8080
    protocol: TCP
    targetPort: 8080
  selector:
    sonobuoy-component: aggregator
  type: ClusterIP
---

I added the step back to the pipeline today and now it runs without problems.


added testimonial

I changed the styling of the testimonials section a little bit, because I wasn't sure how display: table works. I added my own testimonial about the project, and if you'd like we can close the old issue and I can create a new one. Let me know what you think!

There was a merge conflict, but I think I resolved it?! I hope I did!

Nice, now we're gonna blow up!


correct output for odo app delete

What is the purpose of this change? What does it change?
Adds Exists function for app which will remove false positives of odo app delete command
Was the change discussed in an issue?
Fixes #1641

How to test changes?
odo app delete myapp -f

Failed to login as developer
++ '[' false == false ']'
++ echo 'Failed to login as developer'
++ exit 1
make: *** [configure-installer-tests-cluster] Error 1

/retest

/approve

/test e2e-core
level=warning msg="Found override for ReleaseImage. Please be warned, this is not advised"
level=info msg="Consuming \"Install Config\" from target directory"
level=info msg="Creating infrastructure resources..."
level=info msg="Waiting up to 30m0s for the Kubernetes API at https://api.ci-op-c7bbrc8t-5186a.origin-ci-int-aws.dev.rhcloud.com:6443..."
level=info msg="API v1.13.4+f1474d8 up"
level=info msg="Waiting up to 30m0s for bootstrapping to complete..."
level=info msg="Make sure ssh-agent is running, env SSH_AUTH_SOCK is set to the ssh-agent's UNIX socket and your private key is added to the agent."
level=info msg="Use the following commands to gather logs from the cluster"
level=info msg="ssh -A<EMAIL_ADDRESS>'/usr/local/bin/installer-gather.sh <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>'"
level=info msg="scp core@<IP_ADDRESS>:~/log-bundle.tar.gz ."
level=fatal msg="failed to wait for bootstrapping to complete: timed out waiting for the condition"

same error as above
/retest

/lgtm

/retest
[odo]  ✗  Unable to connect to OpenShift cluster, is it down?

https://github.com/openshift/odo/issues/1638


Add support for escaping new Discord markdown features: headings, bullet list, numbered list

Thanks you for contributing!

Will you be publishing the package to npm?

When i am able to, yes, sorry for the late reply...


Reduce the size of the dependency

I am using version 4.9.0-release.3 in a browser environment with Vite bundling. There is a base64 file in the browser network that is almost 7.5MB in size and has the format octet-stream. How can I reduce the size of the dependency?

You can enable compression (e.g. gzip) on the server side to reduce the network transfer size. However, reducing the size of this library is not a plan.


feat: two-factor authentication - verify

What does this Pull Request Do?
This PR is about verifying a two factor authentication code for additional layer of security.
How should this be manually tested?
As an authenticated user, send a POST request to /api/v1/auth/2fa/verify with a request body as below:
{
    "totp_code": "123456"
}

Checklist of what you did

[x] Implemented endpoint to verify the TOTP for 2fa authentication.
[x] Generate and store backup codes
[x] Returned success message with the right response payload.
[x] Added unit tests for the auth service

Issue Link: Issue 266

@buka4rill awaiting your review

2fa no longer supported


netlify dev could not connect to target server after long time out

Describe the bug
The netlify dev command correctly starts the gatsby server on port 8000, which is then running correctly.
The most common scenario is there is a long pause (>10 minutes) then dev server says it can't connect to port 8000 and exits with an error code of 1. On one occasion it connected correctly (after the same long wait).
At some point a few months ago this was working fine, unsure which dependency/environment/cli change has broken it.
To Reproduce
Steps to reproduce the behavior:

Run git clone private git repo
Navigate to the cloned repository
Run netlify dev
See that the CLI exits with an error

Bear with me while I work on this. A discussion about this issue might help me or other people. Not at all easy to reproduce bugs with such complicated systems, e.g. do I need to set up another copy of WordPress for this reproduction? Please, tell me no...
Configuration

If possible, please copy/paste below your netlify.toml.
Please enter the following command in a terminal and copy/paste its output:

$npx envinfo --system --binaries --npmPackages netlify-cli --npmGlobalPackages netlify-cli

  System:
    OS: macOS 11.6
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 16.10.0 - ~/.asdf/installs/nodejs/16.10.0/bin/node
    Yarn: 1.22.15 - /usr/local/bin/yarn
    npm: 7.24.0 - ~/.asdf/installs/nodejs/16.10.0/bin/npm

Expected behavior
Expecting dev server to connect to localhost:8000 shortly after gatsby has finished processing and has opened a port.
CLI Output
You can now view my-project-name in the browser.

  http://localhost:8000/

View GraphiQL, an in-browser IDE, to explore your site's data and schema

  http://localhost:8000/___graphql

Note that the development build is not optimized.
To create a production build, use gatsby build

success Building development bundle - 97.505s

info  gatsby-source-wordpress  Watching for WordPress changes
success Writing page-data.json files to public directory - 1.692s - 147/147 86.87/s
success write out requires - 0.141s
[ LONG WAIT AT THIS POINT ]
◈ Netlify Dev could not connect to localhost:8000.
◈ Please make sure your framework server is running on port 8000
Waiting for the debugger to disconnect...
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Waiting for the debugger to disconnect...

Process finished with exit code 1

Additional context
Is netlify dev waiting for some kind of signal/event from the child process to connect, or is it polling on a regular basis?
NB the output log above is running with the debugger but it fails in the same way without the debugger.

I have this issue again with all Netlify cli versions I've tried:
# homebrew global install
netlify-cli/8.13.0 darwin-x64 node-v16.10.0

# devDep (before upgrade)
netlify-cli/8.17.3 darwin-x64 node-v16.10.0

# devDep (after upgrade)
netlify-cli/9.4.0 darwin-x64 node-v16.10.0

Each time gatsby (v3) finishes with:
info  gatsby-source-wordpress  Watching for WordPress changes
success Writing page-data.json files to public directory - 3.865s - 149/149 38.55/s
success write out requires - 0.025s

Then I get after a long pause:
◈ Netlify Dev could not connect to localhost:8000.
◈ Please make sure your framework server is running on port 8000
error Command failed with exit code 1.

It's possible that gatsby is at fault. Open to ideas on how to debug this dialogue between the two platforms.

having the exact same problem on node v17.5.0, gatsby 4.11.2 and netlify-cli ^9.13.2

Nope, same issue here on SvelteKit.

I moved to gatsby cloud, netlify got unusable for me since no update deploys or redeploys of old commits where possible anymore..

Solved the issue for me, having an index.js placeholder in src/pages/ (as i usually only used src/pages/de/ with locale redirect: domain.com/de/)
const IndexPage = () => {
  return ""
}

export default IndexPage

Having the same time out issue with stopping Netlify dev server when 10 or so minutes passed.
I'm using Netlify dev server for functions and Vite as web server. netlify-cli/10.1.0 win32-x64 node-v17.3.0

For some reason my problem has been resolved by enabling my VPN service on my computer / switching from on network to the other. It seems unrelated since you're running a localhost server but I thought to mention it here anyway.

Some of these issues should be fixed now as of version 12.0.2. If it still appears please reopen with an example.


Inconsistent scores for humaneval

The scores measured on the 1.5B base model are as follows
"humaneval": {
"pass@1": 0.34146341463414637
},
"config": {
"prefix": "",
"do_sample": false,
"temperature": 0.2,
"top_k": 0,
"top_p": 0.95,
"n_samples": 1,
"eos": "",   # is < unk >
"seed": 0,
What parameters do I need to modify to achieve？？

We report the results with the temperature = 0.0, which means the greedy decoding.
Meanwhile, we have updated the evaluation tools so that you can reproduce the results in OpenCodeEval.

If I want to perform humanEval on other models using OpenCodeEval, do I need to modify the eos or prompt in this OpenCodeEval.
The evaluation of tinyllama-v1.1 using humaneval in OpenCodeEval found that the result was very low, only 1.

Usually there are two ways to evaluate the coding model: temperature = 0.2 with samples = 20, or temperature = 0.0 with samples = 1. You should choose the arguments carefully @fxnie


The new HTTP/2 protocol

Description:
The new version of HTTP protocol is coming!
HTTP 1.1 forced both developers and browser vendors to invent different tricks in order to make sites to load and run faster. HTTP/2 will provide significant improvements overt HTTP 1.1 and many of these tricks will become unnecessary. On their place, Web developers will introduce new ways for optimizing the pages.
In this talk I will give an introduction the protocol and emphasize why is it so important for the Web development workflow.
Bio:
Iliyan Peychev is a Software Engineer and UI Infrastructure Lead in Liferay Inc. He started as C developer fourteen years ago, when he was writing software for banks and other financial institutions. Then he became Java developer working in the area of SmartCards and Security. Since 2007 Iliyan is fully devoted to JavaScript and Front-End development. He is highly interested in Server-side JavaScript (NodeJS), Networking and real time data processing. Performance obsessed.

Hi, sounds like an advanced talk. We will probably schedule it for April, and will let you know with some weeks in advance. One thing: the talk is in English, right? Cool! We need more of those :)

April is even better, and please, let's schedule it after April, 15.
Yes, it will be in English. I can speak more or less Spanish, but for technical stuff, I prefer English.
Thanks,

Hi Iliyan,
I am going to propose April 30th for this talk. Can you send me your email address to<EMAIL_ADDRESS>Thanks!


[DOUBT] Buttons are not visible in light mode

Hey I was trying out the theme today (looks really clean by the way :D) and saw that the light mode hides the buttons. I wanted to know whether this is intentional or not as they are visible with the dark theme.
I switched between the themes by manually setting the default value in the partials/header.html file.
Light Mode:

Dark Mode:

Okay so I've figured out what the issue was.
Disabling or moving this piece of code to dark.scss file fixes the issue:
@media (prefers-color-scheme: dark) {
  .social > img {
    filter: invert(1);
  }
}

Not sure why but this property is being applied even when we set "light" as the theme value.
I removed the @media call and just added the rest of the code as it is into the root element and that worked.

Thanks for investigating this! Feel free to create a pull request with the changes.

Cool, will do that! Also, I had forked the repo to make some other modifications to theme as per my liking, one of which is adding a toggle button, similar to the one in Archie-zola. I have used the icon logic from there but the underlying logic is a bit different.
Would you be interested in having this functionality in the Apollo theme? If so, I can create a PR with this logic in place, else I can make the PR with just the changes for the icon visibility.
Here's the link to my fork's branch with the code.
Here's screenshots of the toggle button:
light theme:

dark theme:

Thanks!

hey, any update regarding this?

Sorry, didn't see the message and was busy with university. I'd love to have a theme toggle button! :D

created the PR 👍


htop crashing

While running htop and moving mouse (especially hovering over some text or when randomly some text "jumps under" cursor) the htop window just closes.
While being ssh-ed into my Raspberry Pi when this happens, some escaped character sequence get's printed.
Tested on Linux Mint 19.3, Cinnamon, latest deb package. Windows version works just fine, but htop doesn't seem to care about mouse there.

Thanks! Turns out the terminal was incorrectly sending also mouse movement events which htop does not process.


feat: support fields

Closes https://github.com/riok/mapperly/issues/262

Codecov Report

Merging #346 (d332a2b) into main (dce4b42) will increase coverage by 0.14%.
The diff coverage is 91.91%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   91.71%   91.86%   +0.14%
==========================================
  Files         109      120      +11
  Lines        3379     3747     +368
  Branches      438      508      +70
==========================================
+ Hits         3099     3442     +343
- Misses        189      208      +19
- Partials       91       97       +6

Impacted Files
Coverage Δ

src/Riok.Mapperly.Abstractions/MapEnumAttribute.cs
100.00% <ø> (ø)

...berMappings/MemberNullDelegateAssignmentMapping.cs
57.14% <0.00%> (ø)

.../Mappings/NewInstanceObjectFactoryMemberMapping.cs
100.00% <ø> (ø)

...Mapperly/Descriptors/UserMethodMappingExtractor.cs
98.38% <50.00%> (ø)

...riptors/MappingBuilders/QueryableMappingBuilder.cs
68.42% <68.42%> (ø)

...Descriptors/Mappings/EnumFromStringParseMapping.cs
73.68% <73.68%> (ø)

...ptors/Mappings/MemberMappings/NullMemberMapping.cs
76.27% <76.27%> (ø)

src/Riok.Mapperly/Symbols/FieldMember.cs
78.57% <78.57%> (ø)

src/Riok.Mapperly/Symbols/PropertyMember.cs
78.57% <78.57%> (ø)

...lders/NewInstanceObjectMemberMappingBodyBuilder.cs
80.17% <80.17%> (ø)

... and 54 more

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Font bad quality

VSCode Version:1.5-1.71 (didn't tested on <1.5)
OS Version:Windows 7

Oh - Same as #11252
Steps to Reproduce:

"editor.fontSize": 13,
"editor.fontWeight": "normal",
"editor.fontFamily": "Courier New"
Courier New - In every editor
For check - open png in new window
VSCode (bugged)

Visual Studio

Notepad

Notepad++

Google Chrome (bugged)

Opera (bugged)

Mozilla

Webkit problem?
In editor.fontWeight only "normal" & "bold" works
"bold" - is too bold

@justnonamenoname  indeed, all our font rendering is done by Chromium, and they have their own implementation (doesn't use the OS font APIs AFAIK). Please search for an existing / create an issue against Chromium at https://bugs.chromium.org/p/chromium/issues/list and link to it here.

https://bugs.chromium.org/p/chromium/issues/detail?id=663706

In chrome & opera this fix problem, but in vs 400 don't work
font-weight: 400;

@justnonamenoname Thank you. VS Code is currently on Chromium 52. It is possible that the Chrome or Opera versions you are trying on are using a newer Chromium version. Once we update to a newer Electron version, we will get a newer Chromium version thus bringing the same behaviour

In atom I found these styles help a lot, trying to figure out a way to apply it to VS Code as in comparison to Atom (that has these styles applied) the font rendering for Monoid Retina is blurry:
// make text look better
.platform-darwin .workspace  {
	-webkit-font-smoothing: none;
	-webkit-font-smoothing: antialiased;
	-webkit-font-smoothing: subpixel-antialiased;
	// -webkit-text-stroke: 0.015em;
	text-rendering: auto;
	text-rendering: optimizeSpeed;
	text-rendering: optimizeLegibility;
	text-rendering: geometricPrecision;
}

Todays VS Code insider build comes with Electron 1.6.x, would be interesting to hear if this update solves this issue for anyone: http://code.visualstudio.com/Download#insiders

problem still here

This is an upstream issue (possibly within Chromium), and there are no known workarounds that we could implement on our side. This means there is no possible code change for us to do in VS Code sources to improve things.
To keep the number of issues in our inbox at a manageable level, we’re closing issues that have been on the backlog for a long time but haven’t gained traction or that are not actionable. Thank you for your time and understanding.


[ONNXTransform] always delete orphaned node branches after running an onnx transform

adds a pass in the base ONNXTransform cleanup steps to run ONNXGraph.delete_orphaned_node_branches which is an important additional cleanup step.  This removes unwanted nodes from remaining in the graph after a transform which could lead to issues at inference time.  This function should be safe to run against all transforms and only adds minimal overhead (O(nodes^2)) if any orphaned nodes are found
should fix issues in KVCache injected MPT models which seem to consistently get shipped with orphaned nodes remaining
test_plan:
verified locally that this unblocked running a pipeline with zoo:nlg/text_generation/mpt-7b/pytorch/huggingface/mpt_chat/base-none
future testing should pull down a model with no data files and test injection against it

tests fixed, merging


Add new content

If you know anything related to the current sections you can add.

Another useful resource for web development is mozilla developer network. check out - https://developer.mozilla.org/en-US/docs/Learn

Added. Thanks @nimiTheWinner

https://www.pluralsight.com/ offers high quality courses related to Software Development

Thanks @bartMoskala

https://www.tutorialspoint.com/ has good tutorials on not just web development but programming and databases.

For data science I suggest this very good site https://www.datasciencecentral.com/ which is my default  news feed for things related to big data, machine learning and more

@AjaxianK thanks. It's really a nice resource.

For web developer FreeCodeCamp is a big opportunity because you'll learn by doing projects , earn free certificates, get experience by coding for nonprofits.
https://www.freecodecamp.org

Hai @anu0012  great thought  👍 .
I think CS50 course will be very helpful for establishing all the fundementals of computer science. Many other free courses are also available in the edx 's website.
we  just need to :

search for a course
enroll
learn
Hope this is useful....

CodePen is an online community for testing and showcasing user-created HTML, CSS and JavaScript code snippets. It functions as an online code editor and open-source learning environment, where developers can create code snippets, called "pens," and test them.

In Field of Web Development specially HTML & CSS check out this site
Learn to Code HTML & CSS great content for HTML &CSS.
You can add DevDocs an open source documentation for all popular language, technology.

Hi I am ajay
I guess the courses related to Algorithms in coursera are very good which is handeled by  princenton university
The course name are Algorithms Part1 and Algorithms Part 2 which are free to watch
https://www.coursera.org/learn/algorithms-part1/home/info
coursera.org/learn/algorithms-part2?


feat: Added temperature and TopT

Added topT and Temperature fields in splitandembed.ts
Added the slider in the front end as well

question - What would the Min and Max limits for temperature be?

There was a hydration error being produced from the linkedSlider. I worked my way around it for now.

Here's another explanation: https://community.openai.com/t/cheat-sheet-mastering-temperature-and-top-p-in-chatgpt-api-a-few-tips-and-tricks-on-controlling-the-creativity-deterministic-output-of-prompt-responses/172683


add nix flake

Adds dev shells with

zig 0.11.0
zig master

Thanks for the work but I'm closing this, see this comment for the reasoning.


Eventhub annotation

Added required annotations.
Moved EventData,  EventHubProperties, EventPosition, PartitionProperties, ProxyAuthenticationType, ProxyConfiguration and SendOptions to models namespace.

I believe you're missing EventHubProducerOptions and EventHubConsumerOptions in the annotations.

I believe you're missing EventHubProducerOptions and EventHubConsumerOptions in the annotations.

Not sure if any of the annotations would apply.  We could have @Fluent but for that, we will have to move those files to model dir, should that be fine?

I believe you're missing EventHubProducerOptions and EventHubConsumerOptions in the annotations.

Not sure if any of the annotations would apply. We could have @Fluent but for that, we will have to move those files to model dir, should that be fine?

It's not the case that fluent APIs need to be just in the models package. They can be anywhere, but will definitely be most common in models.

It's not the case that fluent APIs need to be just in the models package. They can be anywhere, but will definitely be most common in models.

@JonathanGiles  Is this also true for @Immutable ?

It's not the case that fluent APIs need to be just in the models package. They can be anywhere, but will definitely be most common in models.

@JonathanGiles Is this also true for @Immutable ?

Yes, we don't need to move things into model for them to qualify for being immutable, it is just the case that most immutable things are model classes.

should I also consider moving EventHubsConsumerOptions and EventsHubsProducerOptions to models dir?

should I also consider moving EventHubsConsumerOptions and EventsHubsProducerOptions to models dir?

That's up to @conniey. It probably makes sense.

should I also consider moving EventHubsConsumerOptions and EventsHubsProducerOptions to models dir?
That's up to @conniey. It probably makes sense.

I have no qualms moving EventHubConsumerOptions and EventHubProducerOptions to the models directory. 👍


Handle AuthAlreadyAssociated error in django-social-auth

Details here.

This was important for 23andMe but may also be important for RunKeeper.


KAJS - Dead-simple Javascript

I thought my KAJS javascript engine would be a good fit for "Templating", although not 100% sure...
KAJS has many features, such as implicit variable declaration, an ruby-like @ shortcut for this, and optional () for functions!

Thanks for the suggestion, but I don't think this is a good fit :)

It's ok :)
Just keep developing...


fc-match for mac ?

i have a need for supporting outputting in many formats and so this code base looks like the "dogs bollocks" as they say, but when trying the examples on a mac, i kept on hitting the need to have  fc-match.
i am on mac.

From my limited googling it looks like fc-match is a Linux only lib, and hence why there is no brew install etc :)

Yes I agree, we should use something more OS-agnostic. Two alternatives I've found are https://github.com/adrg/sysfont and https://github.com/flopp/go-findfont. I particularly find the sysfont one useful. I will look into integrating one of them!

yep that fixes some of the issues compared to the initial issue line above ..
master branch.

ex-run-doc:
	# panic: invalid font data
	cd $(EX)/document && go run .

ex-run-gio:
	# ! panic: invalid font data
	cd $(EX)/gio && $(MAKE) all

ex-run-chart:
	# :)
	cd $(EX)/go-chart && go run .

ex-run-opengl:
	# ! ../../text/fribidi_cgo.go:8:10: fatal error: 'fribidi.h' file not found
	cd $(EX)/opengl && $(MAKE) all

ex-run-map:
	# :)
	cd $(EX)/map && go run .

ex-run-html:
	# :)
	cd $(EX)/html-canvas && $(MAKE) all

The OpenGL example was using the CGO bindings of FriBidi, which you apparently don't have installed. I've reverted the default to the native Go implementation.
As to the invalid font data panics, hopefully the Gio one is fixed, but could you please run the following and send me the font binary file? There seems to be a bug in the font parser for the document example.
package main

import (
	"fmt"

	"github.com/adrg/sysfont"
)

func main() {
	finder := sysfont.NewFinder(&sysfont.FinderOpts{
		Extensions: []string{".ttf", ".otf", ".ttc", ".woff", ".woff2", ".eot"},
	})
	font := finder.Match("NimbusRoman-Regular")
	fmt.Println(font.Filename)
}

This prints a file path, can you please send the binary to me somehow?

Please let me know at least the font name that the script above prints, to be able to reproduce and fix this issue ;-)

@gedw99 Whenever you have time, please let me know the output of the following script. I'd like to fix this bug! ;-)
package main

import (
	"fmt"

	"github.com/adrg/sysfont"
)

func main() {
	finder := sysfont.NewFinder(&sysfont.FinderOpts{
		Extensions: []string{".ttf", ".otf", ".ttc", ".woff", ".woff2", ".eot"},
	})
	font := finder.Match("NimbusRoman-Regular")
	fmt.Println(font.Filename)
}

@tdewolff
here you go 👍

go mod tidy
go: finding module for package github.com/adrg/sysfont
go: found github.com/adrg/sysfont in github.com/adrg/sysfont v0.1.2
➜  examples git:(main) ✗ go mod tidy
➜  examples git:(main) ✗ go run .
/System/Library/Fonts/Supplemental/Hoefler Text.ttc
➜  examples git:(main) ✗ go version
go version go1.16.4 darwin/amd64

Looks like it got what it thought was the closed match for my mac  ?
wanted: https://en.wikipedia.org/wiki/Nimbus_Roman_No._9_L
found: https://en.wikipedia.org/wiki/Hoefler_Text

@tdewolff
i am using tinygo wasm and fair bit these days and figured its worth checking the github.com/adrg/sysfont lib.
In https://github.com/tdewolff/canvas/tree/master/examples/html-canvas, i modified the make file to add:

all:
	GOARCH=wasm GOOS=js go build -o lib.wasm .
	cp "$$(go env GOROOT)/misc/wasm/wasm_exec.js" .
	go run serve.go

all-tinygo:
	tinygo build -o lib.wasm .

then:
make all-tinygo
tinygo build -o lib.wasm .
# github.com/adrg/xdg
../../../../../../../../../../pkg/mod/github.com/adrg/xdg@v0.3.3/paths_unix.go:18:87: Getuid not declared by package os
../../../../../../../../../../pkg/mod/github.com/adrg/xdg@v0.3.3/utils.go:59:16: MkdirAll not declared by package os
../../../../../../../../../../pkg/mod/github.com/adrg/xdg@v0.3.3/utils.go:59:33: ModeDir not declared by package os
make: *** [all-tinygo] Error 1

i raised this https://github.com/tdewolff/canvas/issues/88 so that you can get CI working on all OS's.
I have never sniffed for fonts etc on github ci servers, so dont know how it will behave..

I've raised the TinyGo issue at https://github.com/adrg/sysfont/issues/7. Let's keep the CI stuff in #88 ;-)
I've fixed some issues in parsing the Hoefler font, but it seems that the Go native HarfBuzz implementation doesn't like TTCs. Using go build --tags harfbuzz it works, I'm working on a way of extracting a font from a TTC (easy)

I suspect  that the tinygo compile issues are not really his fault.
The wasm tinygo environment has no OS underneath it with respect to a file system so it might be a bit harsh.
there is a project where a OS layer for golang wasm to compile agai at has been created for running in the browser . I can dig it out.
then there is the WASI OS ( so to speak ) which tinygo ( and rust etc ) support as a standard . I might look into what OS std / primitives it provides .
Wasm is still hard work :)

I've finalized extracting a font from a collection, it should now all work! If not, please reopen.
PS: see the response from Adrian regarding the TinyGo stuff :-)


how to run scripts/render_synthetic_data.py?

python3 scripts/render_synthetic_data.py
--data_path DST3D/train
--model_path /path/to/all_dst_models
--shapenet_path /path/to/ShapeNetCore.v2
--objaverse_path /path/to/objaverse_models
--omniobject3d_path /path/to/OpenXD-OmniObject3D-New
--synsets n02690373
--workers 48
--num_samples 2500
--disable_random_distance
I want to know, what data should be placed in the following paths?
I don't see it in readme and install.

/path/to/all_dst_models
/path/to/objaverse_models
/path/to/OpenXD-OmniObject3D-New

Hi Shuyuan,
Sorry for the confusion. There is a minor issue with our released data. A patch has been pushed to fix this.
Specifically:

--model_path should be the path to this CSV file.
--objaverse_path could be some empty directory where Objaverse models will be downloaded to this directly automatically.
--omniobject3d_path should be the path to OpenXD-OmniObject3D-New. You will find this directory once you download the OmniObject3D dataset.

Let me know if this answers your question.


Update gradle versions. Remove sdk tags from AndroidManifest.xml. Reformat AndoridManifest.xml.

Update gradle versions.
Remove sdk tags from AndroidManifest.xml.
Reformat AndoridManifest.xml.

Please do not issue pull requests on this repository.

You don't accept pull requests for your code?
On Oct 4, 2015 12:20 PM, "Mark Murphy"<EMAIL_ADDRESS>wrote:

Please do not issue pull requests on this repository.
—
Reply to this email directly or view it on GitHub
https://github.com/commonsguy/cw-omnibus/pull/26#issuecomment-145363715.

No, particularly on this repository, for a long list of reasons.


⚠ Processors has degraded performance

In 0cc5620, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 113 ms

Resolved: Processors performance has improved in e33fcc0.


It seems that the settings.xml file is not taken into account when downloading dependencies

Describe the bug
A clear and concise description of what the bug is.
At work we use a private repository for maven artifacts and we need credentials for that.
It seems that this is not taken into account bu the scan.
When I add the <repository>  tag to the pom.xml it does try to use it but then the credentials fail as they still come from the settings.xml file and it fails on a 401.
It might also be that the Server settings in the settings.xml do not work with username and password but with:
<server>
            <id>gitlab-maven</id>
            <configuration>
                <httpHeaders>
                    <property>
                        <name>Private-Token</name>
                        <value>TOKEN_HERE</value>
                    </property>
                </httpHeaders>
            </configuration>
        </server>

SBM Version
local build version v0.15.2-SNAPSHOT
SBM Application
shell
To Reproduce
Steps to reproduce the behavior:
1 scan any project without  tag in the pom but with different settings.xml configuration settings and credentials set in a settings-security.xml file end credentials in the settings.xml file

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
downloading of the dependencies in the pom should work from the provided repo in the settings.xml and not from the pom or the default maven repo.
Or a way to configure which repo to use with which credentials
Stacktrace
If applicable, add the (sanitized) stacktrace here.
Caused by: org.openrewrite.maven.MavenDownloadingExceptions
at org.openrewrite.maven.MavenDownloadingExceptions.append(MavenDownloadingExceptions.java:47)
at org.openrewrite.maven.tree.MavenResolutionResult.resolveDependencies(MavenResolutionResult.java:184)
at org.openrewrite.maven.MavenParser.parseInputs(MavenParser.java:124)
... 30 more
Suppressed: org.openrewrite.maven.MavenDownloadingException: REDACTED failed. Unable to download POM. Tried repositories:
REDACTED: HTTP 401
https://repo.maven.apache.org/maven2: Did not attempt to download because of a previous failure to retrieve from this repository.
at org.openrewrite.maven.internal.MavenPomDownloader.download(MavenPomDownloader.java:561)
at org.openrewrite.maven.tree.ResolvedPom.resolveDependencies(ResolvedPom.java:579)
at org.openrewrite.maven.tree.ResolvedPom.resolveDependencies(ResolvedPom.java:502)
at org.openrewrite.maven.tree.MavenResolutionResult.resolveDependencies(MavenResolutionResult.java:179)
... 31 more
Suppressed: org.openrewrite.maven.MavenDownloadingException: REDACTED failed. Unable to download POM. Tried repositories:
REDACTED: HTTP 401
https://repo.maven.apache.org/maven2: Did not attempt to download because of a previous failure to retrieve from this repository.
at org.openrewrite.maven.internal.MavenPomDownloader.download(MavenPomDownloader.java:561)
at org.openrewrite.maven.tree.ResolvedPom.resolveDependencies(ResolvedPom.java:579)
at org.openrewrite.maven.tree.ResolvedPom.resolveDependencies(ResolvedPom.java:502)
at org.openrewrite.maven.tree.MavenResolutionResult.resolveDependencies(MavenResolutionResult.java:179)
... 31 more
Suppressed: org.openrewrite.maven.MavenDownloadingException: REDACTED failed. Unable to download POM. Tried repositories:
REDACTED: HTTP 401
at org.openrewrite.maven.internal.MavenPomDownloader.download(MavenPomDownloader.java:561)
at org.openrewrite.maven.tree.ResolvedPom.resolveDependencies(ResolvedPom.java:579)
at org.openrewrite.maven.tree.ResolvedPom.resolveDependencies(ResolvedPom.java:502)
at org.openrewrite.maven.tree.MavenResolutionResult.resolveDependencies(MavenResolutionResult.java:179)
... 31 more
Desktop (please complete the following information):

OS: [e.g. Windows]
Version [e.g. 10]

MacOs M1
Additional context
Add any other context about the problem here.

Hi @IvoNet
That's correct, sorry for the inconvenience. This is tracked in #880 and will be added to the new parser component.
See #859


codeInputHighlightStyle apply for all fields issue fix

Could you please merge this? Highlight is not working as expected! @DavidHobbs @josinewong

Thanks for he PR!
One question, you're removing something from PR #27.
Is there a reason for that?

Yes, it's making the input highlighted when it's not on focus.

Can you please elaborate on that?
Reason is, we're removing something someone else added.

Yeah, without this property the input code highlighted feature works. I mean the previous version. Remove it to work that feature as before. I checked all other things as well. No harm for any other feature and works perfectly. If you need more elaboration please let me know

I think this was added to that clear input feature thing. Now it also works now without this condition in that line.


fix French translation of pane:close

The original translation meant "close tab," not "close pane," which was misleading since pane:close closes all the tabs in the selected pane, not just the visible tab (which is what tab:close-tab does).
This PR/Translation is about #ISSUE_NUMBER.
files translated:

[ ] def/--LOCALE-CODE--/about.cson
[x] def/--LOCALE-CODE--/context.cson
[ ] def/--LOCALE-CODE--/menu_darwin.cson
[ ] def/--LOCALE-CODE--/menu_linux.cson
[ ] def/--LOCALE-CODE--/menu_win32.cson
[ ] def/--LOCALE-CODE--/settings.cson
[ ] def/--LOCALE-CODE--/welcome.cson

validation

[ ] I've validated my translation locally by running

npm run validation -- --locale MY_LOCALE

@DThought thanks for taking time caring this detail 👍
This will be merged soon.
TODO for myself

[ ] add contributor to CODEOWNER, README


Contributors Section At Bottom of Page

I went ahead and added everyone on https://github.com/mikebryant/ac-nh-turnip-prices/graphs/contributors and their respective GitHub page as the link.

Also, I have no idea why my commits are just now coming in, this PR was based on the Master branch after PR #67

Are you sending the wrong branch for pull request? The "Files changed" looks completely unrelated to the PR title and only have some unrelated changes.

It is fixed now. I also was very confused by "100+ lines changed" for a very small edit!

I don't fully understand why I don't show up as a contributor, but oh well!

I would consider using this endpoint to make a real-time fetch to the repo to get the contributors list. It sucks that it will forever not include some people (like me!) but this will make it so we don't have to constantly update the list every time someone contributes.
https://api.github.com/repos/mikebryant/ac-nh-turnip-prices/contributors

@theRTC204 It looks like it does include everyone - the API matches up with git log - it's not caring where commits came from as far as I can tell
m@lt:~/go/src/github.com/mikebryant/ac-nh-turnip-prices$ git log | grep Ryan
Author: Ryan Carbotte<EMAIL_ADDRESS>Author: Ryan Carbotte<EMAIL_ADDRESS>Author: Ryan Carbotte<EMAIL_ADDRESS>Author: Ryan Carbotte<EMAIL_ADDRESS>
$ curl https://api.github.com/repos/mikebryant/ac-nh-turnip-prices/contributors | jq '.[1]'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 11715  100 11715    0     0  38159      0 --:--:-- --:--:-- --:--:-- 38159
{
  "login": "theRTC204",
  "id": 6956413,
  "node_id": "MDQ6VXNlcjY5NTY0MTM=",
  "avatar_url": "https://avatars0.githubusercontent.com/u/6956413?v=4",
  "gravatar_id": "",
  "url": "https://api.github.com/users/theRTC204",
  "html_url": "https://github.com/theRTC204",
  "followers_url": "https://api.github.com/users/theRTC204/followers",
  "following_url": "https://api.github.com/users/theRTC204/following{/other_user}",
  "gists_url": "https://api.github.com/users/theRTC204/gists{/gist_id}",
  "starred_url": "https://api.github.com/users/theRTC204/starred{/owner}{/repo}",
  "subscriptions_url": "https://api.github.com/users/theRTC204/subscriptions",
  "organizations_url": "https://api.github.com/users/theRTC204/orgs",
  "repos_url": "https://api.github.com/users/theRTC204/repos",
  "events_url": "https://api.github.com/users/theRTC204/events{/privacy}",
  "received_events_url": "https://api.github.com/users/theRTC204/received_events",
  "type": "User",
  "site_admin": false,
  "contributions": 4
}

Closing in favour of #84

Oh, yeah I figured out a way to link my commits to the project. I misunderstood the docs, and the problem actually was my email address after all.


Update default port for karavi-topology & typos

Description
Add default port for karavi topology and fix broken links
Checklist:

[x] I have performed a self-review of my own changes.

@coulof: Thank you for submitting your pull request!
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at<EMAIL_ADDRESS>


[PINOT-3464] Set the download url correctly in committing LLC segments

Current coverage is 55.66% (diff: 100%)

No coverage report found for master at cd895b6.

Powered by Codecov. Last update cd895b6...97f8634

lgtm otherwise


FIX: validation on model attribute with nested Literal breaks

Change Summary
Nested literals, e.g. Literal['foo', Literal['bar']] are legal syntax per PEP 586. mypy correctly resolves them, as does pydantic.mypy for model attributes.
Nested literals break pydantic model attribute validation at run time. For a comprehensive example case, including pydantic.mypy output and runtime error output see example script.
This PR implements a fix for this by implementing a function to flatten nested literals down to a a list of their raw values.

Bonus notes:

I put 85bf860, adding test for the flatten function in its own commit, in case testing internals as such wasn't wanted
The tuple cast was so that these changes would be back compatible with the literal tests in test_types.py.

I think it would better to use the set (allowed_choices_set ) instead of the tuple (permitted_choices ) in https://github.com/samuelcolvin/pydantic/blob/aaec3c9c15581d2de31bcda0fbf096638386ee20/pydantic/validators.py#L397 but this would have required altering those literal tests test_types.py, and I wanted to keep the scope as small as possible.
Those tests test_types.py look quite stale though (have skip markers, and don't use the proper python version switches used in the rest of pydantic). So maybe it would be worth removing them for these ones in test_validators.py`? Lmk in if so for any case - happy to make amends as wanted.

Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[x] changes/1364-DBCerigo.md file added describing change

Hm, the breaks & the loss of code coverage are results from imports of from other pydantic modules 🤔
Any hints at how you think they are best resolved appreciated. (I would write a test for literal_values, but there is no test_typing.py file yet, so makes me think making such a file isn't the proper solution...!)

Hi @DBCerigo ! Well it tries to run your tests without extra dependencies (so without typing_extensions) meaning the tests on python 3.8 fail
You should just do like it's done for test_interval_validation_error and add a skipif
@pytest.mark.skipif(not Literal, reason='typing_extensions not installed')
def test_interval_validation_error():

Btw imo the method to retrieve all the values of a Literal should be next to literal_values and could be simplified like this:
def all_literal_values(type_: Type[Any]) -> Tuple[Any, ...]:
    """
    This method is used to retrieve all literal values as
    Literal can be used recursively (see https://www.python.org/dev/peps/pep-0586)
    e.g. `Literal[Literal[Literal[1, 2, 3], "foo"], 5, None]`
    """
    if not is_literal_type(type_):
        return type_,

    values = literal_values(type_)
    return tuple(x for value in values for x in all_literal_values(value))

@PrettyWood thanks for guidance, much appreciated.
I've added the test skips, and used your improved implementation, and moved the location of the function to the typing module.
The only bit I think is still not up to scratch is the location of testing all_literal_values - currently this is still in test_validators.py which isn't very appropriate, but there doesn't seem to yet be a test_typing.py - should I make that file? Or is there a better place for that test to live.
Thanks again.
(For my own understanding, what is reasoning for having just the Ubuntu CI run without external deps and thus differ from the osx and windows? Or have I misunderstood why it was just the Ubuntu builds that failed before?)

@DBCerigo Well I can just tell you what I would have done but @samuelcolvin may think otherwise. I would have done a new file test_typing.py to test properly the new all_literal_values method and just an extra test in test_validators.py or test_main.py with one example for nested Literal.
As for the CI, I reckon the main reason is just that it's useless to do all checks possible on every OS. It's quite common to make heavy tests on ubuntu (here we test that everything works with extra dependencies, without, without compiled binaries...for all supported python versions). Don't know if it's relevant to do everything possible on every OS. Checks on mac and windows are already quite complete. Maybe there is another reason though 🤷♂

@DBCerigo Well I can just tell you what I would have done but @samuelcolvin may think otherwise. I would have done a new file test_typing.py to test properly the new all_literal_values method and just an extra test in test_validators.py or test_main.py with one example for nested Literal.

Cool, as this was my thinking also then I'll go for it and @samuelcolvin can correct as required.

As for the CI, I reckon the main reason is just that it's useless to do all checks possible on every OS. It's quite common to make heavy tests on ubuntu (here we test that everything works with extra dependencies, without, without compiled binaries...for all supported python versions). Don't know if it's relevant to do everything possible on every OS. Checks on mac and windows are already quite complete. Maybe there is another reason though 🤷♂

Thanks for that. Having now looked at the CI steps in more detail I see that the build is of course tested with deps on ubuntu, but is also tested in those settings only on ubuntu, hence the difference - so all clear to me now :)
Last thing just to check; I won't re-jig the commit history for this PR too much, as it looks like all PRs are merged with squash by default. Let me know if this is wrong, or it should have a tidier history in any case.

@DBCerigo I like to have a clean history to help the reviewers but you are right all PRs are squash and merged. Since this PR is very small the whole diff is enough for a review so no need to worry about the history too much

@PrettyWood yep - if it was more substantial I would make the commit history proper to enabling stepping through the commits. Thanks for all the help again!

@samuelcolvin thanks for the review. Hopefully good to go this time :)

Thanks so much.


Frealm2

the new test for bip44 wallet derived wamp-cryptosign keys (see also https://github.com/wamp-proto/wamp-proto/issues/401)


xcm/registry - use VersionedMultiLocation in registry

Instead of using specific version of MultiLocation type - it would be preferable to use VersionedMultiLocation instead to avoid registry migration if xcm version changes.

Using VersionedMultiLocation is actually not possible.
Allowing to store different versions in registry for assets create an issue when mapping from location to internal asset id would not possible because conversion would not know which version it has to  convert it into.
Therefore, it is preferable to use one specific version until it is no longer possible to convert more recent versions and in such case, a migration will e needed.
This approach requires a change because currently we set registry's location type to polkadot_xcm::latest::MultiLocation.  so any future upgrades may change this. It needs to be set  to V1.

MultiLocation version pinned to V1 - done as part of #348


Multiple Pivot items

Not sure this is supported features or proper way to use, but just for the information.

When you choose drag items into pivot area, and some errors throws and have blank rows in grid.

fixed now. thanks.

:thumbsup:


cmd + shift + g not works on mac to open source control panel

All other sidebar tabs shortcuts work with cmd + shift + (e,f,d) and also with ctrl + shift + ... on a mac. However, source control panel opens with ctrl + shift + g only and does not work with cmd + shift + g.

Please use the advice at https://github.com/microsoft/vscode/wiki/Keybinding-Issues to investigate.


Services and data loaders need to load config files via URL

What?
For the deposit-service and notification-service and all data loaders, we need to be able to load any config or properties files using URL.
Why?
This will ensure these services and data loader can start up and load config via a URL.  For JHU specifically, we will then be able to remove some EFS mounts and datasync tasks in AWS and simplify infrastructure and deployment.
How?
Use the spring Resource class to load config and properties files.
Acceptance Criteria
ensure these services and data loader can start up and load config via a URL
Related Issues

@markpatton I did some experimenting with this ticket and tried to set the repo.json env var to the https URL of the repo.json object in S3.  It didn't work because the s3 bucket is private.  In order to use the s3 object URL, static website hosting has to be enabled on the s3 bucket and the s3 bucket has to be public (which is not good in our case because the config files could hold sensitive data).
I'm thinking about this more to determine how we can enhance the loading of config files with a different approach.

Deposit services has been deployed to stage with the s3 configuration change.  Here are things that were done:
Deploy deposit-services to stage loading config from s3
-create new bucket pass-configuration-stage
-create new policy named pass-s3-read-configuration
-update task def for both deposit-services
-change config url to s3
remove mount/volumne
-assigned new pass-s3-read-configuration policy to pass-task-def-role
-remove pass-service-task-role-policy
-remove efs access point (deleted deposit-service access point)
-remove s3 transfer folder for deposit services in pass-transfer-files bucket
-remove datasync for deposit services (locations/task)

Moved this back because it would be good to springify the grant loader too.

Grant loader has been deployed to stage and tested. Here are things that were done:
-add grand db user and grant db password and grant db url in param store
-add env vars and secrets in env.list to job def
    -msel needs grant db secrets, no pass_client
    -non-msel needs no grant db secrets, change name of pass_client
     -add java opts env var with enable of s3 to job defs
-assign s3 policy to task def to read s3-config bucket
   -pass-jh-msel-data-loader-task-efs-role
   -pass-data-loader-task-efs-role
-move policy.properties to pass-configuration-stage bucket
-remove policy.properties from transfer bucket
-remove connection.properties in transfer bucket
-update step function job def versions


Makes it possible to enter 1 without a padded 0 in table row

What does this pull request change?
Changes TableRow.tsx to allow users to enter single digit numbers without left-padded 0 to be added.
Why is this pull request needed?
It fixed the issue described above.
Issues related to this change
#469

Hmm... I guess we could either debounce the event and strip the trailing "." after X seconds, or change the event to onBlur and move the formatting logic to the updateItem function instead. Not sure which (if any) of those approaches fits best with the intended use of the table.

Third alternative would be to not do anything until the user clicks save, then do validation and parsing then. I think you can merge what you got, and then consider the rest later on


Event onWithOptions doesn't allow selective behaviour on events

Sometimes its necessary to stopPropogation and preventDefault on certain events and not others. For instance it may be desired to restrict certain key-presses in a text-input field. Examples include:

Credit card entry, numbers and spaces
Phone numbers with international codes () and +
Hex editor, restrict to A-Z 0-5
and many more....

Currently Elm doesn't allow this behaviour because stopPropogation and preventDefault are specified at the time the event listener is [registered] (http://package.elm-lang.org/packages/elm-lang/html/1.0.0/Html-Events#onWithOptions), and before the event listener has received any events.
I suggest changing the signature of [Options] (http://package.elm-lang.org/packages/elm-lang/html/1.0.0/Html-Events#Options) to something like this:
type alias Options =     { stopPropagation : Json.Decoder Bool     , preventDefault : Json.Decoder Bool }
This will allow stopPropogation and preventDefault flags to be based on the content of the event received.
Alternatively since this would be a breaking change could add another Options type and another onWithOptions method.

Moved issue to: https://github.com/elm-lang/virtual-dom/issues/18


Determine java version used for compilation within build scripts

A JAVA_VERSION property is being used to determine whether certain test cases can be built (e.g. modularity test cases cannot be built if Java 8 is being used to build the repository).
JAVA_VERSION is required to be set by the user, but it could be determined quite easily by the build removing the need for the user to set it.  See https://github.com/AdoptOpenJDK/openjdk-systemtest/pull/116 for details of how to do that.

Fixed via: https://github.com/AdoptOpenJDK/openjdk-systemtest/pull/119/files


RFC: Add yesterday to relative formatter

First of all, I :heart: this package, it's fantastic.
I use the relative formatter a lot and it's so plug and play it almost feels like cheating. However, I wonder if others feel like the 22-36 hours section https://github.com/bitwalker/timex/blob/741ed40e30bd1af248cc10005dcfe6cd75058a53/lib/format/datetime/formatters/relative.ex#L17 should say yesterday instead? a day ago sounds awkward to me.
Happy to implement this and submit a PR if maintainers agree

@heimann Sorry for the long delay in responding to this. Since we already have the translations, I've gone ahead and made this change, it will be in 3.7.2


Hotfix/broken compilation

Only compile tests when running meson natively; Meson automatically downloads googletest as a subproject, so it is no longer a system dependency

A lot easier to set up then i though :P

This was the case when i was setting up cross compiling as well. Meson is awesome.


User ignores stopped working

Given the following configuration: https://github.com/NixOS/nixpkgs/blob/master/.mention-bot
User still got mentioned on a new PR https://github.com/NixOS/nixpkgs/pull/19492#issuecomment-253291745

Actually, I think the whole file is being ignored. I'm in "alwaysNotifyForPaths" for pkgs/top-level/python-packages.nix and there have been several PR's this week where I wasn't notified but others were.

Yep, seeing the same thing here:
https://github.com/discourse/wp-discourse/pull/254

@vjeux

Hey, I'm sorry but I don't have the time to look into it. Would be nice if you could run your own instance and put console.log in places and troubleshot what's going on. Sorry about this!

@vjeux this could be duplicate of https://github.com/facebook/mention-bot/issues/173

@domenkozar we only have mention-bot configured in one of our org's repos:
https://github.com/Katello/katello/blob/master/.mention-bot
But yet it's still ignoring our userBlacklist:
https://github.com/Katello/katello/pull/6408

Tackled in https://github.com/facebook/mention-bot/pull/186.
And issue description in #185

https://github.com/NixOS/nixpkgs/blob/master/.mention-bot doesnt have one

@domenkozar I have just tried your configurations and it works fine even without the patch.
Sorry for bothering you, I will try if I can find out what's breaking your repo. :)

Same happen here https://github.com/SatelliteQE/robottelo/blob/master/.mention-bot
Even with that names in ignore list, bot keeps mentioning as you can see here: https://github.com/SatelliteQE/robottelo/pull/4217

Also happening to me at https://github.com/nextcloud/server/pull/3382#issuecomment-277616965.


Line Endings

Don't look at the diff for this. Just look at the commit messages and see if you think it's a horrible idea.
I also intend to go through and update the copyright headers once I get the new format from our lawyers.

I'll just leave this here over the weekend and merge it on Monday. It's almost entirely mechanical.


Jump to Source from Test Results

Observed:

Expected (comes from a maven project):

Hello @abhillman I also used //:ijwb_common_tests to run tests and I was able to see the jump to source option when right-clicking on the test results. Can you provide more details on how to reproduce it if you still have the same problem with the latest plugin version?


Deploy Checklist: New Expensify 2023-07-19

Release Version: 1.3.43-0
Compare Changes: https://github.com/Expensify/App/compare/production...staging
This release contains changes from the following pull requests:

[ ] https://github.com/Expensify/App/pull/16723
[ ] https://github.com/Expensify/App/pull/21406
[ ] https://github.com/Expensify/App/pull/22316
[ ] https://github.com/Expensify/App/pull/22562
[x] https://github.com/Expensify/App/pull/22770
[ ] https://github.com/Expensify/App/pull/22791
[ ] https://github.com/Expensify/App/pull/22831
[ ] https://github.com/Expensify/App/pull/22846
[ ] https://github.com/Expensify/App/pull/22981
[ ] https://github.com/Expensify/App/pull/22983
[ ] https://github.com/Expensify/App/pull/22988
[ ] https://github.com/Expensify/App/pull/22990
[ ] https://github.com/Expensify/App/pull/23030
[ ] https://github.com/Expensify/App/pull/23037
[x] https://github.com/Expensify/App/pull/23042
[ ] https://github.com/Expensify/App/pull/23045
[ ] https://github.com/Expensify/App/pull/23064
[ ] https://github.com/Expensify/App/pull/23086
[ ] https://github.com/Expensify/App/pull/23095
[ ] https://github.com/Expensify/App/pull/23098

Deploy Blockers:

[x] https://github.com/Expensify/App/issues/23083
[x] https://github.com/Expensify/App/issues/23102
[x] https://github.com/Expensify/App/issues/23123
[x] https://github.com/Expensify/App/issues/23187
[ ] https://github.com/Expensify/App/issues/23189
[x] https://github.com/Expensify/App/issues/23190
[x] https://github.com/Expensify/App/issues/23195
[x] https://github.com/Expensify/App/issues/23202
[ ] https://github.com/Expensify/App/issues/23210
[ ] https://github.com/Expensify/App/issues/23233
[ ] https://github.com/Expensify/App/issues/23250
[ ] https://github.com/Expensify/App/issues/23257
[ ] https://github.com/Expensify/App/issues/23262
[ ] https://github.com/Expensify/App/issues/23264
[ ] https://github.com/Expensify/App/issues/23265
[ ] https://github.com/Expensify/App/issues/23285
[x] https://github.com/Expensify/App/issues/23287
[ ] https://github.com/Expensify/App/issues/23288

Deployer verifications:

[ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
[ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
[ ] I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.43-0 :rocket:

Checking off https://github.com/Expensify/App/issues/23083 https://github.com/Expensify/App/issues/23102 and https://github.com/Expensify/App/issues/23123 since they were resolved in the last deploy. We seemed to have forgotten to remove the deploy blocker label.

Checking off https://github.com/Expensify/App/issues/23187 it doesn't need to be a blocker

Checked off https://github.com/Expensify/App/issues/23202, tested it and it is fixed

Checked off https://github.com/Expensify/App/issues/23195, tested it and it is fixed

Checking https://github.com/Expensify/App/issues/23287 off as non -repro anymore

I've retried the iOS build

checking this one as it should be fixed by a CP https://github.com/Expensify/App/issues/23189

Checking off all Apple sign in related PRs since the Apple sign in PR was reverted.

Checking off https://github.com/Expensify/App/issues/23262 as it was decided not to deploy on it

It looks like we CP'd a fix for https://github.com/Expensify/App/issues/23250 https://github.com/Expensify/App/pull/23259#issuecomment-1644390062, retested and it doesn't appear to be happening anymore, checking it off

Team is working on the IOS, I will be updating checklist in a bit as we validate PRs on iOS

Checking off https://github.com/Expensify/App/pull/16723 it was reverted

Regression is down to the last 8%
PR summary
https://github.com/Expensify/App/pull/16723 is failing https://github.com/Expensify/App/issues/23288
https://github.com/Expensify/App/pull/22562 is failing https://github.com/Expensify/App/issues/23269
https://github.com/Expensify/App/pull/22831 is failing https://github.com/Expensify/App/issues/23264
https://github.com/Expensify/App/pull/23098 is failing https://github.com/Expensify/App/issues/23195

@jasperhuangg Regression is completed

Checking https://github.com/Expensify/App/issues/23353 off, no more apple sign in on staging

https://github.com/Expensify/App/issues/23269 repro in prod so checking off https://github.com/Expensify/App/pull/22562

:shipit:


Polling frequency

The client at <IP_ADDRESS> identifies itself as rss2tg, and is polling my feed about every five minutes. If it continues, I'll be blocking the IP, and I suspect other admins will react similarly.

Hello, sorry for late response, I'm on vacation..
What's your feed name? I use library github.com/SlyMarbo/rss it must respect polling frequency if rss feed has it in settings:
"The library does its best to follow the appropriate specifications and not to set the Refresh time too soon. It currently follows all update time management methods in the RSS 1.0, 2.0, and Atom 1.0 specifications. If one is not provided, it defaults to 10 minute intervals."

Thanks, I've raised https://github.com/SlyMarbo/rss/issues/81

Thanks, great point


⚠ Bofrost.fr has degraded performance

In 073cd52, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1327 ms

Resolved: Bofrost.fr performance has improved in 47bc03f after 7 minutes.


Detroit - Hide Rental Assistance section on public page

We want to remove the Rental Assistance section from the listing detail page in Detroit. There are no additional rental assistance programs other than Section 8, which we are now handling in a separate treatment. There is still data in the DB that we want to keep just in case, so for now, we'd like to remove this section from the page.
Acceptance Criteria

Remove the rental assistance component from the listing detail page
Since it's in the ordered list, if there are items after it, they should move up in ordinal

QA Notes:

Open the public site: https://deploy-preview-1393--detroit-public-dev.netlify.app/
Choose a listing with filled the "rental assistance" section
Make sure the "rental assistance" section is not visible

LGTM