chore: fix Husky

See https://github.com/netlify/js-client/pull/659
This fixes how we use Husky with its latest version.

For us to review and ship your PR efficiently, please perform the following steps:

[x] Open a bug/issue before writing your code 🧑💻. This ensures we can discuss the changes and get feedback from everyone that should be involved.
[x] Read the contribution guidelines 📖. This ensures your code follows our style guide and
passes our tests.
[x] Update or add tests (if any source code was changed or added) 🧪
[x] Update or add documentation (if features were changed or added) 📝
[x] Make sure the status checks below are successful ✅

@ehmicky this breaks production installs which probably is the same reason 8.9.0 release failed :/
I tried to install the latest main version from GitHub and it fails with the same error as the release action:
C:\Users\xmr\Desktop>npm i -g github:netlify/cli#main
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>flatten is deprecated in favor of utility frameworks such as lodash.
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade to @mapbox/node-pre-gyp: the non-scoped node-pre-gyp package is deprecated and only the @mapbox scoped package will recieve updates in the future
npm ERR! code 1
npm ERR! git dep preparation failed
npm ERR! command C:\Program Files\nodejs\node.exe C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js install --force --cache=C:\Users\xmr\AppData\Local\npm-cache --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm ERR! code 1
npm ERR! npm ERR! path C:\Users\xmr\AppData\Local\npm-cache\_cacache\tmp\git-cloneCg974T
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command C:\WINDOWS\system32\cmd.exe /d /s /c husky install<EMAIL_ADDRESS>npm ERR! npm ERR! 'husky' is not recognized as an internal or external command,
npm ERR! npm ERR! operable program or batch file.
npm ERR!
npm ERR! npm ERR!      C:\Users\xmr\AppData\Local\npm-cache\_logs\2022-01-15T07_29_00_041Z-debug.log

npm ERR!      C:\Users\xmr\AppData\Local\npm-cache\_logs\2022-01-15T07_29_00_267Z-debug.log

Maybe it's time to reconsider reverting the husky update after all? It's been just a pain in the butt :/

Thanks for finding this out @XhmikosR!
I have created https://github.com/netlify/cli/pull/4046 to fix this. Let's try to first just add husky as a devDependency, before reverting, as I believe this should fix this problem.

The PR is merged now, which should fix the problem. :+1:

I don't think that's the reason, unfortunately :/
In production you do npm prune --production which probably conflicts.

You could probably try npm pack to see this failing.

Great catch again!
Adding husky solved the problem in the other repositories, but we run some prepack and postpack npm scripts with Netlify CLI. prepack runs before prepare, so husky is missing since it is a devDependencies.
So, at the moment, npm publish will fail with an husky: not found error. Note: this bug should not impact any users yet, since we haven't released anything. However, it prevents us from publishing new releases.
I am wondering whether we could just remove those prepack and postpack scripts. :thinking:
npm publish already exclude devDependencies, so there is no need to prune them.
I tried running npm pack --dry before and after removing prepack and postpack, and the same bundle seems to be produced, with the same files.

You could probably remove them, but there must be some reason they exist.
Could be they were needed in the past or something. Or they were added as a precaution measure so that the lock file is as small as possible.


An array as a root node

An alternative solution for #590 and #568 POC

Thanks, @frenzzy. This is an interesting proposal. What about adding Fragments to this PR as well?

Fragments is a separate feature which is not quite related to the current single root node problem, I would prefer to create a separate commits (PRs) for each one. And for Features I see three different possible implementations:

Support VNode with empty name in patch function
Support for nested arrays inside children arrays
Converting fragments (nested arrays) to plain children arrays inside h function

Maybe need to create three PRs and compare..

Lol, JSX Fragments already supported, see #596
And this PR makes the life easier to use them :)

I would prefer not. Put everything in a single PR. Thanks.

This is clever, but if we introduce Fragments someday in the future, I'd prefer this to be properly implemented using DocumentFragment and going all the way as to allow Components to return keyed fragments, not simply an array.

The PR is not about fragments directly, but about an ability to render more than one element into the document.body. I see your point.

Yes, you are right. My apologies for asking you to mix two unrelated things.

+4 bytes^^

The only way we'll support returning an array from the root is if we add fragment support someday, but not like this. Thanks.

The main purpose why I did this, I want that users do not try to put various elements in the container and look for a workaround for "which element Hyperapp should revive" like here #590 and #568

@frenzzy Because we may add fragment support in the future, I think the best we can do now is nothing. So, both #590 and #598 may have to wait as well. Although, I like #598 and it's also what I want to do for Picodom 2.0.

https://github.com/picodom/picodom/pull/96

@frenzzy Do you think we could implement this in a different way?

But btw, we’ve been longing for this feature since the times of 0.1x.
Are keyed elements supported now in root-level array elements?

Are keyed elements supported now in root-level array elements?

No, how would you implement that?

@jorgebucaran what exactly you dislike in the current implementation?
Since we have subviews/lazy components now, I think it make sense to change patch signature to accept a parent element and already resolved an array of children VNodes. And patch function will just modify all children elements without touching the parent element. What do you think?

And patch function will just modify all children elements without touching the parent element. What do you think?

Do you have some code or pseudo code to explain what you mean?

Something like patch(container, nextVDomTree, prevVDomTree) and inside patch do not touch container itself, only container.childNodes


Export to html not working right

Environment Information

leafmap version: 0.14.0
Python version: 3.10.7
Operating System: Win 10
Jupyter version: 6.5.2

Description
Please assist with:
I was trying to save a map to .html and while it does that when I open the html in a new tab or browser it gets quite buggy.
Doesn't display background maps. Can't load the raster layer as well.
Please let me know what I can do to solve this issue...
Thanks
What I Did
import leafmap as lfm
import pandas as pd
import numpy as np
import geopandas as gpd
import branca.colormap as cm
from shapely.geometry import Point, Polygon, shape
from IPython.core.display import display, HTML, clear_output
import os
import sys
from geopandas import GeoDataFrame as gdf
Lmap = lfm.Map(google_map="HYBRID",center=[42.144378, 24.881488], zoom=15)
dir = 'C:\Users\Iwo\Desktop\New folder' # local path
Ortho = os.path.join(dir,'katunica-ortho.png') ## The function 'ImageOverlay' loads images from a url and would therefore have trouble loading image from local path
Lmap.add_raster(Ortho, layer_name='UAV')
soil = gpd.read_file(r'D:\RST-Data-Materials\piper_po4vi.geojson') # local path
InSitu=pd.read_csv(r'D:\RST-Data-Materials\insitu10082022.csv',usecols= ['Date','PH(cm)','Chlorophyl','LAI']) # local path
GPS=gpd.read_file(r'D:\RST-Data-Materials\UAV piper\Result-mihaela\katunica_piper-GCP\pole_2021\11.08staro.shp') # local path
GPSgdf= gdf(GPS)
GPSgdf.crs ='epsg:32635'
GPStrans=GPSgdf.to_crs('EPSG:4326')
Lmap.add_point_layer(GPStrans, popup="Name")
Lmap.add_vector(r'D:\RST-Data-Materials\piper_po4vi.geojson', layer_name='Soil') # local path
Mdata = gpd.read_file(r'D:\RST-Data-Materials\UAV piper\Result-mihaela\mask3.geojson') # local path
Lmap.add_vector(r'D:\RST-Data-Materials\UAV piper\Result-mihaela\mask3.geojson',layer_name='mask') # local path
Lmap.to_html('LeafMap.html')

This is an ipyleaflet issue rather than leafmap. The ipyleaflet's to html functionality is buggy. You can try out the folium backend using import leafmap.foliumap as leafmap. Both to_html() methods inherit from ipyleaflet/folium. There is not much leafmap can do about this.


Consistently ensure the word 'overlay' is printed when talking about overlays.

Also switches to the standard way of referring to file paths on the terminal, and drops the community triplet notice to a message rather than a warning.
Example:
Installing 1/1<EMAIL_ADDRESS>Building<EMAIL_ADDRESS>D:\vcpkg\triplets\community\x86-windows-static.cmake: message: loaded community triplet from here. Community triplets are not built in the curated registry and are thus less likely to succeed.
-- Using cached madler-zlib-v1.3.1.tar.gz.
-- Cleaning sources at D:/work/testing/buildtrees/zlib/src/v1.3.1-2e5db616bf.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source D:/vcpkg-downloads/madler-zlib-v1.3.1.tar.gz
-- Applying patch 0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch
-- Applying patch 0002-build-static-or-shared-not-both.patch
-- Applying patch 0003-android-and-mingw-fixes.patch
-- Using source at D:/work/testing/buildtrees/zlib/src/v1.3.1-2e5db616bf.clean

I'm not sure I like this form myself, in particular 'message' seems really long to say... nothing. This follows the standard way to refer to paths in output though.
I do want to stop community triplets being loud and taking up at least 2 lines though.

I do want to stop community triplets being loud and taking up at least 2 lines though.

Shouldn't we only report it once anyway? It seems excessive to repeat the triplet for every package.

I'm not sure I like this form myself, in particular 'message' seems really long to say... nothing. This follows the standard way to refer to paths in output though.

Agreed that 'message: ' seems excessive here. 'info: '?
Could you also add an example of the new overlay text in context to the description?

Shouldn't we only report it once anyway? It seems excessive to repeat the triplet for every package.

I'm torn on this. I agree it would be nice to not spam it all the time, but I also see people snip out just the block of a failed build when they're having issues, and not noting it being likely to create confusion.

Agreed that 'message: ' seems excessive here. 'info: '?

Will try info, yes.

Could you also add an example of the new overlay text in context to the description?

I was about to say "didn't I already do that?" but just realized I only showed community triplet above. Sure, stand by...


Issue about .pth file and parameters in predict function

Hello,
I encountered two issues while using your method. The first issue is related to the marson_grn_128.pth file. When running your code, this file is used. If we want to use our own dataset, how can we obtain the corresponding file for our own data?
The second issue concerns the predict function in vci/model/model.py. For this function, we need to provide parameters such as outcomes, treatments, cf_treatments, and covariates. How should we obtain these parameters?
Thanks.

Hi, thanks for the question! For custom GRNs, please refer to the graph_prep branch. Generating GRN itself is an art, I don't think anyone can give you an accurate, comprehensive, and context-specific gene relational network based on the prior knowledge of genetic research in the current day and age. So, it is at the discretion of you whether you want to just use a generic prior GRN or a refined GRN using the GNN updating approach we proposed, or simply not using a GRN (in which case you can check out https://github.com/yulun-rayn/variational-causal-inference).
For the second question, outcomes, treatments, and covariates are your factual observations, i.e. the observed gene expressions, factually used drug/knockout, and cell type. cf_treatments is the intervention (i.e. alternative drug/knockout) you are interested in.


[incubator/azuremonitor-containers] add additional parameters and update the instructions for Helm3

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
This PR has the following updates

update the instructions for Helm3  client
add additional parameters clusterId and clusterRegion so that same chart can be used for the managed clusters hosted in Azure

Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test

@vishiy are you good with this?

/approve

/lgtm


[ᚬmaster] chore: update package versions and changelogs

0.27.1 (2020-01-27)
Note: Version bump only for package ckb-sdk-js

Subscription rpc will be not added in v0.27.1 ?

Subscription rpc will be not added in v0.27.1 ? @Keith-CY

It works with websocket that I prefer to implement later.

Subscription rpc will be not added in v0.27.1 ? @Keith-CY

It works with websocket that I prefer to implement later.

Subscription rpc will be not added in v0.27.1 ? @Keith-CY

It works with websocket that I prefer to implement later.

Get


[mungegithub] Only request 40px avatars.

would we rather do it on the server side, since it would be smaller easier?  maybe not...

by updating https://github.com/kubernetes/contrib/blob/master/mungegithub/mungers/submit-queue.go#L467 I think?

I have no strong opinion. The image size is specified in CSS, which is pretty far away from the place we reference the URL already.

Since the width:40px is in the CSS, I thought doing this in the JS keeps the modifications for display as localized to the presentation layer as possible.


Add anchor to vote-create command

Changelog
- description: |
    Make it possible to add an anchor to votes
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context
This PR closes #356 .
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] The change log section in the PR description has been filled in
[ ] New tests are added if needed and existing tests are updated.  These may include:

golden tests
property tests
round trip tests
integration tests
See Running tests for more details

[ ] The version bounds in .cabal files are updated
[ ] CI passes. See note on CI.  The following CI checks are required:

[ ] Code is linted with hlint.  See .github/workflows/check-hlint.yml to get the hlint version
[ ] Code is formatted with stylish-haskell.  See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
[ ] Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7

[ ] Self-reviewed the diff

@carlhammann It looking good, perhpas for consistency with other commands that take anchors it could be
--vote-url
--vote-text
--vote-file
--vote-hash

Similar to what we have with governance actions, which include:
--proposal-url TEXT      Proposal anchor URL
--proposal-text TEXT     Input proposal as UTF-8 encoded text.
--proposal-file FILE     Input proposal as a text file.
--proposal-hash HASH     Proposal anchor data hash.


[WIP] Multiline function call #111 test

https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/111

* **method_argument_space** [PSR-2]
                In method arguments and method call,
                there MUST NOT be a space before each
                comma and there MUST be one space
                after each comma.

I do not agree that the first added test is bug of described fixer. This fixer does not move params to new lines.
Multiline function calls are defined by other PSR rule and therefore should be done as separate fixer.
Do you agree?

This issue could be resolved by another fixer, but until there is such a fixer I think the test added is a relevant issue that should be addressed by the PHP-CS-Fixer.
Feel free to close this PR, I don't think I can work on this anytime soon :(

OK, then this is not a bug report but feature request.
It's cool feature, but it is already requested by #111 . It's great PR and yeah, I would love to see it.
Closing as duplicate.
Thank you @SpacePossum


Create an helper to tweak the scoring function of a query

No draft of a solution yet.

This ticket is about defining the API that would make different kind of score tweaking easy to implement,
within or outside of tantivy's scope.
Here is the list use cases:

boosting part of a query MUST HAVE

query_a.boost(10) OR query_b

sorting by a fast field MUST HAVE

query_a.sort_by(some_fast_field);

letting the developer define how to balance BM25 and some othersimple  fast field (e.g: number of stars, review score, historical CTR, etc.). MUST HAVE
That's a use case for crates.rs for instance

letting the developer score the docs using a ML model loaded for a &[u8] payload.
NICE TO HAVE SOME DAY. Very close to the previous one. MUST HAVE

tweak the scoring function dynamically using a formula. That's very handy for rapid development
NICE TO HAVE. Probably should be an independant crate. MUST HAVE

Maybe decaying (https://www.elastic.co/guide/en/elasticsearch/guide/current/decay-functions.html) also falls into scope of this issue?


Disable test that started failing on windows

This test started failing, seemingly, due to something external
changing. Making a branch from the last green build and an empty commit
causes the same failure.
There might be something here, but for now I've just disabled the test.

Attempted to re-run CI with the same code that last passed was in #28.


In ruby 3.2.2 version, Watir::RSpec::HtmlFormatter will delete current project files

In ruby 3.2.2 version.
RSpec.configure do |config|
  config.add_formatter(Watir::RSpec::HtmlFormatter)
end

I don't set ENV["WATIR_RESULTS_PATH"] as  before versions.
Running " bundle exec rspec " twice,  It will delete all files from current project.
Because in ruby 3.2.2 version, the default output_wrapper will response to method :path , it returns "<STDOUT>".
 @output_path = File.expand_path(ENV["WATIR_RESULTS_PATH"] || (output.respond_to?(:path) ? output.path : "tmp/spec-results/index.html"))
FileUtils.rm_rf File.dirname(@output_path), :verbose => true if File.exist?(@output_path)

@output_path  is assigned "<CURRENT_DIRECTORY>/<STDOUT>".
Run rspec first time, it will output "<STDOUT>" file in the current directory.
Run rspec second time, it will remove all files in the project directory.
It's very bad to delete all files in the current directory.

First of all - really sorry that you had to deal with this unfortunate situation. I hope that nothing critical was deleted.
It's really bad indeed when something like this happens and we need to get it fixed ASAP.
I have a little bit problem of understanding the situation described. Do you know what is the type of output passed to #initialize exactly? What is the <STDOUT> part in the path exactly (e.g. what file is created?)? Do you know if problem happens only with Ruby 3.2.2 or is also happening with Ruby 3.1.2 for example?

I guess looking at your description, then this is the output and the #path method - https://ruby-doc.org/3.2.2/IO.html#method-i-path
Ruby 3.1.2 does not have IO#path. Pretty scary indeed.

Managed to reproduce this problem on Ruby 3.2.2 and yanked watir-rspec 4.0.0 to prevent any further accidental damage.
Thankfully 4.0.0 is the only version working with Ruby 3.2.2 thus far and one of the lines failing is the one responsible for deletion https://github.com/watir/watir-rspec/commit/97f5d193d7f05c259696a025e1ba1e11e9cceded#diff-60f968e3effe8372501a079d4edaeb5c8101362bdfa85e2267a85a90ddf09154L19, but it doesn't work due to usage of File#exists?.
And this design decision by Ruby core team is just awesome:
irb(main):001:0> $stdout.path
=> "<STDOUT>"

Released 5.0.0 with the above problem fixed. Thank you for reporting and I'm really sorry again that this happened to you.
To be honest - I would not write code like this today where deletion happens using possible user provided path (either via WATIR_RESULTS_PATH env variable or output.path which can be provided using RSpec options). I checked that this code was added at 2012 in commit d2a65730a31189874a616b8b35cc181a557497db.
Sorry again and I hope that you will continue using watir-rspec.

That's ok. This time I happened to push my code. so I didn't loss any useful code.
This surprised me at first. I thought it was a virus that deleted these files. I kept trying to run rspec many times and found that it was caused by watir-rspec.
Finally added ENV["WATIR_RESULTS_PATH"] = "tmp/spec-results/index.html" into the code to avoid this problem.
But I think it's serious problem, other users will encounter similar problem if they upgrade to ruby3.2, it's very bad problem.

@simonwu-os thanks to you finding and reporting this issue, me yanking version 4.0.0 and releasing 5.0.0 maybe there's no-one else going to stumble this issue anymore.

Yeah, that's great. Thanks for resolving timely.


Binary Tree construction from preorder and postorder traversals

Issue will be closed if:

You mention more than one algorithm. You can create a separate issue for each algorithm once the current one is completed.
You propose an algorithm that is already present or has been mentioned in a previous issue.
You create a new issue without completing your previous issue.

Note: These actions will be taken seriously. Failure to follow the guidelines may result in the immediate closure of your issue.

Name:
Binary Tree construction from preorder and postorder traversals
About:
Given two arrays:
Preorder Traversal (pre): The order of nodes visited in preorder traversal (Root-Left-Right).
Postorder Traversal (post): The order of nodes visited in postorder traversal (Left-Right-Root).
You need to reconstruct the binary tree that corresponds to these traversals. The challenge lies in the fact that multiple binary trees can yield the same preorder and postorder traversals, but for a given tree structure, there is a unique reconstruction.
The algorithm will effectively reconstruct the binary tree from its preorder and postorder traversals using recursion and careful tracking of subtree sizes.

Labels:
new algorithm, gssoc-ext, hacktoberfest, level1

Assignees:

[x] Contributor in GSSoC-ext
[x] Want to work on it

@DPS-2912 assigned


Various enhancements

Add C54, Z52 and Z54 order types.
Drop bankShortName in favour of hostId.
Initial work on generic example files using command line parameters using yargs instead of single sample files per order type.

Signed-off-by: Herman van Hazendonk<EMAIL_ADDRESS>

@nanvo The yargs implementation might not be great yet, but it does the trick for me. Happy to take any suggestions for those really. This will allow 3 generic example files to be used for all supported order types. Which really makes it easier and flexible :)


czml3 is looking for new maintainers

Full context: https://github.com/poliastro/poliastro/issues/1640

I don't see the need to archive czml3, we can transition that project.

There's a pending release and a couple of pull requests that need merging. Are there any volunteers to move this project forward?
Please explain your motivation, how you are currently using czml3, and what do you intend to do with it in the future.

cc @Sedictious would you like to step in?

There are some serious problems that require quick fixes for this package to remain usable in my opinion, specifically https://github.com/poliastro/czml3/pull/76, https://github.com/poliastro/czml3/issues/105. Once a maintainer is found I think these problems should be immediately addressed.
If a maintainer can't be found I'd be happy to fill in the position, but I'm probably very much under-qualified for the position. If it's of any relevance, I've written a similar library for Julia called CZML.jl.

To potential forkers, copy the issues from here using https://github.com/gavinr/github-csv-tools.

Maintainer sounds a bit "heavy" but I want to try to tackle the open issues (though I expect a non-insignificant ramp up time). To clarify, all PRs would need to be opened to the open project correct (if so I could help with creating the fork, cloning the issues and redirecting to the new repo). I understand that this repo will be archived in any case correct?

I don't intend to archive the repo if anyone wants to step in as maintainer (this is different from what I did in poliastro)

Are you still looking for a maintainer?  I have used czml3 across multiple projects/companies and have a vested interest in keeping it alive and well.  Can you briefly explain what is involved in being a maintainer?

Hi @fbl100 ! With "maintainer" I mean someone who cares about the library, fixes some of the open issues, and as a result of the trust earned by the community earns write access to the repository.
There are a few bugs and gaps so feel free to start contributing, I don't have a lot of time to review big PRs but I'll do my best.
May I ask what have you used czml3 for? 😊

Broadly speaking, I've used it to visualize satellite scheduling results, so showing orbits, models, beams, ground tracks, etc.
I have a small batch of updated models that I use for cases where the official library doesn't have support (see: PolylineArrow).  It's on my list to gather my changes and submit them as a PR.
Not sure if that answers your question, but I'd be interested in becoming a maintainer at some point.

That' great.  I've been working on getting my local mods into a PR.  Hoping to have it ready for review in the next week or so.

Just a heads up, @Stoops-ML continued to make consistently good contributions over the past month so now he has write access. The CI is in a much better state now so we're close to tagging a release.

@astrojuanlu are there any other additions you'd like before a version bump? I've finished all the work that I had planned to do before a version bump.
Also, I remember that you had said somewhere that you wanted to bump to v1.0.0 once all the packets have been added to the library. That still true (i.e. next bump is v0.8.0)?

are there any other additions you'd like before a version bump?

not really, let's proceed!

We made a release 🎉
Now what would be awesome to close this ticket would be to have another person review @Stoops-ML PRs that's not just me. Everybody in this thread is welcome to get more involved in that regard, even if you don't have time to author PRs yourself.

Just when I thought I was going to have time to be a maintainer, I got slammed at work.  I can definitely review PR's, and I'll try to find the time (after the release?) to check the current packet definitions against some of the ones that I've made locally over the years.

I’d like to pitch myself again. I’ve basically rewritten the entire codebase in v2 and have time to maintain the package. There’s bug fixes I have ready to merge, but I’ve been waiting on #162 for a few days now.

@Stoops-ML is effectively maintaining the package now. The only thing missing is that we need a co-maintainer, hence somebody that will review PRs so that at least 1 more person will look at the code before going in. When we find them, I'm happy to grant them triage rights, maintainership rights to @Stoops-ML, and close this issue.

Been thinking about this for a few days. I think it's unreasonable to expect others to step in and start reviewing code.
There's a big PR incoming https://github.com/poliastro/czml3/pull/163 and I don't think I'll ever find the motivation to review it. This is on top of a major refactor that was merged recently https://github.com/poliastro/czml3/pull/154
A year ago I said that we could transition czml3 but now the truth is that I'd like to archive poliastro/czml3.
At the same time, unlike poliastro/poliastro, I'm not picky about squatting this name for myself forever.
I offer this path forward:

We change the trusted publisher of https://pypi.org/project/czml3/ to be https://github.com/Stoops-ML/czml3
I archive this repository

This is equivalent to giving @Stoops-ML "the keys" for czml3 on PyPI.
If there are no major disagreements, and crucially @Stoops-ML is okay, let's proceed.

Thanks very much for having faith in me! I’d love to take over the reins and continue developing this package.
On my end I’ll try to find someone / some people that can help with code reviews.
The main things I’ll be focusing on are bug fixes, expanding property validation and perhaps incorporating some Cesium Ion properties (but I don’t currently have a licence for them). So no big changes should be expected in the coming months.

Confirming that I am now co-owner

About to do (3), and will do (4) right after. Ad astra!


Make links go back

Is there an unobtrusive way of making links go back to the previous location (like history.back()), by adding a specific attribute name/value, like
Back

Back

I found that there is no back option for data-turbolinks-action https://github.com/turbolinks/turbolinks#application-visits.

This feature could be related to this other topics:
https://github.com/turbolinks/turbolinks/issues/88
https://github.com/turbolinks/turbolinks-ios/issues/81
https://github.com/turbolinks/turbolinks/issues/74

Closing as duplicate of #74


rbac: log unknown policies for debugging purposes

In response to a cherrypick label: new pull request created: #974


Make rtop work on windows

@bryphe confirmed that rtop works on windows as well! The only part that does not is the little shell script wrapper that forms rtop binary. Instead, we should make rtop compile a native .exe that does the same thing as the script wrapper. This would be a huge unblocker for Windows native Reason, and is relatively easy to implement. We just need the rtop directory to have a native executable that achieves the following logic:
This is also a great first task.
#!/usr/bin/env bash

# Copyright (c) 2015-present, Facebook, Inc.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

# 0. Touches .utoprc (otherwise utop will fail).
# 1. Avoids "#use"ing ~/.ocamlinit before reason is required.
#    Otherwise, the ~/.ocamlinit is written in `.ml` syntax that will
#    choke the reason parser.
# 2. Add the $HOME directory to the include paths so that in step 3
#     we can actually load the ~/.ocamlinit (but before we require
#     reason).
# 3. Run ml rtop_init.ml that "#use"es ".ocamlinit", and then finally
#    require's reason, so that reason is required after .ocamlinit is
#    parsed in standard syntax.

touch $HOME/.utoprc
touch $HOME/.utop-history
DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )

# intercept the -stdin flag of utop, and preprocess the code into reason code
# before forwarding it. Afaik currently there's no better way of intercepting
# the code after urtop receives code from stdin and before it processes it
if [[ $@ =~ "stdin" ]]; then
    refmt --parse re --print ml --interface false | utop-full $@
else
    utop-full -init $DIR/rtop_init.ml $@ -I $HOME -safe-string
fi

In case it helps, here's how I tested on Windows w/o the script:

npm install -g<EMAIL_ADDRESS>git clone https://github.com/bryphe/esy-minimal-rtop-project
cd esy-minimal-rtop-project
esy install (May need to retry this, due to esy/esy#413 and esy/esy#414)
esy build
esy x utop-full -init C:/Users/<YOUR USERNAME>/.esy/3_/i/esy_ocaml__slash__rtop-3.3.0-c101f070/bin/rtop_init.ml -safe-string
and voila:

But, once we have the native wrapper - it should be as easy as esy x rtop 👍

@bryphe and once we have the native wrapper, building an esy release will expose an npm binary to rtop.exe, correct?

@jordwalke - yep! Although, esy release is blocked on Windows at the moment by https://github.com/esy/esy/issues/418


multiple table to one foreign key relationship

I know it's not a good practice, but I'm working on a project that contains "foreign key" referencing more than one table, the whole bank is this way, I wanted to know if the entity framework supports this type of relationship, so I studied and researched is not supported, if they have a solution, it helps a lot, I'm migrating to the entity framework. But without this feature I can not migrate, an example below:
Data Base:
Tasks
- Id
- SourceId
- TypeSource //Used to set the connection
- Description

OrderService
- Id
- Description

Schedule
- Id
- Description

Code:
ITaskSource
- Id -> int
- Description

Tasks
- Id -> int
- Source -> ITaskSource
- TypeSource -> string //Used to set the connection
- Description -> string

OrderService : ITaskSource
- Id -> int
- Description -> string

Schedule : ITaskSource
- Id -> int
- Description -> string

This reads as table per heirchy
Store all itasksources in one table with
Id
Type
Description
Fk tasks Id + types our cells to identify and type

Actually it might be easier to consolidate the three classes into one


Handle generic parameter types as return types of builtins in DocBuilder

Fixes:
>>> import System
>>> help(System.Reflection.CustomAttributeExtensions.GetCustomAttribute)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Code\ironlang\ironpython3\Src\StdLib\Lib\_sitebuiltins.py", line 103, in __call__
  File "C:\Code\ironlang\ironpython3\Src\StdLib\Lib\pydoc.py", line 1843, in __call__
  File "C:\Code\ironlang\ironpython3\Src\StdLib\Lib\pydoc.py", line 1876, in help
  File "C:\Code\ironlang\ironpython3\Src\StdLib\Lib\pydoc.py", line 1630, in doc
  File "C:\Code\ironlang\ironpython3\Src\StdLib\Lib\pydoc.py", line 1623, in render_doc
  File "C:\Code\ironlang\ironpython3\Src\StdLib\Lib\pydoc.py", line 373, in document
  File "C:\Code\ironlang\ironpython3\Src\StdLib\Lib\pydoc.py", line 1364, in docroutine
  File "C:\Code\ironlang\ironpython3\Src\StdLib\Lib\pydoc.py", line 90, in getdoc
  File "C:\Code\ironlang\ironpython3\Src\StdLib\Lib\inspect.py", line 477, in getdoc
SystemError: Method must be called on a Type for which Type.IsGenericParameter is false.

The documentation on PythonType.GetPythonType(Type type) says it may return null if no type is available. So this is what it does now. However, this code path (chiefly though DynamicHelpers.GetPythonTypeFromType) is used in a lot of places that do not check for null. From nullability annotation point of view, it would be good to keep the return type of GetPythonTypeFromType non-nullable, but how to handle errors? ArgumentException?

Why do we need to prevent GetPythonType from returning a type when Type.IsGenericParameter is true? As far as I can tell it works in .NET Core and only fails on .NET Framework due to an interface for COM support. Or am I missing something?

we could guard against calling Type.GetInterfaceMap on an IsGenericParameter type

Actually, this is what I have implemented first, but then got thinking that perhaps it would be a bad idea to have such types floating around in the Python space. After all, they are not "real" types, should not be instantiated, each one is unique, despite having the same name/CLR type, may not belong to any namespace (when "declared" by a method), etc.
But I am not quite sure about that, so if you think it would be OK, I can put that support back in.

I haven't tried to get my hands on a PythonType of a generic parameter type to see what you could do with it. I expect not much? Not sure what the disadvantage of having such types would be.
It seems like having PythonType.GetPythonType always return a PythonType will lead to a cleaner codebase than returning null (and by consequence having DynamicHelpers.GetPythonTypeFromType throw or return null)? We wouldn't have to deal with potential null checks or try/catch when trying to get a PythonType.
Note that while the comment said it may return null it was also annotated with /*!*/ to say that it does not return null. :smile:


ModuleNotFoundError: No module named 'MinkowskiEngineBackend'

I am trying to reproduce the project on Colab. I was able to reproduce mostly everything but it seems that only the MinkowskiEngine installation has a problem. The error is as follow: (This is from import MinkowskiEngine as ME)
---> 53 from MinkowskiEngineBackend._C import (
54     MinkowskiAlgorithm,
55     CoordinateMapKey,
ModuleNotFoundError: No module named 'MinkowskiEngineBackend'
From the log it seems that the installation is completed:

The issue is similar to #76
This is my nvcc, g++ and gcc version:

Hi, this is probably a little late, but for anyone that's sees this issue, it's as simple as importing MinkowskiEngineBackend before importing MinkowskiEngine. I had this issue as well, and thought the build had failed, but alas.


Update Composer dependencies (2022-10-23-00-06)

Visual regression test passed!
View the visual regression test report


Chain Rule audit Log MATCHED_VAR

Description
When rule has "chain"  audit log MATCHED_VAR prints only last rule data
"messages": [
    {
        "actionset": "",
        "message": "country",
        "data": {
            "file": "",
            "line": 1016,
            "id": 1001,
            "rev": "",
            "msg": "country",
            "data": "Matched Data: %REQUEST_URI: /wp-login.php", //this has to be country information.
            "severity": 6,
            "ver": "",
            "maturity": 0,
            "accuracy": 0,
            "tags": [],
            "raw": "SecRule GEO:COUNTRY_CODE \"@within GB,GR\" \"id:1001,phase:1,msg:'country',deny,severity:'INFO',status:403, logdata:'Matched Data: %%{MATCHED_VAR_NAME}: %{MATCHED_VAR}',chain\""
        }
    },
    {
        "actionset": "",
        "message": "deneme",
        "data": {
            "file": "",
            "line": 1016,
            "id": 1001,
            "rev": "",
            "msg": "deneme",
            "data": "Matched Data: %REQUEST_URI: /wp-login.php",
            "severity": 6,
            "ver": "",
            "maturity": 0,
            "accuracy": 0,
            "tags": [],
            "raw": "SecRule GEO:COUNTRY_CODE \"@within GB,GR\" \"id:1001,phase:1,msg:'country',deny,severity:'INFO',status:403, logdata:'Matched Data: %{MATCHED_VAR_NAME}: %{MATCHED_VAR}',chain\""
        }
    }
]

this is chain rule
first one check country code and in chain rule check request uri

No comment?

Yes. This is a comment.

this is actually fine, the problem is we should only log one of the chains. MATCHED_VAR is set when you finish a rule, that way the next chain will have access to it

Thanks. I decided to not to use matched vars. I use every rule parameters instead of matched vars
thank toy

Shall we close this?

of course we can close it.
thanks for your effort.


New Feature: Props Composer inspired by Laravel's View Composer.

Hello Team!
This PR adds a Props Composer feature, which is inspired by View Composers in Laravel. I really think this would be a very good addition to Inertia.js.
How does this work
Just like in Laravel, you can use Inertia::composer() method in any service provider to set composers for specific components. You can use a composer class or a callback function, like so...
use Inertia;
use Inertia\ResponseFactory;

class AppServiceProvider extends ServiceProvider
{
    public function boot()
    {
        // Class-based approach..
        Inertia::composer('User/Profile', UserComposer::class);

        // Callback-based approach..
        Inertia::composer('User/Profile', function (ResponseFactory $inertia) {
            $inertia->with([
                'post' => [
                    'subject' => 'Hello World!',
                    'description' => 'This is a description.'
                 ]
            ]);
        });
    }
}

Then your composer class must contain a compose() method that will accept an instance of Inertia\ResponseFactory class as the first argument. Within this method you can call $inertia->with(); to set the composed props. This method can accept an array or key-value arguments.
use Inertia\ResponseFactory;

class UserComposer
{
    public function compose(ResponseFactory $inertia)
    {
        $inertia->with('list',  ['foo' => 'bar', 'baz' => 'buzz']);
    }
}

Of course, you can also use the same composer for multiple components like so...
Inertia::composer(['User', 'User/Edit'], UserComposer::class);

This PR implements #74 .


Bug: weird casting of 3_5 to 35 resulting in KeyError

This is easiest to explore in our inventory repo, but I will try to provide some context:
Some assets contain the following structure:
connectors:
  mDP: 1
  DP: 2 # 1 x out w/ MST
  HDMI: 1
  USB-A: 4
  USB-B: 1
  3_5: 1
  DVI: 1

However, when I try to perform any form of write action on that asset, it results in an error:
❱ onyo edit warehouse/display_dell_u2413f.abc123
ERROR: "'connectors.35'"

❱ onyo set --keys test=toast --asset warehouse/display_dell_u2413f.abc123
ERROR: "'connectors.35'"

Reading is a different story
❱ onyo cat warehouse/display_dell_u2413f.abc123
---
...
connectors:
  mDP: 1
  DP: 2 # 1 x out w/ MST
  HDMI: 1
  USB-A: 4
  USB-B: 1
  3_5: 1
  DVI: 1

The connectors key works, but something is weird/wrong with 3_5:
❱ onyo get --keys connectors connectors.DVI connectors.3_5 connectors.35 --path warehouse/display_dell_u2413f.abc123
 ──────────────────────────────────────────────────────────────
  connectors   connectors.DVI   connectors.3_5   connectors.35
 ──────────────────────────────────────────────────────────────
  <dict>       1                <unset>          <unset>
 ──────────────────────────────────────────────────────────────

When I edit the asset manually and change 3_5 to 3-5, everything is fine again:
❱ onyo get --keys connectors connectors.3_5 connectors.35 connectors.3-5 --path warehouse/display_dell_u2413f.abc123
  ──────────────────────────────────────────────────────────────
  connectors   connectors.3_5   connectors.35   connectors.3-5
 ──────────────────────────────────────────────────────────────
  <dict>       <unset>          <unset>         1
 ──────────────────────────────────────────────────────────────

When I enable debugging, I get the following traceback:
❱ onyo --debug set --keys test=toast --asset warehouse/display_dell_u2413f.abc123
...
ERROR: "'connectors.35'"
DEBUG:onyo:Traceback (most recent call last):
  File "/home/aqw/git/inm7/onyo/onyo/lib/utils.py", line 91, in __getitem__
    return effective_dict[parts[-1]]
           ~~~~~~~~~~~~~~^^^^^^^^^^^
  File "/home/aqw/.venvs/onyo/lib/python3.12/site-packages/ruamel/yaml/comments.py", line 853, in __getitem__
    return ordereddict.__getitem__(self, key)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '35'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/aqw/git/inm7/onyo/onyo/main.py", line 543, in main
    args.run(args)
  File "/home/aqw/git/inm7/onyo/onyo/cli/set.py", line 109, in set
    onyo_set(inventory=inventory,
  File "/home/aqw/git/inm7/onyo/onyo/lib/commands.py", line 82, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/aqw/git/inm7/onyo/onyo/lib/commands.py", line 1063, in onyo_set
    inventory.modify_asset(asset, new_content)
  File "/home/aqw/git/inm7/onyo/onyo/lib/inventory.py", line 437, in modify_asset
    self.raise_required_key_empty_value(new_asset)
  File "/home/aqw/git/inm7/onyo/onyo/lib/inventory.py", line 709, in raise_required_key_empty_value
    if any(v is None or not str(v).strip()
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aqw/git/inm7/onyo/onyo/lib/inventory.py", line 710, in <genexpr>
    for k, v in asset.items()
                ^^^^^^^^^^^^^
  File "<frozen _collections_abc>", line 894, in __iter__
  File "/home/aqw/git/inm7/onyo/onyo/lib/utils.py", line 93, in __getitem__
    raise KeyError(f"'{key}'") from e
KeyError: "'connectors.35'"

This behavior is reproducible with onyo new and templates.

This turns out to be a "bug" in the YAML spec, and ruamel is correctly following their insanity.

https://docs.saltproject.io/en/latest/topics/troubleshooting/yaml_idiosyncrasies.html#underscores-stripped-in-integer-definitions
https://yaml.org/type/int.html

Words fail me.
I will fix our inventory repo to no longer use underscores with integers. And will add this to the list of fsck checks.
Closing.

Comment: I don't know whether this would have been protected against by treating all key names as strings. (#671). I think the key name would need to be quoted to begin with.

Comment: I don't know whether this would have been protected against by treating all key names as strings.

I do currently think, that is the right direction.
We convert keys to strings currently only within dot notation (and there we have to), and that is the actual problem here.
We get an integer key and then end up accessing a (wrongly) stringified version of it, which fails.
Instead, we need to stringify the keys we get when reading the YAML, and do so by utilizing ruamel's internal knowledge of how it's actually represented (roundtrip), so we get '3_5' in this case rather than str(35).
Otherwise there likely will be a lot of corner cases where confusing errors happen.
In this case here, we get an error about a key, that the user didn't say to do anything with. This type of thing will remain troublesome, if we don't solve it properly.
But if it works as I currently think, there would be no need to restrict the YAML.
So - re-opening, since this needs addressing (and I think I know how).


Discounts sample remix update

Updates the discounts sample based on the latest Remix template.

tagging @devisscher just for visibility 🙏


3.x: Fix MP tracing guide to include adding helidon-microprofile-tracing dep

Fixes #4686

merge pipeline was stuck, but I verified it passed in Jenkins.


dep init -gopath analysis all repos in my gopath.

What version of Go (go version) and dep (git describe --tags) are you using?
go version go1.8.3 linux/amd64
dep v0.1.0-196-g5c02575
What dep command did you run?
dep init -gopath -v

What did you expect to see?
analysis dependence from my gopath, which is related to my porject.
What did you see instead?
it reslove dependence with all repo in gopath, but also including repos which are not used in my project.

it reslove dependence with all repo in gopath, but also including repos which are not used in my project.

Sorry, it's not clear to me what you expected vs. what occurred? It would really help if you could provide the URL of the repository you ran dep against, the output from running the command, and point out where you believe the behavior is incorrect/unexpected.

Also, in what path did you run dep init -gopath -v?

Below is my repo:
https://github.com/uniatlas/atlasctl
This my travis to create vendor with  dep init -gopath -v command:
https://github.com/uniatlas/atlasctl/blob/develop/CI/.travis.yml
Sorry , I did not preserve the logs, but you can generate new one for building the project, all inforamtion is in the logs of Travis.

@zh794390558 dep init is intended to be a one-time command, run to do initial setup and conversion. It can be fuzzy, and get things wrong at times. Using it in CI as you have here is not the intended usage, and may prove unpredictable.
The intended use pattern is to run dep init once yourself, commit the results, then use dep ensure as your workhorse command. By design, that means getting off of GOPATH pretty much entirely.

closing this out - not the intended usage of dep init.


Support XLSX documents

Issue you'd like to raise.
In doing some testing, I'm finding this library skips xlsx files. When I look a the code no loader is specified here:
https://github.com/pprados/langchain-googledrive/blob/5b82e7355b7de285beb69a0b191913cbbd65f163/langchain_googledrive/utilities/google_drive.py#L298-L314
Suggestion:
Is it possible to import UnstructuredExcelLoader and use that to index xlsx files? It feels like everything is in place to support this file format.

Activate the level info for log, and you can see which package to install for that.
Le ven. 5 avr. 2024 à 11:35, John Pariseau<EMAIL_ADDRESS>a écrit :
CAUTION: External email. Be cautious with links and attachments.
Issue you'd like to raise.
In doing some testing, I'm finding this library skips xlsx files. When I look a the code no loader is specified here:
https://github.com/pprados/langchain-googledrive/blob/5b82e7355b7de285beb69a0b191913cbbd65f163/langchain_googledrive/utilities/google_drive.py#L310https://urldefense.com/v3/__https://github.com/pprados/langchain-googledrive/blob/5b82e7355b7de285beb69a0b191913cbbd65f163/langchain_googledrive/utilities/google_drive.py*L310__;Iw!!OrxsNty6D4my!8RC0LKlAW7udFfD12jCsMIK0Jtw1cCMGVrvNW8tU5Q4Kq0WDvaZP_4EtRbMWOVVusfyg3zEIRyyjQL1qDlp_WD4MRQ8n$
Suggestion:
Is it possible to import UnstructuredExcelLoader and use that to index xlsx files? It feels like everything is in place to support this file format.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/pprados/langchain-googledrive/issues/9__;!!OrxsNty6D4my!8RC0LKlAW7udFfD12jCsMIK0Jtw1cCMGVrvNW8tU5Q4Kq0WDvaZP_4EtRbMWOVVusfyg3zEIRyyjQL1qDlp_WJ8lnCnD$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AABR7FWKANYDZ2RRCJANXT3Y3ZV4VAVCNFSM6AAAAABFYZZEXWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDONJRHA3DSNA__;!!OrxsNty6D4my!8RC0LKlAW7udFfD12jCsMIK0Jtw1cCMGVrvNW8tU5Q4Kq0WDvaZP_4EtRbMWOVVusfyg3zEIRyyjQL1qDlp_WNAIq2st$.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
--
Philippe PRADOS
Senior Manager Référent | +33 6 20 66 71 00tel:+33620667100
OCTO Technology - Part of Accenture
34, avenue de l'Opéra - 75002 Parishttps://www.google.com/maps?q=34+Avenue+de+l'Opera,+75002+Paris
www.octo.comhttps://www.octo.com/# - blog.octo.comhttps://blog.octo.com/#
--- This message is for the designated recipient only and may contain privileged, proprietary, or otherwise confidential information. If you have received it in error, please notify the sender immediately and delete the original. Any other use of the e-mail by you is prohibited. Where allowed by local law, electronic communications with Accenture and its affiliates, including e-mail and instant messaging (including content), may be scanned by our systems for the purposes of information security, AI-powered support capabilities, and assessment of internal compliance with Accenture policy. Your privacy is important to us. Accenture uses your personal data only in compliance with data protection laws. For further information on how Accenture processes your personal data, please see our privacy statement at https://www.accenture.com/us-en/privacy-policy.

Activate the level info for log, and you can see which package to install for that.

Doesn't the mime type mapper have to be updated though?
         "application/vnd.openxmlformats-officedocument.
         spreadsheetml.sheet": cast(
             TYPE_LOAD, partial(UnstructuredExcelLoader, mode=mode)
         ),  # XLSX

Yes,
Read the method default_conv_loader()
https://github.com/pprados/langchain-googledrive/blob/master/langchain_googledrive/utilities/google_drive.py#L166
and
update the attribute conv_mapping
https://github.com/pprados/langchain-googledrive/blob/master/langchain_googledrive/utilities/google_drive.py#L566C5-L566C17
.
You can map with what you want.
Le ven. 5 avr. 2024 à 11:35, John Pariseau @.***> a
écrit :

Issue you'd like to raise.
In doing some testing, I'm finding this library skips xlsx files. When I
look a the code no loader is specified here:
https://github.com/pprados/langchain-googledrive/blob/5b82e7355b7de285beb69a0b191913cbbd65f163/langchain_googledrive/utilities/google_drive.py#L310
Suggestion:
Is it possible to import UnstructuredExcelLoader and use that to index
xlsx files? It feels like everything is in place to support this file
format.
—
Reply to this email directly, view it on GitHub
https://github.com/pprados/langchain-googledrive/issues/9, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABR7FWKANYDZ2RRCJANXT3Y3ZV4VAVCNFSM6AAAAABFYZZEXWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDONJRHA3DSNA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

The version 0.1.40 manage excel file. Thanks


API version can be set using the Connection constructor, but not using the initialize method

I found possible to configure the API version using the Connection constructor like below:
        const conn = new jsforce.Connection ({
            instanceUrl: jwtResponse.instance_url,
            accessToken: jwtResponse.access_token,
            version: '52.0' // 🟢 Explicitly define an API Version without the 'v' character prefix
        }) ;
        console.log (`conn.version: ${conn.version}`) ; // 🟢 Display 52.0

However, I don't understand why it's not possible to configure the API version using the initialize method like below
        const conn = new jsforce.Connection () ;
        conn.initialize ({
            instanceUrl: jwtResponse.instance_url,
            accessToken: jwtResponse.access_token,
            version: '52.0' // 🔴 This doesn't work
        }) ;
        console.log (`conn.version: ${conn.version}`) ; // 🔴 Display 42.0

Is there a way to it using the initialize method?
Thank in advance

triaging old issues...
closing this because conn.initialize was removed in jsforce v2.


feat: Use variable for datasource in Grafana Dashboard to improve support when importing

Please provide a description of this PR:
This enhances the Grafana Dashboards for Istio to get the Prometheus datasource dynamically instead of requiring that there be a datasource named Prometheus [or post-rendering of the dashboard JSON to update datasource]
This is a backwards compatible enhancement -- if your datasource is named Prometheus there is no issue.  If your Prometheus datasource is named something else [i.e. External Prometheus], this enhancement makes it so that no changes are required to the dashboard for datasource and more people should be able to simply download + import the dashboard and have it "just work"

:shipit:

I think there is some magic that makes https://grafana.com/grafana/dashboards/7645 somehow work this way already. I doubt this would break it but may want to double check. The code is in istio/release-builder; I can check later when I am at a computer

It looks like Dashboards in release-* branches are not getting "externalized" and so Dashboards in git [even a release branch] will differ than what is published to Grafana.com for the same release.  As an example here's the diff for two sources of the 1.13.3 Istio Workload Dashboard:
https://grafana.com/api/dashboards/7630/revisions/115/download <-> https://github.com/istio/istio/blob/1.13.3/manifests/addons/dashboards/istio-workload-dashboard.json
  Diff of Latest / Istio Workload Dashboard v1.13.3 on Grafana.com <-> Istio Workload Dashboard on tag `1.13.3` in Git Repo
diff -b git_1.13.3_Dashboard.json grafana_1.13.3_Dashboard.json
2,37d1
1a2,37
>   "__inputs": [
>     {
>       "name": "DS_PROMETHEUS",
>       "label": "Prometheus",
>       "description": "",
>       "type": "datasource",
>       "pluginId": "prometheus",
>       "pluginName": "Prometheus"
>     }
>   ],
>   "__requires": [
>     {
>       "type": "grafana",
>       "id": "grafana",
>       "name": "Grafana",
>       "version": "6.4.3"
>     },
>     {
>       "type": "panel",
>       "id": "graph",
>       "name": "Graph",
>       "version": ""
>     },
>     {
>       "type": "datasource",
>       "id": "prometheus",
>       "name": "Prometheus",
>       "version": "5.0.0"
>     },
>     {
>       "type": "panel",
>       "id": "table",
>       "name": "Table",
>       "version": ""
>     }
>   ],
14a51
>   "description": "Istio Workload Dashboard version 1.13.3",
16c53
<   "gnetId": null,
---
>   "gnetId": 7630,
66c103
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
167c204
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
264c301
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
383c420
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
485c522
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
623c660
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
730c767
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
837c874
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
1001c1038
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
1163c1200
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
1325c1362
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
1429c1466
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
1572c1609
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
1679c1716
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
1786c1823
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
1950c1987
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
2112c2149
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
2274c2311
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
2377c2414
<           "datasource": "Prometheus",
---
>           "datasource": "${DS_PROMETHEUS}",
2508c2545
<         "datasource": "Prometheus",
---
>         "datasource": "${DS_PROMETHEUS}",
2530c2567
<         "datasource": "Prometheus",
---
>         "datasource": "${DS_PROMETHEUS}",
2556c2593
<         "datasource": "Prometheus",
---
>         "datasource": "${DS_PROMETHEUS}",
2578c2615
<         "datasource": "Prometheus",
---
>         "datasource": "${DS_PROMETHEUS}",
2600c2637
<         "datasource": "Prometheus",
---
>         "datasource": "${DS_PROMETHEUS}",
2622c2659
<         "datasource": "Prometheus",
---
>         "datasource": "${DS_PROMETHEUS}",

https://github.com/istio/release-builder/blob/ae5c1413d28439b2d1a034047f7893ff87ac7475/pkg/build/grafana.go#L130-L135
The goal of this PR is to modify Grafana Dashboards in git so that they are able to be imported into Grafana directly using the JSON source from git repo without modification [typically from a release branch/tag].  Looking at release-builder, at minimum the ReplaceAll would need to be updated:
https://github.com/istio/release-builder/blob/ae5c1413d28439b2d1a034047f7893ff87ac7475/pkg/build/grafana.go#L131
Thinking about it a bit more though, perhaps the step to Use Variable for Dashboard Datasource can be removed entirely from "externalize" if it is implemented in the upstream dashboard source instead [benefiting those importing from git repo/source c ode, and ideally no change for those importing from Grafana.com]


Add validation against function call recursion #1019

Recursion validation implemented using BFS algorithm for nested function calls as graph nodes.
Implemented scenarios:

Function calls itself def fun1(x): fun1(x);
Several functions calls each other in a cycle, e.g.:

def fun1(x):
    fun2(x) + fun2(x) + fun3(x);

def fun2(x):
    fun3(x) + fun4(x);

def fun3(x):
    3*x;

def fun4(x):
    fun3(x) + fun1(x);

Here every affected call in the cycle gets a validation error (fun1::fun2, fun2::fun4, and fun4::fun1). In case a function B is called several times from a function A, only first call instance is marked with error (e.g., only first fun1::fun2).

If a Module has multiple recursion cycles, all of them are identified. See example scenarios in example/recursions.calc.

Implements #1019


Fix tfdoc replacement for empty source tables

Force merging as this fixes a dumb mistake on my side that potentially breaks tfdoc replacement.


Change Log collection to use the log depot based on the context of the request: appliance or zone based

Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1197869
We allow users to configure a log depot at both the Zone and individual Appliance level and also let them request logs from either a Zone or Appliance context.
At some point long ago, we had been doing log collection correctly according to this issue but we have been doing it wrong for a long time.  This issue is to track how we want to do to correct the situation.
Existing behavior for both Zone and Appliance level log collection:
Appliance log depot is preferred but Zone level depot is used as a backup.
Note, "existing" takes into the fixes applied in https://bugzilla.redhat.com/show_bug.cgi?id=1186485, namely https://github.com/ManageIQ/manageiq/pull/1850.

Appliance Depot
Zone Depot
Logs Uploaded To

X
X
Appliance depot

X

Appliance depot

X
Zone depot

Fails with not configured

New behavior:
The proposed behavior is that we use the log depot configured based on the context in which the log collection is performed:  Zone context, use Zone depot.  Appliance context, use Appliance depot.
Proposed behavior for Zone level log collection:
Note:  Changed behavior is italicized

Appliance Depot
Zone Depot
Logs Uploaded To

X
X
Zone depot

X

Fails with not configured

X
Zone depot

Fails with not configured

Proposed behavior for Appliance level log collection:

Appliance Depot
Zone Depot
Logs Uploaded To

X
X
Appliance depot

X

Appliance depot

X
Fails with not configured

Fails with not configured

@h-kataria please confirm this is what the UI does now and could be changed to pass along the log collection context (zone or appliance)

The original intent of separating zone-level and appliance-level depots was to provide a one-click, easy to use way for a customer to collect all of the appliance logs for a zone, while retaining the flexibility (using the appliance depot) to collect individual appliance logs if necessary.  The zone-level log collections are intended to be totally independent of the appliance-level depot which means that a full set of logs for all appliance in a zone is easily collected without requiring that a customer or implementer manually configure any appliance depot for any appliance in the zone.
It is totally acceptable for both the zone depot and each or any appliance depot to be the same location, but as they are treated independently configured and non-related configuration elements.
The chart Jrafanie has created seems to preserve that behavior as the success or failure of each log collection is dependent only on the context from which the log collection request originates.  Zone-level log collection is only dependent on zone-level depot specification and appliance-level log collection is only dependent on appliance-level depot specification.
This completely avoids the situation where some logs may be directed to the zone depot and others are directed to separate appliance depot(s).

Blocked by https://github.com/ManageIQ/manageiq/issues/1506 (unable to confirm in the UI)


[Question] Get instanceView when listing all VMs

I have some code that lists all VMs in a subscription and I would like to get the instance view in the request. I used to do this
filter := "$expand=instanceView"
pager := vmClient.NewListAllPager(&armcompute.VirtualMachinesClientListAllOptions{
    Filter: &filter,
})

And then use the pager but attempting to do this with the filter now gives me a 400 bad request. Is there a different way of doing this?

@jacobkilby , it should be Expand.
&armcompute.VirtualMachinesClientListAllOptions{Expand: &filter}


initialize_origin.py not installed

Hello,
I try to invoke the initialize_origin.py script from my launch file as such:
    <node pkg="swri_transform_util" type="initialize_origin.py" name="initialize_origin" >
        <param name="local_xy_frame" value="/map"/>
        <param name="local_xy_origin" value="Spata"/>
        <rosparam param="local_xy_origins">
            [{ name: Spata,
             latitude: 37.9879772,
             longitude: 23.9078602,
             altitude: 129.69,
             heading: 0.0}]
        </rosparam>
    </node>

I get the error:
ERROR: cannot launch node of type [swri_transform_util/initialize_origin.py]: can't locate node [initialize_origin.py] in package [swri_transform_util]

catkin can't see the python script as executable.
I fixed it by chmod +x the .py script, but it's not ideal.
I noticed that you recently added an install target to the script but perhaps it doesn't work?
I have the latest version of marti_common git pulled in my workspace.

Hmm... when I build and install swri_transform_utils in my own workspace, it looks like initialize_origin.py is installed and marked as executable in install/lib/swri_transform_util/initialize_origin.py .  Also, after installing the official ros-indigo-swri-transform-util package, it is installed and executable at /opt/ros/indigo/lib/swri_transform_util/initialize_origin.py
In your clone of the repository, is the file present & exectuable in marti_common/swri_transform_util/nodes/ ?  Also, does the CMakeLists.txt file for swri_transform_util have a catkin_install_python call for initialize_origin.py?

Ah, I have a guess on what's wrong.
I needed to format my laptop yesterday. I backed up and copy/pasted the marti_common folder in my new workspace.
However, the executable was assigned to my previous user account and hence the .py file was not executable any more.


added a configure option for the configurator type

Shopware 5 made it easy to choose a different selection format for the variants. I added a small configuration option inside the PlentyConnector as this has to be set foreach product individually.

Danke.


During hot reload English characters are not being registered after inputting Arabic character

when we run flutter using the command line in visual studio code or another code editor , we need to press (R for restart or r for hot-reload or q or etc...) , there is a small problem ..
my keyboard are English & Arabic , when i press r to make hot-reload and i am using the arabic language it do nothing and when i change the language to english after i pressed the arabic letter it do nothing too , because the console has received my arabic letter , and don't understand my english letter after it ...
i have to press CTRL+C to terminate the debug session and re-run the flutter run --verbose again ..
so , please make the console reject any Char or letter if flutter is in run mode and only accept the known chars or letters like (R,r,q,etc..) ..
i hope you understand :)

also when i press CTRL+C .. it request a confirmation like this: Terminate batch job (Y/N)?
if i press any other letter/Char .. it re-request the confirmation (and this is good :+1:)
the problem: if i press (N) it exit and terminate the session too ..
so fix it , if we press n/N just back to the default mode (that make us use R,r,q,etc ..)
thanks to all.

Since this issue is not reproducible, I am closing this as fixed. If you disagree, please comment and we can reopen it. Thank you


Remove bluebird props test

Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!

[ ] There's a clear use-case for this code change, explained below
[ ] Commit message has a short title & references relevant issues
[ ] The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

copilot:summary

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@09cbfae). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head e190ddb differs from pull request most recent head ac419f2. Consider uploading reports for the commit ac419f2 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage        ?   71.66%
=======================================
  Files           ?     1816
  Lines           ?   115150
  Branches        ?    16687
=======================================
  Hits            ?    82524
  Misses          ?    31506
  Partials        ?     1120

Flag
Coverage Δ

e2e-tests
66.53% <0.00%> (?)

unit-tests
63.54% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Updating database forever

I updated K-9 to 5.113 and now it is busy updating some database, and has been for the last two hours.
It is draining battery faster than I can recharge and has by now filled up 6 GiB of storage.

OK, well, after almost five hours, it finally crashed and started all over.

Please record a debug log: https://github.com/k9mail/k-9/wiki/LoggingErrors

@cketti 5 hours long?

Well, the most important thing would be the stack trace that is logged when the app crashes. Otherwise you didn't provide much information we can work with.

I got a many thousands of lines long log, then had to remove K-9 to make my device usable again.
Will see to find the relevant parts.

same thing for me since noon. K9mail stuck for hours.

I have been having this issue today as well.  It has been running since at least 8 AM (almost 5 hours) saying "Upgrading database of account 'X'".  I haven't tried killing it or anything, but it drained my battery down to 37% in a very short period of time.  I have my phone plugged in now and it is re-charging, but the upgrade process does not seem to be working.

I uninstalled K9mail a short while after I posted my message. Now I wonder if I should re-install it, or wait for the next version. Anyone uninstalled k9mail and re-installed it? Does it work? or should we wait for a fix? K9mail is so great that it is really a pain not to be able to use it.

If you uninstalled, the data is gone. There is no database to be upgraded on a fresh install.

I did not uninstall mine.  It still says it is upgrading.

We finally found the problem in #1947, will release a fix soon. If you didn't reinstall, your data should be fine when we fix the migration.


Update 01-Overview.md

tiny changes

Thanks for doing this, appreciate the work! Seems like you are still reading so just ping me here when you're done.

Accidentally deleted my working repo 🤦
Luckily this PR made it easy to move them into new one #231


Image not loading

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

https://developer.mozilla.org/ko/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-label_attribute

Cannot reproduce the issue, so closing. It may have been fixed it in the mean-time.


[help] How can I fetch liquidation data of all the users in futures?

Python version: 3.7
OS: macOS Big Sur 11.6
python-binance==1.0.15

On these sites (https://coinalyze.net/ethereum-classic/liquidations/, BTC/USDT), I am able to add following indications into graph [Liquidations, Long Liquidations, Short Liquidations, Aggregated Liquidations COIN-margined Contracts, Aggregated Liquidations STABLECOIN-margined Contracts], which make me think that its possible to fetch liquidations of all the pairs in Binance/Futures.
=> Is it possible to obtain data for liquidations (all the users) in cryptocurrencies using python-binance?
I have tried following code, which returns empty list as []:

client = Client(api_key, api_secret)

class Fetch_liq:
    def _futures_coin_liquidation_orders(self, **params):
        """Get all liquidation orders

         __ https://binance-docs.github.io/apidocs/delivery/en/#user-39-s-force-orders-user_data
        """
        # return client._request_futures_api('get', 'forceOrders', signed=True, data=params)
        return client._request_futures_coin_api("get", "forceOrders", data=params, signed=True)

    def get_future_coin_liquidation_orders(self, symbol=None):
        return self._futures_coin_liquidation_orders(
            symbol=symbol,
            autoCloseType="LIQUIDATION",
            limit=100
        )

cf = Fetch_liq()
print(cf.get_future_coin_liquidation_orders(symbol="ETCUSD_PERP"))  # returns `[]`

Any help would be appreciated.
Related:

https://github.com/sammchardy/python-binance/issues/873#issue-899208978
https://github.com/ccxt/ccxt/issues/10234
https://binance-docs.github.io/apidocs/futures/en/#liquidation-order-streams
https://github.com/Binance-docs/Binance_Futures_python/blob/master/binance_f/model/liquidationorder.py

Fetching from self.socket = "wss://fstream.binance.com/ws/!forceOrder@arr" solved my issue.
self.socket = "wss://fstream.binance.com/ws/!forceOrder@arr"
self.ws = websocket.WebSocketApp(self.socket, on_message=self.on_message, on_close=self.on_close)
ws.run_forever()

Hi there, I was looking at your code and see that this only returns real-time liquidations. Do you also know if historical data can be retrieved? Can't find it anywhere. Thanks!

Can I add liqudation data to freqtrade strategy as indicator, example proof of concept code:
import websocket
def on_message(ws, msg):
print(msg)
def on_close():
print("closed")
socket = "wss://fstream.binance.com/ws/!forceOrder@arr"
ws = websocket.WebSocketApp(socket, on_message=on_message, on_close=on_close)
ws.run_forever()

Hi ! Have you found a way to get that data ?
Thanks for your help

Hi there, I was looking at your code and see that this only returns real-time liquidations. Do you also know if historical data can be retrieved? Can't find it anywhere. Thanks!

It took some time for me to find a source, but I discovered that Binance keeps track of this historical data and can easily be accessed on https://data.binance.vision/. Here you can see the historical liquidation data, for instance for USD-M BTC-USD perp is this URL: https://data.binance.vision/?prefix=data/futures/cm/daily/liquidationSnapshot/BTCUSD_PERP/. You can also find other useful historical data on that website.
I also found this repo https://github.com/aoki-h-jp/binance-bulk-downloader that implemented a downloader for it.

@Fabio007 @QuantFlows

Hi there, I was looking at your code and see that this only returns real-time liquidations. Do you also know if historical data can be retrieved? Can't find it anywhere. Thanks!

It took some time for me to find a source, but I discovered that Binance keeps track of this historical data and can easily be accessed on https://data.binance.vision/. Here you can see the historical liquidation data, for instance for USD-M BTC-USD perp is this URL: https://data.binance.vision/?prefix=data/futures/cm/daily/liquidationSnapshot/BTCUSD_PERP/. You can also find other useful historical data on that website.
I also found this repo https://github.com/aoki-h-jp/binance-bulk-downloader that implemented a downloader for it.

Thanks


Dragging and dropping a mover inside containerMovable very fast, sometimes causes components to jump in chrome

Fixed in version 1.2.4


fixes #9784: fix concurrency issue with a shared_ptr

fixes https://github.com/envoyproxy/envoy/issues/9784
@jmarantz: could you give this a try when you get a chance?

@jmarantz, apologies, just saw your comment.

do you mean you ran the exact command I gave to repro and it passed 100/100 times?

Yes, the test suite passes 100/100 when built/executed under gcc.

Can you run this under clang though? I don't think gcc could process --config=clang-tsan and in fact I'm surprised that worked at all.
Also can you merge master?

/wait

Hi @dmitri-d -- are you going to be able to get the chance to pick this up and repro with clang?
Per above, I don't think it makes sense to try to repro with gcc as it's under clang's tsan checks that we notice the failure.

Hey @jmarantz, nods I will try to reproduce this with clang, I might get a chance next week. Was pretty busy with ServiceMesh release...

Hmm. I'm not sure what's going on here. A race is reported here: https://github.com/envoyproxy/envoy/blob/master/source/common/router/rds_impl.cc#L303 when current_cb weak_ptr goes out of scope and its destructor is called:
 Write of size 8 at 0x7b140002c510 by thread T7:
    #0 free /local/mnt/workspace/bcain_0721/llvm/utils/release/final/llvm.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:706:3 (vhds_integration_test+0x21e9578)
    #1 std::__1::_DeallocateCaller::__do_call(void*) /home/wb/opt/clang+llvm/bin/../include/c++/v1/new:334:12 (vhds_integration_test+0x22a1398)
    #2 std::__1::_DeallocateCaller::__do_deallocate_handle_size(void*, unsigned long) /home/wb/opt/clang+llvm/bin/../include/c++/v1/new:292:12 (vhds_integration_test+0x22a1364)
    #3 std::__1::_DeallocateCaller::__do_deallocate_handle_size_align(void*, unsigned long, unsigned long) /home/wb/opt/clang+llvm/bin/../include/c++/v1/new:262:12 (vhds_integration_test+0x22a1304)
    #4 std::__1::__libcpp_deallocate(void*, unsigned long, unsigned long) /home/wb/opt/clang+llvm/bin/../include/c++/v1/new:340:3 (vhds_integration_test+0x22a1298)
    #5 std::__1::allocator<std::__1::__shared_ptr_emplace<std::__1::function<void (bool)>, std::__1::allocator<std::__1::function<void (bool)> > > >::deallocate(std::__1::__shared_ptr_emplace<std::__1::function<void (bool)>, std::__1::allocator<std::__1::function<void (bool)> > >*, unsigned long) /home/wb/opt/clang+llvm/bin/../include/c++/v1/memory:1816:10 (vhds_integration_test+0x31717a1)
    #6 std::__1::__shared_ptr_emplace<std::__1::function<void (bool)>, std::__1::allocator<std::__1::function<void (bool)> > >::__on_zero_shared_weak() /home/wb/opt/clang+llvm/bin/../include/c++/v1/memory:3593:9 (vhds_integration_test+0x3171095)
    #7 std::__1::weak_ptr<std::__1::function<void (bool)> >::~weak_ptr() /home/wb/opt/clang+llvm/bin/../include/c++/v1/memory:5037:19 (vhds_integration_test+0x32d9e37)
    #8 Envoy::Router::RdsRouteConfigProviderImpl::onConfigUpdate() /proc/self/cwd/source/common/router/rds_impl.cc:303:5 (vhds_integration_test+0x32bf78a)

The previous read from another thread was here:
  #0 std::__1::__shared_count::__release_shared() /home/wb/opt/clang+llvm/bin/../include/c++/v1/memory:3415:9 (vhds_integration_test+0x22aea7f)
    #1 std::__1::__shared_weak_count::__release_shared() /home/wb/opt/clang+llvm/bin/../include/c++/v1/memory:3457:27 (vhds_integration_test+0x22aea02)
    #2 std::__1::shared_ptr<std::__1::function<void (bool)> >::~shared_ptr() /home/wb/opt/clang+llvm/bin/../include/c++/v1/memory:4393:19 (vhds_integration_test+0x314c877)
    #3 Envoy::Extensions::HttpFilters::OnDemand::OnDemandRouteUpdate::~OnDemandRouteUpdate() /proc/self/cwd/bazel-out/k8-dbg/bin/source/extensions/filters/http/on_demand/_virtual_includes/on_demand_update_lib/extensions/filters/http/on_demand/on_demand_update.h:10:7 (vhds_integration_test+0x314c7f5)

when the OnDemandRouteUpdate filter's destructor that holds the original callback shared_ptr was called.  I checked that I don't pass references to shared_ptr/weak_ptr from one thread to another anywhere in the code, only copies. With my understanding of shared_ptr/weak_ptr concurrency, what I'm doing is correct and shouldn't cause any issues. Perhaps someone else can take a look? @lambdai would you have time?

ping

I've yet to see tsan fail when there wasn't a race.  Looks like there might be a teardown issue?  I'd suggest adding a test where we kill the request and tear down the filter when there's a route request in progress.  I suspect that'll make the failure mode more clear - if not I'll agree to take a whack at it.

whoops - commentd in the wrong place - deleting here, adding onth eissue


Clean ci

Closes #109
Fixes #113
Checklist

[X] I have made a material change to the repo (functionality, testing, spelling, grammar)
[X] I have read the [Contribution Guide] and my PR follows them.
[X] I updated my branch with the master branch.
[X] I have added tests that prove my fix is effective or that my feature works
[X] I have added necessary documentation about the functionality in the appropriate .md file
[X] I have added in line documentation to the code I modified

Short description of what this PR does:

Clean travis.yml file impl
Closes previous issue and invalid PR

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat(storage): custom tables

Addresses #4546
This is a first draft how to support custom tables. Any feedback highly appreciated (or if this approach is not good and some other is preffered)
Example in the action:

https://github.com/silius-rs/silius/blob/chore/reth_db/crates/mempool/src/database/tables.rs
https://github.com/silius-rs/silius/blob/chore/reth_db/bin/silius/src/bundler.rs#L252

hmm, what's your use case for this? adding new tables to the existing DB?
we don't really want to open this up becomes then it becomes harder to transition to a new db in the future

The use case is to use crate reth_db for database in our project. But we are not using the same tables as reth node, but we have some custom tables (https://github.com/silius-rs/silius/blob/chore/reth_db/crates/mempool/src/database/tables.rs)
If this is not the intended use of reth_db, no problem, we'll use something else

reopening this, because this is still something we want to support and this is likely useful

I'm closing this now that we have a path forward here
ref #13130

Awesome! I'll take a look at new approach

not quite there yet, but almost


#376, v1.8.1 CustomView have Button can't response Action

add constraints to "contentView", and this problem is resolved.

please merge it @dzenbot


Customization of DrawerNavigator

Hi, I'm sure this is likely a simple fix, it's just taken me way too long and I'm getting more and more frustrated.
I have a DrawerNavigator nested within my main StackNavigator:
const MainNavigator = StackNavigator({
  login: { screen: Auth },
  signup: { screen: SignUp },
  home: { screen: Home },
  history: { screen: History },
  main: {
    screen: DrawerNavigator({
      supplier: { screen: SupplierNavigator },
      messaging: { screen: Messaging },
      profileDev: { screen: ProfileNavigator },
      settingsDev: { screen: SettingsNavigator}
    }, {
      drawerPosition: 'right',
      drawerWidth: 300,
      contentComponent: props => <Drawer {...props}/>,
    })
  },
  basket: { screen: Basket },
  sendOrder: { screen: SendOrder }

})
Whenever I click the 'DrawerOpen' button I am presented with this screen:

I want to remove the "Order History" back button.
drawerLabel as a prop is not affecting anything, neither is drawerIcon. I've tried to putting them in the navigationOptions prop, in my customComponent component, in the custom header I am using in the DrawerNavigator screens, in the screens themselves in the navigationOptions, I've tried adjusting and manipulating it in contentOptions, plus many more variations that I can't remember right now.
I haven't included these as snippets/screenshots as there would be too many to list. I have a feeling the issue is to do with my nesting of the DrawerNavigator within a StackNavigator, but to be honest, at this point I'm not sure.
Any help would be much appreciated :)

Hi! In an effort to get the hundreds of issues on this repo under control I'm closing issues tagged as questions. Please don't take this personally - it's simply something we need to do to get the issues to a manageable point. If you still have a question I encourage you to re-read the docs, ask on StackOverflow, or ask on the #react-navigation Reactiflux channel. Thank you!


No openapi.json?

To facilitate API testing, it would be helpful if we could get an openapi.json. Otherwise we'll have to roll a custom API client, which may not conform to the expectations of the API.

We will create one.  think we have just missed it.

I'll open an issue in JIRA and close out this issue.


Use in Angular 2 component

Any ides how to use this in the component, i.e:
this.message = "Hello world"
Or any similar workaround?
For example if that message is shown in the template as:
(tap)="alert(this.message)"

You can use it directly like this:
import { localize } from "nativescript-localize";
this.message = localize("Hello world");


Mode 1000 (kanji mode) not yet implemented

When scanning certain barcodes, I get
Mode 1000 not yet implemented.

https://github.com/piderman314/bardecoder/blob/e1fcff7f4975c8f9cc430b61b0a0ac29a4b1dd78/src/decode/qr/data.rs#L16
Not a huge deal - I don't encounter these much - but it would probably be nice to implement kanji mode eventually.

Indeed, I have never seen these before. Since I have zero experience with JIS I don't think I'll spend the effort until someone has an actual usecase.


python310Packages.pycketcasts: init at 1.0.1

Description of changes
Module to interact with PocketCast's unofficial API
https://github.com/nwithan8/pycketcasts
This is a Home Assistant dependency.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 177483 run on x86_64-linux 1

2 packages built:

python310Packages.pycketcasts
python39Packages.pycketcasts


Mapping GS1 Attribute Project

GS1 has over 8000 attributes - a mixture of boolean features like "If From Concentrate, If Herbal
If in Sauce", and many that are more taxonomic like "Type of Aquatic Invertebrate/ Fish/ Shellfish/ Seafood Mix;Type of Aquatic Plant", and some ordinal like "Diameter of Cigarette".  Many are also associated with particular kinds of foods.  So mapping these to FoodOn or visa versa requires analysis of a number of particular attribute branches.
We can kickstart the mapping exercise with these GS1 attributes that many food items have:

Shelf stable
Perishable
Frozen

"Frozen" is truly a quality of a material entity.  "Shelf stable" and "Perishable" are more like information content entities - not something observable in the moment.  An implication of the latter two is that the thing being described is stored mainly within a certain temperature range.

@ddooley An ongoing issue is the linkage of gs1:Product, schema:Product and Foodon Food Products. gs1 and schema.org have "product" view of things to which they attach attributes that makes sense operationally but not necessarily ontologically.
@JessSing and I have been working on some work arounds to resolve the product <> food gaps but it is not necessarily perfect. Would like to talk about this on the 23rd.


NEW: Adding a bashExample for metadataExtractor

FIX: refactoring the laoding of the externalMetadataExtractor in the example

Current coverage is 40.11% (diff: 100%)

Merging #113 into master will not change coverage

@@             master       #113   diff @@
==========================================
  Files            22         22
  Lines          3101       3101
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1244       1244
  Misses         1756       1756
  Partials        101        101

Powered by Codecov. Last update b5e9662...8f6ab06


jasmine2 framework configuration issue

I upgraded jasmine library to 2.3 version. Updated all tests according jasmine 2.3 documentation.
When I use following config
exports.config = {
    framework: 'jasmine2',

I have issues:
Message:
Failed: Object # has no method 'addMatchers'
Stack:
TypeError: Object # has no method 'addMatchers'
When I use config without framework property it works well all tests are fired.

Replaced this.addMatcher inot jasmine.addMatcher.It works with jasmine2 framework settings.
should I write everywhere jasmine.addMatchers?

If you're trying to use jasmine2, your code should be adopted to the corresponding API-changes. A full upgrade guide can be found here. The custom matchers are listed first.

all tests use new API, custom matcher are adopted too.
in protractor instead of jasmine.* I always wrote this.*
But when I use jasmine2 in configuration this.addMatcher doesn't work as it worked before

As I've mentioned, please read the jasmine2 upgrade guide (referenced above):

The addMatchers function is no longer on the spec (this) it is now on the global jasmine object.

Also note that jasmine.addMatchers requires a spec context - I'd suggest to call it in beforeAll definitions.

thanks


Adds EditionMaxMinter

EditionMaxMinter is a cheaper alternative to RangeEditionMinter and should be used whenever an artist plans to only have a single public sale for an edition.

Hey!! Any news on when it's going to be merged?

Hey!! Any news on when it's going to be merged?

We're actually not likely to integrate this minter now but I'll let @vigneshka confirm


Add inxi

Name: inxi
Language: Perl
URL: https://github.com/smxi/inxi
Description: inxi is a full featured CLI system information tool. It is available in most Linux distribution repositories, and does its best to support the BSDs.

I like it. Can you send a PR?


Add auth to Rapid requests

During the v3 update authentication was removed from the requests, breaking the library. See issue #27 (this PR does not solve the fact an authentication failure doesn't return an error).

@barryvdh @delatbabel
Hi all, can we look at merging this in, this gateway is non-functional with the authentication broken.

Ah yes, the setAuth() doesn't seem to have been ported in https://github.com/thephpleague/omnipay-eway/pull/26

It also looks like this can all be in a base request class, but that's for future enhancements.

Thanks @barryvdh - can you push a new version?
I did end up duplicating the code a lot, certainly needs a refactor but didn't want to complicate this fix.

Tagged


Parsing an element with just spaces inside parsed as empty table

Parsing element <NumberPlateText>        </NumberPlateText>  becomes NumberPlateText = {} but expected NumberPlateText = "        "

try to use <NumberPlateText> </NumberPlateText>


Need help correctly switching between orthographic and perpective projection.

I have been using Perspective::new(aspect, fovy, znear, zfar) and Orthographic::from_fov(aspect, vfov, -zfar, zfar) to construct two projection matrices. I am now trying to seamlessly switch between the two with a key press. I have my view matrix constructed fromIsometry3::look_at_rh(pos, target, up) and converted to 4x4 matrix during rendering with view.to_homogeneous(). Similarly the proj matrix is created with Matrix4::from(proj). However, when I actually switch between the two projection, the orthographic view is more zoomed out than the perpsective. What is the correct way to convert between these two? I though fovy and zfov were both vertical field of view that matched when switching from perspective to orthographic and vice versa.

Digging around stack overflow I found: https://stackoverflow.com/questions/23719474/converting-perspective-projection-to-orthogonal-projection?answertab=votes#tab-top
which helped me convert perspective into ortho using:
let halfy = fovy / 2.;
let height = view.translation.vector.magnitude() * halfy.tan();
let width = height * self.aspect_ratio;
Projection::Orthographic(Orthographic3::new(
    -width,
    width,
    -height,
    height,
    -zfar,
    zfar,
))

This is very similar to how Orthographic::from_fov is implemented but seems like using distance from viewport helped me maintain the same zoom level. Don't know how I can achieve the same effect using Orthographic3::from_fov instead of Orthographic3::new. But atm this fixes my issue. Hope somebody finds this useful.


JS: Add XSS-through-dom query

Adds a new query js/xss-through-dom.
Relevant CVEs:

CVE
source
sink

CVE-2019-14862
element.name
IE7 document.createElement(..)

CVE-2016-10735
element.getAttribute("data-target")
$(..)

CVE-2019-8331
element.getAttribute('data-original-title')
$().html(..)

CVE-2019-15482
$().text()
$(..)

CVE-2019-12313
element.innerText
element.insertAdjacentHTML(..)

CVE-2018-19048
$().val()
element.innerHTML

CVE-2018-8035
element.value
$.jGrowl(..)

All of the above CVEs reads a string from a DOM node (attribute or text-node), where that string is controlled by someone else (e.g. a client, another library, rendered by a server...).
This string then ends up in an XSS sink, and a safe text thereby becomes unsafe HTML.
So the query does not flag vulnerabilities that are immediately exploitable. An attacker needs a write primitive to the relevant location.
But the point is that the write primitive is safe on its own, and an xss-through-dom vulnerability will escalate the attack by unescaping the text.
The query currently flags a lot of results, many of these are just bad style and not necessarily exploitable.
Here are some results: https://lgtm.com/query/2351488529036590711/
Many of the results are the old bootstrap CVE (CVE-2016-10735).
(That CVE existed across many versions of bootstrap. The query does not currently flag all versions).
With this PR we get 2 CVE TPs, and one step closer to 4 more CVE TPs.
(I don't know how many of the last 4 we can reasonably get. 3 of them miss have missing type/data-flow, and the last is a missing $.jGrowl sink)
An evaluation shows that the performance overhead is not that big.
TODO:

[ ] Generalize the new SanitizerGuardNodes to DomBasedXss?
[x] change-note

@erik-krogh - this looks good
There is a small number of minor comments for your consideration.
Also could you add an update to the change notes (the page with a table summarizing the new and updated queries, and that also reports whether query results are shown on LGTM by default or not)? Thanks.

I've added the change note.

Hope this helps.

It did :+1:

@mchammer01: Can you approve the changes?


Add bzip2 as package

Could we add the bzip2 yum package in the slave images?
Because some of the NPM installs(example: npm install phantomjs-prebuilt) are failing because it cannot untar .tar.bz2 packages.

Assuming we should just install across the board ... agree @bparees ?

yeah