Zooming Out Keyboard Databinding Issue

VSCode Version: 1.6.1
OS Version: Windows 10 Enterprise [version 10.0.14393]
AZERTY French Keyboard

Steps to Reproduce:

Open any file text with Visual Studio Code
Do the shortcut Ctrl+-
The shortcut doesn't work

I enclose below the problem in settings of the binding and many other developers on Windows are facing the same issue like me.
Best Regards,
Maher

@MaherJendoubi Please hover over the red x and read the message.

So this means that zoomOut is not bound out of the box for your keyboard layout. The reason is simple:
"ctrl+-" is simply a UI representation for "ctrl+VK_OEM_MINUS", where VK_OEM_MINUS is a key code as defined here. For your current keyboard layout, no single key is mapped to that key code. Meaning regardless what you press on your keyboard, the OS will never generate the key code VK_OEM_MINUS.
Therefore, please go to File > Preferences > Keyboard Shortcuts and define a new keybindings for those commands as you would want them. Here I am doing it:

@alexandrudima Awesome! Thank you for the answer! Which tool are you using please to take such a screenshot?

I'm using LiceCap

Thanks a lot!

👍 👍 👍


Remove additional unused diagnostics.

Also fix typo in diagnostics verifier error message.

@swift-ci please smoke test


Add a check for handling updates to existing fields to decrease the minimums

This builds on top of #666 and focuses on adding a valid check to ensure that minimums can be decreased for existing fields in a CustomResourceDefinition schema.
If the proposal for adding this functionality to carvel-dev/kapp has been accepted prior to starting this work, all changes should be made against  carvel-dev/kapp, otherwise the changes should be made against https://github.com/everettraven/kapp/tree/feature/crd-upgrade-safety-preflight

The proposal has merged and work is now being tracked in carvel-dev/kapp. This issue is now a tracker for https://github.com/carvel-dev/kapp/issues/913

Closing as https://github.com/carvel-dev/kapp/issues/913 has been closed via a merged PR.


feat(EKS): added default node volume size configuration

Q
A

Bug fix?
no

New feature?
yes

API breaks?
no

Deprecations?
no

Related tickets
closes #3129, closes #3130

License
Apache 2.0

What's in this PR?

Added default node volume size configuration option and propagation to node pool creation from both cluster and node pool create requests. Also added AMI size check logic to ensure only bigger volume sizes are allowed.
Why?

To support configurable default node volume sizes. See the tickets for details.
Additional context

Changed the discussed implementation plans because the cluster creation request doesn't go through the NodePoolProcessor.ProcessNew() function and has no access to AWS activities at API server side which made me realize the difference between the image and volume size defaults is that the image is statically selected while the volume size is a dynamic information so instead decided to implement the selection at workflow/activity level wherever necessary.
Create/Update explicit value proxy logic is going to be added later.
(Many Bothans died to bring us this small PR.)
For the record: this is the 3rd iteration, because I first took the PKE example, but realized EKS is a little differently architected at the moment, then tried taking the node image example, but realized it solves a little different problem (static vs. dynamic source) and finally settled on this one.
Checklist

[X] Implementation tested (with at least one cloud provider)
[X] Code meets the Developer Guide
~OpenAPI and Postman files updated (if needed)~
~User guide and development docs updated (if needed)~
~Related Helm chart(s) updated (if needed)~

Test results
Cluster create unset default
<EMAIL_ADDRESS>(master u=)
> aws cloudformation describe-stacks --stack-name pipeline-eks-nodepool-pregnor-local-200901-pipeline-3129-unset-default-pool1 | jq -r '.Stacks[0].Parameters[] | select(.ParameterKey=="NodeVolumeSize")'

# Begin: 2020-09-02T09:21:16.348+02:00

{
  "ParameterKey": "NodeVolumeSize",
  "ParameterValue": "50"
}

# End: 2020-09-02T09:21:17.027+02:00
# Duration: 679ms
# Exit code: 0

<EMAIL_ADDRESS>(master u=)
> aws ec2 describe-volumes | jq -r '.Volumes[] | select(.Attachments[].InstanceId=="i-00a0f4a4f7f7a3b26")'

# Begin: 2020-09-02T09:34:23.930+02:00

{
  "Attachments": [
    {
      "AttachTime": "2020-09-02T07:13:25+00:00",
      "Device": "/dev/xvda",
      "InstanceId": "i-00a0f4a4f7f7a3b26",
      "State": "attached",
      "VolumeId": "vol-07fc99f91bc99b303",
      "DeleteOnTermination": true
    }
  ],
  "AvailabilityZone": "eu-central-1a",
  "CreateTime": "2020-09-02T07:13:25.141000+00:00",
  "Encrypted": false,
  "Size": 50,
  "SnapshotId": "snap-073e1d7e24630a32f",
  "State": "in-use",
  "VolumeId": "vol-07fc99f91bc99b303",
  "Iops": 150,
  "VolumeType": "gp2"
}

# End: 2020-09-02T09:34:24.894+02:00
# Duration: 964ms
# Exit code: 0

Cluster create set default (less than AMI image size)
cluster create workflow failed: selected volume size of 1 GB (default configuration) is less than the AMI image size of 20 GB
(Going to be updated once explicit volume size setting is also allowed.)
Cluster create set default (equal to AMI image size)
<EMAIL_ADDRESS>(master u=)
> aws cloudformation describe-stacks --stack-name pipeline-eks-nodepool-pregnor-local-200901-pipeline-3129-set-default-20-pool1 | jq -r '.Stacks[0].Parameters[] | select(.ParameterKey=="NodeVolumeSize")'

# Begin: 2020-09-02T09:36:42.018+02:00

{
  "ParameterKey": "NodeVolumeSize",
  "ParameterValue": "20"
}

# End: 2020-09-02T09:36:43.044+02:00
# Duration: 1s26ms
# Exit code: 0

<EMAIL_ADDRESS>(master u=)
> aws ec2 describe-volumes | jq -r '.Volumes[] | select(.Attachments[].InstanceId=="i-0481e40faa2a14251")'

# Begin: 2020-09-02T09:38:37.323+02:00

{
  "Attachments": [
    {
      "AttachTime": "2020-09-02T07:34:24+00:00",
      "Device": "/dev/xvda",
      "InstanceId": "i-0481e40faa2a14251",
      "State": "attached",
      "VolumeId": "vol-093df0cd642b5de8d",
      "DeleteOnTermination": true
    }
  ],
  "AvailabilityZone": "eu-central-1a",
  "CreateTime": "2020-09-02T07:34:24.243000+00:00",
  "Encrypted": false,
  "Size": 20,
  "SnapshotId": "snap-073e1d7e24630a32f",
  "State": "in-use",
  "VolumeId": "vol-093df0cd642b5de8d",
  "Iops": 100,
  "VolumeType": "gp2"
}

# End: 2020-09-02T09:38:38.662+02:00
# Duration: 1s339ms
# Exit code: 0

Cluster create set default (more than AMI image size)
<EMAIL_ADDRESS>(master u=)
> aws cloudformation describe-stacks --stack-name pipeline-eks-nodepool-pregnor-local-200901-pipeline-3129-cluster-create-set-default-75-pool1 | jq -r '.Stacks[0].Parameters[] | select(.ParameterKey=="NodeVolumeSize")'

# Begin: 2020-09-02T15:32:58.095+02:00

{
  "ParameterKey": "NodeVolumeSize",
  "ParameterValue": "75"
}

# End: 2020-09-02T15:32:59.236+02:00
# Duration: 1s141ms
# Exit code: 0

<EMAIL_ADDRESS>(master u=)
> aws ec2 describe-volumes | jq -r '.Volumes[] | select(.Attachments[].InstanceId=="i-0ae7274b54e976790")'

# Begin: 2020-09-02T15:33:45.850+02:00

{
  "Attachments": [
    {
      "AttachTime": "2020-09-02T13:29:30+00:00",
      "Device": "/dev/xvda",
      "InstanceId": "i-0ae7274b54e976790",
      "State": "attached",
      "VolumeId": "vol-0cc78a6b6550d095e",
      "DeleteOnTermination": true
    }
  ],
  "AvailabilityZone": "eu-central-1a",
  "CreateTime": "2020-09-02T13:29:30.252000+00:00",
  "Encrypted": false,
  "Size": 75,
  "SnapshotId": "snap-073e1d7e24630a32f",
  "State": "in-use",
  "VolumeId": "vol-0cc78a6b6550d095e",
  "Iops": 225,
  "VolumeType": "gp2"
}

# End: 2020-09-02T15:33:50.170+02:00
# Duration: 4s320ms
# Exit code: 0

Node pool create unset default
<EMAIL_ADDRESS>(master u=)
> aws cloudformation describe-stacks --stack-name pipeline-eks-nodepool-pregnor-local-200901-pipeline-3129-cluster-create-set-default-75-node-pool-unset-default-volume-size | jq -r '.Stacks[0].Parameters[] | select(.ParameterKey=="NodeVolumeSize")'

# Begin: 2020-09-02T16:01:27.081+02:00

{
  "ParameterKey": "NodeVolumeSize",
  "ParameterValue": "50"
}

# End: 2020-09-02T16:01:28.099+02:00
# Duration: 1s18ms
# Exit code: 0

<EMAIL_ADDRESS>(master u=)
> aws ec2 describe-volumes | jq -r '.Volumes[] | select(.Attachments[].InstanceId=="i-04c118a7d40af25c8")'

# Begin: 2020-09-02T16:02:13.686+02:00

{
  "Attachments": [
    {
      "AttachTime": "2020-09-02T14:00:03+00:00",
      "Device": "/dev/xvda",
      "InstanceId": "i-04c118a7d40af25c8",
      "State": "attached",
      "VolumeId": "vol-0255344c320df00f6",
      "DeleteOnTermination": true
    }
  ],
  "AvailabilityZone": "eu-central-1b",
  "CreateTime": "2020-09-02T14:00:03.917000+00:00",
  "Encrypted": false,
  "Size": 50,
  "SnapshotId": "snap-073e1d7e24630a32f",
  "State": "in-use",
  "VolumeId": "vol-0255344c320df00f6",
  "Iops": 150,
  "VolumeType": "gp2"
}

# End: 2020-09-02T16:02:15.012+02:00
# Duration: 1s326ms
# Exit code: 0

Node pool create set default (less than AMI image size)
selected volume size of 1 GB (default configuration) is less than the AMI image size of 20 GB
(Going to be updated once explicit volume size setting is also allowed.)
Node pool create set default (equal to AMI image size)
<EMAIL_ADDRESS>(master u=)
> aws cloudformation describe-stacks --stack-name pipeline-eks-nodepool-pregnor-local-200901-pipeline-3129-node-pool-create-node-pool | jq -r '.Stacks[0].Parameters[] | select(.ParameterKey=="NodeVolumeSize")'

# Begin: 2020-09-02T15:06:57.067+02:00

{
  "ParameterKey": "NodeVolumeSize",
  "ParameterValue": "20"
}

# End: 2020-09-02T15:06:57.775+02:00
# Duration: 708ms
# Exit code: 0

<EMAIL_ADDRESS>(master u=)
> aws ec2 describe-volumes | jq -r '.Volumes[] | select(.Attachments[].InstanceId=="i-02cfec64685cda33b")'

# Begin: 2020-09-02T15:10:04.156+02:00

{
  "Attachments": [
    {
      "AttachTime": "2020-09-02T10:39:49+00:00",
      "Device": "/dev/xvda",
      "InstanceId": "i-02cfec64685cda33b",
      "State": "attached",
      "VolumeId": "vol-09e0c61701872a207",
      "DeleteOnTermination": true
    }
  ],
  "AvailabilityZone": "eu-central-1a",
  "CreateTime": "2020-09-02T10:39:49.659000+00:00",
  "Encrypted": false,
  "Size": 20,
  "SnapshotId": "snap-073e1d7e24630a32f",
  "State": "in-use",
  "VolumeId": "vol-09e0c61701872a207",
  "Iops": 100,
  "VolumeType": "gp2"
}

# End: 2020-09-02T15:10:05.854+02:00
# Duration: 1s698ms
# Exit code: 0

Node pool create set default (more than AMI image size)
<EMAIL_ADDRESS>(master u=)
> aws cloudformation describe-stacks --stack-name pipeline-eks-nodepool-pregnor-local-200901-pipeline-3129-cluster-create-set-default-75-node-pool | jq -r '.Stacks[0].Parameters[] | select(.ParameterKey=="NodeVolumeSize")'

# Begin: 2020-09-02T15:53:33.147+02:00

{
  "ParameterKey": "NodeVolumeSize",
  "ParameterValue": "75"
}

# End: 2020-09-02T15:53:34.704+02:00
# Duration: 1s557ms
# Exit code: 0

<EMAIL_ADDRESS>(master u=)
> aws ec2 describe-volumes | jq -r '.Volumes[] | select(.Attachments[].InstanceId=="i-0a0ecca0ef7eab644")'

# Begin: 2020-09-02T15:54:18.359+02:00

{
  "Attachments": [
    {
      "AttachTime": "2020-09-02T13:52:08+00:00",
      "Device": "/dev/xvda",
      "InstanceId": "i-0a0ecca0ef7eab644",
      "State": "attached",
      "VolumeId": "vol-0060494daba8d500d",
      "DeleteOnTermination": true
    }
  ],
  "AvailabilityZone": "eu-central-1b",
  "CreateTime": "2020-09-02T13:52:08.918000+00:00",
  "Encrypted": false,
  "Size": 75,
  "SnapshotId": "snap-073e1d7e24630a32f",
  "State": "in-use",
  "VolumeId": "vol-0060494daba8d500d",
  "Iops": 225,
  "VolumeType": "gp2"
}

# End: 2020-09-02T15:54:19.636+02:00
# Duration: 1s277ms
# Exit code: 0

Finished the test matrix of [["cluster create", "node pool create"], [unset/0, < AMIImageSize, == AMIImageSize, > AMIImageSize]].


Product 10368/implement the updates for the get started page step 3

Ticket(s)
10368
Type of change

[ ] Design change

Description
Get Started page Step 3's content and organization are modified.
Differences from Figma:
I've kept spacing from other steps same as before cause changing it would have required changing spaces between other steps too.
Instead of step 1, 2, 3 which is used in Figm, Here step 3.1, 3.2, 3.3 are used to distinguish substeps from the general steps.
Some spacing might not be the same as Figma, but I kept it close. I think before adjusting spacing here, the spacing between steps need to be updated to match Figma and then we can adjust spacing inside step 3. But let me know if I should change spacing.
Screenshots
Please include a screenshot of the Figma design file

Before

After

Review your work
Please self review your work before requesting further review. Wait until you reach the next screen to check off the boxes.
Preview
Use your local build.

[x] Everything works as expected
[x] Check changed page(s)
[x] Compare figma screenshot with the changes
[x] Compare linked Figma section to changes made
[ ] Refresh the page, check that using the go-back button works as expected
[ ] Check large screen size (>1400)
[ ] Check tablet screen size (<786)
[ ] Check mobile screen size (<375)
[ ] Check that links work
[ ] Check the console for errors or warnings
[ ] Check the terminal for any errors or problems
[ ] Check for any uncaught ESLint problems

Code Clarity and Readability

[ ] Are variable and function names descriptive, meaningful, in the appropriate case (ex: snake, camel)?
[ ] Is the code self-explanatory and easy to understand?
[ ] Are comments used where necessary to explain complex logic or provide additional context?

Code Efficiency

[ ] Is the code DRY?
[ ] Are there any areas of unnecessary complexity or duplication that might benefit from refactoring?

Code Modularity and Reusability

[ ] Is the code and any new components organized in a logical location in the directory?
[ ] Can any code snippets be refactored into reusable components?
[ ] Are there opportunities to abstract common functionality into separate functions or classes?
[ ] Is there good use of CSS selectors when creating new components or refactoring old ones?

Best Practices and Coding Standards

[ ] Does the code follow the established coding standards and style guide of the project?
[ ] Are there any violations of best practices that should be addressed?
[ ] Are there any hard-coded strings or UI elements that should be externalized?
[ ] Are all measurement units in REM? (border-radius, borders should still be in px)
[ ] Is there any unnecessary commented out code lingering?
[ ] Are all files TypeScript?

Overall PR Checklist:
Please delete any options that are not relevant

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (if applicable)
[ ] My changes generate no new warnings in the console
[ ] There are no new linting errors/problems in my code
[ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
[ ] I have filled out the new 3rd party dependency checklist (if applicable)
[ ] I have filled this PR out fully, and cleaned up any extraneous items so that it is clear and easy to understand

hey @rezamshy ,
Thanks for helping the product team with implementing this! Could you please run npm audit fix locally and then push to resolve the dependency vulnerabilities

hey @rezamshy, I've resolved the dependency vulnerabilities

@rezamshy please make sure to finish the self-review section!

@rezamshy Hi there, checking back in on this PR as it has been open for quite a while. Can you please complete the self review and re-request a final review? Thank you.

I thought step 4 would have many changes but it was only text change so added in this review too.

Angie had a look and she asked me to change the number of columns in step 3 on tablet size.
Please wait until I make the new change

The PR is ready for review and suggestions


Cannot use fastjson on xamarin ios

Cannot use fastjson on xamarin ios, because depends on System.Reflection.Emit, which is not supported by xamarin iOS. Please help

Apple poses a lot of restrictions, sorry but fastJSON does not support IOS


Fix #304. Allow ELI5 to import despite improperly installed LightGBM

Fixes #304.
Catch and pass on OSError when importing broken LightGBM (library load fails - https://github.com/Microsoft/LightGBM/issues/1369).

Codecov Report

Merging #306 into master will decrease coverage by 0.1%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
- Coverage   97.19%   97.09%   -0.11%
==========================================
  Files          44       44
  Lines        2854     2856       +2
  Branches      541      542       +1
==========================================
- Hits         2774     2773       -1
- Misses         43       45       +2
- Partials       37       38       +1

Impacted Files
Coverage Δ

eli5/__init__.py
77.77% <50%> (-7.52%)
:arrow_down:


Support for Node API version 9

Can we support a higher node api version? My electron app uses node api version 9. And the package is using atm is 8, we can't install this on our project. Thank you.

Friendly bump.


Error resolving template alias on windows

Environment

Operating System: Windows_NT
Node Version:     v19.4.0
Nuxt Version:     3.2.3
Nitro Version:    2.2.3
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://github.com/tobiasdiez/nuxt-graphql-server using pnpm dev
Describe the bug
In a module,

create a template usingconst { dst: schemaPath } = addTemplate({
   filename: 'graphql-schema.mjs',
   getContents: () => "test",
   write: true,
 })

This successfully writes the template in .nuxt/graphql-schema.mjs
create an alias for this template nuxt.options.alias['#graphql/schema'] = schemaPath
use the alias in a server file
run nuxt in dev mode

On windows, this fails with the following error
[worker reload] [worker init] D:/Programming/nuxt-graphql-server/playground/.nuxt/dev/index.mjsOnly URLs with a scheme in: file and data are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'd:'

  at new NodeError (node:internal/errors:399:5)
  at throwIfUnsupportedURLScheme (node:internal/modules/esm/resolve:960:11)
  at defaultResolve (node:internal/modules/esm/resolve:1040:3)
  at nextResolve (node:internal/modules/esm/loader:164:28)
  at ESMLoader.resolve (node:internal/modules/esm/loader:838:30)
  at ESMLoader.getModuleJob (node:internal/modules/esm/loader:419:18)
  at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:77:40)
  at link (node:internal/modules/esm/module_job:76:36)

The reason is that the generated dev/index.mjs file contains
import { schema } from 'D:/Programming/nuxt-graphql-server/playground/.nuxt/graphql-schema.mjs';

without the file:// prefix that is necessary on windows. Digging a bit deeper, the issue comes from the node-externals plugin which resolves the alias as
{
  assertions: {},
  external: 'absolute',
  id: 'D:/Programming/nuxt-graphql-server/playground/.nuxt/graphql-schema.mjs',
  meta: {},
  moduleSideEffects: false,
  resolvedBy: 'node-externals',
  syntheticNamedExports: false
}

since .nuxt is marked as externals. In fact, the issue goes away if one uncomments https://github.com/unjs/nitro/blob/c578df8bc85628933a3c0241d452a9b8389084ff/src/rollup/plugins/externals.ts#L82 , in which case the resolution is correct:
{
  assertions: {},
  external: true,
  id: 'file://D:/Programming/nuxt-graphql-server/playground/.nuxt/graphql-schema.mjs',
  meta: {},
  moduleSideEffects: false,
  resolvedBy: 'rollup',
  syntheticNamedExports: false
}

Not sure what is the correct fix.
Additional context
No response
Logs
No response

Not sure how helpful this will be, but I was troubleshooting the same error message in a completely different context. At some point I accidentally let VSCode intellisense auto-complete when I was typing out createError to use in an API file, which added an import statement import { createError } from "~~/.nuxt/imports"; . Like in your case, the generated .nuxt/dev/index.mjs was preventing my application from running. What was generated by nuxt dev included a second import statement in the index.mjs file for createError, import { createError as createError$1 } from "C:/...", without that necessary file:// prefix. Deleting my superfluous, explicit import statement fixed the problem. This might be irrelevant to your case, but hopefully it gives useful context for this error message to the devs and anybody stumbling over, since neither my googling nor chatGPT pointed me at this solution.

I also faced this problem in my modules. Is there any news or workarounds?

For a workaround, you can use pathToFileURL as eg in https://github.com/dword-design/nuxt-mail/pull/174.

@tobiasdiez Do you think this is an issue in Nuxt?

Hi. Sorry for long delay on being back on this issue.
According to @tobiasdiez initial steps, i tried to assemble a reproduction:
https://stackblitz.com/edit/nuxt-starter-724hvd?file=modules%2Frepro.ts,server%2Fapi%2Ftest.ts
This seems to work fine on windows:

Although i might have missed something, please feel free to fork sandbox with any additions that can lead to this issue and would be happy to investigate more 👍🏼
Otherwise i think this issue might be marked as done /cc @danielroe

@pi0 @danielroe I can confirm that this bug is indeed fixed in the most recent nuxt version! Thanks a lot for your work. 🚀


issue126 Move add reminder to home screen

Add a button to top bar with a bell icon (temporary).
Present the scheduleReminderVC as the only VC in the navigationController.
Add a done button when presented from bell that dismisses back to main screen.

Do you have a screenshot of the changes? Would be helpful.

Thanks @chrisbrandow, I made some changes on my branch.  Tracking in #129


Inconsistent JVM-target compatibility

I get the following error: Execution failed for task ':async_preferences:compileDebugKotlin'.

Inconsistent JVM-target compatibility detected for tasks 'compileDebugJavaWithJavac' (1.8) and 'compileDebugKotlin' (17).

compileOptions {
// Sets Java compatibility to Java 17
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}
kotlinOptions {
    jvmTarget = '17'
}

I'm using Gradle 8.7-bin and android library and application 8.1.4. I solved it by changing it locally in the meantime.
Would be great if this could be adjusted for the next version. Also would be great with an upgrade for Gradle version.
I'm using this due to your excellent tutorial for ad consent :)

Thanks for reporting the problem to me, and for watching my video!
I have a version in preparation, can you try it in your project to see if it fixes the bug? You can do this by modifying the way you import the plugin:
  async_preferences:
    git:
      url: git@github.com:svprdga/async_preferences.git
      ref: release/1.0.0

If you are still experiencing the error, it may be due to a specific configuration within your project. It would be helpful if you could provide me with a project where this error can be reproduced.

@Schefferbird  I can confirm that with version 1.0.0 of the plugin the error you mention disappears. You are now able to update your application to the latest version of gradle:
https://pub.dev/packages/async_preferences/versions/1.0.0

Thanks David!

Getting error with version 1.0.0
Execution failed for task ':async_preferences:compileDebugKotlin'.
> Inconsistent JVM-target compatibility detected for tasks 'compileDebugJavaWithJavac' (1.8) and 'compileDebugKotlin' (17).

  Consider using JVM Toolchain: https://kotl.in/gradle/jvm/toolchain
  Learn more about JVM-target validation: https://kotl.in/gradle/jvm/target-validation

Adding kotlin.jvm.target.validation.mode = IGNORE to gradle.properties worked


Support several observers when mapping Tiled custom properties to Bevy components

Using the tiled_observer attribute from bevy_ecs_tiled_macros, we can add an observer to get notified when we map a Tiled custom property to a Bevy component.
Right now, we can only add a single observer per Component / Bundle.
The idea would be to give the user the capability to add several observers per Bevy object.

Not relevant anymore since release of v0.4.0


feat: port to Panacea

Changes

Changed an app name from Cosmos to MediBloc.
Changed a coin type in the HD path from 118 to 371.
Changed a default Bech32 prefix from cosmos to panacea
Changed app icons.
Changed hardcoded values in unit tests.

Also, changed app screenshots for zemu tests

Release plan

Will be released as v2.34.2-panacea because this PR is a fork of<EMAIL_ADDRESS>

@gyuguen @hansol-medi
Changed the app name from Panacea to MediBloc: 91bf466
Changed app icons: 71db396


Revert back to Oracle JDK as part of investigating #43

It seems Oracle JDK 8 is not available on Travis CI anymore.


Drop private for JobFailed

In the thread, 'SparkListener - why is org.apache.spark.scheduler.JobFailed in scala private', Sumona was requesting JobFailed to be accessible by user application.
@andrewor14
Please take a look.

If this makes sense, I can create a JIRA.

Test build #51064 has started for PR 11161 at commit f93508d.

It might be useful to have the JIRA either way (if for some reason we decide to keep it as private having a closed wontfix JIRA would be useful information)?

@tedyu please file a JIRA before creating patches

In this case I don't think we want to do this. In the past we've exposed way too many things and now we're burdened with maintaining backward compatibility. Can you close this PR

Test build #51064 has finished for PR 11161 at commit f93508d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class JobFailed(exception: Exception) extends JobResult

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51064/
Test PASSed.


Image not centering if cropping to a smaller result

It seems that the plugin is having a hard time centering when cropping the image to smaller view.

This is the code:
$uploadCrop.croppie('result', { 				type: 'base64', 				format: 'png', 				size: {width: 1000, height: 1000} 			}).then(function (resp) { 				$('#img-output').attr('src', resp); 			});
This was fixed if I removed the 'size' parameter. I need the parameter though.

Interesting.  Could you put together demo demonstrating the whole issue?  I don't know what you mean by "cropping the image to smaller view".
Just a heads up, I've seen croppie do something like this when the croppie element is in a modal and it's not completely shown before the bind() is complete.

Here's a demo of it:
http://codepen.io/tnrnz/pen/KNKLbN?editors=1100
and yes, I implemented this on a modal, I used the bind() after the modal was completely shown.

Thanks for putting together the demo - I definitely see the issue now.  I'm guessing that broke when I fixed it for safari/IE.  I won't have time to work on this for a couple of weeks - so if you want to dig into it, the issue is somewhere in this function: https://github.com/Foliotek/Croppie/blob/master/croppie.js#L949

I'm going to close this one in favor of #247 - but you get credit for finding it first.  That case just has more traction right now.

hi there,
who could solve this because I have the same bug


Is it possible to disqualify the team from the bracket?

Is it possible to disqualify the team from the tournament?
In case I have the double elimination bracket and I want to disqualify the team in the upper round. And I expect that the team will be automatically disqualified from the lower round too. Does the bracket manager support such a feature?

Or any way to remove the player from the live match?
convert to BYE etc.

Hi! No you have no way of converting to BYE once the tournament is started. You have to mark the team as forfeit, and you may have to do it in subsequent matches


Request: Option to generate a v2 swagger spec?

We've got aspnet-3.1 core services using the latest swashbuckle library. We have some consumers who's code-gen tools (triggered during ci builds) need to still generate against a v2 swagger spec file.
In the bootstrapping middleware for swagger is there an option to produce a swagger spec file, even though we're using the latest libraries?

https://github.com/domaindrivendev/Swashbuckle.AspNetCore#serialize-swagger-in-the-20-format


runtime: time.Tick resolution on Linux dropped to less than 1ms starting with go 1.16?

What version of Go are you using (go version)?

$ go version
go version go1.21.1 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/abozhenko/.cache/go-build'
GOENV='/home/abozhenko/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/abozhenko/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/abozhenko/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.1'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/home/abozhenko/tmp/slow_tick/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build468578710=/tmp/go-build -gno-record-gcc-switches'
uname -sr: Linux 5.4.0-1063-aws
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.4 LTS
Release:        20.04
Codename:       focal
/lib/x86_64-linux-gnu/libc.so.6: GNU C Library (Ubuntu GLIBC 2.31-0ubuntu9.9) stable release version 2.31.
lldb --version: lldb version 10.0.0
gdb --version: GNU gdb (Ubuntu 10.2-0ubuntu1~20.04~1) 10.2

What did you do?

Save main.go and go.mod from https://go.dev/play/p/N0GinbmwtDI
Run:

for v in {3..10} {12..14} 15.15 16 16.15 17.13 18.10 19.13 20.7 21.1; do GOTOOLCHAIN=go1.$v go run main.go; done
    go1.3: got 1000 ticks in 1s time
    go1.4: got  999 ticks in 1s time
    go1.5: got 1000 ticks in 1s time
    go1.6: got  999 ticks in 1s time
    go1.7: got  999 ticks in 1s time
    go1.8: got  999 ticks in 1s time
    go1.9: got  999 ticks in 1s time
   go1.10: got  999 ticks in 1s time
   go1.12: got  999 ticks in 1s time
   go1.13: got  999 ticks in 1s time
   go1.14: got  999 ticks in 1s time
go1.15.15: got  999 ticks in 1s time
   go1.16: got  889 ticks in 1s time  <- drop here
go1.16.15: got  895 ticks in 1s time
go1.17.13: got  890 ticks in 1s time
go1.18.10: got  872 ticks in 1s time
go1.19.13: got  867 ticks in 1s time
 go1.20.7: got  893 ticks in 1s time
 go1.21.1: got  881 ticks in 1s time

What did you expect to see?
About 1000 ticks in all Go versions?
What did you see instead?
Starting with go 1.16 we got 5-10% less ticks.
I reproduced it both on amd64 and arm64 AWS VMs, and on amd64 linux laptop.
I found two issues that seem somewhat related:
https://github.com/golang/go/issues/44343 (but that one is specifically about Windows, right?)
https://github.com/golang/go/issues/53824
But it doesn't look to me that this one is exactly a duplicate.

CC @golang/runtime

I believe this is #44343. There, resolution is much worse on Windows, but note in the initial comment that Linux is ~1.07ms.

Ah, I see.
In that case, maybe we can update the title in #44343, and add some summary(perhaps link to your comment https://github.com/golang/go/issues/44343#issuecomment-1029365697, and link to https://github.com/golang/go/issues/53824 ?) to the issue body, to save time for other who will stumble upon it?

Good point, I've updated the title to include Linux. (Note that the issue body already included Linux).


WIP: Add ci for keystone e2e

What this PR does / why we need it:
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

close this due to https://github.com/kubernetes/cloud-provider-openstack/pull/1804
so that I can avoid openlab CI

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test

/test openstack-cloud-keystone-authentication-authorization-test


BarcodeView stays black because onresume

when i enter onresume in barcodeview, it doesn't show up.
It is IMPORTANT to call barcodeview.onresume inside of onresume.

@markwittbabbel did you got the solution for this issue i am getting the same issue and i am using kotlin.

If you still run into this, post a sample project demonstrating the issue.


Web monitor enhancements for swarm (db status)

web-monitor showed wrong status for 'DB boostrapped' if running with a swarm.
Fixed by adding an explicit property db_path in 'Workspace' config which points to the location where the db is stored in the swarm and per default to the previous location (in the NODE_HOME directory)
previous 0L.toml needs to be deleted and will get recreated properly after:
cargo r -p ol-cli -- --swarm-path=$SWARMTEMPDIR --swarm-persona=alice init

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: lpgeiger:x: name:x: mortonbitsname seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


VM-side cache for cvars registered there

For improving the performance of Cvar::GetValue.
Also I uncovered another funny performance bug where setting a VM cvar was O(N) in the number of cvars.

Following screenshots were all done on a 10 seconds recording.
Here is before (left)/after (right) on Plat23 default scene with spectator HUD:

We notice a clear difference. It's a big win for the HUD!
For unknown reasons the fourth highlighted Cvar::GetValue on the bottom of the list still did an IPC call.
Now when I open the main menu (that processes most of the preferences windows even if not displayed), I still get a lot of IPC calls, I have no idea why:

For some unknown reasons, it even seems to be a bit slower, I reproduced the before/after comparison twice and got the same difference:

Well, for the main menu I guess it's because it's only caching Cvars registered on cgame side, and main menu preferences windows are full of engine cvars, so they go through IPC every time. Main menu being slow isn't the biggest problem.

The remaining cgame one that is still not cached is ui_winner, it is set with trap_Cvar_Set:
src/cgame/cg_servercmds.cpp
362:		trap_Cvar_Set( "ui_winner", str );

src/cgame/cg_main.cpp
1365:	trap_Cvar_Set( "ui_winner", "" ); // Clear the previous round's winner.

pkg/unvanquished_src.dpkdir/ui/ingame_scoreboard.rml
155:	<inlinecvar cvar="ui_winner" class="winner" />

This problem may not be solvable on the cache side, because the cgame cannot know if the cvar is not managed on engine side when setting it.
I guess the better is just to create the cvar in cgame C++ code.

There is no single IPC call done anymore by the HUD once this is merged on cgame side:

https://github.com/Unvanquished/Unvanquished/pull/2997

Here an update before (left)/after (right):


Avoid reporting not-found errors when patching resources under deletion.

What this PR does / why we need it:
When reconciling for deletion, the KubevirtCluster and KubevirtMachine controllers both attempt to patch, as the last step of the reconciliation, the resource in order to indicate to the user that it is being deleted. It is possible that, by the time these patches are called, the resource is already deleted; which result of the patch failing with a NotFound error that is then reported at the error level in the log.
Because this is an expected case, this change silences NotFound errors raised by these two final patches.
Which issue this PR fixes:
fixes #152
Special notes for your reviewer:
Note that the patch methods return an k8s.io/apimachinery/pkg/util/errors#Aggregate error in this case; which will not be recognized by the apierrors.IsNotFound method. So, I am extracting the error using the Reduce method to extract the aggregated error, if there is only one and the error passed to the method is an aggregate.
Note also that, for the KubevirtCluster controller, the change will also apply when a normal reconciliation happens. I believe that this is acceptable as the existence of the resource has been access before and this change should not obfuscate unexpected failures.
Release notes:
NONE

/ok-to-test

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 10 (30.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 45.677%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

controllers/kubevirtmachine_controller.go
2
5
40.0%

controllers/kubevirtcluster_controller.go
1
5
20.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
708

Relevant Lines:
1550

💛  - Coveralls

@pjaton please rebase and retest - flaky e2e test should now be fixed with https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/pull/155

Thanks @agradouski, the test are now passing in this PR after the rebase!

/lgtm


The query references a field that does not exist ?

Trying to solve this issue for past few days.... Do you think migrator is accessing a field from VSTS that is now proprietary.. Here is the log
stssyncmigrator.exe Information: 0 :  Migration Context Complete TeamMigrationContext
vstssyncmigrator.exe Information: 0 :  Migration Context Start WorkItemMigrationContext
TfsQueryContext: TfsQueryContext: TeamProjectCollection: http://--.com/tfs/TalentApp
TfsQueryContext: TfsQueryContext: TeamProject: TalentApp
vstssyncmigrator.exe Information: 0 :  Query Complete: found 886 work items in 946ms
WorkItemMigrationContext: Migrate 886 work items?
WorkItemMigrationContext: Found target project as TalentApp
TfsQueryContext: TfsQueryContext: TeamProjectCollection: https://txxx.visualstudio.com/
TfsQueryContext: TfsQueryContext: idToFind: http://xxx.talentapp.com/tfs/TalentApp/TalentApp/918
TfsQueryContext: TfsQueryContext: TeamProject: TalentApp
vstssyncmigrator.exe Warning: 0 :   [EXCEPTION] TF51005: The query references a field that does not exist. The error is caused by «[TfsMigrationTool.ReflectedWorkItemId]».
vstssyncmigrator.exe Warning: 0 :   [EXCEPTION] TF51005: The query references a field that does not exist. The error is caused by «[TfsMigrationTool.ReflectedWorkItemId]».

Figured this a duplicate one


Update to latest php-http-client

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Mass Mint: Dialogs

#4964

Figma

Detailed interactions and logic is available Figma.
all the needed screens
interactive prototype

Please take the prototype with a grain of salt, not everything is perfect and 1:1 to final design how it should look, so in case you don't know something, don't hesitate to ask @VladoTheBoi
Dialogs
There are 4 main dialogs:

Missing Required Information

this dialog is shown when there are some files with Incomplete state
user cannot mint unless he resolves the incomplete files
can be resolved by:

filling in required information
deleting incomplete files

Final Mass Mint Overview - missing description

when Description missing, it does not restrict user from minting
he is however informed that some files are missing description
shows how many NFTs will be minted

3 Final Mass Mint Overview - Everything OK

shows how many NFTs will be minted

Delete file

displayed when user taps delete file button
if name is missing, display file number from the table

creating a NeoDialog would be a good idea for this one right? @roiLeo @daiagi

creating a NeoDialog would be a good idea for this one right?

Yes or use current b-modal design should be the same


[BUG] thread 'tokio-runtime-worker' panicked at 'called Option::unwrap() on a None value

I think it's similar to issue #563, and I've encountered this issue on version 2.10.0 and 2.9.1
I try to remove other unrelated argument as much as possible and this is the shortest command I could possibly reproduce this issue
feroxbuster -u "<myurl>" -w raft-medium-files-lowercase.txt --collect-words

Error:
thread 'tokio-runtime-worker' panicked at 'called Option::unwrap() on a None value', src/nlp/document.rs:51:14
It might be related to --collect-words option

it's just a place where i used unwrap, thinking it would always be valid, but it isnt 🙃
a quick look at the code in question makes me think the page you're requesting doesn't have a <body> tag

There's a <body> tag within the request page

After debugging my ass hell out I found the which page is blamed for
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Frameset//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Export to PDF</title>
<script type="text/javascript">
window.status='Export to PDF';
</script>
</head>

<frameset rows="0,*"" frameborder="NO" border="0" framespacing="0">
 <frame src="" name="topFrame" id="topFrame" title="topFrame" />
 <frame src="http://redacted.com/capture/pdf.php?url=" name="mainFrame" id="mainFrame" title="mainFrame" />
</frameset>
<noframes><body>
</body>
</noframes></html>

looks like there's indeed a <body> , I'm not sure why this broke the fuzzer

@all-contributors add @ktecv2000 for bugs


feat: DeepNullable

Help wanted: for some reasons I can't get the test working and I'm not sure what the problem is

Closes #124

@quezak thanks a lot for your help, I appreciate!
I've updated the PR with your suggestions as well as adding a test for my use case, which is simpler than the complex object used for other test cases.
Ready to be reviewed!

@FrancescoBorzi Thanks for the update! If you add a brief description to the README, looks like we'll be ready to go :muscle:

@quezak done, thanks!

Updated the docs heading a bit, looks ready now, thanks @FrancescoBorzi!
@all-contributors please add @FrancescoBorzi for code, docs

thanks a lot for your help @quezak @krzkaczor

Released as v6.0.1 👍


feat: Added new column type for rating

Description

Added new column type for a rating in the table.

Fixes #6764
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally.
Added Test Cases.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: FEATURE/6764-new-column-type-rating

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
54.69 (0.01)
36.72 (0.12)
33.4 (0.07)
55.2 (0)

:green_circle:
app/client/src/components/designSystems/appsmith/SearchComponent.tsx
79.31 (3.45)
83.33 (8.33)
66.67 (16.67)
78.57 (3.57)

:green_circle:
app/client/src/widgets/TableWidget/component/TableStyledWrappers.tsx
70.24 (0.36)
21.43 (0.6)
52.83 (0)
70.24 (0.36)

:red_circle:
app/client/src/widgets/TableWidget/component/TableUtilities.tsx
36.65 (-1.3)
22.83 (-1.06)
13.33 (-2.89)
35.03 (-1.15)

:green_circle:
app/client/src/widgets/TableWidget/component/index.tsx
28.57 (1.3)
27.27 (24.67)
21.05 (5.26)
27.03 (1.35)

:green_circle:
app/client/src/widgets/TableWidget/widget/derived.js
65.09 (7.25)
60.84 (3.25)
48.78 (4.88)
63.08 (5.33)

:green_circle:
app/client/src/widgets/TableWidget/widget/getTableColumns.tsx
56 (25.57)
23.08 (23.08)
33.33 (33.33)
50 (30)

:green_circle:
app/client/src/widgets/TableWidget/widget/index.tsx
28.42 (1.93)
9.57 (3.48)
28.57 (0.57)
27.92 (1.56)

:red_circle:
app/client/src/widgets/TableWidget/widget/propertyConfig.ts
87.1 (-8.55)
100 (0)
82.61 (-10.72)
87.1 (-8.55)

:green_circle:
app/client/src/widgets/TableWidget/widget/propertyUtils.ts
26.98 (1.78)
8.33 (0)
23.08 (0)
25.64 (1.96)

[ ] Table crashes when filtering with the rate column. Please verify this with other column types as well.

[ ] Rating options do not show until we provide it with a value.

[ ] Selecting a rating seems to select the row as well. @somangshu Is this feature intentional across all column types?

Closing this PR. Feature will be reopened with TableV2.


what's the difference between 'broad' and 'narrow'  tsv?

Sorry, I didn't find the description of broad and narrow tsv? Could you tell me what's their difference？

It’s a standard term referring to how precise the transcription is:
https://en.wikipedia.org/wiki/Phonetic_transcription#Narrow_versus_broad_transcription
On Sat, Jun 5, 2021 at 7:22 AM LDong @.***> wrote:

Sorry, I didn't find the description of broad and narrow tsv? Could you
tell me what's their difference？
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CUNY-CL/wikipron/issues/425, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OJ23LRJNERIA2KNMQDTRICINANCNFSM46ENVIQQ
.

It’s a standard term referring to how precise the transcription is: https://en.wikipedia.org/wiki/Phonetic_transcription#Narrow_versus_broad_transcription
…
On Sat, Jun 5, 2021 at 7:22 AM LDong @.***> wrote: Sorry, I didn't find the description of broad and narrow tsv? Could you tell me what's their difference？ — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#425>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4OJ23LRJNERIA2KNMQDTRICINANCNFSM46ENVIQQ .

Thank you for your reply! Now I have another question.  I'm studying the multilingual G2P system of SIGMORPHON 2020 shared task, which uses scraped dataset of wikipron here. I found that their multilingual dataset includes broad French dataset and narrow Armenian dataset. However, the wiki link you provided shows that 'A further disadvantage of narrow transcription is that it involves a larger number of symbols and diacritics that may be unfamiliar to non-specialists', which means narrow transcription and  broad transcription may have some different phoneme tags. Thus, I wonder whether the mixture of broad and narrow transcription will confuse a multilingual G2P system? Or is there some disadvantage when mixing broad and narrow transcription dataset?

You are right that some of the SIGMORPHON 2020 shared task data is broad
and other data is narrow. (The 2021 shared data, which is definitely higher
quality, is now out too.) We usually choose whichever is larger and/or
higher-quality for the shared task.
I see your concern. I should note that how the individual Wiktionary
contributors choose to define broad vs. narrow differs from language to
language. (Broad is simply whatever is in angled brackets, and narrow is
whatever is in square brackets, and this is totally at the discretion of
the Wiktionary contributors.) Furthermore, I would say we don't really know
how multilingual sequence-to-sequence neural network models work anyways,
so I'd be hesitant to make any strong guesses as to how this might affect
things. In the case of Armenian vs. French, the two languages use totally
disjoint scripts so you might guess that they don't really do much
parameter-sharing in a multilingual model. It could even be that the mix of
broad and narrow is actually beneficial, perhaps a sort of regularization
effect.
On Sat, Jun 5, 2021 at 10:02 AM LDong @.***> wrote:

It’s a standard term referring to how precise the transcription is:
https://en.wikipedia.org/wiki/Phonetic_transcription#Narrow_versus_broad_transcription
… <#m_7310177812352944298_>
On Sat, Jun 5, 2021 at 7:22 AM LDong @.***> wrote: Sorry, I didn't find
the description of broad and narrow tsv? Could you tell me what's their
difference？ — You are receiving this because you are subscribed to this
thread. Reply to this email directly, view it on GitHub <#425
https://github.com/CUNY-CL/wikipron/issues/425>, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OJ23LRJNERIA2KNMQDTRICINANCNFSM46ENVIQQ
.
Thank you for your reply! Now I have another question. I'm studying the
multilingual G2P system of SIGMORPHON 2020 shared task, which uses scraped
dataset of wikipron here. I found that their multilingual dataset includes
broad French dataset and narrow Armenian dataset. However, the wiki link
you provided shows that 'A further disadvantage of narrow transcription is
that it involves a larger number of symbols and diacritics that may be
unfamiliar to non-specialists', which means narrow transcription and broad
transcription may have some different phoneme tags. Thus, I wonder whether
the mixture of broad and narrow transcription will confuse a multilingual
G2P system? Or is there some disadvantage when mixing broad and narrow
transcription dataset?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/CUNY-CL/wikipron/issues/425#issuecomment-855244777,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OKMPHJQQ53UZTNQPF3TRIVALANCNFSM46ENVIQQ
.


fix: Skip reset password requests with HEAD method (#2381)

PR fixing issue: 2381

"Missing CLA Authorization": CLA Authorization already signed.

/easycla

The commit was done by user https://github.com/jbiland-nt but CLA is signed by https://github.com/jbilandzija

/easycla


--show-labels shows up on "kubectl services create"

--show-labels should not show up at kubectl services create command('s help), and it should error out when it's silently ignored.
For example:
➜  ~ kubectl create service  loadbalancer --show-labels lb-1 --tcp=80:80
service "lb-1" created

Actually there are so many cases like this. When there are some unused flag but cobra command can recognize, for example  https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/util/printing.go#L44-L52
when we use  --show-all when we create service but do not specify the -output flag

It might be by-design. I'm not sure. I just wanted to bring up in case it is completely useless.
I recently opened an issue in the main repo (now fixed): if you specify --show-labels and incompatible printer (-o yaml) it now prints a validation error.
Similarly I think it should fail if --show-labels isn't applicable to the command.

Yeah, create uses the printer library (because you can print what you just created). And the printer library registers all the parameters it knows about.
You can do (even if it's completely useless):
> kubectl create svc  clusterip bla --tcp=3432:2131 -o wide --show-labels
NAME      TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)    AGE       SELECTOR   LABELS
bla       ClusterIP   <IP_ADDRESS>   <none>        3432/TCP   0s        app=bla    app=bla

We could return an error if --show-labels is specified and output is empty though.

I can help to fix this. :-)

Great Lion-Wei, Thanks for working on that! Feel free to ping me on chat or ask for anything. I can't assign to you, so I'll just assign to me to mark it assigned.

Yeah, thanks, I forgot to do it ahah

@apelisse I pushed a pr to do this. In that pr, kubectl will give a warning in this cases like this issue mentioned.
I have tested it, works fun. But might be immature in realization. Can you help me take a review? Thanks.

I'm not sure we have a consensus on what needs to be done, and it's slightly too premature to come-up with code yet.
@ahmetb, can you please re-iterate what you expect?

@apelisse I think the right thing to do here is to make sure --show-labels does not show up at kubectl create service --help and is not usable with the kubectl create service and other "create xxx" commands.

ehhh, Here is how I understand:
When we use kubectl create' with --show-labelsbut with out any-ospecify, the--show-labels` flag will not work. like:
# k create -f /root/rs-who.yaml --show-labels
replicationcontroller "whoami" created

But this flag not completely useless, cause when we use kubectl create with -owide, add this flag can print lables info, like:
# k create -f /root/rs-who.yaml -owide --show-labels
NAME      DESIRED   CURRENT   READY     AGE       CONTAINERS   IMAGES               SELECTOR     LABELS
whoami    3         0         0         0s        whoami       cizixs/whoami:v0.5   app=whoami   app=whoami,env=dev

So IMO, we can't just disable this flag in kubectl create, we need identify cases that the --show-labels flag are useless, and tell the user somehow...

If I understand it wrong, please let me know, thanks... @ahmetb @apelisse

@Lion-Wei you're right. I wasn't aware of this. in this case we should fail when it does not apply. We recently made similar fix to kubectl where we errored if -o=... value is not compatible with --show-labels (e.g. -o=yaml --show-labels). You can dig that PR up and extract common code.

Ok, sounds good, I will do that.

@ahmetb Sorry to ask, but I can't find that pr anywhere, can you give me some information about it? Thanks.

https://github.com/kubernetes/kubernetes/pull/55371

We should probably be more generic and move the verification to the printer code.

@apelisse I extracted printer verification of delete create and others to util/printing.go. I'm thinking maybe there are other cases that should validate, if so, we can add to that function too.

I'm thinking that it might make more sense with the printers package itself. That's where the printer logic lives, that's what is supposed to know how to interpret the options, and which combinations of option make sense and which don't.
@smarterclayton who knows the most about printing.

I can take some time to learn this part code, give the whole logic of printer, then we can decide what to do. You think that will work?

Yeah, that could. I think if you need to have a deep knowledge of printers, then something must be wrong. So don't get lost into too many details.

@apelisse Thanks for your advise, sorry take so lang.
 And cause those command print obj one by one, the flag sort-by and show-all will be ignored.
Specially, when we use kubectl set *** with flag --dry-run, then will use PrintObject no matter what output option is, this maybe a little problem. For example:
# k set env rc/whoami LW=la --dry-run
NAME      DESIRED   CURRENT   READY     AGE
whoami    2         2         2         2h
# k set env rc/whoami LW=la
replicationcontroller "whoami" env updated

delete/replace/scale
Only support out option NONE or name, don't support any output flag.
view
If use output option NONE or wide, will change to -oyaml, only accept flag allow-missing-template-keys.
When use -oname, might have a little problem:
# k config view -oname
<unknown>/<unknown>

# k config view -owide
--output wide is not available in kubectl config view; reset to default output format (yaml)
apiVersion: v1
...

# k config view
apiVersion: v1
...

I think this should covered all situation.


attack: Add -resolvers flag to command

This adds the ability to override the host operating system resolver
by allowing this to be specified on the command line (comma separated list).
In the event more than one is specified, the resolvers are tried in order in a round robin manner.
Background
In some situations it is desirable to override the default host resolver and use a separate host for DNS resolution.  This adds the option to specify the dns server on the command line.
Checklist

[x] Git commit messages conform to community standards.
[x] Each Git commit represents meaningful milestones or atomic units of work.
[x] Changed or added code is covered by appropriate tests.

Hey! Thanks for contribution. Would you please demonstrate with more detail which sort of situation you’re facing that drove this change?
Apart from that, one initial comment:
Would there be a way of avoiding the mutation of the global package level net.DefaultResolver? I’d rather parameterise this in the Attacker only.

For our use case, we have several 10GB interfaces on the same machine, and we want to try to control egress.  We have two different "fake" dns servers that always return a single IP, and we use this in combined with the source address option to effectively steer the traffic out one interface or the other.
As for your other point about the net package global, there is really no other way that I'm aware of to influence how net.Dial etc does dns resolution.  That's one reason I made sure that setting that package global is assigned inside the main() and not in the lib package.

@tsenart I have moved the resolver out of the lib package and into a new package called "resolver".  Is that more along the lines of what you wanted?
Regarding the package global, an alternative would be to specify the Resolver in your net.Dialer that is defined in the Attacker here:
https://github.com/tsenart/vegeta/blob/master/lib/attack.go#L52
I suppose I could create an opts func that allows you to set the Resolver portion of the dialer, but one issue is I wouldn't be able to handle errors, such as a malformed host:port specified.  I could just skip problematic hosts I guess?

@tsenart https://github.com/golang/go/issues/12503
One of the workarounds suggested in this issue is very similar to the approach taken here.  They also use the net.DefaultDialer:
https://godoc.org/github.com/benburkert/dns/init

per that same thread, I disabled this functionality on windows since swapping net.DefaultDialer on that platform has no effect (as is documented in the net package):
On Windows, the resolver always uses C library functions, such as GetAddrInfo and DnsQuery.

For our use case, we have several 10GB interfaces on the same machine, and we want to try to control egress. We have two different "fake" dns servers that always return a single IP, and we use this in combined with the source address option to effectively steer the traffic out one interface or the other.

I see. As a curiosity, is there anything preventing you from changing your environment's configured DNS resolvers outside Vegeta? Are you using containers (Docker et. all)?

@tsenart I have moved the resolver out of the lib package and into a new package called "resolver". Is that more along the lines of what you wanted?

This is still public unfortunately. I'd move this code to the main CLI package and make it fully private.

I suppose I could create an opts func that allows you to set the Resolver portion of the dialer, but one issue is I wouldn't be able to handle errors, such as a malformed host:port specified. I could just skip problematic hosts I guess?

You should handle those errors before setting the resolver in the Attacker. Something like:
resolver, err := newResolver(addrs...)
if err != nil {
    return fmt.Errorf("resolver: %v", err)
}

atk := vegeta.NewAttacker(
    vegeta.Resolver(resolver),
)

EDIT - that's not going to work very well because, for instance, H2C() will change the transport, so I can't modify the dialer if someone puts the resolver in the opts chain after H2C(). It really does need to be in the net package global.

H2C reuses the original Dialer so that shouldn't be a problem. Am I misreading the code?

Please wait until the end to squash so that everybody can follow along your changes.

@tsenart I made some updates.  Instead of using miekg/dns package as a dns server for use during testing, I decided instead to optionally use the dnsmasq which is available in travis.  To enable that resolver test, the VEGETA_TESTDNSMASQ_ENABLE environment variable must be present.  I updated the travis build to install dnsmasq and set that environment variable.  It's not my favorite solution, but using his dns server package for even a trivial example would have added hundreds of lines to the test, and if you want I can disable running that test within the travis build.

@nathanejohnson: I've used miekg/dns before and I find it surprising you found this simple use case to add so much code to our codebase. Have you had a look at introductory articles such as this https://jameshfisher.com/2017/08/04/golang-dns-server.html?
I don't think it's worth it to introduce a run-time dependency like dnsmasq. I'm OK with a code dependency like miekg/dns.

@nathanejohnson: Do you need any help on bringing this forward?

@tsenart @xla sorry for the radio silence, been covered up with work.  Hopefully I can get back to this on the weekend.

Ping :-)

@tsenart I have updated to use miekg dns

Released: https://github.com/tsenart/vegeta/releases/tag/cli/v11.3.0


firmware: support display of release notes from console option 12

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
Only GUI displays release notes during updates.
Describe the solution you like
Display the release notes like they appear in the GUI. It's likely most useful to invoke them via "less" so they can be digested properly.
Describe alternatives you considered
Leaving the console update as is.
Additional context
https://forum.opnsense.org/index.php?topic=26554.msg129168#msg129168

Note to self: doesn't work when performing type change...


[BUG] PyTorch Dataloader doesn't work on the versioned dataset

🐛🐛 Bug Report
When the dataset is committed/versioned, then if we iterate dataloader from ds.pytorch, it looks for a file that doesn't exist. For example, a file like: versions/6638f5b89f2fe54e28446666e7e08515df2bcb0f/images/chunks/f82df5c5.

Thanks @flpvvvv for raising the issue, the following PR should have fixed the issue https://github.com/activeloopai/Hub/pull/1410, and will be released next week. Can you confirm if it is resolved by installing from the source?

Hi @davidbuniat , thanks for your reply.
I tested the latest version 2.2.1 (from the source), and it worked perfectly !
Thanks. It's a great package !

@flpvvvv, thank you so much for helping us get better by providing feedback! Mind joining our community (slack.activeloop.ai). I'll ping you there and we'll arrange some swag to be sent your way. :)

@mikayelh yeah, I would love to join the community, please invite me via slack.

Hey @flpvvvv, thanks a lot for wanting to join! I don't see an email on your GitHub account, so if you can click this link and join yourself it would be great.


fix QA app deploy and page for Template DB

motivations
All QA pages have a warning to use st.query_params in place of experimental functions (docs).
QA deploy action started to fail silently due to no space left on device when pulling the docker image (example). There were ~54 images in the DO droplet's storage (docker info logs and docker images logs)
Template DB QA page fails to show show S3 file metadata and fails to show GeoDataFrames due to a MemoryError when converting the geometry column to a string. That conversion is needed to display the values using st.dataframe.
actions runs

Template DB QA page here
all runs of the QA App deploy action here
successful fail on error example
successful deploy example

screenshots
old deprecation warning

now showing GeoDataFrame properly

Ooh good digging on the deploy failing

Ooh good digging on the deploy failing

I was so confused when the pages weren't changing after deploying


Update profile photo from MVP Summit 2019

Great event, great linked profile photo!

OPS Build status updates of commit a4903f7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

rd/media/profiles/huan-li.jpg
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@huan
Your change in this PR should be live now. Please review it from RD website: https://rd.microsoft.com/en-us/


A github actions workflow to test if getting_started colab notebooks running properly in latest colab docker runtime env.

Prior to activating this workflow, we need to set three env variables:
SERVICE_ACCOUNT_KEY: Google Cloud service account key JSON (make sure to convert it to ONE LINE JSON). Note: minimum permissions required for the service account: Bigquery User
DOCKER_USERNAME: Docker Hub username.
DOCKER_PASSWORD: Docker Hub password or access token.
While this workflow is setup to test only the three getting_started notebooks, we can test any notebook that does not require a GPU. To accomplish that, every new notebook will need to be assessed if it requires any additional preprocessing steps.

A service account is now dedicated for this. Whenever we are ready to merge this PR, I can provide the service account key to create the github repo secret.

@fedorov I modified the preprocessingNotebooks.py script to let the users know whenever we inject something. I also modified the papermill output notebook names. So I believe we are good to go.
Could you use your dockerhub credentials while creating these?
DOCKER_USERNAME: Docker Hub username.
DOCKER_PASSWORD: Docker Hub password or access token.
SERVICE_ACCOUNT_KEY


fix: update isolation as new fixtures of certain scopes arrive

What I did
Make isolation "work" on session, package, module, and class scopes.
Basically, the bug was that as new fixtures of certain scopes come in after a snapshot was taken in that scope, they wouldn't really persist as the scope below left, like if the module changes or something
fixes: #2262
fixes: #1287
How I did it
Awful. Basically the only way to fix this is to rebase the blockchain as new upper scopes up.
A new session comes in later, we have to undo to the module (or closest lowest) snapshot invalidate those fixture, inject those fixtures in the correct order, and re-set all the snapshots.
How to verify it
Can technically uses scopes / parametrized fixtures in any way now... and it should also "work"... it is just is slow if using higher scoped fixtures later on in the test suite, can be really bad actually. I definitely don't recommend using parametrized fixtures unless I can figure out a more optimal way with those
Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

suspecting something with the runner now...

[ ] Ensure isolation fixtures ran last (this has to be the problem!)

Update, mentioned on Telegram but I am pretty sure I actually  found the bug; I am still working on the full fix this PR is not ready for testing yet). Standby for updates.

If you want to see the most magical part(s), look at the changes made to the runner.py module.

This is "working" but may have performance issues if users don't use autouse=True when they should or use parametrized fixturs.

[ ] Either do or consider only reinitializing the autouse=True fixtures (rest should still be invalidated but maybe dont replay them
[ ] Ignore fixtures that don't change chain head from invalidation consideration

Questions: How does one know if a fixture has caused the chain height to increase? There is a way to know if an entire has or if a test has, but there doesn't seem to be a way to know if an individual fixture has, that I can think of.

Can we store extra info in the cache? Such as block height of last access? If auto-mining is used, that would roughly correspond to 1 block = 1 transaction, so this is a good approximation (If auto-mining is turned off, this would not work)

Can we store extra info in the cache? Such as block height of last access? If auto-mining is used, that would roughly correspond to 1 block = 1 transaction, so this is a good approximation (If auto-mining is turned off, this would not work)

Yes, this is how we would do it. I just can't figure out how to know which fixture is responsible. It seems really complicated. For example, if you were using multiple module-scoped fixtures at the same time and some caused height increase and some didn't, the chain height would be higher the next usage for all of them, so how does one know which fixture caused the bump?

[ ] This causes ApePay to fail in tests - figure out why and fix.

[ ]  Fix create_stream min time goes to zero issues that has arrived in ApePay

Notes:

Figured out there is a problem when using multiple parametrized fixtures at once.

[ ] Only trigger invalidation on stateful fixtures of higher scope
[ ] Better handling of parametrized fixtures - right now, always treats them as "new", meaning it is wayy overly invalidating...

So before I merge this, I am going to add a few more projects to the integration tester thing.
I want to really make sure I am not wrecking all of tests by doing this.

ApePay
this branch
32 passed in 102.98s (0:01:42)
main
32 passed in 106.16s (0:01:46)

Once I get https://github.com/ApeWorX/ape/pull/2327 to where I like, I want to also compare running Ape's tests w/ and w/o this feature.


Using "requireCordovaModule" to load non-cordova module "glob" is not supported

cordova -v
9.0.0<EMAIL_ADDRESS>Discovered saved plugin "cordova-plugin-deeplinks". Adding it to the project
Installing "cordova-plugin-deeplinks" for ios
Installing dependency packages:
{
  "mkpath": ">=1.0.0",
  "node-version-compare": ">=1.0.1",
  "plist": ">=1.2.0",
  "rimraf": ">=2.4",
  "xml2js": ">=0.4"
}
Adding cordova-plugin-deeplinks to package.json
Using "requireCordovaModule" to load non-cordova module "glob" is not supported. Instead, add this module to your dependencies and use regular "require" to load it.

Found the PR for this, please could you review https://github.com/e-imaxina/cordova-plugin-deeplinks/pull/11


window is not defined in worker file

This is not really an issue with vue-pdf but I ran into this recently and tought it may be worth sharing.
When using vue-pdf with Webpack 4 (e.g. a project created by vue-cli v3) the dev build with hot reloading gave the following error message:

window is not defined in worker[hash].js

and vue-pdf did not display anything.
This only occurs on development builds with hot reloading, on production it is fine.
After investigating I found the following issue to be the reason why this happens: https://github.com/webpack/webpack/issues/6642
Until this is fixed in webpack the following workaround did work for me.
In the Webpack config set the following option:
 output: {
  globalObject: 'this'
}

This was tricky to track down... what webpack config? with vue-cli v3 there is non and vue.config.js doesn't have an output config :/

:100: @a47ae @rayfoss you guys are heroes :1st_place_medal:

In Nuxt, you can get this to work in nuxt.config.js:
extend(config, ctx) {
  config.output.globalObject = 'this'
}

i still get with NUXT
Unexpected token <

@frederic117
Make sure you also add ssr: false in your nuxt.config.js file if you are using Nuxt in universal mode.
plugins: [
  { src: '@/plugins/pdf', ssr: false },
]

https://nuxtjs.org/guide/plugins/#client-side-only

yes i did that to,
but still get
Unexpected token <
i really don't get what happens :(

@frederic117 if it’s a public repo I can check it out. Or, if you want to add me to the repo if it’s private.

I have the same problem. I don't know why it happened.

Still waiting

@frederic117, @imaxing, for Unexpected token < please refer to issue #13

In Nuxt, you can get this to work in nuxt.config.js:
extend(config, ctx) {
  config.output.globalObject = 'this'
}

In Nuxt, you can get this to work in nuxt.config.js:
extend(config, ctx) {
  config.output.globalObject = 'this'
}

this saved me :D , thank you @coreycoburn

Not working for me. I am not able to load the PDF no matter what I do (place it in the /static dir or on a server). Using webpack 4 too :-(
Tried the 'this' trick, but it's still blank...

Working solution on this link FranckFreiburger/vue-pdf#148

Solve this issue for nuxt.js
👇
#148 (comment)


Undefined signing secret causes NullPointerException

Issue Type

[x] Bug
[ ] Enhancement / Feature request
[ ] Question
[ ] Documentation

Description
Failing to provide a SLACK_SECRET to SlackSignature.Generator's constructor causes a NullPointerException when calling the resulting Generator's generate() method.

The issue is reproducible in:
JSlack version: 3.4.1
OS: OSX 10.15.3 (though this shouldn't matter)
Repro steps:

First, initialize a SlackSignature.Generator object without a signing secret:

SlackSignature.Generator gen = new SlackSignature.Generator()

Attempt to generate a message's signature:

gen.generate("1970-01-01T00:00:00Z", "{}")

The expected result is:
An Exception warning that SLACK_SECRET is not defined
The actual result is:
A NullPointerException on line 87 of SlackSignature.java.
Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Thanks for taking the time to give this feedback 🙏 I will apply the improvement to both jSlack and this 1st party Java Slack SDK.


[AAP-18000] chore: change validation errors format

The second errors is changed to field_errors. Now the validation error looks like:
{
  "errors": {
       "field_errors": "No controller token specified"
  }
}

Resolves AAP-18000

LGTM but why are you renaming the key?

We thought non_field_errors was too confusing to the end users.


Rebuild contract_build.rs

Updating Odra.toml causes errors, because of incompatible contract_build.rs files

No longer a problem.


We should spec that emoji reactions should be sent with the colourful variation-16 selector when applicable

see https://github.com/vector-im/riot-web/issues/13926 and https://github.com/vector-im/riot-web/issues/13586 and friends

moved to the MSC: https://github.com/matrix-org/matrix-doc/pull/1849/files#r435393386


Not working when it is bundled

This plugin is working fine in the development mode. If i minify the files to serve in the production, then it is not working. And no errors in the logs too.

I'm so sorry, I'm unable to help with out any error logs or any other details 😞 . What is the browser and any browser console error in the client side?
Since it's working in development mode and not in production, I'm guessing it might be related to the intermediate steps?

There are no errors in the console. And also i am using the gulp-angular seed project for building the app for production environment.

I'm seeing a similar issue, and this is a PDFJS issue as far as I can tell.
In the PDFJS Worker, there's a line of code which has:
      return pdfjsFilePath.replace(/\.js$/i, '.worker.js');
    }```

The `pdfjsFilePath` variable contains the bundled filename e.g. `example.com/js/mybundledfile.js`, not the original `pdf.js`. Consequently, it tries searching for `mybundledfile.worker.js, can't find it, and then bails out.

Have you tried to include pdf.combined.js instead of pdf.js?


Very different names of sensors in checker declarations

For TRIK sensors they looks like:
twoDModel::robotModel::parts::RangeSensor
twoDModel::robotModel::parts::TouchSensor
trik::robotModel::twoD::parts::TwoDLightSensor

No logic for user how they constructed

We need to fix problem with missing Q_OBJECT in header files.
We must introduce user-friendly naming convention.


canGoBack is true when i use location.replace in Webview

Bug description:
canGoBack is true when i use location.replace in Webview，expect false
Expected behavior:
expect false
Environment:

OS: Android
react-native-webview version: 9.0.1

same problem

Bug description:
canGoBack is true when i use location.replace in Webview，expect false
Expected behavior:
expect false
Environment:

OS: Android
react-native-webview version: 9.0.1

解决了没?

@ChaoYuLeo


isCustomElement 在 webpack 环境中不起作用

Version
3.0.0-alpha.9
Reproduction link
https://github.com/Jimmysh/vue-next-isCustomElement-bug
Steps to reproduce
yarn
npm run dev
What is expected?
<custom></custom> 出现在 dom 中

What is actually happening?
出现了 <!----->

Two approaches

You can config webpack like:
{
  test: /\.vue$/,
  use: {
    loader: "vue-loader",
    options: {
      compilerOptions: {
        isCustomElement: tag => {
          return tag === "custom";
        }
      }
    }
  }
}

and in main.js
import { createApp } from "vue";
import App from "./App.vue";
createApp(App).mount('#app')

import from full build
import { createApp } from "vue/dist/vue.esm.js";
const app = createApp({
  template: "<custom/>"
});
app.config.isCustomElement = tag => {
  return tag === "custom";
};
app.mount('#app')

@djy0 Thanks.
Config webpack success for me.


Update maintainers link in CONTRIBUTING.md

Description

As per the Chef OSS practics info https://github.com/chef/chef-oss-practices/blob/master/project-membership.md#maintainer we have removed maintainer and divided into explicit roles.
So updated maintainers link in CONTRIBUTING.md
Any other links suggestion would be helpful thanks!
Related Issue
Fixes https://github.com/chef/chef/issues/8421
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.
Signed-off-by: Vivek Singh<EMAIL_ADDRESS>

Thanks @vsingh-msys


Shims are not bundled

Having following fuse.js:
const {FuseBox, CSSPlugin, SassPlugin, QuantumPlugin, UglifyJSPlugin, WebIndexPlugin, Sparky} = require("fuse-box");
let app, vendor, isProduction = false;

let themeName = 'exampletheme';
let proxy = 'http://some.proxy.url';

context(class {
  getConfig() {
    return FuseBox.init({
      target: 'browser@es5',
      homeDir: "web/typo3conf/ext/" + themeName + "/Resources/Private",
      output: "web/typo3conf/ext/" + themeName + "/Resources/Public/$name.js",
      sourceMaps: !isProduction,
      plugins: [
        [SassPlugin(), CSSPlugin()],
        CSSPlugin(),
        WebIndexPlugin({path: "."}),
        this.isProduction && QuantumPlugin({
          treeshake: true,
          uglify: true,
          bakeApiIntoBundle: 'vendor',
          css: {
            clean: true
          }
        })
      ]
    });
  }
})
// development task "node fuse""
task("default", async context => {
  const fuse = context.getConfig();
  if (!isProduction) {
    fuse.dev({
      proxy: {
        '/': {
          target: proxy,
          changeOrigin: true,
          pathRewrite: {
            '^/': '/',
          },
        }
      }
    });
  }
  fuse.bundle("vendor")
    .shim({
      jquery: {
        source: "node_modules/jquery/dist/jquery.js",
        exports: "$",
      }
    }).hmr().watch()
    .instructions("~ JavaScript/index.ts");

  fuse.bundle("app")
    .instructions("!> JavaScript/index.ts")

  await fuse.run();
});

// Dist task "node fuse dist"
task("dist", async context => {
  context.isProduction = true;
  const fuse = context.getConfig();
  await src("web/typo3conf/ext/" + themeName + "/Resources/Public/")
    .clean("web/typo3conf/ext/" + themeName + "/Resources/Public/")
    .exec();
  fuse.bundle("vendor")
    .shim({
      jquery: {
        source: "node_modules/jquery/dist/jquery.js",
        exports: "$",
      }
    })
    .instructions("~ JavaScript/index.ts");
  fuse.bundle("app")
    .instructions("!> JavaScript/index.ts")

  await fuse.run()
});

Dev-Mode: everything fine
Production: jquery shim is not included in vendor.
So I tried:
treeshake: {
  shouldRemove: file => {
    if (file.fuseBoxPath === "jquery/index.js") {
      return false;
    }
  }
},

because I noticed

→ tree shaking: Mark for removal jquery/index.js

in the console.
but still: jquery gets not included in vendor. But treeshaking stops working. app.js ist nearly 1MB instead of 1KB.
If I shim in the config part, everything ist fine, but I don't want the extra shim.js file.
I looked at https://github.com/fuse-box/jquery-shimming-example/blob/master/fuse.js
but there is not Quantum-Example.

@Gregor-Agnes
please move .shim({       jquery: {         source: "node_modules/jquery/dist/jquery.js",         exports: "$",       }     }) to FuseBox.init as described in the doc. We need to remove it from the chain, it buggy.

Ok. Is there any other way to bundle shims in vendor.js?

@Gregor-Agnes shims will be in a separate bundle called shims.js

Yes I know that. I want to reduce the http-requests and therefore I wrote:

If I shim in the config part, everything ist fine, but I don't want the extra shim.js file.

So just for the record: Is there any other way to bundle shims?

Not ATM, but we are open for PRs. That shouldn't be big of a deal.
https://github.com/fuse-box/fuse-box/blob/5652c0b0f59e9887907db4d5f0984c7accee6fda/src/quantum/plugin/BundleWriter.ts#L38-L58
We could introduce bakeShimsIntoBundle options in Quantum

#1274


Fix TimestampGen to generate value not too close to the minimum allowed timestamp [databricks]

This modifies the TimestampGen class to generate values one month further from the minimum allowed value. That is because when the timestamps fall in 0001-01 month may cause issue when reading from Spark into Pyspark:
self = TimestampType, ts = -62135596800000000

    def fromInternal(self, ts):
        if ts is not None:
            # using int to avoid precision loss in float
>           return datetime.datetime.fromtimestamp(ts // 1000000).replace(microsecond=ts % 1000000)
E           ValueError: year 0 is out of range

Closes https://github.com/NVIDIA/spark-rapids/issues/9701.

build

build

build

I'm not sure that this is 100% what we want.  Would it be better to do a date_diff in Spark and convert them all to Integers? And for timestamps could we use unix_micros to get the results out as longs?
@jlowe @abellina what do you think? Is it better to restrict the range of timestamps/dates and risk that we have some odd corner case where we copy it back to the host. Or is it better to try and "normalize" the data into something that python does not have issues with?

Reference in new is

I would do both. One case we convert to longs and keep the range, the other we don't change the query and adjust as @ttnghia has. That way we don't add extra layers that could hide an issue? My two cents.

I would do both. One case we convert to longs and keep the range, the other we don't change the query and adjust as @ttnghia has. That way we don't add extra layers that could hide an issue? My two cents.

I'm not sure how to do that. Converting all timestamps/dates to a different types is something that we can have an annotation for and programmatically insert it into the plan before we do a collect. I don't know now to coordinate that with datagen.  But Lets check this in as is, and I'll file a follow on issue to explore if there is a better way to handle this.

I filed https://github.com/NVIDIA/spark-rapids/issues/9747

build


Use the optimum strategy to insert data

Redshift: hard coded SQL insert with a max of 16MB
Other databases: batch insert with 100 batch size

Discover the database using the mechanism bellow:
https://github.com/mageddo-projects/tobby-transactional-outbox/blob/main/src/main/resources/com/mageddo/db/sql-error-codes.properties

https://github.com/mageddo-projects/csv2jdbc/pull/5/files


test.py is missing in the repository

Thank you, @dchampak, for raising the issue.
Please let me know if you would be interested in contributing to this repository.

Thank you for your message. I would love to contribute in any form, but due to other obligations, i am not sure if i would be able to develop code and checkin.

Thank you for your message. I would love to contribute in any form, but due to other obligations, i am not sure if i would be able to develop code and checkin.

Sure, No worries. @dchampak
Please feel free to reach out, Always happy to help.


Converting undefined value to Text

I faced some issue when tried to convert an undefined javascript value to Text with fromJSRef_fromJSString.
Consider following code:
foreign import javascript safe
    "$r = (function(){\
    \    if (window.config) { return window.config[$1]; }\
    \    else { return undefined; }\
    \}())"
    js_get_config_of :: JSString -> IO (JSRef a)
configRefByName :: ToJSString a => a -> IO (JSRef b)
configRefByName = js_get_config_of . toJSString

This is quite simple code to read globally stored configuration, if there is no configuration, undefined value will be returned.
Converting undefined value to String works, but a bit strange:
do
    undefRef <- configRefByName "not defined"
    str <- fromJSRef_fromJSString undefRef :: IO (Maybe String)
    print str

This prints Just "", though I supposed to see Nothing in this case. At least it works.
If I change result type to IO (Maybe Text) I'm facing runtime exception:

uncaught exception in Haskell main thread: TypeError: Cannot read property 'length' of undefined

Obviously, marshall code does not check if value actually valid and just treats it like array of chars (or something), and tries to read length of it.

In addition, fromJSRef x :: IO (Maybe Text) will return Nothing, when x is empty text, i.e "". This brings some inconveniences.
For example, I tried to define FromJSRef instance for some algebraic data type, which have several Text parameters. It uses getPropMaybe in conjunction with fromJSRef to retrieve reference's  properties and convert each of them to Maybe Text values. Though the property exists in the object and its value is not null or undefined, but "", fromJSRef returns Nothing, thus whole conversion fails.

By the way, I need to recheck behaviour described in issue body, because some things might have been changes since September.

Ok, I've written qiuck test example 1.
You can grab the code and test it yourself. Example output comment follows each test case wrapped by {--}.
First, there is test cases for described issue. I'm trying to use fromJSRef with jsNull value twice, once to get String 2, and once to get Text3; then fromJSRef_fromJSSrtring, 3 and 4 respectively:
print =<< (fromJSRef jsNull :: IO (Maybe String)) -- Just "", expected Nothing
print =<< (fromJSRef jsNull :: IO (Maybe Text))   -- Exception, expected Nothing
print =<< (fromJSRef_fromJSString jsNull :: IO (Maybe String)) -- Just "", expected Nothing
print =<< (fromJSRef_fromJSString jsNull :: IO (Maybe Text))   -- Exception, expected Nothing

After that, there are several test cases with existing object (see index.html):
test = { propNull: null,
         propUndef: undefined,
         propEmpty: "",
         propNormal: "sometext"
       };

I'm trying to get property by name and convert it to String and Text with fromJSRef function. I've done tests for:

existing (normal) property 6
property which value is empty string 7
fake property, that does not exists 8
property which value is undefined 9
property which value is null 10

@luite, please have a look!

Current proposed workaround it to try convert JSRef a to JSString type. I'll close it for now and check later.

Please try out the new-marshal branch of ghcjs-base.  Amongst other things, it includes

Pure marshal functions
An unchecked version of fromJSRef (fromJSRefUnchecked)
To/FromJSString are made a subtypes of To/FromJSRef.

Here is an example.
import GHCJS.Types
import GHCJS.Marshal
import GHCJS.Marshal.Pure
import GHCJS.Foreign
import Data.Text

main = do
        print (pfromJSRef (ptoJSRef Nothing) :: Maybe String) -- Nothing
        print (pfromJSRef (ptoJSRef Nothing) :: Maybe Text)   -- Nothing
        noString <- toJSRef Nothing :: IO (JSRef (Maybe String))
        noText   <- toJSRef Nothing :: IO (JSRef (Maybe Text))
        print =<< (fromJSRef noString :: IO (Maybe (Maybe String))) -- Just Nothing
        print =<< (fromJSRef noText   :: IO (Maybe (Maybe Text))) -- Just Nothing
        print =<< (fromJSRefUnchecked noString :: IO (Maybe String)) -- Nothing
        print =<< (fromJSRefUnchecked noText   :: IO (Maybe Text)) -- Nothing
        print =<< (fromJSRef (castRef noString) :: IO (Maybe String)) -- Nothing
        print =<< (fromJSRef (castRef noText  ) :: IO (Maybe Text)) -- Nothing

I'll have a look. Thank you so much!

@hamishmack can you please help me? What should I do to use this new-marshal branch? I have local clones of ghcjs and ghcjs-prim repos. But ghcjs-base is being installed during boot, right?

Install ghcjs as normal, then cabal install --ghcjs --global --force-reinstall in the new-marshal branch of the ghcjs-base repo.  There is no change in ghcjs or ghcjs-prim.

Oh, I've understood! Will try later this day! Thank you, Hamish!

Oh, looks like new-marshal branch is outdated a bit, I'm confused.

Updated.

Amazing, very appreciate!


chore(main): release 0.3.1

:robot: I have created a release beep boop
0.3.1 (2023-01-10)
Bug Fixes

use PAT for release please action to enable triggering dependent (1b4a4d3)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/herdstat/herdstat/releases/tag/v0.3.1 :sunflower:


Integrate basic ODM tools functionality into WebSDL

Citizen scientists need the ability to correct, QA/QC, and annotate their data.

More detail for future reference:

Something inexpensive/free is needed
Need basic steps such as moving measured water depth to stage without resorting to Excel
Need ability to annotate data with notes about what has happened or where there are problems with or gaps in the data
Need ODM Tools-like abilities for doing quality control of datasets (could this be integrated with HydroShare or the like?)