KeyboardDatePicker styling order (?)

!
This might be a local issue, but has been tested on two separate systems- and the same issue appears on both. But while creating this ticket i realized i cannot replicate the problem on codesandbox (see live example). But when running the exact program locally based on react-create-app the problem appears.
The issue seems to be related to order of how the styling gets rendered.

Tested locally the button root styling gets prioritized over the pickers. This issue occurred when upgrading from Material ui 3 and pickers 2.
Environment
{
  "name": "new",
  "version": "1.0.0",
  "description": "",
  "keywords": [],
  "main": "src/index.js",
  "dependencies": {
    "@date-io/moment": "1.3.7",
    "@material-ui/core": "4.1.2",
    "@material-ui/icons": "4.2.1",
    "@material-ui/pickers": "3.1.1",
    "moment": "2.24.0",
    "node": "10.15.3",
    "react": "16.8.6",
    "react-dom": "16.8.6",
    "react-scripts": "3.0.1"
  },
  "devDependencies": {
    "typescript": "3.3.3"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test --env=jsdom",
    "eject": "react-scripts eject"
  },
  "browserslist": [
    ">0.2%",
    "not dead",
    "not ie <= 11",
    "not op_mini all"
  ]
}

Steps to reproduce

Install create-react-app
add IconButton/Menu to app.

import React from 'react';
import './App.css';
import Demo from './demo';
import Menu from "@material-ui/icons/Menu";
import AppBar from "@material-ui/core/AppBar";
import Toolbar from "@material-ui/core/Toolbar";
import IconButton from "@material-ui/core/IconButton/IconButton";

function App() {
  return (

      <IconButton color="inherit" aria-label="Menu">
        <Menu/>
      </IconButton>
      <Demo/>

  );
}

Add MuiPickersUtilsProvider / KeyboardDatePicker used with moment.

import moment from "moment";
import React from "react";
import Grid from "@material-ui/core/Grid";
import { makeStyles } from "@material-ui/core/styles";
import MomentUtils from "@date-io/moment";

import {
  MuiPickersUtilsProvider,
  KeyboardDatePicker
} from "@material-ui/pickers";

const useStyles = makeStyles({
  grid: {
    width: "60%"
  }
});

export default function MaterialUIPickers() {
  // The first commit of Material-UI
  const [selectedDate, setSelectedDate] = React.useState(
    new Date("2014-08-18T21:11:54")
  );

  const classes = useStyles();

  function handleDateChange(date) {
    console.log(moment(date));
    setSelectedDate(moment(date));
  }

  return (
    <MuiPickersUtilsProvider utils={MomentUtils}>
      <Grid container className={classes.grid} justify="space-around">

        <KeyboardDatePicker
          margin="normal"
          id="mui-pickers-date"
          label="Date picker"
          value={selectedDate}
          onChange={handleDateChange}
          KeyboardButtonProps={{
            "aria-label": "change date"
          }}
        />

      </Grid>
    </MuiPickersUtilsProvider>
  );
}
export default App;

Run npm start.

Expected behavior
The picker element to be rendered with correct styling.
Actual behavior
Pickers element with button styling.

Live example
https://codesandbox.io/s/musing-pascal-7gbdi?fontsize=14
any help/info would be greatly appreciated.
Zipped project: https://ufile.io/wpae8kp0

Having the same issue, anyone come across any fixes?

Just to update.. I found out the issue for us was that when we had the KeyboardDatePicker mounted, we would get duplicate styles loaded for MuiIconButton, MuiToolTip, etc. The second loading of the MuiIconButton styles would then override styles from other Mui components (like Switches, DatePicker in this case, etc).
As a quick workaround for now.. I created a hook to avoid having duplicate Mui styles in the  tag.  I will say, this workaround is not an ideal solution, so I'll be following this issue to see what comes of any fixes.
function usePickerIssue1143Hack() {
	// TODO: Remove this once https://github.com/mui-org/material-ui-pickers/issues/1143 is fixed.
	React.useEffect(() => {
		const headNodes = document.getElementsByTagName('head');
		if (!headNodes.length) return;

		const targetNode = headNodes[0];
		const observer = new MutationObserver(mutationList => {
			// is a style dom node added
			const addedStyleNode = mutationList.some(mutation => {
				if (mutation.type !== 'childList') return false;
				return Array.from(mutation.addedNodes).some(
					addedNode => addedNode.nodeName === 'STYLE'
				);
			});

			// if we didn't add a style node, no need to do the rest
			if (!addedStyleNode) return;

			const styleNames = {};

			// iterate over all style tags
			Array.from(document.getElementsByTagName('style')).forEach(node => {
				// get the Mui style name stored on data-meta
				const styledName = node.getAttribute('data-meta');
				if (!styledName) return;

				if (!styleNames[styledName]) {
					// keep track of Mui style names we've already added
					styleNames[styledName] = true;
					return;
				}

				// remove style node if already exists in head
				node.remove();
			});
		});

		// observe for childList changes including subtree
		observer.observe(targetNode, {
			childList: true,
			attributes: false,
			subtree: true,
		});

		// disconnect on hook cleanup
		return observer.disconnect;
	}, []);
}

That can mean that you have 2 different jss packages in the bundle

I have the same issue. I don't think I had it before. It probably came with packages updates, don't know where it comes from though. Thanks

I've experienced the same issue, tracked the cause to this: https://github.com/mui-org/material-ui/issues/15610. I followed https://github.com/mui-org/material-ui/issues/15610#issuecomment-492215308, and fixed all imports that was double nested, eg. changed
import Button from '@material-ui/core/Button/Button';

to
import Button from '@material-ui/core/Button';

I had a LOT of imports to fix (did a search on from '@material-ui/core/, it was a breeze). After all imports were fixed, the problem went away.
You can check if you have the same problem with duplicate imports, by going in to your Chrome DevTools > Sources > expand localhost:port > node_modules > @material-ui > core > esm. If you are doing it "wrong", you will have the same module both in root of core folder, and in core/esm folder. (see first screenshot)
If you are doing it right, you only have modules in the esm folder. (see second screenshot)

Thank you @JReinhold !! I also had '@material-ui/Component/index' imports which needs to be renamed '@material-ui/Component'

This solved our problem as well. Thank you @JReinhold


Use more of create-react-app

Now that CRA is using a monorepo, we should be able to easily consume (and contribute to!) it.
Looks like a good idea to "standardize" some behaviors. We should be able to remove some similars stuff like utils for formatting errors etc.
I guess @gaearon will find it's a good idea, he probably makes a monorepo for that purpose.
We should also make basically a no boilerplate, with no config by default, and offer an eject feature too.

[ ] re-open tab thing #724
[ ] eject
[ ] formatting
[ ] server?
[ ] babel-preset
[ ] eslint-config

We can't really reuse eslint config since it "require" a flowtype plugin and I don't want people to have deps they won't probably use (even if they should ^^).
Will need to find a less strict thing than i-am-meticulous.

This issue is too wide. Closing in favor or more small issues.

Sorry to raise the dead issue but does the eject feature every got around? I saw snippets of the discussion but no conclusion

@drFabio per our new architecture, it's not making sense anymore (at least for eject). Configuration is for now very minimal an injected. You can provide your own webpack/babel config and it should just work.


owncloud-client: 4.0.0 -> 4.1.0

Description of changes
Upgrade owncloud-client to 4.1.0.
Upstream release note:  https://github.com/owncloud/client/releases/tag/v4.1.0
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build owncloud-client

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2339

@ofborg backport ?


How to make button event

I know that buttons is not really working in extensions, but is it some way I can get the button element in a easy way. I want to do button.onclick = ()=>{do something}

I have an ugly solution to this, you can make a reporter block that does this:

I have an ugly solution to this, you can make a reporter block that does this:

I don't think that works, but I can check

I have an ugly solution to this, you can make a reporter block that does this:

I don't think that works, but I can check

It works, I tested it.

I have an ugly solution to this, you can make a reporter block that does this:

I don't think that works, but I can check

It works, I tested it.

Thanks :D


Use the singleton pattern in NovaClient

The patch to use the singleton pattern in NovaClient
missed the call to _get_client. This patch fixes that.

Don't merge -- this has a temporary patch that shouldn't go in. Closing pull-request.


Error when deploying for the web

Hello!
I was testing your lib and seens to work fine in dev. Now I'm trying to make it work for the web in production mode but is not working.
I got this in the console:
 No enum value matches 'inified:ajq', did you use the correct mode or case-style or forgot to specify a default value?
Looks like a error with the minified version, do you have any idea on how to fix this? Thank you!

flutter --version ?

Flutter 3.19.6 • channel stable • https://github.com/flutter/flutter.git  Framework • revision 54e66469a9 (4 weeks ago) • 2024-04-17 13:08:03 -0700 Engine • revision c4cd48e186                                              Tools • Dart 3.3.4 • DevTools 2.31.1
Example working fine on this last version

Flutter 3.19.6 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 54e66469a9 (4 weeks ago) • 2024-04-17 13:08:03 -0700
Engine • revision c4cd48e186
Tools • Dart 3.3.4 • DevTools 2.31.1
I'm using the messageToObject method to call Class.fromJson. In the sendMessage I'm calling sendMessage(json.encode(map)).

Hey, looks like a problem on my side. Sorry.


poissonlogpdf Fix for ForwardDiff

This fixes poislogpdf to work with Dual numbers. Thanks to @mohamed82008 for doing near everything.

It would be nice to add some tests and maybe fix https://github.com/TuringLang/Turing.jl/blob/master/test/ad.jl/AD_compatibility_with_distributions.jl if possible.

I will merge now, then add tests and other stuff in another PR.


Parsing 64-bit integers fails on 32-bit Perls

Only the parse_alias() function is affected by this issue. It will still return a result in 32-bit Perls, but the 64-bit integer values are returned as raw undecoded bytes instead. The affected keys are fileIDs, volCapacity, and volHomeDirRelativePathComponentCount.
There wasn’t really much consideration of 32-bit Perls during development because Macs have been exclusively 64-bit for a while. On other systems, 32-bit environments are also becoming increasingly rare. But yes, this module should also work on 32-bit Perls in principle.
To address this issue, it seems that we should inspect use64bitint in Config, then conditionally load Math::BigInt and create the object using from_bytes after reverse, for endianness. (The Config value should probably only be read once, then stored in a package-global variable, so that it can be overridden for testing etc.)
That said, many 64-bit values don’t actually use the most significant half of the available bits. This should be easy to detect. Such values should probably not be returned as Math::BigInt objects, but as regular 32-bit ints instead. (Don’t forget the sign bit.)
Examples of this issue surfacing on CPAN Testers:

3994d73a-fb63-11ec-99a3-a3c6a802619c – armv6l-linux 5.15.32+, Perl v5.36.0
bc86fc20-fb56-11ec-8f4e-c962458f5e5b – i686-linux 5.10.0-12-686, Perl v5.26.3
1fc78680-fba5-11ec-adc0-753601faaa58 – i686-linux-quadmath 5.10.0-11-686-pae, Perl v5.32.0
47a21382-fc36-11ec-8f4e-c962458f5e5b – i386-freebsd 13.0-release, Perl v5.28.3
9db75a66-fc0e-11ec-85a3-b416c17e0570 – i386-openbsd 7.1, Perl v5.32.1

https://www.nntp.perl.org/group/perl.perl5.porters/2022/09/msg264737.html
Perhaps the documentation should simply recommend -Duse64bitint?


Can Get CallContext Without Method Parameter ?

Can Get CallContext Without Method Parameter ?
For Example From BaseClass

I assume you are asking about server implementation inside Grpc.AspNetCore hosting.
You can try this:
// Startup.cs
public void ConfigureServices(IServiceCollection services)
{
    services.AddServiceModelGrpc();

    services.AddHttpContextAccessor();
}

public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
{
    app.UseEndpoints(endpoints =>
    {
        endpoints.MapGrpcService<MyService>();
    });
}

[ServiceContract]
public interface IMyService
{
    [OperationContract]
    Task<string> AccessServerCallContext();
}

internal sealed class MyService : IMyService
{
    private readonly IHttpContextAccessor _httpContextAccessor;

    public MyService (IHttpContextAccessor httpContextAccessor)
    {
        _httpContextAccessor = httpContextAccessor;
    }

    public Task<string> AccessServerCallContext()
    {
        var serverCallContext = _httpContextAccessor.HttpContext.Features.Get<IServerCallContextFeature>().ServerCallContext;
        return Task.FromResult(serverCallContext.Method);
    }
}

@max-ieremenko yes yes thank you

hi @majidbigdeli ,
since no activity, I am closing this issue.
If this in error, let me know with a comment and I will be happy to reopen the issue.


Migrated Greek pack not containing new dictionary

The migrated pack contaings only the aosp dictionary. Shouldn't the new dictionary be placed into directory dictionary/prebuilt?

Missed that. Sorry. Did you provide the prebuilt dictionary?

The dictionary is this


No instructions for deploying modern report designs to production

There are no instructions or guidance on how to deploy the modern report designs to production after importing the model into the Dev environment.  Are there specific steps, or is the model considered a custom modification and should be treated as such?  (e.g., checked-in to source control, built into an AIO deployment package, etc.)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 586f12ef-881e-1e4d-13e7-6b355e5e53eb
Version Independent ID: 85382ffd-3e2f-a98e-3620-1cdc2ebcd7df
Content: Install modern report design templates - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/analytics/install-modern-report-design-templates.md
Service: dynamics-365-cross-app
Product: ****
Technology: ****
GitHub Login: @RichdiMSFT
Microsoft Alias: richdi

@danielzook, thanks for the feedback. @RichdiMSFT, please review.

Bug 603468 logged to track this issue.


fix: lsp find struct reference in return locations and paths

Description
Problem
Resolves #5394
Summary
Finds struct locations in return types and inside paths.
Additional Context
Making it work for the return type was simple: the code to register it is now done a bit earlier so it works in all cases where a type is referred as the last segment in a Path.
Making it work when the type is in the middle of a Path (like in foo::Foo::new) was a bit trickier: the existing Path lookup only cared about (and registered) the result of the last segment. So now there's code to register each segment in turn... but this is only done if running in LSP mode. So in foo::Foo::new, foo is linked to a module and Foo is linked to a struct. The existing code relied on the DependencyId for this, but a "module" dependency didn't exist... to avoid introducing new variants that are only used in this reference tracking I instead created a new enum, ReferenceId.
Documentation
Check one:

[x] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Actually, given that this wasn't already working well, and this makes it closer to working well, we could merge this PR then I can work on the other things in a separate PR... mainly because I have two other PRs on top of this branch (to avoid merge conflicts) :-)


Use IterableUserDict for os.environ base

This resolves an issue where our overridden os.environ could not be cast to a list or sorted. See backwards compatibility note in docs for details: https://docs.python.org/2/library/userdict.html#UserDict.UserDict
R: @apolito CC: @isdal @hazarm

LGTM


Unable to compile, condition checking

Bug Report
const arr = ['A', 'B'];
if (arr[0] === 'A') {
  arr.shift();
  if (arr[0] === 'B') { // This line has an error
    arr.shift();
  }
}

🙁 Actual behavior
This condition will always return 'false' since the types '"A"' and '"B"' have no overlap.
🙂 Expected behavior
Should not error since shift has changed the array and the first element can now be different

Duplicate of #33443.

Duplicate of #33443.

Duplicate of #33443.

Duplicate of #33443.

Closing as this seems to be a dupe

Closing as this seems to be a dupe


Update prefix for phone number parameter

Summary
Update prefix for the phone number field from c/ to p/ in the user guide
Checks

[ ] Link PR to issue
[ ] Add Reviewer
[ ] Pass CI

Codecov Report

Merging #80 (1a3e113) into master (df31aea) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #80   +/-   ##
=========================================
  Coverage     72.69%   72.69%
  Complexity      437      437
=========================================
  Files            76       76
  Lines          1293     1293
  Branches        132      132
=========================================
  Hits            940      940
  Misses          317      317
  Partials         36       36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df31aea...1a3e113. Read the comment docs.


Articles are not organized consistently

The articles are not organized consistently. The expected organization is Title -> Subtitle -> Article (as described by marak).

I believe this has since been resolved. Feel free to open an issue if you still feel that article organization is ramshackle.


ImageUploadEditor and svg files

It appears that ImageUploadEditor does not support .svg files.
When I try to upload a .svg it gives me a "Uploaded file is not an image!" error. But svg's are images (vector graphics).
Is there anyway to make ImageUploadEditor accept .svg files?

probably the error message is a bit wrong. It better should be: "Uploaded file is not a bitmap image!".
As long as you are willing to accept that there will be no preview of the svg directly within the imageUploadEditor widget, then you can set the attribute: AllowNonImage which should allow you to upload unrenderable files.
Hope, this helps.
With kind regards,
John

I can accept that.
I have created a ImageFormater to display ths SVG on xyzColumns, and it works perfectly.
So thanks :)


Default value for field with no value specified / required field

Hi!
Is there any way to specify that some field is required (see, e.g., click's required option)?
Also, by default one cannot use field from dataclasses with no default value (with every other parameter left also by default) while with pyrallis it is replaced with None value instead. Although, personally I am not having any problem with that (even more, with that behaviour, I can somewhat manually check for required fields via assert some_value is not None for example) but it would be much cleaner if such required options are available.

Any update of this?


Simultaneous use less and sass

mix.sass(...).less(...); - Only works less
mix.less(...).sass(...); - Only works sass
Both do not work. Always only the second.

Update your laravel-mix dependency, support for this was recently added

Many thanks


chore: sanitize paths

I have already updated the provided default import.js. But good point, I am going to add a note in the guidelines.


Add SQS resource

Signed-off-by: sahil-lakhwani<EMAIL_ADDRESS>Description of your changes
This PR adds Queue resource offered by the AWS Simple Queue Service.
An example to create a Queue resource can be found at examples/applicationintegration/queue.yaml
Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[ ] Updated any relevant documentation, examples, or release notes.
[ ] Updated the dependencies in app.yaml to include any new role permissions.

@negz  I have addressed your review comments.

@hasheddan Can you please approve this PR if you feel your comments were addressed in order to clear out your requested changes?

@sahil-lakhwani I'm seeing a failing test - could you please look into this.

@negz I have fixed this.
(This was probably due to the upgrade to the AWS SDK after the rebase.)

Thanks @sahil-lakhwani!


Selecting cell in table

Hello all,
Creating a multi step menu where we have 4 main options in a row using a table.
Am able to bind a key to the table and display a second row, kinda like a submenu, but am unable to use the (*tui.Table).Select(i int) to select a particular cell, at the moment it selects an entire row and applies the builtin functionality and styes.
Maybe we could select a single cell of the table and style it accordingly, any suggestions on how to do this? else maybe this is something we could work towards implementing.

I think this makes sense to implement. I might take a look at this during the holidays if I find the time.


In-Browser Download link doesn't work!

In-Browser Download link doesn't work!

@sarthology

Thanks for point is out.


C# compiler options in localized ru-ru docs use inconsistent command line switch syntax

See this topic and its sub-topics.

Did you mean to open this issue in our repo @eduard-malakhov?

No @mairaw , I've created it for myself to intentionally because I thought that localized docs are managed in the same repository, but as far as I understand now, localizations are entirely managed in separate repositories and it is not common to replicate minor fixes one-by-one, rather they the localized docs are updated on a regular basis by translators and then the changes made to the original docs end up in the localized versions. So, I guess there's nothing to do about the subject and the issue can be closed. Is that the correct way to go?


kilosort functions

functions related to kilosort

I need to still change all functions so that we can concatenate trials within the same probe configuration, subject, and port.


fix: Added bootstrap method

:tada: This PR is included in version 1.1.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Async refresh

Thanks for your PR. I'm wondering if it's possible to limit number of goroutines for refreshing data?

@nqv Will work on that. Meanwhile I can not see any use refreshAfterWrite variable. Shall I add this this to trigger refresh in loading cache?

@nqv Please provide any suggestions or feedback.


Add navigation capability like OCL or SQL select capability to navigate a model

Originally reported on Google Code with ID 540

Replicate something like the following capability in Umple:
http://modeling-languages.com/executing-ocl-expressions-plain-java/?utm_source=feedburner&utm_medium=feed&utm_campaign=Feed%3A+ModelingLanguages-blog+(Software+Modeling+Blog)
The ideas is that you could navigate associations using a language similar to OCL

Reported by @umple on 2014-04-14 14:20:13

Blocked on: #187

Another interesting work close to this issue:
Modular Embedding of the Object Constraint Language into a Programming Language

@opeyemiAdesina


update flowconfig to 70

Thanks to the discussion in #564

this project doesn't explicitly support flow anymore because nobody has the time to maintain it. if you'd like to take it over then let me know ;) but you'd have to be prepared to spend maybe 4-8 hours per month on it


What's the difference between LanguageBind and LLaVA-1.5

Hello! Your LanguageBind is amazing! But I'm new to multimodality, and I was wondering what's the difference between LanguageBind and LLaVA-1.5? Should I use LLaVA-1.5 or LanguageBind if I want my model to have more reasoning power while handling multimodal input (currently, text, image, and video are the three modes at most)? Considering that LanguageBind may be a better choice if other modes are to be added in the future, can LanguageBind be easily combined with LLaVA-1.5, LLaMA, or etc.? I'd like to hear your views on these issues.

LanguageBind and LLaVA are both multi-modal models, but they have different focuses. LanguageBind is designed to align individual modalities to text space. LLaVA maps pictures to LLM for image-text conversations. I think connecting the encoder of each modality of LanguageBind to LLM is more conducive to multi-modal LLM. Because they have been aligned to a textual semantic space in advance.
In addition, our Video-LLaVA is a good proof that it achieves strong performance after aligning video images in advance through LanguageBind encoder.
https://github.com/PKU-YuanGroup/Video-LLaVA

Thank you very much for your reply. It helps me a lot.


Add border type for style in render item of custom series.

What problem does this feature solve?
For itemStyle of custom series, we have borderType having "solid", "dashed" as its value. But in the style of renderItem method, we do not have the same properties.
What does the proposed API look like?
I propose we add a property named "lineType" which does the same thing with borderType in the style object of renderItem method.

Now there is series-custom.itemStyle.borderType for specifying the type of border for all.
Do you want to specify a different borderType for each item in renderItem callback function or make borderType functional?

Now there is series-custom.itemStyle.borderType for specifying the type of border for all.
Do you want to specify a different borderType for each item in renderItem callback function or make borderType functional?
Does any one think which scheme will be better?

Now there is series-custom.itemStyle.borderType for specifying the type of border for all.
Do you want to specify a different borderType for each item in renderItem callback function or make borderType functional?
Does any one think which scheme will be better?

I see that all the properties in series-custom.itemStyle have corresponding properties in renderItem callback function style except borderType. e.g. borderColor has the same meaning as stroke, color has the same meaning as fill but I can not find a corresponding property for borderType in the style of renderItem callback function. It is weird, isn't it? So I want to have a lineType to specify a different borderType for each item and I think it is reasonable.

@nguyencuongabcxyz Do you mean you wish https://echarts.apache.org/en/option.html#series-custom.renderItem.return_path.style to support lineType?

@nguyencuongabcxyz Do you mean you wish https://echarts.apache.org/en/option.html#series-custom.renderItem.return_path.style to support lineType?

Yes. Also for other return_ . I have found a workaround by using lineDash property with some special values. But I think it is ideal to have a lineType property with the same values as borderType property.

@nguyencuongabcxyz
lineDash can be used for this case, like:
function renderItem(params, api) {
    var yValue = api.value(2);
    var start = api.coord([api.value(0), yValue]);
    var size = api.size([api.value(1) - api.value(0), yValue]);
    var style = api.style();

    return {
        type: 'rect',
        shape: {
            x: start[0] + 1,
            y: start[1],
            width: size[0] - 2,
            height: size[1]
        },
        style: {
            fill: 'red',
            stroke: 'green',
            lineWidth: 3,
            lineDash: [5, 5]
        }
    };
}


[issue 134] - Document next milestone goals

Description
Fix #134
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change
[x] Chore (non-breaking change which doesn't affect codebase;
test, version modification, documentation, etc.)

Checklist

[x] Code contributed by me aligns with current project license: Apache 2.0
[x] Pull Request contains a description of the changes
[x] Pull Request does not include fixes for multiple issues/topics
[x] Code is self-descriptive and/or documented
[ ] N/A - I have implemented unit tests to cover my changes
[ ] N/A - I tested my code in OpenShift

/test all

Are those goals described in github issues (or maybe on jira)? From my PoV, those tasks needs to be described there anyway (maybe with "next_release" label, or something like that) with more details and also can be filtered there by some priorities (eg based on "high_prio" / "low_prio" labels, or something like that), so maybe that it's duplication of content to maintain tasks in readme as well?

Are those goals described in github issues (or maybe on jira)? From my PoV, those tasks needs to be described there anyway (maybe with "next_release" label, or something like that) with more details and also can be filtered there by some priorities (eg based on "high_prio" / "low_prio" labels, or something like that), so maybe that it's duplication of content to maintain tasks in readme as well?

Thanks @marekkopecky - Maybe I am getting it wrong but the text that this PR is adding contains the link to the relevant milestone. Isn't that enough? Or am I missing the point?
Re the location for the issues, some time ago we agreed that we can have a single JIRA tracker for each milestone, since we prefer to have issues described in GitHub ATM.

Maybe I am getting it wrong but the text that this PR is adding contains the link to the relevant milestone. Isn't that enough?

Re the location for the issues, some time ago we agreed that we can have a single JIRA tracker for each milestone, since we prefer to have issues described in GitHub ATM.

Ah, good point, the link for github issues is there, +1, one jira is ok as well. But priorities are not defined in github list and some tasks from this MR is not there at all (eg I don't see an issues for Quarkus or logo). So if someone want to see upcoming tasks, they needs to check readme (this MR) and https://github.com/Intersmash/intersmash/milestone/2, and still don't see the priorities there. To be realistic, I guess that not all of mentioned tasks will be done in next milestone, so priorities could help here.

That being said, this text in the README is just about a subset, mentioned just as an advertisement.

Well, I would just prefer to keep link to github and maybe add some explanations of labels here in readme. But remove the details, those are duplicated here from the list on github ( https://github.com/Intersmash/intersmash/milestone/2 ). It would simplify the future maintenance. Anyway, I don't have strong feeling here. If you reconsider it and still think that this advertisement is worth the extra maintenance, we can keep subset of tasks here.

Maybe I am getting it wrong but the text that this PR is adding contains the link to the relevant milestone. Isn't that enough?

Re the location for the issues, some time ago we agreed that we can have a single JIRA tracker for each milestone, since we prefer to have issues described in GitHub ATM.

Ah, good point, the link for github issues is there, +1, one jira is ok as well. But priorities are not defined in github list and some tasks from this MR is not there at all (eg I don't see an issues for Quarkus or logo). So if someone want to see upcoming tasks, they needs to check readme (this MR) and https://github.com/Intersmash/intersmash/milestone/2, and still don't see the priorities there. To be realistic, I guess that not all of mentioned tasks will be done in next milestone, so priorities could help here.

I agree with you about priority, and also about missing GitHub issues for items in the list.
We're still defining it, though, that is why the milestone is still being mentioned as WIP.
So yes, I'd say the next action item for this should be to start a discussion for assigning labels to the milestone issues, although I think this should be done asynchronously and not block this PR from being merged.

That being said, this text in the README is just about a subset, mentioned just as an advertisement.

Well, I would just prefer to keep link to github and maybe add some explanations of labels here in readme. But remove the details, those are duplicated here from the list on github ( https://github.com/Intersmash/intersmash/milestone/2 ). It would simplify the future maintenance. Anyway, I don't have strong feeling here. If you reconsider it and still think that this advertisement is worth the extra maintenance, we can keep subset of tasks here.

I really like the concept of advertising some (hopefully) attractive features, you're right about the maintenance effort though, so I'll keep it to one liner, and link the milestone.

+1, thank you! I'm going to merge this PR once github allows it to me (probably after CI runs).


Question: how does it work?

Does it do downsampling again and again on the same file, or does it load all into JNI, and then just pick the pixels it needs ?
Or maybe it has the option to choose from them ? I mean, it would be a waste to downsample all the time, when you can have it all in the RAM (without being afraid of OOM) ...

That's implementation detail of SSIV, briefly speaking:
It does a downsampling when load the image fully into screen (as a Bitmap, so it's in java heap), that downsampling is optional too, if the image is very small, no downsampling happens, then when user zoom the image, only several regions of the image is decoded (also as Bitmap, java heap).

I see. Can you also add the JNI solution?
I think it should be better in terms of performance and maybe even heap memory usage.
You could even downsample in your own way. As I remember, the downsampling of Android is only of power of 2, and it sometimes has some aliasing in it.
In the past, I created a library that shows how to mess around with bitmaps, but sadly it doesn't do the decoding in JNI:  https://github.com/AndroidDeveloperLB/AndroidJniBitmapOperations
However, I remember I saw a library that does the decoding in JNI too, yet it wasn't seem to be easy to use.

Image loading and cacheing, that's the responsibility of image loading library, e.g. Fresco, Glide, Picasso, and image displaying, including downsampling, pan and zoom, animation, etc, is the responsibility of image displaying library, e.g. SSIV.
This library focus on bridging them together, although currently only image loading library is configurable, but if there are other brilliant image displaying libraries, make it configurable is very easy.

I'm not complaining. I just suggest this as another option, because I think a single decoding (even if it's a bit long) might be better than multiple ones, as long as your device has enough RAM.
If you take, for example, a 40MP image, it takes around 40*4 = 160MB of RAM. This is a lot for heap memory, but it's fine for RAM itself, because most devices out there have at least 1GB of RAM.

Yep, I understand. But I really think that's another image displaying library. Besides, I don't have enough knowledge and time to do such thing, currently.
If you have a good solution, I can modify this library to use your image viewer as an option :)

Sadly the more I read about it, the more complex I saw of how to decode images in JNI.

I'm closing this issue, if you have other questions, please feel free to reopen it :)


Fix issue using single threaded tokio runtime for warp

Warp was previously only using the single threaded tokio runtime.
I've now applied all of the features(just like routerify).
Here's the output from wrk with the same command(change is relative because i have a decent pc):
With single threaded runtime:
1st test:
Running 8s test @ http://<IP_ADDRESS>:8081
  4 threads and 200 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.33ms  505.43us  17.25ms   98.38%
    Req/Sec    38.81k     4.46k   42.42k    95.94%
  Latency Distribution
     50%    1.26ms
     75%    1.29ms
     90%    1.37ms
     99%    3.19ms
  1235543 requests in 8.05s, 96.62MB read
  Non-2xx or 3xx responses: 1235543
Requests/sec: 153514.31
Transfer/sec:     12.01MB

Running 8s test @ http://<IP_ADDRESS>:8081
  4 threads and 200 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.32ms  521.46us   9.61ms   98.19%
    Req/Sec    39.03k     4.82k   42.35k    97.50%
  Latency Distribution
     50%    1.25ms
     75%    1.30ms
     90%    1.36ms
     99%    3.84ms
  1243033 requests in 8.05s, 97.21MB read
  Non-2xx or 3xx responses: 1243033
Requests/sec: 154339.78
Transfer/sec:     12.07MB

With multi-threaded runtime:
Running 8s test @ http://<IP_ADDRESS>:8081
  4 threads and 200 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   491.85us  561.11us  22.24ms   93.13%
    Req/Sec   111.53k    19.06k  136.79k    92.19%
  Latency Distribution
     50%  355.00us
     75%  557.00us
     90%    0.87ms
     99%    2.56ms
  3552834 requests in 8.05s, 277.84MB read
  Non-2xx or 3xx responses: 3552834
Requests/sec: 441173.15
Transfer/sec:     34.50MB

Running 8s test @ http://<IP_ADDRESS>:8081
  4 threads and 200 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   605.08us  518.53us  21.61ms   90.03%
    Req/Sec    86.25k     9.70k  103.34k    81.56%
  Latency Distribution
     50%  478.00us
     75%  725.00us
     90%    1.05ms
     99%    2.67ms
  2747436 requests in 8.07s, 214.85MB read
  Non-2xx or 3xx responses: 2747436
Requests/sec: 340660.10
Transfer/sec:     26.64MB

Running 8s test @ http://<IP_ADDRESS>:8081
  4 threads and 200 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   554.86us  628.21us  22.45ms   92.81%
    Req/Sec   102.35k    23.69k  137.37k    89.69%
  Latency Distribution
     50%  398.00us
     75%  627.00us
     90%    0.99ms
     99%    3.16ms
  3259278 requests in 8.05s, 254.88MB read
  Non-2xx or 3xx responses: 3259278
Requests/sec: 404977.66
Transfer/sec:     31.67MB

What's the next step here, @rousan? I think we need to update all of the comparisons listed in the README, which means someone needs to run them all on the same machine.

Hey @seanpianka, it will be a huge help, if you can re-run these tests on a same machine and update the README. I got busy on some other projects lately.

Closed because of https://github.com/routerify/routerify-benchmark/pull/3


Error when trying to inject dll

Hi whenever I try to inject Oriris dll (Compiled from GitHub) I get this error (Injector is Xenos):

Delete the "Release" folder in the Osiris folder and recompile using "Release" and NOT "Debug" in Visual Studio. Also, might be an injector problem too.

@SwagsRGB When I built the solution to the "Release" folder (I was recompiling into "Debug" before) I still got the same problem. Is their an injector that you recommend?

try recompiling it and i personally use sazz injector

Hi, I just solved the problem with a different injector thanks so much!


TCPDF ERROR: Please explicitly set action attribute path!

I entered my  blade path correctly but I got the following error:
TCPDF ERROR: Please explicitly set action attribute path!
It works properly when I run the view separately, but when I get the PDF, I get the error that the file path is incorrect.

It could be due to multiple reasons,

Check if there are forms in your HTML while creating PDF.
Check the paths you included/used in your HTML to be accessible.
It you are using a framework, make it sure it has the permission to these files used in PDF generation.


Feature request: command-line argument for Tournament to run with single bot

As a temporary workaround you can comment-out all other cars in __init__.py


Move entire sidebar content down with padding

This is more flexible than position: relative on a single element

Flexible how? This doesn't work correctly when viewing the dashboard in an org.

Good catch. This other commit should fix it.
Flexible meaning that it still works if GH or other extensions append other boxes/content in there.

Thanks :)

❤


Update rank-em figure functionality

once #183 is up and ready, we'll need to:

[x] switch the reliance on "hover" to overlap of bounding boxes when a state is dragged over a bar (hover isn't a solution that works for mobile)
[x] use d3.scale to set up x and y bar chart placement in the figure
[x] let the user know somehow that they were wrong (if they were)
[ ] [icing] link the "closed" bars to their state/territory on mouseover
[ ] [icing] show total value on mouseover of state or bar (when "closed")
[ ] [icing] used cursor "grab" when on top of the moveable states

After doing a big text overhaul, I feel like there are two things missing from this figure and would like to think about adding them if possible.

Text that says "Drag the states over its matching bar" that goes away as soon as you start dragging.
When you successfully complete the exercise, text that explains why Idaho might be a little surprising. E.g. "You might have thought that Idaho would be smaller than Oklahoma and Michigan given it's population, but it has large pockets of agriculture that increase it's total water use." (but better than that wording)

great ideas. Similar "drag the .." text type as in climate-fish viz?

Yes, exactly what I was picturing.

For font, in the climate fish viz we used
<style type="text/css">@import url(https://fonts.googleapis.com/css?family=Shadows+Into+Light);</style

Working on some of the recent things brought up after jread's pr #217

Closed by #232


feat: allow multiple lines in alert component

Description
Fixes : #30851
I have raised this pr in-order to allow multiple lines in alert message
Screenshots
passing \n in the message

unable to parse \n

After issue is resolved

Cypress Testing video
https://github.com/user-attachments/assets/ec826cef-664f-4392-b81e-9974178e65ec

Summary by CodeRabbit

New Features

Introduced automated tests for the button widget's alert functionality, ensuring correct display of messages with newline characters.
Enhanced the Toast component to better render content, improving readability by preserving whitespace and formatting.

Bug Fixes

Improved the display of alert messages in toast notifications, ensuring they respect original formatting.

@appsmithorg/query-js-pod , Please review this pr if you have enough bandwidth.
Thanks in advance.

/build-deploy-preview skip-tests=true

@saiprabhu-dandanayak Could you please fix the lint and prettier checks that are failing for the PR?

Hi @rishabhrathod01 , fixed the lint and prettier checks ,  could you pls check ??

Hi @rishabhrathod01 , if you have enough bandwidth , can you pls review this pr , i would be happy to work on comments if any.
Thanks in advance.

@carinanfonseca can you please check the design changes here

hello @saiprabhu-dandanayak
thank you for your contribution.
It makes sense to recognize the \n when we are in JS mode, but in non-JS mode, a user shouldn't be expected to use \n to create a new line. In that mode, pressing 'Enter' in the text area itself should work, like this:

let me know if this is possible. I am happy to answer any questions.

Hi @carinanfonseca  , the screenshot i have added in PR description have double \n , so the spacing is more and even in non-JS mode if we provide  Enter it will work as expected , In non-JS mode even if we provide \n it is being resolved automatically.
Please let me know this is expected behaviour or not.

@saiprabhu-dandanayak could you fix the storybook checks that are failing for the PR?

Hi @rishabhrathod01 , The error is showing it lacks  Project token and i am not sure how to fix this.
Any suggestions would be helpfull.
Thank You.

@saiprabhu-dandanayak you could ignore the storybook failure for now. The Appsmith team will forward the designs for the Toast UI to be implemented here.
cc: @carinanfonseca

/build-deploy-preview skip-tests=true

@saiprabhu-dandanayak could merge the latest release branch to the PR? Will need trigger the workflow again.

Hi @rishabhrathod01 , took recent pull from release branch and updated the source branch , pls check.
Thank you.

Shadow PR for Cypress run

https://github.com/appsmithorg/appsmith/pull/36514
https://github.com/appsmithorg/appsmith-ee/pull/5218

Test has passed for the shadow PR - https://github.com/appsmithorg/appsmith/pull/36514
This PR is safe to merge

@saiprabhu-dandanayak  We are reverting this PR since it is causing below issues.

There was a white space in front of the content which was fixed by https://github.com/appsmithorg/appsmith/pull/36629
Content is not getting wrapped. https://github.com/appsmithorg/appsmith/issues/36642
While running this change in storybook, the toast is expanded in height.


fix: fix broken consign with artsy link

This PR resolves ONYX-1061
Description
This PR fixes the broken consign with Artsy button. The button wasn't broken but the functionality was broken. The button switches you to the sell tab, but if you are already there, then nothing happens. When I tried to popToRoot on the tab by checking useSelectedTab, I noticed that it was broken. The reason behind that is that useNavigationState doesn't return the entire app state, but the tab state - I am fixing that by directly getting that state from the reference that we use for navigation as well.
https://github.com/artsy/eigen/assets/11945712/5beb03f1-8751-4fed-9a81-89d087483f21

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

fix broken consign with artsy link - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

fix useSelectedTab hook - mounir

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (fix broken consign with artsy link - mounir)
Dev changes (fix useSelectedTab hook - mounir)

  Generated by :no_entry_sign: dangerJS against 71119f0d265940ebb36db69bbf99a8be186b734d


Minor fix suggestion: Default to "TAB_BOOST" when supporting own claims

Someone mentioned about odysee.com showing "tip" related text when supporting own claims. Now it should default to "Boost" related text for own claims.
L167: Line not edited but not sure if "claimIsMine" is needed there any more.
PR Checklist

Please check all that apply to this PR using "x":

[X] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[ ] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type
What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Fixes
Issue Number:
What is the current behavior?
When supporting own channel ,app/site shows text about tipping.
What is the new behavior?
When supporting own channel, app/site shows text about boosting.
Other information

Thanks Miko! There's another minor one on the channel page - it shows "boost your content" on title and button, should probably say Channel. Maybe you can add here or in new PR.

hm, lint failed. will have to fix.


Return empty file list instead of throwing error when dependency artifact is empty

What is this PR for?
This PR returns empty list of dependency files instead of throwing error when dependency artifact input form in interpreter setting is empty.
What type of PR is it?
Bug Fix
Is there a relevant Jira issue?
No. The bug is reported through comment in #673
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Hi @minahlee I am not in the position to build zeppelin right now. I can test it over the weekend, if this is fine for you.

@FRosner Sure take your time and thank you for keeping your eyes on it :)

Changes looks good to me.

looks good

Merge if there're no more discussions


Update typings for BankingAliases.getAll

Seems like types for this method signature are not up to date:
https://github.com/Mangopay/mangopay2-nodejs-sdk/blob/master/typings/services/BankingAliases.d.ts#L27
Should be something like: MethodOverload<string, bankingAlias.IBANBankingAliasData[]> I believe. That string param type is the walletId according to the documentation at https://docs.mangopay.com/endpoints/v2.01/banking-aliases#e858_view-the-banking-alias-for-a-wallet

I am running into the same issue currently.


[Windows] Fuzzy Text

The Issue
Steps to reproduce

Hover over any thumbnail content

Expected behaviour
Text should be clear
Actual behaviour
Text is fuzzy
System Configuration
Resolution: 1920x1080
{
  "id": null,
  "jsonrpc": "2.0",
  "result": {
    "build": "release",
    "ip": "---.---.---.---",
    "lbrynet_version": "0.14.2",
    "lbryschema_version": "0.0.9",
    "lbryum_version": "3.1.4",
    "os_release": "10",
    "os_system": "Windows",
    "platform": "Windows-10-10.0.14393",
    "processor": "AMD64 Family 21 Model 1 Stepping 2, AuthenticAMD",
    "python_version": "2.7.13"
  }
}

LBRY Daemon version: 0.14.2
LBRY App version: 0.14.2
LBRY Installation ID: 4QzeH1PfDujXvAMqL3RWAyEaek1DB4GTvmBWdMJpgMQNLKZ1GfYR5SrRjqX1zrLctW
Operating system: Windows-10-10.0.14393

Anything Else
N/A
Screenshots

We are aware of this already, have a PR pending to fix it. Please check with us in slack.lbry.io before submitting an issue if you can! Thanks!


Update Elastix SuperBuild version

@N-Dekker I would think the referenced Elastix version should be updated before the next SimpleITK release to follow the ITK 5.4 release. Is there a recommended version? There does not appear to be a recent Elastix tag, is there expected to be one after the ITK 5.4 release?

Thanks for asking @blowekamp Our intention is indeed to make a new elastix tag + release, soon after the release of ITK 5.4


Qe work michael kolodner

Critical Changes
Added tabs for LookupParent and LookupChild, a QA app, flexipages for standard objects, and many other things to facilitate work within the UI for testers and QA volunteers. All changes should be only within the unpackaged QA directory and should not affect the actual deployable package.
Changes
Issues Closed

Some Notes:  I tried pushing your metadata to a scratch org and it did not deploy without errors. It looks like something is wrong with the flexipages (Record LP).

I made a commit to remove the package.xml, this needs to be defined in the sfdx-project.json file to correctly get pushed to a scratch org.

Screen Capture:


Fixes  broken examples

I updated the examples to ocaml 4.02 and core 0.11.
If I review correctly only the Ncurses example in the Foreign Interfaces chapter does not work, I know too little about the foreign interfaces to make it work.
For the async_graphics example in the chapter on classes, we need an updated async_graphics library. so I took https://github.com/drewsdunne/async_graphics and added an opam file, so we can pin to it : https://github.com/christophe-riolo/async_graphics

Examples not developped here anymore I guess.


add new metric, and update of dependencies and documentation.

Add go.mod/sum dependencie file to facilitate the build
Migrate log to go log (prometheus one are now deprecated)
Add globale metrics:

threads
readwaiters
opsinitiated
opscompleted
dtablesize
Add Documentation in the readme

for information the delta between "opsinitiated" and "opscompleted" are the number of actif thread vs "threads" value, and permit to see how the thread pool are used. if this delta reach "threads" the thread pool are full...


web service?

hpack-convert offers a simple REST interface from a hosted server... consider doing the same? This seems like a tool that many would be willing to try from a browser on their hackage package or a github repo, before committing to download and use it more.

That sounds weird to me, I don't understand why hpack-convert would do that. Clearly their users already have a Haskell environment, so installing the tool should be trivial. What is the gain? Is it simply faster to run it via the web service because you don't have to compile hpack and its dependencies first?
If that's the case, then doing the same for cabal-rangefinder would not make sense, because compiling your project with every possible version of its dependencies takes a lot longer than compiling cabal-rangefinder and its dependencies once.
Another reason why it makes less sense for cabal-rangefinder to do it is that cabal-rangefinder needs access to your source in order to compile it, it's not a pure source-to-source transformation like hpack-convert. So it would be more like a continuous-integration service.
Third, compiling all those versions takes a lot of CPU time, more than a continuous-integration system would, so I'm worried about the server costs. I do have a 5$/mo instance idling around though, and the Haskell community isn't that big, so maybe I should do some cost analysis before deciding that it would be too expensive.

For me personally, I didn't have time to install and figure pack-deps at work, but I did have a few minutes to browse the website (similar web vs local). I also often hesitate to disturb my local dev environment, so if I only have stack installed, I drag my feet on installing GHC and cabal globally.
I also often do not want to freeze up my machine, while I am doing other work or need to compile other projects.
What would also be awesome would be if this project could detect when it needs to rerun (in local mode or ci server mode), where it has a local DB file recording the most recent set of dependencies, and if a new dependency has been added.
I would limit the service to one or two concurrent users at a time (maybe save results, with a publicly visible history). If you actually hit problems with cost and load, that would be a great sign that people are adopting it.

What would also be awesome would be if this project could detect when it needs to rerun (in local mode or ci server mode), where it has a local DB file recording the most recent set of dependencies, and if a new dependency has been added.

That's too optimistic: even if you don't change your dependencies, other changes to the code could have an effect on which definitions from those dependencies you are using or with which types you are using them, which might only work with the latest version.

I am closing for now as I would not use the service at this time. I might be interested again at a later time.


Add support for eslint-plugin-ember

eslint-plugin-netguru-ember has been deprecated and superseded by eslint-plugin-ember. This PR does not remove eslint-plugin-netguru-ember, as some may still be using it in their projects.

Awesome, thanks @SaladFork!

Released in v1.0.5


chip.add event not fired on dynamic chip creation

Hi,
I am using custom ajax autocomplete to dynamically create chips and noticed that 'chip.add' event is not fired on chip creation. 'Select' and 'delete' events work as expected. I have made a simple test case, which is basically an input for chip tag text, a buton to add the chip and a div for chips. Expected behaviour is 'chip.add' event triggered on 'Add chip' buton click.
https://jsfiddle.net/gL52rb0k/21/
https://codepen.io/anon/pen/dzPGQp
IE 11.0.9600.18665
Chrome 59.0.3071.115

Cant' open your fiddle

jsfiddle is up again, at least for me. Added codepen as backup :)

@Smelkopski You're essentially reinitialising the chips control and thus overwriting the chip's data (and events).
There's certainly a kind of .add method missing to change the chips in code. You could raise the event with a click on the button manually, though.

@Smialkowski See if this helps
https://codepen.io/prabhuanirudh/pen/PObxrP
It is a slight modification of your code which does the job as expected.

@developeranirudhprabhu nope, no 'chip.add' alert for me. Does it work for you?

The chip.add event wont be triggered. I Just showed an alternative for same. I will check if v1 has added support for it.

This is fixed in v1-dev


validator.isPostalCode is not a function

Weird, I'm currently having the same issue

@chriso I didn't realize I was on such an old version. I updated to 9.4.1 and it fixed the issues I was having.


Helm error with forwarding ports

Hello,
I have new clear installation of K8s and then I installed Helm. If I try to install whatever (i.e. mysql) I get this error message:
Error: forwarding ports: error upgrading connection: unable to upgrade connection: pod does not exist
# kubectl -n kube-system get pods
NAME                             READY     STATUS    RESTARTS   AGE
etcd-master                      1/1       Running   2          3h
kube-apiserver-master            1/1       Running   3          3h
kube-controller-manager-master   1/1       Running   3          3h
kube-dns-3913472980-5wj0x        3/3       Running   6          3h
kube-proxy-tmh3k                 1/1       Running   2          3h
kube-proxy-vssfr                 1/1       Running   0          3h
kube-scheduler-master            1/1       Running   3          3h
tiller-deploy-1491950541-5crrg   1/1       Running   0          2h

Next I tried to set port-forwarding but I still get the same error:
# kubectl -n kube-system port-forward $(kubectl -n kube-system get pod -l app=helm -o jsonpath='{.items[0].metadata.name}') 44134
error: error upgrading connection: unable to upgrade connection: pod does not exist

K8s and Helm is running on Ubuntu (v16.04) in my VirtualBox. There I have 2 network interfaces. I'm not sure if problem should be there. My networks:

enp0s3 - NAT
enp0s8 - host only adapter (for connecting to Node01)

It is almost the same problem like issue 1770.

This is almost definitely a Kubernetes configuration issue. You might try asking in the #helm-users channel on Slack, if that's possible for you.

I'm going to close this ticket due to inactivity, but please re-open if this still needs to be addressed. Thanks!

me@mypad[k8s/kubeadm]% kubectl version
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.1", GitCommit:"d4ab47518836c750f9949b9e0d387f20fb92260b", GitTreeState:"clean", BuildDate:"2018-04-12T14:26:04Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.5", GitCommit:"32ac1c9073b132b8ba18aa830f46b77dcceb0723", GitTreeState:"clean", BuildDate:"2018-06-21T11:34:22Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
% helm list
Error: forwarding ports: error upgrading connection: unable to upgrade connection: pod does not exist
me@mypad[k8s/kubeadm]%

What is return when you type: kubectl --namespace kube-system get pod -o wide?

I'm also hitting this problem on a vagrant-installed, (based on centos/7 boxes) multi-node cluster.
> kubectl --namespace kube-system get pod -o wide
NAME                             READY     STATUS    RESTARTS   AGE       IP            NODE
coredns-78fcdf6894-cvwgc         1/1       Running   0          1d        <IP_ADDRESS>    master
coredns-78fcdf6894-vr9jw         1/1       Running   0          1d        <IP_ADDRESS>    master
etcd-master                      1/1       Running   0          1d        <IP_ADDRESS>     master
kube-apiserver-master            1/1       Running   0          1d        <IP_ADDRESS>     master
kube-controller-manager-master   1/1       Running   0          1d        <IP_ADDRESS>     master
kube-flannel-ds-kngs5            1/1       Running   0          1d        <IP_ADDRESS>     master
kube-flannel-ds-kr7cc            1/1       Running   0          23h       <IP_ADDRESS>     node2
kube-flannel-ds-n7rr6            1/1       Running   2          23h       <IP_ADDRESS>     node3
kube-flannel-ds-pkzmw            1/1       Running   0          23h       <IP_ADDRESS>     node1
kube-flannel-ds-prrh5            1/1       Running   0          23h       <IP_ADDRESS>     node4
kube-proxy-94tmj                 1/1       Running   0          23h       <IP_ADDRESS>     node3
kube-proxy-jqgfb                 1/1       Running   0          23h       <IP_ADDRESS>     node2
kube-proxy-kgm2r                 1/1       Running   0          1d        <IP_ADDRESS>     master
kube-proxy-s9jfd                 1/1       Running   0          23h       <IP_ADDRESS>     node1
kube-proxy-xgxdv                 1/1       Running   0          23h       <IP_ADDRESS>     node4
kube-scheduler-master            1/1       Running   0          1d        <IP_ADDRESS>     master
tiller-deploy-64c9d747bd-csphl   1/1       Running   0          8m        <IP_ADDRESS>   node3

The cluster seems to operate fine (I've been able to install/access services OK).
I installed tiller using helm init using the latest 2.10.0 binary.
I tried playing with the yaml definition from helm init --output yaml to see if I could "expose" the port somehow (replacing "tiller" by "44134" as targetPort for example) but without success (not really sure what I need to do).  The service section of that yaml looks like this:
---
apiVersion: v1
kind: Service
metadata:
  creationTimestamp: null
  labels:
    app: helm
    name: tiller
  name: tiller-deploy
  namespace: kube-system
spec:
  ports:
  - name: tiller
    port: 44134
    targetPort: tiller
  selector:
    app: helm
    name: tiller
  type: ClusterIP
status:
  loadBalancer: {}

Any ideas?

You can use kubectl port-forward to forward port 44134 locally, then use expose HELM_HOST=:44134 to interact with tiller that way.
Are there any errors you see when running helm list without that configuration though?

Hi Matthew,
Yeah unfortunately the "kubectl port-forward" command and also "helm list"
both produce
connection: pod does not exist```

whereas the "get pods" provided above shows that the tiller-deploy pod is
running.

On Mon, 17 Sep 2018 at 18:00, Matthew Fisher<EMAIL_ADDRESS>wrote:

> You can use kubectl port-forward to forward port 44134 locally, then use expose
> HELM_HOST=:44134 to interact with tiller that way.
>
> Are there any errors you see when running helm list without that
> configuration though?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/helm/helm/issues/2463#issuecomment-422071715>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABywLfVoN4lvVVkHpBNd3svuM-z53tCLks5ub8cJgaJpZM4Ne3PL>
> .
>

--

Cloud Native Training in English or French
-Kubernetes, Docker
-Serverless
-Micro-services
-Python, Git

Can you post the full output of the commands as well as the output of kubectl -n kube-system get pods for me?

OK, thanks for your time.
Does this give any clues?
Thx
 kubectl -n kube-system get pod -o wide
NAME                             READY     STATUS    RESTARTS   AGE
 IP            NODE
coredns-78fcdf6894-cvwgc         1/1       Running   0          1d
<IP_ADDRESS>    master
coredns-78fcdf6894-vr9jw         1/1       Running   0          1d
<IP_ADDRESS>    master
etcd-master                      1/1       Running   0          1d
<IP_ADDRESS>     master
kube-apiserver-master            1/1       Running   0          1d
<IP_ADDRESS>     master
kube-controller-manager-master   1/1       Running   0          1d
<IP_ADDRESS>     master
kube-flannel-ds-kngs5            1/1       Running   0          1d
<IP_ADDRESS>     master
kube-flannel-ds-kr7cc            1/1       Running   0          1d
<IP_ADDRESS>     node2
kube-flannel-ds-n7rr6            1/1       Running   2          1d
<IP_ADDRESS>     node3
kube-flannel-ds-pkzmw            1/1       Running   0          1d
<IP_ADDRESS>     node1
kube-flannel-ds-prrh5            1/1       Running   0          1d
<IP_ADDRESS>     node4
kube-proxy-94tmj                 1/1       Running   0          1d
<IP_ADDRESS>     node3
kube-proxy-jqgfb                 1/1       Running   0          1d
<IP_ADDRESS>     node2
kube-proxy-kgm2r                 1/1       Running   0          1d
<IP_ADDRESS>     master
kube-proxy-s9jfd                 1/1       Running   0          1d
<IP_ADDRESS>     node1
kube-proxy-xgxdv                 1/1       Running   0          1d
<IP_ADDRESS>     node4
kube-scheduler-master            1/1       Running   0          1d
<IP_ADDRESS>     master
tiller-deploy-64c9d747bd-csphl   1/1       Running   0          1h
<IP_ADDRESS>   node3

> kubectl -n kube-system port-forward $(kubectl -n kube-system get pod -l
app=helm -o jsonpath='{.items[0].metadata.name}') 44134
error: error upgrading connection: unable to upgrade connection: pod does
not exist

> kubectl --v 8 -n kube-system port-forward $(kubectl -n kube-system get
pod -l app=helm -o jsonpath='{.items[0].metadata.name}') 44134
I0917 18:58:14.464676    8008 loader.go:357] Config loaded from file
/home/mjb/.kube/config
I0917 18:58:14.470440    8008 round_trippers.go:383] GET
https://<IP_ADDRESS>:6443/api/v1/namespaces/kube-system/pods/tiller-deploy-64c9d747bd-csphl
I0917 18:58:14.470466    8008 round_trippers.go:390] Request Headers:
I0917 18:58:14.470473    8008 round_trippers.go:393]     Accept:
application/json, */*
I0917 18:58:14.470479    8008 round_trippers.go:393]     User-Agent:
kubectl/v1.10.1 (linux/amd64) kubernetes/d4ab475
I0917 18:58:14.482079    8008 round_trippers.go:408] Response Status: 200
OK in 11 milliseconds
I0917 18:58:14.482131    8008 round_trippers.go:411] Response Headers:
I0917 18:58:14.482148    8008 round_trippers.go:414]     Date: Mon, 17 Sep
2018 16:58:14 GMT
I0917 18:58:14.482157    8008 round_trippers.go:414]     Content-Type:
application/json
I0917 18:58:14.482162    8008 round_trippers.go:414]     Content-Length:
3065
I0917 18:58:14.482249    8008 request.go:874] Response Body:
{"kind":"Pod","apiVersion":"v1","metadata":{"name":"tiller-deploy-64c9d747bd-csphl","generateName":"tiller-deploy-64c9d747bd-","namespace":"kube-system","selfLink":"/api/v1/namespaces/kube-system/pods/tiller-deploy-64c9d747bd-csphl","uid":"2fb8d68a-ba8e-11e8-a1be-525400c9c704","resourceVersion":"140256","creationTimestamp":"2018-09-17T15:27:28Z","labels":{"app":"helm","name":"tiller","pod-template-hash":"2075830368"},"ownerReferences":[{"apiVersion":"apps/v1","kind":"ReplicaSet","name":"tiller-deploy-64c9d747bd","uid":"2fb5973d-ba8e-11e8-a1be-525400c9c704","controller":true,"blockOwnerDeletion":true}]},"spec":{"volumes":[{"name":"default-token-nzmpw","secret":{"secretName":"default-token-nzmpw","defaultMode":420}}],"containers":[{"name":"tiller","image":"
gcr.io/kubernetes-helm/tiller:v2.10.0","ports":[{"name":"tiller","containerPort":44134,"protocol":"TCP"},{"name":"http","containerPort":44135,"protocol":"TCP"}],"env":[{"name":"TILLER_NAMESPACE","value":"kube-system"},{"name":"TILLER_HISTORY_MAX","value":"0"}
[truncated 2041 chars]
I0917 18:58:14.531377    8008 round_trippers.go:383] GET
https://<IP_ADDRESS>:6443/api/v1/namespaces/kube-system/pods/tiller-deploy-64c9d747bd-csphl
I0917 18:58:14.531413    8008 round_trippers.go:390] Request Headers:
I0917 18:58:14.531421    8008 round_trippers.go:393]     Accept:
application/json, */*
I0917 18:58:14.531427    8008 round_trippers.go:393]     User-Agent:
kubectl/v1.10.1 (linux/amd64) kubernetes/d4ab475
I0917 18:58:14.534341    8008 round_trippers.go:408] Response Status: 200
OK in 2 milliseconds
I0917 18:58:14.534370    8008 round_trippers.go:411] Response Headers:
I0917 18:58:14.534385    8008 round_trippers.go:414]     Content-Type:
application/json
I0917 18:58:14.534394    8008 round_trippers.go:414]     Content-Length:
3065
I0917 18:58:14.534401    8008 round_trippers.go:414]     Date: Mon, 17 Sep
2018 16:58:14 GMT
I0917 18:58:14.534502    8008 request.go:874] Response Body:
{"kind":"Pod","apiVersion":"v1","metadata":{"name":"tiller-deploy-64c9d747bd-csphl","generateName":"tiller-deploy-64c9d747bd-","namespace":"kube-system","selfLink":"/api/v1/namespaces/kube-system/pods/tiller-deploy-64c9d747bd-csphl","uid":"2fb8d68a-ba8e-11e8-a1be-525400c9c704","resourceVersion":"140256","creationTimestamp":"2018-09-17T15:27:28Z","labels":{"app":"helm","name":"tiller","pod-template-hash":"2075830368"},"ownerReferences":[{"apiVersion":"apps/v1","kind":"ReplicaSet","name":"tiller-deploy-64c9d747bd","uid":"2fb5973d-ba8e-11e8-a1be-525400c9c704","controller":true,"blockOwnerDeletion":true}]},"spec":{"volumes":[{"name":"default-token-nzmpw","secret":{"secretName":"default-token-nzmpw","defaultMode":420}}],"containers":[{"name":"tiller","image":"
gcr.io/kubernetes-helm/tiller:v2.10.0","ports":[{"name":"tiller","containerPort":44134,"protocol":"TCP"},{"name":"http","containerPort":44135,"protocol":"TCP"}],"env":[{"name":"TILLER_NAMESPACE","value":"kube-system"},{"name":"TILLER_HISTORY_MAX","value":"0"}
[truncated 2041 chars]
I0917 18:58:14.535481    8008 round_trippers.go:383] POST
https://<IP_ADDRESS>:6443/api/v1/namespaces/kube-system/pods/tiller-deploy-64c9d747bd-csphl/portforward
I0917 18:58:14.535526    8008 round_trippers.go:390] Request Headers:
I0917 18:58:14.535540    8008 round_trippers.go:393]
 X-Stream-Protocol-Version: portforward.k8s.io
I0917 18:58:14.535554    8008 round_trippers.go:393]     User-Agent:
kubectl/v1.10.1 (linux/amd64) kubernetes/d4ab475
I0917 18:58:14.558269    8008 round_trippers.go:408] Response Status: 404
Not Found in 22 milliseconds
I0917 18:58:14.558304    8008 round_trippers.go:411] Response Headers:
I0917 18:58:14.558321    8008 round_trippers.go:414]     Date: Mon, 17 Sep
2018 16:58:14 GMT
I0917 18:58:14.558327    8008 round_trippers.go:414]     Content-Length: 18
I0917 18:58:14.558332    8008 round_trippers.go:414]     Content-Type:
text/plain; charset=utf-8
F0917 18:58:14.558474    8008 helpers.go:119] error: error upgrading
connection: unable to upgrade connection: pod does not exist

On Mon, 17 Sep 2018 at 18:33, Matthew Fisher<EMAIL_ADDRESS>wrote:

Can you post the full output of the commands as well as the output of kubectl
-n kube-system get pods for me?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/helm/helm/issues/2463#issuecomment-422083659, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABywLSYCdUrr4lkOa3PgxSlvUdi_Nx-Wks5ub87igaJpZM4Ne3PL
.

--
Cloud Native Training in English or French
-Kubernetes, Docker
-Serverless
-Micro-services
-Python, Git

Did anyone found a solution to this

Exactly same issue as @mjbright mentioned, here.

More details about my environment:
kubectl get pods --all-namespaces
NAMESPACE     NAME                              READY   STATUS    RESTARTS   AGE
kube-system   coredns-fb8b8dccf-s2qkz           1/1     Running   11         111m
kube-system   coredns-fb8b8dccf-vlslg           1/1     Running   9          111m
kube-system   etcd-master1                      1/1     Running   6          110m
kube-system   kube-apiserver-master1            1/1     Running   6          110m
kube-system   kube-controller-manager-master1   1/1     Running   6          110m
kube-system   kube-flannel-ds-amd64-gjrgl       1/1     Running   6          108m
kube-system   kube-flannel-ds-amd64-k9gz9       1/1     Running   6          108m
kube-system   kube-flannel-ds-amd64-skcht       1/1     Running   6          108m
kube-system   kube-proxy-ctx9x                  1/1     Running   6          111m
kube-system   kube-proxy-wnmzv                  1/1     Running   6          111m
kube-system   kube-proxy-zvwfd                  1/1     Running   6          111m
kube-system   kube-scheduler-master1            1/1     Running   6          110m
kube-system   tiller-deploy-8458f6c667-s4hv9    1/1     Running   0          6m45s

kubectl get services --all-namespaces
NAMESPACE     NAME            TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)                  AGE
default       kubernetes      ClusterIP   <IP_ADDRESS>      <none>        443/TCP                  111m
kube-system   kube-dns        ClusterIP   <IP_ADDRESS>     <none>        53/UDP,53/TCP,9153/TCP   111m
kube-system   tiller-deploy   ClusterIP   <IP_ADDRESS>   <none>        44134/TCP                107m

kubectl describe pod -n kube-system tiller-deploy
Name:               tiller-deploy-8458f6c667-s4hv9
Namespace:          kube-system
Priority:           0
PriorityClassName:  <none>
Node:               node2/<IP_ADDRESS>
Start Time:         Thu, 11 Apr 2019 13:36:28 -0300
Labels:             app=helm
                    name=tiller
                    pod-template-hash=8458f6c667
Annotations:        <none>
Status:             Running
IP:                 <IP_ADDRESS>
Controlled By:      ReplicaSet/tiller-deploy-8458f6c667
Containers:
  tiller:
    Container ID:   docker://aac77761a0f278a4a89f03a266961e45b191144172224827fc0a13885aeb71db
    Image:          gcr.io/kubernetes-helm/tiller:v2.13.1
    Image ID:       docker-pullable://gcr.io/kubernetes-helm/tiller@sha256:d52b34a9f9aeec1cf74155ca51fcbb5d872a705914565c782be4531790a4ee0e
    Ports:          44134/TCP, 44135/TCP
    Host Ports:     0/TCP, 0/TCP
    State:          Running
      Started:      Thu, 11 Apr 2019 13:36:29 -0300
    Ready:          True
    Restart Count:  0
    Liveness:       http-get http://:44135/liveness delay=1s timeout=1s period=10s #success=1 #failure=3
    Readiness:      http-get http://:44135/readiness delay=1s timeout=1s period=10s #success=1 #failure=3
    Environment:
      TILLER_NAMESPACE:    kube-system
      TILLER_HISTORY_MAX:  0
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from tiller-token-9f299 (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             True
  ContainersReady   True
  PodScheduled      True
Volumes:
  tiller-token-9f299:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  tiller-token-9f299
    Optional:    false
QoS Class:       BestEffort
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type    Reason     Age    From               Message
  ----    ------     ----   ----               -------
  Normal  Scheduled  8m13s  default-scheduler  Successfully assigned kube-system/tiller-deploy-8458f6c667-s4hv9 to node2
  Normal  Pulled     8m12s  kubelet, node2     Container image "gcr.io/kubernetes-helm/tiller:v2.13.1" already present on machine
  Normal  Created    8m12s  kubelet, node2     Created container tiller
  Normal  Started    8m12s  kubelet, node2     Started container tiller

More details about my environment:
kubectl get pods --all-namespaces
NAMESPACE     NAME                              READY   STATUS    RESTARTS   AGE
kube-system   coredns-fb8b8dccf-s2qkz           1/1     Running   11         111m
kube-system   coredns-fb8b8dccf-vlslg           1/1     Running   9          111m
kube-system   etcd-master1                      1/1     Running   6          110m
kube-system   kube-apiserver-master1            1/1     Running   6          110m
kube-system   kube-controller-manager-master1   1/1     Running   6          110m
kube-system   kube-flannel-ds-amd64-gjrgl       1/1     Running   6          108m
kube-system   kube-flannel-ds-amd64-k9gz9       1/1     Running   6          108m
kube-system   kube-flannel-ds-amd64-skcht       1/1     Running   6          108m
kube-system   kube-proxy-ctx9x                  1/1     Running   6          111m
kube-system   kube-proxy-wnmzv                  1/1     Running   6          111m
kube-system   kube-proxy-zvwfd                  1/1     Running   6          111m
kube-system   kube-scheduler-master1            1/1     Running   6          110m
kube-system   tiller-deploy-8458f6c667-s4hv9    1/1     Running   0          6m45s

kubectl get services --all-namespaces
NAMESPACE     NAME            TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)                  AGE
default       kubernetes      ClusterIP   <IP_ADDRESS>      <none>        443/TCP                  111m
kube-system   kube-dns        ClusterIP   <IP_ADDRESS>     <none>        53/UDP,53/TCP,9153/TCP   111m
kube-system   tiller-deploy   ClusterIP   <IP_ADDRESS>   <none>        44134/TCP                107m

kubectl describe pod -n kube-system tiller-deploy
Name:               tiller-deploy-8458f6c667-s4hv9
Namespace:          kube-system
Priority:           0
PriorityClassName:  <none>
Node:               node2/<IP_ADDRESS>
Start Time:         Thu, 11 Apr 2019 13:36:28 -0300
Labels:             app=helm
                    name=tiller
                    pod-template-hash=8458f6c667
Annotations:        <none>
Status:             Running
IP:                 <IP_ADDRESS>
Controlled By:      ReplicaSet/tiller-deploy-8458f6c667
Containers:
  tiller:
    Container ID:   docker://aac77761a0f278a4a89f03a266961e45b191144172224827fc0a13885aeb71db
    Image:          gcr.io/kubernetes-helm/tiller:v2.13.1
    Image ID:       docker-pullable://gcr.io/kubernetes-helm/tiller@sha256:d52b34a9f9aeec1cf74155ca51fcbb5d872a705914565c782be4531790a4ee0e
    Ports:          44134/TCP, 44135/TCP
    Host Ports:     0/TCP, 0/TCP
    State:          Running
      Started:      Thu, 11 Apr 2019 13:36:29 -0300
    Ready:          True
    Restart Count:  0
    Liveness:       http-get http://:44135/liveness delay=1s timeout=1s period=10s #success=1 #failure=3
    Readiness:      http-get http://:44135/readiness delay=1s timeout=1s period=10s #success=1 #failure=3
    Environment:
      TILLER_NAMESPACE:    kube-system
      TILLER_HISTORY_MAX:  0
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from tiller-token-9f299 (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             True
  ContainersReady   True
  PodScheduled      True
Volumes:
  tiller-token-9f299:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  tiller-token-9f299
    Optional:    false
QoS Class:       BestEffort
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type    Reason     Age    From               Message
  ----    ------     ----   ----               -------
  Normal  Scheduled  8m13s  default-scheduler  Successfully assigned kube-system/tiller-deploy-8458f6c667-s4hv9 to node2
  Normal  Pulled     8m12s  kubelet, node2     Container image "gcr.io/kubernetes-helm/tiller:v2.13.1" already present on machine
  Normal  Created    8m12s  kubelet, node2     Created container tiller
  Normal  Started    8m12s  kubelet, node2     Started container tiller

I'm having exactly the same problem. Any solution?
When I do the following request:
GET https://<IP_ADDRESS>:6443/api/v1/namespaces/kube-system/pods/tiller-deploy-59988697b6-j47w7/portforward
I get the following response:
{
  "kind": "Status",
  "apiVersion": "v1",
  "metadata": {},
  "status": "Failure",
  "message": "Upgrade request required",
  "reason": "BadRequest",
  "code": 400
}

which ultimately results in my original command  kubectl -n kube-system port-forward $(kubectl -n kube-system get pod -l app=helm -o jsonpath='{.items[0].metadata.name}') 44134 producing this error :
error: error upgrading connection: unable to upgrade connection: pod does not exist

I had a similar issue when I was trying to install helm to my k8s cluster.
I am running a K8S cluster on my Mac with 3 Virtualbox nodes (k8s-head, k8s-node-1, k8s-node-2).
I have configured kubectl on my Macbook to use that cluster (k8s API is targeting k8s-head node IP). Then I tried to install helm but it failed on helm init command. The reason was b/c of this issue:  https://github.com/helm/helm/issues/6374, so I used a workaround to deploy tiller manually.
After deploy, when I tried to run helm version command again I have got the error with port forwarding mentioned in this issue.
What I have figured out that helm init is generating service configuration:
apiVersion: v1
kind: Service
metadata:
  name: tiller-deploy
  namespace: kube-system
  labels:
    app: helm
    name: tiller
spec:
  selector:
    app: helm
    name: tiller
    type: ClusterIP
  ports:
  - name: tiller
    port: 44134
    targetPort: tiller
status:
  loadBalancer: {}

I have looked at type: ClusterIP  and decided to try to apply this manifest not from my Macbook but from the cluster master node: k8s-head (ssh to it)
After applying the manifest at master node, I have logged off and now when I run tiller version command on my mac - I have got it working:
main] 2019/09/21 18:18:03 Starting Tiller v2.14.3 (tls=false)
[main] 2019/09/21 18:18:03 GRPC listening on :44134
[main] 2019/09/21 18:18:03 Probes listening on :44135
[main] 2019/09/21 18:18:03 Storage driver is ConfigMap
[main] 2019/09/21 18:18:03 Max history per release is 0

I'm having exactly the same problem. Any solution?
When I do the following request:
GET https://<IP_ADDRESS>:6443/api/v1/namespaces/kube-system/pods/tiller-deploy-59988697b6-j47w7/portforward
I get the following response:
{
  "kind": "Status",
  "apiVersion": "v1",
  "metadata": {},
  "status": "Failure",
  "message": "Upgrade request required",
  "reason": "BadRequest",
  "code": 400
}

which ultimately results in my original command  kubectl -n kube-system port-forward $(kubectl -n kube-system get pod -l app=helm -o jsonpath='{.items[0].metadata.name}') 44134 producing this error :
error: error upgrading connection: unable to upgrade connection: pod does not exist

I have exactly this. Did you find out how to fix it? Was it an issue with DNS resolving from within the cluster?

Same issue here:
$ kubectl -n kube-system get service,pods
NAME                    TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)         AGE
service/kube-dns        ClusterIP   <IP_ADDRESS>    <none>        53/UDP,53/TCP   15m
service/tiller-deploy   ClusterIP   <IP_ADDRESS>   <none>        44134/TCP       97s

NAME                                      READY   STATUS    RESTARTS   AGE
pod/aws-node-lfq7l                        1/1     Running   0          8m59s
pod/cluster-autoscaler-5b598f5878-xghtk   1/1     Running   0          8m23s
pod/coredns-77f96c54b6-mfk28              1/1     Running   0          15m
pod/coredns-77f96c54b6-p5nql              1/1     Running   0          15m
pod/kube-proxy-9hbw8                      1/1     Running   0          8m59s
pod/tiller-deploy-78c7d76d4b-d6cql        1/1     Running   0          76s

$ helm version
Client: &version.Version{SemVer:"v2.16.0", GitCommit:"e13bc94621d4ef666270cfbe734aaabf342a49bb", GitTreeState:"clean"}
Error: forwarding ports: error upgrading connection: no preferred addresses found; known addresses: []

Not exactly sure why this was closed without solution as people are still running into it both here and at #1770 (also closed without solution).

I was able to resolve this by restarting the node where tiller was installed and then initializing again.
$ helm init --service-account tiller --wait
$HELM_HOME has been configured at C:\Users\arontx\home\.helm.
Warning: Tiller is already installed in the cluster.
(Use --client-only to suppress this message, or --upgrade to upgrade Tiller to the current version.)

$ helm version
Client: &version.Version{SemVer:"v2.16.0", GitCommit:"e13bc94621d4ef666270cfbe734aaabf342a49bb", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.16.0", GitCommit:"e13bc94621d4ef666270cfbe734aaabf342a49bb", GitTreeState:"clean"}

In all cases that we know of, the problem is related to Kubernetes itself, not Helm or Tiller. That is why we have been closing these out. The answer I gave over two years ago still applies: Your best bet is to go investigate Kubernetes.
AFAIK, there is no single solution to the problem on the Kubernetes side. I have seen it happen due to control plane misconfiguration, API server issues, node issues, DNS issues, and overly aggressive timeouts. If there were only one cause/solution, we could simply document it. But in this case, there's not much we can do but say "go look at Kubernetes"
In other issues, we'e suggested starting out with tests against kubectl attach/proxy/port-forward. That advice still holds true. If those commands don't work, Helm won't work either.
If anyone feels like updating the V2 FAQ, there is already a fairly generic section about proxy failures. https://github.com/helm/helm/blob/dev-v2/docs/install_faq.md This could augment that.

Thank you for the detailed response! I started looking at kubernetes based on responses to the other issues that were raised. I believe my issue was with the kubelet not having contact with the cluster. I have seen this before when setting up new clusters and a restart of the node seems to resolve it. I updated my comment to reflect what worked for me, hopefully it will help others in the future!


Added missing whitespace between words, fixed spelling and grammar, etc

Changes fall into these four categories (with examples):

whitespace: FALSEif ---> FALSE if
spelling: meatfile ---> metafile
grammar: saves it's state ---> saves its state
etc: FALSE ---> FALSE

Do I need to do something about the conflicting files?

Wow! This is a lot of work! Thank you! :-)
Unfortunately, because so many files are being impacted we can't do a simple merge, and instead will have to go through and check each fix.
In other words, it'll take a while for this fix to be accepted. In the future - and I hate complaining after all the work you've done - it would be a lot easier if you could limit PRs to just a few files at a time.
Thank you!
-John

Thanks for taking the time to make these corrections!
Please keep PRs small as we cannot easily accept all these changes in one go. Someone is currently working through them all. Please don't add any more to this PR, but start another. Thanks!
-John

Hi, @GrantMeStrength / John,
I corrected the few small errors that I found in the files. I don't have perms to resolve the file conflicts or to merge the PR - can you please finish up?
Thanks!

checked in via https://github.com/MicrosoftDocs/sdk-api/pull/859


[sw] Key Manager Configuration Changes for Sealing and Attestation

This issue describes the key manager configuration changes required to integrate the new key manager sealing and attestation derivation flows in alignment with the Open Profile for DICE Specification.
The proposed changes will be incorporated in relevant security specifications and in the ROM and ROM_EXT implementation.
DICE Terminology

Unique Device Secret (UDS): per-device hardware-level secret only accessible to the DICE compliant function.
Compound Device Identifier (CDI): Represents the hardware/software configuration measured by DICE.

Attestation CDI (CDI_attestation): Used to attest the hardware and software configuration. It is expected to change between software or configuration updates.
Sealing CDI (CDI_sealing): Derived from the UDS and stable device configuration values. This CDI is appropriate for sealing use cases requiring a stable key derivation function.

DICE to key manager state mapping
The key manager is advanced during the secure boot sequence to derive the following key manager internal states. There are two CDI levels available (CDI0 and CDI1), which gives the Silicon Owner the ability to implement sealing and attestation policies for the OWNER code managed by the BL0 partition.
Note that the key manager internal state is never exposed to software. Software can only use derived outputs from the internal state, either directly or sideloaded into one of the cryptographic accelerators.

DICE
Key Manager Internal Sate
Availability

UDS
CreatorRootKey
ROM_EXT

CDI0
OwnerIntermediateKey
ROM_EXT, BL0

CDI1
OwnerKey
BL0, OWNER (e.g. kernel)

Key Manager configuration
The proposed changes provide the following properties:
ROM_EXT_UPDATABLE
The Silicon Owner is allowed to push ROM_EXT updates to the device without changing the UDS. A stable UDS allows any Silicon Owner to attest the device against the UDS Silicon Creator endorsement certificate, which is specially useful during device ingestion, and ownership transfer.
The Silicon Creator may opt to force a UDS internal state change as part of the ROM_EXT update by changing the ROM_EXT manifest binding_value field. This process renders te UDS Silicon Creator endorsement certificate invalid.
ROM_EXT_OBSERVABLE_UPDATES
ROM_EXT updates force the CDI0 to change, allowing the Silicon Owner to measure the software configuration changes as part of device attestation.
The ROM_EXT must be verifiable out-of-band by the Silicon Owner. This means that the Silicon Owner must be able to compile the ROM_EXT from source and reproduce the expected hash of the build result. This gives the Silicon Owner a strong guarantee that the measured code during device attestation corresponds to the audited ROM_EXT version.
STABLE_CDI_SEALING
All key manager CDI sealing derivations implement the following properties as described in the identities and root keys specification:

software binding: Software binding is used to ensure that the key derivation scheme is only reproducible for a trusted software configuration. This is achieved by having the secure boot implementation configure runtime-irrevocable binding tags in the key derivation scheme. Such tags are delivered inside the signed manifest of each boot partition.
key versioning: Key versioning is the mechanism by which software implements key rotation triggered by security updates. Since there is more than one updatable code partition in the system, the key versioning scheme implements at least 4 32b version comparators with lockable controls, which are configured as part of the secure boot process.

Secure boot updates
ROM
The ROM configures the key manager to provide additional inputs to the derivation of the CreatorRootKey internal state. The CreatorRootKey is used to derive UDS.

ATTEST_SW_BINDING_{0-7}: ROM_EXT manifest binding_value.
SEALING_SW_BINDING_{0-7}: ROM_EXT manifest binding_value.

ROM_EXT
The ROM_EXT configures the key manager to provide additional inputs to the derivation of the OwnerIntermedateKey internal state. The OwnerIntermedateKey is used to derive CDI0.
The following measurements are required at this boot stage:

ROM_EXT_CODE_HASH: SHA2-256 of the ROM_EXT code partition excluding the manifest signature field.
BLO_CODE_HASH: SHA2-256 of the BL0 code partition excluding the manifest signature field.

Configure the key manager software binding registers as follows:

ATTEST_SW_BINDING_{0-7}: SHA2-256(ROM_EXT_CODE_HASH | BL0_CODE_HASH)   where | is the concatenation
operator.
SEALING_SW_BINDING_{0-7}: BL0 manifest binding_value.

BL0
BL0 configures the key manager to provide additional inputs to the derivation of the OwnerKey internal state. The OwnerKey is used to derive CDI1.
The following measurements are required at this boot stage:

OWNER_CODE_HASH: SHA2-256 of the next OWNER code partition excluding the manifest signature field.

Configure the key manager software binding registers as follows:

ATTEST_SW_BINDING_{0-7}: OWNER_CODE_HASH value.
SEALING_SW_BINDING_{0-7}: OWNER manifest binding_value.

CC: @mcy @cfrantz @alphan @drewmacrae @tjaychen

looks good to me! @weicaiyang i guess one important thing we'll need to do is to ensure the binding value is actually propagating to all the advanced calls correctly.

looks good to me! @weicaiyang i guess one important thing we'll need to do in testing is to ensure the binding value is actually propagating to all the advanced calls correctly.

Yes, we have that check in the scb.

@moidx can this issue be closed? It looks like https://github.com/lowRISC/opentitan/pull/13149 fixed this.

I think so. Let's close. I still have to update the documentation, but this issue can be used as a reference for now.

CC @johannheyszl  since this has some documentation related to attestation.

cc @gdessouky


Support certificates with no CN in the Subject

Description of the changes
Support certificates with no Common Name (CN) in the Subject.
Caveats
Assumes a Organisation Name exists in the certificate's Subject.
Checklist
Please go over this checklist to increase the chances of your PR being worked on in a timely manner. Deviations are allowed with proper justification (see previous section).

[x] I have read the project's CoC and contribution guidelines.
[x] I understand and agree to the terms in the Developer Certificate of Origin as applied to this contribution.
[ ] All new code in this PR has full test coverage.

For bug fixes

[x] My changes do not affect any public API or CLI semantics.
[ ] My PR adds regression tests (i.e. tests that fail if the bug fix is not applied).
[ ] All new code in this PR has full test coverage.

I fixed the issue with the breaking change in python-barcode (see a1e4251) and took the liberty to rebase your branch so the workflows can run to completion.

Thank's for the feedback @MatthiasValvekens. Would you prefer the test in test_signing.py or test_cms.py or elsewhere?

Good question. Since the property you changed is only used in PDF signing code and doesn't affect the actual CMS generated, test_signing.py would probably be better. Thanks!

Oh, one somewhat important thing that I forgot to mention: that property is actually only used to generate the signature's visual appearance. That means that you need to be careful in a couple places to avoid making the process of reading back the appearance content overly complex:

Don't mess around with fonts, and ensure the text in the O field of the name is (essentially) latin1-compatible. Using OpenType fonts would require a lot more work to recover the data; pyHanko doesn't include any tools for performing text extraction.
Work with a template file that already includes a single prepared visual signature field (e.g. MINIMAL_ONE_FIELD) and don't set the field name in PdfSignatureMetadata. That should make pyHanko detect & use the prepared field automatically.
When rereading the PDF content, you should be able to find the appearance data using ap_content = r.root['/AcroForm']['/Fields'][0]['/AP']['/N'].data, assuming that your PdfFileReader is named r.

Once you have all that, and assuming the O field in the subject name is "Acme Corp", you can simply test for b"Acme Corp" in ap_content.

Thanks again for the feedback. I do plan on updating this pull request but I haven't had much time recently to dedicate to it. Should hopefully be sometime next week.

Reopening this, I still care :). I'll take care of the regression test.

Codecov Report

Merging #101 (d92ed03) into master (4263309) will increase coverage by 0.10%.
The diff coverage is 50.00%.

:exclamation: Current head d92ed03 differs from pull request most recent head 8d7bfda. Consider uploading reports for the commit 8d7bfda to get more accurate results

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   98.66%   98.77%   +0.10%
==========================================
  Files          73       73
  Lines       10821    11649     +828
==========================================
+ Hits        10677    11506     +829
+ Misses        144      143       -1

Flag
Coverage Δ

unittests
98.77% <50.00%> (+0.10%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pyhanko/sign/signers/pdf_cms.py
99.37% <50.00%> (-0.63%)
:arrow_down:

pyhanko/pdf_utils/qr.py
100.00% <0.00%> (ø)

pyhanko/sign/signers/pdf_signer.py
100.00% <0.00%> (ø)

pyhanko/sign/signers/cms_embedder.py
100.00% <0.00%> (ø)

pyhanko/pdf_utils/writer.py
97.19% <0.00%> (+0.09%)
:arrow_up:

pyhanko/sign/fields.py
99.40% <0.00%> (+0.13%)
:arrow_up:

pyhanko/stamp.py
98.99% <0.00%> (+0.37%)
:arrow_up:

pyhanko/pdf_utils/reader.py
96.88% <0.00%> (+1.43%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4263309...8d7bfda. Read the comment docs.