Alumni and reviews

Feature
Why is this feature being added?
We previously discussed adding alumni to the code schools page and ability for them to add code school reviews. Searched here and didn't see a previous ticket.
What should your feature do?
This will enable new members to quickly and seamlessly find (and query) members and others in the community, and make more informed decisions on reviews and their experience.

Just to clarify for any #hacktoberfest participants: This issue is blocked by the pertinent need for a wireframe. Show us how you'd implement this on our most visited page.

Do you just want a wireframe of how the page would look? Can I get some clarification on the most visited page?

@Kdasay16 https://operationcode.org/code_schools <-- our most visited page
Unfortunately, this task is blocked because our API is down.
I'd like to see the review system integrated with the Code School cards component. I'll ping you when content is displaying once more.

@Kdasay16 our API is back up.

@JennWeideman no - we'll definitely want a good wireframe on this. The Code School Card is arguably our most important component at this point in time.

Putting this on hold until we get the the code schools sorted out.

Documented: https://github.com/OperationCode/front-end/issues/176


Add support for compose file version 3

@Page- @pdcastro do you know why we have circle ci in here? those jobs seem to do the same npm install + build as our CI

@robertgzr I don't think balena CI existed when this repository was last updated. It would be great if you could spend the time to move it over our CI (and maybe also rename the repo? :)

@balena-ci rebase

let's go with #59 for now and see if we need to revive this effort at some later point


#include <lua.h> vs #include "lua.h"

Should C modules use #include <lua.h> or #include "lua.h"?
LUA_INCDIR seems to exist to enable the latter.

If your module brings its own lua.h, then it's easier to use the latter. Otherwise it doesn't matter. LUA_INCDIR is needed for both if Lua's header files are installed in a non-standard location (or if you have multiple Lua installations in standard locations).

If your module brings its own lua.h, then it's easier to use the latter.

Why would a lua module ever bring it's own lua.h?

Otherwise it doesn't matter. LUA_INCDIR is needed for both if Lua's header files are installed in a non-standard location (or if you have multiple Lua installations in standard locations).

Actually I had an issue where my LUA_INCDIR was /usr/include, but I didn't want to include the /usr/include directory for other reasons..... from there I started wondering.

Why would a lua module ever bring it's own lua.h?

I maintain two rocks that bundle some of Lua's source and header files (not lua.h, though):
https://github.com/siffiejoe/lua-getsize
https://github.com/siffiejoe/lua-lbci

Actually I had an issue where my LUA_INCDIR was /usr/include, but I didn't want to include the /usr/include directory for other reasons..... from there I started wondering.

Why? Somehow the compiler needs to find the Lua include files, and /usr/include probably is in your compiler's default search path anyway.

Why? Somehow the compiler needs to find the Lua include files, and /usr/include probably is in your compiler's default search path anyway.

I was messing with musl. It has it's own system headers in /usr/lib/musl/include

So you basically need a way to put additional include directories before the Lua include directory?! Right now that's not possible with the builtin build mode, but of course easy with the make based build mode.

       -Idir
           Add the directory dir to the head of the list of directories to be
           searched for header files.  This can be used to override a system
           header file, substituting your own version, since these directories
           are searched before the system header file directories.  However,
           you should not use this option to add directories that contain
           vendor-supplied system header files (use -isystem for that).  If
           you use more than one -I option, the directories are scanned in
           left-to-right order; the standard system directories come after.

If -I/usr/include causes problems for you just set LUA_INCDIR to something else.

that was only what caused me to investigate.
The actual issue I asked here was whether lua C modules should prefer <lua.h> or "lua.h". I'd like to be consistent across my modules (and have something to refer to when sending pull requests etc).

In any case, this is not a LuaRocks bug, so the issue tracker is not the right place for this discussion. Try lua-l maybe?


Need "wheel of fortune" widget

 Issue by eseidelGoogle
Friday Aug 21, 2015 at 22:36 GMT
Originally opened as https://github.com/flutter/engine/issues/759

I don't see anything like it in the material design spec.  However one of our customers needs a widget which functions a bit like a TabBar and a bit like a PageableList.
Shows paged items which can be scrolled through while you have your finger down.   Once you release your finger it snaps to the middle of the closest item.  This can be used for selecting between colors, or times or letters in the alphabet.  Horizontal is the primary use case, but presumably it could also be used vertically as well.
I need to know the scroll offsets (or at least corresponding items) as they change.
@HansMuller said he'd be willing to take this on.

 Comment by eseidelGoogle
Friday Aug 21, 2015 at 22:38 GMT

Colors snap on the border of the colors and draw a block of color in the region of the time.  Times draw times at the edges of the times (centered on the edge) and snap at those (non-visible) edges.  Alphabet draws letters in the middle of the items and snaps at a non-visible edge.

I think we can close this now.  The widgets we built seem sufficient.


Failure compiler should generate Javadocs

Now generated Java code for descendants of FailureThrowable only have
@javax.annotation.Generated("by Spine compiler")

We need to have Javadoc class header, which repeats the text from a comment of corresponding failure definition from failures.proto.
We also need to have Javadoc for the constructor with the description of the parameters taken from fields of a failure definition.

Implemented in #59.


Option to Disable Info Window on Pin Selection

SUMMARY
I have a project that deals with selected pins on a specific UI the pops in the screen. I need a away to disable the InfoWindow to be presented automatically when the pin is selected.
DETAILS
The use case is when you need to track a Pin selection but doesn't want it to display the Info Window attached to the Pin. I have attached a screenshot with an example of this use case:

Notice that my UI provides a panel below the screen where I can get information for the selected Pin and also do some interaction, so the InfoWindow doesn't provide any valuable addition to this specific use case, and also occupy unwanted space on the screen.
Disabling the InfoWindow pin should be implemented like an flag property that could be set directly in XAML.
PLATFORMS

[x] Android
[x] iOS
[ ] UWP

You can handling pin behavior when clicked.
https://github.com/amay077/Xamarin.Forms.GoogleMaps/blob/e07feeee9bf49606ed0a532627b1c8f3115a467e/XFGoogleMapSample/XFGoogleMapSample/PinsPage.xaml.cs#L166-L179
Pin selection doesn't work automatically means do not open InfoWindow automatically.
But be careful if you hope disable InfoWindow, you can not Map.SelectedPin = xxx always.

I found Google Maps SDK's behavior.
https://developers.google.com/maps/documentation/ios-sdk/marker#add_an_info_window

Clicking the marker does not display an info window if both the title and snippet properties are blank or nil.

So I have a plan to support "Disable InfoWindow" .

Add UiSettings.InfoWindowEnabled as bool property
In Android/iOS side PinLogic, If UiSettings.InfoWindowEnabled is false then skip update marker's Title and Snippet

https://github.com/amay077/Xamarin.Forms.GoogleMaps/blob/ba855acdd86c35d6478d701d696f61cea30c3695/Xamarin.Forms.GoogleMaps/Xamarin.Forms.GoogleMaps.Android/Logics/PinLogic.cs#L78-L90
https://github.com/amay077/Xamarin.Forms.GoogleMaps/blob/ba855acdd86c35d6478d701d696f61cea30c3695/Xamarin.Forms.GoogleMaps/Xamarin.Forms.GoogleMaps.iOS/Logics/PinLogic.cs#L74-L84
Could you create Pull request, @ravero ?

Could you create Pull request, @ravero ?

Of course! I'll prepare this.

Hi, any news about that pull request? I didn't really get how to prevent InfowWindow to appear

I would also know if there is a way to disable the info window simply.

I would also know if there is a way to disable the info window simply.

I just put the pin label to null and it doesn't show the InfoWindow

I tried null and I get an error:
System.ArgumentException: 'Pin must have a Label to be added to a map'
However, using String.Empty works - no error and no info window, thank you!
                Pin pin = new Pin
                {
                    Icon = BitmapDescriptorFactory.DefaultMarker(Color.Red),
                    Position = position,
                    Tag = "whatever",
                    Label = string.Empty
                };

Don't you have an "Input string was not in a correct format." when you select a pin, unselect and select it again? This is what I get with string.empty

@amay077 @ravero Any update about the PR? I'm open to help if needed

In order to hide InfoWindow you need to create your own implementation of MapDelegate and override MarkerInfoWindow method, like that ->
        public override UIView MarkerInfoWindow(MapView mapView, Marker marker)
        {
            return new UIView();// base.MarkerInfoWindow(mapView, marker);
        }

Btw. returning null doesn't work ;)

You can handling pin behavior when clicked.
https://github.com/amay077/Xamarin.Forms.GoogleMaps/blob/e07feeee9bf49606ed0a532627b1c8f3115a467e/XFGoogleMapSample/XFGoogleMapSample/PinsPage.xaml.cs#L166-L179
Pin selection doesn't work automatically means do not open InfoWindow automatically.
But be careful if you hope disable InfoWindow, you can not Map.SelectedPin = xxx always.

Thank you! This does exactly what I have been wanting do to for a long time. Though a formal option to disable the info window would make it more discoverable (and preserve pin selection).


Proc oom adj

Pull Request Test Coverage Report for Build 967

0 of 13 (0.0%)  changed or added relevant lines in 2 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.07%) to 25.879%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

executor/runtime/docker/docker.go
0
3
0.0%

executor/runtime/docker/docker_linux.go
0
10
0.0%

Files with Coverage Reduction
New Missed Lines
%

launchguard/client/client.go
3
72.11%

Totals

Change from base Build 962:
-0.07%

Covered Lines:
2408

Relevant Lines:
9305

💛  - Coveralls

This will become dynamically adjustable once: https://github.com/Netflix/titus-api-definitions/pull/44 is merged.


Optimized Loading & SR2MM Compatibility

To summarize DaloLorn/Rising-Stars#20 and the SR2MM documentation:
Most modern SR2 mods use a special file structure for two reasons:

The mod editor (and possibly the rest of the game) runs through every file in your mod folder at least once. If the mod folder contains a fully-functioning Git repository, loading times will tend to increase over the lifetime of the repository as more changesets pile up. Physically separating the mod from irrelevant metadata such as Git repositories can negate this performance loss.
The SR2 Mod Manager was originally developed as an installation tool for Rising Stars itself, so it'll obviously favor a certain file structure. Conveniently, Darloth's old mods and all of Soloriens' RS-derived work have turned this configuration into an unofficial standard among those modders who bother to make their mods available via Git repos in the first place. While SR2MM will understand your current repository structure, it will run more smoothly if the mod code isn't in the root directory.

The following migration guide is a mildly edited form of the Git preparation guide in the SR2MM readme (themselves a modification of Darloth's instructions at the bottom of the linked RS issue), adjusted to hopefully fit your use case a little more closely:

Create a folder to keep the repository in. For example, C:\Projects\SourceControl\SR2-Colonization-Expansion
Move all SR2 mod data (modinfo, logo, and the data, locales and scripts folders) into a subfolder of that folder - for example, Colonization Expansion.
Move everything else (Git data, license, readme, screenshots folder) from your mod folder into the root folder. (In the example, that would be SR2-Colonization-Expansion.)
Open a command prompt, preferably an admin command prompt (just in case either the source or destination folder are in Program Files). Navigate to your Star Ruler 2 mods directory. Example:   cd "C:\Program Files (x86)\Steam\SteamApps\common\Star Ruler 2\mods"

Create a symbolic link (specifically, a directory junction) from the mod folder in your Git repository to your SR2 mods directory. Example:
   mklink /J "CE" "C:\Projects\SourceControl\SR2-Colonization-Expansion\Colonization Expansion"

After all of these steps have been performed, both SR2 and your Git client should see the mod exactly the way they're meant to see it, and the mod manager will be capable of cleanly downloading, installing, and updating it from GitHub.

On a tangentially related note, I can create a discussion channel for your mod in the SR2 Discord server, if you'd like one - and help you set up a webhook like the one used in #rs-dev-feed. (I can also list your repo in #mods-and-tools whenever you feel it's ready for people to play around with it.)

Thanks for the summary.
My current setup is perhaps a little odd due to using the open source SR2 setup, in that I have
~/Documents/Games/StarRuler2Source/mods/ce as the in progress version of my mod, where Star Ruler 2 scans the files, but this is not a git repository (as ~/Documents/Games/StarRuler2Source is a git repository and git doesn't like nested repositories) and then once I have something that's not crashing or incomplete I copypaste ~/Documents/Games/StarRuler2Source/mods/ce/* into ~/Documents/Games/star-ruler-2-mod-ce for committing.
After thinking about it for a moment I probably should take this as an opportunity to refactor the file structure as copypasting was introducing quite a bit of friction for each change.
I wasn't aware that there was a star ruler 2 discord, where is the invite link for it?

I have an interesting problem with the symlink. When Star Ruler 2 loads up it sees the files inside the symlink with their original filepath, and isAccessible(const std::string& filename) in bind_datafile.cpp is programmed to reject loading or saving files outside the star ruler 2 folder. I could make the function always return true but I'd have to recompile the game as its a C++ file and I'm not sure what side effects disabling this might cause.
Have all of you only been using this file structure on Windows?

We have, yes... though this Stack Overflow answer might be applicable.
Do tell what commands end up working, so I can include Linux instructions in the various guides.

Gotcha, that answer lead me to the solution
I had to do exactly that command you edited in that I didn't see till I fixed it myself :laughing:
For some reason Star Ruler 2 converts symlinks to their original paths, but a junction point works
As a side note, if you mess up and pick the wrong source or target the first time like I did, you can undo the junction with umount

TODO: Find a good solution for reapplying the mount on startup

Looks done to me.


feat: add executor decryption script

This is the python script that will be used by the decryption executor to decrypt the crypt4gh files and place them in a volume. The middleware will parse through all the input locations listed in the original request and feed them to decrypt.py in the first executor. Here's an illustration of exactly what the middleware will do (and how decrypt.py fits into the workflow):

Since it doesn't know what files are crypt4gh files beforehand, the script places all files (regardless of whether or not they are encrypted) in the new volume. If a file is not a crypt4gh file, it gets moved without alteration. If it is a crypt4gh file, the decrypted version is placed in the new volume.

Summary by Sourcery
This pull request adds a new Python script (decrypt.py) that identifies and decrypts Crypt4GH files, moving decrypted files to a specified output directory. Non-encrypted files are moved without alteration.

New Features:

Introduced a Python script (decrypt.py) to identify and decrypt Crypt4GH files, placing them in a specified output directory.

Follow-up question: to distinguish between encrypted and plain files, are you planning on looking at the extension? That may be a bit brittle... How about if the tesInput type grows a boolean field encrypted? cc @uniqueg

@uniqueg Yeah anyone with the secret key file would be able to decrypt the crypt4gh file that was encrypted with the associated public key. So if file.c4gh was encrypted with alice.pub, then anyone with alice.sec could decrypt it. None of the keys are obtainable from the crypt4gh file itself, though.

@JaeAeich Here's the PR with the decryption script and a graphic explaining the general vision.


extensibitlity of data source

I am experimenting with evaluating lazy frame with a custom data source. However, looks like Reader being declared as a struct makes it hard to add support for custom data source that shouldn't be part of the dataframe core code base.
Would it make sense to change Reader and Writer into traits so that custom data source implementations can be fully decoupled from the core code base?

For lazy reads, what matters are being able to get the schema (easy) and bring able to express predicate push-down if supported. The DataSourceEval does the first, but I hadn't gotten to the second.
It's fine if we start with just a trait that doesn't express predicate push-down, as long as the solution leaves scope for it being done in future.
Given that DataFrame takes in a &Reader and creates a concrete Arrow reader for the various formats, we could use arrow::record_batch::RecordBatchReader as the trait for custom sources.
I'm typing this on my phone (power outage), but I'll update my comment later when I'm on a desktop.

if we want to consider predicate push-down as part of the initial design, then perhaps it should be a wrapper trait that provides access to both RecordBatchReader as well as the predicates?

if we want to consider predicate push-down as part of the initial design, then perhaps it should be a higher level trait that provides access to both RecordBatchReader as well as the predicates?

Yes, I'm thinking along the lines of creating a trait that allows data sources to declare their capabilities (projection, filtering, etc), then applying optimisations to them based on such capability.

Hey @houqp, I spent some time trying to find a solution to this. The current #[derive(Serialize, Deserialize, Debug, Clone)] on crate::expression::Reader makes me unable to pass a trait that implements a reader/writer (also tried boxing it).
I haven't explored the idea of a datasource registry, but maybe that could work.
I'm thinking of instead using Arrow Flight for custom datasources. The main downside in the short term is that a custom source would need to implement the gRPC protocol + some defined extensions that would allow determining capabilities.
Spark's DataSource API benefits from runtime reflection to get the correct classes, I'm not good enough with Rust's data types to find equivalent solutions that would work :(

I wanted to implement something like:
pub trait DataSource: INSERT_BOUNDS {
    fn get_dataset(&self) -> Result<Dataset>;
    fn source(&self) -> DataSourceType;
    fn format(&self) -> &str;
    fn schema(&self) -> arrow::datatypes::SchemaRef;
    fn next_batch(&mut self) -> Result<Option<RecordBatch>>;

    fn supports_projection(&self) -> bool {
        false
    }
    fn supports_filtering(&self) -> bool {
        false
    }
    fn supports_sorting(&self) -> bool {
        false
    }
    fn supports_limit(&self) -> bool {
        false
    }

    fn limit(&mut self, limit: usize) -> Result<()>;
    fn filter(&mut self, filter: BooleanFilter) -> Result<()>;
    fn project(&mut self, columns: Vec<String>) -> Result<()>;
    fn sort(&mut self, criteria: Vec<SortCriteria>) -> Result<()>;
}

I think Arrow Flight would be an overkill for this use-case. As for the proposed trait, wouldn't it make more sense to move the responsibility of performing operations like filter and limit into dataframe struct itself?


Validation not working in settings JSON

Version: 1.68.0-insider
Commit: 15253f1528573fc8f84e956b21af4bad57f38c07
Date: 2022-06-02T05:17:01.962Z

open the Settings JSON editor
add some unnecessary commas
no problems reported in the problems view.
open the JSON Language Server log. Observe that there are no diagnostic requests. Other requests are sent and completed, so the language server is running.

Maybe unrelated: I was expecting "trailing comma" warnings in devcontainer.json (we recently changed the schema to not accept them), but they only started showing after I flushed the schema cache (using the UI command) and reloaded the window (I can't completely rule out that a window reload alone would have helped).

@chrmarti I checked that with the fix the trailing commas are reported


Installer issues

Hi,
Recently you might had an installer issue saying that the program is already running but it's not. I'm running into the same problem and I don't know what is the source problem. I want to know if anyone else is having the problem, if yes please reply to this issue with your system version.
A temporary fix for getting it working is running these commands (in a command prompt, not PowerShell) for deleting the app folders (note that will delete the config and log you out of Deezer on the app):
del /F /S /Q %appdata%\deezer-discord-rpc
del /F /S /Q %localappdata%\deezer-discord-rpc-updater
del /F /S /Q %localappdata%\Programs\deezer-discord-rpc

Then just relaunch the installer you've downloaded.

Hello,
I have the same issue on Windows 10 22H2, I encountered it with the update to 1.1.17 and now again to 1.1.18. I don't remember before but it may be because it hasn't been long since I came across your project and I began using it with 1.1.16 🤔
I deleted the folders and launched the installer afterwards and it worked ( I did the same thing before for upgrading to 1.1.17).


Fuzzing starlark

Spawned from https://github.com/google/starlark-go/pull/29#issuecomment-442295688
I've been using the ExecFile example as by base:
// +build gofuzz

package starlark

import "go.starlark.net/resolve"

func Fuzz(data []byte) int {

	resolve.AllowFloat = true
	resolve.AllowSet = true
	resolve.AllowLambda = true
	resolve.AllowNestedDef = true
	resolve.AllowBitwise = true
	resolve.AllowGlobalReassign = true

	thread := &Thread{
		Print: func(_ *Thread, msg string) {},
	}

	predeclared := StringDict{}

	_, err := ExecFile(thread, "apparent/filename.star", string(data), predeclared)
	if err != nil {
		return 0
	}

	return 1
}

first with all the resolve flags on, then with them all off.
I used testdata/*.star as by seed corpus, which now has 2824 entries.  I will file individual issues for the crashers.

I'm fine to close this. I mostly wanted to split it from the comment thread. Seems like no further discussion here is needed.


(PDB-5739) Reduce factsets "stable||volatile" merging

Without more potentially substantial changes to the query engine, we can't drop all the merging (e.g. the facts projection from the inventory endpoint) and switch to independent stable and volatile indexes, so for now, just consider some incremental changes along those lines.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Calling facets overview multiple times in one Jupyter notebook

I want to call use facet overview in different blocks of my jupyter notebook. It works fine with the first block, but if I call facets overview the second time in my notebook it will represent the overview of the new data on previous block. Any idea how I can fix it?

I believe you should be OK as long as you give your different facets-overview elements different IDs, and refer to them through those unique IDs. So the second facets-overview cell might look like this below. Notice to two places where we use "elem2" as a unique ID for this facets overview, as opposed to "elem" for the facets-overview element in the facets-overview demo notebook
        <script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/1.3.3/webcomponents-lite.js"></script>
        <link rel="import" href="https://raw.githubusercontent.com/PAIR-code/facets/master/facets-dist/facets-jupyter.html" >
        <facets-overview id="elem2"></facets-overview>
        <script>
          document.querySelector("#elem2").protoInput = "{protostr}";
        </script>"""
html = HTML_TEMPLATE.format(protostr=protostr)
display(HTML(html))```

Interesting, thanks!
Is there anyway for defining a function for facets overview that can automatically create create different IDs? It might be obvious, I am just curious and like to contribute.


fix: Applied go fmt, fixed masked output

Lines 489-491 in runebuf.go are repeated in lines 506-508.
This typo led to working cursor through prompt text.
Deleting repeated lines fix that issue.
Applied go fmt to runebuf.go

Masked output error
Fmt

Need to move to separate branch


local-collect tests

Just read the code coverage aim for around 85% for everything in local.go and all of the packages under cmd/local, use your best judgement 3 line files do not count
code counts as of today in the packages targeted

NOTE: in issue #29 i have moved the local.go files and test to the cmd/local package to get some more accurate code coverage stats on that package
So I would translate that into the following todo list:

[ ] run ./script/test && ./script/cover-html to see the lines of code missing
[ ] jobprofiles.go needs a few tests
[x] wlm.go needs a bunch of mocked out unit tests .. may need some refactoring, make a separate issue if this is too hard
[ ] awse.go needs some new new tests
[ ] cpu_threads.go needs some new tests
[ ] gclog_finder.go needs a good amount of new tests
[ ] pid.go needs maybe one more
[ ] conf.go needs some additional tests ( I am guessing covering all the simple functions will get you there)
[ ] queries.go needs a few more
[ ] local.go needs the most and to fair this may imply some more refactoring, if so..make a separate task for this refactoring.

do all that above (and make issues for the wlm.go and local.go if that proves to hard) and close this issue.

accidentally closed in fixing one of the tasks (WLM is no longer needed as I used a real rest HTTP server to get it working without a lot of mocking and indirection)

supplanted by another jira


Added support of custom SAML2 post Logout URL

My pull request relates to the discussion thread
https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/pac4j-dev/_ws84B-S7F4/GIJZKu9_BgAJ

Thanks for your contribution


404 at /get-started/part2/

I found a broken link : https://docs.docker.com/get-started/part2/
I arrived on this page through: https://www.google.com/

Internal server issues (code: 500)?

The getting started page was recently updated. Part 2 is now at https://docs.docker.com/get-started/02_our_app/


Implement power wrapper for Gates

Problem
Our codebase implements gates through the abstract Gate protocol. It is common for our scientists to make use of gates raised to a power, for example $\sqrt[1/4]{Z} = T$ and $\sqrt{SWAP}$ are commonly used in universal gate sets. So far it has sufficed to create a new custom gate every time we need to raise a gate to a power, but it would be convenient to simply call a function to find the power of a gate.
Solution Description
Implement a class power wrapper around the Gate Protocol. The wrapper should take a gate and a real number as inputs to it's constructor. We only need to calculate powers for gates without free parameters, so make sure your gate you are wrapping around does not have them. tip: power should be implemented similarly to the dagger wrapper class.
Deliverables

[ ] power wrapper around Gates as described above.
[ ] Write tests for class

Affected repo: orquestra-quantum

Yes. You will have to compute the power of this matrix much in the same way how the dagger needs to be computed in the Dagger class.


Expose ws.onclose method to client

when there aren't many events on subscribed address the websocket seems to close the session probably due by default os/firewall/network setting tcp keep alive: 7200 - 2 hours
For example, I use this function to monitor/subscribe my block rewards when my validator has been elected in current epoch, I can see events coming in but when it's not elected and you have to wait 12 hours to be elected again, the websocket timed out already, have to manually restart the process.
const { next, close } = await client.blockchainStreams.subscribeForLogsByAddressesAndTypes(
      {
        addresses: [validatorAddresss],
        types: [],
        withMetadata: true,
      },
      { once: false }
    )

proposed way to mitigate that:
expose ws.onclose to client, so we can pass callback function to reset the subscribe function
   ws.onclose = function(){
        setTimeout(subscribeFunctionAgain, 1000);
    };

Hey, just released v0.5.5. ea39457214465267ba7d921408f8f09c8995d466
Now you should be able to access the WebSocket instance as follows
const { next, close, ws } = await client.blockchainStreams.subscribeForLogsByAddressesAndTypes(...)

ws.onclose()

Let me know if this solution works for you, specially if you find any issues with the types. Thank you!
PS: I am planning to refactor the WebClient implementation to use a WebSocket library to take advantage of features like auto-reconnect, timeout... You can follow #64 to find out when this will be available :)

Hey, just released v0.5.5. ea39457
Now you should be able to access the WebSocket instance as follows
const { next, close, ws } = await client.blockchainStreams.subscribeForLogsByAddressesAndTypes(...)

ws.onclose()

Let me know if this solution works for you, specially if you find any issues with the types. Thank you!
PS: I am planning to refactor the WebClient implementation to use a WebSocket library to take advantage of features like auto-reconnect, timeout... You can follow #64 to find out when this will be available :)

thanks @onmax great work!


Can I use your project in my project?Not for commercial use, and not a open source project.

Hi @lpf-gavin,
Please refer to the license notice at the bottom of the library's home page/README
Best,
Ari Cheshin


Why do you still use Guavas eventbus for application-internal events?

Hi,
stumbled about your bog posts and this one and came to this repo. Had a look into it and found  a configuration for the eventbus provided by guava library. Also used it years ago for application-internal events. But that's not needed anymore. Spring has it's own eventbus since years now and also provide an annotation based model (and I guess that's what you maybe liked on guavas, right?).
Have a look to the well documented feature. And yes, also async event handling is supported. There is no need for guava dependency anymore ( 2.7 MB in size btw. ). At least not for application internal event handling. ;-)
Happy Coding

Hey Jörg,
thank you for your feedback!
We evaluated both, Spring Application Events and Guava, when we wrote this demo. The support for async events was better in Guava in our opinion. We didn't want to have two annotations on each listener:
@EventListener
@Async
public void listen(...) {
    ...
}

However, I invested some more time and stumbled over this blog post. It describes an approach to enable async Spring events without annotating all listeners with @Async. With this, it's fine for me to remove Guava. As you said, it's one dependency less.
I already updated the code.
Thanks again and best regards,
Thomas

Hi Thomas,
great to see you liked the idea of removing Guava for handling events.
Regarding your commment:

We didn't want to have two annotations on each listener

That's something I understand and fully agree on. The drawback of the solution from the blog you mentioned above is that all events are now handled asynchronously (noted in the blog, too). I also found the link in the blog post that mentioned a solution for this (having both, sync and async events). But that solution comes with some more configuration overhead that is not really necessary I think.
My proposal would be to use Meta-Annotations instead. Create your own annotation for that, like this one:
@Target({ ElementType.METHOD, ElementType.ANNOTATION_TYPE })
@Retention(RetentionPolicy.RUNTIME)
@Documented
@EventListener
@Async
public @interface AsyncEventListener {

    @AliasFor(annotation = EventListener.class, attribute = "value")
    Class<?>[] value() default {};

    @AliasFor(annotation = EventListener.class, attribute = "classes")
    Class<?>[] classes() default {};

    @AliasFor(annotation = EventListener.class, attribute = "condition")
    String condition() default "";
}

The benefit would be you can drop the special configuration class and the much more useful benefit would be you could control the behaviour (sync/async) on the listeners side. What makes it much more flexible for you.
Try it.
Have fun.
Happy coding.
Jörg


Remove Web Starter Kit recommandation

On step 4, you say "and we generally recommend using Web Starter Kit".
Then if you follow the link to Web Starter Kit you end up on a page saying "Warning: Web Starter Kit is no longer supported.".
It doesn't feel right.

yes, this is true, it would be good to make the recommendation to view the documentation.

Yea I'm a bit confused now as there's no alternative recommendation. Wondering if I should or should not continue tutorial with WSK

@petele @rowan-m
I noticed this too — I think we should remove it.

Agreed - I've removed the recommendation from the code lab and will republish today.

Updated in google/webfundamentals#5839


Switch maps on a change on zoom-to-include-markers

Hi,
I am trying to switch between zooms of a map depending on the value that I am using to set zoom-to-include-markers in the directive (true or false). However, this does not auto update the map.
Is this the expected behavior of the directive? Can the map not auto update on a change on zoom-to-include-markers attribute?
Thanks!

There is undocumented feature zoom-to-include-makers="auto".


Guide update request for RedHat SELinux Apache Enforcing mode allow

Hi,
thank you for the solution and the description about the environment set up, its really great!
I have had some difficulties only with the RHEL installation guide. You already know the solution, but it takes time to find it.
I followed the instruction here on this URL (https://www.microsoft.com/en-us/sql-server/developer-get-started/php/rhel/) from the "Step 2.1 Install the PHP Driver for SQL Server" I really missed this one line command.
sudo setsebool -P httpd_can_network_connect_db 1
This line you have it here : https://github.com/Microsoft/msphpsql/blob/dev/README.md
In the "Step 5: Restart Apache to load the new php.ini file" , but it is hard to discover it there as well.
Changes which I would like to ask:

Here on github in the install instructions it would be really helpful to move in the step 5 section that line before the  "Mac OS X" header, because the RedHat header do not have the sign that it has that one line extra comment. For me it was really confusing that it was after the Mac section, because its RedHat related.

On the microsoft url it would be great to have that one line added to the 2.1 section or somewhere near to it.

For me the behavior was the following:
I developed a PHP - MSSQL solution on Ubuntu and when I tried to deploy it on CentOS it was not connecting to the server. I was able to connect via SQLCMD to the MSSQL server, query returned the expected result. Unfortunately when I tried to do the same through PHP it failed every time with this error:
[unixODBC][Microsoft][ODBC Driver 13 for SQL Server]Login timeout expired Error: [unixODBC][Microsoft][ODBC Driver 13 for SQL Server]TCP Provider: Error code 0x271D Error: [unixODBC][Microsoft][ODBC Driver 13 for SQL Server]A network-related or instance-specific error has occurred while establishing a connection to SQL Server. Server is not found or not accessible. Check if instance name is correct and if SQL Server is configured to allow remote connections. For more information see SQL Server Books Online.
Now since executed that command its working fine. So this is more like a please update the guide  request.
Thanks again its really great work,
Vik

Ohh, I forget to mention that for RHEL I think one of the install package name is mistyped on the microsoft website ( https://www.microsoft.com/en-us/sql-server/developer-get-started/php/rhel/). "php-mycrypt"  was not a valid package name for me in "Step 1.2 Install PHP and other required packages"  I think its called the same way as the Ubuntu version "php-mcrypt".
Also here on github maybe it would be advised to change the service restart to

for RHEL:
systemctl restart httpd
for Ubuntu:
systemctl restart apache2

@kviktorman Thanks points taken! we sent a PR with your suggestions

Thanks, I see the changes here on Github. On the linked MS webpage its still the same. Do I need to report that in a different way or it will be updated soon and I shall close this issue?

We'll take care of that one here too :wink: @meet-bhagdev can you update 'Get started pages similar to #500 and @kviktorman suggestions.

Closing this issue @kviktorman as the MS Get started page has been updated. Thank you for your contributions.


Testing 4.2.0 Docker Images on Apple Intel Processor

Description
This is to track testing progress of 4.2.0 Docker Images in [1] on Apple Intel Processor

[x] jdk17/centos
[x] jdk17/ubuntu
[x] jdk17/alpine
[x] jdk11/centos
[x] jdk11/ubuntu
[x] jdk11/alpine

MI 4.2.0 Docker Images in [2] in Apple Intel Processor

[ ] centos
[ ] ubuntu
[ ] alpine - Unsupported arch: aarch64

MI Dashboard 4.2.0 Docker Images in [2] in Apple Intel Processor

[ ] centos
[ ] ubuntu
[ ] alpine

SI 4.2.0 Docker Images in [2] in Apple Intel Processor

[ ] centos
[ ] ubuntu
[ ] alpine

[1] https://github.com/wso2/docker-apim/tree/4.2.x/dockerfiles/
[2] https://github.com/wso2/docker-ei/tree/4.2.x/dockerfiles
Affected Component
APIM , MI , MI Dashboard, SI
Version
4.2.0
Related Issues
No response
Suggested Labels
No response

Tested the following images.

@chanaka3d

Can you share a HAR or the browser console output if it has any errors?

The issue was resolved after updating the safari browser to 15.6.1

All the following docker images are working fine with Apple intel processor. @chamilaadhi


docs: fit md link formatting

Thanks @sublimino! The linter failed but it's not related to this change. We should fix those in another PR.


Certificate Renewal

Issue description
Does Port 80 need to be open for certificate renewal to succeed?
Steps to reproduce
Our certificate renewal scheduled task ran this morning but failed.  I manually renewed the certificate this afternoon after creating a rule to open port 80 within the NSG (as the error message when I initially tried to renew manually suggested that a firewall issue may have been responsible).
1: 2018/3/26 23:12:21 PM - Success - Thumbprint 14BA27C5316F7098F8C77A5B28E33A57A076B91C
2: 2018/5/22 2:45:45 AM - Error - Exception of type 'PKISharp.WACS.AuthorizationFailedException' was thrown.
3: 2018/5/22 2:56:46 AM - Error - Exception of type 'PKISharp.WACS.AuthorizationFailedException' was thrown.
4: 2018/5/22 3:00:19 AM - Success - Thumbprint 60DC519A4961D024E8D0688FA160680E67A41438

Yes it does when you use http validation.  Since tls validation has been disabled, dns validation is the only option for when you want to close 80.


Update manifest-entry.xsd

is this intended or a copy/paste error?

Thanks! It seems to be my mistake.

Released in v0.1.1.


Wine couldn't run application to update windows Icon?

Update win32 executable icon
err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
err:winediag:nodrv_CreateWindow Make sure that your X server is running and that $DISPLAY is set correctly.
err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
err:winediag:nodrv_CreateWindow Make sure that your X server is running and that $DISPLAY is set correctly.
err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
err:winediag:nodrv_CreateWindow Make sure that your X server is running and that $DISPLAY is set correctly.
err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
err:winediag:nodrv_CreateWindow Make sure that your X server is running and that $DISPLAY is set correctly.
Could not load wine-gecko. HTML rendering will be disabled.
err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
err:winediag:nodrv_CreateWindow Make sure that your X server is running and that $DISPLAY is set correctly.
err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
err:winediag:nodrv_CreateWindow Make sure that your X server is running and that $DISPLAY is set correctly.
Could not load wine-gecko. HTML rendering will be disabled.
wine: configuration in '/root/.wine' has been updated.
err:mscoree:CLRRuntimeInfo_GetRuntimeHost Wine Mono is not installed
(node:26857) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error while updating the Windows icon. Wine (winehq.org) must be installed to add custom icons from Mac and Linux.
(node:26857) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I don't understand that.
Wine version : 2.8
OS: CentOS

@adam-lynch

Reported a new log
wine: Bad EXE format for Z:\root\.jenkins\workspace\hongfund-desktop\node_modules\winresourcer\bin\Resourcer.exe.
(node:11890) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error while updating the Windows icon. Wine (winehq.org) must be installed to add custom icons from Mac and Linux.
(node:11890) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

@tangyue0924 I don't have time this minute to look into it but could you give me as much detail as possible? I.e.

nw-builder version
nwjs version
config passed to nw-builder
node version
CentOS version (just in case)
anything else

i am getting the same error on my mac... can u please suggest which version of wine should i use...currently using wine-2.0.2 and version in nwbuilder is 0.22.3
i have try to run wine thing through terminal... it is showing that

@vimalcronj could you please supply an example project?

@tangyue0924 Let me know if this issue still happens for the most recent versions of NW.js and wine.


When a song is played by being clicked in the playlist, it goes back to the top instead of playing the following song

Browser: Safari, Chrome, Firefox
Browser Version:  all up to date
Operating System: OSX
Amplitude.js Version: 3.1.0

Issue description
Not sure if it's a bug or else I'm not aware of some functions but when I click on a determined song in the playlist, after the song is over it goes back to the top song in the player instead of going on into the next song. Is there a function to prevent that and let it go with the following track?
Steps to reproduce the issue

Click on song on the playlist
Let it play
Goes back to the top

What is expected?
I am not sure if this is supposed to be happening or not?
Link to where issue can be reproduced
Also in https://521dimensions.com/open-source/amplitudejs
Thank you, amazing platform! It's the best player I know to date 🥇

Thanks, we appreciate it! We'll take a look into this and we'll report back. 3.2 was just released literally an hour ago and I know the sample player is being updated as we speak.
Thanks for taking the detail to complete such a detailed bug report!

@tveloq Thanks for the heads up! So this is fixed in Version 3.2 which was pushed today. We are updating our marketing site and it will be fixed on there in the next hour or so for an example! Thanks for the kind words too and let us know if there's any other issues.

Wow that's such a great timing! I can confirm the issue is gone on my end, thank you so much @danpastori @jaydrogers !

Awesome, no problem! Let us know if you need any more help!


JBDS-4279 Show ad with link for CDK 3 on confirmation page

Codecov Report

:exclamation: No coverage uploaded for pull request base (1.3.0@f0d630f). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             1.3.0     #558   +/-   ##
========================================
  Coverage         ?   78.99%
========================================
  Files            ?       18
  Lines            ?     2271
  Branches         ?      187
========================================
  Hits             ?     1794
  Misses           ?      477
  Partials         ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d630f...421361e. Read the comment docs.

test this

test this


Path and expand

Snakemake version
5.7.4
Describe the bug
Since 5.7.0 Pathlib compatibility has been added. However, the expand() function gets confused by path-objects, it seems to assume strings.
Logs
TypeError in line 6 of /mnt/work/gutorm/qcTest/snakeplay/Snakefile.pathlib:
unsupported operand type(s) for +: 'PosixPath' and 'str'
File "/mnt/work/gutorm/qcTest/snakeplay/Snakefile.pathlib", line 6, in
Minimal example
from pathlib import Path
hello = "Hello"   # works
hello =  Path("Hello")  # will only work if casted to string or if not expand()-ed
rule test:
input:  "Snakefile.pathlib"
output: expand(hello + '{ext}', ext=['.1','.2'])
run:
print (output)
Additional context
Note that in the example above, using
output: Path("Hello.1"), Path("Hello.2")
will work
This is not a big issue for now - but it would be nice to know if there is a workaround beside

casting to string in the output: clause
casting back to Path in the run: section

I would like to  switch from old-school os.path.* functions but would try to avoid a mix depending on where the variables are used in expand-contexts

This error is not coming from Snakemake. You try to concatenate the path object with a string here: hello + '{ext}', which is not supported by pathlib.


Complications with preloading fallback fonts

Description
Firstly, thank you for making this brilliant framework!
In short, I'm hosting a font needed for my project locally and importing it in CSS:
/* PageShell.scss */
@font-face {
  font-family: Roboto;
  font-display: swap;
  src: local("Roboto"),
    url("../../fonts/Roboto-Regular.woff2") format("woff2"),
    url("../../fonts/Roboto-Regular.ttf") format("ttf");    /* fallback font */
}

A ttf fallback font source is specified above, in case the browser doesn't support woff2. There are two issues I want to highlight.

writeEarlyHints API fails when using fallback fonts in production:

Server running at http://localhost:3000
TypeError [ERR_INVALID_ARG_VALUE]: The argument 'hints' must be an array or string of format "</styles.css>; rel=preload; as=style". Received '</assets/Roboto-Regular.b01691f5.woff2>; rel=preload; as=font; crossorigin'
    at new NodeError (node:internal/errors:393:5)
    at validateLinkHeaderFormat (node:internal/validators:455:11)
    at validateLinkHeaderValue (node:internal/validators:481:7)
    at ServerResponse.writeEarlyHints (node:_http_server:314:16)

This fallback font gets injected into the <head> element, and then loaded even if it's is not needed:

<head>
  ...
  <link rel="preload" href="/assets/Roboto-Regular.b01691f5.woff2" as="font" type="font/woff2" crossorigin="">
  <link rel="preload" href="/assets/Roboto-Regular.4e147ab6.ttf" as="font" type="font/ttf" crossorigin="">
  ....
</head>

This unnecessary resource load will bring down page performance (FCP) if the developer defines multiple fonts.
I believe the default preload strategy should be updated to omit fallback font sources.
Thank you!
Related: https://vite-plugin-ssr.com/preload
Error Message + Error Stack
No response

Can you create a reproduction for 1.?
Good idea/point  regarding 2..

reproduction

Adding a font to the app generated by $ npm init vite-plugin-ssr@latest should do the trick.

As per Node.js's thrown error, it seems like Early Hints don't have a crossorigin property.
TypeError [ERR_INVALID_ARG_VALUE]: The argument 'hints' must be an array or string of format
"</styles.css>; rel=preload; as=style". Received '</assets/Roboto-Regular.b01691f5.woff2>;
rel=preload; as=font; crossorigin'`

Released in 0.4.74 (both the fix and the fallback enhancement https://github.com/brillout/vite-plugin-ssr/issues/624).
In case your company is up for it: https://github.com/sponsors/brillout.


chore: update KendallDoesCoding profile

Fixes Issue

Update profile

Changes proposed

Update avatar (may change it back in the future)
Add icon in milestones section
Add Youtube
Color Youtube icon red.
Remove slash from portfolio link
Add milestone

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@emmalearnscode @Panquesito7 Should I put my coding avatar or just my avatar for this?

@emmalearnscode @Panquesito7 Should I put my coding avatar or just my avatar for my page?

What are you trying to do? Add an image to a milestone?

@emmalearnscode @Panquesito7 Should I put my coding avatar or just my avatar for my page?

What are you trying to do? Add an image to a milestone?

No, as the avatar for my page:
"avatar": "https://i.ibb.co/5LsjwVB/Avatar-Maker.png",

We try to encourage people to use their GitHub profile link as it updates automatically here when you update GitHub and then the two are in sync.

We try to encourage people to use their GitHub profile link as it updates automatically here when you update GitHub and then the two are in sync.

Ok, I dont really want to update my github icon in future, I added a avatar coz that looks more like a real person then this, but will update it to https://github.com/KendallDoesCoding.png

Thanks for making the suggested changes. The JSON file looks good, but I don't have any idea why there are 2 falling checks from github-action.

I think it’s the trailing commas on line 41 and 48 that are causing the test failures.

Thanks for making the suggested changes. The JSON file looks good, but I don't have any idea why there are 2 falling checks from github-action.

I think it’s the trailing commas on line 41 and 48 that are causing the test failures.

Yeah! that makes sense :+1:

Done
On Sun, 6 Feb 2022 at 23:30, Vikas Ganiga @.***> wrote:

@.**** commented on this pull request.
In public/data/KendallDoesCoding.json
https://github.com/EddieHubCommunity/LinkFree/pull/1067#discussion_r800213658
:

],
"milestones": [
{
"title": "Started Tech Journey",

 "date": "2020"

}

 "date": "2020",

 "icon": "globe"

},

Remove the trailing comma on line 48.
—
Reply to this email directly, view it on GitHub
https://github.com/EddieHubCommunity/LinkFree/pull/1067#discussion_r800213658,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUGJUTIPVLTC4MYBKCVXBQ3UZ2ZLXANCNFSM5NU5W5MA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Awesome! there are no failing checks from github-action. All are passed. Well done 👍

Thanks for your and @emmalearnscode 's help :)

Awesome! there are no failing checks from github-action. All are passed. Well done +1

Thanks for your and @emmalearnscode 's help :)

Your welcome :slightly_smiling_face: . Collaboration first code second

@Panquesito7 @emmalearnscode @vikasganiga05 Requesting a re-review from yall as I made edits after yall reviewed it before. Thanks

@emmalearnscode @Panquesito7 I think we got 3 approvals, please merge after I make a final edit.

Kendall please be aware that all maintainers here are volunteers and many of us work full time jobs. We promise to get to your pull requests when we have time. Wait until you have made the final edit to post an update message, have patience and let the maintainers check things and merge things in our own time, thanks :)

@emmalearnscode @Panquesito7 I think we got 3 approvals, please merge after I make a final edit.

Kendall please be aware that all maintainers here are volunteers and many of us work full time jobs. We promise to get to your pull requests when we have time. Wait until you have made the final edit to post an update message, have patience and let the maintainers check things and merge things in our own time, thanks :)

Yeah, I totally understand that. Just posted a gentle reminder as this PR has been on stand-still for the last 4 days :)

GitHub profile is preferable but it’s your choice.

Ok cool! I'll leave it has the github profile for now.

It’s up to you and how long you intend to pay for the domain.

It's a free domain lol, I just need to renew it 😆

It’s up to you and how long you intend to pay for the domain.

It's a free domain lol, I just need to renew it 😆

and yeah, i do intend of renewing it.


ACM-4860 - VM2 version change (2.7.z)

regarding:

https://issues.redhat.com/browse/ACM-4860
https://github.com/patriksimek/vm2/security/advisories/GHSA-7jxr-cg7f-gpgv

/hold

/lgtm

/lgtm

/unhold


Add word "Welter"

Create a folder for "W" and add the word "Welter"
Add the meanings for the verb form of Welter in a file named Welter_verb.json
Add the meaning for the noun form of Refractory in a file named Welter_noun.json
Refer Contribution.md for more details on how to contribute.
Comment here if your are working on this issue to avoid conflicts.
Add reference to this issue i.e Issue #41 in your pull request description.

@Showndarya I'm taking this one


Jobs health banner

Add a banner to indicate if all jobs are healthy/not healthy.

Added health status indicator instead of an actual banner.

PR: #116


[Update Request]: ActivityWatch v0.13.2

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
ActivityWatch.ActivityWatch
Package Version
0.13.2
Please describe the changes you would like to see
There is one new release (v0.13.2) since the current latest version (v0.13.1) available.
The release page of the project ca be found here: https://github.com/ActivityWatch/activitywatch/releases

/


Issues with ES 7.4.2

Describe the bug
Jaeger query is failing to get the spans in the UI because of the following error.
Jun  8 12:51:50 ip-172-31-57-156 jaeger-query[7223]: {"level":"error","ts":1591620710.104769,"caller":"app/http_handler.go:430","msg":"HTTP handler, Internal Server Error","error":"Search service failed: json: cannot unmarshal object into Go struct field SearchHits.hits.total of type int64","errorVerbose":"json: cannot unmarshal object into Go struct field SearchHits.hits.total of type int64\nSearch service failed\ngithub.com/jaegertracing/jaeger/plugin/storage/es/spanstore.(*ServiceOperationStorage).getOperations\n\t/go/src/github.com/jaegertracing/jaeger/plugin/storage/es/spanstore/service_operation.go:121\ngithub.com/jaegertracing/jaeger/plugin/storage/es/spanstore.(*SpanReader).GetOperations\n\t/go/src/github.com/jaegertracing/jaeger/plugin/storage/es/spanstore/reader.go:256\ngithub.com/jaegertracing/jaeger/storage/spanstore/metrics.(*ReadMetricsDecorator).GetOperations\n\t/go/src/github.com/jaegertracing/jaeger/storage/spanstore/metrics/decorator.go:114\ngithub.com/jaegertracing/jaeger/cmd/query/app/querysvc.QueryService.GetOperations\n\t/go/src/github.com/jaegertracing/jaeger/cmd/query/app/querysvc/query_service.go:86\ngithub.com/jaegertracing/jaeger/cmd/query/app.(*APIHandler).getOperationsLegacy\n\t/go/src/github.com/jaegertracing/jaeger/cmd/query/app/http_handler.go:161\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/lib/go-1.13/src/net/http/server.go:2007\ngithub.com/jaegertracing/jaeger/vendor/github.com/opentracing-contrib/go-stdlib/nethttp.MiddlewareFunc.func5\n\t/go/src/github.com/jaegertracing/jaeger/vendor/github.com/opentracing-contrib/go-stdlib/nethttp/server.go:140\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/lib/go-1.13/src/net/http/server.go:2007\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/lib/go-1.13/src/net/http/server.go:2007\ngithub.com/jaegertracing/jaeger/vendor/github.com/gorilla/mux.(*Router).ServeHTTP\n\t/go/src/github.com/jaegertracing/jaeger/vendor/github.com/gorilla/mux/mux.go:212\ngithub.com/jaegertracing/jaeger/vendor/github.com/gorilla/handlers.CompressHandlerLevel.func1\n\t/go/src/github.com/jaegertracing/jaeger/vendor/github.com/gorilla/handlers/compress.go:148\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/lib/go-1.13/src/net/http/server.go:2007\ngithub.com/jaegertracing/jaeger/vendor/github.com/gorilla/handlers.recoveryHandler.ServeHTTP\n\t/go/src/github.com/jaegertracing/jaeger/vendor/github.com/gorilla/handlers/recovery.go:78\nnet/http.serverHandler.ServeHTTP\n\t/usr/lib/go-1.13/src/net/http/server.go:2802\nnet/http.(*conn).serve\n\t/usr/lib/go-1.13/src/net/http/server.go:1890\nruntime.goexit\n\t/usr/lib/go-1.13/src/runtime/asm_amd64.s:1357","stacktrace":"github.com/jaegertracing/jaeger/cmd/query/app.(*APIHandler).handleError\n\t/go/src/github.com/jaegertracing/jaeger/cmd/query/app/http_handler.go:430\ngithub.com/jaegertracing/jaeger/cmd/query/app.(*APIHandler).getOperationsLegacy\n\t/go/src/github.com/jaegertracing/jaeger/cmd/query/app/http_handler.go:168\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/lib/go-1.13/src/net/http/server.go:2007\ngithub.com/jaegertracing/jaeger/vendor/github.com/opentracing-contrib/go-stdlib/nethttp.MiddlewareFunc.func5\n\t/go/src/github.com/jaegertracing/jaeger/vendor/github.com/opentracing-contrib/go-stdlib/nethttp/server.go:140\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/lib/go-1.13/src/net/http/server.go:2007\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/lib/go-1.13/src/net/http/server.go:2007\ngithub.com/jaegetracing/jaeger/vendor/github.com/gorilla/mux.(*Router).ServeHTTP\n\t/go/src/github.com/jaegertracing/jaeger/vendor/github.com/gorilla/mux/mux.go:212\ngithub.com/jaegertracing/jaeger/vendor/github.com/gorilla/handlers.CompressHandlerLevel.func1\n\t/go/src/github.com/jaegertracing/jaeger/vendor/github.com/gorilla/handlers/compress.go:148\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/lib/go-1.13/src/net/http/server.go:2007\ngithub.com/jaegertracing/jaeger/vendor/github.com/gorilla/handlers.recoveryHandler.ServeHTTP\n\t/go/src/github.com/jaegertracing/jaeger/vendor/github.com/gorilla/handlers/recovery.go:78\nnet/http.serverHandler.ServeHTTP\n\t/usr/lib/go-1.13/src/net/http/server.go:2802\nnet/http.(*conn).serve\n\t/usr/lib/go-1.13/src/net/http/server.go:1890"}
Also I see that curator is broken because v5.4.1 isn't compatible with 7.4.2.
 INFO      Preparing Action ID: 1, "delete_indices"  ERROR     Elasticsearch version 7.4.2 incompatible with this version of Curator (5.4.1)
Expected behavior
Jaeger UI should show the spans and also curator is able to delete older indexes.
Version (please complete the following information):

OS: Linux
Jaeger version: v1.17.1
Deployment: EC2

Just to give more information that it was running fine with ES 6.8. This has started happening post 7.4.2 upgrade.

Could you please paste the logs of Jaeger binaries when they started? Jaeger should detect ES version automatically and log it. There is also a flag to specify the version explicitly --es.version=7. Could you please try that?

Thanks, specifying the version explicitly solves the problem.
But still the curator issue remains, I believe it's probably needed to pull the latest curator version to solve that problem.


feat(quantic): new Quantic Modal component created

Quantic Modal
The QuanticModal component provides the logic to easily implement a modal in Quantic. This component handles the animation logic, exposes methods to open and close the modal, offers the option to open the modal in full screen or just to cover the search interface, and exposes a set of slots to fully customize the modal content.
SFINT-4493
Note:
The full screen option is still present in the quantic modal api for the following reason:

Having the Quantic Modal always covering the search interface means that the height of the modal will always be equal to the height of the search interface. Which is a bit problematic because for example in the Example Search Page the height of the search interface  it pretty big, so if the modal covers the whole search interface the user will need to scroll down to see the footer of the modal which is present in the bottom of the modal.  For this particular reason having the modal on full screen can be more useful and more natural. up to debate of course!

Demo
https://user-images.githubusercontent.com/86681870/164706654-2d92b614-0f15-4396-b2fe-7c446847ad04.mov
https://user-images.githubusercontent.com/86681870/164709216-09022c09-7f09-4b46-be5e-7beeead8a1fe.mp4

@MehdiMitiche In the Full Screen section of the PR description you say this:

Having the Quantic Modal always covering the search interface means that the height of the modal will always be equal to the height of the search interface.

Is it possible to make the height of the modal match the viewport's height? Or is that what the "full screen" option is doing?
This might be tricky to implement though, especially when other components are rendered on top of the Insight Panel.

@MehdiMitiche In the Full Screen section of the PR description you say this:

Having the Quantic Modal always covering the search interface means that the height of the modal will always be equal to the height of the search interface.

Is it possible to make the height of the modal match the viewport's height? Or is that what the "full screen" option is doing? This might be tricky to implement though, especially when other components are rendered on top of the Insight Panel.

Yes that's what the "full screen" option is doing, giving the modal a height equal to the viewport's height and a width equal to the viewport's width with a big value of z-index to make the modal appear above of all the other components.

In the case of the refine modal with facets as content. The content will often be longer than the container and the button in the footer to go back to the search results should always be visible and clickable.

What does it take to achieve the responsiveness you show in the RefineModalExampleSearch.online-video-cutter.com.mp4 ? If it can be done in a slick way using template conditional markup for example then could we add it to the exampleSearch component while we're at it?

@MehdiMitiche In the Full Screen section of the PR description you say this:

Having the Quantic Modal always covering the search interface means that the height of the modal will always be equal to the height of the search interface.

Is it possible to make the height of the modal match the viewport's height? Or is that what the "full screen" option is doing? This might be tricky to implement though, especially when other components are rendered on top of the Insight Panel.

Yes that's what the "full screen" option is doing, giving the modal a height equal to the viewport's height and a width equal to the viewport's width with a big value of z-index to make the modal appear above of all the other components.

The thing that worries me is having to scroll down to reach the modal footer when the search page is longer than the viewport. I think that when full-screen is false, the modal height should still match the viewport height so the footer is always visible. We'd have to decide what to do when the modal content is longer than the viewport. My guess is that the footer should remain visible and the content section should scroll, but pushing the footer down after the content could also make sense.

I'm a bit confused, why would we want to the modal height to match the viewport when 'full-screen' is set to false? For example in the Insight Panel shown below:
It's the case where we need the modal to only cover the search interface so 'full-screen' is set to false here. Why would we want the modal height to match the viewport height here?

From what I see in the screenshot, it already behaves as I would expect. I mean that the footer is visible and the content is scrolling, so it seems to be all good already.

The thing that worries me is having to scroll down to reach the modal footer when the search page is longer than the viewport. I think that when full-screen is false, the modal height should still match the viewport height so the footer is always visible. We'd have to decide what to do when the modal content is longer than the viewport. My guess is that the footer should remain visible and the content section should scroll, but pushing the footer down after the content could also make sense.
I understand that we don't want to make the user scroll down to reach the modal footer,  but I can't think of a way that will allow us to always show the  modal footer and in the same time have the modal covering only the search interface when the height of the search interface is longer than the viewport.
The logic I followed is like the following:

If the height of your search interface is greater than the viewport's height, set the value of 'full-screen' to true to display the modal in full screen and avoid scrolling the page to reach the footer of the modal.
if the height of your search interface is lower than the viewport's height, you can set 'full-screen' to true or false depending on the use case. In both cases, you will not need to scroll to reach the footer of the modal.

What does it take to achieve the responsiveness you show in the RefineModalExampleSearch.online-video-cutter.com.mp4 ? If it can be done in a slick way using template conditional markup for example then could we add it to the exampleSearch component while we're at it?

Yes this can be done in a slick way👌 We just need the components needed to achieve this which are the QuanticRefineToggle and the QuanticRefineModal. I'll open PRs for these two components after merging this one.
Then I'll do a separate  PR to update the responsiveness of the exampleSearch component.


Wrong path for injectJs()

I have file structure similar to
- lib
-- inject
--- inject.js
-- scrape.js
- app.js

Then I call
app.js
var scrape = require('./lib/scrape');

scrape.js
page.injectJs('./inject/inject.js');

And it doesn't work. It works only if I set path to inject.js from root, that seems totally non-intuitive
scrape.js
page.injectJs('./lib/inject/inject.js');

This makes sense why it doesn't work. All of this is passed to phantomjs via command line. You should use __dirname when you can.


WIP changes for track recording issues

Summary:

Handling internal service timeout - using goroutine in service.handleRequest
Ignoring buffer too small error on RTP read
Extra logging
Some changes to create docker image

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Does using aiohttp_utils mean I must deploy my app with Nginx+Gunicorn?

Hi,
while I was investigating the other issue I had, I saw in an error traceback that aiohttp_utils actually uses GunicornWebWorker internally:

File "C:\ProgramData\Anaconda3\envs\sensor_gateway\lib\site-packages\aiohttp_utils\runner.py", line 20, in
from aiohttp.worker import GunicornWebWorker as BaseWorker

Does this mean that I will only be able to deploy my application on Nginx+Gunicorn? Meaning this limits my deployment options to just one from the 3 deployment ways listed in aiohttp's deployment documentation section?
I saw in that part of the documentation that Nginx+Gunicorn as deployment option can be slightly slower. My app, due its use case, must be FAST.

No, this library does not prescribe which web server you use in production. The now-deprecated runner module used Gunicorn, but that was only meant to be used in development environments.


YARN-5604. [Federation] Add versioning for FederationStateStore.

JIRA: YARN-5604. Add versioning for FederationStateStore.
We will add version information to Yarn Federation StateStore, this pr contains a basic framework, only contains method definitions, refer to RMStateStore.

@goiri Can you help review this pr? Thank you very much!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
17m 34s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 55s

trunk passed

+1 :green_heart:
compile
3m 53s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 20s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
1m 49s

trunk passed

-1 :x:
javadoc
0m 48s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 23s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 22s

trunk passed

+1 :green_heart:
shadedclient
24m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 39s

the patch passed

+1 :green_heart:
compile
3m 45s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
3m 45s

the patch passed

+1 :green_heart:
compile
3m 12s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 34s

the patch passed

-1 :x:
javadoc
0m 41s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m  7s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 22s

the patch passed

+1 :green_heart:
shadedclient
24m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  5s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
98m 12s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

234m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5394/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5394

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2ec4fc141b03 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / aa89fdf289c1de594f325a97a598b1f5ecba8489

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5394/1/testReport/

Max. process+thread count
949 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5394/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 48s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
32m  6s

trunk passed

+1 :green_heart:
compile
4m 11s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 32s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 19s

trunk passed

+1 :green_heart:
mvnsite
1m 45s

trunk passed

-1 :x:
javadoc
0m 48s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 20s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 30s

trunk passed

+1 :green_heart:
shadedclient
24m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 44s

the patch passed

+1 :green_heart:
compile
3m 59s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
3m 59s

the patch passed

+1 :green_heart:
compile
3m 19s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 19s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 33s

the patch passed

-1 :x:
javadoc
0m 40s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m  7s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 32s

the patch passed

+1 :green_heart:
shadedclient
24m 48s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 10s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
98m 43s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

235m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5394/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5394

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 678513de4457 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e112dcc1d60e00236f473e0b92702ce820015b55

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5394/2/testReport/

Max. process+thread count
944 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5394/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 54s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 12s

trunk passed

+1 :green_heart:
compile
3m 54s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 21s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 16s

trunk passed

+1 :green_heart:
mvnsite
1m 48s

trunk passed

-1 :x:
javadoc
0m 48s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 22s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 25s

trunk passed

+1 :green_heart:
shadedclient
24m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 39s

the patch passed

+1 :green_heart:
compile
3m 45s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
3m 45s

the patch passed

+1 :green_heart:
compile
3m 12s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  2s

the patch passed

+1 :green_heart:
mvnsite
1m 32s

the patch passed

-1 :x:
javadoc
0m 41s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m  8s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 26s

the patch passed

+1 :green_heart:
shadedclient
24m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  8s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
98m 11s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

231m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5394/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5394

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux bba3aa14e739 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 998dadd61c347e093737ed46b8b3ccba4abc62de

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5394/3/testReport/

Max. process+thread count
964 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5394/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Can you help review this pr again? Thank you very much!

@goiri Thank you very much for your help in reviewing the code!


Fix for userlist

This works for me that doesnt have any local users (FreeIPA/Active Directory setup). Would also work for local users.

Okay, i've created a check that checks /etc/login.defs to ensure we only get human like users (except root).
Any users that arent a system user should now safely show up.
But if the userlist is empty, that drop down list should not be a dropdown list, it should be a text field.

But the application will still fail if the userlist still comes back empty (...)

This should never happen, unless someone creates a new user w/o the -m argument. For sure not on nwg-iso, which the greeter was written for. Users created during installation have their home dirs and are visible on the 1st run.


Flag to show how much ram and cpu acs is using

This would require hooking into the daemon?

Yea, we could probably have the daemon call something to check the usage

it might help with testing and benchmarking

and would be fun

Perhaps we should make its own issue called something like "hooking into daemon" because I can think of so much more stuff we would want to grab from the daemon (for example recent gov changes, uptime, etc)

Yea, we can do that


Add core API for password authentication

BothcqlshandJDBC(SQL) clients ask for username/password on the client side, but there's no authentication API defined in Stargate core that allows validating passwords (without creating tokens).
It would be nice to add an API specifically for validating username/password combinations.

Would need to be rethought if this is needed, or something similar, how and so on. Closing this issue since there are no current on-going plans.


protectedRoute middleware protects routes not currently being called

Issue
The protectedRoute middleware appears to be blocking requests to routers even if the same protections are not applied to those routers. This only happens if the routers with stricter role protections come before other routers.
For example:
app.use(`/api`, protectedRoute(), router1);
app.use(`/api`, protectedRoute(['admin']), router2);

This is fine.
If we are trying to hit /api, Route 1 sees that there is a key and the request is handled there. We never get to Route 2.
If we are trying to hit /api, Route 1 sees that there is a key and lets the request pass by, then Route 2 either sees the user has the admin role and handles the request or rejects it or lacking the role.
app.use(`/api`, protectedRoute(['admin']), router2);
app.use(`/api`, protectedRoute(), router1);

This order doesn't work.
Requests to Route 2 work as expected, but the request to Route 1 seems to get screened based on the requirements of Route 2. If the user doesn't have the Admin role when accessing Route 1, the request appears to get rejected with the following message:
{
  "error": "User must have all of the following roles: [admin]"
}

Expected
Assumed that each route would be validated on an individual basis only if that route was accessed. Routes not currently being accessed should not have their validation checked.
Temporary(?) Workaround
If you specify unique route paths in express.ts, the non-called routes are never checked.
app.use(`/api/route2`, protectedRoute(['admin']), router2);
app.use(`/api/route1`, protectedRoute(), router1);

This works fine.

This seems like a limitation of express. I wouldn't use the same route twice and would opt for the unique route approach. There is possibly other options for using the middleware within the router instead but I'll have to do some experimentation.
At the least I can try to update the readme to make this more clear.


Create CHANGELOG.md file

We should have a changelog file with each version's release notes and breaking changes

Closed in v1.0.0-rc.1


pretrained models

@dingmyu hi,
were the pretrained models uploaded such as for the imagenet and cityscapes.
can it run inferencing using cpu-only
can hr-nas detect small objects

Hi,

The pre-trained model is currently unavailable. Please stay tuned.
The searched model can run in CPU-only mode, but its efficiency (which cannot run in real-time) will be much slower than GPU.
Sample images can be found in the paper. We have not evaluated the performance of detecting small objects because HR-NAS aims to search for efficient models.

Thanks,
Mingyu

last question here:

have you considered pruning the final efficient models, inorder to reduce the flops and parameter?
have you considered exporting to onnx so it can run on arm devices such as raspberry pi?

last question here:

have you considered pruning the final efficient models, inorder to reduce the flops and parameter?
i can send you some links to interesting spare pruning methods if you want.
have you considered exporting to onnx so it can run on arm devices such as raspberry pi?

Hi,

The search algorithm of HR-NAS is based on pruning. And we tried to manually reduce some channels of the searched model, the accuracy drops a little.
We have not tried the model on chips or arms and do not have the plan of exporting to onnx, thanks. PR is welcomed.

Thanks.

thanks


implement way to "jump" one (or two?) levels of vars

$(v.city) vs $(V.city) or something like that...

it's already implemented... $(gv.city)... $(dv.city)...


Improve Stripping Support

These changes allow Anvil to support the highest level of bytecode stripping built into Unity and makes the existing stripping defences more targeted to the exact types that require it.
What is the current behaviour?
When building a project that's using Anvil with Managed Code Stripping set to Low or higher the build will throw exceptions.

All of the delayed execution update sources (Ex: UnityFixedUpdateSource) do not have default constructors
UnityLogHandler is not found as the default log handler.

What is the new behaviour?
Fix Update Sources
Each concrete implementation of an update source now has a default constructor defined decorated with [RequiredMember] .
https://docs.unity3d.com/2021.3/Documentation/ScriptReference/Scripting.RequiredMemberAttribute.html
This prevents the default constructor from being stripped when the update source is referenced in the project.
Note: I did attempt to use RequireDerivedAttribute but it didn't drag along the default constructor.
Fix UnityLogHandler
This is an oversight from #70 where link.xml wasn't updated to reflect the new assembly name.
While fixing the issue I decided to migrate away from using link.xml and specifically add [Preserve] attributes to the log listener and log handler implementations.
The advantage to this approach:

Other unused logging types may be stripped rather than all being included even if not required.
Not affected by renaming assemblies

Note: Unfortunately we couldn't use RequireImplementors because these attributes are Unity specific and the interfaces are defined in anvil-csharp-core.
What issues does this resolve?
Resolves: #47
What PRs does this depend on?

None

Does this introduce a breaking change?

[ ] Yes
[x] No

The changes make sense to me, but what do empty constructors have to do with build stripping anyway?

Stripping can be pretty aggressive. If it determines that a type is never instantiated by its default constructor it will strip that constructor away. It'll also strip out unused interfaces, methods, and attributes.
I found out that default constructors were being stripped off the update sources when I enabled stripping on my project.
In the future, the work done for #72 or a specific test after completing #73 will catch these issues at merge time.


Message: Curl error: Failed to connect to mail.xxx.lk port 443: Timed out

Version (e.g. 1.0, dev-master):
PHP version: 5.6
Microsoft Exchange version: 2013 SP1
Description of problem:
I am using this for send email via Exchange Server.  I am using code in php-ews/php-ews/examples/messag/ecreate.php. But I an not give any port like 443. But it gave the error mentioned in heading.
I provided below values in php-ews/php-ews/examples/messag/ecreate.php.
$host = 'mail.xxxx.lk';
$username = 'xxxxx';
$password = 'xxxxx';
$version = Client::VERSION_2013;
Example request:

Example response:

Additional details:

As user credentials are passed as plain-text, this library only supports the HTTPS protocol, which uses port 443. You must have this enabled on your Exchange server.


Creating files for previously existing binaries

Apologies if this is the wrong place to be contacting you but I'm new to both Obsidian and Github so I wasn't sure of the protocol.  I installed this on my main vault, a Windows PC, yesterday, tested it with a new image file and it worked great.
This morning I found I couldn't open my iPad or iPhone Obsidian apps, or rather they took time - 8 minutes for the iPad. When I got into the iPhone one I discovered 2000+ new notes in my Inbox (where I'd set Binary File Manager to create new notes). The iPad wouldn't open at all.  When I then went to the main vault on the PC I find it still generating new notes.  I'm guessing it's generating a note for every image and PDF in my _resources folder.
I'm just unsure what to do next.  If I delete these once they're created, will it just start creating them again?  I wonder how Obsidian Sync will affect it - will the iOS devices keep creating new notes and syncing them to the main vault?
What I want is for Binary File Manager to operate only with new binaries, from the day I install ed it. That's what I assumed it would do. Perhaps I've made a mistake with one of the settings?
UPDATE: I deleted the newly made notes from my Inbox. (I couldn't do it in Obsidian because multiple file deletes don't work, but did it outside in Windows File Manager.) When I reopened Obsidian it quickly restarted creating 2000+ notes for all the binaries in my vault. I've now disabled the plugin until I get advice on continuing.

@normanlamont
The current version generates a note for every image and PDF. To ignore existing files, you have to generate notes for them once and remove the generated notes. So could you try the following on your PC?

Enable Binary File Manager.
Execute command Binary File Manager: Create metadata for binary files not Binary File Manager: Create metadata for unlinked binary files. You may need to run the command several times until no new files are generated.
Remove the generated notes that you don't want.

Thanks for replying.
How do I execute the command in the way you say? I only have the 'Options' screen in Binary File Manager. Is there a command line somewhere?

I deleted all the files in File Explorer and set BFM auto detection to OFF but still every time I open Obsidian it creates new notes. This is creating a big issue for me in the synced versions on my phone and iPad as each time they are generated they get added there and as far as I can see there's no way to delete more than one note at a time on the apps.  (Not your problem, I know, I'll take it up with Obsidian).

Thanks for replying.  I did that but they keep filling up. I suspect it's not Binary File Manager that's generating them now, but they're being synced from my two mobile devices where they've all accumulated. I've shut down Binary File Manager until I can get an answer on the Obsidian forum on how to remove them from my mobile devices.

I've got rid of the files on the mobile devices, reinstated Binary File Manager and run it again. Everything seems to be under control and working fine. Thanks!


Announcement getAwesomeness()

I just created a repo, getAwesomeness.It gives a developer an option to have a consolidated view on all of the awesome awesomeness. Please let me know if it helps or not.

It's a really neat project you've got there. Keep up the good work!


build: Update device sdk to resolve issues.

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Codecov Report

Merging #353 (45f4a30) into main (98306d1) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   33.07%   33.07%
=======================================
  Files          19       19
  Lines        1808     1808
=======================================
  Hits          598      598
  Misses       1144     1144
  Partials       66       66

duplicate of depend-a-bot PR


Bug Fix, Hats only "100" Options.

Fix for this: https://github.com/MyHwu9508/PlayVFreeroam/issues/1

We have added another fix for this issue.


mvcc/backend: exit on racey after-stop commit call

batchTx.commit(false) from newBatchTx
batchTx.commit(true) from stopping backend
batchTx.commit(false) from ongoing mvcc Hash call

would panic because *bolt.Tx.Commit in batchTx.commit
initializes *bolt.Tx.db and *bolt.Tx.meta as nil,
and subsequent *bolt.Tx.Size() call refers to this nil
pointer (panic).
Fix https://github.com/coreos/etcdlabs/issues/30.
/cc @xiang90

@xiang90 Added more test cases which all panic without this patch. Think they
To make it clear, this is only useful for projects embedding etcd server. If a project embeds etcd server, this panic would shut down the whole application. And there's no way to know in advance because etcd server stop method returns after calling backend.Close. https://github.com/coreos/etcd/blob/master/etcdserver/server.go#L667-L672

Why would an in-flight Hash break it but not an in-flight Get or Put?

@heyitsanthony I think same thing can happen in other in-flight RPC calls like get, put.
Hash just happens to be my use case in using embedded etcd servers. I periodically call
Hash to get states of etcd servers, and there seems to be no easy to prevent or shut down
in-flight Hash calls after stopping backend that internally happens in etcdserver.EtcdServer.run.

@xiang90 @heyitsanthony How about checking if db is nil without adding stopped field?
--- a/mvcc/backend/batch_tx.go
+++ b/mvcc/backend/batch_tx.go
@@ -162,7 +162,9 @@ func (t *batchTx) commit(stop bool) {
                if t.pending == 0 && !stop {
                        t.backend.mu.RLock()
                        defer t.backend.mu.RUnlock()
-                       atomic.StoreInt64(&t.backend.size, t.tx.Size())
+                       if t.tx.DB() != nil {
+                               atomic.StoreInt64(&t.backend.size, t.tx.Size())
+                       }
                        return
                }
                start := time.Now()