Adding private custom nodes in FlowFuse

Related Issue
No response
Description
Considerations:

Blog tile for: https://github.com/FlowFuse/website/pull/1177/files

Inspirations:

Verdaccio logo?
Node-RED logo
Extensibility
Protection of private code?

Would this make sense?

The word Private is missing before custom Nodes. Can you add it?

On 2 Oct 2023, at 17:04, Yndira Escobar @.***> wrote:
Would this make sense?
https://user-images.githubusercontent.com/129537638/272008328-42b9feb6-e548-4cee-87ec-24daaae3aade.png
—
Reply to this email directly, view it on GitHub https://github.com/FlowFuse/website/issues/1195#issuecomment-1743190834, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATJSO5QO5FMMXC4DMWT243X5LJYNAVCNFSM6AAAAAA5PJKU6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBTGE4TAOBTGQ.
You are receiving this because you authored the thread.


Fix the comment to be sure function name

Signed-off-by: seo,yeonghak<EMAIL_ADDRESS>

Sorry but these are not correct.
The doc strings follow go best practices of starting the comment with the name of the thing being documented.
Closing, but thanks for the submission!


Chrome Dev Tools Scope

Hello,
Firstly, thank you for this amazing tool. CodeSwing is a part of my daily development workflow. I use it all the time — especially when building-up Tailwind components and fiddling with all of those utility classes.
At one point in time, it seemed like the Chrome DevTools integration was working really well, but it now seems that when I use them, the DevTools scope is set to top — giving me VSCode's Electron context instead of the CodeSwing preview window. If I adjust this, it retains for a moment, but then jumps back to the top context as soon as I save my swing to render the next preview.
Is there something I'm missing or perhaps a setting I need to adjust? As this is a tool I use daily, I'm more than happy to troubleshoot and open a pull request, but before I start investigating, I figured I should first see if there's an easy fix.
Thanks!

Hmm, that's a good question. I didn't make any changes that would have impacted this, but it's possible that the VS Code WebView changed? Let me take a quick look, and see if I can figure anything out. Stay tuned!
// CC @egamma in case he's aware of anything that might have changed here

Thanks! My own config/extension setup hasn't changed, but I'll check in the interim with a fresh VSCode install to see if perhaps there's a conflict with another extension that I'm not seeing.

//CCing @deepak1556 @connor4312 for electron and debug insights.
@stephancasas can you please provide steps for how to reproduce the issue for someone that isn't familiar with the CodeSwing extension.

@egamma, after installing the extension, run the CodeSwing: New Swing... activity from the command palette:

Then, choose one of the pre-defined templates. Here, I'm using the HTML/CSS/JS template:

Next, use either the toolbar shortcut or the command palette to show developer tools, and use the context selector to choose the CodeSwing document/iframe component:

That last step is where the trouble begins. Traditionally, the inspector would immediately focus on the CodeSwing doc, and remain focused. However, as the CodeSwing doc is saved/updated, focus is lost, and the context of the console/devtools returns to the top scope.
Indeed, if we add some console.log() statements to script.js, and save/execute (with the preserve log option enabled), we can observe that the log messages originate from a different context each time.

This is assuredly due to the move to iframe based webviews. I don't see functionality in electron's public API to open the DevTools pre-scoped to an existing target.
Btw, the way we're assessing for the new Live Preview extension is using the Edge DevTools, which provide a remote browser preview in their VS Code extension. @codepo8 is the lead for that team. Maybe we can build infrastructure that's reusable for codeswing? (cc @andreamah -- do you know who will be taking over the Live Preview extension after your internship ends?)

(cc @andreamah -- do you know who will be taking over the Live Preview extension after your internship ends?)

@connor4312 I believe that the vscode team as a whole will be maintaining the extension.

I am talking to a few people and it seems the live extension will stay with
VS Code, but we may take on others, like the old preview extension.
On Mon, Jul 26, 2021 at 5:59 PM Andrea Mah @.***> wrote:

(cc @andreamah https://github.com/andreamah -- do you know who will be
taking over the Live Preview extension after your internship ends?)
@connor4312 https://github.com/connor4312 I believe that the vscode
team as a whole will be maintaining the extension.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lostintangent/codeswing/issues/50#issuecomment-886826774,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAADJRC5ESFS75VED6ZA4KDTZWA6TANCNFSM5A7J6VSA
.

Yup the current apis from electron only target to the top-level document, however we maybe able to target a particular frame if electron connects to https://source.chromium.org/chromium/chromium/src/+/main:content/browser/devtools/render_frame_devtools_agent_host.h.  Created https://github.com/microsoft/vscode/issues/129437 to check feasibility in debt week.

We changed the behavior of Developer: Open webview developer tools when we moved to use standard iframes to host the webview. The command is intended to be used by developers who are building webview extension and we believe that using a single unified developer tools makes sense for that use case: https://github.com/microsoft/vscode/issues/129437#issuecomment-897889739
It doesn't seem like we can easily go back to the old behavior. I think connecting the edge dev tools sounds like a better approach for this use case, as presumably you could also then hide all the webview implementation details from users so that they just see their code


IBM FHIR Server CapabilityStatement is invalid #2436

Add implementation for the various Capabilities statements
Add FHIRPath validation to IT tests
Add configuration property for URL

Signed-off-by: Paul Bastide<EMAIL_ADDRESS>

An simpler way to check a boolean evaluation result would be:
Collection<FHIRPathNode> result = evaluator.evaluate(evaluationContext, "(kind != 'instance') or implementation.exists()");
assertEquals(result, SINGLETON_TRUE);

Where SINGLETON_TRUE is in com.ibm.fhir.path.evaluator.Evaluator and works well as a static import (along with SINGLETON_FALSE).

Do you want me to update the test?


Don't show SOC on Pages

Describe the bug
After an update to Venus os 3.0 the SOC wasn't shown on Pages. It was shown in the Menu under BMS, and the BMS was correcly connected too. Also the SOC weren't in the VRM Portal
How to reproduce

Run clearly in Venus os 2.9.3
Update to Venus os 3.12

Expected behavior

Driver version
1.0.20230631
Venus OS device type
Raspberry Pi
Venus OS version
3.12
BMS type
JKBMS / Heltec BMS
Cell count
16
Connection type
Serial USB adapter to RS485
Config file
[DEFAULT]

; If you want to add custom values/settings, then check the values/settings you want to change in "config.default.ini"
; and insert them below to persist future driver updates.

; Example (remove the semicolon ";" to uncomment and activate the value/setting):
MAX_BATTERY_CHARGE_CURRENT = 100.0
MAX_BATTERY_DISCHARGE_CURRENT = 140.0

CVCM_ENABLE = False
CCCM_SOC_ENABLE = False

Relevant log output
@400000006559da2d2a436f64 *** CCGX booted (0) ***
@400000006559da2e18ce45ec *** starting serial-starter ***
@400000006559da2e27db839c serstart starting
@400000006559da2e285fd2b4 INFO: loading config file /etc/venus/serial-starter.conf
@400000006559da2f159afba4 INFO: loading config file /data/conf/serial-starter.d/dbus-serialbattery.conf
@400000006559da3035d57c8c INFO: Create daemontools service dbus-cgwacs.ttyUSB0
@400000006559da46356d5c4c INFO: Create daemontools service dbus-modbus-client.serial.ttyUSB1
@400000006559da482124b7e4 INFO: Create daemontools service dbus-cgwacs.ttyUSB2
@400000006559da4a01afc534 INFO: Create daemontools service mk2-dbus.ttyUSB3
@400000006559da4b051a09b4 INFO: Start service dbus-cgwacs.ttyUSB0 once
@400000006559da4d1286a33c INFO: Start service dbus-modbus-client.serial.ttyUSB1 once
@400000006559da4e24785f54 INFO: Start service dbus-cgwacs.ttyUSB2 once
@400000006559da500a320604 INFO: Start service mk2-dbus.ttyUSB3
@400000006559da531ef1c2b4 INFO: Create daemontools service dbus-serialbattery.ttyUSB1
@400000006559da5921d8aa4c INFO: Start service dbus-serialbattery.ttyUSB1 once
@400000006559db79038afd74 INFO: Create daemontools service gps-dbus.ttyUSB1
@400000006559db7f067e9af4 INFO: Start service gps-dbus.ttyUSB1 once
@400000006559db8825660b14 INFO: Create daemontools service vedirect-interface.ttyUSB1
@400000006559db8e286c84b4 INFO: Start service vedirect-interface.ttyUSB1 once
@400000006559db92047fb1fc INFO: Create daemontools service dbus-cgwacs.ttyUSB1
@400000006559db98078a715c INFO: Start service dbus-cgwacs.ttyUSB1 once
@400000006559db9d24fb2f9c INFO: Create daemontools service dbus-fzsonick-48tl.ttyUSB1
@400000006559dba3281fa11c INFO: Start service dbus-fzsonick-48tl.ttyUSB1 once
@400000006559dba704ffabb4 INFO: Create daemontools service dbus-imt-si-rs485tc.ttyUSB1
@400000006559dbad07ee6b1c INFO: Start service dbus-imt-si-rs485tc.ttyUSB1 once
@400000006559dbb01f8c7ffc INFO: Start service dbus-modbus-client.serial.ttyUSB1 once
@400000006559dbb739e15c24 INFO: Start service dbus-serialbattery.ttyUSB1 once

Any other information that may be helpful
No response

This is probably because under Settings -> DVCC -> Controlling BMS it did not select the SerialBattery as controlling BMS.

Thanks for the fast answer. I tried this and restart the driver/ reboot the pi, but unfortunately this didn't work

Check also what you selected under Settings -> System Setup -> Battery monitor.

Thak you very much. That fixed the problem


Allow i18n translation of collections used for radio and select inputs

Just 5 added lines enable to translate the values in a collection using a locale file in the following way:
en:
  simple_form:
    labels:
    placeholders:
    hints:
    options:
#     gender:
#        male: Male
#        female: Female
      user:
        gender:
          male: Male
          female: Female
#       edit:
#         gender:
#            male: Male
#            female: Female

I've seen in the user group that this feature has been requested by others.

Very useful pull request! We need this functionality!

Merged, thanks!


Does traefik support with etcd version 3 as the backend?

Does traefik support with etcd version 3 as the backend, if support and How to do?

It doesn't at the moment (2017-04-22) because the package used to abstract key value stores (libkv) has seemingly been  abandoned.  Folks involved with traffic are working on trying to get all of this fixed up though 1.
That being said, etcd3 does provide a 2.x compatibility API so you can still use the updated 3.x binaries with it.

@vdemeester any update on the libkv maintenance front?

I'll close the issue due to inactivity but feel free to re-open if needed.


Add 2D VHF Support

Add 2D VHF for the ability to study confined fluids.  This is very much a work in progress.

Most of the heavy lifting is done in MDTraj, but the 2d VHF has two additional arguments:

cutoff: This is an array of len(2) that will slice an MDtraj trajectory within a certain range of coordinates
coords: This is an array of bools that correspond to x, y, and z coordinates.  This indicates which 2 coordinates get looked at in the 2D RDF.

Also added several unit tests to check that the the function works, and that appropriate ValueErrors get raised.


Feature request (FR): ability to print python interactive window content

Hi,
It'd be great if we could print the entire python interactive window content with 3 options:

cell inputs hidden
cell inputs shown collapsed
cell inputs shown expanded
Great for generating ad-hoc reports for business and/or saving output for oneself while algo designing/prototyping.

Ideally, this extension would first implement hide input cells option, i.e. the 3rd one along with already existing 2 (collapse/expand input cells), so that printing option would simply just print what's already shown in the interactive window. Input cells are informative, but would look unprofessional in a report produced for business folks.
This feature would be one great enhancement! Thanks in advance.
Environment:
Windows 7 SP1 64bit Home Premium
VSCode v1.33.0
Python 3

The line "Great for generating ad-hoc reports ..." applies to all three points and not only to the 3rd one as incorrectly shown P.S. Can't edit the original post for I'm using FFox - admins, feel free to edit (just insert a blank line after point 3 to make it new paragraph) and delete this msg. Thanks.

Perhaps a feature to export the content in the Interactive window into PDF files?

@ronglums There are plenty of pdf printers available, I have one installed, so classic printing would be pdf export as well. But if pdf export would be easier to implement for whatever reason, I'd be fine with that too.

I can't find a print command in jupyter itself, but I can find Print Preview. That opens a new tab with just the cells and output in it. From there I suppose you use the browser's print functionality. Otherwise exporting to PDF is on our roadmap.

@greazer I'm looking for print functionality in VSCode and not jupyter. Optimization and other types of runs I do in my work generate tons of output (charts and calculations) that would not work in a browser. Print functionality is the weakest part of VSCode at this point. Most Data Science work requires runs output to be captured either for analysis or data reporting, and it's a shame that VSCode does not have that.
I guess most people that add features to VSCode are devs, and they don't have a need to output data analysis or data reports as often as DS people do - hence this feature request is left ignored.

@greazer Additional info if helpful: Currently, if I need to do a data analysis with results outputted and captured, I have to use Atom editor and pweave which redirects output into a html file which I then pdf print. Pweave - Scientific Reports Using Python ( http://mpastell.com/pweave/ ).
Now, pweave is abandonware and has bugs that author won't fix, but it's better than nothing. Hopefully, the way pweave works  will give VSCode team some ideas. I certainly hope that capturing output will be implement in a far more user-friendly way compared to pweave which is script/command-line driven.


Correct the info message when stop container

Signed-off-by: Lei Jitang<EMAIL_ADDRESS>The Info message Failed to send SIGTERM to the process, force killing is not correct
because user could specify a stop signal. we shoud replace SIGTERM  with StopSignal().

Oh, and if we want to use "stop signal" everywhere, we'll have to address some docs too; https://github.com/docker/docker/search?utf8=✓&q=SIGKILL

@thaJeztah  ha, I think those docs should be updated when adding --stop-signal :)
I'll update the relate docs if we agree to using stop signal every where

SGTM

LGTM moved to doc review @thaJeztah

This is a good catch. I did not know a different signal can be specified as the stop signal.

LGTM

LGTM


Allow use of operator-> with huffman::table::const_iterator

Replace use of views::transform with a custom view type
detail::base_view<V, B> that casts a derived type (i.e. elements of
view V) to base B.
detail::base_view<V, B> requires the reference type of underlying view
V be a true reference, thus detail::base_view<V, B>::iterator
defines operator-> to return a pointer to B*.
resolves #49
Change-Id: I2c9d14705bd5a0d8f7e562006913906d40c7fe86

I didn't document much. The implementation of detail::base_view::iterator is largely boilerplate.

If this is blocking you from doing something else feel free to merge it in but I'd rather discuss it first, maybe next week.
1. I'd like to understand it

2. I don't think it's actually worth all the added code, given that the table const_iterator is just an implementation detail of our library.

Yeah let's wait. Hopefully I can convince you otherwise after chatting about it :)


Allow input fields in modal

This request gives the ability to provide basic input fields within the modal and the results returned as part of the action function.  Readme and version updated.

@centogram Can you please point to where in the readme I can see how to use this? and how it looks?

An example of how to use the changes are in the snippet below.
The 4 new areas are:

fields  (name, label, value and placeholder can be passed)
an optional validate parameter can be added to a button
a destroyed callback when the modal is dismissed
backdropDismiss parameter  If true, the modal will be dismissed when the backdrop is clicked.

this.$modal.show({
    type: 'danger',
    title: 'This is the title property',
    body: 'This is the body property.  Lorem ipsum, dolor sit amet consectetur adipisicing elit. Eius aliquam laudantium explicabo pariatur iste dolorem animi vitae error totam.',
    primary: {
      label: 'Primary Action',
      theme: 'red',
      action: () => this.$toast.success('Primary Button clicked'),
      validate: (fields) => {
        if (fields.last && fields.last != '') {
          return true;
        } else {
          this.$toast.show({
            type: 'danger',
            title: 'Error',
            message: 'Last Name is required',
          })
          return false
        }
      }
    },
    secondary: {
      label: 'Secondary Button',
      theme: 'white',
      action: () => this.$toast.info('Clicked Secondary'),
    },
    fields: [
      {
        label: 'First Name',
        name: 'first',
        value: "My First Name"
      },
      {
        label: 'Last Name',
        name: 'last',
        placeholder: "Enter your last name",
      }
    ],
    backdropDismiss: false,
    destroyed: () => {
      console.log("modal was closed");
    },
  })


feat: add article counts for logged in users

:tada: This PR is included in version 0.25.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bump nodejs-sf-fx-buildback to new 1.5.7 release

Latest Functions buildpack.

Closing in favor of PR#104


Master - upgrade EF Core to 3.1.3 and CsvHelper to 15.0.4

A PR to upgrade EF Core to 3.1.3 and CsvHelper to 15.0.4
All test cases were run successfully.
I would appreciate if you accept this PR.
Thank you.

@IoTFier Looks good! Only one minor comment, so if you can fix that, I'm happy to merge your PR.
Thanks a lot for this!

@IoTFier Merged. Thanks, great work!

@IoTFier Package published. Cheers!


[HOLD for payment 2022-11-02] [$250] Web - Workspace - Invited user is displayed without a username and an avatar image

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to URL https://staging.new.expensify.com/
Login with any account
Go to Settings->Workspace->Manage members
Kill internet connection
Invite a new member (you should not have had any communication with him before)
Turn on internet connection

Expected Result:
The invited user should be displayed with a username and avatar image without refreshing the page
Actual Result:
Invited user displayed without a username and avatar image
Workaround:
Unknown

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/195673478-bcf6a373-2955-4683-84ed-e2f033cc3ae5.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

I dont think this is necessarily a bug, if you are offline you cannot get the username of a user you havent chatted with before. We could use default avatar. cc @neil-marcellini for your thoughts as you worked in this area i believe

I think it's a bug, but the expected result should be clarified. Yes we should show a default avatar and the email, just like it shows in the options selector and LHN.
cc @chiragsalian since he worked on AddMembersToWorkspace.

I agree with the avatar, the email is already shown correctly.
Just not sure if there is already some fix in motion, so thanks for tagging Chirag 🙇

Ah yup part of it looks like a bug,
Not a bug - we definitely cannot get username information and their actual avatar when offline.
A bug - we should be showing default avatar when we don't have actual avatar information. This should be addressed in this issue.
My plate is a bit full so I'm not taking this on but it should be straightforward to test and fix locally.

I think this can be external, right? The optimistic action is handled in App where also the default avatar should be added

Yes it can definitely be external 🙂

Proposal
When offline after inviting members to the workspace, the personalDetails data from Onyx is not updated.
https://github.com/Expensify/App/blob/62394cca18424fafe09c046fa63199d98696cc49/src/pages/workspace/WorkspaceMembersPage.js#L293
We get the member info from the personalDetails, so in this case, because we can't find the email just invited in personalDetail we add a default value to displayName and login but not with the avatar.
Solution
Rather than checking network status, we can add a default avatar together with displayName and login.
diff --git a/src/pages/workspace/WorkspaceMembersPage.js b/src/pages/workspace/WorkspaceMembersPage.js
index 5e00fdce8..22e641f03 100644
--- a/src/pages/workspace/WorkspaceMembersPage.js
+++ b/src/pages/workspace/WorkspaceMembersPage.js
@@ -15,6 +15,7 @@ import ScreenWrapper from '../../components/ScreenWrapper';
 import withLocalize, {withLocalizePropTypes} from '../../components/withLocalize';
 import compose from '../../libs/compose';
 import * as Policy from '../../libs/actions/Policy';
+import * as ReportUtils from '../../libs/ReportUtils';
 import Button from '../../components/Button';
 import Checkbox from '../../components/Checkbox';
 import Text from '../../components/Text';
@@ -290,7 +291,7 @@ class WorkspaceMembersPage extends React.Component {
             if (email !== this.props.session.email && email !== this.props.policy.owner) {
                 removableMembers.push(email);
             }
-            const details = this.props.personalDetails[email] || {displayName: email, login: email};
+            const details = this.props.personalDetails[email] || {displayName: email, login: email, avatar: ReportUtils.getDefaultAvatar(email)};
             data.push({
                 ...policyMember,
                 ...details,

Result
https://user-images.githubusercontent.com/25520267/196016581-e1b5ef98-ed03-475f-9c89-9997a977cb21.mov

Thanks a lot for the proposals @Uros787 and @mollfpr, but I had issues to get both of them working fine.
@Uros787 In your video it seems to be working fine, but when I applied it, it only loads the profile picture after I reconnect to the internet. If I am offline, it showed empty avatar to me. Can you verify if you've added all the details for the change?
@mollfpr Your proposal loaded the display avatar in all cases, but the moment I switch from offline to online, it changed the avatar color. Did you come across this issue at your end?

@mananjadhav It's because the avatar that we get from the server and what we set in the App with getDefaultAvatar has a different value.

In this example, the avatar that we get from getDefaultAvatar is https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/avatar_8.png while from the server is https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/avatar_1.png

I haven't been able to get both the proposals working.  @mollfpr proposal works for me but I feel switching the avatar colors from offline to online is not a good experience.
I am wondering if while the user is added offline, we should show a greyed avatar only and then when it switches online, it could load from internet (user's actual dp or fallback to one of the colored avatars)

@shawnborton Would you be able to help us decide on the look of the default avatar here? If user is invited to a policy offline, we currently dont show any avatar, which is a bug. I think we should be good y showing a grew default avatar in this case as that align with the offline optimistic nature.
Would you be bale to confirm this? Dont wanna make some assumption here which we would have to change later. Thank you!

I'm cool with using a gray avatar when the user is offline. I think we already have that asset in the repo as well.

Thanks

@Uros787 Your last proposal is similar to @mollfpr 's proposal.
Anyway I prefer to set the default value when we set the object.  I am fine with @mollfpr's proposal here with the value to set greyed avatar.

@mollfpr Feel free to raise the PR
Thanks @mananjadhav for the review.

@mananjadhav @mountiny PR is ready 🚀

Bump @mountiny for the Upwork link

@mateocole can you please help with the payment for @mollfpr ? Thank you 🙇

Issue not reproducible during KI retests. (First week)

Bump @mateocole

@mountiny @mateocole Can you expedite please? It is 4 days overdue the payment date.

Asking for someone to step in here, sorry for the delay

Hello! I'll get going on this NOW

Upwork: https://www.upwork.com/jobs/~012e8c7dcb621a9da7
cc @mananjadhav @mollfpr

@dylanexpensify Applied, thank you!

Offer sent @mollfpr !

Done @dylanexpensify

Offer sent @mananjadhav !

done. @dylanexpensify

Payments sent, contracts ended, job posting closed! Thanks everyone!


Tests for getSelectedHref

@cjwirth relates to #25

To run the JS tests, simply open rich_editor_tests.html


Puppeteer startup question

yo yo
for lack of a better communication method I'll use issues :-)
 if (process.env.CI) {
        arguments_.args.push(
          `--disable-extensions-except=${metamaskPath}`,
          `--load-extension=${metamaskPath}`,
        );
      }

just curious... any reason for adding this snippet to plugins/index.js? I see that Synpress doesn't do that.

Hello. The main reason was the folllowing: https://stackoverflow.com/a/67050433

Gotcha! I don't think it actually does anything...
Anyway, I've decided to simplify whole setup and instead of interacting with MetaMask via Puppeteer inject a mocked window.ethereum object (which is where MetaMask is injected by the extension) and interact with it programmatically. That way I can get rid of Puppeteer and have the tests executing faster and more reliable. Plus, there's no need to hack Cypress anymore :-)
Lmk if you're interested in some info!

send a PR so i can take a look and test.

I thought a bit about it and I think I will try to add support to mocked function onto the cypress. I will read the documentation to start with.


Fix Issue 1753

Description

Add a note to the devenv setup doc with an explanation of the problem and possible solution.
Motivation and Context

Fixes #1753
How Has This Been Tested?

NA
Checklist:

[x] I have added a Signed-off-by
[x] Either no new documentation is required by this change, OR I added new documentation
[x] Either no new tests are required by this change, OR I added new tests
[x] I have run goimports, go vet, and golint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives.  The goal is clean, consistent, and readable code.

Signed-off-by: Arnaud J Le Hors<EMAIL_ADDRESS>

reverify jenkins

Thanks, LGTM


implied tokens create incomprehensible error messages

code like
foo a b:1
creates a incomprehensible error, cause the implied unexpected { is never explained as such
it would be much better if it reported that the implied { came after a and what tokens where expected

Unable to replicate: http://coffeescript.org/#try:foo a b%3A1

my misstake, a should have been a string
http://coffeescript.org/#try:foo 'a' b%3A1 exposes the problem

Fair enough:
foo 'a' b:1

should be an error, but that error shouldn't say "Unexpected {", since there is no {.
Perhaps more generally, we could replace the message "Unexpected {" with "Unexpected object literal"... what does @michaelficarra think?

Ummmmmmm. That sounds fine.

Related: http://lambda-the-ultimate.org/node/4439


Proof of concept: calculations and variables

Proof of Concept for Discussion

Supports calculations by adding a variables store and allowing for reference of these variables from within components
Adds CalcInput, CalcSubtotal, and CalcTotal components which provide formatting for displaying values in financial summary style
CalcInput includes Excel cell-style formatting for editing values
Uses Svelte reactivity to update calculated results immediately on the page

Drawbacks & Considerations

Syntax is not very clean or simple
There is likely a better way to format inputs to make it more apparent that they are editable and that they will impact the calculated cell results immediately, but need to keep in mind print and PDF formatting
We may want to extend these concepts into a broader Evidence "modeling" feature which allows users to include elements like number inputs and calculations into a formatted "model"
This would introduce the need for input-level value formatting
May introduce the need for session-level caching eventually (i.e. if someone changes an input value on a page, should it save for the next time they come back?)

This is really nice.

Syntax is not very clean or simple

I like this approach with stores. IMO This is way better than having to declare in a script tag. I think $input.name might be easier to understand than $variable.name since it lines up with the naming of the component/ props.

We may want to extend these concepts into a broader Evidence "modeling" feature which allows users to include elements like number inputs and calculations into a formatted "model"

Playing with this, I think there are a few other cases where we could extend these ideas:

Use this store approach to add client-side filters for query-results <Filter query={query_name} column=region result_name=filtered_query_name/>  - uses the type and extents of the column to present a filter.
Things that aren't inputs into a spreadsheet style presentation, and more of a UI style input. E.g. a slider to control where a reference line is being set on a chart, that type of thing.

May introduce the need for session-level caching eventually (i.e. if someone changes an input value on a page, should it save for the next time they come back?)

I think you could get away without it for v1. I kind of expected a page refresh to get me back to the defaults. I think if you did preserve these for the user, you'd also want a "reset" button.


Falback to OLD_OS_URL

Coverage remained the same at 91.017% when pulling 57b92baf74681c74bc433b2ee6c9f856a4970900 on RickCarlino:calculate_upgrade into b955060966b3b522da836a502d1b1ffea0cff816 on FarmBot:staging.

Coverage remained the same at 91.017% when pulling 57b92baf74681c74bc433b2ee6c9f856a4970900 on RickCarlino:calculate_upgrade into b955060966b3b522da836a502d1b1ffea0cff816 on FarmBot:staging.


Unable to set dynamic provisioned concurrency using serverless.ts

Instead of using serverless.yml files we use serverless.ts files since our code is written in typescript and we wanted to keep things consistent. However this has caused a problem with being able to dynamically set the number of provisioned concurrency on deployment. We need this functionality as we do not need as much, or any, provisioned concurrency in non-production but do need it for production. Below is a snippet of our index.ts file for our helloworld lambda using serverless framework.
import schema from "./schema";
import { handlerPath } from "@libs/handlerResolver";
import { getProvisionedConfig } from "../../../provisionedConfig";

export default {
  handler: `${handlerPath(__dirname)}/handler.main`,
  provisionedConcurrency: parseInt("${self:custom.envConfig.helloProvisionedMin}"),
  // provisionedConcurrency: getProvisionedConfig().HELLO_PROVISIONED_MIN,
  concurrencyAutoscaling: {
    // attempted loading variable directly from serverless.ts file and also setting provisionedConfig.ts file for vars but neither worked.
    enabled: !!"${self:custom.envConfig.helloProvisionedAutoScaling}",
    // enabled: getProvisionedConfig().HELLO_PROVISIONED_AUTO_SCALING,
    alias: "provisioned",
    maximum: 100,
    minimum: parseInt("${self:custom.envConfig.helloProvisionedMin}"),
    // minimum: getProvisionedConfig().HELLO_PROVISIONED_MIN,
    usage: 0.75,
    scaleInCooldown: 0,
    scaleOutCooldown: 0,
    customMetric: {
      statistic: "minimum",
    },
    scheduledActions: [
      {
        name: "DailyAutoScaleOut",
        timezone: "America/New_York",
        schedule: "cron(0 9 * * ? *)",
        action: {
          maximum: 100,
          minimum: parseInt("${self:custom.envConfig.helloProvisionedMin}"),
          // minimum: getProvisionedConfig().HELLO_PROVISIONED_MIN,
        },
      },
      {
        name: "DailyAutoScaleIn",
        timezone: "America/New_York",
        schedule: "cron(00 01 * * ? *)",
        action: {
          maximum: 10,
          minimum: 1,
        },
      },
    ],
  },
  events: [
    {
      http: {
        method: "post",
        path: "hello",
        request: {
          schemas: {
            "application/json": schema,
          },
        },
      },
    },
  ],
};

We end up seeing this message in the serverless deploy output "Skipping Provisioned Concurrency Auto Scaling: Concurrency configuration is missing!" and the cloudformation template does not have any references to autoscaling. It appears no dynamic values will work but hardcoded values do, however that does not meet our use case.
I also attempted to set this directly in the serverless.ts file but have not been able to get that working either. Being able to dynamically set provisioned concurrency autoscaling based on the environment being deployed to should be possible. How would we be able to accomplish this?

Hi @trent-dailey I am unable to recreate the issue you are experiencing. Is this still a problem? Here is the config I used to test.
➜  sls-dynamic sls -v
Running "serverless" from node_modules
Framework Core: 3.25.1 (local) 3.25.1 (global)
Plugin: 6.2.2
SDK: 4.3.2

import schema from './schema';
import { handlerPath } from '@libs/handler-resolver';

export const getProvisionedConfig = () => ({ MIN: 2, ENABLED: true });

export default {
  handler: `${handlerPath(__dirname)}/handler.main`,
  provisionedConcurrency: getProvisionedConfig().MIN,
  concurrencyAutoscaling: {
    enabled: getProvisionedConfig().ENABLED,
    minimum: getProvisionedConfig().MIN,
  },
  events: [
    {
      http: {
        method: 'post',
        path: 'hello',
        request: {
          schemas: {
            'application/json': schema,
          },
        },
      },
    },
  ],
};

Output:
➜  sls-dynamic sls package
Running "serverless" from node_modules

Packaging sls-dynamic for stage dev (us-east-1)
Configuring Provisioned Concurrency Auto Scaling...
 - Building Configuration for resource "lambda/hello"
Added Provisioned Concurrency Auto Scaling to CloudFormation!

✔ Service packaged (0s)

Thanks @claydanford. Was able to get around the issue by using the below syntax.
provisionedConcurrency: "${self:custom.envConfig.helloProvisionedMin}" as unknown as number,   concurrencyAutoscaling: {     enabled: "${self:custom.envConfig.helloProvisionedAutoScaling}",     minimum: "${self:custom.envConfig.helloProvisionedMin}"  as unknown as number,   },
This is what I had to do to get around the typechecking issues. I will close out this since this has been resolved.

@trent-dailey Thanks for the feedback. It looks like an issue with sls considering it is required by the built in provisionedConcurrency parameter also, which isn't part of the plugin.


locus should be a controlled vocabulary

Matches type for pcr_target_locus etc.

add keywords_study while we are at it.


[BUG] problems importing json prompt

i create a prompt generate video ok,  export prompt  ok, clear prompts  try to import same file or other and the browser  refreshes   opens an old site non related site  plus the SD local,  then  going back to infinite zoom  no prompt is imported   using  1.6   tried a number of time.
{
"prompts": {
"data": [
[
0,
"PHOTO OF BEGINNING OF UNIVERSE"
],
[
"3",
"PHOTO OF EARTH AND PLANETS  AND UNIVERSE AND STARS"
]
],
"headers": [
"Start at second [0,1,...]",
"Prompt"
]
},
"negPrompt": "",
"prePrompt": "",
"postPrompt": "DETAILED ART bY YERKA"
}
To Reproduce
Steps to reproduce the behavior:

Enter these inputs '....'
Click on '....'

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots of error
If applicable, add screenshots to help explain your problem. Or just dump the error.
Desktop (please complete the following information):

OS: [e.g. Windows]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

MAYBE BROWSER RELATED


Code owners

What are you changing?

adding specific code owners for project directories.

Why?

we're currently both unspecific and low on reviewers.

We've added two new teams @guardian/source (to review Source repos) and @guardian/csnx (to review CSNX config).

This looks great!

Thanks Max, we can always change things going forward but lets merge for now and see how it feels.


vectorized support array_repeat function to be compatible with hive syntax

Proposed changes
Support array_repeat function to be compatible with hive syntax
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.71 seconds
stream load tsv:          477 seconds loaded<PHONE_NUMBER>9 Bytes, about 149 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          76 seconds loaded<PHONE_NUMBER> Bytes, about 13 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230322213108_clickbench_pr_118945.html

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run p0

run buildall

run buildall


Controller 'mdHead', required by directive 'mdColumn', can't be found!

Hey,
I try to use md-data-table by building following html code:
<md-table-container>

	    Name
	    Stats
	    Total Amount

</md-table-container>

But I get following error:
Error: [$compile:ctreq] Controller 'mdHead', required by directive 'mdColumn', can't be found! http://errors.angularjs.org/1.3.13/$compile/ctreq?p0=mdHead&p1=mdColumn
I have imported all required files in index.html, injected my application with required modules. I have checked mdColumn and mdHead functions and directives from my-data-table.js just in case if there is typo, but I couldn't find.
How I could fix this?

I can't reproduce this. @FraGoTe was getting the same error in #252.
One thing you can try is moving the mdHead directive above the mdColumn directive in the source file to see if defining it first makes a difference. I don't think it will but if it does I'll make sure it gets defined first when I concatenate all the files together.

Hi Daniel,
Thanks for suggestion. I tried it but it didn't help. I still get the same error.

Okay, I found solution for this problem. I checked dependencies of md-data-table and I found out that it requires at least angularjs version 1.4.0 and I had 1.3.13. Now that I updated my angularjs version to most stable (1.5.0), the md-data-table renders correctly :).
It would be good idea to add notification in the description of README.md file that this module requires at least angularjs version 1.4.0.


Use csa specifc config or base config

          Let's switch to the base config.

Originally posted by @wilke in https://github.com/JDACS4C-IMPROVE/IMPROVE/pull/107#discussion_r1750930493

@wilke I think I tried that at some point but I didn't work for me See my comment here:
https://github.com/JDACS4C-IMPROVE/GraphDRP/blob/develop/csa_wf.py#L54


Make unit test output easier to read

When a unit test fails, the whole row shows as different from expected. For wide tables, this makes it difficult to parse where the difference was. The output should highlight which columns were different.

Closing this in favor of #1637


Updated configuration files relative to BCB battery in the experimental setup folder

This PR updates the configuration files in the experimentalSetup folder as the current ones do not work.
Corresponding PR: https://github.com/robotology/icub-main/pull/727
cc @randaz81

Merging in devel to be consistent w/ PR in icub-main.


Multi-domain support, ROOT_URL problem, use relative URLs in templates instead of absolute URLs

At the moment, Gitea users must set ROOT_URL correctly in app.ini, otherwise many URLs on the web UI will be wrong, which makes the web UI doesn't work properly (CSRF tokens and cookies can not work across domains)
The ROOT_URL must be set to the full URL which the users visit, with correct scheme(eg: https://the-gitea-domain/) and correct sub path if it is used (eg: https://the-gitea-domain/my-gitea-path/).
New code should always use relative URLs for Web UI.

Many maintainers have answered the issues about incorrect ROOT_URL again and again.
Using HTMLURL(and other absolute URLs) in templates is the root case that Gitea can only serve web under ROOT_URL.
That's why we have to force users to set ROOT_URL correctly.
If all URLs in template can be refactored to use Relative URL correctly, then we do not need to force users set ROOT_URL correctly again and again.
The ROOT_URL is still needed because for example, some webhooks need the absolute URL for external systems, and Gitea should show absolute URL on the UI for clone link, etc.
Related:

https://github.com/go-gitea/gitea/issues/14254
https://github.com/go-gitea/gitea/issues/17912
https://github.com/go-gitea/gitea/issues/17843
https://github.com/go-gitea/gitea/issues/19340
https://github.com/go-gitea/gitea/issues/19963
https://github.com/go-gitea/gitea/issues/6397 (5 up-votes!)
https://github.com/go-gitea/gitea/issues/8697  (19 up-votes!)
https://github.com/go-gitea/gitea/issues/20091
https://github.com/go-gitea/gitea/issues/20450

Some more related:

#20436 , after installation, Gitea may redirect user to an incorrect location.
#20089 , it may resolve the incorrect redirection problem during installation.

The PR to detect the problem:

https://github.com/go-gitea/gitea/pull/18971

+1, relative URLs also make configuration more flexible, and may even enable use cases like running on multiple domains. Thought IIRC, ROOT_URL still needs to stay in the config because sometimes absolute URLs need to be built, like for PR link when pushing via SSH. But it's good nonetheless to remove dependencies on ROOT_URL where possible.

We need a new global variable ROOT_URL_PATH, it could be / or sub path like /gitea.

As seen in https://github.com/go-gitea/gitea/issues/20450, dashboard repo links are one example of incorrect absoltute URLs.

First time I have tried gitea and find it surprising that there is no mentioned of this at all on the docs. The docs give an impression that the user can set the environment, but this is incorrect. I'll give a subset of examples, there are several more:
Documentation: Install with docker
To bind the integrated OpenSSH daemon and the webserver on a different port, adjust the port section. It’s common to just change the host port and **keep the ports within the container like they are**.

Gitea explicitly overrides links set by both a reverse proxy and the user. This advice an user to differentiate the environment inside and outside a container (which isnt a feature thats supported). It should be opposite, since the application will override configuration and proxy headers. The application should be as equal as possible to default environments from the gate rather than hardcoding it to differ. One example in the dockerfile from docs:
   **ports:     - "3000:80"     - "222:22"**

Documentation: Managing deployments with environemt variables
In addition to the environment variables above, **any settings in app.ini can be set or overridden with an environment variable** of the form: GITEA__SECTION_NAME__KEY_NAME.
This is pure misinformation as the application never properly supported configuration in this manner. The docs seems to be describing a roadmap of how it should end up to be, rather than the factual.
Documentation: Recommended server configuration
NOTE: Many of the following directories can be configured using [Environment Variables](https://docs.gitea.io/en-us/environment-variables/) as well! Of note, configuring GITEA_WORK_DIR will tell Gitea where to base its working directory, as well as ease installation.
If you follow the docs you will end up with a broken system. Then waste a lot of time until you find the source of misleading information.
More confusing examples:
DOMAIN: localhost: Domain name of this server.
So the hostname? myhostname.localdomain. So much ambiguity. lets assume "myhostname"
SSH_DOMAIN: %(DOMAIN)s: Domain name of this server, used for displayed clone URL.
must be "myhostname" due the above.

So what is the fix here? Refactor HTMLURL to return relative URLS and punt explicit absolute URLS to new config options like SSH?

So I think we need an ALLOWED_ROOT_URLS, which could have a glob matching. When a request to a disallowed root url, Gitea should return 404 or redirect to 404.
I found it's difficult to get the right root url in the backend because maybe there are some reverse proxies. So it's only done by frontend.
But ROOT_URL cannot be removed because some places need that. i.e. When sending an email, the link needs an absolute url. We can reuse ROOT_URL as the default value of that.

I do not think so. No more option is needed.   "When a request to a disallowed root url, Gitea should return 404 or redirect to 404." it not related to this problem, and it's never a real problem.
The proper solution is to refactor most HTMLURLs in templates to relative URLs.
And the global ROOT_URL is necessary and must, see the origin comment:

The ROOT_URL is still needed because for example, some webhooks need the absolute URL for external systems, and Gitea should show absolute URL on the UI for clone link, etc.

To explain why "mismatched ROOT_URL makes the web UI doesn't work properly": because the CSRF tokens and cookies can not work across origin. Users will be affected by: be redirected to a non-login site, failed to submit forms, etc.
I had a full plan about how to do the refactoring, but doing refactoring for Gitea is pretty difficult. Unless there are enough maintainers promised to support this refactoring, I do not have confidence to work on it.

I just hit this warning after upgrading an instance to 1.17 (from 1.15?) with ROOT_URL set to its FQDN (e.g. http://git.domain.local:3000/)
Now most users on this network get a DNS-suffix (e.g. domain.local) provided by DHCP who access the frontend using just the hostname (http://git:3000) for convenience who now get the warning about the supposedly "wrong" ROOT_URL:

Your ROOT_URL in app.ini is http://git.domain.local:3000/ but you are visiting http://git:3000/
You should set ROOT_URL correctly, otherwise the web may not work correctly.

Which doesn't make a whole lot of sense to begin with:
a ) The network-stack will always resolve the hostname to its FQDN using the provided DNS-suffix so this doesn't affect CSRF
b) This should probably not be checked on the client-site (using e.g. window.location)
Now, as a workaround, i could pipe gitea through a reverse proxy to redirect git to git.domain.local pointing A to the reverse proxy to get rid of the warning but this would ultimately break ssh unless i also add an ssh proxy.
So either ignore the warning in this scenario (option in app.ini?) or add the redirect to the build in webserver shipping with gitea as this is only affecting the web part anyway.
Cheers

If you are sure you can ignore the warning, there is a bypass method to hide the warning, see the FAQ in #18971 .

There is a specialized CSS class "js-global-error" for the error message, then end users still have a chance to hide these error messages by customized CSS styles.

Thank you very much, i found the PR after posting the comment.
$CustomPath/public/css/header.css:
.js-global-error {
    display: none !important;
}

$CustomPath/templates/custom/header.tmpl:
<link rel="stylesheet" href="/assets/css/header.css">

Hacky but it works :grin:

Thank you very much, i found the PR after posting the comment.
$CustomPath/public/css/header.css:
.js-global-error {
    display: none !important;
}

$CustomPath/templates/custom/header.tmpl:
<link rel="stylesheet" href="/assets/css/header.css">

Hacky but it works 😁

this is a wonderfully nice solution

To be clear: if you see the error message but you ignore it, you will run into problem.
Please DO NOT do so before Gitea has a clear solution, unless that you are very very sure about what you are doing and you can resolve all your users' problems. That's why I didn't make an option or provide any detail steps for hiding it.
I will hide some unrelated comments and edit to put some warnings in some comments.
For example, user login in https://git/ can not do preview if the ROOT_URL is https://git.domain/.

⚠ WARNING about ignoring the "inconsistent domain" message
To be clear : if you see the error message but you ignore it, you will run into problem.
Please DO NOT do so before Gitea has a clear solution, unless that you are very very sure about what you are doing and you can resolve all your users' problems. That's why I didn't make an option or provide any detail steps for hiding it.
I will hide some unrelated comments and edit to put some warnings in some comments, because if many users ignore the warning, there will be a lot of duplicate issues here reporting that "something doesn't work" (it happened before).
For example, user who log in https://git/ can not do preview if the ROOT_URL is https://git.domain/. They can not do inline PR comment either, there could be more similar problems. You can only ignore the error message if you are sure your users won't use these affected features on different domains.

Got it. Thanks for your very kind notice.

hi, how to force bind to only one domain name?
e.g. allow http://localhost  but disable directly access by ip: http://<IP_ADDRESS>

hi, how to force bind to only one domain name?
e.g. allow http://localhost but disable directly access by ip: http://<IP_ADDRESS>
if the ROOT_URL is https://git.domain/. how to forbid other users to visit it by https://git/ , if they both point to same IP address?

You can do that in reverseproxy.

thank you .
I want to achieve this without another proxy service like nginx.
there's a setting  Http_addr to bind IP, but not for bind host.
maybe I can modify template .tmpl page file to display blank page if detected ip

Another possibly-related issue here - I'm trying to set up my instance so that it's accessible independently in two ways:

via gitea.local, where DNS resolution happens directly on my router and no external Internet access is required
via gitea.my-domain-name.org, where DNS resolution and request routing happen via the wider Internet

Re-opening as linked PR only partially resolved this issue

Most problems in this issue have been addressed by  #21986, so I think it's good to:

Remove most ROOT_URL error messages on the page, only show it to site admin.
Close this issue
Open a new issue to follow remaining and new problems.


Added a progress bar to get feedback when the player is walking

Short Description:
Added a  progress bar to the console to view feedback when the player is walking.
Fixes:

Added a SYS progress bar which will work across environments

love it!

Currently we don't accept PR on the master branch. please submit to the dev branch.


[TRA1][W09-B1]

Good to see all you pitched in for this PR :+1: Don't forget to change your profile picture.


raidboss: add basic triggers for Angra Mainyu

Angra Mainyu is the first boss of The World of Darkness alliance raid.
This boss has a few instant-death mechanics, including some basic
mechanics that are very easy to add triggers for.
Add a trigger for the "Mortal Gaze" mechanic. When this is cast, players
should look away. If they fail to look away, they acquire the Doom
debuff and will die in 10 seconds unless they reach a cleansing circle.
Add an alert for the look away, and an alarm for when doom is acquired.
Add a trigger for the "Double Vision" attack. This attack is cast
periodically, and damages players based on their debuff. The whole arena
lights up half red and half white. If the player is hit by the red area
they gain Ireful, and if they are hit by the white area they gain
Sullen. Repeated hits of the same color do increasing damage until it is
fatal. Keep track of the current debuff and warn the player of which
color to stand in based on this.
In the future, it would be nice to add some alerts for Level 100 Flare,
Level 150 Doom, and possibly the roulette mechanic. These are more
complex and have been skipped for now.
Signed-off-by: Jacob Keller<EMAIL_ADDRESS>

I have no idea how to write a timeline file, so this currently lacks any timeline data. Just the basic triggers to help remind when to avoid mechanics.

Now I say front or behind, (confirmed on gites, the white/light/blue side is always front).
I also captured a mainTank string and use that to allow Double Vision to default main tank to start on white and everyone else start on red. I think that helps since it means people don't get a weird "why does this not pop up sometimes?" vibe.

I have no idea how to write a timeline file

Also, I am MORE than happy to walk you (or anybody) through how to make timeline files, especially for old content.  (I don't think it needs to be part of this PR, but just for future reference.)  There is a timeline guide, but the short of it is that you run util/make_timeline.  Then you massage the result into a timeline by ignoring noisy/inconsistent abilities, find loops, and space out each fight in a zone across time.

I have no idea how to write a timeline file

Also, I am MORE than happy to walk you (or anybody) through how to make timeline files, especially for old content. (I don't think it needs to be part of this PR, but just for future reference.) There is a timeline guide, but the short of it is that you run util/make_timeline. Then you massage the result into a timeline by ignoring noisy/inconsistent abilities, find loops, and space out each fight in a zone across time.

is there discord or some other place we could discuss this? I got a bit started but I think I am at a loss as to how to properly go past the first stage of just generating the timeline automatically..

The discord is the FFXIV ACT Discord (https://discord.gg/hK523Pj).  Feel free to ask in #overlay-discussion or find me by nickname and DM me there.


Manifest conversion fails on Stanford's collection

When using osullivan to parse Stanford's collection (from the iiif-universe repository), manifests are remain lists rather than being converted to manifests.  This does not happen for Villanova's collections, however, so I'm not sure what's up.
connection = open("https://graph.global/static/data/universes/iiif/stanford.json")
collection_json = connection.read
service = IIIF::Service.parse(collection_json)
service.manifests.first
=> {"@id"=>"http://purl.stanford.edu/bb389yg4719/iiif/manifest.json",
 "location"=>"Stanford University",
 "label"=>"Stanford University Libraries, M1814. Flat Box 2, Folder 02"}
[20] pry(ScCollection)> service.manifests.first.label
NoMethodError: undefined method `label' for #<ActiveSupport::OrderedHash:0x007f2a4260a978>

For comparison, the Yale manifests do convert successfully:
[21] pry(ScCollection)> connection = open("http://manifests.ydc2.yale.edu/manifest")
=> #<File:/tmp/open-uri20151006-13599-18bs854>
[22] pry(ScCollection)> collection_json = connection.read;0
=> 0
[23] pry(ScCollection)> service = IIIF::Service.parse(collection_json);0
=> 0
[24] pry(ScCollection)> service.manifests.first
=> #<IIIF::Presentation::Manifest:0x007f2a3c1d1ec0
 @data=
  {"@type"=>"sc:Manifest",
   "@id"=>"http://manifests.ydc2.yale.edu/manifest/DecretumMagistriGratiani",
   "label"=>"Friedberg, ed., Decretum magistri Gratiani "}>
[25] pry(ScCollection)> service.manifests.first.label=> "Friedberg, ed., Decretum magistri Gratiani "

I can get around this by avoiding dot accessors, but it may be of interest.  It's possibly that the problem is in Stanford's manifest and its failure to specify an @type property, and that this isn't an osullivan issue at all.

Not an OSullivan issue, but location in that data isn't a valid property of
a manifest. Do the other collections in the "universe" have this too?

I'll test the remainder of the collections as I continue to robustify the
FromThePage IIIF client.  So far, only Stanford has a bad manifest that
I've found.
On Tue, Oct 6, 2015 at 2:04 PM, Rob Sanderson<EMAIL_ADDRESS>wrote:

Not an OSullivan issue, but location in that data isn't a valid property of
a manifest. Do the other collections in the "universe" have this too?
—
Reply to this email directly or view it on GitHub
https://github.com/IIIF/osullivan/issues/49#issuecomment-145967008.


Add examples of how to construct the namespace and serviceaccount in docs

At a minimum:

GKE
EKS
terraform-kubernetes-helm
kubectl directly

Closing in favor of https://github.com/gruntwork-io/kubergrunt/issues/26


[Feature] Add deployment rules implementation

Short Description
Add deployment rules implementation.
Proposed Changes
Before plans are invoked, the new RulesChecker component checks if rules defined in a CSAR are fulfilled.
Rules can define, e.g., that an application can only be hosted on a specific hypervisor or a hypervisor with a specific endpoint and so on. Whitelist-Rules as well as Blacklist-Rules are supported.

Although, we could wait for the backend refactoring (using winery backend as the container backend) I approve this PR


PWM_Basic example fails to blink LED on Pico W

The Pico W's cy43 wireless chip takes over some of the GPIO and the LED and needs special handling.
I just tried this example and the LED doesn't blink.

HI @badger200
The example is only for general RP2040. While RP2040W is very different, by using LED @ symbolic pin GPIO32, which is controlled only by CYW43 chip
https://github.com/earlephilhower/arduino-pico/blob/master/variants/rpipicow/pins_arduino.h#L8
https://github.com/earlephilhower/arduino-pico/blob/aeb41f3e70628e63ed1cf13f2031cdaf61d65ad0/variants/rpipicow/picow_digital.cpp#L35-L49
Therefore, the PWM can't control the RP2040W LED.
Try to use a different pin and connect LED to it.

I did find a reference example from official Raspberry Pi GitHub: https://github.com/raspberrypi/pico-examples/blob/master/pico_w/blink/picow_blink.c
And it works on my Pico W, however I did not try PWM fading.

You really don't need that fancy code for RP2040W_BUILTIN_LED
Just use normal code with digitalWrite()
#define RP2040W_BUILTIN_LED       32

void setup()
{
  pinMode(RP2040W_BUILTIN_LED, OUTPUT);
}

void loop()
{
  digitalWrite(RP2040W_BUILTIN_LED, HIGH);
  delay(2000);
  digitalWrite(RP2040W_BUILTIN_LED, LOW);
  delay(2000);
}


fix FluxCD URLs

If your pull request concerns an existing Marketplace application, please make sure you have:

[X] Notified the Maintainer of the application in this pull request so that they are aware of your proposal.
[X] Outlined the changes you are proposing, and the reasons these are required (e.g. stability, compatibility with new versions of Kubernetes implementations, etc).
[X] Tested that the application works with the proposed updates applied (including a screenshot)

This is just a change which fixes the URL of toolkit.fluxcd.io to just fluxcd.io.
Test:
curl -Is https://fluxcd.io/install.sh
HTTP/2 200
accept-ranges: bytes
cache-control: public, max-age=0, must-revalidate
content-length: 5600
content-type: application/x-shellscript
date: Sun, 25 Jul 2021 18:13:47 GMT
strict-transport-security: max-age=31536000
age: 3260
etag: "910be6a0f291257fc5e2534e74d4b28b-ssl"
server: Netlify
x-nf-request-id: 01FBFH2FF51VCK26W15655FEGS

@stefanprodan this fixes #229 .

awesome thank you both :)


Dim selection error (maybe) when distilling

Let's see https://github.com/kshmelkov/incremental_detectors/blob/master/network.py#L59-L87
Say self.num_classes = 15, and  self.subnet.num_classes = 10, so we use logits = self.logits_for_distillation[:, :cached_classes+1] for distillation.
But wait, [:, :cached_classes+1]? It is 0-6 now,  rather than 0-11. Should we use 0-11 here?
def compute_distillation_crossentropy_loss(self):
        cached_classes = self.subnet.num_classes
        ...

def compute_distillation_bbox_loss(self):
        cached_classes = self.subnet.num_classes
        ...

I agree with youi @jinyu121


Does copo use "traffic light" and "communication" information as observation?

I mean the algorithm version in the paper.

No. They are completely useless in previous work.

Thanks.

@pengzhenghao Hi, I found that the experiment result of the parking lot in the paper is different from that in 《MetaDrive: Composing Diverse Driving Scenarios for Generalizable Reinforcement Learning》

I notice that the paper of metadrive claims "the result is based on MetaDrive 0.2.5 and is different to previous paper [35] due to updates in MetaDrive.". But I am still curious what makes them differ so much?
Actually, I tried to implement ppo for metadrive, but i got a very poor success rate in parking lot. The success rate is about 0~0.2.
Thanks.

i got a very poor success rate in parking lot. The success rate is about 0~0.2.

That's align with our benchmark result with 0.2.5:  https://github.com/decisionforce/CoPO/tree/main/benchmarks/MetaDrive-0.2.5
I probably will run new benchmark experiments to see the performance. My suggestion is, you can stick with the MetaDrive version you have and run fair comparisions between different algorithms.


Theme: IPv6 connection

REPOST: I think you misunderstood me in the previous thread. What I meant to say was when I switched to Gray theme and back to Authentic I got the same error. Everything seems to work fine with the default Gray theme.
It seems like when it is hosted on ipv6 some parts of the theme just stops working:
*On the dashboard the status numbers (cpu usage, disk usage and all those) just don't show up (https://puu.sh/tno00/e8fe886053.png)
*The theme settings manager doesn't show. (https://puu.sh/tnono/37a375dc23.png)
This only happens when I'm connected to webmin via IPv6. This is a fresh install so I'm pretty sure this isn't a configuration error on my end.
*Debian 8
*Firefox 50.1
*Host a server on ipv6 to reproduce

I don't think how it could be the theme issue.
I will try to reproduce it and get back to you a bit later.

I want to add that if the site is accessed via a domain (while still using ipv6), it seems to work correctly, which makes this even weirder. So this only happens if the server is connected directly with an ipv6 address instead of domain.

While I will debug it a bit later I have no idea how and why it would be related to the theme. Are you sure that it doesn't work in old themes? System Information Page in old themes is different but uses the same mechanism. Make sure that percent signs are also present when you switch themes.

What are the errors in the console?

This is the only one:
17:16:26.209 TypeError: g.data(...) is undefined 1 parent.min.js:6:3061 	__si__bg_upd_exec/<.success/< https://[2a06:e881:1503:110::1337]/unauthenticated/js/parent.min.js:6:3061 	.each https://[2a06:e881:1503:110::1337]/unauthenticated/js/bundle.min.js:2:2923 	__si__bg_upd_exec/<.success https://[2a06:e881:1503:110::1337]/unauthenticated/js/parent.min.js:6:1768 	bv.Callbacks/l https://[2a06:e881:1503:110::1337]/unauthenticated/js/bundle.min.js:2:28806 	bv.Callbacks/k.fireWith https://[2a06:e881:1503:110::1337]/unauthenticated/js/bundle.min.js:2:29588 	H https://[2a06:e881:1503:110::1337]/unauthenticated/js/bundle.min.js:2:79951 	.send/f/< https://[2a06:e881:1503:110::1337]/unauthenticated/js/bundle.min.js:2:82281

Did you try Chrome, out of curiosity? Did you try Incognito Mode?

Tried! Same result.

Are you using proxy?

Not on my computer or network. Via IPv6 the connection to the server goes directly to webmin, but for IPv4 it goes via an nginx reverse proxy, which forwards the request to Webmin's IPv6 address. This set up works correctly however. It does not matter if the request comes from IPv6 or not, it only happens when both no domain name was used and the connection was on IPv6.

I would need your setup to reproduce the problem.

Nope, you can completely ignore the nginx setup, because it is only for v4 compatability, which I normally don't use. Otherwise this setup is completely stock.

Any news?

I can't reproduce the problem yet.

Yeah, but why? Is there any specific reason?

I was working a lot of time on different parts of the theme. I will come back to your issue a bit later.

Okay, thanks!

I don't see the ports in your error message above, are you running behind proxy?

It doesn't show any ports because Webmin is running on default https port (443).

Just noticed something in the address in the error message https://[[2a06:e88x:150x:11x::1337]
Notice how there are two "[" marks where there should only be one.

What is the output of /etc/webmin/config?
You made miniserv to run on 443 and want browser to open it as default https connection?

I'm not sure if I know what you mean, but here's the output.

user@server:~$ cat /etc/webmin/config
by_view=0
passwd_cindex=2
find_pid_command=ps auwwwx | grep NAME | grep -v grep | awk '{ print $2 }'
passwd_uindex=0
tempdelete_days=7
path=/bin:/usr/bin:/sbin:/usr/sbin:/usr/local/bin
passwd_pindex=1
passwd_mindex=4
ld_env=LD_LIBRARY_PATH
passwd_file=/etc/shadow
os_type=debian-linux
os_version=8
real_os_type=Debian Linux
real_os_version=8
lang=en.UTF-8
log=1
referers_none=1
md5pass=1
theme=authentic-theme
product=webmin
webprefix=

Here's also miniserv.conf

user@server:~$ sudo cat /etc/webmin/miniserv.conf
port=443
root=/usr/share/webmin
mimetypes=/usr/share/webmin/mime.types
addtype_cgi=internal/cgi
realm=Webmin Server
logfile=/var/webmin/miniserv.log
errorlog=/var/webmin/miniserv.error
pidfile=/var/webmin/miniserv.pid
logtime=168
ppath=
ssl=1
no_ssl2=1
no_ssl3=1
no_tls1=1
no_tls1_1=1
ssl_honorcipherorder=1
no_sslcompression=1
env_WEBMIN_CONFIG=/etc/webmin
env_WEBMIN_VAR=/var/webmin
atboot=1
logout=/etc/webmin/logout-flag
listen=10000
denyfile=.pl$
log=1
blockhost_failures=5
blockhost_time=60
syslog=1
ipv6=1
session=1
premodules=WebminCore
server=MiniServ/1.831
userfile=/etc/webmin/miniserv.users
keyfile=/etc/webmin/miniserv.pem
passwd_file=/etc/shadow
passwd_uindex=0
passwd_pindex=1
passwd_cindex=2
passwd_mindex=4
passwd_mode=0
preroot=authentic-theme
passdelay=1
cipher_list_def=1
failed_script=/etc/webmin/failed.pl
logout_script=/etc/webmin/logout.pl
login_script=/etc/webmin/login.pl
sudo=1
sockets=
no_resolv_myname=0
bind=2a06:e88x:150x:11x::1337
certfile=/etc/webmin/miniserv.cert
extracas=
ssl_redirect=0
no_tls1_2=

I still have a feeling that it's not the theme related.
At first glance, why do you have port=443 and listen=10000 set at the same time?
What happens if you try to access your page using:
https://[2a06:e88x:150x:11x::1337]:443, does it change anything?

If I type https://[2a06:e88x:150x:11x::1337]:443 the browser removes :443 from the URL, because it is the default port for https and isn't needed. Looking at console again it looks like the extra [ there was just a paste error from me (sorry about that). The listen option is the port which Webmin will listen to broadcasts from Virtualmin, Cloudmin and other Webmin installs I think, due to the option in the GUI being labeled Listen for broadcasts on UDP port.

What if you set the port to 1234 for example and try using:
https://[2a06:e88x:150x:11x::1337]:1234 instead, what do you get?

It just gives me the same error in console (with the extra port number specified). Here's one line:
__si__bg_upd_exec/<.success https://[2a06:e88x:150x:11x::133x]:1234/unauthenticated/js/parent.min.js:6:1768 and the same visual error with no Authentic Theme things showing up.
Here's a full picture: https://puu.sh/uucz0/68f0f2dad5.png

I think I know what could be causing it.
The cause of the issue could be the browser's extensions. Try either incognito mode, or for instance, Chrome to double check. I remember there were issues like this, that were caused by browser's extensions  (addon's).

It's not.
Here it is in IE: https://puu.sh/uucXY/bfbcec4407.png

Tried Firefox incognito mode, I suppose?

Firefox in incognito mode loads all the addons I have (cuz settings lol), but yeah I've tried it. I've also tried it in Chrome stock. Same result in all browsers.

I have logged it as IPv6. Yes, there are problems on XHR requests. I will try to fix it upon 18.40 release.

However, I must admit that everything works great over IPv6 when not using proxy and connecting directly.
You connection is proxied most likely.

I have made some testing and sure now that it was noting to do with the theme. Please read: https://github.com/webmin/webmin/issues/505
It's partly related to https://github.com/qooob/authentic-theme/issues/652

Why do you keep ignoring me when I tell you the connection is NOT via a proxy. I have told you this more than once now.  Look at the response

Auth-type: auth-required=1
Connection: close
Content-Security-Policy: script-src 'self' 'unsafe-inline' 'unsafe-eval'; frame-src 'self'; child-src 'self'
Content-Type: text/html; Charset=UTF-8
Date: Sun, 5 Mar 2017 16:10:33 GMT
Server: MiniServ/1.831
Set-Cookie: redirect=1; path=/
testing=1; path=/; secure
X-Frame-Options: SAMEORIGIN
If you look in the Server header you can see it clearly comes from Webmin and not nginx, so please stop assuming the connection is proxied, because it's not.

To eliminate any suspicion towards SSL, I tried to disable that, but I got the same result. I honestly cannot see how this could be a problem with my setup. It might very well be a problem with Webmin and not the theme though, but as this only happens when using Authentic Theme I thought the best place to put the issue was here.

Oh, man. I didn't expect that. After signing in using IPv6 address only (without domain) I could reproduce all that you're saying for all XHR calls. (like dashboard and theme configuration and other).
Very surprising.
I'll work on it now as I see the problem..

Have a look:
http://stackoverflow.com/questions/40611863/ipv6-issues-with-ajax-requests

I got the reason why. Fixing it...

That's great! Was it related to the theme only or Webmin as a whole?

It was related to the bugged library for parsing URLs..
$_url.attr("path") returns "/sysinfo.cgi" on IPv4 and the IPv6 address itself on IPv6 connections. (hard to believe)
I didn't expect that happeing.. You can run $_url.attr("path") on the console to see what I mean. This is very hard to grasp unless you know what is going on.
Thank you very much for reporting. It's not related to the proxy, you're right!!

Oh yeah that's really weird! Thanks for looking into it and I'm glad I could help. :)

Please give it a try. It's checked.

I'm really glad to get rid of that old library. It should work now.
Please report here if you find any bugs!

Did you upload the webmin theme file or do I have to clone the repo?

Just clone it.

Works great now! Thanks :D

You're welcome.


[BUG] test_node_eviction_multiple_volume may cause undeletable volume

Describe the bug
e2e some times will have cascading error related to cleanup_all_volumes
It may due to test case test_node_eviction_multiple_volume. when test case fail, it may create undeletable volume like

To Reproduce
Steps to reproduce the behavior:

Setup longhorn master-head with 3 nodes
Install longhorn-test
run pytest -s -k test_node_eviction_multiple_volume --count 10
Once test case fail, it may generate volumes which can not be deleted

Expected behavior
Should haveconsistent result
Log or Support bundle
longhorn-support-bundle_fdc78c28-bd29-4700-bcb9-483cdca2c0b7_2022-07-22T08-49-26Z.zip
Environment

Longhorn version: manager master-head dc17cf
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): kubectl
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: k3s
Node config

OS type and version: ubuntu 20.04

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): 3

Additional context
https://github.com/longhorn/longhorn/issues/4066

cc @longhorn/qa

Is this issue just happening recently or actually happened before?

From https://github.com/longhorn/longhorn/issues/4066, the cascading fail caused by cleanup_all_volumes can be traced from May

@weizhe0422 Please check this issue to see if the test case/lib needs to adjust. Thanks.

Test case test_node_eviction_multiple_volume is stable and we did not encounter the cascading error for months


adding java sample

adding a java sample

@TsuyoshiUshio this is the sample you gave me that i've pulled in to the main repo. can you give it a quick review and make sure i pulled everything across that is needed.

I dont understand why you need the nuget package for the java sample. Or do you mean the maven artifact / jar file?

If you build the sample using maven, you will find target/azure-functions/kafka-function-xxxxx(some numbers) directory. That directory is the directory for Azure Functions. At that directory we need to install extension like
func extensions install --source <somewhere nuget directory> -p Microsoft.Azure.WebJobs.Extensions.Kafka - v 0.0.1-alpha-125

Now I'm using the artifact which is specified this document. https://docs.microsoft.com/en-us/azure/azure-functions/functions-create-first-java-maven Python implementation should do the same thing in somewhere. For the Java implementation, the directory is different. Since the directory is not deterministic (kafka-function-xxxx(random number), you need to script or some other stuff.

Ok clearly "you already experience it," is a big no :)
So, please if you can put together step by step guidance on how to build the sample and run the sample locally, that would be great.
I'll leave this PR open until we have this.

Sure. I'd happy to find sometime to write it. One question. Have you already publish the java library to maven repo? if so, the build process can be simplify it.

Not yet. Working on publishing this.

Hi @ryancrawcour ,
I wrote a md document for build/install/run.  You can download, review this link and change the extension from txt to md.  then review and add to your repo.
Readme.txt

@TsuyoshiUshio / @fbeltrao can one of you please review & approve this change. It's to add a Java sample to our samples.


feat: allow deep links in redirectTo validation

Please, can you add tests for the new schemas supported? Also, same for the go bit (file validation_test.go).


Build(deps-dev): Bump husky from 8.0.2 to 8.0.3 (#4512)

Pull request opened by the merge tool on behalf of #4512

Merged in 64e5ce0d8c9d85d21776fb81847148c35567a8c6


Error: Could not authenticate request

Environment details

OS: Windows 10
Node.js version: 8.11.4
npm version: 5.6.0
@google-cloud/storage version: 1.7.0

Steps to reproduce
var googleStorageCloud = require('@google-cloud/storage');
Object.prototype.GCP_upload_file=function (image_look_up_path, image_file_name, CLOUD_BUCKET, user_email, space, GCP_access_url, googleStorage, project_id,  callback)
{
       var fs = require("fs");
	var mime = require('mime-types')
	var mimetyp = mime.lookup(image_look_up_path);

			if (fs.existsSync(image_look_up_path))
			{
				console.log(JSON.stringify(googleStorageCloud));
				var storage = new googleStorageCloud
				({
				  projectId: 'XXXXXX',
				  keyFilename: './GCP_credential.json'
				})

				console.log(JSON.stringify(storage));
				var bucket = storage.bucket(CLOUD_BUCKET);
				var files = bucket.file(space+'/'+user_email+'/'+image_file_name);
				fs.createReadStream(image_look_up_path)
				.pipe(files.createWriteStream
				({
					metadata:
					{
					  contentType: mimetyp
					},
					predefinedAcl: "publicRead"
				}))
				.on("error", (err) =>
				{
					console.log("err : "+err);
				})
				.on('finish', () =>
				{
					console.log("url : "+`${GCP_access_url}${CLOUD_BUCKET}/${space}/${user_email}/${image_file_name}`);
				});
				return callback(null, `${GCP_access_url}${CLOUD_BUCKET}/${space}/${user_email}/${image_file_name}`);
			}

}

I am getting the following error when executing the above code  :
undefined
{}
err : Error: Could not authenticate request
Request failed with status code 404

It is not authenticating me. I have tried for @google-cloud/storage 2.0.0 also then it is giving
{}
TypeError: googleStorageCloud is not a function
    at Object.GCP_upload_file (D:\xxxx\routes\lib\constant.js:513:19)
    at Object.applyAndWait (D:\xxxxxx\node_modules\wait.for\waitfor.js:46:12)
    at Object.for (D:\xxxxxx\node_modules\wait.for\waitfor.js:62:21)
    at D:\xxxxxx\routes\v2.js:445:25
    at Array.map (<anonymous>)
    at D:\xxxxx\routes\v2.js:383:43
    at Array.map (<anonymous>)
    at handleGet (D:\xxxxx\routes\v2.js:346:34)
    at D:\xxxxx\node_modules\wait.for\waitfor.js:15:31

I have invested a whole day but nothing works. This code is running fine on node 6 and npm 4 but giving an error when I have upgraded the node version to 8.
Please help me to resolve this issue.

@ils-sapnaj Thanks so much for raising the issue!
With 2.0.0, you have to use the following:
var {Storage} = require('@google-cloud/storage');
If you want a specific variable name:
var googleStorageCloud = require('@google-cloud/storage').Storage;
For the authentication problem, could you follow these instructions for Client library authentication? Can you authenticate using the code snippet provided for Node.js? Sometimes the environment variable $GOOGLE_APPLICATION_CREDENTIALS isn't set correctly.

Thanks. It is working now.

Greetings!  If it's working with 2.0, we're going to go ahead and close this out.  If you're still running into issues with the new release... please do let us know!

Hi,
I am still getting the issue and error "Error: Could not authenticate request". Here is the system configuration :
OS: Windows 10
Node.js version: 8.11.4
npm version: 5.6.0
@google-cloud/storage version: 2.0.3
It was working fine with node version 6.11.2 and npm version 3.10.10.
Please help me out, I can't work with node 6, I need to upgrade but google storage package is not working.

Greetings @ils-sapnaj!  Can you please open a new issue?  Make sure to include the code you're using that leads to the error please :) Also - if you could share your package.json that would be super helpful.


fix: update to eye v4.14.9

:tada: This PR is included in version 6.5.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v6.5.5

Your semantic-release bot :package::rocket:


Remove older emit support over time

Suggestion
🔍 Search Terms
remove emit target es3 es5
✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
Following #47572, once the default target has been raised to a new value, can TypeScript remove emit support for the no-longer-default old version in either that same major version or the next one?
Using the example schedule in that issue:

Remove es3 emit support for 5.0, making es5 the lowest supported emit target
Remove es5 emit support for 6.0, making es2015 the lowest supported emit target
...and so on

📃 Motivating Example
Supporting emit to low emit targets such as ES3/5 worsens:

Dev cost for some TypeScript features: e.g. #29374's changes were mostly in emit
Output package size: e.g. src/compiler/transformers/es2015.ts has >4k lines today (about 10% the size of src/compiler/checker.ts)

💻 Use Cases
It'd be nice to have a leaner TypeScript without the cost of supporting emit for syntax compatibility the vast majority of runtimes no longer need.

[x] This feature would agree with the rest of TypeScript's Design Goals.

You should remove the check from this point. See goal 11.
Also note that TypeScript does not follow SemVer.


Update first_steps.md

Fix the description of missing access permissions to include the permission prompt.

@PoignardAzur If you have time, could you also try change the url in that example. The url now redirects to https://deno.com/. So deno also asks net permission to deno.com, but that feels a little confusing as the first example.
I think we should use some url which doesn't include any redirects.

Will do.


MTO Entities Database Diagram

This is version two of the DB diagram for MTO and other related entities. This was created using the tool dbdiagram.io. You can find the specific link here: https://dbdiagram.io/d/5db7168afa792a62f50d9625
To identify the kind of relationships the tables have with each other, note there is either a 1 or a * at each end of the line connecting two tables together. 1 stands for one and * stands for many.
This was worked under the assumption that customers would be a renamed service_members table. Also I didn't put all the fields on already established tables within the diagram. I only placed what seemed relevant to MTO entities. I believe the only information I'm truly missing is where electronic copy of orders, travel authorization issuing HQ, and data the PRIME will add to the MTO.
There is no longer an entitlements table. This has been absorbed into the orders table as it was noted that this table already had properties indicating information pertaining to entitlements such as has_dependents and spouse_has_pro_gear. It made sense to me to expand the table rather than introducing a new one.
Another change is that there is no longer an origin_duty_station_id and customer_id on the move_task_orders table. This information was already provided by the parent models to MTOs and it was pointed out to me that this meant we didn't necessarily require that data on MTO.

I'm not sure what level of review you're looking for here, but the service items table is likely to be set up differently than what is in this diagram. TTV will be tackling that soon. Additionally, your PR description says, "customers will be renamed to service_members". Is that correct, or is it the other way around? I thought we wanted to move forward with "customers" as our new terminology.

I wrote would be renamed from customers to service_members. That's alright if the service_items is likely to be set up differently. I expect this diagram to be constantly changing until we get a MVP.

Closing this as a new story will capture changes needed to be made in light of the news from the latest demo.


Filtering task

This PR is used to fix #2

Task-flow
Guidance

Let's call March 15th a day now.

Looks good! Merging!


Revert "Replace use of domifaddr with ip neighbour"

Reverts openstack-k8s-operators/ci-framework#1571
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] README in the role
[x] Content of the docs/source is reflecting the changes

@hjensas
This PR destroyed all the hybrid setups we run for NFV, manual based ones and the automatic approach.
There is a tremendous difference between what we had and what that PR did, mainly:

We now assume that all libvirt networks has IP, what's mostly false in hybrid setups were all interfaces are bridges configured externally (by the dev-scripts role) using NNCP.
We are not getting rid off the VIPs of the OCP https://github.com/openstack-k8s-operators/ci-framework/compare/main...revert-1571-drop-domifaddr-use?expand=1#diff-1059986073513794e4ab8d8dc31f2021be27c61feda9a263650d1d75197c17afR33-R38
We assume that the first network is the public one. What's public? That "concept" made sense in the regular fully virtualized HCI VA, but the architecture repo is showing new VAs that are far from that "ideal" scenario.
Even if all the networks are not bridges, the content of the cifmw_hosts_ports is just crap, as it's based only on the content of the first libvirt network.

/approve
/override rdoproject.org/github-check
Override since it seems molecule on ci_gen_kustomize_value needs a bump following split dataplane changes

* We assume that the first network is the public one. What's public? That "concept" made sense in the regular fully virtualized HCI VA, but the architecture repo is showing new VAs that are far from that "ideal" scenario.

* Even if all the networks are not bridges, the content of the `cifmw_hosts_ports` is just crap, as it's based only on the content of the first libvirt network.

I agree 1000% that a network being public is some opinionated thing that only makes sense for specific architectures.
BUT, I fail to understand how my change has anything to do with that?
Both prior to, and after my change the loop was only for the public_net_nics - which is the NICs on the network matching the name defined as in cifmw_libvirt_manager_pub_net.
 selectattr('network',
                   'match', '^(cifmw-)?' ~ cifmw_libvirt_manager_pub_net)

- name: "Grab IPs for nodes type {{ vm_type }}"  # noqa: risky-shell-pipe
  register: vm_ips
  ansible.builtin.shell:
    cmd: >-
      virsh -c qemu:///system -q
      domifaddr --source arp
      cifmw-{{ nic.host }} | grep "{{ nic.mac }}"
      {% if cifmw_openshift_api_ip_address | default(false) %}
      | grep -v "{{ cifmw_openshift_api_ip_address }}/"
      {% endif %}
      {% if cifmw_openshift_ingress_ip_address | default(false) %}
      | grep -v "{{ cifmw_openshift_ingress_ip_address }}/"
      {% endif %}
  loop: "{{ public_net_nics }}"      <<<---- LOOP ONLY ON "{{ public_net_nics }}"
  loop_control:
    loop_var: nic
    label: "{{ nic.host }}"
  retries: 20
  delay: 5
  until:
    - vm_ips.rc == 0
    - vm_ips.stdout != ''

    public_net_nics: >-
      {{
        (public_net_nics | default([]) + _macs) |
        selectattr('network',
                   'match', '^(cifmw-)?' ~ cifmw_libvirt_manager_pub_net) |
        selectattr('host', 'match', '.*' ~ vm_type ~ '.*')
      }}


Synthetic PoRep support

Synthetic PoRep  support is a bigger task. But I thought I start the conversation.
Deriving challenges
Deriving challenges for Synthetic PoRep is different from the current PoRep. You can find a spec in the link to the FIP provided above, if you prefer code, it can be found at https://github.com/filecoin-project/rust-fil-proofs/blob/8ce806eebba0dbba2928d34b69ed4d875397cf7c/storage-proofs-porep/src/stacked/vanilla/challenges.rs#L182-L374 (and is pretty self-contained).
In case you code something and want to see if it matches our implementation, you can have a look at the challenges-synth binary in the rust-fil-proofs proofs-bin branch. For 32GiB sectors a run would look like this:
echo '{"comm_r": "0x00112233445566778899aabbccddeeff00112233445566778899aabbccddee00", "num_draw_challenges": 262144, "num_generate_challenges":<PHONE_NUMBER>, "replica_id": "0x00112233445566778899aabbccddeeff00112233445566778899aabbccddee00", "sector_size":<PHONE_NUMBER>8, "seed": "0x00112233445566778899aabbccddeeff00112233445566778899aabbccddee00"}'|RUST_LOG=trace cargo run --release --bin challenges-synth

Serialization
The serialization format is also different, but it's well documented.
Where to start
For me it would be great to have something I can call from Rust as soon as possible. I can use the challenge generation in Rust. So for me it would be great if I would get some API exposed to extract the proofs based on a challenge. Even if it's hacky and might be changed/removed in the future, it would help a lot. That would likely also include the serialization. So the ideal call for me would be something that takes the sector and a set of challenges and writes those to disk serialized in the correct format.

Based on the meeting yesterday, here's what I'd need to get things running:
An API I can call from Rust to extract the Merkle proofs. I would imagine it would take the challenges (the offsets) I'm interested in, it would then returns the corresponding proofs of all trees/labels.
As passing data from/to Rust might be a lot of work, I suggest that it just writes the results into a file in the same format as the Rust implementation does. You can find a description of the format at https://github.com/filecoin-project/rust-fil-proofs/blob/master/storage-proofs-porep/src/stacked/vanilla/params.rs#L431-L450.

As passing data from/to Rust might be a lot of work, I suggest that it just writes the results into a file in the same format as the Rust implementation does. You can find a description of the format at https://github.com/filecoin-project/rust-fil-proofs/blob/master/storage-proofs-porep/src/stacked/vanilla/params.rs#L431-L450.

I just found out that you are already able to write a commit-phase1-output file that I'm able to read on from Rust.. So as a start, it would work if you write a file in that format, just with more challenges (as SynthPoRep demands it). I can then take it from there.

To make this more concrete (sorry, I discover as I go that things are even simpler then I thought). I'd like to have an API where I pass in the challenges (the offset) and it writes out the merkle proofs at those offsets.
It would make sense to use the serialization linked above, as it's way smaller and omits some of the things that are not really needed for C2.


Need to contact you

Hello i'm trying to get in touch with you please respond

You can leave a message at the support email (see store listing). Otherwise feel free to open an issue if you have a specific problem or request.


Make it possible to only print summary instead of entire report

Create an option like --print_report, maybe --print_summary

Console already prints summary at the end of a report if that is needed. Workbench will be able to take care of the rest of the use case this would solve.


Rename README to README.md

Rename README to README.md so that the documentation site would process markdown properly.

.


网络模型tf2实现

默认的三层网络
添加graph到tensorboard

添加graph到tensorboard move to: https://github.com/iminders/maddpg/issues/15


Binder set up

I just added the configuration files in order to run Binder. I tested the examples in my forked repo and they worked (except for the example I reported in issue #38 ), you can test the examples using the following path https://mybinder.org/v2/gh/RaulPL/dowhy.git/binder_set_up.
The rest is to add the path to the repository in  mybinder copy the badge and paste it on the README.md. It will look something like this:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: RaulPL sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

this is great, @RaulPL ! Merged your commits and updated the readme.
Thanks also for catching the missing dataset link in ihdp analysis. Will work on adding it.


Unexpected error caused by floating point literals

let x:FStar.Float.float = 1.0 gives the error
Unexpected error; please file a bug report, ideally with a minimized version of the source program that triggered the error.
[F* error] Unhandled constant: 1.000000

F* really has very little support for floating points, except it seems in the parser.
I suggest we disable support for floating points in the parser so that we don't just blow up in the rest of the code.
Then, let's actually figure out how we want to support floating points properly.
@karthikbhargavan you've been talking a bit about verifying floating point libraries etc. That's a much deeper topic than what's here so far. But, perhaps we can use this issue to figure out ambitions for floating points in general.


UI Suggestion (would help me :) ) - confirm dialog for replace "all" when find is multi-file

Twice now I've clicked "All" by accident when I thought I was setting the find scope to be "no top" which is a similar concept.
I was searching for "key" and it took several minutes minutes for all of the replacements, 21 files were edited!! Screen after screen of find/replace went by!!
LOL

yeah I agree -- easy to add and shouldn't be that obtrusive to the user as the All option is relatively rarely used.

ps should be a gide issue..  done.


Where are we incorporating?

Also, Delaware has extremely lightweight paperwork requirements, and reducing routine paperwork is a good thing.


Add safety check in DrawNuklear()

Fixes #68

@alexlnkp Doing this does add another call to each render loop, but I think it should be okay? Mind testing?

Works like a charm! The extra check for safety each render call is a bit sad but I think it's better this way (kind of like a check if malloc fails, it's sad but you need to do it)


Random quote generator

It will generate quotes randomly and post that quote in social media like twitter etc.

I want to work on this under GSSOC21.Please assign to me

Hi @gupta31  You can go ahead with your creation.☺☺

Thanks @harshgupta20 😊

Hi @gupta31 , We have found that this issue is already solved, Kindly raise the issue which is not present in the project and if you want to add some features then you can raise the issue on that dynamic random quote generator.
Happy Contributing.


Move azure-synapse-artifacts to preview

Learn Build status updates of commit 2d19b59:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

ci-configs/packages-latest.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit d6fcdf7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

ci-configs/packages-latest.json
:white_check_mark:Succeeded

ci-configs/packages-preview.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


[11.x] Make file size validation support binary unit sizes

Add file size suffixes KiB, MiB, GiB and TiB to 'toKilobytes()' method of 'Illuminate/Validation/Rules/File.php'.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.